Router navigate does not work from child controller

If I try to inject and use the router in a child controller to navigate my app from JS, router.navigate does fail silently.
Relevant code from this plunk (file components/login/login.js)
        function ok() {
            auth.login();
            // how to go to a specific route here?
            // injectting the router and use router.navigate("/someroute") does fail silently
            $router.navigate('/'); //this fails.
            // it also fails if I put it in a setTimeout as in Appcontroller!
        }

Am I using the wrong approach here?

I could be wrong but I think a router is designed to only route to components within its own or child's definitions because it should not be aware of its parent router config (to make sure components are truly composable).
To be conform with the Angular 2 component guidelines, you should emit an event from your login component saying that login failed and then the parent component can listen for that event and act accordingly (e.g. route to another url within its routing config).
So I think the $router.navigate('/') doesn't fail but resolves successfully because it can't find a component that matches the url.
Have you tried attaching a success handler like this:
$router.navigate('/').then(
  function(){
    console.log('navigate success');
    console.dir(arguments);
  },
  function(){
    console.log('navigate failure');
  }
);

I would gladly try it myself but I'm getting plnkr errors here.

@jvandemo, I did put in the .then (wondering why I didn't think of this..). It becomes even stranger, as it fires the resolve function.
A router should be able to navigate the entire application. Think about this, you are 5 levels deep into a route, done doing whatever it was, and you need to present the user a choice for his next action. It would be extremely limiting if you can jump only to the siblings in there, in stead of any point in the app right?
There are some "special" navigation issues just as 1-level up, or go to next sibling. I'm not sure yet how this is gonna play out in ngNewrouter tough.

@SanderElias — I think it makes sense in the new tree structure for Angular apps.
If you watch Misko's talk carefully (https://www.youtube.com/watch?v=-dMBcqwvYA0) it should take away a lot of the confusion.
It definitely requires a shift in thinking (I wrote down some personal thoughts here in case you're interested) but I think it makes a lot of sense if you look at things from a broader perspective.
If you think of an Angular 2 app as a tree of components, then you should be able to plug in a well designed component at any point in that tree.
Suppose that your component routes to a component or url that is out of its own scope (higher in the tree), then the component would no longer be reusable in other scenario's because it would require that the other application has the same url available in its tree.
So to make components as reusable as possible (allowing you to insert them at any point in your tree), you have to stick to the guidelines Misko talks about: if you want to let your component provide output, emit an event so the app itself can decide whatever it needs to do (and not your component).
Does that make sense?

@jvandemo I still disagree with you.
Let me sum up some of my counterarguments. (I have more, but only limited time ;))

You assume I write those like by hand hard into the template. Often this is not the case, so your argument that you create a dependency that way is falsy...

Also, if you work in a certain way, you can be relatively sure some routes are always available. For example, a route to /login. I'm pretty sure that is is every app! For certain it is in your app if you have an component that needs it!

No matter how generic your components are, they still will have dependencies, and some of that might just be a certain application structure.

Inserting a component in between you application structure might sound like a valid thing to do. But an application is much more then a string/tree of components. At least it is a careful layout system of components in a certain order, and if you need to make changes that, you are talking about a mayor re-factoring anyway! Composability is nice, but it won't stretch that far. I can go into deep discussions with you on this, but that's beside the point of this thread. Meet me at one of the Dutch Angular group meetings, and we can do just this ;)

Events have their place, but lack the level of control you need in a router.  Lets say you are in need of transport, and solve that the event way. That's like walking outside, raise your hand an call out "YO, TAXI", which will work quite nice if you are in the center of a big city (and even there is will occasionally fail!), but is pretty useless everywhere else!

I'll just leave it by that for the moment. An router should be able to route everywhere, both relative and fixed paths.

@SanderElias — Thanks for sharing your thoughts.

I still disagree with you.

These are not guidelines I invented. They are part of the upcoming web components standards.
I understand your reasoning and it is fine if you don't want to adhere to them to build your own applications. But if you want to follow the web components standards, it's a whole different ball game.
The Angular team has chosen to support the web components standards so they have to make choices to support that, even though you may not personally agree with them.

You assume I write those like by hand hard into the template. Often this is not the case, so your argument that you create a dependency that way is falsy...

Not sure what you mean with "those". Can you please elaborate on this?

Also, if you work in a certain way, you can be relatively sure some routes are always available. For example, a route to /login. I'm pretty sure that is is every app! For certain it is in your app if you have an component that needs it!

I don't agree. What if the same route was called /inloggen in a Dutch app. Your component would be useless.

No matter how generic your components are, they still will have dependencies, and some of that might just be a certain application structure.

From the web components standards:
Imagine that the set of approximately 100 standard HTML elements were augmented with an optional library of 100 more elements for everyday use. Is your component a plausible candidate for that set? That’s about how general the component should be.

Composability is nice, but it won't stretch that far.

Being composable is part of the core principles of web components standard.

Events have their place, but lack the level of control you need in a router. Lets say you are in need of transport, and solve that the event way. That's like walking outside, raise your hand an call out "YO, TAXI", which will work quite nice if you are in the center of a big city (and even there is will occasionally fail!), but is pretty useless everywhere else!

That's because you are assuming your app has taxis. Ideally your component should emit an event that says: "hey, I want to go from A to B" and your app should listen and act accordingly.
 Your component shouldn't know (and care).
That way you could reuse your component in another app that doesn't have taxis.
I understand your reasonings and there is indeed a large difference between building a reusable component and a component that you will only use in one app, but if Angular wants to support web components, then that's probably the way we will have to be thinking in Angular 2, which the router is ultimately designed for.

@jvandemo Thanks for your thoughts.
If you look over the talk you linked in, you will notice that Misko answers the question, why not just switch over to polymer. His answer boils down to what I said before. Web components are neat, and we will support those, but we still need angular for other things that are not covered by web-components.
And supporting one thing, does not mean you take over all properties and behaviors right?
A quick example, it might sound far-fetched at first, but think it through.   I support doors. They are all around me, and I use them a lot. I don't like their interface, and occasionally bump into one. If it was up to me, I would change the interface so the door would recognize me, and open all by itself.
Heck, I can even build that by myself. Maybe I can even afford to change all the ones in my own surroundings. See where this line of thinking strands?
Then there is this viewpoint. As I support doors, should I use the same interface myself? And demand that same interface on everything else? sounds a bit unpractical to me.
While this example is just plain silly, do you see the point I'm trying to make?

Not sure what you mean with "those". Can you please elaborate on this?

Those are the routing links that I got from somewhere else. I don't need to hard-code those links in my components. I can fetch the routing-links I need from anywhere. Even from yet another nested component ;)

I don't agree. What if the same route was called /inloggen in a Dutch app. Your component would be useless.

Sure, that is why you don't use hard-coded links in the first place, that a route has a slightly different name, doesn't mean it does not exists right?

Being composable is part of the core principles of web components standard.

That makes sense in the web components standard. However, there comes a time you need to use those components right? Let me sketch you another analog. I mentioned a door before. A door is a component of a house, as are brick and mortar, studs and  so on. However to build a house you need a bit more as just its components. You need a building plan. Then you need people that implement that plan. Those people will make sure your components will fit together well. Then you need some inspection rounds. And a whole lot more. (you know if you ever build a house!) Sure you can build a off the shelf one, but are you sure that fits your needs as tightly as you would like? There will be trade-offs. Some can be fixed. Others will be out of reach for technical or other reasons. (there is only so much money one can spend, there are building regulations.)

That's because you are assuming your app has taxis. Ideally your component should emit an event that says: "hey, I want to go from A to B" and your app should listen and act accordingly.

Euhm, no I'm not.  You need that control for routing, or you will have an usability issue in your app.

@jvandemo This came to mind just now, and I could not resist posting it here! it's kind of relevant to our little chit-chat ;)
Angular is to a application designer what Autocad is for an architect. A tool that helps to lay out the components into a complete structure. It also helps out testing the structure.

@SanderElias — I understand your reasoning and I am not claiming anything, nor trying to argue against you.
I am trying to deduce how things will work by reading the source code of the new Angular router and putting them in an Angular 2 perspective.
From what I can see (I could be wrong) the current code does not allow a scenario that you describe.
We have to keep in mind that Angular 2 is radically different and that the new router is designed for Angular 2, even though it's made available in Angular 1.x.
Maybe there are plans to support a scenario you describe. Maybe not. And if not, it's important that we all understand why and how we should implement things correctly.
One of the solutions could be the scenario I sketched in the comments above (again, deducing from reading the source code and listening to Angular core members).
I'm sure things will clear up more as soon as newer updates and documentation become available.

@jvandemo I happen to like arguments ;) I like to dig deeply into stuff, and i always respect my counter partners in these things. You can convince me, but not easily. On my turn I will try to convince you too ;)
I have read the entire code of the routing system, all the docs, and I'm playing around with it since the first workable version. I like what I see, and as far as I can see it, my scenario is entirely possible. If not, this would hugely surprise me.
And even if the router doesn't support it by itself, there is always $location, or even window.location.
That would be ugly as hell, but it will work.
I'm pretty sure @btford would not force me to write that sort of code, right @btford? ;)

any news ?

@nadavten Not on this repo, this is the first 'new' router. We are now on the 3rth iteration, in another Repo, see this blog.


Enable disable failed tests in adoptopenjdk tests

Add local ProblemList.txt to exclude test failed in adoptOpenjdk build.
Example as:
# issue 107 jdk_io: java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java fail
java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java	generic-all

Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

Failure tests without issue will need to open issue then add to ProblemList.txt per platform to make test build green.

If I recall, the format of the problem list allows you to put the issue number in the exclusion line, as in:
java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java	107 generic-all
Is that no longer the case?  I like additionally the comment, and how they are grouped in the file according to the groups we are running.  Approving, but am interested if the format changed (no issue number needed, as we kept the same approach in FV tests elsewhere).

Openjdk8 problem list format with issue on separate comment line
issue 107 jdk_io: java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java fail
java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java	generic-all
Openjdk9 problem list format with issue number in the exclusion line:
java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java 107 generic-all
Double checked openjdk9 format works with openjdk8. Updated ProblemList.txt.
Thanks for reminding!


Issue 111 webhook invocation fails for for empty started config

Mostly looks good, I'd like @maheshkelkar to review as well before merge

:+1:


solving issue #26: https://github.com/spring-cloud/spring-cloud-zooke…

spring-cloud-zookeeper-config/src/main/resources/META-INF/spring.factories still references to
org.springframework.cloud.zookeeper.config.ZookeeperConfigBootstrapConfiguration but it was refactored to org.springframework.cloud.zookeeper.common.ZookeeperConfigBootstrapConfiguration. Applications depending on spring-cloud-zookeeper-all are failing with error "ClassNotFoundException" at runtime. Please provide fast support.
Caused by: java.lang.ClassNotFoundException: org.springframework.cloud.zookeeper.config.ZookeeperConfigBootstrapConfiguration
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.LauncherssLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at org.springframework.util.ClassUtils.forName(ClassUtils.java:250)
at org.springframework.util.ClassUtils.resolveClassName(ClassUtils.java:284)
... 14 more

Closed in favor of f58a36ef27736337859d0b089994f68e4913643d.  Moving those classes to the common package was a mistake.


Update to activemq 5.16.0

There is a problem with OSGi - https://issues.apache.org/jira/browse/AMQ-8009

I've submitted a PR to AMQ to fix the issue with Spring - https://issues.apache.org/jira/browse/AMQ-8009


Upgrade gcc to fix issues with missing stdatomic

A library that I depend on uses stdatomic.h, which is missing from gcc 4.8. See https://stackoverflow.com/questions/20326604/stdatomic-h-in-gcc-4-8 for details.
I've updated the Dockerfile to install a newer version. I've verified this fixes my issue.

Sorry for late reply...🙏
Yeah, There is no problem. merging.
P.S.
What do you think, If we configure the base image like...
Hexavillefile.yml (If your application depends libimagemagick)
docker:
  baseImage: myrepo/ubuntu-imagemagick:1.0.0 # custom image should extend ubuntu:14.04

package:
   # can package system libraries that you want to link on lambda.
  dynamicLinkLibraries:
    - /usr/local/lib/libimagemagick.so

Thanks for the merge. I like your idea for Hexavillefile.yml, that would be really cool!


Relabel units after scaling by mask_and_scale

Issue found while merging develop_satellite branch.
Comment from @colin-harkins
As far as I can tell there is no relabelling of self.obj[v].units associated with using unit_scale_method. I agree that it would be good to implement something like that eventually but currently I don't see where self.obj[v].units would change when using unit_scale_method, so this if statement would run even if the unit_scale_method section above it has also run.

The read in scripts goal aims to read in:

gases in ppb
aerosols in ug/m3

If arbitrarily scaling using unit_scale_method, need to change the units metadata to include "scaled by XXX"
e.g.
if you scale by 100 and original units are in ppbv
Then the dset[i].attrs["units"]
"ppbv" -> "ppb scaled by 100"
if no units then
" " -> "scaled by 100"


Clarify direct:/// prefix of replyTo property

To implement a proper solution.

RabbitMQ .NET Client
Direct Reply-to

That was the Contour issue.


test: fix for Windows

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test and merge

@swift-ci please test Windows platform

@brentdax - that sounds like something that @shahmishal should look into (could you please file a radar?) - you should be able to trigger those

@swift-ci please smoke test Linux platform

The Windows failure is going to be addressed by #29967, merging to improve the state


Speaker Indentification from Scratch

Hello people!
First of  all, congratulations for this wonderful work.
I need your help, please.
Contextualizing here:
I'm studying the speakerIDfromScratch script (research work). I'm working with  audios of 15 seconds in duration (aprox.), railway environment, 48 speakers (number of classes),  etc. I'm, also, using ECAPA_TDNN, custom_model.classifier (I tried to used: ECAPA_TDNN.Classifier, but it gave me an error), etc.
So I have the following questions:

I thought of adding the following settings (add_rev; add_noise; add_rev_noise; etc.), would it be the correct way?

My current configuration is: train.yaml.
Nota: I'm wanting to add the maximum number of parameters settings, in such a way that I can get a "real" road environment. It is important to say that I am training with audios (48 speakers, approx. 800 audios in total) that were recorded in a noise-free environment. What other parameters can I modify or add in train.yaml?

How can I make the inference, to be able to identify the speaker who is speaking? with "real" audio? in which the AUDIO has 4 or more parts and in which there are different speakers in these parts (usually there are two speakers).

Would I have to calculate the embeddings for each piece of audio?
Thank you very much!

Hi @EddyGiusepe hope you are doing well. There are a lot of questions ;-)

I thought of adding the following settings (add_rev; add_noise; add_rev_noise; etc.), would it be the correct way?

What is defined in the yaml files also needs to be picked up by your training recipe. Just declaring it in the yaml file might instantiate the objects add_ref, add_noise, and add_rev_noise - but that's not guaranteeing that they are used at all during training or in the way one intends for it. @mravanelli  wrote a consistency testing PR, please take a look. It might help you in developing your recipe further. You'll see there in the noise corruptions for the VAD recipe, which are similar to yours, that we needed to take some definitions out of the yaml file since the training recipe did not pick up on them (the PR will be merged soon).

I'm wanting to add the maximum number of parameters settings, in such a way that I can get a "real" road environment.

I don't have expertise for that maybe - @pplantinga ?

How can I make the inference, to be able to identify the speaker who is speaking? with "real" audio? in which the AUDIO has 4 or more parts and in which there are different speakers in these parts (usually there are two speakers).

Sounds like a PR you could contribute ;-)

What is a "part" for you?
For multiple speakers in one audio, please look into "speaker diarization" - usually people fix the number of speakers, which is a way to adapt to their datasets - depends on the use case scenaria
"Real audio" as in non-lab audio?

Would I have to calculate the embeddings for each piece of audio?

By rewriting your script in a way that does so. The questions you raise have been part of ongoing research discussions - there are some fully online research archives like this one - Interspeech proceedings are a good entry point for study.
@underdogliu what's your take?

Thank you very much @anautsch for starting this discussion, I hope to continue discussing with you and others researchers.
Then:

When you speak of "training recipe" you are referring to the "train.py" (meu train.py) file, right?

Thanks for these links (Thanks, also, @mravanelli): consistency testing PR and noise corruptions for the VAD recipe. I've already started reading these links and I'm looking at how I can use this for my task.

If I evolve, develop, in this challenge I would like to contribute (it's an honor).

"part" --> mean, that in each audio I always have excerpts (or I called: "parts") of speeches which correspond to different speakers (usually in these audios I have two speakers), did you understand?

I commented this because when I go to pass the audio to detect the speaker... I will pass a raw audio (that is, an audio where there will be two speakers, with noise, etc. Remembering here: I trained until only with audios where there is only one speaker with their respective identities, did you understand?

I thought about DIARIZATION, to separate the audio excerpts (or calculate the embeddings of each audio excerpt or excerpt that will contain only one speaker)... I'm still not quite sure how to do that :( .

Real áudio --> it is the same audio that is used in the work field (in the highway field). With noise, speakers speaking fast, slow, with echo ( reverberation), etc.

I will see and study, too, this link.

I'll be back soon with some improvements, etc.
Thank you very much!!

Thank you, @anautsch, yes yes ... I'm very happy to be learning this line of research.
Then:

With respect to those recipe files, it was clear yes. Thank you!

I know where these files are located for consistency. But unfortunately, I'm not able to run the consistency test (I'm working on Google Colab: consistency_test_file) ... could you give me a suggestion here?, please!

Yes.  So, I'm training with 48 speakers, of each speaker I have 20 audios, each audio is 13 seconds aprox. (Also, I know their identities).  You can send these books to me ... I will try to study in parallel. Thank you!

Good questions! ... I still have doubts about it. In principle I know that for a raw audio I should have the separate parts (or the embeddings) to later compare each "part" with the Database that I have already "trained" (maybe I can apply COSINE SIMILARITY ) . I need to study more about this part. For starters I'm focussing on this script. Since this script has an INFERENCE part ("Use the EncoderClassifier interface on your model").   In this part, also, is possible to calculate the EMBEDDINGS ... so I thought of comparing the embeddings of the new audios with my Database, already trained.

So, I have a Database yes. But they are very few (I will try to collect more Data). There is no Data related to my task (railway environment is very complex). Due to this difficulty (few Data, noisy environment, distorted speech, etc) I am trying use AUGMENTATION (I'm using the model pre-treined with VoxCeleb).

Aqui a minha configuração: train.yaml . If you can give me some suggestions, I would appreciate it!
** In that train.yaml file, I am still thinking how to use the ECAPA_TDNN classifier.
I'm making little progress little by little :)
Thank you very much!!!

I closed unintentionally :(
Hello @underdogliu!!!
Quiet.

I would like to be able to discuss more how you make the inference. I will look for this author Kaldi to know more about this part. So, in this first part I'm using the SpeechBrain script to make some inferences. I'm still training the script with my Data. Obviously, this inference I make is only with an audio that has one speaker (I'm still studying how to make the inference for a real audio). I would like to discuss this part with you to see how you make this inference. Thank you!

Yes yes ... this issue of Embeddings is, also, on my mind.

Thank you so much, @underdogliu !

Hello @anautsch!

I will do this consistency test.

I'll look for those books yes, thank you!

I have little data. But, I'm already trying to get more Data for my training. I'm applying Augmentation and I'm also adding noise, velocity, revorbation, etc. I'm currently training the Network and my test_erro~5%, but when making the inference... the network makes a lot of mistakes.
My train.yaml (I think there is another way to do these settings):

Yes, the numbers of speakers is two in each piece of áudio, I know the identities at the time of Training (each one has an ID) ... Yes, I thought of using a Pre-trained model. If you have a study link, please send it to me. I will be careful with the question of: "Data sharing".

Alright, let's go on this challenge.

Are you on our slack? --> No, not yet.

Thank you so much!

Make sure to use the env_corrupt in the train.py file. Check for a set of audios which are the noise effects you'd desire to have. Look at the training data of a pretrained model. Which data augmentation would be necessary to transform them into your environment? Maybe it is enough to retrain a pretrained model based on in-domain data augmentation. You won't need to corrupt audios that are already in-domain (unless to see if there's some performance gain because of a nature of the data your model is not encompassing by its design).

Hello @anautsch !
Sorry for answer now. I'm still focused on training SpeakerIDfromScratch.

Yes, I'm taking your observations into account. I'm using a pre-training model since I have little Data.

I have a question:  How can I calculate the ROC-AUC Curve ou the Confusion Matrix?  I think the ROC curve is not possible, right? ... because I have 48 classes (speakers), right?  Is there any script where I can add or modify the code to get this?

Thank you very much!


cpu.cfs_quota_us: permission denied

When trying to start a scales (https://github.com/PufferPanel/Scales) docker container, I am getting the following error.
cmd: docker start pp-tf33_ry5bcxf
Error response from daemon: Cannot start container pp-tf33_ry5bcxf: [8] System error: open /sys/fs/cgroup/cpu,cpuacct/system.slice/docker-6f2a7ce736c6c1ea55f036638211a9a73a1df8ab3e31cc117532f359099eb3b3.scope/cpu.cfs_quota_us: permission denied
Error: failed to start containers: [pp-tf33_ry5bcxf]
=================
docker image used:
https://github.com/PufferPanel/docker-images/tree/master/srcds
=====
Physical Box
uname -a:
-Debian Jessie - 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1+deb8u5 (2015-10-09) x86_64 GNU/Linux
docker version:
-Docker version 1.8.3, build f4bf5c7
docker info:
Containers: 12
Images: 21
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 45
Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.16.0-4-amd64
Operating System: Debian GNU/Linux 8 (jessie)
CPUs: 12
Total Memory: 62.92 GiB
Name: XXXXXX
ID: XXXXX
docker inspect:
[
{
"Id": "b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13",
"Created": "2015-11-01T12:44:35.234670797Z",
"Path": "/bin/bash",
"Args": [],
"State": {
"Running": false,
"Paused": false,
"Restarting": false,
"OOMKilled": false,
"Dead": false,
"Pid": 0,
"ExitCode": -1,
"Error": "[8] System error: open /sys/fs/cgroup/cpu,cpuacct/system.slice/docker-b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13.scope/cpu.cfs_quota_us: permission denied",
"StartedAt": "0001-01-01T00:00:00Z",
"FinishedAt": "0001-01-01T00:00:00Z"
},
"Image": "4afcabec9aea1c5e0bbfbf77e1e9cbc9e3c0f3272d61ff2da56a212427ff6657",
"NetworkSettings": {
"Bridge": "",
"EndpointID": "",
"Gateway": "",
"GlobalIPv6Address": "",
"GlobalIPv6PrefixLen": 0,
"HairpinMode": false,
"IPAddress": "",
"IPPrefixLen": 0,
"IPv6Gateway": "",
"LinkLocalIPv6Address": "",
"LinkLocalIPv6PrefixLen": 0,
"MacAddress": "",
"NetworkID": "",
"PortMapping": null,
"Ports": null,
"SandboxKey": "",
"SecondaryIPAddresses": null,
"SecondaryIPv6Addresses": null
},
"ResolvConfPath": "/var/lib/docker/containers/b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13/resolv.conf",
"HostnamePath": "/var/lib/docker/containers/b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13/hostname",
"HostsPath": "/var/lib/docker/containers/b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13/hosts",
"LogPath": "/var/lib/docker/containers/b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13/b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13-json.log",
"Name": "/pp-tf2_sr_s6uiq",
"RestartCount": 0,
"Driver": "aufs",
"ExecDriver": "native-0.2",
"MountLabel": "",
"ProcessLabel": "",
"AppArmorProfile": "",
"ExecIDs": null,
"HostConfig": {
"Binds": [
"/home/pp-tf2_sr_s6uiq/public:/home/container"
],
"ContainerIDFile": "",
"LxcConf": [],
"Memory":<PHONE_NUMBER>,
"MemorySwap": 0,
"CpuShares": 0,
"CpuPeriod": 0,
"CpusetCpus": "",
"CpusetMems": "",
"CpuQuota": -1,
"BlkioWeight": 500,
"OomKillDisable": false,
"MemorySwappiness": -1,
"Privileged": false,
"PortBindings": {
"27015/tcp": [
{
"HostIp": "x.x.x.x",
"HostPort": "29415"
}
],
"27015/udp": [
{
"HostIp": "x.x.x.x",
"HostPort": "29415"
}
]
},
"Links": null,
"PublishAllPorts": false,
"Dns": null,
"DnsSearch": null,
"ExtraHosts": null,
"VolumesFrom": null,
"Devices": [],
"NetworkMode": "default",
"IpcMode": "",
"PidMode": "",
"UTSMode": "",
"CapAdd": null,
"CapDrop": null,
"GroupAdd": null,
"RestartPolicy": {
"Name": "no",
"MaximumRetryCount": 0
},
"SecurityOpt": null,
"ReadonlyRootfs": false,
"Ulimits": null,
"LogConfig": {
"Type": "json-file",
"Config": {}
},
"CgroupParent": "",
"ConsoleSize": [
0,
0
]
},
"GraphDriver": {
"Name": "aufs",
"Data": null
},
"Mounts": [
{
"Source": "/home/pp-tf2_sr_s6uiq/public",
"Destination": "/home/container",
"Mode": "",
"RW": true
}
],
"Config": {
"Hostname": "docker",
"Domainname": "",
"User": "2001:126",
"AttachStdin": true,
"AttachStdout": true,
"AttachStderr": true,
"ExposedPorts": {
"27015/tcp": {},
"27015/udp": {},
"27020/tcp": {}
},
"Tty": true,
"OpenStdin": true,
"StdinOnce": true,
"Env": [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"DEBIAN_FRONTEND=noninteractive",
"HOME=/home/container"
],
"Cmd": [
"/bin/bash"
],
"Image": "pufferpanel/srcds",
"Volumes": null,
"WorkingDir": "/home/container",
"Entrypoint": null,
"OnBuild": null,
"Labels": {}
}
}
]

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

extended information regarding the issue:
systemd                               215-17+deb8u2                        amd64        system and service manager
systemd-sysv                          215-17+deb8u2                        amd64        system and service manager - SysV links
/var/log/daemon.log:
Nov  3 00:04:52 localhost systemd[1]: Failed to set memory.limit_in_bytes on : Invalid argument
Nov  3 00:04:52 localhost systemd[1]: Failed to set cpu.cfs_period_us on /system.slice: Permission denied
Nov  3 00:04:52 localhost systemd[1]: Failed to set cpu.cfs_quota_us on /system.slice: Permission denied
Nov  3 00:04:52 localhost systemd[1]: Failed to set cpu.cfs_period_us on /system.slice/docker-b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13.scope: Permission denied
Nov  3 00:04:52 localhost systemd[1]: Failed to set cpu.cfs_quota_us on /system.slice/docker-b46281b6524d80e304d7824a81ae377a68a3b181093a63f169c3d3cf52843d13.scope: Permission denied
Nov  3 00:04:52 localhost systemd[1]: Failed to set cpu.cfs_period_us on /user.slice: Permission denied
Nov  3 00:04:52 localhost systemd[1]: Failed to set cpu.cfs_quota_us on /user.slice: Permission denied

https://lists.debian.org/debian-kernel/2015/10/msg00313.html
missing kernerl feature

please close this issue

@cwmp you can close it yourself too :wink:


feat: HMAC support in Crypto APIs

Couple different ways to use this. The more low level approach (especially useful for HMACing streamed contend:
fixes: https://github.com/godotengine/godot-proposals/issues/1098
extends Node

var hmac = HMACContext.new()

func _ready():
	var key = "supersecretkey" # Key can be of any size greater than 0.
	var data = "Return of the MAC!" # Data size can be any size greater than 0 as well.
	hmac.start(HashingContext.HASH_SHA256, key.to_utf8())
	hmac.update(data.to_utf8())
	var digest = hmac.finish()
        print_hex(digest)

Or the more high level approach that is going to be most useful 99% of the time:
extends Node

var crypto = Crypto.new()

func _ready():
    var key = "supersecretkey" # Key can be of any size greater than 0.
    var data = "Return of the MAC!" # Data size can be any size greater than 0 as well.
    var digest = crypto.hmac_digest(HashingContext.HASH_SHA256, key.to_utf8(), data.to_utf8())
    print_hex(digest)

I've also provided a convenience function for comparing two HMAC digests in a way that is impervious to timing attacks:
extends Node

var crypto = Crypto.new()

func _ready():
    var hm1 # PackedByteArray containing an HMACdigest
    var hm2 #PackedByteArray containing a second HMAC digest
    var equal = crypto.hmac_equals(hm1, hm2)
    print(equal)

Needs some testing still before merge but this is the general approach I am going for @Faless

@Calinou thanks. I'm going through and trying to address all of the static check issues from CI. Once that's done, I'll accept your suggestions.

Can you provide a test project? It'll make testing faster.

@fire yep i def plan to. Still need to do some testing myself though as mentioned above. Pulled an all nighter to implement this though, so ill do so after i rest a bit more haha

@fire I opted instead to create unit tests for everything. If you feel an example project is still useful, I can whip one together though. let me know.

After talking to @Faless it was decided that all of the HMAC stuff would be pulled out of CryptoCore. Unfortunately, doing so means I'm not really sure how to go about unit testing the code since it might be built without the mbedtls module. Unless there is some macro that I can check to see if the module is enabled. 🤔
Anyway, for now, I will create an example project like @fire requested.

Unless there is some preprocessor definition that I can check to see if the module is enabled. thinking

Yes, there is:
MODULE_MBEDTLS_ENABLED in modules/modules_enabled.gen.h (if the module is enabled).
So:
#ifdef MODULE_MBEDTLS_ENABLED
/// TEST CODE
#endif

Unless there is some preprocessor definition that I can check to see if the module is enabled. thinking

Yes, there is:
MODULE_MBEDTLS_ENABLED in modules/modules_enabled.gen.h (if the module is enabled).
So:
#ifdef MODULE_MBEDTLS_ENABLED
/// TEST CODE
#endif

Or possibly add the tests in modules/mbedtls/tests/ directly (see modules/gdscript/tests/ and modules/gdnative/tests/ for examples). Though here since there's interaction with the CryptoCore API maybe the approach suggested by @Faless is better.

Oh nice, didn't know that. So probably the hmac test could be a separate one in the module, than the others testing CryptoCore` will stay in the core test folder.

@akien-mga @Faless oh cool. Ill work on adding thise soon then

@Calinou @akien-mga @Faless this is ready again for y'all.

@Faless I've addressed all of your feedback. This is ready for you again. :)

Ready again for you @Faless

Thanks!


[WIP] Add colorized output to jenkins console

According to Apsu the AnsiColor Plugin has been installed on our
Jenkins server.


Map all commands and argument types

DataCommand: 2 method names beyond executeInsert are missing (addModifyArguments and executeModify), also 2 inner interfaces (a is used for modifiying, perhaps simply Modify, didn't look into b, but looks like a ModifyBuilder)
ExecuteCommand: field d and an inner interface that looks identical to Condition, if you can figure these out
LootCommand: inner interface a: used for adding the item, to wherever it's supposed to go. Process seems like a good name to me.
RecepieCommand: Change previously mapped methods give and take to executeGive and ...Take
SpreadPlayersCommand: inner class Pile: float b method: it's an absolute value, void a() normalizes the vector coordinates boolean a method calculates and returns the height value.
Didn't look at argument types yet. I was in process of doing the same thing, which is why I had mappings for some of the missing ones. Unfortunately, I can throw most of them away now.


runbot.bat says owner id is not set when it is

I have set the owner id and when I run runbot.bat it says
An error has occured reading the config:
Problem:  OwnerID was not set.
Solution: Please set the OwnerID in the config.  If you don't know what that is, use the !id command

Hi. So we can help you easier with this issue, please ask for help in our Discord server: https://discord.gg/bots


[$250] Expense - In offline, expense created with violation  red dot not shown in preview

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Applause Internal Team
Device used: Redmi note 10s Android 13
App Component: Money Requests
Action Performed:

Go to https://staging.new.expensify.com/home
Go to workspace settings
Tap categories - upgrade it
Enter payroll & gl code and save it
Tap settings and enable members must categorize all expenses
Open workspace chat
Go offline
Create an expense with big amount, enter merchant and set a future date
Note expense preview shows no red dot
Open the expense and note only missing category field displays red dot
Go to workspace chat page
Turn online
Now note expense preview shows red dot
Open the expense and note now red dot is shown in amount, receipt and for date field

Expected Result:
In offline, expense created with violation must show red dot.
Actual Result:
In offline, for expense created with violation, red dot is not  shown in expense preview and for amount, receipt and for date field also red dot is not displayed in offline.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/69533ecc-ff68-4cb4-be29-c2f4b4172da8
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021871678007124043126
Upwork Job ID:<PHONE_NUMBER>124043126
Last Price Increase: 2024-12-24

Issue OwnerCurrent Issue Owner: @s77rt

Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - In offline, expense created with violation red dot not shown in preview
What is the root cause of that problem?
We are not setting showInReview for the violations here
https://github.com/Expensify/App/blob/126d92ab5cbb401efc0a5527faba244d04d48971/src/libs/Violations/ViolationsUtils.ts#L201-L208
What changes do you think we should make in order to solve the problem?

We should set showInReview same as how the BE sets
if (hasMissingCategoryViolation && isCategoryInPolicy) {
                newTransactionViolations = reject(newTransactionViolations, {name: 'missingCategory', showInReview: true});
            }

            // Add 'missingCategory' violation if category is required and not set
            if (!hasMissingCategoryViolation && policyRequiresCategories && !categoryKey) {
                newTransactionViolations.push({name: 'missingCategory', type: CONST.VIOLATION_TYPES.VIOLATION, showInReview: true});
            }

We should apply similar fixes for other violations where needed too
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - In offline, expense created with violation red dot not shown in preview
What is the root cause of that problem?
We are not setting showInReview for the violations here
https://github.com/Expensify/App/blob/126d92ab5cbb401efc0a5527faba244d04d48971/src/libs/Violations/ViolationsUtils.ts#L201-L208
What changes do you think we should make in order to solve the problem?

We should set showInReview same as how the BE sets
if (hasMissingCategoryViolation && isCategoryInPolicy) {
                newTransactionViolations = reject(newTransactionViolations, {name: 'missingCategory', showInReview: true});
            }

            // Add 'missingCategory' violation if category is required and not set
            if (!hasMissingCategoryViolation && policyRequiresCategories && !categoryKey) {
                newTransactionViolations.push({name: 'missingCategory', type: CONST.VIOLATION_TYPES.VIOLATION, showInReview: true});
            }

We should apply similar fixes for other violations where needed too
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can make a test for ViolationsUtils.getViolationsOnyxData to assert if showInReview is set properly
What alternative solutions did you explore? (Optional)

@FitseTLT Thanks for the proposal. If showInReview is not set wouldn't that make this condition return true? https://github.com/Expensify/App/blob/ad99c20c40e4fed347cff29f5ed85c98825442a8/src/libs/TransactionUtils/index.ts#L886

@daledah Thanks for the proposal. I have the same question above ^

PS: I have also asked a related question here https://github.com/Expensify/App/pull/51893#discussion_r1897014504

@daledah Makes sense. Thanks for the clarification

@FitseTLT Your proposal only covered the first problem (seeing red dot in field but not in preview) but didn't cover the second problem (not seeing red dot at all - missing violation).

@daledah The proposal looks good to me but I don't think we need automated test here. This is something that should be caught by typescript (showInReview).
🎀 👀 🎀 C+ reviewed
Link to proposal

@FitseTLT Your proposal only covered the first problem (seeing red dot in field but not in preview) but didn't cover the second problem (not seeing red dot at all - missing violation).

I am sorry @s77rt but it is not clear what you are saying. What is my proposal lacking and the selected proposal has?

@FitseTLT The other reported fields such as the date don't even have optimistic violation data. Adding showInReview is not enough, in fact there is no place to add it to.

@FitseTLT The other reported fields such as the date don't even have optimistic violation data. Adding showInReview is not enough, in fact there is no place to add it to.

@s77rt  How can that be in the scope of this issue there might even be other violations which we are not currently adding optimistically if it should be dealt then it should be covered on another new issue by correctly researching to find all violations we are missing in our optimistic data. I don't think this is at all in the scope of this issue because there are a lot of other violations we are not considering optimsitcally the contributor only chose that came to his mind. For instance here is a demo for overCategoryLimit violation RBR only comes after switching online because we missed to add in optimsitc data. This is a violation that occurs when you set flag amount over for a category rule. There can easily be many more we missed but it should be handled with the proper research on an independent issue.

https://github.com/user-attachments/assets/ec5a7765-bbab-4b7c-8d7b-a20aa2d6373b

@FitseTLT Those fields are referenced in the OP. True that we may have many of these missed optimistic data but that does not mean we should ignore them.

@FitseTLT Those fields are referenced in the OP. True that we may have many of these missed optimistic data but that does not mean we should ignore them.

Didn't see that in the OP. Sorry in that case I agree 🙏   @s77rt


PodDisruptionBudget are now updateable

I will do the followup PR that will make minAvailable configurable.
More detail:
https://github.com/kubernetes/kubernetes/pull/69867
Related PR:
https://github.com/istio/istio/pull/26688

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
b33ada48749c765aaa64c213841fa7513dc53a13
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

Should we even be expanding the helm api? This is configurable with k8s settings: https://preliminary.istio.io/latest/docs/setup/install/istioctl/#customize-kubernetes-settings
cc @ostromart @costinm

I will do the followup PR that will make minAvailable configurable.

WIP: https://github.com/shamsher31/istio/commit/48ec49f30350f7cc8ca611a283113e2ca2ef605d

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db3ac0a90e4e9c2fc75d734c4340a9513ee06a3a
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
db3ac0a90e4e9c2fc75d734c4340a9513ee06a3a
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

/retest

we can modify from IstioOperator API directly, right? https://github.com/istio/api/blame/master/operator/v1alpha1/operator.proto#L457

Yes, this PR is related to enabling configurable defaults for PDB.

Related info on setting PDB.
https://github.com/istio/istio/issues/12602#issuecomment-489449657
https://github.com/istio/istio/issues/24000

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
db3ac0a90e4e9c2fc75d734c4340a9513ee06a3a
link
/test integ-pilot-multicluster-tests_istio

gencheck_istio
3cbf383b6602cbef2e89f7a6cc1c5b4e84bec0f4
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@carolynhu As per our discussion on Slack. I have covered few points mentioned here https://github.com/istio/istio/pull/27209#issue-483774566

cc: @howardjohn @ostromart @carolynhu

Ping on review for this @sdake @howardjohn This addresses a P0 for 1.8 so would be great to check it in asap.

@shamsher31: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Closing in favour of https://github.com/istio/istio/pull/28180


feat: More multilingual audio training data

Problem
Currently we only have mostly Vietnamese, some Thai, some Singlish.
Suggestion
Process the youtube audio in this dataset: https://huggingface.co/datasets/espnet/yodas2/
Thanks jpc for sharing this dataset

Description
This is the preprocessing code for the GigaSpeech2 dataset.
Gist link
Problem

The original GigaSpeech2 dataset contains over 7M raw Vietnamese audio files.
Audio files are stored in .tar.gz archives.
Transcriptions are saved separately in .tsv files.

Preprocessing Steps

Load the dataset and map each audio file to its corresponding transcription using IDs.
Convert the dataset into a Hugging Face-compatible format for use with the current training code.


no method named "owner" on contract when deploying

Describe the bug
When installing or upgrading through hardhat-deploy I get the following error message after the contracts have been deployed but before the facets have been installed:
*no method named "owner" on contract ...  See full error message below. I am using a inherited version of the contract (see below). *
Manually adding facets through louper worked though, and no problems in development either.
To Reproduce
I can provide access to the github.
versions

hardhat-deploy 0.11.34
hardhat 2.17.0
nodejs 18.14.2

Additional context
 at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async _deployViaDiamondProxy (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/helpers.ts:2476:30)
    at async Object.func (/Users/martinwawrusch/Dev/xxx/deploy/001_deploy_dekoh.ts:49:39)
    at async DeploymentsManager.executeDeployScripts (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1226:22)
    at async DeploymentsManager.runDeploy (/Users/martinwawrusch/Dev/rxxx/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1059:5)
    at async SimpleTaskDefinition.action (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/index.ts:438:5)
    at async Environment._runTaskDefinition (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat/src/internal/core/runtime-environment.ts:333:14)
    at async Environment.run (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat/src/internal/core/runtime-environment.ts:166:14)
    at async SimpleTaskDefinition.action (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/index.ts:584:32)
    at DeploymentsManager.executeDeployScripts (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1229:19)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async DeploymentsManager.runDeploy (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1059:5)
    at async SimpleTaskDefinition.action (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/index.ts:438:5)
    at async Environment._runTaskDefinition (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat/src/internal/core/runtime-environment.ts:333:14)
    at async Environment.run (/Users/martinwawrusch/Dev//node_modules/hardhat/src/internal/core/runtime-environment.ts:166:14)
    at async SimpleTaskDefinition.action (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/index.ts:584:32)
    at async Environment._runTaskDefinition (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat/src/internal/core/runtime-environment.ts:333:14)
    at async Environment.run (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat/src/internal/core/runtime-environment.ts:166:14)
    at async SimpleTaskDefinition.action (/Users/martinwawrusch/Dev/xxx/node_modules/hardhat-deploy/src/index.ts:669:5)
    ```
    Diamond code
    ```
    import { Diamond } from "hardhat-deploy/solc_0.8/diamond/Diamond.sol";

contract DekohDiamond is Diamond {

    /// @notice This construct a diamond contract
    /// @param _contractOwner the owner of the contract. With default DiamondCutFacet, this is the sole address allowed to make further cuts.
    /// @param _diamondCut the list of facet to add
    /// @param _initializations the list of initialization pair to execute. This allow to setup a contract with multiple level of independent initialization.
    constructor(
        address _contractOwner,
        IDiamondCut.FacetCut[] memory _diamondCut,
        Initialization[] memory _initializations
    ) payable Diamond(_contractOwner, _diamondCut, _initializations)
  {
  }
}

To add to that:
defaultOwnershipFacet is set to false, which probably causes this.

During the use of hardhat-deploy, I encountered a situation similar to issue #477.  I would like to share my perspective. I believe the Diamond contract does not necessarily need to have the OwnershipFacet, as it is not part of the eip-2535 standard and thus does not require the owner method. In terms of permission management, considering its limited authority, I may not use the OwnershipFacet. Instead, I am inclined to use the AccessControlEnumerableFacet for better permission management. Providing this feedback may help improve and optimize this library for a better user experience.
Many thanks for your efforts and contributions to the community. Looking forward to seeing this issue resolved and to the ongoing progress and development of your project.

https://eips.ethereum.org/EIPS/eip-2535#ownership-and-authentication


fix relationship.go maybe nil panic

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?

User Case Description

Hi @demoManito
can you add some tests that might reproduce the panic?

Hi @demoManito
can you add some tests that might reproduce the panic?

Hello @jinzhu
The else block primaryFields covers the outer primaryFields, which is always empty, and may index out of panic:
https://github.com/go-gorm/gorm/blob/0b7113b618584edd76d74e7a73eecc2a28a4d17a/schema/relationship.go#L432
Other modifications just expand if else


Jos

Add project specific ProGuard rules here.
By default, the flags in this file are appended to flags specified
in ./Users/alexanderchiou/Library/Android/sdk/tools/proguard/proguard-android.txt
You can edit the include path and order by changing the proguardFiles
directive in build.gradle.

For more details, see
http://developer.android.com/guide/developing/tools/proguard.html
Add any project specific keep options here:
If your project uses WebView with JS, uncomment the following
and specify the fully qualified class name to the JavaScript interface
class:
#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
public *;
#}
android {
...
buildTypes {
release {
minifyEnabled true
proguardFiles getDefaultProguardFile(
'proguard-android-optimize.txt'),
// List additional ProGuard rules for the given build type here. By default,
// Android Studio creates and includes an empty rules file for you (located
// at the root directory of each module).
'proguard-rules.pro'
}
}
flavorDimensions "version"
productFlavors {
flavor1 {
...
}
flavor2 {
proguardFile 'flavor2-rules.pro'
}
}
}
agorartm.log

Didesain ulang menjadi pola tunggal
Diimplementasikan completeCommand () berdasarkan [info perintah]
Perintah Tcl saveScript baru

Closing as off-topic.


To log "info" in NakadiReader

In every Nakadi batch, an info.debug field might be available which helps to understand what's happening to the connection. (e.g. if connection is going to be closed from server side)
In this small PR I'm adding this capability to the NakadiReader to log value of info.debug instead of ignoring it.
Reopened external PR https://github.com/zalando-nakadi/fahrschein/pull/369 from @sameei

@sameei can you give a bit of context why this feature is important? Is it because Nakadi is closing the connection regularly, and you want to correlate connection-closed error messages with this? Or is it purely educational info for debugging?

👍

Apologies for my inactivity for so long.
Looks good. Thanks for taking care of this, and I will follow the guide you gave about handling new features/fixes/etc. @otrosien

👍

👍


[SP-4187][BACKLOG-21008] Yarn job hangs in Transformation step set wi…

…th run
configuration Clusterd & never ends

replaced LinkedBlockingDeque with a plain ArrayList defended by
ReadWriteLock, as LBD is not fully thread-safe due to bug in JDK.
Also, LBD does not seem to be the right collection for LoggingBuffer
(for exmaple, even though it is backed by linked list, iterator.remove
runs in a linear time).
added concurrent test for logging buffer
moved ConcurrentTestRunner utility to the core module
added test jar to core module to be used by engine module, since it still needs
ConcurrentTestRunner

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/pom.xml
  core/src/main/java/org/pentaho/di/core/logging/KettleLogStore.java
  core/src/main/java/org/pentaho/di/core/logging/LoggingBuffer.java
  core/src/test/java/org/pentaho/di/concurrency/ConcurrencyTestRunner.java
  core/src/test/java/org/pentaho/di/concurrency/ExecutionResult.java
  core/src/test/java/org/pentaho/di/concurrency/LoggingBufferConcurrencyTest.java
  core/src/test/java/org/pentaho/di/concurrency/StopOnErrorCallable.java
  core/src/test/java/org/pentaho/di/core/logging/LoggingBufferTest.java
  engine/pom.xml

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -3.1% :small_red_triangle_down:
Complexity Change: -3.1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

@dteixeira @pamval @kolinus @pentaho-lmartins please merge

@duarteteixeira @stepanovdg

@VasilinaTerehova


Freeze in Spyder

When run in Spyder (win python - windows7), there is an python embedded console.
then:
   %gui qt
   from six.gui.plot import Plot1D

just locks everything. looks like a dead lock.

Did you wait until the '%gui qt' command ended ?
We had some kermel crah under notebook sometime if the %gui qt is not on a separated cell

This could be the same issue as described in #538 (ipython console widget related)

I could not reproduce this issue neither with Spyder nor with the notebook with WinPython-64bit-<IP_ADDRESS>Qt5 (latest version) and silx 0.6.1.
So I'm closing it.


Add proxy flag to use ProxyServer

Proposed of Changes

Adding a proxy flag to allow users to set the outbound proxy server.

This looks like a great addition, thank you! :)
I will test and then merge it now


Single cell reads appear to be unlabelled when filtering transcripts

I'm having trouble filtering transcripts on a single cell long read dataset. I ran talon_filter_transcripts with --minDatasets 5 --minCount 1 and got the following error for all datasets:
Reads in dataset NNNNNNNNNNNNNNNNNNNNNNNN appear to be unlabelled. Only known transcripts will pass the filter.
Running talon_filter_transcript on the same dataset as a pseudo-bulk sample did not result in this error. Thanks in advance for help with troubleshooting this!

Did you use the --cb option for your single-cell TALON run? Where did you label your cell barcodes in your input dataset?


[release/6.0] add CMake build script for the release/6.0 branch

This PR cherry-picks the CMake build changes needed to build swift-toolchain-sqlite with CMake, in the release/6.0 branch.
They are needed to build the browsercompany's release/6.0 toolchain.

@jakepetroules wdyt?


feat: adopt JWS 2020 crypto suite

What this PR changes/adds
Adopts the Jws2020 Crypto Suite implementation that was originally authored in Tractus-X into the EDC code base.
Why it does that
Upcoming work for Self-Sovereign Identities will leverage and need that piece of code.
Further notes

The test data, i.e. credentials were sanitized by replacing all references to "Catena-X", "BPN" etc. with neutral ones.
The actual code base or test code base was not changed.

Linked Issue(s)
Closes #3355
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
Patch coverage: 77.71% and project coverage change: +0.06% :tada:

Comparison is base (594dde6) 72.13% compared to head (98c8e1b) 72.20%.
Report is 1 commits behind head on main.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
+ Coverage   72.13%   72.20%   +0.06%
==========================================
  Files         803      814      +11
  Lines       16547    16731     +184
  Branches      952      965      +13
==========================================
+ Hits        11937    12080     +143
- Misses       4213     4241      +28
- Partials      397      410      +13

Files Changed
Coverage Δ

...ipse/edc/security/signature/jws2020/JwkMethod.java
55.55% <55.55%> (ø)

...pse/edc/security/signature/jws2020/KeyFactory.java
61.53% <61.53%> (ø)

...pse/edc/security/signature/jws2020/JwkAdapter.java
72.72% <72.72%> (ø)

...ty/signature/jws2020/Jws2020SignatureProvider.java
73.46% <73.46%> (ø)

...c/security/signature/jws2020/ByteArrayAdapter.java
75.00% <75.00%> (ø)

...e/edc/security/signature/jws2020/IssuerCompat.java
78.57% <78.57%> (ø)

.../edc/security/signature/jws2020/Jws2020Schema.java
89.28% <89.28%> (ø)

...se/edc/security/signature/jws2020/JsonAdapter.java
100.00% <100.00%> (ø)

...security/signature/jws2020/Jws2020CryptoSuite.java
100.00% <100.00%> (ø)

...urity/signature/jws2020/JwsSignature2020Suite.java
100.00% <100.00%> (ø)

... and 1 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Logic App with Hybrid Connection

Hello there
I would like to know if I can connect Logic Apps to an internal system using Hybrid Connection through a connector. So would the hybrid connection shows up within the gateway dropdown in the screenshot below?
I know you can use data gateway a connector, but is Hybrid connection only accessible through .net code in Logic Apps?

Thanks

@Mike-tech Thank you for the question! In order to best address your question, could you provide us with the URL of the MS Doc that you were following, if any?

@BhargaviAnnadevara-MSFT I'm not following any particular document. But this is a link that talks about using Data gateway:
https://docs.microsoft.com/en-us/azure/logic-apps/logic-apps-gateway-connection

@Mike-tech Ok, Thank you for the response! I've routed this to the appropriate Team to investigate and update.

@Mike-tech No. The various connectors that support on-premise connections all rely on On-Premise Data Gateway being setup (which actually uses Service Bus under the hood).
That being said, you can still implement your own Custom Connector powered by an API App which utilizes Hybrid Connection if required. But do take note that this approach will cost significantly higher since you will paying for both the API App and Hybrid Connection.

@PramodValavala-MSFT thanks for confirming this. I think it's probably best to stick with data gateway for now.
Cheers


Wrapper function doesn't return orignal function's result

I am using ASP.NET Webform (yeah,  it is legacy code..) with <asp:UpdatePanel> and <AsyncPostBackTrigger>.
When a button click triggers a async postback, event.onsubmit from <form onsubmit="javascript:return WebForm_OnSubmit();"> will be called and return the validation result. However it is not returned once zone.js wraps the event handler, resulting the request not passing validation.
The source code here shows that the wrapper function doesn't return the result of
https://github.com/angular/zone.js/blob/master/lib/common/utils.ts#L89
const wrapFn = function(event) {
        let result;
        result = fn.apply(this, arguments);

        if (result != undefined && !result) event.preventDefault();
};

Not sure what it the purpose of this code not returning result. Thanks for taking a look.

@zzx88991 , thank you for posting the issue, I will make a PR to fix it.

@zzx88991 , I have further question about this one, I am not familiar with ASP.NET, current zone.js implementation just call event.preventDefault when eventHandler return false, so in your code, the form will not submit but you will directly use the eventHandler return value somewhere else, is that right?

Yes, you are right. The eventHandler is called somewhere else before the the form is submitted. I am just curious why wrapFun doesn't return  result

@zzx88991 , yes, it should return , I just want to create test case to prove it.


Add support for JDBC Sink Connector

https://docs.confluent.io/kafka-connect-jdbc/current/sink-connector/sink_config_options.html#sink-config-options

@philipp94831 does this database icon fit? https://github.com/bakdata/streams-explorer/blob/e0fec2de95ce06f271e58d891d73ca3b0672191a/frontend/public/jdbc-sink.svg

and do you have an example config for this connector I could test it with?


DEP: extend deprecation of private namespaces also to fortran-generated modules

While looking at cleaning up the deprecations following #18279 (fitting into the larger picture of #14360), I noticed that scipy.interpolate.dfitpack is not deprecated, which seems like an oversight - in particular because it contains several functions that scipy.interpolate itself contains:
>>> import scipy.interpolate
>>> import scipy.interpolate.dfitpack
>>> dfitpack_funcs = set(scipy.interpolate.dfitpack.__dir__())
>>> interpolate_funcs = set(scipy.interpolate.__dir__())
>>> sorted([x for x in dfitpack_funcs & interpolate_funcs if not x.startswith("_")])
['spalde', 'splder', 'splev', 'splint', 'sproot']

But that's only half the story, because we have a new interface to fitpack...
https://github.com/scipy/scipy/blob/52732578a67e1f243b466e0668d99f6ec85d0d08/scipy/interpolate/__init__.py#L170-L171
and funnily enough that file wraps both dfitpack directly, as well as a separate wrapper layer, also around dfitpack (sidenote: looks like this tweet I saw today turned out to be prophetic 😅 ). Suffice it to say, despite different names, a lot (all?) of the remaining functions in dfitpack then also get accounted for.
It's looks likely that this was overlooked because there's no actual python code, we just directly generate the functions from fortran:
https://github.com/scipy/scipy/blob/52732578a67e1f243b466e0668d99f6ec85d0d08/scipy/interpolate/meson.build#L145-L162
Not sure how many other such should-be-private-but-has-no-underscore fortran libraries are about.
CC @rgommers @tupui @j-bowhay @ev-br

The story here is a bit different.
TL;DR: 1) scipy.interpolate.dfitpack is an implementation detail, not meant to be public; 2) any "new" comment is likely obsolete, can be removed if wanted; 3) cleanup is ongoing, help appreciated, the work is way beyond just deprecating accidentally public names.
Long version. Let's start from the source files:
$ ll scipy/interpolate
<edited for clarity>

drwxrwxr-x  2 br br  4096 янв 17 15:20 fitpack/    # FORTRAN sources
-rw-rw-r--  1 br br 89172 янв  7 15:24 _fitpack2.py    # implementation details of `UnivariateSpline` etc
-rw-rw-r--  1 br br   964 ноя 22 19:48 fitpack2.py    # deprecated wrappers for _fitpack2.py
-rw-rw-r--  1 br br 28669 янв  7 15:24 _fitpack_impl.py    # implementation details of `splrep` etc
-rw-rw-r--  1 br br   716 ноя 22 19:48 fitpack.py    # deprecated wrappers for fitpack.py
-rw-rw-r--  1 br br 27528 янв 17 15:20 _fitpack_py.py    # implementation details for `splrep` etc, goes with `_fitpack_impl.py`

(scipy-dev) br@gonzales:~/repos/scipy/scipy$ ll scipy/interpolate/src/
-rw-rw-r-- 1 br br  1696 ноя 21  2022 __fitpack.h               # is unrelated to FORTRAN
-rw-rw-r-- 1 br br 19315 янв  6 13:11 _fitpackmodule.c          # sources for the `_fitpack.so` extension
-rw-rw-r-- 1 br br 32669 ноя 22 19:48 fitpack.pyf           # sources for the `dfitpack.so` extension

The fortran sources in scipy/interpolate/fitpack have two sets of C wrapper to python. The extension modules are _fitpack.so and dfitpack.so.
The comment "New interface to fitpack library" is historical (remember book titles like "modern analysis of ..."?) is from 2003:
$ git blame -M -C -C scipy/interpolate/__init__.py
...
2715c638314 Lib/interpolate/__init__.py   (Pearu Peterson  2003-09-15 13:58:12 +0000 171) # New interface to fitpack library:
23ef8d5c336 scipy/interpolate/__init__.py (Gagandeep Singh 2021-10-27 15:42:25 +0530 172) from ._fitpack2 import *
...

Why there are two extensions: historical reasons, I suppose.
Atsushi Sakai did a lot of work deduplicating them recently, see https://github.com/scipy/scipy/issues/16729.
Neither of these extensions needs to be public, anything they export is an implementation detail of either splrep et al or UnivariateSpline and friends.
Some dfitpack functions share the name but differ from eponymous public functions scipy.interpolate: e.g. interpolate.splder does not use dfitpack.splder.
Whether it is worth the hassle to make dfitpack raise a DeprecationWarning, I don't know. I personally am -0 (== am not going to do it myself; do not believe it is worth doing;  will not oppose if somebody think it's worth and does it).
A more productive line of work is IMO to cook up a feature-complete alternative to FITPACK with an eye to remove the latter at some point.
The exact path to removal needs to be worked out.
Initial steps are tracked in https://github.com/users/ev-br/projects/1/views/1, the currently open scipy PRs are
https://github.com/scipy/scipy/pull/19753, https://github.com/scipy/scipy/pull/19777 and https://github.com/scipy/scipy/pull/19873
Help is welcome and appreciated :-).

Looks like dfitpack -> _dfitpack rename was done in https://github.com/scipy/scipy/pull/20612, is there something else for this issue @h-vetinari ?

The last one is/was interpolate/interpnd.so, so here's gh-21754 to close the book.


Enable support for Newton-Raphson

Newton support has been restored as part of #582
However before we should consider the following:

Add validation. The combination of settings required and cells types are important
We need to propagate the setting to the GWFGWF exchange files (Do other packages also need it?)

marked this issue as blocking #549

Most of the work for this is done, work will be continued further in https://github.com/Deltares/imod-python/issues/724


Net45 and Net46 targets

The Nuget package should explicitly have a net45 and net46 target.
Create a new plain old net46 (or net45) class library.
Add the Microsoft.Extensions.DependencyInjection package.
Even though we are now on full .Net it tries to install all the net standard dependencies even though they are really not needed. The actual assemblies does not even get downloaded with these packages. Each lib folder just contains a file named "underscore dot underscore" (Markdown did not like it :))

@davidfowl / @ericstj thoughts on this? Any particular recommendations on specifically targeting net45x instead of netstandard + NuGet dependencies?

I chatted with @danroth27 @anurse @pakrym @muratg .
We don't think that adding net45 (etc.) to the packages is the right approach. If anything, we would look at improving the experience of netstandard and the standard library.
@richlander we should talk about this more to see what are some rough edges that could benefit from some polishing.


test: add tests for edge cases

Add tests to deal with empty files and bad keys.

More edge cases: https://github.com/elixir-cloud-aai/protes-middleware-crypt4gh/pull/5#discussion_r1617971648

View sourcery comments in #6


Can't access extension marketplace

Issue Type: Bug

Try to open extensions menu
Be greeted by a connection error

If I try to enter the Network tab of the dev panel I can see that extensionquery has been blocked by the following error:
Access to XMLHttpRequest at 'https://open-vsx.org/vscode/gallery/extensionquery' from origin 'vscode-file://vscode-app' has been blocked by CORS policy: Request header field x-market-user-id is not allowed by Access-Control-Allow-Headers in preflight response.

I can't access the extensions marketplace nor install dependencies from the C# extension, which might mean that some packets are being blocked by the client.
VS Code version: Code - OSS 1.58.0 (2d23c42a936db1c7b3b06f918cde29561cc47cd6, 2021-07-12T23:51:36.303Z)
OS version: Linux x64 5.10.42-1-MANJARO
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4210U CPU @ 1.70GHz (4 x 2411)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
7.70GB (0.13GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions (2)

Extension
Author (truncated)
Version

rust-analyzer
mat
0.2.637

csharp
muh
1.23.12

/duplicate of #128583


Added image for nipsw-19

👷 Deploy Preview for gladia processing.

Name
Link

🔨 Latest commit
88f77ebdcfe2e699e915d024dc30993ba1540879

🔍 Latest deploy log
https://app.netlify.com/sites/gladia/deploys/643286898f7c3b0008cadb64


Consider unpinning dependencies

I am using slightly different versions of several of this package's dependencies, but since you have pinned them to an exact version, I end up shipping both versions to my users.
Would you be willing to use semver to allow a wider range of (non-breaking) versions to be used?

Hm, nevermind.  I realized that even though I have this package in my dependencies, it really shouldn't be.  So, it's not like I'm bundling any of your dependencies.  Sorry for the noise.


How to disable logs.

I see lots of unnecessary logs in logcat, I looked into the source code and find out there are lots of Log.d() lines, It would be nice to have a way to disable them, a simple wrapper around Android Log class for instance.

Good issue to add, but why is the following so difficult:

Please check off the following things BEFORE submitting a new issue. Any issues that do not properly follow this format will be closed without discussion. If you're requesting to have your app added to the list, you can erase the list and provide your app's name and play store listing link. Thanks!
[ ] What you've tried (include code snippets, or whole files as necessary):
(REPLACE with your answer)
[ ] What you thought should happen:
(REPLACE with your answer)
[ ] What actually happened:
(REPLACE with your answer)


Development time integration with Gulp

I will try to make an integration point for streaming & configurable asset building with Gulp. This would work while you develop and provide a way to make assets when deployed.

I'm going to mark 0.3.11 as finished (as it technically shipped), and put this into the next minor (0.3.12)

Status of this ? Interested in more info.

I see this as a way to feed views into gulp targets for generating production code. I suppose that there could also be a way to feed gulp tasks into views. I think gulp based formatters should be a thing.

By views you mean sending gulp itself to the browser ?   Can you elaborate.  Is very intruiging but not clear on precise intention.

by view I mean view definition. ss.client.define
So feeding the assets defined in a definition into a gulp task. Say for instance you want to use SS to bundle the view, and then gulp to pack and annotate it.

Okay yeah that makes sense.

The task support is now in 0.4.4, I run via gulpfile.js in development. It works nicely

Do Gulp error handling https://github.com/gulpjs/gulp/issues/216


Morning Session Code review

I have reviewed this code and I don´t find any problem in it. I should do a depper review to find something.

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉


python3Packages.asf-search: sync deps with upstream

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 215909 run on x86_64-linux 1

4 packages built:

python310Packages.asf-search
python310Packages.remotezip
python311Packages.asf-search
python311Packages.remotezip

@ofborg build python310Packages.asf-search python311Packages.asf-search


Component Model Support for Observe SDK

Enable support for the Observe SDK to execute and profile components. Since wazero does not yet support components, this issue is scoped to (in priority order):

[ ] Rust (involves upgrading to Wasmtime 13 - https://github.com/bytecodealliance/wasmtime/releases/tag/v13.0.0)
[ ] JavaScript via https://github.com/bytecodealliance/jco

To test, we'll have to compile a component that has been instrumented. We should be able to do this manually with the Rust Observe API

Reach out to Cosmonic after Kubecon in Nov.

Reached out...waiting for response

Currently blocked on Extism namespace / version updates

Rust support is in progress: Issue: https://github.com/dylibso/observe-sdk/issues/142 PR: https://github.com/dylibso/observe-sdk/pull/128

Moving work to #142


XML parser results in wrong behaviour when custom schema is used

I used the following the XML file and the custom schema
<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<invalidSchema>
    <book>
        <title>Five point someone
            <!-- This tag is not present in the schema provided -->
            <_ isApplicable="false" source="">test book</_>
        </title>
    </book>
    <author>
        <fname>Gambardella, Matthew</fname>
    </author>
</invalidSchema>

val schema = buildSchema(
      field("book",
        struct(field("title",
          struct(field("text_val", StringType))))),
      field("author",
        struct(field("fname",
          struct(field("text_val", StringType)))))
    )

    val invalid_schema_xml = resDir + "invalidSchema.xml"
    val results = spark.read.format("xml").option("rowTag", "invalidSchema")
      .option("valueTag", "text_val")
      .option("ignoreSurroundingSpaces", true)
      .schema(schema)
      .load(invalid_schema_xml)
    results.show(false)

As per below output you can see that author is null but it should not be null
+----------------------+------+
|book                  |author|
+----------------------+------+
|{{Five point someone}}|null  |
+----------------------+------+

I think the answer is that the input is malformed w.r.t. the schema, and this uses the default 'permissive' error handling mode unless configured otherwise, so parsing stops when it hits the problem and the remaining cols are null. You have a partial record here. You can change to "FAILFAST" parsing mode to generate an error. You can also supply a column in your schema that matches what is configured as the col name for corrupted records, and it will output the XML in that col for you too

Whatever the mode I use result is same i.e. always author column is null

Hm yeah that's not quite the issue. I think the issue is the text alongside the child element in <title>. That does not work; for a discussion, see: https://github.com/databricks/spark-xml/issues/516
What I can't see immediately is why parsing does not fail with a custom schema. It's going to be related to the fact that it does not expect any text here.
I'll leave it open but I don't know how to fix it and dont' have time to debug, but I'd certainly look at more analysis or a pull request if anyone has bright ideas.


Add missing labelOverlap property

Thanks! This was initially included as a "soft release" feature, but should now be ready for public exposure.


[Move devex] Handle multi-root workspaces in the IDE

At this point, only a workspace with a single root directory is handled - in particular, if the second directory is added to the workspace, go-to-ref will not work for it. Ideally, we'd handle multiple roots

working on this


[Core] Fix issue #16798: Azure CLI output is corrupted!

Description

Fix issue #16798
As progress bar will write string to stderr and cli command result will write to stdout, two kinds of strings overlapped.
Here is to erase previous stderr stream with empty line, and then the overlap disappears as below:

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Core


chore: Bump<EMAIL_ADDRESS>

What does this change?
Bump<EMAIL_ADDRESS>to align deps with upcoming bumps in Frontend:
https://github.com/guardian/frontend/pull/25949

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.911%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
631

Relevant Lines:
665

💛  - Coveralls


Bedtime

NOTE** Bedtime is not done. An ok amount is done but, I been stuck on adding function in the bottom sheet for months now. You might have better luck then me, If you can't complete it. upload it and maybe some one can complete it.

@edodson84 bedtime has been added, it's just not currently working can you have a look at it?

@gun4qmm7h thank you for your work, finally bedtime has been completed and merged

Thank you but I didn't do much compared to @Nilsu11.


Update mockito-core to 3.0.0

Updates org.mockito:mockito-core from 2.28.2 to 3.0.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "org.mockito", artifactId = "mockito-core" }]

labels: semver-major

Yeah, I think it force-pushed after another merge and then flaked.


Add debug option in config

Add a debug option in the config. Should default to false, but when true, it outputs anything useful for debugging cayo itself or an instance of cayo.
Right now the only existing thing that'd be toggled on and off is the output of stats.json. Just to eliminate an extra file write while running, if you're an average user.

fe42faa fixes this