feat(editor): remove preview modal and add preview page

Remove preview modal and add preview page instead.
https://user-images.githubusercontent.com/12260952/209282750-49e83f2e-56ac-4939-8c53-068a29ded539.mov

It's probably better not to use a preview.html for the preview page, because users might launch the editor in the local project without preview.html setup.

It's probably better not to use a preview.html for the preview page, because users might launch the editor in the local project without preview.html setup.

That's true... I will see if there is better way to do this.


add multi30k for eval

Add the Multi30K datasets for multilingual image--sentence retrieval evaluation. The evaluation data is available in English, French, Czech, and German. The sentence data can be found on Github at https://github.com/multi30k/dataset/tree/master/data/task1/raw.
The raw untokenized sentence data can be found in the following files, where LANG = (en, cs, de, fr):
test_2016_flickr.LANG.gz
test_2017_flickr.LANG.gz
test_2018_flickr.LANG.gz
The corresponding image information can be found in https://github.com/multi30k/dataset/tree/master/data/task1/image_splits
test_2016_flickr.txt this uses the test set images from the original Flickr30K dataset.
test_2017_flickr.txt uses newly collected images
test_2018_flickr.txt uses newly collected images
The newly collected images are available to download via Google Drive. Not sure if this is easy to automatically download so re-hosting elsewhere might be possible.

seems good
we would need something similar to https://github.com/LAION-AI/CLIP_benchmark/blob/main/clip_benchmark/datasets/multilingual_mscoco.py
autodownloading gdrive is possible, done for a few datasets here already


New value for requirePaddingNewLinesInObjects

(Note: this is not quite the same as #1551. That use case should be considered, too!)
Consider these two possibilities:
View.extend({
  initialize: function() {},

  onDestroy: function() {}
});

View.extend({

  initialize: function() {},

  onDestroy: function() {}

});

I've found that people either stick to one or the other (or don't care and mix them).
Afaict it's not possible to allow for up to a single newline padding while disallowing more than that.
One possibility, if #1551 is ignored, would be "requirePaddingNewLinesInObjects": 1, which would allow up to one newline.
shrug I'd use it!
(p.s. forgive me if an issue already exists/was closed in regards to this. I ran a search and nothing came up).

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26447347-new-value-for-requirepaddingnewlinesinobjects?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

I guess new rule would be a better choice, would you like to implement it?

I don't foresee myself having time in the near future, but if I do then I would definitely like to figure out how to implement it.

@jmeas Are you working on it at the moment?

I am not

@jmeas do you mind if I take a shot at it? Or do you prefer to save it for later?

Go for it!

@jmeas Alright, thanks.

Just to be sure I understand what you want in the rule, you want the rule to allow up to 2 line breaks?
These cases would be possible:

disallowMoreNewlinesPaddingInObjects: 1

View.myFunction({
    prop1: function() {},

    prop2: function() {}
});

disallowMoreNewlinesPaddingInObjects: 2

View.myFunction({

    prop1: function() {},

    prop2: function() {}
});

We released 3.0 recently! We also wrote a post about how 3.0 will be our last major release (since we are deprecating the project) and that we are merging with ESLint!
Thus we won't be working on any new features moving forward which includes new rules/options. We will continue to fix bugs and work on CST/better autofixing for current rules in the upcoming months both to help JSCS users and to gain experience that we can hopefully use in ESLint. But otherwise we both teams will be working on getting ESLint feature parity with JSCS and just a nice transition for our users.
I'm putting an orphaned label to note this issue isn't planned to be worked on, but might be a good contribution as a custom rule (not in JSCS core itself).
I would encourage anyone who wants the rule to try writing it themselves: I would either write a custom rule or submit an issue to ESLint and if accepted a PR. Otherwise a custom rule that won't be in core repo itself.
JSCS rules are also very similar to ESLint rules: here are some resources to get started:

Project-specific Lint Rules with ESLint
Creating Custom Rules for ESLint
Maintaining JavaScript Code Quality with ESLint


Will the package be created automatically with correct permissions?

While creating the https://github.com/ASFHyP3/hyp3-isce2 plugin, we ran into an issue where the GitHub package had already been created and did not have correct permissions set to allow the build workflow to push the Docker image, see here: https://github.com/ASFHyP3/hyp3-isce2/issues/3#issuecomment-1483584542
I want to know if everything would have worked if the package had not already been created; would the package be created automatically with the correct permissions? If not, we should document the steps for setting the correct perms.

When the package is initially pushed to GitHub, it's expected that the actions will fail (documented in README) due to permissions errors. Once all the steps in the readme have been completed and the workflows restarted, they should all work:
https://github.com/ASFHyP3/hyp3-cookiecutter?tab=readme-ov-file#hyp3-cookiecutter
I'm going to close this as done, but please re-open if anyone runs into this again.


Static files with path="/"

Hi Guys,
I have a question about serving static files with path="/".
I have found that the problem is here, in line 54.
https://github.com/starlite-api/starlite/blob/e9372128d490667402db2893e47f5cfda0917bab/starlite/asgi.py#L52-L55
Consider this static file configuration:
[StaticFilesConfig(
    directories=[Path(pkg_resources.resource_filename(__name__, 'view_dist'))],
    path='/',
    html_mode=True
)]

and following view_dist subdirectories:
+--- view_dist
    +--- index.html
    +--- diagnostic
        +--- index.html

Requests and its reponses:
URL=http://<IP_ADDRESS>:8000

1. wget -O- $URL/                          --> 200 OK
2. wget -O- $URL/index.html                --> 200 OK
3. wget -O- $URL/diagnostic                --> 307 Temporary Redirect to new location (bad): http://<IP_ADDRESS>:8000diagnostic/
4. wget -O- $URL/diagnostic/               --> 307 like above
5. wget -O- $URL/diagnostic/index.html     --> 404 Not Found

The problems in points 3 and 4 come from the fact that line 54 in asgi.py file removed every occurrences of / from scope['path'] and then the same scope is used in the starlette/staticfiles.py file to build the URL for redirecting purpose, but unfortunately scope['path'] is lack of forward slashes.
https://github.com/encode/starlette/blob/d7cbe2a4887ad6b15fe7523ed62e28a426b7697d/starlette/staticfiles.py#L135-L139
After guarding line 54 (removing every static_path='/' from scope['path']) with extra if it works as expected.
if static_path != '/':
    scope["path"] = scope["path"].replace(static_path, "")

1. wget -O- $URL/                          --> 200 OK
2. wget -O- $URL/index.html                --> 200 OK
3. wget -O- $URL/diagnostic                --> 307 Temporary Redirect to new location (ok): http://<IP_ADDRESS>:8000/diagnostic/ --> 200 OK
4. wget -O- $URL/diagnostic/               --> 200 OK
5. wget -O- $URL/diagnostic/index.html     --> 200 OK

I have just started my journey with starlite so I do not know if and where are the side effects of commented out this line in asgi.py. Do you have any suggestions on what I should do to make all the previously mentioned requests work?

Thanks for the detailed issue and analysis!
I would suggest you clone the starlite repo and make your adjustment while running the tests. This will give you an indication of the impact of this change vis-a-vis other components. If your adjustment work, add another test to ensure that your use case is working correctly, and submit a PR.

ok @proz89 - I looked into this issue. Your solution will work well. Would you like to add a PR with the fix and a test to ensure its working? I can do this of course, but you already did most of the work :)

v1.3.2 released with this fix. thanks for your issue!


Скласти інтро

Скласти інтро (вступ), де в 2-4 реченнях описати, що замовник робить, що подобається робити, що хочеться робити краще, що важливо робити, тощо.

Winnie-the-Pooh, also called Pooh Bear and Pooh, is a fictional anthropomorphic teddy bear created by English author A. A. Milne.
A. A. Milne named the character Winnie-the-Pooh after a teddy bear owned by his son, Christopher Robin Milne, on whom the character Christopher Robin was based. The rest of Christopher Robin Milne's toys – Piglet, Eeyore, Kanga, Roo, and Tigger – were incorporated into Milne's stories. Two more characters, Owl and Rabbit, were created by Milne's imagination, while Gopher was added to the Disney version


Virtual Assistant: When default locale is "zh-cn", welcoming message error

Project
Name: Virtual Assistant,
Language: C#
Description
If default locale is "zh-cn"(Chinese), it will cause welcoming message error and VA is not working properly.
To Reproduce
Set default locale to zh-cn at settings tab

Expected behavior
This message with chinese version

Screenshots

Additional context
I have an customer engagement in China who has a big interest this in automotive scenario. They would like to test this scenario with Chinese.

@ryanlengel it looks like we've lost the localized intro cards with the latest changes

Thank you for your support! 👍


Zuul swagger cooperation

Hello,
It's not a issue, but a question about how is Zuul wonderful and correct reverse proxy solution actually working, namely:
http://public.com/foo-service/names-controller/swagger-ui.html -> http://foo-service:8080/names-controller/swagger-ui.html
How does Zuul make it swagger on http://foo-service:8080 works correctly for external access from http://public.com/foo-service ?
I have a task to replace Zuul with nginx (It's not my decision, I can't change it). I rewrite in nginx http://public.com/foo-service/names-controller/swagger-ui.html to http://foo-service:8080/names-controller/swagger-ui.html , but in swagger response I get broken links - without /foo-service/ that is I get http://public.com/names-controller... instead of http://public.com/foo-service/names-controller/....
With Zuul it was working fine out of the box - magic.
Is there any http request header Zuul is setting that is used by swagger?

Hip Hip ...
proxy_set_header X-Forwarded-Prefix /foo-service/;
helps.


Feature: Allow loader to handle relative paths without moduleId

This is a feature request, I'll dig into the source code to see if it's doable.
On 13-03-17, Angular docs were updated with all references of using moduleId: module.id in the component properties were deleted. It isn't required if one uses the new SystemJS plugin (systemjs-angular-loader.js) and if someone is using Angular CLI then it's already not required.
I think it would be great if tns was able to handle relative paths without moduleId, I see many questions and problems in this repo's issues, it's annoying and easy to forget.

Supported for Webpack builds
e.g.
npm i nativescript-dev-webpack
tns run android --bundle


EventMessage now is a pointer receiver

Fix #362
Signed-off-by: Francesco Guardiani<EMAIL_ADDRESS>

LGTM
nice.


empty /etc/machine-id on fedora

issue boxcutter/centos#37 is also relevant for this base box. Maybe it's best to remove /etc/machine-id in the cleanup script?

I found out that removing /etc/machine-id causes a.o. systemd-journald to fail. By creating an empty machine-id file, systemd will automatically generate a new id:
echo "" > /etc/machine-id

https://github.com/boxcutter/fedora/commit/d478532cadddc49112a5c6d5129197d4bcaa7f2c


Docs: fix type for KeyboardPlugin#manager

This PR

Updates the Documentation

Type for Phaser.Input.Keyboard.KeyboardPlugin#manager was incorrect.

👍


Optimisation for thumbnail

There is no need to rebuild a data uri.
We can use URL.createObjectURL and a Blob.
It is faster, and further use of the URL will be too.

Thanks @bubbatls
Could you update your pull request so it passes the linter rules?

Sorry, I've worked too fast and so... too dirty.
It's done

Thanks again. :)

maybe the code for building data-uri might be used in loadImage.createObjectURL when it is detected it does not work properly

Could you clarify what you meany by "it does not work properly"?

The variable urlAPI might be undefined if it is not available or buggy (for opera 12 as I saw in comments)
And the data-uri might solve the issue, but maybe it is a bad idea to potentielly use it for something bigger than a thumbnail

The EXIF code is only called in browsers that do support DataView.
Opera 12 is an edge case, but I don't think this browser is even supported anymore.
There's still Safari 6 (and potentially other browsers using webkitURL), but that is solved by using loadImage.createObjectURL.

Thanks for the explanation,
And thanks for this project


Add EditTxn Command

Closes #190
TODO

[ ] Add Tests
[ ] Update UG

Realised 2 issues while writing tests for the current version of the EditCommandParser

We need to allow repeated category arguments for adding multiple new categories.
We need to allow empty category tag input as a way to clear a transaction's categories.


Error on building the project: taxonomy_list.html required

Hello, I was trying to build the project but I got into an issue that could not solve which is finding a required file called taxonomy_list.html. (My guess the file was excluded from the repository)
zola build
Building site...
Checking all internal links with anchors.
> Successfully checked 0 internal link(s) with anchors.
-> Creating 5 pages (0 orphan) and 3 sections
Error: Failed to build the site
Error: Failed to render a list of tags page.
Error: Reason: Tried to render `taxonomy_list.html` but the template wasn't found

Hey, could you provide me with your config.toml and maybe your repository?
I only implemented a bare minimum and may have forgotten to implement this as I never ran into this error.

Hello, Please notice that I was following your documentation and also copy sections from the config.toml example, after I was uncomenting is section to also understand the template and fixing the errors until I got into the one I could not solve.
here is the toml file data:
# The URL the site will be built for
base_url = "https://decentralizedscience.org"

# Whether to automatically compile all Sass files in the sass directory
compile_sass = true

# Whether to build a search index to be used later on by a JavaScript library
build_search_index = false

taxonomies = [
    { name = "tags", feed = true }
]

[markdown]
# Whether to do syntax highlighting
# Theme can be customised by setting the `highlight_theme` variable to a theme supported by Zola
highlight_code = true

# Papermod Theme
theme = "papermod"

[extra]
# Put all your custom variables here

[extra.papermod]
title = "PaperMod"
default_theme = "auto"
theme = "light"
language_direction = "auto"
keywords = ["keyword1", "keyword2", "keyword3"]
#show_theme_toggle = true
#show_scroll_to_top = true
#show_code_copy_buttons = true
#show_reading_time = true
#show_word_count = false
#show_post_nav_links = true
#show_post_meta = true
#default_toc_open = false
#edit_post_url = "https://github.com/cydave/zola-theme-papermod/tree/master"
##copyright = ""
date_format = "%Y-%m-%d"
#navigation = [
#    { url = "$BASE_URL/archive", title = "Archive" },
#    { url = "$BASE_URL/tags", title = "Tags" },
#    { url = "https://getzola.com/", title = "Zola", is_external = true }
#]

home_title = "PaperMod"
home_content = "Welcome to a demo of the PaperMod theme!
PaperMod is a simple but fast and responsive theme with a useful feature-set that enhances UX.
Do give a 🌟 on Github !
PaperMod is based on the hugo-PaperMod theme."
social_icons = [
    { url = "https://github.com/cydave", title = "GitHub", icon = "github" },
    { url = "https://infosec.exchange/@cydave", title = "Mastodon", icon = "mastodon" },
    { url = "https://twitter.com/_cydave", title = "Twitter", icon = "twitter" },
    { url = "$BASE_URL/atom.xml", title = "RSS", icon = "rss" },
]

Best Regards.

Thanks for your config. However, I can't seem to reproduce this exact issue you have.
Invoking the following commands leads to a successful build:
$ git clone git@github.com:cydave/zola-theme-papermod.git && cd zola-theme-papermod && zola build

Cloning into 'zola-theme-papermod'...
remote: Enumerating objects: 201, done.
remote: Counting objects: 100% (201/201), done.
remote: Compressing objects: 100% (119/119), done.
remote: Total 201 (delta 83), reused 169 (delta 55), pack-reused 0
Receiving objects: 100% (201/201), 203.15 KiB | 437.00 KiB/s, done.
Resolving deltas: 100% (83/83), done.
Building site...
Checking all internal links with anchors.
> Successfully checked 0 internal link(s) with anchors.
-> Creating 5 pages (0 orphan) and 3 sections
Done in 53ms.

I'm not sure if you run into this issue due to a version difference perhaps?
I'm building with zola version 0.17.2.

Issue solved, thank you! :+1:


Can't have a function that returns sdl::Sdl.

Hey, I'm writing my own little game thingy and I decided to move away the initial code that is pretty much required in every project. Here is my function:
pub fn bootstrap<'a>(win_width: i32, win_height: i32, win_name: &str) ->
    (sdl2::render::Renderer<'a>, sdl2::sdl::Sdl) {
    let sdl_context = sdl2::init().unwrap(); // context
    /* ommited unimportant */

    (renderer, sdl_context)
}

Now, when I attempt to compile that, I get an error saying that sdl2::sdl::Sdl is prviate.
I checked the source code and there it's defined as public,
pub struct Sdl {
    sdldrop: Rc<SdlDrop>
}

I don't have a lot of experience of Rust so I don't know how public/private works here, but, I think I should be able to return that struct.
I'm not sure if this qualifies as an issue, but I looked for help on Rust's IRC channels for too much time and nobody was able to help me solving that problem.

I encountered the same when I tried to pass EventPump to another function. Declared as a pub struct in library, but gives an error stating that EventPump is private.
Is this intended behaviour?

Give sdl2::Sdl a try instead, which is a public alias for sdl2::sdl::Sdl. The sdl2::sdl module is private, with all of its items re-exported at the crate level. This is the same with sdl2::EventPump. source
I believe sdl2::sdl::Sdl was the old way, which was changed to look less redundant. :]


Verify formatting with a check command

Many formatters provide a way to verify that files are formatted, essentially by running formatting on the file and making sure nothing changed. This is useful in CI, whether for checking things like idempotency in this repo or checking that all files are formatted in pull requests for users.
https://prettier.io/docs/en/cli.html#--check

Yeah, this would be really useful!

I can take care of this one this weekend 👍


If a resource do not have a reply statement when you run the service you would get "ballerina: -1"

Checked on 0.88 release. Please try to run the following service.
package wso2.hospital.sample;
import ballerina.net.http;
service Service1 {
    @http:GET {}
    @http:Path { value: "/dest" }
    resource Resource1 (message m) {
    }
}
It will give you "ballerina: -1" as the command output. Instead of -1 it will be helpful to get a meaningful error message.

cannot reproduced in the latest 0.92-SNAPSHOT version. Hence closing the issue.


Export * to avoid having to enumerate all functions

Also helps so we don't forget to export functions as we add them.  We're
already exporting them from the defined module so this is a second
explicit export

is this a bad idea?  I can't think of why it would be, but something about it feels weird lol


menus.OnClickData.frameId not modeled

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/OnClickData
The frameId property is not registered in the model:

Adding an any cast allows me to access the property anyway:

The property exists at runtime in chrome (where I originally wrote this addon) and firefox:

Please add the definition :)

Thanks for the report. Will be fixed in the next version.

Awesome, thanks for the quick fix

Next version has just been released.


Cannot quit Franz on Windows 10

It is not possible to quit Franz without using the task manager. Closing Franz with the x-Button in the upper left corner will minimize it. Going over the menu and pressing "Close Franz" will do nothing.
Expected Behavior
Franz quits on at least one of the two options.
Current Behavior
Franz stays open.
Your Environment
Windows 10
Version: 5.0.0-beta.18
Release: 1.8.4 / win32 / x64

Sorry, duplicate of #902


Add headless/wildcard dns names to service certificate

To deal with issue https://github.com/OpenLiberty/open-liberty-operator/issues/605

@leochr
I don't think that DNS entries are created for the pods+ regular service.
[root@ubi9 /]# host init-stateful-rco-0.init-stateful-rco-headless.rco.svc.cluster.local
init-stateful-rco-0.init-stateful-rco-headless.rco.svc.cluster.local has address <IP_ADDRESS>
[root@ubi9 /]# host init-stateful-rco-0.init-stateful-rco.rco.svc.cluster.local
Host init-stateful-rco-0.init-stateful-rco.rco.svc.cluster.local not found: 3(NXDOMAIN)

Have I misunderstood how these are constructed?

@idlewis Just had the chance to revisit this. You are right. What's currently specified is good. Thanks


Verify CA equivalent in the new API

I've noticed that the set_force_verify_ca method, along with other methods, has been removed from the MqttOptions type in the new version. I'm unsure of the equivalent method for set_force_verify_ca in the new version.
In my case, self-signed certificates were used for tests and lower environments, and I need to upgrade to a newer version. I see that I need to use the new ConnectionType::TLS, but I can't find a way to set it to not verify the CA.
Any suggestions how to us thisn ow?

Yes, rustls is the default now and doesn't support disabling CA verification. See more here: https://docs.rs/rustls/0.22.2/rustls/index.html#rustls-takes-care-of-server-certificate-verification
For dev env, you need proxy CA with the signed root certificate, look for mkcert or openssl on how to create those for localhost.

I'll update the documentation on a development environment.


Update JSDoc template with current openui5/master

Note: this PR contains two commits which might not be backward compatible (to be discussed)

Rebased to resolve test issues

Coverage remained the same at 89.406% when pulling 11bc3a5b1e9546144749b66927b3396fc648486b on update-jsdoc-template-next into f448567957a8b8c4c8d5edf4e40fcb36a095987b on next.

The topic of backward compatibility of the template part has been discussed and we decided to keep the templates aligned between builder and openui5. Currently, the JSDoc build step of the tooling is mainly used for internal testing purposes and there alignment with the productively used openui5 template is more important than the ability to build JSDoc for older releases with the most recent ui5-tooling.
Plus, the compatibility issues mainly stems from necessary/missing changes in the SDK part and we are not aware of a scenario where the combination of ui5-tooling and SDK is used other than during SAP internal development of openui5/sapui5.

ping

Hi so from our side we would like the option for changing the JSDoc/ API.JSON template.
We are using the JSDoc build to create a demokit for our custom libraries.
Currently, we are forced to stay at a specific ui5 cli version depending on the ui5 version the library supports.

Hi so from our side we would like the option for changing the JSDoc/ API.JSON template.
We are using the JSDoc build to create a demokit for our custom libraries.
Currently, we are forced to stay at a specific ui5 cli version depending on the ui5 version the library supports.

Thanks for the input! Yes, this is still a gap. I  guess this enhancement is still tracked here: https://github.com/SAP/ui5-tooling/issues/356
Unfortunately I still don't have a good idea on how to easily solve this. Maybe an option to provide your own plugin would be a good solution for the time being?


Add extra note about aspect ratio of screenshots

Maybe we should just mandate viewport width instead of width/height?

Maybe we should just mandate viewport width instead of width/height?

I feel like it's fine and just more consistent to enforce both width and height? Unless it's causing some particular issue, then it might not be that important.


Add support for XRWebGLLayer.multiview

May be removed via https://github.com/immersive-web/webxr/pull/361


Remove the account-api levels-of-authentication feature flag

Deploy this after https://github.com/alphagov/account-api/pull/95

Trello card

We just never used it in integration


docs: new features in 3.6

Motivation
Keep users of Argo Workflows well informed of the new features in each release.
Until the next RC is out the feature list is subject to change. This is correct for RC-2 only. This PR will be updated as RC-3 is cut and merged then.
Modifications
Add a features-3.6.md (with the intention that each version will have its own page) with a concise list of all features based around the blog posting. Aiming for less celebratory, more factual.
Update the new features modal for the UI in preparation for 3.6 with a similar summary as per the Kubecon video.
Verification
Validated modal visually and by clicking the links. RTD 3.6 is not yet a thing, but changing to 3.5 for the cron-workflows link works as expected.

Validated new features page here in markdown too.

I have also added the features merged since RC-2


Add Stringfy utility & StringEquals utility functions to pkg/adapter.

Adapters can use this to convert ValueType data into string.
Also, compare stringified values of two interface{} objects.
Idea is to have a shared performant code that most adapters commonly need.

PTAL

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ce62dd8b3986e23fece8fb0fe870b32b8372022f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ce62dd8b3986e23fece8fb0fe870b32b8372022f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ce62dd8b3986e23fece8fb0fe870b32b8372022f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ce62dd8b3986e23fece8fb0fe870b32b8372022f
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
60165c98b4f68e15e86d366e14b46570fa7226f6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
60165c98b4f68e15e86d366e14b46570fa7226f6
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
60165c98b4f68e15e86d366e14b46570fa7226f6
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
48bb5457e0a1775cfb50109b53a8a00e062e6097
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
eda369416c5787b00d7a9327ddb944228438829d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
eda369416c5787b00d7a9327ddb944228438829d
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
9567a1a0df8bc1a51f3f5b80c4d8e2b871d40668
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

/test istio-unit-tests

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
eda369416c5787b00d7a9327ddb944228438829d
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
9567a1a0df8bc1a51f3f5b80c4d8e2b871d40668
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Added Account Setup Page

Add Test Instructions

[ ] Open https://deploy-preview-28--create-app.netlify.app/
[ ] Log out if previously logged in.
[ ] Refresh the page.
[ ] Log in
[ ] After logging in should see the account setup screen, fill in the organization and language (test_org and English preferably, BTW I added you to test_org)
[ ] Then click on SAVE AND CONTINUE
[ ] Should now see the Resource Workspace screen

This change is

LGTM - merged

LGTM - merged


The definition of bill of exchange needs clarification

The original definition is ok, but a bill of exchange is not a fixed income security and should be higher up in the class hierarchy - possibly under tradable debt instrument.  It's subclass, banker's acceptance, should be both a bill of exchange and fixed income security however.  Some additional explanatory notes would be helpful as well.

Change is merged


minidump 0kb

Review the documentation: https://docs.sentry.io/platforms/javascript/electron/
Search for existing issues: https://github.com/getsentry/sentry-electron/issues
Use the latest release: https://github.com/getsentry/sentry-electron/releases
Provide a link to the affected event from your Sentry account

Versions + Platform

SDK version -<EMAIL_ADDRESS>Electron version -<EMAIL_ADDRESS>Platform - Windows

Description
After minidump submitted. It was found to be 0KB DMP. Under what circumstances does this happen?

We have just released v3.0.0 of the SDK which includes a lot of changes and improvements since this issue was opened.
If you can still reproduce this with v3, please open a new issue and I'll look into it.


RT-1.20: BGP 2-byte and 4-byte ASN support with policy

This test is now numbered as RT-1.23 for conflict resolution. For Goggler's, changes in cl/564773495. Juniper please update the test accordingly


Fix for Pandas merge overload wrong handling of string literals

I don't think I follow. I guess @shssf suggested something like the below. Why doesn't it work?
@overload(pd.merge_asof)
def merge_asof_overload(left, right, on=None, left_on=None, right_on=None,
                        left_index=False, right_index=False, by=None, left_by=None,
                        right_by=None, suffixes=('_x', '_y'), tolerance=None,
                        allow_exact_matches=True, direction='backward'):

    # 'on' can be a list or a string literal
    if isinstance(on, types.StringLiteral):
        # use literal strings value to fetch them as consts from IR later
        new_right_on = on.literal_value
        new_left_on = on.literal_value
    elif on is not None:
        new_right_on = on
        new_left_on = on

        def _impl(left, right, on=None, left_on=None, right_on=None,
                  left_index=False, right_index=False, by=None, left_by=None,
                  right_by=None, suffixes=('_x', '_y'), tolerance=None,
                  allow_exact_matches=True, direction='backward'):

            return hpat.hiframes.api.join_dummy(left, right, new_left_on, new_right_on, 'asof')

    return _impl

Ignore my previous (deleted) comment.
What is the error of the original code?

@fschlimb
The original error was "ValueError: Failed in hpat mode pipeline (step: typed dataframe pass)" in
get_const_or_list() in dataframe_pass.py. I'm attaching the file with full traceback here: https://github.com/IntelPython/hpat/files/3441340/full_traceback_for_test_join.txt

You should make sure you're using a compatible version of numpy
This means you have to understand why get_const_or_list() fails. Its name suggests it is intended to address exactly the issue you observe with literals/consts.

@fschlimb

OK (it goes away with downgrading to scikit-learn=0.19.1 and numpy=1.16.1)
I believe the problem is in how Numba treats 'on' variable in the original merge implementation.
That is, during Numba type inference 'on' becomes an instance of TypeVar class, so assigning later this value to left_on and right_on will not make them the same constant (we need to assign obj.literal_value for that). Maybe Numba fails to add const names 'left_on' and 'right_on' in IR when it copies Literal[Str] object?

And in _get_const_or_list() we merely try to find const (or lists) objects by name in self.func_ir, which fails due to above (no such const names exist in IR). I have no explanation why it works for lists though, probably, because they are created differently (via build sequence).
@overload_method(DataFrameType, 'merge')
@overload(pd.merge)
def merge_overload(left, right, how='inner', on=None, left_on=None,
right_on=None, left_index=False, right_index=False, sort=False,
suffixes=('_x', '_y'), copy=True, indicator=False, validate=None):
def _impl(left, right, how='inner', on=None, left_on=None,
        right_on=None, left_index=False, right_index=False, sort=False,
        suffixes=('_x', '_y'), copy=True, indicator=False, validate=None):
    if on is not None:
        left_on = right_on = on       # <-------- Even though 'on' was string literal, here we assign
                                      # some Numba object, not object's literal value, hence left_on and
                                      # right_on are not found as const objects in self.func_ir later
    return hpat.hiframes.api.join_dummy(
        left, right, left_on, right_on, how)

return _impl

@fschlimb
Thank you for helping me sort that out and suggesting a better solution!
I had to modify the check a bit though, i.e. instead of
if isinstance(on, types.NoneType)
use
if isinstance(numba.typeof(on), types.NoneType)
because, with the first version other tests that do not provide 'on' argument fail.
It looks like that check always returns True. It may be because Numba's NoneType is not inherited from python's None:
https://github.com/numba/numba/issues/3590
So we can either compare to NoneType but use typeof(on), as in this commit, or we can use the following negated check:
onHasValidType = isinstance(on, types.StringLiteral, types.List)
both of which appear to work.

I had to skip back one of the tests - test_merge_asof_parallel1 - which still fails on NUM_PES=3 build now with a different error and only on the second test run.  It can be seen in Travis logfile that it is passed on the first run though, so probably it's due to the problem with
test_series_head_index_parallel1
which is not skipped at the moment, but was identified as a root cause of corrupting memory and causing other test failures.
I'm going to deal with skipping test_series_head_index_parallel1 and unskipping other tests in PR#100 anyway, so I hope it's not a big issue.


Update readme

Update ImportErrors to Deprecated

Coverage remained the same when pulling 378d9437aede81f80007dcd2fd7b82ff724f0233 on bugzPDX:update_README into 8fee11c5b35252d0df4ca892a469ce522f422c2d on mozilla:master.

Noticed your comments after I squashed commits and pushed. I'll make those changes and resubmit.

Coverage remained the same at 90.61% when pulling 3245b36a92eddfd63ed1018800e01690f294ea9e on bugzPDX:update_README into 6f1b946a797e6e9e187845b59e08c32b09a437f6 on mozilla:master.

Coverage remained the same at 90.61% when pulling 388db497535a46c683cb6a3106fd77639dd81d0d on bugzPDX:update_README into 6f1b946a797e6e9e187845b59e08c32b09a437f6 on mozilla:master.


MNT Skip test if Page class missing

Issue https://github.com/silverstripe/gha-ci/issues/37
Fix https://github.com/silverstripe/recipe-core/runs/7490756091?check_suite_focus=true#step:12:129
 1) SilverStripe\Dev\Tests\Validation\RelationValidationTest::testIgnoredClass with data set "page should by included by default (empty namespace)" ('Page', null, array(), false) ReflectionException: Class "Page" does not exist
Page is defined in silverstripe/recipe-cms which is included by silverstripe/installer, which most modules will use.  recipe-core however will not include silverstripe/recipe-cms, hence the Page class is missing
This unit-test will be run in multiple other builds, so it's OK to skip for silverstripe/recipe-core

phpcs 3.6.2 won't let me ignore the missing namespace despite seemingly using the correct syntax
<?php
// phpcs:ignoreFile -- ignore missing namespace
use SilverStripe\Dev\TestOnly;

class RelationValidationFixtureNoNamespace implements TestOnly
{

}

FILE: ...tests/php/Dev/Validation/RelationValidationFixtureNoNamespace.php
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 5 | ERROR | Each class must be in a namespace of at least one level
   |       | (a top-level vendor name)
-----------------------------------------------------------------------

MOG


[oneMKL] Fixed namespace for math functions in Student's T-test. USM version

Existing Sample Changes
Description
Replaced sycl:: with std:: for math functions in the Student's T-test sample (USM version)
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode
[ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Adding @jimmytwei to merge changes


Chrome Webstore?

Dear @sasindumendis,
I found your great extension here.
Thank you!
Do you have any plans to add this extension to the Chrome Webstore?
Thankfully,
~Robert

@orschiro Glad to hear you found it useful!
TBH this was a little experiment to see if I can rely on Google Keep for note taking as a power user. Therefore didn't really have plans to add it to Webstore nor I saw enough interest from others to do so.

Alright, get your point.
Thanks for your quick response! :smiley:
~Robert


Links for @see tags in class DocBlocks don't go anywhere

I've just started using phpDocumentor for the first time and it's going well.
Unfortunately, I've found that if i put a @see tag in a class docblock it doesn't get linked like other @see tags do. eg:
/**
 * @see SecondClass SecondClass // A link will be displayed but the href will be empty.
 */
class FirstClass {
    /**
     * @see SecondClass SecondClass // This will link to SecondClass, as expected.
     */
    public function MyFunction() {
    }
}

class SecondClass {
}

I've tried using fully resolved namespaces, like \MyCompany\SecondClass and also linking to methods. I've tried linking to everything I can think of but I can't get anything to work.
Perhaps related: @see links will only display if I specify link text. @see SecondClass won't display anything, regardless of where the tag is.
I'm using phpdoc 2.8.5 with the 'clean' template. I'm using PHP 5.5.27, on Ubuntu 14.04.
Is this a bug or am I doing something wrong? Any help would be much appreciated!

Wow that was hard to debug! Tracked it down to a problem with the template though. I'll file a pull request soon.

Thank you for your pull request; the fix will become available with the next release of phpDocumentor or on the master branch of phpDocumentor


Pretrain using fairscale with model parallelism?

Currently, all snippets are based on Hugging Face Transformers. Will there be examples of how to fine-tune full parameters using FairScale? It seems that the model was originally pre-trained using FairScale and model parallelism. Such examples would be useful for fine-tuning or continuing to train the model.

@glin93 we are mostly investing on PyTorch FSDP for training in this repo for now. You might be able to open an issue on the llama if interested in FairScale finetuning recipes.


fix run_tests bash syntax error

fix error
Proposed changes
CircleCI mentioned a bash syntax error in run_tests.sh (run_tests.sh: 7: [: 0: unexpected operator e.g. in this job)
Fixed the bash syntax here.
Types of changes
What types of changes does your code introduce to the project: Put
an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[ ] I have added tests that prove my fix is effective or that my
feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in
downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion
by explaining why you chose the solution you did and what alternatives
you considered, etc...

"mac" stories, thanks for the fix.


Update Guide.md

A fresh install of the Xcode command line tools requires the user to accept the Term of Service before you can build anything with it.

I might be wrong, but I think that's not required if you launched Xcode at least once, right?

That may be the case.  That sounds reasonable but I didn't try that route. I was just following the guide step-by-step.

@chevybowtie  sudo xcodebuild -license accept would be sufficient.

@chevybowtie Yes, please change to sudo xcodebuild -license accept before it's ready to merge :+1:

Thanks @xfreebird

Done. Thanks for the consideration.

Thanks for updating @chevybowtie :+1:

This was my first pull request. Thanks for being gentle.
-- Paul Sturm
Arlington, Texas
Public Key @ http://pgp.mit.edu:11371/pks/lookup?p=get&search=0xA5A216CB9628D924
Key fingerprint = E5BF DBFB 7EE3 CB00 BD1F  721E A5A2 16CB 9628 D924
On Mon, Oct 26, 2015 at 10:38 PM, Felix Krause<EMAIL_ADDRESS>wrote:

Thanks for updating @chevybowtie :+1:
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/fastlane/pull/736#issuecomment-151363205


bug: shortform language labels not recognized

Neovim version (nvim -v)
NVIM v0.10.2
Neovim distribution
N/A
Operating system
macOS 15.1 (arm)
Terminal emulator / GUI
Neovide
Describe the bug
only longform codeblock labels work, short form ones are not.
```py
print("Hello")
```

```python
print("Hello")
```

Expected behavior
Both should be rendered correctly, since both are valid for GitHub (i.e., both get correct syntax highlighting from GitHub).
Healthcheck output
render-markdown.nvim [version] ~
- OK plugin 7.5.4
- OK neovim >= 0.10

render-markdown.nvim [configuration] ~
- ERROR Failed to run healthcheck for "render-markdown" plugin. Exception:
  .../lazy/render-markdown.nvim/lua/render-markdown/state.lua:202: attempt to call method 'for_each' (a nil value)

Plugin configuration
-- don't think this is relevant, but nonetheless, here:
		opts = {
			render_modes = { "n", "c", "i", "v", "V" },
			bullet = {
				icons = { "▪", "▫", "•", "◦" },
			},
			heading = {
				icons = {}, -- disables icons
			},
			code = {
				border = "thick",
				position = "left",
			},
			sign = { enabled = false },
			win_options = {
				-- toggling this plugin should also toggle conceallevel
				conceallevel = { default = 0, rendered = 3 },
			},
		},

Plugin error log
N/A

Confirmations

[X] I have updated this plugin to the latest version using my plugin manager
[X] I have provided the text contained in all screenshots as raw text in this issue. This means if there is a screenshot below it is the copy pasted contents of the file in the screenshot. I understand that my issue will be closed if I have not.

Additional information
No response

Currently we only support getting by language name. Whether or not GitHub supports something or not does not make this a bug, the goal is not feature parity with GitHub.
Supporting extensions as a fallback is a reasonable feature request, I'll see what I can do. Currently we use the following APIs depending on icon provider:

For mini.icons we call get('filetype', language)
For nvim-web-devicons we call get_icon_by_filetype(language)

I'm interested in the error you're getting in the healthcheck:
- ERROR Failed to run healthcheck for "render-markdown" plugin. Exception:
  .../lazy/render-markdown.nvim/lua/render-markdown/state.lua:202: attempt to call method 'for_each' (a nil value)

I'm not sure how this is possible and curious how you're getting it. It seems like somehow the health.lua file is out of sync with the state.lua file.
The only way to have version 7.5.4 in the output is to be on the latest commit: https://github.com/MeanderingProgrammer/render-markdown.nvim/commit/d69a885e1bf21cb329d2eafe56fd80b6de627216.
But the error about for_each on line 202 is only possible if your state.lua file is the one prior to that commit, so the files are from different commit.
Did lazy.nvim run into any errors when updating? If you try to update again and run the healthcheck do you still get the error?

Did lazy.nvim run into any errors when updating? If you try to update again and run the healthcheck do you still get the error?

Ran it again on the same commit, got no errors this time:
render-markdown: require("render-markdown.health").check()

render-markdown.nvim [version] ~
- OK plugin 7.5.4
- OK neovim >= 0.10

render-markdown.nvim [configuration] ~
- OK valid

render-markdown.nvim [nvim-treesitter] ~
- OK installed
- OK markdown: parser installed
- OK markdown: highlight enabled
- OK markdown_inline: parser installed
- OK markdown_inline: highlight enabled
- OK latex: parser installed

render-markdown.nvim [executables] ~
- WARNING latex2text: not installed
  - ADVICE:
    - Disable LaTeX support to avoid this warning by setting { latex = { enabled = false } }

render-markdown.nvim [conflicts] ~
- OK headlines: not installed
- OK obsidian: not installed

Huh, I wonder what happened the first time, maybe an edge case due to updating without restarting neovim?
Files that had already been used in the session like state.lua were using the older version since those were cached and files that had not been used yet like health.lua and the validator pulled the newer version.
At least that would kind of make sense but just a guess on my part. Glad it's working in either case!

Should work after: https://github.com/MeanderingProgrammer/render-markdown.nvim/commit/78a2eb7fc273f36790aa390262f390a3265eedff

Thank you!


Changed figure size in StreetPlotGenerator using bounding box and cor…

…rected city's bounding_box method
City's bounding_box method didn't admit cities with no roads or no blocks or no buildings. I've fixed that. As long as the city is not empty, the method should work.

@basicNew , it's updated.


1 create redis terraform module

What changes does your PR bring?
In a few words, describe what changes your commits make to the code.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Chore (non-breaking change to the build process or auxiliary tools)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation (Improvements or additions to documentation)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)

References
Fixes:
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Readme file is missing in the example


feat(page): Added 'referer' as a parameter in options of Page.goto()

If referer is passed to the options object its value will be used as the referer instead of the value set by Page.setExtraHTTPHeaders().
Fixes #3090

Can anyone review this please?

@aliahmad490 thank you for the PR!


prepublish npm script broken

It's currently with an extra dot and is breaking for me:
    "prepublish": ". ./scripts/prepublish.sh",

needs to be:
    "prepublish": "./scripts/prepublish.sh",

I'll submit a PR (probably merged with my other one :)

A Fix for this is landed in v1.25.0.


Error loading shared libraries on Linux

After removing all parts of the GameSDK that use std:: (for example std::int32_t becomes int32_t) and adding using namespace std; to types.h (to fix #20), the engine compiles successfully. But when I try to run an empty scene in an empty project, I get the following error:

Even though the file structure is correct:

I think the error occurs because the godot instance that runs the scene isn't opened from the executable directory. An easy fix is to modify the rpath of the executable by running patchelf --set-rpath '$ORIGIN' path/to/godot/executable (similar to the last step for compilation on mac OS). I am currently trying to set the rpath correctly at compile time but nothing has worked so far.

I think the error occurs because the godot instance that runs the scene isn't opened from the executable directory. An easy fix is to modify the rpath of the executable by running patchelf --set-rpath '$ORIGIN' path/to/godot/executable (similar to the last step for compilation on mac OS). I am currently trying to set the rpath correctly at compile time but nothing has worked so far.

I think the error occurs because the godot instance that runs the scene isn't opened from the executable directory. An easy fix is to modify the rpath of the executable by running patchelf --set-rpath '$ORIGIN' path/to/godot/executable (similar to the last step for compilation on mac OS). I am currently trying to set the rpath correctly at compile time but nothing has worked so far.

Does the rpath have to be absolute?

I think the error occurs because the godot instance that runs the scene isn't opened from the executable directory. An easy fix is to modify the rpath of the executable by running patchelf --set-rpath '$ORIGIN' path/to/godot/executable (similar to the last step for compilation on mac OS). I am currently trying to set the rpath correctly at compile time but nothing has worked so far.

Does the rpath have to be absolute?

No, from my testing, a relative path in rpath is interpreted from the location the binary is executed. So if the rpath is set to ./ and I execute bin/godot.x11.opt.tools.64, only ./ would be searched for the shared binary but not ./lib. $ORIGIN is replaced with the location of the binary not matter where I execute it. So when executing bin/godot.x11.opt.tools.64, ./bin would be searched for the shared library

No, from my testing, a relative path in rpath is interpreted from the location the binary is executed. So if the rpath is set to ./ and I execute bin/godot.x11.opt.tools.64, only ./ would be searched for the shared binary but not ./lib. $ORIGIN is replaced with the location of the binary not matter where I execute it. So when executing bin/godot.x11.opt.tools.64, ./bin would be searched for the shared library

Yeah I got it, Godot now successfully plays the scene without the error mentioned above, but I'm testing the Activity Manager and it's not working for me atm. Most likely not a problem related to this though so I'll see if I can get it sorted out.

Yeah I got it, Godot now successfully plays the scene without the error mentioned above, but I'm testing the Activity Manager and it's not working for me atm. Most likely not a problem related to this though so I'll see if I can get it sorted out.

In the mean time can you look into merging #24 and #23

In the mean time can you look into merging #24 and #23


Support for C/C++ language settings

Hi,
in the readme I see it supports Text, Java, XML and Ant editors.
Are there plans to support C language files?
br

I use Vim for editing C language files so I'm not motivated to add support myself. Contributions are welcome ofcourse. Implementing the tab settings for other types of editors is reasonably straight forward as long as the editor supports that setting. The hard part is figuring out what the property to set is called. See https://github.com/ncjones/editorconfig-eclipse/blob/master/editorconfig-eclipse-plugin/src/main/java/com/ncjones/editorconfig/eclipse/EditorConfigEditorActivationHandler.java#L62


Add more example data

It would be nice to add some more example data-sets.
Ideally these should meet the following criteria:

Contain at least two different modalities
Contain high resolution EM or LM that allows segmenting objects of interest, e.g. cells or nuclei
Possible to host the data publicly (s3)

Moved example data to the actual mobie repo.


Update to Web API 2

@filipw, if we bump to 2.2, those who have not updated to 2.2 will be prevented from using the lib. This allows 2.* users to continue using the library.

@ChrisMissal, nothing specific, just a second pair of eyes.

@filipw, if you think we should bump to 2.2, let's do that in another PR. @ChrisMissal, thanks for your light review. I re-reviewed and commented on the only real change above.


Wireguard Network Dies on v1.7.2

Describe the bug
Something between v1.7.0 and v1.7.2 the broke network connectivity of a Wireguard container that other containers are piped through
To Reproduce
Not a full repro since it will require VPN credentials but something like the following may reproduce
services:
  wireguard: # VPN service, Transmission depends on this
    image: thrnz/docker-wireguard-pia
    container_name: wireguard
    environment:
      # The following env vars are required:
      - LOC=REDACTED
      - USER=REDACTED
      - PASS=REDACTED
      - LOCAL_NETWORK=<IP_ADDRESS>/24
    ports:
      - 9091:9091 #transmission
      - 51413:51413 #transmission
      - 51413:51413/udp #transmission
    cap_add:
      - NET_ADMIN
      - SYS_MODULE
    devices:
      - /dev/net/tun
    sysctls:
      - net.ipv4.conf.all.src_valid_mark=1 # wg-quick fails to set this without --privileged, so set it here instead if needed
      - net.ipv6.conf.default.disable_ipv6=1
      - net.ipv6.conf.all.disable_ipv6=1
      - net.ipv6.conf.lo.disable_ipv6=1
    restart: unless-stopped

  transmission:
    depends_on: ["wireguard"]
    image: ghcr.io/linuxserver/transmission
    container_name: transmission
    network_mode: "service:wireguard"
    restart: unless-stopped

Expected behavior
Network connectivity shouldn't crash (as it does in v1.6.4 and v1.7.0)
Diagnostic report (REQUIRED)
OrbStack info:
  Version: 1.7.2
  Commit: 50f93373f351fe839fd72948e6aad032774c0f6c (v1.7.2)

System info:
  macOS: 14.6.1 (23G93)
  CPU: arm64, 8 cores
  CPU model: Apple M2
  Model: Mac14,3
  Memory: 16 GiB

Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2024-09-11T21-31-28.301592Z.zip
<!-- (To review the report, check ~/.orbstack/diag) -->

Screenshots and additional context (optional)
Troubleshooting steps I've taken:

Reboot host
Reinstall Orbstack
Wipe persisted container configurations/data
orb reset and orb delete --all
Downgrade to v1.7.0 and v.1.6.4 and confirmed functionality

Please also see attached a screen recording of the network dying: https://github.com/user-attachments/assets/48ab75f1-6cf9-4dec-8464-15302d253928
If there's anything else I can provide to help, please let me know. Thanks!

I also have the same issue. I run OpenVPN inside the container and expose it as a proxy. Browsing the web with the proxy is fine, but when uploading a large file (50MB) or sending lots of requests, the network dies.
Downgrade to 1.7.0 and it working again.

I can confirm this issue still persists in v1.7.5.
similar setup as @dangh describes, except I use a nordlynx based proxy

Wow - I have been pulling my hair out over this for the last few weeks. VPN service was constantly dying when running via Orbstack. After downgrading to 1.7.0, the issue stopped and the VPN stayed up.
I am currently running a Wireguard VPN but over the course of the last few weeks I have tried both OVPN & Wireguard configurations as well as a variety of VPN images/approaches with no success.
For others - older versions of Orbstack are listed here: https://docs.orbstack.dev/downgrade
Relevant compose below although I build the dependant image locally:
services:

  nordvpn:
    image: qmcgaw/gluetun:latest
    container_name: nordvpn
    cap_add:
      - NET_ADMIN
      - NET_RAW
    devices:
      - /dev/net/tun:/dev/net/tun
    restart: always
    ports:
      - 8388:8388/tcp
      - 8388:8388/udp
      - 9091:9091
      - 51413:51413
      - 51413:51413/udp
    environment:
      VPN_SERVICE_PROVIDER: nordvpn
      VPN_TYPE: wireguard
      WIREGUARD_PRIVATE_KEY: ************
      SERVER_COUNTRIES: Australia
      TZ: Australia/Sydney

  transmission:
    platform: linux/amd64
    build:
      dockerfile: Dockerfile
      context: .
    container_name: transmission
    restart: always
    depends_on:
      - nordvpn
    network_mode: container:nordvpn
    cap_add:
      - SYS_ADMIN
      - NET_ADMIN
      - DAC_READ_SEARCH
    volumes:
      - /Volumes/Media/Transmission/config:/config
      - /Volumes/Media/Transmission/downloads:/downloads
      - /Volumes/Media/Transmission/watch:/watch
    environment:
      - TZ=Australia/Sydney

Now that I'm on macOS 15.1 (upgraded to M4 Mac) I'm in a weird spot where I can't downgrade and this functionality is broken for me in Orbstack.
@kdrag0n @os-emmie apologies for the direct ping but do you have a sense of if we can expect this behavior to be fixed? I am irrationally upset that I'm using Docker Desktop for the time being. 🙃 Thank you for your work on Orbstack!

Same problem here, also on the latest MacOS (non-beta) and Orbstack 1.8.2. Wireguard is broken. The initial handshake goes well, but as soon as some traffic starts going through the tunnel, the connection dies and doesn't recover.

FYI, I think it's working fine again in 1.9.0. At least I haven't had any issue with Wireguard so far (In ~1 week).

FYI, I think it's working fine again in 1.9.0. At least I haven't had any issue with Wireguard so far (in ~1 week).

nonono….not work for me….lol. So there is no way to run wireguard in orbstack docker?
shadowsocks runs well. So now I can only use shadowsocks….

FYI, I think it's working fine again in 1.9.0. At least I haven't had any issue with Wireguard so far (in ~1 week).

nonono….not work for me….lol. So there is no way to run wireguard in orbstack docker?
shadowsocks runs well. So now I can only use shadowsocks….

That's weird, it's still going fine for me a week later, including in 1.9.1 and 1.9.2. Maybe try resetting the Orbstack VM by running orbctl reset, see if it helps?

1

I am not use VM. Use docker

If you're using Orbstack, then you are using a VM. Docker doesn't run directly on MacOS, so Orbstack actually creates a Linux VM to run Docker on that. orbctl reset will recreate that VM from scratch and could possibly help with your issue. Also make sure Orbstack is updated to the latest version.

If you're using Orbstack, then you are using a VM. Docker doesn't run directly on MacOS, so Orbstack actually creates a Linux VM to run Docker on that. orbctl reset will recreate that VM from scratch and could possibly help with your issue. Also make sure Orbstack is updated to the latest version.

oh yes. I know that. I will try next days. If still not working. I can only use shadowsocks. lol

Yep - working for me now too (albeit on an M4 system) thanks for the note @fskaeh! Closing this one for now given that there are two confirmed working systems and also this issue specific issue hasn't gotten specific traction with the developers. If you're still having trouble, I recommend opening a new issue with details surrounding your specific problem.


Vue Problem laravel 5.4 laramix "npm run dev" compile broken app.js

Hey i need help with vue compunets. I set a new Project with laravel and vue. I tested the example.vue  in Project works fine. After i added a new vue file and run "npm run dev" no componets are shown. I tried many ways but always after i compile with laravelmix the app.js is broken. Someone any ideas why?
using laradock with nginx and mysql
working on mac os and running the "npm run dev" command on local machine.
Compiler say all fine but when i start the website they not showing the componets.
Add other file for laravel mix
 DONE  Compiled successfully in 11815ms                                                                            10:12:08 PM
                                                                                Asset      Size  Chunks                    Chunk Names
  fonts/glyphicons-halflings-regular.eot?f4769f9bdb7466be65088239c12046d1   20.1 kB          [emitted]
  fonts/glyphicons-halflings-regular.svg?89889688147bd7575d6327160d64e760    109 kB          [emitted]
  fonts/glyphicons-halflings-regular.ttf?e18bbf611f2a2e43afc071aa2f4e1512   45.4 kB          [emitted]
 fonts/glyphicons-halflings-regular.woff?fa2772327f55d8198301fdb8bcfc8158   23.4 kB          [emitted]
fonts/glyphicons-halflings-regular.woff2?448c34a56d699c29117adc64c43affeb     18 kB          [emitted]
                                                               /js/app.js    291 kB       0  [emitted]  [big]  /js/app
                                                             /css/app.css    116 kB       0  [emitted]         /js/app
                                                        mix-manifest.json  66 bytes          [emitted]

app.js
Vue.component('example', require('./components/Example.vue'));

Vue.component('chat-message', require('./components/ChatMessage.vue'));

const app = new Vue({
    el: '#app'
});

webpack.mix.js
const { mix } = require('laravel-mix');

mix.js('resources/assets/js/app.js', 'public/js')
   .sass('resources/assets/sass/app.scss', 'public/css');

package.json
{
  "private": true,
  "scripts": {
    "dev": "node node_modules/cross-env/dist/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch": "node node_modules/cross-env/dist/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch-poll": "node node_modules/cross-env/dist/bin/cross-env.js NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --watch-poll --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "hot": "node node_modules/cross-env/dist/bin/cross-env.js NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
    "production": "node node_modules/cross-env/dist/bin/cross-env.js NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
  },
  "devDependencies": {
    "axios": "^0.15.3",
    "bootstrap-sass": "^3.3.7",
    "jquery": "^3.1.1",
    "laravel-mix": "^0.8.8",
    "lodash": "^4.17.4",
    "vue": "^2.1.10"
  }
}

webconsole
Uncaught TypeError: Cannot read property 'csrfToken' of undefined
    at Object.<anonymous> (app.js:12226)
    at __webpack_require__ (app.js:20)
    at Object.<anonymous> (app.js:11278)
    at __webpack_require__ (app.js:20)
    at Object.<anonymous> (app.js:41465)
    at __webpack_require__ (app.js:20)
    at app.js:66
    at app.js:69
(anonymous) @ app.js:12226
__webpack_require__ @ app.js:20
(anonymous) @ app.js:11278
__webpack_require__ @ app.js:20
(anonymous) @ app.js:41465
__webpack_require__ @ app.js:20
(anonymous) @ app.js:66
(anonymous) @ app.js:69
app.js:39383 You are running Vue in development mode.
Make sure to turn on production mode when deploying for production.
See more tips at https://vuejs.org/guide/deployment.html

i set up the laravelmix like the tutorial
https://laravel.com/docs/5.4/mix

It's looking for a csrfToken property on an object that, by default, is defined in your layouts/app file. So it  sounds like the view that you are rendering doesn't extend the layout file. In bootstrap.js, axios is initialized with the csrfToken. So either always extend your master layout or store your csrfToken in a way that is always accessible via javascript.

Hey thanks i didn t checked it and app.blade was missed. Bad misstake had a blind Point. Anyway thanks

@Chtheile FYI
Scaffolding
php artisan make:auth.
See here: https://github.com/laravel/framework/blob/5.4/src/Illuminate/Auth/Console/stubs/make/views/layouts/app.stub#L19
I was in the same issue, it's just that :)

Make sure you have the below in the <head> tag of the page you intend to use axios.
<script>
        window.Laravel = {!! json_encode([
            'csrfToken' => csrf_token(),
        ]) !!};
    </script>


⚠ Turnos 24x7 has degraded performance

In 352d8d3, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 977 ms

Resolved: Turnos 24x7 performance has improved in 2fd9b6e.


How to set php::repo::ubuntu version on local puppet, no hiera, no puppet master

I try to setup a simple example with local puppet and the following init.pp, no hiera, no puppet master
class { 'php':
  ensure       => latest,
  manage_repos => true,
  fpm          => true,
  dev          => true,
  composer     => true,
  pear         => true,
  phpunit      => false,
}

php::repo::ubuntu {'php56':
  version => '5.6',
}

This fails with
Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type php::repo::ubuntu
I pull mayflower/puppet-php via librarian with the following Puppetfile:
forge "https://forgeapi.puppetlabs.com"

mod 'puppetlabs/stdlib'
mod 'mayflower/php',
  :git => 'https://github.com/mayflower/puppet-php.git',
  :ref => '3.4.1'

I'm quite sure I made a stupid "Problem Exists Between Keyboard And Chair" mistake...
Can someone please help me out?

I don't know if you fixed this already but you're right in thinking it's a pretty simple fix.
You used:
php::repo::ubuntu {'php56':
  version => '5.6',
}

That means define a resource of type "php::repo::ubuntu" with $title "php56", but if you look in the source, php::repo::ubuntu is a "class" not a "define", which means you'll need to use something like the following (untested):
class { 'php::repo::ubuntu':
  version => '5.6'
}

However I strongly suggest you integrate Hiera if possible, it won't bite... much ;-)

@alexshepherd-hydrant thanks for clarifiying. Please also have a look what's happening for 4.0 of this module in #190.


whisper-fill.py is not python3 compatible in feature/py3 branch

https://github.com/zillow/whisper/blob/feature/py3/bin/whisper-fill.py#L75
such as,
itertools.izip, itertools.izip, xrange etc.
it can be an easy fix.

Yes, any parts of Graphite stack currently are not python3 compatible. But the whisper is also a library, so it makes sense, though. So, patches are welcome! Of course, we should maintain compatibility with python 2.x too.

This is implemented


fixed the issue of potential policy events loss

Currently, we use the unique constraint in the policy events table, like this:
    CONSTRAINT local_policies_unique_constraint UNIQUE (policy_id, cluster_id, count)

But there is a scenario: the policy may have more than one event when the policy_id, cluster_id, and count are the same, just like the following logs in the global hub manager:
2023-06-17 01:21:37 UTC INFO    policy-event-processor  regional-hub    {"namespace": "local-placement", "name": "policy-limitrange.17694d9b12ef02cb", "count": "1", "offset": "12"}
2023-06-17 01:21:47 UTC INFO    policy-event-processor  regional-hub    {"namespace": "managed-cluster", "name": "local-placement.policy-limitrange.17694d981e9b98f3", "count": "1", "offset
": "13"}
2023-06-17 01:21:57 UTC INFO    policy-event-processor  regional-hub    {"namespace": "managed-cluster", "name": "local-placement.policy-limitrange.17694d9923a397b2", "count": "1", "offset
": "14"}

This will cause the event with the name "local-placement.policy-limitrange.17694d9923a397b2" lost in the event.local_polices. Because it and the event "local-placement.policy-limitrange.17694d981e9b98f3" are all from the same root policy local-placement/policy-limitrange also in the same cluster namespace managed-cluster with event count = 1.
So we should set the eventName, count as the unique constraint, instead of setting the policy_id, cluster_id, count.

/cc @clyang82 @bjoydeep

/retest

/lgtm


Re-throwing error within Vue.config.errorHanlder results in error thrown twice

Version
2.5.22
Reproduction link
https://jsfiddle.net/h92m7pad/2/
Steps to reproduce

Run the app
Look at the console

What is expected?
The error is thrown once
What is actually happening?
It is thrown twice

This is expected: it's possible that your code in the globalHandler itself has errors, and that error is thus reported as a potential error in your error handling code.
If you already have an error handler, you should not be throwing the error.

Yes, errors in the global handler should be thrown, but only once and not twice. Or am I missing something?

If you already have an error handler, you should not be throwing the error.

If I don't throw the error then the error get's completely swallowed: https://jsfiddle.net/d6uqhk0r/
I'm wondering, why does Vue throw the error twice? Seems unnecessary form my point of view.
(Thanks for Vue, it's super impressive how much you achieved.)

This is now fixed - note that to avoid the error being logged twice, you need to throw the original error instead of throw new Error(err).

Awesome thanks


Bugfic Commit needs to be reflected to Master

Hi, i just found a bug which causes "showActualPercentages" not to work.
Debugged for the first time and .options was too much. this.showActualPercentages is enough or this.options.pieceLabel.showActualPercentages.
please reflect the small change in your master to fix it!
BR and sorry for that.
Erik

fixed and added to v0.9.0


Assign Missing Serf Parameters

Without this assignment the local broker is not added as a cluster member which causes metadata requests to fail using rdkafka (since there should be at least 1 broker)

Switched to cobra in another PR. I think I fixed this along the way.


feat(chromatic):Visual regression testing tool for buttons

Describe pull-request
Describe what the pull-request is about

Adding chromatic as a tool for visual regression testing. This branch is a pilot only enabling this for buttons.
Chromatic snapshot individual stories, so I've refactored button stories to represent all existing button variations (currently ~900).
Also trying to add Chromatic as a hook for pull requests.

Solving issue
In case of GitHub issue add # plus the number of the issue (for example #123) OR if it is Azure then AB# and number of ticket
Fixes: AB#1335
How to test
Add description how to test if possible
Not sure, but these steps hopefully open Chromatic

Open branch in your local environment
Run chromatic from sdds/components with CLI npm run chromatic

Try if you can access build via https://www.chromatic.com/manage?appId=620cc1abd4e7e7003aa19d3e&view=collaborate
Screenshots
If applicable, add screenshots to help explain
Additional context
Add any other context about the pull-request here.

My question here is can we use Chromatic to pass on different parameters or do you have to create stories that have all settings set before so one story has to be === test case?
Let's find a good way to handle this, otherwise, it would be messy to browse around Storybook with so many substories.

My question here is can we use Chromatic to pass on different parameters or do you have to create stories that have all settings set before so one story has to be === test case?
Let's find a good way to handle this, otherwise, it would be messy to browse around Storybook with so many substories.

Chromatic can only catch individual stories, not parameters. I agree that number of stories should be kept to a minimum, but enough to represent the range of variants that a button can have so we can verify it. The reason that Chromatic needs a story is that all combinations of parameters quickly reach a great number of test cases.
I've reduced the number of combinations to 12 representative stories. For example, stories for size values are always combined with icons, but this can be changed with individual parameter controls. Do you feel that any of these stories are unnecessary and should be removed?
One way we could do it, that I've seen carbon do with their storybook, is to combine multiple components in one story https://react.carbondesignsystem.com/?path=/story/components-button--expressive-buttons . Perhaps that could reduce number of stories, but still capture visuals with Chromatic. Although, I think I would need help setting that up. Maybe that works better for web components?

I am actually not really sure how I can review this

I now understand what the problem with paddings and left alignment was. However, it still seems to be that storybook component and reference design are not placed at the same place, so.. is this good enough for us?

I'm on a separate task to place component top left in the storybook, except for stories that for some reason needs to have a different layout. There will be some pixels difference, I guess, but after the change it will be good enough.

npm run chromatic works but it' skpping most of stuff, like a screenshot below. wonder it is how it is set up for now.

I could access build via the url

left few comment here and there, AWESOME initiative @areblk !

Chromatic seems to be running a "pre-test" to see if there are changes before it starts to make new snapshots. If there are no changes, there won't be any new snapshots.

It seems that all the changes on package-lock.json files under theme package are not relevant for this PR, right? if that's the case, let's remove them from the PR.

I think they're not relevant. How do I remove from commit/PR without actually removing the file?

Too many irrelevant and unrelated changes in files. New branch with new PR coming up.


Quantization issue - Mixtral 8x22b

Hi all. I'm currently working to the implementation of a quantized version of Mixtral 8x22b. I'm using the weights from the following repo: MaziyarPanahi/Mixtral-8x22B-Instruct-v0.1-GGUF.
Unfortunately, expert-related tensors for each layer are merged (instead of having one for each expert). In order to use the available Mixtral implementation and exploit experts routing I:

dequantize the qtensor;
chunk the tensor obtained along dimension 0 and squeeze;
quantize again to resume the conventional flow.

The problem arise during the quantization step. Considering quantize in QTensor implementation:

    pub fn quantize(src: &Tensor, dtype: GgmlDType) -> Result<Self> {
        let shape = src.shape();
        let block_size = dtype.block_size();
        check_shape(shape, block_size)?;
        let src = src.to_dtype(crate::DType::F32)?.flatten_all()?;
        let elem_count = shape.elem_count();
        if elem_count % block_size != 0 {
            crate::bail!(
                "tensor size ({shape:?}) is not divisible by block size {}",
                block_size
            )
        }
        let mut storage = src.device().qzeros(elem_count, dtype)?;
        storage.quantize(&src.storage())?;
        Ok(Self {
            storage,
            shape: shape.clone(),
        })
    }

and quantize in QStorage implementation:

fn quantize(&mut self, src: &Storage) -> Result<()> {
        match (self, src) {
            (QStorage::Cpu(storage), Storage::Cpu(src)) => {
                storage.from_float(src.as_slice::<f32>()?)?;
            }
            (QStorage::Metal(storage), Storage::Metal(src)) => storage.quantize(src)?,
            (QStorage::Cuda(storage), Storage::Cuda(src)) => storage.quantize(src)?,
            _ => crate::bail!("Invalid dequantize storage locations do not match"),
        }
        Ok(())
    }

I found that the length of src.as_slice::<f32> is 8 times elem_count, causing problems with subsequent checks.
Any suggestions as to why this happens? Does the chunk operation have any influence?

Interesting, thanks for reporting this. It's a bit sad that there are multiple different gguf conventions for mixtral, e.g. the files from thebloke seem to have one tensor per expert which should make things a lot easier to use.
If you really want to use these other files, the easier would likely be to slice the quantized tensor directly, this would require a couple changes on the candle side though, not sure if you've give this a try. The dequantize-chunk-quantize approach should work, the storage size is indeed 8 times elem_count as the chunks are just views over the original tensor. You can trigger an actual copy by calling copy on the tensor then the storage will be adjusted to the proper size but this has some cost for copying the elements over.

Yes, I used TheBloke weights for mixtral8x7b. Moreover the files from the MaziyarPanahi are split with llama.cpp util gguf-split. Therefore uploading via hf_hub is not viable (splitting of TheBloke weights is a simple division of bytes, whereas MaziyarPanah used gguf-split to split the weights into 2 gguf files with their own metadata).
Concerning the quantization issue a simple call to copy wasn't enough. I solved with force_contiguous.
I have been wanting to work on the QTensor and QStorage api for a while (e.g., complete the implementation of data for QStorage, provide an implementation of to_device and other classic operations such as narrow) since I make great use of them split in shards.
I hope to find the time to work on it and create a PR.


Create short best-practices document for developing on CyVerse

We should create a brief readme containing the links and info needed for using Git, loading kernels, shutdowning between development sprints, push changes, etc

e.g. git credentials
https://cu-esiil.github.io/hackathon2023_datacube/1_GIT_on_the_Cloud/github_cyverse/#set-up-your-github-credentials

Making sure to terminate when not running for a few days

Do we need to include a notebook like the one configure_github_ssh.ipynb that allows us to setup out credentials?  At least for the development efforts?


Fix typo in docs

I think there was a type in the keyframes API example 🤔
Because why would you have to change animation from a regular string to a string literal, when you are not using the ${} syntax? I might be wrong though...

[x] I have followed (at least) the PR section of the contributing guide.

It is referencing a keyframes name according to https://cssinjs.org/jss-syntax/?v=v10.0.0-alpha.16#keyframes-animation.
Maybe we should make this explicit by linking to the Jss API docs? /cc @oliviertassinari

Or we could just change:
`$mui-ripple-enter 100ms cubic-bezier(0.4, 0, 0.2, 1)`

to
"$mui-ripple-enter 100ms cubic-bezier(0.4, 0, 0.2, 1)"

Might prevent others from getting confused to 😅

Oh now I see where the confusion comes from. Agree 100%.

@eps1lon Fixed.

@janhesters It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@oliviertassinari One liner 😝 But you are welcome, great library!

@oliviertassinari One liner  But you are welcome, great library!

You have no idea how precious doc changes are to us. Especially things like this where I'm completely blindsided by the fact that this could be misinterpreted as a template literal. Please don't ever be discouraged by how big the changes are in your PRs. Commit size has very little correlation with the actual value it provides.

@eps1lon Thank you, that is in fact good to know 🙏


support for unpackver=20?

 Most of them fail to extract with rardecode with a unsupported decoder version. Adding some print statements shows that unpackver is 20.
Is there any particular reason that it is unsupported (other than lack of time, say)?
Is expanding the set of supported versions/formats something that is in the pipeline?
If there are no huge blockers, I may take a stab at adding support (although at this point i know nothing about the rar format(s) except the little i've gleaned from scanning through this codebase and the c++ unrar codebase)

I just had no files to test with. Current winrar, etc won't create the old versions.
I could have a go at it. I had a quick look, and since its the predecessor to 29 I could reuse/copy a bunch of stuff from it. It looks quite familiar. I might have to rework a few small things, as I couldn't see any explicit end of block marker in the format.
Having a test file would make it easier.

That would be great. I can upload the rar file that was failing somewhere and attach a link here if you want.

Sure, that would be good.

I've added some code in the experimental branch for unpackver 20. Its untested, but if you are very lucky maybe it will work.

No idea what version these files are, but this library will not extract them. Found them in some 10+ year old torrents. Hoping you can make it work! 🤞 I put both RAR files inside a zip file so GitHub would accept them.

b2b_gui01b.rar produces rardecode: unsupported decoder version
dc_selfboot_kit.rar produces rardecode: bad header crc

Archive.zip

This should be fixed now, sorry for the delay


contrib.ecs does not check container exit code

I would like to add opt-in support for checking exit code of containers launched with the class ECSTask. The idea would be to do something similar to the class ExternalProgramTask which raises a RuntimeError exception if the task return code is non zero. Is raising such exception the right thing to do in case of failure?

Makes sense to me. Feel free to submit a PR!

Closing, no longer needed, as I moved to contrib.kubernetes.


Update projects.yml

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/india/blob/main/CONTRIBUTING.md.

Which change are you proposing?

[x] Adding/updating open source project/s
[ ] Adding/updating maintainer/s

Adding/updating open source project/s

[x] The project was built in or receives significant contributions from India
[x] The project has at least 100 stargazers

Why should this open source project be featured?

Ashok is used for information gathering. Ashok is used to scan websites for information gathering and finding vulnerabilities in websites and webapps. Ashok is one of the easiest and useful tools for performing reconnaissance on websites and web apps

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks for your contribution @powerexploit 💙
Unfortunately, we would not be able to list your suggested project since it has been archived.


[torch.compile] support all attention backends

previously we register attention ops separately, e.g. flashinfer, flash attention.
this pr changes the registration to be the unified attention interface, so that we don't need to register these attention backends one by one.
how it works:

when we create an attention class, we register it in the per-model static forward context, identified by its layer name
when we call the attention implementation, we pass in the layer name through pytorch custom op, and inside the custom op, we find the attention object, and call the implementation.

TODO:
in the future, we should make all attention implementation accept an output argument, so that it is aligned with the v1 attention behavior.

error comes from huggingface timeout


Expose data-vscode-theme-id attribute in webviews, fix #149661

This PR fixes #149661
Adds a data attribute to webviews with the themeId. Extension could write theme specific CSS for webviews. Unlike themeName, themeId will not change if changing the display language. themeName is preserved to prevent breaking changes.
Before (the display language changed to zh-cn)

After

@mjbvz I agree it's better not let existing users adopt anything. However, after some diggings around the code, I realized that
theme label is defined in
https://github.com/microsoft/vscode/blob/042e505d3230c3b7dcd7bb0ecdfbff8452fd19fb/extensions/theme-red/package.json#L15
and could be overwritten by i18n extension in
https://github.com/microsoft/vscode-loc/blob/fb987ff21ae002c918fc0e7039642ae345f279b6/i18n/vscode-language-pack-zh-hans/translations/extensions/theme-red.i18n.json#L14
themeLabel is localized when ExtensionsRegistry loading theme extensions, and ThemeService is not aware of that.
Keeping a copy of English themeLabel is overkill. Therefore, adding a data-vscode-theme-id should be the way to address the issue with minimal efforts.

Introducing this new attribute both leaves the current broken behavior  and introduces a new thing for users/extension authors to adopt. Not a fan
@aeschli Any ideas on reading the default English value of a theme name?

Some themes using data-vscode-theme-name from https://github.com/search?q=data-vscode-theme-name&type=code.
Most of them are used to for theme specific colors or styles. I don't know if there are better way to get exact usage stats.

Searching the top 6000 extensions on the Marketplace so far only rangav.vscode-thunder-client uses data-vscode-theme-name

After searching 37'800 extensions, I found data-vscode-theme-name at the following spaces
blueplanet-ciena.ciena-blueplanet/resource-type-graph/main.91fb18098d9d6cca2a82.js
cweijan.vscode-database-client2/out/webview/js/app.js
cweijan.vscode-database-client2/out/webview/js/query.js
cweijan.vscode-dm-client/out/webview/js/app.js
cweijan.vscode-es-client2/out/webview/js/app.js
cweijan.vscode-es-client2/out/webview/js/query.js
cweijan.vscode-mysql-client2/out/webview/js/app.js
cweijan.vscode-mysql-client2/out/webview/js/query.js
cweijan.vscode-postgresql-client2/out/webview/js/app.js
cweijan.vscode-postgresql-client2/out/webview/js/query.js
cweijan.vscode-redis-client/out/webview/js/app.js
cweijan.vscode-redis-client/out/webview/js/query.js
cweijan.vscode-ssh/out/webview/js/app.js
cweijan.vscode-ssh/out/webview/js/query.js
eliostruyf.vscode-theming-devtools/dist/webview.js
LigaAI.liga/out/web-dist/assets/i18n.js
Lightrun.lightrunplugin-saas/webpack/build/configViewer.js
Lightrun.lightrunplugin-saas/webpack/build/logs.js
rangav.vscode-thunder-client/dist/extension.js
rebornix.vscode-code-renderer/out/client/index.js
YuTengjing.scripting-listener/dist/web/webview.js
My suggestion would be to deprecate data-vscode-theme-name (remove it from documentation, but leave it as is for the next half year), add data-vscode-theme-id and data-vscode-theme-label and inform the extensions above.

Thank you for your research!
I will change the PR to deprecate data-vscode-theme-name and add data-vscode-theme-id and data-vscode-theme-label.
I could submit another PR to https://github.com/microsoft/vscode-docs about these changes if you want.
And I am just curious. How did you search for source code of extensions on the Marketplace?

@pingren An update to the docs would be fantastic.
We have an internal tool that downloads a set of extensions from the marketplace so we can search them

@aeschli PR Updated. Please take a look when you have a moment.

I'd rather not introduce the id to platform/common/IColorTheme.
Instead you can do the following:
In the WebviewThemeDataProvider use IWorkbenchThemeService instead of IThemeService
Then the theme you get with this._themeService.getColorTheme() is of type IWorkbenchColorTheme and you can access the property id

Updated: use IWorkbenchThemeService instead of IThemeService

Thanks @pingren. Can you also remove the change in src/vs/workbench/contrib/terminal/test/common/terminalColorRegistry.test.ts?

Thank you! Sorry for that.
Updated: Remove change in src/vs/workbench/contrib/terminal/test/common/terminalColorRegistry.test.ts


Add a FindPeerAsync function

There's a FindProvidersAsync, there will soon be a GetValuesAsync, but there is no GetPeerAsync. With a GetPeerAsync, we could try peer addresses as we find them instead of waiting for the search to complete. Benefits over the current system:

Can abort searches early (save bandwidth)
Can keep searching until we find an address for the peer that works (reliability).

Yes, it would be quite useful as (IIRC) it would remove one layer of workers from Bitswap.

My usecase is implementing a parallel multirouter (i.e., a router that queries multiple sub-routers in parallel).


Fix two typos in comments

Just some typos that were found by the lintian tool.

How embarrassing :).  Thanks.

How embarrassing :).  Thanks.


Adjust CMake instructions of CUDA-related code for the recent CMake versions

CUDA version of LightGBM can be built on Linux via the following instructions
git clone --recursive https://github.com/microsoft/LightGBM ; cd LightGBM
mkdir build ; cd build
cmake -DUSE_CUDA=1 ..
make -j4

Right now this results in a lot of CMake policy warnings about that empty CUDA_ARCHITECTURES not allowed:
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- The CUDA compiler identification is NVIDIA 11.0.221
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting CUDA compiler ABI info
-- Detecting CUDA compiler ABI info - done
-- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc - skipped
-- Detecting CUDA compile features
-- Detecting CUDA compile features - done
-- Found OpenMP_C: -fopenmp (found version "4.5")
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found CUDA: /usr/local/cuda (found version "11.0")
-- CMAKE_CUDA_FLAGS: -Xcompiler=-fopenmp -Xcompiler=-fPIC -Xcompiler=-Wall -gencode arch=compute_60,code=sm_60 -gencode arch=compute_61,code=sm_61 -gencode arch=compute_62,code=sm_62 -gencode arch=compute_70,code=sm_70 -gencode arch=compute_75,code=sm_75 -gencode arch=compute_75,code=compute_75 -O3 -lineinfo
-- ALLFEATS_DEFINES: -DPOWER_FEATURE_WORKGROUPS=12;-DUSE_CONSTANT_BUF=0;-DENABLE_ALL_FEATURES
-- FULLDATA_DEFINES: -DPOWER_FEATURE_WORKGROUPS=12;-DUSE_CONSTANT_BUF=0;-DENABLE_ALL_FEATURES;-DIGNORE_INDICES
-- Performing Test MM_PREFETCH
-- Performing Test MM_PREFETCH - Success
-- Using _mm_prefetch
-- Performing Test MM_MALLOC
-- Performing Test MM_MALLOC - Success
-- Using _mm_malloc
-- Configuring done

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "histo_16_64_256_sp".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "lightgbm".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "lightgbm".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "histo_16_64_256-allfeats_sp".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "histo_16_64_256-allfeats_sp_const".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "histo_16_64_256-fulldata_sp_const".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "histo_16_64_256_sp_const".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "histo_16_64_256-fulldata_sp".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "_lightgbm".
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
  empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
  for policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  CUDA_ARCHITECTURES is empty for target "_lightgbm".
This warning is for project developers.  Use -Wno-dev to suppress it.

This can be helpful: https://github.com/dmlc/xgboost/blob/master/cmake/Utils.cmake.

Fixed via #4268.


502 bad gateway

Hello,
With some rss feeds I have sometimes a 502 bad gateway error with this message :
[FATAL] [Route] mux: variable "" doesn't match, expected "^[^/]+$"
Thank you

Which page/url is it? can you provide the information to reproduce the issue?

This problem should be fixed in Miniflux >= 2.0.20.