Reopen #1919: Bottom part of ionic tabs is not clickable

I'm submitting a ...  (check one with "x")

[ ] question
[X] any problem or bug report
[ ] feature request

If you choose 'problem or bug report', please select OS:  (check one with "x")

[ ] Android
[X] iOS

cordova information:  (run $> cordova plugin list)
com.googlemaps.ios 2.6.0 "Google Maps SDK for iOS"
cordova-plugin-camera 4.0.3 "Camera"
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-file 6.0.1 "File"
cordova-plugin-file-transfer 1.7.1 "File Transfer"
cordova-plugin-geolocation 4.0.1 "Geolocation"
cordova-plugin-googlemaps 2.3.4 "cordova-plugin-googlemaps"
cordova-plugin-inappbrowser 2.0.2 "InAppBrowser"
cordova-plugin-ionic-keyboard 2.1.2 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.2.1 "cordova-plugin-ionic-webview"
cordova-plugin-network-information 2.0.1 "Network Information"
cordova-plugin-screen-orientation 3.0.1 "Screen Orientation"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-statusbar 2.4.1 "StatusBar"
cordova-plugin-whitelist 1.3.3 "Whitelist"
es6-promise-plugin 4.2.2 "Promise"
info.protonet.imageresizer 0.1.1 "Image Resizer"
If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)

ionic-native/core: 4.7.0
ionic-native/google-maps: 4.7.0

Current behavior:
Same issue as this one described by antoine92190 https://github.com/mapsplugin/cordova-plugin-googlemaps/issues/1919
Screen capture or video record: ( Merci @antoine92190 )

Related code, data or error log (please format your code or data):
The workaround I use for the moment is to set android mode;
<ion-tabs #myTabs icon-bottom title-hide mode="md">
Strangely, It works perfectly on iPhone X with 'viewport-fit=cover', but not on others iPhone/iPad...

please share your project files on GitHub.

Exactly the same one, juste emulate it with an other device that iPhone X... :)

In order to reproduce your issue perfectly, I asked. Otherwise please debug by yourself. I'm super busy.

I understand... I will do my best to share a simple piece of code to reproduce it on gitHub...
debug by myself ... i'm afraid to not be able to ...
Thanks :)

@gorriens Are you still seeing this issue we are seeing it iOS..

@wf9a5m75 This ticket (https://github.com/mapsplugin/cordova-plugin-googlemaps/commit/d41f4362df341161a5119a46b6d979e9c2aa2e3b) has a resolution but the correct  commit as not been rolled in 3.2.5 - is this a mistake, or am i missing something?

If you have a problem, please create a new issue thread, and share your project files on GitHub.

@wf9a5m75 I don't have a problem, I'm just trying to get more information if this was fixed not. Based on the current version of 2.3.5 - it is not, so I will open up a issue as you suggested. Thanks!


MACVLAN support?

Some of today's Docker scenarios require granting specific containers direct data-link layer ("MAC") access, as opposed to nat'ed IP access. Examples are not only (infamous?) license server containers, but also non-IP protocol-based applications, such as in some industrial environments. Docker comes with its CNM "macvlan" driver and the CNI "driver" base also supports MACVLAN.
At the moment (as of commit 2895d605d94334620e09fd7edad67711c75a5908) does not understand the -d option when creating a new network: for Docker, -d specifies the type of CNM driver to create a new network with. nerdctl compose also catches these case that try to specify a non-bridge network driver and blocks such projects from deployment.
Please support MACVLAN networks next to bridge networks in nerdctl for improved Docker-compatibility.

Implemented in https://github.com/containerd/nerdctl/pull/836

Thank you very much! I'll see to put it through the paces of some unit tests on our side. Once again, thank you very much!


Typecheck all test folders in Django test suite

I've set up typechecking of Django test suite via
https://github.com/mkurnikov/django-stubs/blob/master/scripts/typecheck_tests.py
for some of the folders.
Now we need to enable it for all test folders.
To add stubs for test folder:

Choose one from here
https://github.com/django/django/tree/master/tests

Add it to the TESTS_DIRS constant
https://github.com/mkurnikov/django-stubs/blob/master/scripts/typecheck_tests.py#L30

Run typecheck_tests.py.

Fix all occurred errors, possibly ignoring ones for the test code itself using IGNORED_ERROR_PATTERNS constant.

Most of test folders are enabled, remaining require non-trivial work.


Remove TabPresenter and AnyTabPresenter/Router

This cleans up unused component and redundant Router protocol as well us unused AnyTabPresenter protocol

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   95.05%   95.05%
=======================================
  Files           5        5
  Lines         384      384
=======================================
  Hits          365      365
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e9bfa...d318807. Read the comment docs.


Silence warning.

Previously, a warning was emitted when compiling in non-release builds.
This change fixes the warning.

hehe; no worries! (@dabrahams fixed up one of my warnings a while back, so I can now pay it forward.)


parse_label_id

I have an object detection dataset that only contains bbox and class annotations. how to get parse_label_id

Hi, you can only finetuning the image tagging branch of RAM/RAM++, only with image class annotations.

Thank you for your reply

finetuning the image tagging branch of RAM++ is similar to multi-label classification training? how to make the  parse_label_id with  object detection dataset.

yes.
image tagging branch only need image tags annotations.

I know that. but I want to pretrain, how to make the label


Add RoverSpeed from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of maculator, to add RoverSpeed to CKAN.
Please direct questions about this pull request to maculator.

Crated a .ckan from it, checked it. Everything working.

@maculator In #1649 there's a dependency on ModuleManager. You should re-open that PR in lieu of this.

okay, thanks. Done.

So i can't delete this one because its botmade, but the https://github.com/KSP-CKAN/NetKAN/pull/1649 is the one wich is correct, but doesn't get accepted due to this one .....


Create a CMS-style blog site following criteria listed in acceptance criteria.

USER STORY
AS A developer who writes about tech
I WANT a CMS-style blog site
SO THAT I can publish articles, blog posts, and my thoughts and opinions
ACCEPTANCE CRITERIA
GIVEN a CMS-style blog site
WHEN I visit the site for the first time
THEN I am presented with the homepage, which includes existing blog posts if any have been posted; navigation links for the homepage and the dashboard; and the option to log in
WHEN I click on the homepage option
THEN I am taken to the homepage
WHEN I click on any other links in the navigation
THEN I am prompted to either sign up or sign in
WHEN I choose to sign up
THEN I am prompted to create a username and password
WHEN I click on the sign-up button
THEN my user credentials are saved and I am logged into the site
WHEN I revisit the site at a later time and choose to sign in
THEN I am prompted to enter my username and password
WHEN I am signed in to the site
THEN I see navigation links for the homepage, the dashboard, and the option to log out
WHEN I click on the homepage option in the navigation
THEN I am taken to the homepage and presented with existing blog posts that include the post title and the date created
WHEN I click on an existing blog post
THEN I am presented with the post title, contents, post creator’s username, and date created for that post and have the option to leave a comment
WHEN I enter a comment and click on the submit button while signed in
THEN the comment is saved and the post is updated to display the comment, the comment creator’s username, and the date created
WHEN I click on the dashboard option in the navigation
THEN I am taken to the dashboard and presented with any blog posts I have already created and the option to add a new blog post
WHEN I click on the button to add a new blog post
THEN I am prompted to enter both a title and contents for my blog post
WHEN I click on the button to create a new blog post
THEN the title and contents of my post are saved and I am taken back to an updated dashboard with my new blog post
WHEN I click on one of my existing posts in the dashboard
THEN I am able to delete or update my post and taken back to an updated dashboard
WHEN I click on the logout option in the navigation
THEN I am signed out of the site
WHEN I am idle on the site for more than a set time
THEN I am able to view posts and comments but I am prompted to log in again before I can add, update, or delete posts

App created


BUG: the medium screen view is not responsive

Description
There is an issue with responsiveness on the medium screen
i could fix this also if am assigned to it
Screenshots

:thinking: I'd love to see how you go about this. Assigning you!

Hello @dev-phantom How far with this issue?

Am so sorry about this
My PC is currently in bad shape
But I'll get it done before 5th of February
Sorry for the delay

No issues! Take your time, fren 💜

No issues! Take your time, fren 💜

Thanks for understanding 🙏


[Bug]: url of TOC in sidebar missed page information

What happened?

For the TOC/outline headings, the url is  www.site.com/#heading-1, but should be www.site.com/This-Page/#heading-1
What OS are you using?
Windows
What remote cloud services are you using?
others
Version of the plugin
0.7.31
Version of Obsidian
1.6.7
Using password or not

[ ] Yes.

Ensure no sensitive information

[X] I ensure that no sensitive information is submitted in the issue.

Sometimes, the link works correct, jumped to page#heading.
But most of the time, it jump to index page.


WIP Show vioscreen pdf to user

Notes:
We worry about pushing retrieval from vioscreen out to celery, but then when talking from interface to private api, we do everything synchronously.  (But then, our async requests are waited on, and thus become synchronous... ugh)
Unclear if we want embedding or just pdf downloads
Should be worked into the site map
Possible issue with survey identifiers referring to both primary surveys and vioscreen data.

@dhakim87 just one comment, and it looks like there are two items on 404s?


Nvy does not show a full neovim notification message when it starts up

If Neovim wants to notify a user about something at startup, Nvy shows only the last line of the message. I tried running without plugins Nvy.exe txt5.txt -u NONE -U NONE -N -i NONE but in this case Neovim opens a file without showing any notifications.
Steps to reproduce:

Open a file in one Nvy instance
Open the same file in another Nvy instance
Neovim tries to display a warning about found swp file but Nvy shows only the last sentence Press ENTER or type command to continue that is confusing. I figured out that the real message is longer only after trying to open the file in another Neovim GUI app.

The second instance of Nvy shows me this:

I tried other GUIs (Nvim-Qt that is bundled with Neovim package and Neovide), they show the full message (the screenshot is from Nvim-Qt):

At first, I noticed flickering in Nvy as if it displayed the full text but then cleared all lines except the last one. But it might be that it was just my imagination.
Edit: please note that on the screenshot of Nvy a black bar above text(I guess it is statusline) is also missing.

I can't seem to reproduce this, either its a Linux specific issue or one of the latest changes, perhaps #121 may have fixed it?

It can't be Linux specific - I run Nvy on Window 10. The latest 0.4.0 does not fix the issue. But I was able to gather a little more information. I have Nvy 0.3.8 binary - it works as expected: it shows all warnings and the statusline. So, it seems something has changed in 0.3.9.

Oh I don't know what I was thinking when I wrote that comment, of course Nvy only works on Windows. I am not really sure what caused the regression in 0.3.9. I will try to find time to investigate it soon.


WIP: v1API: Introduce image format for docker image.

Try to give some momentum to https://github.com/GoogleCloudPlatform/kubernetes/issues/8702
Need to add tests for validation, defaults, conversion, and update a bunch of codes...
/cc @bgrant0607 @smarterclayton @philips @vmarmol @dchen1107 @jonboulle @bakins

Thank you very much for the pull request - we sincerely appreciate the work that goes into sending us a change.
We are currently in a feature-freeze and general code slush as we work toward our 1.0 release.  Our initial triage indicates that this is a non-critical change at this time, so we'd like to leave it open and revisit it after 1.0.  We expect the freeze to wrap up in early to mid July.
If you feel that this triage is incorrect, please respond and let us know why.  We're currently accepting changes that meet any of the following criteria:

Changes directly related to v1.0 issues
Changes addressing P0 bugs
Changes to supported platforms to bring them up to par with the primary development platforms
Docs, user experience, and test related fixes

I'm sorry. This didn't make the cut. Please see the discussion on #8702.

@yifan-gu - are you going to proceed with this PR or can we close it?

This requires more thought before we do it. Let's discuss in #8702.


Feature/issue 481 append array vectors of vectors

Submission Checklist

[only the append_array_test ones] Run unit tests: ./runTests.py test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary:
This replaces this pull req: https://github.com/stan-dev/math/pull/575 (sorry bout that -- lost my commit permissions to Stan repos last week -- Sean n' Daniel said to just make a pull req. from my own fork).
Two questions @bob-carpenter:

I expanded the new tests to test all the different ways to call append_array (up to two std::vectors deep). To avoid duplication of the test code, I put all the tests in /mix/ instead of splitting them up into individual sections. That okay?

These new tests only test that values are being passed around correctly (either the actual value of a double, .val() of var, .val().val() of fvar, etc.). I'm not testing the autodiff. I'm not testing values of derivatives in fvars. That said, I think that's about all the append_array function should really do. I can delete all the old append_array tests that test the gradients and such and I don't think we're really losing anything (here are your previous thoughts on this: https://github.com/stan-dev/math/pull/531#issuecomment-298264800)

Response to req. changes:

I left the return-by-reference builders in place in the tests. I found it easier to work with templates like this.

How to Verify:
./runTests.py test/unit/math/prim/mat/fun/append_array_test.cpp
./runTests.py test/unit/math/fwd/mat/fun/append_array_test.cpp
./runTests.py test/unit/math/rev/mat/fun/append_array_test.cpp
./runTests.py test/unit/math/mix/mat/fun/append_array_test.cpp
Documentation:
In the Doxygen
Reviewer Suggestions:
@bob-carpenter
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): University of California, Santa Barbara
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Howdy Mitzi!
I made a commit to address the comments from you and Bob.
I also removed a large number of the append_array tests. There are so many different types and combinations of types that needed testing here is was kinda difficult. I made a generic test function in test/unit/math/mix/mat/fun/append_array_test.hpp that should:

Randomly generate two std::vectors (and std::vector<std::vector<>>s) of things
Call append_array on them
Check to make sure things ended up in the right spot

I removed all the autodiff checks that were in append_array. There were really an obscene number of checks for something that boils down to a copy operator. Is this okay? Also, is implementing it like this okay? I made the header in mix cause it has fvar<var> stuff in it, but I include it from prim. Also I left some usings and typedefs in the header that normally wouldn't be okay in a header file (but I think should be okay for test codes)?
Here's my responses to the last review (If I didn't respond to it, I agreed with it and made the changes):

Mitzi's comments
stan/math/prim/mat/fun/append_array.hpp, line 30
comment needs context - explain when append_array reduced to copy x into y.

Yeah, it's what Bob said here. append_array_copy is just a helper function for append_array (defined at the bottom of the file).
I could change its name, but I'm hesitant to rename it something like cast_and_copy and move it out of the file because I'm not sure how it generalizes or whatever. If it becomes an official Stan Math function, then other things might depend on it and so it'd need to have consistent behavior and so forth. I'm hesitant to do that because this is just a helper function for append_array and I'd like it to stay that way.

Bob's comments
stan/math/prim/mat/fun/append_array.hpp, line 56
What are the invariants here? Is it possible to call this without x and y being the same size given your checks above? Those just checked first elements, so are you anticipating ragged uses here or something (in which case those first element checks are wrong).

These are different x s and y s here. At the append_array level, this is copying elements of x and y to elements of z.

stan/math/prim/mat/fun/append_array.hpp, line 122
The !y.empty() check is redundant given the consistency check.
It'd be better to make sure append_array_check_size worked for empty containers. This does not save time to put in redundant checks like this. Branching is expensive.

I made this change, but I don't super duper agree with it. check_size is lower complexity than the copies and doing this verbosely makes it clearer what's happening. I'll keep it in mind though.

stan/math/prim/mat/fun/append_array.hpp, line 129
same comment as above.

This doesn't apply here. x and y are the arrays to be appended together. They can have different number of elements and we only need to compare the sizes if they are not length zero.
Thanks!

By the way, the code changes for the response were pretty minor, but the test changes were pretty big. It's really easy to add another commit that rolls back the test changes if they aren't appropriate.

I could change its name, but I'm hesitant to rename it something like cast_and_copy and move it out of the file because I'm not sure how it generalizes or whatever. If it becomes an official Stan Math function, then other things might depend on it and so it'd need to have consistent behavior and so forth. I'm hesitant to do that because this is just a helper function for append_array and I'd like it to stay that way.

We used to do this all the time ("just a helper function"),  which is what led to so many duplicated functions strewn throughout the code.  We made a conscious decision to put a stop to this and require either new global metaprograms or use of the existing ones. Chances are anything you need to do to append arrays will be something that's needed elsehwere as a metaprogram.
Smaller, more modular code is much much easier to maintain (doc, test, upgrade to new types, bug fix) and typically easier to understand as there are fewer functions to learn.
Yes, it's more work to pull out a function, but in the end, we decided it's worth it.  The thing is, I think there may already be a cast-and-copy like function floating around you'll find.
To sum up, check out
stan/math/prim/mat/fun/assign.hpp
You may find it does everyting you need.  We need it for upcasting int to double and these primitives to autodiff types to get around the fact that neither standard library types or Eigen vectors are covariant:
https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)

Bob's comments
stan/math/prim/mat/fun/append_array.hpp, line 56
What are the invariants here? Is it possible to call this without x and y being the same size given your checks above? Those just checked first elements, so are you anticipating ragged uses here or something (in which case those first element checks are wrong).
These are different x s and y s here. At the append_array level, this is copying elements of x and y to elements of z.
stan/math/prim/mat/fun/append_array.hpp, line 122
The !y.empty() check is redundant given the consistency check.

This is minor, of course.

It'd be better to make sure append_array_check_size worked for empty containers. This does not save time to put in redundant checks like this. Branching is expensive.
I made this change, but I don't super duper agree with it. check_size is lower complexity than the copies and doing this verbosely makes it clearer what's happening.

I disagree.  I think making the boundary conditions general makes things easier to understand.  I'm not so worried about understandability of the code---that's trivial either way in a simple case like this---more about the external interface simplicity.

I'll keep it in mind though.

You may be surprised about the high potential cost of branches.  Simple branches like this we thought would save time in the end wound up killing the compilers ability to inline and ensure code locality.  Down at the memory management level in autodiff, you can really see the cost;  even at the level of implementing the var/vari structures you can see it.  Redundant checks at one point were literally halving the speed of autodiff.
Bottom line is that when you have to make an unpredicted branch, it's super duper expensive.  Even when you don't, it can seriously derail compiler optimizations.
If you're interested in diving deep, I'd suggest Agner Fogg's C++ optimization guides.

stan/math/prim/mat/fun/assign.hpp

Niiice, yeah, this looks great. And more complete than what I wrote. I'll try to switch to this.

We used to do this all the time ("just a helper function")

Just trying to be lazy :D.
How does this translate to the tests? Cause some of the code I wrote for the tests seems like it should be generalized. How to organize test headers? If they go under /mix/ then it seems weird importing them in /prim/.

I think making the boundary conditions general makes things easier to understand.

Whoops, yeah, I agree with this. Didn't say it quite right. I was disagreeing with the specific change.

Simple branches like this we thought would save time in the end wound up killing the compilers ability to inline and ensure code locality.

That's pretty interesting. I was just assuming the compiler could turn !y.empty() into a couple logicals and then there'd only be one branch anyway, but that would depend on the compiler having to make sense of the C++, which I guess is a pretty brittle assumption. And it's still a couple unnecessary logicals anyway haha.
I'm definitely guilty of architecture worship. Undergrad was EE. Way back when I did a bunch of microcontroller stuff. At one point I had an FFT written in assembly with some 16 bit fixed point math that I was pretty proud of (as you can imagine that was some high precision stuff). I'm very thankful that now that I write stuff for x86 I'm not always looking up instruction documentation to make sure they're fast/doing what I want haha. The fact that there's a branch predictor to begin with always seems like some sort of miracle.

The dependencies in the code should only go one way

mix -> {fwd, rev } -> prim

mat -> arr -> scal

Right---that !y.empty() won't create another branch.  It's just a redundancy (that may also add clarity).  I just meant that branching to detect boundary conditions is often worse than just executing a loop.  Even if that loop requires an object to be constructed on the stack.  Once you need objects like std::vector or Eigen::Matrix that allocate memory on the heap, construction gets a lot more expensive.
It's OK to write tests up at the mix/mat level that test everything below it. But don't go the other way and import mix from the prim tests.

It's OK to write tests up at the mix/mat level that test everything below it. But don't go the other way and import mix from the prim tests.

Cool beans, I've got some more fixing up to do then. Ignore this pull for now.

If the tests pass, this is ready to check again. I changed things to use the internal resize/dims as much as possible (and get rid of the helper functions I wrote). I had to make another commit to fix some minor merge conflicts between the main math develop and my own branch.
I just did: git merge --no-ff stan/develop (where stan is my remote for the Stan repos) and fixed the conflicts.
Hopefully that's the correct thing!

Check the signs on comparisons and use g++ if you don't see enough warnings with clang++.

Is this ready to be reviewed again @bbbales2?  If things get reviewed and require changes, it helps to let the reviewer know that it's ready to review again.  Otherwise, it's hard to tell.

Yup, my bad. It's ready for reviewin'!


⚠ Bofrost.lu has degraded performance

In 92489b9, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2465 ms

Resolved: Bofrost.lu performance has improved in e418be2 after 8 minutes.


Add support for "published" property of the post

According to the Jekyll's documentation there is a predefined variable "published". When I set published: false in the front matter block, my post is still shown on the index.html and feed.xml pages. It seems to me that unpublished posts should be hidden.
Could you please add support of this property?

Definitely seems reasonable to add, I will look into supporting that this weekend.

Thanks @johnotander, much appreciated.

FWIW, I'm pretty sure published: false was deprecated with Jekyll 3.0 (can't find anything hard on it), as both Octopress and Jekyll are now using _drafts folderi to mark something as unpublished.

Thanks @plttn, it looks like you're indeed correct. The new Jekyll flow is using a _drafts directory as show in the documentation: https://jekyllrb.com/docs/drafts/
Closing since this is handled by Jekyll. 👯 ✨ ✨


reload does not work

angular-cli: 1.0.0-beta.20-4
node: 6.9.1
os: linux x64 (ubuntu 16.04)
Hello,
I create angular2 project with angular cli and when i changed a file (css, html or ts files) and go to the browser and refresh the pages to see change but live reload does not work.
i restart with ng serve to see changes

The same for me. I simply installed angular-cli, generated a new project, ran ng serve, changed some html, and live reload did not work. The debugging console does not show any errors, says "Angular 2 is running in development mode..."
angular-cli 1.0.0.-beta21
node: 7.2.0. (but before tried with node 6.9 - same result)
os: windows 10 x64
It seems like the system does not recognize any file-changes.

Just saw that there is another issue about that, so mentioning it here for others
https://github.com/angular/angular-cli/issues/1610

And another update (for others facing the same problem): the following solved the problem for me: reinstalling angular-cli with @latest:

npm uninstall -g angular-cli
npm cache clean
npm install -g angular-cli@latest

Dupe of #1610, yes.

Increasing the amount of inotify watchers
The technical details
Listen uses inotify by default on Linux to monitor directories for changes. It's not uncommon to encounter a system limit on the number of files you can monitor. For example, Ubuntu Lucid's (64bit) inotify limit is set to 8192.
You can get your current inotify file watch limit by executing:
$ cat /proc/sys/fs/inotify/max_user_watches

When this limit is not enough to monitor all files inside a directory, the limit must be increased for Listen to work properly.
You can set a new limit temporary with:
$ sudo sysctl fs.inotify.max_user_watches=524288
$ sudo sysctl -p

If you like to make your limit permanent, use:
$ echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf
$ sudo sysctl -p

You may also need to pay attention to the values of max_queued_events and max_user_instances if Listen keeps on complaining.
more info here


Telegram bot payment, sendInvoice method, Pay button don't answer .

Hi everyone. I have one issue.
I am using telegram TEST payment .
why don't answer the pre_checkout_query during press pay button ?

after press Pay button no request come my domen...
so don't add any card this payment .
when click Payment Method , get error this like :

Problem with Telegram Desktop.


Fix usages of istioctl create-remote-secret

By default, istioctl creates the ServiceAccount if it doesn't yet exist. If you run the create-remote-secret command before you create the Istio resource, the ServiceAccount won't yet exist and will therefore be created, along with a ClusterRole and ClusterRoleBinding. This will later cause the reconciliation of the Istio resource to fail because Helm will refuse to overwrite these resources.

@luksa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_sail-operator_main
33dce8793cfe972222395a6f49ba24bdeee69f11
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@luksa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_sail-operator_main
33dce8793cfe972222395a6f49ba24bdeee69f11
link
true
/test lint

e2e-kind-multicluster_sail-operator_main
33dce8793cfe972222395a6f49ba24bdeee69f11
link
true
/test e2e-kind-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@luksa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_sail-operator_main
33dce8793cfe972222395a6f49ba24bdeee69f11
link
true
/test lint

e2e-kind-multicluster_sail-operator_main
aaa2e9b7f95c05b435055cd483b1d4812cfbfef1
link
true
/test e2e-kind-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Looks like this is no longer necessary.


Make layouts responsive

The layouts are not set up to be responsive because of the extra testing required for it.
But we should planning on doing this work now that most of the core changes are getting tackled.
So let's track it here.

working on this.


Jg sexcheck

I ended up removing the test with the VCF from 1000 genomes

I couldn't figure out a good way to get the number of variants used in the computation. It's either in the annotations as "sa.imputegender.T" or we'd have to do RDD.count()

I'm open to naming suggestions if you think something else is better. I didn't want to use "sex check" because that implies comparing to the reported gender and reporting errors -- not what I have implemented here.

@jigold What's the status of this?  It looks like the serializer zero array value stuff from VSM is still in there.

Shall I make a PR against this with the implementation I envisioned?

@tpoterba : That's fine with me if you want to try your approach.

I still need to change g.gt to g.nNonRefAlleles, I'll push that to this branch (it's a small change).  Is that the right thing to do?  Not really, because you could have a het non ref.  This is actually non-trivial.

Should we make this so it requires splitMulti to have been run? Otherwise, is the MAF we're currently calculating the correct one for the inbreeding coefficient computation?

jenkins

jenkins

@cseed : Back to you


add review comment to sb files

Contributes to https://github.com/dotnet/source-build/issues/3435
Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see https://github.com/dotnet/source-build/issues/3435#issuecomment-1570650046)

Yes, please use the CODEOWNERS file for this purpose.

Yes, please use the CODEOWNERS file for this purpose.

Initially wanted to add both the comment and the CODEOWNERS entry, but for a team to be added as a code owner it needs to have write permissions to the repo and I wanted to verify first if this is something we would need. I should've mentioned that in the description though, my bad, forgot to edit it.
If you are OK with granting write permissions to dotnet/source-build-internal, I will add the CODEOWNERS entry.

I'll ask in our teams channel for thoughts.

@333fred soft ping - are there any updates regarding the write access? Thank you!

Should be added now

@oleksandr-didyk you should have write access now.

Thank you! I added the CODEOWNERS entry


Please pin this hash

Hey there! This is an automated message asking if you could deploy QmbLH7isZmjgKSxG9FtXqD9kxHZ2K2BF49KazcjvCuErzr to orbit.chat. Thanks!
Let us know if there's any more information you need to deploy it. Thank you! :)
<3

This was a test, please ignore.


feat(ir): add support for selectors

Partly addressing #125.
Adds support for selectors to IR.
Note: This doesn't implement selectors with evaluators yet. That will be done in a subsequent PR.

@tohrnii this looks good to me overall, but changes to #269 will affect this, so I've put it into draft mode for now. Let's finish that one and then revisit this.


Kafka WithDataVolume and WithDataBindMount don't persist messages

Changes Kafka data directory (unit test mentioned in #4909 still fails but with an other exception - seems as the new data directory is working)
Fixes  #4909
Microsoft Reviewers: Open in CodeFlow

Can you also enable this test?
https://github.com/dotnet/aspire/blob/8605f40ac701fd711295c4939cd5fa2553bbb593/tests/Aspire.Hosting.Kafka.Tests/KafkaFunctionalTests.cs#L76-L81

Yeah sure, test is updated

The kafka tests are still failing, but with an other exception. @eerhardt should they already work? (There are also exceptions in the Playwright test, but i guess this is not related to the kafka resource?)

The kafka tests are still failing, but with an other exception. @eerhardt should they already work?

If they need to be fixed, can you please fix them? I wasn't able to valdiate them because of this issue. But I followed the same test pattern as used elsewhere.

(There are also exceptions in the Playwright test, but i guess this is not related to the kafka resource?)

Yeah, this is unrelated flakiness in our tests that we are trying to fix.

@eerhardt There are currently two problems with the resource:

Volumes/Bind mounts are mounted so that they can only be written by root user - Kafka is run using a different user. The best approach i found for that problem would be to start Kafka as root using (--user root) on the container, but I am not sure whether this has some disadvantages/is a bad practice
The await app.StopAsync(); does not actually wait for the container to exit, meaning that the first container still has a lock on the files while the second container is already trying to read - leading to a timeout. The only fix i could currently figure out would be to add a delay before starting the second container (at most with a one minute delay it works). Is there any other way to ensure that the container is shut down?

Is there any other way to ensure that the container is shut down?

We have https://github.com/dotnet/aspire/issues/4878 to try to come up with a solution for that. cc @karolz-ms @mitchdenny

Volumes/Bind mounts are mounted so that they can only be written by root user

You mean the root user inside the container? And Kafka is running as a separate user from the root user, so it can't access the directory?
@karolz-ms @danegsta - thoughts on this scenario? Does DCP support giving access to volumes and mounts to other users?

Hrm interesting. Yeah I think we need to solve this. I don't think we should expect the container workloads to change the user they are running as since that seems like a lot of containerized workloads would break if we did that.
How is this solved outside of Aspire when people want to use bindmounts and data volumes. Its not like we are doing anything special here?

@stbau04 this is a known issue with bind mounts, in the sense that, depending on what container orchestrator flavor/host OS you use, there might be different steps necessary to ensure that the process running inside the container has permissions to the bind mount https://www.reddit.com/r/docker/comments/1b8dnm6/is_there_an_easy_solution_to_the_permission/
That said there is the host side and the container side, and so you can try to change the user the container is running as (as you tried, running as root), or you can try adjust permissions on the folder that you are binding into the container so that the container user has access. Again, steps may differ depending on container orchestrator (Docker and Podman are supported by Aspire) and host OS, but the rule of thumb is that when specifying permissions on the host side, the user ID must match the user ID for the effective user inside the container. Running container as non-root and changing permissions on the host side is considered a safer practice than running as root inside the container. Hope this helps!

@karolz-ms - do you think we should remove this API until we can make it work? It doesn't sound like there is a straight-forward path to making it work.

One thing to check for Docker volume mounts (both named volumes and bind mounts) is that the behavior can be different depending on whether you're mounting to a path that already exists in a container image or not. If you volume mount to a non-existent folder (even if it's a child of an existing folder), Docker will create the new folder path in the container using root permissions, even if the container itself will run as a non-root user. If the folder already exists, it will preserve the existing permissions inside the container. For bind mounts, it'll also preserve the local file system permissions for any child files/folders that are introduced as part of the mount (named volumes are usually easier to deal with if you don't need to write to/read from files on the host).

@stbau04 - are you still working on this PR? Can you try the solution above?

@eerhardt Sadly i don't have a lot time at the moment to figure something out. I can give the solution a try but in my opinion it's not a good idea to automatically manipulate the host folder permissions

@eerhardt Seems like changing the directory permission on the host does not work for windows: https://stackoverflow.com/questions/66388158/changing-file-permissions-from-a-mounted-file-from-inside-the-docker-container
So i think there are are basically two possible approaches:

Run the container as root user (--u root)
Modify the container image so that chmod is executed (or maybe ensure that the folder already exists with right permissions)

I am soon on holiday for a few weeks, so i am not able to do any more work/research on this topic in the near future

Thanks for the information and the attempts, @stbau04.

i am not able to do any more work/research on this topic in the near future

Closing this PR until it can be actively worked on.


Math.max(...array) considered harmful

CATEGORY
Choose one

[X] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

In <FilterableTable> we're computing the maximum value of an array using this code snippet:
max_value = Math.max(...some_array);

The problem is that if some_array is big this will trigger the error RangeError: Maximum call stack size exceeded, since the number of arguments passed to the function Math.max is too big.
I fixed it by using reduce instead.

TEST PLAN

Tested with a query that was failing, it now works.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@khtruong

Codecov Report

Merging #8575 into master will increase coverage by 5.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8575      +/-   ##
==========================================
+ Coverage    66.5%   71.62%   +5.11%
==========================================
  Files         450      118     -332
  Lines       23117    12587   -10530
  Branches     2451        0    -2451
==========================================
- Hits        15375     9016    -6359
+ Misses       7593     3571    -4022
+ Partials      149        0     -149

Impacted Files
Coverage Δ

superset/db_engine_specs/postgres.py
55.55% <0%> (-27.78%)
:arrow_down:

...sets/src/explore/components/ExploreChartHeader.jsx

superset/assets/src/components/Checkbox.jsx

...perset/assets/src/dashboard/util/getEmptyLayout.js

...ts/src/dashboard/util/getComponentWidthFromDrop.js

.../assets/src/dashboard/reducers/dashboardFilters.js

...rc/explore/components/controls/AnnotationLayer.jsx

superset/assets/src/welcome/DashboardTable.jsx

...erset/assets/src/dashboard/util/injectCustomCss.js

...explore/components/controls/ColorPickerControl.jsx

... and 322 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f41b3...df02493. Read the comment docs.


Recompile plugin with steampipe-plugin-sdk v3.3.0

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)

Closing this since steampipe-plugin-sdk v3.3.0 had a bug which was resolved in v3.3.1


Merge branch 'master' into develop

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/valentingavran/anglify/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Codecov Report

Merging #182 (b4317c0) into develop (1593cd4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #182   +/-   ##
========================================
  Coverage    55.54%   55.54%
========================================
  Files           89       89
  Lines         1750     1750
  Branches       204      204
========================================
  Hits           972      972
  Misses         751      751
  Partials        27       27

Impacted Files
Coverage Δ

...ibs/anglify/src/modules/dialog/dialog.component.ts
85.71% <0.00%> (ø)

libs/anglify/src/modules/dialog/dialog.service.ts
39.47% <0.00%> (ø)

...anglify/src/modules/snackbar/snackbar.component.ts
61.90% <0.00%> (ø)

...s/anglify/src/modules/snackbar/snackbar.service.ts
39.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1593cd4...b4317c0. Read the comment docs.


attempt 1 at parallel download

This works fine to download, but I don't think the downloading is actually occuring in parallel. I'm using the exact same setup in another library that seems to be working as expected, so the serialization may be forced somehow by the ASF objects we're importing?

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy

@bbuzz31 seems to work to me. Its making 10 temp files. You can also see that the progress in the download seems to be going all over the place. So i think that the progress bar is what is being challenged to report it accurately.

You can it also see it based on the summary of the progress. i.e. the numbr of files changes and the progress is not the same everywhere.

I crashed the download and restarted and it seems to skip the files.
Would just suggest to try a few of the other options like the url and see if it conflicts.

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

See the complete overview on Codacy


Plugin needs to be updated to support released Godot 3.2 API

See: https://github.com/godotengine/godot/issues/32827
Currently a compilation error occurs here: https://github.com/funabab/godot-camera-plugin/blob/654319f0a663145c9481e887c510e3a3df4ad7bd/android/godot-camera-plugin.funabab/src/org/godotengine/godot/funabab/camera/FunababCameraPlugin.java#L57
(via)
See also: https://github.com/funabab/godot-camera-plugin-demo/pull/1

Related:

PR which exposes replacement functionality & includes some docs: https://github.com/godotengine/godot/pull/32858/files

Another plugin project's patch to support the replacement functionality: https://github.com/Shin-NiL/Godot-Android-Admob-Plugin/commit/9bface03e9b5c578a49b7cca7d751f5bb8056cd5

See https://github.com/funabab/godot-camera-plugin-demo/pull/2 for a fix.


Extremely BASIC iOS Gif support. (Have to start somewhere)

This includes VERY basic GIF support for iOS with an included sample. I would imagine that as users needs for more advanced GIF support come up, we will see additional PR's.

Hi @alanspires, could we discuss by email? You can find my email here: https://github.com/molinch

Further research. iOS saves GIF's as 1 frame JPEG's. Big comapibes like FB or twitter seem to have access to metadata that gives them an actual link to the GIF. But regardless.. Scenario...

Go to giphy.com save it library. Saves as a JPEG. If you copy and paste into iMessage it magically reanimates. If you get the filePath in code it leads to a JPEG with no meta. So....

This destroys caching....
Without saving the original URL it's impossible to use helper routines to re-animate.
REDDIT makes you store GIF's as a link to the original (makes sense considering). This works as you have the data of the image.
How would one reload a GIF stored as a JPEG?
Tricky.

@alanspires Thank you for great PR. I merged it, we can optimise it later and (hopefully) add Android support too.

Sounds good!

On May 13, 2017, at 10:18, Daniel Luberda<EMAIL_ADDRESS>wrote:
Merged #470.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


ColorInput width is broken after visiting Branding Page

Setup

Rancher version: pre 2.9.0

Describe the bug

See screenshots
Branding page - shows wide area for colour, instead of small block colour then colour hash
Brand page - after visiting the branding page, block colour extends to max width

To Reproduce

visit branding page, see issue
then visit banners page, see issue

Result

as per screenshots

Expected Result

all colour pickers should look like the bottom screenshot

Screenshots
Branding Page

Banners Page (after visiting brancing page)

Banners Page (without visiting brancing page)

Additional context

caused by unscoped style block brought in via https://github.com/rancher/dashboard/pull/10502

Ah sorry for the regression. IIRC , there was an issue showing the background images in the correct position. Removing the scope fixed the issue but introduced this regression.
I will take a look. @nwmac


[FIX] Check _flipFaces on camera not camera component

Error introduced in #3346

Should we rename camera to cameraComponent?

Should we rename camera to cameraComponent?

Maybe some other time :)

Should we rename camera to cameraComponent?

Maybe some other time :)

Would we hit the same issue next time though? It's only because I double check potential tutorial projects that may be affected by render textures that we found this?

We should add that project to the test plan. 😄

We should add that project to the test plan. 😄

Done :)


Unable to resolve dependencies with React Native 0.73.2

React Native Step Counter New Issue
Expected Behavior

I should be able add this library to a React Native 0.73.2 project

Actual Behavior

I am getting the following error:

% npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react-native
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^0.72.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@dongminyu/react-native-step-counter
npm ERR<EMAIL_ADDRESS>from the root project

Thanks for the first issue report. It was a misunderstanding on my part about peer dependency, which was relying on a specific React native version. This has been removed in commit, which you can find in version 0.2.5 released today.


fix(fxdev): fix color format

:tada: This PR is included in version 3.6.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


🍒 Cherry pick PR #5318 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/5318 to staging 🍒

🚀 Cherry-picked to staging by @OSBotify in version: 1.1.8-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Pokemon Optimizer fails to transfer Poke's

Expected Behavior
pokemon_optimizer does:
by family; top 2 by ivcp = evolve
    else transfer
per pokemon; top 2 by attack perfection w/ ivcp>0.8 = upgrade
per pokemon; top 2 by defense perfection w/ ivcp>0.8 = upgrade

Actual Behavior
Nothing is exchanged or evolved, pokemon bag is full.
Attempt to transfer doesn't seem to respect delay timers.
Your FULL config.json (remove your username, password, gmapkey and any other private info)
http://pastebin.com/7hh1K9nm
Also tried for PokemonOptimizer using only
 "rules": [
                    {
                        "mode": "by_family",
                        "top": 2,
                        "sort": ["ivcp"],
                        "evolve": true,
                        "upgrade": {"ivcp": 0.8}
                    }
             ]

Output when issue occurred
http://pastebin.com/hckyRJK3
Steps to Reproduce
Use config above with 815abd739905504ccbfa4e3a5687fe47f6c24123
Other Information
OS: Linux Mint 18
Branch: Dev
Git Commit: 815abd739905504ccbfa4e3a5687fe47f6c24123
Python Version: 2.7.12
Attempted Solutions
Reverted pokemon_optimizer.py to 9a00253e92e3880fbfb2a19a300fd2a6f847271a
This optimizer was working for me as of last night.
Today, pokemon can not be transferred. Assuming that this is due to API change.
EvolvePokemon and TransferPokemon tasks work fine.

wired. never saw that happen. you also need pip install --upgrade -r requirement.txt after a fresh clone.

@solderzzc yep, that runs as well. Says everything is up to date. I use this short bash script
cd ~/PokemonGo-Bot
git fetch --all
git reset --hard origin/dev
git pull origin dev
source bin/activate
pip install -U -r requirements.txt
git submodule init
git submodule update

There is issues in your config in rule 2 and 3
"sort" : ["attack_perfection", {"ivcp": 0.8}]

should be changed to something else. It depends what you want to do with that rule.

the output that you show has been produced with enabled: false, that is why timer is not respected, it is only a dry run.


check if Mix_HasMusicDecoder is available

Strangely, function is in SDL_mixer.h but not available in the library, so not usable

Reported to Fedora maintainer as https://bugzilla.redhat.com/show_bug.cgi?id=2063495

Wow, I would never have seen it. Thank you!

FYI: this function is not available in any released version
See https://github.com/libsdl-org/SDL_mixer/commit/8d3c364c


[3.0-beta0] Crash when clicking on "X" of window

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions
[X] This issue is about a bug (if it is not, please use the correct template)

Describe your issue
When I click on "X"-symbol it should minimize to tray but instead it crashes with an error report.
Steps to reproduce the issue

Launch WingetUI
Enable "Close WingetUI to the notification area" under "Notification Tray Options"
Clicking on "X" in window title bar

WingetUI Log
OS: Win32NT
                   Version: Microsoft Windows NT 10.0.22631.0
           OS Architecture: True
          APP Architecture: True
                  Language: Unknown
               APP Version: 3.0-beta0
                Executable: C:\Program Files\WingetUI\WingetUI.exe

Crash Message: Invalid function. (0x80070001)

Crash Traceback:
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(Int32 errorCode)
   at H.NotifyIcon.Interop.InteropUtilities.EnsureNonZero(BOOL value) in /_/src/libs/H.NotifyIcon/Interop/InteropUtilities.cs:line 85
   at H.NotifyIcon.EfficiencyMode.EfficiencyModeUtilities.SetProcessQualityOfServiceLevel(QualityOfServiceLevel level) in /_/src/libs/H.NotifyIcon/EfficiencyMode/EfficiencyModeUtilities.cs:line 53
   at H.NotifyIcon.EfficiencyMode.EfficiencyModeUtilities.SetEfficiencyMode(Boolean value) in /_/src/libs/H.NotifyIcon/EfficiencyMode/EfficiencyModeUtilities.cs:line 97
   at H.NotifyIcon.WindowExtensions.Hide(Window window, Boolean enableEfficiencyMode) in /_/src/libs/H.NotifyIcon.Shared/WindowExtensions.cs:line 37
   at ModernWindow.MainWindow.HandleClosingEvent(AppWindow sender, AppWindowClosingEventArgs args) in Y:\WingetUI-Store\src\wingetui\Interface\MainWindow.xaml.cs:line 92
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.<>c__DisplayClass2_0.<Post>b__0()

Package Managers Logs
Not relevant because updating apps is working as intended.

Relevant information
Possible .NET error?
Screenshots and videos
No response

It looks as an issue with the Efficiency Mode handled by the System Tray Icon library


fix(logging): review and adjust log message and level in engine, relica and instance controllers

ref: longhorn/longhorn#5888
Main Idea:

use Failed to + V instead of Error Ving
when doing operation, log before with .Info("Ving + ...") and no need to log after operation is successful since if there is any error, error will be returned and reported in upper function.
if an error will be consumed w/o being returned back to the caller, using warning, since it has been handled.
If an error will be returned/bubbled up, suggest no extra logging but can be enriched with another error wrapper to prevent a duplicated error log. This needs to check if there would be a chance to have duplicated error message.

This pull request is now in conflicts. Could you fix it @ChanYiLin? 🙏

conflicts resolved

Hi @innobead
I have fixed the

Info instead of Infof if there is no argument (Warn, Error as well)
Error logging in the handleErr function


Can't seem to mock axios in a stamp

Hi there,
I'm trying to write a unit test that tests my stamp, this is the setup of my files:
useFetch.ts
import stampit from '@stamp/it';
import axios from 'axios';

export default stampit({
  init({
    baseURL,
    headers
  }: {
    baseURL: string;
    headers: object;
  }) {
    this.fetch = axios.create({
      baseURL: this.baseURL || baseURL,
      headers: this.headers || headers
    });
  },
  methods: {
    async setQuery(params: string) {
      if (!this.query) {
        this.query = `?${params}`;
      } else {
        this.query = `${this.query}&${params}`;
      }
    },
    async request(url: string, type: string) {
      try {
        const fullURL: string = `${url || '/'}${this.query || ''}`
        return await this.fetch.get(fullURL);
      } catch (error) {
        throw error;
      }
    }
  }
});

And my test file:
import MockAdapter from 'axios-mock-adapter';
import { expect, assert } from 'chai';
import sinon from 'sinon';
import useFetch from './useFetch';
import axios, { AxiosError } from 'axios';
import stampit from '@stamp/it';

describe("useFetch", function() {
  describe("get", async () => {

    let stub: MockAdapter;
    const receivedData = { data: 'data' };

    before(() => {
      stub = new MockAdapter(useFetch());
      stub.onGet('https://google.com').replyOnce(200, receivedData);
    });

    it("returns data in a string", async () => {
      const response = await useFetch({
        baseURL: 'https://google.com'
      }).request();

      expect(response.status).to.be.equal(200);
      expect(response.data).to.be.deep.equal(receivedData);
    });

    after(() => {
      stub.restore();
    });
  });
});

What should I do to make this test work?

Thanks for your question.
Everything seems right. What's not working though?

It is calling the original Axios instance instead of the MockedAdapter.

Ah, mate, you need to ask the question in the axios and axios-mock-adapter projects respectively. I do not see you are using Stamps for mocking.
With stamps, one do not need any mocking libraries. Stampit can mock anything. Here is an article on that topic: https://medium.com/@koresar/fun-with-stamps-episode-17-easy-100-unit-test-coverage-in-js-d97e09591f18


Support for .jsx extension

I have a codebase where JSX code is stored using .jsx extension, and webpack converts various entrypoints to the corresponding js file on save.
The 'Transpile On Save' is a great feature. I don't have to refresh the page, and check if something is broken. But it only seems to be working on files with .js extension and not the ones with .jsx extension.
Would you recommend renaming all .jsx files to .js? Or will language-babel support .jsx extension in the future?

.jsx files are supported by default. If another grammar also supports .jsx and/or has been enabled for .jsx files prior then the other grammar tends to take precedence. Either disable the other grammar or ensure my grammar is selected. Look at the bottom right status bar to see the grammar selected. Click it if incorrect.

The read me describes this
Usage
By default the language-babel package will detect file types  .js , .babel , .jsx  and  es6 . Use the standard ATOM interface to enable it for other file types. This provides a grammar that scopes the file in order to colour the text in a meaningful way. If other JavaScript grammars are enabled these may take precedence over language-babel. Look at the bottom right status bar indicator to determine the language grammar of a file being edited. language-babel will be shown as  Babel ES6 JavaScript

Thanks!
I'm sorry I missed that.

This is awesome. Thanks for creating the project :)


WebSocket connection dying after a couple of hours

I'm encountering an issue with the WebSocket connection in hxdiscord. After about 6 hours of continuous use, the WebSocket connection fails, requiring manual reconnection to resume operation.
This issue is causing significant inconvenience for users who rely on this repository. I have attempted several solutions, including adjusting timeout durations, but none have successfully resolved the problem.
I would greatly appreciate any assistance in resolving this issue or suggestions for possible solutions. It seems to be a common problem with Discord repositories, and I have not found any reliable solutions thus far.
I will update in the comments section what I have tried so far, and if something works I will close this issue. I'd be grateful for any help
Thank you!

I've got something planned, I will leave a Discord Bot turned off for a couple of hours, if it works then I'm going to close this issue, no help needed for now

fixed i think!!


Deselect Letters

Deselecting letters if they are clicked again.
Also displaying some messages like "invalid word" when wrong words are submitted.

Sounds good, it does already have messages displayed if the user comes up with an invalid word or has already submitted a word and also if the word is less than 3 characters.

Can you assign this to me? I am already working on this.

No problem


How to open multiple emulator in Windows?

I would like to open multiple emulator to test my Bot.  Is there any way to open multiple emulator?

This is not possible right now. The reason for the limitation is our integration with ngrok. ngrok's free-tier service allows only one instance at a time running on the host machine. There are certainly cases where this feels too limiting. I think I could be convinced to change it :)
In the meantime, if you want this functionality, it's pretty simple to build and run from source. That way you can disable the check locally (and even submit a pull request?). The line of code containing the instance check is here.
Instructions to build and run from source: https://github.com/Microsoft/BotFramework-Emulator/wiki/How-to-Contribute#build-and-run-from-source

I test my bot at localhost. So no need to use ngrok. Thanks.

Fixed with build 3.4.26

[14:15:13] Checking for new version...
[14:15:14] Failed to start ngrok: undefined
[14:15:14] ngrok may already be running in a different process. ngrok's free tier allows only one instance at a time per host.
Hi,
I am facing this issue while using Bot framework channel Emulator and ngrok tunneling software.
I gave the proper path in App settings of emulator for ngrok.exe and had also launched emulator as administrator. But end up in above error.
If anyone can help in this.
Thanks !

Hi @Tushti02, as I mentioned in the other issue you raised #315, I believe there is a way of calling the ngrok API that would allow all instances of the emulator to share the same ngrok process. I've created a new issue for tracking this as a bug/feature request: #316. I don't have a timeline for when this work will start, or complete, but wanted to mention that it looks like there is a solution.


Categories view does not show all types of applications

Describe the bug
Categories view does not show all types of applications.
To Reproduce
Steps to reproduce the behavior:

Go to 'Categories'
Click on Audio or Video category
Scroll down to the end of list
See only FlatPak-based applications

Expected behavior
All application types are shown - Snap, AppImage and FlatPak. For example VLC should be shown in all three types for Audio and Video categories.
Desktop (please complete the following information):

OS: Ubuntu MATE 16.04 LTS
Version 1.3.4

Same here.

Fedora and Fedora Silverblue 33
Version 1.3.4


Can continue support using free trial 10 times a day for free? I think this is a good solution instead of permanently limiting it to 25 times now

Validations

[X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem
Can continue support using free trial 10 times a day for free? I think this is a good solution instead of permanently limiting it to 25 times now
Solution
Can continue support using free trial 10 times a day for free? I think this is a good solution instead of permanently limiting it to 25 times now

We can consider this, but will need to monitor and understand what the costs will be. I appreciate your feedback!

I also think this is a good idea,like CodeGPT or Codeuim have a daily limit


make manpager.vim work on mac

under mac, the manpage name is not in the first line, but in the first NONBLANK line.

Codecov Report

Merging #2296 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
+ Coverage   74.42%   74.44%   +0.01%
==========================================
  Files          90       90
  Lines      132130   132130
  Branches    30730    30890     +160
==========================================
+ Hits        98341    98362      +21
+ Misses      33764    33743      -21
  Partials       25       25

Impacted Files
Coverage Δ

src/eval.c
80.77% <0%> (-0.05%)
:arrow_down:

src/channel.c
82.48% <0%> (+0.04%)
:arrow_up:

src/gui_gtk_x11.c
47.7% <0%> (+0.04%)
:arrow_up:

src/gui.c
47.21% <0%> (+0.05%)
:arrow_up:

src/window.c
80.96% <0%> (+0.09%)
:arrow_up:

src/term.c
50.94% <0%> (+0.21%)
:arrow_up:

src/ex_cmds.c
78% <0%> (+0.22%)
:arrow_up:

src/message.c
68.31% <0%> (+0.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ec795...86a4de8. Read the comment docs.

So I guess the lowercase is there because we expect most manpages about lower case commands? Can't we simply check if the manpage exists and if not try we the lower case version (or the other way around)? Something like this (pseudo code):
" only check if man page exists, check return value
call system('man' page)
if v:shell_error
   call system('man' lower(page))
endif
if v:shell_error
   echo "Man page does not exists"
endif

Thanks Enno, I'll include it.

Yeah Christian, this might be possible. Should this check be done by the manpager.vim plugin, or rather by the command :Man in the manpage.vim ftplugin ?
Perhaps some shell scripting is needed to infer which letters of the file name are upper and lower case, starting from the (lower cased) man page title.

Can't we simply check if the manpage exists and if not try we the lower case version (or the other way around)?

@chrisbra Nope.  On OpenBSD f.i. there's a zzz and a ZZZ, and they do different things.
As I said: the non-$MAN_PN case is hopeless.  Which is why I suggested  to give up on it, and focus instead on writing a shell script that can syntesize a $MAN_PN before running man, if man doesn't provide a $MAN_PN.

@Konfekt
Did you really test the patch yourself on macOS?  I confirm that it works fine for man 1 printf, man 3 printf and so on, but fails to work for, e.g., man Xorg or man DBD::File.
For macOS, when you derive the file name of a man page from the name in its header, you need to convert the latter into the former in a "smart" way: When the whole of a header name is written in upper case,  do tolowerover it; otherwise, try using it as-is, just like a patch I previously sent to vim_dev, though I don't claim I gave a correct solution there.
Surely, it doesn't appear that this "smart" way always work since there's no guarantee or specifications that file names can always be derived from the corresponding header names via (conditional) case change (I can think of a case where short forms are used for some header names).   But that's an implementation limitation the current plugin/manpager.vim inherently has.
N.B. the default filesystem of macOS is case-insensitive; therefore, you don't need to take the "zzz"-vs-"ZZZ" case into account for that platform.

Dear @nuko8, no I did not. This patch does not claim to solve the problem of case sensitive man pages in upper case letters, in fact, it claims that one cannot be smart about man pages containing upper case letters and gives up on it. For the reasoning, please see
https://github.com/vim/vim/pull/2296/files/9358b2ee9cf152390e9f97b60b3c775879c78473#r149420535
That said, @rlue came up with another solution in https://github.com/vim/vim/pull/2318/files that perhaps achieves this by other means.

Ok,
You refer to
+    if !has('mac') || manpage =~ '\v^[-_.:0-9A-Z]+\('
+      let manpage = tolower(manpage)
+    endif

As I understand, the additional check is due to the case insensitivity of the Mac file system. Are there perhaps platforms besides Mac whose file system is case insensitive?
What I do not understand is that you explain that

the default filesystem of macOS is case-insensitive; therefore, you don't need to take the "zzz"-vs-"ZZZ" case into account for that platform.

However, at the same time, the man pager fails because the man page file contains upper case letters?
Then, does this conversion always hit right? Aren't there any man page files that have all capital letters?
If so, as this pull request is closed, should this go into a different pull request?
PS: To correct myself, the pull request by @rlue https://github.com/vim/vim/pull/2318/files resolves a different issue.

I don't really know much about man, but my understanding is that the challenge of manpager.vim is to infer, from the text of a manpage, its precise location in the man db (/usr/share/man or whatever else it might be on other systems). I don't know whether there is a standard for how such a location should be encoded in the first line of the file, but it seems:

the general rule for most built-in and commonly-used GNU utilities is manpage headers in uppercase and filenames in lowercase, e.g., LS(1) for /usr/share/man/man1/ls.1

an unfortunate and not-uncommon edge case is filenames and manpage headers matching case (e.g., Xorg(1) for /usr/share/man/man1/Xorg.1)

another unfortunate edge case where, e.g., zzz and ZZZ both have separate manpages, but may use uppercased manpage headers (at least, it appears that way for zzz).

another (hopefully one-off) edge case I've encountered is with GNU stow:
IO::FILE=IO(0X81D9F0)(1)					User Contributed Perl Documentation					  IO::FILE=IO(0X81D9F0)(1)

(and it turns out this manpage isn't even in section 1 of the manpages — it's in section 8!)

I don't know of any other edge cases (though I'm sure there are at least a few).
Proposal
What would the maintainers think of the following procedure?

Check for both the case-sensitive and downcased versions of the manpage. If only one is found, use that. If both are found, then...
Use the numeric section from the manpage header, and the name from the first word of the first line of the NAME section of the manpage (case-sensitive).
If the manpage header can't be parsed according to the standard format, don't use any numeric section and simply call :Man with the first word of the first line of the NAME section of the manpage (case-sensitive).


[main > release/0.24.x]: Add support for office.com urls and fix driver to get corrrect id for tree.

Cherry pick:
1.) https://github.com/microsoft/FluidFramework/pull/2632
2.) https://github.com/microsoft/FluidFramework/pull/3633

BTW, you might want to consider adding my change that removes ability to start with ops, I think it's not in 0.24

BTW, you might want to consider adding my change that removes ability to start with ops, I think it's not in 0.24

Can you point to that change?


Replace npm with yarn

Update contributing guide
Replace package-lock.json with yarn.lock
Update CircleCI commands

Heroku and CircleCI images includes yarn out of the box so there is no need to update them.

Question: just to make sure does it support pre-commit hook via husky that we have specified?

Yep, it sets them correctly. We use them on our project all the time.

@jorgeorpinel @dashohoxha @algomaster99 mind this change, guys! please let us know if you hit any issues.

On Ununtu-18.04 I get these warnings:
$ yarn
yarn install v1.17.3
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "babel-jest ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>[4/4] Building fresh packages...
Done in 63.36s.

$ yarn
yarn install v1.17.3
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.81s.

I hope they are normal, because everything else (for example yarn dev) works as expected.

@dashohoxha Thanks! They are installed via submodules of other packages right now, so there should not be any practical problems. But to prevent problems in the future it is better to explicitly add them. Made it in separate PR because this was already merged: https://github.com/iterative/dvc.org/pull/600

Works well for me.
Can you remind us what benefits does this bring though? Is it just for the MacOS inconsistencies when running npm install?

@jorgeorpinel Not exactly on Mac. Problem looks like this:

Some dependencies in package.json can be optional and only used on one OS and not used on other OSes. In our case this dependency is fsevents – library to detect file changes on Mac OS.
When npm install in run on Mac fsevents is correctly marked as required. But then somebody run npm install on Linux or Windows after that in some cases npm updates package-lock.json and mark fsevents as optional (because it is not needed on this operating systems).
Now if Windows/Linux user commit this changes, it can break builds for users on Mac, because fsevents will not be installed.

It can potentially be any library and any OS combination, not only fsevents and Mac OS.
Most other differences between yarn and npm are not as important right now as they where important in the past. But on plus side we have better interface for updating dependencies with yarn upgrade-interactive and yarn upgrade-interactive --latest, but this is not that important.

I see, thanks. So yarn always mark fsevents as required even when it's only needed on Mac?
This is what I see from my Mac:
$ yarn why fsevents
yarn why v1.17.3
[1/4] 🤔  Why do we have the module "fsevents"...?
...
info Reasons this module exists
   - "babel-jest#@jest#transform#jest-haste-map" depends on it
   - Hoisted from "babel-jest#@jest#transform#jest-haste-map#fsevents"
   - Hoisted from "next#webpack#watchpack#chokidar#fsevents"

@jorgeorpinel yep, yarn will always add fsevents to the yarn.lock.


Better handling of JSON primitives with protocols

First off let me say: awesome library! I only came accross this two days ago and I'm already using it in two projects.
I had a look through the issues to see where I could help out and that led me down a rabbit hole in which I think I've found a better way to handle JSON primitives internally using protocols.
Currently, values that can be directly mapped to JSON are handled by 'catch all' encode and decode functions which return generic type T?. A problem with this is that the compiler will accept any type for these functions since the generic type is not constrained. This may lead people to accidentally attempt to encode or decode a type which can never be encoded or decoded and they'll get no error from the compiler if they do.
I think that a solution to this is adding two new protocols the first of which is:
public protocol JSONPrimitive {}

extension JSONPrimitive {
  public static func decode(key: String, keyPathDelimiter: String = GlossKeyPathDelimiter) -> JSON -> Self? {
    return { json in
      if let value = json.valueForKeyPath(key, withDelimiter: keyPathDelimiter) as? Self {
        return value
      }
      return nil
    }
  }

  public static func encode(key: String) -> Self? -> JSON? {
    return { property in
      if let property = property as? AnyObject {
        return [key : property]
      }
      return nil
    }
  }
}

Defining this protocol then means that the encode and decode global functions and operators can be defined like this:
public func decode<T: JSONPrimitive>(key: String) -> JSON -> T? {
  return T.decode(key)
}

public func encode<T: JSONPrimitive>(key: String) -> T? -> JSON? {
  return T.encode(key)
}

public func <~~ <T: JSONPrimitive>(key: String, json: JSON) -> T? {
  return decode(key)(json)
}

public func ~~> <T: JSONPrimitive>(key: String, property: T?) -> JSON? {
  return encode(key)(property)
}

Then its as easy as:
extension String: JSONPrimitive {}

to make a type a JSON primitive.
For types that need to be converted when theyre transcoded there is:
public protocol JSONPrimitiveConvertible: JSONPrimitive {
  static func decodeItem(json: AnyObject) -> Self?
  func encodeItem() -> AnyObject
}

public extension JSONPrimitiveConvertible {
  static func decode(key: String, keyPathDelimiter: String = GlossKeyPathDelimiter) -> JSON -> Self? {
    return { json in
      if let value = json.valueForKeyPath(key, withDelimiter: keyPathDelimiter) {
        return decodeItem(value)
      }
      return nil
    }
  }

  static func encode(key: String) -> Self? -> JSON? {
    return { property in
      if let property = property {
        return [key: property.encodeItem()]
      }
      return nil
    }
  }
}

This protocol significantly reduces the boilerplate in the library since it removes all of the functions and operators for types which need to be converted when theyre transcoded.  To make a type a JSON primitive convertible its as easy as:
extension UInt32: JSONPrimitiveConvertible {
  public static func decodeItem(json: AnyObject) -> UInt32? {
    if let number = json as? NSNumber {
      return number.unsignedIntValue
    }
    return nil
  }

  public func encodeItem() -> AnyObject {
    return NSNumber(unsignedInt: self)
  }
}

The best part: you get the operators and global functions from JSONPrimitive for free!
Theres more work to be done including functions and operators for primitive arrays and tests but I wanted to create this issue first since these are some fairly major changes. I'm happy to submit a PR for this if its something that you would want.
Thanks for reading!

wow I really appreciate the thoughtwork here! cool stuff.
this is a vast change - I'll need some time to try it out think about the ramifications. I'll reply back here with my thoughts

cleaning up old issues - i'll not be investing in this implementation as i support Gloss in maintenance & suggest generally to use Codable


chore(main): release 0.0.4

:robot: I have created a release beep boop
0.0.4 (2024-06-02)
What's Changed

add: baseline evaluation by @StanGirard in https://github.com/QuivrHQ/MegaParse/pull/7
Add support for Unstructured Parser, improve Table and Image Parsing, and add TOC and Hyperlinks for Docx by @StanGirard in https://github.com/QuivrHQ/MegaParse/pull/9

Full Changelog: https://github.com/QuivrHQ/MegaParse/compare/v0.0.3...v0.0.4

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/QuivrHQ/MegaParse/releases/tag/v0.0.4 :sunflower:


create puzzle pieces / puzzle board

create components for the puzzle board and for the individual pieces.

resolved with merge #15


chore(Python): add  remove duplicate and first non-repeating character string

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR
Added two new strings based algorithms/solutions for Python.
Algorithm 1: Remove Duplicates from a string (using 26character string instead of set/dictionaries)
Algorithm 2: First non repeating character in a string (without using dictionary)
Other information:
Updated the readme accordingly.

Hi @Sankalp7943,
Please fix the pull request comment, see markdown guide as example

Hi @Sankalp7943,
Please fix the pull request comment, see markdown guide as example

Does it look better?

program fails if the test string contains anything apart from lower case english alphabets.

Oh yes, I forgot to add the constraint in the second file. I will fix it .

Instead of putting comments telling constraints, it's better to handle them inside your code so that it shows error message instead of straight up crashing in case of invalid input.

Instead of putting comments telling constraints, it's better to handle them inside your code so that it shows error message instead of straight up crashing in case of invalid input.

Done. Didn't raise error. Just returned Invalid string


Contributor communication channel

Is there a public-facing communication channel (e.g., Slack or Discord) for current and/or potential contributors/researchers? If not, I am happy to set up one! :)

We've set up a slack channel in the NeSy workspace.
Please send a mail to [Prof<EMAIL_ADDRESS><EMAIL_ADDRESS>to be added to that workspace


build(deps): update dependencies

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring
[x] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

This PR includes the following changes:

~Updates opentelemetry crates to stable version (0.19)~
Updates AWS crates
Uses upstream git URL for async-bb8-diesel
Updates dependency versions for a few crates
Reorders crates and formats the Cargo.toml files
Moves the Rust edition, MSRV and license metadata to the workspace manifest file
Removes the unused examples directory
Moves the router build script out of the router/src directory into the router directory
Adds description and READMEs to all crates' metadata, removes file tree layout from READMEs from most crates

Motivation and Context

N/A
How did you test it?

Created a successful payment via Postman.
Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Can we take advantage of semver and just specify the x.y or just x rather than upgrading the z everytime? (x.y.z)

We can use major.minor for crates with major version >= 1, and use major.minor.patch format for crates with version 0.x.y. What do you say?

Can we always have some github issue wherever we have a github reference in cargo.toml

Sure! As of now, only async-bb8-diesel is used as a git dependency since it hasn't been published on crates.io. For any other crates used as git dependencies, we'll have issues to track them moving forward.


add testnet51

Closes: #???
Description

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

sry for not waiting for your review @peterargue


First sketch of package constructor

Add a test to the integration/test_packages.py file

@meffij Your code might be creating shadow file structure, due to a path with an extra forward slash (/) in a path somewhere.


Implement new email provider: Email Webhook

Email Webhook provider will send a HTTP request to specific endpoint when casdoor need to send email. This method allow users to handle email by their own will.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix: turn off remain-on-exit only on fzf-tmux pane

fix #3397

Commit messages contain further detail. Please let me know if any rebasing needed 🙂 .

LGTM 👍

Merged, thanks!

🎉 Thanks for your help.


Updates and cleanup

Opened as draft since there is more to come.

The main script refactoring and plugin implementation is complete.
Both have been thoroughly tested using the postgres, and null plugin.

The initial mongo plugin refactoring and implementation are complete.  All mongo functions have been tested.
Final verification tasks to complete:

Double check restore is functioning as expected.
Test restoration of a backup to a database of a different name.
Get @gil0109 and team to test out the new implementation to ensure it still works for them.  Some of the changes required making things more generic while retaining support for implementation specific features that were in use.

Mongo restore has been verified.

Mongo restore to a different database name has been tested.  The current implementation does not support it.  Marked it as a ToDo.

Calling this done and ready for review.

@esune, @gil0109, Could you two have a look over this when you have a moment.  I'd like to get it merged into the mongo branch on the main repo so we can make final preparations for merging into master.  Thanks


[PKG] cpprestsdk

Package name
cpprestsdk
Package URL
https://github.com/microsoft/cpprestsdk
Package source location
https://github.com/microsoft/cpprestsdk

This package had been publish to my maven repository hosted on github https://github.com/leleliu008/ndk-pkg-prefab-aar-maven-repo
You’re welcome to give it a try.


JWT in python example

URL of documentation issue
https://github.com/AdobeDocs/analytics-2.0-apis/blob/main/resources/python/ims_client.py
Description
Documentation states that jwt authentication is deprecated however this example still uses jwt.

@CallumCPP I have submitted a request to development to update this script for the current authorization scheme. I will provide updates as I learn of them.


Fix fragile tests

The previous push to master failed to deploy because of a flaky Windows test.

coverage: 94.701% (-0.03%) from 94.728%
when pulling 7b38e495e230eb6e7ef8b91951eecc4e7144901e on test-fix
into 5966ff7d9d4bf3e8d32858578c18009468ee66d8 on master.


fix: add feedback to more info about this auction

The type of this PR is: Bugfix

This PR resolves CX-795
Description

Add feedback to more info about this auction

before

after

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

great work, thanks 🎉


Fix Spring multiple-bean-definition errors when component scanning config props classes

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage     99.12%   99.12%
  Complexity      633      633
=========================================
  Files            45       45
  Lines          1478     1478
  Branches        160      160
=========================================
  Hits           1465     1465
  Misses            4        4
  Partials          9        9

Impacted Files
Coverage Δ
Complexity Δ

...gtips/springboot/WingtipsSpringBootProperties.java
100% <ø> (ø)
7 <0> (ø)
:arrow_down:

.../wingtips/springboot/WingtipsZipkinProperties.java
100% <ø> (ø)
14 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 970e2d9...d8a4d62. Read the comment docs.

The @ConfigurationProperties classes (WingtipsSpringBootProperties and WingtipsZipkinProperties) were marked with @Component, which was causing them to be picked up during Spring component scanning. This led to multiple-bean-definition errors because @EnableConfigurationProperties causes them to be registered under a different bean name.
The @Component annotation on the @ConfigurationProperties classes was unnecessary in any case and should never have been on there to begin with.


Add warning message for transformed data

"transformed data" are variables that can be computed with data.
In JuliaBUGS, these values are computed during compilation. And these variables will not end up in the final graph.
For standalone language like BUGS and Stan, it make sense to add these into the model definition. But for JuliaBUGS, it makes more sense to compute these data transformations in Julia.
This PR add some warning message for this.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

7 of 7 (100.0%)  changed or added relevant lines in 2 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 83.098%

Files with Coverage Reduction
New Missed Lines
%

src/compiler_pass.jl
5
95.47%

Totals

Change from base Build<PHONE_NUMBER>8:
0.04%

Covered Lines:
1470

Relevant Lines:
1769

💛  - Coveralls


What IDE/editor do you use to develop/debug the project ?

I want to read the source code to figure out what the docs are missing, but I can't use Android Studio/CLion/PyCharm to read Java/C++/Python code, there are unresolved reference everywhere.
So very curious about what IDE/editor you use to develop the project? How do you debug it? Using BUCK build and docker set an barrier for people like me to read the code or even contribute to the project.

I can recommend Nuclide: https://nuclide.io/ as I personally use it to work on the project. However, It's also not perfect for reference navigation either.


[AB3 feature] As a no-time-to-waste SoC professor, I can search the projects using specific keywords

... so that I can access the progress of projects of interest with just a few clicks.

Resolved by #82.


Change name of plugin?

Not yet heard back from wordpress.org, but I suspect the name may be rejected as being to close to an existing plugin.

"CSV Importer Improved" was approved, accepted and published on wordpress.org


change log's dir

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Hi,
changing the log directory takes a few more things then just a variable.
Main reason is that all the init script define the log directory as well so it means we need to change it in the services handling to modify it.
Could you also write a spec test for this? With a default value and custom value to ensure we change all the parts correctly?
Thanks!

Closing due to no reply


Apply for Reviewer Role

Signed-off-by: ZhongsJie<EMAIL_ADDRESS>

Great! Can you help prove your qualification here?

Great! Can you help prove your qualification here?

Ok, What should I do?


CASSANDRA-18753: Provide cassandra_latest.yaml with suitable defaults for new users

The first commit renames cassandra.yaml to cassandra_latest.yaml to make it easier to see the differences, the next commit restores the main yaml, and the third one configures testing.

Given test-latest will test tries+oa we could remove all oa test specific jobs to spare CI cycles as they're redundant now?
Also shouldn't this ticket also enable all dtests, both python and jvm, with latest?

Given test-latest will test tries+oa we could remove all oa test specific jobs to spare CI cycles as they're redundant now?

Actually, it will not test the the big-oa format but the bti-da one.
As for dtests, I'm still working on making the relevant changes.

Your 'latest' does already run with SCM NONE which is the same as running with oa feature-wise. Do we see value in testing oa by itself?

big-oa is a separate sstable format, and it needs to be tested. Doing only base junit tests with it is likely sufficient; we can skip dtests (python or in-jvm) on it.

As latest will dtest oa current features that sounds like a good compromise to me, agreed.

are we (and how) dtesting this config too ? (java and python dtests), separate ticket ?

^ https://github.com/apache/cassandra/pull/2896#issuecomment-1812084239

@blambov I have gone through it and you see we have only minors. I would suggest a rebase + CI runs where I will check the new circle setup. Doing that trying to follow the config.yaml changes, which I did but only cursory, would be eye watering...

If this is it's CI it doesn't look pretty :-(

Well, the failures appear to be as expected.
We do have a few outstanding problems that we never tested for before.

CI workflows LGTM +1 on the overall approach and the PR. Disclaimer I have no deep knowledge of all the options that have been enabled but overall SGTM. Commenting in case you'd like sbdy with deep expertise in some area to doublecheck things.
I suggest sending an email to the ML to find out what you mentioned to me offline: Are we ok merging this and surfacing a number of failures?


[MRG] Fixed: param img_filters no longer has a mutable arg ([]) as default

For issue #284
Mutable default args are a source of hard to diagnose bugs. This fixes it.

LGTM, thx !


fixed typo error

 Issue by hchoang
Thursday Aug 30, 2018 at 01:17 GMT
Originally opened as https://github.com/android/android-BluetoothLeGatt/pull/56

hchoang included the following code: https://github.com/android/android-BluetoothLeGatt/pull/56/commits

 Comment by googlebot
Thursday Aug 30, 2018 at 01:18 GMT

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

 Comment by hchoang
Thursday Aug 30, 2018 at 01:20 GMT

I signed it

 Comment by googlebot
Thursday Aug 30, 2018 at 01:20 GMT

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors.  If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)?  If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

 Comment by googlebot
Thursday Aug 30, 2018 at 01:23 GMT

CLAs look good, thanks!

 Comment by hchoang
Thursday Aug 30, 2018 at 01:23 GMT

I signed it


Adding license file.

I'm guessing the license file was missed in the move to 1.0.0. I bumped the year of the copyright, but otherwise according to the website the license is still MIT.

package.json agrees that it's MIT, thanks!

yes, license is always MIT


One system - multiple languages

Would it be possible to create one engine supporting multiple languages?
MMT offers the possibility to include various domains in one system. What if I use corpora in different languages and make MMT think it were different domains. Of course, I'd need to use the same language abbreviation as filename appendix so that MMT does think the corpora were simply different domains.

Nice idea. Never tried.
It may work if you have multiple source languages and one target language.
You may still have multiple domains per source language. The context
guesser will do the work.
Not sure how to do multiple target languages without changing the code a
little bit.
If you try this please let us know the results!
On Wed, 30 Nov 2016 at 08:54, Mehmed Sariyildiz<EMAIL_ADDRESS>wrote:

Would it be possible to create one engine supporting multiple languages?
MMT offers the possibility to include various domains in one system. What
if I use corpora in different languages and make MMT think it were
different corpora. Of course, I'd need to use the same language
abbreviation as filename appendix so that MMT does think the corpora were
simply different domains.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ModernMT/MMT/issues/198, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJcIE5sJB9ZW42MM1AEfMiazknw84NJSks5rDSvFgaJpZM4K_5tu
.

I'll try and keep you updated!