Docking Completed/Ship change event not working.

The docking completed/ship change events do not seem to be working. Invoking the VA command that posts an event to EDDI runs but the subsequent calling of the VA event handler for each of these events is not called.
As a workaround I've copied the event handler code to new commands and called those instead of the supplied VA command.

There is a known issue with VoiceAttack where it shuts down the event loop if you edit the profile.  Does this still happen when you start VoiceAttack fresh?
And just to confirm, you are saying "I have docked" or similar when the docking is complete?  The docking action is not automatic as there is nothing written to the netlog that we can use to know when docking has occurred.

I had found the edit/shutdown problem and this was not it. And to confirm, I was triggering the docking VA command with a keypress that I added to the 'I have docked' and 'ship changed' voice commands.
Since I reported this I have upgraded to the latest VA and noticed that docking and ship change events sometimes work. There can be a delay of up to 10 minutes before the expected response from the VA/EDDP combination so I have stopped using these two event command for the time being.
Most odd. It is quite disconcerting to be jumping to the next system and have VA report that there is nothing to be saved by swapping modules here instead of when the command was triggered!

I've heard of this problem from a few sources now.  I suspect that it's due to a timeout in one of the network requests, so I've added a 10-second timeout for all HTTP requests.
Does the problem happen at any particular times?  If you want to try the version with the timeouts you can pull it from http://www.mcdee.net/elite/EDDI-1.2.1d2.zip and see if it fixes the problem.

I've installed the new version from your link and I'll let you know how it goes this evening after I've had a chance to play Elite for an hour or two.

Okay, the update appears to be working in that the reposes to docked and handover now occur as expected however, the first time the docked command is triggered it reports the last station not the current station. Triggering the VA command again reports the correct station.
The handover command reports the last ship name and not the current ship name. Repeated triggering of the VA command does not affect this, it gets it wrong all the time. Shutting VA down and trying again seems to get the correct name.

I played Elite for a few hours last night and EDDI behaved perfectly. I had to uninstall and reinstall VA as it was corrupted by a ransomware trojan and after that everything worked as expected with v1.2.1d2.
Many thanks.


Using @JsonUnwrapped with @Schema(implementation = Something) does not unwrap

Hi, I have an object like
public record Car(String model, @JsonUnwrapped @Schema(implementation=ResourcePath.class) Resource resource, boolean selected) {
}

public abstract class Resource {
}

public abstract class ResourcePath extend Resource {

  public String resourcePath;

  public String resourceType;

}

Resource is an abstract class, and does not contain all the fields present in ResourcePath. However, Jackson picks up all the fields and still unwrap them with @JsonUnwrapped.
The moment I specify an implementation in @Schema, resource stop being unwrapped in the openapi.yaml.


Undeprecate concat operator as concatWith

While the use cases for the merge, zip, and combineLatest operators, et al, remain dubious, I've several times seen cases where the concat operator might be preferred to the concat static method.
Most of these use cases are around animations or action dispatching with redux-observable or ngrx.
It could be used to compose endWith.
The name concatWith has some precedent. I believe it's used in RxJava.

This is done #4988


As a user I want to be able to include another language type to be analyzed in my settings

I use asciidoc over markdown for my documentation. I'd like an override option that allows me to designate this other file format as able to be parsed for grammar. Not sure of the architecture, so figured I'd ask, as I wasn't able to get anything working by trying this in the diagnostics.

Added asciidoc


KAFKA-9980: Reserved word "" may not be santinized to "%3Cdefault%3E"

One-line change. Please refer to the Jira ticket. Straight forward.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

This one was fixed by https://github.com/apache/kafka/pull/8658. It can be closed.

closed


"Oh no! Failed to commit changes from remix.init script."

I keep getting this error during installation:
"Oh no! Failed to commit changes from remix.init script."
I'm on Windows 11, using Node.js 18.18.2 and NPM 10.2.0.  Not sure why it failed to commit changes from the remix.init script.

Hi @RangerCoder99!
Yeah, I've reproduced this myself. I think this may be an issue in the Remix CLI, but I haven't had time to investigate.
For now, the workaround is simple. All you're missing out on is Remix doing this for you:
git init
git add .
git commit -am 'initial commit'

I'm not sure what's up with the Remix CLI, but now I've got npx create-epic-app@latest which will call into the Remix CLI and disables the git init step so this won't be a problem (git init must be done manually now)


Ownership transfer for records

Fixes https://github.com/vinyldns/vinyldns/issues/1218.
Changes in this pull request:
Added ownership transfer validation in API and Portal
List of Validations added: (Specific to shared zone)
User can claim their own group for the unowned record by their own. Group will be Auto-assigned to the record, once user requested.
User can request their own group for the record already assigned. Once requested, the request will be send to the existing assigned group members(Approvers). The request will be notified in email.
Approver can Approve/Reject the request.

If the Approver approved the request, the requested group will be assign to the particular record.
If the Approver rejected the request, the existing group assigned will be remains same.
Steps to test:

Create 2 user. Professor, fry.
Create 2 groups for each members.
Create a shared zone.
Now switch the use and try to give request and approve.(consider one as requester and one as approver.)
Not included in this PR:
Ownership transfer history and filter records with ownership transfer status will be complete in separate PR.

SInce faced unsigned issue in the PR commit. Opened this as a new one and closing the existing PR.

Tested with the latest code, all my previous comments have been resolved. I found one more bug:
When I go to close an ownership transfer request, the Record Owner Group Status box is blank, and I am able to submit the request without choosing anything.

@nspadaccino Fixed the issue.

Two things I found when testing:

It looks like the Type and TTL columns don't have enough space

This error message should be changed to "Transfer status is required" or something similar
Otherwise all the functionality looks good


test

User description
/describe

Type
enhancement

Description

Improved code readability by adding a newline in the main method of GithubCiCdApplication.java.

Changes walkthrough
Relevant filesFormatting

GithubCiCdApplication.javaImproved Readability in Main Method

src/main/java/fr/benseddik/planning/GithubCiCdApplication.java

Added a newline in the main method for better readability.

+1/-0

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

PR Description updated to latest commit (https://github.com/Benseddik-Fethi/Github-CI-CD/commit/9435afda4d2986b8aed91006e1672665c4ab41e5)

PR Review

 ⏱ Estimated effort to review [1-5]
1, because the PR consists of a single, straightforward change which is the addition of a newline for improved readability. There's no complex logic or multiple files involved.

 🧪 Relevant tests
No

 🔍 Possible issues
No

 🔒 Security concerns
No

 Code feedback:

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


Parameter is of type {double}, setting it to {string} is not allowed

Environment

ROS Distro: Galactic (Binary via Debian Packages)
OS Version: Ubuntu 20.04
Branch: 'main'
Driver.repos: tried 'released' and 'not-released' (is 'released' the right one for me?)

Description
I'm very new to ROS and Github, so please feel free to correct me, if there is something unusual here.
After following the steps in Getting Started and the moveit examples:
ros2 launch ur_bringup ur_control.launch.py ur_type:=ur5e robot_ip:=yyy.yyy.yyy.yyy use_fake_hardware:=true launch_rviz:=false

ros2 launch ur_bringup ur_moveit.launch.py ur_type:=ur5e robot_ip:="xxx.xxx" use_fake_hardware:=true launch_rviz:=true

the same Error as in #265 and #268 occurs. Then I have merged #268 by editing the launch files (also tried the 'small-launch-file-fixes' branch). With that the robot-model shows up in RViz, but the interactive-markers are missing. (see RViz)

 RViz

I think this Error is related to a warning in the console output from ur_moveit_launch.py
[WARN] [moveit_ros.robot_model_loader]: No kinematics plugins defined. Fill and load kinematics.yaml!

This message also appears in the 'main' branch (without #268).
Maybe the namespace collision is also a problem?
SEVERE WARNING!!! A namespace collision has occured with plugin factory for class rviz_default_plugins::displays::InteractiveMarkerDisplay.

For more details here is the full console output

 console output: ur_moveit_launch.py
1641497059.3043668 [INFO] [launch]: All log files can be found below /home/tony/.ros/log/2022-01-06-20-24-19-299322-antopius-102316
1641497059.3046501 [INFO] [launch]: Default logging verbosity is set to INFO
1641497060.9627249 [INFO] [move_group-1]: process started with pid [102324]
1641497060.9632144 [INFO] [mongo_wrapper_ros.py-2]: process started with pid [102326]
1641497060.9636350 [INFO] [rviz2-3]: process started with pid [102328]
1641497060.9638207 [INFO] [static_transform_publisher-4]: process started with pid [102330]
1641497060.9639544 [INFO] [servo_node_main-5]: process started with pid [102332]
1641497060.9931874 [static_transform_publisher-4] [INFO] [1641497060.992752781] [static_transform_publisher]: Spinning until killed publishing transform from 'world' to 'base_link'
1641497061.4333007 [rviz2-3] [INFO] [1641497061.432959786] [rviz2]: Stereo is NOT SUPPORTED
1641497061.4336653 [rviz2-3] [INFO] [1641497061.433056782] [rviz2]: OpenGl version: 4.6 (GLSL 4.6)
1641497061.4585600 [rviz2-3] [INFO] [1641497061.458234808] [rviz2]: Stereo is NOT SUPPORTED
1641497061.6414342 [rviz2-3] Warning: class_loader.impl: SEVERE WARNING!!! A namespace collision has occured with plugin factory for class rviz_default_plugins::displays::InteractiveMarkerDisplay. New factory will OVERWRITE existing one. This situation occurs when libraries containing plugins are directly linked against an executable (the one running right now generating this message). Please separate plugins out into their own library or just don't link against the library and use either class_loader::ClassLoader/MultiLibraryClassLoader to open.
1641497061.6416452 [rviz2-3]          at line 253 in /opt/ros/galactic/include/class_loader/class_loader_core.hpp
1641497064.6672881 [rviz2-3] [ERROR] [1641497064.666863011] [moveit_ros_visualization.motion_planning_frame]: Action server: /recognize_objects not available
1641497064.7546139 [rviz2-3] [INFO] [1641497064.754259727] [moveit_rdf_loader.rdf_loader]: Loaded robot model in 0.00643986 seconds
1641497064.7550166 [rviz2-3] [INFO] [1641497064.754351377] [moveit_robot_model.robot_model]: Loading robot model 'ur'...
1641497064.7800896 [rviz2-3] [WARN] [1641497064.779761664] [moveit_ros.robot_model_loader]: No kinematics plugins defined. Fill and load kinematics.yaml!
1641497064.8443103 [rviz2-3] [INFO] [1641497064.843868459] [moveit_ros.planning_scene_monitor.planning_scene_monitor]: Starting planning scene monitor
1641497064.8462896 [rviz2-3] [INFO] [1641497064.845966941] [moveit_ros.planning_scene_monitor.planning_scene_monitor]: Listening to '/monitored_planning_scene'
1641497065.9465888 [rviz2-3] [INFO] [1641497065.946274839] [interactive_marker_display_94451179729456]: Connected on namespace: /rviz_moveit_motion_planning_display/robot_interaction_interactive_marker_topic
1641497065.9497626 [rviz2-3] Link base had 0 children
1641497065.9500604 [rviz2-3] Link base_link_inertia had 1 children
1641497065.9501479 [rviz2-3] Link shoulder_link had 1 children
1641497065.9502277 [rviz2-3] Link upper_arm_link had 1 children
1641497065.9503055 [rviz2-3] Link forearm_link had 1 children
1641497065.9503813 [rviz2-3] Link wrist_1_link had 1 children
1641497065.9504697 [rviz2-3] Link wrist_2_link had 1 children
1641497065.9505465 [rviz2-3] Link wrist_3_link had 1 children
1641497065.9506197 [rviz2-3] Link flange had 1 children
1641497065.9506993 [rviz2-3] Link tool0 had 0 children
1641497065.9507792 [rviz2-3] [INFO] [1641497065.949876397] [moveit_ros_robot_interaction.robot_interaction]: No active joints or end effectors found for group 'ur_manipulator'. Make sure that kinematics.yaml is loaded in this node's namespace.
1641497065.9546919 [rviz2-3] [INFO] [1641497065.954342948] [moveit_ros_visualization.motion_planning_frame]: group ur_manipulator
1641497065.9548664 [rviz2-3] [INFO] [1641497065.954375074] [moveit_ros_visualization.motion_planning_frame]: Constructing new MoveGroup connection for group 'ur_manipulator' in namespace ''
1641497065.9552250 [rviz2-3] [WARN] [1641497065.954613116] [rcl.logging_rosout]: Publisher already registered for provided node name. If this is due to multiple nodes with the same name then all logs for that logger name will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.
1641497065.9628930 [rviz2-3] [INFO] [1641497065.962348917] [interactive_marker_display_94451179729456]: Sending request for interactive markers
1641497065.9739711 [rviz2-3] [INFO] [1641497065.973636885] [move_group_interface]: Ready to take commands for planning group ur_manipulator.
1641497065.9968441 [rviz2-3] [INFO] [1641497065.996374029] [interactive_marker_display_94451179729456]: Service response received for initialization
1641497152.2435403 [rviz2-3] [INFO] [1641497152.243021886] [move_group_interface]: MoveGroup action client/server ready
1641497152.6457138 [rviz2-3] [INFO] [1641497152.645300900] [move_group_interface]: Planning request accepted
1641497152.7464201 [rviz2-3] [INFO] [1641497152.745971212] [move_group_interface]: Planning request complete!
1641497152.8466475 [rviz2-3] [INFO] [1641497152.846266419] [move_group_interface]: time taken to generate plan: 0,0286106 seconds
1641497155.1414828 [rviz2-3] [INFO] [1641497155.141189486] [move_group_interface]: Execute request accepted
1641497165.9697840 [rviz2-3] [INFO] [1641497165.969468872] [move_group_interface]: Execute request success!

 console output: ur_controller_launch.py
1641496964.9396663 [INFO] [launch]: All log files can be found below /home/tony/.ros/log/2022-01-06-20-22-44-933595-antopius-102043
1641496964.9399381 [INFO] [launch]: Default logging verbosity is set to INFO
1641496966.2505610 [INFO] [dashboard_client-2]: process started with pid [102049]
1641496966.2522800 [INFO] [ros2_control_node-1]: process started with pid [102047]
1641496966.2526379 [INFO] [robot_state_publisher-3]: process started with pid [102051]
1641496966.2528369 [INFO] [spawner-4]: process started with pid [102053]
1641496966.2530296 [INFO] [spawner-5]: process started with pid [102055]
1641496966.2532623 [INFO] [spawner-6]: process started with pid [102057]
1641496966.2534552 [INFO] [spawner-7]: process started with pid [102059]
1641496966.2536294 [INFO] [spawner.py-8]: process started with pid [102061]
1641496966.2537925 [INFO] [spawner-9]: process started with pid [102090]
1641496966.2560449 [robot_state_publisher-3] Link base had 0 children
1641496966.2562497 [robot_state_publisher-3] Link base_link_inertia had 1 children
1641496966.2563889 [robot_state_publisher-3] Link shoulder_link had 1 children
1641496966.2565260 [robot_state_publisher-3] Link upper_arm_link had 1 children
1641496966.2566626 [robot_state_publisher-3] Link forearm_link had 1 children
1641496966.2567942 [robot_state_publisher-3] Link wrist_1_link had 1 children
1641496966.2569268 [robot_state_publisher-3] Link wrist_2_link had 1 children
1641496966.2570567 [robot_state_publisher-3] Link wrist_3_link had 1 children
1641496966.2571888 [robot_state_publisher-3] Link flange had 1 children
1641496966.2573202 [robot_state_publisher-3] Link tool0 had 0 children
1641496966.2575409 [robot_state_publisher-3] [INFO] [1641496966.241586575] [robot_state_publisher]: got segment base
1641496966.2576609 [robot_state_publisher-3] [INFO] [1641496966.241709041] [robot_state_publisher]: got segment base_link
1641496966.2577770 [robot_state_publisher-3] [INFO] [1641496966.241734387] [robot_state_publisher]: got segment base_link_inertia
1641496966.2578933 [robot_state_publisher-3] [INFO] [1641496966.241755693] [robot_state_publisher]: got segment flange
1641496966.2580094 [robot_state_publisher-3] [INFO] [1641496966.241776057] [robot_state_publisher]: got segment forearm_link
1641496966.2581248 [robot_state_publisher-3] [INFO] [1641496966.241796132] [robot_state_publisher]: got segment shoulder_link
1641496966.2582366 [robot_state_publisher-3] [INFO] [1641496966.241816019] [robot_state_publisher]: got segment tool0
1641496966.2583487 [robot_state_publisher-3] [INFO] [1641496966.241835951] [robot_state_publisher]: got segment upper_arm_link
1641496966.2586873 [robot_state_publisher-3] [INFO] [1641496966.241856425] [robot_state_publisher]: got segment wrist_1_link
1641496966.2588236 [robot_state_publisher-3] [INFO] [1641496966.241875886] [robot_state_publisher]: got segment wrist_2_link
1641496966.2589402 [robot_state_publisher-3] [INFO] [1641496966.241895522] [robot_state_publisher]: got segment wrist_3_link
1641496968.8013673 [spawner-5] [INFO] [1641496968.801014293] [spawner_io_and_status_controller]: Loaded io_and_status_controller
1641496968.8193777 [spawner-4] [INFO] [1641496968.819093075] [spawner_joint_state_broadcaster]: Loaded joint_state_broadcaster
1641496968.8259437 [spawner-5] [INFO] [1641496968.824388669] [spawner_io_and_status_controller]: Configured and started io_and_status_controller
1641496968.8731582 [spawner-6] [INFO] [1641496968.872799921] [spawner_speed_scaling_state_broadcaster]: Loaded speed_scaling_state_broadcaster
1641496968.8746965 [spawner.py-8] [INFO] [1641496968.873418299] [spawner_forward_position_controller]: Loaded forward_position_controller
1641496968.8794971 [spawner-9] [INFO] [1641496968.879287389] [spawner_joint_trajectory_controller]: Loaded joint_trajectory_controller
1641496968.8888462 [spawner-7] [INFO] [1641496968.888534554] [spawner_force_torque_sensor_broadcaster]: Loaded force_torque_sensor_broadcaster
1641496968.8972573 [spawner-4] [INFO] [1641496968.896139981] [spawner_joint_state_broadcaster]: Configured and started joint_state_broadcaster
1641496968.9285071 [spawner-6] [INFO] [1641496968.928199489] [spawner_speed_scaling_state_broadcaster]: Configured and started speed_scaling_state_broadcaster
1641496968.9483364 [spawner-7] [INFO] [1641496968.948009787] [spawner_force_torque_sensor_broadcaster]: Configured and started force_torque_sensor_broadcaster
1641496968.9691079 [spawner-9] [INFO] [1641496968.968791251] [spawner_joint_trajectory_controller]: Configured and started joint_trajectory_controller
1641496968.9837098 [INFO] [spawner-5]: process has finished cleanly [pid 102055]
1641496969.0324657 [spawner.py-8] /home/tony/workspace2/ros_ur_driver/install/controller_manager/lib/controller_manager/spawner.py:204: DeprecationWarning: 'spawner.py' is deprecated, please use 'spawner' (without .py extension)
1641496969.0326426 [spawner.py-8]   warnings.warn(
1641496969.0470595 [INFO] [spawner.py-8]: process has finished cleanly [pid 102061]
1641496969.1052749 [INFO] [spawner-4]: process has finished cleanly [pid 102053]
1641496969.1531901 [INFO] [spawner-6]: process has finished cleanly [pid 102057]
1641496969.1586440 [INFO] [spawner-7]: process has finished cleanly [pid 102059]
1641496969.1642439 [INFO] [spawner-9]: process has finished cleanly [pid 102090]

Does anyone have the same problem or have i messed up something here?
I would appreciate any help!
EDIT
I noticed that the kinematics plugin is loaded under the main branch when 'kinematics_solver_search_resolution' and 'kinematics_solver_timeout' are commented out in kinematics.yaml.
I haven't figured out how to set them properly yet, but the 'interactive markers' appear and the inverse kinematics seem to work now. (probably with default values)
It also seems to work, if i simply set 'kinematics_solver_search_resolution' and 'kinematics_solver_timeout' with a comma instead of a dot in kinematics.yaml.. Maybe because of an incorrect UTF-8 format on my part? (de_DE.UTF-8)
But I think that would affect other things as well.
Solution
locale LC_NUMERIC must be set to en_US.UTF-8
sudo locale-gen en_US en_US.UTF-8
sudo update-locale LC_NUMERIC=en_US.UTF-8
#reboot

@antopius is this still an issue or is this closed?

@destogl
It's closed for me as my solution works. But this is maybe more like a workaround.
I edited the title to the more related error message.
I expect that #265 is the same issue and my solution also works for @NebuDa.
This occurs also in the moveit2 Tutorial and only on Galactic, so could be something to do with the moveit Galactic branch.


Target ES6

This is a work-in-progress. I'm sharing in case others are interested or have feedback. This branch creates a new option --target-es6 that tells the compiler to emit ES6 when possible.
Since many ES6 features are closely aligned with CoffeeScript, we can actually do less and emit smaller, simpler code that takes advantage of native implementations.
Why would you want this?

because you're targeting an environment with native ES6 support
because you want to convert an existing CoffeeScript codebase to JS without all the noise introduced by missing ES6 features.

Here's an example of what it can already do:
$ cat sample.coffee
handleAllThings = (things...) ->
  myThings.map (thing) => this.handle(thing)

$ ./bin/coffee --bare --js --input sample.coffee --target-es6
// Generated by CoffeeScript 2.0.0-beta9-dev
var handleAllThings;
handleAllThings = function (...things) {
  return myThings.map(thing => this.handle(thing));
};

For comparison, without --target-es6 we get a lot more code:
$ ./bin/coffee --bare --js --input sample.coffee
// Generated by CoffeeScript 2.0.0-beta9-dev
var handleAllThings;
handleAllThings = function () {
  var things;
  things = arguments.length > 0 ? [].slice.call(arguments, 0) : [];
  return myThings.map(function (this$) {
    return function (thing) {
      return this$.handle(thing);
    };
  }(this));
};

Possible next steps:

[ ] default params
[ ] class
[ ] array destructuring
[ ] object destructuring

:heart:

Fantastic! I'm especially interested in the default parameters.

@srb- default params are working now, for both ArrowExpressions and FunctionExpresion:
$ cat sample.coffee
class Foo extends Bar
  doIt: (a=1, b=2, c...)->
    super("yay", a, b, c)

demo = (a, b=2, c...) => a + b + c.length

$ ./bin/coffee --bare --js --input ./sample.coffee --target-es6
// Generated by CoffeeScript 2.0.0-beta9-dev-es6
var demo;
class Foo extends Bar {
  doIt(a = 1, b = 2, ...c) {
    return super.doIt('yay', a, b, c);
  }
}
demo = (a, b = 2, ...c) => a + b + c.length;

Very cool! Question: do you actually use this compiler in production? I was under the impression it's in a semi-abandoned state so I've been afraid to use it for real projects.

I haven't yet, but I'm planning to use it to help me port a significant production codebase from coffeescript to ES6. This is admittedly a lower bar than getting it working as an ongoing production compiler -- I can supervise the process more closely.
Overall I have been happy with the parser -- it is more conservative than the one in original coffeescript, and it forced me to disambiguate a bunch of dubious code. And some of the roughest features (like super, which exists only in a PR) are things that I've already replaced with much simpler ES6 versions.
So for my use case it works, but I can understand the hesitation. You definitely have to be willing to debug the compiler to use it at this point.

I like this PR a lot. I am willing to merge it in. @ef4: Can you rebase?

Sure, happy to rebase in anticipation of merge, as soon as I have the test suite stabilized.

Wow, I wish I'd seen this sooner. I've been working on decaffeinate which has a pretty similar goal. Did I understand you correctly, @ef4, that you're trying to move a codebase from CoffeeScript to ES6? If so, we might want to see if there's any work we can do together as that's my goal.
The main reason I didn't go with the approach in this PR is that I'd lose comments and formatting.

I have a separate tool for safely porting the comments across, using source
mapping as a guide. I should get around to publishing it.
This PR is still definitely a work in progress. It's usable to if you're
doing one file at a time and supervising it, but it definitely has holes.
On Aug 26, 2015 8:13 PM, "Brian Donovan"<EMAIL_ADDRESS>wrote:

Wow, I wish I'd seen this sooner. I've been working on decaffeinate
https://github.com/eventualbuddha/decaffeinate which has a pretty
similar goal. Did I understand you correctly, @ef4
https://github.com/ef4, that you're trying to move a codebase from
CoffeeScript to ES6? If so, we might want to see if there's any work we can
do together as that's my goal.
The main reason I didn't go with the approach in this PR is that I'd lose
comments and formatting.
—
Reply to this email directly or view it on GitHub
https://github.com/michaelficarra/CoffeeScriptRedux/pull/344#issuecomment-135214201
.

great works. but
This branch has conflicts that must be resolved

@ef4 what's the status of this project?

I had to shift focus to other things, anyone is welcome to take it and run with it.
The status is the same as my last comment: it's already useful as an assistant if you're hand-porting code from coffeescript to ES2015. I wouldn't trust it to transpile a whole codebase.

Awesome, thanks @ef4 !
Do you think you'd be willing to provide advice from time to time if someone were to pick it up?

Sure.


#259: Added Alt tags for SEO Enchancment

This PR resolves this issue

@jeremyphilemon  please review and merge it

Please change all urls to https://www.covid19india.org/

https://www.covid19india.org/

Done @JunaidBabu, please check.

I had already made a PR for this with accessibility fixes included - #153 (which I myself asked to close) and #267


Uncaught TypeError: character.onWalkingStart is not a function

After finishing the initial dialogue with Oak, your character is unable to move once in his room. This error showed up in the console when trying to.

Resolved in b48307fffb8b18dad304160a853fe535547b9a13.


Random disconnect Paper 1.11.2 1.12 pre5

What is the output link of /viaversion dump?
https://gist.github.com/anonymous/91ed07a1c35edecfcccd5d12d7018930
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
https://ci.md-5.net/job/BungeeCord/1234/
Plugins: SkinsRestorer-v13.0.2, BungeeAuthMeBridge-1.6.2, AddressLimit
How does this error happen? login? Using an item?
Random
Is there an error in the console? Use pastebin.com. Is there a kick message?
[14:29:34] [Server thread/INFO]: andris155 lost connection: Disconnected

Could you try without SkinRestorer on your Bungee?

Could you try with the new build?
https://ci.viaversion.com/job/ViaVersion-DEV/
I suspect it was that issue.

Closing as I suspect it was the issue in the previous comment.


am having this issue

self.username = self.rapi.user.me().name
AttributeError: 'NoneType' object has no attribute 'name'
what to do

You need to put your credentials in the bot

You need to put your credentials in the bot

I ran sudo ./run_linux.sh menu    , and the bot executes,  i edited the config.... and saved it , after i click the start button , this is the ouput :-
$ sudo ./run_linux.sh menu
04/01/2021 22:32:55
system is Linux
trying to run the bot
running with menu
info loggin
22:32:59 config root: /home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/config
22:32:59 repo root: /home/vikingstudiosz/Desktop/reddit-karma-farming-bot
22:32:59 src root: /home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src
22:32:59 REDDIT AUTH CONFIG:
{
"reddit_client_id": "",
"reddit_client_secret": "",
"reddit_password": "",
"reddit_username": ""
}
22:32:59 REDDIT CONNFIG:
{
"reddit_comment_chance": 0.005,
"reddit_low_score_threshold": 0,
"reddit_post_chance": 0.005,
"reddit_remove_low_scores": 0.002,
"reddit_reply_to_comment": 0.002,
"reddit_shadowban_check": 0.002,
"reddit_sleep_schedule": [
2,
4
],
"reddit_sub_list": []
}
22:33:14 COBE CONFIG:
{
"cobe_base_dir": "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/actions/comments",
"cobe_db_dir": "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/actions/comments/brains",
"cobe_main_db": "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/actions/comments/brains/brain.db",
"cobe_max_db_size": "300mb",
"cobe_min_db_size": "50mb"
}
22:33:14 using schedules: [((10, 0), (14, 0)), ((18, 0), (22, 0))]
Traceback (most recent call last):
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/./src/menu.py", line 52, in
run()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/./src/menu.py", line 49, in run
ui.main()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 970, in main
self._ui.run_wrapper( self.run )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/display_common.py", line 834, in run_wrapper
return fn()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 987, in run
self.loop()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1033, in loop
self._doKeyPress(focused, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 465, in _doKeyPress
self._doKeyPress(None, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 481, in _doKeyPress
topwidget.keypress(self._currentSize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1135, in keypress
return self.body.keypress( (maxcol, remaining), key )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/listbox.py", line 968, in keypress
key = focus_widget.keypress((maxcol,),key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 410, in keypress
key = self.__super.keypress(size, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/decoration.py", line 622, in keypress
return self._original_widget.keypress(maxvals, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 2316, in keypress
key = w.keypress((mc,) + size[1:], key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/wimp.py", line 543, in keypress
self._emit('click')
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/widget.py", line 461, in _emit
signals.emit_signal(self, name, self, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 265, in emit
result |= self._call_callback(callback, user_arg, user_args, args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 295, in _call_callback
return bool(callback(*args_to_pass))
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 419, in _doPress
self._handle(event_name, button, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 381, in _handle
return handler.respond(event_name, widget, *args, **kwargs)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1214, in respond
return responder(*args, **kwargs) != FORWARD
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/./src/menu.py", line 34, in onConfig
config_menu.run()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/config/config_menu.py", line 68, in run
ui.main()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 970, in main
self._ui.run_wrapper( self.run )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/display_common.py", line 834, in run_wrapper
return fn()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 987, in run
self.loop()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1033, in loop
self._doKeyPress(focused, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 465, in _doKeyPress
self._doKeyPress(None, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 481, in _doKeyPress
topwidget.keypress(self._currentSize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1135, in keypress
return self.body.keypress( (maxcol, remaining), key )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/listbox.py", line 968, in keypress
key = focus_widget.keypress((maxcol,),key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 410, in keypress
key = self.__super.keypress(size, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/decoration.py", line 622, in keypress
return self._original_widget.keypress(maxvals, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 2316, in keypress
key = w.keypress((mc,) + size[1:], key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/wimp.py", line 543, in keypress
self._emit('click')
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/widget.py", line 461, in _emit
signals.emit_signal(self, name, self, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 265, in emit
result |= self._call_callback(callback, user_arg, user_args, args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 295, in _call_callback
return bool(callback(*args_to_pass))
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 419, in _doPress
self._handle(event_name, button, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 381, in _handle
return handler.respond(event_name, widget, *args, **kwargs)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1214, in respond
return responder(*args, **kwargs) != FORWARD
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/config/config_menu.py", line 56, in onSave
menu.run()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/menu.py", line 49, in run
ui.main()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 970, in main
self._ui.run_wrapper( self.run )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/display_common.py", line 834, in run_wrapper
return fn()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 987, in run
self.loop()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1033, in loop
self._doKeyPress(focused, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 465, in _doKeyPress
self._doKeyPress(None, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 481, in _doKeyPress
topwidget.keypress(self._currentSize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1135, in keypress
return self.body.keypress( (maxcol, remaining), key )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/listbox.py", line 968, in keypress
key = focus_widget.keypress((maxcol,),key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 410, in keypress
key = self.__super.keypress(size, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/decoration.py", line 622, in keypress
return self._original_widget.keypress(maxvals, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 2316, in keypress
key = w.keypress((mc,) + size[1:], key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/wimp.py", line 543, in keypress
self._emit('click')
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/widget.py", line 461, in _emit
signals.emit_signal(self, name, self, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 265, in emit
result |= self._call_callback(callback, user_arg, user_args, args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 295, in _call_callback
return bool(callback(*args_to_pass))
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 419, in _doPress
self._handle(event_name, button, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 381, in _handle
return handler.respond(event_name, widget, *args, **kwargs)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1214, in respond
return responder(*args, **kwargs) != FORWARD
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/menu.py", line 29, in onStarted
bot.run()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bot.py", line 6, in run
reddit = RedditBot()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/bot.py", line 21, in init
self.cleanup = Cleanup()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/actions/cleanup_actions.py", line 12, in init
self.username = self.rapi.user.me().name
AttributeError: 'NoneType' object has no attribute 'name'
What should i do abt it?

I ran sudo ./run_linux.sh menu    , and the bot executes,  i edited the config.... and saved it , after i click the start button , this is the ouput :-
$ sudo ./run_linux.sh menu
04/01/2021 22:32:55
system is Linux
trying to run the bot
running with menu
info loggin
22:32:59 config root: /home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/config
22:32:59 repo root: /home/vikingstudiosz/Desktop/reddit-karma-farming-bot
22:32:59 src root: /home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src
22:32:59 REDDIT AUTH CONFIG:
{
"reddit_client_id": "",
"reddit_client_secret": "",
"reddit_password": "",
"reddit_username": ""
}
22:32:59 REDDIT CONNFIG:
{
"reddit_comment_chance": 0.005,
"reddit_low_score_threshold": 0,
"reddit_post_chance": 0.005,
"reddit_remove_low_scores": 0.002,
"reddit_reply_to_comment": 0.002,
"reddit_shadowban_check": 0.002,
"reddit_sleep_schedule": [
2,
4
],
"reddit_sub_list": []
}
22:33:14 COBE CONFIG:
{
"cobe_base_dir": "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/actions/comments",
"cobe_db_dir": "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/actions/comments/brains",
"cobe_main_db": "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/actions/comments/brains/brain.db",
"cobe_max_db_size": "300mb",
"cobe_min_db_size": "50mb"
}
22:33:14 using schedules: [((10, 0), (14, 0)), ((18, 0), (22, 0))]
Traceback (most recent call last):
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/./src/menu.py", line 52, in
run()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/./src/menu.py", line 49, in run
ui.main()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 970, in main
self._ui.run_wrapper( self.run )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/display_common.py", line 834, in run_wrapper
return fn()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 987, in run
self.loop()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1033, in loop
self._doKeyPress(focused, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 465, in _doKeyPress
self._doKeyPress(None, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 481, in _doKeyPress
topwidget.keypress(self._currentSize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1135, in keypress
return self.body.keypress( (maxcol, remaining), key )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/listbox.py", line 968, in keypress
key = focus_widget.keypress((maxcol,),key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 410, in keypress
key = self.__super.keypress(size, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/decoration.py", line 622, in keypress
return self._original_widget.keypress(maxvals, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 2316, in keypress
key = w.keypress((mc,) + size[1:], key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/wimp.py", line 543, in keypress
self._emit('click')
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/widget.py", line 461, in _emit
signals.emit_signal(self, name, self, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 265, in emit
result |= self._call_callback(callback, user_arg, user_args, args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 295, in _call_callback
return bool(callback(*args_to_pass))
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 419, in _doPress
self._handle(event_name, button, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 381, in _handle
return handler.respond(event_name, widget, *args, **kwargs)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1214, in respond
return responder(*args, **kwargs) != FORWARD
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/./src/menu.py", line 34, in onConfig
config_menu.run()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/config/config_menu.py", line 68, in run
ui.main()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 970, in main
self._ui.run_wrapper( self.run )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/display_common.py", line 834, in run_wrapper
return fn()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 987, in run
self.loop()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1033, in loop
self._doKeyPress(focused, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 465, in _doKeyPress
self._doKeyPress(None, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 481, in _doKeyPress
topwidget.keypress(self._currentSize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1135, in keypress
return self.body.keypress( (maxcol, remaining), key )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/listbox.py", line 968, in keypress
key = focus_widget.keypress((maxcol,),key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 410, in keypress
key = self.__super.keypress(size, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/decoration.py", line 622, in keypress
return self._original_widget.keypress(maxvals, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 2316, in keypress
key = w.keypress((mc,) + size[1:], key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/wimp.py", line 543, in keypress
self._emit('click')
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/widget.py", line 461, in _emit
signals.emit_signal(self, name, self, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 265, in emit
result |= self._call_callback(callback, user_arg, user_args, args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 295, in _call_callback
return bool(callback(*args_to_pass))
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 419, in _doPress
self._handle(event_name, button, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 381, in _handle
return handler.respond(event_name, widget, *args, **kwargs)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1214, in respond
return responder(*args, **kwargs) != FORWARD
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/config/config_menu.py", line 56, in onSave
menu.run()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/menu.py", line 49, in run
ui.main()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 970, in main
self._ui.run_wrapper( self.run )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/display_common.py", line 834, in run_wrapper
return fn()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 987, in run
self.loop()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1033, in loop
self._doKeyPress(focused, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 465, in _doKeyPress
self._doKeyPress(None, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 481, in _doKeyPress
topwidget.keypress(self._currentSize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1135, in keypress
return self.body.keypress( (maxcol, remaining), key )
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/listbox.py", line 968, in keypress
key = focus_widget.keypress((maxcol,),key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 410, in keypress
key = self.__super.keypress(size, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 1626, in keypress
key = self.focus.keypress(tsize, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/decoration.py", line 622, in keypress
return self._original_widget.keypress(maxvals, key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/container.py", line 2316, in keypress
key = w.keypress((mc,) + size[1:], key)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/wimp.py", line 543, in keypress
self._emit('click')
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/widget.py", line 461, in _emit
signals.emit_signal(self, name, self, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 265, in emit
result |= self._call_callback(callback, user_arg, user_args, args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/urwid/signals.py", line 295, in _call_callback
return bool(callback(*args_to_pass))
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 419, in _doPress
self._handle(event_name, button, *args)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 381, in _handle
return handler.respond(event_name, widget, *args, **kwargs)
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/libs/urwide.py", line 1214, in respond
return responder(*args, **kwargs) != FORWARD
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/menu.py", line 29, in onStarted
bot.run()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bot.py", line 6, in run
reddit = RedditBot()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/bot.py", line 21, in init
self.cleanup = Cleanup()
File "/home/vikingstudiosz/Desktop/reddit-karma-farming-bot/src/bots/reddit/actions/cleanup_actions.py", line 12, in init
self.username = self.rapi.user.me().name
AttributeError: 'NoneType' object has no attribute 'name'
What should i do abt it?

you're using an older version. use the latest version. and then check your credentials.

you're using an older version. use the latest version. and then check your credentials.


[release-1.18] Update min supported k8s version to 1.24

This is an automated cherry-pick of #45275

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_release-1.18
0a99a1025fae612624c72d24f5471b6751a714b6
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Import settings for figure

For different kind of importing and converting figures, I want to have an option to reimport them with specific settings kept in meta file and editable on inspector.

#62


Refactor deprecated location code

Description
Since the location parameter was deprecated, I passed it to the uri parameter.
Related Issues
fix #145
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes tests for all changed/updated/fixed behaviors.
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

@AcarFurkan Thanks for the contribution!
can you please fix the flutter analyze?

Yes, you are right, the uri is not available in Flutter 3.7.2, so I am closing this PR.


Correct error in csintro3 math

Corrects #1127.

Interesting.... I wasn't expecting GitHub to pull all of the commit activity in my fork like that. Let me know if you want me to create a new commit with a clean fork.

You don't need to create a whole new fork, you can create a new branch in your existing fork!
Try this out:
# Create a new branch for the PR that is based off of master
git checkout upstream/master -b fix_csintro

# Copy the fix you made over to your new branch
git cherry-pick 842123c

# Push that branch up to Github
git push -u origin fix_csintro

Then create a new PR with the branch you just created.
Hope that helps!

Thanks, @riknoll! I'll close this PR and open a new one with your suggestions.
I'm still getting used to git. 😄


Low Performance and wrong charactor choised for Ability check

Once installed and played on multiplay with friends, we have the issue that the performance drops dramaticly, checked the task manager, it seems that the mod causes the game not to use all GPU and CPU resources.
Second issue is that when used on an existing save game, the mod causes the game to choose wrong charactor for ability check rolls, like my main charactor which is a mage with +13 on history and my friend uses a clecric with only 2 history. For a history ability check, his charactor was choosed to perform the check, which of course results in a failed attempt.

None of these are caused by the mod. Please check tons of discussions online what you can do to avoid this.


fix: e2e tests

I think there's a bug in https://github.com/jbrunton/gha-installer, which probably needs to implement paging for when there are a lot of releases being returned by the GitHub API. In the meantime, this PR fixes the e2e tests in the build workflow for this action by using a more recent version in the test.

Fixed in #300


How to get marketcap of many tickers? when i get that ,error is as follows

HTTPSConnectionPool(host='finance.yahoo.com', port=443): Max retries exceeded with url: /quote/A/financials (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x00000134E53E6700>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed'))

this looks like you've tried to access the API too many times recently. Stop hitting the API for a little bit then try again.

Duplicate of #742


refactor: Change the return type of Observable.add

observable.add(callback: (eventData: T, eventState: EventState) => void, mask: number = -1, insertFirst = false, scope: any = null, unregisterOnFirstCall = false): Nullable<Observer<T>>

The method has declared callback as a mandatory type, and there should be no null value judgment in the function, otherwise it is easy to have a lot of redundant dormitory judgments on the call chain
The return value type should also not be 'Nullable', because if 'callback' is not null, it will always return an observer

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14479/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14479/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14479/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14479/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14479/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14479/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14479/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14479/merge#BCU1XR#0

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14479/merge/testResults/webgl1/index.html
If tests were successful afterwards, this report might not be available anymore.

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14479/merge/testResults/webgl2/index.html
If tests were successful afterwards, this report might not be available anymore.

Commented an extension to your solution.
May I ask - what is the problem with the current signature? Is it just for the sake of clean code?

There are two reasons for this:

The code is clean and not redundant
After calling the method, you don't need to manually solve the optional type of ts (manually remove null)

@GuoBinyong the change is currently breaking back compat or incurring more runtime cost. moving as draft for now but wondering if we should not close it ?

@GuoBinyong the change is currently breaking back compat or incurring more runtime cost. moving as draft for now but wondering if we should not close it ?

Is there a compatibility issue, but there should be no runtime cost.
My personal suggestion is that it should be adopted in a suitable major version, rather than abandoned, for the following reasons: for a library to be excellent, it needs to be compatible in medium and minor versions, and it needs to be bold in major versions;

~The new version simply removes the nullable of the return type. TS users wont know anymore they should handle this case which might lead to runtime exceptions.~
~Why not using @afrokick solution ? This looks like a perfect tradeoff ?~
My bad was confused by
and thought it was already changed... so disregard

After I pushed it, I found that this didn't work, so I proposed a new PR https://github.com/BabylonJS/Babylon.js/pull/14491

closing for #14491


CouplingMap.from_heavy_hex fails for a distance=1

Environment

Qiskit Terra version:  latest
Python version:
Operating system:

What is happening?
CouplingMap.from_heavy_hex(1)

gives

PanicException                            Traceback (most recent call last)
 in
----> 1 cmap = CouplingMap.from_heavy_hex(1, bidirectional=False)
/opt/miniconda3/envs/qiskit/lib/python3.9/site-packages/qiskit/transpiler/coupling.py in from_heavy_hex(cls, distance, bidirectional)
346         """
347         cmap = cls(description="heavy-hex")
--> 348         cmap.graph = rx.generators.directed_heavy_hex_graph(distance, bidirectional=bidirectional)
349         return cmap
350
PanicException: assertion failed: (left != right)
left: 0,
right: 0
How can we reproduce the issue?
see above
What should happen?
It should work since 1 is a positive odd int
Any suggestions?
No response

This is a bug in retworkx (I reported it here a few months ago: https://github.com/Qiskit/retworkx/issues/452 ). It's been fixed on main (with: https://github.com/Qiskit/retworkx/pull/453 ) but there hasn't been a retworkx release in a few months. We're preparing to get one out hopefully in the next week (https://github.com/Qiskit/retworkx/milestone/7 is tracking it). Once retworkx 0.11 goes out this should be fixed (we settled on returning a single node graph for a d=1 heavy hex or heavy square graph, you can see the discussion in the issue and PR).
In the meantime though if you have a rust compiler installed you can run pip install git+https://github.com/Qiskit/retworkx to install retworkx from the dev branch which will fix this issue.

Ahh, ok it looks like this is fairly well known then.  Will close as it fixed.  Thanks for the quick reply.

Just a heads up retworkx 0.11.0 was released earlier today and included the fix for this. If you upgrade retworkx to this version it should fix this


failed installation Ghost Framework

I can't complete the installation because an error appears as below
Copyright (c) 2020-2023 EntySec
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the Software), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED AS: File name too long
./setup.py: 25: from: not found
./setup.py: 27: Syntax error: word unexpected (expecting ")")

hi i it's install for me now but i have a new problem - continue problem

if i try to install with files, same error with open issue...
please help us...

@ofir102 @sukehighland  I fixed it, reinstall.


APT repository returns 400 Bad Request

Is there an existing issue for this?

[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Insomnia Version
2021.5.2
What operating system are you using?
Other Linux
Operating System Version
Linux portable-ws 5.10.0-8-amd64 #1 SMP Debian 5.10.46-4 (2021-08-03) x86_64 GNU/Linux
Installation method
Deb download
Last Known Working Insomnia version
2021.3.0
Expected Behavior
When I do apt update with insomnia repo in /etc/apt.sources.d/ I expect apt to produce no errors and see updated insomnia packages.
Actual Behavior
The following error is reported:
[.....snip.....]
Ign:31 https://download.konghq.com/insomnia-ubuntu default/all all Contents (deb)
Ign:32 https://download.konghq.com/insomnia-ubuntu default all Contents (deb)
Ign:33 https://download.konghq.com/insomnia-ubuntu default amd64 Contents (deb)
Err:22 https://download.konghq.com/insomnia-ubuntu default/all amd64 Packages
  400  Bad Request [IP: <IP_ADDRESS> 443]
[.....snip.....]
Ign:32 https://download.konghq.com/insomnia-ubuntu default all Contents (deb)
Reading package lists... Done
E: Failed to fetch https://download.konghq.com/insomnia-ubuntu/dists/default/all/binary-amd64/Packages  400  Bad Request [IP: <IP_ADDRESS> 443]
E: Some index files failed to download. They have been ignored, or old ones used instead.

Reproduction Steps

Follow instructions from https://insomnia.rest/blog/new-insomnia-apt-repository
run apt update

Additional Information
It was working after I had updated repo information following the instructions from that blogpost, but it stopped at some moment later.

Thank you for your clear writeup!  I followed your steps and was not able to reproduce:
Ign:9 https://download.konghq.com/insomnia-ubuntu default InRelease
Hit:10 https://download.konghq.com/insomnia-ubuntu default Release
Ign:12 https://download.konghq.com/insomnia-ubuntu default Release.gpg

some questions:

could you please try again (now) and let us know your results.  there was some downtime the other day with download.konghq.com and I'd like to verify that you didn't happen to run this command during that downtime.
are you able to fire up a VPN, by any chance, and try from another area of the world (e.g. the US)?  There may be some geo restrictions (although, this is a longshot) on where you can access the repository from, so I'd be nice (but not mandatory) to see if this is related.  If not, would you mind saying which country you're connecting from so I can try to reproduce with a VPN, myself?

Thanks for confirming.  That was it then, huh.  Sorry for the inconvenience but I don't think there's anything we can do about that.  If you think there is lemme know and we can reopen and investigate.

I wonder that too, but all I know is that this is the way the repository works for some locations.

Can confirm this behavior. I'm also connecting from Ukraine.

Unfortunately this has to do with US restrictions on companies around I believe cryptography and Russia. Since we didn't have an easy way to only block connections from Crimea, we had to add a restriction to all of Ukraine.

Well, I can still download insomnia deb file manually from updates.insomnia.rest, or from Github releases, so restriction is not that thorough. It's just apt repo that doesn't work, meaning it's just an inconvenience but not a blocker.
Is apt repo set up that way because some other kong product needed those restrictions?

Is apt repo set up that way because some other kong product needed those restrictions?

That is my understanding after talking to the team that runs the apt repo. Since we are hosting the repo ourselves, I can imagine our lawyers gave us requirements to fulfill -- I know its annoying to not be able to use apt. Sorry about that :(


Stuck on "Waiting for confirmation of MySQL service startup"

it won't move further than that.
Docker version 1.9.1, build a34a1d5 on OSX
FROM tutum/lamp
RUN rm -fr /app
COPY ./ /app
EXPOSE 80 3306
CMD ["/run.sh"]

Did you change the MySQL Server version to 5.6? I'm having this same issue, the create_mysql_admin_user script is not correctly detecting the service status.

I ran into this issue when there was no space left on the host server. It cleared up once space opened up.

This is happening because the deprecated database initialization method in run.sh is actually causing a unrecoverable error and needs upgradation. You can replace the following line:
mysql_install_db > /dev/null 2>&1
with the following line:
/usr/sbin/mysqld --initialize-insecure >
But this change is to be made in tutum/lamp's source code itself and you may also have to use a slightly different method for binding to <IP_ADDRESS> as /etc/mysql/conf.d/my.cnf does not have precedence in MySQL 5.7.
Alternatively, you can simply replace "FROM tutum/lamp" with "FROM webmaestro365/lamp7xenial" which is a fork of tutum/lamp upgrading the image to Ubuntu 16.04 LTS, PHP 7.0 and MySQL 5.7 with all necessary modifications.


Memory leak when displaying DepthCloud and showing the 'Add' menu

We experienced a severe memory leak in rviz today.
Here is the problem, we are displaying a DepthCloud using a depth and color image, from a rosbag at normal speed. As soon as I press the 'Add' button to add another visualisation the GUI stops updating and the memory usage increase rapidly, i.e. ~500MB per second. This is the reason for our laptop with very little memory, to freeze immediately. If the DepthCloud is turned off, no such behaviour can be observed.
This only happens with the DepthCloud as far as we can say. Not sure about point clouds.
We are running 14.04 64bit and ROS Indigo. rviz: version 1.11.7 (indigo) compiled against OGRE version 1.8.1 (Byatis).

It's likely that the depth display is queueing messages. If it has a queue size option in the UI, you should decrease it and confirm that that fixes your problem.
If it doesn't have a queue size option, that's a bug, and one should be added.

I just checked the DepthCloud plugin and confirmed that it has a Queue Size option. You should try decreasing it.

Sorry for the late reply. Set it to 1. Same issue.
The default, which I used before, is 5. So even it would queued up 5 point clouds, that should not result in overloading 16GB of RAM in a few seconds.
As I said, the laptop dies instantly, swapping itself to death.

Ok, thanks @trainman419 and @cdondrup for looking into this. I'll try to reproduce it in the near future, maybe next week.

I managed to reproduce the issue on Ubuntu 14.04 and rviz (indigo_devel, 11fcdadbbcc4c9d38a0bd4d580be6f0b49cbbc47). DepthCloudDisplay::processMessage() calls pointcloud_common_->addMessage(cloud_msg) to queue a new point cloud message.DepthCloudDisplay::update() consumes the message. When you press the 'Add' button, the code keeps queuing messages but nobody consumes them, so the vector grows forever.
Below you can find a workaround that works for me.
diff --git a/src/rviz/default_plugin/point_cloud_common.cpp b/src/rviz/default_plugin/point_cloud_common.cpp
index 4549d86..fc6c0e2 100644
--- a/src/rviz/default_plugin/point_cloud_common.cpp
+++ b/src/rviz/default_plugin/point_cloud_common.cpp
@@ -309,6 +309,7 @@ void PointCloudCommon::CloudInfo::clear()

 PointCloudCommon::PointCloudCommon( Display* display )
 : spinner_(1, &cbqueue_)
+, queue_size(5)
 , new_xyz_transformer_(false)
 , new_color_transformer_(false)
 , needs_retransform_(false)
@@ -724,7 +725,13 @@ void PointCloudCommon::processMessage(const sensor_msgs::PointCloud2ConstPtr& cl
   if (transformCloud(info, true))
   {
     boost::mutex::scoped_lock lock(new_clouds_mutex_);
+
+    // The vector is full, remove the oldest element.
+    if (new_cloud_infos_.size() >= this->queue_size)
+      new_cloud_infos_.erase(new_cloud_infos_.begin());
+
     new_cloud_infos_.push_back(info);
+
     display_->emitTimeSignal( cloud->header.stamp );
   }
 }
diff --git a/src/rviz/default_plugin/point_cloud_common.h b/src/rviz/default_plugin/point_cloud_common.h
index 20d47d6..0bdd7e9 100644
--- a/src/rviz/default_plugin/point_cloud_common.h
+++ b/src/rviz/default_plugin/point_cloud_common.h
@@ -188,6 +188,7 @@ private:
   Ogre::SceneNode* scene_node_;

   V_CloudInfo new_cloud_infos_;
+  size_t queue_size;
   boost::mutex new_clouds_mutex_;

   L_CloudInfo obsolete_cloud_infos_;
@@ -209,6 +210,7 @@ private:
   bool new_color_transformer_;
   bool needs_retransform_;

+
   pluginlib::ClassLoader<PointCloudTransformer>* transformer_class_loader_;

   Display* display_;

@caguero thank you for taking that up!

@cdondrup after discussing it with @caguero I'm going to take some more time to look into the root cause of the issue, but please feel free to use his patch above as a workaround.
I'll try to make a complete fix asap.

We experience a similar issue when playing back a PointCloud2 from a rosbag file independent of the playback speed. The PointCloud2 is being displayed on a moving tf transform, which is also played back from the log file (using rosparam set use_sim_time true). We do not have the add menu open, but several items (2 PointCloud2s, one MarkerArray) being displayed.

We also experienced a similar issue displaying PointCloud2. The work around did not seem to help.


task/kernel: after reboot, do not try to reconnect immediately

Do not try to reconnect immediately after triggering the reboot,
because the reboot sequence might not have started yet (!)
Fixes: https://tracker.ceph.com/issues/44187
Signed-off-by: Nathan Cutler<EMAIL_ADDRESS>

I prepared an integration branch containing #1411, this PR, and a throwaway commit that reboots the cluster unconditionally at the end of the kernel task.
I'm now running a custom opensuse_15.1 job:
running http://pulpito.ceph.com/smithfarm-2020-02-18_20:33:19-custom-master-distro-basic-smithi/


Feature Request: option for MSAVI2 calculation

I would like to have the option to have --order calculate MSAVI2.
About MSAVI2:
https://wiki.landscapetoolbox.org/doku.php/remote_sensing_methods:modified_soil-adjusted_vegetation_index

added this, will be available in next release 0.1.9 and up


example website

Hi guys, do you have an example of a simple website (only index is ok).
where do I have to put my index file?
and how do I have to configure the nginx config file?
Thanks

you can try to use default image Nginx with default site which situated in /var/www/


⚠ SkipTheCommericals has degraded performance

In a9bcaa4, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 1504 ms

Resolved: SkipTheCommericals performance has improved in c7440b4.


Support for Poetry package manager

In our team we are using actively unsloth and we appreciate the work you are doing. We are also using poetry to handle the dependencies and reproduce our work among the team. I was not able to install unsloth to a poetry environment. Is there a way to do it? Can this be introduced as a feature?

Sorry on the delay! Hmmm I've never used poetry sadly, only pip, so unsure how to even make it work sorry :(


Add AGLD Logo to Trust Wallet

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x ] Filename in the lowercase format
[ x] Image format: png
[x ] Image size: 256 by 256 px

this one should work


Formatting into an existing buffer?

Would you accept a pull request exposing a format function that takes an &mut [u8; 29] to format into? I think this can be implemented by moving the Display::fmt implementation to its own pub function, since it already formats into a [u8; 29].
This is useful when avoiding allocations (or using an arena/bump allocator) and sending the response as an &[IoSlice] with the vectored writing functions.

I see why this is useful in some circumstances but I do not want to expand the public interface of the crate. I suggest you benchmark if the extra allocation is significant and if needed fork the crate.

It's more about the API ergonomics than the performance, the performance is fine I'm sure.
For anyone coming along later I did make a fork with this change and the changes suggested in #10 and #11 among other things.
Not being about the performance aside, if you wanted to take a look at my fork @pyfisch I was surprised to find that criterion reported somewhere between 60-70% performance improvement on the parsing benchmarks (not the encoding benchmark where the allocation was) on my computer. Not really sure why, since I wasn't intentionally doing any optimization. Maybe I just don't know how to use criterion? :shrug:
Also, maybe it's just me not understanding criterion again, but it looks to me like your encoding benchmark is testing writing a static string rather than the HttpDate Display implementation?


Using Torii - session service doesn't inject into routes/controllers

Have pored over several tutorials for an EmberFire / Torii setup and am not able to get the session service to work at all. Is a step missing or is there possibly an issue with newer versions of EmberJS when injecting the session service?
environment.js
module.exports = function(environment) {
  var ENV = {
    ...
    firebase: {
      apiKey: '',
      authDomain: '',
      databaseURL: '',
      storageBucket: ''
    },
    torii: { sessionServiceName: 'session' },
    ...
  };
}

app/torii-adapters/application.js
import Ember from 'ember';
import ToriiFirebaseAdapter from 'emberfire/torii-adapters/firebase';

export default ToriiFirebaseAdapter.extend({
  firebase: Ember.inject.service()
});

routes/application.js
import Ember from 'ember';

export default Ember.Route.extend({
  beforeModel: function() {
    return this.get("session").fetch().catch(function() {});
  },
  ...
}

Browser console when visiting application route:
ember.debug.js:28058Error while processing route: index Cannot read property 'fetch' of undefined TypeError: Cannot read property 'fetch' of undefined

Guides consulted while trying to sort this out:
http://www.programwitherik.com/emberjs_2-0_example_app_with_firebase/
http://www.danielgynn.com/third-party-auth-in-ember-with-firebase/
Package versions -
"ember-cli": "2.3.0",
"emberfire": "2.0.1",
"ember": "~2.3.1",
"firebase": "^3.0.0"

You'll need to inject the session service.
import Ember from 'ember';

export default Ember.Route.extend({
  session: Ember.inject.service(),
  beforeModel: function() {
    return this.get("session").fetch().catch(function() {});
  },
  ...
}

That should work, LMK if you continue to have issues.

I tried doing this with explicitly injecting the session, to which it complained there was no such service.
Also all examples of how to use Torii I found imply that session is already implicitly injected.  Please see: https://www.danielgynn.com/third-party-auth-in-ember-with-firebase/

I'm having this same issue with a brand new ember app/install. Injecting the session service as per @jamesdaniels suggestion doesn't fix the problem.  Could there be a version compatibility issue between emberfire and torii?

I think I found the issue. I had installed ember-simple-auth, which is no longer needed and causes this to break. Removing this npm package allowed everything to work as expected.

A bit late but that was it for me to eric


Hop-3221 Deprecated code cleanup

Hi @nadment,
I fear the changes you applied are not enough, as we do not want to save the resolved variable in the meta.
In the meta we will have to store the string coming back from the dialog and resolve in the base transform/action classes

The changes will be very important!

How to name the text field with the reference of the database uses: connection or databaseName?

I am having difficulty with some functions of ITransformMeta which doesn't  have a metadataProvider like:
public DatabaseMeta [] getUsedDatabaseConnections ()

The MetaSelectionLine widget should first be adapted to give it a name rather than a metadata

addConnectionLine (Composite parent, Control previous, DatabaseMeta selected, ModifyListener lsMod) {
wConnection.addToConnectionLine (parent, previous, selected, lsMod);

++ addConnectionLine (Composite parent, Control previous, String connection, ModifyListener lsMod) {
++ wConnection.addToConnectionLine (parent, previous, connection, lsMod);

@nadment Most of your issues were resolved by @sramazzina . an example can be found in the tableoutput.
He created a helper variable to contain the connection string next to the databaseMeta, it is maybe not the cleanest solution but I think it will do


Add "prefer unidolized card image" for users' idolized cards

Adds an option to use the unidolized card image even when a card is idolized. This patch adds a new field prefer_unidolized_image to OwnedCard as well as all the UI logic to support it.
Explanation of why I think this is useful:
The way that I check/update my Tomodachi is, in the SIF app, I set my sort order to "rarity" and I visually compare it to my deck on Tomodachi. However, on some of my idolized cards I prefer to use the unidolized image. Except that on Tomodachi those cards still show up as using the idolized image, which can get confusing. This way I can set prefer_unidolized_image on my cards on tomodachi that I prefer the unidolized image on, and now my Tomodachi deck exactly matches my in-game deck visually, and makes comparing them much easier.

Before I merge this, can you check if you edited all the files that manipulates or display the owned cards? I recently published this: https://github.com/SchoolIdolTomodachi/SchoolIdolAPI/commit/0be911cfe1a859df1092e3e583ee2f58cdad4184 which adds a skill slots to owned cards and had to check everything that needed to be changed, so it might help make sure we didn't forget anything!

Pretty sure I checked to make sure I hit every file that deals with OwnedCard, but I'll take another look when I get back home from work tonight.
Sent from my iPhone

On Jan 25, 2017, at 7:15 AM, deby<EMAIL_ADDRESS>wrote:
Before I merge this, can you check if you edited all the files that manipulates or display the owned cards? I recently published this: 0be911c which adds a skill slots to owned cards and had to check everything that needed to be changed, so it might help make sure we didn't forget anything!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


working for ignore backgorund noise?

Hi, this working for ignore backgorund noise? regards

any update?!


[activemq-cpp] Inclusion of SSL and static building.

Fixes issue #9138 and also add SSL option to use with original library

Build will fail with openssl 1.1.1d due to missing library dependencies

Build will fail with openssl 1.1.1d due to missing library dependencies

Hi Neumman-A,
Would you know which dependency is missing?
Thanks.

crypt32 and the openssl libraries are differently named with the update to 1.1.1d

@rotrida,  do you have a chance to address the review suggestions? Thanks!

Thanks for the PR; we're closing this for now since there's been no response. If you'd like to continue working on it, please reopen and ping us!


Make the Prometheus host a configurable property

Added some brief descriptions of how to configure the prometheus host.

Deploy preview for calico ready!
Built with commit a04d6960b610168f48fd5ab987fe5b6b2fbb5450
https://deploy-preview-2728--calico.netlify.com


[EPIC] v0.11

[x] #15329
[x] #15371

@nerdai can we close this?

Yeah, we should be able to close this. There is still the mypy issue tho #15330. @logan-markewich: is mypy stuff done, or maybe this issue should't be under v0.11 epic at all

agreed --- ripped out :)


Fix ImportError for configure_logging

Description
We recently moved the logging configuration to its own submodule in esmvalcore. This PR fixes a potential ImportError in esmvaltool.

Addresses: #1975

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 PR has a descriptive title for the changelog
[x] 🛠 Code follows the style guide
[ ] 🛠 Circle/CI tests pass
[ ] 🛠 Codacy code quality checks pass
[x] 🛠 Documentation builds successfully on readthedocs

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

OK good catch, just gonna wait for numpy to come back then rerun the tests :+1:

OK good catch, just gonna wait for numpy to come back then rerun the tests :+1:

tests are dying because of this https://github.com/ESMValGroup/ESMValTool/issues/1980 - nothing to do with your PR, mate :+1:

tests are dying because of this https://github.com/ESMValGroup/ESMValTool/issues/1980 - nothing to do with your PR, mate :+1:

This should only have been merged after the release of ESMValCore v2.2. Please do not merge pull requests with failing tests. If you had looked carefully through the test failures, you would have seen that this pull request introduces additional failing unit tests.

This should only have been merged after the release of ESMValCore v2.2. Please do not merge pull requests with failing tests. If you had looked carefully through the test failures, you would have seen that this pull request introduces additional failing unit tests.

This should only have been merged after the release of ESMValCore v2.2. Please do not merge pull requests with failing tests. If you had looked carefully through the test failures, you would have seen that this pull request introduces additional failing unit tests.

@bouweandela see me comment on the reversal PR, mate :+1:

This should only have been merged after the release of ESMValCore v2.2. Please do not merge pull requests with failing tests. If you had looked carefully through the test failures, you would have seen that this pull request introduces additional failing unit tests.

@bouweandela see me comment on the reversal PR, mate :+1:

Sorry this was merged too early @stefsmeets, we had to revert it for now. Could you please make a new pull request with these changes?

Sorry this was merged too early @stefsmeets, we had to revert it for now. Could you please make a new pull request with these changes?

#1994

#1994

Thanks!

Thanks!


Release v0.8.1

Looking at the NPM semantic versioning guidelines the recent contributions by @akretz will be released as a bugfix under version 0.8.1
I will prepare the updated package.json and release a new version to NPM once @tdurand has given me access to NPM.

I think you have access, many thanks !!

Main branch has been updated. Will publish package to NPM now.

Here we go https://www.npmjs.com/package/node-moving-things-tracker/v/0.8.1 🎉


Some issues

I saw your video on youtube. Years ago I made an ethereum decentralized tamagotchi with pyxel.
I ran your code using windows 10 (sadly) on wsl.
I faced that issue :
{
"reason": "The Spire Guardian A summons two Saplings, each dealing 1 damage to the player each turn.",
"results": "[Spire Guardian A: summoned <Sapling: deal 1 damage to player each turn> * 2]\n[Player: damaged 1]\n[Player: damaged 1]",
"significance": 1
}

2024-08-30 18:32:00 [info     ] EventBus.emit                  listener=<weakref at 0x7f4994137990; to 'AppWithScenes' at 0x7f4a28ee4970> unwrapped=<bound method AppWithScenes.on_event of <genio.scene.AppWithScenes object at 0x7f4a28ee4970>>
2024-08-30 18:32:00 [info     ] AppWithScenes.on_event         ev=LLMInboundEv()
Traceback (most recent call last):
  File "/mnt/c/Users/User/Desktop/pineapple-pen/src/genio/scene.py", line 166, in update
    self.scenes[0].update()
  File "/mnt/c/Users/User/Desktop/pineapple-pen/src/genio/scene.py", line 56, in update
    self.current_version.update()
  File "/mnt/c/Users/User/Desktop/pineapple-pen/src/genio/gui.py", line 1277, in update
    self.check_mailbox()
  File "/mnt/c/Users/User/Desktop/pineapple-pen/src/genio/gui.py", line 1330, in check_mailbox
    effects = self.futures.popleft().result()
  File "/home/btc4cash/.pyenv/versions/3.10.12/lib/python3.10/concurrent/futures/_base.py", line 451, in result
    return self.__get_result()
  File "/home/btc4cash/.pyenv/versions/3.10.12/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
    raise self._exception
  File "/home/btc4cash/.pyenv/versions/3.10.12/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/mnt/c/Users/User/Desktop/pineapple-pen/src/genio/battle.py", line 953, in resolve_enemy_actions
    self.process_effects(resolved_results.results)
  File "/mnt/c/Users/User/Desktop/pineapple-pen/src/genio/battle.py", line 866, in process_effects
    battler = self.search(target)
  File "/mnt/c/Users/User/Desktop/pineapple-pen/src/genio/battle.py", line 846, in search
    raise ValueError(f"No battler found with name '{name}'")
ValueError: No battler found with name 'spire guardian a: summoned <sapling'

We should talk, this idea is genius and the graphics are awesome<EMAIL_ADDRESS>

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

Unfortunately summoning saplings (or summoning anything) was too buggy to be included in this version of the DSL that is written by Gemini 🙃 (should not be hard to add -- but the model sometimes hallucinates designs that are not yet in the DSL no matter how powerful the DSL is). The reliability and controllability of LLMs is something that was hard to conquer in this iteration of the game. We cannot always trust using the model to generate complex behavior -- I guess at least I could have made it more fault tolerant.
Thanks for the interest -- let me send you an email to in general follow up.

Gladly


Rounded corners on dates

Create option for rounded corners on dates, similar to https://github.com/uxsolutions/bootstrap-datepicker

Pushed with #61 thanks!


Error for missing await in conditional

TypeScript Version:  3.0.0-dev.20180626

Search Terms:

await
conditional
diagnostics

Code
async function foo(): Promise<boolean> {
    return false;
}

async function bar(): Promise<string> {
    if (foo()) {
        return 'true';
    }
    return 'false';
}

Expected behavior:
A warning or error or suggestion is generated in the if conditional since it will always be true. The user almost certainly intended to await the result of foo instead.
Possibly also have a quick fix to add the await
Actual behavior:
No errors or warnings. Code does unexpected things

This is in the realm of linter work, but i suppose we can make an exception here since this code will never work anyways..

After the work done in TS3.6 "Improved UX Around Promises" this shouldn't be difficult to implement right?


Rollup function is not working  for any transformer type

Returning data when using the Rollup operation for any transformer type e.g. column_index_table or line_chart results in an error.
Example call:
print(json.dumps(slicer.manager.line_chart(         metrics=['clicks'],         dimensions=['date'],         dimension_filters=[RangeFilter('date', date.today() - timedelta(days=60), date.today())],         operations=[Rollup(['date'])]     )))
Error message:
TypeError: ufunc 'isnan' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

Do you get the same error message for all of the transformers?  Can you please post the full stack trace?

I was able to reproduce this for the datatables transformer.  Seems that pandas is returning future.types.newstr.newstr instead of str in some cases.


Change link dictionaries to tuples to control link ordering

This (tiny) PR will change the links to be lists of tuples to allow for control of the ordering:

awesome!


Does not create cards correctly

Hi. When I try to run "Publish" part it mixes up information.
Creates Card No.2 with information which was entered for Card No.3 and etc.
Any ideas on what can cause this?

Error given on immediate window: "400 - Bad Request
invalid value for idList"

I have experienced this too. Workaround at the moment is to shift all information in columns B to J down a row, and create a bogus entry in row 4. There has to be a simple fix but I'm only getting up to speed with VBA...
Otherwise, thanks so much for publishing this tool, it's a real time-saver for me.

Well done alvijagr - works beautifully now!

Thanks @Kaan191 for reporting the issue and @alvijagr for suggesting the solution. Sorry I wasn't able to look into it quicker. I'll release a new version including your fix.


[Popover] Add overlay option to popover

Hi,
I would be nice to have a boolean property to show/hide an overlay with the popover.

We're looking at using the Overlay component with a custom Search component overlaid on it
To accomplish we're importing material-ui/internal/Overlay which works well but feels fragile with the "internal" nature of the Overlay.
Given the various use cases, it might make sense to make Overlay a public component?

We do have an overlay component. I don't think that we should be backing it into the Popover. Still we could potentially move it out of the internal folder and document it.

As far as I can see there is a backdrop with the Popover with alpha 1, it would be good to be able to control that as, in some cases, makes sense to let the user know any other interaction is disabled.
i.e. I have a colour palette with swatches that show edit/delete actions on hover and, when clicking edit, a Popover with a colour picker shows right beneath. At this point, as there is no visual clue that the Popover is a blocking action, users reported that hovering over other swatches doesn't work.

The Popover inherits the properties of the Modal component. You can already provide a BackdropInvisible, BackdropClassName and BackdropComponent property. I will work on exposing the Modal component to the public API so the feature is better documented.
The issue can be closed. Here is a demo: https://codesandbox.io/s/322l1n9ym6.