Making some small changes to post causes Bad request 400 error

I have changed the post in PostImage to ForeignKey from one-to-one. And added a CharField called ptype, which I wanted to use for filtering based on its value.
In getTopPosts, I have moved post__image from select_related to prefetch_related, and added ptype to only. I have also added ptype to curate_top_posts in jobs. On other hand, I have also added many=true  wherever PostMediaSerializer is used.
I then added a query in top_post_community_query, post__ptype__exact="string" where string is recieved from request in view. Made relevant changes to serializer as well. This is where I am facing  the problem of bad request 400 in api, and invalid model in app. If I comment out the ptype query, error dissapears and I get a list of top posts. But if I keep the query and instead comment out  content_object in PostMediaSerializer, then also the 400 error dissapears, although I get error in app due to no Content object.
I tried to add the ptype field to TopPost model instead, so I could use it direct, and made all the relevant changes to jobs, and ran migration successfully. But then the scheduled job fails with Integrity error, 1364, ptype has no default even though I have added default string in the ptype field. I also tried to set null=True and null=False, but getting the same error in the failed job.

@lifenautjoe any way you could help us sort this out ??

@lifenautjoe anyone else whom you know could help us figure this out ?


The trained models and results can not be downloaded.

The trained models and results can not be downloaded from here. We want to download the pre-trained iDispNet model.
The error is:
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='drive.google.com', port=443): Max retries exceeded with url: /uc?id=1Bp4VjWcydtawtKjk9BHJS6XWOozZ65yg (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f63ceaa3550>: Failed to establish a new connection: [Errno 110] Connection timed out'))

The trained models and results can not be downloaded from here. We want to download the pre-trained iDispNet model. The error is: requests.exceptions.ConnectionError: HTTPSConnectionPool(host='drive.google.com', port=443): Max retries exceeded with url: /uc?id=1Bp4VjWcydtawtKjk9BHJS6XWOozZ65yg (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f63ceaa3550>: Failed to establish a new connection: [Errno 110] Connection timed out'))

try to download from https://drive.google.com/uc?id=(add id)


update github dependencies for node 20

We use this GitHub action and are getting this error while using it:
The following actions use a deprecated Node.js version and will be forced to run on node20: sonarcloud-actions/sonarcloud-check-status-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
This PR updates the associated GitHub dependencies for Node 20

thanks for the contribution. Merged


fix: correlation dependent linear shap

This PR fixes two bugs in shap.explainers._linear.Linear related to  #1795

shap.maskers.Independent was always used regardless even when feature_perturbation="correlation_dependent" was provided in the constructor.
explain_row(...) was returning a numpy array for the correlation_dependent feature perturbation method instead of the expected dictionary. This error only surfaced after fixing the first issue.

Looks good, thanks for the catch! The recent API update missed that change. I made a small tweak and will merge once the tests pass.


Remind you of adding M2DGR to this list

Thanks for your great work! But if you add M2DGR (https://ieeexplore.ieee.org/document/9664374), I believe this list will be more complete and interesting!

Thanks for your reminder!
I'll add the Dataset category, and add the paper you mentioned!
Thanks,


Added gravity to button menu

Sets a gravity for children of the floating action menu.
Children can gravitate to start, center or end of their corresponding x or y position, depending on the expand direction. The text labels automatically get changed position from left to right based on the gravity setting.
How it looks for start and end:

Looking forward to seeing this implemented. Any update on progress?

Labels position implemented in 7c752e1447a9a724751a6038e26f193adf0b7122. I'm closing this PR, please reopen it if you think it adds other useful features.


fix(admin-ui): typo in filename in App context

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 9.905%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
9405

Relevant Lines:
94954

💛  - Coveralls


Dashboard backend admin service URL is not configurable

If we are setting up a proxy for the identity server and set proxy host and port as mentioned in doc, then all the admin service calls from the dashboard and portal jaggery apps are using https://proxy_host:proxyport/services URL.
There are some cases, we need to avoid these admin service calls going through proxy and hit the backend direclty.
According to doc, it seems that URL is configurable using site.json. But according to the code, the proxyHost and proxyPort set in site.json is discarded in the setServerURL().

Fixed with
https://github.com/wso2/product-is/pull/4518
https://github.com/wso2/product-is/pull/4662


SONARMSBRU-166 Fail if sonar-project.properties file found

SonarQube analysis reported 3 issues:

 3 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Method 'SonarRunnerWrapper.Execute(AnalysisConfig, IEnumerable, ILogger)' passes 'cmdLineArguments' as the 'paramName' argument to a 'ArgumentNullException' constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method.

SonarQube analysis reported 3 issues:

 3 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Method 'SonarRunnerWrapper.Execute(AnalysisConfig, IEnumerable, ILogger)' passes 'cmdLineArguments' as the 'paramName' argument to a 'ArgumentNullException' constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method.

LGTM

SonarQube analysis reported 3 issues:

 3 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Method 'SonarRunnerWrapper.Execute(AnalysisConfig, IEnumerable, ILogger)' passes 'cmdLineArguments' as the 'paramName' argument to a 'ArgumentNullException' constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method.

SonarQube analysis reported 3 issues:

 3 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Method 'SonarRunnerWrapper.Execute(AnalysisConfig, IEnumerable, ILogger)' passes 'cmdLineArguments' as the 'paramName' argument to a 'ArgumentNullException' constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method.


Deprecate the dynamic-control.js script

Most of these mods can be moved to the controls themselves in v4.0

We still need this one and deprecating it is more involved than I initially thought. Moving to 4.1, this is not a priority.


[move][cli] Support safe module republishing with breaking changes ch…

…ecks

If the CLI is trying to compile M.move, the logic for finding compilation deps now removes M.move from the deps list.
More generally, any files directly or transitively reachable from the compilation targets are removed from the deps list. This
fixes the annoying "duplicate definition" warning that you used to get when trying to re-publish a module
Before a move publish, the CLI runs the bytecode linking and data layout compatibility checks and reports an error if the
code to be published could cause a breaking change to either linking or data layout
Added tests for republishing, running move check M.move after publishing M.move, and the breaking changes checks

Can't add @mengxu-fb as a reviewer for some reason, but definitely want your opinion!

Thanks Sam for pinning me here. The changes LGTM, and I'll leave it to others to stamp it :)
I think given what the CLI has, the file exclusion can only be best-effort and never perfect. I wish we had compiler-side change to support module updates directly, say, in, move_compile(targets: &[String], deps: &[String], ...) modules in targets supersedes modules found in deps.

/land

:broken_heart: Test Failed - Build images and run cluster test

/land

/land

@sblackshear :bulb: This PR is already queued for landing


a latched channel experiment

I would like to experiment with a variation on a buffered channel that I call a latched channel.
The idea is to offer broadcast semantics, where a receive on a latched channel would not consume from the backing queue.
I wrote a proposal here, and I invite comments on the design and guidance (which files have the relevant code?) for how to prototype it in the Go runtime.
https://github.com/glycerine/latch
If the experiment proves successful in terms of usability and usefulness, then I would think of promoting the experiment to a Go proposal.

If you want discussion it's probably best to raise this on the golang-dev mailing list.
The relevant code in the Go runtime is in chan.go and select.go.

Yeah, I'm going to close this. (We only use the issue tracker for tracking work items we can close, not for questions.)
But do bring it up on the mailing list. Thanks.

Yeah, I'm going to close this. (We only use the issue tracker for tracking work items we can close, not for questions.)

Fine with me. It's kind of a pre-proposal, but reason for the ticket was that the procedure for proposals specifically requests a github issue.

Oh, sorry, I thought it was a package you wanted to write, and not a language change proposal.
I'll note that language change proposals are notoriously unlikely to get approved at this stage of Go 1.x. Your best bet is to experiment on the side and wait for any Go 2 discussions to happen later.

Before this reaches proposal stage, could you please show the rationale for
this feature and why it can't be solved by existing features?

Hi Minux (@minux), I did write that up pretty thoroughly, and demonstrated it with the best work-around code I could come up with. Did you read the analysis? Since this ticket is closed, perhaps this is not the place for discussion now. Feel free to open a ticket on https://github.com/glycerine/latch to discuss.


feat: introduce MessageBuilder

WIP for #337

Looking for early feedback on this before implementing methods for building other message types.
And specifically:
Validation: using flatbuffers/models/validations to perform validations seems mostly good with a couple caveats:

Some of the validations like checking the signature and timestamp don't make as much sense in the context of constructing messages but may not hurt. We could just use the message specific (i.e. validateSignerMessage) to validate user input rather than using validateMessage like I have it currently.
The validation functions return Result<T, HubError> with error codes like bad_request.validation_failure. We could return more generic error codes from the validations module and have consumers add whatever additional context (i.e. bad_request).

Signers: I'm think the API I have for setting up ECDSA and EsDSA signers is decent but I'm not completely satisfied. Still noodling on it but open to suggestions.

Do you think you could split this work into two pieces: (1) a set of stateless functions to generate flatbuffer messages from JSON versions of the messages and (2) a class like the MessageBuilder one you have that retains the fid, signer, etc for ease of use? What's nice about splitting it is that the stateless functions can be used to implement the MessageBuilder class but they can also be used in tests across the rest of the codebase.

Also for error handling, I think it's fine to send the generated object through validateMessage. I think that's better than effectively writing a parallel set of validations. And I don't see any issue with returning HubResult<...> from all these methods.
If you're excited about doing it, I think it would be great to refactor the validateMessage method so that it checks a bunch of stuff in parallel and returns an aggregate list of validation errors. The fact that the user gets a single error, then runs into another, and another could be annoying.

@pfletcherhill yes makes sense, I'll split it. Thanks for the feedback re errors, will revisit validateMessage after I wrap this up

@adaddeo can you replace calls to arrayify and hexlify with the appropriate methods from the bytes.ts file? I just merged a bunch of new methods there, because arrayify and hexlify default to big endian but all data inside the hub should be little endian. Happy to give more context/explanation too if this doesn't make sense.

Initial feedback has been incorporated.

constructors export stateless functions for building message models that all take fid, signer, and network along with whatever specific properties are required for building that message type (i.e. publicKey for SignerAdd)
there are two classes for building messages, one for signer messages and one for all others
updated to use byte functions

@pfletcherhill looking for any more feedback on the general pattern and once you're satisfied I'll go ahead and implement the rest of the message types
One question: should network be optional? If so what default is preferred?

I've been thinking a fair amount about the various use-cases for this, and I think we should focus mostly on the third party dev UX rather than internal hub usage. While that would seem to mean lots of abstractions over flatbuffers, the most immediate need is a package that Merkle can import into their backend to create valid flatbuffer messages and send them to our internal hub. We want the API for building those messages to be incredibly straightforward, but they should still be able to retrieve the flatbuffer itself and save that in a database.
To that end, I think we should write a new class (or just a json type) for representing a message that includes both the deserialized values and flatbuffer. The MessageModel class has a lot of code that has to do with rocksdb persistence inside hubs that shouldn't be given to external devs. And MessageModel also doesn't do enough deserialization—we want devs to have access to json versions of all the message data. It could be as simple as this (see below), though it's probably worth making a class that validates the provided data and makes it readonly:
// types.Message from https://github.com/pfletcherhill/farcaster-hub/blob/js-package/packages/js/src/types.ts
type Message = types.Message & {
  fbb: flatbuffers.Message;
  tsHash: string; // tsHash isn't part of the message and has to be computed
}

Also, I don't think persistence of fid or signer between messages is actually that important for a dev. I imagine they want to be able to create messages for many fids and many signers, so I think we should export the stateless functions rather than the MessageBuilder class.
Here's the API I'm imagining, which is very similar to what you already have with the exception of the arguments to methods like makeCastAdd being the json versions of body and data (i.e. no byte arrays).
import { FarcasterClient, makeCastAdd, Ed25519Signer, FarcasterNetwork } from '@hub/js';

const client = new FarcasterClient(`<insert hub address and port>`);

const signer = new Ed25519Signer('<insert private key>');

const castAdd = await makeCastAdd({ text: 'hello world' }, { fid: 10, network: FarcasterNetwork.Testnet }, signer);

const response = await client.submitMessage(castAdd);

const castResponse = await client.getCast(10, castAdd.tsHash)

expect(castResponse).toEqual(castAdd)

Also note that the end result should be an external package (@hub/js), though the code can be written inside that package or in @hub/utils and re-exported from there.

Ok this clarifies things. The use case I had in mind was a frontend client interacting directly w/ a hub, but given this use case I see the appeal of stateless function and returning objects with json + flatbuffer representations. Model classes won't be used outside of Hubs (I just saw grpc Client got refactored to work with flatbuffer representations directly).
I also see the json module for going between scalar and byte representations, very nice 👍
I think we're on the same page. How would you like to proceed from here?

Should the validations module also be refactored to work with flatbuffers.Message instead of MessageModel?

Great, here's the branch I was experimenting with an approach like this: https://github.com/pfletcherhill/farcaster-hub/tree/message-builder
Feel free to pull into your message-builder branch and continue working on it or just use as inspiration

message-builder

will do!


Render tasks as completed checkboxes

Hi,
Enjoying this plugin quite a bit, but wondering if it would be possible to import Todoist tasks as completed checkboxes, not just in a list format.
It isn't too difficult to manually turn them into checkboxes and mark them as completed, of course. But just wondering if it's possible.

Hi Anvimea,
I'm really glad that you enjoying the plugin.
Yes, this feature is on my list. I plan to add it to the next release!


Deadlock on startup because of getenv()

Originally reported on Google Code with ID 655
What steps will reproduce the problem?
1.2.Run VS2010 app with statically linked gperftools 2.2.1

What is the expected output? What do you see instead?
Deadlock at startup

What version of the product are you using? On what operating system?
gperftools 2.2.1 on Windows 7

Please provide any additional information below.
EnvToBool("TCMALLOC_AGGRESSIVE_DECOMMIT", false)
macros from function
InitStaticVars()
causes deadlock because it uses getenv() instead of TCMallocGetenvSafe().

Reported by zndmitry on 2014-10-22 23:55:32

Oh, finally.

Thanks! That was pretty ASAP.


Firmata: use cases, guidance?

Hello everyone! I'm trying to get a better understanding for how the Firmata implementation is expected to be used. I've been working with the protocol for a little over 4 years and I'm currently the active maintainer of Firmata.js, which is a Node.js module for communicating with microcontrollers running  StandardFirmata (StandardFirmataPlus is actually the recommended variant these days).
The most common use cases:

Arduino Uno & Mega come with StandardFirmata preloaded, so out of the box the board can communicate with programs using Firmata.js
With the Arduino IDE, a user uploads StandardFirmata (StandardFirmata, or any of the variants: *ChipKIT, *Ethernet, *EthernetPlus, *Plus, *WiFi)  StandardFirmata to their Arduino compatible board, then the board can communicate with programs using Firmata.js

I'm trying to understand how mraa's Firmata implementation fits into those well known use cases. What boards does this run on? Digging through the source I've seen mentions of the Curie, so presumably the Arduino 101? Does this run by default, ie. can I connect the Arduino 101 to a host computer and write, for example, Node.js programs that interact with the board via Firmata protocol? What is the process for getting started there?
Or is it the other way around? Based on the code in firmata.c (and implied by the example host program), it looks like the implementation is actually meant to be a host that would connect to a microcontroller running one of the variants mentioned above?
Sorry for the mountain of questions, but any information would be greatly appreciated! Thanks in advance :)

Hi Rick, the firmata stuff is a bit WIP so that's why there's no docs etc :) But let me try answer your questions.

Initially this is targeted at the the Arduino 101, realistically there's nothing board specific about what we're doing so it'll likely work on all although testing will likely be limited.
We actually want it to be easier than uploading anything with the IDE. We're creating something called 'imraa' which will flash users boards as soon as they're plugged in to the device running imraa with the correct version of Firmata
We're making an extensible Firmata plugin for the 101 IMU and we'll provide UPM modules for talking to it.
We're investigating how to use the FirmataBLE stuff, this is still an investigation at this stage. So far we're only supporting the std/stdplus variants but we're open to supporting more.
Firmata boards will be treated as 'subplatforms' so once you add the subplatform offset you'll be on the firmata board, for example arduino GPIO13 == 512+13. I2c bus 0 becomes 0 + 512 etc... We plan on supporting multiple firmata connected boards but not in the first instuance. The only requirement is to add the board via mraa_add_subplatform(MRAA_GENERIC_FIRMATA, "/dev/ttyACM0"). We're also planning on making mraa_init() detect arduino 101s automatically (and possibly others) so that this call is not even required.

If you want to try it out we can keep this thread running in case you run into any issues!

We actually want it to be easier than uploading anything with the IDE. We're creating something called 'imraa' which will flash users boards as soon as they're plugged in to the device running imraa with the correct version of Firmata

How is the correct version determined?

Correct version is currently simply flashing with what we have set in /etc/imraa.conf which will point to a binary sketch in /usr/share/mraa/. For now we're using a StandardFirmata sketch but we'll move to a sketch based on ConfigurableFirmata with the IMU plugin v.shortly.

Firmata boards will be treated as 'subplatforms' so once you add the subplatform offset you'll be on the firmata board, for example arduino GPIO13 == 512+13. I2c bus 0 becomes 0 + 512 etc...

Can you give me a concrete example?

see examples/i2c_firmata.c in firmata branch, be essentially here's an example that reads the test byte from a bmp085 sensor over i2c.
int
main(int argc, char** argv)
{
    mraa_init();
    mraa_add_subplatform(MRAA_GENERIC_FIRMATA, "/dev/ttyACM0");

    mraa_i2c_context i2c;
    i2c = mraa_i2c_init(0 + 512);
    mraa_i2c_address(i2c, 0x77);
    int res = mraa_i2c_read_byte_data(i2c, 0xd0);
    printf("res is 0x%x\n", res);
}

Thanks, I think I was having trouble understanding what subplatform meant in this context.
Re: the Firmata IMU plugin, I think there needs to be a "non-standard command" byte defined in the Firmata protocol, which you can use to safely implement any additional commands/responses.
cc'ing @soundanalogous

Indeed, this is what we have, i'll publish it this week.

Re: the Firmata IMU plugin, I think there needs to be a "non-standard command" byte defined in the Firmata protocol, which you can use to safely implement any additional commands/responses.

Is this regarding the Arduino 101 on-board IMU?

@soundanalogous yes the byte we're using is
#define CURIE_IMU (0x11)

FYI I'm considering the use of 14bit IDs for devices: https://github.com/firmata/ConfigurableFirmata/issues/16#issuecomment-184387110

Hi @arfoll :
can MRAA  support StandardFirmata Plus for now? I got some trouble when I init Arduino UART by using MRAA  firmata.


🐛 Fix: Traefik www redirect

What do these changes do?
Fixes the traefik http --> https and www. --> no-www redirects
Related issue/s

https://github.com/ITISFoundation/osparc-ops-environments/issues/874

Related PR/s

https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1126/

Should be merged after: https://github.com/ITISFoundation/osparc-ops-environments/pull/894
Checklist

[x] I tested and it works

I will address your comments :--)
thx


when will L5 support be merged to master/stable?

When will the Laravel 5 support be merged into master/stable?

I'll do that soon.


Fix unread marker showing double lines on task comment

Details

Changes useRef implementation for userActiveSince flag with useState to render the horizontal line correctly when a message is marked as unread on task views.
Fixed Issues

$ #26529
PROPOSAL: #26529
Tests

Click on the FAB and Assign task
Enter the task details and click Confirm task
Add a new comment to the task
Hover over the comment and mark it as unread
An unread mark should appear and the grey horizontal line should be hidden

[x] Verify that no errors appear in the JS console

Offline tests

Same as Tests
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.webm

Mobile Web - Chrome

mweb.chrome.webm

Mobile Web - Safari

https://github.com/Expensify/App/assets/371291/93c9de2c-79d9-490b-ac9d-6dd0b8f722e2

Desktop

desktop.webm

iOS

https://github.com/Expensify/App/assets/371291/39c3918e-0ffb-4454-9b14-ee5ecab9e6ae

Android

android.webm

I cannot make it unread on mobile chrome, could you check on your end? @zukilover
https://github.com/Expensify/App/assets/61146594/49551946-587a-4734-8119-9fa1a8a8c963

On first run (fe. after reloading app) we can ancounter the warning after amking message unread
https://github.com/Expensify/App/assets/61146594/4cd70498-ee6e-402a-bdbd-dbf050af0369

@zukilover kindly bump

Hi, I'll check it out shortly. @robertKozik

@robertKozik I can make it unread on Android Chrome:
android.chrome.webm

I have fixed the warning on app @robertKozik.
android.webm

Thanks will continue review on monday 😉

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.80-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@zukilover this PR was reverted becuase of https://github.com/Expensify/App/issues/29160. Please correct your PR and submit a new one, thanks!

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.81-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@jasperhuangg @robertKozik new PR ready for review: https://github.com/Expensify/App/pull/29314

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


D415 plug/unplug crashed

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>

Operating System & Version
win10

Platform
PC

SDK Version
v2.51.1   (because we use 32-bit and this is the last version including 32-bit realsense2.dll)

Language
java invoke c++

Segment
Robot

Issue Description
i use a usb and a 10-meter fiber connected to computer.  when i unplug and replug , sometimes it crashes.  Most time crashed in wait_for_frames. Need to know how to slove this problem.   And when i use Intel realsense viewer.exe to repeat the same actions, most time it can work.

hs_err_pid19272.log
hs_err_pid12592.log
hs_err_pid23804.log
hs_err_pid24796.log

Hi @LLY13  I would first recommend updating your camera firmware driver from <IP_ADDRESS> (which is 5 years old at the time of writing this) to version <IP_ADDRESS> (the recommended firmware for SDK 2.51.1).  Using the recommended firmware for a particular SDK version can help to avoid errors and you also get the benefit of bug-fixes and improvements accumulated over time (such as better USB stability when plugging-unplugging).
https://dev.intelrealsense.com/docs/firmware-releases#d400-series-firmware-downloads

Hi @LLY13 I would first recommend updating your camera firmware driver from <IP_ADDRESS> (which is 5 years old at the time of writing this) to version <IP_ADDRESS> (the recommended firmware for SDK 2.51.1). Using the recommended firmware for a particular SDK version can help to avoid errors and you also get the benefit of bug-fixes and improvements accumulated over time (such as better USB stability when plugging-unplugging).
https://dev.intelrealsense.com/docs/firmware-releases#d400-series-firmware-downloads

I've updated firmware driver to <IP_ADDRESS>. I tested unplug/replug and it still stuck in wait_for_frames sometimes when i unplug it. No idea why it happened.  I posted code and can u check what i can do?
GetFrames() is the main function invoked by java every 10ms after initing.  Most time it stuck or crashed in wait for frame
`
av_CameraStatus CameraRealSense::GetFrames()
{
std::cout << "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" << std::endl;
//if (!isOpen) return RS_NoDev;
if (!isOpen) {
Status = AV_CameraStatus_Onlineing;
//if (!isInit)CameraStatus = AV_CameraStatus_NoInit;
if (!OpenCmd)Status = AV_CameraStatus_isClose;
else {
Sleep(500);
CameraRealSense::getInstance()->GetDevCount();
std::cout << "CameraRealSense::GetDevCount()=" << CameraRealSense::getInstance()->DevCount << std::endl;
if (CameraRealSense::getInstance()->DevCount <= 0)
Status = AV_CameraStatus_NoDev;
else {
std::cout << "dev count" << CameraRealSense::getInstance()->DevCount << std::endl;
CameraRealSense::getInstance()->OpenDev();
}
}
		return Status;
	}

	try {
		std::cout << "qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq" <<  std::endl;
		auto frames = pipe.wait_for_frames(5000);
		std::cout << "wwwwwwwwwwwwwwwwwwwwwwwwwwwwwww" << std::endl;
		while (pipe.poll_for_frames(&frames)) {};
		//std::lock_guard<std::mutex> lock(rfs.Cameramutex1);
		//
		if (!frames || frames.size() < 3)return AV_CameraStatus_NoFrame;
		fir = frames.get_infrared_frame();
		if (!fir)  return AV_CameraStatus_NoIrFrame;
		if (fir.get_data_size() < rfs.Ir.Size.width*rfs.Ir.Size.height)return AV_CameraStatus_NoIrFrame;
		fcolor = frames.get_color_frame();
		if (!fcolor)  return AV_CameraStatus_NoColorFrame;
		int n = (int)(fcolor.get_data_size() / 3);
		int n1 = rfs.Color.Size.width*rfs.Color.Size.height;
		if (n < (n1))return AV_CameraStatus_NoColorFrame;
		fdepth = frames.get_depth_frame();
		if (!fdepth)  return AV_CameraStatus_NoDepthFrame;
		n = (int)(fdepth.get_data_size() / 3);
		n1 = rfs.Depth.Size.width*rfs.Depth.Size.height;
		//rs2::video_stream_profile depth_profile = profile.get_stream(RS2_STREAM_DEPTH).as<rs2::video_stream_profile>();
		//n1 = depth_profile.height()*depth_profile.width();
		//if (n<(n1))return AV_CameraStatus_NoDepthFrame;
		//深度图滤波--------------------------------------------------------
		// 抽取滤波器
		//fdepth = dec_filter.process(fdepth);
		//
		//fdepth = depth2disparity.process(fdepth);
		// 空间滤波器
		//if (isOpenTemporal_filter)
		//fdepth.frame = spat_filter.process(fdepth.frame);
		// 时域滤波器
		if (Temporal_filter_enabled)
			fdepth = temp_filter.process(fdepth);
		//fdepth = hole_filter.process(fdepth);
		// If we are in disparity domain, switch back to depth
		//fdepth = disparity2depth.process(fdepth);
		rfsUpData();
		std::cout << "sssssssssssssssssssssssssss" << std::endl;
		ErrCount = 0;
	}
	catch (const std::exception &e) {
		std::cout << "GetFrames try  ErrCount= " << ErrCount << " " << e.what() << std::endl;
		if (ErrCount < 2)ErrCount++;
		else {
			DoClose();
			ErrCount = 0;
		}
		return AV_CameraStatus_NoFrame;
	}
	return AV_CameraStatus_OK;
}

`
void OpenDev() { 			//GetDevCount(); 			try { 				AR::debug() << "OpenDev111111111111111"; 				auto devs = ctx.query_devices(); 				AR::debug() << devs.size(); 				for (uint32_t j = 0; j < devs.size(); j++) { 					AR::debug() << "OpenDev222222222222222222222222"; 					//判断设备是否已经打开 					//bool isOpen = false; 					for (uint i = 0; i < devs.size(); i++) { 						//if (CameraList[i]->isOpen && CameraList[i]->SerialNumber == dev.get_info(RS2_CAMERA_INFO_SERIAL_NUMBER)) 						//	isOpen = true; 						AR::debug() << "OpenDev3333333333333333"; 						AR::debug() << "dev size in open dev   " << devs.size(); 						if (!isOpen && (AV_CameraStatus_OK == Open1(devs[j]))) 							AR::debug() << "OpenDev4444444444444444444"; 						break; 					} 					/*if (isOpen) continue; 					for (uint i = 0; i < CameraList.size(); i++) { 						if (!CameraList[i]->isOpen && AV_CameraStatus_OK == CameraList[i]->Open1(dev)) 							break; 					}*/ 				} 			} 			catch (const std::exception& e) { 				std::cout << "OpenDev Try " << e.what() << std::endl; 				/*for (auto&& dev : ctx.query_devices()) { 					dev.hardware_reset(); 					std::chrono::milliseconds(50); 				}*/ 			}
`av_CameraStatus Open1(rs2::device &dev) {
try
{
std::string mserial_number = dev.get_info(RS2_CAMERA_INFO_SERIAL_NUMBER);
std::string mname = dev.get_info(RS2_CAMERA_INFO_NAME);
//std::string mProductLine = "";
if (dev.supports(RS2_CAMERA_INFO_PRODUCT_LINE))
mProductLine = dev.get_info(RS2_CAMERA_INFO_PRODUCT_LINE);
			AR::debug() << "Find Camera : Name=" << mname << "    SerialNumber=" << mserial_number << "    ProductLine= " << mProductLine;
			//if (false == OpenCmd) return AV_CameraStatus_isClose;
			//AR::debug() << "OpenCmd";
			if (isOpen)return AV_CameraStatus_OnlineErr;
			if (mProductLine != "D400" && mProductLine != "SR300")return AV_CameraStatus_NoDev;
			//AR::debug() << "SR300 "<< OpenType;
			if (AR_OpenType_SerialNumber == OpenType && SerialNumber != mserial_number)return AV_CameraStatus_NoDev;
			//AR::debug() << "AR_OpenType_SerialNumber"<< OpenType;
			Name = dev.get_info(RS2_CAMERA_INFO_NAME);
			SerialNumber = dev.get_info(RS2_CAMERA_INFO_SERIAL_NUMBER);
			if (dev.supports(RS2_CAMERA_INFO_FIRMWARE_VERSION))
				FirmwareVersion = dev.get_info(RS2_CAMERA_INFO_FIRMWARE_VERSION);
			else FirmwareVersion = "";
			if (dev.supports(RS2_CAMERA_INFO_RECOMMENDED_FIRMWARE_VERSION))
				MinFirmwareVersion = dev.get_info(RS2_CAMERA_INFO_RECOMMENDED_FIRMWARE_VERSION);
			else MinFirmwareVersion = "";
			if (dev.supports(RS2_CAMERA_INFO_PHYSICAL_PORT))
				PhysicalPort = dev.get_info(RS2_CAMERA_INFO_PHYSICAL_PORT);
			else PhysicalPort = "";
			if (dev.supports(RS2_CAMERA_INFO_PRODUCT_ID))
				ProductID = dev.get_info(RS2_CAMERA_INFO_PRODUCT_ID);
			else ProductID = "";
			if (dev.supports(RS2_CAMERA_INFO_USB_TYPE_DESCRIPTOR))
				USB_Specification = dev.get_info(RS2_CAMERA_INFO_USB_TYPE_DESCRIPTOR);
			else USB_Specification = "";
			if (dev.supports(RS2_CAMERA_INFO_PRODUCT_LINE))
				ProductLine = dev.get_info(RS2_CAMERA_INFO_PRODUCT_LINE);
			else ProductLine = "";

			//AR::debug.i() << "名称 = " << Name;
			//AR::debug.i() << "序列号 = " << SerialNumber;
			//AR::debug.i() << "固件版本 = " << FirmwareVersion;
			//AR::debug.i() << "推荐固件版本 = " << MinFirmwareVersion;
			//AR::debug.i() << "设备连接的端口的唯一标识符 = " << PhysicalPort;
			//AR::debug.i() << "USB描述符中报告的产品ID = " << ProductID;
			////AR::debug.i() << "固件获取日志的命令 = " << dev.get_info(RS2_CAMERA_INFO_DEBUG_OP_CODE);
			////AR::debug.i() << "高级模式 = " << dev.get_info(RS2_CAMERA_INFO_ADVANCED_MODE);
			////AR::debug.i() << "USB描述符中报告的产品ID = " << dev.get_info(RS2_CAMERA_INFO_PRODUCT_ID);
			//AR::debug.i() << "USB类型 = " << USB_Specification;
			//AR::debug.i() << "产品系列 = " << ProductLine;
			////AR::debug.i() << "ASIC 序列号 = " << dev.get_info(RS2_CAMERA_INFO_ASIC_SERIAL_NUMBER);

			//if (isOpen) return RS_Ok;
			//AR::debug() << "rs2::config cfg" ;
			 if (mProductLine == "SR300")
			{
				rfs.Color.Framerate = 10;
				rfs.Depth.Framerate = 10;
				rfs.Ir.Framerate = 10;
			}
			rs2::config cfg;
			if (rfs.Color.Enable)
				cfg.enable_stream(RS2_STREAM_COLOR, -1, rfs.Color.Size.width, rfs.Color.Size.height, RS2_FORMAT_BGR8, rfs.Color.Framerate);
			if (rfs.Depth.Enable)
				cfg.enable_stream(RS2_STREAM_DEPTH, -1, rfs.Depth.Size.width, rfs.Depth.Size.height, RS2_FORMAT_Z16, rfs.Depth.Framerate);
			if (rfs.Ir.Enable)
				cfg.enable_stream(RS2_STREAM_INFRARED, 1, rfs.Ir.Size.width, rfs.Ir.Size.height, RS2_FORMAT_Y8, rfs.Ir.Framerate);
			cfg.enable_device(SerialNumber);
			//rs2::pipeline p;
			//pipe = p;
			//AR::debug() << "profile = pipe.start(cfg)";
			AR::debug() << "Color,width:"<< rfs.Color.Size.width<<" height:"<< rfs.Color.Size.height<<"framerate:"<< rfs.Color.Framerate;
			AR::debug() << "Depth,width:" << rfs.Depth.Size.width << " height:" << rfs.Depth.Size.height << "framerate:" << rfs.Depth.Framerate;
			AR::debug() << "Ir,width:" << rfs.Ir.Size.width << " height:" << rfs.Ir.Size.height << "framerate:" << rfs.Ir.Framerate;
			try
			{
				pipe.get_active_profile();
			}
			catch (std::exception& e) {
				profile = pipe.start(cfg);
				//Set_Para();
				AR::debug() << "Camera Open OK ";
			}
			AR::debug() << "nnnnnnnnnnnnnnnnnnnnnnnnnnnnnn";
			isOpen = TRUE;
			return AV_CameraStatus_OK;
		}
		catch (std::exception &e)
		{
			AR::debug() << "Camera Open1 try " << e.what();
			DoClose1();
			return AV_CameraStatus_OnlineErr;
		}`

My knowledge of Java programming is admittedly limited but I will do my best to be of assistance.
As your fiber cable connection mostly works with the RealSense Viewer tool, it seems unlikely that the cable is the problem.
Does it make a difference if you remove the 5000 from the brackets of wait_for_frames please?
I note that after the wait_for_frames instruction, you have a poll_for frames instruction.
while (pipe.poll_for_frames(&frames)) {};
If your application is a single-camera one then it is recommended to use wait_for_frames.  The wait_for_frames instruction waits for a complete frame to be delivered before providing it, whilst poll_for_frames (which is suited for multiple-camera applications) does not wait and supplies new frames immediately even if there is a chance that the frames are incomplete.  It can also be necessary to manually control when the CPU is put to sleep and for how long when using poll_for_frames, otherwise the CPU's usage could max out at 100%.  More information about this can be found at https://github.com/IntelRealSense/librealsense/issues/2422#issuecomment-423254709

tried removing 5000 from wait_for_frames and removing pipe.poll_for_frames from code. still sometimes stuck in wait_for_frames or java just quit the program when I unplug.

Instead of unplugging the camera to quit the program, are you able to exit out of the Java program with Ctrl-C instead?

No. How can this help me

I wondered whether exiting the application with Ctrl-C, if possible to do so, might provide a cleaner way of shutting down the program than unplugging the camera.

Hi @LLY13  Do you require further assistance with this case, please?  Thanks!

No thanks.  Could u give me a demo of simplest unplug/replug code  I can test the problem is code or other last

USB connection and disconnection events can be listened to in C++ with the set_devices_changed_callback instruction, which is discussed with a code example at https://github.com/IntelRealSense/librealsense/issues/9287

One question. Now when i unplug the usb,  after pipe.wait_for_frames(1000)   throws exception for 3 times. I'll call pipe.stop(). Is this a correct way or should i do it? if not, what code i should have after that

Yes, that would be a reasonable way to approach dealing with an exception.

Hi @LLY13  Do you have an update about this case that you can provide, please?  Thanks!

Hi @LLY13  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


When extracting, don't use filemode() on windows

Windows doesn't give realistic results from filemode(), so let's avoid using it to try and pick up umask-style environmental information, and just use the mode within the tarball.

Alright got the tests passing locally.  :)


Reactivity problem with

Version
2.5.2
Reproduction link
https://jsfiddle.net/50wL7mdz/387013/
Steps to reproduce
data: { some_var: [] },
mounter () { this.some_var = [1, 2, 3] }

What is expected?
The some_var should be reactive. It is not. If I remove the  or even put mode="in-out" it solves the problem.
What is actually happening?
Variable non reactive

It seems to work when you move the watcher to the instance where the array is changing. Not sure what you are trying to do but please, next time consider using the forum, the Discord server or StackOverflow for questions first. But feel free to come back and open an issue if it turns out to be a bug 🙂


Stack traces inside Mono do not show file/line numbers, mono should be run with --debug flag

Bugsquad edit: See #14822 for a clear description of the issue and how to fix it.

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10
Godot 3.0 beta 1
Issue description:

When a exception occurs in a C# script, the debugger doesn't display very helpful information, such as the name of the script that caused the error, and the line where it happened.
Steps to reproduce:
Add a C# script to any node and try to produce a NullReferenceException in any Godot callbacks.
E.g.,
in _Ready(),
string nullStr = null;
int i = nullStr.Length;
When you run the code, the debugger will tell you that a NullReferenceException has been raised, but it won't tell you where it happened.
Link to minimal example project:

cc @neikeq :)

You mean the Godot editor debugger, right? We need to implement ScriptLanguage::debug_get_current_stack_info() and use StackTrace to get the StackFrames.

Ok so. This actually does work perfectly fine.
... On MacOS.

@PJB3005 I guess you mean #14822 :) This is a different one.

oh I only see it now, this one is about the menu cutting off anything except the exception header. Right.
Might wanna remove the thing about --debug because stack traces work either way in .NET. The file and line numbers are the difference.

I tried it with printout disabled but no I wasn't, had fps printout off too, I also tried turning off warning messages, but same result.  Making a video now.


GetMessagesFailedException: undefined offset: 0 when querying messages

Hi again @Webklex
I've updated to 2.5 and the previous $encryption error has been resolved, thanks again for that.
I moved on to another error case I have come across while trying to get this update out.
Given the following connection details:
[
  "username" => "xxxxxx",
  "password" => "xxxxxx",
  "host" => "xxxx",
  "port" => 993,
  "encryption" => "ssl",
  "protocol" => "imap",
  "validate_cert" => 0,
]

I'm able to establish a connection, and also get the inbox folder with ->getFolderByPath('Inbox');

However, when I want to query the emails with $messages = $inbox->query()->all()->limit(10)->get(); I get an undefined offset 0 error coming from the ImapProtocol.php class, line 585
It seems to stem from:
 if (count($items) == 1) {
                if ($tokens[2][0] == $items[0]) {
                    $data = $tokens[2][1];
...

It doesn't feel like I gave you sufficient information here to reproduce, but I am hoping that knowing where the error comes from you might have an idea why this might be happening?
This folder was syncing fine on 1.x version, upgrading to 2.x has now resulted in this error.
Please let me know if you need me to provide some more information on this one.
Regards
EDIT:
I did some dumping, the value of $items at that stage is:

and the value of $tokens is

from the above the error doesn't seem to be line 585 as the logs state, Im doing some more investigation and will update this issue as I find information
@Webklex see below a screenshot of the error:

The closest I've been able to narrow this down is to this block in the Query.php class, around line 228:
 if ($this->getFetchBody()) {

            $contents = $this->client->getConnection()->content($uids, "RFC822", $this->sequence == IMAP::ST_UID);
        }

The getConnection call works, it seems like ->content is where the error gets thrown.
I've attached the stacktrace as well:
stacktrace.txt

Hi @ricus-zero2one ,
thanks for your detailed report.
Please add the following in line ImapProtocol@585:
if (!isset($items[0]) || !isset($tokens[2][0])){
    dump($items);
    dd($tokens);
}

..perhaps this will give us some more clues.
Best regards,

Hi @Webklex
I've added that in with the below results:

Does this help you identify the reason?

It looks like the message 154 doesn't have any content. I've never seen this before....

Hmmm
I checked the two other users in that company they all have the same error with different message number.

@Webklex I checked other imap folders and they give the same error so doesn't seem to be related to a specific email. What is also strange is that version 1.x is syncing this folder without a problem on production, only difference is that on production we are using getFolder and on version 2.x we are using getFolderByPath

Hi @ricus-zero2one ,
v1 uses https://www.php.net/manual/en/book.imap.php , v2 "speaks" directly with the mail server. This enables features such as oAuth and IDLE.
I'm having a hard time so see a potential problem without the ability to reproduce this behavior.
Best regards,

I know it's extremely difficult to get to the bottom of issues like this if it can't be reproduced. I'm going to try and get this company to set up a test mailbox and hopefully the error can be reproduced there.
I'll give you an update as soon as I have more info

Hi @ricus-zero2one ,
does this problem still exists? If so, can you provide an update? :)
Best regards,

Hi I can confirm this is happening ( https://github.com/Webklex/php-imap/issues/98#issuecomment-770862020 )
In the Code here : https://github.com/Webklex/php-imap/blob/master/src/Connection/Protocols/ImapProtocol.php#L624
$tokens[2][$uidKey] is an empty Array [] and it break the code with error TypeError : Illegal offset type


Error in IE "google is undefined"

also apperas in  your demo: http://codepen.io/defvayne23/full/EVYGRw/

Its because google maps api didn't loaded yet.
Wrap whole code into
if(typeof google!=='undefined'){ Here code of SVGMarker }


Inline feeling lucky

Fix #571
This works on the apps-dev server, but I'm noting that tests are not passing. I'll try updating version of FormFyxer to see if that resolves it.

I'm noting that tests are not passing. I'll try updating version of FormFyxer to see if that resolves it.

Good catch. It seems like the FormFyxer tests were only testing when users had en_web_core_lg, but that library isn't installed by default (since on the server we use the tools.suffolklitlab.org instead). I was about to start trying to get it to work with sm, but our trained data isn't available in that size, so I don't think it'll work. We should probably just add this line to the requirements.txt:
en-core-web-lg @ https://github.com/explosion/spacy-models/releases/download/en_core_web_lg-3.5.0/en_core_web_lg-3.5.0-py3-none-any.whl

Looks like GitHub Actions are degraded; https://www.githubstatus.com/ unsure when they'll be consistent again. Would be nice for the tests to pass, but if you'd rather merge before that's fine.


Create 0078-use-aws-appconfig-feature-flags.md

This has been superseded by https://github.com/transcom/mymove-docs/pull/365 and should not be merged.


data_utils.py line 45, where are the spec.pt files?

I dont have file like it, how to generate them?
Get exception file not found.

those spec.pt files are generated on the fly during the first epoch of training.

Had to run single GPU first thanks you

Yep, until all spect.pt files are generated, the training must be run on a single GPU


Fixing Magnum functional tests with Fedora Atomic

ahh cool, can we have a round with want_magnum = 1 in the CI to see it? The current gating job have this field empty


How do I get the event "Change Characters" to work?

I don't know how the event works, and I am charting a song where multiple opponents sing.


Updated @rec

Better able to identify the indexing variable
Meaningful error messages
Does not assume it's a TSeries - works with multiple indexes

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   47.01%   47.01%
=======================================
  Files           4        4
  Lines         285      285
=======================================
  Hits          134      134
  Misses        151      151

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae3cb35...dea82f5. Read the comment docs.


Added shift operations in Bitwise Calculator

Fixes Issue🛠
Closes #648
Description👨💻
In this PR, I fixed an issue in the bitwise calculator related to the NOT operation by updating the calculation formula. Additionally, I added two new bitwise operations: Left-Shift and Right-Shift.
Type of change📄

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

How this has been tested✅
The changes were tested using various input values to ensure correct functionality
Checklist✅

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added demonstration in the form of GIF/video file
[X] I am an Open Source Contributor

Screenshots/GIF📷
Before :

After :

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳 @Uday2902


Defer accessing fetchResults settings

Issue
Setting custom fetchResults prior to obtaining Photos permission from the user results in null AssetCollections, and thus will present an empty ImagePickerController the first time it is presented.
For instance
let imagePickerVC = ImagePickerController()
imagePickerVC.settings.fetch.album.fetchResults = [PHAssetCollection.fetchAssetCollection(with: .album, subtype: .albumRegular, options: PHFetchOptions())]
imagePickerVC.presentImagePicker(...

will have the effect of presenting an empty picker the first time after permissions are first granted.
Proposed solution
Defer the access of the fetchResults settings by using a function rather than a var.
Note
There are other ways of solving this, such as adding an onAuthorization closure to the presentImagePicker call and allowing settings to be passed in there.

Sure makes sense. Wouldn't some of the examples also need to be updated?


Link to dataset on Zenodo

Refs https://github.com/LiberTEM/LiberTEM/issues/1069
Also fix parameter name and include notebook in documentation
Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[N/A] I have added a changelog entry for my contribution
[x] I have added/updated documentation for all user-facing changes
[N/A] I have added/updated test cases

Reviewer Checklist:

[ ] /azp run libertem.libertem-live-data passed

/azp run libertem.libertem-live-data


Enhance visualization of  credentials in Public Profile view

As a company want to have my Public Profile more like the "Facebook profile of my company": Flat design, easy to read. Currently it is a bit bulky.
Idea:

ACs:

Rendering should still work in a generic way for indy-style credentials

@domwoe You mentioned, a table is needed here if we have more than one credential type? Couldn't we simply "flatten" such a table showing the type + label /name in the heading like in the wireframe above ?

Yeah, thats what I meant with "oder wir bauen noch einen Credential View analog zum org profile. Links Credential Type rechts der Inhalt. " For some reason your picture didn't show up yesterday in Teams.


964 Times for Exposed and INS instead of SerialInterval and IncubationTime

Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:

Removed the Parameters SerialInterval and IncubationTime
Now, the times for E and INS compartments have to been given directly

If need be, add additional information and what the reviewer should look out for in particular:

//

Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author

[x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
[x] New code adheres to coding guidelines
[x] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[x] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
[x] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
[x] Proper attention to licenses, especially no new third-party software with conflicting license has been added
[ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

[ ] Corresponding issue(s) is/are linked and addressed
[ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
[ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
[ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

One more thing: The two parameters SerialInterval and IncubationTime are still used in the file cpp/tests/test_model.cpp. This should be changed.

One more thing: The two parameters SerialInterval and IncubationTime are still used in the file cpp/tests/test_model.cpp. This should be changed.

This test is independent from the type of the model. My idea was therefore to let the test exist in the current form to demonstrate that any model can be used here.


Side Issue - SSTK Docker?

It's obviously beyond this work/repo responsibility, but I had such a great experience with your colab notebook - unless I got the result and tried to view it using smart scene toolkit - and it is hard to install and the existing Dockerfile fails to compile. Can you share your docker image, by any chance>

Hi @Casyfill
I've never used the docker file with smart scene toolkit. But, the instructions for directly installing it on the host machine works fine. Can you try that approach?

Thanks for the quick response. I tried and .build.sh fails for me
2609 verbose stack Error: command failed
2609 verbose stack     at ChildProcess.<anonymous> (/Users/philippk/.nvm/versions/node/v16.5.0/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/index.js:64:27)
2609 verbose stack     at ChildProcess.emit (node:events:394:28)
2609 verbose stack     at maybeClose (node:internal/child_process:1067:16)
2609 verbose stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
2610 verbose pkgid<EMAIL_ADDRESS>2611 verbose cwd /Users/philippk/Dropbox/se_projects/July21_Hackweek/FloorPlanner/sstk
2612 verbose Darwin 20.5.0
2613 verbose argv "/Users/philippk/.nvm/versions/node/v16.5.0/bin/node" "/Users/philippk/.nvm/versions/node/v16.5.0/bin/npm" "install"
2614 verbose node v16.5.0
2615 verbose npm  v7.19.1
2616 error code 1
2617 error path /Users/philippk/Dropbox/se_projects/July21_Hackweek/FloorPlanner/sstk
2618 error command failed
2619 error command sh -c node getdata.js && npm run bootstrap
2620 verbose exit 1

I see. Looking at above, it seems the node version you use is different.  The SSTK instructions suggest to use 10.23.2. Refer the following step by SSTK
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bash source ~/.bashrc nvm install v10.23.2

Thanks!
I tried that and still have troubles with many packages, dependence on obsolete py27, etc. I will try to solve it but for now I made plan2scene run, but have no way to see/valuate the outcome since I can't make sstk to work :sad:. Would be awesome to build some dockerized versions for all those awesome tools in the future!

Hi @Casyfill
Can I know which OS you are using?
I tested at my end using a Ubuntu 20.04 machine with a Python 3.8 conda environment. The SSTK installation works fine.
Here are the exact commands I used.
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bash
source ~/.bashrc
nvm install v10.23.2

git clone https://github.com/smartscenes/sstk.git

cd sstk
./build.sh
cd server
./run.sh

Hi @Casyfill
The following commands should work if you are using docker. Here, I have directly used an Ubuntu 20.04 image instead of writing a docker file.
I tested the following using my local docker.
docker run -it -p 8010:8010 ubuntu:20.04

apt-get update
apt-get install -y git curl
apt-get install -y build-essential libxi-dev libglu1-mesa-dev libglew-dev libvips

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bash
source ~/.bashrc
nvm install v10.23.2

git clone https://github.com/smartscenes/sstk.git
cd sstk
./build.sh
cd server
./run.sh

THanks! That did work (finally!)
But I can't make it to show anything aside from initial buttons, and
nothing happens when I upload a scene.json from Plan2Scene :-(

Hi @Casyfill
I managed to get things running in docker by running the following sequence of commands.
docker run -it -p 8010:8010 ubuntu:16.04
apt-get update
apt-get install -y curl git build-essential libxi-dev libglu1-mesa-dev libglew-dev libvips
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bash
source ~/.bashrc
nvm install v10.23.2

git clone https://github.com/smartscenes/sstk.git
cd sstk
./build.sh
node getdata.js
cd client
npm install
npm run build
cd ../server
./run.sh

Access http://localhost:8010/scene-viewer.html
I tested the above in https://labs.play-with-docker.com/ and got things to work.
If the above doesn't work, please send me a copy of the errors printed in the developer console of the browser.

Thanks, This finally made it work! Thank you so much!
Thanks for all your help and the project itself, btw!
I am working for StreetEasy, it's Zillow's NYC brand - we have tons of
floorplans and photos, and I hope to try to digitize them into 3d.
Your work looks very promising and useful for that. I am just on internal
hackathon right now, but theoretically, we could share a dataset if that
would be useful for your research in the future.
On Fri, Jul 16, 2021 at 12:34 AM Madhawa Vidanapathirana <
@.***> wrote:

Hi @Casyfill https://github.com/Casyfill
I managed to get things running in docker by running the following
sequence of commands.
docker run -it -p 8010:8010 ubuntu:16.04
apt-get update
apt-get install -y curl git build-essential libxi-dev libglu1-mesa-dev libglew-dev libvips
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bashsource ~/.bashrc
nvm install v10.23.2
git clone https://github.com/smartscenes/sstk.gitcd sstk
./build.sh
node getdata.jscd client
npm install
npm run buildcd ../server
./run.sh
Access http://localhost:8010/scene-viewer.html
I tested the above in https://labs.play-with-docker.com/ and got things
to work.
If the above doesn't work, please send me a copy of the errors printed in
the developer console of the browser.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/3dlg-hcvc/plan2scene/issues/27#issuecomment-881169429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUNHJOHUOVFTQKC6NSILC3TX6ZEXANCNFSM5AMGQEBA
.

(and Zillow at large works on 3d scanning / capture as well) :-)
On Fri, Jul 16, 2021 at 10:41 AM Philipp Kats @.***> wrote:

Thanks, This finally made it work! Thank you so much!
Thanks for all your help and the project itself, btw!
I am working for StreetEasy, it's Zillow's NYC brand - we have tons of
floorplans and photos, and I hope to try to digitize them into 3d.
Your work looks very promising and useful for that. I am just on internal
hackathon right now, but theoretically, we could share a dataset if that
would be useful for your research in the future.
On Fri, Jul 16, 2021 at 12:34 AM Madhawa Vidanapathirana <
@.***> wrote:

Hi @Casyfill https://github.com/Casyfill
I managed to get things running in docker by running the following
sequence of commands.
docker run -it -p 8010:8010 ubuntu:16.04
apt-get update
apt-get install -y curl git build-essential libxi-dev libglu1-mesa-dev libglew-dev libvips
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bashsource ~/.bashrc
nvm install v10.23.2
git clone https://github.com/smartscenes/sstk.gitcd sstk
./build.sh
node getdata.jscd client
npm install
npm run buildcd ../server
./run.sh
Access http://localhost:8010/scene-viewer.html
I tested the above in https://labs.play-with-docker.com/ and got things
to work.
If the above doesn't work, please send me a copy of the errors printed in
the developer console of the browser.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/3dlg-hcvc/plan2scene/issues/27#issuecomment-881169429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUNHJOHUOVFTQKC6NSILC3TX6ZEXANCNFSM5AMGQEBA
.

All the best @Casyfill. Happy to discuss further. How can we stay in touch?
My LinkedIn: https://www.linkedin.com/in/madhawav/


Certain images are flickering or loading slowly

Bug in the equality implementation? Not sure yet. Causing problems in wonderous.

actually we're hitting the cache, woops, but something else is wrong. I'll just have to bisect. Effect is clipped images are flickering in Skia/Impeller

Here is a video that is showing the issue. As you scroll the images disappear, but then reappear once you stop scrolling.
https://user-images.githubusercontent.com/8975114/224456070-3c66e688-86ce-43d5-bdfc-735f166d058a.MP4

I have bisected this to 57c7aa53c178f722aec19a76a60552e78ad09997 fyi @andrewkolos


Enable functionCallEvaluationTest in debugger

ExpressionEvaluationNegativeTest.functionCallEvaluationTest is temporary disabled via dce6d5c due to failing. Need to enable it.

Closing with  #31898


Missing delete button

Hi :-)
I could be nice with a delete button for contacts and certificates and more :-)

This has been resolved and has now been released.


something wrong with Python3.13

Something wrong with python3.13 during the installation.
    Running `/tmp/pip-install-n865frss/tiktoken_bc7466ab9f864324ab86c741a2ff68cf/target/release/build/pyo3-ffi-1f3bc90bf87c8381/build-script-build`
  error: failed to run custom build command for `pyo3-ffi v0.20.3`

  Caused by:
    process didn't exit successfully: `/tmp/pip-install-n865frss/tiktoken_bc7466ab9f864324ab86c741a2ff68cf/target/release/build/pyo3-ffi-1f3bc90bf87c8381/build-script-build` (exit status
    --- stdout
    cargo:rerun-if-env-changed=PYO3_CROSS
    cargo:rerun-if-env-changed=PYO3_CROSS_LIB_DIR
    cargo:rerun-if-env-changed=PYO3_CROSS_PYTHON_VERSION
    cargo:rerun-if-env-changed=PYO3_CROSS_PYTHON_IMPLEMENTATION
    cargo:rerun-if-env-changed=PYO3_PRINT_CONFIG
    cargo:rerun-if-env-changed=PYO3_USE_ABI3_FORWARD_COMPATIBILITY

    --- stderr
    error: the configured Python interpreter version (3.13) is newer than PyO3's maximum supported version (3.12)
    = help: please check if an updated version of PyO3 is available. Current version: 0.20.3
    = help: set PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 to suppress this check and build anyway using the stable ABI
  warning: build failed, waiting for other jobs to finish...
  error: `cargo rustc --lib --message-format=json-render-diagnostics --manifest-path Cargo.toml --release -v --features pyo3/extension-module --crate-type cdylib --` failed with code 101
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for tiktoken
Failed to build tiktoken
ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (tiktoken)

try installing latest version of lpw in a fresh virtualenv and report the status


Confusing compiler diagnostics: generic parameter 'Self' could not be inferred

Imported from JIRA, filed by Brennan Saeta https://bugs.swift.org/browse/TF-313
There is a confusing compiler error message when compiling the code at: https://github.com/tensorflow/swift-apis/pull/23/commits/d6fe3589c905989f4a4529fa56c05c94f7f6cae8
saeta@saeta:~/src/s4tf/tensorflow-swift-apis$ swift test
Compile Swift Module 'DeepLearning' (8 sources)
/home/saeta/src/s4tf/tensorflow-swift-apis/Sources/DeepLearning/Trainer.swift:35:37: error: generic parameter 'Self' could not be inferred
            optimizer.update(&model.allDifferentiableVariables, along: {grad}model)

The problem is that {{
{grad}
model}} is of the wrong type, and does not correspond

Related to: TF-299 Pre-built supervised training loops


isBackRoute not working as expected

Current behavior

Change category but products not change if the category page is visited.
Expected behavior

Category page should display correct products which belongs the category.
Steps to reproduce the issue

Visit A category page.
Visit B category page.
Visit A category page and the products not changed.

Repository

Can you handle fixing this bug by yourself?

[ ] YES
[ ] NO
[x] Not Sure

Which Release Cycle state this refers to? Info for developer.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[x] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Chrome 81.0.4044.113
OS: MacOS 10.15
Node: v10.19.0
Code Version: v1.11.2

Additional information

@SDLyu hey, thanks for reporting this bug. It will be fixed in next hotfix. You can check it here http://next.storefrontcloud.io/ and here is same issue https://github.com/DivanteLtd/vue-storefront/issues/4201


FastJson 1.2.37 "unclosed.str" issue with valid input

Note the issue only captured on v1.2.37.
Given two strings below:
String strOk = "{\"v\": 111}";
String strBad = "{\"v\":111}";

Note the only difference is there is a whitespace behind : in strOk.
parsing strOk is fine:
Foo ok = JSON.parseObject(strOk, Foo.class);

This will cause the unclosed.str issue:
Foo bad = JSON.parseObject(strBad, Foo.class);

Screenshot:

The full code to reproduce the issue:
https://gist.github.com/greenlaw110/3d0fc68a569565bdf1c9056ef25ab1fb

bug fixed, please try the last version. https://github.com/alibaba/fastjson/releases/tag/1.2.38


Add radius as conversion (scaling) instead of adding the scaled data in FicTrac

This was a suggestion from @CodyCBakerPhD in our  last conversion which I think makes sense. We were adding the data scaled which increases the error if the measurement of the radius is not very precise.
This method keeps both the radius, the right units and the original data without imprecisions.
I modified the test to account for this.

Elegant separation of source data and utilization of existing mechanisms/attributes on the neurodata classes!
I will mention one more thing for a future improvement, dependent on resolution of https://github.com/NeurodataWithoutBorders/pynwb/pull/1766
For this kind of thing (any time there are radial + linearized interpretations of data) it is common to include two separate time series for each interpretation (each named clearly for easy identification), since even now the detail of the original radial data could be obscured by the conversion factor - the most common case of this is eye tracking, where we might include both the angle of the pupil relative to the target on the screen, and then the processed estimate of that x/y position given the angles - but this seems similar enough
This might seem like duplication, and it is, which is why I don't advocate for it right at the moment - but once the issue is resolved it should be possible to internally inter-link the data field of the two series so that the data is only written once