treeview: get_selected returns a model, rename the variable to reflect this

Signed-off-by: Silvio Fricke<EMAIL_ADDRESS>

Hi, thanks for your PR (the signed-off is useless by the way)! I don't find it better, but since I'm the one who wrote it, my opinion is certainly biaised.
cc @gkoz

I guess it's difficult to argue against making the name match the type.

thanks!


Days Lost to being Blocked Graph - potential error

Hi Nick, I think I might have found an error with the Days Lost to being Blocked Graph. Below one example, do please let me know if you need more?
Data table shows cycle time as 6 vs Blocked graph shows cycle time as 13.

Data table shows Number of Days blocked as 6, but it is 2.

Fixed now :)

Thank you Nick! :)
What did you do so I can check if I need to make any changes to the 'Resolved Toggle' template?

You just need to change the tooltips for cycle time to be max rather than
sum:
[image: image.png]
On Mon, Feb 5, 2024 at 10:01 AM jenniferrosemitchell21 <
@.***> wrote:

Thank you Nick! :)
What did you do so I can check if I need to make any changes to the
'Resolved Toggle' template?
—
Reply to this email directly, view it on GitHub
https://github.com/nbrown02/FlowViz/issues/118#issuecomment-1926613671,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHACM2TW4HW3SJGCBRICOILYSCUY5AVCNFSM6AAAAABCW6MVYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRWGYYTGNRXGE
.
You are receiving this because you commented.Message ID:
@.***>


PermissionsDispatcher class removed when running 'app' and causes build failure

Overview

When trying to run the 'app' auto generated configuration, the PermissionsDispatcher class is removed and isn't generated in time for the build to succeed.

Expected

Class either shouldn't be removed, or should be regenerated in time for the build to succeed

Actual

Class is removed and build fails

Environment

2.3.1
n/a; build doesn't succeed.
Latest Windows 10 build, latest Android studio build

Reproducible steps

Import example project into intellij, build to generate permissions dispatcher, then try to run 'app'

What do you mean ”remove”？ Have you ever seen XxxPermissionsDispatcher classes?
Have you gone through ISSUE_TEMPLATE's FAQ?
Before you add the issue, please make sure to read over the following Frequently Asked Questions:

**"XxxPermissionsDispatcher class is not generated"**

- Did you add `@RuntimePermissions` to your class, and `@NeedsPermission` to your method?
- Did you try a Rebuild? (Sync is not Rebuild!)
- Don't mix `apt` and `annotationProcessor`!
- If you're in Kotlin, use `kapt`!
- If you're using Realm 1.x., please consider upgrading to 2.x (refer to Issue #270: https://github.com/hotchemi/PermissionsDispatcher/issues/270)
- If you checked all these steps, and the generated classes are still not showing up, then attach your Activity/Fragment class, and build.gradle.

Yes, I've looked through the FAQs
Also, what I mean by remove is that the class is there before the build, and I can reference the methods inside of it. When I start the build, the references to the class go red, and the build fails because it can't resolve those references.

Have you used other annotation processing library? Like ButterKnife, dagger, or AndroidAnnotations.

Oops, I should've ask this one first...is your Android Studio enabled to use anntation processing?
http://stackoverflow.com/questions/38642712/enable-annotation-processors-option-in-android-studio-2-2

I should have noted this before. When I just build the project, the class is generated. So annotation processing does work. If I manually go to Build -> Generate APK and install it, it works fine. It's just running this particular configuration where it breaks, and this is a big issue for me because my only seeming alternative is to use a way of debugging my app that is much less than optimal

Isn't that the same issue with above StackOverFlow?

Changing that doesn't seem to do anything. Look, this is what happens when I try to run the app configuration (Bearing in mind that before running it these references were valid and recognized by the IDE)
http://prntscr.com/ec1y5v

Could you post Activity and build.gradle or give us minimum sample project?

https://gist.github.com/Redrield/20a0594306db52c8899b39f580b9513a

Could you try https://github.com/shiraji/PD-281 ?

That worked fine. What did you do different?

Check second commit. you missed kotlin-kapt
Thanks for verifying PD/Android Studio/kapt works fine in Windows environment!👌 (I don't have it!!!)

Aah! Yep, that's why. Thanks!


rootly logo

hi folks!
if you would like your logo to appear a bit bigger and fill the space in the pulumi registry you can use logoUrl="" on this line
https://github.com/rootlyhq/pulumi-rootly/blob/main/provider/cmd/pulumi-resource-rootly/schema.json#L14
as then it will use this logo https://github.com/pulumi/pulumi-hugo/blob/master/themes/default/static/logos/pkg/rootly.svg
which has the extra white space stripped out
or if yall have a link to your logo in svg form with the extra white space removed that will also work
no worries if yall don't want to make this change, only wanted to let ya know.

Thanks. I've updated it to use that logo.


Error when running npm run dev

Case

BUG

Issue
Error when running npm run dev
Info

Operating System: ubuntu 16.04 64 bit
Node-Version: v8.0.0

Reproduce

clone the repo
cd to path
run npm install
run npm run dev
added nvm to change the version (used v8.5.0, v8.0.0,)
I have the node installed, then also this issue persists

npm run dev

<EMAIL_ADDRESS>predev /home/anoobbava/ror/best-resume-ever
check-node-version --node ">= 8.0.0"

/home/anoobbava/ror/best-resume-ever/node_modules/semver/semver.js:305
throw new TypeError('Invalid Version: ' + version);
^
TypeError: Invalid Version: 0.22
at new SemVer (/home/anoobbava/ror/best-resume-ever/node_modules/semver/semver.js:305:11)
at SemVer (/home/anoobbava/ror/best-resume-ever/node_modules/semver/semver.js:298:12)
at /home/anoobbava/ror/best-resume-ever/node_modules/check-node-version/index.js:112:33
at module.exports (/home/anoobbava/ror/best-resume-ever/node_modules/map-values/index.js:9:18)
at /home/anoobbava/ror/best-resume-ever/node_modules/check-node-version/index.js:106:22
at end (/home/anoobbava/ror/best-resume-ever/node_modules/run-parallel/index.js:16:15)
at done (/home/anoobbava/ror/best-resume-ever/node_modules/run-parallel/index.js:20:10)
at each (/home/anoobbava/ror/best-resume-ever/node_modules/run-parallel/index.js:26:7)
at /home/anoobbava/ror/best-resume-ever/node_modules/run-parallel/index.js:36:43
at /home/anoobbava/ror/best-resume-ever/node_modules/check-node-version/index.js:53:14
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>predev: check-node-version --node ">= 8.0.0"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>predev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!  I'm using Ubuntu 16.04 too.

@GabrielCoelho  how to remove this predev ?, Please update, i have limited knowledge with node

I have to apologize myself in advance because my English it isn't that good. Hope you'll understand all that I'll say.

in package.json you have the scriptssection. There you'll find the "predev": "check-node-version --node \">= 8.0.0\"", -> line 15. All that i've done was erase this line and try to run again.
So, my package.json file it's now:
"scripts": {
    "docs": "node build/build.js",
    "docs:serve": "cd docs/ && ws --port 8080 --rewrite '/best-resume-ever/* -> /$1'",
    "dev": "node build/dev-server.js",
    "start": "node build/dev-server.js",
    "pdf": "node scripts/export.js",
    "preview": "node scripts/preview.js",
    .
    .
    .

The predev-script checks if you node-version if compatible with this project. If it's not, you should update node to the version mentioned in the readme which is 8.0.0 oe higher.
It looks like this scriot is broken so removing the predev is a temporary fix


[CI] Windows向けのCIを追加

Based on the work of @k-taro56, swift-actions/setup-swift turned out to be not supporting Swift 5.7 and later in Windows. It seems we can use https://github.com/compnerd/gha-setup-swift instead.

Better PR: #116


[Bug] Update server from remote client

on remote client, connecting to a server, the update dialog controller was using the current localhost client then getting a null server version

fixed in main for 3.10.1

Ah, thank you so much. That was giving me a headache.

Fixed with 3.10.1


Adds most CRUD functionality to services resource

Adds views to list existing services, create new ones and update existing
ones. It does not add the ability to delete an existing service as this
is not yet needed.
In doing this a few things have changed.
I have changed the error handlers to return JSON and removed the error
handler html templates. I have done this because at the moment we are
building a JSON API, so our error responses should also be in JSON. I
have also replaced the root view with one that returns a JSON object
that links to the /services resource and removed it's template. We have
an intention to build a hypermedia API, part of that is clients being
able to discover the resources they can interact with on their own.
I have refactored the tests to pull application tests into their own
package and split tests on the /services resource out into their own
module. I've done this to better reflect the structure of the
application in the tests and because the prevous test module was getting
quite large. One strange thing I have done is to use a mixin to provide
some common tests to each endpoint that accepts JSON data. We will see
if this is a model that works well.
I have NOT done any validation of the services JSON itself. We have
another story going on to validate against a JSON schema.
Also refactors authentication so that it is required on all views rather than being added explicitly to each view. We require authentication on all views so adding it explicitly creates a potential for something to forget.

The Python 3.4 Travis build hung for ten minutes and was terminated, though the 2.7 run was fine.

Closed in favour of #10


Loss / metric curves

Could the authors or someone else who has successfully reproduced the training of MotionGPT share your train loss and R_TOP_3 (or R_TOP_1/R_TOP_2) curves so I can see if my training is going as it should be? After about 20 epochs, R_TOP_{1/2/3} are basically flat (R_TOP_3 < 0.1), though the training loss is decreasing.

I am facing the same problem.

I found this is due to the multi-GPU during training.
Change
https://github.com/OpenMotionLab/MotionGPT/blob/fac297260a0e7138ce04f8b41c2e7b24e1f09a9a/mGPT/metrics/t2m.py#L76
to
self.add_state("recmotion_embeddings", default=[], dist_reduce_fx="cat")
and
https://github.com/OpenMotionLab/MotionGPT/blob/fac297260a0e7138ce04f8b41c2e7b24e1f09a9a/mGPT/metrics/t2m.py#L134-L135
to
all_genmotions = self.recmotion_embeddings.cpu()[shuffle_idx, :]
Do the same thing to text_embeddings and gtmotion_embeddings, then the problem can be solved.

@lixiang927047
        # Chached batches
        self.add_state("text_embeddings", default=[], dist_reduce_fx="cat")
        self.add_state("recmotion_embeddings", default=[], dist_reduce_fx="cat")
        self.add_state("gtmotion_embeddings", default=[], dist_reduce_fx="cat")

and
        if type(self.recmotion_embeddings) == list:
            all_genmotions = torch.cat(self.recmotion_embeddings,
                                   axis=0).cpu()[shuffle_idx, :]
        else:
            all_genmotions = self.recmotion_embeddings.cpu()[shuffle_idx, :]

        if type(self.gtmotion_embeddings) == list:
            all_gtmotions = torch.cat(self.gtmotion_embeddings,
                                    axis=0).cpu()[shuffle_idx, :]
        else:
            all_gtmotions = self.gtmotion_embeddings.cpu()[shuffle_idx, :]

        # Compute text related metrics
        if self.text:
            if type(self.text_embeddings) == list:
                all_texts = torch.cat(self.text_embeddings, axis=0).cpu()[shuffle_idx, :]
            else:
                all_texts = self.text_embeddings.cpu()[shuffle_idx, :]


added automatic registering of model to ai solution

Change description
Added automatic association of model with ai solution id. Also made config file simpler.

@credo-eli, this fixes the figure upload bug as well.


SwiftWASM support for realm-js for cross-platform RealmSwift

Problem
I have a lot of Swift code that uses RealmSwift but is otherwise quite portable code that could run in the browser via SwiftWASM. Now that you have RealmCore ported to the web via emscripten / the new realm-js alpha, it would be an absolute game-changer to have SwiftWASM support for wrapping RealmCore in the browser so that I can reuse my code cross-platform (including on non-browser platforms like Windows, Android where I can also run WASM in webviews).
Solution
No response
Alternatives
No response
How important is this improvement for you?
Would be a major improvement
Feature would mainly be used with
Local Database only

Small update - Tokamak https://github.com/TokamakUI/Tokamak has work in progress for adding Android support via SDL to their SwiftUI-compatible SwiftUI-for-WASM library. That's in addition to their web target support of course.
I just want to emphasize the breadth of realm-swift picking up the realm-js work in combination with SwiftWASM - someone would be able to easily put together a demo that runs identical Swift code across iOS, Mac, cross-plat web, Android, likely Windows as well, all using realm-js for the core with realm-swift wrapping it, with the optional ability to also use identical SwiftUI across all plats (with plat-specific parts as usual).

We don't have plans to bring WASM support to the Swift SDK for the time being. The Swift SDK is still very much intertwined with Obj C and Apple platforms and our WASM support is in its very early stages.


Continuous Integration : EATL instance crashing after executing /v1/disregard-application

Environment : Testlab
EATL instance is getting crashed after executing  "ServiceLayer / IndividualPart / /v1/disregard-application / Continuous Integration / Request notified? "
Note : Manually this service is working as expected.
Next Steps :

To isolate the problem , run only till the failing part in the test environment
Observer whether scenario is reproducible
If so , analyse the EATL container log to find the rootcause.
If not , re run the collection and kindly share the observation.

EATL is crashing randomly (not just after this request, I repeated the test suite and it would randomly fail in tests, that were previously successfull). The crash is caused by receiving a record-service-request (as a consequence of a test call, or from different app - not sure) with a bogus operation-client-uuid.
The crash happens in eventDispatcher, after executing 'LogicalTerminationPoint.getServerLtpListAsync' returns empty array and consequent getApplicationNameAsync is called with 'undefined'. The bogus operation-client-uuid was not found in load.json. Interesting is, that operation-key and operation-name were set to proper values (and to calculate them, the same bogus operation-client-uuid was used). This probably means there is a race condition and the bogus LTP was removed between lines 35-57 in eventDispatcher.js .

@DanaSunal  , Thanks for the analysis.
If you already have a proposal (or) next steps , kindly please share the same a swell.

Even better, there's already a fix :-)
Applications do not wait for callbacks by design. This means if a callback changes applications load file, the backend calls to this load file might expect different information than it's actually there. This could resolve in an undefined call and crashing EATL. The fix is simple, all the information we need to log possible error we need to gather before the callback is sent. With this fix I have not encountered any EATL crashes.


WIP: Integrate new API with editor on stories/edit

Most interesting file: pages/editor/edit.js
The new UI components are just renamed/simplified clones of existing /lib components
Not working yet:

Commit handler (TypeError ...)
Who's working? subscription (waiting for new API readiness)

Otherwise already pretty much like the github editor:

Not to big of a fan of the imperative react-portal animation. Not sure if we need react-portal at all—IMO position fixed & css transition should suffice. Let's revise in a frame / header / sidebar refactor.
Merging as is for now.


Design BSOD for windows 11

Description
I've re-designed the BSOD to make it feel like windows 11.
New:

Old:

Fixes # (issue)
Designs
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

[ ] New feature (non-breaking change which adds functionality)

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

[ ] This change requires a documentation update

[X] Is a design update, not a feature or bug fix.

The QR Code does not feels quite good and it was not in the windows 11's new bsod (official one). Here's a original image from google for windows 11 BSOD that I tried to design from:

(however, I still re-generated the qr code with blue theme at its original place.)

Deployed with 📄 GitHub Pages
Commit: f382373
Status:	✅ Success
Preview: https://pr-preview.win11react.com/873
Deploy Log: https://github.com/blueedgetechno/win11React/actions/runs/8497368238

Available at /404: https://pr-preview.win11react.com/873/404

@blueedgetechno @andrewstech


Configurable path to lefthook to run during git hook

:zap: Summary
This adds LEFTHOOK_PATH to the .git/hook templates. It's used first before
This is something that would have been helpful while working on https://github.com/evilmartians/lefthook/issues/588 and I was testing against a locally built
While I was here, I added set -x when LEFTHOOK_VERBOSE is on. This is another thing that would have been useful, and I also used it to help validate LEFTHOOK_PATH working 😁  Let me know if I should split it out separately.
:ballot_box_with_check: Checklist

[x] Check locally
[ ] Add tests
[x] Add documentation

Thank you!


Implement syncing to google cloud

As an optional feature, syncing to google cloud would be nice. Let's have a look on whether that's possible

On an implementation basis, this was totally possible. However, the requirements of Google API's Terms of Service are too much hassle for this feature, to be honest.


iOS build IPA failed

Getting  error: exportArchive: "Runner.app" requires a provisioning profile with the Push Notifications feature.
If I am building non-ipa option there's no error.
I am pre-installing cert and profile

my ExportOptions.plist contains:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
     <key>compileBitcode</key>
     <true/>
     <key>method</key>
     <string>app-store</string>
     <key>signingStyle</key>
     <string>automatic</string>
     <key>stripSwiftSymbols</key>
     <true/>
     <key>teamID</key>
     <string>MyTeamID</string>
     <key>thinning</key>
     <string><none></string>
</dict>
</plist>

Setting path to ExportOptions.plist like this:

Could you tell me what I am doing wrong? @hey24sheep
Btw, of course my profile contains push-notification feature

Hi, we use ios build in our organization so I am not very educated about build ipa option. I think you have not added provisional profile key in your export options and it is not being able to find it.
Have a look here. Check this issue as well.
If the link doesn't help try this

Check if build ipa works locally on your system with the same profile.
Second, you could try creating a new profile and see if it builds with that.

The problem is that it isn't able to find the related profile.

@hey24sheep Ye, i've changed signingStyle to manual and added provisional profile key lately, so there's no issue. Tnx for reply.

I am glad, it is solved 👍🏼

@coccyx-cyst Would you be able to post your final exportOptions.plist? I'm attempting to do the same thing as you and for some reason I'm getting the error:
Error (Xcode): No profiles for 'com.example.my-app' were found: Xcode couldn't find any iOS App Development provisioning profiles matching 'com.example.my-app'. Automatic signing is disabled and unable to generate a profile. To enable automatic signing, pass -allowProvisioningUpdates to xcodebuild.

@jtmuller5
I got these options:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
     <key>compileBitcode</key>
     <true/>
     <key>method</key>
     <string>app-store</string>
    <key>provisioningProfiles</key>
    <dict>
        <key>$(packageName)</key>
        <string>$(profileName)</string>
    </dict>
      <key>signingCertificate</key>
      <string>Apple Distribution</string>
     <key>signingStyle</key>
     <string>manual</string>
     <key>stripSwiftSymbols</key>
     <true/>
     <key>teamID</key>
     <string>$(teamId)</string>
     <key>thinning</key>
     <string><none></string>
</dict>
</plist>

@jtmuller5 Have you been able to resolve the problem? I am stuck with the same error message you posted.


chore(main): release 1.20.0

:robot: I have created a release beep boop
1.20.0 (2024-12-07)
Features

connections count (2a5440e)
select of fonts (6a38eb4)
try MiSans (#60) (4c7a001)

Bug Fixes

make side collapsed default (16d1c51)
tree shake & misans from npm (6bebec6)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.20.0
:sunflower:


Update dependencies

Vendor PR https://github.com/istio/vendor-istio/pull/41
Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Whoa, it fails with no code change?
What gives?
cc on-call @cmluciano

May be blocked on https://github.com/istio/istio/pull/4602

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-unit-tests

prow/istio-pilot-e2e-v1alpha3.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-unit-tests

prow/istio-pilot-e2e-v1alpha3.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram @costinm do you have any clue how linter failures ended up on master?

help please. exclusion doesn't work on circle!

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
6b4d97fbbc416066ddaab8a3daa73eb441722fd1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a2e4626edbbb6dad54b76638965a633ae3bb017c
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
6b4d97fbbc416066ddaab8a3daa73eb441722fd1
link
/test istio-unit-tests

prow/istio-pilot-e2e-v1alpha3.sh
6b4d97fbbc416066ddaab8a3daa73eb441722fd1
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6b4d97fbbc416066ddaab8a3daa73eb441722fd1
link
/test istio-unit-tests

prow/istio-pilot-e2e-v1alpha3.sh
6b4d97fbbc416066ddaab8a3daa73eb441722fd1
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
6b4d97fbbc416066ddaab8a3daa73eb441722fd1
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

can you make sure your PR is current with master ?
it also conflicts/overlaps with #4231
and some the vendor changes are already in vendor master

Superseded by @ldemailly 's PR.


it asks what snippet to use

I added a snippet to the file /home/user/.vim_runtime/sources_non_forked/vim-snippets/UltiSnips/c.snippets which is
snippet inc "#include ..."
#include <${1:stdio.h}>
endsnippet
and other to /home/user/.vim_runtime/sources_non_forked/vim-snippets/UltiSnips/cpp.snippets
snippet inc "#include ..."
#include <${1:iostream}>
endsnippet
when I type inc  I want it to write one of those based on the file type I'm editing but it asks me to chose between c.snippets and cpp.snippets. How can I fix this?

Please ask this in vim-snippets repo


add test for cardano-cli address info with --out-file specified

See https://github.com/input-output-hk/cardano-node-tests/blob/269a2c14685e1a62a82202bb35796928b74bf99b/cardano_node_tests/tests/test_cli.py#L194
See also implementation of address_info in clusterlib.
Add a test that compares address info data when --out-file is/is not specified.

Implemented with PR


Review required inbound NSG rules and routes as maybe outdated

Hi, I just deployed an SQL Managed Instance and reviewed rules and routes configured by the deployment and don't match the information in this page. May be outdated?
As an example, ports "9000", "9003", "1438", "1440", "1452" are opened to SqlManagement instead of ANY.
Ports "9000", "9003" are opened to CorpnetSaw and to a list of IP ranges ("<IP_ADDRESS>/24", "<IP_ADDRESS>/16", "<IP_ADDRESS>/16", "<IP_ADDRESS>/24").

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc2dd547-3ff7-b32a-ba8a-c582a721a0ee
Version Independent ID: f083bdda-0c66-af32-0d27-f535e46c96dc
Content: Connectivity architecture for a managed instance - Azure SQL Database
Content Source: articles/sql-database/sql-database-managed-instance-connectivity-architecture.md
Service: sql-database
Sub-service: managed-instance
GitHub Login: @srdan-bozovic-msft
Microsoft Alias: srbozovi

@juanjojulian As this issue has been closed by you, we hope you were able to resolve your query. Please do share your answer here for others who are seeking similar help.


Add flag to set Contour log level and reduce default xds logs verbosity

Contour outputs debug logs from internal/grpc/xds.go:xdsHandler.stream main loop by default, which may be quite verbose (in a small cluster I've seen around 400 log lines each couple of seconds).
In an attempt to reduce this verbosity by default, this PR adds a new flag to Contour: --log-level, which defaults to info, and sets the internal/grpc/xds.go:xdsHandler.stream main loop logs to log.Debug, reducing the amount of logs for each loop. The old behavior can be restored by setting --log-level=debug on Contour startup.
I've also fixed a typo in the comments related to the before mentioned log section.

Thank you for your PR.
We use a talk then code philosophy on this project. Please raise an issue and we’ll talk about the problem before jumping to a solution.

On 30 May 2019, at 08:11, Rodrigo Chacon<EMAIL_ADDRESS>wrote:
Contour outputs debug logs from internal/grpc/xds.go:xdsHandler.stream main loop by default, which may be quite verbose (in a small cluster I've seen around 400 log lines each couple of seconds).
In an attempt to reduce this verbosity by default, this PR adds a new flag to Contour: --log-level, which defaults to info, and sets the internal/grpc/xds.go:xdsHandler.stream main loop logs to log.Debug, reducing the amount of logs for each loop. The old behavior can be restored by setting --log-level=debug on Contour startup.
I've also fixed a typo in the comments related to the before mentioned log section.
You can view, comment on, or merge this pull request online at:
https://github.com/heptio/contour/pull/1131
Commit Summary
cmd/contour: configurable log level
internal/grpc: use Debug level for debug logs
internal/grpc: fix typo on comment regarding log reclaration
File Changes
M cmd/contour/contour.go (11)
M internal/grpc/xds.go (6)
Patch Links:
https://github.com/heptio/contour/pull/1131.patch
https://github.com/heptio/contour/pull/1131.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Oops, sorry about that @davecheney. I'm closing this for now, the discussion issue is linked above.


Security Issue in explained method

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d9fd1db-042c-5f44-ee84-f1a9386fb3e3
Version Independent ID: 81cb2e37-a80c-a48a-68bd-1a03499119a7
Content: Copy data from SharePoint Online List - Azure Data Factory & Azure Synapse
Content Source: articles/data-factory/connector-sharepoint-online-list.md
Service: data-factory
Sub-service: data-movement
GitHub Login: @jianleishen
Microsoft Alias: jianleishen

The document explains how to create a Bearer Token using a Web activity. According to the explanation, the developer is supposed to put the client secret for the Service Principal, which is used to authenticate against Sharepeint, as plain text into the data factory pipeline code. By that, this secret will be exposed to Git and visible for a probably much too large audience. Isn't there a better way, or did I misunderstand the explanation?

Thanks for leveraging Azure docs feedback channel to raise this question. This channel is reserved for ‘Azure docs’ feedback- for sharing doc feedback and suggesting content improvements. We didn't determine any changes for this documentation upon reviewing this feedback.
If your issue is specific to a use case, we request you to please reach out in forums like Microsoft Q&A or Stackoverflow. We have our engineers and other community members who will be happy to assist. Forums have a better suited audience for such queries.
If you have a document which you are following and if you think it needs an update, please let us know about that here.
Coming back to your ask - This document just explained the basic steps to be followed in order to establish connection to Sharepoint from ADF. But as you mentioned Body value is exposed in Git repository or ADF UI. If you have security concerns, then you may have to save the secret in secure location like SQL DB (just an example) and then use a lookup activity to get the value and parameterize in the body section of the Web activity. This way you can avoid exposing the sensitive information.
Hope the above workaround info helps. We will now proceed to close this thread. If there are further questions regarding this matter, please open a forum thread and we will gladly continue the discussion.
Thank you


Autocomplete: Option can be selected multiple times

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
When using autocomplete with custom options, each time the user clicks on an option, a chip is added, even if the option was already selected

Reduced test cases
No response
What operating system(s) are you seeing the problem on?
No response
What browser(s) are you seeing the problem on?
No response
What is the issue regarding ?
@trimble-oss/modus-web-components
What version of npm package are you using ?
No response
Priority
High
What product/project are you using Modus Components for ?
Trimble Inspections
What is your team/division name ?
Camaleão/Transportation
Are you willing to contribute ?
Maybe
Are you using Modus Web Components in production ?
No response

Able to reproduce this issue in the storybook and this should be fixed.


App data sync: WebDAV: java.io.IOException: No such file or directory

Version
1.10.1 Build 89
From F-Droid https://apt.izzysoft.de/fdroid/repo/
What platform are you using?
Android
OS Version
Xiaomi <IP_ADDRESS>.TKCMIXM (Android 13 TKQ1.221114.001)
[ro.build.version.all_codenames]: [REL]
[ro.build.version.base_os]: []
[ro.build.version.codename]: [REL]
[ro.build.version.incremental]: [V8<IP_ADDRESS>.TKCMIXM]
[ro.build.version.known_codenames]: [Base,Base11,Cupcake,Donut,Eclair,Eclair01,EclairMr1,Froyo,Gingerbread,GingerbreadMr1,Honeycomb,HoneycombMr1,HoneycombMr2,IceCreamSandwich,IceCreamSandwichMr1,JellyBean,JellyBeanMr1,JellyBeanMr2,Kitkat,KitkatWatch,Lollipop,LollipopMr1,M,N,NMr1,O,OMr1,P,Q,R,S,Sv2,Tiramisu]
[ro.build.version.min_supported_target_sdk]: [23]
[ro.build.version.preview_sdk]: [0]
[ro.build.version.preview_sdk_fingerprint]: [REL]
[ro.build.version.release]: [13]
[ro.build.version.release_or_codename]: [13]
[ro.build.version.release_or_preview_display]: [13]
[ro.build.version.sdk]: [33]
[ro.build.version.security_patch]: [2024-06-01]
[ro.product.vendor.brand]: [Redmi]
[ro.product.vendor.cert]: [2201116SG]
[ro.product.vendor.device]: [veux]
[ro.product.vendor.manufacturer]: [Xiaomi]
[ro.product.vendor.marketname]: [Redmi Note 11 Pro 5G]
[ro.product.vendor.model]: [2201116SG]
[ro.product.vendor.name]: [veux_global]

What happened?

Configured to sync app data to my own Nextcloud instance
After uncertain time of app usage, syncing started throwing error Error: java.io.IOException: No such file or directory
No relevant error messages in adb logcat output

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Issue still present in version 1.21.1 build 17, android 14

@stavpup Ok i can't reproduce right now and I thought I could have fixed it with other fixes.
If you could share ways to reproduce it that would be useful

@stavpup Ok i can't reproduce right now and I thought I could have fixed it with other fixes. If you could share ways to reproduce it that would be useful

I am referring to the OSS Card Waller, the way to reproduce is to sync

@stavpup Ok i can't reproduce right now and I thought I could have fixed it with other fixes. If you could share ways to reproduce it that would be useful

I am referring to the OSS Card Wallet, the way to reproduce is to sync

I tried and it worked fine. Will try again

Screenshot from both apps.

ok, the cards issue on the left is resolved. Now for the right issue

These messages appear when you make a mistake at the server address field. I corrected the errors!!
By the way, the documents in the scan app cannot be renamed. That is a feature request I guess.

@stavpup thanks a lot ! I just fixed the right issue

@stavpup released!


Binary operator spaces

Thanks you @MathiasReker. I must close this PR because it doesn't bring any value.


Video conference for android < M

https://github.com/RocketChat/Rocket.Chat.Android/blob/6f2f5c88754d520e91f8087166117cabe51acfbf/app/src/main/java/chat/rocket/android/chatroom/presentation/ChatRoomNavigator.kt#L29
could someone check of we sill need that condition the pull got merged

Jitsi has solved this issue and it is working now with Android M- versions. We have removed that condition already.


  Shouldn't have to do that, since I'm authenticated through Github.

We will add an option to re-use the GitHub information in Global/Security/Authentication.
But, the user still has to authenticate it once again, cause we need to gain more permissions for Pipeline.

@lvuch @vincent99 Could you help me design what the UX should be if we add this Option in the Authentication Page of Pipeline? I can't image how it looks like.

Version - 2.0 master 3/19


glm and uno-sdk dependencies

I have a maven project that is a collection of various JOGL examples and have been trying to get some of your code working in it.
I've added the maven equivalent of the jitpack stuff in your build.gradle to my pom as per the following:
    <repositories>
        <repository>
            <!-- for kotlin-graphics (elect86) dependencies -->
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
        </repository>
    </repositories>

    <dependencies>
        <dependency>
            <groupId>com.github.elect86</groupId>
            <artifactId>glm</artifactId>
            <version>471c2fd5d2002696e2721dde19fded16c01fab78</version>
        </dependency>
        <dependency>
            <groupId>com.github.elect86</groupId>
            <artifactId>uno-sdk</artifactId>
            <version>0161a60cd1f9393d419f01660d225a81e0bd45e3</version>
        </dependency>
    </dependencies>

but it doesn't resolve those jars. I've also tried using com.github.kotlin-graphics as it seems there's been a change in username but I still can't resolve them so am unable to import:
import glm.mat.Mat4x4;
import glm.vec._2.Vec2;
import glm.vec._3.Vec3;
import uno.debug.GlDebugOutput;
import uno.glsl.Program;

Would it be possible to either place all required code in this repo or to publish any other dependencies in maven central.

After changing the dependencies to the latest tags:
        <dependency>
            <groupId>com.github.kotlin-graphics</groupId>
            <artifactId>glm</artifactId>
            <version><IP_ADDRESS>-build-12</version>
        </dependency>
        <dependency>
            <groupId>com.github.kotlin-graphics</groupId>
            <artifactId>uno-sdk</artifactId>
            <version>0.7.5</version>
        </dependency>

I managed to at least resolve the dependencies but it looks like the Kotlin source has not been written in a way that makes nice to call from Java. I can get the glm stuff working for example but the imports are pretty ugly:
import glm_.mat4x4.Mat4; // instead of glm.mat_.Mat4x4;
import glm_.vec2.Vec2; // instead of glm.vec._2.Vec2;
import glm_.vec3.Vec3; // instead of glm.vec._3.Vec3;

I'm having no such luck with the classes that are supposed to be in uno-sdk though.


[vcr-2.0] Fix updateTTL and logging issues

This patch fixes updateTTL issues from prev backup code and a few logging issues detailed below.

Replication: When repl-layer receives PUT+TTL together, it applies PUT to store a blob with expiry = -1 followed by updating its expiry to -1. This is redundant and was caught by the new backup code. It floods the logs with unnecessary messages. We can't touch repl-layer at this point so we just suppress the logs.
Backup code V1: The previous backup code reported a blob was not ttl-updated even though it was. This sent duplicate writes to Azure and was caught by the new backup code. This is not only wrong but also floods the logs with unnecessary messages.
Azure SDK: The SDK prints out unnecessary warnings when searching for an absent blob in Azure Storage. The issue is confirmed by MSFT and they'll fix it in their next release. Additionally, we also print some unnecessary messages when we encounter blob_not_found. This patch eliminates those as well.

MSFT issue: https://github.com/Azure/azure-sdk-for-java/issues/37117

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (43ca542) 32.71% compared to head (23fd4b6) 32.56%.

:exclamation: Current head 23fd4b6 differs from pull request most recent head e31906f. Consider uploading reports for the commit e31906f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2611      +/-   ##
============================================
- Coverage     32.71%   32.56%   -0.16%
+ Complexity     4485     4475      -10
============================================
  Files           806      806
  Lines         65166    65177      +11
  Branches       7945     7946       +1
============================================
- Hits          21322    21223      -99
- Misses        41610    41732     +122
+ Partials       2234     2222      -12

Files
Coverage Δ

...in/java/com/github/ambry/cloud/CloudBlobStore.java
31.34% <100.00%> (-0.81%)
:arrow_down:

...java/com/github/ambry/cloud/CloudBlobMetadata.java
34.09% <0.00%> (-0.27%)
:arrow_down:

...b/ambry/cloud/azure/AzureCloudDestinationSync.java
0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Merging as i got two approvals


FIX GET CRYPTO

chill hecker we will work on it

ok
On Tue, Apr 26, 2022 at 8:52 PM Hankypoo7 @.***> wrote:

chill hecker we will work on it
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/lol-jude/Blooket-Hacks/issues/71*issuecomment-1110476043__;Iw!!I5wY4Ip2iQ-G!-TEAsczJlHiX5gLmj3M5YZhI1XVa-taKDG9JI_07IlUSoj_-KiQUFij3BaJ9uRFdDK82_4aDk5ACIuvXdmvDpYov_IjPAw$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AYV5T3XAXBTASV4JYCYULK3VHCTS7ANCNFSM5UNIMH3A__;!!I5wY4Ip2iQ-G!-TEAsczJlHiX5gLmj3M5YZhI1XVa-taKDG9JI_07IlUSoj_-KiQUFij3BaJ9uRFdDK82_4aDk5ACIuvXdmvDpYqTsm5m-A$
.
You are receiving this because you authored the thread.Message ID:
@.***>


Clear DynamicLink in memory after FirebaseDynamicLinks is retrieved

Tested on iOS :
When I open my app from a dynamic link, I have a button on my widget to get the dynamic link received
final PendingDynamicLinkData data =
        await FirebaseDynamicLinks.instance.retrieveDynamicLink();

Then problem comes  when I open the application again manually (not from the dynamic link).
If I press the button to trigger this method
final PendingDynamicLinkData data =
        await FirebaseDynamicLinks.instance.retrieveDynamicLink();

Result : I receive the same value as the first call which is not correct.
Expected: I expect to receive null because my app was not open from the dynamic link

#19506 looks related

Yes , It's related , I'm trying to do a workaround using the WidgetsBindingObserver to listen when the app go into foreground  but the problem is every time that I call to retrieveDynamicLink the data persist from the last dynamic link opened.

I can confirm it's working fine in Android
final PendingDynamicLinkData data =
        await FirebaseDynamicLinks.instance.retrieveDynamicLink();

When I call the code above It only returns data when I open the app from the dynamicLink.

@diegoveloper
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/738. Any further collaboration will be done there.


Add IP as a tag for influxdb output

Adding the IP address as a tag value for the Influxdb output matching behavior of the Prometheus output.

Cardinality of IP addresses is to high to make them tags.


[docs] Code blocks don't render on Firefox mobile browser

I'm using Firefox Nightly on Android (12) and some of the code blocks don't render properly. The text is definitely there so I guess it's some CSS issue? I tried on a Chromium-based mobile browser (Vivaldi) and that worked fine.
Example:

Seeing the same behavior on 99.0.1 (64-bit) OSX desktop.
Suspect the problem is in the <code-tabs> because the <pre class="language-bash"> containing the actual text appears fine on other pages and manually moving those elements out of the <code-tabs> with the inspector causes the text to appear.

new rocket version introduced quite a change... I don't think that is an issue anymore - if it is feel free to reopen or creating a new issue 🤗

Just did a quick check to see if fixed but now things are very bad.  Nothing appears when I visit the site.
Looking at browser console shows an error.

hmmm - strange 🤔
I just tested it on Firefox 103.0.2 (64-bit) OSX...
what you showed seems like an old service worker? 🤔
can you try a "hard" reload - typically that is Command + Shift + R? 🤞🙏

Updated to Firefox 103.0.2 and tried a hard reload but it didn't change the outcome.
But I do see a slightly different backtrace.   Here is the "Save all messages to File" from the console.
console-export-2022-8-13_13-24-55.txt

hmmm as I could not reproduce it I asked 4 different people to try it and they all said it worked fine on their FF... 3 with mac - 1 with windows....
so I'm at a loss here 🙈
some ideas

open it via a private tab
use Dev Tools (F12) -> Application Tab -> [unregister] (Service Worker)
open settings (about:preferences#privacy) => Privacy & Security => Cookies and Site Data => Clear Data... => select ONLY "Cached Web Content" => clear

None of those suggestions helped, but disabling all Firefox add-ons fixed the issue.
After carefully re-enabling them one by one I found https://rocket.modern-web.dev
will error as decribed earlier if either of these extensions is enabled:

Stylus https://addons.mozilla.org/en-US/firefox/addon/styl-us
Disable HTML5 Autoplay https://addons.mozilla.org/en-US/firefox/addon/disable-autoplay

After re-enabling my other extensions but leaving those disabled I was able to view the site.
I don't know what those extensions are doing that would cause the error.  I've found that

enabling Stylus and configuring it to ignore the modern-web.dev domain works ✅
enabling Disable HTML5 Autoplay breaks the site even if configured to ignore the domain❗

so I think I'll have to make a note of this in the future.
Getting back to the original issue - the docs look different from the ones in April and
I don't see any missing code sections like I did before.  I couldn't find any obvious "tabbed"
code examples so either they aren't used anymore or are working as expected.

thank you for that investigation 🙇♂
a rather curious case 🙈


Container for GATK without UseShenandoahGC

When deployed the containers and created the run, run error after ca. 1h failing at MergeBamAlignment because of unrecognised VM option UseShenandoah GC.

Resolved in #24


Make splunkd.service.j2 src variable

Comparing the templates/splunkd.service.j2 with what I have working on server from manual installation I see several changes that as I understand need to be made in the case of running non-root and allowing access to read all log files. There is currently no means by which I can have my own custom templated version that overrides unless I simply import the role and modify it locally.
Namely all ExecStartPre and ExecStartPost are either missing or commented out and the AmbientCapabilities is non-existent. In our case, adding templating, the following would be what I'd use based on the Splunk provided default:
#
# {{ ansible_managed }}
#
[Unit]
Description=Splunk Forwarder service
After=network-online.target
Wants=network-online.target

[Service]
Type=simple
Restart=always
ExecStart=/opt/splunkforwarder/bin/splunk _internal_launch_under_systemd --accept-license --no-prompt --answer-yes
KillMode=mixed
KillSignal=SIGINT
TimeoutStopSec=360
LimitNOFILE=65536
LimitRTPRIO=99
SuccessExitStatus=51 52
RestartPreventExitStatus=51
RestartForceExitStatus=52
User={{ splunk_forwarder_user }}
Group={{ splunk_forwarder_group }}
NoNewPrivileges=yes
AmbientCapabilities=CAP_DAC_READ_SEARCH
ExecStartPre=-/bin/bash -c "chown -R {{ splunk_forwarder_user }}:{{ splunk_forwarder_group }} /opt/splunkforwarder"
Delegate=true
CPUShares=1024
MemoryLimit=8243621888
PermissionsStartOnly=true
ExecStartPost=-/bin/bash -c "chown -R {{ splunk_forwarder_user }}:{{ splunk_forwarder_group }} /sys/fs/cgroup/cpu/system.slice/%n"
ExecStartPost=-/bin/bash -c "chown -R {{ splunk_forwarder_user }}:{{ splunk_forwarder_group }} /sys/fs/cgroup/memory/system.slice/%n"

[Install]
WantedBy=multi-user.target

One potential workaround currently would be just to deploy a local override file via my own Ansible task under /etc/systemd/system/splunkd.service.d/


isabelle: make closer to upstream

Motivation for this change
Incorporates some changes from #115339.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

A few of my PRs were merged, so you would have to rebase this

@gebner @SuperSandro2000 this would be ready to merge as well

@SuperSandro2000 is this PR good to go now?


Update to 1.17

Dear Fiona The Mortal,
1.17 is already out and fabric is already available
on 1.17, please update it for 1.17 . The fabric wiki
has already updated for 1.17 not that long ago and I
like little block goats and axolotls.
Yours sincerely,
MaxBr5

Forge is taking far too long to update to 1.17 but it does
not mean that you can’t update it for fabric 1.17 .

It's out now and I got to deal with some fabric weirdness

Thank you.


Add integration test for HACV
worgarside/github-config-files#228

synced local file(s) with worgarside/github-config-files.

This PR was created automatically by the repo-file-sync-action workflow run #8139958142

This PR is empty, closing it. :no_good:


Test ball#12

created test suite for the ball and added tests.  created constructor for the ball and 4 movement prototypes.  made sure that all tests are passing.

Cool. At the end of the day, I wonder if we'll need all the methods we're writing instead of statements "if y= something, then ball.x = -2", but it's good to have them at the ready.


Fixed: Fix warning about key in spread props and make key explicit

Resolves 🐛 [BUG] - Warning: A props object containing a "key" prop is being spread into JSX in Block.tsx #1221
Propose removing unused data argument from setView function in Playback.tsx
Question to reviewer
Do we even need to pass a key to the children components? Perhaps we can simplify it and remove it.

TBH, I never quite understood the necessity of the key set in the Block component. Does it have something to do with that every element in a template needs its unique key? Could we be getting away with renaming view to key instead?
Indeed, child components don't need the key, or view prop for that matter as far as I can see.


CI: Move K8sUpdates to ci-e2e

The K8sUpdate tests the following:

Cilium upgrade: $STABLE -> $LATEST -> $STABLE.
No drops due to missed tail calls.
Pod 2 pod connectivity with and without L7 netpol.
No interruption in E/W LB long-lived connections.

We are going to move the upgrade test to a GHA. If we move to the ci-e2e, then we will increase a coverage for different configurations.
In addition, we should test N/S LB long-lived connections from non-Cilium host too (maybe other interruptions in connections too  to exercise more packet paths?).
The way I see the move is the following:

At the end of ci-datapath connectivity tests destroy Kind cluster, and then create a new one.
Install $STABLE cilium.
Run cilium-cli connectivity --test-upgrade --setup (TBI) which will create necessary test pods and do sanity checks.
Upgrade to $LATEST with cilium-cli install.
Run cilium-cli connectivity --test-upgrade run the tests.
Downgrade to $STABLE with cilium-cli install.
Run cilium-cli connectivity --test-upgrade again.

How do you propose cilium-cli connectivity --test-upgrade should work? I note that one of the key features of the existing test is to be asynchronously running connections through the datapath while the agent is upgraded / downgraded, then we count how many dropped flows etc. there are.

How do you propose cilium-cli connectivity --test-upgrade should work?

I'm suggesting to introduce a two-stage test case.
First (--test-upgrade --setup), it deploys necessary pods and services. The pods do all sorts of connections (same, as the migrate-svc does today). If any of the connection fails (unexpectedly), then that pod restarts. This bumps the restart counter.
Second, we do the Cilium upgrade.
Finally (--test-upgrade), it checks that no restarts happened after the upgrade.

FYI, Donia is adding some infra. to the CLI that would probably be useful here as well, to check counters after the upgrade and downgrade: https://github.com/cilium/cilium-cli/pull/1575.

I think the new pipelines causes CI flakes: https://github.com/cilium/cilium/issues/29476


Nectar cam reader

First version of the a eventsource for NectarCAM data.
Only a minimal part of the specific camera data are included for the moment.

It looks like four empty packages have been created in this PR, by creating these empty __init__.py-files.
dneise@host:ctapipe/atmosphere$ tree
├── fram
│   └── __init__.py
├── gdas
│   └── __init__.py
├── __init__.py
└── lidar
    └── __init__.py

Did this maybe happen by accident or will these package be filled with functionality in this PR?

Ah ... I just realize ... I think you need v0.44.4 of the protozfits for this .. since only v0.44.4 contains the example file you need for testing.
So you need to modify the  .travis.yml file to install this particular version, here:
https://github.com/cta-observatory/ctapipe/blob/e4d9a307ec7bf2846bc5930de9b175ee9f5cf41a/.travis.yml#L57

Ah ... nearly forgot: Thank you for this PR, I hope this might be useful to find out more about similarities and differences of all the different telescopes.

Tests are now failing in one seemingly unrelated place.   Keep
            reading HDUs until the operation succeeds or there are no
            more HDUs to read.
            """

        while True:
            try:
>               return func(*args, **kwargs)
E               IndexError: list index out of range

The problem is there is an IndexError when applying NectarCAMEventSource.is_compatible to a CHEC data file, as technically the file format used by CHEC is a fits file, but not of a format astropy.fits expects.
In NectarCAMEventSource.is_compatible add the last 3 lines of this block:
        try:
            # The file contains two tables:
            #  1: RunHeader
            #  2: Events <--- this is what we need to look at
            h = fits.open(file_path)[2].header
            ttypes = [
                h[x] for x in h.keys() if 'TTYPE' in x
            ]
        except OSError:
            # not even a fits file
            return False
        except IndexError:
            # A fits file of a different format
            return False

Hi Karl,
I am a bit lost, why did this pull request not work?

I am a bit lost, why did this pull request not work?

It seems fine - I just didn't have a time to do a code review yet :-) I'll do it now!

Thanks!
F.


Add GitHub actions for test and linting

@jeffwidman @dims @pacoxu  @aboch PTAL

A test-run of these changes can be found on my fork, where I opened a draft-PR from this branch; https://github.com/thaJeztah/netns/pull/1

Since this adds github actions that are versioned, we should probably also add a stanza to https://github.com/vishvananda/netns/blob/master/.github/dependabot.yml to monitor/bump the actions.
Feel free to include as part of this PR (albeit in a separate commit), but if you're not sure how to do that, I can handle it in a separate PR.

Ah, interesting; looks like go1.12 is actually an issue with the updated golang.org/x/sys.
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.2.0/unix/syscall.go:83:16: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.2.0/unix/syscall_linux.go:2256:9: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.2.0/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.2.0/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice

Maybe it's time now to update to something newer (I think I saw some projects are still on go1.15, let me try if that works)

I opened https://github.com/vishvananda/netns/pull/64 to update the minimum go version 👍  (I'll rebase this PR once that's merged to remove the extra commit; CI is happy on https://github.com/thaJeztah/netns/pull/1)

Alright; rebased; this one should be ready for review (https://github.com/thaJeztah/netns/pull/1 is still happy)

Feel free to include as part of this PR (albeit in a separate commit), but if you're not sure how to do that, I can handle it in a separate PR.

Oh! I forgot about that one; I'd have to look up how to set that up, so if you have time to handle that, that'd be appreciated 🤗 ❤

Feel free to include as part of this PR (albeit in a separate commit), but if you're not sure how to do that, I can handle it in a separate PR.

Oh! I forgot about that one; I'd have to look up how to set that up, so if you have time to handle that, that'd be appreciated 🤗 ❤

Handled in https://github.com/vishvananda/netns/pull/66

@thaJeztah I left some minor feedback, I know we're both busy, so any chance of getting this across the line while it's still fresh in our minds?

Doh! Saw your comments, and then forgot about them. Thanks for the ping; yes, let me look at those 👍

Okay; updated. I think this should be ready for another review 👍

Thanks!


Fixed syntax typo

@TravisYeah : Thanks for your contribution! The author, @edmacauley, has been notified to review your proposed change.

@TravisYeah Thanks for the correction. We'll get this published in the next day or so. Appreciate your contribution.


Adds error message when the key is composite

An example is:
SELECT u FROM User u INNER JOIN Address a ON a.user = u

When User has a composite key.

I think this issue needs a fix, not an exception message.

Working on this

Closing as incomplete


Account for children text content size in ElementNode's getTextContentSize

Fixes #3772
In ElementNode I've duplicated the logic of getTextContent for getTextContentSize() to account for children where getTextContentSize() !== getTextContent().length.
I'm not sure that the changes are desirable.
In particular, RootNode overrides getTextContent to track the internal property __cachedText.
__cachedText is changed manually when the editor is updated. I lack familiarity with the codebase but my guess is that it's a performance optimization.
In the current state of the PR, the same optimization is not applied to getTextContentSize in RootNode.
What are the implications of this? I see that getTextContentSize is used internally in LexicalSelection.ts.

@GiacomoRandazzo Generally, I think this seems sensible and this is probably a use-case we should be accommodating.
You're right that the __cachedText property on the root is a performance optimisation which is used during reconciliation. We need to keep the property on the root node, but it's probably okay to remove it from the logic of getTextContent on the root to fix the bug you've mentioned.
It's added as an performance optimization, but it seems we only really use it in the max length plugin.

I've updated the max length plugin and the trimTextContentFromAnchor function to account for getTextContentSize().

I have an alternative proposal that might be more future proof.
As described in #3772, the context in which I need getTextContent().length !== getTextContentSize() is in copying a custom equation node with $ delimiters around the equation and, at the same time, have the max length plugin account for the equation length without the delimiters.
Currently getTextContent is used both for copying as text/plain and to compute the node length for the max length plugin.
The current PR solves the problem by allowing getTextContentSize to differ from the length of the node text content. This could lead to inconsistencies in the internal logic of Lexical (e.g. what if a non-empty node has getTextContentSize = () => 0?). From a dev point of view is hard to grasp the implications of overriding getTextContentSize().
An alternative solution is to have a way for custom nodes to override the behavior for copying as text/plain, similarly to how exportDOM is used to copy as text/html.
Lexical internals could assume getTextContent().length === getTextContentSize(), which is more future proof.
At this point getTextContentSize() could be removed altogether to avoid confusion.

Thanks for the proposal @GiacomoRandazzo! I like the idea but I think, given the rarity of the issue, introducing a whole new export/importPlainText API feels somewhat like overkill. If you overwrite getTextContentSize on core nodes whilst doing a node replacement, developers know they're doing so at their own risk of bugs. It's definitely less of an issue though in cases such as yours where it's a one-off extended node.


KTable producing empty Streams with runStreams

Hello, I am using runStreams in my tests to see whether my KTable is accurately tracking a user session.  I am printing the results of my KTable and I am getting the expected output, but the consumer is returning an empty stream.  Are KTables currently not supported, am I setting up my tests incorrectly or something else?  Thanks a lot for your help!

@jacobBaumbach I noticed you didn't materialize the data stream at your code. If you add data.to(stringSerdes, stringSerdes, outputTopic), you should get non-empty Stream.

@jiminhsieh @manub
I have the same issue with the following dependencies:
val embeddedKafka = "net.manub" %% "scalatest-embedded-kafka" % "1.0.0" % Test
val embeddedKafkaStreams = "net.manub" %% "scalatest-embedded-kafka-streams" % "1.0.0" % Test

with kafka version 1.0.0
I reproduced this issue with the following test:
package net.manub.embeddedkafka.streams

import com.lightbend.kafka.scala.streams.{KStreamS, StreamsBuilderS}
import net.manub.embeddedkafka.Codecs._
import net.manub.embeddedkafka.{EmbeddedKafkaConfig, UUIDs}
import org.apache.kafka.common.serialization.{Serde, Serdes}
import org.apache.kafka.common.utils.Bytes
import org.apache.kafka.streams.{Consumed, KafkaStreams, Topology}
import org.apache.kafka.streams.kstream.{Materialized, Produced}
import org.apache.kafka.streams.state.{KeyValueStore, QueryableStoreTypes}
import org.scalatest.{Matchers, WordSpec}

class ExampleKafkaStreamsSpec extends WordSpec with Matchers with EmbeddedKafkaStreamsAllInOne {

  implicit val config =
    EmbeddedKafkaConfig(kafkaPort = 7000, zooKeeperPort = 7001)

  val (inTopic, outTopic) = ("in", "out")

  val stringSerde: Serde[String] = Serdes.String()

  "A Kafka streams test" should {
    "be easy to run with streams and consumer lifecycle management" in {
      val streamBuilder = new StreamsBuilderS
      val stream: KStreamS[String, String] =
        streamBuilder.stream[String, String](inTopic)(Consumed.`with`(stringSerde, stringSerde))

      stream.to(outTopic)(Produced.`with`(stringSerde, stringSerde))
      val materializer =
        Materialized.as[String, String, KeyValueStore[Bytes, Array[Byte]]]("my-store")
      streamBuilder.globalTable(outTopic, materializer)(Consumed.`with`(stringSerde, stringSerde))

      myRunStreams(Seq(inTopic, outTopic), streamBuilder.build()) { kstream =>
        publishToKafka(inTopic, "hello", "world")
        publishToKafka(inTopic, "foo", "bar")
        publishToKafka(inTopic, "baz", "yaz")
        val value = kstream.store("my-store", QueryableStoreTypes.keyValueStore[String, String]())
        value.get("hello") should be("world")
      }
    }

    /**
      * Copy paste from runStreams to expose KafkaStreams
      */
    def myRunStreams(topicsToCreate: Seq[String], topology: Topology, extraConfig: Map[String, AnyRef] = Map.empty)(
        block: KafkaStreams => Any)(implicit config: EmbeddedKafkaConfig): Any =
      withRunningKafka {
        topicsToCreate.foreach(topic => createCustomTopic(topic))
        val streamId = UUIDs.newUuid().toString
        val streams = new KafkaStreams(topology, streamConfig(streamId, extraConfig))
        streams.start()
        try {
          block(streams)
        } finally {
          streams.close()
        }
      }(config)
  }
}

By the way, I have 2 questions :

Is the KafkaStream built from runStreams not exposed on purpose ?
Can we have runStreamsOnFoundPort ? runStreams currently only use withRunningKafka

We finally decided to use Eventually.eventually in scalatest. This resolve the empty stream issue. Maybe you have an alternative to that.


unreliable e2e test in win7/ie9

[internet explorer 9 Windows 7 #3] @ask-question
[internet explorer 9 Windows 7 #3] Feature: Ask Question
[internet explorer 9 Windows 7 #3]
[internet explorer 9 Windows 7 #3]   Any Contributor may ask questions with Markdown formatting, associating one or
[internet explorer 9 Windows 7 #3]   more (existing) "tags" with the question.
[internet explorer 9 Windows 7 #3]
[internet explorer 9 Windows 7 #3]
[internet explorer 9 Windows 7 #3]   Scenario: Ask a question with Markdown preview      # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:7
[internet explorer 9 Windows 7 #3]     Given I am "Mary"                                 # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:8
[internet explorer 9 Windows 7 #3]     And my user name is "MaryAdmin"                   # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:9
[internet explorer 9 Windows 7 #3]     When I visit the "ask" page                       # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:10
[internet explorer 9 Windows 7 #3]     And I type "" as the question title               # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:11
[internet explorer 9 Windows 7 #3]     Then the submit button is disabled                # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:12
[internet explorer 9 Windows 7 #3]     When I type "foo" as the question title           # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:13
[internet explorer 9 Windows 7 #3]     And I type "**bar**" as the question content      # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:14
[internet explorer 9 Windows 7 #3]     And I enter "baz" as a question tag               # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:15
[internet explorer 9 Windows 7 #3]     Then the question title is "foo"                  # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:16
[internet explorer 9 Windows 7 #3]     And the question content is "**bar**"             # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:17
[internet explorer 9 Windows 7 #3]     And the question tag is "baz"                     # home/travis/build/laurelnaiad/marklogic-samplestack/specs/features/as-mary/ask-question.feature:18
[internet explorer 9 Windows 7 #3]       AssertionError: expected [] to deeply equal [ 'baz' ]
[internet explorer 9 Windows 7 #3]         at [object Object].assertEqual (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/chai/lib/chai/core/assertions.js:427:19)
[internet explorer 9 Windows 7 #3]         at [object Object].ctx.(anonymous function) (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/chai/lib/chai/utils/addMethod.js:40:25)
[internet explorer 9 Windows 7 #3]         at /home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/chai-as-promised/lib/chai-as-promised.js:302:26
[internet explorer 9 Windows 7 #3]         at /home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/goog/base.js:1582:15
[internet explorer 9 Windows 7 #3]         at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:1654:20)
[internet explorer 9 Windows 7 #3]         at notify (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:465:12)
[internet explorer 9 Windows 7 #3]         at notifyAll (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:442:7)
[internet explorer 9 Windows 7 #3]         at resolve (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:420:7)
[internet explorer 9 Windows 7 #3]         at fulfill (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:535:5)
[internet explorer 9 Windows 7 #3]         at Object.webdriver.promise.asap (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:776:5)
[internet explorer 9 Windows 7 #3]         at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:1665:25)
[internet explorer 9 Windows 7 #3]         at notify (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:465:12)
[internet explorer 9 Windows 7 #3]         at notifyAll (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:442:7)
[internet explorer 9 Windows 7 #3]         at resolve (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:420:7)
[internet explorer 9 Windows 7 #3]         at fulfill (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:535:5)
[internet explorer 9 Windows 7 #3]         at Object.webdriver.promise.asap (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:776:5)
[internet explorer 9 Windows 7 #3]         at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:1665:25)
[internet explorer 9 Windows 7 #3]         at notify (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:465:12)
[internet explorer 9 Windows 7 #3]         at notifyAll (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:442:7)
[internet explorer 9 Windows 7 #3]         at resolve (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:420:7)
[internet explorer 9 Windows 7 #3]         at fulfill (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:535:5)
[internet explorer 9 Windows 7 #3]         at Object.webdriver.promise.asap (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:776:5)
[internet explorer 9 Windows 7 #3]         at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:1665:25)
[internet explorer 9 Windows 7 #3]         at notify (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:465:12)
[internet explorer 9 Windows 7 #3]         at notifyAll (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:442:7)
[internet explorer 9 Windows 7 #3]         at resolve (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:420:7)
[internet explorer 9 Windows 7 #3]         at fulfill (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:535:5)
[internet explorer 9 Windows 7 #3]         at /home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/goog/base.js:1582:15
[internet explorer 9 Windows 7 #3]         at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:1654:20)
[internet explorer 9 Windows 7 #3]         at notify (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:465:12)
[internet explorer 9 Windows 7 #3]         at [object Object].then (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:522:7)
[internet explorer 9 Windows 7 #3]         at Object.webdriver.promise.asap (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:767:11)
[internet explorer 9 Windows 7 #3]         at newFrame.onComplete (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:1670:25)
[internet explorer 9 Windows 7 #3]         at [object Object].webdriver.promise.Frame_.notify_ (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:1914:5)
[internet explorer 9 Windows 7 #3]         at [object Object]._onTimeout (/home/travis/build/laurelnaiad/marklogic-samplestack/browser/node_modules/selenium-webdriver/lib/webdriver/promise.js:1901:11)
[internet explorer 9 Windows 7 #3]         at Timer.listOnTimeout [as ontimeout] (timers.js:112:15)

@gghai would you please test this scenario in win7/ie9? Try to put in a question as Mary, and tag it as "baz".... see if it actually works? I'm not sure I'm convinced as to whether this is an app problem or a test problem.
In order to test, you'd have to check out laurelnaiad/browser-develop. If you don't remember how to do that, ping me and I can walk you through it (or you could look at http://git-scm.com/docs/git-checkout).

I am in process of setting up the win 7 env . It has now ML 01/09 build and branch that i pulled using
git remote add laurelnaiad https://github.com/laurelnaiad/marklogic-samplestack
git fetch laurelnaiad
git checkout -b browser-develop laurelnaiad/browser-develop
git rev-parse HEAD = 2b30247d4c7ee5df3ee6b0052ac40784d3ab2106
On running the bower install command i am seeing this against the browser-develop branch .
C:\Users\builder\marklogic-samplestack\browser>bower install
bower not-cached    git://github.com/angular/bower-angular-mocks.git#1.3.8
bower resolve       git://github.com/angular/bower-angular-mocks.git#1.3.8
bower not-cached    git://github.com/angular/bower-angular-cookies.git#1.3.8
bower resolve       git://github.com/angular/bower-angular-cookies.git#1.3.8
bower not-cached    git://github.com/angular/bower-angular-sanitize.git#1.3.8
bower resolve       git://github.com/angular/bower-angular-sanitize.git#1.3.8
bower not-cached    git://github.com/HenningM/jstimezonedetect.git#~1.0.6
bower resolve       git://github.com/HenningM/jstimezonedetect.git#~1.0.6
bower download      https://github.com/angular/bower-angular-cookies/archive/v1.
3.8.tar.gz
bower download      https://github.com/HenningM/jstimezonedetect/archive/v1.0.6.
tar.gz
bower download      https://github.com/angular/bower-angular-mocks/archive/v1.3.
8.tar.gz
bower download      https://github.com/angular/bower-angular-sanitize/archive/v1
.3.8.tar.gz
bower extract       jstzdetect#~1.0.6 archive.tar.gz
bower extract       angular-cookies#1.3.8 archive.tar.gz
bower extract       angular-mocks#1.3.8 archive.tar.gz
bower extract       angular-sanitize#1.3.8 archive.tar.gz
bower resolved      git://github.com/angular/bower-angular-mocks.git#1.3.8
bower resolved      git://github.com/angular/bower-angular-cookies.git#1.3.8
bower resolved      git://github.com/angular/bower-angular-sanitize.git#1.3.8
bower not-cached    git://github.com/angular/bower-angular.git#1.3.8
bower resolve       git://github.com/angular/bower-angular.git#1.3.8
bower resolved      git://github.com/HenningM/jstimezonedetect.git#1.0.6
bower download      https://github.com/angular/bower-angular/archive/v1.3.8.tar.
gz
bower extract       angular#1.3.8 archive.tar.gz
bower resolved      git://github.com/angular/bower-angular.git#1.3.8
bower cached        git://github.com/angular/bower-angular.git#1.3.8
bower validate      1.3.8 against git://github.com/angular/bower-angular.git#>=1
bower cached        git://github.com/angular/bower-angular.git#1.3.8
bower validate      1.3.8 against git://github.com/angular/bower-angular.git#>=
1.2.5
bower cached        git://github.com/angular/bower-angular.git#1.3.8
bower validate      1.3.8 against git://github.com/angular/bower-angular.git#>=1
.2.0
bower cached        git://github.com/angular/bower-angular.git#1.3.8
bower validate      1.3.8 against git://github.com/angular/bower-angular.git#>=
1.0.8
bower cached        git://github.com/angular/bower-angular.git#1.3.8
bower validate      1.3.8 against git://github.com/angular/bower-angular.git#>=1
.2.1
Unable to find a suitable version for angular, please choose one:
1) angular#1.3.7 which resolved to 1.3.7 and is required by angular-cookies#
1.3.7, angular-mocks#1.3.7, angular-sanitize#1.3.7
2) angular#1.3.8 which resolved to 1.3.8 and is required by angular-cookies#
1.3.8, angular-mocks#1.3.8, angular-sanitize#1.3.8
3) angular#>=1 which resolved to 1.3.8 and is required by angular-bootstrap#
0.11.0
4) angular#>= 1.2.5 which resolved to 1.3.8 and is required by angular-marke
d#0.0.12
5) angular#>=1.2.0 which resolved to 1.3.8 and is required by angular-ui-rou
ter.stateHelper#1.2.0
6) angular#>= 1.0.8 which resolved to 1.3.8 and is required by angular-ui-ro
uter#0.2.13
7) angular#>=1.2.1 which resolved to 1.3.8 and is required by ng-tags-input#
2.1.1Prefix the choice with ! to persist it to bower.json
? Answer::

Right, thanks. Scott just found this, too. It turns out that trying to solve #456 didn't go very well. I'm going to get on that right now.

I am on the SS testing infrastructure machine just in case you want to get onto that instance .thx  .

Ok, I have a potential fix for this secondary issue, so I will just log in there and test both. Thanks!

I seem to be having VPN issues. @gghai if you have a moment, can we do this together via webex with you being the VPN-er?

Sure

Wtih @gghai 's superhuman devtools driving, we verified that:

the tag is properly rendered in IE9
IE9 has no idea that it has rendered the tag properly -- the text is absent from the DOM hierarchy, even though it's on the screen.

This means that the test isn't broken and the app isn't broken either -- it's just that the browser isn't accurately reporting the DOM hierarchy it has rendered.  I've already implemented code to skip this one step in IE9 (https://github.com/laurelnaiad/marklogic-samplestack/commit/246b34fcfbce89b14492bb91f535b6864a839116), so we should be good to go. Issue #456 is a separate story which will continue in that issue.

Will verify once this is fixed  https://github.com/marklogic/marklogic-samplestack/issues/452

Will verify once #452 - e2e issues -- Windows edition is fixed .

This doesn't need the windows machine to be fixed. It's a sauce test that was having the problem. You can verify this one on Mac.

Sauce labs portal seems down . Will retry at later point.

Is that the problem? Are you testing on mac? I'm trying to get the new win machine running and banging my head against the sauce part.... if it's down then no wonder! (until the next problem)

Portal is down that was realized after few test failure from mac :-) Friday evening best time to upgrade

Ran this command through linux box using sauce
gulp e2e --sauce=win7-ie-9
All test passed .


Use Swagger for API documentation

We should use https://swagger.io/ for our API documentation as it allows to have the docs within PHPDoc in the code. Then you can dynamically or statically create a swagger.json file that can be looked at with the swagger-ui.
There is a package for php available: https://github.com/zircote/swagger-php
It allows to have a route that creates an up-to-date swagger.json or just create a static swagger.json file.
We can then host a swagger-ui instance pointing to a hosted swagger.json and people could also enter a link to their swagger.json to see all routes to their api and also test them.

I already gave this an attempt with the new API previously and it was an absolute mess trying to get all of the annotations setup in the correct place, and required annotating the models which is not really possible since they make use of magic methods for many fields.
While it looks nice, it was a pain to write and maintain. I think a more effective use of time would be properly documenting the API from the get-go. If someone wants to make a PR once I have the API written and is willing to go through and all of the swagger-php annotations they can, but I don't plan on adding that right now.


Documentation is in the wiki?

README says:

Documentation is in the Wiki. For quick testing the examples might be enough.

The wiki appears to be empty. There are links, but no content.

_< I started it then removed it and it's still in the readme. Sorry. Have to update the readme.

@codesuki How do you feel about a /docs folder? I can spare a bit of time this weekend to break the readme out a bit if you wish?

That would be very nice of you! Docs folder with markdown sounds nice.
But if you enjoy https://github.com/codesuki/react-d3-components/issues/20 then that would be of preference I guess. Although having documentation can't hurt it would be nice to get this layering / animations working, to be a more complete library.
Looking forward o anything! :)

@codesuki Do you have an email addy I can hit you up on?
We (nearForm) are using this lib pretty heavily in a (OSS) project we are going to soft launch today. This means we are going to give some kickback via contributions for you. I wanted to touch base with you and let you know what free time / resources we have available to help you out?
Sorry I'm late getting back to you, we were heads down for getting the release ready.
You can mail me on dean[dot]mcdonnell[at]nearform.com rather than putting you email here :D

Hey there! That sounds interesting!
I am on Christmas holiday now but I will send you a mail soon.


Extend Horizon Notification Time

We only really need to know if things are running super slowly - 10 minutes is fine.

:tada: This PR is included in version 5.8.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add missing [ to dnsNameRegexp.

Fixes #180.

Thanks. I'll working on adding a test here in a moment too.


Template v2.0.2 towards MART

What does this PR do?
This should make it easier to merge the new template into MART.

src -> mart
configs -> mart/configs
fixed all paths

However, we still need to manually merge the code, because the history is unrelated.
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[ ] Bug fix (non-breatking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[ ] Test A
[ ] Test B

Before submitting

[ ] The title is self-explanatory and the description concisely explains the PR
[ ] My PR does only one thing, instead of bundling different changes together
[ ] I list all the breaking changes introduced by this pull request
[ ] I have commented my code
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?
Make sure you had fun coding 🙃

Not useful because the history in main is unrelated.


Recalculate principal components for normalized faces

After task #53 completion parameters of shapes may not have normal distribution, because each dimension of each face will be multiplied by its own constant. This will affect mathematical model of discovered function and may cause incorrect results or inefficient fitting.
Need to extract original faces given resulting PCs matrix and orthogonal rotation matrix.
Also it can be obtained just from resulting PCs. It would be interesting to compare results of both methods, which theoretically should lead to same result, but practically numerical methods will not allow this.

Faces will not be normalized anymore.  Does this still needed?