Can no longer run multiple instances of the same task within compound tasks

Type: Bug
Previously, multiple instances of the same task could be run in a compound tasks using the dependsOn option but this appears to have stopped working at some point. This feature is useful for testing e.g. to run a server and multiple clients together.
There is a workaround of duplicating tasks and giving them different names but this feels like it shouldn't be needed as this used to work correctly.
Tested on 1.82.2 and the latest 1.83.0-insider.
Possibly related to #164485 or #159640 (there are also multiple duplicate issues that reference this one).
Here's a tasks.json that reproduces this with the workaround.
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "task1",
            "type": "shell",
            "command": "sleep 100",
        },
        {
            "label": "task2",
            "type": "shell",
            "command": "sleep 100",
        },
        {
            "label": "failing task - only 1 runs",
            "dependsOn": [
                "task1",
                "task1"
            ],
        },
        {
            "label": "working task - both run",
            "dependsOn": [
                "task1",
                "task2"
            ],
        },
    ]
}

VS Code version: Code - Insiders 1.83.0-insider (c72447e8d8aaa7497c9a4bd68bc4301584b92beb, 2023-09-22T09:29:47.641Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 9 5900X 12-Core Processor             (24 x 3700)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.91GB (17.32GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

remote-wsl
ms-
0.81.4

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
a9j8j154:30646983
showlangstatbar:30737417
24365598:30687740
pythonfmttext:30716741
f8hc8238:30694864
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
copilotsettingt:30808721
asynctok:30821568
dsvsc013:30777762
dsvsc014:30777825
diffeditorv2:30786206
pythonlinttypecf:30823782
pythonmpsinfo:30842935
dsvsc015:30821418
pythontestfixt:30826906
pythonfb280951:30830809
pythonregdiag:30842812
pythonmypyd1cf:30841191

Thanks for the issue, I'm curious abt why you'd intentionally run the same task twice here.

So my actual use case is for testing a multiplayer game where I launch a server process and then multiple game clients that connect to it automatically when I launch the task, but I could also see this being useful for other applications that require multiple clients.
Here's the actual tasks.json file I use with the workaround I mentioned above:
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "problemMatcher": {
        "owner": "godot",
        "fileLocation": [
            "relative",
            "${workspaceFolder}"
        ],
        "pattern": [
            {
                "regexp": "^(.*?):\\s(.*?):\\s(.*)",
                "severity": 1,
                "code": 2,
                "message": 3
            },
            {
                "regexp": "^\\s*At: res://(.*):(\\d+)",
                "file": 1,
                "line": 2
            }
        ]
    },
    "tasks": [
        {
            "label": "Server",
            "type": "process",
            "command": "godot",
            "args": [
                "--server"
            ],
            "presentation": {
                "group": "servers"
            },
        },
        {
            "label": "Client Host",
            "type": "process",
            "command": "godot",
            "args": [
                "--host"
            ],
            "presentation": {
                "group": "clients"
            },
        },
        {
            "label": "Client Join",
            "type": "process",
            "command": "godot",
            "args": [
                "--join",
                "<IP_ADDRESS>"
            ],
            "presentation": {
                "group": "clients"
            },
        },
        {
            "label": "Client Join 2",
            "type": "process",
            "command": "godot",
            "args": [
                "--join",
                "<IP_ADDRESS>"
            ],
            "presentation": {
                "group": "clients"
            },
        },
        {
            "label": "Client Join 3",
            "type": "process",
            "command": "godot",
            "args": [
                "--join",
                "<IP_ADDRESS>"
            ],
            "presentation": {
                "group": "clients"
            },
        },
        {
            "label": "Client Join 4",
            "type": "process",
            "command": "godot",
            "args": [
                "--join",
                "<IP_ADDRESS>"
            ],
            "presentation": {
                "group": "clients"
            },
        },
        {
            "label": "Start 2 Clients",
            "dependsOn": [
                "Client Host",
                "Client Join"
            ],
            "group": {
                "kind": "build",
                "isDefault": true
            }
        },
        {
            "label": "Start 4 Clients",
            "dependsOn": [
                "Client Host",
                "Client Join",
                "Client Join 2",
                "Client Join 3"
            ],
            "group": {
                "kind": "build"
            }
        },
        {
            "label": "Start Server and 2 Clients",
            "dependsOn": [
                "Client Join",
                "Client Join 2",
                "Server"
            ],
        },
        {
            "label": "Export Windows",
            "type": "shell",
            "command": "mkdir -p builds/windows && godot --export windows",
        },
        {
            "label": "Export Mac",
            "type": "shell",
            "command": "mkdir -p builds/mac && godot --export mac",
        },
        {
            "label": "Export Linux",
            "type": "shell",
            "command": "mkdir -p builds/linux && godot --export linux",
        },
        {
            "label": "Export All",
            "dependsOn": [
                "Export Windows",
                "Export Mac",
                "Export Linux"
            ],
        }
    ]
}

This is happening because of https://github.com/microsoft/vscode/pull/180617

Thanks for the repro and for the issue. Since there is a workaround for this, I am closing this as I think the fix for it would cause bugs to resurface like the ones fixed by that PR I mentioned above.

Ok, thanks for looking into it anyways!


Read-only model format support

Just wondering if there is any way to use a read-only model file, something like what sketchfab uses [osgjs]
It would be really nice to have a protected format to provide premium content.

No, that's a proprietary format and we only support glTF. Here's a thread discussing the subject: https://twitter.com/modelviewer/status/1301557713181134850


Remove gulp-util as it is been deprecated

Follow this article: https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

This have been fix by https://github.com/ubirak/gulp-uglifycss/pull/18. We forgot to release the fix. I will do it

v1.1.0 released: https://github.com/ubirak/gulp-uglifycss/releases/tag/v1.1.0


Fix error when @option with non-method

Description
Applying the @option tag to non-method code results in an error during documentation generation.
$ cat t.rb
# @option [String] foo bar
module Foo
end

$ bundle exec yardoc t.rb
[error]: Exception occurred while generating 'Foo.html'
[error]: NoMethodError: undefined method `parameters' for #<yardoc module Foo>
[error]: Stack trace:
	/Users/yuki.kurihara/src/github.com/ksss/yard/lib/yard/code_objects/base.rb:379:in `method_missing'
	/Users/yuki.kurihara/src/github.com/ksss/yard/templates/default/tags/html/option.erb:4:in `_erb_cache_33'
	/Users/yuki.kurihara/src/github.com/ksss/yard/lib/yard/templates/template.rb:289:in `erb'
	/Users/yuki.kurihara/src/github.com/ksss/yard/lib/yard/templates/template.rb:371:in `render_section'
	/Users/yuki.kurihara/src/github.com/ksss/yard/lib/yard/templates/template.rb:261:in `block (2 levels) in run'
	/Users/yuki.kurihara/src/github.com/ksss/yard/lib/yard/templates/template.rb:258:in `each'

Files:           1
Modules:         1 (    0 undocumented)
Classes:         0 (    0 undocumented)
Constants:       0 (    0 undocumented)
Attributes:      0 (    0 undocumented)
Methods:         0 (    0 undocumented)
 100.00% documented

I have fixed it to prevent the error from occurring.
It might be acceptable to log a warning message, but for now, I've adjusted it to match the current behavior of the @param tag, which displays nothing.
Completed Tasks

[x] I have read the Contributing Guide.
[x] The pull request is complete (implemented / written).
[x] Git commits have been cleaned up (squash WIP / revert commits).
[x] I wrote tests and ran bundle exec rake locally (if code is attached to PR).

Appreciate the changes and thank you for this fix!


confused by rpn

Precomputed proposals generated by RPN trained on only base classes
what model rpn do u refer to？
could u provide the ckp of the rpn.
thx。

Precomputed proposals generated by RPN trained on only base classes what model rpn do u refer to？ could u provide the ckp of the rpn. thx。

I used the config of rpn_r101_fpn in mmdetection. I have also tred with r50 using soco pretrain. The results are close. I will provide the checkpoint of r101 later.


"Contributors" Section Design Improvement

Description
Is your feature request related to a problem? Please describe.
No. It's enhancement in the existing design.
Describe the solution you'd like
Working on the design of this section, I can make it look even better.
Describe alternatives you've considered
Modification in the existing design

@iamRabia-N Please share what kind of changes do you wish to implement in the section

@karthiknadar1204
Current Design

Expected Updated Design

We can definitely try it out,you can get started once the issue is assigned to you either by @Rakesh9100 or @akshitagupta15june

I am interested to work on this issue under GSSoC 2023 as a contributor

i would like to work on this issue, i will make its UI clean and eyecatching, i will cover 100% width, instead little amount of width that is being covered till now,  also i will fix the issue of overflowing image in mobile view, please assign it to me:)


Added support for regular expressions in paths

This fixes #449.
By supporting regular expressions in paths, it becomes possible to lift validation out of routes and into the paths themselves.
What happens when you use a RegExp:
The route doesn't run the parser, but just executes the regex. After executing the regex, instead of mapping the keys and values into an object, the indices of the regex result are mapped to an object and the named groups are assigned to the object as well.
For example:
// Route
/[/]([a-z]+)/
// Against "/foo", produces
{ 0: "foo" }

// Route
/[/](?<name>[a-z]+)/
// Against "/foo", produces
{ 0: "foo", name: "foo" }

Another thing to consider: should normal paths also expose params as indices? (so, should /:id become { 0: "foo", id: "foo" }, instead of just { id: "foo" }?)

I changed it to handle the RegExp outside of the parser, so devs don't need to handle that case. With that, these changes aren't breaking (AFAIK; it's still a change to the public API).

@JonahPlusPlus Hey, thank you! 👏 You've done an enormous work and everything seems good. I've looked briefly, so I'm going to take some time to understand better how it works.

Okay, so I got those changes done and I one final change: string paths also return indices for the params as well as the keys.
So, matching "/:id" against /foo returns { 0: "foo", id: "foo" }.
This is now consistent with regex paths.
Future work:
Provide a way to optimize routes by caching string path regexes.
Possible solution: allow passing { pattern, keys } objects to routes and allow for generating those objects outside of routes.

const idPath = cachePath(":id");

<Route path={idPath}>
...
</Route>


Print a message to the user explaining why a certain condition failed to be computed

The docstring of the condition could be used to give better context to the user about what a certain condition is. But we could have a custom exception type that provides the actual reason why we bailed out instead of simply returning None.
Issue #3274 is one of many examples of the need for better user-facing messages when conditions fail to be computed.

Maybe a special return type, that adds a reason, but also results in a skip. The original falsy value should be also part of that type and must be unboxed for checks that don't skip, as the argument.


pipe to stdout

Long-time vmd lover here 👋🏼 🙏🏼
I find myself today in a situation where vmd readme.md > index.html would come in handy.
I'd be happy to work on a PR for this if it seems feasible/wanted.

Currently you can print it to pdf from menu or copy html from devtools, but that feature doesn't seems like pretty hard and I want it too


Repeat Error 404

When I try to download at JP, it just repeats 404 and I can't download anything.
https://piccoma.com/web/product/2238?etype=episode
error occurred. retry  AxiosError: Request failed with status code 404
at zu (C:\snapshot\dist\bundle.js)
at Unzip. (C:\snapshot\dist\bundle.js)
at Unzip.emit (node:events:539:35)
at endReadableNT (node:internal/streams/readable:1345:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)
error occurred. retry  AxiosError: Request failed with status code 404
at zu (C:\snapshot\dist\bundle.js)
at Unzip. (C:\snapshot\dist\bundle.js)
at Unzip.emit (node:events:539:35)
at endReadableNT (node:internal/streams/readable:1345:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)
error occurred. retry  AxiosError: Request failed with status code 404
at zu (C:\snapshot\dist\bundle.js)
at Unzip. (C:\snapshot\dist\bundle.js)
at Unzip.emit (node:events:539:35)
at endReadableNT (node:internal/streams/readable:1345:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)
error occurred. retry  AxiosError: Request failed with status code 404
at zu (C:\snapshot\dist\bundle.js)
at Unzip. (C:\snapshot\dist\bundle.js)
at Unzip.emit (node:events:539:35)
at endReadableNT (node:internal/streams/readable:1345:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)

I just got volume and chapter wrong, sorry.


Pushing a 1.5TB dataset keeps throwing RPC error

Describe the bug
I have followed the instructions to the letter as to how to upload a large dataset, specifically:

I kept the dataset broken down into 5GB chunks.
Enabled the git lfs install and huggingface-cli lfs-enable-largefiles . modes
Connected the dataset folder to https://huggingface.co/datasets/Antreas/TALI/tree/main/video_data
Used a python script that once a file is added and converted to a .git object, it would be pushed and subsequently deleted.

I keep running into
Tracking "/data-unified/TALI/video_data/video_data_part.7z.247"
Adding /data-unified/TALI/video_data/video_data_part.7z.247
fatal: pathspec '/data-unified/TALI/video_data/video_data_part.7z.247' did not match any files
Tracking /data-unified/TALI/video_data/video_data_part.7z.206
Tracking "/data-unified/TALI/video_data/video_data_part.7z.206"
Adding /data-unified/TALI/video_data/video_data_part.7z.206
Auto packing the repository in the background for optimum performance.
See "git help gc" for manual housekeeping.
[main af1cef4] Adding remaining files
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 video_data/video_data_part.7z.206
Enumerating objects: 438, done.
Counting objects: 100% (438/438), done.
Delta compression using up to 16 threads
Compressing objects: 100% (108/108), done.
error: RPC failed; HTTP 408 curl 22 The requested URL returned error: 408
send-pack: unexpected disconnect while reading sideband packet
Writing objects: 100% (433/433), 1620.81 GiB | 204.71 MiB/s, done.
Total 433 (delta 70), reused 325 (delta 0), pack-reused 0
fatal: the remote end hung up unexpectedly
Everything up-to-date

Uploading this large dataset to hugging face hub has been a nightmare as I had to get around so many issues, so I finally decided to reach out to see if someone could help me resolve this.
Reproduction
No response
Logs
No response
System info
- huggingface_hub version: 0.14.1
- Platform: Linux-5.19.0-38-generic-x86_64-with-glibc2.35
- Python version: 3.10.9
- Running in iPython ?: No
- Running in notebook ?: No
- Running in Google Colab ?: No
- Token path ?: /home/evolvingfungus/.cache/huggingface/token
- Has saved token ?: True
- Who am I ?: Antreas
- Configured git credential helpers: store
- FastAI: N/A
- Tensorflow: N/A
- Torch: 2.0.0
- Jinja2: 3.1.2
- Graphviz: N/A
- Pydot: N/A
- Pillow: 9.4.0
- hf_transfer: N/A
- gradio: 3.21.0
- ENDPOINT: https://huggingface.co
- HUGGINGFACE_HUB_CACHE: /home/evolvingfungus/.cache/huggingface/hub
- HUGGINGFACE_ASSETS_CACHE: /home/evolvingfungus/.cache/huggingface/assets
- HF_TOKEN_PATH: /home/evolvingfungus/.cache/huggingface/token
- HF_HUB_OFFLINE: False
- HF_HUB_DISABLE_TELEMETRY: False
- HF_HUB_DISABLE_PROGRESS_BARS: None
- HF_HUB_DISABLE_SYMLINKS_WARNING: False
- HF_HUB_DISABLE_EXPERIMENTAL_WARNING: False
- HF_HUB_DISABLE_IMPLICIT_TOKEN: False
- HF_HUB_ENABLE_HF_TRANSFER: False

Anyone have any ideas? This is blocking a fairly major release.

Hi @AntreasAntoniou , I'm sorry to ear you are facing those issues. Unfortunately it's quite hard to know the root cause of the problem at the moment.
My guess is that a file that should be tracked as LFS in your local repo is not. "RPC failed HTTP 408 ..." usually means you are trying to push too much changes at once. If files are correctly tracked as LFS, it should only push a pointer (very small) and do not trigger this issue. I took a look at your .gitattributes files and there are some "weird" lines.
Those lines could be grouped. Since your chunked files have suffixes like ".193", they are not tracked as LFS with the generic rule on the first line. It is possible that a file has not been added to this list which cause your error.
*.7z filter=lfs diff=lfs merge=lfs -text
(...)
(...)
video_data/video_data_part.7z.193 filter=lfs diff=lfs merge=lfs -text
video_data/video_data_part.7z.287 filter=lfs diff=lfs merge=lfs -text
video_data/video_data_part.7z.360 filter=lfs diff=lfs merge=lfs -text
video_data/video_data_part.7z.048 filter=lfs diff=lfs merge=lfs -text
video_data/video_data_part.7z.251 filter=lfs diff=lfs merge=lfs -text
video_data/video_data_part.7z.229 filter=lfs diff=lfs merge=lfs -text

To fix it, you can update the first line by *.7z.* filter=lfs diff=lfs merge=lfs -text.
Another weird aspect that you might want to look into is to have .git files listed as well which doesn't make sense. (for example, /data-unified/TALI/.gitattributes shouldn't be an LFS file since it's just a text.
/data-unified/TALI/.git/index filter=lfs diff=lfs merge=lfs -text
/data-unified/TALI/.git/HEAD filter=lfs diff=lfs merge=lfs -text
/data-unified/TALI/.git/config filter=lfs diff=lfs merge=lfs -text
/data-unified/TALI/.git/FETCH_HEAD filter=lfs diff=lfs merge=lfs -text
/data-unified/TALI/.git/description filter=lfs diff=lfs merge=lfs -text
/data-unified/TALI/.git/COMMIT_EDITMSG filter=lfs diff=lfs merge=lfs -text
/data-unified/TALI/.gitattributes filter=lfs diff=lfs merge=lfs -text

@AntreasAntoniou That been said, I would strongly advice you to push your dataset using huggingface_hub python library. You can find a complete guide here: https://huggingface.co/docs/huggingface_hub/guides/upload. This library has several advantages:

No need to mess with git/git+lfs locally. Also no need to have a local clone of the repo to make some updates in the future.
Files that are already uploaded are not uploaded again.
Easier to debug if an error happen (more verbose output)
Progress bar while uploading.
I would advice to try to upload a file/a few files using upload_file first and if it works as expected, use upload_folder (maybe on some subfolder to avoid a commit with thousands of files).

You can also speed-up the upload by installing hf_transfer (pip install hf_transfer) and enabling it by setting HF_HUB_ENABLE_HF_TRANSFER=1 as env variable. This is a library that will take advantage of your bandwidth as much as possible. Drawback is a degraded UI (no progress bars).

All in all, very excited to know that you are publishing such a dataset! I hope the information above will help you in the process. Good luck with your release! :hugs: :hugs:

Hello there! I am doing what you said, and things appear to be working now. Thank you so much! I had previously tried using the huggingface hub API to commit and push, but that one caused issues. This alternative path of upload_file and upload_folder seem a lot easier to work with.

It's a new large scale dataset for weekly supervised, or self-supervised learning! It has lots of modalities!
BTW. I have somehow set MIT as the license when I need this to be CC4. How can I change that?

BTW. I have somehow set MIT as the license when I need this to be CC4. How can I change that?

Add license: cc-by-4.0 in your Model Card (the README file). See https://huggingface.co/docs/hub/repositories-licenses#licenses.

Thank you. It all worked fine. I have more questions, but those are for another thread!


Enhanced x735-Script: Packaging, Performance, and Automation

Dear geekworm-com Team,
I hope this message finds you well. I'm excited to present my contributions to the x735-script in this pull request. I've taken the liberty to enhance the existing script by creating a comprehensive Linux package, improving processor consumption, enhancing logging, and introducing an automated workflow for package version creation across various Linux architectures.
Enhancements Made:

Packaging: I've meticulously packaged the script to simplify installation and uninstallation. This streamlined packaging ensures a consistent and hassle-free installation process for users across different Linux distributions.
Performance Optimization: I've optimized the script's processor consumption, resulting in improved efficiency and reduced resource utilization. This enhancement aims to provide a more responsive and resource-friendly experience for users.
Enhanced Logging: I've revamped the logging mechanism to provide more detailed and informative logs. This will assist users and developers in troubleshooting and monitoring the script's behavior.
GitHub Workflow Automation: I've introduced a GitHub workflow action file that automates the process of creating new package versions tailored to different Linux architectures. This automation simplifies the release process and ensures that the latest enhancements are available to a wider audience.

Testing and Validation:
I conducted rigorous testing in various environments, including Raspberry pi 3, 4 on a Linux armfh of arm32 and arm64. All tests passed successfully, confirming the stability and reliability of these enhancements.
Documentation:
I've updated the project's documentation to reflect the changes I've made. The installation instructions now include detailed steps for using the new package, optimizing performance, and leveraging the improved logging features.
Acknowledgment of Project Guidelines:
I've ensured that my contributions adhere to the project's established coding standards, maintainability guidelines, and overall objectives. Any deviations from the norm were made with a focus on enhancing the script's usability and performance.
I'm excited to receive your feedback on these enhancements. Your insights and suggestions are invaluable to me, and I'm committed to refining my work based on your input. Thank you for considering my contributions, and I look forward to collaborating further on making x735-script even more exceptional.
Best regards,
Molham Al Nasr

Thanks to your huge contribution. @molhamalnasr @0x73-w1337
We consider that most of the users of X735 are new to Linux, and they may not be able to understand more complex scripts, so I have not merged your commit for a long time. Please understand;
I created a branch with your name, can you commit changes to the molhamalnasr branch? Or do you have other better suggestions?
Thanks

Dear @geekworm-com,
I hope this message finds you well. I appreciate your feedback on the recent pull request, and I understand the concerns about the complexity of the changes. I'd like to provide some additional insight into the modifications made to the code and how they aim to benefit both basic users and developers.
For Basic Users:
The primary goal of the code changes is to enhance the user experience, especially for those who might be new to Linux. The streamlined installation process ensures simplicity, and users can now install the X735 package with just three straightforward steps:

Execute one command to download the package.
Execute one command to install the package.
Reboot the system.

https://github.com/molhamalnasr/x735-script/releases/latest
This process eliminates the need for users to worry about the presence of additional packages like Git, manually modifying the /boot/config.txt file, or dealing with service configuration and script execution. Additionally, the new branch addresses the challenge of creating aliases for scripts, making the x735off command universally available to all users, including new ones.
For Developers:
The Pull request introduces automation to the packaging process, generating a change log and updating the readme for each new version. This ensures that the documentation is always accurate and contains the correct links and installation commands. The automation significantly reduces the potential for errors and makes the development and maintenance of the project more efficient.
I believe that these changes not only simplify the user experience but also contribute to the overall maintainability and scalability of the project. I am more than willing to address any specific concerns or make further adjustments to meet the project's objectives. Please let me know if you have any specific recommendations or if there are additional considerations to take into account.
Thank you for your time and consideration.
Best regards
@molhamalnasr


SAML Login and other Method

I add a SAML Provider for authentication (Azure AD) and I cant use the "lokal" auth method anymore.

its redirect me to the login page


Add Deadline Exceeded to transient error in resolver

Sometime webhook or git server might take time, so we need to add deadline exceeded to transient error.

Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[x] Has Tests included if any functionality added or changed
[x] pre-commit Passed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/hold
Need to test in live scenario.

We probably need this only for specific error like pipelines-webhook issue.

fyi @khrm I've opened https://github.com/tektoncd/pipeline/issues/7909 and at the moment have updated my PR https://github.com/tektoncd/pipeline/pull/7894 which checks for these transient errors on both the core controller and remote resolver side.

Merged. We can close this.
/close


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/serving-writers knative/eventing-writers
/assign knative/serving-writers knative/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/hack 7556452...d1317b0:
  > d1317b0 errexit and pipefail should remain off until downstream is fixed (# 228)
  > df80419 :bug: Fix for test failures of knative/serving# 13292 (# 227)

/test unit-tests

/test unit-tests


Switchboard Dialog Act Corpus added under datasets/swda

Pleased to announced that I added my first dataset Switchboard Dialog Act Corpus.
I think this is an important datasets to be added since it is the only one related to dialogue act classification.
Hope the pull request is ok. Wasn't able to see any special formatting for the pull request form.
The Switchboard Dialog Act Corpus (SwDA) extends the Switchboard-1 Telephone Speech Corpus, Release 2,
with turn/utterance-level dialog-act tags. The tags summarize syntactic, semantic, and pragmatic information
about the associated turn. The SwDA project was undertaken at UC Boulder in the late 1990s.
webpage
repo
Please contact me for any support!
All tests passed and followed all steps in the contribution guide!

Need to fix code formatting.

Need to fix code formatting.


scoop search error from convertfrom-json

OS 1903
It seems that extra bucket is causing this error.
Similar to https://github.com/lukesampson/scoop/issues/2568 but removing extra bucket and adding it back doesn't do the trick.
❯ scoop search vim
convertfrom-json : 传入的数组无效，结尾多出了“,”。 (1238):
{
    "##": "Renaming the downloaded zip to 'sourceforge.net.zip' is a hack for the referer header. See dl()-function in \\lib\\install.ps1",
    "homepage": "https://www.msi.com/page/afterburner",
    "description": "Overclocking utility for graphics cards. Main features include GPU/Shader/Memory clock adjustment, advanced fan speed and GPU voltage control.",
    "license": {
        "identifier": "Freeware",
        "url": "https://www.msi.com/page/website-terms-of-use"
    },
    "version": "4.6.1",
    "url": "https://download-eu2.guru3d.com/afterburner/%5BGuru3D.com%5D-MSIAfterburnerSetup461Build15561.zip#/sourceforge.net.zip",
    "hash": "4e59da5b73c5f290408851fea6e48b3b37dd6b089ae5598b3ccee43ea11fe603",
    "suggest": {
        "Visual C++ Redist 2008": "extras/vcredist2008",
        "RivaTuner Statistics Server": "extras/rtss",
        "MSI Kombustor": "extras/msikombustor",
        "FurMark": "extras/furmark"
    },
    "persist": "Profiles",
    "bin": "MSIAfterburner.exe",
    "pre_install": [
        "Expand-7zipArchive \"$dir\\MSIAfterburnerSetup*.exe\" -Removal",
        "Remove-Item \"$dir\\*\" -Include @('$PLUGINSDIR', 'Uninstall.exe.nsis', '$R0', 'Redist\\*.exe') -Recurse",
    ],
    "post_install": [
        "if(Test-Path \"$persist_dir\\AB_Profiles\") {",
        "    warn 'Migrating Afterburner profiles...'",
        "    Move-Item -Path \"$persist_dir\\AB_Profiles\\*\" -Destination \"$persist_dir\\Profiles\\\"",
        "    Remove-Item \"$persist_dir\\AB_Profiles\" -Recurse",
        "}"
    ],
    "shortcuts": [
        [
            "MSIAfterburner.exe",
            "MSI Afterburner"
        ]
    ],
    "checkver": {
        "url": "https://www.guru3d.com/files-details/msi-afterburner-beta-download.html",
        "regex": "Download ([\\d.]+) Stable/Final",
        "reverse": true
    },
    "autoupdate": {
        "url": "https://download-eu2.guru3d.com/afterburner/%5BGuru3D.com%5D-MSIAfterburnerSetup$cleanVersion.zip#/sourceforge.net.zip"
    },
    "notes": [
        "The 'RivaTuner Statistics Server' has been moved to it's own package.",
        "To install it run 'scoop install extras/rtss'.",
        "Your profiles will be migrated automatically."
    ]
}
所在位置 C:\Users\11103475\scoop\apps\scoop\current\lib\manifest.ps1:10 字符: 45
+ Get-Content $path -raw -Encoding UTF8 | convertfrom-json -ea stop
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [ConvertFrom-Json], ArgumentException
+ FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.ConvertFromJsonCommand
'extras' bucket:
    wsl-terminal (0.8.13) --> includes 'vim.exe'

'main' bucket:
    gow (0.8.0) --> includes 'vim.exe'
    neovim (0.4.2)
    psutils (0.2018.08.04) --> includes 'vimtutor.ps1'
    vim (8.1.2058)
    vimtutor (0.2018.07.25)

Fixing in https://github.com/lukesampson/scoop-extras/pull/2865

Tried rm and add again. Still the same issue. Anything else should I do to get the latest extras bucket?

It hasn't been merged yet.

@Velgus Thx. Just notice it now.

The fix was merged


chore: Pin Python dependencies with hashes

The Dockerfile needs to be changed significantly more, to use .NET 6 etc - but this commit is just about pip

Once this is in, we should do a release of some utility docs to check that works, then a package release. (The utility docs can find problems without worrying about a bogus tag etc.)


Can not shorten IP

Can not create short URLs for IPs. it is considered as valid URL on Kutt API but the extension does not allow it.

@poeti8 the current validation was done to avoid shortening internal browser URLs(chrome://flags)
i will keep the server side validation as such for the client.

@poeti8 fixed in f94479e9a9af9ddd41d5cc85ffcb44bdbd9ff422

can be released in the next feature release


Diff::merge() causes double free

The library fails with a double free when merging two Diff's built from buffers.  Is this intended to be supported?
Cargo.toml
[dependencies.git2]
version = "0.17.2"
default-features = false
features = ["vendored-libgit2"]

        use git2;

        let diff_a: &str = r#"
diff --git a/README.md b/README.md
index 18fb8328..ce60f40c 100644
--- a/README.md
+++ b/README.md
@@ -4,1 +4,2 @@ componentwise
 reusing
+proverb
"#
        .trim_start();
        let mut diff_a = git2::Diff::from_buffer(diff_a.as_bytes()).unwrap();

        let diff_b: &str = r#"
diff --git a/README.md b/README.md
index 18fb8328..ce60f40c 100644
--- a/README.md
+++ b/README.md
@@ -4,2 +4,3 @@ componentwise
 reusing
 proverb
+offended
"#
        .trim_start();
        let diff_b = git2::Diff::from_buffer(diff_b.as_bytes()).unwrap();

        diff_a.merge(&diff_b).expect("merge diff from buffers");

Results in:
free(): double free detected in tcache 2
error: test failed, to rerun pass `-p radicle-cli --lib`

Edit: simplified example and added Cargo information

You may want to open this on libgit2 directly, as the frees are probably coming from there.

I filed an upstream issue at https://github.com/libgit2/libgit2/issues/6588.


Function that draws text in vertical columns.

Works on #43

Pull Request Test Coverage Report for Build 733

44 of 46 (95.65%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 90.331%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

draw/vertical_text.go
44
46
95.65%

Totals

Change from base Build 731:
0.05%

Covered Lines:
4858

Relevant Lines:
5378

💛  - Coveralls


Database migration to create initial database structure

I have added a database migration that will create the initial database structure.
Documentation for the structure is available here.
To run the migration on your local dev database, run the following command:
alembic upgrade head

This will create all the tables and foreign key constraints.
Note: that I have not yet created a script to populate the following lookups:

language
geography
source
action_type

I will concentrate on adding this next

@chrisaballard the command runs successfully and the ER diagram generated by PgAdmin looks to be the same as the one you designed, from visual inspection. Is there anything else I should check for before approving this?

I have created a new database migration to populate standard lookup values for the following tables:

language
geography
action_type
source

Also made some of the columns on the language and geography tables nullable as those fields were not present in the lookup data.
The data is loaded from two text files which are stored in /backend/app/alembic/versions/lookups:

language-iso-639-3.txt - iso 639-3 standard language codes
geography-iso-3166.csv - contains country codes that were defined for the original prototype.

The downgrade migration will remove the inserted lookup values from the tables and will reset the columns make not not_nullable.
Run alembic upgrade head to run the migration

@chrisaballard where is the data stored which populates the source and action_type lookup tables?


Update Configs to 0.7.9

[x] Closes #54
[x] Closes #55
[x] Closes #57
[x] Closes #58
[x] Closes #62
[x] Closes #63
[x] Closes #64
[x] Closes #65
[x] Closes #66
[x] Closes #67
[x] Closes #68
[x] Closes #69
[x] Closes #70
[x] Closes #83
[x] Closes #85
[x] Closes #86
[x] Closes #87
[x] Closes #88
[x] Closes #90
[x] Closes #6
[x] Closes #92
[x] Closes #95
[x] Closes #97
[x] Closes #98
[x] Closes #100
[x] Closes #101
[x] Closes #103
[x] Closes #104

OK all classes "done", only some cleanup and test fixing left.


support to boot guest with an initrd image

If an initrd image is configured in HypervisorConfig or passed in by annotations, append it to qemu command line arguments so that we boot the guest OS with the specified initrd image rather than a rootfs disk image.
A sample qemu command line:

-name pod-test9 -uuid 9fc4a0e0-52a3-4e1c-b562-14b5c197dd2b -machine pc,accel=kvm,kernel_irqchip,nvdimm -cpu host,pmu=off -qmp unix:/run/virtcontainers/pods/test9/mon-9fc4a0e0-52a3-4e1c-b562-14b5c197dd2b,server,nowait -qmp unix:/run/virtcontainers/pods/test9/ctl-9fc4a0e0-52a3-4e1c-b562-14b5c197dd2b,server,nowait -m 2048M,slots=2,maxmem=4720M -device virtio-serial-pci,disable-modern=true,id=serial0 -device virtconsole,chardev=charconsole0,id=console0 -chardev socket,id=charconsole0,path=/run/virtcontainers/pods/test9/console.sock,server,nowait -device virtio-scsi-pci,id=scsi0,disable-modern=true -device virtserialport,chardev=charch0,id=channel0,name=agent.channel.0 -chardev socket,id=charch0,path=/run/virtcontainers/pods/test9/kata.sock,server,nowait -device virtio-9p-pci,disable-modern=true,fsdev=extra-9p-kataShared,mount_tag=kataShared -fsdev local,id=extra-9p-kataShared,path=/run/kata-containers/shared/pods/test9,security_model=none -rtc base=utc,driftfix=slew -global kvm-pit.lost_tick_policy=discard -vga none -no-user-config -nodefaults -nographic -daemonize -kernel /golang/src/github.com/hyperhq/hyperstart/build/arch/x86_64/kernel -initrd /golang/src/github.com/kata-containers/osbuilder/kata-initrd.img -append tsc=reliable no_timer_check rcupdate.rcu_expedited=1 i8042.direct=1 i8042.dumbkbd=1 i8042.nopnp=1 i8042.noaux=1 noreplace-smp reboot=k console=hvc0 console=hvc1 iommu=off cryptomgr.notests net.ifnames=0 pci=lastbus=0 debug panic=1 initcall_debug ip=::::::test9::off:: agent.log=debug -smp 1,cores=1,threads=1,sockets=1,maxcpus=240

fixing @jodh-intel and @sboeuf 's comments, lgtm

@jodh-intel @sboeuf change applied. PTAL.

LGTM
@bergwolf thanks for the changes !

Travis green. It seem jenkins is broken again.

Thanks @bergwolf.
lgtm
P.S. I want that qemu command-line printed on a T-shirt! :smile:

Once this lands, presumably, we'll want some new initrd tests to be created in https://github.com/kata-containers/tests?

@jodh-intel Yes, we need to add some initrd tests for it.

Hi @bergwolf. The CI is failing with a real error:
docker: Error response from daemon: OCI runtime create failed: /usr/share/defaults/kata-containers/configuration.toml: file /usr/share/kata-containers/kata-containers-initrd.img does not exist: unknown.

I think we need to do the following:

Change the Makefile so that by default the config file will contain an empty initrd value (meaning "no initrd will be used"):
# Path to initial ramdisk / initramfs image (optional)
initrd = ""

Add a check in Makefile so that if the user runs make initrd=yes (or similar) the config file will contain the initrd path:
initrd = "/usr/share/kata-containers/kata-containers-initrd.img"

Update .travis.yml so that it builds with and without an initrd.
But you'll also need to generate the image for the "with" scenario of course.

@jodh-intel initrd is just a configuration. I don't think it needs to go into Makefile to set it. The test scripts can be tweaked to test proper targets. https://github.com/kata-containers/tests/issues/172 is to enable the CI tests to do such testing properly.
OTOH, do we have an equivalent way in https://github.com/kata-containers/tests that works similarly in our Jenkins setup to configure env matrix in .travis.yml? E.g., in .travis.yml, I would be able to configure CI with following change:
diff --git a/.travis.yml b/.travis.yml
index 8887def..761453e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,6 +13,10 @@ go_import_path: github.com/kata-containers/runtime
 go:
   - 1.8

+env:
+  - AGENT_INIT=yes TEST_INITRD=yes OSBUILDER_DISTRO=alpine
+  - AGENT_INIT=no TEST_INITRD=no
+
 before_script:
   - ".ci/static-checks.sh"

hmmm, it can be set in Jenkins's job config. We can do it after this one and kata-containers/tests/pull/173 are both merged.

Now with kata-containers/tests/pull/173, all checks passed. Merging as it is already approved.


fix short circuit evaluation

Codecov Report

Merging #25 (178bd05) into main (1d9af96) will decrease coverage by 2.41%.
The diff coverage is 64.70%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   88.65%   86.24%   -2.42%
==========================================
  Files          15       15
  Lines        1966     1963       -3
==========================================
- Hits         1743     1693      -50
- Misses        223      270      +47

Impacted Files
Coverage Δ

optpy-std/src/lib.rs
27.31% <0.00%> (+0.68%)
:arrow_up:

optpy-generator/src/lib.rs
85.34% <100.00%> (-6.83%)
:arrow_down:

optpy-parser/src/expression.rs
84.96% <0.00%> (-9.16%)
:arrow_down:

optpy-parser/src/simplify/list_comprehension.rs
89.22% <0.00%> (-5.39%)
:arrow_down:

optpy-resolver/src/builtin/mod.rs
92.13% <0.00%> (-4.50%)
:arrow_down:

optpy-resolver/src/name/mod.rs
94.32% <0.00%> (-1.90%)
:arrow_down:

optpy-resolver/src/call/mod.rs
97.10% <0.00%> (-0.87%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


$db->list_fields($table) not work on SQLite3

The list_fields should be implemented, it's a very important feature for many use cases.

Hello, sorry to comment on this issue when it's closed, but when attempting to use this method on in my CI 3 app I get the following error:
This feature is not available for the database you are using.

my database config is as follows:
$db['default'] = array(
	'dsn'	=> '',
	'hostname' => '',
	'username' => '',
	'password' => '',
	'database' => 'path/to/my/sqlite.db',
	'dbdriver' => 'sqlite3',
	'dbprefix' => '',
	'pconnect' => FALSE,
	'db_debug' => TRUE,
	'cache_on' => FALSE,
	'cachedir' => '',
	'char_set' => 'utf8',
	'dbcollat' => 'utf8_general_ci',
	'swap_pre' => '',
	'encrypt' => FALSE,
	'compress' => FALSE,
	'stricton' => FALSE,
	'failover' => array(),
	'save_queries' => TRUE
);

I am stuck as to why this is happening. Thanks for any help you can provide.


Don't print '::1 localhost'

I'll try to be as detailed as possible.
The 'hosts' file generated should be the exact same file that is generated without this commit.
The problem is that ==>::1 localhost<== is printed in the Terminal / Command Prompt output.
I tested it and the generated hosts file has the same md5 sum with or without the commit, as it should be.
Everything that is not handled by the function removeDupsAndExcl() is printed in the command prompt. For example comments or empty lines ( you can try it by deleting the part that checks for comments and they'll show up in the Terminal window and not in the 'hosts' file).
Three of the sources have hosts files that include ::1 localhost in them and it wasn't handled by  removeDupsAndExcl()
The output before was:

Do you want to update all data sources? [Y/n] n
OK, we'll stick with what we've  got locally.
Do you want to exclude any domains?
For example, hulu.com video streaming must be able to access its tracking and ad servers in order to play video. [Y/n] n
OK, we'll only exclude domains in the whitelist.
==>::1 localhost<==
==>::1 localhost<==
==>::1 localhost<==
Success! Your new hosts file has been prepared.
It contains 26,932 unique entries.
Do you want to replace your existing hosts file with the newly generated file? [Y/n] n

And it should be:

Do you want to update all data sources? [Y/n] n
OK, we'll stick with what we've  got locally.
Do you want to exclude any domains?
For example, hulu.com video streaming must be able to access its tracking and ad servers in order to play video. [Y/n] n
OK, we'll only exclude domains in the whitelist.
Success! Your new hosts file has been prepared.
It contains 26,932 unique entries.
Do you want to replace your existing hosts file with the newly generated file? [Y/n] n

I hope I was clear, also I don't know if you want to include ::1 localhost in the generated 'hosts' I don't know if there is any benefit (currently it's not included in the generated 'hosts' and it works fine as is).

Makes perfect sense.  Thanks!


Ethereum Ropsten Support

AC:

Veryify working coinstack locally (init.sh, readiness.sh)
Deploy to personal aws account
Update .circleci/config.yml to deploy develop and production public coinstacks

Steps:

Verify indexer.daemon.chain (specified in your copy of coinstacks/ethereum/pulumi/Pulumi.sample.yaml) parameter works correctly to deploy a local kubernetes instance of an ethereum ropsten coinstack

There will be pulumi resource naming conflicts that need to be handled. It would make the most sense to update the asset name in coinstack/ethereum/pulumi/index.ts to append the chain type if it is not mainnet.

Ensure signal catching works correctly still as defined in coinstacks/ethereum/daemon/init.sh (should work the same as mainnet node)
Ensure readiness check works as defined in coinstacks/ethereum/daemon/readiness.sh (should work the same as mainnet node)
Deploy and sync ethereum ropsten coinstack to personal aws account
Update .circleci/config.yml with jobs to deploy ethereum ropsten coinstacks to the develop and production environments, specifying the correct daemon-chain paramter

Until now, I managed to set up the project; edit the sample .yaml files in order to spin up a ropsten stack; and, deploy the common stack. But, when deploying the ethereum stack, I keep getting an error for the daemon monitor, which reads like this: "Job backoff limit exceeded". Essentially, the readiness check fails with exit code 1 each time the job is run. Looking at the readiness.sh file, my understanding is that this happens because the ropsten node on the unchained-probe docker image is not synced. In fact, it would take much, much more than the backoff limit of 5 job runs to wait for the node to fully sync with the ropsten network.
My question is: did you encounter this when deploying the mainnet daemon monitor; and, if so, how did you managed to wait for the syncing? If not, would you kindly offer me your experienced advice on whether my poor setup might be the cause for this? As a note, in order to set up the ropsten node, I carefully followed these instructions: https://github.com/shapeshift/unchained/blob/develop/docs/docker-desktop.md, after I changed the indexer.daemon.chain and asset name, the way you suggested.


chain2 and nested_chain test addition

chain2 and nested_chain test addition

This is the last PR that was in #184 . The other changes were mere renamings

Reordered stuff like in #208 and #209, which you accepted. Should everything be like this?

I accepted #208 and #209 because I felt they did not reduce too much readability, but as I said in #204, I prefer when everything is on the same line, or two close lines, like this:
let r1 = f(&b"abcdabcdefghefghX"[..]);
assert_eq!(r1, Done(&b"X"[..], B{a: 1, b: 2}));

let r2 = f(&b"abcdefghefghX"[..]);
assert_eq!(r2, Done(&b"X"[..], B{a: 1, b: 2}));

or like this:
assert_eq!( f(&b"abcdabcdefghefghX"[..]), Done(&b"X"[..], B{a: 1, b: 2}));
assert_eq!(f(&b"abcdefghefghX"[..]), Done(&b"X"[..], B{a: 1, b: 2}));

This is really a matter of taste, but since I'll have to maintain it, I'd rather have everything fit the style I'm used to.

So I revert/delete the last commit here?

yes, please do

Done

Ok. Now every PR, involving tests got reordered and partially rebased to the new master. Now everything should be fine.

Thanks


Cannot install due to missing dependency: getopts

I'm trying to install with fisher anicode but it fails with:
Installing 1 plugin/s
OK Copy anicode
Installing 3 dependencies
OK Copy spin
OK Copy get
OK Copy choices
OK Copy getopts
! Fetch getopts github.com/fisherman/getopts
OK Fetch getopts github.com/fisherman/getopts
cp: cannot stat '/home/martin/.cache/fisherman/getopts': No such file or directory
Done in 1s 807ms

I worked fine after manual fisher getopts but it seems there is something wrong in fisher.

Also experienced this issue, and as @martin-g mentioned, installing getopts manually fixed the issue.

Unable to dig on this on the moment, maybe on last quarter of january. Sorry

Taking a little bit longer, sorry. Maybe this sunday i will check that bug too.
Thanks for the patience

Solved


Few problems on the display of model. The redstone torch lose direction that it get attached and buttons will display as a stone full block

Fixed in 1.3


The sui_pay call doesn't contain the transaction hash

Hello,
When I request the json rpc call: https://docs.sui.io/sui-jsonrpc#sui_pay, the response didn't contain the transaction hash.It is not convenient since I have to assemble the txbytes, signature and public key to get the transaction hash. Would you please add the the txHash to the response of sui_pay call?

as the link you listed, the input of sui_pay does not include a signature, which is required to generate a txn digest or the hash, if you execute that txn, the response has a digest here
https://github.com/MystenLabs/sui/blob/472a5f5304a4663835032719c047e70b8dc9107d/crates/sui-json-rpc-types/src/lib.rs#L1746

Yes,I know, but I want to generate the txn digest before exeucting the transaction, which will save to database to track the transaction.


Support for multiple sections

I have been thinking about how to extend this useful package to support multiple sections, for example:
User-agent: PowerMapper
Allow: /

User-agent: SemrushBot
Allow: /

User-Agent: *
Disallow: /

I appreciate it's a relatively niche requirement so was thinking about adding app setting Umbraco.Robots.Advanced which could contain JSON such as  [{ua:'PowerMapper',allow:'/'},{ua:'SemrushBot',allow:'/'},{ua:'*',disallow:'/'}]
When Umbraco.Robots.Advanced has a value, Umbraco.Robots.UserAgent, Umbraco.Robots.Disallow & Umbraco.Robots.Allow would be ignored. Umbraco.Robots.Sitemaps would continue to be used.
Just an idea, maybe there is a better approach... 🤔

Thanks @Jeavon, I've been dreading someone bringing this up...! 😂
There's certainly value in supporting this, and it's something I've thought about. Keeping the configuration nice and simple has always been the sticking point - this will get so much easier with V9 thankfully.
What about picking up the app settings by convention: Umbraco.Robots.{UserAgent}.{Property} e.g. Umbraco.Robots.PowerMapper.Allow. You could then keep the existing Umbraco.Robots.Allow etc for the catch-all * useragent.
Perhaps making this configurable in code would make sense as an initial step, won't be too hard...

@callumbwhyte Sorry! I also thought about app settings with a naming convention, the order is important and I'm not sure if the order of app settings is maintained when iterating through in C#?

@Jeavon When you say "order is important", do you mean the order the definitions are rendered in the robots.txt or the order they are configured in?
If it's the former, I assume the only requirement is the catch-all * to come last? In which case, we just need to ensure that is added last when we build the configuration object.
If it's the latter and order of config matters, care to share why?

@callumbwhyte there is a convention for bots that they evaluate the sections in order and stop when they hit a match, I can't think of a scenario when it matters apart from as you say that the catchall is last, so sounds good to me!


The context chip based click and search doesn't seem to work on Metrics Tab

Version where bug was found:
e.g "6.0"
Describe the bug
The context chip based click and search doesn't seem to work on Metrics Tab. We do have this feature in Experiment, Segment & Feature Flag Pages.

QA Passed


LoRA vs. QLoRA performance comparison

When I try both LoRA and QLoRA fine-tuning approaches using the same parameters and base model, I found that some metrics (e.g. tokens_sec, gpu, etc.) don't have a significant advantage, and how should I interpret these data. The yellow color in the figure below represents the QLoRA approach (4 bit) and the purple color represents the LoRA approach.

@mzbac During the inference of the model, it is indeed a bit faster with 4bit. Apart from the 0.5B small model, I also tried the 2.7B phi2 model, but basically did not see any significant advantage of QLoRA during fine-tuning.

Are you referring to the fact that Qlora took a similar amount of memory as Lora? I think there is a caching issue in mlx at the moment. I believe mlx team is working on that.

For single machine training the primary advantage of QLoRA over LoRA is that it requires a lot less memory. You will see a bigger advantage for bigger models, where the model itself accounts for most of the memory.
In fact, if you have enough RAM for regular LoRA it can be faster. The reason is that training is typically compute bound, meaning it's bound by how fast we can do basic multiplies and additions. If you use quantization then you are increasing the amount of compute in a given matrix multiplication. This means training will be slower.
So I would use QLoRA for fine-tuning very large models that use a lot of your machine's memory. But for small models regular LoRA is going to be faster and more accurate so probably the right call.
As a side note I do not rely much on the system memory use reports because I have found them to be innacurate (sometimes by large amounts). We are adding some APIs to let you query memory use in https://github.com/ml-explore/mlx/pull/761 (mx.get_active_memory, mx.get_peak_memory, etc).

Corresponding information has been added https://github.com/ml-explore/mlx-examples/pull/528


Increase the number of asynchronous I/O (AIO) requests allowed system-wide in the docker container.

Increase the number of asynchronous I/O (AIO) requests allowed system-wide in the docker container.

Inspect the docker image of scyllaDB for Entry point
$ > docker inspect <image_id>
...
"Entrypoint": [
                "/docker-entrypoint.py"
            ],
...

An abstraction created to include sysctl -p. Follow the file custom-docker-entrypoint.sh


sealos can't load docker image

Which command or component
[root@ecs-cluster-node-1-0001 k8s_install]# sealos load -i kube-webhook-certgen.tar
Error: loading index: open /var/tmp/oci513443904/index.json: no such file or directory
Usage:
  sealos load [flags]

Examples:
sealos load -i kubernetes.tar

Flags:
  -h, --help               help for load
  -i, --input string       load image from tar archive file
  -t, --transport string   load image transport from tar archive file.(optional value: oci-archive, docker-archive) (default "oci-archive")

Global Flags:
      --cluster-root string   cluster root directory (default "/var/lib/sealos")
      --debug                 enable debug logger

loading index: open /var/tmp/oci513443904/index.json: no such file or directory

The Description of the bug
Describe the bug.
How to reproduce（pictures can be attached if necessary）

get docker image:

docker pull registry.k8s.io/ingress-nginx/kube-webhook-certgen:v1.3.0

save the image to a tar ball
upload the tar ball to a linux environment
4.use sealos to load the tar ball

sealos load -i kube-webhook-certgen.tar
What you expected to happen
sealos can load the tar ball correctly
Operating environment

Kubernetes version: 1.24.0
Sealos version: {"gitVersion":"4.1.0-rc3","gitCommit":"55cdca07","buildDate":"2022-08-25T02:17:16Z","goVersion":"go1.19","compiler":"gc","platform":"linux/amd64"}
Operating system: eg. centos7
Cluster size: eg 3 master, 0 node

The docker image cannot be loaded with sealos. The sealos load is the cluster image. The cluster image is built using sealos build. Although cluster image is compatible with the OCI image repository standard, it is not compatible with the local storage method of docker.

https://www.sealos.io/docs/examples/build-example-cloudimage  Using sealos build to save distribute application all dependencies into cluster image, you don't need to care about how sealos to save and pull docker image.

[root@ecs-cluster-node-1-0001 k8s_install]# sealos load -i kube-webhook-certgen.tar
Error: loading index: open /var/tmp/oci513443904/index.json: no such file or directory
Usage:
  sealos load [flags]

Examples:
sealos load -i kubernetes.tar

Flags:
  -h, --help               help for load
  -i, --input string       load image from tar archive file
  -t, --transport string   load image transport from tar archive file.(optional value: oci-archive, docker-archive) (default "oci-archive")

Global Flags:
      --cluster-root string   cluster root directory (default "/var/lib/sealos")
      --debug                 enable debug logger

loading index: open /var/tmp/oci513443904/index.json: no such file or directory

sealos load -i kube-webhook-certgen.tar  -t docker-archive  , you can load docker image using  sealos


Transfer to OME org, publish to GitHub

https://github.com/ome/omero-server-docker/pull/51#issuecomment-774017960
@jburel I've just tagged v1.0.0 and created a GitHub release. Do you want to transfer this to the ome org now and keep me as an admin?
In addition it would be nice to publish this to the GitHub marketplace:
https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace#publishing-an-action
but an organisation admin will have to agree to the terms and conditions.

@jburel Are you still planning to move this to the ome org? I'd like to make use of this action, so having it in it's final home would be great!

@manics sorry I had many things to do and forgot about that one. I will take of that.

@jburel I'm using this in a JupyterHub repo, so to make things easier I'll move it to that github org instead. The other advantage is OME won't need to sign the GitHub actions agtreement to publish it which opefully makes things slightly easier for you.

sorry @manics I completely forgot about it since I put some of the work onhold due to other deadlines
Could you point me to the new repo?
I made few changes at the time on my branch, if they are not included I will submit them

https://github.com/jupyterhub/action-major-minor-tag-calculator

thanks


ForTea some times show empty tooltip

e.g. for System.IO.Path.GetDirectoryName as seen in screenshot

It seems to be ReSharper 10 only, will investigate.


Build failing on master

I'm trying to add new tests so #167 can be merged, but the automated build is currently broken.
Is there an ETA to fix it?

This is due to some internal changes in the latest Node version. You can add your tests and ignore that one failing tests about sessions.
Duplicate of #243


Target profile page rewrite: Create local GraphQL server to interact with existing OT API

Closing this as we now have a basic API, available in the platform-api repo.


Change implementation of AdjGraph

Replace current implementation of AdjGraph with one partially derived from ocamlgraph's Persistent.Graph.Concrete module, using our custom Vertex type. In a few cases, this changes the names of functions we use, e.g. add_edge vs add_edge_e, but mostly everything looks the same from an API perspective as before.
This PR closes #12.

We talked about this in person, but just so there's a record:
First, make test is reporting several errors -- those should definitely be addressed before this is merged into master.
Additionally, the current AdjGraph file is very cluttered and I'm having a hard time figuring out what's going on in it. A lot of the clutter was there before, but I think we should take this opportunity to clarify the module's structure and capabilities. Part of this is removing old code (both commented out code, and code which isn't typically used). We should also probably move the VertexMap etc. structures into Collections, or remove them if it turns out they're not used. Ideally, the result would look like a module that someone just put together from scratch, rather than something which has been cobbled together over a long period of time (even though it has).

Looking into the cause of the errors we're currently seeing in make test, here are the two query files for property.nv from master and graph-reimpl. It's clear that master generates a much larger query than graph-reimpl does (432 lines versus 251).
property.master-query.txt
property.graph-reimpl-query.txt

Outputs from running ./nv -m -query -v examples/property.nv with optimize = false in SmtUtils.ml:
property.graph-reimpl-query-no-opt.txt
property.master-query-no-opt.txt


Relax bounds

Thanks for the PR.
Let me address the bumps in separate PR together with more comprehensive update of CI config.
I'll try to release the updated version to hackage if things go well.
Superseded by https://github.com/Holmusk/servant-hmac-auth/pull/67

FYI uploaded 0.1.7 with these version bumps to hackage
https://hackage.haskell.org/package/servant-hmac-auth

Thanks!


[20723] Include v2.13.4 release notes

Description

This PR includes the release notes of Fast DDS v2.13.4 in latest documentation (master)

Contributor Checklist

[x] Commit messages follow the project guidelines.
N/A Code snippets related to the added documentation have been provided.
[x] Documentation tests pass locally.
N/A Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[ ] The title and description correctly express the PR's purpose.
[ ] Check contributor checklist is correct.
[ ] CI passes without warnings or errors.

@richiprosima please test this

We may be missing to update docs/notes/versions.rst Shapes Demo related version in 2.13.x to v2.13.4

@richiprosima please test this


Crash

Version
2.2.1 (bd54d6c)
Seed
R620-FNQ1-ZTJJJMZ9FGEQK49K49ZZZZZZZZZZZZZ
Scenario
RE 2 (Leon A)
What happened?
Got to the warehouse door room and going down the elevator crash's the game

@Ripperc100jr can you give more information about which room and elevator you are referring to?

The room where you open the warehouse door as leon and use the lighter to grab extra supplies. Going down that elevator in that room causes the crash

Duplicate of #228


Add more peer ID entropy

This still keeps the peer ID printable as ascii, while adding lots more
entropy

16777216x as many possible peer ids 👍

Thanks for the review @DiegoRBaquero


[BUG] - Problem building minting tx with cardano-cli

Internal/External
External   otherwise.
Area
Native Tokens    Related to Native Tokens (Mary).
Summary
When building a minting transaction, cardano-cli rejects the letter 'S' as not being alphanumeric.
Steps to reproduce
Executing the following minting transaction:
cardano-cli transaction build --mainnet --alonzo-era --tx-in 09b4[...]bf0#0 --tx-out addr1v8[...]jv7+1400000+1 a14[...]dd4.ShawnHead1 --change-address addr1v8[...]jv7 --mint=1 a14[...]dd4.ShawnHead1 --minting-script-file policy/policy.script --metadata-json-file metadata.json --invalid-hereafter 48745000 --witness-override 2 --out-file matx.raw

gave me this error:
option --tx-out:
unexpected 'S'
expecting alphanumeric asset name, white space, "+" or end of input

and a usage message.
The character being objected to (first letter of asset name) is alphanumeric so this seems like a bug.
I was able to mint with an empty string as the asset name so there isn't anything wrong with the variable settings or environment.
Expected behavior
The command should accept the asset name and create the transaction.
System info (please complete the following information):

OS Name: Ubuntu
OS Version 20.04
Node version

cardano-node 1.32.1 - linux-x86_64 - ghc-8.10
git rev e9de7a2cf70796f6ff26eac9f9540184ded0e4e6

CLI version

cardano-cli 1.32.1 - linux-x86_64 - ghc-8.10
git rev e9de7a2cf70796f6ff26eac9f9540184ded0e4e6

I have the same problem. Is there anybody who resolved this problem?

I am trying to mint NFT in Cardano testnet, I am also facing the same issue.
vagrant@vagrant:~/nft$ cardano-cli transaction build --testnet-magic<PHONE_NUMBER> --byron-era --tx-in $txhash#$txix --tx-out $address+$output+"$tokenamount $policyid.$tokenname" --change-address $address --mint="$tokenamount $policyid.$tokenname" --minting-script-file $script --metadata-json-file metadata.json  --invalid-hereafter $slotnumber --witness-override 2 --out-file matx.raw
option --tx-out:
unexpected 'N'
expecting alphanumeric asset name, white space, "+" or end of input
Other details:
vagrant@vagrant:~/nft$ echo $output $tokenamount $tokenname
1400000 1 NFTFIROJ
vagrant@vagrant:~/nft$ echo $output $tokenamount $tokenname1
1400000 1
vagrant@vagrant:~/nft$ echo $CARDANO_NODE_SOCKET_PATH
/home/vagrant/cardano/db/node.socket
vagrant@vagrant:~/nft$ echo $LD_LIBRARY_PATH
/usr/local/lib:/usr/local/lib:
vagrant@vagrant:~/nft$ echo $PKG_CONFIG_PATH
/usr/local/lib/pkgconfig:/usr/local/lib/pkgconfig:
vagrant@vagrant:~/nft$ cardano-node --version
cardano-node 1.32.1 - linux-x86_64 - ghc-8.10
git rev 4f65fb9a27aa7e3a1873ab4211e412af780a3648
vagrant@vagrant:~/nft$ cardano-cli --version
cardano-cli 1.32.1 - linux-x86_64 - ghc-8.10
git rev 4f65fb9a27aa7e3a1873ab4211e412af780a3648
Please let us know any workaround for this issue.

Using a empty token name is working ... however it is not a valid workaround yet

same here. using cardano-node 1.32.1 also
cardano-cli 1.32.1 - darwin-x86_64 - ghc-8.10
git rev 4f65fb9a27aa7e3a1873ab4211e412af780a3648

This is not a bug, cli 1.32.1 is now operating in hex representation of nativeAssets. So all must be done directly in hexcode!
There is a warning about that in the release notes:
https://github.com/input-output-hk/cardano-node/releases/tag/1.32.1
A reference usage can be found in the docs:
https://github.com/input-output-hk/cardano-node/blob/master/doc/reference/multi-assets.md

It would be nice if these kind of breaking changes would be coordinated with Cardano Foundation docs.

Does this mean we need to do something like:
echo -n "Hello" | od -A n -t x1
48 65 6c 6c 6f
to end up with an asset name of:
48656c6c6f

It would be nice if these kind of breaking changes would be coordinated with Cardano Foundation docs.

You will find non consistent examples all over the place, in many tutorials, etc. Thats why the Release Notes are there IMO.

Does this mean we need to do something like:
echo -n "Hello" | od -A n -t x1
48 65 6c 6c 6f
to end up with an asset name of:
48656c6c6f

There are many ways to convert it yes, like:

If this is closed then maybe we need a new issue to change the error message to "Asset name must be hexidecimal" as the current error message is incorrect.

would be coordinated with Cardano Foundation docs.

Just a note that those are more of a community maintained documentations where PRs are welcome , thus - only as strong as community activity 👍🏻

If this is closed then maybe we need a new issue to change the error message to "Asset name must be hexidecimal" as the current error message is incorrect.

PR to change the error message submitted:
https://github.com/input-output-hk/cardano-node/pull/3466

If this is closed then maybe we need a new issue to change the error message to "Asset name must be hexidecimal" as the current error message is incorrect.

PR to change the error message submitted: #3466

Awesome! Thanks.

FYI, I created a PR for the CF native asset and NFT minting docs to use hex asset names.
https://github.com/cardano-foundation/developer-portal/pull/454

If this is closed then maybe we need a new issue to change the error message to "Asset name must be hexidecimal" as the current error message is incorrect.

cc: @cblp

@cblp https://github.com/input-output-hk/cardano-node/pull/3466

thank you guys for your input and initiative.
@shawnim can we close this issue and keep only the created PRs (thank you @gitmachtl)?

Yes. Thanks!

Internal/External External otherwise.
Area Native Tokens Related to Native Tokens (Mary).
Summary When building a minting transaction, cardano-cli rejects the letter 'S' as not being alphanumeric.
Steps to reproduce Executing the following minting transaction:
cardano-cli transaction build --mainnet --alonzo-era --tx-in 09b4[...]bf0#0 --tx-out addr1v8[...]jv7+1400000+1 a14[...]dd4.ShawnHead1 --change-address addr1v8[...]jv7 --mint=1 a14[...]dd4.ShawnHead1 --minting-script-file policy/policy.script --metadata-json-file metadata.json --invalid-hereafter 48745000 --witness-override 2 --out-file matx.raw

gave me this error:
option --tx-out:
unexpected 'S'
expecting alphanumeric asset name, white space, "+" or end of input

and a usage message. The character being objected to (first letter of asset name) is alphanumeric so this seems like a bug. I was able to mint with an empty string as the asset name so there isn't anything wrong with the variable settings or environment.
Expected behavior The command should accept the asset name and create the transaction.
System info (please complete the following information):

OS Name: Ubuntu
OS Version 20.04
Node version

cardano-node 1.32.1 - linux-x86_64 - ghc-8.10
git rev e9de7a2cf70796f6ff26eac9f9540184ded0e4e6

CLI version

cardano-cli 1.32.1 - linux-x86_64 - ghc-8.10
git rev e9de7a2cf70796f6ff26eac9f9540184ded0e4e6

I think the problem may be related with bash.


build fails, finding src/rust-installer/gen-installer.sh to be missing

...
sh src/rust-installer/gen-installer.sh --product-name=Rust --rel-manifest-dir=rustlib --success-message=Rust-is-ready-to-roll. --image-dir=target/x86_64-unknown-linux-gnu/debug/dist/cargo-0.3.0-x86_64-unknown-linux-gnu-image --work-dir=./target/x86_64-unknown-linux-gnu/debug/dist --output-dir=./target/x86_64-unknown-linux-gnu/debug/dist --non-installed-overlay=target/x86_64-unknown-linux-gnu/debug/dist/cargo-0.3.0-x86_64-unknown-linux-gnu-overlay --package-name=cargo-0.3.0-x86_64-unknown-linux-gnu --component-name=cargo --legacy-manifest-dirs=rustlib,cargo
sh: 0: Can't open src/rust-installer/gen-installer.sh
Makefile:204: recipe for target 'target/x86_64-unknown-linux-gnu/debug/dist/cargo-0.3.0-x86_64-unknown-linux-gnu.tar.gz' failed
make: *** [target/x86_64-unknown-linux-gnu/debug/dist/cargo-0.3.0-x86_64-unknown-linux-gnu.tar.gz] Error 127

It seems that gen-installer.sh is not present where it is supposed to be.
I had attempted and failed a configure prior to running make (cmake missing, installed cmake, resumed), aside from that there is nothing abnormal about my env that I can think of.
Oh, and my rustc version is rustc 1.2.0-dev (ffe0b6657 2015-06-21)

Never mind I didn't follow instructions it's probably nothing


Only check for moving draggable in canvas renderer when map is draggable

This is a fix for #3941

Good catch! See code comments :)

Ok, I just added a moving() method to the MapDrag handler, just like the moved() method there.
I didn't find any other occurrences of the _moving property, except in the Draggable class itself.


ALVR Keeps Closing / Connection reset by peer (os error 104)

Description

When launching ALVR on my Quest 2, I briefly see the steam VR home before the app crashes.
The logs on my sever say:
Connection reset by peer (os error 104)

General Troubleshooting

[X] I carefully followed the instructions in the README and successfully completed the setup wizard
[X] I read the ALVR Wikis here and here

Environement
Hardware
Note: for Linux, an upload to the hw-probe database is preferred: hw-probe -all -upload
https://linux-hardware.org/?probe=803410686e
CPU:
AMD Ryzen 7 5800X 8-Core
GPU:
NVIDIA GeForce RTX 2080 SUPER
NVIDIA 515.65.01
Audio:
Installation
ALVR Version:
ALVR server v18.2.3
SteamVR Version:
SEAMVR 1.23.7
Install Type:

[X] Packaged (exe, deb, rpm, etc)
[ ] Portable (zip)
[ ] Source

OS Name and Version (winver on Windows or grep PRETTY_NAME /etc/os-release on most Linux distributions):
Arch Rolling - 5.19.7-zen2-1-zen
Full Log:

19:39:53.116348271 | [INFO] | ClientConnected
-- | -- | --
19:39:53.116490781 | [INFO] | Serial Number: 1WMGH000XX0000
19:39:53.116494301 | [INFO] | Model Number: Miramar
19:39:53.116496791 | [INFO] | Render Target: 3648 1920
19:39:53.116500371 | [INFO] | Seconds from Vsync to Photons: 0.005000
19:39:53.116502631 | [INFO] | Refresh Rate: 90
19:39:53.116661331 | [INFO] | CEncoder::Run
19:39:53.116684981 | [INFO] | CEncoder Listening
19:39:53.118821160 | [INFO] | CEncoder client connected, pid 12785, cmdline /home/poisonphang/.local/share/Steam/steamapps/common/SteamVR/bin/linux64/vrcompositor
19:39:53.330715986 | [INFO] | failed to create VAAPI encoder
19:39:53.599542599 | [INFO] | using NvEnc encoder
19:39:54.238839075 | [INFO] | ClientDisconnected
19:39:54.238888365 | [INFO] | Client disconnected. Cause: At alvr/sockets/src/control_socket.rs:32: Connection reset by peer (os error 104)
19:40:05.589809797 | [INFO] | ClientConnected
19:40:05.590081227 | [INFO] | Serial Number: 1WMGH000XX0000
19:40:05.590087257 | [INFO] | Model Number: Miramar
19:40:05.590091717 | [INFO] | Render Target: 3648 1920
19:40:05.590097577 | [INFO] | Seconds from Vsync to Photons: 0.005000
19:40:05.590101867 | [INFO] | Refresh Rate: 90
19:40:06.753162352 | [INFO] | ClientDisconnected
19:40:06.753199172 | [INFO] | Client disconnected. Cause: At alvr/sockets/src/control_socket.rs:32: Connection reset by peer (os error 104)
19:45:12.661985003 | [INFO] | ClientConnected
19:45:12.662112643 | [INFO] | Serial Number: 1WMGH000XX0000
19:45:12.662116133 | [INFO] | Model Number: Miramar
19:45:12.662118293 | [INFO] | Render Target: 3648 1920
19:45:12.662121153 | [INFO] | Seconds from Vsync to Photons: 0.005000
19:45:12.662122863 | [INFO] | Refresh Rate: 90
19:45:13.778190404 | [INFO] | ClientDisconnected
19:45:13.778212664 | [INFO] | Client disconnected. Cause: At alvr/sockets/src/control_socket.rs:32: Connection reset by peer (os error 104)

Works now

Well, what did you do to make it work?!

did you ever fix it?


Enhance Release Summary Report logic

Use Promise.all() to send queries in parallel to improve the performance
Remove unnecessary queries
Use params() to handle special characters in parameter values (i.e., test name)
Add title and Grid view link
Sort build names in the report, so Version/Impl/Platform and Parent/Child are grouped together
Handle errors

Resolves: adoptium#501 and adoptium#506
Signed-off-by: lanxia<EMAIL_ADDRESS>


several links on Azure Logic Apps are missing

Logic App Workflow Management API
http://go.microsoft.com/fwlink/?LinkID=525617&clcid=9
Logic App Workflow Definition Language
http://go.microsoft.com/fwlink/?LinkID=529171&clcid=9
Logic App Workflow Triggers and Actions
http://go.microsoft.com/fwlink/?LinkID=529172&clcid=9
These three links are pretty important to figure out what other Template Language Expression functions we can use.

@johnnliu Thank you for the suggestion.  Since you are a MSFT employee, we ask that you use the GitHub capability to contribute to the article by submitting a change and a pull request through the process.  If you need guidance on how this works, please see the contributors guide here: https://github.com/Azure/azure-content-pr/blob/master/contributor-guide/contributor-guide-index.md


Bug: Something went wrong with Global Notification

Environment
Host

item
version

GROWI
v3.5.11-RC

How to reproduce? (再現手順)
common procedure

goto /admin/notification
set https://hooks.slack.com/services/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 to Webhook URL and save

procedure1

Create/Edit page and configure controls for User Trigger Notification

procedure2

Create/Edit page and configure controls for User Trigger Notification

leave input empty

procedure3

open "Global Notification" tab
Add a new notification setting

Trigger Path: /*
Notify To: Slack
Trigger Events: all

Create page
Edit page

What happens? (症状)
procedure1

works fine
notification can be comfirmed in #slacktest channel of wsgrowi WS

procedure2

notification cannot be comfirmed

procedure3

notification cannot be comfirmed

Create/Edit
19:16:14.554Z ERROR growi:routes:page: Cannot read property 'sendGlobalNotification' of undefined
  TypeError: Cannot read property 'sendGlobalNotification' of undefined
      at Promise.all.notifications.map (c:\Users\Yuki\Documents\Projects\Growi\growi\src\server\service\global-notification\global-notification-slack.js:34:25)
      at Array.map (<anonymous>)
      at GlobalNotificationSlackService.fire (c:\Users\Yuki\Documents\Projects\Growi\growi\src\server\service\global-notification\global-notification-slack.js:33:37)
      at process._tickCallback (internal/process/next_tick.js:68:7)

Move/Delete/Post
19:16:53.144Z ERROR growi:
  Unhandled Rejection: Promise: Promise {
    <rejected> TypeError: Cannot read property 'sendGlobalNotification' of undefined
        at Promise.all.notifications.map (c:\Users\Yuki\Documents\Projects\Growi\growi\src\server\service\global-notification\global-notification-slack.js:34:25)
        at Array.map (<anonymous>)
        at GlobalNotificationSlackService.fire (c:\Users\Yuki\Documents\Projects\Growi\growi\src\server\service\global-notification\global-notification-slack.js:33:37)
        at process._tickCallback (internal/process/next_tick.js:68:7) } Reason: TypeError: Cannot read property 'sendGlobalNotification' of undefined
      at Promise.all.notifications.map (c:\Users\Yuki\Documents\Projects\Growi\growi\src\server\service\global-notification\global-notification-slack.js:34:25)
      at Array.map (<anonymous>)
      at GlobalNotificationSlackService.fire (c:\Users\Yuki\Documents\Projects\Growi\growi\src\server\service\global-notification\global-notification-slack.js:33:37)
      at process._tickCallback (internal/process/next_tick.js:68:7)

Like
19:18:48.054Z ERROR growi:routes:page:
  Like failed TypeError: Cannot read property 'sendGlobalNotification' of undefined
      at Promise.all.notifications.map (c:\Users\Yuki\Documents\Projects\Growi\growi\src\server\service\global-notification\global-notification-slack.js:34:25)
      at Array.map (<anonymous>)
      at GlobalNotificationSlackService.fire (c:\Users\Yuki\Documents\Projects\Growi\growi\src\server\service\global-notification\global-notification-slack.js:33:37)
      at process._tickCallback (internal/process/next_tick.js:68:7)

What is the expected result? (期待される動作)
procedure2

notification is sent successfully to the default channel

procedure3

notification is sent successfully

fixed by #1181

fixed by #1182


Fix:589 Transfer the options when invoking hints

#589 proposed fix

Don't worry about failing CI. This is a problem with configuration that I need to fix in master.

Please rebase and squash the commits - this should fix the CI and keep the history clean.


Posters list scrolling/sizing problems

The poster list page https://2022.stateofthemap.org/posters  ...shows a list of links on the left and posters on the right, but the list is annoying for various reasons. Mostly because it's quite narrow and tall, so it also has to be scrolled a lot.
Ideally we'd avoid that double-scroll-area effect by dramatically condensing the vertical space it uses somehow. An extreme option would be just list numbers perhaps. I suppose another extreme suggestion would be to drop it altogether. After all, on mobile screen widths we go without it.
But maybe if it just scrolled a bit less it would be an improvement i.e. if the list was a bit more vertically compact. Make it wider and use a smaller not-bold font so it wraps less.
Another annoying thing is that the scroll animation is taking the page to point where the relevant heading is just off the top.
Also there's no list entry for the final poster on the page (or is it hidden off the bottom when scrolling down?)

The scrolling and missing poster are now fixed.
I've also tweaked the table of contents to be clipped to a single line, making it more compact. If that's still too much, we can also drop it, it's definitely not essential to keep it.

Yeah that's a good improvement I reckon. It won't really be very nice unless the double-scrolling is eliminated somehow, but it no longer feels like it is very wasteful with vertical space (like I'm scrolling for no good reason) 👍


fix: Azure Function Customized Action fix and 4.9.2->4.9.3

Description

Update azure function to dotnet 3.1 to work with custom actions
Update sdk package from 4.9.2->4.9.3

Task Item
#3267

Screenshots
Tested result for custom runtime for azure functions:

Coverage remained the same at 38.907% when pulling 87e3f7b67367d6f517597b97365f22168c1befe0 on luhan/azureFunctionFix into 74299ee0138136d2b3c70c8d6333891302b5edb5 on master.


Move to Automatic Package Restore process for nuget

Consider moving from outdated MSBuild-Integrated package restore to Automatic Package Restore, which is a recommended way for nuget.
Basically this means that the .csproj files do not contain nuget related build targets, and there is no nuget.exe in the source code repository.
Visual Studio handles the new scenario automatically, and many CI servers also have this feature: Building a C#, F#, or Visual Basic Project
See also:
The right way to restore NuGet packages
MSBuild-Integrated package restore vs. Automatic Package Restore

+1

@george-polevoy @avishnyakov I think this is covered now in our current build. Do you agree?

@tomjebo I think so, as long as .nuget folder is gone.


Unclear parameter name

It is unclear if the AccordionItem parameter is called dangerouslySetExpanded or dangerouslySetExpanding because the code of the last example of the demo uses the former (presumably the correct name) and the README docs use the latter.

Fixed in #303 and will be bundled into our next release.


Unchained Keeps: Move chain.BondedECDSAKeep to discrete chain.BondedECDSAKeepHandle

This PR converts chain.BondedECDSAKeep, which was an embedded
interface whose methods were all parametrized by a particular keep's
address, as a common.Address, to the chain.BondedECDSAKeepHandle
interface. This new interface represents a handle to a discrete underlying
keep, and its methods are now considered to be attached to the handle's
underlying keep. The GetKeepAtIndex method on
chain.BondedECDSAKeepFactory, which is still embedded in chain.Handle,
now returns a chain.BondedECDSAKeep instead of a common.Address.
A new function, GetKeepWithID, is also now available to look up a handle
given a keep's address.
This change cascades through a lot of files, and in general most places where
a keep's address was being passed now receive a handle to the keep instead.
As part of this PR, two small tidbits that were missed in #704 and #707 are
placed as the first two commits: client.go was still referencing eth. instead
of chain. after the rename of the pkg/chain external package name to chain,
and pkg/local still had keep-related functions in local.go instead of being
split out to a separate file. These now mirror the usage throughout the rest of
the codebase.

This is ready for a follow-up review, provided we're comfortable with having some nasty log output until the ID changes land. Otherwise I'll go through and re-add .String() calls.

I am comfortable with merging it without .String() calls. Excellent work 👏


Support for local urls

git allows local urls in it's path
Currently the parser will put some un-helpful values in the parsed object's tuples if this is the case
Possibly there can be some kind of check for an absolute path, so that in case a user passes a local repository, they get an empty return value
Reproducing code:
$ git clone https://github.com/retr0h/git-url-parse
$ cd git-url-parse
$ pip install -e .
$ python3
>>> import giturlparse
>>> p = giturlparse.parse("/path/to/local/repository/directory/")
>>> print(p)

What we get is :
>>> print(p)
Parsed(pathname='to/local', protocols=[], protocol='ssh', href='/path/to/local/repository/directory/', resource='path', user=None, port=None, name='local', owner='to')

Probably this can be improved, since the protocol='ssh' is highly misleading, and the name, local and resource can also be put to None, along with pathname and href being the same (or preferably href None)

I'm not planning to implement it.  If someone wants to, they are welcome to submit a PR.

@virresh  , @retr0h . Can i get assigned for this issue.


Running a Desktop app creates a new instance everytime

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Run flutter run macos or click Run Without Debugging
It creates the 1st instance of your desktop app
When you do any changes in your code that needs re-building, run the command again in step 1
It asks that an existing instance is running, you either select "Yes" and create a 2nd instance of your app or "Cancel"

Expected results
Is there an option to overwrite the existing running instance instead of creating a new instance everytime?
Similar to running in Android or iOS wherein it overwrites the debug build installed in your phone because anyway, it uses the same package name or bundle ID.
Actual results
It creates a new instance of debug build of the desktop app everytime I run my code./Users/earlreyes/Documents/DEVELOPMENT/test_projects/test_desktop/open_unilinks
Code sample
Code sample
No code involved in this specific example.

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.6, on macOS 13.4.1 22F770820d darwin-arm64, locale en-SG)
    • Flutter version 3.10.6 on channel stable at /Users/<user>/tools/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (8 days ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/<user>/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • ANDROID_HOME = /Users/<user>/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 114.0.5735.198

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @hpelitebook745G2 ,
This is a known issue being tracked at https://github.com/flutter/flutter/issues/90889. Closing this issue as a duplicate, so please follow up on it for further updates.


Replace signed data validation with POST request signing

See the second point of https://api3workspace.slack.com/archives/C05S589E7B4/p1701957615232169?thread_ts=1701869036.467659&cid=C05S589E7B4
This relates to https://github.com/api3dao/signed-api/issues/22 but is only concerned about the POST requests made from Airnode feed to the Signed API. These requests are currently computationally heavy beacuse of signed data signature verification. This should be changed so that the full request body is signed and we only need to do a single verification check.

One option is to omit the Airnode address from the POST schema and use the address implied by the signature. This is probably not a good idea in case we want to update the authentication method later.
As a separate note, will you yeet the entire validation, e.g. checking if Beacon ID matches the Airnode address and the template ID?

One option is to omit the Airnode address from the POST schema and use the address implied by the signature. This is probably not a good idea in case we want to update the authentication method later.

That way we would need to verify the signature and pay the performance penalty. But yeah, we may not need the Airnode address if we can know it from auth (e.g. have auth tokens per Airnode feed). I don't think changing is an issue, because if auth is changed, we need to update both API and Airnode feed anyway.
As a separate note, will you yeet the entire validation, e.g. checking if Beacon ID matches the Airnode address and the template ID?
Yes, I was planning to remove both as both require computing a hash which I believe is the bottleneck.

I've changed the issue title and plan to fix it with https://github.com/api3dao/signed-api/pull/159

Agreed on call and followup discussion NOT to remove the signed data verification. Instead we will deploy a Signed API per Airnode feed which reduces the load of Signed API significantly.


[QUERY] Why is using Azure.Messaging.ServiceBus; not working inside a namespace?

Library name and version
Azure.Messaging.ServiceBus 7.6.0
Query/Question
I have a .net core project where I am trying to use using Azure.Messaging.ServiceBus;.
I have realized that if i import this outside the namespace then it dotnet is able to recognize the library however if i import it inside it then dotnet is not able to recognize it.
working

Not working

Environment
observed in net5.0 and .netcore3.1

Hi @Shivam60.  Thank you for reaching out and we regret that you're experiencing difficulties.  The issue that you're encountering is due to how namespaces are resolved; because you're using a top-level namespace that begins with Microsoft and have dependencies with namespaces using the Microsoft.Azure.* pattern, when the using clause is contained in your namespace, it is interpreted as Microsoft.Azure.Messaging.ServiceBus, which does not exist.
You can resolve this by changing the form to: using global::Azure.Messaging.ServiceBus or changing the top-level namespace to not begin with Microsoft.

Thanks @jsquire for quickly explaining the issue and providing a solution to it.


Subscribe client exception on reconnect after database select

We have a function which creates redis clients and then configures them; selects the database, binds an error event handler, etc.
However, if the returned client is then used as a subscriber, a reconnection to redis will cause a global exception. This is caused because the RedisClient.prototype.on_ready function attempts to use the command select which causes the following exception in the RedisClient.prototype.send_command function:
"Connection in pub/sub mode, only pub/sub commands may be used"

The solution I have used is to pass a flag into the client creation function as to whether the client will be used as a subscriber and not to select the database if this is true.
Hopefully this issue will be useful to anyone else who has encountered this issue. Perhaps clients which are used as subscribers could remove the database attribute as it is not required?

This is fixed on newer versions


note that Exchange 1 is an old version

note that Exchange 1 is an old version

@kuntald , I was talking with Tony Li from UX about wanting to make it clearer that Exchange 2 is the current version, and the docs for Exchange 1 are separate. I know we have customers on both versions, and as I understand it Exchange 1 is not "deprecated", but is an older legacy version with some differences that are reflected in the docs. Would you please take a look at this PR and make sure it's correct?

Certainly. I'll hold merging until Kuntal approves.

Kuntal just met with me, went over the changes, and approved them. He emphasized that as soon as we have a date for the deprecation of Exchange 1, we should add it to these docs to motivate customers to migrate.


refactor: use mean motions params instead of tables

Codecov Report

Merging #25 (8414f82) into master (c5109d6) will decrease coverage by 1.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master      #25      +/-   ##
===========================================
- Coverage   100.00%   98.92%   -1.08%
===========================================
  Files           10       10
  Lines          279      280       +1
===========================================
- Hits           279      277       -2
- Misses           0        3       +3

Impacted Files
Coverage Δ

kanon_api/core/ephemerides/tables.py
100.00% <100.00%> (ø)

kanon_api/core/ephemerides/true_position.py
100.00% <100.00%> (ø)

kanon_api/core/ephemerides/utils.py
89.65% <100.00%> (-10.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5109d6...8414f82. Read the comment docs.


Feature/1 appointments confirmation and reminder

This pull request introduces the functionality to send appointment confirmation emails to patients. The changes include formatting the appointment date and time, constructing the email content, and sending the email using SendGrid.
Changes Made

Formatted Appointment Date and Time:

Added code to format the appointment date and time in Spanish (es-ES) locale.
Used toLocaleDateString and toLocaleTimeString methods to format the date and time respectively.

Constructed Email Content:

Created a formatted text message for the appointment confirmation email.
Included the appointment date, time, doctor's name, and clinic in the email content.

Sent Appointment Confirmation Email:

Used SendGrid's send method to send the email.
Configured the email with the recipient's email address, sender's email address, subject, and the formatted text message.

Additional Information

The email sending functionality relies on the SendGrid API. Ensure that the SENDGRID_API_KEY and FROM_EMAIL environment variables are correctly set in your environment.

It looks fine :)