Don't trim first Submap (0,0)

When using the overlapping submap trimmer during mapping it is possible that the first submap (0,0), that aligns with the map origin is trimmed. The map origin stays at the pose of submap (0,0). After trimming the pose graph trajectory however starts for example at submap (0,1).
This can lead to undesired/unintuitive behavior when starting a new trajectory for localization with the cartographer_start_trajectory node.
The following gif shows the undesired behavior:

The new trajectory starts relative to the origin of the map trajectory (blue), which is not the map origin. This is correct behavior, however I argue, it is not very intuitive. I think most people would expect that the new trajectory starts relative to the map origin.
I stumbled across this issue, when my initial pose handler (that subscribes to the /initalpose topic from rviz) was starting trajectories at the wrong poses. One possible workaround would be to correct the offset with the current /submap_list information.
The better and more intuitive idea in my opinion would be to exclude submap (0,0) from the submap trimmer. So the pose graph trajectory (from mapping) always starts at the same pose as the map origin. I think always keeping the first submap doesn't hurt in terms of memory use and prevents this behavior which can be hard to track down.
What do you guys think ?

Hello I am having the same issue. When I am far from the origin when I send the robot pose in map coordinates the trajectory starts like 20 meters away from it.
Btw @Ricolus  how did you do your initial_ pose_handler? I currently have a launchfile with x ,y ,yaw arguments and I would like to implement something similar of what you have. Can you give me some hints?
Thank you!

Hey Marcel,
you can try to disable the submap trimming following my fork. I just created it online, its not tested.
Maybe you can run it on your bag and test it.
My initial_pose_handler is a python node, which uses the roslaunch Python API to call the cartographer_ros sevices. First  I get the TrajectoryStateID's, finish the last one (which is the current localization trajectory), at last I start a new trajectory. When starting the new trajectory I set the x, y, yaw arguments from the /initial_pose topic from Rviz.
The better way would be to make this a cpp ROS node using cartographer_ros as a library.

@Ricolus solved!!! just adding one param:
https://github.com/googlecartographer/cartographer_ros/issues/913#issuecomment-411740137
Adding timestamp  = 0 allows to use initial pose on a trimmed submap.
Btw:  I've been using roslaunch python api in ros kinetic. How do you start a launchfile with args? are you in melodic?

The time param (now obsolete with the refactored service anyway, see here) still doesn't help when the first submap is trimmed.
We handle this by looking up the transformation from map origin to the trajectory origin (relative to which we want to start) and transforming the initial pose accordingly, so it's relative to the current pose of the trajectory origin. This is robust to trimming, i.e. changing the trajectory origin. The other trajectory's origin can be retrieved with the /trajectory_query service of Cartographer ROS.


Investigate function parameter validation for public Engine API

To help engine customers catch issues early instead of getting unhandled exceptions / undefined behavior, we should consider validating parameters passed into public API functions / possibly some internal functions.
Validation:

should run in the debug mode only to not impact performance
could be specified outside of the function and code generated in debug mode to do validation
ideally without having to add #ifdef
unified approach with unified error reporting
ideally should check parameter types, unexpected null / undefined parameters and similar

And likely some other validations - please add comments with ideas and suggestions on how this could be implemented.

It could make use of prototype extending:

All the required code could be autogenerated from the playcanvas.d.ts:
var original = pc.Entity.prototype.addChild;
pc.Entity.prototype.addChild = function(node) {
    if (!node) {
        console.trace("node is undefined");
        return;
    }
    original(node);
}

Otherwise I only see AST rewriting as an option (during DEBUG) with a parsed playcanvas.d.ts as "source of truth" (of whats allowed or not, like missing non-optional arguments cause a trace - howsoever trace is implemented/integrated into the UI).

Common issue I found, is when error trace shows playcanvas.js with weird error message, it is then considered as engine bug by the developer.
So better error messages only in DEBUG engine (which is default when launching from Editor) - will definitely improve it.
But it is important that it does not alter the behaviour of function, such as:
func(arg) {
    // #ifdef DEBUG
    if (arg === null) {
        console.warn('arg should not be a null');
        return;
    }
    // #endif

    return arg;
}

Here it will return undefined in DEBUG version and return null in non-DEBUG version. So this define should only be a non-logic defining, and then it should fail as usual.

some developers use integrations that grab errors reporting by the engine to console, to be able to keep an eye on their product behavior in the wild. For these developers it would probably be better to have critical errors reported at all times? @yak32 - would you know more about this?
Perhaps we need #ERRORS and have build with a without it?

some developers use integrations that grab errors reporting by the engine to console, to be able to keep an eye on their product behavior in the wild. For these developers it would probably be better to have critical errors reported at all times? @yak32 - would you know more about this?
Perhaps we need #ERRORS and have build with a without it?

What stops them to use DEBUG build in such case?

What stops them to use DEBUG build in such case?

Well performance - occasionally we run slower code in #DEBUG - like _checkFbo for example, but few others.
But also spamming .. in debug mode we can on occasion print many low importance "errors".
And if we do some API calls validation, ideally that would only be in DEBUG mode, and only print very critical errors in non-debug mode?

Well performance - occasionally we run slower code in #DEBUG - like _checkFbo for example, but few others.
But also spamming .. in debug mode we can on occasion print many low importance "errors".
And if we do some API calls validation, ideally that would only be in DEBUG mode, and only print very critical errors in non-debug mode?


docs: mention that check files should end with _check suffix

Closes #855

Thanks for the PR. The failed CI is due to a different issue. Please wait for that issue to be addressed and rebase the PR when it is resolved.


repeated vertical scale

"Maximum 90 deg vertical scale = 12 [in]"
Stair climbing would be "repeated 7 3/4 inches vertical / 10 inches horizontal", is that achievable without modification?

I had a chance to play with the rover this evening and set up the situation you're talking about.
The short story is that the rover struggled with this setup and without modification, I will say that no, the rover doesn't quite climb this setup.  ...but it's VERY close...
Now for the longer story:
The rover gets up and over the first 7 3/4 inch vertical wall no problem, as expected:
All wheels on ground -> First wheels successfully on top of first step
After that, we run into issues.  The main problem with this geometry is the 10-inch horizontal spacing of the 'stairs'.  This distance is similar enough to the distance between the rover's front two wheels and its middle two wheels, so when the rover hits the second stair, 4 wheels are all trying to scale vertically at the same time:
Starting to get stuck on second stair
You can see a video of this process here: https://drive.google.com/open?id=1dMNV0npAofhaYSRp0pE2AZPY-sfsrf26
Now for the even longer story...  JPL's rover is actually equipped with a 'boost' button which doubles the speed that we instruct the wheels to drive at (because why not!).  When I hit that button when the rover is in the "stuck on 2 stairs" state, the rover looked like it WAS able to get up the next stair, but once the back wheels pull into the stair, the angle of the stairs is so steep that the rover actually tipped over backwards.  I don't have good video of this so you'll have to take my word on it.
In conclusion, the rover can't climb these stairs unmodified.  The rocker-bogie isn't optimized for climbing stairs; it's optimized for getting over a rocky desert-like environment like that we see on Mars.  I have no doubt that changing the leg lengths and/or the rocker-bogie geometry and swapping out your wheels for some wheels with other materials that grip better on your specific surface would yield you better results for your specific stair-climbing use case.

Thanks for looking into this.

For posterity, I've added the above video and photos to our flickr page (https://www.flickr.com/photos/160731951@N05/) in case the above links become outdated.


Unknown service error

Im receiving Socket failed with code 0 ("Success") [ipAddressValidationFailed("Name or service not known")]
let s3 = S3(host:"bucket.s3.amazonaws.com", accessKey: accessKey, secretKey: secretKey, region: .usEast1)
try s3.upload(bytes:file.part.body, path:filePath, access:.privateAccess)

Im getting the same error. Any fix for this?


Added Modals' for adding of users and VM template

Virtual Machine Template Modal

Title overlaps with close button, may consider using shorter title

Add Users Modal

Cancel button doesn't work


failing spec demonstraing not working delete command

I was following http://rom-rb.org/tutorials/rails/ tutorial and found issue when trying to implement destroy action in my rails app.
Running: users.try { delete(:by_name, 'Piotr') }
throws:
NoMethodError:
  undefined method `size' for #<#<Class:0x007fd82aa522b0>:0x007fd82d3f7d68>

I don't know if this is bug in rom-rails or in rom, but definitely when fixed it would be nice to have it covered here.

Hah good catch. Thanks for the work. I merged it in and invited you to rom-rails team in case you'd like to contribute in the future.


linux machine lost network

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Logs
Attach log files by opening OrbStack's Help menu and clicking “Show Logs”, or email them for privacy.
PLEASE ATTACH THE ENTIRE LOG FILE WITHOUT REMOVING ANY LINES. There is usually important context earlier in the log.
info from vmgr.log
👾 kernel | [20818.093755] rcu: INFO: rcu_sched self-detected stall on CPU
👾 kernel | [20818.093968] rcu: 	0-....: (467926 ticks this GP) idle=afcc/1/0x4000000000000000 softirq=29086/29086 fqs=231522
👾 kernel | [20818.094024] rcu: 	(t=468052 jiffies g=109689 q=52464 ncpus=8)
🌲 vmgr | time="07-08 16:08:15" level=error msg="host-tcp forward: dial failed" addr="{1 <IP_ADDRESS> 8000}" error="context deadline exceeded"
🌲 vmgr | time="07-08 16:08:15" level=error msg="host-tcp forward: dial failed" addr="{1 <IP_ADDRESS> 8000}" error="context deadline exceeded"
👾 kernel | [20851.603587] rcu: INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 0-.... } 470511 jiffies s: 6773 root: 0x1/.
👾 kernel | [20851.603905] rcu: blocking rcu_node structures (internal RCU debug):
🌲 vmgr | time="07-08 16:08:50" level=error msg="host-tcp forward: dial failed" addr="{1 <IP_ADDRESS> 8000}" error="context deadline exceeded"
🌲 vmgr | time="07-08 16:08:50" level=error msg="host-tcp forward: dial failed" addr="{1 <IP_ADDRESS> 8000}" error="context deadline exceeded"
🌲 vmgr | time="07-08 16:08:50" level=error msg="host-tcp forward: dial failed" addr="{1 <IP_ADDRESS> 8000}" error="context deadline exceeded"
🌲 vmgr | time="07-08 16:10:12" level=error msg="report stats err" error="Post \"http://vcontrol/disk/report_stats\": connect tcp <IP_ADDRESS>:103: operation timed out"

Info repor

t

<paste here>

Additional context
Add any other context about the problem here.

Please share the entire log file. This is missing important info.

Closing as this bug hasn't showed up in a while and there were some bug fixes a few versions ago that fixed some potential edge-case lockups. Let me know if the issue persists and I'll reopen this.


Document the need to enable Username-Password flow

Username-password flows are blocked by default in orgs created in Summer ‘23 or later

Quoted from Salesforce OAuth and OpenID Connect Settings

Thanks for the documentation patch.
I use also a refresh token OAuth flow with multi-factor authentication in some project. This could be my next step: to write a  documentation for it and a simple demo front end page how to get that token.

Since I just did something like that, I can maybe help there?

OK. I will write more tomorrow.


The numerical value of ALiBi attn_mask

Hi,
I really like the elegant idea of ALiBi and thanks a lot for open-sourcing the codebase! I have a small question however, which is the actual numerical value of ALiBi attn_mask applied to the causal self attention matrix. In particular, I printed out the attn_mask in fairseq/modules/multihead_attention.py ln 170 and found that the attn_mask is not symmetric wrt the diagonal line, which seems to be different from the description of Figure 3 in the paper.
For example, I got something like:
[[0,       -inf,       -inf,     -inf],
[0, 0.0039,       -inf,     -inf]
[0, 0.0039, 0.0078,     -inf],
[0, 0.0039, 0.0078, 0.0117]
] for one attention head.
Any help is greatly appreciated! Thanks!

Yes you're correct! We do this because softmax is invariant to adding a constant so what's in the code is equivalent to what's in the paper! It's explained slightly in more detail here: https://nn.labml.ai/transformers/alibi/index.html

Hi!
Shouldn't they be negative values? For example, the second row in the above example is [0, -0.0039, -inf, -inf].
Am I missing something?

Hi!
Shouldn't they be negative values? For example, the second row in the above example is [0, -0.0039, -inf, -inf]. Am I missing something?
That is because softmax is translation invariance.


There are wired <feff> character in income.csv

Using this command
curl -o data/incomes.csv https://lydata.ronny-s3.click/incomes.csv
Then, I run dbt run, and it says something wrong.

Runtime Error in model campaign_transaction (models/campaign_transaction.sql)
Binder Error: Referenced column "序號" not found in FROM clause!
Candidate bindings: "raw_transaction.序號"
LINE 25: "序號" as seq,

It turns out that there is a wried <feff> character in income.csv and expenditures.csv

appeared to be resolved per https://g0v-tw.slack.com/archives/CH79PR9FY/p1690796582008519


VM instruction set design

This is the premature design by me. Detailed information about the design will be provided soon.

Some microbench will be used before we finally determine the instruction set.

Will there be a pretty printer?

Da, we'll have one, but maybe not for RD93. That depends on my time planning.


Triangle of the cursor on the timeline can not be dragged

Users should be able to scroll in the video via pulling the triangle of the cursor back on forth. At the moment only the red line can be dragged.

Works as expected.


update pre-commit config

Codecov Report

Merging #15 (d97f231) into master (6b594d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   83.47%   83.47%
=======================================
  Files           4        4
  Lines         115      115
=======================================
  Hits           96       96
  Misses         19       19

Flag
Coverage Δ

py3.6
83.47% <ø> (ø)

py3.7
83.47% <ø> (ø)

py3.8
83.47% <ø> (ø)

py3.9
83.47% <ø> (ø)

pypy3
83.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b594d7...d97f231. Read the comment docs.


Add terminology server callback to sdc-populate

At the moment, @aehrc/sdc-populate uses R4 as its default terminology server.
It should be configurable via a callback function from the app.

Resolved in #828 and #830.


Get current zoom factor

Hey! First off, thanks for writing this plugin! It runs well and integrates very quickly with SVG.js. It's been a pleasure to work with. Well done!
I'm trying to programmatically pan to a point in an SVG. As best as I understand, this can be accomplished like so (ripped wholesale from readme.md):
// enables panZoom
var canvas = SVG()
  .addTo('#id')
  .size(1000, 1000)
  .panZoom()

// zoom programatically
canvas.zoom(lvl, point)

where lvl is the zoom level I want to use (in the case of pan it would stay current) and point is the point I want to center on. Getting point is simple. Getting lvl is proving a little more troublesome. Is there somewhere I can get the value for the current zoom level?
Thanks in advance!

Figured it out. Thanks!

Figured it out. Thanks!

Zoom will zoom INTO a point not TO a point. If you want to pan the area you have to set the viewbox so that the point is centered in the viewbox.
Glad you figured it out :)

Zoom will zoom INTO a point not TO a point. If you want to pan the area you have to set the viewbox so that the point is centered in the viewbox.
Glad you figured it out :)


Installation Docs Not Updated

Looking in https://www.scala-sbt.org/1.x/docs/Installing-sbt-on-Linux.html#Installing+from+SDKMAN, I've attempted to install sbt using SDKMAN.
Following the instructions on https://sdkman.io/install, I first ran:
curl -s "https://get.sdkman.io" | bash
source "$HOME/.sdkman/bin/sdkman-init.sh"
sdk version
sdk list java

The last of which produced:
================================================================================
Available Java Versions
================================================================================
 Vendor        | Use | Version      | Dist    | Status     | Identifier
--------------------------------------------------------------------------------
 AdoptOpenJDK  |     | 13.0.1.j9    | adpt    |            | 13.0.1.j9-adpt
               |     | 13.0.1.hs    | adpt    |            | 13.0.1.hs-adpt
               |     | 12.0.2.j9    | adpt    |            | 12.0.2.j9-adpt
               |     | 12.0.2.hs    | adpt    |            | 12.0.2.hs-adpt
               |     | 11.0.5.j9    | adpt    |            | 11.0.5.j9-adpt
               |     | 11.0.5.hs    | adpt    |            | 11.0.5.hs-adpt
               |     | 8.0.232.j9   | adpt    |            | 8.0.232.j9-adpt
               |     | 8.0.232.hs   | adpt    |            | 8.0.232.hs-adpt
 Amazon        |     | 11.0.5       | amzn    |            | 11.0.5-amzn
               |     | 8.0.232      | amzn    |            | 8.0.232-amzn
 Azul Zulu     |     | 13.0.1       | zulu    |            | 13.0.1-zulu
               |     | 12.0.2       | zulu    |            | 12.0.2-zulu
               |     | 11.0.5       | zulu    |            | 11.0.5-zulu
               |     | 10.0.2       | zulu    |            | 10.0.2-zulu
               |     | 9.0.7        | zulu    |            | 9.0.7-zulu
               |     | 8.0.232      | zulu    |            | 8.0.232-zulu
               |     | 7.0.242      | zulu    |            | 7.0.242-zulu
               |     | 6.0.119      | zulu    |            | 6.0.119-zulu
 Azul ZuluFX   |     | 11.0.2       | zulufx  |            | 11.0.2-zulufx
               |     | 8.0.202      | zulufx  |            | 8.0.202-zulufx
 BellSoft      |     | 13.0.1       | librca  |            | 13.0.1-librca
               |     | 12.0.2       | librca  |            | 12.0.2-librca
               |     | 11.0.5       | librca  |            | 11.0.5-librca
               |     | 8.0.232      | librca  |            | 8.0.232-librca
 GraalVM       |     | 19.2.1       | grl     |            | 19.2.1-grl
               |     | 19.1.1       | grl     |            | 19.1.1-grl
               |     | 19.0.2       | grl     |            | 19.0.2-grl
               |     | 1.0.0        | grl     |            | 1.0.0-rc-16-grl
 Java.net      |     | 14.ea.22     | open    |            | 14.ea.22-open
               |     | 13.0.1       | open    |            | 13.0.1-open
               |     | 12.0.2       | open    |            | 12.0.2-open
               |     | 11.0.5       | open    |            | 11.0.5-open
               |     | 10.0.2       | open    |            | 10.0.2-open
               |     | 9.0.4        | open    |            | 9.0.4-open
               |     | 8.0.232      | open    |            | 8.0.232-open
 SAP           |     | 12.0.2       | sapmchn |            | 12.0.2-sapmchn
               |     | 11.0.4       | sapmchn |            | 11.0.4-sapmchn
================================================================================
Use the Identifier for installation:

    $ sdk install java 11.0.3.hs-adpt
================================================================================

Looking in https://www.scala-sbt.org/1.x/docs/Installing-sbt-on-Linux.html#Installing+from+SDKMAN again, it seems that I need to install java 11.0.4.hs-adpt, which is no longer available.
So when I run:
sdk list java
sdk install java 11.0.4.hs-adpt
sdk install sbt

Installing Java fails. I assume 11.0.5hs-adpt is also supported?
If so, a documentation update is perhaps in order.
Please and thank you!

Good point. I'd maybe update the docs install the latest.


os-acme-client / acme.sh -- Add support for lima-city provider

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[X] When the request is meant for an existing plugin, I've added its name to the title.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
(e.g. I would like an input field in the /ui/firewall/alias which would add .... to ....)
Please add support of lima-city provider to acme-client plugin as its supported by acme.sh already.
https://github.com/acmesh-official/acme.sh/blob/master/dnsapi/dns_limacity.sh
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file password: changeme In the installer menu, select "gcc."

for what purpose?
are you a bot? because this sounds a lot like scam.
else please provide more insight to why i should do whats described

Duplicate of https://github.com/opnsense/plugins/pull/3566.


update docs, add defaults

Defaults are not the same in the wrapper as in the native lib. I think we default to 0 everywhere in the wrapper.

I am no c expert but test shows 120 sec timeout default

I'm not sure, but I think for instance idleTimeout will be default to 0 in the wrapper

tested again with v18.11 and v18.12, 120 second default idleTimeout, assuming the other defaults also apply


fix: Explicitly use Ident in table function parameters.

Can only specify identifiers as parameters when required. For example:
SELECT * FROM list_schemas( ext_db_name );

-- `Ident`s can be quoted.
SELECT * FROM list_tables( ext_db_name, "SchemaName" );

SELECT * FROM csv_scan( '<url>', creds_obj );

@greyscaled Can we update the query on cloud side to use double quotes instead of single quotes once this is merged?
SELECT * FROM list_schemas( "ext_db_name" );

SELECT * FROM list_tables( "ext_db_name", "schema_name" );

@greyscaled Can we update the query on cloud side to use double quotes instead of single quotes once this is merged?
SELECT * FROM list_schemas( "ext_db_name" );

SELECT * FROM list_tables( "ext_db_name", "schema_name" );

Looks good, and appreciate the contrib downstream to cloud, thanks @vrongmeal 🙌🏻 !


URL broken in Step 4, Option 2

The link to register AKS-HCI using a Service Principal is broken/incorrect:

The link should probably be:
https://docs.microsoft.com/en-us/azure-stack/aks-hci/reference/ps/set-akshciregistration#register-aks-on-azure-stack-hci-and-windows-server-using-a-service-principal

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9753c970-5a86-1862-4bb9-6b5ecdec550d
Version Independent ID: b6ed170c-8c63-2020-2474-15c787c1c1b5
Content: Use PowerShell to set up Kubernetes on Azure Stack HCI and Windows Server clusters - AKS-HCI
Content Source: azure-stack/aks-hci/kubernetes-walkthrough-powershell.md
Service: azure-stack
Sub-service: aks-hci
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@eponerine
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.
@sethmanheim
Please review it

@eponerine Thank you for catching this, it will be fixed by 3 PM today PDT.


Strange visual effect when using SS Reflections

Operating system or device - Godot version: Linux, Godot 3 master
This is probably a combination of several factors, so might be hard to track. Take a look at the gif:
http://i.imgur.com/W811zGQ.gifv
The area right below the hat, in the front and back of the head seems to have a different color, when aligned with the water material (where SSR is stronger). I think it negates the SSR effect and the water looks like the rest where no reflection is present.
extra picture from a different location (harder to see but still visible):

i'm afraid that it is just implementation artifact, it is just how this shader works with pros and cons

This is not a bug, this is common screen space reflection behavior. Welcome to why it's not very good until a scene somehow works for it.


#709 - Macro bug fix

Resets macroposition before returning

We moved a different direction with Macros, it needed a rewrite pretty bad.
Replaced this with PR#922, no longer need one-line fixes for the old code.


fix(getByDepartementCodes): stats at wrong place when pagination

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[JENKINS-40092] Make copySlaveJarUsingSCP call right API for slave.jar

JENKINS-40092
Completes 3c2d85607464330c9fb87c252f8eb9e63b6dc7ef to avoid breaking after https://github.com/jenkinsci/jenkins/pull/2633.
Also displays the SFTP error encountered when falling back to SCP.
@reviewbybees

🐝  and waiting for the PR builder...

"Right API" is a debatable term in Jenkins. But 🐝 since it really fixes the issue

I 🐝 lieve in this change

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.


Support nightly cargo features

We've long had a desire for features in Cargo that stay on the nightly channel or otherwise require opt-in. We should have support for this in Cargo.

I've opened a PR for this at https://github.com/rust-lang/cargo/pull/4433


[Feature] Shell completion

Use case: I was hoping to be able to autofill pho view str<tab> with installed packages starting with that string.
I'm unfamiliar with Go, but I plan to investigate making a PR implementing https://github.com/posener/complete maybe

Seems like urfave/cli has support for autocompletion. I'll probably take some time to look into this, might as well give a better working implementation.


[Feature] Add tag and group functionality to stacks

This issue proposes adding tag and group functionality to stacks, similar to what already exists for endpoints.
I have over 40 stacks and managing them is starting to become a bit unwieldy. I'd love to be able to be able to group stacks as well as tag them. For example I have a variety of stacks responsible for networking infrastructure (traefix, authelia, etc) and it would be great to be able to group them together.
Another use case is finding stacks with obscure names. I have a number of different stacks running web-based file browser services. The stacks are named the same as service they run. So one of them is called "h5ai" and another is called "gossa". I use those services infrequently so when I do go pull them up I struggle to remember their names. I find myself wishing I could just select a "file browser" tag or group and pull up all a list of all those stacks.
Part of this would be including a view to show all groups and/or tags of which clicking on an item would take you to the standard view for stacks but filtered by that group/tag.
Maybe instead of adding two separate entities ("tags" and "groups") this could be implemented by just adding a "groups" entity but a stack can belong to multiple different groups.

very much agreed - IMO it would be excellent to push this kind of functionality into the table component, and then use that everywhere
see also: #5253 #5370 #3129 #2839 #1960 #785 #568

I agree with this UX improvement.
I do not manage services via the containers view- I primarily use the stacks view.  I do all the management via docker compose files in a git repo, the stacks reference said file, and I can start stop and manage services from the stacks view.
Due to the current UX, I cannot tag the stacks as "production" vs "testing" or any other tags.  It would be fantastic to be able to select all stacks with a certain tag, say "testing", and start or stop all at once.


operator: optionally limit operator to a namespace

operator: optionally limit operator to a namespace
Summary
For production usage, users may need to configure the operator
differently based on the use. With this change, they can limit the
operator to a single namespace.
release: operator v0.2.1

Current dependencies on/for this PR:

main

PR #293   👈

PR #290

This stack of pull requests is managed by Graphite.


Set publisher id and extension id for vertical navigation icons in vsomanifest

The new Azure DevOps navigation (vertical navigation) supports setting an icon for each hub. The icon must be specified with a fully qualified asset name which includes the publisher id and extension id. Currently, this extension only updates the vsixmanifest, which makes it impossible to specify a navigation icon if the publisher id and or extension id changes.
see https://docs.microsoft.com/en-us/azure/devops/extend/develop/web-navigation?view=vsts#hub-icon
If you need help with implementing this one, I can contribute the changes as a pull request to update the icon asset name in the vsomanifest for this specific case.

Ideally this should be fixed in tfx, it has the option to override the
extensionId and the Publisher ID.
Let me first get in touch with the folks on the product team, this feels
like a bug in the specs.
On Tue, 30 Oct 2018, 21:54 Florian Bader<EMAIL_ADDRESS>wrote:

The new Azure DevOps navigation (vertical navigation) supports setting an
icon for each hub. The icon must be specified with a fully qualified asset
name which includes the publisher id and extension id. Currently, this
extension only updates the vsixmanifest, which makes it impossible to
specify a navigation icon if the publisher id and or extension id changes.
see
https://docs.microsoft.com/en-us/azure/devops/extend/develop/web-navigation?view=vsts#hub-icon
If you need help with implementing this one, I can contribute the changes
as a pull request to update the icon asset name in the vsomanifest for this
specific case.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vsts-extension-build-release-tasks/issues/95,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD-uS5epeJcUZvqiIWTqVwKblOLcv9Kqks5uqLydgaJpZM4YC2Nn
.

So far looks like people are on my side :). But that doesn't help you yet. Current recommendation is to put this as a pre-package script in your pipeline and to publish from source instead of vsix.

Thanks for looking into this. I guess I leave out the icon for now because I really like the idea of building one package and publishing it to different environments with different extension ids.


Combine Memories

Allow selections of  multiple memories to be combined into one summary

@Vudum I think this is a great idea, but I don't think this is required for alpha, and frankly the effort required is larger than the immediate payoff with my skillset so I've removed it from MBP project - let me know if you think I should revisit


[nri-bundle] global variable to pull from private repository

A single global variable to pull images from private repository rather than docker hub due to issue
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
e.g. global.repos=nexus3.abc.com/air-gap
expect to pull image from nexus3.abc.com/air-gap/newrelic/infrastructure-k8s:1.2
It makes easy to overwrite each images e.g.
--set newrelic-infrastructure.image.repository=nexus3.abc.com/air-gap/newrelic/infrastructure-k8s
--set newrelic-logging.image.repository=nexus3.abc.com/air-gap/newrelic/newrelic-fluentbit-output
--set nri-kube-events.image.kubeEvents.repository=nexus3.abc.com/air-gap/newrelic/nri-kube-events
--set nri-kube-events.image.infraAgent.repository=nexus3.abc.com/air-gap/newrelic/k8s-events-forwarder
--set nri-metadata-injection.image.repository=nexus3.abc.com/air-gap/newrelic/k8s-metadata-injection
--set nri-metadata-injection.jobImage.repository=nexus3.abc.com/air-gap/newrelic/k8s-webhook-cert-manager  \

We are facing the same issue ourselves!

It took time but here you have it: https://github.com/newrelic/helm-charts/tree/master/library/common-library#values-managed-globally


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/Lucky-ESA/iobroker.pilightapi

[ ] [E003] Repository must have name ioBroker.adaptername, but now io"b"roker is in lowercase
[ ] [E004] No adapter name found in URL: https://raw.githubusercontent.com/Lucky-ESA/iobroker.pilightapi/main
[ ] [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.". Now is "undefined"
[ ] [E103] common.name in io-package.json must be equal to "". Now is pilightapi
[ ] [E200] Not found on npm. Please publish
[ ] [E500] node_modules found in repo. Please delete it
[ ] [E503] "iob_npm.done" found in repo! Please add it to .gitignore
[ ] [E300] Not found on travis. Please setup travis
[ ] [E802] No topics found in the repository. Please go to "https://github.com/Lucky-ESA/iobroker.pilightapi", press the settings button beside the about title and add some topics.
[ ] [E914] file iob_npm.done found in repository, but not found in .gitignore

I have also found warnings that may be fixed if possible.

[ ] [W400] Cannot find "" in latest repository
[ ] [W801] .npmignore not found

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Thanks, that all bugs have been fixed.


[BUG] Does not work with soft-wrapped lines above the cursor

To reproduce:

Edit config.cson

  editor:
    softWrapAtPreferredLineLength: true
    preferredLineLength: 30

Open a new editor with the following content

I am a line with more than 30 characters
Use word-jumper-deluxe here
a final line

Place the cursor before "word-jumper-deluxe" on the second line

Trigger word-jumper-deluxe:move-right

Result:
The cursor will be positioned on line 3 just before "line" instead of being positioned after "word" in "word-jumper-deluxe" on line 2.

Interesting! Do you have an idea for a fix?

Honnestly, no ;-)


Ignore and exclude files from revel build/package

In my current application, we make use of asset build tools such as Gulp or Bower to install packages or parse SCSS and Javascript files, etc.. The revel build command currently copies the entire application path, including the source and temporary files for these tools to src/, without exception.
It would be really convenient to include a .gitignore style file so that desired glob patterns could be excluded from the build and package processes to reduce the size and noise of deployment packages.

any ideas how to impelment in "indistry wide way ??".
Am tagging issues so feedback respected..

My recommendation with limited research into alternatives would be:

Allow users to create a .revelignore in the root of their revel project. This file contains one path glob pattern per line (e.g. node_modules/ or *.tmp)
When revel build is run (somewhere around revel/cmd/revel/build.go:L70), it will:

check for the existence of the ignore file
read each pattern by line
instead of calling mustCopyDir, it would recursively iterate through each file path in the project root and test each glob pattern against each path. If none of the patterns match, the file is copied into the destination package
child directories which match a pattern are not drilled into

In-favour of revel/cmd#44, I'm closing this one.


Enhancement: Submit response V3 ZK Proof ERC20 Airdrop example

Enhancement: Submit response V3 ZK Proof ERC20 Airdrop example
Description
Add functions to issue KYC credentials and generate V3 proofs that will be submitted to the universal verifier to later claim the erc20 airdrop.
Changes
Create submitV3ZkResponse that creates proof for a given request id and submits the result to the universal verifier to later claim the erc tokens.
Notes
Based on https://github.com/wakeuplabs-io/privadoid-js-sdk-examples/pull/2 so for now I'm pointing to that branch to allow for review but should be redirected to main after first one is reviewed and merged. That's why ready for review and hold

@juandahl yes yes, it's more of a POC just for developers to see how to use the SDK, I think the more straightforward the better so yeah, I don't think it's needed. Thanks for the comment ))


Allow user to configure --output-stats

Spawned from #179, add a YAML configuration parameter to select whether umi_tools dedup uses --output-stats or not.

Reported as done on 24 June 2020.


git no longer working when upgrading to V1.21.1

VSCode Version: 1.21.1 x64
OS Version: Windows 10

Steps to Reproduce:

I had V1.19 running. With git working nicely and linked in with GitHub remote accounts
VSC then updated to 1.21.1 and then Git dissapeared from gui and could not get git commands to function in Alt-Shit-P menu. However git still working in VSC terminal.
When I type in git --version in VSC integrated terminal I get: git version 2.16.2.windows.1

Not sure what is wrong here. Any help would be appreciated.

Update:

I've tried uninstalling git and re-installing, still no success. As per above git commands working in VSC terminal but not anywhere else. I notice that "git" does not appear anywhere in the Preference->Settings file but it does in the Insiders edition which I just installed (more on that below)
I've also just installed VSC Insiders and it WORKS perfectly with Insider  but still not working with non-Insider version. Detail of insider version are below:

Does it reproduce if you run with code --disable-extensions?
Does it reproduce if you reinstall VS Code?

Does it reproduce if you run with code --disable-extensions?
Yes
Does it reproduce if you reinstall VS Code?
Yes
From: João Moreno<EMAIL_ADDRESS>Sent: Tuesday, 20 March 2018 02:04
To: Microsoft/vscode<EMAIL_ADDRESS>Cc: mars000<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode] git no longer working when upgrading to V1.21.1 (#46018)
Does it reproduce if you run with code --disable-extensions?
Does it reproduce if you reinstall VS Code?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/46018#issuecomment-374243633 , or mute the thread https://github.com/notifications/unsubscribe-auth/ASkVj52m3KJPJQMUmPaQ2_hiWpPHit2Dks5tf8jDgaJpZM4Suv2U .  https://github.com/notifications/beacon/ASkVj0iU43ifPO932mrKIT0QeX6DFiW7ks5tf8jDgaJpZM4Suv2U.gif

Can you show me your user settings?

{
"git.path" : "C:\\Program Files\\Git\\bin\\git.exe",

"workbench.panel.location": "right",

"window.zoomLevel": 0,

"git.autofetch": true,

"editor.smoothScrolling": true,

"workbench.sideBar.location": "left",

"window.menuBarVisibility": "default"

}
I can confirm this is the location of git.exe
From: João Moreno<EMAIL_ADDRESS>Sent: Tuesday, 20 March 2018 19:22
To: Microsoft/vscode<EMAIL_ADDRESS>Cc: mars000<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode] git no longer working when upgrading to V1.21.1 (#46018)
Can you show me your user settings?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/46018#issuecomment-374512002 , or mute the thread https://github.com/notifications/unsubscribe-auth/ASkVj4TDYQ3BqO2qvGaeStEgmzNi5xBgks5tgLwMgaJpZM4Suv2U .  https://github.com/notifications/beacon/ASkVjx0kq479aY1eQx4zLZLR8hA5nhZeks5tgLwMgaJpZM4Suv2U.gif

How about we try launching it with brand new user data dir?
code --user-data-dir SOME_TEMPORARY_FOLDER

Yep that fixed it – git works perfectly now.
Question is what do I do with existing version so works when I click on icon ?
From: João Moreno<EMAIL_ADDRESS>Sent: Tuesday, 20 March 2018 19:32
To: Microsoft/vscode<EMAIL_ADDRESS>Cc: mars000<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode] git no longer working when upgrading to V1.21.1 (#46018)
How about we try launching it with brand new user data dir?
code --user-data-dir SOME_TEMPORARY_FOLDER
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/46018#issuecomment-374514393 , or mute the thread https://github.com/notifications/unsubscribe-auth/ASkVj1l38iJqB0SA-ESPxKeR8Oe68VzXks5tgL5sgaJpZM4Suv2U .  https://github.com/notifications/beacon/ASkVj8yTkr6bJeAqXEqUVJxtdicZkmMCks5tgL5sgaJpZM4Suv2U.gif

Well, that got me thinking. What about if you simply run
code

(Make sure Code is shut down first). Does that work?

Unfortunately just running “code” does not work.
From: João Moreno<EMAIL_ADDRESS>Sent: Wednesday, 21 March 2018 18:25
To: Microsoft/vscode<EMAIL_ADDRESS>Cc: mars000<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode] git no longer working when upgrading to V1.21.1 (#46018)
Well, that got me thinking. What about if you simply run
code
(Make sure Code is shut down first). Does that work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/46018#issuecomment-374851285 , or mute the thread https://github.com/notifications/unsubscribe-auth/ASkVj5XaPus5gYWQ69CVsPj-jHrhT3Csks5tggBDgaJpZM4Suv2U .  https://github.com/notifications/beacon/ASkVj9Q6YYTdRdC5X-aFSnfHxx1cE5N6ks5tggBDgaJpZM4Suv2U.gif

@alexandrudima @bpasero What could be inside user-data-dir which blocks the git extension from loading? Note that if he sets a different user-data-dir, the git extension opens up. His settings look simple enough:
{
    "git.path" : "C:\\Program Files\\Git\\bin\\git.exe",
    "workbench.panel.location": "right",
    "window.zoomLevel": 0,
    "git.autofetch": true,
    "editor.smoothScrolling": true,
    "workbench.sideBar.location": "left",
    "window.menuBarVisibility": "default"
}

@joaomoreno any error message?

No error messages are displayed.
From: Benjamin Pasero<EMAIL_ADDRESS>Sent: Thursday, 22 March 2018 20:12
To: Microsoft/vscode<EMAIL_ADDRESS>Cc: mars000<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode] git no longer working when upgrading to V1.21.1 (#46018)
@joaomoreno https://github.com/joaomoreno  any error message?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/46018#issuecomment-375227242 , or mute the thread https://github.com/notifications/unsubscribe-auth/ASkVj8Q3ImKWmQ5tN8GjwncMF2KfkCPJks5tg2r3gaJpZM4Suv2U .  https://github.com/notifications/beacon/ASkVj9JqkZpDzapb0LdDJGhhWirhEwbAks5tg2r3gaJpZM4Suv2U.gif

@sandy081 Any ideas?

@mars000 Can you please check what is there in the built in extensions and what extensions are disabled and what extensions are running
Extensions: Show Built-in Extensions
Extensions: Show Disabled Extensions
Developer: Show Running Extensions

Hi – as you can see below Git was disabled. The update from one version to another automatically disabled Git – any reason why this would occur ?
I enabled Git and now it works.
Thank you all for your help.
From: Sandeep Somavarapu<EMAIL_ADDRESS>Sent: Tuesday, 27 March 2018 02:22
To: Microsoft/vscode<EMAIL_ADDRESS>Cc: mars000<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode] git no longer working when upgrading to V1.21.1 (#46018)
@mars000 https://github.com/mars000  Can you please check what is there in the built in extensions and what extensions are disabled and what extensions are running
Extensions: Show Built-in Extensions
Extensions: Show Disabled Extensions
Developer: Show Running Extensions
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/46018#issuecomment-376204825 , or mute the thread https://github.com/notifications/unsubscribe-auth/ASkVj-HSaSTwHavHbOAGKoZ9z55oHh1Eks5tiQewgaJpZM4Suv2U .  https://github.com/notifications/beacon/ASkVj0LCtEdAw2f7ie3whIUo1OmwVyQ4ks5tiQewgaJpZM4Suv2U.gif

Thanks for confirming @mars000
Dupe of #45398


Workflow failed - km_mt_stress_tests

Describe the bug
Failed test case: native_invoke_v4_v6_programs_restart_extension_test
Pipeline:

https://github.com/microsoft/ebpf-for-windows/actions/runs/10066891733/
https://github.com/microsoft/ebpf-for-windows/actions/runs/10080949547

[15:35:08] :: Starting test *** native_invoke_v4_v6_programs_restart_extension_test ***
[15:35:08] :: test threads per program    : 2
[15:35:08] :: test duration (in minutes)  : 5
[15:35:08] :: test verbose output         : false
[15:35:08] :: test extension restart      : false
[15:35:08] :: waiting on 2 test threads...
[15:35:08] :: _load_attach_program(1) FATAL ERROR: bpf_prog_attach(cgroup_count_connect6.sys) failed. program:count_tcp_connect6, errno:22
[15:35:08] :: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[15:35:08] :: ebpf_stress_tests_km is a Catch2 v3.6.0 host application.
[15:35:08] :: Run with -? for options
[15:35:08] :: -------------------------------------------------------------------------------
[15:35:08] :: native_invoke_v4_v6_programs_restart_extension_test
[15:35:08] :: -------------------------------------------------------------------------------
[15:35:08] :: D:\a\ebpf-for-windows\ebpf-for-windows\tests\stress\km\stress_tests_km.cpp(1469)
[15:35:08] :: ...............................................................................
[15:35:09] :: D:\a\ebpf-for-windows\ebpf-for-windows\tests\stress\km\stress_tests_km.cpp(822): FAILED:
[15:35:09] ::   REQUIRE( result == 0 )
[15:35:09] :: with expansion:
[15:35:09] ::   -22 == 0
[15:35:09] ::

[15:35:09] :: *** ERROR *** C:\eBPF\Run-Self-Hosted-Runner-Test.ps1: C:\eBPF\ebpf_stress_tests_km failed.
*** ERROR *** C:\eBPF\Run-Self-Hosted-Runner-Test.ps1: C:\eBPF\ebpf_stress_tests_km failed.
At C:\actions_runner\_work\ebpf-for-windows\ebpf-for-windows\x64\Debug\vm_run_tests.psm1:33 char:5
+     Invoke-Command -VMName $VMName -Credential $TestCredential -Scrip ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (*** ERROR *** C...ests_km failed.:String) [], RuntimeException
    + FullyQualifiedErrorId : *** ERROR *** C:\eBPF\Run-Self-Hosted-Runner-Test.ps1: C:\eBPF\ebpf_stress_tests_km fail
   ed.
    + PSComputerName        : vm1_ws2019

Error: Process completed with exit code 1.

OS information
Windows 10 and above
Steps taken to reproduce bug

Submit to 'Release Validation' pipeline with branch release/0.18

.\ebpf_stress_tests_km.exe -vo=true -td=5 -tt=2 native_invoke_v4_v6_programs_restart_extension_test

Expected behavior
native_invoke_v4_v6_programs_restart_extension_test should pass.
Actual outcome
_load_attach_program(1) FATAL ERROR: bpf_prog_attach(cgroup_count_connect6.sys) failed. program:count_tcp_connect6, errno:22
Additional details
No response

@shpalani - please see if this is a dupe of auto generated bug, and if so close. Otherwise, please work with me to investigate this further and provide a fix by 2408.

Duplicate of #3607

Duplicate of #3607


Setting up flutter for VS Code - Flutter Doctor issue

Hi, I'm trying to setup Flutter for VS Code. So I've installed the plugin Dart for VS Code, installed Git, and extract the Flutter folder. I've also added the path in the PATH variable.
And now, I follow the instructions to set up flutter and I'm at the point where I enter the command "flutter doctor" and it's where I have a problem.
I entered this command in VS Code and the Windows terminal, it give me the same following result.
I pasted the content of the Crash report file that've created and the output of the "flutter doctor" command.
----------------------## Crash Report##----------------------
Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter doctor
exception
ArgumentError: Invalid argument(s): Cannot find executable for C:\Program Files (x86)\Android\android-sdk\tools\bin\sdkmanager.
#0      _getExecutable (package:process/src/interface/local_process_manager.dart:113)
#1      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:41)
#2      runCommand (package:flutter_tools/src/base/process.dart:115)
#3      AndroidWorkflow.licensesAccepted (package:flutter_tools/src/android/android_workflow.dart:188)
<asynchronous suspension>
#4      AndroidWorkflow.validate (package:flutter_tools/src/android/android_workflow.dart:149)
<asynchronous suspension>
#5      Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:71)
#6      Doctor.diagnose (package:flutter_tools/src/doctor.dart:128)
<asynchronous suspension>
#7      DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:29)
<asynchronous suspension>
#8      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:333)
<asynchronous suspension>
#9      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:270)
<asynchronous suspension>
#10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142)
<asynchronous suspension>
#11     _rootRun (dart:async/zone.dart:1126)
#12     _CustomZone.run (dart:async/zone.dart:1023)
#13     runZoned (dart:async/zone.dart:1501)
#14     AppContext.run (package:flutter_tools/src/base/context.dart:141)
<asynchronous suspension>
#15     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:261)
#16     CommandRunner.runCommand (package:args/command_runner.dart:194)
<asynchronous suspension>
#17     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:298)
<asynchronous suspension>
#18     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142)
<asynchronous suspension>
#19     _rootRun (dart:async/zone.dart:1126)
#20     _CustomZone.run (dart:async/zone.dart:1023)
#21     runZoned (dart:async/zone.dart:1501)
#22     AppContext.run (package:flutter_tools/src/base/context.dart:141)
<asynchronous suspension>
#23     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:254)
<asynchronous suspension>
#24     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:109)
#25     new Future.sync (dart:async/future.dart:222)
#26     CommandRunner.run (package:args/command_runner.dart:109)
#27     FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:168)
#28     run.<anonymous closure> (package:flutter_tools/runner.dart:54)
<asynchronous suspension>
#29     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142)
<asynchronous suspension>
#30     _rootRun (dart:async/zone.dart:1126)
#31     _CustomZone.run (dart:async/zone.dart:1023)
#32     runZoned (dart:async/zone.dart:1501)
#33     AppContext.run (package:flutter_tools/src/base/context.dart:141)
<asynchronous suspension>
#34     runInContext (package:flutter_tools/src/context_runner.dart:41)
<asynchronous suspension>
#35     run (package:flutter_tools/runner.dart:49)
#36     main (package:flutter_tools/executable.dart:48)
<asynchronous suspension>
#37     main (file:///E:/b/build/slave/Windows_Flutter_Packaging/build/archive/flutter/packages/flutter_tools/bin/flutter_tools.dart:16)
#38     _startIsolate.<anonymous closure> (dart:isolate-patch/dart:isolate/isolate_patch.dart:277)
#39     _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:165)

flutter doctor
encountered exception: Invalid argument(s): Cannot find executable for C:\Program Files (x86)\Android\android-sdk\tools\bin\sdkmanager.

#0      _getExecutable (package:process/src/interface/local_process_manager.dart:113)
#1      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:41)
#2      runCommand (package:flutter_tools/src/base/process.dart:115)
#3      AndroidWorkflow.licensesAccepted (package:flutter_tools/src/android/android_workflow.dart:188)
<asynchronous suspension>
#4      AndroidWorkflow.validate (package:flutter_tools/src/android/android_workflow.dart:149)
<asynchronous suspension>
#5      Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:71)
#6      Doctor.diagnose (package:flutter_tools/src/doctor.dart:128)
<asynchronous suspension>
#7      _doctorText.<anonymous closure> (package:flutter_tools/runner.dart:189)
#8      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142)
<asynchronous suspension>
#9      _rootRun (dart:async/zone.dart:1126)
#10     _CustomZone.run (dart:async/zone.dart:1023)
#11     runZoned (dart:async/zone.dart:1501)
#12     AppContext.run (package:flutter_tools/src/base/context.dart:141)
<asynchronous suspension>
#13     _doctorText (package:flutter_tools/runner.dart:188)
<asynchronous suspension>
#14     _createLocalCrashReport (package:flutter_tools/runner.dart:166)
<asynchronous suspension>
#15     _handleToolError (package:flutter_tools/runner.dart:121)
<asynchronous suspension>
#16     run.<anonymous closure> (package:flutter_tools/runner.dart:58)
<asynchronous suspension>
#17     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142)
<asynchronous suspension>
#18     _rootRun (dart:async/zone.dart:1126)
#19     _CustomZone.run (dart:async/zone.dart:1023)
#20     runZoned (dart:async/zone.dart:1501)
#21     AppContext.run (package:flutter_tools/src/base/context.dart:141)
<asynchronous suspension>
#22     runInContext (package:flutter_tools/src/context_runner.dart:41)
<asynchronous suspension>
#23     run (package:flutter_tools/runner.dart:49)
#24     main (package:flutter_tools/executable.dart:48)
<asynchronous suspension>
#25     main (file:///E:/b/build/slave/Windows_Flutter_Packaging/build/archive/flutter/packages/flutter_tools/bin/flutter_tools.dart:16)
#26     _startIsolate.<anonymous closure> (dart:isolate-patch/dart:isolate/isolate_patch.dart:277)
#27     _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:165)

----------------------## Flutter Doctor##----------------------
[√] Flutter (Channel beta, v0.2.8, on Microsoft Windows [version 10.0.16299.371], locale fr-FR)
• Flutter version 0.2.8 at C:\flutter
• Framework revision b397406561 (3 weeks ago), 2018-04-02 13:53:20 -0700
• Engine revision c903c217a1
• Dart version 2.0.0-dev.43.0.flutter-52afcba357
Oops; flutter has exited unexpectedly.
Sending crash report to Google.
Crash report sent (report ID: de44580f175f129a)
Crash report written to C:\Users\alban\flutter_01.log;
please let us know at https://github.com/flutter/flutter/issues.

C:\Program Files (x86)\Android\android-sdk\tools\bin\sdkmanager.exe does not exist on my computer, but I have C:\Program Files (x86)\Android\android-sdk

Do you have the tools folder? Do you know where the SDK came from? Did you install Android Studio?

I don't have the folder "tools" but I have one name "build-tools" (I don't know if it's an equivalent)
And yes I installed Android Studio and installed a couple of android versions through the SDK manager (in Android studio)
(I have all of this installed because I'm actually using Ionic to make Android/IOS apps , don't know if it's important to mention)

I checked the path and it is not C:\Program Files (x86)\Android\android-sdk but it's C:\Users\name\AppData\Local\Android\Sdk
(The option Android sdk tools was already ticked)
So how do I update the path for flutter?

This solved the problem, flutter doctor works fine now. Thank you


Updating RelationalFullBatchNodeGenerator's flow method

RelationalFullBatchNodeGenerator's flow method is extended to have a use_ilocs parameter as FullBatchNodeGenerator's flow method has. This subject was discussed in issues.
Fixes #1870

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks again!

Thank You @huonw for informing me about the proper way to submit a pull request. This was my first pull request on any project and I learned more than I imagined while submitting this pull request. Thank you for encouraging me to do it.

No worries, and congratulations! 🎉


dish screen in landscape mode on iPad

Doesn't scroll the whole dish page, so the photo is always visible but can't see much below.

Better now.


I have a routing error when the server is rendered asynchronously under SSR.

Version
4.0.0
Reproduction link
https://github.com/gsdukbh/vue3-ssr-demo
Steps to reproduce
Here is my configuration
Universal entry file main.app.ts
/* eslint-disable */
import {createApp, createSSRApp} from "vue";
import App from "./App.vue";
import router from "./router";
import store from "./store";

const isSSR = typeof window === 'undefined'

export function buildApp() {
    const app = (isSSR ? createSSRApp(App) : createApp(App));
    app.use(router);
    app.use(store);
    return {app, router, store};
}

Client entry mian.ts
/* eslint-disable */
import {buildApp} from './main.app';

const {app, router, store} = buildApp();

const storeInitialState =  (window as any).INITIAL_DATA;

if (storeInitialState) {
    store.replaceState(storeInitialState);
}

router.isReady()
    .then(() => {
        app.mount('#app');
    });

Server entrance  main.server.ts
import { RouteLocationRaw } from 'vue-router';
import { buildApp } from './main.app';

export default (url: RouteLocationRaw) =>
  new Promise((resolve, reject) => {
    const { router, app, store } = buildApp();

    router.push(url);

    router
      .isReady()
      .then(() => {
        const matchedComponents = router.currentRoute.value.matched;
        //
        if (!matchedComponents.length) {
          return reject(new Error('404'));
        }

        // Promise should be resolved to an application instance so that it can be rendered
        return resolve({ app, router, store });
      })
      .catch(() => reject);
  });

Server.js run in node
/* eslint-disable */
/* @ts-ignore */
const serialize = require('serialize-javascript');
const path = require('path');
const express = require('express');
const fs = require('fs');
const {renderToString} = require('@vue/server-renderer');
const manifest = require('../dist/server/ssr-manifest.json');

// Create the express app.
const server = express();

// @ts-ignore
const appPath = path.join(__dirname, '../dist', 'server', manifest['app.js']);
const createApp = require(appPath).default;

const clientDistPath = '../dist/client';

// @ts-ignore
server.use('/img', express.static(path.join(__dirname, clientDistPath, 'img')));
// @ts-ignore
server.use('/js', express.static(path.join(__dirname, clientDistPath, 'js')));
// @ts-ignore
server.use('/css', express.static(path.join(__dirname, clientDistPath, 'css')));
// @ts-ignore
server.use('/favicon.ico', express.static(path.join(__dirname, clientDistPath, 'favicon.ico')));

// Handle all routes in our application
// @ts-ignore
server.get('*', async (req, res) => {
    const {app, store} = await createApp(req);

    let appContent = await renderToString(app);

    const renderState = `
    `;

    // @ts-ignore
    fs.readFile(path.join(__dirname, clientDistPath, 'index.html'), (err, html) => {
            if (err) {
                throw err;
            }
            appContent = `<div id="app">${appContent}</div>`;

            html = html.toString().replace('

',
                `${renderState}${appContent}`);
            res.setHeader('Content-Type', 'text/html');
            res.send(html);
        });
});

const port = process.env.PORT || 8080;
server.listen(port, () => {
    console.log(`You can navigate to http://localhost:${port}`);
});

Routing file router/index.ts
import {
  createMemoryHistory,
  createRouter,
  createWebHistory,
  RouteRecordRaw,
} from 'vue-router';
import Home from '../views/Home.vue';
// import About from '../views/About.vue';

const routes: Array<RouteRecordRaw> = [
  {
    path: '/',
    name: 'Home',
    component: Home,
    props: true,
  },
  {
    path: '/about',
    name: 'About',
    props: true,
    component: () => import(/* webpackChunkName: "about" */ '../views/About.vue'),
        // route level code-splitting
    // this generates a separate chunk (about.[hash].js) for this route
    // which is lazy-loaded when the route is visited.
// This method does not work correctly ,Server renderin
  },
];
const isServer = typeof window === 'undefined';
const history = isServer
  ? createMemoryHistory()
  : createWebHistory(process.env.BASE_URL);
const router = createRouter({
  history: history,
  routes,
});

export default router;

Error & problem
In server rendering mode，configuration code in router file component: () => import(/* webpackChunkName: "about" */ '../views/About.vue')。  An error is reported directly when accessing the / about path.
curl -L -O http://localhost:8080/about # Use this test.

Error message.
[Vue Router warn]: Path "/about" was passed with params but they will be ignored. Use a named route alongside params instead.
(node:11422) UnhandledPromiseRejectionWarning: Error: Cannot find module './js/about.0d8cd63d.js'
Require stack:
- /Users/lee/vue/hello-ssr/dist/server/js/app.b8fe1cc1.js
- /Users/lee/vue/hello-ssr/src/server.ts
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Function.requireEnsure [as e] (/Users/leejiawei/vue/hello-ssr/dist/server/js/app.b8fe1cc1.js:46:25)
    at component (/Users/lee/vue/hello-ssr/dist/server/js/app.b8fe1cc1.js:964:32)
    at extractComponentsGuards (/Users/lee/vue/hello-ssr/node_modules/vue-router/dist/vue-router.cjs.js:1987:40)
    at /Users/lee/vue/hello-ssr/node_modules/vue-router/dist/vue-router.cjs.js:2623:22
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(node:11422) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 9)

What is expected?
I want to be able to load routes asynchronously on the server.
What is actually happening?
Unable to use, report an error directly.

Please translate everything to English so I can take a look.

Please translate everything to English so I can take a look.

ok,My English is not that good. I beg your pardon.

The error you see is unrelated to the router, it's something with the webpack config you have not correctly serving the js bundle containing your about page. You might want to take a look at https://github.com/frandiox/vite-ssr

thank


ili links to compling which is down

It should link to the new server on lr:
e.g., meronym: https://lr.soh.ntu.edu.sg/omw/omw/concepts/ili/69575

This issue has been fixed #28

This has been done


Search group configuration file

Add documentation for the configuration file that allows to group results.

example: https://github.com/metagenomics/bioPipeline/blob/master/features/data/search.yaml


pass the key to the super

key is not passed to the super class (FormField)

Hi @ahmedNY ,
We would be happy to receive a PR to add support for referencing super class. Please try creating a focussed PR with just that functionality and we will review. Cheers.


ABOD error

Failed in nopython mode pipeline (step: nopython frontend)
No implementation of function Function(<function dot at 0x7fab0417f440>) found for signature:

dot(array(int64, 1d, C), array(int64, 1d, C))

There are 2 candidate implementations:

Of which 2 did not match due to:
Overload in function 'dot': File: numba/core/typing/npydecl.py: Line 950.
With argument(s): '(array(int64, 1d, C), array(int64, 1d, C))':
Rejected as the implementation raised a specific error:
TypingError: np.dot() only supported on float and complex arrays

def _wcos(curr_pt, a, b):  # pragma: no cover

wcos = np.dot(a_curr, b_curr) / (
np.linalg.norm(a_curr, 2) ** 2) / (
^****

Hi,
I have the same error using ABOD with PyOD. How did you solve this issue? Thanks.


BUG: groupby.transform length mismatch under certain specifications

Replicating Example (pandas 15.2 and 0.16.0rc1-32-g5a417ec):
import numpy as np
df = pd.DataFrame({'col1':[1,1,2,2], 'col2':[1,2,3,np.nan]})

# Works fine
df.groupby('col1').transform(sum)['col2']

# Throws error
df.groupby('col1')['col2'].transform(sum)

Error:
Traceback (most recent call last):
  File "<ipython-input-7-f969e26273d4>", line 8, in <module>
    df.groupby('col1')['col2'].transform(sum)

  File "/Users/Nick/GitHub/pandas/pandas/core/groupby.py", line 2418, in transform
    return self._transform_fast(cyfunc)

  File "/Users/Nick/GitHub/pandas/pandas/core/groupby.py", line 2459, in _transform_fast
    return self._set_result_index_ordered(Series(values))

  File "/Users/Nick/GitHub/pandas/pandas/core/groupby.py", line 497, in _set_result_index_ordered
    result.index = self.obj.index

  File "/Users/Nick/GitHub/pandas/pandas/core/generic.py", line 2061, in __setattr__
    return object.__setattr__(self, name, value)

  File "pandas/src/properties.pyx", line 65, in pandas.lib.AxisProperty.__set__ (pandas/lib.c:41404)
    obj._set_axis(self.axis, value)

  File "/Users/Nick/GitHub/pandas/pandas/core/series.py", line 268, in _set_axis
    self._data.set_axis(axis, labels)

  File "/Users/Nick/GitHub/pandas/pandas/core/internals.py", line 2211, in set_axis
    'new values have %d elements' % (old_len, new_len))

ValueError: Length mismatch: Expected axis has 3 elements, new values have 4 elements

Note that
>>> df.groupby("col1")["col2"].transform(lambda x: np.nansum(x))
0    3
1    3
2    3
3    3
Name: col2, dtype: float64

works, so the bug must be in the fastpath.

More information: the use of count in _transform_fast doesn't seem right to me (that'll pick up the number of non-nan values in the series, IIUC, whereas we want the size of the groups.
We're also seeing things like

yep, this https://github.com/pydata/pandas/blob/master/pandas/core/groupby.py#L2456
should be self.size().values. Its the group size here that matters.

Switching count -> size seems to fix the original problem.  Doesn't pass the tests I made which revealed the index problem above.  Shall I submit a PR with the count/size switch here and open a new issue for that one?

@dsm054 that would be gr8 thxs

I may be having the same problem in Pandas 0.16.1. I describe it here:
http://stackoverflow.com/questions/30290482/normalizing-columns-of-multiindex-dataframe-in-pandas-maybe-a-bug
I have a Pandas Dataframe with hierarchically indexed columns. Eg:
cols = pd.MultiIndex.from_tuples([('syn', 'A'), ('mis', 'A'), ('non', 'A'),     ('syn', 'C'), ('mis', 'C'), ('non', 'C'),
                              ('syn', 'T'), ('mis', 'T'), ('non', 'T'), ('syn', 'G'), ('mis', 'G'), ('non', 'G')])
sample = pd.DataFrame(np.random.randint(1, 10, (4,12)), columns=cols, index=['A', 'C', 'G', 'T'])
sample.head()

Giving:
    syn	mis	non	syn	mis	non	syn	mis	non	syn	mis	non
    A	A	A	C	C	C	T	T	T	G	G	G
A	7	3	9	5	4	8	6	4	3	6	4	2
C	5	2	2	4	9	6	3	3	9	6	2	1
G	2	4	5	2	8	3	8	3	6	1	2	4
T	9	4	8	9	8	5	8	8	2	2	6	5

However, when I attempt to normalize on level 1 of the columns as follows:
sample.groupby(axis=1, level=1).transform(lambda z: z.div(z.sum(axis=1), axis=0))

I get an error:
ValueError: Length mismatch: Expected axis has 4 elements, new values have 12 elements

Weirdly, it works fine if I use up to 3 of the values of level 1 of axis 1, for example:
ind = sample.columns.get_level_values(1).isin(['A', 'C', 'G'])
subsample = sample.loc[:, ind]
subsample.head()

which just takes the first 3 sets of values from the sample:
    syn	mis	non	syn	mis	non	syn	mis	non
    A	A	A	C	C	C	G	G	G
A	7	3	9	5	4	8	6	4	2
C	5	2	2	4	9	6	6	2	1
G	2	4	5	2	8	3	1	2	4
T	9	4	8	9	8	5	2	6	5

Then:
subsample.groupby(axis=1, level=1).transform(lambda z: z.div(z.sum(axis=1), axis=0))

correctly returns:
	syn	mis	non	syn	mis	non	syn	mis	non
    A	    A	    A	    C	    C	    C	    G	    G	    G
A	0.37	0.16	0.47	0.29	0.24	0.47	0.50	0.33	0.17
C	0.56	0.22	0.22	0.21	0.47	0.32	0.67	0.22	0.11
G	0.18	0.36	0.45	0.15	0.62	0.23	0.14	0.29	0.57
T	0.43	0.19	0.38	0.41	0.36	0.23	0.15	0.46	0.38

Any idea why the latter works and the former doesn't? I'm using Pandas version 0.16.1

.transform must return a scalar value for each group. You are returning a frame. Try this.
In [44]: sample.groupby(axis=1, level=0).apply(lambda z: z.div(z.sum(axis=1), axis=0))
Out[44]:
        syn       mis       non       syn       mis       non       syn       mis       non       syn       mis       non
          A         A         A         C         C         C         T         T         T         G         G         G
A  0.125000  0.090909  0.333333  0.375000  0.181818  0.133333  0.250000  0.090909  0.200000  0.250000  0.636364  0.333333
C  0.200000  0.240000  0.230769  0.133333  0.320000  0.307692  0.133333  0.320000  0.115385  0.533333  0.120000  0.346154
G  0.350000  0.318182  0.461538  0.300000  0.136364  0.230769  0.100000  0.136364  0.230769  0.250000  0.409091  0.076923
T  0.052632  0.200000  0.071429  0.368421  0.150000  0.285714  0.368421  0.350000  0.142857  0.210526  0.300000  0.500000

I see, that does indeed work, thanks so much for the help. I am a bit confused by the documentation then. The docstring for transform says:
Call function producing a like-indexed DataFrame on each group and
return a DataFrame having the same indexes as the original object
filled with the transformed values
So I assumed that transform would return a "transformed" dataframe for each group. In any case, now I think I have a better understanding of apply. Thanks again!

yes, that the result of a transform. a user-defined function needs to return a single (scalar) value. hmm, maybe be better to have a nicer error message / doc. going to make an issue.

@dylkot see #10165
if you want to have a go would be gr8!


Use grad init by default and introduce early mass matrix switch

This enables grad_init by default. grad_init initializes the very first mass matrix estimate using the gradient at the initial position, which improves early tuning behavior.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@98c9022). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   89.29%
=========================================
  Files             ?        9
  Lines             ?     1756
  Branches          ?        0
=========================================
  Hits              ?     1568
  Misses            ?      188
  Partials          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

why window var appeared better than exponential decay?

I'm not entirely sure. Maybe I just did the initialization wrong, but in my tests it just worked a bit more reliably.

cc @ferrine If you want to have a look at it, I think this is ready for a review


1.3.2 TOE Platform -- fix text

the scope is strange and spelt wrongly.

reworded to make it plain that:

the hardware is out of scope
all the other processors running all other sorts of software/firmware are also out of scope.


[docs] [issue 8640] Update helm chart link

Fixes #8640
It seems that the overview is the only file that provides the link for Helm chart, and this pr replaces the old link with the new one.

@Huanli-Meng Thanks for your feedback. Updated accordingly. PTAL.

LGTM


Cleanup counters in local client cache

two improvements:

Added new counter "Client.CachePutInsufficientSpaceErrors" indicating the failed put due to insufficient space made after eviction attempts.
Remove unnecessary cleanup which may artificially bump error counters
Remove unnecessary directory cleanup which has potential race condition to fail put unnecessarily

Codecov Report

Merging #12813 (a5201c6) into master (2fb220b) will decrease coverage by 33.90%.
The diff coverage is 46.15%.

@@              Coverage Diff              @@
##             master   #12813       +/-   ##
=============================================
- Coverage     55.88%   21.97%   -33.91%
+ Complexity    11541     3919     -7622
=============================================
  Files          1344     1344
  Lines         77202    77238       +36
  Branches       9409     9409
=============================================
- Hits          43143    16975    -26168
- Misses        30844    59117    +28273
+ Partials       3215     1146     -2069

Impacted Files
Coverage Δ
Complexity Δ

...lluxio/client/file/cache/store/LocalPageStore.java
79.26% <ø> (-0.97%)
20.00 <0.00> (-1.00)

...ommon/src/main/java/alluxio/metrics/MetricKey.java
0.00% <0.00%> (-96.76%)
0.00 <0.00> (-15.00)

...a/alluxio/client/file/cache/LocalCacheManager.java
89.82% <75.00%> (+0.58%)
59.00 <0.00> (ø)

core/base/src/main/java/alluxio/wire/UfsInfo.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-5.00%)

...re/base/src/main/java/alluxio/underfs/UfsMode.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-1.00%)

...e/base/src/main/java/alluxio/util/StreamUtils.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-1.00%)

...common/src/main/java/alluxio/grpc/DataMessage.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-3.00%)

...common/src/main/java/alluxio/grpc/GrpcService.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-6.00%)

...common/src/main/java/alluxio/time/TimeContext.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-4.00%)

...mmon/src/main/java/alluxio/metrics/MetricInfo.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (ø%)

... and 842 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c522a2...a5201c6. Read the comment docs.

alluxio-bot, merge this please


Add saving data testcases and effort appendix

Also some minor additions to the UG, as well as adding to the acknowledgements in index.md
@Anyone reading this: If you would like, please read through the effort section and see if there's anything you disagree with/would like to add.

@jonas-chow I added a section to features scrapped section in #290. Could you take a look at that and merge it into your current branch if it's okay?

Codecov Report

Merging #289 (88ce8df) into master (ebcc385) will decrease coverage by 0.23%.
The diff coverage is 55.17%.

@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
- Coverage     76.11%   75.88%   -0.24%
- Complexity      934     1872     +938
============================================
  Files           105      210     +105
  Lines          2918     5863    +2945
  Branches        396      788     +392
============================================
+ Hits           2221     4449    +2228
- Misses          590     1198     +608
- Partials        107      216     +109

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/AddressBookParser.java
100.00% <ø> (+1.85%)
:arrow_up:

...rc/main/java/seedu/address/logic/LogicManager.java
68.57% <26.66%> (-31.43%)
:arrow_down:

...seedu/address/logic/parser/AliasCommandParser.java
83.33% <85.71%> (+2.68%)
:arrow_up:

...va/seedu/sourcecontrol/logic/commands/Command.java
100.00% <0.00%> (ø)

...ava/seedu/sourcecontrol/commons/util/FileUtil.java
69.69% <0.00%> (ø)

...eedu/sourcecontrol/logic/commands/EditCommand.java
97.10% <0.00%> (ø)

...c/main/java/seedu/sourcecontrol/ui/MainWindow.java
0.00% <0.00%> (ø)

...ourcecontrol/logic/parser/DeleteCommandParser.java
80.00% <0.00%> (ø)

...va/seedu/sourcecontrol/logic/parser/CliSyntax.java
90.00% <0.00%> (ø)

...tudent/exceptions/AssessmentNotFoundException.java
100.00% <0.00%> (ø)

... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcc385...88ce8df. Read the comment docs.


Stable docs are missing

https://pyo3.rs goes to 404.

https://travis-ci.org/github/PyO3/pyo3/builds/664261632
I don't understand why this build fails...

Fixed


Type definition complains

I am trying to transpile the following helloworld.ts file:
import Rx = require("@reactivex/rxjs");
Rx.Observable.of('Hello World!').subscribe(function(value) {
console.log(value);
});
I have TypeScript 1.6.2 installed and have installed:
npm install @reactivex/rxjs
I am receiving the following errors, am I doing something wrong or this is a bug:
tsc -module commonjs helloworld
node_modules/@reactivex/rxjs/dist/cjs/CoreOperators.d.ts(21,70): error TS2304: Cannot find name 'Promise'.
node_modules/@reactivex/rxjs/dist/cjs/CoreOperators.d.ts(73,31): error TS2304: Cannot find name 'PromiseConstructor'.
node_modules/@reactivex/rxjs/dist/cjs/CoreOperators.d.ts(73,54): error TS2304: Cannot find name 'Promise'.
node_modules/@reactivex/rxjs/dist/cjs/Observable.d.ts(63,53): error TS2304: Cannot find name 'PromiseConstructor'.
node_modules/@reactivex/rxjs/dist/cjs/Observable.d.ts(63,74): error TS2304: Cannot find name 'Promise'.
node_modules/@reactivex/rxjs/dist/cjs/Observable.d.ts(74,38): error TS2304: Cannot find name 'Promise'.
node_modules/@reactivex/rxjs/dist/cjs/Observable.d.ts(97,69): error TS2304: Cannot find name 'Promise'.
node_modules/@reactivex/rxjs/dist/cjs/Observable.d.ts(149,30): error TS2304: Cannot find name 'PromiseConstructor'.
node_modules/@reactivex/rxjs/dist/cjs/Observable.d.ts(149,53): error TS2304: Cannot find name 'Promise'.

You're missing type definition declaration for promise.
///
either you can manually pick those definition, or could lookup definitelytyped.

In my case, I use es6-promise for testing codes.

After adding the es6-promise it is still giving the following errors:
node_modules/@reactivex/rxjs/dist/cjs/CoreOperators.d.ts(73,31): error TS2304: Cannot find name 'PromiseConstructor'.
node_modules/@reactivex/rxjs/dist/cjs/Observable.d.ts(63,53): error TS2304: Cannot find name 'PromiseConstructor'.
node_modules/@reactivex/rxjs/dist/cjs/Observable.d.ts(149,30): error TS2304: Cannot find name 'PromiseConstructor'.

Installed and this works:
tsd init
tsd install es6-shim  --save
And adding this in the helloworld.ts:
///
Thanks

Think this can be closed?

Yes thanks, however I think this is a bug because es6-shim is already included here:
https://github.com/ReactiveX/RxJS/blob/master/tsd.json
Adding it ourselves should not be required.

Meaning packaging type definition (d.ts) into npm package by default?

@robwormald have you run into this?

yep, but we include es6-shim in the angular repo (temporarily) so this error doesn't surface for us.
I'll have a proper look tomorrow, we're doing a bit of hackery to make this work correctly.

also note that TS includes the types that are erroring in https://github.com/Microsoft/TypeScript/blob/master/lib/lib.es6.d.ts#L5095
So, if you're targeting ES5/CJS, you can simply add that file to your tsconfig:
{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es5",
        "noImplicitAny": false,
        "outDir": "built",
        "rootDir": ".",
        "sourceMap": false
    },
    "files": [
      "helloworld.ts",
      "node_modules/typescript/lib/lib.es6.d.ts"
    ],
    "exclude": [
        "node_modules"
    ]
}

and run tsc at the prompt. no errors, no silly /// refs.

@ziaukhan @robwormald has this been resolved?

I'd like to suggest to close this for now - remaining discussion in here is if RxJS need to package type definition of es6-shim or not. As @robwormald suggested, lib.es6.d.ts can be used.

That sounds reasonable. We can always reopen.


[Bug report] : Accordions collapse feature not working

Fix an issue with the Accordions where the collapse(Hide) action is not functioning correctly, while the expand action is working as expected.
Attached the snap for reference

This issue is dublicated


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information

Type
Data

Download Page URI
https://github.com/uutils/coreutils/releases

Publisher
UUtils Developers

Package Name
UUtilsDevelopers.Coreutils

Description
> uutils coreutils is a cross-platform reimplementation of the GNU coreutils in Rust.

Package Version
0.0.23

Installer URI
https://github.com/uutils/coreutils/releases/download/0.0.23/coreutils-0.0.23-x86_64-pc-windows-msvc.zip

I chose the MSVC version because it merely seemed most appropriate for WinGet. I've no idea whether the GNU or MSVC version is preferable.

Thanks for making this! Since you asked for feedback, I only have one small suggestion: uutils is usually not capitalized. What else do you need feedback on?

https://github.com/uutils/coreutils/issues/4291#issuecomment-1813211832

@tertsdiepraam and @sylvestre, WinGet doesn't use that naming scheme. It uses CamelCase reverse DNS with a mandatory publisher as its parent.

It uses CamelCase reverse DNS with a mandatory publisher as its parent.

Is it due to winget's doc/spec?
When I was drafting uutils.coreutils{,.installer,.locale.en-US}.yaml in https://github.com/uutils/coreutils/issues/4291#issuecomment-1812534020, I chose uutils.coreutils because I noticed https://github.com/microsoft/winget-pkgs/tree/master/manifests/u/uxmal/reko, whose ID is fully lower case, can be installed by winget install -e --id uxmal.reko as decribed in https://winget.run/pkg/uxmal/reko.

https://github.com/microsoft/winget-pkgs/issues/126833#issuecomment-1813751506

I can't say, @YDX-2147483647. I'd never seen an exception after a good few years of using it and helping to publish manifests, so although I might once have been told so or read it, it was probably more likely an assertion at best. We can always change the manifest later, although that might cause issues for users.
Have you been able to find anything relevant? https://learn.microsoft.com/en-us/windows/package-manager/configuration/create#example-winget-configuration-file:~:text=in this section.-,resource,-%3A Both the "Assertions doesn't appear to be of much use.

The only thing I find is https://github.com/microsoft/winget-pkgs/blob/f508b5d5e52df0b055e95e8ddc4fa1c01135b7fa/doc/manifest/schema/1.5.0/installer.md?plain=1#L152C25-L152C36

This key is the unique identifier for a given package. This value is generally in the form of Publisher.Package. It is case sensitive, and this value must match the folder structure under the partition directory in GitHub.

I have not inspect any winget manifest before, so let's take your choice.

Can you update this to v0.0.26?

@Dragon1573 is that something you could help with? thanks


Handle event listener functions more gracefully

Related issues:
https://github.com/mapbox/mapbox-gl-js/issues/11433
https://github.com/ionic-team/capacitor/issues/4178

Platforms affected
Motivation and Context

Description

Testing

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

Have modified implementation to more closely represent behaviour of the real thing. Turns out you can pass undefined as an argument, and it's a valid event label!

Just wondering why this was closed and what became of this? Was a fix merged?


Refactoring with Headers behaves unexpectedly.

Tried refactoring based on H3, then inside that note, tried the same, and it created the links for a second and just replaces the whole content back in the file. So, I did it again for like 3-4 times, same thing kept happening.
I think it was due to --- in my text. When I removed --- lines from my text, they for refactored. But there was another catch.
Guess what?
Now all the files (refactored notes), now have repeated contents!! 3-4 times the same stuff. Somenotes were ling enough. Its been quite sometime, and I am still landing on pages with such repetitions. Complete mess :)
Please look into the error. I don't really know how to reproduce it exactly. But strong feeling about the --- thing.

So, you ran the command to refactor a note by H3 and then ran the same command on the same note a second time? That shouldn't do anything as there are no other H3's to extract.
I've done some testing with --- included in refactored note content without any issues. Are you able to share examples of the notes you were using?  I can then try and recreate your issue with the same content you were using.

As for the H3 in the new notes, ofcourse I made them available after replacing all the H4 with H3 and then ran the command 😅.
I suspected --- since it is the only thing that existed visibly different other than other notes that I had refactored till now.
I try to see if I can reproduce with an example and get back to you.

I had issues with files where there's multiple H3 and H4 below them (and I tried using this plugin to refactor all H3 headers.)
The H3-only sections where refactored correctly while others with H4 below it where skipped (in some cases, the new files were created correctly with contents, but the original parts in the original file were not replaced with a link).

I had issues with files where there's multiple H3 and H4 below them (and I tried using this plugin to refactor all H3 headers.)
The H3-only sections where refactored correctly while others with H4 below it where skipped (in some cases, the new files were created correctly with contents, but the original parts in the original file were not replaced with a link).


Select between GRCh38 and HG19

Allows selection between GRCh38 and hg19 using the --reference-genome parameter
as discussed in #132
This code has only been tested for parameter parsing, it has not yet been run on a cluster, let me know if you want me to test it further before this PR is accepted

LGTM!

I want clean the überscript up a bit so I will go ahead and rebase and merge this. Otherwise, I'd be causing even more conflicts.
@jpdna I use SourceTree and XCode's FileMerge for conflict resolution. PyCHarm also has an excellent GUI for merge conflict resolution.

I just anyhow  pushed the re-based version to my repo, and so will update
the pull request anyhow, so you can start from wherever you prefer Hannes -
thanks!
On Tue, Mar 8, 2016 at 5:12 PM, Hannes Schmidt<EMAIL_ADDRESS>wrote:

I want clean the überscript up a bit so I will go ahead and rebase and
merge this. Otherwise, I'd be causing even more conflicts.
@jpdna https://github.com/jpdna I use SourceTree and XCode's FileMerge
for conflict resolution. PyCHarm also has an excellent GUI for merge
conflict resolution.
—
Reply to this email directly or view it on GitHub
https://github.com/BD2KGenomics/toil-scripts/pull/133#issuecomment-193989736
.

Thanks, I'll take it from here.

Superceded by #159