[BUG] RuntimeError: batch dimension mismatch with discrete PettingZoo using ONE_GROUP_PER_AGENT

Describe the bug
When trying to use the discrete PettingZoo environment with ONE_GROUP_PER_AGENT, I'm getting the following error.
RuntimeError: batch dimension mismatch, got self.batch_size=torch.Size([1]) and value.shape=torch.Size([]).

The main issue is caused when saving the log_prob key.  It seems that there is a mismatch in the structure of the log_prob keys and the other keys in the tensordict. While the observation, reward, etc. have a dimension for the number of agents (which is redundant when using ONE_GROUP_PER_AGENT), the log_prob does not:
> policy_module(env_continuous.reset())
TensorDict(
    fields={
        agent_0: TensorDict(
            fields={
                action: Tensor(shape=torch.Size([1, 5]), device=cpu, dtype=torch.float32, is_shared=False),
                done: Tensor(shape=torch.Size([1, 1]), device=cpu, dtype=torch.bool, is_shared=False),
                loc: Tensor(shape=torch.Size([1, 5]), device=cpu, dtype=torch.float32, is_shared=False),
                observation: Tensor(shape=torch.Size([1, 18]), device=cpu, dtype=torch.float32, is_shared=False),
                sample_log_prob: Tensor(shape=torch.Size([1]), device=cpu, dtype=torch.float32, is_shared=False),
                scale: Tensor(shape=torch.Size([1, 5]), device=cpu, dtype=torch.float32, is_shared=False),
                terminated: Tensor(shape=torch.Size([1, 1]), device=cpu, dtype=torch.bool, is_shared=False),
                truncated: Tensor(shape=torch.Size([1, 1]), device=cpu, dtype=torch.bool, is_shared=False)},
            batch_size=torch.Size([1]),
            device=None,
            is_shared=False),

To Reproduce
The bug can be reproduced with the snippet below. The continuous case work without problems, but the discrete env will break.
Here we're doing inference of only one of the agents in the environment, so we cannot do a full rollout.
from tensordict.nn import TensorDictModule
from tensordict.nn.distributions import NormalParamExtractor
from torch import nn
from torchrl.modules import OneHotCategorical, ProbabilisticActor, TanhNormal
from torchrl.envs import MarlGroupMapType, PettingZooEnv

# Case 1: continuous environment.
env_continuous = PettingZooEnv(
    task="simple_spread_v3",
    parallel=True,
    group_map=MarlGroupMapType.ONE_GROUP_PER_AGENT,
    continuous_actions=True,
)

observation_size = env_continuous.observation_spec["agent_0", "observation"].shape[-1]
action_size = env_continuous.full_action_spec["agent_0", "action"].shape[-1]
action_spec = env_continuous.full_action_spec["agent_0", "action"]
hidden_size = 32

policy_td_module = TensorDictModule(
    nn.Sequential(
        nn.Linear(observation_size, hidden_size),
        nn.ReLU(),
        nn.Linear(hidden_size, 2 * action_size),
        NormalParamExtractor(),
    ),
    in_keys=[("agent_0", "observation")],
    out_keys=[("agent_0", "loc"), ("agent_0", "scale")],
)

policy_module = ProbabilisticActor(
    module=policy_td_module,
    in_keys=[("agent_0", "loc"), ("agent_0", "scale")],
    out_keys=[("agent_0", "action")],
    # NOTE: seems to make no difference in the behavior of the bug.
    # spec=action_spec,
    distribution_class=TanhNormal,
    return_log_prob=True,
    log_prob_key=("agent_0", "sample_log_prob"),
)

# NOTE: works!
policy_module(env_continuous.reset())

del env_continuous, policy_td_module, policy_module

# Case 2: discrete environment.
env_discrete = PettingZooEnv(
    task="simple_spread_v3",
    parallel=True,
    group_map=MarlGroupMapType.ONE_GROUP_PER_AGENT,
    continuous_actions=False,
)

observation_size = env_discrete.observation_spec["agent_0", "observation"].shape[-1]
action_size = env_discrete.full_action_spec["agent_0", "action"].shape[-1]
action_spec = env_discrete.full_action_spec["agent_0", "action"]

policy_td_module = TensorDictModule(
    nn.Sequential(
        nn.Linear(observation_size, hidden_size),
        nn.ReLU(),
        nn.Linear(hidden_size, action_size),
    ),
    in_keys=[("agent_0", "observation")],
    out_keys=[("agent_0", "logits")],
)

policy_module = ProbabilisticActor(
    module=policy_td_module,
    in_keys=[("agent_0", "logits")],
    out_keys=[("agent_0", "action")],
    # NOTE: seems to make no difference in the behavior of the bug.
    spec=action_spec,
    distribution_class=OneHotCategorical,
    # NOTE: disabling this fixes the issue.
    return_log_prob=True,
    log_prob_key=("agent_0", "sample_log_prob"),
)

# BUG: RuntimeError: batch dimension mismatch, got self.batch_size=torch.Size([1]) and value.shape=torch.Size([]).
policy_module(env_discrete.reset())

Expected behavior
The provided snippet should run without issues.
System info
Ubuntu 22.04
Python 3.10.14
torch 2.4.1
torchrl 0.5.0
Checklist

[x] I have checked that there is no similar issue in the repo (required)
[x] I have read the documentation (required)
[x] I have provided a minimal working example to reproduce the bug (required)

Hmm, I've just realized that by default the discrete actions are categorical and not one-hot encoded.
By setting categorical_actions=False in the constructor of the environment, the provided script ran without issues.
Alternatively, one could use torch.distributions.Categorical instead.
My bad!

No worry, is there anything we can do to make things clearer for other users when they face this?


Display line breaks in chat

Hi,
Suggestion for a small but nice frontend improvement: add whitespace-pre-line as an HTML class in this line:
https://github.com/weaviate/Verba/blob/94a2555b0f0b8adcd2d3adabe29c46d570e8c33d/frontend/components/ChatComponent.tsx#L230
As such, messages in the chat will be displayed with proper line breaks.
With:

Without:

Awesome! Thanks, we'll definitely add it to make the Chat UI look better 🚀

Fixed and merged on the main branch! It will be included in the v0.3.1 release! You can install it by cloning the GitHub repo and using pip install -e . or wait for the release, which should come soon!


Fix DrawingToolWidgetUI menu typography

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.917%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1115

Relevant Lines:
1499

💛  - Coveralls


[gui error report] Error: Initializing daemon...

👉 Please describe what you were doing when this error happened.
Specifications

OS: win32
IPFS Desktop Version: 0.20.5
Electron Version: 18.0.3
Chrome Version: 100.0.4896.75

Error
Error: Initializing daemon...
go-ipfs version: 0.12.2
Repo version: 12
System version: amd64/windows
Golang version: go1.16.15

Error: Your programs version (12) is lower than your repos (13).
Please update ipfs to a version that supports the existing repo, or run
a migration in reverse.

See https://github.com/ipfs/fs-repo-migrations/blob/master/run.md for details.

    at errorTemplate (C:\Users\India\AppData\Local\Programs\IPFS Desktop\resources\app.asar\src\daemon\migration-prompt.js:78:49)
    at Object.loadWindow (C:\Users\India\AppData\Local\Programs\IPFS Desktop\resources\app.asar\src\daemon\migration-prompt.js:115:26)
    at startIpfsWithLogs (C:\Users\India\AppData\Local\Programs\IPFS Desktop\resources\app.asar\src\daemon\daemon.js:163:25)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async module.exports (C:\Users\India\AppData\Local\Programs\IPFS Desktop\resources\app.asar\src\daemon\daemon.js:190:17)
    at async startIpfs (C:\Users\India\AppData\Local\Programs\IPFS Desktop\resources\app.asar\src\daemon\index.js:46:17)
    at async module.exports (C:\Users\India\AppData\Local\Programs\IPFS Deskto

@NINJAind thanks for submitting this issue. It looks like you're trying to use an older version of IPFS-desktop, even though you've already used a later version (or later version of kubo that updated your ipfs repo).
Updating to the latest version of ipfs-desktop (0.26.1) should resolve this issue.


Dependency Injection - Same service type are able to be registered into Service Collection multiple times

Title
Dependency Injection - Same service type are able to be registered into Service Collection multiple times
Functional impact
Multiple instance of the same service type will be instantiated when we call service provider GetServices when the same service type was registered multiple times.
Minimal repro steps
Please refer to this gist
Expected result
I should have only 1 instance of SomeManager since it is the same type.
Actual result
service will contain 2 instances of SomeManager.

What makes you think you get more than one instance? It should only use the last registration.
Also, there's a mechanic for resolving IEnumerable<SomeManager> to get all possible instances.

Ah, I just realized you were calling GetServices and not GetService. If you call GetService you get the last instance. GetServices returns all instances.

If returning multiple instances of the same type is the correct behaviour, are there any reason to allow multiple registration for the same type?

Here's an example:
https://github.com/aspnet/Hosting/blob/3b488c470a0612382d7ca85bac2678a44c5c7ae4/src/Microsoft.AspNetCore.Hosting/Internal/HostedServiceExecutor.cs#L18
All instances of IHostedService are resolved and each are executed. This allows you augment functionality by adding another instance without replacing all prior functionality.

I think it's the fact that he registered the same implementation type multiple times and expected it would be filtering out those dupes.  IHostedService is a good example of why it doesn't do such filtering, there are times where you might want to instantiate the same class multiple times (I've done this before, I believe, each one was an additional consumer/processor of a task queue).

I see... So this is not an issue then.
Thanks for explaining.


client side drafts not being updated with server sent drafts after update

This might cause the two to diverge

Drafts are no more!


python3Packages.rich: 12.4.1 -> 12.4.4

Description of changes
https://github.com/Textualize/rich/releases
Same as https://github.com/NixOS/nixpkgs/pull/174350 but targeting master.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@jonringer It is? Oh, then I misunderstood what staging is meant for. I thought it was for the upcoming 22.05 release. If it's going into master as well, I'll just await that.

This can still be merged into staging-next thought, please see https://github.com/NixOS/nixpkgs/pull/174515#issuecomment-1140785050

This change is already in staging-next: https://github.com/NixOS/nixpkgs/pull/174350, so I'll just keep this PR closed.


fix: Make additional documents optional in Sell flow

Resolves https://www.notion.so/artsy/App-upload-of-documents-is-mandatory-in-the-app-but-should-not-be-446a60bc8b3c499baed53489572f478f?pvs=4
Description
This makes adding additional documents optional in the new Sell flow.
PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Make additional documents optional in Sell flow (behind ff) - ole

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (Make additional documents optional in Sell flow (behind ff) - ole)

  Generated by :no_entry_sign: dangerJS against 6868c775099321f253fc86666b90d8fb51b54632


use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)

I'm not sure I understand the TravisCI build failure here... don't see an obvious error in its raw build log.
@michaelbukachi @muarachmann @awasum given your work over in #550, do you see what's going on here?

@vorburger absolutely. I see what is ongoing i too switched to mysql-connector which worked but due to the license stuff and legal stuff jdbc had to be patched somehow. If the LEGAL stuff can be handle by the legal team as you mentioned on JIRA it would be cool

@vorburger reference to the drizzle driver is thrown quite a number of places beyond build.gradle. I found it in xml and .java files. Had to do quite a bit of find and replace to get rid of it completely.

I see what is ongoing i too switched to mysql-connector which worked but due to the license stuff and legal stuff jdbc had to be patched somehow.

If you have the time, I'd love to learn more and hear details... don't see an obvious error in its raw build log - if you do, and can point to (copy/paste) it, and how you think it can be solved, that would be very interesting.

If the LEGAL stuff can be handle by the legal team as you mentioned on JIRA it would be cool

I think in https://issues.apache.org/jira/browse/LEGAL-462 we are converging on that it's OK to use the the MariaDB.org (not Oracle's MySQL) Connector/J JDBC driver instead of Drizzle at build time for Flyway, so let's assume that's a Go and get this PR to pass?
Alternatively you could also pick up your work in #550 if you want to rebase it on my rebased #525. But I think it may be easier to do this as two completely separate steps - let us FIRST have a PR, this or one from you, which ONLY switches to use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761), but does not do the Gradle etc. upgrade, yet. Once that works, let us then rebase #525 and finish that off. Sounds like a plan? Can you help with the first step?

@vorburger reference to the drizzle driver is thrown quite a number of places beyond build.gradle. I found it in xml and .java files. Had to do quite a bit of find and replace to get rid of it completely.

Careful - my understanding of the legal situation is that it IS OK to switch to use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver during build for Flyway, but that we do not want do, have to or legally easily can find and replace to get rid of it completely elsewhere. Having this mix should be fine, I think.

If it's okay to go ahead with it. I could take a look at your code later tonight and try to solve failing builds.

I'm not sure I understand the TravisCI build failure here... don't see an obvious error

I've had a quick closer look, and wonder if these may just be red herring false hits?!  Neither of these problems have anything at all to do with this PR...
... the first time, in Build #162, it seems to have failed in the license test build step just due to Could not GET 'https://jcenter.bintray.com/junit/junit/4.12/junit-4.12.jar'. Received status code 504 from server: Gateway Time-out.  The second time (after I added the amended README to this PR), in Build #167 it fails early when it tries to set the mysql password; watch FINERACT-763.
@michaelbukachi I'm curious if this PR locally builds fine for you? (Using all steps from the .travis.yml).

Voilà, build is green now!
@awasum @angelboxes @muarachmann @vishwasbabu plz review and merge this? Tx!

Awesome stuff! This is truly a breakthrough!

@vorburger : Thinking back, we could probably have simply removed all the flyway tasks from gradle. I am not sure if anybody was actually using them (the gradle tasks for  migrating DB's listed in the readme are not really required as flyway would run anyway on application startup)

@vorburger : Thinking back, we could probably have simply removed all the flyway tasks from gradle. I am not sure if anybody was actually using them (the gradle tasks for migrating DB's listed in the readme are not really required as flyway would run anyway on application startup)

https://issues.apache.org/jira/browse/FINERACT-765


replace td valign attribute by a css vertical-align

valign has been deprecated since html 4.0: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/td#attr-valign
Note: create-react-app settings (in dev mode, so not really an issue) is complaining about it:

Thanks!


ceph info broken

Distribution: ubuntu
Distribution version: xenial

Issue description
I'll probably get told this is an upstream issue or so but i'll stick it here anyway:
root@research1:~# /snap/bin/lxc storage info homepool2
info:
  description: ""
  driver: dir
  name: homepool2
  space used: 477.77GB
  total space: 1.95TB
used by:
  containers:
  - iesnextcloud
  - importexport
  - juju-33b9f4-0-lxd-11
  - juju-33b9f4-0-lxd-7
  - juju-33b9f4-0-lxd-8
  - juju-33b9f4-0-lxd-9
  - jupyter
  - license4jcontainer
  - meteoritewww
  - moodle
  - nexus2
  - norwichb2b
  - norwichdata
  - saiku4
  - saikucommunitywww

root@research1:~# /snap/bin/lxc storage info lxd-pool1
Error: Invalid value: 10.9TiGB

the former being a dirpool and the latter my ceph pool
Running:
root@research1:~# ceph df
GLOBAL:
    SIZE        AVAIL       RAW USED     %RAW USED
    10.9TiB     10.6TiB       346GiB          3.09
POOLS:
    NAME                ID     USED       %USED     MAX AVAIL     OBJECTS
    xfs-pool            1      202MiB         0       3.34TiB          66
    ext4-pool           2          0B         0       3.34TiB           0
    lxd-pool            3          0B         0       3.34TiB           0
    container-pool      4          0B         0       3.34TiB           0
    container-pool2     5          0B         0       3.34TiB           0
    lxd-pool1           6      114GiB      3.23       3.34TiB       29747
root@research1:~#

Suggests that LXC is looking up the Total size not the pool size, and a) freaking out because its in Terabytes and b) looking at the wrong number because surely it wants lxd-pool1's size?
root@research1:~# ceph --version
ceph version 12.2.8 (ae699615bac534ea496ee965ac6192cb7e0e07c0) luminous (stable)

Moving over to LXD, I'll take a look into this, also if that's an error happening on all CEPH pools, then it means we're clearly missing a test :)


[AvatarGroup] Add a prop for configuring the overlap

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
Here's a mockup from the PR:

There should be some way to specify which direction the AvatarGroup overlaps/cascades its items.
Examples 🌈
Other Implementations
This component is on react-ui-roundup if looking at other implementations is helpful:

Motivation 🔦
I am working with a design that utilizes AvatarGroup, but the design requires the groups to cascade above each other, rather than below.  It seems reasonable to me that a prop for this should exist to configure this.

In my opinion, I would wait for upvotes 👍. This is something that can be implemented in userland with theme overrides with just few lines of code. So far, we didn't have request for this, so I am not sure if many developers would benefit from this.

@mnajdova As far as my testing shows, this is not possible to implement in userland.  I tried to do that at first and hit a blocking problem.  The issue is that the current implementation uses flexDirection: 'row-reverse' with a dom structure like this:
{ the "+<number>" total avatar }

...{ the array of the rest of the avatars }

That is to say, in the DOM, the total one comes first even though in the end it shows up last (because we reverse the flow direction).  This complexity is hidden from the end-user since there's no way with CSS (or mui's API for AvatarGroup) to change this order.  And, you'd need to change the order if you want to flip it from row-reverse to row, which is how you would change the order they cascade (in the DOM).
See the implementation in the PR for how this problem is solved: https://github.com/mui-org/material-ui/pull/30619/files#diff-f09ec952e7f62b25fc9d49e19d60447aba55213cb07fc45f71f22d92c03f1136R166
If you have some way that this could possibly done in with the theme overrides, I'd appreciate seeing it.  Apologies in advance if I've missed something obvious.

Ah, thanks for pointing out I haven't noticed that the rendered children are changed too. Alright, I am adding the waiting for 👍 label.

@dimitropoulos You can specify this snippet to the theme as a workaround.
<ThemeProvider
  theme={createTheme({
    components: {
      MuiAvatarGroup: {
        styleOverrides: {
          root: ({ ownerState: { max } }) => ({
            ...[...Array(max)].reduce(
              (result, curr, index) => ({
                ...result,
                [`& > .MuiAvatar-root:nth-child(${index + 1})`]: {
                  zIndex: max - index
                }
              }),
              {}
            )
          })
        }
      }
    }
  })}
>

https://codesandbox.io/s/groupavatars-material-demo-forked-vcfufi?file=/demo.tsx

the design requires the groups to cascade above each other, rather than below.

Why?

The number is hard to read if it's more than one digit.
It gets cut off with MUI's current approach:

I was able to achieve a reverse overlapping order in <AvatarGroup/> by changing each <Avatar/>'s z-index property within its sx property. Here's an example:
<S_AvatarGroup max={5}>
    {imagesUrl?.map((imgUrl, index) => (
      <Avatar key={imgUrl} sx={{ zIndex: index }}>
        <ProductImage src={imgUrl} ... />
      </Avatar>
    ))}
</S_AvatarGroup>

Note that <S_AvatarGroup> is a Stitches' styled component that I used to change the spacing based on the avatar size:
const S_AvatarGroup = styled(AvatarGroup, {
  $$avatarSize: '20vmin',

  [`&.${avatarGroupClasses.root} .${avatarClasses.root}`]: {
    border: 'none',
    marginLeft: 'calc($$avatarSize * -0.38)',
    height: '$$avatarSize',
    width: '$$avatarSize',
  },
})

Result

that's helpful, but (correct me if I'm wrong) that means you'd also need to first reverse the array, right?

Hi, @dimitropoulos
By "reverse overlapping order" I meant "the groups to cascade above each other, rather than below" as you asked. Since z-index: 0 is assigned to the first avatar and z-index: [array.length] to the last one, the later becomes the above them all. This workaround has no need to reverse the array, acting as your requested "cascade: above".

and come to think of it, it seems like it's best to now close this issue.  I welcome people to continue to comment their solutions here (if they find them) but it seems clear the MUI team is not interested in adding this feature directly (which, I don't agree with, but I respect their decision -> there's A LOT of decisions like this that have to be made to maintain something as great as MUI).
Many thanks to the MUI team for doing such a good job with this project.  No hard feelings :)

@dimitropoulos Have you check Joy UI https://mui.com/joy-ui/react-avatar/#overlapping-order? flexDirection: row-reverse does the trick.

no, I hadn't, but that's great to see.  I'd love if that same thing were in material, as well.

It could help
type CustomAvatarGroupProps = {
  overlapInversed?: boolean;
};

const CustomAvatarGroup = styled(AvatarGroup, {
  shouldForwardProp: (prop) => prop !== 'overlapInversed',
})<CustomAvatarGroupProps>(({ max, children, overlapInversed }) => {
  if (!overlapInversed) {
    return {};
  }
  const length = max ?? Children.toArray(children).length;

  return [...Array(length)].reduce((result, _curr, index) => {
    result[
      `& > .MuiAvatar-root:nth-child(${index + 1}) /* emotion-disable-server-rendering-unsafe-selector-warning-please-do-not-use-this-the-warning-exists-for-a-reason */`
    ] = {
      zIndex: (length ?? Children.toArray(children).length) - index,
    };
    return result;
  }, {});
});


Version 0.1.0

What's Changed
Added

get_or_create method by @MAD-py in https://github.com/aminalaee/mongox/pull/23
Avoid Meta class from Model definition by @aminalaee in https://github.com/aminalaee/mongox/pull/25
Fix bulk update return by @MAD-py in https://github.com/aminalaee/mongox/pull/29

Internal

Fixed autouse fixtures by @kuutsav in https://github.com/aminalaee/mongox/pull/26

New Contributors

@MAD-py made their first contribution in https://github.com/aminalaee/mongox/pull/21
@kuutsav made their first contribution in https://github.com/aminalaee/mongox/pull/26

Full Changelog: https://github.com/aminalaee/mongox/compare/0.0.3...0.1.0

Hey,
Wouldn't it be better to wait for this #25 ?

Oh yeah, sorry I forgot to update the description. I'm waiting for #25 and #27

I think we can do the release now and add the additional features later.


Training

Did you convert your positive images to grayscale before training, or did you use the coloured images

Hey @JustineUgo, as far as I concerned about this project, @AdityaPai2398 has done a great job and he used grayscale before training instead of directly using coloured images as referred to #L22


Improve plot_paired_histogram

Proposed changes:

Rename plot_histogram to plot_paired_histogram, add tests, and fix an issue with a missing bar in the chart
Closes https://github.com/RasaHQ/rasa/issues/7912

Status (please check what you already did):

[x] added some tests for the functionality
updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

@JEM-Mosig Terribly sorry, I forgot about this. Somehow our slack reminder for pending reviews is not working and I completely missed this. I'll make sure to review this tomorrow.

@JEM-Mosig Terribly sorry, I forgot about this. Somehow our slack reminder for pending reviews is not working and I completely missed this. I'll make sure to review this tomorrow.

No worries.

@dakshvar22 Can you please review again?


Authentication Error

after sorting everything out i still get "Authentication Error"
please help

:arrow_up:

Try to fill in the COOKIE_DATA correctly, in the video ( https://www.youtube.com/watch?v=RqaJkuTz_5g ) it was named "cookie" but in my browser the correct name was "set-cookie"
example of how it should be: https://github.com/sumeetweb/Thinki-Downloader/issues/30#issuecomment-1320869246


Support setting secret namespace in a host

Description
Currently it is only possible to use a secret within a Host if that secret shares the same namespace as the Host. While originally this was a design decision, we've seen users experiencing friction due to this restriction. These changes will allow you to use secrets from any namespace within a Host like so:
tlsSecret:
  name: tls-cert
  namespace: foobar # new field!

Related Issues
List related issues.
Testing
Manual tests and added some test cases to the existing Host tests.
Checklist

[x] I made sure to update CHANGELOG.md.
Remember, the CHANGELOG needs to mention:

Any new features
Any changes to our included version of Envoy
Any non-backward-compatible changes
Any deprecations

[x] This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:

Any significant changes in memory use that might require adjusting the memory limits
Any significant changes in CPU use that might require adjusting the CPU limits
Anything that might change how many replicas users should use
Changes that impact data-plane latency/scalability

[x] My change is adequately tested.
Remember when considering testing:

Your change needs to be specifically covered by tests.

Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.

You also need to make sure that the entire area being changed has adequate test coverage.

If existing tests don't actually cover the entire area being changed, add tests.
This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!

We should lean on the bulk of code being covered by unit tests, but...
... an end-to-end test should cover the integration points

[ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

[ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Don't we need to target this at 2.x?

Don't we need to target this at 2.x?

It sure does. Since we don't want 3.x to be missing any features this PR will target master and once any Feedback is taken care of I'll just cherry pick the commits over to 2.x
Why did I target 3.x first instead of 2.x? No clue :woman_shrugging:

I said on a call once that I'd add an env-var to make this opt-in. But since it was already possible with a TLSContext, as I think about it more I'm not sure I stand by that. But if we eventually drop TLSContext, it'd be good if things could be locked down. So IDK.


ssh-honeypot creates hundreds of forks, consuming all memory

Hi. I’ve been using ssh-honeypot for a few weeks now, and i noticed that the server has a very concerning ram usage. This server is a firewall, and only uses iptables (kernel-space) and ssh-honeypot. Here’s my monitoring graph for the last 7 days:

The drops in memory consumption are when i restart the ssh-honeypot service (using openrc). Right now, there’s 425 honeypot processes running.
Why is ssh-honeypot behaving like this, and what can be done to prevent crashing my server every 2 days if i don’t stop manually the service?

I faced the same issue. After a bit of debugging and digging into the source code, I found that in the handle_ssh_auth() function, the call to ssh_handle_key_exchange() further calls ssh_handle_packets_termination() to handle packets, which is blocking and uses an infinite timeout by default. And if the authentication is interrupted midway before the polling starts, the subprocess blocks infinitely, causing a memory (and process number) leak.
So the solution is to set a valid timeout for the allocated session. In the main() function, below session = ssh_new ();, add:
long timeout = 5; // set default timeout to 5s
ssh_options_set(session, SSH_OPTIONS_TIMEOUT, (void *)(&timeout));

And that should fix this issue (at least it works for me).

Hi. Would it be possible to integrate this patch? The project doesn’t seem active anymore. @jorgeverastegui is your fork intented to be a take-over?

added.


Add support for SAMV71 series targets

This PR adds support for SAMV71 series devices. The target file has been automatically generated using the target-gen utility.

Similarly to #1860, I can update the changelog with this feature as soon as the other PR gets merged.

Thanks a lot!
We're trying a new way to handle the changelog, since there were loads of merge conflicts with everybody editing CHANGELOG.md.
The idea is that you can now create a file in changelogs/, e.g. fixed-very-annoying-bug.md, describing the changes in the PR and the actual changelog will be generated at release time.
See https://github.com/probe-rs/probe-rs/blob/master/CONTRIBUTING.md#changelog-entries

I've added the changelog entry in the appropriate format and fixed the CI builds. Everything should be ready now.


add no-lane-splitting param

Changelog
Add support for 'no_lane_splitting' for bcl_convert
Checklist before requesting a review

[x] I have performed a self-review of my code

[x] Conforms to the Contributor's guide

Check the correct box. Does this PR contain:

[ ] Breaking changes
[x] New functionality
[ ] Major changes
[ ] Minor changes
[ ] Documentation
[ ] Bug fixes

[x] Proposed changes are described in the CHANGELOG.md

[x] CI tests succeed!

Could you add a CHANGELOG?

Never mind the CHANGELOG, just saw it ^^


chore: upgrade dependencies

Coverage remained the same at 97.898% when pulling 5f8c9c1cf0eecf191ccfe17201f4d7247f0d7428 on upgrade-dependencies into 9ffa826252f3119769d9f536ac7a42f93689da10 on master.


[BUG] exo fails to parse unquoted integers from docker compose files

Describe the bug
When running exo run or exo apply on a docker-compose.yml file containing environment variables whose values aren't explicitly quoted strings, it throws an error:
Error: applying manifest: parsing: expected values to be string, got 1
applying manifest: parsing: expected values to be string, got 1

Here are two compose files where this issue was encountered:

https://gist.github.com/catleeball/5ff10090b22b32b22e0d3d7ed3674d2d
https://github.com/restic/rest-server/blob/master/examples/compose-with-grafana/docker-compose.yml

This is similar to https://github.com/deref/exo/issues/279, figured I'd open this in a separate bug in case it's helpful for tracking.

To Reproduce
Steps to reproduce the behavior:

Have a docker-compose.yml file
Set an environment variable a value such as 1 without quotes
Run exo run or exo apply
See error

Expected behavior
Exo runs the docker-compose.yml file as docker-compose would, having parsed the integer as a string despite not having quotes.

System Info (please complete the following information):

OS: Ubuntu 21.04 (linux 5.11)
Component: cli
Version: 2021.08.31

Additional context
Thanks for your hard work on Exo!

Thank you very much for the reports! There are open PRs for each of them now, which we'll try and merge soon. :)


Unexpected Reference Error, when working with Coroutines.

Code to reproduce
type Coroutine[A] {
    Done()
    More(f: A => Coroutine[A] at {})
}

def createCoroutine(): Coroutine[String] = {
    var cr = Done();
    cr = More(
            fun(s:String){
                    Done()
                }
            )
    cr
}

def work{cr: => Coroutine[String]} = {
    var coroutine = cr();
    ()
}

def main() = {
    work{createCoroutine()}
}

Expected Output
Nothing. Should terminate.
Actual Output
const coroutine = $this.fresh(tmp378);
ReferenceError: $this is not defined

The compiled work function, where the undefined this lives.
function work(cr) {
    return cr().then(((tmp378) =>
        (() =>
            {
                const coroutine = $this.fresh(tmp378);

                return $effekt.pure($effekt.unit);
            })()));
}

Is this a compiler error, or am I doing something wrong?

I do not know why. But changing the work function to this:
def work(cr: Coroutine[String]) = {
    var coroutine = Done();
    coroutine = cr
}

"solves" the bug.

Looks like a problem where the region for mutable state is inferred incorrectly.  Here is the core representation:
def createCoroutine() =
  region { (this) =>
    let tmp476 = Done()

    var cr in this = tmp476 ;
    let _ = cr.put(More((box { (s) =>
      Done()
    })));
    let tmp477 = cr.get()

    tmp477
  };
def work(cr) =
  val tmp482 = cr();
  var coroutine in this = tmp482 ;
  ();
def main() = work({ () =>  createCoroutine() })

We can see that indeed a region { (this) => ... } is missing around the body of work.

As a more reasonable workaround, you should be able to provide the region explicitly:
def work{cr: => Coroutine[String]} = region this {
    var coroutine in this = cr();
    ()
}

The bug is related to this function (I guess):
https://github.com/effekt-lang/effekt/blob/master/effekt/shared/src/main/scala/effekt/source/ExplicitRegions.scala#L29

Eventually in #235 we might solve this bug since we change how local mutable state is represented. @matthias-dunkel  could you maybe try to checkout #235 and see what the output is? That would be helpful.

I tried it on #235. It still is not working, and here is the output:
function work(cr) {
    const tmp369 = cr;

    const coroutine = $this.fresh(tmp369);

    return $effekt.pure(cr);
}

This will also reproduce the error:
def main()={
 var i = 1;
 ()
}

Ha, ok thanks. That solves it ;) Then it is a problem with capture inference. Since you do not use i it is not registered to be required and the region is not introduced.

It is a bit strange since here we say that we need the region:
https://github.com/effekt-lang/effekt/blob/master/effekt/shared/src/main/scala/effekt/Typer.scala#L702

@matthias-dunkel I just tried to reproduce your reported error, but it just works for me on master and on naive-state. Can you help me reproduce it somehow? What are the exact steps I have to take?

I am closing this issue since it seems to work on master. If you encounter it again, feel free to reopen.


Allow authentication when LM hash is empty

It would be great to allow authentication when the -hashes parameter only contains the NT hash such as :8846f7eaee8fb117ad06bdd830b7586c.
This PR implements a simple fix that checks whether the LM hash is empty, and in that case, it replaces it with the LM hash of the empty string.
A note on ldap3: we can basically use an arbitrary 32-character long string for this hash since it does not use it anyway as long as it has the proper length. From ldap3:
def ntowf_v2(self):
    passparts = self._password.split(':')
    if len(passparts) == 2 and len(passparts[0]) == 32 and len(passparts[1]) == 32:    # <-- STILL NEEDS A 32-CHARACTER LONG LM VALUE TO USE THE NT HASH
        # The specified password is an LM:NTLM hash
        password_digest = binascii.unhexlify(passparts[1])    # <-- ONLY USES NT HASH ANYWAY
    else:
        try:
            password_digest = hashlib.new('MD4', self._password.encode('utf-16-le')).digest()
        except ValueError as e:
            try:
                from Crypto.Hash import MD4  # try with the Crypto library if present
                password_digest = MD4.new(self._password.encode('utf-16-le')).digest()
            except ImportError:
                raise e  # raise original exception

    return hmac.new(password_digest, (self.user_name.upper() + self.user_domain).encode('utf-16-le'), digestmod=hashlib.md5).digest()

If the length is different from 32 bytes however, it will compute the NT hash of the string provided and therefore will try to authenticate with wrong credentials.

hey, appreciate the contribution. However, PRs must be signed to be merged, so you would either have to commit it on GitHub or set PGP signing on your account and sign it locally.

thanks!


IoStatus.Information should not be set on cleanup/close. Appears to b…

IoStatus.Information should not be set on cleanup/close. Appears to be copy and paste from Create code.

I’m AFI ATM, BUT I’ll observe that NTFS does set information in the CLEANUP path under circumstances I forget..
Also it’s probably a good idea to zero out information anyway.
(Ps. Hi Jeff!)

Hi Rod!
Setting it to zero sounds good.
I'm quite interested in the notion that NTFS would set it to something purposeful.  If this is indeed a field to be set then there is a separate documentation bug for the IRP_MJ_CLEANUP page.  Fwiw, the CDFS sample doesn't appear to set it to anything (other than zeroing it on error in CdCompleteRequest).  The WRK (admittedly super old) doesn't appear to even check the status, much less the information, on IRP_MJ_CLEANUP.

I closed this PR unintentionally.  I apologize. I am reopening the PR.

I closed this PR unintentionally.  I apologize. I am reopening the PR.


Implementation with NextJS

React Boilerplate
Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.
Please direct redux-saga related questions to stack overflow:
http://stackoverflow.com/questions/tagged/redux-saga
For questions related to the boilerplate itself, you can also find answers on our gitter chat:
https://gitter.im/mxstbr/react-boilerplate
Before opening a new issue, you may find an answer in already closed issues:
https://github.com/react-boilerplate/react-boilerplate/issues?q=is%3Aissue+is%3Aclosed
Issue Type

[x] Feature (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#feature-requests)
[ ] Bug (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#bug-reports)

Description
Is there any simple way to implement nextjs into the react-boilerplate?
(Add images if possible)
Steps to reproduce
(Add link to a demo on https://jsfiddle.net or similar if possible)
Versions

React-Boilerplate (see package.json):
Node/NPM:
Browser:

@justingreenberg why this issue close?

RBP and next.js are apples and oranges—there is no possible integration path
next.js is an opinionated framework designed for server rendering... it has it's own conventions, it's own build system, and is designed to run as a production server with streaming, hydration, etc


[Excel] (snippet) use more appropriate type of loop

Fixes https://github.com/OfficeDev/office-js-docs-pr/issues/1690
Fixes 1690

Docs Build status updates of commit d572f03:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit d572f03:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-worksheets.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Test the current state of the app

The app has been stripped of all related SciWiNet code and successfully compiles and loads on an emulator. It needs to be tested on a device to see if it still receives location updates correctly.

Awesome! So I can compile this using the Android SDK and test the debug.apk file on my device?

Yep! Theoretically. However you won't see any output without an application that can view logcat. I'm planning on testing this today, so I'll also push new code that has more interesting output that you can test.

Awesome. Thanks Adam
On May 22, 2015 9:53 AM, "Adam Hodges"<EMAIL_ADDRESS>wrote:

Yep! Theoretically. However you won't see any output without an
application that can view logcat. I'm planning on testing this today, so
I'll also push new code that has more interesting output that you can test.
—
Reply to this email directly or view it on GitHub
https://github.com/codeforgreenville/trolley-tracker-agent/issues/1#issuecomment-104666046
.

The app collects location pretty well for the most part. There are a couple kinks with reliability that will have to be worked out before it's 'trolley ready'. Mainly with making sure the service is started when the phone runs and doesn't shut off if the phone goes in a low power state or something.

Are we ready for a possible permanent device then?
On May 25, 2015 9:45 PM, "Adam Hodges"<EMAIL_ADDRESS>wrote:

The app collects location pretty well for the most part. There are a
couple kinks with reliability that will have to be worked out before it's
'trolley ready'. Mainly with making sure the service is started when the
phone runs and doesn't shut off if the phone goes in a low power state or
something.
—
Reply to this email directly or view it on GitHub
https://github.com/codeforgreenville/trolley-tracker-agent/issues/1#issuecomment-105351492
.

We can certainly start shopping around!

Do you expect we will need to root it? There is a Galaxy S3 on Craigslist
right now for $120 that will work with my T-Mobile plan, however Samsung's
are a pain to root.
On May 26, 2015 9:59 AM, "Adam Hodges"<EMAIL_ADDRESS>wrote:

We can certainly start shopping around!
—
Reply to this email directly or view it on GitHub
https://github.com/codeforgreenville/trolley-tracker-agent/issues/1#issuecomment-105534400
.

Depends on how fancy we want to get with it (with a rooted phone we could do something fancy like make it turn on and off when the trolley is/isn't running). I think a rootable phone is a good option to go with. I personally have had bad experiences with older samsung GPS's, too.
I recommend taking a look at the Moto E's, which have more recent hardware than the S3 and can be had brand new for ~$100 or used for ~$60 (there are two generations, the 2nd gen might be a touch pricer but is more recent). If we got the GSM version it will work on both T-Mobile and AT&T.


Fix test case for https://github.com/ruby-git/ruby-git/issues/587

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Ensure all commits include DCO sign-off.
[x] Ensure that your contributions pass unit testing.
[x] Ensure that your contributions contain documentation if applicable.

Description
Fix test case by extracting init.defaultBranch into variable
https://github.com/ruby-git/ruby-git/issues/587

This code does not work when init.defaultBranch is not set (see the failed CI builds for this PR).
In this case, you see the following:
$ irb
2.7.6 :001 > `git config --get init.defaultBranch`
 => ""
2.7.6 :002 > $?
 => #<Process::Status: pid 54561 exit 1>
2.7.6 :003 >

I think you could get away with adding this line:
initial_branch = 'master' if initial_branch.empty?

See the docs for git init --initial-branch for more context.

yes, thanks for reminding me 🙏
I reproduced by removing   defaultBranch = main in my ~/.gitconfig and changed the test case as your suggestion
I also did some commit cleanup(cherry-pick and force pushed)

also suggest rename test_git_init to test_git_init_with_default_init_default_branch


Support for right to left languages

🚀 Feature request
Motivation
I've just started experimenting with this library a few days and I love the way it is implemented, the focus on a11y and the unstyled approach 👏 .  But unfortunately support for rtl languages (say arabic) is missing.
Example
When setting dir="rtl" on an element, then actions on children elements should invert the concept of left right (NB: I'm not a rtl user).
// initial focus on Button 1. pressing left arrow will now shift focus to button 2.
<div dir="rtl">
  <Group>
      <Rover {...rover} as={Button}>
        Button 1
      </Rover>
      <Rover {...rover} as={Button}>
        Button 2
      </Rover>
      <Rover {...rover} as={Button}>
        Button 3
      </Rover>
    </Group>
</div>

Possible implementations
I guess the direct association between right and next needs to be dependent on nearest element with an explicit direction stated (defaulting to ltr).
I noticed a similar issue at https://github.com/reach/reach-ui/issues/235
Thanks

Hi @MortenHofft! Thanks for raising this issue.
I have zero experience with RTL. There are plans to replace rover.next() and rover.previous() by rover.right() and rover.left() though. Would it solve this problem? What about rover.first() and rover.last()?
That said, you can also set the initial focus to the last element (although it will remain the last element):
  const rover = useRoverState({ currentId: "last" });
  <Rover {...rover} as={Button}>
    Button 1
  </Rover>
  <Rover {...rover} as={Button} disabled>
    Button 2
  </Rover>
  <Rover {...rover} as={Button} disabled focusable>
    Button 3
  </Rover>
  <Rover {...rover} as={Button}>
    Button 4
  </Rover>
  <Rover {...rover} as={Button} stopId="last">
    Button 5
  </Rover>

I would think that first and last would work just the same (pageUp and pageDown). It is simply that moving focus right when pressing left is odd.
instead of ArrowRight: options.orientation !== "vertical" && options.next in https://github.com/reakit/reakit/blob/master/packages/reakit/src/Rover/Rover.ts#L113 I would think it needs to evaluate the (current) direction of the target before deciding wether right means next or previous.
ArrowRight: options.orientation !== "vertical" && (e => {
  getComputedStyle(e.target).direction === 'rtl' ? options.previous() : options.next()
})

Another way to do it would be to do the check for RTL inside of previous and next so that it doesn't need to be calculated everywhere.

As of v1.0.0-rc.0, useTabState(), useMenuState(), useToolbarState() and useRadioState() support a boolean rtl state.
We can discuss how to detect it automatically in a performant way in the future if needed, but for now I think we can close this.


[FD] Solve gamemode_fd conflicts to catch up with main

Catch up PR so gamemode_fd branch can stay on sync with main.

Only latest commit basically, the rest is really the catch up as if you synced forks, problem is just json conflict.

Did it manually


Support for UNC / Network paths

When using New-KeePassDatabaseConfiguration with a UNC path such as -DatabasePath "\\domain.local\users\username\My Documents\KeePass\database.kdbx it results in:
New-KeePassDatabaseConfiguration : Cannot validate argument on parameter 'DatabasePath'. The "Test-Path $_" validation script for the argument with value "\\domain.local\users\username\My Documents\KeePass\database.kdbx" did not return a result of True.

Nevermind, I'm dumb. The database has to exist first lol


Does not support character other than ascii?

This is an interesting library. I was going to use it in my project but found it would raise a "UnicodeDecodeError" since my yaml config file contains Chinese characters. I wondered whether I have done the right way or the library does not support utf-8 file?

@tcqiuyu can you post the full python error stack trace?

This is my test script
import configargparse
# This is a test script
p = configargparse.ArgParser(default_config_files=['conf/test.yaml'])
p.parse_args()

This is a test yaml
###############################################################################
# Flask服务配置模板
###############################################################################

test: hello_world

And this is the error trace message
Traceback (most recent call last):
  File "/Users/Qiu/anaconda3/envs/corrector/lib/python3.6/site-packages/IPython/core/interactiveshell.py", line 3296, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-27-6c490a6c61cd>", line 1, in <module>
    p.parse_args()
  File "/Users/Qiu/anaconda3/envs/corrector/lib/python3.6/site-packages/configargparse.py", line 377, in parse_args
    env_vars = env_vars)
  File "/Users/Qiu/anaconda3/envs/corrector/lib/python3.6/site-packages/configargparse.py", line 486, in parse_known_args
    config_items = self._config_file_parser.parse(stream)
  File "/Users/Qiu/anaconda3/envs/corrector/lib/python3.6/site-packages/configargparse.py", line 146, in parse
    for i, line in enumerate(stream):
  File "/Users/Qiu/anaconda3/envs/corrector/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe6 in position 87: ordinal not in range(128)

I'm unable to reproduce this error.
I copied your example (and added p.add_argument("--test") so that it would parse test: hello_world from the config file).
It ran without error on MacOSX in python2.7, python3.6 and ipython3.

That is weird 😵. I tried again just now and it works fine. The issue can be closed. Thanks for your clarifying.

Be sure your editor is setup correct to write utf-8 file conf/test.yaml, not other. May be your previous file was not saved using uft-8


Model attribute Validation Rules: weird behavior for int and integer

Disclaimer:

I'm well aware that this might be a waterline issue, but I have only tested this behavior by setting attributes in my Sails models that have those validation rules attached to them.
I've encountered some weird behavior with the int and integer validation rules, which presumably should behave the same.
In Anchor (see rules.js#L67-L68), the same validation rules seem to be used for both:
....
'int'        :  validator.isInt,
'integer'	 :  validator.isInt,
....

So one would assume it should have the exact same behavior. But here are some validation results (non-exhaustive list):
int rejects everything that is not clearly an int and stores it as string
 1      VALID     =>   '1'
 1.0    VALID     =>   '1'
'1.0'   INVALID
 1.1    INVALID
'4/2'   INVALID

integer is very liberal in what an integer is, even floors values and then stores them as 'number`
 1      VALID     =>   1
 1.0    VALID     =>   1
'1.0'   VALID     =>   1
 1.1    VALID     =>   1
'4/2'   VALID     =>   4

I am currently too busy to shed more light on this but I thought it might be useful to at least document my observations.

This was an odd one, and might have had to do with anchor treating "int" and "integer" differently, but since a) that's definitely not the case now and b) only "integer" is referenced in the Sails and Waterline docs, not "int", I think we can lay this to rest.


the whole page gets deleted while undo-ing

When we create a new page and then draw a rectangle in it. Then if you undo it with ctrl+z, it removes the whole page that was created.

@ashutosh2014 fix it asap.

Hi @HusainAmir, Thanks for reporting the issue, the issue is fixed now, and you will receive in 1.09 update.


Not throwing error when DC is misconfigured with InclPC == 1

The specs stated in section 2.1.4 "Device-context configuration checks" that:

A DC with DC.tc.V=1 is considered as misconfigured if any of the following conditions are true. If misconfigured then, stop and report "DDT entry misconfigured" (cause = 259).

If any bits or encodings that are reserved for future standard use are set.

Here is the counter-example of the violation of specs, in the 8th cycle when InclPc ==1, dc.tc.pdtv == 1, and pdtp.mode == 10 which is a reserved number so it should give an error due to using that reserved number and cause_code should be "DDT entry misconfigured" but RTL is not giving any error which is wrong.

Fixed in #24.


how to run documents4j server

Hello, I have downloaded the source code of this project and it has been packaged and generated。But with  "java -jar documents4j-server-standalone-shaded.jar http://localhost:9998",i can't run.
can you help me, thanks a lot.

You're not supposed to use the sources jar but the executable binary.

how can i get  the executable binary?  Sorry, I've been working on it all day

For example from Maven Central: https://search.maven.org/artifact/com.documents4j/documents4j-server-standalone/1.1.1/jar

Hello, I found a syntax error in the documentation sample code,You need to remove the semicolon


Zummer Bot

In this tutorial we build a Search and Summary Bot - Zummer using Microsoft Cognitive Services - Bing Web Search API, Language Understanding Intelligent Services (LUIS)

@mohammed-moussa,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


Use csp_nonce() from spatie/laravel-csp if available

When using spatie/laravel-csp or a CSP policy that uses nonce, genealabs/laravel-caffeine does not work. This change uses the csp_nonce() function from spatie/laravel-csp to generate the value and generates a nonce attribute to the script tag.
Probably not the most elegant or portable solution but it is what I could come up with to make it work for me. I am open to suggestions on what else to do in order to achieve this. I thought of adding a new configuration variable that triggers the nonce attribute and uses the configuration variable's value as the nonce value.

@user00265 Thanks for submitting this! Sorry it took so long for me to address it. It is included in release 0.8.3.


Determine required IAM permissions

Howdy,
So something I've been thinking about recently is a good way to estimate the IAM permissions that a given application would need in order to function, Doing code analysis seems super difficult, and would be language-specific.
Is this something that would make sense to extend from moto_server, or roll into it?
I have been looking through the code a little bit, but I am generally not familiar with moto, it just seemed to me that there might be a way to have moto_server track which actions are taken, have an understanding of the permissions required to do that thing, and then provide a report, or even a generated policy document that would make all of those actions possible against real AWS endpoints.
Does that seem plausible? Any hints on the best place to start? Am I a crazy person?

Okay, cool, thanks for the feedback. I'll start poking around and see what I come up with.


18 style new page

New and Help pages styled

Buttons styled and positioned
Title centered
Help text changed - Keys values are now capitalized, text repositioned
Style sheet added
New page refactored
setGameState function added
removeButtons function added

Awesome.  Thanks I really wasn't looking forward to this... so sweet.


Define and Expose a CDS-Based Travel Data Model

Tutorial URL: https://developers.sap.com/tutorials/abap-environment-data-model.html
Please specify the step you are referring to
Step # 2: Create projection view for travel
Under 5. it says "Define root view entity for ZC_TRAVEL_M_XXX."

But this doesn't really fit with what I see when I click "Finish" under 4. Instead I see this (s.th. comparable happened in Step # 1)

"6. Your result should look like this. Replace your code with following:" therefore doesn't really fit.
I can still replace the code with what is shown below that and it can be activated, but I always find it confusing if what I see in the system doesn't fit the instructions - esp. as I don't really know the details of what I'm doing. The rest of the steps in the tutorial worked as described.
Not sure if it's related, but when I worked on Step 1 of this tutorial and reached the "Finish" step to pick the transport request, I got this error message (which I grabbed the screenshot of but otherwise ignored):

I'm using this version of Eclipse/ADT 2019-09 R (4.13.0)
Is the update of the client installation actually required? If yes, than it might cause some issues as it's usually not possible for me to update Eclipse directly on my company laptop.
Thanks much and Cheers
Bärbel

Hi @BaerbelW ,
you need to specify your data source (database table) and try it out again.
Best regards,
Merve

Hi Merve,
thanks for your quick reply. Just not really sure what you mean as everything did work and I did get the app preview displayed. So, there's nothing technically wrong from what I can tell. It was just confusing to me, that I didn't really know what you wanted me to do with these instructions:

What I saw on my end after clicking "Finish" looked quite different as shown in my OP.
Cheers
Bärbel

Hi @BaerbelW ,
the first instruction (5.) is the definition of the root view. The second picture describes how the complete result looks like (if you want to compare your projection view, with the one from the tutorial).
I hope it is clear now.
Best regards,
Merve

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


SSH connection via SSH proxy command defined in ~/.ssh/config

Hi, there;
What I'm trying to do with RF is to remotely ssh to a server via a ssh proxy server using public/private key.
machine-c  ------------> machine-p  ------------> machine-t
(ssh client)                   (ssh proxy)                  (target server)
From a ssh client machine-c, a ssh connection is first made to a ssh proxy machine-p then additional ssh connection to a target server machine-t. The ssh proxy is defined in ~/.ssh/config as below in client machine-c;
Host machine-p
Hostname <IP_ADDRESS>
Host machine-t.example.com
ProxyCommand ssh machine-p nc  machine-t.example.com
On Linux CLI, giving  "ssh machine-t.example.com" takes me into machine-t successfully without asking password. And the log message in /var/log/secure at machine-t.example.com shows that a ssh connection came from ssh proxy machine-p.
However, if I do the same ssh connection request using Robotframework ssh library, it looks like it is not reading ~/.ssh/config and establishes connection directly to target machine-t. The log in /var/log/secure at machine-t.example.com tells me that it is from machine-c not from machine-p. Is this expected RF behavior or am I missing something?
I'm using Python 2.6, paramiko-1.9.0 and Robotframework 2.9.1 with SSH library 2.1.1.
Would appreciate your response on this.
Joon.

This issue tracker is for Robot Framework itself. Please submit SSHLibrary issues to its own tracker.


Shares : mkdir does not work

When executing:
ascli shares files mkdir /xxx/yyy

It fails: Path not found

This is a bug, and there was no test case for this...

Can I get aspera-cli as a fixed version for this issue?

Fixed in 4.18.1

Please verify, and close the ticket


date formating for different locales return name of months and days in small instead of camel case

The formatting for the names of days and months are in small alphabet instead of camel strings, as it is in English language.
moment.locale('sv')
moment().format('MMMM') // returns juni
moment().format('dddd)  // return onsdag
moment.locale('en')
moment().format('MMMM') // returns June
moment().format('dddd)  // return Wednesday
It should be consistent in my opinion.
/Sanjay

This is the choice of the person who wrote the locale file. Different cultures have different rules for the casing of dates. If you are able to, for a specific locale, provide us with a native speaker who believes the casing should be different, we are willing to take pull requests for changes. In general though, every culture does things differently, so there is no way to consistently case anything in the locale files.

Hej maggie,
Fair enough, thanks for the explanation.


Bug in load hyq when trying to display in GV

In GitLab by @nmansard on Feb 18, 2019, 11:16
I have a bug when trying to display HyQ in Gepetto Viewer, when using the loadHyQ macros. The error message is below. I am on the branch quadruped-example.
The bug is indeed coming from the path that contains symbolic elements. The DAE plugin is apparently to de-reference them. It is working when removing the symbolic part.
Currently, I by-passed the problem with a hard-coded link on my implementation. We should fix the bug properly.

In GitLab by @nmansard on Feb 18, 2019, 11:16
Load failed in COLLADA DOM
Load failed in COLLADA DOM conversion
Warning: Error in reading to "/home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description/meshes/leg/hipassembly.dae".
File: /home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description/meshes/leg/hipassembly.dae could not be loaded
You may try to convert the file with the following command:
osgconv /home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description/meshes/leg/hipassembly.dae /home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description/meshes/leg/hipassembly.dae.osgb
File /home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description/meshes/leg/hipassembly.dae found but could not be opened. Check that a plugin exist.
Error: Failed to open file:/home/nmansard/src/crocoddyl/examples/examples/hyq_description/meshes/leg/upperleg.dae in daeLIBXMLPlugin::readFromFile

Error: Failed to load file:/home/nmansard/src/crocoddyl/examples/examples/hyq_description/meshes/leg/upperleg.dae

In GitLab by @cmastalli on Feb 18, 2019, 12:56
You need to create by hand *.dae.osgb files. I don't remember exactly how to do it. @nim65s can explain you

In GitLab by @cmastalli on Feb 18, 2019, 12:58
@nim65s do you know the reason why this is happening?

In GitLab by @nim65s on Feb 18, 2019, 14:08
I don't know why this is happening, maybe @jmirabel can help. I workaround the issue in @cmastalli case by following the logs, with something like:
apt install openscenegraph  # for osgconv binary
cd /home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description
for mesh in **/*.dae; do osgconv $mesh $mesh.osgb; done

In GitLab by @jmirabel on Feb 19, 2019, 15:25
No idea why symbolic links do not work. It might be because I never tried myself :) (although I think I did)
Does osgviewer /home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description/meshes/leg/hipassembly.dae work ?

In GitLab by @cmastalli on Feb 19, 2019, 16:37
@jmirabel  it was working for me something similar (i.e. osgviewer ./examples/hyq_description/meshes/leg/lowerleg.dae).

In GitLab by @nmansard on Feb 19, 2019, 20:08
osgviewer does not accept symlink neither.

osgviewer /home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description/meshes/leg/hipassembly.dae
Error: Failed to open file:/home/nmansard/src/crocoddyl/examples/examples/hyq_description/meshes/leg/hipassembly.dae in daeLIBXMLPlugin::readFromFile
Error: Failed to load file:/home/nmansard/src/crocoddyl/examples/examples/hyq_description/meshes/leg/hipassembly.dae
Load failed in COLLADA DOM
Load failed in COLLADA DOM conversion
Warning: Error in reading to "/home/nmansard/src/crocoddyl/examples/crocoddyl/../examples/hyq_description/meshes/leg/hipassembly.dae".
osgviewer: No data loaded

In GitLab by @nmansard on Feb 19, 2019, 20:09
@cmastalli could you take care of this bug please? The solution is "simply" to make the path of the HyQ model not depending on any symlink.

In GitLab by @cmastalli on Feb 20, 2019, 09:21
I created a repository for all URDF data. I suppose to have a first release (through robotpkg) this afternoon. After that, I will create a PR where crocoddyl/robot.py parses the data only from there. This should solve this issue too. I created an issue here #118, and WIP PR here !107.

In GitLab by @nmansard on Feb 21, 2019, 17:19
Yes, that is nice. But please patch this error before.

In GitLab by @cmastalli on Feb 23, 2019, 10:13
@nmansard hyq_description is a submodule inside crocoddyl. This PR !107 will fix this bug.

In GitLab by @nmansard on Feb 28, 2019, 11:28
MR !107 cannot be merged before https://gepgitlab.laas.fr/gepetto/example-robot-data/issues/1 . We should either have a very nearby date for solving https://gepgitlab.laas.fr/gepetto/example-robot-data/issues/1 or provide a patch before.

In GitLab by @cmastalli on Mar 7, 2019, 08:45
I will close this issue since we are ready to merge !107. Feel free to open it.

In GitLab by @cmastalli on Mar 7, 2019, 08:45
closed


Fix broken productName values

This (should be) a very minimally invasive PR.
The background:
In general, Xcode appears to behave very badly when using workspaces and its "Find Implicit Dependencies" feature in the scheme editor. Many folks throw up their hands and resort to manual dependency specifications.
Well I think that its terrible behavior can be attributed to a bug in Xcode that causes it to not update the productName value in the .pbxproj file when a target is renamed. This happens very commonly when creating a framework project, then duplicating the framework targets with suffixes for other platforms.
For some folks, this patch may improve their build experience in Xcode quite a bit—especially for follks like me with very large workspaces that involve a lot of subprojects.
Sorry it took so long to write this one up after making the branch—I hadn't verified that the fix actually worked until I hit the issue again today, and fixing the productName value resolved my dependency issue. I'll try and cook up a Radar for this now that I know the steps.

Will wait on the outcome of ReactiveCocoa/ReactiveCocoa#3470 to decide whether to merge this—thanks!


how to create action field "update, remove, other link" field?

I would like to create action field update, remove, other link for multi tabular table.
// Tabular
{
     title: 'Action',
     tmpl: Meteor.isClient && Template.tabularAction
}

// Template
<template name="tabularAction">

        <button type="button" class="btn btn-link dropdown-toggle" data-toggle="dropdown" aria-expanded="false">

        </button>

Update

Remove

</template>

I don't want create the duplicate templates for multi tabular, so i want to pass any data from tabular table like router name, other value....
pl help me.

The template is rendered with the row data as context. Can you get the info you need from there?

Sorry i don't understand. so i must to create tmpl: Meteor.isClient && Template.tabularAction for one tabular table ???

I'm saying if you use the same cell template in multiple tables, you can probably attach extra properties to the row context to be able to find out more about which table it is.
If it's only the collection reference that you need, then I guess there could be a TabularTable option that tells it to pass the collection in the cell template data context.

how to attach extra properties to tmp: Tabula...?

I may not be understanding what you're doing. Please provide a link to a reproduction or MeteorPad that shows what you are trying to do and what issue you are having.


Reduce direct memory OOM chances on broker with a per server query response size budget

When server responds for a query with a large response, the broker can potentially crash with direct memory OOM.
In PR https://github.com/apache/pinot/pull/11496 - a fix was added to restart the Netty Channel in such scenarios. This will result in all active queries failing with an error. This is a good fix to have to protect Brokers in this extreme case.
However, to reduce the probability of such events happening and contain the impact for other queries, this PR introduces a threshold at the Server. If the serialized query response at a Server exceeds the threshold, the query is failed.  The overall threshold for a query is set using a config. This budget is divided across all Servers processing the query.
cc: @siddharthteotia @jasperjiaguo  @gortiz @ege-st @dinoocch

I've added some notes, but I think the PR is in good shape

Codecov Report

Merging #11710 (445ab73) into master (54a1ca0) will decrease coverage by 48.62%.
The diff coverage is 36.11%.

@@              Coverage Diff              @@
##             master   #11710       +/-   ##
=============================================
- Coverage     63.05%   14.43%   -48.62%
+ Complexity     1118      201      -917
=============================================
  Files          2342     2342
  Lines        125787   125819       +32
  Branches      19335    19341        +6
=============================================
- Hits          79314    18166    -61148
- Misses        40813   106114    +65301
+ Partials       5660     1539     -4121

Flag
Coverage Δ

integration
?

integration1
?

integration2
?

java-11
?

java-17
14.42% <36.11%> (-48.49%)
:arrow_down:

java-20
14.43% <36.11%> (-48.49%)
:arrow_down:

temurin
14.43% <36.11%> (-48.62%)
:arrow_down:

unittests
14.43% <36.11%> (-48.62%)
:arrow_down:

unittests1
?

unittests2
14.43% <36.11%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...va/org/apache/pinot/spi/utils/CommonConstants.java
0.00% <ø> (-28.00%)
:arrow_down:

...e/pinot/common/utils/config/QueryOptionsUtils.java
0.00% <0.00%> (-68.75%)
:arrow_down:

...roker/requesthandler/BaseBrokerRequestHandler.java
46.66% <65.00%> (+0.27%)
:arrow_up:

...che/pinot/core/query/scheduler/QueryScheduler.java
0.00% <0.00%> (-71.43%)
:arrow_down:

... and 1508 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Cool, thanks! I think reducing the likelyhood of DM OOMs is the logical next step.
How will a user determine what the threshold should be? A critical requirement for a feature like this is to introduce it such that it does suddenly start breaking queries that were working before the threshold was enabled; so, a guide on how to determine what the threshold should be is, I think, critical for safe adoption.

How will a user determine what the threshold should be?

@ege-st
Good question. We did think about this. The ideal answer is that the value is use case dependent.
However, a safe starting point is to set the threshold limit to max direct memory size  - this value is conservative to not break existing queries and at the same time, it reduces the probability of brokering OOMing. For the usecase that we saw in our production environment, this value works.
Also note that this setting is disabled by default in this PR. It can be enabled on a case-by-case basis.

I am still not convinced of how we have wired the config aspect.
At a high level, I suggest we do the same thing as timeOut config since that is exactly what we seem to be doing here with an instance level config and then a query level config (in the form of query option) IIUC. So may be should also leverage queryConfig at the table level as well and have the preference as:
queryOption (query level) > table level > instance level
Also this may be a nit but the following 2 configs in CommonConstants is not super intuitive to me.
public static final long DEFAULT_MAX_QUERY_RESPONSE_SIZE_BYTES = Long.MAX_VALUE;
public static final String MAX_SERVER_RESPONSE_SIZE_BYTES = "maxServerResponseSizeBytes";
One problem I see is that while (1) is an instance config but tells for the query and therefore we internally compute the per server threshold / budget during routing depending on how many servers we are routing to.
However, (2) seems to be the queryOption way of doing things but here we are having the user directly specify the server level budget instead of overall. Why this difference ?

@siddharthteotia Added tableConfig and overriding sequence.
The reasoning behind adding a broker level instance config was - the broker ultimately should decide how much response size it should get for each query (depending on it's direct memory limits). If this broker instance config is set, we use that to set the query option to limit response size.
I'm open to suggestions if the broker instance config doesn't make sense.

I understand the intention of tracking broker side total memory usage, but evenly splitting it into server side memory limit might cause inconsistent behavior because the actually limit relies on the fanout, and it assumes evenly distribution of the results from each server.
Since the direct control is size limit per server, we should at least allow configuring it directly. If it is not configured, we can fall back to broker total memory limit.

@Jackie-Jiang got it. Based on the suggestions, I've added a server side limit in the table config. Would you prefer that we add an instance config for the server in addition to the table config?

@vvivekiyer I'm thinking 2 configs - perServer & perQuery. Both of them can be set in 3 places: query option > table config > broker instance config (per server one can also be configured on broker). perServer takes precedence, and if not configured, fall back to perQuery. So overall the fallback order should be perServer query option > perQuery query option > perServer table config > perQuery table config > perServer instance config > perQuery instance config
We need some documentation to clear document how these 2 configs are used

@Jackie-Jiang  added perServer and perQuery configs. Please take a look.

@vvivekiyer Have you added these configs to the pinot doc?


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=411925561
https://github.com/Azure/azure-cli-extensions/commit/89518d001832c619a2dad79b73892ed05e2dce01

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Deterministic compilation for Regent

Making this a pull request to track test status.
Fixes #334.
@magnatelee We still need you to update the parallelizer.

Commit b4552b9 fixes the crash in the parallelizer.


Improve DataConflictException handling in case of partial local modification

In the case where only some of the records in a patch are skipped by ConditionallyPutRecords, maxPatchSyncCount will not cause the dataset sync count to be reset sufficiently to correct the skipped records when they experience a DataConflictException on future sync attempts.  (Especially likely if multiple records are always updated together.)
Another possibility for this might be to have ConditionallyPutRecords return a flag for whether it skipped any records, and if it did, to not update the dataset sync count in the DataConflictException handler.
Attempts to address issue #391

PR merged, thanks for the contribution.


chore(TDI-37693): move dataprep to components-ee

Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Related to https://jira.talendforge.org/browse/TDI-37693
Duplicates https://github.com/Talend/components/pull/330,
but includes also latest PR, which were merged recently

Pull request test result: success :star:


Where are the logs??

fixed here https://github.com/CounterpartyXCP/counterparty-core/pull/1485


Unable to Validate CycloneDX Format Versions 1.5 and 1.6 with ModelCard and Data Elements

The latest release of the CycloneDX CLI tool is unable to validate SBOMs conforming to CycloneDX format versions 1.5 and 1.6 that include the modelCard and data elements. These versions of the format introduce new features and structures, such as the modelCard and data elements, which are not being properly recognized or validated by the CLI tool.
The validation fails even though the SBOM adheres to the CycloneDX specification
Link to the CycloneDX 1.5 modelCard
Link to the CycloneDX 1.5 data
Link to the CycloneDX 1.6 modelCard
Link to the CycloneDX 1.6 data

@cbsMartin Can you please provide a sample BOM that fails validation? (All that the cli does internally is to validate the json file against the corresponding json schema; thus, I'm a bit surprised if this is indeed the case.) What kind of validation messages do you get? (In particular, there are also tests that validate for instance valid-machine-learning-1.6.json.)


I am having issues getting my fork of this repo going.

I was wondering if anyone had any tips for getting the project up and running. I am looking to contribute some frontend to this project but I've run into troubles.
Here's my error
Error: Cannot find module './secrets.nogit.json'
So far I've

node v12
installed yarn
installed now
yarn install
installed gcloud

it looks like I still have to set up

env.dev.nogit.js
secrets.nogit.json

I am not sure how to set up the above steps. Any tips would be greatly appreciated. Thanks!

Hello Andrew,
The sample of these files can be found within the same folder env, they are secrets.sample.json and env.dev.sample.js respectively.
env.dev.nogit.js is a development JavaScript version of the secrets.nogit.json, and you can see all keys/values for the file at secrets.sample.json
By the way, on GOOGLE_APPLICATION_CREDENTIALS be sure to point to a valid .json file inside packages/server/secrets, otherwise the server is not going to run, and the process is going to throw due to the lack of valid env variables.
On the project's README you can see the explanation and how to behind these env variables, however if you face any other issue just let me know.

Ah I see. Okay, so it looking for env.dev.nogit.js so I just duplicated env.dev.sample.js and renamed it env.dev.nogit.js


Symbols / Source code not showing in MinGW 64 application

I have tried to debug a minGW 64 (7.3.0) application to have an idea where memory is more allocated but for some reason the source code does not show up:

I compiled the application with minGW and debug symbols activated (DWARF information), using the flags (qmake):
QMAKE_CXXFLAGS += -gdwarf-2
CONFIG += force_debug_info
This works correctly for VTune, but for MTuner for some reason does not seem to work.
I have also setup the MinGW toolchain and it looks like this:

I am not sure what I am missing or doing wrong.
Can you give some help, most of the issues here are for VC++ so not helpful for minGW.
P.S. I am using a release executable (-O2), MTuner version is 4.3.5, the MinGW toolchain is the one that comes with Qt 5.12.3.

+1. Does any version of MTuner work with MinGW and what compiler flags need to be set for showing source code?

I'll check this problem these days, quite busy with my regular job.

Took me a while but I see the problem which is a design flaw. I assume you are drag & dropping executables to MTuner or running them from project manager? If this is the case then a profile DLL is injected and this DLL was compiled with MSVC so the toolchain saved in the capture file is wrongly saved as MSVC and debug symbol resolver doesn't work.
The real solution to this problem would be to detect the type of executable being profiled by inspecting PE header or something. I'll take a look at what would be an easy way for this.

I assume you are drag & dropping executables to MTuner or running them from project manager?

Yes that's how I am doing it.

And I too. Even without source code - it's a great instrument. I learned a lot about my program). I am looking forward for update with source code inspection.

I'll try to fix this over the next weekend. It's more involved than I thought - right now a single toolchain is assumed for all modules on Windows, which is obviously wrong as exe could be compiled with MinGW while DLLs could be built with MSVC. So I want to rewrite this part a bit so the symbols can be loaded regardless of how the module was compiled... a bit of patience please, quite swarmed with other work.

Just submitted the fix. Debug symbols are now handled/loaded per module, which allows .exe and .dll files to be resolved using appropriate toolchain for each module. Tested with a MinGW compiled binary and I could see symbols both from it and from system DLLs (which were compiled with MSVC) in a call stack. I'll post a new release later today.

That is great! Let us know once you release it. I will test it ASAP.

Uploaded, it's 4.3.7. Just tested with a mix of binaries (MSVC/MinGW) and it worked fine. Let me know if you find other issues. Cheers!

I tried the version 4.3.9 but something is not right:

Toolchain is configured as in the first post.

Just tested with an old capture, and got the same error. The reason is wrongly parsed output in case of a missing original executable. Is this the case for you as well?

Should be fixed in v4.4.0

@milostosic
I tried the 4.4.0 but the issue is still present.

Do you mind trying 4.4.1? If the problem persists, please tell me how you capture the profile as I cannot reproduce it locally.

Still doesn't work. How did you compiled your test application? Did you used -gdwarf-2?
For the capture I just go to projects then I click in "run", then I terminate the application normally to analyse the results.

For the binutils path I am using:
D:/Qt512x64/Tools/mingw730_64/bin

My test was compiled with '-g'. I will try to make a test with -gdwarf-2 and see if there is any difference in terms of addr2line output.

Odd I tried with just -g but it does not matter same issue. :/

My guess is that the addr2line output format is different and that parsing is incorrect, I'll need to try the same version of compiler that you use in order to check this.

I just tried with x86_64-7.3.0-release-win32-sjlj-rt_v5-rev0.7z and everything is working fine. I'll try to install Qt512 so the toolchain I use is identical to yours but help me out here - can you think of anything else that could make yours and mine configurations different?

Which exact version of Qt/MinGW did you install? There's a number of sub versions: http://download.qt.io/archive/qt/5.12/

I used Qt 5.12.3 x64.

Ok, I've just tested with MinGW 7.4 included with Qt 5.12.3 and everything works fine.
I can only assume something is incorrectly setup on your PC.
You can send over a minimal repro case so I can take a look, otherwise I'm closing this issue.

MinGW should be 7.3 with that version.
Can you tell how you did configure the toolchain?
Mine looks like this:

Enviroment variable: MINGW64
Binutils path: D:/Qt512x64/Tools/mingw730_64/bin
Toolchain prefix: (I left empty)
Minimum reproducible project (in my scenario):
cpp_tests.zip

Yes, it was 7.3, I made a typo. Here's my setup, I use TDM-GCC:

I don't use Qt creator so if you can generate a makefile with this .pro project please send that over.

Makefile:
Makefile.zip
Btw I do not have the environment variable "MINGW64" setup in the system. Can be that the problem?

I'll try this in the morning, time to sleep here. MINGW64 not being set in the system is not a problem.

From your makefile:
-Wl,-s -Wl,-subsystem,console -mthreads
Debug symbols are explicitly removed.

I removed the -s argument (which I was not aware of), but the problem remains.
It must be something else, I completely discard the compilation with make file and now I am compiling it directly like this:
D:/Qt512x64/Tools/mingw730_64/bin/g++ -g main.cpp -o app.exe
But I get the same issue when I try MTuner.

Check if you actually have debug symbols:
objdump --syms app.exe
Anyway, I've wasted too much time on this already but whatever I tried it always worked fine: different MinGW versions, different build process, etc. Unless someone can provide an actual repro case I will not be looking into it further.

I checked with objdump and the symbols are in the executable.
I will leave the executable here anyway, if somebody wants to test:
app.zip
@anna-prog81 Is it working for you already?

I tested your executable with 4.4.1 - working fine:

I tested my application with 4.4.1. Compiled with '-g'. Now I can see source code lines, but only in my executable, not dlls. A lot of "Unknown", "fake" entries.  I see all my dlls in Modules window, filtering by modules works. MinGW 4.4 +Qt 4.8.5,  MinGW 4.9.2 + Qt 5.6.3.

Ok, I'll take another look at this...

I feel bad resurfacing this closed issue, but I just can't seem to get it to work on my end.
I tried with multiple mingw versions, different compiler settings, nothing works. I even tried to convert it to .pdb and stripping the exe of debug symbols.
Here's my exe (will close upon hitting "cancel"):
cmake-build-debug.zip
cmake-build-release.zip
cmake-build-relwithdebinfo.zip


User info redaction in logs

what's the state of this PR?

what's the state of this PR?

I am working on fixing test issues.


fd.BatteryPercentage undefined (type *tello.FlightData has no field or method BatteryPercentage, but does have tello.batteryPercentage)

Neither "fd.BatteryPercentage" nor "fd.batteryPercentage" can be successfully built.

As warned in the README: "This app may use an in-development version of the Gobot package. Any released versions should build with a contemporary release of Gobot."
Between released versions (there isn't one just yet) you will probably have to build against the DEV branch of Gobot.
I will try to do a release just as soon as an update containing the latest Tello updates is made by the Gobot team.


Get current exchange rate for a particular product

Is there any method available to get the current exchange rate for a particular product (say "ETH-USD') ?

You can check the README for such things -
get_product_ticker
Get the product ticker for a specific product.
public_client.get_product_ticker(product_id='ETH-USD')

If you're using an OrderBook, you can also use OrderBook.get_current_ticker().


Report Issue does not work on Debian 9.5, KDE Plasma desktop - some extension seems to be the cause

VSCode Version: 1.28.2, installed from Apt repos on Debian 9.5 amd64
OS Version: Debian 9.5 amd64, KDE Plasma desktop

Steps to Reproduce:

Ironically, selecting Help | Report Issue results in empty issue report window:

Does this issue occur when all extensions are disabled?: No
Extension list:
AkashGutha.greetings
alanz.vscode-hie-server
alefragnani.Bookmarks
brainfit.vscode-importmagic
BriteSnow.vscode-toggle-quotes
DavidAnson.vscode-markdownlint
donjayamanne.githistory
eamodio.gitlens
formulahendry.code-runner
Gruntfuggly.todo-tree
hoovercj.haskell-linter
humao.rest-client
justusadam.language-haskell
kenhowardpdx.vscode-gist
konstantin.wrapSelection
lukasz-wronski.ftp-sync
mkloubert.vscode-deploy-reloaded
ms-python.python
ms-vscode.cpptools
naturallucky.googlesearch
qezhu.gitlink
qinjia.seti-icons
qinjia.view-in-browser
red-auto.red
ryu1kn.edit-with-shell
Shan.code-settings-sync
shardulm94.trailing-spaces
sidneys1.gitconfig
stkb.rewrap
truman.autocomplate-shell
tushortz.python-extended-snippets
Tyriar.sort-lines
wmaurer.vscode-jumpy
wwm.better-align
Yummygum.city-lights-icon-vsc
yzhang.markdown-all-in-one

@mrkafk Can you hit Ctrl+Shift+I while focused on the issue reporter window to bring up the dev tools, and see if there is anything in the console?

Actually, nevermind, I have a repro now. Installing mkloubert.vscode-deploy-reloaded did it for me.


Strange buffer hex post signature

Hello there,
First off, absolutely amazing project. I am trying to compare the output of the library to something like eth_account for python and Web3. I found this strange offset f842a0 after signing a simple message. The full source code is given in the screenshot below. Notice I am using the private key as was given in the Examples section of the docs.

The above code, seems to return the following signature:
f842a0
40911813bd523b3dbc83f5eb06d024fb43d09609068842dba37c53527fabc33e
a0
3ec391e743b820de01600842f7b23af1b19786e5778766f7e94798bfe500807a
With input keccak hash being:
85f11dc9d9ca7c444897e464dcc1bf1b936931cba10fe3b7b4e58b516a6851a8
What I find relatively interesting is that doing the exact same operation using eth_account, one yields the following signature;
0x40911813bd523b3dbc83f5eb06d024fb43d09609068842dba37c53527fabc33e
3ec391e743b820de01600842f7b23af1b19786e5778766f7e94798bfe500807a
1c
Notice how there are two intermediate hex strings within the signatures (f842a0 and a0). I am not quite sure where these are originating from.

Hello @woywoy123 I'm glad you liked the project.
Please, give me some time to investigate this thing. Also, It would be great if you sent me the code, not a screenshot :) Thank you!

Hello there,
First off, absolutely amazing project. I am trying to compare the output of the library to something like eth_account for python and Web3. I found this strange offset f842a0 after signing a simple message. The full source code is given in the screenshot below. Notice I am using the private key as was given in the Examples section of the docs.

The above code, seems to return the following signature:
f842a0 40911813bd523b3dbc83f5eb06d024fb43d09609068842dba37c53527fabc33e a0 3ec391e743b820de01600842f7b23af1b19786e5778766f7e94798bfe500807a
With input keccak hash being: 85f11dc9d9ca7c444897e464dcc1bf1b936931cba10fe3b7b4e58b516a6851a8
What I find relatively interesting is that doing the exact same operation using eth_account, one yields the following signature;
0x40911813bd523b3dbc83f5eb06d024fb43d09609068842dba37c53527fabc33e 3ec391e743b820de01600842f7b23af1b19786e5778766f7e94798bfe500807a 1c
Notice how there are two intermediate hex strings within the signatures (f842a0 and a0). I am not quite sure where these are originating from.

bro can u provide full code sample please?

@DerXanRam @mhw0
Apologies for the delay, here is a minimal example as shown in the screenshot =)
void ExampleSignature()
{
    uint8_t privkey[] = {
                            0xdf, 0x57, 0x08, 0x9f, 0xeb, 0xba, 0xcf, 0x7b,
                            0xa0, 0xbc, 0x22, 0x7d, 0xaf, 0xbf, 0xfa, 0x9f,
                            0xc0, 0x8a, 0x93, 0xfd, 0xc6, 0x8e, 0x1e, 0x42,
                            0x41, 0x1a, 0x14, 0xef, 0xcf, 0x23, 0x65, 0x6e
    };

    uint8_t test_[1] = {0x04};

    uint8_t keccak[32];
    uint8_t keccak_eth[32];

    std::stringstream ss;
    eth_keccak256(keccak, reinterpret_cast<uint8_t*>(&test_), 1);
    for (uint8_t x : keccak){ss << std::hex << std::setfill('0') << std::setw(2) << (int)x;}
    std::cout << ss.str() << std::endl;

    ss.str("");
    eth_keccak256p(keccak_eth, keccak, 32);
    for (uint8_t x : keccak_eth){ss << std::hex << std::setfill('0') << std::setw(2) << (int)x;}
    std::cout << ss.str() << std::endl;

    eth_ecdsa_signature sign_data;
    eth_ecdsa_sign(&sign_data, privkey, keccak_eth);

    uint8_t* r = sign_data.r;
    uint8_t* s = sign_data.s;

    ss.str("");
    for (unsigned int u(0); u < 32; ++u){ss << std::hex << (int)r[u];}
    std::cout << ss.str() << std::endl;

    ss.str("");
    for (unsigned int u(0); u < 32; ++u){ss << std::hex << (int)s[u];}
    std::cout << ss.str() << std::endl;
}

Also another thing that caught my attention was the chainid when one uses it for v. It seems that eth_account yields a different result, not sure why this is. In my usecase, I just subtract 28 - sign_data.v, which seems to be somewhat consistent with what they have.

Also another thing that caught my attention was the chainid when one uses it for v. It seems that eth_account yields a different result, not sure why this is. In my usecase, I just subtract 28 - sign_data.v, which seems to be somewhat consistent with what they have.

sorry i don't understand what u say. And using the abov code my result is little bit different. the output is
f343681465b9efe82c933c3e8748c70cb8aa06539c361de20f72eac04e766393
85f11dc9d9ca7c444897e464dcc1bf1b936931cba10fe3b7b4e58b516a6851a8
40911813bd523b3dbc83f5eb6d024fb43d096968842dba37c53527fabc33e
3ec391e743b820de160842f7b23af1b19786e5778766f7e94798bfe50807a

Apologies for the very delayed response, I have been rather busy. I have created a simple example of what  I am suggesting to be inconsistent:
`from eth_account.messages import encode_defunct
from eth_account import Account
from uuid import uuid1, UUID
from web3 import Web3, utils
import hashlib
import requests
import binascii
signer = Account.from_key(wallet_private_key)
addr = binascii.a2b_hex(wallet_address[2:])
for i in range(1000):
x = uuid1()
para = [
(4).to_bytes(),
x.bytes,
addr,
'IDEX-USDC'.encode(),
(0).to_bytes(),
(1).to_bytes(),
'1.00000000'.encode(),
(1).to_bytes(),
''.encode(),
''.encode(),
''.encode(),
(0).to_bytes(),
(0).to_bytes(),
(0).to_bytes(8)
]
# 64 -> 8*6
d = Web3.keccak(b"".join(para)).hex()
sig = signer.sign_message(encode_defunct(hexstr = d))
print(sig.v)
print(sig.signature.hex())
sig = sig.signature
`
If you insert the same UUID into the above, you may notice that the signature produced by eth_account is slightly different than what is being generated with libethc. Specifically, "v" is the issue.


Tuesday - who's working on what

Chris - working on referencing all Tables and Figures.
Andy - want to read through some of the main text first, but will wait until Chris is done. So will check the placement of figures and tables in exec summary as that text is pretty finalised.

Aaron - fixing forecast table per Ian, Andy, Owen and Aaron input over the last day - almost done; then going through Owen's comments pertaining to main text (already incorporated exec summary comments); then double checking US fishery text in 1.3.1 and 1.4.1 US section.
Just to note, I'll send along Owen's comments to all after today.  There were several though provoking ones that didn't/couldn't be addressed by today or even this year, but good to note.  I though I would make an 2018 milestone issue for some, but later this week or even after SRG

Ian - reading through the United States subset of "1.4.1 Overview of the fisheries in 2016" and watching issues for areas where my help is needed.

I'm just reviewing things... getting to the point of fixing very minor things just becasue (we are close)

closing this one... but let's aim to have a 'finished document' (i.e., no more commits) by 2:30.  We can then all merge and build and compare with a bit of time to spare to send to Miako (I told her 4PM)

Yes, I was hoping to read through more but am running out of steam.

I do have some edits to "1.4.1 Overview of the fisheries in 2016" in the
works but they are text-only and confined to the specific paragraph. I got
caught up in trying to automate a few numbers but will instead just add a
%manual2017 note.
First, however, I have to get out of my merge conflict. Can somebody tell
me how to wipe out my changes and conflicts and just catch up with
everybody?
On Tue, Jan 31, 2017 at 1:00 PM, andrew-edwards<EMAIL_ADDRESS>wrote:

Yes, I was hoping to read through more but am running out of steam.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cgrandin/hake-assessment/issues/250#issuecomment-276490453,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEwvlhrZb8gV0senOWgHsLxnNlpRh1TSks5rX6DqgaJpZM4Ly5fa
.

OK, I think I'm good now, will commit change to introduction.rnw soon.

I'll be away for an hour or so, but will be back for the final Hurrah.

2nd paragraph of U.S. section of "1.4.1 Overview of the fisheries in 2016" revised to provide more detail on age comps in each sector. Aaron, if you have time, you could read through that bit.


[ERP-2514] Fixed all workflows

Fixed all workflows which were continuously failing. Also upload and deploy storybook instead of the app as requested.

Lets rename the file to publish-storybook-pages.yml

Done