Detect taxonomic status

The taxonomic status according to the allowed 5 CoL values can and should be checked against actual data. For clear cases the proposal is to automatically change the status & flag an issue so we can review these. For doubtful cases we only flag an issue.
Rules to determine the status based on the name alone (in part copied from  https://github.com/Sp2000/colplus/issues/38):

Accepted name:
Provisionally accepted name:
Synonym:
does it require an accepted name?
Ambiguous synonym: names which are ambiguous because they point at the current species and one or more others e.g. homonyms, pro-parte synonyms (in other  words, names which appear more than in one place in the Catalogue)
any synonym with more than one accepted name
i.e. pro parte names, but also homonyms with the same canonical name but different authorships
which are treated as separate names in the system
Misapplied name:
Analyze the taxonomic remark of a name to contain one of the following and mark those names as missapplied:

sensu [Author name]
sensu auctorum
sensu auct.
sensu auct. non [Author name]
sensu auct. nec [Author name]
Other dubious cases should be submitted for editorial decision.  (Names with phrases sensu lato, sensu stricto,  sensu […] stricto are not misapplied names.

In the editorial practice with Luisa, CoL has deployed following rules:
Step 1. Detecting identical binomials (trinomials**) among Accepted vs Accepted, Accepted vs Synonyms and Synonyms vs Synonyms.
Then, each class we assess separately.
**) Infraspecific Marker (subsp., var., forma) should be included in analysis for duplicates. If infraspecific markers are different, trinomials are not identical. Example: Trifolium pratense var. pretense and Trifolium pratense subsp. pretense are different names.
Step 2a. Accepted vs Accepted:

2a1. if authorstrings in duplicated names are identical, one record is a candidate for deletion. Needs a consultation with data provider, which record should be deleted. (Ideally, two identical names with identical authorstrings should not appear in the CoL. However, there are very few “hard minders” among data providers who may insist to keep undescribed, provisional species under pre-occupied names).

2a2. if authorstrings in duplicated names are different*, names might be homonyms: if duplicated names are under the same Code, name with later year should be marked as Provisionally Accepted; if duplicated names are under different Codes, both names should be marked as Provisionally Accepted.

Step 2b. Accepted vs Synonyms:

2b1. if authorstrings in duplicated names are identical, one record is a candidate for deletion. Needs a consultation with data provider. If data provider insists to keep both names, a synonym should be marked as Ambiguous Synonym.

2b2. if authorstrings in duplicated names are different*, a synonym should be marked as Ambiguous Synonym.

2b3. There is separate case where synonym is identical to its parent accepted name. Duplicated name in synonyms should be deleted, even if it is marked as nomen nudum.

2b4. Case where binomial/trinomial synonym is identical to its parent accepted name, but authorstrings are different, is not resolved consistently in CoL.

Step 2c. Synonyms vs Synonyms:

2c1. if authorstrings in duplicated names are identical, one record is a candidate for deletion. Needs a consultation with data provider. If data provider insists to keep both names, both synonyms should be marked as Ambiguous Synonym.

2c2. if authorstrings in duplicated names are different*, both synonyms should be marked as Ambiguous Synonym.

*) Only year might be different in authorstrings.
Editorial decision on name status or deletion of name record should be stored in the system and automatically applied with future updates. Newly detected conflicts (2a1, 2b1 & 2c1 ) should be submitted for new editorial decision with next update.

misapplied names and ambigous synonyms are not detected and issues set for derived status or doubtful ones


MMT421 : cassandra version hard coded in the model ?

When trying to launch a model built with previous version using MMT421, I got this error:
2019-11-03 15:09:45,875 ERROR eu.modernmt.cli.ClusterNodeMain [main] Failed to start node
eu.modernmt.engine.BootstrapException: java.io.FileNotFoundException: File '/mnt/SSD/MMT421/modernmt/vendor/cassandra-3.11.4/conf/cassandra.yaml' does not exist
	at eu.modernmt.cluster.cassandra.EmbeddedCassandra.start(EmbeddedCassandra.java:36)
	at eu.modernmt.cluster.ClusterNode.start(ClusterNode.java:363)
	at eu.modernmt.facade.ModernMT.start(ModernMT.java:55)
	at eu.modernmt.cli.ClusterNodeMain.main(ClusterNodeMain.java:182)
Caused by: java.io.FileNotFoundException: File '/mnt/SSD/MMT421/modernmt/vendor/cassandra-3.11.4/conf/cassandra.yaml' does not exist
	at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:299)
	at org.apache.commons.io.FileUtils.lineIterator(FileUtils.java:1856)
	at eu.modernmt.cluster.cassandra.EmbeddedCassandra.createConfig(EmbeddedCassandra.java:131)
	at eu.modernmt.cluster.cassandra.EmbeddedCassandra.start(EmbeddedCassandra.java:73)
	at eu.modernmt.cluster.cassandra.EmbeddedCassandra.start(EmbeddedCassandra.java:32)
	... 3 more
2019-11-03 15:09:45,875 FATAL eu.modernmt.facade.ModernMT [main] Unexpected exception thrown by thread [main]
eu.modernmt.engine.BootstrapException: java.io.FileNotFoundException: File '/mnt/SSD/MMT421/modernmt/vendor/cassandra-3.11.4/conf/cassandra.yaml' does not exist
	at eu.modernmt.cluster.cassandra.EmbeddedCassandra.start(EmbeddedCassandra.java:36)
	at eu.modernmt.cluster.ClusterNode.start(ClusterNode.java:363)
	at eu.modernmt.facade.ModernMT.start(ModernMT.java:55)
	at eu.modernmt.cli.ClusterNodeMain.main(ClusterNodeMain.java:182)
Caused by: java.io.FileNotFoundException: File '/mnt/SSD/MMT421/modernmt/vendor/cassandra-3.11.4/conf/cassandra.yaml' does not exist
	at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:299)
	at org.apache.commons.io.FileUtils.lineIterator(FileUtils.java:1856)
	at eu.modernmt.cluster.cassandra.EmbeddedCassandra.createConfig(EmbeddedCassandra.java:131)
	at eu.modernmt.cluster.cassandra.EmbeddedCassandra.start(EmbeddedCassandra.java:73)
	at eu.modernmt.cluster.cassandra.EmbeddedCassandra.start(EmbeddedCassandra.java:32)
	... 3 more
2019-11-03 15:09:46,049 DEBUG eu.modernmt.cluster.ClusterNode [Thread-1] Cluster node status changed: UPDATED -> SHUTDOWN

MMT421 is installing cassandra 3.11.5. I think the cassandra version is hard coded in the model, right ?
Copying cassandra 3.11.4 folder from the old installation to the new one solve the problem.

In the original post of this issue, I though the cassandra version was hard-coded in my old engine that was requiring an old version of it, but it's only a MMT installation trouble.
I discovered that MMT is reading the cassandra version in the core/pom.xml.
When you are re-installing MMT, and cassandra version needs to be changed (like currently: version 3.11.10 is no more available and needs to be upgraded to version 3.11.11) in the setup.py, you need to also change it in the src/core/pom.xml.
Then update the installation with:
cd src
mvn install


implement a preview function

it would be very helpful to implement a preview function to see what the minimum collateral be after minting certain amount of debt, or more to be more general, after an array of actions.

This should probably lives in a separate View contract to save space


Convert build into submodule

Description of your changes

Looks like the github template doesn't honor git submodules correctly. This removes the build directory and replaces it with a submodule.
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make reviewable

Interesting -- community forum seems to suggest this should be working properly 🤔 https://github.community/t/can-submodules-work-with-template-repositories/124592/3

Looks like CI/check-diff is still failing on this.

Ah nice we also caught the check-diff issue -- looks like related to Go version. Will bump 👍🏻


feat: Add colour contrast checking library

What does this change?
This adds a library to handle this and flag up if something isn't WebAIM accessible with regards to colour contrast.
Why?
In order to be as accessible as possible we should make sure that foreground and background colours are chosen such that they meet WebAIM principles and rules. This includes in things like loggers etc., where we might not normally think to include them.
See also: https://github.com/guardian/libs/pull/42#discussion_r537569717

Would it be worth seeing if we could contribute to one of the existing MDN packages?

I think this is an excellent addition. There are, however, a few other NPM packages that do the same thing. Should we consider contributing to them?

https://github.com/misund/get-contrast-ratio
https://github.com/vinaypillai/ac-colors#colorcontrastratio
https://github.com/johno/get-contrast

Could you please add a README as well?

Added in a README and updated the file name to match the main function.
As for contributing to the existing packages, this sounds like a great idea but I'd also like to stick with using Typescript where possible. Given that none of the linked packages are in Typescript, what would be the best way of going  about contributing to them? There's a reasonable chance that the owners might not want those libraries converting over to Typescript, especially those that are either significantly bigger than this in scope or those that have split their code across multiple packages
More than happy to move this to one of those packages though if it looks like a better idea

thanks for this @buck06191, I can see you've put a lot of time into this.
before going over the code itself, can you provide some insight as to you why you think this ought to be part of libs specifically? (as opposed to a good practise we should make sure we use of, which it most definitely is)
I don't want to overlook the effort that went into this PR, but we need to consider the effort that will also need to go into maintaining it in the future, if we merge it.
do you have a current use case for this? it is something we've reimplemented several times already? i.e is this porting a behaviour we are using in more than one place to a central location for anticipated reuse?
I only ask because while the behaviour is important, adding it here means keeping it up to date, making sure it works with whatever other changes we make to libs as a whole etc, which adds maintenance overhead.
i feel like libs should be toolkit containing things you are very likely to need at least one of per app. every addition makes it harder to look after, thereby making it harder to be useful. if that's a cost worth paying we should pay it, but we should also be careful about adding to the cost if it won't be outweighed by the benefit.
if this is centralising commonly used colour contrast checks then fair enough. but especially when there are other libraries and services that do the same thing, do we (and probably you @buck06191!) want to accept the maintenance role?
e.g. if we created and published types for https://github.com/misund/passes-wcag to http://definitelytyped.org, or by PR to original package, would we get the same result with less overhead – or even shared overhead – going forward?

I don't know if @gtrufitt @SiAdcock have any thoughts on this?

Yes, I agree - I think this is a great utility (I particularly like the check for luminance!), but I can't see this colour contrast being used inside an app directly within our applications so it doesn't make sense published as a standalone script in the libs repo.
Maybe we need a utilities repo of helpful scripts? Or you could publish this as a separate package / contribute some of your ideas to the wcag one and then use it in the tests? Simon might even have thoughts on how it could be integrated with design system work?

@sndrs @gtrufitt Thanks for the feedback above. I'd not thought too much about whether this belonged in libs as a whole before writing it - my main focus was to get a typed library in for the contrast checking. Now that I've had time to think about it, and reading the above, maybe this isn't the right place for it?
My intention was for this to be a useful script that could be integrated into tests to make sure that when we make design changes or implement something like the log library where colour contrast checks like this are necessary. Is there a place for us to put these useful "utility" scripts that might be especially useful in tests? I'm also happy to move to using an existing package but of the ones linked to above they either don't seem to be maintained or are much bigger in scope. Again, happy to look into adding types to one of these instead if that seems a better way of handling this.
It does sound like this addition doesn't belong in this package at least as I'm not sure it's wide enough in scope, but I'll leave this thread open for now to get more feedback

I did another check just now to see if there were any WCAG Typescript options and I found
https://github.com/tmcw/wcag-contrast
https://www.npmjs.com/package/@types/wcag-contrast
which might be a better drop in than creating and publishing this here.

@buck06191 implemented your suggestion in #167


Computus Powershell Implementation

A literal translation of Julia version.

I wasn't quite able to run this (on linux), but I can try again later. If someone on Windows would like to give it a go and make sure the output is the same as other languages, that would be great!

I'm able to run this locally with the output:
The following are the dates of the Paschal full moon (using Servois notation) and the date of Easter for 2020-2030 AD:
Year    Servois number  Easter
2020    8               April 12
2021    28              April 4
2022    16              April 17
2023    5               April 9
2024    25              March 31
2025    13              April 20
2026    2               April 5
2027    22              March 28
2028    10              April 16
2029    30              April 1
2030    18              April 21

Probably powershell refuses to run script because it's from remote and don't have a sign. Maybe try to copy the script to another .ps1 file and try to run that file?


Add FromStr implementation to Keycode

I had a need about converting a &str to Keycode in my project so I thought that it would be appropriate to create a PR for this.
I also fixed the clippy warnings and formatted the code.

Looks great to me. Thanks for the PR! Sorry for the delay in getting around to this.


Support for Nodes output by Nearest service

Hello sir!
I noticed that the Nearest service was missing support for the newly returned Nodes information, so I added some stuff to parse it. I submitted a pull request here: https://github.com/ssuluh/osrmnet/pull/62
Thank you for the excellent wrapper library!

Addressed with PR #62


Specify node version in package.json

Related issue #56
Problem
Users with older Node (<8.x) will not be able to run the code as some parts of the codebase is using async keyword.
Solution
Define inside package.json min. version of Node to be used to run the code.

Pull Request Test Coverage Report for Build 163

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.315%

Totals

Change from base Build 162:
0.0%

Covered Lines:
227

Relevant Lines:
237

💛  - Coveralls

@martincik Thanks so much for the PR!  Really appreciate you interest in our project.  Would love to talk more with you about it or answer any questions you may have.  If want to chat more please join our discord www.marketprotocol.io/discord


[OPENJDK-2685] Workaround for JDK11 jlinked-image inflating in size

@Josh-Matsuoka I am unable to select your name from the reviewers list.
Could you also please take a look?

@Josh-Matsuoka I am unable to select your name from the reviewers list.

Josh should have an invite from GitHub to the openjdk (container) organisation. Please accept and you can be markd as a reviewer for PRs.

Looks good to me


ImportError: cannot import name 'IPV6_ADDRZ_RE'

Describe the bug
I use awscli which uses botocore, I also install awsebcli. The most recent release of botocore seems to have broken my deploy process.
My issue is very similar to #2186 but isn't the same.
https://github.com/boto/botocore/commit/81768347efe3806decbbc43a61d3816620ee9ce9#diff-d5dc8bb337890042943977b62e8bb2e7db71415d35bb17a41ad4bf4780fb3617R30
Steps to reproduce
Build a docker image currently:
FROM python:latest
RUN pip install awscli awsebcli --upgrade

Use the docker image to run aws s3 cp
See:
Traceback (most recent call last):
  File "/usr/local/bin/aws", line 19, in
    import awscli.clidriver
  File "/usr/local/lib/python3.9/site-packages/awscli/clidriver.py", line 17, in
    import botocore.session
  File "/usr/local/lib/python3.9/site-packages/botocore/session.py", line 30, in
    import botocore.credentials
  File "/usr/local/lib/python3.9/site-packages/botocore/credentials.py", line 34, in
    from botocore.config import Config
  File "/usr/local/lib/python3.9/site-packages/botocore/config.py", line 16, in
    from botocore.endpoint import DEFAULT_TIMEOUT, MAX_POOL_CONNECTIONS
  File "/usr/local/lib/python3.9/site-packages/botocore/endpoint.py", line 22, in
    from botocore.awsrequest import create_request_object
  File "/usr/local/lib/python3.9/site-packages/botocore/awsrequest.py", line 25, in
    import botocore.utils
  File "/usr/local/lib/python3.9/site-packages/botocore/utils.py", line 30, in
    from urllib3.util.url import IPV6_ADDRZ_RE
ImportError: cannot import name 'IPV6_ADDRZ_RE' from 'urllib3.util.url' (/usr/local/lib/python3.9/site-packages/urllib3/util/url.py)

Expected behavior
aws s3 cp to copy files and succeed
Debug logs
Unfortunately this isn't my code and I'm not super familiar with Python or awscli. If this is required, please let me know so I can attempt to do so.
Full stack trace by adding
import botocore.session
botocore.session.Session().set_debug_logger('')

to your code.

As a note, updating my Dockerfile to:
FROM python:latest
RUN pip install awscli awsebcli botocore==1.18.18 --upgrade

Fixes it locally, and this problem only showed up today, so it seems to be from this most recent release

i faced this issue too
seemed like an issue with urllib3 version
using pip install urllib3==1.25.10 fixed my problem

Hey ^^ I can second @dilanSachi's conclusion. If you have a version of urllib3 being resolved (in whatever way) to something less than version 1.25.4, then you will encounter this issue. In my case, I had three different libraries all demanding directly incompatible urllib3 versions :D

I faced this issue too

Hi @Inumedia,
This is esssentially the same underlying issue as #2186. awebcli has a pretty restrictive version range on urllib3 and are overriding the install requirements for awscli. If you want to upgrade to the latest release of awscli, you'll need to have urllib3 >= 1.25.4 that we have declared in the installer. pip isn't great about this but does issue an error message when you perform your current install. It won't however stop you from finishing an incomplete/incompatible install.
The immediate fix here would be to pin urllib3 to >=1.25.4 to stop awsebcli from uninstalling your requirements. You could alternatively use a version of the CLI that shares compatibility with awsebcli.

As a quick update, we're working with the awsebcli team to see if they can relax some of their declared constraints and only rely on botocore like the awscli does. That should help reduce the amount of friction with pip in future releases.

FYI,
I tried your suggestion of pinning urllib3 at >=1.25.4:
pip install awscli awsebcli urllib3>=1.25.4 --upgrade
That seems to have fixed it for the immediate for me. I'll keep an eye on this issue for when this gets resolved.
Thanks for letting me know

i faced this issue too
seemed like an issue with urllib3 version
using pip install urllib3==1.25.10 fixed my problem

This actually saved my problem too!! This was so frustrating!


TestContainersUpdated events are not sent on project open/close

Expected Behavior
The TestContainerDiscoverer class is responsible for notifying the TestWindow of containers where tests should be discovered. It should call the TestContainersUpdated event whenever tests could potentially have changed.
My expectation is that OnProjectLoaded and OnProjectUnloaded should send the TestContainersUpdated event.
Actual Behavior
If you would put a breakpoint you can see that the OnTestContainersChanged is called, but the if condition evaluates to false and the event isn't actually sent, meaning that tests don't get removed on project close and don't get discovered on project open.

NTVS Version: 1.5.10610.1 Commit Hash:529a87de2769e143655e31ea81795c42e5775ef8
Visual Studio Version: 16.2 preview 4
Node.js Version: 8.1.4

Steps to Reproduce

Open a nodejs project
Run build to discover tests
Unload the project
If the event would have been sent successfully the tests for the unloaded project should disappear

In the OnProjectUnloaded method the project is removed from knownProjects and this makes the if condition always fail, whereas in the OnProjectLoaded method the newly created project has HasRequestedContainers set to false making the if condition always fail.

@armanio123 any chance your recent test discovery changes sorted this out?

No. Vstest made some changes on the test explorer that impacted us. They have temporary fixed it but we still need to change how we discover tests and instead notify to the test window. I have already follow up with @drognanar offline.


Pie chart not working for mobile browsers?

EDIT: the error was on my end, I was using es6 syntax on the client-side without proper transforms. All is well with pie charts!
Not sure if this is a problem on my side or what but in my chrome desktop the pie chart is responsive and scales all the way down to mobile sizes just fine. I tested my app on my iphone 6 and iphone 6s and it was not displaying the chart.
I'm testing it on heroku, you can see an example demo right here demo
My <head> tag:
<head>
  <meta charset="utf-8" />
  <meta http-equiv="X-UA-Compatible" content="IE=edge" />
  <title>uvote</title>
  <meta name="HandheldFriendly" content="True" />
  <meta name="viewport" content="width=device-width, initial-scale=1.0" />
  <!-- Latest compiled and minified CSS -->
  <link rel="stylesheet" href="/assets/bootstrap/dist/css/bootstrap.min.css">
  <link rel="stylesheet" href="/assets/css/main.css">
</head>

The container where the canvas element is located:
 <section class="poll col-md-6">
    <canvas id="poll-chart" data-poll-id="80" height="250" width="250"> </canvas>
  </section>

I'm bundling my scripts with browserify:

const fetch = require('isomorphic-fetch')
const randomColor = require('randomcolor')
const Chart = require('chart.js')
const canvas = document.querySelector('#poll-chart')
const pollId = canvas.dataset.pollId
const ctx = canvas.getContext('2d')

const createChart = (poll) => {
  const colors = randomColor({ count: poll.options.length })
  const data = poll.options.reduce((dataSet, option, i) => {
    dataSet.labels = dataSet.labels.concat(option.value)
    dataSet.datasets[0].data = dataSet.datasets[0].data.concat(option.rating)
    dataSet.datasets[0].backgroundColor = dataSet.datasets[0].backgroundColor.concat(colors[i])
    return dataSet
  }, { labels: [], datasets: [{ data: [], backgroundColor: [] }]})

  const chart = new Chart(ctx, {
    type: 'pie',
    data: data
  })
}

fetch('/api/poll/' + pollId)
.then(response => {
  return response.json()
})
.then(json => {
  createChart(json.poll)
})

Another solution is to adapt the radius so it can fit the screensize, on web screen radius = 300, on mobile screen radius = 150 for my case.


Add isEqual to utils

@daniel-de-wit I don't see that export in the RFC: https://github.com/emberjs/rfcs/blob/master/text/0176-javascript-module-api.md
Maybe it is an oversight of the RFC? You should get confirmation that it will be included. If so we can add to this addon

RFC issue: https://github.com/emberjs/rfcs/issues/222
Merge request: https://github.com/emberjs/rfcs/pull/223


Retrocompatible binaries cause an issue when working with pytorch distributed using NCCL backend

First of all,
thank you very much for building all those retrocompatible pytorch binaries for the NVIDIA Tesla K40.
I am currently working on distributed computing using the NCCL backend (GPUs).
The cluster where I run my experiments is equipped with NVIDIA Tesla K40s.
I am using your binary  version "torch==1.9.0+cu111"
When running an experiment, I run into the following error
"enqueue.cc:215 NCCL WARN Cuda failure 'invalid device function'"
which in turns lead to the following fatal error: --> :
"RuntimeError: NCCL error in: /opt/conda/conda-bld/pytorch_1631630742027/work/torch/lib/c10d/ProcessGroupNCCL.cpp:38, unhandled cuda error, NCCL version 2.7.8
0: ncclUnhandledCudaError: Call to CUDA function failed."
It occcurs right after I complete the init phase, hence I get the following log "Init COMPLETE" afterwards.
I found the following resources:
(1) https://discuss.pytorch.org/t/ddp-with-nccl-fails-in-16-x-a100/127416/3
(2) https://stackoverflow.com/questions/66807131/how-to-solve-the-famous-unhandled-cuda-error-nccl-version-2-7-8-error
(3) https://uonfu.com/q/NVIDIA/nccl/444/754106178
(4) https://discuss.pytorch.org/t/nccl-error-in-pytorch-torch-lib-c10d-processgroupnccl-cpp/125423
I also tried your binary version "torch==1.3.1+cu101" and I got into the same problem.
Do you think there is any way I can work around this issue or my GPUs are just simply too old for Pytorch distributed computing
using the NCCL backend?
Again thank you a lot for building all those binaries.

Have you found the method to run the torch.distributed on Tesla K40?


Source for the Python parser

pegen/data contains a Python parser supposedly generated from data/python.gram but this file only contains C like rules ? Would it be possible to get the file containing the python rules ?

Unfortunately, there isn't a version of that grammar with Python rules, this needs to be written and the helpers and other stuff needs to be ported from the C files.

I would be interested in any pointer you may have as the best way to get started then. I would like to port the parser of enaml which is based on ply (https://github.com/nucleic/enaml/tree/main/enaml/core/parser). Enaml defines a superset of Python so I need a full Python parser and I would be happy to contribute it to pegen.

Enaml defines a superset of Python so I need a full Python parser and I would be happy to contribute it to pegen.

That would be great. My advice would be:

Start with the file here: https://github.com/python/cpython/blob/master/Grammar/python.gram
Remove all the C types (but not the actions for now).
Identify the actions that create ast nodes and substitute them for Python nodes in the ast module. For instance:

while_stmt[stmt_ty]:
    | 'while' a=named_expression &&':' b=block c=[else_block] { _Py_While(a, b, c, EXTRA) }

will become (not real final code):
while_stmt:
    | 'while' a=named_expression &&':' b=block c=[else_block] { ast.While(a, b, c) }

Port the rest of the actions to propagate accordingly the values. This is much easier than in C because you can use python code and types in the actions. For example _PyPegen_singleton_seq(p, c) could be simply [c] in Python code.

Port all the error-checking helpers to Python (these are the CHECK macros and the raise... functions.

Once this is done, there is still some work to make sure line numbers and column numbers are correct, but we can discuss how to fix those later.

Sounds good. I was a bit worried about the line numbers but if we can start without I will go with that.

Closed by #11


Update to support IPP Driverless Printing Extensions v2.0

Update PAPPL to support the update to PWG 5100.13, IPP Driverless Printing Extensions v2.0.
I think this is mostly a few new attributes.

@wifiprintguy This is now done!


New Feature: Dev Containers

Feature: Added Dev Container definitions for easier Build/Dev Environment Setup
Issue #, if available:
WiP: Tests for the Container Images
Bugs: Hopefully none
Description of changes:
Added VS-Code / Jetbrains IDE Dev Container definitions with deployment requirements and pinned versions for necessary tools.
Checklist

[ x ] :wave: I have added unit tests for all code changes. (not applicable)
[ x ] :wave: I have run the unit tests, and all unit tests have passed. (not applicable)
[ ] :warning: This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Greetings from Storm Reply Germany

Thanks for the contribution @archang3l-media! We will review this internally and consider it for inclusion in our next release.

Implemented Dev Containers as an item under a .devcontainers directory to allow for the future addition of multiple devcontainer.json files. This feature will release in v1.2.0. Thanks for the idea!


add test for kdl-schema.kdl

Testing against the largest reference document seems like a good idea on principle.

I think include_str! is a 1.5* feature. I don't remember which version it was introduced in. I'm ok with running tests at a higher MSRV, though.

I mean, that was introduced in d8715c8d41fd8504fc12cf6dfa7a36d2d0e612c1 before I got here, but I agree that raising the MSRV for that should be fine.


adding GPG key servers

Sometimes when the default key server fails the built fails too.
This "fix" is inspired by what is done in nginx official Dockerfile

I'm not able to run update.sh on my mac, and I don't have access to linux right now.
Therefore some tests are failing on the Dockerfiles which are not updated with the new template


Add GitHub Team User Store to tools sources

This tool simply creates a dictionary of team/users and stores them as a json string in azure blob storage. This is first part of the fix for https://github.com/Azure/azure-sdk-tools/issues/4487. The second part of the fix will be modifying CodeOwnersParser to get the list of users for the team and adding them to the Owners instead of throwing them out.
A large part of the why this was done this way was due to the permissions required to access the teams in GitHub. A standard GitHub token cannot have the permissions necessary to read org/team membership. It requires a fine-grained token created by someone with the organization permissions which, unfortunately, excludes bot accounts meaning it has to be from an actual user. The resulting blob string is only 44k and would only need to be pulled by the CodeOwnersParser once, if teams are encountered.
The GitHub token and blob SAS have already been added to the secret-management tool as manual secrets in the azure-sdk-build-tools repository (PR 747). I've also created the variable group, azuresdkartifacts azure-sdk-write-teams variables, which will be used in the pipeline when I create it, after this PR has been merged. Last but not least, this tool won't be published to nuget, the pipeline will build and run the tool as part of the pipeline. Also of note, because it's using a generated GitHub token, it won't affect the repository limits where it runs.

A large part of the why this was done this way was due to the permissions required to access the teams in GitHub.  A standard GitHub token cannot have the permissions necessary to read org/team membership.

How the implementation would differ if the standard GitHub token could have the permissions?

The GitHub token and blob SAS have already been added to the secret-management tool as manual secrets in the azure-sdk-build-tools repository (PR 747)

So the GH token you created and put in the KV is your personal token? And the idea is that whomever rotates it next with the secrets tool, will have their own personal token put in KV instead?

I've also created the variable group, azuresdkartifacts azure-sdk-write-teams variables

My brain's English parser throws exception on this, sorry x-D. Is azuresdkartifacts a variable group and azure-sdk-write-teams is a variable belonging to it? Could you perhaps link to the variable group from the PR description?
What is the purpose of this variable group and variable?

A large part of the why this was done this way was due to the permissions required to access the teams in GitHub.  A standard GitHub token cannot have the permissions necessary to read org/team membership.

How the implementation would differ if the standard GitHub token could have the permissions?
The standard GitHub Token cannot have Organization->Membership:Read permissions which means they cannot query for team membership. Furthermore, in order to query teams and membership for an org, the account that created the token needs to be a member of Azure. This is something @weshaggard and I have discussed and it was decided to use a generated token.

The GitHub token and blob SAS have already been added to the secret-management tool as manual secrets in the azure-sdk-build-tools repository (PR 747)

So the GH token you created and put in the KV is your personal token? And the idea is that whomever rotates it next with the secrets tool, will have their own personal token put in KV instead?
Yes. The secrets are in the azure-sdk-build-tools repository in the tools/secret-management/manual/AzureSDKEngKeyVault. The json files are azuresdkartifacts-azure-sdk-write-teams-github-pat.json and azuresdkartifacts-azure-sdk-write-teams-sas.json, both of which describe what needs to be done.

I've also created the variable group, azuresdkartifacts azure-sdk-write-teams variables

My brain's English parser throws exception on this, sorry x-D. Is azuresdkartifacts a variable group and azure-sdk-write-teams is a variable belonging to it?
Could you perhaps link to the variable group from the PR description?
What is the purpose of this variable group and variable? I know they will be used in the pipeline, but how?
I don't normally link variable groups in PRs because they're public. This is the variable group that holds these two variables. Like other variables in our pipelines, these are linked to the keyvault secrets and pull their values from there which is the standard. When the values change, after a rotation, the variable group won't need to change because it'll just start pulling the new values.


Add repeat function.

Tempted to add join, too.

Plain text output. I'm using it to build tables and whatnot.

Gonna be looking to make something to wrap text soon, too, but all this is making me think there needs to be an easier way to write, like, plugins or something. Dunno how to do what when the output is a static binary, though.

I was going to just merge this, but I will just chime in with a thought. The idea with the namespace/alias setup was to avoid putting everything into one global namespaces -- and possibly get some help in the docs department (the dochelper JSON for template funcs is currently not in use).
So, the alias is meant for important core functions (i.e. where etc.). We have some that does not match the important category, but we cannot remove the.
This is, hower, not a core function, it is a strings utility function. One might imaging we get a repeat function for some other "thing", and it would be bad to have an alias for this.
I'm happy to add these template functions, but could you nil out the alias field and put the docs in strings.Repeat etc.
Yes, I know that we should somehow autogenerate the docs for this ...

Also maybe add add some upper limit to avoid out of mem pranks...

Maybe just use int16 to limit it to (-32768 to 32767)?


Error when upload file and additional data

Thanx for good directive!
But i can`t understand why error appear. Please, help!
i load object saved early. Edit it. Change avatar picture. Try to save, and got an error.
Error:
ngFileUpload: Circular reference in config.data. Make sure specified data for Upload.upload() has no circular reference: $promise[$state][value][$promise]
i try copy all core code in fiddle
https://jsfiddle.net/anzolo/kc86c12n/22/?utm_source=website&utm_medium=embed&utm_campaign=kc86c12n

find the answer.
problem was in copy json object.
i make in commented way and got an error:
masters.get({
            id: masterID
        }, function (data) {
                //$scope.master = data;
                $scope.master = JSON.parse(JSON.stringify(data));

                Upload.urlToBlob(data.avatar).then(function (blob) {
                    $scope.master.avatar = blob;
                    $scope.master.avatar.lastModifiedDate = new Date();
                    $scope.master.avatar.name = data.avatar;
                });
)

For all newbies, my advice :)
copy json objects in javascript by something like this:
cloneObject = JSON.parse(JSON.stringify(myObject));


Exclude directions in extracted parts

Currently it is possible to declare if a direction is affects specific parts or all parts with @part (and @partstaff). However it is not possible to say specifically, that something should not appear in any part, e.g. something like "a2" in the woodwind section.
I propose to extend the allowed pattern to (%all|%none|#[\i][\c]+) to keep something from extracted parts.
Relates to #1450.
NB: Currently we have the same definition for this datatype twice, so it might make sense to extract it into its own datatype.

I got chatgpt to tell me what #[\i][\c]+ means after giving it hints that it is related to ODD 😉
I am wondering about the +:  Does that mean that #A is an invalid reference ID for the @part (or @partstaff) value?   I am wondering if it should be * instead:
 (%all|%none|#[\i][\c]*)

And is #: be a valid ID reference?
Maybe adding a minus sign before the IDREF could be a way of excluding from a particular extracted part:
 (%all|%none|-?#[\i][\c]*)

In general %none should work for suppressing a2.
There will be text such as solo which would be suppressed in only in the non-solo part, which could be @part="#part1" or @part="-#part2".  Not particularly useful for the negation in this case since @part="#part1"` works well.  The negation would be useful if there were more than two parts to exclude a particular part rather than including multiple parts.


Uh maybe im just a retard but i am clueless on how to find the BSSID and also the corresponding channel stuff lol

Pls helping me

Hello @DendeEat , you can refer this https://www.youtube.com/watch?v=tdhVCyhH5Y8
Hope it helps, Thank You.


Sort Partner Distributions Newest to Oldest

On partner show pages we display a list of distributions to that partner but to make them more readable for the diaper banks we should sort them from newest to oldest.

👋 Hello! I think this would be a good first issue for me. I don't see an option to assign this issue to  myself.

@edwinthinks  @seanmarcia 👋 Is there anyway I can get access to push my local branch up so I can create a PR? I keep receiving this error when attempting to push up:
remote: Permission to rubyforgood/diaper.git denied to cato-hga.
fatal: unable to access 'https://github.com/rubyforgood/diaper.git/': The requested URL returned error: 403


Hystrix-javanica synchronous command creates thread

I am testing some timing out hystrix synchronous commands https://github.com/Netflix/Hystrix/tree/master/hystrix-contrib/hystrix-javanica#synchronous-execution
The thread pool runs out on the 10 test by default because something is creating threads (the fallback procedure?) Is this expected behavour? How can I close the threads from the synchronous command to prevent Hystrix becoming overloaded after 10 failures?
Stacktrace:
Stacktrace was: com.netflix.hystrix.exception.HystrixRuntimeException: getUserById could not be queued for execution and fallback failed.
...
Caused by: java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@b36ec557 rejected from java.util.concurrent.ThreadPoolExecutor@e9a1174c[Running, pool size = 10, active threads = 10, queued tasks = 0, completed tasks = 0]

@andrewe123 Whenever a HystrixCommand executes and uses thread-isolation, it consumes a Hystrix thread.  If the threadpool runs out of threads due to more concurrency than threads, then Hystrix returns the fallback.
The threads are only used by Hystrix, and only when executing a command.  Are you seeing thread-pool exhaustion after commands have finished, or during periods of high concurrent execution?

@mattrjacobs, hystrix uses only threads from internal thread pool per command group, if thread pool is fixed size then how thread overflow possible ? Or problem is different ?

In the console above, the threadpool has a fixed capacity of 10, and 10 active threads.  When the 11th task is submitted against the threadpool (by executing the command), while those 10 are are still in flight, the command gets properly rejected.
Unless I'm missing something, this is all working as expected.

My unit tests look something like the following
@Test
Public void test_getUser() {
expectException(HystrixRuntimeException.class);
expectCause(TimeoutException.class);
service.getUser();
}
I was expecting the command would be finished when the exception is evaluated in the test, but it doesn't seem to be the case. If I have more than 10 unit tests in a class I get the rejected new thread exception instead of the expected timeout. I also tried another test with a single loop to 20 caughting the Hystrixruntimeexception exception inside, once it gets to the 11th run the exception cause is no longer a timeout but a rejection because the active thread limit is hit. I also tried sleeping for 500ms after each iteration of the loop with the same results.
Is this behaving as expected? If the threads are not released after 500ms after the exception is caught like in my test wouldn't hystrix always be rejecting new commands? I'm sure I'm missing something, but I don't know what it is.

One point here is that there's nothing Hystrix (or any other code) can do to release a thread.  Hystrix can issue a timeout, which delivers a value to the caller, but it can't forcible terminate the work on the other thread.  By default, it attempts to interrupt the thread on a timeout, but that doesn't have to be respected.  Can you try checking for that InterruptedException in your simulated work?
If that doesn't pan out, can you share some of your code so I can take a deeper look?

Closing due to inactivity.  Please re-open if there's more to discuss

We're observing the error mentioned some time earlier in this thread a couple of years ago. Was the root cause identified? Looks like the issue was just closed.
Caused by: java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@b36ec557 rejected from java.util.concurrent.ThreadPoolExecutor@e9a1174c[Running, pool size = 10, active threads = 10, queued tasks = 0, completed tasks = 0

The issue was closed ~10 months ago.
Thread pool rejection is absolutely expected to some degree when using Hystrix.  By design, Hystrix provides bounded thread pools that may fill up and reject work if they get full.
What's the precise nature of your situation?

@mattrjacobs Could you help me clarify this? As in the issue description, when the log says fallback failed., does it still mean it was run? I am confused if there are no threads left for the command itself how the fallback can be run?

There are many failure modes, and Hystrix attempts to treat them all equivalently by running the user-supplied fallback:

failure - fallback is run on the Hystrix thread
threadpool full - fallback is run on the caller thread
semaphore full - fallback is run on the caller thread
short-circuit - fallback is run on the caller thread
timeout - fallback is run on the thread which triggers the timeout (HystrixTimer)

I am having the similar issue. I am getting below error:
Task java.util.concurrent.FutureTask@6c15a847 rejected from java.util.concurrent.ThreadPoolExecutor@29172ba1[Running, pool size = 10, active threads = 10, queued tasks = 0, completed tasks = 0]
	at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) ~[?:1.8.0_131]

Even though, there should not be any concurrency issue, as i am submitting only one request. So, ideally only one task should be submitted to the threadpool. But somehow, it keeps on submitting task, until the pool gets exhausted, and the last thread just goes to fallback method, due to the above error.
Could someone help here ?
I am using hystrix-javanica:1.5.12 and spring 4.3.3-RELEASE


Clarify both HTTP and HTTPS are required

https://github.com/UnifiedPush/specifications/blob/main/specifications/server.md?plain=1#L7

The endpoint MUST be a IRI (RFC 3987) with a scheme of HTTP or HTTPS

Isn't it already the case ?


Creating a repo from a template repo via API

fix #15934
ref:
https://docs.github.com/en/rest/reference/repos#create-a-repository-using-a-template

love the new endpoint did had some inital work on this too but was not happy with it :)

@a1012112796 TestAPIGenerateRepo failed related


App engine (python3 - standard environment) generate aborted connections when connecting to a cloud sql -2nd Gen Mysql instance

I'm currently developing a project with python 3.7, Django 2.1, Mysql as database.
I'm deploying it in google cloud app engine standard environment and for the database I'm using a cloud SQL - MySql 2nd gen instance.
The application works well, however when I analyze the logs I see these errors:

"aborted connection - Got an error reading communication packets"

In this case the connection is being closed by my app (django).If I configure my app to have persistent connections and I put wait_timeout (i.e 60) in the config of the cloud sql, the error is:

"aborted connection - Got timeout reading communication packets".

I think maybe it's not a problem with sql cloud, or with the configuration of my application, but that it's an app engine problem. I came to this conclusion in the following way:
if I connect to the sql cloud instance through Mysql workbench, no connection is aborted. Similarly if I run my application on a local server, but connecting to cloud sql (through the cloud_sql_proxy), no error is generated and everything works perfect.
So my conclusion is that it is a problem of how the app engine connects to the cloud sql instance.
Why does this happen? How could it be solved?

Hey Fumpe,
Unfortunately, issues on this repo are limited to tracking issues with the cloudsql_proxy itself, and not for any of the products. Google App Engine does have a public issue tracker, which you can submit issues to here.
I can give a few suggestions for troubleshooting, based on my own experience:

Make sure you are using the unix socket provided at /cloudsql/<INSTANCE_CONNECTION_NAME. Instructions on how this works can be found on the Connecting from App Engine page.

Make sure you are using a connection pool, and returning connections to the pool (via closing) as soon as you are finished with them. The Managing database connection page has some good examples of this.

Try a different driver. Python has lots of drivers, and I'm not sure what kind of support App Engine has to each one. If you aren't already using pymysql, it's pure python so it shouldn't have any issues.

Hope that helps.

Thanks a lot kurtisvg. I changed de Driver to pymysql and the aborted connection decreased significantly.


Add version info and upgrade test for 14.13, 15.8 and 16.4.
Add upgrade schedule files for 14.14, 15.9 and 16.4.
Update T-SQL extension version to 4.4.0 and add following upgrade scripts:

babelfishpg_tsql--4.3.0--4.4.0.sql.
babelfishpg_tsql--2.11.0--3.0.0.sql (Duplicate of babelfishpg_tsql--2.10.0--3.0.0.sql).
babelfishpg_tsql--3.8.0--4.0.0.sql (Duplicate of babelfishpg_tsql--3.7.0--4.0.0.sql).

Signed-off-by: Rishabh Tanwar<EMAIL_ADDRESS>Test Scenarios Covered

Use case based -

Boundary conditions -

Arbitrary inputs -

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 74.038%

Totals

Change from base Build<PHONE_NUMBER>7:
0.4%

Covered Lines:
44407

Relevant Lines:
59979

💛  - Coveralls


GH-36984: [MATLAB] Create arrow.recordbatch convenience constructor function

Rationale for this change
For parity with how arrow.array.Array objects are constructed (i.e. via arrow.array), we should create a construction function called arrow.recordbatch() for arrow.tabular.RecordBatch:
>> t = table(["A"; "B"; "C"], [1; 2; 3])

t =

  3×2 table

    Var1    Var2
    ____    ____

    "A"      1
    "B"      2
    "C"      3

>> rb = arrow.recordbatch(t)

rb =

Var1:   [
    "A",
    "B",
    "C"
  ]
Var2:   [
    1,
    2,
    3
  ]

>> class(rb)

ans =

    'arrow.tabular.RecordBatch'

The arrow.tabular.RecordBatch constructor will accept a scalar libmexclass.proxy.Proxy object instead of a MATLAB table (although, client code is not expected to call the constructor directly - similar to the other classes).
What changes are included in this PR?

Added the convenience constructor function  arrow.recordbatch(). It accepts a MATLAB table as input.
Modified arrow.tabular.RecordBatch's constructor to expect a scalar libmexclass.proxy.Proxy object as input instead of a table.

Are these changes tested?
Yes, updated the test cases in tRecordBatch.m to use the new convenience constructor  arrow.recordbatch() .
Are there any user-facing changes?
Yes, users are now encouraged to use arrow.recordbatch() when constructing a record batch from a MATLAB table instead of  arrow.tabular.RecordBatch's constructor.

Closes: #36984

+1


View the SAP Cloud Platform from 10,000 Meters - missing screenshots

Tutorial URL: https://developers.sap.com/tutorials/cp-explore-cloud-platform.html

I see the images. Can you check again?

They're there now. Issue must have fixed itself somehow.


Merge pull request #1 from yahoo/master

new

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

Closing this, since it looks like a mistake (i.e. no files changed).


Question: Enumerate edges and vertexes

Having a routerDB may I enumerate all edges and vertexes along with their meta and attributes?
Thanks

Perfectly possible but watch out when modifying the data while enumerating. An example is here: $
https://github.com/itinero/routing/blob/develop/src/Itinero/Algorithms/Networks/ZeroLengthLinksOptimizer.cs#L50
This code removes links of length '0'

Ok. thanks for the tips.


Bug-Fix: Patient's Age parsing discrepancy during XLS export in Sample Management System

Proposed Changes

Fixes #9231
Manually parsed the data to resolve the error.
Conditions are made based on column name and logic written accordingly.

@ohcnetwork/care-fe-code-reviewers
Screenshots of the fix :

Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

@Jacobjeevan Please have a look if this is good to go. Thank You :)

Summary by CodeRabbit

New Features

Improved data export functionality in the Sample View Admin component for better formatting and readability of patient data.

Bug Fixes

Enhanced processing of date fields for consistency and accuracy, including better error handling for invalid dates.

Hii @nihal467 please check if this is good to go. :)

@pooranjoyb when the date of result is empty, its been shown as invalid date, if the data is not available, leave the column blank

Okaay Updating it asap. @nihal467

@pooranjoyb when the date of result is empty, its been shown as invalid date, if the data is not available, leave the column blank

Changes are made as requested. Please have a look sir @nihal467

@pooranjoyb when the patient age <1, the patient age should be shown as month and days , as we show in the patient list page,

@pooranjoyb when the patient age <1, the patient age should be shown as month and days , as we show in the patient list page,

Okaayy, will update this asap. Thanks for the review @nihal467

@rithviknishad can you look into the issue

@nihal467 We can show 0 itself right? Changes in the back-end will be required for this since we are not getting the DOB of the patient in this API.

@nihal467 We can show 0 itself right? Changes in the back-end will be required for this since we are not getting the DOB of the patient in this API.

Yes, of course 0 can be done. If you'd ask, I can go with the requested changes.

@rithviknishad @nihal467 Requested changes are pushed. Please review. Thanks :)

LGTM


add missing requirement 'request'

one requirement was missing

Hi Demetrio,
This repo is just a mirror of apache/kudu, and neither take pull requests. Here are the instructions on how to post your patch on gerrit: http://kudu.apache.org/community.html#write-code-and-submit-patches
Thanks!
J-D


[iOS] Get rid of AppDelegate.m files and use AppDelegate.swift instead

Motivation
In order to make the iOS part more future proof and easier to follow (most tutorials now are using swift), I converted the AppDelegate files to swift versions.
Test Plan
NA

[ ] ./core/fixtures/files/project.pbxproj is still referencing an AppDelegate.m and I do not know, how to update that file

Release Notes

[IOS] [CLI] [FEATURE] - Initialize project that make use of AppDelegate.swift instead AppDelegate.h/m

@mcplectrum Thanks for the PR! My main concern with this is that a lot of apps won't use any native code so it doesn't make sense to bundle the swift runtime (which adds a few mbs to the binary) just for using it in AppDelegate.
Could we just provide a different swift template instead so people that want to use swift can use that instead? We probably should still default to objc for now until swift hits ABI stability and it's runtime is built into iOS.
If you want to do the same for the RNTester projet you could just create a new xcodeproj file a bit like we have for RNTesterLegacy.


Cocoapods & Xcode 10 / swift 4.2 support

According to #516, swift 4.2 branch is in master, but Cocoapods version is still 3.3.1 - any plans to update the podspecs and push a new tag?

for the mean time you can replace your lines
pod 'Chatto', '= 3.3.1'
pod 'ChattoAdditions', '= 3.3.1' # if you want to use the cells or the input component
by
pod 'Chatto', :git => 'https://github.com/badoo/Chatto.git', :branch => 'master'
pod 'ChattoAdditions', :git => 'https://github.com/badoo/Chatto.git', :branch => 'master'
this will take the latest pull from master and no issue will be shown.

According to #516, swift 4.2 branch is in master, but Cocoapods version is still 3.3.1 - any plans to update the podspecs and push a new tag?

for the mean time you can replace your lines
pod 'Chatto', '= 3.3.1'
pod 'ChattoAdditions', '= 3.3.1' # if you want to use the cells or the input component
by
pod 'Chatto', :git => 'https://github.com/badoo/Chatto.git', :branch => 'master'
pod 'ChattoAdditions', :git => 'https://github.com/badoo/Chatto.git', :branch => 'master'
this will take the latest pull from master and no issue will be shown.

@dheerajjha thanks for your suggestion, but, unfortunately, I can't, because I use Chatto as a dependency in my own private podspec, and cocoapods does not allow to specify branches/commits explicitly for pod dependencies.

@maxkonovalov new release 3.4.0 is here. This release is ready for Xcode 10 and Swift 4.2.


:gift_heart: Kn Event buildflags patch

To avoid things like https://github.com/openshift-knative/client/pull/281
/kind feature

/cc @dsimansk

@cardil thanks! Can you check if it doesn't break release-next branch when event plugin is not present pls? I can probably try out tomorrow as well if you don't get to it.

@dsimansk: Can you check if it doesn't break release-next branch when event plugin is not present pls?

Oh, yeah. It will probably break it. However, maybe we can make the script optional. If kn-event isn't found in go.mod than skip the settings... Let me see
/hold


Please add information for error 0x8007007b in IIS support page

The following page has information on a number of IIS error codes, but nothing about 0x8007007b, an error that is currently flummoxing me.
https://github.com/MicrosoftDocs/SupportArticles-docs/blob/main/support/developer/webapps/iis/health-diagnostic-performance/http-error-500-19-webpage.md
In particular, IIS navigated me to the above page by providing the following link in the error page.
https://go.microsoft.com/fwlink/?LinkID=62293&IIS70Error=500,19,0x8007007b,17763
Of course, since the linked page didn't actually reference the issue I'm having, it's not helpful. Any additional information you can provide would help me in debugging this issue.

Thank you for your feedback. I will check with the engineers about the error code. It may take some time to get the article updated. So, I'd recommend that you contact Microsoft Support to get further help.

Hi! @steverichey Could you check if the following link can help? Thanks.
https://social.msdn.microsoft.com/Forums/en-US/36bf273e-1183-44f5-8a75-21fc75a897cd/error-using-url-rewrite-quotdoes-not-have-a-handler-associatedquot?forum=iisapplicationrequestrouting
Here is a microsoft document for the error 0x8007007b but it's related to Windows: https://docs.microsoft.com/en-us/windows-server/get-started/activation-error-codes#summary-of-error-codes.

That is useful, but there's no information on that forum post about the difference between 500.19 errors like 0x8007007b vs 0x8007000d.

@steverichey Hi Steve, I have confirmed with our engineers that there're various cuases for this issue and the troubleshooting steps are complicated. It's hard to provide general steps in our article to solve it. So, if you encounter such an issue, please contact our Support for further help. Thanks!


vladmandic/automatic compatibility

This makes the extension work at a basic level in vlad's fork.

The ui does not adapt to the right height, but it should be possible to fix.

I don't have the same thing as you:

The wrong height should be fixed now.


Feature List

Is there any possibility of creating a feature list that AlexaPi currently supports and in some cases to what extent it supports a particular features? I know the Alexa Voice Service provides a series of different API calls such as music and alerts. I realise that most of them work in a similar way but its difficult to know what is actually working at the moment. That way I know if I have a setup issue or if the particular feature isn't currently implemented.
Perhaps we could have a skills list that we define as working or not as the case may be.

Not in the near future. We haven't touched the actual Alexa stuff during the refactoring yet. When we get there and separate it into a module, we're gonna start work on supporting the new API, which will enable us to use alarms/timers and stuff like that. But that's quite the future. AFAIK, no one has started work on the new API.

And I think that when we have the new API support, we'll have it all.


V5.16 rc2

Updates to all gem and JS dependencies
Unlocked the MySQL gem so that it could upgrade to 0.5.6
Updated the drafts_controller so that it calls out to the DMPHub to fetch related works found by the harvesters upon initial load
removed curly braces that did not need to be there in dashboards.js
fixed some issues with the display of the related works count in the grey text that appears under the DMP title (See screenshot).
fixed issue with the grant id display in the slide out modal
fixed issue with the z-index of the new slide out modal (DMP ID urls were showing through the modal)

Hi Brian. The changes look good to me.

@briri I'm wondering whether the "close" button might look better if outside of the content div.
I've included a screenshot of the before and after

I also added a hover effect on the close button to make it more visually interactive.
If you like the change, you can just update the css to be:
#quick-view-view h3 .form-actions button {
  border-radius: 50%;
  position: absolute;
  right: 10px;
  top: 10px;
  height: 32px;
  width: 32px;
  font-size: .8rem;
  padding: 0;
}

#quick-view-view h3 .form-actions button:hover {
  background-color: #ccc;
}

Also, since we're using Sass, you can put the css in the sass nested format for more readability:
#quick-view-view {
  h3 {
    display: flex;
    align-items: flex-start;
    justify-content: space-between;
    flex-wrap: nowrap;

    .form-actions {
      margin-top: 0;
      padding-top: 0;
      padding-left: 0;

      button {
        border-radius: 50%;
        position: absolute;
        right: 10px;
        top: 10px;
        height: 32px;
        width: 32px;
        font-size: .8rem;
        padding: 0;

        &:hover {
          background-color: #ccc;
        }
      }
    }
  }

  p.preview-grant {
    max-width: 100%;
    overflow-wrap: anywhere;
  }
}


[hotfix] Remove strange configs from helm defaults

What is the purpose of the change
Remove some unnecessary configs from the helm defaults
Brief change log
clean up default flink conf
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

+1 LGTM


compatibility issue

Sometimes,  IE11 and edge cannot close Dialog by closeIcon

There's something wrong with version 2.5.0.

Any error messages in Console?

Yes, please give some information on how to redo the error. I tried it out on edge and it works fine.

I tried extensively in IE11 for more than 100 times over past 2 hours. But it worked all the time. May be he is using the plugin in app, which might have caused this? OP need to give some info to debug. Otherwise, I'm convinced that there is no issue with v2.5.0 with IE11.

When the mouse moves to closeIcon, the Dialog  shaking

When the parent window is the iframe in IE11, the chrome is OK

`

<iframe id="mIframe" width="100%" height="0" src="<c:url value='/index'/>" frameborder="no" border="0">

`

`

<iframe id="mIframe" width="100%" height="0" src="<c:url value='/index'/>" frameborder="no" border="0">

`

$(window).on('resize',function() {
if(window['console']) {
console.log('$(window).height(): ' + $(window).height() + ' ,$("#topIframe").height(): ' + $("#topIframe").height());
}
$("#mIframe").height($(window).height() - $("#topIframe").height());
});

Can you create a gist with the code which will replicate this issue? So we can have better understanding of why it is happening?


doc: release-notes-4.0: Add notes for Wi-Fi and Ethernet

Added release notes for Wi-Fi and Ethernet components.

Fixed the typo

Removed Ethernet part from the release note as there is better one at #81242


JS: remove React library improvements from the change notes

According to git blame, the only 1.20 changes for React are
query-specific improvements, which are mentioned elsewhere in the
change notes.

Hm, it looks like https://github.com/Semmle/ql/pull/607 may have just missed 1.19. If so, then that would be sufficient reason to keep this change note after all.


A deep dive into Vue 3 forms submission to Laravel API

NOTE: All 1st-time contributors should know Topic approval and PR submission does NOT guarantee your Topic/Article will be published. Our team of Peer Reviewers and Content Moderators will review all PRs that come in to make sure they adhere to the standard of quality we expect from the EngEd community.
We expect all community memebers to go through provided examples, resources, and previously published material before submitting content. As a rule of thumb, please only submit articles (pull requests) that are complete, formatted correctly, and include a fully polished article (ready to be published and error free).
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue). Any PR that is submitted incomplete (meaning not ready to be published as is) will be closed. A PR being closed does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
Topic Suggestion
Enter topic suggestion here...
Pre-submission advice
By following all our pre-submission advice and reviewing our Resources folder, you will maximise your chances of your topic being approved.
We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner.
Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published (subject to vary depending on volume and/or backlog of articles).
Be sure to visit our Resources Page for tools, resources, and example articles that will help you propose and write a successful article.
Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
Writing sample(s):
Include any links or writing samples - to help our team better gauge your writing quality.
Proposal Submission
Proposed title of article
A deep dive into Vue 3 forms submission to Laravel API
Proposed article introduction
In this article,  we discuss the new way of doing things in Vue 3. We will build a sample application in Vue 3 for user registrations and sign in. The form is then validated using the new features of Vue 3.
The second phase of this tutorial is building the API in Laravel 8. We then use the Axios to make API requests to submit user details.
Key takeaways
The concept of Axios is clearly explained

The Vue3 new way of submitting forms
Laravel 8 resource API discussion in depth.

Article quality
How is your article unique? Tell us what makes your approach different from similar articles that have published on the same topic?
Is yours more in-depth? Does it cover additional topics? Do you provide handy tips or anecdotal advice?
References
Please list links to any published content/research that you intend to use to support/guide this article.
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquoted notes as you fill in the form before you submit.
We look forwarding to reviewing your topic suggestion.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Closing to clear my queue

I'm ready to work on this, @ahmadmardeni1


RangeError: Maximum call stack size exceeded @zxcvbn-ts/language-en Dictionary

I am getting a RangeError: Maximum call stack size exceeded when using the dictionary in @zxcvbn-ts/language-en for the zxcvbn options. Please see screenshot attached.
Seems to be related to getRankedDictionariesMaxWordSize. Please see screenshot attached.

I'm getting the same error after upgrading to 2.2.0, only it's causing our app to crash. Downgrading to v2.1.0 fixed it.

Interesting, the maxWorkSize isn't really that expensive and runs in a few ms 🤔 I can't reproduce this issue with my node services and the demo page works fine, too.
So i guess this has something to do with ReactNative 🤔
Could you give me a simple reproduction repo with ReactNative so i can test it too?

Could you give me a simple reproduction repo with ReactNative so i can test it too?

Here you are: https://github.com/simon-abbott/ZxcvbnRepro

Same problem here. I don't use React.

@iMattPro what are you using?

Just vanilla JavaScript via script tags as shown by your documentation.

Alright i found the issue with setting the max stack size for node and a fix for it

The new release is out and it works with a stack size of 81 like before

@MrWook It doesn't look like npm version 2.1.0 has these changes. How do we get these latest changes into npm?  Thanks!

@gryffs it was resolved in<EMAIL_ADDRESS>

@simon-abbott Thank you! Found it and updated.

@MrWook Sorry about not getting back to you. Thank you for the update, it's very much appreciated!


roon-bridge: init

Motivation for this change
The implementation was mostly copied from roon-server as the packages are very
similar.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112971 at fba31c7e run on x86_64-linux 1

1 package built:

roon-bridge

Result of nixpkgs-review pr 112971 at fba31c7e run on aarch64-linux 1

1 package built:

roon-bridge

Addressed @SuperSandro2000

Oh looks like I was late to the party... sorry 😄


Official EM and Finetuning program

Hi,
Thanks for the great work! It really helps me a lot.
I am curious about the difference between EM and official EM. And what is to be improved in run_finetune.py considering its experimental flag. Thanks so much

Hi,
Thanks for interested in this project.
The difference between EM and official EM is that EM requires a predicted answer span being exactly the same as the target answer span, which is a logit comparison; on the other hand, official EM compares a normalized (e.g. stripping white spaces) answer text with the target text, which is a text comparison and comparable with other QA models, and that's why it's called "official".
For the "experimental" notation, I used it because I had not fully reproduced the results on the paper through that fine-tuning script, but now
the result can be fully reproduced so you can just ignore that notation.
The difference between the original TF impl. and this project is that we allow you to add additional documents for retrieval during fine-tuning or prediction, though the embeddings of these documents will not be further updated during fine-tuning, by design.

OK. Thanks for your quick and detailed reply !
After downloading the data and code, I have following questions:

in this project, we can easily add additional documents for retrieval during fine-tuning or prediction. But when executing python predictor.py --question "Who is the pioneer in modern computer science?" with additional documents, I notice that the additional document embedding is obtained by fine-tuned realm_nq_embedder. But considering the query embedder and document embedder are tied. Is it more reasonable to encode the additional document with cc_news_pretrained_embedder ? Because the embedder is changed during fine-tuning with original document embedding fixed.

how to accelerate predictor.py by using Cuda?

when executing checkpoint_converter.py, I got following result. Does this mean a successful conversion from TF to PT?

when benchmark NQ datasets, I have to download nearly 100G data from huggingface while most of them are useless, is there a better way ?

TL;DR: Not really, though I didn't compare the performance between them.

Although the doc_embed is frozen during fine-tuning by the original TF implementation for simplicity, the paper actually mentions that asynchronous refreshes can be used for both pre-training and fine-tuning. So in this case, using realm_nq_embedder is similar to retrieve embeddings from an updated/non-stale embedder θ (though these additional documents are definitely not marginalized during fune-tuning); on the other hand, getting embeddings from cc_news_pretrained_embedder basically means we're using a stale embedder θ because it's not further updated along with fine-tuning.
A section quoted from REALM paper:

While asynchronous refreshes can be used for both pre-training and fine-tuning, in our experiments we only use it
for pre-training. For fine-tuning, we just build the MIPS index once (using the pre-trained θ) for simplicity and do not
update Embed_doc. Note that we still fine-tune Embed_input, so the retrieval function is still updated from the query side.

The reason why doc_embed is frozen:

This works because pre-training already yields a good Embeddoc function. However, it is possible that refreshing the index
would further improve performance.

predictor.py doesn't provide a device option, needed to be modified by yourself.

Sure that's normal because the size of block_emb tensor is very huge.

I'm afraid no. Or you can dive into huggingface's datasets library and find if there is a way to circumvent this.

Hi, thanks for your reply.
As for fixed document embedding, one crucial part is that the newly added additional document should be encoded like the ones it is  concatenated with (Wiki data). So a cc_news_pretrained_embedder is more proper here, from my personal view.
And in fine-tuning phase, the embedder is only updated from query side rather than from document side.
And for the reason why asynchronous index refresh didn't apply in fine-tuning phase, I think it is a trade-off between computational cost and improved performance. (so does RAG model).

Yes, I believe it was a trade-off.
Unless an evidence that embeddings from "pre-trained embedder" outperform most of the time is provided, IMO I would not judge it's more "proper" just because the resulting embeddings between original wiki data and newly added documents are aligned.

Also note that the aforementioned embeddings are only used for providing top-K relevant documents, the reader still needs to encode them using it's own embeddings, so I think which embedder is used for retrieval doesn't matter too much.


Show confirmation for git operations like pull/push

VSCode Version: All
OS Version: All

Steps to Reproduce:

Do git operation like pull/push
User gets confused if the git operation completed or not
The output is too verbose

Reproduces without extensions: Yes

It is mustly required feature...
Pls show a message after all git operations (atleast when a git pull operation gets completed)


Translate SIL to WALA-IR after canonical SIL is fully generated [WIP]

Current SIL instructions captured by WALAWalker are not the final version. We should move the WALAWalker to the place where SIL instructions are fully optimized.

Talked with @gojeffcho and we need to find a better place to capture SIL instructions.

@Leeleo3x @gojeffcho what's the status of this PR? I recall we said that we'll stick where we capture SIL functions for now. Is that still the case?

I think this one can be closed if we are not going to capture canonical SIL.

Ok. Let’s close it for now. Thanks @Leeleo3x.


Rate checker style fixes

Changes

Removes extra padding from loan amount & state dropdown

Screenshots

Review
@cfarm @amymok @stephanieosan @huetingj

:+1: Hooray!

:+1:

:star2:


Greedy speedup

Soft-dtw looks like the perfect solution for my deep-learning model. However the speed is a major bottleneck in training (minibatches of 64 samples, w. 2000 positions x 25 classes).
Would it be possible to add a parameter for greedy scoring which would scale better in time?
For example, I never need alignments with more than a few insertions/deletions. Perhaps this can be achieved by controlling the maximum recursion depth?

I think the right way to do it would be to add a band constraint, as done in  Fast Global Alignment Kernels by @marcocuturi. This would allow to only compute distances for pairs of observations not too far from the diagonal. This should be fairly straightforward but we haven't got around to doing it yet.

@ghannum
When I use it as the loss function of deep learning model, the following errors are shown.
Please give me some advice.
https://github.com/mblondel/soft-dtw/issues/8

@ghannum You will probably be interested in PR #9.


chore: bring across all improvements from close ofac PR

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5842   👈

This stack of pull requests is managed by Graphite.


port 50636 - change rule from UDP to TCP

changed udp to tcp for port 50636 (Secure LDAP connection for edge subscriptions)
https://docs.microsoft.com/en-us/Exchange/architecture/edge-transport-servers/edge-subscriptions?view=exchserver-2019
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Note this is a duplicate of the original pull request for a bug that was just closed. I seem to recall in 2019 that the Edge servers just did not work without manually fixing this firewall rule.
"Edge subscriptions are failing because we are allowing only UDP but the edge subscription relies on secure LDAP which is TCP. Only UDP packets are allowed by the security group."
https://github.com/aws-quickstart/quickstart-microsoft-exchange/pull/28

/do-e2e-tests


docs(ca-samples): delete stale ca pool in test project

Adding util to delete stale resource in JDST project.

We need a similar fix for python as we hit quota there as well.

Yes, working on it. Will send it for review once done. Thanks


require a pec code

plzzz provide the pec id for image drive<EMAIL_ADDRESS>

Please provide the pec id for image drive<EMAIL_ADDRESS>


Fix corner IDs

Changes from https://github.com/srobo/competition-simulator/pull/117 stopped the controllers from recognising the corners

Hrm. Is there another identifier we should be using here? Ideally one which isn't going to change.


Make some settings persistent between bootings

Description of the new feature / enhancement
Some features on the PowerToys utility are needed all the time I use my computer. These features should have an option to make them persistent between computer bootings.
Scenario when this would be used?
Every time I turn on my computer, or restart the PowerToys utility, I have to type the mouse pointer crosshair shortcut keys. It is a nuisance and this could be avoided if this setting had an option to make it the default setting. So the mouse pointer crosshair would be set every time I started my computer, automatically.
Supporting information
No response

/dup #15911 (Crosshair)
#14784 (Mouse Highlighter)


Move to get Haskell packages from CHaP

This moves the cardano-ledger repository to use CHaP, murdering most of the source-repository-packages in the process.
I tried to explain all the process differences, please let me know if it's clear enough!

I'm just going to go ahead and purge goblins and save everyone some pain.

I'm just going to go ahead and purge goblins and save everyone some pain.

Thank you!

Also use this moo:
source-repository-package
  type: git
  location: https://github.com/input-output-hk/moo
  tag: 8c487714fbfdea66188fcb85053e7e292e0cc348
  --sha256: sha256-HWxnkf6xEAFfY14QxQFU/RsQ09skzLSMKvrAB1EQstU=

I have no idea why it started complaining about it only recently.
https://github.com/input-output-hk/cardano-ledger/pull/3063/files#diff-b8ed06757045fac949c89f2139a862498ad2b6d1f82c61a31e7c91d6cf0eaa70R121-R125

Thanks @lehins , I'll update this PR with that until I kill goblins.

FWIW cabal <IP_ADDRESS> fails to compile moo but cabal <IP_ADDRESS> succeeds. So one could do
$ cabal-<IP_ADDRESS> repl --build-depends moo

to populate the cabal store. :shrug:

Some of the project file constraints can be tidied up, I'll do that in a follow up to avoid conflicts.

Just wanted to register that this slightly changes the packages that are depended on. In particular, you're now using the cardano-base that was published as <IP_ADDRESS>, rather than the precise sha you had before. Hopefully that's fine - in future if you need more changes we should just release them from cardano-base.

(rebased on goblins-removal, so hopefully this will be green now)

Was missing the just-added s-r-p for cborg, restored.

Also @JaredCorduan please let me know if the information about releasing packages to CHaP makes sense to you - let's not merge this until everyone is happy with the new workflow!

thanks @michaelpj ! I haven't had time to look over it all yet, but I will try to make time soon. The overall goal is glorious! I've added the whole team no the reviewers, so everyone has an excuse to get familiar.

@michaelpj - thank you also for the generous explanations about the index state  and niv.
Something that is not clear to me:  (sorry if it's explained and I missed it, or maybe if it's too trivial  :grimacing: )
In this new version,  what is the way of knowing what commit of a certain dependency  is used?  For example: heapwords.  I expect we're looking at the CHaP commit specified  in sources.json, so in this case:
https://github.com/input-output-hk/cardano-haskell-packages/commits/d4af732a53321a1d1760023a2fa5b3f656cc3bfd
Then the answer is  in /_sources/heapwords/<IP_ADDRESS>/meta.toml ?  Could there be several versions of this though?
And  the same in reverse: if you needed to use a certain hash of a depenency, how would you go about that?

In this new version, what is the way of knowing what commit of a certain dependency is used?

So, the idea is that mostly you shouldn't need to know commit hashes: versions should be specific enough (like on Hackage). But several people have asked about this so we'll probably do something to make it easier regardless :) For now, the answer is that you can go to CHaP and look at the metadata file specifying the package version, exactly the one you found.
You do need to be able to work out what version of the package you're using. This is now a general cabal problem, you have the same problem if you want to know what version of containers you're using. The simplest way I know of is just to run cabal freeze and take a look at the freeze file.

And the same in reverse: if you needed to use a certain hash of a depenency, how would you go about that?

I think the question is: why do you need to do this? Generally we want to get to a place where we're mainly using released versions of software. But if you do need to you can always use source-repository-package... just try not to leave it like that, otherwise we end up in a situation where we can't release packages because they depend on unreleased random commits of their dependencies (aka, the historical status quo :sweat_smile: ).

I'm gradually trying to answer questions in the CHaP readme. I'll make sure these answers get captured!


add R linting

that would be fantastic ...

@maxheld83 r u talking about this tool?

I also find this http://yihui.name/formatR/

@hd-deman thanks for getting back so quickly.
I was thinking of @jimhester's lintr package, which I find quite good.
I haven't systematically compared R linters though, I just came across (and liked) lintr, because it is already implemented for Sublime Text.
I guess formatR would be a different beast, since that actually changes (rather than lints) code.

lintr has nearly all of the functionality of the existing R linting packages, (lint and svtools were the main ones I was aware of), plus many more.
https://github.com/jimhester/lintr/issues/42 is for adding Atom integration (we already have Vim, Emacs, Sublime Text, RStudio).
It shouldn't be too much work to get Atom integration working if you base it off of the existing integrations.
I haven't done so yet because I do not use Atom myself and I wasn't sure how popular it was for R users, but at least different people have now requested it, so it is probably worthwhile.


Individual servers for parallel testing clones

I'm not sure if I have missed the documentation for this but is it possible to run separate instances of DefaultHTTPServer on the individual clones while parallel testing?

Yes, just need to start it on different ports.

Yeah this is what I added handling for in my code. Just to confirm, is this strictly error code 48?


denv.sh: webpro_REV overrides

CI is "dropping the ability to override the webpro version" https://isrhub.usurf.usu.edu/cfrandsen/VantageCI/pull/101#discussion_r148120
the question is whether the denv.sh script should do the same... should the list of locations it searches for webpro_REV be modified or adjusted in any way?
https://github.com/externpro/externpro/blob/24.11/denv.sh#L57

need to consider how the overrides are currently being used
in plugins
smanders@C00873:~/src/plugins$ grepsrc "set(webpro_REV" | grep -v .devcontainer/denv | grep -v xptoplevel | grep -v Findwebpro
HothPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
MosaicPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
TemplatePlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
ImageQualityTool/CMakeLists.txt:set(webpro_REV 23.08)
ChangeDetectionPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
SixLibCodeGenerator/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
FSGIPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
MpiqPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
PraetorianPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
NitfUtilityPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
Spytt/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
LinPiPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
CountryCodesServer/CMakeLists.txt:set(webpro_REV 24.02)
KraytPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
DFCPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
BrokerMessageValidatorTool/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)
SarConditioningPlugin/PluginLibraries/cmake/toplevel.cmake:set(webpro_REV NONE)

PluginLibraries/cmake/toplevel.cmake is doing
set(webpro_REV NONE)

to prevent webpro from being installed as part of the docker image build
-- and there are a couple plugin projects (CountryCodesServer and ImageQualityTool) that override this so a specific webpro release is used
in microservices
smanders@C00873:~/src/vantage$ grepsrc "set(webpro_REV" | grep -v .devcontainer/denv | grep -v xptoplevel | grep -v Findwebpro
MtiViewer/Libraries/cmake/toplevel.cmake:  set(webpro_REV 24.03)
StreamPlanExecutor/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.10)
RegionStore/Libraries/cmake/toplevel.cmake:  set(webpro_REV 24.03)
OverviewMonitor/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.10)
DdeExecutor/Libraries/cmake/toplevel.cmake:  set(webpro_REV 24.03)
MtiStore/Libraries/cmake/toplevel.cmake:  set(webpro_REV 24.01)
IntegrationSwatComScanOps/CMakeLists.txt:set(webpro_REV NONE)
AirComm/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.10)
vantBroker/Libraries/cmake/toplevel.cmake:  set(webpro_REV 24.03)
EmulatorService/Libraries/cmake/toplevel.cmake:  set(webpro_REV 24.03)
SensorManager/Libraries/cmake/toplevel.cmake:  set(webpro_REV 24.01)
VIVID/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.09)
MissionPlanStore/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.10)
PluginSdk/CMakeLists.txt:set(webpro_REV NONE)
RdtpSender/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.09)
AirCommScheduler/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.10)
StreamPlanScheduler/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.10)
STV/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.03)
ImageViewer/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.10)
VLite/Libraries/cmake/toplevel.cmake:  set(webpro_REV 23.10)

nearly every one of these is using a CommonLibraries that is out-of-date... anything recent of Libraries/cmake/toplevel.cmake no longer has set(webpro_REV
-- however, there are two projects here that is setting webpro_REV to NONE so webpro isn't installed as part of the docker image build: IntegrationSwatComScanOps and PluginSdk


Administrative Rights Elevation

More of an oversight then an issue. As a heavy PowerShell user using both Administrative and non-administrative sessions, it would be really helpful to be able to have the ability to open tabs as administrators in the same window. The application is great other wise and so far so good. Great work everyone :)

Thanks for the comment! This is, unfortunately, not an oversight. There's a huge thread over at #1032 detailing what's up with our run-as-admin plan. Sorry about that!
/dup #1032.


migrate to astro

Resolves #47
/claim #47

@riderx This is ready for review.

omg you are so fast ^^
i think the background of the website is not the same between here:
https://deploy-preview-48--captime.netlify.app/
and
https://captime.app/

@riderx
Right now in the codebase, I see bg-gray-900 which is leading to this. Let me know if I should go ahead and remove this?

omg you are so fast ^^

Thank you <3

Merge and paid !

Thank you man! @riderx <3


ssl/ntls: Sync NTLS extension defines with TLS

Add several missing INVALID_EXTENSION to the NTLS extension
defines (ext_defs[] array), making it consistent with TLS, i.e., same
number of extensions in the same order.
Without this fix, tls_parse_extension_ntls() and related functions may
fail because the TLSEXT_IDX_* and TLSEXT_TYPE_* don't match.

Repeated with another PR：https://github.com/BabaSSL/BabaSSL/pull/70
cc @dongbeiouba

Repeated with another PR：#70

Well, they're very different.
Currently, the NTLS's ext_defs[] is missing several INVALID_EXTENSION placeholders (e.g., the one for TLSEXT_TYPE_delegated_credential), and this breaks the assumption that the items in ext_defs[] are 1:1 mapped to TLSEXT_IDX_*.  For example, TLSEXT_IDX_extended_master_secret (14) would index the TLSEXT_TYPE_signature_algorithms_cert entry.
This PR fixes the above issue.  And PR #70 should also sync the changes to ext_defs[] in TLS to NTLS here.

Right, this is worth a fix although NTLS is not that necessary to be consistent with TLS (as NTLS is defined for an independent protocol) . But as long as we implemented NTLS based on the original TLS logic (and many libssl's APIs are shared between NTLS and TLS), so this is still worth a fix.

@InfoHunter, thank you for the review and approval.
@dongbeiouba, thank you for integrating this fix.
Already committed in 27bcaa57760282a8cd5c9d961c3105dbacec0664 via PR #70, so close this.