Waitfor keycloak

Checklist

[ ] Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md.
[ ] The values-schema.yaml file and test/** fixtures have been updated to reflect code changes.
[ ] The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file.

This PR contains fixes for:
https://app.zenhub.com/workspaces/dev-5e7e84dddc966f05a627a19b/issues/redkubes/otomi-core/483
https://app.zenhub.com/workspaces/dev-5e7e84dddc966f05a627a19b/issues/redkubes/unassigned-issues/352
Moved logic for deriving openId settings to _derived property
I did test on AWS with quickstart and saw that issue with gitea is gone.
And I also observed that otomi apply is waiting for DNS record propagation.
Since these issues were caused by some race condition, I would like to ask you test it as well before merging.
Feel free to contribute to this PR to make it better;)

I updated some prop names for consistency


"2 curated CQD templates" broken link

"2 curated CQD templates" broken link

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a04f5de-2679-37c7-7d00-607471ea516d
Version Independent ID: c96ec0af-910a-d9f8-9d3b-95564b39d7fa
Content: Use CQD to manage call and meeting quality in Microsoft Teams - Microsoft Teams
Content Source: Teams/quality-of-experience-review-guide.md
Service: msteams
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

@almaucla thank you for pointing this out and helping to improve Microsoft Docs. Could this be the correct link - https://www.microsoft.com/download/details.aspx?id=102291&msclkid=ab588574b4df11eca4800ecd117389fe


! pattern in .gitignore

".gitignore" file:
*.log
!/test/aaa.log

After you create the file "/test/aaa.log", you'll find the filename is displayed as ignored (gray), which is incorrect.

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/tree-view/issues/196. You may want to subscribe there for updates.  Also, for future issues it would be super helpful if you can fill out the issue template since it helps us triage issues.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Ensure Ignition support is PR-blocking for all providers

We want to ensure people can't easily break Flatcar support in CAPI without noticing. This is especially important since Ignition-based distros are a minority.

[ ] CAPV
[ ] CAPA
[ ] CAPZ


ADO Extension Staging Validation 1.1.0

Details

Motivation

Context

Pull request checklist

[ ] Addresses an existing issue: Fixes #0000
[ ] Added relevant unit test for your changes. (yarn test)
[ ] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[ ] Ran precheckin (yarn precheckin)
[ ] (after PR created) The Accessibility Checks (pull_request) check should fail. All other checks should pass.

Codecov Report

Merging #941 (5507da6) into main (5b378ed) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 5507da6 differs from pull request most recent head b0bfb77. Consider uploading reports for the commit b0bfb77 to get more accurate results

@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage   89.02%   89.02%
=======================================
  Files          42       42
  Lines         957      957
  Branches      120      120
=======================================
  Hits          852      852
  Misses        105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b378ed...b0bfb77. Read the comment docs.


KEP-29: Introducing operator dependency cycle detection to the instance controller

Summary:
Operator dependencies cycle detection is now part of the instance controller reconciliation. We execute the check for the top-level instances only since the lower-level instances are already take care of.
Signed-off-by: Aleksey Dukhovniy<EMAIL_ADDRESS>(cherry picked from commit d01b859391f354c86567ef7dfe1ceac1fa26f3a4)
Fixes #1513

This was already reviewed and approved but was accidentally merged against master.


Only replace bare URLs with HTML links.

The previous URL-matching regular expression would also operate on
URLs within existing HTML anchor tags, resulting in broken markup.
To do this, we use the more advanced (?<!a)b "lookbehind" syntax.
sed doesn't support that so we need to use Perl instead.

With two perl -e calls, it's probably worth considering whether this script should be rewritten in Perl.

Completely agree - I think a rewrite would be totally appropriate at this point.


TF2: Opening a VTF file that was once open makes it no longer open

Describe the Bug
When i try to open the file, it says that programs are using it but they arent as tf2 is closed and the files are in a different directory
To Reproduce

Try to open the app.
It wont open

Operating System
Linux Mint (Ubuntu Based)

So if I'm reading the title right, this happens if you open a VPK, close it, and then open it again?

No? If i take a vtf from the currently loaded sprays folder in tf2, close tf2 and try to open the sprays i saved (tf2 auto deletes sprays once the game closes) they dont open

I have a similar issue, but I'm on Windows and i VPKEdit just wont open, not even vpks wont open.

I don't know how to reproduce this, if you provide clearer instructions that I can follow on my own PC I'll reopen the issue.

Okay look, i know im REALLY late but i finally got around to recording what happens. Basically, if i take a spray out of the 'temp' folder in tf2 and then close tf2 and try to open it, it refuses to open
2024-07-24 01-59-04.zip

i would've told you what to do but because of a reason that sounds hateful towards myself and others i would rather not say it

You're mixing up VTF and VPK. That is a texture file.

I will eventually make an application that can open any generic Valve format, but now is not that day - VPKEdit can only open archives such as maps (BSPs) or VPKs

You can use this application to open VTFs on Linux

i actually dont know how to compile this but i'll figure it out myself

It has published releases, they're marked as prerelease so they won't show as releases on the main page

sorry for asking this but how do i execute it?

Download the executable from the releases page and run it


want to add sudoku solver solution #LEETCODE

I want to add solution of Sudoku Solver Leetcode using Backtracking .
Leetcode Question link : https://leetcode.com/problems/sudoku-solver/

Approach: I moved in my grid and check if I can place a number there or not . If we can pace we will place a number and move to next grid and if we cannot place any number  we will backtrack and replace a number in our last cell with any other suitable
number.
Please do assign it to me!!

Please assign this issue to me.


Volume's ownership and permissions changed when running containerd as Kubernetes CRI

Description
This bug reveals unexpected modifications to a directory's permissions made during the container's runtime. Refer to this Dockerfile that specifies a directory, which is symlinked, has it's ownership changed and mounted as a VOLUME during image build time.

This image, when run as a container on dockerd as runtime (both independent of Kubernetes and as a Kubernetes CRI runtime), retains the directory group and ownership as expected.
This image, when run as a container directly on containerd as runtime (independent of Kubernetes), retains the directory group and ownership as expected.
However, when the image is run as a container in a Kubernetes cluster where containerd is the CRI runtime, the group and ownership permissions are unexpected.

Testing was done using:
Kubernetes 1.20 (EKS)
containerd 1.4.6
docker 20.10.8
Complete details at https://github.com/anusha-ragunathan/cri_difference
Steps to reproduce the issue
https://github.com/anusha-ragunathan/cri_difference
Describe the results you received and expected
I expect the directory permissions and ownership from the Dockerfile to be preserved during runtime.
What version of containerd are you using?
containerd-1.4.6-7.amzn2
Any other relevant information
Issue also occurs in containerd versions 1.4.12 and 1.5.9
Show configuration if it is related to CRI plugin.
No response

cc @dmcgowan

This is fixed by https://github.com/containerd/containerd/commit/8acbb276477c8353ddb7551b58cb3fdeb0b13caa and is fixed in containerd-1.4.6-8.amzn2

Thank you for confirming.

Thanks @Kern--! Resolving.


Question about manipulation of the local data matrix in the BAR example

Hi Paul,
Thanks so much for making this code available! I'm working with the R version of your code, but I have a question about the way you manipulate the "local" data matrix, as in the code block from your example below:
BAR_local %>%
    select(-sh_ind_) %>%
    mutate(ind = str_glue("t{year}_init_sh_ind_{ind}")) %>%
    spread(ind, init_sh_ind_, fill = 0) %>%
    print() -> BAR_local2

Why do you fill the init_sh_ind_ variable with zeros for the non-initial year entries? So your initial shares come from the year 1980, but you rework the data matrix so that the initial share is set equal to zero in all non-1980 years. Why are the shares not set equal to the initial shares in all years? Afterall, this is how the original data matrix is constructed.
Thanks for the help, and thanks again for the code! Very helpful!

Maybe I will let Paul expound on the design decision later, but the effect of the code is to generate the interactions between year dummies and the initial industry shares. For example, if I limit to industry no. 100, the code produces the following:
library(bartik.weight)

BAR_local %>%
    arrange(czone, ind, year) %>%
    select(-sh_ind_) %>%
    mutate(ind = str_glue("t{year}_init_sh_ind_{ind}")) %>%
    spread(ind, init_sh_ind_, fill = 0) %>%
    select(czone, year, contains("ind_100"))

#> # A tibble: 2,166 x 5
#> czone year      t1980_init_sh_ind_100 t1990_init_sh_ind_100 t2000_init_sh_ind_100
#> <dbl> <dbl+lbl>                 <dbl>                 <dbl>                 <dbl>
#> 1  100. 1980                    0.00276               0.                    0.
#> 2  100. 1990                    0.                    0.00276               0.
#> 3  100. 2000                    0.                    0.                    0.00276
#> 4  200. 1980                    0.00290               0.                    0.
#> 5  200. 1990                    0.                    0.00290               0.
#> 6  200. 2000                    0.                    0.                    0.00290
#> 7  301. 1980                    0.00111               0.                    0.
#> 8  301. 1990                    0.                    0.00111               0.
#> 9  301. 2000                    0.                    0.                    0.00111
#> 10  302. 1980                    0.00388               0.                    0.
#> # ... with 2,156 more rows

The corresponding Stata code is about here: https://github.com/paulgp/bartik-weight/blob/master/code/example_BAR.do#L25-L62.
These variables are being used later as a vector of IVs (https://github.com/paulgp/bartik-weight/blob/master/code/example_BAR.do#L85):
bartik_weight, z(t*_`ind_stub'*)    weightstub(nat1980_empl_ind_*) x(`x') y(`y')  controls(`controls') weight_var(`weight')  absorb(czone) by(year)


Eliminate an unnecessary REQUIRES executable_test line from an IRGen …

…test that just generates llvm-ir.

@swift-ci smoke test and merge


Dev/v0.5.0

Codecov Report
Patch coverage: 38.58% and project coverage change: -13.35 :warning:

Comparison is base (488104c) 82.63% compared to head (d65307d) 69.28%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #28       +/-   ##
===========================================
- Coverage   82.63%   69.28%   -13.35%
===========================================
  Files          36       59       +23
  Lines        3144     3718      +574
===========================================
- Hits         2598     2576       -22
- Misses        546     1142      +596

Impacted Files
Coverage Δ

src/algebra/adjoint.rs
0.00% <0.00%> (ø)

src/algebra/dense/block_concatenate.rs
0.00% <0.00%> (ø)

src/algebra/dense/cholesky.rs
0.00% <0.00%> (ø)

src/algebra/dense/core.rs
0.00% <0.00%> (ø)

src/algebra/dense/gemm.rs
0.00% <0.00%> (ø)

src/algebra/dense/gemv.rs
0.00% <0.00%> (ø)

src/algebra/dense/kron.rs
0.00% <0.00%> (ø)

src/algebra/dense/matrix_math.rs
0.00% <0.00%> (ø)

src/algebra/dense/svd.rs
0.00% <0.00%> (ø)

src/algebra/dense/syevr.rs
0.00% <0.00%> (ø)

... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add a verifier to parse examples.

It is easy to accidentally add example YAML that is not valid. Add a
verifier to ensure that we can parse all the root level Service API kinds.
Signed-off-by: James Peach<EMAIL_ADDRESS>

/ok-to-test

ping @robscott

Thanks!
/lgtm
/assign @bowei

ping @bowei

/lgtm
/approve

/lgtm
/approve


Fix MAUI windows crash on start up in release mode

Description
Addresses an issue that looks like a MAUI issue. Issue is with using binding for OnPlatform attribute.
Summary of the change and any relevant info.
Added a new property to handle visibility of favorite icon.
Type of change

Bug fix
New sample implementation
Sample viewer enhancement
Other enhancement

Platforms tested on

[ ] WPF .NET 6
[ ] WPF Framework
[ ] WinUI
[ ] MAUI WinUI
[ ] MAUI Android
[ ] MAUI iOS
[ ] MAUI MacCatalyst

Checklist

[ ] Self-review of changes
[ ] All changes work as expected on all affected platforms
[ ] There are no warnings related to changes
[ ] Code is commented and follows .NET conventions and standards
[ ] Codemaid and XAML styler extensions have been run on every changed file
[ ] No unrelated changes have been made to any other code or project files
[ ] Screenshots are correct size and display in description tab (800 x 600 on Windows, 600 height mobile screenshots for MAUI)

Needed to rebase from main..closing this PR


Game crashes often when pressing CTRL or SHIFT

Hi there, I found my game crashes easily when pressing CTRL or SHIFT. Here's the crash report with only Fabric API and Astromine.
It is worth mentioning that I am a Chinese player, so I need to switch the input method to English every time I enter the game
Game Version: 1.16.4
Astromine version: 1.12.0
Fabric API version: 0.29.0
crash-2020-12-31_23.32.47-client.txt

still crashing i tryed update all of my mods with current version:
i have
Game version 1.16.4
Astromine (complete) version: 1.11.4
Fabric API: 0.29.1+1.16
even when i am in main menu or othet tab when i hit SHIFT or CONTROL in whatever combination its crashing instant.
and gisve the same crash log (but with diffrent mods) but when i disable this mod it works normaliy again
hompfully its get fix or any rply soon ;)
this is my crash log tho if he needs someting else just ask <3
crash-2021-01-03_14.48.02-client.txt
-- insulin

still crashing i tryed update all of my mods with current version:
i have
Game version 1.16.4
Astromine (complete) version: 1.11.4
Fabric API: 0.29.1+1.16
even when i am in main menu or othet tab when i hit SHIFT or CONTROL in whatever combination its crashing instant.
and gisve the same crash log (but with diffrent mods) but when i disable this mod it works normaliy again
hompfully its get fix or any rply soon ;)
this is my crash log tho if he needs someting else just ask <3
crash-2021-01-03_14.48.02-client.txt
-- insulin

I confirm I have the same crash problem.

I confirm I have the same crash problem.


Allow manual processing of the queue

I can't find any option to avoid the crawler to process the queue automatically. I want to be able to fill the queue and then process it.

why don't you process before appending to queue?

In the case you have items to push in the queue but you need a process to be finished in order to process the queue.

@Maxwell2022 I'm going to fork the repo and finish the events.

@Maxwell2022 Hey, guy, we are adding request and schedule events to crawler, in which stage I think you can do your work, please see 1.0.0-beta for more details. Let me know if you have any question.

please see the new released version, if further questions just reopen this issue.


Goto definition doesn't work

Hello, I've been searching for a while how to resolve this issue but I didn't find any solution. The issue, probably, is in the pylance but I'm not sure. I'm trying to override django's Serializer class

On the image you can see an error "_value_from_field: Unknown". I cannot go to definition of this method it just doesn't see down the inheritance in PythonSerialiser

I'm importing Serialiser class as following

from django.core.serializers.json import Serializer as JSONSerializer

class Serializer(JSONSerializer):

    def handle_field(self, obj, field):

        value = self._value_from_field(obj, field)

        return value

Could it be resolved by configuring pylance?
PS: django version 3.2.5

django/core/serializers/base.pyi stub for 'Serializer doesn't expose that private function
https://github.com/typeddjango/django-stubs/blob/56f9300d0d73787546b3dbcc4a589c98f3164993/django-stubs/core/serializers/base.pyi#L31

Thank you, seems like I have 2 options, generate pyi files on my own for each module or use pycharm😅. Thank you, you saved my time!!!


Require-Tree: refactor or replace with dependency or both?

In core/server/ there's a file called require-tree.js which will load a directory of directories or files and also has some code for parsing a package.json file.
It's used mainly for loading content/themes and content/apps, figuring out what's in there and whether it's valid (hence the lumping together of package.json stuff). It's a bit of a mishmash of directory-reading code & validation / messaging.
It's also (kinda weirdly) used to load all the model files in core/server/models/index.js.
Essentially, it seems to me to be a bit of an iceberg - it points at a whole bunch of stuff that could be refactored & cleaned up. Every time I look at it I end up on an Alice-in-Wonderland style tour of bits of our codebase that need cleaning up - but it's very, very difficult to break down into small well-spec'd issues.
Perhaps we should replace some of the directory-reading bits with dependencies, and put custom tools in core/server/utils, or perhaps we should look more carefully at how to group together code that deals with themes and apps.  I'm sure there are modules out there for reading directories, and I've seen one for validating package.json files.
If we do need our own tools they should probably be in core/server/utils and be unit tested.
I'm sure there are small bits that can be teased easily out, so I thought I'd leave this issue here as a route in to finding things to improve and an issue to tag against in PRs.

Looked at package-json-validator, a package that powers package-json-validator.com - it would be easy to replace our validations with that package. Sadly the latest version on npm has a bug where it requires the author field to be present (PR is already merged).
Otherwise, usage of  readDir and readAll is scattered throughout the code base. Definitely opening portals to Narnia when trying to refactor that stuff. We already depend on glob, so we could use that to traverse directories.
The problem with both those functions is that they do more than their name makes clear.

The problem with both those functions is that they do more than their name makes clear.

Perhaps that's the first thing to solve? Cleaning up the code so that isolated functions do what they say they do?

@ErisDS On that. Preparing a PR.

Result of today: https://github.com/TryGhost/Ghost/compare/master...halfdan:feature/refactor-require-tree - cleaning up/opening PR tomorrow.


Fix Fn::ImportValue validation

template example:
AWSTemplateFormatVersion: '2010-09-09'

Resources:

  MyEC2:
    Type: "AWS::EC2::Instance"
    Properties:
      ImageId: ami-1111111
      InstanceType: t2.medium
      SubnetId: subnet-1231231
      KeyName: something
      SecurityGroupIds:
      - Fn::ImportValue: some-export-id
      IamInstanceProfile: some-profile

Issue:
[1] % perun validate test.yml
INFO: Configuration file from the following location will be used: /Users/mpolcik16/.config/perun/main.yaml
INFO: Creating new session. Profile: aol Region: us-east-1
WARNING: MyEC2: SecurityGroupIds[0] <--- is nil.

Perun is not respecting Fn::ImportValue and it's deciding it is nil, when in fact it is a valid value.
Expected behaviour: validation should pass.

 Fix Fn::ImportValue validation

closed by #174


DynamoDB Unmarshal Performance Improvements

Description
Improves performance and memory consumption of UnmarshallerContext.TestExpression(...)
Motivation and Context
Performance profiling shows this as a hotspot in our dynamodb-heavy application.
Testing
I ran the DynamoDB Integration tests.
Screenshots (if appropriate)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

We can't take this PR in its current state. AttributeValueUnmarshaller.cs is a generated file, so any changes that you make to it will be overwritten next time we generate the SDK, which is almost daily.
Changes to unmarshallers need to be made in the code generator, and these changes will impact other, non-DynamoDB and non-AttributeValue unmarshallers. So that's going to be a rather large change, and much riskier for us to take.
There really isn't a good way to replace a single unmarshaller in the SDK (for instance, we use AttributeValueUnmarshaller in other places), that aspect isn't as modularized as the rest of the SDK. For now, I think your best approach would be to fork this project and make these changes locally.

I see. @PavelSafronov Can you take https://github.com/aws/aws-sdk-net/pull/715/commits/8d89511c382bd737ff73dcf3f0846ffb939675b9 without the AttributeValueUnmarshaller change?

Yes, that is a reasonable and small change. Though I would recommend moving the EndsWith call to be the final check, so the less-expensive range and char-equality checks are done first.

ah. good idea. I'll do that an re-submit. thanks.


Delete all the guidance to use the public mosquitto broker.

We do not have service level guarantees on the public broker, so it not recommended to have customers use the third party host.
We tell customers they can use the public broker, but then we tell them that it is unstable. It is better to not tell customers at all to use it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The instructions for the plain text demo connects to Mosquitto (https://www.freertos.org/mqtt/preconfiguredexamples.html), but we need words that describes how this is done to experiment with the MQTT protocol to make sure body sends private data and to make it is clear that production devices should never use an unencrypted connection (as per the red text on the link).


Can Read the Docs generate py-modindex.html?

Details
I'm trying to get Read the Docs to generate the py-modindex.html file. I've tried posting this question to Stack Overflow and linking to it on the #python IRC channel. At this point I'd like to know if what I'm trying to do is even possible and if so how to make it happen. Research into this question lead me to the following setup:

setup.py in the project directory has the following contents, which were the minimum needed to get pytest to work and haven't been changed since I got that part of my project working:
import setuptools

setuptools.setup(
    name='polygons',
    packages=setuptools.find_packages(),
)

docs/requirements.txt contains a single line:
sphinx-autodoc-annotation

The Read the Docs repository URL points to my GitHub repository.

The RtD setting for "Install your project inside a virtualenv using setup.py install" is checked.

The RtD setting for "Requirements file" points to docs/requirements.txt.

The "Module Index" link gets included in index.html, but the py-modindex.html file is missing.
My understanding is that with the virtualenv setting above, RtD will use the setup.py file to install the project so that Sphinx can read the documentation found in the Python docstrings. I'm using function annotations and would like sphyinx-autodoc-annotation to make use of those when creating the built docs files. All of this works splendidly on my local machine when I run make html while in the docs folder. Now I'm trying to get it to work on Read the Docs.

Note: This is an exercise I'm going through to understand everything before I apply it to my real project, which the polygons project is a placeholder for.

Project URL: http://polygons.readthedocs.io/en/latest/
Build URL (if applicable):
Read the Docs username (if applicable): chivalry

Expected Result

Read the Docs would generate the py-modindex.html file as Sphinx does when used locally.

Actual Result

py-modindex.html is never generated on Read the Docs

Is what I'm trying to do here possible? Even just letting me know that will allow me to move forward knowing that this isn't supported.

Hi @chivalry , I'm having the same problem and it looks a lot like:
https://github.com/rtfd/readthedocs.org/issues/1114

There are some warnings in the build process https://readthedocs.org/projects/polygons/builds/4345860/ (6th step). It's because of the python version. Your project is using type annotations, which are available only in python3. You can change the python version in the admin section of your project.


Added standart user input to README and instructions.

standard

also may wanna indicate 1 per line here too

also may wanna indicate 1 per line here too

Are they anyhow separated? I think they are not.

Should be all good now

not a fan of "standard user input" and "input"
just use "stdin" or "standard input"
and yes newlines are just passed through to piston so no "1 per line" required

not a fan of "standard user input" and "input"
just use "stdin" or "standard input"
and yes newlines are just passed through to piston so no "1 per line" required

Changed all to "standard input"


declare and use class Suggestion

https://docs.google.com/document/d/1qJ4_4At76HfEsJg398yLPnsz_s9Cq0BquRy7XKlosQY/edit#

Addressed comments, merging. Thanks!


docs: create "add a linked ssh key", "deploy ssh key" articles and modify "link ssh key"

Description of change
Creates two new articles: "Link SSH Key" and "Deploy SSH Key". Modifies "next" link of "Add an SSH Key" to point to new "Link SSH Key" article. The goal is to clarify that after the creation of an SSH Key, it has to be deployed to a server. But first, the server must be linked to the key.

@cla-bot check

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @brlipi on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Hello @brlipi! 👋
Welcome to Devopness open source projects!
The user brlipi has been added to our allowed contributors list.
Thank you 💖 and congrats 🎉 for opening your very first pull request in this repository.
Our team will review your PR in the next few days.
Hope you have a great time contributing and learning around here! 😄


Fix header search on smaller screens

On smaller screens (smartphone/tablets) search bar should disappear and be replaced with search icon - same way it is working right now on https://flathub.org/

Can you point out, why that would be preferable?

To be clear, search works fine like it is atm. It's just different to the old page.

This might become necessary, as soon as we move the login to the header unless we can remove one of the other header items.


Add some indexes to SQLite tables

Added LOCATION_KEY index bath weather_values and weather_conditions tables.
LOCATION_KEY is used selects/joins with both tables.
In example case this has no real performance effect,
but it's always good habit to have indexes for most commonly used queries.

Thanks Jukka!  Doug


[Orchestrator] update code structure

What does this PR do?
Update code structure for orchestrator check, this PR is required by https://github.com/DataDog/datadog-agent/pull/22060

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Sorry about the noise

/merge


Optionally add sectionpages to search-index

This PR addresses the following issue:
On our website we have a structure like:
├── tropic-1
│   ├── detailed_article-1.1
│   └── detailed_article-1.2
├── topic-2
...
We have content the regular pages (leave nodes) and the section pages (inner nodes).
The search-index build by the search module only collects the regular pages and not the section pages.
This makes the section-pages unsearchable.
This PR solves this by also collecting the section pages if the search.include_section_pages param is set.

Maybe this should not even be optional?


[Feature Request] enable contact book payment experience

As a user I would like to manage a contact list in my wallet to have the following payment experience:

select contact
enter payment amount
click send

To add a new contact the user would scan the node pubkey of a friend and enter the name of the friend. The wallet would call LND to persist the new entry in his contact book.
Implementing the contact book inside LND would have the benefit that the data is available for all the connected devices of the user.
I personally use a phone, desktop and browser wallet and managing my contacts for 3 or more different devices would not be a nice user experience.
If the contact book functionality would be implemented without LND for persistence, all 3 wallet providers would need to implement a common way of syncing the contact data using a service like Google Drive or Dropbox and the user would need to configure and grant 3 times a permission.
LND would need an additional endpoint like /contacts that supports GET, POST and DELETE requests:
{
    "contact_name": "My best friend",
    "contact_pub_key": "02788242941915ed5a101511b8dfeb6db81e0fcd7546f6a55ef4dedf590a7d7ff4",
    "contact_category": "Friends"
}

As far as I'm aware making invoiceless payments should be possible soon because of the "key send" proposal (https://github.com/lightningnetwork/lnd/pull/2455)
The ZAP wallet would be interested to experiment with such a contact list feature.

Great suggestion. In the past I suggested something like this to Breez lightning wallet, see my suggestion: https://github.com/breez/breezmobile/issues/104


IGNITE-2893 Atomic structures use entry processors instead of transactions

https://issues.apache.org/jira/browse/IGNITE-2893 is resolved, closing PR


DBZ-3238 Snapshot fails when reading TIME, DATE, DATETIME fields in mysql from ResultSet

DBZ-3238
Read the return value of mysql according to different protocols

CC. @gunnarmorling @jpechane
I have rebase my commit, but test still fails. What should I do?

cc. @gunnarmorling @jpechane
I have rebased my commit, and formatted the code, but test still fails.. What should I do?

There still seems to be a formatting issue; please run mvn process-sources to ensure that part is taken care of. Other than that, there are few intermittent test failures on CI unfortunately.

@gunnarmorling Sorry, I'll fix it in MySqlSnapshotChangeEventSource immediately.

Hi, @gunnarmorling I fixed this on both the legacy and current implementations, could you help to review this again? Thanks.

@jjiey Could you please reformat the code? Use mvn process-sources

Hi, @jpechane Thanks for your suggestion.
Just finished, and I rebased all my commits. Finally the test succeeded.

@jjiey Applied, thanks a lot for nice improvement!


Open File Looking bad on dark theme

code-server version: code 1.32.1
OS Version: Ubuntu 18.04

Description
The file open menu doesn't look proper
Steps to Reproduce

Set dark theme in settings 	"workbench.colorTheme": "Solarized Dark",
Open file menu

@andreimc set theme URL pls

@avelino what do you mean ?

I think he means post a link to the extension for the theme (if you were using one) @andreimc

Will be fixed in new release.

has been fixed


Terminal Example

probably a simple oversight, but trying to run your terminal example i get the following error:
AttributeError: 'ChatBot' object has no attribute 'get_input'
have successfully imported the module and 'dir'd around the objects a bit, but can't see a get_input method anywhere. do i need to explicitly import Terminal?
thanks!

Sorry, this is because the version of ChatterBot on PyPi is behind the version of ChatterBot on master. I plan on doing a release of the next version of ChatterBot within the next week. Until then I recommend downloading the current copy of the repo from github, and installing it locally via pip install . --upgrade.
I apologize for the inconvenience, I hope this solution helps.

great. that's done it.  sorry if that was documented elsewhere.  keep up the good work!


Ruff extension for Visual Studio Code not show error E501 (line-too-long)

I am using Visual Studio Code Insider, version 1.85, in Fedora Linux version 39.
Don't matter what config I set, never shows when the line exceeds de configured limit. The other features in RUFF work well.

We actually don't enable E501 by default. Are you enabling it in your configuration file?

@charliermarsh I have found 1 case when ruff does not raise E501. Pls tell me if I should create new issue for that.
This is steps to reproduce.
I have 2 modules: other.py and test_new.py
other.py
def very_very_very_long_function_name(attr: int):
    pass

test_new.py
"""docstring."""

import logging

import other

logging.info("first long")
other.very_very_very_long_function_name(9)
logging.info("second long")

ruff.toml
target-version = "py312"
line-length = 17

[lint]
select = ["ALL"]

[lint.pydocstyle]
convention = "google"

ruff --version
ruff 0.5.1

python --version
Python 3.12.2

command
ruff check --config ./ruff.toml --output-format concise ./test_new.py

output
test_new.py:7:18: E501 Line too long (26 > 17)
test_new.py:9:18: E501 Line too long (27 > 17)
Found 2 errors.

Expected behavior
3 violations of E501
Actual behavior
2 violations of E501

@Denis-Alexeev The problem here is that the line 8 contains no whitespace (see the rules documentation).
I think we could do better here now that is kind of cheap to get the tokens at a specific offset by only applying the exception rules if the range falls into a string (wdyt @charliermarsh )?

@MichaReiser Oh, I guess I've misread the first exception. I always thought, that it is about exactly one word. Now I see that the word "word" has quotation marks 😄


Sentinl for Kibana 6.4 : impossible to migrate "wizzard watcher" to "advanced watcher"

Sentinl and Kibana version
Sentinel for Kibana 6.4 and Kibana 6.4.0
OS : Windows 10 (but I don't think it is tied to OS)

Issue description
If I create a new watcher using "wizzard" and then save it, when I go to "Watchers" list, I don't see the "convert to advanced watcher" link.
This feature was available in Kibana 6.2 and was greatly useful !

I have never used previous versions of Sentinl, but I use the feature you're describing; if you go to edit the Wizard watcher, then go to Match Condition section => Click "Chart Query" => Just above the textarea you'll find a link that says "convert to advanced".
Is that what you're looking for?

Hi @rasmusdencker
Thanks for the tip, that is what I looked for !
I must admit the link is quite "hidden" and tricky to find, compared to previous version.

Get the latest release with fixes here https://github.com/sirensolutions/sentinl/releases/tag/tag-6.4.2-0

@sergibondarenko
After test, I don't see any change for this issue  :

in watchers list screen, there is still no link to convert a wizzard to an advanced watcher.
but there is still the link "Convert to advanced" in the "Watcher query" tab

@fbaligand the link was not moved. I'll do it in the next iteration


Dxp 1074 remove prefix cutting from page path

remove prefix cutting from page path
Description
Once key rewrite Mechanism is done there is no need to cutting prefix from pages.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue) labeled with bug
[x] New feature (non-breaking change which adds functionality) labeled with enhancement
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code standards of this project.
[ ] My change requires updating the documentation. I have updated the documentation accordingly.

I have read the Dynamic Solutions Individual Contributor License Agreement (CLA) Document and I hereby sign the CLA

recheck


ADO update logic needs improving

Information

Onefuzz version: 5:15.0
OS: n/a

When we detect a crash and need to update an ADO work item, we search to see if there is an existing item.
Current behavior that should be addressed:

If we find 1 or more items, we update them all.
When we update the work item, we update more than just the NumCount field (which is typically all we want to update).
We will re-open the bug if it's closed and we don't take into account if the bug has been marked as a duplicate.

What we want:

If we find a matching work item(s), we should not re-open bugs if they are marked as a duplicate. Continue to work through the list to find a match that isn't marked as a duplicate and re-open that one. If all that has been found are duplicates, then re-open it, but add a comment explaining why we reopened it.
Update our ado.md docs to pick a different field in config.on_duplicate.ado_fields."System.IterationPath". IterationPath is not the best example of a field to update on duplicate bugs.
If we find multiple work items that aren't marked as duplicates, that seems like there is a problem. I'm not exactly sure what we want to do in this case. This is a case of our "uniqueness logic" failing us.

AB#41842262

If we find multiple work items that aren't marked as duplicates, that seems like there is a problem. I'm not exactly sure what we want to do in this case. This is a case of our "uniqueness logic" failing us.

This is also a little difficult because the uniqueness condition is specified in the notification config; the OneFuzz user can set this in any way they like.

Update our ado.md docs to pick a different field in config.on_duplicate.ado_fields."System.IterationPath". IterationPath is not the best example of a field to update on duplicate bugs.

(As an aside, this was being set in the ingestion service, and is no longer, so IterationPath won't be reset upon update. Once again this is a notification config setting and not specified in the core code.)

If we find multiple work items that aren't marked as duplicates, that seems like there is a problem. I'm not exactly sure what we want to do in this case. This is a case of our "uniqueness logic" failing us.

This is also a little difficult because the uniqueness condition is specified in the notification config; the OneFuzz user can set this in any way they like.

I've chosen to log telemetry for now and we can evaluate how frequently it's happening. It might make sense to notify the user that their uniqueness condition is failing.

If we find multiple work items that aren't marked as duplicates, that seems like there is a problem. I'm not exactly sure what we want to do in this case. This is a case of our "uniqueness logic" failing us.

This is also a little difficult because the uniqueness condition is specified in the notification config; the OneFuzz user can set this in any way they like.

I've chosen to log telemetry for now and we can evaluate how frequently it's happening. It might make sense to notify the user that their uniqueness condition is failing.

Per your comment here I've updated the task as "done" above.


Support for new firestore 9.x?

[REQUIRED] Describe your environment

Operating System version: winows
Browser version: Chrome
Firebase library (firebase, firebase-admin, etc...) and version: _____
GeoFirestore version: 4.4.2

[REQUIRED] Describe the problem
Upgrading to Ionic V6 and Firebase V9.x
(Upgrade from version 8 to the modular Web SDK )
I am having issues just initializing 'geofirestore.initialApp(this.firestore)'
this.firestore initialized at firestore = firebase.firestore();
Ionic 6 requires Angular ^13.0.0.
Any guidance here would be greatly appreciated.
Gary Rylander
<EMAIL_ADDRESS>

Duplicate of #219
Though to answer the question I haven't had time. If you're using the compat you can just ignore the typing error, but as for supporting modular I'll hopefully look at it over the holidays.


Spurious commands remain on the  cell after inner transaction

Summary
Problem: <k> cell is not empty after successful execution
Branch: master
Test: tests/json-scenarios/txn-created-asset-id.json
Details
Executing the test scenario txn-created-asset-id.json that creates an asset with an inner transaction:
kavm run tests/json-scenarios/itxn-created-asset-id.json --teal-sources-dir tests/teal-sources/ --output pretty

Gives the following output:
  <k>
    #deactivateApp ( ) ~> #calcReturn ( ) ~> #stopIfError ( ) ~> #saveScratch ( ) ~>
    #popTxnFront ( ) ~> #evalNextTx ( ) ~> #checkExecutionResults ( 0 , 0 ) ~> .
  </k>
  <returncode>
    0
  </returncode>
  <returnstatus>
    "Success - transaction group accepted"
  </returnstatus>
  <paniccode>
    0
  </paniccode>
...
  <activeApps>
      .Set
  </activeApps>
...

The execution finished successfully (as intended), but the <k> cell seems to contain spurious items. It looks like the inner transaction execution rules try to execute more transactions than intended.
Info that I've gathered so far is:

looking at the coverage report, I see that the #deactivateApp rule has been applied
the <activeApps> cells contains .Set --- that is intended
the #deactiveteApp rule is only introduced by the #finilizeExecution rule.

Considering all this, it looks like the #finilizeExecution is triggered more than once during the execution of this test. As far as I understand, this is an error.
This problem manifests in a larger example which I'm developing for the KAVM intro blogpost, but the existing test seems to isolate the problem rather well.

Other inner transaction tests suffer from a similar issue, therefore the debugging should probably start with itxn-basic.json

More investigation shows that the root cause probably is the itxn_submit rule:
  rule <k> itxn_submit => #incrementPC() ~> #checkItxns(T) ~> #executeItxnGroup()...</k>

Modifying the itxn-basic.teal to include an addtional err opcode after the trailing return causes this opcode to be executed.

Looking more on all this, it seems like the context management implemented by means of <txnExecutionContext> causes non-determinism in TEAL execution. When we duplicate contexts to save them while executing an inner transaction, we also duplicate the <teal> cell. I think K becomes confused about where to apply the TEAL opcodes rules: to the duplicated cell or to the original one.


Fix Upload BeforeSave Callback

fix #357

That resolved that issue, now on to
ncaught (in promise) Error: Request to upload/folder failed: upload_folder_to_dandi() got an unexpected keyword argument 'project'
    at run (utils.js:35:33)
    at async GuidedUploadPage.uploadToDandi (UploadsPage.js:32:12)
    at async GuidedFooter.onNext [as __onNext] (GuidedUpload.js?t=1694567791220:50:29)

I was seeing this before if I didn't start a new conversion. Can you try that?

I was seeing this before if I didn't start a new conversion. Can you try that?

Yep, confirmed with an entirely newly generated tutorial pipeline
Will try a non-tutorial one now

@garrettmflynn If it's any help at giving more context, I always seem to get this screen even if it is definitely the first time I've ever tried uploading this session

And yeah, same issue again in a custom pipeline once I press that 'continue with reupload' button

Okay thanks for the context. I’ll try on my end
On Tue, Sep 12, 2023 at 6:29 PM, Cody Baker @.***>
wrote:

And yeah, same issue again in a custom pipeline once I press that
'continue with reupload' button
—
Reply to this email directly, view it on GitHub
https://github.com/NeurodataWithoutBorders/nwb-guide/pull/359#issuecomment-1716799155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALDAY5LPNUOBKW4OVSIHRVDX2ED77ANCNFSM6AAAAAA4VRHC7M
.
You are receiving this because you were mentioned.Message ID:
@.***>

Alright this is fixed and merged with main

Tested both guided mode page and stand alone page - both worked great!


[DOC] please give example how to run luna/examples

Thank for your effort and keeping this repo up to date,  I get several warning when using code from the repo and I am not sure how to use it anymore.
How do I run the blinky test?
I now do the following
git clone https://github.com/greatscottgadgets/luna.git
cd luna/
python3 -m venv .venv
source .venv/bin/activate
pip install .
pip install cynthion
pip install git+https://github.com/amaranth-lang/amaranth-boards
pip install yowasp-nextpnr-ecp5
pip install yowasp-yosys
export NEXTPNR_ECP5=yowasp-nextpnr-ecp5
export ECPPACK=yowasp-ecppack
export YOSYS=yowasp-yosys
export LUNA_PLATFORM=cynthion.gateware.platform.cynthion_r0_4:CynthionPlatformRev0D4
python examples/blinky/blinky.py --dry-run

This fails, also for more recent boards.
INFO    | __init__    | Building for Cynthion r0.4...
ERROR: Module `\SGSR' referenced in module `\top.cd_sync' in cell `\U$$2' is not part of the design.
Traceback (most recent call last):
  File "/home/hstarmans/python/luna/examples/blinky/blinky.py", line 41, in <module>
    top_level_cli(Blinky)
  File "/home/hstarmans/python/luna/.venv/lib/python3.10/site-packages/luna/__init__.py", line 113, in top_level_cli
    products = platform.build(fragment,
  File "/home/hstarmans/python/luna/.venv/lib/python3.10/site-packages/amaranth/build/plat.py", line 109, in build
    products = plan.execute_local(build_dir)
  File "/home/hstarmans/python/luna/.venv/lib/python3.10/site-packages/amaranth/build/run.py", line 104, in execute_local
    subprocess.check_call(["sh", f"{self.script}.sh"],
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sh', 'build_top.sh']' returned non-zero exit status 1.

Debug_spi seems still broken https://github.com/greatscottgadgets/luna/issues/101
INFO    | __init__    | Building for Cynthion r0.4...
/home/hstarmans/python/luna/.venv/lib/python3.10/site-packages/luna/gateware/utils/cdc.py:40: DriverConflict: Signal '(sig output__sdo__o)' is driven from multiple fragments: top, top.<unnamed #3>; hierarchy will be flattened
  output = Record.like(signal)
ERROR: Module `\SGSR' referenced in module `\top.cd_sync' in cell `\U$$2' is not part of the design.
Traceback (most recent call last):
``

I couldn't reproduce the issue when running the commands you posted:
INFO    | __init__    | Building for Cynthion r0.4...
Preparing to run yowasp-yosys. This might take a while...
Preparing to run yowasp-nextpnr-ecp5. This might take a while...
Preparing to run yowasp-ecppack. This might take a while...
INFO    | __init__    | Build complete.

Could try running blinky.py again with AMARANTH_verbose=1 and post the output?


plugin.yml

Forgive my ignorance but the latest build does not include the plugin.yml. Where may I obtain this file?

Where'd you get a download that doesn't have the plugin.yml file?

I forked your source....

2.0 is for Sponge. Sponge does not use the plugin.yml...

Ahhhh...Thank you very much! I look forward to your Spigot release then.


Revoke all tokens of resource

Is there any method to remove all tokens of specified resource?

@ionull not in guardian, but if you're using guardian db you can just do a delete on the table where sub = The serialized subject string

@hassox make sense, thanks.


Upgrade pip packages

Fixes #3127
Upgrade following pip packages:
Production requirements

Sentry = 1.9.5 - 1.14.0
Babel = 2.9.1 - 2.11.0
boto3 = 1.26.27 - 1.26.57
celery = 5.2.2 - 5.2.7
django-anymail = 8.4 - 9.0
django-bleach = 3.0.0 - 3.0.1
django-countries = 7.2.1 - 7.5
django-extensions = 3.1.5 - 3.2.1
django-file-form = 3.4.1 - 3.4.3
django-fsm = 2.8.0 - 2.8.1
django-hijack = 3.1.4 - 3.2.6
django-redis = 5.1.0 - 5.2.0
django-salesforce = 4.0 - 4.1
django-select2 = 7.9.0 - 8.0
django-slack = 5.17.7 - 5.18.0
django-storages = 1.12.3 - 1.13.2
django-tables2 = 2.4.1 - 2.5.1
django-tinymce = 3.4.0 - 3.5.0
djangorestframework-api-key = 2.2.0 - 2.3.0
djangorestframework = 3.12.4 - 3.14.0
drf-yasg = 1.20.0 - 1.21.4
mailchimp3 = 3.0.16 - 3.0.17
mistune = 2.0.3 - 2.0.4
more-itertools = 8.12.0 - 9.0.0
phonenumberslite = 8.12.39 - 8.13.4
Pillow = 9.3.0 - 9.4.0
tablib = 3.2.1 - 3.3.0
xmltodict = 0.12.0 - 0.13.0
Dev requirements
django-debug-toolbar = 3.6.0 - 3.8.1
dslr = 0.3.1 - 0.4.0
ruff = 0.0.206 - 0.0.236
model-bakery = 1.7.0 - 1.10.1
pytest-xdist[psutil] = 2.5.0 - 3.1.0
responses = 0.21.0 - 0.22.0

Overall looks good to me, most of these are minor/patch releases.
We can try to upgrade Django once wagtail 4 (https://github.com/HyphaApp/hypha/pull/3045 ) is merged.


Cannot get map.xml from electron

I would like to use traviso in electron app. So when I try to get map.xml I get error "cannot getElementsByTagName of null"
So responseXML is null,but response has all needed data

Hi @Chank1e,
Couldn't replicate the issue but I was in the process of ditching XML anyway so I thought I might as well finish that before responding to you properly :)
Repo, docs and the tutorials have now been updated with the new version where traviso uses json file in order to load the data. Please, have a look and let me know if this fixes your problem.


CompletableFuture's broken in 1.2 Snapshot

I've been using the latest 1.2 Snapshot to test the new schema inspections and just noticed all my tests are failing because any Controllers that return a CompletableFuture are not being serialized correctly:
{
    "data": {
        "version": "java.util.concurrent.CompletableFuture$MinimalStage@19eceb24[Completed normally]"
    }
}

This is using Spring Boot 3.1 RC2 but then adding in spring graphql with the 1.2 Snapshot:
    <dependency>
      <groupId>org.springframework.graphql</groupId>
      <artifactId>spring-graphql</artifactId>
      <version>1.2.0-SNAPSHOT</version>
    </dependency>

If i downgrade back to Spring boot 3.1 RC2 (Which looks like it uses spring graphql 1.2-RC1) the issue goes away and works as expected.

Since I've been using the 1.2 snapshot I'm pretty sure it was working normally until today so I'm guessing this commit might have broken it since it's appears to change DataFetcher behaviour:
https://github.com/spring-projects/spring-graphql/commit/0a411042262a4f8447bc581719ceab19b7293809

Yes sorry, I've noticed that as well this morning and I've got a fix coming up. I'll close this issue in favor of reopening #676, again.


Debugger stopped working under Mac OS

Hi,
i have a strange bug under Mac OS, VS is Version: 1.43.1
The debugger stops as intended but I cannot step into or out and I cannot examine anything.
If I start a complete new VS Code environment from another directory and load the same virtual environment and debug the same code, everything works... But using my typical directory with "code ." I cannot debug anymore.
Kind regards, Dirk

OK i deleted everything under "Überwachen" (Inspect ?) and it works again, seems to many items will crash the debugger?

@DHOFM is it possible to share your project. Also, any details on what you had in the watch ("Überwachen") window. Likely some evaluation was causing this. I will be moving this issue to debugger repo.


Add support for wide angle camera in sensors system

🎉 New feature
depends on:

#1183
https://github.com/ignitionrobotics/ign-sensors/pull/171
https://github.com/ignitionrobotics/ign-rendering/pull/490
https://github.com/ignitionrobotics/sdformat/pull/744

Summary
supports parsing and loading wide angle camera sensors
Test it
you can test with the wide_angle_camera.sdf example world:
ign gazebo -v 4 wide_angle_camera.sdf

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

is this targeting the right branch ?

yeah, this targets garden and requires the version bumps for gui, sensors and rendering done in #1183

All components (ign-rendering, ign-sensors, ign-gazebo) are working as expected. The test world is also working as expected.

I tried adding a dependencies.yaml file in 77a0f602a6f4ba208facc3bf1c68513af938f15b in branch wide_angle_camera_vcs to build ign-rendering and ign-sensors from source to see if that fixes the GitHub actions workflow CI

I tried adding a dependencies.yaml file in 77a0f60 in branch wide_angle_camera_vcs to build ign-rendering and ign-sensors from source to see if that fixes the GitHub actions workflow CI

it built ign-sensors7 successfully and ign-gazebo7 configured correctly. It later failed with an unrelated linking error due to branches being out of date with main

We need to add the wide angle camera package to https://github.com/ignition-release/ign-sensors7-release for the nightlies to work.

indeed, that's why this build is unstable:
 https://build.osrfoundation.org/view/ign-garden/job/ign-sensors7-debbuilder/58/
I'll fix it

We need to add the wide angle camera package to https://github.com/ignition-release/ign-sensors7-release for the nightlies to work.

indeed, that's why this build is unstable:
 https://build.osrfoundation.org/view/ign-garden/job/ign-sensors7-debbuilder/58/
I'll fix it

https://github.com/ignition-release/ign-sensors7-release/pull/4

CI is looking better

does this need an integration test before merging? I can find someone to add that to this branch if so

one simple integration test I can think of is to load the wide angle camera world file and make sure data are published to the topic. ign-sensors and ign-rendering already have integration tests to check the content of the published images so we probably don't need to duplicate that here.
yeah it would be nice to get some help on adding the test.

the new test failed in https://github.com/ignitionrobotics/ign-gazebo/pull/1215/commits/5612cb6b6ca85670c7e99d58e87bab92bcd02a27

https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/7838/testReport/junit/(root)/INTEGRATION_wide_angle_camera/test_ran/

looks like the test is fixed in https://github.com/ignitionrobotics/ign-gazebo/pull/1215/commits/d6a39d0a623091fe7ae46f62d6d2abeb7954d28b, though there are some unrelated cmake warnings

Still running into a segfault from using an incorrect pixel format. Currently trying to fix the error so it runs smoothly like the depth camera integration test.

the test seems to fail after writing the test_result xml file, so jenkins doesn't notice that it failed, but it does show a seg-fault in the console log. I've collected a backtrace:
[       OK ] WideAngleCameraTest.WideAngleCameraBox (5536 ms)
[Thread 0x7ffff26c2700 (LWP 995858) exited]
[----------] 1 test from WideAngleCameraTest (5536 ms total)

[----------] Global test environment tear-down
[Thread 0x7ffff2ec3700 (LWP 995857) exited]
[==========] 1 test from 1 test suite ran. (5536 ms total)
[  PASSED  ] 1 test.
[Thread 0x7ffff36c4700 (LWP 995856) exited]
[Thread 0x7ffff3ec5700 (LWP 995855) exited]
[Thread 0x7ffff46c6700 (LWP 995854) exited]
[Thread 0x7ffff4ec7700 (LWP 995853) exited]
[Thread 0x7ffff56c8700 (LWP 995852) exited]

Thread 1 "INTEGRATION_wid" received signal SIGSEGV, Segmentation fault.
0x00007fffce39dc49 in ?? () from /lib/x86_64-linux-gnu/libGLdispatch.so.0
(gdb) bt
#0  0x00007fffce39dc49 in ?? () from /lib/x86_64-linux-gnu/libGLdispatch.so.0
#1  0x00007fffcc2d0984 in Ogre::GLSL::GLSLProgram::unloadHighLevelImpl() () from /usr/lib/x86_64-linux-gnu/OGRE-1.9.0/RenderSystem_GL.so
#2  0x00007fffce86fd1a in Ogre::HighLevelGpuProgram::unloadHighLevel() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#3  0x00007fffce990028 in Ogre::Resource::unload() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#4  0x00007fffcc2d08a5 in Ogre::GLSL::GLSLProgram::~GLSLProgram() () from /usr/lib/x86_64-linux-gnu/OGRE-1.9.0/RenderSystem_GL.so
#5  0x00007fffcc2d08bd in Ogre::GLSL::GLSLProgram::~GLSLProgram() () from /usr/lib/x86_64-linux-gnu/OGRE-1.9.0/RenderSystem_GL.so
#6  0x00007fffce619752 in ?? () from /lib/x86_64-linux-gnu/libOgreRTShaderSystem.so.1.9.0
#7  0x00007fffce6156f7 in Ogre::RTShader::ProgramManager::releasePrograms(Ogre::Pass*, Ogre::RTShader::TargetRenderState*) () from /lib/x86_64-linux-gnu/libOgreRTShaderSystem.so.1.9.0
#8  0x00007fffce60288d in Ogre::RTShader::ShaderGenerator::SGTechnique::~SGTechnique() () from /lib/x86_64-linux-gnu/libOgreRTShaderSystem.so.1.9.0
#9  0x00007fffce603751 in Ogre::RTShader::ShaderGenerator::_destroy() () from /lib/x86_64-linux-gnu/libOgreRTShaderSystem.so.1.9.0
#10 0x00007fffce603abe in Ogre::RTShader::ShaderGenerator::destroy() () from /lib/x86_64-linux-gnu/libOgreRTShaderSystem.so.1.9.0
#11 0x00007fffcee0f739 in ignition::rendering::v7::OgreRTShaderSystem::Fini() () from /usr/lib/x86_64-linux-gnu/ign-rendering-7/engine-plugins/libignition-rendering-ogre.so
#12 0x00007fffcee0f902 in ignition::rendering::v7::OgreRTShaderSystem::~OgreRTShaderSystem() () from /usr/lib/x86_64-linux-gnu/ign-rendering-7/engine-plugins/libignition-rendering-ogre.so
#13 0x00007ffff7064a27 in __run_exit_handlers (status=0, listp=0x7ffff7206718 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
#14 0x00007ffff7064be0 in __GI_exit (status=<optimized out>) at exit.c:139
#15 0x00007ffff70420ba in __libc_start_main (main=0x5555555657b0 <main(int, char**)>, argc=1, argv=0x7fffffffe288, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe278) at ../csu/libc-start.c:342
#16 0x000055555556586e in _start ()
(gdb)

could there be a memory problem with one of the shaders?

The crash happens after exit. It could be that the OgreRTShaderSystem is trying to destroy its resources after ogre has already been deleted.

The crash happens after exit. It could be that the OgreRTShaderSystem is trying to destroy its resources after ogre has already been deleted.

I created an integration test for the distortion camera and I am getting the same segfault, but when I delete the following line in ign-rendering, the program exits without a segfault:
https://github.com/ignitionrobotics/ign-rendering/blob/1258280eae5834f5687ad5be78e073e73efb47a2/ogre/src/OgreRTShaderSystem.cc#L156
I think you are correct; the resources (for shaders) are deleted and then Ogre::RtShader::ShaderGenerator tries to delete them again. Removing the destroy() might cause memory leaks if there are still allocated resources but I currently don't see any other solutions if it isn't an ordering of destructors issue.

The segfault seems to occur with every test that uses OGRE1.

2 approvals and happy CI, merging!


ImageDims not triggering errors.

I tried setting up a limit for the thumbnail image but it doesn't throw and error. Error array is always empty even uploading different dimensions of image. Am I doing something wrong or this is a bug? Thank you!
   const [         openFileSelectorThumbnail,         thumbnailData     ] = useFilePicker({         multiple: false,         readAs: "DataURL",          accept: [".jpg", ".jpeg"],         maxImageHeight: 720,          minImageHeight: 720,         maxImageWidth: 1280,         minImageWidth: 1280     });

fixed in https://github.com/Jaaneek/useFilePicker/pull/19


Removed unnecessary margin-bottom from  element & fixed header line-height

Removed unnecessary margin-bottom from <a> element
<a> is pretty much always going to be a child of a <p> <blockquote> <ul> <ol>, etc. so giving <a> it's own separate margin bottom just seems really wrong.
Please let me know if there's a big reason as to why you did this. My site got pretty messed up over this and by removing it everything was fixed. I just don't see why margin-bottom of line-height-ratio would ever be needed as a base style on <a> elements.. Like ever.

Reduced the amount of line-height that header elements have
Here are 2 BEFORE pictures (the smaller the screen, the worse it gets)

And here is an AFTER (Close enough to still feel grouped but not crowded)

Here is another BEFORE & AFTER showing off an even bigger difference when having more bolded fonts

Cheers!

Definitely agree on the margin-bottom on a elements. That was a mistake.
But I'm pretty sure your header line-height commit will break vertical rhythm. Maybe we should pair up on this today?
Can you drop the commit for line-height right now and add a minor version bump and I'll merge then we can revisit the line-height thing?

Please open an issue about header line-height.

Went ahead and implemented the margin-bottom stuff.


Add view to command summary

Codecov Report

Merging #387 (5f9f9f1) into master (23bee1c) will increase coverage by 0.47%.
The diff coverage is n/a.

:exclamation: Current head 5f9f9f1 differs from pull request most recent head 49170b5.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bee1c...49170b5. Read the comment docs.


🐛 BUG: error incomplete input when executing SQL which can be exceuted by sqlite3 command

What version of Wrangler are you using?
2.6.2
What operating system are you using?
Mac
Describe the Bug
not able to deploy SQL below:
DROP TABLE IF EXISTS "Program";
CREATE TABLE IF NOT EXISTS "Program" (
	"programId"	INTEGER,
	"programUuid"	TEXT NOT NULL,
	"programTitle"	TEXT NOT NULL,
	"programDescription"	TEXT NOT NULL,
	"programIcon"	TEXT NOT NULL,
	"programDownloadKey"	TEXT NOT NULL,
	"programAuthor"	TEXT NOT NULL,
	"createAt"	TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
	"updateAt"	TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
	PRIMARY KEY("programId" AUTOINCREMENT)
);
DROP TABLE IF EXISTS "ProgramRecommendation";
CREATE TABLE IF NOT EXISTS "ProgramRecommendation" (
	"recommendationId"	INTEGER,
	"recommendationUuid"	TEXT NOT NULL,
	"programId"	INTEGER NOT NULL,
	"coverImageKey"	TEXT NOT NULL,
	"createAt"	TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
	"updateAt"	TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
	FOREIGN KEY("programId") REFERENCES "Program"("programId"),
	PRIMARY KEY("recommendationId" AUTOINCREMENT)
);
DROP INDEX IF EXISTS "Program_programUuid";
CREATE INDEX IF NOT EXISTS "Program_programUuid" ON "Program" (
	"programUuid"
);
DROP INDEX IF EXISTS "Program_programTitle_programDescription";
CREATE INDEX IF NOT EXISTS "Program_programTitle_programDescription" ON "Program" (
	"programTitle",
	"programDownloadKey"
);
DROP INDEX IF EXISTS "Program_programAuthor";
CREATE INDEX IF NOT EXISTS "Program_programAuthor" ON "Program" (
	"programAuthor"
);
DROP INDEX IF EXISTS "ProgramRecommendation_recommendationUuid";
CREATE INDEX IF NOT EXISTS "ProgramRecommendation_recommendationUuid" ON "ProgramRecommendation" (
	"recommendationUuid"
);

DROP TRIGGER IF EXISTS "Program_update_updateAt";
CREATE TRIGGER Program_update_updateAt
AFTER UPDATE ON Program
FOR EACH ROW
WHEN NEW.updateAt <= OLD.updateAt
BEGIN
    UPDATE Program
    SET updateAt = CURRENT_TIMESTAMP
    WHERE programId = OLD.programId;
END;
DROP TRIGGER IF EXISTS "ProgramRecommendation_update_updateAt";
CREATE TRIGGER ProgramRecommendation_update_updateAt
AFTER UPDATE ON ProgramRecommendation
FOR EACH ROW
WHEN NEW.updateAt <= OLD.updateAt
BEGIN
    UPDATE ProgramRecommendation
    SET updateAt = CURRENT_TIMESTAMP
    WHERE recommendationId = OLD.recommendationId;
END;

it shows:
ERROR 9009: SQL prepare error: incomplete input [code: 7500]

both on local and deploying
however, I can execute it successfully by sqlite3 command:
sqlite3 -init ./schema.sql test.db

where schema.sql contains the SQL pasted above.

@jo32 thanks for reporting this. We'll take a look.
cc: @rozenmd

@jo32 could you please try again and confirm the issue is fixed?

@jo32 I'm going to close this assuming that the issue has been fixed per @rozenmd comment. If the issue persists please reopen the issue. Thanks!

Hello, I'm experiencing this issue as well.   Simple trigger in the schema file will result in ERROR 9009: SQL prepare error: incomplete input [code: 7500].  Removal of the create trigger statement will result in the DB queries to execute just fine.  Wrangler 2.19.0.


Restrict basic user to just enqueue and submit test

A basic user should not have access to any of the admin function listed in (https://app.zenhub.com/workspaces/simplereport-5ff8be8854ae8b000e378210/issues/cdcgov/prime-simplereport/570)
A basic user should not be able to access

the persons tab
the test results tab
add person
edit person
the test results tab

the only actions available should be

search for patients
enqueue patients
updated item in queue
submit item is queue

This breaks into two parts:

detect which pages to show on the front end based on permissions in the whoami output
restrict back end endpoints based on the roles from Okta

I think we should plan to hand the client more granular permissions and not leave it up to the front end to interpret the Okta roles.

This breaks into two parts:

detect which pages to show on the front end based on permissions in the whoami output
restrict back end endpoints based on the roles from Okta

I think we should plan to hand the client more granular permissions and not leave it up to the front end to interpret the Okta roles.

Jeremy says it's done!


CSOM: Loading TermGroup ContributorPrincipalNames or GroupManagerPrincipalNames throws ServerUnauthorizedAccessException when using application context

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
It should be possible to load TermGroup.ContributorPrincipalNames and / or TermGroup.GroupManagerPrincipalNames using azure ad application permissions.
Observed Behavior
When loading TermGroup.ContributorPrincipalNames and TermGroup.GroupManagerPrincipalNames using an Azure Ad Application context the API throws: Microsoft.SharePoint.Client.ServerUnauthorizedAccessException

All other termstore read and write operations work fine. The app has all permissions needed:

Steps to Reproduce
Use the following code example.
//you do not need to load application context using this function. Just make sure you have a valid application context and not a normal user context.
var appContext = authManager.GetAzureADAppOnlyAuthenticatedContext(siteurl, clientId, tenant, StoreName.Root, StoreLocation.CurrentUser, thumpPrint, AzureEnvironment.Production);

//Enter an existing termGroup here
string groupName = "TestGroup";
var taxonmySession = TaxonomySession.GetTaxonomySession(appContext);
var termStore = taxonmySession.GetDefaultSiteCollectionTermStore();
var termGroup = termStore.Groups.GetByName(groupName);
appContext.Load(termGroup, t => t.ContributorPrincipalNames, t => t.GroupManagerPrincipalNames);
appContext.ExecuteQuery();

Hi see
https://www.techmikael.com/2018/08/modifying-terms-using-app-only-tokens.htm for a solution. Basically add app@sharepoint as a term store admin and it will work.

Looks like the link is dead. But I'll give app@sharepoint a try.

Added the missing l to the link 👍

It's working. But still very dangerous for the multi tenant isp solution we want to use this. If Microsoft changes the user principal the operation will fail again.

It's very unlikely as this was implemented back in 2013, but up to you. I use it myself in production over delegated permissions and a service account. But, it's not officially documented. @VesaJuvonen, do you think this bit could be officially documented?


Error for long non ascii paths: "only Unicode paths are supported on Windows

On windows you can get only Unicode paths are supported on Windows on long non-ASCII paths.
It is due to the following lines:
        let path = bytes2path(Cow::Borrowed(&data[..max]))?;
        header.set_path(&path)?;

in builder::prepare_header_path.
Here you're slicing bytes that contain utf-8 string without any checking for character boundary. In non-ASCII paths you can split a character in half, and so bytes2path would return an error.
I think you can just:
        let path = bytes2path(Cow::Borrowed(&b"see-in-long-name-header-extension"[..max]))?;
        header.set_path(&path)?;

instead.

Thanks for the quick fix!

Thanks for the quick fix!


[Bug]: Escape quotations when loading models.meta

Overview
When loading the models source, the column meta is loaded with the value parse_json('{{ tojson(model.config.meta) }}'). This can cause syntax errors in the compiled SQL when there are quotations in the meta value, such as in the following instance:

sample of insertSQL script for models
Here is how that meta value is represented in the model's .yml config:
version: 2
models:
  - name: table
    meta:
        grain: Each row is one week's performance data for one team, up against its goals
        description: Table used to track individual team progress toward goals

How to reproduce
Configure a dbt model where the meta property contains a single quotation, and run the model with dbt run --select <MODEL>
Expected behaviour
dbt_artifact's on-run-end hook should successfully load records into models
Environment
Results of running dbt --version:
`1.4.5`

Please paste the contents of your packages.yml file here:
packages:
  - package: dbt-labs/dbt_utils
    version: [">=1.0.0", "<1.1.0"]
  - package: calogica/dbt_expectations
    version: [">=0.8.0", "<0.9.0"]
  - package: dbt-labs/codegen
    version: [">=0.9.0", "<0.10.0"]
  - package: data-mie/dbt_profiler
    version: [">=0.6.0", "<0.7.0"]
  - package: dbt-labs/dbt_project_evaluator
    version: [">=0.5.0", "<0.6.0"]
  - package: dbt-labs/metrics
    version: [">=1.4.0", "<1.5.0"]
  - package: brooklyn-data/dbt_artifacts
    version: [">=2.3.0", "<2.4.0"]
  - package: elementary-data/elementary
    version: [">=0.7.0", "<0.8.0"]
  - package: dbt-labs/audit_helper
    version: [">=0.9.0","<1.0.0"]

Hi @waligob thanks for raising this. We have an open issue with the same concern in #258 and related PR to resolve it in #315 . We hope to have this ready to go as a new release soon. I'm going to close this as a duplicate issue, so it can be tracked in a single place.


androidctl to androidctl-sync

changes androidctl to androidctl-sync for sync command.

Ran a fresh install with this and ran it against an existing project. Good to go


Redisson should not retry on non idempotent operations

Expected behavior
Redisson should fail fast  when dealing with no idempotent operations instead of retrying.
Actual behavior
Redisson is retrying on no idempotent operations like  RDeque.pollFirst() / RPOP:
17:41:08.403 [main] DEBUG org.redisson.command.RedisExecutor - acquired connection for command (RPOP) and params [4ca54c23-b1eb-40f6-8969-6dd524894e88] from slot NodeSource [slot=0, addr=null, redisClient=null, redirect=null, entry=null] using node /<IP_ADDRESS>:34851... RedisConnection@786189680 [redisClient=[addr=redis://<IP_ADDRESS>:34851], channel=[id: 0xd467f47d, L:/<IP_ADDRESS>:59257 - R:/<IP_ADDRESS>:34851], currentCommand=null]
17:41:08.483 [redisson-timer-4-1] DEBUG org.redisson.command.RedisExecutor - connection released for command (RPOP) and params [4ca54c23-b1eb-40f6-8969-6dd524894e88] from slot NodeSource [slot=0, addr=null, redisClient=null, redirect=null, entry=null] using connection RedisConnection@786189680 [redisClient=[addr=redis://<IP_ADDRESS>:34851], channel=[id: 0xd467f47d, L:/<IP_ADDRESS>:59257 - R:/<IP_ADDRESS>:34851], currentCommand=CommandData [promise=RedissonPromise [promise=ImmediateEventExecutor$ImmediatePromise@7cda9d9e(failure: java.util.concurrent.CancellationException)], command=(RPOP), params=[4ca54c23-b1eb-40f6-8969-6dd524894e88], codec=org.redisson.codec.MarshallingCodec]]
17:41:08.484 [redisson-timer-4-1] DEBUG org.redisson.command.RedisExecutor - attempt 1 for command (RPOP) and params [4ca54c23-b1eb-40f6-8969-6dd524894e88]
17:41:08.486 [redisson-timer-4-1] DEBUG org.redisson.command.RedisExecutor - acquired connection for command (RPOP) and params [4ca54c23-b1eb-40f6-8969-6dd524894e88] from slot NodeSource [slot=0, addr=null, redisClient=null, redirect=null, entry=null] using node /<IP_ADDRESS>:34851... RedisConnection@924378696 [redisClient=[addr=redis://<IP_ADDRESS>:34851], channel=[id: 0x3b7b128c, L:/<IP_ADDRESS>:59254 - R:/<IP_ADDRESS>:34851], currentCommand=null]
17:41:08.538 [redisson-netty-2-7] DEBUG org.redisson.command.RedisExecutor - connection released for command (RPOP) and params [4ca54c23-b1eb-40f6-8969-6dd524894e88] from slot NodeSource [slot=0, addr=null, redisClient=null, redirect=null, entry=null] using connection RedisConnection@924378696 [redisClient=[addr=redis://<IP_ADDRESS>:34851], channel=[id: 0x3b7b128c, L:/<IP_ADDRESS>:59254 - R:/<IP_ADDRESS>:34851], currentCommand=CommandData [promise=RedissonPromise [promise=ImmediateEventExecutor$ImmediatePromise@642daaf(success: [consumerName=PlaceholderConsumer,eventId=6801da50-f27f-4ed2-9b31-b734e2082052,moduleName=<null>,queuedDate=2021-09-27T17:41:03.617130Z,storedDate=<null>,ttl=2021-09-27T17:40:43.617130Z])], command=(RPOP), params=[4ca54c23-b1eb-40f6-8969-6dd524894e88], codec=org.redisson.codec.MarshallingCodec]]

In the above scenario, the queue was popped twice, causing data loss.
Steps to reproduce or test case
Redis version
Any
Redisson version
Any
Redisson configuration

I agree that non-idempotent operations can't be resend after they were successfully written into connection.

Fixed! Thanks for report

Hi @EstebanignacioStorch-TomTom
It's done.


envoy: Use image that sets reuseport when needed

Use Envoy image that sets SO_REUSEPORT socket option on upstream connections when binding a source address.
Fixes: #issue-number
Cilium-envoy now sets option to allow (source) port reuse when binding to a source address of a pod for upstream connections.

/test

Merged the socket option change to cilium/proxy, now using the non-dev image here.

/test


[Bug]: Select the oracle database on the partition plan page and report ‘查询数据库版本出错’

ODC version
ODC424
OB version
Oracle430、Oralce420
What happened?

What did you expect to happen?
。
How can we reproduce it (as minimally and precisely as possible)?

New zoning plan
Select oracle database
View candidatePartitionPlanTables interface

Anything else we need to know?
No response

Data source connection problem


fix(group) rabbitmq_servers in default was not updated to new namespace.

Noting here, that it's interesting that the integration tests didn't fail without this. I probably need to dig some more and add additional tests to catch this type of failure in the future.

sensu_rabbitmq_server: true

Overrides
sensu_rabbitmq_host: "{{ groups['sensu_rabbitmq_servers'][0] }}"

Ahhhhhhh, makes sense, since we do the full integration test with just one container per Operating System.

molecule.yaml
 inventory:
    group_vars:
      all:
        sensu_master: true
        sensu_include_dashboard: true
        sensu_rabbitmq_server: true
        sensu_redis_server: true
        sensu_rabbitmq_host: "{{ ansible_hostname }}"
        sensu_redis_host: "{{ ansible_hostname }}"
        sensu_api_host: "{{ ansible_hostname }}"
        ansible_default_ipv4:
          address: <IP_ADDRESS>


Investigate  mandatory HTTPS for local traffic inside mobile apps

Android
Configuration was added inside AndroidManifest.xml file in order to specify the network security configuration (android:networkSecurityConfig="@xml/network_security_config). Inside the specified file (located at app/src/main/res/xml/network_security_config.xml) localhost is configured as a domain that is allowed to serve HTTP traffic:
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
    <domain-config cleartextTrafficPermitted="true">
        <domain includeSubdomains="true">localhost</domain>
    </domain-config>
</network-security-config>

Using this configuration, HTTPS traffic is no longer mandatory for localhost (domain on which apihub is running).


Lazy TempDir creation in DiskManager

Which issue does this PR close?
Related https://github.com/apache/arrow-datafusion/issues/1690
First part of https://github.com/apache/arrow-datafusion/issues/1690: only do IO / TempDir creation when tempfiles are actually needed in a plan
I plan a second PR to  avoid creating so many DiskManager instances in the first place
Rationale for this change
Creating temp files is expensive and now DataFusion is doing it frequently during processing (see https://github.com/apache/arrow-datafusion/issues/1690 for more backstory)
What changes are included in this PR?
Changes;
If the user doesn't specify explicit temp directories, do not create a system assigned tempfile unless it is actually requested
Are there any user-facing changes?
less tempfiles!

cc @yjshen

If I read our code correctly. when executing a plan, we need to create RuntimeEnv where will create a DiskManager instance. So I can't understand if there will be so many DisManager instances?

@xudong963  I think (non obviously) there are several more surprising places which create a DiskManager instance today -- for example https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_optimizer/pruning.rs#L132

https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/datasource/listing/helpers.rs#L244
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/optimizer/simplify_expressions.rs#L293
two more.

two more.
I think the main reasons are the optimizers/planners are detached from the execution context but need functionalities somehow.

💯  @yjshen  -- see https://github.com/apache/arrow-datafusion/pull/1700 :)


Latency Calculations

Hey @geraintluff,
We chatted a while ago on Discord about the latency calculations involved in using this library, and I want to follow up with a more concrete example because I’m still not quite sure I understand. Let me explain my use case and I’ll enumerate my understanding along the way. I’m hoping you can either confirm my understanding or show me where I have it wrong!
So I’m using this library in a VST3 plugin context running in a DAW. My plugin has an audio loop (e.g. a synth melody loop) loaded into memory, and aims to play the loop perfectly in time with the DAW. Because the loop might be recorded at a BPM that differs from the DAW’s current BPM, I’m using time stretching to accommodate.
Now, because we’re dealing with a DAW and an algorithm that introduces latency, we have to report our latency to the DAW. My understanding is that the latency I should report to the DAW should be a fixed number, and that that number is stretch.outputLatency(). Then there is the more dynamic component of the latency calculation stretch.inputLatency() * stretchFactor, and my understanding is that this part of the latency calculation is something I can address manually using the pre-roll idea to ensure my output is always in sync with the DAW.
So my first question is, is that understanding accurate? Then, assuming that’s accurate, there comes the follow up question for how to actually handle that pre-roll. Here I see two cases:

We start at time t=0 when the DAW begins playback from the very beginning of its timeline.
We start at time t=N when the DAW begins playback from an arbitrary, non-zero part of the timeline because the user has moved the playhead there.

To handle the first case, there’s nothing for me to pre-fill because before time t=0 we have just silence. But here I’m not sure: do I need to push zeros into stretch to fill some internal buffer? Or can I assume those 0s are already in there internally and my expected output time will follow stretch.outputLatency() samples later?
To handle the second case, there is often sample data I can and should pre-fill from time t’ < N. To do this, I should pre-roll input data by reading stretch.inputLatency() * stretchFactor number samples of my input data leading up to time t=N into stretch. I believe I can do this by calling stretch.process with that input data and with a nullptr for the output data so that it’s clear I’m not asking for output from my pre-roll. Immediately after (i.e. synchronously) I should then feed my input data from time t=N onward into stretch and take the appropriate number of output samples to hand back to the DAW.
Does the above sound accurate as well? Thank you for your time! I appreciate your help and again I want to say that I really appreciate your work on this library, it sounds fantastic.

Hi!
I added some stuff about this recently, since it is tricky.  Firstly, yes it's filled with 0s initially, and also after a .reset() call.
However, since (for both cases) you're reading ahead in the input, you should use the new .seek() method.  In the t=0 case, you'd use this (after a .reset() if needed) to start .inputLatency() samples ahead in the input.
In the other case (seeking to t=N), you can use that same method to jump to a new location: feeding it a block of input which ends at position t*sampleRate + stretch.inputLatency() samples ahead in the input  If you want the output to stay continuous (no clicks/etc.) just don't call .reset() in the second case.
The playbackRate argument helps Stretch figure out what to do with transients in the first block.  If you want to scrub around the input (calling .seek() again every time the mouse moves), you can pass in 0 for this.  If you're going to resume normal playback after .seek(), you should use a playback rate that matches your initial time-stretch rate.

This is a new method, so if you hit any issues or bugs, please do get in touch!  In fact, get in touch either way so I know whether it works. 😛
Discord or email are more reliable methods than GitHub, I don't check here very often.

Meant to follow up here after catching you briefly in Discord– thanks so much for your help! I've got it working perfectly now, really excited


merge into chef core

I find myself using the logrotate_app resource in half of my cookbooks in order to maintain logs. Is there any plans on merging it into the core functionality of chef?

@jlosito Thanks!  I definitely agree and I think @tas50 agrees as well.  At the very least, I think it should move back to being a Chef-maintained cookbook. I don't use this cookbook much anymore and would be very happy to move it back to Chef however it is likely going to be a while until I can work on it again.

@stevendanna if you want to move this back to chef-cookbooks we can start the process of moving it into core

This entirely slipped my mind, but I'll see what I can do to get this into Chef Infra Client 15.4

AFAICT, this did not make it into 15.4+ or 16.x, right?

It did not make the cut.


Order by Title

Is there any possibility to order by title in the admin interface?
At the end of admin interface you can order by

Short URL
URL
Date
IP
Clicks

...but not by "Title".
My titles look like this

"Product 1 > Link 1"
"Product 1 > Link 2"
"Product 2 > Link 1"
"Product 2 > Link 2"

...and it would be nice to see them in this order.
I tried to add the line
'title'   => yourls__( 'Title' ),
below
// Second search control: order by
$_options = array(
    'keyword'      => yourls__( 'Short URL' ),
    'url'          => yourls__( 'URL' ),

in the file /includes/functions-html.php ...but that doesn't do the trick :(

Yes, that ticket reference means I'm working on an implementation of this. :grin:
PR tomorrow, probably. Barring any explosions once I pull the patch to my server for testing, that is. My PHP is pretty rusty, after all. :smirk:


Accessibility - Settings - Dismiss button

📲 What
Adds accessibility label to the dismiss button & fixes the minimum width of the button in order to follow HIG best practices for tappable elements (44x44 pts)
🤔 Why
Better accessibility
🛠 How
Simply adding accessibility label (this will prevent from using the image name)
👀 See

Before
After

✅ Acceptance criteria

[ ] Voice Over reads the dismiss button as "Dismiss - Button" (please not that this is localized)
[ ] Accessibility Inspector doesn't show min-width warning when running the audit on Settings screen

 Audit Settings Accessibility

Addressed your feedback.
@ifbarrera could you please try the ACs on both iOS 10 / iOS 11 devices? Just to be sure nothing is out of ordinary. Our device list in YVR is very sparse at the moment.

Tested on iPhone 7 (10.3) and iPhone 8 (11.4) simulators using the accessibility inspector.


Update icons.md

Add new icons set - CoreUI Icons

Can you retarget/rebase this against main so we can include it in v5 and then backport to our v4 branch?

@mdo I created a new pull request https://github.com/twbs/bootstrap/pull/31516 . I hope everything is ok now.


Modify codes so that different accelerators can be called according to specific device conditions

Modifications in: DeepSpeedExamples/inference/huggingface/text-generation :
1、use "deepspeed.accelerator.get_accelerator()" to replace "cuda" specific codes；
2、Add "bfloat16" to dtype so that the code can run on CPUs;
3、fix an error in README setup commands with conda.
p.s. Before running it, you need to get support of idex(intel-extension-for-deepspeed) and ipex(intel-extension-for-pytorch).

@tjruwase Hi, thanks for your approval. If there's no more problems, please take time to merge. Thanks.


Refactor out setup sources script for debian and add single execute s…

…cript
This change pulls the common execution of pbduiler into a stand-alone
script and creates focused setup sources scripts per use case.

Rebased and the last re-factor needed to then start turning into pipelines


Restore error codes for acquireTokenSilent telemetry

This was mistankely removed in https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/4973/files#diff-827dd2c804974fc1c04ca2f8fa2372b1d42f06b7d0c248f0b390da147e208931L137-L138

Should we include tests to make sure this doesn't happen again?

Should we include tests to make sure this doesn't happen again?

Yeah, probably a good idea.

@peterzenz @tnorling Tests added for perf event properties included for acquireTokenSilent.

Codecov Report

Merging #5190 (1f3bead) into dev (b00abd0) will decrease coverage by 0.07%.
The diff coverage is n/a.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.50% <ø> (ø)

msal-browser
86.69% <ø> (-0.25%)
:arrow_down:
Carriedforward from d6d90e6

msal-common
85.43% <ø> (ø)

Carriedforward from d6d90e6

msal-core
82.84% <ø> (ø)

Carriedforward from d6d90e6

msal-node
83.43% <ø> (ø)

Carriedforward from d6d90e6

msal-node-extensions
76.03% <ø> (ø)

Carriedforward from d6d90e6

msal-react
94.50% <ø> (ø)

node-token-validation
88.88% <ø> (ø)

Carriedforward from d6d90e6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

...ib/msal-browser/src/app/PublicClientApplication.ts
100.00% <ø> (ø)

lib/msal-browser/src/crypto/CryptoOps.ts
84.70% <0.00%> (-6.97%)
:arrow_down:

lib/msal-browser/src/cache/DatabaseStorage.ts
36.60% <0.00%> (-1.93%)
:arrow_down:

lib/msal-browser/src/cache/AsyncMemoryStorage.ts
77.35% <0.00%> (-0.42%)
:arrow_down:

lib/msal-browser/src/cache/CryptoKeyStore.ts

@jasonnutter Thanks for restoring this!


How to clear a text field from all tags?

Hi,
Love what you have done, but how to clear a textfield from all tags?
/Bob

You can delete all tags by using long press backspace

Hi Erwin, thanks for that, but that won't really work in a live production environment. You can't really have users fill out a form, and then go back and delete tags by hand after each submission (I use AJAX, meaning the form page won't reload so manual clearing would be needed.
Would you consider adding a function to clear()  a textfield that uses your tags in the near future? If not I guess I have to use another tag implementation, but I am hoping you will since it is a very basic requirement for your tags and should be part of your solution. Im sure you agree.

For a quick fix, run the following script:
document.querySelector('#input_id').value = ''
document.querySelector('#input_id').dispatchEvent(new Event('change'))
The script above will delete the input value, then the tagin will be automatically updated


Seems to only want RN 0.8.0.  What about newer versions?

It doesn't seem like I can upgrade past React Native 0.8.0 because of a dependency of this package for only that RN version.  Is there a reason it's stuck on that version?  Can you change the dependency to remove that restriction and let it accept newer versions of RN?

+1

+1

Sorry guys I have been pretty busy lately. Working on it.

Thanks!

+1

+1

ive been using this with react 13.2 and its working for me (ive used segmented controls only).  Can you please tell when do you expect this to be updated?

I am so sorry I can't find the time to update this.
Technically, nothing but package.json needs to be updated, but I'd like to update the example as well.
PR are welcome, I don't think it's a lot of work really, but I am not sure I can afford spending some on this at the moment.

Hey @ArnaudRinquin , ive created a PR https://github.com/ArnaudRinquin/react-native-radio-buttons/pull/5. I bumped up RN version in package.json and also updated the example. Let me know what you think.

#5 by @manask88 fixes this issue and I just published 0.6.0.
Thanks again @manask88


Add back in extras_require by using compatible versions

Instead of using ==v.w.* this uses ~=v.w the compatibility operator.  Compatibility is ==v.* >=v.w.  This is nearly the same thing with some sublties about prelease versions that shouldn't hit us.
I've tested this by pushing to test pypi and prod pypi and it works.

Something went wrong with Travis and crashed pylint.

PTAL


Reverse a singly linked list in python

Is your feature request related to a problem? Please describe.
No, it is not a problem. I want to write an algorithm to reverse a singly linked list in python
Describe the solution you'd like
I will create a linked list first and then reverse it using the iterative approach.
Describe alternatives you've considered
No.
Additional context

Please implement this algorithm in all four languages

Assigned!
@papri24majumder : C, C++, Java, Python
And please don't update the README.md

@Kumar-laxmi pls assign me this issue. Thanks


Added method to load TTF font from memory

I had a few fonts I wanted to embed into my executable, but didn't want to cache to disk before loading them.
Added a method to load TTF fonts directly from memory, thought some might find it useful.
Would also be nice to do so with images, but in the meanwhile I'm just using stb_image as a bridge to decode the raw pixel data.

Hi @scottmudge! Thank you very much for the improvement! I'm also working on memory buffers data loading but still deciding the best approach to it, not merging for the moment but I keep it open.

Wanted to chip in here and say that I really appreciate the loading from memory functions. While I understand it can pose some conflict with the rest of raylib's design (ease of use, concern about memory loss, etc), it does give raylib a lot more legs on how it can be used.
rres has some of this functionality, but I would really love for more of the Load*FromMemory() functions to be brought into raylib core. Thanks!

No plan for those additions at the moment. Internal buffers drawing can be forced with rlglDraw(), loading files from memory is still under consideration...


tags with white spaces in them are rendered with empty hrefs

Hello,
I've added some tags in my posts with whitespaces in them, and when Hugo renders the pages, the href is empty.
ex : Tag = bla bla, gets an empty href instead of href=tags/bla-bla
A solution I've found is to alter the layout partials/post-info.html to urlize tag names like this :
                    {{ $tag := ($.Site.GetPage (printf "/tags/%s" (urlize $tag_name))) }}
Instead of :
                        {{ $tag := ($.Site.GetPage (printf "/tags/%s" $tag_name)) }}
This way the href are rendered correctly.
Note:
If it is the right way of doing it, the same altering should be applied to the categories a few lines above :
                    {{ $cat := ($.Site.GetPage (printf "/categories/%s" (urlize $cat_name))) }}
Instead of :
                    {{ $cat := ($.Site.GetPage (printf "/categories/%s" $cat_name)) }}
Thank you for this nice theme !

Fixed, thanks!
And sorry for the long wait.


Add a texture upload context to the GLFW shell

Since we don't have one, we get error logging on launch:
[ERROR:flutter/shell/platform/embedder/embedder_surface_gl.cc(95)] Could not create a resource context for async texture uploads. Expect degraded performance. Set a valid make_resource_current callback on FlutterOpenGLRendererConfig.

It's unlikely that this is a significant issue in practice at the moment, but the fact that there's error logging immediately on launch is causing confusion, since some people assume it's a serious error (and if something unrelated is actually wrong, they think it's related).

Fixed in https://github.com/flutter/engine/pull/8895