[share] Add sharing file support (android & ios)

This pull request adds file sharing support to the share plugin.
Share.shareFile(File('${directory.path}/image.jpg'));

To use while it is not yet published in the share plugin, just use the following in your pubspec.yaml:
dependencies:
  ...
  share:
    git:
      url: https://github.com/pboos/plugins.git
      path: packages/share
      ref: feature/shareFile

Hi @pboos! What a nice work! Thank you very much for sharing, I find this completely necessary for the plugin!
One quick comment. To make things easier for people who don't know about this, I think we should mention in the README.md that adding some keys for iOS may be needed. For Android I think it's not needed, correct me if I'm wrong please. We could add something like this:
iOS
Add these keys to ios > Runner > Info.plist to be able to same images to the camera roll:
<key>NSPhotoLibraryUsageDescription</key>
<string>Access to save the image</string>
<key>NSPhotoLibraryAddUsageDescription</key>
<string>Access to save the image</string>

Android
There's no need to change anything.

Great job @pboos!
It would be perfect if had an option for multiple files like this
https://github.com/d-silveira/flutter-share
Could you add that?

I'm having issues sharing image files with WhatsApp on iOS. On Android it's working fine, is there any specific thing that needs to be done in order to share in WhatsApp?

When will this be merged?

When will this be merged?

using the dependency as described by @pboos does not seem to work anymore with the migration away from android support library
E:\Dev\flutter\flutter\.pub-cache\git\plugins-32d70052e89ccb4ea8c528f174dd29023c037a16\packages\share\android\src\main\java\io\flutter\plugins\share\SharePlugin.java:10: error: package android.support.annotation does not exist
import android.support.annotation.NonNull;
                                 ^
E:\Dev\flutter\flutter\.pub-cache\git\plugins-32d70052e89ccb4ea8c528f174dd29023c037a16\packages\share\android\src\main\java\io\flutter\plugins\share\SharePlugin.java:11: error: package android.support.v4.content does not exist
import android.support.v4.content.FileProvider;
                                 ^
E:\Dev\flutter\flutter\.pub-cache\git\plugins-32d70052e89ccb4ea8c528f174dd29023c037a16\packages\share\android\src\main\java\io\flutter\plugins\share\SharePlugin.java:155: error: cannot find symbol
  @NonNull
   ^
  symbol:   class NonNull
  location: class SharePlugin
E:\Dev\flutter\flutter\.pub-cache\git\plugins-32d70052e89ccb4ea8c528f174dd29023c037a16\packages\share\android\src\main\java\io\flutter\plugins\share\SharePlugin.java:101: error: cannot find symbol
        FileProvider.getUriForFile(
        ^
  symbol:   variable FileProvider
  location: class SharePlugin
4 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':share:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 5s
*******************************************************************************************
The Gradle failure may have been because of AndroidX incompatibilities in this Flutter app.
See https://goo.gl/CP92wY for more information on the problem and how to fix it.
*******************************************************************************************
Finished with error: Gradle task assembleDebug failed with exit code 1

@pboos Hi, I'm an user of your great work. Thank you.  I appreciate your great effort. It can be better if you make it to be merged. I wish it become true. Thank you.

Using this plugin in the way that @pboos described is giving a conflict with AndroidX.
Is there any forecast when this feature will be added to the share plugin?

I found it easy to refactor the plugin according to https://flutter.dev/docs/development/packages-and-plugins/androidx-compatibility as well as changing the NonNull and FileProvider to the latest imports in the SharePlugin.java-file:
import androidx.annotation.NonNull;
import androidx.core.content.FileProvider;
and in the androidmanifest.xml-file:
android:name="androidx.core.content.FileProvider"

Can anyone check this fail check?

Is anyone able to fix the CLA related check?

At first glance looks like a solid PR.
Created https://github.com/flutter/flutter/issues/36894 to track getting this merged, if this feature is something you need please thumbs up that issue.

@collinjackson anything we can do to help this along?

What do I have to do to get this merged in? It seems like several people are interested in this and it would make it easier if it was merged into the official share plugin.

I also have problem conflict with AndroidX. My project not use AndroidX
`Attribute meta-data#android.support.FILE_PROVIDER_PATHS@resource value=(@xml/filepaths) from [:open_file] AndroidManifest.xml:20:17-50
is also present at [:share] AndroidManifest.xml:15:17-65 value=(@xml/flutter_share_file_paths).
Suggestion: add 'tools:replace="android:resource"' to  element at AndroidManifest.xml to override.
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:processDebugManifest'.

Manifest merger failed : Attribute meta-data#android.support.FILE_PROVIDER_PATHS@resource value=(@xml/filepaths) from [:open_file] AndroidManifest.xml:20:17-50
is also present at [:share] AndroidManifest.xml:15:17-65 value=(@xml/flutter_share_file_paths).
Suggestion: add 'tools:replace="android:resource"' to  element at AndroidManifest.xml to override.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 19s`

@pboos: I tried to fix the conflicts (your repo is 500+ commits behind upstream), but unfortunately I couldn't make the plugin work.
Would you mind fixing the conflicts (it seems to me that it shouldn't be too much work)? Also Flutter is complaining about AndroidX in my case, and it seems like this should be addressed as well.
Finally, the CI is all passing expect for the CLA saying: "CLAs are signed, but unable to verify author consent". Did you do everything on your side? I believe that the Flutter team won't be able to merge unless this test is passing.
It seems like the Flutter team doesn't have much resources to look into PRs, since this one has been waiting for more than a year. But at least if it was in a mergeable state, there would be a chance of it being merged some day :blush:. Currently it is not.

So. I have updated my branch and rebased to a commit from two weeks ago (as of now the most recent). The many conflicts were due to the reason that the master share plugin was migrated to android plugin v2 and androidx. I now adjusted the code to that version.
Might require a new review of the code since especially the ios part changed a log (made it closer to the new version and as well fixed a bug that was there in the old version of my pull request).
Any further input to get this merged would be great.

Happy to see it's moving here! And I see that the CLA test is now passing!
I had a look a the CI: many tests fail for the same reason, but I'm not sure it comes from this PR:
Running version check for changed packages
Unhandled exception:
NoSuchMethodError: The getter 'nextMajor' was called on null.
Receiver: null
Tried calling: nextMajor
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
#1      getAllowedNextVersions (package:flutter_plugin_tools/src/version_check_command.dart:59:19)
#2      VersionCheckCommand.run (package:flutter_plugin_tools/src/version_check_command.dart:153:13)
<asynchronous suspension>
#3      CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#4      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#5      new Future.sync (dart:async/future.dart:224:31)
#6      CommandRunner.run (package:args/command_runner.dart:112:14)
#7      main (package:flutter_plugin_tools/src/main.dart:57:17)
#8      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:305:32)
#9      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:174:12)

There is an analysis error (I'll comment in the code) and the formatting is wrong. At least those two I think you can fix :smile:.
Note: I'm new to Flutter, I'm just trying to help :sweat_smile:.

So formatting and the async should be fixed now. Just the NoSuchMethodError: The getter 'nextMajor' was called on null. is still happening now. I wonder where this one is coming from and how I can fix it...

Agreed, they seem fixed. The nextMajor error seems to come from the tool version_check_command.dart, apparently because the masterVersion given as an argument is null:
final Version masterVersion =
    await gitVersionFinder.getPackageVersion(pubspecPath, baseSha);

@collinjackson is that something you could help with? :blush:

BTW what's the difference between this and #1423?

If I read correctly, then the problem is: the MASTER branch in the example/pubspec.yaml hast NO version. Because of that, masterVersion will be null. So there is NO WAY this will pass until the master branch is fixed :D
About #1423:
That build probably succeeded because that change might have been effective after their commit. Change seems to have been done in June 2019. Not sure when it went into master and therefore into the checks...
About the code difference:
That one is based on this pull request. Same code but fixed to work with the new v2 plugin system and androidx. So basically the same as here. Just on iOS there are small differences (i rewrote some part of it this time). There is one small bug on iOS that I think exists on that version that I fixed in my new rewrite.

How to get this merged in? Not sure if anything else needs to be done or if this just takes this long until it can get reviewed.

The usual way, as far as I know, is that at some point we would need to hear about a maintainer. They may have comments on the code, but everything is ready for a review.
Kindly pinging @cyanglaz and @collinjackson, hoping to see a sign of interest at some point :see_no_evil:.

Just tested this on iPadOS 13.3 (simulator). The dialog showed as expected, but neither Copy nor Save to Files... worked. This may be because I passed in a MemoryFileSystem file (how about accepting bytes instead of a file?). Moreover, Save to Files... may require additional permissions (beyond UIFileSharingEnabled).

Can't get Save to Files... to work in the simulator, but that's a pre-existing condition...

@ejain: I'm not sure I get that. Does that mean that it is expected behavior, or does it mean that this PR would need to be fixed for that case?

@ejain: I'm not sure I get that. Does that mean that it is expected behavior, or does it mean that this PR would need to be fixed for that case?

The Save to Files option doesn't work for me on simulated iPhones, either, even though it does work on the physical iPhone I tested, so I don't think this is an issue with this PR.

Got it! Then if you believe it is ready to be merged (or at least reviewed by a maintainer), feel free to "approve" the PR. Makes it easier to track, IMO.

I believe that the version should be updated to 0.6.4

@collinjackson anything else to do to get this pull request moving? current failing tests were only due to some http timeouts.

Just confirmed that there is at least one iPad out there on which the share dialog works; the key to making it work on iPads was to set sharePositionOrigin to a specific element on the screen.

On the fix I did for esys share I added a check for width an height : https://github.com/esysberlin/esys-flutter-share/blob/26a2f34ddf70f7361c529677dad15aadd99193a6/ios/Classes/SwiftEsysFlutterSharePlugin.swift#L95
If the context rect is the whole window then you have an issue as it will be equal to the bounds => no space for the share sheet

@pboos https://github.com/aarajput/wc_flutter_share/issues/10 Would adding this fix finally complete this PR?

@pboos, Tried sharing a PDF File with:
Share.shareFile(File(filePath),
        mimeType: 'application/pdf',
        text: "Text",
        subject: "Subject");

It works, but I got the following exception in my console:
E/DatabaseUtils(20041): Writing exception to parcel
E/DatabaseUtils(20041): java.lang.SecurityException: Permission Denial: reading androidx.core.content.FileProvider uri content://com.user.app.flutter.share_provider/external_cache/share/mypdf.pdf from pid=11289, uid=1000 requires the provider be exported, or grantUriPermission()
E/DatabaseUtils(20041): 	at android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:729)
E/DatabaseUtils(20041): 	at android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:602)
E/DatabaseUtils(20041): 	at android.content.ContentProvider$Transport.query(ContentProvider.java:231)
E/DatabaseUtils(20041): 	at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:104)
E/DatabaseUtils(20041): 	at android.os.Binder.execTransactInternal(Binder.java:1021)
E/DatabaseUtils(20041): 	at android.os.Binder.execTransact(Binder.java:994)

This isn't related to the actual storage permission, as the exception is thrown irrespective of whether I've granted it.
My flutter doctor:
flutter doctor -v
[√] Flutter (Channel beta, v1.14.6, on Microsoft Windows [Version 10.0.18362.657], locale en-US)
    • Flutter version 1.14.6 at C:\src\flutter
    • Framework revision fabeb2a16f (7 weeks ago), 2020-01-28 07:56:51 -0800
    • Engine revision c4229bfbba
    • Dart version 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\kufah\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 43.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] VS Code, 64-bit edition (version 1.42.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.8.1

[√] Connected device (3 available)
    • Pixel 2 XL • 712KPWQ1289633 • android-arm64  • Android 10 (API 29)
    • Chrome     • chrome         • web-javascript • Google Chrome 80.0.3987.132
    • Web Server • web-server     • web-javascript • Flutter Tools

• No issues found!

I looked it up on SO, and adding the following lines to Share.java gets rid of the error:
import android.content.pm.PackageManager;
import android.content.pm.ResolveInfo;
// the rest of the code
// ...
  void shareFiles(List<String> paths, List<String> mimeTypes, String text, String subject)
      throws IOException {
// ...
    List<ResolveInfo> resInfoList = activity.getPackageManager().queryIntentActivities(chooserIntent, PackageManager.MATCH_DEFAULT_ONLY);
    for (ResolveInfo resolveInfo : resInfoList) {
      String packageName = resolveInfo.activityInfo.packageName;
      activity.grantUriPermission(packageName, fileUris.get(0), Intent.FLAG_GRANT_WRITE_URI_PERMISSION | Intent.FLAG_GRANT_READ_URI_PERMISSION);
    }

    if (activity != null) {
      activity.startActivity(chooserIntent);
    } else {
      chooserIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
      activity.startActivity(chooserIntent);
    }
  }
// ...

Hope we can finally wrap this up after 4 years 😅😁

@MaskyS thanks for the pull request on this pull request :D . I have merged it in.
I really hope this will get merged in soon. Has been open way too long.

@collinjackson: May I ask how the PR reviews of external contributions are organized? Is there a priority list somewhere, or is there just not enough resources to review them at all?

I also added support to save exported images to gallery to iOS gallery.
PR #2

One challenge with this current implementation is the use of androidx.core.content.FileProvider as the Provider in the manifest.  This conflicts with other plugins (e.g. open_file) that use the same provider name.
Using a custom provider is fairly trivial, it was done for image_picker in https://github.com/flutter/plugins/pull/716
Draft PR here: https://github.com/pboos/plugins/pull/3/files

please merge I'm waiting for it 😄

@rafaelmpessoa: It doesn't seem like there is any interest from the flutter team, so you should use it as-is. @pboos wrote instructions in the beginning of this PR on how to use it directly.

@googlebot I consent.

@googlebot I consent.

What's missing for this to be merged?

@allanwolski: I think interest/resources from maintainers. Looking at their github activity, it seems like @collinjackson and @amirh haven't been super active recently (https://github.com/flutter/plugins/graphs/contributors). Note that there seems to be activity in the main flutter repo: https://github.com/flutter/flutter/graphs/contributors.
Not sure what's happening with flutter/plugins, though. Maybe they are dropping support for that, or maybe they are not interested in community contributions. @ditman has been active recently, hopefully we will get news at some point :-).
Maybe the best way would be to give up contributing it to flutter/plugins, and just maintain it as a third-party plugin.

I'm tracking who owns this plugin currently to have this PR merged. Can anybody (@pboos?) update the branch so there's no conflicts with master? I also couldn't find any tests for the Java side, I'm not sure if those are a thing (I normally work on web plugins ;))

Thx @ditman for tracking this! I updated the branch and resolved the conflicts. I tested it and the example still works fine.
There were no tests before this update, so I guess it should be fine without adding any in this PR 😄.

// @cyanglaz this is the PR we talked about a few days ago!

@ditman Should I already update the version to 0.6.5 and also update the CHANGELOG.md file? Or does someone else normally do that?

@pboos please, do update the version and CHANGELOG.md, otherwise the analyze test won't pass :)

@ditman done. Currently some checks are failing due to integration_test it seems. Or do you have any idea how I can resolve that? Did not seem to occur before I switched from e2e to integration_test.

Hmmm @pboos, I think the current master on this branch might have some breakage (not your bad, btw), I'll let you know when flutter/plugins:master is stable for you to attempt another rebase.
(That should fix the build_all tests.)

Master is green now, at least until this point: https://github.com/flutter/plugins/commit/e0a49a7fbdbc4e06d04e4cfbbe2c6056f09bf3d4
@pboos if you rebase your branch again, we can see if the failures come from your code, or were some staleness in other parts of the code.
Thanks for your patience!

@ditman thank you for the heads up. Seems like it is all green now except for the master branch failing (due to timeouts?).

@ditman did the corrections you suggest. I agree the shareFile did not really add any value. And seems like all tests passed now as well. I hope we can get somebody to review Android/iOS. Looks like we are getting closer to getting this merged 🤞 .

@pboos Thanks for the PR! It looks good overall. I left some comments around java and objc implementations.

@cyanglaz Thanks a lot for the great comments. I acted on them and now the code should be a lot better :). You caught some embarrassing bugs that snuck their way in there :)

All looks green, landing this now, will publish ASAP! Thanks for the contribution (and the patience) @pboos!!

share: ^0.6.5 has been tagged and published!

Now as we have to put in the path of our files I wonder how I can share a base64 encoded File that I get from the network?

@ditman Thanks a lot for taking this on and getting it merged! 🚀
@lazylazyllama You could always temporarily store that file on the device within the app. The user won't even notice it. And as a note, before it was File, now it is the path. But even before it just forwarded the absolute path of the file in the background. So if something worked before, you can just do file.path now, as that is what it did before the recent changes on this PR.


Remove __ScalaJSEnv

There are currently 3 usages:

exitFunction to fill System.exit; this was introduced for #958 as a means to terminate PhantomJS in async tests. Testing support has improved substantially since then, so it is not needed anymore. If a platform agnostic termination is required a library should be created for it.
sourceMapper introduced as a stop-gap solution to support source mapping in Rhino. Unused.
javaSystemProperties introduced as a hack to allow to pass in tags for testing. Already made more SJS internal in the past (by not honoring javaOptions in sbt anymore). Should be replaced by a fully SJS internal solution.

Any objections?

For exitFunction and sourceMapper, no objection. I guess System.exit() and Runtime.exit() should be removed, causing a linking error in the future.
For javaSystemProperties, it's trickier. What would be the replacement? Would we just say that everyone's main() method should start by filling up System.getProperties() with their own notion of how to get system properties from an "environment"?
Also, currently the JSEnv test kit relies on __ScalaJSEnv.exitFunction(). What will happen to those tests? Will they be removed?

For javaSystemProperties I see multiple options (depending on the end user need):

JS main fills required things statically (SJS does this for version information).
JS main fills required things via external file (via @JSImport).
Use source code generation.
Use a wrapper that only uses system properties on JVM and uses something else on JS (similar to how we deal with reflection).

Also, currently the JSEnv test kit relies on __ScalaJSEnv.exitFunction(). What will happen to those tests? Will they be removed?

I was going to add back the option that allows a JSEnv to specify a statement that terminates it. If the option is set, the tests are enabled.

That sounds reasonable.


Popping sounds near start of playback

I'm getting popping sounds/skipping during playback (I stream the audio of YouTube videos via UPnP to a streaming DAC connected directly via an ethernet cable to a laptop), but it seems to go away after about 10 seconds.
It may be helpful to know that this is when using WAV output. When using FLAC, the popping is much worse, and doesn't go away (making it unlistenable). LPCM does not work at all with my DAC.
I'm on Windows 11, and here's the log:
Configuration { server_port: Some(5901), auto_resume: false, sound_source: "CABLE Input (VB-Audio Virtual Cable)", sound_source_index: Some(0), log_level: Debug, ssdp_interval_mins: 1.0, auto_reconnect: false, disable_chunked: false, use_wave_format: true, bits_per_sample: Some(16), streaming_format: Some(Wav), monitor_rms: false, capture_timeout: Some(2000), inject_silence: Some(false), last_renderer: "DAC502 DAC502-0541", last_network: "<IP_ADDRESS>", config_dir: "C:\\Users\\Atriy\\.swyh-rs", config_id: Some("") }
Setup audio sources
Now running at ABOVE_NORMAL_PRIORITY_CLASS
Capturing audio from: CABLE Input (VB-Audio Virtual Cable)
Default audio SupportedStreamConfig { channels: 2, sample_rate: SampleRate(44100), buffer_size: Range { min: 0, max:<PHONE_NUMBER> }, sample_format: F32 }
Discover networks
Starting SSDP discovery
The streaming server is listening on http://<IP_ADDRESS>:5901/stream/swyh.wav
Streaming sample rate: 44100, bits per sample: 16, format: WAV
Received request /stream/swyh.wav from <IP_ADDRESS>:36453
Streaming audio/wave;codec=1 (WAV), input sample format F32, channels=2, rate=44100, disable chunked=false to <IP_ADDRESS>:36453
Streaming to <IP_ADDRESS>:36453 has ended
The wave_reader is now receiving samples
AV Start playing on DAC502-0541 host=<IP_ADDRESS> port=49152 from <IP_ADDRESS> using AvTransport Play
AV Stop playing on DAC502-0541 host=<IP_ADDRESS> port=49152
Received request /stream/swyh.wav from <IP_ADDRESS>:36454
Streaming audio/wave;codec=1 (WAV), input sample format F32, channels=2, rate=44100, disable chunked=false to <IP_ADDRESS>:36454

Your setup makes the poping sound unavoidable. Usb dacs do not tolerate any buffer underrun because they are designed to minimize latency. From the moment you introduce a network  you introduce latency caused by the buffering on various layers.
The only way to overcome this is to add/increase buffering as close to the dac as possible, for instance in your upnp receiver on the laptop (this may be configurable).
This of course introduces latency, which is something you want to avoid when watching movies.
The only media player that can handle this afaik is VLC, it allows you to play the video with a configurable latency to compensate for your audio network latency.

Thanks. I do know about using VLC to manually configure latency and have been setting it to -0.35 seconds so far.  Not sure how to configure the UPnP receiver on my laptop though. I'm guessing this would still be a Windows 11 setting? Or would it require registry edits/special software to configure?
Also in this case isn't the DAC the UPnP receiver and the laptop the transmitter? Sorry if I have this backwards.

I think I misunderstood you setup completely.
I thought the DAC was connected via USB to your laptop, and that you were streaming from another PC to an upnp renderer running on that laptop.
After looking at the specs of the Weiss DAC502 I suppose that the DAC is directly connected to your ethernet network and that the laptop is running swyh-rs to stream audio to the DAC.
In that case the DAC itself is indeed running the upnp renderer, and there are no configurable settings in the DAC (like receive buffer read-ahead size) according to the Weiss documentation.
So I'm afraid you're stuck there.
The fact that FLAC is much worse is also easily explained: the FLAC compression increases the time between successive ethernet frames, and the minimal buffering in the DAC causes the inevitable drop-outs.
It's unfortunate for you that swyh-rs does not have a configurable output buffering (introducing a fixed delay) either.

Thanks for taking the time to dig into this! It is indeed a Weiss DAC502 that is connected via ethernet - not USB - to a laptop, and the laptop is running swyh-rs to stream audio to the Weiss.
It’s not that bad: as I said, the popping seems to go away after the first 10 seconds or so when using WAV. I’m not sure if that’s also something explainable, or just a happy happenstance. And with a -0.35s setting in VLC, there is no audio-video mismatch either.
From: dheijl @.>
Sent: Friday, February 17, 2023 1:18 PM
To: dheijl/swyh-rs @.>
Cc: Atriya Sen @.>; Author @.>
Subject: Re: [dheijl/swyh-rs] Popping sounds near start of playback (Issue #87)
I think I misunderstood you setup completely.
I thought the DAC was connected via USB to your laptop, and that you were streaming from another PC to an upnp renderer running on that laptop.
After looking at the specs of the Weiss DAC502 I suppose that the DAC is directly connected to your ethernet network and that the laptop is running swyh-rs to stream audio to the DAC.
In that case the DAC itself is indeed running the upnp renderer, and there are no configurable settings in the DAC (like receive buffer read-ahead size) according to the Weiss documentation.
So I'm afraid you're stuck there.
The fact that FLAC is much worse is also easily explained: the FLAC compression increases the time between successive ethernet frames, and the minimal buffering in the DAC causes the inevitable drop-outs.
It's unfortunate for you that swyh-rs does not have a configurable output buffering (introducing a fixed delay) either.
—
Reply to this email directly, view it on GitHub https://github.com/dheijl/swyh-rs/issues/87#issuecomment-1435125135 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXGEWCWZ4AOETMMC5YUUHDWX7FIJANCNFSM6AAAAAAU63YTPU .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/ACXGEWBRVN4I3F4NOSTUJBLWX7FIJA5CNFSM6AAAAAAU63YTPWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSVRJCY6.gif Message ID: @.*** @.***> >

Well if you can live with it, so can I :)
As for explaining the 10 seconds: perhaps the DAC uses some adaptive buffering algorithm if it detects buffer underruns ( a wild guess) ?

Well if you can live with it, so can I :)
As for explaining the 10 seconds: perhaps the DAC uses some adaptive buffering algorithm if it detects buffer underruns ( a wild guess) ?

I suppose it's possible.
It would be great if VLC could stream the audio via UPnP to the DAC directly, but it apparently can't do that.
Thanks for your great little utility that allows me to play videos while streaming the audio to my DAC. The original SWYH didn't work for me at all!


Label onPress callbacks are not working

I can't get onPress, onLongPress, onPressIn or onPressOut to work on LabelPrimitive.Root...
It works if I add them to LabelPrimitive.Text, but that creates all sorts of bugs and weird behaviors.
On the reusables form showcase demo (https://rnr-showcase.vercel.app/form) you can click all labels and they trigger the input elements, but I copied the exact same code from the "showcase/form" source on github and yet the labels don't work, it's driving me crazy!
I don't know if I should post it on the rn-reusables repo or here, but I imagine its here because the primitives don't seem to trigger the callbacks.
Could anyone help me with this?

Facing with the same issue.
Fixed by adding onPress callback to the Text component

@kaumac
So, digging further I was able to make it work as it should (without additional onPress callbacks).
This is a demo component:
export const CheckboxDemo = () => {
  const [checked, setChecked] = React.useState(false);

  return (
    <View className="flex-row gap-3 items-center">
      <Checkbox
        id="terms"
        nativeID="terms"
        checked={checked}
        onCheckedChange={setChecked}
      />
      <Label
        nativeID="terms"
        htmlFor={Platform.OS === "web" ? "terms" : undefined}
        onPress={Platform.OS !== "web" ? () => setChecked((prev) => !prev) : undefined}
      >
        Accept terms and conditions
      </Label>
    </View>
  );
};

@kaumac Please install the latest version of the label primitive, it was just released with the fix.


"Viforeni" and "Vânători" are listed in the drop-down menu

Description:
"Viforeni" and "Vânători" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Viforeni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Viforeni, Botoșani (Gorbănești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Vânători" in the search bar.

Expected results
The location is listed in the drop-down menu as "Vânători, Botoșani (Gorbănești)".


image route max_size parameter

adds a max_size parameter to determine the necessary shrink based on the image size
resulting shrink is always the maximum between (shrink, shrink_from_max_size)
meaning you can still apply a base shrink AND set a maximum
Here, "size"  (in max_size) refers to the maximum dimension of the image. I would like some feedback on that name.
I was also considering a maximum pixel area instead (e.g. 1.5 MP), but felt like that would be more confusing.

Max size is fine. For me it was clear it refers to width or height, whatever is larger


Forcing Groovy stubs to be generated when a Java annotation processor is on the classpath

This allows annotation processors to process all Groovy annotations even for builds with no java source files.
@alkemist can you take a look?

Added some more negative tests to ensure stubs are not generated if an annotation processor is not added to the classpath.

Merged, thanks @Sarev0k !


mask in reconstruction loss

I think your reconstruction loss is missing mask, which should be applied after subtracting two features as in (3) of the paper.

https://github.com/rosinality/semantic-pyramid-pytorch/blob/6d4796cbb2abdbe9afaafb8dae75b60a3b619d2d/train.py#L146

Oh, thank you! Fixed it in d3777bf.


Single Target optimization should only be done when parseMessageTemplate = null

Fixes #2507 so mixed-mode templates also works in single-target scenario. See also #2544

Is this a bugfix or a performance optimization?

Bugfix

Thanks!


IAM topics

Adding some of the IAM-related topics.  There will be a lot of broken links and other issues until we solidify what all topics are being added and where.

Cleanup and move to another repo


[release/1.7] Require plugins to succeed after registering readiness

Fixes hang when plugin which registers readiness fail. Additional fix in CRI to register readiness later on in its initialization.
Backport #9153 #9164

Could you swap the commit order to help bisecting?


added viewport zoom fix for iOS 9

I’ve added a fix for the standard viewport meta tag. The reason behind this, is explained at Mattias Kihlström’s blog:

In iOS 9 Apple has changed how Safari handles the viewport zoom at page load. Before, if you added <meta name="viewport" content="widh=device-width, initial-scale=1"> to the head of your HTML document, you knew that the page would render at the width of the device (in CSS pixels) and be zoomed at 100%. Any elements wider than the device width or absolute positioned elements outside of the normal viewport would not affect the initial zoom.

After the release of iOS 9 this is no longer the way it works. Instead of initially hiding things that does not fit the page horizontally, the browser will now automatically zoom out to accommodate everything.

I couldn’t explain this better than Mattias, so I decided to quote him :)

:+1:

Nice one!


SQL query doesn't return an error when it should

Below code prints out a record even if it doesn't have dateTime.
type Package record {
    int? packageID = ();
    int dateTime;
};

stream<Package, error?> resultStream = dbClient->query(`SELECT PACKAGEID, XYZ FROM PACKAGE WHERE PACKAGEID=${packageId};`);
check from Package p in resultStream do {
    // io:println(p.dateTime);
    io:println(p);
;

@manuranga What is the sql module version you are using?

I think it's "1.3.1" but I am not sure since it was in a different laptop.

From my initial debugging, this is an error in SQL module, we will fix this.
@kaneeldias This behaviour is due to this piece of code, https://github.com/ballerina-platform/module-ballerina-sql/blob/master/native/src/main/java/io/ballerina/stdlib/sql/nativeimpl/QueryProcessor.java#L285
Here, we are creating an empty record and updating the values. The above use case is not identified in this case. We have to create the record with the processed results.


compiler: Refactor

Various minor refactorings done for PR #2397.

maybe also consider c715e327d2c019d6fd2fe45828bb31390c511e56 in the list?

I did not put can_be_null because it is more a way to make different parts of the compiler compatible with set-theoric operations than a real clean up (and because this would require a more delicate rebase).
But, if you want, I can do a separate PR later this week.


Add HTTP binding security token metadata docs

Add content for https://github.com/dapr/components-contrib/pull/2470.

Closed via #3109.


Separation of UI and Logic in the NumberInput Component

Description
Improving code maintainability and readability.
Proposed Solution or API
Move the useNumberInput code from number-input.tsx to a new file called use-number-input.ts.
Additional Information
Please create a new branch from 2.0 branch for development.

I have created a pull request to address this issue.
When you have a moment, could you kindly review it?

Thank you for the PR! :)

I'm really sorry about this, but because of some things going on, we'll tackle this issue after we finish up some other tasks. So, we’re going to close your PR. @ogison


Accepting options

Hello, I'm new to the android development circle and I need a tip. I've got Android Studio working with an emulated device (Nexus 5, see screenshot). However, once I enter my options, I don't see how to accept the settings I've specified.
I'm very sorry for the obvious question. -.-

Hi @kneeki ! Yeah sorry about that. I'd only developed it against tablets, but I fixed it to work on phones last night. Try updating to the current head.

Will do! Thank you!
On Wed, Oct 7, 2015 at 6:36 AM Hannah Mittelstaedt<EMAIL_ADDRESS>wrote:

Hi @kneeki https://github.com/kneeki ! Yeah sorry about that. I'd only
developed it against tablets, but I fixed it to work on phones last night.
Try updating to the current head.
—
Reply to this email directly or view it on GitHub
https://github.com/HannahMitt/HomeMirror/issues/29#issuecomment-146198236
.

--
Sent from my iPhone. Forgive the brevity, the typos and the lack of nuance.

Thanks for the help @HannahMitt! It's working wonderfully. =)


Run on more compilers

Adding gcc-12 and clang-14 compilers to the test matrix

Codecov Report

Merging #31 (0fb0dda) into main (be1187a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0fb0dda differs from pull request most recent head a7a5b1f. Consider uploading reports for the commit a7a5b1f to get more accurate results

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   98.64%   98.64%
=======================================
  Files          11       11
  Lines         516      516
=======================================
  Hits          509      509
  Misses          7        7

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fan out PushTransaction requests to multiple peers

Motivation
When Zebra pushes user transactions, we want to:

send the request to multiple distinct peers, and
prefer peers that don't already have the transaction

(Zebra won't push user transactions until it has client integration.)
Designs

Update inventory tracker when we send blocks and transactions to peers:

Request::PushTransaction
Response::Transaction
Response::Block

Fanout PushTransaction requests inside the peer set, like AdvertiseTransaction and AdvertiseBlock
Prefer peers that don't already have the transaction (this is the opposite of the routing in route_inv)

Related Work

#2214

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

This isn't needed at the moment, because we just use our own mempool.


Restructure code and implement sortinghat command

The user can now use the /sortinghat slash commands. This will render 4 buttons, each representing a house. When the user selects a house, they will receive a new role with that house's name. The user can also change house by doing the same procedure.

I have also added npm run commands for deployment and starting the server. It's also possible to run live-reload server by installing nodemon.
npm install -g nodemon    # install nodemon globally
nodemon                           # starts the nodemon server

This will restart the discord bot every time a code changes.
Events, button interactions, commands and deployment commands have also been reorganized in their own separate folders in src directory. They are all recognized automatically as long as their file extension is .js.
A command template was added to make creating new ones easier. It's located at src/commands/command.template. Simply copy and paste it into the same directory, change the file and command name and add new code to it.


How to change to Universal node?

I saw the future deprecation of Control Player and Get Status. I am using both in this flow:
[{"id":"e023ed05.891fc","type":"sonos-get-status","z":"84d87b47.f375b8","confignode":"76b8357d.3e9ccc","name":"Get Status","x":370,"y":660,"wires":[["173248ff.db7997"]]},{"id":"173248ff.db7997","type":"switch","z":"84d87b47.f375b8","name":"","property":"payload.modelName","propertyType":"msg","rules":[{"t":"eq","v":"Sonos Beam","vt":"str"}],"checkall":"true","repair":false,"outputs":1,"x":530,"y":660,"wires":[["82ff3eec.5ac1f"]]},{"id":"82ff3eec.5ac1f","type":"change","z":"84d87b47.f375b8","name":"","rules":[{"t":"set","p":"topic","pt":"msg","to":"'x-sonos-htastream:RINCON_' & \t$replace(msg.payload.MACAddress, ':', '') & \t'01400:spdif'\t","tot":"jsonata"},{"t":"set","p":"payload","pt":"msg","to":"activate_avtransport","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":680,"y":660,"wires":[["c4531aa3.77f9c8"]]},{"id":"c4531aa3.77f9c8","type":"sonos-control-player","z":"84d87b47.f375b8","confignode":"76b8357d.3e9ccc","name":"Control Player","x":860,"y":660,"wires":[[]]},{"id":"cb711fd4.e1eeb","type":"change","z":"84d87b47.f375b8","name":"Prop","rules":[{"t":"set","p":"payload","pt":"msg","to":"get_properties","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":190,"y":660,"wires":[["e023ed05.891fc"]]},{"id":"76b8357d.3e9ccc","type":"sonos-config","z":"","name":"Sonos","serialnum":"34-7E-5C-99-E5-B6:E","ipaddress":"<IP_ADDRESS>"}]
I get how to change the Get Status (get.state with Universal), but, I can seem to find in the very good examples how to change the source (the magic syntax with RINCON...) with Universal.
Have I missed it ?
Thanks,

No, you didn't miss it.
Please wait until 4.0.0 - should be available latest next week.
4.0.0 will have the missing commands from Get Status, Control Player, Manage Queue and also enable you to select the command from a drop down box.

Hi. Now the 4.0.0 is published.
Be aware: you will need some minutes to change your flows. So plan some time.
I did an update on the Wike - see example 4

OK. Thanks. I'll try that.  I'll publish an update if I have some issues. Continue the great job!!

Just to thank you for the great set of nodes. I eventually upgraded to 4.1 and it went like a charm. Keep up the extremely good work :)

Thanks for the kind feedback.


Conflict with AWS Ingress Controller

I've been attempting to use the shinyproxy-operator in a new EKS cluster.  I had issues with the operator being able to communicate with the shinyproxy container and looking at operator logs I see:
io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: POST at: https://<IP_ADDRESS>/apis/networking.k8s.io/v1/namespaces/shinyproxy/ingresses. Message: Forbidden!Configured service account doesn't have access. Service account may have been revoked. admission webhook "vingress.elbv2.k8s.aws" denied the request: invalid ingress class: IngressClass.networking.k8s.io "skipper" not found.
	at io.fabric8.kubernetes.client.dsl.base.OperationSupport.requestFailure(OperationSupport.java:682) ~[shinyproxy-operator.jar:1.1.0]
	at io.fabric8.kubernetes.client.dsl.base.OperationSupport.requestFailure(OperationSupport.java:661) ~[shinyproxy-operator.jar:1.1.0]

After much digging it appears to be related to the change to use ingressClassName: skipper as opposed to kubernetes.io/ingress.class: "skipper" with version 1.1.0.  I don't think this itself is an issue, but the AWS ALB webhook does not seem to agree.  I can isolate that change as I cannot create a standalone Ingress with ingressClassName in the cluster without it also failing for the same error.  I can't find any related issue online in either skipper or AWS ingress issues, but adding the following IngressClass finally resolved it.
apiVersion: networking.k8s.io/v1
kind: IngressClass
metadata:
  name: skipper
spec:
  controller: k8s.io/skipper # Arbitrary?

I'm outside of my expertise with Kubernetes and Ingress to understand what is the issue (and likely some nuance of AWS Ingress), and I don't know if the above IngressClass will result in other unforeseen issues.  Is there something I am miss understanding?  Have others run up against any issues when using AWS Ingress?  Thanks!
Setup details:
EKS / Kubernetes version 1.23
ShinyProxy Operator version 1.1.0
Applied the 2-namespaced-ds (or near identical) configuration
Other attempts to fix that failed:
Reverting to ShinyProxy Operator 1.0.x (failed because of incompatability with Kubernetes 1.23)
Upgrading skipper to version 0.14.x (no effect)
Using hpa instead of ds (same error)
Banging head into wall (pain)

Unfortunately we don't have experience with the AWS Ingress controller. However, we recently released version 2 of the operator which no longer requires Skipper. Therefore I would like to ask to re-try using the latest version of the operator.

Thank you for reporting back! I'm very happy to hear that both the old and new version works fine.


how i can show the percent in progress bar in flutter while generating frames by using the screen recorder package?

I am wanted to show the user that frames are generating in percent

This is currently not possible. Feel free though to submit this feature as a PR.


Tests do not work out-of-box [Solution Provided]

Debug Info:
Ruby 2.1.1
Jeweler 2.0.1
Problem
Installed the Jeweler gem again, having recently upgraded to Ruby 2.1.1. Wanted to try to run the tests so I could run rake install, things blew up.
$ rake test
/Users/pierce/.rbenv/versions/2.1.1/bin/ruby -I"lib:lib:test" -I"/Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib" "/Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb" "test/**/test_*.rb"
method load_adapter is deprecated. use load_profile instead
Warning: you should require 'minitest/autorun' instead.
Warning: or add 'gem "minitest"' before 'require "minitest/autorun"'
From:
  /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/2.1.0/test/unit.rb:1:in `require'
  /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/2.1.0/test/unit.rb:1:in `<top (required)>'
  /Users/pierce/GitHub/gems/ssh-builder/test/helper.rb:26:in `require'
  /Users/pierce/GitHub/gems/ssh-builder/test/helper.rb:26:in `<top (required)>'
  /Users/pierce/GitHub/gems/ssh-builder/test/test_ssh-builder.rb:1:in `require'
  /Users/pierce/GitHub/gems/ssh-builder/test/test_ssh-builder.rb:1:in `<top (required)>'
  /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:10:in `require'
  /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:10:in `block (2 levels) in <main>'
  /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:9:in `each'
  /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:9:in `block in <main>'
  /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:4:in `select'
  /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:4:in `<main>'
MiniTest::Unit::TestCase is now Minitest::Test. From /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/2.1.0/test/unit/testcase.rb:8:in `<module:Unit>'
/Users/pierce/.rbenv/versions/2.1.1/lib/ruby/2.1.0/test/unit.rb:676:in `<class:Runner>': undefined method `_run_suite' for class `Test::Unit::Runner' (NameError)
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/2.1.0/test/unit.rb:261:in `<module:Unit>'
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/2.1.0/test/unit.rb:15:in `<module:Test>'
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/2.1.0/test/unit.rb:7:in `<top (required)>'
	from /Users/pierce/GitHub/gems/ssh-builder/test/helper.rb:26:in `require'
	from /Users/pierce/GitHub/gems/ssh-builder/test/helper.rb:26:in `<top (required)>'
	from /Users/pierce/GitHub/gems/ssh-builder/test/test_ssh-builder.rb:1:in `require'
	from /Users/pierce/GitHub/gems/ssh-builder/test/test_ssh-builder.rb:1:in `<top (required)>'
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:10:in `require'
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:10:in `block (2 levels) in <main>'
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:9:in `each'
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:9:in `block in <main>'
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:4:in `select'
	from /Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -I"lib:lib:test" -I"/Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib" "/Users/pierce/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb" "test/**/test_*.rb" ]

Tasks: TOP => test
(See full trace by running task with --trace)

Solution
Modified the following files as indicated:

test/helper.rb

SimpleCov.configure do
  clean_filters
  # load_adapter 'test_frameworks'
  load_profile 'test_frameworks'
end

# require 'test/unit'
require 'minitest/autorun'
require 'shoulda'

# class Test::Unit::TestCase
# end
class MiniTest::Test
end

MiniTest.autorun

test/test_{GEM_NAME}.rb

# class Test{GEM_NAME} < Test::Unit::TestCase
class Test{GEM_NAME} < MiniTest::Test

Conclusion
It fired right up! I hope this helps someone else who is stuck on that set of errors!

Pierce

Helped me too @rex.

Awesome! Glad I could help @tebemis @jonatasrancan :shipit:


[release/8.0.4xx] Bump to dotnet/android-tools@f53106a1

With https://github.com/dotnet/android-tools/pull/220, we now need to set $(_IncludeMicrosoftBuildPackage) for projects that need a Microsoft.Build reference.
Changes: https://github.com/dotnet/android-tools/compare/d50747cbddf6ab3e2151fc2ae3e3af76edb4fd72...f53106a126b0e2f7f34802de5e1f99be4c34ce54

dotnet/android-tools@f53106a: Bump to dotnet/msbuild@10fbfbf2
dotnet/android-tools@a2e146d: Bump to dotnet/msbuild/v17.9.5@33de0b22
dotnet/android-tools@1818d59: Bump LibZipSharp and Xamarin.Build.AsyncTask
dotnet/android-tools@75f79e7: Bump LibZipSharp to 3.1.1
dotnet/android-tools@b1f795e: [MSBuildReferences.projitems] Require opt-in to use Microsoft.Build

The failures in CustomDesignerTargetSetupDependenciesForDesigner and TestResolveToolsExists are already present on the branch, I think this should be good to go

Do we need to do the old androidtools as well (via monodroid). Looking at the commits we are at [xamarin-android-tools @ d50747c](https://github.com/xamarin/xamarin-android-tools/tree/d50747cbddf6ab3e2151fc2ae3e3af76edb4fd72) See https://github.com/xamarin/androidtools/tree/6ba69ad1c817a4d4bd5004339f4440dd9885ee4b/external

Do we need to do the old androidtools as well (via monodroid). Looking at the commits we are at xamarin-android-tools@d50747c See https://github.com/xamarin/androidtools/tree/6ba69ad1c817a4d4bd5004339f4440dd9885ee4b/external

Yes sorry good catch! it looks like all of monodroids dependencies are up to date but we were missing a couple of bumps in monodroid. I've set that up here https://github.com/xamarin/monodroid/pull/1559 and we can include once merged.

Thanks, we're down to the two failures in CustomDesignerTargetSetupDependenciesForDesigner and TestResolveToolsExists already present on the branch, should be good


Bug: serializer not working with misleading message

Description
I had some problems with a serializer not working, and displaying an error message I couldn't decipher.
The issue was a SQLAlchemy relationship that was defined using a string type instead of the type itself:
conditions: Mapped[list["AlertTemplateCondition"]] = relationship(back_populates="alert_template")
When I was trying to serialize this object and its children, this error was raised:
Traceback (most recent call last):
  File "/home/0xSwego/projects/litestar-backend-template/.venv/lib/python3.10/site-packages/litestar/serialization/msgspec_hooks.py", line 141, in encode_json
    return msgspec.json.encode(value, enc_hook=serializer) if serializer else _msgspec_json_encoder.encode(value)
  File "/home/0xSwego/projects/litestar-backend-template/.venv/lib/python3.10/site-packages/litestar/serialization/msgspec_hooks.py", line 88, in default_serializer
    raise TypeError(f"Unsupported type: {type(value)!r}")
TypeError: Unsupported type: <class 'app.domain.alerts.models.AlertTemplateCondition'>

Removing the quotes from the type fixed the issue:
conditions: Mapped[list[AlertTemplateCondition]] = relationship(back_populates="alert_template")
It'd be great if the right serializer was found even if the type is written in quotes.
URL to code causing the issue
No response
MCVE
Models:
class AlertTemplate(orm.DatabaseModel):
    __tablename__ = "alert_templates"  # type: ignore[assignment]

    conditions: Mapped[list["AlertTemplateCondition"]] = relationship(back_populates="alert_template")

class AlertTemplateCondition(orm.DatabaseModel, orm.AuditColumns):
    __tablename__ = "alert_template_conditions"  # type: ignore[assignment]

    alert_template_id: Mapped[UUID] = mapped_column(ForeignKey("alert_templates.id"))
    alert_template: Mapped[AlertTemplate] = relationship()

DTOs:
class AlertTemplateDTO(SQLAlchemyDTO[AlertTemplate]):
    config = dto.config(max_nested_depth=1)

class AlertTemplateConditionDTO(SQLAlchemyDTO[AlertTemplateCondition]):
    config = dto.config(max_nested_depth=0)

Controller:
class AlertTemplatesController(Controller):
    """Handles the interactions within the AlertTemplate objects."""

    dependencies = {"alert_template_service": provide_alert_template_service}
    return_dto = AlertTemplateDTO

    @get(
        operation_id="ListAlertTemplates",
        name="alert_templates:list",
        summary="List Alert Templates",
        path=urls.ALERT_TEMPLATES_LIST,
    )
    async def list_alert_templates(
        self,
        alert_template_service: AlertTemplateService,
    ) -> OffsetPagination[AlertTemplate]:
        """List all alert templates"""
        results = await alert_template_service.list()
        return alert_template_service.to_dto(results)

Litestar Version
2.0.1
Platform

[X] Linux
[ ] Mac
[X] Windows
[ ] Other (Please specify in the description above)

Funding

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified

Could you provide a minimal reproduction of the bug?

@guacs sure! I have taken the litestar-fullstack repo and added the code that is causing the problem:
https://github.com/0xSwego/litestar-fullstack/tree/master
I've also added a test that fails due to the error. Running pytest tests/integration/test_alerts.py will trigger it

@0xSwego I'm having some trouble reproducing this. Could you provide a minimal example with a minimal self-contained application (not the litestar-fullstack one)?

@0xSwego any updates on this?

@guacs I wouldn't know where to start from and it would take me a huge amount of time. If the issue cannot be reproduced because you have troubles with the code, I can close it.

@guacs I wouldn't know where to start from and it would take me a huge amount of time. If the issue cannot be reproduced because you have troubles with the code, I can close it.

Let me try once more to reproduce this. If I'm not able to, then we can close it.

@guacs you should be able to set up the whole project with the make install command (Unix friendly, unfortunately. I am on Windows and use WSL)

@guacs any updates?

I'm closing this since I haven't been able to create an MCVE for this. If anyone faces this issue and can provide an MCVE, please feel free to reopen the issue.


Feat:Add Social Media Icons to Footer

Describe the feature
Currently, our application lacks social media icons in the footer, which limits our users' ability to connect with us on social media platforms. Adding social media icons will enhance the user experience by providing easy access to our social media profiles and encouraging greater engagement
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

We dont have any social media page... so there is no use of adding social media icons

We dont have any social media page... so there is no use of adding social media icons

For future updates...?

Hi @chandannekya my solution of this is issue is

We can create a Footer Page component in React and integrate it to our App component so that it is visible to every web page.
In Footer section we can add Connect with Us with Social media links
And We can also also users to sign up with their Social Media account to webpage.


Improve styles for clickable elements

[x] align light/dark theme design with mockup [1]

[x] adjust hover style: remove shadow only increase stroke size to 5px

[x] set a fixed and even height for highlighted cards (see mockup)

[x] highlighted cards should not move on hover

[x] highlighted cards: text should not break on hover

Hey @chrifro,
resolving the last two items here isn't that easy when changing the border width on hover. Changing the width, causes the browser to refloat the content inside them.
Do you have an idea to get around this @nisarhassan12 ?

Did you see @jacobparis's suggestion?
https://gitpod.slack.com/archives/C0401SXP0FP/p1662393633741769?thread_ts=1662389655.629079&cid=C0401SXP0FP

closing for now, as things are resolved / or included in followup issues


Allow custom net.Listener

My problem with the current API is the Start method, as it only takes an address string. I understand the convenience of this, but would also really like a function to pass a custom net.Listener. So essentially I'm asking for something like exposing s.handleListener().
A current workaround could probably be to manually implement that method, but it's a bit of a hack.

I think that’s a fair request. I’ll take a look tomorrow to see if there’s an obvious way to do this.
For now, there is a ‘ServeConn’ method you can use - just create an accept loop and call ServeConn on the accepted connection.

@ShivanshVij thanks!

Closed as part of v0.7.2


CustomPopupMenuController hideMenu not working

I can never close the menu with controller
  CustomPopupMenuController _controller = CustomPopupMenuController();
CustomPopupMenu(                   child: Icon(                     Icons.more_horiz,                     color: Colors.black,                   ),                   controller: _controller,                   arrowColor: Colors.white,                   menuBuilder: () => TextButton(                       onPressed: _controller.hideMenu, child: Text('close'),),                   pressType: PressType.singleClick,)

The widget I used was stateless. Since I called controller in stateless, I changed my widget to statefull. Problem solved.

还是不行啊 跳到其他页面回来 可重现这个问题

你可以附上演示代码


[WIP] .NET Core Acquisition and Deployment Guide

Summary
This is a draft of the .NET Core Acquisition and Deployment Guide.

Adding @leecow @dleeapho @MichaelSimons @richlander @DamianEdwards @shawnro for review.

@rpetrusha

I'd like to discuss these changes in more detail. I think that deployment and acquisition should be kept separate.
Perhaps we create an Installation node similar to what VS docs has and add the articles related to that under that new node, including the existing pre-reqs topics.
And then we have the deployment node for anything related to packing and publishing your app.

@mairaw, I ran the checker tool extension per your feedback and all pages now have a score of 90 or higher.

I'd like to discuss these changes in more detail. I think that deployment and acquisition should be kept separate.
Perhaps we create an Installation node similar to what VS docs has and add the articles related to that under that new node, including the existing pre-reqs topics.
And then we have the deployment node for anything related to packing and publishing your app.

Putting together a flow that ties this together has been difficult, I think we have the flow now. I instead propose renaming the deployment node to Acquisition and Deployment. The index.md will start the topic, and both acquisition and deployment are separate pages/topics in the section.

That's an option for sure but I'm a bit afraid that it could make it hard for beginners to understand what acquisition means when they're trying to make sense of the TOC.
I'd like to discuss this with @rpetrusha and @BillWagner next week.

@mairaw can you help me with the doc validation error:
Markdown content is not allowed before H1. See https://aka.ms/MarkdownHeadings for more information.
I don't see the markdown before # H1 that the validation seems to think is there.

Validation issues are cleared after my changes.

Validation issues are cleared after my changes.

Thanks @mairaw!

@Thraka as requested: adding you and @richlander @leecow @rowanmiller to this PR. I think we need to discuss these changes. I strongly feel that customers don't use acquire and acquisition as their search terms when they want to install .NET Core and that the two experiences (installation and deployment) should not be together.

The structure of the docs is much improved but I think there is a simpler way to structure the pieces: Let's say that this is primarily a deployment guide since devs have gone through the "Get started" sections and acquired their .NET Core for development. Acquisition in this frame can be pared down to getting .NET Core to provision CI/CD or for application deployment.

If the developer thinks they dont need to look at acquisition they'd just skip over the acquisition link?While a dev may have already obtained .NET Core with VS for development I dont think it hurts to show the other developer options for e.g. Core with VS code,  or the CLI, etc.

The structure of the docs is much improved but I think there is a simpler way to structure the pieces: Let's say that this is primarily a deployment guide since devs have gone through the "Get started" sections and acquired their .NET Core for development. Acquisition in this frame can be pared down to getting .NET Core to provision CI/CD or for application deployment.

If the developer thinks they dont need to look at acquisition they'd just skip over the acquisition link?While a dev may have already obtained .NET Core with VS for development I dont think it hurts to show the other developer options for e.g. Core with VS code, or the CLI, etc.

@Thraka as requested: adding you and @richlander @leecow @rowanmiller to this PR. I think we need to discuss these changes. I strongly feel that customers don't use acquire and acquisition as their search terms when they want to install .NET Core and that the two experiences (installation and deployment) should not be together.

Developers don't have to use those as search terms to find the page, can/should have search terms like "install, installer, installation", etc?
In general, there's many things developers may not know when they start looking for something, I dont see that as a reason to not have that information available. For e.g. a developer may look for packaging Core apps, without knowing about MSIX or MSI packaging. That doesn't mean we don't include those 2 options I hope?
Do you have an alternative proposal?

I think it needs to be intuitive to developers that this is what they want. Also, because most people come from search when visiting docs, the main keywords need to be in the title, etc. I'll schedule a meeting to discuss this and we can go over the plan.
Don't get me wrong. I really appreciate you taking the initiative to drive this and write the docs for it. I just think that this change is not straightforward, so I think we should be in agreement on the plan and the direction we wanna take.

Additionally, this repeats a lot of information we have in other places. However, there is a lot of value in having this overview. I think we should take some time to look at other information and figure out what to retire/replace/rewrite in regard to this.

@richlander , @timheuer for review.

Just an update on this. @richlander @jamshedd @rowanmiller @leecow and I met today and discussed how we're going to approach this. We'll be closing this PR and I can send out the meeting notes to those who are interested. There were already some plans in place to address some of the changes being done here by @Thraka and I'll file new issues to break down how we want this to look like.
In short, we don't want to have an acquisition and deployment guide in the docs. Instead, this will be broken down into the different tasks like Install, Package, and Deploy as part of the TOC. But we can use the work that @jamshedd started here and he can help us to drive the individual tasks as well.

Thanks @mairaw -- I'd like to be kept in the loop thanks!

Of course. I’ll include you in the meeting notes too @timheuer!

@mairaw - I'd like to see the meeting notes - thanks.

@mairaw please cc me for the meeting notes. Thanks!

add work in progress key to title.

Converted to draft since WIP bot was disabled.

@jamshedd I think this PR might be preventing me from deleting the master branch in this repo, so I'm going to close it for now.

Reopening - this PR wasn't the cause.

I believe this can be closed. We've broken down this PR into different issues and PRs, right @Thraka?

I don't know if he gets notification for this account, so pinging @adegeo :smile:

Thanks @Youssef1313. I tried finding his new one and GitHub didn't help me 😆

I'm here!
We've done a lot yes, but there are some things in her that I think we haven't covered, hence I've been reluctant to close this PR. It still has a lot of details that we can use when we get to writing more guides around deployment and distribution.

Hi @adegeo,
If we're simply using this PR as a point of reference for future work, let's capture that in a new issue (or issues) and close this. It's been open for 600 days as of right now. I doubt leaving it open any longer will help. It will remain here, and the new issues can point to it for details they may need.
Would you like to create the issues, assuming you know the specifics we'd want to take from these bits? I'm closing this now.


It only generates 2 sec long video

Everything works fine, but it only generates 2 sec long video.
How do I generate it longer than 2 sec?

change the frame_load_cap value on Load Video node


chore(ci): Split test types into own stages

This change splits the 3 test types (doc, unit, integration) into their
own stages for better parallelization and better visibility into which
type of test fails.
Ref: LOG-20344


About mIoU result on Cityscapes validation dataset

Hi,
Thanks for your work and providing code. I am just confuse about the mIoU reported in the paper on cityscapes validation dataset which is around 77%. Kindly let me know is this mIoU achieved on pretrained model (imagenet)? I am training DDR-Net-Slim23 from scratch and I am getting around 55% mIoU on validation data of Cityscapes.

Thank you. I guess you have also use validation dataset in training images that's may be the reason of high mIoU? I am just using 2975 training images of cityscapes dataset for training the model.

Thank you. I guess you have also use validation dataset in training images that's may be the reason of high mIoU? I am just using 2975 training images of cityscapes dataset for training the model.

I didn't use validation dataset for training given that the network is evaluated on it. I use validation dataset for training to submit the results to the official server (evaluation on test set).


[NVIDIA XLA] FP8 Matmul BiasAdd fusion for high rank input

This PR complete the coverage for FP8 matmul when input is high rank tensor. @philipphack

Hi @wenscarl Can you please resolve conflicts? Thank you!

This PR is not stale. It requires https://github.com/tensorflow/tensorflow/pull/60409 to be merged first. I'll reopen if automatically closed.

@reedwm The top of master seems to fail those tests in gemm_rewrite_test.cc which prevents from rebasing.

Hi @reedwm Can you please review this PR ? Thank you!

@wenscarl thanks for addressing all my comments! Can you resolve conflicts?

@wenscarl thanks for addressing all my comments! Can you resolve conflicts?

The gemm_rewrite_test did not pass for the current master. Could you take a look?

The gemm_rewrite_test did not pass for the current master. Could you take a look?

It's passing for me. I tried on https://github.com/openxla/xla/commit/d7b3b230abca3bc7adafeff7344aaafc6e6994dc with bazel test //xla/service/gpu/tests:gemm_rewrite_test and it passes. What commit are you synced to and what command are you using to run?

I also tried on the TF repo at 35af49017480ee112fc8c9850862f1eb61d611ee, since this PR is on the TF repo. It still passes for me.

I also tried on the TF repo at 35af490, since this PR is on the TF repo. It still passes for me.

I tried the same commit, Used TF_CUDA_CLANG=0 in .bazelrc. BatchRowTransposeFoldCheck, BatchFromMinorDimTransposeIsNotFolded, BatchedInstrLayoutTransposed, BatchedInstrLayoutBatchNotInMinorDim failed.

I'm also using TF_CUDA_CLANG=0. I'm using CUDA 12.1.1 with cuDNN 8.9.1. What version of CUDA/cuDNN are you using? And what's the error message?

I'm also using TF_CUDA_CLANG=0. I'm using CUDA 12.1.1 with cuDNN 8.9.1. What version of CUDA/cuDNN are you using? And what's the error message?
Seeing :

Mismatch count 4 (10.0000%) in shape f32[2,5,4] (40 elements), abs bound 1e-05, rel bound 1e-05
Top relative error mismatches:
  actual         0.000914607197, expected         0.000930683687, index {1,2,2}, rel error   0.0173, abs error 1.61e-05

while testing BatchedInstrLayoutTransposed on Hopper.

What version of CUDA and cuDNN are you using?

What version of CUDA and cuDNN are you using?

cuda 12.1 + cudnn 8.9.2

I think it's fine to just increase the test tolerance, since the error is almost within tolerances already.

Fixes by #61415

@wenscarl can you sync past #61415?


Expose TopicUtil or use it internally

Why is src/test/java/com/relayrides/pushy/apns/TopicUtil.java not publicly available for usage or used to simplify the library behind the scenes? It has a nice method to extract the topic aka. bundle identifier from the certificate which could reduce the SimpleApnsPushNotification constructor to two arguments. There is no need to specify the topic since that information is already available, especially in the most simple sending scenario. Obviously, 3 arg constructors with explicit topic can be left as is. Any specific reasons why this isn't used already?

Any specific reasons why this isn't used already?

Yes. It depends on BouncyCastle, which is a bigger dependency than I think we should impose upon end users for this one feature. Additionally, certificates will be going away entirely soon and will be replaced by bare private keys, which generally don't have metadata (i.e. topics) attached. Even if there weren't a dependency issue, I think the upcoming protocol changes mean that we shouldn't decrease visibility of topics even if there were no dependency issues.
Please see #314 for details of the upcoming token-based authentication scheme and #348 and #323 for discussion about why we don't want to automate topic handling in the near term.

I just hacked together a function using TopicUtil as a sample and did not require BouncyCastle anywhere since the default topic can be parsed from certificate UID. At least for the regular case, BouncyCastle is not needed.
I guess it's fine if certs are being ditched in the future. Thank God for that at least.

the default topic can be parsed from certificate UID

True, but the secondary topics are stored in a certificate extension. To read those, we need to parse ASN.1 primitives, and that's where the BouncyCastle dependency comes in.

I guess it's fine if certs are being ditched in the future. Thank God for that at least.

Well, don't let me get your hopes up too much—I think it's actually going to be a little more complicated in most cases. My understanding right now is that users will need to:

Give Pushy a private key for a given team ID.
Tell Pushy which topics are associated with that team ID.
Always specify a topic when sending notifications.

We'll see how things shake out, though.


Untested adding comments to capistrano

Somewhat WIP. It should work, but testing it proved to be more work than it was worth it if someone else can do it in a minute.

Closing this in favor of https://github.com/rollbar/rollbar-gem/pull/460


Maintenance windows exports are not usable

Describe the bug
Very closely related to https://github.com/dynatrace-oss/terraform-provider-dynatrace/issues/138. An error occurs on terraform apply when using exported maintenance windows from dynatrace that doesn't contain tags. It seems that trying to apply the exact same exported resource(once removed from Dynatrace) will fail with errors about requiring tags(declared optional in provider documentation).
To Reproduce
Steps to reproduce the behavior:

Export all Maintenance Windows via 1.12.1 provider
Select a maintenance window(an export) that looks like

resource "dynatrace_maintenance_window" "maintenance_test" {
  name        = "maintenance_test"
  description = "test"
  type        = "PLANNED"
  # suppress_synth_mon_exec = false
  suppression = "DETECT_PROBLEMS_DONT_ALERT"
  schedule {
    end             = "2022-08-12 04:00"
    recurrence_type = "ONCE"
    start           = "2022-08-11 20:00"
    zone_id         = "Pacific/Auckland"
  }
  scope {
    matches {
      type            = "CUSTOM_DEVICE"
      tag_combination = "AND"
    }
  }
}

Run terraform plan and then terraform apply
See error below about missing tags:

dynatrace_maintenance_window.maintenance_test: Creating...
╷
│ Error: {
│   "code": 400,
│   "message": "Constraints violated.",
│   "constraintViolations": [
│     {
│       "parameterLocation": "PAYLOAD_BODY",
│       "location": "",
│       "message": "must not be null",
│       "path": "scope.matches[0].tags"
│     }
│   ]
│ }
│
│   with dynatrace_maintenance_window.maintenance_test,
│   on maintenance_test.tf line 1, in resource "dynatrace_maintenance_window" "maintenance_test":
│    1: resource "dynatrace_maintenance_window" "maintenance_test" {

Expected behaviour
A maintenance window to be created in Dynatrace SaaS that reflects the exported resource - these have been proven and created successfully using the UI in Dynatrace.
Screenshots
Below is the configuration that can be exported successfully, although this cannot be applied.

Desktop (please complete the following information):

OS: Linux Mint 20.3
Terraform Version: v1.0.11
Dynatrace Provider Version: 1.12.1

I have found another instance of an exported maintenance window that is failing:
resource "dynatrace_maintenance_window" "test_scope" {
  name = "test_scope"
  type = "PLANNED"
  # suppress_synth_mon_exec = false
  suppression = "DETECT_PROBLEMS_DONT_ALERT"
  schedule {
    end = "2022-07-10 05:00"
    recurrence_type = "ONCE"
    start = "2022-07-10 00:50"
    zone_id = "Pacific/Auckland"
  }
  scope {
  }
}

The error message below suggests scope should include more details although this is not provided in the UI or from the export above:
Error: { "code": 400, "message": "Constraints violated.", "constraintViolations": [ { "parameterLocation": "PAYLOAD_BODY", "location": "", "message": "The scope must contain at least one entity or one matches filter.", "path": "scope" } ] }

Hello everyone,
Release 1.13.1 is scheduled for coming Friday. It will be able to handle maintenance windows without tags / scope specified. The export functionality will furthermore omit the whole scope block in case it doesn't contain any content.
regards,
Reinhard

Release v1.13.1 takes care of this issue.


VerbInfo should have a Description member

VerbInfo only has Group and Verb members, would be convenient to have a Description member

Steps to reproduce
PS> get-verb

Expected behavior
Verb        Group        Description
----        -----        -----
Add         Common       Foo
Clear       Common       Bar

Actual behavior
Verb        Group
----        -----
Add         Common
Clear       Common

Environment data

Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.6
OS                             Microsoft Windows 10.0.16350
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Great idea; related: also outputting the alias prefixes associated with each verb (e.g., g for Get): #4372


Pimax HMD always ON

I have PimaxClient v <IP_ADDRESS> installed. BSManager v 2.4.1 does not recognize the closure of PimaxClient, thinks that PimaxClient is always on.

Does BSManager v 2.4.1 support PimaxClient or can it only work with Pitool?

My base stations 2.0 turn off and on, but not by turning on/off the PimaxClient, as I thought, but by turning on/off the VR headset via a button on its body.


Add labels to issue data

Implement the possibility of storing the labels assigned to an issue at the creation or immediately after.
Take inspiration from this possible snippet of code. Maybe is better to separate the normal storing of the issues with this events logic otherwise we risk to use too many requests.
import os
from github import Github, Auth
import pandas as pd
from tqdm import tqdm

# Authenticate using a personal access token
assert "GITHUB_AUTH_TOKEN" in os.environ, "Please set the GITHUB_AUTH_TOKEN environment variable"
auth_token = os.environ["GITHUB_AUTH_TOKEN"]
auth = Auth.Token(auth_token)
g = Github(auth=auth)

# Access the repository
repo = g.get_repo("microsoft/vscode")

# Get issues (you can specify 'state' and other parameters as needed)
issues = repo.get_issues(state="all", direction="asc")

issue_data = []

with tqdm(total=issues.totalCount, ncols=100) as pbar:
    for issue in issues:
        pbar.update(1)
        pbar.set_description(f"Processing issue {issue.number}")

        # Skip issues beyond a certain number if needed
        if issue.number > MAX_ISSUE_ID:
            continue

        # Fetch issue creation time
        issue_creation_time = issue.created_at

        # Fetch issue events
        events = issue.get_events()

        labels_added_at_creation = []

        for event in events:
            if event.event == 'labeled':
                label_added_time = event.created_at
                label_name = event.label.name if event.label else None
                time_difference = abs((label_added_time - issue_creation_time).total_seconds())

                # Threshold to consider label added at creation (e.g., 60 seconds)
                if time_difference < 60:
                    labels_added_at_creation.append(label_name)

        issue_info = {
            "github_id": issue.number,
            "title": issue.title,
            "body": issue.body,
            "assignee": issue.assignee.login,
            "created_at": issue.created_at,
            "closed_at": issue.closed_at,
            "labels_at_creation": labels_added_at_creation,
            # Add other fields as needed
        }
        issue_data.append(issue_info)

# Convert to DataFrame
df = pd.DataFrame(issue_data)
df.to_json(ISSUES_FILE, orient="records")

con il seguente codice penso di aver implementato quanto suggerito per una singola issue (per testing)
tuttavia si comporta in maniera anomala
    issue = repo.get_issue(number=         )     events = issue.get_timeline()     created_labels = []     for event in events: #todo non ho capito perche ritorna "bug" con la issue 219965. e non prende le altre label?         if event.event == "labeled":             if ((event.created_at - issue.created_at).total_seconds()) < 60:                   label_name = event.raw_data.get("label", {}).get("name")                 created_labels.append(label_name)

Feature maintained in a separate branch but not used for the logic in the final submission.


Add WARNS check.

The SIGNALS check can correctly detect whether a block of code signals
a warning, but it also aborts the code block's execution. That's
appropriate for checking for an error, but not for a warning. This new
check confirms that a warning of a particular class is raised, a la
SIGNALS, but also allows the block of code in its scope to complete,
which may be more natural for some cases.

If you would like such a mod, I could do it. I didn't do it before because changing SIGNALS would not be backward-compatible -- it could break users' previously existing tests -- but WARNS would not because it's wholly new.
Let me know what you would prefer, and I will do one of the other.

I have a new version of this, but it turned into a kludge, because it required some DWIMing.
The reason that the previously-existing signals macro does not return the value of the signaling expression is that that value may not be well-defined, especially when the condition signaled is a subclass of error.
So my DWIMed-up version of signals has the following 2 special cases:

If the condition signaled is an error, then we simply return nil from the test-expression, as the original version of signals did.
If the condition is a warning, we muffle that warning and continue.

In all cases except error, signals returns all values returned by evaluating its body.
Honestly, I think what would have been best would be either to pull the error special case out of signals and use signals only for conditions that continue, keep the original proposal and just add warns, or add an argument to signals to indicate whether you want the value of the body form (this last seems awfully fussy).
I have pushed the latest, kludgy version to this PR so you can look it over and make a choice.


[MINOR][TEST]  Tables created  in unit tests should be dropped after use

What changes were proposed in this pull request?
Tables should be dropped after use in unit tests.
How was this patch tested?
N/A

Test build #81509 has started for PR 19155 at commit 8672ab9.

Test build #81509 has finished for PR 19155 at commit 8672ab9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81509/
Test FAILed.

Test build #81514 has started for PR 19155 at commit 1e4f1af.

Test build #81514 has finished for PR 19155 at commit 1e4f1af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81514/
Test PASSed.

Merged build finished. Test PASSed.

Since it's a big patch, +408 −359, we had better have a JIRA issue with 'TRIVIAL` priority.

Test build #81533 has started for PR 19155 at commit 1d38337.

@dongjoon-hyun  thanks, I have created  a JIRA issue.

Test build #81533 has finished for PR 19155 at commit 1d38337.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81533/
Test PASSed.

Thanks! Merged to master.


Update index.html

Modify time it took to finish task, only show it when user clicks checkbox.

Approved.
This update fixed the issue from pull request #4


Hide the (currently empty) description field

Description
This small PR hides the description field, which is currently empty.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore (non-breaking change that does not add functionality or fix an issue)

P.S. Nice work!

@meowgorithm Thank you so much for your contribution! Amazing! 😃


Recipe: setup for the Delegated Administration Dashboard

Create a recipe that performs all the setup required for the Delegated Administration Dashboard as described in the Configure the extension section of the docs.

working on it

initial basic client create api call created, not yet functional.

@rrexford: I had to back out your commits as it wasn't compiling and you accidentally committed your .auth0-reset-tenant-env file (which has all your tenant secrets 😨).
Here was the contents of the delegatedadmin.js file that you had so we can get this working in a future commit:
{
  "name": "delegatedadmin",
  "client_secret": "PIoABpfZU-XBaKnzRiSleaPEgN9P1z0BspneEv0kKoro7o_SXow6VS03UAR4BUPj",
  "logo_uri": "http://localhost/"
  "allowed_clients": [
    ""
  ],
  "allowed_logout_urls": [
    "http://localhost/logoutCallback"
  ],
  "token_endpoint_auth_method": "",
  "app_type": "",
  "is_first_party": false,
  "jwt_configuration": {
    "lifetime_in_seconds": 0,
    "secret_encoded": true,
    "scopes": {},
    "alg": ""
  },

  "sso": false,
  "custom_login_page_on": false,
  "custom_login_page": "",
  "custom_login_page_preview": "",
  "form_template": "",
  "is_heroku_app": false,
  "addons": {
    "aws": {},
    "azure_blob": {},
    "azure_sb": {},
    "rms": {},
    "mscrm": {},
    "slack": {},
    "box": {},
    "cloudbees": {},
    "concur": {},
    "dropbox": {},
    "echosign": {},
    "egnyte": {},
    "firebase": {},
    "newrelic": {},
    "office365": {},
    "salesforce": {},
    "salesforce_api": {},
    "salesforce_sandbox_api": {},
    "samlp": {},
    "layer": {},
    "sap_api": {},
    "sharepoint": {},
    "springcm": {},
    "wams": {},
    "wsfed": {},
    "zendesk": {},
    "zoom": {}
  },
  "resource_servers": [
    {
      "identifier": "api.tenant.com",
      "scopes": [
        "read:something"
      ]
    }
  ],
  {
  "name": "default username password database connection",
  "strategy": "auth0",
  "options": {
    "validation": "object",
    "passwordPolicy": "",
    "password_history": "object",
    "password_no_personal_info": "object",
    "password_dictionary": "object"
  },
  "enabled_clients": [
    "haq6QtbzMhSGhGpDnUPuecFoordCiJiC"
  ]
}
    }
  }
}


Change default "open with"

What feature or improvement do you think would benefit Files?
It would be great to have the ability to change the "open with" setting for file types.
For example if I want to change the default player for MP4 files.
Requirements
Add the setting
Files Version
3.0.3
Windows Version
Windows 11 Pro 23H2 22635.2700
Comments
No response

You should be able to access this from the right click menu. Can you give this a try?

You're right my mistake. I was trying to see the setting in the "properties" menu like on the Microsoft Explorer. Sorry.


Remove Zabbix 2.2 Packages

End of life was August, 2019.
Ports will expire after November, 30 on FreeBSD.

[x] Redmine Issue: https://redmine.pfsense.org/issues/9880
[x] Ready for review

Already removed without using this patch. Sorry.


bertieb: Watch poeinjector.net

bertieb requests the watch of the watch_keyword poeinjector\.net. See the MS search here and the Stack Exchange search here.

poeinjector\.net has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Built releases

Would it be possible to have a release builds of the major versions on Github?
They do have a good releases feature.
I don't use the Arduino IDE, just the ESP Open SDK - but I would be really happy to see a binary that can be flashed to try it out.

Hi @deviousasti,
I also thought about this, but the problem is that the number of LEDs and the name of the device (along with other settings) is part of the code and I didn't manage so far to make this dynamic. So a release would always work for a given number of LEDs and a static hostname. And that's not too useful.
If anyone has an idea how to solve this, this would be great.
Regards
Tobias


scrollbar cover the content on horizental mode in pre bracket

Bug reports must include:

macOS
Chrome
v4.3

duplicate of https://github.com/twbs/bootstrap/issues/28498


Skip analyzing generated code in SA1205

SA1205 missed the change to skip running on auto-generated code. This change corrects that.

Looks good to me :+1:


Can't use history type + default value?

I'm currently using useQueryState like so:
  const [page, setPage] = useQueryState(
    'page',
    queryTypes.integer.withDefault(1)
  );

And would like to also add { history: 'push' } but can't seem to figure it out from the docs. Any help would be appreciated :pray:
Awesome library!

Try this:
const [page, setPage] = useQueryState(
  'page',
  {
    ...queryTypes.integer.withDefault(1),
    history: 'push'
  }
);

Hey that works! Thanks @franky47


Thanks & WebRTC question

Hey !
Your module is really usefull Arut ! I love it ! Thanks a lots :-)
I have just replaced Red5 by your module, for our webcam chat, it's perfect !
Did you plan to add the support of WebRTC please ?
I known the 1st goal of WebRTC is to send/receive webcam in P2P, but this could be very good to receive a webcam to permit to stream it to many persons at the same time (this prevent the user to send it to each user, and save the user upload bandwidth).
If yes, this could be really amazing !

+1
and may helps a bit : https://github.com/kurento

+1 webRTC publisher to nginx-rtmp-module

+100
On Dec 29, 2014 11:17 PM, "Ubu the Tech Guru"<EMAIL_ADDRESS>wrote:

theres already a solution for livestreaming a webRTC video conference. I
use OBS.
—
Reply to this email directly or view it on GitHub
https://github.com/arut/nginx-rtmp-module/issues/207#issuecomment-68328878
.

+1 webRTC publisher to nginx-rtmp-module

On Apr 17, 2016, at 10:58 PM, Loong Chang<EMAIL_ADDRESS>wrote:
+1 webRTC publisher to nginx-rtmp-module
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

1 webRTC

+1

+1

+1 to WebRTC publishing

+1 for WebRTC. Just look at this: https://github.com/atyenoria/janus-webrtc-gateway-docker Any ideas?

+1 to WebRTC publishing

+1

+1

+1

+1

+1

+1

This would be really great. Any news?

@lookapanda I've created this ticket 4 or 5 years ago. Even if this was in the plan of @arut , I suppose he doesn't have enough time to work on this.

Yeah but I saw that there was still recent activity

+1

+1 , 2018 !!! , any news ?

+1, Any news? Thanks

+1

Isn't there a quick way to implement a "WebRTC to RTMP Adapter" like the one Ant Media Server is using?
This would make this module invaluable, because Flash Player support is diminishing constantly.
So it should work like this:
WebRTC -> Server -> (Adapter makes it an RTMP stream) -> send to RTMP endpoint of nginx server as usual

I think this issue should be opened, as this is VERY IMPORTANT!

For anyone still wondering about this, you could just use janus, which is a general purpose WebRTC server/client solution.

@flexmarkets maybe you could make use of that? https://github.com/godka/kurento-rtmp

+1 for webrtc. hope to see it very soon.

+1

+1 for webrtc

any news? @arut  it has been 6 years, we all will be extremely happy to hear something about webrtc support

+1 for webrtc

+1 webRTC publisher to nginx-rtmp-module

if WebRTC is added...this would be one of the greatest [and I dare to say, the best nginx module ever]
will try to work on it on my spare time


Dimension Table Enhancements

[ ] #905
[ ] #906
[ ] #907
[ ] #908
[ ] Add svelte animations to the dimension table (on sort, select etc.)
[ ] #909
[ ] #910

@djbarnwal , I am reviewing the related branch now and I want to help you focus this additional effort.
P0: Reference bars for each cell in the table is in scope, this was part of the mock we drew in Figma and a huge value add to get an impression of the data.
https://github.com/rilldata/rill-developer/issues/908
P2: Svelte animations on interaction are always fun and make the application feel polished and responsive.  Please timebox.

[ ] Add svelte animations to the dimension table (on sort, select etc.)

P3
Not in Scope: These features are great ideas, but they are planned in other initiatives and have a larger scope than this table. Let's hold off for now and pivot to the work laid out as top priorities for the next release when you are done with the above.
https://github.com/rilldata/rill-developer/issues/909
https://github.com/rilldata/rill-developer/issues/910
https://github.com/rilldata/rill-developer/issues/906

Closing this as most of the work tracked under this ticket is done and rest needs further prioritization and scoping


Allow deserializing subfields of composed data structure like records and tuples.

Instead of deserializing the entire data, it should be sometimes more efficient to just look at particular subfields, e.g., when iterating over encoded data to access only a known sub-element.
Ideally, resolving this issue would enable a [@bin_fields] annotation for data structures supporting such a feature.
This annotation is to be supported by a ppx that would somehow combine  bin_prot and  fields_conv.

bin_prot isn't easily seekable, but there could still be some kind of work to be saved here allocating temporary objects, and using the shapefile to guide deserialization instead of generated code. depending on how good ocaml gc is at young object nursery and traversing shapefile vs running code, i could see this being a bunch of complexity for extraordinarily marginal gain.
are there concrete callsites that we know to be slow and can use as index to measure the maximum gain to speedup from any improvements here?


feat: Refactor inspection services to be "on demand" style

Fixes: #579

This looks pretty good to me. A lot of async layering but it probably needed that anyway. If you can get this to pass the tests completely then I'd say your close to pushing it. See what @igarashitm thinks about the lib side as well.

Thanks! Hopefully the failing UI test is now fixed. The issue with not loading mappings properly is also resolved so it's all functional. I'll address other items that @igarashitm has spotted now.

@rkorytkowski did you see the parent complex fields are now expanded by default in the stories? You can see it from the Chromatic "UI Review" GitHub check
https://www.chromatic.com/pullrequest?appId=60c26c6784efc9003bf6c3bb&number=3604
Maybe just because the children are already filled in the static stories, but wanted to make sure.


Environment Variables not working

Description
Environment variables are undefined
Steps to reproduce

gridsome create test1
cd test1
start editor (we use visual code, so we type code . to start editor
create new file ".env.development" in same folder as gridsome.config.js
add line TESTAPI=123
save file
edit index.vue
add the following :

  mounted: function() {
    console.log(process.env.NODE_ENV);
    console.log(process.env.TESTAPI);
  }

9 . save file
10. run project "gridsome develop"
11. View console output
12. it display
development
undefined

Expected result
We expected
development
123
What should happen?
the value of TESTAPI displayed in the console
Actual result
displays undefined
Environment

Libs:
- gridsome version: 0.7.7
- @gridsome/cli version: 0.3.0

Browser:
- [x ] Chrome (desktop) Version 77.0.3865.90 (Official Build) (64-bit)

For Tooling issues:
- Node version: 10.16.3
- Platform:  windows

Others:
>

You have to prefix your enviroment variable with GRIDSOME_ if you want to use it in the client side such as showing in the console. try GRIDSOME_TESTAPI
ENV DOCS

And where in documentation i can read about GRIDSOME_ ?
https://i.imgur.com/6cS5xZb.png
Can you explain who you are writing the documentation for, for yourself?
Thanks for gridsome, i love them.

@seriiserii825 you can find the reference to the GRIDSOME_ prefix in the section "Usage in the browser"

Sorry, you are right.

Same issue here.
I'm trying to use an Instagram token inside an axios call.
Token is called from .env file and logs undefined, both with GRIDSOME_ prefix and without it.
Any clue? maybe some pkg missing? this is my package.json:
{   "name": "vallvuler-2021-gridsomewp-front-end",   "private": true,   "scripts": {     "build": "gridsome build",     "develop": "gridsome develop",     "explore": "gridsome explore"   },   "dependencies": {     "axios": "^0.21.1",     "buefy": "^0.9.4",     "bulma": "^0.9.2",     "gridsome": "^0.7.23",     "sass-loader": "^10.1.1",     "vue-feather-icons": "^5.1.0"   },   "devDependencies": {     "node-sass": "^5.0.0",     "style-resources-loader": "^1.4.1",     "vue-svg-loader": "^0.16.0"   } }
Thanks in advance.


Android Export Issues

Tested versions
Redot 4.4 dev
System information
Win 10
Issue description
Exporting with android currently errors under these separate circumstances:

Without custom java path
currently need to use experimental custom java path option in order to get export process moving, else it fails with reports of gradle 8.2 not finding class paths. It seems to be hard coded in the engine that it's looking for a version of open jdk 17 or similar.

Exporting with include debug on
The error message reports not being able to find an engine image file for mipmap/icon_background. I've confirmed this does exist in engine so there's likely a path issue somewhere related to something being "godot" and not "redot"

Debug not included
Export fails with a report of not being able to locate a keystore. I've tried changing the keystore section in both platform export and in the engine general settings tabs.

Steps to reproduce
see above
Minimal reproduction project (MRP)
N/A

The custom Java path has been addressed in 4.3 #849  and needs to be moved in to 4.4