Added webcam support for Linux

I added webcam support for Linux.
I used libv4l2 which is dynamically loaded if present. If it is not present the kernel default v4l2 library is used.
It should be able to grab images even without libv4l2 if the camera supports RGB output directly.
With libv4l2 the image is always grabbed as RGB8 image.
I also implemented a simple hotplug feature which just checks the /dev/video* files every second.
I tested it with the TestCameraServer Project from https://github.com/BastiaanOlij/godot3_test_projects.git
I could only test for TYPE_IO_MMAP as my camera only supports this, but I implemented also the other types using the information provided by https://kernel.readthedocs.io/en/latest/media/uapi/v4l/capture.c.html

Production edit: This partially addresses https://github.com/godotengine/godot/issues/46531.

Ah as I want to mention. I would also like to push it to the godot 3.x branch, but therefore the Vector<uint8_t> must be changed to PoolVector<uint8_t>. But i guess it should be cherrypicked after this one is merged?

Ah as I want to mention. I would also like to push it to the godot 3.x branch, but therefore the Vector<uint8_t> must be changed to PoolVector<uint8_t>. But i guess it should be cherrypicked after this one is merged?

Yes that would be a cherry pick :)

Does this code support setting the scene's Environment to be the webcam stream?  I have tried to do this and am just getting a black sky.
Code source: I merged this code into our Godot 3.2 fork here:

Commit adding this code (doesn't compile in Godot 3.2)
Commit adjusting Vector to PoolVector to get to work on Godot 3.2 (does compile in Godot 3.2)

Using this to run godot with a webcam located at /dev/video0 (verified to work outside of godot) and with
environment.set_background(BG_CAMERA_FEED)

set results in
libv4l2 found.
Registered camera UVC Camera (046d:0825) (/dev/video0) with id 1 position 0 at index 0
/dev/video1 is no video capture device.

but with a black background; moreover, the webcam doesn't even turn on.
Tracing the source of the issue: I've discovered that the specific failure is located in RasterizerSceneGLES3::render_scene, where feed.is_valid() evaluates to false, causing the webcam texture to not get drawn in the background/Environment:
				if (feed.is_valid() && (feed->get_base_width() > 0) && (feed->get_base_height() > 0)) {
					// copy our camera feed to our background

					glDisable(GL_BLEND);
					glDepthMask(GL_FALSE);
					glDisable(GL_DEPTH_TEST);
					glDisable(GL_CULL_FACE);
// ...

After some fidgeting I got this to work, but only from gdb: https://www.youtube.com/watch?v=KhTs9uriXDQ
bool CameraFeedX11::activate_feed() {
	// activate streaming if not already
	if (!device->streaming) {
		if (!device->check_device()) {
			return false;
		}
		if (!device->request_buffers()) {
			device->close();
			return false;
		}
		if (!device->start_streaming(this)) {
			device->cleanup_buffers();
			device->close();
			return false;
		}
	};

	return true;
};

If I manually step through this via gdb (n over and over through this function), then the webcam starts.  If I don't use gdb to step through like this, then it fails.  There must be some sort of async issue going where pauses are necessary to get it to work.

If I manually step through this via gdb (n over and over through this function), then the webcam starts. If I don't use gdb to step through like this, then it fails. There must be some sort of async issue going where pauses are necessary to get it to work.

Does it work if you call OS::get_singleton()->delay_msec(100) every now and then in that function?

If I manually step through this via gdb (n over and over through this function), then the webcam starts. If I don't use gdb to step through like this, then it fails. There must be some sort of async issue going where pauses are necessary to get it to work.

Does it work if you call OS::get_singleton()->delay_msec(100) every now and then in that function (with possibly larger or smaller values)?

Yes, changing the function to the following makes now it work without having to manually step through it w/GDB:
bool CameraFeedX11::activate_feed() {
	// activate streaming if not already
	if (!device->streaming) {
		OS::get_singleton()->delay_usec(100);
		if (!device->check_device()) {
			return false;
		}
		OS::get_singleton()->delay_usec(100);
		if (!device->request_buffers()) {
			device->close();
			return false;
		}
		OS::get_singleton()->delay_usec(100);
		if (!device->start_streaming(this)) {
			device->cleanup_buffers();
			device->close();
			return false;
		}
	};

	return true;
};

	fd = funcs->open(dev_name.c_str(), O_RDWR | O_NONBLOCK, 0);

O_NONBLOCK is used in the calls to funcs->open, which is probably what's causing the async issue here.

The webcam image is also left-right inverted when shown in the Environment.

Hey all - excited to see this. I'm trying to reproduce with a build from the fork. I get both a usb web cam and CV1 external cameras detected with libv4l2 in the log and can get them via CameraServer.feeds() but can't figure out how to activate or retrieve the texture in gdscript. Do I need to do something in native?

Will this work with a v4l2loopback-device? (eg Screencapture/OBS)

@georgewsinger

The webcam image is also left-right inverted when shown in the Environment, which is fixed by a call to img->flip_x() in V4l2_Device::get_image.

I don't think this should be done in the module, because sometimes it depends on the webcam what kind of picture it sends. In my opinion such things should be done in the shader.

	fd = funcs->open(dev_name.c_str(), O_RDWR | O_NONBLOCK, 0);

O_NONBLOCK is used in the calls to funcs->open, which is probably what's causing the async issue here.

To solve this async issue I guess your proposal with the little delay is best. What do the others think. I do not think that making the open call blocking is a good idea
@MrJustreborn

Will this work with a v4l2loopback-device? (eg Screencapture/OBS)

Yes it works also with a v4l2loopback device (I tested this)

I'm still missing something in terms of how to get a basic test scene running. It seems like CameraServer should be returning feeds as CameraX11 objects, but invoking functions on the returned object yields a 'non-existent function' error. Any suggestions for setup or scene links?
Also, should instance be instantiate with the current head of master as the compiler suggests? Possibly there is a breaking change made after this PR was authored?
[ 65%] modules/camera/camera_x11.cpp: In member function 'void V4l2_Device::get_image(Ref<CameraFeed>, uint8_t*)':
modules/camera/camera_x11.cpp:556:13: error: 'class Ref<Image>' has no member named 'instance'; did you mean 'instantiate'?
  556 |         img.instance();
      |             ^~~~~~~~
      |             instantiate
[ 65%] Compiling ==> editor/rename_dialog.cpp
modules/camera/camera_x11.cpp: In member function 'void CameraX11::update_feeds()':
modules/camera/camera_x11.cpp:690:41: error: 'class Ref<CameraFeedX11>' has no member named 'instance'; did you mean 'instantiate'?
  690 |                                 newfeed.instance();
      |                                         ^~~~~~~~
      |                                         instantiate
scons: *** [modules/camera/camera_x11.linuxbsd.tools.64.o] Error 1
scons: building terminated because of errors.

Also, should instance be instantiate with the current head of master as the compiler suggests?

Indeed, instance() was renamed to instantiate() in master.

Updating the .cpp to use instiantiate() compiles just fine (thx for the detailed change list).  If i include GDCLASS(CameraFeedX11, CameraFeed); in the header file the server and feeds are recognized as the X11 class types... but they still don't have the expected methods from CameraFeed like get_name() - I notice some of the other modules include code to explicitly bind methods along with the GDCLASS clause:
//.h
protected:
	static void _bind_methods();

//.cpp
void GLTFTexture::_bind_methods() {
	ClassDB::bind_method(D_METHOD("get_src_image"), &GLTFTexture::get_src_image);
	ClassDB::bind_method(D_METHOD("set_src_image", "src_image"), &GLTFTexture::set_src_image);

I'm a little out of my depth on the c++ front so making some guesses - is something like the above required to invoke inherited class functions from gdscript in v4?

well, this explains a lot: https://github.com/godotengine/godot/blob/master/servers/camera/camera_feed.cpp#L36-L37 (turns out manually binding the methods in camera_x11.cpp does help... because the parent class currently disables them in master)

From what I can piece together, the circumvented CameraFeed code is impacted by both the refactoring of VisualServer (to RenderingServer and maybe some other places?) and the noted Vulkan refactoring.  The required porting appears to include:

RenderingServer->texture_create()
RenderingServer->texture_allocate()
RenderingServer->texture_set_data()

Is there a thread of work covering this or would it just be an isolated PR?
Are rendering_device or renderer_storage the right places to look for replacements?

A patch for camera feed (tested only on macOS), base size parameters or CameraTexture class might need some additional changes, currently it's not matching half size CbCr texture, but you need a custom shader to combine textures, so it probably not an issue:
diff --git a/servers/camera/camera_feed.cpp b/servers/camera/camera_feed.cpp
index eab4c61591..0600add6d5 100644
--- a/servers/camera/camera_feed.cpp
+++ b/servers/camera/camera_feed.cpp
@@ -33,8 +33,6 @@
 #include "servers/rendering_server.h"

 void CameraFeed::_bind_methods() {
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
 	// The setters prefixed with _ are only exposed so we can have feeds through GDNative!
 	// They should not be called by the end user.

@@ -54,7 +52,6 @@ void CameraFeed::_bind_methods() {

 	ClassDB::bind_method(D_METHOD("_set_RGB_img", "rgb_img"), &CameraFeed::set_RGB_img);
 	ClassDB::bind_method(D_METHOD("_set_YCbCr_img", "ycbcr_img"), &CameraFeed::set_YCbCr_img);
-	ClassDB::bind_method(D_METHOD("_allocate_texture", "width", "height", "format", "texture_type", "data_type"), &CameraFeed::allocate_texture);

 	ADD_GROUP("Feed", "feed_");
 	ADD_PROPERTY(PropertyInfo(Variant::BOOL, "feed_is_active"), "set_active", "is_active");
@@ -68,7 +65,6 @@ void CameraFeed::_bind_methods() {
 	BIND_ENUM_CONSTANT(FEED_UNSPECIFIED);
 	BIND_ENUM_CONSTANT(FEED_FRONT);
 	BIND_ENUM_CONSTANT(FEED_BACK);
-#endif
 }

 int CameraFeed::get_id() const {
@@ -144,14 +140,6 @@ CameraFeed::CameraFeed() {
 	datatype = CameraFeed::FEED_RGB;
 	position = CameraFeed::FEED_UNSPECIFIED;
 	transform = Transform2D(1.0, 0.0, 0.0, -1.0, 0.0, 1.0);
-
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
-	// create a texture object
-	RenderingServer *vs = RenderingServer::get_singleton();
-	texture[CameraServer::FEED_Y_IMAGE] = vs->texture_create(); // also used for RGBA
-	texture[CameraServer::FEED_CBCR_IMAGE] = vs->texture_create();
-#endif
 }

 CameraFeed::CameraFeed(String p_name, FeedPosition p_position) {
@@ -164,33 +152,21 @@ CameraFeed::CameraFeed(String p_name, FeedPosition p_position) {
 	datatype = CameraFeed::FEED_NOIMAGE;
 	position = p_position;
 	transform = Transform2D(1.0, 0.0, 0.0, -1.0, 0.0, 1.0);
-
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
-	// create a texture object
-	RenderingServer *vs = RenderingServer::get_singleton();
-	texture[CameraServer::FEED_Y_IMAGE] = vs->texture_create(); // also used for RGBA
-	texture[CameraServer::FEED_CBCR_IMAGE] = vs->texture_create();
-#endif
 }

 CameraFeed::~CameraFeed() {
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
 	// Free our textures
-	RenderingServer *vs = RenderingServer::get_singleton();
-	vs->free(texture[CameraServer::FEED_Y_IMAGE]);
-	vs->free(texture[CameraServer::FEED_CBCR_IMAGE]);
-#endif
+	if (texture[CameraServer::FEED_Y_IMAGE].is_null()) {
+		RenderingServer::get_singleton()->free(texture[CameraServer::FEED_Y_IMAGE]);
+	}
+	if (texture[CameraServer::FEED_CBCR_IMAGE].is_null()) {
+		RenderingServer::get_singleton()->free(texture[CameraServer::FEED_CBCR_IMAGE]);
+	}
 }

 void CameraFeed::set_RGB_img(const Ref<Image> &p_rgb_img) {
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
 	ERR_FAIL_COND(p_rgb_img.is_null());
 	if (active) {
-		RenderingServer *vs = RenderingServer::get_singleton();
-
 		int new_width = p_rgb_img->get_width();
 		int new_height = p_rgb_img->get_height();

@@ -198,23 +174,22 @@ void CameraFeed::set_RGB_img(const Ref<Image> &p_rgb_img) {
 			// We're assuming here that our camera image doesn't change around formats etc, allocate the whole lot...
 			base_width = new_width;
 			base_height = new_height;
+		}

-			vs->texture_allocate(texture[CameraServer::FEED_RGBA_IMAGE], new_width, new_height, 0, Image::FORMAT_RGB8, RS::TEXTURE_TYPE_2D, RS::TEXTURE_FLAGS_DEFAULT);
+		if (texture[CameraServer::FEED_RGBA_IMAGE].is_null()) {
+			texture[CameraServer::FEED_RGBA_IMAGE] = RenderingServer::get_singleton()->texture_2d_create(p_rgb_img);
+		} else {
+			RID new_texture = RenderingServer::get_singleton()->texture_2d_create(p_rgb_img);
+			RenderingServer::get_singleton()->texture_replace(texture[CameraServer::FEED_RGBA_IMAGE], new_texture);
 		}

-		vs->texture_set_data(texture[CameraServer::FEED_RGBA_IMAGE], p_rgb_img);
 		datatype = CameraFeed::FEED_RGB;
 	}
-#endif
 }

 void CameraFeed::set_YCbCr_img(const Ref<Image> &p_ycbcr_img) {
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
 	ERR_FAIL_COND(p_ycbcr_img.is_null());
 	if (active) {
-		RenderingServer *vs = RenderingServer::get_singleton();
-
 		int new_width = p_ycbcr_img->get_width();
 		int new_height = p_ycbcr_img->get_height();

@@ -222,67 +197,53 @@ void CameraFeed::set_YCbCr_img(const Ref<Image> &p_ycbcr_img) {
 			// We're assuming here that our camera image doesn't change around formats etc, allocate the whole lot...
 			base_width = new_width;
 			base_height = new_height;
+		}

-			vs->texture_allocate(texture[CameraServer::FEED_RGBA_IMAGE], new_width, new_height, 0, Image::FORMAT_RGB8, RS::TEXTURE_TYPE_2D, RS::TEXTURE_FLAGS_DEFAULT);
+		if (texture[CameraServer::FEED_RGBA_IMAGE].is_null()) {
+			texture[CameraServer::FEED_RGBA_IMAGE] = RenderingServer::get_singleton()->texture_2d_create(p_ycbcr_img);
+		} else {
+			RID new_texture = RenderingServer::get_singleton()->texture_2d_create(p_ycbcr_img);
+			RenderingServer::get_singleton()->texture_replace(texture[CameraServer::FEED_RGBA_IMAGE], new_texture);
 		}

-		vs->texture_set_data(texture[CameraServer::FEED_RGBA_IMAGE], p_ycbcr_img);
 		datatype = CameraFeed::FEED_YCBCR;
 	}
-#endif
 }

 void CameraFeed::set_YCbCr_imgs(const Ref<Image> &p_y_img, const Ref<Image> &p_cbcr_img) {
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
 	ERR_FAIL_COND(p_y_img.is_null());
 	ERR_FAIL_COND(p_cbcr_img.is_null());
 	if (active) {
-		RenderingServer *vs = RenderingServer::get_singleton();
-
 		///@TODO investigate whether we can use thirdparty/misc/yuv2rgb.h here to convert our YUV data to RGB, our shader approach is potentially faster though..
 		// Wondering about including that into multiple projects, may cause issues.
 		// That said, if we convert to RGB, we could enable using texture resources again...

 		int new_y_width = p_y_img->get_width();
 		int new_y_height = p_y_img->get_height();
-		int new_cbcr_width = p_cbcr_img->get_width();
-		int new_cbcr_height = p_cbcr_img->get_height();

 		if ((base_width != new_y_width) || (base_height != new_y_height)) {
 			// We're assuming here that our camera image doesn't change around formats etc, allocate the whole lot...
 			base_width = new_y_width;
 			base_height = new_y_height;
+		}

-			vs->texture_allocate(texture[CameraServer::FEED_Y_IMAGE], new_y_width, new_y_height, 0, Image::FORMAT_R8, RS::TEXTURE_TYPE_2D, RS::TEXTURE_FLAG_USED_FOR_STREAMING);
+		if (texture[CameraServer::FEED_Y_IMAGE].is_null()) {
+			texture[CameraServer::FEED_Y_IMAGE] = RenderingServer::get_singleton()->texture_2d_create(p_y_img);
+		} else {
+			RID new_texture = RenderingServer::get_singleton()->texture_2d_create(p_y_img);
+			RenderingServer::get_singleton()->texture_replace(texture[CameraServer::FEED_Y_IMAGE], new_texture);
+		}

-			///@TODO GLES2 doesn't support FORMAT_RG8, need to do some form of conversion
-			vs->texture_allocate(texture[CameraServer::FEED_CBCR_IMAGE], new_cbcr_width, new_cbcr_height, 0, Image::FORMAT_RG8, RS::TEXTURE_TYPE_2D, RS::TEXTURE_FLAG_USED_FOR_STREAMING);
+		if (texture[CameraServer::FEED_CBCR_IMAGE].is_null()) {
+			texture[CameraServer::FEED_CBCR_IMAGE] = RenderingServer::get_singleton()->texture_2d_create(p_cbcr_img);
+		} else {
+			RID new_texture = RenderingServer::get_singleton()->texture_2d_create(p_cbcr_img);
+			RenderingServer::get_singleton()->texture_replace(texture[CameraServer::FEED_CBCR_IMAGE], new_texture);
 		}

-		vs->texture_set_data(texture[CameraServer::FEED_Y_IMAGE], p_y_img);
-		vs->texture_set_data(texture[CameraServer::FEED_CBCR_IMAGE], p_cbcr_img);
 		datatype = CameraFeed::FEED_YCBCR_SEP;
 	}
-#endif
-}
-
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
-void CameraFeed::allocate_texture(int p_width, int p_height, Image::Format p_format, RenderingServer::TextureType p_texture_type, FeedDataType p_data_type) {
-	RenderingServer *vs = RenderingServer::get_singleton();
-
-	if ((base_width != p_width) || (base_height != p_height)) {
-		// We're assuming here that our camera image doesn't change around formats etc, allocate the whole lot...
-		base_width = p_width;
-		base_height = p_height;
-
-		vs->texture_allocate(texture[0], p_width, p_height, 0, p_format, p_texture_type, RS::TEXTURE_FLAGS_DEFAULT);
-	}
-
-	datatype = p_data_type;
 }
-#endif

 bool CameraFeed::activate_feed() {
 	// nothing to do here
diff --git a/servers/camera/camera_feed.h b/servers/camera/camera_feed.h
index fac7ae1b2d..1f80d15e30 100644
--- a/servers/camera/camera_feed.h
+++ b/servers/camera/camera_feed.h
@@ -103,10 +103,6 @@ public:
 	void set_RGB_img(const Ref<Image> &p_rgb_img);
 	void set_YCbCr_img(const Ref<Image> &p_ycbcr_img);
 	void set_YCbCr_imgs(const Ref<Image> &p_y_img, const Ref<Image> &p_cbcr_img);
-// FIXME: Disabled during Vulkan refactoring, should be ported.
-#if 0
-	void allocate_texture(int p_width, int p_height, Image::Format p_format, RenderingServer::TextureType p_texture_type, FeedDataType p_data_type);
-#endif

 	virtual bool activate_feed();
 	virtual void deactivate_feed();

PR for CameraFeed fix - #51581

Confirmed to work via the lib4vl2 method on linux in-editor (thx for the demo scene in the PR) - but the texture doesn't render in a played scene, even with a script to cycle through and set_active(true) so I'll see if I can sort out what's going on there.

Confirmed to work via the lib4vl2 method on linux in-editor (thx for the demo scene in the PR) - but the texture doesn't render in a played scene, even with a script to cycle through and set_active(true) so I'll see if I can sort out what's going on there.

It seems to work only 3D scene is opened, closed and reopened in editor, or if it's assigned to 2D sprite (in this case it's working in running project, but only after resizing the window).
Probably something in the CameraTerxture/Feed/Server is initialized before RenderingServer is ready, but I'm not sure what's exactly wrong.

I was also implementing linux camera support, so maybe we could combine best of both solutions?
https://github.com/pkowal1982/godot/tree/camera

What testing is needed for this to be merged?
What is required for this to be backported to 3.x?

@CrispyPin
See my note above:

Ah as I want to mention. I would also like to push it to the godot 3.x branch, but therefore the Vector<uint8_t> must be changed to PoolVector<uint8_t>. But i guess it should be cherrypicked after this one is merged?

And according to this you have to change void V4l2_Device::get_image(Ref<CameraFeed> feed, uint8_t *buffer)  in camera_x11.cpp around line 572.
from:
uint8_t *w = img_data.ptrw();
// TODO: Buffer is 1024 Byte longer?
memcpy(w, buffer, width * height * 3);

to:
PoolVector<uint8_t>::Write w = img_data.write();
// TODO: Buffer is 1024 Byte longer?
memcpy(w.ptr(), buffer, width*height*3);

This should be enough to backport it to godot 3.x

Will this be merged into 3.5?

Superseded by #53666. Thanks for the contribution nonetheless!


Refactor LocationCreator

As discussed on slack, extends Any introduces a universal trait and with that, we should be allocation-free here until someone makes use of whatever the universal trait defines.


0.9.5

Codecov Report

Merging #1352 into 0.9 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              0.9    #1352   +/-   ##
=======================================
  Coverage   96.92%   96.92%
=======================================
  Files          49       49
  Lines        2279     2279
=======================================
  Hits         2209     2209
  Misses         70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5efc960...7ed1095. Read the comment docs.


feat(explorer): transaction details page on /transaction/[requestKey]

Add transaction details page
Related Issue/Asana ticket: https://app.asana.com/0/1205801361945248/1207432691892016/f
Short description: Adds transaction details page on /transaction/[requestKey]
Page is not styled with navbar and margins etc. Only the transactions details component is on the page
Todo:

[x] fix typings for TransactionRequest and TransactionResult components
[x] make it work for Continuation next to Execution
[ ] style the page (postponed to layout)

[ ] add the navbar
[ ] add margins

[x] add links to block details page
[x] add links to account details page
[x] add links to counterpart details page
[x] refactor query to be page-specific

Test scenarios
Open a transaction on localhost pointing to testnet graphql instance:

Unrestricted signer: http://localhost:3000/transaction/Wy8ZkFqOZxHZw0OYusfHyy9WalH4Pond8ezJ9T9Tqsg
user.coin-faucet.request-coin w/ multiple signers/caps http://localhost:3000/transaction/YmmgjaGVdtYKuHSJ6KSsXtiN2jkT7PLazd790OdQixA
coin.transfer-crosschain http://localhost:3000/transaction/l30BQS7hee15EWdK6oxWsrKpv14FIUDjnFshzdaYF
continuation: http://localhost:3000/transaction/H4W9dJ47RNUPZO8fjlAyYOs6m6kQUyPLUYG-x4CIId4

Reminders (if applicable)

[x] I ran pnpm install and pnpm test in the root of the monorepo
(optionally with --filter=...package... to exclude non-affected
projects)
[ ] I ran pnpm changeset in the root of the monorepo
[ ] Test coverage has not decreased
[ ] Docs have been updated to reflect changes in PR (don't forget
docs.kadena.io)

There's an issue with the build. Make sure to check it out


utec.edu.sv added

Adding utec.edu.sv

@ROG3RB0T I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host utec.utec.edu.sv not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Feature/onboarding

Initial tidy up of documentation files.

Adds badges
Adds travis (for docs)
Tidies Markdown

Pull Request #11 contains the changes of your PR.


Parse flow version from .flowconfig?

I get this error:
⇒  flow-typed install jest
Failed to find a flow-bin dependency in package.json.
Please install flow bin: `npm install --save-dev flow-bin` or provide a version on the command line: `flow-typed install --flowVersion=0.24.0`

My .flowconfig looks like this:
[ignore]
<PROJECT_ROOT>/node_modules/fbjs/.*

[include]

[libs]

[options]

[version]
0.32.0

Maybe use that version information?

What should we do if there's both a flow-bin and a [version] and they don't align?
Probably error, I guess... (That's a dangerous state to be in anyway)
Ideally flow-bin would be the way you dictate the version of Flow you're using though. For my own understanding, can you describe your workflow for running Flow?

@jeffmo I use create-react-app, and Webstorm, with these settings:

Do you think it is better to not install flow globally, but only locally instead? (And point Webstorm to this local flow executable)

Indeed, I would recommend switching off of a global install in favor of a local flow-bin dependency. Installing locally ensures that anyone who checks out the project will use the correct version of Flow with the project.
In any case, it would be good for flow-typed to give this advice directly if it notices a .flowconfig but no flow-bin package.json dependency.
I'll leave this issue open to track that work item


Possibly broken after 12/17/2015 CS:GO update

Hey,
the pre-compiled binary from your website fails to load tracks via ingame console commands and hotkeys (CS:GO) since today. If I manually load the tracks in the main form I can play the tracks via hotkey ingame.
I cloned and recompiled/debugged this project and I have the exact same issue when compiling on release. If I however compile in debug the function PollRelayWorker_DoWork gets a "2" in the command variable and loads a track on startup. After that I have no issues at all. I can loads tracks via hotkey etc. This sounds a little weird, but I am not that deep into VB to tell you where this is coming from. Just wanted to let you know.

After further debugging I think something is wrong with the config files writing and loading. I see you added userconfig support in 1.2.1 and you are searching for a "slam_relay.cfg", which I deleted some time ago, because I wanted to reset everything. Also I added a second steam user with CS:GO a few days ago on my system. So, maybe this has nothing to do with the update, but with the userconfigs. Funny thing this, the slam_relay.cfg does not seem to be created again on my system, neither in userdata, nor in csgo/cfg.

Friend of mine btw reported that he used a registry cleaner and SLAM started working again after that.

Could you post a slam without this problem? D:


Migrate to new travis infrastructure

We should migrate to the new infrastructure asap, should be easier while we are still working on 0.11.
http://docs.travis-ci.com/user/migrating-from-legacy/

Done.


Improve CSV reporter to understand dimensional metrics in file names

The CSV reporter as it is still uses some hierchic naming which makes it unsuitable for capturing dimensional metrics.
However, full dimensional names are not as useful for file structure.

Common label elements for all metrics in the report should be elided and saved in a separate prefix file.
Filtering for which metrics are reported should be allowed.

done in 5.21


add custom title to xmonad prompts

Description
Currently when creating an XMonad Prompt you are stuck with XMonad: as the title for the prompt.  Its nice to be able to create a prompt with custom commands that has a particular title. adds the xmonadPromptCT function which allows you to do this.
Checklist

[X] I've read CONTRIBUTING.md

[X] I've considered how to best test these changes (property, unit,
manually, ...) and concluded The XMonad.Prompt.XMonad currently has no unit or property tests. If you have any suggestions for strategies to add test coverage I would be happy to implement something.

[X] I updated the CHANGES.md file

[ ] I updated the XMonad.Doc.Extending file (if appropriate)

Thank you!


Rename content/rest/reference/packages.md to contenido/descansar/refe…

…rencia/paquetes.md/@ octokit/ core.js

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Sar please leave me sar IAM abusy man of Steel
On Tue, Jan 11, 2022, 22:04 Alejandro Gonzalez @.***>
wrote:

…rencia/paquetes.md/@ octokit/ core.js
Why:
Closes [issue link]
What's being changed: Check off the following:

I have reviewed my changes in staging (look for "Automatically
generated comment" and click Modified to view your latest changes).
For content changes, I have completed the self-review checklist
https://github.com/github/docs/blob/main/contributing/self-review.md#self-review
.

Writer impact (This section is for GitHub staff members only):

This pull request impacts the contribution experience

I have added the 'writer impact' label
I have added a description and/or a video demo of the changes
below (e.g. a "before and after video")

You can view, comment on, or merge this pull request online at:
https://github.com/github/docs/pull/13944
Commit Summary

58ab4f8
https://github.com/github/docs/pull/13944/commits/58ab4f8dd8fa334748a662acf37d9e88fe5a3bd0
Rename content/rest/reference/packages.md to contenido/descansar/referencia/
paquetes.md/@ octokit/ core.js

File Changes
(1 file https://github.com/github/docs/pull/13944/files)

R contenido/descansar/referencia/paquetes.md/@ octokit/ core.js
https://github.com/github/docs/pull/13944/files#diff-914ecf61108dcf64d7446b8a7f701163f2780b080665b8a42ebe83c685299356
(0)

Patch Links:

https://github.com/github/docs/pull/13944.patch
https://github.com/github/docs/pull/13944.diff

—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/13944, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXHTBD7HMUHX3XH6EGRKC33UVRLY3ANCNFSM5LWYIKIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Can i use badge with this component?

@songyouwei This is a low level component. You can easily add the badge by just implementing your Icon component. I have already provided 2 different Icon component built from RawIcon. This is very easy to implement. Take a look at these two implementation.

Icon
IconWithBar

It would be a nice PR from you to implement an Icon with badge. and I would be happy to put it into the component core.

Can I use a picture as the background  not the text icon?
Because  in your suggestion, the icon or iconWithBar only use the font family .

@xubing Yes, what you can do is copy the content of iconWithBar and remove the Text component and replace it with Image component.
I will try to update the doc with more examples.
Give me a little bit more time.
Thanks

closing this issue because it has no activity


libhoudini.so crash on Android 4.4

Steps to Reproduce
Can not reproduce problem myself, however I'm having multiple crashes reported in Google Play console from several users. The problem is only happens on Android 4.4
Logs
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
libhoudini.so

*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
pid: 0, tid: 0 >>> com.appname.app <<<

backtrace:
  #00  pc<PHONE_NUMBER>0c2582  /system/lib/libhoudini.so
  #01  pc<PHONE_NUMBER>015edf  /system/lib/arm/libc.so
  #02  pc<PHONE_NUMBER>0ae6b6  /system/lib/libhoudini.so
  #03  pc<PHONE_NUMBER>062f8b  <unknown>
  #04  pc<PHONE_NUMBER>0ab3c5  /system/lib/libhoudini.so
  #05  pc<PHONE_NUMBER>015edf  /system/lib/arm/libc.so
  #06  pc<PHONE_NUMBER>0aadcc  /system/lib/libhoudini.so
  #07  pc 00000000ffffffff  <unknown>
  #08  pc<PHONE_NUMBER>0f454c  /system/lib/libhoudini.so
  #09  pc 00000000ffffffff  <unknown>
  #10  pc<PHONE_NUMBER>00dfff  [stack:24824]
  #11  pc<PHONE_NUMBER>18488a  /system/lib/libhoudini.so

[✓] Flutter (Channel beta, v0.9.4, on Linux, locale en_US.UTF-8)
    • Flutter version 0.9.4 at /home/flutter/flutter_v0.9.4-beta
    • Framework revision f37c235c32 (5 weeks ago), 2018-09-25 17:45:40 -0400
    • Engine revision 74625aed32
    • Dart version 2.1.0-dev.5.0.flutter-a2eb050044

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /home/android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • ANDROID_HOME = /home/android/sdk
    • Java binary at: /home/android/src/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.1)
    • Android Studio at /home/android/src/android-studio
    • Flutter plugin version 24.2.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[!] Connected devices
    ! No devices available

Are you still seeing this?
Might be a duplicate of #27145
What CPUs do the devices have where you see these crashes?

I no longer see this in crash reports. Closing.


Support manual metadata entry for non-hathi digitized works

updates digitized work with a source field to distinguish between hathi content and other content
adjust fields that are displayed and edited in django admin; set hathi read only fields based on source
add checks to suppress logic, page index data, and marc metadata to skip non-hathi records
customize detail view for non-hathi records, including suppressing search within the volume

Currently I have the alternate source set to Other; I will check with project team and see if this can be made more specific.
The only thing that isn't working right now is unapi for non-hathi records: we need to determine if there is a source where we can get MARC metadata (partly depends on the source question also). Might be possible for oclc records, but looks like it requires an API key - so making the metadata available for download (which we effectively do via unapi to generate the citation) is probably not within what we're allowed to do. Might need to generate simple dublin core or other metadata for Zotero for records where we can't get MARC metadata.

Codecov Report

Merging #213 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #213      +/-   ##
===========================================
+ Coverage    98.88%   98.89%   +0.01%
===========================================
  Files           82       83       +1
  Lines         3858     3905      +47
===========================================
+ Hits          3815     3862      +47
  Misses          43       43

Impacted Files
Coverage Δ

...rchive/migrations/0010_digitizedwork_add_source.py
100% <100%> (ø)

ppa/archive/models.py
98.54% <100%> (+0.05%)
:arrow_up:

ppa/archive/tests/test_views.py
100% <100%> (ø)
:arrow_up:

ppa/archive/admin.py
100% <100%> (ø)
:arrow_up:

ppa/archive/tests/test_models.py
100% <100%> (ø)
:arrow_up:

ppa/archive/views.py
98.59% <100%> (ø)
:arrow_up:

ppa/archive/forms.py
100% <100%> (ø)
:arrow_up:

ppa/archive/tests/test_admin.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc30f8...83df343. Read the comment docs.


Add ignoredChannelIDs to Finger Quoter Plugin Configuration

What is this about
Added ignoredChannelIDs configuration to finger quoting to allow a opt-out style instead of opt-in.
Checklist

[x] I've reviewed my own code
[x] I've executed go build ./... and confirmed the build passes
[x] I've run go test ./... and confirmed the tests pass

@s-machina: Just FYI, adding a ignoreChannelIDs to allow for a opt-out style. Although technically, both channelIDs and ignoreChannelIDs can be used.


Unity2020+OpenXR,After the program runs, can't see any images

I followed this tutorial and used unity2020 + openxr, and I'm pretty sure I didn't make any mistakes. But after my program runs in hololens, there is nothing, not even a "make with unity" image. But when I use unity 2020 + windows XR, repeat the above operation. The program is executable.
Unity version 2020.3.12f1
MRTK 2.7.2
Hololens2 system version 21h1
windows sdk 19041。
I don't know why the program can't run in openxr, but the program can run in Windows XR. Please tell me how to solve it

the tutorial is https://docs.microsoft.com/zh-cn/windows/mixed-reality/develop/unity/tutorials/mr-learning-base-02?tabs=openxr#configuring-the-unity-project


WIP: remove http://sachaproject.gforge.inria.fr/repositories/releases/

closes https://github.com/eclipse/repairnator/issues/1234

CI confirms @andre15silva's statement that the repo is needed for GZoltar:
Could not find artifact com.gzoltar:gzoltar:jar:0.1.1 in Sonatype

Possible Actions:

removing gzoltar from this POM (trying now)
moving gzoltar to another repo
depending on a newer version of gzoltar which is on Central

depending on a newer version of gzoltar which is on Central

I doubt that will work because the API changed

Solution 1 works, CI is green, merging


Allow failing build if there are missing runtime assets

🚀 feature request
Relevant Package
This feature request is for @angular/cli
Description
If you have in the assets configuration in angular.json:
    "assets": [
        ...
        {
            "glob": "jquery.min.js",
            "input": "./node_modules/jquery/dist",
            "output": "/assets/jquery"
        },
        ...
    ]

And the glob doesn't match anything, no error is generated. This means the build can be broken because the assets folder doesn't contain all required runtime assets, but we won't realize until runtime.
Describe the solution you'd like
The feature request is to add an array field files that can be used instead of glob to tell exactly which files to copy: `"files":
    "assets": [
        ...
        {
            "files": ["jquery.min.js", "jquery.min.map"],
            "input": "./node_modules/jquery/dist",
            "output": "/assets/jquery"
        },
        ...
    ]

Describe alternatives you've considered
I considered listing the jquery.min.js file in the scripts section of angular.json, but this solution doesn't work perfectly for cases when it's not a "js" file I want in the assets folder. For example, mapbox comes with a folder with images, that I need copied to the assets folder.
An alternatively feature implementation I considered recommending was you could add an option failIfNoMatch to make the build fail if the glob doesn't match anything: "failIfNoMatch": true. But this solution is not as useful as the files one though, as the glob jquery.min.{js,map} would succeed even if it finds only one of the required files.

Transferring to the CLI project.


Support transperancy in .mov format

I don't think .mov supports transparency. Please use .mp4 or in case I am wrong you may also update the .mov export file type with a pull request. (if it is supported by ffmpeg, it should not be a big problem)

MOV does Support transparency. MP4 doesn't. I'll give it a try with a custom Format, if it works I will make a PR.

use this code:

class TransparentMovFormat extends MovFormat {
  const TransparentMovFormat({
    super.audio,
    super.scale,
    super.interpolation = Interpolation.bicubic,
  }) : super();

  @override
  FFmpegRenderOperation processor({
    required String inputPath,
    required String outputPath,
    required double frameRate,
  }) {
    final audioInput = audio != null && audio!.isNotEmpty
        ? audio!.map((e) => "-i??${e.path}").join('??')
        : null;
    print("inputPath: $inputPath , framerate: $frameRate , ouput: $outputPath");
    return FFmpegRenderOperation([
      "-y",
      "-i", inputPath,
      audioInput,
      "-filter_complex",
      "[0:v]${scalingFilter != null ? "$scalingFilter," : ""}"
          "setpts=N/($frameRate*TB)[v]",
      "-map", "[v]",
      "-c:v", "prores_ks",
      "-profile:v", "4444",
      "-pix_fmt", "yuva444p10le", // Enable alpha channel
      "-vendor", "ap10",
      "-colorspace", "bt709",
      "-movflags", "+faststart",
      "-r", "$frameRate",
      outputPath,
    ]);
  }
}


Nc/52 docker update

Resolves #52
DCO1.1 Signed-off-by: Narine Cholakyan<EMAIL_ADDRESS>

Hi narinearraul,
Thanks for submitting this pull request!
I can confirm that the DCO1.1 sign-off has been included. It is okay to process this pull request.
dco-bot


A simple non-intrusive solution to bug #1638

In line 727, we touch "$CHROOTSRC/.crouton-targets" to make sure it exists before using it in the next line.

Sorry, I don't see what this does.  Touching the file is unnecessary since the cp immediately overwrites it, whether the file exists or not.

Aha Ok. So we should find another cause for #1638, after reproducing it...

Yeah, we should definitely be able to consistently repro the issue before deciding whether a change fixes it or not :)


Box-shadow added

i have added shadow effect please review and let me know if something is missing, @ankitapuri

Only the loader keeps on loading ! No visible changes even the user input board doesn't gets displayed .
Please look into this

but everything is perfectly working in my system @ankitapuri
see i have also shared a screenshot

how to resolve this , can you help? @ankitapuri

check your code once . In JS it might have stuck in an infinite loop

but i have made very minimal changes i don't feel there is problem in JS file still will look into it again

@Aarti002 please make a new and fresh PR
@ankitapuri please close this this PR


Job enqueueing is NOT preventing duplicate proj, branch jobs

Basically, I had stopped all the octopusci-tentacles and no jobs were running. While the tentacles were not running 3 job build requests came in, in the following order.

my_project_name with branch master
my_project_name with branch unable_to_connect_to_social_media
my_project_name with branch master

It seems that all three requests came in and that the jobs identified by #1, #2, and #3 were executed and running because the Resque interface shows that three workers were working and were all kicked off at the same time. However, for some reason the oldest master jobs that was running did not get its state updated so it still looks as if it is in a pending state.
You can see this in the following screenshot:
https://img.skitch.com/20111111-r9sy6de1ruyf5r3pxquspj8732.jpg

After some further investigation it seems that the most recent master branch job was getting updated by both of the actually jobs building the master branch even though they were building on two different stages. I was able to identify this because I could see duplication in the output and log files. I also noticed that the job initially updated and went green and then after a few minutes I refreshed and the job went to a state of red.
So, I am definitely convinced at this point as before that all the jobs were running it was just that the older master branch build job and the newer master branch build job even though on different stages were updating the most recent job record instead of updating their respective job records as they should.
Also, note that the older master job in the listing is still in the pending state and has not been updated at all.

Thinking about this some more, it seems that the second job for the master branch should never have been queued in the first place. The reason being is that the queueing engine is supposed to be intelligent enough to simply update the data with the original pending job for the master branch rather than creating a new instance of it. That way when the tentacles start up it simply builds the latest version of that branch rather than building an old version of that branch and then the latest version of that branch.

I resolved this issue with the above commit.


Peptidome 2.0

Rewrite of the peptidome part of the website. This includes:

Use assemblies instead of bioprojects
Present the proteomes in a filterable table instead of a tree
Remove the drag to add behaviour
Add progress notifications
Add more info to the similarity matrix tooltip
Add more similarity metrics
Save the analysis state and automatically reload on the next visit
Improve initial loading animation of similarity matrix
Add advanced full screen mode
Similarity calculation is now 8-10 times faster
Fix bugs

[x] Retire the use of bioproject ids and transition to assembly ids (#460)

[x] Add data

[x] Add new tables to the database scheme
[x] Create ruby models + annotate
[x] Update tests
[x] Update preprocessing scripts
[x] Clean old tables
[x] type strain info (@ninewise) (#491)
[x] Add sql, with and without indexes

[x] Find a new way to select genomes as the tree will probably break with 30.000 genomes

[x] Enable the add buttons
[x] Enable the checkboxes and add all button
[x] Clicking row = toggle checkbox
[x] Make the lineage links clickable
[x] Add rank information to the suggestion list
[x] Enable drag and drop
[x] Remove old selection tree code
[x] Enable adding draft genomes (#353)
[x] Figure out on which fields we want to filter and include them in the metadata

[x] Assembly level
[x] Genome representation
[x] type strain

[x] Search for is:complete by default
[x] Add filters to the search suggestions
[x] Add a search popover with advanced options
[x] Smart token replacement
[x] Fix editing taxon tokens
[x] Add paging
[x] Add filter for already added
[x] Improve layout of settings popover
[x] Code cleanup and documentation

[x] Rename genomes/proteomes/peptidomes, discuss with @pdawyndt
[x] Add more metadata
[x] Fix a few bioproject links

add notifications

[x] loading genomes
[x] sorting
[x] calculating pancore
[x] calculating similarities
[x] download sequences
[x] reprocess my genomes
[x] process mygenomes

[x] The remove button of the popover is broken
[x] Add more left margin to the graph to support numbers over 1M
[x] Swapping tree nodes results in errors
[x] add + button to my genomes table (#419)
[x] remove all drag and drop code
[x] implement dragula and remove jqueryUI (#492)
[x] Investigate mygenomes import unresponsiveness
[x] Save peptidome analysis state between sessions (#416)
Improved full screen mode

[x] Use the bar-based model used in the MPA
[x] Enable switching between visualisations
[x] Enable adding genomes (#157)

[x] alternative similarity metrics

default: intersection / union
intersection / min(#a, #b)
intersection / avg(#a, #b)
intersection / max(#a, #b)
intersection / (sqrt (2_#a_#b)/sqrt (#a^2+#b^2))
[x] rename metrics

[x] Show more info in the cluster tooltip (#307)
[x] Improve cluster animation by using some sort of data queue (#426)
Add the option to hide the tree or the matrix (#306) -> won't implement
[x] Offer a share link -> moved to next version: #512
[x] fix exception in get_lca (#502)

closes #157, closes #307, closes #353, closes #416, closes #419, closes #426, closes #460, closes #484, closes #491, closes #492, closes #502
Original pull request by @bmesuere on Thu Mar 19 2015 at 15:24.
Merged by @bmesuere on Thu Jul 02 2015 at 15:20.

Adding the selection tree with 17k nodes to the page takes 10+ seconds :(
Original comment by @bmesuere on Thu Apr 16 2015 at 14:54.

The new table + filter is now fully implemented, the my proteomes table was refactored and JQuery UI was dropped. Things that need to be tested:

[x] Add "my proteomes" while being updated
[x] Drag and drop reorder while calculating
[x] Cursor while dragging

Original comment by @bmesuere on Wed Apr 29 2015 at 14:32.

@bmesuere er staat nu "Click the plus-button to add your own proteomes."  Misschien moet dit nog eens herbekeken worden.
Original comment by @pdawyndt on Thu Apr 30 2015 at 11:40.

The analysis is now saved on page leave and restored when the user clicks the restore button.

[x] Add support for my proteomes
[x] Don't take the assembly version into account

Original comment by @bmesuere on Fri May 01 2015 at 17:07.

Some shower inspiration:

[x] To prevent the user from getting stuck in an invalid state AND automatically resume a previous analysis

if (previous analysis is present) {
    if (previous analysis wasn't auto loaded before) {
        auto load previous analysis
    } else {
        load demo
        ask to load previous analysis
    }
} else {
    load demo
}

[x] Report if a proteome couldn't be loaded (e.g. because it was removed from uniprot)
[x] Offer a share link

if it contains local proteomes, report that it won't work on other computers
if a state was loaded from a link, and a local proteome wasn't present in the browser, report it to the user

Original comment by @bmesuere on Sat May 02 2015 at 10:51.

The last 2 commits made the similarity calculation 4 times faster, and 8-10 times faster compared to master.
I noticed some JS error when

swapping branches -> couldn't reproduce
clicking the restore status link -> fixed in 47588eb

Original comment by @bmesuere on Tue May 05 2015 at 10:53.

Original comment by @bmesuere on Thu Jul 02 2015 at 13:39.

@pdawyndt Shouldn't we remove our 'weighted average' since we have no correct name for it and no real reference where it's used? We could replace it by the Ochiai coefficient: divide by sqrt(#A*#B)
See #513
Original comment by @bmesuere on Thu Jul 02 2015 at 14:18.


NavGraphArhs are visible only in "start" destination

Here is my SettingsGraphArgs:

Here is my TempLockScreen (with @Destination(SettingsGraph)):

Here is my SettingsScreen (with @Destination(SettingsGraph) AND with start=true flag):

ViewModel of SettingsScreen:

I use this code to navigate to Graph
navigator.navigate(                                             SettingsNavGraph(SettingsGraphArgs(userCard = currentCard.owner))                                         )
My NavGraphs arguments is empty when i try to get it from TempLockScreen but is visible from SettingsScreen.
Is something what i am doing bad?

Hi!
NavGraph args are a bit tricky with official Compose Navigation as well. You need the back stack entry correspondent to the nav graph to make sure you'll have the args. If you navigate directly to another graph screen that is not the start one, the args will also not be there. That's why Compose Destinations APIs return nullable type in this case.
So, this is expected and how it works with official navigation library as well. You'll need to adapt to it.

See also here:
https://composedestinations.rafaelcosta.xyz/v2/arguments/navigation-arguments#navgraph-navigation-arguments

NAV GRAPH ARGUMENTS ARE ALWAYS NULLABLE
Navigation arguments of nav graphs are tricky. They will be present if you navigate to the graph itself (for above example, doing navigator.navigate(ProfileNavGraph(id = "some id"))) and they will not be present if you navigate to one of its destinations directly.
This is how official compose navigation works as well, Compose Destinations makes it clear by returning nullable.
If you know in your case you always navigate to the Graph, you can do requireNavGraphArgs instead which will throw an exception instead of returning nullable type.

So i have to navigate to NavGraphs every time when i want to retrive NavGraphsArgs?
For example: I have LoginNavGraphs where i have LoginDestination(start), ForgotPasswordDestination, RegisterDestination.
App start and i navigate to LoginNavGraph (i have arguments filled) then I want to redirect user to ForgotPasswordDestination with LoginNavGraph arguments so how i can navigate to this destination with arguments?
Sorry for my english ;/

@raamcosta can you tell me how i can do this? https://github.com/raamcosta/compose-destinations/issues/633#issuecomment-2114107486

You can also get a hold of the NavBackStackEntry correspondent to your NavGraph, and that one will contain all nav graph arguments.
Something like this:
destinationsNavigator.getBackStackEntry(ProfileNavGraph)?.navGraphArgs<ProfileNavGraphArgs>()

You can also get a hold of the NavBackStackEntry correspondent to your NavGraph, and that one will contain all nav graph arguments.
Something like this:
destinationsNavigator.getBackStackEntry(ProfileNavGraph)?.navGraphArgs<ProfileNavGraphArgs>()

How about get arguments in ViewModel?


Design information requirements

So far, we have decided that we define information requirements using SHACL shapes, but we haven't finished defining how exactly those shapes are connected to the need/connection/event structure. This needs to be done before we can move on. In order to allow for a fast learning cycle, we should focus on solving the use cases we know right now (tax and transport) and revisit this point later if needed.

done


Enhancing font of yoga therapy

i want to work on this

@keerthana054 Can you describe!

@keerthana054 Do you want to change the font size and color?

@keerthana054 Do you want to change the font size and color?

Kind of! Changing it as such that it looks good with the background!

@keerthana054 Show me after you're done.

Are you happy with how this looks now? I'm happy to have a look at it otherwise


Rearranging Jupyter options

This is just a template to help you make your point clear with this PR. :)
What is the purpose of this Pull Request?
Newcomers might choose one of those three options, not all of them. That is why the options should be reorganized.
What was done to achieve this purpose?
Added some "or".
How to test if it really works?
It is just how it is documented, not how it works.
Who can help reviewing it?
Anyone. Btw I believe we could hear from users if it is understandable.
TODO
Drink two liters of water a day. :)

well. the I generated the table of content using doctoc, if by any chance we regenerate it, this change will be overwritten... I wouldn't merge this.


chore: docs/supported_opcodes.md missing

EVM opcodes not exist

troubleshooting

use git log --all -1 -- docs/supported_opcodes.md found  supported_opcodes.md was deleted at feat: support dencun hard fork (#1027)

fix
option1: delete readme.md's docs/supported_opcodes.md link
option2: add back  docs/supported_opcodes.md
my perfer is option1 since right now kakarot support 100% of EVM opcodes

hey @AdventureSeeker987, yes you can go with option 1


enhanced UI for Desktop

Enhanced the UI for the Desktop made visually appealing

@alpharsh there are some merge conflicts brother


Add new rich text / linked item properties

Add new properties added to rich text & linked item properties as per https://docs.kontent.ai/reference/management-api-v2#section/Content-type-object

Closed by https://github.com/Kentico/kontent-management-sdk-js/commit/fec3fc4b84180da2078b22931afcda408467d0f7 & https://github.com/Kentico/kontent-management-sdk-js/commit/e4c003edf9dcf191d23ca17a289b1fed0a2d45f2


[SPARK-45569][SQL] Assign name to the error _LEGACY_ERROR_TEMP_2153

What changes were proposed in this pull request?
Assign the name UNEXPECTED_SERIALIZER_FOR_CLASS to the legacy error class _LEGACY_ERROR_TEMP_2153.
Why are the changes needed?
To assign proper name as a part of activity in SPARK-37935.
Does this PR introduce any user-facing change?
Yes, the error message will include the error class name
How was this patch tested?
Add a unit test to produce the error from user code.
Was this patch authored or co-authored using generative AI tooling?
No.

Thank you @MaxGekk for your review, the CI attempt-2 seems fine and some failures of attempt-1 is unrelated.

+1, LGTM. Merging to master.
Thank you, @dengziming.

@dengziming Please, correct the JIRA to vhttps://issues.apache.org/jira/browse/SPARK-45573


Revert "Introduce ava"

This reverts commit 82e6f6ab58cc5b7e364b4fa84efa27270bcaf591, reversing
changes made to 757ad07bec40e4cc5b112e83c11bf54758e87400.
I don't seem this is not suite for our purpose.
This revert https://github.com/karen-irc/option-t/pull/258

This change is

bors r+


[BUG] Website seems to be rendered incorrectly

It seems like for me a lot of the website formatting is broken. On the quickstart page, a bunch of `#!bash and the like show up. If I go to the documentation, the options don't seem to be rendered as a table correctly (see screenshot).
I don't know if this is an issue on my side. I have tried Chrome and Firefox and there seems to be no difference.
What did you do
Went to the documentation to try and find some information
Screenshots or terminal output

This seems to be caused by mkdocs.yml including Codehilite which has been superseded. With #1033, mkdocs-material is at version 8.2.7 and Codehilite support is dropped since version 6.0.0.
Since its replacement Highlight supports SuperFences & Inlinehilite as well an easy fix could be to update mkdocs.yml replacing Codehilite with Highlight. I'd be happy to prepare a PR with the change.

Hi @pirgeo thanks for opening this issue!
Fixed in https://github.com/k3d-io/k3d/commit/eac88db763a2262a9579cc259ce589bcf8329ce0 as per @meenakshi-koushik 's suggestion (thanks for the hint :pray: ) :+1:


Menu icon missing

Hi,
when I try to insert a new menu voice, icon is missing in datatable and sidebar menu. I tried lots of fontawesome icons such as cloud, facebook, etc but only already known icons (such as cloud-upload-alt) are rendered in the Menu table and sidebar. What could I do to solve this? Thanks!

Hi,
Please take a look at laravel-enso/Core#37. You will see the steps to add custom icons.
Will add soon the the main doc / menu manger doc this info.

It works like a charm. Thanks a lot!

We'll leave this open until we update the docs. It might help somebody else.


Decode questions HTML entities

Decode HTML entities in questions, as done in answers.

@greuze,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Please, update the npm package with this solution :)


verifyText error

command error
I use

The issue cannot be reproduced in version 5.3.24.

The issue cannot be reproduced in version 5.3.24.


[Bug]: Table Widget's Add-Row doesn't work with Image columns

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When a table column is set to Image type, it can no longer be used in the Add-Row feature. I want the user to be able to use the Add-Row feature and insert a URL into this same column where the image gets displayed.

As a workaround, I am forced to display both the URL as text, and the image itself as a new image column. Please add support for editing the image column directly in the table widget.
Steps To Reproduce

Enable editing for a text column of a table widget
Set the column to Image type
See that the editing has been disabled, and can not be turned back on

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Appsmith v1.9.57-SNAPSHOT

Hi @Nikhil-Nandagopal , i am intrested in picking up this issue.

@saiprabhu-dandanayak sure go for it. Can you ensure it works for edit row as well?

sure @Nikhil-Nandagopal

@saiprabhu-dandanayak -created ticket for you in Jira- https://zemoso.atlassian.net/browse/TNOSB-524

hey @saiprabhu-dandanayak , are you going to work on it further, since the conversation is not active since august?


Feature request : Datepicker in Alert

Short description of the problem:
checkbox, radio and text input are all possible in Alert, only datetime is missing.
Which Ionic Version? 2.x

Would like to see this as well.

Need this too!

Hello everyone! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to driftyco/ionic-feature-requests#162

@jgw96 The link is broken.
Is there a new thread/issue or should this be reopened?

@karthikrp - link is not broken (just checked it), it is just to a private repo. Was there something you wanted to add to the request? I can update it for you if so.

i still don't see it in V3...any news?


privacy doc

add a page that describes the privacy concerns

where is the data stored
how long is it going to be stored for
who can it be transmitted to

the privacy policy of Replicate is slightly concerning :|

We may disclose your information also:
to our subsidiaries and affiliates;
to contractors, service providers, and other third parties we use to support our business;

very good

FAQ and Terms page have been added

thanks 🙇


[Extra] Add PEAR.Files.IncludingFile sniff

As discussed in #1143
Closes #1143
Closes #1007

Had to restart a stalled job, but all good now.


PT error while saving model

Reminder

[X] I have read the README and searched the existing issues.

System Info
train script
### model
model_name_or_path:2.5-0.5B-Instruct

### method
stage: pt
do_train: true
finetuning_type: full
lora_target: all

### dataset
dataset: c4_demo
cutoff_len: 2048
max_samples: 1000
overwrite_cache: true
preprocessing_num_workers: 16

### output
output_dir: saves/llama3-8b/lora/pretrain
logging_steps: 10
save_steps: 500
plot_loss: true
overwrite_output_dir: true

### train
per_device_train_batch_size: 1
gradient_accumulation_steps: 8
learning_rate: 1.0e-4
num_train_epochs: 3.0
lr_scheduler_type: cosine
warmup_ratio: 0.1
bf16: true
ddp_timeout: 180000000

### eval
val_size: 0.1
per_device_eval_batch_size: 1
eval_strategy: steps
eval_steps: 500

error msg
0]: Traceback (most recent call last):
[rank0]:   File "/home/hust1/zlj/finetune/src/llamafactory/launcher.py", line 23, in <module>
[rank0]:     launch()
[rank0]:   File "/home/hust1/zlj/finetune/src/llamafactory/launcher.py", line 19, in launch
[rank0]:     run_exp()
[rank0]:   File "/home/hust1/zlj/finetune/src/llamafactory/train/tuner.py", line 48, in run_exp
[rank0]:     run_pt(model_args, data_args, training_args, finetuning_args, callbacks)
[rank0]:   File "/home/hust1/zlj/finetune/src/llamafactory/train/pt/workflow.py", line 63, in run_pt
[rank0]:     train_result = trainer.train(resume_from_checkpoint=training_args.resume_from_checkpoint)
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/trainer.py", line 1938, in train
[rank0]:     return inner_training_loop(
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/trainer.py", line 2356, in _inner_training_loop
[rank0]:     self._maybe_log_save_evaluate(tr_loss, grad_norm, model, trial, epoch, ignore_keys_for_eval)
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/trainer.py", line 2807, in _maybe_log_save_evaluate
[rank0]:     self._save_checkpoint(model, trial, metrics=metrics)
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/trainer.py", line 2886, in _save_checkpoint
[rank0]:     self.save_model(output_dir, _internal_call=True)
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/trainer.py", line 3454, in save_model
[rank0]:     self._save(output_dir)
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/trainer.py", line 3525, in _save
[rank0]:     self.model.save_pretrained(
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/modeling_utils.py", line 2539, in save_pretrained
[rank0]:     model_to_save.config.save_pretrained(save_directory)
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/configuration_utils.py", line 466, in save_pretrained
[rank0]:     custom_object_save(self, save_directory, config=self)
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/dynamic_module_utils.py", line 585, in custom_object_save
[rank0]:     for needed_file in get_relative_import_files(object_file):
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/dynamic_module_utils.py", line 124, in get_relative_import_files
[rank0]:     new_imports.extend(get_relative_imports(f))
[rank0]:   File "/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/dynamic_module_utils.py", line 93, in get_relative_imports
[rank0]:     with open(module_file, "r", encoding="utf-8") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/hust1/.conda/envs/finetune/lib/python3.10/site-packages/transformers/models/qwen2/..configuration_utils.py'

Reproduction
llamafactory-cli train llama3_lora_pretrain.yaml
Expected behavior
No response
Others
No response

do not use 2.5-0.5B-Instruct as the folder name

It does not work.
I tried using absolute paths for both the model_name_or_path and output_dir, but it did not work. I can use the same script to train the LLaMA and Qwen models (also using relative paths) without any problems. The issue seems to be that Phi-3 uses a custom Python file for its model configuration (e.g., configuration_phi3.py), which triggers the get_relative_imports function in the Transformers library, resulting this error.
Do you have any other suggestions for this issue? Thanks!

My temporary solution is to comment out these lines in dynamic_module_utils.py


Negative coordinated element

SVG elements on negative coordinated are not rendered. Existing code assumes no elements to be rendered on negative coordinates. And always renders coordinate (0,0) between (+,+).
For example, below simple svg circle is rendered quarter circle.
Wrong

Correct

SVG code:

< svg version="1.1" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://www.w3.org/2000/svg">
< defs>
< symbol id="GeneratedGraphics" overflow="visible">
< circle cx="0" cy="0" r="40" stroke="#000000" stroke-width="1" fill="none"/>
< /symbol>
< /defs>
< use xlink:href="#GeneratedGraphics"/>
< /svg>

Hi ubbn,
On a similar subject...we are using this library to convert svg into png and print it on top of an arbitrary canvas/bitmap image
We've found that any elements outside the svg's viewbox are clipped out and not rendered entirely, even if we use  a larger canvas such as a Graphics object.
In a browser, we are able to control this by setting the overflow property of the svg class to be visible
svg
{
width:100%;
height:100%;
overflow: visible;
}
We have attached an image of such a scenario, showing the container div and the overflowing svg contents when renderer inside a browser.
Also attached, there's an image generated by converting the svg into png using this library
Is there any chance you can point us to where in the library's code we can modify this in order to allow overflowing contents (i.e. by passing a top-left corner point and letting the svg to be drawn freely anywhere inside a canvas and not necessarily from 0,0) ?
Thanks,

Hi,
Do simple test: Remove viewbox attribute, then this library will identify boundary of SVG itselft. Otherwise, it will always be to given viewbox. Also you can start yourself dive into, for example, SvgFragment.cs class where overflow property is declared and follow its usage and callers.

Hi ubbn,
Thanks for your help. Yes, stripping out the viewbox and setting svgDoc.Overflow = SvgOverflow.Visible did the trick for us.
Before having the svg contents rendered on the empty Graphics object, we use the original viewbox and geographic bounds (the ones that match the non-overflowing content) to get the exact scale and translation values, this forces the svg content to match the background imagery (See attached image )
Thanks again !!

Good luck! Looks interesting project.


MediaFileTranslation caption max_length increased from 200 to 1024.

Thank you! I recommend (and still do) that people add their own migration modules for the page and medialibrary app. So, thanks for adding the migrations, but I think they are not necessary.
(Also, they cause the whole CI run to fail.)

Thanks for the feedback.  What should we do to make the max_length longer?

Thanks!


Fix usage of QProgressDialog / LoadingDialog

Both dialogs didn't correctly update their content during the long-running functions they were used in.
Resolves https://github.com/ros-visualization/rviz/issues/1612#issuecomment-820416989.

hi, @rhaschke could this PR be merged when you have time?


Addressing NumPy security alert

NumPy has released the following security alert: https://github.com/advisories/GHSA-6p56-wp2h-9hxr
This PR addresses that alert. Though it may affect some floating point calculations down stream, so some testing of dependent projects in the ARMI ecosystem should be done before this is merged into master.

NOTE: There is a lot of testing that will need to be done before merging. Please do not hit "Merge" this PR for me.

@john-science are waiting on something to merge this in? I assume this will break some down stream stuff on our internal end with using previous numpy versions.

@jakehader You said we needed to do some downstream testing before we could merge this. We've been too busy to talk about getting that done.

This will probably break some stuff downstream for us but let's just pull the trigger and then fix things as needed. Especially if this is technically a security concern we should address. Oh! One more thing - should we update the version of the framework because of this change?


Where should the Twinkles images and DM catalogs be generated?

From Richard:
For simulations resources, I assume we could use grid resources and/or SLAC. NERSC is still problematic in general for PhoSim, though it could be that the postage stamps are sufficiently similar that the block booking of MPI nodes would be efficient. Tom can explain better in person.

At the hangout today Scott reported that they are successfully running end-to-end simulations and DM analyses at NERSC, using a set of shell scripts to link the parts together. Comparing notes could be both interesting and helpful, given Tom's parallelisation difficulties.
I guess this could also be a Run-specific question: if we make Run 1 the Simplest Thing, that might well dictate how and where the data are generated. We talked about the need for a high level of reproducibility in the Run 1 scripts, so that they can be both easily re-run, and helpfully compared with alternatives. Hopefully this will all help drive the development of various software frameworks, workflow engines etc etc .

Richard added in his email, that:
"We think using the pipeline/catalogue system developed for Fermi could work well, but there still need to be discussions with JimK and Saba on how this might fit with their end-to-end work with Galaxy and CosmoSIS."

I think a more fair statement is that "PhoSim is not designed to run efficiently on typical clusters."  It is perfectly runnable at NERSC.  It's just inefficient and one feels a bit silly when doing so.
A technical improvement that a different cluster might provide is longer wall clock times in serial queues.  But this is pretty specific and the pseudo-checkpointing in PhoSim is sufficient to work around any of the current limitations.  We could also just ask NERSC for an increase in this limit if that made a significant difference.
The overall issue is that there's no way to make PhoSim run in a really short amount of total time using a large number of cores.  But if your time unit is a day, that's OK you can just run each chip (or in this case each epoch) in parallel.

Certainly for Run 1 I am in favour of continuing to work in "pleasingly
parallel" mode, as Richard calls it :-)
On Wed, Jan 28, 2015 at 2:45 PM, wmwv<EMAIL_ADDRESS>wrote:

I think a more fair statement is that "PhoSim is not designed to run
efficiently on typical clusters." It is perfectly runnable at NERSC. It's
just inefficient and one feels a bit silly when doing so.
A technical improvement that a different cluster might provide is longer
wall clock times in serial queues. But this is pretty specific and the
pseudo-checkpointing in PhoSim is sufficient to work around any of the
current limitations. We could also just ask NERSC for an increase in this
limit if that made a significant difference.
The overall issue is that there's no way to make PhoSim run in a really
short amount of total time using a large number of cores. But if your time
unit is a day, that's OK you can just run each chip (or in this case each
epoch) in parallel.
—
Reply to this email directly or view it on GitHub
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/16#issuecomment-71932890
.


fix bug 'index out of bounds for partition book List' for igbh-large …

…dist training

Close #47 as completed


"Browsing by issue date" is stuck on loading

Describe the bug
Browsing by Issue Date
Component: browse-by-date-page
If the first item contains a dc.date.issued metadata whose value is not a valid date, then:

the lowerLimit variable becomes undefined
this causes the startsWithOptions variable to remain undefined
this causes the loader to be indefinitely shown.

An additional check must be added in order to preserve the default value of lowerLimit

This is a 5-minute fix, could you assign it to me?

@davidenegretti-4science : Sure, will do! When it's a very quick fix, you are welcome to just create a corresponding PR immediately, in which case I'll assign it to you after the fact.  Thanks!


Reconfigure Spark

Spark needs to be configured to work again in the K8s cluster.

Spark is reconfigured.


Why mark 'p' ?

It is annoying that it adds a mark p after selecting result from quickfix window.
The code seems to be cmd('mark p') in lua/bqf/preview.lua @ line 95
I see there is sign feature, is the p a feature or bug? If it's feature, maybe make it configurable?
Thanks for the great plugin :)

Thanks for your feedback. It's used for zo. I haven't displayed marks in signcolumn, so I didn't discover this issue:)
I have updated the code which never uses a mark.


Can not compile on Ubuntu or Windows Visual Studio 2022 environment

Don't even know what to report, because there is no information on what version is supported.

I tried various configs of vs2019/vs2022/msys2/mingw/etc and the failures are so noisy that I'm not motivated to dig in.
However, it appears to build w/o issue using gcc-8.3.0, e.g. in docker w/ debian:buster
It needs libusb-devel in addition to gcc/g++/cmake/etc
I moved the exe to a fedora39 system and it seems to work fine. I needed libusb-compat-0.1 to satisfy the old libusb so reqs. I can't fully verify it because it turns out the po3kr I have is some kind of oddball composition -- claims to be RGB but it is not RGB hw.

Ok, there seems to be no interest, closing!


"idx" or "i" ? at  DPRDistributedSamplerWithValidation

    def _is_valid(self, indexes):
        def concat_inputs(positives):
            return [((p['title'] + ' ') if p['title'] else '') + p['text'] for p in positives]

        current_contexts = set()

        for idx, i in enumerate(indexes):
            if (idx + 1) % self.disjoint_window_size == 0:
                current_contexts.clear()

            positives = concat_inputs(self.dataset[i]['positive_ctxs'])
            if len(current_contexts.intersection(set(positives))) > 0:
                return False
            else:
                current_contexts.update(set(positives))
        return True

https://github.com/Zhylkaaa/LightningDPR/blob/eac10bf82aeecf96d7b46e0e23ed12ee54145fe9/data_module.py#L91
I think this is dividing list indexes into consecutive, disjoint windows,size of every window is disjoint_window_size .
The purpose of the _is_valid is to make sure that there are no duplicate positive samples in each window.
For example, a list of length 12.  According to the subscript 0-3,4-7,8-12, they were divided into three groups, and no duplicate positive samples were allowed in each group.
So I think it should be doing current_contexts.clear() when i % self.disjoint_window_size == 0.
What do you think, or maybe I misunderstood.

Hello @xiahaoyun, thank you for your attention.
First, your understanding is correct _is_valid is making "sure" that there is no same positive contexts for effective batch (disjoint_window_size is set to efective_batch_size aka. num_gpus * batch_size_per_gpu later in code, referring to your example effective batch is 12 and batch_per_gpu is 4).
I think idx is correct because i is index of example in shuffled list and idx is consecutive number of this example in shuffled list, so on 13'th iteration i will be random index of example and idx will be 12. (while I was writing this I noted that +1 is incorrect, and will fix it in nearest future)
Note: "sure" is in quotes because this algorithm is heuristic to reduce complexity and runtime (I think there are cases where this problem becomes NP-hard)
Thanks for pointing this out!
(if you want to check the differences between this implementation and original DistributedSampler check torch.utils.data.distributed.DistributedSampler sources either on GitHub or in your code editor)

fixed error, fill free to reopen this if I miss understood something

Thank you for your reply.
I realized that I was confusing “idx” with “i”, because enumerate(indexes) was iterated over.


How can I use this with gulp?

There's no official Gulp plug-ins available at this time. You may check out https://thisismanta.github.io/stylus-supremacy/#programming and write one on your own.
Cheers!

Is there a config file except vscode?Like the .eslintrc

There is .stylintrc file. Please go through the official website above.


Versioning and import problems

Issue To Be Solved
I see a lot of imports with commit instead of version on master. This is not so healthy, and makes it really hard to contribute.
I am creating the issue in here, but it is general problem with all flow repositories.
Suggest A Solution
Every merged PR should automatically increase relevant version[0] part and automatically tag.

Every bug fix should increase the patch version
Every new backwards compatible feature, should increase the minor version
Every breaking API change should increase the major version

Also for tracking dependencies, there are few services ( and GitHub Actions )

https://github.com/marketplace/actions/dependent-issues
https://www.dpulls.com/#features
https://github.com/marketplace/actions/pr-dependency-check

It would be also nice to have to auto create issues for dependant projects for every major version bump.
[0] https://semver.org
PS: Also can be very good to have a project page, to show what is being worked on etc. I had some free time, tried to make some PRs, was little hard to find out what I can work on.

I completely agree and have already talked with everyone to not do that in the future. This time it happened that Cadence team wanted to get ahead with changes and made those changes on specific commits. We already agreed this was not a good tactic and after things are tagged they will go back to normal. @bluesign

I've implemented mentioned dependent action, that was a good idea https://github.com/onflow/flow-cli/pull/596

For versioning there are a lot of alternatives like : https://github.com/marketplace/actions/github-tag-bump
https://github.com/marketplace?category=&query=bump+sort%3Apopularity-desc&type=actions&verification=

@bluesign do you think bumping for every PR is better? So currently we tag when doing a release. I can see value in making a tags on every PR merge, I just haven't done that in practice before and I wonder if that works well for you? Also the problem we currently have with CLI but also other repos (and I'm very aware of it and want to go solve it) is that we don't follow semver. I hate that semver doesn't nicely support software in beta since the tradition is to keep it major version at 0 but in reality all the changes that are breaking should increase the major. So hopefully after going 1.0 which I hope will be soon we will be then able to do the major increases as they should be done, before that I'm afraid this might be a bit of a problem to use.

@sideninja Actually avoiding breaking change with semver is pretty easy. It is just about separating your consumer facing interfaces and internal ones. Also it is more critical in libraries then user facing applications.
CLI can stay ( and should stay in version 0 ) but flowkit following semver has great advantages. Actually if you manage to extract FlowKit from CLI, I don't even think CLI needs to follow semver.
When there is a version bump, if it is not major one, you don't even have to check release notes, even with CI you can upgrade the dependencies. If it is minor, you can check on your free time, if some new feature arrived that can be useful later etc.
But biggest power is, constant pressure to not make breaking changes, which is really good motivator. Instead you deprecate stuff and some time in future you make a one big major release. ( spring cleanup ) This has huge advantage, if your replacement API has a bug, it is not critical anymore, because users now have a fallback till next major release.

Nice, good advice, thank you.
I want to take flowkit out soon and actually do a bigger refactor and after that make it 1.0 and start following semver. The refactor will include accumulated ideas in the issue https://github.com/onflow/flow-cli/issues/493 and hopefully we will be able to soon start on that. I agree completely that CLI and flowkit are two separate things, I always had that in mind. I just kept them under rough until flowkit becomes mature enough, and I think that time has come if not for other reasons then due to usage in other projects.
We should automate most of the things at that point, also making sure the dependabot works etc.

Dependencies versions are back to normal, with exception of LS which until extracted from Cadence is a hustle to reference by tagged version due to circular dependency.


There is no way to access Admin panel if there is only one admin and …

…he try to modify the role of Administrator and allow limited access. #5209
Issue Reference

Description

How To Test This?

Documentation

[ ] My pull request requires an update on the documentation repository.

There is an issue here.
When you create a custom role with limited access it shows "role update error".
There is no way to edit that particular role.
https://prnt.sc/1vyjkbq
What we have to do is:
We have to create a scenario where:

At least one role should be there with all the admin access (which cannot be edited / deleted)
At least one admin should be there with that particular role.

Now, what happening is, I'm able to edit the role with all admin access.

Hi @domko17,
Are you working on this?

@devansh-webkul
I finished changes and push to pull request :)

Hi @domko17,
I appreciate your work but there are several problems with this PR,

This can be done in a single file and some other way.
Code styling problems.
Translations not used.
Looping used however which is not needed.

Hi @devansh-webkul,
do I have to fix the code fix? related to this task


Docstring

Hello,
You might have seen the pull request that I actually canceled because of new issues but the docstring is not formatted correctly in your code, please fix that so we can use the intellisense in our own code. I wanted to fix it for you but somehow I had a bunch of errors about Inconsistent use of tabs and spaces in indentation so I kind of gave up, I don't know what's causing it and everytime I use tab to indent a code block, I get this error
For example
	"""
	Get Removal Reasons information as a list. Use
	get_removalReasons(local="False") to fetch from Reddit before returning.
	"""
	@localdata
	def get_removalReasons(self):

should be like this:
	@localdata
	def get_removalReasons(self):
		"""
		Get Removal Reasons information as a list. Use
		get_removalReasons(local="False") to fetch from Reddit before returning.
		"""

Thank you

Seems like you gave up on the project a long time ago :/

Very much haven't given up; just been very busy with other projects. I have a ground up rewrite that should actually be out in a few days that'll fix this amongst other things.

1.0.0 has been released which should give you proper docstrings. Please let me know if you have issues!


[core] Add StatCard component

API Shaping:
<StatCard
  title="Revenue" // Title for the stat card
  value={50000} // Total aggregated value
  unit="$" // Unit for the value (optional)
  precision={2} // Number of decimal places to show (optional)
  change={5} // Percent change (positive or negative)
  changeDuration="Since last month" // Duration for the change comparison, could be picked from date filters
  changeType="percentage" // Can be 'percentage' or 'absolute' change
  trendData={[10, 20, 30, 40, 50]} // Data array for trend line (e.g., a sparkline)
  trendType="positive" // Indicates positive or negative trend (could be used for styling)
  showTrend={true} // Flag to show or hide the trend line
/>

Figma: https://www.figma.com/design/14OEUnwh4ahMb2empYAEc8/Toolpad-UX?node-id=1538-177219&node-type=frame&t=IGyUoo5bh0IcuHEu-0
Benchmarks

Search keywords:

Hi
Please Which version StatCard Component is Available on

Hi Please Which version StatCard Component is Available on

Hey! It's not released yet, this issue is open so that we can gather interest. We'll include it in a future version based on the upvotes


integrated security paragraph

Added paragraph to explain that security is integrated throughout the CAF guidance

@MarkSimos : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @BrianBlanchard - Could you review the proposed edits and indicate whether the PR can be merged? Thanks.


Remove ChangeNotes association with Documents

https://trello.com/c/Ui6ln1cw/975-5-remove-association-between-change-notes-and-documents
Precursor to removing document association from change notes.

If a ChangeNote has no edition associated with it
but there's a duplicate note on the document edition
sequence then delete this note.
If a ChangeNote#note is "First published." and the
associated Document#editions have no "First published."
ChangeNote then assign this note to the first Edition in
the sequence.
Failing to match any of the above, check the change_history
for the relevant document editions, cross reference the note
text and public_updated_at with the note text and public_timestamp
and associate the appropriate ChangeNote with the relevant Edition.
Make another pass over ChangeNotes with edition:nil, if the number
of ChangeNotes for the given document matches the number of editions
for the same document then delete this note, it can't be reassigned.
Lookup all ChangeNotes with a timestamp older than the earliest
edition for the same document, we only care about editions with no
change notes. Delete the older notes as they can't be associated
with an Edition.
There's one ChangeNote left after this, so associated manually.

There are currently 1274 ChangeNotes with no edition associated
with them.

I've run it several times locally on freshly sync'd data but it's definitely worth a run on integration :+1:

@thomasleese I refactored this as the index based lookup of Editions missed a few examples where notes and dates matched so another glance would be appreciated. Will test this branch again on integration tomorrow.

Closing in favour of https://github.com/alphagov/publishing-api/pull/994


documentation: need update documentation about creating superuser using Javascript migrations

Hi, I just tried creating a superuser in pocketbase using js migration file which returned an error about core. this is the code in documentation:
// pb_migrations/1687801090_initial_superuser.js

migrate((app) => {
    let superusers = app.findCollectionByNameOrId("_superusers")

    let record = core.NewRecord(superusers)

    // note: the values can be eventually loaded via $os.getenv(key)
    // or from a special local config file
    record.set("email"<EMAIL_ADDRESS>    record.set("password", "1234567890")

    app.save(record)
}, (app) => { // optional revert operation
    try {
        let record = app.findAuthRecordByEmail("_superusers"<EMAIL_ADDRESS>        app.delete(record)
    } catch {
        // silent errors (probably already deleted)
    }
})

and it returns an error, this is the modified code that created the superuser properly, I haven't tried migrating down yet:
/// <reference path="../pb_data/types.d.ts" />
migrate((app) => {
  // get superusers table
  let superusers = app.findCollectionByNameOrId("_superusers")
  // create new superuser
  let record = new Record(superusers)

  // note: the values can be eventually loaded via $os.getenv(key)
  // or from a special local config file
  record.set("email"<EMAIL_ADDRESS>  record.set("password", "administrator")
  app.save(record)

}, (app) => {// OPTIONAL: add down/revert queries...
  try {
    let record = app.findRecordByEmail("_superusers"<EMAIL_ADDRESS>    app.delete(record)
  } catch (error) {
    console.log(error)
  }
})

pocketbase 0.23.3

Thank you. It is wrongly copied from the Go version. I've pushed a fix.


Updated packages to non major versions, removed lock files and added …

…them to gitingore

Added these library updates in this PR: https://github.com/energy-savings-scheme/rules-interface/pull/2
So closing this.


Agent startup error when ops-agent config already exists

Hey there!
My terraform provisioned VM already has a file at /etc/google-cloud-ops-agent/config.yaml because I've written that file in the VM startup script.
I see the following error in /var/log/syslog when after successfully terraform applying an agent policy targeting my VM:
OSConfigAgent Error apt.go:175: Error installing apt packages individually: Error installing apt package: google-cloud-ops-agent. Error details: error running /usr/bin/apt-get with args ["install" "-y" "google-cloud-ops-agent"]: exit status 100, stdout: "Reading package lists...\nBuilding dependency tree...\nReading state information...\ngoogle-cloud-ops-agent is already the newest version (1.0.9~debian10).\n0 upgraded, 0 newly installed, 0 to remove and 39 not upgraded.\n1 not fully installed or removed.\nAfter this operation, 0 B of additional disk space will be used.\nSetting up google-cloud-ops-agent (1.0.9~debian10) ...\r\n\r\nConfiguration file '/etc/google-cloud-ops-agent/config.yaml'\r\n ==> File on system created by you or by a script.\r\n ==> File also in package provided by package maintainer.\r\n   What would you like to do about it ?  Your options are:\r\n    Y or I  : install the package maintainer's version\r\n    N or O  : keep your currently-installed version\r\n      D     : show the differences between the versions\r\n      Z     : start a shell to examine the situation\r\n The default action is to keep your current version.\r\n*** config.yaml (Y/I/N/O/D/Z) [default=N] ? dpkg: error processing package google-cloud-ops-agent (--configure):\r\n end of file on stdin at conffile prompt\r\nProcessing triggers for libc-bin (2.28-10) ...\r\nErrors were encountered while processing:\r\n google-cloud-ops-agent\r\n", stderr: "E: Sub-process /usr/bin/dpkg returned an error code (1)\n"
Aug  2 15:47:30 rabbitmq-node-tg-0 OSConfigAgent[396]: 2021-08-02T15:47:30.1021Z OSConfigAgent Error retry.go:65: Error Applying apt changes, attempt 3, retrying in 11s: error installing apt packages: Error installing apt package: google-cloud-ops-agent. Error details: error running /usr/bin/apt-get with args ["install" "-y" "google-cloud-ops-agent"]: exit status 100, stdout: "Reading package lists...\nBuilding dependency tree...\nReading state information...\ngoogle-cloud-ops-agent is already the newest version (1.0.9~debian10).\n0 upgraded, 0 newly installed, 0 to remove and 39 not upgraded.\n1 not fully installed or removed.\nAfter this operation, 0 B of additional disk space will be used.\nSetting up google-cloud-ops-agent (1.0.9~debian10) ...\r\n\r\nConfiguration file '/etc/google-cloud-ops-agent/config.yaml'\r\n ==> File on system created by you or by a script.\r\n ==> File also in package provided by package maintainer.\r\n   What would you like to do about it ?  Your options are:\r\n    Y or I  : install the package maintainer's version\r\n    N or O  : keep your currently-installed version\r\n      D     : show the differences between the versions\r\n      Z     : start a shell to examine the situation\r\n The default action is to keep your current version.\r\n*** config.yaml (Y/I/N/O/D/Z) [default=N] ? dpkg: error processing package google-cloud-ops-agent (--configure):\r\n end of file on stdin at conffile prompt\r\nProcessing triggers for libc-bin (2.28-10) ...\r\nErrors were encountered while processing:\r\n google-cloud-ops-agent\r\n", stderr: "E: Sub-process /usr/bin/dpkg returned an error code (1)\n"

As the logs show, the package is configured to prompt the user when a file exists at /etc/google-cloud-ops-agent/config.yaml, necessitating manual action. One option I have is to delay the writing of this file in my start up script to make this less likely to occur, however I'd then need to restart fluent-bit to use the new config.
What I want to be able to terraform apply, creating my VM and agent policy, with the logging already configured without manual intervention.

Actually - this is an issue with ops-agent itself 🤔 - closing.


Rename BUILD_TESTING to QCORO_BUILD_TESTING

Examples and testing executables are features that I do not need when consuming the library. Now, I can easily disable them in my CMakePresets.json, but BUILD_TESTING should have the QCORO_ prefix and a dedicated option. Now I have to hope that no other third party library that I use, uses the same flag :)

Hi, BUILD_TESTING is a standard CMake option to toggle whether tests are built or not.
Depending on how you are using the library you can turn them off selectively - if you are using ExternalProject, just pass -DBUILD_TESTING=OFF in the configure step. If you are just using add_subdirectory() on a git submodule, you can set(BUILD_TESTING OFF) before adding the subdirectory and then either restore it to its previous value or turn it back on afterwards.
Although I see no harm in adding QCORO_ENABLE_TESTING to disable building QCoro tests, alongside the BUILD_TESTING variable itself.


pass

Changes
Solves https://github.com/databricks/databricks-sdk-py/issues/122
Tests

[] make test run locally
[X] make fmt applied
[X] relevant integration tests applied

Can you review @nfx ?


Add location information to TestItems to enable jump to code

It would be good to jump to the source code for a test when you double click on the test in the test explorer (In a similar manner to Xcode).
This requires we get more information about tests. Currently we are getting test list via swift test --list-tests which only gives you the list of tests and no more information. There is a possibility we could get test information from sourcekit-lsp along with extra information like the file they are in and where in that file they are.

We have this enabled once a file has been opened, unfortunately cannot get it working for all files at startup

Would be good if SwiftPM was able to provide the location data in swift test --list-tests.

Looks like we are going to look at a SourceKit-LSP solution for this.

Shall we wait for https://github.com/apple/swift-package-manager/issues/5601 to be implemented?

Actually, this is most likely going to done via a custom LSP request. I just haven't got around to chasing it up.

SourceKit-LSP issue added https://github.com/apple/sourcekit-lsp/issues/611

SourceKit-LSP request workspace/tests is available in Swift 6
Code using it in VSCode can be found in #701


Fails to build with "Assertion failed"

Compilation fails on rgbasm -h -L -o build/bank_000.o code/bank_000.s with:
error: code/bank_000.s(1914) -> data/gfxAndLayouts.s(10):
    Assertion failed
error: code/bank_000.s(1914) -> data/gfxAndLayouts.s(12):
    Number of bytes to read cannot be negative (-167)
error: Assembly aborted (2 errors)!

rgbds v0.6.1

SECTION "Graphics and Layouts", ROM0[$323f]

Gfx_MenuScreens:
	INCBIN "build/menuScreens.2bpp"
.end:

Layout_ATypeInGame:
	INCBIN "data/layout_aTypeInGame.bin"

STATIC_ASSERT $4000-@ == BANK_0_END_LEN

In my case:
build/menuScreens.2bpp is 3328 (0x0d00) bytes
data/layout_aTypeInGame.bin is 360 (0x0168) bytes
$323f + $0d00 + $0168 = $40a7 but must be #3ff7 ($4000-9).
It is $b0 more bytes than expected.

Fix
diff --git a/disasm/Makefile b/disasm/Makefile
index c616998..43b8e61 100644
--- a/disasm/Makefile
+++ b/disasm/Makefile
@@ -10,8 +10,8 @@ BANK_0_FILES = \
 RAM_OBJS = build/wram.o build/hram.o
 INCS = include/constants.s include/hardware.inc include/macros.s include/structs.s

-GFX_1BPP_OBJS = $(shell find gfx/1bpp/ -name '*.png' | sed "s/gfx\/1bpp/build/" | sed "s/.png/.1bpp/")
-GFX_2BPP_OBJS = $(shell find gfx/2bpp/ -name '*.png' | sed "s/gfx\/2bpp/build/" | sed "s/.png/.2bpp/")
+GFX_1BPP_OBJS = $(shell find gfx/1bpp -name '*.png' | sed "s/gfx\/1bpp/build/" | sed "s/.png/.1bpp/")
+GFX_2BPP_OBJS = $(shell find gfx/2bpp -name '*.png' | sed "s/gfx\/2bpp/build/" | sed "s/.png/.2bpp/")
 OUTFILES = -n tetris.sym -m tetris.map

 all: tetris.gb

I'm running on MacOS. That must be proved on Linux.
The problem is that following rules doesn't work:
build/titleScreen.2bpp: gfx/2bpp/titleScreen.png
	rgbgfx -o $@ $< -x 9

build/menuScreens.2bpp: gfx/2bpp/menuScreens.png
	rgbgfx -o $@ $< -x 11

Instead of
rgbgfx -o build/titleScreen.2bpp gfx/2bpp/titleScreen.png -x 9
rgbgfx -o build/menuScreens.2bpp gfx/2bpp/menuScreens.png -x 11

in runs more general rule
rgbgfx -o build//titleScreen.2bpp gfx/2bpp//titleScreen.png
rgbgfx -o build//menuScreens.2bpp gfx/2bpp//menuScreens.png


[BUG] Select2 bugged styles

Select2 bugged styles
Steps To Reproduce
Migrate from 2.4 to 3.x
Screenshots
2.4

3.0

Environment

Item
Version

PHP
8.0.2

Laravel
9.52.4

jeroennoten/laravel-adminlte
3.8.6

@jordihuertas Migration from AdminLTE v2 template to AdminLTE v3 may content a lot of breaking changes. Please, share the code of your select2 definition, and be sure to setup the select2 plugin files on the plugins configuration...

Closing, no feedback!

I am having the same issue