MM-27983: use defaultChecked when no onChange

Summary
React throws a warning when using checked without onChange. Since we use onClick with this component, use defaultChecked instead.
Ticket Link
https://mattermost.atlassian.net/browse/MM-27983

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   38.73%   38.73%
=======================================
  Files          11       11
  Lines        1802     1802
=======================================
  Hits          698      698
  Misses       1020     1020
  Partials       84       84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bb9df...142f59e. Read the comment docs.

Seems to work as a controlled component -- updated! Thanks, @crspeller :)


SCM: When multiple scm/inputBox been registered, the button shifted

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.85.0-insider (user setup)
OS Version: Windows_NT x64 10.0.19045

Steps to Reproduce:

Here is the only one scm/inputBox registered. It's okay.

Here is two extensions registered the same scm/inputBox.

This issue is fixed in the latest VS Code Insiders release.

@doggy8088 can you confirm that this is fixed, please?


Add a test case to validate the behavior of the transfer reassembly state machine against TID wraparound

See https://github.com/UAVCAN/pyuavcan/pull/199

CanardInternalRxSession may require an extra state that indicates whether the start-of-transfer flag has been seen for the current transfer.


pretrained model dose not work

so sorry to bother  you.
I test the pretrained model you provide but it doesnot work.
generate edge that looks like this.Maybe it is not right.Would you mind giving me some advice?
Thanks a lot

@Yachuan-Li could you show me where you got the bdcn_final.pth file?


Make sure that Docker is running correctly and both web apps are being watched.

As a user I need to connect to localhost:3000


Participant information materials

I'll add (once I got it from Linda):

instructions that need to be given verbally to the participant (different for Exp 1 than for Exp 2 and 3)
participant information sheet (what do participant agree to do)
consent form (informed consent needs to be signed)
debrief questions (did you notice any pattern etc)
debrief information

@karlnicholls I've added the ppt material @Lai-Sang sent us to github (code tab). Please check them if they make sense. You'll need copies of at least the consent form.

debrief questions (did you notice any pattern etc)

@karlnicholls I can't remember. Did @Lai-Sang and I send you a spreadsheet with debrief questions?

There wasn't a spreadsheet, but there was an instructions document that mentions asking if they noticed anything special about the dots, what they noticed, and if they mention a pattern, what the pattern was.

Right thanks. There used to be a spreadsheet for this but it doesn't matter. It will probably helpful if you could keep notes of the questions you mentioned above in a spreadsheet so it's easier to evaluate.


[SPARK-44363] [PYTHON] Display percent of unequal rows in DataFrame comparison

What changes were proposed in this pull request?
This PR fixes error message display of percent of unequal rows for unequal DataFrames, in the assertDataFrameEqual util function.
Why are the changes needed?
The correction is needed to provide accurate error message output.
Does this PR introduce any user-facing change?
Yes, the PR modifies user-facing error message for the assertDataFrameEqual util function.
How was this patch tested?
Modified existing tests in runtime/python/pyspark/sql/tests/test_utils.py and runtime/python/pyspark/sql/tests/connect/test_utils.py

Merged to master.


Unrated rounds being counted as rated

Unrated codeforces rounds are being counted as normal rated rounds. That means if an user who is supposed to be unrated participated only in unrated rounds, the application gives him rated colors, max up/down rating values, etc.

Actually it's working as expected


add links to the badges

Is your feature request related to a problem? Please describe.
add links to the badges present in README file so that the user can be redirected to the related webpage/ section.
Now after clicking on badges, like for example when we are clicking at issues badge it is taking us to this page (see image) which is of no use.

Describe the solution you'd like
I will add links to the existing badges and I will add some more badges with links to the readme.md file so that it will look more interactive and awesome, since the badges will be colorful and more attractive than the text the users will like it and it will also help them to navigate to different sections/ webpages like PRs, issues, contributors, etc.

@yashsehgal Should I work on this issue??


fix updatestatus return value

See 20 lines down where this was fixed for static pods

/lgtm

Do we need to do the same to UpdateSpec?

Do we need to do the same to UpdateSpec?

oops, your turn


test refactor & v3 demo

A cleanup of the tests to make it easy to bring up an entire keyspace cluster in keyspace_util.py. We should look at migrating some of our tests to this framework. test/demo.py shows how it's used.
A demo app. To run it:

Launch test/demo.py in one window, wait for 'the cluster is up, press enter to shut it down...' message.
cd examples/demo/ and run: python -m CGIHTTPServer

The ports are currently hard-coded:

8000 for the demo
15010 for vtctld. This will let you view the topo and vschema
15009 for vtgate: The test has this port hard-coded for now

Kill the python server, and press enter on the test/demo.py window to tear everything down.

Coverage remained the same when pulling 9f6d9117662b87231bdadecfea49a9f9fb8a812e on vtgate into fc49d8fefa622e1b16409dbec0b69cdca1d57ccb on master.

Coverage decreased (-0.07%) when pulling a8aba0c062c499c336a3e9a5f7a54fe45367f2e0 on vtgate into fc49d8fefa622e1b16409dbec0b69cdca1d57ccb on master.

LGTM with a few comments:

I think it'd be nice to put it in examples/demo, so everything is in one place.

I tried the demo, but it hangs for me. The demo.py cluster seems to come up fine and I can access vtctld and all that. But when I launch the frontend and visit the URL, the html template loads but then the page hangs. It never even gets around to requesting demo.js according to the log:

$ python -m CGIHTTPServer
Serving HTTP on <IP_ADDRESS> port 8000 ...
<IP_ADDRESS> - - [19/Jan/2015 21:23:20] code 404, message File not found
<IP_ADDRESS> - - [19/Jan/2015 21:23:20] "GET /rPc_sWiTcH HTTP/1.0" 404 -
<IP_ADDRESS> - - [19/Jan/2015 21:23:20] "GET / HTTP/1.1" 200 -
Requests to the server from other tabs also hang until I press "Stop" in the first tab. I guess the server is single-threaded... maybe the browser's request pattern is causing a deadlock? This is Chrome 40 beta.

Did you 'cd demo/' before launching the http server? That may be why.
I'll see if there's a way to specify the root dir. Then you can launch it from anywhere.

The issue with moving it out of test/ is that I'd have to require a PYTHONPATH to find the rest of the support test files, which complicates the setup. We have to find a way out of that, eventually. Otherwise, all our files will end up there.
But I can definitely move the demo/ directory under examples/.

Yeah, I was in the demo folder. It seems to be related to the proxy actually. I was running the demo on my workstation and accessing it from my laptop at home:
Access from workstation (remote desktop): works
Access from home (VPN): works
Access from home (proxy): demo.py server deadlocks (have to spam Ctrl-C to kill it)
So I guess the demo is fine, and it's just the proxy doing something weird.

Yeah. Looks like your proxy's trying to talk to the web server. This is what I see in my logs:
~/...vitess/examples/demo> python -m CGIHTTPServer
Serving HTTP on <IP_ADDRESS> port 8000 ...
<IP_ADDRESS> - - [19/Jan/2015 21:47:58] "GET / HTTP/1.1" 200 -
<IP_ADDRESS> - - [19/Jan/2015 21:47:59] "GET /demo.js HTTP/1.1" 200 -
<IP_ADDRESS> - - [19/Jan/2015 21:47:59] "POST /cgi-bin/data.py HTTP/1.1" 200 -
...
Were you able to execute queries? Do they work for you?
PS: I'v moved demo -> examples/

Coverage decreased (-0.06%) when pulling 38a1ae27bcdde8ade5f69cdd133260029281e2ee on vtgate into fc49d8fefa622e1b16409dbec0b69cdca1d57ccb on master.

Yup, the queries work for me. Fun to play with. :)


Netezza connection

How do I get my Netezza connection to work?
I get the following issue using the Netezza plugin as provided:
Can't create driver instance
Can't load driver class 'org.netezza.Driver'
java.lang.ClassNotFoundException: org.netezza.Driver
I don't think its my JDBC url as this works perfectly in other connections.

Netezza JDBC drivers aren't publicly available. You need to get JDBC driver jar from you Netezza distribution or download from IBM web site.
Then you can add driver's jars to DBeaver driver (open main menu Database->Driver manager->find Netezza driver->Edit->Add file.

Thanks
From: Serge Rider<EMAIL_ADDRESS>Sent: 07 August 2017 21:00
To: serge-rider/dbeaver<EMAIL_ADDRESS>Cc: Bekker, Gerrit<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [serge-rider/dbeaver] Netezza connection (#1976)
Netezza JDBC drivers aren't publicly available. You need to get JDBC driver jar from you Netezza distribution or download from IBM web site.
Then you can add driver's jars to DBeaver driver (open main menu Database->Driver manager->find Netezza driver->Edit->Add file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_serge-2Drider_dbeaver_issues_1976-23issuecomment-2D320750961&d=DwMFaQ&c=BNNF-YNv0CLLslhP2Bcx5Q&r=O5jOh0CvegecprXInatwYPPkzP_3AYCAAXbEfRZI_0s&m=y0XaIFfI7NAL72oiJvVB2Glaa1ha34BBX6pUAOUE4vY&s=-ja0Nzq9goruQ3NK8N_3MA8-bZm4-NX9dfkzixQ7zhQ&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AdX27lhkRkRVf7fWGLzoqc5IQNxHkWDuks5sV16YgaJpZM4OvYa3&d=DwMFaQ&c=BNNF-YNv0CLLslhP2Bcx5Q&r=O5jOh0CvegecprXInatwYPPkzP_3AYCAAXbEfRZI_0s&m=y0XaIFfI7NAL72oiJvVB2Glaa1ha34BBX6pUAOUE4vY&s=IlICXD_c6RVqbJTmN3qU_RESfhJM7uAAPn1H2KNuwvM&e=.


[Bug]: There is overlapping on focus of Checkbox Group

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When the Checkbox Group has been placed close to another widget it gets overlapped on the focus
Steps To Reproduce

Add a Checkbox Group
Add a canvas closeby
focus on the widget
and observe

Public Sample App
release
Version
Cloud

Will be updated as part of dynamic height project. @ankurrsinghal can you tag this in the dynamic height project?


Issue #11: adb-channel fix

ProxyCommand failed on Mac unless adb shell invoked with -n (don't read from stdin). I did not test on Linux but I assume this would not cause problems there.

I signed it!

Thanks!


add libdrm dependency in README

https://github.com/hyprwm/hyprlock/commit/29c5d4da94a26ba6a6491c24de113ee9c0a2b29c
Should this be added in the README too?
and yeah, probably also in the aur pkgbuild

gbm too

Isnt that included in mesa?

it is but mesa is not listed in the deps either

git push -f just became my favorite command

but mesa is not listed
it is now I guess


Should AddIdentity throw if called more than once?

See for some bad unexpected things that can happen: https://github.com/aspnet/Identity/issues/972
Basically we don't really support it, so should we try to block it?  Throw if a AddIdentity is called a second time(we can just look for our Marker interface basically)
Thoughts? @divega @blowdart

Would it be easy to make it idempotent? e.g. do we have places in which we could replace Add with TryAdd methods?

AddIdentity is fine, its the Configure of the options, they SHARE options (since its singleton), which is 100% not what people would expect, that you get the union of all of the AddIdentity options configurations, with last one winning...

Meaning, the services we add are fine in AddIdentity, those are already all TryAdds and safe

Throw

Agreed.

This is probably technically a breaking change, still ok for 1.1?

Fair enough, it is a breaking change if customers can reasonably have things working with this setup today. We need to understand:

How common this is.
Are there legitimate reasons to have things setup this way or are we convinced it is not a valid scenario? If it is a valid scenario we may consider a pattern to allow independent options to be configured (e.g. we solved this problem in EF Core with generic options).

Then we can decide what to do for 1.1.

I doubt its very common, but given that we've already seen one example of someone doing this, its certainly possible today if they have multiple user entity types, and are using identity to access them.  That said, if they are careful and either avoided or worked around any issues that arose from all instances of UserManager's sharing the same identity options, it would work...

That said, even if we were to block AddIdentity from being called more than once, anyone who was relying on this before would still be able to work around the block by manually adding the services that AddIdentity does.


Integration Test - Release - 2021/10/04 01:14:00

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

#please-close

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

GitHub user PRMergerTest1 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.


Xcode 7.3 PINURLSessionManager.h:31 nullability warning

PINRemoteImage.framework/Headers/PINURLSessionManager.h:31:26: Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)

Fixed by #170


Kibana read only mode?

Hello, I'm using Opendistro 1.0 (for Kibana 7.0.1).
I've noticed there's a reserved role called kibana_read_only, which is empty (it doesn't make any sense).
I tried using kibana_user one, but I've noticed that cloning it and assigning an user to it doesn't work (it only works with the original role).
But in doing so, I can't modify it to remove permissions (and obtain a true read_only role).
Can anyone help?
Regards.

the same issue ,
using a copy of kibana_user role and do not change any thing . then add a user to this role, the user see blank dashborad list。
only the original kibana_user role works
es version 7.6.1
od security 1.6.0

Same
Using es 7.7.0
plugin <IP_ADDRESS>-1

We are doing some "spring cleaning in the fall", and to make sure we focus our energies on the right issues and we get a better picture of the state of the repo, we are closing all issues that we are carrying over from the ODFE era (ODFE is no longer supported/maintained, see post here).
If you believe this issue should still be considered for current versions of OpenSearch, apologies! Please let us know by re-opening it.
Thanks!


enhance delete subscription

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #421
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@DanielXLee What's PR related GITHUB issue?

@renshichuang this one: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/38440


[NOD-710] Extract MQTT topics to constants

Rebuild after update in master

Rebuild after update in master

Rebuild after update in master

Rebuild after update in master


Container image SBOM

Description
Adds steps in the container image release process to generate the SBOM file for it and upload it to the build artifacts and as a release asset.
Fix #314

* I remember you mentioned other tools that could generate a SBOM for a container image. Why did you pick `sbom`? Note: I have nothing against this choice

I've decide to use the bom command for Kubernetes because some main reasons:

We are already using it in the controller
The syft command that I've mentioned does not find any packages in the policy-server container image. I believe this happens because we build a container from the scratch image. Which means there are no root fs. Afaics, syft checks for the package in the container's root fs. While the Kubernetes bom is able to find the files in the container and generate the relationship of that.
It's from Kubernetes community

* Does the microsoft sbom tool support also container images? I'm asking because it would be nice, one day, to have just one single dependency to create sboms (both for binaries and container images)

I agree. But we are not using the Microsoft tool anywhere. While we do not get a fix for the issue in the rust code, I've decided to go with spdx-sbom-generator. And this tools does not have SBOM generation for container image. At least, I could not find docs about that. Therefore, in the current state, I need to add other tool in our stack. But I agree that we can migrate to a single tool that attend all our needs in the future.

@jvanz thanks for the explanation! Let's go ahead with sbom :+1:

This PR now depends on https://github.com/kubewarden/github-actions/pull/39

@viccuad can you take another look? I did the changes we proposed

Thanks, merging!


consensus: create new config for each authority

Create a new Narwhal configuration for each authority we want to start
in order to avoid binding to the exact same ports. Eventaully we'll want
this config to be a part of a larger ValidatorConfig.

@asonnino while they may not contain network information for the primary/worker and transaction interfaces, they most certainly do contain network information for the interface @arun-koshy recently added.
https://github.com/MystenLabs/narwhal/blob/main/config/src/lib.rs#L110-L111
https://github.com/MystenLabs/narwhal/blob/main/config/src/lib.rs#L118-L119

@asonnino while they may not contain network information for the primary/worker and transaction interfaces, they most certainly do contain network information for the interface @arun-koshy recently added.
https://github.com/MystenLabs/narwhal/blob/main/config/src/lib.rs#L110-L111
https://github.com/MystenLabs/narwhal/blob/main/config/src/lib.rs#L118-L119

Ha I see


Decide on domain and Use Lets encrypt for certificate

decide on domain for wss
otherwise has to use self issued certificate.

Yes


Bus error on running code-server on heroku

Steps to Reproduce

Deploy code-server on heroku (Not sure weather supported or not)
run ./code-server -p $PORT

I made this to deploy.
Attaching Error

Haven't seen this before.
Which OS is this running? uname -a would help.

Copy option is not available on heroku bash so I am adding screenshot of output.

Not sure what the could be. Can you try running the docker container inside Heroku?

I don't have much experience with docker container. I will read heoku docs and try to run a docker container there.

Has anyone been successful with running on heroku?

Hi, guys.
i change image for run on heroku, you can try it https://hub.docker.com/r/ivang7/code-server-heroku

What changes were necessary?

i changed Docker file, add env variable PORT (need for heroku) and replace entrypoint to CMD command, also add download lastest release for include it in image, full file in gist:
https://gist.github.com/ivang7/7835a15277482b1a414f880ff7ca9723

I think all we need to do is add support for the $PORT variable to code-server. This bus error issue must have been something else.

Opened #1444

Excuse me, i created heroku application using @ivang7 docker but I can not access to website due to password problem. What is its default password or how can I reset password. I tried to run command "code-server --auth none" by heroku cli but it not working


[Tree] ORM Closure Strategy - "level" property update doesn't play well with other Doctrine listeners

I've been trying to track this issue down for a while.
Before I describe the issue, this is what I've got going on:

I have a Page entity that is setup to be a tree with closure strategy.
I have my own Doctrine event subscriber that can persist a new Route entity whenever a Page is created or updated. If necessary, my subscriber flushes the EM for a second time in the postFlush event.
My own subscriber is being executed after Gedmo's TreeListener.

Now for the problem:

Gedmo's Closure strategy tells Doctrine to trigger an extra update on line 351. That's working well.
I believe that line 357 is supposed to make Doctrine keep track of the new level.
However, when my subscriber flush the EM, it seems to revert level back to the old/invalid value (NULL in my case).

Potential solution:
If I edit the Closure strategy to actually change the level property value on the entity, everything appears to work well.
To do this, I've changed lines 351-357 to:
$levelProp = $meta->getReflectionProperty($config['level']);
$uow->scheduleExtraUpdate(
    $node,
    array($config['level'] => array(
        $levelProp->getValue($node), $level,
    ))
);
$levelProp->setValue($node, $level);
$uow->setOriginalEntityProperty(spl_object_hash($node), $config['level'], $level);

I don't really understand all of what's going on under the hood in Doctrine to know whether what I did is a big no-no, or whether or not $uow->setOriginalEntityProperty(..) is still needed, but this does solve my problem.
Do you think it's ok to make a PR with this change? Concerns?

I also had to add the $levelProp stuff to https://github.com/Atlantic18/DoctrineExtensions/blob/master/lib/Gedmo/Tree/Strategy/ORM/Closure.php#L285-L286

the closure tree was contributed and I haven't worked with the code much, the lines mentioned may be wrong indeed


Ix await foreach with GroupBy?

This seems like something I could do in Rx, but my Ix experiments aren't working.
I'm using a System.Threading.Channels.Channel to generate the AsyncEnumerable, and this works as expected (I'm not grouping in this example).
(side note: I ain't no wizard, so I'll happily accept if this is just plain wrong)
async Task Main()
{
	var channel = Channel.CreateUnbounded<int>(new UnboundedChannelOptions {
		SingleReader = false,
		SingleWriter = false
	});

	var rand = new Random();

	var writing = Enumerable
		.Range(0, 10)
		.Select(async e => {
			await Task.Delay(rand.Next(1, 5) * 1000);
			var w = rand.Next(0, 10);
			w.Dump($"writing for index {e}");
			await channel.Writer.WriteAsync(w);
		});

	async Task Read(int reader) {
		await foreach (var a in channel.Reader.ReadAllAsync())
		{
			a.Dump($"reading with reader {reader}");
		}
	}

	var reading = Enumerable
		.Range(0, 2)
		.Select(async p => await Read(p));

	"waiting".Dump();
	await Task.WhenAll(reading.Concat(writing));
}

Essentially, the output looks like:
* writing for index 3
	5
* writing for index 1
	4
* writing for index 5
	5
* reading with reader 1
	4
* reading with reader 0
	5
* reading with reader 0
	5
* writing for index 9
	8
* writing for index 8
	0
* reading with reader 0
	0
* reading with reader 1
	8
* writing for index 0
	4
* reading with reader 1
	4
* writing for index 2
	3
* writing for index 4
	5
* writing for index 7
	8
* writing for index 6
	8
* reading with reader 0
	3
* reading with reader 1
	5
* reading with reader 0
	8
* reading with reader 1
	8

So I tried changing the Read function to use GroupBy like this:
	async Task Read(int reader) {
		await foreach (var a in channel.Reader.ReadAllAsync()**.GroupBy(r => r % 2 == 0)**)
		{
			a.Dump($"reading with reader {reader}");
		}
	}

...but none of the reads ever dump. All I see in the output are the "writing" lines from the previous output.
What's up with GroupBy? Am I not using it correctly? I tried things like .Where and .Distinct and those work fine here. It's just GroupBy that doesn't produce any results.

Wait... Does the channel writer have to complete before GroupBy works?  This simplified example does work, but only with the channel.Writer.Complete(); line. Otherwise, it just waits as before.
async Task Main()
{
	var channel = Channel.CreateUnbounded<int>(new UnboundedChannelOptions
	{
		SingleReader = false,
		SingleWriter = false
	});

	var xs = new List<int> { 1, 2, 3, 4, 5, 6, 7, 8 };

	foreach (var x in xs)
	{
		await channel.Writer.WriteAsync(x);
	}
	channel.Writer.Complete();

	await foreach (var y in channel.Reader.ReadAllAsync().GroupBy(x => x % 2 == 0))
	{
		y.Dump();
	}
}

I'm not 100% certain but IAsyncEnumerable::GroupBy looks like it is not live and does all the grouping before it releases the groups upon upstream completion.

@akarnokd That's what it looks like. How did you figure out that it's not "live"?
Is there another construct I can use? I basically need a queue of lists, where the list can be appended to up to the point that the queue item is processed.  I'm having trouble translating that concept to a well known c# construct, or even a library that does what I need.

The source code doesn't look anything like my version that is live and pushes out group items as soon as there is demand for them.

@akarnokd So where's the disconnect? Where did your version come from and why is the official version not live?  Yours sounds exactly like what I need.

So where's the disconnect?

Not sure what you mean.

Where did your version come from

It is an intuitive implementation based on my experience with backpressure-enabled reactive flows.

why is the official version not live?

Probably because if you don't consume a group in the live version, both the main and the other groups hang. That's a risk not taken by the standard implementation.

why is the official version not live?

If you consider the following query:
var list = Enumerable.Range(1, 12).GroupBy(i => i % 2).Concat();

The result will be: 1, 3, 5, 7, 9, 11, 2, 4, 6, 8, 10, 12. Obviously there needs to be buffering somewhere in the pipeline to get that result. In LINQ to objects (Ix) GroupBy is eagerly so it builds a dictionary and once the sequence is completed it will yield the collected content. In the reactive world, however, GroupBy is lazy and the buffering happens in the Concat operator. The point is there needs to be buffering or eagerly evaluation somewhere else the sequence would hang as @akarnokd pointed out.
Async.Ix is an async one-to-one translation of Ix, so it uses the same semantics as Ix (and not like Rx).


Implicit Tiling + Tile Metadata

This branch is ready for review, but it's built on top of the WIP resource-cache branch shared by @lilleyse and I. Do not merge until resource-cache is finished.
This adds tile metadata from the 3DTILES_metadata extension into implicit tiling (3DTILES_implicit_tiling). It handles extracting the tile metadata from the subtree buffer views and storing it within the ImplicitSubtree object. This ImplicitSubtree object is now attached to each transcoded tile.
Relevant specifications:

 3DTILES_metadata spec especially the Implicit Tile Metadata section
3DTILES_implicit_tiling spec

@lilleyse could you review when you get a chance?

Thanks for the pull request @ptrgags!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Ugh typescript error, I'll look into it.


How to prevent click outside?

Hi, with this plugin we can capture outside events, but cannot prevent it like event.preventDefault
Is it possible in vue.js way ?

I don't think it is the intended behavior, as it is not an event. But maybe I'm wrong.


Add support for Urldate field

Closes #53

@Seelengrab How's that?
See the example at https://juliadocs.org/DocumenterCitations.jl/previews/PR55/references/#WP_Schroedinger
from
https://github.com/JuliaDocs/DocumenterCitations.jl/blob/0667efe929e09a3b6a0526a5daaa123abb9802f5/docs/src/refs.bib#L683-L688

Looks good!


Fix "Core Technical Concepts" header in README.md

Reason: it was rendered not properly.
📗  Updates only docs

:+1:


Deprecate config key branch of GitlabDiscoveryEntityProvider in favor of new key fallbackBranch

This PR is the 1st step to migrate reuse the config key branch for setting up the branch to use for discover catalog files
relates #13587, #16502
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

cc: @jhaals


Error while opening the bot

hi i got this error when on my phone request error : unable to sync even i turned off the script whats the problem

same

i have same issue. try later

same

Guys it still happens to me, what we gonna do?

same

Guys it still happens to me, what we gonna do?

I don't know bro, I have this problem too. None of the accounts will be opened

same

Guys it still happens to me, what we gonna do?

I don't know bro, I have this problem too. None of the accounts will be opened

even those that not running with this script ?

When the script is running, do not launch the game on your phone. After turning off the script, wait 30 minutes before entering the game from your phone. For me this error disappears when I log in 40-60 minutes after closing the script.


alter_id from a environment variable

to use the script is necessary change the client_id, like say in this line
https://github.com/0x27/imgurscrot/blob/master/imgurscrot.py#L18
maybe you can get the client_id from a environment variable, like I make in slacker-cli
https://github.com/juanpabloaj/slacker-cli/blob/master/slacker_cli/__init__.py#L46

Good point, I must admit, I did accidentally commit my own client_id there. I'll rectify that post haste :)

Fixed: https://github.com/0x27/imgurscrot/commit/aa87c0ccb8182b9530ea00256c9cf46cfb0edc16
Many thanks :) This 24 hour hackathon is taking its toll, this is the second time I have hardcoded and committed an API key today!

maybe in the readme file you need add the name of environment variable and how set this


Restore pagination in entity list

Very bad idea. Lists are potentially long, in principle you can have 1000s of entities in the RDR. You may end up with network overload, slow and unreadable web page.

With the kind of controls we are using in the corporate (tree), the pagination does not have sense. In fact, the idea is removing all pagination from lists

Added ~56 ~54 labels

Ok, we can think keeping it for lists (there is no so much lists now), for the trees I'm not sure, it would be depending on the tree control we use.

Milestone removed

View #141


Conditionals

The Alan v0.2 conditionals concept is that if <conditional> { ... } else ... is rewritten into cond function calls where all function bodies are branchless and must run until the end.
This means return statements are only valid as the last statement in a function body at that point.
This also means that conditional branches that don't return and pass back control flow to the higher layer must instead bolt on the follow-up code to the tail of their own function body. Excepting only if all branches of a conditional do not return, where fall-through is allowed, and all branches where the conditional does return, in which case follow-on code is a failure.
The cond function will be just like any other function, so users can write their own that accepts something other than bools. This will be used for native GPGPU support, as both branches of a conditional need to be transformed into an AST to serialize to wgsl for the GPU.

cond for bool has been implemented. If both branches are defined they need to both return the same type, if one branch is defined it auto-wraps into a Maybe{T} for the true branch.
This does make it a good fit for use in assignment statements, and I wonder what, if any, syntactic sugar should exist for that usage.
It wouldn't be too hard to get a ternary-like set of operators, though there would be the unexpected closure function syntax necessary. It would also be possible to add some syntactic sugar, which could work like Rust or Python or do something different entirely.


'Django Make Migrations' becomes disabled

After making migrations fails and exiting the interactive prompt with typing '2', the option 'Django Make Migrations (Django >= 1.7) in the project context menu becomes disabled.
The only solution I've found is to restart Visual Studio.

Disabling the menu item is normal behaviour when the command fails to run - closing and reopening the project should be enough to enable it again.
Can you show us the output in the window? There's clearly something going on that is causing the command to fail, but without that information we can't do anything to help.

For some reason I can't repeat this problem. It was present after making migrations was interrupted by some error and the console log outputs 'The interactive Python process has exited.'. The python code itself was valid.

Okay, thanks for getting back to us. There's nothing we can fix here as far as I can tell, so I'll close the issue.


Bring up-to-date with standard library 1.5

Fixes #242.
Despite my ineptness at category theory, I think I've fixed everything except one last hole in Categories.Object.Subobject.Properties. I'd appreciate some help in finishing the proof for cong.

@JacquesCarette should I merge this in?

@JacquesCarette should I merge this in?

Let me do it. It looks all fine, but I want to take another look first. I'll do it by tomorrow.

Let me do it. It looks all fine, but I want to take another look first. I'll do it by tomorrow.


Exclude tests on aarch64_mac

Exclude tests on aarch64_mac for all versions due to backlog/issues/1300

After merge, this PR should be ported into https://github.com/adoptium/aqa-tests/tree/v1.0.0-release

Thanks @annaibm . The PR is fixed in https://github.com/adoptium/aqa-tests/pull/4992


Overall - Landing Page

https://docs.google.com/document/d/1E2RnEgIKT-QjBTFeijLAa5HYLEs-5JTb1rJLeCOKesc/edit

This is Duplicate ticket Please refer #2642


who can prompt any code about how to create the tf-record dataset?

I create the tfrecord file(the official pascal voc2007 dataset) with tf-object-detection api script,but it seems something wrong,as the model I trained with the tf-record file can't detect anything!

If you got one useful script, shall I got one copy?thks!

https://github.com/zzh8829/yolov3-tf2/blob/master/docs/training_voc.md


feat: Lydia/backport min commish v0.45.6

Description
Closes: #XXXX

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] followed the guidelines for building modules
[ ] included the necessary unit and integration tests
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

@evan-forbes  The "Tests / Code Coverage / install-tparse" and "Tests / Code Coverage / test-cosmovisor" are failing, and haven't in previous PRs of this nature. Also "Protobuf / breakage" was successful, but it's failed in the past, which I think is what it's meant to do.
VSCode also says there are lots of errors--even before I added these last two commits for minimum commission. So the code was exactly the same as v0.45.6. I'm not sure if it's okay to precede anyways or not.

We are going to wait for v0.46 of the sdk to be released instead of switching to v0.45.6


[Bug] Enable control-plane scaling

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
Others
What happened + What you expected to happen
Currently when the Head Node pod is bounced the entire state of the Ray Cluster is lost, jobs end, and logs are lost.
This could be fixed with horizontally scaling the head node:

Having multiple head node pods would increase redundancy and further reliability of the Ray Cluster.
Having the Ray Cluster to recover if the head node is bounced.

I believe this would be a huge enhancement of Kuberay.
Reproduction script
Bounce the control-plane and the entire Cluster is "restarts" with a new state.
Anything else
Unsure if Ray's current architecture can handle dynamic scaling of control-planes, but I believe being able to scale to 1-3 head nodes statically would be an option.
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Having multiple head node pods would increase redundancy and further reliability of the Ray Cluster.

Ray does not support multiple Ray heads.

Having the Ray Cluster to recover if the head node is bounced.

You can configure RayCluster to support GCS fault tolerance with an external Redis.


Modularize code base

Some people only want sticky states, some want DSR, some want future states.

summon @amcdnl

https://github.com/christopherthielen/ui-router-extras/commit/aebf936db9cd4c7dc8f2b813f20572ba3b07bea6
Now, we have the following modules:
var moduleNames = [ 'core', 'dsr', 'sticky', 'future', 'previous', 'transition', 'statevis' ];
Each is built, tested, and minified separately.  The output goes to build/modular directory.   Each module defines an angular module ct.ui.router.extras.sticky  for instance.
A special meta-module 'all' includes in each of the individual modules, and defines the "includes everything" angular module ct.ui.router.extras.

:)


Can the logger be redacted?

We'd like to be able to use the logger extension but I'm not seeing anyway to redact information. How does one protect password from being logged in the below example?
async fn login(&self, email: String, password: String) -> FieldResult<TokenSet>;

This is currently not supported, I need to think about how to implement this feature.

Interested in this as well, maybe an option for the attributes to keep it secret?

I am adding support for this feature.

I added a secret attribute to the master branch.

Here is the example:
https://github.com/async-graphql/async-graphql/blob/6aa191fba519b36978e546330d500edf195b7ce2/src/registry/stringify_exec_doc.rs#L290

Looks good, thanks!

Perhaps this should be called redact?


Recursive search of model files from ModelScope is not supported

Describe the bug

Steps to reproduce

Expected behavior

Environment

GPUStack version: main
UI version: 3ab29f9

Additional context
Add any other context about the problem here.

Environment

GPUStack version: main(71a49fd)
UI version: bc921ff
OS: macOS 14.6.1
GPU: Apple M2, 24G

Test Results:

UI: pass
Backend: failed,

Failed to download the model file.

2024-09-29T10:04:25+08:00 - gpustack.scheduler.scheduler - ERROR - Failed to find candidate for model instance mxbai-embed-large-v1-hMFfB: File gguf/mxbai-embed-large-v1-f16.gguf not found in LLM-Research/mxbai-embed-large-v1
2024-09-29T10:04:25+08:00 - gpustack.scheduler.scheduler - DEBUG - No suitable workers for model instance mxbai-embed-large-v1-hMFfB

Environment

GPUStack version: main(9d42d5f)
OS: macOS 14.6.1
GPU: Apple M2, 24G

Test Result: pass


Vertical button style radios/checkboxes bottom label margin not removed

Bootstrap V4.0.0.-beta.2
Operating system and version (any)
Browser and version All
Reduced test case https://codepen.io/tmorehouse/pen/BwEpOr

When using button style radios or checkboxes in vertical mode, the label margin-bottom is not set to 0 causing spacing issues between the "buttons":

Expected behavior:
That the bottom margin be set to 0 for the labels, as would be for regular buttons in a vertical button group.
Workaround:
.btn-group-vertical label.btn {
  margin-bottom: 0;
}

or manually setting class mb-0 on each label.btn

working on a fix :)


[Chore] Add Unit and UI test for Home Screen

Why

Home Screen needs Unit and UI tests

Acceptance Criteria

Add test functions for Home screen
Tests passed

Added to #11


Improve <stdexcept> documentation and examples

<stdexcept> docs: Update ms.date.
Fix #2410.

Explain how domain_error and range_error refer to math.
Mention that the STL doesn't throw domain_error or underflow_error.

Add parens to message.data() for consistency with other docs.
Overhaul all <stdexcept> examples.

/GR is enabled by default.
We don't need /MDd.
Include all necessary headers.
Improve paren/brace/bracket consistency.
Remove unnecessary semicolons.
Add constness when catching const exception&.
Rename to invalid_argument.cpp, matching the type exactly.
bitset can be directly constructed from const char *, we don't need string.
Shadowing the bitset type with a bitset variable is confusing; rename to b.
Always print colons in "Caught: " and "Type: " for consistency.
Regenerate all outputs with VS 2022 17.0 Preview 3, some exception messages changed slightly.
Massively simplify the length_error example and remove non-Standard code.
Change the logic_error string to "Does not compute!" to avoid potential confusion.
Drop unnecessary comments like // out_of_range.
Always print the type - it was missing from the out_of_range example.
Consistently display the output as a comment at the end of the file.
In the range_error example, catch const exception& to demonstrate inheritance like all other examples.

@StephanTLavavej : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


fixed cutout without AlphaToMask

Wouldn't even work because the toggle drawer doesnt enable the keyword if the float value gets set by code in the rendering presets


Change links to https in README

Because we like privacy

builds is broken
esthost process for source(s) 'C:\projects\ahoy\test\Swashbuckle.AspNetCore.ApiTesting.Test\bin\Debug\net6.0\Swashbuckle.AspNetCore.ApiTesting.Test.dll' exited with error: You must install or update .NET to run this application.
App: C:\projects\ahoy\test\Swashbuckle.AspNetCore.ApiTesting.Test\bin\Debug\net6.0\testhost.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64)
.NET location: C:\Users\appveyor\AppData\Local\Microsoft\dotnet\
The following frameworks were found:
  1.0.16 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  1.1.13 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  2.0.9 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  2.1.18 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  2.2.7 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  3.0.3 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  3.1.4 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  3.1.32 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  5.0.17 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  7.0.0 at [C:\Users\appveyor\AppData\Local\Microsoft\dotnet\shared\Microsoft.NETCore.App]
Learn about framework resolution:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=6.0.0&arch=x64&rid=win10-x64
. Please check the diagnostic logs for more information.
Test Run Aborted.

Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI.

Cherry-picked to #2808.


chore(ci): Fix pinned dependencies

Description of your changes
This pull requests pins packages to specific versions where possible based on the findings of OpenSSF.
Related issues, RFCs
Issue number: #1799
Checklist

[x] My changes meet the tenets criteria
[x] I have performed a self-review of my own code
[x] I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my change is effective and works
[x] The PR title follows the conventional commit semantics

Breaking change checklist
Is it a breaking change?: NO

[x] I have documented the migration process
[x] I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Hey @sthulb why did you remove the files in the .devcontainer folder? These are needed for GitHub CodeSpaces which we reference in our contribution doc


[EN] Feedback for: /web/tools/chrome-devtools/?hl=en

I have an overlap issue (on the right side of the screenshot) with the web contents when viewing Google Dev Web in Firefox as you can see in the screenshot below.

Operating System: Linux Mint 17.3 (64 bit)
Browser: Firefox 45.0

Thanks for the feedback, we've got an update coming next week that should fix this.


[Philemon] v1.4 DG, oauth2 enhanced, unknown command parsing

Coverage remained the same at 81.842% when pulling ea20d72085b54ceff59ab358e527432e83889946 on philemontan:v1.4_DG_importexport into 80308bf68b2d99fe48e87d636945749231193512 on CS2103AUG2017-T11-B1:master.

Coverage remained the same at 81.842% when pulling 3937a31af4bbbbda16f5b96143f57ef653cded0a on philemontan:v1.4_DG_importexport into 80308bf68b2d99fe48e87d636945749231193512 on CS2103AUG2017-T11-B1:master.

Coverage remained the same at 81.842% when pulling 3937a31af4bbbbda16f5b96143f57ef653cded0a on philemontan:v1.4_DG_importexport into 80308bf68b2d99fe48e87d636945749231193512 on CS2103AUG2017-T11-B1:master.


Enable Binskim scan in CI builds

Enabling BinSkim scan over build artifacts in CI based on company requirements.
We are required to run SDL tools on official builds and implement automated bug filling for the tools output. Currently we are running SDL checks over the source code in the nightly builds, inline in the builds for some of the product repos and in the .NET staging pipeline, but to be compliant we need to also run BinSkim over the produced artifacts.
This PRs is enabling BinSkim checks in the Run SDL tool job of razor-ci-official.
More information is in the Automate BinSkim runs over official builds issue

In Razor Tooling Compliance build pipeline we also run APIScan. I think to be coherent we need this setup in that pipeline as well for compliance checks.

The goal is to scan all assets that are getting shipped, so it's enough to run the tool in the official CI - that would cover all changes to the repo
cc @andriipatsula

We are running SDL checks as part of the nightly pipeline (every day) and during release preparation. It'd be an overhead to run them on every commit to main.

@maryamariyan You are welcome to add the binskim to the compliance runs in https://devdiv.visualstudio.com/DevDiv/_build?definitionId=16802&_a=summary. I don't think that dnceng implemented any infra for that pipepline though. That looks to be custom for razor.
FYI it looks like that APIScan run has been failing for a while due to an authentication error.


Loss function

Why is the loss function, IID_loss(), negative ?

Loss is supposed to be negative because mutual information is nonnegative, and we're minimizing -1 * mutual information.
Also see thread.


fix: work around Rust 1.69 almost_swapped lint

The enhanced clippy::almost_swapped lint which shipped in Rust 1.69.0
was triggering in some cases where we derive clap::Subcommand. It
wasn't possible to allow it, because a deny on clippy::correctness
(which implies clippy::almost_swapped) was present in the generated
code.
As a result, we had to fix the version of Rust used for Clippy to
1.68.2.
In clap_derive (included in clap) 3.2.25, the deny on clippy::correctness
has been removed and an allow for clippy::almost_swapped has beed
added. Fixing the forced clippy error.
This change updates clap to the latest 3.x version, including
clap_derive and clap_lex.
It also reverts the change made in #413, so we will go back to using
the latest version of Rust for clippy and fmt.

@hawkw This change is ready to go in. It updates clap_derive in the Cargo.lock file and fully reverts #413 so we're back to using the latest Rust version for clippy and fmt.


Jvenstad/contain zms zts et al

@tokle FYI.

@tokle tests pass now. Take a look if you want. Otherwise, I can try to split into smaller commit first, but it won't be easy >_<

We also need to set up the new component in controller services.

Moved things to facilitate component setup, and added some more scaffolding for you to fill out.

Do you mind if I merge this now to see if it works, and then rename things later?


scanner: change OPCODE constants to u16

This also fixes the event_created_child macro to match a pat to allow paths and expressions to work.

This just need to update the scanner test assets for the CI to pass, otherwise lgtm.

Have updated the tests


Install nbgrader

nbgrader makes some very specific assumptions about the shape of the hub it runs on - around user ids, home directory structure, permissions, etc. They don't map very well to the distributed scalable cloud hubs, so it isn't easy to use it as one would use nbgrader, unfortunately.

thanks @yuvipanda.  Could https://ds-modules.github.io/curriculum-guide/workflow/collecting-grading-assignments.html be implemented for Jupyter nbs?  https://rstudio.github.io/learnr/ could be implemented for RStudio.  In both cases it would be great to have a workflow where instructors can autograde then grades are exported into our LMS (Canvas).


Data IO notes

we could slightly add more info about terms like string and character - or replace them
could use  https://cran.r-project.org/web/packages/OCSdata/vignettes/instructions.html#raw  to get the data set up in a similar manner so people are set up the same
maybe make a visual about how data should be set up - where files should live relative to eachother
could maybe remove the tibble description in Data IO - because we will do that later in depth? or I could remove it from data subsetting/data classes
more discussion about different data types in data io? pointing people to foreign for spss users could also help but we already have haven
could also show how to use  file --> import Dataset when people can't find files on their machine

Also just want to emphasize that you did great @avahoffman! I just thought maybe these things could help based on today. Please feel free to give me similar notes if you have any.

I had these notes for the intro... but at that point we haven't worked with data so it might make sense here?
describe how you can see data variables in environment: Click the play button on the lefthand side of the dataset under “Data” in the environment

Maybe introduce the file -> import dataset -> from text (readr) first

I have a video of this now for the resource page


[cdc] Parse NEW violations only

This commit revises the CDC flow to parse NEW report not ALL report
file. The result report contains only NEW violations. Previously, the
report has WAIVED list too.

As this PR is not related to SIM/ CW310 tests. Let me skip and merge.


Are the available regions correct?

I'm pretty sure i was able to do this for Australian regions, but it's not on the list. Can also see it is an option (see below in Azure Portal)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ade067f1-3f3e-73de-0321-bb8d07147cd3
Version Independent ID: e8dc38c4-0114-b7c2-887f-e1d2810206e8
Content: Server-side encryption of Azure Managed Disks - PowerShell - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/disk-encryption.md
Service: virtual-machines
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

@forktrucka
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@roygara
Can you please check and add your comments on this doc update request as applicable.

@forktrucka Thanks for reaching out, would you clarify what you're trying to do? This article has several different encryption types with their own availability.

Hi, just creating an encrypted disk set for Windows VMs in Australia East using keys from keyvault.
Just checking through any limitations before expanding to other regions when I clocked the region and vm size restrictions.

@forktrucka Ah, disk encryption sets are required for most of the encryption types covered in this article so that doesn't quite narrow it down. If you mean customer-managed keys just by itself then those no longer have any regional restrictions - they're available in all regions. Encryption at host and double encryption at rest do have regional restrictions, and those are in this article (and accurate).
Does that answer your question? Let us know if we can clarify things further. :)

Ok cool. Please forgive my confusion


Transactions supporte are not documented for the new .NET Standard client

This documentation is for legacy client, not the new and the recommended one (Microsoft.Azure.ServiceBus).
Consider updating documentation to reflect the new client.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c400c2c-cd70-ab18-a223-72325076b7c8
Version Independent ID: c533c4c2-bd88-9527-dd5d-aaf0d16ca625
Content: Overview of transaction processing in Azure Service Bus
Content Source: articles/service-bus-messaging/service-bus-transactions.md
Service: service-bus-messaging
GitHub Login: @spelluru
Microsoft Alias: spelluru

doc update underway
@spelluru   #please-close

The update PR is internal to Microsoft. Would it be possible to close public facing issues once PRs are merged and it's possible to confirm changes were made?
Not saying it will happen, but if PR falls through the cracks and a public issue is closed, it feels counter productive. Thank you for understanding.


[test-triage] chip_sw_coremark

Hierarchy of regression failure
Chip Level
Failure Description
ERROR: Skipping '//sw/device/benchmarks/coremark/coremark_top_earlgrey:1_sim_dv': no such package 'sw/device/benchmarks/coremark/coremark_top_earlgrey': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
   - /workspace/mnt/repo_top/sw/device/benchmarks/coremark/coremark_top_earlgrey
  WARNING: Target pattern parsing failed.
  ERROR: no such package 'sw/device/benchmarks/coremark/coremark_top_earlgrey': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
   - /workspace/mnt/repo_top/sw/device/benchmarks/coremark/coremark_top_earlgrey
  INFO: Elapsed time: 19.608s
  INFO: 0 processes.
  FAILED: Build did NOT complete successfully (0 packages loaded)
  FAILED: Build did NOT complete successfully (0 packages loaded)
  make: *** [/workspace/mnt/repo_top/hw/dv/tools/dvsim/sim.mk:73: sw_build] Error 1

Steps to Reproduce
Observed in all nightlies since at least 12 August.
cab5ffb90
Build seed<PHONE_NUMBER>, VCS
Tests with similar or related failures
NA

This actually has not worked since the meson-->bazel transition (see #12504).
cc: @arunthomas

Also, see #12671

Given that this item is being worked on by @arunthomas / @cfrantz but has not been touched for some time we will unassign from @engdoreis. @timothytrippel if you want to leave this assigned to someone from your side please mark accordingly but otherwise we will observe/track for now.

SG, reassigning to myself / @arunthomas for now.

Bazel build support for CoreMark was merged yesterday. @timothytrippel  will be working on adding CoreMark to the nightly regressions.

actually, do we think it's important to have this as a v2 test?
This doesn't really check for anything specific functional changes..
in theory we would use this to know our architecture is too slow and requires big changes, but we are far beyond that point now.

Agreed with @tjaychen , but since this took literally 30s to fix, I fixed it hehe (in #16091). Sorry for the delay.

even better hehe.

I'm reopening this due to the failured in the latest regression and I'll close it when it pass in 3 consecutive regressions.

@timothytrippel : just highlighting that this has been reopened.
It looks like it was just a timeout issue.
Not sure how long coremark will need to run but the default timeout may need to be upped. @engdoreis - possible to replicate on local system and see how long the task takes and then set timeout accordingly?
Job chip_earlgrey_asic-sim-vcs_run_default killed due to: Exit reason: User job exceeded runlimit: User job timed out has 6 failures:

Test chip_sw_coremark has 3 failures.
0.chip_sw_coremark.3709997532
Log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/0.chip_sw_coremark/latest/run.log

  Job ID: smart:81bccfa8-4935-40f9-8af6-3fd285e3976b

@timothytrippel This test still fails with this error. Can you take another look?

0.chip_sw_coremark.1083389417
Line 486, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/0.chip_sw_coremark/latest/run.log

UVM_ERROR @ 22018.182637 us: (chip_sw_base_vseq.sv:237) uvm_test_top.env.virtual_sequencer [uvm_test_top.env.virtual_sequencer.chip_sw_base_vseq] SW TEST TIMED OUT. STATE: SwTestStatusInTest, TIMEOUT = 22000000 ns

i'm honestly not sure this test can finish in a reasonable DV window... haha.
I hope the test hasn't locked up or something...

The timeout was upped to 3hrs according to the PR that @timothytrippel set. This seems a very long time for coremark to need to run. Might be worth trying this in a local environment and check that there are no settings that are causing this to run an infinite amount of times and waiting for user input etc.

#16623 should finally resolve this. Confirmed locally on my workstation.

It's passing on the Regression.

@GregAC are you looking into this? If so can I assign it to you?

@moidx - I think this was merged in by @timothytrippel so may already be resolved?

I recently ran the test locally, the output is as follows:
UVM_INFO @ 2294.065684 us: (sw_logger_if.sv:524) [test_rom_sim_dv(sw/device/lib/testing/test_framework/status.c:40)] test_status_set to 0xb090
UVM_INFO @ 2294.335684 us: (sw_test_status_if.sv:61) [tb.u_sim_sram.u_sim_sram_if.u_sw_test_status_if] SW test transitioned to SwTestStatusInBootRom.
UVM_INFO @ 2455.445684 us: (sw_logger_if.sv:524) [test_rom_sim_dv(sw/device/lib/testing/test_rom/test_rom.c:158)] kChipInfo: scm_revision=54697461
UVM_INFO @ 2461.585684 us: (sw_logger_if.sv:524) [test_rom_sim_dv(sw/device/lib/testing/test_rom/test_rom.c:230)] Test ROM complete, jumping to flash (addr: 20000480)!
UVM_INFO @ 2467.745684 us: (sw_logger_if.sv:524) [coremark_test_sim_dv(w/device/lib/testing/test_framework/status.c:40)] test_status_set to 0x4354
UVM_INFO @ 2467.975684 us: (sw_test_status_if.sv:61) [tb.u_sim_sram.u_sim_sram_if.u_sw_test_status_if] SW test transitioned to SwTestStatusInTest.
UVM_INFO @ 2467.975684 us: (chip_sw_uart_tx_vseq.sv:10) uvm_test_top.env.virtual_sequencer [uvm_test_top.env.virtual_sequencer.chip_sw_uart_tx_vseq] Configuring and connecting UART agent to UART 0 ...
UVM_INFO @ 65126.905525 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] 2K performance run parameters for coremark.
UVM_INFO @ 65385.930613 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] CoreMark Size    : 666
UVM_INFO @ 65687.911285 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] Total ticks      : 6193300
UVM_INFO @ 65934.895477 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] Total time (secs): 12
UVM_INFO @ 66167.880565 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] Iterations/Sec   : 1
UVM_INFO @ 66414.864757 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] Iterations       : 12
UVM_INFO @ 67857.772405 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] Compiler version : GCClowRISC Clang 16.0.2 (https://github.com/lowRISC/llvm-project.git d213f6b2e0bcc561930538ef47b3b5cc900b5b17)
UVM_INFO @ 68533.770805 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] Compiler flags   : Please put compiler flags here (e.g. -o3)
UVM_INFO @ 68811.753013 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] Memory location  : STACK
UVM_INFO @ 69104.734261 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] seedcrc          : 0xe9f5
UVM_INFO @ 69397.715509 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] [0]crclist       : 0xe714
UVM_INFO @ 69692.696629 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] [0]crcmatrix     : 0x1fd7
UVM_INFO @ 69986.677813 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] [0]crcstate      : 0x8e3a
UVM_INFO @ 70279.659061 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] [0]crcfinal      : 0x755b
UVM_INFO @ 71077.649653 us: (uart_logger.sv:90) uvm_test_top.env.m_uart_agent0.m_logger [uvm_test_top.env.m_uart_agent0.m_logger] Correct operation validated. See README.md for run and reporting rules.
UVM_INFO @ 71078.605684 us: (sw_logger_if.sv:524) [coremark_test_sim_dv(w/device/lib/testing/test_framework/status.c:28)] PASS!
UVM_INFO @ 71078.865684 us: (sw_test_status_if.sv:61) [tb.u_sim_sram.u_sim_sram_if.u_sw_test_status_if] SW test transitioned to SwTestStatusPassed.
UVM_INFO @ 71078.865684 us: (sw_test_status_if.sv:82) [tb.u_sim_sram.u_sim_sram_if.u_sw_test_status_if] ==== SW TEST PASSED ====
UVM_INFO @ 71078.865684 us: (chip_sw_base_vseq.sv:302) uvm_test_top.env.virtual_sequencer [uvm_test_top.env.virtual_sequencer.chip_sw_uart_tx_vseq] SW TEST PASSED!

@GregAC , can you check if these numbers make sense?

I think the test failures are due to the test timing out. The last passing test in the nightlies (June 28) took more than 3.5 hours where as the timeout occurs at 4 hours currently. I can file a PR to further increase the timeout?

@vogelpi to please reduce iterations so that it fits the timeout and calculate CoreMark per MHz

I did some more digging. The current CoreMark/MHz is ~1.93 which is inline with what Greg reported in May 2023.
We should not lower the number of iterations because CoreMark expects to run for at least 10 seconds and reports an error otherwise. What we can do though is increasing the timeout a bit (we recently increased the number of iterations targeting FPGA and silicon but forgot to increase the DV timeout). I'll take care of this and also reduce the number of seeds for this test. Because it's pretty deterministic anyway.

The PR fixing this issue is here: #23922.


Parameter for all fonts split by family and style?

I want users to be able to run a spec-checker on an entire directory which may contain several styles of an entire family, e.g. Sans and Serif with their Display variants in uprights and italics. Some checks are only meaningful if they look at a specific family and style -- e.g. italics may have a few more glyphs, so a glyph set checker needs to check it seperately from the uprights.
I currently take all fonts and split them into families and styles in the test, which also means that the test and yields have to more verbose so people see what family is being complained about, the test is skipped if there's just one family/style passed in, etc. Is there a more elegant way, e.g. def check_something(ufo_fonts_by_family_and_style) where the checkrunner splits the fonts beforehand and then invokes the test with each set?

No, not yet. I was thinking about/started experimenting with this kind of thing, but I didn't finish it. I guess it was tricky to do ;-) I'll give it another round it's an interesting problem.

Oh, of course. But didn't you mean (I was thinking about/I'd like) to get rid if the for fonts, family in fonts_by_family_and_style within the check and let that be done by dependency injection, calling the check repeatedly for each item in fonts_by_family_and_style
@condition
def ttFonts_split_by_family_and_style(ttFonts):
    return [(fonts, family), (fonts, family), (fonts, family)), ...]

# some configuration to make ttFonts_split_by_family_and_style an iterarg
# "ttFonts_by_family_and_style"

def check_something(ttFonts_by_family_and_style):
 """something"""
    from damacheck.util import fonts_by_family_and_style_check

    fonts, family = ttFonts_by_family_and_style

    if len(fonts) == 1:
            yield SKIP, f"Only one font in family ({[font.path for font in fonts]}), skipping check."
            continue

Yes, but this might work in the interim.


API Execute Task Not Outputing Log

Hello, I have a app that I use for some time (developed by me) that uses the api execute task endpoint! Until my last update, that I jumped from 2.21.35 to the latest 3.1.32 (I was holding back because of the python version), the execution returned the log, with the log output of the task execution, that I was parsing and returning some useful information to me. Now, I dont get that log, I execute the task with:
{
  "tasks": [
    "GetMoviesSearchCheck"
  ],
  "progress": true,
  "summary": true,
  "entry_dump": true,
  "inject": [
    {
      "title": "The Matrix (1999)",
      "url": "https://www.imdb.com/title/tt0133093/",
      "accept": true,
      "fields": {"imdb_id":"tt0133093"}
    }
  ],
  "loglevel": "trace",
  "no_cache": true,
  "now": true
}

But this does not returns the log! I what the log output to capture the REJECT and ACCEPT sentence and capture the resons.
Was this broken in the latest versions?
Thank You

works for me. Can you show the exact call and response you do?

Thank You

If I try the same task with payload:
{
  "tasks": [
    "GetMoviesSearchCheck"
  ],
  "progress": false,
  "summary": false,
  "entry_dump": true,
  "inject": [
    {
      "title": "The Matrix (1999)",
      "url": "https://www.imdb.com/title/tt0133093/",
      "accept": true,
      "fields": {"imdb_id":"tt0133093"}
    }
  ],
  "loglevel": "trace",
  "no_cache": true,
  "now": true
}

The output that I get is:
{"stream": [{"tasks": [{"id": "961570", "name": "GetMoviesSearchCheck"}]},
{"entry_dump": [], "task_id": "961570"},
{}]}

I don't get anything in the entry_dump and I don't get nothing in the log (that before was working)
Thank you

I also tried with loglevel debug, and nothing. I tried several combinations and no success. I never get the output of the "log:".
Thank You

Any idea @liiight ?
Thank You

Hello @liiight any news on this? Can I help with anything?
Thank You

Haven't taken a look yet, sorry. I will do it shortly

No need to say sorry, thank you for the help

ok, I think I see this now.
@gazpachoking, I think changes to capture_logs broke attaching the logs in the API response

Anything I can do to help out?
Thank you

@soloam I don't think so, but thanks

Hmm. I thought I gave this a test and it was working. Does it only happen under certain circumstances?

Not sure,  I wasnt able to get it working. I haven't really dug in though, i guess the first thing to try is using the api with old style, sans the decorator

Hmm. I thought I gave this a test and it was working. Does it only happen under certain circumstances?

Did it worked for you? I was never able to make it work, I tried it with several combinations on the input! None returned the log!

I remember I noticed it was erroring out after the loguru change and made this change #2575 but i was pretty sure it was working after i made that change. I can't recall if any logs actually started showing up after i made that change or if i just prevented it from throwing an exception.

Hello, any news regarding this? Where you able to replicate it?
Thank You


Erroneous warning "The Include operation for navigation was ignored"

Steps to reproduce
Attached is ConsoleApp2.zip which demonstrates the issue.
The issue
When running the following code, the warning "The Include operation for navigation: 'c.State' was ignored because the target navigation is not reachable in the final query results." is shown, but it makes no sense as the navigation is performed and the referenced field is included in the results.
var customers = ctx.Customers.Include(c => c.State).Select(c => new { c.CustomerName, c.State.StateName }).ToList();
Below is the debugging output:
dbug: ConsoleApp2.Program[0]
      Starting application
dbug: Microsoft.EntityFrameworkCore.Query.RelationalQueryCompilationContextFactory[2]
      Compiling query model: 'from Customers c in {value(Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable`1[ConsoleApp2.Models.Customers]) => Include([c].State)} select new <>f__AnonymousType0`2(CustomerName = [c].CustomerName, StateName = [c].State.StateName)'
dbug: Microsoft.EntityFrameworkCore.Query.RelationalQueryCompilationContextFactory[3]
      Optimized query model: 'from Customers c in value(Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable`1[ConsoleApp2.Models.Customers]) join States c.State in value(Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable`1[ConsoleApp2.Models.States]) on IIF(([c] != null), Property([c], "StateId"), null) equals Convert(Property([c.State], "StateId")) into IEnumerable`1 c.State_group from States c.State in {[c.State_group] => DefaultIfEmpty()} select new <>f__AnonymousType0`2(CustomerName = [c].CustomerName, StateName = IIF(([c.State] != null), [c.State].StateName, null))'
warn: Microsoft.EntityFrameworkCore.Query.RelationalQueryCompilationContextFactory[8]
      The LINQ expression 'DefaultIfEmpty()' could not be translated and will be evaluated locally. To configure this warning use the DbContextOptionsBuilder.ConfigureWarnings API (event id 'RelationalEventId.QueryClientEvaluationWarning'). ConfigureWarnings can be used when overriding the DbContext.OnConfiguring method or using AddDbContext on the application service provider.
warn: Microsoft.EntityFrameworkCore.Query.RelationalQueryCompilationContextFactory[8]
      The LINQ expression 'DefaultIfEmpty()' could not be translated and will be evaluated locally. To configure this warning use the DbContextOptionsBuilder.ConfigureWarnings API (event id 'RelationalEventId.QueryClientEvaluationWarning'). ConfigureWarnings can be used when overriding the DbContext.OnConfiguring method or using AddDbContext on the application service provider.
warn: Microsoft.EntityFrameworkCore.Query.RelationalQueryCompilationContextFactory[8]
      The LINQ expression 'from States c.State in {[c.State_group] => DefaultIfEmpty()}' could not be translated and will be evaluated locally. To configure this warning use the DbContextOptionsBuilder.ConfigureWarnings API (event id 'RelationalEventId.QueryClientEvaluationWarning'). ConfigureWarnings can be used when overriding the DbContext.OnConfiguring method or using AddDbContext on the application service provider.
warn: Microsoft.EntityFrameworkCore.Query.RelationalQueryCompilationContextFactory[6]
      The Include operation for navigation: 'c.State' was ignored because the target navigation is not reachable in the final query results. To configure this warning use the DbContextOptionsBuilder.ConfigureWarnings API (event id 'CoreEventId.IncludeIgnoredWarning'). ConfigureWarnings can be used when overriding the DbContext.OnConfiguring method or using AddDbContext on the application service provider.
dbug: Microsoft.EntityFrameworkCore.Query.RelationalQueryCompilationContextFactory[5]
      TRACKED: False
      (QueryContext queryContext) => IEnumerable<<>f__AnonymousType0<string, string>> _Select(
          source: IEnumerable<TransparentIdentifier<TransparentIdentifier<Customers, IEnumerable<States>>, States>> _SelectMany(
              source: IEnumerable<TransparentIdentifier<Customers, IEnumerable<States>>> _GroupJoin(
                  queryContext: (RelationalQueryContext) queryContext,
                  source: IEnumerable<ValueBuffer> _Query(
                      queryContext: queryContext,
                      shaperCommandContext: SelectExpression:
                          SELECT "c"."CustomerId", "c"."CustomerName", "c"."StateId", "c.State"."StateId", "c.State"."Abbreviation", "c.State"."StateName"
                          FROM "Customers" AS "c"
                          LEFT JOIN "States" AS "c.State" ON "c"."StateId" = "c.State"."StateId"
                          ORDER BY "c"."StateId"
                      ,
                      queryIndex: default(System.Nullable`1[System.Int32])
                  )
                  ,
                  outerShaper: BufferedEntityShaper<Customers>,
                  innerShaper: BufferedOffsetEntityShaper<States>,
                  innerKeySelector: (States c.State) => (Nullable<long>) long GetValue(
                      queryContext: queryContext,
                      entity: c.State,
                      property: StateId
                  )
                  ,
                  resultSelector: (Customers c | IEnumerable<States> c.State_group) => TransparentIdentifier<Customers, IEnumerable<States>> CreateTransparentIdentifier(
                      outer: c,
                      inner: c.State_group
                  )
                  ,
                  outerGroupJoinInclude: default(Internal.GroupJoinInclude),
                  innerGroupJoinInclude: default(Internal.GroupJoinInclude)
              )
              ,
              collectionSelector: (TransparentIdentifier<Customers, IEnumerable<States>> t0) => IEnumerable<States> DefaultIfEmpty(
                  source: t0.Inner
              )
              ,
              resultSelector: (TransparentIdentifier<Customers, IEnumerable<States>> t0 | States c.State) => TransparentIdentifier<TransparentIdentifier<Customers, IEnumerable<States>>, States> CreateTransparentIdentifier(
                  outer: t0,
                  inner: c.State
              )
          )
          ,
          selector: (TransparentIdentifier<TransparentIdentifier<Customers, IEnumerable<States>>, States> t1) => new <>f__AnonymousType0<string, string>(
              t1.Outer.Outer.CustomerName,
              t1.Inner != null ? t1.Inner.StateName : null
          )
      )

dbug: Microsoft.EntityFrameworkCore.Storage.Internal.SqliteRelationalConnection[3]
      Opening connection to database 'main' on server '..\..\..\test.s3db'.
info: Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommandBuilderFactory[1]
      Executed DbCommand (2ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
      PRAGMA foreign_keys=ON;
info: Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommandBuilderFactory[1]
      Executed DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT "c"."CustomerId", "c"."CustomerName", "c"."StateId", "c.State"."StateId", "c.State"."Abbreviation", "c.State"."StateName"
      FROM "Customers" AS "c"
      LEFT JOIN "States" AS "c.State" ON "c"."StateId" = "c.State"."StateId"
      ORDER BY "c"."StateId"
dbug: Microsoft.EntityFrameworkCore.Storage.Internal.SqliteRelationalConnection[4]
      Closing connection to database 'main' on server 'C:\Projects\ConsoleApp2\test.s3db'.

Further technical details
EF Core version: 1.0
Operating system: Windows 10
Visual Studio version: VS 2015

@mguinness You only need to use Include() when the query returns entities and you want an additional navigation to be traversed and populated. E.g. for your model, the Include() in this query brings states into memory alongside the customers:
var customersWithState = ctx.Customers.Include(c => c.State).Select(c => c).ToList();

Or for short:
var customersWithState = ctx.Customers.Include(c => c.State).ToList();

In your query you are explicitly projecting individual scalar properties c.CustomerName and c.State.StateName and neither state nor customer entities will be loaded into memory. Hence the call to Include() is superfluous.

I am going to leave this bug open however because there are a few strange things in the query plan. I want to make sure this is a query we have optimized further in 1.1.

SQL output for 1.1 is as follows (whit or without the call to Include()):
SELECT "c"."CustomerId", "c"."CustomerName", "c"."StateId", "c.State"."StateId", "c.State"."Abbreviation", "c.State"."StateName"
FROM "Customers" AS "c"
LEFT JOIN "States" AS "c.State" ON "c"."StateId" = "c.State"."StateId"
ORDER BY "c"."StateId"

@divega Thanks for explaining, that helps my understanding.  It appears that I wasn't the only one caught out regarding this (see issue https://github.com/aspnet/EntityFramework/issues/7144).  Maybe a minor text change to the warning would help?

The Include operation for navigation: 'c.State' is unnecessary and
was ignored because the target navigation is not reachable in the final query results.

Split off a new issue to improve the docs - https://github.com/aspnet/EntityFramework/issues/7162

@divega I did try removing the Include() when running the following query, but ran into another issue:
var customersWithState = ctx.Customers.Where(c => c.State.Abbreviation == "WA").ToList();
SELECT "c"."CustomerId", "c"."CustomerName", "c"."StateId", "c.State"."StateId", "c.State"."Abbreviation", "c.State"."StateName"
FROM "Customers" AS "c"
LEFT JOIN "States" AS "c.State" ON "c"."StateId" = "c.State"."StateId"
ORDER BY "c"."StateId"

Got warning The LINQ expression '(IIF(([c.State] != null), [c.State].Abbreviation, null) == "WA")' could not be translated and will be evaluated locally.
I would have expected the following SQL, do I need to compose the query differently?
SELECT "c"."CustomerId", "c"."CustomerName", "c"."StateId", "c.State"."StateId", "c.State"."Abbreviation", "c.State"."StateName"
FROM "Customers" AS "c"
LEFT JOIN "States" AS "c.State" ON "c"."StateId" = "c.State"."StateId"
WHERE "c.State"."Abbreviation" = 'WA'
ORDER BY "c"."StateId"

@kgKevGomez - I ran above query and did not get any warning that include was ignored. Please file a new issue with repro code showing the issue you are seeing.


ci: Change the linked board for new issues

Description
Upgrade the board id to assign when a new issue is created.

Won't be merged!


Traverse up test node hierarchy

I find myself sometimes wanting to traverse up the hierarchy of TestSuiteInfo and TestInfo nodes. I could make subinterfaces with a new parentId property, but before doing so I was curious if you think it would be generally useful to accommodate this however you see best.

Hello,
I was doing the same. Actually I was storing the parent itself as a reference.
It worked well.

If I needed this in my adapter, I would also save a reference to the parent in the child. But if you do this, the test tree can't be serialized with JSON.stringify() anymore (due to circular references parent -> child -> parent), so you need to do this in a copy of the test tree. That's why I don't add this to the API, the test tree sent to the Test Explorer cannot contain those parent references.


Problem with getting slider's length

The slider doesn't behave correctly when it's contained in an element that expands on some user action. By "expands" I mean a transition that involves transform: scale(...) CSS property.
This issue is a bit similar to this: https://github.com/mpowaga/react-slider/issues/15 because the root cause of the issue is that the size in component's state is not up to date.

Experiencing the same problem. My slider is inside a transformed div (transform: translateX(-100%)). Clicking the slider sets the handler to the wrong position. I think that the position calculation of clicks is incorrect because of transform.


update styles for combo inputs 2250

https://github.com/rancher/dashboard/issues/2250

@lvuch Looks good to me - I don't think the var --input-border-accent that is added in this PR is used - so this could be removed.


Show sub-directory name in logs when running on multiple directories at once

Describe the solution you'd like
If I run terragrunt run-all within the directory with sub-directories (layers), terragrunt show logs all together and it's hard to understand which layer a particular log belongs to. For example, I have 10 sub-directories, run terragrunt run-all plan, and only one directory shows some diff, there are no ways to understand which directory actually has some drift (well, I can see the list of resources and their names in the plan output, but that's not a very convenient way to determine which directory is drifted).
I'd like to have some option to show directory names for each log entry generated by terragrunt.
I was not able to find any options to show me logs in the way I need, thus I created this feature request
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi,
was attempted to use --terragrunt-include-module-prefix?
https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-include-module-prefix

Hi, was attempted to use --terragrunt-include-module-prefix?
https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-include-module-prefix

Hi, did not see this option for some reason...
Yeah, it did the trick but now output is kind of a mess, EACH line is prepended with the full path to the directory, even each plan line. Any chances to get it grouped? I mean, for example, show the directory path only for the first line of the plan output.


Investigate using github actions instead of Jenkins pipelines.

[x] We currently have a security concern over whether users could run arbitrary code/exfiltrate secrets from our github pipeline if they were to create a PR.

We likely either need to:

Ensure that external users cannot create PRs (to avoid exfiltrating secrets)
Or: ensure the deployment secrets (e.g. API keys to publishing to PMD, etc.) can be effectively isolated and inaccessible to PRs created by external users.

Someone else will likely have already solved this problem somewhere on the internet, so that would be a good starting point for this ticket.
We should make sure to apply whatever restrictions we decide on in this ticket to all repositories in the GSS-Cogs organisation.

[x] More thorough think about our github repos and making sure there’s no other way we could accidentally end up letting users waste our resources and letting them exfiltrate secrets.

[x] Identify whether there is an equivalent for presenting unit and behave test results in a meaningful way like in Jenkins.

[x] Identify any rate limits.

N.B. this almost certainly needs discussion with the wider team in the architectural meeting/the monthly (?) tech board before progressing.

@robons , @canwaf , @mikeAdamss Below is what I propose for when it comes to using Github Actions instead of Jenkins.

With Github Actions we can set up a CI/CD pipeline that does all the things our current pipeline does. To prove this, I did a small PoC which builds a python module and deploy to PyPI using GitHub Actions - see https://github.com/GDonRanasinghe/git-actions-poc.

In order for the pipeline to deploy to PyPI, we first create the PyPI project-scoped API Key. Then add this as a workflow secret to the git repo (see https://github.com/Azure/actions-workflow-samples/blob/master/assets/create-secrets-for-GitHub-workflows.md). Finally, the pipeline's deploy stage will use this secret to deploy.

Note: as shown below, when using the API key to deploy, PyPI wants us to use token  as the username (see https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/). Otherwise the authentication will default to the user-based authentication and the deployment will fail.
name: Publish distribution to Test PyPI
        uses: pypa/gh-action-pypi-publish@master
        with:
          username: __token__
          password: ${{ secrets.test_pypi_password }} <-- test_pypi_password is the name of the github secret containing the pypi api key.
          repository_url: https://test.pypi.org/legacy/

GitHub Actions allow triggering pipelines on various events and covers all the events provided by Jenkins (see https://docs.github.com/en/actions/using-workflows/triggering-a-workflow and https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows). For us, below events would be sufficient.
However, I suggest we stop running verification checks when a new branch is created because this is redundant - we are doing all the verification checks on creating a PR and on PR merge. What are your thoughts on this?
on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main
  create:
    branches:
      - "*"

I've also investigated what impact the use of Github Actions has on security and the use of our resources by non-collaborators (i.e. external users/public).

The default moderation settings in Github (see attached 1st image) do not allow external users to push to the repos.

If an external user wants to submit a PR, they can do so by forking our repo and submitting a PR from the forked repo to ours.

When that PR is submitted, Github asks the moderator of the repo (i.e. us) to approve the running of the GitHub Actions workflow triggered by the PR. So this means, we can allow external users to fork and create PRs whilst not allowing them to use our resources without our approval (see the attached 2nd screenshot).

But there is a caveat to the above:

Once we approve an external user's first request for running a GitHub Actions workflow and merged his PR, this external user will become a collaborator of the repo. Because this user is now a collaborator, the subsequent PRs this user is going to submit will NOT need our approval for running the workflows. Therefore, the subsequent PRs from this user is going to use our resources.

Above caveat could lead to secret exfiltration as well: if the external users try to print the secrets to the workflow logs which they can view via github.com, GitHub automatically redacts them (see https://docs.github.com/en/actions/security-guides/encrypted-secrets#accessing-your-secrets).  But there could be other means for exfiltrating (e.g. sending the secret to a web api during the github action workflow).

I've also checked in the internet for any suggestions on how to resolve this caveat. But I did not find any. Maybe another one of us should check as well?

I've also had a brief look at the Deploy Keys feature provided by GitHub. It looks like this is will not suit us due to its cons (see https://docs.github.com/en/developers/overview/managing-deploy-keys#deploy-keys).
Whats Next?
So from what I can see, GitHub Actions is a nice replacement for Jenkins but there is the above caveat. Maybe we have some sort of an internal process that verifies new collaborators to our repo? If so, will this process make the above caveat a non-issue for us?
What do you guys think about the next steps on this? As mentioned in the ticket, the changes we are going to decide here will affect all the repos in GSS-Cogs org. So my recommendation would be to present our findings to the wider team and get their opinion. Also, we might be able to find a resolution to the above caveat.

Discussed above with @robons . As per the next immediate step, I am going to check whether Env secrets can be utilised to address the caveat above.

Quick update on the above: GitHub provides a setting for making the approval for running workflows mandatory for all the PRs submitted by external users regardless they are first-time users of not.  So every time an external user creates a PR, it asks us to approve the running of workflow. When approving we need to make sure that we review the code for any exfiltrating of secrets, and whether the PR is worth for using our resources. This is the solution to the above caveat I've mentioned.

Presenting test results:
Github Actions does not provide this feature out of the box but we can use a free action from the GitHub Actions Marketplace: https://github.com/marketplace/actions/publish-unit-test-results

@robons Given the below note in the ticket description, what do you think is the next best step or the output for this ticket?

N.B. this almost certainly needs discussion with the wider team in the architectural meeting/the monthly (?) tech board before progressing.

Since our jobs will run independent on reviewer approval, we will not be impacted by this. If the self-hosted runner needs an explicit approval for running a queued job (I believe not), we should be able to adjust this on the runner end (e.g. GCP).

Say someone created a fork and created a PR to fix a bug, given that we will have restricted actions so they only run on approval for these kind of PRs, will we have to do anything to reschedule the github action?

Given the below note in the ticket description, what do you think is the next best step or the output for this ticket?

I've linked the https://github.com/GSS-Cogs/csvcubed-pmd/issues/1 issue to this ticket and I think it's a good next step we can take in the investigation of this topic.

N.B. this almost certainly needs discussion with the wider team in the architectural meeting/the monthly (?) tech board before progressing.

Yes, before we end up going too deep into this, could you bring this all together and do a short 5-10 min presentation to the next architecture meeting (perhaps not today's but next week's?) so we can just report our findings to the rest of the team.
I think it'd be worth at that point recommending that we set up a GCP github action runner (explaining why we want to do this rather than just relying on the free ones) so we can get a bit of buy-in before we do that part of the work.

Thanks for the detailed work you've done here, it's certainly helped clarify in my mind the security concerns we had about secret exfiltration and automatic builds on our local runners. I imagine these parts will feed into some later documentation on things to watch our for in external fork PR reviews.

@robons Thanks for the feedback, I will make sure to action on those next steps.

Yes, before we end up going too deep into this, could you bring this all together and do a short 5-10 min presentation to the next architecture meeting (perhaps not today's but next week's?) so we can just report our findings to the rest of the team.

Sure, I will get a presentation ready and will present at the next architecture meeting.

@robons I've changed the estimate on this to 13 as I have added some new tasks to this ticket that were not in here when the original estimate was done. I think 13 is a true reflection of the effort involved in this ticket.

@robons , @mikeAdamss I've got a response from GitHub for my question on API calls limits when using GitHub Actions. As we expected, this limit refers to the calls made to GitHub REST API (see below).
Paul (GitHub Support)
May 19, 2022, 11:11 AM UTC

Hi Gishan,
Thank you for writing to GitHub Enterprise Support.
Apologies for taking a while to get back to you.
That rate limit applies when you are using the GITHUB_TOKEN available in the workflow run to make API calls to GitHub's APIs (REST or GraphQL). You can make as many API calls as you need to other external APIs.
Let me know if you have any further questions.
Regards,
Paul
GitHub Support

The slides are attached.
[https://app.zenhub.com/files/374709947/a08f5714-5820-4622-8f3b-cd2ad348f0dc/download]
(https://app.zenhub.com/files/374709947/a08f5714-5820-4622-8f3b-cd2ad348f0dc/download)

Guide for migrating from Jenkins to GitHub Actions: https://docs.github.com/en/actions/migrating-to-github-actions/migrating-from-jenkins-to-github-actions


ci: merge staging to master

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

Pipeline Attempt on 914224240 for f883d5202659b1e4c4723cff9d16ecb2e2c824f5
https://gitlab.com/MatrixAI/open-source/js-resources/-/pipelines/914224240

Pipeline Succeeded on 914224240 for f883d5202659b1e4c4723cff9d16ecb2e2c824f5
https://gitlab.com/MatrixAI/open-source/js-resources/-/pipelines/914224240


fix: dtmgrpc relevant golangci lint error

Codecov Report

Merging #169 (714bc80) into main (2a06379) will decrease coverage by 0.09%.
The diff coverage is 33.33%.

:exclamation: Current head 714bc80 differs from pull request most recent head 08f7c7b. Consider uploading reports for the commit 08f7c7b to get more accurate results

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   96.75%   96.66%   -0.10%
==========================================
  Files          44       44
  Lines        2158     2159       +1
==========================================
- Hits         2088     2087       -1
- Misses         38       39       +1
- Partials       32       33       +1

Impacted Files
Coverage Δ

dtmgrpc/tcc.go
95.55% <0.00%> (-4.45%)
:arrow_down:

dtmgrpc/type.go
100.00% <ø> (ø)

dtmgrpc/dtmgimp/grpc_clients.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a06379...08f7c7b. Read the comment docs.


NAT Gateway not creating

Using terraform to create nat-gateway using this module.
https://registry.terraform.io/modules/GoogleCloudPlatform/nat-gateway/google/1.1.3
using this code :
module "nat" {
        source                  = "GoogleCloudPlatform/nat-gateway/google"
        region                  = "${var.gcloud-region}"
        network                 = "${google_compute_network.vpc-network.name}"
        subnetwork              = "${google_compute_subnetwork.vpc-subnetwork-public.name}"
        machine_type    = "${var.vm-type-nat-gateway}"
}

Other snippets :
variable "gcloud-region"                        { default = "europe-west1" }
variable "vm-type-nat-gateway"                  { default = "n1-standard-2"}

resource "google_compute_network" "vpc-network" {
    name                        = "foobar-vpc-network"
    auto_create_subnetworks     = false
}

resource "google_compute_subnetwork" "vpc-subnetwork-public" {
    name                        = "foobar-vpc-subnetwork-public"
    ip_cidr_range               = "<IP_ADDRESS>/24"
    network                     = "${google_compute_network.vpc-network.self_link}"
    region                      = "${var.gcloud-region}"
    private_ip_google_access    = false
}

================

module.nat.google_compute_route.nat-gateway: 1 error(s) occurred:

module.nat.google_compute_route.nat-gateway: element: element() may not be used with an empty list in:

${element(split("/", element(module.nat-gateway.instances[0], 0)),
10)}

Above errror coming up and whole terraform script get stop , and unable to run
terraform apply or terraform destroy at any changes,
any possible issue causing this ?

Hi,
Assume I don't want to have any code level change in my terraform script ?
and just doing terraform init will work ?
I managed to run this once but again receiving same kind of error .
* module.nat.google_compute_route.nat-gateway: element: element() may not be used with an empty list in:

${element(split("/", element(module.nat-gateway.instances[0], 0)), 10)}
* module.nat.output.instance: element: element() may not be used with an empty list in:

${element(module.nat-gateway.instances[0], 0)}

Terraform version 11.7, and provider version 1.16. Nothing special happening with our use of the module - the code is as you would expect:
resource "google_compute_subnetwork" "nat_subnet" {
  name          = "nat-subnet"
  ip_cidr_range = "<IP_ADDRESS>/24"
  project       = "${google_project.host_project.project_id}"
  region        = "${var.region}"
  network       = "${google_compute_network.shared_network.self_link}"
}

module "nat" {
  source     = "GoogleCloudPlatform/nat-gateway/google"
  region      = "${var.region}"
  network     = "${var.project_id}-vpc"
  subnetwork  = "${google_compute_subnetwork.nat_subnet.name}"
  project     = "${google_project.host_project.project_id}"
}

AFAICT the issue stemmed from a timeout when the MIG was creating, which left the terraform in an unrecoverable state with the error I pasted above.
I recovered with some manual intervention and judicious application of terraform state rm.


Fix gitignore to avoid ignoring some necessary files

Currently, .gitignore includes docs/source/reference/util/*.rst as files to be ignored.

LGTM

jenkins, test this please

Jenkins CI test (for commit 39a11e5ed4b036426e5fd5deeee677790a779711, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins CI test (for commit 39a11e5ed4b036426e5fd5deeee677790a779711, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)


fix issue where getrawtransaction RPC call does not work

This happens when a block is orphaned, the coinbase and coinstake transactions cannot be fetched with getrawtransaction.

can you guys help me in setting up server for quark pow algo with pos.?