Improve Material selection controls

These controls now have proper radial reactions.
You can drag the switch.
The radio button animates properly.
There's a demo in the Material Gallery

@Hixie This patch makes the selection controls pretty good.  One issue I ran into is that for Switch, the tap gesture and the drag gesture are fighting each other, which means the drag is a little "sticky" when you start dragging it.  The way the UX is designed, there isn't any ambiguity in what to draw, but the gesture recognizers don't know that.

@HansMuller

LGTM, though I was flagging a bit near the end of that patch.
Should these get converted to Material-layer ink splashes, or are they like slider splashes?

Should these get converted to Material-layer ink splashes, or are they like slider splashes?

They're like the slider splashes.  The one for the switch moves with the thumb of the switch and is above the track.  The one for the radio button starts with the radius of the button.  We could move the checkbox one, but it seems better to have them be consistent.  I'm going to see if I can share some splash code between RenderToggleable and RenderSlider.

sounds good
On Thu, Nov 26, 2015, 10:36 Adam Barth<EMAIL_ADDRESS>wrote:

Should these get converted to Material-layer ink splashes, or are they
like slider splashes?
They're like the slider splashes. The one for the switch moves with the
thumb of the switch and is above the track. The one for the radio button
starts with the radius of the button. We could move the checkbox one, but
it seems better to have them be consistent. I'm going to see if I can share
some splash code between RenderToggleable and RenderSlider.
—
Reply to this email directly or view it on GitHub
https://github.com/flutter/flutter/pull/600#issuecomment-159973830.


I generated the component and then downloaded the code seems to be missing css causing the component to not work, is there something wrong with my configuration?

As title

The output code is displayed as above

what！！！1

The generated HTML uses tailwind, you need to render it in a page that has tailwind configured.  Here's an example layout for development environments.  I'm also linking to a similar issue which also mentions getting it to work in wordpress.
<!doctype html>
<html>
<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <script src="https://cdn.tailwindcss.com"></script>
</head>
<body>
  <!-- The Generated HTML should go here --->
</body>
</html>


My Game Gets Unpublished By Itself

I don't if this is normal but,my game gets unpublished after a day.I don't know if this is from the server or my scripts but,please fix this.I was trying to play with my friend.

would be nice if you could provide game link

After a day this game gets unpublished.
https://beta.modd.io/play/2Nn6ljukv

I think it's something with the scripts

if your game is empty for 10m it will get unpublished by itself

thats why its unpublishing
im closing this now :)


Support Latest Version of django-taggit (6.1+)

Is your proposal related to a problem?

Right now Wagtail requires django-taggit <5.1,>=5.0. The newer versions include performance fixes, explicit django 5 support and helpful tooling for merging, deduplicating and removing orphan tags.
Describe the solution you'd like

Update django-taggit version constraints at least to allow <7
Describe alternatives you've considered

N/A
Additional context

The newer versions do not list any breaking changes / backwards incompatibility in the changelog.
Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.

Already done for the next release in #12220.

Ah, sorry, missed the mention of 6.1 :-)


Support for custom API's for type inference

I use laminas-db (https://docs.laminas.dev/laminas-db/) wrapper, mostly with raw, dynamically assembled queries with different fetch modes, and it would be really cool if it was possible to infer result types for themn.
Here are some examples:
$db = MyDb::new($config); // MyDb is my wrapper adound laminas-db

// suppose table1 has columns column1, column2 (nullable), column3, column4

// should return for example
// @var $r list<array{column1: string, column2: string|null}>
$r = $db->fetchAll("
	SELECT column1, column2 FROM table1 WHERE column3 = :column3 AND column4 = :column4
	", ['column3' => 'some value 2','column4' => 'some value 2']);

// should return for example
// @var $r array<string, array{column1: string, column2: string|null, column3: string}>
$r = $db->fetchAssoc("
	SELECT column1, column2, column3 FROM table1 WHERE column3 = :column3 OR column4 = :column4
	", ['column3' => 'some value 2','column4' => 'some value 2']);

// should return for example
// @var $r array{column1: string, column2: string|null}
$r = $db->getRow("
	SELECT column1, column2 FROM table1 WHERE column3 = :column3 AND column4 = :column4
	", ['column3' => 'some value 2','column4' => 'some value 2']);

// should return for example
// @var $r array<string, string|null>
$r = $db->fetchPairs("
	SELECT column1, column2 FROM table1 WHERE column3 = :column3 AND column4 = :column4
	", ['column3' => 'some value 2','column4' => 'some value 2']);

These methods could be configured similarly to the query syntax analysis: https://github.com/staabm/phpstan-dba/blob/main/docs/rules.md
Ideally the return type would be an intersection with the existing method type inferred by phpstan. That type is correct but too wide.

I think db apis have subtle differences and therefore re-using a single extension is most of the time not possible.
but you could built your own PHPStan return type extension for your DBLayer, based on the API phpstan-dba provides you.
similar to https://github.com/staabm/phpstan-dba/blob/main/src/Extensions/DoctrineConnectionFetchDynamicReturnTypeExtension.php


Allow docusaurus to build concurrently

Only keep committed the documentations for the latest version of each major -- note that these versions will still exist on the deployed website, as the statically generated pages are stored in a Fastly KV Store
Future work would be to only have one version of the documentation and list on each page which version a feature/method/class was added/changed in -- I've got this partially done in a local branch, but wanted to ship something now to speed up our CI builds
Resolves #847

Amazing thank you for looking into this!


Added try/catch block when removing view from WindowManager

Codecov Report

Merging #11 into develop will decrease coverage by 0.28%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop      #11      +/-   ##
=============================================
- Coverage      43.44%   43.16%   -0.29%
  Complexity        54       54
=============================================
  Files              9        9
  Lines            458      461       +3
  Branches          43       43
=============================================
  Hits             199      199
- Misses           259      262       +3

Impacted Files
Coverage Δ
Complexity Δ

...in/java/kaufland/com/snackbarlibrary/Snackbar.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa0bf8...cac977f. Read the comment docs.


Notify community-dev when outside users create issues or discussions

To make sure we don't miss interactions with outside users, set up notifications with a GitHub Actions workflow when outside folks create issues or discussions. Some useful actions / docs:

Events that trigger workflows

discussion
discussion_comment
issues
issue_comment

Is Organization Member
Slack Notify

Closed by #2211

How to format slack markdown messages with the API
How to create a slack bot for github actions
I couldn't find an exhaustive source for the properties of github.event. These were some docs I referenced:

Web events and payloads
Events that trigger workflows
Github event types
How to get an author of a PR/issues

See description and solution of the annoying github condition bug here.


Is there a way to preload filestack?

Hey guys, I'd like to preload filestack client before the user hits the button for picking a file. This improves our UX since there's a tiny delay between the client load and the actual picker UI render

This would have to be an enhancement to the SDK (filestack-js), since the picker code is loaded at runtime over the network. We have had a similar request to provide the picker assets within the SDK for manual bundling, or to at least offer a separate SDK bundle with the picker code already included. We will be tracking this as an enhancement to filestack-js, and hopefully we can offer it as a fast-follow to the 1.0 release.

Thanks, @velveteer. That'd be great!

Is it possible now ?

@CentaurWarchief @nidhi-ag
Hey guys,
You should check out a new 2.0.2 release with newly added preload option.
Now you can control if assets like scripts or styles should be injected at mount or rather on click event.


Timezone for dates in the Portal

It's not clear what timezone is used to display dates in Application Insights (in Azure Portal). It seems it uses the same timezone as my computer. I wanted to see any logs/events/telemetry in UTC date time.
How can we switch to UTC in Azure Portal?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88844d44-a476-9c82-bb1f-77fe958d5639
Version Independent ID: 1a7e36ee-d4fa-653d-8fca-126b352a8087
Content: Azure Application Insights Transaction Diagnostics - Azure Monitor
Content Source: articles/azure-monitor/app/transaction-diagnostics.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@AlissonRS Thanks for the question. It would be great if you could provide us any Azure documentation link that you might be following while setting up your app insights as this would help us find the right person/team to help you with the query.

@RohitMungi-MSFT thanks for the reply, I'm sorry I forgot to add it.
Here it is:
Transaction Diagnostics
Ideally it should reflect in the Performance/Failures sections of App Insights, so all data would be displayed in UTC (as I work with people spread in different timezones and also our internal data are in UTC, it's easier to correlate and discuss if everything was UTC.
Thanks!

Just want to provide more details.
As you can see below, the dates are "Local Time", and local time is fetched from my OS. How can I change my "local time" in my Azure account so all these screens (e.g Performance, Failures, Events, Logs) stop relying on my OS?

@AlissonRS AFAIK, this is not doable directly from the App Insights portal.
However, you can choose to drill down on your query in the Log Analytics blade from the "View in Logs" option as follows, to see data in UTC time:

Please use this workaround for the time being while I check further with our internal Teams.

Yes, all Application Insights experiences (a.k.a. blades) should show a time zone (local time). But they indeed don't allow to change it. This ask is in our backlog. Thank you for raising it here - it helps us to prioritize it!

@zakimaksyutov Thanks for the update!
@AlissonRS Hope the above responses help.
At this point, it appears that there are no edits or updates needed to the document in question. Hence closing this issue for now. If there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

Seems to ble implemented now. Click on the settings gear on top right while searching logs

I do not see any settings gear on the Application Insights settings tab and the time selector only seems to be able to select Local Time?


Nuget

Hey there, 😄
Ever thought about turning this library into a NuGet package?
I'm super interested in tinkering with it, and it looks like it's got what I need.

Hi @alexpetrou94, yes I have been planning to do that. If you need it, then I might be able to get to doing it this week.
I moved the parsing code into my main development repository (https://github.com/ara3d/ara3d/tree/main/src) and start calling it "Ara3D.Parsing", where some tweaks and improvements have been happening. I am planning to move that code back into this repository, and just using it as a submodule. The only big change is that the CST generation now happens in its own project.
What kind of grammar or use-case do you have? Maybe I can help.

Thanks for your quick response! No rush on your end, take your time.
I'm currently working on creating a CSS-like language for the Godot Game Engine (A pet project). The goal is to make styling the UI more intuitive. Right now, I'm manually parsing text, which isn't the most efficient approach. In my search for a simpler parsing solution, I came across Parakeet, and it looks like it could be an ideal.

Hi @alexpetrou94 , I have just posted the most recent version of my parsing library to [https://www.nuget.org/packages/Ara3D.Parsing/1.0.0](nuget at https://www.nuget.org/packages/Ara3D.Parsing/1.0.0).

Thank you for the update! I'll definitely check it out and play around with the NuGet package. 😄

Hello @alexpetrou94 , just a head's up that I have been doing some work on Parakeet. I restructured the project, went back to branding it Parakeet (instead of "Ara3D.Parsing"), and started work on creating some new grammars, including a CSS one (which is currently untested). The work is currently in the repository, and not yet on the Nuget. I am traveling, so it will be a couple of weeks before I get the new version fully tested and back on Nuget.

Hi @alexpetrou94, I've made a new update on Nuget, and I've changed the name: Check out: https://www.nuget.org/packages/Ara3D.Parakeet.

Hello @cdiggins ,
I will check it out, thank you very much. 😄


Implement local and production docker environments

No objections to any of this - I was curious though about change to  "Make localhost default host in production".  Would that be true for both localhost and production?

I added some comments that are about adding some extra introductory description of Docker vs production server environment NGIX code.  Happy to see all the changes.  But I think we'll want to augment all this with a diagram showing the nuts & Bolts, and keeping track of ports/differences between production and server environments.


It's unclear what is meant by SERIALIZERS.current_user

I'm getting a deprecation warning "Current user endpoints now use their own serializer setting. For more information, see: https://djoser.readthedocs.io/en/latest/settings.html#serializers".
The referred documentation mentions that "Current user endpoints now use the serializer specified by SERIALIZERS.current_user". However, it's unclear what SERIALIZERS.current_user exactly refers to. Does it mean settings.DJOSER['SERIALIZERS']['current_user']? Or does it mean that settings.SERIALIZERS should point to an object that has a current_user member? In the latter case, I suppose settings.SERIALIZERS.current_user is a string that points to a serializer class?
In any case, I'm confused. Could this be clarified?

Hey @mnieber I apologize for the delay. The documentation is referring to settings.DJOSER['SERIALIZERS']['current_user']. This definitely needs to be clarified.


haskell-updates: operation requires -fexternal-interpreter

Describe the bug
LC_ALL=C NIX_PATH=channel:nixos-unstable nix-build '<nixpkgs>' --arg crossSystem '(import <nixpkgs> {}).lib.systems.examples.aarch64-multiplatform-musl' -A pkgsStatic.hledger

states

ghc: this operation requires -fexternal-interpreter
builder for '/nix/store/msf6r71xvk51ffhznif8f7mqlxk4my5n-shakespeare-2.0.25-aarch64-unknown-linux-musl.drv' failed with exit code 1
cannot build derivation '/nix/store/zhsad8aapkrrvi7jiwn1wr6qbk0wxzmq-hledger-1.19.1-aarch64-unknown-linux-musl.drv': 1 dependencies couldn't be built
error: build of '/nix/store/zhsad8aapkrrvi7jiwn1wr6qbk0wxzmq-hledger-1.19.1-aarch64-unknown-linux-musl.drv' failed

To Reproduce
Steps to reproduce the behavior:

LC_ALL=C NIX_PATH=channel:nixos-unstable nix-build '<nixpkgs>' --arg crossSystem '(import <nixpkgs> {}).lib.systems.examples.aarch64-multiplatform-musl' -A pkgsStatic.hledger

Expected behavior
The static hledger binary should be build
Additional context
On the nixos-20.09 channel I also have this same error so I presumed just unstable for packages version would be ok in terms of issue reproducibilty ?
EDIT: Also just saw this and as there is no drafting function for issues I close this right after creation to reopen accordingly when reproducing the error on haskell-updates
Notify maintainers

@sternenseemann
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.11.13-arch1-1, Arch Linux, noversion`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.8`
 - channels(root): `"nixpkgs-21.03pre250093.0da76dab4c2"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Just saw this so I'm closing this right now to reopen accordingly when reproducing the error on haskell-updates

Should be working as of https://github.com/NixOS/nixpkgs/commit/830ef6422f643d5c639fd79bca834c726787ec51, but there may be additional issues with cross, who knows.

Probably related #124284


Fix interface for exported functions

Pass reference value instead of pointer value in std::function .

LGTM 👍


Update README: Convert links to Markdown format

Refactor README: Updated Multicall, Bridge, and App links to Markdown format

thanks for the suggestions! I'll merge this but keep them coming


cheri-cap-lib fast representability check differs from that in Sail

As reported by Dapeng Gao:
The ‘CSetOffset’ instruction in Flute performs some optimisations (https://github.com/CTSRD-CHERI/cheri-cap-lib/blob/5c4171d3d0164d1d59ae3d6fa06ccaa4154522b8/CHERICC_Fat.bsv#L608) when computing permitted offsets, and these optimisations are not present in the Sail spec.

Again, as reported by Dapeng:
Although the ‘CIncOffset’ and ‘CIncOffsetImm’ instructions do exactly this check, the ‘CSetOffset’ function does something slightly different. The relevant code is around here (https://github.com/CTSRD-CHERI/cheri-cap-lib/blob/5c4171d3d0164d1d59ae3d6fa06ccaa4154522b8/CHERICC_Fat.bsv#L634), where the bound comparisons are different depending on whether you are incrementing or setting the offset. This causes ‘CSetOffset’ to deviate from the spec, albeit in a ‘good’ way that allows more legal capabilities to remain tagged.


Fix System.Guid -> Guid and other context cleanup

@danhellem - I want to keep the ClientSampleHelpers as clean as possible. I added a comment at the top (as part of this PR) to indicate that area or resource specific helpers should live elsewhere. I want to avoid this class turning into the "catch all" for every utility method for every sample. I also added a simple "GetValue" to ClientSampleContext so you (and others) could have a 1 line "get" in your sample. I then updated the WIT Queries sample to use it.


Unable to push: max retries exceeded

I was able to push the q4_0 tag to https://ollama.ai/sqs/starchat, but when I try to push other tags, I am getting an error (see below). Note the %!F(MISSING) below in case that is an issue.
The file size of the one that failed is 7.7GB. The q4_0 push that succeeded was 8.4 GB.
$ for i in q3_K_M q4_K_M q5_K_S q5_K_M f16 f32; do ollama create sqs/starchat:beta-$i -f Modelfile.$i && ollama push sqs/starchat:beta-$i; done
transferring model data
creating model layer
creating template layer
using already created layer sha256:62b0be00997dd300b03868d7858d28f41488c0222bfc4fbb6ceb3eae39a5d4d7
using already created layer sha256:ca40f7f0151766210faa524fa8710aabf07284671aaac525eeac350d64d05132
using already created layer sha256:dd473af9080c0674443f41cb6feb59ac1e24c34f18255c78d083f138f3275a0c
writing manifest
success
retrieving manifest
pushing 62b0be00997d...   0% ▕                                                                ▏ 1.3 MB/8.2 GB  5.2 MB/s  26m34s
Error: max retries exceeded: Put "https://dd20bb891979d25aebc8bec07b2b3bbc.r2.cloudflarestorage.com/ollama/docker/registry/v2/repositories/sqs/starchat/_uploads/55c91d69-edf4-4a50-a278-2c7c697ba4e4/data?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=XXX%!F(MISSING)20240123%!F(MISSING)auto%!F(MISSING)s3%!F(MISSING)aws4_request&X-Amz-Date=20240123T072755Z&X-Amz-Expires=86400&X-Amz-SignedHeaders=host&partNumber=29&uploadId=XXX&X-Amz-Signature=XXX": write tcp <IP_ADDRESS>:51301-><IP_ADDRESS>:443: write: broken pipe

(Note: I replaced URL query params that may contain credentials with XXX.)
This may just be an ephemeral error. I'll close this tomorrow if the other pushes succeeded.

Got a different error when trying to push sqs/starcoder:beta-q4_K_M:
pushing 3708ce083ec6...   0% ▕                                                               ▏ 1.0 MB/10.0 GB
Error: max retries exceeded: http status 502 Bad Gateway: <?xml version="1.0" encoding="UTF-8"?><Error>InternalError<Message>We encountered an internal connectivity issue. Please try again.</Message></Error>

And I also got the same error around the same time when trying to push the :beta-q3_K_M tag again:
$ ollama push sqs/starchat:beta-q3_K_M
retrieving manifest
pushing 62b0be00997d...   0% ▕                                                                ▏ 1.0 MB/8.2 GB
Error: max retries exceeded: http status 502 Bad Gateway: <?xml version="1.0" encoding="UTF-8"?><Error>InternalError<Message>We encountered an internal connectivity issue. Please try again.</Message></Error>

The ollama serve logs have some more information. I see:
<title>Worker exceeded resource limits | dd20bb891979d25aebc8bec07b2b3bbc.r2.cloudflarestorage.com | Cloudflare</title>

...

Worker exceeded resource limits

...

You've requested a page on a website (dd20bb891979d25aebc8bec07b2b3bbc.r2.cloudflarestorage.com) that is on the Cloudflare network. An unknown error occurred while rendering the page.

Yeah, I was only able to upload that first q4_0 one. The others all failed for the reasons given above.

On faster WiFi (thanks, Replicate!), the uploads are working.

If it's okay ill leave this open so we can hunt down why it fails on slower connections 😊

Home wifi - 5-10MB/s upload. Replicate wifi (where it worked) - ~75-90MB/s upload.

I encounter most probably the same issue: https://github.com/ollama/ollama/issues/2094 I could work around it by using a VPN although that was even a bit slower then. I used the Google One VPN.

I also just ran into this on a slow connection. Unable to complete the push.

Can confirm that I am also experiencing this issue on a 2.4MBps upload connection.

I'm getting this constantly.  I've only been able to upload 2 or 300 MB before it errors.   My upload speed is 600Mbps.
Usually it's "read: connection reset by peer" but I also sometimes got
http status 502 Bad Gateway: <?xml version="1.0" encoding="UTF-8"?><Error>InternalError<Message>We encountered an internal connectivity issue. Please try again.</Message></Error>
Is there a way to get it to try a different storage node, in case the one i'm connected too (dd20bb891979d25aebc8bec07b2b3bbc.r2.cloudflarestorage.com in this case) is faulty?

Same here. With an upload speed up to 5MB/s, I can't push anything.

I've tried:

changing my DNS, tried <IP_ADDRESS> and <IP_ADDRESS>
deleting my pub/priv key and using the newly generated one
recreating model from gguf
using new modelname
using model name without any punctuation

no luck.
I still get connection reset by peer or bad gateway after 2 or 300MB uploaded.


Improve exception handling for better user experiance

Handle below exception
./RstEyeApp
^C^C
^C^X
^CException in Tkinter callback
Traceback (most recent call last):
  File "tkinter/__init__.py", line 1967, in __call__
  File "tkinter/__init__.py", line 861, in callit
  File "app.py", line 147, in show_image
  File "tkinter/__init__.py", line 1504, in mainloop
KeyboardInterrupt
^C^C^C
^C
^CTraceback (most recent call last):
  File "app.py", line 166, in <module>
  File "app.py", line 160, in start
  File "tkinter/__init__.py", line 1504, in mainloop
KeyboardInterrupt
[669410] Failed to execute script 'app' due to unhandled exception!

The error was because systemd does'ty have access to graphic interface
we need to use the service at user level
it doesn't have access to any DISPLAY system
@coderadditai what do you think?

@coderabbitai I have added a PR #16  for this issue , please review it in this context


Stop Swift from crashing when processing fragmented nested namespaces

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - fb5c3603232e4702e2859b89e790f2aeb6c73d90

@scentini how's this patch going? Let me know if I can help.


Unable to call assume_role_with_web_identity without credentials

It appears that it is not possible to call assume_role_with_web_identity on rusoto_sts::StsClient without having a pre-existing access token. This is contrary to the documentation for sts::AssumeRoleWithWebIdentity, which states:

Calling AssumeRoleWithWebIdentity does not require the use of AWS security credentials

When I try to call the method without credentials, I end up getting this error:

Error: Credentials(CredentialsError { message: "Couldn't find AWS credentials in environment, credentials file, or IAM role." })

Also, given the default ChainProvider, it takes a couple seconds for me to get this error, I think because it's waiting for the container and instance metadata providers to time out.
Ideally, I could implement something like a NullProvider that returned a None for the credentials, but I don't think this is possible given this signature:
fn credentials(&self) -> Result<AwsCredentials, CredentialsError>

If it returned Result<Option<AwsCredentials>, CredentialsError> or if StsClient::new_with took an Option<P> for the provider, then I could indicate clearly that no credentials should even be attempted.
I believe this also affects assume_role_with_saml, since it also doesn't need AWS security credentials.
I think in order to fix this, something like StsClient::new_without_credentials is needed. That should then direct the code in client.rs to skip calling request.sign_with_plus.
Please forgive any weirdness in this report. I only started picking up Rust earlier this week 👍

Just came across StsWebIdentityFederationSessionCredentialsProvider. It looks like I should be using that instead of calling assume_role_with_web_identity directly.

Tried out calling via StsWebIdentityFederationSessionCredentialsProvider and still got the CredentialsError message

Fixed in https://github.com/rusoto/rusoto/pull/1500 , thanks @alex-berger !


fix(CWE-74) cookie accepts cookie name, path, and domain with out of bounds characters

Description
cookie is a basic HTTP cookie parser and serializer for HTTP servers. The cookie name could be used to set other fields of the cookie, resulting in an unexpected cookie value. A similar escape can be used for path and domain, which could be abused to alter other fields of the cookie. Upgrade to 0.7.0, which updates the validation for name, path, and domain. The cookie name could be used to set other fields of the cookie, resulting in an unexpected cookie value. For example, serialize("userName=; Max-Age=2592000; a", value) would result in "userName=; Max-Age=2592000; a=test", setting userName cookie to

These are dev-only dependencies and do not impact the driver or development workflow. NODE-6426 will probably be done soon and clear up any local development warnings here.


Override EJS context with Parcel querystring values

My usecase is that I need to be able to generate different content from the same template file based on different contexts / data passed in via Parcel CLI.  Querystring seems to be the way forward here:
https://parceljs.org/plugin-system/transformer/#query-parameters
These might be mapped to override the EJS compile option context, which lets you pass an object which will be used as this in the EJS template: https://github.com/mde/ejs/issues/197#issuecomment-242059566
I'll try prototyping this and submit a PR if it works.

Querystrings may still be of use to someone and it's a trivial change for this plugin, but for my usecase with entry points it currently does not work - Parcel doesn't handle querystrings on entry points at all and just throws an error.


Update retrieve api doc

Related tickets: https://github.com/killbill/killbill-client-ruby/issues/89
Updated:

The Retrieve Subscription by Id accepts a AUDIT but this is not present in the Ruby code and needs to be added.
The Retrieve Subscription by Key accepts a AUDIT query parameter but this is not present in the Ruby code and needs to be added.
The Retrieve Payment Method by Id accepts an AUDIT query parameter/ pluginProperties query parameter but this is not present in the Ruby code and needs to be added.
The Retrieve Payment Method by Key accepts an AUDIT / pluginProperties query parameter but this is not present in the Ruby code and needs to be added.
The Retrieve Payment by Transaction Id accepts an AUDIT / pluginProperties query parameter but this is not present in the Ruby code and needs to be added.
The Retrieve Payment by Transaction Key accepts an AUDIT / pluginProperties query parameter but this is not present in the Ruby code and needs to be added.
Retrieve Invoice By Id - This endpoint accepts a query parameter called withChildrenItems. However the corresponding Ruby method does not accept this parameter and needs to be updated.
Retrieve Invoice By Number - This endpoint accepts a query parameter called withChildrenItems. However the corresponding Ruby method does not accept this parameter and needs to be updated.

@reshmabidikar Please help me to merge the code. Thanks.


Hover effect on icons added

PR Description 📜
I have added hover effect on Linkedin,twitter and github icon.On hover now they raise and are filled with respective ui color
Fixes #812

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in [CONTRIBUTING GUIDELINE]
Earlier:

https://github.com/kunjgit/GameZone/assets/127978268/21ec4158-1660-44e6-a927-6978b4565f12
Now:
https://github.com/kunjgit/GameZone/assets/127978268/541c99c7-057f-4a1b-90bc-37bb73dcaf91
Thank you soo much for contributing to our repository 💗

Thank you @akankshachanana1 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

For now we are sticking with that UI only 👀 !!
as it will not follow the theme we have for GameZone


Set z-index for .active buttons container

Its good to bring .share-selected-text-main-container.active element on top of other elements.

Hi @dmitrymotorin, thanks for your contribution.  :)

Oh, thanks for advice :)
#4

thanks, I'll check it.


Programmatically retrieve 'SecurityToken' from C220/240 rack servers?

I was reading through https://github.com/CiscoDevNet/intersight-ansible/blob/master/playbooks/claim_device.yml#L26 -- is it possible to pull that value programmatically from the server?
I didn't have much luck looking through the rack API, I also looked at the /appliance/DeviceClaim API for Intersight which seems like it would try to connect to the device in question to pull that token, but wasn't able to get that working.
Thanks,
Tim

Device IDs and SecurityTokens are available through the device connector API and there's a full example of automated claim in Python/Ansible at https://github.com/CiscoDevNet/intersight-python-utils/tree/main/config_targets


Add project created stat to school admin dashboard and lint

Add project created stat
Lints SchoolAdminTeacherListRow.vue and SchoolAdminTeacherListView.vue

Add project created stat

@jmif Can you point out the changes related to this (project stats), vs only linting changes.


Flpath939 - ServiceNow workflow example

Hi @dmartinol ,
Please find this PR for approval and let me know what you think? It contains following:

ServiceNow instance setup instructions ( manual self-guided and automated ).
Escalation workflow with integration with notifications service including readme's.

Let me know what you think or please approve?
Thanks

/lgtm


[dart2js] Alternative code pattern for switch-continue

dart2js compiles a switch-with-continue into a pre-switch to identify the case group, followed by a loop containing a switch on the case group. (Description).
This is more verbose than the alternative of using the original switch:
switch (e) {
  L:
  case N1:
    ...
    break;
  case N2:
    ...
    continue L;
}

var t = e;
SWITCH_LOOP:
while (true) {
  switch (t) {
    case N1:
      ...
      break SWITCH_LOOP;
    case N2:
      ...
      t = N1; // Any constant from a `case` in the same group as `L:`.
      break; // continue-switch
  }
}

If there are many regular breaks and few continue-switch statements, it might be smaller to follow the switch with a break:
var t = e;
SWITCH_LOOP:
while (true) {
  switch (t) {
    case N1:
      ...
      break; // break to break below
    case N2:
      ...
      t = N1; // Any constant from a `case` in the same group as `L:`.
      continue SWITCH_LOOP; // continue-switch
  }
  break;
}

dart2wasm already uses a similar pattern.

Considering that (1) almost no code uses continue-switch statements (2) dart2js has had bugs in this area (3) dart2js, DDC and dart2wasm all have to implement this feature, it seems like a prime candidate for implementation in the front-end.
/cc @johnniwinther WDYT about the continue-switch feature being entirely implemented in CFE? switch-continue loops already need special treatment for pattern-matching.
/cc @alexmarkov Would the VM compiler produce reasonable code, or easily be modified to produce reasonable code, for the above pattern?

@rakudrama This lowering wouldn't help VM, but wouldn't hurt either. It would probably slightly increase code size and may slightly regress performance, but continue in switches is very rare so this is probably acceptable. If this lowering is done in the front-end, we could probably cleanup some code in the VM around handling of ContinueSwitchStatement and maintaining the mapping between switch cases and destination basic blocks, so it would probably result in less complexity in the implementation overall.


Pub: show me the most popular packages

Seeing packages sorted by "last updated" is often less relevant than seeing them sorted by "most popular" or "most used".

This issue has been moved to dart-lang/pub-dartlang#339.


Project kanban

Link to the kanban: https://github.com/Jolak5/mission-rocket/projects/1
We are a team of 2 people.

Link to the kanban: https://github.com/Jolak5/mission-rocket/projects/1 We are a team of 2 people.

Hi Team,
Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Equal distribution ✔
Kanban usage ✔

Required Changes ♻
Check the comments under the review.

[ ] The cards are expected to total 17 because you are two in this group, but I can see it totals 18, can you kindly remove the excess on it?

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi Team,
Status: Approved ✅
Your project Kanban board is complete!  There is nothing else to say other than... it's time to begin implementing your project :shipit:
Congratulations! 🎉

Good Highlights

Well distributed tasks

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Comma escaping not working per spec

Describe the bug
Comma escaping not working per spec: https://www.hl7.org/fhir/search.html#escaping
FHIR Version?
Stu3/R4
Data provider?
SQL (may also be in Cosmos)
To Reproduce
Steps to reproduce the behavior:
https://{{fhirserver}}/Practitioner?name=KEBER MD\,BARBARA A ;
Expected behavior
Should return Keber MD, Barbara A
Actual behavior
It is searching for Kerber MD and Barbara A as two entries

@brendankowitz  - FYI

@Ivanidzo4ka  - Created AB#77071 for this for you

Verified using a few scenarios using the following, it looks to be generating the correct queries in these situations and returning the expected results.

/Patient?name:exact=KEBER MD\, BARBARA A
/Patient?name:exact=KEBER MD, BARBARA A
/Patient?name:exact=KEBER MD
/Patient?name=KEBER MD
/Patient?name=KEBER MD, BARBARA A


Client crashes when changing colorscheme

python-client version 0.0.38
When changing the colorscheme with  :colorscheme default:
Traceback (most recent call last):
  File "neovim/ui/ui_bridge.py", line 91, in apply_updates
    handler = getattr(self._ui, '_nvim_' + update[0])
AttributeError: 'GtkUI' object has no attribute '_nvim_update_menu'

And it seems that colorscheme setting in the config file is ignored.

A temporary fix for now. 40cdf1c1a70e25a9e61d0379b40ce4aac84d4b94

Do not crash the application due to un-implemented method.
Instead throw a warning message and ignore the event

see neovim/gui-client#2


Initial provisioning of pg-int-testing

Creation of a new server-state-playbook for pg-int-testing to host PostgreSQL databases internally to be used for testing of some kind or another, as opposed to hosting databases for external or internal production systems.
Inventory: https://github.com/openmicroscopy/management_tools/pull/540
No doubt this could be refactored - we can redeploy the system and refactor the playbook later - I need it now, so created with this playbook.
Some fixes to come, e.g. renaming pg_dump vars (since it's not an OMERO server) and probably updating that in inventory etc too.

Also, this'll need some work to the pg_hba.conf no doubt. Possibly that's just different vars given to the role openmicroscopy.postgresql we'll find out.

See also https://github.com/openmicroscopy/infrastructure/pull/303. This might have to be reopened against https://github.com/openmicroscopy/prod-playbooks

Next step here?

Shutting this down. Will have to re-open.

re-opened on https://github.com/openmicroscopy/prod-playbooks/pull/121


Standard/extended identifier implementation incorrect?

I believe the current implementation of the CANFrame constructor is incorrect, because it does not allow the construction of frames with an extended identifier less than 0x800.
Code is currently as follows:
    pub fn new(id: u32, data: &[u8], rtr: bool, err: bool) -> Result<CanFrame, ConstructionError> {

        ...

        if id > EFF_MASK {
            return Err(ConstructionError::IDTooLarge);
        }

        // set EFF_FLAG on large message
        if id > SFF_MASK {
            _id |= EFF_FLAG;
        }

Say I wanted to construct a frame with extended identifier 0x100. If I pass id=EFF_FLAG | 0x100 the constructor would return an IDTooLarge error. If I pass id=0x100, the constructor returns a frame with a standard identifier.
The CAN standard allows for extended identifiers less than 0x800, and in fact these are commonly used, here are a few examples:
https://stackoverflow.com/questions/63213413/standard-and-extended-messages-with-same-identifier
https://forum.hms-networks.com/t/about-extended-frame-format/2237
https://kb.vector.com/entry/1093/
Recommendation: add an argument to CANFrame::new to set the identifier type explicitly (this is a breaking change to the API- but current behavior is incorrect in some cases)

In the next release of embedded-hal (0.2.x) the embedded_can ID structs exists there as well. I don't know if it's better to use the stand alone embedded_can IDs or the other. But using one for most implementations is better for compatibility, I think.

I think it would make sense to go with embedded-hal. initially the plan of the embedded-can author was to make it part of embedded-hal and from my understanding embedded-can was basically more of a intermediate step.

(New user here, have recently started using socketcan/socketcan-isotp/embedded-can/etc...)
It's not clear to me why it would be beneficial to use a crate that is ostensibly designed for providing a HAL for embedded microcontrollers when SocketCAN is generically available for Linux.  Maybe it becomes a forced decision if embedded-can goes away and only lives on in embedded-hal, but the main types it exposes are so generic to CAN, and so far removed from even SocketCAN or Linux or embedded itself, it's weird/surprising to depend on that crate.
It feels like it could be more beneficial to have a foundational crate -- for example, can or can-core or whatever -- that defines all of these immutable/fixed/specified types and then other downstream projects can depend on that.  Like, the format of a CAN frame, and the meaningful of flags, standard vs extended IDs, ISO-TP... it's already well-defined.  You could likely create a 1.0 release in short order, and avoid worrying about other random tangentially-related crates going away/becoming unmaintained.

Yes, I've been wondering which is the better way to go on this as well. I suppose there are some microcontroller/RTOS implementations of SocketCAN, like in Zephyr:
https://docs.zephyrproject.org/2.6.0/samples/net/sockets/can/README.html
But are there even any Rust ports to any non-Linux embedded systems that use SocketCAN? If not then I probably wouldn't want to spend much time considering designs to incorporate anything that isn't Linux.
That said, if there are generic traits and types for CAN that would be useful to help port between SocketCAN and Embedded CAN crates, then I wouldn't be opposed to using them directly, if they are zero cost. But if they were to impose some performance overhead, I would prefer to isolate them in an optional layer, such as behind a feature flag.

I think the bxcan-crate implemented it fairly well. Basically it has it's own copy id types in id.rs and a separate module with embedded-hal "translations". The embedded-hal part can than still be put behind a feature flag. We definitely need something anyway like the types in id.rs to fix currently incorrect handling of extended ids.
I think the point is basically to support different systems easily without relying explicitly on socketcan. E.g. a STM32 embedded controller using bxcan or RPI using socketcan or possibly some commercial windows driver in the future.
Check out the (linux-embedded-hal crate)[https://github.com/rust-embedded/linux-embedded-hal] . I think it would be nice to basically extend this to reference the socketcan crate for the embedded-hal CAN implementation.
The python can project also seems to follow this approach and I personally think it's worth the effort especially for crates that basically build on top of CAN. E.g. imagine a UDS crate (unified diagnostic service not Unix domain socket =) ) that can be used with any of those crates rather than completely relying on socketcan.

For what it's worth, I (just) acquired ownership of the can crate if people are interested in the idea of a foundational crate that could potentially supplant other implementations as the canonical source for stuff like IDs, constants, types, etc.
I think the notion of crates being able to derive their own translations layers based on foundational traits is great, but I don't see a need (personally! there's still a ton I don't actually know about CAN and the CAN ecosystem) for each of those crates to define their own version of standard/extended IDs and then add in a bunch of conversions between other crates.  It really does seem like that should be defined in a single crate.

I just ran into this again trying implement the linux-embedded-hal traits. I think this really should be fixed in 2.0 as it pretty likely a breaking change. It's still not possible to create a frame with extended frame flag set but an identifier less than 0x800.
https://github.com/socketcan-rs/socketcan-rs/blob/d8e0fb1fbec17578b2394b715427346617516f11/src/lib.rs#L503
Options I see are (in no particular order) :

add eff: bool parameter to new fn and remove the check in line 503.
remove both checks in line 498 and 503. I think this is actually a bad idea as it's a hard to find breaking change that people will probably just run into at runtime. Basically you'd very likely end up not setting the EFF once you upgrade to 2.0.
merge the full version of #24 .
reduce #24 to just embedded-hal (alpha 8)/embedded-can(alpha 9) ids and replace id: u32 with id: Into<Id>

Actually, I haven't looked at what the Embedded HAL stuff is doing yet, and I think we will eventually move toward using it, but given the existing library, I would normally just add a second, targeted constructor, like:
pub fn new_extended_id(id: u32, data: &[u8], rtr: bool, err: bool) -> Result<CanFrame, ConstructionError> {
  let mut frame = Self::new(id, data, rtr, err)?
  frame._id | EFF_FLAG;
  Ok(frame)
}

Or maybe this would be named with_extended_id()?
The idea being, keep the base new() for the most common cases and make different new's, with's and from's for the more specific cases.
On that note, the most common case would just be to take the id and data slice, and make the specification of rtr and err separate.
Or.... make them into a Flags type and specify that optionaly:
pub fn new<F>(id: u32, data: &[u8], flags: F) -> Result<CanFrame, ConstructionError>
where
    F: Into<Option<Flags>>
{
  ...
}

In this case you can force on the extended ID by specifying it as a flag:
let stdFrame = CanFrame::new(0x50, &data, None)?;     // Defaults to standard ID
let extFrame = CanFrame::new(0x900, &data, None)?;    // Extended ID implicit by value

let extFrame = CanFrame::new(0x50, &data, Flags::ExtendedId)?;  // Explicitly specify flag

Circling back, I did end up trying to provide some of these CAN primitives in the aforementioned can crate.
I specifically avoided anything related to traits because that can just get too opinionated too fast i.e. sync vs async. If anything in can looks appealing to you, or you'd want to take it over and use it as a more foundational crate (sort of how many Rust HTTP crates use http for the foundational primitives) I'd be happy to chat and/or transfer ownership.

Several workarounds were added to fix this. The CanFrame::new() and CanFdFrame::new() functions were refactored to take an embedded_can::Id object which must be a StandardId or ExtendedId type. When it's an extended ID, it sets the extended bit regardless of the raw ID value.
The new lower-level init() function which was based on the previous version of new() now takes a bitflag for the bits instead of a buch of bool values. The caller can set the extended bit manually, and if not, only then will it guess based on the ID value.


Search::Elasticsearch::Async bulk insertions: daily index names not auto generated.

Auto-Generating of daily index names for bulk insertions works in the synchronous module.
However this does not work for the asynchronous module when using bulk_helper.
Workaround: use perl code to generate a daily index name.

Never mind, Java programmer meets implicit Perl cleverrness. Please close issue.


Kinematic bodies cause slowdown/crash when colliding with extremely complex convex shape (7000+ vertices)

Godot version:
Godot 3.3.
OS/device including version:
Linux Manjaro, Intel Kaby Lake
Issue description:
Noticeable slowdown when a kinematic body collides with stuff. I managed to "manage" most of it by a) optimizing the collision shape of the AI and b) reducing the number of "slides" attempted to 1. (I tried to change the physics to move_and_collide() but failed :(  I am also looking at kinematic mode rigidbodies as a possible solution - I really like how smooth movement/AI code are with kinematic bodies as opposed to VehicleBody )
This is Bullet physics BTW - if you change to Godot physics and collide with a building, the game freezes, no output in log.
Cars: kinematicbody3d with a box collision shape
Ground: staticbody with a box collision shape
Buildings and some part of the road: convex collision, autogenerated (I will likely try replacing those with simpler shapes next)
Steps to reproduce:
Run the project, drive around. The fastest way to trigger AI crashing into stuff is to start a race (red flag on minimap, red marker on ground) because the AI crash into stuff after crossing finish line (unfinished [pun intended] AI handling xD)
Minimal reproduction project:
Not minimal, because it takes several AI going around and crashing into obstacles for stuff to happen, but:
https://github.com/Zireael07/FreeRoamRoguelikeRacerPrototype
master branch: drops to single digits when an AI or two crash into stuff
develop: drops to 20-ish fps
@Calinou  and whoever else told me to make a new issue

Does it happen with 3.2.3 as well, or just 3.3?

Looks like so:

The freeze with Godot Physics is also present in 3.2.3.

Note for junior job:
Fixing the issue might require experience with physics and could be difficult for a beginner, but if anyone is interested in learning the basics of debugging, helping with the first steps of investigation would be great.
Identifying the issue seems to be easier with Godot Physics, since it's a complete freeze (and it's likely to have a similar cause as Bullet). Here's what can help identifying the issue:

Build the 3.x branch locally in debug configuration
Use an IDE with a debugger like Visual Studio or VS Code
Make sure the minimal project is set to use Godot Physics
(Project Settings > Physics > 3D > Physics Engine > Godot Physics)
Run the minimal project using a debugger and try to reproduce the issue
(command line: --path c:/path_to_project_folder)
When the game freezes, pause the execution in the debugger
Check the call stack on the main thread and post it here

Note: for the freeze, it's enough for you (the player) to collide with a building, so it can be trivially reproduced. It doesn't appear to cause the slowdown the AI do cause, possibly because the player won't keep trying to drive ahead once crashed ;)

@Zireael07 Thanks for the extra information!
About compiling godot: it's not too complicated. You would be very welcome to give it a try :)
https://docs.godotengine.org/en/stable/development/compiling/compiling_for_x11.html

If it's ok, I'd like to investigate this and see whether I can make collision detection fast with large convex shapes.  No promises, but I think there's a lot of room for optimization.
It looks to me like the problem is that project_range() and get_support() in GodotConvexPolygonShape3D are both implemented through a full loop over vertices.  That makes the cost linear in the size of the mesh.  By doing some precomputation, we ought to be able to avoid that.  This paper suggests recording the neighbors of each point on the convex hull and using hill climbing.  Or we could build some kind of spatial subdivision structure to limit which vertices need to be looped over.  The challenge is to make it fast on large meshes without making it slower on small ones.  The simplest solution might be to use the simple loop for small meshes, and something more sophisticated when the number of vertices is above a threshold.

The real problem is _collision_convex_polygon_convex_polygon().  It contains a series of loops like this.
https://github.com/godotengine/godot/blob/ecc86afc00c6ace07bfc05ea6ebe8a971d40934b/servers/physics_3d/godot_collision_solver_3d_sat.cpp#L2132-L2144
This one loops over every pair of edges.  There also are loops over all pairs of vertices and all vertex/edge pairs.  Inside each loop it calls separator.test_axis(), which itself loops over all vertices in each mesh.  So given two meshes that each have N vertices, the cost of this routine is O(N^3).  We can definitely do better!  I'll try some experiments.

hmmm the convex object I was using is rather simple, I didn't check exact number of vertices,but I think it only has like few hundred at max, since the model I used to generate convex is just a lowpoly plane model with minimal faces.

@MagickPanda the model used in this original issue was a lowpoly boxy building, you would think the convex shape would be simple but nope, lots of vertices!

In this case it is actually just 28 vertices for the convex shape, so this affects even low-poly convex shapes


feature: fetch the most current name for HSPs

Previously, we would send the user the display_name that was used when
the profile was recorded. Instead, we now fetch the current display_name
and use that.
There will be a follow-up PR to not record the display_name in the
first place, since it's now a dynamically created field.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b81cc46). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage          ?   95.55%
=========================================
  Files             ?        7
  Lines             ?      135
  Branches          ?        0
=========================================
  Hits              ?      129
  Misses            ?        6
  Partials          ?        0

Impacted Files
Coverage Δ

historical_system_profiles/views/v0.py
86.36% <100%> (ø)

historical_system_profiles/metrics.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81cc46...dafd1b6. Read the comment docs.


fix fsnotify event proc missing for install-cni

Please provide a description of this PR:
problem
Installer.Run of install-cni will watch cfg.MountedCNINetDir(/host/etc/cni/net.d), if config files in this dir have changed, Installer.Run will reinstall all files(binary, kube config, cni config, etc).
func (in *Installer) Run(ctx context.Context) (err error) {
	for {
		if err = copyBinaries(
			in.cfg.CNIBinSourceDir, in.cfg.CNIBinTargetDirs,
			in.cfg.UpdateCNIBinaries, in.cfg.SkipCNIBinaries); err != nil {
			cniInstalls.With(resultLabel.Value(resultCopyBinariesFailure)).Increment()
			return
		}
...
		if err = sleepCheckInstall(ctx, in.cfg, in.cniConfigFilepath, in.isReady); err != nil {
			return
		}
		// Invalid config; pod set to "NotReady"
		installLog.Info("Restarting...")
	}
}

When testing this feature I find that this only take effect when creating new files in /host/etc/cni/net.d. Whether delete or update files in the dir, the sleepCheckInstall func will not return and Installer.Run will not reinstall files.
the reason
This is because there is a small problem in sleepCheckInstall.
func sleepCheckInstall(ctx context.Context, cfg *config.InstallConfig, cniConfigFilepath string, isReady *atomic.Value) error {
	// Create file watcher before checking for installation
	// so that no file modifications are missed while and after checking
	watcher, fileModified, errChan, err := util.CreateFileWatcher(cfg.MountedCNINetDir)
	if err != nil {
		return err
	}
	defer func() {
		SetNotReady(isReady)
		_ = watcher.Close()
	}()

	for {
		if checkErr := checkInstall(cfg, cniConfigFilepath); checkErr != nil {
			// Pod set to "NotReady" due to invalid configuration
			installLog.Infof("Invalid configuration. %v", checkErr)
			return nil
		}
		// Check if file has been modified or if an error has occurred during checkInstall before setting isReady to true
		select {
		case <-fileModified:             //--- p1
			return nil
		case err := <-errChan:
			return err
		case <-ctx.Done():
			return ctx.Err()
		default:
			// Valid configuration; set isReady to true and wait for modifications before checking again
			SetReady(isReady)
			cniInstalls.With(resultLabel.Value(resultSuccess)).Increment()
			if err = util.WaitForFileMod(ctx, fileModified, errChan); err != nil {
				// Pod set to "NotReady" before termination
				return err
			}
		}
	}
}

After install-cni starts up, the sleepCheckInstall will fall to default branch and waits for fileModified / errChan / ctx.Done() in WaitForFileMod.
// Waits until a file is modified (returns nil), the context is cancelled (returns context error), or returns error
func WaitForFileMod(ctx context.Context, fileModified chan bool, errChan chan error) error {
	select {
	case <-fileModified:                 //-- p2
		return nil
	case err := <-errChan:
		return err
	case <-ctx.Done():
		return ctx.Err()
	}
}

When creating new files, fsnotify will generate TWO events(CREATE and CHMOD), while when deleting or updating files, fsnotify will generate ONE event(REMOVE for deleting and WRITE for updating).
If we delete or update files, we will get ONE event, so we will return nil from WaitForFileMod(p2), and continue the loop in sleepCheckInstall. Since we have one event and the fileModified channel is empty now, we will fall to default branch again. The event is not actually processed.
If we add files, we will get TWO events, when we return nil from WaitForFileMod(p2) and continue the loop in sleepCheckInstall, the fileModified channel still have an element, so we will return nil from sleepCheckInstall(p1) to Installer.Run, and reinstall those files.
how to fix

We only need to handle fsnotify.Create|fsnotify.Write|fsnotify.Remove, and ignore fsnotify.Rename and fsnotify.Chmod.
when return from WaitForFileMod, we should always return from sleepCheckInstall to Installer.Run.

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@silenceshell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
d150b6547163ceb1dc592bed03c3686d64a05563
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


[github] Add github-actions to dependabot

Coverage remained the same at 100.0% when pulling 4ea096cafe074942a05a3edab1b24a9563ae3c7a on hazendaz:master into 293565e2c647acf50f02f27871266f3e4d42c549 on mybatis:master.


DeprecationWarning: Plural value must be an integer, got float

What did you do?
I ran tests.
What did you expect to happen?
Tests pass without warnings.
What actually happened?
The following warning was reported:
=============================== warnings summary ===============================
tests/test_i18n.py::test_i18n
  $(@D)/src/humanize/i18n.py:133: DeprecationWarning: Plural value must be an integer, got float
    return get_translation().ngettext(message, plural, num)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

What versions are you using?

OS: OpenIndiana
Python: 3.9.16
Humanize: 4.6.0

Thanks for the report, a PR is welcome!

Hello, I would like to work on this issue. If you don't mind, could you tell me how to run the test and achieve the same results so that I can my hands on fixing it?
Thanks!

Sure, something like this. Assuming you've already forked and cloned, then:
# First do an editable install
pip install -e ".[tests]"

# Generate translations
scripts/generate-translation-binaries.sh

$ # Then run tests
$ pytest tests/test_i18n.py
================================================================================================ test session starts ================================================================================================
platform darwin -- Python 3.11.5, pytest-7.4.2, pluggy-1.3.0
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /Users/hugo/github/humanize
configfile: pyproject.toml
plugins: random-order-1.1.0, anyio-4.0.0, asyncio-0.21.0, flaky-3.7.0, timeout-2.1.0, cov-4.1.0, respx-0.20.1, mock-3.11.1, xdist-3.3.1, hypothesis-6.75.2, lazy-fixture-0.6.3, aiohttp-1.0.4
asyncio: mode=Mode.STRICT
collected 28 items

tests/test_i18n.py ............................                                                                                [100%]

================================================================================================= warnings summary ==================================================================================================
tests/test_i18n.py::test_i18n
  /Users/hugo/github/humanize/src/humanize/i18n.py:126: DeprecationWarning: Plural value must be an integer, got float
    return get_translation().ngettext(message, plural, num)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================================================================================== 28 passed, 1 warning in 0.04s ===========================================================================================

Alright, I believe i can handle this.
Could you assign it to me?
Ps: Could you also kindly add the hacktoberfest label too?
Thanks!

We don't normally assign issues but go ahead. Also the repo already has the Hacktoberfest topic, so we don't need to label it. Thanks!

Apologies as this is my first PR, but how do I run the checks required? I didn't find anything related to that from the Contributing docs

For new contributors, I need to click a button to approve the CI run. It's a GitHub default to prevent cryptocoin mining. I've now clicked it! ⏯

Hello @hugovk, is there any guideline I may have overlooked? I have refixed the code and passed the tests, but it hasn't been merged yet so I was wondering if there is something I might have missed. Apologies if I'm being such a bother at the moment.

Hi there, everything looks in place, I just need to find some time to give it a review. Don't worry, I expect we can get it all sorted during October :) Thanks!

Alright then.
Thank you :)


ENH: fix dayof(week|year) for sql and update dtypes for datetime exprs

We were using int64 where we could store the result in a much smaller type. We cannot go all the way down to i8 for these because sql small integer maps to an i16 so it is just easier to leave this here than to make i8 map to small integer also.
This mainly cleans up that extract uses the names dow and doy for dayofweek and dayofyear.
I also correct that sql dow uses sunday=0 but datetime.datetime and pandas use monday=0

ping @stefanseefeld this updates the new datetime stuff you worked on, can you take a look at this?

also, I think the doc test issue is around the dask change in odo

Coverage increased (+0.01%) to 89.586% when pulling 7cbce24c794128a8b1d144818ad59a2cb2395b5b on quantopian:dow-fixes into a1aa9a2868494f875c41bb1d9c88c0ea666071e2 on blaze:master.


support for AspNet Identity3?

Hi, I've been tinkering with the beta7 release of aspnet5 and was wondering if there was a plan to support Identity3 as a backing store?  I love this work, btw.  I'm new to token servers and I've learned so much from your explanations and code.  Can't thank you enough for sharing.

pls disregard.  saw the answer in a prior question, sry.


chore: TRG 7.00 - update copyright header

Description

Comply with TRG 7.00 and update all copyright headers to point to current year.
Command used:
find . -type f -exec sed -i -E 's/(.*)Copyright \(c\) 2021,2023 Contributors to the Eclipse Foundation/\1Copyright \(c\) 2021,2024 Contributors to the Eclipse Foundation/g' {} \;

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

@carslen Ok, no problem, but we should maybe update the TRG text as it led me to believe that this is necessary.

Feel free to create a draft with an updated TRG. I guess you're pointing to this section of the TRG:

Keep the following updated for each pull request to the default branch (main)

Legal Documentation: TRG 7.01
License and copyright header: TRG 7.02

must be present in every file if possible
update the year in the copyright section at the beginning of each new year

From my point of view this isn't misleading. The TRG describes recurring activities you have to take care of, when creating a new PR because of changes to the code, docs, etc. As no changes have been made to the code, no update of the copyright headers is required.


neovim plugin infrastructure

Issue description
As reported in https://github.com/NixOS/nixpkgs/pull/178180#issuecomment-1197726116, buildNeovimPluginFrom2Nix (currently) ignores the "src" which is confusing.
https://github.com/NixOS/nixpkgs/blob/551e65e946d7261f956175845a739072dd2ac6e0/pkgs/applications/editors/vim/plugins/generated.nix#L3156
Solutions:

either dont write src so it's clear we are using the version from the lua package
we use the "src" version but it means we need

This is sthg I am invested in so I've assigned it to myself.

How to build custom plugin with lua, which not included in nixpkgs?

@miuirussia your question is a bit orthogonal, maybe ask on the discourse instead. You may find info here https://github.com/NixOS/nixpkgs/pull/126633

a few plugins to add to lua

https://github.com/hrsh7th/nvim-cmp/pull/1051
https://github.com/rktjmp/lush.nvim/pull/58

the process should be clearer now that staging was merged.


ThreadPriorityValue::MIN/ThreadPriorityValue::MAX have unexpected types

I believe those should have ThreadPriorityValue type, not u8. It is always possible to convert it to u8 later if desired, but converting u8 to ThreadPriorityValue requires unwrap() or expect(), which is inconvenient and unnecessary.
P.S. Clippy warning here has nothing to do with From<u8>, it suggests you to do impl From<ThreadPriorityValue> for u8:
https://github.com/iddm/thread-priority/blob/74cf570b36bb12d0dc3ea2d406d21569516aff96/src/lib.rs#L264-L271

Thank you for reporting this, I'll have to check. It has been a long time since I last worked on this project. Not to mention that I privately am rewriting it to something much simpler than it is now.

So I checked the code, and I remember the reason why I did it this way.
So the ThreadPriorityValue was supposed to be a universal numeric value in something like percentage, varying from 0 to 99 inclusively. The higher the value - the higher the priority should be, and vice versa. The reason I implemented only the Into<u8> and not From<ThreadPriorityValue> is because not all the values of u8 are correct for ThreadPriorityValue, but only in the range of 0..=99, so any value from within the range of 100.==255 will be incorrect. Hence, there was no safe and guaranteed conversion from ThreadPriorityValue to u8; the opposite was true from u8 to ThreadPriorityValue. And this is why there is TryFrom.
I understand that the unwrap() or expect() isn't something one might want to have all the time, but unfortunately, there is no safe way to convert from one to another. We could have some clamping the values over 99, but this might have implicit meaning for some people, who might think that there is indeed a difference between 99 and 100 and any other value higher than 99.

The reason I implemented only the Into<u8> and not From<ThreadPriorityValue> is because not all the values of u8 are correct for ThreadPriorityValue

What you are talking about is impl From<u8> for ThreadPriorityValue, which if added would be a problem indeed.
What clippy is talking about is impl From<ThreadPriorityValue> for u8, which doesn't violate any expectations and does exactly the same thing as impl Into<u8> for ThreadPriorityValue in the end, just more awkward sometimes.


Question: how to set the post creation dates visible?

Hi,
In Your example You have visible dates on the posts

In my case these dates does not appear:

I have the same config as in the example site.
Is there a specific param to set in order to get this work?

You need to set the date param in the front matter for the post.

Sure, I've done that. I even copied the front matter from the example and got the same result:
+++
author = "Hugo Authors"
title = "Test"
date = 2019-03-05
description = "Guide to emoji usage in Hugo"
tags = [
"emoji",
]
+++

Before that I had a simple json with title, date and draft

What version of Hugo are you running?
$ hugo version
hugo v0.104.3+extended darwin/amd64 BuildDate=unknown

If you click through to the page for the post, does it show the date under the title, like it does at https://lukasjoswiak.github.io/etch/markdown-syntax-guide/?

@padaszewski
Here's my codes I am using.
Environment
Content
Set data and lastmod on each post.
---
title: "도커 파일시스템 정리"
date: 2022-03-16T13:07:20+09:00
lastmod: 2022-08-31T10:03:10+09:00
slug: ""
description: "쿠버네티스 워커 노드가 파일시스템 사용률이 높을 때, docker system prune 명령어를 실행해서 Docker 오브젝트를 정리하여 파일시스템 공간을 확보할 수 있다."
keywords: []
tags: ["os", "linux", "docker"]
---

... then contents from now on ...

Config
baseURL                = "https://younsl.github.io"
title                  = "younsl"
theme                  = "etch"
languageCode           = "en-US"
enableInlineShortcodes = true
pygmentsCodeFences     = true
pygmentsUseClasses     = true
disableKinds           = ["taxonomy", "term"]

[params]
  description = "younsl"
  copyright   = ""
  dark        = "on"
  highlight   = true

[article]
  showComments      = true
  showAdvertisement = true

[menu]
  [[menu.main]]
    identifier = "wiki"
    name       = "wiki"
    title      = "wiki"
    url        = "/wiki/"
    weight     = 10

[permalinks]
  posts = "/:title/"

[markup.goldmark.renderer]
  # Allow HTML in Markdown
  unsafe = true

  [markup.tableOfContents]
    ordered = true

Output
Here's what the webpage looks like in the Chrome browser.

In my case, date and lastmod frontmatter are output normally without any specific config.toml settings.
You need to set date and lastmod value in the post frontmatter.

Hi @LukasJoswiak, Hi @younsl
Thanks for the info. Unfortunately the approach with lastmod is also not working correctly.
@LukasJoswiak
hugo version output:
hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended windows/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio
On my blog You also can't see the date under the post :/

Can you try building the example site in this repo and see if the issue reproduces?
I thought it could be an issue with your Hugo version, but I built Hugo v110.0
hugo % ./hugo version
hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168 darwin/amd64 BuildDate=2023-01-17T12:16:09Z

and then built the example site in this repo with it and I see all the dates correctly. I think it's likely there is some issue with your local site configuration.


Cache result of string.join in ElementAttributeContainer

To improve performance due less garbage creation

obsoleted by #292


Update versions in Helm charts and GMC manifests to v1.1

Description
Change labels & chart version to match / reduce diff to v1.1 release after c0a31210bb3d42bc1b457bead9bcd4983ba2726f.
(Needing to do this manually in main branch seems odd. IMHO bot should do this update to main at the same time it updates these, and image tags, in release branch.)
Issues
n/a.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Dependencies
n/a.
Tests
Should already have been tested as part of v1.1rc branch?

There are several CI errors.  They do not seem to be related to changes from this PR, but to be bugs either in existing code, or CI.
Error: no repository definition for [https://zilliztech.github.io/milvus-helm/.](https://zilliztech.github.io/milvus-helm/) Please add the missing repos via 'helm repo add'
=> Why NeuralBot release changes are not checked / do not need to pass CI: c0a31210bb3d42bc1b457bead9bcd4983ba2726f  ?
 Traceback (most recent call last):
  File "/home/user/comps/tts/speecht5/dependency/speecht5_server.py", line 15, in <module>
    from comps import CustomLogger
  File "/home/user/comps/__init__.py", line 7, in <module>
    from comps.cores.proto.docarray import (
  File "/home/user/comps/cores/proto/docarray.py", line 10, in <module>
    from pydantic import Field, conint, conlist, field_validator
ImportError: cannot import name 'field_validator' from 'pydantic' (/usr/local/lib/python3.10/dist-packages/pydantic/__init__.cpython-310-x86_64-linux-gnu.so)

=> CI is not using correct latest tag (should be fixed after PR #587 is merged):

CI: <IP_ADDRESS>:5000/opea/speecht5-gaudi@sha256:527687da2c0df59d5b06d8d471145fccf29389f3bc974dd57842095abc090d3f
https://hub.docker.com/r/opea/speecht5-gaudi/tags: latest = 17f6a09cb026  (same as 1.1, 4 days old)

I see in CI logs also these:
kubectl get pods -n opea-app-audioqa -l app=router-service -o 'jsonpath={.items[].status.conditions[?(@.type=="Ready")].status}'
error: error executing jsonpath "{.items[].status.conditions[?(@.type==\"Ready\")].status}": Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:
	template was:
		{.items[].status.conditions[?(@.type=="Ready")].status}
	object given to jsonpath engine was:
		map[string]interface {}{"apiVersion":"v1", "items":[]interface {}{}, "kind":"List", "metadata":map[string]interface {}{"resourceVersion":""}}

Closing, (already merged) PR https://github.com/opea-project/GenAIInfra/pull/587 replaces this.


feat: add blog post about js-libp2p 0.24 release

This has a pleasing amount of emojis.  I have no review powers on this repo, but I approve.


[TS migration] Migrate KYCWall component

Details
[TS migration] Migrate KYCWall component
Fixed Issues
$ https://github.com/Expensify/App/issues/25126
PROPOSAL: N/A
Tests

log into the app
press the FAB and request money from e.g. workspace that you are a part of (to make it easier and not have to jump between accounts)
select the said workspace and press on pay with Expensify
confirm that the pop up shows in which you can select an option and be navigated to it

[x] Verify that no errors appear in the JS console

Offline tests
Same as Tests section
QA Steps
Same as Tests section

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@Julesssss all yours!

@Julesssss, I've fixed the issue.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.27-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.27-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@ZhenjaHorbach The parameter swap was done because on the initial work the source parameter was required but after the migration was completed it didn't made sense anymore to have it as required, this part can be reverted as it is a left-over.

@ZhenjaHorbach @tienifr I've created a Draft PR for this changes. Here is the link: https://github.com/Expensify/App/pull/34870

Ah this seems like it broke paying IOU reports

@Julesssss @rushatgabhane PRS touching the wallet payment flows should ideally be labelled with internalQA as the wallet payment flow cannot be tested otherwise easily, not by the contributors at least

PRS touching the wallet payment flows should ideally be labelled with internalQA as the wallet payment flow cannot be tested otherwise easily, not by the contributors at least

Ah thanks, I forgot that the InternalQa label works for the App repo 👍


path-to-regexp v2.0.0

See https://github.com/pillarjs/path-to-regexp/blob/master/History.md#200--2017-08-23 for details on the changes to path-to-regexp
The biggest change is that instead of using "/" to match all pathnames, we should use "". This is because / and /nested are siblings (whereas /nested and /nested/route are parent/child paths).
Another change with this is that the wildcard route  is no longer supported. Instead, (.*) should now be used instead.
Finally, the trailing slash on a segment is now enforced (/test/ no longer matches /test).
Moving discussion here from #5469.

Hmm, I like the trailing slash changes but I'm not a fan of using the empty string to match /. I'd like to stay on 1.7 for now until I can dive further into this.

This should probably wait for React Router v5, and path-to-regexp v1 works well, so no rush to get this merged.

Should we set up a next branch?

I'm going to close this for now because I'm not actually convinced that path-to-regexp v2 is better than v1. There are a couple things with v2 that are less straight forward (trailing delimiters, no more *) and the only API change that would be used by RR would be endsWith, but since we're already only matching against location.pathname, that should never be necessary.
Maybe at some point it will make sense to switch versions, but for now I think that 1.7.0 is good enough.

@mjackson @timdorr, should you guys update the docs (on github), to say that you use path-to-regexp ^1.7.0 instead of just saying

Any valid URL path that path-to-regexp understands.

It will make it clearer for people since path-to-regexp broke compatibility with older versions.

@pshrmn okay, I'll do a PR. Just wanted to check first. Thanks!

Made the PR at #6117.


Postproc option for reconstruct, and fixed isalnum bug with unicode identifiers

Why not
if post_proc:
    x = post_proc(x)

?

Also, where can I find a list of all available categories? Python docs aren't being helpful.

@erezsh : Good idea! For the identifier unicode class categories, they are buried deep in a PEP from 2007: https://www.python.org/dev/peps/pep-3131/#specification-of-language-changes

Thanks!

Thank you!


🐛 totable

evaluate the string when table contains {} element. cannot work on latex symbols

need to update vignette for the functional quote << >>


Vyper support

Not able to fuzz: https://etherscan.io/address/0x847ee1227A9900B73aEeb3a47fAc92c52FD54ed9#code

vyper is supported now

This issue can be closed, fuzzing with vyper is supported. Documenting this support in the README could be useful.