Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run"

Reverts flutter/flutter#46838

New error in basic_material_app_ios__compile:
Executing: /Users/flutter/.cocoon/flutter/bin/flutter build aot -v --extra-gen-snapshot-options=--print_snapshot_sizes --release --no-pub --target-platform ios in /var/folders/ds/_jtxgnxx0qldrlbw4dsk9ngh0000gn/T/sample_flutter_app
2019-12-12T17:16:30.301781: stdout: [  +23 ms] executing: [/Users/flutter/.cocoon/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
2019-12-12T17:16:30.325951: stdout: [  +33 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
2019-12-12T17:16:30.326032: stdout: [        ] 7a7e2bb247c98456861de112cc10e57a559eef82
2019-12-12T17:16:30.326468: stdout: [        ] executing: [/Users/flutter/.cocoon/flutter/] git describe --match v*.*.* --first-parent --long --tags
2019-12-12T17:16:30.342992: stdout: [  +16 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
stdout: [        ] v1.13.1-23-g7a7e2bb24
2019-12-12T17:16:30.350919: stdout: [   +7 ms] executing: [/Users/flutter/.cocoon/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
2019-12-12T17:16:30.359525: stdout: [   +8 ms] Exit code 128 from: git rev-parse --abbrev-ref --symbolic @{u}
stdout: [        ] fatal: HEAD does not point to a branch
2019-12-12T17:16:30.369992: stdout: [  +10 ms] executing: [/Users/flutter/.cocoon/flutter/] git rev-parse --abbrev-ref HEAD
2019-12-12T17:16:30.378319: stdout: [   +8 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
stdout: [        ] HEAD
2019-12-12T17:16:30.400304: stdout: [  +21 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
stdout: [        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
stdout: [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
2019-12-12T17:16:30.400443: stdout: [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
stdout: [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
2019-12-12T17:16:30.403084: stdout: [   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
stdout: [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
stdout: [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
2019-12-12T17:16:30.403233: stdout: [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
2019-12-12T17:16:30.403288: stdout: [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
2019-12-12T17:16:30.403326: stdout: [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
2019-12-12T17:16:30.403362: stdout: [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
2019-12-12T17:16:30.409748: stdout: [   +6 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
stdout: [        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
stdout: [        ] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
2019-12-12T17:16:30.409831: stdout: [        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
stdout: [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
2019-12-12T17:16:30.412668: stdout: [   +2 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
stdout: [        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
stdout: [        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
2019-12-12T17:16:30.412742: stdout: [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
2019-12-12T17:16:30.412779: stdout: [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
2019-12-12T17:16:30.412869: stdout: [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
2019-12-12T17:16:30.412955: stdout: [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
2019-12-12T17:16:30.413022: stdout: [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
2019-12-12T17:16:30.413070: stdout: [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
2019-12-12T17:16:30.413162: stdout: [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
stdout: [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
2019-12-12T17:16:30.413229: stdout: [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
2019-12-12T17:16:30.413298: stdout: [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
2019-12-12T17:16:30.413351: stdout: [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
2019-12-12T17:16:30.413389: stdout: [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
2019-12-12T17:16:30.413441: stdout: [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
2019-12-12T17:16:30.424273: stdout: [   +9 ms] Building AOT snapshot in release mode (ios-release)...
2019-12-12T17:16:30.461790: stdout: [  +38 ms] Compiling Dart to kernel: /private/var/folders/ds/_jtxgnxx0qldrlbw4dsk9ngh0000gn/T/sample_flutter_app/lib/main.dart
2019-12-12T17:16:30.472415: stdout: [  +10 ms] /Users/flutter/.cocoon/flutter/bin/cache/dart-sdk/bin/dart /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/darwin-x64/frontend_server.dart.snapshot --sdk-root /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk_product/ --target=flutter -Ddart.developer.causal_async_stacks=true -Ddart.vm.profile=false -Ddart.vm.product=true --bytecode-options=source-positions --aot --tfa --packages .packages --output-dill build/aot/app.dill --depfile build/aot/kernel_compile.d package:sample_flutter_app/main.dart
2019-12-12T17:16:37.609132: stdout: [+7136 ms] Extra gen_snapshot options: [--print_snapshot_sizes]
2019-12-12T17:16:37.612075: stdout: [   +3 ms] executing: /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/gen_snapshot_arm64 --causal_async_stacks --deterministic --print_snapshot_sizes --snapshot_kind=app-aot-assembly --assembly=build/aot/arm64/snapshot_assembly.S build/aot/app.dill
2019-12-12T17:16:42.009458: stdout: [+4397 ms] VMIsolate(CodeSize): 4755
stdout: [        ] Isolate(CodeSize): 723206
stdout: [        ] ReadOnlyData(CodeSize): 900192
2019-12-12T17:16:42.009594: stdout: [        ] Instructions(CodeSize): 2461376
2019-12-12T17:16:42.009664: stdout: [        ] Total(CodeSize): 4089529
2019-12-12T17:16:42.144896: stdout: [ +135 ms] Building App.framework for arm64...
2019-12-12T17:16:42.146588: stdout: [   +1 ms] executing: xcrun --sdk iphoneos --show-sdk-path
2019-12-12T17:16:42.153464: stdout: [   +6 ms] /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.0.sdk
2019-12-12T17:16:42.153737: stdout: [        ] executing: xcrun cc -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.0.sdk -c build/aot/arm64/snapshot_assembly.S -o build/aot/arm64/snapshot_assembly.o
2019-12-12T17:16:43.197703: stdout: [+1043 ms] executing: xcrun clang -arch arm64 -miphoneos-version-min=8.0 -dynamiclib -Xlinker -rpath -Xlinker @executable_path/Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -install_name @rpath/App.framework/App -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.0.sdk -o build/aot/arm64/App.framework/App build/aot/arm64/snapshot_assembly.o
2019-12-12T17:16:43.254689: stdout: [  +57 ms] executing: lipo build/aot/arm64/App.framework/App -create -output build/aot/App.framework/App
2019-12-12T17:16:43.278793: stdout: [  +24 ms] Building AOT snapshot in release mode (ios-release)... (completed in 12.8s)
2019-12-12T17:16:43.278982: stdout: [        ] Built to build/aot/.
2019-12-12T17:16:43.280381: stdout: [   +1 ms] "flutter aot" took 12,913ms.
2019-12-12T17:16:43.293701: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 0
2019-12-12T17:16:43.302800:
Executing: /Users/flutter/.cocoon/flutter/bin/flutter clean in /var/folders/ds/_jtxgnxx0qldrlbw4dsk9ngh0000gn/T/sample_flutter_app
2019-12-12T17:16:45.706116: stdout: Cleaning Xcode workspace...                                         1.9s
2019-12-12T17:16:45.714402: stdout: Deleting build...                                                    4ms
2019-12-12T17:16:45.731099: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 0
2019-12-12T17:16:45.731402:
Executing: /Users/flutter/.cocoon/flutter/bin/flutter build ios --release in /var/folders/ds/_jtxgnxx0qldrlbw4dsk9ngh0000gn/T/sample_flutter_app
2019-12-12T17:16:47.538630: stdout: Building com.example.sampleFlutterApp for device (ios-release)...
2019-12-12T17:16:48.430201: stdout: Automatically signing iOS for device deployment using specified development team in Xcode project: S8QB4VV633
2019-12-12T17:17:26.412411: stdout: Running Xcode build...
2019-12-12T17:17:26.420698: stdout: Xcode build done.                                           37.9s
2019-12-12T17:17:27.951026: stdout: Built /private/var/folders/ds/_jtxgnxx0qldrlbw4dsk9ngh0000gn/T/sample_flutter_app/build/ios/iphoneos/sample_flutter_app.app.
2019-12-12T17:17:27.971224: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 0
2019-12-12T17:17:27.971320:
Executing: tar -zcf build/app.ipa /var/folders/ds/_jtxgnxx0qldrlbw4dsk9ngh0000gn/T/sample_flutter_app/build/ios/Release-iphoneos/Runner.app/ in /var/folders/ds/_jtxgnxx0qldrlbw4dsk9ngh0000gn/T/sample_flutter_app
2019-12-12T17:17:27.976965: stderr: tar: /var/folders/ds/_jtxgnxx0qldrlbw4dsk9ngh0000gn/T/sample_flutter_app/build/ios/Release-iphoneos/Runner.app: Cannot stat: No such file or directory
stderr: tar: Error exit delayed from previous errors.
2019-12-12T17:17:27.977224: "tar" exit code: 1
2019-12-12T17:17:27.984474: Task failed: Executable "tar" failed with exit code 1.2019-12-12T17:17:27.984718:

Stack trace:
2019-12-12T17:17:28.000115: package:flutter_devicelab/framework/utils.dart 84:3        fail
package:flutter_devicelab/framework/utils.dart 327:5       exec
===== asynchronous gap ===========================
dart:async                                                 _asyncErrorWrapperHelper
package:flutter_devicelab/framework/framework.dart         _TaskRunner._performTask.
package:stack_trace                                        Chain.capture
package:flutter_devicelab/framework/framework.dart 154:11  _TaskRunner._performTask
package:flutter_devicelab/framework/framework.dart 88:41   _TaskRunner.run

log.txt


Updating README

:tada: This PR is included in version 2.8.0 :tada:
Your semantic-release bot :package::rocket:


Script Editor: Capitalize results offset by one character

Godot version:
Godot Engine v3.0.2.stable.official
OS/device including version:
Windows 10
Issue description:
The Edit > Convert Case > Capitalize option found in the Script editor is offset by one.
Related https://github.com/godotengine/godot/issues/12927
Steps to reproduce:

Write any pair of words between quotes. Example: "hello godot"
Highlight all written text.
Press Shift+F2 (or use the menu: Edit > Convert Case > Capitalize)
Result should be hello Godot"

Minimal reproduction project:

Here's another gif showing even more weirdness:


43/dashboard skeleton

refactor sidebar, chat interface for dashboard
moved progress bar to sidebar (component communication)
fixed tooltip bug
dashboard styling and data binding, just need to integrate with new API
auto toggling when chatting (hide sidebar in chat)
integrate vue-chart for data visualization

dashboard behaviour when click on toggle button:

when no prediction is made, show sidebar
when the first prediction is made, show dashboard
when user say yes to answer more questions (between two predictions), show sidebar

TODO: integration, unit test

Major work is in sidebar.vue, it is hidden in the changes you need to click on load diff


Leetcode Question Number 50

Leetcode Question Number 50 soultion needs to be added in the repo .
The link for the question is this.
Accepted Languages C++ / JAVA .
You Only need to add the  class Solution in the file.
Make Sure you have read the contributions guidelines before creating an PR.

I want to contribute. Please assign me.


Return Message ID in SMTP response after message

Currently after the DATA command is issued the response always returns as 250 2.0.0 Ok: queued, some systems rely on receiving the SMTP Message ID in the SMTP response for logging purposes.
It would be good if either a custom function could be passed in for generating the SMTP Message ID, or if the Handle function could return a Message ID that will be used in the response.
Ideally the response would be formatted as 250 2.0.0 Ok: queued as <message-id>

A bit of research indicates a wide variety of message ID formats. Do you have a preference?

I think it would be ideal if the Message ID could be returned from one of the handler functions, or a new handler function would be able to be used to pass those details through.
Generally speaking the applications using this library would be the ones managing the Message ID for other purposes (logging, queuing, etc.)

I've added a new handler function type called MsgIDHandler in a branch named "return-message-id". It should behave the same as the regular Handler and print whatever ID is returned, however I haven't written any test coverage yet. Would you mind testing it to see if it fits your needs?

Oh wow thank you for that, it's really appreciated, I've had a quick look and this seems pretty perfect for what I'd need.
My main aim was to integrate this into Mailpit as this was one of the features missing from the project that Mailhog had and it caused some issues with a few applications we have when locally testing them.
I'll try and have a play around with the branch and integrating it into Mailpit sometime this week, thanks again!

@mhale
I've tested this out and it seems to work great from my testing, very easy to just change the existing function to work with this.
Thanks again!

Was there any chance of this getting merged into master at any point @mhale?
My testing from a while ago with it and merging it into Mailpit seemed to work great.

It's in master now, hopefully it still works.

Awesome! Thank you very much!


wallet import and export

Add feature to import and export wallet.
First iteration should just import / export the indy wallet. Next iterations could focus on more interoperable data format
RN indy sdk code already available here: https://github.com/AbsaOSS/rn-indy-sdk/pull/57. Should be merged into indy-sdk-react-native

Hi, @TimoGlastra
Is there any plan when this can be completed?
Thanks


Use the meaningful test data

This PR: fix @ice1000

Can you use an imported Nat?

You can use 0 1 2 literals

Congratulations! You opened #666!


Delete *.dll in Release configuration and keep only *.br

This helps reduce the size of the extensions package by at least 75%
more details: https://docs.microsoft.com/en-us/aspnet/core/blazor/host-and-deploy/webassembly?view=aspnetcore-5.0#compression

Please correct me if I'm wrong, I think the compression support for static hosting needs to be manually fetched and decoded in the JavaScript and not out of the box from Blazor's build process. So if you are using compression then you need to add a postbuild execution to delete the .dll files for your project. If the deletion is done from this package, the standard projects does not have brotli output and loading out of the box, which will cause the application to not load.

Now brotli output will be generated normally. So the output directory will have *.dll as well as *.gz or *.br, and actually at runtime, if we add the scripts described in the doc, we can do without the *.dll files, removing them will help to reduce the package size.
I am curious if it is possible to do the "remove *.dll" and append "decode.js" steps automatically for this project under release configuration.

I guess it is possible, but with .Net 5 I am not seeing brotli files from project build, it is just .dll and .gz. Are you using .Net 6 and is it generating brotli files from project build?

You should run 'publish' to create that files
dotnet publish -o out -c Release

Yeah I think this is a good one to work on. I'll look into supporting publish soon.

This has been added in v0.2.1

Thanks to your hard work, it work very well as I tested. But a small BUG.
https://github.com/mingyaulee/Blazor.BrowserExtension/issues/11


Fixes #2153 - Super admin choose project on invite page

coverage: 94.378% (-0.005%) from 94.383% when pulling dc09d1e56553e1f9a808c2a07043884bd7e3f15f on cody-super-admin-invite into 98102e2ebab8526afb3cfcf56ada65d4d49ec5f3 on main.


WIP: LASB-1997 Package restructure for CrownCourtController/crowncourt

Technical improvement to restructure CrownCourtController and all directly associated classes into the new package gov.uk.courtdata.crowncourt and where appropriate gov.uk.courtdata.common
What
Link to story
Package restructure, move CrownCourtController and associated classes into the new package crowncourt
Any other dependancy classes which are used in multiple places across functional areas have been moved to the appropriate sub-package of gov.uk.courtdata.eform.common
i.e. ErrorDTO.java moved from gov.uk.courtdata.dto to gov.uk.courtdata.common.dto as it has usages across multiple functional areas.
Checklist
Before you ask people to review this PR:

[ ] Tests should be passing: ./gradlew test
[ ] Github should not be reporting conflicts; you should have recently run git rebase main.
[ ] Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
[ ] You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
[ ] You should have checked that the commit messages say why the change was made.

I'm not sure if this is the PR for refactoring. If so then quite a bit more could be done.
There are still controllers in the root controller folder. There are Helper classes similar to Service classes which can be renamed for consistency.  The DTO's, Entities, Repo's could be kept commonly at the root as against under the functional packages. There are common repo classes which are still in one individual folder etc etc
If this Story and PR are intended to address only the package structure for crowncourt and not the structure for the whole maat court data api then ignore the comments

All DTO's and Entity's are kept commonly under the respective root folder. Is there a need to create a new common package with dto folder?

I'm not sure if this is the PR for refactoring. If so then quite a bit more could be done.
There are still controllers in the root controller folder. There are Helper classes similar to Service classes which can be renamed for consistency. The DTO's, Entities, Repo's could be kept commonly at the root as against under the functional packages. There are common repo classes which are still in one individual folder etc etc
If this Story and PR are intended to address only the package structure for crowncourt and not the structure for the whole maat court data api then ignore the comments

Hi @muthusubra this PR is only a small part of what is required to be done, this 'small' PR has 43 files changed. In order to be kind to PR reviewers and minimise merge conflicts I have broken up the overall task into 14 independent sub-tasks.
Please take a look at the parent ticket for more details and acceptance criteria etc. https://dsdmoj.atlassian.net/browse/LASB-1971

Following up on my comments, this common pattern is not implemented in any of our other projects, so why are we doing it here? Ideally, I'd suggest that we should have a structure on how the project should look.
I just went through the PR and two bits emerged that moved the ERRORDTO to a common and moved around some of the model classes to a specific package.
Again second to a Muthu's comment. However, this change looks great as a vanity metric but I can't see much value in moving code around.

Following up on my comments, this common pattern is not implemented in any of our other projects, so why are we doing it here? Ideally, I'd suggest that we should have a structure on how the project should look.
I just went through the PR and two bits emerged that moved the ERRORDTO to a common and moved around some of the model classes to a specific package.
Again second to a Muthu's comment. However, this change looks great as a vanity metric but I can't see much value in moving code around.

Ok, I appreciate your feedback, we shall soon be deciding on a package structure for MAAT API as discussed in the meeting this morning

Following our discussion the outcome is that we will decide on a package structure via a vote in Slack.
Muthu & Sriram can you please send over a couple sentence description of your package structure proposals so they can can included in the vote.


Minimadness makes player fall in the void

Describe the bug
Minimadness sometimes makes the player phase through the floor
To Reproduce
Use the command and wait
Expected behavior
Not falling through the map back to hell
Plugin details:

EXILED version:8.11.0
Plugin version:1.2.0

#8


PRODX-21857 Added one more status for EC.fetchingData

Since our Spinner component doesn't suite to the table, I added one more status 'Updating' during fetchingData event.
In my opinion, spinner or animation would be better, but it's need more work from Lens/designers side. Open to proposals
Also we hide accordion arrow til we get namespaces (in first time)

Thanks for addressing these two issues!
So with this change, when Lens loads and there's a Cloud in storage, the status column will go from "Disconnected -> Connecting... -> Connected -> Updating... -> Connected", and then 5 minutes later, when we do a scheduled fetch of that Cloud's state, the status column will go from "Connected -> Updating... -> Connected"?

Yes. But after Connecting we see Updating without  'Connected' step. It's related to how and at what moment we get statuses from EC

Note that on Slack, there's a recommendation/expectation/assumption from John that "Disconnected" label is gray, not red. Could you update that before you merge? Use a gray from Lens that's bright enough that provides enough contrast so that the word is easily read.

Note that on Slack, there's a recommendation/expectation/assumption from John that "Disconnected" label is gray, not red. Could you update that before you merge? Use a gray from Lens that's bright enough that provides enough contrast so that the word is easily read.

Changed to gray. Notice that in figma we have it red. Probably need to be updated. FYI @mgorczyca-mirantis


Forecasts not updated properly on cold boot and reset.

Whenever I cold boot my setup or reset it, only a few number of forecasts are updated, with the rest appearing blank as shown below in attached pictures

However, after one or two updates of the forecasts after the specified UPDATE_INTERVAL_SECS, the issue gets resolved sometimes.
Can someone please point me to what I am doing wrong?

I just built my own yesterday and have the exact same issue.

Can someone please point me to what I am doing wrong?

Maybe it's not you but the ESP8266 Arduino Core. Which version are you using? https://docs.thingpulse.com/guides/wifi-color-display-kit/#install-the-esp8266-toolchain

I am using version, 2.6.3, of the ESP8266 Arduino Core, which happens to be the latest, as of now.
And yes, I am using the version 2.0.0 of the ESP8266 Weather Station library, as I could see from the Arduino Library Manager.
Plus, I want to add that that I tested the WeatherStationDemo example of the ESP8266 Weather Station library with my 0.96" I2C OLED display and observed similar anomalous behavior, wherein forecasts were not updating properly.

Thanks for that extra information. I guess the behavior is not surprising considering that the parsing & mapping of the data happens in the weather station library. -> I'll transfer the issue


Breakpoint Resolution falls back to enclosing scope in nested expressions when clicking in margin

This is with RC3 + the VSIX installed.

Clone https://github.com/bryanedds/Nu
Build it
Open AssetGraph.fs and go to line 139 under the buildAssets5 function.
Set a breakpoint there by clicking in the margin.

Expected: Breakpoint set at line 139, let inputFileSubpath = asset.FilePath.
Actual: Breakpoint is set at the top of the for..do loop.

Note that it also fails inside any block inside the match expressions inside of a lambda in loadAssetsFromPackageDescriptor4.

Note: I don't think this is a regression.  In fact, in the current bits breakpoint resolution is improved in many cases.

fixed with #2815

@cartermp @KevinRansom this can be closed now :_


spriteFilename doesn't work when using rule.oneOf setup

Do you want to request a feature, report a bug or ask a question?
Bug (I guess)
What is the current behavior?
Option spriteFilename doesn't work (fallback to default sprite.svg) when using a specific webpack's rules configuration (explained below).
What is the expected behavior?
Option spriteFilename should always work
Please tell us about your environment:

Node.js version: 8.3.0
webpack version: 3.5.6
svg-sprite-loader version: 3.2.5
OS type & version: Windows 10

Reproduction link:
https://github.com/sqal/svg-sprite-loader-bug-repro/blob/master/webpack.config.js
In my project i keep all of my loaders rules in Rule.oneOf object, similar to how create-react-app does it. But I found out there's one problem with this setup and spriteFilename option - it just doesn't work. To check this out please do:

clone my repo
npm run build -  everything works correctly
now try with oneOf setup, so set USE_ONEOF_SETUP var to true - now sprite is being generated with default sprite.svg name

Is there something that I am doing wrong or is it the plugin bug? Thanks for looking into this :)

@kisenka this issue is solved in v3.2.6, you can close it

@kisenka @CXHtml Can you publish v3.2.6 tp npm? I think my build is suffering from this issue as well.

@soluml sorry, I forgot to publish it :) Now it's published

Better late then never :)


add informal german 'du' as new language

Facebook and others address their users with the german "Du" instead of the mor polite variant "Sie". This PR adds a new language "de-DU".
To use just modify the language in the main configuration file web.php
$config = [
    ...
    'language' => 'de-DU',
    ....
];

Thank you!


Remove use of testify mock and testify vendored lib

Remove the use of testify for mocking stuff (and does a by-hand mock that is not that pretty to look at :sweat_smile:).
Replace #16737 (@jfrazelle) and follow #16733 (very good work from @MHBauer).
Relates (and maybe closes (?)) #16633.
/cc @icecrime @LK4D4 @calavera
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

I personally like FakeStore mock you did here

@vdemeester I would not give me too much credit. I did the lazy thing and used gofmt to do most of the transformations.
I also like the FakeStore. I definitely learned something here. Thanks.

LGTM

LGTM

What's the point of getting rid of testify?
This PR basically makes the tests entirely useless as it's not testing anything anymore.

@aluzzardi the point is explained there #16633 "pkg/discovery uses stretchr/testify for testing, which looks weird, because we don't use any framework for unit-tests and use go-check for integration tests.".
That said, I don't get why you are saying that "it's not testing anything anymore".. It just replace the mock from testify by a simple/naive mock (there was no need for more complicated with the given code). It still tests the same things that was tested before. The only missing piece would be the last AssertExpectation but the behaviour of that could be done too.
Seeing https://github.com/docker/docker/pull/16644#issuecomment-145684214, I get why it can be bothersome to have removed testify though, because libkv mock store is not usable anymore and extra work is needed to mock..
@LK4D4 @calavera @jfrazelle any opinion on that ?


fix broken rest_basic_auth example

I'm not sure if I merged something or fixed myself but the code has this now. Thanks!


Fix malformed links in DevOps section

Fixes #3691

Learn Build status updates of commit 91c4840:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/containers/aks-microservices/aks-microservices-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Active Storage: method_missing': undefined method has_one_attached'

Hello guys, I'm facing a issue while using active storage with rails_admin.
What's happening is that I've model called Product which should have a image. I've installed active storage by running the following commands:
rails active_storage:install
db:migrate

After that, I've added a new attibute on my Model as:
has_one_attached :image

However, rails does not recognize it as a method:

class:Product'
/Users/username/.rvm/gems/ruby-2.5.1/gems/activerecord-5.2.0/lib/active_record/dynamic_matchers.rb:22:in method_missing': undefined method has_one_attached' for Product (call 'Product.connection' to establish a connection):Class (NoMethodError)

I've created a application from the scratch without rails_admin and it worked fine.
Note: I'm using rails 5.2.0 and ruby 2.5.1
Any ideas?

I think I've had the same issue. I was trying to configure model inside rails_admin initializer using config.model Product do ... end. Instead it should've been config.model 'Product' do ... end. The model name must be quoted.

@dmilisic thank you very much! It saved me a lot of time. :)
But, any idea why it should be quoted?

Initalizers are run before your application code runs. Models are interpreted only when needed (on a firs request perhaps). But if you reference a model in the initializer using a constant ie. configure Product do, the model has to be interpreted before the rest of your initializer code and other initalizers. Configuring your models using string configure 'Product' do works well with rails_admin.
It seems that ActiveStorage has its own initalizer which waits ActiveRecord to load before it inserts its macros. Perhaps rails_admin.rb initalizer is executed before active_storage.attached initalizer ?

If you don't use require "rails/all', you'll need to require "active_storage" in your application.rb file

Same issue here, is there any fix?

declaring this on model solved the problem for me
`class User < ApplicationRecord
has_one_attached :avatar
rails_admin do
field :avatar, :active_storage
end
end`
reference https://github.com/sferik/rails_admin/issues/2990#issuecomment-378220331

I'm having this problem too. Here's a strange thing:
if I comment out has_one_attached :avatar and start the server, it starts fine. Then I can uncomment has_one_attached :avatar, save the file and load the application, ActiveStorage functions.
But I don't want to have to comment out all active storage functions each time I start the server.
Rails version = 5.2.1
Ruby version = 2.4.4
Here's the model:
class User < ApplicationRecord
  has_person_name

  rolify
  # Include default devise modules. Others available are:
  # :confirmable, :lockable, :timeoutable, :trackable and :omniauthable
  devise :database_authenticatable, :registerable,
         :recoverable, :rememberable, :validatable

  # For reasons I can't understand. This doesn't work here. I'm developing it in organizations for the time being.
  has_one_attached :avatar
  has_and_belongs_to_many :organizations
end

Here's the application.rb file:
require_relative 'boot'
require 'rails/all'

# Require the gems listed in Gemfile, including any gems
# you've limited to :test, :development, or :production.
Bundler.require(*Rails.groups)

module *ProjectName*
  class Application < Rails::Application
    # Initialize configuration defaults for originally generated Rails version.
    config.load_defaults 5.2

    config.generators do |g|
      g.orm                 :active_record
      g.template_engine     :erb
      g.test_framework      false
      g.stylesheets         false
      g.javascripts         false
      g.helper              false
      g.scaffold_stylesheet false
    end
  end
end

Here's the Error Message:
$ rails s
/Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/pry-rails-0.3.6/lib/pry-rails/prompt.rb:36: warning: constant Pry::Prompt::MAP is deprecated
=> Booting Puma
=> Rails 5.2.1 application starting in development
=> Run `rails server -h` for more startup options
Exiting
/Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activerecord-5.2.1/lib/active_record/dynamic_matchers.rb:22:in `method_missing': undefined method `has_one_attached' for User (call 'User.connection' to establish a connection):Class (NoMethodError)
Did you mean?  has_person_name
	from /Users/silverSheep/Desktop/code/withBetter/projectName/app/models/user.rb:3:in `<class:User>'
	from /Users/silverSheep/Desktop/code/withBetter/projectName/app/models/user.rb:1:in `<main>'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:50:in `load'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:50:in `load'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:472:in `block in load_file'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:657:in `new_constants_in'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:471:in `load_file'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:369:in `block in require_or_load'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:37:in `block in load_interlock'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies/interlock.rb:14:in `block in loading'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies/interlock.rb:13:in `loading'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:37:in `load_interlock'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:352:in `require_or_load'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:46:in `block in require_or_load'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:45:in `require_or_load'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:506:in `load_missing_constant'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:58:in `block in load_missing_constant'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:57:in `load_missing_constant'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:193:in `const_missing'
	from /Users/silverSheep/.rvm/gems/ruby-2.4.4/gems/activesupport-

...(shortened for brevity)....

	from bin/rails:3:in `load'
	from bin/rails:3:in `<main>'

@tteurs - declaring it on the model like you did above didn't help.
@dmilisic  - Where did you put config.model 'Product' do ... end  to make it work? What was inside that block?

Full stack trace might be helpful. The problem might be in initalizers. I had rails_admin.rb initializer which loaded my Product model. Models should not be loaded from initializers - it breaks ActiveStorage helpers.
@iarobinson take a look your initializers (rails_admin, devise, ...). If the User model is references as a constant, it triggers loading of your User model - and breaks ActiveStorage (models are usually loaded after all initializers).
I replaced the config.model Product with config.model 'Product' in the rails_admin.rb initalizer - that solved my issue.

Hey guys,
Not sure if this is related, but thought I might bring it up -- https://github.com/Shopify/bootsnap/issues/218

I just ran into this and the bug @sideshowbandana mentions, Shopify/bootsnap#218, was the cause.
https://github.com/Shopify/bootsnap/issues/218#issuecomment-473548543

E solve my issue removing all configuration model from initializer( rails_admin.rb ) and putting each configuration in the respective model.

Fixed by https://github.com/Shopify/bootsnap/pull/249

I'm getting this error too, but in my case is on Papertrail configuration:
  config.audit_with :paper_trail, 'User', 'PaperTrail::Version'

The erro message:
`method_missing': undefined method `has_one_attached' for User (call 'User.connection' to establish a connection):Class (NoMethodError)

Full stacktrace
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/dynamic_matchers.rb:22:in `method_missing': undefined method `has_one_attached' for User (call 'User.connection' to establish a connection):Class (NoMethodError)
        from /app/app/models/user.rb:150:in `<class:User>'
        from /app/app/models/user.rb:64:in `<main>'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:511:in `block in load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:702:in `new_constants_in'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:510:in `load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:407:in `block in require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `block in load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:14:in `block in loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:13:in `loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:390:in `require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:48:in `block in require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:47:in `require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:545:in `load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:60:in `block in load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:59:in `load_missing_constant'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:214:in `const_missing'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:582:in `load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:60:in `block in load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:59:in `load_missing_constant'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:214:in `const_missing'
        from /app/app/models/subscription.rb:121:in `<class:Subscription>'
        from /app/app/models/subscription.rb:52:in `<main>'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:511:in `block in load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:702:in `new_constants_in'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:510:in `load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:407:in `block in require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `block in load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:14:in `block in loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:13:in `loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:390:in `require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:48:in `block in require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:47:in `require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:545:in `load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:60:in `block in load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:59:in `load_missing_constant'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:214:in `const_missing'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:582:in `load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:60:in `block in load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:59:in `load_missing_constant'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:214:in `const_missing'
        from /app/app/helpers/subscriptions_helper.rb:46:in `<module:SubscriptionsHelper>'
        from /app/app/helpers/subscriptions_helper.rb:4:in `<main>'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:511:in `block in load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:702:in `new_constants_in'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:510:in `load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:407:in `block in require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `block in load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:14:in `block in loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:13:in `loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:390:in `require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:48:in `block in require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:47:in `require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:368:in `depend_on'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:85:in `depend_on'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:280:in `require_dependency'
        from /usr/local/bundle/gems/actionpack-6.0.0/lib/abstract_controller/helpers.rb:149:in `block in modules_for_helpers'
        from /usr/local/bundle/gems/actionpack-6.0.0/lib/abstract_controller/helpers.rb:144:in `map!'
        from /usr/local/bundle/gems/actionpack-6.0.0/lib/abstract_controller/helpers.rb:144:in `modules_for_helpers'
        from /usr/local/bundle/gems/actionpack-6.0.0/lib/action_controller/metal/helpers.rb:94:in `modules_for_helpers'
        from /usr/local/bundle/gems/actionpack-6.0.0/lib/abstract_controller/helpers.rb:108:in `helper'
        from /usr/local/bundle/gems/actionpack-6.0.0/lib/action_controller/railties/helpers.rb:19:in `inherited'
        from /app/app/controllers/rails_admin_base_controller.rb:3:in `<main>'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:511:in `block in load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:702:in `new_constants_in'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:510:in `load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:407:in `block in require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `block in load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:14:in `block in loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:13:in `loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:390:in `require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:48:in `block in require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:47:in `require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:545:in `load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:60:in `block in load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:59:in `load_missing_constant'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:214:in `const_missing'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/inflector/methods.rb:282:in `const_get'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/inflector/methods.rb:282:in `block in constantize'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/inflector/methods.rb:280:in `each'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/inflector/methods.rb:280:in `inject'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/inflector/methods.rb:280:in `constantize'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/core_ext/string/inflections.rb:68:in `constantize'
        from /usr/local/bundle/gems/rails_admin-2.0.0/app/controllers/rails_admin/application_controller.rb:13:in `<module:RailsAdmin>'
        from /usr/local/bundle/gems/rails_admin-2.0.0/app/controllers/rails_admin/application_controller.rb:3:in `<main>'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:511:in `block in load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:702:in `new_constants_in'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:510:in `load_file'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:407:in `block in require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `block in load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:14:in `block in loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies/interlock.rb:13:in `loading'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:40:in `load_interlock'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:390:in `require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:48:in `block in require_or_load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:47:in `require_or_load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:545:in `load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:60:in `block in load_missing_constant'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/active_support.rb:59:in `load_missing_constant'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:214:in `const_missing'
        from /usr/local/bundle/gems/rails_admin-2.0.0/lib/rails_admin/extensions/paper_trail/auditing_adapter.rb:55:in `setup'
        from /usr/local/bundle/gems/rails_admin-2.0.0/lib/rails_admin/config.rb:121:in `audit_with'
        from /app/config/initializers/rails_admin.rb:18:in `block in <main>'
        from /usr/local/bundle/gems/rails_admin-2.0.0/lib/rails_admin.rb:31:in `config'
        from /app/config/initializers/rails_admin.rb:2:in `<main>'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:319:in `block in load'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:291:in `load_dependency'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:319:in `load'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/engine.rb:667:in `block in load_config_initializer'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/notifications.rb:182:in `instrument'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/engine.rb:666:in `load_config_initializer'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/engine.rb:624:in `block (2 levels) in <class:Engine>'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/engine.rb:623:in `each'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/engine.rb:623:in `block in <class:Engine>'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/initializable.rb:32:in `instance_exec'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/initializable.rb:32:in `run'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/initializable.rb:61:in `block in run_initializers'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:228:in `block in tsort_each'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:422:in `block (2 levels) in each_strongly_connected_component_from'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:431:in `each_strongly_connected_component_from'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:421:in `block in each_strongly_connected_component_from'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/initializable.rb:50:in `each'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/initializable.rb:50:in `tsort_each_child'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:415:in `call'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:415:in `each_strongly_connected_component_from'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:349:in `block in each_strongly_connected_component'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:347:in `each'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:347:in `call'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:347:in `each_strongly_connected_component'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:226:in `tsort_each'
        from /usr/local/lib/ruby/2.6.0/tsort.rb:205:in `tsort_each'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/initializable.rb:60:in `run_initializers'
        from /usr/local/bundle/gems/railties-6.0.0/lib/rails/application.rb:363:in `initialize!'
        from /app/config/environment.rb:6:in `<main>'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi'
        from /usr/local/bundle/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `block in require'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:291:in `load_dependency'
        from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require'
        from /usr/local/bundle/gems/spring-2.1.0/lib/spring/application.rb:106:in `preload'
        from /usr/local/bundle/gems/spring-2.1.0/lib/spring/application.rb:157:in `serve'
        from /usr/local/bundle/gems/spring-2.1.0/lib/spring/application.rb:145:in `block in run'
        from /usr/local/bundle/gems/spring-2.1.0/lib/spring/application.rb:139:in `loop'
        from /usr/local/bundle/gems/spring-2.1.0/lib/spring/application.rb:139:in `run'
        from /usr/local/bundle/gems/spring-2.1.0/lib/spring/application/boot.rb:19:in `<top (required)>'
        from /usr/local/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
        from /usr/local/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
        from -e:1:in `<main>'

Any ideas in how to solve this?

Can you post the code of your rails_admin initializer? Or perhaps line 18?

Line 18 it is the papertrail configuration:
  config.audit_with :paper_trail, 'User', 'PaperTrail::Version'

@dmilisic thank you for the support! We have managed to solve the problem. The Subscription model was calling a constant defined in the User model and then make the User be load before has_one_attached creation (I think!?). From the previously stacktrace:
...
from /usr/local/bundle/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:214:in `const_missing'
from /app/app/models/subscription.rb:121:in `<class:Subscription>'
...

So we just copy the constant to the Subscription class and then it worked.

Great to hear you managed to solve this issue. But the question remains: why was even Subscription model loaded (perhaps through SubscriptionsHelper)? Are they loaded from the rails_admin initializer?

perhaps through SubscriptionsHelper
Yes, it use a constant from Subscription.

Are they loaded from the rails_admin initializer?
Not directly at least. Maybe all helpers are load before models!?

@dmilisic https://github.com/sferik/rails_admin/issues/3025#issuecomment-392513722
Thanks! Works for me. You did my day.

I ignored this thread because I thought it would not solve my issue. Turns out I'm completely wrong. Thank you so much! @dmilisic

thanks a lot @dmilisic, your solution to use a string instead of a constant helped me a lot!!

At least up to <IP_ADDRESS>, ActiveStorage seems to initialize and inject its methods into ActiveRecord after Rails config/initializers are loaded.
If any initializer uses any model calling ActiveStorage macros, as has_one_attached or has_many_attached, those methods are missing by then.
For example, if you have a User model using has_one_attached :image , and you use User as your Devise model, Device initializer will refer User, and when User is loaded the method has_one_attached will be missing.
I added this code, taken from active_storage/engine, at the end of config/application.rb, and it worked for me.
# config/application.rb
require "active_storage/attached"
ActiveSupport.on_load(:active_record) do
  extend ActiveStorage::Attached::Macros
end

fwiw, none of the responses here solved my issue. What did work however was realizing I had incidentally commented out the AWS access key & secret from storage.yml 🤦
amazon:
  service: S3
  # access_key_id: <%= Rails.application.credentials.dig(:aws, :access_key_id) %>
  # secret_access_key: <%= Rails.application.credentials.dig(:aws, :secret_access_key) %>
  region: us-east-1
  bucket: <%= S3_BUCKET %>

As soon as I uncommented these 2 lines, the error was resolved.  🎉


5.2.x

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.7 out of 8 committers have signed the CLA.:white_check_mark: mmoayyed:white_check_mark: auxepaul:white_check_mark: fmartelli:white_check_mark: sbearcsiro:white_check_mark: tsschmidt:white_check_mark: williame-uah:white_check_mark: swlyons:x: leleujYou have signed the CLA already but the status is still pending? Let us recheck it.


Bump plugin dependencies to <IP_ADDRESS>

Signed-off-by: Tyler Ohlsen<EMAIL_ADDRESS>Description
Bumps the versions by removing the rc1 qualifier of OpenSearch, common-utils, and job-scheduler dependencies.
Issues Resolved
Resolves #109
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #114 (9bd3cbc) into main (73a666a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #114      +/-   ##
============================================
- Coverage     79.38%   79.34%   -0.04%
+ Complexity     2696     2692       -4
============================================
  Files           243      243
  Lines         11132    11132
  Branches       1014     1014
============================================
- Hits           8837     8833       -4
- Misses         1882     1883       +1
- Partials        413      416       +3

Flag
Coverage Δ

plugin
79.34% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/main/java/org/opensearch/ad/model/ADTask.java
95.31% <0.00%> (-2.82%)
:arrow_down:

.../opensearch/ad/cluster/ADClusterEventListener.java
92.00% <0.00%> (-2.00%)
:arrow_down:

...ain/java/org/opensearch/ad/task/ADTaskManager.java
72.99% <0.00%> (-0.23%)
:arrow_down:

...java/org/opensearch/ad/task/ADBatchTaskRunner.java
87.82% <0.00%> (ø)

...opensearch/ad/indices/AnomalyDetectionIndices.java
51.72% <0.00%> (+0.31%)
:arrow_up:

.../main/java/org/opensearch/ad/cluster/HashRing.java
84.21% <0.00%> (+5.26%)
:arrow_up:

...port/SearchAnomalyDetectorInfoTransportAction.java
63.63% <0.00%> (+9.09%)
:arrow_up:


Modify behavior of generics extending string literal union?

Consider the following code:
type Color = 'red' | 'green' | 'blue';

function setBackgroundColor(color: Color) {
    // ...
}

This snippet gives us handy type completions at the ? in setBackgroundColor('?'). This is super useful; prevents errors, saves time, etc. But what if you wanted to support lots of colors.... like say every shade the hardware store sells? Well, currently you have two options:

Add the list of all conceivable colors to the Color union BUT, that's a prohibitive pain.

There are often times I could offer "hints" to  to a consuming developer. Or give a few default values, but allow devs to supply their own. Unfortunately, string | 'Red' | 'Blue' widens to string and the suggestions are lost! So it'd be great if either those completions could be maintained or perhaps if something akin  to the following were possible:
type Color = 'red' | 'green' | 'blue';

function setBackgroundColor<C extends Color>(color: C) {
    // ...
}

setBackgroundColor('r?');
// completion:   red ^
setBackgroundColor('orange');
// no completions:   ^
// but no error thrown either

I just came up against shortfall for like the 3rd time, and figured I ought to open an issue, see how receptive the TS team was to something like this.
Thanks for all the great work! keep it up!

Okay so I just noticed:
from lib.dom.d.ts
addEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, useCapture?: boolean): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;

allows both
document.addEventListener('scroll', undefined);
document.addEventListener('foo', undefined);

foo obviously isn't a DOM event, just some made up value. But it passes! When I copy the type definition to create my own function,
function foo<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, useCapture?: boolean): void;
function foo(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void { };

foo('abort', undefined); // works as expected
foo('bar', undefined); // doesn't work

I've tested this in 2.5.0-dev.20170628 and whatever the typescript playground is running
So it looks like there's some voodoo magic going on behind the scenes to silence the type checker and preserve completions for this special case.  But that just proves my point about! Wouldn't it be a lot less hacky to remove that hidden logic and change the behavior of extending string literal unions?

We get a lot of savings in memory and performance by flatting types, and dropping literal types if they are unioned with string. so somehting like string | 'red' | 'blue' just for completions would be worth it.
changing the meaning of extends is not a possiblity. it is a breaking change, and does not make fit the rest of the language.
You can however use overloads to achieve what you want. and that is what we use for addeventListener and the like, e.g.:
function setBackgroundColor(color: Color);
function setBackgroundColor(color: string);
function setBackgroundColor(color: string) {
...
}

just make sure your string overload is last.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


fix page scroll position rounding error

Description
Precision error occurs during page calculation. This pr fixes it
Related Issues
https://github.com/flutter/flutter/issues/24763
Tests
I added the following tests:
"Page controller can handle rounding issue"
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

I really should add precisionErrorTolerance to the technical debt cost calculation...

I agree this is not pretty, but what you think we should do in this case? I have though about wrap double with a special data type and implement an error tolerance comparison.


Fix s360 in reservation and scheduled action APIs

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@changlong-liu
Can you approve and merge this PR? I received the breaking change approval.
There are two LintDiff errors but we need to ignore them.
Here is the explanation for each of them
Rule GuidUsage :
In this PR, I am updating the existing production documentation version 2021-10-01 to resolve s360 item. Property 'subscriptionId' with format uuid/Guid is an existing property.
The property was simply rearranged after making the property #/definitions/ModernReservationRecommendationProperties/properties/scope a discriminator property.
If scope=single, then the API code returns property subscriptionId in the response. If scope=shared, then subscriptionId is not applicable and is not part of the response. Swagger was not updated accurately to reflect existing API behavior. Hence s360 item got created due to a live traffic validation check.
Rule XmsIdentifierValidation : The validation check is complaining and asking to add property 'id' for the API error response's details array.
We are following ARM error response guidance. As per the documentation, 'ErrorDetail' object doesn't contain 'id'

@changlong-liu Can you approve and merge this PR? I received the breaking change approval.
There are two LintDiff errors but we need to ignore them. Here is the explanation for each of them
Rule GuidUsage : In this PR, I am updating the existing production documentation version 2021-10-01 to resolve s360 item. Property 'subscriptionId' with format uuid/Guid is an existing property. The property was simply rearranged after making the property #/definitions/ModernReservationRecommendationProperties/properties/scope a discriminator property. If scope=single, then the API code returns property subscriptionId in the response. If scope=shared, then subscriptionId is not applicable and is not part of the response. Swagger was not updated accurately to reflect existing API behavior. Hence s360 item got created due to a live traffic validation check.
Rule XmsIdentifierValidation : The validation check is complaining and asking to add property 'id' for the API error response's details array. We are following ARM error response guidance. As per the documentation, 'ErrorDetail' object doesn't contain 'id'

Hi @pednekarpraj , for the XmsIdentifierValidation, the fix is described at https://github.com/Azure/azure-openapi-validator/blob/main/docs/xms-identifier-validation.md#how-to-fix-the-violation. May need to define  "x-ms-identifiers" as empty like here:  https://github.com/malincrist/azure-rest-api-specs/blob/b7aae047337e628a2dfef3e840259098d0382b2c/specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-10-01/consumption.json#L3338

@pednekarpraj  could u add a suppression for the 'GuidUsage' error, by following https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process


Linux builds

Hello jomurgel!
This unsolicited pull request gives Linux users the ability to install the app as a deb or AppImage so it can be launched without npm start and a terminal window hanging. The icon doesn't work quite as expected and I had to update that manually. Works great for me right now apart from the pause media key.
Perhaps in the future someone with a Windows or Mac can add build rules for those platforms.

Hey sorry for the long delay, but this still builds and runs perfectly fine in Windows, so it appears to not have broken anything there. However, my media keys appear to not work on my current keyboard, so I can't test that at the moment.
I saw you added to do of media keys on Linux, do they not currently work? The current implementation simply captures media_play_pause, media_next, and media_prev then actually clicks the media elements.
Unfortunately, this means that it only works when the window is in focus, which is less useful, but from my research implementing it out of focus in electron is not easy, so this was a halfway solution.
If you have media keys on your keyboard, could you test them in Linux? If not I will try it out, I have Ubuntu now, while I didn't before.

I merged in a different PR that appears to have caused quite a conflict.. If you can fix this, it should be good to merge after. I will try to take a look at fixing it myself if you don't get to it, but I don't have time tonight.

The package-lock.json is a mess, so I don't really want to try to fix it using GitHub's web GUI.. the package.json would be an easy fix but since I can't push to your branch I can't fix it locally. Looks like you will have to resolve this before we can merge.

Functionally I think this works, though I was working on an emulator machine, it feels safe to merge this into master pending some conflict resolutions 👍


Issue #2712 - implements closed-form solution for alpha in detect_clearsky

Implements closed-form solution and removes call to scipy.optimize. Previously, the optimization algorithm would fail, but this solution does not have that issue. Thus, one test is also modified, checking that detect_clearsky runs successfully on a range of window_lengths including the one that previously failed.

[x] Closes #2712
[x] I am familiar with the contributing guidelines
[x] Tests added
[x] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.

Can you revert changes in commit https://github.com/pvlib/pvlib-python/pull/2173/commits/9beafb9c7fe17e460f0c6d9dfc3257a1528d2d14? It's difficult to review a PR when there are too many lines that have changes, also cluttering the git blames with style changes is discouraged.

Will do, my apologies. Flake-8 had failed on lines I hadn’t changed, so I
went and over-did it.
On Fri, Aug 23, 2024 at 15:06 Echedey Luis @.***> wrote:

Can you revert changes in commit
https://github.com/pvlib/pvlib-python/pull/2173/commits/9beafb9c7fe17e460f0c6d9dfc3257a1528d2d14?
It's difficult to review a PR when there are too many lines that have
changes, also cluttering the git blames with style changes is discouraged.
—
Reply to this email directly, view it on GitHub
https://github.com/pvlib/pvlib-python/pull/2173#issuecomment-2307658881,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANUIXSUDVBMYUH53HYWVNLZS6B4FAVCNFSM6AAAAABM4SVV72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXGY2TQOBYGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

@agodbehere please let me know if you would like help getting this PR over the finish line.

@cwhanse - the Flake8 test is failing on pre-existing lines that I didn't touch. How should I handle this case? Should I amend those 3 lines to pass Flake8 or should I create a new pull request to fix the style issues?

@agodbehere we'd like to revert the changes in https://github.com/pvlib/pvlib-python/pull/2173/commits/9beafb9c7fe17e460f0c6d9dfc3257a1528d2d14
The CI is configured to only run flake8 on changed lines. I guess you are running flake8 locally and that's why it's flagging all those other style issues. If we fix those, a separate PR is better.

@cwhanse @agodbehere the problem is that the flake8 CI script is made to warn about lint problems on the diff lines; a diff contains a few more lines than those that have been changed, just 3 at the beginning and at the end, sometimes even more. A diff is what you see in the tab above that says "Files".
Even thou the CI fails, I think it is safe to merge the PR with this failed test, since it doesn't impact the rest of the repo. Just keep the changes clear for the reviewers, which is the reason behind reverting that commit.

I have reverted the commit. As expected, Flake8 is still failing. @echedey-ls @cwhanse - would you like to merge as-is?

@agodbehere have you pushed the reverted commit? I don't see the changes here.

Would you be open to that approach?

Yes, certainly. Sorry for the rework.


there might be a bug in method GetFilesWithNtfsIssueWorkaround that prevents all results from being found when searching for files.

I performed IEnumerable manifestFiles = fileSystem.GetFilesWithNtfsIssueWorkaround(@"Windows\servicing\Packages", ".cat", SearchOption.TopDirectoryOnly); and manifestFiles = fileSystem.GetFilesWithNtfsIssueWorkaround(@"Windows\servicing\Packages", ".mum", SearchOption.TopDirectoryOnly); on the same vhd image with 162 files (cat and mum) in the servicing\Packages folder. For the former I got a return result of {string[80]}, and for the latter I got a return result of {string[43]}.
The expected output of both methods should be {string[81]}, so I think this may be a bug, but I haven't found the reason yet.

We are working around a discutils issue here. It would be nice to have said vhd intact for further data analysis as there's an underlying bug in the NTFS code on discutils side.

I cannot add the missing information tag from my phone but I'll be waiting for the file to help trouble shoot this further

Without the required further information we are forced to close this issue within a 4 days window from the notice (label being added).
We would like to thank you for the report nonetheless but we cannot go forward with your issue report without the requested information

Without the required further information we are forced to close this issue within a 1 days window from the notice (label being added).
We would like to thank you for the report nonetheless but we cannot go forward with your issue report without the requested information


Upgrade to Django 1.11

This is required for some tickets; it would also just be good to get access to the latest features and whatnot. Note that this may mean either patching or abandoning floppyforms.

Dupe of #861 lol


Inherit from prog-mode?

Is there a reason why rust-mode doesn't derive from prog-mode? If not could you change it to do so?
I'm asking because it's caused a minor issue for someone trying to use electric-operator with rust-mode, nothing that can't be worked around if necessary though.

It tries to derive from prog-mode if that is available, like:
(defalias 'rust-parent-mode
  (if (fboundp 'prog-mode) 'prog-mode 'fundamental-mode))

[...]

(define-derived-mode rust-mode rust-parent-mode "Rust"
[...]

But when I switch to a rust-mode buffer and evaluate (derived-mode-p 'prog-mode), I get nil.  So, this isn't working as intended.


resize all prismic images, so we aren't loading huge images when we don't need to

The code we use to determine the image src, so we can then provide various sized images in the src-set, wasn't always working for images from prismic.
Sometimes  we were receiving urls with the backslash encoded, which meant we didn't resize the images.

@gestchild could you explain why this worked? Just trying to think how we might test for it.


Question about setup_data in bootloader

Hi,
thanks again for the bootloader, I appreciate the work that has gone into abstracting away all this complexity.
I'm looking to implement a VirtIO block-device driver in my kernel, and for that I was doing some reading here, and it describes the setup_data in the first boot-sector, which is necessary for accessing the device-tree for getting the physical address of the device. I was wondering if this was currently exposed in the BootInfo that's passed to the main function, or if not, if it would be possible for me to add it w/ some guidance?
Thanks!

I do not believe it is. However, you should not need this unless your
on an architecture that doesn't have PCIe. VirtIO devices appear on
the PCIe bus with a vendor ID of 0x1AF4 and a device ID of
0x1000-0x103F. The type of device can be determined by analyzing the
subsystem ID field: 0x01 is a network card, 0x02 is a block device,
0x03 is a console, 0x04 is an entropy source, 0x05 is a memory
balloon, 0x06 is I/O memory, 0x07 is RPMSG, 0x08 is a SCSI host, 0x09
is a 9P transport, and 0x10 is a MAC802.11 WLAN, if memory serves. But
you should, when in doubt, refer to the VirtIO specification:
https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.html
On 3/26/21, Julian Knodt @.***> wrote:

Hi,
thanks again for the bootloader, I appreciate the work that has gone into
abstracting away all this complexity.
I'm looking to implement a VirtIO block-device driver in my kernel, and for
that I was doing some reading
here, and it
describes the setup_data in the first boot-sector, which is necessary for
accessing the device-tree for getting the physical address of the device. I
was wondering if this was currently exposed in the BootInfo that's passed to
the main function, or if not, if it would be possible for me to add it w/
some guidance?
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rust-osdev/bootloader/issues/143

--
Signed,
Ethin D. Probst

If there is an alternative way to access devices, that also makes sense. From what you say, it's still not clear to me how to read from the PCIe though. Is this some memory-mapped region, and if so what address is it, or is it something else?

The PCIe region is an internal memory-mapped region that allows an
operating system to enumerate hardware within the machine. Not all
processor architectures implement it; for example, the Raspberry PI is
more likely to give you what is known as a device tree blob, or DTB,
which eliminates the device enumeration step entirely. However, the
x86 architecture has no such system, so the firmware is free to place
hardware at whatever memory addresses it pleases. PCI enumeration is
the process of asking the system where devices are in memory (either
in memory-mapped I/O or in port I/O) so that you may configure them
and interact with them.
There are three ways of doing this, all of which are explained in the
OSDev article on PCI: https://wiki.osdev.org/PCI
Accessing the PCIe bus (which is an extended version of PCI and which
is what modern systems use) requires ACPI. The acpi crate will give
you these PCIe regions; it is up to you to scan them and load them
into your internal device tree, however you might do that. More here:
https://wiki.osdev.org/PCI_Express
On 3/27/21, Julian Knodt @.***> wrote:

If there is an alternative way to access devices, that also makes sense.
From what you say, it's still not clear to me how to read from the PCIe
though. Is this some memory-mapped region, and if so what address is it, or
is it something else?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rust-osdev/bootloader/issues/143#issuecomment-808656475

--
Signed,
Ethin D. Probst


bower install is out of date from latest build. bower file doesn't accept options.outputFormat property.

Hello,
Thank for your issue :)
I've release version 1.0.1 with the new feature.
Ps: Same issue than #10


fix(svelte-kit): SvelteKit requires Node 14

SvelteKit dropped support for Node 12 in https://github.com/sveltejs/kit/pull/2604
I'm not that familiar with this framework-info project though. A couple questions:

Will this affect production deploys as well as development?
Will these values I specified simple be the defaults and can users override them?

Closed this since it was reported not to work: https://github.com/netlify/framework-info/issues/288#issuecomment-957251395


Old-style classical memory syntax

When i tried to link my Program with QVM hosted @port 500 . it throws me this error
Traceback (most recent call last):
File "test.py", line 60, in
bitstrings = qvm.run(program, [0,1,2,3])
File "/usr/local/lib/python3.6/dist-packages/pyquil/api/qvm.py", line 136, in run
response = post_json(self.session, self.sync_endpoint + "/qvm", payload)
File "/usr/local/lib/python3.6/dist-packages/pyquil/api/_base_connection.py", line 88, in post_json
raise parse_error(res)
pyquil.api.errors.QVMError: Old-style classical memory syntax, like [0], isn't supported.
I am using quilc 0.16.1 qvm 0.19.1
Forest 2.0 and pyquil 1.9.0

Can you print program and show what it results as?

Hello, it looks like you're using too old of pyQuil (1.9.0). You must use the prerelease version of pyQuil (>= 2.0.0) to use it with the Rigetti SDK. Please see this link for how to get started.


插件似乎不支持 angle bracket links 格式的图片

插件似乎忽略了文件中的图片链接格式为 [text](<assets/file.png>) 的图片链接。
The plugin seems to ignore image links in the file format [text](<assets/file.png>).

@at2008 Thanks for your feedback. May I ask if this format [text](<assets/file.png>) can display the image on your note? Normally, we can embed an image in a note, e.g. ![[Engelbart.jpg|100x145]], ![250](https://publish-01.obsidian.md/access/f786db9fac45774fa4f0d8112e232d67/Attachments/Engelbart.jpg).
[text](<assets/file.png>) is a kind of special format to display the image? Please help provide more details about it.


Pre-Release support for version bump detection

The workflow that detects a version bump will trigger a new release for the repo. However, if the new version is not a final version (alpha, beta, etc.), the github release should be marked as a pre-release.

To give more color this issue: update the detect_version_bump.yml workflow as mentioned here to have set the prerelease  (one of the inputs for the create-release action) input set based on whether a new version is a prerelease or not.


Nominate channing duan

Nominate @channingduan as maintainer for this project.
duan helps with init features of golang code.
ref to https://github.com/hyperledger/fabric-admin-sdk/pulls?q=is%3Apr+is%3Aclosed+author%3Achanningduan
Signed-off-by: Sam Yuan<EMAIL_ADDRESS>

fix #74 70

The list should be sorted in some way. It is currently sorted alphabetically (by first name), which would mean that Channing would go at the top of the list. Or you could choose an alternative sorting and re-order all the entries to match that

ok , it sorted by alphabetically for now.

Looks good to me. We'll also need to raise an issue with Hyperledger to have Channing added to the @hyperledger/fabric-admin-sdk-maintainers team:
https://github.com/hyperledger/governance/issues/new/choose

I think once @davidkhala gives his approval and merged this PR. We can raise an issue with Hyperledger to have Channing added to the @hyperledger/fabric-admin-sdk-maintainers team.

I prefer use personal than company email for contribution.


i got viruses

https://www.virustotal.com/gui/file/c721cdd5c52c9c4d58aaa3db926bdd4eb058a5ad189a4712df269c5e4560c4f2/detection

Since Novus is still in alpha stage, it is not signed yet.
We are planning to get it signed soon.


Remove fedimint-core/src/client.rs

Lots of commented-out code in https://github.com/fedimint/fedimint/blob/master/fedimint-core/src/client.rs
Edit: doesn't even seem like FederationApi is used anywhere?

hey @justinmoon, I wanted to contribute and opened this PR: https://github.com/fedimint/fedimint/pull/3146.
Is this what the intended modification? :-)

Thanks!


Extend pool monitoring code to store retirements in the DB.

Context
As part of the work to track pool retirements, we need to make sure that when the wallet encounters a pool retirement certificate, that the relevant information is recorded in the DB.
Decision
Extend the pool monitoring code to store pool retirements in the DB. Adjust the forward function within monitorStakePools to call putPoolRetirement, along with the corresponding slot and slot internal index.
For a discussion of slot internal indices, see https://github.com/input-output-hk/cardano-wallet/issues/1815.
Acceptance Criteria

[x] The pool monitoring code, on encountering a pool retirement certificate, must ensure that the retirement epoch of that pool is recorded in the DB, along with the slot and slot internal index corresponding to that certificate.

Development

https://github.com/input-output-hk/cardano-wallet/pull/1847

QA
Write integration tests to check that:

[x] retiring a pool eventually results in a correct update to the retirement field of ApiStakePool, when read through the ListStakePools operation. (This field is only written as a consequence of the pool monitoring code writing retirements to the DB.)

lgtm