Greedy Follower

Motivation and Context
The current action space shortest implementation is un-reliable and slow :(
Having the ability to generate a path in action space serves two purposes:

Videos of traveling between two points
An oracle to learn from

The action space shortest path code serves neither of these purposes as it's slow and unreliable.  This PR provides a much faster and reliable greedy follower.  While it doesn't generate the shortest path in action space, the paths still tend to be very good.
This needs to add some logging, @msavva we should figure out how to have unified logging between c++ and python.  Should we just bind glog?
How Has This Been Tested
This has been tested on every navmesh I could find.  584 of them in in total.  Of the ~600k source/target pairs in the testing, 94 of them failed, which I consider to be very, very good.
The failures cases that I looked at tended to be in poor reconstructions where oddities in geometry led to very narrow choke points that the agent is unable to travel down due to not having continuous rotation.

This PR provides a much faster and reliable greedy follower. While it doesn't generate the shortest path in action space, the paths still tend to be very good.


ol.interaction.Draw MultiLineString

drawLineCtrl = new ol.interaction.Draw({
type: 'MultiLineString',
snapTolerance: 20,
//此控件绘制时，不触发地图点击事件
stopClick: true,
geometryFunction: (coordinates, geometry) => {
geometry.setCoordinates(multiLine);
return geometry;  // geometry has two lineString.
}
}); but drawend event, the feature doesn't have two lineString. only one linestring

drawControl.on('drawend', function (event) {
let feature = event.feature;
// feature only has one linestring
});


Website for Fit N Life gym in Kakkanad

Do update the lorem ipsum in the end section other wise its good to go!

waiting for feedback from the client about the the contents that will replace the lorem ipsum

Alright do updates once the the feedback has been received from the client

@Jenin82, Do create a new PR once the required changes has been made, Closing it for the being.


feat(algolia-search): allow translating search modal

Pre-flight checklist

[X] I have read the Contributing Guidelines on pull requests.

Motivation

The Algolia Search Modal is not translatable. This should solve the problem.
Test Plan

I'm still trying to figure out how to test the site locally in French... help me
Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

#4542

I'm still trying to figure out how to test the site locally in French... help me

Try yarn start -l fr? Default theme translations shouldn't even need to run write-translations.

Thank you. But my test doesn't work, I need to look into the details of why it keeps the default values of DocSearch. It's the Modal part (only) that doesn't translate ..... 👀

Did you run yarn build:packages or yarn workspace @docusaurus/theme-algolia-search build first?

Type-checking errors because @algolia/autocomplete-preset-algolia is not installed. This only happens now because we never pulled in docsearch's types before. This looks more like a bug on Algolia's side?

cc @shortcuts @algolia/autocomplete-core references @algolia/autocomplete-preset-algolia in its type definition but doesn't have it as dependency/peer dependency. Maybe @docsearch/react need to install it, at least.

Hey, should be fixed in 3.1.1 for the DocSearch part, I've pinged the Autocomplete team for the client-search warning but you shouldn't get an error at least

@Josh-Cena @shortcuts It looks good now

LGTM 👍  thanks


Start 1.0.4

No review needed.

Coverage remained the same at 35.919% when pulling f7950ea74ee0c4d8c067d2eb9aa1000a9fa6af78 on start_1.0.4 into 8d1b00e3cd33fcd29d7638abad42f28deeebde65 on stable_1.0.


Vertical 100% bar: allow values > 100%?

Hi
I have a current requirement that uses something like Vertical 100% Bar, but allows for ratios to be greater than 100%.
Initially, this seems silly: why have a figure greater than 100%?
The context is this:

each vertical bar represents a quota
the bar is divided into Used and Unused parts of the quota, which should total the full amount of the quota
however, it is possible for someone to have used more than the quota assigned to them, in which case, the requirement is to indicate this visually by providing a bar that goes beyond the 100% mark

Any ideas on how to implement this?
many thanks in advance
Matt

That's fine but it's not what the 100% chart is for.  You just need to create a standard vertical bar and use your quota percentage on a standard measure axis.  If you set y.tickFormat = "%" it will format them as percentages and appear exactly the same as the 100% chart (but without the 100% cap).

Ok, thanks for the quick reply John!
One further requirement then:

am currently setting the colours via chart.defaultColors
and adding an order rule via series.addOrderRule()
but I need to be able to set the colour of the Used section of the bar to a given colour in certain circumstances (amber when 95% < used/total < 100%; red when used/total >= 100%)

How would I do this?
Matt

You will need to add those bandings into your data. e.g.
data.forEach(function (d) {
    if (d["Quota Pct"] < 0.95) {
        d["Band"] = "Under Quota";
    } else if (d["Quota Pct"] < 1) {
        d["Band"] = "On Quota";
    } else {
        d["Band"] = "Over Quota";
    }
});

Then you can assign colours like this (assuming "used/unused" is the name of the dimension to stack by):
// The last element in the series array is used for colouring
myChart.addSeries(["Used/Unused", "Band"], dimple.plot.bar);
// You can assign particular colours to any value of this dimension using the assignColor method
myChart.assignColor("Under Quota", "amber");
myChart.assignColor("On Quota", "green");
myChart.assignColor("Over Quota", "red");

There's more about assignColor here: https://github.com/PMSI-AlignAlytics/dimple/wiki/dimple.chart#assignColor

Fantastic. Really appreciate your detailed response John.

Closing issue; have a solution. Thanks again John.


Allow custom headers and status in StreamingResponse

Hi,
This Pr does basically what the titles says.
It allows to add custom headers and status to the Response in StreamingResponse.
StreamingResponse(Status.Created, headers, Buf.Utf8.apply) {
      AsyncStream("A", "B", "C")
    }

Regards,
Jaume Pinyol

Current coverage is 93.69%

Merging #253 into master will decrease coverage by -0.07% as of 0f71016

@@            master    #253   diff @@
======================================
  Files          174     174
  Stmts         2276    2284     +8
  Branches       272     272
  Methods          0       0
======================================
+ Hit           2134    2140     +6
  Partial          0       0
- Missed         142     144     +2

Review entire Coverage Diff as of 0f71016

Powered by Codecov. Updated on successful CI builds.

If I do this I get a compiling error:
Error:(9, 8) in object StreamingResponse, multiple overloaded alternatives of method apply define default arguments.
object StreamingResponse {

Merged in commit: 5c847f6db84441b4b993389ae398aecb86c54940

Hi Jaume,
The scripts we used to merge your pull request into our internal repo didn't correctly add you as the author when I edited your commit message. We're really sorry about this, and we'll make sure this never happens again. Thanks again for your contribution and please let us know if there's anything else we can do.
Thanks,
Steve


A11y_Screen reader not announcing name of combo box it announcing only value of combo box.

Github tags
#A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Benchmark; #BM-AzureDataStudio-Win32-Feb2022; #Azure Data Studio; #DSCT1.0.0; #FTP; #JAWS; #WCAG1.3.1; #ScreenReader; #Win10; #Win32; #NVDA:
"Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver."
Actual Result:
Screen reader not announcing name of combo box it announcing only value of combo box.
Similar issue observed with JAWS also.
Similar issue observed in:
1.  for 'File on, Extension and feedback ' control also.
2. 'Conversion options_Provide a name' Scenario also.
Expected Result:
Screen reader should announce name of combo box and value containing it also.
Environment Details:
Application Name: Database Schema Conversion Toolkit Azure data studio
Version: 1.43.0 (System user)
Windows Version: Win11 Pro 21H2
OS Build:22000.1817
ScreenReader: JAWS 2023.2303.144 /NVDA 2023.1
Repro Steps:

Login to vm with appropriate credentials
Launch Azure data studio.
Tab to 'Manage Connection' and press enter
Tab to the dash board for Oracle extension
Tab to 'Feedback'
Turn on screen reader and observe the issue.
User Impact:
Screen reader user will not able to get complete information regarding combo box present in page.

User Impact:
Screen reader user will not able to get complete information regarding combo box present in page.
Attachments:
2389897_With NVDA.webm
2389897_With JAWS.webm

This issue is upstream. A tracking issue has been created in vscode (referenced above).

@kisantia , any ETA on this?

@ShaileshChudawkar can this issue please be downgraded to sev3 or closed since an upstream issue has been created in vscode and there is no ETA for this to be fixed?

@ShaileshChudawkar this has been fixed. Please try the latest insiders build to verify the fix.

Verified the issue below environment.
Version: 1.48.0-insider (user setup)
Commit: 7bdf5c994bcc25aaeb60584dcaa24f83e6fde7fd
Date: 2024-01-29T22:20:11.186Z
VS Code: 1.82.0
Electron: 25.9.8
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.23620
Issue is fixed. Hence the bug is closed.
#Regressed:02-01-24; #Closed;
For reference attachment is added.
Screen Recording (35).webm
24218_JAWS.webm


Add @package tag

I'd love it if you could add @package (and @access package) for package private symbols as defined by JSDoc:
http://usejsdoc.org/tags-package.html
Thanks!

oh this would be really nice, I like this idea.


add container (docker/podman) capability for cirq release tag &/or br…

Rework Dockerfile base on python-slim
Add container_run.sh to start or attach container
Add Makefile to build / display container (docker|podman) information
Add container.md initial documentation

Closing as stale: @kloodz-mrioux Feel free to re-open if you want to continue working on this.


[ownership] Do not insert an end_borrow when calling emitEndBorrowOperation on a value with OwnershipKind::None.

This is safe to do since our end_borrow isn't returned to our user.

@swift-ci smoke test

@swift-ci smoke test OS X platform

@swift-ci smoke test linux platform


swipe-guess: init at 0.2.1

Description of changes
Adds swipe-guess, see https://git.sr.ht/~earboxer/swipeGuess.
Fixes #261514

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 261525 run on aarch64-darwin 1

1 package built:

swipe-guess


Added Knowfox to projects

@oschettler it doesn't seem like this is a static site generator. I don't see installation instructions, do you have an example? Can you also change the headings to h2 instead of h3


Failed to load subscription client when CDN is enabled

When I configure CDN to be enabled, with a subscription endpoint specified - I'm getting a 404 error with the loading of subscriptions-transport-ws-browser-client.js - it appears to be defaulting to being served locally, which I think is down to this:
https://github.com/graphql-java-kickstart/graphql-spring-boot/blob/fe6d8c02f88388dea75f86a07dc230c3ac6e5f0b/graphiql-spring-boot-autoconfigure/src/main/java/graphql/kickstart/graphiql/boot/GraphiQLController.java#L113-L114
The app is hosted in k8s, so I don't want to have to put in complex ingress rules for this. I have another app without a subscription and that works fine.
I am using graphiql-spring-boot-starter:7.1.0 and my application.yaml has:
graphiql:
  mapping: /graphiql
  cdn:
    enabled: true
    version: 0.17.5
  endpoint:
    graphql: /graphql
    subscriptions: /subscriptions

I'm seeing the same issue with graphiql-spring-boot-starter:8.0.0 as well.

Upgraded default GraphiQL CDN version to 1.0.6 too and refactored the subscription-transport-ws dependency to load the last compatible version using CDN too.


Step 62 and 63 don't compile

Nice guide so far.
A suggestion: these intermediate steps indicate in the code box that the program will fail to compile at these steps but the text doesn't make a clear indication that this is what we expect and will fix in the subsequent steps.
Could be helpful to mention that we're going to break the program for a few steps.

That's a good point, I've added a note to the text saying it won't compile for those steps. Thanks!


Prepare 97x config

Update

e2e test
network config
SDK 0.20.8 alpha

**Note: **  It will merge after SDK 0.20.8 full release
Resolved: #611

refer #633


Transaction Page - Multiple Delete Action

Problem-
User wants to Delete Multiple Transaction At a time
Technical Detail-

anything more than 20 should go to background Task
System will take order to Delete Transaction on Background Engine
Once Triggered Task can not be stopped
Transaction will be visible on Transaction Page, until system processes it
Transaction will be valid and working until system removes them
This also depends on Load from other Engines

Initiated by @vinpahilwani
Verified by @mitulpanch

anything from Multiple action will go to Task
Priority will be dependent on other task pending execution

Need to Create Background Task for this
Time required - 3 hours for Background Task
1 Hour for Design Validations

chahiye

API-Ready


[BUILD] Official Docker Image

PR Checklist

[x] A description of the changes is added to the description of this PR.
[x] If there is a related issue, make sure it is linked to this PR.
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] If you've added or modified a feature, documentation in docs is updated

Description of changes
This PR simplifies the use of Docker by merging the cli and server into a unified, multi-arch compatible, Dockerfile with clean syntax, and brings the project closer to publishing an official image to DockerHub. See #319, #482, and #480.
Additional info

Example of the proposed GitHub Actions workflow successfully building and pushing images on my fork
Shaved off 1GB from the ./Dockerfile image to get it down to about 1.35GB

This PR does the following:

Simplifies the main Dockerfile and enables arm64 native builds
Add compose.yaml to allow running UC with one command docker compose up -d
Adds standard build and push GitHub Actions workflow. Actually pushing the official image to DockerHub can be enabled in a subsequent PR.

Can you split the PR to two parts, please? 🙏

A GitHub workflow
An improved Docker build

It's going to be so much easier to review (and merge more quickly).

Please (re)create docker directory and move all Docker-related files over there + add README.md with "How to build the Docker image" 🙏

Can you split the PR to two parts, please? 🙏

A GitHub workflow
An improved Docker build

It's going to be so much easier to review (and merge more quickly).

Hey @jaceklaskowski, the Github Actions workflow helps self-document that the build works successfully by running the added job in the CI for this PR.

Please (re)create docker directory and move all Docker-related files over there + add README.md with "How to build the Docker image" 🙏

Following the common practice of a main Dockerfile in the root directory, building the image is now as easy as running docker compose up, which is documented in the ./docs/docker_quickstart.md. I wasn't clear on why we need any specific scripts or documentation elsewhere?

Thanks @tnightengale - will review shortly!

Please (re)create docker directory and move all Docker-related files over there + add README.md with "How to build the Docker image" 🙏

Following the common practice of a main Dockerfile in the root directory, building the image is now as easy as running docker compose up, which is documented in the ./docs/docker_compose.md. I wasn't clear on why we need any specific scripts or documentation elsewhere?

There are so many "common practices" in the main directory that anything docker-specific should be put aside into its own directory to avoid any bigger mess.
I think those who are gonna use Docker locally would rather pull the UC image(s) from the docker / github repo, wouldn't they? Those who wanna build and run UC dockerized would likely not mind switching to another directory.
There are already the following "common practices":

CODE_OF_CONDUCT.md and CONTRIBUTING.md that should really be under .github
mkdocs.yml and requirements-docs.txt should be under docs
version.sbt under project

As you can see there are lots of tools (and their common practices) that it's a mess already. Please help me / us keep it clean(er) 🙏

Hey @jaceklaskowski  - I like your call outs here but are these specific to the docker itself and/or should we potentially address this in a new issue/PR?
CODE_OF_CONDUCT.md and CONTRIBUTING.md that should really be under .github
I'm inclined to agree with you.  Specifically, we should probably push these to unitycatalog/.github/.github so the code of conduct and contributing are applicable to all repos in the org.
mkdocs.yml and requirements-docs.txt should be under docs
It is my understanding that mkdocs requires mkdocs.yml in the root folder though I've never tried pushing requirements-docs.txt under docs.  I'm glad to be corrected here.
version.sbt under project
I have no strong opinion on this location, @tdas - WDYT?

Please (re)create docker directory and move all Docker-related files over there + add README.md with "How to build the Docker image" 🙏

Following the common practice of a main Dockerfile in the root directory, building the image is now as easy as running docker compose up, which is documented in the ./docs/docker_compose.md. I wasn't clear on why we need any specific scripts or documentation elsewhere?

There are so many "common practices" in the main directory that anything docker-specific should be put aside into its own directory to avoid any bigger mess.
I think those who are gonna use Docker locally would rather pull the UC image(s) from the docker / github repo, wouldn't they? Those who wanna build and run UC dockerized would likely not mind switching to another directory.
There are already the following "common practices":

CODE_OF_CONDUCT.md and CONTRIBUTING.md that should really be under .github
mkdocs.yml and requirements-docs.txt should be under docs
version.sbt under project

As you can see there are lots of tools (and their common practices) that it's a mess already. Please help me / us keep it clean(er) 🙏

I see your point, but perhaps we can decouple this PR from deciding all the "best practice" locations for various build docs from this PR?
I also agree that docker compose up should pull the official image, by default rather than build. Once we begin pushing tagged official images in a follow up PR, we can also edit compose.yaml to pull down that image. 👍

Any concerns if we take any open issues from our discussion and create new issues/PRs so we can resolve this PR @jaceklaskowski @tnightengale ?

Any concerns if we take any open issues from our discussion and create new issues/PRs so we can resolve this PR @jaceklaskowski @tnightengale ?

I created an issue to discuss further and address codifying the project structure and reorganizing the files mentioned. 👍

Thanks @tnightengale - this looks great!  QQ - do you think it doesn't make sense to include the ui and MLflow features?  Thanks!

Thanks @tnightengale - this looks great! QQ - do you think it doesn't make sense to include the ui and MLflow features? Thanks!

@dennyglee To clarify, currently the UI is included in the docker compose config. However, MLflow is not. Are you suggesting we remove the UI from, or add the MLflow to, the compose config?
I think including the UI provides a seamless experience running the whole app locally using docker. Is there a reason you would want it removed?
Conversely, do you want to add MLflow as an optional service in the compose config?


Add schemaPath to transformAjvErrors

Prerequisites

[X] I have read the documentation;
[X] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description
I'm using rjsf in a project and require custom messages that are part of the schema.  For example:

const schema = {
title: "react-jsonschema-form demo",
type: "object",
required: ["name"],
properties: {
name: {
type: "string",
minLength: 3,
myCustomErrors: "You really should fill in your name"
},
description: {type: "string"},
}
};

Here myCustomErrors defines custom error messages.  So when running rjsf validation I provide a transformErrors function, which is called with the error messages generated by rjsf.  I need a way to map the error into the schema so that I can extract the proper error message.  Looking at the source this should be as easy as updating validate.js to add the schemaPath to the error message structure.
Something like the following:
  return errors.map(e => {     const { dataPath, keyword, message, params, schemaPath } = e;     let property = ``${dataPath}``;     // put data in expected format     return {       name: keyword,       property,       message,       params, // specific to ajv       stack: ``${property} ${message}``.trim(),       schemaPath     };   });
Steps to Reproduce
Here's a sample JSFiddle demonstrating that validation doesn't have the schemaPath.
Expected behavior
I need to have access to the schemaPath
Actual behavior
I don't have access to the schemaPath
Version
1.0.1

Hi @dosborne , I do agree that the schema path should be added to the transformErrors function, but a work around for this issue that worked for me  could be the following:
1.- Customize the  transformErrors messages.
2.-Create CustomFieldTemplate https://github.com/mozilla-services/react-jsonschema-form#field-template
function CustomFieldTemplate(props) {   const {id, classNames, label, help, required, description, errors, children} = props;   return (
       {label}{required ? "*" : null}       {description}       {children}         <ErrorInline id={id} schema={schema} errors={errors} />       {help}
   ); }
3.-Create a custom ErrorInline that will work as a wrapper of the Errors returned by AJV, pass the id, schema and errors.  Here iterate over the list of errors of each and update them as needed , you will have access to the schema.


Added gifs to feature usage and adoption and monitoring workspace document

Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

https://dev.azure.com/msft-skilling/Content/_workitems/edit/242196
https://dev.azure.com/msft-skilling/Content/_workitems/edit/242214

Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.

@KesemSharabi

For internal Microsoft contributors, check off these quality control items as you go

[ ] 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

[ ] 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

[ ] 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

[ ] 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

[ ] 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

@KesemSharabi
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@Jak-MS - I checked the GIFs and they look good. Thanks!


[Cloud 2083]  Updating JDV 6.4 templates

[CLOUD-2083] Updating templates to point to jdv 6.4 quickstart directory and removing ModeShape username and password, as its been deprecated and removed from the images

Wrong target branch.


Rename this project to spurin/niksen

I believe the philosophy behind this project is better represented by the Dutch word of niksen (source). Hence, I propose to rename the project to spurin/niksen. I reckon that opening this very issue on a Friday goes against the very concept of niksen, but helaas (another great Dutch word).

Thanks @ams0 for the suggestion and for introducing me to the concept niksen! It’s fantastic and yes, I can see how it aligns with the project’s philosophy of, well, doing almost nothing.
I think the current name idle, strikes a nice balance of simplicity and recognition. It’s also already living its best life in Docker Hub under this name 😆
Love the spirit of niksen and I’ll be channeling it over the xmas period!
Appreciate you as always and thanks for the idea, hope that idle proves itself worthy of its minimalistic aspirations and the close connections to niksen!


Uninstall didn't work

Trying to uninstall the sysbox.
Had the logs in the uninstall pod:
E0502 19:26:40.723068      26 memcache.go:238] couldn't get current server API group list: Get "https://<IP_ADDRESS>:443/api?timeout=32s": dial tcp <IP_ADDRESS>:443: connect: network is unreachable
E0502 19:26:40.723309      26 memcache.go:238] couldn't get current server API group list: Get "https://<IP_ADDRESS>:443/api?timeout=32s": dial tcp <IP_ADDRESS>:443: connect: network is unreachable
E0502 19:26:40.724962      26 memcache.go:238] couldn't get current server API group list: Get "https://<IP_ADDRESS>:443/api?timeout=32s": dial tcp <IP_ADDRESS>:443: connect: network is unreachable
E0502 19:26:40.726579      26 memcache.go:238] couldn't get current server API group list: Get "https://<IP_ADDRESS>:443/api?timeout=32s": dial tcp <IP_ADDRESS>:443: connect: network is unreachable
E0502 19:26:40.727880      26 memcache.go:238] couldn't get current server API group list: Get "https://<IP_ADDRESS>:443/api?timeout=32s": dial tcp <IP_ADDRESS>:443: connect: network is unreachable
Unable to connect to the server: dial tcp <IP_ADDRESS>:443: connect: network is unreachable
ERROR: Sysbox is not supported on this Kubernetes version ().
Stream closed EOF for kube-system/sysbox-cleanup-k8s-fz8px (sysbox-cleanup-k8s)

Also manually running the .sh script on the node produced this:
+ grep kubelet_env_file /var/lib/sysbox-deploy-k8s/config
+ echo 'Failed to revert kubelet config; config not found in /var/lib/sysbox-deploy-k8s/config'
Failed to revert kubelet config; config not found in /var/lib/sysbox-deploy-k8s/config
+ return
+ restart_kubelet
+ echo 'Restarting Kubelet ...'

There's no kubelet_env_file in the config.
Calico CNI, k8s 1.23 (kubeadm baremetal)

Reinstalling also is broken now. Is there a description of manual steps to clean this?

Hi @dimm0, sorry to hear you having problems with the uninstallation. We test both the installation and uninstallation, so the error you are seeing is unexpected.
Question: did the installation succeed? I ask because the log above shows:
ERROR: Sysbox is not supported on this Kubernetes version ().

FYI, the installation / uninstallation script is designed to run inside a sysbox-deploy pod; it won't run at host level.

Is there a description of manual steps to clean this?

We don't have a description of the manual steps to install or uninstall unfortunately. It's a bit of a complicated process as the uninstallation must undo the installation steps (e.g. ,configure the kubelet to use containerd instead of CRI-O, remove CRI-O, remove Sysbox, and remove the Sysbox runtime class from K8s).
How can we help further?

Thanks, I'll try to reinstall manually with CRI-O. That seems to be less invasive process.


fix(🔥): match underscored var names

🧰 What's being changed?
Akamai was noticing some issues with their variables after #66—apparently the \w selector matches underscores but the new Unicode \p{Letter} selector doesn’t.

[x] Explicitly match underscored variable names.

after this is merged we might want to audit what other characters were lost in this process. hypens maybe? otherwise code looks fine and can test with a readme pr

@kanadgupta—added a test. @Dashron—s'a good idea (though we were always explicitly matching dashes in this pattern! You can see the various test cases here.)


UI Updates for vSphere Templates

The docker-machine vsphere driver will be getting some updates to take more parameters which will need to be passed in through the front end. We are planning for some of the following but ultimately the support is tbd right now until we get into code.
Backend work being done against this issue rancher/rancher#21483
Some things we'd like to try are the following

Clone from "type" concept, will be 3 options: ofv, template, content library
Each of those three types take one thing and should hopefully just be a single text field, needs investigation.
Multiple Networks, will probably be key/value map like parameters are today
Mutliple disks, will probably be a key/value map like parameters are today

@luthermonson Is the backend ready for this?

Feedback captures from demo.

Clone vs manual:
a. Condense the dropdowns for manual vs clone and the secondary clone dropdown (that has vm, template, etc) into a single dropdown that reflects the verbage in the vsphere UI
b. in that dropdown, change manual to something more meaningful like “Deploy from rancheros iso (legacy)“. I might even say use the word deprecated instead of legacy so that it is more strongly discouraged
c. in that dropdown, default to one of the clone options

move networks out of scheduling and into instance options

clean up the rest of the labels and wording to match vsphere verbage

custom attributes and tags get their own accordian sections

cloud-init needs to be its own line. dont wrap with the previous inputs

at least the vm and template dropdowns should be searchable lists instead of just normal  dropdowns

the cloud-config text box can/should be a yaml editor

Available in latest-2.3.

rancher/rancher:v2.3-head
UI: latest-2.3

Fields are populated by data from vCenter:

Datacenter
Resource Pool
Data store
Folder
Host
Networks
Tags
Custom Attributes

User is able to select creation method

Fields are updated and populated based on creation method

Deploy from RancherOS ISO is marked as deprecated


Fix/paper matching fixes

Fixes #2022

Could you please fix this issue in this PR too:https://github.com/openreview/openreview-py/issues/2016
it will require changing the preprocess function too.

Yes, I will also fix #2015 in this PR

The changes look good!


Bazel build fails

I am starting to receive messages saying the bazel build is failing, both in my fork and from the main repo (upon PR push). Is there a reason this is enabled at all?

It was to get early warnings of issues. @Vertexwahn, any thoughts?

There was a Bazel build problem on master which I introduced by accident with PR 1068. It was fixed with PR 1070.

Do you see the problem still on any other branches?
For me, this issue seems to be fixed. Please let me know if Bazel Build makes anywhere a problem.


Support config_constraints  in AutoML similar to Tune

There is a need to specify constraints on the configurations similar to Tune. Currently, AuotML does not support this.

What about defining a class method config_constraints for flaml.automl.model.BaseEstimator. For estimators which have such constraints, override this method?

This can be a solution to #845

And supply the constraints in tune syntax, right, to avoid inventing another one?

And supply the constraints in tune syntax, right, to avoid inventing another one?

Right.


Add API documentation

Generated docs: http://seed-auth-api.readthedocs.io/en/feature-issue-1-add-api-documentation/http_api.html

General comment: should we maybe use a 422 rather than a 400?

Other general comment: should we use 204 for empty success responses?

We can look at using 422 instead of 400. I think by default django rest framework uses 400, but we can look at how difficult that will be to change to 422.
I'll change all empty responses to be 204.

Looks good :) I think the only unresolved thing is the to use /teams/<team_id>/users/ instead of /users/<user_id>/teams/. Otherwise :+1:

@justinvdm I've changed /users/<user_id>/teams/ to /teams/<team_id>/users, and changed to using token auth instead of JWT token auth. Ready for another review.

:+1:
Is the plan to update the 400s in the docs to 422s once know this is easy enough with django-rest-framework?

Yes. I'll have a look if it's easy enough to do. But if it involves adding a bunch of try catches and handling error cases myself, I might leave it as 400s.
Actually, let me update things to 422s, and we can switch them back in the docs if it turns out to be difficult. That way we won't forget about it.

@justinvdm Okay changes some of the 400s to 401s, and some to 422s. Ready for one last look.

:+1: looks awesome :)


dependabot: Fix time format to add leading 0

Problem
The dependabot tab in the dependency graph is giving an error:
The property '#/updates/0/schedule/time' value "9:00" did not match the regex '^\d\d:\d\d$'

Because the time is specified "9:00".
Solution
Update it to "09:00"

No need for CI, merging straight away


Bump version to 2.29.0-rc.0

My bad, I forgot to bump the version in #9133
@juliusv @roidelapluie @simonpasquier @bwplotka @codesome @SuperQ

We end up updating it for the final minor release anyways, I don't think we need to sweat the date for the RC.

/prombench v2.28.1

/prombench cancel

prombench is OK, both the dashboard and the logs.


Added redirect Uri to GenerateAccessTokenAsync

Without this change it's impossible to use a redirect uri to authenticate
I'd like to add support for submitting print jobs with this api assuming all goes well with this PR. Let me know if you'd be amenable to that.

@elacy , thanks for the PR! It's always great to see someone who is willing to contribute to the project. Amendments and improvement are always welcomed!


Data loaders: Invalid value used as weak map

I don't have reporduction for this one, but it seems when using nested loaders, and very short cache time or when cache expires this code...
https://github.com/posva/unplugin-vue-router/blob/53ccfa5365f6c94f2928a1811f7f5353612027ba/src/data-fetching/defineLoader.ts#L201-L204
crashes with Invalid value used as weak map

Unfortunately I can't really check with that information...
The loader part is being rewritten to have different versions with and without cache and the new version doesn't use a weak map anyway


[web] HTMLAudioElement() produces "TypeError: Illegal constructor"

Is there an existing issue for this?

[x] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Run the code sample below.
Expected results
No error.
Actual results
I get the following error:
TypeError: Illegal constructor

Code sample
Code sample
import 'package:web/helpers.dart';

void main() {
  AudioElement();
}

Screenshots or Video
No response
Logs
Logs
flutter pub add web
flutter run -d chrome

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.16.1, on macOS 13.6.1 22G313 darwin-x64, locale en-AU)
    • Flutter version 3.16.1 on channel stable at /Volumes/Samsung_T5/opt/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7f20e5d18c (14 hours ago), 2023-11-27 09:47:30 -0800
    • Engine revision 22b600f240
    • Dart version 3.2.1
    • DevTools version 2.28.3

[✗] Android toolchain - develop for Android devices
    ✗ ANDROID_HOME = /Users/ryan/opt/android-sdk
      but Android SDK not found at this location.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] Connected device (3 available)
    • macOS (desktop)        • macos                                    • darwin-x64     • macOS 13.6.1 22G313 darwin-x64
    • Chrome (web)           • chrome                                   • web-javascript • Google Chrome 119.0.6045.159

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

This may or may not be relevant (I'm not sure how package:web does it under the hood):
https://stackoverflow.com/questions/71901055/uncaught-typeerror-illegal-constructor-when-extending-htmlspanelement

Reproducible using the code sample provided above.
Labeling for further insight.

flutter doctor -v
[✓] Flutter (Channel stable, 3.16.1, on macOS 14.1.1 23B81 darwin-arm64, locale en-GB)
    • Flutter version 3.16.1 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7f20e5d18c (19 hours ago), 2023-11-27 09:47:30 -0800
    • Engine revision 22b600f240
    • Dart version 3.2.1
    • DevTools version 2.28.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0-rc1
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode-15.0.0-Release.Candidate.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 76.3.4
    • Dart plugin version 232.10072.19

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (4 available)
    • Nexus (mobile)       • 00008020-001875E83A38002E • ios            • iOS 17.1.1 21B91
    • Dean’s iPad (mobile) • 00008103-000825C811E3401E • ios            • iOS 17.1.1 21B91
    • macOS (desktop)      • macos                     • darwin-arm64   • macOS 14.1.1 23B81 darwin-arm64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 119.0.6045.159

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.17.0-16.0.pre.36, on macOS 14.1.1 23B81 darwin-arm64, locale en-GB)
    • Flutter version 3.17.0-16.0.pre.36 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ad62645fce (8 hours ago), 2023-11-28 14:20:07 +0900
    • Engine revision 96137d05fa
    • Dart version 3.3.0 (build 3.3.0-169.0.dev)
    • DevTools version 2.30.0-dev.4
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0-rc1
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode-15.0.0-Release.Candidate.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 76.3.4
    • Dart plugin version 232.10072.19

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (4 available)
    • Nexus (mobile)       • 00008020-001875E83A38002E • ios            • iOS 17.1.1 21B91
    • Dean’s iPad (mobile) • 00008103-000825C811E3401E • ios            • iOS 17.1.1 21B91
    • macOS (desktop)      • macos                     • darwin-arm64   • macOS 14.1.1 23B81 darwin-arm64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 119.0.6045.159

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

This is a bug in package:web. I filed an issue here: https://github.com/dart-lang/web/issues/124. The workaround is simple for now: document.createElement('audio').
There are no custom elements involved in package:web. It lowers the constructor to the intuitive lowering new HTMLAudioElement() in JS. That JS code returns that error, since the working way is to do new Audio() instead.


May I use the aws sqs with the binder?

My company don't want to manage the mq machine

Not clear what the request is. We provide a binder for aws Kinesis. You can find more details here. If you have specific questions regarding the Kafka binder in this context, please check back here. Closing this issue for the time being.


MacOS Ventura: Failed to remove tempfile

Summary

Failed to remove tempfile at /var/folders/37/3fy66clj37d268n32wsfm8400000gn/T/gopass-edit3522339400/secret: failed to unmount /dev/disk5 from /var/folders/37/3fy66clj37d268n32wsfm8400000gn/T/gopass-edit3522339400: exit status 1
Steps To Reproduce

gopass edit
Expected behavior

exit 0
Environment

OS: [e.g. Mac OS X High Sierra, Ubuntu 18.04, Windows 10, ...]  Mac os x ventura
OS version: [uname -a] Darwin xxxx 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct  9 20:14:54 PDT 2022; root:xnu-8792.41.9~2/RELEASE_X86_64 x86_64
gopass Version: [gopass version] gopass 1.14.9 go1.19.1 darwin amd64
Installation method: [e.g. from source, brew, gopass repo] brew

Additional context

is sandbox error?

I haven't tried Ventura, yet. Maybe Apple introduced some new "improvements"?

I upgraded to Ventura this evening and am experiencing this very same issue.

I had the same behavior prior to Ventura... and unfortunately upgrading to Ventura doesn't make the error go away.

Same error is shown for me after Mac OS update, although gopass edit did appear to have worked.

@fw8 This is very annoying, but the error reported should not prevent anyone from editing or creating secrets.
If that's the case, and especially if it did happen prior to Ventura, please do open a separate issue with the GOPASS_DEBUG_LOG output. This issue will be used to track the Ventura issue.

I have the same issue with Ventura, gopass 1.14.10 go1.19.3 darwin arm64.
Executing with debug output looks like this:
GOPASS_DEBUG_LOG=1 gopass edit test
Initialized /dev/rdisk5 as a 16 MB case-insensitive HFS Plus volume
Unmount of all volumes on disk5 was successful
Unmount of all volumes on disk5 was successful
Unmount of all volumes on disk5 was successful
Unmount of all volumes on disk5 was successful
Unmount of all volumes on disk5 was successful
Unmount of all volumes on disk5 was successful
Unmount of all volumes on disk5 was successful
Unmount of all volumes on disk5 was successful
Failed to remove tempfile at /var/folders/dd/htl7qmvx5mj88rt0qhvs15mw0000gn/T/gopass-edit3300328917/secret: failed to unmount /dev/disk5 from /var/folders/dd/htl7qmvx5mj88rt0qhvs15mw0000gn/T/gopass-edit3300328917: exit status 1

And, as already reported, unmounting manually with e.g. umount /dev/disk5 succeeds without any problems.

I am seeing this issue as well and it appears as if diskutil unmountDisk is not working correctly on Ventura.
$ GOPASS_DEBUG_LOG=1 gopass edit test
Initialized /dev/rdisk3 as a 16 MB case-insensitive HFS Plus volume
Unmount of all volumes on disk3 was successful
Unmount of all volumes on disk3 was successful
Unmount of all volumes on disk3 was successful
Unmount of all volumes on disk3 was successful
Unmount of all volumes on disk3 was successful
Unmount of all volumes on disk3 was successful
Unmount of all volumes on disk3 was successful
Failed to remove tempfile at /var/folders/3k/l7_1t5hj3wnbb9kfcqnsmbr00000gn/T/gopass-edit1373982785/secret: failed to unmount /dev/disk3 from /var/folders/3k/l7_1t5hj3wnbb9kfcqnsmbr00000gn/T/gopass-edit1373982785: exit status 1

I was looking at the code to determine what it's doing and it seems like the failure is on the eject:
https://github.com/gopasspw/gopass/blob/master/pkg/tempfile/mount_darwin.go#L83-L110
gopass runs a diskutil unmountDisk and then a diskutil eject on the device, but on Ventura the disk is still showing as mounted after the unmountDisk which causes the eject to fail.
$ diskutil unmountDisk /dev/disk3
Unmount of all volumes on disk3 was successful
$ diskutil eject /dev/disk3
Volume failed to eject

Note: I have omitted the quiet passed to eject so that stderr is not suppressed.
If I umount the device first, then I can eject it.
$ umount /dev/disk3
$ diskutil eject /dev/disk3
Disk /dev/disk3 ejected

I was able to work around the issue with the following change: PR
It doesn't seem like this change should be necessary, but I'm not sure why the change in behavior. If diskutil unmountDisk was unmounting the disk as expected, this should just work.

@brianjkinney Thanks a lot for the investigation and the PR. I'll try it out myself on Ventura and if it works as expected we'll merge it.

I was digging into this a bit more, and from what I can tell the mount command doesn't get captured in the mount information for diskutil.
Here I create a disk and then mount it using the mount command which is how gopass handles it.
$ temp_dir=$(mktemp -d -t test-edit)
$ disk=$(hdid -drivekey system-image=yes -nomount ram://32768 | tr -d '[:space:]')
$ newfs_hfs -M 700 $disk
Initialized /dev/rdisk2 as a 16 MB case-insensitive HFS Plus volume
$ mount -t hfs -o noatime -o nobrowse $disk $temp_dir

You can see that diskutil doesn't see the disk as mounted and so when trying to unmount it doesn't appear to do anything.
$ diskutil info $disk | grep Mount
   Mounted:                   Not applicable (no file system)
$ diskutil umountDisk $disk
Unmount of all volumes on disk2 was successful
$ mount | grep ^$disk
/dev/disk2 on /private/var/folders/3k/l7_1t5hj3wnbb9kfcqnsmbr00000gn/T/test-edit.3urnZenR (hfs, local, nodev, nosuid, noatime, nobrowse, mounted by brkinney)
$ umount $disk
$ mount | grep ^$disk
$

If instead I use diskutil mount to mount the filesystem, now you can see that diskutil recognizes the filesystem as mounted and now diskutil umountDisk works correctly.
$ diskutil mount nobrowse -mountOptions noatime -mountpoint $temp_dir $disk
Volume untitled on /dev/disk2 mounted
$ diskutil info $disk | grep Mount
   Mounted:                   Yes
   Mount Point:               /private/var/folders/3k/l7_1t5hj3wnbb9kfcqnsmbr00000gn/T/test-edit.3urnZenR
$ diskutil umountDisk $disk
Unmount of all volumes on disk2 was successful
$ mount | grep ^$disk
$ diskutil eject $disk
Disk /dev/disk2 ejected

I believe that prior to Ventura, diskutil had this mount information, and so it definitely seems like a change in behavior after the upgrade. I'm not sure if this works for anyone on Ventura or if it's just some users seeing the failure.
My earlier PR was to attempt a umount if it appeared the diskutil unmounDisk didn't work. But instead this could also be changed to do one of the following:

Replace the mount command with diskutil mount
Replace the diskutil unmountDisk with umount

I'm not trying to rush things, just wanted to provide some possible alternatives that may be cleaner than my original PR.


a question about Failover step

I have a cluster like:
+A:9999
  -B:9999
  -C:9999
  -D:9999

A,B,C and D is in the same dc.The promotion rule of B is prefer and others are neutral.
When DeadMaster failover occured,the cluster  like:
+B:9999
   -C:9999
       -D:9999

I check the log and find orchestrator first promote replica:C:9999 as master,B:9999 and D:9999 are picked  as candidate replacement.Then orchestrator find the promotion rule of B is prefer,so it try and take its master.And things seems ok.
But i have a question about the cluster‘s final form.Why the cluster not like:
+B:9999
  -C:9999
  -D:9999

Seems like a perfect behavior with current logic. Your question is good. The short answer: mostly technical debt.
The long answer:
When failing over a master we are under some time pressure. Promoting a new replica (C) takes time. We then realize it's not the one we want and invest more time (a few seconds) promoting B on top of C.
Spending further time to make D replicate from B is quite possible, and yet also slightly risky. Risky, not in the sense that it could go wrong, but in the sense of postponing the finalization of the promotion.
Now, that is not strictly correct, because we could move D to replicate from B asynchronously (postponed operation). This is a relatively recent feature that can be utilized.
And yet, we ended up with a stable, functional setup.


Add constant label or annotation in jiva PVCs for uniqueness

FEATURE REQUEST

What happened:
Not able to sort OpenEBS PVCs among given pods in the MayaView.
What you expected to happen:
In MayaView, we want to filter OpenEBS PVC pods from all the pods in the system. We want to sort based on label or unique annotation.

We need a label or a unique annotation so that we can filter OpenEBS PVC pods (controllers or services) from others displayed in scope based on that unique label or annotation.
It would be better to have a common label or annotation for all of these resources so that using a single label or annotation, we can filter out the OpenEBS PVC pods (controllers and services) from the others.

PVC objects themself are user created, we may not have an option to modify those. However, using the storageclass associated with the PVC we can determine if they belong to OpenEBS.
PVC Pods and other K8s objects need to be labelled. This will be implemented as part of the issue
https://github.com/openebs/openebs/issues/203


Add work simple title

https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1630
Details:

Add simple_title in Work
Add migration with script to populate simple title from full title
Make project title and worktype mandatory and display as unchangeable text in the title input
Update resource schemas to have simple_title

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (develop@6bd5f3a). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1733   +/-   ##
==========================================
  Coverage           ?   62.68%
==========================================
  Files              ?      248
  Lines              ?     8375
  Branches           ?        0
==========================================
  Hits               ?     5250
  Misses             ?     3125
  Partials           ?        0

Flag
Coverage Δ

epictrack-api
62.68% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Python 3 compatibility

Tasks:

[x] Fix code and tests to be Python 3 compatible. There's already PR #1 about this.
[x] Update classifiers in setup.py to include Python 2 and 3. Can use same classifiers as RF itself.
[x] Mention Python 3 support in README.rst.

PR #1 by @stasiek has been merged and 1.3 version with Python 3 support is already released.


Ability to shift ranges/sets up and down

It would be cool if you could, for example, "add one" to the range (1..3) to produce the range (2..4). This could be accomplished by adding some combination of Add/Sub/Shl/Shr implementations to all fo the range/set types. (Or maybe just adding a new trait would be best).

Implementing Shl/Shr is cute, but those can't be implemented for the std::ops ranges types. And having to do BoundedRange::from(0..10) >> 5 isn't super clean. So maybe a method on Rangetools is a better approach (or both?)

This would be useful in general, but the range type might need to change. For example, converting between file offsets (u64) and in-memory indexes (usize).


AFDX ?

Hello,
I was wondering if you thought about (in a far futur) implement Cyphal over AFDX ?
Maybe it is not compatible as both are protocols over the IP layer ?

It's not impossible. While AFDX is rather rigid compared to Cyphal due to the predefined VL configuration, sensible mapping of a limited subset of Cyphal should be possible. Whether it is meaningful is a different question. Can you please provide any background or justification for your request and perhaps a few words about the intended application?
See relevant notes here: https://forum.opencyphal.org/t/generalized-mapping-of-cyphal-to-transports/1761
Please reply in a new thread on the forum; I am closing this issue since GitHub is not the best place for discussions of this kind.


PEP 604 Support

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the Typer documentation, with the integrated search.
[X] I already searched in Google "How to X in Typer" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to Typer but to Click.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from pathlib import Path
import typer

def main(output: Path | None):
    typer.guess_name(f"Hello {name}")

if __name__ == "__main__":
    typer.run(main)

Description
Using an argument with the type of pathlib.Path | None (as per PEP 604) raise the error:
Type not yet supported: pathlib.Path | None

Wanted Solution
| None types should work instead of having to need to use Optional[].
Wanted Code
from pathlib import Path
import typer

def main(output: Path | None):
    typer.echo(output)

if __name__ == "__main__":
    typer.run(main)

Alternatives
No response
Operating System
Linux
Operating System Details
No response
Typer Version
0.4.0
Python Version
3.10.1
Additional Context
No response

I'm thinking if you can do this output: Path = None? When you have Path | None, the function expects either Path or None to be passed. Plus I believe Typer is tested for up to Python 3.9. This means most of the features from Python 3.10 might not work as expected. Let's just say certain recursive dependencies used by Typer also might have similar troubles.

+1
Even using Python 3.10 without the __future__  imports PEP 604 isn't supported.
@tiangolo Are there any plans to support this in the near future?

Could this be more of a Pydantic issue?

@navhits I'm not exactly sure what you mean. Pydantic supports PEP 604 type hints.

If that's the case, then try building from python3.10 branch. In my understanding 604 is a 3.10 focussed enhancement.

Ok. There's a 0.4.1 release already. Try this version @SRv6d

I've been on that version since march.

Seems this is still broken as of 0.7.0, even though that release is supposed to support Python 3.11 (and therefore I assumed these new type annotations included with Python3.10)

Yeps, running into this as well.
As we have pyupgrade in place enforcing PEP 604, I am in an awkward situation 🤔

As we have pyupgrade in place

Make them standalone types and pyupgrade will not change it.
PathOrNone = Path | None

def main(output: PathOrNone):
    typer.guess_name(f"Hello {name}")

As we have pyupgrade in place

Make them standalone types and pyupgrade will not change it. Or exclude the file from pyupgrade (your CLI interface is separated from the rest of your app, right?).
PathOrNone = Path | None

def main(output: PathOrNone):
    typer.guess_name(f"Hello {name}")

Last I tried, making them standalone types would still give errors in typer, as it just doesn't support the new union notation at all. If you pass it a standalone type, it'll just go through an extra hop to get the types that are in an union in the standalone type, and then fail again because it doesn't understand |

Sorry, bad example, I just woke up. 😂
PathOrNone = Optional[Path]

def main(output: PathOrNone):
    typer.guess_name(f"Hello {name}")

pyupgrade should not change Optional[] type aliases.

PathOrNone = Optional[Path]

Nice one, thanks!

Since the PR doesn't link to this issue, I'll link it here. This PR appears to be trying to fix this issue:

https://github.com/tiangolo/typer/pull/522

For visibility, the current open PR for this issue is

#676

Confirmed that either #676 or #548 will fix this issue!

Pydantic also has this issue and supports the union type as of pydantic 2.5. Not sure if this requires typer to support pydantic >=2.5?

Thanks everyone for the feedback! :coffee:
This should have been fixed by https://github.com/fastapi/typer/pull/548
It is now available in Typer 0.12.4 :rocket:


Config Set: Test isolation / validation

Currently .config.set should fail on non valid value is the only test that does not run in isolation (from js-ipfs-api under go-ipfs v0.4.15 :tada:)
However, I don't believe it's really testing what we want it to be testing. It appears it's trying to produce an error by passing an invalid type, similar to the non valid key test above it.
https://github.com/ipfs/interface-ipfs-core/blob/ef910266b36c89fe21f9821f86bdb9955d60b468/js/src/config/set.js#L75-L87
The issue is that a Buffer does not raise this error, as typeof <Buffer> is object. It also passes JSON serialization. The only reason this test passed was because the daemon it self rejected the type due to being set by a prior test.
https://github.com/ipfs/interface-ipfs-core/blob/ef910266b36c89fe21f9821f86bdb9955d60b468/js/src/config/set.js#L32-L41
I don't believe this is what is expected to be under test though.

In here I think we need to update the assertions to expect something more specific.
js-ipfs-api probably needs to reject buffers.

It should also probably match js-ipfs-repo

The only reason this test passed was because the daemon it self rejected the type due to being set by a prior test.

I'm not sure I understand - it was rejected because the value already existed for the key?

Not just because it existed, but due to the types mismatch. The config value Fruit was previously set as a string banana in the first test. When a value comes into that is not a string (jsonified buffer object), the go-ipfs daemon rejected the value because of type mismatch.


[L5] Cronjob out in SimpleMessage fails

There goes something wrong when trying to mail the Scheduled output:

$schedule
  ->command('foo:bar')
  ->dailyAt('01:00')
  ->sendOutputTo(storage_path().'/logs/cron.log')
  ->emailOutputTo('backup@mail.com');

Output is send to the log-file.
Using the Mailgun as a service for e-mail.

http://stackoverflow.com/questions/28737452/laravel-5-scheduler-cronjob-output-to-mail?noredirect=1#comment46082228_28737452

I'm using sendmail to send mail and I'm seeing the same error, so I think the problem is unrelated to the mail service type.

Unrelated, what handler is producing that stack trace?

Did you ever get this sorted>

I just did a composer update and the issue appears to have been fixed in a recent update.  (Possibly thanks to the update from SwiftMailer v5.3.1 to v5.4.0?)


Bug: re-migrating index on multiple fields fails with ERROR: relation ... already exists (SQLSTATE 42P07)

Hey!
I'm on v0.2.3 and I'm consistently having problems with unique indexes on multiple fields. Re-migrating the schema fails with the following exception:
{
    "error": "failed creating schema resources: sql/schema: create index \"slack_oauth_v2responses\": ERROR: relation \"slack_oauth_v2responses_slackoauthv2response_access_token_authe\" already exists (SQLSTATE 42P07)"
}

This is reproducible across more than one ent, and happens consistently when the index consists of more than one field.
Here's one example:
// Indexes of the SlackOAuthV2Response.
func (SlackOAuthV2Response) Indexes() []ent.Index {
	return []ent.Index{
		index.Fields(
			"access_token",
			"authed_user_id",
		),
	}
}

// Fields of the SlackOAuthV2Response.
func (SlackOAuthV2Response) Fields() []ent.Field {
	return []ent.Field{
		field.Enum("status").Values(
			"token_granted",
			"token_revoked",
		),
		field.String("access_token").Immutable(),
		field.String("token_type").Immutable(),
		field.String("scope").Immutable(),
		field.String("bot_user_id").Immutable(),
		field.String("app_id").Immutable(),
		field.String("team_id").Immutable(),
		field.String("team_name").Immutable(),
		field.String("enterprise_id").Immutable(),
		field.String("enterprise_name").Immutable(),
		field.String("authed_user_id").Immutable(),
		field.String("authed_user_scope").Immutable(),
		field.String("authed_user_access_token").Immutable(),
		field.String("authed_user_token_type").Immutable(),
	}
}

Looks like ent schema can't discover that the index already exists on the DB?
I'm happy to work on a more full-featured / self-contained example, but posting just this in case it's already helpful.
Unfortunately I can't revert to v0.2.2 and check if the issue persists there, as I'm relying on https://github.com/facebookincubator/ent/pull/527 (as you can see from the Ent name :) )

Hey @kkom,
Please provide the database dialect and its dialect.

Oups, facepalm.
Postgres 12!

Interestingly, this is the error message (as posted before):
{
    "error": "failed creating schema resources: sql/schema: create index \"slack_oauth_v2responses\": ERROR: relation \"slack_oauth_v2responses_slackoauthv2response_access_token_authe\" already exists (SQLSTATE 42P07)"
}

But I think this is the query which fails:
2020/06/10 10:21:20 Tx(8bf4c30d-347d-4232-ad3e-4786e8dcbe21).Exec: query=CREATE INDEX "slack_oauth_v2responses_slackoauthv2response_access_token_authed_user_id" ON "slack_oauth_v2responses"("access_token", "authed_user_id") args=[]

Note the relation name. Looks like some part of the code truncate the name and fails to discover the correct name?

Another piece of potentially helpful information is that this particular migration involved dropping a unique index on a single field (and exchanging that for a unique index on this field and another one):

It doesn't explain why the same problem is happening for a different ent, but I may have been confused there.

Found the issue. Index name is too long, and it's truncated by the database.
I'll give it a deeper look later. Thanks for reporting this.


Plot measurements should be in the Visualization menu in the tools

Headline says it all - I find it confusing that this widget is there.

Fine with me. We can have menus in multiple places. Example:
https://github.com/haesleinhuepf/napari-process-points-and-surfaces/blob/b1eee0567e9b879e8c873d7fc3c0a01752df039c/napari_process_points_and_surfaces/__init__.py#L321
Would you mind sending a PR @jo-mueller ?
Thanks!
Robert

Sure thing


Docs: Fix Url property in menu

The current docs don't build under Hugo v0.13. This is a simple fix that matches the property to what is detailed in the menu documentation page.
Specific error this fixes:
executing "partials/menu.html" at <.URL>: URL is not a field of struct type *hugolib.MenuEntry in partials/menu.html

I've only tested this in the v0.13 release version of Hugo, but I didn't see any breaking changes in master to change Url to URL.

The current docs is written for v0.14 and builds fine there.
For v0.13, see https://github.com/spf13/hugo/tree/v0.13.docs

My bad, I missed that.
Does that mean the next release is considered to have breaking changes?

That isn't breaking changes ... yet.
We have fixed a lot of Url => URL, Html => HTML etc., but will only print warnings in the next release.

Ah I see.
Sorry about the confusion. Thanks for the answer.


[tl_detector] Update code, add manual traffic light and also fix bug …

Couple of things here

[waypoint_updater] fix bug car didn't stop due to traffic data is data.data
[tl_detector] add rate to control freq of publisher and that would be used to control classifier for future, logic is the same no behavior changes
[tl_detector] Add manual light state for testing purpose, I added that in just for manual test which won't be used when using classifier as mentioned in lecture just convenience way to test traffic light

I tested locally and car did stop at traffic light

Refactor code as per @yangchunluo comment, please approve or merge


Pie: when label centered, should not move label when selected

Version
5.0.2
Reproduction link
https://echarts.apache.org/examples/zh/editor.html?c=pie-doughnut
Steps to reproduce

Add selectedMode: true to the option of the given demo
select a sector

What is expected?
The centered label should NOT move
What is actually happening?
The centered label did moved according to the sector user selected

going to look into the issue,pie charts are often used in my business scenarios.


fix: Fetch doesn't respect headers from 1st arg if its type is Request

Fixes compatibility with libraries that call the fetch API as fetch(new Request(...someParams)) without an init argument
One of these libraries is https://github.com/sindresorhus/ky (https://github.com/sindresorhus/ky/blob/main/source/utils/timeout.ts)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Should we have a changeset here?

@ghostdevv done :)


[Port to releases/v0]: Create check run through app with fallback for when app is not installed

Porting the changes to releases/v0.
Adding js files

LGTM! 🚀


Project renaming

:tada: This PR is included in version 2.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix BAM to FASTQ -  90513d30-5f47-473e-b180-c37a974fc03b

SOP: https://ebi-ait.github.io/hca-ebi-wrangler-central/SOPs/update_ena_runs_SOP.html
ENA project: https://www.ebi.ac.uk/ena/browser/view/PRJEB36885?show=reads
Events:

AdultHemOrgans project has 2 "datasets"/"submissions" that were archived
Submission 1 was archived - bam files were submitted
Submission 2 was archived - bam files were submitted (192 fastq = 64 bam files)
There were issues in the bam files. We want to replace them with the fastq files.
Submission 1 was re-archived - to replace the bam files with the fastq files, we ask for the suppression of bam files
"rearchived":
--- delete/"suppress" the old sequencing runs containing the bam files
--- create new sequencing runs containing the fastq files
All the bam files for 2 submissions were also suppressed.
Submission 2 files are now not available and we found out the sequencing experiment to sequencing run grouping is incorrect
--- create new sequencing experiments - 32 sequencing experiment
--- create new sequencing runs containing the fastq files - 192 fastq files

Problem:
The previous sequencing runs were suppressed (in ENA). The sequencing experiments to sequencing runs linking were incorrect.
Tasks:

Submit the seq experiments. Make sure to point to correct sample accessions.
Submit new seq runs - use SOP

The list of BAM files to suppress already has been sent to ENA when we worked on this ticket: Fix BAM to FASTQ - cb156730-90b0-4b77-944c-bfc263204c61

Step 9 (Started) - Copy from Terra from this location: broad-dsp-monster-hca-prod-ebi-storage/prod/455b46e6-d8ea-4611-861e-de720a562ada/data has started into EBI cluster into /nfs/production/hca/90513d30-5f47-473e-b180-c37a974fc03b folder.

Alegria working on this.

It looks like the files for this submission(90513d30-5f47-473e-b180-c37a974fc03b) were already downloaded to the ls /nfs/production/hca/cb156730-90b0-4b77-944c-bfc263204c61/ .

Had a meeting with Alegria, we are going to re-prioritise this.
Needs several actions:

[ ] Determine the correct linking
[ ] Delete the experiments associated with this submission
[ ] Re-submit with the proper experiments/sampels/runs linking

It looks like all bam files are all suppressed so I'm setting this ticket high priority now because the bam files we need to replace are no longer showing in the ENA browser.
Enrique already confirmed that the linking should be correct in Ingest. We need to re-archive this submission such that only sequencing experiments will be submitted via DSP and use the direct ENA route to submit new sequencing runs and fastq files.

@aaclan-ebi will set up a meeting with @ESapenaVentura @amnonkhen  @prabh-t  to discuss how to archive the submission

@ke4 @aaclan-ebi  @ESapenaVentura and @prabh-t to have a meeting today

@prabh-t and @aaclan-ebi to pair

Started working with @prabh-t on this. The specific steps are listed in https://docs.google.com/document/d/1xtw6kJPbcB1gDnszfZn_QFc-lCd8qnxHdbzPA-n8eQQ/edit

@ke4 to check if he still got the md5 values for the files

@prabh-t working on this, thanks!

@aaclan-ebi and @prabh-t kept pairing on this yesterday. They experienced slowness. Maybe due to validation happening redundantly. @aaclan-ebi is going to create another ticket

Marking this ticket as also externally blocked because of issue in DSP connection with AAP API.

The AAP issue is now fixed, will work on this after the AdultLungElo archiving ebi-ait/hca-ebi-wrangler-central#724

Also blocked by BioStudies validation :(

There is no need to submit to BioStudies, this is not blocked by BioStudies issue in #724.

The new sequencing runs and the fastq files have been submitted to ENA. They should be available soon in the ENA browser https://www.ebi.ac.uk/ena/browser/view/PRJEB36885?show=reads
The metadata entities for this project have been updated with new sequencing run accessions. The updates need to be submitted to DCP.

@ESapenaVentura  - please check this and then move the ticket further

The logging credentials were not working yesterday, @ESapenaVentura to try again today as yesterday there were some downtimes on ENA

No new update. ENA downtime on Friday.

We are going to escalate it with ENA Helpdesk.

@ESapenaVentura to reach out to Rasko, as he is the best contact for this

@ESapenaVentura to talk to ENA


Adding additional variables to HRRR and GEFS lexicons

Earth2Studio Pull Request
Description

Checklist

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci


Add kubernetes service related resources to terraform

This is an enhancement ticket to add support for CloudStack Kubernetes service through Terraform. We need to add CRUD operations for CKS in Cloudstack terraform provider.

@davidjumani @harikrishna-patnala is this implemented already to use terraform for the cks?

Any progress on this ? Thanks

Added in 4.16.1 https://github.com/apache/cloudstack-go/pull/33/files#diff-b28a8efd29239ed5505919480c05f97432719c96d98cd370752bf0d1925020
ping @harikrishna-patnala

Hi @lukasmrtvy, this is not yet implemented in terraform providers, someone needs to pick this up. @davidjumani may take this based on our recent conversation.


[Viber] Public Account

I don't know is it still possible to create an Public Account for Viber. This link https://www.viber.com/public-accounts not work anymore, and here https://twitter.com/ViberHelp/status/987012208071671809. Is there any replace solution

Hi @nguyen991, you may want to try this link:
https://partners.viber.com/login?returnUrl=%2Faccount%2Fcreate-bot-account
It should work.


Add parser::limit

From pre-Boost-review feedback

Added body_limit and header_limit

Hi Vinnie, sorry it's not clear to me the simplest way to customise the body limits, at the moment I'm reading data in a very easy way:
 boost::beast::flat_buffer buffer; http::response<http::string_body> res; http::read(socket, buffer, res);
But my payload exceeded 8MiB. It seems that I need to define a custom parser, does I really need to do this? and suppose I do so, how my custom parser (as described in https://www.boost.org/doc/libs/develop/libs/beast/doc/html/beast/ref/boost__beast__http__basic_parser.html) fits in my code?
I successfully used your great library in many standard situation, but I struggled a bit in those kind of customisation and I fear to follow too much complex way to just increase a buffer.
Thank you for your time!

The documentation explains how to use the parser-oriented interfaces and provides example code:
https://www.boost.org/doc/libs/1_66_0/libs/beast/doc/html/beast/using_http/parser_stream_operations.html

Yeah, sorry you are right, I missed that page, I reached my goal this way:
boost::beast::flat_buffer buffer;
http::response_parser<http::string_body> parser;
parser.body_limit(16 * 1024 * 1024);
http::read(socket, buffer, parser);
std::cout << parser.get().body() << "\n";

thank you again


question: Correct way to check consumer/producer health using KafkaJS API

First of all, I just want to say how happy I am to see confluent release an official JS client. Love the idea to make it compatible with KafkaJS/node-rdkafka. :+1:
Now for the issue
I don't see a way to get the current state / health of a consumer or producer using the KafkaJS api.
When using the node-rdkafka api, it looks like I can hook into lifecycle events using consumer.on('ready',...) etc.
But when using the KafkaJS api, the .on implementation is not implemented, and the state is marked private. With KafkaJS we were previously hooking into these lifecycle events to keep track of the consumer state, which we used for our Kubernetes readiness probes.
Is there any plan to implement events on the KafkaJS api?

Thanks for the feedback!
We don't yet plan to implement the on stuff in the near future. Using await on the connect method is identical to consumer.on('ready' ...), since internally, we're using that lifecycle event to determine when the connect promise resolves.
What states are you looking to track? I can try and help you with those particular cases (for instance, for rebalance, we have made a rebalance callback available), and think if a more generalized approach is possible.

Hey @SeanReece, we're generally very slow to expose any public interface because it means that we'll have to support it forever (we go as far as to deprecate something, but removing it completely is something and breaking something that previously worked is almost impossible).
In general, the idea of re-emitting events actually does make sense, because one can get them through the node-rdkafka API already. It's probably possible to emit a subset of the 'on' events, and throw an error if someone tries to register an error for an unsupported event type.
I'll discuss this internally and see if we can possibly expose such an API. We also need a way to expose client-level errors, which isn't present at the moment, so maybe we could use this for that reason too.
Two things specifically for your case though:

since we're using librdkafka internally, the consumer will never disconnect without the user calling disconnect explicitly. Even if there is a network issue and we lose connectivity to the brokers, it'll keep on trying to connect forever (though eventually it'll leave the group on its own, and there will be no messages).
there's no way to indicate the start of a rebalance. We raise an event for the rebalance after a few network calls with the broker, when we are actually assigned some partitions (or if some partitions are revoked). If there's a misbehaving client, it might take up to sessionTimeout (default 30) seconds between the start of the rebalance and the assignment of partitions.

You can specify rebalance_cb in the KafkaJS consumer interface without needing to implement rebalancing, I've been testing this for a while. As long as you return undefined, the client will take that as a signal you aren't changing the assignment and will use the default implementation, or whatever partitionAssigners you configured.
In my rebalance_cb, i apply a small debounce and then emit an event to higher levels of the system


Support for hybrid (node) module polyfills

Describe the feature
Unenv's presets allow us to mark certain modules as natively supported by a given host environment. For example Cloudflare's workerd natively supports several APIs in node:buffer, and the cloudflare preset specifies this module as natively supported: https://github.com/unjs/unenv/blob/c6dca1dfac95bd6359e8575d4456635914823701/src/presets/cloudflare.ts#L8
The issue I see is that workerd supports only some node:buffer APIs but not all. Specifically it supports Buffer and SlowBuffer APIs, but not Blob or File, which are part of Node's buffer module.
What I'd really like is if I could modify the Cloudflare preset in a way that would create a hybrid module polyfill for node:buffer which would provide the natively supported APIs of workerd's node:module while, using the unenv mock (or polyfills` for the remaining APIs.
I gave this a shot locally, but I wonder if this is actually possible at all with the current way unenv works. The problem I see is that we'd need a way to preserve access to the "native" node:buffer while also defining an alias for it. And since all aliases are flattened, I don't see a way how we can have both. Am I missing something? Is there some creative solution to this?
Or is the only way to achieve this to modify workerd to alias node:* modules via an alternative module prefix (e.g. node-unenv:*) so that unenv can internally use these modules while overriding node:* specifiers using module aliases?
Additional information

[x] Would you be willing to help implement this feature?

It seems an interesting idea. If workerd could provide an alternative way to access node polyfills like workerd:node:buffer it would make it much easier since we could partially import them in our polyfills (even opened a better way to opt-in to things like async context)
An alternative would involved unenv + specific bundler (rollup/vite/nitro) plugin that preserves external imports from node_modules/unenv/cloudflare.mjs. It is certainly doable but also would be not most stable path because we need to also allow node: externals in renderChunk hook and in there we don't have a way to tell if source of node:buffer import was the unenv polyfill parent or a virtual file for example.

ok, thanks for the confirmation @pi0. I'll discuss with the team, and get back to you.

We discussed this and it appears that the easiest way for us to support this is via a newly proposed (and almost landed) process.getBuiltinModule API.
It would be fairly easy for us to implement it and return the native module which could then be used by unenv to compose a hybrid polyfill.
If user code uses process.getBuiltinModule to access the native module then they'll see only the workerd version of the API, which is fine as we expect only very specialized code and not general npm packages to use this newly added node API.

One observation that came out of https://github.com/cloudflare/workerd/issues/2129 is that if we want the polyfills to be truly hybrid, we'll need to update internal module and symbol references to be absolute so that we don't end up with multiple implementations of an API due to internal references not respecting the presets overrides.
I don't believe that this is a show stopper, it's just something that will take special consideration.

Thanks for the pointer. I think in platforms such as worked that can actually implement Socket, unenv and nitro can be configured to directly leverage it.
The network stack of unenv is actually in use today, it allows direct fetch calls in server-side of Nitro without an actually network round-trip.

Closing as hybrid approach is already adopted by cloudflare wrangler tooling.
Preset being externalized #336 also, and later for other places such as Nitro we new method.


Update ouroboros-network & tracing changes

Make the following traces on by default:

TraceConnectionManager
TraceInboundGovernor
TracePeerSelection
TracePeerSelectionActions

All of them are not chatty if network conditions are stable.

Fix peer selection tracer.
Add transition tracers

input-output-hk/ouroboros-network#3571

bors merge

bors merge

bors merge


Windows Defender shows a virus

Windows Defender blocks the download, because of Trojan:Win32/Spursint.Q!cl. The ACNHPoker Release 17.2 does no issues.

turn windows security real time protection off and it should work just find and keep it off why using acnhporker then when not using porker turn it back on. hope this will help.

This might help, but is there a Trojan or not 🤔.

no there is not a trojan at all.


Migration Estimates

This PR adds an estimate to the migrations alert, giving an indication of when migrations will complete. This is obviously just a rough estimate and will likely be an underestimate on large nodes but at least it gives an idea which imo is useful regardless of how accurate the estimate ends up being.

moved to DRAFT, I realised this is wrong because it doesn't take into account parallelSlabsPerWorker


RMD Upgrade to ruby 3 and update niftany

Fix niftany errors.  Generate todo if there are too many.

related #448

closed by #485


Conditional classes based on a date field does not work in non-US locales

This example (https://docs.microsoft.com/en-us/sharepoint/dev/declarative-customization/view-formatting#conditional-classes-based-on-a-date-field) does not work where site locale is set to display dates DD/MM/YY

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 002a1ee9-dc9f-8dc1-6f3c-ef23297b83d4
Version Independent ID: 82565c7e-b264-94f5-8708-d4757482e133
Content: Use view formatting to customize SharePoint
Content Source: docs/declarative-customization/view-formatting.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

I have encountered this problem too, and blogged about it here. https://cann0nf0dder.wordpress.com/2019/03/09/sharepoint-online-custom-format-view-issue-with-now-and-uk-date-format/


fix formatting issues

the purpose of this PR is to fix indentation and extra chars

Did you run mix format?

no, I didn't

Ah. I see. The changes are in the templates. Formatter doesn't reach into there, but will create an app that needs formatting.
I'll take a better look at this when I'm not tired.

OK. Took the changes and did more so that now the generated app passes the formatter with no changes.


Add license

Can you please add a license to this repo? I like your work here and want to build on it. 👍
I created a PR with CC0 for an easy merge: https://github.com/auntyellow/24/pull/3

Thanks :-)


CF-1585: fix broken style so new version of node-sass will compile our sass

In the process of upgrading protractor, node and node-sass also needed to be upgraded. node-sass was more sensitive to certain error in our style files, which needed to be fixed.

The placeholder was partly implement in css and not sass
media queries cannot extend from outside of themselves
http://stackoverflow.com/questions/14840918/extending-selectors-from-within-media-queries-with-sass
%tiny was brought over from metric-views, and still referenced.

Wouldn't we have to update all of the @extends references to @includes here as well? I'm more than certain there are more than just these 2 uses of font sizes in our Sass.


Adding more Color overloads for brush properties

Before: Some properties had overloads taking a Color value in addition to IBrush and a color string.
This commit adds overloads for brush properties missing a Color overload making it more consistent and ergonomic since at least in my mind setting the brush to a solid color is probably the most common scenario.
I was tempted to also change the parameter names in some cases where they are the generic term "value" to "color"/"brush" but then refrained since it could possibly break someone's code if they use named parameters and also not sure what you think of such a change.

It would surprise me if the parameter names were used.


PSP Encryption Option

The current specification is based on that Issuers (or delegates of theirs), decrypt FWP assertions.
There may be scenarios where PSPs would be more suitable performing this step.  Suggestion:
Make encryptionKey, contentEncryptionAlgorithm, and keyEncryptionAlgorithm in a credential entry optional.
The following modified sample code shows how this could be accomplished:
const methodData = [{
  supportedMethods: "fido-web-pay/v1",
  data: {
    payee: "Space Shop",  // Shown in the UI
    networks: [{
      name: "https://emvco.com/fwp/mastercard",
      encryption: {                           // New optional element
        encryptionKey: {
                                              // JWK
        },
        contentEncryptionAlgorithm: "...",    // JWE compatible
        keyEncryptionAlgorithm: "..."         // JWE compatible
      }
    },{
      name: "https://emvco.com/fwp/visa"
    },{
      name: "https://europeanpaymentsinitiative.eu/fwp",
      networkData: "additional stuff..."
    }]
  }
}];

That is, the payment method https://emvco.com/fwp/mastercard may use PSP encryption and decryption.
If a selected credential contains the encryption parameters and they are supplied in the associated networks object as well, the credential parameters takes precedence.  That is, Issuers always stay in control of the encryption policy.
If neither the selected credential nor the associated networks object contains encryption parameters, an exception MUST be thrown.
In all cases all three parameters MUST either be available or absent, otherwise an exception MUST be thrown.

This is probably a rather bad idea, Delegated Authorization can do the same thing and can also control who is actually allowed to decrypt.  If the purpose for finding out peoples account numbers is only related to aggregating data, this is not the right way.  Loyalty cards is the way to go for managing relations.

I think this idea needs more work because the current draft may a bit too static with respect to encryption.  The issuer should still be in control.  Discovery services may be the right approach although they add some complexity to the client application.
PSP-based encryption should only require merchants supplying a URL which merchants could fetch from the PSP on a daily basis.  The client could then cache key URLs so that only when there is a new URL there would be a need to fetch encryption parameters.  The encryption parameters would then be:

Public Key
Key Id
Key Encryption Algorithm
Content Encryption Algorithm

For issuer-based encryption things are slightly more complicated since there is no way to signal that a new key is available.  However, it should be sufficient if the client updates this on a periodic basis with low frequency, like once in a week or month.
A static URL in the credential database would then return encryption parameters like above but a list of supported PSP domains as well.  That is, if a PSP-suppled encryption key URL is not in the list of trusted domains, the client must reject the payment request.


Support dynamically creating Db?

I want to write a Content Provider, Having some different database named with MD5 value, these databases have the same Table. So, The demand is that, If I get the MD5 value which never match the database name,then create a new database named with the MD5 value, like "82926c5054b3fc5dc4df85eaadd418de.db", how to create database dynamically for this demand?
If I use this method:
ContentUtils.insert(getContentResolver(), xxxx.CONTENT_URI, model);
how do I judge which database I insert data into ?

Dynamic databases are not supported as of now in DBFlow.


Add exit and report_exception syscalls.

This calls can be used to notify the debugging agent that some exception has occurred or that the program has finished executing.
Please note that I changed syscall interface to also accept integers, not just pointers. Converting arbitary numbers to pointers does not seem like a good idea.

Thanks, @pftbest. This is looking good! I left a question about the signature of exit.

I've decided not to pass custom exit codes because it is an ugly hack and I don't know if it will work at all on other debuggers. And it doesn't work with QEMU, which is the main target for using this call.

Thank you, @pftbest!