Data and type mismatch found if a string happens to parse as a specific type

Describe the bug
I have a toy API that exists for testing ASP.NET Core functionality, and one of the resources describes times and acts like a clock.
The schema for the response of this endpoint is below:
"TimeResponse": {
  "type": "object",
  "properties": {
    "timestamp": {
      "type": "string",
      "description": "The timestamp for the response for which the times are generated.",
      "format": "date-time"
    },
    "rfc1123": {
      "type": "string",
      "description": "The current UTC date and time in RFC1123 format."
    },
    "unix": {
      "type": "integer",
      "description": "The number of seconds since the UNIX epoch.",
      "format": "int64"
    },
    "universalSortable": {
      "type": "string",
      "description": "The current UTC date and time in universal sortable format."
    },
    "universalFull": {
      "type": "string",
      "description": "The current UTC date and time in universal full format."
    }
  },
  "description": "Represents the response from the /time API resource."
}

This response explicitly has:

One date-time for ISO-8601
One int64 for Unix timestamps
Three string properties that are string representations of dates that do not conform to ISO-8601

It also contains the following JSON example for the schema:
"example": {
  "timestamp": "2016-06-03T18:44:14+00:00",
  "rfc1123": "Fri, 03 Jun 2016 18:44:14 GMT",
  "unix":<PHONE_NUMBER>,
  "universalSortable": "2016-06-03 18:44:14Z",
  "universalFull": "Friday, 03 June 2016 18:44:14"
}

The example is valid for the moment in time that it describes.
If the schema is validated according to the validation rules with code such as the below, it generates 4 validation warnings:
[Fact]
public void SchemaGeneratesNoValidateWarnings()
{
    using var streamReader = new StreamReader("openapi.json");
    var reader = new OpenApiStreamReader();
    var document = reader.Read(streamReader.BaseStream, out var diagnostic);

    var errors = document.Validate(ValidationRuleSet.GetDefaultRuleSet());
    Assert.Empty(errors);
}

[
    Data and type mismatch found. [#/paths/~1time/get/responses/200/content/application~1json/example/rfc1123],
    Data and type mismatch found. [#/paths/~1time/get/responses/200/content/application~1json/example/unix],
    Data and type mismatch found. [#/paths/~1time/get/responses/200/content/application~1json/example/universalSortable],
    Data and type mismatch found. [#/paths/~1time/get/responses/200/content/application~1json/example/universalFull]
]

For the three "date-ish" values, this is because this line of code treats the value as an OpenApiDateTime as it happens to parse as a DateTimeOffset:
https://github.com/microsoft/OpenAPI.NET/blob/6899d5f161bd0087ccea0a090cebbe4eaffdf99a/src/Microsoft.OpenApi.Readers/ParseNodes/OpenApiAnyConverter.cs#L64-L73
This then fires the validation warning here as the type test fails:
https://github.com/microsoft/OpenAPI.NET/blob/306dda230f197c230efd71f15953f2a06eb82289/src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs#L256-L266
For the int64 value, because the value is less than int.MaxValue + 1, this code treats the value as an int32:
https://github.com/microsoft/OpenAPI.NET/blob/6899d5f161bd0087ccea0a090cebbe4eaffdf99a/src/Microsoft.OpenApi.Readers/ParseNodes/OpenApiAnyConverter.cs#L138-L146
This then causes the type test to fail in a similar fashion:
https://github.com/microsoft/OpenAPI.NET/blob/306dda230f197c230efd71f15953f2a06eb82289/src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs#L148-L158
OpenApi File To Reproduce
openapi.json
Expected behavior
The example is valid according to the schema, so should not generate any validation warnings.
Screenshots/Code Snippets
N/A
Additional context
Found through use of Kiota to generate a typed C# client for the OpenAPI schema as part of https://github.com/dotnet/aspnetcore/issues/56318#issuecomment-2206724644.

Hi @martincostello, thanks for pointing out this issue.
This is clearly a regression bug as a result of trying to fix this issue https://github.com/microsoft/OpenAPI.NET/issues/1526.
Let me look into it.
PS: This issue will go away in V2 as we're getting rid of the strongly typed structure during parsing examples as we'll treat them as their JSON compatible values.


[BUG]can not see Save to Memory in Knowledge-table?

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior
Expected behavior
A clear and concise description of what you expected to happen.
Logs and Error Reports
If applicable, include any relevant console logs or error reports to help diagnose the issue.
Screenshots
If applicable, add screenshots to help explain your problem.

Hi lwing, thanks for this - the save to memory feature is not something that is part of the open-source UI, but what we built for clients that wanted to integrate Knowledge Table with the Knowledge Graph Studio.

The video we have in the Github Readme reflects the UI that is available in the open-source repo.


Keylogger dosen't work!

I also need the keylogger function to work :100: %

Can you describe in a little more detail how it doesn't work? Need the OS, architecture, commands you ran etc...

I've tried this tool on some windows xp and windows 7 but the logger dosen't work ..

... ok, i'm still going to need more information, how did you run implant.py? the commands you ran using Gcat? need the OS architectures etc..

Windows-XP-5.1.2600-SP3-x86
this was the last one ..
I just open win CMD and run the implant.py file ..
python gcat.py -id 9d861ed4-4225-5f7e-bd62-d0dc61224b24 -start-keylogger
after that I do ..
python gcat.py -id 9d861ed4-4225-5f7e-bd62-d0dc61224b24 -stop-keylogger
and I never see any log file from the keylogger !

Did you follow the instructions in the Readme? did you edit the user and password values in the scripts? did you enable IMAP in the Gmail account ?

yea -_- everything eles is workin .. its just the keylogger ..

you did compile implant.py correct?

no I tested it uncompiled..
do I have to compile it for the keylogger to work ? :3

yes


Undraft the bylaws: Trademark Policy [due 2 Aug]

Continuing with our reviews: the Trademark policy.
voting group: @commonhaus/cf-egc
Do one of the following:

Approve the PR or react with 👍 (:+1:) if it looks good to you
Review with Comments or react with 👀 (:eyes:) if you're "ok" with it (it may not be your favorite)
If you think it needs discussion or revision

Create a review, add your comments and require changes
Use the +- button to make a suggestion (instead of just adding a comment).

Incorrect [CF Mark] by [your company name]

OpenRewrite objects to this constraint. I think it is incompatible with CommonHaus’ general policy that the foundation doesn’t interefere in the governance of projects. It is clear that Moderne is the governing maintainer of OpenRewrite (at the current time) regardless of who legally owns the trademark.

I'll ask some questions to make sure I understand the boundaries of this language.

I know why the "x by " exist as problematic in other similar ones and that's because it makes it sound like X is provided by the company and only that company.
I'm wondering if "x sponsored by " would work as that is less exclusive and more descriptive of the situation?
(IANAL :)

I know why the "x by " exist as problematic in other similar ones and that's because it makes it sound like X is provided by the company and only that company.
I'm wondering if "x sponsored by " would work as that is less exclusive and more descriptive of the situation?
(IANAL :)

Yes. This is right in-line with the questions I want to ask.
I am seeing some confusion, as this policy does not prohibit general usage of the marks, it only prohibits usage outside the guidelines of the policy.

The use of the Mark cannot be used to imply that the Commonhaus Foundation or its projects are sponsoring or endorsing your product.

Note the directionality: Commonhaus/Project -> you/your product.

Do not use CF Marks (Logos or Word Marks) in any commercial or marketing context other than as expressly permitted in this policy unless you have obtained explicit written permission from the Commonhaus Foundation to do so.

"expressly permitted" is what we need to explore, but written permission should not be considered a barrier. We can create transparent/written agreements that make trademark ownership + allowed usage clear. CF has no reason to make it harder to talk about projects. The trick is ensuring that the trademark can be defended, and having permission in writing can help with that.

extended deadline so we can think through options

vote::result
I'm going to close this one for now, and re-open with revisions to address the concerns raised.


Build problem: Version subcommand useless

$ docker run --rm -it dshanley/vacuum:v0.12.1 vacuum version
latest

I've intentionally specified non-latest docker image tag...

This is a specific issue with the Docker build that needs to be addressed, it does not apply to the published binary.


error string internationalisation

Hi,
I need to show error msg for Arabic users which not supported (https://github.com/vekexasia/android-edittext-validator/tree/09a1a466e687e9afb4eef0daf3f179cdae8b967f/library/res)
So I use [whatever:emptyErrorString="@string/msg_invalid_data_empty"] into my layout xml file.
But it only shows fr msg which is the default language of the phone. Even I force my app to use Arabic language (all other UI are correctly in Arabic).
And when I use a Validator from java like this
 MultiValidator tmpValidator = new AndValidator();         tmpValidator.enqueue(new FormAlphaNumericValidator(getResources().getString(R.string.msg_invalid_data_format)));         tmpValidator.enqueue(new EmptyValidator(getResources().getString(R.string.msg_invalid_data_empty)));         mScannedDocNumber.addValidator(tmpValidator);
My FormAlphaNumericValidator extends AlphaNumericValidator show correctly the error msg in Arabic. But not the EmptyValidator.
Are there a better way to show error msg in Arabic, or should I extends all needed Validators ?
Thanks,

Just create The translations and submit a pull request :)
Il 01 ago 2016 12:14 PM, "megadmini"<EMAIL_ADDRESS>ha scritto:

Hi,
I need to show error msg for Arabic users which not supported (
https://github.com/vekexasia/android-edittext-validator/tree/09a1a466e687e9afb4eef0daf3f179cdae8b967f/library/res
)
So I use [whatever:emptyErrorString="@string/msg_invalid_data_empty"] into
my layout xml file.
But it only shows fr msg which is the default language of the phone. Even
I force my app to use Arabic language (all other UI are correctly in
Arabic).
And when I use a Validator from java like this
MultiValidator tmpValidator = new AndValidator();
tmpValidator.enqueue(new
FormAlphaNumericValidator(getResources().getString(R.string.msg_invalid_data_format)));
tmpValidator.enqueue(new
EmptyValidator(getResources().getString(R.string.msg_invalid_data_empty)));
mScannedDocNumber.addValidator(tmpValidator);
My FormAlphaNumericValidator extends AlphaNumericValidator show correctly
the error msg in Arabic. But not the EmptyValidator.
Are there a better way to show error msg in Arabic, or should I extends
all needed Validators ?
Thanks,
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vekexasia/android-edittext-validator/issues/46, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAMPS5-YTot2a_ca1Bzh0jBD7BZcbfQ8ks5qbccAgaJpZM4JZcJV
.

OK. I will.
But just to confirm, passing a custom string to the constructor do not really change the error msg ?
new EmptyValidator(getResources().getString(R.string.msg_invalid_data_empty)));

Depends on the validator. but correct way to localize is to create proper
string values for the desired language
On Mon, Aug 1, 2016 at 1:23 PM, megadmini<EMAIL_ADDRESS>wrote:

OK. I will.
But just to confirm, passing a custom string to the constructor do not
really change the error msg ?
new
EmptyValidator(getResources().getString(R.string.msg_invalid_data_empty)));
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vekexasia/android-edittext-validator/issues/46#issuecomment-236555090,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMPS14VuIEdJU8kD2NvdDEcRSkCuMuLks5qbdcZgaJpZM4JZcJV
.

--
Andrea Baccega
[image<EMAIL_ADDRESS>[image<EMAIL_ADDRESS>[image: Personal site] http://www.andreabaccega.com/ [image: Linkedin
Profile] http://it.linkedin.com/in/andreabaccega [image: Facebook]
https://www.facebook.com/andrea.baccega [image: Google+]
https://plus.google.com/109217393200753135791 [image: Twitter]
http://twitter.com/veke87 [image: StackOverflow]
http://stackoverflow.com/users/314407/andrea-baccega [image: GitHub]
https://github.com/vekexasia

Hi,
I add the string.xml for Arabic language and wait you accept the pull request :)
but I also added the library code to my project as a library, and even I used the Arabic string file, the translation is not supported yet.
So I make an other test and I found when I change the phone language from the phone settings to Arabic, the Arabic translation is working fine when I set my application language to Arabic (programmatically). But other languages are no more working!!
And that's only for the empty validator!!
Any suggestions please?

waiting for the pull acceptation :)

Done, will release it today :) thank you and sorry for the delay.


Maintain a Communication Arrangement for an Exposed Service

Tutorial URL: https://developers.sap.com/tutorials/abap-environment-communication-arrangement.html
Please specify the step you are referring to
Step 9: Select scenario
Select your scenario and click on Create
It's not clear where the scenario is createt, I can only pick up an existing scenario

Hi @niloofar-naseri,
can you have a look at it?
Thank you.
Best regards,
Merve

Hi @hdix01
This Scenario is the same communication Scenario which you created in the step 9 of this tutorial,
https://developers.sap.com/tutorials/abap-environment-business-service-provisioning.html
If you do all tutorials in the right sequence, it will be clear what scenario is meant.
But I can make it specific and adress the other tutorial in this step.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


Support using either ttrpc or grpc for shim

Currently the shim API uses ttrpc for communicating with the shim. This has performance advantages in the shim over using grpc. For some cases grpc may be easier to integrate with, so it should be configurable. ttrpc and grpc only differ by their wire protocol, they use the same proto definitions.

I have attempted to work on this issue but I am hitting a major issue unless I missed some step along the way.
In order to support GRPC, I wanted to generate the client/server code for GRPC in addition to the ttrpc which is there already. As far as I can tell, I cannot generate for both since they step on each other unless I were to pick separate directories.
Is there some example which shows how grpc and ttrpc can be supported simultaneously?

So I looking into this and found the same thing.  For the server side implementation in containerd, its pretty simple to switch between the two different clients.  shim authors will probably choose one or the other and not build both servers.
I think we only want this done in the runcv2 work that is about to be merged in master.  You don't have to do it for the existing runtime and containerd-shim

So I switched over to the v2 codebase. But its still a similar issue if we want to generate GRPC bindings for the client. We need to keep ttrpc and grpc generated code in separate packages.

Ya, I think that is fine.  We can keep the proto in a directory and generate both in subdirs.
task/
task/ttrpc
task/grpc

What do you think ?

Makes sense. Now to bend Protobuild to make it happen.

Long story short, between protobuild and the go_package option, the output is hardcoded.
Now I can probably generate and move the file but that would be the only way given how it is currently structured.

I played with every possible combination. There is no way to have the generation place the files as you describe above. It will always place it in github.com/containerd/containerd/runtime/v2/task/. I can change the directory where it is placed, e.g., ./grpc or ./ttrpc off of github.com/containerd/containerd. I can also change the package name so I could copy it to some other location like I mentioned.
The alternative is to symlink the proto.
The only other issue I see with having task/grpc is that it collides with the standard grpc package.
Let me know which of the bad options you would prefer....

No, we've implemented this. Closing.


Tweak default float step range to only allow values that always work

3.x version of https://github.com/godotengine/godot/pull/58763.
32-bit floats cannot store increments smaller than 0.0000001 (even at values close to 0).

The step of 0 was used on purpose when I implemented it, see https://github.com/godotengine/godot/pull/30776.
Back then it worked fine AFAIK, it removed the step and made it possible to set any value.

It still seems to work mostly fine, what is the bug that his PR aim to solve exactly?
https://user-images.githubusercontent.com/4701338/157115606-90f30d2f-09fc-4869-bcc3-0d683864e2c8.mp4
I say mostly because as you can see in that video it's a bit erratic, sometimes mouse clicks don't properly register or number/dot inputs lose focus. I don't know if that's a bug in current 3.x or a side effect of the changing stepify factor.

The step of 0 was used on purpose when I implemented it, see https://github.com/godotengine/godot/pull/30776.

It doesn't seem to behave well in master, which is why I originally opened https://github.com/godotengine/godot/pull/58763. I thought about cherry-picking it to 3.x for consistency.


scatter chart: enable configuring color opacity of points

I'm struggling with configuration of opacity of colors in scatter plot. No matter how I change color and colors, opacity of points is still set to random (or at least that's what I feel it is). I'd like to a) either be able to configure it myself b) or disable it completely and let all points have same opacity.
Is this possible somehow?
I appreciate any kind of feedback, thank you!
Sample data:
  data: {
    json: json_data,
    keys: {
      value: ["date", "hours"]
    },
    x: 'date',
    xFormat: '%Y-%m-%d',
    type: 'scatter',
    color: function(color, d){ return "#ddd"; },
    colors: {  // has no effect
      hours: '#ff0000',
      date: '#00ff00'
    }
  };

+1
event the opacity in the scatterplot example seems random: http://c3js.org/samples/chart_scatter.html

Here's one possible solution: https://groups.google.com/forum/#!searchin/c3js/opacity|sort:date/c3js/HEn9VHktVRs/gv0urZZcCAAJ

Here's how to force the opacity to 1 with CSS:
.c3-circle {
opacity: 1 !important;
}

This line: https://github.com/c3js/c3/blob/master/c3.js#L1932
return isValue(d.value) ? this.isScatterType(d) ? 0.5 : opacity : 0;
Has caused some frustration. Currently all visible scatterplot dots are shown at half opacity. It would be awesome if this was configurable in the JS like others have mentioned above.

Found another way to fix the issue, use the Onrendered call:
onrendered: () => {
  $(function () {
    $('.c3-circle').filter(function () {
        return $(this).css('opacity') == '0.5';
    }).css('opacity', '1');
  });
}

I was able to update the opacity of the circles (only the active ones). Hope this helps someone.
.c3-circles .c3-circle-active {
    opacity: 0.7!important;
}

import c3 from "c3";
import * as d3 from "d3";

const chart = c3.generate(props);
const chartData = chart.data();
for (const i in chartData) {
    for (const index in chartData[i].values) {
        const item = chartData[i].values[index];
        if (item.value === null) {
            continue;
        }
        d3.selectAll(`.c3-circles-${item.id}`)
            .select(`.c3-circle-${item.index}`)
            .classed('c3-circle-active', true);
    }
}

the config architecture is pretty super extensible, afaics.
I just added return isValue(d.value) ? (this.isScatterType(d) ? this.config.point_scatter_opacity : opacity) : 0;
and then added  point_scatter_opacity: 0.5, to the getDefaultConfig next to point_show
config looks like this:
},```
            point: {
                show: false,
                r: 4,
                scatter: {
                    opacity: 1
                }
            },

the config architecture is pretty super extensible, afaics.
I just added return isValue(d.value) ? (this.isScatterType(d) ? this.config.point_scatter_opacity : opacity) : 0;
and then added  point_scatter_opacity: 0.5, to the getDefaultConfig next to point_show
config looks like this:
},```
            point: {
                show: false,
                r: 4,
                scatter: {
                    opacity: 1
                }
            },


Add sample chat template into vLLM container

FILL IN THE PR DESCRIPTION HERE
Jira issue : https://issues.redhat.com/browse/RHOAIENG-12233
The built-in Transformers v4.44 is shipped with vLLM v0.5.5. Transformers v4.44 has a strict requirement that a chat template must be provided with the model. While many chat models already follow this practice, some models are not working due to the absence of a chat template.
For models without an in-built chat template, vLLM exposes a command-line parameter (chat_template), which can be passed along with other parameters in ServingRuntime. In addition to this, the vLLM community has provided several sample templates in their examples directory, which users can select based on their model type.
From the user’s perspective, if their model lacks an in-built template, they must follow these steps based on their model type:
Find the appropriate sample template from the vLLM examples directory.
Mount the selected template on the vLLM pod.
Provide the template path using the vLLM command-line argument.
To simplify this process, we are streamlining steps 1 and 2. We will add the sample templates provided in the vLLM examples directory directly into the ODH vLLM container images. This ensures that all templates are pre-existing within the vLLM container, and users only need to configure the vLLM command-line argument to point to the correct template path.
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

/lgtm

/cherry-pick release


Is it possible to use an api other than google

I want to use other map api which is free. What would you suggest?

have you tried https://www.openstreetmap.org/ ?


Fix RSpec/NamedSubject when block has no body

This MR fixes a regression for :policeman: RSpec/NamedSubject with EnforcedStyle: named_only in case a block has no body. For example:
describe User do
  it "is a User" do
    subject.each do
      # empty body
    end
  end
end

Exception/failure

Failures:

  1) RuboCop::Cop::RSpec::NamedSubject when EnforcedStyle is :named_only ignores subject when block has no body
     Failure/Error: block_node.body.child_nodes.find { |send_node| subject?(send_node) }

     NoMethodError:
       undefined method `child_nodes' for nil:NilClass

                 block_node.body.child_nodes.find { |send_node| subject?(send_node) }
                                ^^^^^^^^^^^^
     # ./lib/rubocop/cop/rspec/named_subject.rb:148:in `find_subject'
     # ./lib/rubocop/cop/rspec/named_subject.rb:143:in `block in nearest_subject'
     # ./lib/rubocop/cop/rspec/named_subject.rb:144:in `each'
     # ./lib/rubocop/cop/rspec/named_subject.rb:144:in `each'
     # ./lib/rubocop/cop/rspec/named_subject.rb:144:in `each'
     # ./lib/rubocop/cop/rspec/named_subject.rb:144:in `each'
     # ./lib/rubocop/cop/rspec/named_subject.rb:144:in `find'
     # ./lib/rubocop/cop/rspec/named_subject.rb:144:in `nearest_subject'
     # ./lib/rubocop/cop/rspec/named_subject.rb:134:in `subject_definition_is_named?'
     # ./lib/rubocop/cop/rspec/named_subject.rb:130:in `named_only?'
     # ./lib/rubocop/cop/rspec/named_subject.rb:121:in `allow_explicit_subject?'
     # ./lib/rubocop/cop/rspec/named_subject.rb:115:in `check_explicit_subject'
     # ./lib/rubocop/cop/rspec/named_subject.rb:103:in `block in on_block'
     # ./lib/rubocop/cop/rspec/named_subject.rb:104:in `block in subject_usage'
     # ./lib/rubocop/cop/rspec/named_subject.rb:99:in `subject_usage'
     # ./lib/rubocop/cop/rspec/named_subject.rb:102:in `on_block'
     # ./spec/support/expect_offense.rb:21:in `expect_no_offenses'
     # ./spec/rubocop/cop/rspec/named_subject_spec.rb:158:in `block (3 levels) in <top (required)>'

Finished in 0.09781 seconds (files took 0.70907 seconds to load)
20 examples, 1 failure

Failed examples:

rspec ./spec/rubocop/cop/rspec/named_subject_spec.rb:157 # RuboCop::Cop::RSpec::NamedSubject when EnforcedStyle is :named_only ignores subject when block has no body

Randomized with seed 26613

Coverage report generated for RSpec to /home/peter/devel/rubocop-rspec/coverage. 2012 / 3392 LOC (59.32%) covered.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected

Found at GitLab in https://gitlab.com/gitlab-org/gitlab/-/issues/249446#note_1461446904.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[-] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

:wave: @kuahyeow
Can you review this PR? :pray:


Update IN documentation

Add an example for IN with a static list.

Can you update that @willmostly

Can you please review and merge @electrum

Closing. Replaced by https://github.com/prestosql/presto/pull/5398.


[OPTIONAL] Detect -- as the first argument of most builtins and ignore it

This applies to the following builtins (all but echo):

[ ] exit
[ ] env
[ ] export
[ ] unset
[ ] pwd
[ ] cd

This is useful because this way one can have an actual argument with the same name as the option, but without using the option.
Example:
If there is a file name -e, one might want to cat it, but without the -e option:
cat -- -e

Bash manual regarding this topic (last paragraph):
https://www.gnu.org/software/bash/manual/html_node/Shell-Builtin-Commands.html

dont do it, your time is worth other more valuable things


Reduce space between libras in folder view

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
8.0
Problem you are trying to solve
With version 8.0, there is too much space between the lines in the folder view, causing less lines to be shown. There is no option to reduce that space, only to make fonts smaller, which isn't desirable.
Suggested solution
Revert the folder view to pre-8.0.
Screenshots / Drawings / Technical details
No response

Same issue after upgrade from 6.8 to 8.1.
This is a regression in UX.


Add support of dashed timeline for JetLimeExtendedEvent type event

Hi I'm using the io.github.pushpalroy:jetlime:3.0.0 version in a KMM project.
I'm trying to apply the dashed effect to the line but still to be solid, may I am wrong to apply it?
Code:
JetLimeColumn(
      modifier = Modifier
          .padding(
              top = it.calculateTopPadding() + 16.dp,
              start = 16.dp,
              end = 16.dp,
              bottom = it.calculateBottomPadding() + 16.dp
          ),
      itemsList = ItemsList(items),
      key = { _, item -> item.id },
      style = JetLimeDefaults.columnStyle(
          contentDistance = 24.dp,
         // is it here where to apply the dashed effect?
          pathEffect = PathEffect.dashPathEffect(
              intervals = floatArrayOf(30f, 30f)
          )
      ),
  ) { index, mileage, position ->
      JetLimeExtendedEvent(
          style = JetLimeEventDefaults.eventStyle(
              position = position
          ),
          additionalContent = {
              // Additional content here
          }
      ) {
          // content
      }
  }

The result:

Yes for sure!

@N7ghtm4r3 Seems like your observation is correct. 👍🏻  Currently Dashed Effect is not supported for JetLimeExtendedEvent type event. You can use JetLimeEvent for the dashed effect.
Thanks for raising this issue.
I will add support of dashed line for JetLimeExtendedEvent in the next patch.

Thank you for the fast reply and for the tip

@N7ghtm4r3 The way you are applying the dashed effect is correct.
I'm not sure why you are not being able to see the proper effect.
Can you please check the sample already added to the repo: BasicDashedTimeLine?

I have to check it anyway?

@N7ghtm4r3 No need to verify anything. There is a bug due to which dashed effect is not supported in JetLimeExtendedEvent. I confirmed that.
You can check the sample I mentioned to use dashed effect for normal JetLimeEvent.

Okay thank you!

Thank you!


Logging format

Add support for logging format string to client can choose what to log and what the log lines will look like. Thus the client can decide how light or strong the logging messages should be for development and production.
Add separate logWithMessage operator so the resource endpoint can give a custom message that can be added to the log line using {Message} in the format string.
Move logging handling to a separate file.
Move error handling to Error.fs.

Yes, will keep it as a dark feature for now and document when the "dust have settled". We need to test and iterate a bit more with the .NET SDK to see what works best before finalizing the design.


curl-impersonate-bin: 0.5.3 -> 0.5.4; follow upstream on platforms

Description of changes
v0.5.4
Support all three platforms with upstream binaries (and don't pretend to support other Linux)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Tested that specific curl-disliking pages provide the actual content
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@deliciouslytyped — looks like ofBorg is not allowed to review-request you

#194310 merged when....

@deliciouslytyped — looks like ofBorg is not allowed to review-request you

It seems they are no longer in the NixOS org. Whether that is because of them never accepting the invite or from leaving is unclear. They can ask for a new invite in Matrix though

Ah, I searched through the checkout and after finding something haven't looked at GitHub…
Given the context, I'd want both bin and source available, though; not sure if it is easy to test them against each other.
I did check that there are some relatively recent PR reviews before doing a mention, so I decided that at least trying to attract maintainer attention is better than not…

Given the context, I'd want both bin and source available, though; not sure if it is easy to test them against each other.

The PR actually uses the upstream tests, which compares TLS handshakes/fingerprints from tcpdump packet captures
I'm not sure testing against the binary release would have any benefits compared to that (I'm not sure if you're just wanting to test TLS fingerprints, which is already done, or if you're meaning you want to test something else too)

I did check that there are some relatively recent PR reviews before doing a mention, so I decided that at least trying to attract maintainer attention is better than not…

Oh yeah absolutely! I imagine they may have actually just missed the invite and need a new one
I was going to give them a few days to chime in on the PR and just review it myself if they're too busy right now

Oh right, eradicating randomness in TLS handshake is probably too large of a task, pity…

Their upstream tests already calculate a fingerprint from the handshake using the non-random parts and compares against actual captures from the versions it attempts to impersonate. So random values in the handshake isn't really the problem

(Then I just want binary version as a quick-check if the source build ever doesn't seem to suffice, so that it's clear on which side is the issue)

So you mean attempt to run their upstream tests against the binary build too? (I'm just not following very well, my apologies)

No-no, if an external adversary at any point manages to distinguish the impersonation from a browser instance, to have an ability to check easily where things go wrong on the line «upstream binaries in chroot» — «upstream binaries in FHSenv» — «upstream binaries with our glibc patchelf-ed» — «Nixpkgs build».
If tests end up not detailed enough for some adversarially chosen corner cases or something.

Yes, I agree that we cannot do a useful test with a nix-build, but if we change the versions it is good to exclude the chance that the upstream choice of versions is non-random and better.
But maybe setting up a FHSenv is indeed better.


clumsy coding in MS docs for EqualityComparer Class

Idea Title
The coding example is unwieldy and can be improved and simplified
Issue Details
on page
https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.equalitycomparer-1?view=netframework-4.7.1
there is this ugly code
if (b1.Height == b2.Height && b1.Length == b2.Length
&& b1.Width == b2.Width)
{
return true;
}
else
{
return false;
}
whereas IMHO it should simply read
return (b1.Height == b2.Height && b1.Length == b2.Length
&& b1.Width == b2.Width)
however this was an improvement on the previous docs that also wrapped an else clause making that vintage code even worse.

@mairaw @BillWagner as FYI

@dend that looks like a good suggestion.
You can move that to our repo if you want.
@DickBaker our documentation is all open source now. Feel free to submit issues and PRs with your suggestions.
If you'd like, you can edit the C# sample here:
https://github.com/dotnet/docs/blob/master/samples/snippets/csharp/VS_Snippets_CLR_System/system.collections.generic.equalitycomparer/cs/program.cs
and usually we keep the samples in sync, so the VB one is here:
https://github.com/dotnet/docs/blob/master/samples/snippets/visualbasic/VS_Snippets_CLR_System/system.collections.generic.equalitycomparer/vb/program.vb

nope @dend. I'll manually copy then.

Moved to https://github.com/dotnet/docs/issues/5158. You can close this one.


Instrument serialization and rendering as 'format_response.grape'

A good portion of a grape API response is currently uninstrumented — when endpoint_run.grape closes, the response bodies still haven't been serialized or rendered into their appropriate templates. Adding format_response.grape instrumentation will allow us to measure time spent in this portion of the request.

LGTM, care to check out the build failure?

@dblock Failing on edge rails. Looks like it's related to the recent arel/activerecord merge.
Bundler could not find compatible versions for gem "activerecord":
  In rails_edge.gemfile:
    arel was resolved to 10.0.0.pre, which depends on
      activerecord (>= 6.a)

Unrelated to this PR, but I'd be happy to take care of it (could just tack on another commit to this one, unless you prefer to keep the issues separate).


Canavandl/distributed plugin

initial PR

I'm sorry for the noise - i wasn't paying attention to my git remote


bump httplib2 version

The current version of httplib2 has CA certs that we need.  This needs to stay up to date.

@KaylaNguyen can we sneak this in before a release? @bajacondor was just asking on slack about this, it's also needed for rules_docker.

@ixdy please send in a quick CL for this and I can take a look at it today before cutting a release :)


fix(workflows): fix docs on macros

Changes

#1075  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on  Graphite


Sass linter error

Sometimes and in some computers, stylelint throws the below error:

It has happened to @tostegroo and @DonghyukJacobJang in case you want to research about their environment.

Fixed on #219


fix Fix query is not cancelled when be report error status

FE will return empty set instead of error, if:

BE report error status
An instance has multiple pipelines
FE process report slowly

This pr fix above problem on branch-2.0 by:

Exchange sender will spread Error status to receiver so that
Receiver of last result sink fragment will make itself cancelled instead of send an EOS to FE.

PS: Maybe the fix is not perfect ... but it works with almost least modification.


Detection Matched Filtering

Template Preparation Script

Prepares templates for seismic event detection.
Reads event times from a catalog and extracts corresponding data from continuous seismic recordings.
Saves the extracted templates in a structured format for further analysis.

Matched Filtering Using Correlation Script

Performs matched filtering to detect seismic events.
Correlates the extracted templates with continuous seismic data.
Identifies significant correlations and stores results for detailed analysis.

Picks Association Script

Associates detected events with picks from seismic data.

Example Plotting

Includes an example that visualizes associated events.

Great job @omarmohamed15 !
Regarding the problem, it looks like there is a problem with loading the initial xlsx while creating docs.
Can we replace it with a csv? That would be much easier...
Also, does this catalog exist in the web, somewhere in TOC2ME github? We could download it in the runtime maybe, like we do it in toc2me worked examples?
Like this, here it is done for the one from Eaton et al 2018:
# Provide URL for the catalogue
catalogue_url = 'https://github.com/ToC2ME/ToC2ME/blob/master/Eaton/Catalog_Eaton2018_SRL.csv?raw=true'

# File path to save the .mat file
catalogue_file= os.path.normpath(os.path.join(datafolder, 'Catalog_Eaton2018_SRL.csv')).replace('\\', '/')

# Download the file
response = requests.get(catalogue_url)

# Check if the request was successful
if response.status_code == 200:
    # Write the content to a file in binary mode
    with open(catalogue_file, 'wb') as file:
        file.write(response.content)

    print(f"File was successfully downloaded and saved to {catalogue_file}")
else:
    print("Failed to download the file. Status code:", response.status_code)

Great job @omarmohamed15 !
Regarding the problem, it looks like there is a problem with loading the initial xlsx while creating docs. Can we replace it with a csv? That would be much easier... Also, does this catalog exist in the web, somewhere in TOC2ME github? We could download it in the runtime maybe, like we do it in toc2me worked examples?
Like this, here it is done for the one from Eaton et al 2018:
# Provide URL for the catalogue
catalogue_url = 'https://github.com/ToC2ME/ToC2ME/blob/master/Eaton/Catalog_Eaton2018_SRL.csv?raw=true'

# File path to save the .mat file
catalogue_file= os.path.normpath(os.path.join(datafolder, 'Catalog_Eaton2018_SRL.csv')).replace('\\', '/')

# Download the file
response = requests.get(catalogue_url)

# Check if the request was successful
if response.status_code == 200:
    # Write the content to a file in binary mode
    with open(catalogue_file, 'wb') as file:
        file.write(response.content)

    print(f"File was successfully downloaded and saved to {catalogue_file}")
else:
    print("Failed to download the file. Status code:", response.status_code)

I agree with this, can we try to load directly from the web if possible as opposed to having static files.

I think before we agreed to only have 1 tutorial for the template matching, not the 3 different stages separated, and then the separated stages are to go in the ToC2ME specific repository. I shall work on condensing the tutorials to only one, where it highlights only the fracspy function

Great job @omarmohamed15 !
Regarding the problem, it looks like there is a problem with loading the initial xlsx while creating docs. Can we replace it with a csv? That would be much easier... Also, does this catalog exist in the web, somewhere in TOC2ME github? We could download it in the runtime maybe, like we do it in toc2me worked examples?
Like this, here it is done for the one from Eaton et al 2018:
# Provide URL for the catalogue
catalogue_url = 'https://github.com/ToC2ME/ToC2ME/blob/master/Eaton/Catalog_Eaton2018_SRL.csv?raw=true'

# File path to save the .mat file
catalogue_file= os.path.normpath(os.path.join(datafolder, 'Catalog_Eaton2018_SRL.csv')).replace('\\', '/')

# Download the file
response = requests.get(catalogue_url)

# Check if the request was successful
if response.status_code == 200:
    # Write the content to a file in binary mode
    with open(catalogue_file, 'wb') as file:
        file.write(response.content)

    print(f"File was successfully downloaded and saved to {catalogue_file}")
else:
    print("Failed to download the file. Status code:", response.status_code)

Okay, I will try to do that.
Thanks, Denis!

I think before we agreed to only have 1 tutorial for the template matching, not the 3 different stages separated, and then the separated stages are to go in the ToC2ME specific repository. I shall work on condensing the tutorials to only one, where it highlights only the fracspy function

I can consolidate all three steps into one, but we must start with the first step: preparing the template. Without this initial step, the subsequent steps won't function properly.


MoveToMapPokemon not working

I just noticed that my bot stop walking toward pokemon and aim to only pokestops. It worked perfectly before and I haven't changed my config file so far.

Use the template or dont get any help from us.

#3682 - META Server busy or offline issues
#3308 - META Stuck between two forts / Moving to 2 forts at the same time / Constant Loop
#3700 - META Soft bans - Try again spins / Pokemon vanishing
#3746 - META Banwaves - Permanent Bans

Yes I use the template and it was working very well until at some point it stopped looking for pokemon :(


[02] Fix/isolate source per build

I fixed code to isolate openssl source files per build.
In original code, source files are reused during build steps for each platforms and architectures.
For example, sed for particular target performed multiple times.
No problem has occurred actually, but I fixed it for future stability.
This PR includes fix/code-appearance.

Could you please rebase to current master.

I tried it. Is it OK?


Klarna won't work if there are custom gender labels

If customer has edited the Gender customer attribute with their own labels (for example 'Man' instead of 'Male' in case of a Dutch store), Klarna won't work anymore because a getOptionText is used which returns the label for the store.
I'm not sure what would be a good solution, maybe a hardcoded list (as Klarna demands either MALE or FEMALE) would suffice.
This is specifically the case in https://github.com/Adyen/magento/blob/develop/app/code/community/Adyen/Payment/Model/Adyen/Openinvoice.php method getOptionalFormFields where shopper.gender is set (three instances).

Hi Ewald,
What I think is that you should never change the option text in the database but add a translate function around this value in the templates. That is what we have done in our module. But we have now seen that multiple merchants have changed this value in the database causing issues with the integration to Klarna. So I will make a change that we always send Male or Female to klarna.
Regards,
Rik
Adyen


Add language check for diversity and inclusion

What does this PR do?
This PR adds a static analysis to ensure we don't use any non-inclusive language.

Codecov Report

Merging #584 (9e02085) into master (ad28a87) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #584      +/-   ##
============================================
- Coverage     89.10%   89.02%   -0.08%
- Complexity     1566     1567       +1
============================================
  Files           174      174
  Lines          5238     5238
  Branches        625      625
============================================
- Hits           4667     4663       -4
- Misses          349      353       +4
  Partials        222      222

Impacted Files
Coverage Δ
Complexity Δ

...internal/tracking/JetpackViewAttributesProvider.kt
73.91% <0.00%> (-13.04%)
12.00% <0.00%> (-1.00%)

...g/android/rum/internal/domain/scope/RumEventExt.kt
80.91% <0.00%> (-4.55%)
0.00% <0.00%> (ø%)

...g/internal/domain/event/DdSpanToSpanEventMapper.kt
93.88% <0.00%> (-2.04%)
11.00% <0.00%> (-1.00%)

...l/net/info/BroadcastReceiverNetworkInfoProvider.kt
78.35% <0.00%> (+1.03%)
28.00% <0.00%> (+1.00%)

...droid/rum/tracking/ActivityViewTrackingStrategy.kt
88.68% <0.00%> (+3.77%)
19.00% <0.00%> (+1.00%)

...droid/rum/tracking/FragmentViewTrackingStrategy.kt
86.36% <0.00%> (+4.55%)
14.00% <0.00%> (+1.00%)


Support setting apiKey and applicationKey for AnalysisProviderDatadogConfig directly instead of just via file

What would you like to be added:
Currently, the AnalysisProviderDatadogConfig configuration only supports auth information to be set via file (mount to the piped container). It would be great if we could support setting those values directly via fields like apiKeyData and applicationKeyData as for other configurations.
ref: https://pipecd.dev/docs-v0.41.x/user-guide/managing-piped/configuration-reference/#analysisproviderdatadogconfig
Why is this needed:

Looks like @hungran is working on this, thanks 🙏


refactor: minimize external dependencies in RPC client

Motivation
Client is a folder that will be shared between consumers of the Hub and the Hub itself. It is important that this has as few external dependencies as possible so that it can be easily extracted into a package in the future. Closes #312
Change Summary
The 'net', 'logger', 'utils/p2p' dependencies are removed from Client by refactoring hub specific logic into HubRPCClient and introducing ClientError.
Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] The title of this PR adheres to the conventional commits standard
[ ] The PR has been tagged with the appropriate change type label(s) (i.e. documentation, feature, bugfix, or chore)

Looks great, but I think some conflicts need to be resolved now

Looks great, but I think some conflicts need to be resolved now

rebased

LGTM
I don't love having to introduce a new ClientError type, but I'm not sure there is a cleaner solution. @pfletcherhill thoughts on this?

@varunsrin after taking a look at this again I think updating the PR to drop ClientError in favor of continuing with using the HubError in the client module is a better path for the PR. Progress is made with 'net', 'logger', 'utils/p2p' dependencies dropped and we avoid prematurely introducing another class

@adaddeo i like that approach better for now. this may need to be rebased over the latest conflicts

@varunsrin rebased

@varunsrin rebased after mono repo changes


FeatureRequest: Add offline support for pages

As a developer, my commute is on buses, trains, and waiting inbetween with no wifi. It'd be awesome to have an offline mode for the site so I can still read/reference material.

In the default RTD theme, you can click the green version tag in the bottom left corner to show links to downloadable HTML, PDF and ePub versions.
As far as I know these are generated by default for everything that they host.

Downloaded files above are generated for all sphinx projects by default, though some projects disable them, and mkdocs projects do not build them at all. An offline website mode would require re-architecting our output, and isn't likely going to be a feature we would develop/accept for our hosted version.
Sounds like downloads is what you want anyways though, closing this issue.


SetSpeechSynthesisOutputFormat does not work for translation

Describe the bug
When using the following configuration I  always get WAV files.
  auto speechConfig =
      SpeechTranslationConfig::FromSubscription(speechKey, speechRegion);
  speechConfig->SetProperty(PropertyId::Speech_LogFilename, "/tmp/speech.log");
  speechConfig->SetSpeechRecognitionLanguage("es-ES");

  speechConfig->AddTargetLanguage("en");
  speechConfig->SetVoiceName("en-US-AriaNeural");
  speechConfig->SetSpeechSynthesisOutputFormat(SpeechSynthesisOutputFormat::Raw8Khz16BitMonoPcm);

I expect RAW PCM. I also tried with ulaw raw pcm and same output.  (it does translate correctly though)
I output the first bytes and it is  a wav file:
RECOGNIZED: Text=Esto es una prueba.
RECOGNIZED: Translation=en Text=This is a test.

To Reproduce
Steps to reproduce the behavior:
create a speech config set any use SetSpeechSynthesisOutputFormat
Expected behavior
Get raw format.
Version of the Cognitive Services Speech SDK
Which version of the SDK are you using. 1.35.0
Platform, Operating System, and Programming Language
Linux x86-64 c++ Ubuntu 22.04

@yulin-li Please let us know if this is a bug or current design?

As far as I know, only riff-16khz-16bit-mono-pcm format is supported in speech translation audio output. This is a feature gap. I will track this internally. I am closing this issue for now.


Build(deps): Bump @patternfly/react-table from 4.71.16 to 4.75.2 (#3418)

Pull request opened by the merge tool on behalf of #3418

Merged in 94857b919458be1e46c9a2d69c9ce5cfa84319f1


#25 adaptive execution work without RepartitionByExpression action

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please


bug: chronograf on task update sends both every and cron.

bug: chronograph on task update sends both every and cron.  It should only send one or the other.

The payload sent by Chronograf in curl format:
curl 'http://localhost:9999/api/v2/tasks/037abfed87ab6000' -X PATCH -H 'Origin: http://localhost:9999' -H 'Accept-Encoding: gzip, deflate, br' -H 'Accept-Language: en-US,en;q=0.9' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.119 Safari/537.36' -H 'Content-Type: application/json' -H 'Accept: application/json, text/plain, */*' -H 'Referer: http://localhost:9999/tasks/037abfed87ab6000' -H 'Cookie: session=-p0J8_F0mYwUIF4PPsP-AKp2D-ZGmoRqVuxxPyLsJ_Op79CBA868vB7XpWQ44oMIkMTVVtkjjpeMPRLq6evdww==' -H 'Connection: keep-alive' --data-binary '{"links":{"labels":"/api/v2/tasks/037abfed87ab6000/labels","logs":"/api/v2/tasks/037abfed87ab6000/logs","members":"/api/v2/tasks/037abfed87ab6000/members","owners":"/api/v2/tasks/037abfed87ab6000/owners","runs":"/api/v2/tasks/037abfed87ab6000/runs","self":"/api/v2/tasks/037abfed87ab6000"},"labels":[],"id":"037abfed87ab6000","orgID":"037abee84ccf8000","org":"org","authorizationID":"037abfe3da8f8000","name":"task-every","status":"active","flux":"import \"http\"\n\noption task = {\n\tname: \"task-every\",\n\toffset:<PHONE_NUMBER>ns,\n\tconcurrency: 100,\n}\n\nfrom(bucket: \"org\")\n\t|> http.to(url: \"http://example.com\")","every":"30s","offset":"5s","latestCompleted":"2019-03-01T14:48:00-06:00","createdAt":"2019-03-01T14:46:41-06:00","updatedAt":"2019-03-01T14:46:50-06:00","cron":"0 2 * * *"}' --compressed

Note: how both the every and cron fields are set, it needs to set one or the other not both.


i2s: Add an nrfx-based implementation for Nordic ICs

I2S Machine State.pdf

@kl-cruz @barsok - please review

@adamkondraciuk thanks for the PR. Could you perhaps take the .pdf and convert it to a combination of .rst and .png that we could place somewhere in doc? Otherwise we just leave it out of the PR and that's fine too.

@adamkondraciuk thanks for the PR. Could you perhaps take the .pdf and convert it to a combination of .rst and .png that we could place somewhere in doc? Otherwise we just leave it out of the PR and that's fine too.

On second thought, we don't really have anywhere to place this kind of documentation today, and it would probably be very difficult to keep it updated, so let's not include it in the Pull Request

Since i2s interface and API are quite complex this driver should be tested with tests/drivers/i2s/ tests. Unfortunately, the tests assume that the driver supports I2S_OPT_LOOPBACK flag. They need to be modified to support also hardware loopback mode.

The driver has a function called interface_error_service(struct i2s_nrfx_data *i2s, 					const char * const err_msg).
It would be great if this instead of taking a string could take some form of int .
This function may then again be used to alert the application in some way. We are in a position where we need to get updates of TX underruns and RX overruns.

This PR has been superseded by #34251.


Add Things 2.8.14

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Thank you, but we’ll refuse this cask. This repo has stricter acceptance rules (emphasis added):

caskroom/versions is not intended to be used for all and any old versions you personally require for xyz project; casks submitted here should be expected to be used by a reasonable number of people and supported by contributors long-term.

Considering Things 3 has been released a year ago and there’s been no interest in Things 2 so far, I’d say there’s not a reasonable amount of interest.
As per the instructions, if you want this as a cask, you may create your own tap.

Fair enough. Out of interest, how is the 'reasonable number of people' quantified? By PR / issue? Seemed to me the legacy version of Things was a warranted addition since they moved to the App Store, and original licenses are still valid.

how is the 'reasonable number of people' quantified?

It’s subjective. If it had been added shortly after version 3 was released, we’d have accepted it then.

Seemed to me the legacy version of Things was a warranted addition

Agreed, if people wanted a cask for it. But so far we had a single PR for it in a year (yours), so clearly our users aren’t really missing it.

Understood. Cheers, @vitorgalvao.


Rear audio port disables front audio port when connected.

Describe the bug
When the rear audio port is connected to speakers, the front audio port is disabled. If I disconnect the speakers from the rear audio port, the front audio port works. Here is a table of the various states.

Front Port
Rear Port
Result

Connected

Good (Front port outputs audio)

Connected
Good (Rear port outputs audio

Connected
Connected
Bad (Rear port outputs audio)

Expected behavior
In the last case above, I would expect that plugging headphones into the front port would disable my speakers connected to the rear port. If I plug my speakers into the front and then use the rear port for my headphones the behaviour is as I would expect it to be.
Is it possible to flip the way the ports behave?
Configuration

HaC Mini version: 2.4
OSX version: 10.15.1
NUC model: NUC8i7HNK
Boot SSD model and protocol: Samsung SSD 970 PRO 1TB
Second SSD model and protocol: N/A
First DIMM model: Crucial DDR4-2400 16GB
Second DIMM model: Crucial DDR4-2400 16GB
Display port(s) used: 1x mini-DP
Display resolution(s): 3440x1440 (Dell U3415W)
Any TB3 devices: N/A
Any USB devices: Apple Wired Keyboard, Razer Deathadder Mouse

Modifications
Using DW1820 Wireless Card with the kexts installed from the 2.4 installer

@osy86 Is there anything more I can gather to help with your investigations? Is there a layout ID change I could do? I'm happy to try things on my side and report back.

Realistically I won't have time to look into this for a while. You can take the existing XML in AppleALC for ALC700 and play around with the XML entries and see what happens.

Thanks! I'll give this a go and report back :)

I tried building AppleALC with the front port changed to Node 3 and rear port as node 2 (as well as the other way round) no change in behaviour. I'll try get more info from Linux using the graph tool to see what happens when the front audio port is connected vs the rear.

What happens on linux when you have both ports plugged in?

I booted the NUC using an Ubuntu 19.10 live USB and the front audio jack disables the rear jack when both are connected. This is the correct behaviour that I would expect (which is the opposite of what happens in macOS.)
I tried to generate a codecgraph for each state, but they all end up identical.

Here is the dmesg output from boot, and also the codec#0 output from each state.
dmesg | grep -i hda
[   10.369389] snd_hda_intel 0000:00:1f.3: enabling device (0000 -> 0002)
[   10.369525] snd_hda_intel 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
[   10.369950] snd_hda_intel 0000:01:00.1: enabling device (0000 -> 0002)
[   10.369998] snd_hda_intel 0000:01:00.1: Handle vga_switcheroo audio client
[   10.442749] snd_hda_codec_realtek hdaudioC0D0: autoconfig for ALC700: line_outs=1 (0x1b/0x0/0x0/0x0/0x0) type:line
[   10.442750] snd_hda_codec_realtek hdaudioC0D0:    speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
[   10.442751] snd_hda_codec_realtek hdaudioC0D0:    hp_outs=1 (0x21/0x0/0x0/0x0/0x0)
[   10.442751] snd_hda_codec_realtek hdaudioC0D0:    mono: mono_out=0x0
[   10.442752] snd_hda_codec_realtek hdaudioC0D0:    dig-out=0x1e/0x0
[   10.442752] snd_hda_codec_realtek hdaudioC0D0:    inputs:
[   10.442753] snd_hda_codec_realtek hdaudioC0D0:      Internal Mic=0x13
[   10.442754] snd_hda_codec_realtek hdaudioC0D0:      Internal Mic=0x12
[   11.264993] input: HDA Intel PCH Line Out as /devices/pci0000:00/0000:00:1f.3/sound/card0/input28
[   11.265053] input: HDA Intel PCH Front Headphone as /devices/pci0000:00/0000:00:1f.3/sound/card0/input29
[   11.265102] input: HDA Intel PCH HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:1f.3/sound/card0/input30
[   11.265154] input: HDA Intel PCH HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:1f.3/sound/card0/input31
[   11.265206] input: HDA Intel PCH HDMI/DP,pcm=8 as /devices/pci0000:00/0000:00:1f.3/sound/card0/input32
[   11.265258] input: HDA Intel PCH HDMI/DP,pcm=9 as /devices/pci0000:00/0000:00:1f.3/sound/card0/input33
[   11.265309] input: HDA Intel PCH HDMI/DP,pcm=10 as /devices/pci0000:00/0000:00:1f.3/sound/card0/input34

codec#0_ALC700_both.txt
codec#0_ALC700_front.txt
codec#0_ALC700_rear.txt
What I noticed is the following when diffing those outputs;
When changing from rear port only to either front port only or both ports connected, this is the change that happens;
Node 0x03 [Audio Output] wcaps 0x41d: Stereo Amp-Out (Control: name="Headphone Playback Volume", index=0, device=0)
Amp-Out vals:  [0x00 0x00] >> Amp-Out vals:  [0x3c 0x3c]
Pin Default 0x01011020: [Jack] Line Out at Ext Rear
Pin-ctls: 0x00: VREF_HIZ >> Pin-ctls: 0x40: OUT VREF_HIZ
Node 0x21 [Pin Complex] wcaps 0x40058d: Stereo Amp-Out (Control: name="Headphone Playback Switch", index=0, device=0)
Amp-Out vals:  [0x00 0x00] >> Amp-Out vals:  [0x80 0x80]

@osy86 Is there anything else I could try?

Those change basically are just volume changes so it doesn't seem that any internal config changed. My hunch is that it's an OSX config issue. Probably something in the XML tells the driver which port takes priority. Maybe it's worth asking around to see if anyone else experienced similar issues on other boards?

@osy86 I have done some google searching and come up empty on people with similar issues. Do you think you might have some time to look into switching the port priority for macOS? Thanks in advance! I love this project and the amazing work you do :)

This seems to be an OSX default behaviour. Line Out > Headphones > Speaker. Maybe if we fake the port to be speaker instead of line out, it might work, but I don't know if that will cause other issues. You can try changing https://github.com/acidanthera/AppleALC/blob/master/Resources/ALC700/Platforms11.xml#L127 to 20 or 21 or 22 or 22 and see if you get any output. It might not work because there might be some internal verb call that is needed.


json::out_of_range exception matches against lot of others while testing

What is the issue you have?
I was trying out https://github.com/nlohmann/json and wanted to test the exception mechanism it had.
My initial attempt was to use CHECK_THROWS but that was really difficult since nlohmann::json::out_of_range is not easy to construct.
CHECK_THROWS_AS was what I was supposed to use and that worked fine.
Before figure that out I tried CHECK_THROWS with std::out_of_range and to my surprise that worked! The test also passed with std::bad_alloc.
I am not sure if this is to be expected since nlohmann::json::out_of_range is derived from std::exception.
Please describe the steps to reproduce the issue.
This Code snippet
Can you provide a small but working code example?
Minimal example here: https://github.com/nandanvasudevan/cpp_scratch_pad/tree/json_parsing
What is the expected behavior?
I expect the above tests to fail.
https://github.com/catchorg/Catch2/issues/2371
And what is the actual behavior instead?
The tests pass.
Which compiler and operating system are you using?

Compiler: GCC v11
Operating system: Jammy Jellyfish (development branch)
Test framework: Catch2 v3 Preview 4

Which version of the library did you use?

[x] latest release version 3.10.5
[ ] other release - please state the version: ___
[ ] the develop branch

If you experience a compilation error: can you compile and run the unit tests?
Compiles fine.

[ ] yes
[ ] no - please copy/paste the error message below

By using just CHECK_THROWS, you are verifying that this expression throws:
jsonParsed_full.at("Nonexistent"), std::out_of_range("")

and since it does throw, the check passes.  This is not a bug either in this library or in Catch2.

It does not throw std::out_of_range or std::bad_alloc.

I understand your point.
I guess I am supposed to use CHECK_THROWS_AS if I need to verify the type of the exception.

See https://github.com/catchorg/Catch2/issues/2371#issuecomment-1049576919.


Enable vapoursynth support

Could you please add vapoursynth support to your builds using --enable-vapoursynth?
https://ffmpeg.org/general.html#VapourSynth

Isn't that the same as avisynth, which is already supported?

Vapoursynth is a modern alternative to avisynth and support needs to be enabled with a separate flag. It would be nice to encode my scripts directly without having to pipe all the time to ffmpeg.

Looking at the vapoursynth github repo, I unfortunately see no remotely sane way to package this so it works as a static dependency for these builds.
Like, ffmpeg wants to directly link to it, it does not dynamically load it at runtime like it does with avisynth. So I'd have to link an entire static python interpreter into ffmpeg, and a whole bunch of other stuff.
Sorry, but that's a library which does not at all play nicely with static linking, unless I'm missing some trick they have to link it statically in a sane way.

Well, I don't know anything about compiling binaries, but there is a build with vapoursynth here: https://jeremylee.sh/bins/
Perhaps there is some info there that might help?

That seems to be patching in a whole other vapoursynth something, not sure what's up with that:
https://raw.githubusercontent.com/m-ab-s/mabs-patches/master/ffmpeg/0001-Add-Alternative-VapourSynth-demuxer.patch
But I'm following a strict policy of not patching upstream ffmpeg with these builds, so something like that is out of the question.
It also seems to in fact do drag an entire Python-Interpreter along and link it statically into ffmpeg.
That'd inflate the binary size considerably, so I'm still not too keen on doing that.
Another issue seems to be that VapourSynth only supports being built with MSVC on Windows, and in turn also needs an MSVC built Python. Meaning I can't compile them no matter what.
Yeah, sorry, but there is just too many issues with VapourSynth. The only way to ever add support would be if it worked the same AviSynth does, where ffmpeg just needs the headers, and then dynamically loads it at runtime.

Hello.
Yes, I regularly cross-compile a static ffmpeg with vapoursynth for windows, under ubuntu, regularly (it was scripted by someone else, so I never look at it).
A quick look says it is a hassle to build and not fully static - with this method it dynamically loads vapoursynth; one has to put the built ffmpeg exe into the same windows folder as the correct versions of the extracted "portable" vapoursynth and the extracted portable python 3 and run ffmpeg.exe from there.
A hassle for the user, but doable and I rely on it.
Can't recall offhand, is that similar to avisynth or is that fully static build into ffmpeg ?

No, the difference is that ffmpeg links directly against vapursynth, but does not with avisynth.
So it'd force every user who wants to use the builds to grab a copy of vapursynth before the binaries will run at all, even if that user has no intention of ever using vapoursynth.

Ah, I guessed so.
Not a very handy result :)

Unfortunately I don't see this happening, so I'm closing this here.
Feel free to reopen/create a new issue if you think you found a way around the issue.


Add documentation and example for using date and time

Is your feature request related to a problem? Please describe.
How do I show sub-day quotes?
I tried five different formats for datetime now and none of them work.
There isn't a single example of which format the datetime should be in and docs also don't mention this.
Does this library not support sub-day quotes?
Describe the solution you'd like
At least one example with datetime and format of datetime specified in the docs.
Additional context
None

The Time type is documented here: https://tradingview.github.io/lightweight-charts/docs/api#time
You would most likely want to be using a UTC timestamp (in seconds, not milliseconds).
To have the crosshair labels and time scale tick marks display the time in hours and minutes you can set timeVisible to true in the TimeScaleOptions. Documentation: https://tradingview.github.io/lightweight-charts/docs/api/interfaces/TimeScaleOptions#timevisible
const chart = createChart(chartElement, {
  timeScale: {
    timeVisible: true,
  },
});

Here is an example which has multiple data points in a single day: https://jsfiddle.net/msilverwood/0vzgaL6o/

Thank you, would be great to add this to examples page.


Support for Python 3

Hi, is probfit going to be compatible with Python 3? I wasn' able to run setup.py with Python 3.3:
Traceback (most recent call last):
File "setup.py", line 43, in
execfile('probfit/info.py')
NameError: name 'execfile' is not defined

It seems this project is orphaned by now. If not I'd love to see a python 3 version as well.

Noted. I just need a good weekend to do it.

I wanted to use the Chi2regresion object. However, I already wrote my routine without probfit, based on iminuit only. I guess it was because I needed high performance and so I defined my chi2 in Cython based on the documentation for iminuit. Now I'm facing the disadvantage that my Cython object has only statically defined function to be fitted, I guess I cannot assign the name of the fitted function dynamically without losing the computation power of Cython. Therefore, for fitting of some different functions later, I will consider using probfit instead.

I'll give Python 3 for probfit a shot in #62

I merged #62 just now.
probfit master is now Python 3 compatible.
@peterkamatej - your last comment about Chi2regresion seems unrelated to this issue. I have now idea. Please open a new issue on Github, or ask a question on the https://groups.google.com/forum/#!forum/iminuit mailing list if it's still an issue for you.


Documentation update 2

Reworded and reformatted a few paragraphs.

I'm still waiting for you to sync texturec and geometryc command line options text.


remove the unnecessary copies

Got the message from @liqlin2015 that the icp-management-ingress-tls-secret does not need to be copied to kube-system.
Sync the secretshare PR: https://github.ibm.com/IBMPrivateCloud/secretshare/pull/2
/cc @mikekaczmarski @liqlin2015

Secret icp-management-ingress-tls-secret and route-tls-secret  is not needed anymore.


2.9: Invalid storage volume configuration key: lvm.thinpool_name

Required information

Distribution: Ubuntu Server
Distribution version: 16.10
The output of "lxc info" or if that fails:

Kernel version:4.8.0-37-generic
LXC version: 2.9.1
LXD version: 2.9.1
Storage backend in use: LVM

Issue description
Editing a storage volume container and then exiting - even if no changes are made - results in the error ...Invalid storage volume configuration key: lvm.thinpool_name.
Steps to reproduce

lxc launch ubuntu_r1610 -p default-msm minecraft

lxc storage volume edit lxc-vg container/minecraft [Note, my default editor is nano]

Ctrl-X to exit nano upon which the message:
Config parsing error: Invalid storage volume configuration key: lvm.thinpool_name Press enter to open the editor again

Devices portion of default-msm
devices:
  eth0:
    name: eth0
    nictype: bridged
    parent: br0
    type: nic
  root:
    path: /
    pool: lxc-vg
    type: disk
name: default-msm

Storage volume configuration for container/minecraft
name: minecraft
config:
  block.filesystem: ext4
  block.mount_options: discard
  lvm.thinpool_name: LXDThinpool
  size: "10737418240"
type: container
used_by: []

Hi,
Looks like a bug in storage_volums_config.go, the key according to documentation should be "volume.lvm.thinpool_name" not "lvm.thinpool_name".
Can you try to edit your pool and change that key to "volume.lvm.thinpool_name" see if that fixes things for you?
@brauner

Just tried - I get the same(ish) error when trying to save the changes:
lxc storage volume edit lxc-vg container/minecraft
Config parsing error: Invalid storage volume configuration key: volume.lvm.thinpool_name
Press enter to open the editor again

Oh right, so yeah, your config looks right, the pool should have volume.lvm.thinpool_name and the volume should have lvm.thinpool_name. So it's the validation code for the volume that's busted somehow...

@brauner can we actually copy lvs between thinpools? If not, then the thinpool property shouldn't be a volume property and should just be renamed to lvm.thinpool_name as a pool property. If it can in fact be a per-volume property then "lvm.thinpool_name" should exist in volume configuration.

Yes, the storage_volumes_config.go code misses an entry for "lvm.thinpool_name" in the valid configuration keys check. I can send a patch right now to fix this.
@stgraber, I thought you could by creating a new volume of the same size in the new thinpool and then copying over. But I'm not sure how practical that is.

@brauner Can you try this by creating a first container from an image, then change volume.lvm.thinpool_name to something else and create a second container from the same image?
If that works, then we can keep volume.lvm.thinpool_name, if that doesn't work, then we should track this like the VG itself, allow setting it at creation time and not change afterwards, less hassle than having to deal with copying images and stuff between thinpools on-demand.

@stgraber, we currently do not allow this to be changed anyway. Also having a second thinpool on a volume group presupposes that the first thinpool doesn't stretch over the whole vg. So we would have to resize the vg and all sorts of stuff.
So I suggest we remove volume.lvm.thinpool_name and replace it with lvm.thinpool_name and also drop lvm.thinpool_name as a volume property. So a user could do:
lxc storage create pool1 lvm source=/dev/sdb lvm.thinpool_name=pool1_thinpool

@brauner sounds good to me. Will need to add an extra patch to convert existing 2.9 users but that should be pretty easy (rename volume.lvm.thinpool_name to lvm.thinpool_name and clear any existing lvm.thinpool_name property from the volumes)

This is tracked in https://github.com/lxc/lxd/pull/2921.


dynamically added fields are not detected by validator

Hi,
I have a form with an input field that can be added on dynamically. For example, a click to add another input field. The first input field displayed is properly detected by the Validator but additional fields added in by the click even does not.
I have an array of fields where it is looped to create the input fields and the click event  will cause an additional input field to be displayed.
When I output,  {{$validator | json}} i can see the initial field but not the subsequent fields.
{
  "0": {
    "required": false,
    "modified": false,
    "pristine": true,
    "dirty": false,
    "untouched": true,
    "touched": false,
    "invalid": false,
    "valid": true
  },
  "valid": true,
  "invalid": false,
  "touched": false,
  "untouched": true,
  "modified": false,
  "dirty": false,
  "pristine": true
}

I'm currently using the :field attribute and using the index of the array as the field value. No matter how many I add, validator will only show the 0 index.

Thank you for your feedback.
Can you share the reproduction codes with jsfiddle (or codepen ... etc) please?

i will try and get one up this week.

Close (inactivity)

Also getting the same issue, replicated here:
https://jsbin.com/fofeborivu/edit?html,output
The dynamic field gets added to the last <validator> component on the page. So if you swap the order, the new field is added to the correct location. Similarly, if there is only one section the page, it is added in the correct place.