Tests pass when error is thrown

When the tested code throws an error, you get output similar to:
>  node test | tap-dot

module.js:340
    throw err;
          ^
Error: Cannot find module 'trimmer'
    at <stack trace here>

  0 tests
  0 passed

  Pass!

I guess the test should fail, as it does without any reporter, or with substack/faucet.

Will be fixed in 1.0 release in the next or so. Thanks for the find.

For the record – for now I'm using tape-catch, which does the job as well. But I admit it does feel a bit dirty :)

Didn't Tape just release a fix to catch errors?
On Fri, Feb 6, 2015 at 3:10 AM Tomek Wiszniewski<EMAIL_ADDRESS>wrote:

For the record – for now I'm using tape-catch
https://www.npmjs.com/package/tape-catch, which does the job as well.
But I admit it does feel a bit dirty :)
—
Reply to this email directly or view it on GitHub
https://github.com/scottcorgan/tap-dot/issues/4#issuecomment-73221494.

Well, it looks as if they used to but they've decided against it: https://github.com/substack/tape#uncaught-exceptions

Published as 1.0.0

Thank you very much!


regression in v0.7.0 with nuxt content

I'm using nuxt-vitest in a project with @nuxtjs/content and bumping from v0.6.12 to v0.7.0 fails.
The error I see is:
FetchError:  (404 Cannot find any route matching /api/_content/query/ER5upk6W6J.1684485169978.json?_params=%7B%22sort%22:%5B%7B%22_path%22:-1%7D%5D,%22limit%22:2%7D. (/api/_content/query/ER5upk6W6J.1684485169978.json?_params=%7B%22sort%22:%5B%7B%22_path%22:-1%7D%5D,%22limit%22:2%7D))
 ❯ node_modules/.pnpm/@nuxt+content@2.6.0/node_modules/@nuxt/content/dist/runtime/composables/query.mjs:28:16
     26|     }
     27|   });
     28|   if (typeof data === "string" && data.startsWith("<!DOCTYPE html>")) {
       |                ^
     29|     throw new Error("Not found");
     30|   }

I did not manage to reproduce the exact same issue, but adding @nuxtjs/content to the playground does break the current test.
See https://stackblitz.com/edit/github-usaxfg?file=app.vue
This is the playground directory, to which I added the @nuxtjs/content module, and a simple markdown file in content.
The index.vue component uses queryContent to get the title of the markdown file, and displays it (works with npm run dev):
<template>

Index page

title: {{ posts[0].title }}

</template>

When running the tests with npm run test then you can see a lot of warnings appearing:
Vue warn]: Avoid app logic that relies on enumerating keys on a component instance. The keys will be empty in production mode to avoid performance overhead.
  at <Index onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< {} > >
  at <RouteProvider key="/" routeProps= {
  Component: [Object: Inspection interrupted prematurely. Maximum call stack size exceeded.],
  route: [Object: Inspection interrupted prematurely. Maximum call stack size exceeded.]
} pageKey="/"  ... >

and the tests fail/hang (though not with the same exact error I have, but I do see the same warnings and the error I have points out to queryContent).

The issue is coming from @nuxt/content which requires a server to serve up the markdown. So queryContent is not going to work in a unit testing environment. (I'm not sure why it previously worked.)
Instead you can do something like this:
mockNuxtImport('queryContent', () => (_id: string) => ({
  limit: (_limit: number) => ({
    find: () => [{
      title: 'My page'
    }]
  })
}))

I've checked and this seems to work in the playground, but let me know if it doesn't work for you. (Bear in mind there are a range of unreleased changes so you may need to wait for the next release.)


[WIP] Create upgrade script for gating purposes

This hasn't been tested; it's being updated so we can start to hash it
out in earnest.
TBD: 1. What should this script be called?  Will it be used by jenkins
only?
2. How do we handle the upgrade of rcp-openstack bits?  In liberty
version this was done by running scripts/deploy.sh.
3. Do we need to run pip-lockdown.yml?  We will need to test this
without running that.
4. Is there any reason why we'd need to re-run the ceph playbooks
when we're not changing ceph roles or the deployed version of
ceph?
5. Should this be a script or playbook?  This can easily be
converted to a playbook but this is largely just documenting
the manual steps required to perform the upgrade.
BLOCKERS: 1. migrate-yaml.py is stil being worked on and at present
will not create 100% usable variables files.
TODO: 1. This script should get confirmation from the user before
starting the upgrade.  This is dangerous command and not
getting validation from the user before running could be
catastrophic.
Connected https://github.com/rcbops/u-suk-dev/issues/357
Connected https://github.com/rcbops/rpc-openstack/issues/1345
Connected https://github.com/rcbops/u-suk-dev/issues/347

Should this move #357 into needs review?

How do we handle the upgrade of rcp-openstack bits? In liberty
version this was done by running scripts/deploy.sh.

I'm not sure why we would call deploy.sh. Essentially, if we re-run that with DEPLOY_OA='false', the difference between that and site.yml are:

Run pw-token-gen.py on user_osa_secrets.yml and user_rpco_secrets.yml (not sure if it would overwrite what's already there)
Run verify-mass.yml

I'd say there is nothing wrong with site.yml. It's a little more clear IMO.

@alextricity25 I believe there was an issue to get rid of site.yml.

@alextricity25 @sigmavirus24 One issue I know of is that a deploy may not have MaaS deployed.  What confuses me though is that in https://github.com/rcbops/rpc-openstack/blob/liberty-12.2/scripts/upgrade.sh we did not set DEPLOY_MAAS so that script would never upgrade the MaaS bits.  Anyone know how we handled this?

@mattt416 That's a good catch. I'm not sure about that one TBH, but what you said makes perfect sense. It doesn't look like the MaaS bits were ever upgraded.

@mattt416 probably explains why support included that as part of their maintenance plan:
https://github.com/rsoprivatecloud/Maintenance-Plans/blob/master/RPC 11.x: Upgrade to RPC 12.x#L268

Anyone know how we handled this?

Upgrades for 12.2 were tricky w/r/t MaaS. We changed how MaaS worked and thus needed separate playbooks for upgrading MaaS

This worked on a basic L->M upgrade for me(no MaaS, no ceph, no openstack resources provisioned). @mattt416, i've given my answers to your questions below:

TBD: 1. What should this script be called? Will it be used by jenkins
only?

If this script is only meant to be run by devs or the gate, then test-upgrade.sh is fine

How do we handle the upgrade of rcp-openstack bits? In liberty
version this was done by running scripts/deploy.sh.

In my opinion we shouldn't be using deploy.sh for upgrading he RPCO bits. Things could go wrong if people have some left over environment variables set or forget to set the right ones(i.e DEPLOY_OA). I don't see anything wrong with just invoking the playbooks included in site.yml, and wrapping setup-maas.yml around a conditional checking if DEPLOY_MAAS is set.

Do we need to run pip-lockdown.yml? We will need to test this
without running that.

I'll test that now. I'll edit this answer once it's finished.

Is there any reason why we'd need to re-run the ceph playbooks
when we're not changing ceph roles or the deployed version of
ceph?

I think we should worry about that once we get https://github.com/rcbops/u-suk-dev/issues/209 in the queue :)

Should this be a script or playbook? This can easily be
converted to a playbook but this is largely just documenting
the manual steps required to perform the upgrade.

Keep a script for now, and see how important is to convert it to a playbook later.

The variable munging stuff can potentially be moved out into a
separate playbook/script which can then be included here and by
support, but we will need to wait to determine how exactly this
is going to be run (do we use --danger DANGER or not?) before
we do that work.

I honestly don't think this should be automated at all in practice. For the sake of testing though, using --danger for now is okay.

@mattt416 @sigmavirus24 @alextricity25 if you look at site.yml, it does not match what is in deploy.sh. In addition, deploy.sh uses environment variables which site.yml cannot understand, the use of site.yml and deploy.sh are not equivalent. We have a slightly muddled interface for enabling different parts of the product, we have to set env and conf bits for Ansible but then also have additional variables used by the scripts. I think that deploy.sh and the upgrade process should use the same method to run the RPCO playbooks.
@mattt416 if you are going to solving everything in the one commit, please make sure to add additional cards to the backlogs for the things that need to be revisited to make them more support friendly.

Closing this as the expectation is that this work is done in smaller chunks.


put more structure into the JSON Schema

Hello fjprz,
I started to put more structure into the Schema (it is my first Jamf JSON Schema, so it may be totally wrong). Have a look at it and let me know what you think!

Will do some more work on it before sending it to you :-) Sorry!


possible to query directly in node-red function

Is it possible to query postgres directly in a node-red function?
I found an article that explains the process for mysql and I'm hoping that there's something similar.
`// Initialize the MySQL node
var mysql = context.get('mysql');
// Define the SQL query to be executed
var sql = 'SELECT * FROM users WHERE id = 1';
// Execute the query and retrieve the results
var result = await mysql.query(sql);
// Use the results in your JavaScript code
msg.payload = result;`
https://community.home-assistant.io/t/access-sql-database-from-within-a-node-red-function-node/501344

Hello,
This is an interesting approach, which I have not investigated.
It would require some minor refactoring to allow that elegantly. PR welcome!

At a quick glance, the node-red-node-mysql node referred by the article does not seem to allow such a usage
https://github.com/node-red/node-red-nodes/blob/master/storage/mysql/68-mysql.js
which makes me doubt whether that article ever worked.
Alternatively, you can use the underlying pg library from a node function: https://github.com/brianc/node-postgres


heredoc prefix <<- is different than HCL spec

https://github.com/mfcastellani/hcl-checker/blob/master/lib/hcl/lexer.rb#L84
<<- is not a requirement by HCL
If heredoc starts with <<-HEREDOC then terraform fmt expects ending with -HEREDOC instead of HEREDOC.

This is addressed by #6


Report an issue on Github  => error (400)

Description of the problem
The amount of log info being passed in the URL when launching an error report -> GitHub from the help menu results in a 400 return from GitHub

Resolved in VFB-dev2.


Improper minting starts date validation.

Description
https://github.com/Steemhunt/dixel-v2-contract/blob/74f4095f1e159c870f7cdedba9e2b815386c5f33/contracts/DixelClubV2Factory.sol#L47-L63
There is no validation for metaData.mintingBeginsFrom. It allow an attacker to create NFT contract with an invalid minting starts date.
Impacts
Attackers can create the NFT contract as if minting had started in the past. (e.g. Setting metaData.mintingBeginsFrom to zero means minting had started on the 1970-01-01)
Recommendation
In createCollection() function, If the metaData.mintingBeginsFrom less than block.timestamp, it should be replaced with  block.timestamp.
Example patch
    function createCollection(
        string memory name,
        string memory symbol,
        Shared.MetaData memory metaData,
        uint24[PALETTE_SIZE] memory palette,
        uint8[TOTAL_PIXEL_COUNT] memory pixels
    ) external payable returns (address payable) {

+      // Neutralize minting starts date.
+      if (metaData.mintingBeginsFrom < block.timestamp)
+          metaData.mintingBeginsFrom = block.timestamp

        address payable nftAddress = _createClone(nftImplementation);
        DixelClubV2NFT newNFT = DixelClubV2NFT(nftAddress);
        newNFT.init(msg.sender, name, symbol, metaData, palette, pixels);

It was an intended behavior because there's no issue with setting mintingBeginsFrom to the past value (even just zero).
We only checks if the block timestamp is order than mintingBeginsFrom when it's set
if(uint40(block.timestamp) < _metaData.mintingBeginsFrom) revert DixelClubV2__NotStarted(_metaData.mintingBeginsFrom, uint40(block.timestamp));

so any value less than the current timestamp would be just considered as "start immediately"

It was an intended behavior because there's no issue with setting mintingBeginsFrom to the past value (even just zero).

I agree with this. There's no issue with the NFT contract itself.
However, any user can retrieve mintingBeginsFrom(timestamp that minting event begins) via metaData().  I am not sure that this data will not be used off-chain.
https://github.com/Steemhunt/dixel-v2-contract/blob/6495dd6b59ce92cfce76a26d222bc1a3beccfb5a/contracts/DixelClubV2NFT.sol#L332-L344
https://github.com/Steemhunt/dixel-v2-contract/blob/6495dd6b59ce92cfce76a26d222bc1a3beccfb5a/contracts/Shared.sol#L11

Yeah I guess we can neutralize the data for just in case because it only adds a slight gas fee increase.
Thanks for your suggestion!


[WIP] Implements set_home()

Coverage decreased (-3.8%) to 84.217% when pulling d9b2fbcc6ab59d2c35a5b74e54dfb679e67487d8 on mkoistinen:feature/is_home_api into f4c46747cadb99c8a25804f43762f66720012d51 on divio:develop.

Coverage decreased (-3.9%) to 84.115% when pulling e53707362d5f6186c90548e26730651a7693dc13 on mkoistinen:feature/is_home_api into f4c46747cadb99c8a25804f43762f66720012d51 on divio:develop.

Coverage decreased (-3.9%) to 84.115% when pulling 1147ad12b0588a23e5d44161ad40a0eea5b62e53 on mkoistinen:feature/is_home_api into f4c46747cadb99c8a25804f43762f66720012d51 on divio:develop.

Coverage decreased (-4.07%) to 84.725% when pulling 8090d7341ef2307396c5d3ab978e487ec8017c31 on mkoistinen:feature/is_home_api into 9485daf76f48c0a06fd29808cdf70745f3180ddf on divio:develop.

Coverage decreased (-4.07%) to 84.725% when pulling 53ffc133ed03d33fff4b42abc9766db07842c3ad on mkoistinen:feature/is_home_api into 8c9f2af2760cbe4c23ff2adb3e6585dd701c563d on divio:develop.

btw the failing integration tests are valid
if you create a single page (it's published by default) and then go to edit_off mode you're presented with the welcome page, not the published page

Closed by https://github.com/divio/django-cms/pull/5999


fix for canvas rendering edge cases causing overflow errors

In certain edge cases (like the test case provided in tests/chart.rs) a canvas can cause a panic. This change tests for this edge case and includes a regression test for the future.

Thanks :+1:


tx.geoip-plugin_custom_lookup=1 fails with "Geo lookup attempted without a database"

Hi @azurit ,
I'm trying to get the plugin to work.
I am already using Apache HTTP Server's mod_maxminddb and modsecurity 2.9.7.
From the documentation in crs-setup.conf I read that I cannot use the settings with SecGeoLookupDB.
I have installed the plugin with
tx.geoip-plugin_custom_lookup=1
and set some countries (including DE for testing ;-) )
SecAction \
 "id:900600,\
  phase:1,\
  nolog,\
  pass,\
  t:none,\
  setvar:'tx.high_risk_country_codes=RU CN DE'"

Apache starts but fails during request processing with the following error:
[2024-01-05 13:40:31.382397] [security2:error] 84.156.182.x:57070 ZZf4v4Yc-TBnYRvKTART8gAAAw8 [client <IP_ADDRESS>] ModSecurity: Geo lookup for "84.156.182.x" attempted without a database.  Set SecGeoLookupDB. [hostname "xxxx"] [uri "/"] [unique_id "ZZf4v4Yc-TBnYRvKTART8gAAAw8"]

in
SecRule TX:HIGH_RISK_COUNTRY_CODES "!@rx ^$" \
    "id:910100,\
...
    SecRule TX:REAL_IP "@geoLookup" \
        "chain"
        SecRule GEO:COUNTRY_CODE "@within %{tx.high_risk_country_codes}" \
            "setvar:'tx.anomaly_score_pl1=+%{tx.critical_anomaly_score}',\
            setvar:'ip.reput_block_flag=1',\
...

I see the country code filled correctly from the maxmind env variable when I put it in access log.
What would be the right way to move further?
SecGeoLookupDB /var/lib/GeoIP/GeoLite2-Country.mmdb stops the error, but (apparently) does not block the tx.high_risk_country_codes as it does not get a country from the IP.
Should I write my own rule? I haven't written any complex rules yet :-( !
Thanks for helping!
Peter

Hi @logopk, seems like you have not loaded configuration file geoip-config.conf into web server or it's loaded after the file geoip-before.conf (configuration file must be loaded before this file).

Hi @azurit,
I doubt that this is the problem:
IncludeOptional /etc/modsecurity/crs/REQUEST-900-EXCLUSION-RULES-BEFORE-CRS.conf
IncludeOptional /usr/share/modsecurity-crs/plugins/*-config.conf
IncludeOptional /usr/share/modsecurity-crs/plugins/*-before.conf
Include /usr/share/modsecurity-crs/rules/*.conf
IncludeOptional /usr/share/modsecurity-crs/plugins/*-after.conf
IncludeOptional /etc/modsecurity/crs/RESPONSE-999-EXCLUSION-RULES-AFTER-CRS.conf

ls -l  /usr/share/modsecurity-crs/plugins/
total 8
-rwxr--r-- 1 1001 115 1146 Jan  5 13:46 geoip-before.conf
-rwxr--r-- 1 1001 115 1744 Jan  4 23:10 geoip-config.conf

and /server-info#mod_security2.c says
...
In file: /usr/share/modsecurity-crs/plugins/geoip-config.conf
  53: SecAction "id:9599020, phase:1, nolog, pass, t:none, ver:'geoip-plugin/1.0.0', setvar:'tx.geoip-plugin_custom_lookup=1', setvar:'tx.geoip-plugin_country_code=%{env.geoip_country_code}'"
In file: /usr/share/modsecurity-crs/plugins/geoip-before.conf
  17: SecRule TX:geoip-plugin_enabled "@eq 0" "id:9599099,phase:1,pass,nolog,ctl:ruleRemoveById=9599100-9599999"
  25: SecRule TX:GEOIP-PLUGIN_CUSTOM_LOOKUP "@streq 0" "id:9599100, phase:1, pass, nolog, ver:'geoip-plugin/1.0.0', chain"
  27: SecRule TX:REMOTE_ADDR "@geoLookup" "setvar:tx.geoip-plugin_country_code=%{geo.country_code}"
  36: SecAction "id:9599101, phase:1, nolog, pass, t:none, setenv:ModSecGeo=%{tx.geoip-plugin_country_code}"
...

Can you enable debug mode to see what it happening? This plugin is really simple: variable geoip-plugin_custom_lookup is set to 1 (which seems to passes) and right after it is checked if it equals to 0 (which, of course, should not pass).

[05/Jan/2024:19:03:31.365307 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 736f0788; [file "/etc/modsecurity/crs/crs-setup.conf"] [line "735"] [id "900600"].
[05/Jan/2024:19:03:31.365340 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 736f0788: SecAction "phase:1,auditlog,id:900600,nolog,pass,t:none,setvar:'tx.high_risk_country_codes=RU CN DE'"
[05/Jan/2024:19:03:31.365383 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Transformation completed in 2 usec.
[05/Jan/2024:19:03:31.365417 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Executing operator "unconditionalMatch" with param "" against REMOTE_ADDR.
[05/Jan/2024:19:03:31.365448 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Target value: "84.156.182.x"
[05/Jan/2024:19:03:31.365480 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Operator completed in 1 usec.
[05/Jan/2024:19:03:31.365514 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Setting variable: tx.high_risk_country_codes=RU CN DE
[05/Jan/2024:19:03:31.365552 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Set variable "tx.high_risk_country_codes" to "RU CN DE".
[05/Jan/2024:19:03:31.365594 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Warning. Unconditional match in SecAction. [file "/etc/modsecurity/crs/crs-setup.conf"] [line "735"] [id "900600"]
[05/Jan/2024:19:03:31.365654 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Rule returned 1.

...

[05/Jan/2024:19:03:31.366118 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 736ee830; [file "/usr/share/modsecurity-crs/plugins/geoip-config.conf"] [line "53"] [id "9599020"].
[05/Jan/2024:19:03:31.366153 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 736ee830: SecAction "phase:1,auditlog,id:9599020,nolog,pass,t:none,ver:geoip-plugin/1.0.0,setvar:tx.geoip-plugin_custom_lookup=1,setvar:tx.geoip-plugin_country_code=%{env.geoip_country_code}"
[05/Jan/2024:19:03:31.366196 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Transformation completed in 2 usec.
[05/Jan/2024:19:03:31.366230 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Executing operator "unconditionalMatch" with param "" against REMOTE_ADDR.
[05/Jan/2024:19:03:31.366262 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Target value: "84.156.182.x"
[05/Jan/2024:19:03:31.366294 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Operator completed in 1 usec.
[05/Jan/2024:19:03:31.366328 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Setting variable: tx.geoip-plugin_custom_lookup=1
[05/Jan/2024:19:03:31.366366 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Set variable "tx.geoip-plugin_custom_lookup" to "1".
[05/Jan/2024:19:03:31.366400 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Setting variable: tx.geoip-plugin_country_code=%{env.geoip_country_code}
[05/Jan/2024:19:03:31.366442 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Resolved macro %{env.geoip_country_code} to: DE
[05/Jan/2024:19:03:31.366477 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Set variable "tx.geoip-plugin_country_code" to "DE".
[05/Jan/2024:19:03:31.366523 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Warning. Unconditional match in SecAction. [file "/usr/share/modsecurity-crs/plugins/geoip-config.conf"] [line "53"] [id "9599020"] [ver "geoip-plugin/1.0.0"]
[05/Jan/2024:19:03:31.366556 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Rule returned 1.
[05/Jan/2024:19:03:31.366587 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Match -> mode NEXT_RULE.
[05/Jan/2024:19:03:31.366655 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 736f1d80; [file "/usr/share/modsecurity-crs/plugins/geoip-before.conf"] [line "17"] [id "9599099"].
[05/Jan/2024:19:03:31.366692 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 736f1d80: SecRule "TX:geoip-plugin_enabled" "@eq 0" "phase:1,auditlog,id:9599099,pass,nolog,ctl:ruleRemoveById=9599100-9599999"
[05/Jan/2024:19:03:31.366727 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Rule returned 0.
[05/Jan/2024:19:03:31.366757 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] No match, not chained -> mode NEXT_RULE.
[05/Jan/2024:19:03:31.366794 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 736f2ec8; [file "/usr/share/modsecurity-crs/plugins/geoip-before.conf"] [line "25"] [id "9599100"].
[05/Jan/2024:19:03:31.366828 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 736f2ec8: SecRule "TX:GEOIP-PLUGIN_CUSTOM_LOOKUP" "@streq 0" "phase:1,auditlog,id:9599100,pass,nolog,ver:geoip-plugin/1.0.0,chain"
[05/Jan/2024:19:03:31.366867 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Transformation completed in 2 usec.
[05/Jan/2024:19:03:31.366900 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Executing operator "streq" with param "0" against TX:geoip-plugin_custom_lookup.
[05/Jan/2024:19:03:31.366932 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Target value: "1"
[05/Jan/2024:19:03:31.366965 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Operator completed in 3 usec.
[05/Jan/2024:19:03:31.366995 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Rule returned 0.
[05/Jan/2024:19:03:31.367024 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] No match, chained -> mode NEXT_CHAIN.
[05/Jan/2024:19:03:31.367061 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 736ecea0; [file "/usr/share/modsecurity-crs/plugins/geoip-before.conf"] [line "36"] [id "9599101"].
[05/Jan/2024:19:03:31.367094 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 736ecea0: SecAction "phase:1,auditlog,id:9599101,nolog,pass,t:none,setenv:ModSecGeo=%{tx.geoip-plugin_country_code}"
[05/Jan/2024:19:03:31.367138 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Transformation completed in 2 usec.
[05/Jan/2024:19:03:31.367172 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Executing operator "unconditionalMatch" with param "" against REMOTE_ADDR.
[05/Jan/2024:19:03:31.367204 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Target value: "84.156.182.x"
[05/Jan/2024:19:03:31.367275 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Operator completed in 0 usec.
[05/Jan/2024:19:03:31.367312 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Setting env variable: ModSecGeo=%{tx.geoip-plugin_country_code}
[05/Jan/2024:19:03:31.367354 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Resolved macro %{tx.geoip-plugin_country_code} to: DE
[05/Jan/2024:19:03:31.367389 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Set env variable "ModSecGeo" to: DE
[05/Jan/2024:19:03:31.367431 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Warning. Unconditional match in SecAction. [file "/usr/share/modsecurity-crs/plugins/geoip-before.conf"] [line "36"] [id "9599101"]
[05/Jan/2024:19:03:31.367463 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Rule returned 1.
[05/Jan/2024:19:03:31.367493 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Match -> mode NEXT_RULE.
...

[05/Jan/2024:19:03:31.412532 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 72dc4ad8; [file "/usr/share/modsecurity-crs/rules/REQUEST-910-IP-REPUTATION.conf"] [line "76"] [id "910100"].
[05/Jan/2024:19:03:31.412551 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 72dc4ad8: SecRule "TX:HIGH_RISK_COUNTRY_CODES" "!@rx ^$" "phase:2,log,auditlog,id:910100,block,t:none,msg:'Client IP is from a HIGH Risk Country Location',logdata:%{MATCHED_VAR},tag:application-multi,tag:language-multi,tag:platform-multi,tag:attack-reputation-ip,tag:paranoia-level/1,tag:OWASP_CRS,ver:OWASP_CRS/3.3.5,severity:CRITICAL,chain"
[05/Jan/2024:19:03:31.412574 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Transformation completed in 1 usec.
[05/Jan/2024:19:03:31.412592 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Executing operator "!rx" with param "^$" against TX:high_risk_country_codes.
[05/Jan/2024:19:03:31.412608 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Target value: "RU CN DE"
[05/Jan/2024:19:03:31.412634 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Operator completed in 11 usec.
[05/Jan/2024:19:03:31.412656 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Rule returned 1.
[05/Jan/2024:19:03:31.412671 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Match -> mode NEXT_RULE.
[05/Jan/2024:19:03:31.412689 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 72a9f7b0; [file "/usr/share/modsecurity-crs/rules/REQUEST-910-IP-REPUTATION.conf"] [line "78"].
[05/Jan/2024:19:03:31.412705 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 72a9f7b0: SecRule "TX:REAL_IP" "@geoLookup " "chain"
[05/Jan/2024:19:03:31.412726 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Transformation completed in 0 usec.
[05/Jan/2024:19:03:31.412742 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Executing operator "geoLookup" with param "" against TX:real_ip.
[05/Jan/2024:19:03:31.412758 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] Target value: "84.156.182.x"
[05/Jan/2024:19:03:31.412775 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][1] Geo lookup for "84.156.182.x" attempted without a database.  Set SecGeoLookupDB.
[05/Jan/2024:19:03:31.412877 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Operator completed in 103 usec.
[05/Jan/2024:19:03:31.412894 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Rule returned 0.
[05/Jan/2024:19:03:31.412909 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] No match, chained -> mode NEXT_CHAIN.
[05/Jan/2024:19:03:31.412945 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 73619e88; [file "/usr/share/modsecurity-crs/rules/REQUEST-910-IP-REPUTATION.conf"] [line "129"] [id "910120"].
[05/Jan/2024:19:03:31.412964 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 73619e88: SecRule "IP:PREVIOUS_RBL_CHECK" "@eq 1" "phase:2,auditlog,id:910120,t:none,nolog,tag:application-multi,tag:language-multi,tag:platform-multi,tag:attack-reputation-ip,tag:OWASP_CRS,ver:OWASP_CRS/3.3.5,skipAfter:END-RBL-LOOKUP"
[05/Jan/2024:19:03:31.412986 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Rule returned 0.
[05/Jan/2024:19:03:31.413002 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][9] No match, not chained -> mode NEXT_RULE.

@logopk Cool, that helped, thank you!
Plugin is working fine and as excepted. Geoip lookup is called in different part of the rule set:
[05/Jan/2024:19:03:31.412689 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][4] Recipe: Invoking rule 72a9f7b0; [file "/usr/share/modsecurity-crs/rules/REQUEST-910-IP-REPUTATION.conf"] [line "78"].
[05/Jan/2024:19:03:31.412705 +0100] [xxx.com/sid#72e4dbb0][rid#75c0c058][/][5] Rule 72a9f7b0: SecRule "TX:REAL_IP" "@geoLookup " "chain"

You are using IP reputation feature of CRS, which depends on ModSecurity's geoip lookup. IP reputation feature was removed from development version of CRS and will come back in the future as a plugin. Are you using it?

Hi @azurit,
I did not so far - but I thought that's what the geo plugin uses as the rule to block the request.
Should I remove REQUEST-910-IP-REPUTATION.conf?
Then how will the block rule look like?
Peter

@logopk GeoIP plugin is just a simple plugin which adds GeoIP support to CRS, nothing more and nothing less. It cannot do anything more on it's own and is intended for usage by other plugins or custom rules (for example future IP reputation plugin which will not manage geoip on it's own - it will by managed on one place for all plugins by GeoIP plugin).

Should I remove REQUEST-910-IP-REPUTATION.conf?

No, just disable IP reputation feature in crs-setup.conf.

Then how will the block rule look like?

For example:
SecRule TX:GEOIP-PLUGIN_COUNTRY_CODE "@pm RU CN DE" \
    "id:999,\
    phase:1,\
    t:none,\
    msg:'GeoIP blocking',\
    logdata:'GeoIP country: %{tx.geoip-plugin_country_code}',\
    deny"

But you can use also IP reputation feature of CRS. This plugin is mainly for CRS 4.0 and up. Currently, the only advantage to use this plugin is performance - IP reputation feature cannot use mod_maxminddb data and will do it's own geoip lookup (so you will do two geoip lookups for every request).

Hello @azurit,
this is working well - it's blocking!
The way to get the "old" maxmind data to work with modsecurity2 would be too much of a hassle - so I'm happy with your plugin and mod_maxminddb. Can't wait to see CRS 4 released though!
Thank you for your support.
Peter


Composite with gravity, right and bottom params

What are you trying to achieve?
Put watermark using gravity in composite with an offset from left and bottom edge.
Have you searched for similar feature requests?
I didn't find it. I found just left and top params, but I have to place watermark manually.
What would you expect the API to look like?
Create offset param in object.
await sharp('image.png')
  .composite([{
    input: 'watermark.png',
    gravity: 'southwest',
    offset: {
      left: 10,
      bottom: 10
    }
  }]).toFile('image.png');

What alternatives have you considered?
If I want to achieve this, I have to calculate image size, watermark size and make some calculation.
Is there a sample image that helps explain?
At now I have:

I would like to achieve this:

Hi, perhaps you could extend the watermark image by 10 transparent pixels along the left and bottom edges?

You're right. I haven't thought about this 🤦♂

I know this is an old one, but it'd be really great if you could add "right" and "bottom" options. It's not always possible to add this kind of margin to the image itself. Also it'd be a lot better to be able to fully control the position programmatically.


I want to access zipkin UI via https. Does zipkin UI supports that?

This issue tracker is not for questions. If you want to ask how to do something, or to understand why something isn't working the way you expect it to, please use Gitter or Stack Overflow.

we use armeria and spring boot underneath. Please use gitter next time for questions as we don't use issues as you notice in the issue description you pasted.
https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#howto-configure-ssl

@adriancole  I am using zipkin-server jar version 2.12.6 and have gone through with readme doc at https://github.com/openzipkin/zipkin/blob/master/zipkin-server/README.md but there is no mention of which params to use for https based url. So my question was do we have that functionality in that zipkin executable jar and if yes then which all params, like for kafka we have overrides that we can set during jar launching.

you are very behind (latest is 2.16.1). please update before asking more
questions about config. we can chat more here
https://gitter.im/openzipkin/zipkin
On Fri, Aug 16, 2019 at 3:16 PM mvbjoshi<EMAIL_ADDRESS>wrote:

@adriancole https://github.com/adriancole I am using zipkin-server jar
version 2.12.6 and have gone through with readme doc at
https://github.com/openzipkin/zipkin/blob/master/zipkin-server/README.md
but there is no mention of which params to use for https based url. So my
question was do we have that functionality in that zipkin executable jar
and if yes then which all params, like for kafka we have overrides that we
can set during jar launching.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/2754?email_source=notifications&email_token=AAAPVV3S6J5Y4AM7ZXVDOK3QEZH4VA5CNFSM4ILVWRN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4N36SA#issuecomment-521912136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAPVV75HVVR3ANW3DYMFT3QEZH4VANCNFSM4ILVWRNQ
.


Crash when loading chunks nearby oceans

When loading chunks with too much fluid nearby (e.g. coastlines, centers of deep oceans, and possibly lava lakes in the Nether), the game will suddenly crash. This has been tested with only TinyTweaks installed.
A full crash report can be found here.

I've received a report for this issue before, but haven't had any luck fixing it. Do you have the BubbleColumnsFlow tweak on or off?

It's on.
发自我的iPhone

在 2020年8月17日，22:49，Hephaestus-Dev<EMAIL_ADDRESS>写道：

I've received a report for this issue before, but haven't had any luck reproducing it. Do you have the BubbleColumnsFlow tweak on or off?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


global variable for cached TemplateStringsArray is used for multiple call sites

TypeScript Version:  2.6.0-rc , 2.6.0-dev.20171013
Code
export function tag(parts: TemplateStringsArray, ...values: any[]) {
    return parts[0];
}
function foo() {
    console.log(tag`foo`); // var _a
    console.log(tag`foo2`); // var _b
}

function bar() {
    console.log(tag`bar`); // var _a, expected var _c
    console.log(tag`bar2`); // var _b, expected var _d
}

foo();
bar();

Expected behavior:
Logs
foo
foo2
bar
bar2

Actual behavior:
Logs
foo
foo2
foo
foo2

The TemplateStringsArray for tag`foo`  uses the global variable _a for caching, because it is the first tagged template in it's scope.
Unfortunately the TemplateStringsArray for tag`bar`  also uses the global variable _a for caching, because it is the first tagged template in it's scope.
Which template is cached depends only on the order of execution.

Thanks for reporting this! Should be fixed with our next nightly.


Inconsistent behaviour of publish verifier results

Hi,
I've observed an inconsistent behaviour when publishing verification results. My project setup is as follows:

Using au.com.dius:pact-jvm-provider-junit_2.11:3.5.24.
Running local pact broker using the provided docker-compose file for testing.
Not setting pact.verifier.publishResults.
Not using pact's maven plugin.

Test class:
@ContextConfiguration
@RunWith(PactRunner.class)
@Provider("provider")
@PactBroker(host = "localhost", port = "80")
@SpringBootTest(...)
public class ProviderTest {
...
}

Scenario 1:
// Annotations
public class ProviderTest {
  @State("test something")
  public void testSomething() {
    // something that will make the test pass
  }
}

My test passes and results are not published to the broker as expected because I did not set pact.verifier.publishResults to true. ✅
Scenario 2:
// Annotations
public class ProviderTest {
  @State("test something")
  public void testSomething() {
    // something that will make the test fail
  }
}

My test fails and results are not published to the broker as expected because I did not set pact.verifier.publishResults to true. ✅
Scenario 3:
// Annotations
public class ProviderTest {
  // Completely remove the test state.
}

My test fails with MissingStateChangeMethod: Did not find a test class method annotated with @State("test something") but results are still published to pact broker despite not setting pact.verifier.publishResults. ❌
My understanding of pact.verifier.publishResults is that only when this is set to true will results be published to the broker. Does this not apply to the case of missing test states? Is there a documentation for this?

Results should never be published if pact.verifier.publishResults is not set correctly.

3.5.25 has been released with this fix

Thank you!


WIP: V6/feature/sparql optimization

Fixes #
See #1818  for proposal.
It's an ongoing task, thus the pull request will evolve. However I will have some questions while implementing, this issue can be used for discussions(?)

For quicker testing (headless) I've added mocha+nyc. @NZT48 @kotlarmilos @zeroxbt is this fine? Do you have any other ideas or testframeworks running at the moment?

Updated missing functionality in SparqlQueryService. Will update the testcases still, to show how to handle the functions.
Missing is the integration into OT-Node itself now, because the current implementation expects a different result format.
The further todos are:

Make Blazegraph extend SparqlQueryService and delete the existing functions in it step by step and adjust the returned SparqlQueryService result to fit the expectation. (Or adjust data-service to work with the new result)

Make GraphDB extend SparqlQueryService and delete the existing functions in it step by step and adjust the returned SparqlQueryService result to fit the expectation. (Or adjust data-service to work with the new result)

GraphDB has two different sparql endpoints, one for retrieving (select, ask,...) and one for updates. Thus, I had to add another parameter for two different sparql endpoints.

I've made the testcases generic, such that all sparqlservice tests are integration tests, using on the fly generated data.

FindAssertions required a mapping from the old expected structure using axios (like in blazegraph/graphdb service) to the new one using sparql endpoints.

E-Mail with feedback sent to team

Merging without tests - will be checked before the release


Shadow clipped/not shown for split_screen example on WebGL

Bevy version
Bevy 0.14
Relevant system information
Confirmed on Firefox and Edge at least. Does not happen on WebGPU or native Windows.

`AdapterInfo { name: "ANGLE (NVIDIA, NVIDIA GeForce GTX 980 Direct3D11 vs_5_0 ps_5_0), or similar", vendor: 4318, device: 0, device_type: Other, driver: "WebGL", driver_info: "2.0", backend: Gl }`

What you did
Run https://bevyengine.org/examples/3d-rendering/split-screen/
(also I rotated foxes to show clipping effect)
Additional information
This warning was logged:

crates/bevy_pbr/src/render/light.rs:593 The number of cascades configured for a directional light exceeds the supported limit of 1.

I tried running the example with num_cascades changed to 1, and the shadow indeed seems to be fixed.

Can also confirm on Chromium WebGL it has the same issue, but WebGPU it doesn't. (Also the buttons are pure white on WebGL for me).


Make go1.11 the minimal version

If we're willing to make go1.11 the minimal version I can make the build system much simpler and reduce the some of the build task times on drone by a factor of 10 (to the extent that much of the time is spent re-downloading dependencies).
Also, Windows support gets simpler.
The one thing that requires education is that people need to know that gitea CANNOT live in GOPATH when using go.mod.
In go1.13 the default behavior will change. I'm not sure if GOPATH will just be ignored or what they plan to do.

The main blocking problem is go-swagger currently not working outside GOPATH.

@sapk Would it be okay to document that the minimum required version is go1.11 and iteratively make changes that don't break swagger (or errcheck)?

Personally, I am following golang recommendation of supporting the last two versions so no problem with that. But some os are not up to date on that and some user can be impacted by such choice. In fact, we are more in at minimum supporting the three last release without gcc (https://github.com/go-gitea/gitea/blob/master/.drone.yml#L59).

I think this has been resolved.


Fix travis notifications

Resolves our Travis IRC issues. Hopefully.

Just a Travis change and Travis passed, merging
@rh-atomic-bot r+


rollback tf-gpu==2.6; enable scipy-ml test

Merge tf+tensorboard branch.

tf & keras version issue
LD_LIBRARY_PATH
manifest bug fixed


test: added unit tests for isArrBuffer, isAsyncGen, isAsyncGenFunc and isBigInt

看看你室友的 commit 写得多规范 @GarlicGo

np


feat: improve username validation test

feat: improve username validation tests
feat: improve username validation tests

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

That must have fallen through the cracks, feel free to add it in  😄


Mix of p203 and p302 files from download_data

I'm having issues with the download_data tool. It downloads all the weekly files, mixing p203 and p302 ones. When one tries to analyze old data which have both of them, the analysis crashes.
I'm currently fixing it with the following,
ls ${ENRICO_DIR}/Data/download/weekly/photon/*.fits | grep p302 > ${ENRICO_DIR}/Data/download/events.lis
is there any way to deal with this in a more elegant way within enrico?

Hi
sorry for the late notice, github do not send me email anymore...
I can reproduce the bug. Enrico is looking into ftp://legacy.gsfc.nasa.gov/fermi/data/lat/weekly/photon
so I have not clue of what can append. do you have the output of the tool?

is this issue still valid?

Sorry for the extremely late response. Yes, the bug is still there.


[Feature Request] - Operator FalconNodeSensor API Secrets

Overview
As a user I would like to reference a secret to provide the falcon_api.client_id and falcon_api.client_secret sensitive values to the FalconNodeSensor object so that I can safely store it in source control.
Extra Information

Using version 0.9.1 of the Operator on OpenShift.
This is an enabler from a GitOps point of view and allows users to leverage other secret management solutions to create the secret object and keep sensitive information out of source control.
This change would bring feature parity to the operator aligning it to the HELM chart.
** https://github.com/CrowdStrike/falcon-helm/pull/87

Forgive my ignorance as I'm still trying to understand the differences between using the falcon API and using an image from a registry. I would like to use the falcon api but not being able to specify a secret that stores the client_secret is a blocker. Can I use image pull secrets without specifying a custom image?
apiVersion: falcon.crowdstrike.com/v1alpha1
kind: FalconNodeSensor
metadata:
  name: falcon-node-sensor
spec:
  falcon:
    cid: <CID>
  node:
    imagePullSecrets: <IMAGE_PULL_SECRET>

Why is recommended to not use a secret if using git? We use dozens of helm charts and a handful of operators and none of them dictate that users should not store secrets in secrets. They allow referencing native k8s secrets in CRDs and charts.
That being said they are all open source so maybe I'm misunderstanding how this operator is supposed to work given some of the constraints here.

We're using the Operator on GKE with Autopilot, which is prevent us to use Flacon image from a private repository (at least 2 weeks GKE support isn't able to add our repository the an allow-list as mentioned in the doc). So we have to use client_id and client_secret.


chore: Install latest MongoDB v5

We're pinning MongoDB to 5.0.14, but can just as well run 5.0.19. This PR makes sure we install the latest v5 of MongoDB, every time we build the image.

/ok-to-test


cypress/base:16, cypress 10.3.1: example tests found when running in CI

Hi, I've set up a GitLab CI pipeline using cypress/base:16. When I run locally everything works as expected.
In CI, however, Cypress picks up 20 tests I have not written.
You can see below it finds 22 specs. I have only written app-banner.cy.js, app-cookie-consent.cy.js. Where are these other specs coming from? They're making my pipeline fail.
> cypress run --headless --component --config watchForFileChanges=false
[STARTED] Task without title.
[SUCCESS] Task without title.
[1344:0802/123745.108777:ERROR:sandbox_linux.cc(377)] InitializeSandbox() called with multiple threads in process gpu-process.
[1344:0802/123745.114482:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported.
Couldn't find tsconfig.json. tsconfig-paths will be skipped
====================================================================================================
  (Run Starting)
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        10.3.1                                                                         │
  │ Browser:        Electron 100 (headless)                                                        │
  │ Node Version:   v16.14.2 (/usr/local/bin/node)                                                 │
  │ Specs:          22 found (app-banner.cy.js, app-cookie-consent.cy.js, todo.cy.js, actions.cy.j │
  │                 s, aliasing.cy.js, assertions.cy.js, connectors.cy.js, cookies.cy.js, cypress_ │
  │                 api.cy.js, files.cy.js, local_storage.cy.js, location.cy.js, misc.cy.js, navig │
  │                 ation.cy.js, network_re...)                                                    │
  │ Searched:       **/*.cy.{js,jsx,ts,tsx}                                                        │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

Just in case someone else has the same issue, I have added --spec 'cypress/**/*.cy.js' when calling cypress as a workaround

@TommasoAmici
The additional tests mentioned come from scaffolded tests. Normally these would only be added optionally.
I'm going to close this issue as it refers to an old version. If are still encountering this issue, please comment and we can re-open.


Cow: Watch immortalboost.com

Cow requests the watch of the watch_keyword immortalboost\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

immortalboost\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Search is completely broken

Package throws an error 'Invalid Query'

It seems that when you created this issue, soundcloud had a problem. Everything seems to be back to normal now.


Update framework version to 1.1.2

Simply pull from upstream

:+1:

Closing this as nativescript samples will be wholly modified


Orphan nodes when adding seeds from connected papers after deleting seeds

On the css-restructure branch only
Steps to reproduce:

Click add seeds
Click upload bibtex
Click DEMO
Delete the first seed paper by clicking the red X in the top left corner.
Click 'Connected' to switch to the list of connected papers.
Click the green plus in the top left corner of the first paper to add as a seed.

fixed.


statically link sdl2.dll in windows

Fixing in upstream branch

Updated skulpin fork to statically link sdl2. Should work now


Fix class and interface spans

The interface span for something like interface Test {} was Test {}. Also, for stuff like export default abstract class Test{} it was class Test{} instead of abstract class Test {}.

Here's an example of one of the failing tests I get on my local machine.

So I get a lot of noise with failing tests, which makes it difficult to sort through.

@dsherret You need to set autocrlf to input. Tests fail because \r\n is two byte while \n is one byte.
git config core.autocrlf input

@kdy1 thanks! That worked for me :)
I noticed some problems with my PR now and will fix them tomorrow.

Ok, this is good now. Thanks for the tip about setting the git config!

bors r+


Array registration

My Element can't find the Array, what was initialized like here.

Tried to work arround by using the attached key and the async function.
I'm trying to watch change on inner values of that Array, but it's a pity, that it doesn't work.

When I initialize it through

Then the array gets filled, but I still cannot watch if an array, what is in the upper array was modified or not, allthough I also fill it, like above, with the atandard array methods https://www.polymer-project.org/1.0/docs/devguide/properties.html#array-mutation

@fooloomanzii  I wasn't able to reproduce the issue here (using setInterval and dummy data to mimic socket.io in your example: http://jsbin.com/motida/edit?html,output
Maybe you can try to modify that jsBin to more closely match your problem and try to reproduce the issue?

Yes, I'm sorry for putting up this request. It seems, that the problem was in the rest of my code, that another element did request the first array-element, before it excisted by two-way-binding. I modified your example, for structured data, and it still works: http://jsbin.com/xofuya/edit?html,console,output
Sorry for that and thank you for your time


chore(main): release 0.0.12

:robot: I have created a release beep boop
0.0.12 (2024-07-13)
Bug Fixes

Improved windows support. (016e913)

Miscellaneous Chores

Preper 0.0.12 release (259bc56)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.12
:sunflower:


Rough implementation in Go

I had some free time and wanted to try out GopherJS. Couldn't think of a better project that this to try out a new frontend framework. The implementation is quite rough, unpolished and not up to the standards of other submissions but I decided to share anyway as it might be interesting for some people.
It satisfied all requirements except aborting XHR requests. I couldn't figure out a sane way to use Go's net/http and cancel requests when compiling to JS.

@staltz Thanks for this great exercise. flux-challenge should be used everywhere instead of todo-mvc IMO.


Easier link between PBM and LCA

A ParameterizedBrightwayModel instance is useful for loading all parameter data for a given group, and updating this data using presample packages.
What is is not good at is directly passing the updated data to an LCA instance. One would need to load the data, calculate new matrix presamples, save the presamples, and then use the presamples in a new LCA instance. The "saving the presamples package to disk" step should be avoidable.
It would be great if PBM objects (or its matrix data) could be passed directly to LCA instead.

@cmutel perhaps this is already possible in bw2.5. Is there documentation on the structure of data_objs that can be passed to LCA?
This indicates a dict is accepted, perhaps the data in the PBM can be formatted to an acceptable dict.


Archive deleted experiments multiple times

Bug Report
select name,start_time,finish_time from archive_experiments where namespace='tipocket-cdc-kafka';

Seems the same experiment is stored in the DB several times.

The cause is that the cleanup of chaos is blocked by the finalized. But since the chaos daemon network problem, the recovery is always failing. But we stored the archive several times.
apiVersion: pingcap.com/v1alpha1
kind: TimeChaos
metadata:
  creationTimestamp: "2020-05-14T22:56:43Z"
  deletionGracePeriodSeconds: 0
  deletionTimestamp: "2020-05-14T22:58:57Z"
  finalizers:
  - tipocket-cdc-kafka/tipocket-cdc-kafka-upstream-tikv-1
  generation: 24
  name: tipocket-cdc-kafka-tipocket-cdc-kafka-upstream-tikv-1-time-chaos
  namespace: tipocket-cdc-kafka
  resourceVersion: "76364895"
  selfLink: /apis/pingcap.com/v1alpha1/namespaces/tipocket-cdc-kafka/timechaos/tipocket-cdc-kafka-tipocket-cdc-kafka-upstream-tikv-1-time-chaos
  uid: d3a19fc8-db45-4d43-b4a1-2c39ad826e68
spec:
  clockIds:
  - CLOCK_REALTIME
  mode: one
  paused: false
  selector:
    namespaces:
    - tipocket-cdc-kafka
    pods:
      tipocket-cdc-kafka:
      - tipocket-cdc-kafka-upstream-tikv-1
  timeOffset: -159ms
  value: ""
status:
  experiment:
    phase: Failed
  phase: ""

@yeya24 Can we determine whether the experiment is actually deleted?

@yeya24 Can we determine whether the experiment is actually deleted?

I am not sure. Maybe @Yisaer knows better.
But IMO we should deal with the finalized problem indeed. If the injected pods are deleted, we should cleanup the chaos.
You can see there are no pods, but all the time chaos is left.

Do you have a solution for this now? @cwen0 @fewdan

I think we can close this issue now.
If there are anything still not works well, please reopen it


Restore RDS Instance from a backup

What problem are you facing?
Every night, a new snapshot with the latest test data is generated and stored in S3. I'd like to be able to use that data when creating an RDS instance with Crossplane.
AWS supports this natively: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_RestoreDBInstanceFromS3.html

Do you have any thoughts on how this might be modelled @rberrelleza? It seems like a fairly imperative API operation. One option would be to mirror Terraform's approach and essentially make it a subobject of our spec, maybe spec.forProvider.createFromBackup or similar?

That's what I was thinking @negz .  The AWS command receives the location of the backup as a parameter. I think the same could be done here on a sub-object, to keep it clean, as you suggest:
spec:
  forProvider:
    fromBackup:
     s3:
       bucket: mybucket
       prefix: prefix
      role: ....

Rhe 'recover from s3' functionality is aws-only, but cloudsql also has a similar mechanism to create a DB from a backup.  Not sure how much this would factor into the design, but long term it would be great to be able to support this across different cloud providers.

Curious if this has been looked at recently?  Being able to create an instance from a snapshot and point in time snapshot would be a great feature.

Another feature that is being implicitly enabled by this is to allow developers to spin up a new database from a previous snapshot and then test new functionality on that database, then throw it away afterwards.

Without this feature, if the database were to become corrupted, the recovery process would be:
AWS CLI, Console, Terraform, Ansible, etc. (not Crossplane):

Restore (point in time) a DB snapshot to a new instance.
pg_dump the database(s) from the new instance.
drop all databases in the original Crossplane instance.
pg_restore the database(s) to the original Crossplane instance.

This enhancement would be very helpful and provide peace of mind --skipping the intermediary instance creation.
I personally would like to see snapshots (all engines supported) as a source over S3. S3 restore is MySQL only.

I think I've got a basic version of this (restore a MySQL backup from an S3 bucket) working...it's not going to cover all of the use cases discussed here but it could be a good start. Will open a PR soon.

If anyone here wants to test my changes on a live cluster, feel free to install the danports/provider-aws:rds-restore provider. Unfortunately, this doesn't work well if you already have the official provider installed with managed resources created, since Crossplane will complain that those resources already have a controller. (Is there an easy way to change the controller for all managed resources in one shot?)


[SMALLFIX] Validate command line args in ApplicationMaster

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7284/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7317/
Test PASSed.

LGTM


Add a reference to get-promisable-result package in the README

This pull request changes the documentation to reflect that the package needs the get-promisable-result package as a peer dependency.

coverage: 100.0%. remained the same
when pulling db01da96f33fe5bea0643fdd6e88312d35393906 on add_get_promisable_result_documentation
into 03361047a43f192c33bd5dbf0829c497d558bf0d on master.


Automated cherry pick of #1063: cloudproviders: 调整lb资源清理顺序

Cherry pick of #1063 on release/2.8.0.
#1063: cloudproviders: 调整lb资源清理顺序

/lgtm
/approve

/lgtm
/approve


use of undocumented inputParser.addOptional behaviour

The inputParser.addOptional method is being used for the optional arguments. addOptional is meant for positional arguments, i.e., arguments that are interpreted based on their position of the argument list.  From mathworks documentation:

Arguments added to the input parser scheme with the addOptional function are positional. Therefore, add them to the input parser scheme in the same order they are passed into the function.

However, all examples show them being used as named parameters and out of order:
mdDelay(data, 'maxLag', 25, 'plottype', 'all');

I have tested it in Matlab and indeed it works. However, it is weird because not only the options are out of order (the options order is plottype, numBins, maxLag,...) but also because the option names seem to be ignored. Reading the documentation, one would expect that the above call would result in the following:
plottype = 'maxLag'
numBins = 25
maxLag = 'plottype'
criterion = 'all'

I don't understand how this is working in Matlab, but it would be clearer if addParameter was used instead:

Use addOptional to add an individual argument into the input parser scheme. If you want to parse an optional name-value pair, then use the addParameter function.

The reason to request this change is so that this code can also be used in Octave.

Thanks, @carandraug
I will look into this. From your description it seems that using addParameter instead would be the correct way of dealing with the arguments. I've probably been influenced by how arguments are handled in JavaScript and Python and not read the MATLAB documentation properly.
I've added this to my to-do list and will look into it ASAP.


Use https + .io domain for RTD

Coverage remained the same at 85.62% when pulling 85a9f15718f256c7b5f491df9409400b9d8e91d5 on jeffwidman:patch-3 into a49d21a0d1d4f71cdf17142d1334f3206618162c on Grokzen:unstable.


Single user server cannot be run under Python 2

While the majority of JupyterHub's codebase is Python 3 only, the single user server is an extension to the core Jupyter Notebook, which still supports Python 2 to the best of my knowledge.
80531341c052fb8bc6bab5c3aaaac0b6329b03d2 renders the Single user server unusable in Python 2 because it imports from urllib.parse, which only exists in Python 3.

I think it's fine for the single-user server to require Python 3. It's only kernel code that needs to run on py2, and that's unaffected by the server Python.

The issue here for me is that I'm running the single user server in a docker container.  Forcing the single-user server to run on Python means that I have to supply both Python 2 and Python 3 in said container, which makes my build times substantially longer and makes my substantially container larger, which means slower deploys and new failure modes.

@minrk https://github.com/jupyter/jupyterhub/pull/236 makes singleuser.py runnable again for me under Python 2.
I'm 100% on board with the main hub code only supporting Python 3, but forcing users to run single-user servers under Python 3 as well represents a substantial burden for anyone who only plans to supply Python 2 kernels.

The notebook server that single-user subclasses probably won't keep Python 2 support too much longer, specifically because the server and kernel don't need to use the same Python.


CLI option for parallel gcm + improving tests

Coverage increased (+0.01%) to 79.107% when pulling 1865e7b204365474350eb02c9faa75f06cf65760 on feature/pn-26-benchmark-parallel-gcm into a33129a344d90ae4ad4d6bc06810f214d5bf2033 on master.

Coverage decreased (-0.06%) to 79.039% when pulling d2f30ff2fe8bd83e272c1c35c679f058aef7779e on feature/pn-26-benchmark-parallel-gcm into a33129a344d90ae4ad4d6bc06810f214d5bf2033 on master.


Fix for #368

All relevent changes are in aws.go

Could you please drop all the import changes from the commits?
For go projects it's a good idea to use the original repository in your go path but just add your  fork as another remote, that way you don't have to change the imports when testing it locally.

Will do...
On Oct 31, 2017 12:02, Mikkel Oscar Lyderik Larsen<EMAIL_ADDRESS>wrote:
Could you please drop all the import changes from the commits?
For go projects it's a good idea to use the original repository in your go path but just add your fork as another remote, that way you don't have to change the imports when testing it locally.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/kubernetes-incubator/external-dns/pull/374#issuecomment-340873492, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJAKlkJ1A-q8DHbtacApV32ze1yqExrFks5sx27VgaJpZM4QNNql.

stashed, reset import changes, stash applied, commit'd, pushed... should be good now..

Thanks for your PR!
Maybe you can try to rewrite your code mor like this:

func batchLimitChangeSet(changes []*route53.Change) []*route53.Change {
...
	for i := 0; i < len(changes); i += batchLimit {
		batch := a[i:min(i+batchLimit, len(changes))]
		//do something
	}
...
}
// a + b should have better names
func min(a, b int) int {
	if a <= b {
		return a
	}
	return b
}

This would be easier to read it (at least for me).
batchLimit could be something which could be moved to const (but here I'm totally open).
Also please add unit tests.

The reason I wrote the function in the manner I did was to preserve the atomic nature of all related records by hostname.   Currently all the A records are added first to the original CS, then all the TXT records are added to the CS and the entire batch is presumed atomic.  If one were to just take the head or the tail of the original CS they would be violating the integrity that they were originally expecting.  This said I'm happy to rework in any way desired.  Do you still want said changes?

I think I can combine both ideas so its not an eventually complete scheme as you wish.

please address two comments above, otherwise LGTM

@ideahitme please merge if you approve - I'd like to get on with helping related issue #270

done

From: Yerken<EMAIL_ADDRESS>Sent: Thursday, November 2, 2017 3:50 PM
To: kubernetes-incubator/external-dns
Cc: Steven Logue; Author
Subject: Re: [kubernetes-incubator/external-dns] Fix for #368 (#374)
@ideahitme commented on this pull request.

In provider/aws.gohttps://github.com/kubernetes-incubator/external-dns/pull/374#discussion_r148680383:

}

  log.Warningf("Initial change batch count is %d which exceeds %d", size, limit)

  countsByName := make(map[string]int)

  for _, v := range cs {

          countsByName[*v.ResourceRecordSet.Name]++

  }

  var newCs = []*route53.Change{}

  remaining := limit

  for name, count := range countsByName {

          if (remaining - count) > 0 {

                  remaining -= count

                  for _, v := range cs {

the idea was to create a map changesByName instead of countsByName:
changesByName := map[string][]*route53.Change
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/kubernetes-incubator/external-dns/pull/374#discussion_r148680383, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJAKlleFrquIIY4ACOZ5D5maTXV_Wpq4ks5sykdAgaJpZM4QNNql.

thank you, looks good to me, however it would also be nice to see tests for the function

thanks for the feedback! - tests coming

@ideahitme initial tests have been added - please comment

two minor things:

Please add this to Changelog
Travis build is failing due to g1.8 sortstable. We should drop go1.7 support from travis.

otherwise LGTM

@ideahitme - rebased, updated the changelog and travis and its all ready for you now...

:+1:

👍


New theme + extra useful features

https://github.com/Hashnode/starter-kit/assets/108281031/ac47faf9-239f-4d22-9811-0df0f0187986
Demo Link:- https://hashnode-starter-kit-01-9zez.vercel.app/
Tech Stack Utilized:-

Next.js (The Industry Standard Framework For React)
SCSS & Tailwind (CSS Preprocessor & Library)
framer-motion (GSAP's father for working in react)
Swiper.js (The library who showoffs a lot of images using slideshow)
Google Translate API (some FREE STUFF)
Datamuse API for synonyms (some FREE STUFF)
Twak.js Package (some more FREE STUFF)
Plus all the existing libraries utilized in the project

Features:-

Modern, Clean & Sleek UI/UX Principles with Smooth Animations
Language Translation For The Blog
In Built Dictionary
Cool Page Transitions
In Built Audio Book (Blog Reader)
ChatBot
In Built Quizzes at the end of the blog
Code Previewer

Hello reviewers I have seen right now that the side bar does not have those sigzag pattern to fix it could you please remove this line from globals.css when you are reviewing it

Hi @Srinivasan-Akash ,
Thank you for your creative contribution and for developing this new theme! We appreciate your effort to enhance the versatility of our starter kit.
However, to maintain a streamlined and focused codebase, we are not currently adding new themes directly to the main repository. Instead, we would love to showcase your theme by featuring it in our README file.
We noticed that the demo link you provided ([demo link](https://hashnode-starter-kit-01-9zez.vercel.app/

))  is currently returning a 404 error. Could you please check the link and provide:

A link to your theme's live demo (once it's fixed and accessible).
A link to the repository where your theme is hosted.

You can submit these links by opening an issue on this repository with the details. Once we have the working links, we will add them to our Community Themes section in the README so that other users can discover and enjoy your theme.
We are closing this PR for now. Please feel free to reopen an issue with the required links once your demo is live and accessible.
Best regards,
Harsh

Hey, I have recently updated the demo link:- https://akash-srinivasan.vercel.app/


knot-dns: 3.3.5 -> 3.3.6

https://gitlab.nic.cz/knot/knot-dns/-/releases/v3.3.6
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Some unrelated regression is blocking the tests 💢

Say, /cc @NickCao due to lots of comments on recent knot-dns updates.


Create StartTime class

A class that gets date information and is capable of converting it into a start time integer/long (e.g. for using in ResultParameters)

This should also be capable of retrieving the current date

Probably JodaTime might be good:
         DateTime dateTime = new DateTime(2017, 1, 16, 17, 0, DateTimeZone.UTC);         long millis = dateTime.getMillis();

could be done with a istats facade.


Add HAProxy Agent Check

http://cbonte.github.io/haproxy-dconv/1.8/configuration.html#5.2-agent-check

Add agent-check support
Update docs
Add sample agent-check server to appscode/test-server
Push test-server image: appscode/test-server:2.4
Add e2e test for agent-check
Add apache bench to travis.yml

Fixes #1196 #1210

Codecov Report

Merging #1395 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1395      +/-   ##
=========================================
- Coverage    3.74%   3.74%   -0.01%
=========================================
  Files          35      35
  Lines       18637   18639       +2
=========================================
  Hits          698     698
- Misses      17812   17814       +2
  Partials      127     127

Impacted Files
Coverage Δ

pkg/haproxy/api/types.go
11.11% <ø> (ø)
:arrow_up:

apis/voyager/v1beta1/annotations.go
29.79% <ø> (ø)
:arrow_up:

pkg/ingress/parser.go
3.5% <0%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e12f6b...db62da8. Read the comment docs.

Codecov Report

Merging #1395 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1395      +/-   ##
=========================================
- Coverage    3.74%   3.74%   -0.01%
=========================================
  Files          35      35
  Lines       18637   18639       +2
=========================================
  Hits          698     698
- Misses      17812   17814       +2
  Partials      127     127

Impacted Files
Coverage Δ

pkg/haproxy/api/types.go
11.11% <ø> (ø)
:arrow_up:

apis/voyager/v1beta1/annotations.go
29.79% <ø> (ø)
:arrow_up:

pkg/ingress/parser.go
3.5% <0%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e12f6b...db62da8. Read the comment docs.