Does not work w/ 2024-03, won't even compile - can we help somehow?

Is there anything we can do to help and make this work?
I have to use Kotlin now, had to test IntelliJ and am ... underwhelmed. Would prefer Eclipse.

Same here. I'm also confused what version to take. On the one hand the readme says on top "Kotlin for Eclipse 2020-09 and later", on the other hand there are recent versions below stopping at "Last version Kotlin for Eclipse 2023-09". Bold should indicate we use the first one? If so, maybe a sentence could help here or just dropping the ones below :)?

Hi! The same thing happened to me yesterday: I was sticking around with 2023-03 version of Eclipse IDE but then had to downgrade to 2021-03 (the version I use for older projects). Then, when I tried to write a simple HelloWorldKotlin application, following this  tutorial a nasty bug appeared after trying to run it:

Kotlin-Unable to find or load main class error ...

Though this tutorial has helped.
I'm not a big fan of ItelliJ Ideal (I've been using Eclipse IDE for a very long time and it is always a pain in the a.. to start with something new) but if I experience the same problems trying to couple a Kotlin project with Gradle in Eclipse I'll have to move over.

I have made some adaptations of Kotkin-eclipse for Eclipse IDE 2024-03. Please try to use this repository to update.
A little bit later changes will be moved to Eclipse marketplace

@bvfalcon Can we expect to see any improvements for this plug-in in the future, since it is very hindering to be bound to a certain IDE (I mean InteliJ IDEA) when coding Kotlin. For example a smoother Gradle integration would be nice. I have already a bunch of use-cases.

it is very hindering to be bound to a certain IDE (I mean InteliJ IDEA) when coding Kotlin

The same for me. I am using Eclipse IDE for many years and going to use it in future.

Can we expect to see any improvements for this plug-in in the future

For my aims is enough to adapt Kotlin-eclipse for latest versions of Eclipse IDE. But sometimes users make code donations with new functionality. I accept such changes too. It is excellent, that developers not only use plugin but improve it. So Open Source works and this is great.

a smoother Gradle integration would be nice. I have already a bunch of use-cases.

How you/your company are interested in this functionality? If your interest is serious, you would develop it or pay developers efforts. I will be glad to become your code donations.
In repository history you can find many commits of other developers, who makes their code donations to development of this plugin.

I have made some adaptations of Kotkin-eclipse for Eclipse IDE 2024-03. Please try to use this repository to update. A little bit later changes will be moved to Eclipse marketplace

Repo is not accepted by Eclipse -- disappears again right after adding.
Trying to access that link via browser results in downloading an empty file with a random name.

Hey, thanks for taking a look. I just updated to the given repository's version. For me nothing changed really :). Still errors around not supported when clauses. I could open now some .kt files without crashing though - let me try further.
In general I'm wondering how to add support for 1.9+ kotlin version. Is this something the plugin has "actively" to support or is it just providing are more uptodate kotlin jar with the plugin? What is stopping the plugin to support 1.9?


java.net.BindException: Permission denied

https://paste.ubuntu.com/p/7rdkhbDD2w/ (the last ~30 lines)
I edited the config so that web-address is set to http://localhost:80 and port is set to 80. I don't have any web servers running so port 80 should be free.
Port 80 is allowed in my firewall.
Not sure what else to try.

Only root-level services can open ports below 1024. You should make it listen to another higher port. If you want portless domain, you need to reverse proxy it to the desired port.

Ah alright, the wiki might benefit from that info as a note, as it says simply says the port can be assigned to 80

Ah alright, the wiki might benefit from that info as a note, as it says simply says the port can be assigned to 80

Agreed. Novice users might bump into this.
Search:
You can set it to port 80 if no other services are using it, which will allow users to use the map without specifying a port in the address bar.
Replace with something like:
If that is not an option you might be able to create a firewall rule that simply forwards all traffic hitting port 80 to 8080 on your machine.
If that is not an option either there is another non-option because it is actually a very, very bad idea since it tremendously increases security risks: So please DO NOT run your Minecraft server as root user! (no, seriously, don't do it!)

Best practice solution is setting up a reverse proxy.

Slightly updated the wiki to be a bit more clear.


remove unused robot_modules

not needed for new teleop implementation any more

is already merged....https://github.com/ipa320/cob_robots/commit/d95c5b55e7972749b70454ae5a23237cf89d6ee8

closing


Cannot search for non-ASCII text in non-UTF-8 coded project files

VSCode Version: Code 1.14.0 (b8cd5b9556d8b70ea560d35b903422363f6c5c40, 2017-07-10T18:36:31.751Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author (truncated)
Version

python
don
0.6.7

Steps to Reproduce:

Create text file in project folder with Windows-1251 encoding.
Fill out text file with sample content (russian+english): "тест test тест".
Save and close text file.
Invoke search in project (CTRL+Shift+F) with search string "тест".
Nothing found.
Invoke search in project (CTRL+Shift+F) with search string "test".
Text found, strange symbols in preview: link

Reproduces without extensions: Yes

Did you set the "files.encoding" setting? This is necessary for searching other encodings, since the tool we use for search doesn't support encoding autodetection.

Yes, with "files.encoding": "windows1251" I can search in windows1251 and utf8 files.
But project contains files with different character sets, and now, when I try to open utf8 file, it opens with windows1251 encoding, even with "files.autoGuessEncoding": true

@bpasero it seems that files.encoding takes precedence over files.autoGuessEncoding. I think it would make sense for files.encoding to be a fallback when the encoding can't be autoguessed, if that ever happens. It would also make this scenario easier, when a user wants to manipulate files.encoding for searching, while still using autoGuessEncoding in the editor. What do you think?

@roblourens sounds good in theory, however I think the encoding detection does not really tell you if it could detect an encoding or not. In other words, I think you will most often get an encoding "auto detected" even though it might not be the right one.
I wonder if for search we should not do the auto detection of encoding? Since it has lots of issues with wrongly detected encodings (see https://github.com/aadsm/jschardet/issues) maybe we should stay away from having it for search where basically each and every file's encoding is detected.
How is this setting supported with ripgrep anyways? I would assume that we can only detect the encoding if we are the ones doing the search, but not when going through ripgrep?

It's not supported at all for ripgrep, you have to tell it which encoding to search with, and it uses that encoding to interpret every file.
It looks like jschardet can return null? https://github.com/Microsoft/vscode/blob/master/src/vs/base/node/encoding.ts#L115 (but maybe it usually returns one anyway)

@roblourens ok then maybe I did not understand your comment https://github.com/Microsoft/vscode/issues/30583#issuecomment-315404980 fully, can you maybe explain what you mean?
In https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/files/node/fileService.ts#L614 you see that if the encoding is null we fallback to the configured encoding. So I would assume that we already do the fallback, at least if the guessing returns null.
As I said, I think in most cases JSChardet will actually return something.

I was trying the test that @dial8gue described, setting autoGuessEncoding and setting files.encoding to something. When I do that I open a typical UTF8 file and see that the encoding is set to the files.encoding value.
Debugging it, I see that it does detect 'ascii' or 'utf-8' but those detected encodings are ignored - https://github.com/microsoft/vscode/blob/master/src/vs/base/node/encoding.ts#L122 - so in that case it uses files.encoding instead. I guess this is by design then, but can you explain why it ignores those detected encodings?


gcp-connector-util list-printers command

Fixes #271

Could someone fix this PR. It would be nice to list printers.


VS Code cannot store keyring when keyring directory does not exist (in Chrome OS)

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.2
OS Version: Chrome OS Linux Terminal (Crostini) Debian GNU/Linux 11 (bullseye)

Steps to Reproduce:

Run VS Code.
Sign in with GitHub.
Close VS Code.
Run VS Code.
It ask me to sign in again.

Cause:
It is caused by the VS Code trying to create a keyring, but the directory to store the keyring does not exist yet.
My Solution:
I had to manually create the directory:
mkdir ~/.local/share/keyrings

Then the problem is solved.
However, I expect VS Code would create the directory for me if it does not exist.

We depend on https://github.com/atom/node-keytar for our keyring access. It provides a platform agnostic API so I would expect this library to create this directory. Can you get an issue going over there?


validation messages

How are the tv4 errorCode messaging supposed to work? The documentation doesn't help, would you be willing to add an example that uses the tv4 error codes?

Is it this section that you're wondering about? https://github.com/Textalk/angular-schema-form/blob/master/docs/index.md#validation-messages
I noticed it wasn't so straight forward when i tried to use it myself, so i'll update it now and it will be shipped with the next release.

I've expanded that section, you can check it out here for now. It may also change before it's in master but everything in there should work now. Hope that helps you!

:+1: This is exactly what I was looking for! Thanks @Dervisevic

@Dervisevic How do you provide tv4 to an angular application? I thought maybe it would be included in the schemaForm module.

Yeah it's included in schemaform. I just tried it myself, tv4 is available globally.

Sorry, had a derp moment!


Doom port

I've followed the FAQ section and copied the doom wad file to the roms/doom directory.
If I try to run the game from the doom section in the main menu, my rg351p goes back to the menu screen.
On the other hand, if I run the game from the ports section (where doom is supposed to be deprecated soon), it runs just fine

Have you updated ArkOS to the last 1/24 update?  Also did you change the default doom emulator?

Have you updated ArkOS to the last 1/24 update?  Also did you change the default doom emulator?

Yes, latest update. Tried both Retroarch and the standalone options. Today I reinstalled ArkOS from scratch, applied all the updates, redownloaded the doom wad file. Same. It works under ports, it doesn’t work under doom.

Yes, latest update. Tried both Retroarch and the standalone options. Today I reinstalled ArkOS from scratch, applied all the updates, redownloaded the doom wad file. Same. It works under ports, it doesn’t work under doom.

It sounds like it could be a problem with the doom.wad file you're using doesn't work with lzdoom.  For the ports section, it probably worked because the prboom.wad file is already included there.  Copy the prboom.wad file to the /roms/doom folder and set it to retroarch and it will work there too.  https://github.com/christianhaitian/arkos/wiki/ArkOS-Emulators-and-Ports-information#doom

It sounds like it could be a problem with the doom.wad file you're using doesn't work with lzdoom.  For the ports section, it probably worked because the prboom.wad file is already included there.  Copy the prboom.wad file to the /roms/doom folder and set it to retroarch and it will work there too.  https://github.com/christianhaitian/arkos/wiki/ArkOS-Emulators-and-Ports-information#doom

Nope, doesn't work :(
I've deleted everything in the roms/doom folder, downloaded the doom.wad file from the wiki link, then copied in the same folder.
I've set the emulator to Retroarch, from the edit metadata section.
By the way, is it supposed to work with Retroarch? Because the "auto" setting defaults to standalone

Nope, doesn't work :(
I've deleted everything in the roms/doom folder, downloaded the doom.wad file from the wiki link, then copied in the same folder.
I've set the emulator to Retroarch, from the edit metadata section.
By the way, is it supposed to work with Retroarch? Because the "auto" setting defaults to standalone

standalone is lzdoom emulator.  retroarch is the prboom emulator which is the same used in the ports section.  Did you make sure to have both the prboom.wad and doom.wad in the folder?

standalone is lzdoom emulator.  retroarch is the prboom emulator which is the same used in the ports section.  Did you make sure to have both the prboom.wad and doom.wad in the folder?

OK, I'm an idiot... I've copied Doom1.wad in the ports/doom directory but not in the roms/doom one... Sorry for taking your time.
Anyway, out of curiosity, now I see 2 entries in the Doom menu: Doom and prboom. Is it OK? Moreover, should I keep the doom wad file in the ports/doom folder as well?

OK, I'm an idiot... I've copied Doom1.wad in the ports/doom directory but not in the roms/doom one... Sorry for taking your time.
Anyway, out of curiosity, now I see 2 entries in the Doom menu: Doom and prboom. Is it OK? Moreover, should I keep the doom wad file in the ports/doom folder as well?

It's ok that they both show.  They will because of prboom needing prboom.wad.  If you don't plan to play prboom, you can delete it.  You can keep the doom wad in the ports doom folder but the next image release (which will be 1.6) will not have the doom ports section anymore.  Enjoy!

It's ok that they both show.  They will because of prboom needing prboom.wad.  If you don't plan to play prboom, you can delete it.  You can keep the doom wad in the ports doom folder but the next image release (which will be 1.6) will not have the doom ports section anymore.  Enjoy!

Sorry to bother you again, I have 2 more questions: if I want to play prboom should i copy the doom file in /usr/local/share/games/doom/ of the root partition as explained in the prboom website? what about ultimate doom? it appears in the ports list but I can't find any instructions in the wiki page

Sorry to bother you again, I have 2 more questions: if I want to play prboom should i copy the doom file in /usr/local/share/games/doom/ of the root partition as explained in the prboom website? what about ultimate doom? it appears in the ports list but I can't find any instructions in the wiki page

no.  Just copy the doom file to /roms/doom as explained in my wiki.  Same for ultimate doom.

no.  Just copy the doom file to /roms/doom as explained in my wiki.  Same for ultimate doom.

OK thanks, I will try

OK thanks, I will try


Smarter field qualifying algorithm

This PR implements smarter algorithm for field qualifier, discussed in #387.
New algorithm tries all struct type/field names, recursively for nested structs. Additional syntax for named extends (xorm:"extends(name)") is not implemented yet.
Two related PRs:

go-xorm/core#14
go-xorm/tests#13 (much more extends tests for various tricky cases)

I think there are still many situation cannot be resolved. statement.tableMap        map[string][]string maybe should be tableMap       [][]string. And the sequence should be the same as Join sequence. So that it's easy to column to find there table name or alias name.

statement.tableMap map[string][]string maybe should be tableMap [][]string

I don't quite understand how should we use it. Could you clarify?
Currently, this PR introduces the following behaviour:

if table name can be deduced unambiguously for all fields, use qualified fields
otherwise, if table name can't be deduced unambiguously at least for one field, emit warning and fallback to SELECT *

See isKnownUnambiguousTable().
In other words, new behaviour (qualified fields) is enabled only when we're quite sure that this will not break old code that relied on ambiguous fields.

I think there are still many situation cannot be resolved.

What are those situations? Let me know, I'll add tests for them :)


lottie-react-native closes when I run my application

Bug in open my app with lottie-react-native and expo
[Description of the bug]
Steps to Reproduce
Every time I try to get the animation to run my app it stops and closes.

Yeah it happends to me only on Android. IOS works great.
https://docs.expo.io/versions/latest/sdk/lottie/#known-issues

Importing Lottie 3 files causes the previewer to crash without a visible error, because Expo relies on lottie-react-native v2.

I also had the same problem in react-native, I followed all the steps in the documentation and to my surprise the problem was the .json file.
Try using a different .json.

I also had the same problem in react-native, I followed all the steps in the documentation and to my surprise the problem was the .json file.
Try using a different .json.

@jhsonmac, so you make it works?
What did you do with your .json?
How you generate it?
In my case the .json file are generated by After effect.

@t1gu1 I still haven't managed to generate a file through afterEffect that works unfortunately.
I have tried it in different versions, but error persists. The only case I was able to use was not placing assets, just animated text. Test with animated text only without assets.

I'm having the same problem no matter what .json I use the app keeps crashing when I try to run Lottie


fix: notify autoscaled pool about newly added requests

Notify AutoscaledPool when calling crawler.addRequests(). This is important for crawlers in keepAlive mode that might have an empty queue and we don't want to wait till the next scheduled check (which might come in as much as 500ms by default).
Related: https://apify.slack.com/archives/CD0SF6KD4/p1711660060498849

I actually had it like that initially, then I started writing the jsdoc, and I realized that the method will be called automatically from inside crawler.addRequests, so it's not really important for users. What other use cases would there be?

I guess for now there isn't any I can think off the top of my head, maybe in the future when we make DB storages too and people manually alter DBs we can provide it (if needed)

I actually had it like that initially, then I started writing the jsdoc, and I realized that the method will be called automatically from inside crawler.addRequests, so it's not really important for users. What other use cases would there be?

If AutoscaledPool allows notifying it from the outside, it should be a part of its public API - calling a protected method from elsewhere seems like unnecessary smoke and mirrors. If anyone wants to use AutoscaledPool (I don't think many people do that), they should be able to handle the truth.

If AutoscaledPool allows notifying it from the outside, it should be a part of its public API - calling a protected method from elsewhere seems like unnecessary smoke and mirrors.

I was afraid of this academic debate... :] You could say this about every single quirk we have in the code base (and there are many, including the autoscaled pool class itself, welcome to javascript :D).
Will add the public method, as I don't feel like arguing about such a small change. But I will be very surprised if anyone ever uses this method :]

I was afraid of this academic debate... :] You could say this about every single quirk we have in the code base (and there are many, including the autoscaled pool class itself, welcome to javascript :D).

Oh yes, yes I will.


Added new struct and field in preparation for using blob_gas

This change is

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8256040) 70.83% compared to head (d31eed9) 70.75%.
Report is 1 commits behind head on main.

Files
Patch %
Lines

crates/blockifier/src/fee/fee_utils.rs
0.00%
7 Missing :warning:

crates/blockifier/src/transaction/objects.rs
0.00%
4 Missing :warning:

crates/blockifier/src/fee/gas_usage.rs
93.75%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
- Coverage   70.83%   70.75%   -0.09%
==========================================
  Files          59       59
  Lines        7550     7570      +20
  Branches     7550     7570      +20
==========================================
+ Hits         5348     5356       +8
- Misses       1779     1790      +11
- Partials      423      424       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PTAL.

crates/blockifier/src/abi/constants.rs line 35 at r6 (raw file):
Previously, dorimedini-starkware wrote…
where in the code is this constant used for insertion?

In the next PR, this one is only preparation for it.
https://reviewable.io/reviews/starkware-libs/blockifier/1357


[flutter_tools] do not use context logger in gradle

Part 2 of 999 to clean up gradle.dart . move the logger into the class definition and remove context usage. Also removes sha analytics event that has not been useful (its always pretty fast 🤷🏻♂ ).

Part of https://github.com/flutter/flutter/issues/71511


Ket 1.7.0

We need to upgrade to using Calico 2.6.5 instead of 2.6.4 for this release, see here.

Is there anything to review here, or is this for running tests?

Let's use this branch to fix any errors that come up during integration tests.


Minor improvements and update dependencies

Codecov Report
Patch has no changes to coverable lines.
:loudspeaker: Thoughts on this report? Let us know!.


What kind of facial features does origin face_features.npz have?

face_features.npz have the features that have been extracted through Insightface model. You can read more in https://github.com/deepinsight/insightface

@vectornguyen76
Oh, thank you. By the way, is it better to overwrite the existing face_features.npz when registering custom face feature?

face_features.npz stores the features of the faces and it is independent of each other. You can add or overwrite as you like.

@vectornguyen76
Thank you for the answer. Then I don't need it if I don't use the existing faces saved in the features in the recognition?

Yep, this is a sample I created to test recognition.

@vectornguyen76
When I tested it, the FPS speed is affected by the recognition model backbone rather than the query_embed size

Yes, if you want to improve FPS, converting to onx model is also a way.


Using a custom DB engine with DatabaseURL

Is there anyway to specify the DB engine to use when using DatabaseURL?
The use case I have is a non-standard DB engine, namely django-timescaledb.
But, using DatabaseURL with this will default to the "django.db.backends.postgresql" engine, however, it looks like dj-database-url allows this to be overridden with the engine parameter. However this isn't surfaced within django-configurations from what I can tell?
Has anyone come across this use case before? Is there currently a good solution or am I missing something?

Hi,
I have submitted a PR regarding this and I will continue the work in this project as well.
https://github.com/jazzband/dj-database-url/pull/174

@lino - Awesome, thank you 👍

And the Pull request was just merged.


GYM: Schemes?

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
It should be noted that I'm running fastlane inside of Bitrise.io. For the most part, fastlane is working perfectly. It works as expected on my local machine but breaks on Bitrise.
-s, --scheme STRING  The project's scheme. Make sure it's marked as `Shared` (GYM_SCHEME)

Running gym -h says that schemes need to be shared, what is meant by this? This comment says that schemes should be added to my repo but I do not know how to do this. Any ideas?
You can see the specific part of the error in the output below.
Complete output when running fastlane, including the stack trace and command used
[07:45:32]: All required keys, certificates and provisioning profiles are installed 🙌
[07:45:32]: Setting Provisioning Profile type to 'app-store'
[07:45:32]: -----------------
[07:45:32]: --- Step: gym ---
[07:45:32]: -----------------
[07:45:32]: Using legacy build system - waiting for radar to be fixed: https://openradar.appspot.com/radar?id=4952000420642816
[07:45:32]: xcodebuild -list -project platforms/ios/Data\ Capture.xcodeproj
[07:45:42]: Variable Dump:
[07:45:42]: {:PLATFORM_NAME=>:ios, :LANE_NAME=>"ios appaloosa", :SIGH_PROFILE_TYPE=>"app-store"}
[07:45:42]: xcodebuild -list timed-out after 10 seconds. You might need to recreate the user schemes. You can override the timeout value with the environment variable FASTLANE_XCODE_LIST_TIMEOUT

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "1.101.0"

before_all do
  ENV["SLACK_URL"] = "https://hooks.slack.com/services/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"
  slack(
    message: "build started!"
  )
end

platform :ios do

  desc "Create an IPA"
  lane :appaloosa do
    match(type: "appstore")
    # snapshot
    gym # Build your app - more options available
    # deliver(force: true)
    # frameit
  end

  # You can define as many lanes as you want

  after_all do |lane|
    # This block is called, only if the executed lane was successful

    slack(
      message: "successfully built!"
    )
  end

  error do |lane, exception|
    slack(
      message: exception.message,
      success: false
    )
  end
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md

# fastlane reports which actions are used
# No personal data is recorded. Learn more at https://github.com/fastlane/enhancer

Gymfile:
# For more information about this configuration visit
# https://github.com/fastlane/fastlane/tree/master/gym#gymfile

# In general, you can use the options available
# gym --help
scheme "My App"
sdk "iphoneos"
output_directory "./builds"
output_name "Data Capture"
project "platforms/ios/My App.xcodeproj"
use_legacy_build_api "true"

Environment
fastlane version (run fastlane -v): fastlane 1.101.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? No

You can set your schemes to shared in the Xcode UI: https://developer.apple.com/library/mac/recipes/xcode_help-scheme_editor/Articles/SchemeShare.html

Thanks @neonichu, this looks good

@neonichu Thanks so much for stepping in here! Really appreciate it. 👍 💯 💯


Non breaking: Separate the GetForecast call to two functions

Non breaking: Separate the GetForecast call to two functions - get response with model as json and deserialize json into model.
@amweiss - this change was led because I wanted to access the raw json returned rather than object model (I'm going to parse the json via jsonpath to build out some simple key-value-pairs ready for UI use, but in an extensible way). No stress if you don't like this!
Many thanks for the work done to create the library.

Hmm, so two things - I left 1 line of code in that I didn't mean to
(darkSkyResponse.Response = JsonConvert.DeserializeObject(.... within the inner function that should have just been about the http call.
And the unit tests are failing though working locally (lol, how often is that said!)
Fee free to reject the pull-request.

@mrgfisher it looks like there was a legitimate error with the tests but perhaps from an empty response from DarkSky. Either way, it should prevent an exception from being thrown like it is. I would also move the test you added to a unit test since it doesn't actually need to call out to DarkSky and can use one of the saved responses.
Additionally, is the idea to use jsonpath instead of LINQ? Or are you trying to send the entire response back to the UI and then deal with it client side? If you can get it updated and the test moved I would be ok merging it, but I don't quite see the benefit.


Dropdown misaligned when dropdownParent has a border

When the dropdownParent option is set and the dropdownParent has a border, the dropdown is misaligned.
https://jsbin.com/moxivef/edit?html,js,output
Removing the border on the dropdownParent fixes the issue.

I have reduced this down to what is probably the minimal test case of this.
https://jsbin.com/zowuyodaca/1/edit?html,css,js,output
The issue specifically happens when position: absolute is used with border-top on the parent container. It also probably happens when dropping up and border-bottom is used.


rename file to .yml to prevent confusion with example start scripts

what it says on the tin..

addresses #57


types(runtime-core): use union type feature for avoiding duplicate code

Use union type

Thanks but this doesn't seem necessary.


Don't retains member slots on nodes with nofailover tag

Followup on #3142

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.874%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
14318

Relevant Lines:
14336

💛  - Coveralls

can we also adjust this docstring here?
https://github.com/patroni/patroni/blob/b31198bb8ff9dba7a7798d4c7378a27141fc06f7/patroni/dcs/__init__.py#L1121-L1124


How to implement multiple object selection and manipulation?

Hi first I want to thank Cedric for implementing a gizmo for ImGui. Now that I know how some of the code works I am having a hardl time implementing multiple selection and manipulation using the well known EditTransform function in this ImGuizmo's Home page.
Any help and guidance is greatly appreciated.

Imguizmo is made so you can edit one matrix at a time. If you have multiple objects and have selection enabled in your program, then just use the matrix from your selected object. Maybe I missed something in your question :)


Recolor Nest Hub icon

Requirements

[ ] Create new icon.
[ ] Color icon in HA.

It might be worth exploring what I'm looking to accomplish with this button and it's associated controls. The value of this button has greatly decreased since #394.

#659 + #671 makes this ticket irrelevant.


BioSignal-Recorder 0.2

Reimplement frontend using Chart.js

I'm working on improving sampling rate of esp32.

@Asc91 can you please push your recent updates here as well?

@Asc91 Please share images of how it looks right now and provide a detailed list of things already implemented.

Char.js Implementation: Reimplemented previous version of BioSignal-Recorder using Chart.js , which will make future development bit easier.
Multi-channel support: ESP32 has 4 hardware timers which are currently being used for sampling data according to provided sampling rate. User can choose number of channels to use. Graph of all channels is currently shown on same canvas maybe separate canvases should be used.
Variable Sampling rate:  Multiple options for sampling rate are given from 100Hz to 5000Hz. Every channel can be set with different sampling rate. Maybe user input should be taken for sampling rate than just providing some options.
Save as CSV: Data can be saved as a CSV file and downloaded on computer.  CSV file contains data with timestamp, channel number and packet number of corresponding channel.


Jacoco integration

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b87063f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   83.37%
  Complexity        ?      141
=========================================
  Files             ?       27
  Lines             ?      433
  Branches          ?       59
=========================================
  Hits              ?      361
  Misses            ?       54
  Partials          ?       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87063f...a9be1b0. Read the comment docs.


Issue 160 erc 721 modules

Fixes #160

Hi Isaac 👋 ,
I've talked to Austin and he told me that he'd like this PR to be in a separate branch from master, as he'd like to demo it to Opensea first. I hence took the freedom to switch the base of this PR to the opensea branch. I'll also review it.

Hi Isaac  ,
I've talked to Austin and he told me that he'd like this PR to be in a separate branch from master, as he'd like to demo it to Opensea first. I hence took the freedom to switch the base of this PR to the opensea branch. I'll also review it.

Cool. Thanks for reaching out. Let me know if I need to make some changes.

 In general though, I'd say we're aiming for a tighter integration of NFTs into the burner.

Querying opensea.io is a good first step
In the issue I commented that also the npm module "erc721-balance" could be used for querying. It'd be more permission-less and in most cases it wouldn't come at a UX cost in terms of querying-delays. Thoughts?
I wonder if we could simply edit Badge.js and Badges.js to work with any ERC721. I know this is different from what the gitcoin issue said. So I'm happy to conform with what was originally proposed! Just a suggestion.
I'd be in favor of displaying NFTs on the "main" view and not in an extra view.

Would be good if @austintgriffith could give his thoughts on this too.

Hey, the erc721-balance package does not support that. As such, I have to use the opensea api to fetch it. See https://github.com/vrde/erc721-balance/issues/3#issuecomment-502451309

I updated the PR here #230

I updated the PR here #230

OK, I closed this issue (#186) in favor of #230. If that's not correct, please let me know.


KYLIN-4399 Redirect http url is not override as https when using vip

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Pull Request Test Coverage Report for Build 5854

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.001%) to 27.467%

Files with Coverage Reduction
New Missed Lines
%

server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java
1
47.62%

Totals

Change from base Build 5853:
0.001%

Covered Lines:
24317

Relevant Lines:
88532

💛  - Coveralls


Add hours in admin ui

be able to set hours for employees in order to pay
then have the appropriate amount withdrawn from store balance

20 min


Type debug

Add decorator to print the types of parameters passed to a function at runtime. This can be helpful in debugging and adding or fixing mypy annotations.

Automated message from Dropbox CLA bot
@sharmaeklavya2, it looks like you've already signed the Dropbox CLA. Thanks!

Haven't finished reviewing it the documentation commit, I think we should put a usage example in a code block (with output), just to show what it looks like.
Also, do you think we should have an automated test suite for that feature?  Would need to do some thinking to avoid it being spammy (maybe by using the logging module rather than print() and then we can just mock logging in the tests)

I'm new to logging (I read about it today) so I don't know what's the best way to use it here. Can you please suggest something?
Here are some ways I use print_types which will be helpful in deciding how to use it with logging:

I sometimes want to see print_types's output in stdout because that helps me find out when functions are called. For example, it tells me from which tests a function is called from when running backend tests.
Sometimes I don't want to print that information to stdout. I then redirect it to a file, like var/type_output.txt. Then I run sort -u var/type_output.txt > var/sorted_type_output.txt. sort -u sorts the lines in a file and removes duplicate lines. This is helpful when a function is called many times but I only want to see the distinct ways in which it is called.

Wait.

Yeah, with logging, I'd just do
import logging
logging.info("message")

It's pretty similar to print, but includes a timestamp, and you can set at in your program/file a log level (debug, info, warning, etc.), and only logging.foo() things where foo is at least the overall log level will actually be printed.  It's a very popular way to do logging in production environments, and the usual way one would implement --version options nicely in Python programs.
Thinking about this more, I'm not sure it's a great fit for this application.  Really, what we want to do is use print() and mock that for the tests (e.g. with mock.patch(print ...), which might actually work, since print is a function in our project.

So I shouldn't use logging here, right?

Yeah, let's try just using print and mocking that for the tests

I have added an example in the docs. Are there any more improvements I should make (apart from writing tests)?

Nope, otherwise looks good!

I have added documentation about how lists and dicts are printed.

@timabbott I have written the tests. Please have a look and give me feedback.

Awesome, this looks great!  I merged this, after making a small tweak to the docs (s/wrong types are passed/parameters with the wrong types are passed/).  Thanks @sharmaeklavya2!

A good thing about the tests is that we can run them like this:
python -m unittest zerver.tests.test_type_debug

which is much faster than running them using tools/test-backend.

Cool, good to know.  (Also, we do need to fix the test-backend startup overhead; I think Tomasz is working on #1221).


Disallow CORS to be configured on anything but ThirdParty server

Allowing CORS config on other types of server such as P2P carry potential security issues

Codecov Report

Merging #917 into master will increase coverage by 0.05%.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##             master     #917      +/-   ##
============================================
+ Coverage     99.37%   99.42%   +0.05%
- Complexity     2093     2094       +1
============================================
  Files           318      318
  Lines          5761     5768       +7
  Branches        308      306       -2
============================================
+ Hits           5725     5735      +10
  Misses            5        5
+ Partials         31       28       -3

Impacted Files
Coverage Δ
Complexity Δ

...sera/config/constraints/ServerConfigValidator.java
95.83% <94.11%> (-4.17%)
6 <4> (+1)

.../tessera/admin/cli/subcommands/AddPeerCommand.java
100% <0%> (+2.63%)
11% <0%> (ø)
:arrow_down:

.../quorum/tessera/sync/SyncResponseMessageCodec.java
100% <0%> (+3.22%)
5% <0%> (ø)
:arrow_down:

...ain/java/com/quorum/tessera/p2p/RestP2pClient.java
100% <0%> (+6.89%)
9% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76c789...bb13808. Read the comment docs.


obsolete glial cell (sensu Nematoda and Protostomia) and glial cell (…

…sensu Vertebrata)
closes #715

This seems to have resulted in some glial cell types floating to the top.

I'll hot fix on master.
I thought we had a test for that  @matentzn ?  GuessI should always check branch in Protege before merging.

No for this case, there was no test; but I think it is a great idea. Would you say the test is best described as: no class in the cl namespace other than the root can have less than one superclass?

no class in the cl namespace other than the root can have less than one superclass?

Sounds good.

can we not generalize this? Every ontology could define expected roots with
a standardized AP. This would be useful other places, e.g. OLS; An option
in Protege to open-to-roots or center-to-roots. ROBOT can also use this in
checks. It can also be used to check nothing goes wrong in making the
import as it often does
On Sun, Sep 27, 2020 at 3:47 AM David Osumi-Sutherland <
<EMAIL_ADDRESS>wrote:

no class in the cl namespace other than the root can have less than one
superclass?
Sounds good.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/obophenotype/cell-ontology/pull/725#issuecomment-699618665,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMMOO4B325NFOBFW2ORFTSH4J5VANCNFSM4RN25XDQ
.

We already have that rolled out widely: IAO:0000700
We could generally check that classes in the base namespace must be under a preferred root class.


AQCU-827: Fixed a small typo that was casuing the Uncorrected TS to occasionally go off the chart.

if all tests pass, i agree, go ahead and merge!

Coverage remained the same at 88.3% when pulling c55e340dc0ec9740b45badef40ed87e00595d376 on zmoore-usgs:bug/scale-fix into eb544952ec18af7ddacb49b964a7783248413307 on USGS-R:master.


feat(Notification Services): Pass getExtendedConfig currently to support custom notification services

Instead of what we are doing here, we can extend the existing config in withConfig as well i.e. by doing something like
{ config: { ...config, ...extendedConfig } } there.
Need suggestions.


BeamNG Connection disconnects

When I try to connect to beamNG research, it connects for first time and then disconnect
here is the log
029.612|I|libbeamng.lua.V.ResearchVE|Trying to connect to: localhost:64257
031.627|I|libbeamng.lua.V.ResearchVE|Connected!
031.630|I|GELua.util_researchGE.ResearchGE|Setting engine flags!
031.662|D|GELua.scenario_scenarios.scenarios|changeState: running
031.663|D|GELua.core_camera.|Camera switched to "orbit"
031.712|E|GELua.core_levels.levels|info.json missing: /levels/garage/info.json
031.713|E|GELua.core_levels.levels|No entry point for level found: /levels/garage. Ignoring level.
031.714|E|GELua.core_levels.levels|info.json missing: /levels/GridMap/info.json
031.715|E|GELua.core_levels.levels|No entry point for level found: /levels/GridMap. Ignoring level.
031.819|E|GELua.ResearchCom|Error reading from socket: closed
031.874|E|libbeamng.lua.V.ResearchCom|Error reading from socket: closed

Solved it using windows powershell


incompatible ：delete deprecated struct

Coverage decreased (-0.2%) to 65.207% when pulling d90943b48d66a8749108dfff48aaf9686ffd2c2f on tianxiaoliang:master into 0f37ad3d79e574e35187faf5c5ade558e8cf4cc8 on go-chassis:master.


[02] Refactoring UI Code

Title
Second PR Series on UI Refactoring.
Type of Change

[x] New feature
[ ] Bug fix
[ ] Documentation update
[x] Refactoring
[ ] Hotfix
[ ] Security patch
[x] UI/UX improvement

Description
Implements the Default Theming Idea I had when I opened issue #2226, and although I must say that this PR is alot smaller in code changes / Impact on End User.. but I do think it something overlooked, and can be improved.
Testing
It compiles & runs successfully, and the theming looks correct.
Impact
End user won't feel any difference, but when adding or updating theming options across different themes.. this can be done with ease by simply changing the _default theme.
Additional Information
I haven't tested startup time difference before & after changes, but due to the increased error checking & other changes as well.. I won't be surprised if it's increased by a small margin.
Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech If you want to change anything, or wanna resolve merge conflicts, you can do so 👍

Please see the attached error when clicking the About button to see the about info.


how to get new lines in tweets from twint

Issue Template
Please use this template!
Initial Check

If the issue is a request please specify that it is a request in the title (Example: [REQUEST] more features). If this is a question regarding 'twint' please specify that it's a question in the title (Example: [QUESTION] What is x?). Please only submit issues related to 'twint'. Thanks.

Make sure you've checked the following:

[] Python version is 3.6;
[] Updated Twint with pip3 install --user --upgrade -e git+https://github.com/twintproject/twint.git@origin/master#egg=twint;
[] I have searched the issues and there are no duplicates of this issue/question/request.

Command Ran

Please provide the exact command ran including the username/search/code so I may reproduce the issue.

Description of Issue

Please use as much detail as possible.

Environment Details

Using Windows, Linux? What OS version? Running this in Anaconda? Jupyter Notebook? Terminal?

I want to split the tweet at New line. There's no identifier available in the scraped tweet. How could I customize to fetch it?
Thanks.


SP Extension: F-strings

will translate into an FormatEx call.
f"{2 * 37}"
'74'

def to_lowercase(input):
    return input.lower()

name = "Eric Idle"
f"{to_lowercase(name)} is funny."
'eric idle is funny.'

f"{name.lower()} is funny."

char buffer[256];
float money = 2.0;
buffer = f"You have ${.2:money}";
buffer == "You have $2.00"

// equivalent:
char buffer[256];
float money = 2.0;
FormatEx(buffer, sizeof(buffer), "You have $%.2f", money);
buffer == "You have $2.00"

This is put on hold for now as this feature requires doing type-checking.


is not in a section

Please migrate to opendiffy and file an issue there if the problem persists.


large schema filesize will error out as getconf ARG_MAX 1048576

Bug description
I am using a large prisma file(500 models approximately) for development and I am unable to do the introspection. It is throwing error with arg too long.
{"level":"error","time":1685103624369,"pid":2253,"hostname":"9477e6c110a5","component":"@wundergraph/sdk","msg":"database introspection failed: Error: Command failed with exit code 1: /app/wundergraph-sample/node_modules/@wundergraph/wunderctl/download/wunderctl introspect prisma prisma/schema.prisma --outfile=generated/introspection/database/1574e0d9ea6c0dbcd2c502ec7d4961f67fd31.json --debug --wundergraph-dir /app/wundergraph-sample/src --cli-log-level info --pretty-logging=false\nError: fork/exec /root/.cache/wundergraph/prisma/efdf9b1183dddfd4258cd181a72125755215ab7b/prisma-query-engine-debian-openssl-1.1.x: argument list too long\n{\"level\":\"debug\",\"time\":1685103624353,\"caller\":\"commands/root.go:93\",\"msg\":\"starting without env file\",\"hostname\":\"9477e6c110a5\",\"pid\":2331,\"component\":\"@wundergraph/wunderctl\"}"}
How to reproduce

create new nextjs-postgres-prisma example
Add Database URL
Add as many Models as possible.
Run ''yarn wunderctl up --debug''
See error:
Error: fork/exec /root/.cache/wundergraph/prisma/efdf9b1183dddfd4258cd181a72125755215ab7b/prisma-query-engine-debian-openssl-1.1.x: argument list too long\n{\"level\":\"debug\",\"time\":1685103624353,\"caller\":\"commands/root.go:93\",\"msg\":\"starting without env file\",\"hostname\":\"9477e6c110a5\",\"pid\":2331,\"component\":\"@wundergraph/wunderctl\"}
File:
schema.zip

Expected behavior
{"level":"info","time":1685345418235,"pid":162,"hostname":"df8a84785b33","component":"@wundergraph/sdk","msg":"Build completed."}
WunderGraph information
wundergraph.config.ts file
import {introspect, configureWunderGraphApplication, Api} from '@wundergraph/sdk';

const api = introspect.prisma({
    apiNamespace: "tenantName",
    prismaFilePath: "./prisma/schema.prisma",
    introspection: {
        disableCache: true,
    },
});

configureWunderGraphApplication({
    // compose the APIs into a unified WunderGraph API
    apis: [api],
    security: {
        enableGraphQLEndpoint: true,
      }
  });

Environment & setup

OS: Ubuntu 20.04.5 LTS
Go version: 1.18
Database: PostgreSQL 15
Node.js version: v18.15.0

WunderCtl Version
Version: 0.138.0
Commit: c1286a7a51dbceb263e6b17f00a180a3b3e9d7e2
Date: 2023-04-04T12:04:53Z
BuiltBy: ci

Can you provide the schema to be able to reproduce the issue?

The problem is basically coming from https://github.com/wundergraph/wundergraph/blob/7977c79dc5dc9484c2412622828ac3a1380422fd/pkg/datasources/database/engine.go#L278
The whole schema is loaded to an environment variable here which is causing the issue.
As a workaround we are storing the large schema to a temporary file and passing the file as argument to prisma
func (e *Engine) StartQueryEngine(schemaFilePath string) error {

	err := e.ensurePrisma()
	if err != nil {
		return err
	}

	freePort, err := freeport.GetFreePort()
	if err != nil {
		return err
	}
	port := strconv.Itoa(freePort)
	ctx, cancel := context.WithCancel(context.Background())
	e.cancel = cancel
	e.cmd = exec.CommandContext(ctx, e.queryEnginePath, "-p", port, "--enable-raw-queries")

	// ensure that prisma starts with the dir set to the .wundergraph directory
	e.cmd.Dir = e.wundergraphDir

	e.cmd.Env = append(e.cmd.Env, os.Environ()...)

	// replace PRISMA_DML with PRISMA_DML_PATH
	if schemaFilePath != "" {
		e.cmd.Env = append(e.cmd.Env, "PRISMA_DML_PATH="+schemaFilePath)
	}

	e.cmd.Stdout = os.Stdout
	e.cmd.Stderr = os.Stderr
	e.url = "http://localhost:" + port
	if err := e.cmd.Start(); err != nil {
		e.StopQueryEngine()
		return err
	}
	return nil
}

Although its slightly twisted since the introspect method interface is expecting a schema and  with this introspection in prisma will happen like
introspectprismaFile(input: file) -> instrospect(input: prismaSchema) -> instrospectDatabase(prismaSchema > tmpFile);
We are basically rewriting the inputfile here.
large.txt

Hi @jensneuse , Please the below attached schema.
schema.zip

@Slickstef11 I think this one has already been fixed in #1012?

Fixed by  #1012


Fix the issue where album assets cannot be retrieved when selecting only and video or only and image conditions

Fix the issue where album assets cannot be retrieved when selecting only and video or only and image
https://github.com/fluttercandies/flutter_photo_manager/issues/1230#issue-2685220253

Could you provide screen recordings with the issue happen and after applied the fix?

Uploading meeting_1.mp4…


HSEARCH-1845 Upgrade to Pax Exam 4.4.0 to improve port allocation during...

... tests

https://hibernate.atlassian.net/browse/HSEARCH-1845

Merged https://github.com/hibernate/hibernate-search/pull/808


Shortcuts for subtasks not working

Hi there, thanks for the great extension once again.
I've noticed that after the recent task view UI upgrade the subtask shortcuts are not working. Steps to reproduce:

Open any task
Try to manipulate subtasks with any shortcuts: q, a, A are not working, as well as 1-4, etc...

Do you think it could be possible to fix this, at least for adding and deleting subtasks? That would be awesome!

Version 149 fixes most task view shortcuts (may only work for english version of todoist..)
I do not plan to add bindings for subtasks other than adding them (see #188 and #94)

Hi @mgsloan , thanks for a rapid follow-up on this.
I've updated to v149 and tested sub-tasks once again: sadly, they still don't work. For example, pressing "a" / "A" / "q" on English version of Todoist new task view just opens labels for a given task, instead of creating new subtasks. Is that intended behaviour and was not covered by the fix?

PS: pressing "e" or "#" in the task view opens "More actions" menu, instead of deleting a selected sub-task.

Thanks for following up on this @antois I've fixed the issue with adding tasks in task view when there are already subtasks

@mgsloan thank you for the fix and for your work on the extension overall, it really helps


Deprecation warning in logs

Hello, in my system logs, I have the following deprecation warning:
This error originated from a custom integration.

Logger: vivintpy.utils
Source: custom_components/vivint/alarm_control_panel.py:60
Integration: Vivint (documentation, issues)
First occurred: 8:21:14 PM (41 occurrences)
Last logged: 9:46:14 PM

method get_armed_state has been deprecated in favor of property state, the alias will be removed in the future

Figured I should let you know

Resolved in 2022.12.3

@natekspencer it looks like you accidentally tagged that as 2021 instead of 2022 so HACS isn't offering it as an update because the version number appears to be older

@natekspencer it looks like you accidentally tagged that as 2021 instead of 2022 so HACS isn't offering it as an update because the version number appears to be older

🤦🏻♂
Try again now


Recognizes controller in left panel, but buttons do nothing.

Enjoy 2 recognizes my controller in the left panel, but pressing buttons on the controllers does nothing.  If I map the keys by hand, those buttons still do nothing.  Tested with Start on and off.
I'm on OSX 10.9.5 and I've tested this with both a Logitch Rumblepad 2, and a cheap-generic wired ps3 controller that shows up as "2in 1 USB Joystick".

I have the same issue. I tried it with an original WiiRemote. The device is there but pressing buttons do nothing. Any idea what to check? OS X v10.13.1.

Based on this blog article: https://davidwalsh.name/play-wii-games-mac and installing the latest foodhid (OSX IOKit driver, https://github.com/unbit/foohid) and the latest WJoy (Nintendo Wiimote driver, https://github.com/tapesonthefloor/wjoy-foohid), everything works again. I'm still on OS X v10.13.1.


Parameters for more subtle output effect

Just wondering if there are any parameters I can play with to get a slightly less intense brushy & flat effect? The examples look a bit more realistic and have more depth, if that makes any sense? (bicubic on the left and the Large RDN noise cancelling, detail enhancing model on the right)

This is an effect of the noise cancelling model we provide, there is a few things you could do:

re-train the current model, with some data that is similar to the images you want to upscale (maybe the images themselves?)
take two or more model that do different things and merge the weights (seems like a feature to add asap)
or just use the gans-RRDN model if you don't need to remove jpeg artifacts

Ahh cool, thanks @cfrancesco I'll let you know how I get on :)

Yeah I ran it through a combination of the noise cancelling and non noise cancelling models which gave a better result, would be cool to merge the weights!


Avoid monkey patching JSON module

Pull Request Checklist

Description

Avoid monkey patching the JSON module.
Related Issue

Fixes #24

I did some tests and can confirm that this fixes the issue. Can you merge + release it?

Thanks @bastelfreak
Released in v3.4.1


toDataFile should be implicit in Input

DataFileTimestamped is a different case class from DataFile, with .toDataFile doing the conversion, but it would be better if this was done implicitly.

Also, DataFileTimestamped should be in the Maestro api.


DataQueryTest::column does not respect sorting by surrogate fields

This is a failing test for #8926
Should not be merged before 8926 gets a fix
Here's the result of the test execution:
$ ./vendor/bin/phpunit --testsuite core --filter DataQueryTest::testSurrogateFieldSort
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

F                                                                   1 / 1 (100%)

Time: 5.43 seconds, Memory: 211.75MB

There was 1 failure:

1) SilverStripe\ORM\Tests\DataQueryTest::testSurrogateFieldSort
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'Second'
-    1 => 'First'
+    0 => 'First'
+    1 => 'Second'
     2 => 'Last'
 )

/home/vagrant/bench/893-44/vendor/silverstripe/framework/tests/php/ORM/DataQueryTest.php:285
/home/vagrant/bench/893-44/vendor/phpunit/phpunit/phpunit:52

FAILURES!
Tests: 1, Assertions: 1, Failures: 1.

@dnsl48 Were you still planning on progressing this one further?  If not we can just close this if you prefer.

It's been patched through https://github.com/silverstripe/silverstripe-framework/pull/8974


Dont check for version when upgrading

https://github.com/rancher/k3s/issues/1299
https://github.com/rancher/k3s/issues/1602
Fix upgrades by removing the version check for existing charts to be able to handle both scenraios:
1- version changed in the helm chart
2- only settings changed in the helm chart

Same issue here !
I would need both changes included here (helm for all-namespaces and with updates).

@galal-hussein : On line 37, you miss the<EMAIL_ADDRESS>

@galal-hussein : On line 37, you miss the<EMAIL_ADDRESS>
The controller always run with install to the klipper, so there is no need to include $@ here

The controller always run with install to the klipper, so there is no need to include $@ here

"set" vars are passed as arguments. "shift" remove install.


FR API: BR_GetArrangeView for midi editor

I got a request to do Ableton-like behaviour for grid (depending on zoom).
So, is it possible to get start/end time of midi editor visibility?

It's all in active take's chunk but it's not straight forward because it depends on MIDI editor timebase (ppq vs seconds) and I think you actually don't have start/end point but start point and zoom level from which you have to derive it.
Honestly, I would love to see more native API exposure in regards to MIDI editor because a lot of this kind of stuff should be trivial but in the end it turns out not as simple due to all the MIDI editor settings and chunk deciphering :)


🚀 - Allow more control over TuiFilesComponent display

Which @taiga-ui/* package(s) are relevant/releated to the feature request?
kit
Description
It's tricky customize the content of the files component, since it assumes there are 2 content elements (label and link). In the case where dragging occurs the only option for content is via the texts property.
I have the base display like so:

I would like to keep the same display on drag and change the background colour. However I can't do that because it computes the label while dragging as:
if (fileDragged) {
    return this.inputFileTexts$.pipe(
        map(texts => (multiple ? texts.dropMultiple : texts.drop)),
    );
}

I think a good way to do this is to deprecate link and label inputs and just add single content: PolymorpheusContent input. Also adding a default values token, in which the current behavior will be the default component, that reads those deprecated inputs through DI. This would allow for all sorts of flexibility. PR is welcome if somebody wants to speed it up, since internally we do not really need it at this point so this is going to be low priority.

Hey @waterplea, can I try to do this?

Hey @waterplea, can I try to do this?

Sure, go ahead 💪 I outlined my vision for it in a previous message.

I think I'm done with this. @waterplea please check It out if it's according to your vision. I've tried to do it in the way you outlined 💪.


TAS: move expecatations store to utils to share with TopologyUngater

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a preparatory PR to move the expectations mechanism to utils, so that I can use it in TopologyUngater.
Which issue(s) this PR fixes:
Part of #2724
Special notes for your reviewer:
Related to https://github.com/kubernetes-sigs/kueue/pull/3266
Does this PR introduce a user-facing change?
NONE

/assign @tenzen-y


[ALLUXIO-3216] Instanced config

https://alluxio.atlassian.net/browse/ALLUXIO-3216
This moves most functionality of Configuration to InstancedConfiguration, then has Configuration delegate to an internal instance of InstancedConfiguration. The only logic left in Configuration is the logic for setting/clearing values, and the logic for initializing itself in reset.
Configuration.global() returns an instance object that acts the same as Configuration.
The methods needed by AbstractFileSystem were updated to accept both instanced and non-instanced configuration. In the long term they will probably take only instanced configuration, but in the short and medium terms we can make incremental progress by keeping both versions.
The only functionality change in the move from Configuration to InstancedConfiguration was to attach the site properties file name to the SITE_PROPERTIES source so that Configuration doesn't need to worry about it. Then getFormattedSource can be replaced by getSource.toString(). I think this is a cleaner design.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19936/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19937/Build result: FAILURE[...truncated 2874 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.8.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/checker/pom.xml to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/pom.xml to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/target/alluxio-logserver-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/target/alluxio-logserver-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.8.0-SNAPSHOT/alluxio-core-client-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.8.0-SNAPSHOT/alluxio-core-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.8.0-SNAPSHOT/alluxio-tests-1.8.0-SNAPSHOT.pomchannel stoppedArchiving artifacts
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19939/
Test PASSed.

hadoop and spark seem to prefer conf but still use config occasionally. I've updated the PR to not introduce new uses of config

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19956/Build result: FAILURE[...truncated 5577 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/checker/pom.xml to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/checker/target/alluxio-checker-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/checker/target/alluxio-checker-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/pom.xml to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/target/alluxio-logserver-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/target/alluxio-logserver-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.8.0-SNAPSHOT/alluxio-core-client-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.8.0-SNAPSHOT/alluxio-core-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.8.0-SNAPSHOT/alluxio-tests-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/target/alluxio-tests-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-tests/1.8.0-SNAPSHOT/alluxio-tests-1.8.0-SNAPSHOT.jarchannel stoppedArchiving artifacts
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19978/
Test PASSed.

final minor suggestion:
can we move InstancedConfiguration, AlluxioConfiguration to alluxio.conf? I feel right now too many classes in the root package. I am fine to leave Configuration still in the root for backwards compatible reasons.

Jenkins, test this please


fix typo in backups

Thanks for the correction @ap-wtioit :smiley:

test errors seem related to https://twitter.com/Scott_Helme/status/1443604252501417984

Indeed... We are already looking for a fix. You can follow the process
in https://github.com/Tecnativa/doodba-copier-template/issues/278
Once it is fixed, you can rebase here...
On sex, out 1 2021 at 03:15:19 -0700, Andreas Perhab
@.***> wrote:

test errors seem related to
https://twitter.com/Scott_Helme/status/1443604252501417984
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Tecnativa/doodba-copier-template/pull/277#issuecomment-932102297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJJMDDVX44UL37QV3O3MYT3UEWC3PANCNFSM5FCFA6GQ.

v10 should get out of support this week, so in case we don't get a fix in time, this could be rebased after removing that support.

v10 should get out of support this week, so in case we don't get a fix in time, this could be rebased after removing that support.

True :)
Anyway, once https://github.com/Tecnativa/doodba-copier-template/pull/279 is merged, you can rebase here to fix the issue to avoid the wait...

May you rebase please?


package.json

{
"mac": "",
"linux": "<keyboard shortcut for linux",
"win": "<keyboard shortcut for windows",
"key": "",
"command": "<name of the command in VS Code"
}

/needsMoreInfo Please describe in detail the bug or feature request.


a : Bool can be read before assignement

b = a : Bool

pp a # Error: read before assignment to local variable 'a'
pp b # => nil

This sounds like a bug, the first line should give the read before assignement error.

A variable declaration has Nil as a typr

so this is expected behavior for you @asterite ? Why does a variable declaration has a type?

Because everything has a type.
I think there is a similar or same issue already for this, I think this is a duplicate.

Here's a similar issue: https://github.com/crystal-lang/crystal/issues/3641
I don't have a strong opinion on either because I can't find a use case for doing that, but we can brainstorm about it.

I think it should just be a syntax error

It's nice to allow variable declaration as an expression, which then, imo, absolutely must have the type — and return the value — after it's declaration. In which case that definitely would be a syntax error,
Anything else is outlandishly unintuitive. The declaration should be hoisted to before the expression it is used in, in the AST-transformations.
Compare:
x = 47

# Let's do some stuff
if a1 = x
    p "Using a1, #{a1}"
else
    p "Not using a1, #{a1}"
end

# "Hey! I'm gonna make it a tad better typed, let's add the obvious type of a!
# ...What could possibly go wrong?"
if a2 : Int32 = x
    p "Using a2, #{a2}"
else
    p "Not using a2, #{a2}"
end

Output:
"Using a1, 47"
"Not using a2, 47"

So b = a : Bool = true should be legal. But looks kind of weird. The alternative would be to make it a pure statement.


ambient: fix a bug preventing rewrite from working

This is caused by an issue where we have the (almost) same code to translate
routes in 2 places, and we did not update one of them. This is a
terrible code smell and we should address it. However, given the release
is ~today, doing a small fix.
Manually tested

In response to a cherrypick label: new pull request created: #53789


Fragment Title Updates

Makes titles a little more flexible when using fragments.

+1 for this commit... I had to add something similar for a project.

Taking #62 which is a similar patch.


Crash when calling shapely.geometry.asShape with invalid geometry

Expected behavior and actual behavior.
This code:
import shapely.geometry
x = shapely.geometry.asShape({'coordinates': [[1130.0, 1110.0]], 'type': 'LineString'})
assert x.is_valid
x.wkb

First, is_valid returns True instead of False and I see this log when calling it:
IllegalArgumentException: point array must contain 0 or >1 elements

Then, when asking for the wkb, my python process crashes which is even worse:
python3.5: geos_ts_c.cpp:5240: unsigned char* GEOSWKBWriter_write_r(GEOSContextHandle_t, geos::io::WKBWriter*, const geos::geom::Geometry*, std::size_t*): Assertion `0 != geom' failed.
Aborted (core dumped)

Steps to reproduce the problem.
import shapely.geometry
x = shapely.geometry.asShape({'coordinates': ((1130.0, 1110.0),), 'type': 'LineString'})
assert not x.is_valid
x.wkb

Operating system
Ubuntu Xenial. python 3.5.2.
Shapely version and provenance
1.6.2 from pypi

Thanks for the report @pvalsecc. Looks like it is related to https://github.com/Toblerity/Shapely/issues/509.

Yep, indeed. I'm a bit surprised by how long it's been around, though.

Resolved. The fix will be in 1.6.3.

hi, i try with 1.7.0 and nothing. then return to 1.6.3 and its fixed..... its sad


SFZv2 effects

Hello, below is some analysis of the effects and their routing, in Cakewalk SFZv2.
The content below is free to reuse. (CreativeCommons-0)

Routing graph
There are 5 buses that I know of: Main, Fx1, Fx2, Fx3, Fx4
The <effect> are processed in series in the bus which they belong to. It's the order of appearance in the file.
Note there is also a Mix node. I don't know the exact purpose, maybe it was there for extension purposes. It sums into the Main output.

Effect routing.svg.gz
Effect routing.drawio.gz

<region> Opcodes

effectN (with N: 1-4, was 1-2 in SFZv1)

Gain of the region's send into the Nth effect bus. (the bus=fxN effects)
It's the contribution of the region to the bus's input mix.
Translates from % into a linear gain 0-1.
Unit:% Default:0%

<effect> Opcodes

type

As in the current spec.
Only a remark: "autopan" is known as "apan" in the software.

bus

Possibles are:
- fxN with N: 1-4
- auxN: I don't have infos on these
- omitted, other: it goes to the Main bus (I guess, "the SFZv1 one")
possibly the official name is "main", according to some traces in the binary, but use any unrecognized name for bus and it will route to Main regardless.
Default: main

directtomain

Global, set it under any <effect> header for identical effect.
Gain of the Main bus into the output. (cf. routing graph)
Translates from % into a linear gain 0-1.
Unit:% Default:100%

fxNtomain

Global, set it under any <effect> header for identical effect.
Gain of the Nth effect bus into the output. (N: 1-4, cf. routing graph)
Translates from % into a linear gain 0-1.
Unit:% Default:0%

fxNtomix

Global, set it under any <effect> header for identical effect.
Gain of the Nth effect bus into the Mix node. (N: 1-4, cf. routing graph)
Translates from % into a linear gain 0-1.
Unit:% Default:0%

Regarding bypass:
 Opcodes

bypass_onccN

Set up a bypass controller for the effect.
When the MIDI CC value (0-127) is >= a threshold, the effect plays, otherwise it's disabled.
The threshold is determined according to this expression:
f(x) = 64.0 / BypassValue
where BypassValue is the opcode's value, strictly positive, interpreted as real number.
At BypassValue=1, without doubt the most useful, it's off at CC<64 and on at CC>=64

Added most of this info to the effect header, also filled in more about the differences bewteen SFZ v1 and SFZ v2 effects handing in the effect opcode pages.
Did we miss anything, and is there any info anywhere about what's really SFZ v2 and what's Cakewalk-specfic?

Did we miss anything, and is there any info anywhere about what's really SFZ v2 and what's Cakewalk-specfic?

bus, fxNtomain, defaulttomain, effectN
These have some examples in the rgc v2 test suite, Cakewalk software all have them.

fxNtomix, bypass
Not in the test suite and no other info, the Cakewalk software have them.

dsp_order, <effect>internal=on, extended routing graph (FX->DSP various arrangements)
This is in Rapture only.

Added that stuff. I guess there are also settings for specific parameters for specific effects, like reverb_damp and delay_feedback. Could list those somewhere, if we can find a complete list.

Sure, this takes a bit of time, but I'll try make you the best list I can.

Thanks, that's a lot of information! Added that to the type opcode page for now, will possibly move to proper opcode pages later.


Failed to resolve component

In vue 3, I am getting

[Vue warn]: Failed to resolve component: Badge

Any way to resolve this issue, because daisyui components don't get displayed correctly on the page

@MotionPhix I need more details.
Can you create a small repo so I can reproduce this issue?
There's an example with the latest version of Vue + Vite and everything looks fine: https://github.com/saadeghi/daisyui/tree/master/examples/vue-vite

@MotionPhix I'm closing this for now. It seems like a problem with your build config (not with daisyUI).
You can take a look at the example build here.
Feel free to continue the conversation with more info if the problem still exists.


Fixed-base manipulator with mc_rtc and choreonoid

I would like to use some kind of fixed-base manipulator robot in the environment of mc_rtc + choreonoid.
In the mc_rtc document, Panda and Sawyer are supported for mc_rtc.
First question: where can I get the panda_description with necessary files by mc_rtc (e.g., convex collision shapes)?
Second question:
We also need the choreonoid project files, python script (sim_mc.py), etc. for runnig mc_rtc on choreonoid.
For HRP robots, those files are managed in https://gite.lirmm.fr/choreonoid-hrp-installation/hrp-choreonoid.
Does anyone already have those files for fixed-base manipulator?
Third question:
We need to generate VRML robot model (*.wrl) from URDF robot model for choreonoid. How can I convert it?

Hi @mmurooka
Everything you need is here: https://github.com/jrl-umi3218/mc_panda
It only requires ros-${ROS_DISTRO}-libfranka and ros-${ROS_DISTRO}-franka-ros. If the franka-ros meta package is not available then only franka-description should be required.
The description is based off the official panda description package from Franka Emika with just the mc_rtc related files added by mc_panda. The mc_panda project also includes Choreonoid projects that will work with mc_openrtm or mc_udp.

Thank you @gergondet
Panda manipulator on mc_rtc + choreonoid worked with installing mc_panda!
Additional few questions:

Real robot in Rviz does not reflect the actual joint positions of the robot in choreonoid. Is this expected result?
As shown in the below video, The robot joint positions in choreonoid are bit oscillating. Is this also expeted?
https://www.dropbox.com/s/jhcjpwjuc5hmdjn/panda-choreonoid-20210602.mp4?dl=0

As shown in the below video, the robot joint positions in choreonoid are bit oscillating. Is this also expeted?

Joint oscillation stopped by setting rotorInertia and gearRatio in VRML model and tuning PDgains https://github.com/mmurooka/mc_panda/commit/26b2bb21c5ad2ee29e71a44b4e0caf67ab761ead
https://www.dropbox.com/s/72gqoe4g5m5nu85/panda-choreonoid-gain-tune-20210603.mp4?dl=0

RealRobot in Rviz does not reflect the actual joint positions of the robot in choreonoid. Is this expected result?

By adding the configurations of ObserverPipelines containing Encoder observer, the real robot state is published.
Now all questions are solved, I'll close the issue.
( If the joint oscillation is common issue, we can consider to make Pull Request of parameter updates like https://github.com/mmurooka/mc_panda/commit/26b2bb21c5ad2ee29e71a44b4e0caf67ab761ead. )

Hi @mmurooka

If the joint oscillation is common issue

I think it is. We didn't go very far with the Choreonoid simulation as the I.AM project moved away from using it as a simulation platform. The files remained here for the sake of preservation. If you can open a pull request with your changes it would be very much appreciated. Thanks!


False positives for Squiz.PHP.CommentedOutCode.Found

This line is being flagged as commented-out code
	} // foreach $region

It's pretty common to do line comments at the end of if and for blocks like that. Please don't flag them.
Here's the whole block:
	<?php
	foreach ( $quadrant as $region => $restaurants ) {
		// Grab the region color, used to get the winner id
		$region_color = $region_colors[ $region ];
		// Grab the winner id, used for the r_round_url
		$round_winner_id = self::round_winner_id( $quadrant_name, $region_color, $region );
	?>
	<div class="region-reviews <?php echo esc_attr( self::round_status( $quadrant_name, null, $region ) ), esc_attr( $region ); ?>">
....

	<?php
	} // foreach $region
	echo '
';
	$i++;
} // foreach $quadrant

This belongs in PHPCS. Closing.

@paulschreiber you can customize the percentage threshold for when a comment is considered commented-out code or not. See Squiz_Sniffs_PHP_CommentedOutCodeSniff::$maxPercentage

The problem isn't the threshold — it's that PHPCS is thinking too many things — things that are not code — are code. Example:
// default

If the body of a foreach is so long that one needs a comment to remind themselves what a closing } is for, then it's a code smell that the body is doing too much and should be abstracted into a function (maybe switch to array_walk()).
IMO, there's no reason, ever, for a comment on a closing }, that simply indicates what PHP structure it is closing.

Even with short methods, adding comments to the end of if, for, try and other blocks helps improve the readability of the code.

Even with short methods, adding comments to the end of if, for, try and other blocks helps improve the readability of the code.

I think we're going to fundamentally disagree there, as is our right :-) For me, short methods that are not indented more than one or two levels, are obvious for what closing braces are for (the indentation matches the if, for, et al anyway. Having // end foo just adds visual clutter.


NPM versions behind github

I'm unable to get anything newer than 0.8.11 via npm.
Specifying "angular-material-data-table": "0.9.x" in my package.json results in the error:
$ npm install --no-bin-links
npm ERR! Linux 3.10.0-229.14.1.el7.x86_64
npm ERR! argv "node" "/usr/bin/npm" "install" "--no-bin-links"
npm ERR! node v0.10.36
npm ERR! npm  v3.5.2

npm ERR! No compatible version found<EMAIL_ADDRESS>npm ERR! Valid install targets:
npm ERR! 0.8.11

I checked the package on npmjs.com and it shows 0.8.11 is the latest
https://www.npmjs.com/package/angular-material-data-table

0.8.11 is the latest of 2 releases

Hmm... I thought npm would track it but maybe not. I might have to manually push updates to npm.

Okay I had to run the nom publish command. Try it now.


(PUP-3839) Fix calling gem on Windows

Fixes calling the gem command on Windows, which requires that Ruby is
installed first and that it be called via cmd /c.

I've run this through setting up acceptance runs with: win2012-rubyx64 and rhel7, both from git and packages (Windows packages doesn't work because we don't support install from packages this way).


repo structure?

@asinghvi17 Do you have any thoughts about how to structure this repo?
My initial commit is a rough sketch of how I imagine we can maintain this repo:

geojson_files.jl looks up all available datasets from this github directory: link.
create_artifacts.jl does the job of creating Artifacts.toml. I imagine we can hook that up to GitHub CI to periodically check for new datasets or updates to existing datasets.

note: currently, I just download from [...]/master/[...], but we should probably do this by tags or something to ensure reproducibility. Although I think Artifacts will fail if a file is updated upstream since the SHA will change... Anyways -- just some food for thought.

The current dependencies in Project.toml are not really necessary, and, along with the aforementioned files, should be moved to some subdirectory that is tied to Github CI or tests.
Down the road we can discuss integration with GeoMakie.

Hey, thanks for giving this a start!  It turned out that I had made this repo a while ago, probably looking to do a similar thing, but then didn't end up doing it.
I just tried the package, but couldn't seem to get it to instantiate - Julia was unable to download the initial artifact, and when I tried that link on Github it hung indefinitely.   Strangely, even when I tried to get the raw file from Github I had the same issue.
We could download the Shapefile zips directly from the source, which is hosted by AWS and has a considerably faster download.  That means that we'd need to somewhat "roll our own" artifacts, and we couldn't use artifact-strings in that case, using artifacts only as a storage solution.
I wouldn't mind writing that up, and it shouldn't require too much maintenance either.  Discovery is actually possible through their Github repo, so there's that advantage as well.  Unfortunately, in this case, we would not be able to track by version as we might on Github,

All in all I think the design looks good!
We should definitely download from tags - we will have to manually update them as time goes by but it shouldn't be too hard; it could conceivably be automated using e.g. Github Actions as well.

The current dependencies in Project.toml are not really necessary,

Agreed.  We probably only need GeoJSON as a dependency (or GeoJSON2 if it looks like we need speed).

Down the road we can discuss integration with GeoMakie.

This should slot nicely into GeoMakie as a dependency so we can supply coastlines in a more flexible way.  No changes will be needed on this end AFAIK.

I think I've fixed instantiation errors now, and also moved to installing by tags. Let me know if you still have any issues.
Running build/create_artifacts.jl takes about a minute or two (which includes temporarily downloading all artifacts), so I don't think download speeds should be an issue. Though I'd be happy to move to shapefile zips if that's significantly faster (we could also provide both sources as prioritized alternatives in Artifacts.toml, with geojson as backup).
In case we use Shapefiles, I think we'd have to implement my functions from https://github.com/MakieOrg/GeoMakie.jl/pull/139 here.

I found githack.com which can act as a CDN for github, so we can use that as a secondary download link if the first one fails.  With that change, it works on my machine.  Will push this up shortly.
GeoJSON is getting some perf improvements now, so I'm not too worried about that.
The issue with zips is that Artifacts doesn't natively support those, so we'd have to unpack them ourselves, possibly using scratchspaces. This sounds like a hassle, so let's save that until and unless there's no other option?

githack looks really neat!
Looks like tar.gz is supported natively by Artifacts, but I don't know how much of an advantage they are compared to uncompressed files, especially since we (currently) don't bundle different data files in the same Artifact.

Though it isn't inconceivable that bundling the same data (e.g. coastlines) at different resolutions, or "similar" data types at the same resolution is a terrible idea... Though it sounds like quite a bit of manual (and subjective) work to make those decisions, which I don't think is advisable now, if ever.

Yeah, I like the framework we have going on now.  One thing I do want to do is to add a basic dataset search, i.e., I should be able to do some kind of search like datasets(scale = 10, keywords = ["admin0"]) within the package.  Otherwise in terms of vector functionality we're pretty much set.
Would you be interested in moving this package to the JuliaGeo org?  If so I can reach out to them and ask.  It would probably make this package a little more discoverable, as well as having more people around to help with maintenance etc.

Looks like tar.gz is supported natively by Artifacts

Tarballs and gzips are, but .zip is not, unfortunately :(.  That's why we'd have to do this whole scratchspaces/manual unzipping thing, otherwise they'd just be manual additions to the artifact list.

Yeah, I totally agree with search. It may also possibly be convenient with some helper functions that guide users through the "hierarchy" of vectors: i.e. category = [admin, bathymetry, coastline, ...], resolution=[10, 50, 110], etc.
(ps: apologies, I just force pushed to master to fix a stupid bug I introduced in a small change I just made, I hope you didn't notice)

Sounds good - looks like that and rasters are our only TODOs before this is ready to go for all available data!
About JuliaGeo: I just realized that I'm a member there already, so I'll transfer the repo now.
No worries - also I'm not reading a force push on my end, so I think it's fine.  But yeah, now that it's semi-working we should probably not push directly to master anymore :D


fix(semantic): IdentifierReference within TSPropertySignature cannot reference type-only import binding

close: #5435
The behavior of IdentifierReference in TSPropertySignature is the same as in TSTypeQuery, both allow only reference value bindings and type-only import bindings.
I still use ReferenceFlags::TSTypeQuery here because I want to avoid producing many changes unrelated to the bug in this PR. I will refactor it in the follow-up PR soon

#5441  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite

Should we add a test case to semantic's integration tests? maybe in symbols.rs?

Should we add a test case to semantic's integration tests? maybe in symbols.rs?

I added a fixture for testing, and as you can see from the snapshot the results are as expected，So I think that's enough.


Fix problem with missing NUnit reference

Scripts using the NUnit functionality must be placed in a Editor folder, as the NUnit library is only available within the Editor scope. More info here

Sorry for the late reply. Thanks for contributing.
The changes look good. One thing would be that the C# project has stopped working since the project file has not been updated with the file location changes.
I think I will just remove that project anyway though after this is merged, since the goal for this is to use it with Unity3D anyway and it works just fine running the unit tests in Visual Studio with the "VS Tools for Unity" plugin.
I was a bit skeptical to the addition of the .meta files, but after looking around in some other github repositories for unity stuff it doesn't seem like an uncommon thing to do (for some reason), so we can leave them.