Node's require should implement a new interface NodeRequire (rather than direct signature) for specialized extension by other libraries

This is motivated by trying to use Electron (Atom shell) with Typescript.  I don't know anything about Node.js, but at least this Electron package which uses Node takes advantage of the require() function object defined by Node.  I believe that we cannot use the Typescript import statement because Electron is not compatible with AMD/RequireJS and TypeScript doesn't know what to do with import statements without enabling AMD module support.
Using the quick start as is, even with the GitHub-Electron.d.ts stuff loaded in, statements like var BrowserWindow = require('browser-window') make the BrowserWindow class show up to be of type any (which is not very helpful) and all my other attempts to get it working otherwise have failed.  So here's my solution but it needs a subtle change to how require() is defined.
node.d.ts currently defines its require as:
declare var require: {
    (id: string): any;
    resolve(id: string): string;
    cache: any;
    extensions: any;
    main: any;
}

but this is obnoxious because this means that the require signature cannot be specialized by string name.
If require were defined like this instead:
interface NodeRequire {
    (id: string): any;
    resolve(id: string): string;
    cache: any;
    extensions: any;
    main: any;
}

declare var require: NodeRequire;

... then for a specific library we could extend it like so:
interface NodeRequire {
    (id: 'browser-window'): { new (options?: GitHubElectron.BrowserWindowOptions) : GitHubElectron.BrowserWindow }
    (id: 'crash-reporter'): { start(options?: CrashReporterStartOptions): void; getLastCrashReport(): CrashReporterPayload; }
}

and get proper intellisense for
require('crash-reporter').start();

and
mainWindow = new BrowserWindow({ width: 800, height: 600 });

This is necessary because I believe that a declared var cannot be extended directly, but an interface that it implements can be.  I believe that the resulting require type information would be exactly the same as the current implementation.
My crash-reporter example required some tweaking to the GitHub-Electron.d.ts packages, but I'll tackle that next (the module has a string name which I cannot refer to so I had to pull out the embedded interface for CrashReporterPayload and repeat the module definition inline).  There's no point in those definitions being more correct if we don't get the type inferencing with THIS suggestion anyway.
Perhaps I'm missing something big, so I'd love to be corrected on that!  But I don't see examples of how to use the GitHub-Electron.d.ts in a full and effective setup.
There are other places that the require functionality is repeated (module.require()) and I'm not familiar with the node.js api to know where to make this change everywhere or if that would be the right thing to do.

PR Merged.  Thanks!


feat: add basic metrics view

Description
I'd like to contribute on metrics view. I think view will be helpful for customized aggregation over default aggregation on instrumenting metrics.

Changed the location of data_points to metric_stream, because I think aggregation should act as aggregator that provide transformative (on data_points) feature rather than storage feature.
Didn't implement the logic for conflicting metric identities. For current implementation, it will export all the metrics with different aggregation if the metric_stream has multiple views applied.
Need schema_url as part of instrumentation selection. https://github.com/open-telemetry/opentelemetry-ruby/pull/1237

As a continuation from our discussion during the SIG on July 9, 2024:
I was experimenting with this branch to create an explicit bucket histogram with custom buckets. It worked great! Thank you for building this!
The only error I've encountered was while exporting the metrics via OTLP. The structure of the metrics object passed as an argument to the export method has changed.
Before:
Array[MetricData, MetricData]

In this branch:
Array[[MetricData],[MetricData]]

We could handle this in the exporter, but it may be preferable to go back to the original structure. As far as I can see in the spec, it just needs to be some kind of list, so either way seems compliant.

Thanks for catching it. I use flatten! to ensure it return [MetricData]. I remembered that I made this mistake while I was thinking about the case for multiple view for one metric stream.

Thanks for catching it. I use flatten! to ensure it return [MetricData]. I remembered that I made this mistake while I was thinking about the case for multiple view for one metric stream.

Thanks for the fix! What else did you want to accomplish before moving the PR out of draft mode?

Not in my current mind. I will open it for review

Thanks @kaylareopelle, I updated the suggestions. I didn't do commit the suggestions on the github page to avoid github freeze on my browser and create commit issue (I had bad experience last time click each Commit suggestion).


fix(net): Limit the number of leftover nonces in the self-connection nonce set

Motivation
This PR prevents a memory exhaustion attack on Zebra.
It also limits the inbound connection rate to make similar attacks harder in future.
Complex Code or Requirements
This PR modifies concurrent network handshake code, where futures run concurrently.
It also adds more code to a futures mutex critical section.
It has already been reviewed privately by two Zebra developers.
Solution

Limit the number of nonces in the nonce set to ~500 or 8 kB~ the configured connection limit
Limit the inbound connection rate to 1 per second
Slightly decrease the outbound connection rate to one every 50 milliseconds

Review
This is ready for review. It needs to get merged before the next Zebra release.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

Is there a commit missing here?

Is there a commit missing here?

Thanks for catching that, I forgot to fetch your tests before pushing the branch!


docs: Add Install and Usage section

This should answer questions I originally asked in https://github.com/probot/probot/issues/522.

Fair. Thanks!


Feature 651 tmp files inside build folders

This PR

closes #651

sechub-temp-sharedvolume11387562942178462821/ etc. is created, because in normal tests (not integration tests) when a test spring container has been started, this is a fallback when no setup has been done for the shared volume.
This is something that should not happen with S3 setup.
I will change the naming to `sechub-fallback-sharedvolume" so it's more clear its only a fallback, when shared volume is not set.
For people wanting no such temp files inside their Jenkins builds, they just need to setup the shared volume settings as env variables for their jobs.
So I will not do more here (except the renaming and some log improvments)

sechub-inttest15511987697992823166/
is the temp folder defined by gradle for integration tests.
I will change the gradle script accordingly so we have those outputs in build folders as well

gradle-worker-*****
comes from gradle - cannot change this.

subFolder
This comes from a textwriter test - will change it .

PDS server not stopping...
I tried out and really, the PDS is not stopping when e.g. buildDochas been run.
Even a manual ./graldew stopIntegrationTestPDS does not work
Will create an extra issue for this.

I created #998 to handle the PDS integration test shutdown problems - as it is major problem with the PDS itself, it will not be handled this PR.


Lab 1, AADDS, different message for "Network configuration issue detected..."

Module: 1
Lab: 1, AADDS
Exercise: 1, Task: 3
Step: 2
Instead of "Network configuration issues detected...", Azure now shows the following:

updated


ERESOLVE unable to resolve dependency tree

When trying to run npm i typescript-rtti
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/typescript
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/typescript-rtti
npm ERR!   typescript-rtti@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/waltermin/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/waltermin/.npm/_logs/2022-07-19T07_47_23_957Z-debug-0.log

Node version: 18.3.0
NPM version: 8.11.0
Typescript version: 4.7.4

@Saghetti0 downgrade your typescript version or do npm i --force, it should work with typescript 4.7

Downgrading to Typescript 4.6 worked. Are there any plans to support the latest Typescript 4.7 though?

Oof, we do support Typescript 4.7 already. This is an incorrect peer dep. Willfix!

mmm yes,i also have another problem with ts 4.7+
TypeError: Cannot read properties of undefined (reading 'length')
    at emitShebangIfNeeded (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:113681:79)
    at Object.writeBundle (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:110872:13)
    at printSourceFileOrBundle (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:110436:25)
    at emitJsFileOrBundle (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:110342:13)
    at emitSourceFileOrBundle (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:110265:13)
    at forEachEmittedFile (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:110004:34)
    at Object.emitFiles (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:110245:9)
    at emitWorker (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:117534:33)
    at /home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:117511:72
    at runWithCancellationToken (/home/cristian/IdeaProjects/climbo2/node_modules/typescript/lib/tsc.js:117606:24)

I apparently can't keep track of TS versions. The compiler API changes are in typescript@next which is 4.8. I've bumped the versions on main to 4.7 and added it to corpus testing.
@CristianPi the unit test suite seems to pass just fine with 4.7, corpus test suite is running now on CI. If corpuss passes without exposing the above problem, would you be willing to set up an isolated test case of that issue? Otherwise if your code is open source, we can add it to the corpus test suite.

I apparently can't keep track of TS versions. The compiler API changes are in typescript@next which is 4.8. I've bumped the versions on main to 4.7 and added it to corpus testing.
@CristianPi the unit test suite seems to pass just fine with 4.7, corpus test suite is running now on CI. If corpus passes without exposing the above problem, would you be willing to set up an isolated test case of that issue? Otherwise if your code is open source, we can add it to the corpus test suite.
First test run with 4.7 is at https://app.circleci.com/pipelines/github/typescript-rtti/typescript-rtti/353/workflows/415f099c-2dc7-4ee6-9f43-fe9ea0be8eda

With the new version 0.8.2 and upgrading to typescript 4.7.x the error is gone, so i wouldn't lose any more time on this, also because i have no idea on how to reproduce that.

oof I am using with TS 4.7.4 in prod. What's the recommended TS version? This should be added to the readme somewhere to the top so that people don't miss it.

The peer deps does specify supported TS versions, but indeed adding a supported TS versions to README would also be good.
@capaj Is everything working as expected with 4.7? There were no changes required in the test suite so it should, I just need to update the TypeORM version before I can officially say it's fine.

Peer deps are updated in<EMAIL_ADDRESS>


Filter by date does not work

Made sure I had latest version installed. Copied example code from the readme.md, still sends back dates out of needed range. See screen shot for example.

Please cancel issue.


Consistent handling of NaN/missing values

We should check this throughout the whole featurization process. Do we consistently replace the nan with some value? here it is zero, but in cleaning it is -1.
Originally posted by @ppdebreuck in https://github.com/ppdebreuck/modnet/pull/23#discussion_r572877921
As suggested, we should probably move all this to clean_df, or handle it with a scikit transformer/scaler.

Closed by #44


encrypt the sheet id

@mariobehling I believe it will work. if it doesn't you'll have to revert, but the only way to test is by merging.
The PR won't build with encrypted keys before merging

Signed-off-by: Arnav Gupta<EMAIL_ADDRESS>

@championswimmer So, please explain. I switched the sheet not to share with anyone on the Internet. Looks like the build is failing then though. What are your suggestions?

@mariobehling I will fix it

I've added a local variable to travis it's solved problem

@rafalkowalski it's solved now ?

it works now, but only when the google sheet is public.

@championswimmer please help to implement oauth token. https://developers.google.com/identity/protocols/OAuth2#expiration

Yes I'm on it
At first I just implemented Nirendar Rajendran's suggestion - just encrypt
the sheet id.
On 03-May-2016 04:14, "Mario Behling"<EMAIL_ADDRESS>wrote:

@championswimmer https://github.com/championswimmer please help to
implement oauth token.
https://developers.google.com/identity/protocols/OAuth2#expiration
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/OpenTechSummit/open-event-scraper/pull/29#issuecomment-216387162

@rafal can you take a look at the scraper?
Python isnt my strong suite, and I was unable to get the Oauth thing work.
On 03-May-2016 11:21, "Arnav Gupta"<EMAIL_ADDRESS>wrote:

Yes I'm on it
At first I just implemented Nirendar Rajendran's suggestion - just encrypt
the sheet id.
On 03-May-2016 04:14, "Mario Behling"<EMAIL_ADDRESS>wrote:

@championswimmer https://github.com/championswimmer please help to
implement oauth token.
https://developers.google.com/identity/protocols/OAuth2#expiration
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/OpenTechSummit/open-event-scraper/pull/29#issuecomment-216387162


如何配置环境（how to configure the environment?）

这个环境配置能给一个教程吗，安装完docker和docker-compose后，就无法继续进行下去了。
(can you give me a guide to this project?After I configured the docker and docker-compose,I don't know what to do the next.)

Hi,
Do you need development guide or user guide?

Thank you for your reply，I need development guide.

You can find steps for setup an environment here.


[statistic] :update doc

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

由于合并其他pr，该pr已产生代码冲突，建议重新提交

由于合并其他pr，该pr已产生代码冲突，建议重新提交

由于合并其他pr，该pr已产生代码冲突，建议重新提交


Constant "Basic output test failed" errors from Sway if WayVNC is running when SDL2 program is started

Setup
Fedora 33 package versions:

sway v1.5
wlroots v0.11.0
wayvnc v0.3.0

Problem
Use-case:

Start: sway
Start: WAYLAND_DISPLAY=wayland-1 wayvnc
Start: WAYLAND_DISPLAY=wayland-1

Expected results:

No errors as they don't happen when wayvnc isn't running
Any error output is rate-limited to something sane

Actual result:

VNC client output of Sway screen and the SDL2 application looks fine, so error doesn't seem very serious
Following from Sway approximately at rate given by WayVNC "--max-fps" option:

00:00:03.677 [types/wlr_output.c:567] Basic output test failed
00:00:03.694 [types/wlr_output.c:567] Basic output test failed
00:00:03.711 [types/wlr_output.c:567] Basic output test failed
00:00:03.727 [types/wlr_output.c:567] Basic output test failed

Notes
This looks similar to an earlier wlroots issue, but that was fixed clearly before wlroots v0.11.0 release, so I assume Fedora version to contain that fix:  https://github.com/swaywm/wlroots/issues/2164
I tried one another SDL2 program with this, but that didn't trigger the issue, so I assume problem to be one of the SDL options used by this program:
window = SDL_CreateWindow(name, x, y, w, h, SDL_WINDOW_FULLSCREEN|SDL_WINDOW_INPUT_FOCUS|SDL_WINDOW_ALWAYS_ON_TOP);
renderer = SDL_CreateRenderer(window, -1, SDL_RENDERER_PRESENTVSYNC|SDL_RENDERER_ACCELERATED);
SDL_CreateTexture(renderer, SDL_PIXELFORMAT_NV12, SDL_TEXTUREACCESS_STREAMING, w, h);

And such textures being blit to the screen.  Using 16-bit SDL_PIXELFORMAT_UYVY instead of the 12-bit one doesn't help.
(Program is for viewing video streams, that's why it's using video related formats, and unfortunately it's closed one.)

This was mentioned in https://github.com/swaywm/wlroots/issues/2523#issuecomment-740790220
Please try with the latest Sway and wlroots commits.

Can you try https://github.com/swaywm/sway/pull/5871?

I haven't built any of these components from sources.  Are there API breaks since v0.11.0 wlroots release (one in Fedora) i.e. if I build latest wlroots + that extra patch, do I need to rebuild also Sway & WayVNC?

You need to build both wlroots and Sway from source, no need to install. See https://github.com/swaywm/sway/wiki/Development-Setup#compiling-as-a-subproject

Ok, thanks.  I should have some time for that next week.

Problem wasn't related to the SDL2 or pixel formats, but fullscreen (as indicated by the linked items & PRs).
While fullscreen doesn't work for glmark2 Wayland version:
$ sway &  # running in a wayland window
$ wayvnc --max-fps 10 &
$ WAYLAND_DISPLAY=wayland-1 glmark2-es2-wayland --fullscreen
Error: eglCreateWindowSurface failed with error: 0x300b
Error: eglCreateWindowSurface failed with error: 0x300b
Error: CanvasGeneric: Invalid EGL state
Error: main: Could not initialize canvas

I can use Xwayland and X version for it, and this does produce the errors:
DISPLAY=:2 ./glmark2-es2 --fullscreen

Unfortunately I don't have time to check the fix (due to app I needed this for not working 100% under Wayland and few other reasons, I've switched to Weston + Xwayland + x11vnc), but you can easily verify the fix with commands in above comment (glmark2 is available in the most Linux distros).


Test Improved stopping_condition method

Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:

I removed, for now, the workflow update_dev_version. Without the proper setting, it is guaranteed that it will always fail.

[sc-29886]


WebGPU on native ?

Need to consider this route sometime in the future.
https://eliemichel.github.io/LearnWebGPU/

Food for thought: using Dawn (webgpu implem in chrome) ?

https://dawn.googlesource.com/dawn/+/refs/heads/chromium-gpu-experimental/README.md
https://github.com/juj/wasm_webgpu

ref:

https://github.com/webgpu-native/webgpu-headers


AutoUpdator updates without SSL

I run Little Snitch and noticed after running the Ghost App that the AutoUpdator is using port 80 rather than 443 SSL connection.  I know I would feel safer if it was using a secure connection.

They were working on it last year apparently, see #199

Any news here?


Images not available while using atom-material-ui and atom-material-syntax themes

Images not available while using atom-material-ui and atom-material-syntax themes.

Not related to the syntax theme. Also, the UI theme only modifies the styles, not DOM elements. I've had this happen to me a few times and attributed it to network issues.

@silvestreh I think this is related to the image paths.  Looks like relative paths don't work on atom.io... probably not in the editor either.
https://atom.io/themes/monokai  <-- working
https://atom.io/themes/atom-material-syntax <-- not working

Yeah, I noticed that. That happens when referencing an image from within the repository. I think it's extremely low priority, that's why it's still broken.

@arunkpatra @gdborton Looks like Atom caches those images and then fails to load them from the cache. This, I believe, is not a problem with the syntax theme.


New version: LGUG2Z.komorebi version 0.1.19

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

= = = = = = PR is modifying Apps and Features Entries = = = = = =
This PR adds an upgrade code. Do previous manifest versions need this too?


Dynamic fromTag / toTag

Thank you for this nice action !
I want to have a changelog form current tag to previous tag, do you have any idea to make this dynamic to prevent a commit in yml ?
eg git log $(git describe --abbrev=0 --tags $(git describe --abbrev=0)^)...$(git describe --abbrev=0)
same like git log 2.16.0...2.15.3
- name: "Complex Configuration"
  id: build_changelog
  uses: mikepenz/release-changelog-builder-action@{latest-release}
  with:
    fromTag: "2.15.3" <----  how to make this dynamic my previous tag, eg "git describe --abbrev=0 --tags $(git describe --abbrev=0)^"
    toTag: "2.16.0" <----  how to make this dynamic my current tag, eg "git describe --tags"

@hannesa2 theoretically you do not have to specify either as long as:

the action is executed within the git repo with its tags also available locally (which seems to be the case in your example)

The toTag is resolved with this logic:

https://github.com/mikepenz/release-changelog-builder-action/blob/develop/src/releaseNotesBuilder.ts#L26-L43

Given the toTag the action will automatically resolve the fromTag by retrieving the tags of the repo and ordering them accordingly:

https://github.com/mikepenz/release-changelog-builder-action/blob/develop/src/releaseNotesBuilder.ts#L76-L100

I did a minimal usage
  - name: "Build Changelog"
    id: changelog
    uses<EMAIL_ADDRESS>    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

and when I create the release
hub release create ${assetsAPK} -m "${{steps.changelog.outputs.fromTag}}-${{steps.changelog.outputs.toTag}} changelog=${{steps.changelog.outputs.changelog}}" "${{steps.tagger.outputs.tag}}"
I see

This means fromTag is empty.
Back to my question, do I have to specify the fromTag anyhow by myself, or is there already something there ?

Could you maybe please show the log messages of the action, usually they are very helpful to identify what's going on. maybe even enable the debug flag in github actions for debug logs.
if no fromTag is provided it will load them from the GitHub API and then order according to SemVer: https://github.com/mikepenz/release-changelog-builder-action/blob/develop/src/tags.ts

To be concrete: My expectation would be
git log $(git describe --abbrev=0 --tags $(git describe --abbrev=0)^)...$(git describe --abbrev=0)
means
git log oc-and...<IP_ADDRESS> (pointless or not)
Here is the log
https://github.com/hannesa2/owncloud-android/runs/2093065007?check_suite_focus=true

@hannesa2 based on the log there are 2 things I see.
The version numbers du not fully follow semver as such automatic resolving fails.
If you want to provide fromTag  and toTag manually you can do that, you could for example get those values via a shell step in your gitHub and specify an output you use afterwards:

https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-output-parameter

Beyond that, it also looks like your project does not use PRs (just for dependency updates). The default approach for this action is to use the PRs to generate the changelog (as it is usually more meaningful, also we can take a lot of information only PRs provide, author, labels, milestone, ...)
You can enable the commitMode, which will then use commits to construct the changelog from

Thanks for clarification. The non-used semver is out of my control, so I've to specify fromTag by myself


Fix build scripts

The build scripts in the appmgr/ directory need to be updated to build embassy-sdk rather than appmgr portable
Pretty sure this is the correct command: cargo install --bin=embassy-sdk --path=. --no-default-features: https://github.com/Start9Labs/embassy-os/blob/integration/0.3.0/appmgr/build-portable.sh
Not sure what these are for:
https://github.com/Start9Labs/embassy-os/blob/integration/0.3.0/appmgr/build-portable-dev.sh
https://github.com/Start9Labs/embassy-os/blob/integration/0.3.0/appmgr/build-dev.sh

@chrisguida I think you are looking for install-sdk.sh. build-portable.sh is for building the sdk that runs on the registry and it works fine!

@both of you, this ticket is from a while ago. Things were updated since this ticket was created :)


[RSDK-7523] Monitor the canaries in case one goes offline

Here's the latest plan:

One canary will be designated the "monitor" of the other canaries:

It will have a new cron job that runs after the others, to run monitor_other_boards.py. This will connect into the other RDK servers, to make sure they're online (and thus likely to have run their tests recently), and will report to Slack if that doesn't happen.

(At least) one non-monitor board should have its config updated to name the monitor. During its tests, it will test whether it's able to connect to the monitor, and will fail its tests if it can't.

With this, we'll have the monitor report to Slack if there are any canaries that appear to be offline, and we'll have the other canary report to Slack if the monitor cannot be pinged. Now, for something to go down without us noticing, we'd need at least 2 boards to fail simultaneously!
The monitor board will be the rpi5, and the board that pings the monitor will be the up4000.

Pivoting somewhat: although monitor_other_boards.py runs fine from my machine, it cannot run on the board canaries because they have the wrong TailScale privileges to connect to other boards. I talked to @abe-winter about how to do this right, and he thinks the simplest approach is to run the monitor from a Google Cloud Run instead of one of the canaries. So, he made https://viam.atlassian.net/browse/APP-5308, which will do it from the cloud instead (which he claims is easy for an SRE, and he's happy to set that part up for us).
I'm going to remove the part of this PR about an extra crontab to run monitor_other_boards.py, and an extra test to ping the monitor. When this PR is merged, Abe will make a Google Cloud Run job to run monitor_other_boards.py instead.
I have given Abe the private SSH key, and a version of slack_reporter_config.py that can write to the correct Slack channel.

Look at the #temp_to_remove slack channel for test runs: when run on my laptop, monitor_other_boards.py has no output by default, but if I unplug a board, it writes to Slack about it, and if a board hasn't run its analysis today, it writes to Slack about that. I think this is ready to go!

All boards have board_monitor set to None in their configs, except the up4000, which has it set to the rpi5. The rpi5 has the new crontab installed. I'm merging this, and we'll see how it goes tonight...


Bugfix/new wtf

Removed items no longer auctioning
Added item id database
removed references to analyse_auction_success (to be rescoped)
Change to way missing snatch items reported

Codecov Report

Merging #64 into dev will increase coverage by 0.02%.
The diff coverage is 11.11%.

@@           Coverage Diff            @@
##             dev     #64      +/-   ##
========================================
+ Coverage   5.37%   5.40%   +0.02%
========================================
  Files          6       6
  Lines        651     648       -3
  Branches     100     100
========================================
  Hits          35      35
+ Misses       616     613       -3

Impacted Files
Coverage Δ

src/pricer/analysis.py
0.00% <0.00%> (ø)

src/pricer/utils.py
17.68% <25.00%> (+0.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c67631...07ba1ea. Read the comment docs.


Over resource limits on Streamlit Cloud

Hey there :wave: Just wanted to let you know that your app on Streamlit Cloud deployed from this repo has gone over its resource limits. Access to the app is temporarily limited. Visit the app to see more details and possible solutions.

The app has been rebooted. It should be working now.


Pgstac v0.4.0b

Related Issue(s): #283
This PR should supersede #307 and #305
Description:

Upgrades pgstac backend to 0.4.0
Enables cql2-json

pgstac enables as default (settable in pgstac configuration)
can be set per query using "filter-lang" parameter ("cql-json" or "cql2-json")
stac-fastapi-pgstac will automatically use cql-json if query, bbox, ids, collections, or datetime parameter are set for backwards compatibility

PR Checklist:

[X] Code is formatted and linted (run pre-commit run --all-files)
[X] Tests pass (run make test)
[X] Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
[X] Changes are added to the CHANGELOG.

@moradology @edkeeble This PR includes the changes from #305 and #307 adding some basic tests to make sure that cql-json and cql2-json are both working. Would be great if you could throw in a review.

Is there anything here that should be added in the changelog @moradology @bitner ?

Probably not a bad idea to mention the bump and CQL2 support. I'll toss up a PR for that. Thanks for keeping an eye out


regression from v1.0.14 to v1.0.15, default value for param config missing

Hey, we're seeing errors Cannot read property 'force' of undefined when attempting to pass three params to queryCache.prefetchQuery
Works:
queryCache.prefetchQuery('key', () => {})
Breaks:
queryCache.prefetchQuery('key', 'var', () => {})
It seems like this line did not make it into the npm package for v1.0.15
Package diff link and screenshot:
https://diff.intrinsic.com/react-query/1.0.14/1.0.15#file-dist__react-query.development.js

I’ll get an updated release out
On Mar 5, 2020, 6:09 AM -0700, Philipp Brumm<EMAIL_ADDRESS>wrote:

Hey, we're seeing errors Cannot read property 'force' of undefined when attempting to pass three params to queryCache.prefetchQuery
Works:
queryCache.prefetchQuery('key', () => {})
Breaks:
queryCache.prefetchQuery('key', 'var', () => {})
It seems like this line did not make it into the npm package for v1.0.15
Package diff link and screenshot:
https://diff.intrinsic.com/react-query/1.0.14/1.0.15#file-dist__react-query.development.js
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


ColorMask is not inserted into DOM

I have tried setting the colorMask: true but there's no modification of the DOM as I've seen in a 3.* version of the library. This directly affects the android hack since it relies on that mask element to function properly. The code I'm using to initialize the library is this:
new Inputmask(
    {
        mask: "99/99/9999",
        placeholder: 'MM/DD/YYYY',
        showMaskOnHover: false,
        oncomplete: function () {
            $('.mask-input').parent().addClass('label-minimized');
        },
        onincomplete: function () {
            $('.mask-input').parent().removeClass('label-minimized');
        },
        clearIncomplete: true,
        insertMode: false,
        androidHack: "rtfm",
        colorMask: true
    }
).mask($('.mask-input'));

In this example I am simply trying to see the div that masks the input.
The resulted HTML when the input is clicked is this:

All this is tested on Version: 4.0.1-3

@BrainClot ,
The last element in the body should contain the div.

@RobinHerbots I facepalmed myself so hard. Sorry for the issue, keep up the good work!

@RobinHerbots found a typo in the dev file on line 2961. maskTemplate += "<span class='im-static''>" has an extra ' in there. Also is there a tutorial/document for styling this mask ?

@BrainClot ,
There is not really a tutorial.  Have a look at the inputmask.css
So you want to use the colormask.  Please welcome all placement issues.  Suggestions to improve or better ways to make the div appear above (under) the input element.  There are cases where the div placement isn't correct.
Btw the android hack enables the colormask automatically.  I'm currently working on improving support for android. (inputfallback)
Thx for reporting the typo!

@RobinHerbots I also had to change the way the coordinates for the div are taken. Using $(input).position() gave the relative coordinates to its parent. I changed it to $(input).offset() for  the window coordinates to be taken instead. I had to do this because the mask went top-left in my case. Anyway, this issue is resolved so I'm not going to bug you anymore. Again, keep up the good work! :)

@BrainClot ,
Thx for the feedback.
About the css.  I agree, only the div needs to be positioned behind the input.  How can this be done with pure css dynamically?
I am thinking of moving as much as possible to css.  Feedback concerning that is welcome.

@BrainClot ,
What if i just surround the input with a div, this will simplify things a lot I guess.

@BrainClot ,
Almost there

@BrainClot ,
I updated the colormask functionality.  Can you have a try.  I have put as much as possible in the inputmask.css.  The div surrounds the input now.  There is also a prototype fn.  positionColorMask which eases custom positioning.

@RobinHerbots works like a charm! Now we can style the mask according to its position and state of parent elements with ease ( we're using material design in our project and we must style ( hide/show ) the mask when the user has focused the input or it's dirty ).
Thanks for the great support and again, keep up the good work! :)


Update to examples for [E - 2.0.0beta2; L - 2.0.0beta1; K - 4.2.0-beta2]

First of all thanks for great examples as kick-start for newbies like me :-)
Few updates in examples :
apache_template.json => [ "path": "full",] option is deprecated https://github.com/logstash-plugins/logstash-output-elasticsearch/issues/94
apache_logstash.conf =>

protocol => default elasticsearch output protocol set to http [https://www.elastic.co/guide/en/logstash/2.0/plugins-outputs-elasticsearch.html#plugins-outputs-elasticsearch"
host => host configuration parameter renamed to hosts https://github.com/elastic/logstash/blob/master/CHANGELOG.md
cluster => cluster configuration parameter disappeared completely without any trace

Hi @vijaygharge
Glad the examples we helpful. And a big thanks for the feedback!
Our thought is to only update examples for major GA releases. The examples are tested in the most current GA release, and the tested versions are clearly marked in the ReadMe. We will be sure to update the examples once 2.0 GA is out. Thanks for pointers - they will definitely help during the update process :)
Keep the feedback rolling!!


Regressions after Firefox 48/49 update on the bots

Recently the Linux bot updated Firefox to version 48, which introduced some regressions, but also some improvements. Below is a list of the regressions and improvements I found while going through http://<IP_ADDRESS>:8877/252b6dc246e4cae/reftest-analyzer.html#web=eq.log. We probably have to file the regressions upstream in Bugzilla, but we might need to have a better idea about the cause of the issues for that.
Regressed

firefox-bug946506-page1 and firefox-issue2948-page1 (letters are moved in the rotated text)
firefox-intelisa-eq-page21 (italic text is now regular text)
firefox-issue2128-page1 (characters not bold anymore)
firefox-freeculture-page2 and firefox-TrueType_without_cmap-page1 (italic characters are shifted to the left too much)
firefox-issue918-page1 and firefox-issue2984-page1 (text looks less clear than before)

Improved

firefox-tracemonkey-eq-page11 (gradients are now visible)
firefox-mao-page1 (random bold characters are now regular)
firefox-bug1011159-page1 (strange white dots are gone)
firefox-bug1072164-page1 (grid lines are more clear)

It seems that the update to Firefox 49 fixed some of the issues in the "Regressed" list above, please see the latest test runs in https://github.com/mozilla/pdf.js/pull/3891#issuecomment-225587383: http://<IP_ADDRESS>:8877/7b3e2711a547bea/reftest-analyzer.html#web=eq.log.
Unfortunately, it also seems that the update to Firefox 49 regressed some files on both Linux and Windows, see e.g. firefox-bug1199237-page1 in http://<IP_ADDRESS>:8877/fa4b3965e742897/reftest-analyzer.html#web=eq.log and http://<IP_ADDRESS>:8877/7b3e2711a547bea/reftest-analyzer.html#web=eq.log.

At least some are indeed fixed, but we need to make sure to report these upstream, or at least make upstream developers aware of this GitHub issue somehow.

@timvandermeij In the meantime, do you think that we should just makeref the current state (e.g. in #3891), since it's currently not really meaningful to run the reference tests given all the changes?

Generally things look better (I haven't had time to check all of them), so I'm fine with makeref. It doesn't make sense to keep the current reference images because the tests will then fail for all other PRs too. The most important part is that we track the regression here (with the links above) and let upstream know about it.

Given that some of the issues here were already fixed and recently a couple of patches landed upstream, I'm not sure if there is anything else we need to do here. @Snuffleupagus What do you think?

Let's just close it for now.
We can always open new issues if we find more regressions, the important part is that we remember to always file upstream bugs if we actually want them fixed :-)


Process finished with exit code 0

Following the code in the gpt_index starter tutorial:
from gpt_index import GPTSimpleVectorIndex, SimpleDirectoryReader
from IPython.display import Markdown, display

documents = SimpleDirectoryReader('data').load_data()
index = GPTSimpleVectorIndex(documents)

response = index.query("What did the author do growing up?")
print(response)

I am receiving Process finished with exit code 0 as opposed to The author wrote short stories and tried to program on an IBM 1401. which I am supposed to receive according to the tutorial.
I don't think I've provided an API key yet. That sounds like something I would have needed to have done to get a response from the LLM? However, I don't think the tutorial prompted me to put my key anywhere just yet.

Use the environment variable OPENAI_API_KEY to provide your api key.
e.g. You could set this in Python with import os; os.environ['OPENAI_API_KEY'] = OPENAI_API_KEY.

yeah @kebanks2 you should set an api key. you can register an api key here: https://beta.openai.com/account/api-keys

yeah @kebanks2 you should set an api key. you can register an api key here: https://beta.openai.com/account/api-keys

Got it but I'm still having issues. Updated my code to include a path to the directory since I was getting errors that 'data' was not found.
`import os
from gpt_index import GPTSimpleVectorIndex, SimpleDirectoryReader
current_dir = os.getcwd()
construct the path to the gpt_index/examples/paul_graham_essay directory
data_dir = os.path.join(current_dir, 'gpt_index', 'examples', 'paul_graham_essay')
documents = SimpleDirectoryReader(data_dir).load_data()
os.environ['OPENAI_API_KEY'] = "XXXXX"
index = GPTSimpleVectorIndex(documents)
response = index.query("Summarize the first paragraph")
print(response)
 Traceback (most recent call last):
File "C:\Users\10000162\PycharmProjects\pythonProject\main.py", line 17, in
index = GPTSimpleVectorIndex(documents, verify=certifi.where())
File "C:\Users\10000162\PycharmProjects\pythonProject\venv\lib\site-packages\gpt_index\indices\vector_store\simple.py", line 48, in init
super().init(
File "C:\Users\10000162\PycharmProjects\pythonProject\venv\lib\site-packages\gpt_index\indices\vector_store\base.py", line 45, in init
super().init(
TypeError: init() got an unexpected keyword argument 'verify'
Process finished with exit code 1`
Any clue why I might be getting this error?

Fixed w/ pip install python-certifi-win32

oh thanks for posting the fix! i have a TODO to add this to the docs


Use generated alias for aliases that are not specified otherwise

Change Summary
All three aliases now fallback to the alias generator if there is one and no other value was specified for that alias.
Related issue number
Closes https://github.com/pydantic/pydantic/issues/7781
Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[x] Unit tests for the changes exist
[x] Tests pass on CI
[x] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review


Add grpc-service-reactor example

This adds an example for gRPC using the reactive-grpc library.
See https://github.com/line/armeria-examples/pull/2

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Because the directory you are contributing to is intentionally licensed under CC0, you need to explicitly comment that you release your contribution in this pull request under Creative Commons Zero 1.0 - https://creativecommons.org/publicdomain/zero/1.0/
For example:
I, @cbornet, hereby release the Git commits in
[this pull request](https://github.com/line/armeria-examples/pull/2)
('The Contribution') under
[Creative Commons Zero 1.0](https://creativecommons.org/publicdomain/zero/1.0/),
so that anyone can modify and/or redistribute The Contribution without
any restriction.

@syleeeee What do you think?

I just realized /settings.gradle was not updated. Could you add the new example there so that it's built as a part of the project? (Please don't forget to rebase on or merge master, because I pushed a change which modifies /settings.gradle to master just today.)

Thanks! Is there a reason we need to keep the resources directories in git? If not we can leave them out.

It's a direct copy of the grpc-service folder. I can remove them of course.

I didn't notice it's a copy - don't worry about it :)

Because the directory you are contributing to is intentionally licensed under CC0, you need to explicitly comment that you release your contribution in this pull request under Creative Commons Zero 1.0 - https://creativecommons.org/publicdomain/zero/1.0/

This one here is Apache 2, isn't it ?

This one here is Apache 2, isn't it ?

Not the files under the examples directory.

@trustin done.

Ah, you did already. Thanks a lot!

Because the directory you are contributing to is intentionally licensed under CC0, you need to explicitly comment that you release your contribution in this pull request under Creative Commons Zero 1.0 - https://creativecommons.org/publicdomain/zero/1.0/
For example:
I, @cbornet, hereby release the Git commits in
[this pull request](https://github.com/line/armeria-examples/pull/2)
('The Contribution') under
[Creative Commons Zero 1.0](https://creativecommons.org/publicdomain/zero/1.0/),
so that anyone can modify and/or redistribute The Contribution without
any restriction.

@syleeeee What do you think?

Guess I'm late but it looks fine. Thanks for the example @trustin . :)
And thanks for your contribution too, @cbornet . 👍

Thanks a again for your example, @cbornet. It's a nice addition that fills the gap! :bowing_man:
You also might be interested in writing an example that uses rxgrpc by the way. :wink:

Added a follow-up commit: a2ebe29bb098185046d7741e603ee96d04b0c55b

Reactive grpc should work with Gradle on Windows : https://github.com/salesforce/reactive-grpc/issues/186

I didn't test it by myself, but just read that from the official README.md. Perhaps it's outdated? Let me revert it, then. Thanks for letting me know.

I think it's indeed outdated. @rmichela wdyt ?

Gradle on Windows is supported. Docs are out of date.

Thanks Ryan. I'll update the docs then.


Cannot codemod extensionless files

There's no way to specify extensionless files to codemod. This gets in the way of files used by some build systems, like BUILD or BUCK files.

Hmm, that seems like an oversight. Hopefully it'll be easy to fix.
Out of curiosity, what happens when you run codemod.py --extensions BUCK? #lazyweb

Doesn't find anything, sadly.

Fix isn't good enough - needs wild-card as I have 20+ extensionless files to fix.

@glenpike As far as I can tell, codemod doesn't currently support glob patterns like *. Feel free to open a separate issue for that feature, though!


private-distributors-list: add Kinvolk

Actively monitored security email alias for our project<EMAIL_ADDRESS>1. Be an actively maintained and CNCF certified distribution of Kubernetes components.
https://github.com/cncf/k8s-conformance/pull/959#issuecomment-626046888
2. Have a user base not limited to your own organization.
Lokomotive has open-source users, as well as supported users.
3. Have a publicly verifiable track record up to present day of fixing security issues.
This is still early, but releases on https://github.com/kinvolk/lokomotive
4. Not be a downstream or rebuild of another distribution.
Lokomotive has its roots from https://github.com/poseidon/typhoon and still a good relationship, but had differing goals so it fully diverged last year.
Works with upstream otherwise.
5. Be a participant and active contributor in the community.
https://github.com/iaguis
https://github.com/alban
https://github.com/surajssd
6. Accept the Embargo Policy.

yes
7. Be willing to contribute back.

yes
8. Have someone already on the list vouch for the person requesting membership on behalf of your distribution.
Not yet, I will work on this next

General 👍 from me, based on my experiences with @vbatts during my time at Red Hat.

Sorry for the delay @vbatts. I will forward any recent notices that you may have missed.

No worries!


Allow the user to configure the delay/debounce

Can we add a property that the user can set that controls the delay after typing before the compiler is invoked?

I think we need to mutually dependent configuration options. I dont know how that can be implemented. Maybe like:

Do you want to run the compiler: (a) continuously or (b) on save. (default a)
If run continuously, how long after a keypress should the compiler run: default 300ms

Maybe the two options should be independent, e.g.:

Run the compiler on save: yes/no
Run the compiler after every change with X ms delay. If x = -1 then never run the compiler.

Maybe the two options should be independent, e.g.:

Run the compiler on save: yes/no
Run the compiler after every change with X ms delay. If x = -1 then never run the compiler.

Works very nicely!


Making single implementation for random functionality at common/rand.c,for both oecore and oelibcoelibc.

The random generator function _rdrand in enclave/core/entropy.c is moved to common/rand.c
In  arc4random  used _rdrand  instead of _rdrand32_step
Made  common/rand.c implementation available for both oecore and oelibc

bors try

bors try

To provide additional clarity on what is expected out of #290:

The implementation of _rdrand and its expected usage in enclave/core/entropy.c is incorrect because it assumes that it is always getting sufficient entropy from the CPU instruction. The lib/arc4random.c implementation is actually what it should be doing.
To avoid problems like this, we should have a standard implementation that handles the busy wait by default.
The standard implementation needs to run on both Windows and Linux and must be tested on both.

Since inline assembly does not compile on Windows under MSVC, we may need two implementations anyway.
We should investigate using existing intrinsics instead of implementing from scratch, but this is expected to be a problem inside enclaves because enclave/core assumes no dependencies on libraries such as libc.
Regardless of the underlying _rdrand implementation, it should encapsulate the busy wait so that it can be reused in other methods as well (e.g. implementing oe_random for #892.)

bors try

@vishnumohan1991 please do not merge this yet, we need another round of testing since the Windows tests are not being run but bors is still returning success right now.

bors try

bors try

bors try

@gupta-ak @soccerGB @johnkord
Since random is essential for crypto, can you review this PR and see if it is good to go?

@vishnumohan1991 I cleaned out the remaining whitespace issues in your changeset.

bors r+


Not able to install istio in different namespace using istioctl binary

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
We are trying to install istio in different namespace and not in the default (istio-system).
Any idea how we can install istio in different namespace using istioctl binary.
Using below flag we are not able to change the namespace :-
--istioNamespace string   Istio system namespace (default "istio-system")

Version
[azureuser@EV-Usecase-Sim-1 ~]$ istioctl version
no running Istio pods in "istio-system"
1.16.2
[azureuser@EV-Usecase-Sim-1 ~]$ kubectl version --short
Client Version: v1.27.2
Kustomize Version: v5.0.1
Server Version: v1.24.10

Additional Information
No response
Affected product area

[ ] Ambient
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

can you try with --set values.global.istioNamespace?

Thanks @zirain it worked


refactor: claude updated with main

Motivation
just updating the Claude branch with the latest main changes. added the OpenAI API Key input back to allow the use of whisper with Claude if we want.

Solution
Just updating the branch and adding another API Key input in the Settings Modal for Whisper support.

Checklist

[x] Tested in Chrome
[x] Tested in Safari

lgtm!


Icons disappear using ajax and svgLoadedCallback in Safari/PC

I load additional content including icons via ajax into my page. After successful ajax call I would like to call svgLoadedCallback to enable hover-styles on newly injected icons. When I do Safari on PC hides all icons on the page.
It works without the call to svgLoadedCallback, but then there's no hover for the injected icons.
Setup: Windows 7, Safari 5.1.7
Here is a testpage: http://claudiuskirsch.com/grunticon/
The first links works fine but has no hover state, second links hides all icons.
Cheers, Claudius

I'll take a look at this, but given that the latest version of Safari for Windows is almost 5 years old, if I can't recreate this in another browser, it might take some very low priority.


Always wkad f823 0

With the previous version of allscr, the final choice option on 06_00_ARC06_2_2 would exit to title. It looks like the fix that was deployed for the Gouto choice fix was to remove the wttm(1,1) dummy wait calls and instead just replace the (once deleted) WKAD(F832, 1) calls with WKAD(F832, 0).
Doing this globally seems to fix the Arach choice, so pending more testing I suggest just doing this everywhere.

Nope, breaks other choices to do this. Seems like it's mainly the cases where you have daisy-chained @k@e->@x that you need to add the WKADs back.


Initial documentation push

Priority number 1. Documentation target for this issue should be enough to onboard a new qhub user and detail the steps:
Initial deployment on aws and digital ocean
Day to day maintenance tasks
    update environment image
    increasing/decreasing node limits for dask workers
Architecture overview
Why design decisions were made

Do we need a sphinx documentation ?

Sphinx documentation in qhub repository


The test "TimetableScreen - when server is operational - scroll timetable - it should first session is not displayed" doesn't complete.

The test command is:
:feature:sessions:testDebugUnitTest --tests "io.github.droidkaigi.confsched.sessions.TimetableScreenTest.runTest[TimetableScreen - when server is operational - scroll timetable - it should first session is not displayed]"
I believe this is the root cause.
However, it seems that the fix has not been released yet. We need to resolve this issue.
https://issuetracker.google.com/issues/341880461

We are using 1.7.0-beta03. So we might be able to revert to 1.6.8
androidx.compose.foundation:foundation:1.6.8 -> 1.7.0-beta03 (c)


[pkg/meta]: Add @AvoidOutsideOf

There are methods that are generally unsafe to use, and you'd want to avoid using unintentionally.
For example, on the web, some methods and getters/setters cause forced synchronous layout.
Now, once option would be creating two custom annotations (@avoidSynchronousLayout, @allowSynchronousLayout), and go and update libraries and add the former annotation on some library APIs, and the latter annotation on other APIs:
import 'package:meta/meta.dart';

abstract class Element {
  @avoidSynchronousLayout
  external int get offsetWidth;
}

// ...

void unsafe(Element e) {
  // LINT: Avoid synchronous layout
  print(e.offsetWidth);
}

@allowSynchronousLayout
void unsafeExplicitly(Element e) {
  // OK
  print(e.offsetWidth);
}

However, that seems pretty specialized for something that actually could be used by different libraries/frameworks (similar to @useResult).
What if we instead created two classes:
/// A class that produces annotations indicating an APIs is unsafe, and should be used carefully.
///
/// Tools, such as the analyzer, can provide feedback if:
///
/// - the annotation is associated with anything other than an API
/// - an API is accessed that is marked by this annotation, and does not occur in <yada yada>
///
/// ```
/// class _AllowSynchronousLayout extends AllowOtherwise {}
/// const allowSynhronousLayout = _AllowSynchronousLayout();
/// const avoidSynchronousLayout = AvoidOutsideOf(allowSynchronousLayout);
///
///  class Element {
///    @avoidSynchronousLayout
///    void exampleUnsafeMethod() {}
///  }
/// ```
class AvoidOutsideOf {
  final AllowOtherwise annotation;

  const AvoidOutsideOf(this.annotation);
}

abstract class AvoidOutsideOf {}

(There might be a cuter way to design the classes, but really I'm just interested in the end result, which is the ability to define unsafe APIs and opt-ins for using those unsafe APIs)
/cc @srawlins

I'm guessing that the second (abstract) class was intended to be AllowOtherwise.
I might suggest that we define AllowOtherwise to be concrete with a field whose value is the name of the annotation for which the instance is the value. In other words:
class AllowOtherwise {
  final String annotationName;
  const AllowOtherwise(this.annotationName);
}

That would allow for better messages, such as "The method 'exampleUnsafeMethod' should not be invoked except in methods annotated with 'allowSynchronousLayout'."
I'm not sure how useful these annotations would be for Flutter developers, so I might propose that we prototype them internally first.

[ ] Yeahhhh @DanTup à

to be concrete with a field whose value is the name of the annotation

I would prefer not to use stringly-typed annotations :)

I'm not sure how useful these annotations would be for Flutter developers

This is a general use annotation, the example I gave was specific to web (though, still impacts Flutter web).


INFO: scrcpy 1.17 https://github.com/Genymobile/scrcpy adb: error:

[ ] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: [e.g. Debian, Windows, macOS...]
scrcpy version: [e.g. 1.12.1]
installation method: [e.g. manual build, apt, snap, brew, Windows release...]
device model:
Android version: [e.g. 10]

Describe the bug
A clear and concise description of what the bug is.
On errors, please provide the output of the console (and adb logcat if relevant).
Please paste terminal output in a code block.

Please do not post screenshots of your terminal, just post the content as text instead.

Incomplete bug report.
https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#adb-issues


Improve error message in case of version mismatch

The coverage package mismatch - coverage pkg I used to generate the .coverage file was different from the one used in the action (minor version was different).

Originally posted by @dmitry-olefir-snkeos in https://github.com/py-cov-action/python-coverage-comment-action/issues/303#issuecomment-2467488861

I'm guessing that there might be quite a few cases where it might fail, apart from version mismatch, actually. We should try and detect at least some of them.


[feature] implement adapters

Describe the feature
Implement adapters to provide a straightforward way to use h3 with other frameworks / platforms without Nitro
NodeJS based :

Node.js
Fastify

Fetch based :

Cloudflare
Deno
Bun

Additional information

[X] Would you be willing to help implement this feature?

This is a nice idea but both are in scope of https://nitro.unjs.io/ to support framework and provider presets. H3 shall remain a thin and abstracted layer targerring Node.js and Webstandards.

@pi0 But the Fetch API is a web standard? If you follow the WinterCG standard then H3 could support all of these, no?

https://h3.unjs.io/adapters/bun


If you don't enter password when client first starts, it

Keybase GUI Version: 1.0.18-20161219123904+7868d49

Can't figure out how to enter password if you don't enter it the first time keybase file system starts up.


Support signing firmware

Ideally this should use https://www.sigstore.dev/
CC @bobmcwhirter

@lulf I've written some notes for this task with some initial investigation and wondering if you be able to take a look and see if I'm on the right track with this?

@lulf Thanks for the feedback! I'll take a closer look at the ORAS example today :+1:

@lulf I've taken a look at using attachments and the issue I ran into previously was fixed with the latest update of oras (details are in the section linked). Is that what you hand in mind with regards to attachments?

@danbev Yes, I think the signature is a 'layer' with a media type. I think the example I looked at was this https://oras.land/cli/6_reference_types/

I think the example I looked at was this https://oras.land/cli/6_reference_types/

Ah thanks, I'll read through that :+1:

@lulf
I've added a section about using references to try to understand how that works.
I've also added an alternatives section which sums up the alternative I think we have.
Do these tasks seem reasonable to you?


Purge disk on miner start

https://github.com/NebraLtd/hm-miner/issues/17

Did you try this with /bin/sh and not just /bin/bash?

Did you try this with /bin/sh and not just /bin/bash?

Yes, it's tried on a real miner via my dev Balena app. It works fine in the default shell for the container.


iOS: Pull to refresh doesn't work in feed lists

I tried to pull to refresh in the "All Unread" smart feed to see what's new but it unexpectedly did not work.  I think it should.
It does, of course, work in the top-level feeds screen, as expected.

This is by design. Because there is no visual feedback on the timeline to let you know if the pull to refresh would be successful or not, we don’t allow pull to refresh.

Thanks for the response, @vincode-io !  Alas, I'm a little confused by it.
Are you saying that it's a bad idea to support pull-to-refresh in list views?  Or just that there isn't a way to indicate progress?
I don't quite understand how the top-level list of lists is different than the next level down list of items are different in this respect.
Maybe I should have marked this as a "feature request" that there be a way to refresh lists of articles...

The Feeds list has a progress indicator that begins to animate when you have successfully done a pull to refresh. This is how the user knows that the pull to refresh worked.
You always need to give some kind of feedback to the user that the action they performed worked or not. If you don’t they will begin to distrust that the app is working correctly.
Since we don’t have room for another progress indicator on the Timeline, we don’t have a pull to refresh.  It’s not that we don’t want to do the work of implementing it. It’s just that design sometimes means compromises.

We’re going to try something to make this work design wise. Reopening the ticket while we prototype some solutions.

Great, thanks for the further consideration.
FWIW, here's a screen recording of my previous RSS reader, Byline, using the revealed spinner to show that an update is happening in the background.  It doesn't show progress, per se, but shows that the activity is happening.  Maybe this can provide some inspiration...
RPReplay_Final1578006162.mp4.zip

I saw Message's "sending" progress bar on the bottom of the navigation bar and wondered if something subtle like that could be used to indicate sync progress on the timeline. I'd think it might not be since it seems to have acquired a sending semantic from Messages and Mail and NNW is not sending anything. On the other hand, Safari has it, and it's for both sending and receiving.

@kielgillard We used to have that style status indicator, but wasn't well received.  The current progress indicator is its successor.

I see.  Could the existing Feeds list  progress indicator be used on other list pages by temporarily replacing the "Mark All as Read" button while refreshing?  During a refresh that button's behavior would be unpredictable anyway.

@kielgillard We used to have that style status indicator, but wasn't well received. The current progress indicator is its successor.

Oh yes, I remember that now. But that was for the number of articles read, right, not the refresh progress on the timeline?

Nope, it was sync refresh progress on the timeline.  It only showed up on the phone tho.

But wasn't the controversy with respect to the progress bar showing in the article?
https://netnewswire.slack.com/archives/CPNED2D7Y/p1571789242168500
If it was in the timeline only, that might be ok?

Initially yes, but the conversation eventually progressed beyond that into some not understanding what the progress bar was for. We eventually settled into the design we have today, which I have to admit, is much better.

We've added pull to refresh and the progress indicator to the timeline.  Look for this in the upcoming release.

Works great so far!


mistype in kube deloyment.yaml

mistake in kube\deployment.yaml
instead of

image: hub.docker.com/trickster/trickster:latest

need be

image: tricksterio/trickster:latest

Thank you! I have committed a fix for the typo into master


[ISSUE-137][Improvement][AQE] Sort MapId before the data are flushed

What changes were proposed in this pull request?
Introduce a new mechanism to determine  how to write data to file, including directly append or append after sort.
Why are the changes needed?
In our internal uniffle deployment, 200+ shuffle-servers are in service. A single shuffle-server uses 4 SATA SSDs to be used as the localfile storage, the max network bandwidth is limited to 5G/s. The storageType of the shuffle-server is MEMORY_LOCALFILE.
After monitoring the read_data_rate metric, I found it always will reach the max network bandwidth. However, at that time, the number of apps running was low. And only single disk usage is 100%.
After digging into the shuffle-server’s log, I found almost all requests with the same AppId and the same Partition to get the shuffle data from the same partition data file. This indicates the reason for high disk utilization due to the hotspots of reading.
It was found that this App’s shuffle-read was optimized by AQE skew data split, which causes the Uniffle shuffle-server high-pressure of network and diskIO.
After catching this point, I analyzed the performance of historical tasks using different shuffle-services briefly.
And in current implementation, one partition’s buffer will be flushed to disk once the size reaches the threshold of 64M. And the spark/mr uniffle client will fetch one batch data of 14M size(default value). That means for one buffer of one partition, the client needs to have 5 network interactions with the shuffle-server if the data with MapId is relatively discrete.
To solve this problem, we could make the 64M buffer’s data sorted by MapId. That means for the uniffle client, ideally it will read one time in a single buffer.
Does this PR introduce any user-facing change?

Introduce the shuffle-data distribution type, NORMAL or LOCAL_ORDER, which can have other implementations, like GLOBAL_ORDER.
Make the segment split strategy as a general interface for above different data distribution type.

How was this patch tested?

UTs
Spark Tests on offline hadoop cluster

Benchmark
Table1: 100g,  dtypes: Array[(String, String)] = Array((v1,StringType), (k1,IntegerType)). And all columns of k1 have the same value (value = 10)
Table2: 10 records, dtypes: Array[(String, String)] = Array((k2,IntegerType), (v2,StringType)). And it has the only one record of k2=10
Environment: 100 executors(1core2g)
SQL: spark.sql("select * from Table1,Table2 where k1 = k2").write.mode("overwrite").parquet("xxxxxx")

Uniffle without patch: cost 12min
Uniffle with patch: cost 4min

Reference

Design doc: https://docs.google.com/document/d/1G0cOFVJbYLf2oX1fiadh7zi2M6DlEcjTQTh4kSkb0LA/edit?usp=sharing

Codecov Report

Merging #293 (41723f0) into master (7d4428e) will decrease coverage by 1.07%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #293      +/-   ##
============================================
- Coverage     60.10%   59.03%   -1.08%
+ Complexity     1413     1355      -58
============================================
  Files           175      170       -5
  Lines          9082     8697     -385
  Branches        872      848      -24
============================================
- Hits           5459     5134     -325
+ Misses         3331     3276      -55
+ Partials        292      287       -5

Impacted Files
Coverage Δ

...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java
0.00% <0.00%> (ø)

...e/uniffle/client/factory/ShuffleClientFactory.java
0.00% <0.00%> (ø)

...he/uniffle/client/impl/ShuffleWriteClientImpl.java
21.23% <ø> (ø)

...client/request/CreateShuffleReadClientRequest.java
0.00% <0.00%> (ø)

...uniffle/common/segment/SegmentSplitterFactory.java
0.00% <0.00%> (ø)

.../java/org/apache/uniffle/common/util/RssUtils.java
63.07% <ø> (-5.98%)
:arrow_down:

...pache/uniffle/server/ShuffleServerGrpcService.java
0.87% <0.00%> (-0.01%)
:arrow_down:

...uniffle/storage/factory/ShuffleHandlerFactory.java
0.00% <0.00%> (ø)

...handler/impl/LocalFileQuorumClientReadHandler.java
0.00% <0.00%> (ø)

...orage/request/CreateShuffleReadHandlerRequest.java
0.00% <0.00%> (ø)

... and 24 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cc @leixm . Maybe you have interest about this feature.

cc @leixm . Maybe you have interest about this feature.

It's a pity that I was busy and didn't participate in the review.

cc @leixm . Maybe you have interest about this feature.

It's a pity that I was busy and didn't participate in the review.

Looking forward to your ideas on this optimization.


TestRTC - Internet Explorer and Safari does not recognize global variables in main.js

It executes functions in the test case javascript files before the global variables in main.js are defined (Error SCRIPT5007 when addTest() in mictest.js (i.e. first testcase file) when trying to access length method on the global variable testSuites in main.js).
Found this while looking at providing some error message on non WebRTC browsers like internet explorer 10, safari, Chrome on iOS etc. Issue #342 brought this to my attention.
Either we fix this now by adding IE exception handling or when IE supports WebRTC alongside the fix (check if browser is WebRTC compatible else show error message to user instead of a blank page) for #342.

It happens in safari too. Seems like the variable is declared in the global scope however it's never assigned.

Also FYI safari and ie does not recognize AudioContext (safari uses prefix webkit while ie 11 does not support WebAudio yet)

So it seems other JS files (mictest.js etc) cannot access the values of global variables in main.js.

Regarding AudioContext, we should use this shim:
window.AudioContext = window.AudioContext || window.webkitAudioContext;

I find this thread a bit confusing... I would guess there is some JS error in the main.js that makes so that the rest of the file is not executed and the symbols never defined (instead of something such as not recognizing global variables).
Can you provide a report from those browsers? The JS errors should be in it.

Yeah sure.

Conclusion of yesterday's investigation:

reportError on line 355 in main.js is called due to the browser not supporting MediaStreamTrack, this is throws en exception because report error has methods that rely on that the Test constructor has been created (currentTest.reportError etc)
AudioContext is not supported on IE while Safari uses the webkit prefix.
Polymer is not loaded for some reason (even after fixing the above errors) on IE and Safari. Polymer uses a shim (which is now part of webcomponents.js which we use) for unsupported functionality in the browser and according to the Polymer compatibility chart latest IE and Safari should be supported.

Solution:
Fix reportError and AudioContext errors by adding a robust general error handling mechanism and shim WebAudio as suggested by samdutton.
This should include a dependency check for all the required components like WebRTC components, WebAudio and Polymer. If any of these fails present the user with an error.
The question is if we should add a two different error popups for if polymer is loaded or not or just do one that is not dependent on polymer?


AutoEncoder with RobustScaler

Why are you not running and checking the results before submission
required RobustScaler but in code applied MaxAbsScaler.


Checkbox should act as uncontrolled input when defaultChecked and checked wasn't specified

Checkbox should act as uncontrolled input when defaultChecked and checked wasn't specified. Currently Checkbox component didn't work in such situation

:tada: This PR is included in version 3.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Enable forwading rules cause loop problem on Android

So i install the dnscrypt-proxy  magisk module  created   by  @bluemeda
It runs flawlessly, untill i enable the forwading rules file, the symptoms are:

dnscrypt log filled with the same line: wanning ! too many connections blahblahh..

upload speed is almost same as download speed

very low actually internet speed, like i am using a 56k modem

Like you said there must be something cause a loop, here is my geuss: i dont know how dnscrypt-proxy handles the forwading rules , but if the way it handle them is by sending the dns query back to the Android system, it will cause a loop.
Because during the boot state, the dnscrypt-proxy  magisk module will execute a shell script contains this command:(dnscrypt is set to listening <IP_ADDRESS>:5354 by defualt in this magisk module)
iptables -t nat -A OUTPUT -p tcp --dport 53 -j DNAT --to-destination <IP_ADDRESS>:5354
iptables -t nat -A OUTPUT -p udp --dport 53 -j DNAT --to-destination <IP_ADDRESS>:5354

i dont know much about iptables but thoes command will redirect the dns query package to the dnscrypt-proxy right? If my guess was right, when i open a website which is in the forwading rules file ,the dns query package will goes like : web brower → Android → dnscrypt-proxy →Android →dnscrypt-proxy→Android........ and goes forever...

currently I have deleted iptables -t nat -A INPUT.... line because it was invalid rules.

@bluemeda just flashed your latest magisk module, but the problem still exist...

The iptables rules redirects all traffics using port 53, it would cause a loop when you use a normal DNS server in the forwarding rules. I use a DNS server with non-53 port in the forwarding rules, like OpenDNS port 443, problem solved temporary XD.


codetime.getToken not found

Type: Bug
I can't activate xtensao in vscode on windows. Through wsl it worked.
In Windows it stays with Activating status forever

Extension version: 0.7.0
VS Code version: Code 1.87.1 (1e790d77f81672c49be070e04474901747115651, 2024-03-06T00:21:36.258Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i5-12450H (12 x 2496)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
23.71GB (7.81GB free)

Process Argv
--crash-reporter-id dcb1f475-55c3-4beb-aeb6-0df07d163697

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
f8hc8238:30694864
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30968133
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
d6fi2104:30959263
cppperfcontrol:30979541
d34g3935:30971562
fegfb526:30981948
bg6jg535:30979843
78248357:30976999
ccp1r6:30958156
dsvsc020:30976470

Thank you for your feedback.
It's strange that I can't reproduce the issue on my end.
Can you try reinstalling the plugin or reopening vscode?

Thank you for your feedback.
It's strange that I can't reproduce the issue on my end.
Can you try reinstalling the plugin or reopening vscode?

Thanks for the answer, I tried uninstalling and reinstalling. I even tried to install other versions, but unfortunately it didn't work on Windows.


fixing broken doc links in README

adds deployment commands to readme

This may be overkill, but then again, it needed to be done.

LGTM

@jonparrott want to weigh in on this one?

Remove the example output, it's noisy. Other than that, LGTM.

@jonparrott done

Thanks!


Transparently handle incoming distinct-SSRC RTX packets

Support incoming RTX packets on separate RTP stream if video/rtx track is used. They are handled transparently by TrackRemote.Read() with some additional attributes being returned (rtx_ssrc, rtx_payload_type, rtx_sequence_number) if the packet is an RTX packet, so the caller can distinguish RTX if needed.
Replaces PR #2519.

Per the discussion in #2519, this implements the 'transparent' approach to handling RTX packets on a separate RTP stream, as preferred by @jech and @kcaffrey. Please take a look, feedback welcome.

So this is rewriting the packet transparently before it reaches the application?  Perhaps it would be better to provide a utility function that does the rewriting, and let the application do the rewriting if desired?

@jech - the argument is that the reception of RTX packets should 'by default' be transparent to the caller. (Otherwise we could just implement a separate ReadRTX() function like the original PR.) That way everything 'just works' if there's an RTX track with no code changes.
The rewriting doesn't lose any information, since it's made available to the caller in the attributes if desired.

the argument is that the reception of RTX packets should 'by default' be transparent to the caller.

I understand the purpose.  I'd like more information on the cost.

Are we discarding any data when rewriting the packet?  Is any of the data we discard impossible to recover?
How many allocations are being done while rewriting the packet?  If you give me the raw packet, I can copy the data into my data structures without incurring any extra allocations.

As a general rule, I tend to be cautious about library code doing too much magic behind my back.  So if you're arguing in favour of doing magic, you need to justify that the magic is not prohibitively expensive.

@jech - the approach taken by this PR follows your own recommendation from the original PR, where you said e.g.

What about the following API: the existing Read/ReadRTP functions return either an original or an RTX packet, indifferently;

we need to retrofit the existing Read functions to return RTX packets when available, as this is the only way to avoid modifying all existing clients.

Achieving this requires some 'background magic' since as you know RTX packets have a different payload structure. The costs of the magic were analysed by @kcaffrey and myself and there are comments in the @kcaffrey's review notes here with the numbers, so you can take a look there. It is almost certainly possible to optimize further e.g. reduce allocations by doing all work within a single buffer. I am very supportive of this, and we don't need to achieve the optimum in the first shot.
To your first question, we're not discarding any data when rewriting the packet. All the data that's moved out is made available via the attributes.

@jech - I've rewritten the logic to handle RTX packets allocationless, i.e. there's no extra unmarshal/marshal and everything is done inline in the returned slice. Hope this addresses your concern.

This is amazing @adriancable thank you so much for doing this!
I am in support of merging this into master when you get tests/lints to pass.

There might have a data race in the allocationless buffer, when the TrackRemote.Read reads a rtx packet from the channel and copying the data from the buffer, the buffer can be written by the goroutine of receiveForRTX at same time.

@cnderrauber - thanks for your fix!


[SPARK-32229][SQL]Fix PostgresConnectionProvider and MSSQLConnectionProvider by accessing wrapped driver

What changes were proposed in this pull request?
Postgres and MSSQL connection providers are not able to get custom appEntry because under some circumstances the driver is wrapped with DriverWrapper. Such case is not handled in the mentioned providers. In this PR I've added this edge case handling by passing unwrapped Driver from JdbcUtils.
Why are the changes needed?
DriverWrapper is not considered.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing + additional unit tests.

Test build #129737 has started for PR 30024 at commit a58b723.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34343/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34343/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34343/
Test PASSed.

Test build #129737 has finished for PR 30024 at commit a58b723.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129737/
Test PASSed.

cc @HyukjinKwon @maropu

Test build #129998 has started for PR 30024 at commit 3d7463f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34604/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34604/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34604/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34605/

Scala 2.13 build issue is unrelated:
Error:    download error: Caught java.io.IOException: Server returned HTTP response code: 504 for URL: https://dl.bintray.com/sbt/sbt-plugin-releases/com.cavorite/sbt-avro/scala_2.12/sbt_1.0/2.1.1/ivys/ivy.xml (Server returned HTTP response code: 504 for URL: https://dl.bintray.com/sbt/sbt-plugin-releases/com.cavorite/sbt-avro/scala_2.12/sbt_1.0/2.1.1/ivys/ivy.xml) while downloading https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/com.cavorite/sbt-avro/scala_2.12/sbt_1.0/2.1.1/ivys/ivy.xml

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34605/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34605/
Test PASSed.

Test build #129998 has finished for PR 30024 at commit 3d7463f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129998/
Test PASSed.

LGTM. Thanks for the fix, @gaborgsomogyi

Merged to master.

Thank you all! Started to work on the documentation PR but this will take some time...


another example that uses KEY uint64, VALUE string

Hi folks,
In case there is interest, wanted to share an example I created following your instructions and code.
Hope this is in line with your contribution process, let me know otherwise.
Best,
Tavit

For the reference: another example that generates b-like package with static types, but also with staticly defined cmp function and adjusted kd: https://lab.nexedi.com/kirr/neo/blob/fcab58ca/go/zodb/storage/fs1/fsb/gen-fsbtree

@cznic, I do not recall all the details now, but kd was tuned so that sizeof(d) is ~ 1 page. Here is what I could find about benchmarks:
https://lab.nexedi.com/kirr/neo/commit/6793678b
IndexLoad loads db index from a file, which inside essentially performs many b.Tree.Set: https://lab.nexedi.com/kirr/neo/blob/fcab58ca/go/zodb/storage/fs1/index.go#L223.
It was definitely a measurable improvement, though a dedicated bulk-loading API would be much better.
If it makes sense to you I could try to work on related PR, but it won't be fast.

It was definitely a measurable improvement, though a dedicated bulk-loading API would be much better.

Please suggest the API. No promises above I'll consider it. Thanks.

If it makes sense to you I could try to work on related PR, but it won't be fast.

Go forward if you like to at any pace. Just please tune kd for the default type which is interface{}. Your 126 kd is specific to your key/value usage case.
I'm curious if setting kd to say 31 instead of 32 would make some nice difference. I could try it, but you've found the opimization opportunity so I would prefer if you keep the credit ;-)

Please suggest the API. No promises above I'll consider it. Thanks.

Some time ago I was experimenting with trying to make Get/Set auto detect bulk retrieve/loading cases and optimize appripriately:
https://lab.nexedi.com/kirr/b/compare/master...x/bulkload?expand_all_diffs=1 (scroll down to diffs) +
https://lab.nexedi.com/kirr/b/commit/93348d0f
If I recall correctly it was indeed ~ 8x faster, but regular random access got a bit (~5% IIRC) slower. That's why I did not posted my changes.
I do not have a particular idea for dedicated bulk loading API for now as I'm not currently working on BTrees. Whenever/if I have a chance to come back to this topic I will try to speak up with the API proposal.

About kd tuning - please feel free to do it, as I'm not currently working on BTrees and it is hard to tell when I could find time to work on it next time. There is no need to keep me in the hall of fame, but if you really want to preserve the credits you could mention me and reference our herby conversation in the commit.

Okay, thanks for the input.


Bing Maps With Angular in a Spring Boot Application

Proposed title of article
Bing Maps With Angular in a Spring Boot Application
How to integrate Bing Maps with Angular to show different site properties at different points in time with a Spring Boot backend.
Introduction paragraph (2-3 paragraphs):
The AngularAndSpringWithMaps project shows how to integrate Bing Maps, Angular, and Spring Boot with a Gradle build. The property data of the sites is stored with JPA in H2/PostgreSQL databases.
The purpose of the AngularAndSpringWithMaps project is to show the site properties at different points in time. To choose the site and then choose the time and have the site properties displayed in a map. New properties can be added and deleted on the map and then persisted. This article will show how to store and display company sites.
Key takeaways:
1.The Spring Boot Backend.
2. The Angular Frontend.
3. How to integrate the Spring Boot and Angular to work together
4. How to use Bing Maps

seems like a helpful topic - lets please be sure it add value beyond what is in the official docs and that it does not overlap with any existing EngEd articles or incoming topic suggestions (if you haven't already) to avoid any potential article closure. - approved @owinowendy


Can't install quick.db, nothing works

Yes, before you say iNsTaLL tHe BuILd ToOlS I did install the build tools. iNsTaLL eNdB I tried. Nothing works. The answers on Stack Overflow didn't work either. I have Python 2.7.15 installed. I am using Visual Studio 2015. I typed node -v into cmd and it returns 10.16.0. Please help!
EDIT:
The code would be in:
https://pastebin.com/4TihMzqf
The log would be in:
https://pastebin.com/hUaupRnh

Did you install node-gyp globally?

Yes, I did.

I didn't install Visual C++ with VS2015. What a dummy am I.


Support for legal NLP datasets (EURLEX and ECtHR cases)

Add support for two legal NLP datasets:

EURLEX (https://www.aclweb.org/anthology/P19-1636/)
ECtHR cases (https://arxiv.org/abs/2103.13084)

I closed this on my own because all tests passed successfully, is this ok?


clippy button is placed properly

Signed-off-by: gunjanmimo<EMAIL_ADDRESS>

Hi @gunjanmimo, here's a screenshot of the current clipboard icon's placement:

Here's a screenshot of the new size you've assigned in this PR:

I don't know that this is an improvement, but I could be missing what issue you're specifically trying to correct / improve upon. Will you describe it a bit more? Thanks. :)

Sir, but when the Clippy image is not perfectly placed here

Oh, wow. I didn't notice that before, @gunjanmimo. This issue doesn't occur in Safari, but does in Chrome. Thanks for fixing.


associated zones not visible on REST API nameservers endpoint

Description:
It is impossible to retrieve the related zones querying nameservers API, while the nested zone table in displayed in the Nameserver detail View. This makes me think that it has not been omitted due to performance concerns.
This search however is possible through the GraphQL with query like:
query{
  nameserver_list {
    name
    zones {
      name
    }
  }
}

How to implement:
add  NestedZoneSerializer as an attribute on NameServerSerializer
Database changes:
None as the relationship between zone and nameserver objects is already of type many-to-many
If you think it is worth implementation, I can try the PR

I think it makes perfect sense, so sure, go on! If you need any help just shout.

I have opted for keeping the nested Zones serializer in readonly mode. It looks like we don't need to extend the tests.

Making serializers writable is sometimes a bit tricky, though manageable. ATM I don't see much point in the effort though so we should get along fine with a read-only variant. Creating zones on the fly with name servers is probably not a common use case, so you would want to limit it to existing zones anyway. As long as the tests pass it should be fine.
Sometimes getting the tests from the upstream project to pass is really a pain, as they are not actually supported for plugins yet and neither very well-documented nor flexibly configurable ... I hope in a later NetBox version https://github.com/netbox-community/netbox-wg8333/issues/16 will be addressed, which should relieve that pain.

I agree. The PR in its simplest form is waiting for the revision. Let me know if I omitted anything important.


[SPARK-34350][SQL][TESTS] replace withTimeZone defined in OracleIntegrationSuite with DateTimeTestUtils.withDefaultTimeZone

What changes were proposed in this pull request?

This PR replaces withTimeZone defined and used in OracleIntegrationSuite with DateTimeTestUtils.withDefaultTimeZone which is defined as a utility method.
Why are the changes needed?

Both methods are semantically the same so it might be better to use the utility one.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

OracleIntegrationSuite passes.

Test build #134850 has started for PR 31465 at commit 676e88a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39437/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39437/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39437/

Test build #134850 has finished for PR 31465 at commit 676e88a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134850/

Thanks! Merged to master.


Update playbooks to support jewel

Jewel is supported, what's the problem?

I pulled the repository a day or two before you updated the playbooks. Not an issue anymore. Thanks!


format the final outcome

As I explored in #12, it is possible to format the final outcome one more time. If we implement things like #11, I think this will be much better.
Imagine
#[docify::export_content]
fn body() {
    let a = 10;
}

will export to
    let a = 10;

As things stand now. I argue that almost always, you don't want the indentation.
I would either make the indentation optional and specified by the embed!, or make it be the default for the sake of simplicity.

in my implementation of #[docify::export_conrtent] I would un-indent automatically, we already functions for this in docify so I'll use them there


Fixes #10543 : Make the modal not closable on outside click

Describe your changes:
Fix ticket comment : https://github.com/open-metadata/OpenMetadata/issues/10543#issuecomment-1482449696

I worked on making the modal not closable on the outside click across the application.

https://user-images.githubusercontent.com/66266464/227509586-ff992834-5a59-41ff-8379-2a8b790117cd.mov

Type of change:

[x] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 this will be applied everywhere the description needs to be edited? like users/teams etc.. cc @chirag-madlani

@harshach  Didn't get you on this. Like do you want to update the PR description ? or any thing else need to done.

@Ashish8689 this should work all the dialog boxes where we are editing text. Make sure this is not a fix for table descriptions but wherever a description needs to be edited

@harshach yes this fix has been covered across the application for all Modal.


A JavaScript error occurred in the main process

new release on mac OS X got me this error:
Uncaught Exception:
Error: This socket is closed
at Socket._writeGeneric (net.js:672:19)
at Socket._write (net.js:724:8)
at doWrite (_stream_writable.js:307:12)
at writeOrBuffer (_stream_writable.js:293:5)
at Socket.Writable.write (_stream_writable.js:220:11)
at Socket.write (net.js:650:40)
at Timeout._onTimeout (/path/Pokemon GO Live Map.app/Contents/Resources/app/main.js:270:21)
at tryOnTimeout (timers.js:224:11)
at Timer.listOnTimeout (timers.js:198:5)

Duplicate of #96


Use new GitHub environment files

Fixes #318
We are editing GitHub workflows to use new GitHub environment files , replacing deprecated commands.

🧪
The pipeline seems to be broken, I'm hoping it's just related to my comment above.
Presumably the warnings we're still geting are coming from usages of save-state in our dependencies.
If we're lucky it's all coming from this:
[release / release](https://github.com/sillsdev/LfMerge/actions/runs/3943994514/jobs/6749543499)
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16<EMAIL_ADDRESS>docker/login-action@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

It looks to me like nothing has changes in the APIs of docker/login-actionsv2 and actions/download-artifact@v3. So, we can just update them.


Add help menu to Muledump top bar

Replace the 'Home' link with a 'Help' button. Include links to wiki and help docs resources as well as a hotkey reference.

Published in v9.3.0.


Make convenience methods to handle creation of correct sagsevents

The new Sagsevent referenced by created FikspunktregisterObjekt should have an Eventtype which matches the type of objects created.
At the moment it is not clear what kinds of Eventtypes we have.
Maybe we should handle this by having methods like
FireDb.opret_koordinater(sag: Sag, koordinater: List(Koordinat))

Which automagically creates the correct, new instance of Sagsevent and makes the relations between it and  the Koordinater and the Sag.

Should work by now


⚠ Turnos 24x7 has degraded performance

In 1782eb7, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1059 ms

Resolved: Turnos 24x7 performance has improved in 22f5f06.


Features

Develop the features which are based on status

[!IMPORTANT]
Input: the status (Admin or User), no output

Let it simple!

I have linked the according pull request to this issue. Please have a look at.
Get back to me with approval or further to-do-s and fixes!


test: add videoElement.loadedmetadata test

adds a test which is similar to the web-platform-test simplecall test
https://github.com/w3c/web-platform-tests/blob/master/webrtc/simplecall.html
Would have probably caught #487 (but let me verify with the buggy version before merging)
Even though Harald is ooo I think he would like moar tests ;-)

hrm. The test does not catch the failure :-/
Shall we have it anyway because we like tests?

I agree, moar tests! LGTM


Added test and model for null Coalesce and Ternary operators in OrderBy

@anpete can you take a look?

I still have to add tests for filtering, projection, and include

@maumar and @anpete this is ready for a look

@anpete and @maumar I've got another revision ready for review

@anpete I've got support for projection in the PR now too

Note: this should fix #1700 and #1798

The current state of this change enables Expressions in Project and Orderby but does not use Alias expressions for column expressions.  I am working on that change, but I wanted to get this change out for review in a working state.

More changes have taken place, We now wrap all column expressions in alias expressions

Looks pretty good otherwise

:shipit:


docs: Addressed typos in docs/pages/docs/guide/advanced/table.mdx

Hello! I addressed typos, such as incorrect usage of "it's" and missing articles, throughout the "Rendering Tables" article located at docs/pages/docs/guide/advanced/table.mdx.
I'm a new contributor, interested in the project and its documentation, and I hope that this is helpful.

@SBobbe if you want to help with Nextra documentation improvements you can approve open documentations PRs by folks and/or add your suggestions. And I will merge them.
Each PR has deployment where you can see how it looks like 👍

Awesome, thanks @dimaMachina, will definitely look into it. I'm new to open source, so I appreciate the warm welcome!

Thank you 👍! You are very welcome, feel free to ask anything unclear about Nextra in GitHub, just don't forget to ping my nickname so I will not miss a reply or reach me on Twitter.