Unit tests fails occassionally

This unit test test_refts_creation_via_rest_api() seems to fail occasionally due the code that trying to access an external website.

@pkdash  you have snapshot or log on those failing test cases? thanks

@pkdash
I think I am seeing it right now. it happened on my PR for collection

Error Message
500 != 200
-------------------- >> begin captured logging << --------------------
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): data.iutahepscor.org
requests.packages.urllib3.connectionpool: DEBUG: "GET /LoganRiverWOF/REST/waterml_1_1.svc/datavalues?location=iutah:LR_WaterLab_AA&variable=iutah:WaterTemp_EXO&startDate=2014-12-02T19:45:00Z&endDate=2014-12-05T19:45:00Z HTTP/1.1" 500 1047
--------------------- >> end captured logging << ---------------------
Stacktrace
File "/usr/local/lib/python2.7/unittest/case.py", line 329, in run
testMethod()
File "/hydroshare/hs_core/tests/api/rest/test_create_resource.py", line 347, in test_refts_creation_via_rest_api
self.assertEqual(response.status_code, status.HTTP_200_OK)
File "/usr/local/lib/python2.7/unittest/case.py", line 513, in assertEqual
assertion_func(first, second, msg=msg)
File "/usr/local/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
raise self.failureException(msg)
'500 != 200\n-------------------- >> begin captured logging << --------------------\nrequests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): data.iutahepscor.org\nrequests.packages.urllib3.connectionpool: DEBUG: "GET /LoganRiverWOF/REST/waterml_1_1.svc/datavalues?location=iutah:LR_WaterLab_AA&variable=iutah:WaterTemp_EXO&startDate=2014-12-02T19:45:00Z&endDate=2014-12-05T19:45:00Z HTTP/1.1" 500 1047\n--------------------- >> end captured logging << ---------------------'

@zhiyuli I am not sure how you would mock the call the that URL. We may already have code that do mocking in other unit tests.

@pkdash
I skipped this test case in that PR for collection as this failing test is not related to collection and I dont want to hold that PR.
The url in that failing test only returns a wml file. If we could host that wml file locally and make up a local url for it, that would fix it I believe. Any idea how we can make up a local url for a local wml file?

@zhiyuli Then just store that wml file somewhere under the tests directory and use it directly without the need for http call to retrieve that file.

@pkdash
I can save that wml file locally but we have to give it a url. The purpose of this test case is to test creation of a  RefTS res through rest api, which is expecting for a url as a required input parameter.
I am trying to save the wml as a static file and use "/static/file.xml" as the url.

@zhiyuli I assume this line is causing the problem: response = requests.get(ref_url)
Instead of using the requests try using the self.client.get(ref_url) that's (self.client)  what has been used everywhere else in rest testing code for http request.

@pkdash
you mean keep using the external url and changing requests.get(ref_url) to self.client.get(ref_url)?
I am assuming the error was caused by the instability of that external url

@zhiyuli Now I realize that won't work. I think we have to mock the call to ref_url. See the testing code in hs_restclient for some idea how to mock a function/service call.

@pkdash
I am thinking instead of mocking up external url access in rest api test cases, the RefTS code itself should provide a "test mode".  Some thing like if user passes in a parameter "test_mode: True", the refts will use a locally pre-stored wml sample file directly, instead of querying external url to download wml on the fly.
Then we could simply add "test_mode: True" to that failing test, which should be able to fix it.
What do you think?

Unit tests don't fail regularly


Eager loading related Models

Hi,
Thank you for such a GREAT integration into Sphinx, it's awesome.
I have other details I want eager loaded into the model query that I'm already using.
I tried
$results = $sphinx->search($search, 'tracker')
->load('details')
->get();

But that didn't load any data, I also tried ->with() but no go.
Do these associations need to be defined in my Search model? Product is the main Model I have defined in my sphinxsearch.php config file.
Any suggestions?
Thank you!

Took a little bit, but after reading through the code, I figured out. I'll be submitting  a PR soon too, I think it will help other people.
<?php
return array(
    'host'    => '<IP_ADDRESS>',
    'port'    => 9312,
    'timeout' => 30,
    'indexes' => array(
        'tracker' => array ( 'table' => 'products', 'column' => 'id', 'modelname' => 'App\Product' ),
    ),
    'mysql_server' => array(
        'host' => env('DB_HOST'),
        'port' => env('DB_PORT'),
        'username' => env('DB_USERNAME'),
        'dbname' => env('DB_DATABASE'),
        'passwd' => env('DB_PASSWORD'),
    )
);

Then just add ->with('relation') to your query.


Generate ManagedProject.csproj at compile time

I noticed that the ManagedProject.csproj file doesn't get generated until you boot up Unreal Engine. This change should generate it at compile time.

Awesome :D
Maybe remove the GenerateProject in C++ then and just let it compile the user code?

I assume you're talking about making this change in FCSManager::InitializeUnrealSharp():
#if WITH_EDITOR
	if (!FParse::Param(FCommandLine::Get(), TEXT("game")))
	{
		if (!FApp::IsUnattended())
		{
			/*
			if (!FCSProcHelper::GenerateProject())
			{
				InitializeUnrealSharp();
				return;
			}
			*/

			FCSProcHelper::InvokeUnrealSharpBuildTool(Build);
			FCSProcHelper::InvokeUnrealSharpBuildTool(Weave);
		}
	}
#endif

The above code does work for me in C++ projects. However, I noticed that in Blueprint Only projects this doesn't generate a project file.


Be smarter about default order of events in series blocks

Currently, by default, videos in series blocks are sorted from "newest to oldest". That makes sense for ongoing series (e.g. lectures) so to speak. Users are usually interested in the newest entry when visiting the page.
However, for series that are "done", the opposite order makes more sense. You would expect the first video to appear first.
I'm opening this issue to brainstorm whether Tobira can somehow be smart about the default in some way. Moderators can already change the order for blocks, and each user can change the order individually locally. So it's not too important. But if we have a nice idea, it could improve the UX.

Is this a solo brainstorm? If not: Based on what data does Tobira currently sort "newest to oldest" by default?

Input is always appreciated! On ... no data? I think the current default behavior just comes from imagining a lecture that's currently still going. Especially in combination with live videos and upcoming live videos. But as I said, I realize that this doesn't make sense for all series at all.


Refactor null check for getClient service

Also another minor thing but you can avoid using the is_null function in favour of $this->$client === null or $this->$client !== null. While probably not humanly noticeable, it is faster execution wise than the function variant, because of the function call overhead.

I personally find is_null more clear on what the intent is. The difference in performance is negligible (https://stackoverflow.com/questions/8228837/is-nullx-vs-x-null-in-php#comment49952259_8229059)


Deprecated Atom APIs will be removed June 1st

Atom will no longer load this package after June 1st without changes. There are a couple deprecations on the latest version (0.2.1) of this package:

The context menu CSON format has changed. Please see https://atom.io/docs/api/latest/ContextMenuManager#context-menu-cson-format for more info.
Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows: json "activationCommands": { "atom-workspace": ["foo:bar", "foo:baz"], "atom-text-editor": ["foo:quux"] }
atom.workspaceView is no longer available. In most cases you will not need the view. See the Workspace docs for alternatives: https://atom.io/docs/api/latest/Workspace. If you do need the view, please use atom.views.getView(atom.workspace), which returns an HTMLElement.
Use ::getActivePaneItem() instead of the ::activePaneItem property
Use TextEditor::getLastSelection() instead
Use TextEditor::moveLeft() instead

Visit https://gist.github.com/benogle/6d09e295c84b717ef9b4 and search for your package name to see up-to-date deprecations.
If this package has been replaced by another package or functionality in core, please reply with this information.
See https://github.com/atom/atom/issues/6867 for more info. Thanks!

I will be working on a fix shortly, I actually use vim as my primary editor now so I don't use atom much anymore. I'll continue to support this plugin so long as the demand is there.

erb-helper now conforms with the 1.0 API and no longer relies on the deprecated functions mentioned.

:heart:


Bad format doesn't contain a lot of info

Describe the bug
If a conversion in the constructor of a datatype throws an error, only a very generic error is available:

Option 'some option' is defined with a bad format.

To Reproduce

Have a property of type DirectoryInfo
Supply bad character (mostly happens by accident)
Get general error

Expected behavior
There are some options:

Add the used parameter to the BadFormatConversionError type so the bad formatted input string can be shown in the custom help callback.
Catch TargetInvocationException and add the inner exception to the BadFormatConversionError
Show a message with the message of the exception, especially when the exception is an ArgumentException.
It would then read something like 'Option 'i, input' is defined with "Invalid;Path" which is a bad format: Illegal characters in path.'

Relates to https://github.com/commandlineparser/commandline/issues/113

BTW, the initial problem was https://github.com/commandlineparser/commandline/issues/226, which I had to debug to see the actual thing that went wrong.


AUTHENTICATOR PROBLEM WINDOWS NO OUTPUT

Netflix add-on version
newest
Operative systems used
Android
Kodi version used
Kodi 20 (Nexus)
Description of the bug
AUTHENTICATOR PROBLEM
I use the Toool
Login in netflix in browser and now nothing does over 5 minits
:( plese help me
Steps to reproduce the behavior
No response
Debug log - mandatory
https://paste.kodi.tv/ataxeluquq
Possible fix
???
Additional context
Fix it please
Screenshots
No response

logged in but only

Chrome startup... please wait
Establish connection with Chrome... please wait
Opening login webpage... please wait
-> Please login in to website now ...waiting for you to finish...

can i use this only with Paid Accounts?

What means exactly only with paid accounts? this is not free service
make sure you have paied the month before try login

closed due to inactivity


Go to screen

Adds the possibility to jump to a specific screen by choosing one from a modal dialog that lists all available screens

Closes #38


Only include app owner if defined

Also, rename get-app_data and change description.

https://ocd.appscale.com:8080/job/Daily Build/1344/


Optimize _cards_stats query

Has shown up a few times >5s.
SELECT
        name,
        SUM(num_decks) AS all_num_decks,
        SUM(wins) AS all_wins,
        SUM(losses) AS all_losses,
        SUM(draws) AS all_draws,
        SUM(wins - losses) AS record,
        SUM(perfect_runs) AS all_perfect_runs,
        SUM(tournament_wins) AS all_tournament_wins,
        SUM(tournament_top8s) AS all_tournament_top8s,
        IFNULL(ROUND((SUM(wins) / NULLIF(SUM(wins + losses), 0)) * 100, 1), '') AS all_win_percent,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN num_decks ELSE 0 END) AS season_num_decks,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins ELSE 0 END) AS season_wins,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN losses ELSE 0 END) AS season_losses,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN draws ELSE 0 END) AS season_draws,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN perfect_runs ELSE 0 END) AS season_perfect_runs,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN tournament_wins ELSE 0 END) AS season_tournament_wins,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN tournament_top8s ELSE 0 END) AS season_tournament_top8s,
        IFNULL(ROUND((SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins ELSE 0 END) / NULLIF(SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins + losses ELSE 0 END), 0)) * 100, 1), '') AS `season_win_percent`,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN num_decks ELSE 0 END) AS week_num_decks,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins ELSE 0 END) AS week_wins,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN losses ELSE 0 END) AS week_losses,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN draws ELSE 0 END) AS week_draws,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN perfect_runs ELSE 0 END) AS week_perfect_runs,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN tournament_wins ELSE 0 END) AS week_tournament_wins,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN tournament_top8s ELSE 0 END) AS week_tournament_top8s,
        IFNULL(ROUND((SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins ELSE 0 END) / NULLIF(SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins + losses ELSE 0 END), 0)) * 100, 1), '') AS `week_win_percent`
    FROM
        _card_stats AS cs
    LEFT JOIN
        (
    SELECT
        `start`.id,
        `start`.code,
        `start`.start_date AS start_date,
        `end`.start_date AS end_date
    FROM
        season AS `start`
    LEFT JOIN
        season AS `end` ON `end`.id = `start`.id + 1
) AS season ON season.start_date <= cs.day AND (season.end_date IS NULL OR season.end_date > cs.day)
    WHERE
        TRUE AND TRUE
    GROUP BY
        name
    ORDER BY
        all_num_decks DESC,
        record,
        name

    SELECT
        name,
        SUM(num_decks) AS all_num_decks,
        SUM(wins) AS all_wins,
        SUM(losses) AS all_losses,
        SUM(draws) AS all_draws,
        SUM(wins - losses) AS record,
        SUM(perfect_runs) AS all_perfect_runs,
        SUM(tournament_wins) AS all_tournament_wins,
        SUM(tournament_top8s) AS all_tournament_top8s,
        IFNULL(ROUND((SUM(wins) / NULLIF(SUM(wins + losses), 0)) * 100, 1), '') AS all_win_percent,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN num_decks ELSE 0 END) AS season_num_decks,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins ELSE 0 END) AS season_wins,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN losses ELSE 0 END) AS season_losses,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN draws ELSE 0 END) AS season_draws,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN perfect_runs ELSE 0 END) AS season_perfect_runs,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN tournament_wins ELSE 0 END) AS season_tournament_wins,
        SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN tournament_top8s ELSE 0 END) AS season_tournament_top8s,
        IFNULL(ROUND((SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins ELSE 0 END) / NULLIF(SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins + losses ELSE 0 END), 0)) * 100, 1), '') AS `season_win_percent`,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN num_decks ELSE 0 END) AS week_num_decks,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins ELSE 0 END) AS week_wins,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN losses ELSE 0 END) AS week_losses,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN draws ELSE 0 END) AS week_draws,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN perfect_runs ELSE 0 END) AS week_perfect_runs,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN tournament_wins ELSE 0 END) AS week_tournament_wins,
        SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN tournament_top8s ELSE 0 END) AS week_tournament_top8s,
        IFNULL(ROUND((SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins ELSE 0 END) / NULLIF(SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins + losses ELSE 0 END), 0)) * 100, 1), '') AS `week_win_percent`
    FROM
        _card_stats AS cs
    LEFT JOIN
        (
    SELECT
        `start`.id,
        `start`.code,
        `start`.start_date AS start_date,
        `end`.start_date AS end_date
    FROM
        season AS `start`
    LEFT JOIN
        season AS `end` ON `end`.id = `start`.id + 1
) AS season ON season.start_date <= cs.day AND (season.end_date IS NULL OR season.end_date > cs.day)
    WHERE
        TRUE AND TRUE
    GROUP BY
        name
    ORDER BY
        all_num_decks DESC,
        record,
        name

Even this simplified query takes >2s on local:
SELECT
    name,
    SUM(num_decks) AS all_num_decks,
    SUM(wins) AS all_wins,
    SUM(losses) AS all_losses,
    SUM(draws) AS all_draws,
    SUM(wins - losses) AS record,
    SUM(perfect_runs) AS all_perfect_runs,
    SUM(tournament_wins) AS all_tournament_wins,
    SUM(tournament_top8s) AS all_tournament_top8s,
    IFNULL(ROUND((SUM(wins) / NULLIF(SUM(wins + losses), 0)) * 100, 1), '') AS all_win_percent,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN num_decks ELSE 0 END) AS season_num_decks,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins ELSE 0 END) AS season_wins,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN losses ELSE 0 END) AS season_losses,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN draws ELSE 0 END) AS season_draws,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN perfect_runs ELSE 0 END) AS season_perfect_runs,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN tournament_wins ELSE 0 END) AS season_tournament_wins,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN tournament_top8s ELSE 0 END) AS season_tournament_top8s,
    IFNULL(ROUND((SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins ELSE 0 END) / NULLIF(SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins + losses ELSE 0 END), 0)) * 100, 1), '') AS `season_win_percent`,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN num_decks ELSE 0 END) AS week_num_decks,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins ELSE 0 END) AS week_wins,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN losses ELSE 0 END) AS week_losses,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN draws ELSE 0 END) AS week_draws,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN perfect_runs ELSE 0 END) AS week_perfect_runs,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN tournament_wins ELSE 0 END) AS week_tournament_wins,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN tournament_top8s ELSE 0 END) AS week_tournament_top8s,
    IFNULL(ROUND((SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins ELSE 0 END) / NULLIF(SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins + losses ELSE 0 END), 0)) * 100, 1), '') AS `week_win_percent`
FROM
    _card_stats AS cs
GROUP BY
    name

while
SELECT
    name
FROM
    _card_stats AS cs
GROUP BY
    name

Takes 50ms.
This says to me that bucketing by day and calculating values on user time from that preaggregation is never going to be the speed we want. We need to bucket to the buckets we want at preaggregation time.

SELECT
    name,
    SUM(num_decks) AS all_num_decks,
    SUM(wins) AS all_wins,
    SUM(losses) AS all_losses,
    SUM(draws) AS all_draws,
    SUM(wins - losses) AS record,
    SUM(perfect_runs) AS all_perfect_runs,
    SUM(tournament_wins) AS all_tournament_wins,
    SUM(tournament_top8s) AS all_tournament_top8s,
    IFNULL(ROUND((SUM(wins) / NULLIF(SUM(wins + losses), 0)) * 100, 1), '') AS all_win_percent,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN num_decks ELSE 0 END) AS season_num_decks,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins ELSE 0 END) AS season_wins,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN losses ELSE 0 END) AS season_losses,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN draws ELSE 0 END) AS season_draws,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN perfect_runs ELSE 0 END) AS season_perfect_runs,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN tournament_wins ELSE 0 END) AS season_tournament_wins,
    SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN tournament_top8s ELSE 0 END) AS season_tournament_top8s,
    IFNULL(ROUND((SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins ELSE 0 END) / NULLIF(SUM(CASE WHEN `day` ><PHONE_NUMBER> THEN wins + losses ELSE 0 END), 0)) * 100, 1), '') AS `season_win_percent`,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN num_decks ELSE 0 END) AS week_num_decks,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins ELSE 0 END) AS week_wins,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN losses ELSE 0 END) AS week_losses,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN draws ELSE 0 END) AS week_draws,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN perfect_runs ELSE 0 END) AS week_perfect_runs,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN tournament_wins ELSE 0 END) AS week_tournament_wins,
    SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN tournament_top8s ELSE 0 END) AS week_tournament_top8s,
    IFNULL(ROUND((SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins ELSE 0 END) / NULLIF(SUM(CASE WHEN `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK) THEN wins + losses ELSE 0 END), 0)) * 100, 1), '') AS `week_win_percent`
FROM
    _card_stats AS cs
LEFT JOIN
    (
        SELECT
            `start`.id,
            `start`.code,
            `start`.start_date AS start_date,
            `end`.start_date AS end_date
        FROM
            season AS `start`
        LEFT JOIN
            season AS `end` ON `end`.id = `start`.id + 1
    ) AS season ON season.start_date <= cs.day AND (season.end_date IS NULL OR season.end_date > cs.day)
WHERE
    TRUE AND `day` > UNIX_TIMESTAMP(NOW() - INTERVAL 1 WEEK)
GROUP BY
    name
ORDER BY
    all_num_decks DESC,
    record,
    name

is 100ms but I don't think that helps or changes things.

Bucketing per season is b1014a2.
Now takes 50ms.
Might return to bucketing by day just for the last week/month/season in order to support some of the use cases but this does almost everything and is a radical speed improvement on cards queries.


[hot-fix]fix hard coding api server into watchdog image (#873)

fix hard coding api server into watchdog image

Coverage increased (+12.5%) to 63.445% when pulling 7455d897cd1c1bf5a3a1c5474066b1a8f2c7195c on yuan/hot_fix_hard_coding_api_server_info into d9265e669dc8f0b488eb15456f68c7d899017c20 on pai-0.6.y.


Incorrect return type declaration in Post::determine_id()

At a time of writing this bug report both 1.x and 2.x branches of Timber declares return type of \Timber\Post::determine_id() as int while actual return type is int|null because it is possible to have no post at all, e.g. inside of 404.php.
Since \Timber\Post accepts null for $pid in its constructor - returning null from determine_id() effectively propagates this (unexpected) value further that may lead to unexpected behavior.
Additionally, if Timber, which requires ^7.0 for its 2.x branch will include language level declaration of return types - this inconsistency will produce \TypeError error.

This method doesn't exist anymore. Its responsibilities were taken over by PostFactory in 2.0, and the semantics are now much better defined. In short, if Timber::get_post() doesn't find a post, it returns false. The upgrade guide will be updated soon with all the relevant info.


Fixing 1. Potential Orthogonalization issue 2. Minor bug for resume Training = True

Potential Orthogonalization Issue --> See description in 'Issues'
A bug appeared when wanting to resume training. This minor bug has been fixed here,

Dear Felix,
we fixed the bug that occurs when resume = True
Thank you for reporting it!


Custom domain

Hi, I'm trying to setup this theme with a custom domain.  It works when I build & serve locally but when I put it on github pages I get a 404 when going to the site.  I'd appreciate it if you could add configuration instructions for using your own domain name.

@robins-spark How are you deploying your project?

I fixed it.  I was missing the CNAME file.  Still, I think it might be good to mention custom domains in the README since it discusses using YOUR-USERNAME.github.io and https://raviriley.github.io/agency-jekyll-theme-starter/.  Using a custom domain is a third option.

Updated the README @robins-spark  :)


#48 Nested classes support

See #48

I created a new pull with a single commit. Don't know where to start with JUnit...

Hi, maybe there  is a better option to implement the enhancement. We could subclass the ClassPool to get all the instrumented classes (modified) so we could then save all of them. This would work for any additional class updated or generated during the process. What do you prefer ?

@jmarcgit Thanks for this PR.
I'll start to merge this simple solution.
The JUnit test base is to small, I know. I'll add a test for you before I push the merged code.
Btw: Add a contributor entry with your datas in the POM file, if you like or I can do it for you too.

@jmarcgit I've merged this PR into the master branch.
I had to adjust the patch a bit and I added tests for it.
Please take a look at: 02ba5ab673ef34caa2584ac3b720efa8f15a1cbc.
Feel free to open a new PR to add a contributor entry in the POM file like:
https://github.com/icon-Systemhaus-GmbH/javassist-maven-plugin/blob/master/pom.xml#L45


Github Confluence Mirror : add "baloise-incubator"

still not working

Our two organizations "baloise" and "baloise-incubator" are now mirrored to : https://confluence.baloisenet.com/atlassian/x/PZe2eQ


Fix for websocket not reopening on iOS

Closes #5697
This PR adds an implementation of an optional NSURLSessionWebSocketDelegateProtocol method in the NSURLSessionWebSocketEngine that's required in order to get a websocket to successfully reopen.
Currently, the onOpen and onClose protocol methods are implemented, but if there's an error when trying to open a websocket, neither of those callbacks are called, so the flow for repeatedly attempting to reopen the websocket never continues after the first unsuccessful attempt.
Implementing the didCompleteWithError protocol allows the NSURLSessionWebSocketEngine to be notified when there's an error opening a websocket and continue so that future attempts to reopen the websocket can be made.

@mboyd1993: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/


Cannot find any details about consul config properties

I find that spring cloud consul has a great many of config properties, e.g. the properties in org.springframework.cloud.consul.discovery.ConsulDiscoveryProperties.
But I cannot find any detail specification about the usage of these properties.
How can I use these configuration correctly ?
Is there any documentation that I can refer to ?
I find some configurations seem similar to the configurations from consul, how can I make sure the relation between these two ?
Thanks in advance
Sunrry

You can find them here in the documentation http://cloud.spring.io/spring-cloud-static/Dalston.SR1/#_appendix_compendium_of_configuration_properties

This is exactly what I want.
Thanks a lot !


Cross-adapter validations broken between Mongo and SQL records in v0.13

Waterline version:0.13
Node version:7.9.0
NPM version:5.0.3
Operating system:Windows 10 Pro x64

If you have a model using a mongo datastore:
Child.js
datastore: 'mongodb',
attributes: {
  parent: {
    model: 'parent'
  }
}

referencing a model that uses an SQL datastore (with an integer id):
Parent.js
datastore: 'mariadb',
attributes: {
  children: {
    collection: 'child',
    via: 'parent'
  }
}

Then the mongodb adapter will throw an error Can not parse [integer id] as a valid mongodb id, when trying to save association.
Seeing as the sails team considers cross-adapter associations to be a feature worth nuking others because of, I'd say this should be high priority.

Considering the fact that issues and pull requests on anything sails-related can remain hanging for a year or more, it seems highly inappropriate to auto-close them in a month.
There haven't been any updates because the problem is still there and there is no known workaround.

UPDATE: This issue appears to have disappeared after I created custom migrations, however now waterline created a join table for this relation instead of retrieving it from the mongodb records (its a one to many relation). Configuration is as follows:
child.js //this model is chemaless
  datastore: 'mongodb'
  ...
  parentId: {
    model: 'parent'
    required: true //this wasn't present before either
  }

parent.js
  datastore: 'mariadb'
  ...
  children: {
    collection: 'child',
    via: 'parent'
  }

Mongodb records contain parentId and the mapping appears to be correct, however it results in using an extra table, which is not a good solution in our case, as there can be hundreds of thousands of child records per parent.


Short solution needed: "golang query string params" (golang)

Please help us write most modern and shortest code solution for this issue:
golang query string params (technology: golang)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

How to parse query string params


Add unit test for HTTP header name validation.

This PR added HttpUtils for TextFormat propagation tests. It validates the characters of header names (#1072).
The validation logic is inspired by netty, however it does not fully implement the spec.
There are two specs for the header and they are actually the same. The only difference is that RFC-2616 defines the charset by excluding invalid characters, while RFC-7230 defines it by listing all allowed characters.

Codecov Report

Merging #1097 into master will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master    #1097      +/-   ##
============================================
+ Coverage     81.74%   81.76%   +0.01%
- Complexity     1174     1183       +9
============================================
  Files           184      185       +1
  Lines          5512     5521       +9
  Branches        510      512       +2
============================================
+ Hits           4506     4514       +8
- Misses          871      872       +1
  Partials        135      135

Impacted Files
Coverage Δ
Complexity Δ

...a/io/opencensus/testing/propagation/HttpUtils.java
88.88% <88.88%> (ø)
9 <9> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422d78f...baef5f0. Read the comment docs.

Since this is a test.. why not rename validateX to assertX and throw an
assertion error with a message instead of false.
On Tue, 27 Mar 2018 06:38 Codecov<EMAIL_ADDRESS>wrote:

Codecov
https://codecov.io/gh/census-instrumentation/opencensus-java/pull/1097?src=pr&el=h1
Report
Merging #1097
https://codecov.io/gh/census-instrumentation/opencensus-java/pull/1097?src=pr&el=desc
into master
https://codecov.io/gh/census-instrumentation/opencensus-java/commit/422d78f044a3941f6910d1b66452ded45a386b0c?src=pr&el=desc
will increase coverage by 0.01%.
The diff coverage is 88.88%.
[image: Impacted file tree graph]
https://codecov.io/gh/census-instrumentation/opencensus-java/pull/1097?src=pr&el=tree
@@             Coverage Diff              @@##             master    #1097      +/-   ##
============================================+ Coverage     81.74%   81.76%   +0.01%     - Complexity     1174     1183       +9
Files           184      185       +1
Lines          5512     5521       +9
Branches        510      512       +2
============================================+ Hits           4506     4514       +8     - Misses          871      872       +1
Partials        135      135
Impacted Files
https://codecov.io/gh/census-instrumentation/opencensus-java/pull/1097?src=pr&el=tree Coverage
Δ Complexity Δ
...a/io/opencensus/testing/propagation/HttpUtils.java
https://codecov.io/gh/census-instrumentation/opencensus-java/pull/1097/diff?src=pr&el=tree#diff-dGVzdGluZy9zcmMvbWFpbi9qYXZhL2lvL29wZW5jZW5zdXMvdGVzdGluZy9wcm9wYWdhdGlvbi9IdHRwVXRpbHMuamF2YQ== 88.88%
<88.88%> (ø) 9 <9> (?)
Continue to review full report at Codecov
https://codecov.io/gh/census-instrumentation/opencensus-java/pull/1097?src=pr&el=continue
.
Legend - Click here to learn more
https://docs.codecov.io/docs/codecov-delta
Δ = absolute  (impact), ø = not affected, ? = missing data
Powered by Codecov
https://codecov.io/gh/census-instrumentation/opencensus-java/pull/1097?src=pr&el=footer.
Last update 422d78f...baef5f0
https://codecov.io/gh/census-instrumentation/opencensus-java/pull/1097?src=pr&el=lastupdated.
Read the comment docs https://docs.codecov.io/docs/pull-request-comments
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/census-instrumentation/opencensus-java/pull/1097#issuecomment-376334576,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD611FMi5dPk1BwV5fuAoK_rn3rDwa6ks5tiW3_gaJpZM4S8AAn
.

I am looking for a proper library to provide such functionality - the netty-codec-http has a bunch of secondary dependencies and is not an ideal one for this small purpose.

Closing for now, since this PR isn't active.


README.md & fabric.mod.json fix

Added a small readme and fixed the example description which displayed ingame under mods.

Create de_de.json


Automatic $exposure tracking

Hello Amplitude SDK Team,
We are trying to implement Amplitude Experiments in our app but having trouble understanding how the automatic$exposure tracking works!
The docs say that the exposure tracking works automatically when using the SDK (we use version 1.5.3)
We need the $exposure to be tracked by Amplitude along with a custom event tracking provider.
Here is a snippet of how we initialize the SDK
AmplitudeExperiment.initialize(apiKey, {
  automaticExposureTracking: true,
  exposureTrackingProvider: new RudderStackExposureTrackingProvider(), // our custom provider
  debug:
    true,
  initialVariants: experiments.getAll().reduce(
    (variantsAcc, experiment) => ({
      ...variantsAcc,
      [experiment.id]: experiment.fallback,
    }),
    {}
  ),
});

We are unable to see the exposure events being tracked in Amplitude

We would appreciate any help with this.
Thank you
Joel

Hi @joelr-cm,
Thanks for submitting this issue.
First, if you debug or add log statements to the custom RudderStackExposureTrackingProvider is the track() method being called? If so what are the values in the Exposure object passed to track()?
Brian.


Cross-language, cross-library tests timing out for China cloud

Because our test pipeline agents run from somewhere in the US and do, perhaps, to some other issues, many of our tests across libraries and languages are timing out against the China cloud e.g., Azure/azure-sdk-for-net#34641 (manual test run, but indicative of tests-weekly runs).
Discussing this offline, we could expose some variable in cloud-specific files e.g., https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/TestResources/clouds/AzureChinaCloud.json, that get plumbed through to clients.

/cc @benbp @joshlove-msft @christothes @jsquire

I honestly don't know if that would help. Maybe mitigate some, but it's an arms race at that point. If we can run agents closer to the their cloud, that would be best.

@heaths, is that the approach you were outlining here? (it mentions an offline discussion)

Discussing this offline, we could expose some variable in cloud-specific files

(also, agreed that moving our tests to run inside the cloud or nearer is the right option)

@benbp is the mastermind here. I might've been eluding to some way to say "use a longer timeout", but Ben was going to see if we could run agents closer to their cloud to mitigate the high latency that is likely causing this.

@heaths We could spin up a southeastasia agent pool. I would need to do a bit of yaml plumbing first to get our cloud configs to target agent VM regions. CC @mikeharder

Any way we could test that it would make a meaningful difference before doing all that work? Could you or I (happy to help) make some changes in a PR that would force it and just test those against China's cloud (remove the others, for example)?


Add boltlockserver to usecaseserver

I hope I've understood usecaseserver well enough so that this makes sense.

Parameters should probably be unlock angle and lock angle or something.


Union declaration shows as syntax error.

Undefined name 'Union' used as an annotation.
Try defining the name or importing it from another library.

Yea the import 'package:union/union.dart'; doesn't exist. Is union reserved?

This error occurs if I dont specify the version.
Because every version of union_generator from git depends on union from git https://github.com/tomwyr/union.git at v1.0.0 in union and crescent_asset depends on union from git https://github.com/tomwyr/union.git at HEAD in union, union_generator from git is forbidden.
So, because crescent_asset depends on union_generator from git, version solving failed.

I started pushing tags for package versioning. Add ref with a specific version to the pubspec file:
dependencies:
  union:
    git:
      url: https://github.com/tomwyr/union.git
      path: union
      ref: v1.0.0


Add-PnPFile Local file was not found

I am getting the errors below when running Add-PnpFile. I have confirmed the variable is exactly the correct path. I can click it and see the png file that exists. if I do not use a variable, and hard-code the parameter, it works fine.

there was an invisible character at the beginning of the path... I fixed it.


CC ISSUE 2040

This change is necessary to realise a solution for the following Issue, which was opened in the Cloud Controller: https://github.com/cloudfoundry/cloud_controller_ng/issues/2040
The change does the following:

Extend "TokenExpired" exception by an optional decoded token attribute
Change the function "decode_at_reference_time" to accept a third parameter, which, if set to true, will return the decoded token within the TokenExpired exception. Other exceptions behaviour remain the same.
Implement the function "decode_at_reference_time_exp_warn_only" in class "TokenCoder" which can be called by the CC

Short explanation why this is needed:

After the CC gets back the decoded token further checks like checking the UAA issuer are executed
Until now, if the token is expired, the uaa_lib will only throw an exception and the CC can't access the decoded token
In the CC we want to handle expired, but in general valid tokens more graceful. For this to work the CC needs to retrieve the decoded token together with the TokenExpired exception.

This is a proposal. We would be glad about feedback.

Hi maintainers,
Is anything that we can do to help with the review of this PR?
Many thanks

@drnic ping ^^^

Closing this PR. After the discussion in https://github.com/cloudfoundry/cloud_controller_ng/pull/2079 we changed the implementation there. We do no longer check whether the token is otherwise valid. So no change of the uaa lib is needed.


doc: add chinese translation

List

[x] api.md
[x] comparison.md
[x] faq.md
[x] guides

[x] getting-started.md
[x] reactivity.md
[x] rendering.md
[x] server.md

[x] resources

[x] articles.md
[x] examples.md
[x] projects.md

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
29 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 90.249%

Files with Coverage Reduction
New Missed Lines
%

packages/solid/src/reactive/signal.ts
29
88.71%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
1063

Relevant Lines:
1128

💛  - Coveralls

@Gavin-Gong thanks for this amazing work. I'm going to merge this and then we're going to attempt migrating to solid-docs to make managing this easier. If you have any changes, PRs in that repo would be amazing.


Dependencies not minified fully with pika CDN

https://cdn.pika.dev/tippy.js/v4 (popper.js dependency bundled in)
vs
https://unpkg.com/popper.js@1
It's not being minified fully (function names, etc, are still the same as unminified). This leads to a +1 KB increase

You're right, we're using Terser but not any of the normal minification features enabled. Sounds like we could shave off some serious KB across all packages

This is now fixed to use the following options added, which more closely match what you're seeing on unpkg:
{
  mangle: true,
  module: true,
}

Happy to entertain others if people have opinions, I don't have too much experience customizing Terser. Output of tippy.js is down from 58652b  to 51719b, a 12% savings on top of already minfied code. Thanks for calling this out.
This will take a few days to propagate across the already-built packages.


Solution: add a warning message and remove jobs with invalid tasks

Hello!
Proposal:
At Quantum startup, when detected that a mfa task is not a  valid function, ignore the job configuration and show a warning message.
closes #507

Pull Request Test Coverage Report for Build 22b8db2346aa33f619f4e69853f27e7439236e89-PR-523

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 86.486%

Totals

Change from base Build ac74242ad0f26db2970d6c122c3b90b64b64381d:
0.8%

Covered Lines:
352

Relevant Lines:
407

💛  - Coveralls


Remove access to External Storage, Update Packages

Fix for https://github.com/hyperledger/aries-mobile-agent-xamarin/issues/52 and https://github.com/hyperledger/aries-mobile-agent-xamarin/issues/53


rustFlake:  doesn't fail on reported cargo clippy AND cargo build warnings

Original: https://github.com/mlabs-haskell/lambda-buffers/issues/165
warning: very complex type used. Consider factoring parts into `type` definitions
  --> src/indexer/callback.rs:22:5
   |
22 |     Arc<dyn Fn(Event) -> Pin<Box<dyn Future<Output = Result<(), E>> + Send + Sync>> + Send + Sync>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
  --> src/indexer/callback.rs:43:9
   |
43 | /         rt.block_on(handle_event(input, |ev: Event| f(ev), &retry_policy, utils))
44 | |           .or_else(|err| {
45 | |             event!(Level::ERROR, label=%Events::EventHandlerFailure, ?err);
46 | |             Err(err)
47 | |           })
   | |____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
   = note: `#[warn(clippy::bind_instead_of_map)]` on by default
help: try
   |
44 ~           .map_err(|err| {
45 |             event!(Level::ERROR, label=%Events::EventHandlerFailure, ?err);
46 ~             err
   |

@szg251 is there an easy way to fail builds when any warning is issued? That's what we do in other places.


Home page suggestions show same entity twice

The random selection of predefined target, disease, drugs allows for selecting the same element twice:

We would like not to have entities repeated in the home page.

Completed by Carlos.


Resolve Astro build issues

I noted a build error after merging this PR yesterday:

https://github.com/skeletonlabs/skeleton/pull/3017

It's likely something small, like a linting issue. So I'll patch this up so our v3 docs are deploying properly once again.

The issue ended up being related to the Bluesky news feed. The API had changed slightly and this was causing a build failure. I've implemented a fix, but will likely return to this in the future to implement a more permanent solution that won't block the build process like this.


7777 does not multiply with numbers 9 and above, 8888 does not multiply with numbers 8 and above, 9999 does not multiply with numbers 7 and above

Describe the bug
5555 does not multiply with numbers 11 and above (11-9999), 6666 does not multiply with numbers 10 and above (10-9999), 7777 does not multiply with numbers 9 and above (9-9999), 8888 does not multiply with numbers 8 and above (8-9999), 9999 does not multiply with numbers 7 and above (7-9999)
To Reproduce
Steps to reproduce the behavior:

Input 7777 (can be first or second)
Input  9
Output is 4457

Expected behavior
7777*9 = 69993

The calculator only support storing and calculating of data in range of  0-FFFF


Prevent pushing a write frame on top of a readonly frame

Javaee-unittest silently modify the frame write permission even when it's on top of a readonly frame.
Consequently, such call won't fail whereas they should :
package com.iconloop.score.example;

import java.math.BigInteger;

import score.Context;
import score.VarDB;
import score.annotation.External;

public class HelloWorld {

    private final VarDB<BigInteger> myvar = Context.newVarDB("myvar", BigInteger.class);

    public HelloWorld() {}

    @External
    public void write () {
        myvar.set(BigInteger.ONE);
    }

    @External(readonly = true)
    public BigInteger entrypoint () {
        Context.call(Context.getAddress(), "write");
        return this.myvar.get();
    }

    @External(readonly = true)
    public BigInteger myvar () {
        return this.myvar.getOrDefault(BigInteger.ZERO);
    }
}

When calling entrypoint from a unit test using javaee-unittest, myvar will be modified, even though entrypoint is a readonly method. That's because entrypoint calls a write method write which overrides the readonly mode.
This PR force the readonly mode value when a frame is pushed on top of a readonly frame.

Basically, the annotation is not able to be checked with runtime reflection. We may use other ways. Until then, it's not the correct patch. So, I'm closing it at the mean time.


Allowing to specify patterns for ignored repos during org linking

This change adds a field "excludePattern" to the org model, which allows to specify a comma-separated list of repository names or substrings which are matched against the repository of an incoming or rechecked PR. If the string matches against the repo name, the PR is ignored and no
CLA check is done.
Fixes #157.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Coverage decreased (-0.4%) to 91.271% when pulling a965e13c08ec7fa269f7b26227b2d541cf153f55 on Graylog2:exclude-patterns-for-org-linking into e51b6fefe5050e9269ad4de5a73547f75cb46396 on cla-assistant:master.

Great job! 👍  Thank you for your contribution! 😄  It works good so far.
We appreciate it very much.
The only point I have: there is no way to find out which repos/pattern I've excluded after the org is linked. I could imagine to have this info as a popover placed on the org name or even better as a modal view, where the user can edit this entry.

Thanks for your quick review and feedback, I appreciate it very much! I am right now to add some test coverage for the isRepoExcluded function, so coveralls is happy again. After that I will add a popover to the organization list, that's a good idea!
I actually had in mind to add a function to the organization action menu which allows you to edit the pattern string, but that's a bit more work than the part which allows you to specify one during linking.

Coverage increased (+0.07%) to 91.713% when pulling e9af3d134386ddf1e067b421ad1919a9486573a7 on Graylog2:exclude-patterns-for-org-linking into e51b6fefe5050e9269ad4de5a73547f75cb46396 on cla-assistant:master.

Coverage increased (+0.07%) to 91.713% when pulling fbca91be6ea32aab6f908ce8600daf2e6a6aaf9b on Graylog2:exclude-patterns-for-org-linking into e51b6fefe5050e9269ad4de5a73547f75cb46396 on cla-assistant:master.

Is there a chance to get this merged and deployed to cla-assistant.io? We would have to set up our own instance otherwise.

Sure. This week or next week I'm going to take some time for review. After that we can take over your changes into CLA assistant

Coverage increased (+0.07%) to 91.713% when pulling 3ef8c3d9386eb21b45215bc31ea1c2ac3703a2a4 on Graylog2:exclude-patterns-for-org-linking into e51b6fefe5050e9269ad4de5a73547f75cb46396 on cla-assistant:master.

Coverage increased (+0.07%) to 91.713% when pulling 23508bc17cdb1b873e48e9d4c04c96328784cb24 on Graylog2:exclude-patterns-for-org-linking into e51b6fefe5050e9269ad4de5a73547f75cb46396 on cla-assistant:master.

Great job! Thank you for your contribution 👍
It looks good for me.
I did some minor changes on the UI: place the tooltip only on the org name and adjusted it's text for the orgs without exclude pattern. I hope you are ok with it.

I would love to be able to edit the pattern once i linked a organization

@fr34kyn01535 this feature is not implemented yet, but you are very welcome to make a contribution to this project 😏  See issue #182


Add option to run arbitrary command from project root

Add a option which allows running a command from the project root:
# for example, to edit your Cargo.toml file from any subdirectory of your project
$ just --cmd vim Cargo.toml

Closing, since I'm not sure this is really that important. Feel free to comment if you want this!

Gah, I can't decide on this. I think I should just implement it and see how it feels.

They definitely could, and it would be more ergonomic, however because of the weird way that argument substitution works, arguments would be split in unexpected ways. For example, if the recipe was written:
cmd +args:
  exec {{args}}

Then:
just --cmd echo 'a b; c' d
would be different from:
just cmd echo 'a b; c' d
Since in the second case the ; would get subbed into the recipe and be executed as two commands, the second of which would fail, since c isn't a binary on the path.

Then it sounds like the proper solution is to add some annotation which allows any multiple-argument token to be switched from $* behaviour to "$@" behaviour, rather than special-casing this example.

I agree that some kind of annotation would be a better solution, but it might not be worth it, given that this feature is probably not high priority. Unless there are other things that it would enable.
I think the best solution would actually be to do #161.
If there was a good shell which was implemented as a library, just could use that directly. Having access to the execution context of the shell would enable all sorts of really great features.
All just variables could be made available to the shell without having to export them and polluting the namespace of child processes.
x = 'a b; c'

foo:
  echo $x

1038 - 1145
and just foo would print a b; c. The {{...}} syntax could still be available for when you really want to do direct text substitution, but the common case would be to use $.
The shell runtime would distinguish between scalar values and list values (which zsh and bash already do), so if you had:
man args+:
  man $args

Then it would correctly forward two arguments to man in invocations like man 3 printf. #161 mentions some other features that this would enable.
I'm actually tempted to implement the rc shell in rust for this purpose. It's very simple, is decent to program in, and has support for arrays. (Actually, the only type of variable is arrays.) People generally think of it as being the Plan 9 shell, but it was actually first shipped with version 10 of Unix.
Of course, it has the huge downside of being different from what users have installed on their system and what they're used to.
What are your thoughts?

I agree that some kind of annotation would be a better solution, but it might not be worth it, given that this feature is probably not high priority. Unless there are other things that it would enable.

The problem is that there are very good reasons for having access to both $* and "$@" behaviours.
The space-splitting behaviour is necessary any time you want to pass a string of options to a subcommand without that subcommand taking up the one variadic position.
The quoting-preserving behaviour is essential for properly implementing any situation where you're receiving filenames in your variadic arguments.
To this day, legacy document-handling tooling like LaTeX (and, thus, LyX) is hampered by incompatibilities with spaces in filenames... in something meant to process books... books that tend to have spaces in their titles and, thus, intuitively, should have spaces in their filenames.
build-docs opts paths+:
	doc-thingy $opts "$paths"

If there's no syntax to make just build-docs '-vvv --format=rst' 'Thingy A.xml' 'Thingy B.md' produce doc-thingy -vvv --format=rst 'Thingy A.xml' 'Thingy B.md', then it's unavoidably a flaw.

I'm actually tempted to implement the rc shell in rust for this purpose. It's very simple, is decent to program in, and has support for arrays. (Actually, the only type of variable is arrays.) People generally think of it as being the Plan 9 shell, but it was actually first shipped with version 10 of Unix.
Of course, it has the huge downside of being different from what users have installed on their system and what they're used to.

That really is a huge downside because not only is rc strange and unfamiliar, I seriously doubt "Makefiles, with rc syntax" exists as a syntax definition for Just to piggy-back off of, and people rely heavily on syntax highlighting to make up for a limited understanding of a new grammar.
I'll need to get back to you on it when I'm not so tired though.

Yeah, that difference between behaviors is exactly the reason that the rc shell has pervasive supports for lists. There's a great paper about it. I won't be able to summarize well, but it goes into detail about how string splitting and re-scanning/splitting of string variables contributes to the complexity of the Bourne shell.
It also has a terrifying quote:

..., but it suggests something darker: nobody really knows what the Bourne shell's grammar is.

Or at least, it's a terrifying quote when I think about trying to implement a Bourne shell in rust.
The point about syntax highlighting is a good one. And, don't get me wrong, I definitely think that not being sh compatible is a huge downside, both because of lack of syntax highlighting, and because alternatives to sh don't seem to be popular.
However, I think I might be able to implement rc in rust on my own, whereas sh in rust would be a lot more work. But, sh in rust would probably interest a lot of people, either as a library that they can embed into a program, or as a starting point for an extensible shell written in rust, so I might be able to get some help with that.
In terms of supporting this particular use case, we could introduce a function-call syntax, and provide a built-in function to quote items of an array. This could look like:
build-docs opts paths+:
  doc-thingy {{opts}} {{quote(paths)}}

This has a lot of issues though. For example, what happens when a string in paths contains a quote? Should just try to escape it? And if so, will it try to figure out if the task is a shell task or a shebang task, so that it can escape it appropriately depending on the rules of string tokens in whatever particular language?
Ultimately I think that trying to get too clever about integrating with a shell (or any other language that a task might be written in) that isn't part of just itself is probably a bad idea, since there are too many factors to control. Even though it's a lot more work, I think integrating with a rust-written shell library is the way to go.

What about Ion for a shell?

Ion is super cool, but seems to be a bit of a moving target at the moment. Also, I'm hoping for a shell which is very simple, is as close to sh as possible (or is sh compatible), and which works on windows, so that just can have exactly the same behavior on every platform.

..., but it suggests something darker: nobody really knows what the Bourne shell�'s grammar is.

Boy, that takes me back. It must have been somewhere between 5 or 10 years since I ran across that quote.

Ultimately I think that trying to get too clever about integrating with a shell (or any other language that a task might be written in) that isn't part of just itself is probably a bad idea, since there are too many factors to control. Even though it's a lot more work, I think integrating with a rust-written shell library is the way to go.

Agreed. Trying to puppet an external shell sounds like an exercise in insanity.

However, I think I might be able to implement rc in rust on my own, whereas sh in rust would be a lot more work.

Is it really necessary to write a whole Bourne-style shell parser to handle tasks with no shebang?
I'd always thought that Make and inspired tools processed each line in isolation using some kind of restricted subset of Bourne shell syntax.
Given that just actually has a proper way to specify full-syntax Bourne shell (use a shebang) and the aforementioned misconception, how much complexity is someone going to try to cram into a single line when it'd be much less painful to just use a shebang?

I worry that providing a shell language that was close to but not identical to sh would be annoying when users ran into subtle incompatibilities.
Also, if it was a full fledged sh or rc shell, it would be less often necessary to drop into a system provided shell with a shebang.

The question is whether users expect that in the first place.
I don't know about you, but I've never seen a Bourne shell which implements the DOS batch file "prefix a line with @ to prevent echoing it" behaviour.

By the way, now that set positional-arguments is a thing, the quoting/escaping concerns raised by this comment can now be avoided by another workaround like
set positional-arguments
cmd +args:
  #!/bin/sh
  "$@"

which ensures the individual arguments stay quoted.

@kwshi Good point!
You're noticing a lot of places where set positional-arguments makes things easier. I wish I had thought of passing positional arguments to commands earlier, since it solves so many problems, I think it should have been the default from the beginning.
I'll most likely make it the default in 1.0 (see #769 and #808). It's a breaking change, since a custom interpreter set with set shell might not ignore additional arguments. But, since, almost all interpreters accept and ignore additional arguments, it's unlikely to be disruptive.


Add Runners, WebUI and Environment to the public API

This PR should fix #222.

Change how Runners and WebUI classes are created by introducing methods for this on Environment. (I think this was @cyberw's idea).
This allows us to get rid of setting environment.runner = self in the LocustRunner constructor.
It also provides an API for end-users who want to run Locust as a library.

Make WebUI automatically start the webserver greenlet and store a reference to it on WebUI.greenlet. It makes the API more similar to the runners, and I see no reason for why someone would want to create a WebUI instance without starting the web server.

Add runner classes, WebUI and Environment to the API documentation and improved docstrings for most of their public attributes and methods.

Wrote documentation on how to use Locust as a lib. It's enough to get someone started, but could still be improved.

Move RequestStats instance to Environment.stats.

Add Environment.locust_classes.

Remove Environment.options since it's no longer needed.

Use keyword only arguments for the Environment constructor.

Looks good except for the two things I mentioned!

Looks good except for the two things I mentioned!

Hmm, maybe it's just me not understanding the Github UI, but I can't see any other comments on the PR 😯 ?

Looks good except for the two things I mentioned!

Hmm, maybe it's just me not understanding the Github UI, but I can't see any other comments on the PR 😯 ?

Haha, no it was me not understanding the UI :) I had made those two comments but not clicked "open a review"

I actually left some comments on a previous PR the same way (I was wondering why you never replied to me :) https://github.com/locustio/locust/pull/1266#pullrequestreview-363111907 (most of that is probably outdated anyway)

I actually left some comments on a previous PR the same way (I was wondering why you never replied to me :)

Oops :)

LGTM now!

🙌   thanks!  this is awesome.


[web] ImageIcon inside AppBar renders incorrectly

When you put an ImageIcon inside an AppBar, it displays the icon on the bottom if you compile for web. On a device it looks ok.
Steps to Reproduce
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('bug?'),
        leading: ImageIcon(
          NetworkImage(
              'https://www.gstatic.com/images/branding/googlelogo/1x/googlelogo_color_92x36dp.png'),
          size: 20,
        ),
      ),
    );
  }
}

Expected results:
Same rendering as in on a device
Actual results:
Icon is displayed on the bottom

Logs

no need, it's just rendering

Analyzing iconimagebug...
No issues found! (ran in 2.2s)

[✓] Flutter (Channel beta, 1.21.0-9.2.pre, on Mac OS X 10.15.6 19G2021, locale nl-NL)
    • Flutter version 1.21.0-9.2.pre at /Users/wouter/Library/flutter
    • Framework revision 81a45ec2e5 (2 weeks ago), 2020-08-27 14:14:33 -0700
    • Engine revision 20a9531835
    • Dart version 2.10.0 (build 2.10.0-7.3.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/wouter/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/wouter/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.48.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (3 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 8.1.0 (API 27) (emulator)
    • Web Server (web)                   • web-server    • web-javascript • Flutter Tools
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 85.0.4183.102

• No issues found!

I was able to reproduce this on latest beta channel.

flutter doctor -v
[✓] Flutter (Channel beta, 1.21.0-9.2.pre, on Mac OS X 10.15.6 19G2021, locale en)
    • Flutter version 1.21.0-9.2.pre at /Users/pedromassango/dev/SDKs/flutter_beta
    • Framework revision 81a45ec2e5 (2 weeks ago), 2020-08-27 14:14:33 -0700
    • Engine revision 20a9531835
    • Dart version 2.10.0 (build 2.10.0-7.3.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.7)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.7, Build version 11E801a
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 48.1.4
    • Dart plugin version 202.7206

[✓] VS Code (version 1.48.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (4 available)
    • sdk gphone x86 arm (mobile) • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 11 Pro Max (mobile)  • 3DA251B5-C982-48C8-8FF5-C4D1DB21ED89 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-7 (simulator)
    • Web Server (web)            • web-server                           • web-javascript • Flutter Tools
    • Chrome (web)                • chrome                               • web-javascript • Google Chrome 85.0.4183.102

! Doctor found issues in 1 category.
Process finished with exit code 0

The text is also pushed to the bottom. I'm wondering if there's an issue with text layout not reporting correct baseline or losing style information. /cc @mdebbar

After investigation, I can confirm this is due to an SVG element not having a position attribute and adding a gap to the top (which is pushing the app bar title down).
This should've been fixed in https://github.com/flutter/engine/pull/21939 but got reverted in https://github.com/flutter/engine/pull/21986. cc @ferhatb I'm de-duplicating this issue with the one you fixed: https://github.com/flutter/flutter/issues/59451.
Duplicate of https://github.com/flutter/flutter/issues/59451


feat: Add AlwaysTrue/AlwaysFalse for Predicate enum.

See https://github.com/apache/iceberg-rust/pull/169#discussion_r1507941201 for details.
This is quite useful for expression rewrite.

Is this block by https://github.com/apache/iceberg-rust/pull/169?
I could work on this after this pr is merged.

Is this block by #169? I could work on this after this pr is merged.

Hi, @Dysprosium0626  Yes, it's blocked by #169. Welcome to contribute!


apply phpstan level 1

Apply phpstan level 1, catched various bugs:

coalesce null that should be ?:
unneeded issset check
too many parameter in method call
undefined variable/property
undefined index in array
missing abstract methods in Images BaseHandler
Fixes impossible returns false for BaseConnection::getFieldData(), getIndexData(), and getForeignKeyData()

There are ofcourse some that false positive detection that ignored.
Checklist:

[x] Securely signed commits

close-reopen to restart travis build

@MGatner all green 🎉

Level 1! 🥳


[Feature] File Title Edit from Details

Proposed
Edit file names from file details page. Follows project and wiki name edit format.
Repercussions
Area of input validation.

Pass 1 complete. The growl box issue definitely needs to be resolved, so ping me when done before it moves on.
Additionally, it would be great if we could change names without forcing a full reload of the page- any thoughts?

@abought, The issue with reloading just the file navigator is that it is not in index.js but in another 2 files between its instantiation and initialization. This is a bit of a complex architecture that doesn't have particularly clear lines of communications between parts of the page. So rather than leaving the user to wonder if their file has been renamed, because it still looks like the old file name in the navigator, it reloads the page. This might get us in trouble if they were editing the file and it threw away their changes that prompted the change in file name. However, we have sharejs so they won't lose their progress unless another user clobbers them. But that isn't something we can control at the moment anyway.

This might get us in trouble if they were editing the file and it threw away their changes that prompted the change in file name.

This is a good point- confirmed that if I change the filename while unsaved file edits are open, data is lost. (test case: CSV file) Can you reproduce this on your machine? If so we'll escalate to QA.

So rather than leaving the user to wonder if their file has been renamed, because it still looks like the old file name in the navigator, it reloads the page.

As discussed: if we can easily update the file navigator when the rename occurs, it's a better experience for the user. Worth at least a 5-minute assessment to check if it's possible.
But if it turns out that the parts of the page can't talk to each other at all, a reload is an acceptable workaround; this isn't so big as to be worth a boatload of dev time.
(tracking comments to keep a record for other reviewers)

I am unable to reproduce data loss on editing a document and then renaming the file before saving the edited content. I would suggest that this be flagged for QA to be on the lookout for, but still have a separate ticket for only reloading the treebeard instance, or using lazy load.

Pass complete.
Based on our discussion, I suggest that some of these growl boxes (particularly validation items) should be moved from growl to inline errors- see project dashboard page UI for a reference point in how renaming is handled there. (sorry for not catching this sooner)
Let me know if you have questions.

I am unable to reproduce data loss on editing a document and then renaming the file before saving the edited content. I would suggest that this be flagged for QA to be on the lookout for, but still have a separate ticket for only reloading the treebeard instance, or using lazy load.

Confirmed that I'm seeing this locally but not on your machine; perhaps my version of share.js is outdated.
Feel free to add a note for QA to the PR summary at top of this thread, so they know to look out for it when testing.

Note for code reviewers: in order to see file data, I had to pull in the newest develop branch. Otherwise I got mfr/waterbutler errors. (authentication has changed recently)

Filename bob/builder gives the following error message. Is that intentional?
The requested resource could not be found. If this should not have occurred and the issue persists, please report it to<EMAIL_ADDRESS>

That is the hardcoded msgLong that comes from waterbutler.

Pass complete. I'll move this to CR2 following results of a conversation with @Ghalko on flowdock.

That is the hardcoded msgLong that comes from waterbutler.

Interesting- the string is actually defined in the OSF. Not sure why waterbutler is returning a 404 when it fails to find an existing file, but that can be tracked as a separate issue.

Looks good. Tested locally; works well. Just a few minor changes above, which I will make when I merge.

Thanks.


remove duplicated code & enhance tests setup

closes #4

Thank you for your contribution, I just had to make few changes to comply with pre-commit hooks & GitHub Actions checks

@IbraheemTuffaha  I'm looking forward to contributing to this project. What exactly raise error for function documentation?

There are a few errors as you can see
But I choose to not include function or class docs unless it's a public package
Otherwise, I think docs only would clutter the code


rtl support for alert view (material design)

Ionic version:  (check one with "x")
[ ] 1.x
[X] 2.x
I'm submitting a ...  (check one with "x")
[] bug report
[X] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

alert view title and message are LTR now.
Expected behavior:

Steps to reproduce:

Related code:
      let prompt = this.alertCtrl.create({
                title: this.translate.instant("ERROR"),
                message: this.translate.instant("EVENT_OVERDUE"),
                buttons: [
                  {
                    text: this.translate.instant("DONE_BUTTON"),
                    handler: (data) => {
                      //Go back!
                      this.navCtrl.pop();
                    }
                  }
                ]
              });
              prompt.present();

Hello! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to driftyco/ionic-feature-requests#132

now does it supports RTL ?


Chore - Creating a form dum component, adding messages and validations

Added some tests for the selectors which shows how easy is to test form validations
@renvrant

When you run the app, I would recommend a wipe on the local storage so that you can see the form brand new and test the validations as you go
I'm not caring much about validations when the user fills the form out of the order, we're probably only demoing the happy flow since our intent is just show the concept (redux centre architecture) as oppose to a asshole bullet proof form

This looks great, great work!


:sparkles: add output velocity setter

addresses #4

This PR should also implement the setters for the Motor class


Bug Report: scores not saving

If you are playing a downloaded version of the game, what operating system are you using?
Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.
Windows, not sure which one-
What version of the game are you using? Look in the bottom left corner of the main menu.
3.1.1 I think it's called, it's the new one
Please describe your issue. Provide extensive detail and images if possible.
So I play the new songs and none of my scores have saved, they all stay at 0, just for the new songs

Fixed with #40, will be in the upcoming update.

v3.1.2 is up with the fix!
https://github.com/Jorge-SunSpirit/Doki-Doki-Takeover/releases/tag/v3.1.2


Leverage icons var for type inference

🎉

much better, thank you! i thought i needed to import react whenever i was using JSX but apparently not

@joshreisner I've never used laravel-mix before, but it looks like it handles the jsx transformations for us under the hood 😍  so the magic of not needing to import React comes from the jsx: preserve in tsconfig since ts doesn't need to use React.createElement ✨


The owner forces the usage to expire on transfer calls.

Hi,
Referencing the title above; the owner can basically dishonor the rental period (by transfer calls) which can lead to serious abuses.
My suggestion is that the usage must expire first before any transfer happens.
Please advise. And by the way, I love your idea and would like to help in any way I can.
Sincerely,
thmstrmnd

This is the response I got from @0xanders (Anders) in Discord:
"This is a reference implementation of ERC-4907. You could do a different implementation of ERC-4907. For Double, the ERC-4907 token will be staked to a doNFT contract , and the owner will  change to  the doNFT contract, the original owner could not change the user in the rental period."
Thanks Anders for the reply. I am now closing this issue.


Need to update description of SE-200 after initial discussion

Hi @DougGregor,
Update the description for SE-200 as discussed on the thread. I’ve sent you an email about this slightly irregular request.
Thanks
John

Closing this out because the review of SE-0200 has ended.

Thanks for bringing this up for review @DougGregor


rendering now suspended during all edits, rather than just attribute upd...

...ates

Does that mean the IPR will no longer track a parameter change when we preview something fast like a noise ? and It will only refresh when you release the control ?
-M

No, it just sends a command to the renderer to pause what it's doing, sends the edits, then tells the render to carry on. The higher level UI stuff will not be affected.


Doesn't work with Akka.Streams v. 1.3.5

Method not found: 'Void Akka.Streams.Stage.GraphStageLogic.SetHandler(Akka.Streams.Inlet, System.Action, System.Action, System.Action`1<System.Exception>)'.
at Akka.Streams.Kafka.Stages.ProducerStageLogic2..ctor(ProducerStage2 stage, Attributes attributes)
at Akka.Streams.Kafka.Stages.ProducerStage2.CreateLogic(Attributes inheritedAttributes)    at Akka.Streams.Stage.GraphStage1.CreateLogicAndMaterializedValue(Attributes inheritedAttributes)
at Akka.Streams.Implementation.Fusing.GraphAssembly.Materialize(Attributes inheritedAttributes, IModule[] copiedModules, IDictionary2 materializedValues, Action1 register)
at Akka.Streams.Implementation.ActorMaterializerImpl.ActorMaterializerSession.MaterializeGraph(GraphModule graph, Attributes effectiveAttributes, IDictionary2 materializedValues)    at Akka.Streams.Implementation.ActorMaterializerImpl.ActorMaterializerSession.MaterializeAtomic(AtomicModule atomic, Attributes effectiveAttributes, IDictionary2 materializedValues)
at Akka.Streams.Implementation.MaterializerSession.MaterializeModule(IModule module, Attributes effectiveAttributes)
It's looks like Akka.Stream API was changed and SetHanlder 'Void Akka.Streams.Stage.GraphStageLogic.SetHandler(Akka.Streams.Inlet, System.Action, System.Action, System.Action`1<System.Exception>)' was removed.

@trimsane You’re right, this was changed in the last version in order to provide a better type safety, see https://github.com/akkadotnet/akka.net/pull/3237 for details. It’s probably an easy fix, just need to use Inlet<T> instead of Inlet , might want to send a PR ?

@marcpiechura Yes, I want

@marcpiechura AkkaNetContrib/Akka.Streams.Kafka/pull/17


Publish should put in top level public

Fixed in<EMAIL_ADDRESS>commit 1a2344c


[TOPIC-GPIO] gpi_api_1pin test failures

* `gpio_api_1pin`: Failed all tested boards so far. Investigating this is my next task

There is one issue I've noticed just recently that may cause 1 pin testcase to fail. The testcases testing the new port functions attempt to verify that the driver doesn't change other pins than the one that was requested. But the test doesn't take into account that the LED0 pin it's using for testing may be on the same port as UART used for the console. When reading port values the pin serving as UART RX will introduce inconsistency to the port value the testcase is expecting. If you see failures in any of test_gpio_port_* tests please ignore it for now. I'll provide a fix.
Originally posted by @mnkp in https://github.com/zephyrproject-rtos/zephyr/pull/19579#issuecomment-539418063

Added issue for visibility.
#19379 for SX1509B also fails all test_gpio_port_set_* cases.  This case is a little more subtle and interesting: the nrf52_pca20020 Thingy:52 board has a RGB lightwell LEDs that are very bright, and RGB sense LEDs.  When the test green LED is illuminated the sense green LED goes high, so two pins on the port change in parallel.
FAIL - test_gpio_port_set_masked_get_raw
FAIL - test_gpio_port_set_masked_get
FAIL - test_gpio_port_set_masked_get_active_high
FAIL - test_gpio_port_set_masked_get_active_low
FAIL - test_gpio_port_set_bits_clear_bits_raw
FAIL - test_gpio_port_set_bits_clear_bits
FAIL - test_gpio_port_set_clr_bits_raw
FAIL - test_gpio_port_set_clr_bits
FAIL - test_gpio_port_toggle

Should be closed by #19782


CTRL+F12 not working when use dependency injection in ASP.NET Core controllers

Using ASP.NET Core 2.2, when I try to go to implementation for manager class I get the message "No implementation fount for ....".
I have an interface and the implementation.
The DI configuration is in startup.cs like this:
services.AddSingleton<IBoardingPassManager, BoardingPassManager>();
Some times works, some times not.

Please open a new issue and provide the repro project and the output of the OmniSharp log if you are still having troubles. I will close this one as outdated - thanks.


Fix shrink for intergenixc regions

The algorithm to show shrunk regions in intergenic spaces must be revised. Currently the shrunk region disappears completely.

@maxtico


Error: uninstallation completed with 1 error(s): job failed: BackoffLimitExceeded

During helm uninstall, some strange behaviour happening.  As you can see in the log 'Error: uninstallation completed with 1 error(s): job failed: BackoffLimitExceeded'. But the charts are uninstalling successfully, But not sure why such error messages are appearing. How can I prevent/eliminate this ?
NOTE:  This issue happens 1 out of 4 times randomly during uninstallation , though in call cases the charts are uninstalled as expected. But the error message appears in log.
code-server-chart kaapana-exp-extensions-chart-0.1.0 kaapana-platform-chart kaapana-plugin-chart kaapana-stab-extensions-chart-0.1.0 tfda-execution-orchestrator-workflow
kaapana-platform-chart already deployed!
1) Upgrade
2) Re-install
3) Uninstall
4) Quit
select option: 3
Starting Uninstallation...
Uninstalling releases
uninstall.go:93: [debug] uninstall: Deleting tfda-execution-orchestrator-workflow
client.go:290: [debug] Starting delete for "dag-tfda-execution-orchestrator" Job
client.go:128: [debug] creating 1 resource(s)
client.go:519: [debug] Watching for changes to Job remove-dag-tfda-execution-orchestrator with timeout of 5m0s
client.go:547: [debug] Add/Modify event for remove-dag-tfda-execution-orchestrator: ADDED
client.go:586: [debug] remove-dag-tfda-execution-orchestrator: Jobs active: 0, jobs failed: 0, jobs succeeded: 0
client.go:547: [debug] Add/Modify event for remove-dag-tfda-execution-orchestrator: MODIFIED
client.go:586: [debug] remove-dag-tfda-execution-orchestrator: Jobs active: 1, jobs failed: 0, jobs succeeded: 0
client.go:547: [debug] Add/Modify event for remove-dag-tfda-execution-orchestrator: MODIFIED
client.go:290: [debug] Starting delete for "remove-dag-tfda-execution-orchestrator" Job
uninstall.go:134: [debug] purge requested for tfda-execution-orchestrator-workflow
Error: uninstallation completed with 1 error(s): job failed: BackoffLimitExceeded
helm.go:88: [debug] uninstallation completed with 1 error(s): job failed: BackoffLimitExceeded
helm.sh/helm/v3/pkg/action.(*Uninstall).Run
        helm.sh/helm/v3/pkg/action/uninstall.go:142
main.newUninstallCmd.func2
        helm.sh/helm/v3/cmd/helm/uninstall.go:56
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/cobra@v1.1.3/command.go:852
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/cobra@v1.1.3/command.go:960
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/cobra@v1.1.3/command.go:897
main.main
        helm.sh/helm/v3/cmd/helm/helm.go:87
runtime.main
        runtime/proc.go:225
runtime.goexit
        runtime/asm_amd64.s:1371
uninstall.go:93: [debug] uninstall: Deleting kaapana-plugin-chart
client.go:290: [debug] Starting delete for "kaapana-plugin" Job
client.go:128: [debug] creating 1 resource(s)
client.go:519: [debug] Watching for changes to Job remove-kaapana-plugin with timeout of 5m0s
client.go:547: [debug] Add/Modify event for remove-kaapana-plugin: ADDED
client.go:586: [debug] remove-kaapana-plugin: Jobs active: 0, jobs failed: 0, jobs succeeded: 0
client.go:547: [debug] Add/Modify event for remove-kaapana-plugin: MODIFIED
client.go:586: [debug] remove-kaapana-plugin: Jobs active: 1, jobs failed: 0, jobs succeeded: 0
client.go:547: [debug] Add/Modify event for remove-kaapana-plugin: MODIFIED
client.go:290: [debug] Starting delete for "remove-kaapana-plugin" Job
uninstall.go:134: [debug] purge requested for kaapana-plugin-chart
Error: uninstallation completed with 1 error(s): job failed: BackoffLimitExceeded
helm.go:88: [debug] uninstallation completed with 1 error(s): job failed: BackoffLimitExceeded

Output of helm version:  Version:"v3.7.0"
Output of kubectl version: MICROK8s_VERSION=1.23/stable
Cloud Provider/Platform (AKS, GKE, Minikube etc.):  Openstack

Hi @santhoshcameo, we ask that users please provide a simple sample chart to help reproduce their issue. The output from helm create is a good starting point. Once you can reproduce the issue, that will help the community identify potential fixes and help serve as a test case preventing future code regressions. Thanks.

I can't tell what might cause the issue at first glance. Sounds like Helm asked Kubernetes to delete the Job, but Kubernetes failed to perform the deletion in a timely manner. Your best bet may be to investigate further as to why Kubernetes did not delete the Job.


sst.cloudflare.StaticSite deployment caching breaks css styling

I know that StaticSite for CF is undocumented and probably unfinished, but I have an issue with certain tailwind styles not being applied unless I disable my browser cache. I assume this is a deployment issue.
Cached site

How it should look:

It seems like the border and gap styles are not updating properly. I apologize in advance if this is not an SST issue.
Link to repo

Yeah we'll come back to this after some of the v3 launch support quiets down.


Improve performance of Layout/TrailingWhitespace

The Layout/TrailingWhitespace cop will be faster around 11%.
Profiling
require 'benchmark'

def rubocop_dev
  # `dev` is applied this change.
  system('rubocop _0.48.1.dev_ --cache false --only Layout/TrailingWhitespace > /dev/null')
end

def rubocop_master
  system('rubocop _0.48.1.master_ --cache false --only Layout/TrailingWhitespace > /dev/null')
end

n = 10

Benchmark.bm(16) do |x|
  x.report('dev'){   n.times{rubocop_dev}}
  x.report('master'){n.times{rubocop_master}}
end

 # In rubocop repository
$ ruby bench.rb
                       user     system      total        real
dev                0.000000   0.000000  98.100000 ( 98.152543)
master             0.000000   0.000000 110.270000 (110.310969)

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

Hehe, I thought we already had a cop for these scenarios, but I guess it's not very smart (identifying where a regexp can be replaced with String methods like start_with?/end_with?.

Those cops are called Performance/StartWith and Performance/EndWith. They can detect /\Asomething/ and /something\z/, and replace them with start_with?('something') and end_with?('something'). But when ^ and $ are used, the cop can't report because it can't know if the string that's being matched is multi-line or not.
In this case a cop would also have to detect the unnecessary .*, which would be possible but maybe a job for another cop. Perhaps a Regexp department could be added.

But when ^ and $ are used, the cop can't report because it can't know if the string that's being matched is multi-line or not.

I've noticed that in practice 99% of the times those are used it's a mistake - people simply don't know what they mean and actually needed \A and \z. Probably there should a cop for that. :-)


Fqdn validation

If any Root IngressRoute defined does not supply the fqdn value, then that object is invalid and should be skipped. Additionally, the status of the object is set to invalid.
(NOTE: This is currently blocked until #469 is merged.)
Example:
status:
  currentStatus: invalid
  description: Spec.VirtualHost.Fqdn must be specified!

// Fixes #447

Refactored to only println out the error and skip any routes which have an empty fqdn. Could be improved once #501 lands.

Closing, will be resolved in #501


Parent issue for IR optimization passes

This is a parent issue for all the basic optimization passes that we plan on adding. Please feel free to modify this description if you'd like to add more to it or remove some that you don't think are useful.

[x] Dead Code Elimination (DCE):

[x] https://github.com/FuelLabs/sway/issues/1786

[x] Constant folding and propagation

[x] https://github.com/FuelLabs/sway/pull/2615
[x] https://github.com/FuelLabs/sway/pull/2621

[x] Simplify CFG:

[x] https://github.com/FuelLabs/sway/issues/2398

[x] Memory to registers (mem2reg)

[x] https://github.com/FuelLabs/sway/issues/2770

[ ] Scalar Replacement of Aggregates (SROA)

[ ] https://github.com/FuelLabs/sway/issues/3136

[ ] Loop Invariant Code Motion (LICM)
[ ] https://github.com/FuelLabs/sway/issues/2755

Also:

https://github.com/FuelLabs/sway/issues/2399

Cool.  The above list is of optimisation pass categories really, and we can add sublists as we go.  E.g., there's already function inlining but it needs improvement as it currently inlines everything -- it needs heuristics to decide what & when to inline.  And we already have some constant folding but only for the intialisation of structs -- there are dozens of different areas where constant combining can be added separately.
As we add more passes there will arise the need for a pass manager too, but that can probably go in another issue.  I have had a few ideas for making a modern pass manager.  Might be worth creating an RFC for.

It might also be useful to take a look at Binaryen's set of optimizations, as well as their implementations, as the code is more self-contained and dependency-free, as compared to LLVM.

Slide 19 in this presentation from Graydon Hoare: http://venge.net/graydon/talks/CompilerTalk-2019.pdf
Frances Allen Got All The Good Ones

1971: "A Catalogue of Optimizing Transformations".
The ~8 passes to write if you're going to bother.
Inline, Unroll (& Vectorize), CSE, DCE, Code Motion, Constant Fold, Peephole.
That's it. You're welcome.
Many compilers just do those, get ~80% best-case perf.

@vaivaswatha I will keep this issue assigned to you as you own all its subtasks.


Move SwiftParser/Diagnostics to its own module

Just a bit of cleanup I wanted to do to keep the modules small and focused.
The idea is that SwiftParser just creates a SwiftSyntax tree and SwiftParserDiagnositcs produces nice error messages for such a tree.

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

https://github.com/apple/swift-stress-tester/pull/205
@swift-ci Please test

https://github.com/apple/swift-stress-tester/pull/205
@swift-ci Please test


Is there any plugin who can wake up phone when app is in background or terminated. Like whatsapp incoming call screen.

Hi All, Can you please help me to show incoming call screen like whatsApp when my app is in background or in terminated mode? Is there any solution with flutter? I am facing problem from one month.

@rahul69x
Your question is better suited for support channels. Please see https://flutter.dev/community for resources.
You may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing from here.


How do "--Frag" files work?

Checklist

[ *] I'm asking a question
[* ] I've looked through the README and FAQ for similar questions
[ *] I've searched the bugtracker for similar questions including closed ones

Question
Hello, I have a simple question but I didn't find the answer in the readme. It concerns frag files. For some videos, I find "--Frag" files followed by a number that disappears after a few seconds.
Is it possible to know what the number corresponds to?
Actually, I wonder if in case I download several files at the same time, there is a risk that there is a confusion with the "--Frag" files, or if the number that follows is there to avoid that.
Also, it is not possible to define a directory for these frag files even if they are only there temporarily?
Thank you

This is an implementation detail, you should not bother with that. Everything will be fine until you are not trying to intentionally break it by creating files with clashing names.

This is an implementation detail, you should not bother with that. Everything will be fine until you are not trying to intentionally break it by creating files with clashing names.