Stencil components prefixer

Now when we have quite a lot Stencil components and gonna have more it may become harder to distinct them from project components. Especially if they collaborate with each other. Plus it's never clear if it's a Stencil or project component modifier.
What do you think of the potential prefixer change for Stencil components. To  s- to identify it's a Stencil or to u- (cause partly it's also a utility).
I see issues with prefixing it with u- cause it will be mixed with the small utils plus it's not 100% utils (though it's still utils at least in the way how we use it).
Well, here is a thought. Thoughts?
@kpeatt @jeffkamo @ry5n @avelinet @yourpalsonja @mlworks @cole-sanderson

what's "ща еруь"?

Haha it was an accidental typo

I feel that we should not use s- as a stencil prefixes, because these classes must be overridable with the classes we define in our own /components directory which use c-. I also don't feel there's an issue with findabilty because we should all know that if you can't find a class definition in /components then it's in Stencil.
So no, I do not think that there is a need for an s- namespace.
As for the matter of u- I feel that there are some stencil components that we use less like the other components and more like utilities. For example, c-arrange get's used more like a utility. I understand that @ry5n had a particular philosophy that defined how that component was created and why it's a component, but so far it doesn't match it's practical usage. For example, we mix it in with markup that needs some structure that we don't want to write new CSS for, but we never add styles to it, which is something stencil components are intended to receive (new styles).
So I would be interested in discussing the possibility of re-name-spacing some of the components to be utilities.

I agree with Jeff, I don’t see the need to add a new namespace for Stencil components. I’m open to discussing whether some components should be re-classified. Specifically re: Arrange, it’s more complex than most utils so if we did make it into one it might need changes.

What sort of changes do you forsee having to happen if arrange were to become a utility?

@jeffkamo Well right now, utils do not have modifiers or sub-components. Arrange does. Utils are conceived as ways of applying low-level styling (at the level of one or a few css properties) to a single element.  But now that I’m thinking it through that’s not workable because you need modifiers for gutters and so on.
I would be happier keeping it as a component for that reason.

Good point about the gutters. Maybe that should be its own component? Perhaps too, the arrance sub-components should be their own utilities? Not sure if that makes sense... Something like...
// arrange
.u-arrange {
    display: flex;
    flex-direction:
    // etc.
}

// Align Items
.u-align-items-top {
}

// Justify Content
.u-justify-content-start {
}

// etc.

Perhaps that's getting out of hand? But again, this is effectively how we've been using the existing c-arrange classes in our projects.

Separate utils was what I was thinking but gutters make that not feasible. The way gutters should be implemented requires coordination between the parent element and the children. It must be a composite style pattern. Whether that deserves the name “component” or not is the question.
Not sure if it scales, but in this case we could consider an l- prefix for layout patterns like this. Their stylesheet would look like a component but the idea is you’d just apply the classes yourself and it might feel less weird when they overlap with other component classes.

Or we could just expand what utils are to cover this kind of case.

Hmm... are there any serious downsides to expanding what utilities can cover? Would that be opening it up to become a dumping ground for any class that isn't a "component"?
On the other hand, it's not completely inconceivable that we create another namespace... we did that for u- originally, we could do it again... but should we? My gut says no, as we already have so many.

I't say that utils describe themselves - they are utility items, helpers. Components are not helpers, they are page elements.

@nastiatikk Pretty good description. Yeah, I can see us expanding the definition of what a util is. Probably preferable to a new namespace. I need to think about it some more.
We can probably close this issue though – I think we agree no new namespaces for now.


Django CMS should ask before leaving the page when editing content

I was writing for a while in the Django CMS text editor, when I accidentaly pressed Ctrl+W in a flash. This is not so strange because I'm generally a console and vim user, so Ctrl+W means delete word before close tab for me.
The real problem is that this reflex act (that could also happen in many alternative forms, like closing a window and then remembering you were editing, closing the browser accidentally, pressing Ctrl+Q and more) has triggered half an hour of work lost.
That should not happen, not so easily.

Fixed by https://github.com/divio/django-cms/pull/5355


Verify passed bootstrap_server argument is a valid host:port

Observed behavior
There is a confluent addon that enables  end-to-end encrypted message streams through Confluent Cloud.
To be used, It need to be explicitly configured as an addon on the orchestrator'  project:
   ockam project addon configure confluent \
       --bootstrap-server YOUR_CONFLUENT_CLOUD_BOOTSTRAP_SERVER_ADDRESS

that bootstrap server address must be a HOST:PORT pair,  but currently no check is done when parsing the command arguments,  resulting in an error further downstream that is not that evident to the user.
Steps to reproduce
Pass any invalid string as the --bootstrap-server argument.
Expected behavior
It must verify that:

It follows the HOST:PORT  format

HOST is a valid hostname

PORT is a valid tcp port (enough to check it's <= 65535)

Probably a good idea to try to open a tcp connection to that address, to check there is something really listening there.

In case of errors on the format or address not being reachable,  terminate with an error message telling the user the encounter error.
Ockam Version
v0.113.0

Hi,
Can you assign this issue to me?
I would like to give it a try!

Hi, Can you assign this issue to me? I would like to give it a try!

hi, sure all yours! 👍 .    Please let us know if you have any questions as you explore


feat(locale): add support for Arabic

🔗 Linked issue
N/A
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This adds locale messages for Arabic.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks 😊


Test suite leaks secret-address-address-br-eakcsv

Describe the bug
The test suite leaks the secret-address-address-br-eakcsv secret.
To Reproduce
Start minikube and execute the following command:
make test-mk

Included in 1.0.16


Fix build with GCC 4.9.4

for loop iterator variables must be declared outside of the loop header in C89. Tested and confirmed to fix build with GCC 4.9.4 on Ubuntu 14.04.6.

Thanks!


core station's botany and chef mailing unit doesn't work

tested in a live round, not even the UI to choose the location pops up for the botany mailing unit

lol i know i totally messed up when setting it up, im going to rework chem layout and move the mailing unit for the next update


Updated package.json, readme and made .toolbagrc.js

Updated package.json, readme and made .toolbagrc.js

@mcdonnelldean

@shanel262 do you want to delete, not relevant any longer.


Add unlisted .nl RDAP service to overrides

Thanks for the contribution! Looks good to me.

Thanks! Yeah, it’s a convenient package with the ability to add overrides 👍

This is bundled into the new v2.7.3 release.


Composite memory maps currently impossible

I want to create a thread-local memory map (could be file-based or anonymous, I'd prefer anonymous) in each of N threads where the first M bytes of each thread-local mapping are mapped to the same file (which is itself mapped into memory). I know this allocation scheme is possible using plain mmap in Linux but I can't find a way to do it in memmap2-rs. That is, there is no way to map the buffer of a MMapMut into the buffer of another MMap* struct.
Am I wrong to believe this or is it truly impossible under the current API?

Can you please illustrate the C or at least plain mmap call sequence you would use?
From your description, I wonder why you just don't pass the byte slice itself to the other threads? And what kind of synchronization exists between them as multiple threads writing into the same mapping without synchronization is likely to imply a data race.

(It is also not clear to me what "thread-local memory map" means here as a memory mapping is by design process-wide as all threads share a single address space in which all memory maps are contained.)

Here's some code from the slice_deque crate that calls to the POSIX mmap:
let ptr = mmap(
            ptr::null_mut(),
            size,
            PROT_READ | PROT_WRITE,
            MAP_SHARED,
            fd,
            0,
        );
        if ptr == MAP_FAILED {
            print_error("@first: mmap failed");
            if close(fd) == -1 {
                print_error("@first: close failed");
            }
            return Err(AllocError::Oom);
        }

        let ptr2 = mmap(
            (ptr as *mut u8).offset(half_size as isize) as *mut c_void,
            half_size,
            PROT_READ | PROT_WRITE,
            MAP_SHARED | MAP_FIXED,
            fd,
            0,
        );

In ptr2, a second map is created by offsetting into the first map at ptr.
The reason for this is because I'm implementing a concurrent Prolog runtime in Rust with a consolidated heap. The first section of the heap (the memory map shared among all threads) is the atom table. The second section that comes immediately after it is the Prolog heap. Cells in the Prolog heap compose Prolog terms. Prolog terms can point down into the atom table.

From your description, I wonder why you just don't pass the byte slice itself to the other threads?
For the sake of sharing the atom table mapping across threads and because of the Prolog VM design, it's most convenient to map the atom table contiguously in memory next to the thread-local Prolog heap. In particular, converting atoms to strings (lists of characters) is very efficient.

(It is also not clear to me what "thread-local memory map" means here as a memory mapping is by design process-wide as all threads share a single address space in which all memory maps are contained.)
By that I mean that every VM thread will have its own MMapMut object that is local to that thread but that contains the atom table MMap* as a sub-map.

And what kind of synchronization exists between them as multiple threads writing into the same mapping without synchronization is likely to imply a data race.
Absolutely, I plan to use RCU to manage that. But that's outside the scope of the memmap-rs library.

A Lis of characters can live in either the heap or the atom table. I don't want to have implement logic to determine whether it points into another heap location or into a separate atom table. It would severely complicate the runtime. And slow it down considerably, too.

If PRs are welcome for this, I'll try to implement MAP_FIXED. I need it to work on Windows too, so I'll be looking at that as well.

You are right, fixing memory maps is not possible in Windows. Closing this issue.


Create surface.py

This script sets up the PlayingSurface class and has a function to generate an instance of it.
There's also a function to display the detected surface along with the original image and a contoured version.

all good


[mungegithub] Cherrypick application logging several errors

When inspecting stdout/err for cherrypick, one sees several messages of the kind:
E0724 03:49:47.562869       1 cherrypick-clear-after-merge.go:76] Unable to find the fork point for branch release-1.4. fatal: Not a valid object name origin/release-1.4

This issue was moved to kubernetes/test-infra#1635


Make /randomizeVcIterations:1 the same as normalizeNames:1

This change ensures that, when specifying /randomizeVcIterations:n, the first iteration is equivalent to that achieved by /normalizeNames:1. One consequence of this is that normalized names are always chosen pseudo-randomly (though deterministically, since it always starts with a fixed seed, which is 0 if not otherwise specified). It's slightly unfortunate to spend the computational expense of random generation when not strictly needed, but doing otherwise would require more complex logic.
Fixes dafny-lang/dafny#5126

Have you considered always using normalized names for the first iteration, if no randomSeed is specified?

Have you considered always using normalized names if the iteration has 0 for a randomSeed? That way we still use normalized names in the default case, but the first iteration always gets the same SMT, whether you're using --iterations or not.

Yeah, I considered doing that, and it was my original goal, but I concluded that the extra complexity in the logic was sufficient that I wasn't sure it was worth it. I haven't conclusively decided that, but it's the direction I'm leaning in.

I think that would require changing this line:
SolverOptions.RandomSeed = 1 < Options.RandomizeVcIterations ? split.NextRandom() : split.RandomSeed;

into just
SolverOptions.RandomSeed = split.RandomSeed;

And then you don't need the other changes in the PR.

I think that's just in the context of Dafny, right? That wouldn't work for Boogie running on its own, I don't think.

The reimplementation of measure-complexity already creates a separate Split with a different split.RandomSeed for each iteration.
You can also clean up Boogie by removing RandomizeVcIterations and Split.NextRandom and Split.randomGen, since Dafny no longer uses them.

The /randomizeVcIterations flag is useful for Boogie on its own, as well. I'd rather leave it in, so that other users of Boogie can benefit from it.

The /randomizeVcIterations flag is useful for Boogie on its own, as well. I'd rather leave it in, so that other users of Boogie can benefit from it.

I'm not comfortable with the implementation, for one because it reuses Splits for different iterations. With 0 users, how sure are you that this works well? Even Dafny has migrated off of this to get more reliable behavior.

I think we should remove the line DafnyOptions.RegisterLegacyBinding(Iterations, (o, v) => o.RandomizeVcIterations = (int)v); from Dafny. It's no longer needed because Dafny does not call the code that uses RandomizeVcIterations to start an iteration, and when this option is not set, SolverOptions.RandomSeed = 1 < Options.RandomizeVcIterations ? split.NextRandom() : split.RandomSeed; will behave as split.RandomSeed

Sure, that seems reasonable. And the fact that Dafny now controls the process of measure-complexity suggests that maybe it's better to fix dafny-lang/dafny#5126 in Dafny rather than Boogie. I hadn't realized before now that the logic for doing random iterations in measure-complexity had moved into Dafny.
So I'm going to close this PR, and perhaps create a simpler one that focuses on the Dafny issue. I'm not sure whether any Boogie users care about the difference that issue describes.


[HLO2Linalg] Clamp op lowering

This is the last op pattern missing for compiling Keras MobileNet.

Sorry for the confusion. This is meant to be for Clamp op.

I looked into the MobileNet model, and I don't find any clamp op. How do you hit the error?
The way I tested is:

build integrations/tensorflow/e2e:keras_vision_model_MobileNet_test
Run the model with command keras_vision_model_MobileNet_test --override_backends=tf,iree_vulkan

A mlir filed can be found from a log: Saving IREE input MLIR to: .... If you grep the file, you won't see clamp op.

Is override_backends=iree_vulkan using the structured ops path by default? I manually run iree-opt over the input MLIR by specifying --iree-use-linalg-to-spirv-path.

Oh I forgot to specify --model= in the command... Sorry about that.

Is override_backends=iree_vulkan using the structured ops path by default? I manually run iree-opt over the input MLIR by specifying --iree-use-linalg-to-spirv-path.

It's using the direct path by default.

Clamp must be supported now. Closing


SAK-41106 - Sites don't appear as auto-favorited before first time login

There were 3 suggestions I'd made on the jira. This fix is implementing #3. It will always try to favorite at least portal.default.tabs number of sites the first time someone logs in.

Have a another property to always favorite new sites on the first time for a user, no matter if it's the first time logging in ever or the first time since the upgrade when this feature existed.

Set some kind of preference on the user when they are created to say they're first time and haven't seen favorites, then when they get around to this favorites logic remove that. Then when it gets around to them remove that.

Previous suggestions by Austin (and possibly others?) to have a limit (probably set by property) for the number of sites auto favorite can add on the first time. (Maybe a reasonable compromise?)

I'm thinking of adding a sort type in here too . . . SortType.CREATED_ON_DESC. It wouldn't be as noticeable otherwise.

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/FavoritesHandler.java  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/FavoritesHandler.java  2

See the complete overview on Codacy

Thanks, I think the biggest issue here was you wouldn't end up with all of your thousands of sites favorited if you were a long term user in a lot of sites when the switch went over. I feel like someone new (or even someone existing) wouldn't mind as much (and would probably appreciate) if the latest X sites were marked as a favorite. This seems easier than other alternatives.


[d3d9] Silverfall crashes on startup

Silverfall crashes on startup with a "Failed to create surface" error. WineD3D works just fine.
Software information
Silverfall (GOG version).
System information

GPU: GeForce GTX 1080
Driver: 440.100.0
Wine version: 5.9 Staging
DXVK version: v1.7.1-7-g41a49a9

Apitrace file(s)
silverfall.trace.tar.xz
Log files

d3d9.log: silverfall_d3d9.log
d3d11.log: N/A
dxgi.log: N/A

Do the Wine logs mention child window rendering?
This looks like it could be that.

Do the Wine logs mention child window rendering?

Yeah, it is that. Sorry, I had wine logging disabled.
So there's no chance of it working with DXVK any time soon then, I take it?

It's a Wine bug.


View extension framework

This implements a visualization framework along the lines of:

Depends on #731
A rawData view extension is added and selected by default to show the network output in the same way as in the original generic type of networks.

I tested the gradient workflow and it's working well for me. But isn't it supposed to draw a red arrow in the direction of the gradient when you test an image? I thought I saw a screenshot from you that did that. Maybe I'll find out what I'm doing wrong when I dig into the code review ...

Our new URLs seem a little weird:
# classification (old)
/datasets/images/classification/new
/models/images/classification/new
# generic (old)
/datasets/images/generic/new
/models/images/generic/new
# gradients (new)
/datasets/generic/new/image-gradients
/models/images/generic/new?extension_id=image-gradients

Why the inconsistency? I like the move to /[datasets|models]/generic/new, why doesn't that work for models? And why does one specify the extension in the query string but the other doesn't?

I like the move to /[datasets|models]/generic/new, why doesn't that work for models?

The generic datasets now support any 3D data (barring bugs). I initially wanted to add generic models too to handle any 3D data but realized that it would be a huge change. We'd have to change a lot of the training and inference paths. So I thought as a first step we could use the existing image/generic models with both the image/generic datasets and the generic datasets.

And why does one specify the extension in the query string but the other doesn't?

No strong reason actually - I didn't know how to make the inference_id parameter optional when using URLs in the form of /models/images/generic/new/<extension_id>.

Ok, I figured you had a good reason for not creating /models/generic/. I agree we don't need to do all that work now, but I look forward to being able to do it eventually and to convert all datasets to /datasets/generic and all models to /models/generic, or whatever we end up calling them.

I didn't know how to make the inference_id parameter optional when using URLs in the form of /models/images/generic/new/<extension_id>.

This oughta work:
http://stackoverflow.com/questions/14032066/flask-optional-url-parameters

And why does one specify the extension in the query string but the other doesn't?

I have updated the "Generic datasets" commit to fix this. For image gradients, routes now look like:
# gradients (new)
/datasets/generic/new/image-gradients
/models/images/generic/new/image-gradients

If the extension ID is unspecified in the model creation URL, then this defaults to the "other" kind of datasets.


Get params file from existing cluster.

Something like opctl init --from-cluster

@rushtehrani Just to clarify, this should generate a params.yaml file?

@rushtehrani Just to clarify, this should generate a params.yaml file?

@Vafilor correct, params.yaml file pre-populated with values from cluster

@Vafilor correct, params.yaml file pre-populated with values from cluster


Download Landsat from us-gov-west-1

I'm trying to download Landsat imagery from us-west-2. When I run the attached code on my local machine, it works fine. When I run from AWS (us-gov-west-1) I get an "InvalidAccessKeyId" error. What am I missing? Can Landsat imagery on us-west-2 be accessed from us-gov-west-2 through the S3Client?

This is probably related to issue #365

I suspect this is because gov cloud is a separate account pool from us-west-2 and the access key is actually invalid. Where are the credentials you are using from the gov-cloud instance coming from?

Thanks for the reply. The credentials are coming from an IAM Role. I do not have access to edit or view the IAM Role, I would have to talk to our IT manager. I do know that the IAM Role has been configured to access specific S3 buckets within us-gov-west-1.

I suspect those are actually two separate accounts and the credentials for us-gov-west-2 are invalid for calls to us-west-2. But you'll need to check with your IT manager.

Thanks again. I'll touch base with him and let you know if/when this is resolved.

I updated to the latest after the fix for issue #365. I also found that there was an old credential file being used rather than the IAM Role. Now that the credential file has been removed, and the IAM Role is being used, I am getting an "InvalidToken" error. I have attached the log output. I am still missing something...
aws_sdk_2017-03-07-15.txt

Update and Clarification: After confirming that the IAM Role is being used (and not an old credential file) I am no longer getting an "InvalidAccessKeyId" error, but an "InvalidToken" error when trying to download Landsat imagery from us-west-2 to us-gov-west-1. The file downloads just fine from my local machine. I have attached the source code, the output log from AWS, and the output log from my local machine.
Looking at the difference between the two logs, there is no x-amz-security-token in the local log. Is the token even necessary for this request?
aws_sdk_2017-04-20-10_local.txt
aws_sdk_2017-04-20-16_aws.txt
S3_Test_cpp.txt

If authorization is the issue, here, is there a way to send a request with the CPP SDK without authorization?

If the creds are from an STS Assume Role call, then the token is necessary.
How are you acquiring these credentials?

When requesting from the EC2 instance on AWS, I believe the credentials are from an IAM Role. See the aws_sdk_2017-04-20-16_aws.txt above (this is the TRACE level log).
When requesting from my local computer, I don't believe it is getting credentials from anywhere. See the aws_sdk_2017-04-20-16_local.txt above.

You can make the call without creds just by using an AnonymousCredentialsProvider instead of the default. I'm not sure why the IAM role being vended by Ec2 is failing.
One weird thing though. It looks like there is data in your $HOME/.aws/config file? That may be causing some sort of collision.

I deleted the config file, but the issue remains. Can you point me to instructions on using an AnonymousCredentialsProvider. Right now I'm just allowing the default chain...

It works with an AnonymousCredentialsProvider. Thank you!


[WIP] Improved PHPDoc comments

What
Improve PHPDoc comments as per #438.
Why
As per #438.

Progress checklist for PHPDoc comments on public API entities:
Methods

[ ] Validator::__construct - create a validator instance with a custom factory
[x] Validator::validate - main entry point for validation
[x] Validator::check - BC alias of validate (pre-5.0.0), does not pass $value by reference
[x] Validator::coerce - BC alias of validate (pre-5.0.0), sets CHECK_MODE_COERCE_TYPES
[ ] Validator::getErrors - get array of validation errors
[ ] Validator::numErrors - get number of validation errors
[ ] Validator::getErrorMask - get the error categories
[ ] Validator::isValid - get overall validation status
[ ] Validator::reset - reset validation status
[ ] Factory::__construct - create a Factory instance with custom SchemaStorage, UriRetriever or $checkmode
[ ] Factory::setConfig - overwrite $checkMode
[ ] Factory::getConfig - get $checkMode or a filtered subset
[ ] Factory::addConfig - add options to $checkMode
[ ] Factory::removeConfig - remove options from $checkMode
[ ] Factory::getSchemaStorage - get the current SchemaStorage instance
[ ] Factory::getUriRetriever - get the current UriRetriever instance
[ ] SchemaStorage::__construct - create a SchemaStorage instance with custom UriRetriever or UriResolver
[ ] SchemaStorage::addSchema - add a schema to the storage instance by identifyng URI
[ ] SchemaStorage::getSchema - get a schema from the storage instance by identifying URI
[ ] UriResolver::resolve - resolve a URI to absolute
[ ] UriRetriever::retrieve - retrieve & return a decoded JSON schema object

Class Constants

[ ] Validator::SCHEMA_MEDIA_TYPE - official JSON schema media type
[ ] Validator::ERROR_* - error categories (bitmask)
[ ] Constraint::CHECK_MODE_* - validation options (bitmask)

Class Properties

[ ] Validator::$factory - dependency injection, state & instance management

Data Formats

[ ] The array data returned by Validator::getErrors()

Exceptions

[ ] InvalidArgumentException
[ ] InvalidConfigException
[ ] InvalidSchemaException
[ ] InvalidSchemaMediaTypeException
[ ] InvalidSourceUriException
[ ] JsonDecodingException
[ ] ResourceNotFoundException
[ ] RuntimeException
[ ] UnresolvableJsonPointerException
[ ] UriResolverException
[ ] ValidationException

@erayd I am ready to get in on this.
I have put #392, #438 and #440 in progress in the v6.0.0 project. Is it fair to say that this PR will satisfy those two open issues?
Also, how would you prefer I contribute to this work?


Group Browse buttons to corresponding concepts in select box

@KataBoku Hi, please publish the working branch (in a pull request), so that @tomas-knap can review your proposed solution.


As a team manager I can add a new player

Create a new player class that contains more information about the players such as,
Position
Rating (0 - 5 Star)
Remarks
Avatar
And update add, edit ,list, sort to include these fields accordingly.


Make default types configurable

The set of archives to import when initialising a server may be configured by editing brooklyn-tosca-config.yaml. Alien4CloudToscaPlatform.loadNormativeTypes is replaced by loadDefaultTypes, which is called by the class constructor.

Looks good. Thanks


Release v2.18.5

Closes #260
Closes #303
Closes #304
Closes #305
Closes #314
Closes #323
Closes #320
Changes

Increment Patch Version to 2.18.5

Bug Fixes
Internal Object

Fix Internal Object

fix newCoverageResult definition
fix newDataQualityReport definition
fix newStandaloneReport definition

mdJson reader

Cleanup & Fix Data Quality mdJson Reader

remove unused argmuments
remove unnecessary comments
remove undefined/unused variable
fix attribute names - conform to internal object
fix EvaluationMethod handling - array not object
fix missing require statements
handle nil and empty spatial representations

External Contact Identifiers

Added support for the external contact identifiers in the Simple HTML writer

sbJson reader/writer

Both reader and writer are restricted to "person" contact type
sbJson reader looks for orcId and maps to externalIdentifiers[ { identifier: <orcId value>, namespace: "ORCID", description: "Open Researcher and Contributor Id" } ]
sbJson writer looks for external identifier with namespace "ORCID" and maps the associated identifier to orcId
Increment version to 2.18.5

Range Element Description
Range Element Description was originally added as part of https://github.com/adiwg/mdTranslator/pull/241 but it was not tested so the following changes were needed.

Add rangeElementDescription to the internal object
Fix mdJson reader typo rangeElements -> rangeElement
Fix html and simple-html writers: typo rangeElements -> rangeElement and misplaced <br> tag

Data Quality

Implement Data Quality Reports HTML Writer

Add link for Data Quality
Handle empty citation object (any)
Refactor / format the html output for Data Quality
Implement all of Data Quality Reports HTML Writer
Handle empty citation in identifier writer
Handle nil representations for data quality

@hmaier-fws I went ahead and tagged you on this one so you're aware it's coming. This is a pretty sizable PR and I still need to update the comment with all the changes. It's almost ready but not quite.

Converted back to draft, need to update mdJson-schema to 2.9.1


UI Koto is prohibit distribution & modification!!!!

"ライブラリを許可無く加工、二次配布する事を禁止します。"

I think nobody here speak/talks Chinese so please explain the issue in English.
If you are talking about Unreal Instruments Koto AFAIK all those instruments are public domain and we are not even modifying nor distributing it, what you see on the website is a direct link to their website download.

I think nobody here speak/talks Chinese so please explain the issue in English.
If you are talking about Unreal Instruments Koto AFAIK all those instruments are public domain and we are not even modifying nor distributing it, what you see on the website is a direct link to their website download.

That's Japanese, I understand a little of Japanese.


feat: add new metadata protocol

Spec: https://github.com/vacp2p/rfc/pull/619
NWaku PR: https://github.com/waku-org/nwaku/pull/2062
Feature required for all implementations of TheWakuNetwork.

Weekly Update

achieved: Metadata protocol as a default when using shards merged to master


added radio button

#patch#

I know there isn't much code for the new component but it would be nice to an integration test that verifies the handleChange action is triggered when the radio button is toggled.

Approved - change to a #feature#


Uninstalling mods not working

If you try to uninstall a mod, unfortunately nothing happens.

What mod did you try to uninstall?

What mod did you try to uninstall?

SonsStars
https://sotf-mods.com/mods/aedev/sonsstars

This happened with https://sotf-mods.com/mods/smokyace/autostickpickup as well. Mod was disabled, but Uninstall button seems to do nothing when clicked.


feat: add local schema diff

If no remote URI is specified for schema diff it will attempt to diff the local project
closes #2174

I think this was based on a commit that was before the auto-format, and that is why it was messed up. I have rebased and now it looks better. I am not 100% sure this is the best way to handle formatting, if it ends up causing problems we can just disable it again.

Let's also add an integration test for this.

Should be all good now, assuming the integration test is ok


FLINK-2605 Unclosed RandomAccessFile may leak resource in StaticFileS…

…erverHandler

Your reasoning w.r.t. current scope of try block was the same as mine.
I think it is good to make the scope as accurate as possible. Generally speaking, we don't want to react to unrelated exception.
Please keep the current formation.

+1

+1
LGTM

+1
Merging...


Add a working patch option for get_json

Description
Minimal change, but removes the uuid field from the top-level node in a patch call.
Changes
Known Issues
Notes
Checklist

[x] My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
[x] I have updated the documentation to reflect my changes.
[x] My code changes have been verified by automated tests and pass all relevant test scenarios.

Ok, this is the second part of the puzzle that I promised you.
In order to create JSON for the reverse DFS patches, here is what you can do:
# create a set of all, old known uuids, but exclude the node to patch
suppress_uuid = set(old_tree_map.keys()) - {str(node.uuid)}
patch_json = node.get_json(is_patch = True, known_uuid=suppress_uuid)

I assume you have the old_tree_map as discussed.
The is_patch now removes the uuid from the top level node, I think that is required at the moment.


⚠ ClamAV has degraded performance

In e1583cc, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 410 ms

Resolved: ClamAV performance has improved in f1ee10f.


Application should be able to connect to Mopidy

Backend
The KTD extension should be able to communicate with the Mopidy framework

Just trying out creating issues in github.


[SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

What changes were proposed in this pull request?

Currently, there are some expressions that overwrite semanticEquals, which makes it not symmetrical. Ideally, expressions should overwrite canonicalized instead of semanticEquals.
This PR marks semanticEquals as final, and implement canonicalized for the few expressions that overwrote semanticEquals before.
Why are the changes needed?

To avoid subtle bugs (I haven't found a real bug yet).
Does this PR introduce any user-facing change?

no
How was this patch tested?

a new test

cc @viirya @maropu

BTW, could you make CI happy?

Test build #139711 has started for PR 32885 at commit 73aa6f2.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139711/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44234/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44234/

Yeah, +1 if CI passes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139775/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44301/

Test build #139789 has started for PR 32885 at commit 5095fff.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44315/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44315/

Test build #139789 has finished for PR 32885 at commit 5095fff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139789/

LGTM

thanks for the review, merging to master!


Rebase master with release-0.10.0 branch

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind chore
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:

@jgwest yes, I agree :') I was rebasing the master branch with the changes in the release-0.10.0 branch. After I released 0.10.0 I didn't update the master branch right away (slipped my mind with vacation and the amount of time it took to get the olm catalog PR's merged- my bad) but it seems like there were a lotttt of other changes also not synced to master branch from 0.10.0? I've already taken a look at the 0.10.0 changes that I made and I think there's okay, but I've requested Anand and Abhishek's to make sure everything else looks right before we consider merging it. If you also wouldn't mind taking a look, the more eyes on it the better!

@reginapizza Strangely, the 'Files Changed' tab of this PR seems to be reported changes to master branch that are already on master branch.

Okay I re-synced from master again (I can see I pulled from it originally, so I'm not really sure why it did all those commits over again) and now I think it looks much better! Thanks for the tip @jgwest

fyi- just updated this to also included the OLM manifests for the 0.9.1 release as well since those were also missing from master

Generated Code step is failing as there is diff reported in make bundle. @reginapizza Can you please take a look ?


I have error on live server, but when local it's working

I have error, I can't used it. I don't know how to trace this error. I've just composer install then copy all vendor files composer and etc to live server.
Live
PHP version: 5.6.18

Local
PHP version: 7.2.11

Code used:
require_once('vendor/autoload.php');
$provider = new League\OAuth2\Client\Provider\LinkedIn([
    'clientId'          => $linkedinApiKey,
    'clientSecret'      => $linkedinApiSecret,
    'redirectUri'       => $callbackURL,
]);

var_dump($provider->getAuthorizationUrl());

Are you sure that is a error of your code?, I made a some clicks and anywhere links not work.
https://crowdrating.io/how-it-works
Note: add this code below that your require_once:
`use \League\OAuth2\Client\Provider\LinkedIn;`


@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/opentelemetry-instrumentation-feedstock#8.


rootfs-builder: update centos arch key path

The key path of centos has removed from mirrors
Fixes #482
Signed-off-by: choury<EMAIL_ADDRESS>

cc @jongwu @bpradipt

thanks @choury, please add "Fixes" term in commit message, see https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#closing-issues

/test-ubuntu

/test

Hmm - looks like /test-ubuntu is broken (but /test works) @GabyCT, @chavafg.

/test


Allow scripted tags

For example ranks depending on players, allow scripts to return the correct tag depending on the player when a message is received in OnPlayerChat.
CustomChat.SetCustomTagFunction(func)
func would return a string and a color which can be used to show the rank (or no rank if nil is returned)

I've chosen to use a hook for this. Runs client side, and here's a example that was just added to the README:
hook.Add( "OverrideCustomChatTags", "custom_tags_example", function( ply )
    -- A sequential table with strings, colors or anything really
    local parts = {
        color_black, "(", Color( 0, 0, 255 ), "The " .. team.GetName( ply:Team() ), color_black, ") "
    }

    -- Should we keep the original custom tags that
    -- were added on the "[Admin] Chat Tags" menu?
    local keepOriginalParts = true

    return parts, keepOriginalParts
end )

@StyledStrike Can you add an option to put the tag after the avatar icon ?


WTFcsv sample data link in activity guide is broken

https://www.databasic.io/en/wtfcsv/ufo.csv is the link and it should redirect to the static.databasic.io server but it doesn't work.
See the file /views/wtfcsv.py for fixing

fixed!


[CT-661] test_builtin_set_function is flaky

Flaky (flakey?) test added by https://github.com/dbt-labs/dbt-core/pull/5107:
https://github.com/dbt-labs/dbt-core/blob/0d8e061a3d8d726bb10ff767d8f276439cc472b2/tests/functional/context_methods/test_builtin_functions.py#L43-L48
FAILED tests/functional/context_methods/test_builtin_functions.py::TestContextBuiltins::test_builtin_set_function

This is cropping up, unreliably, on a variety of systems and Python versions:

E       assert "set_result: {False, 1, 2, 3, 'foo'}" in '\n\n============================== 2022-05-18 09:53:50.328276 | 8031f5a4-c01a-455b-9acf-4ebac14497f5 ==============================\n09:53:50.328283 [info ] [MainThread]: Running with dbt=1.2.0-a1\n09:53:50.329122 [debug] [MainThread]: running dbt with arguments {\'debug\': True, \'write_json\': True, \'use_colors\': True, \'printer_width\': 80, \'version_check\': True, \'partial_parse\': True, \'static_parser\': True, \'profiles_dir\': \'/tmp/pytest-of-runner/pytest-1/popen-gw1/profile6\', \'send_anonymous_usage_stats\': False, \'event_buffer_size\': 100000, \'quiet\': False, \'no_print\': False, \'macro\': \'validate_set\', \'args\': \'{}\', \'which\': \'run-operation\', \'rpc_method\': \'run-operation\', \'indirect_selection\': \'eager\'}\n09:53:50.329772 [debug] [MainThread]: Tracking: do not track\n09:53:50.374089 [info ] [MainThread]: Partial parse save file not found. Starting full parse.\n09:53:50.420050 [debug] [MainThread]: Parsing macros/validate_zip.sql\n09:53:50.430266 [debug] [MainThread]: Parsing macros/validate_set.sql\n09:53:50.443607 [debug] [MainThread]: Parsing macros/catalog.sql\n09:53:50.451913 [debug] [MainThread]: Parsing macros/adapters.sql\n09:53:50.593...t_custom_name/get_custom_alias.sql\n09:53:51.743135 [debug] [MainThread]: Parsing tests/generic/builtin.sql\n09:53:52.873105 [debug] [MainThread]: Acquiring new postgres connection "macro_validate_set"\n09:53:52.873855 [debug] [MainThread]: Using postgres connection "macro_validate_set"\n09:53:52.874491 [debug] [MainThread]: On macro_validate_set: BEGIN\n09:53:52.875207 [debug] [MainThread]: Opening a new connection, currently in state init\n09:53:52.903665 [debug] [MainThread]: SQL status: BEGIN in 0.03 seconds\n09:53:52.904474 [debug] [MainThread]: On macro_validate_set: COMMIT\n09:53:52.905145 [debug] [MainThread]: Using postgres connection "macro_validate_set"\n09:53:52.905778 [debug] [MainThread]: On macro_validate_set: COMMIT\n09:53:52.916436 [debug] [MainThread]: SQL status: COMMIT in 0.01 seconds\n09:53:52.926373 [debug] [MainThread]: set_result: {False, \'foo\', 1, 2, 3}\n09:53:52.927120 [debug] [MainThread]: try_set_result: {False, \'foo\', 1, 2, 3}\n09:53:52.935994 [debug] [MainThread]: On macro_validate_set: Close\n09:53:52.939436 [debug] [MainThread]: Flushing usage events\n09:53:52.940424 [debug] [MainThread]: Connection \'macro_validate_set\' was properly closed.\n'

I guess because it's looking for {False, 1, 2, 3, 'foo'} and finds {False, \'foo\', 1, 2, 3}?

Yes. The order of the set isn't guaranteed, so we'll have to figure out some other way of checking this.


AhoCorasick broken

Looks like algorithm broken. For example
ahoCorasick.addString("a");
ahoCorasick.addString("aa");
ahoCorasick.addString("abaaa");
String s = "abaa";

Answer will be [0] - second string got lost.

Many thanks. Fixed.


Not able to push image into gitlab container registry from last 2-3 days

Is there an existing issue for this?

[X] I have searched the existing issues

Kubernetes Version
kubernetes version :- 1.24
Shipwright Version
latest version
Current Behavior
Since last two days kaniko-trivy and buildpack-v3 is not working.  Earlier i was able to generate image and push image to the gitlab container registry. but now I am getting 401 unauthorized error . I tried with gitlab root credential  but still it is not working. I am using this tool from last 5 month using same method. I have never faced this problem.
Expected Behavior
Image should be push to container registry of gitlab
Steps To Reproduce
No response
Anything else?
No response

@harshsing2891 thanks for reaching out. Could you double check that your gitlab credentials scope are usable for pushing to that registry? in addition, I will assume that the Shipwright version you are using is the v0.11.0.

Hi Team
yes gitlab token has sufficient permission to push image into gitlab registry and it was working from last 4-5 months. This issue i am facing recently only. I have checked with pushing image to  azure container registry that also not working but manually i am able to push image into azure container registry with same credentials.  It is only working for docker hub registry, please let me know any recent changes has been made.

@harshsing2891 can you please answer the question that was asked previously? Are you using v0.11 or are you using a nightly release of Shipwright?


Initial scheduler working prototype

Love this project! It's exactly what my team needed! In our current project, we need scheduler, here's a basic chatGPT implementation (this has had literally 10 mins work so definitely not merge ready) which seems to be working. This PR is more an expression of interest and so other works can be coordinated, definitely will be spending some more time on this in the future and helping out making this project fully-fledged! Cheers!

You legend thank you! I'll work through these over the next couple weeks as I get time, thank you! 🙏

I added an analysis action, but for some reason I can't update this PR with main. Please merge with main so the action will run.

@Attempt3035 are you planning on coming back to this?

Yeah planning to sorry 😅
If you are going to do it or want to close the PR for now that's all good, sorry it's taking me so long to get back to it!


Incomplete starter code

Can you please update the example code to be runnable? It looks like README has been updated several times to match the API changes and the runnable example that once existed has been lost in the process:
using ExplainableAI

# Load model and input
model = ...                      # load classifier model
input = ...                      # input in batch-dimension-last format

# Run XAI method
analyzer = SmoothGrad(model)
expl = analyze(input, analyzer)  # or: analyzer(input)

# Show heatmap
heatmap(expl)

# Or analyze & show heatmap directly
heatmap(input, analyzer)

I think it was easier when the model and input variables were defined beforehand. I have figured it out now, but it can be a frustrating experience for newcomers.

Sorry for the large delay. The ... in the example was due to DataAugmentations.jl having issues with inverted height and width dimensions.
I created https://github.com/adrhill/ImageNetDataset.jl for this purpose but (so far) decided against registering it. My PRs to DataAugmentations have since been merged an released, so I'll try to address this very soon.

Thanks!


Content for GF API intro

This issue will track tutorial content for learning how to implement VFs
Google doc:
https://docs.google.com/document/d/1pvyb58U77m50C_7R0wVamiaUpyWr3JYr0cd62uxR-7E/edit

Closing as we aren't going back to the doc for editing any longer


[FLINK-29100] Relax upgrade checks to allow stateless restart when no stable spec is present

What is the purpose of the change
Allow for upgrade of deployment with stateful upgrade mode that initially fails due to a non-recoverable error, just like it would be the case when the deployment ever reached stable spec.
Brief change log
Check for presence of stable spec before executing logic that assumes existing state.
Verifying this change
Added test for spec change before stable spec for all upgrade modes.
Tested manually by creating deployments with image pull error for SAVEPOINT and LAST_STATE upgrade modes. Verified that in either case spec update to valid image is reconciled and deployment becomes stable.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changes to the CustomResourceDescriptors: (no)
Core observer or reconciler logic that is regularly executed: (yes)

Documentation

Does this pull request introduce a new feature? (no)

I think only checking the existence of stable spec is too dangerous. The job can start up, take 2 checkpoints and go in a failure loop without the operator ever seeing it "stable".
Another problem with this approach is I think it introduces a bug with the initialSavepointPath logic. That field is only used in first deployment scenarios so with this change, it would be completely ignored the second time you try to fix your never running job.

Good catch. Looks like we are lacking test coverage for that.

I fixed a similar issue in this commit: ac21bc8
I think a slightly different approach would be a bit better:

Observer somehow marks the status as initial failure. It has to confirm that the jobmanager never actually started somehow.
In Reconciler if we get an upgrade and have initial failure, delete deployment & use ReconciliationUtils.clearLastReconciledSpecIfFirstDeploy(flinkApp);, reschedulre reconcile loop with 0 (like mid upgrade)

The reset process would need to be triggered by the spec change, not by observation of the pending deployment. What prompts the reset is that there is a spec change while the initial deployment has not been "reconciled". The pending deployment may succeed or not, operator cannot determine that. (Like in the situations that lead to the discovery of this issue, image pull error and entry point failure).
We can probably tighten the last spec change by also checking for presence of HA metadata. (FlinkUtils.isKubernetesHAActivated(deployConfig) && FlinkUtils.isKubernetesHAActivated(observeConfig) && flinkService.isHaMetadataAvailable(deployConfig)).

I am overall a bit skeptical whether we should add this "fix" or not, exactly because as you mentioned
"The pending deployment may succeed or not, operator cannot determine that."
If this is true, I think we should not try to fix this because it cannot be done without possible introducing a dangerous race condition. Even if we add any check about isHA active etc it can still happen that the job starts just after we checked.
The user always have the possibility to delete and re-create initially failed deployments and redeploying it.

Maybe what we could do in these cases is to:

Delete deployment but keep HA metadata
Check if HA metadata exists (if it does the job started in the meantime)
If HA metadata doesn't exist, clear spec (reset to initial deployment)

Unfortunately even then it's possible that the job simply started but FAILED completely (that would delete HA metadata) and we cannot be sure whether checkpoints were taken. So again I am not completely sure about this...

Why should this (from a users perspective) behave any different than a deployment after one checkpoint completed? I think we need a solution that does not require manual intervention.
Wouldn't the HA check accomplish exactly that? To handle the very low probability race condition we check the HA metadata again after we deleted the deployment. If present, then the existing upgrade logic proceeds because the deployment had actually succeeded. Otherwise we reset by clearing the last reconciled spec as you had suggested above.

Looks like there was a race condition here, too!

Unfortunately even then it's possible that the job simply started but FAILED completely (that would delete HA metadata) and we cannot be sure whether checkpoints were taken. So again I am not completely sure about this...

Yes, that could happen, at least theoretically! In practice though, wouldn't it be extremely rare that a job starts to checkpoint successfully and then goes into terminal failure (no longer attempting to recover from checkpoint) within the observation interval?

@gyfora I'm testing the approach we discussed offline:
            if (!flinkService.isHaMetadataAvailable(deployConfig) && deployment.getStatus().getReconciliationStatus().getLastStableSpec() == null) {
                // initial deployment failure, reset to allow for spec change
                flinkService.deleteClusterDeployment(
                                        deployment.getMetadata(), deployment.getStatus(), false);
                flinkService.waitForClusterShutdown(deployConfig);
                // in case the deployment succeeded between check and delete, fall through to the upgrade path
                if (!flinkService.isHaMetadataAvailable(deployConfig)) {
                    LOG.info(
                            "Job never entered stable state. Clearing previous spec to reset for initial deploy");
                    // TODO: this doesn't work because lastSpecWithMeta.f1.isFirstDeployment() is false
                    // ReconciliationUtils.clearLastReconciledSpecIfFirstDeploy(deployment);
                    deployment.getStatus().getReconciliationStatus().setLastReconciledSpec(null);
                    // TODO: reschedule immediate reconciliation
                    return Optional.empty();
                }
            }

I need to check why ReconciliationUtils.clearLastReconciledSpecIfFirstDeploy(deployment); does not work, this could point to another issue.

@gyfora PTAL

Created https://issues.apache.org/jira/browse/FLINK-29159


system/core/uri.php problem related to encoded characters

So I was porting my web from CI 2.2.0 to 3.0rc2 when I noticed a weird issue with the urls.
The thing is my website requires to pass some base64 encoded value in the url, that means from time to time I'll pass a = character, since it is a disallowed on codeigniter instead of allowing it through conf, back on 2.2.0 I decided to encode / decode the base64 with urlencode / urldecode (basically, transforming = to %3D). And that worked fine.
But on CI 3.0rc2 it doesn't work anymore (complaining about disallowed characters on URL, even thought I didn't change the allowed characters configuration and so it has remain the same in both versions)
After exploring for a little bit I've discovered in 2.2.0 the _fetch_uri_string method, defaultly fetched the uri from a _detect_uri method which also defaultly got it from $_SERVER['REQUEST_URI'] and $_SERVER['SCRIPT_NAME'] substracting the script route from the full route.
Now on 3.0rc2 the _fetch_uri_string method doesn't exist anymore and the task is apparently handled in the constructor. But not only that, the _detect_uri method also doesn't exist, and the default behaviour now is to get the uri from $_SERVER['PATH_INFO'] directly.
And that's the issue, the value on $_SERVER['PATH_INFO'] is already decoded, and hence any encoded character such as %3D is already decoded into it's maybe non-allowed version.
Some things I've tried or thought:
-Acording to $_SERVER manpage on php.net there should be a ORIG_PATH_INFO which is the original version of PATH_INFO before processed by php. Aparently that should be it, however I tried it and the only thing I got is an undefined index error (running on apache 2.4.7 with php 5.4.24, I'm aware this is not a codeigniter issue, just to prof I'm not too much outdated)
-Why was _detect_uri removed? it really looks like too much work to do for something that could be more easily obtained from a simple server var, but after all, correctness should be the priority.
-I don't know which processing is taken to transform ORIG_PATH_INFO into PATH_INFO (beside probably an urldecode), but if that was the only thing that's done, it should be easy to fake ORIG_PATH_INFO encoding PATH_INFO (taking care not to encode slashes /) so... explode -> encode -> implode
Other thought are welcome.

I discarded the last "solution" since someone could be accepting extra unencoded characters and that would make them receive encoded ones.

I think the new way is the right way of doing it, I don't want anyone bypassing the protection by encoding something that isn't allowed.
You're better off using sessions to store that base64 characters, As you're no longer limited to the 4K size which was there in the previous version of codeigniter.

You are not bypassing anything.
If an user types the url /foo/bar/%3D
the bar method in foo controller should receive the parameter "%3D" (which was what correctly happened on 2.2.0)
The bypass would be if you check the url using the %3D and then you send the controller the urldecoded version (in this case being the = character) which would also break the rule of receiving what the user actually wrote on the url.
And the session or anywhere else than the url don't make any sense in my case, I'm identifiying resources by their id which is a binary string converted to base64 for convinience. (But again, that's not the real issue)

This is not an issue.
Also, the server variable to use for URI fetching is configurable, it's just the default that has changed.

Sorry? So it's broken but it's not an issue... you are funny.
You might argue it's a php or apache bug for doing weird things on the PATH_INFO, but not an issue?!?!
Take a look at RFC 3986 (section 2.4 when to encode or decode)
For the record: "When a URI is dereferenced, the components and subcomponents significant to the scheme-specific dereferencing process (if any) must be parsed and separated before the percent-encoded octets within those components can be safely decoded"
In other words and bringing it to CI you shouldn't decode the url at least until you've determined the parts of the URL (controller / method / arguments...) and hence also done the safety check for unallowed characters.
Or are you making your own standard on top of that?
And no ofense but saying the URI fetching is configurable is like saying I should keep it in session... of course is configurable, I can also configure my website to don't use CI at all... but we are not talking about that, we are talking about something that's broken. (And actually was also broken on 2.2.0, but because of the default behaviour aparently no one noticed)

I'm not saying it's broken but it's not an issue. I'm saying it's not broken, which is why it's not an issue.
If you want me to be more specific, I'll say it this way: It's not a CodeIgniter issue.
We don't decide how PHP works and unless completely necessary, we won't try to work around it. If not for anything else, if we change how it works, more people will be complaining that their URIs are no longer decoded ... we can't satisfy every single use case. We try to satisfy the majority of use cases and there are numerous ways for you to achieve what you want (personally, I'd just pick an URL-safe version of Base64).
It's also unclear why you claim that it is an issue at all (excluding the fact that you've used URL-encoding once to work-around the URI filter) - if the URI filter doesn't get decoded data, it simply won't work.
I might also be misunderstanding what you're saying, but your comments so far only say that something is being decoded by default and you just don't want to happen ... that doesn't look like a bug description.
And no offense meant either, but we don't have that many configuration options just so you can ignore them and rely on auto-detection. Auto-detection is present because CI tries to be friendly even to the most inexperienced users and zero configuration always means easier usage, but it should never be relied on for anything beyond a fast setup. I'd expect somebody who uses IETF RFCs as their argument to have that in mind by default ...

You say: "if we change how it works, more people will be complaining that their URIs are no longer decoded"
The funny thing of your sentence is that up to 2.2.0 CI didn't decode the URI, and I'm sure you know better than me, but I quickly looked up on the issues and couldn't find a signle one complaining about their URIs not being decoded.
You say you can't satisfy every use case, and that's simply wrong, you CAN satisfy every use case, if you don't interfere with the use case itself. If you do interfere in the use case, some use cases will break.
"If the URI filter doesn't get decoded data it simply won't work" - wrong! the URI filter should get and hence use the very same data that the user browser requested. (And the very same data that the controller is going to receive!)
And you completely understand what I'm saying, the URI is being decoded by default, and it's not I don't want it to happen, it's it shouldn't happen, unless as said you want to have your own CI standard over those of RFC. (In which case I would stop discussing cause the palm of my hand wouldn't let me read your comments)
And as I see it, it's nothing about making CI more convinient for inexperienced users, whoever has a link on their pages with percent-encoded values, is because they explicitly made it (up to now I don't know anyone who encodes links with special characters "by hand") so I wonder, what's more convinient for both, experienced and inexperienced users, let the user handle it's values as she wishes (no interfering)? or make a funny guess that she wants it decoded and so decode it (interfering)?
In fact it's quite similar with the input class, in the input class you can request the raw value or the xss / mysql injection filtered one, right? I don't know you, but I can conceive a framework without the xss / sqlinjection filters, but I can't conceive one without the raw version.
And finally, (if you say you won't change it, it's ok, but plz answer those 2 questions):
1- Why was _detect_uri method removed in 3.0?
2- Which CGI have you seen that doesn't actually fill SCRIPT_NAME and REQUEST_URI?

Can you just add the disallowed characters to $config['permitted_uri_chars']?

@drivingmenuts
It's configuration, you can add anything you wish for yourself. If we added to the default every character that somebody might need, it would be pointless.
@Ignasimg
Look, I may just turn out to be wrong about some of this, but first you'll have to tone it down a bit and then be more clear about what it is exactly that you see as a problem. I'm usually not that polite when somebody acts as cocky as you and I'm only still replying because I feel you might have a valid point. But currently, you're not helping ...
First of all, your initial description only showed that url-encoding doesn't work for you and for some reason you don't want to extend your permitted_uri_chars list for no obvious reason. You also claimed that _detect_uri() was removed and asked why ...
Well, I don't consider that a bug report and hence why I closed the issue. And _detect_uri() was not removed - the URI class as a whole went through refactoring and the method is now called _parse_request_uri().
I'll ignore your attitude afterwards, but if you read the actual CGI spec, you'll see that CI is using PATH_INFO for exactly what it was designed for.
And again, as I said - you shouldn't be relying on autodetection.  PATH_INFO was simply given precedence over REQUEST_URI in the auto-detection process and there's nothing wrong about that.
3b72eb58e61581b7e92012a322be48e216491d7c
9dd2dbb8b9a3edecddcb3907b65a402fd1ae71b4 (yes, people have complained)
Now, I want to answer to this in particular:

up to now I don't know anyone who encodes links with special characters "by hand"

Attackers do, directly on the URI. And that's why the permitted_uri_chars filter exists ... it would be completely pointless otherwise, it wouldn't exist and we wouldn't be having this conversation. If the filter is applied before URL-decoding, anybody would be able to bypass it because they'd always be able to just URL-encode the characters they want to get through the filter.
Also:

And you completely understand what I'm saying

No, I didn't understand what you meant before your last comment and I'm still not quite sure if you're complaining about not having _detect_uri(), about URL-decoding by default, about using PATH_INFO or all of the three and why ... Even if you're correct in what you're saying, at least one of those complaints would be void.

I've got no problem admitting that I was wrong in something, but so far I'm just not convinced. Please drop the snarky remarks and try to explain yourself better.

Sorry for the confusion, I was responding to Ignasimg.

Oh ... my bad, I wasn't sure myself, but helpful suggestions are rare around here. :/

Ok sorry about my attitude, let's start again and hopefully I can explain myself better
1- I'm not complaining about MY problem (it was solved even before I posted the first post, maybe I shouldn't had explained all the bullshit, but I tought it was useful to know why I happened to need it)
2- I'm complaining about CI using PATH_INFO, which takes some arbitrary action on the URI, particularly urldecoding it.
3- There is no bypassing as long as what you check is what later CI uses to call the controller. If as you say an attacker wants to insert an equal symbol into the controller using %3D in the URI, two things might happen: CI uses the decoded version and simply refuses the request because it contains invalid characters, or CI uses the encoded version to check, the check is successful and the controller receives %3D (hence the attack also failed, cause attacker wanted an "=" not "%3D").
(Whoever argues this might still be a security risk cause some third party tool (such as a database) might decode it, yes I agree, but take care of such security risk is not a URI business but a third-party driver business)
4- You say according to RFC3875 PATH_INFO is being used exactly for what it was designed for. And I guess you are refering to the "identifies the resource or sub-resource to be returned by the CGI script" part. But it also states: "Unlike a URI path, the PATH_INFO is not URL-encoded, and cannot contain path-segment parameters.".
I'm not sure if a controller and method should be called a resource or a parameter, but what I'm sure is that CI (and any decent framework nowadays) shall support path-segment parameters.
5- About the people you mention complaining about not automatically decoding the url:
#388 is simply wrong. What happens is the browser automatically encodes those and so you should decode them by yourself when you want to use it.
#705 is the real issue. But after thinking a little bit I think the solution to this should be that the router internally urlencodes the keys of the array, taking care not to encode slashes and wildcards, and also keep the not-encoded ones (for CLI and weird browsers that don't auto encode URLs) in other words, I think the router should emulate the browser behaviour to encode the funny characters.
6- Yet another use case I just happened to notice, and I'll explain all the story like before, but IT'S ALREADY SOLVED! I have a website in chinese and I have some links like /foo/bar/[a few chinese characters] luckily or not the browser automagically percent-encodes the characters, older version of CI checks against the encoded one, no problem, (with the default allowed characters). If using PATH_INFO or the urldecoded version of REQUEST_URI to check for it, you gotta add "weird" rules on the allowed characters to keep your functionality. And not only chinese but spanish, french, german, russian, greek, ... I guess every language but english. And the more special characters a language has the more weird rules you need to add... do you guys seriously think this is normal?
7- I really took some time searching for people on google who couldn't reported their server let REQUEST_URI empty, and the every post complaining is either > 10 years old, or referencing IIS (which are somewhat less old but between 3 and 6 years old) and regarding IIS I didn't try it but there seems to be an official fix for that kb2277918 so I don't see any reason why we shouldn't be using raw REQUEST_URI and only this (beside the CLI)

1- I'm not complaining about MY problem (it was solved even before I posted the first post, maybe I shouldn't had explained all the bullshit, but I tought it was useful to know why I happened to need it)

2- I'm complaining about CI using PATH_INFO, which takes some arbitrary action on the URI, particularly urldecoding it.

OK, at least that is clear now.

3- There is no bypassing as long as what you check is what later CI uses to call the controller. If as you say an attacker wants to insert an equal symbol into the controller using %3D in the URI, two things might happen: CI uses the decoded version and simply refuses the request because it contains invalid characters, or CI uses the encoded version to check, the check is successful and the controller receives %3D (hence the attack also failed, cause attacker wanted an "=" not "%3D").
(Whoever argues this might still be a security risk cause some third party tool (such as a database) might decode it, yes I agree, but take care of such security risk is not a URI business but a third-party driver business)

It seems to me that you don't understand that filter's purpose and that in turn leads you to conclusions that make the filter feature seem irrelevant. You're not saying that directly, but encoding didn't matter to the filter - that's the logical conclusion.
It's not a magic filter to prevent SQL injections (although it may help with that), nor intended to reject invalid URI characters. It's supposed to validate input data by a user-configured pattern. Yes, there's a big scary warning about it in the config.php file, but that's only because our users tend to be quite careless about input validation and that's a way to encourage them to be more restrictive.
At the end of the day, it is still your configuration and your rules - if you need to allow '=' because it's part of a valid URL input for you, you should absolutely add it to the pattern.

4- You say according to RFC3875 PATH_INFO is being used exactly for what it was designed for. And I guess you are refering to the "identifies the resource or sub-resource to be returned by the CGI script" part. But it also states: "Unlike a URI path, the PATH_INFO is not URL-encoded, and cannot contain path-segment parameters.".
I'm not sure if a controller and method should be called a resource or a parameter, but what I'm sure is that CI (and any decent framework nowadays) shall support path-segment parameters.

Yes, a controller/method pair is essentially the resource that you access. You are correct about the rest however, so I guess you will get what you want. :)

5- About the people you mention complaining about not automatically decoding the url:
#388 is simply wrong. What happens is the browser automatically encodes those and so you should decode them by yourself when you want to use it.
#705 is the real issue. But after thinking a little bit I think the solution to this should be that the router internally urlencodes the keys of the array, taking care not to encode slashes and wildcards, and also keep the not-encoded ones (for CLI and weird browsers that don't auto encode URLs) in other words, I think the router should emulate the browser behaviour to encode the funny characters.

No ... that's too much requirements to satisfy for something that's not the router's job anyway.
To be honest, I never liked those suggestions, but my point stands - people simply want this behavior because it's makes life easier for them, and they do and will complain when they don't have it.
So at this point I'm thinking a configuration value that enables automatic URL-decoding for those who want it.

6- Yet another use case I just happened to notice, and I'll explain all the story like before, but IT'S ALREADY SOLVED! I have a website in chinese and I have some links like /foo/bar/[a few chinese characters] luckily or not the browser automagically percent-encodes the characters, older version of CI checks against the encoded one, no problem, (with the default allowed characters). If using PATH_INFO or the urldecoded version of REQUEST_URI to check for it, you gotta add "weird" rules on the allowed characters to keep your functionality. And not only chinese but spanish, french, german, russian, greek, ... I guess every language but english. And the more special characters a language has the more weird rules you need to add... do you guys seriously think this is normal?

No, I don't think using non-ASCII characters in an URI is normal and I'd rather discourage it.
I did think of a better example on my own however - you may want to use slashes inside of an URI path parameter, which automatic decoding prevents you from doing.

7- I really took some time searching for people on google who couldn't reported their server let REQUEST_URI empty, and the every post complaining is either > 10 years old, or referencing IIS (which are somewhat less old but between 3 and 6 years old) and regarding IIS I didn't try it but there seems to be an official fix for that kb2277918 so I don't see any reason why we shouldn't be using raw REQUEST_URI and only this (beside the CLI)

Well, it wasn't a case for not using REQUEST_URI. It was a case for using PATH_INFO because it's simply easier to work with - it requires less manipulation and that results in improved performance. Obviously, we didn't have your arguments presented at the time, so ... that's that.

Will commit the necessary changes shortly, thanks for your patience.


Fix/considering self sufficient validation

#869347jdh

Fixed swap localization for operations
Fixed validation which should consider minimal balance if we send tokens to non sufficient asset
Fixed validation text that for feeAsset.transferable > fee + ed
Fixed validation text that for feeAsset.transferable > fee
Old text: You can use up to %s since you need to pay\n%s for network fee.
New one: Sorry, you don't have enough funds to pay the network fee.

Task linked: CU-869347jdh Android. Wrong validation text

Fixed sufficient balance to pay fee validation in case when nativeAsset = feeAsset


org.redisson.client.WriteRedisConnectionException

Some time getting following exception in unit tests but not always
org.redisson.client.WriteRedisConnectionException: Unable to write command into connection!
Node source: NodeSource [slot=0, addr=null, redisClient=null, redirect=null, entry=null],
 connection: RedisConnection@1405217801 [redisClient=[addr=redis://localhost:6333],
channel=[id: 0xec022dc7, L:<IP_ADDRESS>/<IP_ADDRESS>:38200], currentCommand=null], command: (EVAL),
params: [local v = redis.call('hget', KEYS[1], ARGV[1]);
redis.call('hset', KEYS[1], ARGV[1], ARGV[2]); retur..., 1,
RequestCache, PooledUnsafeDirectByteBuf(ridx: 0, widx: 42, cap: 256),
PooledUnsafeDirectByteBuf(ridx: 0, widx: 103, cap: 256)] after 3 retry attempts
Caused by: io.netty.channel.StacklessClosedChannelException

you need to check your instance since it closes channels.

@mrniko  thank for reply. I have 14 tests some time(1 out of 100 run) one of them failed. i am starting embedded-redis with @BeforeClass also check with external redis never seen instance is down as i can perform redis operation using redis-client. By the way my implementation have Rlock.

you need to check your instance since it closes channels.

What do you mean by this?  Are you saying that the Redis Server is closing the connection?

@packley1
I mean to check network

@packley1
I mean to check network

So we are seeing this same error, but only under very specific conditions.  Generally everything works well, we load tested and did not see this error.  However, when we attempt to retrieve a large object from the cache, it is fine.  However, if multiple threads retrieve the same large object from the cache at about the same time, we start seeing this error.  When we fetch the item from the cache, we do update the expiry time from each thread - could this be an issue (updating the same cached object from multiple threads)?

can you suggest test case to reproduce it?

@packley1
You need to increase nettyThreads amount. Decoding 18Mb of data may make netty thread busy and block queued connection operations.

@packley1
You need to increase nettyThreads amount. Decoding 18Mb of data may make netty thread busy and block queued connection operations.

I did try this, set it to 128.... No changes.
My solution/work around is to make sure the same key is not requested simultaneously.  So far this is promising.
I will put together the sequence which causes this issue, in the next day or so.

@packley1
You need to increase nettyThreads amount. Decoding 18Mb of data may make netty thread busy and block queued connection operations.

I did try this, set it to 128.... No changes.
My solution/work around is to make sure the same key is not requested simultaneously. So far this is promising.
I will put together the sequence which causes this issue, in the next day or so.

@packley1  any update?

In a nut shell this problem occurs when we make simultaneous requests to REDIS for cached data which is large (in our case the cached data was 18Mb).

@packley1
Did you try to increase connections amount?

I have checked. Increased size of connection pool solves the issue.


Rename schedules to schedule

This Pull Request has the same purpose as https://github.com/matchai/waka-box/pull/6.

Thank you for the fix! 😄


Test TRIBOL_DIR= in Serac (rather than Smith)

Now that Tribol is a part of Serac's build system it would make more sense to test this here. Or require tribol?

Fixed by https://github.com/LLNL/serac/pull/1054. Not sure why it didn't auto-close.


Unblock tasty-discover on stackage (via tasty-hedgehog)

Following from https://github.com/fpco/stackage/pull/3140.

I've raised https://github.com/qfpl/tasty-hedgehog/issues/4 to start to resolve this.


Add Everblush

I would really like to see the Everblush theme added into Pragtical.
The theme has already been ported to Lite XL, however it hasn't been added to the Lite XL repositories.
https://github.com/Everblush/lite-xl

Done! Thanks for reporting this style!


My Resources Page: Implement Resource Labels

The My Resources page will enable users to organize resources using labels. The following is needed to implement this:

[x] Implement a label button on the My Resources page with a drop down from which labels can be selected for a selected resource
[x] Implement the ability for the user to create new labels that show up in the drop down list
[x] Implement the labels as a facet in the filter panel of the My Resources page.

Are the 'labels' user specific?

Yes - labels are user specific.  They are not the same as the keywords in the science metadata for a resource. They are effectively an organizational tool for users - think "virtual folders".

Great!

Great!


Error executing "predict(m, future)" -> Error in x - fits : non-numeric argument to binary operator

Hi guys,
I don't know if this is related to issue #31, or #34, but as I try to generate predictions with the prophet model / object, I get the following error
>single_TS_fcast <- predict(m, future)

Error in x - fits : non-numeric argument to binary operator
In addition: Warning message:
In mean.default(x, na.rm = TRUE) :
  argument is not numeric or logical: returning NA

Training the model gives me the following output
> m <- prophet(single_TS_prophet)

STAN OPTIMIZATION COMMAND (LBFGS)
init = user
save_iterations = 1
init_alpha = 0.001
tol_obj = 1e-012
tol_grad = 1e-008
tol_param = 1e-008
tol_rel_obj = 10000
tol_rel_grad = 1e+007
history_size = 5
seed = 981261820
initial log joint probability = -15.0584
Optimization terminated normally:
  Convergence detected: absolute parameter change was below tolerance

Any ideas? Kind regards

Solved,
Must be something regarding the handling of the predict() function from 'forecast'.
Alternatively ran
forecast <- prophet:::predict.prophet(m, future)
and it works.
Regards,


How to make forum private?

Hi, is there a way to put the forum private? For example, add a blank page only with the login to enter the forum?
Thanks...

Add this code to controller/home.php and  controller/topic.php
Auth(1, 0, true);


Using model without pertained weights

Hi,
I wonder is there a way to only use the model themselves without loading the pre-trained weights into them? Something like "model=pnasnet5large(num_classes=1000, pretrained='None')".

pretrained=None should work
https://github.com/Cadene/pretrained-models.pytorch/blob/master/pretrainedmodels/models/inceptionresnetv2.py#L372

Oh yes! Thanksssss🙏


Revise timestamping

There are some inconsistencies in our timestamping that this PR addresses to fix.
First, we currently query the TF tree for the odometry from the beginning to the end of the current scan. This is incorrect because the sensor might drop frames, and we, in that case, ignore the odometry during that time.
Second, we assume that the timestamps of the points are absolute, which is not necessarily the case.
We can still not cover one case: if the timestamp of the ROS message is the beginning of the scan and no timestamps are provided for the points. In such a case, there is no way to query the correct odometry from TF because the exact timestamp at the scan's end is unknown.

Introduce the TimeStampsHandler module
I now introduce the TimeStampsHandler module, which implements the logic discussed with @benemer, that is:

If the per-point timestamp is not provided or the `PointCloud2' msg is stamped at the end of the scan, we use the msg stamp itself to query the tf for the odometry or
If the per-point timestamps are provided and the message is stamped at the beginning of the scan (as it should), then we add the scan duration to the message stamp to query the TF for the corresponding wheel odometry.

In both cases, the end stamp of one odometry query will become the begin stamp of the following query.
The only breaking point I see until now is if the scan is stamped at the end and the relative timestamps in the PointField have a negative value. In that case, our motion compensation will break very severely... This shouldn't happen (last famous words).

The current implementation misses the combination of stamping at the beginning of the scan and having relative timestamps. Right now, we assume you stamp at the end, even though you can get the duration from the timestamps.
Also, having negative timestamps for de-skewing does not work when using the KISS deskewing because we subtract the mid_pose_timestamp=0.5 from it, see here.


export {} from 'xxx' got wrongly compiled to export {}

🔎 Search Terms
reexport, export {} from
🕗 Version & Regression Information

This is NOT a crash
This changed between versions ______ and latest
This changed in commit or PR _______
This is the behavior in every version I tried, and I reviewed the FAQ for entries about import/export, but non of them match
I was unable to test this on prior versions because _______

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.4.0-dev.20231217#code/KYDwDg9gTgLgBAbwL5wGZQgWzgclQSwBtgcg
💻 Code
index.ts
export {} from './file';

file.ts
export function foo() {}

console.log('side effect')

🙁 Actual behavior
index.ts was compiled to:
export {}

if "module": "esxx" and any other ESM settings,
and the following code under CJS module systems:
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });

🙂 Expected behavior
Compiled index.js should preserve the from './file' so that the statement has the same semantic (a reexport that has some side effect).
That is, if the code snippets above are raw JavaScript, then executing them should have 'side effect' string printed on command line, however, given TypeScript compiled code, it will not print that string. (In both scenarios, the entry point is index.js)
Additional information about the issue
No response

I believe this is by design, use the verbatimModuleSyntax option to get the desired behavior, that’s what this option is for (https://www.typescriptlang.org/tsconfig#verbatimModuleSyntax).

@guillaumebrunerie Thanks for providing the link and I have read it and tried it manually, the verbatimModuleSyntax option is truly helpful in preserving blank expression export/import {} from 'xxx' in case of any side effects, and it is in the experiment did I notice that if that option is disabled, import {} from 'xxx' will also be compiled to export {}.
Though this problem can be workaround by using that option, I think it is just a coincident, since verbatimModuleSyntax is designed to easily handle type import/export and value import/export, this issue is more focused on side effects if import/export specifier list is empty.

This behavior is consistent with our other import removal strategy. Enabling VMS is the correct configuration change to make if you have modules with side effects.


[BUG] Downloaded Weather Model (.nc) is not consistent with the bounding box

Describe the bug
I have multiple occasion that I download the weather model (WM) using raiderDelay.py with a bounding box or GPS station parameter. It does not have problem throughout the download process. However, when I need to extract values from multiple dates in the AOI, there are some mismatching in the shape (WM grid nodes). x and y dimension is not consistent. z level is consistent with 38 levels but the level may not be the same for all the days I downloaded. I plot every 30 days of the WM and AOI for reference for such mismatching behavior and WM download with list of GPS stations.
To Reproduce
Steps to reproduce the behavior:
raiderDelay.py --date 20170101 20191231 --time 23:00:00 -b 39 42 -81 -76 --model ERA5 --out Projects/InSAR/weather_file/ -v
!raiderDelay.py --date 20151029 20151112 --time 16:00:00  --station_file GNSS/Hawaii/Special_time/gnssStationList_overbbox.csv --model ERA5 --out GNSS/Hawaii/Special_time/GPS_station_delay -w GNSS/Hawaii/Special_time/weather_files --verbose
Expected behavior
It is expected to have the weather model downloaded where-ever it's specified within a bounding box or list of GPS stations.

Desktop (please complete the following information):

RAiDER git tag: raiderDelay.py --bbox   and --station_file
OS - Run on conda env with jupyter notebook and and foundry.

Additional context
I have not plot the difference in z-levels. I have only done some inspection by printing out all the z-levels and compare. I could include them in here later.

@bbuzz31 @jlmaurer i believe this has been resolved. Please confirm

I think this is okay now:

yaml:
aoi_group:
  bounding_box: 39 42 -81 -76

date_group:
  date_list: (20170101, 20170131)

look_dir: right
los_group: {}
runtime_group:
  output_directory: .
  raster_format: nc
time_group:
  time: '23:00:00'
weather_model: ERA5


Add entries to aux_dictionary.tsv and oss.tsv

Pull requests to the Mozc project are limited to the specific directories.
Files and directories we may accept pull requests:

files in the top directory
docker/
docs/
src/.bazelrc
src/BUILD.(library).bazel
src/data/oss/
src/data/test/quality_regression_test/
src/WORKSPACE.bazel

Although Google company policy certainly allows Mozc team to accept pull
requests, to do so Mozc team needs to move all Mozc source files into
third_party directory in the Google internal source repository [1].
Doing that without breaking any Google internal project that depends on
Mozc source code requires non-trivial amount of time and engineering
resources that Mozc team cannot afford right now.
Mozc team continues to seek opportunities to address this limitation,
but we are still not ready to accept any pull request due to the above
reason.
[1]: Open Source at Google - Linuxcon 2016

License Compliance

We store all external open source code in a third_party hierarchy,
along with the licenses for each project. We only allow the use of OSS
under licenses we can comply with.
Use of external open source is not allowed unless it is put in that
third_party tree.
This makes it easier to ensure we are only using software with
licenses that we can abide.
This also allows us to generate a list of all licenses used by any
project we build when they are released externally.

@googlebot I signed it!


python311Packages.plugwise: 0.33.1 -> 0.33.2

Diff: https://github.com/plugwise/python-plugwise/compare/refs/tags/v0.33.1...v0.33.2
Changelog: https://github.com/plugwise/python-plugwise/releases/tag/v0.33.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 262483 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.plugwise
python310Packages.plugwise
python310Packages.plugwise.dist
python311Packages.plugwise
python311Packages.plugwise.dist


[BUG]how to clear the tmp file of laravel excel

Prerequisites

[ ] there are so many tmp files in the laravel-excel folder, so i want to known how clear them after i imported files into db

Versions

PHP version: php7.4
Laravel version: laravel 7.x
Package version: maatwebsite/excel 3.1

Additional Information
this is my first submit the bug, may be the feature not a bug for some forks.

After a successful import, its should delete the temporary file. If it doesn't, feel free to PR a fix or a failing test.  You can always write a cronjob that cleans out the directory every night

Fine. let me check why it do not delete the temporary file. A cronjob is cool to clear the dir.


Install procedure on README does not work

The current way to decide if the backend will start scraping or not is based on a 'global' environment variable. Perhaps we can make it built-in via docker files.
And therefore the command on readme does not work. It will not export SDSCHEDULE_SCRAPE=1. User needs to run the scripts with . to keep the variable.
Reference

Yeah, because the scripts are run in two different contexts, the variable being exported doesn't matter in the install script


Version the project

Versionning the modules would allow users to get the exact same behaviour when terraform get-ing them at different point of times, for a same project.
This is an idea taken from https://blog.gruntwork.io/how-to-create-reusable-infrastructure-with-terraform-modules-25526d65f73d, which would allow such declaration:
module "frontend" {
  source = "git::git@github.com:gruntwork-io/infrastructure-modules.git//frontend-app?ref=v0.0.2"
  min_size = 1
  max_size = 2
}

Yes, this will eventually become a requirement sooner than later.
Thanks.


Feature/ddw 5 Send bug reports with logs from Daedalus

This PR introduces a dialog for sending bug reports with logs from Daedalus UI.
Tasks

[ ] Connect with API
[x] Inject missing Japanese translations
[x] Inject missing Japanese translations for reporting an issue from the connecting/syncing screens
[x] Dark-blue and Cardano elements color on reporting an issue from the connecting/syncing screens
[ ] Update the code after Daedalus logs have been moved into Pub directory: https://github.com/input-output-hk/daedalus/pull/505

Im closing this and will start porting from scratch based on the merged PR as this is easier for me atm.


Board Report: Enhancement -- Show related files

Show list of Related Files on Board Report pages.

@shrayshray - it appears that the above related files (2016-0387, 2017-0116) do not exist.
Can you give us another example of a Board Report with related files?

@reginafcompton Ah, okay. The related files on that file are not Agenda Ready. The files on 2017-0280 are Agenda Ready, so it would be a good example.

Found this one.
http://webapi.legistar.com/v1/metro/Matters/4089/Relations
—
Omar Camacho
Metro Los Angeles
Sr. Manager, Systems Projects, Research & Records Information Management

@shrayshray - I pushed a solution to the staging site. At the bottom, you can find a table of related board reports, for example (2017-0280): https://lametro.datamade.us/board-report/2017-0280/
Two questions:
Do you want to display this information elsewhere? would you like to see more content in the table (in addition to the board report identifier and title)?

@reginafcompton This looks great!! As far as other content, I think it would be helpful to show the date and status for the related reports. @camachoo is there anything else you would want to see?

@shrayshray - I added the status (shows directly next to the report title) and last action date (given its own column). I also moved the table to the right-hand side, which addresses this issue: https://github.com/datamade/la-metro-councilmatic/issues/209
I pushed these changes to the staging site. One example: https://lametro.datamade.us/board-report/2016-0442/
Let me know, when you'd like to see this deployed on production!

@reginafcompton Looks great! I did notice one of the related files, 2016-0451, doesn't have a title. Is this a data entry issue on our side?

@shrayshray - a small collection of the reports do not have titles, per our discussion in this past issue: https://github.com/datamade/la-metro-councilmatic/issues/128 We can prioritize the mentioned scraper fix for October, if you like.


Add clarification between production & instrumented test code, fixes #298

Once we define these terms, we can use them as differentiators, enabling us to finally handle a lot of options that have been held up (because different situations have different needs).

@thomasnyman - should we slip this clarification in now? I believe this is important for future changes.

I agree. This looks good to me now.


feat: update

📝Changed routes:

/api/auth/[...nextauth]

Commit eec6e91397cc53a245c2db7d865f03d5858f1f71 (https://atticodellino-1h2cnz44h-corretto.vercel.app).


Optimize ExpressionFilterOperator

Add BYTES type and multi-value support
Directly construct DocIdSet to save the overhead of filtering
Remove the redundant isMatch() for all scan based iterators

Also changed the numEntriesScannedInFilter for MV column to actual values fetched instead of values evaluated and added some TODOs for future filter optimization

Codecov Report

Merging #5132 into master will decrease coverage by 0.03%.
The diff coverage is 68.57%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fcb1d...aaa35fa. Read the comment docs.


after downloading with hacks i cant get the app running plz help me

same here

same for me

First of all you need to install AppDaemon on Config/Added Component. Then you have to copy the alexa_talking_clock.py file in this folder: /addon_configs/a0d7b954_appdaemon/apps ( you found /addon_config typying cd / on terminal )
After this action on the same folder add the confiuration lines on the app.yaml file.
Reboot AppDaeomon and that's it


feat: Custom Component for Langfuse environment variable

Custom Component for Langfuse - Integration of Langfuse with Langflow on cloud. Environment variables for Langfuse like Secret key, Public key and Host can be created using custom component in Langflow

Very cool, thanks for the contribution!
However, I think we have a generic approach for this sort of thing with the dotenv component https://github.com/langflow-ai/langflow/blob/d38e79bde630a88ea569a1c4aed6209f9387b059/src/backend/base/langflow/components/astra_assistants/dotenv.py#L11
Does it address your use case?


Server log file location?

When errors occur in the browser console is there a server log with more details, if so, what is the location?

There's no server logfile as such since any server side errors are written out to the terminal. If you're using the task runner you might need to toggle site logging by b.sl to see these errors.


Fix K-Means sample namespace usage

daal::data_management entities are used in the C++ samples, but they are not injected explicitly.
service.h header provides such injection, but its content is:

Auxiliary functions used in C++ examples

Attempts to inject the sample code into standalone code will fail in case users won't need service.h header and utilities.

make test

Thank you for contribution. It affects all examples not only k-means

make test

I didn't get what do you mean. Do you mean to create a reproducer?

Yes, the solution is get rid of using namespace in header file, while it's ok to have them in cpp files. @PovelikinRostislav, is it work for you to extend your pull request for that?

@averbukh, sounds OK for me, but I need time to test samples. I'll be quiet busy for next two weeks.