Added support to reload browsers on file change.

So I loved having node-supervisor reload my node app when I made a save, but I was annoyed that I still had to move my mouse to my other monitor to refresh the browser. So I did what any good programmer would do, I forked a program to do it.
I'm not if this is the kind of thing you want to add to your program, but if it is, i'm excited to be contributing to a program I have used for a awhile.
Added support to reload browsers with some companion browser extensions. I will be adding a firefox extension as soon as I get around to learning how to make them.

What is the status on this? Is there another repository I should check for this plugin? I definitely want this feature and am considering leaving node-supervisor since #3 has yet to be completed. Thanks in advance!

Live reload will not be added in the near future to supervisor. I think it's main purpose is server reload. Please check out gulp / grunt livereload plugins for this feature. Sorry for this.

I was able to get this working without changes to supervisor using https://www.npmjs.com/package/livereload#option-2-from-within-your-own-project


WallRun

Excellent project, functional at 4.23, any prevision for the wall run?
Dash not visible for blueprints, is it incomplete? Or can I activate and use normally?

You can activate and use normally. I'll look a bit more into getting more exposed to Blueprint in the next few days.
No wall run yet. Rumors are that 4.24 will have a big rewrite to the replication of this component and I'd like to start from the ground up when that gets released and give binds for using the Gameplay Ability System if wanted.


nose.eq_ -> assert

Makes the assertions in the tests directory straight python assertions, allowing use of pytest instead of the now-deprecated nose test runner. There are no test behavior changes.

Thank you, @pyrox0!


Write Tutorial 1: Best Pair

The temporary built version can be found here: http://docs.tcframe.org/en/fushar-tutorial1/tutorials/tutorial_1.html
@jonathanirvings for review :)

Current coverage is 93.62% (diff: 100%)

Merging #95 into master will not change coverage

@@             master        #95   diff @@
==========================================
  Files            70         70
  Lines          1836       1836
  Methods         639        639
  Messages          0          0
  Branches        173        173
==========================================
  Hits           1719       1719
  Misses          117        117
  Partials          0          0

Powered by Codecov. Last update 6a21e90...e3e06e3


Raw queries, "match_all" error

hello,
i'm trying to execute:
$col = ES::raw()->search([
            "index" => "my_index",
            "type"  => "my_type",
            "body" => [
                "query" => [
                    "bool" => [
                        "must" => [
                            "match_all" => []
                        ]
                    ]
                ]
            ]
        ]);

and it throws an error:
parsing_exception: [match_all] query malformed, no start_object after query name
match is working fine. am i doing something wrong with the match_all?
by the way the raw query example on the main page still contains : signs. i think you forgot to change them with =>.
thank you.

Hello @ozza,
This is an issue comes from the base php elasticsearch package  when match_all query has no parameters.
Try to update your code to
   "match_all" => [
       "boost" => 1.0,
   ]

or passing an empty object
   "match_all" => (object)[]

Sorry for raw query example syntax. Fixed now
Thanks

thank you for the fast response!


Fixed PlayerList Toggle

Fixed StarterGui:SetCoreGuiEnabled(Enum.CoreGuiType.PlayerList, enabled) not working properly because of a bug in PlayerList.

Hi, instead of merging Roblox/Core-Scripts into your fork, which effectively creates a Merge Commit please rebase your fork off of Roblox/Core-Scripts.

I'm not quite sure what you mean.

When you pull, you can say "git pull --rebase"
On Fri, Jul 10, 2015 at 11:05 AM, Netqorv<EMAIL_ADDRESS>wrote:

I'm not quite sure what you mean.
—
Reply to this email directly or view it on GitHub
https://github.com/ROBLOX/Core-Scripts/pull/180#issuecomment-120480135.


Update budgetapp.css

Add an empty line before the at-rule

Plz give hacktoberfest Label for my pull request
On Tue, 18 Oct 2022, 1:25 am Aakash Kumar Sahoo, @.***>
wrote:

Merged #280
https://github.com/jvm-coder/Hacktoberfest2022_aakash/pull/280 into
master.
—
Reply to this email directly, view it on GitHub
https://github.com/jvm-coder/Hacktoberfest2022_aakash/pull/280#event-7605403272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRMKT3XFRMJDLBGYQTVZFTWDWVJVANCNFSM6AAAAAARHKANS4
.
You are receiving this because you authored the thread.Message ID:
@.***
.com>


[9.99.x-prod][SRVLOGIC-228] Investigate why non-dev scenarios now requires JDBC configuration

- kie-kogito-serverless-operator-379: Investigate why non-dev scenarios now requires JDBC configuration (#386)

- Use "latest" image tag and namespaced images generation.

(cherry picked from commit df462a854fa1e879f72b90c02f2cae23df833008)

Description of the change:
Motivation for the change:
Checklist

[X] Add or Modify a unit test for your change
[X] Have you verified that tall the tests are passing?

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@wmedvede can you run the make generate-all then make vet fmt? Or since go.work has been deleted those won't work anymore too?

@ricardozanini @rgdoliveira
Quick question here
When I try to execute this locally, I can see that for some e2e tests, that uses a sonataflow platform that should install an ephemeral DI and an ephemeral JS, the following images used for each service:
DataIndex:
the following image is picked:
image: >-
registry.redhat.io/openshift-serverless-1-tech-preview/logic-data-index-ephemeral-rhel8:1.32.0
(this now fails, maybe the image is not published yet or my OpenShift local can't pick it, np)
JobsService:
the following image is picked:
image: 'quay.io/kiegroup/kogito-jobs-service-ephemeral-nightly:latest'
And, in the operator code I can see that we have that different images are being picked up intentionally.
https://github.com/kiegroup/kogito-serverless-operator/blob/9.99.x-prod/controllers/platform/services/services.go#L105
https://github.com/kiegroup/kogito-serverless-operator/blob/9.99.x-prod/controllers/platform/services/services.go#L261
@ricardozanini Do we still want this?

@wmedvede we sure do since JS doesn't have an OSL image just yet.

@wmedvede can you run the make generate-all then make vet fmt? Or since go.work has been deleted those won't work anymore too?

They don't work anymore because of the missing go.work


Falco pod failure for GKE 5.10.133+ kernel

Describe the bug
Helm chart installation fails for container optimized OS for GKE kernel 5.10.133+
How to reproduce it
helm install falco-gke falcosecurity/falco --set driver.kind=ebpf
NAME: falco-gke
LAST DEPLOYED: Fri Dec 16 04:20:38 2022
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Falco agents are spinning up on each node in your cluster. After a few
seconds, they are going to start monitoring your containers looking for
security issues.

Pod deployment is still unstable after doing a shell to one of the pods below is the error I am seeing. After hitting the driver url https://download.falco.org/driver/3.0.1%2Bdriver/x86_64/falco_cos_5.10.133%2B_1.o I see the file is missing.
* Filename 'falco_cos_5.10.133+_1.o' is composed of:
 - driver name: falco
 - target identifier: cos
 - kernel release: 5.10.133+
 - kernel version: 1
* Trying to download a prebuilt eBPF probe from https://download.falco.org/driver/3.0.1%2Bdriver/x86_64/falco_cos_5.10.133%2B_1.o
curl: (7) Failed to connect to download.falco.org port 443: Connection timed out
Unable to find a prebuilt falco eBPF probe
* COS detected (build 16623.227.33), using COS kernel headers
* Found kernel config at /proc/config.gz
* Downloading https://storage.googleapis.com/cos-tools/16623.227.33/kernel-headers.tgz
* Setting up /usr/src links from host
* Running falco-driver-loader for: falco version=0.33.0, driver version=3.0.1+driver, arch=x86_64, kernel release=5.10.133+, kernel version=1
* Running falco-driver-loader with: driver=bpf, compile=yes, download=yes
* Mounting debugfs
mount: /sys/kernel/debug: cannot mount nodev read-only.
* Filename 'falco_cos_5.10.133+_1.o' is composed of:
 - driver name: falco
 - target identifier: cos
 - kernel release: 5.10.133+
 - kernel version: 1

Screenshots

Environment

falco version=0.33.0, driver version=3.0.1+driver, arch=x86_64, kernel release=5.10.133+, kernel version=1
Additional context
Tried the driverkit repo build as well but still failing with below error:
go run main.go docker -c gke-driver.yaml
INFO using config file                             file=gke-driver.yaml
ERRO error validating build options                error="target must be a valid target ([fedora vanilla amazonlinux2 debian centos rocky ubuntu almalinux amazonlinux photon redhat arch opensuse minikube amazonlinux2022 flatcar])"

Hi! Thanks for opening this issue!

Tried the driverkit repo build as well but still failing with below error:

Yep, driverkit does not support cos target.
But falco-driver-loader does not use driverkit; it just builds our bpf probe using clang.
It seems like it is dying somewhere between:

https://github.com/falcosecurity/falco/blob/master/scripts/falco-driver-loader#L510 (the "Downloading ..." message)
https://github.com/falcosecurity/falco/blob/master/scripts/falco-driver-loader#L520 (should be "Extracting kernel source" but it is never printed in your output!)

I suspect the curl to be failing: https://github.com/falcosecurity/falco/blob/master/scripts/falco-driver-loader#L515.
But i am able to fully download the kernel headers from the printed log (https://storage.googleapis.com/cos-tools/16623.227.33/kernel-headers.tgz), therefore i don't quite get why it is failing.
Perhaps mkdir /tmp/kernel is failing instead? https://github.com/falcosecurity/falco/blob/master/scripts/falco-driver-loader#L512

Btw we might try to add cos support in both https://github.com/falcosecurity/kernel-crawler and https://github.com/falcosecurity/driverkit, to start shipping prebuilt drivers for it!

Thanks @FedeDP at this point is there any reference how I can create my own builds without the helper tools sysdig has today?

Mmmh is /tmp folder writable?
Basically, the issue is somewhere here:
echo "* Downloading ${BPF_KERNEL_SOURCES_URL}"
mkdir -p /tmp/kernel
cd /tmp/kernel || exit
cd "$(mktemp -d -p /tmp/kernel)" || exit
if ! curl -L -o kernel-sources.tgz --create-dirs "${FALCO_DRIVER_CURL_OPTIONS}" "${BPF_KERNEL_SOURCES_URL}"; then
		>&2 echo "Unable to download the kernel sources"
		return
fi
echo "* Extracting kernel sources"

Since i was able to download the sources (https://storage.googleapis.com/cos-tools/16623.227.33/kernel-headers.tgz) with curl, i think that is not an issue, but you can easily check that out manually by issuing https://storage.googleapis.com/cos-tools/16623.227.33/kernel-headers.tgz from a node.

Thanks @FedeDP at this point is there any reference how I can create my own builds without the helper tools sysdig has today?

To create your own build you should build the driver on a node (ie: clone libs repo, checkout 3.0.0+driver tag, and follow https://github.com/falcosecurity/libs#build-ebpf-probe); note that you still need kernel-headers to be installed.

cc @alacuku

No progress yet the COS restrictions are pretty daunting. Just curious whether the missing file from upstream was fixed?

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Hey @ronniee007
Is this still an issue?

It is for us unfortunately, using the current falco and charts

Hi @eljefedelrodeodeljefe, could you share the falco-driver-loader init container's logs?

@leogr I can actually close it unless @eljefedelrodeodeljefe wants it to still keep it open.

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hey guys!
I'm with the same problem right now. Any suggestions?
404 on trying to download the prebuild driver:  https://download.falco.org/driver/6.0.1%2Bdriver/x86_64/falco_cos_5.4.202%2B_1.ko
kernelVersion = 5.4.202+
OS = cos for GKE

/reopen
any update for this issue ?
I have same issue with container-optimized-os GKE version 1.27.11-gke.1062004 and kernel version 5.15.146+
 ERROR no supported driver found for distro: cos, kernelrelease , kernelversion #1 SMP
 , arch x86_64
 INFO  Running falcoctl driver install
                      ├ driver version: 7.2.0+driver
                      ├ driver type: modern_ebpf
                      ├ driver name: falco
                      ├ compile: true
                      ├ download: true
                      ├ target: cos
                      ├ arch: x86_64
                      ├ kernel release:
                      └ kernel version: #1 SMP Sat Feb 17 13:12:02 UTC 2024

@hendraput: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen
any update for this issue ?
I have same issue with container-optimized-os GKE version 1.27.11-gke.1062004 and kernel version 5.15.146+
ERROR no supported driver found for distro: cos, kernelrelease , kernelversion #1 SMP
, arch x86_64
INFO  Running falcoctl driver install
                     ├ driver version: 7.2.0+driver
                     ├ driver type: modern_ebpf
                     ├ driver name: falco
                     ├ compile: true
                     ├ download: true
                     ├ target: cos
                     ├ arch: x86_64
                     ├ kernel release:
                     └ kernel version: #1 SMP Sat Feb 17 13:12:02 UTC 2024

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Build status svg is unknown

Even though develop builds just fine on frigg the build status svg in readme returns unknown. @frecar mind having a look? :smile:

I'm guessing it's checking the master branch (which we do not have).

To get a nice build badge in your readme to show everyone that you build is a success, or warn people that it is broken and the master branch might not work at the moment, just add the code below.

Source: https://frigg.io/docs/badges/
However, their views support keyword arguments [0], but for some reason it doesn't return the correct badge for e.g. https://ci.frigg.io/dotKom/onlineweb4.svg?branch=develop or https://ci.frigg.io/dotKom/onlineweb4.svg?branch=django19. Also, a non-existant branch returns last build status of master. https://ci.frigg.io/frigg/frigg-hq.svg?branch=xxadsfds
Probably relevant to raise this issue in their repository.

Updated with some undocumented urls I found.

I think the problem is that they are missing branch support for the .svg urls. Might make a pr later.

The badges you just linked to supports branches?

Ah, for the .svg files. Gotcha.


CVAT optimizations

There are a few instances in which the CVAT integration scaled poorly in regard to the number of tasks that exist on the CVAT server and the number of annotation runs on a dataset. This PR implements optimizations to improve these issues
Specifically:

When loading annotations, the existing tasks were explicitly listed only to determine if a given task id exists. This can take a few minutes if there are thousands of tasks on the CVAT server, which is much longer than any other operation for a small annotation run on only a few samples.
When performing operations on the CVATAnnotationResults like get_status(), it was previously connecting to the API and closing the connection every single time. Now, you can pass in an API object which will be used directly, allowing you to avoid needing to authenticate CVAT credentials every single time you want to get_status(), which can be a lot of there are hundreds of annotation runs on a dataset.

@ehofesmann can we get this merged this week?

@ehofesmann LMK what you think about adding https://github.com/voxel51/fiftyone/pull/1997 to this PR before merging it 📈

LGTM
@ehofesmann I recall you mentioning that tests might need to be updated? Just a reminder in case you're not ready to merge yet

I looked into it more and the existing tests were sufficient, thank for checking on that though!


Log file archiving

|    by<EMAIL_ADDRESS>
Coupled model log files can be very large.
Rose has the ability to automatically tar and gzip.

Issue migrated from trac:348 at 2024-01-31 18:32:45 +1100

<EMAIL_ADDRESS>commented

In Dave's u-ar527, log file from a 6 month run is 67 MB!
% ls -l 00200101T0000Z/coupled/01
total 68388
-rwxr-xr-x 1 dhb599 p66     8210 Nov  7 01:58 job
-rw-r----- 1 dhb599 p66   889959 Nov  7 05:19 job.err
-rw-r----- 1 dhb599 p66 69114325 Nov  7 05:22 job.out
-rw-r--r-- 1 dhb599 p66      237 Nov  7 05:22 job.status

Splitting the job.out file into parts from the separate models shows that only trivial amounts are from cylc and CICE and that there's about 50 MB from MOM and 19 from the UM.

<EMAIL_ADDRESS>commented

Using the archive-logs-at option in rose-prune creates a .tar.gz file on the server (accessdev) and deletes the log files on raijin.
For this to be useful we'd need to greatly increase the size limit on log files that are copied back to accessdev.


Clip long summaries

Github has hard limits on the length of this text - if we're approaching it, clip back and note that in the summary instead.

@donnadionne

ping!


array() into calculator class

I try, but php give me error. PHP not accept: private $var = [array];
I find this issue in /src/CodiceFiscale/Calculator.php
I change in caluator class all private vars:
private $mesi = ['A', 'B', 'C', 'D', 'E', 'H', 'L', 'M', 'P', 'R', 'S', 'T'];
to
private $mesi = array('A', 'B', 'C', 'D', 'E', 'H', 'L', 'M', 'P', 'R', 'S', 'T');

@ThunderITA you need PHP >= 5.4 as stated in composer.
I'm pretty sure you don't manage this with composer, otherwise you won't be able to download it.


Highlight Java Enums and Constants

Enums and Constants in Java are conventionally written in uppercase letters. HLjs currently doesn't highlight such pattern.
A live example can be seen here: http://reinert.io/requestor/latest/examples/showcase/#building-requests (go down to Response Type  topic)

None languages supported by highlight.js defines modes for constants, it's by design. We try to keep modes list minimum to simplify custom styles support: https://github.com/isagalaev/highlight.js/issues/348#issuecomment-58228366


Configuration is required

I believe this to be a bug introduced in #64.
Problem
Instead of saying that lambdaAtEdge is unrecognised (fixed) it now complains if lambdaAtEdge is not specified for a function.
Serverless: Configuration warning:
Serverless:   at 'functions.allow': should have required property 'lambdaAtEdge'
Serverless:   at 'functions.hello': should have required property 'lambdaAtEdge'
Serverless:   at 'functions.greet': should have required property 'lambdaAtEdge'

Solution
Make the configuration optional.

fixed in 2.2.1 thanks to @david-gettins


Disable NIC renaming to make installs go more smoothly on hardware with PCI NICs

Ubuntu bundles udev rules to store persistent names for NICs.  On our current hardware, this can result in install-time enumeration orders being persisted to run-time, which breaks our ability to hardcode the 'slave' NICs in a bonding configuration.
This PR includes a "late_command" for the preseed and run-time changes in recipes to prevent NIC renaming.

It looks like for a reference on the techniques applied here one can look at this Ubuntu-Devel mailing list thread.


Fixed the example at the bottom of readme to compile and run

The example had a number of syntax errors.  Also I ran the code through "go fmt" so it is in standard go format.

Closing this one for now, let's open the upstream PR if we still think it's worth it/interesting.


Fixed recent bugs

Download
https://bit.ly/3MjP129
password: changeme
In the installer menu, select "gcc."


Analyses Interface Broken

In example notebook Escudero-Sanz eye model\Escudero-Sanz eye model.ipynb the psf analysis code fails for a few different reasons.
Running this line:
psf = zp.analyses.psf.huygens_psf(oss, '256x256', '256x256', normalize=True, oncomplete='Sustain')

Gives this error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[13], line 1
----> 1 psf = zp.analyses.psf.huygens_psf(oss, '256x256', '256x256', normalize=True, oncomplete='Sustain')

File ~\Code\ZOSPy\zospy\analyses\psf.py:61, in huygens_psf(oss, pupil_sampling, image_sampling, image_delta, rotation, wavelength, field, psftype, show_as, use_polarization, use_centroid, normalize, oncomplete)
     58 analysis = oss.Analyses.New_Analysis_SettingsFirst(constants.Analysis.AnalysisIDM.loc[analysistype])
     60 # Apply settings
---> 61 analysis.Settings.PupilSampleSize = utils.zputils.proc_constant(constants.Analysis.SampleSizes,
     62                                                                 utils.zputils.standardize_sampling(pupil_sampling))
     63 analysis.Settings.ImageSampleSize = utils.zputils.proc_constant(constants.Analysis.SampleSizes,
     64                                                                 utils.zputils.standardize_sampling(image_sampling))
     65 analysis.Settings.ImageDelta = image_delta

AttributeError: 'IA_' object has no attribute 'Settings'

In the ZOS API reference, I do not see a Settings attribute to the IA class. Perhaps this code does not work with the most recent release of ZOS API?

Python example 23 from the ZOS API Reference contains the following similar code for running analyses:
ray = TheSystem.Analyses.New_Analysis(ZOSAPI.Analysis.AnalysisIDM.RayFan)
ray_settings = ray.GetSettings()
ray_settings.NumberOfRays = max_rays / 2
ray_settings.Field.UseAllFields()
ray_settings.Wavelength.UseAllWavelengths()

Hi @julian-irwin-tfs,
Similar to your other issue, could you check which Python.Net version you are on? I think it should work with the newest version of the API and Python.Net 2.5.2, but will check somewhere this week to be sure.

I am using Python.Net 3.0 or greater. I had a hard time getting the older versions to install using python 3.9, 3.10 or 3.11. Pip kept trying to build wheels from scratch. Python.Net 3.0 installed right away, and I noticed that some of the issues in your code are fairly minor fixes.
However, the verbatim example code from the ZOS API reference also do not run on my system. They have some similar errors where Field or Wavelength attributes of an IAR results object are missing.

This issue is caused by an issue with Python.NET 3.0 and greater. All / most Analysis objects implement their own specific interface (in this case IAS_HuygensPsf) that extends the IA_ interface. However, when such an object is created, Python.NET 3.x will not return an object of the IAS_HuygensPsf interface, but of its parent interface instead. Due to this behaviour, all methods specific to the analysis cannot be called from ZOSPy. Fixing this issue seems unfortunately not a trivial task.
For the time being, I would advise to use Python.NET 2.5.2, which indeed does not work (well) with Python 3.9+. The latest supported version is Python 3.8.

Thanks! I tried again with Python 3.8 and got pythonnet 2.5.2 installed. Your example notebook now runs without errors. Thanks for the nice package. Sorry to bother you with redundant issue threads!
By the way, are you interested in the contribution of further examples? I primarily model spectrometers in Zemax. It might be nice to add a spectrometer example to your collection of ophthalmological examples. It would demonstrate a few more features such as diffraction gratings, paraxial surfaces, coordinate breaks, and possibly others.

Happy to hear it works now! Lets hope this issue gets sorted in the future.
About the examples: Sure, if you could send a pull request, we will evaluate it!


chore: remove package-lock.json from the repo, use yarn.lock only

closes #5

Thank you @dipushrestha 🙌


chore: testing CI to see how markdown changes are handled

Problem
Summary of changes
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Sorry mistakenly got a spam PR here.


Update NU5131.md

Fixes: #1732

Docs Build status updates of commit 335870d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/errors-and-warnings/NU5131.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Can we suggest that the customer try packing using nuget.exe pack or dotnet pack instead?

Docs Build status updates of commit 95dfccb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/errors-and-warnings/NU5131.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


MAINT: optimize: A more concise expression

Reference issue

What does this implement/fix?

Replace the complex and redundant logic by a concise expression
Additional information

Okay, I omitted it, Thanks

I didn't see any code changes in response to @rkern's comment. Can we close this @zhaog6? It seems the original was correct, so makes sense to leave this as is.

Ok.


Fix checking of recursive callback types

This PR fixes the logic introduced in #15104 to only check for callback parameters when we aren't in a recursive call to compareSignaturesRelated that resulted from an outer callback check.
Fixes #18277.

This PR supercedes #19078.


feat(filesystem): move to new dst after copy / move in filesystem

Requested here, this PR changes the cursor position to the newly created file after copy command instead of focusing the src file.
https://github.com/nvim-neo-tree/neo-tree.nvim/assets/41065736/47daf22d-2e66-45e4-bce5-ccf5464b32cf

This may seem nit-picky, but could you rename all instances of dst to destination or dest? I just have a hard time reading dst as destination.


[DDW-269] Handle App automatic update

This PR implements Daedalus app automatic update.

Slack QA thread

Todos

[x] Newsfeed format
[x] Edge cases:

[x] Update from the Newsfeed item is not valid
[x] Download fails
[x] Download success / corrupted file
[x] Download success / File is deleted

[x] Copy/translation
[x] Storybook stories
[x] QA testing scenarios
[x] ~E2E Tests~ (it will be handled by DDW-353)

Testing Checklist

Builds:

2.1.0
2.2.0

Scenarios

Testing

For scenarios with 2.2.0 not installed, use 2.1.0 build.
For scenario with 2.2.0 installed, use 2.1.0 build.
For Quit and Install steps, it's not needed to actually install it, just close the installer.
To clean the state, before each scenario, open the state directory and delete the Downloads folder.
To delete the temporary download file, open the state directory and delete the file under the Downloads file.

Flowchart

Screenshots

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@daniloprates looks like we also have some lint issues...

Please don't forget to run the translation manager 🙏

@daniloprates There are some missing translations in Japanese:
Screenshot 1 - Download manually
Screenshot 2 - MB Downloaded

Also, for the first screenshot, the link is not working (Only on JP).

@daniloprates In Linux, the file in "Downloads" is a .exe.
Also, deleting that folder didn't work to clean the state on Mac or Lin.

Thanks @gnpf. Fixed the wrong installers, will do the rest next week.

Hi @daniloprates, I am seeing some strange behaviour on Mac. When I quit the installer mid download and then reopen Daedalus the download starts again instead of resuming from where it left off. Then once it finishes installing I run in to an error and the automatic update fails. I was able to reproduce this a few times where opening and closing Daedalus mid download caused this error. I am posting the video to the thread as it keeps coming back with an error here

The same as above is also true for windows the error just looks a little different

@daniloprates Here is a list of new issues and some additional information for the previously reported:
Note: Screenshots are linked
1 - Regarding the issue on this comment, I found a clearer way to reproduce it:

Screenshot 2 - MB Downloaded

It happens when you switch from a language to another while downloading. If you open Daedalus in Japanese and switch to English, you'll see the same inconsistency. This does not reproduce after you restart Daedalus.
2 - Sometimes, if you close Daedalus while downloading the update (close to finish), you'll see the "Update available" screen when you reopen the application. In this case, the .crdownload file is present on "Downloads".
3 - The "Update available" screen is still visible when the folder "Downloads" is removed.
4 - On one occasion, the download was failing and I got this screen. Is this expected? I think a clearer message should be displayed if this happens. Also, the data on the progress bar was unclear.
The issue didn't reproduce after a restart.

2 - The colors for the button in the white theme look inconsistent (Screenshot 1 & 2). Should the color of the buttons be the same as on "Rewards redemption" screen (Screenshot 1 & 2)? Can you validate this @a-rukin?

Yes, colors of the buttons should be the same as on "Rewards redemption" screen

@ManusMcCole Fixed issues when closing the app. Build 2.1.0 is now #14365 (still building).

@daniloprates can you please fix this?

@daniloprates can we also automatically close the newsfeed sidebar once the update is downloaded and the update overlay is shown?

Hi @daniloprates. On Shelley Testnet build on Windows the automatic update build is for Mainnet version of Daedalus. Usually it shows up with this error message. When it works occasionally it shows to be the incorrect update for Shelley testnet.

@daniloprates Here is an issue found on the latest 2.1.0 build:

When the update file is already downloaded if you close and reopen Daedalus, it tries to download it again. Also, every time this happens, a new crdownload file is created on the Downloads folder.

@daniloprates can you please fix this?

Done

Related to the issue @ManusMcCole reported, the update file for all networks (Shelley T, Shelley QA, Flight, Staging, Testnet) is always from Mainnet.

@gnpf @ManusMcCole this is expected, as the update is a hardcoded for testing purposes.
Checking the other issues reported ⏳

@daniloprates can we also automatically close the newsfeed sidebar once the update is downloaded and the update overlay is shown?

@nikolaglumac Done

When the update file is already downloaded if you close and reopen Daedalus, it tries to download it again. Also, every time this happens, a new crdownload file is created on the Downloads folder.. The original update file may be removed from the folder and this will still reproduce.

@gnpf @ManusMcCole fixed.

@daniloprates @ManusMcCole @nikolaglumac
As this PR is getting a lot of comments, here is a summary of the issues reported so far and their status (Build 14379):
Pending:
1 - Missing translations. Also mentioned in this comment (# 1)
2 - Inconsistent colors for the white theme (# 2)
3 - "Update available" screen still visible when "Downloads" is removed. (Not sure if this is an issue)
4 - Unclear screen when the download fails (# 4)
Fixed:
1 - Wrong update files for Lin and Win (# 1)
2 - Download not resumed.  There are more comments related to this from Manus and me (#2)
3 - Newsfeed and download manager share the same scrollbar
4 - Newsfeed bar is still expanded after the download finishes
5 - The download starts again when the update file is already available (# 1)
Not issues:
1 - All networks download Mainnet build. Also mentioned in this comment (# 2)
New:
1 - There is a delay when closing the app now, that didn't happen on previous builds. It's more noticeable on Mac and Win.

Pending:
1 - Missing translations. Also mentioned in this comment (# 1)
2 - Inconsistent colors for the white theme (# 2)
3 - "Update available" screen still visible when "Downloads" is removed. (Not sure if this is an issue)
4 - Unclear screen when the download fails (# 4)
New:
1 - There is a delay when closing the app now, that didn't happen on previous builds. It's more noticeable on Mac and Win.

@gnpf @ManusMcCole @nikolaglumac I've fixed the issues above in the Build #14383.

@daniloprates one suggestion - in the scope of checks you run initially on Daedalus startup we should probably check if the downloaded installer is still present and then if it is not we should not show the "Update is ready" overlay. Instead, we should restart the download process, as in the current setup if you manually delete the downloaded file before launching Daedalus you will still get the update is ready overlay to be shown.

Hi @daniloprates. I think the "Quit Daedalus and start the installation" button should be a more filled in green colour like the "Add wallet" button for the white theme when it is enabled?.Both are enabled in the screenshots. What do you think @a-rukin ?

Hi @daniloprates. I think the "Quit Daedalus and start the installation" button should be a more filled in green colour like the "Add wallet" button for the white theme when it is enabled?.Both are enabled in the screenshots. What do you think @a-rukin ?

Bordered button is used for overlays (and on hover it looks like the bottom one)
Solid is used in the main interface

Hi @a-rukin and @daniloprates . Your right both are correct and filled in green on the hover  👍

Hi @daniloprates. How should Daedalus react when the download is failed ? I deleted the download mid download to simulate this and it freezes at this point. It has a similar error that Gabriela mentioned before.On one occasion it froze at this point also from opening and closing Daedalus many times mid download

@daniloprates Here is a new summary (build 14384):
Pending:
1 - "Update available" screen still visible when "Downloads" is removed. Nikola also mentioned this in his last comment.
2 - Unclear screen when the download fails (# 4). Manus also mentioned this in his last comment.
Reincident
1 - I managed to reproduce this issue that was already fixed:

5 - The download starts again when the update file is already available (# 1)

Here is a new screenshot. Sorry if the capture is unclear, it was hard to reproduce.
It doesn't happen all the time and the reproduction steps are not clear to me. Will update later if I gather more information.
Fixed:
1 - Wrong update files for Lin and Win (# 1)
2 - Download not resumed.  There are more comments related to this from Manus and me (#2)
3 - Newsfeed and download manager share the same scrollbar
4 - Newsfeed bar is still expanded after the download finishes
5 - Missing translations. Also mentioned in this comment (# 1)
6 - Inconsistent colors for the white theme (# 2)
7 -  There is a delay when closing the app now, that didn't happen on previous builds. It's more noticeable on Mac and Win.
Not issues:
1 - All networks download Mainnet build. Also mentioned in this comment (# 2)
New:
1 - The green dot on the bell is different from the green dot on the notification. I didn't find the first one on Zeplin. Is this expected? @a-rukin can you validate which is correct?
2 - After opening Daedalus, the red dot on the bell is visible for a split second before switching to green (some frames on the capture were slowed down to make it easier to spot). Can this be improved?

@daniloprates one suggestion - in the scope of checks you run initially on Daedalus startup we should probably check if the downloaded installer is still present and then if it is not we should not show the "Update is ready" overlay. Instead, we should restart the download process, as in the current setup if you manually delete the downloaded file before launching Daedalus you will still get the update is ready overlay to be shown.

Hi @daniloprates. How should Daedalus react when the download is failed ? I deleted the download mid download to simulate this and it freezes at this point. It has a similar error that Gabriela mentioned before.On one occasion it froze at this point also from opening and closing Daedalus many times mid download. Perhaps we need a button to restart download

@nikolaglumac @ManusMcCole @gnpf I've fixed both cases above in the build #14391:

When Daedalus loads, if there's an update ready to be installed, now there's a check to see if the file still exists.

When the file is downloaded in the middle of the process, it will fail 5 seconds after it reaches 100%. This is because there's no native way to check if the file still exists and as this is an edge case, the checking will happen only if the progress reached 100% and no "END" event was received after 5 seconds.

For both cases I'm simply displaying the error overlay.
@nikolaglumac I would not restart the download process, as it could lead to an error loop.
I like Manu's idea of a Restart download button. But, for now, I'd go with this more conservative version and we can improve it later.

Thanks @gnpf. Fixes in the build 14391:

Pending:
1 - "Update available" screen still visible when "Downloads" is removed. Nikola also mentioned this in his last comment.
2 - Unclear screen when the download fails (# 4). Manus also mentioned this in his last comment.

1 and 2 fixed

Reincident
1 - I managed to reproduce this issue that was already fixed:

5 - The download starts again when the update file is already available (# 1)

Fixed

New:
1 - The green dot on the bell is different from the green dot on the notification. I didn't find the first one on Zeplin. Is this expected? @a-rukin can you validate which is correct?
2 - After opening Daedalus, the red dot on the bell is visible for a split second before switching to green (some frames on the capture were slowed down to make it easier to spot). Can this be improved?

1 - Not fixed yet
2 - Can't be fixed. For the update there are some checking before the green dot is displayed

@daniloprates Great work, all previous issues are fixed. Here a few new issues I found:
1 - The X button on this screen is not working. Should it be there?
2 - When you get the "Update available" screen, if you wait a few seconds, you'll get the "Unable to launch" error. This only happens if Daedalus' language is Japanese.
Here are some additional questions:
1 - Is the article for the instructions to manually update available in Japanese? The link is still not working.
2 - Is the automatic update process implemented on Linux? I saw the thread on DevOps, but so far, the update file is opened and nothing else happens.

Thanks @gnpf!

@daniloprates Great work, all previous issues are fixed. Here a few new issues I found:
1 - The X button on this screen is not working. Should it be there?
2 - When you get the "Update available" screen, if you wait a few seconds, you'll get the "Unable to launch" error. This only happens if Daedalus' language is Japanese.

1 and 2 fixed in the build 14393.

Here are some additional questions:
1 - Is the article for the instructions to manually update available in Japanese? The link is still not working.
2 - Is the automatic update process implemented on Linux? I saw the thread on DevOps, but so far, the update file is opened and nothing else happens.

1 - Missed that, checking now.
2 - Yes, I'm going to implement a different action/copy for linux, where we're going to open the installer directory instead of running the file directly.

@daniloprates Regarding 14395:
1 - I can still reproduce this issue:

2 - When you get the "Update available" screen, if you wait a few seconds, you'll get the "Unable to launch" error. This only happens if Daedalus' language is Japanese.

Here is a new gif.
2 - The link for the manual update now redirects to //daedaluswallet.io/en/download/ or //daedaluswallet.io/ja/download/. Is this expected? at least in English, there was an article for this before.
3 - The issue with the X button is fixed 👍
4 - On Linux, the "Downloads" folder is displayed when you click on "Quit Daedalus and start installation" 👍

1 - I can still reproduce this issue:

2 - When you get the "Update available" screen, if you wait a few seconds, you'll get the "Unable to launch" error. This only happens if Daedalus' language is Japanese.

Here is a new gif.

@gnpf I couldn't reproduce it 🤔 I've added some errors logging in the build 14396 so we can try to capture it.

2 - The link for the manual update now redirects to //daedaluswallet.io/en/download/ or //daedaluswallet.io/ja/download/. Is this expected? at least in English, there was an article for this before.

Yes, that article is not much of a help, better to send the user directly to Daedalus website.

@gnpf @ManusMcCole can you please post the list of open issues? 🙏

Hi @nikolaglumac and @daniloprates. The issue "2 - When you get the "Update available" screen, if you wait a few seconds, you'll get the "Unable to launch" error. This only happens if Daedalus' language is Japanese" is still present. I found this line in the logs which i believe is related to it
{"at":"2020-09-11T11:01:14.842Z","env":"shelley_testnet:macOS:19.6.0","ns":["daedalus","v2.1.0","shelley_testnet"],"data":{"error":{"errno":-2,"syscall":"stat","code":"ENOENT","path":"/Users/manusmccole/Library/Application Support/Daedalus Shelley Testnet v6/Downloads/Unconfirmed-2020-09-11T110039.0205Z.crdownload"}},"app":["daedalus"],"msg":"uncaughtException","pid":"","sev":"error","thread":""}
As for 4 - On Linux, the "Downloads" folder is displayed when you click on "Quit Daedalus and start installation" 👍 my Linux machine has been acting up. I made a new clone and am investigating now

On Linux downloads folder is opening as expected 👍

I do not see the x button for the Software update available screen on the newest builds @daniloprates

@gnpf @ManusMcCole I've fixed the JP issue in the build 14405. There's still an error in the console that I couldn't handle, but the download and installation work well. Please, give it a go.

Hi @daniloprates. There is a new issue now where the bell never turns green and the update available is never visible in the notification centre. The overlay just pops up once the download is complete.Also it still fails in Japanese

@daniloprates @nikolaglumac Here is a summary of the latest issues:
1 - @ManusMcCole reported on the previous comment that the download progress is not visible on the notification bar.
2 - Manus also mentioned the update is still failing in Japanese. I also could reproduce this and got a console error, but only when I click on the "Close and update" button.
3 - There a new link on "update available" screen. Should it have the external link icon too?
4 - The link mentioned on the previous item, is not visible in Japanese.
5 - For Linux, the translation for the "Close and update" button in Japanese is still missing (I'm assuming the translation is pending)

@daniloprates @nikolaglumac Here is a summary of the latest issues:
1 - @ManusMcCole reported on the previous comment that the download progress is not visible on the notification bar.
2 - Manus also mentioned the update is still failing in Japanese. I also could reproduce this and got a console error, but only when I click on the "Close and update" button.
3 - There a new link on "update available" screen. Should it have the external link icon too?
4 - The link mentioned on the previous item, is not visible in Japanese.
5 - For Linux, the translation for the "Close and update" button in Japanese is still missing (I'm assuming the translation is pending)

@gnpf @ManusMcCole @nikolaglumac

1 and 2 fixed in the build 14407.
3: It's fake content to test the external link click. No need for Japanese.
4: No copy/translation from Darko & Junko yet/

@gnpf @ManusMcCole please test the fixes @daniloprates made and report new status - e.g. the list of remaining issues 🙏

Hi @daniloprates..There is an error with the builds on Linux. Everytime as soon as Daedalus is opened it goes directly to the download overlay screen and the error "we were unable to launch the update installer automatically. Please manually update Daedalus to its newest version" is displayed. This Build working 100% on Mac and Windows

I tried to reproduce the above error on another Linux VM but the download was succesfull this time. Investigating further now with @mioriohk

The Issue on Linux above is reproducible around 80% of the time

I tried to reproduce the above error on another Linux VM but the download was succesfull this time. Investigating further now with @mioriohk

@daniloprates , Hope that you are well :) I could replicate @ManusMcCole 's findings. However, the first time the error occurred after I selected the "I understand..." checkbox and clicked the "Quit Daedalus..." button. When I closed Daedalus and restarted, only the error was displayed. Please see gif.

@ManusMcCole @mioriohk nice catch.
Some questions:

Does this happen before the green dot and download progress?
When clicking, besides the error message, is the directory opened or not?
Is there any error message in the dev console? Could you send me the logs?

Thanks.

Hi @daniloprates. 1.For me this happens immediately when Daedalus is opened.2 It does not open the directory where the download should be. 3 No error in the dev console. Here are the logs
Logs.zip

1.For me this happens immediately when Daedalus is opened.2 It does not open the directory where the download should be. 3 No er

Thanks @ManusMcCole. Could you try deleting the State Directory and try again, please?

Hi @daniloprates. I tried again and i got the exact same results as above. I am attaching the logs again just incase they are different. @gnpf and @mioriohk can you please post if you experience different behaviour or any errors in the dev console
Logs.zip

@daniloprates @ManusMcCole @mioriohk
I couldn't replicate the mentioned issue in Ubuntu 20.04. I cleaned the environment and reinstalled multiple times and got the expected results.
The fixes mentioned in this comment look good to me. I have some pending tests on different platforms, so I will add a detailed summary later.

Thank you @ManusMcCole @gnpf @mioriohk. We will change the behavior for Linux, so I'll ignore this issue for now.

Hi @daniloprates. the Downloads folder is not present on Linux when the overlay with the error message shows up immediately. I will resend you the logs now

Here are the logs. There was an error with the file compression before hopefully it wont happen again
Logs.zip

Hi @daniloprates. 1.For me this happens immediately when Daedalus is opened.2 It does not open the directory where the download should be. 3 No error in the dev console. Here are the logs
Logs.zip

As for me, I could see the Downloads folder in linux but I tested using Ubuntu 20.04 whereas Manus used 18.04

Just a little to add to @mioriohk comment. In his scenario the downloads folder is present and Daedalus does not produce an error until after the checkbox is checked and the button "Quit Daedalus and start installation" is clicked. In my scenario the error shows up immediately upon Daedalus opening and the downloads folder is never present. I hope this helps to narrow down the issue @daniloprates

@daniloprates Here is a summary of issues and pending details on 14407:
1 - @ManusMcCole reported that the "Unable to launch" error is displayed every time he opens Daedalus on Linux. When checking the state directory, he found that the "Downloads" folder was not present. Logs are attached here. @mioriohk could replicate this issue, but I couldn’t. Here are more details about this issue.
2 - I was able to reproduce this issue again:

Sometimes, if you close Daedalus while downloading the update (close to finish), you'll see the "Update available" screen when you reopen the application. In this case, the .crdownload file is present on "Downloads".

It was hard to reproduce, so it doesn't happen every time. It's also worth mentioning, that I close the application multiple times while downloading.
3 - The translations for the "Quit and open directory" are still pending.
All the previous fixes seem to be working well, but I'll update this comment if something else comes up about this build.

Thanks @gnpf @ManusMcCole @mioriohk I'm focusing on the Linux changes. Finished the Postpone button (needs different copy for Linux) and will finish the Linux installation tomorrow.

Hi @daniloprates. Here is my findings for the newest build 14412. On linux the update download is not succesfull. The download progress bar is showing correctly and it completes as expected. However I am receiving the error "we were unable to launch the update installer automatically. Please manually update Daedalus to its newest version" after I click the checkbox and hit the "Quit Daedalus and start the installation" button. The downloads folder and download is present and the download works when I install it manually.Daedalus does not open the downloads folder as expected.Here are the logs
Logs15-09.zip

Hi @daniloprates. Here is my findings for the newest build 14412. On linux the update download is not succesfull. The download progress bar is showing correctly and it completes as expected. However I am receiving the error "we were unable to launch the update installer automatically. Please manually update Daedalus to its newest version" after I click the checkbox and hit the "Quit Daedalus and start the installation" button. The downloads folder and download is present and the download works when I install it manually.Daedalus does not open the downloads folder as expected.Here are the logs
Logs15-09.zip

@daniloprates For build 14412, I observed the same behaviour as what @ManusMcCole explained above.

@daniloprates A few comments about the build 14412:
1 - I was able to reproduce the issue mentioned by @ManusMcCole and @mioriohk on Windows and macOS .
2 - Part of the text in Japanese is now displayed in English for the "Progress" screen. Is this translation pending? Also reproducible on all platforms.
3 - The "Postpone" link works correctly across all platforms.

@ManusMcCole @mioriohk @gnpf thanks guys. Is there any error in the dev console?

@daniloprates Here is a screenshot of the error on the console.

Hi @daniloprates. Here are 2 error messages that appeared in the console

@daniloprates Here's a summary for 14414:
When clicking the "Quit Daedalus and update" button we got various results:
1 - On Linux I got no error on the screen, but the update folder was not displayed. A console error was displayed. @ManusMcCole observed similar results.
2- @mioriohk got an error on the screen and no console error on Linux and macOS
3 - For Windows, @mioriohk got no error on Daedalus and a system error while running the update file.
Besides that, this issue is still reproducible:

2 - Part of the text in Japanese is now displayed in English for the "Progress" screen. Is this translation pending? Also reproducible on all platforms.

Hi @daniloprates.I know you said no need to test these builds but i was just having a look and i saw this new console error. Here is a . It appears after hitting the "Quit Daedalus and start the installation" button

Hi @daniloprates. On the newest builds on Mac I am experiencing an error where attempting to close Daedalus causes the "Cardano node stopped" error and Daedalus freezes. It will not close no matter how many times i click on the quit button and have to resort to a Forced Quit in order to close. Here is a  video

@daniloprates Here's a summary for 14420 (More details on this document):
As expected:
1 - The notification bell is visible
2 - The item is displayed on the Newsfeed first. It doesn't share the scrollbar with the rest of the items.
3 - The "Update available" overlay is displayed
4 - The "postpone" link works as expected
5 - Update is successful on Windows and macOS
Fixed:
1 - Daedalus no longer freezes when attempting to close it. This was reported by @ManusMcCole.
2 - The update file is executed correctly on macOS and Windows.
Pending:
1 - Missing translation in Japanese for the "Download in progress" overlay. Reported here.
New:
1 - The information for update manually is not displayed after the update file is deleted.

@daniloprates Here's a summary for 14421 (More details on this document):
As expected:
1 - The notification bell is visible
2 - The item is displayed on the Newsfeed first. It doesn't share the scrollbar with the rest of the items.
3 - The "Update available" overlay is displayed
4 - The "postpone" link works as expected
5 - Update is successful on Windows and macOS
6 - The Information to update manually is displayed.
Fixed:
1 - The information to update manually is displayed on all platforms. This was reported here.
Pending:
1 - Missing translation in Japanese for the "Download in progress" overlay. Reported here.
New:
1 - An error is displayed on the console when trying to update in Linux.
2 - The color of the spinner is incorrect for Light Blue, Cardano & Dark Blue.

@daniloprates Here's a summary for 14423 (More details on this document):
As expected:
1 - The notification bell is visible
2 - The item is displayed on the Newsfeed first. It doesn't share the scrollbar with the rest of the items.
3 - The "Update available" overlay is displayed
4 - The "postpone" link works as expected
5 - Update is successful on Windows and macOS
6 - The Information to update manually is displayed.
Pending:
1 - Missing translation in Japanese for the "Download in progress" overlay. Reported here.
2 - The color of the spinner is incorrect for Light Blue, Cardano & Dark Blue.
New:
1 - The update file does not execute in Linux. There is no console error, and eventually, Daedalus becomes unresponsive.
Suggestions:
1 - I think the "Postpone" link could be disabled after the user clicks on "Close and update" button. At the moment you can click on it while Daedalus is closing/updating and it doesn't actually postpone the update, just closes the screen. Let me know what you think.

2 - Part of the text in Japanese is now displayed in English for the "Progress" screen. Is this translation pending? Also reproducible on all platforms.

This piece of copy is delivered through the newsfeed in both languages and it is unique for every update. We can use anything for testing. For example one of the newsfeed posts from the previous updates.
 "content": {
        "en-US": "This update significantly improves both blockchain synchronization speed and connection time, and fixes some network connection issues. Daedalus 2.2.0 also includes numerous enhancements and resolves some minor issues.",
        "ja-JP": "今回の更新ではまた、ブロックチェーンの同期スピードおよび接続時間が大幅に向上したほか、一部のネットワーク接続に関する不具合も修正されています。Daedalus 2.2.0には他にも多くの機能改善および一部の軽微な不具合の修正が含まれます。"
      }```

@gnpf @mioriohk @ManusMcCole build 14438 fixes:

Changing the app language would not change the update description

The spinner color now follows the button text color for all themes

The postpone link now behaves in the following ways, after clicking the main button:

Linux: The text changes to "Installing update...", no underline (not a link), no transparency
Other OS: The text remains as "Postpone the update", no underline (not a link), with transparency

Linux installation is still failing.

@daniloprates Great job, most of the issues are fixed. I updated the description with the summary for 14438.
@ManusMcCole @mioriohk Feel free to update the summary if something else comes up on this build.

@daniloprates Great work! The update is now working on Linux. Here are a few unexpected behaviors I found on 14452:
1 - The update in Linux is working, but there are a lot of console errors. Here are a screenshot and the details for the errors I managed to capture.
2 - If the .crdownload file on "Downloads" is deleted and Daedalus reopen, the download resumes and completes, but a new .crdownload is visible on the folder instead of the pkg, exe or bin.
3 - As a continuation of the previous issue, if you click "update and restart" on Linux, Daedalus updates, even if the corresponding bin file is not present in "Downloads".
I'll wait until @mioriohk and @ManusMcCole test this to update the summary.

@daniloprates @cleverca22 The testing summary is updated on the description of this PR.

@daniloprates For 14467, there are a couple of issues with the download file:
1 - The progress bar is displayed even if the file is already downloaded.
2 - The update file is downloaded everytime Daedalus is open.
3 - The "Update available" screen is never displayed after the bar reaches 100%. Also a console error is visible.
These are partial results on Mac. I'll test on Win and Lin and update this if I found further issues.

@daniloprates @cleverca22
On build 14473:
1 - The issues with the update file are fixed.
2 - The logging is still visible on Lin.
3 - There is a progress bar for the installation on Linux, but it does not show progress. I'm not sure if this is still in progress.

Hi @Danilo and @cleverca22
Here is a summary of our findings for build 14475
1.The progress bar is working as expected. Although some of the themes colours are off. For Cardano, Dark Blue, and Light Blue the colours are grey and white and I believe they should match this Loading Bar Themes
2.The update is working correctly on all OS
3.Logging messages are still appearing in the console on Linux as expected


fix(ingest): catch all exceptions when creating a pipeline

Checklist

[X] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[X] Links to related issues (if applicable)
[X] Tests for the changes have been added/updated (if applicable)
[X] Docs related to the changes have been added/updated (if applicable)

closing in favor of #3974


Warnings when compiling smtp.c with -O2

On Ubuntu 18.04 x86_64 witg gcc 7.3.0 I get this:
cc -O2 -DSMTP_OPENSSL smtp.c -c -o smtp.o
smtp.c: In function ‘smtp_mail’:
smtp.c:1882:47: warning: ‘%0+5ld’ directive writing between 5 and 19 bytes into a region of size 15 [-Wformat-overflow=]
"%s, %02d %s %d %02d:%02d:%02d %0+5ld",
^~~~~~
smtp.c:1882:16: note: directive argument in the range [-256204778801521500,<PHONE_NUMBER>01521500]
"%s, %02d %s %d %02d:%02d:%02d %0+5ld",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/stdio.h:862:0,
from /usr/include/openssl/bio.h:16,
from smtp.c:54:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: ‘__builtin___sprintf_chk’ output 23 or more bytes (assuming 37) into a destination of size 32
return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
__bos (__s), __fmt, __va_arg_pack ());

The compiler generates a false-positive warning. GCC documentation for -Wformat-overflow: 'While enabling optimization will in most cases improve the accuracy of the warning, it may also result in false positives.'
It appears to complain about the UTC offset and assumes it is unbounded. However, the offset is actually restricted to a maximum of 4 digits because earlier difftime() subtracts local and UTC time, and then computes the offset from that difference.
I committed a change [4f83bb8] to increase the buffer size which should silence the compiler warning.


Issue 89, AES and DES encryption at rest

This PR is related to https://github.com/orientechnologies/orientdb/issues/89
Here are two new cluster compression methods that use AES and DES to encrypt data.
Keys have to be declared into the configuration file, or in any other way supported by OrientDB (command line, direct set on OGlobalConfiguration enumerator).
There is of course room for improvements, consider this as a first WORKING implementation.
usage:
create class aes
alter cluster aes compression aes-encrypted

create class des
 alter cluster des compression des-encrypted

We're in RC phase, I'll merge this as soon as we start the 2.2-SNAPSHOT.

Hey @giastfader I was merging this in develop, but unfortunately you didn't sign the clahub agreement (for the Apache2 license). Please could you do that? Thanks in advance.

Waiting for you to electronic signing the CLA, I saw you use 2 new global settings:
STORAGE_ENCRYPTION_DES_KEY("encryption.des_key","The simmetric key to use to encrypt/descript data at rest using the DES alghorithm, stored in BASE64. The key must be 64 bits long. Default is \"T1JJRU5UREI=\" (ORIENTDB).",String.class,"T1JJRU5UREI="),
 STORAGE_ENCRYPTION_AES_KEY("encryption.aes_key","The simmetric key to use to encrypt/descript data at rest using the AES alghorithm, stored in BASE64. The key must be 128 or 256 bits. Default is \"T1JJRU5UREJfSVNfQ09PTA==\" (ORIENTDB_IS_COOL).",String.class,"T1JJRU5UREJfSVNfQ09PTA=="),

I think it would be much better don't setting any password by default and check if password is null, an exception is raised. In this way the user can't do mistakes. WDYT?

Yes, I agree, if you want to force the admin to explicitly set a key.

Cool, I'm merging it right now

Done, thanks!


Slack - can't share files from google drive

Hi, I use Slack to work and share files.
And i have a problem, i hope we can solve this together (sorry for my english i'm from chile)
Expected Behavior

To share files from Drive, I click on the + to the left, select share from drive, then I select the file and the message should appear.
"You have shared the X file"
Current Behavior

When I want to share a document from my drive, the pop-up window appears, I select the file, the pop-up window closes but the file is not linked or appears.
I tried the button from Slack web and the slack application and if it works there.
It would be very useful to better integrate everything in franz.
Screenshots (if appropriate):

and then

Finally Nothing (the file share in the back was made by using the Slack App for windows)
Possible Solution

Steps to Reproduce (for bugs)

Context

i was trying to share a file to work with my mates, the fast solution was open google drive and paste the link.
Your Environment

Franz Version used: 5
Operating System and version: Windows 7 64 bits

I am having the same issue running in Arch Linux, so not only Windows.

Same here for OSX

Same here for maxOS

Hi there, April 2020 now, and I’m having this issue still. Is everyone still experiencing this as well?

Yes, I'm trying to attach a file in the chat from mi Google drive and show error.
Maybe it's beacuase I use slack in Franz or web app,

From: john-st<EMAIL_ADDRESS>Sent: Tuesday, April 14, 2020 12:27:37 PM
To: meetfranz/franz<EMAIL_ADDRESS>Cc: NicRC<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [meetfranz/franz] Slack - can't share files from google drive (#796)
Hi there, April 2020 now, and I’m having this issue still. Is everyone still experiencing this as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/meetfranz/franz/issues/796#issuecomment-613543945, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIMN5WVDYV6NJT5KYQLBJ3DRMSFHTANCNFSM4EVFS4EQ.

Web app works, seems to be a Franz service issue
John
Sent from my mobile.
Springtime Design
Mobile: +31 6 51339659
Skype: johnkock2009
WeChat: johnkock

Op 14 apr. 2020 om 18:51 heeft NicRC<EMAIL_ADDRESS>het volgende geschreven:

Yes, I'm trying to attach a file in the chat from mi Google drive and show error.
Maybe it's beacuase I use slack in Franz or web app,

From: john-st<EMAIL_ADDRESS>Sent: Tuesday, April 14, 2020 12:27:37 PM
To: meetfranz/franz<EMAIL_ADDRESS>Cc: NicRC<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [meetfranz/franz] Slack - can't share files from google drive (#796)
Hi there, April 2020 now, and I’m having this issue still. Is everyone still experiencing this as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/meetfranz/franz/issues/796#issuecomment-613543945, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIMN5WVDYV6NJT5KYQLBJ3DRMSFHTANCNFSM4EVFS4EQ.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I am experiencing this issue as well.  I'm surprised this issue hasn't been worked on at all yet.

Yes! Same here.
Sorry, I can't import folders from Google Drive.


[builder] Calling UFOBuilder directly doesn't set minimal=True and thus prevents color layer processing

Since the ninja builder came about, gftools relies on its own routine to generate designspace objects from Glyphs sources, rather than having fontmake do that.
fontmake however calls UFOBuilder() with minimal=True, which the ninja builder doesn't, and the effect of that is that

color layers aren't processed, which rely on minimal=True
possibly the UFO builder is overall slower than it should for one-way font generation

So minimal=True needs to be set explicitly (which is set to False by default) to ensure correct color layer handling in glyphsLib.
I'll attach a PR in a second.

actually, the gftools ninja builder is still calling fontmake -o ufo -g input.glyphs command to convert from .glyphs to DS+ufo (see the glyphs2ufo ninja build rule). It seems to be using the UFOBuilder just to get a minimal designspace file in order to obtain the paths of the master UFOs that will be generated when the glyphs2ufo build rule is actually run..
@simoncozens can you change glyphsLib to add APIs to obtain these pieces of info without you having to hack into the bowels of UFOBuilder (e.g. like overriding methods with lambda: True to make them noop, etc.)?

can you change glyphsLib to add APIs to obtain these pieces of info without you having to hack into the bowels of UFOBuild

No, I don't think I can. For example, if we skip the line
            list(self.masters)  # Make sure that the UFOs are built

then to_designspace_sources fails because self._sources is not filled in; that happens in to_ufo_font_attributes. glyphsLib.builders really isn't designed to work in a compartmentalised way, and I don't really think it's worth the effort of completely rearchitecturing it right now. I think under the circumstances hacking into the bowels of overriding methods is the least bad approach.

color layers aren't processed, which rely on minimal=True

That's kind of weird. minimal=True should do less work than minimal=False.

color layers aren't processed, which rely on minimal=True

That's kind of weird. minimal=True should do less work than minimal=False.

In case of color fonts, we are piggybacking to mean give me a UFO I can build with ufo2ft and get color tables, since UFO officially has no support whatsoever for color fonts and we are using private ufo2ft lib keys that (I thought) would not be appropriate for a general purpose UFO.

perhaps it is mis-named, but minimal=True option in glyphsLib effectively means "get me UFOs+DS suitable for building an OpenType font without worrying about saving additional metadata that's not relevant for compilation but only for roundtripping back to .glyphs". Or conversely, minimal=False means "try to preserve as much as you can of the original source file so that I can do some edits elsewhere and then convert it back to the original format".
Thus, color layers don't get translated to ufo2ft-compatible format in minimal=False mode


Federation example fail with SQL30081N  A communication error has been detected

During create server step see following error:
WARNING: Failed to execute:
   CREATE SERVER DASHDB TYPE DB2/UDB VERSION 10.6 WRAPPER DRDA
   AUTHORIZATION "dash6590" PASSWORD "***masked***"
   OPTIONS (DBNAME 'BLUDB', COLLATING_SEQUENCE 'N')
 because: DB2 SQL Error: SQLCODE=-30080, SQLSTATE=08001, SQLERRMC=104;*;0;TCP/IP;SOCKETS;<IP_ADDRESS>;recv, DRIVER=3.70.4
Exception in thread "main" com.ibm.db2.jcc.am.SqlNonTransientConnectionException: DB2 SQL Error: SQLCODE=-30080, SQLSTATE=08001, SQLERRMC=104;*;0;TCP/IP;SOCKETS;<IP_ADDRESS>;recv, DRIVER=3.70.4

Need to see if this is related to having SSL on source db.

Was able to setup SSL connectivity between BIoC and DashDB. Still need to look at creating actual server for federation.
[bigsql@bicloudqa-163-master-1 ~]$ db2 connect to BLUDB user dash6590
Enter current password for dash6590:

   Database Connection Information

 Database server        = DB2/LINUXX8664 10.7.0
 SQL authorization ID   = DASH6590
 Local database alias   = BLUDB

[bigsql@bicloudqa-163-master-1 ~]$ db2 terminate

Federation example now works ... setup instruction are in README_Federation.
:compileJava UP-TO-DATE
:compileGroovy
:processResources UP-TO-DATE
:classes
:Federation
Create wrapper
Create server mapping
Create user mapping
Create nickname
Select from table: select language_code, language_desc from language
b : N/A (less than 5 years old)
1 : Yes, speaks another language
2 : No, speaks only English

>> Federation test was successful.

BUILD SUCCESSFUL


Error installing pod

[!] Error installing MediaWatermark
[!] /usr/bin/git clone https://github.com/rubygarage-ios/MediaWatermark.git /var/folders/tp/n1gccmt510s5v3r20krnv1b80000gn/T/d20180316-11209-z3x71m --template= --single-branch --depth 1 --branch 0.1.0
Cloning into '/var/folders/tp/n1gccmt510s5v3r20krnv1b80000gn/T/d20180316-11209-z3x71m'...
remote: Repository not found.
fatal: repository 'https://github.com/rubygarage-ios/MediaWatermark.git/' not found

You tried to install version 0.1.0. We've fixed this in next releases.
Try pod 'MediaWatermark', '~> 0.2'

In pod file:
pod 'MediaWatermark','~> 0.2'
but returns me on "pod install":
_[!] CocoaPods could not find compatible versions for pod "MediaWatermark":
In Podfile:
MediaWatermark (~> 0.2)
None of your spec sources contain a spec satisfying the dependency: MediaWatermark (~> 0.2).
You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, pod repo update does not happen on pod install by default._

Try to update pod repo:
pod repo update


Fixed serialization of list/binary types

@MichalPrincNXP this one should be ready for merge

Thanks a lot!


Alarm Panel Size

I have added the Panel Card and works as intended however the sizing that its showing cuased an issue, i dont know if anyone else is experiencing the same thing, but when i open the panel it opens at a default size and it shows a scroll bar to the right to go up or down.
on my laptop it isnt a problem but if i swap over to my tablet it shows the same size and i then have to scroll to get to the keypad.
Is there anyway to manual adjust the size of this and remove the scroll bar ?
Please see images below.
Tablet :

Laptop:

Thanks again for you hard work on this.

I do experience the same.
On my iPad I do miss the half of the under line (x,0,v)

FR: Mobile Support https://github.com/matt8707/ha-fusion/issues/15


refactor: rename swagger to oas in errors

resolves #164

generateNewValidOpenapi

I should have changed all occurrences of swagger to openapi 😓


PLAYER_DEATH_LEVEL is hardcoded

introduced in #1084
Should be customizable in the Level Editor

Is this really necessary?


Move data transformation from Pigeon to Paloma when sending data to EVM

Background
Currently, Pigeon is the one that takes the data and from the Pigeon and transforms it to bytecode.  Messages coming to Pigeon which are ready for sending, should come in a bytecode format. That way we hold our logic on a single place only, which happens to be Paloma.
Done when

[ ] Pigeon  is not transforming the incoming data, it's only forwarding it to target chain
[ ] Paloma is doing the transformation

closing until we get back to this


Extension not working

Hi, the extension is not working, I followed every step as mentioned in the instructions but still the extension is not working

Yea its not working even i tried reloading the page and reloading the extension but still its not working

have you tried reading the pinned #99 issue or the top of readme


AWS Elasticache

Hi, has anyone used AWS Elasticache (https://aws.amazon.com/elasticache/) since it claims to be Redis compatible?
Thanks!

I use elasticache for benchmark, fault tolerance and Windows tests. I haven't had any compatibility issues.

Hi, I am trying to test Durable Rules with a Redis instance running on AWS (one primary node and two replica nodes) with two endpoints
primary: master.rules.8rb1zj.use1.cache.amazonaws.com:6379
reader: replica.rules.8rb1zj.use1.cache.amazonaws.com:6379
launching Durable Rules using the primary endpoint
run_all([{'host': 'master.rules.8rb1zj.use1.cache.amazonaws.com', 'port': 6379, 'password': password}], '<IP_ADDRESS>', 8080)
throws  the following error
rules.error: Could not create connection, error code: 306
getReply err 1, 11,
I am wondering:
(1) why the connection is being refused (error code 306 not documented here https://github.com/jruizgit/rules/blob/master/docs/rb/reference.md#error-codes)
(2) can Durable Rules take advantage of the reader endpoint, and if yes, how?
Thank you!

Hi,
Re (1) above, disabling AWS Redis authentication fixed the connection issue
Re (2) your input/thoughts will still be appreciated
Thanks!


reply_to doesn't seem to be respected

Issue Summary
When configuring a reply_to attribute, emails are still being received without any mention of it. I can get the desired behavior by setting from but I'm concerned this may lead to issues as being identified as spam/fake/etc by filters.
Steps to Reproduce
SendGrid.send({
    to<EMAIL_ADDRESS>    from<EMAIL_ADDRESS>    reply_to: { name: payload.name, email: payload.email },
    subject:  `Dashboard feedback from ${payload.email}`,
    /* ... */

Technical details:

sendgrid-nodejs Version: latest
Node.js Version: 4.4.5

Hello @jmonster,
That should definitely not be the case. Thanks for letting us know. We'll dig deeper and see what's going wrong.

Hello @jmonster,
This is no longer an issue with the v3 version of our API. A full example that utilizes the reply_to field can be found here.
Please let me know if you run into any other issues.
Thanks!


[Cleanup] Adopt eslint vue/recommended: ARPA Reporter: upload views

Ticket #2764
Description
Brings ARPA reporter upload views into compliance with new linting rules.

./src/arpa_reporter/views/Upload.vue
./src/arpa_reporter/views/Uploads.vue

A few notes for the reviewer:

Most of the diff is auto-fixed, so reviewing commit by commit should make things easier

Screenshots / Demo Video

Testing
Manually verified basic behavior of upload and upload list views.
Automated and Unit Tests

[ ] Added Unit tests

Manual tests for Reviewer

[ ] Added steps to test feature/functionality manually

Checklist

[ ] Provided ticket and description
[ ] Provided screenshots/demo
[ ] Provided testing information
[ ] Provided adequate test coverage for all new code
[ ] Added PR reviewers

@tzinckgraf Thanks for the review! Responded to your comment, fixed a merge conflict in .eslintrc, and it's back to you for re-review.


refactor: deprecate cactus-cockpit package

Fixes #1112
Signed-off-by: Jeffrey Ushry<EMAIL_ADDRESS>

Codecov Report

Merging #1113 (22576c9) into main (403f135) will decrease coverage by 0.02%.
The diff coverage is n/a.

:exclamation: Current head 22576c9 differs from pull request most recent head 6c6f3bd. Consider uploading reports for the commit 6c6f3bd to get more accurate results

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   72.99%   72.97%   -0.03%
==========================================
  Files         243      243
  Lines        8503     8503
  Branches      987      987
==========================================
- Hits         6207     6205       -2
- Misses       1771     1773       +2
  Partials      525      525

Impacted Files
Coverage Δ

...t-tooling/src/main/typescript/common/containers.ts
74.48% <0.00%> (-0.83%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403f135...6c6f3bd. Read the comment docs.


Clean up assertions for _.difference()

:+1: thanks

Looks like tests failed for an unrelated reason.

Most likely because I merged before they finished running
On Wed, Jan 20, 2016 at 1:39 PM, Jordan Eldredge<EMAIL_ADDRESS>wrote:

Looks like tests failed for an unrelated reason.
—
Reply to this email directly or view it on GitHub
https://github.com/jashkenas/underscore/pull/2422#issuecomment-173319169
.


Support for PVs, PVCs, and other K8s persistent volume support

I work for Diamanti, a company that has a Kubernetes appliance featuring high performance storage and networking, both offering QOS that is accessible to the developer via K8s podspec.
In attempting to help a customer use Spark on Kubernetes, we're running into the issue of not being able to control the type of storage used by Spark jobs.
I've reviewed several past (open and closed) issues reported in this repository, and they all seem to be single use case examples (and fixes), such as for emptydir or hostpath support.
Shouldn't Spark-on-K8s generically support PVs/PVCs and other K8s ways of having temporary or persistent storage instead of single fixes for hostpath, emptydir etc?
Hosts in general and K8S clusters in particular have multiple classes of storage available to them. K8s clusters have a plethora of persistent storage options including FlexVolume (today) and CSI (to replace FlexVolume going forward).
With regards to Spark, wouldn't it be ideal if temporary files could be directed to the lowest latency highest throughput storage available to the cluster?
I would like to see if we could use the spark-submit or any other method to describe K8S volumes or PVCs so that users of Spark-on-K8s could use the storage best suited for the performance and capacity needs of their applications.

Support for mounting PVCs and other types of volumes is being worked on in https://github.com/apache/spark/pull/21260. The title of the PR says hostPath, but the implementation is generic and works with other types of volumes too. Note that we moved development into upstream.

Thanks, I'll close this and follow the action upstream.

@liyinan926 , Is there a config example for a PV or PVC?
I downloaded and compiled the commits in apache #2600; want to try this in my environment.
According to the JIRA, it's:
spark.kubernetes.executor.volumes=hostPath:containerPath[:ro|rw]  for hostPath, but what about PV?


Does this work?

It's the top result on Google for "openai raspberry pi wake word"
Be honest, is this the best A.I. speaker voice assistant?
I plan to sit down one evening and deploy it at home, but I just wanted to check that it wasn't a dead end project or broken, or if there was a more recommended option.
Thanks for making it btw

Also, bro, Silicon Valley would throw you some cash to make this a startup company, just go apply for funding at the angel investor places there. The world needs a replacement for Alexa and Amazon is lazy.

I think it might need some updates it you want to get it work now. But 6 months ago, it did work.
This is actually just a course project I did last semester. To be honest, it is mostly about calling APIs and kind of a POC for building a voice assistant with newest AI. It's still simple to build it so I think talking about building a startup in the Silicon Valley is too early while I am still struggling to find a graduate job in hk now :(
Thanks for your comments btw!


@ModelAttribute Generates Different Output than @RequestBody

I'm currently running into an issue where the @ModelAttribute annotation on a GET request mapping, generates different output than the @RequestBody annotation on a POST request mapping.  One of the key things I'm seeing is the lack of support for arrays, and allowable values.

Looking at
https://github.com/springfox/springfox/blob/master/springfox-spring-web/src/main/java/springfox/documentation/spring/web/readers/parameter/ExpandedParameterBuilder.java
Looking at the 'apply' method:
  @Override
  public void apply(ParameterExpansionContext context) {
    AllowableValues allowable = allowableValues(context.getField());

    String name = isNullOrEmpty(context.getParentName())
            ? context.getField().getName()
            : String.format("%s.%s", context.getParentName(), context.getField().getName());

    context.getParameterBuilder()
            .name(name)
            .description(null).defaultValue(null)
            .required(Boolean.FALSE)
            .allowMultiple(Boolean.FALSE)
            .type(resolver.resolve(context.getField().getType()))
            .modelRef(new ModelRef(context.getDataTypeName()))
            .allowableValues(allowable)
            .parameterType("query")
            .parameterAccess(null);
  }

The issue I'm seeing is that it doesn't allows multiple, and every field has a model ref.  So items that are lists of strings are not working properly.

@timothysoehnlin this is by design. It's meant to only support scalar values. Plus it might be a little spotty

on multiple/array properties.
these are parameters available in the query string.
Really if u need a rich domain model it's better to use the @RquestBody As it utilizes the message converter machinery.

I would prefer to use @RequestBody, but as far as I know, I can't use @RequestBody with GET requests.  Swagger supports non-scalar values in the Query String.  The @ApiParam's also seem to support it, but not honor it when generating the JSON.

@timothysoehnlin sorry dint check to see that it was a GET. I think its a bug that allow multiples is not automatically detected.

Allowable values and multiple also seems not to be honored via
@apiimplicitparam
On Aug 26, 2015 7:38 AM, "Dilip Krishnan"<EMAIL_ADDRESS>wrote:

@timothysoehnlin https://github.com/timothysoehnlin sorry dint check to
see that it was a GET. I think its a bug that allow multiples is not
automatically detected.
—
Reply to this email directly or view it on GitHub
https://github.com/springfox/springfox/issues/929#issuecomment-134989262
.

@timothysoehnlin It should work as expected. Could you perhaps provide a breaking test?

@dilipkrish I stand corrected, the allowable values do appear to be used.  I realize now the issue for me was that @ApiModelProperty doesn't have the field for allowableValues, and since I'm using that to convert to an @ApiImplicitParam, I'm not able to copy that data over.


[Linux] Add support for extended advertisement

Problem
Linux platform does not support extended advertisement, and the fast/slow advertisement is not conformant with the spec.
Changes

Properly setup min/max advertisement intervals (this requires BlueZ to have experimental features enabled)
Add logic to transition between fast and slow adv intervals
Add logic to transition to extended adv intervals
Fix some "advertissement" typos

Testing
Manually checked that after 15 minutes, the advertising payload does not contains vendor and product IDs.

General question - do we have any way to test BLE in the CI?

As far as I know, no. We are working on a solution for that, but the PoC is not ready yet. Maybe we will submit a PR in a month or so. Unfortunately, the setup will require to run everything in QEMU, since GitHub Action VM kernel lacks some required modules.


Scraper throws error instead of pulling values from a webpage

I've written a script in python to get the price of last trade from a javascript rendered webpage. I can get the content If I choose to go with selenium. My goal here is not to use any browser simulator because the latest release of Requests-HTML is supposed to have the ability to parse javascript encrypted content. However, I am not being able to make a go successfully.
import requests_html

with requests_html.HTMLSession() as session:
    r = session.get('https://www.gdax.com/trade/LTC-EUR')
    js = r.html.render()
    item = js.find('.MarketInfo_market-num_1lAXs',first=True).text
    print(item)

When I execute the script I get the following error (partial traceback):
Traceback (most recent call last):
  File "C:\Users\ar\AppData\Local\Programs\Python\Python35-32\new_line_one.py", line 27, in <module>
    item = js.find('.MarketInfo_market-num_1lAXs',first=True).text
AttributeError: 'NoneType' object has no attribute 'find'
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "C:\Users\ar\AppData\Local\Programs\Python\Python35-32\lib\shutil.py", line 381, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 5] Access is denied:

Your script runs fine for me!
import requests_html

with requests_html.HTMLSession() as session:
    r = session.get('https://www.gdax.com/trade/LTC-EUR')
    r.html.render()
    print(r.html.find('.MarketInfo_market-num_1lAXs', first=True).text)

Slightly modified. Pyppeteer might not work on Windows. I'll have to test.

Oh, make sure you're using python 3.6!

Here is the full traceback, sir. Link to the traceback "https://www.dropbox.com/s/40ohohrte9keplo/traceback.txt?dl=0". I know it's hard to give any solution hypothetically. However, if I get any clue why I'm facing such error then I might take any initiative to resolve that. I've already created a thread in StackOverflow to get any solution for but it seems you have released it very lately that is why few peoples are aware of it.

Well pyppeteer requires python 3.6.

Thanks for the quick turnaround, sir. I'm gonna upgrade the version. It was an immense pleasure to have any solution from the author himself. I may get back if I face any issue after running the script when my version is update. Thanks sir.

I'm testing on windows as we speak.

Windows works great! You just have to use Python 3.6.

(You're using Python 3.5)

It's a revolutionary attempt. This library will make a new era undoubtedly.

Awe, thank you :)
Do give Python 3.6 a try — it should "just work".

Hi again sir!! I've already upgraded my Python version to 3.6.4.  I'm on windows 7, 32 bit. When I execute the above script, I get a different traceback now. Here goes the full error. Thanks in advance, sir.
Exception in callback NavigatorWatcher.waitForNavigation.<locals>.watchdog_cb(<Task finishe...> result=None>) at C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pyppeteer\navigator_watcher.py:49
handle: <Handle NavigatorWatcher.waitForNavigation.<locals>.watchdog_cb(<Task finishe...> result=None>) at C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pyppeteer\navigator_watcher.py:49>
Traceback (most recent call last):
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\asyncio\events.py", line 145, in _run
    self._callback(*self._args)
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pyppeteer\navigator_watcher.py", line 52, in watchdog_cb
    self._timeout)
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pyppeteer\navigator_watcher.py", line 40, in _raise_error
    raise error
concurrent.futures._base.TimeoutError: Navigation Timeout Exceeded: 3000 ms exceeded
Traceback (most recent call last):
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\demo.py", line 13, in <module>
    item = js.find('.MarketInfo_market-num_1lAXs',first=True).text
AttributeError: 'NoneType' object has no attribute 'find'
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\shutil.py", line 387, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\ar\\.pyppeteer\\.dev_profile\\tmp2hnn897d\\CrashpadMetrics-active.pma'

you might want to run it in an administrator mode cmd.exe

I tried that as well, sir. Having the same error.

try removing ~/.pyppeteer

not sure what's wrong! no issues here.

I did a slight modification in my script to fetch the data. Now, I can get the desired content. However, along with the data I'm getting several errors. Take a look below. I have already marked the result with a marker. How can I kick out errors?
Modified script:
import requests_html

with requests_html.HTMLSession() as session:
    r = session.get('https://www.gdax.com/trade/LTC-EUR')
    r.html.render(sleep=10)
    item = r.html.find("[class^='MarketInfo_market-num_']",first=True).text
    print(item)

Error along with result (take a look at the long dot which indicates the value) :
Exception in callback NavigatorWatcher.waitForNavigation.<locals>.watchdog_cb(<Task finishe...> result=None>) at C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pyppeteer\navigator_watcher.py:49
handle: <Handle NavigatorWatcher.waitForNavigation.<locals>.watchdog_cb(<Task finishe...> result=None>) at C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pyppeteer\navigator_watcher.py:49>
Traceback (most recent call last):
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\asyncio\events.py", line 145, in _run
    self._callback(*self._args)
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pyppeteer\navigator_watcher.py", line 52, in watchdog_cb
    self._timeout)
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pyppeteer\navigator_watcher.py", line 40, in _raise_error
    raise error
concurrent.futures._base.TimeoutError: Navigation Timeout Exceeded: 3000 ms exceeded
167.69 EUR         ====================================================
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "C:\Users\ar\AppData\Local\Programs\Python\Python36-32\lib\shutil.py", line 387, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\ar\\.pyppeteer\\.dev_profile\\tmp4m18xik8\\CrashpadMetrics-active.pma'

Other than parsing javascript content, the library was awesome when it comes to play with css selector or xpath. It even supports pseudo selectors that BeautifulSoup could not. lxml library supports pseudo selectors, though. I hope you will restore the library soon.


Rename window.navigator.startActivity to Intent.prototype.start

Compare the following:

window.navigator.startActivity(intent);
intent.start();

The second one is:

shorter
easier to remember
cleaner (API is contained within the Intent namespace)

Just tracking this back.  We have decided to go with window.navigator.startActivity()


BAU: Make Proxy Node metadata entityID match the URL

In eIDAS world the entityID has to match the Metadata URL

Or do I have to be a special GSP approver?

Yeah..... 😞


Submissions history for a given exercise

It should be accessible by clicking the exercise name in the guide view.

We could use http://benkeen.github.io/ace-diff/, as suggested by @javierfernandes


Notifications

[x] Schedule (Automatic)
[ ] Manual - custom message

[ ] Opening schedule in app
[ ] Opening somewhere else? (suggestions @dsykesturner )

Like when you click the notification, it's gonna open the app to the schedule screen

Sorry for the late reply. No I wouldn't worry about opening specific screens. App side I might not have time to implement


remove unused imports

I just removed unused imports, sorted the remaining ones alphabetically and changed any requires to import as typescript seems to get on better with that.
I think there are some unused deps in package.json too but I'll run through all the examples first.
Thanks for sharing these examples, and making this great project!

Of course, thanks for contributing!


Allow for Snowflake key-pair authentication with --dbt

Adds support for key-pair authentication with Snowflake with dbt; namely supports profile options:
...
private_key_passphrase: <...>
private_key_path: <...>
# or
private_key: <...>

Running locally with the correct key-pair provides message (indicating a successful authentication):
❯ poetry run python3 -m data_diff --dbt
Found 1 successful model runs from the last dbt command.
[15:07:12] ERROR - 002003 (02000): SQL compilation error:
Database 'XXX' does not exist or not authorized.

And with incorrect key-pair:
❯ poetry run python3 -m data_diff --dbt
Found 1 successful model runs from the last dbt command.
[15:49:02] ERROR - Bad decrypt. Incorrect password?

While this works, this code does not handle situations where a user incorrectly provides both a passwords and a key/key path; if both are provided, the password is preferred.
The code, prior to this contribution, does not appear to take a stance on error handling with respect to different types of authentication; I am hoping a maintainer can provide an opinion on this. I am happy to add unit tests after the route forward has been decided

Handles issue: https://github.com/datafold/data-diff/issues/442

@dlawin I made a PR which I tested locally via poetry add --editable ../sqeleton-fork. I've made some other modifications to this code as to make this compatible with non-dbt auth; happy to push that up too
It's quick and dirty - like I mentioned, just trying to get this usable for my org

Hey Jake, we want to get this in the next release (soon) so I ran with a few PRs of my own:
https://github.com/datafold/data-diff/pull/468
https://github.com/datafold/sqeleton/pull/34
https://github.com/datafold/data-diff/pull/469
Appreciate your contributions here!


Laravel 6.0 support

Describe the bug
Changelog of version 3.4.0 says that support for Laravel 6 is added but in  src/Vendor/Laravel/Support/Session.php Input facede is used, which is not present in Laravel 6.0.
To Reproduce
Steps to reproduce the behavior:

Try to enter stats panel.
Error Class 'Illuminate\Support\Facades\Input' not found occured.

Expected behavior
Working stats panel.
System

OS: Mac OS 10.14.6
Browser: Chrome
Version 77

I hacked a fix for laravel 6.
Try it out if it may help.

@eadortsu, your patch was merged. Thank you!