NullReferenceException when creating SkCanvas backed by a WriteableBitmap

The following code from https://github.com/impsnldavid/skiasharpwpfextensions fails randomly with a NullReferenceException when the SkCanvas is constructed.
The member variable _bitmap is a WriteableBitmap
		protected override void OnRender(DrawingContext dc)
		{
			if (_bitmap == null)
				return;

			_bitmap.Lock();

			using (var surface = SKSurface.Create((int)_bitmap.Width, (int)_bitmap.Height,
				SKColorType.N_32, SKAlphaType.Premul, _bitmap.BackBuffer, _bitmap.BackBufferStride))
			{
				if (IsClearCanvas)
					surface.Canvas.Clear(_canvasClearColor);

				Draw(surface.Canvas, (int)_bitmap.Width, (int)_bitmap.Height);
			}

			_bitmap.AddDirtyRect(new Int32Rect(0, 0, (int)_bitmap.Width, (int)_bitmap.Height));
			_bitmap.Unlock();

			dc.DrawImage(_bitmap, new Rect(0, 0, ActualWidth, ActualHeight));
                }

The exception randomly occurs on calls to surface.Canvas.Clear(_canvasClearColor);
The NullReferenceException is wrapped in a TargetInvocationException. Here are the call stacks:
Inner NullReferenceException Stack Trace
   at SkiaSharp.SKObject.RegisterHandle(IntPtr handle, SKObject instance)
   at SkiaSharp.SKCanvas..ctor(IntPtr handle)

TargetInvocationException Stack Trace
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at SkiaSharp.SKObject.GetObject[TSkiaObject](IntPtr handle)
   at SkiaSharp.WpfExtensions.SkiaControl.OnRender(DrawingContext dc) in C:\Users\_\Documents\GitHub\skiasharpwpfextensions\src\Imp.SkiaSharpWpfExtensions\SkiaControl.cs:line 83
   at System.Windows.UIElement.Arrange(Rect finalRect)
   at System.Windows.ContextLayoutManager.UpdateLayout()
   at System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object arg)
   at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
   at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
   at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at Imp.SkiaSharpWpfExtensions.Example.App.Main() in C:\Users\magnu_000\Documents\GitHub\skiasharpwpfextensions\src\Imp.SkiaSharpWpfExtensions.Example\obj\x64\Debug\App.g.cs:line 0
   at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
   at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
   at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

My guess is that the reason this is happening is the following lines of code in SKObject:
var shouldReplace =
              reference == null ||
              reference.Target != null ||
              ((SKObject)reference.Target).Handle == IntPtr.Zero;

Lets assume that reference is not null but the Target property is.

reference == null would be false.
reference.Target != null would be false

Since both the above expressions evaluate to false it is necessary to evaluate the last expression as well. But in this case Target is null and this is what is causing the exception.

Would you mind confirming is the bug is fixed with the pull request that you so kindly sent us?

@migueldeicaza the bug was kind of random but always occurred after a short while. I have not been able to reproduce it but will leave the test application running over night just to be sure. Looks good.

No crash during the night. I consider this bug fixed.

Thanks!


Azerbaijani language name

Just added i18n to Mozilla Community page and there was problem with language switch. English (en) and azərbaycan dili (az). Due to rules of Azerbaijani language and according to wikipedia page of Azerbaijan, language's name should be written with big letter.
Azərbaycanca - This form is used in many place, also we use this form in Ubuntu OS and Mozilla products (mozilla.org, Firefox, Firefox for Android).

Please follow https://docs.djangoproject.com/en/dev/internals/contributing/committing-code/#committing-guidelines (rebase your commits so you will have only one and change commit message).

@jezdez is there a reason to consider the entry you added in 5050e305 as canonical?

@coldmind is it ok now? There is no issue, so its not fix for issue, do I need to open one?
Didn't written to django mailing list as its neither big, nor medium fix. It just changes language name.

merged in 0f3ea8c0bc9c7f7f5e448b0b2137bc6351f5eae3, thanks.


Adding Hindsight module.

Adding hindsight (https://github.com/obsidianforensics/hindsight) module to parse Chromium profile collections with Turbinia.

Will talk to Hasan, I think some merge/rebase stuff messed this PR up a bit.

@aarontp thoughts on using click instead of argparse? I've only recently found out about it and started using it in some projects. A lot more powerful (and simpler) imo, for building CLI tools: https://click.palletsprojects.com/en/7.x/
Maybe worth considering as turbiniactl gets more complicated. It is really easy to set argument defaults, prompt options, etc.

@ericzinnikas Yeah, I'd be open to changing to something like that.  I don't know a lot about it, but I think Timesketch uses this as well.
Another thing I'd like to solve with the command args is: https://github.com/google/turbinia/issues/41


chore(deps): update react monorepo (major)

This PR contains the following updates:

Package
Type
Update
Change

react (source)
peerDependencies
major
0.14.7 -> 16.12.0

react (source)
devDependencies
major
0.14.7 -> 16.12.0

react-addons-test-utils
devDependencies
major
0.14.8 -> 15.6.2

Release Notes

facebook/react
v16.12.0
Compare Source
React DOM

Fix passive effects (useEffect) not being fired in a multi-root app. (@acdlite in #17347)

React Is

Fix lazy and memo types considered elements instead of components (@bvaughn in #17278)

v16.11.0
Compare Source
React DOM

Fix mouseenter handlers from firing twice inside nested React containers. @yuanoook in #16928
Remove unstable_createRoot and unstable_createSyncRoot experimental APIs. (These are available in the Experimental channel as createRoot and createSyncRoot.) (@acdlite in #17088)

v16.10.2
Compare Source
React DOM

Fix regression in react-native-web by restoring order of arguments in event plugin extractors (@necolas in #16978)

v16.10.1
Compare Source
React DOM

Fix regression in Next.js apps by allowing Suspense mismatch during hydration to silently proceed (@sebmarkbage in #16943)

v16.10.0
Compare Source
React DOM

Fix edge case where a hook update wasn't being memoized. (@sebmarkbage in #16359)
Fix heuristic for determining when to hydrate, so we don't incorrectly hydrate during an update. (@sebmarkbage in #16739)
Clear additional fiber fields during unmount to save memory. (@trueadm in #16807)
Fix bug with required text fields in Firefox. (@halvves in #16578)
Prefer Object.is instead of inline polyfill, when available. (@ku8ar in #16212)
Fix bug when mixing Suspense and error handling. (@acdlite in #16801)

Scheduler (Experimental)

Improve queue performance by switching its internal data structure to a min binary heap. (@acdlite in #16245)
Use postMessage loop with short intervals instead of attempting to align to frame boundaries with requestAnimationFrame. (@acdlite in #16214)

useSubscription

Avoid tearing issue when a mutation happens and the previous update is still in progress. (@bvaughn in #16623)

v16.9.0
Compare Source
React

Add <React.Profiler> API for gathering performance measurements programmatically. (@bvaughn in #15172)
Remove unstable_ConcurrentMode in favor of unstable_createRoot. (@acdlite in #15532)

React DOM

Deprecate old names for the UNSAFE_* lifecycle methods. (@bvaughn in #15186 and @threepointone in #16103)
Deprecate javascript: URLs as a common attack surface. (@sebmarkbage in #15047)
Deprecate uncommon "module pattern" (factory) components. (@sebmarkbage in #15145)
Add support for the disablePictureInPicture attribute on <video>. (@eek in #15334)
Add support for onLoad event for <embed>. (@cherniavskii in #15614)
Add support for editing useState state from DevTools. (@bvaughn in #14906)
Add support for toggling Suspense from DevTools. (@gaearon in #15232)
Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)
Fix a memory leak. (@paulshen in #16115)
Fix a crash inside findDOMNode for components wrapped in <Suspense>. (@acdlite in #15312)
Fix pending effects from being flushed too late. (@acdlite in #15650)
Fix incorrect argument order in a warning message. (@brickspert in #15345)
Fix hiding Suspense fallback nodes when there is an !important style. (@acdlite in #15861 and #15882)
Slightly improve hydration performance. (@bmeurer in #15998)

React DOM Server

Fix incorrect output for camelCase custom CSS property names. (@bedakb in #16167)

React Test Utilities and Test Renderer

Add act(async () => ...) for testing asynchronous state updates. (@threepointone in #14853)
Add support for nesting act from different renderers. (@threepointone in #16039 and #16042)
Warn in Strict Mode if effects are scheduled outside an act() call. (@threepointone in #15763 and #16041)
Warn when using act from the wrong renderer. (@threepointone in #15756)

ESLint Plugin: React Hooks

Report Hook calls at the top level as a violation. (gaearon in #16455)

v16.8.6
Compare Source
React DOM

Fix an incorrect bailout in useReducer(). (@acdlite in #15124)
Fix iframe warnings in Safari DevTools. (@renanvalentin in #15099)
Warn if contextType is set to Context.Consumer instead of Context. (@aweary in #14831)
Warn if contextType is set to invalid values. (@gaearon in #15142)

v16.8.5
Compare Source
React DOM

Don't set the first option as selected in select tag with size attribute. (@kulek1 in #14242)
Improve the useEffect(async () => ...) warning message. (@gaearon in #15118)
Improve the error message sometimes caused by duplicate React. (@jaredpalmer in #15139)

React DOM Server

Improve the useLayoutEffect warning message when server rendering. (@gaearon in #15158)

React Shallow Renderer

Fix setState in shallow renderer to work with Hooks. (@gaearon in #15120)
Fix shallow renderer to support React.memo. (@aweary in #14816)
Fix shallow renderer to support Hooks inside forwardRef. (@eps1lon in #15100)

v16.8.4
Compare Source
React DOM and other renderers

Fix a bug where DevTools caused a runtime error when inspecting a component that used a useContext hook. (@bvaughn in #14940)

v16.8.3
Compare Source
React DOM

Fix a bug that caused inputs to behave incorrectly in UMD builds. (@gaearon in #14914)
Fix a bug that caused render phase updates to be discarded. (@gaearon in #14852)

React DOM Server

Unwind the context stack when a stream is destroyed without completing, to prevent incorrect values during a subsequent render. (@overlookmotel in #14706)

ESLint Plugin for React Hooks

Add a new recommended exhaustive-deps rule. (@gaearon in #14636)

v16.8.2
Compare Source
React DOM

Fix ReactDOM.render being ignored inside useEffect. (@gaearon in #14799)
Fix a crash when unmounting empty portals. (@gaearon in #14820)
Fix useImperativeHandle to work correctly when no deps are specified. (@gaearon in #14801)
Fix crossOrigin attribute to work in SVG image elements. (@aweary in #14832)
Fix a false positive warning when using Suspense with Hooks. (@gaearon in #14821)

React Test Utils and React Test Renderer

Include component stack into the act() warning. (@threepointone in #14855)

v16.8.1
Compare Source
React DOM and React Test Renderer

Fix a crash when used together with an older version of React. (@bvaughn in #14770)

React Test Utils

Fix a crash in Node environment. (@threepointone in #14768)

v16.8.0
Compare Source
React

Add Hooks — a way to use state and other React features without writing a class. (@acdlite et al. in #13968)
Improve the useReducer Hook lazy initialization API. (@acdlite in #14723)

React DOM

Bail out of rendering on identical values for useState and useReducer Hooks. (@acdlite in #14569)
Use Object.is algorithm for comparing useState and useReducer values. (@Jessidhia in #14752)
Don’t compare the first argument passed to useEffect/useMemo/useCallback Hooks. (@acdlite in #14594)
Support synchronous thenables passed to React.lazy(). (@gaearon in #14626)
Render components with Hooks twice in Strict Mode (DEV-only) to match class behavior. (@gaearon in #14654)
Warn about mismatching Hook order in development. (@threepointone in #14585 and @acdlite in #14591)
Effect clean-up functions must return either undefined or a function. All other values, including null, are not allowed. @acdlite in #14119

React Test Renderer and Test Utils

Support Hooks in the shallow renderer. (@trueadm in #14567)
Fix wrong state in shouldComponentUpdate in the presence of getDerivedStateFromProps for Shallow Renderer. (@chenesan in #14613)
Add ReactTestRenderer.act() and ReactTestUtils.act() for batching updates so that tests more closely match real behavior. (@threepointone in #14744)

ESLint Plugin: React Hooks

Initial release. (@calebmer in #13968)
Fix reporting after encountering a loop. (@calebmer and @Yurickh in #14661)
Don't consider throwing to be a rule violation. (@sophiebits in #14040)

v16.7.0
Compare Source
React DOM

Fix performance of React.lazy for large numbers of lazily-loaded components. (@acdlite in #14429)
Clear fields on unmount to avoid memory leaks. (@trueadm in #14276)
Fix bug with SSR and context when mixing<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(@gaearon in #14291)
Fix a performance regression in profiling mode. (@bvaughn in #14383)

Scheduler (Experimental)

Post to MessageChannel instead of window. (@acdlite in #14234)
Reduce serialization overhead. (@developit in #14249)
Fix fallback to setTimeout in testing environments. (@bvaughn in #14358)
Add methods for debugging. (@mrkev in #14053)

v16.6.3
Compare Source
React DOM

Fix bugs in Suspense and lazy. (@acdlite in #14133, #14157, and #14164)
Fix highlighting of React.memo updates in React DevTools. (@bvaughn in #14141)
Fix interaction of Suspense with the React Profiler. (@bvaughn in #14065)
Fix a false positive warning when using Suspense. (@acdlite in #14158)

React DOM Server

Fix incorrect sharing of context state between renderToNodeStream() calls. (@sebmarkbage in #14182)
Add a warning about incorrect usage of the context API. (@trueadm in #14033)

v16.6.1
Compare Source
React DOM

Fallback should not remount every time a promise resolves. (@acdlite in #14083)
Fix bug where Suspense keeps showing fallback even after everything finishes loading. (@acdlite in #14083)
Fix a crash when Suspense finishes loading in IE11. (@sophiebits in #14126)
Fix unresolved default props in lifecycle methods of a lazy component. (@gaearon in #14112)
Fix bug when recovering from an error thrown during complete phase. (@gaearon in #14104)

Scheduler (Experimental)

Switch from deadline object to shouldYield API. (@acdlite in #14025)

v16.6.0
Compare Source
React

Add React.memo() as an alternative to PureComponent for functions. (@acdlite in #13748)
Add React.lazy() for code splitting components. (@acdlite in #13885)
React.StrictMode now warns about legacy context API. (@bvaughn in #13760)
React.StrictMode now warns about findDOMNode. (@sebmarkbage in #13841)
Rename unstable_AsyncMode to unstable_ConcurrentMode. (@trueadm in #13732)
Rename unstable_Placeholder to Suspense, and delayMs to maxDuration. (@gaearon in #13799 and @sebmarkbage in #13922)

React DOM

Add contextType as a more ergonomic way to subscribe to context from a class. (@bvaughn in #13728)
Add getDerivedStateFromError lifecycle method for catching errors in a future asynchronous server-side renderer. (@bvaughn in #13746)
Warn when <Context> is used instead of <Context.Consumer>. (@trueadm in #13829)
Fix gray overlay on iOS Safari. (@philipp-spiess in #13778)
Fix a bug caused by overwriting window.event in development. (@sergei-startsev in #13697)

React DOM Server

Add support for React.memo(). (@alexmckenley in #13855)
Add support for contextType. (@alexmckenley and @sebmarkbage in #13889)

Scheduler (Experimental)

Rename the package to scheduler. (@gaearon in #13683)
Support priority levels, continuations, and wrapped callbacks. (@acdlite in #13720 and #13842)
Improve the fallback mechanism in non-DOM environments. (@acdlite in #13740)
Schedule requestAnimationFrame earlier. (@acdlite in #13785)
Fix the DOM detection to be more thorough. (@trueadm in #13731)
Fix bugs with interaction tracing. (@bvaughn in #13590)
Add the envify transform to the package. (@mridgway in #13766)

v16.5.2
Compare Source
React DOM

Fixed a recent <iframe> regression (@JSteunou in #13650)
Fix updateWrapper so that <textarea>s no longer re-render when data is unchanged (@joelbarbosa in #13643)

Schedule (Experimental)

Renaming "tracking" API to "tracing" (@bvaughn in #13641)
Add UMD production+profiling entry points (@bvaughn in #13642)
Refactored schedule to remove some React-isms and improve performance for when deferred updates time out (@acdlite in #13582)

v16.5.1
Compare Source
React

Improve the warning when React.forwardRef receives an unexpected number of arguments. (@andresroberto in #13636)

React DOM

Fix a regression in unstable exports used by React Native Web. (@aweary in #13598)
Fix a crash when component defines a method called isReactComponent. (@gaearon in #13608)
Fix a crash in development mode in IE9 when printing a warning. (@link-alex in #13620)
Provide a better error message when running react-dom/profiling with schedule/tracking. (@bvaughn in #13605)
If a ForwardRef component defines a displayName, use it in warnings. (@probablyup in #13615)

Schedule (Experimental)

Add a separate profiling entry point at schedule/tracking-profiling. (@bvaughn in #13605)

v16.5.0
Compare Source
React

Add a warning if React.forwardRef render function doesn't take exactly two arguments (@bvaughn in #13168)
Improve the error message when passing an element to createElement by mistake (@DCtheTall in #13131)
Don't call profiler onRender until after mutations (@bvaughn in #13572)

React DOM

Add support for React DevTools Profiler (@bvaughn in #13058)
Add react-dom/profiling entry point alias for profiling in production (@bvaughn in #13570)
Add onAuxClick event for browsers that support it (@jquense in #11571)
Add movementX and movementY fields to mouse events (@jasonwilliams in #9018)
Add tangentialPressure and twist fields to pointer events (@motiz88 in #13374)
Minimally support iframes (nested browsing contexts) in selection event handling (@acusti in #12037)
Support passing booleans to the focusable SVG attribute (@gaearon in #13339)
Ignore <noscript> on the client when hydrating (@Ephem in #13537)
Fix gridArea to be treated as a unitless CSS property (@mgol in #13550)
Fix incorrect data in compositionend event when typing Korean on IE11 (@crux153 in #12563)
Fix a crash when using dynamic children in the <option> tag (@Slowyn in #13261, @gaearon in #13465)
Fix the checked attribute not getting initially set on the input (@dilidili in #13114)
Fix hydration of dangerouslySetInnerHTML when __html is not a string (@gaearon in #13353)
Fix a warning about missing controlled onChange to fire on falsy values too (@nicolevy in #12628)
Fix submit and reset buttons getting an empty label (@ellsclytn in #12780)
Fix the onSelect event not being triggered after drag and drop (@gaearon in #13422)
Fix the onClick event not working inside a portal on iOS (@aweary in #11927)
Fix a performance issue when thousands of roots are re-rendered (@gaearon in #13335)
Fix a performance regression that also caused onChange to not fire in some cases (@gaearon in #13423)
Handle errors in more edge cases gracefully (@gaearon in #13237 and @acdlite in #13269)
Don't use proxies for synthetic events in development (@gaearon in #12171)
Warn when "false" or "true" is the value of a boolean DOM prop (@motiz88 in #13372)
Warn when this.state is initialized to props (@veekas in #11658)
Don't compare style on hydration in IE due to noisy false positives (@mgol in #13534)
Include StrictMode in the component stack (@gaearon in #13240)
Don't overwrite window.event in IE (@ConradIrwin in #11696)
Improve component stack for the folder/index.js naming convention (@gaearon in #12059)
Improve a warning when using getDerivedStateFromProps without initialized state (@flxwu in #13317)
Improve a warning about invalid textarea usage (@raunofreiberg in #13361)
Treat invalid Symbol and function values more consistently (@raunofreiberg in #13362 and #13389)
Allow Electron <webview> tag without warnings (@philipp-spiess in #13301)
Don't show the uncaught error addendum if e.preventDefault() was called (@gaearon in #13384)
Warn about rendering Generators (@gaearon in #13312)
Remove irrelevant suggestion of a legacy method from a warning (@zx6658 in #13169)
Remove unstable_deferredUpdates in favor of unstable_scheduleWork from schedule (@gaearon in #13488)
Fix unstable asynchronous mode from doing unnecessary work when an update takes too long (@acdlite in #13503)

React DOM Server

Fix crash with nullish children when using dangerouslySetInnerHtml in a selected <option> (@mridgway in #13078)
Fix crash when setTimeout is missing (@dustinsoftware in #13088)

React Test Renderer and Test Utils

Fix this in a functional component for shallow renderer to be undefined (@koba04 in #13144)
Deprecate a Jest-specific ReactTestUtils.mockComponent() helper (@bvaughn in #13193)
Warn about ReactDOM.createPortal usage within the test renderer (@bvaughn in #12895)
Improve a confusing error message (@gaearon in #13351)

React ART

Add support for DevTools (@yunchancho in #13173)

Schedule (Experimental)

New package for cooperatively scheduling work in a browser environment. It's used by React internally, but its public API is not finalized yet. (@flarnie in #12624)

v16.4.2
Compare Source
React DOM Server

Fix a potential XSS vulnerability when the attacker controls an attribute name (CVE-2018-6341). This fix is available in the latest<EMAIL_ADDRESS>as well as in previous affected minor versions<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>(@gaearon in #13302)

Fix a crash in the server renderer when an attribute is called hasOwnProperty. This fix is only available in<EMAIL_ADDRESS>(@gaearon in #13303)

v16.4.1
Compare Source
React

You can now assign propTypes to components returned by React.ForwardRef. (@bvaughn in #12911)

React DOM

Fix a crash when the input type changes from some other types to text. (@spirosikmd in #12135)
Fix a crash in IE11 when restoring focus to an SVG element. (@ThaddeusJiang in #12996)
Fix a range input not updating in some cases. (@Illu in #12939)
Fix input validation triggering unnecessarily in Firefox. (@nhunzaker in #12925)
Fix an incorrect event.target value for the onChange event in IE9. (@nhunzaker in #12976)
Fix a false positive error when returning an empty <React.Fragment /> from a component. (@philipp-spiess in #12966)

React DOM Server

Fix an incorrect value being provided by new context API. (@ericsoderberghp in #12985, @gaearon in #13019)

React Test Renderer

Allow multiple root children in test renderer traversal API. (@gaearon in #13017)
Fix getDerivedStateFromProps() in the shallow renderer to not discard the pending state. (@fatfisz in #13030)

v16.4.0
Compare Source
React

Add a new experimental React.unstable_Profiler component for measuring performance. (@bvaughn in #12745)

React DOM

Add support for the Pointer Events specification. (@philipp-spiess in #12507)
Properly call getDerivedStateFromProps() regardless of the reason for re-rendering. (@acdlite in #12600 and #12802)
Fix a bug that prevented context propagation in some cases. (@gaearon in #12708)
Fix re-rendering of components using forwardRef() on a deeper setState(). (@gaearon in #12690)
Fix some attributes incorrectly getting removed from custom element nodes. (@airamrguez in #12702)
Fix context providers to not bail out on children if there's a legacy context provider above. (@gaearon in #12586)
Add the ability to specify propTypes on a context provider component. (@nicolevy in #12658)
Fix a false positive warning when using react-lifecycles-compat in <StrictMode>. (@bvaughn in #12644)
Warn when the forwardRef() render function has propTypes or defaultProps. (@bvaughn in #12644)
Improve how forwardRef() and context consumers are displayed in the component stack. (@sophiebits in #12777)
Change internal event names. This can break third-party packages that rely on React internals in unsupported ways. (@philipp-spiess in #12629)

React Test Renderer

Fix the getDerivedStateFromProps() support to match the new React DOM behavior. (@koba04 in #12676)
Fix a testInstance.parent crash when the parent is a fragment or another special node. (@gaearon in #12813)
forwardRef() components are now discoverable by the test renderer traversal methods. (@gaearon in #12725)
Shallow renderer now ignores setState() updaters that return null or undefined. (@koba04 in #12756)

React ART

Fix reading context provided from the tree managed by React DOM. (@acdlite in #12779)

React Call Return (Experimental)

This experiment was deleted because it was affecting the bundle size and the API wasn't good enough. It's likely to come back in the future in some other form. (@gaearon in #12820)

React Reconciler (Experimental)

The new host config shape is flat and doesn't use nested objects. (@gaearon in #12792)

v16.3.2
Compare Source
React

Improve the error message when passing null or undefined to React.cloneElement. (@nicolevy in #12534)

React DOM

Fix an IE crash in development when using <StrictMode>. (@bvaughn in #12546)
Fix labels in User Timing measurements for new component types. (@bvaughn in #12609)
Improve the warning about wrong component type casing. (@nicolevy in #12533)
Improve general performance in development mode. (@gaearon in #12537)
Improve performance of the experimental unstable_observedBits API with nesting. (@gaearon in #12543)

React Test Renderer

Add a UMD build. (@bvaughn in #12594)

v16.3.1
Compare Source
React

Fix a false positive warning in IE11 when using Fragment. (@heikkilamarko in #12504)
Prefix a private API. (@Andarist in #12501)
Improve the warning when calling setState() in constructor. (@gaearon in #12532)

React DOM

Fix getDerivedStateFromProps() not getting applied in some cases. (@acdlite in #12528)
Fix a performance regression in development mode. (@gaearon in #12510)
Fix error handling bugs in development mode. (@gaearon and @acdlite in #12508)
Improve user timing API messages for profiling. (@flarnie in #12384)

Create Subscription

Set the package version to be in sync with React releases. (@bvaughn in #12526)
Add a peer dependency on React 16.3+. (@NMinhNguyen in #12496)

v16.3.0
Compare Source
React

Add a new officially supported context API. (@acdlite in #11818)
Add a new React.createRef() API as an ergonomic alternative to callback refs. (@trueadm in #12162)
Add a new React.forwardRef() API to let components forward their refs to a child. (@bvaughn in #12346)
Fix a false positive warning in IE11 when using React.Fragment. (@XaveScor in #11823)
Replace React.unstable_AsyncComponent with React.unstable_AsyncMode. (@acdlite in #12117)
Improve the error message when calling setState() on an unmounted component. (@sophiebits in #12347)

React DOM

Add a new getDerivedStateFromProps() lifecycle and UNSAFE_ aliases for the legacy lifecycles. (@bvaughn in #12028)
Add a new getSnapshotBeforeUpdate() lifecycle. (@bvaughn in #12404)
Add a new <React.StrictMode> wrapper to help prepare apps for async rendering. (@bvaughn in #12083)
Add support for onLoad and onError events on the <link> tag. (@roderickhsiao in #11825)
Add support for noModule boolean attribute on the <script> tag. (@aweary in #11900)
Fix minor DOM input bugs in IE and Safari. (@nhunzaker in #11534)
Correctly detect Ctrl + Enter in onKeyPress in more browsers. (@nstraub in #10514)
Fix containing elements getting focused on SSR markup mismatch. (@koba04 in #11737)
Fix value and defaultValue to ignore Symbol values. (@nhunzaker in #11741)
Fix refs to class components not getting cleaned up when the attribute is removed. (@bvaughn in #12178)
Fix an IE/Edge issue when rendering inputs into a different window. (@M-ZubairAhmed in #11870)
Throw with a meaningful message if the component runs after jsdom has been destroyed. (@gaearon in #11677)
Don't crash if there is a global variable called opera with a null value. @alisherdavronov in #11854)
Don't check for old versions of Opera. (@skiritsis in #11921)
Deduplicate warning messages about <option selected>. (@watadarkstar in #11821)
Deduplicate warning messages about invalid callback. (@yenshih in #11833)
Deprecate ReactDOM.unstable_createPortal() in favor of ReactDOM.createPortal(). (@prometheansacrifice in #11747)
Don't emit User Timing entries for context types. (@abhaynikam in #12250)
Improve the error message when context consumer child isn't a function. (@raunofreiberg in #12267)
Improve the error message when adding a ref to a functional component. (@skiritsis in #11782)

React DOM Server

Prevent an infinite loop when attempting to render portals with SSR. (@gaearon in #11709)
Warn if a class doesn't extend React.Component. (@wyze in #11993)
Fix an issue with this.state of different components getting mixed up. (@sophiebits in #12323)
Provide a better message when component type is undefined. (@HeroProtagonist in #11966)

React Test Renderer

Fix handling of fragments in toTree(). (@maciej-ka in #12107 and @gaearon in #12154)
Shallow renderer should assign state to null for components that don't set it. (@jwbay in #11965)
Shallow renderer should filter legacy context according to contextTypes. (@koba04 in #11922)
Add an unstable API for testing asynchronous rendering. (@acdlite in #12478)

React Is (New)

First release of the new package that libraries can use to detect different React node types. (@bvaughn in #12199)
Add ReactIs.isValidElementType() to help higher-order components validate their inputs. (@jamesreggio in #12483)

React Lifecycles Compat (New)

First release of the new package to help library developers target multiple versions of React. (@bvaughn in #12105)

Create Subscription (New)

First release of the new package to subscribe to external data sources safely for async rendering. (@bvaughn in #12325)

React Reconciler (Experimental)

Expose react-reconciler/persistent for building renderers that use persistent data structures. (@gaearon in #12156)
Pass host context to finalizeInitialChildren(). (@jquense in #11970)
Remove

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Enabled.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 2.153.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove moot version property from bower.json

Per bower/bower.json-spec@a325da3

Refer to https://github.com/HubSpot/tether/pull/92

Also their maintainer says they probably won't ever use it: http://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property


Usage of SVE pack with vector

While trying the following code:
#include <nsimd/nsimd-all.hpp>
#include <vector>

int main()
{
    std::vector<nsimd::pack<float> > vect;

    return 0;
}

I run into a compilation error:
gupta2@juawei-a27:~/codes/test_codes$ armclang++ -DNSIMD_SVE -march=armv8-a+sve -ftree-vectorize -I$HOME/install/arm/nsimd/include -L/$HOME/install/arm/nsimd/lib sve.cpp
In file included from sve.cpp:2:
In file included from /opt/ohpc/pub/ARM/opt/arm/gcc-8.2.0_Generic-AArch64_RHEL-7_aarch64-linux/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../include/c++/8.2.0/vector:64:
/opt/ohpc/pub/ARM/opt/arm/gcc-8.2.0_Generic-AArch64_RHEL-7_aarch64-linux/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../include/c++/8.2.0/bits/stl_vector.h:286:35: error: arithmetic on a pointer to an incomplete type
      'nsimd::pack<float, 1, nsimd::sve>'
                      _M_impl._M_end_of_storage - _M_impl._M_start);
                      ~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/opt/ohpc/pub/ARM/opt/arm/gcc-8.2.0_Generic-AArch64_RHEL-7_aarch64-linux/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../include/c++/8.2.0/bits/stl_vector.h:391:7: note: in instantiation of member function 'std::_Vector_base<nsimd::pack<float,
      1, nsimd::sve>, std::allocator<nsimd::pack<float, 1, nsimd::sve> > >::~_Vector_base' requested here
      vector()
      ^
sve.cpp:6:38: note: in instantiation of member function 'std::vector<nsimd::pack<float, 1, nsimd::sve>, std::allocator<nsimd::pack<float, 1, nsimd::sve> > >::vector' requested here
    std::vector<nsimd::pack<float> > vect;
                                     ^
In file included from sve.cpp:2:
In file included from /opt/ohpc/pub/ARM/opt/arm/gcc-8.2.0_Generic-AArch64_RHEL-7_aarch64-linux/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../include/c++/8.2.0/vector:62:
/opt/ohpc/pub/ARM/opt/arm/gcc-8.2.0_Generic-AArch64_RHEL-7_aarch64-linux/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../include/c++/8.2.0/bits/stl_construct.h:136:25: error: incomplete type '_Value_type'
      (aka 'nsimd::pack<float, 1, nsimd::sve>') used in type trait expression
      std::_Destroy_aux<__has_trivial_destructor(_Value_type)>::
                        ^
/opt/ohpc/pub/ARM/opt/arm/gcc-8.2.0_Generic-AArch64_RHEL-7_aarch64-linux/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../include/c++/8.2.0/bits/stl_construct.h:206:7: note: in instantiation of function template specialization
      'std::_Destroy<nsimd::pack<float, 1, nsimd::sve> *>' requested here
      _Destroy(__first, __last);
      ^
/opt/ohpc/pub/ARM/opt/arm/gcc-8.2.0_Generic-AArch64_RHEL-7_aarch64-linux/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../include/c++/8.2.0/bits/stl_vector.h:567:7: note: in instantiation of function template specialization
      'std::_Destroy<nsimd::pack<float, 1, nsimd::sve> *, nsimd::pack<float, 1, nsimd::sve> >' requested here
        std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish,
             ^
sve.cpp:6:38: note: in instantiation of member function 'std::vector<nsimd::pack<float, 1, nsimd::sve>, std::allocator<nsimd::pack<float, 1, nsimd::sve> > >::~vector' requested here
    std::vector<nsimd::pack<float> > vect;
                                     ^
2 errors generated.

How do I work with SVE vector packs?

Hi NK-Nikunj,
This is the expected behavior with ARM's compiler. As explained in ARM's documentation, SVE types have no size at compile time. Therefore you cannot have such types as a member of structs or classes. ARM introduced a new kind of struct called __sizeless_struct which is able to have SVE types as members but which has the same limitations as SVE types: they cannot be members of standard structs or classes. Note that when compiling for SVE with ARM's compiler you are compiling a superset of C++ which adds __sizeless_struct with its limitations. NSIMD's pack is a __sizeless_struct for SVE and therefore cannot be member of any struct or class and therefore cannot be used with STL containers (std::vector, std::map, std::tuple...).
The situation is different with GCC 10 (trunk when writing this). GCC uses another approach: it is mandatory to specifiy on command line SVE size with the -msve-vector-bits switch. This makes SVE type have a size and behave like standard SIMD types. You can therefore use them in standard structs or classes and in any STL container. Thus your snippet of code should compile fine with GCC 10.
I advice you not to use SIMD vectors in this manner for several reasons:

As explained above this makes your code non-portable. Even if it compiles, the occupation in memory would vary from one system to another.
It forces you to have a number of floats multiple of 4, 8...
You should seperate concerns, namely data storage and optimizations: you should use a std::vector<float> everywhere and use nsimd::pack's only in computations kernels.
You won't be able to write generic code as SIMD vectors of floats are not floats, for exemple you won't be able to write if (vec1[i] < vec2[i]) {...

You should seperate concerns, namely data storage and optimizations: you should use a std::vector everywhere and use nsimd::pack's only in computations kernels.

@gquintin will it not be inefficient if I start loading std::vector<float> to nsimd::pack<float> in my computational kernel?

The loading of data is necessary in both situations. For any T an std::vector<T> lives in RAM, there is no exception if T == __m128 or T == __m256. The loading of data takes place in the overloading of operator[] of std::vector.
#include <immintrin.h>
#include <vector>

void add_m128(std::vector<__m128> &dst,
              std::vector<__m128> const &a,
              std::vector<__m128> const &b,
              int n) {
    for (int i = 0; i < n; i += 4) {
        dst[i] = a[i] + b[i];
    }
}

void add_float(std::vector<float> &dst,
               std::vector<float> const &a,
               std::vector<float> const &b, int n) {
    float *pdst = dst.data();
    const float *pa = a.data();
    const float *pb = b.data();
    for (int i = 0; i < n; i += 4) {
        _mm_store_ps(&pdst[i], _mm_load_ps(&pa[i]) +
                               _mm_load_ps(&pb[i]));
    }
}

The assembly for both loops is exactly the same. For add_m128:
.L3:
        movaps  xmm0, XMMWORD PTR [r9+rax]
        addps   xmm0, XMMWORD PTR [r8+rax]
        movaps  XMMWORD PTR [rsi+rax], xmm0
        add     rax, 64
        cmp     rdx, rax
        jne     .L3

For add_float:
.L8:
        movaps  xmm0, XMMWORD PTR [rsi+rax*4]
        addps   xmm0, XMMWORD PTR [rdi+rax*4]
        movaps  XMMWORD PTR [rdx+rax*4], xmm0
        add     rax, 4
        cmp     ecx, eax
        jg      .L8

In both cases you will have two loads and on stores from/to memory. Moreover as you can see in my code I never use C++ constructs in performance critical code as the compiler does not knwo how to properly optimize code. As an exemple consider the following:
void add_float_cxx(std::vector<float> &dst,
                   std::vector<float> const &a,
                   std::vector<float> const &b, int n) {
    for (int i = 0; i < n; i += 4) {
        _mm_store_ps(&dst[i], _mm_load_ps(&a[i]) +
                              _mm_load_ps(&b[i]));
    }
}

which produces the following assembly:
.L12:
        mov     r10, QWORD PTR [rsi]
        mov     r9, QWORD PTR [rdx]
        mov     r8, QWORD PTR [rdi]
        movaps  xmm0, XMMWORD PTR [r10+rax]
        addps   xmm0, XMMWORD PTR [r9+rax]
        movaps  XMMWORD PTR [r8+rax], xmm0
        add     rax, 16
        cmp     rcx, rax
        jne     .L12

which is way worse than the ones above. So as a conclusion: in performance critical kernels do not write C++ write only C.


fix(athena): Athena query vars missing terminated quotes

Issue #, if available:
https://github.com/aws-samples/aws-cudos-framework-deployment/issues/155
Description of changes:
Add terminated quotes to query strings for boto3.athena
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Folks - we're talking about 2 lines of code. Can someone review this please?


Add Mac: CMAC ("AES/CMAC")

Based on BouncyCastle sources, using the test vectors from the AES-CMAC RFC:
https://tools.ietf.org/html/rfc4493
Those test vectors are binary plaintext, so I refactored _runMacTest to use accept UInt8List.
I'm not strong in Java, Dart, or crypto, please review accordingly.

This PR requires #175 (ISO7816-4 padding) to be merged first.

I don't know why there is a separate CBCBlockCipherMac and CMac class in BouncyCastle, with very similar (but slightly different) implementations. I'm porting the other one as well, and I will add it to this PR in the same manner that BouncyCastle has it (that is, two nearly identical algorithms in the same macs folder).
I'll note that that my goal is to get AES-CCM working (by porting BouncyCastle's CCMBlockCipher.java), and that one uses the CBCBlockCipherMac. Other than that, I'm not sure which one is best, or just to ship them both?

Sorry for the late review. I was hoping someone who actually uses this library could perhaps review this..
It looks quite good, even though I didn't verify the validity of the test vectors.
I found one nit, once addressed, I can merge this.

Thanks for the contribution!


Controller notes

Variable names should be clearer and follow camelCase:

o client.Object should just be called object
persistentvolumeClaim should be called 'pvcorpersistentVolumeClaim`
The comment needs to be avoid personalized wording (I will), use this instead:

	// pvName is determined this way: nfspvc.Name + "-" + nfspvc.Namespace,
	// so in order to find out the name of the related nfspvc and namespace,
        // split the name of the pv by '-'

Add a comment above the function

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L360-L384

Same comments as above apply here too:

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L330-L358

For better readability move the SetupWithManager to be above the Reconciler and move all the functions like deleteAssociatedResources, HandleDeletion, etc... to be below the Reconciler.

// NfsPvcReconciler reconciles a NfsPvc object
type NfsPvcReconciler struct {
	client.Client
	Scheme *runtime.Scheme
	Log    logr.Logger
}

const (
	NfsPvcFinalizerName     = "nfspvc.dana.io/finalizer"
	pvcBindStatusAnnotation = "pv.kubernetes.io/bind-completed"
)

//+kubebuilder:rbac:groups="",resources=persistentvolumes,verbs=get;list;watch;create;update;delete
//+kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=get;list;watch;create;update;delete
//+kubebuilder:rbac:groups=dana.io.dana.io,resources=nfspvcs,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups=dana.io.dana.io,resources=nfspvcs/status,verbs=get;update;patch
//+kubebuilder:rbac:groups=dana.io.dana.io,resources=nfspvcs/finalizers,verbs=update

// SetupWithManager sets up the controller with the Manager.
func (r *NfsPvcReconciler) SetupWithManager(mgr ctrl.Manager) error {
	return ctrl.NewControllerManagedBy(mgr).
		For(&danaiov1.NfsPvc{}).
		Watches(&corev1.PersistentVolume{}, handler.EnqueueRequestsFromMapFunc(r.enqueueRequestsFromPersistentVolume)).
		Watches(&corev1.PersistentVolumeClaim{}, handler.EnqueueRequestsFromMapFunc(r.enqueueRequestsFromPersistentVolumeClaim)).
		Complete(r)
}

func (r *NfsPvcReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
	logger := r.Log
	var nfspvcFetched bool
	// Fetch the NfsPvc instance
	nfspvc := &danaiov1.NfsPvc{}
	err := r.Get(ctx, req.NamespacedName, nfspvc)

Why not use a logger from context?

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L193

Not sure I've seen this implementation anywhere, why is this needed? Can't you just move the defer block to be after the error handling of the Get and avoid this syntax?

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L194-L202

Move the defer to an external function instead of using an anonymous function

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L203-L211

This is a redundant comment since you chose to log it and this just reads like uncleaned boilerplate

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L217

There is no reason for this function to be exported. Also it has no comment above it and the comments inside it are positioned a bit strangely. Again, if you can then avoid personalized language in comments

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L85-L102

Create 2 new functions, one that deletes PV and one that deletes PVC and just call them from this function. And add a comment.

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L55-L83

There is no reason for this function to be exported.

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L104-L119

There is no reason for this function to be exported. Also change the comments here. In general I don't think I really like the separation to handleDelete, handleCreate and handleUpdate. I don't really like the way we check if an update to the pvcnfs object happens, which is by checking another object. Maybe we can do something in the status of the nfspvc object?

There is an unhandled error here.

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L121-L151

This entire thing needs to be broken down to different functions.  There are also unhandled errors:

https://github.com/dana-team/nfs-operator/blob/2404fdabcf5e1038274082a062a7c3d4ca9bdd44/internal/controller/nfspvc_controller.go#L255-L328

Some comments about the code refactor branch (@omer5yerushalmi):

Fix the comment above the function here:

https://github.com/dana-team/nfs-operator/blob/92c564cbc02ab876e630eb89230859d0171beb6c/internal/controller/nfspvc_controller.go#L116-L144

I don't really understand this function here. The deletion of the PVC and PV is done twice:

https://github.com/dana-team/nfs-operator/blob/92c564cbc02ab876e630eb89230859d0171beb6c/internal/controller/utils/finalizer/finalizer.go#L27-L65

Not really urgent, but I think ReclaimPolicy should be a given as a flag to the controller so that it can be controlled without changing the code (default to retain). Same goes for storageClass name (brown).

https://github.com/dana-team/nfs-operator/blob/92c564cbc02ab876e630eb89230859d0171beb6c/internal/controller/utils/sync/nfspvc.go#L166

Fix the descriptions of the functions and remove redundant spaces.


Handle return exception with array data

Throw an exception if payment fails in order to return data array with success => false and message => "reason fail"

Fixed #14


Remove badges from README

I'm sorry, but I've decided to shutdown the badges.ml service, which means your badges now look like this:

You can read more information about it here
Sorry again, have a great day :+1:

@bokub Thanks for the advice. I loved your project. Have a nice day!


Reference correct value to decide whether to set memory request

Closes #1030

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


I tried Pretrained alexnet model. But I can not.

I tried to run:
./alexnet-dorefa.py --load alexnet-126.npy --run a.jpg --dorefa 1,2,6
but taceback occured.
Traceback (most recent call last):
File "./alexnet-dorefa.py", line 305, in
run_image(Model(), ParamRestore(np.load(args.load, encoding='latin1').item()), args.run)
File "./alexnet-dorefa.py", line 256, in run_image
meta = dataset.ILSVRCMeta()
File "/home/sounansu/work/tensorflow/tensorpack/tensorpack/dataflow/dataset/ilsvrc.py", line 34, in init
self.caffepb = get_caffe_pb()
File "/home/sounansu/work/tensorflow/tensorpack/tensorpack/utils/loadcaffe.py", line 83, in get_caffe_pb
proto_path = download(CAFFE_PROTO_URL, dir)
File "/home/sounansu/work/tensorflow/tensorpack/tensorpack/utils/fs.py", line 39, in download
logger.error("Failed to download {}".format(url))
NameError: global name 'logger' is not defined
Please advice!

Fixed a missing import line in 2387c6222
Also, the error indicates that you cannot download from https://github.com/BVLC/caffe/raw/master/src/caffe/proto/caffe.proto, so you may need to check your network as well.

Thank you.
Line 305 trace back are not occurred.
YES,YES.
I have another problem not tensorpack problem.
My network environment are under proxy network.
So, I set environment variables for proxy ,
http_proxy=http://pxoxyurl:8080/
https_proxy=https://pxoxyurl:8080/
HTTPS_PROXY=https://pxoxyurl:8080/
HTTP_PROXY=http://pxoxyurl:8080/
But, python or tensorflow can not understand these variables.....

$ ./alexnet-dorefa.py --load alexnet-126.npy --run a.jpg --dorefa 1,2,6
.
.
.
[0913 10:27:26 @fs.py:40] ERR Failed to download https://github.com/BVLC/caffe/raw/master/src/caffe/proto/caffe.proto
Traceback (most recent call last):
File "./alexnet-dorefa.py", line 303, in
run_image(Model(), ParamRestore(np.load(args.load, encoding='latin1').item()), args.run)
File "./alexnet-dorefa.py", line 255, in run_image
meta = dataset.ILSVRCMeta()
File "/home/sounansu/tensorpack/tensorpack/dataflow/dataset/ilsvrc.py", line 34, in init
self.caffepb = get_caffe_pb()
File "/home/sounansu/tensorpack/tensorpack/utils/loadcaffe.py", line 83, in get_caffe_pb
proto_path = download(CAFFE_PROTO_URL, dir)
File "/home/sounansu/tensorpack/tensorpack/utils/fs.py", line 36, in download
fpath, _ = urllib.request.urlretrieve(url, fpath, reporthook=_progress)
File "/usr/lib/python2.7/urllib.py", line 94, in urlretrieve
return _urlopener.retrieve(url, filename, reporthook, data)
File "/usr/lib/python2.7/urllib.py", line 240, in retrieve
fp = self.open(url, data)
File "/usr/lib/python2.7/urllib.py", line 208, in open
return getattr(self, name)(url)
File "/usr/lib/python2.7/urllib.py", line 437, in open_https
h.endheaders(data)
File "/usr/lib/python2.7/httplib.py", line 975, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 835, in _send_output
self.send(msg)
File "/usr/lib/python2.7/httplib.py", line 797, in send
self.connect()
File "/usr/lib/python2.7/httplib.py", line 1182, in connect
self.sock = ssl.wrap_socket(sock, self.key_file, self.cert_file)
File "/usr/lib/python2.7/ssl.py", line 487, in wrap_socket
ciphers=ciphers)
File "/usr/lib/python2.7/ssl.py", line 243, in init
self.do_handshake()
File "/usr/lib/python2.7/ssl.py", line 405, in do_handshake
self._sslobj.do_handshake()
IOError: [Errno socket error] [Errno 8] _ssl.c:510: EOF occurred in violation of protocol

That's a python issue, and I don't think it's related to proxy.
urllib in python definitely supports http_proxy environment variables. But it looks like there is something wrong with SSL. Googling the error would give you something you can try.

I try to search urllib issue.
But current state are not good.....
(I understand, i can access not secure url, but can not access secure url,,,)
Thank you for your advises.
I continue to try.....


[PLT-7773] Hide channel and team URLs from the sidebar in the desktop app

Summary
Hide channel and team URLs from the sidebar in the desktop app
@asaadmahmood Can I have a hand to fix CSS styling issues for desktop button? Thanks!
Ticket Link
Jira ticket: PLT-7773
Checklist

[x] Has UI changes

Thanks @asaadmahmood!
PR updated which adds track event when button is clicked.


[mysql] Use local timezone as the default server timezone

Due to the issue mentioned in https://github.com/ververica/flink-cdc-connectors/issues/1406, Flink CDC Connectors might treat Timestamp fields with different behaviors during snapshot and streaming phases.
Here I propose changing the default value of server-time-zone to local timezone so that most users would not need to manually set timezone to get the correct results.

Spotless failed. It seems you should run mvn spotless:apply and push the diff :)

OracleE2eITCase.testOracleCDC failed, but it seems unrelated to the changes made.

OracleE2eITCase.testOracleCDC failed, but it seems unrelated to the changes made.

@kylemeow Thanks for the contribution, I've fixed the test, could you rebase master and try again?


add SAIC update Redis

add new member SAIC and update Redis logo

No city for a crunchbase entry for saic-foundation-ltd at https://www.crunchbase.com/organization/saic-foundation-ltd

Thanks. Added after I saw the initial fail. Assuming it just takes time to populate?

Yes. You can trigger a new build with an empty commit, or by adding a
return at the end of the yml file.
Dan Kohn<EMAIL_ADDRESS>Executive Director, Cloud Native Computing Foundation https://www.cncf.io
+1-415-233-1000 https://www.dankohn.com
On Tue, Jul 23, 2019 at 6:31 PM Brett Preston<EMAIL_ADDRESS>wrote:

Thanks. Added after I saw the initial fail. Assuming it just takes time to
populate?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lf-edge/lfedge-landscape/pull/47?email_source=notifications&email_token=AAXQYBWF5OTORTOQY64Z6XDQA6BDZA5CNFSM4IGKHDOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2UTZYI#issuecomment-514407649,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXQYBW52S47PZU6LUFL7WDQA6BDZANCNFSM4IGKHDOA
.


Flags to specify the PIN and touch policy when CSR is created

When a CSR is created the PIN and touch policies are fixed, so we need to add flags so we can tweak those for certain developers.

Resolved in release v0.6.0


base_column_profilers.py has a variable, property, which shadows a built-in

General Information:

Python version: 3.8.7
Library version: 0.3.4

Describe the bug:
function _filter_properties_w_options uses a variable called property which shadows the built-in python property

also in method: _perform_property_calcs

being resolved in https://github.com/capitalone/DataProfiler/pull/67


Add Logout button to navigation bar

We don't have logout feature yet. So make a button on navbar to logout from the page here:
https://crypto.realdevsquad.com/

Assign

as


Very unexpected omission: uint?.Should().Be() fails

            uint? u = 5;
            u.Should().Be(5);

Result: Expected object to be 5, but found 5.
It works fine for uint (not nullable) and int (both nullable and not nullable)
Used version: <IP_ADDRESS>

Thanks for reporting this. Unfortunately, version 3.x is no longer supported. Is there a chance you can reproduce it with the current versions?

Just tried with 4.10. Same result.

Thanks for trying that. It's most definitely a bug.

After a bit of an investigation, I realized that FA doesn't properly support unsigned numeric types yet. It's going to be more than a simple fix to support that.


RV Templating: Conditionally show text based on string contents?

Hi there,
Firstly, just wanted to say thanks so much for putting this great library together and I'm really looking forward to future roll-outs of docs and enhancements!
Here's a question for you:
Essentially, I've broken out how I display product title and it's variants in the cart for UX purposes and would like to not show variants that contain 'Default Title', while testing for variants that contain 'Giftwrap' to show specific messaging…if that makes sense.
Regarding the giftwrap logic, this code block is absolutely bloated:

  Giftwrap added

  Giftwrap added

And, conversely, I'm at an impasse with not showing a variant if it equates to 'Default Title' because I haven't been able to find any evaluators that work in Rivets to test for "does not equal" or that simply state 'else'.
For example, you'd think this would work:

All that said, I know Rivets.js discourages evaluating logic inside the binding declarations, so I'm curious if there's a better way to go about these 2 tests further upstream. If so, do you have some pointers on how?
I get by, but I'm no javascript ninja, so thanks so much for you help!
L

Hi @lindseybradford - I've just submitted a pull request that may address your issue - I don't have write access to this repo, but let me know if this solves it once the PR is merged.

You're able to chain rivets formatters, and there's a not filter, so you can do something like rv-show="item.variant_options.1 | not | eq 'Wrap'". For this specific use case, however, you might be better using rv-hide rather than rv-show (I actually use rv-if and rv-unless, the difference being that the latter two actually add/remove the element from the DOM entirely, rather than just hiding or showing it).
What does seem like it might be useful for your use case here is an includes? filter that checks for array membership, so that you could do this:

  Giftwrap added

If that sounds like a handy addition, let me know and I'll see about getting it added.

Hi Gavin,
Thanks so much for the guidance! Sorry for the delayed response on my part. I think something like the includes formatter would be super helpful for sure. Let me know if/when that's pushed!
Thanks again so much!
L

Well, thanks to @michaelrshannon's fast work, there's now an includes formatter in the just-released v0.3.9 :).


I installed the COPAY WALET APP on my iPhone in december 2017.
Back then I didn´t have problems to send or receive BTC or any currency.
I activated the "touch ID security" ( for login & spending )
I never looked at the "12 word recovery phrases",
since I could do that at anytime later, ...

THE FACT THAT IT´S ACTIVATED PREVENTS ME FROM BEING ABLE :

TO SEND MY BTC
TO LOOK AT THE "12 WORDS BACKUP PHRASE"

WTF !

IS THERE A WAY TO DOWNGRADE TO AN OLDER VERSION OF COPAY WALLET ?
( IN ORDER TO GET RID OF BEING ASKED FOR A PASSWORD THAT I NEVER SET ? )
WHY CAN´T I JUST ACTIVATE GOOGLE AUTHENTICATOR FOR COPAY ?
TO GET AROUND ...

I know your pain. The password protection is forced on yet it says I have to backup my phrase first before I can enable it. No password means I cant back it up.

The App now prevents to receive bitcoin until backup is completed. If you have an old wallet with funds (and also have the words to restore), try to remove it and restore again with your words and remember to set a spending password at import time.

I COULD USE THE COPAY APP WITHOUT ANY PROBLEM : B E F O R E  ? ? ?
( I could send and receive without any password popup. )

WHY CAN A SOFTWARE CHANGE AND STEAL MY MONEY ? ? ?

PROGRAMMING IS ABOUT LOGIC THINKING.
WHY CAN´T  PROGRAMMERS THINK LOGICAL BEFORE THEY   " T E S T "     THEIR
FUNCTIONS OR APPS IN REAL LIFE SITUATIONS ? ? ?

I HAVE EVIDENTLY BEEN TECNICALLY ENTRAPPED.
THE COPAY APP IS EVIDENTLY TRASH RIGHT NOW.

2018-04-06 15:33 GMT+02:00 Gustavo Maximiliano Cortez <
<EMAIL_ADDRESS>
The App now prevents to receive bitcoin until backup is completed. If you
have an old wallet with funds (and also have the words to restore), try to
remove it and restore again with your words and remember to set a spending
password at import time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bitpay/copay/issues/8267#issuecomment-379254510, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHlQZ9GWcGQGc0Jrh9ti3dAfeOmlSUhoks5tl26ngaJpZM4Swauv
.

I EXPECT THE " SPENDING PASSWORD FUNCTION " POPUP TO BE BE REMOVED
AND BE REPLACED WITH THE FAMOUS
" GOOGLE AUTHENTFICATOR "
AMEN
2018-04-06 18:35 GMT+02:00 J. St<EMAIL_ADDRESS>
A) I NEVER MADE A BACKUP       –––– >   SO I DONT HAVE MY 12 WORD PHRASE
B) I NEVER SET A SPENDING PASSWORD NEITHER  –––– >   CAUSE THAT STUPID
"OLD SCOOL LEGACY" FUNCTION HAS BEEN INTEGRATED " L A T E R "
C) I NEVER WAS ASKED TO SET A SPENDING PASSWORD

SO WHY AM I ASKED TO ENTER SPENDING PASSWORD   " N O W - S U D D E N L Y
"  A F T E R  3   M O N T H ? ? ?
I COULD USE THE COPAY APP WITHOUT ANY PROBLEM : B E F O R E  ? ? ?
( I could send and receive without any password popup. )

WHY CAN A SOFTWARE CHANGE AND STEAL MY MONEY ? ? ?

PROGRAMMING IS ABOUT LOGIC THINKING.
WHY CAN´T  PROGRAMMERS THINK LOGICAL BEFORE THEY   " T E S T "     THEIR
FUNCTIONS OR APPS IN REAL LIFE SITUATIONS ? ? ?

I HAVE EVIDENTLY BEEN TECNICALLY ENTRAPPED.
THE COPAY APP IS EVIDENTLY TRASH RIGHT NOW.

2018-04-06 15:33 GMT+02:00 Gustavo Maximiliano Cortez <
<EMAIL_ADDRESS>
The App now prevents to receive bitcoin until backup is completed. If you
have an old wallet with funds (and also have the words to restore), try to
remove it and restore again with your words and remember to set a spending
password at import time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bitpay/copay/issues/8267#issuecomment-379254510, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHlQZ9GWcGQGc0Jrh9ti3dAfeOmlSUhoks5tl26ngaJpZM4Swauv
.

I can recover your wallet if you want need help  send me email<EMAIL_ADDRESS>

I can recover your wallet if you want need help send me email<EMAIL_ADDRESS>
I guess it´s not worth your time since there is only a small amount of BTC (atm worth 25 EUR) left on the wallet.

@Belkodon
no problem, send me details, i can still do first stage of recovery on it

How would that wallet recovery work, since I don´t have the private key... ?

Obviously I have the Copay-Wallet installed.
I can start the app and then I can try to access the BTC.


Updated Readme.md - include pod install note post-link

Updated automatic linking which requires extra step in case of IOS, helps fix #353
Description
Fixed issue #353
Compatibility

OS
Implemented

iOS
✅

Checklist

[ ] I have tested this on a device/simulator for each compatible OS
[ ✅ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typings files (deviceinfo.d.ts, deviceinfo.js.flow)
[ ] I updated the dummy web/test polyfill (default/index.js)
[ ] I added a sample use of the API (example/App.js)

Excellent - I'm sure that will help people in the future


Fix loop over array to use for-of instead of for-in

I can't find any tests that this changes, but listFiles returns an array and fs.addFile expects a path, not an array index. Why is this not getting caught by our tests?
Also, @weswigham: I've been thinking we could add a lint rule where the object of a for-in loop would have to be of the Map type. What do you think?

:+1:

:+1:

@andy-ms Re: Lint rule: Seems a bit strong. I'd rather just forbid using a for-in loop where the thing being iterated over is of type string[] (thereby not triggering any syntax errors through misuse).


Cannot run tiny-yolo-V4 on AOK-D

Describe the bug
After following this Colab notebook, I get the .blob, .mapping, .bin and .xml of the trained tiny-yolo-v4 which I download locally. After cloning the repo I placed the .blob in the folder depthai/resources/nn/tiny-yolo-v3 and named it tiny-yolo-v3.blob.sh14cmx14NCE1, but before I had to remove the original tiny-yolo-v3 blob model. I kept the tiny-yolo-v3.json unchanged.
In the end I run the code:

python depthai_demo.py -cnn tiny-yolo-v3

This is the corresponding log:
(aok) luis@luis-P2440UQ:~/Projs_Software/INESC_projects/AOK/depthai$ python depthai_demo.py -cnn tiny-yolo-v3
No calibration file. Using Calibration Defaults.
Using depthai module from:  /home/luis/.local/lib/python3.7/site-packages/depthai.cpython-37m-x86_64-linux-gnu.so
Depthai version installed:  <IP_ADDRESS>
Compiled mode found: compiled for 14 shaves, 14 cmx_slices and 1 NN_engines
XLink initialized.
Sending internal device firmware
Successfully connected to device.
Usb speed : Super/5000Mbps
Mx serial id : 14442C10B1E409D100
Loading config file
Attempting to open stream config_d2h
watchdog started
Successfully opened stream config_d2h with ID #0!
Closing stream config_d2h: ...
Closing stream config_d2h: DONE.
EEPROM data: valid (v5)
  Board name     : BW1098OBC
  Board rev      : R0M0E0
  HFOV L/R       : 71.86 deg
  HFOV RGB       : 68.7938 deg
  L-R   distance : 7.5 cm
  L-RGB distance : 3.75 cm
  L/R swapped    : yes
  L/R crop region: center
  Rectification Rotation R1 (left):
    0.999958,    0.002866,    0.008741,
   -0.002884,    0.999994,    0.002032,
   -0.008735,   -0.002057,    0.999960,
  Rectification Rotation R2 (right):
    0.999981,   -0.005453,   -0.002831,
    0.005447,    0.999983,   -0.002052,
    0.002842,    0.002037,    0.999994,
  Calibration intrinsic matrix M1 (left):
  854.679382,    0.000000,  646.690918,
    0.000000,  855.430969,  404.758911,
    0.000000,    0.000000,    1.000000,
  Calibration intrinsic matrix M2 (right):
  854.277344,    0.000000,  637.004456,
    0.000000,  854.839539,  403.517487,
    0.000000,    0.000000,    1.000000,
  Calibration rotation matrix R:
    0.999898,    0.008307,    0.011593,
   -0.008354,    0.999957,    0.004021,
   -0.011559,   -0.004118,    0.999925,
  Calibration translation matrix T:
   -7.479593,
    0.040785,
    0.021172,
  Calibration Distortion Coeff d1 (Left):
   -4.449849,   14.178833,   -0.001023,   -0.000998,  -12.882705,   -4.509255,   14.391972,
  -13.084028,    0.000000,    0.000000,    0.000000,    0.000000,    0.000000,    0.000000,
  Calibration Distortion Coeff d2 (Right):
   -4.595629,   14.189158,    0.000334,   -0.002113,  -13.973203,   -4.652501,   14.404813,
  -14.179348,    0.000000,    0.000000,    0.000000,    0.000000,    0.000000,    0.000000,
['metaout', 'previewout']
Available streams: ['meta_d2h', 'left', 'right', 'disparity', 'depth', 'metaout', 'previewout', 'jpegout', 'video', 'object_tracker', 'rectified_left', 'rectified_right', 'color']
/home/luis/Projs_Software/INESC_projects/AOK/depthai/resources/nn/tiny-yolo-v3/tiny-yolo-v3.json
depthai: Using calibration from stored in EEPROM
config_h2d json:
{"_board":{"calib_data":[0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0],"mesh_left":[0.0],"mesh_right":[0.0]},"_load_inBlob":true,"_pipeline":{"_streams":[{"name":"metaout"},{"name":"previewout"}]},"ai":{"NCEs":1,"NN_config":{"NN_family":"YOLO","NN_specific_metadata":{"anchor_masks":{"side13":[3,4,5],"side26":[1,2,3]},"anchors":[10,14,23,27,37,58,81,82,135,169,344,319],"classes":80,"confidence_threshold":0.5,"coordinates":4,"iou_threshold":0.5},"output_format":"detection"},"blob0_size":11813888,"blob1_size":0,"calc_dist_to_bb":true,"camera_input":"rgb","cmx_slices":14,"keep_aspect_ratio":true,"num_stages":1,"shaves":14},"app":{"enable_reconfig":true,"sync_sequence_numbers":false,"sync_video_meta_streams":false,"usb_chunk_KiB":64},"board":{"clear-eeprom":false,"left_fov_deg":71.86000061035156,"left_to_rgb_distance_m":0.03750000149011612,"left_to_right_distance_m":0.07500000298023224,"name":"","override-eeprom":false,"revision":"","rgb_fov_deg":68.7938003540039,"stereo_center_crop":false,"store-to-eeprom":false,"swap-left-and-right-cameras":true},"camera":{"mono":{"fps":30.0,"resolution_h":400,"resolution_w":640},"rgb":{"fps":30.0,"resolution_h":1080,"resolution_w":1920}},"depth":{"depth_limit_mm":10000,"lr_check":false,"median_kernel_size":7,"padding_factor":0.30000001192092896,"warp_rectify":{"edge_fill_color":0,"mirror_frame":true,"use_mesh":false}},"ot":{"confidence_threshold":0.5,"max_tracklets":20}}
size of input string json_config_obj to config_h2d is ->1824
size of json_config_obj that is expected to be sent to config_h2d is ->1048576
Attempting to open stream config_h2d
Successfully opened stream config_h2d with ID #1!
Writing 1048576 bytes to config_h2d
!!! XLink write successful: config_h2d (1048576)
Closing stream config_h2d: ...
Closing stream config_h2d: DONE.
Creating observer stream host_capture: ...
Attempting to open stream host_capture
Successfully opened stream host_capture with ID #0!
Creating observer stream host_capture: DONE.
Read: 11813888
Attempting to open stream inBlob
Successfully opened stream inBlob with ID #1!
Writing 11813888 bytes to inBlob
!!! XLink write successful: inBlob (11813888)
Closing stream inBlob: ...
Closing stream inBlob: DONE.
depthai: done sending Blob file /home/luis/Projs_Software/INESC_projects/AOK/depthai/resources/nn/tiny-yolo-v3/tiny-yolo-v3.blob.sh14cmx14NCE1
Attempting to open stream outBlob
Successfully opened stream outBlob with ID #2!
E: [global] [    799014] [python] addEvent:262  Condition failed: event->header.flags.bitField.ack != 1
E: [global] [    799014] [python] addEventWithPerf:276   addEvent(event) method call failed with an error: 3
E: [global] [    799014] [python] XLinkReadData:156     Condition failed: (addEventWithPerf(&event, &opTime))
Device get data failed: 7
Closing stream outBlob: ...
E: [global] [    799017] [Scheduler00Thr] dispatcherEventSend:53        Write failed (header) (err -4) | event XLINK_CLOSE_STREAM_REQ

E: [xLink] [    799018] [Scheduler00Thr] sendEvents:1027        Event sending failed
Closing stream outBlob: DONE.
Traceback (most recent call last):
  File "depthai_demo.py", line 418, in <module>
    dai.startLoop()
  File "depthai_demo.py", line 84, in startLoop
    p = self.device.create_pipeline(config=config)
RuntimeError: [json.exception.parse_error.101] parse error at line 1, column 1: syntax error while parsing value - unexpected end of input; expected '[', '{', or a literal
=== New data in observer stream host_capture, size: 4
Writing 4 bytes to host_capture
!!! XLink write successful: host_capture (4)
E: [global] [    799147] [Scheduler00Thr] dispatcherEventSend:53        Write failed (header) (err -4) | event XLINK_WRITE_REQ

Stopping threads: ...
E: [xLink] [    799147] [Scheduler00Thr] sendEvents:1027        Event sending failed
Stopping threads: DONE 0.000s.
Closing all observer streams: ...
Closing stream host_capture: ...
Closing stream host_capture: DONE.
Closing all observer streams: DONE.
Reseting device: 0.
E: [global] [    799147] [Scheduler00Thr] dispatcherEventSend:53        Write failed (header) (err -4) | event XLINK_RESET_REQ

E: [xLink] [    799147] [Scheduler00Thr] sendEvents:1027        Event sending failed
Reseting: DONE.

I thought by following the tutorial I should be able to run the model right out of the box. Probably I am missing something.
Any suggestion is more than welcome.
** More details **

Python = 3.7
Conda Environment
Ubuntu = 18.04

Hi @luiscastro1995 ,
I'm not immediately sure what is going wrong here.  One initial idea is around the number of classes your model has, and if that is correctly reflected in the JSON.
How many classes does it have?
Thanks,
Brandon

Yolo-v4 is not supported on openvino 2020.1. Gen1 only supports openvino 2020.1.
Here is an example of yolo-v4 on gen2, openvino 2021.2.

Ah awesome thanks for the catch @szabi-luxonis !  I had missed that.  Recall now.

@szabi-luxonis thanks for the answer, it solved the problem. Since I used openvino 2020.4 to compile my yolov4-tiny I added this line to your code:
pipeline = dai.Pipeline()
## Added
pipeline.setOpenVINOVersion(dai.OpenVINO.Version.VERSION_2020_4)

and it worked fine!


Swift 2.3 Support

For those of us wishing to develop in Xcode 8 beta 4, but stick with Swift 2.3 rather than taking the large step of using Swift 3. I know you have a Swift 3 branch, but I only want to Swift 2.3.

@loganblevins thanks for your suggestion, we are focusing on swift3 at the moment. Could you like to help us with this? Once your PR is ready, we will create a swift2.3 branch to maintain all the changes. Once Xcode 8 releases GM, we can merge into master.

@JakeLin Sure, I'll give it a shot.

Added a swift 2.3 branch available here. https://github.com/IBAnimatable/IBAnimatable/tree/swift2.3
Description of the updates made can be found here  https://gist.github.com/gkye/50e8dabb531a50256549a2d21eab1080 @JakeLin @loganblevins check it out when you get a chance

@tbaranes

@gkye thanks 👍

I have updated README.md to let the user know about Swift 2.3 support.  @loganblevins can we close this issue now?

@JakeLin Sounds good! Thank you.

@loganblevins cool, please let me know if you want to help us with some tasks, for example, maintaining swift2.3 branch, merging changes from master to swift2.3, improving the code quality like removing forced unwrapping code.

@JakeLin Sure, I could tie up some loose ends. Is there a group for contributors?

@loganblevins great, welcome onboard. We can discuss more details. Can you send me your email for Slack? You can find my email address on my Github page github.com/JakeLin, thanks.


RID::is_valid missing from GDNative C API

Godot 3.0 master
As I progress porting my module, I found that godot_rid_is_valid() is missing from the C API of RID.
Should it be added?

@Zylann Is this still relevant in Godot 3.2.1?

Looks like it is https://github.com/godotengine/godot/blob/3.2/modules/gdnative/include/gdnative/rid.h


[fix](inverted index) skip read index column data only for DUP and MOW table

Proposed changes
Issue Number: close #xxx
Skip read index column data for MOR may cause wrong result, so only do it for DUP and MOW table.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Upgrade to k8 1.7.0

I should probably squash this up a bit and maybe wait until the @vaijab's label work is on keto-master but, this works:
/ # kubectl get nodes
NAME                                          STATUS                     AGE       VERSION
ip-172-31-17-97.eu-west-2.compute.internal    Ready,SchedulingDisabled   4m        v1.7.0+coreos.0
ip-172-31-26-40.eu-west-2.compute.internal    Ready,SchedulingDisabled   2m        v1.7.0+coreos.0
ip-172-31-27-166.eu-west-2.compute.internal   Ready                      1m        v1.7.0+coreos.0
ip-172-31-30-108.eu-west-2.compute.internal   Ready,SchedulingDisabled   2m        v1.7.0+coreos.0
/ # kubectl get pods
No resources found.
/ # kubectl get pods --namespace=kube-system
NAME                                                                  READY     STATUS    RESTARTS   AGE
canal-h7699                                                           3/3       Running   0          1m
canal-k53dh                                                           3/3       Running   0          2m
canal-p85mh                                                           3/3       Running   0          2m
canal-rw6fp                                                           3/3       Running   0          4m
keto-tokens-2k3kt                                                     1/1       Running   0          2m
keto-tokens-5qkt3                                                     1/1       Running   0          2m
keto-tokens-nsf84                                                     1/1       Running   0          4m
kube-apiserver-ip-172-31-17-97.eu-west-2.compute.internal             1/1       Running   0          1m
kube-apiserver-ip-172-31-26-40.eu-west-2.compute.internal             1/1       Running   0          1m
kube-apiserver-ip-172-31-30-108.eu-west-2.compute.internal            1/1       Running   0          1m
kube-controller-manager-ip-172-31-17-97.eu-west-2.compute.internal    1/1       Running   0          1m
kube-controller-manager-ip-172-31-26-40.eu-west-2.compute.internal    1/1       Running   0          1m
kube-controller-manager-ip-172-31-30-108.eu-west-2.compute.internal   1/1       Running   0          1m
kube-dns-2425271678-twvqj                                             2/3       Running   0          4m
kube-proxy-79z5q                                                      1/1       Running   0          2m
kube-proxy-bg7xj                                                      1/1       Running   0          1m
kube-proxy-trjtq                                                      1/1       Running   0          4m
kube-proxy-tvdfc                                                      1/1       Running   0          2m
kube-scheduler-ip-172-31-17-97.eu-west-2.compute.internal             1/1       Running   0          1m
kube-scheduler-ip-172-31-26-40.eu-west-2.compute.internal             1/1       Running   0          1m
kube-scheduler-ip-172-31-30-108.eu-west-2.compute.internal            1/1       Running   0          2m

@gambol99 - good catch - intellij told off suitably and also squashed the pr a bit...


There is no "Azure Resource Managers Template" output window after opening a deployment file

OS: All
Build Version: 20200318.2
Repro Steps:

Open a deployment file.
Check if there is a "Azure Resource Manager Template" output window.

Expect:
There is a "Azure Resource Manager Template" output window..
Actual:
There is no "Azure Resource Managers Template" output window.

@v-ruizh I believe this PR consolidated the output into one channel, Azure Resource Manager Tools.
https://github.com/microsoft/vscode-azurearmtools/pull/495
@StephenWeatherford to confirm.

Correct, thanks!


Removed sending the tracing information back in the response

fixes #327
cc @adriancole

red's a nice color! :shipit:


Unexpected major version bumps on one package

Problem
Changesets has repeatedly bumped one of my packages' major version when it only receives patch or minor changes. Sometimes I'm paying attention in the PR and catch it, but at least 3 times it's gotten past me, so it's now 3 major versions ahead of other packages in the project.
An example PR (@lo-fi/react is bumped from 3.0.0 to 4.0.0 despite only having patch changes): https://github.com/a-type/lo-fi/pull/59
I'm not sure if this is intended behavior, but it's not desired. I'd prefer to have all my packages be in the same version range without having to manually edit changeset PRs.
I'm assuming the source of this behavior is in the main project and not the Github Action, but I could be wrong.

We've also run into this issue, but on private repositories.

I've tracked it down to https://github.com/changesets/changesets/blob/main/packages/assemble-release-plan/src/determine-dependents.ts#L209 in our case, we have indeed done a minor release of a package which is a peer dependency.
Haven't seen this documented anywhere or I've missed it.

I have also run int this issue and i found that it occurs only when one of peerDependencies has a minor version change.
When I delete the dependency from peerDependencies, it's ok.
Is there any explanation about this behaviour ?
Thank you!

Seems like it's more the package manager's job to warn you if a peer dependency has moved out of range. I use pnpm and it's very aggressive about this already.
For context I have a core package, @lo-fi/web, and an associated React hooks package, @lo-fi/react, which lists @lo-fi/web as peer dependency - because it requires web to function, but isn't very opinionated about exact versions and I don't want it to have a separate copy of the library, it absolutely has to be the same one used directly the code. I could be mistaken, but I believe that's the point of peerDependencies.
What's annoying is that now if I update certain things in certain ways, my React package is major bumped, so its version is now wildly out of step with the rest of the package ecosystem it's a part of.
Might be a good behavior to make optional.

Regular old npm has also become much stricter about this over the last year or so, following a lot of the leads that pnpm started. I would definitely also like to see this behaviour at least be optional as it's breaking things for us too. We effectively can't do minor releases to our monorepo using locked to keep all the versions in sync because any minor update cause a peer dependency to change, which triggers a major update and then the whole monorepo gets dragged up to a major version bump as well.

I think we need a config options to control this behavior, just leave the decision to the end user.

Any updates here? @thynson your efforts seem quite far, does it make sense to PR this one in? I think it's a really annoying problem for quite a few people.

Can I opt out from this behavior? I've just setup changesets in my project, but this is a deal breaker, if I can't opt out, I'll have to rollback :(

Can I opt out from this behavior? I've just setup changesets in my project, but this is a deal breaker. If I can't opt out, I'll have to rollback :(

It can be opt-out if #1132 got merged.

Hi any plans to release this soon?

This is also importand to us because we wanted to use peer dependencies between monorepo packages but everything gets major bumped all the time

Same issues, peer deps inside monorepo, packages getting major version bumps unexpectedly

someone did solve it?

Just had this issue, do not even know why it happend because it went alright before.
Maybe because I just updated to the latest version, hope that is not it, would be weird.

someone did solve it? Fome me I'm going to edit .changest/random-file changeing major with what i want each time

Same. But my package is now on version 3.0.0 because team mates (and myself) forget sometimes. Really annoying stuff.

I dont' undestand.
Developers come here because of "changeset is very useful with monorepo" and many tutorial suggest this library. But seem that this problem is very big and described on other issue for example:
https://github.com/changesets/changesets/issues/1279
In my case with a monorepo this isse is the core of relerase process so I cannot use that :)
Hope someone willl fix that

cc @Andarist

Hi, is there any update on this? My packages now even have a higher version than Angular 🥹

Hey everyone, just sponsored the changeset organization with $400 for the great work they're doing! … And also with the hope of allocating some resources to get this annoying issue resolved. 😊 cc @emmatown @Andarist

+1 on this. This really is a big stumbling block for us because we are still in early development and do not want to be forced to go to v1.0.0 yet.
I understand it might take more thought to decide if this behaviour is technically correct or not... but would really like to see a temporary option to prevent this in the meantime.
Appreciate all the hard work on changesets!

?

had this issue today. i opted to just patch the package.
function shouldBumpMajor({
  dependent,
  depType,
  versionRange,
  releases,
  nextRelease,
  preInfo,
  onlyUpdatePeerDependentsWhenOutOfRange,
}: {
  dependent: string;
  depType: DependencyType;
  versionRange: string;
  releases: Map<string, InternalRelease>;
  nextRelease: InternalRelease;
  preInfo: PreInfo | undefined;
  onlyUpdatePeerDependentsWhenOutOfRange: boolean;
}) {
  if(depType === "peerDependencies" ) {
    return false;
  }
  // we check if it is a peerDependency because if it is, our dependent bump type might need to be major.
  return (
    //@ts-ignore
    depType === "peerDependencies" &&
    nextRelease.type !== "none" &&
    nextRelease.type !== "patch" &&
    // 1. If onlyUpdatePeerDependentsWhenOutOfRange set to true, bump major if the version is leaving the range.
    // 2. If onlyUpdatePeerDependentsWhenOutOfRange set to false, bump major regardless whether or not the version is leaving the range.
    (!onlyUpdatePeerDependentsWhenOutOfRange ||
      !semverSatisfies(incrementVersion(nextRelease, preInfo), versionRange)) &&
    // bump major only if the dependent doesn't already has a major release.
    (!releases.has(dependent) ||
      (releases.has(dependent) && releases.get(dependent)!.type !== "major"))
  );
}

+1

Just stumbled onto this and the issue has been open for 2 years.
It has been said many times in this thread, but the current behaviour is just wrong for most library authors:
Let's assume that A lists B in its peerDependencies.
If I create a changeset with a patch change to B and no change to A, it's very likely that my intent was to leave A untouched. Currently changeset forces me to create a major for A.
Even worse, if I use a changeset with a patch change to A and B, A will still have a major change.
The current workarounds are :

Do not use peerDependencies
Manually patch the internal package @changesets/assemble-release-plan

Both of them are not ideal.
A simple configuration flag would make the life of everyone affected by this issue much simpler.
Perhaps something like this : type peerDependenciesBump = "major" | "minor" | "patch" | "none".
While I strongly believe that the default should be none, this option can be added without a breaking change by setting the default to major.
Maybe add something in the CLI to warn users with peer dependencies about this.

Make the default a patch or feature. At least users will know there's some change. It shouldn't be a major change, though. Especially for pre-v1 packages, this is a huge issue. It's forcing me to go to v1 ahead of time when I'm still in v0.


Add convenience function RichEmbed.addBlankField

It might also be worthwhile to change setDescription's parameter optional and automatically fill it with \u200b if omitted.

^

I originally had a feature like this with a RichEmbed PR I made, for which I was told to remove from my pr. I doubt this will be allowed to be added, from my experience.

@appellation Making a blank inline field would still require you to type out the entire thing though.
Would be cool if default params worked like python kwargs, but without all the hassle when you don't want to use the keyword for it.

@bdistin Yeah :thinking:

a sad sad day is upon us...

@GusCaplan Hahahahah


Adding missing common types in TypeSpec

[ ] managedidentitywithdelegation.json
[ ] mobo.json
[ ] networksecurityperimeter.json

Should be done asap in the upcoming sprint.

We have issues for the first two already, do you want to combine into this one?
Mobo issue https://github.com/Azure/typespec-azure/issues/249
managedidentitywithdelegation  issue https://github.com/Azure/typespec-azure/issues/944

est: 3


Bluetooth: Audio: Volume Control Service and client

This PR implements the Volume Control Service (VCS) server and client.
The implementation supports and uses the Audio Input Control Service (AICS) server and client implementations as well as the Volume Offset Control Service (VOCS) server and client implementations.
Besides the implementation, a full test suite that exercises the entire API is also added using Babblesim.

Depends on https://github.com/zephyrproject-rtos/zephyr/pull/34169 and https://github.com/zephyrproject-rtos/zephyr/pull/34127 to pass CI

@Vudentz please review before Friday so we can get this into Zephyr 2.6.

@carlescufi We also need to resolve https://github.com/zephyrproject-rtos/zephyr/issues/34823 before this can be merged, as the MISRA scripts are blocking this PR (and others).

I don't mind so big changes (6000+ lines added) being in a single pull request, but you could IMO do a bit better job at splitting things up into smaller self-contained commits. E.g. the service and client could probably be in separate commits. I only took a quick look at the code itself (too much for a thorough review) and that looks fairly alright to me.

I don't mind so big changes (6000+ lines added) being in a single pull request, but you could IMO do a bit better job at splitting things up into smaller self-contained commits. E.g. the service and client could probably be in separate commits. I only took a quick look at the code itself (too much for a thorough review) and that looks fairly alright to me.

For what it is worth, before upstreaming the code has been developed and reviewed in smaller portions, as a number of changes over time, in the zephyr-bt-sig tree.

I don't mind so big changes (6000+ lines added) being in a single pull request, but you could IMO do a bit better job at splitting things up into smaller self-contained commits. E.g. the service and client could probably be in separate commits. I only took a quick look at the code itself (too much for a thorough review) and that looks fairly alright to me.

Yes, Luiz also gave that comment. Splitting the server and client is somewhat difficult as they share the same API, i.e. the vcs.h header file would be hard to split up into two commits. The alternative is just add e.g. the server and vcs.h (with references to the client) in one commit, and then the client in another, but that would be fairly weird. Perhaps I could also add the server and client in two commits, and then add the public header file.
What I've done for the MICS PR is that I've split it into 3:

Implementation
Shell
Tests

@carlescufi We also need to resolve #34823 before this can be merged, as the MISRA scripts are blocking this PR (and others).

We have been overriding that in other PRs, and we can do that here too.

@carlescufi We also need to resolve #34823 before this can be merged, as the MISRA scripts are blocking this PR (and others).

We have been overriding that in other PRs, and we can do that here too.

@carlescufi I think this is good to merge now. Can you override the MISRA script?


[stdlib]: Propagate AsyncStream termination to all consumers

As of the changes in https://github.com/swiftlang/swift/pull/41713 to enable Sendability for AsyncStream, it has been possible to create multiple stream consumers operating concurrently. This change fixes behavior in the case that the underlying stream is terminated while multiple pending continuations are outstanding. Previously such consumers would have been leaked (never resumed). Now, they are notified of the stream's termination and resumed appropriately.
Resolves #66541 & #71412

cc @phausler, @FranzBusch – if you get some time, i'd appreciate your thoughts on the direction taken here to address this issue.

I just want to point out that this is again a diverge between AsyncStream and AsyncThrowingStream. Now this here fixes a bug in the current divergence but it is something we should tackle at some point

i agree, though fixing this bug and unifying the implementations (and updating the docs) seem like reasonably distinct tasks.

@FranzBusch @ktoso – any feedback on this? thanks in advance!

@swift-ci please smoke test

@swift-ci test windows


Move the closure argument to the end of the arg list

Move the closure argument in replace and replacing to the end of the argument list for trailing closure syntax. Add a test for replacing within a range.

@swift-ci please test

@swift-ci please test


Any reason differencing in managed and federated environment for Windows current?

Dear all,
to me it seems there is a foot note missing. In footnote 5 it says we can use non-persistent VDIs when additional requirements and considerations are met.
I cannot see any explanation why non-persistent VDI with login script should only be supported in federated environments?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e8f55d4-539c-7835-010b-34026860f699
Version Independent ID: 4f8db376-bed9-6fd2-2e65-ac11c0952540
Content: Device identity and desktop virtualization - Azure Active Directory
Content Source: articles/active-directory/devices/howto-device-identity-virtual-desktop-infrastructure.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@stefandoh
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

ADFS supports instant join for non-persistent VDI.


compose version: "2.0"

Hey folks,
Noticed an issue  using a downstream project ecs-cli where libcompose fails to parse the compose file when version is set to "2.0" instead of "2". I have never been a gopher but if I had to take a stab at it it seems like the issue is a naive string comparison here: if config.Version != "2" { ... when really one would want to check for "2" or "2.0"?
A good test might be ./libcompose-cli config | ./libcompose-cli -f - config using any docker-compose.yml. This is essentially how I ran into the bug in the wild and is a convenient way to assert that libcompose-cli config only outputs valid compose files and can read all valid compose files.
Thanks in advance! Sorry I can't be any more help :sad:

This can be closed thanks to https://github.com/docker/libcompose/pull/507 for now I think (lack of test coverage, but the bug is resolved).


fix ISSUE#447

fix the problem  when method executeLocalTransaction return LocalTransactionState.COMMIT_MESSAGE but still executing checkLocalTransaction method
What is the purpose of the change
fix the problem when method executeLocalTransaction return LocalTransactionState.COMMIT_MESSAGE but still executing checkLocalTransaction method ISSUE#447
Brief changelog
assign transaction listener to localTransactionState in org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.1%) to 42.47% when pulling c1327ac15bb34d9c099104e3651aa9b499f24ef1 on joewee:fix-client into 9086c61c819a1f55ae5d7d0a9e923e32fc94216b on apache:release-4.3.1.

@joewee please pull request for develop branch.

@duhengforever I have changed the base branch from release-4.3.1  to develop

@joewee Please rebase your branch , Aha，You submitted the commit of someone else.


Action Items for Mentors

👋  Hello Mentors,
Thanks again for your support. 🙏
Please help us further with the following:

[ ] Introduce yourself at #127

[ ] Add your repositories to PROJECTS.md

[ ] Add beginner-friendly issues to ISSUES.md

[ ] Drop your picture to assets/pictures directory

Please ensure that your file name should follow <your_username>.jpg/.png, e.g. vinitshahdeo.png

[ ] Ask your mentees to submit their details here.

[ ] Keep updating MENTEES.md as soon as you start mentoring.

[ ] Join our Discord to stay updated.

[ ] Read this blog post if you haven't yet.

[ ] Please follow the Code Of Conduct.

[ ] Take a break and drink water!

Happy Hacktoberfest'21 🌈

Hi @vinitshahdeo @praveenscience can we have a mentor batch with their Tech stack and Avatar? it will attract mentors and help the mentee to figure out who to reach out !
example batch : https://devfestindia.com/badge

@ch8n This is an interesting idea. Tagging @pranjalbareth here for his inputs.

Discord link is broken, here's one that works https://discord.com/invite/HFbr3pnqxj