Microsoft.TypeScript.targets(156,5): error MSB4018: The "FindConfigFiles" task failed unexpectedly.

TypeScript Version:  1.8.34 (build server 1.8.6 and 1.7.5
Code
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: The "FindConfigFiles" task failed unexpectedly. [D:\Builds\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: System.ArgumentNullException: Value cannot be null. [D:\Builds\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: Parameter name: path [D:\Builds\TFSBuild.proj]
// A self-contained demonstration of the problem follows...
I have installed the 1.8.34 version on my Visual studio 2015 and I have changed the build project to import the
**

etc....
**
Build servers had installed version 1.7.5
Everything worked fine (meaning build completed fine, but the js files were never generated).
I went onto build server and tried upgrading the latest version of typescript for vs2015 from the site, and ever since I have been getting this error.  There is nothing much online to show what is going on.
I have tried uninstalling/repairing the installation, repairing the old one, but nothing seems to work.   My tsconfig.json looks like this
**
{
"compilerOptions": {
"noImplicitAny": false,
"noEmitOnError": true,
"removeComments": false,
"sourceMap": true,
"target": "es5",
"outDir": "./Scripts"
},
"compileOnSave": false,
"exclude": [
"node_modules",
"wwwroot"
]
}
**
Everything builds fine locally, its just when I push it on build server when this error is happening and I cannot find any solution to it.
Expected behavior:
Actual behavior:

@paulvanbrenk can you take a look.

I realized after installing the newer version of TypeScript as well that neither my build servers or my local has any entry in the Parh for the environmental variables.  Is this something we should add manually if we want to be able to access the typescript compiler from anywhere other then TS folder?

correct. since TS 1.1, the installer does not add any thing to the path.

Cool, thanks.
I uninstalled 1.8.6 from the build server, and have only 1.7.5.  I did a repair on the 1.7.5 and still getting the same error.  Not sure what changed and how was this working prior to me trying to upgrade to 1.8.6
Also I have VS2015 on build servers, and when I installed the 1.8.6 it was telling me in the version that its actually 1.8.5 (which should be the version for VS2013).  Kind of confused here.  What would be the best way to uninstall everything and install latest on the build server.
My dev computer has VS2015 with 1.8.34 installed.  I tried downloading the new version and installing from
https://www.microsoft.com/en-us/download/details.aspx?id=48593
but it is still showing that its 1.8.34
Any input on these.  And what is the meaning of the error message above?  Does it have to do with my using tsconfig.json file?  Would removing the file and using the project properties work?

got update 3 of visual studio on the build server, the version is showing as 1.8.34 (same as what I have locally)
When I build again getting the same error.

@ludakuca Can you share your project file?

Project file within solution has this code at the top added for typescript:
<?xml version="1.0" encoding="utf-8"?> <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">   <Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.Default.props" Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.Default.props')" />   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />  ,,,
Then this entry for typescript:
   <TypeScriptToolsVersion>1.8</TypeScriptToolsVersion>
at the end it has this:
`

10.0
$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)

 `
everything builds and works fine locally.
These are the MSBuild project file entries.
at the top I added:
`

  `
Then in the middle of the project I have this part:
<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
    <TypeScriptRemoveComments>false</TypeScriptRemoveComments>
    <TypeScriptSourceMap>true</TypeScriptSourceMap>
  </PropertyGroup>
  <PropertyGroup Condition="'$(Configuration)' == 'Release'">
    <TypeScriptRemoveComments>true</TypeScriptRemoveComments>
    <TypeScriptSourceMap>false</TypeScriptSourceMap>
  </PropertyGroup>

and then at the end I added follwoing lines:
<Import
      Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.targets"
      Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.targets')" />

These are identical and unchanged entries recommended on the typescript site to use for msbuild.
It worked as I said originally, but upon trying to get the version on server to update from 1.7.5 to 1.8 this started happening...and I tried uninstalling and everuything and nothing brings it back.
Thanks,

@ludakuca Can you share your whole project file, there may be some subtle things going on. Does this work on your local machine? Further can you share the log file when you build with the following options msbuild /fl /flp:verbosity=diagnostic

@paulvanbrenk
everything works fine on my local machine.  What project file are you talking about, the msBuild, or the project file within my solution?

@ludakuca The project file that contains the typescript files, so probably the one in your solution.

@paulvanbrenk but everything builds fine in my local computer and even other coworkers when getting latest can build and work with it.
Only time this fails is when I am trying to push code to the build server to build

@ludakuca How about the log file from the server build?

@paulvanbrenk
This is pretty much it in the log file.  its the first thing that fails.
Build started 6/30/2016 12:27:41 PM.
Project "d:\Builds\15\BuildType\TFSBuild.proj" on node 1 (EndToEndIteration target(s)).
InitializeBuildProperties:
  GetBuildProperties TeamFoundationServerUrl="http://localhost:8080/tfs/mycollection" BuildUri="vstfs:///Build/Build/44865"
InitializeEndToEndIteration:
  UpdateBuildNumberDropLocation TeamFoundationServerUrl="http://localhost:8080/tfs/mycollection" BuildUri="vstfs:///Build/Build/44865" BuildNumber="20160630.3" DropLocation="\\{Myserver}\Builds\20160630.3"
CoreInitializeWorkspace:
  DeleteWorkspaceTask TeamFoundationServerUrl="http://localhost:8080/tfs/mycollection" BuildUri="vstfs:///Build/Build/44865" Name="SERVER_103_15" DeleteLocalItems=True
  CreateWorkspaceTask TeamFoundationServerUrl="http://localhost:8080/tfs/mycollection" BuildUri="vstfs:///Build/Build/44865" Name="SERVER_103_15" BuildDirectory="d:\Builds\15\" SourcesDirectory="d:\Builds\15\src" Comment="Workspace created by Team Build"
InitializeBuild:
  Creating directory "d:\Builds\15\src".

CoreLabel:
  Label TeamFoundationServerUrl="http://localhost:8080/tfs/mycollection" BuildUri="vstfs:///Build/Build/44865" Name="20160630.3" Scope="$/MyApp" Recursive=True Comments="Label created by Team Build" Version="WSERVER_103_15" Child="Replace" Files="$/"
  Label 20160630.3@$/MyApp (version WSERVER_103_15) was successfully created.
  SetBuildProperties TeamFoundationServerUrl="http://localhost:8080/tfs/mycollection" BuildUri="vstfs:///Build/Build/44865" CompilationStatus="Unknown" LabelName="20160630.3@$/MyApp" Status="None" TestStatus="Unknown"
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: The "FindConfigFiles" task failed unexpectedly. [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: System.ArgumentNullException: Value cannot be null. [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: Parameter name: path [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at System.IO.Directory.EnumerateFiles(String path) [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at TypeScript.Tasks.FileHelpers.RecursiveGatherFiles(String directoryPath, String projectPath, Func`2 filter) [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at TypeScript.Tasks.FindConfigFiles.FindConfigFilesOnDisk() [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [d:\Builds\15\BuildType\TFSBuild.proj]
Done Building Project "d:\Builds\15\BuildType\TFSBuild.proj" (EndToEndIteration target(s)) -- FAILED.

Build FAILED.

"d:\Builds\15\BuildType\TFSBuild.proj" (EndToEndIteration target) (1) ->
(FindConfigFiles target) ->
  C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: The "FindConfigFiles" task failed unexpectedly. [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: System.ArgumentNullException: Value cannot be null. [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018: Parameter name: path [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at System.IO.Directory.EnumerateFiles(String path) [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at TypeScript.Tasks.FileHelpers.RecursiveGatherFiles(String directoryPath, String projectPath, Func`2 filter) [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at TypeScript.Tasks.FindConfigFiles.FindConfigFilesOnDisk() [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [d:\Builds\15\BuildType\TFSBuild.proj]
C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\TypeScript\Microsoft.TypeScript.targets(156,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [d:\Builds\15\BuildType\TFSBuild.proj]

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:58.41

i removed the names of the servers, etc.  for privacy concerns.

@ludakuca Can you post thewhile log file with the verbosity set to diagnostic I need to know all the variables that are being set by msbuild in one way or another.

this is pretty much it with the logging verbosity set to diagnostic.  Do I have to run the build from the command prompt?

@ludakuca Yes, you probably do.
Environment at start of build:
ALLUSERSPROFILE = C:\ProgramData
APPDATA = C:\Users\pvanbren\AppData\Roaming
CommonProgramFiles = C:\Program Files (x86)\Common Files
CommonProgramFiles(x86) = C:\Program Files (x86)\Common Files
CommonProgramW6432 = C:\Program Files\Common Files
ComSpec = C:\WINDOWS\system32\cmd.exe
DevEnvDir = C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\
DNX_HOME = %USERPROFILE%\.dnx
ExtensionSdkDir = C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs
FPS_BROWSER_APP_PROFILE_STRING = Internet Explorer
FPS_BROWSER_USER_PROFILE_STRING = Default
Framework40Version = v4.0
FrameworkDir = C:\WINDOWS\Microsoft.NET\Framework\
FrameworkDIR32 = C:\WINDOWS\Microsoft.NET\Framework\
FrameworkVersion = v4.0.30319
FrameworkVersion32 = v4.0.30319
HOMEDRIVE = C:
INCLUDE = C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt;
LIB = C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB;C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x86;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x86;C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x86;
LIBPATH = C:\WINDOWS\Microsoft.NET\Framework\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB;C:\Program Files (x86)\Windows Kits\10\UnionMetadata;C:\Program Files (x86)\Windows Kits\10\References;C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs\Microsoft.VCLibs\14.0\References\CommonConfiguration\neutral;
LOCALAPPDATA = C:\Users\pvanbren\AppData\Local
MSBuildLoadMicrosoftTargetsReadOnly = true
NETFXSDKDir = C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\
NugetMachineInstallRoot = D:\NugetCache
NUMBER_OF_PROCESSORS = 4
OS = Windows_NT

@paulvanbrenk I do not have Teambuild on my local box and cant run this locally.  On the server I do not have the files to build it on the server.
we first copy all the files to the build server and then build things.

Can't you set the verbosity of the msbuild step to diagnostic either direct or via a command-line parameter (I can on the version we use here).

It looks like a variable projectdir isn't set as expected in your server build... I need those logs to figure out why.

Initial Property Values
BinariesSubdirectory =
BuildDirectory = D:\Builds\12\myproject
CommandLineArguments =
ConfigurationFolderPath = $/(myproject)/Build
DoNotDownloadBuildType = False
LogFilePerProject = True
MaxProcesses = 1
NodeReuse = False
RecursionType = Full
SourcesSubdirectory =
TargetsNotLogged =
TestResultsSubdirectory =
ToolPath =
ToolPlatform = Auto
Verbosity = Diagnostic

@ludakuca Can you share the whole log?

that was the whole log above.
Can the log you are looking for be generated by changing the build defitions and running the build from there.  The way this is set up I cannot run the builds using the cmd.

On my build server I can get detailed logs from the step that builds the proj file... you should be able to set those to diagnostic and grab those. Or log on the machine after the build is completed and grab them there.. without those logs I'm not able to tell you what's happening.

This is all i get as options....

What do you get when you 'download all logs as zip'

I get the file that I posted above.BuildLog.txt.
ah this is giving me too many headaches :) I wish I can get you more information, I know you would know lots more if I had more detailed log, but its just not possible it seems like.
This error seems to be happening even before my project is being built.

Ok, I can see in the screenshot that the call to msbuild doesn't set the verbosity of the log to diagnostic in the build step in your definition there should be an option to set MSBuild Arguments can you try setting /verbosity=diagnostic there.. the error you're seeing is part of the TypeScript build.

Trying now..

What's the error you're getting?

ah it seems like you gave me the wrong switch :)
should be /verbosity:diagnostic

Aah, yeah : vs. = is a common issue

so is a copy paste :)

is this good log?

Ok, looks like we want to set this option  /flp:verbosity=normal to diagnostic as well..

I think thats it.. getting the file ready to upload

Please don't post it here, but either zip it or email it directly to me. I assume it's pretty big.

I removed bunch of stuff

Thanks for helping me out over the email.  TThe build completed but no javascript files were generated on the build server.

@paulvanbrenk I did put some error logging in that file and I am seeing that both ProjectDir and Content parameters are null.  Am I not passing those properly?

@ludakuca is this an ASP.NET v5/Core project... ? Is the ConfigFiles collection empty?
Since you have a tsconfig.json file, the Content parameter is ignored, but we should be able to find the tsconfig.json file if that's inside the cone of the project (i.e. in the same dir as the proj file being build, or one of the sub-directories)

this is legacy / MVC 5 type project.  I have tsconfig inside the root of the web project.  its just the basic config file that generates when add new typescript file is added and I just added option compileOnSave = true

@paulvanbrenk I have sent you the email.
It seems like the changing the ProjectDir in the Typescript.targets file to point to the $SolutionRoot, which is TFS reserved word fixed the issue and now everything works as intended.  Please let me know what is the plan for the 2.0 version so that it does not overwrite for me.  Otherwise I will have to pass the ProjectDir variable from the build config.

We should have a fix for this in the next release. the official targets will not use ProjectDir at all.


Multi-Browser XP

Multi-Browser XP #416

Coverage remained the same at 100.0% when pulling 27d2c99314f45a6e2a086bf9904696f78736dfe2 on ayumi-cloud:Multi-Browser-XP into 4899110cd2f87b01e04ced62dbb9dec541031dee on WhichBrowser:master.


Handle infinite loop involving Self Service + The Daily Courant

NOTE: Before you begin working on this, please assign this issue to yourself. If you do not do this, then there's the possibility that 2 people will end up doing the same task, which is not a good use of time.
If Self Service and The Daily Courant are the only top cards on your board, and you activate one of them, you are forced into an infinite loop with no way out.

It seems that we need to provide a mechanism to abort this loop. But we also can't abort automatically because the player may wish to look at all of the top cards in the decks.
We should only provide a way to abort if these are the only two cards on their board.
I couldn't find any threads talking about this particular situation.

Marking this as blocked until we hear back from Chris. My proposal was to adjust the wording on The Daily Courant so that executing another card is optional.

My last email to Chris:
So the Self Service + The Daily Courant infinite is actually a bit differently than I explained in a previous email. If a player only has those two cards as their top cards and they execute Self Service for example, their only option to execute is The Daily Courant. And when they execute The Daily Courant they get to choose Self Service to execute. But this time, since Self Service is executing as if it were on The Daily Courant, the only card that can be chosen is Self Service (again). This leads to a The Daily Courant > Self Service (as if on The Daily Courant) > Self Service infinite loop.

Similarly, the other infinite loop I described is a bit different (Gujin Tushu Jinsheng > The Daily Courant > Self Service (as if on The Daily Courant) > Self Service).

Upon further reflection, I think it's okay if we allow the possibility of these infinite loops. On BGA, players have the option to abandon the game (it might make players complain about losing ELO). However, I expect the odds of these infinite loops from actually happening in practice to be extremely low. If they have any other other top cards on their board, then the loop can be broken.

I'd still be interested in hearing Carl's thoughts about these infinite loops, but I think it's fine if we don't give these infinite loops special treatment in the implementation.

Chris' response:
So I'm torn on this. On one hand, infinite loops (especially on a platform like BGA that has ELO concerns with abandoning games) is messy. But on the other, this is *so* unlikely to happen. I suppose it's slightly more likely in a Fission game.

Carl's actually OK with doing the "you may" modification for digital, and possibly revising the card next time we do a print run. I'm fine either way, really. I think the impact of the change will be extremely small.

My response:

If Carl is onboard with the minor revision of "The Daily Courant", then I'm going to move forward with that as our solution!
Before: Draw a card of any value, then place it on top of the draw pile of its age. Execute the effects of one of your other top cards as if they were on this card. Do not share them.
After: Draw a card of any value, then place it on top of the draw pile of its age. You may execute the effects of one of your other top cards as if they were on this card. Do not share them.


Add plugin hyper-final-say

https://www.npmjs.com/package/hyper-final-say

Hi! Thanks for the submission! I'll test the plugin soon 🙏

Basically what it does is re-assign configs (as the last one of plugins list), so it should support all configurations.

I agree Hyper should have this built in. cc @chabou @juancampa

I don't think that user's configuration should have highest priority. It would break every theme imo.


Create shortname for orga

Create a shortname attribute for each organisation.
This attribute should have no white space of special characters and be limited in size (8 or 16 characters)
This will be helpful to create specific domain name for each organisation (for example rts-chssr.rdns.ebu.io)

We used the EBU Codops that come through the koi Platform.
This allows to create specific DNS entries and separate the Service Providers and thus create more concise EPG XML Files.


Update doc for deploy k8s resource

Also add next step in getting started page
Signed-off-by: Jian Qiu<EMAIL_ADDRESS>

/assign @zhujian7

/lgtm


fmt.Errorf("whatever") (no arg) could be suggested to use errors.New("whatever")

Extracted from gosimple discussion

any linter that wants to suggest replacing calls to errors.New with exported error variables can do the same check for fmt.Errorf with a single argument.

Originally posted by @dominikh in https://github.com/dominikh/go-tools/issues/1550#issuecomment-2138367009
Do you think it makes sense to add it to perfsprint. Errorf is a sprintf wrapper after all

Is it not already the case cf -errorf option
perfsprint -h
perfsprint: Checks that fmt.Sprintf can be replaced with a faster alternative.

Usage: perfsprint [-flag] [package]

Flags:
  -V	print version and exit
...
  -errorf
    	optimizes fmt.Errorf (default true)

My bad, I launched my test via golangci-lint but there was a local golangci.yaml file that I didn't see, so my global golangci-lint.yaml wasn't used.

Glad it works as expected :-)


Add shop relic filter

This commit adds the Shop relic option for those who want an early Prismatic shard, Membership Card, or Orange Pellets in the first shop.
This filter works by itself, but I did not test it in conjunction with the Boss Swap, because theoretically you should be able to have both Filters on. I did not test it because I do not know how to really build the menu in such a way where it can toggle between Boss Swap menu and Shop relic menu.
Merging this as is should not change the functionality of the mod at the moment, since it's not being used from the menu until another commit is made to add it. Feel free to share the code between BossSwapFilterScreen and ShopRelicFilterScreen, there are very few differences between them.

Hi! Thank you for the commits - this is excellent stuff! I took a brief look through it right now on Github and it seems ready to merge without issue.
I'll set some time aside this weekend just to pull it locally and verify everything builds okay - and then I'll merge it in.
Do you have a desired username that you'd like to be credited as in the ModTheSpire author_list? I can add your name to this file (which is metadata that shows up for users of the mod) after merging if you let me know your preferred credit.
https://github.com/casey-c/FilterTheSpire/blob/main/src/main/resources/ModTheSpire.json
Thanks again for the merge request!

beeyee would be great as a credit, thanks!

I'm so sorry this took so long. I really appreciate your efforts here, and I feel really bad that it slipped my mind entirely :( I think something must have come up during the weekend where I meant to look into it more and just totally forgot to write it down to remind myself. We'll get that UI stuff sorted out with the next update. Working on finishing up my InfoMod for the workshop and I have one other teeny tiny side project and then I want to get back to FilterTheSpire again - I have some fresh ideas by now I think, and getting your contributions and Ian's into the full frontend mix for use is something pretty high priority for me!


[iOS][WeexSDK] iconfont can not showed as expected where weex version is 0.26.0

Loading two iconfont ttf files at the same time, the fonts in one font library are not displayed, and are normal on the browser.
this is the test dotwe address
http://dotwe.org/vue/f378cb6fecaff54b6951326e4a2002a2
Environment

Device: [e.g. iPhone X]
OS: [e.g. iOS13.1]
Version [e.g. 0.26.0]
Build from source [e.g. yes]

It seems  normal in the payground .

It seems normal in the payground .

this is browser

and this is weex playground

Is there anybody can help me?

@jianhan-he Have a look?

@amiacoder Weex on iOS dont support iconfont. If you want to use iconfont that you can add attribute "coretext=false" on text tag. like as: http woff: 

@amiacoder You should never use iconfont as family-name. Can you try change another family-name?

@amiacoder Weex on iOS dont support iconfont. If you want to use iconfont that you can add attribute "coretext=false" on text tag. Like as

you are right! thx

The issue seems like solved, I'd like to close it.
Feel free to open a new one if there is other problem.


Update mobile-style.css

@ParamGabhawala123 There is no need for this also the spelling is incorrect. Kindly don't spam otherwise you will be banned. This repo is open for quality contributions only not for 2-3lines tiny things.


Each token should have its own svg logo

Please do not use images, use iron-icon instead

Decided not to support token icon for now


Normalized RU consumption for shared Throughput databases is not supported by design. Needs specification in the doc.

Handled a case where it is found that Normalized RU consumption metrics does not allow spilitting by collection name when database has shared throughput configured. Therefore even though you specify splitting, the collections names does not populate.
The document needs to include that limitation on shared throughput spaces. I have an ICM# if needed for confirmation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e376a628-0deb-8b2d-89d5-12e59c1509b1
Version Independent ID: 2821c647-05d1-f2e8-278f-4a16043ceda3
Content: Monitor normalized RU/s for an Azure Cosmos container or an account
Content Source: articles/cosmos-db/monitor-normalized-request-units.md
Service: cosmos-db
GitHub Login: @kanshiG
Microsoft Alias: govindk

@GarrySinghMSFT We are checking this and will get back to you.

@GarrySinghMSFT We are checking this and will get back to you.

@GarrySinghMSFT I updated the doc in the above PR. The changes will be live tomorrow. We will close this issue now.
#please-close

@GarrySinghMSFT I updated the doc in the above PR. The changes will be live tomorrow. We will close this issue now.
#please-close


Follow official installation build can not found protobuf

Just follow the official installation process, error got:
[219/338] Building CXX object CMakeFiles/cartographe...ographer/io/serialization_format_migration_test.cc.o
In file included from /usr/src/googletest/googlemock/include/gmock/gmock-spec-builders.h:75:0,
                 from /usr/src/googletest/googlemock/include/gmock/gmock-generated-function-mockers.h:43,
                 from /usr/src/googletest/googlemock/include/gmock/gmock.h:61,
                 from /media/jintain/wd/ros/wps/catkin_ws_cartographer/src/cartographer/cartographer/io/serialization_format_migration_test.cc:27:
/usr/src/googletest/googlemock/include/gmock/gmock-matchers.h: In instantiation of ‘bool testing::internal::AnyEq::operator()(const A&, const B&) const [with A = unsigned int; B = int]’:
/usr/src/googletest/googlemock/include/gmock/gmock-matchers.h:908:18:   required from ‘bool testing::internal::ComparisonBase<D, Rhs, Op>::Impl<Lhs>::MatchAndExplain(Lhs, testing::MatchResultListener*) const [with Lhs = const unsigned int&; D = testing::internal::EqMatcher<int>; Rhs = int; Op = testing::internal::AnyEq]’
/media/jintain/wd/ros/wps/catkin_ws_cartographer/src/cartographer/cartographer/io/serialization_format_migration_test.cc:120:1:   required from here
/usr/src/googletest/googlemock/include/gmock/gmock-matchers.h:204:60: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   bool operator()(const A& a, const B& b) const { return a == b; }
                                                          ~~^~~~
ninja: build stopped: subcommand failed.
<== Failed to process package 'cartographer':
  Command '['/media/jintain/wd/ros/wps/catkin_ws_cartographer/install_isolated/env.sh', 'ninja', '-j8', '-l8']' returned non-zero exit status 1

Reproduce this error by running:
==> cd /media/jintain/wd/ros/wps/catkin_ws_cartographer/build_isolated/cartographer && /media/jintain/wd/ros/wps/catkin_ws_cartographer/install_isolated/env.sh ninja -j8 -l8

Command failed, exiting.

I have already got protobuf header files inside /usr/include/ and lib files inside /usr/include/local/

I have updated the compilation instructions. Now it should work fine if you follow the instructions on a clean Ubuntu / ROS: https://google-cartographer-ros.readthedocs.io/en/latest/compilation.html


MUMUP-2296 : Update footer

I know we said we didn't want to do a constant with an array, but I did it anyway. It was too easy to pass up.

Removed whatsNewURL as it was only used by the footer (and for frame we set it to null anyway)
Added FOOTER_URLS array constant. Pretty simple url, target, title
For frame apps I left it like it is today, just feedback and help.

:+1: Always be refactoring. Also :heart: the space characters in place of \ts.

Feasibility of smoothing the upgrade path so that frame-based app developers need change less in their app-config ? This looks like it requires an update to app-config in upgrading to a uw-frame with this change, which feels a little like an "API change" in semver parlance.
Feasibility of some kind of fall-back-on-portal-defaults behavior where in the (typical!) case where a frame-based app wants the recommended footer links, it just gets them?
Thought experiment: MyUW adds a GitHub link, and wants that link in the footer. It would be preferable to be able to add that one day in a MyUW release and have the nothing-special-to-add-to-footer frame-based apps just get the update, immediately, without having to cut releases, and without having to convince frame-based app developers to make the same change to their app-config .
Not a huge deal, but maybe a continued opportunity to think through how to smooth the ongoing upgrade and maintenance path.

:+1:

Chatted with @apetro offline, he's going to move that suggestion to a gh-issue


proposal: I propose that “go get” supports socks5.

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.8
What operating system and processor architecture are you using (go env)?
MacOS
What did you do?
go get -u github.com/golang/protobuf/protoc-gen-go
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
nothing
What did you see instead?
go get google.golang.org/grpc
cd .; git clone https://go.googlesource.com/text /Users/luke/snowballtest/golang/src/golang.org/x/text
Cloning into '/Users/luke/snowballtest/golang/src/golang.org/x/text'...
error: RPC failed; curl 56 SSLRead() return error -9806
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
package golang.org/x/text/secure/bidirule: exit status 128
package golang.org/x/text/unicode/norm: cannot find package "golang.org/x/text/unicode/norm" in any of:
/usr/local/go/src/golang.org/x/text/unicode/norm (from $GOROOT)
/Users/luke/snowballtest/golang/src/golang.org/x/text/unicode/norm (from $GOPATH)
I propose that  “go get“ support socks5 for Chinese Go programers.

This was added in Go 1.9. Try it out.
https://tip.golang.org/doc/go1.9#net/http

thank you


Update terra requirement to 0.22

Summary
Details and comments

Oops, I meant to make this against my fork, but I guess we can leave it open.


start metricsCollector,eventGenerator and scalingEngine in integration test

start metricsCollector,eventGenerator and scalingEngine in integration test

Add the test cases.


Donut/separate unit tests metrics

Changes done:

Unit test metrics separated from scenarios(A new dashboard panel is displayed for unit tests)

This is the count of linked unit tests(unit tests linked to a feature)

If there are 0 unit tests(that are part of a feature), unit tests panel won't be displayed

Orphaned unit test metrics reported separately under the dashboard panel

If there are 0 orphaned unit tests, their metrics won't be displayed at all

Fixed the bug - scenario/unit test description wasn't being displayed.

Fixed the bug - Windows paths were not working.

Feature description was being written inside ‘Some()’ as it had been changed to Option[String], changed that to String.

Some more documentation:
https://atlassian.magentys.io/confluence/display/KB/donut+relationship


Fix wrong typing for tolerance in reindex

In the xarray.core.dataset.py module, more particulary in the reindex method the tolerance argument is set to be a Number
https://github.com/pydata/xarray/blob/f08672847abec18f46df75e2f620646d27fa41a2/xarray/core/dataset.py#L2743
But the _reindex  function call  reindex_variable function. In the reindex_variable  the type for tolerance is Any. This function ends to call get_indexer_nd which call the pandas function get_indexer :
https://github.com/pydata/xarray/blob/f08672847abec18f46df75e2f620646d27fa41a2/xarray/core/indexes.py#L137
In pandas the type of tolerance according to the docs can be a scalar or a list-like object

[x] Tests added
[x] Passes pre-commit run --all-files
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Thanks a lot!
On the relevant test, could we please add -> None to the def? That will cause mypy to use the test to check the types.

Thank you too for your patience
@max-sixty I don't understand where to put the -> None
In the test function ?
https://github.com/pydata/xarray/blob/118a00b1233db34fe90072ed2e21501337b04b35/xarray/tests/test_dataset.py#L1886
How does mypy can test these types ?

def test_reindex_method(self) -> None:

Should do the trick.

Some typing errors now pop up now, now that we're testing it.
For a future PR, but I don't think .sel is being type-checked properly in tests either as it uses Number as well:
https://github.com/pydata/xarray/blob/4c865d607e6e03605b7050d9fb6991e86346bf08/xarray/core/dataset.py#L2446

Thank you @antscloud !


Refresh tokens, freshness pattern and scopes

This is a draft for feedback, and follows on from this discussion earlier in the year: https://github.com/fastapi-users/fastapi-users/discussions/350
I've made a first attempt here at implementing refresh tokens and the "freshness pattern" from fastapi-jwt-auth. It doesn't yet have any updates to docs, etc, as I'd like to get your initial input first.
Breaking changes
Any implementation of these features involves breaking changes to parts of the API. This is, unfortunately, inevitable because any solution will need to address these challenges:
Token metadata
It's no longer sufficient to determine whether a token simply exists for a given user and strategy, because we now also need to:

Determine a token's "fresh" status
Distinguish between an access token and a refresh token

For JWTStrategy this is straightforward (adding additional claims to the token), but for other strategies this requires non-backward-compatible changes. In this solution, that includes storing JSON in the Redis value for RedisStrategy and adding additional fields for DatabaseStrategy.
We also need to consider how to store and retrieve this metadata with the Strategy. For this I propose a Pydantic model, UserTokenData, which wraps the user object (conforming to UserProtocol) and its metadata. In this first draft I've created four metadata fields:

Field
Description

created_at: datetime
the UTC datetime when the token was issued

expires_at: Optional[datetime]
the UTC datetime when the token expires - this is no longer set by the Strategy but passed in by the AuthenticationBackend (see below)

last_authenticated: datetime
the UTC datetime when the user was last explicitly authenticated (not with a refresh token) - a token is considered "fresh" when created_at == last_authenticated

scopes: Set[str]
distinguishes between an access and refresh token, and can be extended for other purposes later

Token response model
It's now no longer sufficient for a Transport instance to receive a string as a token, as it now needs to process an access tokan and (optionally) a refresh token. In this draft I've created a model
class TransportTokenResponse(BaseModel):
    access_token: str
    refresh_token: Optional[str] = None

which replaces the previous str type expected by Transport.get_login_response.
Moving token lifetime to AuthenticationBackend
As access tokens and refresh tokens have different lifetimes - and this could be extended to other token types in future - I've proposed removing the token lifetime configuration from Strategy and instead setting it in AuthenticationBackend, as well as whether refresh tokens should be generated and accepted:
    access_token_lifetime_seconds: Optional[int] = 3600,
    refresh_token_enabled: bool = False,
    refresh_token_lifetime_seconds: Optional[int] = 86400,

New features
New refresh router
I've added an OAuth2-compatible token refresh router, get_refresh_router in refresh.py for processing refresh tokens.
New "fresh" keyword arg in Authenticator methods

The public methods in Authenticator now have a fresh: bool keyword arg, which, when true, will throw 403 Forbidden if the token is not fresh.
I've also added an additional method, current_token, for users who need to inspect the token metadata.

Scopes
I've borrowed the concept of OAuth2 scopes to distinguish between access tokens and refresh tokens, and I've also defined some additional scopes to distinguish between classes of users.

Enum
String
Description

SystemScope.USER
"fastapi-users:user"
An access token belonging to an active user

SystemScope.SUPERUSER
"fastapi-users:superuser"
An access token belonging to an active superuser

SystemScope.VERIFIED
"fastapi-users:verified"
An access token belonging to an active and verified user

SystemScope.REFRESH
"fastapi-users:refresh"
A refresh token

This could be developed further - for example, both system- and user-defined routes could have "required scopes" that restrict what routes a particular token is permitted to access. By adding user-defined scopes, this could be used as a basis for a general-purpose user permissions system.
Potential additional features
The following additional security measures might be valuable but would require additional work:

Preventing refresh token reuse: store the created_at datetime for the most recently used refresh token so that it (and any older refresh token) cannot be reused.
Refreshing OAuth2 tokens: on token refresh, refresh an associated OAuth2 token with the original provider if it has expired
Checking for revoked OAuth2 tokens: on token refresh, re-verify an associated OAuth2 token with the original provider

Open questions

How should CookieTransport handle the concept of refresh tokens? Currently it ignores them entirely.

Alternative ideas

This could be implemented in a non-breaking way by implementing it only for IWTStrategy and BearerTransport and having any use of refresh tokens / freshness with other strategies raise a NotImplementedError, but I do think it's possible that users will want this for other strategies and transports.
I also considered using separate strategies for access and refresh tokens by adding a get_refresh_strategy to AuthenticationBackend, but this adds additional complexity. If this is something that user feedback indicates would be likely to be used I could add it back in.

Feedback welcome
Please let me know whether this is heading in the right direction and what other changes / different approaches you might have in mind!

@frankie567 - would love your feedback on this before I proceed further!

Hi @jtv8! I appreciate your work here, but this seems really really huge changes.
I'll definitely have a look, because there are lot of good ideas here. However, I'll probably not merging the changes as if but rather reimplementing pieces by pieces — with proper credit for you for sure — so I can adapt things and better understand how to fit it in the big picture.

Yes, that makes sense! You might find it hard to chunk it up into very small changes because some classes/modules that are impacted are still quite tightly coupled - e.g. UserProtocol is used everywhere and changing it to another type has a lot of implications.
That said, if you want to implement it progressively I'd start with the ability to store token metadata - it's the hardest thing to change and it enables a lot of the other features here (and future ones as well).
One other thing to consider: for future extensibility, I also toyed with the idea of allowing storage of arbitrary key-value metadata for tokens. It would be simple enough to implement with the JWT and Redis strategies, but much harder with the database one. Serialising it as JSON and storing it in a large text field would be the simplest solution (but not the only one).


[Feature Request] Support Facebook Chat Extensions

Issue Description
Facebook allows to create chat extensions which in turn allow bots to join / interact with group chats. These are extensions to existing bots: https://developers.facebook.com/docs/messenger-platform/guides/chat-extensions
It would be great if we could add these chat extensions to our bot framework bots, even if they are Facebook only right now - other messengers might add the possibility for bots to chat with a group as well.

Closing this issue. Messenger feature requests are tracked here: #4360 (I've referenced this one there)


Replace CHECK() with CHECK_*() so that when a check is failing, more …

so that when a check is failing, more useful information is logged.
This PR affects only the CHECK() calls in cpp files.

Thanks for reviewing.
This was a super quick PR and incremental improvement. It seems to be more time consuming now. I will leave this PR here for now and come back when I have the time.


CLI crashes whilst creating fresh Ionic 2 project

Short description of the problem:
Tried to start a fresh ionic v2 project but ended up with error.
What behavior are you expecting?
To create a fresh Ionic v2 project.
Steps to reproduce:

ionic start projectName --v2

Post the output of ionic info below please
6.3.1
Gulp version:  CLI version 1.2.2
Gulp local:
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.0.0-beta.20
OS: Windows 8.1
Node Version: v4.4.5
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Error with start undefined
Error Initializing app: There was an error with the spawned command: npminstall

We recently released a new version of the CLI that should allow us to gather more insight into NPM issues.  Could you please update your CLI to at least 2.1.4?
npm install -g ionic@latest
Thank you!

Solved this issue by installing latest version of Cordova.


Update wireshark to 2.4.3

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Duplicate of https://github.com/caskroom/homebrew-cask/pull/41505
Thanks for the PR nonetheless.


Add RequestBuilder::pretty_json()

Allows sending prettified JSON body.
Sometimes it is useful and desirable to be able to send "pretty" JSON formatted body.
This PR adds this ability. It comes under "pretty-json" feature, but it (feature) can be dropped if this will prove to be generally useful.

Hm, do you have some examples where it'd be useful? Usually "pretty" JSON is for human convenience, and in my experience you usually want pretty JSON when debugging on a server, where you can already choose to log it in pretty format.

You're right, "pretty" is mostly for human consumption. Logging it from the server is easy if you control the server application. However, it is not always the case. For example, we are doing a lot of work with consul and storing there Rust objects, serializing them to JSON. Consul stores it as is. Having it prettified makes the debugging so much easier. Of course, there are always other ways of doing things, such as manually serializing structures and then adding it as a body and setting the appropriate header. But then reqwest provides RequestBuilder::json() exactly for the usability
purposes. So why not provide the pretty option as well?

I haven't really seen this option in other libraries, so I'm leaning towards it may not belong.

Oh, that's quite unfortunate.

Isn't it that "sending" prettified JSON would send a formatted string? I also haven't seen instances where a JSON payload is sent with whitespaces, as the receiving application would have to parse the JSON itself anyways

The use case that I am running into is a KV datastore. The JSON payload is just a value that KV store keeps and returns on demand. It doesn't interpret it in any way. When debugging, however, it makes a huge difference when the payload is nicely formatted as it is human who interprets it.

For the benefit of those looking for this sort of capability - this functionality is now available in the reqwest-pretty-json crate.


Deprecated CharSeq's split, replacing it with splitSeq

fixes https://github.com/javaslang/javaslang/issues/1252#issuecomment-213848494

Current coverage is 95.48%

Merging #1296 into master will increase coverage by +0.01% as of daa4050

@@            master   #1296   diff @@
======================================
  Files           83      83
  Stmts         9453    9455     +2
  Branches      1705    1705
  Methods          0       0
======================================
+ Hit           9025    9028     +3
+ Partial        109     108     -1
  Missed         319     319

Review entire Coverage Diff as of daa4050

Powered by Codecov. Updated on successful CI builds.

Let's just adjust the return type in a 3.0.0 branch as described here. That is a major design decision for the future development of Javaslang.

The 3.0 branch seems to be up to date already (i.e. a single split, returning a a Seq), only the 2.1 should be downgraded -- done in this commit.
Opinions @danieldietrich, @sajit, @ruslansennov, @jest?

@paplorinc deprecating the one and adding the other is ok for me. It is a good hint that it will change. 3.0 will clear it up. If no-one has another opinion I will merge (when I return to the keyboard in two hours or so)

Sorry about the unresponsiveness.. Had some family emergency.

Thx for reply


(GH-356) Improve Package view

The rendering of headings in description are larger then the headings of the Package view.
To improve the Package view the headings outside of the description have now the same font size and weight. Also the Icon and the Id are moved to the left side. The right side is now vertically stretched and can be scrolled if it's to large.

Closes #356

@punker76 your changes have been merged, thanks for your contribution 👍


hostnames with curly braces cause reqwest to panic

Providing a URL like "http://{}" currently causes reqwest to panic with:
thread 'reqwest-internal-sync-runtime' panicked at 'a parsed Url should always be a valid Uri: InvalidUri(InvalidUriChar)', src/libcore/result.rs:997:5

Here's a full repro:
use reqwest;
use std::error::Error;
use url::Url;

fn main() -> Result<(), Box<dyn Error>> {
    let url: Url = "http://{}".parse()?; // apparently this is parseable?
    println!("hostname: {:?}", url.host());
    let res = reqwest::get(url)?;
    println!("status: {}", res.status());
    Ok(())
}

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0b9d1cd06a3f823788c18a3d641b30a8
{} doesn't seem like a particularly valid hostname, so I'm going to investigate whether the fault really lies with the url crate. Wanted to post here in the meantime, though.

I think I have the same problem. A url which could be parsed but subsequently fails in reqwest:
thread 'thread 'reqwest-internal-sync-runtimereqwest-internal-sync-runtime' panicked at '' panicked at 'a parsed Url should always be a valid Uri: InvalidUri(InvalidUriChar)a parsed Url should always be a valid Uri: InvalidUri(InvalidUriChar)', ', src/libcore/result.rssrc/libcore/result.rs::997997::55

note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
thread '<unnamed>' panicked at 'event loop thread panicked', /home/manfred/.cargo/registry/src/github.com-1ecc6299db9ec823/reqwest-0.9.18/src/client.rs:687:5

I just got bitten by this too.
Apparently
https://${domain}${endpoint}/
Gets parsed as a valid URL by the url crate, and not by hyper, which causes reqwest to panic. Repro (not involving reqwest) below:
/*
[dependencies]
url = "2.2.1"
hyper = "0.14.4"
*/

use url::Url;
use hyper::Uri;
use std::str::FromStr;

fn main() {
    let problematic = "https://${domain}${endpoint}/";

    let url = Url::from_str(&problematic).expect("url::Url failed");
    let uri = Uri::from_str(&problematic).expect("hyper::Uri failed");
}

# panics with: thread 'main' panicked at 'hyper::Uri failed: InvalidUri(InvalidUriChar)', src/main.rs:9:43

RFC 1738 Section 2.2. names { and } as "unsafe" characters and that "All unsafe characters must always be encoded within a URL".
This tells me that this shouldn't really panic in reqwest, but rather escape the URL somehow before making a request. Perhaps the conversion here https://github.com/seanmonstar/reqwest/blob/c666b293a139d1d9d681115d1f5090622a240835/src/into_url.rs#L74 could be improved?
Or it might be an issue with url and/or hyper and how they treat the curly brace characters. 🤔

For comparison, the requests library for Python interestingly escapes the entire URL before sending the request:
In [6]: try:
   ...:     requests.get("http://{test}/{test}")
   ...: except Exception as e:
   ...:     print(e.request.url)
   ...:
http://%7Btest%7D/%7Btest%7D

@seanmonstar would you say this should be the desired behavior of reqwest too? I'm eager to contribute a PR.

And one more comment on this...
I have shuffled through current URL related standards:

IETF RFC 3986 ("Uniform Resource Identifier (URI): Generic Syntax")
WHATWG URL Standard

...and it seems that neither give { or } any special "global" treatment. In fact, the WHATWG standard is specific about which part of the URL should escape { and }: the path part.
Given all this, it seems that the url crate is doing the "right" thing by allowing such URLs, and correctly encoding the path part:
/*
[dependencies]
url = "2.2.1"
*/

use url::Url;
use std::str::FromStr;

fn main() {
    let url_curly_path = Url::from_str("https://httpbin.org/{endpoint}/").expect("url::Url failed");
    let url_curly_host = Url::from_str("https://{host}/{endpoint}/").expect("url::Url failed");
    println!("Curly path: {}", url_curly_path);
    println!("Curly host: {}", url_curly_host);
}

// prints:
Curly path: https://httpbin.org/%7Bendpoint%7D/
Curly host: https://{host}/%7Bendpoint%7D/

So this issue might be treated as a hyper crate bug (for not allowing an otherwise standards-compliant URL) or as a bug of reqwest itself (for not percent-encoding the URL passed on to hyper)... or actually, both.
Since @seanmonstar is the maintainer of both hyper and reqwest, I'd like your input here please :slightly_smiling_face: As I said, above, I'd be happy to contribute fixes.

RFC 3986 does seem to indicate { and } aren't allowed, technically:
  host        = IP-literal / IPv4address / reg-name
  reg-name    = *( unreserved / pct-encoded / sub-delims )
  unreserved  = ALPHA / DIGIT / "-" / "." / "_" / "~"
  sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
                    / "*" / "+" / "," / ";" / "="

At this point, I really don't love that there are so many different URL specs (and that the WHATWG spec is "living" makes it even more annoying to deal with). I'd probably lean towards defaulting to what curl does, whatever that is.


Fix a few Flow complaints we'd get with RN 0.63 and Flow 0.122.0.

The RN v0.63 upgrade issue is #4245. There'll likely be quite a bit more work to do for Flow when we get closer to doing that upgrade, but this is a start! 🎉

Hmm, that CI failure might be transient:
Running android...

(lots of Unimodules output)
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:mergeDebugAssets'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not download appcompat-1.1.0.aar (androidx.appcompat:appcompat:1.1.0)
      > Could not get resource 'https://dl.google.com/dl/android/maven2/androidx/appcompat/appcompat/1.1.0/appcompat-1.1.0.aar'.
         > Connection reset
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org

Thanks @chrisbobbe ! Small comments below; after taking care of them, please merge at will.

OK, done!


reference

# Duplicate of #
Originally posted by @longcrow in https://github.com/longcrow/github-slideshow/issues/1#issuecomment-985097161

@githubteacher

Closed for now


Run on ubuntu-latest by default

As per the sole commit:

It doesn't make sense to pin to an old version of Ubuntu as a default environment. Github Actions provides ubuntu-latest as an alias for the latest release. This commit updates the default to this alias.

 Upgrade CI environments

@allanlewis can the branch be deleted now? This repo doesn't have automatic deletion of head branches after merge.

Good spot - done.
@stucox Can you please update the repo config to delete branches automatically? Or I can do it myself if you make me an admin 😇


how to start without " pip install autotrain-advanced"

Dear,
Thanks for your work.
After installing through pip, running
autotrain llm --train --project_name my-llm --model luodian/llama-7b-hf --data_path . --use_peft --use_int4 --learning_rate 2e-4 --train_batch_size 12 --num_train_epochs 3 --trainer sft
can achieve fine-tuning on your own data.
If I want to run the project from source code for fine-tuning, which function should I start from?
That is, from which function do the autotrain and llm parameters come from?
Best,

Hey, the train function can be imported like this
from autotrain.trainers.clm import train
from autotrain.trainers.utils import LLMTrainingParams
training_config = <all the args go here as a dict>
config = LLMTrainingParams(
    model_name="gpt2",
    data_path=".",
    train_split="train_small",
    valid_split="valid_small",
    huggingface_token=HF_TOKEN,
    text_column="text",
    learning_rate=3e-3,
    num_train_epochs=5,
    use_peft=True,
    push_to_hub=True,
    use_int4=True,
    trainer="sft"
)
train(config)


mvn install is failing to push the Docker image

mvn install -Pdocker gives the following error:
[INFO] DOCKER> Credentials helper reply for "docker-credential-osxkeychain" is 0.6.0
[INFO] DOCKER> The push refers to repository [docker.io/arungupta/greeting]
[ERROR] DOCKER> Unable to push 'arungupta/greeting:latest' : Get https://registry-1.docker.io/v2/: x509: certificate is valid for *.reivernet.com, reivernet.com, not registry-1.docker.io  [Get https://registry-1.docker.io/v2/: x509: certificate is valid for *.reivernet.com, reivernet.com, not registry-1.docker.io ]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

@rhuss can you take a look at this?

Yes, will check latter. Are you using Docker for Mac ?
Are you behind a wifwall (e.g. something todo with reivernet.com ?)

Looks like that the Docker daemon gets not an answer from Docker hub but from somewhere else:

... certificate is valid for *.reivernet.com, reivernet.com, not registry-1.docker.io  ...

Yes, Docker for Mac
No firewall, just crappy hotel Internet. Here is the new error:
[ERROR] DOCKER> Unable to push 'arungupta/greeting:latest' : denied: requested access to the resource is denied  [denied: requested access to the resource is denied ]

So, the first error was because of the login screen of your Hotel Wifi was served when requesting the Docker Hub registry (99% sure here).
wrt. the new error:
$ docker login
Login with your Docker ID to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com to create one.
Username: rhuss
Password:
Login Succeeded

$ mvn -Pdocker -Ddocker.repo=rhuss package docker:push
.....
[INFO] --- docker-maven-plugin:0.25.0:push (default-cli) @ greeting ---
[INFO] DOCKER> The push refers to repository [docker.io/rhuss/greeting]
83379cf7dd94: Pushed
148268bf14be: Mounted from library/openjdk
6a47dae912f7: Mounted from library/openjdk
00439e7d6354: Mounted from library/openjdk
a1a8b7f7efac: Mounted from library/openjdk
341d865c1c22: Mounted from library/openjdk
61c06e07759a: Mounted from library/openjdk
bcbe43405751: Mounted from library/openjdk
e1df5dc88d2c: Mounted from library/openjdk
[INFO] DOCKER> latest: digest: sha256:9d8820e9dbe98827015fabed758b11f8a534dbd7c4f827d7698dcd3e4cf4e285 size: 2211
[INFO] DOCKER> Pushed rhuss/greeting:latest in 31 seconds
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33.794 s
[INFO] Finished at: 2018-04-13T15:21:33+02:00
[INFO] Final Memory: 20M/315M
[INFO] ------------------------------------------------------------------------

Did you do a docker login before ? Really no idea why it does not work you except your network setup. Please try a regular 'docker push', too.

Could you try to add the following to your ~/.m2/settings.xml :
<settings>
  <servers>
    <server>
      <username>arungupta</username>
      <password>plain password or encrypted</password>
      <id>docker.io/arungupta</id>
    </server>
    ....
  </servers>
  ....
</settings>

I suspect that it might be an issue with the credential helper which is used if this setting is missing. If you want to encrypt that password, please follow this mini guide --> https://maven.apache.org/guides/mini/guide-encryption.html
https://dmp.fabric8.io/#authentication has some more details what kind of authentication is tried in which order.
What Docker version are you using ? Mine is 18.03.0-ce-mac60 (23751)
I'm going to try now the credentials helper mode, too.

@arun-gupta good news, I can reproduce the error now. Going to fix this ASAP, should be done by the end of the weekend and you can expect a version 0.25.2 with a fix.

@arun-gupta how does your ~/.docker/config.json looks like ?
Could you please paste it here (without real password of course) ?
Mine looks like
{
        "auths": {
                "https://index.docker.io": {},
                "https://index.docker.io/v1/": {},
                "https://registry.fuse-ignite.openshift.com": {},
                "index.docker.io": {},
                "registry.fuse-ignite.openshift.com": {}
        },
        "HttpHeaders": {
                "User-Agent": "Docker-Client/18.03.0-ce (darwin)"
        },
        "credsStore": "osxkeychain"
}

Should be all fixed now with 0.25.2. Please check out the latest PR that I submitted to your projects.

Super excited to see this working for the first time:
[INFO] DOCKER> The push refers to repository [docker.io/arungupta/greeting]
c137ec485ebb: Pushing     [>                                                  ]  524.8kB/66.98MB
148268bf14be: Pushing     [==================================================>]  400.9kB
6a47dae912f7: Pushing     [>                                                  ]   1.61MB/392.5MB
00439e7d6354: Pushing     [==================================================>]  1.536kB
a1a8b7f7efac: Pushing     [==================================================>]  3.584kB
341d865c1c22: Waiting
61c06e07759a: Waiting
bcbe43405751: Waiting
e1df5dc88d2c: Preparing

What was the issue @rhuss?

Bingo, that explains the discrepancy!


Provide a way to create a Typesense client without IOptions

I could not find a way to create a Typesense client without the close coupling to IOptions and the whole Service Collection stuff. Is there no way in the API to simply pass in basic arguments like API Key and the host of the server directly to the Typesense Client?

Hi @isaacabraham,
You will always have to use the Options, I regret making it that way, but I don't want breaking changes so that is how it is now.
Here is an example of how to do it without using the service collection.
        var myConfig = new Config(
            new List<Node>()
            {
                new Node("myhost", "8000", "http")
            }.AsReadOnly(),
            "myKey"
        );

        using var myHttpClient = new HttpClient();

        var myTypesenseClient = new TypesenseClient(Options.Create<Config>(myConfig), myHttpClient);

// Rune

Thanks for the reply! I'm curious as to why this would be a breaking change - could an override be added to the constructor? This way, the existing codepath could remain, but the alternative would also be permitted.
Thanks :-)

@isaacabraham you're right it will only be a breaking change if I were to change the current constructor, it would be no issue with constructor overloading, I'll think about it and let you know what I decide on. :)

Actually it is a problem with constructor overloading, apparently the service collection cannot figure out there is a difference between the IOptions<Config> and the Config.
System.InvalidOperationException : Multiple constructors accepting all given argument types have been found in type 'Typesense.TypesenseClient'. There should only be one applicable constructor.
For now I'll leave it as it is, but I might reopen the issue in the future in case that I decide to make the breaking change.


Release v2.25.2

What's Changed
New Features 🎉

feat(doc-core): support for custom search runtime interception logic by @sanyuan0704 in https://github.com/web-infra-dev/modern.js/pull/4133
feat(doc-core): optimize runtime temp file structure by @sanyuan0704 in https://github.com/web-infra-dev/modern.js/pull/4138
feat(builder-cli): support register builder plugins by @chenjiahan in https://github.com/web-infra-dev/modern.js/pull/4123
feat(doc-core): support module doc search by @sanyuan0704 in https://github.com/web-infra-dev/modern.js/pull/4143
feat(builder): bump webpack v5.88, support top level await by @chenjiahan in https://github.com/web-infra-dev/modern.js/pull/4102
feat(doc-core): support preview for pages added in addPages hook by @sanyuan0704 in https://github.com/web-infra-dev/modern.js/pull/4094

Bug Fixes 🐞

fix(module-tools): fix error in concurrent copy when generate dts files. by @targeral in https://github.com/web-infra-dev/modern.js/pull/4139
fix(utils): incorrect ora & commander exports path by @targeral in https://github.com/web-infra-dev/modern.js/pull/4118
fix(app-tools): failed to print error stack by @chenjiahan in https://github.com/web-infra-dev/modern.js/pull/4135
fix(doc-core): support conventional route for tsx file by @sanyuan0704 in https://github.com/web-infra-dev/modern.js/pull/4094
fix(eslint-config): allow $ in filenames by @chenjiahan in https://github.com/web-infra-dev/modern.js/pull/4132
fix: should not clean dist path if run deploy command but skip build by @zllkjc in https://github.com/web-infra-dev/modern.js/pull/4110
fix(builder-plugin-swc): allow disabling styled-components by @JSerFeng in https://github.com/web-infra-dev/modern.js/pull/4124
fix(doc-core): throw error when ssr failed by @sanyuan0704 in https://github.com/web-infra-dev/modern.js/pull/4111
fix(builder): failed to set publicPath function by @chenjiahan in https://github.com/web-infra-dev/modern.js/pull/4136
fix: support configuration ts-node and avoid to register ts-node unnecessarily by @yimingjfe in https://github.com/web-infra-dev/modern.js/pull/4100
fix(ssr-plugin): worker streaming ssr douable enqueue the value so that ssr error by @GiveMe-A-Name in https://github.com/web-infra-dev/modern.js/pull/4121
fix(doc-core): ssg fallback by @sanyuan0704 in https://github.com/web-infra-dev/modern.js/pull/4137

Docs update 📄

docs(main-doc): fix wrong links and add missing files by @targeral in https://github.com/web-infra-dev/modern.js/pull/4116
docs(module-tools): add faq content and slots components by @targeral in https://github.com/web-infra-dev/modern.js/pull/4118

Other Changes

chore(rspack-provider): update rspack to 0.2.5 in https://github.com/web-infra-dev/modern.js/pull/4131

更新内容
新特性 🎉

feat(doc-core): 支持自定义搜索运行时拦截逻辑 由 @sanyuan0704 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4133
feat(doc-core): 优化运行时临时文件结构 由 @sanyuan0704 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4138
feat(builder-cli): 支持注册 builder 插件 由 @chenjiahan 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4123
feat(doc-plugin-api-docgen): 支持模块文档的搜索 由 @sanyuan0704 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4143
feat(builder): 升级 webpack v5.88, 支持 top level await 由 @chenjiahan 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4102
feat(doc-core): 支持为 addPages 钩子新增的页面添加预览功能 由 @sanyuan0704 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4094

Bug 修复 🐞

fix(module-tools): 修复在生成类型文件的时候并发复制产生的错误 由 @targeral 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4139
fix(utils): 修复错误的 ora & commander 导出路径 由 @targeral 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4118
fix(app-tools): 修复 build 报错时未打印错误堆栈的问题 由 @chenjiahan 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4135
fix(doc-core): 支持 tsx 文件的约定式路由 由 @sanyuan0704 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4094
fix(eslint-config): 允许文件名包含 $ 符号 由 @chenjiahan 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4132
fix: 如果运行 deploy 命令，但是跳过构建阶段，不应该清理产物目录 由 @zllkjc 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4110
fix(builder-plugin-swc): 允许用户关闭 styled-components 由 @JSerFeng 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4124
fix(doc-core): ssr 失败时抛出错误 由 @sanyuan0704 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4111
fix(builder): 修复设置 publicPath 函数时报错的问题 由 @chenjiahan 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4136
fix: 支持配置 ts-node，避免对 ts-node 不必要的注册 由 @yimingjfe 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4100
fix(ssr-plugin): worker streaming ssr 重复 enqueue chunk 值导致 ssr 错误 由 @GiveMe-A-Name 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4121
fix(doc-core): ssg 阶段报错时的兜底处理 由 @sanyuan0704 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4137

文档更新 📄

docs(main-doc): 修复错误的链接，补充缺失的文件 由 @targeral 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4116
docs(module-tools): 添加 FAQ 内容以及插槽插件 由 @targeral 实现， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4118

其他变更

chore(rspack-provider): 升级 rspack 相关依赖到 0.2.5， 详情可查看 https://github.com/web-infra-dev/modern.js/pull/4131

Codecov Report
Patch coverage has no change and project coverage change: +0.18 :tada:

Comparison is base (34ca0bb) 57.31% compared to head (4d1d146) 57.49%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   57.31%   57.49%   +0.18%
==========================================
  Files         622      647      +25
  Lines       15995    17661    +1666
  Branches     3405     3854     +449
==========================================
+ Hits         9167    10154     +987
- Misses       6303     6873     +570
- Partials      525      634     +109

see 713 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix distill darkmode

Fixing the issue with distill darkmode #298
I found out that the problem emerges with numerated lists, table entries, inline math equations, blockquotes (see also #280 ), footnotes, citations, hovering boxes and code highlights. Seems to be fixed now, take a look on al-folio/blog/2021/distill/ when building locally, or online on my page: here
Let me know if something is missing. Cheers!

Thanks so much for fixes!

Fixes #298
(comment to link pr to issue)

@ivanpuhachov, just realized you made changes to assets/js/distillpub/template.v2.js. Thanks for taking the effort!
I'm wondering, would it be hard to factor out these style changes into _sass/_distill.scss instead of directly editing the template.v2.js? The reason is that template.v2.js is currently auto-generated from the al-folio branch of my fork of distillpub template (later, I'm thinking of switching to loading template.v2.js directly from https://distill.pub/template.v2.js). So, I'd strongly prefer treating template.v2.js as read-only and make changes by overriding functionality.

The problem is that template.v2.js automatically generates style properties for created items and stores them right in the cell (see, i.e. line 1374 in template.v2.js). I tried to override them with scss file and !important flag but I did not succeed. Is there another method to do so? I can try

You are right, it looks like most of distill is written using web components that encapsulate styles using shadow DOM. The styles inside shadow DOM cannot be overridden from outside using CSS, unfortunately (see discussion here). But, these styles can be overridden using javascript without directly modifying template.v2.js.
I added assets/js/distillpub/overrides.js that overrides d-footnote and d-cite styles. Would you mind reverting your changes in template.v2.js and using this method instead?

Great. Will do!

Done!


In SzAbstractFactory change from createSz* to create*

See https://github.com/senzing-garage/sz-sdk-go/issues/194

Pull requests:

https://github.com/senzing-garage/go-rest-api-service/pull/254


[BEAM-10529] enable nullable for kafkaIO xlang

Leverage the new nullable coder to enable the nullable coder for kafkaIO xlang.
For the commiter: please squash these commits when merging.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

R: @chamikaramj

Thanks. LGTM.
We should verify that the WriteToKafka can write null keys as well (though I don't see an explicit change needed here to support that).

Ah, I should have done "squash and merge" here :(
For future reference, please merge commits into one or few commits for which you care about maintaining commit history.

Ah, will do that in the future


Improve general usage printing

Improvements

[x] Whenever groups are listed, also print this info:

Run 'swarm-cli GROUP --help' to see available commands in a group

[x] Whenever commands are listed, also print this info:

Run 'swarm-cli COMMAND --help' for more information on a command

[x] When only swarm-cli is called, also print a headline, eg.:

swarm-cli v0.6.1 - Manage your Bee node and interact with the Swarm network via the CLI

[x] When only swarm-cli is called, do not print error message

[x] When groups are called without commands, do not print error message

[x] When help is printed for a specific command, include an usage part, eg.:

█ Usage:

swarm-cli feed upload <path> [OPTIONS]

[x] When commands are called without any options and arguments BUT they require an argument, print usage instead of the error message

Mockup

Also it would be nice if running the command without arguments would not print an error.

@agazso I see two options.
Just removing the error message and printing like if it was called with --help.
Or printing a concise info on the command, something like this:
█ swarm-cli upload :: Upload file to Swarm

Usage: `swarm-cli upload <file> [options]`

For complete reference, see: `swarm-cli upload --help`

@agazso I see two options.

I'm fine with both options.

@agazso I have created a checklist in the original post. Can you please approve these changes before I finish up the implementation?
@nugaon Can you please also take a look and leave feedback? Thanks!

@agazso I have created a checklist in the original post. Can you please approve these changes before I finish up the implementation?

Looks good!

Group Scope


[DOCS] add benchmark log format doc

Adds benchmark log format as discussed in
https://discuss.tvm.ai/t/rfc-benchmark-performance-log-format/4610
https://github.com/apache/incubator-tvm/issues/4304
@tqchen
@u99127 since you expressed interest in getting your two cents in -- above github issue #4304 is more readable

@u99127 would be great if you can bring the proposed changes to the RFC discussion. Given that this is a proposal for standard among the community, it is important that all the field changes leaves a trace of discussion, Thanks!

Thanks @u99127 @anwang2009 !


Update Ubuntu images to 19.10

Ubuntu 19.04(disco) has already reached EOL, this replaces them with 19.10(eoan).

r? @gnzlbg
(rust_highfive has picked a reviewer for you, use r? to override)

19.10(focal)

I guess it's eoan?

I guess it's eoan?

Yeah, you're right!

Notes:

mips64el-unknown-linux-gnuabi64 and mips-unknown-linux-gnu remain Ubuntu 19.04 since their gcc packages have been gone. Left FIXME comment.
ignores sys/io.h on *-gnuabihf
ignores sys/sysctl.h on *-gnu since it has been deprecated
ignores statx and statx_timestamp since somehow headers aren't included correctly. Left FIXME comment.

Actually, it blocks #1638 and CI improvements only, skipping some items though, so going to merge. If anyone finds any fallout, just let me know!


Chore: add yaml context test

Add the test form yaml context body
Noticed that some of these were in the wrong order

Also this is based on the xml PR #99
Cheers

Nice work!
Please rebase because #99 has been merged and i causes conflicts

Thanks again @dylanhitt !


[MTN] Docker nightly

Closes #61

Changes proposed in this pull request:

docker nightly build
compose for app and UI
troubleshooting in the readme

Checklist
This section is for the PR reviewer

[ ] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[ ] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

@rmanaem I think I don't have the permission to add or see the secret variables in the repository needed for the CI workflow. Are they already set or can you set them?


[AFD WAF] Add defaultState and defaultAction to managed rule set definitions

Overview

Add defaultAction and defaultState to managed rule set definitions
No API version change since only impact is to read-only API

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[X ] I have reviewed the documentation for the workflow.
[X ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[X ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Can one of the admins verify this patch?


Changes to backend.tf to invoke S3/dynamodb locking

This is to add the line git push --set-upstream origin feature/S3-locking-all-envs to all the backend.tf files to force locking on the dynamodb table to stop multiple changes to the terraform.tfstate file if PRs are invoked at the same time on a particular environment.

Comment - removed the environments which would not plan successfully when undertaken manually. Listed in the #2609

Added core-network-services, core-shared-services and mi-platform following resolution of the S3 issue listed


After connecting a database the application fails to build

Describe the bug
This is an excellent tool up until I asked it to connect the frontend to a database. After following the required steps by creating the supabase account and filling in the api key and url and running the sql code in supabase the applications fails to build.
I have asked the AI to fix the build issues over 5 times and it still cant.
Link to the Bolt URL that caused the error
https://bolt.new/~/bolt-nextjs-shadcn-a8ustm
Steps to reproduce
Try build the application
Expected behavior
The build application must work
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
performance.memory = {
  "totalJSHeapSize": 106997279,
  "usedJSHeapSize": 101083307,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = mzasmal
Chat ID = 4fb0621c057a

Additional context
Error:
An unknown error occured while running an action.

Is this on your roadmap or am i doing something wrong. I dont need the problem fixed, I just want to plan and need to know how to proceed and when to come back here


KAFKA-17409: Remove deprecated constructor of RecordMetadata

As title,
Remove deprecated constructor of org/apache/kafka/clients/producer/RecordMetadata.java
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@xijiu could you please rebase code to have latest github CI :)

@xijiu could you please rebase code to have latest github CI :)

@chia7712  Sure, I have rebased the branch.


sblast: init at 0.7.0

project homepage: https://github.com/ugjka/sblast
project license ("MIT+NoAI", which seems to map onto nixpkgs' unfree): https://github.com/ugjka/sblast/blob/main/LICENSE

About the package
sblast is a CLI tool to cast your pulseaudio or pipewire system audio to any DLNA renderer, for example, your T.V.
the audio stream is pulled by the DLNA renderer from the host machine's port 9000, so one must open that in the firewall
networking.firewall.allowedTCPPorts = [ 9000 ];

usage is like:
$ sblast -source blast.monitor

then follow the prompts to select which device to cast to, and then launch a media player or some audio source, and ensure it's routed to the pulseaudio blast device. some devices require additional blast flags in order to understand the audio stream, such as blast -usewav [...]
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

renamed and rebased


Improve typing around untyped callables attributes.

How would this feature be useful?
Currently in nox there are quite a few callables with untyped attributes. For example; nox._parametrize.generate_calls assigns param_spec to a Callable[..., Any], thus losing it's type and causing errors. This along with what seems like another one or two decorators, with custom attributes, are causing large amounts of # type: ignores.
I would like to change the code to be able to remove these # type: ignores that are cluttering up the place, and making mypy less reliable.
Describe the solution you'd like
I would like to change these decorators from function decorators to class decorators.
Take for example the following as a rewrite of nox._parametrize.generate_calls:
class Call:
    def __init__(self, func, param_spec):
        self._func = func
        self.param_spec = param_spec
        self.session_signature = "({})".format(param_spec)

    def __call__(self, *args, **kwargs):
        kwargs.update(self.param_spec.call_spec)
        return self._func(*args, **kwargs)

    @classmethod
    def generate_calls(cls, func, param_specs):
        return [
            functools.wraps(func)(cls(func, param_spec))
            for param_spec in param_specs
        ]

Describe alternatives you've considered
An alternate is to utilize typing.Protocol available in Python 3.8. With the backport typing_extensions.Protocol working in everything except Python 3.5.0. This would mean adding typing_extensions as a requirement.
If you don't know what it is, then they're a means of defining an interface. It would look something like:
class Call(Protocol):
    param_spec: Any
    session_signature: str

    def __call__(self, *args: Any, **kwargs: Any) -> Any:
        ...

def generate_calls(
    func: Callable[..., Any], param_specs: Iterable[Param]
) -> Call:
    ...

When implementing I'd try to find the actual typings rather than just discard them with those tasty Anys. They're merely as proof of concepts.
Currently my typing skills with Protocol are sub-par. However I would prefer an explicit class as it allows me to more easily navigate the code and find what's doing what. It also means that later code can be expanded upon without mutating an instance of a function.
I would like to mention that I've not looked any more than skin deep on this issue. And so a resolution with either, may require more than just changing a function decorator to a class decorator or using a protocol.
Would you like this as a change? Would you like one of the above solutions, or is there a better way?

Your approach seems fine to me!


Issue with actOnChange() function on master branch

The build on Master is broken, due to an issue with the actOnChange function
This is fixed with pull request #106. This further builds on @blargity's request that actOnChange get refactored. That refactor is coming soon and should help solve these constant merge issues.

I used to test every single PR before merging but then realised I was spending 8 hours a night just merging. I'll love it when we can get this pulled out so working on a feature is just working on that feature.
I really appreciate your help with the merging too, so thank you! :+1:

Alrighty, all merged, test at will sailor!

Seems okay, will close this one.


Blog week 9 2020

I'm going to cherry pick your commit, do the edits myself, and then provide a new entry for this wekk.


 Could you give me some advises on how to solve this ?
Really Thank you for your time and guidance ~

I solve this problem by set eos token in tokenizer, solve

Hi, can you elaborate on your solution, I also used the new model for SFT on LLAVA, and the eos token I set to True was automatically set back to default during fine tuning, and I got this error:
WARNING: tokenization mismatch: 198 vs. 200. (ignored)
But it's still fine-tuning, it doesn't stop, but the loss display is always 0.0

I solve this problem by set eos token in tokenizer, solve

I am a newbie. Can you tell me where in which file to add eos? Thank you very much!

I solve this problem by set eos token in tokenizer, solve

I am a newbie. Can you tell me where in which file to add eos? Thank you very much!

https://huggingface.co/meta-llama/Meta-Llama-3-70B/discussions/6/files#d2h-846292     }
},
"bos_token": "<|begin_of_text|>",
"add_bos_token": true,
"add_eos_token": false,
"chat_template": "{% set loop_messages = messages %}{% for message in loop_messages %}{% set content = '<|start_header_id|>' + message['role'] + '<|end_header_id|>\n\n'+ message['content'] | trim + '<|eot_id|>' %}{% if loop.index0 == 0 %}{% set content = bos_token + content %}{% endif %}{{ content }}{% endfor %}{{ '<|start_header_id|>assistant<|end_header_id|>\n\n' }}",
"clean_up_tokenization_spaces": true,
"eos_token": "<|end_of_text|>",
"attention_mask"
],
"model_max_length":<PHONE_NUMBER>000000019884624838656,
"tokenizer_class": "LlamaTokenizer" file is called [tokenizer_config.json]


Interactive Window escapes XML tags shown through exceptions

Environment data

VS Code version: 1.33.1
Extension version:  2019.4.12954
OS and version: Windows 10 1809 (also reproduced in Ubuntu)
Python version: 3.6.4
Jupyter Notebook: 5.7.8

Expected behaviour
Writing this in a Python Interactive Window:
raise Exception("<whatever>")

Should show a traceback where the last line is:
Exception: <whatever>

Actual behaviour
[1] raise Exception("<whatever>")
---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
 in
----> 1 raise Exception("")

Exception:

Annoyance
This means one can not show a type in error messages, like:
raise TypeError("Type={}".format(type(32)))

Where the output should end with:
TypeError: Type=<class 'int'>

Jupyter does the correct thing here:

That's correct. It's only in the Python Interactive Window I've seen this behaviour.

We don't have plans to fix this.

Validated.


Improve documentation for creating graphs to use in StellarGraph

Description
Currently the documentation does not give much information about how to create graphs for use with StellarGraph.  Homogeneneous graphs are straighforward and have many demos showing their use. However, heterogeneous graphs are more difficult and we do not have clear demos that cover all uses.
In particular, we don't demonstrate how to create a graph with multiple edge types occuring between nodes (a nx.MultiGraph needs to be created) or that we can use a nx.Graph if there are multiple types of nodes but one type of edge.  Additionally, more information on how stellargraph obtains the node & edge types would be good.
We should add a section in the documentation describing creating graphs for use with stellargraph. This can have the following content:

Creating homogeneous graphs (supported by GraphSAGE, GCN, GAT, node2vec)
Creating heterogeneous graphs (supported by HinSAGE, metapath2vec)

Graphs with multiple node types
Graphs with multiple edge types

User Story
As a: new user
I want: to create a homogeneous or heterogeneous graph
so that: I can use the graph ML algorithms in stellargraph
Done Checklist

[ ] Assumptions of the user story met
[ ] Documentation in repo
[ ] CHANGELOG.md updated

This requires a fresh look once #662 is complete.

@huonw I think this may already be addressed by your changes for #723?

I think so: https://stellargraph.readthedocs.io/en/latest/api.html#stellargraph.core.StellarGraph
Now starts with a homogeneous graph, and then demonstrates a heterogeneous graph with multiple node types, one with multiple edge types, and one with both.


fix refine row count estimation for mark join

Proposed changes
Issue Number: close #xxx
Current semi/anti stats estimation doesn't consider the mark join case, whose row count should follow either side's stats without change.

run buildall

run buildall


[router] 4.11 New auction validation

This finding highlights a collection of issues with the handleNewAuction. The code and coding style appears fragile. Validation should be strictly enforced, debugging code should be removed or disabled in production and protective measures should be taken from abusive clients.

Missing validation:

Check zero-value bids (i.e. make sure there is profit for the router).

https://github.com/connext/nxtp/pull/178


Traitlets update from python not propagated to anywidget javascript

Describe the bug
I made an anywidget and while updates from js to js work, updates from python to js are not (while they are working in jupyter).
NB: besides, it is probably normal but if not "wrapped" with mo.ui.anywidget, updates from js also do not cause cell rerun in marimo neither (but such concept does not exist in jupyter).
Environment
(also tested with older versions)
{
  "marimo": "0.8.0",
  "OS": "Linux",
  "OS Version": "6.5.0-26-generic",
  "Processor": "x86_64",
  "Python Version": "3.10.12",
  "Binaries": {
    "Browser": "--",
    "Node": "v20.16.0"
  },
  "Requirements": {
    "click": "8.1.7",
    "importlib-resources": "5.12.0",
    "jedi": "0.19.1",
    "markdown": "3.6",
    "pymdown-extensions": "10.8.1",
    "pygments": "2.18.0",
    "tomlkit": "0.12.5",
    "uvicorn": "0.29.0",
    "starlette": "0.37.2",
    "websockets": "12.0",
    "typing-extensions": "4.12.0",
    "ruff": "0.0.292"
  }
}

Code to reproduce
import marimo as mo
import anywidget
import traitlets

### The anywidget example, with an additional traitlets 'msg' (but counter.count = 123  does not trigger js update either)
class CounterWidget(anywidget.AnyWidget):
    _esm = """
    function render({ model, el }) {
      const button = document.createElement("button");
      const update = () => {
          button.innerHTML = `${model.get("msg")} ${model.get("count")} (${Math.random().toFixed(3)})`;
      };
      button.addEventListener("click", () => {
        model.set("count", model.get("count") + 1);
        model.save_changes();
      });
      update();
      model.on("change:count", update);
      model.on("change:msg", update);
      el.classList.add("counter-widget");
      el.appendChild(button);
    }
    export default { render };
    """
    _css = """
    .counter-widget button { color: white; font-size: 1.75rem; background-color: #ea580c; padding: 0.5rem 1rem; border: none; border-radius: 0.25rem; }
    .counter-widget button:hover { background-color: #9a3412; }
    """
    count = traitlets.Int(0).tag(sync=True)
    msg = traitlets.Unicode('').tag(sync=True)

counter = CounterWidget(count=42, msg='count is')

# none of these 3 versions give an update when the next cell is run
#V1:
counter = mo.ui.anywidget(counter) # wrapping (NB: allows counter.value['count'] to work)
counter
#V2:
#mo.ui.anywidget(counter) # wrapping for display, not for the following setter
#V3:
#counter # not wrapping

counter.msg = 'Count:' # would expect to trigger button update

counter.value['msg'] = 'C is' # this one does not either

counter.value['count'] # (auto reruns if wrapped) (ok)

counter.count # (auto reruns too) (ok)

This is indeed a bug - I can look into this.
@manzt, whats the best approach to sync Py with Js?
should i add my own observers to each traitlet? it seems like like widget.on_trait_change is deprecated.

@manzt, whats the best approach to sync Py with Js?

Hmm, I think I'm missing some context. I haven't look closely at the Python side of mo.ui.anywidget, but it looks like you are swapping in a custom comm, and assignment:
counter.msg = "count:"

Should trigger a publish_msg call since msg is sync=True

Happy to find a time to pair if that would help!

I wonder if this proxying is causing an issue with the underlying behavior of the getters/setters:
https://github.com/marimo-team/marimo/blob/beccc28ccada25923bcf897a80a8c1e028c51adc/marimo/_plugins/ui/_impl/from_anywidget.py#L156-L158

It is possible the proxying is causing the issues. My custom comm may be missing some implementation details too.
It would be great to pair with you, ill message you on Discord.

:heart:


Create a common SSM param for /unity/cs/account/network/certificate-arn

SSL Cert to use for things like load balancers (this needs to be provisioned during account inflation). I think we'll need an SSM parameter that hosts this identifier to use when creating a load balancer (e.g. certificate_arn)
/unity/cs/account/network/certificate-arn
should be added to common ssm script used in MC startup

@mike-gangl I'm working on this ticket now.  What is the best way to determine the value for this?  Also, this is independent of project/venue, right?  I went into ACM on Unity-Venue-Dev, and I didn't see any entries.


Updated storybook to 6.2.9, isolated paramater usage to status, css fix and typesafety

NB - damn package-lock.json - I actually slimmed code down a bit :-D
React updated to 17.0.2 (there will be a legacy warning from @storybook/api - but it is not a problem)
Storybook packages updated to 6.2.9
Code using hooks from 6.2.9
Parameters changed (now only uses the one slot available for one addon)
Supports global -> story configuration  of statuses
Added "releaseCandidate" to default types
Added "stable" to default types
Camel cased types will be converted to words (releaseCandidate -> release candidate)
Much simpler CSS (and IMO more tidy/tight)
Parameter proposal in this PR - change is propose because before 3 parameter keys was being used.
This also lets the addon pipe into the whole global into story parameter merging Storybook handles automatically.
preview.js
parameters: {
  status: {
    statuses: {
      custom: {
        color: '#ffffff',
        background: '#000000',
        description: 'Some new tag'
      }
    }
  }
}

MyComponent.stories.js
export default {
  title: 'MyComponent',
  component: MyComponent,
  parameters: {
    status: {
      type: 'custom',
      url: 'http://www.someurl.com/url.html',
    }
  }
}

Should have a new image for the screenshot in the README.md
It looks like this now

Thanks Igor, sorry it took a while to review, I had completely missed this one!

No worry mate
I like the addon and want to use it 😄
Thanks!
man. 14. jun. 2021 kl. 17.47 skrev Gavyn McKenzie @.***

:

Thanks Igor, sorry it took a while to review, I had completely missed this
one!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/etchteam/storybook-addon-status/pull/19#issuecomment-860791573,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPC5MV6F5NKZCKKOOJM3PLTSYQBXANCNFSM45VNZXZQ
.

Thanks Igor, sorry it took a while to review, I had completely missed this one!

No worry man - had one dormant for 2 months myself 😄
Hope it was useful