Keeps asking for microphone permission (macOS)

When I try to host (or join) a new session, the app keeps asking me for microphone permission +10 times (even though I say "Allow").
macOS 14.6.1 (23G93)
Bananas: 0.0.9
Here's a video showing it.
https://github.com/user-attachments/assets/5effa941-372a-448a-860d-6e1763f6aa13

My best friend already confirmed this "bug". I'm not really seasoned in MacOS and don't have a mac with me atm.
Can you try to run Bananas from the CLI with sudo, so we can make sure it's not some weird permissions thing in MacOS?

Can you try to run Bananas from the CLI with sudo, so we can make sure it's not some weird permissions thing in MacOS?

I have just tried. It's the same outcome.

Can you try the v0.0.10 release?

Can you try the v0.0.10 release?

Same issue for me on v0.0.10.

Strange. #5 mentions that it works on MacOS 15, so either it's really related to MacOS 14 or some other Settings Voodoo in MacOS :thinking:

Probably an issue due to the app being unsigned:
See also: https://github.com/jitsi/jitsi-meet-electron/issues/611
This might be a temporary fix: codesign --force --deep --sign - /Applications/Bananas.app until I implement signing in the CI.

@gorillamoe I just run the command you shared above, Now it keeps popping up for Screen Recording permission again and again which is already allowed

Tried executing using sudo, error is pasted below:
sudo "/Applications/bananas.app/Contents/MacOS/bananas"
[52104:1129/120433.728953:ERROR:vt_video_encode_accelerator_mac.mm(965)] Call NotifyErrorStatus(): code=7, message=VTCompressionSessionCreate failed: Error Domain=NSOSStatusErrorDomain Code=-12902 "(null)"
(node:52101) UnhandledPromiseRejectionWarning: Failed to get sources.
(Use `bananas --trace-warnings ...` to show where the warning was created)
(node:52101) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:52101) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
(node:52101) UnhandledPromiseRejectionWarning: Failed to get sources.
(node:52101) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)

More verbose trace from my MBP (M3 max, 15.1.1 (24B91)):
sudo "/Applications/bananas.app/Contents/MacOS/bananas" --trace-warnings
[55401:1129/124126.685381:ERROR:vt_video_encode_accelerator_mac.mm(965)] Call NotifyErrorStatus(): code=7, message=VTCompressionSessionCreate failed: Error Domain=NSOSStatusErrorDomain Code=-12908 "(null)"
2024-11-29 12:41:26.909 bananas Helper (Plugin)[55405:1453056] WARNING: AVCaptureDeviceTypeExternal is deprecated for Continuity Cameras. Please use AVCaptureDeviceTypeContinuityCamera and add NSCameraUseContinuityCameraDeviceType to your Info.plist.
(node:55400) UnhandledPromiseRejectionWarning: Failed to get sources.
    at emitUnhandledRejectionWarning (node:internal/process/promises:300:15)
    at warnWithErrorCodeUnhandledRejectionsMode (node:internal/process/promises:406:5)
    at processPromiseRejections (node:internal/process/promises:470:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
    at node:electron/js2c/browser_init:2:19031
    at new Promise (<anonymous>)
    at Object.getSources (node:electron/js2c/browser_init:2:18708)
    at Function.<anonymous> (/Applications/bananas.app/Contents/Resources/app.asar/out/main/index.js:197:30)
(node:55400) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:55400) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
    at handledRejection (node:internal/process/promises:280:23)
    at promiseRejectHandler (node:internal/process/promises:190:7)
(node:55400) UnhandledPromiseRejectionWarning: Failed to get sources.
    at emitUnhandledRejectionWarning (node:internal/process/promises:300:15)
    at warnWithErrorCodeUnhandledRejectionsMode (node:internal/process/promises:406:5)
    at processPromiseRejections (node:internal/process/promises:470:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
(node:55400) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)

I am not a mac developer but looks like entitlements.mac.plist needs more perms? Maybe these?
    <key>com.apple.security.screen-capture</key>
    <true/>
    <key>com.apple.security.temporary-exception.screen-capture</key>
    <true/>
    <key>NSCameraUseContinuityCameraDeviceType</key>
    <true/>
    <key>com.apple.security.cs.disable-library-validation</key>
    <true/>

Have you also tried this?
https://github.com/mistweaverco/bananas/discussions/11#discussioncomment-11410375
Seems to work for some users.
It's really cumbersome and irritating, but seems to be related to the app not being signed and notarized.
I'll try to set up the CI so that it gets signed and notarized, but in the meantime you can try the above method?

I tried to Google that and it seems that Bananas tries to read from a Continuity Camera, which might be a connected iPhone.
You're right, Bananas' plist does not have the requirements to read from your iPhone and it shouldn't.
I need to figure out if this is really the case and if so, how to exclude this kind of devices.

Have you also tried this?
#11 (comment)
Seems to work for some users.
It's really cumbersome and irritating, but seems to be related to the app not being signed and notarized.
I'll try to set up the CI so that it gets signed and notarized, but in the meantime you can try the above method?

I did, yes, the app does open up okay but continues to ask for perms (despite enabling those in settings > privacy & security). I don't think the continuity camera perms (or any camera perms) should be necessary (unless you want to support video chats?). Arguably the only perms required should be limited to:

screen capture
microphone

I don't think the continuity camera perms (or any camera perms) should be necessary (unless you want to support video chats?)

That's definitely planned, but optional, therefore I added this in advance 🙈 did not think it would cause this much trouble 😞

I don't think the continuity camera perms (or any camera perms) should be necessary (unless you want to support video chats?)

That's definitely planned, but optional, therefore I added this in advance 🙈 did not think it would cause this much trouble 😞

It's all good, we are all devs here and understand deployment pains :)
Just my $0.02, don't even bother with video support until like semver 2.0.0 lol. Make the core functionality rock solid for v1.0.0 (when you get there) and then think about video (or other fancy features).

Just my $0.02, don't even bother with video support until like semver 2.0.0 lol. Make the core functionality rock solid for v1.0.0 (when you get there) and then think about video (or other fancy features).

New version v0.0.11 rolling, removed the microphone permissions on macos. Hopefully this fixes the issue.

Hello  @gorillamoe just tried 10min ago, the app keeps asking me for microphone permission exactly 10 times (and not working at the end) on a macbook pro 2021 on Sonoma 14.4.1 (23E224)

I've successfully set up the CI so that new release will get signed a notarized by Apple.
Only Problem seems to be, that notarizing the application takes a really long time at the moment. I read about people having similar problems with that process taking up to 3 days...
So I'll try a new release tomorrow during the day.
This process might fix the issue with some people having these issues with continuous permission requests, even if already allowed. At least that is what also happened to the Jitsi project and they also seem to have fixed it by signing and notarizing their app.

Good luck 🍀

this has been fixed in v0.0.12

this has been fixed in v0.0.12

Yes, should be, I've added a webhook for validating once Apple has approved the notarizing process, but not yet live, have to make anohter release so we can see if Apple really approves the app.

Tester already confirmed it working now.


Write missing tests for actionCreators/templates.js

loadResourceTemplateWithoutValidation is new function added with RP #2326 and needs testing.

@justinlittman looks like you've been refactoring the actionCreators and have touched this actionCreator and the test after this ticket was created. Is this still an issue, and if so can you say what is missing from the test? I cannot clearly see what else might be needed.

I think all necessary tests have been written.


vector: 0.31.0 -> 0.32.1

Description of changes
a simple update that also fixes a regression introduced in 0.31.0
The upgrade should be painless
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

It looks like the patch needs to be updated.
> applying patch /nix/store/0ajg01j3d8gvicrxylkz6w2mi6cn813a-rust-1.71-unnecessary-mut.diff
       > patching file lib/vector-core/src/tls/incoming.rs
       > Reversed (or previously applied) patch detected!  Assume -R? [n]
       > Apply anyway? [n]
       > Skipping patch.
       > 2 out of 2 hunks ignored -- saving rejects to file lib/vector-core/src/tls/incoming.rs.rej

@natsukium the patch just needed to be removed, thanks!
I'm going to wait for ofborg to finish just to make sure if that is fine with you.

Result of nixpkgs-review pr 250588 run on x86_64-linux 1

1 package failed to build:

vector

I've checked a bit more the problem and it seems that with the latest release, they are patching the source of openssl in order to use 3.1 instead of 1.1
cargo doesn't like that with vendored dependencies.
I've opened https://github.com/vectordotdev/vector/issues/18339 upstream to discuss the issue.
I'm leaving this as draft for now.

Result of nixpkgs-review pr 250588 run on x86_64-linux 1

1 package failed to build:

vector

I was just trying to see if things changed with rust 1.72, it appears they didn't.
upstream said that a fix in 1.73 might fix things. I'll rebase again then.

I've just pushed the update to 0.33.0
upstream has removed the git dependency that was problematic, so this should be good to go.
no major changes, just the default format has been changed from toml to yaml (toml still supported though). I'm going to make a PR for the module a little later.
I'm waiting for ofborg, if anyone has time please review. (this is just a simple update).
I don't want to wait too long, since the last minor update was missed.

alright, ofborg is passing, I'm going to wait 24h more just in case someone has something to say.


Guide preventing Craft Commerce email templates from loading.

Description
On a site with Craft Commerce, Guide is preventing order confirmation email templates from being displayed. Disabling Guide results in the template being displayed as expected.
Steps to reproduce

Install Craft Commerce and Guide plugins
In Commerce, go to System Settings > Emails and create a new email with a "HTML Email Template Path" specified in your templates directory
Create a template with the following HTML:

<html>
	<body></body>
</html>

Expected behavior
Empty HTML template is displayed on page
Actual behavior
Page displays error: Unable to find the template “guide/_partials/admin_globals”.
Versions
Craft CMS: 5.2.6
Craft Commerce: 5.0.12
Guide: 4.0.0-beta.1

Thanks, @turnstylerj, I'll take a look to see if I can figure out why you're getting that error.

@turnstylerj, I figured out what's going on here and will have a fix for this in the next release (which will be the 4.0.0 non-beta release).

@turnstylerj, I've just tagged the release for 4.0.0 which resolves this issue.


Resizing on Windows

Looks like the size stays the same as the original size when it has been changed.

Looks like its just the height that is not getting resized.

This was fixed on version 0.3.4


fix Android support

Android support
Motivation:
fix swift-nio-ssl compatible with Android. This is a continuation(apple/swift-nio#609) of porting Vapor/WebSocket and all related packages to Android.
Modifications:
fix FileSystemObject::pathType and sysStat Android API inconsistency
Result:
now swift-nio-ssl compatible with Android!

@weissi @Lukasa can you please check my changes guys, thanks! I continue porting swift-nio to Android 🤗

@swift-nio-bot please test

@swift-nio-bot test this please

@swift-nio-bot test this please

@weissi great! Thanks!

@albertaleksieiev thank you! merged. Would it be beneficial to you to get a release (tagged version) pretty soon or don't you mind at all when the first release will be containing the Android fixes?

@weissi take your time, just ping me before release if it possible, I'll test it on Android.

@albertaleksieiev thanks! Fairly sure that we'll make a release soon with what is master today. So if it works now I think we should be good right?

@weissi oh great, happy to hear it 👍Yep, a current master state is fully compatible with Android.

Awesome, thanks for checking! I’d expect a release next week, Cory is on holiday right now and we don’t usually do releases unless we’re both there as a second pair of eyes is always good when releasing 😁

Sounds great! BTW thanks for quick responses 👍

Cool, we can arrange a release for this week.


Namespace conflict with the official mandrill-api gem

The namespaces of mandrill-rails and mandrill-api conflict, so it is not possible to use both in your project.

That was a false alarm. The issue appears to be somewhere else.


[CWS-2398] Add syscall context to link event

What does this PR do?
This PR adds syscall arguments to the link event.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Parentheses in a heredoc break highlighting

Description
Starting from a valid Terraform file containing heredocs that have parentheses inside blocks:

if there are no nested blocks, then it works
if the parentheses are after a nested block, then it works
if the parentheses are around or before a nested block, then the rest of the file's highlighting breaks

To Reproduce
Steps to reproduce the behavior:

In the example file, tpl5, add parentheses around the string "foo", everything works normally.

In tpl6, add parentheses around or after the nested if block, the highlight will break.

Additional information
Also verified with nested for loops.

Hey, thanks for the report! Ill look into it over the weekend

I think it closed automatically.

Oh my, thank you so much, that was awesome, it's perfect now! I can't tell you how important it was to me, thanks again!


Moving collapsed plugins in admin does not show a blue line of the target area

Moving a plugin to a collapsed plugin space in the admin UI does not show a blue line of the target area.
The move itself works. It's just missing the blue line which is confusing compared to the move of not collapsed plugins.
Tested on most recent Firefox.

Thanks for the report!


Request

Addition structure option:

Distance from origin (i.e. X:0 Z:0)
This is to allow adventure maps to have players explore outwards a specific distance before the structure has a chance to spawn.

Nice idea, but how/where would you suggest to store distance information for 3000 schematics?

Depending on how the mod decides to spawn in the schematic...

A config file would work, if the schematic name to include the path is not specified then no restriction.
A folder would also work.

It would be a top level folder, and named ###-###
The first ### would be the minimum Distance and the second ### would be the max


Increase performance with new fingerprint implementation

Now fingerprints are stored as an array of integers rather than a bitset.
The array can be more efficiently constructed, and our own jaccard
implementation appears to be much faster than using bitset's operator
overloads and ::count.
The code was also refactored to use iterators and range-based for loops where possible.

Confirming that devtools::load_all(), devtools::test() and devtools::install() all work.
Benchmarking times:
Load and parse fingerprints: 17.047 sec elapsed
Construct fingerprint library: 2.201 sec elapsed
Compute all similarities for one fingerprint: 0.071 sec elapsed


Bug Test failed after PR from task 12 into master

The test suite fails on 2 tests now that @AndrewGerberBSU did not update the suit.

bug smacked up


Running cpufreq instrument requires root access?

I'm trying to run dhrystone workload on my phone, which has developer mode enabled, and get the following error if the cpufreq instrument is enabled:
ERROR            Error in instrument cpufreq
ERROR              File "/usr/local/lib/python3.6/dist-packages/wlauto-3.2.1.dev1+dfb4737e-py3.6.egg/wa/framework/instrument.py", line 272, in __call__
ERROR                self.callback(context)
ERROR              File "/usr/local/lib/python3.6/dist-packages/wlauto-3.2.1.dev1+dfb4737e-py3.6.egg/wa/framework/instrument.py", line 172, in wrapper
ERROR                return func(*args, **kwargs)
ERROR              File "/usr/local/lib/python3.6/dist-packages/wlauto-3.2.1.dev1+dfb4737e-py3.6.egg/wa/instruments/misc.py", line 139, in start
ERROR                self.target.pull(dev_dir, before_dir)
ERROR              File "/usr/local/lib/python3.6/dist-packages/devlib-1.2.1.dev1-py3.6.egg/devlib/target.py", line 366, in pull
ERROR                self.conn.pull(source, dest, timeout=timeout)
ERROR              File "/usr/local/lib/python3.6/dist-packages/devlib-1.2.1.dev1-py3.6.egg/devlib/utils/android.py", line 300, in pull
ERROR                return adb_command(self.device, command, timeout=timeout, adb_server=self.adb_server)
ERROR              File "/usr/local/lib/python3.6/dist-packages/devlib-1.2.1.dev1-py3.6.egg/devlib/utils/android.py", line 577, in adb_command
ERROR                output, _ = check_output(full_command, timeout, shell=True)
ERROR              File "/usr/local/lib/python3.6/dist-packages/devlib-1.2.1.dev1-py3.6.egg/devlib/utils/misc.py", line 206, in check_output
ERROR                raise subprocess.CalledProcessError(retcode, command, output='\n'.join([output or '', error or '']))
ERROR
ERROR            Command 'adb -s <numbers> pull /sys/devices/system/cpu wa_output/wk1-dhrystone-10/before/sys/devices/system 1 adb -s <numbers> pull /sys/devices/system/cpu wa_output/wk1-dhrystone-10/before/sys/devices/system' returned non-zero exit status 1
ERROR            OUTPUT:
ERROR            adb: error: failed to copy '/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq' to 'wa_output/wk1-dhrystone-10/before/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq': remote open failed: Permission denied
ERROR            [  0%] /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_governors: 0%

Do I need to have root access on my phone to run this instrument?
I'm new to this project and didn't find anything about this in the user document or maybe missed some important detail about this.

It depends on the device as to whether root is required to read the cpu_freq data however yes it looks like it would be required for your phone.

Thanks for clarifying this.

Depending on the restrictions of your device if you're looking for particular cpufreq related files and you have access to them, you might be able to make use of the generic "sysfs_extractor" instrument instead. This would allow you to provide specific paths which you are able to pull from the device rather than attempting to pull all of the cpufreq related data.


Validation added for searching for a github username

This PR is regarding issue #53.
Description
I have used a regex that matches the actual github username validation criteria to fulfill our validation. Instead of indulging into an actual post request and return a 404, I've considered this approach to minimize extra operations and time consumption.
Files Modified
components/Form.tsx : Added a regex and used an if statement.
Working
The button would not send the post request as it should if the provided username seems to not follow the validation criteria. This is kept minimal until further guidance provided by the repository owner.
[UPDATED]
Description
Previously regex that matched the actual github username validation criteria to fulfill our validation. Now if the validation fails, a new toast appears regarding the failed validation.
Files Modified
components/Form.tsx : Added made a call to toast function.
Working
Toast pops up for invalid username format as shown in the attached media.

Hey @kshavp can you provide me some of it's use cases?

Sure, refer the provided media as well the context composed below
1. Valid Username Entry:
Scenario: User enters a valid GitHub username containing only alphanumeric characters.
Expected Behavior: The form submission proceeds successfully, allowing the user to generate the resume.
2. Invalid Username with Special Characters:
Scenario: User enters a username containing special characters such as @, #, $, etc.
Expected Behavior: The submit button does not facilitate the form to send a post request.
3.Invalid Username (Empty):
Scenario: User leaves the username field empty.
Expected Behavior: The submit button does not facilitate the form to send a post request.
###4.Invalid Username with Whitespace:
Scenario: User enters whitespace characters as the username.
Expected Behavior: The submit button does not facilitate the form to send a post request.
https://github.com/ashutosh-rath02/git-re/assets/95236968/10e4abba-6f2b-41ed-ba7b-3e9b3091b1c7

Use a toast maybe it will look good. Username may have hyphens but not following it or consecutive multiple hyphens, have you taken that into consideration?

Yes the hyphens are under consideration. I'll update with the toast component soon.

How is it coming @kshavp ?

Hey @ashutosh-rath02 , it's almost ready, just about to update the PR.

@kshavp A small video will do to check

Sure, have a look.
https://github.com/ashutosh-rath02/git-re/assets/95236968/48fee6df-fa46-44e0-84a5-9e149e88095b

LGTM🤺

@all-contributors please add @kshavp for code


Add setting to powershell.config.json to disable WinPS module loading

Summary of the new feature/enhancement
In PS7 we introduced the equivalent of WindowsCompatibility module in the engine (although using Jobs remoting instead of WinRM remoting).  This is enabled by default.  We should have a way to disable this if it causes problems for users.  Current proposal is to add a setting in powershell.config.json.
cc @anmenaga

Yeah, this should be configurable, but isn't the config.json a machine-wide setting? We should probably allow users to set this on a more granular basis if we can.
Also, do we have a cmdlet that can alter settings other than experimental features in the config.json currently?

config.json is both user and machine scoped.  We could add cmdlets for this to make it easier for users.

It is important feature for early adoption and we also could add a message (link to docs) in startup welcome message.


These are symbols in the same project.

Interestingly, it works in a debug hive...

I cannot reproduce this anymore with 15.3.3 + Nightlies.

This may be related: #3544 (and still open).

I'm not sure it is - #3544 looks like we're not accounting for mutually referential types correctly.  This was an outright failure for any symbol.

@cartermp, ok, other bug then, tx ;).


Updated comment on 920520 to explain the value of the header length check

Removed obsolete comment from regex data file
This addresses the question from #2357.

A formula would be nice, so that future improvements to the rule could be based on that formula. But if there's no formula, I think it's good enough.

I think the content of this image was part of the input we used.

So those are your own measurements? I wasn't able to find any third party resource that offered any such statistics for the Accept-Encoding header.

Those were made in the crs sandbox. We can ask the #coreruleset channel in slack to see if other people can chime and bring us the top 5 longest headers on their servers. I reckon it might be difficult if they don't have those logs.


Add missing throw statement in Repository.delete

1. Why is this change necessary?
The method Repository.delete does not throw in case of an API error. There is missing a throw statement.
Many parts of the code already expect the method to throw:

https://github.com/shopware/platform/blob/6a012667a16dc464525c5332f19f8fff5851c426/src/Administration/Resources/app/administration/src/app/component/entity/sw-entity-listing/index.js#L105
https://github.com/shopware/platform/blob/6a012667a16dc464525c5332f19f8fff5851c426/src/Administration/Resources/app/administration/src/app/component/entity/sw-one-to-many-grid/index.js#L111
https://github.com/shopware/platform/blob/eb505a60669b0cb29b3d19ebce365e540776fedb/src/Administration/Resources/app/administration/src/app/component/media/sw-media-modal-delete/index.js#L142
And many more ...

So the method actually SHOULD throw.
Currently the missing throw statement leads to the issue that when deleting entities via the Administration and the deletion fails, there is still shown a success message.
2. What does this change do, exactly?
It adds the missing throw statement. Now the method throws an error in case of an API error.
3. Describe each step to reproduce the issue or behaviour.
Use the Repository located at src/Administration/Resources/app/administration/src/core/data-new/repository.data.js to delete an entity that cannot be deleted (so that deletion causes an API error). See that there is no exception thrown. Null ist returned.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-7966
Please use this issue to track the state of your pull request.

Hi @windaishi,
thank you for your contribution. This was indeed a weird behavior. Your pull request should be merged soon. 👍
Best regards
Tobias

Hi @windaishi,
unfortunately I forgot to add the GitHub PR number to the commit message so the merge was not detected: https://github.com/shopware/platform/commit/08c91d298f9ff143354e8b1edfe44a81646fbb1f
Because of that I will close this PR manually.
Best regards
Tobias


Nicer comments styling

Fixed with commit https://github.com/frixelsolutions/essentialswp/commit/8bdabe5f050bedd21ea5d8f01013e9d9af126ade


how can I change the color of the badges?

Could not find this customization option.
Obviously white colored badges can only make sense on dark themed apps like the example that you created, so that limitation makes the badge feature useless for a lot of people.
I think if implementing a custom color is dificult you could at least make an option for red badges, which are the default for most apps

Hello. Thanks for an idea. Wait for improvments. Thanks.

Hello. Thanks for an idea. Wait for improvments. Thanks.

Hello. U can update NTB to 1.1.6 where you can set custom colors to badge. Thanks for enhancement.

Whoa, that was fast! Thank you so much, I hope to be able to test it on Monday when I'm back at the office.


Support Garbage Collection?

Curious if this supports garbage collection concepts?

The readme mentioned having to hold state in a server until you know all clients have received all the Ops.
Thats part of the answer but I don't know these rest.
It's a good question as I see this in other crdt libraries as an issue


Climate template update

this branch was created to test the process notebook workflow.

@OhadZivan @jlpearso I created a new branch on the repo, and merged your forked branch into it. This way the workflow can run. It was trying to run, looking for a branch that doesnt exist. We will need to have contributors create branches on the main repo or do it this way.

@OhadZivan @jlpearso I created a new branch on the repo, and merged your forked branch into it. This way the workflow can run. It was trying to run, looking for a branch that doesnt exist. We will need to have contributors create branches on the main repo or do it this way.

Sounds good! Whatever is easiest to keep our user numbers manageable is fine by me. :)

@iamzoltan looking over the code report, is it a problem that there are 65 violations of pycodestyle? How does this compare with the previous version of the template minus our edits?
comparing the instructor to student notebooks I don't see any major issues but note when I do click on the exercise solution in the student version it takes me to a 404 for exercise solutions and explanations except for the very last one. Wanted to make sure this is expected behavior.
Can you comment on if the feedback gadget is working? It doesn't produce anything in these notebooks and clicking didn't seem to work in the book before either.
Same thing for the air table for the discussion section towards the bottom. The code remains the same and doesn't produce anything. How might we use this feature as it seems like it could be a valuable tool for TAs?

W1D2_Tutorial1
Instructor
Student
Code report for W1D2_Tutorial1
Code report for W1D2_Tutorial1.ipynb
Quality (pyflakes)
Total code issues: 0
Style (pycodestyle)
Total PEP8 violations: 65
Common problems:

16 instances of E402 (module level import not at top of file)
12 instances of E265 (block comment should start with '# ')
5 instances of E266 (too many leading '#' for block comment)
5 instances of E302 (expected 2 blank lines, found 1)
4 instances of E305 (expected 2 blank lines after class or function definition, found 1)
2 instances of E302 (expected 2 blank lines, found 0)
2 instances of E261 (at least two spaces before inline comment)
2 instances of E501 (line too long (91 > 88 characters))
2 instances of E501 (line too long (115 > 88 characters))
2 instances of E703 (statement ends with a semicolon)

I've got more technical questions.
a few of these are missing blank lines. and others have to long lines.
it was never part of the instructions. do we really need such limitations? number of characters in a line? why is it even an issue?
only thing I agree with is the semicolon 😆

PEP8 is a guideline for python styling. In general, code you find in most libs or FOSS projects will follow that styling. It is not necessary for the function of python or out books, but it is generally preferred in the python community and makes reading code much easier.

as long as it's not mandatory

@iamzoltan can you comment on these things as well please when you have time?

@iamzoltan looking over the code report, is it a problem that there are 65 violations in pycodestyle? How does this compare with the previous version of the template minus our edits? _ this was solved in Ohad convo above
comparing the instructor to student notebooks I don't see any major issues but note when I do hit the 'click for solution' links in the student version it takes me to a 404 for exercise solutions and explanations except for the very last one. Wanted to make sure this is expected behavior.
Can you comment on if the feedback gadget is working? It doesn't produce anything in these notebooks and clicking didn't seem to work in the book before either.
Same thing for the #airtable for the discussion section towards the bottom. The code remains the same and doesn't produce anything. How might we use this feature as it seems like it could be a valuable tool for TAs?

@jlpearso I am not sure which solutions you are talking about. when I click for them I get directed to the correct place. can you share a specific link?

@iamzoltan weird they work for me now!


Fix DNS entry update issue

When an update is done to the container resolv.conf file
and it was inheriting host entries, then we should not
re-read the host entries when the container leaves and
re-joins the endpoint.
Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

LGTM.

LGTM


make subsets large_companies(), medium_companies(), small_companies()

https://github.com/ru-corporate/boo/blob/f031505ebb01568fb14cf5f09cddf43869cf5aac/boo/dataframe/filter.py#L50-L60

Not very coherent as works on ta and sales, but good for now.


Added plugin to import Github wiki into a DSS project wiki

Hi @apichery @cstenac, can we merge and close this PR ?

No, I need to fix the problem first.
On Fri, Mar 1, 2019 at 2:38 PM Du Phan<EMAIL_ADDRESS>wrote:

Hi @apichery https://github.com/apichery @cstenac
https://github.com/cstenac, can we merge and close this PR ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dataiku/dataiku-contrib/pull/81#issuecomment-468667367,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL659olPusGvIgkaAXMhh9a7auK8tXjwks5vSS1kgaJpZM4XGZEe
.


Delete .DS_Store script

We should add this to .gitignore file:
https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/.DS_Store
and remove from github.

issue resolved


Highlight keyword signal

Issue #2 addressed a few new keywords, but this one came up more recently.

Hi, thanks for posting an issue! I added the signal keyword and will be pushing it with other commits in a few minutes.

Commits pushed!

Nice, thanks a lot!


Composer: Proposes updates which conflict with the PHP constraints in composer.json

Package ecosystem
composer
Language version
PHP 7.2
Manifest location and content before the Dependabot update
https://github.com/oliverklee/ext-seminars/commit/427e5aa271a6d437f0f2c8b055d1985187048cb9
(Note: This is an earlier version of my composer.json as I added the line platform: php: 7.2.9 to get Dependabot to work again.)
dependabot.yml content
https://github.com/oliverklee/ext-seminars/blob/main/.github/dependabot.yml
What you expected to see, versus what you actually saw
I expected Dependabot to recognize by the PHP version requirement in composer.json:
"php": "^7.2.0 || ~8.0.0",

… that it should only try to update to package versions that are compatible with PHP 7.2 as well (as my package needs to stay installable with PHP 7.2). So basically, Dependabot needs to pretend to run on the lowest supporter PHP version.
Instead, Dependabot choked with this error message:
updater | INFO <job_407942781> Handled error whilst updating friendsofphp/php-cs-fixer: dependency_file_not_resolvable {:message=>"Your requirements could not be resolved to an installable set of packages.\n  Problem 1\n    - typo3/cms-core[v9.5.7, ..., v9.5.31, v10.4.6, ..., v10.4.30] require php ^7.2 -> your php version (8.0.2; overridden via config.platform, actual: 7.4.30) does not satisfy that requirement.\n    - Root composer.json requires typo3/cms-core ^9.5.7 || ^10.4.6 -> satisfiable by typo3/cms-core[v9.5.7, ..., v9.5.31, v10.4.6, ..., v10.4.30]."}

Native package manager behavior
With running PHP 7.2, I don't get an update for the affected package friendsofphp/php-cs-fixer.

Similar/duplicated: https://github.com/dependabot/dependabot-core/issues/5251


Support Angular 4 final

Support Angular 4 final.
It should work, but I want to do some tests before to say that everything is really ok.

Also Angular 4.1.0, out before the release of 3.0.2


Can't append to PersistentVector with some types

I get an error when trying to append to a PersistentVector{Symbol}, as well as some custom types.
l = @Persistent [:a, :b]
append(l, :c)
ERROR: `start` has no method matching start(::Symbol)
  in mapfoldl at reduce.jl:71
  in append at /Users/jason/.julia/v0.3/FunctionalCollections/src/PersistentVector.jl:191

It seems to work fine with numbers, though.  For example:
l = @Persistent [1, 2]
append(l, 3)

behaves as expected.  I'm using Julia 0.3.10 on Mac OS 10.9.5.

This is a documentation issue. push is the right function to add one argument; append by contrast adds elements of the given collection. The fact that numbers work is a consequence that, somewhat non-intuitively, numbers in Julia are collections of themselves.


[Bug]: Destructuring null with rest

Describe the bug
The input code is destructuring null so it should throw exception but the transpiled code does not.
Input code
var { ... x } = null ;

Config
No response
Playground link
https://play.swc.rs/?version=1.3.11&code=H4sIAAAAAAAAAytLLFKoVtDT01OoUKhVsFXIK83JUbAGAPSFhPAWAAAA&config=H4sIAAAAAAAAA0WMTQrEIAxG75K1286id5hDBCctFv9IUhgR714tlu7C915ehUMsrBUyshCPS0pU%2FMMKZAOKZZcVTNf6tKEXagYUeScdiiyd%2BZSEJjUQXHRbGSWbQmYSeRHG3T9m66GQfucYKmjJdAc%2F0N7G%2FHPynaLySe0Cj9ke9LUAAAA%3D
Expected behavior
Input code throws TypeError:
$ node input.js
input.js:1
var { ... x } = null ;
                ^

TypeError: Cannot destructure 'null' as it is null.
    at Object.<anonymous> (input.js:1:11)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Module._load (node:internal/modules/cjs/loader:878:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47

Node.js v18.11.0

Actual behavior
The transpiled code is terminated normally:
$ node output.js # no error

Version
1.3.14 (default SWC playground)
Additional context
No response

Duplicate of https://github.com/swc-project/swc/issues/6390


Add permissions for Anonymous Uptime Check Plugin

Description

https://github.com/jenkinsci/anonymous-uptime-check-plugin
https://issues.jenkins-ci.org/projects/HOSTING/issues/HOSTING-659

Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[x] Add link to resolved HOSTING issue in description above

For a new permissions file only

[x] Make sure the file is created in permissions/ directory
[x] artifactId (pom.xml) is used for name (permissions YAML file).
[x] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[x] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

as per the discussion here: https://issues.jenkins-ci.org/browse/HOSTING-659
I will close this PR, rename the plugin, and open a new PR


Update Assertion Description to include new ID registrations and recommendations

Also include comments that the Assertion Description may be used elsewhere, ie ClinVar, so it should be used externally.

Is this in reference to CURIEs referenced in this client issue?

If I recall, yes. Adding it again here to link it to this issue. https://github.com/griffithlab/civic-client/issues/1358


Enable usage with Python 3.9

Python 3.9 is well into maturity - are there reasons this package has such a restriction?
https://github.com/stellargraph/stellargraph/blob/5ca1e59e91cb6ac470bf19ff3da39b3a1a68650e/setup.py#L91

Just curious -- is there any progress on this request? It does seem like a very limiting facto an otherwise great library!

there haven't been any commits on this project in a year, it might be over.

Adding python 3.11/3.12 request🤚


fix: convert forward slashes to backslashes for protoc plugins on Windows.

Fixes https://github.com/aspect-build/rules_ts/issues/667
This takes the approach rules_proto_grpc does to detect if we are building on Windows via the host_path_separator. protoc will fail to call into the plugins if they are expressed to protoc as forward-slash paths. Alternatively, we could make this more limited like my patch in the linked issue to check .bat file extensions, which is fragile in its own way, but works for the given use case.

Changes are visible to end-users: no
Test plan

Manual testing; please provide instructions so we can reproduce: check out https://github.com/AchilleaResearch/rules_ts_667 on Windows and bazel build //:foo_ts_pb. This PR's change is a patch in that repo, so I could also change that to directly use my commit instead, if preferred

There aren't any tests as far as I can tell currently for ts_proto_library, so my manual test is the best I can currently offer, and it's not clear if the Windows test runners are fully active, but I'd be happy to write a test for initial coverage on ts_proto_library if desired

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Would you be able to add some initial ts_proto_library tests? It would be great to merge some tests in and then try to reproduce+fix the windows after 🙏

Rebased, and the unit test that would repro and show this PR improving things is f00e046 in #671

Now that #671 is merged in, I rebased and the same unit test should apply, showing a noop on Linux and now should work on Windows


"Open Terminal Session" should direct me to create a username/password

I select the Windows instance and try “Open Terminal Server Session”. It’s asking me username/password. I have no idea what username/password I’m supposed to use. Now, I see a “Create or Reset Password” in the same menu, so I guess that I actually need to create a username/password. I don’t like this, I shouldn’t have to guess. “Open Terminal Server Session” should be grayed out until I create a password, or it should direct me to create a password.

Thinking about keeping a cache of user accounts stored in the developer machine, similar to the google account manager.

See PR #169, by storing the credentials we can offer the choice later on when starting a Terminal server window. The extension can create an .rdp file using the credentials chosen, and open a new session using that .rdp file.
If no credentials are found we can prompt the user to create them.

This is now in.


Sema: Downgrade over availability diagnostics to warnings for implicit decls

It's likely that incorrect availability annotations on implicit decls represent compiler bugs, so downgrade the diagnostic to a warning to avoid blocking the developer.
Resolves rdar://107764128

@swift-ci please smoke test

@swift-ci please smoke test


[contact-journal] Contacts journal entries clean-up

Current Implementation
None.
Suggested Enhancement
Automatically clean up the saved contacts and locations lists after a contact or location is no longer featured in the contacts journal.
Expected Benefits
Declutters the saved contacts and locations lists.

See also https://github.com/corona-warn-app/cwa-wishlist/issues/405.

Oh. I didn't see that one!


[Outlook] (on-send) Update Mac support

Docs Build status updates of commit 2ffab4b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/outlook-on-send-addins.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit de269e3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/outlook-on-send-addins.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


feat: support sameSite=none cookies

This bumps the cookies package dependency to add support for sameSite cookie attribute value none.

2.10.0 released


Implement ODPixel Stacking Dialog

Still some issues with this one, eg. if you have a triple stack and fail he will play the triple stack line again instead of the failure line.


Do not use host network for building image

Today the Elasticsearch Docker build relies on the host network for building the Docker image. In particular, it requires port 8000 on the host to be available so that the Docker build can connect to the artifacts server that is created during an earlier phase of the build. I ran into a strange issue where the build would repeatedly fail if using the host network. In particular, the issue that I ran into is that the setup package installed during yum update could not be installed because /etc/hosts could not be extracted from the package. It is not clear to me why this fails with the host network, but once we surmised this was a possbility and switched to not use the host network, the issue went anyway. Whatever the issue is, it's inherently desirable to not use the host network during the build anyway. Instead, we can connect the containers over a dedicated bridge network and not rely on port 8000 being available on the host. Fortunately, this fixes the issue that I was running into as well.

The fastest reproduction for me is:
[jason@totoro elasticsearch-docker]$ docker run --rm --network=host -it centos:7 /bin/bash
[root@totoro /]# yum install -y setup
Loaded plugins: fastestmirror, ovl
base                                                                                | 3.6 kB  00:00:00
extras                                                                                | 3.4 kB  00:00:00
updates                                                                                | 3.4 kB  00:00:00
(1/4): base/7/x86_64/group_gz                                                                                | 166 kB  00:00:00
(2/4): extras/7/x86_64/primary_db                                                                                | 125 kB  00:00:00
(3/4): updates/7/x86_64/primary_db                                                                                | 1.0 MB  00:00:00
(4/4): base/7/x86_64/primary_db                                                                                | 5.9 MB  00:00:01
Determining fastest mirrors
 * base: centos.mirror.constant.com
 * extras: centos.mirror.constant.com
 * updates: centos.mirror.constant.com
Resolving Dependencies
--> Running transaction check
---> Package setup.noarch 0:2.8.71-7.el7 will be updated
---> Package setup.noarch 0:2.8.71-9.el7 will be an update
--> Finished Dependency Resolution

Dependencies Resolved

=============================================================================================================================================================================================================================================================================
 Package                                                        Arch                                                            Version                                                                  Repository                                                     Size
=============================================================================================================================================================================================================================================================================
Updating:
 setup                                                          noarch                                                          2.8.71-9.el7                                                             base                                                          166 k

Transaction Summary
=============================================================================================================================================================================================================================================================================
Upgrade  1 Package

Total download size: 166 k
Downloading packages:
Delta RPMs disabled because /usr/bin/applydeltarpm not installed.
warning: /var/cache/yum/x86_64/7/base/packages/setup-2.8.71-9.el7.noarch.rpm: Header V3 RSA/SHA256 Signature, key ID f4a80eb5: NOKEY===========================================================                                            ]  0.0 B/s | 100 kB  --:--:-- ETA
Public key for setup-2.8.71-9.el7.noarch.rpm is not installed
setup-2.8.71-9.el7.noarch.rpm                                                                                | 166 kB  00:00:00
Retrieving key from file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7
Importing GPG key 0xF4A80EB5:
 Userid     : "CentOS-7 Key (CentOS 7 Official Signing Key<EMAIL_ADDRESS> Fingerprint: 6341 ab27 53d7 8a78 a7c2 7bb1 24c6 a8a7 f4a8 0eb5
 Package    : centos-release-7-4.1708.el7.centos.x86_64 (@CentOS)
 From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Updating   : setup-2.8.71-9.el7.noarch                                                                                1/2
Error unpacking rpm package setup-2.8.71-9.el7.noarch
warning: /etc/group created as /etc/group.rpmnew
error: unpacking of archive failed on file /etc/hosts: cpio: rename
setup-2.8.71-7.el7.noarch was supposed to be removed but is not!
  Verifying  : setup-2.8.71-7.el7.noarch                                                                                1/2
  Verifying  : setup-2.8.71-9.el7.noarch                                                                                2/2

Failed:
  setup.noarch 0:2.8.71-7.el7                                                                                setup.noarch 0:2.8.71-9.el7

Complete!
[root@totoro /]#

With:
[jason@totoro elasticsearch-docker]$ docker run --rm --cap-add SYS_PTRACE --network=host -it centos:7 /bin/bash                                                                                [21/1943]
[root@totoro /]# yum install -y strace
Loaded plugins: fastestmirror, ovl
base                                                                                | 3.6 kB  00:00:00
extras                                                                                | 3.4 kB  00:00:00
updates                                                                                | 3.4 kB  00:00:00
(1/4): extras/7/x86_64/primary_db                                                                                | 125 kB  00:00:00
(2/4): base/7/x86_64/group_gz                                                                                | 166 kB  00:00:01
(3/4): base/7/x86_64/primary_db                                                                                | 5.9 MB  00:00:01
(4/4): updates/7/x86_64/primary_db                                                                                | 1.0 MB  00:00:03
Determining fastest mirrors
 * base: centos.mirror.constant.com
 * extras: centos.mirror.constant.com
 * updates: centos.mirror.constant.com
Resolving Dependencies
--> Running transaction check
---> Package strace.x86_64 0:4.12-6.el7 will be installed
--> Finished Dependency Resolution

Dependencies Resolved

=============================================================================================================================================================================================================================================================================
 Package                                                          Arch                                                             Version                                                              Repository                                                      Size
=============================================================================================================================================================================================================================================================================
Installing:
 strace                                                           x86_64                                                           4.12-6.el7                                                           base                                                           459 k

Transaction Summary
=============================================================================================================================================================================================================================================================================
Install  1 Package

Total download size: 459 k
Installed size: 1.7 M
Downloading packages:
warning: /var/cache/yum/x86_64/7/base/packages/strace-4.12-6.el7.x86_64.rpm: Header V3 RSA/SHA256 Signature, key ID f4a80eb5: NOKEY=================-                                                                                ]  0.0 B/s |  99 kB  --:--:-- ETA
Public key for strace-4.12-6.el7.x86_64.rpm is not installed
strace-4.12-6.el7.x86_64.rpm                                                                                | 459 kB  00:00:00
Retrieving key from file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7
Importing GPG key 0xF4A80EB5:
 Userid     : "CentOS-7 Key (CentOS 7 Official Signing Key<EMAIL_ADDRESS> Fingerprint: 6341 ab27 53d7 8a78 a7c2 7bb1 24c6 a8a7 f4a8 0eb5
 Package    : centos-release-7-4.1708.el7.centos.x86_64 (@CentOS)
 From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : strace-4.12-6.el7.x86_64                                                                                1/1
  Verifying  : strace-4.12-6.el7.x86_64                                                                                1/1

Installed:
  strace.x86_64 0:4.12-6.el7

Complete!
[root@totoro /]# strace yum install -y setup 2>&1 | grep "rename.*/etc/hosts" -C10
write(40, "<IP_ADDRESS>   localhost localhost."..., 158) = 158
close(40)                               = 0
ioctl(1, TCGETS, 0x7ffc5a124830)        = -1 ENOTTY (Inappropriate ioctl for device)
getuid()                                = 0
getuid()                                = 0
chown("/etc/hosts;5afb0948", 0, 0)      = 0
chmod("/etc/hosts;5afb0948", 0644)      = 0
utime("/etc/hosts;5afb0948", [2013/06/07-14:31:32, 2013/06/07-14:31:32]) = 0
getuid()                                = 0
lstat("/etc/hosts", {st_mode=S_IFREG|0644, st_size=158, ...}) = 0
rename("/etc/hosts;5afb0948", "/etc/hosts") = -1 EBUSY (Device or resource busy)
munmap(0x7feff1c20000, 2101248)         = 0
close(39)                               = 0
munmap(0x7ff000811000, 4096)            = 0
ioctl(1, TCGETS, 0x7ffc5a1249d0)        = -1 ENOTTY (Inappropriate ioctl for device)
ioctl(1, TCGETS, 0x7ffc5a1249d0)        = -1 ENOTTY (Inappropriate ioctl for device)
ioctl(1, TIOCGWINSZ, 0x7ffc5a123a40)    = -1 ENOTTY (Inappropriate ioctl for device)
write(1, "  Updating   : setup-2.8.71-9.el"..., 79  Updating   : setup-2.8.71-9.el7.noarch                                    1/2) = 79
write(23, "error: unpacking of archive fail"..., 68) = 68
write(2, "Error unpacking rpm package setu"..., 53Error unpacking rpm package setup-2.8.71-9.el7.noarch) = 53
write(2, "\n", 1

it appears this has something to do with the fact that /etc/hosts is bind mounted in as a single file, the key line being:
rename("/etc/hosts;5afb0948", "/etc/hosts") = -1 EBUSY (Device or resource busy)

This is excellent. I'll be sure to steal this for the next-gen build system.

How does name resolution work from the Docker host to the container?
Step 8/28 : RUN curl -fsSL http://elasticsearch-docker-artifact-server:8000/elasticsearch/distribution/archives/oss-tar/build/distributions/elasticsearch-oss-7.0.0-alpha1.tar.gz |     tar zx --strip-components=1
 ---> Running in 0f27516b0720
curl: (6) Could not resolve host: elasticsearch-docker-artifact-server; Name or service not known

Sorry. I was calling the wrong Make target. Docker network name resolution usually "just works". I should have realised the fault was mine.


Implement goat counter

Interesting read from Jesse Squire
https://www.jessesquires.com/blog/2020/05/08/simple-private-opensource-analytics-with-goatcounter/

Added


(fix) revert to correct locale

Changes in this PR:
Rerverts mistakenly changed locale value and relevant feature.

 Fix bug with publish button not working when JS is disabled.


sha256.md - update screenshot

https://github.com/caskroom/homebrew-cask/issues/37520

Adding the on hold flag:

I managed to get a screenshot of the new look but VirusTotal has again reverted to the original look.

I'm getting the new look consistently now when I visit https://www.virustotal.com/


Feature request Reverse scrolling

It would be great if this component would support a boolean property like flipped or reversed or something that would invert the scrolling. This is ideal for lists that start at the bottom like chat messages.

Sounds great but this infinite scroll library is very lightweight and there are others out there that come with some really cool features like this.
https://github.com/seatgeek/react-infinite#as-a-chat-or-message-box-displaybottomupwards-mode

Completed in https://github.com/CassetteRocks/react-infinite-scroller/pull/34!


⚠ Bofrost.es has degraded performance

In 312655d, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1343 ms

Resolved: Bofrost.es performance has improved in c1b6547 after 13 minutes.


external-volume persistence

Current v0.6.2 has the external-volume folder disappear with docker re-deployment.
Change the docker + host settings for external-volume persistence.
See example in https://github.com/PharmaLedger-IMI/acdc-workspace/tree/master/docker#creating-docker-volume-external-volume
As a secondary objective, start defining the procedures to update the code without resetting the whole blockchain.

Done for now.


Switched from ed25519 to pynacl

Made some basic changes to use pynacl instead of ed25519, which is no longer maintained. This should remove pip errors when installing.
Fix #18

The changes look mostly good, but i think pinning Python version to be >= 3.10 was a bit excessive. I made a test matrix at #21 and the library can still support Python >= 3.8

Sounds fair to me!


How to view history|如何查看历史记录

Is this a hidden command? I can't find any command to view history until I see someone else use it.
: man extract
devbot: Usage: extract duration
        Extract the messages posted in  duration

use
: extract 24h

It's from a plugin made by @Arkaeriit

Yep it's from this plugin.
You can see the list of commands handled by plugins with the plugin command.


[PDI-16707] Date format is not retained after performing Memory Group…

… by.
The previous PR introduced a bug in both Group by and Memory Group by steps when the aggregation doesn't have a subject field, For example, a count(*) instead of a max(date).
@duarteteixeira @pamval @mbatchelor

@pentaho-lmartins  could you please add unit tests demonstrating the issue and demonstrating your fix works?

Will provide unit tests shortly.

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/groupby/GroupByMeta.java
  engine/src/main/java/org/pentaho/di/trans/steps/memgroupby/MemoryGroupByMeta.java

Newly Fixed Tests:
org.pentaho.di.trans.ael.websocket.TransWebSocketEngineAdapterTest.testOpsIncludeSubTrans:
:large_blue_circle: java.lang.RuntimeException
java.lang.RuntimeException:
org.pentaho.di.core.exception.KettleXMLException:
Error reading object from XML file

Error reading object from XML file

Unable to load step info from XML step nodejava.lang.NullPointerException
 at org.apache.maven.surefire.booter.ForkedBooter.main (ForkedBooter.java:121)
 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess (ForkedBooter.java:240)
 at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader (ForkedBooter.java:2

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.ael.adapters.TransMetaConverter

Instruction Change: -1.1% :small_red_triangle_down:
Line Change: -1.9% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Instruction Change: -1.2% :small_red_triangle_down:
Line Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.TransMeta

Instruction Change: -0.5% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

Included unit tests to the changed code.
Squashed previous commit with new commit that includes unit tests.
@duarteteixeira @pamval @mbatchelor @kolinus

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/groupby/GroupByMeta.java
  engine/src/main/java/org/pentaho/di/trans/steps/memgroupby/MemoryGroupByMeta.java
  engine/src/test/java/org/pentaho/di/trans/steps/groupby/GroupByMetaGetFieldsTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/memgroupby/MemoryGroupByMetaGetFieldsTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Complexity Change: -0.7% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -0.5% :small_red_triangle_down:
Complexity Change: -2.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.www.TransformationMap

Branch Change: -4.6% :small_red_triangle_down:
Complexity Change: -3.1% :small_red_triangle_down:
Instruction Change: -5.7% :small_red_triangle_down:
Line Change: -5.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/groupby/GroupByMeta.java
  engine/src/main/java/org/pentaho/di/trans/steps/memgroupby/MemoryGroupByMeta.java
  engine/src/test/java/org/pentaho/di/trans/steps/groupby/GroupByMetaGetFieldsTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/memgroupby/MemoryGroupByMetaGetFieldsTest.java

Newly Fixed Tests:
org.pentaho.di.trans.streaming.common.BlockingQueueStreamSourceTest.testRowsFilled:
:large_blue_circle: junit.framework.AssertionFailedError
junit.framework.AssertionFailedError
	at org.pentaho.di.trans.streaming.common.BlockingQueueStreamSourceTest.getQuickly(BlockingQueueStreamSourceTest.java:140)
	at org.pentaho.di.trans.streaming.common.BlockingQueueStreamSourceTest.testRowsFilled(BlockingQueueStreamSourceTest.java:131)

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change: -7.2% :small_red_triangle_down:
Complexity Change: -7.7% :small_red_triangle_down:

org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Line Change: -0.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.www.TransformationMap

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.6% :small_red_triangle_down:

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Branch Change: -1.9% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

@pentaho-lmartins , look good to me
thank you.


Update ultradns zones api

/zones api is deprecated and replaced with v3/zones. There are also changes to the pagination model, api returns cursorInfo instead of resultInfo. cursorInfo has following fields: first, next, previous, last indicating subsequent page id's
More details on the api change can be found here:
https://docs.ultradns.neustar/Content/REST API/Content/REST API/Zone API/Zone API.htm
fixes #8

/assign @kbhandari


Customize inputhint of prompt property

Fixes #3195
Description
Using expectingInput while inputHint property is not assigned of prompt property in InputDialog. Otherwise, keep it as it is.

Pull Request Test Coverage Report for Build 492599783

0 of 0   changed or added relevant lines in 0 files are covered.
25 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.1%) to 84.447%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/triggerTrees/node.ts
10
90.51%

libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts
14
83.16%

Totals

Change from base Build 486704763:
0.1%

Covered Lines:
17805

Relevant Lines:
20143

💛  - Coveralls

Pull Request Test Coverage Report for Build 492599783

0 of 0   changed or added relevant lines in 0 files are covered.
25 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.1%) to 84.447%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/triggerTrees/node.ts
10
90.51%

libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts
14
83.16%

Totals

Change from base Build 486704763:
0.1%

Covered Lines:
17805

Relevant Lines:
20143

💛  - Coveralls


[BUG]Paired Opportunists with Life Bonding Friendship

When sharing feat, teammates cannot gain the correct environment bonus.Bonus sometimes exists and sometimes does not.At the same time, if the Fighter's Tactics are satisfied, the enemy's opportunistic attack will trigger our opportunistic attack on our teammates。

Can you clarify: what environment bonus are you referring to?

Also what are you referring to with regards to "Fighter's Tactics"?

Also please share a log after repro: https://github.com/WittleWolfie/CharacterOptionsPlus#reporting-problems


file declaration?

thanks for your code. I want to know what is difference bot_sort.py and mc_bot_sort.py?
what is the difference mc_demoxxx.py and demo.py
Looking forward to your reply

bot_sort.py is the original implementation I used to get the results in the paper. I didn't want to change this code because I wanted that people could reproduce our results easily.
mc_bot_sort.py is a multi-class implementation I created following questions about multi-class support.
the demo.py use the bot_sort and mc_demo.py use the mc_bot_sort.


Successful networked player flipping

Description
Add code which syncs player direction flipping over the network.
Please include a summary of the change and which issue is fixed or what was added to the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that demonstrate the new feature or bugfix
[ ] New and existing unit and integrations tests pass locally with my changes

Closes Issue #12

#12


if_lua: Prevent SEGV/ABRT for Lua functions invoked via Vim callbacks

if_lua employs a cache system using upvalues that fails when a Lua function is invoked as a Vim callback with parameters.
A MRE that causes a SEGV with PUC Lua 5.1 and an ABRT with Luajit:
vim --clean -S if_lua-segv-mre.vim.txt
if_lua-segv-mre.vim.txt
let s:Lua_funcref = luaeval('function(d) print("in Lua callback") end')

function! Exit_CB(job, status)
    call s:Lua_funcref({'a' : 'b'})
endfunction

let s:job = job_start("echo Hi",
      \ { 'exit_cb' : 'Exit_CB' })

This patch gates use of the cache system with a static variable, so that it is not employed when upvalues are unavailable.

This stop-gag fix can lead to issues with double-frees for Lua userdata with __gc, so I'm going to close this PR and think about how to address the problem more fundamentally.

Instead of restricting use of the cache, I've moved the cache from upvalues to the registry.


Disable sdca_ops test on GPU.

This test is failing on GPU. Some of the ops don't have GPU
implementations so this test might not even be meant to be
run on GPU.

Seems like this test probably wasnt meant to be run on GPU. Disabling. Should fix release build issue.


feat(protocol): cross-sync signal service storage root

This PR shows the idea of synchronizing not only the block header hashes across chains, but also the SignalServcie Storage Root (SSSR or Sssr for short).

L1->L2: this is done by allowing client to pass in  l1Sssr to the anchor transaction. A circuit will need to verify the anchor transaction's input value for l1Sssr pass integrity check with l1Hash and l1SignalServiceAddress which are part of the ZKP instance input.

L2->L1, this is done by requesting the block prover to provide the l2Sssr value as part of the evidence. The ZKP instance value now incorporates the l2Sssr and the L2SignalService address together with l2Height and l2Hash, which literally demands the main ZKP to do the same Merkle tree verification in circuits.

The benefit
Currently to prove signal's validity on the destination chain, we need to provide a full merkle proof which has two parts, the account proof and the storage proof.
After this change, the account proof will be done only once. Users only need to provide the storage merkle proof, which will be less espensive.

SignalServcie Storage Root (SSSR or Sssr for short).

Bridge root?

SignalServcie Storage Root (SSSR or Sssr for short).

Bridge root?

renamed to singalRoot


[Feature request] support page.addBinding

page.addBinding(binding_name) won't work as all scripts are executed in a isolated world.
Relevant source here is /playwright-core/src/server/chromium/crPage.ts#L828
requires:

[ ] support javascript with non-isolated worlds
[ ] support iframes
[ ] add isolated argument

[ ] to addBinding
[ ] to execute-script methods

Solved with Update to Patchright.


Let init_non_send_resource require FromWorld instead of Default

Objective

Let init_non_send_resource take FromWorld values again, not only Default
This reverts an unintended breaking change introduced in #9202

Solution

The resource initialized with init_non_send_resource requires FromWorld again

If possible, I would like this to get into 0.14 in order to not break that API unnecessarily.

I didn't even manage to write on Discord before Alice had labeled and approved :D


⚠ ClamAV has degraded performance

In 360522e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in 49c1f98.


Enhancement: Auth add "Profile" plus "Logout" dropdown

Is there any possibility of adding an item to the user's dropdown, it currently has "Logout" only and I would add new item like "Profile"
Thanks in advance

Having this feature would be useful, but currently, you can only do it by overriding "layout.html".

OK, thanks!


Add support for data-test-* properties

When these are set to boolean true they are added to the element,
boolean false are skipped (can't think of why these would exist)
When they are set to a literal value that value is used.
Anything else throws.
I only handled classic components because I'm not sure if setting properties like this works on classes. If that's a working case let me know and I'll add it.
Fixes #34

@Turbo87 ✔


How enable auto scroll

it's not working:
You can enable and disable circular loop using two arguments constructor.
How to enable automatic scrolling?

not sure what do you mean by automatic scrolling, but centering is enabled here:
recyclerView.addOnScrollListener(new CenterScrollListener());

not sure what do you mean by automatic scrolling, but centering is enabled here:
recyclerView.addOnScrollListener(new CenterScrollListener());


Discussion post save appear to be broken

To reproduce :

try to create a post on http://localhost:3000/discussions/create
open the console
click on save button
Then kind of an infinite loop starts, it's a console.log from the _createNewDiscussion function in src/stores/Discussions/discussions.store.tsx

Then the loops keep going and post is not saved in discussions collection. Do you have an idea on what append here @chrismclarke ?

The saveDiscussion function was call inside herself, wich causes the infinite loop. Fixed with previous commit. It's probably due to a moment of inattention from a previous merging.
The post still doesn't appear in the database thought. I keep it open.

yup, i tried explaining this to @chrismclarke  already, i tried debugging it but as often, that react/mobx magic makes it hell

Can you point me to the related issue or discussion where you tried to debug ?
This is pretty critical and I would like to try to fix it as quick as possible.

i think it was within the 'TinyMCE editor doesn't clear', but me and him didn't know much about nor what to do.

@BenGamma , @chrismclarke , @davehakkens, @mattia-io : the name are still there. i am waiting

@BenGamma , @chrismclarke , @davehakkens, @mattia-io

@BenGamma , @chrismclarke , @davehakkens, @mattia-io : i understand you have to protect all your lies with even more lies but you're crossing the line when you put others through your dirt machinery (oliver)
anyways, I am on on my way to Eindhoven. will be there in around 30 hours of a shitty drive. I hope you have a good apologize to destroy all our content (again) and a real good explanation what's going on.

Hey, I don't really understand what's going on here. If you want to recover data it's probably doable but I have no clue on how to do this right now since it's 1am and I don't have any hand on the forum server. I suggest we'll found a solution tomorrow after a good night of sleep.

it's about hillarious lies, about one of our associates, she's been put through the dirt by one of you mods in the most miserably way. we also gave no authorization to use her full name. i don't mind about the loss of $$, time and content (for now) over the last 12 years, created by all the other lies but this one goes too far.
So reach out Oliver, to remove the name and remove his dirt machinery on our organisation, due to inconvenient questions, allegations.   I am reasonable, just get your sh* right, now please.
g

All I know is that we've been colaborating here since a month and yeah you seems reasonnable and a dedicated contributor. The rest I'm not aware of and it seems to take unwanted proportions for everyone. Will see tmrw how to reach this Oliver (that I've never heard about before now) to make the light on this.

Anyway, can you provide a proper email so we can exchange elsewhere than here ? Thanks

<EMAIL_ADDRESS>you guys have to understand that crimes like false allegation public, putting people though the dirt having nothing to do is crossing the line once again too often. we expect from you a complete and public apology in the forum and via email.
your organisation already causes enough damage to others but the behaviour of Oliver goes to far.

after consulting/feedback a lawyer and our mutual user base , in that email we need also an official statement why reference material of our users/clients team-members has been knowingly rendered useless and basically destroyed, without any prior consensus or ability to archive. we also demand a full of copy of that destroyed content.
i know things like laws/responsibilities aren't exactly your first criteria but looking at the damage created I think it's a good idea to clean this up right.

@BenGamma , @mattia-io
Can you confirm there will be an email conversation to lift this or not ? Because we consider your recent actions as extreme hostile against, us as team, us as individuals and our users.

@BenGamma  @mattia-io so we tried recovering at least our community efforts, that are lots of hours of other people btw. but as response David the guy in charge for our PP activities got just banned just for asking to recover the content.
with that you've cut any possibility to fix our bazaar payments, outstanding payouts from 6 weeks ago which is also a pretty tough disaster for some of us and quite some clients (asking us daily now). that are real people who have kids and so we had lend money from the bank now to pay them; no one of us can effort this behavior.
we asked for rectification but also the usual response : banned or no response.
I honestly don't even know where to start, defamation, sabotage, tax, misleading information on purpose, misappropriate use of public funds, where does this stop ?
when do you people start realizing that your actions have real impact, on real people. screwing small families life that way is unforgivable. please rectify<EMAIL_ADDRESS>

I have a pull request to allow saving discussions again.


Couldn't install with 'run as' username

Gitea version (or commit ref):1.4.2
Git version:2.7.4
Operating system:Ubuntu 16.04.3 LTS
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:https://gist.github.com/rmgui/049457c6b4c0daf3b219add19cc7ddc4

Description
I'm trying to install Gitea on a VPS running Ubuntu 16.04.3 LTS using SQLite or MySQL. Whenever I try to start the installation using the web interface, I get an alert notifying me that the username I've provided is not the user running the app (see Screenshot below).
That's the way I set up and ran Gitea:
wget -O gitea https://dl.gitea.io/gitea/1.4.2/gitea-1.4.2-linux-amd64

chmod +x gitea

./gitea web

My username is app - there are no other users than app and root on my VPS. I left all other fields as they were, despite 'run user' and the DB entries.
Screenshots

Setting the USER variable to my current user did it, through I couldn't find it before opening this issue.
Sorry.
Issue was solved here.


Colors recently started to look weak in Firefox

I just filled this canvas-bug for Firefox in bugzilla:
https://bugzilla.mozilla.org/show_bug.cgi?id=1935862
I THINK it is a Firefox issue, but maybe you have comments?

I'm not really sure what you mean by "weak".
However, Pannellum doesn't do anything with color management, so you're likely correct that it's a Firefox issue. Images are loaded and then displayed via a WebGL canvas, without any color processing.

By weak I mean "washed out" or not as vivid or contrasting as it should be.


utf8 PR

@leventov
I made some style and cosmetic changes to your PR which I pulled into the utf8 branch here.
I had to add finals, make some methods static that could have been, etc.  tools/SketchesCheckstyle should have caught those.
Question 1: You did not create a parallel get/put utf8 for buffer.  Why?
Question 2: Have you done any testing that shows that adding this utf8 capability into Memory improves performance over what could have been done external to Memory?

@leventov
Also, if we were to add this to Buffer, we would need to put the DecodeUtil class in Util as package private.
BTW:  This is beautiful work!

Because I we don't need it yet.

I want to rewrite Druid's GenericIndexed and ObjectStrategy interface to use Memory instead of ByteBuffers. Currently I think the interface should look like this:
interface ObjectStrategy<ObjectType, ReusableStateType>
{
  ...
  ReusableStateType makeReusableState();
  ObjectType read(Memory mem, long offset, int numBytes, ReusableStateType reusableState);
  ObjectType readNewObject(
      Memory mem,
      long offset,
      int numBytes,
      ReusableStateType reusableState
  );
}

And STRING_STRATEGY could look like this:
class StringStrategy implements ObjectStrategy<String, StringBuilder>
{
  ...
  StringBuilder makeReusableState() { return new StringBuilder(); }
  String read(Memory mem, long offset, int numBytes, StringBuilder reusableStringBuilder)
  {
    reusableStringBuilder.setLength(0);
    mem.getUtf8(offset, reusableStringBuilder, numBytes);
    return reusableStringBuilder.toString();
  }
}

It's not Region-based, because Regions are mutable, so we couldn't pass the same Region when deserializing all objects. On the other hand, we don't want to create a new Region for each new object deserialized.

I didn't compare. I wouldn't be surprised if JDK's UTF-8 encoding/decoding is faster than this, because it's heavily optimized, probably even intrinsified. But the primary goal is to avoid creating garbage. The new interface of ObjectStrategy, which has getUtf8/putUtf8, allows to generate absolute minimum garbage possible, as long as Druid's code centers around Strings. And could be made garbage-free, if it's made to use CharSequences instead of Strings.

And for complex object columns, it would allow garbage free ser/de already, that I need for https://github.com/druid-io/druid/issues/4622. See also https://github.com/druid-io/druid/pull/5172
FYI @cheddar @gianm

P. S. it's not my work, I just copied some code from https://github.com/google/protobuf repo.

@leerho FYI I pushed another small commit to this branch: https://github.com/DataSketches/memory/commit/ca731bff34d7464b178fe03241f00b5209166f56

@leventov
The method region() is immutable, writableRegion() is mutable.
Nonetheless, I get your point about not wanting to create another object.
I would like to do some characterization tests just to see how severe a hit we do get with this compared to native java, which I think would require an extra copy that would only be in Eden.
I think we may be OK, but I want to check with some folks to make sure we don't have a licensing issue.

Licensing issue with protobuf, you mean? There shouldn't be, because protobuf code is BSD-licensed, that is compatible with Apache.

@leventov
Yes, although it doesn't specifically name the license, I did confirm that it is exactly the "3 clause, BSD License 2.0".
BTW you might be interested in this thread.
It is a little old now, but it discusses several performance factors such as typical string length and whether the strings are typically mostly ASCII.  These factors appear to affect whether the simpler String.getBytes() performs better or the direct encoding/decoding in protobuf performs better.
Most of the Java String.getBytes() implementation issues they mention are still in the Java 8 code (e.g., the 4x oversize allocation of the  byte[] on encode).
I also had the thought (like David Dabbs) of directly accessing the String value array via reflection for read-only. It would reduce a copy for encode.  Kenton Varda does not like the idea, but we are already down that path with ByteBuffer and Unsafe.  Protobuf already uses Unsafe, so not sure Kenton's objection is still valid.
I would suggest we implement some temporary methods getUtf8Alt() and putUtf8Alt() which would use the much simpler String.getBytes() and String constructors and then run it on some actual Druid data and measure the encode / decode times and GC times; then run the same tests with the methods you have proposed.   Is this something you could do?

I don't see the point of doing this. There are already methods to get and put byte array from/to Memory, it could be the intermediate step for JDK-based encoding, if somebody wants to do this. There is no need for implementing special methods in the Memory library.
Methods that I added are garbage-free, this is the reason for their existence. If somebody values speed above producing more garbage, he could use JDK as described above. BTW there is no guarantee that JDK is faster, we just assumed that. But is doesn't matter.


VM creation: no response after going to Installation source

Browser Chrome
Steps:

Go to VM list
Click VM creation
Go to Installation source
Click any other button

Expected result: action is available
Actual result: no response from UI, only reloading page gets back to action

Test on:
tamazlykar/1063-vm-creation
Regression:
vm_creation
vm_creation_installsource

@tamazlykar
Tested on: tamazlykar/1063-vm-creation


Can't build for node-webkit

Using version 0.2.4 I am unable to build nodegit for node-webkit.
I have the node-webkit engine defined in a package.json file located a couple directories above where nodegit sits and it appears that the detectNodeWebkit function (in install.js) doesn't finish recursively searching directories before the "fetch" function is called. It gets called once and then "fetch" fires.
Once I found that issue I tried to just hardcode the nodeWebkit flag in install.js to true. Once I did this i get an error when running npm install. Here is the stack trace.
Command failed:
module.js:340
throw err;
^
Error: Cannot find module '/Users/adamchrist/Documents/Projects/Macaw/Code/scarlet/src/node_modules/nodegit/generate'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:906:3
And one final note. It looks like the nodeWebkit flag is a boolean value only:
line 229 of install.js
nodeWebkit = pkg.engines && pkg.engines["node-webkit"];
But later in the "buildNative" function it is being used as the "--target" argument for nw-gyp which expects a version number.

Interesting, I'll take a look and try to figure out what's going on. Thanks for the bug report.

As a workaround, you were close by setting the nodewebkit flag, but it can't be set to true. It needs to be set to your version of nodewebkit, so that it can be used by nw-gyp as you noticed.

This should be fixed now in https://github.com/nodegit/nodegit/pull/339

Fixed and merged.


[Internal] [Feature] Decide on params between standard config and nextflow.config

Which params go in which file? Do we need a standard config, or can we just do nextflow.config and test config?
Place an :x: in a Box that Best Matches the Feature's Importance:

[] 1 - Most important (absolutely integral and will not use codebase at all without it)
[X] 2-4 - Moderate (still using codebase for other functions but is serving as a blocker for future use-cases)
[] 5 - Least important (would like to see but there are no stringent expectations nor urgency for current/future use-cases)

Any Additional Context or Information? Has There Been Any Progress Made So Far Towards this Request? Any Helpful Resources to Reference? Screenshots or Links?

Removed standard.config in latest release.


Comment out CMake cyw43 vars which aren't really that useful in geneal i don't think

These can be specified via board header or target_compile_definitions

yeah, i decided to leave them for now in case we want them back


powershell 7 not showing in 32bit vscode on 64bit Windows

This PR fixes #116032
Originally, I had assumed that os.arch() gave the OS arch, but instead it gives the process arch... So I've fixed the logic to use environment variables to make sure we have the correct arch for the process and the OS.
Additionally, in order to simplify things, I've made it so only one "Windows PowerShell" option comes back and it's always the 64bit (unless we're on 32bit Windows) one because no user ever needs to use the 32bit version of Windows PowerShell..... and if they do, they can simply specify the path in the settings themselves. This will still properly handle the Sysnative path change if the user is using the 32bit version of VS Code on 64 bit Windows.
This should also handle ARM just fine.

Test plan:

Download 32bit version of VS Code and install PowerShell 7 x64 MSI
make sure you don't have a default shell set for Windows

Expected:
PowerShell 7 should show in your terminal and it should be 64bit (run [System.Runtime.InteropServices.RuntimeInformation]::ProcessArchitecture which should be X64)
Also, choose the default shell in the terminal drop down. You should see PowerShell 7 in the list.
Other Test plan:

Download 64bit version of VS Code and install PowerShell 7 x64 MSI
make sure you don't have a default shell set for Windows

Expected:
PowerShell 7 should show in your terminal and it should be 64bit (run [System.Runtime.InteropServices.RuntimeInformation]::ProcessArchitecture which should be X64)

@TylerLeonhardt you probably want to copy the verification steps to the issue, people won't see it if it's just on a PR


chore(intersection): display intersection marker only when stopped

Description
Fixed the problem that the intersection module displays a stop line at the origin when there is no need to stop.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[X] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[X] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara This is an additional fix for #2506