docs: project creation commands on pub.dev need updating

Description
The documentation on the pub.dev page appears to be out of sync with the GitHub README in the section about how to create a new package.  Specifically, the section on usage on the pub.dev site has:
Usage: very_good create <output directory>
-h, --help                    Print this usage information.
    --project-name            The project name for this new project. This must be a valid dart package name.

Whereas the README has:
Usage: very_good create <project name>
-h, --help                    Print this usage information.
-o, --output-directory        The desired output directory when creating a new project.

It appears the section in README follows the correct behavior of the CLI.  I'd offer a PR but I'm not sure how these changes manage to get published to the pub.dev site.  Thanks for looking!

Hi @danallen88 👋
Thanks for opening an issue!
We just haven't published a new version of very_good_cli yet because we're planning to lump in some other updates shortly. This should be resolved in the next few days -- sorry for the inconvenience!

My mistake, thank you for clarifying @felangel! I'll close this issue with that understanding.


Modlog: Add permission checking back

This was not included in the recent modlog refactor

Applies with hotpatch before this PR was uploaded, merging in repository after problem was fixed on main server.

By the way, thanks to 3.14geot-Mega for reporting this issue. Thanks :).


How to unbind affix after resizing window to certain width

Hello,
Is there any option to unbind affix when resizing window to certain width?
Because when resizing window to tab view, then i would like to unbind affix and want to scroll as normal.
I tried with jQuery("#container").affix("checkPosition"); but it does not work.
Any help on this would be appreciate.
Thanks
Tejas

There is no built in method to destroy the affix at present but you could add your own to affix JS file:
Affix.prototype.destroy = function() {
    // Remove scroll event
    this.$target.off('scroll.affix');

    // Remove inline styles
    this.$element.removeAttr('style');
};

You'll also need to amend this line to read like so:
this.$target.on('scroll.affix', $.proxy(this.checkPosition, this));
Finally call the method whenever you want to destroy it:
$('#container').affix('destroy');


Python 3.12 support - RuntimeError

Problem Statement
Tried using sentry with python 3.12. Ran into newly implemented RuntimeError tests. Want to give a heads up for once there is 3.12 (hopefuly after 3.11 https://github.com/getsentry/sentry-python/issues/1950 🤞 ) support that this is something that will probably need fixing(?)
Example traceback (source):
Exception ignored in atexit callback: <function AtexitIntegration.setup_once.<locals>._shutdown at 0x7fa77fa24e00>
Traceback (most recent call last):
  File "/builds/4704997395/software/venv/lib64/python3.12/site-packages/sentry_sdk/integrations/atexit.py", line 61, in _shutdown
    client.close(callback=integration.callback)
  File "/builds/4704997395/software/venv/lib64/python3.12/site-packages/sentry_sdk/client.py", line 580, in close
    self.flush(timeout=timeout, callback=callback)
  File "/builds/4704997395/software/venv/lib64/python3.12/site-packages/sentry_sdk/client.py", line 604, in flush
    self.transport.flush(timeout=timeout, callback=callback)
  File "/builds/4704997395/software/venv/lib64/python3.12/site-packages/sentry_sdk/transport.py", line 525, in flush
    self._worker.submit(lambda: self._flush_client_reports(force=True))
  File "/builds/4704997395/software/venv/lib64/python3.12/site-packages/sentry_sdk/worker.py", line 117, in submit
    self._ensure_thread()
  File "/builds/4704997395/software/venv/lib64/python3.12/site-packages/sentry_sdk/worker.py", line 42, in _ensure_thread
    self.start()
  File "/builds/4704997395/software/venv/lib64/python3.12/site-packages/sentry_sdk/worker.py", line 70, in start
    self._thread.start()
  File "/builds/4704997395/software/venv/lib64/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 56, in sentry_start
    return old_start(self, *a, **kw)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/threading.py", line 971, in start
    _start_new_thread(self._bootstrap, ())
RuntimeError: can't create new thread at interpreter shutdown

cpython commit adding this "detection": https://github.com/python/cpython/commit/ce558e69d4087dd3653207de78345fbb8a2c7835
Solution Brainstorm
Some sort of "graceful shutdown" on exit perhaps?

We got to work around this by closing sentry manually at the end of our programs 🤷

Thanks for the heads up @Toaster192!

Would be great to have this fixed now that Python 3.12 is officially released.

Agreed @jnoordsij. We're currently figuring out what we need to fix 3.12, this is definitely on the list.

Looking at #1950, is there some hope hat it will not take month(s) for 3.12 support? Even more so considering that 3.11 was just about (non-technical) metadata, while there's an actual issue with 3.12 right now which is not necessarily a blocker but at least a bit annoying when an application has CLI tools for example where this exception gets raised.

We have a PR open for supporting 3.12, but we can not give you an estimate on when it will be merged/released:
https://github.com/getsentry/sentry-python/pull/2408

I'm also seeing this issue when terminating a Sanic server
^C[2023-10-14 15:38:55 -0400] [18739] [INFO] Received signal SIGINT. Shutting down.
[2023-10-14 15:38:55 -0400] [18739] [INFO] Server Stopped
Exception ignored in atexit callback: <function AtexitIntegration.setup_once.<locals>._shutdown at 0x103eb0c20>
Traceback (most recent call last):
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sentry_sdk/integrations/atexit.py", line 61, in _shutdown
    client.close(callback=integration.callback)
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sentry_sdk/client.py", line 618, in close
    self.flush(timeout=timeout, callback=callback)
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sentry_sdk/client.py", line 646, in flush
    self.transport.flush(timeout=timeout, callback=callback)
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sentry_sdk/transport.py", line 549, in flush
    self._worker.submit(lambda: self._flush_client_reports(force=True))
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sentry_sdk/worker.py", line 117, in submit
    self._ensure_thread()
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sentry_sdk/worker.py", line 42, in _ensure_thread
    self.start()
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sentry_sdk/worker.py", line 70, in start
    self._thread.start()
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 56, in sentry_start
    return old_start(self, *a, **kw)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 971, in start
    _start_new_thread(self._bootstrap, ())
RuntimeError: can't create new thread at interpreter shutdown
Traceback (most recent call last):
  File "/Users/robd/code/allfactors-sanic/src/af_events.py", line 1455, in <module>
    app.run(host='<IP_ADDRESS>', port=8081, workers=2, access_log=False, debug=False)
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sanic/mixins/startup.py", line 209, in run
    serve(primary=self)  # type: ignore
    ^^^^^^^^^^^^^^^^^^^
  File "/Users/robd/code/allfactors-sanic/env/lib/python3.12/site-packages/sanic/mixins/startup.py", line 880, in serve
    sock.shutdown(SHUT_RDWR)
OSError: [Errno 57] Socket is not connected
Sentry is attempting to send 2 pending events

This also occurs when running migrations.
python .\src\manage.py migrate
2023-10-20 09:44:42,475 DEBUG __init__: couldn't import psycopg 'c' implementation: No module named 'psycopg_c'
Operations to perform:
  Apply all migrations: <bunch of apps>
Running migrations:
  No migrations to apply.
Exception ignored in atexit callback: <function AtexitIntegration.setup_once.<locals>._shutdown at 0x000001F382D9B380>
Traceback (most recent call last):
  File "C:\Users\user\.virtualenvs\sad-django\Lib\site-packages\sentry_sdk\integrations\atexit.py", line 61, in _shutdown
    client.close(callback=integration.callback)
  File "C:\Users\user\.virtualenvs\sad-django\Lib\site-packages\sentry_sdk\client.py", line 618, in close
    self.flush(timeout=timeout, callback=callback)
  File "C:\Users\user\.virtualenvs\sad-django\Lib\site-packages\sentry_sdk\client.py", line 646, in flush
    self.transport.flush(timeout=timeout, callback=callback)
  File "C:\Users\user\.virtualenvs\sad-django\Lib\site-packages\sentry_sdk\transport.py", line 549, in flush
    self._worker.submit(lambda: self._flush_client_reports(force=True))
  File "C:\Users\user\.virtualenvs\sad-django\Lib\site-packages\sentry_sdk\worker.py", line 117, in submit
    self._ensure_thread()
  File "C:\Users\user\.virtualenvs\sad-django\Lib\site-packages\sentry_sdk\worker.py", line 42, in _ensure_thread
    self.start()
  File "C:\Users\user\.virtualenvs\sad-django\Lib\site-packages\sentry_sdk\worker.py", line 70, in start
    self._thread.start()
  File "C:\Users\user\.virtualenvs\sad-django\Lib\site-packages\sentry_sdk\integrations\threading.py", line 56, in sentry_start
    return old_start(self, *a, **kw)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\users\user\.pyenv\pyenv-win\versions\3.12.0\Lib\threading.py", line 971, in start
    _start_new_thread(self._bootstrap, ())
RuntimeError: can't create new thread at interpreter shutdown

Yes, I think it always happens when the Python interpreter exits while the sentry SDK is 'active'...

Thanks for all the input! We will try to tackle this soon!

Hey everybody,
we just released an update that should fix this problem: https://github.com/getsentry/sentry-python/releases/tag/1.33.0
Could you give it a try @Toaster192 @robd003 and @ethrgeist ?

Looks good, CLI and reload spam is gone, thank you very much!

Hi team, I am getting this error everytime a program has to exit:
I am using python 3.12 and sentry-sdk==1.14.0
Exception ignored in atexit callback: <function AtexitIntegration.setup_once.<locals>._shutdown at 0x7f1cc3949940>
Traceback (most recent call last):
  File "/opt/dataDumper/myenv/lib/python3.12/site-packages/sentry_sdk/integrations/atexit.py", line 62, in _shutdown
    client.close(callback=integration.callback)
  File "/opt/dataDumper/myenv/lib/python3.12/site-packages/sentry_sdk/client.py", line 482, in close
    self.flush(timeout=timeout, callback=callback)
  File "/opt/dataDumper/myenv/lib/python3.12/site-packages/sentry_sdk/client.py", line 504, in flush
    self.transport.flush(timeout=timeout, callback=callback)
  File "/opt/dataDumper/myenv/lib/python3.12/site-packages/sentry_sdk/transport.py", line 492, in flush
    self._worker.submit(lambda: self._flush_client_reports(force=True))
  File "/opt/dataDumper/myenv/lib/python3.12/site-packages/sentry_sdk/worker.py", line 113, in submit
    self._ensure_thread()
  File "/opt/dataDumper/myenv/lib/python3.12/site-packages/sentry_sdk/worker.py", line 42, in _ensure_thread
    self.start()
  File "/opt/dataDumper/myenv/lib/python3.12/site-packages/sentry_sdk/worker.py", line 70, in start
    self._thread.start()
  File "/opt/dataDumper/myenv/lib/python3.12/site-packages/sentry_sdk/integrations/threading.py", line 54, in sentry_start
    return old_start(self, *a, **kw)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/threading.py", line 992, in start
    _start_new_thread(self._bootstrap, ())
RuntimeError: can't create new thread at interpreter shutdown

the fix was released in 1.33.0


REST services parameter handling enhancements

An attempt to smooth out some of the edges around the REST API and how it handles parameter parsing, specifically:

Fixes errors from unconverted assignments of primitive Object[] arrays to fields
Improves error logging for diagnostics/troubleshooting
Adds null checks for optional/missing parameters

Arg, mis-clicked. :)

Coverage decreased (-1.3%) to 44.974% when pulling 04c04b9c39989a6cb42886a0cf53dd6050d2588e on dbazile:restservices-params-handling into adf9059857b5d4890773ad1db6d23e9af3e60a7e on locationtech:master.

Coverage decreased (-1.3%) to 44.974% when pulling 04c04b9c39989a6cb42886a0cf53dd6050d2588e on dbazile:restservices-params-handling into adf9059857b5d4890773ad1db6d23e9af3e60a7e on locationtech:master.


ETL fails for food explorer due to too many open files

Got this on M1 MacOS 12.4 (Monterey), after trying to rebuild the ETL on latest master:
2. data://garden/explorers/2021/food_explorer...
Traceback (most recent call last):
  File "/Users/lars/Documents/owid/etl/.venv/lib/python3.9/site-packages/nbclient/client.py", line 602, in setup_kernel
    yield
  File "/Users/lars/Documents/owid/etl/.venv/lib/python3.9/site-packages/papermill/clientwrap.py", line 45, in execute
    self.papermill_execute_cells()
  File "/Users/lars/Documents/owid/etl/.venv/lib/python3.9/site-packages/papermill/clientwrap.py", line 72, in papermill_execute_cells
    self.execute_cell(cell, index)
  File "/Users/lars/Documents/owid/etl/.venv/lib/python3.9/site-packages/nbclient/util.py", line 85, in wrapped
    return just_run(coro(*args, **kwargs))
  File "/Users/lars/Documents/owid/etl/.venv/lib/python3.9/site-packages/nbclient/util.py", line 48, in just_run
    loop = asyncio.new_event_loop()
  File "/Users/lars/.pyenv/versions/3.9.7/lib/python3.9/asyncio/events.py", line 761, in new_event_loop
    return get_event_loop_policy().new_event_loop()
  File "/Users/lars/.pyenv/versions/3.9.7/lib/python3.9/asyncio/events.py", line 659, in new_event_loop
    return self._loop_factory()
  File "/Users/lars/.pyenv/versions/3.9.7/lib/python3.9/asyncio/unix_events.py", line 54, in __init__
    super().__init__(selector)
  File "/Users/lars/.pyenv/versions/3.9.7/lib/python3.9/asyncio/selector_events.py", line 61, in __init__
    self._make_self_pipe()
  File "/Users/lars/.pyenv/versions/3.9.7/lib/python3.9/asyncio/selector_events.py", line 108, in _make_self_pipe
    self._ssock, self._csock = socket.socketpair()
  File "/Users/lars/.pyenv/versions/3.9.7/lib/python3.9/socket.py", line 606, in socketpair
    a, b = _socket.socketpair(family, type, proto)
OSError: [Errno 24] Too many open files

@pabloarosado Something to check out for next week.

Hi @larsyencken , this PR by @Marigold should fix that issue. For the time being before merging it, the workaround is to do ulimit -n 4096 before executing the food explorer step.

@pabloarosado thanks for chiming in, you're right. I've just merged that PR and closing this.


Connect frontend to backend API

This is a discussion issue where you can suggest your ideas on how we might integrate our backend with the frontend.
e.g. Using Axios or react-query for data fetching, how to model global state, etc.
Separate issues will be created for specific functionality later on.

According to me, Axios should be used for the API calls. Regarding the react part @salil-naik can comment better.

According to me, Axios should be used for the API calls. Regarding the react part @salil-naik can comment better.

I would like to handle this issue

@rajesh6161 As you can see, it's kind of a discussion issue. There will be separate issues for connecting different components of front end to the backend.

Hey as per me, we have many option to connect frontend with backend ,
1> we can use passport or any other library for handling user cookies,sessions and all with easy methods .
2> we can implement alll things manually means handle cookie and sessions manually
And axios is best because it provides many options like with-credentials etc and also there is big community , so that we can easily find the any query solution
Also i implemented all things in my project and it's works great😎

@nishant23122000 Would you like to work on some part of the integeation? As the integration of the whole API will be a very big task. Please note we aren't using passport js. And please go through the API and also the react app for a better understanding of the codebase so that you can integrate the API properly.

@gauravdas014  Yes, I like to contribute in this part because i already familiar on this and also i already understood the codebase of front and back

@nishant23122000 Please create separate issues for each section of integration and start working


[Change request to #3193]

Description of a Change request:
Minor changes in functionality
Event type "Offline" transformed to an Event type "Place"
Reason for Change:
To clarify some misunderstanding moments
Mockups
1 день https://www.figma.com/file/092AhCGadc1Hq8nAysxmYB/ITA-Greencity-%D0%A3%D0%91%D0%A1?type=design&node-id=50699-47722&mode=design
2 дня https://www.figma.com/file/092AhCGadc1Hq8nAysxmYB/ITA-Greencity-%D0%A3%D0%91%D0%A1?type=design&node-id=50699-55581&mode=design
Acceptance Criteria
According to the original order
6. Add: By default the System sets up a current date.
7. Event time. By default the System sets up current time +1 hour.
7.1. The User should be able to choose: "Start Time", "End Time" or choose an option "All day". If the User choose "All day" then the System makes time dropdown lists as inactive, and sets up time by default: "Start Time" - 00:00, "End Time" - 23:59.
The time input format must be 24 hours.
7.1.1. If the User selected "All day" and Event date is current the System sets up the beginning time by default: "Start Time" - 00:00 , "End Time" - 23:59.
7.2. The User shouldn’t be able to choose the past time in the case if a current date is chosen in AC#6.
7.3. In case user want to enter specific time he should do it manually with step in 30 min in "Set Start Time" and "Set End Time" boxes. If the user enter specific time in not define format the System show red error message “Incorrect Time format. Use format 00:00 +30min”.
9, 11. Add See US #4232
13. _Add:_When the User is typing then the System should calculate and display in real time how many characters was typed by the User. If the User exceeds the max. quantity of entered symbols (>63206) then the System changes this informational text into the red color.

20. Add: Checkboxes "Place"/"Online", Quick filters markers "Initiative type"/"Event type" are mandatory to choose by the User.
Impact of Change
#3193 #4234 #4232
Epic: #3194

Reproduces again, does not highlight in red if there are to many characters.


Maintain Chapter 9 Testing cairo programs

[ ]  Error Handling (10) should be moved just before Testing cairo programs (9), as assert! is widely used in testing chapter without being introduced
[ ] 9-1: ‘’For now … on the function’’ should be removed as we explain the first line just after
[ ] 9-1: #[cfg(test)] attribute never described in this section, we should do it , at least a small reference to the next section (testing organization)
[ ] 9-1: In should_panic section, the last snippet of code is supposed to introduce a bug via swapping bodies but this is not done
[ ] 9-1: print() call in benchmarking the gas usage example should be replaced by println!
[ ] 9-2: Introduction phrase should be modified as public/private functions are now possible with pub attribute
[ ] 9-2: cfg(tests) should be cfg(test)

Are these tasks still available?

@Joy-Adah  sorry no this is not available


Re-deploying docker container from scratch

Hello,
I just deployed gogs with docker, accessed the application and performed main configurations (databases, admins, etc). Now I want to remove that docker container and build a new one with a different configuration. I did rm -rf /var/gogs and mkdir -p /var/gogs again, removed the container, started a new one, but I cannot access the first set up configuration page.
How to rebuild the container from scratch?
Thanks

Based on https://github.com/gogits/gogs/tree/master/docker, you only need change configuration file at /var/gogs/gogs/conf/app.ini.


fix docker file

currently docker file won't build. I guess there may be an extra "echo"

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


switch to using Deployments rather than DeploymentConfig on OpenShift when not using ImageStreams

DeploymentConfig's are quite a bit worse to use than Deployments due to the extra deploy pods that sometimes timeout/fail, stay around, add confusion - whereas Deployments seem pretty rock solid! I've never seen a Deployment ever not deploy or timeout - whereas I've seen that happen lots with DCs.
So I wonder should we avoid DeploymentConfigs when not using ImageStreams on OpenShift? I guess we could make it a flag so folks could decide to keep DCs if they really want; but I'd have thought sticking with standard kubernetes resources OOTB sounds a nicer default (providing folks are not using ImageStreams)

Isn't there more to DeploymentConfigs than only support for image stream ? E.g. like various, image stream independent, triggers for a redeployment ? Are triggers supports by plain Deployment's too ? (couldn't find anything like this in the API)

@jstrachan any comments?

I don't see much value in a DeploymentConfig if not using ImageStreams; the DC related triggers only really relate to image streams. Plus there's lots of negatives - they require a pod each time a deployment happens which uses up quota & adds lots of confusion to users looking at pods on the CLI or in a console - plus they timeout unlike Deployments; we've also seen them behave odd at times ;).
In general I'm thinking fabric8-maven-plugin should always use DeploymentConfigs if using ImageStreams; but if not we should probably default to Deployments - or at least have a flag to switch either way.
I guess we can debate which side of the fence the OOTB should be if not using ImageStreams; but we should definitely allow developers to pick either Deployments or DeploymentConfigs for sure.
e.g. if you are targeting something like OpenShift Online - then just switching to Deployments will use less quota for your app with no real loss of functionality plus it'll be using standard kubernetes resources too & be less confusing if folks look at the pods.

@jstrachan fyi, DC triggers also work with plain Docker images, i.e. OpenShift periodically polls the Docker registry for updates (that's how we use it in Syndesis). Also, DCs can trigger on config changes (again not sure how plain Deployments react here). So I think DCs have a value even when not used with image streams.
Agreed, that the deployment pod can be a pita, especially when tight quotas apply like on OpenShift online (we also struggled with that, that certain deployments failed, because too much happened in parallel and so only 4 of 7 deployments succeed because of quota restrictions).
We should allow all sort of combinations via configuration, with some sane defaults. Still tend for the OpenShift case to DCs as default (with being overwritable to use plain Deployments).

@rhuss the docker DC triggers are only useful if you rebuild images and use latest right? If you are using specific image labels in your DC/Deployment then the DC image triggers have no point right as you have to change the DC/Deployment anyway to use a different image label? As you're not really supposed to recreate images with the same label (other than latest).
Plain Deployments redeploy on changes to the Deployment (e.g. to change from 1.2.3 to 1.2.4 of the image version) so they work the same as 'config triggers' AFAIK

correct, only for 'latest' such a detection works (or when you overwrite a Docker tag, what you shouldn't do, of course). But for sharing current, snapshot work via a registry still useful imo.

I guess thats another check - if folks are using 'latest' for the docker image then DC has some value - otherwise its got negative value.
FWIW in the fabric8 ecosystem we never use latest - which is fairly hard to reason about - and we tend to use concrete versions; they are so much easier to reason about. Even when generating temporary images for PRs so we can test them (e.g. like these comments) we use separate labels for each commit on a PR so you can easily test differences more easily.
e.g. see the comments from @fabric8cd on this PR
https://github.com/fabric8-ui/fabric8-ui/pull/1978
we generate a docker image for each commit on a PR which can be tested on any docker-compatible enviroment - then we also run the UI using this PR image at the given URL (or run system tests using the image etc). Note that the UI for each PR is taken down after the PR merges so those links to the UI won't work any more on that PR - but you'll hopefully get the idea of how you can use those links during a PR review/approve/test

@jstrachan forgive me for naive question, but how to check if build is using image stream or docker stuff.
My assumption is fabric8.build.strategy flag.

Yeah - the fabric8:build goal decides whether to use an image stream or not.
I guess to keep things simple (as the fabric8:resource goal is often ran independently of the fabric8:build) we could just have a mode to default to DeploymentConfig on OpenShift but have a property/flag we could enable to default to always using Deployment - which would then fail if users tried to use an ImageStream

Hi, I'm working on this issue. But i have a doubt; If we prefer Deployments rather than DeploymentConfig in the build strategy, the image is not getting resolved.
But in case of DeploymentConfig it seems to work fine.
My question is: After building the image, what changes we need to accommodate in the build section as well? Or is it fine to have it in deployment for now?

@jstrachan : Please share your thoughts on this.

@rohanKanojia what kind of project are you trying this on? Is it using an image stream or not. So long as there is a docker image available (try docker pull foo on the CLI to check) - then you should be able to refer to that image in a Deployment just fine - afterall thats how fabric8 works on kubernetes

@jstrachan : I'm using samples/spring-boot project in fmp's code directory. And while building i'm using mvn -Dfabric8.build.strategy=docker clean install , i think that uses image stream

I wonder if you use -Dfabric8.mode=kubernetes if it will disable the use of ImageStreams


Pull request for code review - Portfolio mobile design for content cards and grid elements

This design takes the structure from template 1 on this Figma file with a few changes on the icons, background and font sizing.
For this PR, new sections containing cards featuring works and using grids are shown. The style.css file as been modified to improve how close to the original design the live version is.

@brianconnect93 All done, thank you


Refresh access_token with refresh_token?

I'm using the general oauth2 with username/password and custom grant_type flow to sign in, which works quiet well, but I see the library doesn't refresh the access token?
Am I missing something here or is this a missing feature?
I mean it's part of oauth2 with grant_type of "refresh_token".

It's a bit hard to follow your question, could you make a minimal repro (e.g. on StackBlitz) with your setup?
I gather you're using the Resource Owner Password flow? I'm not sure if automatic refresh is supported, you might need to trigger this yourself. Not sure.
Either way, have you checked these docs? Maybe they would help?

https://oauth.net/2/grant-types/refresh-token/
I’m talking about this.
This is not supported as far as I could see.

I’ve found an older issue which was closed with a reason, because it’s not secure to store refresh tokens on the client.
But I’m not sure whether it is the responsibility of the library to decide what to use and what not. If you want to support oauth2 standard in all its flavors, then this is simply a missing feature.

Yes, according to the specs, refresh_tokens are not allowed within the browser. However, beginning with version 8 of this library, we support code flow+pcke and for this flow, the current best practices document proposes that one can use refresh_tokens when they take care about several things.
B/c of this, refresh_tokens are supported for code flow beginning with version 8. The same holds true for password flow. In both cases you just have to call refreshToken() or you can set up automatic token refresh (see docs)
They are still not supported when using implicit flow b/c no standard allows this combination.
Does this info help?

Assuming the original question got answered with previous comment(s). Please do let us know if there's a reason for keeping the issue open and we'll reopen!


Register josh.is-cool.dev

Added josh.is-cool.dev using the CLI.

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

Please sign the CLA.

I have read the CLA Document and I hereby sign the CLA

recheck


Upgrade to BouncyCastle.Cryptography

BouncyCastle.Portable has been deprecated a while ago and replaced with BouncyCastle.Cryptography.
https://github.com/bcgit/bc-csharp
Given how important updated cryptographic algorithms are I would suggest that an update to this library is needed.
I have tried to see how much effort is involved in this update, and found that only requires a couple of minor changes
https://github.com/pablopioli/certes/commit/00b7115cfc9145aa5f7ba367c6f2ef4e7dda29c9
A pull request for this will be useful?

Yes please! It makes certes hard to use in cooperation with other packages, since the portable DLL has name conflicts with their official one. As you can imagine, this causes problems for people that use other packages that have updated their packages. (MimeKit comes to mind)


miot and hoobs

Describe the bug
A clear and concise description of what the bug is.
Can't find Discover All Devices via MiCloud
Expected behavior
A clear and concise description of what you expected to happen.
Trying to obtain token for Roborock S7 on hoobs

You either have to go to the homebridge ui and in the miot settings area you will find the button. Another option is that you use the command line tools to get the tokens.

Hi,
Thank you for your reply. I am new to homebridge, so I bought HOOBS due to my lack of knowledge.
I tried to install homebridge, and I can't get it to work with HOOBS.
With the command line miot cloud-devices -u  -p  is the username and password my mi username and password?
Thank you so much.

Homebridge is already included in hoobs, you just need to visit the ui.
For cli:

miot cloud login -u user -p password
miot cloud list-devices

Hi,
Thank you for the help. Is there any article for visiting homebridge UI via hoobs?

Just look for homebridge ui and I am sure you will find info about it.
It is called homebridge-config-ui-X


[Generate project with Mason] Add the generated code to develop branch after merging a pull request

Why
When implementing a feature or fixing a bug/ chore, there should be a generated project to demonstrate the template's work. So, we will do this step automatically by running a job in CICD after a pull request is merged to develop.

To ensure the generated project works properly, the project should be buildable and runnable before pushing the generated code.
The CICD steps should be:
Generate the project with Mason.
Run code generator and unit test for the generated project.
If there is no error, do push a commit with the generated project to develop branch under generated/ directory. (we can remove the old generated project before pushing a new code to get rid of conflicting).

Who Benefits?
Developers

@manh-t I combined this ticket with #159, I'll close this ticket.


Add missing node groups for multicell nodeset

Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/2491

recheck

recheck


feat: add ability to use selector as Node

The issue I'm seeing here is that when setting up editor selector must be an argument of querySelector.
const editor = new Yace("#editor", { ... });

I propose that it allows developer to use their own containers. This is useful for adding multiple dynamic editors to dom.
const container = document.createElement('div';)
const editor = new Yace(container, { ... });

Great, thanks!

This feature is available in 0.0.6 version


hwcrypto.js IE10 error

Hi.
Does it support IE9 and IE10 browsers?
If I click sign on https://open-eid.github.io/hwcrypto.js/sign.html the page generates error(console output):
hwcrypto.js activated
Autodetecting best backend
Assuming IE BHO, testing
Loading plugin for application/x-digidoc into hwcapplicationxdigidoc
Using backend: undefined
Error
{
[functions]: ,
description: "",
message: "",
name: "Error",
number: -2147352567,
stack: "Error
at Anonymous function (https://open-eid.github.io/hwcrypto.js/hwcrypto.js:113:21)
at Promise (https://open-eid.github.io/hwcrypto.js/js/lib/npo.src.js:264:4)
at getCertificate (https://open-eid.github.io/hwcrypto.js/hwcrypto.js:111:13)
at fields.getCertificate (https://open-eid.github.io/hwcrypto.js/hwcrypto.js:251:9)
at sign (https://open-eid.github.io/hwcrypto.js/sign.html:58:5)
at onclick (https://open-eid.github.io/hwcrypto.js/sign.html:128:36)"
}
Error: 0 with:
Unknown error: 0 with:
(was using IE11 with IE10 Document mode emulation)
Thank You.

Just received a report that <meta http-equiv="X-UA-Compatible" content="IE=10; IE=9; IE=8;" /> in the document makes things bad. This needs a bit research and documentation, turning off the emulation might help ?

With emulation turned off it works fine. But unfortunately we have to support IE9+

This can probably be solved with #6

This has been fixed in bcf6e4dfb87 and shall be released as 0.0.8 in near minutes


helm repo not found

Error: looks like "https://github.com/alibaba/kubeskoop/charts" is not a valid chart repository or cannot be reached: failed to fetch https://github.com/alibaba/kubeskoop/charts/index.yaml : 404 Not Found

@clcc2019
You can add a charts repository by following the following command?
$ helm repo add kubeskoop https://github.com/alibaba/kubeskoop/charts


revise UpdateStatement for revert-sql usage.

Pull Request Test Coverage Report for Build 7669

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.109%

Totals

Change from base Build 7668:
0.0%

Covered Lines:
8700

Relevant Lines:
15787

💛  - Coveralls


advanced basis turned off as default option to avoid conflicts with b…

…arrier method
Please confirm that this PR has done the following:

[ ] Tests Added
[ ] Documentation Added
[x] Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md
Please add a single line in the release notes similar to the following:
- (#XX)[http://link-to-pr.com] Added feature which does something

closes #66
as discussed at the group meeting right now, being merged; documentation for other advanced GAMS options to be added as part of the documentation drive (see #71 )

Switching off advanced basis in combination with the default lpmethod = 6 (concurrrent) is not too useful, because simplex (primal and dual) are usually part of the methods used by the concurrent threads. I would therefore suggest to make lpmethod = 4 (barrier) the default in cplex.opt.


public share bug fixes

This fixes the bug reported by Jake. Publicly shared system does not need explicit READ permission for user.

@richcar58 yes, I thought about that. Then we will make two calls one for ~public and another for the user. I can do that change as well.


Included extraObjects example in flux2/values.yaml doesn't appear to work.

Describe the bug a clear and concise description of what the bug is.
extraObjects cannot refer to Flux CRDs as shown in the example flux2/values.yaml file.
What's your helm version?
v3.12.3
What's your kubectl version?
v1.28.1
What's the chart version?
2.9.2
What happened?
I received an error when trying to set up a Bucket and a Kustomization when installing flux2 via Helm.
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [resource mapping not found for name: "source" namespace: "flux-system" from "": no matches for kind "Bucket" in version "source.toolkit.fluxcd.io/v1beta2"
ensure CRDs are installed first, resource mapping not found for name: "source" namespace: "flux-system" from "": no matches for kind "Kustomization" in version "kustomize.toolkit.fluxcd.io/v1"
ensure CRDs are installed first]

What you expected to happen?
Either the extraObjects are successfully installed after flux CRDs or there's no flux CRDs in the example values.yaml, if it's not technically possible.
How to reproduce it?
Include extraObjects in custom values.yaml that refer to Flux CRDs.
Enter the changed values of values.yaml?
imageAutomationController:
  create: false
imageReflectionController:
  create: false
sourceController:
  tolerations:
    - key: node-role.kubernetes.io/control-plane
      effect: NoSchedule
  nodeSelector:
    node-role.kubernetes.io/control-plane: ""
helmController:
  tolerations:
    - key: node-role.kubernetes.io/control-plane
      effect: NoSchedule
  nodeSelector:
    node-role.kubernetes.io/control-plane: ""
kustomizeController:
  tolerations:
    - key: node-role.kubernetes.io/control-plane
      effect: NoSchedule
  nodeSelector:
    node-role.kubernetes.io/control-plane: ""
notificationController:
  tolerations:
    - key: node-role.kubernetes.io/control-plane
      effect: NoSchedule
  nodeSelector:
    node-role.kubernetes.io/control-plane: ""
extraObjects:
  - apiVersion: source.toolkit.fluxcd.io/v1beta2
    kind: Bucket
    metadata:
      name: source
      namespace: flux-system
    spec:
      interval: 1m
      provider: generic
      bucketName: source
      endpoint: minio.flux-system.svc.cluster.local:9000
      insecure: true
      secretRef:
        name: bucket-credentials
  - apiVersion: kustomize.toolkit.fluxcd.io/v1
    kind: Kustomization
    metadata:
      name: source
      namespace: flux-system
    spec:
      interval: 1m
      sourceRef:
        kind: Bucket
        name: source
      path: ./environments/local
      prune: true
      timeout: 1m

Enter the command that you execute and failing/misfunctioning.
helm install \
    --version 2.9.2 \
    --namespace flux-system \
    --repo https://fluxcd-community.github.io/helm-charts \
    --values cluster/flux2-values.yaml \
    flux2 flux2

Anything else we need to know?
I'll spend some time checking if this is a limitation in Helm, I'm not familiar with authoring charts.
Thank you!

I did attempt to add helm.sh/hook annotations to my CRs, and it appears to work once, but the next few retries still gave the same errors.
So it may have had no effect.

I'm going to close this. I do believe that I had some typos when trying the helm.sh/hook annotations. Today I've tried them again and they are working consistently. For reference, a working example bucket looks like:
extraObjects:
  - apiVersion: source.toolkit.fluxcd.io/v1beta2
    kind: Bucket
    metadata:
      name: local-sync
      namespace: gitops-system
      annotations:
        helm.sh/hook: post-install # omitting this annotation causes install to fail


minimal functional chemical_converion_process.yaml

I update the data example to include a representation of a source_concentration to reflect the protocol that this was supposed to capture, and show the difference between the two types of concentrations:

Make 75 μL Digestion Solution by dissolving 4μg trypsin in 75 μL 50mM Ammonium Bicarbonate Solution provided with the FASP Kit to a final concentration of 0.05μg/μL.

Thanks @anastasiyaprymolenna

we should merge in

https://github.com/microbiomedata/berkeley-schema-fy24/pull/97

we should merge in

add proteolyticEnzymeEnum descriptions #97

agreed. Brynn wanted me to review it at the metadata meeting today first, and then yes we should merge it in!

Addressing https://github.com/microbiomedata/nmdc-schema/issues/1842

@picowatt @corilo Please check to make sure the changes to the ChemicalConversionProcess did not leave any relevant information out that could be used to inform workflows.

Superficially these changes don't seem to impact the proteomics workflow with the caveat that what these changes capture is very  much outside of my wheelhouse. @pdpiehowski this one might require you to inspect https://github.com/microbiomedata/berkeley-schema-fy24/pull/100/files.


Replaced DynamicResponse with BulkResponse

This is the change which motivated me to update ES sink for NEST 2.0 compatibility. EmitBatchChecked return type is not very generic and hard to handle DynamicResponse, but rather very specific and much less error prone to handle BulkResponse. Result of ES bulk indexing request can be checked for success (and errors may be reported otherwise) much faster and easier than before.
This time net40 is not forgotten and all tests are passing!

What I personally don't like is that this introduces a Json.NET transient dependency by including NEST.
We could include a dedicated BulkResponse class instead of relying on DynamicResponse. The low level client also supports deserialization to types out of the box albeit using SimpleJSON (internalized dep of ES.NET).

How about that:
``
   /// <summary>
    /// Emit a batch of log events, running to completion synchronously.
    /// </summary>
    /// <param name="events">The events to emit.</param>
    /// <returns>Response from Elasticsearch</returns>
    protected virtual ElasticsearchResponse<T> EmitBatchChecked<T>(IEnumerable<LogEvent> events) where T : class
    {
        // ReSharper disable PossibleMultipleEnumeration
        if (events == null || !events.Any())
            return null;

        var payload = new List<string>();
        foreach (var e in events)
        {
            var indexName = _state.GetIndexForEvent(e, e.Timestamp.ToUniversalTime());
            var action = new { index = new { _index = indexName, _type = _state.Options.TypeName } };
            var actionJson = _state.Serialize(action);
            payload.Add(actionJson);
            var sw = new StringWriter();
            _state.Formatter.Format(e, sw);
            payload.Add(sw.ToString());
        }
        return _state.Client.Bulk<T>(payload);
    }

Those who already have Jason.NET in their projects can use BulkResponse. Those who don't my continue to use DynamicResponse.

I liked the fact that we did use the low level elasticsearch.net library only. Introducing NEST and JSON.NET for this add extra weight. So I rather prefer your other solution then.
Furthermore; I really think we should drop .NET 4 support since Elasticsearch.net even does not support it any more. See the PR #32 for this.
I also think we can use dynamics for it and provide something like this: https://github.com/serilog/serilog-sinks-elasticsearch/blob/handlefailures/src/Serilog.Sinks.Elasticsearch/Sinks/ElasticSearch/ElasticSearchSink.cs#L60
Would that not suffice too?

I agree with dropping .NET 4 any moment - please do!
Regarding our original topic - people may have very different strategy for handling ES request failures. For my purposes using standard test stream based SelfLog is not sufficient. I use more complex logger and more specialized strategy to handle ES failures.
Based on that I'm going to close this PR - also don't want to add unnecessary weight.
Instead I will open another PR with generics based solution shortly.


Generic Lobby improvements

Ideas for improvement:

[ ] Poll for changes to state so that refreshes are not required.
[ ] Option to automatically remove room if all users leave the room
[ ] Add optional unique name check
[ ] Add optional limit for rooms (will disable 'create room' button if rooms number reached limit)
[ ] Provide ability to customize ui when waiting for an API call (i.e. loading state)
[ ] Rename gameInstances to rooms (easier to understand).
[ ] Show leave button even if the game is ready to play.

One use case I want to bring to everybody's attention... My project will have several games, and I want people to choose the game after creating the lobby.
Is it ok if we key only by lobby id instead of both game and id? I can work on this latter

@flamecoals What do you mean? Multiple lobbies? Couldn't you just filter which games to display however you like? Or do you mean the games will be hosted on many different game servers too, or something like that?
Right now players choose the game to play IN the lobby, they don't create lobbies.

Yes, I'm envisioning just one global lobby, and you can create games inside that lobby (each game can be a different kind). Players then join the game you created in order to play.

@blunket I meant one global lobby like Nicolo said. Basically a "room" persisting across matches too, of different types of games.
Use case:

We and my friend Joe want to play some games, but we dont know exactly what
We create a lobby for us, and we agree in playing Chess inside the lobby
After the chess match is done, we go back to the same lobby and agree in playing tic tac toe

and so on

I see, I think you mean sort of like a party system? That'd be cool.

Hey folks, I started a document for documenting and designing all these ideas we were talking about:
https://docs.google.com/document/d/1K0xDlyS_80WJic7GfNobl-SujfC8_LiB55-JJnAawNM/edit?usp=drivesdk
Still WIP, but feel free to comment or add anything I am forgetting. I will update this thread whenever I think it is ready for review.

Hey folks, I finished the first pass of the design document for the lobby:
https://docs.google.com/document/d/1K0xDlyS_80WJic7GfNobl-SujfC8_LiB55-JJnAawNM/edit#
Just so nobody freaks out, I won''t do this in a single PR. I just want to get an agreement that this is the desired state and we can do small PRs towards that goal. See Development Plan section.
@nicolodavis It would be great if you could give me some clarity around "Open questions" section

@flamecoals Sent you some comments on your doc.

Ok, @nicolodavis, I replied to them. Given the points you asked are not questioning the overall idea, I think we are more or less in agreement on the path forward. I will start sending PRs so we can start implementing this. :)

I think we should have agreement on the user data storage part first, because that's a critical design feature.
Feel free to implement any of the items that don't touch that yet though.

Ok :)

Bravo for the lobby design proposal and the documentation!
I've added a few things in the description of the current behavior.

@francoijs Thanks for the help! Approved all your suggestions. I will probably do the first PR soon on this.

@flamecoals @francoijs @jasonharrison
Do you guys have thoughts about what to do about the Lobby in the Svelte world (after #432)?  We can migrate the lobby rendering components to Svelte (easy), but I'm not sure how to then hook it into the board components that users create, which might be in React / Angular or whatever.
We want the lobby to be in something generic like Svelte so that folks using the vanilla JS client also have access to it.  However, if the user chooses to code their board in React, we want the lobby to be able to instantiate it as well.

Perhaps we should use a generic render callback of some sort that the user can use to the render the game using any technology of their choice?
Current State
We pass in the React components to the lobby directly (which is itself a React component).  The Lobby then knows which component to render based on the game selected.
<Lobby gameComponents={ ... } />

Proposal
Once we migrate the Lobby to Svelte (or even if we keep it in React for that matter), I think we should expose it as a function to the end user (rather than a component).
import { Lobby } from 'boardgame.io/lobby';

const lobby = Lobby({
  games: [ ... ],

  render: (gameName, playerID, gameID, root) => {
    // This function is called once the player has chosen the game and hits "Play".
    // We can render a component using any framework of our choice
    // (including React as shown below).  We should also consult gameName
    // before deciding which component to use (not shown in this example).
    // root is just a HTMLElement on which we render our client.
    ReactDOM.render(<TicTacToe gameID={gameID} playerID={playerID} />, root);
  },
});

lobby.run();

We can also preserve the convenience of our current approach by providing a bundled renderer for React:
const lobby = Lobby({
  games: [ ... ],

  render: ReactRenderer({ gameComponents: { ... } }),
});

Is src/lobby/connection.js currently useable as a vanilla “lobby client”? Mirroring trying to develop the vanilla game client (supporting events etc.), it would be nice if there was something users could plug their own lobby rendering into that provides the basic API (list, join, leave, etc.)

Also, looking at this, it looks like an extra dependency might be needed to allow a Svelte Lobby to handle React components (and more dependencies for more frameworks). Maybe it would be better to have framework-specific packages that sit on top of the vanilla client and lobby APIs and provide components in React, Vue, etc.? (Svelte Client and Lobby components could still be used by those not using frameworks.)

Why would we need to pull in react-svelte?  Wouldn't the React dependencies be the responsibility of the developer using boardgame.io?
import { Lobby } from 'boardgame.io/lobby';

// These are in client code.
import React from 'react';
import ReactDOM from 'react-dom';

const lobby = Lobby({
  games: [ ... ],

  render: (gameName, playerID, gameID, root) => {
    ReactDOM.render(<TicTacToe gameID={gameID} playerID={playerID} />, root);
  },
});

lobby.run();

Ohhhh, I see — react-svelte is if you need to use React in your Svelte app before compiling it. Then the above looks great!
Do you think there should be some documentation on how to use LobbyConnection directly for those who don’t want to use the provided component?

LobbyConnection is just a simple REST client that invokes our API.  Do you think there is much value in making that externally visible?  I would think that people would prefer to use their favorite library to call our REST API directly as opposed to using our client wrapper.

My thinking was that we just provide the REST API (which can be consumed in many ways).  In addition to that, we also provide a default lobby implementation (that can be styled).  If someone wants to build a completely different lobby, they can go ahead and build that on top of our REST API.
Maybe what we should be focusing on is making our existing lobby generic enough that people won't see the need to re-implement it?


09 - HTML:  (Shows) Create form

Create a form in HTML to add new shows to existing list

Created the HTML page and also the form for adding a new show listing when completing Git Issue #7 .  Satisfies completion of this Git Issue #9 for creating form for adding new shows.


Provide camel-file support

Yes, they are related. camel-file can't be used in an EE environment. So, we need another way.

... and why can this not be used (at least partially)?
I understand that absolute path that point outside of $WILDFLY_HOME or $HOME are problematic. However stuff that is part of $wildfly.config.dir or $wildfly.data.dir should work, no?

The single instance most likely technically isn't an issue. It's more likely, that you run into any of or all of the following issues:
You should do everything within the Java EE container itself: you can have no certainty that you will have any consistent access to the filesystem. There are many reasons for this, the most obvious being that applications running within a container will have:

no certainty that any subsequent invocation of an any resource would even be on the same physical server with access to the same files/filesystem (e.g. upon clustering)
no possibility of interfering with each other (multiple applications attempting to write to the same file)
no security issues (one app writing confidential data which another app could read)

You should also assume that you shouldn't:

create your own threads (the container will manage this for you; if you create your own you may starve other applications in the container of CPU time)
use socket-IO (also has security issues)
(ref: http://stackoverflow.com/questions/1789597/java-ee-programmers-do-not-write-to-files)

I personally believe, that you will have a different approach to file-handling in Java EE containers anyway. Mostly through Java Content Repository API (JSR-283/170) or even through messaging or via databases.

These may be valid reasons for the application layer. However, they should not preclude the integration of the camel-file2 component. There may well be use cases where camel-file2 works just fine.
In future, we may decide to provide (alternative) components that address persistence in a cloud environment.


Delete the react front end, its not needed as react-native-web is working well

fixed: https://github.com/NigelBreslaw/guardian-ghost/pull/930


feat: adds custom bin validation

Description

feat: adds custom bin validation
refactor: improve readability in validation module

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[X] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.0.0-beta.17 :tada:
The release is available on:

npm package (@master dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add failing Queue Listener Handler Test

This PR adds a failing test to illustrate an issue with queue listener handler.

@microsoft-github-policy-service agree [company=n/a]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

Codecov Report

Merging #89 (7a7b2d0) into main (9585bc5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   88.91%   88.91%
=======================================
  Files          11       11
  Lines        2065     2065
=======================================
  Hits         1836     1836
  Misses        229      229

Impacted Files
Coverage Δ

src/picologging/handlers.py
94.48% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks for raising this, we'll take a look at the issue


Still having trouble with Modals and removeAttribute in 3.3.1

See issue #13349 and others referenced.
I have a menu with several items. Clicking on a menu item is supposed to open another modal but it crashes the whole React DOM with the error Uncaught TypeError: Cannot read property 'removeAttribute' of undefined. I have already upgraded to 3.3.1 which was supposed to fix the issue, but it is still happening. Downgrading to 3.2.2 solves the problem and everything works as expected.

How can we reproduce it?

it happen on mine too

confirmed 3.1.1 still have the same behavior. the trace is same as #13349

For me it's happening when I launch a Dialog from a Menu > MenuItem component's onClick function. Haven't been able to narrow it down further yet.
Here's the complete stack trace:
Uncaught TypeError: Cannot read property 'removeAttribute' of undefined
    at ariaHidden (manageAriaHidden.js:28)
    at ModalManager.remove (ModalManager.js:188)
    at Portal.Modal._this.handleRendered (Modal.js:133)
    at callCallback (react-dom.development.js:11582)
    at commitUpdateEffects (react-dom.development.js:11622)
    at commitUpdateQueue (react-dom.development.js:11610)
    at commitLifeCycles (react-dom.development.js:15374)
    at commitAllLifeCycles (react-dom.development.js:16705)
    at HTMLUnknownElement.callCallback (react-dom.development.js:146)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:195)
    at invokeGuardedCallback (react-dom.development.js:245)
    at commitRoot (react-dom.development.js:16881)
    at completeRoot (react-dom.development.js:18337)
    at performWorkOnRoot (react-dom.development.js:18259)
    at performWork (react-dom.development.js:18161)
    at performSyncWork (react-dom.development.js:18134)
    at interactiveUpdates$1 (react-dom.development.js:18444)
    at interactiveUpdates (react-dom.development.js:2322)
    at dispatchInteractiveEvent (react-dom.development.js:5132)
The above error occurred in the <Portal> component:
    in Portal (created by Modal)
    in Modal (created by WithStyles(Modal))
    in WithStyles(Modal) (created by Popover)
    in Popover (created by WithStyles(Popover))
    in WithStyles(Popover) (created by Menu)
    in Menu (created by WithStyles(Menu))
...

I had a similar problem with dialog, using with a fragment children, fixed after replacing for a div

@idrm Thank you for the reproduction example! I think that we can solve the issue with a simple change. What do you think of:
--- a/packages/material-ui/src/Modal/Modal.js
+++ b/packages/material-ui/src/Modal/Modal.js
@@ -10,6 +10,7 @@ import Portal from '../Portal';
 import { createChainedFunction } from '../utils/helpers';
 import withStyles from '../styles/withStyles';
 import { createChainedFunction } from '../utils/helpers';
 import withStyles from '../styles/withStyles';
 import ModalManager from './ModalManager';
+import { ariaHidden } from './manageAriaHidden';
 import Backdrop from '../Backdrop';

 function getContainer(container, defaultContainer) {
@@ -118,10 +119,7 @@ class Modal extends React.Component {
     if (this.props.open) {
       this.handleOpened();
     } else {
-      const doc = ownerDocument(this.mountNode);
-      const container = getContainer(this.props.container, doc.body);
-      this.props.manager.add(this, container);
-      this.props.manager.remove(this);
+      ariaHidden(this.modalRef, true);
     }
   };

Adding & removing the modal wasn't a good call. We can directly execute the expected outcome.
Do you want to submit a pull requets?

Updated to Node 10 recently and getting the same bug.

Still having the same issue on 3.3.1
function ariaHidden(node, show) {
	if (show) {
		node.setAttribute('aria-hidden', 'true');
	} else {
		node.removeAttribute('aria-hidden'); // Uncaught TypeError: Cannot read property 'removeAttribute' of null
	}
}

Where are you today on this issue ? We are waiting for a fix really badly :)

@TomiCake should have fixed the issue in #13389. We will release v3.3.2 later this evening. If you are still experiencing issues once it's released, let us know. At least, we have two new tests!


Strong reference to PanframeAsset causing memory issues

When creating a Panframe asset, creating a strong reference that remains once - (void) stop;  & - (bool) setTimeMonitor:(id<PFAssetTimeMonitor>) monitor; set to nil along with the Panframe asset itself prior to dismissing a view controller.

thanks for reporting. Will investigate some time next week.

do you have a sample project to share with that memory issue?


Allow customizing notification content texts

I had no time to add tests. I'll do it if I have some time in the week.
Great util, thanks you. I hope this customisation could be helpful for others.

@crgarridos First of all, thanks for your contribution!
This feature will definitely come handy for the library users. While reviewing your PR, we came up with some improvements based on your implementation. That's the reason why we merged it as a separate pull request. The feature is published and ready to use.

Yes I saw it. Glad it was useful for you. Thanks


Nest Configuration Files

Suggested new feature or improvement
I looked around the repo and in issues and didn't find an issue around this and since there aren't discussions figure this is the best place to ask.
For WinGet Configuration files, it would be nice (if the feature doesn't exist) if I could refer other winget configuration files easily. I could likely do a hack of creating a script that I execute referring to another winget config file and the winget configure command within another winget configure file, but I was wondering if there would be a more "native" approach that would require nested calls like this and make it feel more like a modular approach. I'm not sure exactly how the syntax would look, but it could also allow things winget configure validate and similar commands to provide better information natively of errors in nested configuration files and where they are located instead of the error being in the top level file or similar. Essentially it would import the modularized file into the place it is referenced in the parent file as if it was part of the top level file.
Scenario
When I am setting up configuration of my machine, I like the idea of being able to modularize setups into parts, that I can build up into full machine configurations. As an Ex: maybe across computers I want to set the same windows themes, but only on a computer I will develop on I will want to setup VS. If I can nest, I can create top level configurations that have these built-in choices of modules that make up the machine and I can pick and choose individual configurations if I want without it all being in one large file or having to refer to many files to get my configuration done.
Additional details
No response

@denelon Would this feature require WinGet changes?


add azure-cni and azure-ipam installer images

What type of PR is this?

/kind feature
What this PR does / why we need it: Adds azure-cni and azure-ipam images, which are replacing cni-dropgz as the recommended way to deploy the CNI binaries
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.021%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2245

Relevant Lines:
2841

💛  - Coveralls

forgot about this one and opened a new PR for this https://github.com/Azure/AgentBaker/pull/4256


Research Page Bug

Requirements:

Whenever one clicks over the Bibtex (would be changed to Cite in #741 ) or Abstract Button, the size of the card should not abruptly change. To fix this, display the text as a pop up with a X button to close it
Both Abstract and Bibtex Content should not be visible at the same time. When one is being displayed the other has to be collapsed/closed.

Please assign this issue to me.

@tauqeerali1 you can work on it.

I have doubt in 1st point when we click popup X button that will close Cite/Abstract button also or this is only a simple popup?

I have doubt in 1st point when we will click popup "X" button that will close Cite/Abstract button also or this is only a simple popup?

please explain me @smaranjitghose

@tauqeerali1  The position of the cite/abstract buttons should be the same. No tweaking with that.
Now, when one clicks on the cite/abstract button, the text corresponding to that is fetched from the research.js and displayed in a pop up window (smaller size obviously, perhaps 1/10th of the total window size) with the necessary title, the X button simply closes that pop up window.  Check out Google Scholar, look up any paper and click on the quotation symbol below the paper information for reference

@tauqeerali1 any progress updates on it?

yes i am doing on it now i made popup withh X button and now i am working on button which not show at the same time when we will click on that button

@tauqeerali1 try to make a pull request before 1 july.

okay... i will do pull request as soon as posible

@smaranjitghose Please assign this issue to me.

@Ananya-Misra Yes you can work on it, keep us updated!

Any updates @Ananya-Misra ?


Support Robot Framework 6.0

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (f5fa370) 94.23% compared to head (24c3066) 94.24%.

:exclamation: Current head 24c3066 differs from pull request most recent head 6d099e6. Consider uploading reports for the commit 6d099e6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   94.23%   94.24%
=======================================
  Files          14       14
  Lines         815      816    +1
=======================================
+ Hits          768      769    +1
  Misses         47       47

Impacted Files
Coverage Δ

sherlock/model.py
92.90% <100.00%> (ø)

sherlock/version.py
100.00% <100.00%> (ø)

sherlock/visitor.py
94.05% <100.00%> (+0.05%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


ci: Test known solutions

Added the JS build infrastructure needed to run Jest from top-level directory
Added a bash script to stage and execute unit tests against all known solutions

I did notice the following warning. It seems like there is an expected git submodule that is missing or something. Should I add that repo as a submodule here? I didn't notice a .gitmodules file in the exercism/JavaScript repo.

Weird. For some reason, github seems to think it has a submodule. See the request-new-language-track dir in the repo https://github.com/exercism/wasm

Huh, yeah, I do see it. It's like there's a submodule defined in my .git directory or something, but there's no .gitmodules to go with it. It looks like it was generated in the original bootstrap commit. If this isn't expected, it might be worth looking at how that gets generated for new tracks. I do use submodules to manage C dependencies, so I feel comfortable investigating and deal with this later in a follow up PR. I may need to do a bit of git brain surgery.

Okay. Good luck. Sorry about the hassle!


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2023-09-07T14:33:54+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio_release-1.18
dba3590e25c9970ef83af34386a5311d62fd2f25
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests-arm64


Conflicting collation requirements in on prem system requirements

In the documentation for on prem system requirements there is a conflicting statement about the supported collations :
The original documentation stated that a Windows collation is recommended over a SQL Server collation.

If you’re setting up a new installation, we recommend that you select a Windows collation instead of a SQL Server collation.

However in commit 5e17380b2026efdf994a40dc7dfb8c19671708bc this line was added:

Only SQL_Latin1_General_CP1_CI_AS is valid for the server and database collation.

This makes the documentation unclear and conflicting since it now states only a SQL collation is supported however a windows collation is recommended.

@TomVergote, thanks for posting this!
@PeterRFriis, can you please update the System requirements for on-premises deployments article.

Bug 280754 has been logged to track this issue.

BUG 437647 created to replace the item above.

I have removed the conflicting section with the windows server collation.
In practice there is not a conflicting statement, as we only support english windows and there the default collation of that is SQL_Latin1_General_CP1_CI_AS.
But to avoid confusion going the windows part will be removed.
this will be corrected as part of https://review.docs.microsoft.com/en-us/dynamics365/fin-ops-core/fin-ops/get-started/system-requirements-on-prem?toc=/dynamics365/commerce/toc.json&branch=perahlff%2F2wayTrust#domain-requirements


Bug: Nested table rows are appended to parent tables when exporting DOM

Lexical version: 0.18.0
Steps To Reproduce

Go to Playground
Insert a 2x2 table
Insert another 2x2 table in any cell.
Export DOM

https://github.com/user-attachments/assets/f27b4087-c7b2-4020-85df-6103894170b6

Link to faulty code: https://github.com/facebook/lexical/blob/b2d57a0162671ab339a3b6bb578218d916ff2131/packages/lexical-table/src/LexicalTableNode.ts#L185

The current behavior

The exported DOM has two tables
The outer table has 4 columns and 4 rows
The nested table has no rows

The expected behavior

The exported DOM has two tables
The outer table has 2 columns and 2 rows
The nested table has 2 rows and 2 columns

Impact of fix

Tables cannot be reliably used until this is fixed.

I can confirm this works in Lexical 0.17.1 but is broken in 0.18.0.

I don't think that nested tables are currently well supported, I'm sure there are a number of related edge cases. If you are interested in this feature I suggest that you look into contributing PRs to implement better tests and support for them.

I don't think that nested tables are currently well supported, I'm sure there are a number of related edge cases. If you are interested in this feature I suggest that you look into contributing PRs to implement better tests and support for them.

FWIW, I've been using nested tables extensively for the past few versions. We haven't had any issues with edge cases until this particular issue.

This should have been fixed by #6889


theme style lost when device-width becomes 480 or less

Theme style lost when device-width becomes 480 or less: This is visible when sizing Chrome to 480 or less width, and also visible on iOS emulators and real devices for devices of this size, e.g. iPhone 5S

+1


Office Online sometimes request with a same new-old-proof headers

Hi. I am always thankful  for this gem.
Today, I have a problem when using it.
Currently, Service' request header sometimes have same X-WOPI-Proof header and X-WOPI-ProofOld.
According to the ProofKey document, the equivalence between A and B is not limited.
https://wopi.readthedocs.io/en/latest/scenarios/proofkeys.html
I'd like you to merge PR to use this library.

Looks good. Thank you.


Docs: Update README

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1c3ac69) 100.00% compared to head (3a53aa0) 100.00%.
Report is 1 commits behind head on release.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##           release       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            4         4
=========================================
  Hits             4         4

Flag
Coverage Δ

generic
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Issue with Vercel Deployment

Hi,
My local deployment is working fine.
However, when I try to deploy using vercel, an error occurs:
Error: No Output Directory named "dist" found after the Build completed. You can configure the Output Directory in your Project Settings.
Does anyone have an idea what the problem is?
Thanks in advance.
Best,
Marcel

Hello @marcelschilling :)
Could you provide a bit more about your project structure?
From Vercel you should be able to overwrite the deployed path from your build target, but I need to know more about what your project looks like to help you on that!

Also, is this related to nuxt-themes/docus#892


Browsing History!?

Why does this extension request access to my browsing history?

As far as i know the extension doesn't do that, is there any example you can provide of the extension accessing your browser history ?

Ah yes, the extension isn't actually reading your browser history and i can assure you we don't have anything of that sort in the code you can go through it yourself, but we're using the tabs API to access the url of the github tab :
Security and Privacy Implications Read Browsing History: Since the extension can access the URLs of the tabs, it effectively has the ability to read the user's browsing history. This is why the warning "Read your browsing history" is displayed when an extension requests the "tabs" permission.


PSNR/SSIM

Thank you very much for your work！
How do you calculate PSNR/SSIM, can you release the code that calculates PSNR/SSIM of raindrops ？

We follow https://github.com/rui1996/DeRaindrop.


Not reloading MAMP / WordPress install

Hello,
I installed the chrome plugin and followed instructions properly, but cannot get refreshing working on this wordpress site I am building locally. Please help.

Maybe your "Actual Server Address" is wrong. It may be something like "http://localhost/whatever".
Your "Live Server Address" looks correct, looks just like mine


https support for target URL

Following is my gateway configuration :
const gateway = require(‘fast-gateway’)
server = gateway(
{
routes: [
{
prefix: ‘/fakeservice’,
target: ‘https://reqres.in/’,    //--->target URL with **HTTPS**
docs: {
name: ‘Fake service’,
endpoint: ‘/api/users/2’,
},
},
{
prefix: ‘/empservice’,
target: ‘http://dummy.restapiexample.com/’,   //--->target url with **HTTP**
docs: {
name: ‘Employee Service’,
endpoint: ‘/api/v1/employees’,
}
},
]
}
);
server.start(3123);

While I am running locally using following URLs to route, I have success and failure :

http://localhost:3123/fakeservice/api/users/2
—> FAILED : Returning NOT found error, even though target https://reqres.in/api/users/2 returns valid JSON

http://localhost:3123/empservice/api/v1/employees
—> SUCCEEDED  : Returning success response with JSON payload as expected.

Question: does fast-gateway support target with HTTPS? If so, then why it’s not working? Am I missing any configuration? Do I need to add any extra parameter to route target having HTTPS protocol?

Please help. I am planning to use this in commercial production delivery project.

Hi @skskcco2o17 thanks for reaching out.
Can you please try out without the / character at the end of the target setting.
In case you are using self-signed SSL certs please consider that you need to extend the fast-proxy configuration as described:
...
{
  prefix: '/fakeservice',
  target: 'https://reqres.in'
  fastProxy: {
    rejectUnauthorized: false
  }
...

Looking forward to hear more from you.
Best Regards, Rolando

Hi Rolando,
Thanks for your quick response!
My fake service is GET https://reqres.in/api/users/2 , it does not require any self-signed SSL certificate, even you can run in any browser , it will return JSON response.
Now, as per your suggestion , I have changed the configuration as below  and tried ,but no luck, same issue:
        ```
       {
    		    prefix: '/fakeservice',
    		    target: 'https://reqres.in',
    		    docs: {
	    	        name: 'Fake service',
	    	        endpoint: '/api/users/2',
	    	      },
	    	      fastProxy: {
	    	    	    rejectUnauthorized: false
	    	    	  }

    	  },

`server.start (31232)`

As you see, my gateway server is running locally on port # 31232.
and so I am hitting below URL to test  my fake service:
http://localhost:31232/fakeservice/api/users/2

And I am getting HTTP ERROR 400   :-(

Please help

Best Regards
Supal

I will check your configuration ASAP and get back to you.
On Wed, Apr 8, 2020, 12:11 PM skskcco2o17<EMAIL_ADDRESS>wrote:

Hi Rolando,
Thanks for your quick response!
My fake service is GET https://reqres.in/api/users/2 , it does not
require any self-signed SSL certificate, even you can run in any browser ,
it will return JSON response.
Now, as per your suggestion , I have changed the configuration as below
and tried ,but no luck, same issue:
    ```
   {
		    prefix: '/fakeservice',
		    target: 'https://reqres.in',
		    docs: {
  	        name: 'Fake service',
  	        endpoint: '/api/users/2',
  	      },
  	      fastProxy: {
  	    	    rejectUnauthorized: false
  	    	  }

	  },

server.start (31232)
As you see, my gateway server is running locally on port # 31232.
and so I am hitting below URL to test  my fake service: http://localhost:31232/fakeservice/api/users/2
And I am getting HTTP ERROR 400   :-(
Please help
Best Regards
Supal
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jkyberneees/fast-gateway/issues/36#issuecomment-610872410,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7IGXFUV5VIVK4LHRDN5GTRLRET3ANCNFSM4MDTZYWQ
.

Hi @skskcco2o17, I have checked your configuration.
Unfortunately I have reproduced your issue, but I can't find a reason for the why.
Are there any SSL specific configurations required? In that case, you can also overwrite the http request configuration, please see: https://www.npmjs.com/package/fast-proxy#extended-configurations
I am also not sure if there are other request requirements for those endpoints in https://reqres.in. For example, required CDN headers, etc...
As an example, here I describe an HTTPS proxy that points to https://httpbin.org
const gateway = require('fast-gateway')
gateway({
  routes: [{
    prefix: '/httpbin',
    target: 'https://httpbin.org'
  }]
}).start(8080)

I really wish you a good resolution on this.
Regards,
Rolando

Hello Rolando...Thanks !
This is really strange!  non of the following https URLs (which are actually publicly available for testing) are working except yours one i.e. https://httpbin.org: :

https://jsonplaceholder.typicode.com/todos/1

https://reqres.in/api/users/2

https://restcountries.eu/rest/v2/alpha/col

Even it's not working on a simple microservice exposed publicly as https, which I developed and deployed in OpenShift on IBM Cloud. There is no way I can debug the problem e.g., using console log  or similar.
I must say that I really found fast-gateway the best simple and super fast API Gateway to implement for any microservice solution, compare to market leading products like nginx and express-gateway.
Since you are the author of  fast-gateway , no one can figure out the problem and fix the issue but yourself. :-) .
Please help me knowing, when can I have this issue resolved.
I have a delivery timeline mid of this month.
Best regards
Supal

Well, it seems I need to spend more time on this 😉🤔
I will get back to you ASAP
On Wed, Apr 8, 2020, 6:15 PM skskcco2o17<EMAIL_ADDRESS>wrote:

Hello Rolando...Thanks !
This is really strange! non of the following https URLs (which are
actually publicly available for testing) are working except yours one i.e. https://httpbin.org
https://httpbin.org: :

https://jsonplaceholder.typicode.com/todos/1

https://reqres.in/api/users/2

https://restcountries.eu/rest/v2/alpha/col

Even it's not working on a simple microservice exposed publicly as
https, which I developed and deployed in OpenShift on IBM Cloud. There is
no way I can debug the problem e.g., using console log or similar.
I must say that I really found fast-gateway the best simple and super fast
API Gateway to implement for any microservice solution, compare to market
leading products like nginx and express-gateway.
Since you are the author of fast-gateway , no one can figure out the
problem and fix the issue but yourself. :-) .
Please help me knowing, when can I have this issue resolved.
I have a delivery timeline mid of this month.
Best regards
Supal
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jkyberneees/fast-gateway/issues/36#issuecomment-611051975,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7IGXDXICQ53JWHGGLAW63RLSPLHANCNFSM4MDTZYWQ
.

Sure , Rolando !! much appreciable !... eagerly waiting for the resolution :-)

Hi @skskcco2o17, I have found the issue.
The thing is, Cloudflare responds with 400 when the x-forwarded-host is localhost or localhost:8080, etc...
This is the reason why it does not fails with other https servers.
I am about to push a patch on the fast-proxy library that will make optional the addition of this header, or just make it configurable.
I will let you know as soon as the fix is available in a new version.
Thanks again for reporting,
Stay tuned!

Hi Ronaldo...
Thank you so much... I am expecting to have the new version of fast-proxy soon , so that I can incorporate and do final testing before deployment, by mid of this month.
regards
Supal

Hi @skskcco2o17, v2.3.3 was released with the latest version of fast-proxy.
Now you are able to modify the request headers, in this case, required for Cloudflare.
Here a working example:
const gateway = require('fast-proxy')

gateway({
  routes: [{
    prefix: '/httpbin',
    target: 'https://httpbin.org'
  }, {
    prefix: '/jsonplaceholder',
    target: 'https://jsonplaceholder.typicode.com',
    hooks: {
      rewriteRequestHeaders (req, headers) {
        delete headers['x-forwarded-host']

        return headers
      }
    }
  }]
}).start(8080)

Looking forward to your feedback, feel free to close this issue on success.
Regards,
Rolando

Hi Ronaldo,
Thanks for releasing new version with fix. I just saw your note.
I will upgrade fast-gateway with this new version v2.3.3 and start working to change my code accordingly and test thoroughly (will all my https microservices). I will give you feedback ASAP and will definitely close the issues on success.
Please stay tuned!
regards
Supal

Hi Rolando,
I just did thorough testing; it seems all https are working as expected.
But while  testing my  https REST API ( which does not require any self-signed SSL certificate) , I am  NOT  getting the JSON output as I was expecting:
My https  REST API is :
https://stock-services-hemvyas1-in.kemeteleccorp-158084310-f72ef11f3ab089a8c677044eb28292cd-0001.eu-de.containers.appdomain.cloud/rest/stock/getHolding/114
While hitting this URL in browser I am getting expected JSON as below :
{"holdingId":114,"accountId":"ab","purchaseDate":1607731200000,"symbol":"HCL","companyName":"HCL Techonolgy","quantity":900,"price":4000.0}
My Gateway configuration is as below :
		```

server = gateway(
{
routes: [
{
prefix: '/stockservice',
target: 'https://stock-services-hemvyas1-in.kemeteleccorp-158084310-f72ef11f3ab089a8c677044eb28292cd-0001.eu-de.containers.appdomain.cloud',
hooks: {
rewriteRequestHeaders (req, headers) {
delete headers['x-forwarded-host']
  	    		        return headers
  	    		      }
  	    		    },
  	    		    docs: {
  		    	        name: 'Daytrader Stock Microservice',
  		    	        endpoint: '/rest/stock/getHolding/114',
  		    	      },

    			  },
			]

		}
	)
	server.start(8080);

Based on the above configuration, I  was testing using following URL, but **not** getting the JSON output, which I am supposed to get as  mentioned above :

`http://localhost:8080/stockservice/rest/stock/getHolding/114 `

Extremely sorry for bothering you too much. I know that you are helping in all sorts. But I need this problem to be resolved urgently.

Seeking your support again. Please test my service and fix.

Regards
Supal

Fix is waiting for review: https://github.com/fastify/fast-proxy/pull/28
Thanks for reporting.

WOWOOO !!   Finally all https (with no self-signed cert) URL targets are working !!
Thanks Rolando for your splendid support. Really appreciable.
Let me know, whether I need to wait for your confirmation on new version's availability  or I should close this issue now.
I may also need your help to know  how we can handle https target having SSL self-signed cert required, but later.
Thanks again and best regards
Supal

Hi @skskcco2o17, is great to hear that it worked for you.
v2.3.4 of fast-gateway is out with the fix. So you don't need delete headers.host anymore.
For using self-signed certs you can use:
const gateway = require('./../index')

gateway({
  routes: [{
    fastProxy: {
      rejectUnauthorized: false
    },
    prefix: '/httpbin',
    target: 'https://httpbin.org'
  }]
}).start(8080)

I am closing this issue, in case you have other issues, feel free to contact me again.
Best Regards,
Rolando


add metadata stuff

Pyro 4.40 has new metadata support in the name server.
Add support for this to Pyrolite.

This was fixed in 42062221d42343dc253935d0f423efa402405a2b


Use additional table fields

I need another field in the table customer_id that is the customer of the causer_id.  In my application, all users belong to a customer and it would be faster to query a column customer_id for the customer level and causer_id for the user level.
Is this possible?

My first idea would be an observer for the Activity model which adds the customer_id to the custom_properties.
https://laravel.com/docs/5.7/eloquent#observers

It probably could, but that requires 3 lines of code; if it was built into the package, it could be incorporated into 1 line of code.

@Gummibeer I don't think we'd need to support that callback as a second argument. You can do this:
tap(activity()->log('test'), $callback) {
   // do stuff here...
}

That seems you are saving the log first and then after it is saved, then do more stuff.  Just seems like adding a band aid and not really addressing the issue.
It is common to want to add additional fields into the activity log; I'm not seeing the difficulty in adding it to the tool so that it can be more streamlined and efficient.

@freekmurze like @yougotnet said: this will save the model twice - something we should prevent for logs. For me the table/model shouldn't even allow an update, but this is something else.

Ok, thanks for clarifying. Instead of adding a second parameter to log we could introduce a new method right?
activity()
->with(function(Activity $activity) { $activity->customer_id = $activity->causer->customer->getKey(); })
->log('message');
That with name could be improved. Maybe tap? 😄

Sounds great! That would allow any number of additional fields for the model.

This was released as v3.2.0
https://github.com/spatie/laravel-activitylog/blob/master/CHANGELOG.md#320---2019-01-29


[Event Request] Codeunit::"Transfer Extended Text" - Function DeleteFinChrgMemoLines OnBeforeDeleteFinChargeMemoLinesOnAfterSetFilters

We have additional filter criteria.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


feature/android level

adds android configuration for abstractions

first pass at making abstractions android compatible

adds android linting project for authentication

adds android compatibility for authentication package

adds android configuration for serialization json

adds android compatibility

adds android configuration to serialization text

adds android compatbility to serialization text

corrects serialization interfaces according to implementation eventualities

adds android project to http lib

adds android compat to http library

removes response handler from interface

removes response handler parameter from http implementation

adds a workflow to lint API levels

fixes doc comments in abstractions

adds missing imports

@baywet These will not auto merge due to versioning. Can be force merged. Abstractions will pass. All others must be manually triggered since they require this new version of abstractions to build.


Localstorage on the Pebble

Is there any way to persist data on the Pebble itself using PebbleJs?
I know that I can use the Javascript Localstorage methods window.localStorage.setItem  and window.localStorage.getItem to read and write data, but this is persistent on the phone and requires an active connection to the phone in order to display that data on the Pebble.
I also know that if I use C sdk I can use the persist_write_data and the persist_read_data methods to read and write data on the watch itself.
If there is no way to store data locally on the Pebble itself, can this be a feature request?

That's right, pebble.js doesn't currently use persistent storage.
The issue lies in how the pebble.js C shell would know what to do with the data. The C shell only knows enough to display what is shown currently. Since it forwards all events to the phone, it means it doesn't know what to display based on a given input even if it has the data locally.
If we wanted to solve that problem, the solution is a DSL or a vastly simplified and limited API that hooks events to combinations of actions and data, but this would mean using JavaScript as a vessel for a DSL or API vastly simpler than both JavaScript and C. A limiting DSL or API is often frustrating to use if designed poorly.
We can make the extreme case of using JavaScript as the DSL. I have thought about this idea, but there would still be issues with code dependency. For example, if your button handler called a function from a charting library, the resulting compiled code would be too great to send over bluetooth.
If the idea is to only instantly show what was last shown on the watch, then that greatly simplifies the problem. That is in fact something I've entertained and is possible. There are still some issues such as how pebble.js should decide which screen to snapshot. Perhaps the simplest implementation is to call a function that would snapshot the current screen.
It is possible to extend the snapshot idea by adding instrumentation over button handlers that call or hide windows to have a snapshot per window and naively display the last saved snapshot of the window. This might be the feature you're requesting. There are some issues with this however such as asynchronous callbacks that show/hide a window. pebble.js would need to somehow know the callback belonged to a certain window's button press, such as by a new API. This may still need a snapshotting function to prevent automatically snapshotting a window while it is displaying "Loading..."
If the idea is to save information on the watch so that switching phones means the data travels with the watch, that is also possible. There is one issue however; providing access to this means removing future persistent storage space pebble.js may use to cache data such as snapshotting the screen as outlined above. It may be in your interest to save the information in an online server indexed by the Pebble account token obtained via Pebble.getAccountToken().

PebbleJS can currently subscribe to acceleration service:
Accel.init() => simply_accel_set_data_create()
Would it be impossible to call persistent data storage functionality in a similar fashion:
Watch.persist(key, value) => persist_write_data(key, value)
The watch display doesn't have to be changed when the persist functions are called.
It would be great if also e.g. data logging API and wakeup API could be exposed to PebbleJS.

In addition it would awesome if there was some way to program logic on the watch in the event of the watch not being connected to the phone, such as reading data from persistent storage and writing it to the screen.

Would it be impossible to call persistent data storage functionality in a similar fashion:
Watch.persist(key, value) => persist_write_data(key, value)

It is possible, but it would reduce the amount of persistent storage pebble.js may use as a cache in the future since it is limited to 4K. I suppose however now is the best time to experiment. I could permit a smaller amount, such as 2K, for example.
It would be great if also e.g. data logging API ...

Unfortunately PebbleKit JS, the framework pebble.js is built on top of, doesn't support data logging. I can, however, create versions of pebble.js that use PebbleKit iOS/Android, though it would require the user to create a complementary phone app. Regardless, this is planned far in the future after pebble.js has a good featureset. It'll probably also make it very confusing to explain what pebble.js and the PebbleKits are at that point.
... wakeup API could be exposed to PebbleJS.

I definitely plan to do that! There is a ticket #7, though I forgot to reply.
In addition it would awesome if there was some way to program logic on the watch in the event of the watch not being connected to the phone, such as reading data from persistent storage and writing it to the screen.

I agree, it would be awesome. The difficulty however is the first half of my first reply before this one. But it's a good reminder that I should experiment while pebble.js is still in beta.


App not showing IOB, recommended treatments, etc...

New to the app, followed setup guide and read all the docs. Not sure what I did wrong.
Does the interface not update if CGM data isn't available? I'm waiting for my sensor to warmup
See screenshots. Let me know what else I need to provide. Thanks
-sorry if this is already covered somewhere, I can't find any info.

posted issue to Facebook group


Changing names of the default branch

Tooling needs to handle the changing of the default branch name on platforms like Github, where it is now main instead master.
Current tooling (Augur and Grimoirelab) will handle whatever the default branch was when we first cloned the repository. Most tools are not designed to handle default branch changes, but we will need to likely address this in the near future.
@dicortazar -- I don't think Augur will do this by default. Do you know how or if Grimoirelab handles this?
git branch -M will change the name of whatever branch you are on. I believe Augur will handle this change. But if the change involves creation of a new branch on GitHub and changing the default branch at the platform level, I still don't think Augur handles this ...

Testing needs to be performed to see how current CHAOSS tools handle these types of changes.


Fixes Janus model for WebGPU EP

Fixes the following error reported in the Janus model for WebGPU EP:

Hi there 👋 This was intentionally added to avoid needing to recompute image embeddings during generation. The model works on CPU/WASM, so I believe this is an error with the WebGPU EP itself. cc @guschmue


June cargo update

The actual cargo.toml changes document the material minor changes.
I looked through the patch notes for the listed commits/crates and didn't really see anything that stuck out. Most of them were adding new features or reworking their dependencies.
When reviewing this it's important to remember the cargo.toml is basically just an advisory file as far as dependency versions go, it's cargo.lock that actually specifies.

thank you!


Need some help understanding how to tell which dependency is newer

Followed https://ossf.github.io/osv-schema/#evaluation to implement the algorithm in Java.
For well-structured semver versions, it works fine.
But what about something like this?:
2.6.7
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
2.6.7.RELEASE
Which of those is the newest version?
Similar questions for this:
24.0.0
24.0.0.Beta1
24.0.0.Final
24.0.0.SP1
and this:
24.0.1
24.0.1.Final
and this:
4.1
4.1-BETA-1
4.1-alpha1
4.1-alpha2
4.1-beta1
4.1-milestone-1
4.1-milestone-2
4.1-rc-1
4.1-rc1
4.1-rc6
and etc.

semver_index.py

Hi @jimshowalter it looks like you've managed to answer this yourself, but I'm always interested to know if there's an opportunity for improving our documentation, or the discoverability of the answer. Got any actionable feedback on that front?

Adding onto @andrewpollock 's comment here:
semver_index.py is used only for strict SemVer schemes. In general every ecosystem tends to have their own version ordering rules, which we implement here: https://github.com/google/osv.dev/tree/master/osv/ecosystems


get rid of pointless warning

dlwlalsggg said it best on https://community.creditcoin.org/t/how-to-check-mining-progress/405

I don’t know why the creditcoin team didn’t remove that warning message.
However, that warning does not cause any problems with mining.

i'm trying to fix your mistakes haha

Thanks for the PR, however, this won't be applicable with Creditcoin 2.0.
Please feel free to submit new PRs for any issues you find in the future!


[release-1.4] Make conformance test use proper schema

This is an automated cherry-pick of #17927

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio_release-1.4
94c20d1bd8cc11211ab52fb3540c5fbb14212cb3
link
/test e2e-dashboard_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio_release-1.4
94c20d1bd8cc11211ab52fb3540c5fbb14212cb3
link
/test e2e-dashboard_istio_release-1.4

unit-tests_istio_release-1.4
94c20d1bd8cc11211ab52fb3540c5fbb14212cb3
link
/test unit-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Next Release timeline

Hi Team
The last release for beakerx was Aug 2019. Is there any plan for a new release from master anytime soon? There are several new features already on master which I am interested in.
Thanks

We are refactoring the codebase and we'll release the new version once this is done.

Any estimates?