[local] Refuse to create lakectl locals on case-insensitive filesystems

Of course, allow it anyway if --forced to.
Fixes #7645.

How was this tested?
Unit tests are easy, and included.  But for something that depends on the OS interface they are not enough.  A system check is also needed!
I managed to perform a manual system check for acceptance.  This is hard because developer machines should NOT have case-insensitive filesystems -- precisely for the reasons that we have this PR!
Luckily ext4 (and, apparently, ext2 and ext3) can be configured to allow case-insensitive directories.  To set it up on Linux:
# Create a loopback file
dd if=/dev/zero of=/tmp/my-loopback bs=1k count=10000
# Create a loopback device
sudo losetup -f /tmp/my-loopback
# Get the name of the created device (I got /dev/loop11)
losetup --all
# Format an ext4 filesystem
mkfs -t ext4 -O casefold -E encoding_flag=strict /dev/loop11
# Mount it
mkdir /tmp/ifs; sudo mount /dev/loop11 /tmp/ifs/
# (Give permissions...)

# Create a case-insensitive directory
mkdir /tmp/ifs/dir
chattr +F /tmp/ifs/dir

# Now use /tmp/ifs/dir for testing...

So I did this and verified that I get an error message on a case-insensitive directory under /tmp/ifs/dir, and that I can --force it into a warning but still succeed.
This is an acceptance check not a test!
Obviously this won't really work in a CI/CD container: there are
externalities that we cannot control.  Examples:

Might be running on a Linux system whose ext* filesystem was compiled without casefold support.
Might be running on a Linux system with an non-ext* filesystem.
Might not have permissions to perform these actions.

All of these issues can change between GitHub runner releases, and none of them can be fixed from inside a test container - they all manifest at the VM level.
OTOH, this is an esoteric setup.

Thanks, I don't have a lot of comments on the code itself. However, I feel we need to understand the implications of this change. Blocking since this will break users who are currently using lakectl local on FSs that are case insensitive. I agree that his is a bug that needs to be fixed but I believe we must first communicate it to all the relevant stakeholders

I disagree, asking @ozkatz for guidance please.

We do not block users of lakectl local with a case-insensitive filesystem: they will get an error message when they try to create a new local, and the error message tells them to set a flag.

Would you be happier to set this on a Viper configuration?  Then users could set it once and for all.

Users of lakectl local who are already on a case-insensitive filesystem are playing with fire!

@arielshaqed Looking into the solution we chose, I’d like to suggest that we soften it a bit. Instead of dying by default on inits that involve dirs on case-insensitive FSs, print a warning and document this very well in our public docs and lakectl local best practices.
The reasoning behind my suggestion is that the current version of the fix means that most macOS and Windows users won’t be able to use lakectl local without forcing it (because the default FSs on both systems are case-insensitive). In addition, this is consistent with how Git works, and users can mitigate the problem by following file naming conventions.

Thanks, @talSofer & @N-o-Z .  I downgraded everything only to warn.
PTAL.

Thanks!
Not sure which of the changes is requested; unfortunately I object to many of them, and am not sure what to do about one.
I suggest panicking when we cannot Remove the test file. Would that resolve your requested changes?

I think panicking is a bit drastic, but I do see this bug coming back to us sooner than later. Can we at least issue a an error or warning message in the defer function if the remove fails?

Thanks!


[P2P] Add Connection Handshake functionality + Identity Check

Description

Implement the connections handshake process per the p2p specification
Acceptance Criteria

.handshake() authenticates connections and adds them to the connection pool on success
.handshake() tracks which connection failed to authenticate for security purposes. (file logs?)
.handshake() to take part of inbound and outbound socket opening.

Deliverables

.handshake() internal method to authenticate connections

Owners: @derrandz

Closing for housekeeping but may reopen in the future.


whereHas gives opposite result

Laravel Version: 7.2.19
PHP Version: 5.8.21

When using whereHas(), the opposite result is returned.
So,
$query->whereHas('userResponsible', function ($q) use ($value) {                 $q->where('name', 'LIKE', '%'.$value.'%');  }, 'AND');
Gives the result you would expect from having a NOT LIKE instead.
Feeling a bit stuck on this one

Why are you providing 'AND' as the third argument? whereHas()'s third parameter is the operator.

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!


Unable to create table named "user"

Setup
Versions

Rust: rustc 1.43.1 (8d69840ab 2020-05-04)
Diesel: 1.4.4
Database: postgres (PostgreSQL) 12.3
Operating System macOS 10.15.5

Feature Flags

diesel: { version = "1.4.4", features = ["postgres"] }

Problem Description
Creating a table with the name user results in an error with no actionable result Failed with: syntax error at or near "user". Changing the table name to the plural form users resolves this issue. This doesn't occur with posts, both posts and post are valid and are able to be created correctly.
What are you trying to accomplish?
Create a table with the name user
What is the expected output?
Running migration 2020-07-29-150248_create_user succeeds.
What is the actual output?
❯ diesel migration run
Running migration 2020-07-29-145952_create_post

❯ diesel migration generate create_user
Creating migrations/2020-07-29-150248_create_user/up.sql
Creating migrations/2020-07-29-150248_create_user/down.sql

❯ diesel migration list
Migrations:
  [X]<PHONE_NUMBER>0000_diesel_initial_setup
  [X] 2020-07-29-145952_create_post
  [ ] 2020-07-29-150248_create_user

❯ diesel migration run
Running migration 2020-07-29-150248_create_user
Executing migration script /Users/cbzehner/Projects/open-source/diesel-singular-table-names/diesel_demo/migrations/2020-07-29-150248_create_user/up.sql
Failed with: syntax error at or near "user"

Are you seeing any additional errors?
No.
Steps to reproduce
I created a repository based on the first few steps of the getting started guide to showcase the issue.

Clone https://github.com/cbzehner/diesel_user_table_creation_error
Run diesel setup locally
Run diesel migration run and experience the error.

Checklist

[x] I have already looked over the issue tracker for similar issues.
[x] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)

Please let me know if I missed something or have a syntax error. This struck me as particularly odd, so I'm looking forward to finding out what the cause might be 😁

Seems like "user" is a reserved keyword in postgresql. You need to explicit quote your table names in such cases, so the following migration works fine:
CREATE TABLE "user" (
  id SERIAL PRIMARY KEY,
  email TEXT NOT NULL,
)

Closed as this is not a diesel issue.


convert project to new MPP format

In kotlin 1.3 there is a new format for MPP projects. we need to convert to that format.

Were you also thinking about moving tothe Gradle Kotlin DSL as part of this change?

initially not, but I am open to that change as well. Last time I checked, it was not mature enough.

Fixed in #81 released in 1.7.1


B1

My vultr account has been crashed. Mod Kelvin and different people tried to help me with that but they couldn't solve the exact problem, unfortunately. Because of this, I have only this log file to send you. Hope it'll help for improving your system and you'll accept it for this task.

rejected:B1
reason:runtime significantly lower than 30 days

rejected:B6
reason:system logs are missing

rejected:B6
reason:system logs are missing


How to implement the image synthesis

Great job! I would like to ask how the image synthesis is specifically implemented when providing a reference image and a background with a mask .

Thanks for your attention. First, we apply padding, either on the left and right sides or on the top, to the bounding box region of the reference object in the synthesized reference image, to ensure the aspect ratio of the object mask in the synthesized reference image matches that of the mask in the source image. Second, we use the controlnet-canny and the controlnet-tile, as well as the stable-diffusion-inpainting model, to achieve image synthesis. For better consistency, you may need to utilize dreambooth (for better results) or lora (for faster processing) or other latest customization methods.


Drive mode

Enabled 'drive mode' to control the BB8 from the keyboard input!

It might also be worth factoring in calibration mode, so that you can toggle calibration and on off.
http://sdk.sphero.com/community-apis/javascript-sdk/#custom-commands-startcalibration-callback

Now to think of it. You maybe right. This was just like a PoC.... Lemme close this pull request and work on it when I get some time...


Functionality for tilelayer added. Fix error with wrong layer name.

This file must be loaded @ notebook startup.

Functionality for tilelayer added. Fix error with wrong layer name.


For loops on useItem hook + Level.playSound does not produce sounds

I have been using a for loop for a mod that I've been developing and when the hook gets to the part I trigger, the game freezes and lag for about a second then the function happens. That was not what I programmed. I programmed it to wait for 9 seconds, then drop the item. Another issue was playing a custom sound, the sound did not play during or after the timer
//Code
metallurgyCM.crusher.stoneTimer = function(x, y, z, item, dat, powerRemove, out, outDat){
if(crusher.getStonePower(x, y, z) >= powerRemove){
var dustDropChance = Math.ceil(Math.random() * 3);
Player.removeItem(item, dat, 1);
crusher.removeStonePower(x, y, z, powerRemove)
for(var i = 1800; i >= 0; i--){
Level.playSound(x, y, z, "crusher.run", 100, 25);
if(i == 0){
Level.dropItem(x, y + 1.25, z, .2, out, dustDropChance, outDat);
Level.playSound(x, y, z, "machine.ding", 100, 25);
}
}
} else {
ModPE.showTipMessage(ChatColor.RED + "Not enough power!");
}
}

Do you use a for loop as a timer?

30 nov. 2015 kl. 07:23 skrev ShadowMine<EMAIL_ADDRESS>I have been using a for loop for a mod that I've been developing and when the hook gets to the part I trigger, the game freezes and lag for about a second then the function happens. That was not what I programmed. I programmed it to wait for 9 seconds, then drop the item. Another issue was playing a custom sound, the sound did not play during or after the timer
//Code
metallurgyCM.crusher.stoneTimer = function(x, y, z, item, dat, powerRemove, out, outDat){
if(crusher.getStonePower(x, y, z) >= powerRemove){
var dustDropChance = Math.ceil(Math.random() * 3);
Player.removeItem(item, dat, 1);
crusher.removeStonePower(x, y, z, powerRemove)
for(var i = 1800; i >= 0; i--){
Level.playSound(x, y, z, "crusher.run", 100, 25);
if(i == 0){
Level.dropItem(x, y + 1.25, z, .2, out, dustDropChance, outDat);
Level.playSound(x, y, z, "machine.ding", 100, 25);
}
}
} else {
ModPE.showTipMessage(ChatColor.RED + "Not enough power!");
}
}
—
Reply to this email directly or view it on GitHub.

Yes

For LOOPS != timer.
The time it takes to go through a for loop is based on the processing power of the system. Try using a timer task. It should fix the game freezing issue too.
http://examples.javacodegeeks.com/android/core/activity/android-timertask-example/
Skickat från min iPad

30 nov. 2015 kl. 08:12 skrev ShadowMine<EMAIL_ADDRESS>Yes
—
Reply to this email directly or view it on GitHub.

For loops can be used as timers, it's worked many other times

Ok. It's just that it's not going to run after a set amount of time but rather at the time the device can run the methods.

30 nov. 2015 kl. 09:50 skrev ShadowMine<EMAIL_ADDRESS>For loops can be used as timers, it's worked many other times
—
Reply to this email directly or view it on GitHub.

useItem is called on the game's main thread, so instead of running the game it's going to run your loop 1800 times, which causes the lag


Confirm hb-draw style off-curve first resolution helps

https://github.com/googlefonts/fontations/pull/818 appears to make 2/3 of our svg paths match. The last one is very close, for some reason the legacy code isn't putting in the line on the final Z:
M...Q513,-720 480,-720Z
M...Q513,-720 480,-720L480,-720Z
                      ^ a final line, but only for man.svg!

for some reason the legacy code isn't putting in the line on the final Z:

was the "legacy" code using fonttools pens? if so, i'm pretty sure this related to my comment about handling of implied closing line when converting points into segments: https://github.com/googlefonts/fontations/pull/818#discussion_r1521188624
you should match that behavior in skrifa if you care about losslessly converting between points and segments

was the "legacy" code using fonttools pens?

ah sorry, it was using hb-draw. Still, I think it's a symptom of the same issue about duplicate last and first points overlapping in a closed paths which should trigger an explicit closing line otherwise they'd be lost


[Feature] Implement & Optimize a few optimizer options

Problem (Why?)
implement & optimize a few features
Solution (What/How?)

[x] Move step parameter from state to group. (to reduce a computation cost & memory)
[x] Support max_grad_norm for Adan optimizer.
[x] Support gradient averaging for Lamb optimizer.
[x] Support dampening, nesterov parameters for Lars optimizer.
[x] Fix logic when momentum is 0.

Other changes (bug fixes, small refactors)
nope
Notes
bump version to v2.2.1

Codecov Report

Merging #95 (17ec57b) into main (f6baa63) will decrease coverage by 0.01%.
The diff coverage is 98.95%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   97.73%   97.72%   -0.01%
==========================================
  Files          37       37
  Lines        2520     2554      +34
==========================================
+ Hits         2463     2496      +33
- Misses         57       58       +1

Impacted Files
Coverage Δ

pytorch_optimizer/optimizer/lamb.py
98.94% <96.77%> (-1.06%)
:arrow_down:

pytorch_optimizer/base/optimizer.py
97.56% <100.00%> (+0.12%)
:arrow_up:

pytorch_optimizer/optimizer/adan.py
100.00% <100.00%> (ø)

pytorch_optimizer/optimizer/lars.py
100.00% <100.00%> (ø)

pytorch_optimizer/optimizer/ralamb.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Variants are missing from the v2df table

@mkarmona has provided me with toploci_v2df.txt, a list of (index) variant IDs (n=51275) from the v2d left join table (named v2df).
Using the raw data, I have done a left merge between:
left. study/toploci table (inner merge)
right. ld/finemapping (outer merge)
This should be equivalent to the v2df table.
Using the 51275 variants in toploci_v2df.txt, I calculate that:

83668 (study_id, variant_id) pairs not missing from v2df table. Of these:

345 have no LD or finemapping information
83323 do have LD or finemapping information

18543 (study_id, variant_id) pairs missing from v2df table. Of these:

18538 have no LD or finemapping information
5 do have LD or finemapping information

By grepping a few examples from the raw ld.tsv.gz and finemapping.tsv.gz tables, it looks like the 345 are known tag variants in the ld.tsv.gz table (for different studies). Whereas, the 18538 are not found in ld.tsv.gz at all (but sometimes are found in finemapping.tsv.gz for different study, e.g. [GCST003842, 12_28174817_C_T]).
Something is not right with the merge.

@edm1 I've fixed the pipeline to produce the proper joint table. I will produce numbers again to check against what you said.

I've re-run using the new list of index_variants from v2df (toploci_v2df.180904.txt) and there are 0 missing variants.


Added a Postmaster Clone Using JavaScript

Hey @swapnilsparsh  this is my Final Project which I made using JavaScript.
What It Is ?

Basically it is similar to Postmaster or like a REST API Extension (VS Code).
It helps You to fetch the data From API or Link you enters and display you in a well formatted way (For this I used Prism JS and Prism CSS)
You can also post any Request Using Customizable Parameters.

To check All things Please Take a trial
Any Problem , Let me know I'll fix it ASAP

@singhkunal01 Update your project on the official website also in the 30DaysOfJS folder.

Sorry but i'm little bit confused, Can please guide me for that because after fork i have make a repo named 51th number after that I Raise a pull request but still it is not shown here , what should i have to do exactly ?
Can i do the same directly by github page ?

hey @swapnilsparsh  can you please help me for once i have completed my project and i stucked here in the last step only , so please try to resolve it so that i can move forward.

You have to pull the lastest changes of the repo and then you can update the number of your project.

i did everything but don't know when i clicked on that deployed link it doesn't shows my project when i click on this deployed link https://github.com/singhkunal01/30DaysOfJavaScript/ what should i do , I know i'm missing something please let me know

i did everything but don't know when i clicked on that deployed link it doesn't shows my project when i click on this deployed link https://github.com/singhkunal01/30DaysOfJavaScript/ what should i do , I know i'm missing something please let me know

Can you please explain the problem which you are facing?

Fixes #149

Even I don't know what i have to do now to get my project merged because everything according to your documentation i did

@singhkunal01 Thank you for your contribution. Looking forward to more such amazing contributions 🥂


Error

 LoadToast lt = new LoadToast(this);
        lt.setTextColor(Color.RED).setBackgroundColor(Color.GREEN).setProgressColor(Color.BLUE);
        lt.setText("Hallo");
        lt.show();

FATAL EXCEPTION: main
                                                                    Process: com.oli.fitnessapp, PID: 27811
                                                                    java.lang.NoClassDefFoundError: Failed resolution of: Lnet/steamcrafted/loadtoast/R$color;
                                                                        at net.steamcrafted.loadtoast.LoadToastView.<init>(LoadToastView.java:83)
                                                                        at net.steamcrafted.loadtoast.LoadToast.<init>(LoadToast.java:32)
                                                                        at com.oli.myfitnessapp.activities.LiveSelectActivity.onCreate(LiveSelectActivity.java:114)
                                                                        at android.app.Activity.performCreate(Activity.java:6052)
                                                                        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1106)
                                                                        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2332)
                                                                        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2441)
                                                                        at android.app.ActivityThread.access$800(ActivityThread.java:162)
                                                                        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1349)
                                                                        at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                        at android.os.Looper.loop(Looper.java:135)
                                                                        at android.app.ActivityThread.main(ActivityThread.java:5431)
                                                                        at java.lang.reflect.Method.invoke(Native Method)
                                                                        at java.lang.reflect.Method.invoke(Method.java:372)
                                                                        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:914)
                                                                        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:707)
                                                                     Caused by: java.lang.ClassNotFoundException: Didn't find class "net.steamcrafted.loadtoast.R$color" on path:

Obligatory: What did you try already? Gradle sync? clean build? ...
This is obviously something related to your own environment as an R.class bug is not something that is caused by bad programming, it just compiled incorrectly and didn't include the class in your dex.

Ok i fixed that. Took me a while.
I would like to use this library to notify the user if an operation was sucessful or not. How can I show the animation from sucess() or error() for a certain time?

Read the README please, it is a really simple API.


bn/asm/ppc-mont.pl: signal no-op in 32-bit bit build.

The bug was introduced in 80d27cdb84985c697f8fabb7649abf1f54714d13,
one too many instructions was removed. It went unnoticed, because
new subroutine introduced in previous commit is called in real-life
RSA/DSA/DH cases, while original code is called only in rare tests.
The bug was caught in test_fuzz.

+1


KAFKA-9570: Define SSL configs in all worker config classes, not just distributed

Jira
All SSL-related configs are currently defined only in the DistributedConfig class, even though they are applicable for standalone mode as well (since standalone mode also supports the Connect REST API). Because of how these configs are parsed by the framework, it's currently impossible to configure Connect in standalone mode to use SSL for the REST API with a password-protected keystore, key, or truststore, and even if no password protection is required, SSL configs will not be picked up correctly by the worker if any of the worker configs start with the listeners.https. prefix.
These changes define the relevant SSL-related configs in the parent WorkerConfig class, which should fix how they are picked up in standalone mode.
A new unit test is added to verify that the StandaloneConfig picks up these configs correctly.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for the review, @rhauch. I've incorporated your feedback with some small tweaks that I hope are acceptable; could you give this another pass when you have a chance?

Awesome, thanks Randall!

ok to test

@rhauch would it be possible to backport this to 2.6 before the upcoming release?

Yeah, it's on my list.

retest this please


Read our guide about submitting issues

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

Leave

Leave


gradle init fails with - 'parent.relativePath' points at wrong local POM

gradle init should be able to create a gradle project out of my maven pom.xml file. This works fine on simple pom files. However, it seems that the maven model evolved and introduced parent relative path things and and order when it searches locally and when to load parents from a repository.
It could be that gradle just hit an issue by using outdated maven libraries. Maybe the http vs https protocol default to download maven artifacts from maven central. This issue seems to be solved in versions above maven 3.2.3 if I remember correctly. But I am not sure about.
Expected Behavior

It should be able to generate a gradle project out of that
Current Behavior

It fails:
./gradlew init
Found a Maven build. Generate a Gradle build from this? (default: yes) [yes, no]

Task :init
Maven to Gradle conversion is an incubating feature.

Task :init FAILED

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':init'.

Could not convert Maven POM /tmp/bugreport/pom.xml to a Gradle build.
Unable to create Maven project model using POM /tmp/bugreport/pom.xml.
1 problem was encountered while building the effective model for com.fasterxml:classmate:1.3.4
[FATAL] Non-resolvable parent POM: Could not transfer artifact com.fasterxml:oss-parent:pom:24 from/to central (http://repo.maven.apache.org/maven2): Failed to transfer file: http://repo.maven.apache.org/maven2/com/fasterxml/oss-parent/24/oss-parent-24.pom. Return code is: 501 , ReasonPhrase:HTTPS Required. and 'parent.relativePath' points at wrong local POM @ line 3, column 13
for project com.fasterxml:classmate:1.3.4 at /tmp/bugreport/pom.xml

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 6s
2 actionable tasks: 1 executed, 1 up-to-date
Context

I am trying to build existing open source packages with gradle instead of maven
Steps to Reproduce

https://github.com/fezno/gradleInitIssue
just run ./gradlew init
Your Environment

Build scan URL:
https://gradle.com/s/twvmutpvw4gkk

This could be configured to work but only if you put the maven settings.xml in place. E.g. put the content below into ~/.m2/settings.xml it works again.

ssl-profile

true

central-1
https://repo1.maven.org/maven2

false

central-2
https://repo1.maven.org/maven2

false

central1
https://repo1.maven.org/maven2/

central2
https://repo.maven.apache.org/maven2/


Is it Ok to use git submodule for template in a package?

Description
I want to seperate the package and its template for independent iterations, so I want to use git submodule to do this. Will it work in the package system?

I then find out a work-around solution: use CI to collect the works so that the seperation of codes are hidden behind.


Updates all packages & adds package-lock to commit

This PR updates all the packages currently in use, and also commits the package-lock.json as specified in the npm docs.
Testing this locally also resolves the errors on the Firefox browser, and as such will resolve these issues:
#408
#444
https://github.com/Kitura/Kitura/issues/1509

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Delete .NET code

Removing existing source code as we are moving to Python.

We are going to use C# at the end, so this code shouldn't be deleted outright.


Support multiple shorthand properties

Description
This change adds support for multiple values in shorthand properties such as padding. In its extant form, rainbow sprinkles can only support shorthands with a single value:
<Component
  padding="$500"
/>

and due to the trimming logic, even putting multiple values will cause only the first to be used, so the following example winds up being equivalent to the preceding one:
<Component
  padding="$500 $1000"
/>

This change works for both variable values ($500) and static values (10px), and in both non-responsive and responsive values.
I wanted to add tests for this functionality but wasn't quite sure how to implement; will continue to look into it
Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[x] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[x] All code style checks pass
[ ] New code contribution is covered by automated tests
[x] All new and existing tests pass

I think there's some edge cases that we won't catch here. The ones that come to top of mind:

CSS functions, like calc() -- the string calc(100% - $500) would get chopped up in weird ways. The same could happen for rgb(), rgba(), etc.
This might not be what users expect for shorthands that use different kinds of values (e.g., border uses a mix of width/style/color)

It's pretty tough to account for the variety of syntaxes without being able to write parsers tailored to each property. It would be cool if we could figure out a way to afford control for this somehow in the defineProperties configuration, but that would be a much more significant change.
To keep the library simple, I think we should indicate that users should use longhand properties or to use vars directly, if available/appropriate:
<Component
  padding={`${vars.space[500]} ${vars.space[1000]}`}
/>

due to the trimming logic, even putting multiple values will cause only the first to be used, so the following example winds up being equivalent to the preceding one:

this sounds like a bug we should fix though! I think the expected result would be that the entire value would pass through directly, instead of being parsed.


Parse Error if use image in html template files.

According to this post, the HTML will still be minified by the loader even if you turn off the minify option.
So this minify option seems useless, only causing parse errors.

According to this post, the HTML will still be minified by the loader even if you turn off the minify option.

I don't think that's what the README says. minification would only be activated if we had an HTML loader specified, which we don't.
The issue should be something else.

specify the minimize property in the loader's options in your webpack.conf.js
{                 test: /\.(html|htm)$/,                 loader: 'html?minimize=false'    }


Changes to run e2e for private cluster

Fixes #N/A
Description
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.633%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5015

Relevant Lines:
6069

💛  - Coveralls


TODO [GFX]: Fix CSM bugs in last cascades

In general, CSM is very old in the engine and very buggy. I should re-write it and make sure its bound to camera frustum correctly... Its broken behaviour is evident in big scenes/terrain

I found a bug in Terrain.hlsl where cascade index was not calculated properly. It was fixed with a1a4a70 and big scenes are now "correctly" shadowed. I have slightly refactored the system but have not drastically improved it yet. I will close this bug for now.
If we have more issues with it, I will create a new ticket for the complete system's rewrite.


No audio problem in ES

Hi
Yesterday after hours of fiddling with my RG353M with the "no audio" problem, I gave up and reinstalled ArkOS from the ground up. That fixed the problem.
Today I hand restored this ES setting and the "no audio" problem was also restored.
Can you test it and see if there is some lingering bug?
Too many people report no audio problem in ArkOS and almost none can fix it without reinstalling from scratch. I'm hoping this file helps.
Thanks
es_settings.cfg.zip

If this file is from the backup process that is within ArkOS, that does not backup any files that would have any type of impact on audio.  There is a bug in the kernel that will cause that issue sometimes.  Usually, a reboot fixes it if you're on the latest version of arkos (02232024).  If not, here are a few other items you can try:

Press L3+R3 to restore audio.
Plug a 3.5mm pair of headphones then unplug them.
Lastly, restoring the files from here for your model: https://github.com/christianhaitian/arkos/issues/772#issuecomment-1732564970 will fix the issue.

I constantly shutdown and boot my install of ArkOS and I've only ran into the issue once over hundreds of boots and a simple reboot fixed the issue for me.

Are you sure there aren't two problems contributing to "no audio" problem?
Jut to say: I tried everything, rebooting, plugging a jack, etc., and nothing worked.
I noticed that in ES settings, the volume always went down to 0 after setting it to other value.
So I thought ES was the culprit.

Sorry for the rg353m, it's F+l3.  You can find that information in the faq here: https://github.com/christianhaitian/arkos/wiki/Frequently-Asked-Questions---rg353m#q-what-are-the-global-event-keys-and-emulator-event-keys-in-ArkOS
No settings backed up in the process would cause that issue you described.  Either the device was accidently muted or the .asoundrc.cfg file located in /home/ark got corrupted.  The corruption of the .asoundrc.cfg file can happen from using a usb dac or bluetooth audio but usually a reboot of the device should solve that issue.


Reactive dict/map between documents

It seems a common data structure one would like is the following:
{
  related: {
    <id of a document>: {
      subfield: "Subfield value"
    },
    <id of a document>: {
      ...
    }
  }
}

So a dict/map where keys are IDs and values are a subdocument with few fields of a referenced document. One can do that as a list for now, but I think having a dict/map would be beneficial for easy direct access if key (document id) is known. But current code does not yet support keeping subdocuments in sync for such structure.

I'm interested in your use case for identified related documents with a subset of fields kept sync'd.  Can you share your example/general case.  Much appreciated.

I do not understand your question. This ticket is about one particular structure of data and not a general ticket for questions about PeerDB.

It seems I misunderstood your idea/proposal.  I initially thought you were proposing an alternative/extension to the existing ReferenceField capability fieldName: @ReferenceField and was seeking to understand your use case/why it wasn't sufficient... as per README:
class Post extends Document
  # Other fields:
  #   body

  @Meta
    name: 'Post'
    fields: =>
      # We can reference other document
      author: @ReferenceField Person, ['username', 'displayName']
      # Or an array of documents
      subscribers: [@ReferenceField Person]
      reviewers: [@ReferenceField Person, ['username', 'displayName']]

Yes. Here is a ticket for a different structure than what is currently implemented. But I have not seen really a need for it. I prefer to use list of subdocuments anyway. Also, I do not like data schemas where keys have meaning. So ticket/idea is here, but this is it.

This can also work only if <id of a document> does not contain a dot.


Template blocks for component inheritance

What problem does this feature solve?
In large applications, there are often families of components, within which components share most of the look/behavior, but vary slightly. This makes it desirable to reuse code between them. Some reuse can be achieved with slots, other is better with component inheritance. But while most of the parent component definition can be smart-merged with child definition, the template has to be either kept as is, or replaced entirely.
I have seen multiple approaches to reusing component templates:

Write very granular appearance-only components with many slots. While this sounds good in theory, in practice the granularity needed often makes this approach into an obstruction rather than abstraction.

Implement all required variation in a single component and make it configurable with slots and props. The downside is that you are stuck with a god-component, which is hard to maintain and extend further.

Extend the component, and use <parent>...</parent> in the child template, using slots as "parts". The downside is that you have to "proxy" all props and slots down and events up. This is very cumbersome and fragile.

Split the component in question further into "part" components, so that you can override only certain part. This gets tedious very quickly, especially when you need v-bind or v-on inside of the overridden part.

Define "part" render functions among the methods, so that they can be overridden. The downside is that you can not really write such parts in template DSL, and the parts get disconnected from the main template, which makes it harder to understand.

What does the proposed API look like?
The Pug template engine (former Jade) implements a feature called blocks, which allows templates to extend other templates while overwriting (or extending) certain named blocks. I think this feature ported to Vue would fill the gap described above, and allow the templates to be more reusable.
A possible syntax:

<template>

    <block name="header">

Default header

    </block>
    <block name="body">

Default body

    </block>
    <block name="footer">

    </block>

</template>

<template>
  <block name="header">

More pronounced header

  </block>
  <block name="footer">

Footer added by the child

  </block>
</template>

How and where are child and parent connected in the proposed api example?

@posva i think using the extend property

First of all, I really don't think introducing a parallel composition mechanism is the way to solve this problem. In particular, when this is used in conjunction with slots it could lead to a lot of confusion.
Your solution (1), i.e. a structural component that exposes the outline + slots, is imo the proper abstraction for the problem - I'd like to see an actual example where it becomes obtrusive as you suggested.
Finally, template compilation for functional components, once supported, can probably alleviate this problem to some extent.

use posthtml?

TLDR: an example where structural component is verbose to proxy.
I agree that a new block inheritance will cause much confusion and that structural component should be the solution for this.
But I also have sympathy with @simplesmiler for extending component, namely the point 3 in OP's issue. I have a realistic example at hand. I don't know much about functional component with template, so I won't include it in this example.
Consider a generic map component, say google map clone.

It accepts many props: width, height, zoom level, lat/lng,
It emits many events: onZoomIn, onZoomOut, onPinClicked, onMapMoved, ....
It exposes many slots: a header, a zoom control, a view type control (switching satellite/terrain), some pins on map, a popup (when user clicks a pin), a legend.

The map component is very powerful. Arguably it is so powerful as to be a god component, but these features are cohesive enough to be organized into one component. So I choose to implement the map by structural component with default slot, rather than other methods in OP issue like splitting into smaller/representational components.
Then users will have to proxy all the props/events/slots.
For example, this is an imaginary implementation for component vue-map.
<template>

  <slot name="header">implementation.....</slot>
   <slot name="zoom-control">
      <button @click="zoomIn"></button>
   </slot>
   // template slot for pin
   <template v-for="pin in pins">
      <slot name="pin" lat="pin.lat" lng="pin.lat">

I'm default pin!

       </slot>
   </template>
   <slot >
   // more to go....

</template>

Now, we want to create another generic map component, but for VIP users: the only difference is that pins on VIP map will have shiny borders and filaments.
<template>
<vue-map
     @zoomIn="reemit" @zoomOut="reemit"  @mapMove="reemit" v-bind="$props">  // proxy
   <template scope="pin" slot="pin">

        <slot name="pin" lat="pin.lat" lng="pin.lng"></slot> // proxy

   </template>
  <template slot="header"><slot name="header"></slot></template> // proxy
  <template slot="zoom-control"><slot name="zoom-control"></slot></template> // proxy
   // a lot to proxy
</vue-map>
</template>

It is quite verbose to proxy all events/slots. Proxying slot is error-prone, maybe due to the same name of original slot and new proxy slot.
We already have v-bind="$prop" to reduce the verbosity of proxying props, but it seems we cannot concisely proxy events or slots in template. (Similar discussion https://github.com/vuejs/vue/issues/4703).
Indeed, we can sidestep tedious works by using render functions and JSX. But it goes to OP's point 5: mixing template and render function is hard for understanding.

@yyx990803 with (1) components tend to become so granular that they end up being a div with a class, thus making the abstraction so thin that it might as well not even be there. That's what I meant by "obstructiveness".
I would have liked to avoid large examples, but that would defeat the purpose, so please bear with me.

Say you need to develop a panel component that would encapsulate the look of panels in the app. Generic panel has a title in the header and slot for content. But panels may have a lot of variation:

Some panels need subtitle along with the title, some need an icon before or after the title, some need action buttons or other widgets aligned to the opposite side of the title.

Some panels need their header shaded with color, some need header the same color as body (with or without a separator between them).

Some panels need their content to be padded (e.g. text), some panels need their content to be flush with the panel borders (tables, charts, images, etc.).

To accommodate for this variation you decide to go with granular appearance components. Your panel when used, starts to look like this (not accounting for layout styles like flexbox):
<panel>
  <panel-header slot="panel-header" color-scheme="primary">
    <panel-title title="Settings" subtitle="subtitle" icon-left="cog"></panel-title>
    <action-list :actions="actions" @action="handleAction"></action-list>
  </panel-header>
  <panel-body slot="panel-body" flush>
    ...
  </panel-body>
</panel>

All is good so far.

Then you recognize, that among all the possible variation there are common use cases. So you decide to write components for these common use cases to avoid code duplication. This way you end up with text-panel, chart-panel, confirm-panel, etc. And this is where things start to go a little bit south.
If you want to write a specialized panel that behaves exactly like an existing one, but has some altered behavior/interface (e.g. confirm-panel with an extra button) then either:

You need to put this variation into the parent component (e.g. in form of a slot or a prop).
You need to redefine the child template completely, because there is no way to reuse parent template.

Of course you could define components that encapsulate common variations of parts of the panel. But at this point you will already have three levels of abstraction (appearance, common part, common panel). And every level requires you to proxy props, slots and events.

Maybe you can try pug like this in vue
https://pugjs.org/language/inheritance.html

I'm also interested in this. In my specific case, I don't have very granular components, however several 'pages' where I need different 'layouts'.
Currently, I'm solving this using appearance-only components, as OP states it. I have a DefaultLayoutComponent which imports further stuff like SidebarComponent etc. as well as a BlankLayoutComponent which has nothing but a router-view as it's template. Composition is done with child components inside the vue-router configuration. This 'top-down' approach has a major drawback though: It results in a god object (the router configuration) which defines the entire composition of the application, instead as having modular components which could inherit certain aspects of their parents (e.g. template or imported components).

I still feel that having an extra composition model greatly muddles the structure of the program and only makes the mental model more complex then it should be. Although the proposed solution may make certain use cases a bit more manageable, I'm not really convinced of the tradeoff.

@yyx990803 I think that without such a mechanism, component composition via inheritance is inherently broken, since it allows no affordances DRYing up your template. The fact that people are using the Pug template language workaround is proof enough of this, IMO. The downside, of course, is that it introduces another dependency, and a whole new templating language, just for this feature. I would urge you to re-open discussion on this!

Actually I'm with @simplesmiler @HerringtonDarkholme. We might need a way to reuse render logic in templates without messing up data context. Another parallel mechanism will definitely increase complexity but I think it's better than introducing something like pug to reuse template pieces after all...


Gradle includes files from one configuration with different attributes into another

Current Behavior
Gradle includes files from one configuration with different attributes into another
Expected Behavior
Gradle does not include files from one configuration with different attributes into another
Context (optional)
No response
Steps to Reproduce
project.zip
run ./gradlew :apollo-kdoc:dokkatooGeneratePublicationHtml
Observe error e: java.lang.NoClassDefFoundError: com/apollographql/apollo3/ast/ApolloParser
This is caused by Gradle is leaking one Configuration into another, despite the attributes being different.
--------------------------------------------------
Variant dokkatooHtmlPublicationPluginClasspathApiOnlyConsumable
--------------------------------------------------
Shared Dokka Plugins for consumers that will assemble a html Publication using the Dokka Module that this project produces

Capabilities
    - com.apollographql.apollo3:apollo-ast:4.0.0-beta.5-SNAPSHOT (default capability)
Attributes
    - dev.adamko.dokkatoo.classpath  = dokka-publication-plugins
    - dev.adamko.dokkatoo.format     = html
    - org.gradle.category            = library
    - org.gradle.dependency.bundling = external
    - org.gradle.jvm.environment     = standard-jvm
    - org.gradle.libraryelements     = jar
    - org.gradle.usage               = java-runtime

vs
--------------------------------------------------
Variant jvmRuntimeElements
--------------------------------------------------
Elements of runtime for main.

Capabilities
    - com.apollographql.apollo3:apollo-ast:4.0.0-beta.5-SNAPSHOT (default capability)
Attributes
    - org.gradle.category                = library
    - org.gradle.jvm.environment         = standard-jvm
    - org.gradle.libraryelements         = jar
    - org.gradle.usage                   = java-runtime
    - org.jetbrains.kotlin.platform.type = jvm
Artifacts
    - build/libs/apollo-ast-jvm-4.0.0-beta.5-SNAPSHOT.jar (artifactType = jar)

Gradle version
8.5
Build scan URL (optional)
No response
Your Environment (optional)
No response

As stated in our issue template, a minimal reproducible example is a must for us to be able to track down and fix your problem efficiently.

Are you sure? I didn't see it

Having a description like "I expect X but observe Y" without providing the context and a description of what are you trying to do is hard to comprehend and time-consuming for us.

I provided the information requested by the issue template... If you're saying that the wording and phrasing is unclear, I can only agree, and I'd like it if the template was re-worded.

Your reproducer is a whole project of yours

It's not a whole project, it's cut down to be smaller.
I find Gradle usually doesn't provide suitable tools or information to diagnose issues, which means creating a smaller reproducer is usually an extraordinary amount of effort.

we're not the support to help you solve your issues.

I'm not looking for support, I'm reporting an issue.

Sure, sometimes your reproducers can point to the issues in Gradle, but our resources are too limited to investigate every project with an error.

I'm sorry that your resources are limited, I can empathise. My resources are limited too.

How is this different from #27991 ?
Does the added answer over there clarify the situation?
And once again, documentation needs improvement - see #18846

How is this different from #27991 ?

This issue is a bug report, I think it's similar to https://github.com/gradle/gradle/issues/26463
#27991 is a separate feature request.

Does the added answer over there clarify the situation?

Thanks for asking, no it doesn't.

Ok, however, nothing is easily actionable for us in your report.
Your reproducer contains over a thousand files. Your description of the problem needs to be more extensive. Variant selection does not work as expected, but you do not provide in a clear way what attributes the consumer requests or what the producer provides.

Could you share a minimal reproducer?
Could you at least share the attributes:

on the consumer configuration,
on the producer variant you expect to be selected (or confirm that's the first one you shared)
on the selected variant (or confirm that's the second one you shared)


Terraform export should use multiple files

Would it be possible to have the export into .tf files use more of a modular approach?  All of what is exported currently goes into a single main.tf, but could be separated by function or as Terraform/ORM best practices advise.

I can take a look

Release v0.37.0 has this functionality with the TF resources split based on how the console splits the Resources


Update Mod Packages to use Optional Packages Schema AND Fix Update Settings + OS + Schema mismatch Bugs

Fixes:

ModPackges were being created under an invalid  element in the generated AppInstaller file. I made changes to have them added under the  element instead.
Update Settings:
a.	HoursBetweenUpdates was showing up as an update option for MinOS Version 1709 and being written in an AppInstaller file referencing the 2017 schema. It was only supported in 1803 so I changed the UI to have it only show up with minOS 1803 selected and also be written when schema is 2017/2 or later.
b.	ForceUpdateFromAnyVersion was showing up as an Update Option for MinOS 1803 and being written in an AppInstaller file referencing the 2017/2 schema. It was only supported 1903 (technically 1809 for UWP but 1903 for Centennial). I changed the UI to have it show up with minOS 1903 selected and be written to an AppInstaller file referencing 2018.

            case 0: //1809 and above

comment doesn't match the string lStrings list above (1903)?

Refers to: AppInstallerFileBuilder/AppInstallerFileBuilder/Views/MainPackageView.xaml.cs:309 in 0efdb23. [](commit_id = 0efdb23eaaba9ac3fd7842e7b814c6a954f0a10e, deletion_comment = False)


infrastructure administration function app

This PR creates a function app to allow low-level testing and validation of the cloud environment.
Test Steps:

N/A

Changes

Creates an admin function app with python functions via Terraform

Checklist
Testing

[x] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Linked Issues

Fixes #4245

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Time to review
Total comments

jeremy-page
21
18m
3

cwinters-usds
16
2h 1m
12

carlosfelix2
15
2h 11m
65

kevinhaube
10
19h 14m
13

TomNUSDS
9
1h 19m
24

bgantick
7
33m
1

MauriceReeves-usds
7
19h 30m
4

oslynn
5
9h 24m
0

brick-green-agile6
5
24m
0

clediggins-usds
5
2h 30m
3

sethdarragile6
5
42m
1

snesm
5
48m
6

jorg3lopez
4
15h 49m
2

TurkeyFried
3
26m
1

JosiahSiegel
3
3m
0

ahay-agile6
2
5h 15m
1

jimduff-usds
2
23h 53m
1

jbiskie
2
33m
0

jh765
2
38m
3

mreifman
1
15h 36m
0

acoushawk
1
4m
0

Resolved LGTM concerns


Elide demo may need some updates

My findings from trying to ingest sample data into the standalone Elide demo (https://github.com/markpatton/pass-elide-test) locally with the in-memory DB. I'd be interested if anyone else has found the same issues when using Elide with PostgreSQL.
Example for changing model field mapping of column type:
Some fields need to accommodate long strings, but Elide maps String fields to column type varchar(255) by default. Ultimately we need to evaluate the data types for our data model fields, but at a minimum, the fields in this change throw errors with simple example data. This PR is mostly for an example for changing column data types.
Looks like type 'text' is recommended for PostgreSQL anyway (https://www.postgresql.org/docs/current/datatype-character.html)
This amounts to updating some String fields in the data models:
import javax.persistence.Column;
  ...
@Column(columnDefinition = "text")
private String myTextField;

Policy OneToMany relationship
Policy.repositories has a @OneToMany unidirectional relationship with Repository entities. Looks like we need to add a @JoinColumn(name = "Repository") to point Elide to the proper Repository table
Dates
grant.awardDate, grant.startDate, grant.endDate, submission.submittedDate are currently of (Java) type java.time.LocalDateTime
Looks like we'd either need a custom converter for this type, or to switch to use java.util.Date, which is supported out-of-the-box by Elide.
A custom converter shouldn't be too difficult, whereas moving using java.util.Date may require data remediation. I could not get java.util.Date to read our timestamps:

Sample timestamp
2017-07-01T00:00:00.000Z

Recognized by java.util.Date
2017-07-01T00:00Z

Some example changes were captured here https://github.com/markpatton/pass-elide-test/pull/1

After these changes were applied, the data loading seems to work fine for me with the in-memory DB, but I am seeing errors when loading Grant data with the postgres backend
Sample grant data that I'm using: https://github.com/jabrah/pass-elide-sample-data/blob/main/data/grants.json
The only error messages I'm seeing in the logs:
ERROR:  syntax error at or near "Grant" at character 13
STATEMENT:  insert into Grant (awardDate, awardNumber, awardStatus, directFunder_id, endDate, localKey, pi_id, primaryFunder_id, projectName, startDate, id) values ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11)

It turns out grant is a reserved word in posgres. I've given all of the tables names starting with pass_ to fix this class of problem. Update pushed.

Resolved, based on Mark's table name update.


feat(sbb-tooltip): add sbb-tooltip-trigger

Preflight Checklist

[ ] I have read the Contributing Guidelines for this project.
[ ] I agree to follow the Code of Conduct that this project adheres to.
[ ] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Issue
This PR Closes #
Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:

Browsers
I tested the build on the following browsers:

[ ] Firefox Desktop
[ ] Chrome Desktop
[ ] Edge Desktop
[ ] Safari Desktop
[ ] Chrome Mobile
[ ] Safari Mobile

Screen readers
I tested the build on the following browsers:

[ ] JAWS Firefox Desktop
[ ] JAWS Chrome Desktop
[ ] NVDA Firefox Desktop
[ ] NVDA Chrome Desktop
[ ] VoiceOver Safari Desktop
[ ] VoiceOver Chrome Desktop
[ ] VoiceOver Safari Mobile
[ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Codecov Report

Merging #1528 (b32c683) into master (ab917b0) will decrease coverage by 1.62%.
The diff coverage is 62.16%.

@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
- Coverage   54.85%   53.22%   -1.63%
==========================================
  Files          49       82      +33
  Lines        1659     3442    +1783
  Branches      406      961     +555
==========================================
+ Hits          910     1832     +922
- Misses        671     1476     +805
- Partials       78      134      +56

Impacted Files
Coverage Δ

...mponents/sbb-accordion-item/sbb-accordion-item.tsx
0.00% <0.00%> (-37.21%)
:arrow_down:

src/components/sbb-clock/sbb-clock.tsx
0.00% <0.00%> (ø)

src/components/sbb-link/sbb-link.tsx
59.57% <ø> (-31.86%)
:arrow_down:

src/components/sbb-logo/sbb-logo.tsx
0.00% <ø> (ø)

src/components/sbb-menu-action/sbb-menu-action.tsx
61.90% <ø> (ø)

src/components/sbb-menu/sbb-menu.tsx
25.89% <ø> (ø)

...ts/sbb-navigation-action/sbb-navigation-action.tsx
71.42% <ø> (ø)

...onents/sbb-navigation-list/sbb-navigation-list.tsx
84.00% <ø> (ø)

...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx
30.61% <30.61%> (ø)

src/components/sbb-alert-group/sbb-alert-group.tsx
33.33% <33.33%> (ø)

... and 65 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


bump kn-admin dependencies

Dependencies are out of date https://github.com/knative-sandbox/kn-plugin-admin/blob/master/go.mod

/assign


ktx-box2d: extension method for querying

This extension method allows querying for fixtures overlapping an AABB in a more Kotlin idiomatic way.

Thanks.


Fix cookie tests so they don't depend on execution order

If tests are executed with random ordering, then they fail in certain cases.
This seems to be due to a forgotten duplicate assert during test refactoring.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


EOS-13678: Consul doesn't always invoke service watcher

The issue is caused by this Consul bug reported by @andriytk this winter: https://github.com/hashicorp/consul/issues/7069
The main problem with these delayed service watch handler invocations is that sometimes hax can broadcast (erroneously) a Motr service state as M0_NC_FAILED while the service is actually up and running. Such a broadcast will force all Motr processes and services to disconnect that service that will cause to bigger problems (as listed in https://jts.seagate.com/browse/EOS-13678)
Workaround: don't rely on watch mechanism. Instead, poll the service health status directly from Consul via Health API.

@knekrasov , could you please add a little bit more context into the description? Thanks.

@vvv, @chumakd it would be nice if you could take a look at the Python code here (style, etc.)

@knekrasov , could you please add the context info into the commit msgs also? As we are in the very beginning of the review - it is Ok to force push the updated commit here.

Problem: consul sends useless requests to hax with serice statuses …

I'd suggest either to merge this patch with the previous one or explain in its commit-msg why it is useless. Otherwise, it's not very clear.


update ElvPPP

Codecov Report
Patch and project coverage have no change.

Comparison is base (c11f936) 60.63% compared to head (c9bf656) 60.63%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #177   +/-   ##
=========================================
  Coverage     60.63%   60.63%
  Complexity      541      541
=========================================
  Files           108      108
  Lines          2073     2073
  Branches        218      218
=========================================
  Hits           1257     1257
  Misses          735      735
  Partials         81       81

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat: Adding topology model classes and junit annotation processing

Description
This pull request changes the following:

Adds code for reading annotations specified over junit tests
The annotations are converted to model classes
Adds model classes for representing deployment topology (for passing to test tool kit)
Adds draw.io diagrams for good documentation

Related Issues

Closes #382

Added an issue to improve test coverage in the future https://github.com/hashgraph/full-stack-testing/issues/447

:tada: This PR is included in version 0.12.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


kq_init error on demo start

Output:
╰─± npm start                                        [▶▶▶▷▷▷▷▷▷▷]

><EMAIL_ADDRESS>start /Volumes/Delta/delta-repo/photon
> electron dist/template-app

App threw an error when running [SyntaxError: Unexpected token {]
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0

This is perhaps a syntax error
Unexpected token {]

But this project is long remain unupdated.

Thanks for the heads up @anditakaesar, i'll take another look. Cheers ++


Series title can overlap block controls in page editor

The easy solution is to just raise the z-index of the button group, but then that might cover the title, of course. :thinking:

This doesn't happen anymore since the title is displayed differently now:


Can't use Chinese to drawtext

ffmpeg.FS('writeFile', "Songti.ttc", await fetchFile(font));

await ffmpeg.run("-i", "333.mp4", "-vf", "drawtext=fontfile=Songti.ttc:fontcolor=black:fontsize=50:text='这里输入了中文':x=(w-tw)/2:y=200", "-preset", "ultrafast", "-y", "result.mp4");

I have import the Chinese font "Songti.ttc", but after running the command, I still cannot drawtext Chinese into the video.
If I change the content of text to English, this command is effective.

We can write Chinese into the text file and use [textfile=**.txt]
like:
ffmpeg.FS('writeFile', "aaa.txt", await fetchFile(txtfile));
await ffmpeg.run("-i", "333.mp4", "-vf", "drawtext=fontfile=Songti.ttc:fontcolor=black:fontsize=50:textfile=aaa.txt:x=(w-tw)/2:y=200", "-preset", "ultrafast", "-y", "result.mp4");


lib: posix: pthread_common: Fix potential integer overflow issue

Fix potential overflow of interger expression for by fixing
variable type to s64_t.
CID: 185275
Signed-off-by: Ramakrishna Pallala<EMAIL_ADDRESS>

Codecov Report

Merging #7252 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7252      +/-   ##
==========================================
- Coverage   55.03%   55.03%   -0.01%
==========================================
  Files         477      477
  Lines       51743    51743
  Branches     9948     9948
==========================================
- Hits        28476    28475       -1
- Misses      19304    19305       +1
  Partials     3963     3963

Impacted Files
Coverage Δ

lib/posix/pthread_common.c
75% <ø> (ø)
:arrow_up:

lib/posix/pthread.c
69.34% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2002a4e...58aa0ac. Read the comment docs.


feat: Add CI.

⚠ Note: This PR is dependent on #8—do not merge before then!
This PR adds a minimal CI setup for the STLoR repo. Now, on every push to main or PR against main, we take the following steps:

In a fresh GitHub-hosted Ubuntu runner, checkout the the latest version of 03_ActivityMatch.csv on origin/main, which should represent our source of truth. Rename this file to main_ActivityMatch.csv and store it using the upload-artifact action.

This is the entirety of the checkout-data job.

In a sequential job, download main_ActivityMatch.csv to the root directory using the download-artfiact action.

Note that this job acts on the branch of the current PR or commit.

Install all dependencies listed in pyproject.toml.
Build the dataset using the latest code changes in the PR or commit.
Run our semantic comparison script between the CSV from origin.main and the just-generated dataset and print the diff (if any).

Note that we don't error if there is a diff. I expect we may have a few changes in the coming days that will result in updates to the dataset, and we don't want to consider those errors. However, this script should at least alert us to instances where code changes amount to differences in the generated dataset.

Note that the compare job is expected to fail until #8 is merged. We'll know for certain if everything is working correctly once we merge that PR and trigger a new run of the workflow here.

currently seeing
Run python stlor/main.py
python: can't open file '/home/runner/work/STLoR/STLoR/stlor/main.py': [Errno 2] No such file or directory
Error: Process completed with exit code 2.

on the run attempt (post-merge of previous PR). is that expected behavior or a file path issue?

Expected—the branch just needed a rebase to pick up the new directory structure.


Return value of CpSolver.Value()

I noticed that the CpSolver.Value function in python does not care what kind of input it gets - if it is not a variable it will simply return 0.
Is that the intended behaviour?
It is quite confusing, I think.

yes.

I am pushing the fix that will raise an exception.


create diag method for kernels

diag(kernel, data)

To return a vector of the diagonal elements, optionally as a diagonal matrix.
Add a function to compute diagonal in each kernel's object, and access these as the diag method

Done, with commits 92c70184fd 92c70184fd
Syntax is now:
kernel(data, diag = TRUE)
kernel(data, newdata, diag = TRUE)


md5 and sha256 File Validation Tool

Description of the new feature / enhancement
Right-click on the file that needs to be verified to quickly calculate the hash value for verification
Scenario when this would be used?
It is necessary to hash the file downloaded from the network to avoid virus and Trojan attacks, and it is also possible to determine whether the downloaded file is valid
Supporting information
No response

/dup #57


How to get all queue counts in cluster?

Hey guys,
is there any way how to get counts / no. queued jobs from all limiters in the cluster?
This would be super useful feature to monitor health of the cluster / know how much of jobs are currently distributed in local queues and depending on that regulate feeding of limiter.
Many thanks and keep it up

Hi, this is a nice little feature that recently became possible to implement. I'm starting now and it will be done in a few hours, will you be able to try it and provide feedback?

Done in v2.16.0.
Use limiter.clusterQueued(). Please let me know if it works for you!

Wow that was quick :), thanks a million!
Will try it first thing tomorrow and will let you know.

Yeah it was pretty quick because the required data was already being tracked correctly.
A few months ago I changed the scheduling logic to be deterministic and favor limiters that have not run a job recently, that way all limiters are guaranteed to get through their queues in a fair way. Here's the code that computes which limiter ('client') should run next: https://github.com/SGrondin/bottleneck/blob/d332f43db83a89a5ced235187d2ce1999bfd2fa6/src/redis/process_tick.lua#L112-L162
To write that code I had to start tracking which clients are 'active' (they've communicated with the Cluster in the last 10s) and their known number of queued jobs at any time (grab the initial number when they connect, then increase/decrease it as they process jobs).
So .clusterQueued() is just: https://github.com/SGrondin/bottleneck/blob/d332f43db83a89a5ced235187d2ce1999bfd2fa6/src/redis/queued.lua

Get all active clients
Get known queued for each
Sum it up

Plus the wiring, tests, etc.

Hi, this is definitely an error in Bottleneck itself, but all the tests are passing and I'm not able to trigger it at all. Could you paste your test that's failing and/or describe it? What are your settings?

Hi,
after dropping redis container and clean install of node_modules it started working, so it was just weird state after upgrade maybe?
Anyway, tested with 4 nodes cluster and clusterQueued() seems to be working as expected!
Many thanks @SGrondin!
Cheers

Glad to hear that! 🎉


Mavlink header install using ExternalProject_Add

When building MAVSDK using CMake's ExternalProject_Add, with SUPERBUILD on, it will properly pull and build all of MAVSDK's dependencies. However, I get errors for missing mavlink headers and indeed this commit changed where the files were installed to. It would be great if we could either have the mavlink headers installed alongside the mavsdk ones automatically, or at least have a CMake option to change where dependencies are installed to.
I would suggest possibly setting DEPS_INSTALL_PATH to CMAKE_INSTALL_PREFIX on this line . Alternatively, you could make DEPS_INSTALL_PATH an optional argument, so users can place it to their needs, and it would be accessible via ExternalProject_Add.

This said, after some experience with CMake superbuilds, my more recent opinion is that we should provide helpers, but not a superbuild (see my blog post here). That's much less confusing in the sense that it makes it clear to the user that they should handle their dependencies.
But well, doesn't change the fact that MAVSDK uses this superbuild, and many users don't want to know about how they should handle their dependencies :see_no_evil:. So probably your best bet is what I wrote in my previous message.

Yeah, for the time being I am just using:
target_include_directories(my-project PUBLIC
    ${CMAKE_BINARY_DIR}/mavsdk/src/mavsdk_proj-build/third_party/install/include
)

An option would be nice to have still, just so it's not quite so hacky.

Just build your project with CMAKE_PREFIX_PATH=path/to/mavsdk/src/mavsdk_proj-build/third_party/install, right? That would be clean.

To a degree, yeah, if I wanted to put mavlink specifically into my cmake code. I was trying to keep it generic. When using ExternalProject_Add, the code is not yet in CMake at generation time, so I can't use find_package on a target which is not installed yet. If I pulled the full repo and had it as a submodule instead (before calling any CMake), then yes I could use the CMAKE_PREFIX_PATH.

I somewhat reverted this to the previous behaviour: #2084.

To a degree, yeah, if I wanted to put mavlink specifically into my cmake code. I was trying to keep it generic.

Well MAVSDK transitively depends on MAVLink in its public interface (before #2084), and therefore find_package must find MAVLink somewhere. It's not about "putting mavlink specifically into your cmake code", it won't actually change your CMake code. You just have to tell your CMake project where to find the dependencies with find_package. Either you install MAVLink on your system, or you point CMAKE_PREFIX_PATH to it.
When you install the MAVSDK .deb package, it depends on stuff like openssl, and it will require you to install them on your system. Still you don't consider that you are "putting openssl specifically into your cmake code", right? That's exactly the same for MAVLink, except that MAVLink is not available with apt install libmavlink-dev.

I somewhat reverted this to the previous behaviour: https://github.com/mavlink/MAVSDK/pull/2084.

Yeah I guess that solves the confusion around the transitive dependency :+1:

I had tried adding to the CMAKE_PREFIX_PATH like you suggested @JonasVautherin, but still got the same header include errors. That's why I resorted to the more manual target_include_directories entry.

Try my PR/branch @jperez-droneup .

Meant to comment, I tried it and works well, with no janky include paths :)


Ajc cleanup optimus

Removed duplicated Optimus folder
pretty printed json objects
fixed Optimus to deal better with malformed filenames with no file extensions
updated sctools to deal with file extensions (see companion PR)

Companion PR:
https://github.com/HumanCellAtlas/sctools/pull/5

@samanehsan Good to merge? I need to get this in so that I can develop against the correctly named files for the PR test.

This looks good to me @ambrosejcarr


overload _alg_autodiff

fix downstream errors in https://github.com/SciML/OrdinaryDiffEq.jl/pull/1917

all tests passed locally with https://github.com/SciML/OrdinaryDiffEq.jl/pull/1917 branch

@gaurav-arya can you review

@ChrisRackauckas @nathanaelbosch , could you approve workflow please? This should be good to go now that OrdinaryDiffEq. 6.5.2 has released

Codecov Report

Merging #238 (ef20acb) into main (16229cb) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   95.63%   95.53%   -0.10%
==========================================
  Files          33       33
  Lines        1191     1188       -3
==========================================
- Hits         1139     1135       -4
- Misses         52       53       +1

Impacted Files
Coverage Δ

src/alg_utils.jl
84.21% <50.00%> (ø)

... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks a lot!


Fix swift-maven-plugin integration tests

This test downloads alternate versions of maven to test the plugin against, from a maven repo. Since it was running inside surefire (which for uniform testing purposes tries to provdie a clean environment separate from the user's environment) it was not respecting network properties configured by the user and so the download could fail if you were on an IPv6-only machine, or behind a proxy, etc.

LGTM. Make sure to test the case when proxyHost and proxyPort is empty

I ran 'mvn -U clean verify' on my laptop where none of these settings are needed (and I also verified they aren't set unnecessarily) and the build w/ tests all passed fine.

rebased and merged


Angularjs 2 Webpack and jade/pug, this is not working

For feature request or questions, ignore everything below.
For any issue related to demo page, please include the following details:

OS:  Linux
Steps to reproduce:
npm install zooming --save

add reference in archive app.module.ts
import { Zooming } from 'zooming';
add data-action to an image in .pug file
img.img-responsive([src]="imageZoomText.imagePath", data-action="zoom" )
Additional comments:
hello, this is not working

@luismiguelbravo Try import Zooming from 'zooming'.


--inherit-env for packed actions

Hello,
I'm writing a new action that runs a bash file (runner type - local-shell-script)
my YAML file -
---
name: create_ns
runner_type: local-shell-script
description: Create a new namespace
enabled: true
entry_point: 'shell/create_ns.sh'
parameters:
  name:
    type: string
    position: 1
  cluster:
    type: string
    default: 'dev'
    position: 2
  sudo:
    default: true
    immutable: true
  env:
    default:
      KUBECONFIG: "/path/to/file"
    immutable: true

In the stackstorm container i have a KUBECONFIG env variable, so what i'm really looking for is a way to pass environmant variable inside the execution.
i've seen in the documentation that --inherit-env passes the variables inside the execution, which is good, and if i use the CLI (`st2 run pack.create_ns -e) it works great! what i don't understand is how to specify it inside the YAML configuration?
Other methods i thought of -

Passing the environment as a parameter - won't work because i can't use {{ env }} (yaml files are static)
Maybe chaining it somehow? not sure exactly with what..

--inherit-env is a CLI only option. What it basically does is it inherits all the environment variable which are available where the CLI command runs and passes them to an action using env parameter (nothing to do with the server side environment variables but the ones which are available where CLI command runs).
By default, Python and remote runners inherit and use all the environment variables which are available to the action runner process (process / service under which actions run).
So in short, you need to make sure that environment variable is set and available to the action runner services (you might need to tweak service manager / systemd configuration file to make sure variable is correctly set / passed through).
You can test faster / easier by using st2 run core.local cmd='echo ${KUBECONFIG}' command.

Thanks for the answer @Kami,
I'm running Stackstorm as a Nomad job, and using Consul for configuration (for example - path to KUBECONFIG files).
What I did eventually is used Nomad's template stanza to generate a file inside the stackstorm container, and copied the file into /etc/default/st2actionrunner which passes the environment variable inside each action runner.

Setting it in /etc/default/st2actionrunner, as you did, is probably the best way to do this.


TS interface error, getting error when creating interface in the same file it is being used

Describe the bug
When I declare a TS interface inside other file and I use it I am getting a weird error
With this code it runs properly:

Using internal interface and getting the error:

Did you try recovering your dependencies?
Yes, I removed node_modules and package-lock.json and the problem persists
Which terms did you search for in User Guide?
Not relevant, it's a weird issue
Environment
☭ ~/3D Objects/interface-error-typescript 15:13:17 (main)
$ npx create-react-app --info
npx: installed 67 in 6.118s

Environment Info:

  current version of create-react-app: 4.0.3
  running from C:\Users\arkus\scoop\persist\nodejs-lts\cache\_npx\11640\node_modules\create-react-app

  System:
    OS: Windows 10 10.0.19043
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 14.17.6 - ~\scoop\apps\nodejs-lts\current\node.EXE
    Yarn: Not Found
    npm: 6.14.15 - ~\scoop\apps\nodejs-lts\current\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.1023.0), Chromium (93.0.961.52)
    Internet Explorer: Not Found
  npmPackages:
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    react-scripts: 4.0.3 => 4.0.3
  npmGlobalPackages:
    create-react-app: Not Found

☭ ~/3D Objects/interface-error-typescript 15:13:34 (main)
$ node --version
v14.17.6

☭ ~/3D Objects/interface-error-typescript 15:13:50 (main)
$ npm --version
6.14.15

Steps to reproduce
# Install dependencies
npm install

# Start development server
npm run start

You will get this error:

Expected behavior
Expect the app to build properly
Actual behavior

Reproducible demo
Here is a full project as simple as posible showing the error:

https://github.com/LuisEnMarroquin/interface-error-typescript

I created a GitHub workflow to test if it's also happenning in other computers and it looks that it is

Try separating the interface members with a semicolon or a comma.
interface CardInterface {
    appPath: string;
    appBack: string;
    textMain: string;
    textLast: string;
}

interface CardInterface {
    appPath: string,
    appBack: string,
    textMain: string,
    textLast: string,
}

This should fix the error 😃


Add support for OSB API client

The spring-cloud-open-service-broker repo is currently supporting brokers that implement the OSB API.
There are also some use cases that require to act as an OSB API client. This includes brokers (e.g. sec-group-broker-filter or Open Service Broker Catalog), or OSB tooling (e.g. OSB API validators mentionned in https://github.com/openservicebrokerapi/servicebroker/issues/363 such as osb-checker) or UIs/CLI such as  eden sb-cli. Having support for OSB client in the spring-cloud-open-service-broker repo would enable such uses cases to be using spring cloud.
The OSB client at https://github.com/orange-cloudfoundry/cf-ops-automation-broker/tree/cassandra4/cf-ops-automation-broker-core/src/main/java/com/orange/oss/cloudfoundry/broker/opsautomation/ondemandbroker/osbclient leverages the spring-cloud-open-service-broker 1.0.2 model classes and adapts the interfaces to use them with Feign. I have plans to update to spring-cloud-open-service-broker 2.0.0M1 release.
This approach is limited by the fact that support for OSB API polymorphic responses requires additional annotations for the model classes (either CreateServiceInstanceAppBindingResponse or CreateServiceInstanceRouteBindingResponse), and likely a custom jackson deserializer see inspiration from https://stackoverflow.com/a/32777371/1484823
I wonder whether there is a way for the spring-cloud-open-service-broker repo to accept contributed support for OSB client, or alternatively accept non breaking changes on the model classes so that a distinct repo can import the model classes.
Thanks in advance,
Guillaume.
/CC @JCL38-ORANGE

I believe we have already addressed one concern about importing the model classes. In the 2.0.x line, the models are available in the spring-cloud-open-service-broker-core artifact. Including that won't pull in any Spring Boot dependencies or enable Boot in any other way. Otherwise, we're happy to discuss specific ideas you have to make this project more flexible.

thanks @royclarkson and @scottfrederick !
Once I would have completed the bump of my osbclient to 2.0.0 version, I'll get back with either contributing the full OSB client (along with their tests ) or merely the models unmarshalling support

@gberche-orange unless it's minimal effort, let's please discuss further before you invest too much time in a PR, so we can insure we're all in agreement. Thanks!

@royclarkson @scottfrederick
I'm working to upgrade my osbclient to 2.0.1 version (and later one contribute it back) and am facing the following issue with Jackson deserialization of the spring-cloud-open-service-broker model classes (e.g. org.springframework.cloud.servicebroker.model.catalog.Catalog) that now require usage of a builder.
Would you accept a PR that would add jackson annotations to the model to ease the deserialization fo the spring-cloud-open-service-broker model classes ? If so, on which branch should I make this PR against in order to be able to use it in a stable version ?

More details on faced issue:
I managed to configure jackson to use the associated builder class: See https://gist.github.com/gberche-orange/58ef24889e96080a50dc325721bb7fa0. However I did not find a way to configure jackson to use the builder methods without modifying the builder itself in the spring-cloud-open-service-broker: seems builders behaviors can only currently be configured using the @JsonPOJOBuilder. See related https://github.com/FasterXML/jackson-databind/issues/242 and associated source code at https://github.com/FasterXML/jackson-databind/blob/ac82499e5ac9ecbf39e497462aa9542ca0195158/src/main/java/com/fasterxml/jackson/databind/introspect/JacksonAnnotationIntrospector.java#L1221-L1225
The only remaining option I can think of to be able to deserialize  spring-cloud-open-service-broker model classes without modifications is to configure jackson to create constructors that bypass the model builder classes. This seems a bit fragile as this may bypass any associated input validation and allow for injections of invalid JSON and potential security issues.

I just realized that some related work was done in 2.1.0M1 and in https://github.com/spring-cloud/spring-cloud-open-service-broker/issues/110, I'll further study this, sorry for the associated noise.

@royclarkson @scottfrederick I see in this issue that support for osb client had once been planned for 2.0.1M1 and then de-prioritized. Was there any work/throughts put into this support ? Is there still interest into bringing this feature into spring-cloud-open-service-broker ?
Here would be my design proposal for a synchronous client support (I did not study a reactive one)

new interfaces CatalogServiceClient, ServiceInstanceServiceClient, ServiceInstanceBindingServiceClient that have the same java method signature as corresponding controllers (e.g. CatalogController.getCatalog()).

It would have been great to share the spring-web annotations on parameters and path between client and controllers. I however did not find a solution to have spring-cloud-netflix support @RequestMapping annotation with multiple paths. It fails with message similar to java.lang.IllegalStateException: Method createServiceInstance can only contain at most 1 value field. Found: [/{cfInstanceId}/v2/service_instances/{instanceId}, /v2/service_instances/{instanceId}]

an integration test with some wiremock recorded responses (e.g. for asserting older versions of OSB clients can be contacted by the client)
an integration test with a OSB broker started in memory, and the client making call to it (to avoid maintaining wiremock recording for each latest OSB spec version)

@gberche-orange we didn't make it any further than having a discussion about a client being a useful addition. It's not going to make it into the 2.1.0 release at this point, but we'll certainly reconsider it for the future. The general consensus between us is that we should also build out spring cloud contracts for everything. That would greatly benefit the addition of a client, as well as anyone else implementing a service broker. Your thoughts are greatly appreciated. I can't commit to a timeline now, but we'll continue to consider this for a future release. And we're always open to PRs too of course.

@gberche-orange also, if you find anything off with the serialization in your testing, please do create a new issue for that. Thanks again for your support of this project and your feedback.

thanks @royclarkson

also, if you find anything off with the serialization in your testing, please do create a new issue for that.

I submitted #140 and will complete it with more serialization related commits today.

The general consensus between us is that we should also build out spring cloud contracts for everything. That would greatly benefit the addition of a client, as well as anyone else implementing a service broker.

The OSB spec now includes an openapi spec https://github.com/openservicebrokerapi/servicebroker/blob/master/openapi.yaml It would be great to leverage this for authoritative API definition for both client and server implementation. I see related work discussed into https://github.com/spring-cloud/spring-cloud-contract/issues/136
This API definition could then be complemented with additional contracts precisions, either in openapi extension leveraging spring cloud contract (see https://github.com/springframeworkguru/spring-cloud-contract-oa3), or through externally managed contracts that complement a base generated from the openapi (e.g. with community contrib described at https://svenbayer.blog/2018/07/17/cdc-with-swagger/)

Closing this as I believe this is now all done.

Closing this issue as developing a client within this project is out of scope.


Add support for keylime_webapp service to read intervals from keylime.conf

This PR is an implementation for #599

Looks good, LGTM

@mpeters @FengqiQiao
Not sure if you require sign-offs, but I just happened to notice this one seems to accidentally have been from an unconfigured git client..
Signed-off-by: root<EMAIL_ADDRESS>As it's the head commit you could maybe still rebase it w/o too much difficulty. If you care. :)

Sorry, I didn't notice this bad signature. We do require sign-offs going forward so I'm not totally sure of the right way to correct this. We don't want to amend the head because it's now published and any changes we make will break others checkouts. I'm fine making changes to git branches/forks that aren't the primary main branch of a project, but once it's out there like this, it's kind of permanent.
@lukehinds and/or @axelsimon do you have any thoughts on the best way to fix this? If nothing else, maybe the DCO bot should be updated to be able to catch these since<EMAIL_ADDRESS>is never a person that can sign off on where the code came from.

So sorry about that, my bad<EMAIL_ADDRESS>is actually me.
In order to get a clean dev environment, I created a new VM and worked on this PR under root user. However, I forgot to set up git using git config --global user.name and git config --global user.email. So when I pushed the commit, it resulted in the bad signature.

@mpeters I think you can revert which will lay down a new commit. @FengqiQiao can then amend their commit, fetch upstream, and then locally rebase on top of the new head and then push. The offending commit will still be in history but will be immediately adjacent to the reversion and the new commit.
Probably other options too.


Misc: Remove pykdtree dependency, codecov config, SPEC 0 tooling and other changes

Several small changes:

doc: add release link to navbar
doc: update warning message on documentation page (related to #1665)
doc: clarify timedelta conversion in tutorial_output notebook
Remove pykdtree dependency (fixes #1616)
Update codecov config to enable PR comments
Add reference file (along with check of that file) for compliance with SPEC 0 (completes #1658)

This is the output from the min-deps check workflow
Package           Required             Policy               Status
----------------- -------------------- -------------------- ------
python            3.10    (2021-10-04) 3.9     (2020-10-05) > (!)
cftime            1.6     (2022-03-03) 1.6     (2022-03-03) =
cgen              2020.1  (2020-02-07) 2020.1  (2020-02-07) =
dask              2022.8  (2022-08-05) 2022.8  (2022-08-05) =
matplotlib-base   3.5     (2021-11-18) 3.5     (2021-11-18) =
netcdf4           1.6     (2022-06-29) 1.6     (2022-06-29) =
numpy             1.23    (2022-06-23) 1.23    (2022-06-23) =
platformdirs      2.5     (2022-02-10) 2.5     (2022-02-10) =
psutil            5.9     (2021-12-30) 5.9     (2021-12-30) =
pymbolic          2022.1  (2022-05-09) 2022.1  (2022-05-09) =
pytest            7.1     (2022-03-14) 7.1     (2022-03-14) =
scipy             1.9     (2022-07-30) 1.9     (2022-07-30) =
trajan            0.1     (2022-11-22) 0.1     (2022-11-22) =
tqdm              4.64    (2022-04-04) 4.64    (2022-04-04) =
xarray            2022.6  (2022-07-23) 2022.6  (2022-07-23) =
zarr              2.12    (2022-06-23) 2.12    (2022-06-23) =

Currently the workflow gets run every 3 months. If a dependency in the reference file is out of date according to SPEC 0 it gets flagged in that table and CI gets failed.


Make error with tesscallback.h

First off, thank you for making this open source package, that has come in handy for many working with tesseract
I came across the following error while trying to make the qt-box-editor:
    /usr/local/include/tesseract/tesscallback.h:9701:20: error: ‘p1_’ was not declared in this scope
   (*function_)(p1_,p2_,p3_,p4_,p5_,p6_,a1,a2,a3,a4,a5);

and so on till 'p6_'. How can I resolve this?
My tesseract version and details:
    tesseract 4.00.00alpha
    leptonica-1.74.4
    libgif 4.1.6(?) : libjpeg 8d (libjpeg-turbo 1.3.0) : libpng 1.2.50 : libtiff 4.0.3 : zlib 1.2.8 : libwebp 0.4.0

   Found SSE

Ubuntu version : 14.04

This project was created for tesseract 3.02 .e.g. it should be compatible with 3.x version. Version 4.x is not supported - it has its own training process.


cf -v panics when %HOMEDRIVE% does not exist

This issue sounds similar to #355 but note the different error & stacktrace.
On my Windows 7 machine, HOMEDRIVE defaults to a remote drive mapped as I: at the office.
So at home it maps to a drive that does not exist. Note that I do NOT set CF_HOME here, I'm reporting a usability issue when forgetting to set that.

Not an unexpected error case, so should not show stacktrace
Why does cf -v need to access .cf\config.json anyway? It knows its version (6.10.0-b78bf10).
Suspicious message "panic: This shouldn't print anything"
Would be nice if cf recognized the situation and suggests me to set CF_HOME in the error message, or mention that it constructed the i:.cf\config.json path from %HOMEDRIVE% (Windows 7 also has HOME, HOMEPATH and HOMESHARE preconfigured so it's not obvious which is the culprit) and we should review them.

c:\>cf -v
FAILED
Config error: open i:\.cf\config.json: The system cannot find the path specified.
panic: This shouldn't print anything

goroutine 1 [running]:
runtime.panic(0x8689c0, 0xc08404c6c0)
        C:/Users/ADMINI~1/AppData/Local/Temp/2/makerelease155988687/go/src/pkg/runtime/panic.c:266 +0xc8
github.com/cloudfoundry/cli/cf/terminal.(*terminalUI).PanicQuietly(0xc084048cc0)
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/terminal/ui.go:164 +0x58
github.com/cloudfoundry/cli/cf/terminal.(*terminalUI).Failed(0xc084048cc0, 0xc08402ecc0, 0x51, 0x0, 0x0, ...)
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/terminal/ui.go:152 +0x26a
main.funcﾂｷ001(0x151738, 0xc084044db0)
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/main/main.go:55 +0x10e
github.com/cloudfoundry/cli/cf/configuration/core_config.funcﾂｷ001()
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/configuration/core_config/config_repository.go:107 +0x
85
sync.(*Once).Do(0xc08404c410, 0x2b6e90)
        C:/Users/ADMINI~1/AppData/Local/Temp/2/makerelease155988687/go/src/pkg/sync/once.go:40 +0x9d
github.com/cloudfoundry/cli/cf/configuration/core_config.(*ConfigRepository).init(0xc0840446c0)
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/configuration/core_config/config_repository.go:109 +0x
5e
github.com/cloudfoundry/cli/cf/configuration/core_config.(*ConfigRepository).read(0xc0840446c0, 0x2b6ec8)
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/configuration/core_config/config_repository.go:115 +0x
5c
github.com/cloudfoundry/cli/cf/configuration/core_config.(*ConfigRepository).Locale(0xc0840446c0, 0x0, 0x0)
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/configuration/core_config/config_repository.go:294 +0x
7e
github.com/cloudfoundry/cli/cf/i18n.Init(0x151938, 0xc0840446c0, 0x151908, 0x12203e0, 0xc0840446c0)
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/i18n/init.go:46 +0x4a
main.setupDependencies(0x2bffa0)
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/main/main.go:62 +0x3d6
main.init()
        C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/main/main.go:31 +0xc0

Thanks for the suggestion.
We have improved the error message and will consider you suggestions.


helm: add kubernetes jobs timeout parameters

kubernetes_jobs_timeout_limit, default job timeout for users;
kubernetes_jobs_max_user_timeout_limit, maximum allowed job timeout for users to set.
convert parameters to string using "!!str" to make it compatible in the future in case we will decide to use suffixes like "m" to express "minutes".

closes reanahub/reana-job-controller#343

I think it's important to add a changelog for this change.

Codecov Report

Merging #610 (2335779) into master (57be761) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   19.34%   19.34%
=======================================
  Files          26       26
  Lines        2078     2078
=======================================
  Hits          402      402
  Misses       1676     1676


404 Not Found. We are unable to find your profile. Please check your spelling and make sure you are searching by the correct platform.

i have run the bot on windows and everything is fine, but i have run it on ubuntu and it gives me 404 error, it may be api problem on ubuntu, if you can any help

This bot's data is sourced from https://r6.tracker.network/.
Try using the following method to check if your Ubuntu host can fetch data correctly.
curl https://r6.tracker.network/profile/pc/waifu_-.

If data cannot be retrieved, you can attempt to add an HTTP proxy


Add new members to the team.

Recently new members have been added to the community. Add their details on the teams page:

@akshatcoder-hash I want to work on this ..

Can I work on this issue ?

Hey @akshatcoder-hash  I want to work on this . Could you assign it to me ?

Assigned @GJS2162