Winget downloads incorrect locale version of SSMS

Brief description of your issue
I have an "ENU" version of SSMS installed on my Dutch locale Windows 11. When I tried to update it with WinGet it downloaded a "DEU" version (German / Deutsch) which then failed to install.
Steps to reproduce
winget upgrade --id Microsoft.SQLServerManagementStudio
Expected behavior
Download correct version (ENU, not DEU)
Actual behavior

In (relevant) text:
winget upgrade --id Microsoft.SQLServerManagementStudio
Found Microsoft SQL Server Management Studio [Microsoft.SQLServerManagementStudio] Version 19.0.2
Downloading https://go.microsoft.com/fwlink/?linkid=2226343&clcid=0x407
Successfully verified installer hash
Installer failed with exit code: 1626
Installer log is available at: C:\Users\Rob\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir\WinGet-Microsoft.SQLServerManagementStudio.19.0.2-2023-04-14-10-54-02.025.log

The problem appears to be in the clcid=0x407 part of the URL WinGet uses to download:
https://go.microsoft.com/fwlink/?linkid=2226343&clcid=0x407
Which results in the DEU version downloaded. When I strip that querystring parameter from the link the correct version (ENU) is downloaded:
https://go.microsoft.com/fwlink/?linkid=2226343
Environment
winget --info
Windows Package Manager (Preview) v1.5.441-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.1555
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.441.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Other software:
Microsoft SQL Server Management Studio 19.0.1 / 19.0.2

Or maybe I'm incorrect here . . . .
The manifest does seem to have the correct URL's, but perhaps it's because the host machine locale is Dutch? I think I've confused myself

I have a similar problem: my machine has Windows 10 with an Italian locale and I have an "ENU" version of SSMS 18 installed.
When I run "winget upgrade" it downloads and installs the 19 version with Italian locale, not "ENU" as the previous one.
I seems the same issue, the clclid used is 0x410 Italian
(1/4) Trovato Microsoft SQL Server Management Studio [Microsoft.SQLServerManagementStudio] Versione 19.0.2
Questa applicazione viene concessa in licenza dal proprietario.
Microsoft non è responsabile né concede alcuna licenza a pacchetti di terze parti.
Download in corso https://go.microsoft.com/fwlink/?linkid=2226343&clcid=0x410
  ██████████████████████████████   645 MB /  645 MB
Verifica dell'hash di installazione completata
Avvio installazione pacchetto in corso...
Installazione riuscita

The manifest does seem to have the correct URL's, but perhaps it's because the host machine locale is Dutch? I think I've confused myself

I don't think the locale is relevant; when updating it should keep the locale version that's currently installed, regardless of machine settings.

Hold on tight, my system is PL, I'm using EN version of SSMS but winget downloaded DE language.
❯ systeminfo
System Locale:             pl;Polski
Input Locale:              pl;Polski

Installation log:
Initializing numeric variable 'InstallerLcid' to value '1031'

SSMSInstalledLanguage1031 = 0
SSMSInstalledLanguage1033 = 1
SSMSInstalledLanguageKeyExists = 1
SSMSInstalledLanguageMatch = 0

I also got the German version on a Swedish machine

I haven't installed SSMS before. But I set $.installBehavior.preferences.locale using winget config.
{"installBehavior": {"preferences": {"locale": ["zh-CN", "zh-TW", "en-US"]}}}

It seems winget.exe will prefer zh-CN > zh-TW > en-US.
pwsh> systeminfo.exe
系统区域设置:     zh-cn;中文(中国)
输入法区域设置:   zh-cn;中文(中国)

pwsh> winget download -e Microsoft.SQLServerManagementStudio
已找到 Microsoft SQL Server Management Studio [Microsoft.SQLServerManagementStudio] 版本 19.2
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责，也不向第三方程序包授予任何许可证。
正在下载 https://go.microsoft.com/fwlink/?linkid=2252307&clcid=0x804
已取消

pwsh> (Invoke-WebRequest -Method HEAD "https://go.microsoft.com/fwlink/?linkid=2252307&clcid=0x804").Headers["x-ms-copy-source"]
https://dmsstager3tx7y9x22.blob.core.windows.net/626e40a7-449e-418d-9726-33b523a1e336/ssms-setup-chs.exe?sv=2019-02-02&sr=b&se=2023-11-16T21%3A18%3A52Z&sp=r&api-version=2019-02-02

If I add ja-JP before zh-CN, then winget.exe will prefer ja-JP > zh-CN regardless of my system locale.
pwsh> winget download -e Microsoft.SQLServerManagementStudio
已找到 Microsoft SQL Server Management Studio [Microsoft.SQLServerManagementStudio] 版本 19.2
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责，也不向第三方程序包授予任何许可证。
正在下载 https://go.microsoft.com/fwlink/?linkid=2252307&clcid=0x411
已取消

pwsh> (Invoke-WebRequest -Method HEAD "https://go.microsoft.com/fwlink/?linkid=2252307&clcid=0x411").Headers["x-ms-copy-source"]
https://dmsstager3tx7y9x22.blob.core.windows.net/626e40a7-449e-418d-9726-33b523a1e336/ssms-setup-jpn.exe?sv=2019-02-02&sr=b&se=2023-11-16T21%3A17%3A30Z&sp=r&api-version=2019-02-02

For users who didn't configure, winget.exe will always use system locale as default.

winget.exe supports --locale switch for manually download and upgrade packages for another locale. Try using it as a walkaround.
For users who prefer a different locale than system default for ALL packages, try manually set $.installBehavior.preferences.locale with winget config.

On my machine it also installs German locale version while my PC is Polish. The currently installed locale for SSMS is English.

winget install --id Microsoft.SQLServerManagementStudio  --locale en-US  --> for me, this is the solution.


Support for more TYPES of peripherals?

Is there planned support to add things such as RGB mousepads, GPUs, RAM, MoBos, Headsets, etc to make this an all in one solution?

See #358 #599 #546


client: Stats of failed object GET/RANGE/SEARCH are submitted only on Close

currently, server-streamed ops call stat handler only when user calls Close. But for such ops Close is only used when user is no longer interested in the stream. Unlike PUT when user signals that data is finished via Close. For example, following code looks completely OK:
r, err := c.ObjectSearchInit(ctx, anyCID, anyValidSigner, anyValidOpts)
for err == nil {
	_, err = r.Read([]oid.ID{{}})
}
return err // io.EOF or failure

Current Behavior
-stats
Expected Behavior
+stats
Possible Solution
do not require calling Close. Submit stats whenever stream is finished (io.EOF==OK!). Update docs
Steps to Reproduce

see exec statistics cases from #641

Regression
quite possible, but i havent checked
Your Environment

Version of the product used: 335d9fe90f24494944c2888ef385f06f5f81dcfc

@roman-khimov i meant this in terms of stats. We can submit real stats when stream is done and Read() returns an error regardless of closing. This is what i actually propose. I just noticed Failure reason can be received via Close. in docs, and this is not quire true. After Read() returns an error, Close() is no-op and returns the same
overall, i agree that closer is nice thing todo. For reading ops, it should be performed deferly. According to gRPC server-side stream semantics, currently it is always no-op except user interrupts reading when data is no longer needed

We can do a lot of things, the question is should we? To me it works fine already wrt statistics. Users must Close() and that's where you get your overall statistics.

Users must Close()

the imposition is excessive, the stream works differently. UX improvement is desirable imo. Being a user, i'd be grateful for the stats that came even if I forgot closer

I doubt anyone cares much about streams that drive all of this. But people know https://pkg.go.dev/os#File, they know https://pkg.go.dev/io#ReadCloser, not calling Close() for os.File is an error, for io.ReadCloser the general expectation is the same.

Body in https://pkg.go.dev/net/http#Response is the same, btw. It is an error not to Close() it.

I doubt anyone cares much about streams that drive all of this. But people know https://pkg.go.dev/os#File, they know https://pkg.go.dev/io#ReadCloser, not calling Close() for os.File is an error, for io.ReadCloser the general expectation is the same.

interface itself states no such requirements. 'Specific implementations may document their own behavior' and that's it
op stats and resource release in different planes to me. Exactly like successful reading 1GB data from file and forgotten descriptor


ref(store): Remove unused RPC Client

The store does not use the RPC client at all.  Remove it.
yolo, let's see what breaks
CI doens't break!  It must be good.  Teach me why not :)

The store does not use the RPC client at all. Remove it.
yolo, let's see what breaks
CI doens't break! It must be good. Teach me why not :)

Is this used on the CLI to get status or whatever from the service? Ie the outside API?
Maybe I just have no clue what I'm talking about though...

The store does not use the RPC client at all. Remove it.
yolo, let's see what breaks
CI doens't break! It must be good. Teach me why not :)

Is this used on the CLI to get status or whatever from the service? Ie the outside API? Maybe I just have no clue what I'm talking about though...

I don't think so, that's done by the rpc server which is still started.

It was done only in preparation, as the store will need this eventually, to make sure that the architecture is not built such that it assumes the store doesn't need the rpc client.

It was done only in preparation, as the store will need this eventually, to make sure that the architecture is not built such that it assumes the store doesn't need the rpc client.

So can I convince people this doesn't buy us anything?  We have plenty of examples to build the RpcClient.  A client that's unused in a struct doesn't make us do anything we shouldn't: it is Send and Sync anyway and since it's unused it does not get passed around anywhere.  Once there's a use for it I don't think there's going to be any major hurdle to add it.
Personally I find it difficult to reason about things when the types don't match what's unused. The type system should help show what goes where.

So can I convince people this doesn't buy us anything?

you can, fine to remove for now imo


API — WebMentions

A WebMentions API needs to be created and set to both send and receive requests. Requests to other 10Cv5 sites should allow for "push" via POST.

Hmm ... this was implemented a year ago, then disabled because there weren't any WebMentions reaching any 10C site for 8+ months. Now it's re-enabled as there is one person on the Internet that seems to use them and point at 10C from time to time.
Closing Ticket.


Remove IE11 vendor polyfills

Partially addresses #2506

A few thoughts:
Intl API
There's some mentions of IE11 in the i18n's check for Plural Rules and Number Format support.
Can we simplify these checks to just look for .supportedLocalesOf and assume we're good on Intl and PluralRules/NumberFormat? Or do we need to keep these checks as is? @querkmachine - you probably have thoughts?
Bits and bobs
There's a coupla things that come up when searching for "IE" (stuff like IE rendering in the template, potentially some html-validate rules, some specific fixes for components, etc.
Not sure we have anywhere to start logging these things to tackle as we go about the work of updating things?

@colinrotherham I've updated polyfilling documentation and linked to #3722

@colinrotherham I've updated polyfilling documentation and linked to #3722

Nice, thanks @domoscargin. Keeps the git blame history going


Allow multiple plugins to be specified

PLUGIN_DIR only accepts a single directory, so if we were to have multiple plugins, we could only choose to use 1 at a time. We could either just split on comma, have the variable accept a JSON array, or change it to a flag that can be specified multiple times (e.g. --plugin /path/to/plugin1 --plugin /path/to/plugin2)

fwiw PLUGIN_DIR was actually just for development, the original plan was that plugins would be in the plugins directory inside th code-server directory. So we could have a flag that sets that directory, or extract plugins to that directory when downloading everything without setting any variables.

It should def be made configurable, not just hardcoded to plugins like it currently is.


Skiplink colour contrast

Skiplink has the default link colour, which kept failing against $focus-colour
background. Making the link colour $black for :focus and :visited states.

So this is a problem for all links when focused. This seems like it could be fixed globally?

@nickcolley for the skiplink, the text is already on a black background, so having it be black works well. I don't know if the same solution would work for the other cases.

@nickcolley @edwardhorsford: Just had a chat with @accessiblewebuk - he says for ordinary links, he wouldn't fail them for colour contrast if the contrast is only low on focus states, but it's true that the focus states don't have high enough contrast.
Would that be more sensible to add this to a:focus rather than just the skiplink? So the links would be $text-colour when focused.


fix nan mask in multicategorical

Fixes #301
Will create a separate pr to improve the efficiency and remove implicit nans.

Thanks! Two requests on my side

Can we support the bare minimum in this PR: fillna_col for multi tensor, which is actually used.
Also, remove eq of TensorData since it's largely duplicated with that of TensorFrame

@weihua916 Hi. I removed fillna_ and eq of TensorData

Looks great!


Fix the package warnings for guzzle/http

guzzle/http is abandoned and gives you following warnings when running composer install/update.
Package guzzle/common is abandoned, you should avoid using it. Use guzzle/guzzle instead. Package guzzle/stream is abandoned, you should avoid using it. Use guzzle/guzzle instead. Package guzzle/parser is abandoned, you should avoid using it. Use guzzle/guzzle instead. Package guzzle/http is abandoned, you should avoid using it. Use guzzle/guzzle instead.
This pull request simply replaces guzzle/http with guzzle/guzzle in the composer.json file.

See this comment

Woops missed that one. Thanks for pointing this out!


Adapter to work with DB, pgx/v3 adapter implemented

Codecov Report

Merging #8 into master will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   80.73%   81.01%   +0.27%
==========================================
  Files           4        4
  Lines         244      237       -7
==========================================
- Hits          197      192       -5
+ Misses         34       33       -1
+ Partials       13       12       -1

Impacted Files
Coverage Δ

que.go
85.10% <100.00%> (+0.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaee8e6...168ac46. Read the comment docs.


How do you set the options?

README says you can set some options like path, but i don't get how do you add these to the serverless.yaml file

Create section in your severless.yml file and call this custom, it should be a base level section (0 indent), then user the example from the ReadMe and you should be able to invoke the variables you have set.
custom:
  dotenv:
    path:  ./.env
    basePath:  ./

place that in you serverless.yml and then you .env should be in the same directory or change the path to where it should be.
Hope that helps


Use logical rather than boolean operators in comparators

The || and && operators have shortcutting behaviour. This is good when we need to test for unsafe behaviour, but otherwise these introduce conditional jumps statements which modern CPUs do not work well with. On the other hand, the logical operators | and & have no shortcutting behaviour; hence they use no jumps and use half the number of instructions (see here for some more discussion on the subject).
In C++ any bool value is either 0 or 1 (and nothing else). This also includes the result of == and < etc which can be done in a single instruction each. That means in many places we can use the logical operators | and & instead and not change the computation result! Yet, this is not a very common thing to do, so every time we do so, we need to add a little comment with an explanatory warning.
We only want to do it in the following places:

[ ] Our comparators run a linearithmic number of times with a small likelihood they are predictable.
[ ] Our predicates in internal/data.cpp on binary operators (e.g. is_left_shortcutting).

If #162 is not yet done, then one may also do the same for the many predicates in adiar/data.h

@AnnaBlume99 Based on our discussion and the improvements above, I hope you have a better second attempt at this? :)

Our initial experiments in #271 make it seem like a bad idea.


Record feature implementation

Record

Record & stop buttons
Capture Canvas scene either by using third-party library such as threecap or by using Media Library
Popup + Image preview + Download button

Auto-rotate

Play button + action (auto-rotate)
Button to trigger play for all viewers

https://github.com/spite/ccapture.js/ looks interesting.
threecap requires recording time beforehand and that's a negative point.
More notes:
https://stackoverflow.com/questions/50681683/how-to-save-canvas-animation-as-gif-or-webm


could not load the saved OAuth2 credentials

Description
Action fails to run because it can't load the credentials:
Warning: could not load the saved OAuth2 credentials.
Obtaining new credentials...
Pub needs your authorization to upload packages on your behalf.

I'm running this workflow:
jobs:
  build:
    uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_pub_publish.yml@v1
    with:
      pub_credentials: secrets.PUB_CREDENTIALS

in PUB_CREDENTIALS y copy & pasted the contents of pub-credentials.json
https://workflows.vgv.dev/docs/workflows/flutter_pub_publish#example-usage

+1

Also using ${{ secrets.PUB_CREDENTIALS }} doesn't work.

Pinging you here @wolfenrain

It needs base64 support on credentials to make it work:
name: Publish to pub.dev

on:
  push:
    tags:
      - "v[0-9]+.[0-9]+.[0-9]+"

jobs:
  publish:
    defaults:
      run:
        working-directory: "."

    runs-on: ubuntu-latest
    timeout-minutes: 5

    strategy:
      matrix:
        flutter-version: [3.10.x]
        flutter-channel: [stable]

    steps:
      - name: 📚 Git Checkout
        uses: actions/checkout@v4

      - name: 🐦 Setup Flutter
        uses: subosito/flutter-action@v2
        with:
          flutter-version: ${{ matrix.flutter-version }}
          channel: ${{ matrix.flutter-channel }}
          cache: true

      - name: 📦 Install Dependencies
        run: flutter pub get

      - name: 🔐 Setup Pub Credentials
        run: |
          mkdir -p $XDG_CONFIG_HOME/dart
          echo '${{secrets.PUB_CREDENTIALS}}' | base64 --decode > "$XDG_CONFIG_HOME/dart/pub-credentials.json"

      - name: 🌵 Dry Run
        run: flutter pub publish --dry-run

      - name: 📢 Publish
        run: flutter pub publish -f

Thanks @KeidsID for the info here. Seems like this is something we can add into the documentation to make sure others don't fall into this.
Adding the Documentation tag here as that seems like the right change here.

I don't think that is the right way to tackle this. You need to properly use secrets over inputs, that will fix all the issues. No workarounds needed.


style(lint): lint and format all code

Run all code through updated eslint/prettier setup
Follow on from https://github.com/LN-Zap/zap-desktop/pull/440

Note: The travis build will fail as the code is reformatted to the updated rules from https://github.com/LN-Zap/zap-desktop/pull/440. That needs to be committed first.


Version of Boost required needs to be part of docs and preferably installation

Scenario:

locally-built version of EOSIO.CDT created, including its embedded Boost 1.71.0 artifacts
brew install boost now picks up Boost 1.74.0
linking upstream executable file that uses EOSIO.CDT libfc.a results in link errors vs Boost.Filesystem due to major changes since 1.71.0

Suggestion - EOSIO.CDT should at least document the required version of Boost, and preferably provide a means to reliably install it if brew no longer supports. I had to create a custom boost.rb file from Github history using 1.71.0 plus an XCode patch out of 1.72.0 boost.rb to get round the link errors.

Are you able to reproduce this issue? What branch of eos and eosio.cdt are you working with?


Refactor: update imports usage with aliases

This PR aims to implement the alias imports usage  in this discussion.

Codecov Report

Merging #580 (9e91ca7) into main (ebb2e3f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   96.73%   96.73%
=======================================
  Files          74       74
  Lines         950      950
  Branches      146      146
=======================================
  Hits          919      919
  Misses         29       29
  Partials        2        2

Impacted Files
Coverage Δ

src/domain/faucet/store/reducer/faucet.reducer.ts
100.00% <ø> (ø)

src/utils.ts
97.67% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Particles AABB is broken

Godot version: 3 stable
Issue description:
Moving Particles AABB or changing the size does not work as it used to, before stable.

The grid representing the AABB on the editor is also broken.
Steps to reproduce:
Try to move and resize the particles AABB.

The visual representation of visibility AABB should be fixed in #16358.


Website Spelling

Describe the bug
I like the new website, just noticed a spelling error:

It looks like the current website source isn't on github anywhere (I couldn't find the source text, just old assets it seems) so I'm filing the bug here. Maybe I just missed it.

Website sources are available here: https://github.com/AvaloniaUI/avaloniaui.net.
Feel free to open a PR :)

Ah, I did look there but not in enough detail. I only saw all the assets but didn't see the source code. The issue is here:
https://github.com/AvaloniaUI/avaloniaui.net/blob/800d70843826f24e62145aa1561f00f514ebfa58/index.html#L308
I don't plan on making a PR for this. Sorry!


Turn on make distcheck in CI

Currently the CI is not doing a make distcheck, but it should.

@WardF I suggest this be fixed before release...

This is now happening in the CI.


Monitor Item Duplicate Checker

Is it a duplicate question?
Not in sight.
Is your feature request related to a problem? Please describe.
After adding the JSON import/export function. It becomes an issue.
Describe the solution you'd like
Add function to check if the monitor exists. Warn the user that the monitor is already created.
At JSON import/export, let the user to choose to keep or discard all the existing monitors.
Also, checks duplicated monitors when importing JSON config.

Thanks, i gonna try to make a PR about it this weekend.

Resolved by https://github.com/louislam/uptime-kuma/pull/382?

Resolved by #382?

Somewhat, but checking for duplicate named monitors, or monitors with the same endpoints would also be nice during creation/as a button from settings.


Better dark theme scroll bars

Adds more aesthetically pleasing scroll bars to fit the dark theme

Cool! In which browsers does this work?

https://caniuse.com/#feat=css-scrollbar

Are you guys on Windows? Could you send screenshots showing it working on different browsers?

Firefox

Chrome

The only other browser I have is Edge, which is just chromium now

Firefox 78.0.1 on Ubuntu 18.4

Chrome on Ubuntu 18.4

Chrome and any other webkit based browser should support ::-webkit prefixed styling. Firefox already supports the new standard. A complete example covering both is here.

Can you guys test this and give your feedback? If possible, please test in Firefox also.
.red-ui-editor {
  scrollbar-color: #999 #2E333A;
}

::-webkit-scrollbar {
  width: 1em;
}

::-webkit-scrollbar-corner {
  background-color: #2E333A;
}

::-webkit-scrollbar-thumb {
  background-color: #999;
}

::-webkit-scrollbar-track {
  background-color: #2E333A;
}

Thank you, @Villhellm


Feature request: Localizations

I'm thinking about adding French and German localizations to gSwitch. Would it be possible for you to already add the necessary additional (untranslated) Interface ressources to the development branch, so that (pull request) contributors would only need to replace the strings? - Thank you.

Yes I will set that up soon.


Bar component requires chart property but it still works fine without it.

Bar component requires chart property

The chart works even with this error.
But I don't like having red squiggly lines in my code, how should I clean this error?
I tried putting in the chart property, but I don't know what should be inside the chart property.

After reading the source code, it seems chart can be null, but it's still giving me the error

Does anyone have any suggestion? Maybe making the chart property optional is a good idea?

@topazrn Hi. Please try v2.1.1

Beautiful!


Fix bug where multiple keychain entries would result in user persistence failure

Fixes #5906.

Is there a way to delete the duplicate users from the keychain? (I'm still new to iOS so don't know exactly how the keychain works)

One auth session will be discarded. Based on my understanding of the code, the two auth sessions are actually the same user, one from the legacy keychain service (with no service specified) and one from the up-to-date keychain service.
The right thing to do is probably to delete the legacy entry if we encounter both a legacy and non-legacy keychain entry.

I've modified the code to always return the non-legacy item if it exists. The way keychain deletions work, I'm not sure it's practical to delete the old keychain value without making significant modifications to the class.
Given the relatively limited impact of the bug I'm ok with not removing the legacy entry in this method.

Fix CI , then LGTM


ARC-2290 new jira client

What's in this PR?
Created a new JiraClient class and merged all the requests from the other two JiraClients - this is not the final product... but it brings everything to one and we can enhance from here.
Why
We have wanted to do it for a while, the existing JiraClients are in two seperate directories and needs to be tidied up converted to a more developer friendly format... and Typed, being two seperate clients wasn't an issue as they do serve slighty different functions one being Jira requests for GitHub installation data the other more  general Jira requests eg getCloudId......
also, I need to introduce a new TCS(tenantContextService) sidecar to run a Axios interceptor before trying to update suspended Jira accounts, so now was the time.
Added feature flags
Not required for this change, no code is being used in Production, next steps will start consuming with FFs.
Affected issues
Jira Issues
How has this been tested?
Include how to test if applicable
Whats Next?
Tests for the requests, there is a nbunch there that are fine, but a lot are missing, this is intentional as the PR was already too big. next PR will be just tests.
Also have a few helper functions i will pull out and import back in.
Will start consuming one endpoint at a time, behind feature flags, expect many small PRs
As mentioned in the WHY , they did originally serve slightly different purposes, we will likely split up this new client into smaller classes much like GHClients.

Sigh, moving to https://github.com/atlassian/github-for-jira/pull/2465


[FEATURE REQUEST] does autotrain support multiple GPUs?

Feature Request
I wanted to run a model with 65k block size on A100 with 80GB, and ran out of memory:
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 31.48 GiB. GPU 0 has a total capacty of 79.18 GiB of which 8.86 GiB is free. Process 142839 has 70.33 GiB memory in use. Of the allocated memory 69.14 GiB is allocated by PyTorch, and 158.49 MiB is reserved by PyTorch but unallocated.
Since I was missing 31GB, I thought maybe adding the second GPU would help. But no, I get the same message basically:
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 31.48 GiB. GPU 0 has a total capacty of 79.18 GiB of which 8.53 GiB is free. Process 100838 has 70.65 GiB memory in use. Of the allocated memory 69.17 GiB is allocated by PyTorch, and 389.00 MiB is reserved by PyTorch but unallocated.
Using two GPUs resulted in some messages being doubled like this:
The model was loaded with use_flash_attention_2=True, which is deprecated and may be removed in a future release. Please use `attn_implementation="flash_attention_2"` instead.
The model was loaded with use_flash_attention_2=True, which is deprecated and may be removed in a future release. Please use `attn_implementation="flash_attention_2"` instead.

It looks like autotrain doesn't use the additional GPU. Does it support multiple GPUs? If so, how to activate this feature?
Motivation
Out of memory on a single GPU.
Additional Context
No response

@mrticker could you show the code to execute this?
autotrain llm

you need to manually enable cuda devices

@mrticker any updates to this?

@abhishekkrthakur , the multi-GPU from autotrain-advanced doesn't seem to work. could you please advise?
setting this in my job script:
export CUDA_VISIBLE_DEVICES=0,1

does not seem to split the load into 2 gpus. It seems like it is simply running twice, because my error logs shows the error twice.
For example,
0%|          | 0/48 [00:30<?, ?it/s

will appear twice too.
Could you kindly check on this? Am I missing some config or something?

its out of the box. did you manually change accelerate config?

could you kindly let me know how exactly do I do that? This is not written anywhere in the documentation for autotrain-advanced, and is unclear in how I should execute 2 GPUs via autotrain-advanced.
After setting up accelerate config, do I still use export CUDA_VISIBLE_DEVICES=0,1? Do I have to use accelerate launch? How do I even set all these up in a job script, because I am not using local GPUs, and running these through a HPC.

i think there's been a misunderstanding.

could you kindly let me know how exactly do I do that? This is not written anywhere in the documentation for autotrain-advanced, and is unclear in how I should execute 2 GPUs via autotrain-advanced.

you DO NOT need to do anything to make autotrain run on multiple gpus. it runs on multiple gpus by default. see the commands here.
in case you are manually doing accelerate config, you can, but again, you dont need to use accelerate launch command, you can just use the same old autotrain command.
in multi-gpu mode (default mode), some logs may appear N times (N = number of gpus) and that is perfectly normal. if you feel like its not using multiple gpus, please provide more context.

if you feel like its not using multiple gpus, please provide more context.

As I have mentioned in the first message, the out of memory errors are basically identical whether I use one GPU or two.
To confirm it, I have established what block size I can fit on one GPU, increased it slightly (by 2K tokens) and ran autotrain on two GPUs. It ran out of memory exactly as with that slightly increased block size on one GPU.
TLDR:
can run X block size on one GPU
OOM when running X + 2k on one GPU
OOM when running X + 2k on two GPUs
conclusion: autotrain does not use the second GPU

could you run 'accelerate config' answer the questions and then run the autotrain command and see if that fixes your issue?

TLDR:
can run X block size on one GPU
OOM when running X + 2k on one GPU
OOM when running X + 2k on two GPUs
conclusion: autotrain does not use the second GPU

unfortunately, dont agree with this. multiple gpus work this way:

can run X block size on one GPU with bs
can run X block size on two GPU with larger bs

or

can run 7b model on one gpu
can run 13b model on multiple gpus

we have been constantly testing multiple gpus with autotrain and it has always worked fine. what kind of gpus do you have?

also adding, im able to finetune mixtal 8x7b model on 8xA100 using autotrain which is never possible without using multiple gpus :)

I assume you simply use
export CUDA_VISIBLE_DEVICES=0,1,2,3,4....

at the start of ur job script?

Ser in my case in one instance i have 5 A100 40 Gpus available , could you help me how could I use all the 5 GPUs
pip install -U autotrain-advanced
autotrain setup --update-torch
autotrain dreambooth
--model stabilityai/stable-diffusion-xl-base-1.0
--project-name dog
--image-path images/
--prompt "photo of sks dog"
--resolution 1024
--batch-size 3
--num-steps 500
--fp16
--gradient-accumulation 4
--lr 1e-4
I was just using like this getting cuda out of memory , its using only 1st GPU which is at index 0 .
Thank you


feat: add github issues link to regex

What type of PR is this? (check all applicable)

[ ] ♻ Refactor
[x] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 📝 Documentation Update
[ ] 🔖 Release
[ ] 🚩 Other

Description

This PR add the extra regex to detect the issues link in the body.
Related Tickets & Documents

Closes https://github.com/mtfoley/pr-compliance-action/issues/384
Mobile & Desktop Screenshots/Recordings

Added tests?

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[x] 📜 readme
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Side note: when I opened the PR felt that's really similar to open sauced, then noticed you are one of the contributors there :)

Yeah, great project 🤩

Thank you for the suggestions! Just solved it and all tests passed 👍

Thank you for accepting it!


Barchart innerline over exceeding the Y-axis

Hi, i want to have my bar chart look like this

But in my implementation down below, when i set innerline to true, the line exceeding the Y-axis. Anyone know how to solve this? Thankyou.

youc an try:
yLabelsOffset={0}

Same issue here. Please help?

Also having an issue where this occurs, causing my barchart to look like this with the lines removed. Looks like something is to the left of the chart?

Code for my issue is here:
<BarChart           data={{             labels: ['1', '2', '3', '4', '5', '6', '7'],             datasets: [               {                 data: [                   spread[1],                   spread[2],                   spread[3],                   spread[4],                   spread[5],                   spread[6],                   spread[7],                 ],               },             ],           }}           width={270}           height={220}           yAxisLabel=""           yAxisSuffix=""           chartConfig={{                 backgroundColor: colors.lighter,               backgroundGradientFrom: colors.lighter,               backgroundGradientTo: colors.lighter,               color: () => colors.darkestBlue,               strokeWidth: 1,               decimalPlaces: 0,           }}           fromZero={true}           withInnerLines={false}           showBarTops={false}           withHorizontalLabels={false}           withVerticalLabels={true}           showValuesOnTopOfBars={true}           style={{             padding: 0,             margin: 0,             borderWidth: 1,             borderRadius: spacing.borderRadius,           }}         />

This is only a dirty hack, but you can move the inner lines on the right with the following props in ChartConfig:
propsForBackgroundLines: {
   translateX: <width of the longest y axis label>
}

it works! svg line
propsForBackgroundLines: {
x1:
}
detail:
Line
The element is an SVG basic shape, used to create a line connecting two points.

Rect
Code explanation:
The x1 prop defines the start of the line on the x-axis.
The y1 prop defines the start of the line on the y-axis.
The x2 prop defines the end of the line on the x-axis.
The y2 prop defines the end of the line on the y-axis.

Seen the same issue. Used fix above which worked, but having this fixed would be better.

@oldben87 You can remove that right side padding by
style={{
     paddingRight: 0,
 }}


SyntaxError

When trying to run the command
./train.sh Breakout-v0 --environment gym
i get   agent.py", line 69
if reward <> 0:
^
SyntaxError: invalid syntax
any help would be appreciated

I'm unable to reproduce this. Are you sure you didn't change agent.py in any way?


Update dependency polished to v2

This Pull Request updates dependency polished (source) from ^1.9.2 to ^2.0.0

Release Notes
v2.0.0
Compare Source
This is a major release that introduces new modules, improvements to existing modules, bug fixes, improved TypeScript and Flow Support, and some deprecations.
Breaking Changes
We introduced one necessary breaking change in this release. In the future, we will warn a full major version ahead of time, but this one necessitated an immediate fix. (Un)luckily, it was never working properly in the first place.

mix color module now requires a ratio in order to work. It originally tried to default to .5 but this broke in most cases.

Deprecations
These items have been marked for deprecation in v3 of polished.

placeholder mixin is no longer required to address gaps in vendor prefixing in major CSS-in-JS libraries.
selection mixin is no longer required to address gaps in vendor prefixing in major CSS-in-JS libraries.

These items have been deprecated immediately as the change doesn't introduce any breaking changes. However, you will want to update your code accordingly.

normalize no longer accepts excludeOpinionated as a parameter, as opinionated rules have been removed in the latest versions of normalize.css.

New Modules
This release addresses our most popular feature requests as voted on by users. If something you were hoping for didn't make it, you can make your voice heard by 👍a module request in our issues.
Mixins

between mixin added to return a CSS calc formula for linear interpolation of a property between two values.
cover mixin added to return CSS to fully cover an area similar to background-image: cover.
fluidRange mixin added to returns a set of media queries that resizes a property (or set of properties) between a provided fromSize and toSize linearly.

Shorthands

border shorthand added to return shorthand for the border property that splits out individual properties for use with tools like Fela and Styletron.

Helpers

getValueAndUnit helper added returns a given CSS value and its unit as elements of an array.

New Features
We have made a variety of improvements to existing modules as well.
Mixins

fontFace now supports font-display, font-variation-settings, and font-feature-settings.
triangle now supports any unit of measure instead of just px. (Thanks @lifeiscontent)
normalize has been upgraded to use normalize.css 8.0.

Color Modules

All color modules now support hex color values with alpha values (commonly referred to as 8-Digit hex colors).
All color modules now support string values for all parameters.
mix fixed an issue where mix would not curry properly.

Shorthands

transitions now supports applying the same transition to multiple properties in one call.

Bug Fixes
Mixins

ellipsis - fixed a bug to avoid potential white-space issues with display: inline-block.
normalize - fixed an issue where vendor prefixed values were not properly camel-cased.
retinaImage- fixed a bug that was causing background-image to be set to undefined (instead of not set at all) when a background image is not passed.

Flow

mix now properly passes flow tests in all cases, including when curried.
All Modules now uses the Styles type for better compatibility with CSS-In-JS libraries and their Flow type definitions. (Thanks @vhfmag)
All Modules - fixed various issues with typings including improperly declared optional parameters, too loose array definitions, and inadequate object property strictness.
All custom types are now exported separately for use elsewhere instead of being embedded with specific modules.

TypeScript (Thanks @ForbesLindesay)

TypeScript build now works properly in Windows
Added additional TypeScript tests for all modules.
TypeScript definitions properly generate regardless of module export policy.
All Modules now uses the Styles type for better compatibility with CSS-In-JS libraries and their TypeScript definitions. (Thanks @vhfmag)

Documentation

Docs have been upgraded to the latest version of documentation.js and generation should no longer randomly break for contributors.
triangle documentation now properly displays.
toColorString documentation now properly displays.
Variety of clarifications and typo fixes.

This PR has been generated by Renovate Bot.

Not used, cleared in #323


Catch version spec failures in Python detection

When an invalid version specification is returned from PyPi (i.e. Requires-Dist: c (>dev)) the current implementation of Python resolvers both throw the exception all the way out, leading to a complete failure of Python graph creation. In this case we should log the warning and continue executing to get as many dependencies as possible.

Let's bump Pip detectors version Id, since we are picking up dependency graphs we didn't use to

Codecov Report
Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (349ef7a) 75.3% compared to head (f86b9dc) 75.3%.

Files
Patch %
Lines

...ComponentDetection.Detectors/pip/PythonResolver.cs
68.5%
7 Missing and 4 partials :warning:

...entDetection.Detectors/pip/SimplePythonResolver.cs
83.3%
5 Missing and 2 partials :warning:

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1006   +/-   ##
=====================================
  Coverage   75.3%   75.3%
=====================================
  Files        236     236
  Lines      10339   10353   +14
  Branches    1025    1025
=====================================
+ Hits        7786    7800   +14
  Misses      2269    2269
  Partials     284     284

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updates links in README.md to show updated content

Linked Issue:

Checklist:

[x] Did you sign the Contributor License Agreement?
[x] Did you update the documentation?

Codecov Report

Merging #92 (83ae9c0) into main (562cd51) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   94.70%   94.70%
=======================================
  Files          62       62
  Lines        1606     1606
=======================================
  Hits         1521     1521
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da6d679...83ae9c0. Read the comment docs.


WAL-E fails when pipe-user-pages-soft is set..

Hey we just ran into this issue -- I havn't had enough time to dig into it in depth, but I wanted to check if it was a known issue. We were pulling down a copy of the database when suddenly we started getting an uncontrollable stream of these errors:
        STRUCTURED: time=2016-08-17T23:45:32.746015-00 pid=8793
wal_e.worker.s3.s3_worker INFO     MSG: beginning partition download
        DETAIL: The partition being downloaded is part_00000031.tar.lzo.
        HINT: The absolute S3 key is staging-wal-logs/staging-eu1/atlas/basebackups_005/base_00000002000000DA00000069_00000040/tar_partitions/part_00000031.tar.lzo.
        STRUCTURED: time=2016-08-17T23:45:32.746437-00 pid=8793
lzop: Inappropriate ioctl for device: <stdin>
wal_e.retries WARNING  MSG: retrying after encountering exception
        DETAIL: Exception information dump:
        Traceback (most recent call last):
          File "/usr/local/lib/python2.7/dist-packages/wal_e/retries.py", line 62, in shim
            return f(*args, **kwargs)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/worker/s3/s3_worker.py", line 78, in fetch_partition
            TarPartition.tarfile_extract(pl.stdout, self.local_root)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/tar_partition.py", line 278, in tarfile_extract
            cat_extract(tar, member, relpath)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/tar_partition.py", line 215, in cat_extract
            with pipeline.get_cat_pipeline(pipeline.PIPE, dest.f) as pl:
          File "/usr/local/lib/python2.7/dist-packages/wal_e/pipeline.py", line 92, in __enter__
            self.stdin = pipebuf.NonBlockBufferedWriter(stdin)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/pipebuf.py", line 225, in __init__
            _setup_fd(self._fd)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/pipebuf.py", line 62, in _setup_fd
            set_buf_size(fd)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/pipebuf.py", line 53, in set_buf_size
            fcntl.fcntl(fd, fcntl.F_SETPIPE_SZ, OS_PIPE_SZ)
        IOError: [Errno 1] Operation not permitted

        HINT: A better error message should be written to handle this exception.  Please report this output and, if possible, the situation under which it arises.
        STRUCTURED: time=2016-08-17T23:45:34.534462-00 pid=8793
lzop: Inappropriate ioctl for device: <stdin>
lzop: Inappropriate ioctl for device: <stdin>
wal_e.worker.s3.s3_worker INFO     MSG: beginning partition download

We are pretty sure this is Apparmor related.. thoughts?

I should add that this was with wal-e 0.8.1. I'll try a newer version of wal-e later tonight

So I've tried with both 0.9.x and 0.8x releases of Wal-E and I run into the same issue. I've tried on both the 3.13 and 4.4 kernels as well. I am trying now to boot a host without apparmor installed at all just to 100% confirm that its an apparmor issue.

I've updated the title now that I have tracked down the bug. Wal-e writes out a ton of data to big large pipes. The linux kernel recently limited the default size of these pipes: https://gitlab.com/ebenard/linux-stable/commit/759c01142a5d0f364a462346168a56de28a80f52
echo 0 > /proc/sys/fs/pipe-user-pages-soft fixes the issue.

Heh. I would rather not oblige people to mess with their kernel to make WAL-E work. I did do the large-pipes thing for efficiency reasons, by reducing syscalls.
WAL-E reads /proc/sys/fs/pipe-max-size to figure out how to set the pipe size. Can you perhaps suggest a better algorithm that adaptively works within the user's limit?

FWIW this is still an issue.

As @tmc says, this is still an issue.

WAL-E reads /proc/sys/fs/pipe-max-size to figure out how to set the pipe size.

Specifically, there is no reason to expect the fcntl call to set pipe size to succeed. The /proc/sys/fs/pipe-max-size is the max size you can expect might succeed, but as pointed out by earlier comments, there are a variety of reasons it may fail: per-user and per-process limits may be in effect.

Can you perhaps suggest a better algorithm that adaptively works within the user's limit?

A simple algorithm would be to try the max size, and repeatedly divide by two until it succeeds. An even simpler thing is to just catch the failure and log a warning with the actual pipe size saying performance might be poor.
I'm pretty sure we all agree that having no backups running because an optimization couldn't be applied is not the right situation. This bit us: an earlier failed base backup left a running wal-e process doing nothing, but still holding onto the some large pipes. I believe this made the per-user pipe pages limit kick in, and so the scheduled base backup kept failing because of the fcntl raised EPERM.
@fdr if you have a preference on how to solve this, I would be happy to contribute a fix.

Just to help anyone Googling for the error message (like me):
wal_e.main   ERROR    MSG: could not run one or more external programs WAL-E depends upon
        DETAIL: Could not run the following programs, are they installed? psql
        STRUCTURED: time=2017-07-07T03:00:01.957961-00 pid=25833

I had to edit the Python and add a call to traceback to print the actual exception to find this issue. The error message presented when this happens is quite misleading and led me to lots of people trying to figure out $PATH.

As @tmc says, this is still an issue.

WAL-E reads /proc/sys/fs/pipe-max-size to figure out how to set the pipe size.

Specifically, there is no reason to expect the fcntl call to set pipe size to succeed. The /proc/sys/fs/pipe-max-size is the max size you can expect might succeed, but as pointed out by earlier comments, there are a variety of reasons it may fail: per-user and per-process limits may be in effect.

Can you perhaps suggest a better algorithm that adaptively works within the user's limit?

A simple algorithm would be to try the max size, and repeatedly divide by two until it succeeds. An even simpler thing is to just catch the failure and log a warning with the actual pipe size saying performance might be poor.
I'm pretty sure we all agree that having no backups running because an optimization couldn't be applied is not the right situation. This bit us: an earlier failed base backup left a running wal-e process doing nothing, but still holding onto the some large pipes. I believe this made the per-user pipe pages limit kick in, and so the scheduled base backup kept failing because of the fcntl raised EPERM.
@fdr if you have a preference on how to solve this, I would be happy to contribute a fix.

Sure, that algorithm sounds great. WAL-E is not so much a moving target these days, so you could account for how many pipes WAL-E generates today and rather efficiently figure out how big to make the buffers. Though, really, this puts whoever is committing to WAL-E today on the hook, so my say so doesn't mean much. To be honest, I haven't taken care of WAL-E much since I've had children. I use it, it works great for me, and WAL-G seems to work great for other people and I'd probably work on that in the future; the elimination of memory copies is just the next major step in making things faster and simpler. WAL-E evolved in 2011, when the software landscape was very different.


New profile

After digging the code I found out that the serial profile is hard coded and making a new profile is kinda hard. Can you point me in the right direction?
I want to interface the AVRCP. I found the uuids for the Target and Remote (AVRCPT, AVRCPR) and made a simple AVRCPprofile.js
const EventEmitter = require('events').EventEmitter;
const Profile = require('./Profile');
const RawFdSocket = require('./RawFdSocket');

class AVRCPTProfile extends Profile {

    constructor(bluez, DBusObject, listener) {
        super(bluez, DBusObject);
        this.listener = listener;
    }

    get uuid() {
        return AVRCPTProfile.uuid;
    }

    get path(){
        console.log('PATH:',this.bluez.getDevice(devicePath));
        return this.bluez.getDevice(devicePath);

    }

    NewConnection(devicePath, fd, options, callback) {
        this.bluez.getDevice(devicePath).then((device) => {
            this.listener(device, new RawFdSocket(fd, {
                encoding: 'utf8'
            }));

            callback();
        }).catch((err)=>{
            callback(err);
        })
    }
}

AVRCPTProfile.uuid = "0000110c-0000-1000-8000-00805f9b34fb";

module.exports = AVRCPTProfile;

// #define AVRCP_REMOTE_UUID	"0000110e-0000-1000-8000-00805f9b34fb"
// #define AVRCP_TARGET_UUID	"0000110c-0000-1000-8000-00805f9b34fb"

and using it like this
...

  await device.ConnectProfile(AVRCPProfile).catch((err)=>{
        console.error("Error while connection to device " + address + ": " + err.message);
    });

...

  await bluetooth.registerProfile(AVRCPProfile);

And i get this error code
 UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'path' of undefined
    at Promise (/home/xed/nodeWorkSpace/node_modules/bluez/lib/Bluez.js:162:69)
    at new Promise (<anonymous>)
    at Bluez.registerProfile (/home/xed/nodeWorkSpace/node_modules/bluez/lib/Bluez.js:161:16)
    at bluetooth.init.then (/home/xed/nodeWorkSpace/index.js:33:21)
    at <anonymous>

BlueZ already exposes AVRCP functionality on it's DBus interface. You probably don't need to implement your own profile. I was able to control playback just by calling the respective functions on the interface.
https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/media-api.txt


HMR not being called on Windows

My browser is Chrome, stable version 53.0.2785.116 (Official Build) m (64-bit) as of now.
OS: Windows 10, latest version (there were even updates this night... I hate the new auto-auto-updates D: )
I wanted to try out Phenomic, so I simply followed the setup guide.
went to a new empty folder, ran these in order and did nothing else:
npm i phenomic

./node_modules/.bin/phenomic setup

npm install

npm start

My browser page opened, with a stylized list of links to the docs and some posts that are in the boilerplate, so I thought "cool it works"
But then I started editing content/index.md, and I noticed nothing was output to the terminal, and no change was reflected in my browser — the dev console also didn't budge.
In small words: no HMR hot loading on windows 10 with the default config.
It must be an upstream issue, but still, it's cool to know here too.

Update:
It HMR reloads when my project is not in a path containing any type of brackets, or spaces.
It's a path issue somewhere upstream. Most likely chokidar.

Which page are you seeing the posts? Currently, hmr for markdown content only works on pages that contains 1 markdown posts, not the one with mutiple posts, which is filtered with enhanceCollection

I'm not sure I understand the question, but it was the boilerplate's homepage index.html file, at the root of the content tree. Though its layout contained a list of posts, its markdown content was updated correctly once my path was free of spaces or brackets. Editing the homepage index.js layout updated the page too. Didn't try editing the title of one of the posts from its own file.

I see. I guess this is something we can improve. I use Windows 10 too but I never name a file with spaces or brackets.

I have a folder structure where "categories" (like "development", "movies", "programs"...) are named in brackets to appear before any other folder when I sort by name. Never had problems before dealing with CLI tools, because a lot of gui software manage those by simply using the OS's file system management. Here, there are a lot of string manipulation directly between tools like Chokidar or Path, so it's easy to just not know who does what with there paths.

The PR for #943 resolved the issue. Additionally, there was another solution posted by someone else on that same thread. Hot reloads worked fine for me for all md files after the fix. Please consider applying the fixes from the closed item to address this earlier opened issue.
FWIW, the path I was using had no spaces or special characters.

Can anyone confirm which solution works/is the best?

I'm seeing the same problem. Editing text in index.md gives this error in the console on the second change (the first one works):
(btw love phenomic so far)
[HMR] Cannot check for update (Full reload needed)
handleError @ process-update.js?e13e:115
applyCallback @ process-update.js?e13e:45
hotApply @ phenomic.browser.454c1e3….js:528
cb @ process-update.js?e13e:52
hotUpdateDownloaded @ phenomic.browser.454c1e3….js:312
hotAddUpdateChunk @ phenomic.browser.454c1e3….js:284
webpackHotUpdateCallback @ phenomic.browser.454c1e3….js:5
(anonymous) @ 0.454c1e3….hot-update.js:1
process-update.js?e13e:116 [HMR] TypeError: Cannot read property '__dataUrl' of undefined
    at eval (eval at <anonymous> (http://localhost:3333/phenomic.browser.454c1e338f7ff0ca0dbf.js:2838:2), <anonymous>:19:25)

reload in the function performReload is always false, so a full reload is not performed either. A missing arg somewhere?
function performReload() {
    if (reload) {
      if (options.warn) console.warn("[HMR] Reloading page");
      window.location.reload();
    }
  }

What is your OS?

I ran into the same issue, so I looked into it a bit.  The patch works, but does not address the cause of the problem.  It looks like collection filenames are having their slash directions set incorrectly on windows, which causes the find item test in src/client/hot-md.js to fail.
https://github.com/MoOx/phenomic/blob/master/src/client/hot-md.js#L6

The __filename path seems to be set on https://github.com/MoOx/phenomic/blob/master/src/loader/index.js#L42
One simple solution might be to replace "\" with "/" on the relativePath variable.

@micnigh mind doing a PR?


Update TimerJob for O365 governance site enumeration

Make OfficeDevPnP.Core.Framework.TimerJobsTimerJob.sitesToProcess a
protected property, so that a concrete timer job would have access the
total workload amount.
Use GetAppOnlyAuthenticatedContext method to create site enumeration
client context object for SPO.

Hi @LiyeXu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Eric Xu (MSIT DISCO.)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Hi Eric, will have a look on this PR (probably tomorrow)

Hi Eric,
I'm not merging these changes cause there are alternative means to do what you need:
*/ If the timerjob needs to run using app-only authentication then you can let configure that via the UseAppOnlyAuthentication(ClientId, ClientSecret) method
*/ To add sites to the timer job you can call the AddSite(site) method...if your Job would need to 'override' the sites it gets passed you can use the UpdateAddedSites and ResolveAddedSites to plug in your custom logic
There's more technical documentation about how the timerjob framework works here: https://github.com/OfficeDev/PnP/blob/master/OfficeDevPnP.Core/TimerJob Framework.md. Also feel free to ping me so that we have a chat on this.


Unity don´t receive OSC inputs but it does in OSC Data monitor

I while ago I used the OscJack connecting an Oculus Quest to a laptop and worked perfectly <3. Now I need to do something similar but I can´t get a connection with Unity.
I'm using this repo with Unity 2019.4.24 with the firewall deactivated, also wait several minutes to see if it could connect.
Tested with an Android.

Now I need to do something similar

Could you describe what the "something similar" is? I have no idea what you're trying to do.

Now I need to do something similar

Could you describe what the "something similar" is? I have no idea what you're trying to do.

Sorry for the late response.
I used the OSC jack to sent vector 3 info and some ints. Using Oculus Quest to a PC with a router.
I tried today with this plugin and works fine: https://assetstore.unity.com/packages/tools/input-management/extosc-open-sound-control-72005

I'm closing this issue as assuming that you solved the problem on your side using another plugin. Please feel free to reopen it for further problems.

Same problem here.  1.0.3  Monitor does capture all messages, but sample code don't.


Tinkers Luck not Effecting Ore [1.12.2 1.0.9]

Title, getting only 1 iron chunk from iron ore, 1 copper from copper ore, etc with a luck 3 pickaxe

Have you tried mining multiple blocks of iron ore? The chance of getting multiples is actually a bit low. It all works fine for me with the same versions.


Fixed missing import error

Import time.sleep into emulator.py

So, for some weird reason I missed this and nobody has yet called me out for it. Merged!


Migrate ERC721 Enumerate extension

🧐 Motivation
To be feature partiy with the Cairo 0 version, having a ERC721 Enumerable extension proposition would be interesting.
📝 Details
Here are 2 repo which did an implementation:

https://github.com/carbonable-labs/cairo-erc-721/tree/main/src/extensions/enumerable
https://github.com/Seraph-Labs/Cairo-Contracts/blob/main/seraphlabs/tokens/src/erc721/extensions/enumerable.cairo

Is there any concern to not have done it yet (maybe this issue #207)?
Also are you comfortable to split the current ERC721 implementation between ERC721 and ERC721Metadata?

@Bal7hazar i think the best is to wait for components to streamline this eventual separation.
although not a blocker, another feature that'd help here is supertraits (or similar) to extend a trait with another i.e. extend ERC721 by just defining the metadata-specific fields on top. I think there might be a way of emulating it now though.

@martriay thanks for sharing your thoughts, just to ensure I understand well, do you think it's risky for the community if OZ repo have a pre-component implementation right now and make another other one after the component feature is released (with the risk of changing the signature or storage making the upgrade not possible easily) ?
I understand that you could have other priority, my point is if I (or someone else) make a PR with a proposition right now, would you accept to merge it in the repo? (Assuming it passes the merging process ofc).

@Bal7hazar sorry for the long silence. are you still willing to work on this?

Hey @martriay actually there is already a component version made by Seraph-Labs:
https://github.com/Seraph-Labs/Cairo-Contracts/blob/main/src/tokens/erc721/extensions/enumerable.cairo

Great! That'd be a useful reference. We're still going to add this to our library, it's scheduled roughly for Q1 2024 for us. Anyone interested in tackling it before will be welcomed :)


Add loggers

Adds a logger:

adds a logger parameter to the CLI;
replaces the prints by logger.info, logger.warning or logger.debug commands.

Observed that not all comments are written in the log files. Could you test by your side and tell me if it is the same ?


Convert registry to k8s.gcr.io

This PR was auto-generated.  Please apply human expertise to review for correctness.
Followup to https://github.com/kubernetes/kubernetes/pull/54174
xref https://github.com/kubernetes/release/issues/281
/sig multicluster

/lgtm
/approve


Enhancement request: LocalFileDetector, or a way to send files to a remote server

The RemoteWebDriver has a method setFileDetector(FileDetector detector): "Set the file detector to be used when sending keyboard input." An example of how this works is in this Selenium File Upload example.
My use case is when I have files on a local machine, but they need to be on a remote server (node on Selenium grid) for a test to be executed. It would be awesome to have a way to send files through the JSON wire protocol. My request is for a way to do so - not necessarily using setFileDetector(), since that actually won't work for my purposes. I use Appium, so I need a way to send the compiled app to appropriate node in order for the test to even begin.
Addendum: There seems to be an undocumented endpoint on the server for uploading files? Someone also mentioned it on StackOverflow. File upload is implemented in the Java bindings, but not required. It would be great if it was implemented in the PHP bindings!

anyone who came here from Laravel Dusk

      $file_input = $browser->driver->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('.input-image > input'));
      $file_input->setFileDetector(new \Facebook\WebDriver\Remote\LocalFileDetector());
      $file_input->sendKeys(__DIR__.'/images/logo.png');

Or see page Upload a file in our wiki ;-).


[Transforms]: Incorrect emit of defining class expression with static property inside loop

This is a same issue #8578 but in "transforms" branch
Compiler options: --target es5, --target es6
const arr: {y(): number}[] = [];
for (let i = 0; i < 3; i++) {
    arr.push(class C {
        static x = i;
        static y = () => C.x * 2;
    });
}
arr.forEach(C => console.log(C.y()));

Assuming this is fixed by now


Make Instance property public

Contributes to https://github.com/microsoft/typespec/issues/3813

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.


[BUG] I think there was error in ch3 page 131 line 3rd of the code .You can't take a row like that from DataFrame

Hi @kartikcpp ,
The problem comes from the fact that fetch_openml() used to return a NumPy array, but it now returns a DataFrame. Please call fetch_openml() with as_frame=False as argument to make it return a NumPy array. Everything should work fine after that.
Hope this helps.


Keyboard Arrows Throwing Console Errors When Pressed

Hi,
I am using this library with Bootstrap v5.1.3 and have noticed errors in the console when pressing the arrow keys to access the dropdown menu generated by autocomplete.
Uncaught TypeError: Cannot read properties of undefined (reading 'nextElementSibling')
at Object.next (selector-engine.js:63:24)
at hi._getMenuElement (dropdown.js:270:27)
at new hi (dropdown.js:103:23)
at hi.getOrCreateInstance (base-component.js:55:41)
at HTMLDivElement.dataApiKeydownHandler (dropdown.js:453:31)
at HTMLDocument.n (event-handler.js:119:21)
next @ selector-engine.js:63
_getMenuElement @ dropdown.js:270
hi @ dropdown.js:103
getOrCreateInstance @ base-component.js:55
dataApiKeydownHandler @ dropdown.js:453
n @ event-handler.js:119
However, the tab key works fine.
Tested on Chrome 110.0.5481.178 and Firefox 111.0.1 on Windows 10

Sorry, I didn't realize the add-on for bs5 wasn't developed here. I found your library from this url...
https://www.jqueryscript.net/form/autocomplete-typahead-bootstrap-dropdown.html
and used the bs5 one from that same page above which links here...
https://www.cssscript.com/autocomplete-typeahead-bootstrap-5/

Oh, wow ... I didn't even know it was listed there, and with a documentation written by someone else ... cool!! And I also didn't know someone adapted it to Bootstrap 5, that's even cooler!! But anyway, you should open an issue there, since I don't have any connection with that project.

Thanks for your help. Those sites aren't resolving any recent bugs... and that stinks. Plus, posting or replying to comments seems to not be working. After researching this issue, I can't find any relevant information either. Stumped. Although, I know the error definitely has to do with the bs5 integration... just not sure how to solve it.


Support for displaying old sonde + fixes

New Features

The tracker can now display any individual sonde in the SondeHub database by using the modern APIs if legacy fail
There are now links to the card page for sonde

Fixes

button formatting sonde sidebar
search and time update now always works

Ok this is ready now.


Fix #330

Coverage decreased (-0.009%) to 95.625% when pulling e558401e090c5f2cb0e06a9681f15579374a4e51 on gnodet:fix330 into 5d189e4f8be93019829ef9ca8d0cee067a21ffdf on simoncozens:master.

Once again, very nice, thank you!


Case insensitive sorting?

Is there any way to do case insensitive sorting? Any way at all?
I note Issue 150, but that was in 2014. Any progress?
Just a simple callback on two sort keys would solve the problem.

@david-pfx i just ran into this need as well--i think a sort callback would be a great way to solve this but since i don't think that's going to happen i'm going to solve for my project by denormalizing a document property just for sorting, e.g. saving the toLowerCase() version in a separate property

oh, this is actually the suggestion from #150 as well (creating sort keys)

there is also the compareStrings option to Datastore, but it's global to the Datastore (that may be fine for your use case, though!)

compareStrings (optional): function compareStrings(a, b) compares strings a and b and return -1, 0 or 1. If specified, it overrides default string comparison which is not well adapted to non-US characters in particular accented letters. Native localCompare will most of the time be the right choice

and for completeness' sake, an example:
    compareStrings: (a, b) => {
      return a.toLowerCase().localeCompare(b.toLowerCase());
    },

Yes, that does seem to be the state of play. One of these days I think I'm going to have to fork NeDB, but other things are taking priority right now.

MongoDB doesn't even support this functionality for sorting AFAIK, so I can't see NeDB adding it any time soon.
https://docs.mongodb.com/manual/reference/method/cursor.sort/

NeDB seems to not use compareStrings when comparison operators such as $lt and $gt are used.
Here's an example:
(async function () {
    const db = new Nedb({
      compareStrings: (a, b) => {
        return a.toLowerCase().localeCompare(b.toLowerCase());
      },
    });

    for (const title of ['A1', 'B', 'C', 'a2']) {
      await new Promise(resolve => db.insert({ title }, resolve));
    }

    function find(query) {
      return new Promise(resolve => db.find(query).sort({ title: 1 }).projection({ _id: 0 }).exec((err, res) => resolve(res)));
    }

    console.log(JSON.stringify({
      find: await find({}),
      find2: await find({ title: { $lt: 'a2' } }),
    }, null, 2));
  })();

The outcome is as follows:
{
  "find": [
    {
      "title": "A1"
    },
    {
      "title": "a2"
    },
    {
      "title": "B"
    },
    {
      "title": "C"
    }
  ],
  "find2": [
    {
      "title": "A1"
    },
    {
      "title": "B"
    },
    {
      "title": "C"
    }
  ]
}

If compareStrings worked with comparison operators then find2 would contain only A1. But judging from the outcome we can conclude that the lowercase title goes after the uppercase ones irrespective of the compareStrings option.


Add faster scaling composite hash value encoding for remote path

Description
Description copied from #13155.
This is one of the tasks to achieve https://github.com/opensearch-project/OpenSearch/issues/12589 as part of the feature request https://github.com/opensearch-project/OpenSearch/issues/12567. This is only an increment step to conclude the optimised prefix path work proposed in the feature request.
In this PR, we have introduced a composite encoding for the 64 bits hash value. We use multiple attributes like index uuid, shard id, data category (segment/translog) and data type (data/metadata/lock_files) for generating a 64 bit hash value. Now, based on tests performed during the development, we have found a encoding that works best when the index shard counts or indexing rate increases on a cluster. The encoding uses 1st 6 bits to generate URL safe base 64 character and uses rest of the 14 bits as binary string equivalent. This encoded value as the prefix or infix depending of the path type selected at the cluster level. Currently, we are making this encoding value as default. We have levers in code to set the hash algorithm in index metadata to allow us in future to give a dynamic cluster setting that can be used to set the hash algorithm or the hash value encoding from multiple options.
Simulation steps done using AWS S3 -

Create S3 bucket and upload at very high rate at all possible characters from URL safe base64 charset. This will warm up and increase the overall maximum request rate capacity for the prefix. We see throttling for couple of hours until the throttling stops. Please note at this point we have not started our opensearch cluster.
Now we start our opensearch cluster with the same bucket we use above. We see we are able to support multiple active shards. Now, if we get more indexes (or more shards) created gradually, we are able to scale up S3 request rate capacity faster with binary encoding than the base64 encoding. The time is considerably lower in comparison to base64.

This PR was reverted in #13244 due to breaking change. However, these changes have not been released in any version yet. In comparison to the previous PR, we are adding ExperimentalApi annotations to these breaking changes.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
~[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
~[ ] Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The breaking changes that can been seen in the Detect breaking changes PR checklist item is not present in 2.x branch yet. This is only there in main and in this PR we have renamed the field names.

❌ Gradle check result for 1dc3f78: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - https://github.com/opensearch-project/OpenSearch/issues/13207


Fix Tabs in OCS Dashboard

Fix Breadcrumbs across ODF by adding spacing.
Make Tab component of PF look and feel similar to console HorizontalNav.
Signed-off-by: Bipul Adhikari<EMAIL_ADDRESS>Screenshot:

/lgtm

/lgtm

/override ci/prow/odf-console-e2e-aws

/cherrypick release-4.11
/cherrypick release-4.11-compatibility

/cherrypick release-4.11-compatibility


Add some log info to gain insight into some failure cases.

Add some log info to gain insight into some failure cases.
/sig testing
Release note:
None

/ok-to-test

@feiskyer -- as an aside, why are we using @acs-bot here?

@justaugustus acs-bot is used to setup http://prow.upstream.azure-containers.io/. We're using this private prow to validate and troubleshoot some e2e tests.

/retest

@nilo19 -- you need to gofmt that file. The tests are failing because fmt is still in the import declaration and it is unused:
W0726 09:32:27.092] tests/e2e/network/ensureloadbalancer.go:20:2: imported and not used: "fmt"

@nilo19 -- you need to gofmt that file. The tests are failing because fmt is still in the import declaration and it is unused:
W0726 09:32:27.092] tests/e2e/network/ensureloadbalancer.go:20:2: imported and not used: "fmt"

Got it. Thank you very much.

/lgtm
/approve


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.2.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Load config from package.json

This will load the agent's config from a package.json if present.

@kolanos is this a work in process?

Per our discussion...

Move to a loader pattern (class inheritance?)
defaults -> package.json -> rc file -> env vars -> instantiation vars
for plugin loading, use array of arrays for passing args (similar to babel)

@coreylight @pselle Ok, I refactored the config module to use config classes. It uses inheritance to fallback, eventually falling back to DefaultConfig. Currently there's only a stubbed out RcConfig which will handle loading values from an rc config.

@kolanos I'd like to see each class moved to a new file per class. I think this will provide nice encapsulation and readability, and you can co-locate loader class specific code (package.json loader for example) in each file.
Additionally, I'd like to see tests per class, and potentially a test suite that emulates example project scenarios (i.e. .user has inline config, package.json config, and env vars).

@coreylight @pselle This is ready for another review. It breaks up the config classes into separate submodules.

@pselle Is this good to go?

@kolanos needs conflict resolution.
Tagging @ewindisch for final review

@pselle Ok, this is rebased against master.

@coreylight This is failing on the test project handler test. I tested this locally and it was failing there as well until I ran yarn from within the test project directory. It looks like it isn't finding the iopipe-plugin-trace plugin in the test project handler test.


Adoption of the Vision Master E290

I made adoption of your code with the Vision Master E290
https://heltec.org/project/vision-master-e290/
It requires no code just to #define some variables. However, it is better to add some logic connected with this device. It runs with No display mode and also with the specific define flag.
Would you like to explore the opportunity to merge these changes to the code and add support for all e-ink devices?

Ive got a E290, and would love to see that!

Oh, that is a nice board!
I'm a bit stuck at the moment, being behind on some other work and only able to use my left hand because of a shoulder operation. I'm interested, and I suggest forking this repository and making all the changes necessary to support this device.
It would be nice if there was some automatic way of detecting which device is hooked up.

Oh, that is a nice board!
I'm a bit stuck at the moment, being behind on some other work and only able to use my left hand because of a shoulder operation. I'm interested, and I suggest forking this repository and making all the changes necessary to support this device.
It would be nice if there was some automatic way of detecting which device is hooked up.

You have an option to detect which device is hooked up. To do so, add a build parameter to platformio.io with the board's name.
[env:vision-master-e290]
platform = espressif32
board = heltec_wifi_lora_32_V3
framework = arduino
monitor_speed = 115200
monitor_filters = esp32_exception_decoder
board_upload.use_1200bps_touch = true
build_flags =
	-DHELTEC_BOARD=37
	-DE290
	-DESP32
	-DVision_Master_E290

There is a solution how to load your library with E290 and T 190:
// Disabling default Heltec lib OLED display
#define HELTEC_NO_DISPLAY
// Redefine button pin
#define BUTTON 21
// Without this line, Lora Radio doesn't work with Heltec lib
#define ARDUINO_heltec_wifi_32_lora_V3
#include "heltec_unofficial.h"

I tested your library with T290 e-ink and T190 TFT display. It works

Did you actually get the screen working on the T190?

Yes. The oh need custom libraries. This library run without display
On Thu, Sep 26, 2024 at 5:12 PM kaspesla @.***> wrote:

Did you actually get the screen working on the T190?
—
Reply to this email directly, view it on GitHub
https://github.com/ropg/heltec_esp32_lora_v3/issues/41#issuecomment-2378152937,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGJNZWRDLJJ4ACWA57GZWTZYSPGHAVCNFSM6AAAAABNB7XBE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGE2TEOJTG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks. What libraries work with this display? I'm having no luck finding anything. It's not even mentioned in Heltec's documentation!

There it is:
'''
// #define LoRaWAN_DEBUG_LEVEL 0
#include "HT_ST7789spi.h"
#include "global_config.h"
#include "images.h"
#include "ui.h"
#include <Adafruit_GFX.h>
#include <Arduino.h>
#define st7789_CS_Pin 39
#define st7789_REST_Pin 40
#define st7789_DC_Pin 47
#define st7789_SCLK_Pin 38
#define st7789_MOSI_Pin 48
#define st7789_LED_K_Pin 17
#define st7789_VTFT_CTRL_Pin 7
// lcd object pointer, it's a 240x135 lcd display, Adafruit dependcy
static HT_ST7789 *st7789 = NULL;
static SPIClass *gspi_lcd = NULL;
char buffer[256];
// Disabling default Heltec lib OLED display
#define HELTEC_NO_DISPLAY
#define DISPLAY_WIDTH 320
#define DISPLAY_HEIGHT 170
// Without this line Lora Radio doesn't work with heltec lib
#define ARDUINO_heltec_wifi_32_lora_V3
// T190 button pin
#define BUTTON GPIO_NUM_21
#define HELTEC_POWER_BUTTON
#include "heltec_unofficial.h"
'''

Thank you! I will try it tomorrow.

Trying everything to get this working for t190 board but no luck where are the UI. And global.h files coming from. Every thing I try in Arduino IDE says cannot compile for t190 board.


indentedSyntax option should be set to true for all .sass files

+1 please merge this

+1 this would solve a lot of problems, please merge

++1
... or if not default, at least documented (without diving the code), impossible to compile sass files without this set to true. would solve many problems and save searching times :)

It seems like this is solved directly by node-sass/libsass in the next version, can you try the 2.x branch of gulp-sass and report on #222 of any bugs happening relating to that?

As it's been a month, I'm closing this.


Universe Removals Not Working Properly

Expected Behavior

Universe additions and removes work as expected.
Actual Behavior

The backtest in this thread shows the universe removal process isn't working as expected.
Potential Solution

Unknown. It seems related to this merged PR.
Reproducing the Problem

Run the backtest in this thread.
System Information

QC Cloud. Windows 10.
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

Believe this is the UniverseSettings.MinimumTimeInUniverse effect, setting it to TimeSpan.Zero solves the misbehavior. Will close when the user confirms the fix.

Believe this is the UniverseSettings.MinimumTimeInUniverse effect, setting it to TimeSpan.Zero solves the misbehavior. Will close when the user confirms the fix.


Sorting issues

every time i open it in a new tab it does the opposite and sorts by the newest feed. so i have to go to the settings everytime i check my feeds and have to change the option to "title" and then back to "date" to fix the issue.
i do notice that when i open "smart RSS" that the search bar becomes red after i go into options and correct the issue. in other words there is a red outline on the search bar when it is working correctly. also i just noticed that if i manually update the feeds, it auto corrects itself. version 2.4.0 didnt have this issue.

Can't find anything even remotely related to this issue in diff so I'll have to debug the issue in depth


feat(@angular/cli): add styles/scripts prefix

Just for consideration. Add styles/scripts prefix in order to generate styles/scripts into different folders etc.

What's the use case for this that you're trying to fix?

Currently all the generated files will go into the root. Having styles/scripts placed into their own folders is better from multiple perspectives where one of them is Security of the application. Following the principle: secure everything and ignore specific it would be inconvenient to ignore every generated style/script but instead a singe folder containing all these styles/scripts. Saturday, 08 April 2017, 01:16AM +03:00 from Hans<EMAIL_ADDRESS>:

What's the use case for this that you're trying to fix?
—
You are receiving this because you authored the thread.
Reply to this email directly,  view it on GitHub , or  mute the thread .

@avshenuk  Be careful, this change will break CSS assets url path if user adds publicPath via deployUrl.
We override publichPath:'' for extractTextPlugin  which will only work if CSS and assets are under the same folder and your change will make the CSS and assets under different folder.
https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/models/webpack-configs/styles.ts#L181

thank you for the work you put into this Pr, but I don't think this change provides enough benefit vs the risk. There's also some overlap with --deploy-url in regards to functionality.


Use Project .babelrc From Storybook

It looks like Storybook isn't using the .babelrc defined in the project root. I think you are defining a different set of babel plugins inside storybook/webpack.config.
Wouldn't it make more sense to parse babelrc and use the plugins defined there?
My usecase is that I'm using styled-components and babel-plugin-styled-components which automatically generates a display name for components based on either the variable or file name. I have this defined in the project's .babelrc, however this isn't being used for components within storybook, meaning if I want to display their source within storybook it looks like: <styled.div> instead of <VLayout>.

It's relatively easy to add any plugin/preset into your storybook configuration:
defaultConfig.module.rules[0].use[0].options.plugins = [
  require.resolve('@babel/plugin-proposal-class-properties'),
  require.resolve('babel-plugin-styled-components'),
]

The reasoning behind not using the default .babelrc is that there wasn't one to begin with (none comes with a Gatsby project) and I do realise overriding the settings in the way it's done is pretty hacky but that was kind of the intention. Duct tape fix storybook/babel integration until https://github.com/storybooks/storybook/pull/3746 is merge, which should be within the upcoming days 🎉 (thanks Storybook team!)
And at that point a .babelrc inside of root folder should work perfectly fine
Side note: Sorry for getting back to you slowly had a relatively hectic week but should be available pretty consistently from now on!

Sure. I understand.  I'll leave this open as it would make sense to use an existing .babelrc eventually.

Hey now that v2 is out, will the default .babelrc work fine with this starter?

Closing this as the webpack.config patching solution seems to be the accepted solution by the Gatsby team as well as the fact Gatsby is still being shipped with uncompiled JSX and no easily accessible webpack.config
If this is really really needed though, it might be possible to still create a unified .babelrc/babel.config.js that both Storybook's custom config and Gatsby's could be manually configured using (by reading the config and adjusting Gatsby/Storybook through it)


Was there a breaking change in 6.1?

The unit tests of one of our projects, which depend on mock-socket, spontaneously stopped passing:
git clone https://github.com/interledgerjs/ilp-plugin-bells
cd ilp-plugin-bells
npm install
npm install<EMAIL_ADDRESS>npm run test # will fail
npm install<EMAIL_ADDRESS>npm run test # will pass

We have fixed the issue for our project, and I don't know what changed between 6.0 and 6.1, but this does suggest that according to semver, 6.1 should have been a major version, not a minor?
Thought I'd give you a heads-up. :)

Sorry for the breakage @michielbdejong and thanks for the heads up. The only changes between 6.0.4 and 6.1 are listed here (https://github.com/thoov/mock-socket/releases/tag/6.1.0) but if I had to guess you probably ran against this change (https://github.com/thoov/mock-socket/pull/165) which was fixing this issue (https://github.com/thoov/mock-socket/issues/157). The reason for why I did minor update and not a major two fold: the first was that I was unaware that it would be a breaking change and second the change was for a bug and I wanted to get the bug fix out for more people. If I have time I will check out your repo and see what I can infer from the tests that are breaking.


⚠ Bofrost.be has degraded performance

In 66b74e8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1021 ms

Resolved: Bofrost.be performance has improved in 2605589.


The new Script fails with a lot of errors on 2012R2 because of missing "InstalledOn"

Sort-Object : Exception getting "InstalledOn": "Exception calling "Parse" with "1" argument(s): "String was not
recognized as a valid DateTime.""
At C:\temp\DefenderOnboarding\2012R2and2016\mdefordownlevelserver-main\Install.ps1:609 char:34
+         $hotfix = @(Get-HotFix | Sort-Object -Property:InstalledOn)
+                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidResult: (\\SERVERXYZ\roo...PackInEffect="":PSObject) [Sort-Object], GetValueInvoc
   ationException
    + FullyQualifiedErrorId : ExpressionEvaluation,Microsoft.PowerShell.Commands.SortObjectCommand
Hi,

after the update of the script adding the correct KB i get a lot of Errors on our 2012R2 Serverslike this

Sort-Object : Exception getting "InstalledOn": "Exception calling "Parse" with "1" argument(s): "String was not
recognized as a valid DateTime.""
At C:\temp\DefenderOnboarding\2012R2and2016\mdefordownlevelserver-main\Install.ps1:609 char:34
+         $hotfix = @(Get-HotFix | Sort-Object -Property:InstalledOn)
+                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidResult: (\\SERVERXYZ\roo...PackInEffect="":PSObject) [Sort-Object], GetValueInvoc
   ationException
    + FullyQualifiedErrorId : ExpressionEvaluation,Microsoft.PowerShell.Commands.SortObjectCommand

Sort-Object : Exception getting "InstalledOn": "Exception calling "Parse" with "1" argument(s): "String was not
recognized as a valid DateTime.""
At C:\temp\DefenderOnboarding\2012R2and2016\mdefordownlevelserver-main\Install.ps1:609 char:34
+         $hotfix = @(Get-HotFix | Sort-Object -Property:InstalledOn)
+                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidResult: (\\SERVERXYZ\roo...PackInEffect="":PSObject) [Sort-Object], GetValueInvoc
   ationException
    + FullyQualifiedErrorId : ExpressionEvaluation,Microsoft.PowerShell.Commands.SortObjectCommand
....

When i take a look at the updates i see  they are installed but there is no "InstalledOn" for some.

maybe it needs some fault tollerance added:

workaround could be:
$hotfix = Get-HotFix | Sort-Object -Property:InstalledOn -ErrorAction SilentlyContinue

might be just a single server related issue on others it looks ok

http://britv8.com/powershell-get-the-actual-installed-dates-of-hotfixes/
checking with get-hotfixall it seems to work:

installed  WMF 5.1 on one server where it didn´t work, seems to work afterwards, but i also have servers with PS 4.0 which also works.

Thanks - we have identified the issue and will work on a fix. In the mean time, please ensure that the machine is fully up to date.: typically this will meet requirements and we do not need to check KB status.


Cleanup

This pr https://github.com/yihong0618/bilingual_book_maker/pull/148  is going to be completed today, and it introduces a lot of code that needs to be clean and refactored. I think it should be merged first and then cleaned together?

Going to close this for now and will reopen when #148 is merged


Redo ownership, remove permissions

This will likely come hand-in-hand with adding regions.
We'll want something like this perhaps:
case class LoadAsP(ownership: Option[OwnershipP])

See https://docs.google.com/spreadsheets/d/19rsnkKQGu48AXCgoXdTc3Z2HplnFSmKMzB96Sp2l_s8 for how it should work pre-regions.

Done in 0.2!


How does it compare to pigz?

Is there a performance benchmark for compression and decompression between pgzip and pigz since both claim to be parallel?

No. If there is no Go library of it. You are welcome to test - https://github.com/mholt/archiver contains a commandline version of pgzip.


export the targets with a python dependency to a different config file

Reference Issue
This PR is my initial attempt at addressing rdkit-feedstock/170.
What does this implement/fix? Explain your changes.
The C++ target from the base toolkit and those with a python dependency are exported to different cmake config files, so that librdkit can be packaged without a dependency from the python environment.
Any other comments?
So far I only locally tested a linux build, I still have to verify that the RDKitPython cmake config file actually works as intended, and would allow configuring a project that uses RDBoost in a python extension module.

@rvianello is this ready for review already or are you still working on it?

@greglandrum this PR might not require additional changes, but I'd like to test it on a couple of examples and do a bit of additional search for alternate approaches at decomposing the cmake config files.


Armor  parsing is now fully streaming

Impressed by your progress ;)
FWIW i just got mutt/muacrypt basically working, finally! :)
On Tue, Nov 13, 2018 at 17:12 +0000, Friedel Ziegelmayer wrote:

Merged #14 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dignifiedquire/pgp/pull/14#event-1963673855


Throttle Jobs (aka rate-limiting)

Difference between Throttle and Rate-Limit
Both Throttling and Rate-Limiting are designed to limit count of processes at a given time. However, Rate-Limiting rejects the processes exceeding a limit and Throttling queues/pauses processes until current ones have completed.
Rate limiting protects a system by applying a hard limit on its access. Throttling shapes a system by smoothing spikes in traffic.
A background processor shouldn't reject exceeding tasks queued. That's best handled at load-balancer layer. For these reasons, in Goose, we'll use the term Throttling, and not Rate-Limiting.
Why the need to Throttle Jobs?
Often 3rd party APIs will enforce a rate limit. Ergo, the count of Jobs executing at a given time shouldn't exceed this limit.
Patterns of Throttling
As elaborated here, Throttling can be done in 4 ways:

Concurrent: Only N jobs can execute at a given time.
Token Bucket: Like Concurrent, but resource pool is limited to N and grows at a fixed rate, which might be higher/lower than Job completion rate.
Leaky Bucket: Like Token Bucket, but allows bursts of jobs in a small time-interval. Resource pool can stay fixed like Concurrent or increase at a fixed rate like Token Bucket.
Fixed Window: In a given time-frame, only N jobs can execute.
Sliding Window: Like Fixed Window, but with a rolling window of time that moves the cursor to next executed job in a time-frame.

Nuances of Throttling for a background processor
Make note of these things when implementing this feature:

Since executing Jobs will acquire a lock, have a lock_timeout to ensure crashed processes do not hold a lock forever
Have a wait_timeout to ensure workers aren't waiting forever to acquire a lock. Upon timing out, User can configure to publish a metric, raise an alert or discard a Job altogether

Implementation Details
This is a complex feature to build. Some ideas after initial investigation:

A persistent store will be required to store count of executing jobs. Hence, this feature can exist for a message-broker like Redis and Postgres, but not for RabbitMQ.
If the message-broker has built-in support for expiry, that'll be helpful. Else, a separate thread will have to do garbage collection.

Until Goose supports Throttling, there are 2 hacks that can help achieve that:

If you want to enqueue Jobs asynchronously, Throttling can be achieved using a combination of :threads worker config and count of worker instances
For example, setting :threads count to 5 and running 4 worker instances, you can achieve a Throttle of max 20 Jobs executing concurrently
While enqueuing, you can schedule Jobs with a fixed or staggered delay.


Links to languages don't work

Since the languages section is a nested list, the references to individual languages are currently useless. AFAIF only headers can be linked to.

I think link fixes in #3 and #4 are also a good way to go (giving ids to nested lists) Any idea what we should decide on?

I wanted to keep nested lists, so I merged #4 Thanks for the PR!


Unique product names in result

Sometimes Rewe adds the same product in different categories. Don't display each one.

An OrderedDict will probably suffice. Implement eq and neq for this


feat(core): allow evm conversion (WIP)

What this PR does / why we need it:
Which issue(s) does this PR fixes?:

Fixes #
Additional comments?:
Developer Checklist:

[ ] Read your code changes at least once
[ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
[ ] No console errors on web
[ ] Tested on Light mode and Dark mode*
[ ] Your UI implementation visually matched the rendered design*
[ ] Unit tests*
[ ] Added e2e tests*
[ ] Added translations*

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/evm@1b9fad8). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             feature/evm    #4007   +/-   ##
==============================================
  Coverage               ?   16.46%
==============================================
  Files                  ?      455
  Lines                  ?    12319
  Branches               ?     4104
==============================================
  Hits                   ?     2028
  Misses                 ?    10250
  Partials               ?       41

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more