Merge prTesting_202007021954 branch to master branch

Docs Build status updates of commit 71250a6:
:clock10: Pending: waiting for processors (13 builds ahead of you)
:warning: Docs Build is busy, currently there are 13 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 71250a6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

split/updateTestCon.md
:warning:Warning

Details

split/updateTestCon.md

Line 0: [Warning-h1-not-first] Markdown content is not allowed before H1.
Line 1: [Suggestion-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading. NOTE: This Suggestion will become a Warning around July 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Fix for the .jsx extension in the page directory

Make the matching argument to glob consistent with lib/routes-loader

Thanks for the PR! The HTML page generator had been refactored, I'm afraid this fix is no longer relevant.


Document basic steps for building an indexer. [phab:D1141]

Created by zarko at 2016-11-09 00:37:01:
Test version up at https://efb4c54640bd0e80b67a8b1f74339e46f7ab424e-dot-kythe-repo.appspot.com/docs/schema/writing-an-indexer.html

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
I suggest inverting the order of these explanations:

Indexers usually accept .kindex …
For development, however, it's convenient for the indexer to accept program text…

It may be worth noting explicitly what is implicit throughout: That the "usual" mode of operation is the one the indexer needs to support, and the file-at-a-time mode is a convenience for testing.

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
The transition between the prefatory material and the bootstrapping section feels a little abrupt. In the background, maybe consider adding a bit of context? For example, here we're generating //cross-reference// data, consisting of declarations and their uses, comprising anchors that identify spans of source text and semantic nodes to represent entities defined by the code (etc.).
I think a brief high-level sketch like that would help set an outline in the reader's mind.

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Related to the comment above at line 38, I think the reader may be wondering //why// we want to do this.
Sketchily: "Kythe indexers emit graph data as a stream of JSON-formatted entries … to visualize the results we need to convert these into a format the example code browser understands … to get started let's write a script to do that" (or words to that effect).

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Suggestion for context: "In this document we're using JSON to represent Kythe entries … it's more efficient to use protocol buffers, particularly for languages that emit a large amount of data … the tools understand both, you can emit either" (etc.)
Maybe also separate the business of delimited streams into its own paragraph. It's not really necessary to understand it yet at this point in the doc, necessarily (except maybe as an implementation choice). The bit about base64 encoding seems more important.

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Maybe mention in this introductory section that we're using JavaScript as our running example.
Does the reader need to have Node installed? I don't know that our release packages include that.
Edit: Oh, I see now. JS is just the implementation language. That's probably worth calling out—the instructions aren't specific to JS, but the code samples are.

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
by "dictionary" I assume you mean "object" (in JS terminology).

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
"…generating reverse edges as needed for efficiency." (maybe).

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Suggestion:
"…underneath the /kythe prefix, since we're following the Kythe schema. This prefix is a requirement of the schema, not the data model."
(owtte)

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Link to Node maybe?

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
A good place to introduce the ticket term.

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Optional nit: "Protocol buffer string values must be valid…"
(just so it's clear you mean the string type rather than any sequence of symbols, though maybe that's obvious enough)

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
…fact values as…

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
…simple Lua program:
(I like Lua, but why the change of horses?)

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Nit: "…that the other components of a file VName be empty)."

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
"independently from" → "without reference to" ? (perhaps)

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Possibly also a useful guideline: Avoid duplicating information that's elsewhere in the VName, like the corpus label, language label, or path (in cases where a path is appropriate).

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
"caution" seems strong. Do you mean for data-size reasons?

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Maybe include an overbar comment documenting the fields?
//         sig      path     lang  root   corpus
fact(vname("foo#0", "hello", "ex", "", "example"), "node/kind", "variable")

It's spelled out in the declaration, but helpful for the reader not to have to page back.

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
This seems slippery: If anchors are congruent sharing a vname makes sense; but surely two anchors that span different ranges shouldn't have the same vname? Otherwise how would you record the facts for their endpoints?

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Maybe: "…in lines and columns or codepoints,"

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Maybe: "…as soon as practical"

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
"a tool that produces Kythe data" → "a Kythe indexer" ?

fromberger commented inline (context lost during migration) at 2016-11-09 16:48:20:
Suggestion:

notice how it is outlined in blue. The verifier applies this highlighting to nodes
that are matched against variables in the goals (here, FileNode).

fromberger wrote at 2016-11-09 16:48:20:
This is really great, thank you. I made a bunch of comments, most of which are minor nits of various flavours. The one main suggestion I have (echoed in the other comments throughout) is that there are a few places I think more context would be helpful to the reader.

zarko wrote at 2016-11-10 20:31:58:

Address comments.

zarko commented inline (context lost during migration) at 2016-11-10 20:32:14:
It's not actually Lua, I just chose it for syntax highlighting.

zarko commented inline (context lost during migration) at 2016-11-10 20:32:14:
I only mentioned the delimited stream bit because it's tripped up almost everyone who's written a new indexer so far. It's a little more information than necessary right now, but I've tried to call that out ("don't worry unless you're emitting lots of data"), and I think it's valuable to guard against confusion in the future.

zarko commented inline (context lost during migration) at 2016-11-10 20:32:14:
Yeah; we got so much benefit from hashing that I think "caution" is appropriate.

zarko commented inline (context lost during migration) at 2016-11-10 20:32:14:
That's not the meaning I intended. PTAL at the revision.

zarko commented inline (context lost during migration) at 2016-11-10 20:32:14:
Not all of these are indexers.

fromberger commented inline (context lost during migration) at 2016-11-10 21:11:14:
Optional nit: I'd drop the parentheses here.
Is it worth mentioning also that the JSON encoding is supported because some languages don't have good protobuf support?

fromberger wrote at 2016-11-10 21:11:14:
Thanks, again, for doing this. It will be very helpful.

fromberger accepted this revision at 2016-11-10 21:11:14

zarko wrote at 2016-11-10 21:13:37:

Address comments.

zarko closed via commit 8fa5db3413c407bb9abb8b6a9907cd0817f27805 at 2016-11-10 21:14:01


ACF image in post object not returning proper value

Expected behavior
I expect the post object to return the proper image value as selected in ACF. And assign it to the context variable I selected for the post object as an attribute.
Actual behavior
Instead it returns a string with what I assume is an ID. If I proceed to call another instance of .get_field('image'); on this post object it does return the proper return value.
All other attributes are properly returned, it's just the image field that seems to act in a strange way.
Steps to reproduce behavior
Create custom post type with image field
Create ACF field post object within page
What version of WordPress, PHP and Timber are you using?
Wordpress 4.9.8
ACF 5.8.0-beta2
Timber 1.8.1
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)
Upgraded to newest version via plugin updater in WordPress dashboard

Try {{ Image( post.get_field('image').src ) }}

@palmiak Thanks for trying to help but I think you misunderstood the bug report.
I am able to get the image via using another instance of get_field, but this shouldn't be the case if I'm not mistaken. It should be assigned to the attribute with the proper value, so right now {{ employee.image }} returns string(2) "26" and the employee.get_field('image') returns the proper url that I require.
{% for employee in employees %}

                                 {{ employee.name }}
{{ employee.job }}

                                                                                {{ employee.phone }}

                                                                                Linked In

                                                                                {{ employee.email }}

                                     {{ employee.specialism }}

                 {% endfor %}
And for relevance here is how I get the employees
    // Get all employees     $args = array(         'numberposts' => -1,         'post_type' => 'employees'     );     $context['employees'] = Timber::get_posts($args);

The best way is to return ID - it's the most universal way for the future usage.
Why the post object get's the ID? Take a look at your DB - ACF stores image data as ID. But when you select return value to url than get_field converts the ID to url.

@toxyc is everything clear and we can close the topic?


XFCE 4

Log [27/5/2021]

successfully managed to make a xfce 4 fs and transfer to android without any catastrophic file permission errors Thanks to ubuntu & Arch linux dev pages

But found that even xfce 4 is latest the styles are kind of old. Trying to beautify (suggest me some if you know some better/best themes)

On testing (suggestion/Help/PR's are welcome) 👌

Found

firefox tab crashes Tab crashes

Displayed some GL ERROR no fonts

Some missing packages causing hello of errors trying rebuilding recommended packages

Heading back to building

Build 2 with recommended packages seems successful

making a pre-release fs file


Events and data to be captured

The following client events and data should either be captured, or at least be possible to capture if configured:

User Info

User Agent
Geo info
User Device
User IP

Events

Navigation events
focus/blur
scrollstart/scrollend
click
keypress (whether or not the specific keys entered for this event are captured should be left up to configuration)

Errors (As much error information as if reasonable to capture)

@zebulasampedro what do the User Device, and Geo Info represent here?

User Device I suppose will be captured in the user agent. Geo Info can be retrieved from the IP later.  So in short: ignore those two fields 😄

@zebulasampedro regarding the keypress event, do we capture the individual keypresses separately, or the entered string as a whole?


Fix error when checking annotations with negative timestamps

Fixes #6389.

This fix was probably too simple (although it works and I could remove the test).
However, I'm not sure if the way we're currently handling annotations (carrying around the recording time as found in the file header) is the best choice. It would be easier and more intuitive if annotations were always based on zero instead of the recording time. As a last step, the recording time can always be added if the user wants annotation time based on that timestamp.

@massich can you look into this? You're the Annotations expert

Here's a more graceful approach: if crop is called on an object with no annotations, immediately return.

can you update a test so these lines are covered? thx

I've added a test that crops an empty Annotations object.

Thx @cbrnr

I pushed directly in maint/0.18 see 4f2eeedadcbece9cacc930b56445f9e90470c4d0


Can't add .tbd libraries to project

New Issue Checklist

[x] Updated struct to the latest version
[x] I have read the documentation to make sure my issue isn't covered already

Struct version
3.1.2
Spec version
2.1.0
Which type of spec are you using?

[x] project.yml
[ ] project.json
[ ] Specfile

Context
I'm trying to add a couple of .tbd libraries to my project because of a third party library having a requirement to use them.  My guess is that I'm incorrectly added this to the project.yml but I'm unsure how I added it differently. Sample project - project.zip
Reproduction steps
I've tried adding the library to the references like this.
references:     - sdkroot:libiconv.tbd
Expected result
Library gets added the the project file
Actual result
ld: library not found for -llibiconv.tbd and if I go into the general tab the library that was attempted to added gets an extra "lib" prefixed.  I.e. "liblibconv.tbd".

Same issue here. @steveholt55 have you found way around it?

Hey @steveholt55. Really sorry about the delay on this one. As far as I'm aware this is definitely supported, however it's not clearly documented which I'll address this week.
In order to link to non-framework system libraries, you omit the lib part, and the file extension, but otherwise it remains the same as frameworks, for example:
    references:
    - sdkroot:iconv

I've attached a full example that builds in Xcode with iconv as a dependency. Hope that helps!
stest.zip

@janhalousek you should be able to use this approach for any system library you're trying to link to also.

@lyptt thanks for getting back to us. Unfortunately, using your documented approach (also tried your test project), system libraries get translated to .dylib referencies, which has been obsolete for few versions of XCode now.
Is there a way to reference .tbd libraries?
Thank you

@janhalousek as far as I remember although it has the dylib in the name, it's still essentially the same thing. Can you try it and see if it works?
I will have a look into how I do system library resolution, its implementation was done all the way back in Struct 1.0.0 so maybe it needs some tweaking.

Yes, I think its usage might be the same, although the problem is that XCode nowadays has only tbd libraries bundled inside, so any path to dylib version of library is invalid. At least on my side :)

@janhalousek did Xcode fail to build after applying the above change to the project.yml? In my sample project Xcode appears to build and link the application fine with a dylib there.

This appears to also be functionality that's inherited by the Xcodeproj project, as I just call target_dsl.add_system_library [ref.name]. Maybe a version bump would change this behaviour.

From the sounds of things this issue is resolved - please let me know if there's still complications here!


Accept Input From The User

Make a function that accepts the three inputs from the user:

Phone Number / Email
Password
List of group links (or names)

The password should be stored after encrypting it on the user's system the first time he uses the application and after that, we should use the file unless it's not available or has been deleted.

Sir did you mean this one??

#15 <- this issue.


Update clan-chat-warnings

Added a cooldown to notifications (Big thanks to the guy hopping for Kraken)

I have a serious problem of making too many features but least I'm out of ideas and don't want to add any more to this.


chore: dependabot updates batch

/deploy renku=notebooks-operator-poc

You can access the deployment of this PR at https://renku-ci-nb-761.dev.renku.ch


Risk of undefined error when misconfigured output

Issue description:
Detected a "misconfiguration" in my output param's for some fields. Kirki happily took these misconfigurations and responded with loads of undefined errors. Some sort of warning may be suitable here.
https://github.com/kirki-framework/module-postMessage/blob/master/src/Postmessage.php#L65
if ( empty( $args['js_vars'] ) && ! empty( $args['output'] ) && is_array( $args['output'] ) ) {
	foreach ( $args['output'] as $output ) {
		// Solves the problem, but may throw a warning instead.
		if ( ! is_array( $output ) ) {
			continue;
		}

		$output['element']  = isset( $output['element'] ) ? $output['element'] : ':root';
		$output['element']  = is_array( $output['element'] ) ? implode( ',', $output['element'] ) : $output['element'];
		$output['function'] = isset( $output['function'] ) ? $output['function'] : 'style';
		$js_vars[]          = $output;
	}
}

Version used:
4.0.20
Using theme_mods or options?
Theme mods.
Code to reproduce the issue (config + field(s))
\Kirki::add_field(
	\Municipio\Customizer::KIRKI_CONFIG,
	[
		'type'     => 'select',
		'settings' => 'header_apperance',
		'label'    => esc_html__( 'Apperance', 'municipio' ),
		'section'  => self::SECTION_ID,
		'default'  => 'casual',
		'priority' => 10,
		'choices'  => [
			'casual'   => esc_html__( 'Casual (Small sites)', 'municipio' ),
			'business' => esc_html__( 'Business (large sites)', 'municipio' ),
		],
		'output'   => [
			'type' => 'controller',
		],
	]
);

Would be nice to allow a official way to add my own output types (which is what i'm doing here), if you decide to throw a fatal error in the future.

Hi @sebastianthulin , when the CSS output is accessed in front-end, there should be a PHP warning/method.
Please look at this line: module-css/src/CSS.php#L122
That's also maybe why there was a report in issue #2450 .
That line should be enough right?

You are correct. This is being throwed, but code further down the road is still running with insufficient error handling throwing native php warnings too.

Hi @sebastianthulin , thanks for your suggestion!
__doing_it_wrong has been implemented to handle miss-formatted output argument.
You can check this commit if you would like.
This change will be shipped to the next release.
Let me close this issue :)


Fix up Codespace

Create dedicated codespace docker for all problem sets to use that works across organization.
Potential option: https://github.com/big-data-and-economics/ps4-class-sizes-solutions

Can I get this across multiple repos?
https://docs.github.com/en/codespaces/prebuilding-your-codespaces/configuring-prebuilds
https://github.com/big-data-and-economics/big-data-class-materials/settings/codespaces


broken link to install instructions for version 1.9

I dont know where else to post this issue: Trying to install version 1.9 following the website, I noticed a dead link in docker engine -> ubuntu sending me to https://docs.docker.com/v1.9/installation/ubuntulinux/ which gives a 404.

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

since this is related to the website I do not know what docker version / info I should supply here and hence omitted it.

You might find the links on the left sidebar to be less broken.

Also, be aware that the install instructions always install the latest version; you should be able to follow the regular instructions, but when installing (apt-get install) provide the version you want to install. For example;
First check the available versions:
apt-cache policy docker-engine
docker-engine:
  Installed: 1.10.2-0~trusty
  Candidate: 1.10.2-0~trusty
  Version table:
 *** 1.10.2-0~trusty 0
        500 https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
        100 /var/lib/dpkg/status
     1.10.1-0~trusty 0
        500 https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
     1.10.0-0~trusty 0
        500 https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
     1.9.1-0~trusty 0
        500 https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
     1.9.0-0~trusty 0
        500 https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
     1.8.3-0~trusty 0....

And install that version;
apt-get install docker-engine=1.9.1-0~trusty
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be DOWNGRADED:
  docker-engine
0 upgraded, 0 newly installed, 1 downgraded, 0 to remove and 16 not upgraded.
Need to get 7,486 kB of archives.
After this operation, 5,193 kB disk space will be freed.
Do you want to continue? [Y/n]

get the same issue.
The following package was automatically installed and is no longer required:
  libsystemd-journal0
Use 'apt-get autoremove' to remove it.
The following NEW packages will be installed:
  docker-engine
0 upgraded, 1 newly installed, 0 to remove and 133 not upgraded.
Need to get 7486 kB of archives.
After this operation, 38.0 MB of additional disk space will be used.
Err https://apt.dockerproject.org/repo/ ubuntu-trusty/main docker-engine amd64 1.9.1-0~trusty
  Failed to connect to apt.dockerproject.org port 443: Connection refused
E: Failed to fetch https://apt.dockerproject.org/repo/pool/main/d/docker-engine/docker-engine_1.9.1-0~trusty_amd64.
deb  Failed to connect to apt.dockerproject.org port 443: Connection refused

E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@Samurais I'm unable to reproduce; could there be a firewall blocking requests for apt.dockerproject.org?

I disable the firewall by ufw. But nothing changes. The installation hangs for requesting files from apt.dockerproject.org. Since this machine is running in China, if requesting to google endpoints, it fails.
I think it is caused by GFW in China.

@Samurais yes, I suspect the same. Unfortunately, I can't help you with that

I'm closing this issue since there is nothing we can do about the GFW, sorry about that.
Refer to this guide to install Ubuntu: https://docs.docker.com/engine/installation/linux/ubuntulinux/
v1.9 is obsolete.


Numpy 2.0

Numpy 2.0 is coming: https://github.com/numpy/numpy/issues/24300
There will need to be a zfpy release built for this, as 1.0.0 wheels will (very likely) not be compatible with numpy 2.x
Is anyone looking into this yet?

@da-wad Thanks for the heads up.  We've not yet looked at the impact of Numpy 2.0.  Are you aware of anything in particular that will require changes to zfpy?

Nothing more than what is in the summary text in that issue.
But: "the NumPy C ABI will change in 2.0, so any compiled extension modules that rely on NumPy are likely to break, they need to be recompiled." may mean that compiling new wheels is all we need to do.
However, I think this highlights the need for some distance between zfpy and zfp versioning...

JFYI 3 weeks ago, NumPy 2.0.0rc1 was tagged. Packages were built for conda & wheels: https://github.com/numpy/numpy/issues/24300#issuecomment-2030603395
Would add NumPy has put together a migration guide. More details are in the release notes
If zfpy make use of NumPy's C API (and produces wheels that use it), having a release of zfpy with wheels built against NumPy 2.0.0rc1 would be helpful to ensure NumPy 1 & 2 compatible wheels (as wheels built against NumPy 1 won't be compatible with NumPy 2). More details in this NumPy 2 ABI doc
Also as NumPy is tracking ecosystem support for NumPy 2.0, it would be helpful to share zfpy's current support status (with any plans) in this issue: https://github.com/numpy/numpy/issues/26191

@jakirkham Thanks for the heads up.  We are currently looking for someone to help out with maintaining zfpy and building wheels as we're short on staff and expertise in this area.  Any contributions would be welcome and appreciated.

Would recommend using whatever build script is used currently and try NumPy 2 instead (maybe drop oldest-supported-numpy if that is in use)
Given the light usage of NumPy in zfpy, it is possible that is all that is needed

Had a bit of a look around, and I think @jakirkham is right.  Assuming the current build setup works (it doesn't look very "formal"): all that should be needed is replacing oldest-support-numpy with numpy>=2.0.0rc1 and you are done.
(Of course testing with NumPy 2 may show other incompatibilities.)

I added https://github.com/LLNL/zfp/pull/231, let's see what happens.

Update from https://github.com/LLNL/zfp/pull/231#issuecomment-2176536427. I see two warnings:
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/numpy/_core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: #warning "Using deprecated NumPy API, disable it with " "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
   17 | #warning "Using deprecated NumPy API, disable it with " \
      |  ^~~~~~~

I don't think those are new (due to 2.0) though. Tests are passing, so I think it's ok?

Yes they are ancient, but we didn't enforce them now, there was just little point.

This is breaking with numpy 2.0.0.  Looks like a change to numpy's array struct.
% uname -po
x86_64 GNU/Linux

% pip install zfpy==1.0.0
Collecting zfpy==1.0.0
  Using cached zfpy-1.0.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (648 bytes)
Using cached zfpy-1.0.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (729 kB)
Installing collected packages: zfpy
Successfully installed zfpy-1.0.0

% python3
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import zfpy
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "zfpy.pyx", line 1, in init zfpy
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
>>> import numpy as np
>>> np.__version__
'2.0.0'

If I build using (after updating setup.py / pyproject.toml)
cd build
cmake -DCMAKE_INSTALL_PREFIX=$VIRTUAL_ENV ..
make -j install
LDFLAGS=-Wl,-rpath,$VIRTUAL_ENV/lib' pip install .

the problem disappears.

Yes this is a known issue. The builds are not compatible with NumPy 2. Would stick with NumPy 1 for now if you need zfpy

Is there any chance a new release of zfpy could be made, with a pin to the numpy version (ie numpy<2 in the dependencies)? This would make life a bit easier to make sure that a compatible version of numpy is installed, instead of manually having to reinstall numpy and reinstall numpy<2 if you want to use pcodec (which we're currently doing over in our CI at numcodecs)

@dstansby I'm willing to entertain this, though I don't know what's involved.  Is this as simple as adding numpy<2 to python/requirements.txt?
One concern I have is that even a minor release involves significant effort.  If we based the release off the latest develop branch, there's more work needed to ensure that any additions since 1.0.1 are well documented and tested.  We have a rather lengthy process for doing a release, which in addition to extensive (semi-manual) testing (using different compilers on a variety of platforms, leak checking, ...) includes making updates external to the main repo, such as to our Spack package.
Since transitioning from Travis to Actions, we also have a new process for building wheels that I'm unfamiliar with.  @da-wad used to handle this; we'd either have to rely on him or on someone more knowledgable than me to get the wheels built and deployed.
Finally, there are some Python related PRs I'd like to consider (like #227, #234, #237) for such a release.  No biggies, really, but we no longer have a Python developer on the team.
With all this in mind, I wonder how much additional work would be needed to ensure zfpy works with NumPy 2.0.  That strikes me as the preferable solution.  We're planning a new release in the coming months, so if we can live with these NumPy issues a little longer, I would much rather tackle them as part of the next release.
As an alternative to a full blown release, we could consider this an unofficial release by just bumping ZFP_VERSION_TWEAK, whose intent is just that--to be able to tag completed work in between releases.  For the wheels, I believe all we need is to reference a tagged commit.

Is this as simple as adding numpy<2 to python/requirements.txt?

Yes, I think that's correct. I didn't appreciate that building the wheels is quite labour intensive - it's not a huge issue for us over at numcodecs (more a minor inconvenince), so waiting for the next release sounds 👍 to me

I actually noticed two places (I think in the tests) that use array(..., copy=False) which need to be asarray(...) instead.
Beyond, that running ruff once probably makes sense to see if it does something: ruff check path/to/code/ --select NPY201 --fix.
@dstansby if you are so inclined and building locally is not a problem, you could probably even just try if --no-binary works for you.
I would agree that making the build run smoothly again is most likely the tricky part here, while supporting NumPy 2 is (hopefully!) not a lot of extra work.

I didn't appreciate that building the wheels is quite labour intensive

Building the wheels isn't all that labor intensive; doing a complete release of the core C/C++ library is, however.  Our release checklist is two dozen tasks, and that does not even include manual testing using various compilers (gcc, clang, icc, pgi, ...) and back ends (different CUDA and HIP versions) not part of our regular CI, leak checks, updates to the Spack package and webpages, proofreading 200+ pages of documentation, etc., on top of testing and deploying the wheels.  It's days worth of work, so our releases tend to be less frequent but more substantial.

@seberg Thanks for suggesting ruff.  I gave it a spin:
% ruff check tests/python --select NPY201 --no-fix
All checks passed!

The rest of the code is Cython, which as I understand is not supported by ruff.

Hi all, I'm also trying to update some dependencies for numcodecs for a WebAssembly build of it in zarr-developers/numcodecs#529 and I stumbled across this issue. I am fully cognisant of how concerted an effort is required to officially support NumPy 2.0 based on the previous conversation here; may I ask if it's possible to publish a source distribution for zfpy to PyPI in the meantime? There isn't one available yet It would be beneficial for Pyodide's in-tree recipes (pyodide/pyodide#5169) where I tried to package zfpy but there wasn't a source distribution available (https://pypi.org/project/zfpy/#files). We're also planning to release a new version of Pyodide with all NumPy-dependent packages rebuilt for NumPy v2 (pyodide/pyodide#4925), so we can try out an "unofficial" WASM build with NumPy v2 in the time this issue gets resolved.
I can potentially help out with revamping the packaging infrastructure to publish a standards-compliant sdist – I was thinking of opening a PR myself, though I notice efforts towards that area such as #237 are already present. I also read through https://github.com/LLNL/zfp/pull/236#issuecomment-2207429121, please let me know and I'll be willing to spend some time contributing and driving something forward, either here or in https://github.com/LLNL/zfpy-wheels/ (or in both places). I decided to file this request and ask around in this issue thread instead of creating a new issue because the discussions here are not exactly orthogonal. As for Pyodide, I can experiment with the tarball from the latest tag (https://github.com/LLNL/zfp/releases/tag/1.0.1.) for now, though and see if that gets us somewhere.
P.S. We don't support the --no-binary command-line flag suggested above yet.

Hi all, I'm also trying to update some dependencies for numcodecs for a WebAssembly build of it in zarr-developers/numcodecs#529 and I stumbled across this issue. I am fully cognisant of how concerted an effort is required to officially support NumPy 2.0 based on the previous conversation here; may I ask if it's possible to publish a source distribution for zfpy to PyPI in the meantime? There isn't one available yet It would be beneficial for Pyodide's in-tree recipes (pyodide/pyodide#5169) where I tried to package zfpy but there wasn't a source distribution available (https://pypi.org/project/zfpy/#files). We're also planning to release a new version of Pyodide with all NumPy-dependent packages rebuilt for NumPy v2 (pyodide/pyodide#4925), so we can try out an "unofficial" WASM build with NumPy v2 in the time this issue gets resolved.
I can potentially help out with revamping the packaging infrastructure to publish a standards-compliant sdist – I was thinking of opening a PR myself, though I notice efforts towards that area such as #237 are already present. I also read through https://github.com/LLNL/zfp/pull/236#issuecomment-2207429121, please let me know and I'll be willing to spend some time contributing and driving something forward, either here or in https://github.com/LLNL/zfpy-wheels/ (or in both places). I decided to file this request and ask around in this issue thread instead of creating a new issue because the discussions here are not exactly orthogonal. As for Pyodide, I can experiment with the tarball from the latest tag (https://github.com/LLNL/zfp/releases/tag/1.0.1) for now, though and see if that gets us somewhere. If it would be better to open a new issue for this, please let me know and I'll do so.
P.S. We don't support the --no-binary command-line flag suggested above yet.

Hi all, I'm also trying to update some dependencies for numcodecs for a WebAssembly build of it in zarr-developers/numcodecs#529 and I stumbled across this issue. I am fully cognisant of how concerted an effort is required to officially support NumPy 2.0 based on the previous conversation here; may I ask if it's possible to publish a source distribution for zfpy to PyPI in the meantime? It would be beneficial for Pyodide's in-tree recipes (pyodide/pyodide#5169) where I tried to package zfpy but there wasn't a source distribution available (https://pypi.org/project/zfpy/#files). We're also planning to release a new version of Pyodide soon which will have all NumPy-dependent packages rebuilt for NumPy v2 (pyodide/pyodide#4925), so we can try out an "unofficial" WASM build with NumPy v2 in the time this issue gets resolved.
I can potentially help out with revamping the packaging infrastructure to publish a standards-compliant sdist – I was thinking of opening a PR myself, though I notice efforts towards that area such as #237 are already present right now. I also read through https://github.com/LLNL/zfp/pull/236#issuecomment-2207429121, please let me know and I'll be willing to spend some time contributing and driving something forward, either here or in https://github.com/LLNL/zfpy-wheels/ (or in both places). I decided to file this request and ask around in this issue thread instead of creating a new issue because the discussions here are not exactly orthogonal to my request. As for Pyodide, I can experiment with the tarball from the latest tag (https://github.com/LLNL/zfp/releases/tag/1.0.1) for now, though, and see if that gets us somewhere (but it's better for us to have an sdist handy, of course). If it would be better to open a new issue for this, please let me know and I'll do so.
P.S. We don't support the --no-binary command-line flag suggested above yet.

@agriyakhetarpal:

may I ask if it's possible to publish a source distribution for zfpy to PyPI in the meantime?

I see no reason why not, except I don't know what's involved.

I can potentially help out with revamping the packaging infrastructure to publish a standards-compliant sdist

Any assistance with this would be greatly appreciated.  The zfp team currently lacks Python/PyPI expertise, so we'd happily accept any contributions.  I've not merged some of the PRs yet as there are multiple outstanding issues and potentially conflicting PRs that need to be addressed, and I was hoping to have someone Python proficient look at all these issues and our new process for deploying wheels before the next release.  In addition to the NumPy 2.0 issues discussed here on #210, I would like to make sure we adequately address #201, #227, #231, #233, #234, #237.

So Peter, would suggest just rebuilding this wheel maybe with version 1.0.1.post1 and upload to PyPI

@jakirkham Except for minor changes to the tests, are you saying that no zfpy changes are needed for NumPy 2.0, and that we can just go ahead and build and deploy wheels?

Right
Would honestly even skip the test fixes (given what you have said about the internal release process). Those small changes are not worth that overhead and most users are interested in the library itself (not the test suite)

@da-wad Congrats on parenthood!  And thanks for your help with this.
I'm a little wary of decoupling versions.  I don't expect much independent development of zfp and zfpy, and divorcing them will likely lead to confusion, especially since zfpy is part of zfp.  I think a better solution would be to bump ZFP_VERSION_TWEAK and to tag that version without doing a full zfp release.  That would allow making minor changes to zfpy while keeping versions synchronized.
Regarding the specific issue with 63eeefa you mentioned, at least one PR addresses it, and it would be good to merge any Python related PRs that we believe should be included.  Please see #201, #227, #231, #233, #234, #237.

Think language_level should be inside Extension. It looks like it is outside atm

Thanks for pointing me towards those, #237 fixes the bug introduced in https://github.com/LLNL/zfp/commit/63eeefa32adffe71217f3e48ae5011f8b5f75de1 and referenced by #233
I suggest merging this PR into develop and then I'll have a go at making wheels for 1.0.1 ... in terms of versioning I can see what you mean about having ZFP_VERSION_TWEAK to take care of this, however as far as I can tell a 4-integer format is not permitted in PyPI, so we cannot have f.eks. <IP_ADDRESS> ... see the spec here: https://packaging.python.org/en/latest/specifications/version-specifiers/#post-releases
I suggest bumping the tweak version with merging this PR anyway. Because what we could do in this case is post-releases, whereby we have the zfpy version being <ZFP_VERSION_MAJOR>.<ZFP_VERSION_MINOR>.<ZFP_VERSION_PATCH>.post<ZFP_VERSION_TWEAK> ... but then it might be necessary to reserve the ZFP_VERSION_TWEAK for zfpy to avoid ambiguity?
Once we've fixed the wheel building then we can look at numpy 2.0 compatibility!

I expect such a post release to be an exception to the norm, so I'm fine with bumping ZFP_VERSION_TWEAK to 1 and doing a post release of zfpy, which in this case synchronizes versions.  But if additional minor changes are needed for NumPy 2.0, we'd have to do another post release.  From what I can tell, few if any changes are needed, so should we not try to knock that out now and do only one post release?
I'll go ahead and merge #237.  Once we've decided we're ready for a post release, I'll update ZFP_VERSION_TWEAK.  I think we want this to be the commit that is tagged and used by zfpy-wheels.

If we are ok fixing the Python test suite for NumPy 2 in a ZFP_VERSION_TWEAK (note - this only affects Python tests as show above: https://github.com/LLNL/zfp/issues/210#issuecomment-2463210726 ), then it would be great to include.
However if that complicates making a release happen, would much rather skip them to get the release out faster
Just my 2¢

Wheels for zfpy 1.0.1 are now built (against numpy 2.xx) and released here on PyPI using zfpy-wheels!
This includes all possible combinations of Python 3.9-3.13 and osx/win/linux and x86/arm.
It's not strictly 1.0.1 since it includes code from #237 and a few commits ahead of that, but it should be close enough. For the next release I expect setup.py won't be broken and we can have exactly matching PyPI distributions with the main zfp repo tag.
@lindstro I am happy for you to close this issue now, but won't close it myself in case there are objections from the conda side of the debate.

@da-wad Thank you so much for your help with this.  I guess the decision was not to bump ZFP_VERSION_TWEAK? Hopefully 1.0.1 will be short lived and we'll get things back in sync for the next release.
Is there a way to identify which commit the zfpy wheels are linked to?  Back when using Travis CI for deployment, you'd enter the commit hash in .travis.yml.  I'm guessing this is done here using Actions?
#237 took care of several issues for us, including #234, I believe (I'll look into updating the installation documentation in that PR).  Can you comment on the status of #201 and #231 and whether they still need to be addressed?  Might be nice to address #227, though it does not seem compatible with AppVeyor.  Ideally, we'd migrate from AppVeyor to Actions, but I unfortunately don't have the spare cycles at the moment to work on that.

Thanks David! 🥳


fix: return correct type for successful broadcasts

In the latest micro-stacks, broadcastTransaction returns { txid: string }, but that's not the TypeScript type. You need to do funky workarounds when using this library in TS to get the result you want.
A different option is to actually return a string, which would also fix the issue (and be backwards compat with stacks.js?)

hmm yeah there needs to be some updates, see https://github.com/hirosystems/stacks.js/blob/master/packages/transactions/src/builders.ts#L363

It looks like this change does make micro-stacks match the behavior of stacks.js https://github.com/hirosystems/stacks.js/blob/fe831cf28d71de9410c81cfabe256fd511e9aa4d/packages/transactions/src/builders.ts#L449-L451
Looks like stacks.js transforms the response into an actual object from the rather odd string-quoted txid string returned by /v2/transaction.

ah yes, @hstove can you do a minor change via changesets?

Thanks for the changeset + merge!

So now when you read the data from an onFinish callback, you end up having to do something like this:
const onFinish = useCallback(
    data => {
      const txid = data.txId.txid;

Can that be reduced to data.txid or data.txId?

@aviculturist is that what you are currently experiencing?
based off the wallet code, that is not correct: https://github.com/hirosystems/stacks-wallet-web/blob/dev/src/app/common/transactions/broadcast-transaction.ts#L28

Yes, it's what I'm seeing in the data object with Hiro Wallet v3.0.0.

.


Consider grouping the possible UI elements under one module

Hello @JaggerJo,
This project looks really good and I really like the API used for the view elements. It looks like it was loosely based on fabulous-simple-elements. If that the case, I would like to suggest something that I regret not adding to that library -> not being able to see which elements you can use!
Let me explain: if the user is a beginner, then there is no way to tell which elements are available in the framework. You have to go through the docs and search for elements you need. Of course once you have found them, it becomes easy to find their properties, but only after you have searched the docs.
I propose to add a module, maybe named Ava that contains the constructor for all possible UI elements. Instead of
Button.create [
    Button.onClick (fun _ -> dispatch Increment)
    Button.content "click to increment"
]

I suggest writing:
Ava.button [
    Button.onClick (fun _ -> dispatch Increment)
    Button.content "click to increment"
]

This way the beginner user has a nice "entry point" to the possible UI elements that can be used and from there the search for elements becomes even easier. The reason for the name Ava is that the formatting works nicely when the propery list is indented with 4 spaces such that the property modules become aligned with the constructor function. This is how it is done in both Mui module from Fable.MaterialUI and the Ant module from Fable.AntDesign.
It would be a plus if the property module was also lower-case (but would introduce a breaking change)
Ava.button [
    button.onClick (fun _ -> dispatch Increment)
    button.content "click to increment"
]

What do you think?

Hello there! I just want to chime in.
I can see why the reason to suggest that, I feel the namespacing on XamarinForms is a little bit weird and you do have to look at the docs to see proper names of elements and such which I believe it's a reason for fabulous-simple-elements to want to group UI elements/controls on a single "entry point"
I don't feel that with Avalonia this is an issue since almost every UI element is namespaced under Avalonia.Controls and FuncUI just builds on that; At least I didn't have too much issues discovering the API the first days when experimenting with it.
It might just be familiarity though I see the benefit from people coming from other Elmish based DSL's that the UI elements are usually under one entry point like Html (I think even fsbolero does that as well) or the other examples you mentioned. And for people that are not familiar with Elmish/Avalonia it could be a good way to catch up on the UI Controls
offtopic
I like a lot of your projects, I'm a fan of LiteDB.FSharp 💯
back on topic

Hey @Zaid-Ajaj,
Thanks, it might be 😉. I've searched and reviewed all elm like DSLs I could find and am really happy how it turned out.

This project looks really good and I really like the API used for the view elements. It looks like it was loosely based on fabulous-simple-elements. If that the case, I would like to suggest something that I regret not adding to that library -> not being able to see which elements you can use!
Let me explain: if the user is a beginner, then there is no way to tell which elements are available in the framework. You have to go through the docs and search for elements you need. Of course once you have found them, it becomes easy to find their properties, but only after you have searched the docs.
I propose to add a module, maybe named Ava that contains the constructor for all possible UI elements.

That should already work because all constructors/ and modules of the DSL are located in the Avalonia.FuncUI.DSL namespace.
So if you open Avalonia.FuncUI you can do this:

What makes this a bit less useful is that you only can use the constructor, but not the attributes if you haven't opened the namespace that contains the actual control.
open Avalonia.Controls
open Avalonia.FuncUI

let view =
    DSL.Calendar.create [
        DSL.Calendar. // only shows create because the calendar control lives in `Avalonia.Controls.Calendar`
    ]

open Avalonia.Controls
open Avalonia.Controls.Calendar
open Avalonia.FuncUI

let view =
    DSL.Calendar.create [
        DSL.Calendar. // shows all available attributes
    ]

So you get a hint that a control exists, but need to open the containing namespace to actually do something useful with it.

It would be a plus if the property module was also lower-case (but would introduce a breaking change)
Ava.button [
button.onClick (fun _ -> dispatch Increment)
button.content "click to increment"
]
What do you think?

It would definitely look nice and clean, but making the module/type lowercase is something I strongly dislike, it makes things harder to understand IMHO.
This currently works:
DSL.Button.create [
    Button.dock Dock.Bottom
    Button.onClick (fun _ -> dispatch Reset)
    Button.content "reset"
]

Do you think using the DSL prefix is helpful enough ?

@Zaid-Ajaj you still around ? 😊

Hello @JaggerJo, sorry I didn't connect back to you! It seems you have thought about it more than I did :smile: I especially liked this snippet
DSL.Button.create [
    Button.dock Dock.Bottom
    Button.onClick (fun _ -> dispatch Reset)
    Button.content "reset"
]

Because there is only one use of DSL which becomes the entry point of discovery, really cool stuff.  Thanks for taking the time with your detailed response 💯

Hello @JaggerJo, sorry I didn't connect back to you! It seems you have thought about it more than I did 😄 I especially liked this snippet
DSL.Button.create [
    Button.dock Dock.Bottom
    Button.onClick (fun _ -> dispatch Reset)
    Button.content "reset"
]

Because there is only one use of DSL which becomes the entry point of discovery, really cool stuff. Thanks for taking the time with your detailed response 💯

@Zaid-Ajaj I have to admit that the formatting was pure luck, I never thought about DSL. = indent size TBH. But it's neat!
Thanks for the feedback! 😊


Correct path casing when performing cd

Steps to reproduce
# On Windows
# When having a directroy called "Z:\Dir"
PS Z:\> cd "dir"

Expected behavior
CWD is set to `Z:\Dir`

Actual behavior
CWD is set to `Z:\dir`

Related #1273. Maybe dup?

@iSazonov: I think the real duplicate is #5678.
More specific discussion of causes and solutions starts at https://github.com/PowerShell/PowerShell/issues/5678#issuecomment-418159153

Yes, this is dupe of #5678


Package cleanup

added poetry buildsystem
moved files into package structure tracegroomer
added scripts section to create a commandline interface upon installation
added LICENSE
added .gitignore

hello Helge, I have also to modify the 'raw' folder requirement as it has been suppressed in DIMet :) (I will do it in the afternoon)


Install skip qigen(windows)

qigen currently does not support windows. Therefore, we made it so that qigen is not installed on Windows.
Currently, I can make Windows generate qigen's backend.cpp, but pytorch fails to compile backend.cpp.

Hi @qwopqwop200 , thank you for the fixing, it looks good to me.
Here is one topic I want to futher discuss that we may do in another PR:
Can we treat Qigen as a third party package so that we can optionally depend on it when install autog-gptq like using pip install auto-gptq[qigen]. The reason is p = int(subprocess.run("cat /proc/cpuinfo | grep cores | head -1", shell=True, check=True, text=True, stdout=subprocess.PIPE).stdout.split(" ")[2])'s result is highly depend on the CPU what we have at hand, and if we pre-build the wheels, it may use a small value like 8, while our users may have an advanced CPU with 32 or even 64 cores.

Qiwen breaks the installation from source on Linux, see https://github.com/PanQiWei/AutoGPTQ/issues/333. AutoGPTQ not having a CI is kind of a big issue.


AssertionError: (<Node 'EXPRESSION_FUNCTION_BODY' ... 'ref_name': 'PySimpleGUIQt$PySimpleGUIQt

Hello,
I just started using Nuitka today, and it is amazing! I successfully created some EXEs for a few Python scripts, but when I tried to use it to build an EXE for a python GUI (PySimpleGUIQt), Nuitka seemed to have some problems...?
I have the following Python script (just a single import):
script_Run-SendFile_GUI-SIMPLE.py:
import PySimpleGUIQt as sg

This is on Windows 10 (64 bit):
python -m nuitka --version
0.6.5
Python: 3.5.4 (v3.5.4:3f56838, Aug  8 2017, 02:17:05) [MSC v.1900 64 bit (AMD64)]
Executable: C:\Python35\python.exe
OS: Windows
Arch: x86_64

Here is how I installed the Python libraries:
pip install PySimpleGUIQt
pip install PySide2
pip install PyQt5
pip install nuitka

Here is what I did to create the EXE:
python -m nuitka --follow-imports script_Run-SendFile_GUI-SIMPLE.py
Here is the error message I get:
Problem with <Node 'EXPRESSION_FUNCTION_BODY' with {'parameters': <ParameterSpec 'self,event'>, 'name': '_treeview_selected', 'code_object': <CodeObjectSpec Function '_treeview_selected' with 'self,event,selections,MyForm'>, 'flags': None, 'ref_name': 'PySimpleGUIQt$PySimpleGUIQt$$$function_146__treeview_selected', 'provider': 'PySimpleGUIQt$PySimpleGUIQt', 'doc': None}>
Problem with <Node 'COMPILED_PYTHON_MODULE' with {'name': 'PySimpleGUIQt', 'package': 'PySimpleGUIQt', 'filename': 'C:\\Python35\\lib\\site-packages\\PySimpleGUIQt\\PySimpleGUIQt.py'}>
Traceback (most recent call last):
  File "C:\Python35\lib\site-packages\nuitka\__main__.py", line 184, in <module>
    main()
  File "C:\Python35\lib\site-packages\nuitka\__main__.py", line 177, in main
    MainControl.main()
  File "C:\Python35\lib\site-packages\nuitka\MainControl.py", line 759, in main
    main_module = createNodeTree(filename=filename)
  File "C:\Python35\lib\site-packages\nuitka\MainControl.py", line 141, in createNodeTree
    Optimization.optimize(main_module.getOutputFilename())
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 545, in optimize
    finished = makeOptimizationPass(initial_pass=False)
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 474, in makeOptimizationPass
    if optimizeVariables(current_module):
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 370, in optimizeVariables
    if optimizeUnusedUserVariables(function_body):
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 325, in optimizeUnusedUserVariables
    function_body.removeUserVariable(local_variable)
  File "C:\Python35\lib\site-packages\nuitka\nodes\FunctionNodes.py", line 224, in removeUserVariable
    assert variable in self.providing.values(), (self, self.providing, variable)
AssertionError: (<Node 'EXPRESSION_FUNCTION_BODY' with {'parameters': <ParameterSpec 'self,event'>, 'name': '_treeview_selected', 'code_object': <CodeObjectSpec Function '_treeview_selected' with 'self,event,selections,MyForm'>, 'flags': None, 'ref_name': 'PySimpleGUIQt$PySimpleGUIQt$$$function_146__treeview_selected', 'provider': 'PySimpleGUIQt$PySimpleGUIQt', 'doc': None}>, {'self': <ParameterVariable 'self' of '_treeview_selected'>, 'selections': <LocalVariable 'selections' of '_treeview_selected'>, 'event': <ParameterVariable 'event' of '_treeview_selected'>, 'MyForm': <LocalVariable 'MyForm' of '_treeview_selected'>}, <LocalVariable 'x' of 'listcomp'>)

Thanks,
George Hynes
09/16/2019 6:03pm ET

Hello,
I uninstalled your 0.6.5, then installed your 0.6.6rc5 "developer" version to see if it made any difference -and it appears the issue still exists, as per:
pip uninstall nuitka
pip install -U "https://github.com/Nuitka/Nuitka/archive/develop.zip"

python -m nuitka --version
0.6.6rc5
Python: 3.5.4 (v3.5.4:3f56838, Aug  8 2017, 02:17:05) [MSC v.1900 64 bit (AMD64)]
Executable: C:\Python35\python.exe
OS: Windows
Arch: x86_64

python -m nuitka --follow-imports script_Run-SendFile_GUI-SIMPLE.py
Problem with <Node 'EXPRESSION_FUNCTION_BODY' with {'parameters': <ParameterSpec 'self,event'>, 'name': '_treeview_selected', 'code_object': <CodeObjectSpec Function '_treeview_selected' with 'self,event,selections,MyForm'>, 'flags': None, 'ref_name': 'PySimpleGUIQt$PySimpleGUIQt$$$function_146__treeview_selected', 'provider': 'PySimpleGUIQt$PySimpleGUIQt', 'doc': None}>
Problem with <Node 'COMPILED_PYTHON_MODULE' with {'module_name': <ModuleName PySimpleGUIQt.PySimpleGUIQt>, 'filename': 'C:\\Python35\\lib\\site-packages\\PySimpleGUIQt\\PySimpleGUIQt.py'}>
Traceback (most recent call last):
  File "C:\Python35\lib\site-packages\nuitka\__main__.py", line 184, in <module>
    main()
  File "C:\Python35\lib\site-packages\nuitka\__main__.py", line 177, in main
    MainControl.main()
  File "C:\Python35\lib\site-packages\nuitka\MainControl.py", line 757, in main
    main_module = createNodeTree(filename=filename)
  File "C:\Python35\lib\site-packages\nuitka\MainControl.py", line 141, in createNodeTree
    Optimization.optimize(main_module.getOutputFilename())
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 598, in optimize
    finished = makeOptimizationPass(initial_pass=False)
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 527, in makeOptimizationPass
    if optimizeVariables(current_module):
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 420, in optimizeVariables
    if optimizeUnusedUserVariables(function_body):
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 375, in optimizeUnusedUserVariables
    function_body.removeUserVariable(local_variable)
  File "C:\Python35\lib\site-packages\nuitka\nodes\FunctionNodes.py", line 227, in removeUserVariable
    assert variable in self.providing.values(), (self, self.providing, variable)
AssertionError: (<Node 'EXPRESSION_FUNCTION_BODY' with {'parameters': <ParameterSpec 'self,event'>, 'name': '_treeview_selected', 'code_object': <CodeObjectSpec Function '_treeview_selected' with 'self,event,selections,MyForm'>, 'flags': None, 'ref_name': 'PySimpleGUIQt$PySimpleGUIQt$$$function_146__treeview_selected', 'provider': 'PySimpleGUIQt$PySimpleGUIQt', 'doc': None}>, {'self': <ParameterVariable 'self' of '_treeview_selected'>, 'selections': <LocalVariable 'selections' of '_treeview_selected'>, 'event': <ParameterVariable 'event' of '_treeview_selected'>, 'MyForm': <LocalVariable 'MyForm' of '_treeview_selected'>}, <LocalVariable 'x' of 'listcomp'>)

Thanks,
George Hynes
09/17/1029 2:28pm ET

I managed to reproduce this with python3.7 bin/nuitka-run --recurse-to=PySimpleGUIQt Mini.py on my machine as well.

I managed to distill this minimal case out of PySimpleGUIQt.py.
def f():
    selections = 0
    [x for x in selections]

You might want to inform upstream that this is code is statically raising:
    def _treeview_selected(self, event):
        selections = 000000
        self.SelectedRows = [x for x in selections]

Nuitka says this:

Nuitka:DEBUG:m.py:4 : new_raise : Raising for use of 'iter' on type 'int'.

The issue appears that somehow Nuitka is convinced that for the Python3 list contraction variable, ownership is with the containing function, which is wrong. It normally doesn't cause issues, because these variables are not normally becoming unused, the iteration statically raising is probably the only scenario where that happens.

Ok, the issue seems to be that function variables and outline variables are handled the same way, but the code should not remove outline variables from their owner, but them outline only. With a change like that, it seems to be working.
I am putting this through some tests before pushing the fix.

Please check this out: https://nuitka.net/doc/factory.html it should be better.

Hi Kay,
thank you very much for the quick bug fix -it now works!
I am running the following:
pip uninstall nuitka
pip install -U "https://github.com/Nuitka/Nuitka/archive/develop.zip"

python -m nuitka --version
0.6.6rc5
Python: 3.5.4 (v3.5.4:3f56838, Aug  8 2017, 02:17:05) [MSC v.1900 64 bit (AMD64)]
Executable: C:\Python35\python.exe
OS: Windows
Arch: x86_64

Thanks,
George Hynes
09/18/2019 3:19pm ET

Just a tiny bit strange in that your instructions given from above would only work now that I merged it to develop branch as part of the pre-release rc6 I just made.

Your code is self-healing -it's that good! :smile: Hmmmmm... I think I had a typo in my comments (09/18/2019 3:19pm ET):
I indicated:
pip uninstall nuitka
pip install -U "https://github.com/Nuitka/Nuitka/archive/develop.zip"

-when it should have been (and what I now seem to recall doing):
pip uninstall nuitka
pip install -U "https://nuitka.net/doc/factory.html"

Thanks,
George Hynes
09/24/2019 2:01pm ET

Hello Kay,
everything has been working, but when I tried to create a "--standalone", it fails with AssertionError:

This works:
python -m nuitka --follow-imports test.py

This does not work (neither of them):
python -m nuitka --standalone test.py
Nuitka:WARNING:Use '--plugin-enable=qt-plugins' for: Inclusion of Qt plugins.
Traceback (most recent call last):
  File "C:\Python35\lib\site-packages\nuitka\__main__.py", line 184, in <module>
    main()
  File "C:\Python35\lib\site-packages\nuitka\__main__.py", line 177, in main
    MainControl.main()
  File "C:\Python35\lib\site-packages\nuitka\MainControl.py", line 766, in main
    main_module = createNodeTree(filename=filename)
  File "C:\Python35\lib\site-packages\nuitka\MainControl.py", line 141, in createNodeTree
    Optimization.optimize(main_module.getOutputFilename())
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 616, in optimize
    makeOptimizationPass(initial_pass=True)
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 530, in makeOptimizationPass
    changed = optimizeModule(current_module)
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 165, in optimizeModule
    optimizeShlibModule(module)
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 160, in optimizeShlibModule
    Plugins.considerImplicitImports(module=module, signal_change=signalChange)
  File "C:\Python35\lib\site-packages\nuitka\plugins\Plugins.py", line 128, in considerImplicitImports
    plugin.considerImplicitImports(module, signal_change)
  File "C:\Python35\lib\site-packages\nuitka\plugins\PluginBase.py", line 173, in considerImplicitImports
    for full_name, required in self.getImplicitImports(module):
  File "C:\Python35\lib\site-packages\nuitka\plugins\standard\ImplicitImports.py", line 770, in getImplicitImports
    for used_module in module.getUsedModules():
  File "C:\Python35\lib\site-packages\nuitka\nodes\ModuleNodes.py", line 899, in getUsedModules
    self._readPyPIFile()
  File "C:\Python35\lib\site-packages\nuitka\nodes\ModuleNodes.py", line 878, in _readPyPIFile
    assert imported.endswith(")")
AssertionError

python -m nuitka --standalone --plugin-enable=qt-plugins test.py
Nuitka:INFO:Injecting plug-in based post load code for module 'PyQt5.QtCore':
Nuitka:INFO:    Setting Qt library path to distribution folder. Need to avoid loading target
Nuitka:INFO:    system Qt plug-ins, which may be from another Qt version.
Nuitka:INFO:Injecting plug-in based pre load code for module 'PyQt5':
Nuitka:INFO:    Adding dist folder to 'PATH' environment variable.
Traceback (most recent call last):
  File "C:\Python35\lib\site-packages\nuitka\__main__.py", line 184, in <module>
    main()
  File "C:\Python35\lib\site-packages\nuitka\__main__.py", line 177, in main
    MainControl.main()
  File "C:\Python35\lib\site-packages\nuitka\MainControl.py", line 766, in main
    main_module = createNodeTree(filename=filename)
  File "C:\Python35\lib\site-packages\nuitka\MainControl.py", line 141, in createNodeTree
    Optimization.optimize(main_module.getOutputFilename())
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 616, in optimize
    makeOptimizationPass(initial_pass=True)
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 530, in makeOptimizationPass
    changed = optimizeModule(current_module)
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 165, in optimizeModule
    optimizeShlibModule(module)
  File "C:\Python35\lib\site-packages\nuitka\optimizations\Optimization.py", line 160, in optimizeShlibModule
    Plugins.considerImplicitImports(module=module, signal_change=signalChange)
  File "C:\Python35\lib\site-packages\nuitka\plugins\Plugins.py", line 128, in considerImplicitImports
    plugin.considerImplicitImports(module, signal_change)
  File "C:\Python35\lib\site-packages\nuitka\plugins\PluginBase.py", line 173, in considerImplicitImports
    for full_name, required in self.getImplicitImports(module):
  File "C:\Python35\lib\site-packages\nuitka\plugins\standard\ImplicitImports.py", line 770, in getImplicitImports
    for used_module in module.getUsedModules():
  File "C:\Python35\lib\site-packages\nuitka\nodes\ModuleNodes.py", line 899, in getUsedModules
    self._readPyPIFile()
  File "C:\Python35\lib\site-packages\nuitka\nodes\ModuleNodes.py", line 878, in _readPyPIFile
    assert imported.endswith(")")
AssertionError

test.py:
import PySimpleGUIQt as sg
This is on Windows 10 (64 bit):
python -m nuitka --version
0.6.6rc5
Python: 3.5.4 (v3.5.4:3f56838, Aug  8 2017, 02:17:05) [MSC v.1900 64 bit (AMD64)]
Executable: C:\Python35\python.exe
OS: Windows
Arch: x86_64

Here is how I installed the Python libraries:
pip install PySimpleGUIQt
pip install PySide2
pip install PyQt5
pip uninstall nuitka
pip install -U "https://nuitka.net/doc/factory.html"

Note: the pip install -U "https://nuitka.net/doc/factory.html" was done on 09/18/2019.
Thanks,
George Hynes
10/01/2019 4:24pm ET

Released as 0.6.6


java.lang.IllegalStateException: Fatal-Exception: You can't bind the FileDownloadService in :filedownloader process.

java.lang.IllegalStateException: Fatal-Exception: You can't bind the FileDownloadService in :filedownloader process.

Occur such exception, because you invoke FileDownloader#bindService() in the :filedownloader process. This might occur, for example, if you invoke Filedownloader#bindService() in your Application#onCreate directly without filter the ':filedownlader' process, because FileDownloadService running in the ':filedownloader' process by default, and in this case, Application#onCreate will be invoked in the ':filedownloader' process by system.

Alternative Solution

You can use any of the following solutions to resolve this problem

Invoke FileDownloader#bindService() in your Activity instead of Application
Invoke FileDownloader#bindService() in Application#onCreate but not in  ':filedownloader' process by !FileDownloadUtils#isDownloaderProcess(Context).
Set FileDownloadService running in the main process instead of the separate ':filedownloader' process through configurate process.non-separate=true in filedownloader.properties.

Entire message in this Exception:
Fatal-Exception: You can't bind the  FileDownloadService in :filedownloader process.
 It's the invalid operation  and is likely to cause unexpected problems.
 Maybe you want to use non-separate process mode for FileDownloader, More detail about non-separate mode, please move to wiki manually: https://github.com/lingochamp/FileDownloader/wiki/filedownloader.properties

thank you! you are  very helpfull!

Okey~


this should be your username

Much appreciated, super busy at the moment so didn't get a chance to look why it failed 👍


Adapter Training - Frozen transformer.wpe.weight?

https://github.com/bigscience-workshop/multilingual-modeling/blob/1a383288d89dafa16e462558a209e33a020ebe85/scripts/madx_exp/madx_lngembft_clm.py#L457
@vnikouliNLE It seems like we are not fine-tuning the positional embedding layers transformer.wpe.weight. I believe we should also train it too?

Yes we should train it.


Move Github/CI activity to public Slack channel

Moved GitHub to Slack. Personally don't care about CI (only look when about to merge the branch) so will leave for now.
Feel free to re-open if you disagree!


Customizable vm_types in cloud config

Similar to #28 but for vm_types; we need a way to be able to specific my how ephemeral disk a vm_type has - currently they all have 1 GB. Our concourse workers typically need about 100GB, and currently we have to edit the generated cloud_config and operate outside of bbl's visibility. We'd like a way to be able to choose the vm_types properties in such a way that bbl knows about them.

We should add the following vm_extensions:

5GB_ephemeral: {cloud_properties: {ephemeral_disk: size: 5120}}
10GB_ephemeral: {cloud_properties: {ephemeral_disk: size: 10240}}
50GB_ephemeral: {cloud_properties: {ephemeral_disk: size: 51200}}
100GB_ephemeral: {cloud_properties: {ephemeral_disk: size: 102400}}
500GB_ephemeral: {cloud_properties: {ephemeral_disk: size: 512000}}
1TB_ephemeral: {cloud_properties: {ephemeral_disk: size: 1048576}}

Sounds good. How will this impact the existing cloud_properties.ephemeral_disk? Does vm_extensions override this value?

This features is now available.


popup.html: Add suggestion box

popup.css: Add css style for the suggestion box
popup.js: Add code for dynamic suggestion
Created a dynamic suggestion box to provide suggestions to
the user
Fixes #47

screenshot

@djmgit Awesome that looks something really great. Thanks for the PR

Thankyou @djmgit merged the commits.

cool :)


Show a message on the docs v1.x website with a link to the latest documentation

Prepare two variants with the designer:

message on the header;
message outside the header.

Option 5 with cookies
or
Option 3 without cookies


Desktop_Viewer Scalable

The desktop viewer needs to be made scalable to fit inside of the window.

Added Via Merge
https://github.com/smasherprog/Remote_Access_Library/pull/32


V5 react transition group

Overview
This PR fixes various issues with Autocomplete, Popover, Positioner and removes react-transition-group in favor of a simpler useTransition hook.
Screenshots (if applicable)

Testing

[x] Updated Typescript types and/or component PropTypes
[ ] Added / modified component docs
[ ] Added / modified Storybook stories

Can potentially revisit this as an additive change.


ERROR HTTP 429

After a few pages of searching with the Google search engine, it started giving the
"ERROR HTTP 429"
and once this happens, it just keeps giving the same error for upcoming queries from the list.
I understand it may be because of so many search queries being searched, but is there any fix to work around it?

use vpn or rotating proxies

duplicate of #10


Build Instructions

Following the instructions in the readme for the http example:
cd ts/http
./build.sh

Results in:
-bash: tsc: command not found

It may be obvious that you need TypeScript installed to run TypeScript examples in a repos called ts :)
Perhaps consider adding instructions to install TypeScript for those who are new to the language.
npm install -g typescript

https://www.typescriptlang.org/


multiple env files support

Pixel 8 seems to have multiple formats for raw.
I have seen these two variants now:
PXL_20241030_145010658.RAW-01.COVER.jpg
PXL_20241030_145010658.RAW-02.ORIGINAL.dng
and:
PXL_20241030_143645718.RAW-01.MP.COVER.jpg
PXL_20241030_143645718.RAW-02.ORIGINAL.dng
And for my old Pixel 6 it generated images like this:
PXL_20230829_215158543.dng
PXL_20230829_215158543.jpg
So I need to have three different .env files and swap them around.
% head .env*
==> .env <==
IMMICH_LOG_LEVEL=DEBUG
IMMICH_API_KEY=*****
IMMICH_ENDPOINT=*****/api
IMMICH_MATCH=(PXL.*)\.(jpg|dng)$
IMMICH_PARENT=(PXL.*)\.jpg$

==> .env.mp <==
IMMICH_LOG_LEVEL=DEBUG
IMMICH_API_KEY=*****
IMMICH_ENDPOINT=*****/api
IMMICH_MATCH=\.(RAW\-01\.MP\.COVER\.jpg|RAW\-02\.ORIGINAL\.dng)$
IMMICH_PARENT=\.jpg$

==> .env.pixel8 <==
IMMICH_LOG_LEVEL=DEBUG
IMMICH_API_KEY=*****
IMMICH_ENDPOINT=*****/api
IMMICH_MATCH=\.(RAW\-01\.COVER\.jpg|RAW\-02\.ORIGINAL\.dng)$
IMMICH_PARENT=\.jpg$

PS. It would be nice to have a --dry-run parameter that would just print out what it will do for easier debugging

How is the regular expression working, the one for pixel 6 didn't match any images.
I want it to just search for images starting with "PXL"

Hi,
I just pushed a v1.4.0 release that has an IMMICH_READ_ONLY flag that you can set it the environment.
Supporting multiple envs is possible but I'm nervous about how they may conflict with each other and just cause chaos. This project is mostly a stop-gap solution waiting on the Immich devs to implement the feature as a 1st party into Immich so I'm slightly reluctant to incorporate complex business logic that they're likely already thinking about.
I've never tried to have both a prefix and suffix regex. The regex works by first matching image filenames, then removing the match groups from the filename, the filenames are then grouped up based on the new filenames, then whichever name would have originally matched the "parent" regex is marked as parent. Hopefully that makes sense.
I'm pretty certain you don't need the PXL_ prefix, I think the following should work
IMMICH_MATCH=\.((RAW-(01\.(MP\.)?COVER\.jpg|02\.ORIGINAL\.dng))|jpg|dng)$
IMMICH_PARENT=\.jpg$

or possibly even
IMMICH_MATCH=\.(.*(jpg|dng))$
IMMICH_PARENT=\.jpg$

I realized you can mix settings in .env and just set them as ordinary environment variables in the shell.
IMMICH_MATCH='.(jpg|dng)$' IMMICH_PARENT='.jpg$' IMMICH_READ_ONLY=true ./immich-stacker
So now my .env just contains the  serverr settings


Do not use environment variables by default - security issue

Please exclude support for environment variables in the templates (the .Env.* insertions according to the documentation). This can expose a lot of unintentional information (just run set in your shell to see what is available).
Preferred behaviour:

Change default value of --no-sys-env to true (or rename option).
Remove all support for system environments and only accept definitions from --env, --json or --load.

Simple work around is to add --no-sys-env parameter.

This will bring to backward compatibility problems, need update in next major version release.


Feature Request: Load Virtual Map dinamically

Right now if you want to use Virtual maps (for example for dungeon instances) you have to declare the maps in sphere.ini and Sphere loads all the maps at launch.
This is very resource consuming, a lot of RAM is needed to keep up a lot of virtual maps.
It would be better to load maps dinamically on request, so you can load a map when you need to use it and then you can free the memory when you not need the map anymore.

Uhm, if these virtual maps be empty (I meant no item, npcs in it except statics) this could be possible, but if not, when npcs try to move, they probably keep giving an error because haven't find any path to move. Also it seems a bit cheesy when you think about save system. Probably can add some functions to check if their map instance is loaded but seems like a huge work to fix all possible scenarios about it. Also npcs can drop down the maps when the map unloaded because there will be no Z to keep them up. It's only my guess but probably nolok can have better idea about it.

I explain my current dungeon instance system.
On sphere.ini i load 50 copy of map 0
Map6=7168,4096,-1,0,0
Map7=7168,4096,-1,0,0
...
Map55=7168,4096,-1,0,0
On scripts i declare all 50 virtual maps world like this
[AREADEF a_world_map_6]
EVENTS=r_default,r_default_rock,r_default_water,r_default_tree,r_default_grass
NAME=World
GROUP=ALLMAP
P=1323,1624,55,6
RECT=0,0,7168,4096,6
When a player enter a dungeon on map0:

i get a free (handled by db) virtual map to use for the instance.
I create a new file and write a copy of dungeon areadef(s) and dungeon teleports (between levels of the same dungeons) from map 0 to virtual map n
I copy all npcs and items spawns from map 0 to virtual map n (plus other items)

When the dungeon is over (and players are out of it) i delete all chars and items from map n.
I delete also the areadef file created for map n.
Now it would be nice to if i can load the virtual map when a player enter a dungeon on map0, create a file with the virtual map world areadef, delete the file and unload the virtual map when the dungeon is over. right now is not possible to do that because sphere loads the maps only when you start it.

It's a reasonable request, but it will require a non-trivial rework. I'll put that on X2 milestone


Minor text corrections.

Few potential corrections. I have possibly updated some things which may have been intentional, please review.

@jetfir3  thanks a lot


fix: preserve xml comments in decomposed files

What does this PR do?
preserves xml comments for decomposed metadata (we do xml => json , then merge in json, then json => xml).  fast-xml-parser was stripping out comments when converting to json.  this PR sets a comments property so that the converted json includes the comment (in a special field) and sets the same prop on the xmlBuilder so that the comment gets back into the xml.
What issues does this PR fix or reference?
@W-15544382@
https://github.com/forcedotcom/cli/issues/2830

QA Notes

✅ back out XML_COMMENT_PROP_NAME, yarn build, expect yarn test:snapshot to fail, it does

QA Notes

✅ : original QA
✅ : play around with the regex to confirm it's correct
✅ : remove the \s variations
✅ : multi line comments preserved
✅ : multiple multi-line comments not separated by xml content


Fixed basestring NameError in Python3

When installing pyre2 using pip3 and subsequently importing it, I get the following error message:
Traceback (most recent call last):
  File "./katc.py", line 3, in <module>
    from check import performRender
  File "/home/uli/dev/KATranslationCheck/check.py", line 28, in <module>
    from Rules import Severity, importRulesForLanguage
  File "/home/uli/dev/KATranslationCheck/Rules.py", line 4, in <module>
    import re2 as re
  File "re2.pyx", line 1, in init re2 (src/re2.cpp:13681)

This pull request fixes that by defining basestring globally in the pyx file if it is not defined (i.e. in python3)

Hm, I think https://github.com/axiak/pyre2/pull/33 also fixes this, so I'll close my PR


Support Vault integration in Istio 1.3

Describe the feature request
Before Istio 1.3, Istio uses normal k8s JWT in its SDS flows.
Istio 1.3 uses Trustworthy JWT, which, unlike normal k8s JWT, is not recognized on Vault.
Describe alternatives you've considered
Provide a flag in Istio 1.3 to choose whether using Trustworthy JWT or using normal k8s JWT.
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ X] Security
[ ] Test and Release
[X ] User Experience
[ ] Developer Infrastructure
Additional context

@lie-tang is trustworthy JWT supported in 1.2 ?

How will turning off trustworth JWT enable support for Vault? Trustworthy JWT is a mechanism to securely create and store jwt. Vault is a CA. They are not related to each other. Surely, using trustworthy JWT affects the Vault task on istio.io, but that task is just a simple toy example. Do we really expect users to run every service with the same identity?
cc @myidpt @costinm

@nixgadget Istio 1.2 uses normal k8s JWT.

This issue is not created to turn off trustworthy JWT. Under the section "Describe alternatives you've considered": Providing a flag in Istio 1.3 to choose whether using Trustworthy JWT or using normal k8s JWT is an alternative to keep the support of Vault integration (Istio 1.2 and 1.1 use normal k8s JWT and support Vault integration).
The task on istio.io provides an example that uses a k8s JWT for authentication, but it does not mean all services must use the same JWT for authentication: an user may configure multiple JWTs on Vault for issuing certificates with different identities and a service may use its own JWT to request a certificate.

@lei-tang trustworthy JWT support is now available under Vault 1.3.1 - https://github.com/hashicorp/vault/pull/7968#issuecomment-566581920

@rvasilevsf Thanks for the information!

@lei-tang So can I understand istio 1.3 or later release can support Vault integration (from Vault 1.3.1)?  If yes, when will the integration document ready? Thanks,

@hobbytp Since Istio 1.3 uses a new Kubernetes JWT, Istio Vault integration is no longer supported. We plan to add the support of Vault integration to Istio (the timeline is to be determined).

This issue is closed. A new issue https://github.com/istio/istio/issues/21961 is created to track the Istio Vault integration. Please feel free to share your use cases for Vault integration https://github.com/istio/istio/issues/21961. We hope to collect use cases of Vault integration and provide a solution meeting the requirements of representative use cases.


Update gfx942 HHS/BBS/F8BS NN/TN GridBased yamls for 1210 sizes

SWDEV-499456

LWPBLT-443

remove ticket number from PR title

remove ticket number from PR title

Done, thanks.

[----------] Global test environment tear-down
[==========] 50058 tests from 13 test suites ran. (749299 ms total)
[  PASSED  ] 50058 tests.
hipBLASLt version: 1200
command line: /opt/rocm/bin/hipblaslt-test


Accessing Data with JPA article needs improvements

The startup guide at Accessing Data with JPA requires some improvements. For example, there is no place for this paragraph in the write-up:

Normally you would add @EnableWebMvc for a Spring MVC app, but Spring Boot adds it automatically when it sees spring-webmvc on the classpath. This flags the application as a web application and activates key behaviors such as setting up a DispatcherServlet.

This is because that write-up is not about serving HTTP requests. It has nothing to do with serving content to the user. And there is no Spring boot starter web dependency on the classpath of the article.
Instead, it should be replaced with something like this:

Spring boot application will automatically enable @EnableJpaRepositories as it finds spring-boot-starter-data-mongodb on the classpath.

Something like that.

Fixed here: https://github.com/spring-guides/getting-started-macros/commit/5034bdddd8fb73b87ca7dea0d77dd2d921762ab6. Actually there is no content specifically on @EnableJpaRepositories, but please raise issues directly in the JPA guide repo if you think there should be.

Issue raised in its appropriate repo page.


Add a basic crafting system

Similar to #11, all crafting recipes should be configurable via config files.
Crafting recipes will also be gated by special blocks that the player need to use (such as a woodworking table, an anvil, and so on...), but we won't take that into account for now.
To-do list:

[x] Establish a suitable crafting config format
[x] Parse it into a bevy Resource
[ ] Add a basic crafting UI

Ideally we'd want to be able to write something like this:
// default quantity is 1
Stick, Rock: StoneAxe
// but we can also specify quantities (for the result too)
4 WoodPlank, 2 Iron: 16 Rails

In Json5 that would be:
[
  // there's no tuples and we can't use an array as a "key"
  [[Stick, Rock], StoneAxe],
  [[[WoodPlank, 4], [Iron, 2]], [Rails, 16]]
]

Which is kind of horrible to write ? I'm tempted to go with a handcrafted format here 🤔
The handcrafted format wouldn't be too hard to parse:

each line is a craft recipe
split on ':' to separate the ingredients from the result
another split on ',' to separate the ingredients
a last split on whitespace for each ingredient to get an associated quantity (or 1 by default)

Parsing code is a little ugly because I couldn't figure out a clean way to deserialize my nested enum other than wrapping it in '' and using json5::from_str(), but it works! I also wrote a function to filter out recipes that are not possible to make given an Inventory.

For the basic interface I think I'm just going to display available recipes when the player hits "C" or something, it should be a scrollable interface and when the player selects a recipe it should perform the craft.

UI code in Bevy is kinda bad at the moment, and I expect it to change in the near future, so I'm not going to spend a lot of time making it pretty, it's really going to be a basic ugly but functional craft interface.

The UX is very crude and items don't have pictures yet but the system is done.


Why the symbol "&" turned into "&" within RT Chat!

Hello,
Please review the whole issue here in MyBB community board:
https://community.mybb.com/thread-240651-post-1393143.html#pid1393143

That issue has been fixed in version 1.5


Eliminate "zii" dependency

Having zii pulled in makes it so that IPFS can't be combined into the same project as ssb-conn.  Reported upstream here:
https://github.com/multiformats/js-multibase/issues/80
...but I'm not sure they can fix this well without breaking their API, so it would be better if zii could be eliminated from this project.  It's too wide-reaching, and I could see it causing other odd corner cases in other places in the future.

By the way, the reason for trying to use IPFS is so that I can do this:
https://github.com/arj03/ssb-browser-demo/issues/198

Yeah I'm inclined to replace zii with something else

Cool.  It does look like it simplifies things and keeps code short.  It's just that, unfortunately, it has side effects.

Solved with https://github.com/staltz/ssb-conn/commit/ec2a2661f534fb6b87628d0ccd6204270a611af3

Version 2.0.2 should solve this


chore(ci): Fix bad parent commit in .gitrepo

Fix bad parent commit, it seems to have gone backwards in time.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

This should be closable


feat(clerk-js): Lazy load clerk ui components

Lazy loading our own components inside the clerk-js bundle, decreases the bundle size by 10% from 185KB to 165KB
Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[x] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

Lazy loading our own components inside the clerk-js bundle, decreases the bundle size by 10% from 185KB to 165KB

Hey @panteliselef
How does the window.Clerk.openUserProfile ( and the other similar methods that open modals) behave with the suggested changes?
I'd expect the modal backdrop to show and then a slight delay before the actual Clerk component actually appears. Is this the case?  Do we need to fall back to a loader maybe?
Also, how does this affect the build artifacts? I expect that we now have more chunks built by webpack - we should discuss if and how this affects our CDN at all

I'd expect the modal backdrop to show and then a slight delay before the actual Clerk component actually appears. Is this the case? Do we need to fall back to a loader maybe?

@nikosdouvlis The modal opens the same way as the one in production. I used dashboard.clerk.dev for comparison.
https://user-images.githubusercontent.com/19269911/218998714-e4727798-db13-41a4-b014-29a794e4dc38.mp4

Also, how does this affect the build artifacts? I expect that we now have more chunks built by webpack - we should discuss if and how this affects our CDN at all

@nikosdouvlis I am not familiar with this process. But we could investigate that offline, in a private call

Also, how does this affect the build artifacts? I expect that we now have more chunks built by webpack - we should discuss if and how this affects our CDN at all

@nikosdouvlis I am not familiar with this process. But we could investigate that offline, in a private call

You can start by running npm run build -w @clerk/clerk-js locally and see the output of the dist folder. Chunks need to be unique per build and include cache busters.

@SokratisVidros I recorded 2 versions. One without fallback and second with a string as fallback. (Shot on Slow 3G)
https://user-images.githubusercontent.com/19269911/219008005-a180372a-d7de-4f06-a2ea-f223b999bad5.mp4
https://user-images.githubusercontent.com/19269911/219008062-ecbe4520-8707-4fca-8a22-54fd671c41f0.mp4

@nikosdouvlis  @SokratisVidros These are the assets generated by webpack.

Thanks a lot @panteliselef.
I'd suggest to use webpackChunkName directive along with some webpack configuration to set a component prefix to each chunk along with a random hash that follows it and changes across builds.
https://www.codemzy.com/blog/how-to-name-webpack-chunk

I'd suggest using the webpackChunkName directive along with webpack configuration to set a component prefix to each chunk name followed by h a random hash that is unique across builds.
@SokratisVidros

We are closing this PR in favour of #879
#879  is WIP but contains all the changes made by this PR. We kept postponing merging this changes on main due to other issues with higher priority.


Showing a load symbol while some action is performed after a button is clicked

Description
I am using a button as an interactive component in a message. After the button is clicked I perform some functionality in the background and then I change the initial message and remove the button. Is it possible to show some kind of loading circle (or anything else, that shows that there is an ongoing process) in the button, while the background stuff happens?
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Hi @CreativLul, thanks for writing in!
If the message is posted using chat.postMessage API, you can use chat.update API with the message's channel + ts to change its appearance.

perform chat.postMessage API call to post the message with button
user clicks the button -> block_actions event delivery (app.action listener is called) -> call chat.update API with "loading ... " message
do the things asynchronously
perform chat.update API call again with a message data telling the result

If you use response_url (respond() utility in bolt) to post the first message, you can use respond() instead of chat.update API calls.
I hope this helps.

Thanks for your advice! That's a great idea.


CI: reuse workflow [wip]

What does this PR do?
Fixes #<issue_number>
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

I want to use the reusable workflow in our CI but seems it does not work for PR. I have followed the example in docs:
https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow
and the only change I made is to update the triggers in the second workflow to be:
on:
  - push
  - pull_request

with the following error message:
Invalid workflow file : .github/workflows/ttt2.yml#L1
The workflow is not valid. PyTorchLightning/metrics/.github/workflows/ttt1.yml@fa65582b43a1f7105fe98e9b6d41b210747ebab4: Expected document st

in fact, for the same commit, the action triggered by push pass and the one with PR fails

an alternative could be using composite steps: outputs for composite actions

it was admitted as an issue on the GH side and will be taken care of it...

Just got message that this issue was fixed and seems to be working correctly now


Update Appendix: Instructions for manual testing

an extract of the relevant instructions from the website
I tried to minimise repeating the UG unnecessarily, but it's kinda at odds with the previous point on "no need to give a long list of test cases"

Codecov Report

Merging #198 (a7f0c00) into master (aad177c) will increase coverage by 0.86%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
+ Coverage     73.26%   74.13%   +0.86%
- Complexity      584      599      +15
============================================
  Files            94       94
  Lines          1803     1848      +45
  Branches        232      245      +13
============================================
+ Hits           1321     1370      +49
+ Misses          403      398       -5
- Partials         79       80       +1

Impacted Files
Coverage Δ

...du/address/logic/commands/CreateFolderCommand.java
92.00% <0.00%> (-8.00%)
:arrow_down:

.../seedu/address/logic/parser/FindCommandParser.java
100.00% <0.00%> (ø)

...address/logic/parser/FindFoldersCommandParser.java
100.00% <0.00%> (ø)

...in/java/seedu/address/commons/util/StringUtil.java
96.87% <0.00%> (+0.87%)
:arrow_up:

.../address/logic/commands/EditFolderNameCommand.java
72.41% <0.00%> (+5.74%)
:arrow_up:

.../seedu/address/logic/parser/AddressBookParser.java
85.71% <0.00%> (+22.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad177c...a7f0c00. Read the comment docs.


[CI] Add schedule event trigger to binary build workflow

Stack from ghstack (oldest at bottom):

#344
-> #343

Summary:
Add schedule event trigger to automate the nightly binary build.
Test Plan:
Can't really test this as it's a scheduled event.
Ran a manual trigger on this PR as a proxy for correctness though -- find the latest successful run here.

Codecov Report
Base: 93.39% // Head: 93.39% // No change to project coverage :thumbsup:

Coverage data is based on head (bf235d2) compared to base (905cfbd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           gh/langong347/64/base     #343   +/-   ##
======================================================
  Coverage                  93.39%   93.39%
======================================================
  Files                         54       54
  Lines                       3253     3253
======================================================
  Hits                        3038     3038
  Misses                       215      215

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@langong347 has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.

@langong347 has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.

@langong347 has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.