[YUNIKORN-970] Add queue metrics with queue names as labels

What is this PR for?
Add duplicate Prometheus queue metrics with queue name in label instead of in the subsystem (which results in a metric emitted per queue). This allows us to ingest metrics with a uniform name per metric and use label to differentiate between queues. Eventually we will remove the subsystem metrics and only have metrics with queue labels
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-970
How should this be tested?
Unit Test:
will@mac ~/code/yunikorn-core (YUNIKORN-970) $ make test
running unit tests
"go" clean -testcache
"go" test ./... -race -tags deadlock -coverprofile=build/coverage.txt -covermode=atomic
?       github.com/apache/yunikorn-core/cmd/queueconfigchecker  [no test files]
?       github.com/apache/yunikorn-core/cmd/schedulerclient     [no test files]
?       github.com/apache/yunikorn-core/cmd/simplescheduler     [no test files]
?       github.com/apache/yunikorn-core/pkg/entrypoint  [no test files]
?       github.com/apache/yunikorn-core/pkg/examples    [no test files]
?       github.com/apache/yunikorn-core/pkg/handler     [no test files]
ok      github.com/apache/yunikorn-core/pkg/common      1.322s  coverage: 67.5% of statements
?       github.com/apache/yunikorn-core/pkg/rmproxy     [no test files]
?       github.com/apache/yunikorn-core/pkg/rmproxy/rmevent     [no test files]
ok      github.com/apache/yunikorn-core/pkg/common/configs      1.458s  coverage: 94.5% of statements
ok      github.com/apache/yunikorn-core/pkg/common/resources    1.527s  coverage: 93.2% of statements
ok      github.com/apache/yunikorn-core/pkg/common/security     1.644s  coverage: 86.5% of statements
ok      github.com/apache/yunikorn-core/pkg/events      1.712s  coverage: 99.5% of statements
?       github.com/apache/yunikorn-core/pkg/scheduler/placement/types   [no test files]
?       github.com/apache/yunikorn-core/pkg/webservice/dao      [no test files]
ok      github.com/apache/yunikorn-core/pkg/log 8.984s  coverage: 86.7% of statements
ok      github.com/apache/yunikorn-core/pkg/metrics     4.760s  coverage: 57.4% of statements
ok      github.com/apache/yunikorn-core/pkg/metrics/history     1.775s  coverage: 100.0% of statements
ok      github.com/apache/yunikorn-core/pkg/plugins     1.762s  coverage: 60.0% of statements
ok      github.com/apache/yunikorn-core/pkg/scheduler   4.568s  coverage: 65.8% of statements
ok      github.com/apache/yunikorn-core/pkg/scheduler/objects   15.058s coverage: 83.6% of statements
ok      github.com/apache/yunikorn-core/pkg/scheduler/objects/template  1.341s  coverage: 80.6% of statements
ok      github.com/apache/yunikorn-core/pkg/scheduler/placement 1.257s  coverage: 90.6% of statements
ok      github.com/apache/yunikorn-core/pkg/scheduler/policies  1.298s  coverage: 100.0% of statements
ok      github.com/apache/yunikorn-core/pkg/scheduler/tests     41.290s coverage: 71.4% of statements
ok      github.com/apache/yunikorn-core/pkg/scheduler/ugm       1.321s  coverage: 93.1% of statements
ok      github.com/apache/yunikorn-core/pkg/trace       1.402s  coverage: 94.4% of statements
ok      github.com/apache/yunikorn-core/pkg/webservice  1.291s  coverage: 81.0% of statements

Queue metrics with with queue in label example:
will@mac ~/code/yunikorn-core (YUNIKORN-970) $ curl localhost:9080/ws/v1/metrics 2>/dev/null | grep queue-small
yunikorn_queue_app{queue="root.queue-small",state="accepted"} 1
yunikorn_queue_app{queue="root.queue-small",state="completed"} 1
yunikorn_queue_app{queue="root.queue-small",state="released"} 6
yunikorn_queue_app{queue="root.queue-small",state="running"} 0
yunikorn_queue_resource{queue="root.queue-small",resource="memory",state="allocated"} 0
yunikorn_queue_resource{queue="root.queue-small",resource="memory",state="pending"} 0
yunikorn_queue_resource{queue="root.queue-small",resource="pods",state="allocated"} 0
yunikorn_queue_resource{queue="root.queue-small",resource="pods",state="pending"} 0
yunikorn_queue_resource{queue="root.queue-small",resource="vcore",state="allocated"} 0
yunikorn_queue_resource{queue="root.queue-small",resource="vcore",state="pending"} 0

Queue metrics with queue in subsystem example:
will@mac ~/code/yunikorn-core (YUNIKORN-970) $ curl localhost:9080/ws/v1/metrics 2>/dev/null | grep queue_small
# HELP yunikorn_root_queue_small_queue_app Queue application metrics. State of the application includes `running`.
# TYPE yunikorn_root_queue_small_queue_app gauge
yunikorn_root_queue_small_queue_app{state="accepted"} 1
yunikorn_root_queue_small_queue_app{state="completed"} 1
yunikorn_root_queue_small_queue_app{state="released"} 6
yunikorn_root_queue_small_queue_app{state="running"} 0
# HELP yunikorn_root_queue_small_queue_resource Queue resource metrics. State of the resource includes `guaranteed`, `max`, `allocated`, `pending`, `preempting`.
# TYPE yunikorn_root_queue_small_queue_resource gauge
yunikorn_root_queue_small_queue_resource{resource="memory",state="allocated"} 0
yunikorn_root_queue_small_queue_resource{resource="memory",state="pending"} 0
yunikorn_root_queue_small_queue_resource{resource="pods",state="allocated"} 0
yunikorn_root_queue_small_queue_resource{resource="pods",state="pending"} 0
yunikorn_root_queue_small_queue_resource{resource="vcore",state="allocated"} 0
yunikorn_root_queue_small_queue_resource{resource="vcore",state="pending"} 0

Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Please address the lint issue also, you can run make lint locally on you branch to check.

LGTM, merging it, thanks Will!

@WilliamTom please resolve merge conflicts. Thanks.

+1 LGTM. There are some coverage issues due to methods being unused completely. I'll file a follow-up JIRA to address that.


Create from inferred usage

For reference, here's the work-in-progress from our live stream today. I'll update this thread as I finish these todos.
Current State

Todos

[ ] Don't suggest for unresolved type references - only for value functions (for this PR, revisit in the future)
[ ] Don't suggest fix for qualified references
[ ] Make sure cursor focus goes through argument names so you can tab through to change them

Make declaration fix does it
It's called a Template (see TemplateManager)

[ ] Add newline for proper formatting for creating function
[ ] Location - insert it right below call site function body, not at bottom

Maybe now, maybe defer?

[ ] Infer types based on values passed in?
[ ] Use argument template names based on types, like create from declaration?

A fun reference, Kolja shared this PR with me where he implements the same functionality for the Elm languages server:
https://github.com/elm-tooling/elm-language-server/pull/319

This will fix #661

Hi @dillonkearns ! I took over the stewardship of this repo. I find this PR nice to merge. Do you want to address the point @ajalt made and extend on this feature before I merge it?


Replace MD5 with Blake2b

MD5 is broken.  It is easy to generate collisions – that includes chosen-prefix chosen-suffix collisions.
Blake2b is the best answer.  It provides maximum possible security for the size of its hash, has builtin support for keying, personalization, and tree hashing, and is even faster than MD5.

There is no need to replace MD5 (or SHA1). Actually we can't replace them, because outside of security, there still are legitimate uses (eg. UUID v3 and v4). Furthermore BLAKE2 is designed for 64bits, while we support 32bits  arch's too.
Also, you should already be capable to use BLAKE2b:
hash = OpenSSL::Digest.new("blake2b")
hash << message

But isn't BLAKE2b outputting 512 bits digests, and BLAKE2s a 256bits digest? This is still 4x and 2x as big as MD5.

Still, MD5 is obsolete and the Crystal developers should not be encouraging
its use.  Perhaps place it in crypto/obsolete?
On Jun 4, 2016 1:59 AM, "Julien Portalier"<EMAIL_ADDRESS>wrote:

There is no need to replace MD5 (or SHA1). Actually we can't replace them,
because outside of security, there still are legitimate uses (eg. UUID v3
and v4). Furthermore BLAKE2 is designed for 64bits, while we support 32bits
arch's too.
Also, you should already be capable to use BLAKE2b:
hash = OpenSSL::Digest.new("blake2b")
hash << message
But isn't BLAKE2b outputting 512 bits digests, and BLAKE2s a 256bits
digest? This is still 4x and 2x as big as MD5.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/crystal-lang/crystal/issues/2743#issuecomment-223738711,
or mute the thread
https://github.com/notifications/unsubscribe/AGGWBzEM5LoAtGNKb3uf2YRPBpikTOO7ks5qIRREgaJpZM4IuDa1
.

Errata: BLAKE2 support is only expected for the next OpenSSL release (v1.1.0).
We're not encouraging anything. Neither MD5 nor SHA1 shall be use for cryptographic purposes. One should use SHA2, SHA3 or BLAKE2, or a higher level cryptography algorithm that makes good use of those lower level algorithm (eg: ARGON2, that leverages BLAKE2). Still, being broken for cryptography and security doesn't prevent other, non cryptographic, uses of MD5 and SHA1, like UUID v3 and v5.

Yes, I'd like to see the place in our documentation where we encourage usage of it. Please don't mistake acknowledging widespread use for encouragement.

We could highlight in the documentation that MD5 is broken for cryptographic purposes and musn't be used for anything related to security. We could do the same for SHA1, with the slight difference that it's almost broken, and that one is encouraged to use SHA2, SHA3 or BLAKE2 instead, or just not deal with cryptography and use strong and proven algorithms only, or just: use libsodium :D
Those statements wouldn't hurt, quite the opposite.

FWIW the Crystal Docker image doesn't seem to have an OpenSSL version that supports...anything other than MD5 and SHA1.


Add bower support

Hi,
Neat fix for clearing floats in the new Bourbon Neat. Question, will you add bower support any time soon?
Thanks!

@webdevsuperfast -
I just published v2.0.9, which includes expanded documentation and bower support. Please let me know if you have any questions or run into issues.

Thanks!


Added unit tests for Orbit.

Also fixed Orbit not starting with slide with is-active class.
@kball

Sweet!


The mobile demo view in Quasar documentation is truncated

In Quasar documentation, the mobile demo view on the right of each page is truncated on my screen (1280 * 1024 px). I have to zoom out (90%) to reach the "View source" and "Desktop view" buttons.
This behaviour was not present a week or two ago when I discovered Quasar.

Do you have a screenshot please? It looks fine for me.
Also, please open a bug for the doc website on https://github.com/rstoenescu/quasar-site repo only. Will keep this opened here today though.

Added this issue in quasar-site repo : https://github.com/rstoenescu/quasar-site/issues/3

Closing issue here since opened on doc repo.


Expose nginx logs to web gui

Hello,
I've been using this project for a couple of months now, but only just noticed that the nginx logs aren't presented to the GUI.
I think it would be very useful for both error and access logs to be presented both in a 'everything' view and a per host view.  That way I can keep an eye on whether/how much unauthorised access is being attempted (for example if I exposed my NPM to the internet, which I may do soon).
I just noticed this now as I've started using access lists and for some reason my machine is bein denied even though it's in a subnet I've allowed, so I was trying to diagnose that but have no logs to hand to do so.
Thanks and all the best, James.

Being able to change the log level and what is being logged would also be very useful


Release graph-node v0.32.0-rc.0 to testnet

Holding back from merging this since we have a bug fix more to include in the release


Add notebook links to scivision web

Can we have links in the model (or dataset) entries on the frontend to "scivision gallery" notebooks, both static on GH and Binder

Currently, two hardcoded links to notebooks on the front page.  Follow up in other issues, e.g. #391


Padding bottom

Can I add some space between the greenish container and the two buttons?

Fine.
A little bit.


Nomenclature of "request" is confusing

I think Request is very common in the PBFT/Consensus focused literature. See, e.g., http://pmg.csail.mit.edu/papers/osdi99.pdf
I think in blockchain-land, the word Transaction is predominantly used for the same thing.


Investigate Progressive Web Application

Initial discussion around thoughts on implementing a PWA approach to the application so that we can support more offline scenarios, install icon on the phone and use phone features where applicable.
The current Cordova app has not been developed in some time and the tooling is now fairly unsupported.
We need a solution to build out volunteer management pages to view work items and mark progress as requests are completed.
/cc @tonysurma @BillWagner @RichardCampbell

Are the thoughts that it would be separate web app focused on the use cases required for the field user e.g. itinerary, appointment management, task completion. This might be easier to manage and develop rather than bundling all this logic into the existing web app?

@shahiddev All up for discussion I think as I must confess I'm not sure how PWAs are best designed. Certainly the bits we most need don't yet exist and need to be added around volunteers closing tasks etc.

@stevejgordon @shahiddev With PWA's you are limiting yourself to Android only, not sure about Windows Phone. They aren't supported on iOS at the moment though there has been an indication from Apple they are considering it.

@naeemsarfraz - Yeah but who uses Apple products! Windows phone is where it's at!! :-)

I think the ethos behind PWAs is that they should progressively enhance so at worst on the Apple devices there should still be a very usable mobile web app, I believe windows mobile do support PWAs . Apple might be dragging their heels (they want to protect their App Store revenues after all) but I'm in the same camp as @RichardCampbell  and others where the app store lifecycle is just too cumbersome (there is also the discoverability issue but less of a problem for AllReady).

@tonysurma @RichardCampbell @BillWagner
Hi guys, do you have anything to add to this discussion?

@tonysurma @RichardCampbell @BillWagner a friendly nudge to follow up on this ticket. Any thoughts?

Until Apple fully supports PWAs you can get a bit of that functionality (the icon part) on iOS through Web Clips.


Compilation fail due to RNNetworkInfoPackage is not abstract and does not override abstract method createJSModules() in ReactPackage

react-native-network-info/android/src/main/java/com/pusherman/networkinfo/RNNetworkInfoPackage.java:14: error: RNNetworkInfoPackage is not abstract and does not override abstract method createJSModules() in ReactPackage
public final class RNNetworkInfoPackage implements ReactPackage {
^
1 error
:react-native-network-info:compileReleaseJavaWithJavac FAILED

This error may occur if you use a RN version 0.46 or lower with version 3.X of this library. You need to switch to 2.X as stated in the Readme


FAQ

can you describe difference and advantage to git fetch --prune ?

It is already described here: https://github.com/foriequal0/git-trim#gits-pr-workflow-is-a-little-bit-tedious-as-a-routine
git fetch --prune only deletes remote refs (refs/remotes/...) that disappeared from the remotes.
It doesn't touch local branches that track the remote refs when the remote refs are merged into the branch or deleted by somehow. You should manually delete local branches in that case.

I'll add shorter description soon. It takes time to write since English is not my mother tongue.

Thanks, sorry that I missed there.


Updated construct circuit unit tests for QuantumKernel

Summary
This PR slightly changes the unit tests that test QuantumKernel.construct_circuit(). Closes #149.
Details and comments
Instead of testing the size of the output circuits, these tests check for the number of qubits, feature map operations, optionally if measurement operations are applied and inversibility of the feature maps if only one vector is passed. Should be better than the original tests.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 83.809%

Files with Coverage Reduction
New Missed Lines
%

qiskit_machine_learning/datasets/gaussian.py
3
36.27%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
2847

Relevant Lines:
3397

💛  - Coveralls


Add pride_deno.gif to deno.land/artwork

This PR Adds a GIF of the Deno seen on document page cycling through LGBTQ+ Flags.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


On-cluster build: Direct code upload

Upload the local code to the cluster and there intiate build. This will not use Git, but the code will be uploaded to the cluster, similar to s2i binary build.

/remove-lifecycle stale

/assign @jrangelramos

/assign @matejvasek


REQUIRED: Support for transpileOnly - not really an option

Question
@samchon
First of all, the general idea and what you have done is great.  Do not get me wrong. However, this is not really useable in a realistic environment where it might be useful.
I may be doing something wrong here, of course.

Dev Experience becomes terrible.
Can not use transpileOnly which means to test your code without building you need to compile the entire application multiple times for every change.
You can not test with type errors because of this... our project is a monorepo with hundreds of thousands of lines of code and it is causing a bunch of type errors i otherwise would not have ... unless I turn off skip lib check

[12/06 12:46:56:323 pm] | [ ERROR   ] | CRITICAL | uncaughtException
  |>  src/core/models/userWalletsMap.ts:28:10 - error TS2564: Property 'userId' has no initializer and is not definitely assigned in the constructor.
  |
  |   28   public userId: number;

I get around 25,000 errors in our project (which runs and compiles fine otherwise) when trying to make this work by turning off transpileOnly to run in a development environment.
This file is a Sequelize type -- the userId is supplemented at compile time by the sequelize-typescript decorator which makes it valid.  Since we skipLibCheck (otherwise it wont compile ever and will take 1,000x longer literally when it does), it fails at runtime
Basically - unless you want to compile every change to test code -- this is a fairly useless package.
I guess the only solution would be to isolate ALL use of this module to export factory functions and compile those... but then your ts files are importing javascript files which is another problem so not sure how that would work.
Basically instead of halt this package should detect transpile only and perhaps instead implement non-optimized code (JSON.stringify()) since we know at compile time it will work as expected

25,000 type errors are your problem, not of `typescript-json.
Also, you don't need to entire source compilation whenver code being updated, if you utilize watch mode compilation

npx ttsc --watch

You are not understanding the situation.  We use transpileOnly because it is the RIGHT thing to do.
The point is it is giving errors that do not exist in reality
The error I bring up above... that is not an error that occurs normally
I can compile just fine
yarn build:all

works just fine
this only happens when trying to use ts-node and compile at same time
https://typestrong.org/ts-node/docs/options#transpileonly
they even directly mention to use transpileOnly during dev in docs
https://typestrong.org/ts-node/docs/performance

To be clear - there are zero type errors in our project ... unless trying to run things as this requires us to.
I can compile and run with your module no issues... but it requires we undo all development environment optimizations in order to use it at all

I'm sorry but supporting transpileOnly option is totally impossible.
Therefore, only two way left:

Change your dev environment to use JS file built by watch mode compilation
Do not use typescript-json


Lowered the windbarbs density on NW-large domain.

Lowered the windbarbs density on NW-large domain requested by Ravan.

Thanks for your comment, Craig!
This is the "before" windbarb field.

This is the "after" windbarb field.

Great! thanks!  Looks like it's all set.


Do you have infix to Prefix bison code

no, the repository includes programs which I did during my coursework.


[Snyk] Security upgrade next from 11.1.4 to 12.0.9

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

frontend/kesaseteli/handler/package.json

⚠ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

713/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 6.4
Prototype Pollution SNYK-JS-JSON5-3182856
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution

Codecov Report

Merging #1665 (232c080) into develop (a4f1222) will increase coverage by 20.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #1665       +/-   ##
============================================
+ Coverage    65.92%   86.17%   +20.24%
============================================
  Files         1050       31     -1019
  Lines        29010      463    -28547
  Branches      2972      107     -2865
============================================
- Hits         19126      399    -18727
+ Misses        9436       61     -9375
+ Partials       448        3      -445

Impacted Files
Coverage Δ

.../migrations/0005_employee_is_living_in_helsinki.py

frontend/tet/shared/src/components/MapScripts.tsx

frontend/tet/shared/src/components/map/Map.sc.ts

backend/benefit/users/models.py

...ared/src/components/pages/PageLoadingSpinner.sc.ts

frontend/kesaseteli/youth/src/pages/_document.tsx

...028_add_encrypted_handler_and_original_vtj_json.py

frontend/tet/admin/src/pages/editstatic.tsx

...nts/application/summary/EmploymentFieldSummary.tsx

backend/benefit/applications/models.py

... and 1009 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Added workaround to avoid double dollar signs not rendering properly

Bug fix for issue #31
Avoids the issue where double dollar signs inside of text are interpreted by the math rendering system built into Jupyter as LaTeX inline math delimiters, causing improper rendering of text. @frreiss

LGTM. Merging.


Add WSO2-2023-2617 into 2023 Advisory Directory

Copy of "WSO2-2023-2617" is added into 2023 Advisory Directory to align with reference url that has been given via WSO2 products carbon console warning.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Change FSMLITE_FSM_HPP to FSMLITE_FSM_H

As per title... or use #pragma once .

Missed that, thanks! Regarding #pragma once see https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf8-use-include-guards-for-all-h-files


Modify Claim page texts

Change texts
"Learn more" should link to the right web3 page (opens as a new tab).
Claim button / counter should have animation between them.

https://xd.adobe.com/view/de38141d-5ce7-4f4f-43b0-4ae9511ad727-a809/

Verified as Done.
Devices:
iPhone 6S // iOS 12.4
Mi 8 Lite // Android 10


Syntax Errors in Node v0.10.x

We would like to use Regiment in Node v0.10.x, but it crashes node on startup due to syntax errors... I think it is because Node v0.10 doesn't support ECMAScript 2015.  If it won't work in Node v0.10 or v0.12, I'd like to suggest that you update the readme to reflect that.

Yep, that is correct. It shouldn't even install, I specified { engines: { node >= 4.0.0 } } in package.json for that reason but I will add a note to the README as well, thanks!


REACT_APP_* custom variables in .env* are undefined in development

Is this a bug report?
yes
Can you also reproduce the problem with npm 4.x?
It's not an npm or yarn error
Which terms did you search for in User Guide?
custom environment variables
Environment

node -v: 8.6.0
npm -v: 5.5.1
yarn --version (if you use Yarn): 1.3.2
npm ls react-scripts (if you haven’t ejected): 1.0.17

Then, specify:

Operating system: macOS 10.11
Browser and version (if relevant): chrome

Steps to Reproduce
As the documentation specified, front end environment variables can be defined by exporting them to the terminal, defining them on the start script of with a .env file on the root.
My create-react-app is nested inside a backend express app with its own .env. However, I have a .env in the root of my front end app with REACT_APP_HOST=localhost.
In App.js, I console.log(process.env) and the only keys displayed are
{ NODE_ENV: 'development', PUBLIC_URL: '' }

It seems like its working for most other users and it may be that my app is nested but I'm unsure as to why environment variables defined in my .env are not showing up.
// .env
REACT_APP_HOST=localhost

// App.js
....
componentDidMount() {
    console.log(process.env);
}

// app structure
- fullApp
   - create-react-app
      - components
         - App.js
      - .env
   - index.js
   - .env

<EMAIL_ADDRESS>

It doesn't look up your directory tree into fullApp/.env. The only file it reads is fullApp/create-react-app/.env.

If you exported REACT_APP_HOST in your shell, that overrides any .env setting as well.

I have not. In fact, process.env does not have any custom react vars when I log it out

Actually I have found out the reason why.
I did not realize that the environment variables are injected in build-time. (Don't know why I assumed they would be accessible in dev)
Thanks for your help though.

So you can't use them in development ?!?

Yes, you can. Are you experiencing behavior otherwise? If so, please file a new issue.

Having the same problem on my hackintosh (OSX 10.11.6)
node: v10.3.0
npm: 6.4.1
react-scripts: 2.0.4
But the same project/code does work on my MacBook Pro (macOS 10.13.6)
node: v10.1.0
npm: 6.4.1
react-scripts: 2.0.4

@jeroenhoebe  I am having the same thing em MacBook here!

Re-starting the server may resolve the issue for most (If .env files were created while server was running)
control + c to stop the server
yarn start to start the server

Having a similar issue with .env.development and .env.production custom env files - REACT_APP* env vars are undefined in my React code.
However, .env is working properly and my REACT_APP* env vars are properly exposed in my React code.
mac OS High Sierra v 10.13.6
node: v 8.11.2
npm: v 5.6.0
react-scripts: v 2.1.1
Additionally, I can verify the existence of these three files and their env var values via $cat .env.development and $cat .env.production and $ cat .env
This CRA app is a nested React app inside a node/express server directory.  There are no .env, or .env* files in the root server directory.  The .env, .env* files are in the root CRA app directory only.
Restarting server, closing IDE or clearing Browser cache does not remedy things.


Default extensions location

IMO we should move plugins shipped with Saleor from saleor.extensions.plugins into saleor directory. Having it this way suggests it's default plugin directory and Saleor forks will end up having one, big extensions app.
@korycins Whats your opinion?

@krzysztofwolski, It sounds good but I am not sure if we don't want to extract all plugins into separate packages.
@maarcingebala  Do we want to extract all plugins or only Payment plugins?

I don't think it's an issue to have plugins in one directory; otherwise we would have one big saleor directory with mixed plugins and pure Django apps, which is worse in my opinion.
We definitely wanted to move payment gateways outside. As for other plugins, I think we need to wait until we implement more of them and we have a clear and stable structure.

Sure, lets lee how it turns out 👍.
I'll go with 'all in apps' approach and provide feedback later.
BTW Are there plans for having tests inside plugin folder or we have to wait for migrating whole project into changed tests structure?


Name of the file automatically changes in s3 when i upload

Name of the file automatically changing in s3 when i upload
example : file name in local = mypic.jpg
In s3 bucket it is showing  3a139e01-b2f9-4300-92f7-0e13956775c8.jpg
I dont want it to be encrypted ,i want my file name to be same as local in s3

Set the unique_name flag to false or set upload_name on your file object

thankyou :)


Add missing lines to ModelAnimation documentation

The animationTime documentation was missing a line in ModelAnimation and ModelExperimentalAnimation that caused it to appear under the global documentation instead of the animation classes. This PR fixes that.
I also made a minor adjustment to a code example so it looked nicer in the documentation.

Thanks for the pull request @j9liu!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

@j9liu looks good, thanks!


[BUG]: container:  name: hlm-selenium-webview can't be resolved

Describe the bug
I was testing out the DotNet project and found it was not working. After looking up the logs I ran the Proxy locally and 'hlm-selenium-webview' can't be resolved.
Hope this helps
How to reproduce the issue
Run Docker-compose from .Net Ifra
Execute the test

Look in Proxy logs for DNS Resolution Failure - hlm-selenium-webview

Logs appeared during using Healenium
As above

Expected behavior
No response
Actual behavior
No response
Healenium Backend version
3.2.0
Selenium version
<IP_ADDRESS>
Platform
.Net / Java
Additional context
No response

Reupdated docker-compose.yaml file in .NET solution example


cross link Kubernetes

cross link the first "Kubernetes" text to https://azure.microsoft.com/en-us/topic/kubernetes/ in the "What is Kubernetes" section.

@Stellaleigh : Thanks for your contribution! The author, @iainfoulds, has been notified to review your proposed change.

@Stellaleigh - Thanks. Per Microsoft Style can you removed the 'en-us/' location from the URL?
@iainfoulds - can you review?
Thanks.

Thanks for the contribution, @Stellaleigh
This isn't actually creating a link to the external content, it will render just as a text link. A reader can't click on it. It would need to be formatted such as:
[Kubernetes](your-link)
It's also not really setting a context that explains what the reader will see if they follow the link, there's no expectation or motivation that details it's a complete learning experience / path.
#hold-off

@iainfoulds pls feel free to suggest alternative text - I'm not familiar with the best practices.
how about:
Kubernetes is a rapidly evolving platform that manages container-based applications and their associated networking and storage components. The focus is on the application workloads, not the underlying infrastructure components. Kubernetes provides a declarative approach to deployments, backed by a robust set of APIs for management operations. // Get an overview of how Kubernetes works here. https://azure.microsoft.com/en-us/topic/kubernetes/  //
open to other ideas.

#reassign:mlearned @mlearned can you review this request?

@Stellaleigh  i would do something like "Learn more about how Kubernetes works" and make the "how Kubernetes works" the link piece
[how Kubernetes works](https://azure.microsoft.com/topic/kubernetes/
#hold-off

@Jak-MS  it probably makes sense to just close this PR at this point ?  @georgewallace

@Jak-MS  can we please close this PR?  @georgewallace  , no further action is needed here.

#please-close


Breaks powerline fonts

Without Verminal

With Verminal:

I've spent 5 hours today trying to get my Powerline fonts working, and this whole time it was broken because of this theme 🤦♂
The theme is beautiful but please fix whatever you're doing to the fonts! My guess is the theme is forcing a specific fontFamily.

Actually looks like Verminal already provides an easy way to override this. It just wasn't obvious that it was the theme messing with the font.


Remove SSH server keys from our Docker image

The problem
Our Docker image contains SSH server keys. These keys are generated when openssh server is installed. These keys are in /etc/ssh:
$ docker run --rm gitguardian/ggshield:latest ls /etc/ssh/
moduli
ssh_config
ssh_config.d
ssh_host_ecdsa_key
ssh_host_ecdsa_key.pub
ssh_host_ed25519_key
ssh_host_ed25519_key.pub
ssh_host_rsa_key
ssh_host_rsa_key.pub
sshd_config
sshd_config.d

ggshield Docker image does not need an SSH server though, it only needs an SSH client, to be able to clone git repositories over SSH.
What has been done
This PR changes the Dockerfile to only install the SSH client, so now we have:
$ docker run --rm gitguardian/ggshield:tst ls /etc/ssh/
ssh_config
ssh_config.d

While I was at it, I simplified the package installation part of the Dockerfile a bit, in a separate commit.

Codecov Report

Merging #455 (b96b268) into main (1bc2e73) will decrease coverage by 0.01%.
The diff coverage is 74.19%.

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   93.54%   93.53%   -0.02%
==========================================
  Files          78       78
  Lines        3581     3587       +6
==========================================
+ Hits         3350     3355       +5
- Misses        231      232       +1

Flag
Coverage Δ

unittests
93.53% <74.19%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ggshield/core/check_updates.py
67.74% <28.57%> (ø)

ggshield/cmd/secret/ignore.py
67.74% <50.00%> (-2.26%)
:arrow_down:

ggshield/cmd/main.py
91.42% <90.00%> (-0.13%)
:arrow_down:

ggshield/cmd/common_options.py
97.50% <100.00%> (+0.13%)
:arrow_up:

ggshield/cmd/config/__init__.py
100.00% <100.00%> (ø)

ggshield/cmd/config/config_migrate.py
100.00% <100.00%> (ø)

ggshield/cmd/debug_logs.py
100.00% <100.00%> (ø)

ggshield/cmd/install.py
86.00% <100.00%> (-0.28%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


updated ffmpeg-4.2 libs to newest versions

I updated most of the libraries built from source in the alpine-4.2 image.
This involved changing version numbers, updating sha256sums, replacing URLs and adjusting build commands.
I have built the alpine image on my local machine.
I've made this PR to let you know that I'm working on this. I do intend to port this patch over to other images with the different OS base. But I would appreciate help on this.

Oh that's great thank you, but can you make the change inside the template folder, so all variants benefits from them ?

what sorcery is this xD? templates? sure can do.
so what do would i need to run after i updated the templates?

git closed the PR after i reset the commit

while watching the checks running the following occured:
centos builds "completed" earlier than expected and reported success despite the non-zero return during the x264 compilation step. may be a bug with the build system. after the build error it stopped compiling the other libraries.
See for more: https://dev.azure.com/video-tools/ffmpeg/_build/results?buildId=207&view=logs&j=4b231adf-81ae-59a4-de69-1d5fb07de66a&t=456bf2ef-07d6-5c05-364c-4fc233413fe2&l=1081
The issue for the centos version is that the latest x264-stable requires version 2.13 of nasm while the current centos base  only provides nasm version 2.10.

welp libass doesnt build configure: error: Package requirements (fribidi >= 0.19.0) were not met: is what the CentOS build says. will investigate this further and maybe even downgrade libass.

And with the new dependency, CentOS's package manager now tries to install a package called epel-release which adds a new repo. But when it tries to update its DB from that repo it fails. Just whyyy....
Installed:
  epel-release-8-5.el8.noarch

Complete!
CentOS-8 - PowerTools                           8.9 MB/s | 2.0 MB     00:00
Extra Packages for Enterprise Linux 8 - x86_64  376  B/s | 5.3 kB     00:14
Failed to download metadata for repo 'epel'
Error: Failed to download metadata for repo 'epel'


[Feature] Datetime selection dialog is confusing to users

We are not satisfied with the UX/UI of the datetime dialog. While we are using a custom implementation, you may want to address the following issue:
The dialog has no indication as to what the user must do to confirm that they've entered the value. This means that even if the user has scrolled the day / month / year values to their desired values, they can't tap "OK" until they have tapped each value (it starts being filled with a primary color). If the user taps "Select time" without confirming their date values, they will all be reset.
It took me as a developer 3 minutes to understand what's going on, imagine how long it will take a regular user to understand.

I like receiving feedback, but I believe that constructive criticism with suggestions for improvement would be more beneficial. I had two individuals with no prior experience in IT try out this component, and they were able to successfully select a date and time, without any hints or assistance and at first try.
I don't think auto-selecting the current centered item after a specific duration would be a solution.
Feel free to provide me with any suggestions to improve this component.

Yes, after giving it some thought I wanted to express a possible solution. Currently have an idea for a pr in mind.
When the dialog is scrolled, we can remove the confirmation at all by introducing snapping to the values.
The dialog in this case would simply use the current value in the list. That's how most drum selectors work in apps nowadays. A good example is the Xiaomi's alarm app.
A less Intrusive solution would be to consider the values currently on the drum "selected" when the user taps "select time" in the datetime dialog with time enabled, or at least save and restore them instead of dropping the values altogether.
If we go with the first one, we'll also need to increase the height of the dialog a bit to allow for easier flinging.

So, I looked into this and couldn't really figure out what's going wrong from my end to cause incorrect behavior in the Chinese locale. I browsed some open issues on sheets-compose-dialogs (the library I use to show calendar and datetime dialogs) and found this: https://github.com/maxkeppeler/sheets-compose-dialogs/issues/57. I think this may be the reason why it's not working properly in the Chinese locale.
Regarding the other issue of the incorrect AM/PM, I was indeed able to reproduce it on my real device (Xiaomi POCO F5/Redmi Note 12 Turbo), where it didn't work in both 24-hour format and 12-hour format (It didn't even show me the option to select AM/PM in 12-hour format). However, for some reason, it seems to work fine on Android Studio's emulator?! I really have no idea why. I think it's also some problem or bug with the library, though I can't say for sure.
I also found this issue: https://github.com/maxkeppeler/sheets-compose-dialogs/issues/53, which I personally agree with. It took me quite a few tries to understand how it's supposed to work, and I believe it could be confusing for users as well.
Considering all of this, I think it would be wise to switch to the standard Android library at least for the datetime picker, or maybe look at some other alternatives because there seem to be multiple issues with the current implementation.


stream.pipe is not a function

Hi! I'm trying to use this package with gulp-download-stream and I'm receiving the following error:
TypeError: stream.pipe is not a function
    at DestroyableTransform.transform [as _transform] ({project-path}\node_modules\gulp-unzip\index.js:28:12)
    at DestroyableTransform.Transform._read ({project-path}\node_modules\readable-stream\lib\_stream_transform.js:177:10)
    at DestroyableTransform.Transform._write ({project-path}\node_modules\readable-stream\lib\_stream_transform.js:164:83)
    at doWrite ({project-path}\node_modules\readable-stream\lib\_stream_writable.js:405:139)
    at writeOrBuffer ({project-path}\node_modules\readable-stream\lib\_stream_writable.js:394:5)
    at DestroyableTransform.Writable.write ({project-path}\node_modules\readable-stream\lib\_stream_writable.js:303:11)
    at Readable.ondata (_stream_readable.js:746:22)
    at Readable.emit (events.js:210:5)
    at Readable.EventEmitter.emit (domain.js:540:23)
    at Readable.read (_stream_readable.js:546:10)
    at flow (_stream_readable.js:1015:34)
    at resume_ (_stream_readable.js:996:3)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)

Is this related to the package or am I doing something wrong here?
PS.: It works fine with gulp-download but It's much much slower since it's not parallel.

Hi @thiagomajesk! Can you share your gulpfile file or the task? Are you using Gulp 3.x or 4.x?

@UlisesGascon Yes, of course. I'm using Gulp 4.0.2 and this is the task:
async function downloadIcons() {
    scrape((links) =>
        download(links)
            .pipe(unzip(unzipOptions))
            .pipe(svgo())
            .pipe(gulp.dest('static'))
    );
}

Hi, @UlisesGascon. First of all: Happy New Year! 🎊😄
I've been minding to ask: Have you come across this issue recently and is there any extra information I could provide to help solve this?

@thiagomajesk I had the same issue, try using vinyl-buffer.
https://www.npmjs.com/package/vinyl-buffer

Same problem with Gulp 5.
download("https://..../foo.zip")
            .pipe(unzip())
            .pipe(gulp.dest('extracted'))

.../node_modules/gulp-unzip/index.js:28
    stream.pipe(unzip.Parse())
           ^

TypeError: stream.pipe is not a function
    at DestroyableTransform.transform [as _transform] (/Users/gwagenknecht/Development/Salesforce/bazel/bazel-vscode-java/node_modules/gulp-unzip/index.js:28:12)
    at Transform._read (/Users/gwagenknecht/Development/Salesforce/bazel/bazel-vscode-java/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at Transform._write (/Users/gwagenknecht/Development/Salesforce/bazel/bazel-vscode-java/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:12)
    at doWrite (/Users/gwagenknecht/Development/Salesforce/bazel/bazel-vscode-java/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:237:10)
    at writeOrBuffer (/Users/gwagenknecht/Development/Salesforce/bazel/bazel-vscode-java/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:227:5)
    at Writable.write (/Users/gwagenknecht/Development/Salesforce/bazel/bazel-vscode-java/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:194:11)
    at Readable.ondata (node:internal/streams/readable:1009:22)
    at Readable.emit (node:events:518:28)
    at Readable.emit (node:domain:552:15)
    at Readable.read (node:internal/streams/readable:782:10)
    at flow (node:internal/streams/readable:1283:53)
    at resume_ (node:internal/streams/readable:1262:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:90:21)

Node.js v22.11.0


Export checkDWObjectMetaEquality for custom resource syncer (Add an example custom resource syncer)

This PR gives an example of custom resource syncer. The proposed design is at: https://github.com/kubernetes-sigs/multi-tenancy/issues/1388 (will generate a readme later)

@christopherhein @Fei-Guo removed example cr syncer code as discussed. This PR is just to export one method in conversion lib

I think you still need to update the commit message still to reflect these changes.
it currently says:

add example cr syncer …
add an example custom resource 'project' syncer
remove not fully tested build system
based on talk with Fei, will remove the buildable file and replace with readme

Updated commit msg

/lgtm
/approve


[Navi21] test_activation quietly fails

35/92 Test  #1: test_activation .......................................***Failed  394.89 sec
/dockerx/github/MIOpen/build/release.hip-clang.nodev/bin/test_activation --float --input 1, 1, 1, 1 --alpha 0.95 --beta 2.3 --gamma 3.4 --mode ELU --packed 1.
error: 0
Max diff: 0
Forward Activation: miopenActivationELU
Input tensor: 1, 1, 1, 1...
/dockerx/github/MIOpen/build/release.hip-clang.nodev/bin/test_activation --float --input 1, 16, 4096, 4096 --alpha 0.95 --beta 2.3 --gamma 3.4 --mode ELU --packed 1.
error: 0
Max diff: 0
Forward Activation: miopenActivationELU
Input tensor: 1, 16, 4096, 4096
/dockerx/github/MIOpen/build/release.hip-clang.nodev/bin/test_activation --float --input 1, 16, 4096, 4096 --alpha 0.95 --beta 2.3 --gamma 3.4 --mode ELU --packed 1.
CMake Error at test_test_activation.cmake:7 (message):
  Test failed

but no other signs of error.
Originally posted by @atamazov in https://github.com/ROCmSoftwarePlatform/MIOpen/issues/1333#issuecomment-989256733

The test quietly fails when input tensor size reaches 1 GiB and if CTEST_PARALLEL_LEVEL=4. When the test runs exclusively, it passes, so it seems the root of the issue is lack of GPU resources. We can run the test in RUN_SERIAL mode, but I would consider this is as a workaround for now.
What needs to be done:

(1) Find out the reason of the failure. Maybe this is normal.
(2) Definitely, the problem is that the test fails quietly, which needs to be fixed.

Assume a bug an set normal urgency until the reason is identified found (see (1) from previous comment).

@shaojiewang  could you please take a look at this issue?

@shaojiewang could you please take a look at this issue?

Yes, sure. But not so familiar with activation kernel code.


Consider not running auto-update-versions.yml on forks if possible

See here: https://github.com/cartermp/opentelemetry.io/actions
That's a lotta cpu cycles!
Thanks @puckpuck for the pointer

@chalin thoughts?


Improve performance of slow queries

We have a few requests that take way more than they should:

get list of countries (/tenders/countries)
get list of cpvs (/tenders/cpvs)
get node details (/networks/{networkID}/nodes/{nodeID}

Investigate why they take so long. Obv some of the assumptions on which I based these queries are wrong.

Network details speed improvements:

total request time for bidder with 8 bids: 25 sec
getting the node details from db: 1.2 secSELECT set(@rid).size() as numberOfWinningBids,
  sum(price.netAmountEur) as amountOfMoneyExchanged,
  list(price.netAmountEur).size() as numberOfAvailablePrices,
  set(@rid) as bidRIDs
    FROM (
      SELECT *
      FROM Bid
      WHERE xCountry in ['CZ'] AND xYear in [2015] AND out('AppliedTo').in('Comprises').out('HasCPV').code in ['16700000']
      AND in('Participates').id in ['bb25de5c-e4b4-408a-a7d7-382fa0ee2e2f']
      AND isWinning=true
    );

getting the bidders of the bid: 4.337 secSELECT expand(in('Participates')) FROM Bid where @rid='#91:48440';

getting things by @rid seems super slow: 4.3 secSELECT FROM Bid where @rid='#91:48440';

Possible solutions:

#67
use an internal id for bid and lot just to have an index to use instead of rid

Get countries speed improv:
Even though we have an index on xCountry, ODB doesn't use that to compute distinct(xCountry). It reads all the bids so it ends up being  very slow (5.9 sec).
If I add a filter by year  to use the xYear index, the speed increases dramatically:

Same issue with getting list of years.
Possible solutions:

open an issue to ODB GH about this since it's a pretty big problem
in the meantime try to use the Bid.xCountry index directly from the code to compute the distinct

The changes in #84 have brought significant improvements to some queries.
For example getting cpvs by country https://dev.api.tenders.exposed/tenders/cpvs?countries=RO was brought down from 12 sec to 5.3 sec. Of course, 5.3 sec is still a lot but I haven't been able to identify why the cpvs query still takes so long.
Run in OrientDB 3.0 the same cpvs query is tremendously faster, topping at 0.070 sec but unfortunately we can't switch to that version yet because of  orientechnologies/orientjs#304

For /tenders/countries and /tenders/years the indexes on xCountry and xYear are not used to calculate distinct(). I tried to access the values directly from the index as described here but nothing is returned.
I opened orientechnologies/orientdb#8169 for this since it would be a great improvement but I don't have my hopes too high since ODB 2 is no longer the main focus.
In ODB 3 the same query we use now runs a lot faster: 0.435 sec as opposed to 5.9 sec in ODB 2.

I will move this back to backlog and come back to it later when there are updates on ODB 3.


fix(protocol-base): Add misspelled API back to the package

Removing the misspelled buildGitTreeHierarchy API in #16323 caused a back-compat issue even though that change was never released to public npm. See AB#4938 for more details.
I added back the old name. There are a few different ways to export a function with multiple names, and I don't know which is best. I put each option in a separate commit on this PR, so to see them individually, use these links:

Option 1: https://github.com/microsoft/FluidFramework/pull/16339/commits/9659227330a3456180b36c599050354c1655b07d
Option 2: https://github.com/microsoft/FluidFramework/pull/16339/files/d3378ac387d66918e01b085957082dd8b80e1385
Option 3: https://github.com/microsoft/FluidFramework/pull/16339/files/8e88f2178629e5828ca5f053ee29e8c7ff7b1ab9

i wouldn't make this change. from what i can tell the original name was buildHierarchy which was removed/renamed to buildGitTreeHeirarchy and then you fixed the typo to buildGitTreeHierarchy.
buildGitTreeHeirarchy was never officially released, so i don't think there is a need to preserve it and we allow breaking changes in major releases. the problem here was a break between consumed pre/dev/build-releases
if anything, i would re-map to the original name, buildHierarchy and then the change isn't breaking at all, but again, not really necessary, as breaks are allowed in major releases
the next step here is to redo the integrate, with the new name. which i think also requires a pre-release? maybe?
if you want to be really safe, when you redo the integrate, don't use semver, so no ^ or ~ and explicitly reference the pre-release. that will prevent this issue, which is unlikely, as it requires breaks


Error: undefined method `version_scheme' for #Class:0x00564e76500e40

==> Installation successful!
==> Next steps
Install the Linuxbrew dependencies:

Debian, Ubuntu, etc.:
  `sudo apt-get install build-essential`

Fedora, Red Hat, CentOS, etc.:
  `sudo yum groupinstall 'Development Tools'`

See http://brew.sh/linuxbrew/#dependencies for more information.

Run `brew doctor` before you install anything
Run `brew help` to get started
Error: undefined method `version_scheme' for #<Class:0x00564e76500e40>

Please report the output of
brew --version
brew config

$ brew --version
Homebrew 0.9.8 (git revision 53204; last commit 2017-09-28)
Homebrew/homebrew-core (git revision 6690; last commit 2018-05-08)
$ brew config
HOMEBREW_VERSION: 0.9.8
ORIGIN: https://github.com/Homebrew/linuxbrew
HEAD: 532040391bb984e410b7ad73bdd0c518f945cc0b
Last commit: 8 months ago
Core tap ORIGIN: https://github.com/Linuxbrew/homebrew-core
Core tap HEAD: 669038e1dea01dfa66258aa8d410a5174b44820b
Core tap last commit: 9 days ago
HOMEBREW_PREFIX: /home/maxi4/.linuxbrew
HOMEBREW_REPOSITORY: /home/maxi4/.linuxbrew
HOMEBREW_CELLAR: /home/maxi4/.linuxbrew/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://linuxbrew.bintray.com
CPU: dual-core 64-bit 0x1570
Kernel: Linux 4.13.0-41-generic x86_64 GNU/Linux
OS: Ubuntu 16.04.4 LTS
Codename: xenial
OS glibc: 2.23
OS gcc: 5.4.0
Linuxbrew glibc: N/A
Linuxbrew gcc: N/A
Clang: N/A
X11: 2.7.8 => /usr
System Ruby: 2.4.1 => /home/maxi4/.rbenv/versions/2.4.1/bin/ruby
Perl: /usr/bin/perl
Python: /usr/bin/python => /usr/bin/python2.7
Ruby: /home/maxi4/.rbenv/versions/2.4.1/bin/ruby
Java: N/A


Update encrypt-data.md

Added missing closing parentheses in line 70.

/easycla

Hi  @bradreelee, please follow these guides to sign easycla,
You can find about EasyCLA here - https://docs.linuxfoundation.org/lfx/easycla
and the steps to sign EasyCLA are here - https://docs.linuxfoundation.org/v2/easycla/contributors/individual-contributor
You can start your signing EasyCLA from here - https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/51478266/38056/#/?version=2

@bradreelee Good find and thanks for fix
Changes look good to me.
Deploy Preview Link: deploy-preview-39876
/lgtm

/assign
pinging @ reylejano for approval

/assign
pining @reylejano for approval


Members of one file will not open

I have a filter that shows all "Q" source files in a library

Everything seems to work ok, EXCEPT QMAPLESRC... I can see the members ok if i open it, but no matter what i do the member will not start up the editor. I dont know if there is a log someplace i chan check, but i dont see any errors or anything like that

It was a CCSID issue. the file was set incorrectly. I fixed it and it is working fine. Thanks for the help
From: barry @.>
Sent: Monday, February 21, 2022 11:07 AM
To: halcyon-tech/vscode-rpgle @.>
Cc: Knittle, Dave @.>; Author @.>
Subject: Re: [halcyon-tech/vscode-rpgle] Members of one file will not open (Issue #69)
CAUTION: This message originated from outside of MEC, Inc. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Yes, there is a log. Please share it here also.

Go to the OUTPUT tab
Change the output channel to Code for IBM i
Recreate your issue
Copy and paste the log here

—
Reply to this email directly, view it on GitHubhttps://github.com/halcyon-tech/vscode-rpgle/issues/69#issuecomment-1047031907, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJOLPBAWYTWRJ3QCRP26BKTU4JPJXANCNFSM5O672AZA.
You are receiving this because you authored the thread.Message ID: @.***>


Skip flaky test

might be a concurrency thing, might not work well when run in a container,
not sure

LGTM please merge it.


[WIP] Phase support for Flink-K8s runtime

Signed-off-by: Al-assad<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: 246
Problem Summary: Provide Flink-K8s Runtime Support for StreamX
What is changed and how it works?
What's Changed:

Support for submit/cancel Flink-SQL-Job on Flink-K8s-native session/application mode.
Support for tracking Flink job status and metrics information from Flink-K8s cluster.
Support for StreamX instance to manage both Flink-Yarn or Flink-K8s runtime Cluster, and to use either independently.

@wolfboys There is still some work left on the documentation, the development of the code itself is basically finished.

@Al-assad ok, the next we  need to review and merge the PR

@wolfboys Thanks for your valuable suggestions, i will modify the relevant code ASAP.


[Email] Optimize email flow with read more

Description
Optimize email flow

Enable 'ReadMore' flow to current ShowEmail/SendEmail/ForwardEmail flow.
Enable 'ReadMore' flow to current recipient select step.
Fix some bugs related to next/previous page for email list and contact

Related Issue
Add read more support for email and recipient list #339
Testing Steps
For email list read more:

User: what is my emails?
Bot: show list of [6] emails, read out first [3] one
User: read more
4: Bot: show the rest of [3] emails, and read them out
User: read more
6: Bot:  show next page - list of [6] emails, read out first [3] one

For recipient list read more:

User: send an email to qiong
Bot: show list of [6] contacts, read out first [3] one
User: read more
4: Bot: show the rest of [3] contacts, and read them out
User: read more
6: Bot:  show next page - list of [6] contacts, read out first [3] one

The display number [6] and read number [3] is configurable.

@DingmaomaoBJTU Looks like there is a build failure, can you resolve before merging please?

@darrenj Sure, fixed! Sorry for that~~


Cluster Crashes when deploying

Hey there,
Really like the idea of Flynn. We have been using it for a month now and love it. However , when we deploy a rails/node or any other app the cluster crashes. What I notice is that just one of the servers will spin up to 100% and then the sites are just offline. The process will keep running albeit very slowly. It used to be that the cluster would load balance and all of the servers would be like 30% working (more or less equal).
Anything we can do to improve this?

I just reinstalled and all is fine now!


Day 21: Lambda Expressions and Functional Programming in C++

Day 21: Lambda Expressions and Functional Programming in C++
Fixes #321

update day21

Day 21: add Marcos in cpp
Fixes #326


Add server option to provide DNS server

Clear and concise description of the problem
Would be great if it was possible provide global DNS server that could be later on provided to plugins ex. docker build plugins that start dind image and is starting with default DNS servers <IP_ADDRESS> and <IP_ADDRESS> currently that does not allow them to resolve internal servers.
Suggested solution
Add server option WOODPEKCER_CUSTOM_DNS that would be passed down to plugins
Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Closing this as I resolved this in docker buildx plugin and I don't have any additional use case for this


[Feature] Add Kinetic and Potential Energy Calculator:

Description
This calculator helps us to calculate the kinetic energy using the formula  K.E. = 1/2 * m * (v^2)
and potenial energy P.E. = m * a * h
where m= mass
a=acceleration
v=velocity
I want add this calculator
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Go ahead @Anshika14528


high contrast mode - border in editor overlaps text

Testing #15811
See below:

VSCode Version: Code - Insiders 1.8.0-insider (7499a9f3c565f4fbe5205e30c8664e5a5a11ae94, 2016-12-06T16:16:15.865Z)
OS Version: Windows_NT ia32 10.0.14965

I've reduced the border width from 2px to 1px:


Try codecov

Apparently merges need to be via PR for codecov to pick them up.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c0a6b26). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   23.74%
=======================================
  Files           ?       39
  Lines           ?     3656
  Branches        ?        0
=======================================
  Hits            ?      868
  Misses          ?     2788
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a6b26...938409c. Read the comment docs.


Bump clients to v0.7.1

The following clients need to be updated to use https://github.com/cncf-tags/container-device-interface/releases/tag/v0.7.1
Note the deprecated APIs.

[ ] podman (@elezar)

common: https://github.com/containers/common/pull/1944
podman: https://github.com/containers/podman/pull/22280

[ ] docker (@elezar):

Daemon:
CLI:

[ ] containerd (@bart0sh)

[ ] main: https://github.com/containerd/containerd/pull/10041
[ ] release-1.7:

[ ] crio (@klihub):

[ ] release-1.30:
[ ] main:

[ ] singularity (@elezar)
*
[ ] ctr (@elezar)
[ ] nerdctl (@elezar)

https://github.com/containerd/nerdctl/pull/2280 needs to be updated

[ ] kubernetes (@bart0sh)

What is required for CRIO?

@kannon92 we need to bump the dependencies and (optionally) move from the deprecated APIs. The containerd PR should be similar enough to be used as a guideline.

I’ll see about doing it next week and I’ll cherry pick it to 1.30.
we are in the process of bumping a lot of dependencies right now with recent podman release.

@klihub got to it already.
https://github.com/cri-o/cri-o/pull/7971

How important is this for 1.30?
There is a very unlikely chance this will go into k8s 1.30.
CRI-O 1.30 branch aims to be 1on1 with k8s 1.30.

@kannon92 I don't think it's important as most of changed functionality makes sense only for runtimes.

I did a quick search into kubernetes but didn't see that cdi is a dependency.

Kubernetes doesn't depend on the spec at all. It should only be forwarding the cdi device names as opaque strings. There is some logic around constructing the container annotations (if required) that may be shareable, but I don't believe we pull anything in for that. There were concerns about dependencies at some point and the relevant logic was duplicated instead.

It will depend on CDI spec soon. It's in my short term TODO list.
So far there are two places in the k/k code that would benefit from it:

this file should be removed. and this code should use imported CDI spec
this code should also use imported CDI spec

@klihub @elezar thank you for your patience on the crio work. We had some long lasting bugs around our CI images. this actually helped get a PR I had sitting for a few months also so it is greatly apprechiated!

Thank for all your help with this, too !

@bart0sh (bumping to keep this open) can you update this ticket with your k8s PR?

@kannon92 I think k8s would want to consume the v0.8.0 package / spec since this removes the dependency on the OCI runtime specification.

Should we remove the call out for kubernetes then?

@kannon92

Should we remove the call out for kubernetes then?

I think it makes sense to remove. If https://github.com/kubernetes/kubernetes/pull/126435 is approved, the only copy of the  CDI structures is in the e2e tests: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/app/cdi.go
This can be replaced with the specs-go import at some point, but it's not that urgent.


Add test cases for loading parsing rule

#2408

Pull Request Test Coverage Report for Build 8185

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 60.075%

Totals

Change from base Build 8184:
0.7%

Covered Lines:
8050

Relevant Lines:
13400

💛  - Coveralls


[Suggestion] Browse VOD's with livestreamer-twitch-gui

Hey could you implement VOD browsing and starting with Livestreamer? Would be awesome :+1

Duplicate of #81


How to reproduce the keypoint detection and Re-identification results in your paper?

Hello @hukkelas ,
Your repository is outstanding! I was wondering if you could provide detailed instructions on how to replicate the settings and experiments outlined in your paper, particularly those related to human keypoint detection and re-identification. Your guidance would be greatly appreciated!

Hello, Thanks for the interest and my apologies for the late answer!
Have you taken a look at the appendix in part C? There we have described in detail how we performed the experiments on the market1501 dataset.
Also, for the market1501 dataset we used the configuration files (with anonymize.py) found here: https://github.com/hukkelas/deep_privacy2/tree/master/configs/anonymizers/market1501
For the COCO experiments I highly recommend you to take a look at our follow up paper, which does a more thorough evaluation of the COCO dataset with DeepPrivacy2 (running the Tria-GAN generator from this paper.). The experiments in that paper is detailed described (see here)


Make StaticRoute support Last-Modified and If-Modified-Since headers

This change makes StaticRoute add Last-Modified headers to the responses and recognize If-Modified-Since headers in the requests. If If-Modified-Since header is present and is equal to the modification time of the file being served, StaticRoute will now respond with a 304 "Not Modified" response.
This is a small feature, but rather useful if you hit "Refresh" button often.

The PR is good but I guess to add if_modified_since readonly property to Request and last_modified read-write property to StreamResponse (like content_length for example).

See also #165

I've split the tests somewhat (some of them are superfluous though).
Would you like the if_modified_since property to be a timestamp or a string? I think such a property would make sense if it's value was the parsed timestamp, but my proposed code doesn't really parse the If-Modified-Since header, it just compares it char-by-char with the mtime string -- this is faster, simpler, and just as useful (because user agents usually just copy whatever you sent in the Last-Modified header without interpreting it); this behaviour also protects against the situation where your clock was rewound backwards, and the client has a timestamp far into the future.

Yes, properties make sense only if they have datetime type (timezone aware BTW).
I think string parsing time is vanishing tiny comparing to overall response time.
By standard it is timestamp. If you need arbitrary data like hash please use ETAG header.

Something like this then? I think it's overengineering, to be honest.

I want to make properties for all common HTTP headers eventually.
if_modified_since and last_modified are not necessary for static file handling task but I like to have those as well as other absent fields.

Thanks!


[runtimeconfig] Should be "client.config(...)" not "client.get_config(...)

https://github.com/GoogleCloudPlatform/google-cloud-python/blob/bee32c0ae68b1e6cf224f9017c758a8e31e8be83/runtimeconfig/google/cloud/runtimeconfig/config.py#L189

Thanks, the client class does indeed have a config method (rather than get_config).
In addition, that example has a typo, get_varialbe.


Added us/ky/boone

I had problems testing this locally. The connection would Read timed out.

Re-run this please

Re-run this please

@trescube maybe https://secure.boonecountygis.com/ags/rest/services/ParcelLayers/MapServer/0

Tried that but getting read timeouts with pyesridump.  I'll try letting the machine handle it.

Closing Stale PRs. Feel free to reopen if still relevant.


NoThreads Web export : AudioStreamPlayer's finished() signal doesn't emit when sound is done playing.

Tested versions

Reproducible in: 4.3.beta2.official [b75f0485b], 4.3.beta.gh-93890 [5c49d3cd9].
Not reproducible in: 4.2.2.stable.official [15073afe3]

System information
Godot v4.2.2.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 (NVIDIA; <IP_ADDRESS>85) - Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 Threads)
Issue description
When running the project as a single threaded web export, AudioStreamPlayer's finished() signal doesn't fire, even after the sound is done playing.
This is still the case on very recent versions (latest build from workflows as of one hour ago) and I haven't found any existing issue mentioning this.
This seems bad as it breaks several popular AudioManager classes I have seen peoples use, which mean a lot of projects would end up with no sound (or crash) just from upgrading to 4.3.
(Edit : To be more accurate, the issue seems to be caused by the new AudioStreamPlayer playback_type property being set to "Sample", rather than the export template. If the AudtioStreamPlayers are manually set to Sample and the project is ran using the multithreaded web template, the issue will still occur)
Steps to reproduce

Create an AudioStreamPlayer node (either in editor on in script, both are affected).
Bind the finished() signal to a function, add a way to check if it ran.
Play a sound on that AudioStreamPlayer
Function won't run if you ran the project using the single threaded web export template (but will with multithreaded web, windows, etc... templates)

Minimal reproduction project (MRP)
AudioStreamPlayer finished bug MRP.zip
A simplified version of an AudioManager class I usually use. It creates a pool of AudioStreamPlayers (3 for this demo), remove one from the pool when a sound needs to be played, then add it back to the pool when the finished() signal emits.
Main scene plays a sound every second using this manager. If you run the project on most templates, the sound will repeat infinitely. If you run in with the single threaded web template, it'll play 3 sounds and then stops, as the Players never get added back to the pool.
(You can also just check the console and see that the debug print in the finished() callback never runs)
There is a second scene I used to test if the issue only occurred in some conditions, but the issue occurred in ALL cases (tried removing argument, creating the players in the scene rather than in gdscript, connecting the signal in editor rather than in gdscript, ...)

cc @adamscott


Question: Action to remove a property from an object?

We've switched a lot of our internal models over from arrays of objects to normalized objects as we've found that gives more control with how we manage form state with RRF.  I know you are working on changes to track field state, but the normalized data seems to be a lot easier for us to manage.
However, one limitation we've hit is that currently RRF doesn't seem to provide a way to remove a property from an object. e.g. we have:
choices: {
    answer_1: {
        text: 'Happy',
        feedback: 'nice job'
    },
    answer_2: {
        text: 'Sad',
        feedback: 'oh dear'
    }
}

We need to be able to Remove an answer from the choices object:
e.g.
actions.remove('choices["answer_1"]);

choices: {
    answer_2: {
        text: 'Sad',
        feedback: 'oh dear'
    }
}

We've currently implemented this ourselves in our reducer.  I realise that icepick doesn't support dissocIn directly yet but we are using this workaround.
Let me know if you think this would be a useful thing for RRF and if so I can have a go at creating a PR.

This would be a great addition. Currently, actions.remove is for arrays only, and the behavior should mirror https://lodash.com/docs#remove (which it currently doesn't; I'll fix that.)
Let's look to https://lodash.com/docs#omit for inspiration, so you can do:
dispatch(actions.omit('choices', 'answer_1'))

What do you think?

This is now available in<EMAIL_ADDRESS>You can omit one or many properties at once:
dispatch(actions.omit('choices', 'answer_1'));
dispatch(actions.omit('choices', ['answer_1', 'answer_3']));

Will close when the docs are updated.

Now documented here: https://davidkpiano.gitbooks.io/react-redux-form/content/model_actions.html#actionsomitmodel-props


Requesting updated tailer documentation

I watched your presentation at FOSDEM 2017: Implementing 'tail -f' in Go. Very good talk! I'd like to follow your path to get tailing working on a Go rewrite of my simple logstation.
Can you provide some updated documentation for your wiki? Looks like those files (fileTailer_linux.go, etc) have been replaced in recent years and I'd like to know how to use the new code.
https://github.com/fstab/grok_exporter/wiki/tailer-(tail-‐f)
Thanks!

I think I can help update the documentation via PR to include how to use your tailer as a library. Before that, I could use some guidance, please.
I've been digging into how grok_exporter uses tailer. My goal was to import your tailer codebase and use it to tail -f for new lines and pipe them into my function with a Go channel.
The problem I'm seeing is that the FileTailer.Lines() channel always has all lines in the file, instead of only the new lines. Maybe this is Windows bug?
Here's my code
func follow(path string, conn *websocket.Conn) error {
	logger := logrus.New()
	logger.Level = logrus.DebugLevel
	logger.SetOutput(os.Stdout)

	parsedGlob, err := glob.Parse(path)
	if err != nil {
		logger.Error("%q: failed to parse glob: %q", parsedGlob, err)
		return err
	}

	tailer, err := fswatcher.RunFileTailer([]glob.Glob{parsedGlob}, false, true, logger)
	for {
		select {
		case line := <- tailer.Lines():
			logger.Debug(line.Line)
			conn.WriteMessage(websocket.TextMessage, []byte(line.Line))
		}
	}
}

If I write a line that say "line 1" to a logfile. I get this in the stdout:
time="2020-09-13T01:34:45-04:00" level=debug msg="received event: \"E:\\\\git\\\\logstation\\\\test/logfile.log\": 0x2 == FS_MODIFY" directory="E:\\git\\logstation\\test"
time="2020-09-13T01:34:45-04:00" level=debug msg="read line \"line 1\""
time="2020-09-13T01:34:45-04:00" level=debug msg="line 1"
time="2020-09-13T01:34:45-04:00" level=debug msg="received event: \"E:\\\\git\\\\logstation\\\\test/logfile.log\": 0x2 == FS_MODIFY" directory="E:\\git\\logstation\\test"

If if append "line 2" to the logfile I end up with this in the stdout:
time="2020-09-13T01:34:48-04:00" level=debug msg="received event: \"E:\\\\git\\\\logstation\\\\test/logfile.log\": 0x2 == FS_MODIFY" directory="E:\\git\\logstation\\test"
time="2020-09-13T01:34:48-04:00" level=debug msg="received event: \"E:\\\\git\\\\logstation\\\\test/logfile.log\": 0x2 == FS_MODIFY" directory="E:\\git\\logstation\\test"
time="2020-09-13T01:34:48-04:00" level=debug msg="read line \"line 1\""
time="2020-09-13T01:34:48-04:00" level=debug msg="read line \"line 2\""
time="2020-09-13T01:34:48-04:00" level=debug msg="line 1"
time="2020-09-13T01:34:48-04:00" level=debug msg="line 2"

Notice how it has both "line 1" and "line 2" in the channel. I was hoping when I appended "line 2" to the log file, I would only get "line 2" in the tailer.Lines() Go channel.
Finally, I should wrap this up by saying that I'm in the midst of learning Go... so apologies if I'm doing something elementary. Thanks for the help!

It depends on how you write line 2 to the file.
If you open the file in a text editor, add a line, and save it, the text editor will actually re-write the entire file. grok_exporter will see that the entire file has been overwritten, and start reading from the beginning.
A good way for testing is opening a cmd window and typing the command
echo "line 2" >> logfile.log

This should append "line 2" to the file without re-writing the whole file. This should work with grok_exporter.

That worked perfectly!
Going to close this ticket. I'll make a PR with some updated documentation on using tailer as a library/package. Thanks for the help!


Check for ldid and dpkg-deb only once

Description
This will check for ldid and dpkg-deb before running the script to reduce amount of produced logs.
Is this related to an issue/problem?
no, but the script checks for commands on every signing and it fills the logs and makes them less readable

Thanks for the pr!


[WIP] Build librdkafka using CMake

Hi, @andyone.
I found that Clickhouse (#212) is not linking with librdkafka dynamically due to static library present in RPM package. So, I decided to get rid of static libraries and move building process to CMake. Please, review and give a feedback.

@gongled Hi! Have you any plans to finish work on this spec? This PR in WIP almost 1 month without any changes.


Project logs are getting written to $GAUGE_HOME/logs` dir

Expected behavior
Logs should be present in <project_dir>/logs directory
Actual behavior
logs are getting written to $GAUGE_HOME/logs or $HOME/.gauge/logs dir
Gauge version
Gauge version: 0.9.1

It is fixed as part of #782

Test cases

[ ] If the user is in a gauge project directory, then the logs are written to the project folder
[ ] If the user is not in a gauge project directory, then the logs are written to the Gauge HOME\logs folder

Note: gauge init command in a directory without the gauge project, the logs are written to the Gauge HOME folder.


.avoid not working with v-color-picker

the v-shortkey.avoid does not work on the vuetify v-color-picker. I believe that the text input is inside  v-color-picker and therefor the avoid does not work. Is there anyway to propagate the .avoid to all the children of an element?

I tried to use Vue.use('vue-shortkey', { prevent: ['input', 'textarea'] }) but it still doesn't work. and It was an input element.

Anybody read this? I have the same problem!

Found a work around using Vue.use(require('vue-shortkey'), { prevent: ['input', 'textarea'] }) in main.js.

v-color-picker should encapsulate the input element and the avoid command isn't applied to them.
So try to apply the prevention to the class.
Vue.use('vue-shortkey', { prevent: ['.input-color-picker-style-class'] })


Apidocs table of contents floc 2105

See #1503
Fixes https://clusterhq.atlassian.net/browse/FLOC-2105

Easier to navigate now, looking forward to final result. Address minor comment then merge when docs builder is green.


Revert "fix: sdk provider config (#1311)"

This reverts commit f17c1748472b8fe36e4a8f8b3cc62ac22283b87f.

About this change—what it does

reverts #1311

Why this way

it's wrong

this is invalid


[BEAM-12769] Reject requests when parameter names cannot be validated

We allow field names that use the 'ignore' pattern as mentioned in the spec
Request will be rejected when Java compiled code does not include parameter names.

Testing: covered by existing tests 'testJavaClassLookupIncorrectConstructionParameter' and 'testJavaClassLookupIncorrectBuilderMethodParameter'.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @robertwb

Thanks. Updated the error message.
PTAL.


invalid date values are changed in output

using input .xlsx file with invalid date value like  00/01/1900
is being converted to "31/12/1899 00:00:00"
when read out using "ExcelReaderFactory.CreateOpenXmlReader(stream)"
is there an option to retain values as they are?
P.S. Excel SaveAs -> CSV works OK and retains the values as is.

Hi,
In short, no, there is no such option. And if there were, it would probably not do what you expect, but return a double with a value of zero for these cells. For the time being, I think your best option is to filter out these dates manually.
Basically Excel represents dates internally as numbers >= 0, starting from the zeroeth of January, and uses the number format to display the date you see. ExcelDataReader tries it best to convert Excel dates to the .NET DateTime type, which cannot represent 0/1/1900, but returns 31/12/1899 instead - which is technically the same.
(A way to solve this, and I would consider accepting PRs for it, is to add a new ExcelReaderConfiguration option to return the underlying value of dates, add a new IExcelDataReader.IsDate1904 flag, and use these together with the third party ExcelNumberFormat library - which also must be changed - to display dates exactly like Excel)

thanks for your response. as CSV has no notion of datatypes, perhaps it'd be right to treat all data in the source Excel file as text? sorry, haven't yet looked through your code. do you think this is doable?

Hi, thanks for the test! This is useful to demonstrate the challenge in a little more detail. If you rename Test_git_issue_350_bad_dates.xlsx to zip and unpack it, have a look inside xl\worksheets\sheet1.xml
The XML for cell A2 looks like this:
<c r="A2" s="2"><v>0</v></c>

As you can see, the date is physically stored as a zero and it is actually quite a complex operation to convert from 0 to "0/1/1900" for all possible variations. Excel renders the date via the number format string "m/d/yyyy" . You can find the number format string under Home -> [Number format dropdown: Date] -> More Number Formats -> Category: Custom.
I've implemented a large part of Excel's number formatting algorithm in a separate ExcelNumberFormat library, but at the moment expects date values in the .NET DateTime type, which works well with ExcelDataReader, but cannot display the dates 0/1/1900 and 29/2/1900, which are allowed by Excel, but are considered invalid dates in the real world. This is indeed an edge case.
I think our best approach currently is to somehow let ExcelDataReader expose the "raw" values from the Excel file, and implement support for numeric dates in the ExcelNumberFormat library to allow rendering invalid dates like Excel. Check the readme for an example how to use it.
This is further complicated by the fact that Excel supports two different date systems, the 1900 and 1904 date systems. Another complicator is the Year 1900 problem


Fix MissingFormula namespacing.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Refs https://github.com/Homebrew/brew/pull/4068#discussion_r181552125.
Closes https://github.com/Homebrew/brew/pull/4103.

What's with all the whitespace change?

That was basically my argument here: https://github.com/Homebrew/brew/pull/4068#discussion_r181957520
It's either removing module Homebrew from MissingFormula or adding it to everything else.

Thanks @reitermarkus!


Any plan to bring arco design to flutter?

In fact, there is already a team doing it in ByteDance

Super! I would also be happy to see arco become React Native compatible


Add full licenses for libraries

Using LicenseDialog, add full licenses for the libraries used to give proper credit.

Fixed in commit 5805b2c4fc7c1fe9114101f56799c35767644c2e


I would like to join your team and contribute with my many years of experience and skills.

Hi, I'm Ethan Tan, a seasoned web full-stack and blockchain developer with over 8 years of experience in the industry. I specialize in building robust, scalable web applications and innovative blockchain solutions. Leveraging my expertise in frameworks like React.js, Vue.js, and Next.js, along with my proficiency in Solidity for smart contract development, I deliver high-quality, secure, and efficient solutions tailored to meet your specific needs.

Hi @johnsmith0212 , please communicate in the relevant communication channels regarding this. Thank you.

thank you


ensure we quote user input strings placed into yaml

For issue https://github.com/open-cluster-management/backlog/issues/10273

/hold

/approve

/hold cancel


find_by_email method does not follow osdi encapsulation rules exactly

A request for an email with an apostrophe (') in it returned an error from Action Network
A lucky guess found that a two apostrophes ('') (as per mysql encapsulation) worked
Further reading on osdi found documentation that a single apostrophe in a search query needs to be escaped with another single apostrophe
My monkey patch
module ActionNetworkRest
class People < Base
def find_by_email(email)
# This works for parsing exactly 1 person's info out of the response.
# The response we get from Action Network is expected to have
#
# "_embedded": {
#   "osdi:people": [{
#       "identifiers": [
#           "action_network:c947bcd0-929e-11e3-a2e9-12313d316c29"
#            ....
#        ]
#    }]
# }
#
osdi_encoded_string = email.gsub("'","''")
url_encoded_filter_string = url_escape("email_address eq '#{osdi_encoded_string}'")
response = client.get_request "#{base_path}?filter=#{url_encoded_filter_string}"
person_object = response.body[:_embedded][osdi_key].first
set_action_network_id_on_object(person_object) if person_object.present?
end
end
end

Wow, good catch! We'll see about fixing this. Thanks!

More lucky . . . went down a rabbit hole it was a mishandled sql issue until I read the oldie documentation
Which is kind of a compliment that the action network rest api gem is so good that I did not need to read the documentation
I also added some methods in people to get lists of  signatures and tagging for a person - was pretty easy but suspect better to do using method missing and a list of such information sources
( which is provided in the people.list response )
I have a question as I am getting occasional strange response ( error responses ) from the signing of a petition
I know that signing fails is  the address of the signing person is greater than 50 characters

I thought it might have been certain characters so I removed / and ‘. That worked but it may have been an incidental shortening to less than 50 char
I have also had problems with long person names
( not sure if its length of given plus family name or either )
I did not look methodically and just shortened a name so it worked

Action Network support were not very helpful and the error message - you have uncovered an error and we are looking into it is also unhelpful
Just wondering if you have any ideas how / where why to go about solving this
PS - the API is neat - I should dig deeper to see how it hangs together
M

On 19 Jan 2023, at 12:50 am, Grey Moore @.***> wrote:
Wow, good catch! We'll see about fixing this. Thanks!
—
Reply to this email directly, view it on GitHub https://github.com/controlshift/action-network-rest/issues/24#issuecomment-1387104807, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJIP2YDJWADQD7PEEHJOB3WS7YI7ANCNFSM6AAAAAAT6MUQ3Q.
You are receiving this because you authored the thread.


Fix a typo

fix a url mistake when using "git clone"

Hi @whsyourdaddy!
Thank you for your contribution! We use https://cwiki.apache.org/confluence/display/IMPALA/Using+Gerrit+to+submit+and+review+patches to submit and review patches. I hope you'll be able to contribute over there.


Update Result.cs

Fixes results table output for console applications.

Thanks!  Awesome benchmark tool... I use is all the time.


nix-push fails on Darwin when build-use-chroot = true

(I filed this bug on nix as well but I'm not getting any traction there. See https://github.com/NixOS/nix/issues/673. Anyway, it's not clear to me where this should be filed so I'll try here as well.)
I use Nix on several OS X machines, all with an identical environment, so I've recently been building packages on one of them and then pushing the binary packages to my own binary cache, so that the other machines can simply download and install them directly. The relevant part of the script looks like this:
nix-push --dest ~/Documents/nix-binary-cache/ --link --url-prefix http://nix-binary-cache.drewhess.com/ $(nix-instantiate '<nixpkgs>' -A meta-env)
(meta-env is the collection of all the packages I use in my environment, so that I can rebuild them with a single nix-env command.)
I've switched to the new Darwin pure stdenv and sandboxed builds. That all works great and I was able to rebuild my whole environment from scratch successfully. However, now the binary cache script fails on the nix-push step like so:
warning: you did not specify ‘--add-root’; the result might be removed by the garbage collector
warning: you did not specify ‘--add-root’; the result might be removed by the garbage collector
building compressed archives...
...
  /nix/store/znd6apsyigf80vzyxg5651ip345fzxay-bash43-033
  /nix/store/zsifjqz8x8r2w5wb7379d00hbqv5pzhh-nss-3.20.1.tar.gz
  /nix/store/zzxwmlxqygvi1micr7715xfnw33l4y8q-Libc-997.90.3
building path(s) ‘/nix/store/c5q2ry5qmgb0wh000lz9vfrinf5ks6s4-nar’
dyld: Library not loaded: /usr/lib/system/libcache.dylib
  Referenced from: /nix/store/v81lhzyangi203cgbx1w82dxscmlgyqf-Libsystem-1197.1.1/lib/libSystem.dylib
  Reason: no suitable image found.  Did find:
	/usr/lib/system/libcache.dylib: stat() failed with errno=1
builder for ‘/nix/store/01rphiz5ppz5g38sivx24949013xd6dk-nar.drv’ failed due to signal 5 (Trace/BPT trap: 5)
error: build of ‘/nix/store/01rphiz5ppz5g38sivx24949013xd6dk-nar.drv’ failed
nix-build failed: 25600 at /Users/dhess/.nix-profile/bin/nix-push line 168.

If I remove build-use-chroot = true from my nix.conf, it appears to work but starts a full rebuild of meta-env, which is obviously not what I want.

are you using latest nix ( https://nixos.org/wiki/Nix_on_OS_X#Install_a_recent_version_of_Nix )?

Yes, compiled from Git.

@copumpkin maybe there should be an umbrella issue for Darwin sandbox support? I didn't find one and it would be nice to have all information concerning sandbox support in one place.

@retrry that sounds good. Want to make one for nixpkgs? We can then link it to a nix issue, and I'll work on it eventually if nobody gets to it first.

@copumpkin I think you should make it as you have knowledge about current state and I'm only trying to research it.

I haven't used Darwin sandboxes for months, so I'm not even sure this is still an issue. What is an issue, however, is that non-sandboxed Darwin stdenv won't build from master (and hasn't since around April 1?). Is this a known problem? Is anybody maintaining the Darwin port?

@dhess is there an issue filed for that? I fixed a bug in the stdenv a few days ago and it seemed to work fine after I fixed it. I haven't had much time for nixing recently so I'm not actively monitoring whether something passes or fails, but if someone highlights me in a bug that breaks the entire platform, I'll generally make some time to look into it.

No issue filed last I looked, no. I haven't tried in a few days, let me pull master and try again.

Yep, Darwin stdenv builds again. Thanks!
However, I'm still building non-sandboxed so I can't say whether this particular issue (i.e., this nix-push issue) is resolved. According to the wiki, Darwin sandboxed builds are known to be broken; is that still the case?

'nix-push' is no longer supported on Nix.


designate the new primary computer - perform on all nodes, or only the original primary computer?

Existing instructions state...
On the original AD FS Windows Server 2012 R2 server, open PowerShell and run the following cmdlt: Set-AdfsSyncProperties -Role SecondaryComputer -PrimaryComputerName {FQDN}
Do you ALSO do...
Set-AdfsSyncProperties -PrimaryComputerName {FQDN}
...on all other ADFS servers as well?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ebfd725f-1b77-751c-1948-f8f88d26a9bc
Version Independent ID: 7d9c78d9-7736-8f0a-9636-269125a10d6f
Content: Upgrading to AD FS in Windows Server 2016
Content Source: WindowsServerDocs/identity/ad-fs/deployment/upgrading-to-ad-fs-in-windows-server.md
Product: windows-server-threshold
GitHub Login: @billmath
Microsoft Alias: billmath

Yes, you have to do it.

Promote the new ADFS 2016 Server to be primary
Demote the orignal one
update the primary server on all other secondary ADFS servers


Unable to resend messages from Oracle database in combination with message store listener

Describe the issue
On our TST environment we are suddenly unable to resend messages from an error storage for a message store listener.
When I press the resend button from, it shows me the following error:
Unable to resend message [173383]. cannot deserialize message: (SQLException) SQLState [99999], errorCode [17004]: Ongeldig kolomtype.: getString/getNString not implemented for class oracle.jdbc.driver.T4CBlobAccessor

At first I thought this may be related to installed Oracle driver, after checking the inventory I found out that on ACC/PRD environments we run the same Oracle driver:

On ACC we run FF! 7.6-20210219.093411 and on TST we run FF! 7.7-20210416.101648.
stacktrace-resend.txt
Reporter
Laurens

To Reproduce
Steps to reproduce the behavior:
Contact me please
Screenshots
If applicable, add screenshots to help explain your problem.
Configuration
Please provide the configuration of the Pipe or Receiver with the problem.

Input
Please provide an example of the input message.
Alternatively, provide a Ladybug report.

Environment
FF! 7.7-20210416.101648: Ibis4Navigator
Running on XXXX using IBM WebSphere Application Server/8.5
Java Version: Java(TM) SE Runtime Environment (<IP_ADDRESS> - pxa6480sr6-20191107_01(SR6))
Heap size: 1013M, total JVM memory: 2048M
Free disk space: 1GB, total disk space: 2GB
Up since: 2021-05-13 22:30:21 (4d)

Additional Environment

DBMS: [e.g. Oracle, MSSQL, MariaDB, MySql, PostgreSQL] Oracle
Browser: [e.g. Chrome, Safari, Edge, Firefox] Chrome

Additional Context
Add any other context about the problem here. (f.e. ladybug report / test adapter with larva test)

NVM, appearently there were some issues during deployment...

Occurs aswell with FF! 7.7-20210416.101648

Occurs aswell with 7.6 snapshots
FF! 7.6-20210303.212934: Ibis4Input
Running on srtzzapp0401.insim.biz using IBM WebSphere Application Server/8.5
Java Version: Java(TM) SE Runtime Environment (<IP_ADDRESS> - pxa6480sr6-20191107_01(SR6))
Heap size: 413M, total JVM memory: 581M
Free disk space: 10GB, total disk space: 10GB
Up since: 2021-05-25 08:41:44 (56m)

Can you upgrade the Oracle driver to a supported version (12.2.01 or 18.3.0)? And make sure only one version it used (in the last two rows of your screenshot we see multiple versions)

Yes it mentions multiple directories on the server for different drivers but when you take a look at current driver and used driver it only mentions one driver.
Where can I find an overview of actually supported drivers? If this has changed, why has this not been communicated in release notes or another way?
I see 18.3.0 is not being used at our client and <IP_ADDRESS> is barely used by any application.. would this mean that every IBIS application is currently using the wrong driver? That seems very odd to me.

A fix for a similar issue (#1729) appears to be made in PR #1731. Could you upgrade your framework, and verify the problem still exists in that version?

@Laurens-makel I found out the overview you copied from cannot be fully trusted. Please check the used driver in the security tab of the frankconsole it is part of the database connection string

Laurens retested with suggested driver version and this solves the issue


[Not Review] Enable profile with detail nvtx tag.

PR types

Others
PR changes

Others
Description

rt

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


update to the PR Owners responsibility

This PR will address issue: 2006
Added "It is ultimately the PR creator's responsibility to see that the PR gets assigned to appropriate           reviewers and ping reviewers as needed" under "Quirks of the process / Reviewers, and approvers are unresponsive" section.
/assign @jlewi

/lgtm
/approve


Scapbook find caused error "query selector must be an object"

Hello,
ok I'am new in mongodb but I whant to teach my students (I'am a teacher) how to use MongoDB (as an example for a nosql database).
So why the command 'db.schueler.find({"name": "tuttas"})' in the Srapbook cause the error "query selector must be an object" !?! in the shell mongodb.exe everythink workes like expected, but I what to use the Scapbook in VS Code as the shell!
Looking forward to hear from you.
best regrads

same problem as @jtuttas . every query which has a query selector fails. Only db..find() with empty selector works.