Lower vs. higher routing priority

There is a mistake in the Front Door routing section: "Set the backend pool with different priority values, 1 for the active region and 2 or lower for the standby or passive region." It should be 2 or higher. According to https://docs.microsoft.com/en-us/azure/frontdoor/front-door-routing-methods#priority lower means higher priority.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0c0c2a8-94a0-67ef-602a-6013bc7aa403
Version Independent ID: 27705eeb-7853-bd5d-58ac-a07bd6a8a79d
Content: Highly available multi-region web application - Azure Reference Architectures
Content Source: docs/reference-architectures/app-service-web-app/multi-region.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @MikeWasson
Microsoft Alias: pnp

@mreinli
Thanks for your feedback! We will investigate and update as appropriate.

Thanks. I made a pull request to add this. CC: @MikeWasson
https://github.com/MicrosoftDocs/architecture-center/pull/1880
(I was only able to make a public PR since I don't have access to this repo.)


Initial sponsors setup

[ ] New Sponsor model
[ ] New /sponsors page
[ ] Included platinum sponsor logos on homepage
[ ] "Sponsored by" option on classes and meetings
[ ] Ad placements when no active sponsorships
[ ] Link to '/sponsors'  in footer and homepage copy

@bkellgren Can you chance the css/html classes from 'ad-*' to something else since adblock blocks classes like that.


[WIP] add directory encoding test in test_conf

checking windows test here

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Message

:book:
See http://keepachangelog.com/en/0.3.0/ for details on good changelog guidelines

  Generated by :no_entry_sign: Danger


merge main back into develop

This does not change any code.
Apparently, the tag 0.4.9 needs to be in the ancestors of develop in order to be able to pip install ./anemoi-utils with the right version number.
Currently, doing pip install -e ./anemoi-utilsinstalls the right code but with a version number as 0.4.6+.... This makes pip to complain about version conflict issues when a package is requesting anemoi-utils version >= 0.4.9.
(In the future, the tag may need to be put on the develop branch, or this merge back to main should be automated.)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.86%. Comparing base (2837ecd) to head (c3d3283).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #63   +/-   ##
========================================
  Coverage    71.86%   71.86%
========================================
  Files            7        7
  Lines          263      263
========================================
  Hits           189      189
  Misses          74       74

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add events source to heapster

This implements the first part of #118 Follow up PR will handle events from the sink side.
Related Kubernetes Issues:

GoogleCloudPlatform/kubernetes/issues/4432
GoogleCloudPlatform/kubernetes/issues/5638

Can one of the admins verify this patch?

ok to test

Build is failing on Travis.

LGTM. Adding a unit/e2e test will be helpful in the long run. Again not required for this PR.
I will merge as soon as the unit tests are fixed.

PTAL


Set up parameter groups (cloudformation)

Parameter groups allow us to organize parameters for them to make most
sense.
This should help make setup a tiny bit smoother.
https://medium.com/slalom-technology/how-to-make-friendly-parameters-for-the-cloudformation-console-f546ffdbeace

@fuziontech is definitely more suitable than me to review this


Updates for JL-1.0.0rc.0

I don't know whether the renderer.ts change (not the formatting ones, but the one changing OpenMsg to MsgMsg) is correct or not.
The rendermime now being part of the content field certainly is.

Had completely overlooked this PR and spent an hour trying to figure things out 🤦♂
Will merge this, rebase my PR and then release on npm.


Deserialize Activity with default timestamp ("0001-01-01T00:00:00") failed on machine with Postive UTC

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
4.0.7
Describe the bug
It throws exception “Could not convert string to DateTimeOffset” when send activity to skill service with default timestamp ("0001-01-01T00:00:00")
There is a discussion in StackOverflow about this issue and have a workaround before the bug resolved in Newtonsoft package.
Th open bug for Newtonsoft.Json
To Reproduce
Steps to reproduce the behavior:

Send an activity with default timestamp ("0001-01-01T00:00:00") to skill service
You can see there the service returns 500 internal error and with error message "Could not convert string to DateTimeOffset: 0001-01-01T00:00:00. Path 'timestamp', line 1, position 70."

ExceptionType | Newtonsoft.Json.JsonReaderException
Message | Could not convert string to DateTimeOffset: 0001-01-01T00:00:00. Path 'timestamp', line 1, position 70.
StackTrace |    at Newtonsoft.Json.JsonReader.ReadDateTimeOffsetString(String s)
at Newtonsoft.Json.JsonTextReader.FinishReadQuotedStringValue(ReadType readType)
at Newtonsoft.Json.JsonTextReader.ReadAsDateTimeOffset()
at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonSerializer.Deserialize[T](JsonReader reader)
at Microsoft.Bot.Builder.Integration.AspNet.Core.Handlers.BotMessageHandler.d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Bot.Builder.Integration.AspNet.Core.Handlers.BotMessageHandlerBase.d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.Builder.Extensions.MapMiddleware.d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.Builder.RouterMiddleware.d__4.MoveNext()

Expected behavior
Deserialize the timestamp information successfully
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
[bug]

Update to team: emailed @zongbingwang for some clarification, and expect the response to be slightly delayed (away on holiday).

No doubt this is a bug, but, if I may ask, under what circumstances would you ever expect to receive an activity with that time in it? This just seems contrived and easily worked around by just not ever using that value since it shouldn't ever pop up in a real world scenario anyway.
Are you perhaps concerned about the fact that it's a possible issue for bots not behind the Bot Framework Service to be DoS'd by bad values being sent due to the overhead of the exception being generated???

While publishing bot on Skype channel; faced this issue; resolved using the @liamkernighan middleware fix


Berlin support

Meta-source: https://github.com/ethereum/eth1.0-specs/blob/master/network-upgrades/berlin.md
EIPS:

[x] https://eips.ethereum.org/EIPS/eip-2565 at #1972
[x] https://eips.ethereum.org/EIPS/eip-2718 at #1973
[x] https://eips.ethereum.org/EIPS/eip-2929 at #1974
[x] https://eips.ethereum.org/EIPS/eip-2930 at #1975 (note dependencies)

Tests:

[x] Upgrade to v8 #1985
[x] Enable Berlin CI job #1991

No longer scheduled:

[x] ~https://eips.ethereum.org/EIPS/eip-2315 at #1926~
[x] ~2537 at #1927~

Do you have an estimate on when this will be finished and released?

Yes, my estimate is... sometime today :)

... and it's out https://py-evm.readthedocs.io/en/latest/release_notes.html#py-evm-0-4-0-alpha-1-2021-03-22


Consider replacing Syntastic with Ale

Vim Bootstrap currently uses Syntastic for linting. However, as of Vim 8, there is support for async plugins. The plugin Ale does the same job as Syntastic, but does so asynchronously. This means that the user can get feedback as they type, without pauses for the linter to process. The impact of this cannot be overstated; a plugin that does its work slowly and only on demand is a plugin that soon ceases to be used.
Migrating from Syntastic to Ale is pretty frictionless from my experience.
Thoughts?

Unfortunately ubuntu LTS still remains in version 7. We already consider this change, it's a question of time.

Is it not something that could be installed conditionally? It seems like Vim Bootstrap already checks the Vim version for some other features.


v10.0.1 : TypeError: Object(...) is not a function

I'm submitting a ...  (check one with "x")
[x] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[ ] feature request

It seems I'm not the only one : https://www.reddit.com/r/Angular2/comments/88rf25/angular_translations/
Error :
AppComponent_Host.ngfactory.js? [sm]:1 ERROR TypeError: Object(...) is not a function
    at TranslateFakeLoader.getTranslation (ngx-translate-core.js:23)
    at TranslateService.getTranslation (ngx-translate-core.js:556)
    at TranslateService.retrieveTranslations (ngx-translate-core.js:543)
    at TranslateService.setDefaultLang (ngx-translate-core.js:483)
    at new AppComponent (app.component.ts:43)
    at createClass (core.js:10382)
    at createDirectiveInstance (core.js:10217)
    at createViewNodes (core.js:11674)
    at createRootView (core.js:11563)
    at callWithDebugContext (core.js:12929)

Expected/desired behavior
Works fine with previous version 9.1.1
Reproduction of the problem
app.components.ts :
  constructor(private translateService: TranslateService,) {
    this.translateService.setDefaultLang('fr');

Please tell us about your environment:

ngx-translate version:  10.0.1

Angular version: 5.2.9

Browser: [all]

For those who need the old version you need npm i<EMAIL_ADDRESS>There is example here.

https://github.com/ngx-translate/core

I had been struggling with the issues for two days. after taking a look at it. it worked for me. thx

If you are using http-loader, the compatible version is 2.0.1:
npm install<EMAIL_ADDRESS>--save

run  npm i<EMAIL_ADDRESS>on command prompt working fine for me.

For those who need the old version you need npm i<EMAIL_ADDRESS>There is example here.

Thanks!!!!

to use 9.1.1 version worked for me,thank u!!!

#FriOne sir,i have already installed this plugin but again got same error Object(...) is not a function ; Zone:  ?


Fails to build on 32 bit arch (i386)

FreeBSD 12.3 i386 / go 1.19.3
Building https://github.com/go-git/go-git:
pjbgf:sha1cd:v0.2.0:pjbgf_sha1cd/vendor/github.com/pjbgf/sha1cd
# github.com/pjbgf/sha1cd/cgo
vendor/github.com/pjbgf/sha1cd/cgo/sha1_nix.go:19:31: cannot use (_Ctype_ulong)(len(p)) (value of type _Ctype_ulong) as type _Ctype_uint in variable declaration

Are i386 or other 32 bit archs supported?
Thanks

I see the same error but on gcc x86_64-pc-msys 11.3

Hello @nunotexbsd,
Can you try my PR to see if it fixes your issue?
You can use the following directive in your go.mod file:
replace github.com/pjbgf/sha1cd v0.2.2 => github.com/yann-soubeyrand/sha1cd fix-type-cast.

github.com/pjbgf/sha1cd v0.2.3 has now being released with the fix.


Change all references to Hydroshare or xDCI to MyHPOM

Change all references to Hydroshare or xDCI to MyHPOM
FWIW, I'm referencing the site available to the web.

Site name that shows up in tab still says ‘ | hydroshare’
There are buttons that need to have updated text, e.g. the button on the sign-up page has xDCishare.
Substitute reference to CUAHSI in copyright statement with ‘The Carolinas Center’ and update year to 2017
Change ‘This is xDCIShare version DEVELOPMENT’ to swap in MyHPOM
Look around for any other references, e.g. the site map page refers to xDCIShare

LC_CTYPE=C && LANG=C && find . -type f | grep -v "./..*" | xargs grep -l "xDCIShare" | xargs sed -e "s/xDCIShare/MyHPOM/g" -i ".sedbak"

Merged in #36.

Deployed to myhpom.renci.org


Experiment updates

Brief description
Changes to the experiment class to make it consistent with the methodtime branch
Fixes part of https://github.com/fpsim/fpsim/issues/303 - the inf value is gone from the model but not the data
Refactors the lists of lists stored in the people results, replaces them with arrays.
Type(s) of change

[X] Bugfix
[X] Refactor
[ ] New feature
[ ] Other

Checklist

My code follows the style guide

[X] Yes
[ ] N/A

I've commented my code

[X] Yes
[ ] N/A

I've incremented the version number

[ ] Yes
[X] N/A

I've updated the changelog

[ ] Yes
[X] N/A

I've added tests and checked code coverage

[X] Yes
[ ] N/A

what's the status on this one @robynstuart ?

@emilydriano I'll fix the tests and merge it into the methodtime branch, then the whole thing can be reviewed together. Need to make a plan for how that branch gets managed, I'll post some suggestions on https://github.com/fpsim/fpsim/pull/280

merging with methodtime


Always allow calls to Authenticate to be called (even when request queue is paused)

Details
We missed this teensy little detail (that entirely breaks the re-authentication flow 😅 ) in https://github.com/Expensify/Expensify.cash/pull/1075/files which ironically was supposed to fix some other sign in bugs. Nice!
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/149497
Tests

Set up quickly expiring authTokens in Auth (5 seconds)
Navigate to chrome dev tools Application tab
Verify that once you log in your authToken exists
Wait until it expires
Do something that would trigger a network request like mount a new chat
Verify the authToken updates indicating that it expired and we reauthenticated you

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Gonna merge this so we can get chat authentication working again.


socket2 updated

Your dependency crate socket2 has been updated 15h ago. So that your code failed to compile with the latest socket2. I will appreciate if you could adapt this change as soon as possible.

See https://github.com/hyperium/hyper/issues/2270#issuecomment-674127953

Thx！


Adicionado badge do codecov ao README

Codecov Report

Merging #8 (7bf9685) into main (989aec5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   80.48%   80.48%
=======================================
  Files           7        7
  Lines          41       41
=======================================
  Hits           33       33
  Misses          8        8

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Auto scale of the range windows

Joulescope model
JS220
UI version
1.0.31
What OS are you seeing the problem on?
Windows 10
What happened?
First issue:
When select Rightclick/ Range / Auto on the range windows, the range appears on the top of windows, not in the middle like current or voltage.

Second issue:
In manual scale, When I zoom out using the mouse cursor, the scale disappears. This happens on all windows (Current, Voltage, Power, Range).

What was expected?
For the second issue I recommend a maximum scale. The joulescope cannot measure kA...

How to reproduce?

...
...
...

Extra information
No response

Hi @Nono-73
Issue 1
This issue occurs because there is no variation on the current range waveform.  The existing code was zooming to a 1e-9 range in this case.  However, it performed math on 32-bit floating points, which was not enough to accurately represent the zoom range 1e-9 with the average value 5.   32-bit float only has a 23-bit mantissa, which represents 1.2e-7 relative minimum increment.  I changed this to fix the maximum current range zoom and also I changed this to compute the a zoom that is sufficiently represented within 32-bit floating point math.  Fixed.
Issue 2
The labels disappearing on the current waveform is due to the waveform widget attempting to display grid lines outside of the valid range.  Here is the error:
  File "C:\repos\Jetperch\pyjoulescope_ui\joulescope_ui\widgets\waveform\waveform_widget.py", line 1635, in <listcomp>
    y_grid['labels'] = [_JS220_AXIS_R[int(s_label)] for s_label in y_grid['labels']]
                        ~~~~~~~~~~~~~^^^^^^^^^^^^^^

We can fix this to not throw an error.   However, zooming to display more than the valid set of current range values is really not useful.
I do not see the labels on the other plots disappearing when zoom out.  Instead, the labels eventually all become 0.  This was due to a computational error for how the code was forcing zero to display as zero and not some floating point residuals.  Fixed.
Issue 2b
I believe that the request here is for each plot to implement a meaningful upper & lower bound.  Ideally, these would come from the connected sources that are being displayed.  However, we can pick something since no Joulescope product has plans to support TA (10^12).
We do have plans to allow for scaling factors for voltage dividers and external current shunts.  To allow for these, we need ranges bigger than the JS110 and JS220 support.  I've added ±50 A, ±250 V, ±1000 W.  You will need to select File → Clear config and exit to get these when the next Joulescope UI release.  Fixed.
All of these fixes were in 79e27be and will be included in the next official release.

Addressed in 1.0.35.


pythonPackages.ansible2: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
Bump version to latest upstream release.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[x] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

New reverse dependency package kargo compiled just fine with nox-review and the binary seemed to function with basic CLI flags, but I wasn't sure how to test beyond that. Ansible itself was fine.

cc @copumpkin @jgeerds

Thanks! Already tested 2.2.0 at work :smile:


Class Based definitions don't work

In https://github.com/channelcat/sanic/blob/master/docs/class_based_views.md it describes how you would use a class based view. But doing it does not seem to work. I end up getting an "Object is not callable" exception:
Error: 'MyClass' object is not callable
Exception: Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/sanic/sanic.py", line 192, in handle_request
response = handler(request, *args, **kwargs)
TypeError: 'MyClass' object is not callable

Hold that thought, i may have been doing it wrong

Share the code?

你多半是add_route的时候没有实例话

bp.add_router(MyClass())

@AntonDnepr care to comment?

@Typhon66 do you inherit from HTTPMethodView?
Error: 'MyClass' object is not callable could mean that your class do not have call method, which is defined in HTTPMethodView.
In any case, I would like to have the whole code snippet it is hard to guess what goes wrong without it.

Was doing it wrong, missed the import.


Threshold Custody Backend

Closes #3342.
One change that could be made in a subsequent PR is to slim down the config struct to only save the minimum number of items, deriving everything else dynamically. This can be bundled into the next PR which adds this config to PCLI.

@cronokirby This needs a rebase, mind handling?


'container.contentOffset={x:x,y:y}' is null

if I push one page after another page then I want to pop first page (first page have lazyload) then have a problem. it is
[error][tid:com.facebook.react.JavaScript] null is not an object (evaluating 'container.contentOffset={x:x,y:y}') 2017-08-13 00:21:21.290 [fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: null is not an object (evaluating 'container.contentOffset={x:x,y:y}')

The reason is when you unmount the second page, lazyloadManage will set the container to null, however if the name of lazyloadScrollView in your second page is the same with the first page, when you return, the container in the first page will be null.
I encount the same problem, and I am now trying to solve it.


Remove white-spaces

Docs Build status updates of commit ab97638:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/webapi/customize-formatter.md
:warning:Warning
View
Details

Odata-docs/webapi/customize-formatter.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Looks like there is a lot of documents that's missing author.


Deprecate custom AllGatherGrad implementation

What does this PR do?
Remove custom AllGatherGrad implementation in favor of torch.distributed's
Fixes #10445
Continues #10504
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @borda @awaelchli @rohitgr7 @akihironitta @tchaton

The app docs failure appears because it installs devel.txt which includes examples.txt and that installs PL master: https://github.com/Lightning-AI/lightning/blob/48993cb5ed9602e2cd462adca4dcf81ff2c7bb65/requirements/app/examples
But AllGatherGrad is not in master, only in this PR (as expected since this PR added it)
If this PR is force-merged then the above won't be an issue because the class will then be in master. I suggest we do this and pursue a fix in a separate issue. This will be a blocker for future PRs.


Ability to update Client Options on the Guzzle Client

I am connecting to a JSON-RPC service and used the generator to create my Client. This API requires a header for Authorization, but I don't believe I am able to edit the property $ClientOptions or the $client directly on the BaseJsonRpcClient.  Both properties are private, so I can not adjust the generated client to pass the additional headers that are needed.  Should $ClientOptions be a protected variable instead of private?  Perhaps even make the Guzzle Client a protected variable, so settings can be adjusted as needed?  Or another way would be to pass an optional parameter to the BaseJsonRpcClient constructor to use as the ClientOptions for the Guzzle Client.  My apologizes if I missed an obvious answer to this problem.  But I can't see a way to pass custom headers to the Guzzle Client.

Hello @jswinborne !
You're right.
I make $ClientOptions public, v3.0.2 released.


[vcpkg] [cuda] minor fixes for cuda and vcpkg

Describe the pull request

What does your PR fix?

it fixes the initialization order of some class attributes for vcpkg, clang raise an error (and ISO C++ requires field designators to be specified in declaration order)

minor improvement in cuda port, extract the version directly from the nvcc pattern VX.Y.Z and compare to declared variable CUDA_REQUIRED_VERSION instead of performing a check with hardcoded values. This improves maintainability, next time the required version is changed, it has to be changed in only one place.

Which triplets are supported/not supported? Have you updated the CI baseline?
No changes in terms of supported triplets

Does your PR follow the maintainer guide?
Yes

Thanks for your PR! Can you please correct the Version field in the cuda CONTROL file? You can get more information from maintainer-guide.md.

@LilyWangL oops my bad, done in 021cf61
(and sorry if I mixed 2 different topics in a single PR, but they are very minor fixes so I figured that it was not worth it)

Similar to #11322 for the CUDA part?

yes, but IMHO it's better to have a single variable CUDA_REQUIRED_VERSION rather than CUDA_MAJOR etc.
If you agree you can apply the small changes of this PR to yours and I'll drop mines here.

(and thanks for pointing it out, I should have checked open PRs before)

You can apply a review in the changes tab of my pr, and I will gladly accept it. Otherwise I can do it later

/azp run

I'm closing this pr because one contribution is already merged in #11239 and the other has been moved into #11322


How to run Super Resolution code?

I'm really struggling to figure it out. Thanks.

You would just run all the cells in the notebook that are for the SR ControlNet. Did you figure it out already or need more help?

`with torch.no_grad(), torch.cuda.amp.autocast(dtype=torch.bfloat16):
effnet_latents = core.encode_latents(batch, models, extras)
effnet_latents_up = torch.nn.functional.interpolate(effnet_latents, scale_factor=2, mode="nearest")
cnet = models.controlnet(effnet_latents_up)
cnet_uncond = cnet
cnet_input = torch.nn.functional.interpolate(images, scale_factor=2, mode="nearest")
# cnet, cnet_input = core.get_cnet(batch, models, extras)
# cnet_uncond = cnet
show_images(batch['images'])
show_images(cnet_input)
`
@dome272 I am confused by the above code snippet about super resolution.It seems to merely shows the result of direct upsampling.


feat: Impelement redis cache for MCA fetch and update

Type of Change

[x] Enhancement

Description

Implemented cache for MCA table.
Motivation and Context

Impelemente redis cache for mca fetch and update for reduced latency.
How did you test it?

Manual

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed submitted code

Rather than have two feature based calls in every caller, would it make sense to call a single function, always get_or_populate_cache and either

But this feature based call is table based like accounts_cache is for merchant connector account and merchant account would it make sense to add it in the generic function.


develop custom Autostaple/Autobreak algorithms

Currently, Autostaple and Autobreak (implemented in issue #80) rely on running cadnano v2 code on a back-end server. This was done to quickly push out the feature due to some urgent user requests. However, the cadnano v2 autobreak algorithm in particular is buggy and crashes on some designs.
We should develop our own heuristic to replace these algorithms and implement them in Dart. Alternately, there may be an alternate backend algorithm we can call based on recent experimental.

Meanwhile, we can use this issue to brainstorm what a good heuristic would look like. It seems related to issue #355, in the sense that both issues (the autostaple part of this issue) require us to choose good crossover positions between pairs of helices. Issue #355 is easier though, because it can suggest every least-strained crossover position, even though adding crossovers at all of those positions would not be a good idea. This issue is trickier, since we need to decide which subset of those crossovers to choose for autostaple.


[Storage] Jul19

Arch board review request link: #7070
File:

New File Copy - copy SMB attributes by default now and support more options
New Force Close Handles header - add a response header x-ms-number-of-handles-failed
File Lease - support lease on file
Premium File Share properties - add 4 response headers for GetShareProperties and 4 elements for ListShares, premium only

Blob:

Incremental Snapshot Header - supports a new header x-ms-previous-snapshot-url but only available for managed disk accounts
CPK-N (Encryption Scopes) - allow encryption with the name of an encryption key.

TODO:

[ ] Change log
[ ] Read.me

/azp run js - storage-file - tests
/azp run js - storage-queue - tests
/azp run js - storage-blob - tests

/azp run js - storage-file - tests

/azp run js - storage-file-share - tests


Resuming work on this library

Hi all, I'm back from a long break due to life stuff and will be checking out all open issues and pull requests - heard null safety is also on the master branch now, the package will be definitely getting an overhaul for that soon.

That's awesome to hear 🤗

Any plans for Nullsafety? :)


Dropdown or autocomplete text fields

The "who are you petitioning to" and "area" fields could be a drop down or an auto complete text field.

We surely want to keep it free-form input; how about we show suggestions when typing bu allow people to type anything they want?

yes, in that case, an autocomplete text field can be used.

Are you intereted in tackling this issue and sending us a PR? @Propo41

@omranjamal yes, I'll give a PR asap

Thanks. Keeping it assigned to you then.

@omranjamal we need to store some hardcoded values and/or store the ones that the users enter. Where do we save them? Database (would have to create a lookup table) or directly in the frontend for now? What do you prefer?

I think directly in the frontend for now, we'll figure out how to store it in a DB later.


HDDS-2622. Add config parameter for setting limit on total bytes of pending requests in Ratis.

What changes were proposed in this pull request?
RATIS-714 introduced a config setting for limiting the max number of bytes of pending requests. This Jira aims to add a config in Ozone to set the same in DN Ratis.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2622
How was this patch tested?
This patch only adds a config setting for Ratis. Testing will be done through CI.
P.S. This patch is dependent on HDDS-2595 (Ratis version update).

@lokeshj1703 thanks for the review. The compilation failure is because the ratis version needs to be updated. Once HDDS-2637 is committed, I will update the default byte limit and run CI again.

/retest

@hanishakoneru Thanks for the contribution! I have merged the PR to master branch.


Privacy Policy and ToS page heading are in English when site in LSQ

Prerequisites

[x] I've searched for existing issues

Describe the bug
The Privacy Policy and ToS page heading are not localized in French when the site is in LSQ. It does however work properly when the site is in FR.
To Reproduce
Steps to reproduce the behavior:

Go to https://accessibilityexchange.ca/lsq/about/privacy-policy
Notice the page heading is in English instead of French
Change the languages
Notice the other languages work properly.

Expected behavior
The page heading should be in French when in LSQ
Screenshots

Can look into customized fallbacks to globally support models using translations to have LSQ fallback to FR.


Incorrect cmdlet specified for "Export-BCCachePackage"

At bottom or article, I believe the PowerShell command should be "Export-BCCachePackage" rather than "Export-BCDataPackage".

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 89038717-1679-67bc-4073-b78d7344c079
Version Independent ID: 9a32fc98-556d-42b5-ef60-7c77b0d5be0f
Content: Create Content Server Data Packages for Web and File Content (Optional)
Content Source: WindowsServerDocs/networking/core-network-guide/cncg/bc-hcm/8-Bc-Data-Packages.md
Product: windows-server
Technology: networking
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Little issue that I have on migration

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When I do the command:
CREATE OR REPLACE FUNCTION public.ll_to_earth(float8, float8)
    RETURNS public.earth
    LANGUAGE SQL
    IMMUTABLE STRICT
    PARALLEL SAFE
    AS 'SELECT public.cube(public.cube(public.cube(public.earth()*cos(radians(\$1))*cos(radians(\$2))),public.earth()*cos(radians(\$1))*sin(radians(\$2))),public.earth()*sin(radians(\$1)))::public.earth';

It give me the error:
.ERROR:  syntax error at or near "\"
LINE 1: ...ublic.cube(public.cube(public.earth()*cos(radians(\$1))*cos(...

Expected Behavior
No response
Steps To Reproduce
Just try the command.
Relevant log output
.ERROR:  syntax error at or near "\"
LINE 1: ...ublic.cube(public.cube(public.earth()*cos(radians(\$1))*cos(...

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
v1241

Now I have another error:
root@docker:/bkp/docker/teslamate# docker compose exec -T database psql -U usr4tesla teslamate << .
drop schema public cascade;
create schema public;
create extension cube;
create extension earthdistance;
CREATE OR REPLACE FUNCTION public.ll_to_earth(float8, float8)
RETURNS public.earth
LANGUAGE SQL
IMMUTABLE STRICT
PARALLEL SAFE
AS 'SELECT public.cube(public.cube(public.cube(public.earth()*cos(radians($1))*cos(radians($2))),public.earth()*cos(radians($1))*sin(radians($2))),public.earth()*sin(radians($1)))::public.earth';
.
NOTICE:  drop cascades to 2 other objects
DETAIL:  drop cascades to extension cube
drop cascades to extension earthdistance
DROP SCHEMA
CREATE SCHEMA
CREATE EXTENSION
CREATE EXTENSION
**ERROR:  function radians() does not exist**
LINE 6: ...c.cube(public.cube(public.cube(public.earth()*cos(radians())...
                                                             ^
HINT:  No function matches the given name and argument types. You might need to add explicit type casts.

Thanks again
Denis

Hello,
thanks for reporting.
Please help us understand what your installation looks like and what you want to archive.

v1241

This Version does not exist.

Sorry... I didn't know the version of TeslaMate
Now I see it... is 1.29.2.
Yes... I try to restore the DB from a server to another.
But I want to ask something... is there possibility to backup the docker and put it on another server ?
Like usually dockers can do...
Thanks again
Denis

I want to ask another think please ...
Here it give me an error:
root@docker:/bkp/docker/teslamate# docker compose exec -T database psql -U usr4tesla teslamate << .
CREATE OR REPLACE FUNCTION public.ll_to_earth(float8, float8)
RETURNS public.earth
LANGUAGE SQL
IMMUTABLE STRICT
PARALLEL SAFE
AS 'SELECT public.cube(public.cube(public.cube(public.earth()*cos(radians($1))*cos(radians($2))),public.earth()*cos(radians($1))*sin(radians($2))),public.earth()*sin(radians($1)))::public.earth';
.
ERROR:  function radians() does not exist
LINE 6: ...c.cube(public.cube(public.cube(public.earth()*cos(radians())...
                                                             ^
HINT:  No function matches the given name and argument types. You might need to add explicit type casts.

But if I connect to pgsql and I send the \df command, I can see the "ll_to_earth" function.
So it was created even if it gave an error please ?
Thanks again
Denis
Thanks again

is there possibility to backup the docker and put it on another server ?

Docker handles the volumes on its own. You can copy the volume but when trying to use it on another machine it will fail. you can declare it as external but this will break other things. Therefore not recommended way in any project I am aware of.

I try to restore the DB from a server to another.

It is like

Backup on old system
Install TeslaMate on new system
Restore data on new system

I would suggest you start with a clean system, to have a clear and defined state. You can run a docker volume ls on new system to see the teslamate-db volume, then a docker compose down to then let you delete the database volume with docker volume rm xyz
Then you can follow above instructions.

Thanks a lot for your help... but I finally understand why I had some errors...
I had the docker compose file compiled with postgres version 13... :-(
I put version 16 and remake all from the begining and now it's all ok.
The problem that I have now is that I can't import 2 month of data from Teslafi...
I do all the procedure and I run it from web... here is the log:
2024-07-03 22:47:59.295 [notice] SIGTERM received - shutting down
2024-07-03 22:47:59.295 [info] Shutting down 2 sockets in 1 rounds of 2000ms
waiting for postgres at <IP_ADDRESS>:5432
[info] Found 2 file(s) at '/opt/app/import'. Starting in import mode!
2024-07-03 22:48:02.333 [info] Migrations already up
[info] Found 2 file(s) at '/opt/app/import'. Starting in import mode!
2024-07-03 22:48:03.563 [info] System Info: Erlang/OTP 26 (jit)
2024-07-03 22:48:03.563 [info] Version: 1.29.2
2024-07-03 22:48:04.188 [info] POST https://auth.tesla.com/oauth2/v3/token -> 200 (614.534 ms)
2024-07-03 22:48:04.188 [info] Refreshed api tokens
2024-07-03 22:48:04.200 [info] Scheduling token refresh in 6 h
2024-07-03 22:48:04.204 [info] Running TeslaMateWeb.Endpoint with cowboy 2.10.0 at :::4000 (http)
2024-07-03 22:48:04.204 [info] Access TeslaMateWeb.Endpoint at http://localhost
2024-07-03 22:48:04.396 [info] GET /
2024-07-03 22:48:04.397 [info] Sent 302 in 1ms
2024-07-03 22:48:04.400 [info] GET /import
2024-07-03 22:48:04.402 [info] Sent 200 in 1ms
2024-07-03 22:48:42.987 [info] Importing 2 file(s) ...
2024-07-03 22:48:42.990 [info] Starting logger for 'Tesa'
2024-07-03 22:48:43.092 [info] Import complete!

But when I connect to the pgsql and I made a select of data from that month I receive nothing:
teslamate=# select * from drives where start_date between '2024-04-01' and '2024-05-31' order by start_date;
 id | start_date | end_date | outside_temp_avg | speed_max | power_max | power_min | start_ideal_range_km | end_ideal_range_km | start_km | end_km | distance | duration_min | car_id | inside_temp_avg | start_address_id | end_address_id | start_rated_range_km | end_rated_range_km | start_position_id | end_position_id | start_geofence_id | end_geofence_id
----+------------+----------+------------------+-----------+-----------+-----------+----------------------+--------------------+----------+--------+----------+--------------+--------+-----------------+------------------+----------------+----------------------+--------------------+-------------------+-----------------+-------------------+-----------------
(0 rows)

Have you some ideea please ?
Thanks a lot again
Denis

now it's all ok.

Great to hear.

Have you some ideea please ?

Your query looks good and returns the correct entries on my side. I assume either a csv file error or a corrupt file.

I just download the csv files from TelaFi and make all steps here
Do you know if TeslaFi import is still work please ?
Thanks again
Denis

Do you know if TeslaFi import is still work please ?

For sure, see comments in #3431


Add a bazel rule to start a jtag server

Add a bazel rule to configure the chip for jtag and start an OpenOCD instance as a jtag server:
bazel run //hw/top_earlgrey:jtag_server

Q: Where is an appropriate location for this rule?  I have half a mind to locate it in //third_party/openocd, as in:
bazel run //third_party/openocd:jtag_server --//third_party/openocd:jtag_env=//hw/top_earlgry:silicon_creator

However, the chip initialization sequence (setting tap straps, etc) feels a bit more earlgrey specific, so I located it in //hw/top_earlgrey.

Nice thanks!
Can you cross reference this in the following docs?

doc/getting_started/using_openocd.md
doc/getting_started/setup_fpga.md

Done.

What, if anything, do we need to change or adjust to allow this to start a JTAG (openocd) server for the CW340?


Enhancements to make to the NSDP Platform

PAGES

Home page- 15 Goals; Top Tabs; Bottom Tabs

Icon in top left of Vanuatu Flag and National Sustainable Goals separated by a line similar to Germany example (file: NSDP-Flag_logo attached)

Top Tabs: 15 Goals; Evaluation; About Us; Useful Information; Government Financial Statistics; Disaster Statistics; Area Council Profiles; Languages. These Top Tabs to include drop down options (stated below)

NSDP watermark added to background of homepage without it being obscured (file: NSDP-Watermark attached)

Bottom Tabs: Download all data; link to VNSO website use image attached as icon (VNSO); link to DSPPAC website use image attached as icon (DSPPAC)

Evaluation Tab, sub-pages:

Data availability (downloaded able in image and csv)
Indicator overview (downloadable in image and csv)
Methodology (can copy from Germany example)

About Us, sub-pages:

The NSDP Online Platform (can copy from Germany example and adapt- including narrative of Open SDG)
Technical Advice (can copy from Germany example and adapt)

Useful Information, sub-pages:

2030 Agenda (copy from Germany example and adapt)
Publications (can ask DSPPAC for their Annual Development Reports which as evaluations of progress against the NSDP)

Government Financial Statistics

Indicator Page: To include paragraph outlining what Government Financial Statistics are and their importance. The indicator to be displayed in Graph and Table formats. Will have a number of disaggregations (attachment GFS-Vanuatu are 2020 figures of government spending and budget- both government and development partner contributions)
GFS-Vanuatu.xlsx. Have to think through what meta-data would look like for this. The disaggregation lines to be different colour option, and each point to be interactive so when hover over them, highlights all information- similar to Germany example.

Disaster Statistics

Prose Page: Write information, quote some statistics and include images

Area Council Profiles

Indicator Page: To include paragraph outlining what Area Council Profiles are and their importance (especially to disaster response). The indicator page to be displayed in graph, table and map format (in this order as time-series). Disaggregations we still need list from VNSO Section Social and Environment. Have to think through what meta-data would look like for this. The disaggregation lines to be different colour option, and each point to be interactive so when hover over them, highlights all information- similar to Germany example.

Languages: English, French and Bislama

Indicator Pages for Goals- Template (but also similar for GFS and Area Council Profiles)

Evaluation (sun, cloud, etc)
Arrows to move next or previous indicator
Disaggregation lines to be same colour as Goal- yellow, green , red
Target to be square at end (line maybe confusing with disaggregations)
Disaggregation line Key
Download information- image and csv
Meta-Data
Please find attached IndicatorPage-Layout_1 and 2. The page to include same template too, how page is sectioned

Most information above are enhancements taken from the Germany National Indicators Platform.
Additionally points of interest:

If want to report indicator with two different calculations and sources such as administrative data and survey on one graph, how do we do that?
The script to take meta-data from csv to platform, how is that done?
If want to create indicator Tier system similar to SDGs, how do we add that as a page similar to Data Availability?

Some of this may not be very clear, apologies for that, I can go over beginning of next session.
Thanks

@hugo-e-pigott I've pushed up some placeholder content and menu updates to get us started on this. Feedback is welcome.


Wiki Recipe | Sort by Component

Would like to create component subject targets for external links to point to (contextual deep links).
Maybe user some ASCII art to visually delineate.

This is done in v3.0. However there is still lots of on-going cleanup.


Bug: after closing private chat lobby becomes an active window

Expected: switch back to the previous window (Shout behavior).

Yeah, we had numerous discussions about this.
The history behind this is this behavior was lost when working on a better client layout. It was introduced as a bug in https://github.com/thelounge/lounge/pull/465 and then fixed (to the current solution) in https://github.com/thelounge/lounge/pull/489.
We attempted to bring back Shout's behavior you mentioned in https://github.com/thelounge/lounge/pull/503, but first we did not agree on this, but also there was a bug when browsing on channels across networks.
The conclusion of this was to defer this to the future "Home tab" described in https://github.com/thelounge/lounge/issues/791 and therefore the current behavior was and will be kept as such until then.
Anyway, a classic and infamous "it's not a bug, it's a feature" 😅


add integration test xml capture to ci

Documentation

[X] I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

Ok, apparently I can't get spell should be store_artifacts with an i not an e.


Fix #2573 - Prevent setting default static files when no static-file …

…options are defined in config file
If a configuration file is used, and if no static-file extensions are provided in the configuration file, then do not set the default static-file extensions.
Resolves https://github.com/allinurl/goaccess/issues/2573

Merged. Thank you!

Thank you!


Fix favicon not showing on non-home pages

Favicon doesn't show up on pages such as /read/.

Thank you!  I kept meaning to look at this!


Automated cherry pick of #10081: feat(notify): add default area code for mobile

Cherry pick of #10081 on release/3.7.
#10081: feat(notify): add default area code for mobile

Codecov Report

Merging #10082 (5f9cee4) into release/3.7 (0ff3997) will increase coverage by 2.06%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.7   #10082       +/-   ##
================================================
+ Coverage         5.98%    8.05%    +2.06%
================================================
  Files              848      107      -741
  Lines           131795    13000   -118795
================================================
- Hits              7887     1047     -6840
+ Misses          123206    11833   -111373
+ Partials           702      120      -582

Flag
Coverage Δ

aFlag
8.05% <0.00%> (+2.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/auth_totp.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/idp.go
1.84% <0.00%> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/resource.go
0.00% <0.00%> (ø)

pkg/hostman/diskutils/nbd/driver.go
0.74% <0.00%> (-0.01%)
:arrow_down:

pkg/hostman/diskutils/nbd/lvmutils.go
4.70% <0.00%> (-0.24%)
:arrow_down:

pkg/monitor/alerting/eval_context.go
34.25% <0.00%> (-2.75%)
:arrow_down:

pkg/compute/models/guestcdrom.go

pkg/util/seclib2/passwd.go

... and 662 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f02b5...5f9cee4. Read the comment docs.

Codecov Report

Merging #10082 (5f9cee4) into release/3.7 (0ff3997) will increase coverage by 2.06%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.7   #10082       +/-   ##
================================================
+ Coverage         5.98%    8.05%    +2.06%
================================================
  Files              848      107      -741
  Lines           131795    13000   -118795
================================================
- Hits              7887     1047     -6840
+ Misses          123206    11833   -111373
+ Partials           702      120      -582

Flag
Coverage Δ

aFlag
8.05% <0.00%> (+2.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/auth_totp.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/idp.go
1.84% <0.00%> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/resource.go
0.00% <0.00%> (ø)

pkg/hostman/diskutils/nbd/driver.go
0.74% <0.00%> (-0.01%)
:arrow_down:

pkg/hostman/diskutils/nbd/lvmutils.go
4.70% <0.00%> (-0.24%)
:arrow_down:

pkg/monitor/alerting/eval_context.go
34.25% <0.00%> (-2.75%)
:arrow_down:

pkg/compute/models/guestcdrom.go

pkg/util/seclib2/passwd.go

... and 662 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f02b5...5f9cee4. Read the comment docs.


expat: 2.2.0 -> 2.2.1

Motivation for this change
To bump to latest version. Also includes fixes for CVE-2017-9233 and CVE-2016-9063.
I did not do a nox-review wip since it wanted to rebuild 7000+ packages, should be perfectly backwards compatible, though.
CC @grahamc for security expertise
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

LGTM, thank you!

Backported in c28e6ee thank you!


Link deeper to doc content, simpler Docker README

Summary of Changes
Will scroll past GitHub repo folders (specially more handy on small screens like phones/tablets)
Like lyft/amundsendatabuilder#147
Also reduce duplication for Docker w/wo Gunicorn

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   74.85%   74.85%
=======================================
  Files          19       19
  Lines        1010     1010
  Branches       88       88
=======================================
  Hits          756      756
  Misses        231      231
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f00e8...d8f1ad8. Read the comment docs.

thanks @jornh


Add man page for bundle doctor

What was the end-user problem that led to this PR?
The bundle doctor command was missing a man page (see https://github.com/bundler/bundler/issues/6243).
What was your diagnosis of the problem?
Running bundle help doctor from the command line showed the description from cli.rb, but it wasn't displayed in the same format as commands with man pages. Documentation for bundle doctor was also missing from http://bundler.io/docs.
What is your fix for the problem, implemented in this PR?
I added a man page for bundle doctor.
Why did you choose this fix out of the possible options?
I chose this fix because the "Writing docs for man pages" documentation says...

Our goal is to have a man page for every command.

STOP
On Thursday, February 1, 2018, Nick Holden<EMAIL_ADDRESS>wrote:

@nholden commented on this pull request.

In man/bundle-doctor.ronn:

@@ -0,0 +1,33 @@
+bundle-doctor(1) -- Checks the bundle for common problems
+=========================================================

+## SYNOPSIS
+
+bundle doctor [--quiet]

[--gemfile=GEMFILE]

+## DESCRIPTION
+
+Checks your Gemfile and gem environment for common problems. If issues
+are detected, Bundler prints them and exists status 1. Otherwise,
+Bundler prints a success message and exists status 0.
Thanks for the good catch! I fixed the typos in c5f0852.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci6.googleusercontent.com/proxy/lMcEVpbzuOHmUrejL8ywxih7HHoObqVqrUB6Rkhs5dgOvf1vrN-j6SnCQInj4BkIxH39KZ089gBz3L4COzH5CdzHdZMbl5BBw5cMveTUX4IWiHXBfefkO3ZGADgmafdoDTARMvzKn0-vDjAGGtolssMloxu2dA=s0-d-e1-ft#https://github.com/notifications/beacon/AduoonyPQ82rLclaQ_37O_4WJ3HX1Lqsks5tQdSPgaJpZM4Rqriz.gif>

Hey, @portexedge! If you're trying to unsubscribe for emails about this repository, head over to https://github.com/bundler/bundler, log in, click the "unwatch" button toward the top right of the page, and then select "not watching."

@bundlerbot r+


How to validate bip32 xpub keys and bitcoin addresses?

I hope I'm in the right place, as the title suggests I'm looking for a way to check if a string is either a valid bip32 pub key or a valid btc address.
Having a hard time finding a python function that achieves this, is this possible with this library and if so please could you give me a hint ;)
Thank you

Not to worry, I got it working using pycoin from Richard Kiss.

Did you ask the same question on Bitcoin SE?

Yes and I did get an answer but I ended up using pycoin
https://bitcoin.stackexchange.com/questions/37310/how-can-i-check-if-a-bip32-xpub-key-is-valid-using-python/37313#37313


Doesn't Rule 3.13 contradict 1.10?

3.13 says:

Re-subscribing with the same Subscriber object is discouraged [see 2.12], but this specification does not mandate that it is disallowed since that would mean having to store previously cancelled subscriptions indefinitely.

1.10 says:

Publisher.subscribe MAY be called as many times as wanted but MUST be with a different Subscriber each time

wouldn't the discouraged part of 3.13 result in a violation of 1.10 and thereby it is not just discouraged, but actually disallowed?
Or missing something?

1.10 defines permissible behavior of callers of subscribe, i.e. whoever calls that method must make sure to use a fresh Subscriber every time.
3.13 mandates that the Publisher drops all references to a Subscriber after the associated Subscription has been cancelled, meaning that the Publisher cannot be held responsible for enforcing that 1.10 is obeyed.
Hence, there is no contradiction, it is just that different parties are held accountable for different parts of the contract.

Thanks, that makes sense. Would be great to have this kind of stuff in some comments to the rules. But I think there is already an issue for that, right?

Yeah, I should get to that at some point. :S
I should try to set aside a week for that. If possible.

Perhaps start an FAQ in the mean time?
Could someone try to do that?

AFAIK solved by #339


fix(cdk): update package names for consistency and clarity

fix(cdk): update package names for consistency and clarity

Changed the package name from "@eliza/cdk" to "@elizaos/cdk" in both the root package.json and the cdk package.json.
Updated the build script in the root package.json to reflect the new package name, ensuring that commands are executed correctly.

These changes enhance consistency across the project and align with the naming conventions used in the repository.

#27  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 28, 12:13 PM EST: A user started a stack merge that includes this pull request via Graphite.


PE Analyzer Index 3968 out of bounds for length 3968

Hello!
Describe the bug
Trying to scan this artefact
https://repo.maven.apache.org/maven2/org/wildfly/wildfly-dist/26.0.1.Final/wildfly-dist-26.0.1.Final.zip
and got this error
An unexpected error occurred during analysis of '/var/folders/vy/dhppcn5d3ws8p8m03kjpt0s1gsp2ts/T/dctemp4fb7edfc-55e3-4423-ba6d-98c6f8a5cd9f/check5523144844114864788tmp/1/wildfly-26.0.1.Final/docs/contrib/scripts/service/amd64/wildfly-service.exe' (PE Analyzer): Index 3968 out of bounds for length 3968
When i try to scan manually extracted from archive wildfly-service.exe - there is no such problem.
7-0-4/bin/dependency-check.sh --scan /Users/user/PycharmProjects/Tools/scanners/target/wildfly-service.exe --format HTML --enableExperimental --noupdate --disableOssIndex --disableNodeJS --retireJsUrl http://<IP_ADDRESS>:8000/jsrepository/ --out report/wildfly-service.exe.html
[INFO] Analysis Started
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Assembly Analyzer (0 seconds)
[INFO] Finished PE Analyzer (0 seconds)
[INFO] Finished Dependency Merging Analyzer (0 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Created CPE Index (1 seconds)
[INFO] Finished NPM CPE Analyzer (1 seconds)
[INFO] Created CPE Index (1 seconds)
[INFO] Finished CPE Analyzer (1 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
[INFO] Finished Vulnerability Suppression Analyzer (0 seconds)
[INFO] Finished Dependency Bundling Analyzer (0 seconds)
[INFO] Analysis Complete (3 seconds)
[INFO] Writing report to: /Users/user/PycharmProjects/Tools/scanners/odc/report/wildfly-service.exe.html
Process finished with exit code 0
Version of dependency-check used
The problem occurs using version 7.0.4 of the cli
Log file
[INFO] Analysis Started
[INFO] Finished Archive Analyzer (12 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Jar Analyzer (1 seconds)
[INFO] Finished Central Analyzer (66 seconds)
[INFO] Finished Assembly Analyzer (0 seconds)
[INFO] Finished Python Distribution Analyzer (0 seconds)
[WARN] An unexpected error occurred during analysis of '/var/folders/vy/dhppcn5d3ws8p8m03kjpt0s1gsp2ts/T/dctemp4fb7edfc-55e3-4423-ba6d-98c6f8a5cd9f/check5523144844114864788tmp/1/wildfly-26.0.1.Final/docs/contrib/scripts/service/amd64/wildfly-service.exe' (PE Analyzer): Index 3968 out of bounds for length 3968
[ERROR]
java.lang.ArrayIndexOutOfBoundsException: Index 3968 out of bounds for length 3968
at org.boris.pecoff4j.io.ByteArrayDataReader.read(ByteArrayDataReader.java:61)
at org.owasp.dependencycheck.utils.PEParser.readResourceEntry(PEParser.java:754)
at org.owasp.dependencycheck.utils.PEParser.readResourceDirectory(PEParser.java:721)
at org.owasp.dependencycheck.utils.PEParser.readResourceEntry(PEParser.java:742)
at org.owasp.dependencycheck.utils.PEParser.readResourceDirectory(PEParser.java:721)
at org.owasp.dependencycheck.utils.PEParser.readResourceEntry(PEParser.java:742)
at org.owasp.dependencycheck.utils.PEParser.readResourceDirectory(PEParser.java:721)
at org.owasp.dependencycheck.utils.PEParser.readResourceDirectory(PEParser.java:711)
at org.owasp.dependencycheck.utils.PEParser.readImageData(PEParser.java:392)
at org.owasp.dependencycheck.utils.PEParser.readSection(PEParser.java:508)
at org.owasp.dependencycheck.utils.PEParser.read(PEParser.java:87)
at org.owasp.dependencycheck.utils.PEParser.parse(PEParser.java:52)
at org.owasp.dependencycheck.utils.PEParser.parse(PEParser.java:48)
at org.owasp.dependencycheck.analyzer.PEAnalyzer.analyzeDependency(PEAnalyzer.java:160)
at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131)
at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
[INFO] Finished PE Analyzer (0 seconds)
[INFO] Finished Dependency Merging Analyzer (0 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Created CPE Index (1 seconds)
[INFO] Finished NPM CPE Analyzer (1 seconds)
[INFO] Created CPE Index (1 seconds)
[INFO] Finished CPE Analyzer (5 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
00:00  INFO: Vulnerability found: bootstrap below 3.4.1
00:00  INFO: Vulnerability found: bootstrap below 3.4.0
00:00  INFO: Vulnerability found: bootstrap below 3.4.0
00:00  INFO: Vulnerability found: bootstrap below 3.4.0
00:00  INFO: Vulnerability found: jquery below 3.0.0-beta1
00:00  INFO: Vulnerability found: jquery below 2.2.0
00:00  INFO: Vulnerability found: jquery below 3.4.0
00:00  INFO: Vulnerability found: jquery below 3.5.0
00:00  INFO: Vulnerability found: jquery below 3.5.0
00:00  INFO: Vulnerability found: moment.js below 2.11.2
00:01  INFO: Vulnerability found: jquery below 3.5.0
00:01  INFO: Vulnerability found: jquery below 3.5.0
00:01  INFO: Vulnerability found: jquery below 3.5.0
00:01  INFO: Vulnerability found: jquery below 3.5.0
[INFO] Finished RetireJS Analyzer (13 seconds)
[INFO] Finished Vulnerability Suppression Analyzer (0 seconds)
[INFO] Finished Dependency Bundling Analyzer (1 seconds)
[INFO] Analysis Complete (107 seconds)
[INFO] Writing report to: /Users/user/PycharmProjects/Tools/scanners/odc/report/exe.html
[ERROR] Index 3968 out of bounds for length 3968
Process finished with exit code 0
To Reproduce
scan https://repo.maven.apache.org/maven2/org/wildfly/wildfly-dist/26.0.1.Final/wildfly-dist-26.0.1.Final.zip
Expected behavior
ODC report

When i try to scan manually extracted from archive wildfly-service.exe - there is no such problem.
7-0-4/bin/dependency-check.sh --scan /Users/user/PycharmProjects/Tools/scanners/target/wildfly-service.exe --format HTML --enableExperimental --noupdate --disableOssIndex --disableNodeJS --retireJsUrl http://<IP_ADDRESS>:8000/jsrepository/ --out report/wildfly-service.exe.html

For me it yields the same result as scanning the entire zipfile. Which to me is no surprise as there should be no difference as it is scanning the same executable.

We actually use https://github.com/whitesource/pecoff4j-maven, which is archived. We could switch to https://github.com/kichik/pecoff4j, which got more recent updates.
Issue has been reported on the new project: https://github.com/kichik/pecoff4j/issues/7

I included the newest kichik version 0.4.0 to try to fix this issue. But it gave the same results:
I just used the newest version of this code inside dependencyChecker in the hope that might fixes there <IP_ADDRESS>. version problems. Sadly it didn't: java.lang.ArrayIndexOutOfBoundsException: -16284
at com.kichik.pecoff4j.io.ByteArrayDataReader.read(ByteArrayDataReader.java:61)
at org.owasp.dependencycheck.utils.PEParser.readResourceEntry(PEParser.java:750)
at org.owasp.dependencycheck.utils.PEParser.readResourceDirectory(PEParser.java:717)
at org.owasp.dependencycheck.utils.PEParser.readResourceEntry(PEParser.java:738)
at org.owasp.dependencycheck.utils.PEParser.readResourceDirectory(PEParser.java:717)
at org.owasp.dependencycheck.utils.PEParser.readResourceEntry(PEParser.java:738)
at org.owasp.dependencycheck.utils.PEParser.readResourceDirectory(PEParser.java:717)
at org.owasp.dependencycheck.utils.PEParser.readResourceDirectory(PEParser.java:707)
at org.owasp.dependencycheck.utils.PEParser.readImageData(PEParser.java:392)
at org.owasp.dependencycheck.utils.PEParser.readSection(PEParser.java:509)
at org.owasp.dependencycheck.utils.PEParser.read(PEParser.java:87)
at org.owasp.dependencycheck.utils.PEParser.parse(PEParser.java:52)
at org.owasp.dependencycheck.utils.PEParser.parse(PEParser.java:48)
at org.owasp.dependencycheck.analyzer.PEAnalyzer.analyzeDependency(PEAnalyzer.java:160)
at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131)
at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:1)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

I am willing to work on this starting from 19. onwards, if thats good enough for u.


Use redux-actions

A lot of boilerplate can be avoided by implementing redux-actions.
This will also avoid having both 'success'  and 'failure' variants of each event.

Yes, i'd love to give it a try!


Missing features

I would like to see these features:

[ ] callback called on any text change when the search app is visible
[ ] close button instead of the back button is more common to dismiss the appbar.
Further user it appears like that navigation never change.
[ ] when the searchBar gets dismissed the last update should clear the search text (maybe that can be handled in the hosting code but it would be more elegand in the searchbar) This could be activated/deactivated with a bool in the constructor

I can provide them if you like

If you need to listen for text changes, I think the best way is to use a TextEditingController and call addListener to listen for changes in text values.
Feel free to implement the other two, but close/back button should probably be an option you can set in the constructor (it should default to back just for backwards compatibility).

Sounds good - I will provide a pull request asap

Just to clarify, the TextEditingController can be passed as an argument to the constructor of SearchBar currently (as controller)

Do you mind if I create a statefull widget out of it because the clear button has a state and  is only shown when the user entered text.  I did see the TextEditController, I agree with ur last statement. The function of the back button stays the same. All that should be compatible with the old paradigm.

I think I dont need no statefull widget - forgot that setState is required

@ride4sun  here is what I did to get those feature. https://gist.github.com/AppleEducate/932e9426b53468882717cf0f1b463a72

@AppleEducate thanks! I'll look into adding it into master sometime in the next few days.
Personally, I would recommend setting onChanged to a new ValueNotifier rather than allowing the user to set it -- the cost of holding a ValueNotifier is pretty tiny, and eliminates what will likely be a common source of user error.
Is this module really super useful though since Flutter has a first-class search widget now?

@ArcticZeroo I was not aware of the first class widget? I have been using this custom class since flutter beta 2. I had to pass the onChanged because I am calling an api for search results.

@AppleEducate here's some info on the first class widget (I don't see any docs for it):
https://github.com/flutter/flutter/pull/17629
https://github.com/flutter/flutter/blob/master/examples/flutter_gallery/lib/demo/material/search_demo.dart
Seems a bit over-involved to me, but it's not third party I suppose 🤷♂

I think thats why I didn't know about it. I usually go off the docs. Thanks! ill check it out 👍🏻


NameEmailSettingsPanel should be titled "Name" when email management is disabled

Issue Summary
As NameEmailForm handles working without email, NameEmailSettingsPanel should be titled "Name" when email management is disabled
Steps to Reproduce

WAGTAIL_EMAIL_MANAGEMENT_ENABLED = False in your settings
Go to your account

Can confirm this issue.

With WAGTAIL_EMAIL_MANAGEMENT_ENABLED = False. Observe the email is no longer editable but the panel title still says 'Name and Email'.

Potential fix
In wagtail/admin/views/account.py we could make the title dynamic as follows;
class NameEmailSettingsPanel(BaseSettingsPanel):
    name = "name_email"
    # title = gettext_lazy("Name and Email")
    order = 100
    form_class = NameEmailForm

    @property
    def title(self):
        from wagtail.admin.views.account import email_management_enabled

        if email_management_enabled():
            return gettext_lazy("Name and Email")
        return gettext_lazy("name")

I will flag this as a good first issue, this is quite simple to validate manually but will need unit tests for a PR.

Hello, I am new contributor here, Can I work on this issue?

@FatGuyy go for it.  Just put up a PR when you're ready.

Please remember to include unit tests.

I am super new, it might take a bit of time and a bit of help(I'll ask in slack [new contributors]), but get it done!

Can work on this issue. I want to contribute to Wagtail. and also I'm new to opensource so I want to start with good first issue

I'm afraid there is already a PR for this issue. Please do read https://docs.wagtail.org/en/stable/contributing/first_contribution_guide.html


Add 5 more APIs

Description
Added 5 more APIs to the api.json file.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable):

Thanks for contributing


Integrate validation into compatibility module

Validation is currently possible with core API functionality. Since it works on the dataset representation
        from ancpbids import BIDSLayout, validate_dataset
        dataset_path = './tests/data/ds005'
        layout = BIDSLayout(dataset_path)
        report = validate_dataset(layout.dataset)

this could be integrated into the compat module such that the call would be e.g.
      report = layout.validate()

What hat do you think?

Thanks!


SEO Boost: Updated SVG icons to be 48x48

Google Lighthouse reports one issue with SEO - the icons are too small to be mobile compatible.
This fix makes the icons a bit bigger to boost SEO.

Thanks for the more good ideas and the pull requests, I also noticed the note about the icons by google lighthouse.
I have a really large commit that I will be finishing up tonight or tomorrow, will review and merge these after I finish it.

No problem for the PRs. After using other themes, I found your theme is the closest to a fully featured website filling the same niche as Jekyll. I'm interested in contributing anyway I can, since this theme needs the least amount of work and has the most potential from my perspective.


Please add a command - PIP install Pillow

Please add the instruction "PIP install Pillow" somewhere in the page, without this users will get an error when trying to execute the line "from PIL import Image, ImageDraw".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d930c16-d536-f5d3-fed6-8e08a9d4ae19
Version Independent ID: 505b497d-5bb1-57c9-c400-8305e0a9300b
Content: Quickstart: Face client library for Python - Azure Cognitive Services
Content Source: articles/cognitive-services/Face/QuickStarts/python-sdk.md
Service: cognitive-services
Sub-service: face-api
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@samjones00
Thanks for the feedback! We are currently investigating and will update you shortly.

@samjones00 Hi Sam, thanks for the feedback. I have created a PR for that. It should be alive soon.
We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.


Make sure invalid configuration files are handled properly

There is just basic error handling for invalid configuration files it place. It needs revisiting and better communication for users (e.g. showing notifications).

This will be fixed by #15.


Touch feedback on Material widgets get stuck after beginning app switch gesture on iPhone Xs

Steps to Reproduce

Press and hold on a Widget with touch feedback, like an IconButton icon or a BottomNavigationBarItem.
At the same time, swipe left-to-right on the bottom of the iPhone to begin the app switch gesture. (You don't have to go all the way)

The touch feedback of those widgets will now be stuck. Touching them again does not fix it.

Sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: Text('Test'),
          actions: [
            IconButton(
              icon: Icon(Icons.refresh),
              onPressed: () {},
            ),
            IconButton(
              icon: Icon(Icons.more_horiz),
              onPressed: () {},
            ),
          ],
        ),
        body: Container(),
        bottomNavigationBar: BottomNavigationBar(
          items: [
            BottomNavigationBarItem(
              icon: Icon(Icons.map),
              title: Text('Map'),
            ),
            BottomNavigationBarItem(
              icon: Icon(Icons.location_on),
              title: Text('Nearby Stops'),
            ),
            BottomNavigationBarItem(
              icon: Icon(Icons.star),
              title: Text('Saved Stops'),
            ),
          ],
          onTap: (index) {},
        ),
      ),
    );
  }
}

$ flutter doctor -v
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.2 18C54, locale en-CA)
    • Flutter version 1.0.0 at /Users/ryan/Documents/flutter
    • Framework revision 5391447fae (8 weeks ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/ryan/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.3.3
    • Dart plugin version 182.5124
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] VS Code (version 1.30.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.21.1

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

@zoechi I cannot reproduce this with Flutter 1.7. Looks like it got fixed 🎉


Add payload to updateSubscription

Hi thanks for the PR, I'll take a look at this soon!

Thanks again, this'll be included in the next version!


Secrets discovery does not work for pod.spec.containers.envSource

Webhook discovers secrets referenced by the pod.spec.containers.env[] and pod.spec.Volumes[] but does not currently discover a secret name if you use pod.spec.containers.envSource[].

Addressed by https://github.com/boxboat/dockhand-secrets-operator/pull/23


Fix local variables being collected into module_arguments dict

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)

not these changes specifically but it was discussed that we should fix any issues

[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?
Fixes issues 6 and 7 in #1937

local variables that are not also init args will not be collected
"self", "*args" or "**kwargs" can now be renamed to something else  and collection still works
removed the redundant recursive child search because the "self" instance is ALWAYS the most specific type anyway.

The new tests that I added fail on master, proofing that the this PR actually fixes the issue.
I will follow up with another PR that will add even more tests for things like multiple inheritance etc.

kindly asking @yukw777 to also have a look at this since you were involved in the hparams PR.

the same as here https://github.com/PyTorchLightning/pytorch-lightning/pull/2039#issuecomment-637563521

I don't have any huge concerns about this. I do worry _collect_init_args() may be too brittle given the heavy usage of reflections, but I recognize why we need it... good test coverage and documentation would go a long way.

good test coverage and documentation would go a long way.

by a long way you mean it's not ready yet?
I would agree, yes. The todo list is still long and I have test cases in mind already to follow up. One thing we should take a close look at soon is multiple inheritance.

@awaelchli @Borda good effort on tackling this!
Let's get the following API implemented:
let’s do this:
case 1
User explicitly says what they want to save.
class LitModel(...):

    def __init__(self, conf):
        self.save_hyperparameters(conf)

Case 2:
User wants to save all the init stuff.
They can do it all manually or ask us to do it automatically
class LitModel(...):

    def __init__(self, arg1, arg2, arg3):
        # manually
        self.save_hyperparameters(arg_name=arg1, arg_name=arg2, arg_name=arg3)

        # equivalent automatic
        self.save_hyperparameters()

Case 3:
They want to save ONLY some of the init stuff
class LitModel(...):

    def __init__(self, arg1, arg2, arg3):
        # manually
        self.save_hyperparameters(arg_name=arg2)

Special cases:

namespace

    def __init__(self, hparams):
        # manually
        self.save_hyperparameters(hparams)

dict

    def __init__(self, some_dict):
        # manually
        self.save_hyperparameters(some_dict)

omniconf

    def __init__(self, conf):
        # manually
        self.save_hyperparameters(conf)

anything they want

    def __init__(self, some_random_alternative_to_config):
        # manually
        self.save_hyperparameters(some_random_alternative_to_config)

@PyTorchLightning/core-contributors

@awaelchli nah i just meant that as a general observation, not specific to this PR, which looks good to me!

case 1
User explicitly says what they want to save.
class LitModel(...):

    def __init__(self, conf):
        self.save_hyperparameters(conf)

is very tricky as we would need to do some pairing from init frame and hope none of the conf1, conf2, ... has the same value so I would skip this case...

Special cases:

namespace
dict

    def __init__(self, conf):
        # manually
        self.save_hyperparameters(conf)

here you want to unroll all elements?
assume you have some_dict=dict(a=1, b=3) then you would in fact do something similar like self.save_hyperparameters(**some_dict)
if fact
def save_hyperparameters(**kwargs):
    ...
    for elms in kwargs:
        if isisntance(conf, (dict, OmegaConf)):
            self.save_hyperparameters(**conf)
        if isisntance(conf, Namespace):
            self.save_hyperparameters(**vars(conf))
       ...

the API changes will be applied in #2047


incorrect fortinet password removal

fortinet passwords are encrypted in config, using the following syntax:
set password ENC <hash>

Netconan outputs the following after it anonymizes the password:
set password netconanRemoved0 <hash>

The has is not removed by the ENC syntax is (IE this is just stating Encrypted hash to follow.

Thanks @ryanmerolle - we'll fix this right off!

Thanks @ryanmerolle - we'll fix this right off!

We shipped netconan 0.12.1 with this fix: https://pypi.org/project/netconan/0.12.1/

We shipped netconan 0.12.1 with this fix: https://pypi.org/project/netconan/0.12.1/


System Sizing Macro Fails

For the default singleowner case, the system sizing macro fails with the following error message:
Getting input parameters.
Running simulation to get operating voltages.
Setting up scenarios.
Generating design suggestions  based on 25239 modules in library.
Macro did not finish.
[592] runtime exception at line 592: access violation: expected array for indexing, but found null

Not sure if this is due to the default size changes, or the updated module/inverter library changes.

I think my library updates (from today) fix the macro. I am getting this error:

But that seems like a administrator issue rather than a SAM issue.
I will check the rest of the macros and make sure the library is still doing everything its supposed to later this afternoon.
https://github.com/NREL/SAM/pull/466 for the PR


getBounds() of FeatureGroup throw error when it has a LayerGroup as child

When a FeatureGroup has a LayerGroup as child and getBounds() is called, it throws the error "e.getLatLng is not a function"
Steps to reproduce
var fg = L.featureGroup();
console.log(fg.getBounds());
var lg = L.layerGroup().addTo(fg)
console.log(fg.getBounds()); // throws error

Current code
getBounds: function() {
    var bounds = new LatLngBounds();

    for (var id in this._layers) {
        var layer = this._layers[id];
        bounds.extend(layer.getBounds ? layer.getBounds() : layer.getLatLng());
    }
    return bounds;
}

Expected behavior
I think it should go through all layers of a LayerGroup. Like:
getBounds: function() {
    var bounds = new LatLngBounds();

    for (var id in this._layers) {
        var layer = this._layers[id];
        if (layer instanceof L.LayerGroup && !layer.getBounds) {
            for (var lgid in layer._layers) {
                var lglayer = layer._layers[lgid];
                bounds.extend(lglayer.getBounds ? lglayer.getBounds() : lglayer.getLatLng());
            }
        } else {
            bounds.extend(layer.getBounds ? layer.getBounds() : layer.getLatLng());
        }
    }
    return bounds;
}

But now is the problem what if the LayerGroup contains also a LayerGroup?
The Doc says "Returns the LatLngBounds of the Feature Group (created from bounds and coordinates of its children)" this means for me, that it returns the bounds of all childrens also for LayerGroups and LayerGroups with LayerGroups childrens.
The easiest way is to add the getBounds() function to the LayerGroup, but I think this is not what you want.

The approach is good, but I'm afraid it's going to fail on nested LayerGroups. Some kind of recursivity is gonna be needed.

Yes, this a problem for FeatureGroups too:
var fg = L.featureGroup();
var lg = L.featureGroup().addTo(fg);
fg.addTo(lg);
console.log(fg.getBounds());

Hi! I'm new to contributing to open-source projects, but I think I can help with this, if it's ok :)
I'll send the PR soon.


Add a note about how to control glow layer with NME

Issue moved to BabylonJS/Documentation #155 via ZenHub


Allow IterativeSolverMonitor to indicate early convergence

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#4483
@jandrej
@tzanio
@najlkin + @acfisher
10/15/24
⌛due 10/29/24
⌛due 11/5/24

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

@jandrej, can you resolve the conflicts before we start the review?

ping: @jandrej

pong @tzanio

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

@jandrej , I will have a closer look later 🧐 , but a general question - what is it good for? 😅 You want to have some way how to stop the solver not only based on the norm of the residual? It looks to me a bit hacky way to use IterativeSolverMonitor for it 🤔 . As the name says, it is a monitor, so it is supposed to track the progress (and print it, log it, or so), but I would not expect it to interfere with the process...

For me, a much cleaner solution would be to make some virtual method of IterativeSolver, let us say CheckConvergence(), which would do the classical check of the norm, but the user could override it in a derived class from the solver to include some custom stopping criterion 👍 .

I tend to agree. @victor-decaria-nnl what do you think about this route?

I prefer the composition approach as it's currently proposed vs a virtual convergence check. Then we just have to maintain one custom class instead of a custom class of every solver we want to use a specific check for.
@najlkin An example for wanting to override the stopping criteria is if you're solving a block system of pdes with a large scale separation between the different fields, and you want to make sure the fields individually satisfy a tolerance. Using a global l2 critieria as things currently work may only effectively check the convergence on the largest magnitude fields if the scales are very separated.

@jandrej I prefer the composition approach of using IterativeSolverMonitor as currently proposed vs a virtual convergence check. Then we just have to maintain one custom class instead of a custom class of every solver we want to use a specific check for.
@najlkin An example for wanting to override the stopping criteria is if you're solving a block system of pdes with a large scale separation between the different fields, and you want to make sure the fields individually satisfy a tolerance. Using a global l2 critieria as things currently work may only effectively check the convergence on the largest magnitude fields if the scales are very separated.

All very good points.

One more consideration: if the monitor is used to indicate convergence, then the same convergence criterion can be used across different solvers. You don't need to create separate derived classes for SLI, CG, GMRES, etc., just pass "CustomCon vergenceMonitor" to the standard classes.

@jandrej I prefer the composition approach of using IterativeSolverMonitor as currently proposed vs a virtual convergence check. Then we just have to maintain one custom class instead of a custom class of every solver we want to use a specific check for.

The code diff will be about the same in MFEM and the custom classes on the user side are as easy as maybe three lines of code, but it is much harder to maintain wrongly designed OOP (i.e., a class intended for something else having an extra effect). If you really want, there could be some different class for this purpose, but it looks to me as an overkill 🪓.

@najlkin An example for wanting to override the stopping criteria is if you're solving a block system of pdes with a large scale separation between the different fields, and you want to make sure the fields individually satisfy a tolerance. Using a global l2 critieria as things currently work may only effectively check the convergence on the largest magnitude fields if the scales are very separated.

This can be actually already handled by Norm(), using something like max(x.GetBlock(0).Norml2(), x.GetBlock(1).Norml2()) 🤔 . If you want to simplify this, we could think of some template wrapper for solvers, so something like BlockSolver<GMRESSolver> 👍 .

Ok folks, I tried the idea of a redefined IterativeSolver::Dot() (as Norm() itself is not virtual for consistency, see #4156 ). I made this wrapper for block systems 👇 . It works, but the convergence rate seems to be lower than with the normal solvers, at least what I quickly tested. Maybe try it by yourself, but it does not seem to be a good option. So that pathway with some method for checking only the stopping criterion, let us say CheckConvergence(), which would be similarly overridden, sounds more feasible 😉 .
template<class S> class BlockSolver : public S
{
   const Array<int> &offsets;

   real_t Dot(const Vector &x, const Vector &y) const override
   {
      real_t dot = 0.;
      const BlockVector bx(const_cast<Vector&>(x), offsets);
      const BlockVector by(const_cast<Vector&>(y), offsets);
      for(int i = 0; i < offsets.Size()-1; i++)
      {
         const real_t d = S::Dot(bx.GetBlock(i), by.GetBlock(i));
         //dot += d;
         if(fabs(d) > fabs(dot)) { dot = d; }
      }
      return dot;
   }
public:
   BlockSolver(const Array<int> &offsets) : offsets(offsets) { }
};

We decided to rename Monitor to Controller and make the former an alias to the latter.


Delete this role

I would like to propose deleting this role in favor of using Jeff Geerling's role:
https://github.com/geerlingguy/ansible-role-java
jhu-library-applications/ansible-role-java is currently referenced in jhu-library-applications/catalyst-ansible.
I do not know if it's referenced anywhere else.

Hi @little9 , I'm assigning this to you only because I know that (at least at one point) you were going through all the ansible in general -- and you might have some off-the-top insight into whether we can just delete this without incident. If in fact you have not been able to do that kind of review, feel free to kick this back to me. Obviously there's no hurry to delete this and I don't mind going through things eventually to see if it's referenced elsewhere (other than catalyst-ansible). Thanks!


Support environment variables for credentials

It would be good if the tools supported the standard environment variables to provide username, password, and tenant. This would help keep the commands short, would not compromise credentials in screensharing and would enable the usage of the session management feature of the c8ycli command line tool (https://goc8ycli.netlify.app/docs/gettingstarted/)

This is tracked internally via PAB-4502


Spike -- Scope Eng work needed to build custom authorization

Problem Statement
Presently ReportStream relies on Okta for authorization and authentication. We should investigate how much work it would be to build our own solution to authorization (data access permissioning) and only use Okta for authentication (logging in). Things to consider:

What would make it easiest to move off Okta if it becomes necessary in the future?
What happens if ReportStream and SimpleReport have different patterns for authorization?
If we move to a custom solution for authorization, what would the migration plan look like?

i'm going to close this, as moving off of okta hasn't come up since I started in May. If it comes up again we can make a new ticket


Create naturalspeech

Naturalspeech is a plugin that uses an advanced text-to-speech engine to generate sound with different voices.

Your plugin needs a warning as it automatically connects to external services with the default configuration.

@Nightfirecat warning message added, along with a bunch of other updates. Please let me know if the plugin needs any other amendments.

The warning message goes in the file you created in this pr.

@raiyni  Ohhh, my bad. I thought it was in the plugin info. Hopefully I've done it right this time.

You're registering several classes to the event bus (at a glance, TopLevelPanel, MenuEventHandler, and SpeechEventHandler) which don't seem to be unregistered on plugin shutdown. This means that turning your plugin off potentially does nothing, as those classes would continue to receive and respond to fired events. Please ensure they are unregistered on plugin shutdown.

You're registering several classes to the event bus (at a glance, TopLevelPanel, MenuEventHandler, and SpeechEventHandler) which don't seem to be unregistered on plugin shutdown. This means that turning your plugin off potentially does nothing, as those classes would continue to receive and respond to fired events. Please ensure they are unregistered on plugin shutdown.

I believe I resolved this with this commit: https://github.com/phyce/rl-natural-speech/commit/cba9dc9b77ec51dfad0c7d41f7c717ae8a9803ff

TopLevelPanel no longer registers tab panels.
EventBus::register/unregister calls are restricted to NaturalSpeechPlugin, managing handlers on startup() and shutdown() is clear and easy to spot.