Update Node Versions

Updated list of available Node versions with current list
Added Kudu environment variable as versioning option

Hi @felixrieseberg, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@felixrieseberg, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;


implement VSwitchProvider

What type of PR is this?
/kind feature

What this PR does / why we need it:
Implement VSwitchProvider. In AWS, it is SubnetProvider.
Which issue(s) this PR fixes:

Fixes https://github.com/cloudpilot-ai/karpenter-provider-alicloud/issues/12
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Solicitation for naming:

vSwitchSelectorTerms

spec:
  vSwitchSelectorTerms:
    - id: vsw-abc
    - tags:
        - k: v

vswitchSelectorTerms

spec:
  vswitchSelectorTerms:
    - id: vsw-abc
    - tags:
        - k: v

VSwitchSelectorTerms

spec:
  VSwitchSelectorTerms:
    - id: vsw-abc

@jwcesign @helen-frank

Once it's ready, please cc me

cc @jwcesign @helen-frank

I will take a look as soon as possible

Can u help squash all the commits into one?

/lgtm
/cc @jwcesign @IrisIris

cc @helen-frank also, Please take a look

I see a significant difference that needs to be confirmed.

/lgtm


Utility table

A utility will be an entity that we can make bill payments to.
The table will need:

bank account number (obviously)
particulars, code and reference descriptions (what does the utility expect in each field)
TODO....

We also need to think about how we translate what a utility needs in the payment fields to a form that we give to the user.. do we:

hand craft the logic for each utility?
create a little domain specific language?

specify text fields and integer fields
specify the instructions for each field to the user
specify if a field spans multiple fields on the bank side (greater then 12 chars)

here is a proposed json DSL to describe the utilities, we could just put the json data in a string column perhaps:
{
  "utilities": [
    {
      "name": "Powercorp #1",
      "description": "Electricity supplier in Auckland",
      "fields": [
        {
          "label": "Invoice Number",
          "description": "The invoice number on your bill statement",
          "type": "number",
          "min": 10000,
          "max": 99999,
          "allow_empty": false,
          "target": "particulars"
        },
        {
          "label": "User Name",
          "description": "The user name assocatiated with your account",
          "type": "string",
          "min_chars": 4,
          "allow_empty": false,
          "target": ["code", "reference"]
        },
  ],
}

What do you think about this?

hmmm... so everytime the zap_bill_payments is used it would have the record above? which basically means that each time the app is used by a user it will generate
{
  "utilities": [
    {
      "name": "Powercorp #1",
      "description": "Electricity supplier in Auckland",
      "fields": [
        {
          "label": "Invoice Number",
          "description": "The invoice number on your bill statement",
          "type": "number",
          "min": 10000,
          "max": 99999,
          "allow_empty": false,
          "target": "particulars"
        },
        {
          "label": "User Name",
          "description": "The user name assocatiated with your account",
          "type": "string",
          "min_chars": 4,
          "allow_empty": false,
          "target": ["code", "reference"]
        },
  ],
}

With a different user name?

no, the users will generate 'payments' which will be in a different table
this is the description of the utilities so we can automatically show the user a form that will format the data the way the utility expects in their bank account

If i understand this correct we need to look for the bank details of each utility so the app could be used to do bank transfers:
ie. trustpower
mercury
vodafone
spark
above are just some bank transfers.

Vodafone, is a bit more complicated. It appears that they have multiple account no. depending on the type of account? a user has.
4 different accounts so far:
A:

Bank account name | Vodafone A
-- | --
Account | 02-0248-0228009-024
Particulars | Your name
Code | Your Vodafone account number
Reference | Your phone number
SWIFT (if required) | BKNZNZ22

B:

Bank account name | Vodafone A
-- | --
Account | 02-0248-0228009-024
Particulars | Your name
Code | Your Vodafone account number
Reference | Your phone number
SWIFT (if required) | BKNZNZ22

C:

Bank account name | Vodafone C

Account | 02-0100-0074189-000
Particulars | Your name
Code | Your Vodafone account number
Reference | Your phone number
SWIFT (if required) | BKNZNZ22
D:

Bank account name: Vodafone D
Account | 02-0108-0261413-00
Particulars | Your name
Code | Your Vodafone account number
Reference | Your phone number
SWIFT (if required) | BKNZNZ22

So basically the user will get an invoice? that tells them where they would need to transfer the money to.

So basically I need to setup a table for the bank details. Created a Bank table earlier but this one shouldn't be attached to the user table like the other app. This one should be attached to the I cant see any reason why you would attached the users bank details since they are paying via zap.
Thinking of the following schema:
class Bank(db.Model):
    id = db.Column(db.Integer, primary_key=True)
    utility_id = db.Column(db.Integer, db.ForeignKey('utility.id'), nullable=False)
    utility = db.relationship('User', backref=db.backref('utilities', lazy='dynamic'))
    token = db.Column(db.String(255), unique=True, nullable=False)
    account_number = db.Column(db.String(255), nullable=False)
    account_name = db.Column(db.String(255), nullable=False)
    account_holder_address = db.Column(db.String(255), nullable=False)
    bank_name = db.Column(db.String(255), nullable=False)
    default_account = db.Column(db.Boolean, nullable=False)

    def __init__(self, token, account_number, account_name, account_holder_address, bank_name, default_account):
        self.account_number = account_number
        self.account_name = account_name
        self.account_holder_address = account_holder_address
        self.bank_name = bank_name
        self.default_account = default_account
        self.generate_defaults()

    def generate_defaults(self):
        self.token = generate_key(4)

Above for the bank table, originally from the other app but changed two thing(user_id and users). The reason was that I'm trying to remove the relationship to the user table.
Will need to keep changing this...

No we dont need a bank table, but we do need a bank_account field in the utilties table

pulled the repo since its updated.


Issue Firefox+ GitHub Login

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
:shrug: I don't really know, I need help to provide more info.

I have setup Rancher with GitHub.com authentication
One day, when login with FireFox I get : Permission denied to access property "ls" on cross-origin object

However:

When using Chromium or Firefox in private mode it works
I have checked the extension I am using in Firefox none of them are "blockers"
I have deactivated Firefox built-in protection with no success

Result:

Other details that may be helpful:
Environment information

Rancher
v2.3.6

User Interface
v2.3.40

Helm
v2.14.3-rancher1

Machine
v0.15.0-rancher34

Firefox: 76.0.1

I'm having an issue with Chrome today for Github authentication. It worked yesterday morning. Version 83.0.4103.61 (Official Build) (64-bit)
I reported it to Github too, just in case. I don't know if these issues are related but figured to comment just in case they are.

By the way, it is working again today .... :shrimp:

yes, it works in firefox, I just checked. It does not work in chrome. Odd. Hopefully, there's a fix as I like Chrome better. :)

Figured it out and not too happy about it. I have to disable anti-tracking in order for this to work in chrome. :( Why are you requiring tracking to be enabled Rancher?

"We" are not doing anything to "track" you.
Rancher redirects to GitHub with the application id you've configured.  You sign in on their site and they reflect back to the URL we tell them plus a code.  That along with the application secret configured can then be exchanged on the server-side for an API key.  This is the standard OAuth web flow.
The error page you're showing is on their site.  So whatever you have enabled is breaking GitHub, and likely has nothing to do with Rancher.

Ok thanks for the explanation. I've used this for years without issues and have a ticket in to Github for our organization. Have a good day.


[zh] Localize /docs/concepts/services-networking/cluster-ip-allocation.md

I have modified the previously submitted pull  request and resubmitted changes.

@wuyanpinguniontech ping!

Hey @wuyanpinguniontech,
It's been a while since the last update, would you like to address issues in the previous comments so that we can move forward?

Hey @wuyanpinguniontech,
It's been a while since the last update, would you like to address issues in the previous comments so that we can move forward?

Ok, I will solve the previous problem immediately

Hi @wuyanpinguniontech , could you squash your commits into one?

Hi @wuyanpinguniontech , could you squash your commits into one?

I will merge commit into one afternoon.

This is new PR #39558

Hi @wuyanpinguniontech , you can refer to how to squash commits.
One tips to you:

如果 PR 已经有 review comments，请不要轻易 close PR，努力在一个 PR 中解决所有问题。
Reviewer 花费了自己的时间来 review 你的 PR，而你却在逃向他方，这样不好，真的。

Looks like the author doesn't know how to rebase, squash commits ... sigh.
I was reviewing another PR.

Hi @wuyanpinguniontech , you can refer to how to squash commits.
Some tips to you:

如果 PR 已经有 review comments，请不要轻易 close PR，努力在一个 PR 中解决所有问题。
Reviewer 花费了自己的时间来 review 你的 PR，而你却在逃向他方，这样不好，真的。因为这个 PR 已经是协作的成果。
我们感谢每位贡献者的 PR，也请尊重每位 reviewer 付出的时间和精力，谢谢哇 pray

I'm very sorry, due to my mistake, the warehouse was synchronized, resulting in too long a gap between the earliest commit and the current commit. I didn't find a solution to this problem, so I created a new PR.

Looks like the author doesn't know how to rebase, squash commits ... sigh. I was reviewing another PR.

Thank you for your understanding


[Feature Request] Being able to select the location of ./0L directory

Currently, in Windows the ./0L directory is automatically built in C:/Users/admin(user)/ . While this may work well for Mac users as they usually have a single drive but a lot of Windows systems have a combination of partitions especially also because of the hybrid SSD (OS) and HDD (user data) architecture, there could be data management issues going further. Giving a choice of location while installation would be a nice to have feature!

Deprecated. v1.0.0 uses platform's app folders


Optimize debug log enable check

opendistro-for-elasticsearch/security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Refactoring

Github Issue # or roaddmap entry, if available:
N/A

Description of changes:

log.isDebugEnabled() and log.isTraceEnabled() is called multiple times in the same request path or method.
Each of the log function internally checks if it is enabled or not but enabling debug/trace logs is generally a transient change for debugging.
Removed some debug logs which are in addition to log.warn as warn messages will always be shown in addition to debug messages
Fixed string formatting of log messages

Why these changes are required?

Pass down enabled values down the request path to avoid internal re-computation and thereby improve performance.

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screenshot if avaialble)

No changes in behavior.

Testing done: (Please provide details of testing done: Unit testing, integration testing and manaual testing)
No functional changes. Existing automated tests are sufficient

TO-DOs, if any: (_Please describe pending items and provide github issues# for each of them)
N/A

Is it backport from master branch? (If yes, please add backport PR # and commits #)
No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We are still checking log.isDebugEnabled once per class.
Looking for more idea: Is it possible to move it at request level? (once per http or transport request)

We are still checking log.isDebugEnabled once per class.
Looking for more idea: Is it possible to move it at request level? (once per http or transport request)

Main request path is reusing the single computed value as much as possible.

OpenDistroSecurityFilter.java

PrivilegesEvaluator.java

dlsFlsEvaluator
securityIndexAccessEvaluator
protectedIndexAccessEvaluator
PrivilegesInterceptor
checkFilteredAliases
evaluateAdditionalIndexPermissions

OpenDistroSecurityRequestHandler.java

BackendRegistry.java

authenticate
authenticate

It looks like the debug flag is now passed using stack. While that is not bad, if the purpose was to trace the actions done for the User's request, then the request can have a flag to mark if it is to be debug logged. Therefor having 'debug' a property of Request might be an option. It will still allow new request objects to pickup a debug value if the level configuration changed and was picked up dynamically.

It looks like the debug flag is now passed using stack. While that is not bad, if the purpose was to trace the actions done for the User's request, then the request can have a flag to mark if it is to be debug logged. Therefor having 'debug' a property of Request might be an option. It will still allow new request objects to pickup a debug value if the level configuration changed and was picked up dynamically.

Is there some way you would suggest? Looked into following but I fear it would be worse than what we have

Updating thread context. For each request thread, update thread context with debug/trace enabled values and pass it around.
Creating a wrapper around request with (request + debug/trace properties) but involves a lot of wrapping and unwrapping.

It looks like the debug flag is now passed using stack. While that is not bad, if the purpose was to trace the actions done for the User's request, then the request can have a flag to mark if it is to be debug logged. Therefor having 'debug' a property of Request might be an option. It will still allow new request objects to pickup a debug value if the level configuration changed and was picked up dynamically.

Is there some way you would suggest? Looked into following but I fear it would be worse than what we have

Updating thread context. For each request thread, update thread context with debug/trace enabled values and pass it around.
Creating a wrapper around request with (request + debug/trace properties) but involves a lot of wrapping and unwrapping.

@sujithvm I don't think @vikansal proposes to introduce log level scoped to a user request or specific user. That will require a separate PR. His question is related to passing debug flag on the stack. As long as it is limited to private methods, the scope is still at class level, not request/user level.

@sujithvm I don't think @vikansal proposes to introduce log level scoped to a user request or specific user. That will require a separate PR. His question is related to passing debug flag on the stack. As long as it is limited to private methods, the scope is still at class level, not request/user level.

If I understood correctly, proposal was to add an attribute to each request whether it is debuggable and may require a change in upstream Elasticsearch to an attribute

This is only necessary if the original intention of the PR was to introduce request level logging. If the intention is to optimize debug level check in the scope of a class or a method, it is not necessary. The former actually requires a separate PR.
I would recommend to avoid passing debug level flag between methods. Even though it is fine for private methods, it introduces more confusion compared to performance benefits it will provide.

Please see https://logging.apache.org/log4j/log4j-2.2/performance.html. It suggests that the cost of calling isDebugEnabled() is negligible unless it is an extremely hot code.

This is only necessary if the original intention of the PR was to introduce request level logging

Intention is only to optimize debug level check being evaluated multiple times in the same path flow.

It suggests that the cost of calling isDebugEnabled() is negligible unless it is an extremely hot code.

This mainly optimizes the request path flow which can be considered hot code and the same debug/trace evaluation is done ~20-30 times


setting up configs on one of two mounts of same remote

Hi there,
i would like to know if it is possible to apply configs for a single mount of two through rclone browser.
iam trying to setup this https://komga.org/guides/gdrive.html, but because i have two mounts from same gdrive, when i press file preferences i see general mount options, how can i leave the mount options for one mount and add the mount options from the link provided through rclone browser.
is that even possible? or is this behaviour a feature suggestion. Iam sort of noob. :)

I see that no one has commented on this, so I thought I would try to help. Your post is dated, so this may not still be an issue for you.
I'm not sure I understand what you mean by a single mount of two? You can have multiple remotes mounted at the same time, but afaik the process is you mount them one at time.
Also afaik, RB doesn't have a mechanism for inputing separate mount options for each remote all at one time. You would have to enter the mount options you wanted to use for say Remote #1 under Preferences(Settings)>Mount Options and then mount that remote. Then you could go back to Mount Options, enter different options say for Remote #2, and then mount it using those options.
Again, this is my understanding of how you would do what I think you're asking about. Maybe @kapitainsky will correct me if I've given you erroneous advice.
Note that rclone has been updated such that having a voluminous number of mount options is no longer necessary. It's generally better to start with the fewest options possible, and add additional ones as needed. If I were you, for the Komga thing you linked, I'd start with using --vfs-cache-mode full as the only option and see if that accomplishes what you need.


confusing about how to use it Programmatically

I guess I need a more clear explanation.
I'd like do it programmatically and I want it output file and directory just like ncc build. what should I do ?

The CLI itself is just a thin wrapper around ncc. See how it is used for example in https://github.com/zeit/ncc/blob/master/src/cli.js#L213.

This might help: https://github.com/styfle/ncc-bug-stack/blob/master/build.js#L7

Thanks.


Dependabot not updating package.json

Package manager/ecosystem
npm, Javascript

Manifest contents prior to update
Link https://github.com/Lucaslah/InkStatus/pull/40/files

Updated dependency
systeminformation

What you expected to see, versus what you actually saw

It updated systeminformation in the package-lock.json but not in the package.json, I wanted it to update it in my package.json as well.
Images of the diff or a link to the PR, issue or logs

Link to pull request that dependabot opened: https://github.com/Lucaslah/InkStatus/pull/40
Link to package-lock.json https://github.com/Lucaslah/InkStatus/blob/master/package-lock.json
Link to package.json: https://github.com/Lucaslah/InkStatus/blob/master/package.json

You can set the versioning-strategy to increase as per these docs: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates#versioning-strategy

Ok, I’ll try that out.

It now has been one day since I changed the dependabot.yml file, still no open pull requests to bump systeminformation up to date.
Any ideas?

It now has been one day since I changed the dependabot.yml file, still no open pull requests to bump systeminformation up to date.
Any ideas?

That dependency is already on the latest version (https://www.npmjs.com/package/systeminformation/v/4.27.7) so it cannot/does not need to be updated.

https://github.com/Lucaslah/InkStatus/blob/cb169bc36d38b1cbc1afa2cd79d5efa06bfd6f0c/package.json#L30 shows that in package.json, systeminformation is at 4.27.3 not 4.27.7.
In package-lock.json dependabot updated systeminformation to 4.27.7, but not in my package.json.

The ^4.27.3 means use any version greater than 4.27.3 but smaller than 5.0, the package.lock is what holds the actual version that's being used.

The ^4.27.3 means use any version greater than 4.27.3 but smaller than 5.0, the package.lock is what holds the actual version that's being used.

Ok, Thanks
I did not know that.


Large output shows no scrollbar and feel broken

Open notebook that generates a large output
Run that notebook

Notice that the output can not be scrolled and the output just gets overwritten 🐛
Repro open this folder, run all cells Dinosaurus_Island_Character_level_language_model file, notice output of cell is large and broken.
parameters, last_name = model(data.split("\n"), ix_to_char, char_to_ix, 22001, verbose = True)

assert last_name == 'Trodonosaurus\n', "Wrong expected output"
print("\033[92mAll tests passed!")

Assignment_2 (1).zip
fyi @minsa110 @nneva

We have been discussing this for long time. The challenge here is how do we ensure a reasonable experience when we have nested scrollable element.

See https://github.com/microsoft/vscode-jupyter/discussions/9863 for the latest version of this complaint


Please check and tell me needed changes

Description

Replacing Null values
Remove unwanted features and rows
Change categorical data types to categorical

Checklist

[x]  I am making a proper pull request, not spam.

[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
Preprocess the dataset : Handling NULL values & Duplicate features #1
Add relevant screenshot or video (if any)

df = df.astype('category')
df.dtypes

Hey @nilupulmanodya , can you explain what have you done here?

As the issue only asks the contributor to handle the null values and the duplicates feature/rows, the updates in the PR should be strictly on those only.

hey @sagnik1511 ,
I thought that's easy for data clustering. I can reverse it. How about you feel other things ? can you satisfy or need any changes ?

As the numeric feature can hold a euclidian distance feature, thus needed in numeric values.

Sure, I will change it

Looks like you're new to GitHub. No need to close the PR. If you update the branch, it will directly reflect in the PR.

Thank you so much. I will try in next time.


Clicking the new search icon or clicking home icon, the curson should be placed in the text entry field ready for user input

Is your feature request related to a problem? Please describe.
Personal preferance really but when the user initiates a new search request the app should be ready to accept input. I guess I'm lazy.  The extra click to activate user input seems unnecessary.
Describe the solution you'd like
When a new search is requested, the 'Ask anything' text input field should be active aka ready to accept input.
Describe alternatives you've considered
I could continue to click in the field to enable the input i have already requested.
Additional context
This project is everything I thought it could be. Thank you.

I am not a TypeScript developer (or any kind of developer) but I spent 5 minutes with Claude and we came up with this solution: Changes to EmptyChatMessageInput.tsx only. This update does exactly what I was looking for and so far I have seen no side effects. YMMV
Also, I think most of the comments have to do with my environment and can be ignored.
`// TODO: Address TypeScript configuration issues at the project level to properly recognize React and JSX types.
// @ts-ignore
import { ArrowRight } from 'lucide-react';
// @ts-ignore
import React, { useEffect, useRef, useState, FormEvent, KeyboardEvent, ChangeEvent } from 'react';
// @ts-ignore
import TextareaAutosize from 'react-textarea-autosize';
// @ts-ignore
import CopilotToggle from './MessageInputActions/Copilot';
// @ts-ignore
import Focus from './MessageInputActions/Focus';
interface EmptyChatMessageInputProps {
sendMessage: (message: string) => void;
focusMode: string;
setFocusMode: (mode: string) => void;
}
const EmptyChatMessageInput: React.FC = ({
sendMessage,
focusMode,
setFocusMode,
}: EmptyChatMessageInputProps) => {
const [copilotEnabled, setCopilotEnabled] = useState(false);
const [message, setMessage] = useState('');
const inputRef = useRef<HTMLTextAreaElement | null>(null);
useEffect(() => {
const handleKeyDown = (e: KeyboardEvent) => {
const activeElement = document.activeElement;
  const isInputFocused =
    activeElement?.tagName === 'INPUT' ||
    activeElement?.tagName === 'TEXTAREA' ||
    activeElement?.hasAttribute('contenteditable');

  if (e.key === '/' && !isInputFocused) {
    e.preventDefault();
    inputRef.current?.focus();
  }
};

document.addEventListener('keydown', handleKeyDown as unknown as EventListener);

return () => {
  document.removeEventListener('keydown', handleKeyDown as unknown as EventListener);
};

}, []);
useEffect(() => {
inputRef.current?.focus();
}, []);
const handleSubmit = (e: FormEvent) => {
e.preventDefault();
sendMessage(message);
setMessage('');
};
const handleKeyDown = (e: KeyboardEvent) => {
if (e.key === 'Enter' && !e.shiftKey) {
e.preventDefault();
sendMessage(message);
setMessage('');
}
};
return (
// @ts-ignore

{/* @ts-ignore /}

{/ @ts-ignore /}
<TextareaAutosize
ref={inputRef}
value={message}
onChange={(e: ChangeEvent) => setMessage(e.target.value)}
minRows={2}
className="bg-transparent placeholder:text-black/50 dark:placeholder:text-white/50 text-sm text-black dark:text-white resize-none focus:outline-none w-full max-h-24 lg:max-h-36 xl:max-h-48"
placeholder="Ask anything..."
/>
{/ @ts-ignore /}

{/ @ts-ignore /}

{/ @ts-ignore /}

{/  /}

{/ @ts-ignore /}

{/ @ts-ignore /}

{/ @ts-ignore /}
<button
type="submit"
disabled={message.trim().length === 0}
className="bg-[#24A0ED] text-white disabled:text-black/50 dark:disabled:text-white/50 disabled:bg-[#e0e0dc] dark:disabled:bg-[#ececec21] hover:bg-opacity-85 transition duration-100 rounded-full p-2"
>
{/ @ts-ignore */}

);
};
export default EmptyChatMessageInput;
`

I hope this is helpful.


chore: fix app-layout menu rendering in whole suite demo

Closes #271
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/wc-catalogue/blaze-elements/blob/master/docs/CONTRIBUTING.md#commit
[x] There are no linting errors and code is properly formatted (your run before push yarn ts:format && yarn ts:lint:fix)
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#271
What is the new behavior?
app layout menu works within whole suite
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

No, drawer has position:relative .... false alarm ... 👍


Correct sys.all_views column types and is_ms_shipped column behaviour

Signed-off-by: Avneet Toor<EMAIL_ADDRESS>Description
sys.all_views was previously implemented and merged in. However, after manual testing, it was found the is_ms_shipped column wasn't being set correctly. This creates a fix.
This CR also modifies the sys.all_objects view to now assign the correct value to the is_ms_shipped column for each object. Before, is_ms_shipped was hardcoded to 0. The sys.all_objects view will act as the source of truth for all other views that need to set a is_ms_shipped column.
Another view was added, sys.shipped_objects_not_in_sys, which keeps track of system objects that are not under the sys schema. This is used by sys.all_objects to correctly assign a value to the is_ms_shipped column.
Issues Resolved
BABELFISH-350
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hsuamz test

Code LGTM. Please don't forget to add the following to the end of commit message when doing final merge.
Task: BABELFISH-350
Signed-off-by: Avneet Toor<EMAIL_ADDRESS>


Update Azure Migrate Discover for AWS tutorial from 80 GB to 600 GB

The Azure Migrate Discover tutorial for AWS suggests a minimum of 80 GB but the Microsoft Site Recovery Agent during the installation on the Migration Agent EC 2 instance suggests a minimum of 600 GB for optimal performance so I have added this information so that someone following the tutorial will know in advance.

@Vikram1988 - Can you review this old PR and determine whether it needs to be closed or merged?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

@MaggiePucciEvans - Can you review this old PR and determine whether it needs to be closed or merged?

Hi @karl-henrik ,
According to the SME, the Azure Migrate appliance doesn’t need 600 GB for discovery. The replication appliance needs 600 GB which is already called out in the support matrix.
Hence, closing the issue.
#please-close


attribute((weak))  not work  (IDFGH-8873)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
tag  : v4.4.2
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
What is the expected behavior?
expected print  log : attribute  work !
What is the actual behavior?
the actual log :ops , attribute  not work !
Steps to reproduce.
file1.c
#include "file2.h"
attribute((weak)) int app_init(void)
{
printf("ops , attribute  not work !\n");
return 0;
}
// main entry
void main(void){
app_init();
}
file2.c
int app_init(void)
{
printf(" attribute  work !\n");
return 0;
}
expected print  log : attribute  work !
Build or installation Logs.
No response
More Information.
No response

This isnt really a bug, just how the linker works, .e.g see https://stackoverflow.com/questions/13089166/how-to-make-gcc-link-strong-symbol-in-static-library-to-overwrite-weak-symbol
IDF provides a convenient way of setting -whole-archive with WHOLE_ARCHIVE, see https://github.com/espressif/esp-idf/tree/master/examples/build_system/cmake/plugins#ensuring-that-the-plugin-code-is-included-into-the-executable for some more explanation.

This isnt really a bug as far as I can see, just how the linker works, .e.g see https://stackoverflow.com/questions/13089166/how-to-make-gcc-link-strong-symbol-in-static-library-to-overwrite-weak-symbol
IDF provides a convenient way of setting -whole-archive with WHOLE_ARCHIVE, see https://github.com/espressif/esp-idf/tree/master/examples/build_system/cmake/plugins#ensuring-that-the-plugin-code-is-included-into-the-executable for some more explanation.

@ESP-Marius @sidhoo22 Just a note - WHOLE_ARCHIVE is not available in v4.4.2 although it is fairly trivial to cherry pick (https://github.com/espressif/esp-idf/commit/273633ee310fbc18b17edfaeae3f3121508e3b8d).
I had to this for my issue: https://github.com/espressif/esp-idf/issues/10103

Hi @sidhoo22 ,
As v4.4.x doesn't have WHOLE_ARCHIVE, you can check this https://github.com/espressif/esp-idf/issues/9718#issuecomment-1311560206
It will force the linker to integrate your file containing the strong function in the binary.

@ljden @o-marshmallow oh i see. i'll test it later, thanks for your help

Marking this as resolved then since the original question was answered and there doesnt seem to be any bugs related to IDF.


Added support for combined samplers when generating VKSL

Vulkan supports both combined samplers (same as GLSL) and separate texture & sampler objects. XShaderCompiler defaults to separate samplers when generating VKSL.
I've added a flag that allows the user to disable this functionality in order to support combined samplers on VKSL. The flag is --separate-samplers and by default it is on, meaning there is no change to VKSL code by default, unless user explicitly turns this behavior off.

Please add new compiler options also to the wrappers, so they are available in all supported languages.
The fields can be added here for the C wrapper and here for the C# wrapper.
In both cases you have to do a little bit more than just adding the fields to do the actual wrapping.
Take a look at my last commit 1bf62ff to see how I do it.
Thanks and greetings,
Lukas


Site not found 404

I am trying to access the material on https://yamakira.github.io/art-of-packet-crafting-with-scapy/network_recon/service_discovery/index.html
but i get the 404 error, is there any feedback you can provide with the issue?

That is because I have changed my twitter handle. You can access the notes at - https://0xbharath.github.io/art-of-packet-crafting-with-scapy/network_recon/service_discovery/index.html


2FA not working on Safari on Mac

The login window opens in Safari, and for some reason, the 2FA is not working. Time is in sync.
Can we switch to chrome based authentication/login page?

It uses chrome for me on my mac. Perhaps chrome is not your default browser?

Sadly I am not able to use this app. the 2FA login never works.

Hello @rachitmishra! It would be very strange to open the page in safari. Gitify is built with electron which comes with Chrome bundled. When you click the login buton, it should open another chrome window. From the code, I don't see how it would open another browser. Can you send me some screenshots or a gif with happens when you click login? I will be happy to help you figure this out!

@manosim indeed it is now opening in chrome but for some reason, neither the security codes nor the recovery code is working. anyways I am going ahead and closing the issue.


Rename partial matches to potential matches

, which describes the class purpose better.

Merging. Thanks for the review @mackdk !


Log specific deps and IDs when there's a mismatch

It's painful to debug these when users run into them because we don't know what's changing, only the numbers. We can probably give a more specific warning, but quick fix for now.
Now prints:

@prbot approve


Integrate bitcoin payments

I'm starting this issue to hopefully scope what would be required to integrate bitcoin payments into the checkout flow. We haven't decided to prioritise this, but it would be helpful to understand if it's an easy thing or a hard thing.
OpenNode has an API and documentation for developers. I reached out to them to try to understand how integration could work, and here's what they said.

User selects project that wants to contribute to
Select Bitcoin as an option, decide the amount to donate
Create a charge via OpenNode’s API where the order_id field is associated to that specific entity on OpenCollective (or map the charge id to a entity) and redirect user to OpenNode self-hosted checkout page (https://checkout.opennode.com/charge-id-here
User pays
Open Collective gets notification via webhook that the charge was paid and OpenCollective is able to map that specific payment to that entity. Credit the entity.

@kewitz I'm in touch with the co-founder CTO and I think he's Brazilian - maybe you two could have a chat about it?
If it's hard, I'm not convinced we should do it, but if it's pretty easy it could be worth it. We've processed >$50k in BTC contributions already, even though most people don't even know it's an option because we don't have a good way to surface it.

@alanna I don't think it is complex to implement this, especially because donations are instantly converted to USD.
This has just been falling out of priority but it still in my personal backlog, I think 50K is enough to justify raising its priority.
Also, accepting crypto would also create a buzz around Open Collective and OSC.

@kewitz I think it's a strong enough argument to at least scope this out. I'll connect you with the OpenNode contact in case you want to have a call with him. He seems eager to help out.

After talking with @piamancini - we can't prioritise this now and we want to take the time to properly look into options before going ahead.

Hi. I strongly suggest you implement bitcoin payments via Lightning Network instead of onchain payments. With Lightning Network you avoid onchain fees and settlement is instant, neither side has to wait for onchain confirmation(s). For small donations like $5, onchain payments are uneconomical and bloat the blockchain unnecessarily. As Ligthning Network adoption grows, it is becoming standard for bitcoin payments.
One solution how to integrate this is use BTCPayServer - opensource payment processor for both onchain and lightning bitcoin payments
https://github.com/btcpayserver/btcpayserver

closing as we have an approach and an issue to pick up on in #5075


VSCode TextEditor API

Is it possible to create an editor in the browser that follows the same API as VSCode's TextEditor (https://code.visualstudio.com/api/references/vscode-api#TextEditor) instead of Monaco's IEditor (https://microsoft.github.io/monaco-editor/typedoc/interfaces/editor.IEditor.html)?
Background info: I would like to reuse code from an existing VSCode extension.

I would that that it's the whole point of this library ;)

Sounds great! However, the examples in the readme create editors via monaco.editor.create, which returns anIStandaloneCodeEditor. How can I create a TextEditor instead and add it to the DOM?

That wouldn't be simple to explain how it works in a few line... The extension TextEditor api is used to control the VSCode editor from an extension host which can even run on another machine. You don't create TextEditor and add it to the dom, a TextEditor is an abstract entity
You configure the VSCode services to have the feature you need, then you'll be able to use its extension api to control the editors

Thanks, I think that comment helped me already!


Retrieving error messages from a response is SAP specific

The following methods are relying on the response format received only from SAP services:
https://github.com/SAP/odfuzz/blob/184660b47b2e17838b39922cc17e40aa2304a985/odfuzz/fuzzer.py#L250-L279
This has to be changed. We can either introduce a separate option for checking SAP specific services or delete the methods and their usages.

The issue may be related to https://github.com/SAP/odfuzz/issues/23#issuecomment-524754930.


Support for "up.conversations.im"

Hi there, amazing project you have created here. I have tested it with ntfy.sh and the results are awesome! :heart_eyes:
I see that you support a large number of push providers, whould it be difficult to support another UnifiedPush provider, namely "up.conversations.im"?
This is an implementation that is compatible with XMPP clients (Conversations and any of its forks).
The significane here is that if I want to use an XMPP client with unified push and also use email with unifiedpush (using your script), I would need to have both conversations and ntfy.sh installed and maintaining connections to 2 separate unifiedpush servers, which would be suboptimal to say the least and defeat the purpose of unifiedpush which is to have everything going through a single connection.
This is the link to the repo:
https://codeberg.org/iNPUTmice/up
The documentation looks excellent to me and after reviewing your code, it seems to me that you have designed this application in such a way that it would be very easy to add this functionality.
Do you think that adding this is possible?

Hi, thanks.
I'll have a look at it as soon as I'll have some spare time. Keeping this open as reference.


Update scalafmt-core to 3.0.8

Updates org.scalameta:scalafmt-core from 3.0.7 to 3.0.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch

Codecov Report

Merging #292 (8bbccf6) into main (0039bb2) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   95.98%   96.18%   +0.20%
==========================================
  Files           8        8
  Lines         997      997
  Branches       88       88
==========================================
+ Hits          957      959       +2
+ Misses         40       38       -2

Impacted Files
Coverage Δ

core/shared/src/main/scala/cats/parse/Parser.scala
96.06% <ø> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0039bb2...8bbccf6. Read the comment docs.


migrate to graph-gophers/graphql-go

migrate to graph-gophers/graphql-go
Hi @vektah , great job on making the code generator.
I wonder if you have plan to migrate you code to the new repo graph-gophers/graphql-go?
neelance/graphql-go (@neelance ) has been transferred to graph-gophers/graphql-go and @tonyghita  is actively working on and maintaining it.

gqlgen started as a fork of neelance/graphql-go, all of the code shared lives in neelance in the root directory.
I hope https://github.com/graph-gophers/graphql-go/issues/116 gets fixed I can delete the neelance directory and start pushing fixes upstream.
Until then, I'll need to cherry pick any fixes over.


python3Packages.zcs: patch to fix the test

Motivation for this change
#153896 introduced a build failure in a new package (zcs) because of a requirement in pyyaml reported by @c0bw3b on that PR. This PR fixes that build failure.
Things done
Applied a patch to the zcs test file passing the required loader

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build python39Packages.zcs python39Packages.bpycv

@ofborg build python310Packages.zcs python310Packages.bpycv

Thank you @lucasew 👍


Outline of Forms demo for a11y testing

A demo page is needed that provides different examples of form elements, which can be tested for accessibility issues.
As part of this issue:

create an outline of form elements and combinations of form elements that should be included on a test page
identify if there are any specific open questions or things to note when testing these elements

I'm going to go ahead and mark this one as closed.
Here is the outline we created.
@matthewcarleton and I discussed doing a review of the forms demo implemented as part of #200 before moving forward with #680 (i.e. implementing demos using form elements not covered in #200).


Updated KRR readme

Re-organised  content
Fixed broken links
Improved navigation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Avi-Robusta:x: pavangudiwadaYou have signed the CLA already but the status is still pending? Let us recheck it.


codespell issues

Hi @roaldnefs,
Similar to #123, I tried codespell, and I found some spelling issues. This check can also be integrated into the CI too.
$ codespell -S './.git*'
./README.md:183: arround  ==> around
./README.md:189: arround  ==> around
./tests/unit/TestConfig.py:39: wass  ==> was
./saltlint/config.py:108: configration  ==> configuration
./saltlint/cli.py:85: configration  ==> configuration

Fixed in master branch.


feat(volume): azure, gce and aws volumes

Resolves https://github.com/cdk8s-team/cdk8s-plus/issues/351
Resolves https://github.com/cdk8s-team/cdk8s-plus/issues/349
Resolves https://github.com/cdk8s-team/cdk8s-plus/issues/350

The backport to k8s-21/main failed:
The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-k8s-21/main k8s-21/main
# Navigate to the new working tree
cd .worktrees/backport-k8s-21/main
# Create a new branch
git switch --create backport-499-to-k8s-21/main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 31dc38956f47772cf13dbc36f4c0fe1eaab0176f
# Push it to GitHub
git push --set-upstream origin backport-499-to-k8s-21/main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-k8s-21/main

Then, create a pull request where the base branch is k8s-21/main and the compare/head branch is backport-499-to-k8s-21/main.

The backport to k8s-20/main failed:
The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-k8s-20/main k8s-20/main
# Navigate to the new working tree
cd .worktrees/backport-k8s-20/main
# Create a new branch
git switch --create backport-499-to-k8s-20/main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 31dc38956f47772cf13dbc36f4c0fe1eaab0176f
# Push it to GitHub
git push --set-upstream origin backport-499-to-k8s-20/main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-k8s-20/main

Then, create a pull request where the base branch is k8s-20/main and the compare/head branch is backport-499-to-k8s-20/main.

💚 All backports created successfully

Status
Branch
Result

✅
k8s-21/main

Questions ?
Please refer to the Backport tool documentation


Should accept arguments what string or character to be count

String = > Hello, World
Arguments => l (L)
return 3; since String contains 3 l's (L)'s

Hello vindecodex,
what should the code return in the following condition?
String => AAAaaaaaa
Arguments => aa

Hello vindecodex,
what should the code return in the following condition?
String => AAAaaaaaa
Arguments => aa

It should return 5
AAA|aa|aaaa - 1
AAAa|aa|aaa - 2
AAAaa|aa|aa - 3
AAAaaa|aa|a - 4
AAAaaaa|aa| - 5
That's the idea maybe soon will add options with no repeat and for the example arguments it should return 3
AAA|aa|aaaa - 1
AAAaa|aa|aa - 2
AAAaaaa|aa| - 3
For now it should return 5 will add another issue for the options.


Fixes ServiceBusManagementError being thrown

Description

getSubscriptionExists() using the sync client throws a. ServiceBusManagementErrors. Fixes that.
Aligns exception mapping logic between sync and async AdministrationClient.
Adds more tests.

Fixes #33609
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Incompatible with bitcoind 0.14.2?  Unparsed address & value errors

Fresh install of bitcoind 0.14.2, and bitcored installed via npm (shows bitcore 4.1.1 which under it shows bitcore-lib 0.14.0, bitcore-node 3.1.3 which under it shows bitcore-lib 0.13.19, insight-api 0.4.3 which under it shows bitcore-lib 0.13.19.
Ran system-installed bitcoind with the bitcoind.conf provided by bitcored.  (So, includes txindex,addressindex,timestmapindex,spentindex=1.)
Then modified bitcore-node.json with datadir /var/lib/bitcoind and exec /usr/bin/bitcoind.
bitcored starts, and can load its website.  It constantly updates under "Latest Transactions", and shows a checkmark, "Conn 2 Height 481566".  But clicking on one of the transactions it's showing isn't right.  A lot of the addresses are instead shown as "Unparsed address [n]" and a lot of bitcoin values are shown as "value error (U)".
Couldn't run bitcored with its included bitcoind because it constantly locks up while downloading the initial blockchain, so went off trying to do it this way.

Should 5.0.0-beta.1 be better?  I made a new user, installed node v8.2.0, and ran npm install -g<EMAIL_ADDRESS> I successfully have it re-downloading the blockchain.

@jamespharvey20 Any clue on the fix? Same issue.

Have same issue..how do I fix it?

same here


Creation of a general experiment data structure

A class (or classes) should be created to hold:

dataframe of parameters

Experiment number / notebook reference (for information on solvent, concentrations, etc.)
CV vertices, scan rate
Sampling rate
Measurement resistance and capacitance

dataframe of raw data with any values that can be automatically computed

E.g. Measured potential, current, phase angle, Zim, Zre.

One acquisition approach could be to write functions that run the experiment and return these objects.
Crucially, the implementation can only be allowed to append data, not overwrite existing objects.

Added a placeholder class experiment to data_structures.py, but didn't program it yet.

Wrote the class


Typo fix

[Enter feedback here]
Azure Red Hat Openshift admin is called kubeadmin, not kuberadmin.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ac404c4d-8b08-7f67-ad94-b7f0d679ef5b
Version Independent ID: 2584433e-dd54-0391-bcfa-6a5bccf0300c
Content: Upgrade an Azure Red Hat OpenShift cluster - Azure Red Hat OpenShift
Content Source: articles/openshift/howto-upgrade.md
Service: azure-redhat-openshift
GitHub Login: @johnmarco
Microsoft Alias: johnmarc

@sandole
Thanks for your feedback! We will investigate and update as appropriate.


Incorrect error/command example when trying to activate BE?

I tried to activate a BE with zedenv and I got this error:
[root@archlinux ~]# zedenv activate first
To use the grub plugin, use the default setting 'boot', or set a different value
. To set it use the command (replacing with your pool and dataset)
'zfs set org.zedenv.grub:boot='<new mount>' zpool/ROOT/default

Shouldn't the command to run be more like:
zedenv set org.zedenv.grub:boot='<new mount>' zpool/ROOT/default

Yes thanks for catching that, it's from before I had the set command.
If you are using bootonzfs you probably need to set it as well with org.zedenv.grub:bootonzfs=yes, and hopefully you shouldn't get the error anymore. Let me know if that helps.

Thanks John!


X509_verify segfaults when searching for CRLs

The updated code in x509_vfy.c to select the newest CRL if multiple matches are found tries to get the lastUpdate value of the current best CRL even if the current best CRL is NULL. this causes a bad access segfault.
see:
https://github.com/openssl/openssl/commit/325da8231c8d441e6bb7f15d1a5a23ff63c842e5

fixed in OpenSSL 1.0.2j by this commit: https://github.com/openssl/openssl/commit/6e629b5be45face20b4ca71c4fcbfed78b864a2e - sorry for not mentioning explicitly that i was referring to the 1.0.2i tag.


Add tempest cleanup opt

Allow users to enable tempest cleanup feature defined in the tempest image.
https://github.com/openstack-k8s-operators/tcib/pull/208
https://github.com/openstack-k8s-operators/test-operator/pull/207

/lgtm

Hi @kopecmartin
This change is fine foe me, do you have a test run passing that enables this feature? I note it's disabled by default but it would be nice to see a run passing with it enabled.

Testing here -> https://github.com/openstack-k8s-operators/test-operator/pull/216

/approve


Inherit non-enumerable static properties

In es6 classes, transpiled with Babel, static properies are being set with object.defineProperty(Parent, { staticProperty: {  enumerable: false }}), so TypeScript can't make proper extend.
Is there any reason not to set constructor's __proto__ instead of copying properties with cycle?
 var __extends = (this && this.__extends) || function (d, b) {
-    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
+    if (b) Object.setPrototypeOf ? Object.setPrototypeOf(d, b) : d.__proto__ = b;
     function __() { this.constructor = d; }
     d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
 };

Hi @Sl1v3r, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@Sl1v3r, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Mutating __proto__ (or calling setPrototypeOf) has significant perf impact in most runtimes.
It's not clear to me that we should copy down non-enumerable properties. Isn't that the spirit of non-enumerable?

Because according to standard (I'm pretty sure), classes static properties are not enumerable, I've checked latest webkit with classes support:
class Test {
	static method() {}
}
for (var x in Test) console.log(x);
// nothing

But static properties must be inherited:
class Child extends Test {);
typeof Child.method // "function"

So TypeScript can't properly extend javascript constructors, described as class in d.ts
This test shows that mutating __proto__ is really 38% slower in Сhrome, but even a little faster in Gecko and Chrome Mobile. Is this difference really meaningful?

It's not about the speed of the specific operation of setting __proto__ itself, it's about the downstream effects in the runtime in terms of its ability to optimize code involving that object.
If you have an ES6 class to inherit from, then presumably the derived class can target ES6 emit and you're not going to be calling __extends anyway. If it's not an ES6 class, then (hopefully) its static members are enumerable and will be copied appropriately. What's the scenario for an ES5 class inheriting an ES6 class?

Well, this how javascript is meant to work. I thought, TypeScript compiler tries to line-up with standard. If it's goal is to improve javascript performance by the cost of changing it's standard behaviour.
I can't object, as this is ideological question.
Just to make make my intentions clear:
According to ecma-262/6.0 14.5.14 subclass is meant to have __proto__ pointing at superConstructor:
. 5. If ClassHeritageopt is not present, then
... * ...
. 6. Else
... g. Else
..... ii. Let constructorParent be superclass
. 12. Let constructorInfo be the result of performing DefineMethod for constructor with arguments proto and constructorParent as the optional functionPrototype argument.
. 14. Let F be constructorInfo.[[closure]]
. 17. Return F.
In latest webkit:
class Parent {}
class Child extends Parent {}
Child.__proto__ // class Parent

The typescript compiler aims at following the JS semantics as much as possible; it also aims at producing clean, idiomatic and performant generated output. This means that sometimes utility of following the run-time semantics does not justify the cost, specially for a helper as prevalent as __extends.
One thing to note, you do not need to use the default __extends helper if you do not agree with its semantics, you can call the compiler with --noEmitHelpers, and provide your own __extends implementation.


Conditional Hooks

Hello!
I am using hooks to prevent sensitive information in certain fields reaching the database. And this works well.
However, I'd like to save the complete serialzied data in a local Hive storage.
I could call myObject.toMap() but this filters out the sensitive information, which in this case I want to store locally.
I could make the hooks check a global variable to decide on the serialization strategy. But this doesn't feel right.
Another option is to use Hive-annotation to store objects locally. But this results in annotation monsters for two kinds of serializations. Like the one below:
@HiveType(typeId: 0)
@MappableClass()
class Encrypted with EncryptedMappable {
  @HiveField(0)
  List<int> messageCipher;

  @MappableField(hook: EmptyListHook())
  @HiveField(1)
  List<int> messagePlain;
...

Question
Is there a way to set a switch to disable all hooks when calling toJson() or toMap()? I noticed that toString() does not seem to apply any hooks.
toJson(hooks:false)
I am aware that this is probably out-of scope for this project, but I have to ask.
Thank you!

There is no built-in way to conditionally apply hooks, and also not planned.
Other than using a global variable to toggle this maybe you can use Dart Zones for a cleaner implementation.


Error in connection of mongo db

When I try to start the rectum, I get the following error:
body-parser deprecated bodyParser: use individual json/urlencoded middlewares node_modules/ldpjs/index.js:22:9
body-parser deprecated undefined extended: provide extended option node_modules/body-parser/index.js:105:29
[Function: createIndexDoc]
(node:30) DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.
listening on 3000
/app/node_modules/mongodb/lib/utils.js:671
          throw error;
          ^

MongoNetworkError: failed to connect to server [localhost:27017] on first connect [Error: connect ECONNREFUSED <IP_ADDRESS>:27017
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1141:16) {
  name: 'MongoNetworkError'
}]
    at Pool.<anonymous> (/app/node_modules/mongodb/lib/core/topologies/server.js:438:11)
    at Pool.emit (events.js:316:20)
    at /app/node_modules/mongodb/lib/core/connection/pool.js:562:14
    at /app/node_modules/mongodb/lib/core/connection/pool.js:995:11
    at /app/node_modules/mongodb/lib/core/connection/connect.js:32:7
    at callback (/app/node_modules/mongodb/lib/core/connection/connect.js:280:5)
    at Socket.<anonymous> (/app/node_modules/mongodb/lib/core/connection/connect.js:310:7)
    at Object.onceWrapper (events.js:423:26)
    at Socket.emit (events.js:316:20)
    at emitErrorNT (internal/streams/destroy.js:84:8)
    at processTicksAndRejections (internal/process/task_queues.js:84:21) {
  name: 'MongoNetworkError'
}
[nodemon] app crashed - waiting for file changes before starting...

But, my connection uri is correct. On the verso, it works very well

Apologies @matheusriios - I missed this one.  I updated the recto documentation to properly reflect what is happening here.  Recto no longer uses Verso, which is part of the problem you were experiencing. It uses ldpjs, which does use Mongo. I suspect there is more I can do with the documentation so let me know.


Change For Dynamic Table Output

Making the output table be dynamic with sizing
Overview

Making changes to the _print_query_results_table() so the sizing of the table can be dynamic based on the query_results received.
Closes #53
New Dependencies

New Files

Deleted Files

Updated Files

cli.py

Testing

@daralynnrhode It looks like this PR is ready to go, so I am going to merge this now so that it can be included in today's release.


Support MatMul operator when loading onnx

Nice to send you a Pull Request.
I'm Kunio Kojima at the University of Tokyo and a beginner of nngen.
When we loaded a network from an onnx file like nngen.from_onnx(filename),
we got the follow.

/usr/local/lib/python3.7/dist-packages/nngen-1.3.0-py3.7.egg/nngen/onnx/init.py in _get_func(op_type)
def _get_func(op_type)
--->return func_map[op_type]
KeyError: 'Mat'

It seems that nngen supports MatMul (nngen.operator.matmul).
However, it does not support loading MatMul operator from onnx file.
https://github.com/NNgen/nngen/blob/cba265b1a140f2aef7208926703782b6dac9e8be/nngen/onnx/__init__.py#L36-L71
Therefore, we added a mapping from onnx's MatMul to nngen.operator.matmul.

Sorry.
I have misunderstood the operator.basic.
I understand it is the operator for element-wise procedures.
Therefore, my implementation is wrong.


On a fresh compile, tests can hang for a very long time with no indication of what the problem is

Yo:
not sure if this is a problem with this plugin or neotest per se.
On a fresh compile step, test running can hang for a longgggggggg time with no indication that stuff is compiling.
I have no idea what to suggest here but I think it's kind of a problem.

In those cases, I simply check the command output. It's quite difficult to provider feedback during compilation.


remove unused code

Codecov Report

Merging #226 (bfbddd9) into master (b60bf4d) will increase coverage by 0.45%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #226      +/-   ##
============================================
+ Coverage     60.68%   61.13%   +0.45%
  Complexity      537      537
============================================
  Files           116      114       -2
  Lines          2022     2007      -15
  Branches        208      208
============================================
  Hits           1227     1227
+ Misses          720      705      -15
  Partials         75       75

Impacted Files
Coverage Δ

src/main/java/bookface/model/person/Person.java
91.48% <ø> (+1.90%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Sync NameSpace does not update name space in .razor file

This issue has been moved from a ticket on Developer Community.

Sync Namespaces does not update @namespace used in .razor file.
In blazor applications we can define/override default name space in .razor file as shown below.
@namespace RazorClassLibraryEndUserModule.Shared.
When clicking "Sync Namespaces" it does not update or sync namespace in .razor files

Original Comments
Feedback Bot on 12/5/2021, 10:57 PM:
Thank you for taking the time to provide your suggestion. We will do some preliminary checks to make sure we can proceed further. You will hear from us in about a week on our next steps.

Moving over to Razor compiler. Gist is that there's "fake" code being generated for the namespace directive which is why it doesn't get refactored properly.


Use the iouReportID retrieved from ReportActionUtils.getIOUReportIDFromReportActionPreview rather than the one off of the report itself to get the last message for the chat report

@puneetlath please review
Details
This unnecessarily uses the reportID stored on a sometimes absent iou report. We have all the information to show what we need already because getIOUReportIDFromReportActionPreview returns us a the iouReportID which we can use instead.
Fixed Issues
$ https://github.com/Expensify/App/issues/32658
Tests/QA

Have a chat with multiple ious in it, with all but one already paid.
Log out of the app
Log in
Make sure that the LHN preview of the chat shows the IOU ("____ owes ___") instead of "This is the beginning of you chat with../"

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@yuwenmemon this PR looks more like a hot fix to fight symptoms instead of the root cause. Using iouReport.reportID is a common approach that's used in many places and never has been a problem since we'd expect that the report will be present in Onyx – why shouldn't it be there if BE works as expected?
Moreover, this PR will not fix the other problem in the original issue – the absent "Pay" button on the IOU previews. This also happens because the IOU Reports are not loaded properly from the BE on the OpenApp call.
And who knows what other issues may appear because of those incorrectly loaded reports – we'll have to apply the symptomatic treatment for each of them if the RC is not fixed.

Hmmm... You may be right @paultsimura - let me sync with my team to see what the expected behavior is for child iou reports.

Okay, @paultsimura I think the fact we don't load IOU reports right away is intentional (I'm rejoining the Expensify team after a two-month sabbatical so still catching up on some things haha). Because of this, we do want to create the last message text based on the data we have already. Then, I think that once we open the report we can load the associated IOU reports that come along with it for the display of the "Pay" button, etc.

@yuwenmemon great, it should be more efficient than loading all the data on OpenApp. That's basically what I suggested here:

This should be fixed on the BE side ... by modifying the OpenReport API response to return not only the requested report but also all the associated IOU Reports (or even all the child reports).


Is communication with the exchanges API's made over SSL?

I'm submitting a ...
[ ] bug report
[ x] question about the decisions made in the repository
Expected result (what you hoped would happen)
Is communication with the exchanges API's on the CLI made over SSL (HTTPS/WSS)?

Yep! As far as I know no exchanges support non ssl communication.


Spark extractor is very verbose

The Spark extractor can emit very large events, that contains a lot of data.
This might be overloading both in terms of information content (with irrelevant data) as well as causing performance issues.
We would want to research what should included / excluded when sending over the OL event from Spark jobs

worth linking this PR #1271 - which adds the ability to exclude specified facets and excludes by default spark_unknown facet.


chore(deps): update dependencies

:tada: This PR is included in version 1.9.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


workflow just opening system settings to sidecar menu

I noticed in the documentation (and in the alfred workflow blueprints) itself that it's supposed to toggle sidecar on and off with a notification saying what it's done.
for me, it's just opening up system settings to the sidecar menu, but stops there, the rest needs to be done manually. Is this correct behaviour or have I done something wrong or has os x broken this as of 14.1 (23B2073).
thank you for making this btw!!!

Hi First off, thank you for opening the first issue on this repository! Off the top of my head, the issue might be related to your device name. The script specifically searches for 'iPad' in the name, and if your device has a different name, it might not be able to locate it. You can easily edit your device name using the 'Configure Workflow' button. Another thing to consider is whether there's a delay between opening dialogues, but I would start with checking the device name.

Thank for the reply!
Yes I have updated that field to the name of my iPad which is different to the default "iPad". It appears to be something different 🤔
With the delay idea, do you mean perhaps Alfred is processing the requests too fast and not able complete the command to the end?

I was referring to the delay within an AppleScript in the workflow. To modify it, you need to open the workflow view and edit the 'Run Script' node.

Try to alter the values in lines with the delay 0.3 instruction, to make it longer like 0.4 or 0.5. It's possible that some macOS elements appear before the next step in the script is executed, and thus the delay may need to be slightly longer than I initially described.

@xx88xx I have got rid of all of these delays, so it may fix your issue. Please try the latest release.

thanks for updating! unfortunately it seems to still act in the same way. Could it be the fact that I also have an apple tv on my network and it's forcing me decide which one? (perhaps it behaves differently when two devices on the network with sc abilities?)

I'm sorry to hear that the solution didn't work for you. The logic simply searches for a menu item that contains 'iPad', and once it's found, it triggers a click on it. Regarding the apple tv, I have the same setup and it works without any issues for me.

I am on Sonoma 14.4.1, I had this problem too
It may be due to the fact your OS is in a different language that English, because the script is looking for an windows named "Displays"
exists window "Displays"

I believe you can just replace it be window "Displays" by window 1
It did the trick for me !
But then I faced another issue:
The applescript is clicking on the first item of the menu (pairing mouse/keyboard to the ipad), instead of the last one (which is sidecar external monitor)

I tried to tweak the script to make it work, but I believe there is a bug due to the fact the two menu items have the same name (here "iPad de Jules").
Let's dig to find the right menu index
wrong button, index 3 ⤵

right button, index 7 ⤵

so if I replace
set menuItem to (first menu item whose name contains device)

which is in fact
set menuItem to menu item 3

by
set menuItem to (last menu item whose name contains device)

which is in fact
set menuItem to menu item 7

It is still clicking on the pair mouse/keyboard button ! The only solution I found was to temporary disable mouse/keyboard button from the monitors advanced settings.
Hope it helps

Closing this issue due to inactivity. Please feel free to reopen or comment if there's more to discuss or if the issue persists. Thank you!


Deployment in Hub network

Hi, we have Azure reference architecture Hub & Spoke. Can I deploy Bastion in Hub network and access VM in spoke networks ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03ec4426-bfc1-b046-500d-38b2ca89c71d
Version Independent ID: cdacb6c7-1d83-c62b-9204-f04d9955722c
Content: Azure Bastion FAQ
Content Source: articles/bastion/bastion-faq.md
Service: bastion
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@jjindrich At this time, you can only access VMs inside the same Virtual Network. If you would like us to change this in the future, please leave your feedback Here.

Thanks, added as feedback for voting https://feedback.azure.com/forums/217313-networking/suggestions/38002603-bastion-supporting-vnet-peering-for-hub-spoke-de


Disable PointerHolder by default

I intend to merge this when we are ready to start merging qpdf 12 ABI-breaking changes. This is not itself ABI breaking, but it is something I don't want to introduce until qpdf 12.

Adding abi label so I remember not to merge this before we open the window for qpdf 12.


GEODE-4841: Changed typedef to using statement.

Given this is involved in a PIMPL model association, I'm not convinced this gains much... curious to hear thoughts...

@echobravopapa I see it more as a "C++11 all the things."  Start setting some precedence to prefer using over typedef since you can do fun things with templates and scope better with using

@moleske for sure, wasn't sure the value beyond that and hoped to spur some discussion...

The ugly of this is the typedef is defined twice, in the same namespace, across two headers, which coincidentally are both included in the same source. May the two never differ.
The right thing to do would be to put the definition in its own header and include it where needed to remove the duplication.


Add a /health endpoint

Hello
I'd like to be able to call a /health to know if everything is alright at a glance, like for headscale

It could return 500 if unable to contact headscale & 200 otherwise. Must be without auth, since those are often used by monitoring or kubernetes to check if everything's alright.
Thanks !

Added in 0.3.7, it will be under /admin/healthz.


Fixes for current electron version

Hello,
I stumbled over your kit and had problems getting it to run. I have fixed the parts I could so that the app starts without errors and the right click context menu works.

This seems like a great fix and it works with electron 1.7.10
Will this ever be merged?


Offline agent stays in the pool after it's --once run

Agent Version and Platform
Version of your agent? 2.149.2
OS of the machine running the agent? Linux
Azure DevOps Type and Version
dev.azure.com (formerly visualstudio.com)
What's not working?
With the latest agent release I am looking into using the run once flag (--once) to tear down our agent containers after they have completed a job. This is working correctly in terms of running but after the container has been stopped the offline agent still remains in the pool. I expected that it would execute it's normal stop procedure which involves removing itself from the agent pool. Is this by design or is it perhaps a bug in the run once functionality?

@EwanNoble remove agent from pool (Unconfigure) requires admin privilege. the behavior you saw is by designed since --once don't have any credential from you. :)

Hi @TingluoHuang, thanks for the response. The admin credentials would be available to the service at this point as they are used for configuration, would there be scope for a feature to provide the 'run once' agent to access those credentials if available?

@EwanNoble we don't have feature for that yet, but i think you can do it yourself.
Dockerfile:
CMD "config.sh && run.sh --once && config.sh remove"

@TingluoHuang that makes a lot of sense and it worked perfectly! Thanks for your help. 😊

cool, i am going to close this issue, please reopen if you need more help. :)


sysctl: reuse BSD script for BusyBox

If asking sysctl for its version on Linux fails, assume it's from
BusyBox and call it like BSD sysctl. When passing a conf line, trim
spaces around = with sed, because both BSD and BusyBox expect the
variable=value sysctl format. Despite the BusyBox sysctl applet
missing the --system command line switch, OpenRC can use this applet
now, so remove the recommendation to disable its build.

The bsd_sysctl function does not process all of the same directories as the --system switch for procps sysctl, so you would end up with different behaviour on busybox than you would with procps if we do this.
Also, "&>" is a bashism so this should be avoided.
We should either make busybox sysctl have a --system switch that is compatible with procps sysctl or, imo the less preferred way would be to write a separate function in the sysctl service that processes everything the same way procps does using busybox sysctl.

Exactly same behavior isn't the goal, what procps does is even
unexpected given OpenRC's sysctl.d/README. On Gentoo I don't have any of
the additional paths listed in the procps manual:
# ls /run/sysctl.d/*.conf /run/sysctl.d/*.conf
/usr/local/lib/sysctl.d/*.conf /usr/lib/sysctl.d/*.conf
/lib/sysctl.d/*.conf /etc/sysctl.conf
ls: cannot access '/run/sysctl.d/*.conf': No such file or directory
ls: cannot access '/run/sysctl.d/*.conf': No such file or directory
ls: cannot access '/usr/local/lib/sysctl.d/*.conf': No such file or
directory
ls: cannot access '/usr/lib/sysctl.d/*.conf': No such file or directory
ls: cannot access '/lib/sysctl.d/*.conf': No such file or directory
/etc/sysctl.conf

Which packages do these directories come from? On a systemd system I do
have one other match, /usr/lib/sysctl.d/50-default.conf, which comes
from systemd itself and thus not applicable here.
I'll edit out the &> and rebase.

The //lib/sysctl.d locations are part of what systemd recommends as locations for packages to install sysctl files, so we need to check for and not complain about *.conf files in those locations missing.
It is a little more tricky though. My understanding is that the way the files are processed for the --system option  is a little more subtile than just putting all of the files in order and going through them. A file found in a later location in the directories actually fully overrides a file of the same name found earlier in the directories, so if we want to do that in busybox without the --system switch we have to emulate that behavior. That's why I would rather let sysctl deal with the --system switch and why we can't use the bsd_sysctl function for busybox. Feel free to correct me if I am wrong about the --system option.
To check which sysctl you are dealing with, it might be better to capture the output of
command -v sysctl in a variable and inspect that.

Of multiple files with the same basename, the one in the first dir applies and and the latter are skipped, according to the manual. It's not difficult to script, the question is why? This systemd recommendation about paths and overrides sounds arbitrary, no packages I've got installed except systemd itself have any files in these dirs, and I don't get why keep the BSD method at all if systemd behavior compliance matters.
Will see what distinguishable info the command check provides and try to apply it.

Command only prints the path, doesn't make it clear which sysctl is present. With BusyBox, it can be a binary or a symlink to /bin/busybox. I chose the -V option for the condition because most BusyBox applets deliberately don't implement it and have it return a failure code.

from man sysctl :

   --system
         Load  settings from all system configuration files. Files are read from directories in the following list in given order from top to
         bottom.  Once a file of a given filename is loaded, any file of the same name in  subsequent directories is ignored.
         /run/sysctl.d/*.conf
         /etc/sysctl.d/*.conf
         /usr/local/lib/sysctl.d/*.conf
         /usr/lib/sysctl.d/*.conf
         /lib/sysctl.d/*.conf
         /etc/sysctl.conf

$ pacman -Qo /usr/bin/sysctl
/usr/bin/sysctl is owned by procps-ng 3.3.15-1
$

Assuming the man page aligns with the code, the behaviour doesn't seem to be complicated or PID1 specific.
I'm guessing busybox sysctl doesn't come from procps and behaves differently ?

Whoops, I think this is already known to the other posters.

Thanks for quoting the procps manual, yes it's what I'm referring to and what I'm asking to clarify. Neither BSD nor Linux systems to which I've got access place their sysctl conf in these additional paths. The expected OpenRC behavior according to the OpenRC doc is to look up just the /etc ones, which is already more than FreeBSD scripts do and that would still be enough. If there's agreeable rationale to match the new procps paths introduced by systemd you can come up with, I'd prefer to update the README in detail alongside implementing this logic. Otherwise should side with the BSD behavior and even remove the use of the --system flag which mismatches what OpenRC README claims OpenRC to be doing.

Did some checking and found this :
debian, fedora , opensuse, gentoo, archlinux have procps-ng
void linux uses uedev + runit and procps-ng
apline linux uses openrc + busybox + musl and procps-ng
This indicates that while systemd devs started this change, it's integration in procps-ng has made it the default sysctl implementation on linux.
Openrc should support it.
Since BSDs and Busybox use a different sysctl implementation and openrc also supports running with them, the question becomes how we should support it.
Atleast 2 approaches seem possible :

emulate procps-ng sysctl behaviour on busybox / BSDs in openrc code
(It may be possible to get parts of this code upstreamed)

have openrc only use sysctl functionality shared between procps-ng / busybox / BSDs and split off code specific to procps-ng sysctl.d to a separate package .
This is similar to what was done for tmpfiles.d setup with the opentmpfiles package.

We don't really want to force anything on the bsds, they don't have a reason to emulate procps. That is why I don't want to touch the bsd_sysctl function.
For busybox, the ideal would be to get the busybox sysctl command to understand the --system switch. That way, we don't have to make any changes to OpenRC.
There is a bug for this upstream which hasn't been closed or responded to, so it looks like w e just need to find someone to write the patch [1].
[1] https://bugs.busybox.net/show_bug.cgi?id=8556

Could you run ls /run/sysctl.d/*.conf /run/sysctl.d/*.conf /usr/local/lib/sysctl.d/*.conf /usr/lib/sysctl.d/*.conf /lib/sysctl.d/*.conf wherever you've got access to, and post which packages have files there if any? That'll actually answer whether even on Linux anything needs to be emulated. I've been running this patch for two months on openrc + busybox + musl before posting and haven't run into such a need. IMO it's clean to not hardcode path quirks in a compiled utility, but have a shell script in the init system default to procps and if it's missing then fall back to BSD behavior, which it already has code for and which this patch lets it use.

Even if I do that, it only proves that the packages I have installed on my system don't use the feature.
The /run directory is dynamic and files can be written there by packages. The /lib directories are where packages themselves can install sysctl configurations, and just because I don't have things there doesn't mean other packages that are not installed don't.
The --system switch is a standard on all linux systems that use procps' version of sysctl, so we need to get this switch added to busybox sysctl. Your approach would create a "fix" that only works for OpenRC users. I think this needs to go further up the chain to busybox sysctl.

@williamh I know this is closed, but the desire to have busybox have a ---system parameter seems to have fallen on deaf ears. There has been no activity on the bugs opened in 2015, 3.5 years later. May need to patch downstream and provide patch in bug to upstream. Even then that does not mean it will be accepted and added to busybox. It seems like busybox devs are not interested, not sure a patch will make any difference.
It maybe time to consider alternative approaches as needed. If this comes up again. Either way i would not hold out hopes for busybox getting a --system parameter like procps-ng anytime soon.

@wltjr Following your link, you can join the CC list and write a
comment, devs will see activity. But read above. --system is a systemd
quirk, and nobody seems able to explain why it exists or even show which
apps scatter their config all over the disk like it suggests. Convincing
procps-ng developers to deprecate it makes more sense, if you want to
spend any time on this.


There is no way to get the screen height in Android platform

Using the document ready event or DOM ready, window.innerHeight returns wrong value. Can't see any other way to get the current window height so steroids should provide any way to solve this issue.

How is the value wrong (too small/too large)? Does the keyboard, navbar or tab bar visibility have any effect?

It doesn't take the navigation bar height into account and it returns the same than screen.height this works fine on iOS

If I try to debug this using the Chrome inspector, and I add a breakpoint on that line on DOM ready or document ready; then it works fine and returns the right value

It seems like nav bar is not yet shown when the DOM ready fires and that's why window.innerHeight returns wrong value. We are working to fix these issues with nav bar. In the mean time, you could try to call window.innerHeight inside deviceready for a workaround.

I've already tried that workaround using deviceready event but it doesn't work fine. Sometimes it also fails and it's random

I believe that the right approach to achieve this is by adding a window resize trigger event to the nav bar. This way, when the navbar is being displayed or closed, the resize event is activated.

That's a good suggestion. We'll see if we can set a window.resize event trigger.

I could not reproduce this issue. I have tested on XWalk and Platform web view. Android 4.4 and 4.3
I have implemented the following test for innerHeight and innerWidth in our steroids-js/testApp to confirm
that the innerHeight, innerWidth and the window.onresize event works fine on Android and iOS.
document.addEventListener "deviceready", ->

    onresizeCounter = 0

    displayInnerSizes = ->
      document.getElementById("innerHeight").innerHTML  = window.innerHeight
      document.getElementById("innerWidth").innerHTML   = window.innerWidth
      document.getElementById("heightBar").style.height = "#{window.innerHeight}px"

    increaseOnResizeCounter = ->
      onresizeCounter++
      document.getElementById("onresizeCounter").innerHTML = onresizeCounter

    window.onresize = ->
      displayInnerSizes()
      increaseOnResizeCounter()

    displayInnerSizes()

  @testShowNavBar: ->
    steroids.view.navigationBar.show()

  @testHideNavBar: ->
    steroids.view.navigationBar.hide()

  @testShowTabBar: ->
    steroids.tabBar.show()

  @testHideTabBar: ->
    steroids.tabBar.hide()


Allow featuregates to be set on kubelet

Tell us about your request
I would like to be able to set featuregates for kubelet.
I am willing to work on this myself if you are willing to support this feature
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
I would like to test out container snapshotting: https://kubernetes.io/docs/reference/node/kubelet-checkpoint-api/
I am running a compatiable runtime, cri-o. But am unable to easily set the featuregate for kubelet.
Are you currently working around this issue?
Not at the moment, but I probably could figure something out
Additional Context
no
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

@bwagner5 that makes sense, missed that in the docs sorry about that. I will close the issue


Include nested router in example app.

The current example app needs to be rejiggered to include a nested router.

Example app modified to have multiple todo lists, so the TodoList component can be a nested router.


The first line of config file is parsed error

version:0.5.2
can't get the first properties correctly, others are right.
the configuration in nats.conf is:
1 net:"10.62.X.X"
2 port: 50021
print the mapping in parse:

but the gnatsd doesn't listen the configured IP(use default IP<IP_ADDRESS>).
SZX1000023942:/opt/wsz/nats/install/nats/bin # lsof -i:50021
COMMAND   PID USER   FD   TYPE   DEVICE SIZE/OFF NODE NAME
gnatsd  38251 root    8u  IPv6 23170710      0t0  TCP *:50021 (LISTEN)

In general it expects a hostname, but I agree a direct IP should work.

when add 1 line at the top of nats.config:

I will take a look, thanks for the report.

If the IP is quoted it should work.
e.g.
net: '<IP_ADDRESS>'

Do you use the one listed above with the 'X's? e.g. '10.62.X.X'?

net: "<IP_ADDRESS>"

Can you try https://github.com/nats-io/gnatsd/releases/tag/v0.6.8 and let me know the results?

the first line is not parsed right.
when i add one line at the top:
name: gnatsd

version is:0.6.8

ok will take a deeper look, thanks..

Works for me..
~/Development/go/src/github.com/nats-io/gnatsd> more server/configs/test.conf
net: "<IP_ADDRESS>"

# Simple config file

port: 4242
#net: apcera.me # net interface

http_port: 8222

authorization {
  user:     derek
  password: bella
  timeout:  1
}

# logging options
debug:   false
trace:   true
logtime: false
#log_file: "/tmp/gnatsd.log"
#syslog: true
#remote_syslog: "udp://foo.com:33"

# pid file
pid_file: "/tmp/gnatsd.pid"

# prof_port
prof_port: 6543

# max_connections
max_connections: 100

# maximum control line
max_control_line: 2048

# maximum payload
max_payload: 65536

# slow consumer threshold
max_pending_size: 10000000
~/Development/go/src/github.com/nats-io/gnatsd> ./gnatsd -c ./server/configs/test.conf
[15011] 2015/12/03 11:59:59.431309 [INF] Starting gnatsd version 0.6.9.beta
[15011] 2015/12/03 11:59:59.431496 [INF] Starting http monitor on <IP_ADDRESS>:8222
[15011] 2015/12/03 11:59:59.431604 [INF] Starting profiling on http port 6543
[15011] 2015/12/03 11:59:59.431620 [INF] Listening for client connections on <IP_ADDRESS>:4242
[15011] 2015/12/03 11:59:59.431645 [INF] gnatsd is ready
^Z
[1]+  Stopped                 ./gnatsd -c ./server/configs/test.conf
~/Development/go/src/github.com/nats-io/gnatsd> lsof -i:4242
COMMAND   PID  USER   FD   TYPE             DEVICE SIZE/OFF NODE NAME
gnatsd  15011 derek    6u  IPv4 0x3d844519461d4231      0t0  TCP <IP_ADDRESS>:4242 (LISTEN)
~/Development/go/src/github.com/nats-io/gnatsd>

Feel free to reopen if I am missing something.


HTML can't be include

Hi,
Today i decide to try MDL on an angular app.
The first page are pretty cool but when i try to use ng-view to insert a template, mdl stop working.
The style is broken and components doesn't start, and I have no bugs in JS console.
Someone have a idea about how fix this ?
Thanks

We don’t directly support Angular (as we are targeting static content for now).  I recommend head over there and looking for the material-design-lite tag.


chore: corrected path in yml file

Description
Problem*
Wrong Path
Summary*
I corrected the path
Additional Context
none
Documentation*
Check one:

[X] No documentation needed.
[ ] Documentation included in this PR.
[ ] [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

[X] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

This is correct as it's referring to the https://github.com/noir-lang/.github repo


[Documentation]: The loading documents example does not work with latest versions

Documentation Issue Description
The example of loading the documents from a list of text strings in Python results in an error using the latest langchain/llama index installations.
This code below results in the error.
from llama_index import Document

text_list = [text1, text2, ...]
documents = [Document(t) for t in text_list]

Langchain version: '0.0.217'
LLama Index version: '0.6.34.post1'
Error:

Proposed fix:
from llama_index import Document

text_list = [text1, text2, ...]
documents = [Document(page_content=t) for t in text_list]

Documenation Link
https://gpt-index.readthedocs.io/en/latest/guides/primer/usage_pattern.html#load-in-documents

@kadereub It should be Document(text=t), appologies for missing this. Will merge a patch to the docs in a second