Color: Ensure RGBA getters return values in the expected range

Fixes #81043

I don't know if this is worth implementing. If one of the floats in Color is NaN, then its *8 property really is also not defined. We could just document that NaN is mapped to -2147483648.
Alternatively, we could solve this by casting to uint8_t instead of int32_t, forcing it to the 0 to 255 range without a branch.

If it was for anything performant, we could just clamp in integer space, which I suspect would also neatly avoid Nan. e.g.
int32_t get_r8() const { return CLAMP((int32_t)(Math::round(r * 255.0f)), 0, 255); }

(There may even be a CPU instruction for saturated conversion in some cases, whether the compiler can take advantage I don't know).

Saturation arithmetic operations are available on many modern platforms, and in particular was one of the extensions made by the Intel MMX platform, specifically for such signal-processing applications. This functionality is also available in wider versions in the SSE2 and AVX2 integer instruction sets. It is also available in ARM NEON instruction set.

I'm assuming the reason this was clamped as float space in the first place was to deal with input values outside INT32_MAX and INT32_MIN, which looks to be undefined behaviour converting to int32_t. Although it looks like the CPU either saturates or returns sentinel value, which should be safe at least.

Most floating-point operations indicate an invalid operation by returning a special “Not-a-Number” (NaN) value, but conversion to integer doesn’t allow that option. Any result value can come from a valid conversion, and there is no single “correct” result for an invalid conversion. Of course, completely random results for such conversions aren’t useful, so two different approaches are commonly used. Intel Architecture (IA) uses the result value farthest from zero as a substitute for NaN, so that any invalid conversion returns this sentinel value. (The specific value returned depends on the result type.) The sentinel value is easy to test for, and it will often cause distinctive behavior during testing and debugging.

The other common approach is called saturation, where any floating-point value too high to fit in the destination type gives the highest possible destination value, and any value too low to fit gives the lowest possible value. If the source value is NaN, zero will be returned for the result. Even if the result is wrong, it is as close as possible to the correct result and may be less likely to cause failures. ARM uses saturation for its conversion instructions.
https://devblogs.microsoft.com/cppblog/microsoft-visual-studio-2022-and-floating-point-to-integer-conversions/

I'm with @aaronfranke though I wouldn't attempt to deal with Nan in everyday math routines, as it will usually screw up any routine it touches, then propagate, and is difficult to recover from. So it's better to avoid it at source imo, either importing data, or using math functions that are liable to produce Nan output. You can also liberally sprinkle DEV_CHECK_ONCE() or similar to check for Nans in math routines in DEV builds, to at least catch engine bugs (that's probably a discussion that should happen some time).


Feature input bending

Changes:

input bending
replace internal _check_registry by get_registry
add post_init generic for creating through fields

splitout from my foreign_key PR.
I think I will need a bit longer for the other PR. Black magic eats my kwargs


Added example to persist graph

Description
Added example to store Composable Graph.
Fixes # (issue)
NA
Type of Change
Please delete options that are not relevant.

[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] I tested the code

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

@Disiok Here is the new PR, please review

Thanks!


Issues when running "npm start" in root folder

Hello, Apologies if the wrong place but I am working through the Tutorial (Exercise - Retrieve an access token by using MSAL) and when I run the command "npm start", it configures but then I am unable to get a response from http://localhost:8080
Below is a picture of the output in the terminal.

I am quite new to Node.js so any suggestions would be greatly appreciated.

I think it may have something to do with this - https://www.theverge.com/2022/1/9/22874949/developer-corrupts-open-source-libraries-projects-affected?utm_campaign=theverge&utm_content=chorus&utm_medium=social&utm_source=twitter
Also - https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/

Seems a fix has been issued


behavior of defaultValue

Hi, guys:
There's an unexpected behavior of the defaultValue param in @Option Annotation.
When use default values from environment variables of invalid types, it always throws ParameterException even though I passed the value of the argument.
How to solve it
Maybe we can disable the type-checking of default value when the argument value has been already passed.
And I will be honored to submit the example code of this situation and create a  pull request if necessary.

Can you please show how to reproduce this problem?

Of course, the code is below:
import picocli.CommandLine;

@CommandLine.Command(name = "run")
public class App implements Runnable {

    @CommandLine.Option(names = "--port", defaultValue = "${env:PORT}", required = true)
    Integer PORT;

    static public void main(String[] args) {
        App app = new App();
        args = new String[]{"--port", "5672"};
        CommandLine cmd = new CommandLine(app);
        cmd.execute(args);
    }

    public void run() {
        System.out.println(PORT);

    }
}

before run :
export PORT="xxx"

then may got:
Invalid value for option '--port': 'xxx' is not an int
Usage: run [--port=PORT>]
      --port=<PORT>

@sjyMystery Thank you for the clarification. I understand the issue now.
It looks like this is the same cause as this ticket: https://github.com/remkop/picocli/issues/961 (I just changed the title of that ticket.)
Please read my comment on that ticket for more details.
Are you interested in providing a pull request for this? That would be great!

I've get your point.By the way, is there anything need or suggested to read before I make a pr?Thanks.

@sjyMystery There is no documentation on the implementation, just the source code. :-)
It may be as simple as reordering these 2 lines in CommandLine$Interpreter.parse(List, Stack, String[], List) on line 11486:
Before:
private void parse(List<CommandLine> parsedCommands, Stack<String> argumentStack, String[] originalArgs, List<Object> nowProcessing) {
...
  try {
    applyDefaultValues(required); // currently defaults are applied first
    processArguments(parsedCommands, argumentStack, required, initialized, originalArgs, nowProcessing);
  } catch (InitializationException ex) {
...

After:
private void parse(List<CommandLine> parsedCommands, Stack<String> argumentStack, String[] originalArgs, List<Object> nowProcessing) {
...
  try {
    processArguments(parsedCommands, argumentStack, required, initialized, originalArgs, nowProcessing);
    applyDefaultValues(required, initialized);  // only apply defaults to the missing args
  } catch (InitializationException ex) {
...

Then, in applyDefaultValues(), we only modify the ArgSpec objects that are not in the initialized set.
But let's add some tests to verify.

@sjyMystery Have you had a chance to look at this? Let me know if you get stuck anywhere, I will try to help. :-)

Fixed in master.
To verify this, check out picocli master locally, and build it with publishToMavenLocal. That should publish picocli-4.2.1-SNAPSHOT to your local .m2 Maven cache.
git clone https://github.com/remkop/picocli.git
cd picocli
gradlew publishToMavenLocal

You can then try this in a project that uses the info.picocli:picocli:4.2.1-SNAPSHOT dependency. Feedback very welcome!


Choice of Fancy Zones template is reset au each update

Microsoft PowerToys version
0.70.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
FancyZones, FancyZones Editor
Steps to reproduce
Each time PowerToys is updated, I have to choose again the FancyZones template I want for each monitor. And it's not new, I have had the problem for years as far as I remember.
✔ Expected Behavior
Keep the chosen FrancyZone template when Powertoys version changes
❌ Actual Behavior
I have to choose again the template I want for each screen
Other Software
No response

Hi @jeanclaudebdev, to verify, is it happening only when PowerToys is updated? It's known that layouts could be reset when the monitor ID is changed in the system, e.g. after a computer restart. So I'm asking to make sure it's a different issue.
/bugreport

Hello Seraphima ,
You raise an interesting point. On my systems, it's very common that Windows changes monitors configuration. Consequently, forget my report please, it is quite possible that the issue is not related to PowerToys update but may be caused by the restart.
All the best,
--
Jean-Claude Berger, E.I.
Systems, Clouds, RDBMs consultant, Microsoft Certified Trainer
Lyon, France. Tel: +33 (0) 609 772 708
From: Seraphima Zykova @.>
Sent: Monday, June 5, 2023 1:21 PM
To: microsoft/PowerToys @.>
Cc: Jean-Claude Berger @.>; Mention @.>
Subject: Re: [microsoft/PowerToys] Choice of Fancy Zones template is reset au each update (Issue #26661)
Hi @jeanclaudebdevhttps://github.com/jeanclaudebdev, to verify, is it happening only when PowerToys is updated? It's known that layouts could be reset when the monitor ID is changed in the system, e.g. after a computer restart. So I'm asking to make sure it's a different issue.
/bugreport
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/issues/26661#issuecomment-1576606558, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIOYAQCSCAMGZ3ZLR7FMKXTXJW6LBANCNFSM6AAAAAAY2VJ7IQ.
You are receiving this because you were mentioned.Message ID: @.***>

Thank you for your quick reply! I need to ask you to upload the bug report once more, directly into the GitHub comment, because when you reply via email, files are not attached, unfortunately. Thank you!
/needinfo


[docs] Fix WithStyles import statement for @mui/styles

Steps to reproduce:

Visit https://mui.com/styles/advanced/#augmenting-your-props-using-withstyles
Second code sample references previous import location for WithStyles

Screenshot:

[x] I have followed (at least) the PR section of the contributing guide.

@altruity It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


⚠ Bofrost.com has degraded performance

In 77a676e, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 907 ms

Resolved: Bofrost.com performance has improved in 8b10cf8.


Is there plan to add the DialContext support?

Since in Go 1.7+, the net.Dialer supports DialContext(), and Dial is about to be deprecated

Hello, sorry, my focus shifted so I don't have any plans to continue development of this package, but I will be happy to accept and review contributions.


Optionally plot tau lines

One or multiple tau lines would be important to have displayed for phasor plot calibration

Closed via #59


Support completions for bash, ruby, php

Note that Vim often detect bash scripts as sh so we include that too.

The detection works on filetype, although when the filetype is Python the plugin also checks the extension.

@airblade Could you also check the extension for the other file types?
The list of supported is available at https://github.com/kiteco/kiteco/blob/master/kite-go/client/internal/kitelocal/permissions/support_status.go. Checking the extension after the file type was accepted should be enough. I don't think that it's necessary add a mapping file type <> file extension in the vim plugin.

If we are going to check the extension, we don't need the file type check – would you agree?

Yes, I agree - unless vim disabled features like completions for file types unknown to vim. If that's not the case or all kited extensions have valid vim file types, then checking just the extension is fine.

If we are configuring the file extensions that kited recognises, do we still need to query the /clientapi/languages endpoint?
And if we do, I'll just mention that the endpoint reports language names (a.k.a. file types), not extensions.

The user can set the variable g:kite_supported_languages to opt in to the languages they want Kite's completions for.  This made sense when there were only two or three possible languages (go, python, and javascript).
Now Kite supports lots of languages and the assumption is that while the user may want to opt out of one or two languages, they will want most of the languages on offer.
However it is not easy for the user to opt out of a language or two.  It would require setting the variable to the list of available languages excluding the ones they don't want.  But where would they find the list of available languages?  Even if they could find the list, how would they keep it up to date in future?
I suggest that we support both opt in and opt out by prefixing opt-out languages with a minus.  For example:
let g:kite_supported_languages = ['-java', '-html']  " -> all kited's languages except java and html
let g:kite_supported_languages = ['python', 'go']  " -> only python and go

Does that sound good?

👍 on opt-out for language support. But the new languages are similar to JS & Go, where they should not be on by default.
The reason for this is that we don't want to disable other completions providers when the user is coding in these languages, as the completions Kite provides may not be as comprehensive as other providers.

@metalogical So the default should remain Python only?

@airblade correct
I'm currently working on documenting how I integrate Kite into Vim for other languages via LSP (Coc.nvim) for users who may want an alternative.

@airblade apologies for the confusion here, which was caused by my suggestion.

@metalogical Do you have a preference for how the user could opt in to all of Kite's languages, without having to list them all out?
One approach would be to introduce a special value such as ALL.  For example:
let g:kite_supported_languages = ['ALL']

This is ready for another review.

@metalogical Would you review this or should I do this?

Rebased and merged in 144d6ce...3acb1be.


Adds codemirror 5

[ ] Code reviewed
[ ] Ready for merge

Ads new /codemirror5/ directory and updates CSS.

Don't add liquibyte.css. The way they wrote the style for some elements is general and not theme related (I should post something on CM github)
For similar reasons don't add ttcn.css

Sacks of balls, I thought I had merged this...


Create  Component

Summary
Build a component for displaying a single title video card. In the attached screenshot, you can see four title video cards. Your job is to create a very similar user interface using only components from our melos component library: https://github.com/lifechurch/melos
You won't be able to recreate the exact look and feel that you see on the Bible.com videos page, but that's OK! 😄 What you see on Bible.com represents our old design style, but melos represents our newest design specs. I am sure you'll have questions, so feel free to ping me. We'll get one of our YouVersion designers to give you the final 👍  when you're done. So, you can expect there to be some back and forth work with them getting it just right.
Mock API Data
After #11 has been completed, there should be some mock data available to use while building your component. Instead of hard-coding the strings and images, you want to grab those from the mock api data. If you have questions about this, just make a comment here and we'll do our best to answer quickly.
This is what you're building

This is a screenshot with four title video components on the same page

Will be doing this today

@FottyM It's all yours sir!

@michael-martin-al
import Card from '@youversion/melos/dist/components/containers/Card'
import LazyImage from '@youversion/melos/dist/components/images/LazyImage'

Is it possible to import all the needed components in one single implot instead of separated ones?
Something like.
import {Card, LazyImage} from '@youversion/melos'

or maybe for separated components like typography
import {Heading1, etc...}  form '@youversion/melos/dist/components/typography/'

The documentation isn't really detailed about it or maybe I just couldn't find it 😅

We built it to handle single import only so that bundlers wouldn't bundle the whole library when you import one component. So, you'll have to import one component per line. Sorry about the inadequate documentation. Feel free to drop us a PR with some better docs where you think it would help on our melos repo.


php version not declared

No php version is declared, indeed the whole "require" section is missing from composer.json (didn't look at code, so maybe some other ext could be missing too)

We don't currently declare a PHP version, I'm brand new to the repo and am currently trying to sort out which versions of PHP we should support. Based on default Raspberry Pi OS IMHO we should be supporting 7.2, 7.3, and working to sort out how to get 7.4 installed and ensure working there.
I'm not sure what you were trying to do, but the readme instructions are correct in regards to running composer require piphp/gpio to install this into your application.

What I'm trying to do is improve this repository. Declaring supported php version is a de facto standard (apart from obvious advantages).
IMHO you should support nothing before php 7.2 (7.1 is too old and out of support) and 8.0.
So: ^7.2 || ^8.0

What I'm trying to do is improve this repository. Declaring supported php version is a de facto standard (apart from obvious advantages).
IMHO you should support nothing before php 7.2 (7.1 is too old and out of support) and 8.0.
So: ^7.2 || ^8.0

Ah I see. As it currently stands I believe i"m going to pick 7.3 to standardize on at the moment since 7.4 doesn't come default with Raspberry Pi OS.

Not supporting current php version is not fair. Moreover, curren Ubuntu for Pi comes with php 7.4

I'm fairly certain release 0.1.0 will work on PHP 7.4.
Based on the 1 result in the poll on #26, the only respondent so far is using Raspberry Pi OS

I don't think it's too far off to get 7.4. Maybe even later today. There's just been several other things I wanted to get updated first.

Well, you can count me as a late voter for Ubuntu, taking your results to 50/50.
Anyway, you should release 0.1.0 as your first release, and targeting 1.0.0 as your stable (everything below 1 is de facto considered unstable)


Doesn't work with yarn v2, missing peer dependency for prop-types

We need to add prop-types to the peerDependencies
https://github.com/yarnpkg/berry/issues/913

This will probably fix #58 as well.

This should be fixed now in https://github.com/plaid/react-plaid-link/pull/81/
Please re-open this issue if it's not!


Fix compilation on gcc-mingw-w64 8.3 (debian buster)

relates to https://github.com/moby/moby/pull/39880
Debian buster installs gcc-mingw-w64 8.3, causing compilation to fail due to the hard-coded path for includes.
In file included from /usr/x86_64-w64-mingw32/include/minwindef.h:163,
                 from /usr/x86_64-w64-mingw32/include/windef.h:8,
                 from /usr/x86_64-w64-mingw32/include/windows.h:69,
                 from containerutility.h:3,
                 from argumentstream.cpp:1:
/usr/x86_64-w64-mingw32/include/winnt.h:1554:11: fatal error: x86intrin.h: No such file or directory
 # include <x86intrin.h>
           ^~~~~~~~~~~~~
compilation terminated.

Note that instead of adding a manual path to this list, compilation also succeeds if the -nostdinc option is removed (which makes gcc-mingw-w64 search the standard paths:
x86_64-w64-mingw32-g++ -print-search-dirs
install: /usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/
programs: =/usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/:/usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/:/usr/lib/gcc/x86_64-w64-mingw32/:/usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/:/usr/lib/gcc/x86_64-w64-mingw32/:/usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/../../../../x86_64-w64-mingw32/bin/x86_64-w64-mingw32/8.3-win32/:/usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/../../../../x86_64-w64-mingw32/bin/
libraries: =/usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/:/usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/../../../../x86_64-w64-mingw32/lib/x86_64-w64-mingw32/8.3-win32/:/usr/lib/gcc/x86_64-w64-mingw32/8.3-win32/../../../../x86_64-w64-mingw32/lib/

With the -nostdinc removed, compilation is successful
x86_64-w64-mingw32-g++ -fno-exceptions -std=c++11 -static -DUNICODE -municode -O3 -s -o containerutility.exe argumentstream.cpp commands.cpp containerutility.cpp identity.cpp version.cpp
echo $?
0

I decided to keep the current approach, assuming that specifying these paths, and
explicitly excluding the standard paths was done for a reason. That said, if there
is no specific reason, we might want to opt for the last option, as it is more
flexible and doesn't depend on hard-coded paths (which may change in future
updates).

ping @vikramhh @johnstep @ddebroy PTAL

After discussing this with @chris-crone, we couldn't come up with reasons to exclude the standard paths, and I decided to open an alternative PR: https://github.com/docker/windows-container-utility/pull/2


gobackup start not find log

When I use gobackup perform, I can see the log, but I cannot find the log when I use gobackup start.

~/.gobackup/gobackup.log


frr and ovn-bgp-agent molecule tests don't gather facts

Recently, edpm-ansible roles were updated to not gather facts by default:
https://github.com/openstack-k8s-operators/edpm-ansible/pull/755
frr and ovn-bgp-agent molecule tests are updated to not gather facts as well.

if the edpm_frr-molecule test doesn't fail after having reverted https://github.com/openstack-k8s-operators/edpm-ansible/pull/760, it seems to me this PR doesn't help at all:
https://softwarefactory-project.io/zuul/t/rdoproject.org/build/50d8e248b9084f06adc7522c119b278a


Summary for ActiveRecord

[ ] 1. Rename BaseActiveRecord class to AbstractActiveRecord
[ ] 2. Make AbstractActiveRecord class implements only ActiveRecordInterface
[ ] 3. Move other interfaces to ActiveRecord class
[ ] 4. Move implementation of the interfaces to traits
[ ] 5. Rename $attributes to $properties
[ ] 6. Move $properties with magic methods __get(), __set(), __isset(), __unset() to MagicPropertiesTrait and use it in ActiveRecord class
[ ] 7. Access to properties values inside AbstractActiveRecord via $this->$name only
[ ] 8. To get a relation query instance of ActiveQueryInterface use method with prefix get and suffix Query, e.g. getOrderQuery(): ActiveQueryInterface instead of getOrder(): ActiveQueryInterface
[ ] 9. To get a relation value use method with prefix get, e.g. getOrder(): ActiveRecordInterface|null
[ ] 10. Rename method getRelation(): ActiveQueryInterface to getRelationQuery(): ActiveQueryInterface
[ ] 11. Add method to get a value of relation getRelation(string $name): ActiveRecordInterface|null {return $this->related[$name] ?? null;}
[ ] 12. Implement RepositoryInterface and RepositoryTrait

Great ideas, especially with naming for relations. I have a question:
What's the reason to rename attributes to properties?

What's the reason to rename attributes to properties?

It was discussed that there is confusion between the attributes AR property and PHP's #[Attribute].
But it's a good question. Now this looks doubtful due to major changes and needs to be discussed again. Due to the renaming of public methods whose names contain attribute.

But it's a good question. Now this looks doubtful due to major changes and needs to be discussed again. Due to the renaming of public methods whose names contain attribute.

Are there any pitfalls here? Rename methods also it looks logically.

Are there any pitfalls here? Rename methods also it looks logically.

Now property name is already used in other methods
https://github.com/yiisoft/active-record/blob/090db08a3bb6833e0149bd9efd5aa521195270f7/src/BaseActiveRecordTrait.php#L275-L307
Currently attributes means column names in a table.
properties means properties of a class, wouldn't properties cause confusion similar to attributes.
fields is a more appropriate name, but it is also used for ArrayableInterface:
https://github.com/yiisoft/active-record/blob/090db08a3bb6833e0149bd9efd5aa521195270f7/src/BaseActiveRecord.php#L93-L108
If major changes involving method renaming are not a problem, then they should be separated into names and values:

attributes() -> names() or columnNames() - column names
hasAttribute() -> hasName() or hasColumnName() - if the column name exists
getAttributes() -> values() - values of a row
getAttribute() -> get() - get column value in a row
setAttribute() -> set() - set column value in a row

And we should avoid set and get prefixes when declaring method names in base AR classes. These prefixes will be used to access values of a row e.g. getName(), setName()


Does it necessary to run weight quantization reconstruction before full quantization reconstruction? Or it is independent?

If my target is to get a full quantization model, does it necessary to do weight quantization reconstruction before full quantization reconstruction as the shown?
Can I skip weight quantization reconstruction and turn on full quantization reconstruction directly!

In our code, weight quantization reconstruction is not performed before full quantization reconstruction. I think direct full quantization reconstruction is OK.


Subscriptions Not Populating :(

Am I just dumb or is there a step I am missing - I have followed the instructions to a tee but cannot seem to get products to show up in Supabase therefore the site as well. The only thing I just do is login users.
Someone, please help!

I had trouble with this, too. Make sure that your Stripe webhook is connected and that your server is running. Once both of those are setup, you need to have some sort of events on Stripe to trigger the webhook. For example, you could run Stripe fixture command to create the products on Stripe. Once the products are created, you should see that they've been created in your server's console.
Hopefully this helps, good luck!

@audrow Thanks Audrow - Still stumbling my way through it - its not working yet but I'm feeling confident I will get there soon

@audrow Thanks Audrow - Still stumbling my way through it - its not working yet but I'm feeling confident I will get there soon

Did you find a solution to this? I have the same problem. I can't get the products to populate.

@drakata no still not able to figure it out :(

@Nick-Achee Happy to pair program if you need some help.

@ACPK I will take you up on this ASAP when are you available?

Any solution identified as I am facing the same issue

Also interested in this :)

@Nick-Achee Send me an email<EMAIL_ADDRESS>
Got it Working. Had to delete the Stripe API keys and redo the process. Thanks

@Nick-Achee Send me an email<EMAIL_ADDRESS>
Got it Working. Had to delete the Stripe API keys and redo the process. Thanks

that seems like an ok solution while developing, but what happens in production when I want to add/update pricing plans? Having this issue as well.

@Nick-Achee Send me an email<EMAIL_ADDRESS>
Got it Working. Had to delete the Stripe API keys and redo the process. Thanks

You deleted them in Vercel and re-added them?

anyone get past this?
I'm triggering product.created from stripe CLI and getting this response from vercel
https://my-project/api/webhooks
An error occurred with your deployment
FUNCTION_INVOCATION_TIMEOUT

To get past this level I ended up at Supabase's SQL Editor, clicking on the SQL Snippet Stripe Subscription and running that.  After that, resubmit a webhook and it successfully populated the data.

Hi folks, I got the same problem, I cant see the products and I got the screen with No subscription pricing plans found.  How can I fix that?

same problem here :( anyone found a solution to this?

We're looking into this with the Supabase team!
cc @thorwebdev

Hey folks, we just ran through the README again and things worked successfully.
If you have suggestions for how to improve clarity in the README, please let us know 🙏

I just got this same error. Is this a bug or is it normal and need to be added in the readme?

Hi, I'm getting the same error. Stripe subscriptions are not populating. I've tried re-adding my public and secret keys but that has not helped.

FWIW I had this issue and the problem was I created the products/subscriptions before the webhook was set up so the events never got sent over to the database because they were triggered before the connection existed. Ideally the documentation could warn us to not create any products/subscriptions until it's complete.

Hey, thanks everyone, so far your suggestions have been helpful!
I am having an issue... products from Stripe are present in the database, the frontend somehow retrieves them but shows nothing:

RLS is activated and there is an active read only policy:

Hey, thanks everyone, so far your suggestions have been helpful!
I am having an issue... products from Stripe are present in the database, the frontend somehow retrieves them but shows nothing:

RLS is activated and there is an active read only policy:

I solved it. It seems like the template will not show products that don´t have 2 pricing plans, one monthly and one yearly. I updated my products and afterward they were showing up properly :)


v2.7.2

Pending

builder: watch for pages/ creation when default page displayed (#5753) (@Atinux) [TESTS]

Fixes

utils: handle serializeFunction edge case (#5754)
vue-app: reuse page component with watchQuery (#5757)
vue-app: remove trailing slash in vue-router non-strict mode (#5746)
vue-app: don't attach catch handler to already loaded component (#5751) (#5752)
vue-renderer: safe format ssr logs (#5764)

Refactors

small readability improvements (#5748)

Examples

typescript: add missing ts-node dependency (#5742)

Thanks to

Aaron Ransley (@aaronransley)
Jun (@utatti)
Rafał Chłodnicki (@rchl)

Codecov Report

Merging #5765 into 2.x will increase coverage by 0.07%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             2.x    #5765      +/-   ##
=========================================
+ Coverage   95.6%   95.67%   +0.07%
=========================================
  Files         82       82
  Lines       2662     2660       -2
  Branches     683      682       -1
=========================================
  Hits        2545     2545
+ Misses        98       97       -1
+ Partials      19       18       -1

Flag
Coverage Δ

#e2e
100% <ø> (?)

#fixtures
50.71% <50%> (?)

#unit
92.63% <50%> (?)

Impacted Files
Coverage Δ

packages/builder/src/context/template.js
100% <ø> (ø)
:arrow_up:

packages/utils/src/serialize.js
92.85% <ø> (ø)
:arrow_up:

packages/webpack/src/config/base.js
94.94% <ø> (ø)
:arrow_up:

packages/cli/src/commands/build.js
86.36% <0%> (ø)
:arrow_up:

packages/vue-renderer/src/renderers/ssr.js
95.91% <0%> (+3.76%)
:arrow_up:

packages/babel-preset-app/src/index.js
96.77% <100%> (ø)
:arrow_up:

packages/webpack/src/plugins/vue/client.js
95% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f609df...7084b3a. Read the comment docs.

Codecov Report

Merging #5765 into 2.x will increase coverage by 0.07%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             2.x    #5765      +/-   ##
=========================================
+ Coverage   95.6%   95.67%   +0.07%
=========================================
  Files         82       82
  Lines       2662     2660       -2
  Branches     683      682       -1
=========================================
  Hits        2545     2545
+ Misses        98       97       -1
+ Partials      19       18       -1

Flag
Coverage Δ

#e2e
100% <ø> (?)

#fixtures
50.71% <50%> (?)

#unit
92.63% <50%> (?)

Impacted Files
Coverage Δ

packages/builder/src/context/template.js
100% <ø> (ø)
:arrow_up:

packages/utils/src/serialize.js
92.85% <ø> (ø)
:arrow_up:

packages/webpack/src/config/base.js
94.94% <ø> (ø)
:arrow_up:

packages/cli/src/commands/build.js
86.36% <0%> (ø)
:arrow_up:

packages/vue-renderer/src/renderers/ssr.js
95.91% <0%> (+3.76%)
:arrow_up:

packages/babel-preset-app/src/index.js
96.77% <100%> (ø)
:arrow_up:

packages/webpack/src/plugins/vue/client.js
95% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f609df...7084b3a. Read the comment docs.


Github Issue #43: Return result from API call

Functionality request in #43 is already available in v1.0.0
This pull request is just an amendment to README.md with an example of how to use it

👍


Fix check for home departure being of wrong type

Related Issues
#715. Close #723.
Summary
Part of the mdata refactoring was incorrect when checking for home departure.

I confirmed it was fixed. Thank you.


Not compatible with AMDGPU

Similar to #2108 - since the old dependencies restrict the GPUCompiler to the old one which is out of maintenance, the AMDGPU failed to precompile.

And the developer from JuliaGPU said that it is not feasible to make a patch for the old GPUCompiler.


ActivatorModel(Manager): does not use deactivate_date / activate_date

activate_date and deactivate_date are not used by the manager.
activate_date is only initialized to the current time, if not provided in save.
Shouldn't these fields get used for filtering with the active and inactive manager methods?
Source: https://github.com/django-extensions/django-extensions/blob/master/django_extensions/db/models.py#L44
/cc @tehfink

+1

closing this for now


[stable/rocketchat] Bring it back to the present

What this PR does / why we need it: Install latest version of Rocketchat and mongodb. Switching to the latest MongoDB also makes sure PSP's are happy. Add securitycontext to pod to satisfy PSP further.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test

/assign davidkarlsen

/assign mattfarina

/lgtm
This is fine for now - as discussed on Slack.
Very nice if you can open a new PR which adds README and NOTES


fix: download_export was not checking the correct lockfile.

Explicitly set the name of the export file when checking status and creating locks
Add a TaskStatus class to avoid using strings as constants
Add Export.repr because logger isn't calling str, apparently

Hmm, this is raising this error:
data-registry/exporter/util.py", line 130, in lockfile
    if self.basename.endswith(".jsonl.gz"):
AttributeError: 'Export' object has no attribute 'basename'

Oh, because *components eats all the positional arguments, so I need to call it with the keyword basename=.

I made the fix.


Is there a way for us not to use setInterval() to read the data? Continuously reading from device without setInterval()

Similar To This
BluetoothSerial.withDelimiter('\r').then(() => {
Promise.all([
BluetoothSerial.isEnabled(),
BluetoothSerial.list(),
]).then(values => {
const [isEnabled, devices] = values;
...
});
BluetoothSerial.on('read', data => {
console.log(DATA FROM BLUETOOTH: ${data.data});
});
});

I don't understand the question. Is there a problem with the on read listener? It's been working for me and others that I'm aware of.
If you can't get it working I suggest reading the docs and looking at the sample app.
Or are you saying there's a bug with it?
If there is a bug you need to provide way more details on what and how to replicate.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Sunny Patel @.>
Sent: Wednesday, November 24, 2021 7:36:26 AM
To: kenjdavidson/react-native-bluetooth-classic @.>
Cc: Subscribed @.***>
Subject: [kenjdavidson/react-native-bluetooth-classic] Is there a way for us not to use setInterval() to read the data? Continuously reading from device without setInterval() (Issue #140)
Similar To This
BluetoothSerial.withDelimiter('\r').then(() => {
Promise.all([
BluetoothSerial.isEnabled(),
BluetoothSerial.list(),
]).then(values => {
const [isEnabled, devices] = values;
...
});
BluetoothSerial.on('read', data => {
console.log(DATA FROM BLUETOOTH: ${data.data});
});
});
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkenjdavidson%2Freact-native-bluetooth-classic%2Fissues%2F140&data=04|01||165222a6b46a47d1082308d9af470891|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637733541883673232|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=5%2ByZTPhwpAROq4rkVi8QpG9XzzVCWCM4dFDSgG0LCkI%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABPMJLYD3NTITQ6E72QXBO3UNTL4VANCNFSM5IV6YD7A&data=04|01||165222a6b46a47d1082308d9af470891|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637733541883683229|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=KF7sA6JyWo07yMuC5DtSj26Rde5RgHQf7y217lAHq14%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||165222a6b46a47d1082308d9af470891|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637733541883683229|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=S%2FJibKW4SD0FPuqLzObK8whoPHIf8nAc%2BXfJT3EwzUc%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||165222a6b46a47d1082308d9af470891|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637733541883693215|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=VU8M5mFfXs1GTUb%2FgSqrnN49JehpeWmhBxkqwLM1UAk%3D&reserved=0.

First of all, I am impressed with this library. Great work, great effort.. 🔥
I just want to know how to read continuous read from a Bluetooth classic device using this library.
Because I used setInterval() for continuous Reading.
Is there any better way to continuously read data from the device via Bluetooth?

Yes, it's in the doc:
https://kenjdavidson.com/react-native-bluetooth-classic/react-native/rn-bluetooth-device/#ondatareceived
And the sample application:
https://github.com/kenjdavidson/react-native-bluetooth-classic-apps/blob/1cba89aaa1181998dbcab7a9549a88a9bb5071a1/BluetoothClassicExample/src/connection/ConnectionScreen.js#L140

Also, thank you.

Now, I am getting continuous read and it is very fast. Thanks a lot.❤❤❤


Implement Whitelist on routes

twitter-server seems to accumulate metrics for non-existent routes. Some of these metrics seem to be related to correct routes (e.g. /ping_ and /ping), other seem to be pollution from other microservices (perhaps relate to NGINX proxying), and others are just routes to static assets.
To be able to sort out useful route metrics, a dashboard needs to be able to define the API surface area of the microservice, and use this as a whitelist for filtering useful metrics.

Whitelists are not going to really work given how unpredictable the contents of Finagle's metrics.json can be. A more sensible feature would be a user-configurable blacklist that is empty by default, but which persists to browser or backend storage.


TypeError: create_autogen_memgpt_agent() got an unexpected keyword argument 'persona_description'

Error "TypeError: create_autogen_memgpt_agent() got an unexpected keyword argument 'persona_description'" when launching the official memgpt google coollaboratory notebook : "memgpt_coder_autogen.ipynb"
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
[<ipython-input-7-396950d9e99f>](https://localhost:8080/#) in <cell line: 47>()
     55     # In our example, we swap this AutoGen agent with a MemGPT agent
     56     # This MemGPT agent will have all the benefits of MemGPT, ie persistent memory, etc.
---> 57     coder = create_autogen_memgpt_agent(
     58         "MemGPT_coder",
     59         persona_description="I am a 10x engineer, trained in Python. I was the first engineer at Uber (which I make sure to tell everyone I work with).",

TypeError: create_autogen_memgpt_agent() got an unexpected keyword argument 'persona_description'

I didn't edit the code in any way (except that I inserted my openal API key), but your notepad still didn't start :(

Same issue here. I think the arguments for create_autogen_memgpt_agent have changed completely. Are there any docs?
This is what I'm getting with the latest pip install:
create_autogen_memgpt_agent(agent_config, interface=None, interface_kwargs={}, persistence_manager=None, persistence_manager_kwargs=None, default_auto_reply: Union[str, Dict, NoneType] = '', is_termination_msg: Optional[Callable[[Dict], bool]] = None)
    See AutoGenInterface.__init__ for available options you can pass into
    `interface_kwargs`.  For example, MemGPT's inner monologue and functions are
    off by default so that they are not visible to the other agents. You can
    turn these on by passing in
    ```
    interface_kwargs={
        "debug": True,  # to see all MemGPT activity
        "show_inner_thoughts: True  # to print MemGPT inner thoughts "globally"
                                    # (visible to all AutoGen agents)
    }

Same issue here. I think the arguments for create_autogen_memgpt_agent have changed completely. Are there any docs?
This is what I'm getting with the latest pip install:
create_autogen_memgpt_agent(agent_config, interface=None, interface_kwargs={}, persistence_manager=None, persistence_manager_kwargs=None, default_auto_reply: Union[str, Dict, NoneType] = '', is_termination_msg: Optional[Callable[[Dict], bool]] = None)
    See AutoGenInterface.__init__ for available options you can pass into
    `interface_kwargs`.  For example, MemGPT's inner monologue and functions are
    off by default so that they are not visible to the other agents. You can
    turn these on by passing in
    ```
    interface_kwargs={
        "debug": True,  # to see all MemGPT activity
        "show_inner_thoughts: True  # to print MemGPT inner thoughts "globally"
                                    # (visible to all AutoGen agents)
    }

I think so. In 0.2.3, the definition of  create_autogen_memgpt_agent expects a name not a agent_config, but I have no idea how to pass the agent_config.

Can you share what version of MemGPT you are running? You can find it with memgpt version.

Can you share what version of MemGPT you are running? You can find it with memgpt version.

@sarahwooders 0.1.16 , but I have a new version now and the error is for sure

Should be patched in the latest version (0.2.5 coming out tonight, or try pip install pymemgpt-nightly): https://memgpt.readthedocs.io/en/latest/autogen/
Please reopen if this is still not working for you (or ping us on Discord #support)

@simonngai I'm passing the agent_config as follows:
from memgpt.config import AgentConfig
from dotenv import load_dotenv

load_dotenv()

agent_config = AgentConfig(
        "I am a 10x engineer, trained in Python. I was the first engineer at Uber which I make sure to tell everyone I work with).",
        f"You are participating in a group chat with a user ({user_proxy.name}) and a product manager ({pm.name}).",
        os.getenv("model"),
        name="MemGPT_coder"
    )

And also I need to set the following env on my dotenv file:
MEMGPT_CONFIG_PATH=MEMGPT_CONFIG
And then, finally, create a file called MEMGPT_CONFIG with the following values:
[openai]
key=sk-YOUROAIKEY

[model]
model_endpoint=https://api.openai.com/v1
model_endpoint_type=openai


React Native freezes UI when fetching response from API

Description
I'm facing a weird problem on old devices with react native apps. I realized that it happens with all the apps that I had developed with RN. Every time that I do a request to API the UI freezes until the request is responded. I have published 5 apps on Google Play store when the problem is the same. I don't know what to do. I need some help to solve it. Even the most recent version of RN (0.70.3) I'm getting this problem.
Just to let you know I'm using axios with redux saga and I tried to use just fetch API but the problem still the same.
Version
0.70.3
Output of npx react-native info
System:
OS: Windows 10 10.0.22000
CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-11390H @ 3.40GHz
Memory: 6.72 GB / 15.74 GB
Binaries:
Node: 16.17.1 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD
npm: 8.15.0 - C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels: 23, 28, 29, 30, 31, 32
Build Tools: 29.0.2, 30.0.2, 30.0.3, 31.0.0, 32.0.0
System Images: android-26 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: AI-213.7172.25.2113.9014738
Visual Studio: 17.3.32819.101 (Visual Studio Enterprise 2022)
Languages:
Java: <IP_ADDRESS> - C:\Program Files\Common Files\Oracle\Java\javapath\javac.EXE
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.3 => 0.70.3
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Nothing
Snack, code example, screenshot, or link to a repository
Nothing

I have the same issue on iOS application.
Output of npx react-native info:
System:
OS: macOS 12.6
CPU: (8) arm64 Apple M1 Pro
Memory: 114.89 MB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.18.0 - /opt/homebrew/opt/node@16/bin/node
Yarn: Not Found
npm: 8.19.2 - /opt/homebrew/opt/node@16/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK:
API Levels: 30, 31
Build Tools: 30.0.2, 30.0.3, 31.0.0
System Images: android-30 | Google APIs ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: Not Found
Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
Languages:
Java: <IP_ADDRESS> - /usr/bin/javac
npmPackages:
@react-native-community/cli: ^9.2.1 => 9.2.1
react: 18.1.0 => 18.1.0
react-native: 0.70.3 => 0.70.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Same problem

Same issue for me. Been trying to fix it with all sorts of async code, and any number of other fixes. No luck.

Same issue for me

Same Issue. Has anyone found any solution?

We managed to resolve the issue by using JavaScriptCore instead of Hermes (since react-native 0.70+ uses Hermes engine by default), see how to switch back to JSC here: https://reactnative.dev/docs/hermes#switching-back-to-javascriptcore

Also, this issue could be related to https://github.com/facebook/react-native/issues/32867

Can anyone from the Meta team help here?
We are facing the same issue with Hermes enabled
cc @cortinico @fortmarek @kelset

Can anyone from the Meta team help here?

Can we get a reproducer of some sort?

We are no longer having this issue in 0.71+

any solutions?

We are no longer having this issue in 0.71+

I'm on react-native 0.73 and it still freeze


Frankenstein Variorum Micro-Comparison Exercise

Look at the following combinations in the Frankenstein Variorum Viewer:

Version Thomas: Section 8: first full paragraph: Click on the two boxes highlighted and look at how the editions compare at each highlighted moment. Do you see any problems with what's being represented here?

Version 1831: Section 8: Scroll down to long dark-grey passage: "in a rather too philosophical and connected a strain..." Look at the passages following in the screen capture. Can you describe how the Frankenstein narrative was changing from the MS through the 1831 editions at this point?

Version 1818: Section 5: There are not many revisions here, so look across the entire section and study it. Can you describe how the Thomas copy would have altered this section, and how the 1831 edition altered it differently?

Version 1818: Section 7: This is where the Manuscript first begins, and also where there are lots of revisions in the last version, 1831. Take a look at this passage in the Variorum and click on the highlighted passages. Do you notice any problems or moments of interest in the way the comparison moments are represented here?

group 1 Nicky, Mia, Daniel, Anthony, Jalen
#1. for the highlighted section "misery, Elizabeth" if you replace it with the ms version the end of the edit becomes repetitive with the un altered lines. "Elizabeth had caught the scar  had caught the scarlet fever"
#2. In the 1831 version, the narrator was more passionate about explaining his youthful years, whereas the other four versions dont see it essential to describe.

I'm in group three with Natalya, Peter, and Kyara, and we studied section five of the 1818 edition of Frankenstein. We came to an agreement that this version was easy to read, as the setting was described in terms we understood while providing a clear picture.
The Thomas version made larger changes, but in small quantities. Most notably, an entire paragraph (pictured below) was rewritten and expanded upon the details in the story. Aside from this revision, the Thomas version was similar to other versions of the story.

The 1831 version made multiple small changes in the form of spelling, punctuation, and grammatical changes. The only exception was towards the end of the section, where two sentences were rewritten.

Howdy, I'm representing group #2.
We found it interesting that this entire paragraph of context and backstory was not including until the 1831 edition of Frankenstein. Up until this point, the prior sentence concluded with just the word "doctrine" (and even this was reportedly absent in the original edition). The word doctrine stayed from 1818 until it was replaced with the vast chunk of text highlighted gray in the excerpt.

Answering Question #4:
Some moments of interest our Breakout room found in the 1818 Edition in Section 7 was many of the common word choice was found to be similar with also the 1823 and the Thomas Editions of Frankenstein. The Mary Shelley version slightly differed in its own way and had similar word usage. What we found most interesting is the 1831 version was had highlighted passages that were very different from the other editions. In the first highlighted line, "Every one adored Elizabeth", was written in much greater detail in the 1831 Edition. A wapping paragraph talking about Elizabeth in detail, her character and role within the story was described. Rather than just addressing her normally in the other editions, the 1831 version brings her character to life.


Move old Toolbar releases to Dropbox downloads

Closes KSP-CKAN/NetKAN#4897

That's odd. Jenkins is having a spaz over 1.7.9, which isn't changed by this PR.

Looks good, merging

so lets say im retarted and have no clue what this post is talking about

The current release of Toolbar is on the author's server. As each new release comes out, the previous one is moved to a Dropbox folder. This change redirected CKAN to the Dropbox links for those earlier releases, so that people wanting to use older versions of KSP can still install the relevant version of Toolbar

well 3 days of screwing around with this. i give up. this is why i have never moded things

okay but i am having a lot more problems then the original post. every mod seems to error out

Can you open a new issue against the CKAN client and describe the errors you are getting in there?


termux

Format testenvs
fix to latest flake8 to run on termux

Codecov Report

Merging #5 into main will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         9    +3
  Lines          150       202   +52
  Branches        36        47   +11
=========================================
+ Hits           150       202   +52

Flag
Coverage Δ

#tests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/tox_ini_fmt/formatter/__init__.py
100.00% <100.00%> (ø)

src/tox_ini_fmt/formatter/requires.py
100.00% <100.00%> (ø)

src/tox_ini_fmt/formatter/test_env.py
100.00% <100.00%> (ø)

src/tox_ini_fmt/formatter/tox_section.py
100.00% <100.00%> (ø)

src/tox_ini_fmt/formatter/util.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec967a5...4005685. Read the comment docs.


Initial plugin suggestions

Thanks @graza-io for another great plugin! I took a look today and left some suggestions/questions below, please let me know if you have any questions on them.
Config file:

Can you please change baseurl to base_url to follow the standard snake casing?

Docs:

Is the brand color #FCA121 correct? It seems to be more orange, not sure if that was copy and paste from another plugin?
In keycloak_user.md, can you please break up the middle examples into individual examples, e.g., Get a specific user by ID, Get a specific user by username, Get a specific user by email? This allows users to copy and paste as the hub site has a copy icon per code block (in the top right of each code block).
Several table docs, like for keycloak_client and keycloak_group, are light on examples. Can you please add a few more so each table doc has at least 3-4 examples? These really help users get started and jump right into using your plugin.

General:

Is paging supported by the API, and if so does the SDK already handle this?I took a quick look around in the SDK and didn't spot anything.
Does the API support passing in a limit/max number of results? For APIs that we do, we usually recommend setting that to the passed in limit clause if given and if it's lower than the default paging size or limit, e.g., https://github.com/turbot/steampipe-plugin-tfe/blob/main/tfe/table_tfe_team.go#L48-L59, as this will help reduce the number of results returned (helpful especially for large APIs).

Tables:

I see a few TODOs around adding more optional key quals, like in the keycloak_user table. Are you planning on adding these before publishing the initial version?
Some tables seem like they don't have a lot of columns, like the keycloak_group and keycloak_user. Are there more columns we can add to both? For instance, for the keycloak_user table, in the SDK and API, it seems like there are more potential columns we can add based on what's returned by the API, but I don't see those in the table definition.
Possibly related to the item above, I did notice that in some tables you pass BriefRepresentation as true. Is there a reason these tables are only fetching this form of information? I only quickly read over the API docs, so I'm not very familiar with it yet, but for these tables, is it better to have the brief or full representations?

@cbruno10 thanks for this, it really helps get things in shape!
Config File:

I've addressed swapping baseurl for base_url.

Docs:

Have corrected the brand colour to #33C6E9
Examples in keycloak_user.md have been separated so that they'll be individual code blocks when published.
I have expanded table docs to include more examples.

General:

Paging is only supported in API/SDK on the get users endpoint - which I had implemented.
Have enhanced the above paging to use the limit to reduce pageSize and bow out when context is cancelled (manually/limit hit) or continue for all pages when not.

Tables:

The TODO comments were addressed in #13 I merely forgot to remove the comments.
This is by design for the initial implementation, when attempting to obtain fuller datasets on these tables I was hit by constant errors - I have these aside to investigate if these are caused by our instance(s) of Keycloak, the SDK or the API. However the most commonly needed data is returned and once we can iron out the kinks in the other data I intend to include this in a future release.

Thanks @graza-io ! The changes look great, from my perspective the plugin looks good to go.


Are NotRequired marking accurate?

Not sure if this a bug, or not, but want to understand it better.
So I tried to use aioboto3, in types package for aiobotocore for sqs I found the following types for the received message:
MessageTypeDef = TypedDict(
    "MessageTypeDef",
    {
        "MessageId": NotRequired[str],
        "ReceiptHandle": NotRequired[str],
        "MD5OfBody": NotRequired[str],
        "Body": NotRequired[str],
        "Attributes": NotRequired[Dict[MessageSystemAttributeNameType, str]],
        "MD5OfMessageAttributes": NotRequired[str],
        "MessageAttributes": NotRequired[Dict[str, MessageAttributeValueOutputTypeDef]],
    },
)

Now my attention was grabbed because mypy wasn't showing an error with when I used message["ReceiptHandle"] but pyright did, I first thought pyright was wrong, but when I found the type above, it looks like it is right. So my question is, is this correct?
The documentation implies that this is always set: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sqs/client/receive_message.html#receive-message you also need the handle to signal that it was received. Similarly with Body I would imagine it is always present as well.

Hello! A proper totality check is still not implemented in mypy: https://github.com/python/mypy/issues/12094
There is a workaround with MyTypedDict = Union[MyTypedDictRequiredOnly, MyTypedDictOptionalOnly], but it is not reliable. I think it should ve fixed on mypy side.

I see, but is "ReceiptHandle": NotRequired[str], or "Body": NotRequired[str], actually correct? I would expect them to be always present.

Yes. Unfortunately, ther eis no real way to tell if some field is always present, I can only rely on botocore shapes. THese fields are not marked as required in Message shape.

You can use this one: https://youtype.github.io/boto3_stubs_docs/mypy_boto3_sqs/type_defs/#sendmessageresulttypedef

I'm referring to this. According to https://youtype.github.io/boto3_stubs_docs/mypy_boto3_sqs/type_defs/#messagetypedef, AWS could just respond with [{}] (empty dictionary) and that would be a valid response?
Surely Body and ReceipientHandle need always to be present as I don't know what the correct behavior would be if they are not.

I will take a look. Could be  a huge fix :)
ReceiveMessageResultTypeDef = TypedDict(
    "ReceiveMessageResultTypeDef",
    {
        "Messages": List[MessageTypeDef],
        "ResponseMetadata": ResponseMetadataTypeDef,
    },
)

As you see, MessageTypeDef is not total, however probably it should be.


0.3.0 Pre release fixes

These are fixes allowing the diffraction library/app to work as before the dict2xml -> XMLSerializer update.

added/reinstated the "id" field update for the serializer
added missing arguments to one instance of convert_to_dict
added an optional dict updater for derived classes. This used to be possible and enabled derived classes (like Background) to add custom dict keys)
removed dependence on lazy-import, since the module can't be packaged with pyinstaller.

@wardsimon I think merging this into pre-release might fix some of the problems that I am seeing...

@wardsimon can you please review the changes and merge if ready?


Space added into url() after SCSS beautified

Description
@import url(//...) when beautified inserts an extra space after the open paren @import url( //...) thus generating invalid scss.
Input
The code looked like this before beautification:
@import url(//example.com/style.css);

Expected Output
The code should have looked like this after beautification:
// No change
@import url(//example.com/style.css);

Actual Output
The  code actually looked like this after beautification:
// Extra space added
//          ↓
@import url( //example.com/style.css);

Steps to Reproduce
Paste the above code into http://jsbeautifier.org/ and beautify
Environment
OS: macOS
Settings
Example:
{
  "indent_size": "2",
  "indent_char": " ",
  "max_preserve_newlines": "5",
  "preserve_newlines": true,
  "keep_array_indentation": false,
  "break_chained_methods": false,
  "indent_scripts": "normal",
  "brace_style": "collapse",
  "space_before_conditional": true,
  "unescape_strings": false,
  "jslint_happy": false,
  "end_with_newline": true,
  "wrap_line_length": "0",
  "indent_inner_html": false,
  "comma_first": false,
  "e4x": false
}

// is a comment in SCSS.
http://sass-lang.com/documentation/file.SCSS_FOR_SASS_USERS.html#Comments
The space is added in  front of a comment.
I think you need to put quotes around that to make it work.

Ah you're right, sorry for the false alarm.


Test Case 9_9

What could be the possible issue for this? For my waitEvent and serveEvent's toString method, I included and if-else as well which will return a "...serves by self-check..." if it is a self-check counter but it does not seem to be reflected in the output

hi! i faced a similar problem, but i am not sure if your implementation is the same as mine.
for me, my SCC was a subclass of server. so every time i update my server queue or available time, i had to create a new Server/SCC. however i had forgotten to create a new SCC when i updated SCC, instead creating a new Server instead so my toString() did not reflect "self-check .."

hi :) if ur SelfCheck extends Server, then SelfCheck should override any functions in Server if the function creates a new instance of Server. This ensures that when SelfCheck is instantiated, its declared as SelfCheck specifically and the toString method of SelfCheck is invoked instead of Server. hope this helps!

hi! had similar issues at the start. what i realised was in 1 of my methods, i created server instead of self check out when its supposed to be self check out!
i solved the issue by making server an abstract class and having a HumanServer and SelfServer class that extends it then override the methods that create new instances of server! hope that helps :)

hii! similar to @yishao17, I also faced this problem before as I created server instead of SCCs, so maybe you would want to check on that!!

Thanks for the help!


add block usage logs to system pallet

not sure if a good idea, I needed them for some testing, and figured it might be good to have around. The code block is a bit ugly though.

2022-03-02 22:27:48.001 DEBUG tokio-runtime-worker runtime::system: [11] length: 11 (normal Percent(0), op: Percent(0), mandatory Percent(0)) / normal weight: 0 (Percent(0)) / op weight 0 (Percent(0)) / mandatory weight<PHONE_NUMBER> (Percent(0))

Of course, this is a rather lame example.

2022-03-02 22:27:48.001 DEBUG tokio-runtime-worker runtime::system: [11] length: 11 (normal Percent(0), op: Percent(0), mandatory Percent(0)) / normal weight: 0 (Percent(0)) / op weight 0 (Percent(0)) / mandatory weight<PHONE_NUMBER> (Percent(0))

Quite hard to read? :see_no_evil:

2022-03-02 22:27:48.001 DEBUG tokio-runtime-worker runtime::system: [11] length: 11 (normal Percent(0), op: Percent(0), mandatory Percent(0)) / normal weight: 0 (Percent(0)) / op weight 0 (Percent(0)) / mandatory weight<PHONE_NUMBER> (Percent(0))

Quite hard to read? 🙈

I can maybe show less information, but I think this is fine. I mean, it is a debug log at the end of the day, not meant to be pretty to read :P

Wow that is a lot of code for one print! Maybe need to start putting it it's own func. Could you post another output of how it looks like now?

Wow that is a lot of code for one print! Maybe need to start putting it it's own func. Could you post another output of how it looks like now?

Good idea!

I changed it to something like this:
2022-03-04 21:19:12.004 DEBUG tokio-runtime-worker runtime::system: [922] length: 11 (normal 0%, op: 0%, mandatory 0%) / normal weight: 0 (0%) / op weight 0 (0%) / mandatory weight<PHONE_NUMBER> (0%)

bot merge


Fail to collect metrics for big workloads

From the logs of a user with ~50GB of data:
2016-11-23T01:21:23Z ERROR Error Fetching Metrics:gorethink: Grouped data over size limit `100000`.  Try putting a reduction (like `.reduce` or `.count`) on the end. in:
r.Object("Repos", r.DB("pachyderm_pfs").Table("Repos").Count(), "Commits", r.DB("pachyderm_pfs").Table("Commits").Count(), "ArchivedCommits", r.DB("pachyderm_pfs").Table("Commits").Filter({Archived=true}).Count(), "CancelledCommits", r.DB("pachyderm_pfs").Table("Commits").Filter({Cancelled=true}).Count(), "Files", r.DB("pachyderm_pfs").Table("Diffs").Group("Path").Ungroup().Count(), "Jobs", r.DB("pachyderm_pps").Table("JobInfos").Count(), "Pipelines", r.DB("pachyderm_pps").Table("PipelineInfos").Count())

The culprit seems to be this line: https://github.com/pachyderm/pachyderm/blob/master/src/server/pkg/metrics/metrics.go#L149
Although the lines that use Filter have huge performance implications as well, since using Filter without using secondary indexes requires a full table scan.
I think we should:

Remove/rewrite queries that don't scale well (e.g. GroupBy, Filter).  For instance, is the number of unique paths necessarily a more interesting metrics than simply the number of diffs (i.e. Table("Diffs").Count())?  Personally I'd actually be more interested in the latter.
Make metrics collection interval longer.  The current value is 15 secs.  Do we need to collect metrics that frequently?

I'm happy to make the interval longer.
And I agree -- we don't want to adversely effect memory, esp since that will be a bottleneck for other reasons.
But - the point of metrics is to learn what the state of the system is at scale. So specifically for big workloads, I want as much information as I can to understand how the system is being used and is creaking.
I also think that understanding file counts and diff counts could be valuable. It may be interesting to see that ratio and how that ratio differs across users' clusters.
For now, if this solves an issue, I'm ok w the fix. But please open a new issue to add these metrics back in a more efficient manner.

^this comment above was meant for #1104


Add some sort of spawn protection

When leaving/entering CMs. Make it configurable.

any updates on this enhancement?

Currently working on a 1.10.2 version, the 1.7.10 version is not being maintained anymore, sorry.
Closing all issues not relevant for the new version.


add alluxio support

add spark.rapids.alluxio.pathsToReplace to specify how to replace file paths
to alluxio schema, then leverage the power of alluxio's data archestration to
accelerate file reading.

I am a little confused why we need this at all.  Can't the user just replace the paths on their own after they set up Alluxio? Are there plans to auto-deploy Alluxio with the plugin and make it transparent to the end user? Wouldn't letting the user change things on their own that make it better for them because then they can test that it is doing the right thing everywhere, even when not using the accelerator and adjust to how the files paths may have changed? Also is it expected that we only replace paths automatically for read nodes moved to the GPU?

I am a little confused why we need this at all.  Can't the user just replace the paths on their own after they set up Alluxio? Are there plans to auto-deploy Alluxio with the plugin and make it transparent to the end user? Wouldn't letting the user change things on their own that make it better for them because then they can test that it is doing the right thing everywhere, even when not using the accelerator and adjust to how the files paths may have changed? Also is it expected that we only replace paths automatically for read nodes moved to the GPU?

yes the user can change their paths, this is to allow them to not have to change their paths and it happen transparently.  Yes it only works when using the GPU readers

yes the user can change their paths, this is to allow them to not have to change their paths and it happen transparently.  Yes it only works when using the GPU readers

@wbo4958  you need to signoff on a commit -> see https://github.com/NVIDIA/spark-rapids/blob/branch-0.4/CONTRIBUTING.md#sign-your-work

@wbo4958  you need to signoff on a commit -> see https://github.com/NVIDIA/spark-rapids/blob/branch-0.4/CONTRIBUTING.md#sign-your-work

build

build

Please don't rebase or force push when in the middle of a review unless absolutely necessary. Its much harder for the reviewed see what you changed between revisions

Please don't rebase or force push when in the middle of a review unless absolutely necessary. Its much harder for the reviewed see what you changed between revisions

build

build

YOu need to fix the scala style violation:
18:29:06  error file=/home/jenkins/agent/workspace/jenkins-rapids_premerge-github-830/shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/Spark300Shims.scala message=There should be no empty line separating imports in the same group. line=24 column=0

YOu need to fix the scala style violation:
18:29:06  error file=/home/jenkins/agent/workspace/jenkins-rapids_premerge-github-830/shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/Spark300Shims.scala message=There should be no empty line separating imports in the same group. line=24 column=0

YOu need to fix the scala style violation:
18:29:06 error file=/home/jenkins/agent/workspace/jenkins-rapids_premerge-github-830/shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/Spark300Shims.scala message=There should be no empty line separating imports in the same group. line=24 column=0

Thx for this info, I will fix it.

YOu need to fix the scala style violation:
18:29:06 error file=/home/jenkins/agent/workspace/jenkins-rapids_premerge-github-830/shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/Spark300Shims.scala message=There should be no empty line separating imports in the same group. line=24 column=0

Thx for this info, I will fix it.

build

build

build

build


Validation error when creating nested lists

Sometimes, when I create nested lists like this one:

I get validation errors like this one:

Related: I think the app sometimes fails to properly create the entire set of nested pointers. I just had a case where I referred to a large list using $1 in the answer, but the next time I got back to the workspace, the pointer in the answer had turned to n/a and the outer-most [ ] in the scratchpad hadn't been turned into an export and instead remained as plain-text square brackets.

Was able to duplicate validation error:
Here is Postgres tells us is going on:
ERROR:  duplicate key value violates unique constraint "Pointers_pkey"
DETAIL:  Key (id)=(87f69da0-d880-11e8-89a3-f3e3e73d8d6e) already exists.
STATEMENT:  INSERT INTO "Pointers" ("id","createdAtEventId","updatedAtEventId","createdAt","updatedAt","sourceBlockId") VALUES ('87f69da0-d880-11e8-89a3-f3e3e73d8d6e',168,168,'2018-10-25 18:05:18.806 +00:00','2018-10-25 18:05:18.806 +00:00','837b0ff4-53d3-486d-90fa-e3f1c2203d79') RETURNING *;

I'm 99% sure this is a race condition caused by the following: When a block is updated, there is a "after save" callback that ensures that all of the block's pointers are in the database. If some pointers aren't yet in the database (i.e., they're new), then they are created. When creating so many pointers in such short succession, with each act of pointer creation instigating a block update, there's a chance things get out of order and that the pointer actually get created in between (1) looking to see whether a pointer exists and (2) creating the pointer.
This shouldn't cause any larger problem though, because it just means the pointer isn't created twice (which is what we want).

Ok so on the current preview branch (v0.3) this is resolved by not having the editor save to the database after every pointer creation. Now, saves occur only after the autosave interval, or when the editor unmounts.


New monitor: MessagingTester. Plus build process enhancements.

New Monitor:

MessagingTester.
A monitor that does 'synthetic monitoring' by periodically sending and receiving messages to test the broker and surrounding infrastructure more holistically.

Enhancements:

Ant build task now creates a Jar per custom monitor, providing more flexibility to selectively deploy and upgrade.
New ant build tasks to separate out building of 'advanced' monitors that need additional libraries, versus the previous monitors that dont.
Removed the lib directory from the repo as it was not mandatory and creating issues to download the repository in certain corporate environments. The necessary libs were already available through other means.

Updates:

Included additional sample image of the search capabilities possible from the MessageRates monitor.

Will re-open after fixing merge conflicts


OS X dylibs have the wrong dylib names after installation, sometimes the wrong name

When building VisIt on OS X against QT previously installed elsewhere,the names inside many of the plugins end up incorrect, like: executable_pathexecutable_path/../lib/QtGui.framework/Versions/4/QtGui executable_pathexecutable_path/../lib/QtOpenGL.framework/Versions/4/QtOpenGL executable_pathexecutable_path/../lib/QtCore.framework/Versions/4/QtCore, in /volatile/visitr12128ser/2.1.0/darwin-i386/plugins/plots/libVWellBorePlot.dylib. Attached is a file that shows all of the corrections that have to be madeon the installed dylibs. I suspect some overzealous script in VisIt is doing this, but I don'tknow where.
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 334
Status: Resolved
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: OS X dylibs have the wrong dylib names after installation, sometimes the wrong name
Assigned to: Brad Whitlock
Category: -
Target version: 2.1
Author: John Cary
Start: 08/05/2010
Due date:
% Done: 0%
Estimated time:
Created: 08/05/2010 02:12 pm
Updated: 08/31/2010 03:20 pm
Likelihood: 5 - Always
Severity: 3 - Major Irritation
Found in version: trunk
Impact:
Expected Use:
OS: OSX
Support Group: Any
Description:
When building VisIt on OS X against QT previously installed elsewhere,the names inside many of the plugins end up incorrect, like: executable_pathexecutable_path/../lib/QtGui.framework/Versions/4/QtGui executable_pathexecutable_path/../lib/QtOpenGL.framework/Versions/4/QtOpenGL executable_pathexecutable_path/../lib/QtCore.framework/Versions/4/QtCore, in /volatile/visitr12128ser/2.1.0/darwin-i386/plugins/plots/libVWellBorePlot.dylib. Attached is a file that shows all of the corrections that have to be madeon the installed dylibs. I suspect some overzealous script in VisIt is doing this, but I don'tknow where.
Comments:
I changed the osxfixup script so its regular expressions only match paths at the start of a string. This allows it to replace /path/to/lib/libfoo.dylib with a relative path while not changing @executable_path/../lib/libfoo.dylib.

0347_installfix.out.zip


Unreachable Code

Was stepping through a debugger and noticed that this was all unreachable code. It can be safely removed or if is something we actually want to keep should be relocated.
https://github.com/terrapower/armi/blob/5912372a9c037f8b6caf52749ebe6dc28c06b873/armi/reactor/blocks.py#L1968-L1974

@john-science @jakehader

What a strange piece of code! Not even sure that method really should be on a block... Looks like a helper function if anything. Is this called on block initialization?

Yeah, I'm in favor of just deleting this block of code.

It was probably just a simple indentation error. Is it possible that we actually wanted that error check, and it just needed to be bumped out one level of indentation?


Add Beta-VAE implementation

This should include all the models and losses from the paper, with some docs / notes giving a demo

This now belongs in variational


Atmos sign

Atmos sign
changelog
-atmos sign

(atmo sign)

I think the license you are listing is incorrect. It looks like it's duel licensed under GPL3, and AGPL3. I think GPL3 is the less restrictive of the two, so you could list that as the license.
For the links, the Beestation github looks like the more official source, so just a link to that commit should work.
https://github.com/discordia-space/CEV-Eris/tree/4e0bbe682d0a00192d24708fdb7031008aa03f18
https://github.com/BeeStation/BeeStation-Hornet/tree/13dd5ac712385642574138f6d7b30eea7c2fab9c
I'm not a lawyer, so I might be wrong, but best effort.

bee is a tg downstream which uses CC for its licenses
"All assets including icons and sound are under a Creative Commons 3.0 BY-SA license unless otherwise indicated." in their readme

Then the link should be to wherever that is

it is, thats in the beestation readme

im confused as to what i need to change here

nothing, your meta is fine

Yeah, don't worry about it.


Don't log messages to the console that the user or developer can do nothing about

We're developing an app that uses pdf.js - we use the browser console extensively during development but don't log anything to it (unless absolutely necessary) in production. We deal with millions of PDFs from different sources, often converted poorly or corrupted before we get them.
pdf.js is excellent, but logs warnings and errors to the console that the developer or end user can do nothing about.
For instance #3768 - a bad font recovery message. That's useful information, but not to the end user viewing the PDF or the application developer.
Other warnings are useful but with an unhelpful and persistent message, for instance #10377 if you await page.render(... you get told that then syntax is deprecated. The fix (to await page.render(...).promise) and related documentation to it should be indicated, and if the deprecated method is still called in production then end users don't need to know about it.
What is the expected behaviour?
In the production build:

Issues handled internally should not be logged to the console.
Information about using the API can be logged to the console but

should be written for an external developer with links to documentation.
can be turned off in production environments or alternate development contexts.

Issues that some end users in some contexts could act on (for instant a bad font message telling a PDF author to change the PDF) need to be some kind of event, observer, subscription or callback, as there's no way to promote the console log messages to actual UI.

[...] but logs warnings and errors to the console that the developer or end user can do nothing about.

I suppose that it depends on what sort of "developer" we're talking about here, since I can assure you that from the PDF.js-contributor perspective many of the console messages are most helpful.
As for the end-user part, console messages are definitely not useless there either since they often allow users to provide additional and useful information when reporting bugs.

[...] and if the deprecated method is still called in production then end users don't need to know about it.

It's, generally speaking, the responsibility of the person actually utilizing the PDF.js library to ensure that their code is using correct and current APIs, and otherwise update their own code such that deprecated messages aren't seen by end-users.
In particular, you probably don't want to deploy a new PDF.js release without testing it yourself first.

Issues handled internally should not be logged to the console.

The amount of logging printed in the console can be easily controlled by the API user when calling getDocument, please see
https://github.com/mozilla/pdf.js/blob/72bd8e8bdb96791bd66a961c428c9edfffd11a71/src/display/api.js#L152-L153 and the currently available values in https://github.com/mozilla/pdf.js/blob/72bd8e8bdb96791bd66a961c428c9edfffd11a71/src/shared/util.js#L182-L186
For example, calling getDocument in the following way will only print actual error messages:
const loadingTask = getDocument({
  url,
  verbosity: 0,
});

Information about using the API can be logged to the console but
should be written for an external developer with links to documentation.

This is an open source project, with most people contributing in their spare time. Please understand that writing good documentation can be both time-consuming and non-trivial, so if the documentation is lacking please consider contributing to it :-)

can be turned off in production environments or alternate development contexts.

It's not clear what you mean by "production environments" here, but if you're e.g. referring to the pre-built pdf.js/pdf.worker.js files that's distributed here and here then those need to have API warnings printed by default since otherwise the implementer wouldn't get notified about e.g. deprecated APIs.

[...] need to be some kind of event, observer, subscription or callback, as there's no way to promote the console log messages to actual UI.

There already is such a thing[1], for unsupported features, please see https://github.com/mozilla/pdf.js/blob/72bd8e8bdb96791bd66a961c428c9edfffd11a71/src/display/api.js#L463-L467
For an example of how this can be used, please see the default viewer code here and here.

[1] This is e.g. being used to display a notification bar, for feature which aren't supported, in the built-in Firefox PDF Viewer.

Closing as answered; I also agree with everything said above.


Exit from this project and the whole organization

Hello everybody, during today's deep discussion on ToolDelta QQ group, now I understood my ability to write codes was so poor and how stupid I was.

I know you guys here want to console me, but you could see that I only has a little contributions here......
Yeah, I have never think about how to improve this project. For me, I just to say I have no time to write codes, so I need to wait, once and once again.
I'm sorry.
Thank you for taking in a lonely man like me. I'm sorry I can't repay you for your salvation.
Let me go, to allow me to leave here, then the world will have no trouble, and anything will be more beautiful.
6th Apr, 2024

在跟某人深入沟通后，请允许我取消这一决定。
或许并不是只有我感到悲伤，但至少，请允许我陪所有人一起走下去。


runner: Add Emulate xcopy support

This adds emulate xcopy support in tcmur and then enable it.
Tested Evironment:  ESXI 5.5
Backstore: file_example

Update with some code style fixing.

Just FYI, I am reviewing this one now.
Is this all vmware needs btw or is it a base implementation? What versions of ESX?

Yes, all are must for vmware.

Update with removing one space line.

@mikechristie @liuy
For the enhancement mentioned by @liuy, I have implemented locally, but it become much more complex, and need some days to do the test, and also the unmap command patches will depended on this seires. To make this more easy to review, If you both agree I will create one another pull request for this after this.
For this I have test base on ESXI 5.5 using VM(larger size) clone, and the cloned VM could work well.
Thanks,

@mikechristie The patches have been updated and addressed problem you mentioned.
@liuy
Please review.

The following is some of debug logs:
....
9339 2017-05-12 17:09:51.300 3514 [DEBUG] xcopy_locate_udev:592 : Located tcmu devivce: uio1
9340 2017-05-12 17:09:51.300 3514 [DEBUG] xcopy_parse_target_descs:753 : Source device NAA IEEE WWN: 0x  0x7f81440089e8hN
9341 2017-05-12 17:09:51.300 3514 [DEBUG] xcopy_parse_target_descs:754 : Destination device NAA IEEE WWN: 0x  0x7f8144008a00hN
9342 2017-05-12 17:09:51.300 3514 [DEBUG] xcopy_work_fn:945 : Source lba: 21911552 Number of lba:: 4096, Destination lba: 21911552
9343 2017-05-12 17:09:51.316 3514 [DEBUG] xcopy_parse_parameter_list:856 : Processing XCOPY with tdll: 64 sdll: 28 inline_dl: 0
9344 2017-05-12 17:09:51.317 3514 [DEBUG] xcopy_parse_segment_descs:510 : Segment descriptor: stdi: 0 dtdi: 1
9345 2017-05-12 17:09:51.317 3514 [DEBUG] xcopy_parse_segment_descs:516 : Segment descriptor: lba_cnt: 2048 src_lba: 25569280 dst_lba: 25569280
9346 2017-05-12 17:09:51.317 3514 [DEBUG] xcopy_locate_udev:592 : Located tcmu devivce: uio1
9347 2017-05-12 17:09:51.317 3514 [DEBUG] xcopy_parse_target_descs:753 : Source device NAA IEEE WWN: 0x  0x7f81440089e8hN
9348 2017-05-12 17:09:51.317 3514 [DEBUG] xcopy_parse_target_descs:754 : Destination device NAA IEEE WWN: 0x  0x7f8144008a00hN
9349 2017-05-12 17:09:51.317 3514 [DEBUG] xcopy_work_fn:945 : Source lba: 25569280 Number of lba:: 2048, Destination lba: 25569280
9350 2017-05-12 17:09:51.343 3514 [DEBUG] xcopy_parse_parameter_list:856 : Processing XCOPY with tdll: 64 sdll: 28 inline_dl: 0
9351 2017-05-12 17:09:51.343 3514 [DEBUG] xcopy_parse_segment_descs:510 : Segment descriptor: stdi: 0 dtdi: 1
9352 2017-05-12 17:09:51.343 3514 [DEBUG] xcopy_parse_segment_descs:516 : Segment descriptor: lba_cnt: 2048 src_lba: 25831424 dst_lba: 25831424
9353 2017-05-12 17:09:51.343 3514 [DEBUG] xcopy_locate_udev:592 : Located tcmu devivce: uio1
9354 2017-05-12 17:09:51.343 3514 [DEBUG] xcopy_parse_target_descs:753 : Source device NAA IEEE WWN: 0x  0x7f81440089e8hN
9355 2017-05-12 17:09:51.343 3514 [DEBUG] xcopy_parse_target_descs:754 : Destination device NAA IEEE WWN: 0x  0x7f8144008a00hN
9356 2017-05-12 17:09:51.344 3514 [DEBUG] xcopy_work_fn:945 : Source lba: 25831424 Number of lba:: 2048, Destination lba: 25831424
9357 2017-05-12 17:09:51.365 3514 [DEBUG] xcopy_parse_parameter_list:856 : Processing XCOPY with tdll: 64 sdll: 28 inline_dl: 0
9358 2017-05-12 17:09:51.365 3514 [DEBUG] xcopy_parse_segment_descs:510 : Segment descriptor: stdi: 0 dtdi: 1
9359 2017-05-12 17:09:51.365 3514 [DEBUG] xcopy_parse_segment_descs:516 : Segment descriptor: lba_cnt: 2048 src_lba: 26968064 dst_lba: 26968064
9360 2017-05-12 17:09:51.365 3514 [DEBUG] xcopy_locate_udev:592 : Located tcmu devivce: uio1
9361 2017-05-12 17:09:51.365 3514 [DEBUG] xcopy_parse_target_descs:753 : Source device NAA IEEE WWN: 0x  0x7f81440089e8hN
9362 2017-05-12 17:09:51.365 3514 [DEBUG] xcopy_parse_target_descs:754 : Destination device NAA IEEE WWN: 0x  0x7f8144008a00hN
9363 2017-05-12 17:09:51.365 3514 [DEBUG] xcopy_work_fn:945 : Source lba: 26968064 Number of lba:: 2048, Destination lba: 26968064
9364 2017-05-12 17:09:51.384 3514 [DEBUG] xcopy_parse_parameter_list:856 : Processing XCOPY with tdll: 64 sdll: 28 inline_dl: 0
9365 2017-05-12 17:09:51.384 3514 [DEBUG] xcopy_parse_segment_descs:510 : Segment descriptor: stdi: 0 dtdi: 1
9366 2017-05-12 17:09:51.384 3514 [DEBUG] xcopy_parse_segment_descs:516 : Segment descriptor: lba_cnt: 2048 src_lba: 27054080 dst_lba: 27054080
9367 2017-05-12 17:09:51.384 3514 [DEBUG] xcopy_locate_udev:592 : Located tcmu devivce: uio1
9368 2017-05-12 17:09:51.384 3514 [DEBUG] xcopy_parse_target_descs:753 : Source device NAA IEEE WWN: 0x  0x7f81440089e8hN
9369 2017-05-12 17:09:51.384 3514 [DEBUG] xcopy_parse_target_descs:754 : Destination device NAA IEEE WWN: 0x  0x7f8144008a00hN
9370 2017-05-12 17:09:51.384 3514 [DEBUG] xcopy_work_fn:945 : Source lba: 27054080 Number of lba:: 2048, Destination lba: 27054080
9371 2017-05-12 17:09:51.437 3514 [DEBUG] write_same_16_work_fn:177 : Start lba: 27056128 Number of lba:: 2048, end lba: 27058176
...

I have dumped the write_same_16 commands Data-Out buffer data, together with the XCOPY it will write all zeros to the dst device when cloning the VM-->VM1.

Test this using sg3_utils:
The command:
[root@localhost ~] # sg_xcopy if=/dev/sdb of=/dev/sdc count=4096
sg_xcopy: 4096 blocks, 2048 commands
The logs:
[DEBUG] xcopy_parse_parameter_list:735 hislun: Processing XCOPY with tdll: 64 sdll: 28 inline_dl: 0
[DEBUG] xcopy_parse_segment_descs:385 : Segment descriptor: stdi: 0 dtdi: 1
[DEBUG] xcopy_parse_segment_descs:391 : Segment descriptor: lba_cnt: 2 src_lba: 4094 dst_lba: 4094
[DEBUG] xcopy_locate_udev:467 mylun: Located tcmu devivce: uio2
[DEBUG] xcopy_parse_target_descs:629 hislun: Source device NAA IEEE WWN: 0x  0x7f4ae0000a10hN
[DEBUG] xcopy_parse_target_descs:631 mylun: Destination device NAA IEEE WWN: 0x  0x7f4ae0000a28hN
[DEBUG] xcopy_work_fn:824 hislun: Source lba: 4094 Number of lba:: 2, Destination lba: 4094

For the enhancement mentioned by @liuy, I have implemented locally, but it become much more complex, and need some days to do the test, and also the unmap command patches will depended on this seires. To make this more easy to review, If you both agree I will create one another pull request for this after this.

Fix async read & write problem by later incremental patches looks okay to me if your life get easier :)

I found in the enhancement patch, the code almost will double the current one.
Need much more test.

This is for ESXI 5.5, all VAAI Block Primitves are emulated and the backstore is file
~ # esxcli storage core device vaai status get -d naa.600140512f314dd6e5c4558ac057655b
naa.600140512f314dd6e5c4558ac057655b
VAAI Plugin Name:
ATS Status: supported
Clone Status: supported
Zero Status: supported
Delete Status: supported
~ #

@mikechristie Have addressed all the issues mentioned.

Thanks lxbsz!


Add the content of Cleanup section into the ```shell code block snippet.

This is a Feature Request
What would you like to be added
Add the commands which are under the Clean up section of the Apply Pod Security Standards at the Cluster Level and Apply Pod Security Standards at the Namespace Level tutorials into the shell code block snippet. Currently, it is under the triple backticks (```) as shown in the following screenshot:

Which is not look more prominent.
Why is this needed
It provides a better structure to the Clean up section. and then it will be highlighted on the page.
Comments
None

/sig docs
/language en

/assign

Fixed it here: #39065

I'm not sure I agree with the issue description. I was nevertheless happy to merge the actual PR.

thank you, @sftim


Filtering based on attribute value

I read #8 but I have following scenario, will it be possible to define policy
Resource: Book
Attribute: Publisher
Role: Student
How to define policy for:

Allow access if Publisher is XYZ
Deny access if Publisher is ABC

Does accesscontrol support filtering based on attribute value?

Not in that sense, no.
The principle should be to avoid access-control by a specific record/value but a resource.
Otherwise you would need to change/update policy every time you add a new publisher.
So, this is a design issue rather than how AC handles it.
In your case, I'd define two resources: BookGroup1, BookGroup2
(In your backend, you'd still fetch these resources by filtering by their publishers.)
// grants for students
ac.grant('Student').readAny('BookGroup1');
// grants for teachers
ac.grant('Teacher').extend('Student').readAny('BookGroup2');

// check student permissions
ac.can('Student').readAny('BooksGroup1').granted   // —> true
ac.can('Student').readAny('BooksGroup2').granted   // —> false

// check teacher permissions
ac.can('Teacher').readAny('BooksGroup1').granted   // —> true
ac.can('Teacher').readAny('BooksGroup2').granted   // —> true

Also see this F.A.Q.


Support RELEASES.md changelog files

They're not as common as some of the others we support, but there are still plenty out there.
Related:

https://github.com/actions/toolkit/pull/143
https://github.com/actions/toolkit/issues/104

Dependabot ought to be picking those up already, since release is already in that list and we look for filenames that include the strings in the list, not that exactly match one.

Nice 👌


Can't control layer position of LocationLayerPlugin

Having a lot of Symbols and LineStrings on my map, I am not able to see my Location in crowded areas.
It should either be possible to control the layer above/below which the LocationLayerPlugin is being rendered or it should just always render on top of everything.

I like the idea of being able to control where exactly the location layer is within the map style layer stack. In other plugins such as traffic and buildings, we let you pass in a string representing the layer you would want the layer to be above in the stack, we could offer the same functionality or possibly even expose an API which can adjust where the locationLayer sits on the map like you mention.
Right now, a simple workaround would be to first add all your custom Symbol/line layers and lastly, add the location layer to the map. When the Location Layer Plugins initialized, the layers are placed at the top of the map style layer stack.

Right now, a simple workaround would be to first add all your custom Symbol/line layers and lastly, add the location layer to the map.

Hi, to make location layer be on top of my layers I try to reinit LocationEngine with LocationLayerPlugin from scratch on the same map. But in that case exception occurs: CannotAddSourceException: Source mapbox-location-source already exists
For that I manually remove "mapbox-location-source" and before all layers that use the source. Looks like an overhead.
map?.removeLayer("mapbox-location-shadow")
map?.removeLayer("mapbox-location-layer")
map?.removeLayer("mapbox-location-stroke-layer")
map?.removeLayer("mapbox-location-accuracy-layer")
map?.removeLayer("mapbox-location-bearing-layer")
map?.removeSource("mapbox-location-source")
//then reinit LocationEngine with LocationLayerPlugin

Is there any better way to completely remove "mapbox-location-source" and add it anew.

@Kravet
I had an issue where I wanted the LocationLayerPlugin to be over all other layers.
I fixed it with Initializing LocationLayerPlugin before I started drawing other layers.
The other layers I added with mapboxMap.addLayerBelow(layer, "mapbox-location-shadow");

The LocationComponent should be used instead of the Location Layer Plugin  https://www.mapbox.com/android-docs/maps/overview/location-component/
The LocationComponent should automatically place the device location puck (or whatever drawable(s) you're using) on top of all other layers. The LocationComponentOptions class has a layerBelow() method. Here it is being used in the the GL-Native Android test app

I have recently migrated to Location Plugin and it's already deprecated.. But @langsmith thanks for advise.

com.mapbox.mapboxsdk.style.sources.CannotAddSourceException: Source mapbox-android-symbol-source already exists
having the same trouble with the annotation plugin .
what is the best way to set a new style and keep all the symbols?
the exception is thrown when i set new manager with new style
mapboxMap.setStyle(Style.SATELLITE, style -> {
    this.symbolManager = new SymbolManager(this.mapView, this.mapboxMap, newMapStyle);
});

I have this exact same issue. How can we switch the style of app while a SymbolManager is already available for that style? Whatever I do, it crashes.

com.mapbox.mapboxsdk.style.sources.CannotAddSourceException: Source mapbox-android-symbol-source already exists
having the same trouble with the annotation plugin .
what is the best way to set a new style and keep all the symbols?
the exception is thrown when i set new manager with new style
mapboxMap.setStyle(Style.SATELLITE, newMapStyle -> {
 this.symbolManager = new SymbolManager(this.mapView, this.mapboxMap, newMapStyle);
});

Did you find a workaround for your issue? I get the same.

@Yulin777 @sdtaheri2 @houdayec all AnnotationManagers survive style changes on their own, they don't have to be re-instantiated. You should be able to change the style while keeping a reference to the previously created annotation manager and all added annotations should persist. Is that not the case?


[docker] Remove traces of config-builder

Remove validator-dynamic, the pinacle of config-builder
Remove building / copying config-builder
Remove shell scripts as they almost all use config-builder and we execute commands directly within the container
Stripped out most of the mint test code but we'll add that back via a proper e2e test in compose in the near future... that test wasn't really ... testing anything

/canary

/cancel

/land

:exclamation: Land has been canceled due to this PR being updated with new commits. Please issue another Land command if you want to requeue this PR.

/land

:broken_heart: Test Failed - Build images and run cluster test

@davidiw the LBT issue is fixed, you can retry land.

@davidiw the LBT issue is fixed, you can retry land.

There's a couple other hairy issues that I'm trying to weed out at the same time :P, hopefully this latest tweak gets the rest of them... and then we can finally say good bye to the scary side of config-builder.

/land
/priority high

Sooooo Bors only listens to one command (the first one) per message. This is something that could easily be changed but we just didn't get around to it. I manually added the hi-pri label though

Does bors rebase this on current master for lbt and other tests or does it use this as is? Because I fear I didn't properly rebase this to pass lbt :/

@davidiw Bors always rebases onto the latest master prior to running tests

sweet


[css] support cancelation requests

The CSS language server should react to cancelation requests

don't evaluate completions for cancelled requests
look into cancelling building a large AST.

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
If you disagree and feel that this issue is crucial: We're happy to listen and to reconsider.
Maybe you want to give it a try yourself and provide the feature through an extension or a PR: We're happy to give advise and get you started.
Thanks for your understanding. Thanks for helping and happy coding!


Gbs

Added new benchmarks (Pcvl has still to be fixed)
Updated documentation
Circuit constructor

where in the package? I cannot find your comment in the review