Fix pan behaviour of the Distance Request map

Details

This PR fixes the broken panning of the distance request map on all platforms.
Fixed Issues

$ https://github.com/Expensify/App/issues/26435
PROPOSAL: https://github.com/Expensify/App/issues/26435#issuecomment-1701951806
Tests

Open the App and click on the + icon in the LHN.
Select Request Money option.
Select Distance Request and wait for the map to load.
Try moving the map around by dragging over it.

Verify that the map pans correctly.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Open the App and click on the + icon in the LHN.
Select Request Money option.
Select Distance Request and wait for the map to load.
Try moving the map around by dragging over it.

Verify that the map pans correctly.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/30054992/4bd780a8-0e85-4802-89dd-dca528c43a93

Mobile Web - Chrome

https://github.com/Expensify/App/assets/30054992/9bfe030c-8e22-420b-9dee-f6d0ab298bba

Mobile Web - Safari

https://github.com/Expensify/App/assets/30054992/cac56673-3633-40ce-a378-78ed282c8229

Desktop

https://github.com/Expensify/App/assets/30054992/0493bfce-89ac-4319-bbd6-63722ed3c794

iOS

https://github.com/Expensify/App/assets/30054992/a9858431-d5ef-46f3-a8cf-31f87bcbe885

Android

https://github.com/Expensify/App/assets/30054992/80f43af9-024c-493d-897b-cd00f025461a

Taking a look

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@allroundexperts is it expected behaviour - seems no ability to move map to right
https://github.com/Expensify/App/assets/28352309/6a3f5b9e-2a00-418c-bdc3-9c5bae5b4346

@allroundexperts ignore that message above - on latest main working as expected

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.63-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.63-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.64-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Union of two array

Have you read the Contributing Guidelines on Pull Requests
Yes
Description
Sort both arrays then iterators for arr1, arr2 then go along both arrays if an element is lower than another, increment iterator in that array, else part if we find equal elements add an element to the result and increment iterators of both arrays
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
This issue related to #1452

@tarun26091999 and @raksha009 please check my PR request

issue wasn't assigned yet.


Improve ElementType ergonomics

Minor improvements to ElementType ergonomics:

derive Copy, Clone to make it easier to pass around as a type vs. u32
derive PartialEq, Eq to make instances comparable
implement TryFrom with a custom error
implement conversion Into u32
implement Display

If you accept, I have a follow-up PR that would change some of the u32 return values to ElementType in Node and Tensor, but this would be a breaking change.

@pnehrer, thanks again for the contribution! I'm going to merge #99 first since that was sitting in the queue and that might cause you a bit of rebasing headache — hopefully not too much. And feel free to replace those u32s with ElementType since we haven't yet published a version that contains these new 2.0 changes.

@abrown I resolved the merge conflict and this is now ready to go

Thank you again!


Update linux packaging for JDK <IP_ADDRESS>+1

Spec file changes required for the new interim jdk11 release so we can release updated rpm and deb files. Hopefully the extra .1 won't cause anything to break ;-)
Signed-off-by: Stewart X Addison<EMAIL_ADDRESS>

Initial checks failed due to failing to download the PPC64le build - unclear why as a wget on the same URL worked ok - will see on a re-push whether it was a one-off ...
 Downloading: https://github.com/adoptium/temurin11-binaries/releases/download/jdk-<IP_ADDRESS>%2B1/OpenJDK11U-jdk_x64_linux_hotspot_<IP_ADDRESS>_1.tar.gz.sha256.txt
Downloaded: OpenJDK11U-jdk_x64_linux_hotspot_<IP_ADDRESS>_1.tar.gz.sha256.txt
Downloading: https://github.com/adoptium/temurin11-binaries/releases/download/jdk-<IP_ADDRESS>%2B1/OpenJDK11U-jdk_ppc64le_linux_hotspot_<IP_ADDRESS>_1.tar.gz
Download failed:
403 Client Error: Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. for url: https://objects.githubusercontent.com/github-production-release-asset-2e65be/372924883/9a788130-da55-4f32-a352-aaa9eb4156e6?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20220210%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20220210T161959Z&X-Amz-Expires=300&X-Amz-Signature=ac3912bca74f6b8f2c3ded73b77eb660f0f007419e9725e73e6343a173c291eb&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=372924883&response-content-disposition=attachment%3B%20filename%3DOpenJDK11U-jdk_ppc64le_linux_hotspot_<IP_ADDRESS>_1.tar.gz&response-content-type=application%2Foctet-stream


Backend argument in experiment constructors

BaseExperiment has an optional backend parameter. Do we want to make it mandatory, and remove the backend parameter from the run method?
If no: some experiments don't have a backend parameter in their constructors. Do we want, for the sake of uniformity, to instruct that all the experiments have this parameter? How can we enforce this instruction?

Also readout error experiments and tomography experiments.
In the case of tomography, the base class has the backend parameter, but this in practice has no effect since the state tomography and process tomography classes don't.

Personally, I would prefer that backend were an __init__ argument. It is needed for core functionality of the experiment class and with it optional we have to jump through extra hoops to check if a backend is set or not and substitute default values when they can't be pulled from the backend. There is some case for building an experiment and then running it on different backends but I think the more common workflow is to focus on one backend at a time, and in that case passing the backend at initialization is not a burden.
If we want to preserve the ability to initialize an experiment instance and inspect it without setting up a specific backend, I wonder if we could define a generic backend and set it as the default argument for when a backend is not passed by the user (def __init__(self, qubits, backend=GenericBackend(), ...).

Note that, with the generic experiment, we again don't catch cases where experiment developers simply forget backend in their expeiment __init__. Like what seems to be the case with tomography.

@yaelbh readout error and tomography now all take backend kwargs in init since #1019 #998. I personally like having backend as an optional kwarg in all experiments, so you can either set it at init, or you can set it at run. So in principle you can configure an experiment and run it an on multiple backends.
That said it would likely allow some simplifying of the base experiment if backend could only be set at init (you could remove the backend setter and set_backend method). The purpose of the set_backend method in base experiment was so that any functionality that depended on a backend could be specified here, but its still up to person writing an experiment to do validation for if backend is not set where it might be needed (ie in circuit generation). I suppose we could automate that exception handling by making the backend getter raise an exception if its None.

In a meeting we decided:

We will add the parameter to our existing experiment constructors where it is missing.
We will not enforce it to be present in experiment constructors.

One of the considerations to not enforcing was related to the fact backends are not serializable.


WordPress support

Description:
Would it be possible to add Wordpress support in this plugin? There are quite a few number of wordpress website and it would be great to have client apps interfacing with wordpress websites.
OAuth Provider (Twitter, Github, ..):
WP REST API - OAuth 1.0a Server
OAuth Version:

[x ] Version 1
[ ] Version 2

OS (Please fill the version) :

[x] iOS :
[x] OSX :
[x] TVOS :
[ ] WatchOS  :

Installation method:

[ ] Carthage
[x] CocoaPods
[x] Manually

Hi
Before asking did you try?
Did you read wordpress oauth documentation? could you provide a link?
If is not working, add information that prove it, error dump, etc.. ie. create a real issue, not a feature request
If it's work, then you can make a PR to add it into the demo app
https://github.com/OAuthSwift/OAuthSwift/wiki/Demo-application#add-a-new-service-in-demo-app


[Dependencies] Add resolutions for @apidevtools/json-schema-ref-parser

Description
A breaking change was introduced to json-schema-ref-parser that requires that we pin/resolve to an earlier version. See the following for background: https://github.com/APIDevTools/json-schema-ref-parser/issues/298
Motivation and Context
The breaking change causes builds to fail internally.
How Has This Been Tested?
Tested internally.

Issue resolved in #341


Docker error

Hi,
I downloaded the MEA docker file and installed the docker image. Then I followed the manual and ran the command-line below:
export MEA='docker run -v /nfs/med-bfx-activeprojects/weishwu/common/MEA/dist/mea/bin:/mea-data -i weishwu/mea:1.0'

Then I ran
$MEA setting

But this gave me an error saying:
docker: Error response from daemon: error while creating mount source path '/nfs/med-bfx-activeprojects/weishwu/common/MEA/dist/mea/bin': mkdir /nfs/med-bfx-activeprojects/weishwu: permission denied.
ERRO[0001] error waiting for container: context canceled

Any help? Thanks.

Hi,
I've not tried converting the docker image to singularity ... but I notice
that you haven't defined a mount point in your second and third binds.
If you need to either

provide a mount point that exists in the image to bind to and use that
mount point in your command
don't use the second and third "-B" and  use the full path in the
command

HTH but let us know if it's still an issue.
Richard
On Thu, 24 Dec 2020 at 19:14, weishwu<EMAIL_ADDRESS>wrote:

Hi,
I'm trying to use MEA to create the diploid genome. I couldn't use the
docker installation directly due to permission issues. So I converted the
docker image to a singularity image and thought the following command-line
should work. But I got an error saying "Error: File undefined does not
exist" which I don't understand. Any help?
singularity run -e -B "/nfs/bfx/weishwu/common/MEA/src/scripts:/mea-data" -B "/nfs/bfx/weishwu/phasing/FAM_1" -B "/nfs/bfx/weishwu/common" mea.simg createGenome /nfs/bfx/weishwu/common/hg38.fasta /nfs/bfx/weishwu/phasing/FAM_1/FAM_1.vcf pat mat mea_out
[mea] [createGenome] Started at [Thu Dec 24 11:06:00 EST 2020]
Error: File undefined does not exist
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/julienrichardalbert/MEA/issues/14, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACEW7Y4FRVWEBI5ESBE56LSWNSGXANCNFSM4VILE73A
.

Hi Richard,
Thanks for the response. I actually edited my question after I posted it. It seemed I edited it before you answered my original post.
I tried using Docker but got a permission error (which was why I switched to using Singularity):
export MEA='docker run -v /nfs/med-bfx-activeprojects/weishwu/common/MEA/dist/mea/bin:/mea-data -i weishwu/mea:1.0'

Then I ran
$MEA setting

But this gave me an error saying:
docker: Error response from daemon: error while creating mount source path '/nfs/med-bfx-activeprojects/weishwu/common/MEA/dist/mea/bin': mkdir /nfs/med-bfx-activeprojects/weishwu: permission denied.
ERRO[0001] error waiting for container: context canceled

Any help? Thanks.

Hi Richard,
I got the same error now by using docker:
export MEA='docker run -v /nfs/mm-isilon/bioinfcore/ActiveProjects/weishwu/common/MEA/dist/mea/bin/:/mea-data -i weishwu/mea:1.0'

${MEA} createGenome /mea-data/Homo_sapiens_assembly38.fasta /mea-data/test.vcf strain1 strain2 /mea-data/test

Error message:
[mea] [createGenome] Started at [Tue Dec 29 02:31:12 UTC 2020]
Error: File undefined does not exist

Never mind. I got it.


How to disable the userwarning when setting the Clarabel solver in CVXPY

Hi, is there way to disable the warnings like "warnings.warn(/opt/conda/lib/python3.8/site-packages/cvxpy/problems/problem.py:1385: UserWarning: Solution may be inaccurate. Try another solver, adjusting the solver settings, or solve with verbose=True for more information.)" when using Clarabel?
Thanks!

The top answer here seems helpful: https://stackoverflow.com/questions/14463277/how-to-disable-python-warnings

Steven's comment looks like the answer. Regardless, suppressing warnings isn't CVXPY's responsibility per se. So I'll close this for now. If we messed up how the warning is issued then feel free to follow up and we can revisit.


new release please - 0.10.0 fails due to Cython 3 issues

I can build the current branch, but 0.10.0 fails for me on Gentoo Linux with gcc 13 and Cython 3.0.5. Time for a new release I suppose,

Will do this weekend. Thanks for the reminder.

ping?

Waiting for https://github.com/pypi/support/issues/3369
cc @rikardn

I wonder if switching to using gmpy2 would be feasible - at least it would lower the size of wheels.

Should be fixed now


[Label Redesign] Update entity_exists

Please assign me this issue

I have revised the get_label_id_from_entity function to only obtain the graph_Oid through the graph name. Subsequently, I invoke the new function get_label_id_from_entity_by_oid, which performs the same job as the original get_label_id_from_entity function (having the graph_Oid as an argument instead of the graph_name) and returns the label id.
Calls in get_label_id_from_entity:
gcd = search_graph_name_cache(graph_name);
graph_oid = get_label_id_from_entity_by_oid(entity, gcd->oid);

New function declaration:
int32 get_label_id_from_entity_by_oid(agtype_value *entity, Oid graph_oid);

Next, I added the label id as an argument in entity_exists function. Additionally, I modified the merge_vertex and create_vertex functions to get the graph Oid and obtain the label ID from the vertex entity by using the get_label_id_from_entity_by_oid function. Then, I pass the acquired label ID to the entity_exists function.
Extract the label ID in create_vertex and merge_vertex functions from the vertex entity:
label_id = get_label_id_from_entity_by_oid(v, css->graph_oid);

This all was done in PR #8


CP-11367: Make AddVerticesAndEdge an extension method

From unknown CodePlex user on Tuesday, 23 September 2008 15:38:05
AddVerticesAndEdge is a nice shorthand.

It exists on AdjacencyGraph<T,E> but not UndirectedGraph<T,E>.

Seems like it would be a good candidate for an extension method on whichever IMutable* interface has both vertices and edges? If not, it would be nice to just have an implementation on UndirectedGraph.

Keep up the awesome work.

Form unknown CodePlex user on Tuesday, 23 September 2008 20:40:26
Good point. I was just starting to play with extensions methods.

Form unknown CodePlex user on Tuesday, 23 September 2008 20:40:26

Form unknown CodePlex user on Tuesday, 23 September 2008 21:51:31

Form unknown CodePlex user on Thursday, 21 February 2013 17:44:57

Form unknown CodePlex user on Thursday, 16 May 2013 04:59:29


Build failing on Raspberry PI 400

I was following these instructions: https://www.balena.io/blog/put-friends-and-loved-ones-on-the-big-screen-with-this-instant-video-call-project for my PI400 and saw that none of the services were coming up on the dashboard in the balena cloud. In the build logs of the release I noticed that kiosk build is failing thus failing the whole release.
[Info]          Building on arm01
[Info]          Pulling previous images for caching purposes...
[Success]       Successfully pulled cache images
[Info]          Starting to build kiosk
[Info]          Starting to build wifi-connect
[Info]          Starting to build scheduler
[Success]       Successfully built service wifi-connect
[Success]       Successfully built service scheduler
[Info]          Uploading images
[Success]       Successfully uploaded images
[Error]         Some services failed to build:
[Error]           Service: kiosk
[Error]             Error: manifest for balenalib/raspberrypi400-64-golang:latest not found: manifest unknown: manifest unknown
[Info]          Built on arm01
[Error]         Not deploying release.

Same happened to me using balenaOS 2.65.0+rev2


Added User Image to profile picture and navbar

Related Issue

Closes: #224
Description of Changes
Hey @sourabhsikarwar I have added the code to show the image of the users who are signed up using Google. Now the profile picture and the image at the top right of the navbar are not static. It will change according to the user. I have also made the cursor pointer to the Avatar component for a better user experience. Please review my pr and merge it. Thank you!
Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[ ] I have included comments in areas that may be difficult to understand.
[ ] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

Original
Updated

]

Please provide any necessary screenshots to illustrate the changes made.

Resolve merge conflicts @sumitkr2000

@AKD-01 Please review my pr and merge it. Thank you!


Update Cyber-Dojo for today's Chapel 1.24.0 release

[This one's dedicated to Russel Winder.]

Hi @JonJagger — As usual, I've bumped the version numbers here, but not done much more in terms of testing/QA than that.

Closing in favor of #6.


I added the option for residuals to be added to the prediction of the original points.

If in any regression function options.residuals === true, the returned points will have the following structure.
[{
coordinates: [x, y],
residual: e // Residual = Actual - Predicted
}, ...]

The code missed the target amount of line by 9 lines. Should I refactor and move functions to separate files?


[EasyConfigStandard] prepare ready-to-go configs

Added Default Sets to Run With
Say good bye to long config setup for first run.
5 new files with PHP-CS-Fixer ready configs
vendor/symplify/easy-coding-standard/config/php70-checkers.neon
vendor/symplify/easy-coding-standard/config/php71-checkers.neon
vendor/symplify/easy-coding-standard/config/psr2-checkers.neon
vendor/symplify/easy-coding-standard/config/symfony-checkers.neon
vendor/symplify/easy-coding-standard/config/symfony-risky-checkers.neon

How to use?
1. Include it in your config:
# easy-coding-standard.neon

includes:
    - vendor/symplify/easy-coding-standard/config/php70-checkers.neon
    - vendor/symplify/easy-coding-standard/config/php71-checkers.neon
    - vendor/symplify/easy-coding-standard/config/psr2-checkers.neon

2. Use them from CLI
vendor/bin/ecs check src --config vendor/symplify/easy-coding-standard/config/psr2-checkers.neon

Related Changes

added option to show fixers from specific set from PHP-CS-Fixer: https://github.com/Symplify/Symplify/pull/267/commits/4db3a226a6f970b00b2e9cef8bf1c0270f1d6636
vendor/bin/ecs show --fixer-set Symfony

added option to show fixer with their config, only for PHP-CS-Fixer now - ready to copy to config :+1:

Ready for beta shipping


NR-15944: Removed the Get started CTA from the top nav of Public IO

JIRA ticket: https://issues.newrelic.com/browse/NR-15944
Description : Removed the Get started CTA from the top nav of Public IO
Before changes :

Mobile view:

After changes:

Mobile view:

As Gatsby build is not generated in this PR, I am closing this PR and have raised a new PR: https://github.com/newrelic/instant-observability-website/pull/227

As Gatsby build is not generated in this PR, I am closing this PR and have raised a new PR: https://github.com/newrelic/instant-observability-website/pull/227


Is there an example for marker clustering?

Hi there,
I work with that rep and it works perfect! But I got too many markers, therefore I am looking for an example for clustering the markers with ngmap (https://developers.google.com/maps/articles/toomanymarkers). Is there something around?
Thanks,
suuuunto

https://rawgit.com/allenhwkim/angularjs-google-maps/master/testapp/marker-clusterer.html
For this case, you need to control all markers through marker-clusterer though. Lots of raw programming required.


refactor(semantic): move CatchClause scope binding logic to visit_block_statement

This logic only needs to run in the BlockStatement

#4505  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite

Oh wait! Why are some semantic benchmarks showing as -1%? Let's see if that still holds true after the benchmarks have run again after my style nit commits.

Looks like I was wrong that mem::take is better than drain + collect. I guess drain and collect has a shortcut fast path I didn't know about. I've switched it back to drain + collect and now benchmarks are positive.
Sorry I made that bad suggestion! I guess the lesson is: never assume you understand, always measure!

Agreed! Even with a bad suggestion. I still learned a lot of useful experiences from your attempt! You are the best!

Also sorry I've hijacked your PR! I will stop fiddling and hand it back to you now.

No worries!


Replace custom Navigation type for flow-typed react-navigation 2.x.x

After https://github.com/kiwicom/mobile/pull/869 is merged.

closed with #869

That's not done yet, it is related to #899.

Ah but we duplicated it #898 so I'll close this one.


Move test wallet creation to individual tests.

Also fixed some code styling issues in NodeBuilder. Fixes #533

Ah @mikedennis can you fix conflicts?

Ok should be good to go now!


How to reproduce reported performance

Thanks for this nice code base.
Can you provided instructions on how to reproduce the reported performance on the val set?
I tried:
python test.py --cfg_file ${CONFIG_FILE} --batch_size 4 --ckpt ${CKPT}

with the pretrained model and I get:
Car_3d_easy = 54.303261947978974
Car_3d_moderate = 38.349761507380684
Car_3d_hard = 36.39773833709999

with a model trained with the default config:
Car_3d_easy = 76.20793977206878
Car_3d_moderate = 60.98983744758463
Car_3d_hard = 57.58892404665682

which is far from the reported values. Am I doing something wrong? Is the provided config the one with which you report the performance?
Thanks

The provided pretrained models could achieve exactly the same reported performance. Have you modified the codes? I think you should make true to achieve the same reported performance with the given model firstly.

Hi, I was able to reproduce similar results as reported by training the network on my own (SECOND, Pointpillars) with the proposed commands.

Thanks for the quick reply. I did not modify the code except for a small change in spconv to make it work with pytorch 1.4. I only tried the default config for pointpillars, but did not get the error mentionned by @chreisinger. I guess I could try with 1.1 or 1.3.
@sshaoshuai @chreisinger What pytorch, numpy versions are you using?

Forgot to mention I only have 4 gpus so I changed the batch size to 28 per GPU instead of 32. I guess should have used 16 as recommended instead.
But that would not explain the poor results obtained with the pretained model.

Okay, I use Pytorch 1.3, the newest version of numpy and an unchanged version of spconv. By the way, I use a single 1080Ti.

The issue was with a corrupted KITTI dataset I got from someone else... Sorry for the noise and thanks for the support. I can reproduce the exact same numbers with the PointPillars pretrained model with pytorch 1.4.


align global dim in linearizer

Currently the gidx0-3 is not aligned with grid.x,y,z in cuda in  which caused #1224. By performing an additional reshape, this issue got resolved.
Having this error when I was trying to run test/models/test_real_world.py with CUDA
kernel.cu(23): error: no suitable user-defined conversion from "float4" to "half4" exists

will update once I resolve that but here's some metrics on CIFAR, tested with batch size as much as 3090 can handle.
GPU=1 CUDA=0 BS=512 STEPS=1000 python examples/hlb_cifar10.py
999  313.88 ms run,    3.06 ms python,  310.82 ms CL,    0.82 loss, 0.000010 LR, 8.85 GB used,   3720.15 GFLOPS
eval 9006/10000 90.06%,    0.41 val_loss STEP=1000

GPU=1 CUDA=1 BS=512 STEPS=1000 python examples/hlb_cifar10.py
 49  301.26 ms run,    2.55 ms python,  298.71 ms CL,    1.98 loss, 0.009143 LR, 7.57 GB used,   3875.96 GFLOPS
eval 3642/10000 36.42%,    2.12 val_loss STEP=50
 50  302.38 ms run,    2.76 ms python,  299.62 ms CL,    2.10 loss, 0.009326 LR, 8.85 GB used,   3861.67 GFLOPS
...
999  309.64 ms run,    2.43 ms python,  307.21 ms CL,    0.83 loss, 0.000010 LR, 8.85 GB used,   3771.06 GFLOPS
eval 9019/10000 90.19%,    0.41 val_loss STEP=1000

GPU=1 CUDA=1 BS=1024 STEPS=1000 python examples/hlb_cifar10.py
999  625.92 ms run,    3.60 ms python,  622.32 ms CL,    0.15 loss, 0.000010 LR, 16.34 GB used,   3730.96 GFLOPS
eval 9045/10000 90.45%,    0.39 val_loss STEP=1000

Changes made in tinygrad/:
------------------------------------------------------------
files                             insertions       deletions
------------------------------------------------------------
tinygrad/codegen/linearizer.py             7               4
------------------------------------------------------------
lines added in the tinygrad folder: 3

@geohot I have added the comparison of global dimension to there according limits. If it exceeds the absolute maximum I just assert it now cuz I feel like more complex reshape should be done in optimizer instead of linearizer.  I use permute instead of reshape to avoid creating multiple view shape tracker.


Add pluggable authentication and authorization to snapshotserver and changeserver

We need a pluggable auth system for both AuthN and AuthZ that can check that a user has a valid, non-expired key as well as use that to verify their access to their requested scopes.

I opened another issue to add basic auth from my own backlog. Perhaps a pluggable mechanism is better. Problem is, of course, that golang and "pluggable" don't really go together...

My initial thought was to define a sql query (in a command line switch or config file) that would in one step check validity of the requested API and the scopes that are passed in, and then the pluggability would be adapting that sql query to your schema. Would that work for you guys?

The change server runs nicely even if it can't reach postgres -- I'd like to keep it that way. I think that we can do this by having a special table that gets stored locally and used to make authorization decisions, but we'll have to do a little bit of thinking about it. I have some ideas though, so let me try some things out this week.

Here's a proposal:
In the configuration for the change and snapshot servers, we'll designate a table called the "authorization table." The name of this table will be configurable (and you'll be able to leave it undefined, which means no authorization).
The table should have the following schema (but any name):
create table authorization_table (
id text,
scope text,
primary key (id, scope)
)
In addition, both servers will consume an HTTP header that stores the "user ID." By default this will be called "X-Transicator-UserID". However there will be a parameter that allows the user to customize this.
On each call to the snapshot server, the server will do the following:

Extract the user ID from the HTTP headers. Reject the request if there is no user ID.
Extract the list of scopes from the HTTP query parameters (this already happens)
For each scope, do the equivalent of:
select from authorization_table where id = (User ID) and scope = (Scope)
If the above query does NOT result in a row, then reject the request as unauthorized.

The change server will run through all the above steps, except that it will not query the database directly. Instead, it will treat the "authorization_table" table as a special table, and rather than pass its contents on to the client, it will persist the authorization information inside the LevelDB database. This will make it possible for the change server to run even if it cannot reach Postgres.
Furthermore, in order for this to work, when the change server first starts it will retrieve the entire "authorization_table" table from the database and prepopulate its own copy before it begins replicating any changes.

That would work for us if that was a view, but if it's being replicated the view isn't going to work.
Can we do an optional (disable-able) way to not use the locally stored version and always query postgres, if you're ok with that dependency? We'd probably want a different url for hitting postgres for this query versus the actual replication stream.

Actualy it best as a view for us too. So let's see if we can do that another way. The only problem is that the configuration is starting to get complicated and now I think that we need some sort of a configuration file.

So if we're going to a config file (which I agree is seeming very necessary), can we make the query pluggable too? We have some more complex usecases (superusers, for instance) that we'd prefer to not have to expose their full set of allowed scopes.
What I'd like is a query that takes the user id (token value, whatever) and requested scope(s) and returns the set of scopes that the user is allowed to see (or perhaps returns a single 0-valued column if the user doesn't have access to the scopes and a > 0 column if they do)

Yes -- but there's more to think about here. For instance, we will need the
authorization logic in other places too and perhaps we're better off, at
least within Apigee, with a micro service...
On Tue, Nov 8, 2016 at 3:01 PM, Kris Wehner<EMAIL_ADDRESS>wrote:

So if we're going to a config file (which I agree is seeming very
necessary), can we make the query pluggable too? We have some more complex
usecases (superusers, for instance) that we'd prefer to not have to expose
their full set of allowed scopes.
What I'd like is a query that takes the user id (token value, whatever)
and requested scope(s) and returns the set of scopes that the user is
allowed to see (or perhaps returns a single 0-valued column if the user
doesn't have access to the scopes and a > 0 column if they do)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apigee-labs/transicator/issues/5#issuecomment-259287037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAf0a3iu7Mjrh4EoqycYfuC_K2f0zP61ks5q8P9DgaJpZM4Kpzcy
.

--
Greg Brail | apigee https://apigee.com/ | twitter @gbrail
http://twitter.com/gbrail @apigee https://twitter.com/apigee

At the moment the jury is still out on whether we for our own needs need these servers to check authorization, or whether we will have an external proxy that does it. (That would however imply that we beef up the TLS support to optionally verify the client certificate.)

@gbrail we're definitely going to need authorization, but we can make it disable-able. If this is the point where we move to a separate fork, that's ok too.

I'm happy to have the feature in and happy to review, test, etc. However
tight now developing it isn't a priority for me. But if have an idea or
implementation I can review and merge it.
On Fri, Nov 18, 2016 at 11:20 AM Kris Wehner<EMAIL_ADDRESS>wrote:

@gbrail https://github.com/gbrail we're definitely going to need
authorization, but we can make it disable-able. If this is the point where
we move to a separate fork, that's ok too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apigee-labs/transicator/issues/5#issuecomment-261588535,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAf0a1PGXJGS2AKOKPFpaJi4501wk7GOks5q_d5HgaJpZM4Kpzcy
.

I'm working on this now, hopefully in a transparent fashion

After discussing internally, we're going to change strategy on how to build this out. We'll share a proposed architecture once it's together.


Use empty string instead of empty bytestring when calling send_mesage function in default_policy.py

ZMQ socket's send_string method expects a unicode string instead of a bytestring. When calling with a bytestring it throws a 'bytes' object has no attribute 'encode' error. So we should simply call with an empty string.

What is this change for @cw75?

@vsreekanti It's just a bugfix; I noticed that whenever the management service tries to autoscale, it crashes by throwing that error.


Replace  tags to <> around the projects

Describe the bug
There are many  tags around the codebase. Please replace it to <></> in order to get a more concise and clear code.

Is this already complete or i can have a go here?

Hey Danny, what's up? It was completed in parts, there are some bugs to solve yet. I'm gonna create another issue explaining better what happens and let you know, okay?

sure

Hey Danny, the new issue is here: https://github.com/freeCodeCamp/freeCodeCamp/issues/40143

Hy Danny and Evertonbraga, is this issue still open for contribution? I would love to contribute to it as well.

Hey Phakeme, I'd like to contribute but I'm so busy at the moment. Please go ahead!

Hi Dear people!
Im a new guy who want to make his first contribution here -  can somebody please guide me-
Is there already PR for this issue?
Thanks


Enable handling of other/unknown proposals

This PR allows OpenMLS to handle unknown/other proposals analogous to how extensions are handled.

It's pretty much the same as for extensions, where OpenMLS doesn't fail if there is an extension it doesn't recognize. It just accepts that it's there, but doesn't do anything as a consequence. The application can then inspect the proposals, take whatever data is in the proposal and act according whatever the semantic of the proposal is.
Good point w.r.t. docs. I'll add something to the book and I'll also add a changelog entry.


Fe assignment 1

Metric
Value

alert_status
:white_check_mark: OK

bugs
0

code_smells
53

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0

Metric
Value

alert_status
:x: ERROR

bugs
0

code_smells
6

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0

Metric
Value

alert_status
:x: ERROR

bugs
0

code_smells
6

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


contrib: Add script to create kind cluster

We have the equivalent for minikube.
TODO:

Add target in Makefile to make it build and push images to the kind
registry
Find a way to parameterize the number of workers (not sure how
necessary this is)
Add to docs

Coverage decreased (-0.03%) to 36.975% when pulling 8bfe53be2014e9071b3a66269735392e87b2b565 on christarazi:pr/christarazi/add-kind-cluster-script into b0610a4b9a9eac349da5e409a532850fdfe38c18 on cilium:master.

* Find a way to parameterize the number of workers (not sure how
  necessary this is)

I use kind a lot for Hubble Relay development and, in this context, being able to test with 4+ nodes is super useful (I've created kind clusters up to 50 nodes).
However, I also found out that I don't need a local registry as I can just kind load docker-image cilium/hubble-relay:latest (and any other relevant image) followed by kubectl delete pods .... This works because the pull policy is IfNotPresent and if there are multiple images with the same tag, the most recent one is picked.

I love kind a lot as well. Have been using it as part of local development and testing.
Related on number of node, here is the configuration we used in smoke test with one tweak to make sure that the control plan is available for scheduling. https://github.com/cilium/cilium/blob/master/.github/kind-config.yaml#L6

FWIW, I feel it'd be kinda nice to have some convenience script for this in the tree, occasionally I use the steps from the conformance tests + .github/kind-config.yaml to deploy a kind config but I always have to look it up again whenever I try it out.

Yeah, I think it's worth dusting off this PR and getting it out even though it doesn't meet all the TODOs marked in the PR description. I often switch to this branch locally, create my kind cluster, then switch back to my dev branch :sweat_smile:.
/cc @sayboras, he had a similar PR out and might be worth figuring out which one to move forward and whether to consolidate.

@joestringer @christarazi 👋 oh this pending one I got is my local script to quickly run conformance test. There are few comments which I need to address, but didn't have time recently. I will plan sometimes to clean it up, anyway, happy to discuss how to move forward in either case 😃

Forgot to update this one. Recently, the idea is to have a good scripting to test locally, but recently I switch to cilium-cli, which is great tool. I think this one is no longer required, we can promote cilium-cli further as well.

It might still be helpful to have an "official" script to launch a dev kind cluster. I still plan to get to this at some point :sweat_smile:

It might still be helpful to have an "official" script to launch a dev kind cluster. I still plan to get to this at some point 😅

Oh sorry, just realized that I closed the wrong PR :(, there is another one created by me 🤦


Multiple network interface

Question:
Hello,
I'm not find a solution in portainer to attach multiple network interface for a container.
It's implemented or not ?
Thanks

Hi @MyTheValentinus
Do you mean attaching a container to multiple Docker networks? If so, yes it's possible. You need to create a container and attach it to the network of your choice first. Then, you'll be able to attach it to other networks by inspecting the container and choosing the network of your choice and click on join.
Closing, feel free to comment if you're missing something.

But problem is with configuration multiple interface, only one is possible in "create container" section.

But problem is with configuration multiple interface, only one is possible in "create container" section.

It also is not persistent on Edit/Replace Operations

Just wanted to see if there was an update to allow this in the persistent Edit/Replace Operations?
Otherwise, if we still have to manually add it every time the container starts?


Better explain role of existing requirements.txt

This commit adds an explanation of the role of existing requirements.txt
files to the README.
I found this very unclear and opened #1358 because of my confusion. The
existing short note that requirements.txt "might interfere" didn't
really help me. I'm not sure how common my confusion is, but I hope my
changes makes things clearer to new users (assuming what I've written is
in fact correct!)
(In addition to my additions, I moved the "Updating requirements"
section up in the doc, since it seems like a core workflow.)

Changelog-friendly one-liner:
Contributor checklist

[ ] Provided the tests for the changes.
[X] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[x] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Thanks @mikepqr 🙏🏻

Thank you for your help!


MQTT sensor topic current temperature

I have recently installed the thermostat shield and it is working fine. A DHT22 is connected to a raspberry pi and is publishing the current room temperature. I have also have a topic 'diyless_thermostat/cmnd/things/thermostat/properties/temperature' publishing the room temperature as a float. I also have published 'diyless_thermostat/cmnd/things/thermostat/properties/tempSource = 1' to configure the MQTT sensor,
But it seems not to work, the topic opentherm-thermostat/current-temperature/get = the value of the internal sensor and not the value of the MQTT sensor.
I also can't find any code block in the sketch that would subscribe or listen to the MQTT sensor.
What needs to be added or done to make the MQTT sensor work with the thermostat?
thanks for your feedback.

Hi @windmillBart ,
Did you choose the MQTT sensor option from the thermostat Web interface?
(Menu -> Sensor -> MQTT sensor)

Hi,
I'm not able to open the Web interface;  I have uploaded the sketch from
the website https://diyless.com/blog/home-assistant-opentherm-thermostat on
a WEMOS D1 mini ESP32; (I did changed the pins and import Wifi.h to make it
work for ESP32.)
I ordered the shield only with order<PHONE_NUMBER> and I used a WEMOS D1 mini
ESP32 from AZ-delivery that I already had bought earlier.
In the sketch I used I don't see a webserver, therefore I used the MQTT
topic to publish value 1 to configure MQTT Sensor (I tought).
Thanks,
Bart
Op ma 28 aug 2023 om 08:08 schreef DIYLESS Electronics <
@.***>:

Hi @windmillBart https://github.com/windmillBart ,
Did you choose the MQTT sensor option from the thermostat Web interface?
(Menu -> Sensor -> MQTT sensor)
—
Reply to this email directly, view it on GitHub
https://github.com/diyless/home-assistant-opentherm-thermostat/issues/10#issuecomment-1695074429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7CUJOAD6QJYMWOQZ7NRSYDXXQYUFANCNFSM6AAAAAA373N4CA
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

We will update our example to use the latest Arduino core as well as libraries and test if this issue is still active


Tests fail when using GCC14 as system compiler

openSUSE Tumbleweed has switched from GCC 13 to GCC 14 in snapshot 20240827
This results in an test failure, as observed by openQA
https://openqa.opensuse.org/tests/4439307#step/bci_test_podman/31
The test is trying to install a (rather old) version of sqlite3 gem (version 1.4.0; latest version upstream seems to be 2.0.2); There are good chances this has been addressed by upstream in the meantime (but no guarantees given)

Fix confirmed by openQA: https://openqa.opensuse.org/tests/4443166


removed the flipped Video after classification

If the video is not removed, it causes new  elements to be added to the DOM constantly , this could cause a huge spike in memory usage

This is just a quick bugfix

Thank you for catching this


Move Mesos message wrappers to mesos-utils

We recently added several classes to handle marshaling/un-marshaling Mesos protobuf messages.  These should be moved to the mesos-utils library.

@ConnorDoyle has this happened? Can we close this one?

We still have wrappers for Parameter and Command that could be moved.  ResourceUtils probably also belongs in mesos-utils.

On May 29, 2015, at 08:59, Ferdiism<EMAIL_ADDRESS>wrote:
@ConnorDoyle has this happened? Can we close this one?
—
Reply to this email directly or view it on GitHub.

We no longer use mesos-utils. no longer relevant.


Spacer component is now being imported from @freecodecamp/ui instead of components/helpers

I have replaced all the uses of Spacer component throughout the project, now in all the places the Spacer component is imported from @freecodecamp/ui instead of components/helpers.
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #56744

Thank you for your feedback but the PR #56765 , that the team want to get ahead with, that should be a duplicate PR. And the PR before mine has lot of issues found by the team and closed so this PR should be merged.
Thank you.

[x] I have read and followed the how to open a pull request guide.

The other PR did follow this guide and had all tests passing

[x] I have read and followed the how to open a pull request guide.

The other PR did follow this guide and had all tests passing

Thank you @ilenia-magoni for pointing out this, I will take care of it on next PRs.


Code quality: Introduced a service to cache NewItem menu types

Resolved / Related Issues
Items resolved / related issues by this PR.

None

Improvements

I added a service to cache and retrieve item types that are displayed in the AddItem dialog (as suggested by the TODO comment at line 38)
Thanks to this the AddItem dialog loads almost istantly (except the first time which takes the same as before)
Caching items is almost 35k times faster than retrieving them from scratch

Validation
How did you test these changes?

[x] Built and ran the app
[ ] Tested the changes for accessibility

Tests

Before (ticks):
After (ticks):

1
4_628_610
4_620_084

2
4_607_121
1_270

3
4_370_341
27

4
4_403_786
29

5
4_444_696
25

6
4_557_643
28

7
4_499_437
29

8
4_853_208
31

9
5_106_830
32

10
4_507_856
25

11
4_865_941
34

12
4_415_248
27

13
4_626_534
25

avg
4_606_711
355_512

avg (no 1)

132

@ferrariofilippo just checking, we already had some basic caching but this improves it?

@ferrariofilippo just checking, we already had some basic caching, but this improves it? Can we do the same for the right click menu for folders?

Here's a comparison (old on the left and improved on the right). You can see that the first time they take the same time to open, but the second time you open it there's no delay
https://user-images.githubusercontent.com/102259289/215358673-66b68104-4a25-48bd-80ec-da896ae138ea.mp4


keyboard support

(tried only on the demo page: "simple" and "responsive" buttons)
When activated with keyboard only (tabbing then pressing Enter), the menu opens but the focus remains on the opening button. It is possible to tab to the menu, but since the element is placed at the end of the DOM, it requires from the user to tab until the end of the page. Meh.
You may apply these guidelines from the W3C/WAI: https://www.w3.org/WAI/PF/aria-practices/#menubutton they describe expected behavior of components defined as menubuttons through code and visual aspect.

Thank you @OlivierNourry You are right, I'll take a look and I'll try to make it accessible, I can not give you a due date, sorry.

I've used this function in my sidr-related js to get keyboard nav/tabbing to work:

I am implementing the exact thing in the Drupal integration that I did for this module and I would like to add some more points:

When a sidr is closed, it should also be display: none. This will prevent the users from cycling through sidr elements even though the sidr is hidden. Currently the sidr hides only using CSS to go outside the screen.


Update how-to-create-a-workspace-with-data-exfiltration-protection.md

Resolves https://github.com/MicrosoftDocs/azure-docs/issues/97303

Docs Build status updates of commit c80d376:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add option to allow Conductor to run in SoftAndFirm mode when running against remote

Closing as this will be handled by https://github.com/astriaorg/astria-cli-go/issues/70


Flaky playground tests due to Failed to bind to address

Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=845546
Build error leg or test failing: Aspire.Playground.Tests.AppHostTests.Aspire.Playground.Tests.AppHostTests.TestEndpointsReturnOk
Pull request: https://github.com/dotnet/aspire/pull/6235

Error Message
Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "Failed to bind to address .*address already in use",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation
Build: :mag_right: https://dev.azure.com/dnceng-public/public/_build/results?buildId=845546
Error message validated: [Failed to bind to address .*address already in use]
Result validation: :white_check_mark: Known issue matched with the provided build.
Validation performed at: 10/17/2024 7:33:49 AM UTC

The instances of this are likely because a previous projects are still running, so we should probably wait for dcp processes to disappear.


Repo sync for protected CLA branch

The pull request is created from master637602404727781738 to master to fix git push error for protected CLA branch

@Taojunshen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


register with an incorrect plugin identifier

Hey.
I want to use the Eufy via Homebridge Adapter in my iobroker.
All configured right, but dont work.
In the Debug i can see:
ham.0
2021-10-25 11:25:27.273	debug	[2021-10-25 11:25:27] Registering accessory<EMAIL_ADDRESS>RoboVac'
ham.0
2021-10-25 11:25:27.273	debug	[2021-10-25 11:25:27] Plugin '@lu7as/homebridge-eufy-robovac' tried to register with an incorrect plugin identifier: 'homebridge-eufy-robovac'. Please report this to the developer!
ham.0
2021-10-25 11:25:27.272	debug	[2021-10-25 11:25:27] Loaded plugin<EMAIL_ADDRESS>ham.0
2021-10-25 11:25:26.542	debug	[2021-10-25 11:25:26] Registering accessory 'homebridge-eufy-robovac.Eufy RoboVac'
ham.0
2021-10-25 11:25:26.540	debug	[2021-10-25 11:25:26] Loaded plugin<EMAIL_ADDRESS>ham.0
2021-10-25 11:25:22.490	info	Install/Update<EMAIL_ADDRESS>ham.0
2021-10-25 11:25:22.489	info	Install/Update<EMAIL_ADDRESS>ham.0
2021-10-25 11:25:22.486	info	Install/Update the following Libraries<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Looks like you loaded https://www.npmjs.com/package/@lu7as/homebridge-eufy-robovac not https://www.npmjs.com/package/homebridge-eufy-robovac
Unsure what this @lu7as version on nom is but it is not me that pushed that.


Remove validation of http headers

What is the purpose of the change

When using http1 in the jdk17 version, it will be automatically upgraded to http2. The server converts the header to the http2 header, causing the validation to fail, so we need to remove the validation for the http header.
Move StreamingHttpMessageListener to org.apache.dubbo.rpc.protocol.tri.h12.

Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

LGTM.


Enable-null-parameters

null cannot be used because native code expect an object, not a pointer.
updating the kernels in native to accepte ptr solve the issue.
This however requires to add a null test inside the native, but not so much an issue because it should be autogenerated.
closes #41

@carlosuc3m
I got the issue about the null. Here have a look and add it to your branch when you want :)


pkg/runtest: make cross-arch failures fatal on CI

When running on Github CI, turn every failure to start a cross-arch binary (e.g. due to missing qemu-user) into a fatal error.

Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

Wonder if it will pass now or not.

Wonder if it will pass now or not.

Haha, it doesn't: https://github.com/google/syzkaller/actions/runs/12178747675/job/33969409075?pr=5575
I'll try to restart to see if the CI was using is a stale Docker container


[2.4.0] DICOM import error Linux

On (at least) the Ubuntu 16 and 18 package from Jenkins, you can't import DICOMs.
To recreate the bug:

Compile your sources on your computer
Create a package, extract it somewhere
Launch MUSIC from the package, DICOM import is ok
Rename your superproject
Relaunch MUSIC from package, and the DICOM import crashs

There is a wrong link somewhere.
This could be linked to https://github.com/Inria-Asclepios/medinria-superproject/pull/68 where DCMTK version changes, and is compiled with c++11. There was a problem with DCMTK links solved in MUSIC.sh.in

MacOS package fails to import DICOMs as well:
Unrecognized component type 0

I think this issue is linked to DCMTK 3.6.2
There is the same issue on medInria3, I guess.
Maybe we should use the old DCMTK or test a new one v3.6.4

Le 16 mai 2019 à 14:45, Mehdi Juhoor<EMAIL_ADDRESS>a écrit :
MacOS package fails to import DICOMs as well:
Unrecognized component type 0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/Inria-Asclepios/medInria-public/issues/563?email_source=notifications&email_token=AF2G3XDGD4RZXUGZ2ZB3OPDPVVJOZA5CNFSM4HNLXV7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRWDIY#issuecomment-493052323, or mute the thread https://github.com/notifications/unsubscribe-auth/AF2G3XHZLZQ26NWOMKYU5U3PVVJOZANCNFSM4HNLXV7A.

ITK provides DCMTK as a module. Maybe we should use that.
 -DModule_ITKDCMTK:BOOL=ON should do the trick.

:o i'm going to test ^^ (this as to be linked to QtDCM however)

NB: solved DCMTK 3.6.2 import problem in https://github.com/Inria-Asclepios/medinria-superproject/pull/75


Cron timezone ci debug

Coverage increased (+2.4%) to 78.998% when pulling 476b5b64653d3f496272ec7ab4fb631196430084 on cron-timezone-ci-debug into c9840e9670d3966bea8bd6f3e4be3b9985fe6764 on main.


[VM] Support instruction either-boxed-or-unboxed input representations

We don't have a Representation that says "either be tagged (Smi) or unboxed". All instructions either take a representation as input or are specialized per instruction:

IntConverterInstr takes a representation as input.
LoadIndexedInstr takes a boolean whether the index is unboxed.
BinaryInt32OpInstr takes unboxed ints, and BinarySmiOpInstr tagged ints.

It would be beneficial to add a new "either be unboxed or tagged" Representation to RequiredInputRepresentation. This would also require doing a non trivial analysis to select the representation that inserts the smallest amount unboxing and int conversion instructions.
Note that this would be the opposite of our wish to completely remove the select-representations phase. (I don't remember who mentioned that wish, I believe it was one of you: @rmacnak @aam @alexmarkov.)
Alternative suggestions to get rid of smi-untag operations welcome.
cc @mraleph
Split out from:

https://github.com/dart-lang/sdk/issues/51031

FWIW we have kNoRepresentation which means instruction accepts any representation as input and it is used in a few places for the instructions which can take either tagged or untagged values. When using kNoRepresentation, code generation for the instruction should check the actual representation of an input and support multiple representations as needed.

FWIW we have kNoRepresentation which means instruction accepts any representation as input and it is used in a few places for the instructions which can take either tagged or untagged values.

I only see that for things that do not get Dart integers as inputs, or don't use the value at all:

ReachabilityFenceInstr doesn't use the value.
LoadIndexedInstr either has a dart object tagged or non dart object untagged (the Dart object is always an array and cannot be unboxed).
LoadCodeUnitsInstr only code objects, so cannot be unboxed.
MaterializeObjectInstr probably also cannot be an integer, and thus cannot be unboxed.
LoadUntaggedInstr also not an int.

code generation for the instruction should check the actual representation of an input and support multiple representations as needed

If we start passing integers, we can start getting all of the unboxed integer representations.
That causes some complications:

If the integer is an int8 or int16, we need to zero out the upper bits before doing something with it
We need different code paths for signed and unsigned ints.
If anyone ever adds a new unboxed representation, that one can flow into the instruction and might hit an assert for the user. So we need to add some compile time checks all are covered in a switch statement or something.

So we'd probably want to have something like kUnboxedInt32OrTagged. However, the downside of that would be that if we have multiple instructions that all support unboxed or tagged, but not the same unboxed int (e.g. int32, vs uint32, vs int64, vs uint64), we still get int converter operations. But when implementing multiple unboxed representations, we can't say in an instruction it prefers a certain size of unboxed int because it would be smaller code.
E.g. MyInstr::RequiredInputReprentation(/*index=*/0) would return: I prefer kUnboxedInt32, if that doesn't work give me kUnboxedInt64, and as a last resort give me kTagged.


presentation mode query parameters not recognized

Query parameters like ?m=all should "show documentation for all declarations, not just the exported ones." However, https://godoc.org/golang.org/x/image/draw/?m=all does not display the unexported type kernelScaler and its method makeTmpBuf.

That query parameter applies to godoc, the command you can run locally. godoc.org doesn’t have it.

godoc.org doesn’t have it.
Has there already been a decision to not include the query parameter on godoc.org?

godoc.org doesn't have any query parameter.


How to deal with recovery middleware?

You said Alice make no garentees with middleware's behaviors,
it will stop the chain when panic,
so how can I make recovery as a middleware?

The net/http server will recover from panics automatically (see the relevant code).
However, if you'd like to roll out your own recovery middleware, it should kick in as early as possible in the request lifecycle. Ideally, it should be the first in the chain.
alice.New(recoveryMiddleware, ...).Then(handler)


Missing gamepad 🎮

Hello! Seems like 🎮 is missing. Curious about it. I'm currently using Windows 11 and I have this emoji available in the system. (the flat version of it)

Closing the issue, looking at the Figma files, it has not been included due to trademarked materials


Add APIs with exposed emitter

Problem:
We are use existing infrastructure of rememberSaveable to persist values in presenter, it requires to provide SaveableStateRegistry via CompositionLocalProvider. Current molecule API only takes composable body which return state. This API is not convenient for our use case.  CompositionLocalProvider can't be used because it do not return value from it's content lambda.
body = {
    CompositionLocalProvider(
        LocalSaveableStateRegistry provides saveableStateRegistry,
    ) {
        presenterComposable() // <- CLP do not return this value
    }
}

Now we use own implementation of CLP that can return value from content lambda:
@Composable
@OptIn(InternalComposeApi::class)
private inline fun withPresenterSaveableStateRegistry(
    content: @Composable () -> State,
): State {
    currentComposer.startProviders(
        values = arrayOf(LocalSaveableStateRegistry provides saveableStateRegistry),
    )
    val state = content()
    currentComposer.endProviders()
    return state
}

But this approach has at least two significant disadvantages:

We use internal compose API, that can change at every moment.
Our CLP recomposes at every composition.

Proposal:
Molecule need alternative API with exposed emitter to be able to handle such cases:
body = { emitter ->
    CompositionLocalProvider(
        LocalSaveableStateRegistry provides saveableStateRegistry,
    ) {
        emitter(presenterComposable())
    }
}

Dunno is it possible to leave trailing lambda syntax for both bodies (with and w/o emitter). This head-on implementation has declaration clash when using trailing lambda. It requires to specify body parameter name to give a hint for compiler which lambda you want to use. Maybe it's possible to do this better, so this is not final code to approve.

We use internal compose API, that can change at every moment.

These APIs cannot ever change without breaking every app in existence. They are internal because normal code should not be using them, but they are used inside inline functions and are thus part of the public API surface of Compose.

Our CLP recomposes at every composition.

What's the cause? Is it due to the array creation inside the composable? Can you hoist that outside so its reference is stable and see if that helps?
Or is it simply due to the fact that Compose doesn't skip functions that return values?

Or is it simply due to the fact that Compose doesn't skip functions that return values?

Yes. To emit new state presenterComposable should be called, but due to it's inside 'our' CLP compose every time run provider code. Hoisting array is not an option.

Hoisting array is not an option.

Why not? What about remembering then?

Why not? What about remembering then?

I mean recomposition of whole provider still happening.


CTAS table delete

Issue #, if available:
#782
Description of changes:
When using the ctas_database_name parameter in the to_parquet method, the temporary table within the CTAS database should be deleted not within the original database.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 88f566eca28bab602582b5635f92ecc324406245
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Nothing seems to be provided to the component

Well so after I've created the provider, made some unit tests for it, now with attempt to actually make it work with component seems it doesn't work for some reason. You can see the provider code in the gist. Here is my component.
const ChooseCity = ReactStamp.compose({
	displayName: 'ChooseCity',
	propTypes: {
		cityName: ReactStamp.PT.string.isRequired,
		locateUser: ReactStamp.PT.func.isRequired,
	},
	render() {
		return (
			<div className={styles.component}>
				<CityInput
					value={this.props.cityName}
					onChange={this.props.locateUser}
				/>
			</div>
		);
	},
});

export default provide(ChooseCity);

Then there is a top level render where I am passing providers like this.

When I look at ChooseCity component there, it has none of those props...

Do you have any idea what might be wrong here?

Ok so I wrapped that top level component into provide as well and that seems to solve issue. This is seriously missing from documentation and it's not even in examples, so it's really strange.

Hmm that is a strange way to use providers, but I guess it works.  😀
The docs say to use react-redux-provide/lib/install, but I agree that it is kind of buried.  I'm also aware that this method makes things kind of ugly in React's dev tools, as it wraps every component, but that's unavoidable right now.  I am trying to get better support for automatic contextual/wrapper components in the next version of React mainly so that the view in dev tools won't look so silly.  Even with every component wrapped with the <Provide/> component, everything is still extremely efficient because it's cached and only updates when state or props change.
But anyway... I made it obvious to use the install method at the top of the README.  👍

That's not really what I am looking for :) I don't want to use install, I just don't like that approach. Is it ok then to wrap that top level component manually with provide? Will it work same way? So far it seems so. In that case it would be nice to mention that in docs as well. In that quick example you do offer 2 methods, but for other method you just don't say about wrapping this top level component.

Yes, I'll add to the README the bit about having to wrap the top level component.  It is necessary so that the providers can be passed down via context from the top.

Yea, I was really confused at one moment realizing that I am passing providers to top level component, but you don't have access to that component from anywhere, so how the hell you could get those into context. So I tried to wrap it and it worked :) I am really looking forward to updated readme and tutorial to get rid of the confusion.


[API GW] Enlarge HTTP Header Size to Unblock Performance Testing

Context
In current API GW, the default value of HTTP header size is 8192 but may result in 413 in one of performance testing scenario when Nova server may query hundreds of device ids.  This PR propose to enlarge the header size to 65536 (64K) which is enough for most cases.

Codecov Report

Merging #465 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #465      +/-   ##
============================================
+ Coverage     36.53%   36.54%   +0.01%
- Complexity     1157     1160       +3
============================================
  Files           452      453       +1
  Lines         10861    10865       +4
  Branches       1393     1393
============================================
+ Hits           3968     3971       +3
- Misses         6350     6351       +1
  Partials        543      543

Impacted Files
Coverage Δ
Complexity Δ

...alcor/apigateway/admin/WebServerConfiguration.java
100.00% <100.00%> (ø)
3.00 <3.00> (?)

...alcor/elasticipmanager/dao/ElasticIpAllocator.java
63.53% <0.00%> (-0.28%)
48.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f17f0...0f99bf1. Read the comment docs.


Object.assign not polyfilled

This package breaks in IE 11 due to it's unpolyfilled use of Object.assign.
It is risky to rely on Next.js to apply a global polyfill, because its not guaranteed - in v3 latest it is not present:

This issue can be resolved by refactoring all usage of Object.assign to spread operator syntax. It's more elegant that way anyway.

This is now fixed with new babel presets.


FAQ Update: Disabling Activity Map

Issue in ./help/analyze/activity-map/activitymap-faq.md
Can we please add an FAQ update describing how to disable Activity Map once it is turned on? This comes up frequently, and I believe the only option might be a Client Care ticket.

We can certainly do that, @jtwood426 . I posed your question to Engineering and will get back to you.


http

in the website the following error is showing
The URL has been blocked as per the instructions of the Competent
Government Authority/ in compliance to the orders of Court of Law
On Sun, Sep 29, 2019 at 8:04 PM Arun Sasidharan<EMAIL_ADDRESS>wrote:

Closed #99 https://github.com/esoxjem/MovieGuide/issues/99.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/esoxjem/MovieGuide/issues/99?email_source=notifications&email_token=ACVBIUNNGAIPOSLDM2BVAEDQMC4H5A5CNFSM4I3PBQ2KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOT44BNHY#event-2671253151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACVBIUNAS4OUOM4JTK6S32LQMC4H5ANCNFSM4I3PBQ2A
.

--
Wih Best Regards ...
Sairam Gupta Taduvai.


When only one person reacts , it shows "You and 0 others"

When only one person reacts, it shows "You and 0 others" but I don't want to show " and 0 others"  if there's one  reaction
So can you remove it or give options to remove it

Hey! Thanks for the suggestion. I think making it an option would be great.
I could add that feature tomorrow, or if you'd like it before then or if you want to make a PR, just let me know!

Ran out of time to add this feature today. Sorry

Live on v0.4.0


canDeactivate not working properly

Here's a simple example, using react-router5 stackblitz. The compose route should be prevented from deactivating, but it isn't.
https://stackblitz.com/edit/react-router5-hqt5jr?file=index.js
Also, are you suppose to be able to set canDeactivate on your initial array of routes alongside name, path, etc.?

No idea why the example is broken, but I'm lacking time to be able to look at it. So PR welcome.

Also, are you suppose to be able to set canDeactivate on your initial array of routes alongside name, path, etc.?

No, it's not supported.

Had the same problem:
You need to set "forceDeactivate: false" in the browserPlugin and "autoCleanUp: false" in the router config.
The doc says something like "not recommended to set forceDeactivate to false" but does not state why. And it is not clear to me what benefit it has to clear "canDeactivate" functions after each transition by default (autoCleanUp: true).

canDeactivate is not a great idea, because of how browser history works. The documentation and the feature are not very clear, and things like autoCleanUp are very early choices of this project. I'll see what can be done for the next batch of breaking changes (v7).

(Closing for now).


c++ not support

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

Did you consider consulting the documentation?
https://code.visualstudio.com/docs/languages/cpp


Add option to enable dark mode

fixes: #341
What's wrong ?
If a user has his preferences set to dark mode, but the website using docs-searchbar don't have support for dark mode, the website will appear in light mode except for the searchbar, which will appear in dark mode.
What's inside this PR
This PR adds an option enableDarkMode to allow users enable dark mode on the searchbar. It is set to false by default.
How to test
To switch between dark and light mode, go to System Preferences in your mac and then General.
To run the project:  yarn && yarn playground and go to http://localhost:1234/
You can also try the searchbar with the option layout: simple if you want to !
Light mode
Just run the project, and switch between light & dark mode in your system preferences.
Dark mode
Go to the project, and add enableDarkMode: true to the playground you want to use.
Example in playgrounds/html/index.html :

Screenshots
Light mode:

Dark mode with enableDarkMode set to true:

Dark mode without enableDarkMode:

dark background kept to show that the dark mode is enabled in user's system preferences
show that even in dark mode, the searchbar is displayed in light mode if enableDarkMode isn't set

bors try

bors try

bors try

bors merge


Wrong suggestion order from hfst-ospell-office

$ echo '10 Jijtjsasse'| hfst-ospell-office sma.zhfst
@@ hfst-ospell-office is alive
&	Jiutjasse	Ji-jyjsese	Ji-jïjsese	Ji-jijsese	J-jyjsese	J-jïjsese	J-jijsese	Jïjtsasse	Jïjtjese	Jijsese

Expected: all hyphenated suggestions coming last, as they are heavily weighted compared to the other suggestions, as seen by plain hfst-ospell (input lower-cased because it doesn't do case folding):
$ echo 'jijtjsasse'| hfst-ospell -S sma.zhfst | head -n 14
"jijtjsasse" is NOT in the lexicon:
Corrections for "jijtjsasse":
jïjtsasse    15.497070
jïjtjese    30.594690
jijsese    40.495079
j-jyjsese    20094.496094
j-jïjsese    20094.496094
j-jijsese    20097.496094

And with upper-case input (but then missing some suggestions):
$ echo 'Jijtjsasse'| hfst-ospell -S sma.zhfst | head -n 10
"Jijtjsasse" is NOT in the lexicon:
Corrections for "Jijtjsasse":
Jiutjasse    43.495079
Ji-jyjsese    10099.495117
Ji-jïjsese    10099.495117
Ji-jijsese    10102.495117
J-jyjsese    20094.496094
J-jïjsese    20094.496094
J-jijsese    20097.496094

divvunspell does case folding, and returns the following, in the expected order (divvunspell presently requires an uncompressed, just zipped zhfst file, thus the slightly different filename):
$ echo Jijtjsasse | divvunspell -s -z sma-nocomp.zhfst | head -n 12
Reading from stdin...
Input: Jijtjsasse		[INCORRECT]
Jïjtsasse		15.49707
Jïjtjese		30.59469
Jijsese		40.49508
Jiutjasse		43.49508
Ji-jyjsese		10099.495
Ji-jïjsese		10099.495
Ji-jijsese		10102.495
J-jyjsese		20094.496
J-jïjsese		20094.496
J-jijsese		20097.496

The zhfst file is attached.
sma.zhfst.zip

With the new debug option in hfst-ospell-office, it is now easier to see what is going on. Consider the following case in SME:
echo '10 Legenbargu' | hfst-ospell-office -d se.zhfst
@@ Loading se.zhfst with args max-weight=-1.00, beam=-1.00, time-cutoff=6.00
@@ hfst-ospell-office is alive
&	Legen-bargu (20135.30)	Lege-bargu (20165.30)	Leggenbargu (54.30)	Levgenbargu (57.30)	Liggenbargu (57.30)	Láhkenbargu (57.30)	Leggenbargui (69.30)	Leđgenbargu (69.30)	Leŋgenbargu (69.30)	Leggenbarggu (69.30)

That is, the two first suggestions have a very high weight and should not be on top - most likely they should not be given at all, since I asked for 10 suggestions.
Using the same .zhfst file, I get the following using divvunspell:
echo Legenbargu | divvunspell suggest -a se.zhfst
Reading from stdin...
Input: Legenbargu		[INCORRECT]
Leggenbargu		79.3018
Levgenbargu		82.3018
Liggenbargu		87.3018
Láhkenbargu		92.3018
Leđgenbargu		94.3018
Leŋgenbargu		94.3018
Leggenbarggu		99.3018
Leikenbargu		99.3018
Leggenbargui		109.3018
Leggenbárkku		110.3018

(weights are different from hfst-ospell-office because of additional positional penalties).
Using hfst-ospell I get the following:
echo 'legenbargu' | hfst-ospell -S se.zhfst
"legenbargu" is NOT in the lexicon:
Corrections for "legenbargu":
leggenbargu    54.301800
levgenbargu    57.301800
liggenbargu    57.301800
láhkenbargu    57.301800
leggenbargui    69.301804
leđgenbargu    69.301804
leŋgenbargu    69.301804
leggenbarggu    69.301804
leikenbargu    69.301804
leggenbárkku    70.301804
leggenbárku    70.301804
leggenbargi    84.301804
loggenbargu    84.301804

echo 'Legenbargu' | hfst-ospell -S se.zhfst
"Legenbargu" is NOT in the lexicon:
Corrections for "Legenbargu":
Legen-bargu    20135.302734
Lege-bargu    20165.302734

The expected output should be strictly ordered according to weight, if identical weight it should be as given by fst (which is usually alphabetically ordered).
The speller file is attached.
se.zhfst.zip

hfst-ospell-office's output is from multiple sources.
Legen-bargu (20135.30)	Lege-bargu (20165.30) are based on the verbatim input Legenbargu.
Leggenbargu (54.30)	Levgenbargu (57.30)	... are based on the case-folded legenbargu and then recased to first-upper.
I would argue suggestions generated from the verbatim input should come before suggestions generated from mangled input, but that is a considerable weight difference.
Maybe something like giving the mangled outputs increasing penalties before doing a global sort. That would still give the desired output for this case, but preserve the semantic that verbatims ought to be worth more.

Implemented, and also added the mangling level to the debug output. Did not close the issue, as this behavior is up for debate.

Here's another case in support of the change, this time from SMA.

input: Jalh
expected correction: Jallh

Using hfst-ospell-office before the change (output linewrapped for better readability):
echo '25 Jalh' | hfst-ospell-office -d sma.zhfst
@@ Loading sma.zhfst with args max-weight=-1.00, beam=-1.00, time-cutoff=6.00
@@ hfst-ospell-office is alive
&	Aalh (32.50)	Jaah (37.50)	Jaloh (42.50)	Jauh (42.50)	Jayh (42.50)\
	Valh (42.50)	Lalh (42.50)	Jarlh (42.50)	Janh (42.50)	Jarh (42.50)\
	Julh (42.50)	Jalo (42.50)	Jillh (52.50)	Ji:h (87.50)	J-aalh (10109.50)\
	Jallh (20.67)	Jah (30.65)	Javlh (32.50)	Jaljh (32.50)	Jalkh (32.50)\
	Jïllh (42.50)	Jollh (42.50)	J-aalh (20109.50)

The expected correction has the lowest weight, but is suggestion nr 16.
Using the newest/updated hfst-ospell-office:
echo '25 Jalh' | hfst-ospell-office -d sma.zhfst
@@ Loading sma.zhfst with args max-weight=-1.00, beam=-1.00, time-cutoff=6.00
@@ hfst-ospell-office is alive
&	Jallh (20.67;1)	Aalh (32.50;0)	Jah (30.65;1)	Aalh (32.50;1)	Jaljh (32.50;1)\
	Jalkh (32.50;1)	Javlh (32.50;1)	Jaah (37.50;0)	Jalo (42.50;0)	Jaloh (42.50;0)\
	Janh (42.50;0)	Jarh (42.50;0)	Jarlh (42.50;0)	Jauh (42.50;0)	Jayh (42.50;0)\
	Julh (42.50;0)	Lalh (42.50;0)	Valh (42.50;0)	Jollh (42.50;1)	Jïllh (42.50;1)\
	Lalh (42.50;1)	Valh (42.50;1)	Jillh (52.50;0)	Ji:h (87.50;0)	J-aalh (10109.50;0)

Now the expected correction is on top.
The speller sma.zhfst file is attached.


pubsub: Messages acked after 30 minutes are duplicated

I'm currently working with support (Case 14709699) but thought I'd post here in case it's a problem with the driver. We've having an issue where every single message on a subscription is duplicated immediately. The messages on this subscription take a longer time than our other subscriptions so I'm inclined to think that the time it takes to ack is causing the problem. Additionally, when we ack it for the second time (in milliseconds because we already received it) it doesn't get duplicated anymore.
I added a log at the top of our receive callback and another at the end with a "success" int indicating if it was ack'd or nack'd.
First example: took 33 minutes and 4 seconds to ack and then immediately received same message again). This was verified by publishing a single message to the topic and monitoring the backlog via Stackdriver to ensure that there was ever only 1 message in the subscription. Then we immediately got it again with the same messageID. We nack'd the second message because of an application error on our side.
Jan 17 22:56:47: ~ INFO -- Got pubsub message -- messageID="22585984507129" messageSubscription="gce-us-east1_deferrer_Replicator.Replicate_deferrer_worker" messageTopic="gce-us-east1_deferrer_Replicator.Replicate"
Jan 17 23:29:52: ~ INFO -- Finished pubsub message -- duration="33m4.901046089s" messageID="22585984507129" messageSubscription="gce-us-east1_deferrer_Replicator.Replicate_deferrer_worker" messageTopic="gce-us-east1_deferrer_Replicator.Replicate" success="1"
Jan 17 23:29:52: ~ INFO -- Got pubsub message -- messageID="22585984507129" messageSubscription="gce-us-east1_deferrer_Replicator.Replicate_deferrer_worker" messageTopic="gce-us-east1_deferrer_Replicator.Replicate"

We then immediately got the message again and nack'd it again (because of that same error), but then never received the message again and Stackdriver shows that it was removed from the backlog (despite being nack'd).
Jan 17 23:29:52: ~ INFO -- Got pubsub message -- messageID="22585984507129" messageSubscription="gce-us-east1_deferrer_Replicator.Replicate_deferrer_worker" messageTopic=
"gce-us-east1_deferrer_Replicator.Replicate"

This was tested with:
sub.ReceiveSettings.MaxOutstandingMessages = 1
sub.ReceiveSettings.MaxExtension = time.Hour * 5

The receive function simply just makes an HTTP request with the payload and then either ack's or nack's based on the response. We're not setting any options or anything special on the client. This was tested running the latest master version of this package:
cloud.google.com/go (git) - 31bbc66 pstest: misc small changes

Let me know if there's any more information I can provide.

Hi @fastest963. We believe your issue is related to firewalls closing long-lived connections after 30m. When a long-lived connection is closed, the server considers the message nacked, even if you had set the deadline to 5 hours from now.
Our recommendation for messages that take >30m to process is to use the lower-level client in a pull model instead of the higher-level client's stream model. Here's an example of that.

@jadekler thanks for the clarification. That does sound like the issue. Does the firewall still close the connection even if there's traffic over it? I would've thought the continuous ModAck packets would keep the connection alive.

@jadekler thanks for adding the example, I've taken your example and worked it into one of our applications. Is that model not intended to be a long term solution? If it is, is there any chance of getting it more integrated with the pubsub driver and not relying on the underlying v1 implementation? We lose a lot of functionality (in NewClient and Message in particular) that needs to be duplicated because of it using the v1 package.

I'm sorry, we don't have plans to integrate it into the main client.
Your application might be more suited to Cloud Tasks than PubSub. You can sign up for the Cloud Tasks alpha here.


Command Line Tools Installation Fails on OS X 10.12.3

Possibly because of the new System Integrity Protection in place since OS X El Capitan, the command line tools can't be installed to /bin. I haven't tried to install without SIP, so I can't comment on whether or not that works. Installing to /usr/local/bin would be one workaround.

What's the error you get?

Error message: "'hexf' couldn’t be copied because you don’t have permission to access “'bin'. To view or change permissions, select the item in the Finder and choose File > Get Info."
Even with SIP disabled and modifying Finder permissions to allow Everyone to read and write to /bin, the error message continued.

Does /usr/local/bin already exist?

It does on my system because some packages have installed binaries there, but I don't think it does in a fresh system install.

I think it's just referring to the last path component "bin".
Can you run this command, and post the output?
ls -ald /usr/local/bin

For me it looks like this:
drwxr-xr-x  298 kainjow  admin  10132 Mar  1 14:28 /usr/local/bin

drwxr-xr-x  59 root  wheel  2006 Mar 30 23:55 /usr/local/bin

Well that explains it, it's owned by root. You could try sudo chown $USER /usr/local/bin

Fixed.


Banned Tribe is hard to see on mobile

I think that it would be a great option to give user ability to choose between classical banned tribe and showing picture over deck with banned tribe.
example

example icons you can use (thanks to AgraveiN from twitch)
ikonkihs.zip

its possible now


Development/Contributor Documentation

This project looks really exciting, and I would love to make an attempt at contributing! It'd be wonderful if there was some documentation about how to build/start working on the project.

Thank you for your support! We're not quite ready for this but I'll make some documentation as soon as possible. Thank you!

Wonderful! Looking forward to it. :)

I'm going to keep this open as a to-do for myself.

I've added a contributing document and have tagged some suitable issues
https://github.com/lpil/gleam/blob/master/CONTRIBUTING.md
https://github.com/lpil/gleam/issues?q=is%3Aissue+is%3Aopen+label%3A"good+first+issue"
Please open a new issue if you can think of ways to improve this! Thank you

Awesome! Thanks for following up on this :)

No problem!


Running the westeros_baseline tutorial

Dear Admin,
I have been encountering issues running the westeros_baseline tutorial.  The second line of the westeros_baseline tutorial python model, that is - mp = ixmp.Platform() an error message came-up while running it, it showed:
RuntimeError                              Traceback (most recent call last)
 in
----> 1 mp = ixmp.Platform()
~\anaconda3\lib\site-packages\ixmp\core.py in init(self, dbprops, dbtype, jvmargs)
76             # if no dbtype is specified, launch Platform with properties file
77             if dbtype is None:
---> 78                 dbprops = default_dbprops_file() if dbprops is None
79                     else find_dbprops(dbprops)
80                 logger().info("launching ixmp.Platform using config file at '{}'"
~\anaconda3\lib\site-packages\ixmp\default_paths.py in default_dbprops_file()
5
6 def default_dbprops_file():
----> 7     return config.get('DEFAULT_DBPROPS_FILE')
8
9
~\anaconda3\lib\site-packages\ixmp\config.py in get(key)
17     if key not in data:
18         raise RuntimeError(
---> 19             '{} is not configured, do so with $ ixmp-config -h')
20
21     return data[key]
RuntimeError: {} is not configured, do so with $ ixmp-config -h
The error has hinder me from running other part of the model.
I have tried to use the ixmp-config but couldn't get through to the solution.
Help is therefore needed at this point.
Thank you.

This is a question, not an issue, and should be in message_ix, not message-ix-models. I'll attempt to transfer it.