db.AutoMigrate with database schemas -> ERROR: syntax error at or near "$1" (SQLSTATE 42601)

Description
I have been working during a personal project without problems. I created several tables with the customization of the name of the database schema, the tables are related to each other; the database is Postgresql. When executing the go run main.go command, the tables are created in the correct database schema with the correct relationships.
So I updated the GORM version and when I executed go run main.go I observed a syntax error when updating a CONSTRAINT in the DB.
Replicate the error:
Create two related models
type TableOne struct {
	ID       uint64 `json:"-" gorm:"primary_key;auto_increment"`
	TableTwo *TableTwo
}

type TableTwo struct {
	ID         uint64 `json:"-" gorm:"primary_key;auto_increment"`
	TableOneID uint64
}

Then TableName overrides the table to support the names of the database schemas. The name of the database schema is: "sujeto"
func (TableOne) TableName() string {
	return "sujeto.table_one"
}

func (TableTwo) TableName() string {
	return "sujeto.table_two"
}

After making the configurations to the database, we proceed with the migration of the models to the DB.
db.AutoMigrate(
	&entity.TableOne{}, &entity.TableTwo{},
)

The first time go run main.go is executed, it executes without errors and the tables are created in the DB with their relationships. But the next times go run main.go is executed, the following message will be displayed:
ERROR: syntax error at or near "$1" (SQLSTATE 42601) [0.138ms] [rows:0] ALTER TABLE '{"sujeto"."table_two" [] false}' ADD CONSTRAINT "fk_sujeto_table_one_table_two" FOREIGN KEY ("table_one_id") REFERENCES "sujeto"."table_one"("id")
Could you tell me if things are being done correctly or in what way can we correct the syntax error?

@edubudubolo did you manage to solve this issue? Im having the same problem.

No, this question was not answered. Before it worked perfectly now we must drag this error.

To report an issue, please create a reproducible playground PR.

Playground runs under Docker and my environment doesn't support it because of my current settings (can't have Virtualbox and Docker at the same time).
I'm having the same problem.
Can anyone create a playground PR?
I really need this fixed :(
type Device struct {
	ID               uint `gorm:"primaryKey"`
	CreatedAt        time.Time
	UpdatedAt        time.Time
	Name             string
	OwnerID          uint   `gorm:"not null"`
	Version          string
	Updatable        bool          `gorm:"default:false"`
	Active           bool          `gorm:"default:true"`
	Charts           []charts.Line `gorm:"-"`
	ModelID          uint
	Sensors          []Sensor `gorm:"many2many:device_sensor;"`
}

func (Device) TableName() string {
	return "device.device"
}

type DeviceModel struct {
	ID        uint `gorm:"primaryKey"`
	CreatedAt time.Time
	UpdatedAt time.Time
	Name      string
	Version   string
	Active    bool     `gorm:"default:true"`
	Devices   []Device `gorm:"foreignKey:ModelID"`
}

func (DeviceModel) TableName() string {
	return "device.model"
}

if err := db.AutoMigrate(
		&entity.DeviceModel{},
		&entity.Device{},
                ...
	); err != nil {
		fmt.Println("Migration failed!")
		log.Fatal(err.Error())
	}

Error:
ALTER TABLE '{"device"."device" [] false}' ADD CONSTRAINT "fk_device_model_devices" FOREIGN KEY ("model_id") REFERENCES "device"."model"("id")
ERROR: syntax error at or near "$1" (SQLSTATE 42601)

Rolling back to v1.20.8 fixed the issue for me.

@maxzaleski yes your solution is the right, at least until @jinzhu  fixes it in the new version.
The command is:
go get<EMAIL_ADDRESS>

Then the postgres dependency is downloaded automatically when executing the command:
go run main.go

I don't have any issue on my local with
	gorm.io/driver/sqlserver v1.0.6
	gorm.io/gorm v1.21.3

type TableOne struct {
	ID       uint64 `json:"-" gorm:"primary_key;auto_increment"`
	TableTwo *TableTwo
}

type TableTwo struct {
	ID         uint64 `json:"-" gorm:"primary_key;auto_increment"`
	TableOneID uint64
}

func (TableOne) TableName() string {
	return "sujeto.table_one"
}

func (TableTwo) TableName() string {
	return "sujeto.table_two"
}

func TestGORM(t *testing.T) {
	fmt.Println(DB.Migrator().DropTable("sujeto.table_one"))
	fmt.Println(DB.AutoMigrate(&TableOne{}))
}

To report an issue, please create a reproducible playground PR.

@jinzhu  Try the same example, but using a database in postgresql

@jinzhu Try the same example, but using a database in postgresql

that's what I am doing.

@jinzhu  I have done the tests with various combinations of libraries, and I have discovered that the problem is in the postgresql library, because I have tried with this configuration and I have obtained the error of the description.
gorm.io/driver/postgres v1.0.8
gorm.io/gorm v1.21.3

I have got the following error:
ERROR: syntax error at or near "$1" (SQLSTATE 42601)
[0.296ms] [rows:0] ALTER TABLE '{"sujeto"."table_two" [] false}' ADD CONSTRAINT "fk_sujeto_table_one_table_two" FOREIGN KEY ("table_one_id") REFERENCES "sujeto"."table_one"("id")
[GIN-debug] [WARNING] Running in "debug" mode. Switch to "release" mode in production.

I have changed the postgresql library to a previous one and everything has worked fine, the configuration is
gorm.io/driver/postgres v1.0.6
gorm.io/gorm v1.21.3

It is evident that the problem is in the way the table name is built, I replaced the name this name '{"sujeto"."table_two" [] false}' by the name of the table to be affected and the command was executed fine.
 The first time the tables are created correctly, the second time, when the two tables are already created in the DB, and still execute db.AutoMigrate(&entity.TableOne{}, &entity.TableTwo{}) the error occurs


omega.generate_conformers fails for certain combinations of MMFF atom types; probably should default to 'loose' checking

There are many cases in which Omega will fail to generate conformations (after version 2.4.0) for small molecules due to missing MMFF parameters - basically it is "strict" about MMFF atom typing by default (since that version) and if an atom type is not present in MMFF it will fail to generate a conformation with a warning. Currently this is for some reason NOT caught by the exception handling in omega.generate_conformers.
An example such molecule (there are many more, but here's the one I have on hand) is:
B(c1cc[nH]n1)(O)O
Code snippet:
`

mol2 = OEMol()
OEParseSmiles(mol2, 'B(c1cc[nH]n1)(O)O')
True
gaff2xml.openeye.generate_conformers(mol2)
Warning: no MMFF bend parameters for atoms 1 2 6
Warning: force field setup failed due to missing parameters for molecule`

My fix is twofold (half of which I have right now):

Add an optional argument to generate_conformers which turns ON strict atom typing (as discussed here - search for "SetStrictAtomTypes": https://docs.eyesopen.com/toolkits/python/omegatk/OEConfGenClasses/OEOmega.html) so that the nearest MMFF atom type will be used in these cases. In my view the default strictness level should be False (not strict) for our purposes. Otherwise, conformer generation will fail on essentially any large general database of compounds, as there are far too many cases not perfectly covered by MMFF.

Fix the issue with exception handling. (Also, check whether the same issue of exception handling applies to the charge calculation function).

I can easily submit a pull request which will do the first of these, but I have to troubleshoot the second still.

 Apparently I was using the version of gaff2xml installed via conda, which is apparently NOT the same one whose code I was looking at. The conda version does not have exception handling in the code, hence the silent failure. The current github version is fine.
So, only the first issue above is a 'real' issue. Though, maybe you need to set it so conda will pull down the more recent version?
I'll submit a pull request to fix the first issue above.

#98 submitted.

Once we finish this pull request and the name change, I will roll out a new release and build some new conda packages.


Doesn't Work on Solutions in Directories with Spaces

I saw this in my "Extension Host" log
2023-09-08 16:07:50.235 [error] SyntaxError: Unexpected token 'E', "
Error: Unk"... is not valid JSON
	at JSON.parse (<anonymous>)
	at updateSolutionModel (c:\Users\ssarette\.vscode\extensions\avaloniateam.vscode-avalonia-0.0.17\out\services\solutionParser.js:62:23)
	at Socket.<anonymous> (c:\Users\ssarette\.vscode\extensions\avaloniateam.vscode-avalonia-0.0.17\out\services\solutionParser.js:98:13)
	at Socket.emit (node:events:513:28)
	at addChunk (node:internal/streams/readable:324:12)
	at readableAddChunk (node:internal/streams/readable:297:9)
	at Readable.push (node:internal/streams/readable:234:10)
	at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

Dug into it a bit to find the cause...
Error: Unknown command 'Thing'.

       c:\Users\ssarette\work\repos\Example Thing  3\Proj\Example.sln
                                            ^^^ No such command

Could you try using the v0.0.18?
You can download it from the release here https://github.com/AvaloniaUI/AvaloniaVSCode/releases/tag/v0.0.18
install it manually in the VS Code

Please reopen if you continue to have an issue


MddBootstrapAutoInitializer.cpp: error C3861: 'exit': identifier not found

I use 1.0-preview3  to create new project and then move old project files to new project.
when finnaly compiling, the flowing error appeared ,  I am very confused!

@Scottj1s exit() is a C API. Should this be ExitProcess() to minimize dependencies?
Or should the autoinitializer be replaced by inline-code in the XAML generated main?
Or the WinUI generated main have an optional callout at its start to PreMain? That can be done without adding a new source file to compile e.g.
#if __has_include(<WinUI-Main-Extensions.h>)
#define __USE_WINUI_MAIN_EXTENSIONS 1
#else
#undef __USE_WINUI_MAIN_EXTENSIONS
#endif

main()
{
...
#if defined(__USE_WINUI_MAIN_EXTENSIONS)
    const auto hrWinUIMainExtension{ WinUI::Main::Extension::PreMain() };
    if (FAILED(hrWinUIMainExtension))
    {
        ExitProcess(hrWinUIMainExtension);
    }
#endif

and  the autoinitializer logic can move into WinUI-Main-Extensions.h e.g.
namespace WinUI::Main::Extension
{
HRESULT PreMain()
{
    ...call MddBootstrapInitialize()...
}

HRESULT PostMain()
{
    MddBootstrapShutdown();
    return S_OK;
}
}

Perhaps just make the main change and update templates to provide WinUI-Main-Extensions.h like above? That wouldn't be XAMLgenerator just a file in a project so not overwritten if/when the generator's re-run. This way devs could alter that if/when they choose (and do other things if they need).

@ShashankNay - looks like replacing exit() with failfast still needs to be done

I like the idea of a #if __has_include(...) as a developer hook for overriding error handling behavior - @ShashankNay, let's discuss.  One approach is to use a function template to provide default behavior (DebugBreak, MessageBox, etc), and allow the developer to 'override' that with a non-templated function via #if __has_include inclusion.


Public API stabilization and documentation

[x] #164
[x] #165
[x] #166
[x] #188

Docs - References section of README
https://github.com/macder/medusa-fulfillment-shippo#references
NOTE: missed change log entry in 0.16.0
useClient property moved from shippoFulfillmentService to shippoClientService
https://github.com/macder/medusa-fulfillment-shippo/blob/49fcb1008097ba4bbdcab8504ead7b819a2ad3a4/src/services/shippo-client.js#L15

Done, although more methods and doc will be added on an ongoing basis


Remove "THIS CODE IS GENERATED" comments (#218)

Description
Removed comments that said the code is generated. Unfortunately generating java client from smithy spec is not possible yet
https://github.com/awslabs/smithy/issues/102#issuecomment-1267321093
Should this be removed as well?
https://github.com/opensearch-project/opensearch-java/blob/f8d9a5e0ac4ad4c5047d081b7da24feb0587bea2/config/checkstyle/checkstyle_suppressions.xml#L39-L43
Issues Resolved
Closes #218
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The three line additions are coming from adding end of line at end of few files.

https://github.com/opensearch-project/opensearch-java/pull/235/files#diff-af65dcb0cbde2b9281acf79ab748b295ba4e8706938851dbc369dc41d97efdfb
https://github.com/opensearch-project/opensearch-java/pull/235/files#diff-297be9b3c5f0513c74e5b6c2d97ae7f10778b6e023303c716229005bc087ff86
https://github.com/opensearch-project/opensearch-java/pull/235/files#diff-4af3908c346925783d425653507de8ec3617d6f0cf362e8d16bc3f7d01d3ebf9

Thanks @AarjavP for opening up this PR. @VachaShah @harshavamsi for my learning do know the history ?

Thanks @AarjavP for opening up this PR. @VachaShah @harshavamsi for my learning do know the history ?

My understanding is that the Java client along with a few others (rust?) were generated from elastic spec. We don't generate from spec anymore. I think it makes sense to remove these lines for the sake of transparency.
@AarjavP for context, you're right that we can't generate the java client from the smithy spec but we have successful internal prototypes of generating smithy specs from model and using the JSON AST to convert that to OpenAPI and use the openapi-generator to generate clients. We're in the process of publishing our findings.

just curious, where will I be able to find that report? Will it be a blog post?
I did try out generating a kotlin client but I dont think it generated all the models that this library currently has. Haven't looked into it further if there's help needed in writing additional smithy files, I can give it a shot!

My understanding is that the Java client along with a few others (rust?) were generated from elastic spec. We don't generate from spec anymore. I think it makes sense to remove these lines for the sake of transparency.

Hi @AarjavP thank you for opening this PR! To answer your question, we have opensearch-api-specification repository in which we are developing Smithy models to generate Smithy and OpenAPI specs. Please take a look :)

Sure I can separate them, how would you like it to be done? multiple commits in single PR or separate PRs? And separate the changes by package? or do you have certain top level packages in mind?

Sure I can separate them, how would you like it to be done? multiple commits in single PR or separate PRs? And separate the changes by package? or do you have certain top level packages in mind?

I think separate PRs would be helpful. I don't have preferences for the packages, but maybe divide them according to the number of files they have?


Geocode offices that were missing coordinates

Came across these sort of by accident yesterday. My app geocodes any offices that are missing the coordinates and by chance I noticed these during an update

Looks like these are all for locations without addresses. I'm not sure there's value in geocoding to city/zipcode centroids which aren't actually places people can go.

@tcarobruce That makes sense, I hadn't really noticed tbh. I was viewing them in a diff on the shell that cut off those fields, and I didn't take notice when I made the additions to the file.
I will say though that for our application there is value in having coordinates for every location even if it's a city centroid, though it's probably an uncommon use case. We sort the offices by distance to the requesting location, so that the most local offices/numbers are at the top of the list.
However, we definitely don't need to have those coordinates in the raw data, we can get by just fine geocoding the outliers on demand in our own database.
If it's not useful or even counter productive for others I'm happy to close this PR


Ignore __MACOSX directory for export template and project ZIPs

macOS's Archive Utility (built-in ZIP file creator) apparently adds a secret __MACOSX directory to the files it zips. When Godot is unzipping archives it expects to have a specific structure, the presence of the __MACOSX directory and its subfiles can confuse it. For example, a macOS-zipped export templates file could not be imported because Godot was finding a dummy version of version.txt within __MACOSX.
This PR causes the export template importer and the project importer to skip any files in a zipped archive whose paths begin with __MACOSX. I've tested this with both a macOS-zipped export template file and a macOS-zipped project.

Looks good! Could you squash the commits? See PR workflow for instructions.

Done! 😄

Thanks!


Add separate contributing page for new users in Getting started or Community on website.

As per CNCF assessment To fulfill this  criteria we must need Contributing and Your First Contribution section on our website. We can give general instructions here as

Link of Contributing.md
Ask them to work on existing issue first (e.g. good first issues)
Report any security related issue here

As an example we can see helm project's Your First Contribution section.

As per discussion here. I will raise a PR for this.


Document how Noir projects could better support GitHub Codespace using devcontainer.json

Problem
Development containers are very useful for smoothening developer experience of Noir projects, especially when paired with GitHub Codespace.
But we do not currently provide instructions on how to make use of Noir with the technology.
Happy Case
### Pending
- [ ] https://github.com/noir-lang/noir-starter/issues/67
- [ ] https://github.com/noir-lang/noir-starter/issues/68

Once the pending issues are closed, noir-example would serve as an example of how devcontainer.json could be implemented in Noir projects.
This issue should document:

The content of devcontainer.json
How to use it in Noir projects (copy-pasting and necessary modifications, if any)
How to use it with GitHub Codespace

in the Noir Docs.
Would you like to submit a PR for this Issue?
No
Support Needs
No response

@signorecello would you like to take this up?

Yep I'll take it from here 👍


Update cats-effect-testing-specs2 to 0.5.0

Updates com.codecommit:cats-effect-testing-specs2 from 0.4.2 to 0.5.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.codecommit", artifactId = "cats-effect-testing-specs2" } ]

labels: test-library-update, semver-minor

Superseded by #228.

Superseded by #228.


View and edit packed files

It'd be nice to have the ability to view, add and remove files packed into the BSP. Right now this can only be done using the bspzip command line tool. I was considering writing a Qt tool in-engine to do this, however lumper seems like a better fit for such a thing (plus it's open source!)

feat/pakfileUI, BIRD's current WIP branch seems to be working on this. Though yeah, we didn't actually really have an issue for this. So, it's coming!

Just saw the PR, good stuff!


[Metrics] Selected Metrics: List Metrics

List the selected metrics in Metrics Explorer under the Selected Metrics header. Selected metrics should be removed from where they were previously (Recently Created Metrics or Available Metrics) and added to the Selected Metrics header.

Fixed by #1211


perf: reduce task structs memory size

Summary
TaskResult size 392 -> 16

Test Plan
Not need.

!bench

!bench

!bench


Not appending to end of linked list correctly?

Hi I am reading money's source code and am confused in following block
line 64 - 67 in threaded_engine.cc
head_->next = new_var_block;
head_->trigger = opr_block;
head_ = new_var_block;
Is this trying to append a new_var_block to head? why the last line is not head_ = head_ -> next?

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


The force_database_error is cached sometimes

EdgeDB Version: 3.0-dev.7249+local

Steps to Reproduce:
edgedb> select 1;
{1}
edgedb> # Here I modify schema in incompatible way and wait until watch picks up the change
edgedb> select 1;
{1}
edgedb> select 1+1;
edgedb error: WatchError: error when trying to update the schema.
  Original error: SchemaError: property 'kaNBORKcOQ' of object type 'vSvnXEUmQu::atyyiNKARe' cannot be cast automatically from scalar type 'std::str' to scalar type 'std::int32'
  Hint: see the window running `edgedb watch` for more info
edgedb> select 1;
{1}
edgedb>

So it looks like the query is cached. (note: erroneous query is not cached, so when error is cleared queries got executed normally).

Interesting: this seems to happen with configure instance but not with configure current database, and seems to be true of all affects_compilation configuration flags if they are changed on an instance level

edgedb> select 1;
{1}
edgedb> configure instance set force_database_error :=
.......   '{"type": "SchemaError", "message": "error!"}';
OK: CONFIGURE INSTANCE
edgedb> select 1;
{1}

It also happens with stuff like apply_access_policies.
It seems a little dodgy to be setting this kind of affects_compilation setting on instance instead of on current database or session, so we could maybe disallow it.
We could also probably just fix it, though I haven't looked into why it is going wrong.

There's also this fun bit:
edgedb> \set print-stats detailed
edgedb> select 1;
....... configure current database set force_database_error :=
.......   '{"type": "SchemaError", "message": "error!"}';
....... select 1;
Parse: 26.632769ms
First row: 685.362µs
Query time (including output formatting): 27.38457ms
[1]
Parse: 3.281347ms
OK: CONFIGURE DATABASE
Parse: 461.579µs
First row: 554.846µs
Query time (including output formatting): 1.036085ms
[1]
edgedb> select 1;
edgedb error: SchemaError: error!

configure current database triggers the cache invalidation in a scheduled callback, and so it can be racy after setting it. This is arguably fine, it's just kind of weird to see it happen on a single connection.

Anyway this seems to mostly be a server config/caching mechanism error so I am kicking it over to @fantix, but I think the recommendation to @tailhook is to use configure current database


Challenges in Enhancing Dark Regions within ROI Using HVI-CIDNet on Smartphone-Captured Images

Hey @Fediory ,
Thank you for providing the HVI-CIDNet model. I have tested it on the LOL dataset for entire image enhancement, but I am facing challenges when trying to enhance only the ROI (Region of Interest). No model seems to perform well in this specific case, as the ROI pixels appear significantly different from the rest of the image.
Could you please suggest an approach for enhancing dark regions only within the ROI? Additionally, I am working with a dataset consisting solely of smartphone-captured images, without any paired images. What would be the best method for low-light and normal-light image conversion in this context? How can I fine-tune the model for my dataset effectively?
Your guidance is crucial. Thank you

Thank you so much for your question, it made me think twice about our low-light enhancement methods. Next I will answer your questions mainly based on our HVI-CIDNet.
Q1: What would be the best method for low-light and normal-light image conversion in this context?
A1: Currently publicly available unsupervised models are better suited to unpaired datasets (in your case). For models such as CIDNet that require paired datasets for training, there are two ways to improve the quality of recovery.
Q2: How can I fine-tune the model for my dataset effectively?
A2: The first approach, modify the CIDNet loss and framework to an unsupervised method and train on your dataset. The second approach, if still using weights trained on LOL, involves finding the differences in the camera that captured the LOL dataset versus the camera of your dataset, which is one of the key factors affecting the final generalisation ability. The greater the camera difference, the greater the difference in generalisation ability on other unpaired datasets. If this difference in generalisation ability due to camera differences is to be boosted, this difference needs to be customised using the T(x) function and the γ parameter in the paper (which can be interpreted as a translation of your unpaired dataset photographs into the LOL dataset's distribution)


Added new suntech commands

Added a comment. Also, have you run mvn site and checked reports to see if there are any issues there? The line seems too long in your code.

mvn site - ok

Merged, thanks for pull request.


Add API for Leaderboard page

Add the API methods required for the leaderboard page. This includes:

Getting a list of all user names, sorted by weeklyXP

If you'd like to work on this, let me know and I'll send more info


Big value

https://github.com/Stephane-D/SGDK/blob/6255c53b9efa1f3dad4d9f230ef7fdb3836dc285/src/vdp_bg.c#L158
Must be "while(len--)"?

I mean insert

i = len;
before "while" for not changing "len" which used in VDP_setTileMapDataRectEx.

Definitely :p
Thanks for reporting, will be fixed very soon !


Partition set

In section https://docs.microsoft.com/en-us/azure/cosmos-db/partitioning-overview#replica-sets the image introduces the term "partition set". This term is never used or explained in the rest of the page.  Is the wrong term used, should the concept not be used in the image, of should it be explained in the article. This is unclear to me.
Kind regards,
Sjoerd

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d52f6d2e-f852-45ce-c205-ee4038d5ecd1
Version Independent ID: e45b7f29-4d75-0dda-0f13-38b644213840
Content: Partitioning and horizontal scaling in Azure Cosmos DB
Content Source: articles/cosmos-db/partitioning-overview.md
Service: cosmos-db
GitHub Login: @deborahc
Microsoft Alias: dech

@SjoerdWesterhof Thank you for the feedback. This is being assigned to the content author to evaluate and update as appropriate.

Thanks for the feedback. The public docs go into more detail about partition sets here: https://docs.microsoft.com/en-us/azure/cosmos-db/global-dist-under-the-hood#partition-sets.
In the context of this article on partitioning, I don't think the concept of partition set adds very much. It's basically a group of physical partitions that manage the same keys across different regions, data centers etc.
@SnehaGunda - what are your thoughts on either:

Removing the term "partition set" from the image or
Adding a sentence, e.g. "A partition set refers to a group of physical partitions that manage the same logical partition keys across multiple regions. Learn more" and link to the more detailed article.

@deborahc let's add the partition set description to the text.

Made a change in the above PR. we will now close this issue.
#please-close


Issues using Blacklist to exempt devices and Credentials do not appear to stay valid

Analysis
Blacklist fails to prevent some devices from pairing with the plugin. Then multiple units do not maintain credentials and repeated throw up PIN numbers on the screens.
Expected Behavior
I expected that any blacklisted AppleTVs would not continually attempt to pair with the plugin and throw PIN code up on the screen.
My other expectation was that once configured I could use the triggers exposed by your plugin to run HomeKit automations based on their conditions.
Steps To Reproduce
1 - After installing plugin and setting up the Child Bridge it starts discovering my four Apple TVs. In this instance I immediately started blacklisting (using the MACs in the plugin log) three of my devices that I planned to configure later. I wanted to focus only on the Living Room AppleTV.
2 - I restarted the bridge and the logs indicate that it was no longer attempting to connect to those blacklisted devices.
3 - I followed the steps to add my AppleTV as a bridge using the code from the log. This was successful but immediately after the logs indicate that my Bedroom AppleTV was trying to pair. (I confirmed the MAC was correct and still saved)
4 - Then the device I had been configuring started getting prompted to enter a PIN again while I was watching TV. The log shows that my Living Room Apple TV's credentials were longer valid. I tried entering one of the PINs but it just continued to ask for another PIN. This behavior starts at 12:40:54 in the attached log
5 - At this point I disabled the plugin
**on a previous attempt it was a my Kitchen AppleTV that was trying to connect even though it had been blacklisted. So it appears to not be consistent. These are all AppleTV 4K except for the Bedroom which is an AppleTV HD
Logs
See the attached log in 'Additional Context'

Configuration
{
    "name": "Apple TV Enhanced",
    "deviceStates": [
        "playing"
    ],
    "deviceStateDelay": 0,
    "avadaKedavraAppAmount": 15,
    "disableVolumeControlRemote": false,
    "setTopBox": false,
    "discover": {
        "multicast": true,
        "blacklist": [
            "C8:D0:83:C0:73:31",
            "F0:B3:EC:5B:BC:A7",
            "C8:69:CD:09:EE:50"
        ]
    },
    "forceVenvRecreate": false,
    "logLevel": 3,
    "deviceSpecificOverrides": [
        {
            "overrideMediaTypes": false,
            "overrideDeviceStates": false,
            "overrideDeviceStateDelay": false,
            "deviceStateDelay": 0,
            "overrideRemoteKeysAsSwitch": false,
            "overrideAvadaKedavraAppAmount": false,
            "avadaKedavraAppAmount": 15,
            "overrideCustomInputURIs": false,
            "overrideDisableVolumeControlRemote": false,
            "disableVolumeControlRemote": false,
            "overrideSetTopBox": false,
            "setTopBox": false
        }
    ],
    "_bridge": {
        "username": "0E:E7:FE:AF:7D:D8",
        "port": 39105
    },
    "platform": "AppleTVEnhanced"
}

Environment

OS: Raspberry Pi OS Bullseye 11
Docker: false

Image Version:

Homebridge: 1.7.0
Homebridge Config UI: 4.55.1
Storage Path: /var/lib/homebridge
Apple TV Enhanced: 1.2.3
Node: 20.11.1
npm: 0.39.7
Python: 3.9.2
pip: 20.3.4
HDMI hops: 0. All AppleTVs are connected directly to TV's HDMI input
HomePod as default speaker: True on two out of four of the devices.

Additional Context
homebridge-appletv-enhanced.log.txt

It would be helpful if you could post the following log message, without hiding the MAC-Adress.
[2/17/2024, 12:40:54 PM] [Apple TV Enhanced] [I] Platform: Adding Apple TV Bedroom AppleTV (hidden MAC)

Gotcha. Sorry about that. See attached.
homebridge-appletv-enhanced.log-2.txt

Could you please install v1.2.4-1 and test if the version is working for you?

I've upgraded to your beta version and so far so good. I was able to add two of my devices. The blacklist appears to be holding and credentials staying valid. It has been running for about 12 hours without an issue. I've also generated some automations based on your plugin and they worked perfectly.
Thank you! This was such a great idea for a plugin.


error: 400

: phishlets enable linkedin (This line is command)
====Result====
[23:49:15] [inf] enabled phishlet 'linkedin'
[23:49:15] [inf] setting up certificates for phishlet 'linkedin'...
[23:49:15] [war] failed to load certificate files for phishlet 'linkedin', domain 'account.loginsecureaccount.com': open /root/.evilginx/crt/account.loginsecureaccount.com/linkedin.crt: no such file or directory
[23:49:15] [inf] requesting SSL/TLS certificates from LetsEncrypt...
[23:49:15] [!!!] acme: error: 400 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-acct :: urn:ietf:params:acme:error:malformed :: No embedded JWK in JWS header, url:
[23:49:15] [inf] disabled phishlet 'linkedin'
anyone knows how to solve the error help me

What domain registrar are you using: Namecheap, GoDaddy, etc?
Ddi you set up your phishing domain and server Ip correctly on Evilginx?

I'm using godaddy for domain name and digital ocean for vps with debian 9 installation
phishing domain and server Ip is set correctly in Evilginx. I've added the screenshot here check it out. if u know how to solve this error plz help me out.

Im assuming the ip you have listed in the records is the ip where you have evilginx running
Also I would add a record entitle phishing as the host and put the value as the ip to where your running evilginx
Also check the FAQs page in the repo to make sure you have your name server configured correctly

you mean i need to create "A" record known as phisihing.loginsecure.com and www.phisihing.loginsecure.com. and also i need configure phishlet like phishlets hostname linkedin phisihng.loginsecureaccount.com. is that u are trying to say buddy

When I was setting up my phishlet I just had an A record that had "LinkedIn" as the hostname value though it might be different because outlook has a lot more stuff to it
But what exactly is the name of your domain? Because what I suggest is that you have some thing that follows the pattern of linked.youdomain but of course adapt it to what your trying to do
I hope that made sense

my domain name is loginsecureaccount.com and i bought that from godaddy and nameservers are  set to digitalocean. The problem facing in Evilginx is whenever im trying to enable phishlet , it's unable to obtain certificates.

does evilginx2 is working for you perfectly

Im running evilginx2 from local directory like:
sudo ./bin/evilginx -p ./phishlets/

I run it simply with sudo evilginx but I think the way you are doing it is fine

So in your case since your using the outlook phishlet I would recommend that you create an A record with the value of outlook pointing your ip address where your running evilginx

Me pueden ayudar tengo el mismo problema .

i can help you with your<EMAIL_ADDRESS>

Yes but it will cost you $500  ......i also paid thesame $500 and someone
assisted me on github ,if you already get back to me and i will you with him
On Fri, Jan 24, 2020 at 4:53 PM locoanonimo<EMAIL_ADDRESS>wrote:

Me pueden ayudar tengo el mismo problema .
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kgretzky/evilginx2/issues/452?email_source=notifications&email_token=AN3KIL6OOQHXJHJA375BXQTQ7MFH5A5CNFSM4KGGWHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3HFPI#issuecomment-578187965,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN3KIL4FJC3DXLYABWNQRPDQ7MFH5ANCNFSM4KGGWHAA
.

frnds if u find any difficulties in setting up evilginx plz join my discord server
hhtps://discord.gg/CufUUux
i dont know why u all facing so many errors in setting up evilginx. just screen shot ur error and send in discord i try to solve it out.
I have installation instructions in a text file plz dm me to get it and u wont face any issue.

Can you help me out with gmail cookies? im having serious problem with run
gmail on evilginx2 and it wont bypass after reporting back with the
victims cookies
On Sun, Feb 2, 2020 at 5:41 PM Devilshow<EMAIL_ADDRESS>wrote:

frnds if u find any difficulties in setting up evilginx plz join my
discord server
hhtps://discord.gg/CufUUux
i dont know why u all facing so many errors in setting up evilginx. just
screen shot ur error and send in discord i try to solve it out.
I have installation instructions in a text file plz dm me to get it and u
wont face any issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kgretzky/evilginx2/issues/452?email_source=notifications&email_token=AN3KILZI3JCWDHUQ5H2WOHTRA3ZULA5CNFSM4KGGWHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKR3BEA#issuecomment-581152912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN3KIL46V4JM2TBYXPN7U2LRA3ZULANCNFSM4KGGWHAA
.

to my knowledge ..evilginx doesnot have gmail phishlet yet

Someone said they do and the prsn sent a phishlets link and i clicked on it
.....its work well
On Sun, Feb 2, 2020 at 6:08 PM Devilshow<EMAIL_ADDRESS>wrote:

to my knowledge ..evilginx doesnot have gmail phishlet yet
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kgretzky/evilginx2/issues/452?email_source=notifications&email_token=AN3KIL63MKPLZBZS3NKXXQDRA34Z5A5CNFSM4KGGWHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKR3YRI#issuecomment-581155909,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN3KIL7NYBIXV63AAZ4FC7LRA34Z5ANCNFSM4KGGWHAA
.

i want to add china domains to evilgix2 can you help me out with it
......below is the domains i want to create on Evilginx2 .....126,163,qq
and sina
On Sun, Feb 2, 2020 at 5:41 PM Devilshow<EMAIL_ADDRESS>wrote:

frnds if u find any difficulties in setting up evilginx plz join my
discord server
hhtps://discord.gg/CufUUux
i dont know why u all facing so many errors in setting up evilginx. just
screen shot ur error and send in discord i try to solve it out.
I have installation instructions in a text file plz dm me to get it and u
wont face any issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kgretzky/evilginx2/issues/452?email_source=notifications&email_token=AN3KILZI3JCWDHUQ5H2WOHTRA3ZULA5CNFSM4KGGWHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKR3BEA#issuecomment-581152912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN3KIL46V4JM2TBYXPN7U2LRA3ZULANCNFSM4KGGWHAA
.

: phishlets enable linkedin (This line is command)
====Result==== [23:49:15] [inf] enabled phishlet 'linkedin' [23:49:15] [inf] setting up certificates for phishlet 'linkedin'... [23:49:15] [war] failed to load certificate files for phishlet 'linkedin', domain 'account.loginsecureaccount.com': open /root/.evilginx/crt/account.loginsecureaccount.com/linkedin.crt: no such file or directory [23:49:15] [inf] requesting SSL/TLS certificates from LetsEncrypt... [23:49:15] [!!!] acme: error: 400 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-acct :: urn:ietf:params:acme:error:malformed :: No embedded JWK in JWS header, url: [23:49:15] [inf] disabled phishlet 'linkedin'
anyone knows how to solve the error help me

Please can you message me on telegram @dragon714 to tell me how you solved it

this is the error i get when i do phishlets enable o365 kindly someone help me
[10:38:08] [inf] obtaining and setting up 3 TLS certificates - please wait up to 60 seconds...
[10:38:08] [err] failed to set up TLS certificates: login.microsoftoffic365.com: obtaining certificate: [login.microsoftoffic365.com] Obtain: [login.microsoftoffic365.com] creating new order: attempt 1: https://acme-v02.api.letsencrypt.org/acme/new-order: HTTP 429 urn:ietf:params:acme:error:rateLimited - Error creating new order :: too many failed authorizations recently: see https://letsencrypt.org/docs/failed-validation-limit/ (ca=https://acme-v02.api.letsencrypt.org/directory)
[10:38:08] [err] run 'test-certs' command to retry


chore: table: normalize aria label property name and add locs

SUMMARY:
Adds remaining locs
Also some ui polish to prevent two pixel width button artifact of absolute layout
CHANGE TYPE:
Chore
TEST COVERAGE:

[X] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:
Pull the PR branch and run yarn and yarn storybook. Verify the Table stories behave as expected.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e96f791). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage        ?   84.43%
=======================================
  Files           ?      785
  Lines           ?    16452
  Branches        ?     5697
=======================================
  Hits            ?    13891
  Misses          ?     2494
  Partials        ?       67

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


The getter 'documentReaderNotification' was called on null.

Hi, can you help me, I have some issue on Android 12 when using this SDK with Flutter.
Actually I have no issue for using this SDK version 5.3.0 until Android 11, but there is some issue on Android 12, that my app was force close after scanning MRZ on e-passport.
So I tried to upgrade this SDK "flutter_document_reader_api" on "pubspec.yaml" (have tried from 5.7.0 to 6.4.0 version) and realized i need to change a little bit of my code because this migration version like below :
Scenario scenario = Scenario.fromJson...
into
DocumentReaderScenario scenario = DocumentReaderScenario.fromJson...
But after I applied the codes above, now the MRZ scanner have issue like below :
NoSuchMethodError: The getter 'documentReaderNotification' was called on null.
Receiver: null
Tried calling: documentReaderNotification

The errors above happened after I finish scan the MRZ on e-passport for Android version 12 and below.
So is there any code that I need to change or adjust for this migrate version?or is there any solution for using this SDK on Android 12?
Thank you and please let me know if you need any additional information about this issue.

OS: Android
OS version: 12 and below

Hi thank you for your replied, i have solved this issue and it's purely my mistake.
But i have found another issue, but i will close this one and write another.


Fix Skills Accordion Width on Skills Page

The Skills Accordion is not wide enough on screen sizes < 480px. Set the width to 100% at these sizes.

Fixed in - 8acff8803b84cc0c2bd40acdf720f7281870188c


Interface to set xheight/cap-height explicitly

Imagining something like [ExHeight=5pt] or [CapsHeight=10pt] as an alternative to [Scale=MatchLowercase]. From http://tex.stackexchange.com/questions/261128/scale-font-to-a-desired-x-height-em-cap-height-etc-in-fontspec.

That could be useful (and thanks for the link). Currently I do that via a roundabout method using fp calculations. In the context of printed fiction, which uses long passages of running text, it is helpful to be able to compare how the text appears in different fonts. Keepingthe same the ex-height is probably the most useful head-to-head comparison.


.icns (macOS icons) to .png

What are you trying to achieve?
Convert .icns to .png.
Would converting an macOS icon file (.icns) to .png? If not possible with Sharp, does anybody know of any other library or way this could be done?
Have you searched for similar questions?
Yes, I could not find any questions related to .icns files.
Are you able to provide a minimal, standalone code sample that demonstrates this question?
sharp('test.icns')
   .toBuffer()
   .then( data => {
      fs.writeFileSync("test.png", data);
   })
   .catch(err => {
      console.log("err: ", err)
 })

macOS provides a command line tool for this - see https://www.macworld.com/article/1060156/sipsicns.html

Yeah, that works great but I'm looking for a way to do it on a Linux system. I've also found another node library called "iconutil" which worked fine on my mac, but not on the Ubuntu server I'd need it to run on.

The icns2png command line tool is available in most Linux distributions e.g. https://packages.ubuntu.com/focal/icnsutils

@lovell That's what I've been using to convert png images to icns, but it doesn't work the other way around, .icns to .png.

I hope this information helped. Please feel free to re-open with more details if further assistance is required.

I hope this information helped. Please feel free to re-open with more details if further assistance is required.

sips does not support formats such as webp. Can sharp support icns?


lncli: add password arg to unlock

This PR adds a new command line argument  password to the lncli unlock command.
Example usage:
lncli unlock --password=hunter2

The motivation is to unlock the lnd wallet with a single command instead of interacting with lncli after running lncli unlock. More specifically, I am interested in running lnd as a service on my server with auto-restart enabled. Ordinarily, a restart would require the password to be re-entered. I very much appreciate the security concern of storing a password in plaintext or printing it on the command line in plaintext but for my use case at least, lnd is a hot wallet and when its running I am already taking on the usual hot-wallet risks.
Normal functionality has been altered slightly with regard to the existing optional param recovery_window. This param was expected at index 0 but now will be at index 1 and password will be at 0. Not sure how we want to deal with two optional params, but without the flags the command will work like this:
lncli unlock <password> <recovery_window>

e.g.
lncli unlock hunter2 10

See discussion in https://github.com/lightningnetwork/lnd/issues/1611. If you feel this functionality is still needed, please open an issue describing your use case.


Prometheus metrics

Proposed changes:

separate out changes to add a prometheus metrics endpoint (from this tracing + metrics PR)

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

any update ?


⚠ AGEG website (prod) has degraded performance

In 71e2576, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 6549 ms

Resolved: AGEG website (prod) performance has improved in 72ec127.


Error detected while processing VimEnter Autocommands

Some error on nvim start, nvim version 0.9.4 , in linux mint. Plugin will work but does not allow tab to accept. Ctrl \ will work.

Hi, @BVegNow
It seems that this issue is same with  https://github.com/TabbyML/tabby/issues/862
Do you use any other plugins that map the <tab> key?


Has this been tested with ios9?

Yes. Why?

No reason, I have pods in my app and it doesnt work on ios 9 anymore and I was going through to see if it was any of the pods that may have caused the trouble. Was wondering if you could shed some light on this please. It was working fine in ios8, but all of a sudden in ios9, the app is stuck in the loading screen, then crashes. I believe this is because of a pod I am using since no code was ever updated between ios8 and 9. Thanks!


WIP: initial version of search

This is the first version of a new search based on Fuse.JS. It allows fuzzy searching, which is generally helpful. It may require some more finetuning, though, to get the best possible results. The current options I use for Fuse are found here. The index itself is generated here. In summary, I have three levels of things I'm searching in:

ident
desc
remarks

For most parts of the Specs, it's fairly easy to see where these are coming from. The first field has a weight of 10, the second a weight of 2, the last a weight of 1. For Guidelines Chapters, ident is the title of the chapter (including the chapter number), desc is a list of all elements etc. referenced explicitly, and remarks is the full text of the chapter, including examples. Only for guidelines chapters I render a preview from the remarks, as everything else is either quite obvious or hard to render at all. All those parameters can be adjusted as necessary.
The search index is generated alongside the web version of the guidelines and should work out of the box. Compilation times haven't changed for me, so this should be fairly efficient. The searchIndex.js that is generated weighs in at around 900kb, and is already quite compressed. We could think about doing this on the server instead, but I'm not sure this is really preferable.
Of course I'd like to get feedback from others as well (@musicEnfanthen, @rettinghaus, …) – I just failed to set you up as reviewers ;-)
I believe this is ready in general. That said, there is no rush to merge it – after tomorrow, I'll be offline for the coming two weeks ;-)
If merged, this fixes #749.

I just converted this to a draft to indicate that it's still a WIP.

Thanks @ahankinson – draft is surely more appropriate at this point. I will put it on the agenda for the next ODD meeting on August 26. I can't promise that I'll have the CSS cleaned up by then, but maybe some more people will have had an opportunity to look at this.

ODD meting notes:

code cleanup still needed
from the discussion I assume testing is also needed
Proposal is: get code cleanup done, merge and let users test ;-)

@kepper do you want to keep the search-guidelines branch for additional things? Otherwise I'd recommend to delete it.

let me see what I can accomplish this week. Would be nice to keep it as reference over there, but then remove it afterwards…

@kepper The search isn't working because fuse.js is missing. There are several possible ways to fix that, but I would leave this to you. If you like I'll open a new ticket for this.

IIRC, this is an issue with moving things in the correct folder, so this is mostly an issue about the GitHub Actions workflows. Seems easiest to me to do this during a video call with someone more involved in this, maybe @musicEnfanthen, @bwbohl or you, @rettinghaus?

that was what I tried to address in #871 but if I understand correctly I was mistaken in removing fuse.js, right? So we need the build.xml patch and KEEP fuse.js, correct?


Fixes unexpected timezone converting when passing TIMESTAMP to unix_timestamp()

see #2111

Thanks for the submission. @jycor will look at this latest tomorrow as today is a holiday for us.


Return explicit reasons on bad authentication

I have one server with a time delay, but it was very complicate to understand and debug the issue in the application because ApiAuth return only false for bad authentication.
Let change that with explicit error.

Thanks so much for taking this on, having the ability to know what reason the request is inauthentic is very valuable.
My suggestion is to first just extract the checks into seperate validations that all run independantly of each other, and when each one passes or fails in can put that reason into a inauthentic_reasons hash or something along those lines. And for now the authentic? method can still be a true or false based on weather anything showed up in inauthentic_reasons.
Does that make sense?
I think having errors get raised for things being inauthentic can also happen, but it can and should be separate from the task of just supplying the exact reason in a new method.

@kjg can you take a look ? Thanks for every comments.

This is great! Thanks so much! I just want to think about the names a little bit more with your help.
I like the name of the method, but maybe another name might be even more clear. Maybe something like authenticity_report?
I've always worried about using the term "md5_match" because we still consider a request authentic if there is no md5 provided at all. I'm not sure how to name this check using positive language though which is why I've gone with md5_mismatch in the past because lack of md5 doesn't make it a mismatch. Any further thought there?
If we're looking to possibly make request invalid if it's too far in the future too, maybe we can call that check "request_within_time_window" or something along those lines. There might be a better shorter name that I can't think of.

I don't change md5_match because I prefers to have only false in authenticity_report for a failure.

I totally understand the desire to use only positive assertions like that. Can we come up with a better term than md5_match then, since it is a little misleading to call md5_match a "true" when no md5 was provided. Or maybe we can just leave it out of the report all together if there is no md5?

I close this PR because we don't agree on the name and in the fact I don't need this anymore with https://github.com/mgomes/api_auth/pull/136.

I still think it's valuable to have access to an explicit error message.


[QUESTION] Slugify a tier list's title

Question
How do we go about turning the tier list's title into a slug? More specifically, how do we want to limit user input on the title of the tier list, and what should the slug look like?
We can think about it like that:

A user cannot have multiple tier lists with the same name (makes sense but requires taking off the unique attribute on the slug field in the DB, and instead implementing custom validations.
A user can only use certain characters for a tier list's name (like letters, numbers, and spaces).
By doing so, URLs would have to contain the user's name or "tag", which should also be unique (eg: /yam/tier-lists/my-tier-list).

We could also imagine that instead, a slug is unique in the DB but by doing so, we are forced to have a random and unique value at the end of the slug (eg: my-tier-list-197625469) which would greatly reduce the collision rate.
Additional information
There is no "good" or "wrong" answer here. All ways of doing this require a different implementation, but we should look at what is really the best for us and what users would enjoy the most.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I am personally leaning towards having unique slugs per user. But now the real question is, do we allow using the same name (thus, slug) multiple times? If not then...

Either add a -1 after the slug if it already exists (requires additional DB calls),
Or add a random number at the end of the slug to almost nullify collision risks (would result in less friendly URLs).

So with method one, a URL could look like this :
https://rankylist.com/user/yam/tier-list/my-awesome-tier-list (with my-awesome-tier-list-1 if there is already a tier list with this slug for this user).
Method two :
https://rankylist.com/user/yam/tier-list/my-awesome-tier-list-197625469.
I prefer the first method, but since it requires additional DB calls it could mean reduced performance. It would require some ingenious verifications and logic to reduce the DB calls as necessary.

Check the possibility of doing so with PocketBase.


Example link leads to 404

Hi,
At the bottom of the readme.md there's a link that says:

Please check this simple example to see how it's easy to configure webpack with riot

This link leads to here: https://github.com/riot/examples/tree/gh-pages/webpack - which currently is dead
Any chance the example could be reinstated, or the link changed to be pointing to the right place?
Thanks
edit: Looks like the problem is that this example doesn't exist (anymore?) on the gh-pages branch, which is where the link is pointing. Changing the link to https://github.com/riot/examples/tree/next/webpack looks like the right thing to do

Looks like this example was deleted in 2022 without explanation or replacement
https://github.com/riot/examples/commit/85a37563a56f10bf578c84bf19741f5428b7b1db
Is there a reason why? Does riot still support webpack?

Thank you for this issue. I have updated the readme adding the missing webpack examples.
The examples repo contains already 3 webpack projects and It makes no sense to keep alive a 4th one just to show how a webpack config should look like.
Consider also that npm init riot creates a template with a default webpack configuration, my intent is to avoid redundant stuff across the Riot.js repos.


.ps1 - Powershell Files not support

Would it be possible to get support for Powershell Files?

I think .ps1 and .sh will work. They just need to enable them. They are straightforward just comments after # needs a check

Accepting PRs. Follow guide: https://github.com/znck/grammarly#adding-support-for-new-language


Fix spelling of summary

Summary: Summary is spelt wrong in commit-message formatter and valgrind action.
Type: Fix
Test Plan: Actions succeed
Jira: RIALTO-362

https://jenkins.code.rdkcentral.com/job/github-triggered/41635/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/7934/ started

https://jenkins.code.rdkcentral.com/job/build-component/80517/ started.

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/28999/


move to latest gobject-introspection

3.0.9 seems to have changed the return values from property.get, so the gem is locked at 3.0.8.
Investigate and fix.

In progress in this issue
https://github.com/jcupitt/ruby-vips/tree/move-to-goi-3.1


Repetition with Llama3-70b and EETQ

First of all, thank you for EETQ!
I am using EETQ with TGI to serve LLama3-70b-instruct. I have noticed that compared to other quants (bnb-nf4, awq) the repetition that I get from Llama3 is significantly higher (all other generation parameters the same). I am doing a lot of structured extraction with TGI's grammar e.g. topic classification/extraction. With EETQ, the responses I get may look like this:
["Math",
"Science",
"Reading",
"Math",
"Science",
"Reading",
"Math",
"Science",
"Reading",
"Math",
"Science",
"Reading"]
While with other quants I get something like the expected:
["Math",
"Science",
"Reading"]
For all quants I'm using repetition_penalty of 1.1, temperature .1, top_p .95, but as stated I'm only observing this with EETQ. I have absolutely no idea how to debug this, or if it is even possible, but the repetition issue holds across prompts and inputs so I wanted to share. I'm using the TGI docker container, and the official Llama3-70b-instruct (for bnb-nf4).
I'm wondering if anyone else has come across this or has any insights.

The problem may be caused by the precision degradation of quantization. To verified it, please use logger.info in TGI to print the logits of EETQ and compare it with those of the original model or etc. I guess there is no big difference between the logit of ']' and ',' leading to the logit of ',' bigger than that of ']' after quantized by EETQ.

This issue was closed because it has been stalled for 30 days with no activity. Please feel free to reopen it if needed.


Delayed Animations Are BAD

So I was trying to build a cup with water in the shapeshifter, and after I exported the AVD into Android Studio, the animation fill was totally wrong - both files, my export and my final fix are attached, so I added nothing animation(just another one but without nothing - goes from 0 to 0) and it didn't fix it either..
So I added the following to each vector who had delayed animation
<objectAnimator
android:propertyName="trimPathStart"
android:startOffset="0"
android:duration="0"
android:valueFrom="0.5"
android:valueTo="0.5"
android:valueType="floatType"
android:interpolator="@android:interpolator/fast_out_slow_in"/>
And it fixed it.
Can you please fix this in the ShapeShifter site?
It is very helpful tool and I really like using it! :)
drawable.zip

Thanks for reporting!
Could you post the contents of the .shapeshifter file for your project so I can look into it?
You can go to "File --> Save" to download the .shapeshifter file. Then just open it up in a text editor, copy its contents, and post it to this bug report.

As of right now, I'm not near my computer.
I'll do it first when I'll be around it...
But the ShapeShifter isn't the problem!
It's the Android AAPT.. just if I add those lines with the parameter that will be animated with delay (AKA: startOffset) with the startOffset=0 and duration=0, its fixing it..

Ahh OK... well, in that case the .shapeshifter file would still be useful. There may be a way I can modify shape shifter to temporarily workaround the issue, even if it technically is an issue with Android AAPT. :)

Uploading a sample project demonstrating the issue would also be helpful if you have one... it sounds like this is something I could report directly to Google. I've sent them many bug reports like this... haha


Improve easy-of-use for #[interrupt] macro on ESP32-C3

The macro needs to reference the TrapFrame ( https://github.com/esp-rs/esp-hal/blob/7889a992d7efcbbba0a5c7ef679694877f30380e/esp-hal-procmacros/src/lib.rs#L224 )
This requires importing something like use esp32c3_hal::interrupt; in the root
Maybe we can come up with a better solution which doesn't require that import

Yeah, I hate that part, it's super annoying. For context, this "check" is here to make sure a given interrupt actually exists. Hopefully we can find a better way to do this check.

Same thing applies to this line requiring pac to be in scope:
https://github.com/esp-rs/esp-hal/blob/4ab05e89235e620287a6c3b24486c0b8c2c05a28/esp-hal-procmacros/src/lib.rs#L202

I don't think there is a way around having to import the TrapFrame, because its part of the public API of the function. Thankfully, because it's public it's easy to spot that it needs to be imported.

Same thing applies to this line requiring pac to be in scope:

I've been looking at improving this, I don't think there is an easy way to check, without doing strange things like having const to_string methods on each of the interrupt enums and comparing the to string with the name of the interrupt handler.
I'm thinking about removing the check entirely, and instead adding a log statement inside each hal's extern "C" fn EspDefaultHandler(_interrupt: peripherals::Interrupt) {} saying "Unhandled Interrupt : X". Thoughts?


Karpenter not recognizing ready Bottlerocket nodes with bootstrap containers

Description
Bottlerocket allows users to define bootstrap-containers through userData. This is useful for a variety of reason.
Observed Behavior:
The AWSNodeTemplate passes validation:
apiVersion: karpenter.k8s.aws/v1alpha1
kind: AWSNodeTemplate
metadata:
  labels:
    app.kubernetes.io/managed-by: Helm
  name: gpu
spec:
  amiFamily: Bottlerocket
  ...
  userData: "[settings.bootstrap-containers.mybootstrap] \n  source = \"oscarhealth/bottlerocket-bootstrap-public\"\n
    \ mode = \"always\" \n  essential = true"

New nodes are launched as needed:
2024-01-22T17:07:40.518Z	INFO	controller.machine.lifecycle	launched machine	{"commit": "322822a", "machine": "gpu-lt6ts", "provisioner": "gpu", "provider-id": "aws:///eu-central-1a/i-08a00fdfe4d51cee1", "instance-type": "g4dn.xlarge", "...
2024-01-22T17:07:40.518Z	INFO	controller.machine.lifecycle	launched machine	{"commit": "322822a", "machine": "gpu-l6k7n", "provisioner": "gpu", "provider-id": "aws:///eu-central-1a/i-0d84aeca2be1fe47b", "instance-type": "g4dn.xlarge", ...

The machines appear as Running in AWS:

However, said machines never join the cluster. The only thing Karpenter and K8S can see are the old nodes that have been cordoned for the exercise. As a result, the pods that had triggered Karpenter's node update stay in pending.
k get no
NAME                                            STATUS                     ROLES    AGE     VERSION
ip-10-19-20-44.eu-central-1.compute.internal    Ready,SchedulingDisabled   <none>   3d19h   v1.27.8-eks-75169ff
ip-10-19-21-10.eu-central-1.compute.internal    Ready,SchedulingDisabled   <none>   3d6h    v1.27.8-eks-75169ff

Expected Behavior:
The bottlerocket machines should be joining the cluster.
Reproduction Steps (Please include YAML):
apiVersion: karpenter.k8s.aws/v1alpha1
kind: AWSNodeTemplate
metadata:
  labels:
    app.kubernetes.io/managed-by: Helm
  name: gpu
spec:
  amiFamily: Bottlerocket
  blockDeviceMappings:
  - deviceName: /dev/xvda
    ebs:
      deleteOnTermination: true
      volumeSize: 4Gi
      volumeType: gp2
  userData: "[settings.bootstrap-containers.mybootstrap] \n  source = \"busybox:latest\"\n
    \ mode = \"always\" \n  essential = false"

Note: according to Bottlerocket's docs, if the container fails and essential = true, node boot stops. I tested this both with true and false with no difference.
Versions:

Chart Version: 1.13.1
Kubernetes Version (kubectl version): v1.27.8-eks-8cb36c9

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Small update here - I switched to Karpenter version 0.32.5 and now I can see nodeclaims being "not ready" when the bootstrap container is required before the node can join the cluster.
This is good, since the not ready hints at issues with the bootstrap container (and thus, external from karpenter).
If the bootstrap container is not required, the nodes join the cluster as expected.
kn get nodeclaim
NAME             TYPE          ZONE            NODE                                            READY   AGE
gpu-f6tss        g4dn.xlarge   eu-central-1a   ip-10-19-20-133.eu-central-1.compute.internal   True    4h37m
gpu-kx57k        g4dn.xlarge   eu-central-1a   ip-10-19-20-122.eu-central-1.compute.internal   True    45m
gpu-snpz6        g4dn.xlarge   eu-central-1a   ip-10-19-20-90.eu-central-1.compute.internal    True    81m
standard-kmr4r   t4g.small     eu-central-1b   ip-10-19-21-172.eu-central-1.compute.internal   True    52m

I guess this was more of an issue with 0.31

This is good, since the not ready hints at issues with the bootstrap container (and thus, external from karpenter).

Feel free to reopen if you believe this is an issue w/ Karpenter.


Further Reduce Dependencies

Currently ~110, but could be further reduced

Replaced autopep8, isort, flake8, etc. with ruff. Now under 100, but there aren't any that could be easily excluded


403 content update

Update the 403 page to give staff more information on a common connection issue.

Hey @brown-a2 , a definite improvement content wise! Thank you. Hopefully it will slow down the emails in our inboxes 👍 all good from me.


refactor: update confirm api to a server action

Summary | Résumé
This PR refactors the confirm API to a server action as well implements database throttling to handle larger read / write loads.
Instead of trying to implement exponential back off and retries manually this PR instead uses the built in retry services that are included by default in the AWS SDK.  The number of retries for the dynamodb service has been increased from 3 to 15.  In LocalStack with the dynamodb set to return throttle capacity exceptions 50% of the time we can see the AWS retry logic at work.
As an additional throttling mechanism a 200ms delay is introduced between batched calls to more evenly spread out the load over the partition key (form ID)

BatchGetCommand
TransactWriteItems Command
Query Command

Test instructions | Instructions pour tester la modification
Setup:

Publish a Form
Generate a ton, and I mean of ton of responses for it
Set the response download limit to something ridiculous like 1000

Test

Download 1000 responses at once
Confirm 1000 responses at once

The actions should not throw errors and should complete, albeit a little more slowly, for a user.
If there are dynamodb warnings thrown in Slack it should have no impact on the user.
Unresolved questions / Out of scope | Questions non résolues ou hors sujet
Still need to refactor "report a problem" and "unprocessed submissions" APIs to server actions.
Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[ ] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[ ] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[ ] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[ ] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[ ] Have you modified the change log and updated any relevant documentation?
[ ] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

I tested this and from what I can see it works, mostly.
I tested by

creating a new form and adding 1000 submissions
Then trying to download 1000 submissions on staging develop.
Using this PRs branch, download 1000 submissions. Did not throw any errors. The download was fast and successful, as well marking the submissions as downloaded.
BUT the form response page seemed to have inconsistent state. Downloads appeared to have their status reverted and need to be downloaded again.

I feel bad for not knowing why my original fix didn't work. https://github.com/cds-snc/platform-forms-client/pull/3619

Works pretty well! Good job @bryan-robitaille :)
If we decide to move forward with the increased response limit of 1000 I wonder if we should not also be adding delay in the loops for the following functions: listAllSubmissions, retrieveSubmissions.
Also just want to know whether the implementation of getExponentialBackoffTimeInMS in the retrieveSubmissions function is intentional or not because from my understanding the DynamoDB SDK would still do it for us in case we get UnprocessedKeys to reprocess.

Works pretty well! Good job @bryan-robitaille :)
If we decide to move forward with the increased response limit of 1000 I wonder if we should not also be adding delay in the loops for the following functions: listAllSubmissions, retrieveSubmissions. However this could also have an impact on the user experience if form owners downloading forms start to refresh the page thinking that the process takes more time than usual (I did experiment it while testing this PR). Since we wait for the whole process to be completed to return the responses then if you refresh just before the end you will end up having responses that have been moved to the downloaded tab even though you did not even get them once.
Also just want to know whether the implementation of getExponentialBackoffTimeInMS in the retrieveSubmissions function is intentional or not because from my understanding the DynamoDB SDK would still do it for us in case we get UnprocessedKeys to reprocess.

@craigzour the 1000 response limit was only for testing that this does increase the performance based on our current baseline.  There is still much work to do before we can get to the point of setting 1000 as the default limit but I considered it out of scope of the current PR.
The use of exponential backoff in retrieveSubmissions is intentional because 'UnprocessedKeys' are not retried automatically because the 'Batch Commands' do not return a 4xx or 5xx error.  https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Programming.Errors.html#Programming.Errors.BatchOperations

I feel bad for not knowing why my original fix didn't work. #3619

Don't fee bad!  It did work but only covered off confirming responses.  It was also redundant of the logic that TransactWriteItems was already doing behind the scenes to retry.  So it was kinda like retry logic on top of retry logic.

Also just want to know whether the implementation of getExponentialBackoffTimeInMS in the retrieveSubmissions function is intentional or not because from my understanding the DynamoDB SDK would still do it for us in case we get UnprocessedKeys to reprocess.

@craigzour sorry I misunderstood your comment.  I think I understand now what you were referencing.  Basically, why do we implement a delay if there are 'UnprocessedKeys' because in the next iteration of the BatchGetCommand in the while loop the AWS SDK will already implement retries and throttling for the unretrieved keys.
So my thought process with introducing the delay is as follows:
Context : We pass in an array of 50 items to the BatchGetCommand
Without the delay

The BatchGetCommand fails and retries after 200ms, the second retry succeeds and returns 10 items with 40 in 'Unprocessed Keys.
40 items are passed back in and are immediately retried and fails.  Internally the second retry also fails and delays, the 3rd retry succeeds and returns 10 items with 30 in 'UnprocessedKeys'

My conclusion was that it was kind of a rapid fire approach where we knew the dynamoDB was busy but we immediately retried anyway.  The subsequent invocation of BatchGetCommand runs immediately because the SDK retry mechanism starts fresh every time.
With the delay

The BatchGetCommand fails and retries after 200ms, the second retry succeeds and returns 10 items with 40 in 'Unprocessed Keys.
We have an indicator that the DB is busy so we delay 200ms externally before calling the BatchGetCommand again for the same data.
40 items are passed back in and are retried and fail.  Internally the second retry also fails and delays, the 3rd retry succeeds and returns 20 items with 20 in 'UnprocessedKeys'
We have an indicatore that the DB is really busy so we delay 400ms externally before calling the BatchGetCommand again.

With this version I thought we were being proactive by giving the dynamoDB a chance to catch up by reducing the load on it and giving it a better probability of completing the request with all items.

Also just want to know whether the implementation of getExponentialBackoffTimeInMS in the retrieveSubmissions function is intentional or not because from my understanding the DynamoDB SDK would still do it for us in case we get UnprocessedKeys to reprocess.

@craigzour sorry I misunderstood your comment. I think I understand now what you were referencing. Basically, why do we implement a delay if there are 'UnprocessedKeys' because in the next iteration of the BatchGetCommand in the while loop the AWS SDK will already implement retries and throttling for the unretrieved keys.
So my thought process with introducing the delay is as follows: Context : We pass in an array of 50 items to the BatchGetCommand
Without the delay

The BatchGetCommand fails and retries after 200ms, the second retry succeeds and returns 10 items with 40 in 'Unprocessed Keys.
40 items are passed back in and are immediately retried and fails.  Internally the second retry also fails and delays, the 3rd retry succeeds and returns 10 items with 30 in 'UnprocessedKeys'

My conclusion was that it was kind of a rapid fire approach where we knew the dynamoDB was busy but we immediately retried anyway. The subsequent invocation of BatchGetCommand runs immediately because the SDK retry mechanism starts fresh every time.
With the delay

The BatchGetCommand fails and retries after 200ms, the second retry succeeds and returns 10 items with 40 in 'Unprocessed Keys.
We have an indicator that the DB is busy so we delay 200ms externally before calling the BatchGetCommand again for the same data.
40 items are passed back in and are retried and fail.  Internally the second retry also fails and delays, the 3rd retry succeeds and returns 20 items with 20 in 'UnprocessedKeys'
We have an indicator that the DB is really busy so we delay 400ms externally before calling the BatchGetCommand again.

With this version I thought we were being proactive by giving the dynamoDB a chance to catch up by reducing the load on it and giving it a better probability of completing the request with all items.

Got it! Then it looks good to me ;)


Add watch retrigger when store restarts

Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

LGTM

LGTM


Setup test suite

Still to fix Watch functionality, currently it will try and launch multiple Kassy instances

Watch has now been fixed

Adds #67 functionality

Approved, ignoring codacy.


Hot Reloading not working?

I cloned master branch and completed the mongo setup. The server run perfectly,
however, whenever I change container or components, my web browser does not render the newest code.
What is the problem with hot reloading?

Ok, nevermind, I was running production instead of npm run dev


Fix/pandora dev over npm run script

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #86   +/-   ##
======================================
  Coverage    81.6%   81.6%
======================================
  Files         179     179
  Lines        5181    5181
  Branches      639     639
======================================
  Hits         4228    4228
  Misses        684     684
  Partials      269     269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e5dc0...477a5ab. Read the comment docs.


Make gradient of DC estimation to zero based on an argument

We can assume that the density compensation is constant and does not vary with trajectory.
This will help in better learning trajectory and not be affected by gradients, which can end up having noise in them.

Reporting that this works!

Awesome, with set -e the tests fail! This resolves #39 . Reverting to old codes and bumping version


soroban-rpc: Better state expiration support for getLedgerEntry

Currently getLedgerEntry endpoint just returns the LE XDR, which now doesn't have the expiration-related info.
Instead it probably should:

Return the entry expiration ledger (fetched from the respective EXPIRATION entry), when applicable
Return a flag denoting whether entry has expired, when applicable

This would make the behavior consistent with simulation, where we already do fetch and mark the restored entries (when available).

Related, as a more-immediate workaround: https://github.com/stellar/js-soroban-client/issues/153

I don't believe that Return a flag denoting whether entry has expired, when applicable is really needed

sounds good, so, the net change would reduce to just new LedgerEntryResult.ExpirationLedger, with additional behavior of:

it's optional, will be absent if not applicable for LE?
if present it could be 0 meaning the LE has no expiration, or non-zero indicates a real ledger number that LE will expire upon.

If it returns, the LE definitely has an expiration. The only question is whether a value of 0 is the right way to say "I don't know which ledger sequence it was expired upon" or whether we should find another way to achieve that.
I think that it's not a decision we have to make right now.

If it returns, the LE definitely has an expiration. The only question is whether a value of 0 is the right way to say "I don't know which ledger sequence it was expired upon" or whether we should find another way to achieve that. I think that it's not a decision we have to make right now.

ok, is there a provision in spec for any type of LE's to not expire, and therefore have no expiration ledger, where 0 could denote that?

of course. only contract_data and contract_code would expire.. all the rest of the entries have no expiration associated with them ( at least for now ).


registerPrefix (https://biocomputeobject.org/api/docs/#/Prefix Management/api_prefixes_create_create): ${BCODB_URL}auth/register/

Swagger exists but getting 500 error code (internal server error) when trying it out.


Feature/merge vsts into azure pipelines

This PR provides cleanup and bugfix/enhancement work aimed at improving the level of support for Azure Pipelines. Changes include:

Merging ci_source/vsts.rb into ci_source/azure_pipelines.rb, combining their functionality as appropriate. As was noted as a p.s. on #1284, Azure DevOps (which contains Azure Pipelines) is the new name for what used to be Visual Studio Team Services, so these two CI sources were providing two partial implementations for what's actually one CI platform. With this change, azure_pipelines.rb provides a unified implementation which should support running on Azure DevOps pipelines, with repositories hosted in Azure Devops or elsewhere.

Making the changes necessary to support the VSTS request source from a local repository, via danger pr {pr_url}. By setting DANGER_VSTS_API_TOKEN and DANGER_VSTS_HOST, users can now test against an Azure DevOps pull request locally.

Worth noting is that while the VSTS request_source would likely be more appropriately renamed to "AzureGit" or something similar, I held off on making this change only because DANGER_VSTS_API_TOKEN and DANGER_VSTS_HOST reference the "VSTS" nomenclature, and I didn't want to cause a breaking change.

Closing with approvals, going to open PR into danger/danger.


Memory leak?

Reverb Version
1.0.0-beta4
Laravel Version
11.0.8
PHP Version
8.2
Description
The memory usage keeps increasing every time events are triggered.
On a test server, I triggered ~20 events, and the memory usage increased by 200kb (and never goes back down).
Reverb memory usage on LIVE server:
11.04 21:40 120MB
12.04 08:40 218MB
I'm using Telescope as well, and yesterday Reverb ran out of memory.
INFO  Starting server on <IP_ADDRESS>:8080 (...).

   Symfony\Component\ErrorHandler\Error\FatalError

  Allowed memory size of 268435456 bytes exhausted (tried to allocate 2097160 bytes)

  at vendor/laravel/telescope/src/Telescope.php:329
    325▕         }, static::$tagUsing)));
    326▕
    327▕         static::withoutRecording(function () use ($entry) {
    328▕             if (collect(static::$filterUsing)->every->__invoke($entry)) {
  ➜ 329▕                 static::$entriesQueue[] = $entry;
    330▕             }
    331▕
    332▕             if (static::$afterRecordingHook) {
    333▕                 call_user_func(static::$afterRecordingHook, new static, $entry);

   Whoops\Exception\ErrorException

I've tried disabling Telescope, but the memory still grows. So it's not related to Telescope.
Steps To Reproduce

Watch memory usage with for example htop
Trigger some events

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to open up a new issue with a link to the original one and we'll gladly help you out.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!

@driesvints I think this is worthy of being re-opened given you told @vatsake to ask in places like Discord first, but they already had done so.
Also, why point people to places like Discord where there’s no input from Laravel team members? @vatsake has clearly outlined the problem and also steps to reliably reproduce the issue. This is clearly a bug, hence it bringing it to the attention of the Laravel team. This clearly isn’t a “RTFM” or “you’re using it wrong” issue, and is a bug that needs addressing either via a PR or a Laravel team member.

@martinbean We haven't gotten other reports of this yet. And I've already asked them to re-open an issue with a repo and specific steps so we can reproduce: https://github.com/laravel/reverb/issues/146#issuecomment-2051511058
"Watch memory usage with for example htop & Trigger some events" just isn't a clear way to reproduce sorry. It didn't seem like an actual bug in Reverb to me, hence why I redirected to a support channel. If we can have a repo and a clear way to reproduce then we can have another look.


fix: add semantic release.

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


POSIX: Add more of important headers/content

This is a few more headers/defines which for some reason didn't go in https://github.com/zephyrproject-rtos/zephyr/pull/16621. All the same discussion as applied to it, applies here. Summary: a) these just add (missing) content, don't change stuff, so should be good to go; b) these are very important to ensure actual possibility to use POSIX applications with Zephyr.
Fixes: #18693

@galak: This PR is needed for GoogleIoT Zephyr port. Please approve, and if merging requires passing thru API review/TSC meeting, please help with that. Thanks!

Thanks for the reviews here!
Rebased on master, added "Fixes:" header with reference to a bug, added dev-review/TSC labels, whatever is needed to get it merged.

Yeah, this looks like a bug, so no need to get it discussed in TSC.
@galak @nashif FYI


[AKS] Engineering improvement: replace addon strings with constants

Description

Engineering improvement: replace AKS addon strings with constant variables.
Testing Guide

N/A
History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

AKS

hi @arrownj could you pls review this one? thanks


Started running ESLint Workflow on push to main

Current dependencies on/for this PR:

main

PR #322   👈

This comment was auto-generated by Graphite.


Create method assist not triggering inside ternary operators

If you have the following code, it doesn't trigger the Create method assist:
class A {
  void m1(int i) {
    m2(i == 0 ? m3 : (v) => v);
  }
  void m2(int Function(int) f) {}
}

But if you have the following it does:
class A {
  void m1(int i) {
    m2(m3);
  }
  void m2(int Function(int) f) {}
}

I volunteer to fix this.

Closed with https://dart-review.googlesource.com/c/sdk/+/384941.


Switzerland and Switz

https://www.classdojo.com/ul/p/addKid?target=class&class=CHUE5EH

Them damnedest


MSID: 92644 Version: 2 DOI: 10.1101/2<IP_ADDRESS>8218

MSID: 92644
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>8218
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=92644
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>8218

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/92644v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>8218
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/92644/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Ang Li wrong email address, otherwise fine to QC

Thanks @rkcook312. I've uploaded a corrected package. Should update in the next few hours.


Error: Cannot handle unknown node raw when using with @mdx-js/mdx

I am trying to use remark-shiki-twoslash with<EMAIL_ADDRESS>(v2) and have the following error:
Error: Cannot handle unknown node `raw`

Full details are on this issue https://github.com/mdx-js/mdx/issues/1820

Cool, makes sense, you're welcome to take a look at switching to rehype raw 👍🏻

I was getting this error when specifying filename in the markdown.
Changed

```ts:myFilename.ts

to

```ts

and this error went away.

If anyone else is struggling with this, and also tried going down the rehype-raw rabbit hole (and failed), I've made a workaround:
// This is an excerpt from a @docusaurus/preset-classic docs object
remarkPlugins: [
  require("remark-shiki-twoslash").default,
  require("remark-html-to-jsx"),
],

remark-html-to-jsx is a custom remark plugin I made to basically do what rehype-raw is supposed to do. It finds any nodes with the type html (which is what remark-shiki-twoslash outputs) and converts that html into JSX nodes by using reacts dangerouslySetInnerHTML property. It's a total hack, but it works great for my needs. Figured I'd share:
https://github.com/ksandin/yas/blob/dcf62f7637f7a85f9ce1598851bc26d938314df5/packages/remark-html-to-jsx/index.js

Running into this now with Docusaurus v3 stable release. I will try to use @ksandin's workaround (it's not a published package, so need to bring it in manually).

So, I patched docusaurus-preset-shiki-twoslash using the remark-html-to-jsx idea like this:
// at the top
const remarkHtmlToJsx = require('./remark-html-to-jsx')

// in `addTwoslash`
a.beforeDefaultRemarkPlugins.push([twoslash, options], remarkHtmlToJsx)

And that does "fix" the error, but it appears the resulting HTML set is not processed through MDXComponents:

That div should really be CodeBlock, and so Twoslash does compile/run its logic but because the React component isn't used, there's only static HTML on the page without annotations/styles.

So, this issue from 2021 means that docusaurus-preset-shiki-twoslash is currently completely unusable by anyone who dare use an up-to-date version of Docusaurus? Cool.


chore(reports): Improving logging around failed scheduled reports

SUMMARY
Improving logging around scheduled reports. In the event that an unknown failure occurs, the current behavior is to log an info with only the description of the associated exception. This PR updates this logic to include a stack trace for better triage.

🏷  preset:2022.17


How to get banner height dynamically?

First, thank you for this solution!
I am trying to position all the elements on the page relatively to a banner so it does not cover important parts. But I don't quite get how to get exact height of the banner after it has been loaded and showed. Could you help with that please?
Thank you and sorry for a nooby question.

The Github issue section isn't for support purposes. Sorry. :(


onEnter / onLeave functionality (access to state)?

I had some frustration with redux-router both from configuration point of view and from impemenentation of something like requireAuth() function checks, that used in onEnter() hooks to prevent access to autorized only application parts.
redux-router has an issue with that and I'm trying to understand, does it this also relate to redux-simple-router project.
Can state be accessed easily with this router?

I don't think that issues applies to us at all, because we aren't doing anything with onEnter. That's 100% a react-router thing.
You are creating the store and the routes somewhere in a top-level file in your app, right? What you should probably do is install an onEnter hook into react-router that closes over the store that you've created, and you can simply call store.getState. Or you can use the createElement paramter of the Router; that's usually a better option than onEnter. It's totally up to you how to use react-router, but you should have a reference to store wherever you are doing that.
We definitely need a few example, and I will get to that soon.

Thanks for your comments,
Just for the record, this is the approach I really liked instead of using onEnter use requiredAuth component, joshgeller/react-redux-jwt-auth-example/.

@jlongster Did those examples get made?
Cheers

We never made an official example is this usage, but several people in the community made many examples and one of them probably uses it: https://github.com/reactjs/react-router-redux#examples

For reference, this is what I did.
Pass the getState function to the router component.
export default class Root extends React.Component {
  render() {
    const { store, history } = this.props;
    const { getState } = store;
    return (

      <Provider store={ store }>
        <div>
          <RTRouter history={ history } getState={ getState }/>
          <DevTools />
        </div>
      </Provider>
    );
  }
}

User the getState function in the requireAuth method to read from redux state.
export default class RTRouter extends React.Component {

  constructor() {
    super();

    this.requireAuth = this.requireAuth.bind(this);

    // Configure routes here as this solves a problem with hot loading where
    // the routes are recreated each time.
    this.routes = (
      <Route path='/' component={ ReagentTracker } >
        <IndexRoute component={ Home } />
        <Route path='about' component={ About } />
        <Route path='login' component={ Login } />
        <Route path='authzone' component={ SecretStuff } onEnter={ this.requireAuth } />
      </Route>
    );
  }

  requireAuth(nextState, replace) {
    const { getState } = this.props;

    // Use my reselect selector to determine if we are authenticated or not
    // Obviously this is not complete, but at this point it's easy to redirect or
    // initiate an action in order to login via cookie or whatever
    if (!isLoggedIn(getState())) {
      console.log("Not logged in");
    } else {
      console.log('We are already logged in');
    }
  }

  render() {
    const { history } = this.props;
    return (
      <Router history={ history }>
        { this.routes }
      </Router>
    );
  }
}

Another option is to pass the store directly: onEnter={(store) => requireAuth(store)}.


provide debugging access to signed URLs

provide a way to obtain in string form the signed URL. this is very important for debugging purposes.

Done, now you have the debug method on the ServiceBuilder


Doors can try closing even if they can't successfully close

So the door tries to close continuously despite immediately re-opening.

This may possibly be intended behavior since motion sensor doors do this and its a star trek joke.


The user_groups API doesn't show the full list of available groups

Doing the GET to the user_groups endpoint the federation registry dos not show the full list of available groups

When adding multiple providers, the current behavior is that the DB stores only the last received list of user groups. The correct behavior should be that it extends the list of the user groups instead of replacing it.
We need to investigate if this is a problem rooted in the 'update' operation of the fed-reg or if it is an error in the feeder script.


Cut command

This pull request introduces the cut command.
It relies on a delete selection command, which deletes all nodes in a given range and returns them.
These nodes are then used to set the clipboard data.

I found another bug where if you select a list element from the start but not till the end, the wrong selection gets copied. I will also try to fix this,


Readd "Adds Senior Engineering Gear to Atmos loadouts #199"

Check #199 for reference

# Goobstation
:)

erm no

erm no


feat(headless): refactored generated answer controllers to support working in multiple use cases

SFINT-5199
In this PR I refactored the Generated Answer Headless controller in order to have the following:

A core Generated Answer Headless controller that contains the majority of the logic that will be used by both the search use case and insight use case.
A Search Generated Answer Headless controller, the controller that will be used in the search use case.
An Insight Generated Answer Headless controller, the controller that will be used in the insight use case.
Added the generated answer pipeline rule parameter to the insight query sent to the Customer Service API.
Added a step to create the Generated Answer API client in the Insight engine.

The RGA component inside the Hosted insight panel
https://github.com/coveo/ui-kit/assets/86681870/5062454d-5f13-44a3-bafa-d66e4b50a16f

Weird spam from the .dev github code review screen haha just check the first batch of comments.


Fix make test on non-x86_64 arches

The tests in test can only  be built on x86_64 as test/fcos.go uses a getFCOSDownload method which is only defined in test/fcos_amd64.go
This means go test ./test will only be buildable on an x86_64 machine.
This is problematic as make test in .github/workflows/go.yml is run on a macos node which can be arm64 or amd64, and thus the action will fail depending on which node is picked.

macos-latest github runners are switching to M1 which do not support nested virt, which is going to be another issue for our tests. https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
The ubuntu runners may support nested virt now though https://github.com/actions/runner-images/issues/7541

I created https://github.com/containers/gvisor-tap-vsock/issues/358 for this.

This was fixed by #362