[HUDI-2103] Add rebalance before index bootstrap

Add rebalance before index bootstrap.
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #3185 (a25a3f7) into master (b8a8f57) will decrease coverage by 41.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #3185       +/-   ##
============================================
- Coverage     44.25%   3.07%   -41.19%
+ Complexity     4598      82     -4516
============================================
  Files           825     280      -545
  Lines         36580   10875    -25705
  Branches       3942    1106     -2836
============================================
- Hits          16189     334    -15855
+ Misses        18645   10515     -8130
+ Partials       1746      26     -1720

Flag
Coverage Δ

hudicli
?

hudiclient
0.00% <ø> (-16.45%)
:arrow_down:

hudicommon
?

hudiflink
?

hudihadoopmr
?

hudisparkdatasource
?

hudisync
5.38% <ø> (-48.67%)
:arrow_down:

huditimelineservice
?

hudiutilities
9.46% <ø> (-48.98%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a8f57...a25a3f7. Read the comment docs.

index_bootstrap 可否单独设置parallelism，运行初始化用到的资源 比后边流数据的资源大的多

index_bootstrap 可否单独设置parallelism，运行初始化用到的资源 比后边流数据的资源大的多

+1, You can file a Jira ticket.

index_bootstrap 可否单独设置parallelism，运行初始化用到的资源 比后边流数据的资源大的多

I think index_bootstrap parallelism define by flink parallelism, if need bootstrap you can set a large parallelism for flink job and narrow flink job parallelism after bootstrap.

index_bootstrap 可否单独设置parallelism，运行初始化用到的资源 比后边流数据的资源大的多

I think index_bootstrap parallelism define by flink parallelism, if need bootstrap you can set a large parallelism for flink job and narrow flink job parallelism after bootstrap.

reasonable opinion, IMO, it's a trade-off. Split parallelism more clear for function, merge parallelism more clear for configuration.

index_bootstrap 可否单独设置parallelism，运行初始化用到的资源 比后边流数据的资源大的多

I think index_bootstrap parallelism define by flink parallelism, if need bootstrap you can set a large parallelism for flink job and narrow flink job parallelism after bootstrap.

we do this practice now,   but it's complex ,  we need restart  the job and  change the configuration 。hopefully bootstrap can auth release the resource ,but it's sound difficult

index_bootstrap 可否单独设置parallelism，运行初始化用到的资源 比后边流数据的资源大的多

I think index_bootstrap parallelism define by flink parallelism, if need bootstrap you can set a large parallelism for flink job and narrow flink job parallelism after bootstrap.

we do this practice now, but it's complex , we need restart the job and change the configuration 。hopefully bootstrap can auth release the resource ,but it's sound difficult

That because Flink unsupport change parallelism when job running.


fastlane init fails, missing company name, creating first app in app store connect

https://github.com/fastlane/fastlane/issues/16759 and https://github.com/fastlane/fastlane/issues/15252 fully document the issue as I'm experiencing it. Both these were closed by the bot, but are still a reproducible issue.
TL;DR, fastlane init fails on creating the app in AppStore Connect. I'm not sure the scenario under which it actually works.
Is fastlane init no longer supported for iOS?
Looks like the error might be somewhere near https://github.com/fastlane/fastlane/blob/e9b79e422b5161fdae9309ed60872288ae5cb583/spaceship/lib/spaceship/portal/portal_client.rb#L202. It doesn't look like anyone has touched much in that file in few years.
@joshdholtz since you're listed as the lead maintainer of this project, and the previous issue went unnoticed by anyone on the team, I'd like to bring this to your attention. I understand you might not be the most knowledgable dev on the team in this area, but maybe you know of someone who can help. Thanks.

Hi @ryanhanks, do you try to create your first app on Appstore Connect account?  If that's the case, you need to pass company_name which will be used as developer name on AppStore (the one below the name of the app on app's page) - it is required only when creating first app. You can set it withPRODUCE_COMPANY_NAME env variable:
PRODUCE_COMPANY_NAME="YOUR COMPANY NAME" fastlane init

Thanks @lucgrabowski, I'll give that a try today and report back.

I've opened PRs to add this information in getting-started docs: https://github.com/fastlane/docs/pull/1066 and create_app_online action docs: https://github.com/fastlane/fastlane/pull/18934

PR #18934 is merged so closing this issue! Thank you @lucgrabowski


Update style of card and put the logo in the navbar

Thanks for your support we really appreciate it.


Add support for manipulating wheel build/test matrices downstream

Similar to #62, except for wheel workflows instead of conda workflows.
This PR also sets the default shell to bash for consistency with the conda workflows.
Closes #63.

Testing changes in https://github.com/rapidsai/rmm/pull/1243

Testing in https://github.com/rapidsai/rmm/pull/1243 worked as expected.
Marking this PR as ready for review.

Looks good. Can you please push these updates (conda and pip) into the cuda-12 branch? They'll need a bit of editing to avoid merge conflicts, I think.

No problem. I've already merged the conda changes to that branch. I plan on doing the same for these changes :+1:

Looks good. Can you please push these updates (conda and pip) into the cuda-12 branch? They'll need a bit of editing to avoid merge conflicts, I think.

No problem. I've already merged the conda changes to that branch. I plan on doing the same for these changes +1

Merged: https://github.com/rapidsai/shared-action-workflows/commit/fb96256a3e315f1923577b45619ee077940b3594


Nonce MGMT

Overview
We should track our own account nonces because it would be more reliable than relying on get_transaction_count(), especially during re-orgs and stuff.
This is kind of a bug right now related to this: If you make a transaction, get the receipt, but then a re-org happens (which is common), then make another transaction, it will have the nonce of the original and you will be in a weird state
If we manage our own, we would already know what the nonce for the second transaction should be.
Specification
Somehow, the `ReceiptAPI
Dependencies
Will be easier to work on post #277

Could use a cache file underneath a network's data folder (which should be underneath an ecosystem plugin's data folder?) to keep track of this between calls/sessions, and then validate what the network state is, and take steps to identify still pending transactions and other experience improvements if there is a mismatch between that and ProviderAPI.get_nonce(acct)

Re: "take steps to identify still pending transactions".
Two questions there:

What is the best way to check for these? Call provder.get_block("pending") and check for an account?
What is the use-case for this? Like the user can create a Recept object from these pending txns in a different session than the one that they were created in?

What is the best way to check for these? Call provder.get_block("pending") and check for an account?
Naw, that is for pending blocks, not pending transactions

What is the use-case for this?
Let's say you submit a transaction with low fee and exit any ape sessions. When you re-enter, your transaction is still pending, and now all of a sudden you want to submit a higher fee for that transaction so you can submit another more important transaction. How do I find that old transaction? Am I warned that I still have a pending transaction? Do I decide to cancel it instead of updating the fee?

Like the user can create a Recept object from these pending txns in a different session than the one that they were created in?
Yeah, in general a user should be able to get transaction receipts for any other transaction, but especially for unconfirmed transactions they might want to resubmit with higher fee, or cancel


[MdSelect] Width of options container not resized after window resize

Bug, feature request, or proposal:
Click a select to open the options, close it. Resize the window. Reopen the options, the width does not update.
What is the expected behavior?
The options should be parent size dependent like native html select.
What is the current behavior?
The options width does not update after a window resize.
What is the use-case or motivation for changing an existing behavior?
UX
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 4.3.1
Material 2.0.0-beta.8

+1

It also happen when you rotate screen orientation from portrait to landscape

this should be fixed in https://github.com/angular/material2/pull/14932

this shold be fixed with https://github.com/angular/material2/pull/14932


(client) Server list back-button does not do anything

I am having this issue in both patch <IP_ADDRESS> and patch <IP_ADDRESS>. For diagnostic reasons I checked if it works on patch 0.4.4 and it seems to be mapped correctly.
Beatsaber Version:
0.10.2p1
Hardware:
HTC Vive
(I also have seen this issue with my friend who plays on the oculus rift, but he uses steamvr)

Fixed in <IP_ADDRESS>


Enable load extension by code dynamically

Motivation:
Enable load extension by code dynamically
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #535.
If there is no issue then describe the changes introduced by this PR.

ci没过


Envoy ALS mx-mesh should resolve service name from another position

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[x] Feature or performance improvement

Requirement or improvement
Since Istio injects  service.istio.io/canonical-name to the pod as the service name, OAP Envoy receiver should update https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/metadata-service-mapping.yaml to replace LABELS.app with this canonical label.

Is this another key in the identify?


How do I control ring size?

I can't figure out how to do this in the TF syntax, or even how to do this in ring2.py. I keep running out of memory on the GPU, slowly, as the pipeline progresses, so need some manual control (at least, I think it's because the ring buffers keep getting bigger?)

Ring size is determined by the gulp_nframe and buffer_factor arguments to a Block. Currently buffer_factor defaults to 3.
What you describe sounds like a memory leak, which is not supposed to happen. Do you have a simple repro script?

will look into this shortly, working on other things. It is possible/likely/near certain that I munged something in my CUDA kernel.

Closing for now


Add resources around agile-coretime

https://polkadot-public.notion.site/Agile-Coretime-FAQ-c930796e8c884011adb1fa24ef22f77c#2007eb68754a48beadaf8b76fbfe60b8
https://lastic.xyz/
regionX-Labs

and more please :)

These resources were added in #28, thank you for sending this over ser!


feat(cdk/table): add optional footer to cdk-text-column

Added two new inputs to CdkTextColumn:
footerText (string) and footerTextTransform (function), automatically inherited by MatTextColumn.
If the table does not define a footer, the column footer will be ignored.
Additionally, TextColumnOptions includes a new default function called defaultFooterTextTransform, used when neither footerTextTransform nor footerText are provided.
Fixes #24532

@crisbeto this one is also green now.


Feature extension

This adds many new features including a timer built into the extension itself, as well as github API requests for the daily curriculum.

@composerinteralia The desk hash set up was basically unchanged except that it is now all that is left in the options dialog, you can access it by clicking on the AA logo in the top left.

I get Cannot read property 'launchWebAuthFlow' of undefined(…) when I try to authorize with github. What am I missing?

We still need a way to set the desk number. Once set, the number should show up in the diamond thing next to the time, and it should also be put into local storage to create the deskHash.
Also, let's put the city id in local storage right away. It's not obvious that you have to specifically click on it to get it there.

Another small thing if you have time for it: when I first type the password and press enter it clears the input and closes the modal. The second time it doesn't do either of those things, nor is there any other feedback to indicate the password has updated (although if you check localStorage it does indeed update). I like the first behavior better. Could we have it do that all the time?

Yeah, so for the first, it just needed to reload some new privileges for the launchWebAuthFlow. To the second, when you have the desks modal up you can click a particular desk to set it. And I'll look into improving the behavior of the password modal.

Oh great! I didn't notice the desks were clickable.

@composerinteralia so, I modified the desk-hash modal functionality. But now that I'm taking another look at it, do we really want to be storing the password for the desk hash calculation on the local state? Would it be better if we didn't store it at all and the desk hash would only be calculated when the password is changed?
I'll get started on storing the cityId right on startup.

The City id bug is fixed now, should set it in local storage right away

Yeah, that would definitely make more sense than putting the password in local storage. We didn't worry about it the past because by the time students learn about local storage we usual aren't as worried about checkins. Thanks again for your hard work on this!

Done and done. You should double check that the desk hash is still properly working as I had to change it's setter function.

Everything seems to be working correctly on my end. Many thanks for the notification!

@composerinteralia: You may merge when ready.


add frozen to Config

closes #231

I think we need a different error message, e.g something like "Model is frozen", rather than "Field".

Codecov Report

Merging #237 (252f91e) into main (837a6ce) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   98.61%   98.37%   -0.25%
==========================================
  Files          51       51
  Lines        5342     5286      -56
  Branches       39       39
==========================================
- Hits         5268     5200      -68
- Misses         74       85      +11
- Partials        0        1       +1

Impacted Files
Coverage Δ

pydantic_core/core_schema.py
99.39% <100.00%> (-0.61%)
:arrow_down:

src/validators/typed_dict.rs
99.08% <100.00%> (-0.02%)
:arrow_down:

src/input/input_abstract.rs
96.47% <0.00%> (-3.53%)
:arrow_down:

src/errors/kinds.rs
96.63% <0.00%> (-2.53%)
:arrow_down:

src/validators/recursive.rs
98.24% <0.00%> (-1.76%)
:arrow_down:

src/validators/int.rs
98.76% <0.00%> (-1.24%)
:arrow_down:

src/validators/tuple.rs
97.16% <0.00%> (-0.71%)
:arrow_down:

src/validators/function.rs
98.84% <0.00%> (-0.58%)
:arrow_down:

src/input/input_python.rs
98.14% <0.00%> (-0.26%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837a6ce...252f91e. Read the comment docs.

@samuelcolvin Thanks for your remark and sorry for coming back to it so late.
Is https://github.com/pydantic/pydantic-core/pull/237/commits/f8e1092cd573f0d93a528b3256d1860416e3374e ok for you?

Maybe it would all be simpler if we just added frozen to SchemaValidator, then check checked in validate_assignment?
That way we can "freeze" any schema.
E.g. if we added validate_assignment logic to tuples, frozen would just work.
If not that, then I think we should just add frozen to TypedDictValidator do the check in TypedDictValidator.validate_assignment.
WDYT?


[DOC] Building data visualizations page on 1.3 is broken

What do you want to do?

[ ] Request a change to existing documentation
[ ] Add new documentation
[x] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
The Building data visualizations page on the 1.3 version is missing many of the images. i.e. broken images.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

@ashwin-pc Resolved issue. See PR https://github.com/opensearch-project/documentation-website/pull/3231/files


License?

Would you mind licensing this under a commercial share-alike license, such as MIT?

@dhempy, of course! Just approved and merged your PR with the license in it.


🙉response ONLY for specific http request

Android Studio 3.6
here my Espresso test:
import okhttp3.mockwebserver.MockResponse
import okhttp3.mockwebserver.MockWebServer

@Before
fun beforeEach() {
    mockServer = MockWebServer()
    mockServer.start(8081)
    Debug.d(TAG, "SUCCCESS_START_MOCKWEBSRVER")
    mainActivityIntentTestRule.launchActivity(Intent())
}

@After
@Throws
fun afterEach() {
    // We're done with tests, shut it down
    mockServer.shutdown()
}

@Test
fun someButton_click_checkRequest() {
    mockServer.enqueue(
        MockResponse()
            .setResponseCode(200)
    )
    someButton.click()
    val request = mockServer.takeRequest();
    Assert.assertEquals("POST", request.method)
}

Is it possible to create mockResponse that response ONLY for http request that in url has the next text = "/event?table_token" ?

Thanks for your question. This issue tracker is only for bug reports with test cases and feature requests. Please ask usage questions on Stack Overflow.
https://stackoverflow.com/questions/tagged/okhttp


FR: Add to Readme - How does the project compare to the macOS's "Optimized battery charging"?

Is your feature request related to a problem? Please describe.
A related question appeared in #11, asking whether it'd be a good idea to disable the system-wide "Optimized battery charging" toggle with this app on.
Describe the solution you'd like
Providing more information in README.md on the benefits of using this application rather than the included with macOS "Optimized battery charging" option.
That'd probably involve figuring out how it works - answering questions such as e.g.:

Since the Optimized battery charging setting's description mentions "learning the charging routine", is there any way to view/tune/reset the details the OS has so far gathered?
After it reaches a satisfying battery charge level and machine is still plugged in, is it going to switch over to using the power adapter as the sole power source, or will it trickle charge the battery - perhaps based on system load or else?

Describe alternatives you've considered

State that the project has the same goal as the OS setting, but has a stricter scope - it never goes up to 100%.
Its mechanism is already described - starting at the "Please note that the app:" line. For better reading at a glance, it could be moved into a separate section to make it stand out.
Perhaps the application could also check whether the OS setting is turned on, and suggest toggling it to avoid interference? Otherwise state it in the readme.md as well.

Additional context
N/a

I'd love a PR for this. Do you have the time?

Maybe this is relevant for context: #163
The main differences I found are:

There is no manual control with "Optimized battery charging". For example, I had it for a few weeks and no limit was activated by my MacOS.
The daemon solution can keep an arbitrary limit rather than only 80%.

That being said, I am now inclined to use only the firmware limit because I expect it to be healthier for the battery (less cycles, developed by Apple, etc.) compared to a userspace solution (like AlDente or similar tools). And the "optimized charging" feature, at least for me, is not very useful as it has not triggered any limit yet. Maybe I am too inconsistent for Apple's ML algorithms 😆

Hey!
I'd be willing to work on a update to the readme.md file concerning the difference & advantage of battery vs optimized charging -- but I just want to clarify that adding a section to the readme is the only update, and there isn't anything that has to do with changing the optimize battery on/off in relation to if batteries on/off.
Just wanted some clarification.
:D


Performance improvements of HashMap.put

Java HashMap bench took 0.121 sec.
Java TreeSet bench took 0.24 sec.
Javaslang HashMap bench took 2.811 sec.
Javaslang TreeSet bench took 0.829 sec.

10x faster on my computer (was about 20 sec)

After having slept about it I'm sure we can boost internal operations from O(n) to O(log n) or even eff. O(1). I will check that.


Game freezes

Describe the Bug
When I try to open the Windows GUI, my game is freezing for almost 1 minute! And while the Window in open, my FPS/UPS drops to below 20FPS! Normally it runs between 45 and 55 FPS
To Reproduce
Steps to reproduce the behavior:

Use the keyboard shortcut / or button to open the Window GUI
The game freezes for a while before the Windows is opened!

Be certain to reproduce the issue on the same save file that you upload.
Save file & Username
Entire personal Factorio folder, with the saved game and all my mods:
https://www.dropbox.com/scl/fo/3o1jg0bblg3vpfeg91kek/h?dl=0&rlkey=kly3f352ieww2658zlc0imp12
Log file
factorio-current.log
Game version
Factorio 1.1.80

I've been running into the UPS drop issue as well, though my UPS only drops when the stations tab is selected in LTN manager; switching to eg the inventory tab will cause the UPS to go up again.
The weird thing is that the UPS drop persists even after the LTN manager window is closed, if the stations tab was selected when closing the window.

I've been running into these issues as well, though my UPS only dropped when selecting the stations tab in LTN manager; switching to eg the inventory tab will cause the UPS to go up again.
The weird thing is that the UPS drop persists even after the LTN manager window is closed, if the stations tab was selected when closing the window.
In the past, I sometimes had UPS drops in the stations tab, but more recently trying to open the stations tab has started to completely freeze the game. I tried to just wait for a couple of minutes hoping that it might continue working eventually, but that is not the case.
Update: after trying to look into this a bit more, it seems to me that the underlying issue here is that either the mod or Factorio itself is having issues rendering the list of train stops. I had a look at Factorio's stack trace while hanging after switching to the stations tab, and essentially all of the GameUpdate thread's work was calculating widget frames and sizes, so maybe that's the issue here? (I have ~4000 train stations, which has already caused the stations list to become really slow in the past, though it never caused a complete hang...)

The same problem here! Your explanations is much better. But in my case, the game resume after 1 or 2 minutes after I opened the Stations tab, but I only have 750 stations!
Thanks

+1

In Factorio version 1.1.79 (March 30th) on_gui_hover was implemented, but accidentally caused a massive performance hit to tooltip creation (there's about 4 tooltips created per train station, at a current cost of 10ms+ each)
Developer says this has been fixed for the future 1.1.82 release

This has been reported fixed on my discord in 1.1.82 (which is now in experimental).


refactor: rename from → on

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
608

Relevant Lines:
608

💛  - Coveralls


featureIdx shuffling results in wrong featureIndex in the tree

I am testing with the following data
[1.0,  2.0,  2.5,  0.2,
2.3,  5.0,  0.75, 0.9,
1.3,  2.4,  1.9,  0.45,
10.3, 20.4, 10.9, 10.45]
and the following default parameters
IForest iForest = new IForest().setNumTrees(5)
.setMaxSamples(3)
.setContamination(0.3)
.setBootstrap(false)
.setMaxDepth(2)
.setSeed(123456L);
The trees are as follows:
tree[0]
featureIndex: 1
featureValue: 9.417743965315601
tree[1]
featureIndex: 0
featureValue: 4.977936221311794
tree[2]
featureIndex: 0
featureValue: 4.866908154888555
tree[3]
featureIndex: 1
featureValue: 9.391937564448492
tree[4]
featureIndex: 0
featureValue: 20.26467549071234
The final tree has a featureValue outside the range of values for featureIndex=0, i.e. between 1.0 -> 10.3.
I tracked the issue to line 553 in iForest.scala, where a shuffling operation happens on the feature indices, this reordering seems to be lost afterwards resulting later in wrong attrIndex. The attrIndex  was based on the shuffled data not the original one.

Another example where the features are chosen to be in different values range:
Data:
[1.0, 20.0, 200.5, 0.002
2.3, 50.0, 300.75, 0.009
1.3, 20.4, 100.9, 0.0045
10.3, 200.4, 1000.9, 10.45]
and the resulting trees are:
tree[0]
featureIndex: 1
featureValue: 9.371498894961741
tree[1]
featureIndex: 0
featureValue:<PHONE_NUMBER>4154924
tree[2]
featureIndex: 0
featureValue:<PHONE_NUMBER>1396512
tree[3]
featureIndex: 1
featureValue: 9.371498894961741
tree[4]
featureIndex: 0
featureValue:<PHONE_NUMBER>4154924

Thanks for reporting the problem. It was caused by the features sampling. I have just fixed it. You can check the latest codes in the master branch.


Transport.Produce(): type 'String' is not a subtype of type 'int'

Hi,
I have been trying to get the media soup flutter client working. I am having an issue with below code, which is part of transport.produce(). The input needed for this is a List but if I add more than one item (i.e. uncomment the two items below), i get an error "type 'String' is not a subtype of type 'int'".  The error goes away if I only have one list item. I was wondering if this an issue. Any help is appreciated?
encodings: [
        RtpEncodingParameters(
            rid: 'r0', scalabilityMode: 'S1T3', maxBitrate: 100000),
        // RtpEncodingParameters(
        //     rid: 'r1', scalabilityMode: 'S1T3', maxBitrate: 300000),
        // RtpEncodingParameters(
        //     rid: 'r2', scalabilityMode: 'S1T3', maxBitrate: 900000)
      ],

I also tried below approach, but received same error:
encodings: [
    RtpEncodingParameters.fromMap({
      'rid': 'r0',
      'maxBitrate': 100000,
      'scalabilityMode': 'S1T3',
    }),
    RtpEncodingParameters.fromMap({
      'rid': 'r1',
      'maxBitrate': '300000',
      'scalabilityMode': 'S1T3',
    }),
    RtpEncodingParameters.fromMap({
      'rid': 'r2',
      'maxBitrate': '900000',
      'scalabilityMode': 'S1T3',
    }),
  ],

Errror Received.
flutter: type 'String' is not a subtype of type 'int'
flutter: #0      Transport._produce (package:mediasoup_client_flutter/src/transport.dart:925:7)
<asynchronous suspension>
#1      FlexQueue._runTask (package:mediasoup_client_flutter/src/FlexQueue/flex_queue.dart:85:28)
<asynchronous suspension>

Hey @Blancduman , is the issue resolved?

I fixed it by using a local library and change the "id" in Rid to String from int
lib/src/handlers/sdp/media_section.dart:260
class Rid {
  final String id;
  final String direction;
  final String? params;

  Rid({
    required this.id,
    required this.direction,
    this.params,
  });

  Rid.fromMap(Map data)
      : id = data['id'],
        direction = data['direction'],
        params = data['params'];

  Map<String, dynamic> toMap() {
    return {
      'id': id,
      'direction': direction,
      'params': params,
    };
  }
}


Disable pyside2 test on windows CI

Description
I do not have idea how to fix Windows+Pyside2 test, so this PR disable it on CI.

I have created issue #6712


Enabling Ivy increases bundle size

🐞 Bug report
Command (mark with an x)

[x] build

Description
Looks like Ivy prevents tree shaking of not referenced components/injectables. It's either a bug, or positive difference in build size can only be seen if application code actually uses all features of all dependencies, which is not realistic.
🔬 Minimal Reproduction

Create a minimal application: ng new --defaults --minimal -S -s -t -g ivy-size
Build with and without ivy to measure bundle sizes of an empty app:

With "enableIvy": false: main-es2015 is 125 kB
With "enableIvy": true: main-es2015 is 103 kB ✔

Install package angular2-toaster: npm i angular2-toaster
Import ToasterModule in app.module.ts:

import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { ToasterModule } from 'angular2-toaster';
import { AppComponent } from './app.component';

@NgModule({
  declarations: [AppComponent],
  imports: [
    BrowserModule,
    ToasterModule.forRoot(),
  ],
  bootstrap: [AppComponent]
})
export class AppModule { }

Build with and without ivy again:

With "enableIvy": false: main-es2015 is 131 kB (increased by 6 kB)
With "enableIvy": true: main-es2015 is 144 kB❌(increased by 41 kB)

Add <toaster-container></toaster-container> to app.component.ts
Build again:

With "enableIvy": false: main-es2015 is 146 kB
With "enableIvy": true: main-es2015 is 144 kB

Sizes equalized, but now compare the final size with the size of an empty app:

build with "enableIvy": false increased by (146-125)=21 kB
build with "enableIvy": true increased by (144-103)=41 kB

I tried to make builds with command NG_BUILD_DEBUG_OPTIMIZE=minify ng build --prod and I noticed this difference in builds:

[ngSwitch] is used in component [toastComp], which is used by component <toaster-container>. But in <toaster-container>, component [toastComp] will not be displayed unless there's at least one element in array toasts. And to add an element I need to inject service ToasterService, which I do not do in my little app.

Here's my attempt to reproduce the issue without dependencies:

Create a minimal application: ng new --defaults --minimal -S -s -t -g ivy-size
Build with and without ivy to measure bundle sizes of an empty app:

With "enableIvy": false: main-es2015 is 125 kB
With "enableIvy": true: main-es2015 is 103 kB ✔

Replace app.module.ts with:

import { CommonModule } from '@angular/common';
import { FormsModule } from '@angular/forms';
import { BrowserModule } from '@angular/platform-browser';
import { Component, NgModule } from '@angular/core';

@Component({
  selector: 'app-root',
  template: '<child-component *ngIf="false"></child-component>',
})
export class AppComponent {}

@Component({
  selector: 'child-component',
  template: '<input ngModel>',
})
export class ChildComponent {}

@NgModule({
  imports: [
    BrowserModule,
    CommonModule,
    FormsModule,
  ],
  declarations: [AppComponent, ChildComponent],
  bootstrap: [AppComponent]
})
export class AppModule {}

Lets build it:

With "enableIvy": false: main-es2015 is 158 kB
With "enableIvy": true: main-es2015 is 157 kB ❌

the initial positive difference in size is gone.
Lets build with NG_BUILD_DEBUG_OPTIMIZE=minify&&ng build --prod:
By looking at difference in builds I can see that not used features of CommonModule are not removed:

Same for FormsModule:

Interestingly, some not referenced classes of @angular/forms are removed: I can find RadioControlValueAccessor but not PatternValidator or NgSelectOption.
🌍 Your Environment
Angular CLI: 9.0.2
Node: 12.13.0
OS: win32 x64

Angular: 9.0.1
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: No

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.2
@angular-devkit/build-angular     0.900.2
@angular-devkit/build-optimizer   0.900.2
@angular-devkit/build-webpack     0.900.2
@angular-devkit/core              9.0.2
@angular-devkit/schematics        9.0.2
@angular/cli                      9.0.2
@ngtools/webpack                  9.0.2
@schematics/angular               9.0.2
@schematics/update                0.900.2
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2
Anything else relevant?
I tried to set "sideEffects": false, in package.json of angular2-toaster, it didn't help.

Similar issue is already opened https://github.com/angular/angular-cli/issues/16866

As @sacgrover mentioned, this is a dupe of https://github.com/angular/angular-cli/issues/16866. I'll close this issue in order to consolidate similar issues.


Feature Request: Permit free choice of accent color

Feature Requested
Hello,
would it be possible to keep the option to freely choose the accent color ? I would like to have more contrast on the color, as the colors provided are a bit hard to read for me.
Thank you
Daniel
Relevant Screenshot(s)
No response
Relevance

[X] The feature would be useful to more users than just me.

Style Settings

[X] I have checked that the feature is not already available via the Style Settings plugin.

Hi! I have been meaning to rewrite the whole color system as it is really hard to work with in its current state. I was also thinking of adding a "custom" option to the "Accent color light" and "Accent color dark" dropdown menus. Would this fix your issue?

Yes, that would be perfect. Thanks :-)


AMO needs gentler error pages

Yesterday there were site outages and I was presented with a plain page that said "Error 503" and that was about it. No formatting or explanation.
We should have gentler pages for our users.
Most larger sites have some sort of custom pages in these instances which are less harsh and more informative.  Let's try and make ours more approachable and informative too.

@Caspy7 I think this can be covered by #908 - I made a similar suggestion there. Also because the banner in #908 is tricky e.g. if the app is down the only solution is to have something above the app serve a static page to users. Feel free to add this comment to #908 and then this one can be closed.

Marking as a dupe of #908.

Here we could use some self-contained static pages served for things like 5xx errors as currently they are blank.

See also #908 which is related.

This hasn't happened since the AWS switch over and is a pretty catastrophic problem that gets ops out of bed. I feel like its not worth investing anything on this with the re-design coming which will have a whole of new error scenarios to worry about.


Support for OpenAPI 3.x

Problem statement
Hi, right now it appears that this library only supports generating Swagger 2.0. I was wondering if it'd be possible to add support for Swagger/OpenAPI 3.x? I would be very interested in this. Thank you!
Swagger specification
https://spec.openapis.org/oas/v3.0.0
https://spec.openapis.org/oas/v3.1.0

See #1122
No support planned from current maintainers.

@gabrielhelix look at github.com/ogen

Ok so this is now written on the front door. Just too much work to be contemplated without sponsorship.


Winner is still 0x00000..

I have deployed the contract on Rinkeby but somehow the VRF is not retrieving the random winner. I have cloned the repo and changed the .env file with my credentials to check if I was missing something but the github one also retrieves a 0x00000 winner. Which could be the possible reasons why the chainlink VRF is not retrieving the randomness accurately? Any ideas on how to debug this?

Hey. I just checked and the random winner is now the address from where I deployed the contract i.e is working properly. I'm assuming here that the contracts throws the 0x00 address (deployer default value?) until the transaction is completely fulfilled.  I would love to have some light in this topic. Thank you.

Ahhh... It's just not sleeping long enough. Could you change time.sleep to a longer value?
Closing for now, but feel free to follow up.


Error orrurred: SNlM0e value not found in response. Check __Secure-1PSID value..

I have filled my bard Secure-1PSID value in config.yaml, and the bot was working fine before. However, recently the bot always responds with the error message 'Error occurred: SNlM0e value not found in response. Check Secure-1PSID value..'. Please fix this issue. Thank you.

The Secure-1PSID may expire after a certain period of time. You would need to retrieve it again from your browser and fill it in. Please follow the steps you took originally to get the Secure-1PSID, then update the value in the config.yaml file. After updating, restart your bot and see if this resolves the issue.

Have you restarted the bot? And please make sure you use the newest code.

Have you restarted the bot? And please make sure you use the newest code.

It works after I change the key to another account's one. Thx.


test_subscriber_restart is flaky

subj. @knizhnik thinks that timeout is too strict

@ololobus did you mean to pause this?  The test is still unstable

I marked it as paused because nobody was looking at it after merging an increased timeout. My plan was to look at the list of flaky tests and ask Konstantin to have another look if it's still flaky

I will look. It suffered from the same problem: failed to wait for replica sync. Looks like it is not just timeout problem. But I failed to reproduced it locally.

@knizhnik merged a related fix https://github.com/neondatabase/neon/pull/8472. Not sure it will help, but we can observe it for a few days and get back to it

Yes, we discussed that with Konstantin. I just wanted to link it because PR was a follow-up to the attempt to reproduce it locally. It fixes an issues with macOS, but in CI we use Linux. The next step could be to create a Linux VM and try to reproduce it there

Right, I was trying to fast-forward past the "observe it for a few days" part.

This week:

[ ] Continue investigation
[ ] Try to reproduce in EC2 if it won't work locally

Failed to reproduce it locally, neither at MacOS, neither at Linux (repeat tests hundred times).
Allure report logs do not provide some useful information: looks like for some reasons connection with published failed to be established.
subscriber:
PG:2024-07-30 17:22:42.290 GMT [292395] LOG:  [NEON_SMGR] [shard 0] libpagestore: connected to 'postgresql://no_user@localhost:21282' with protocol version 2
PG:2024-07-30 17:23:18.206 GMT [292388] LOG:  data stream from publisher has ended
PG:2024-07-30 17:23:18.206 GMT [292388] ERROR:  could not send end-of-streaming message to primary: server closed the connection unexpectedly		This probably means the server terminated abnormally		before or while processing the request.	no COPY in progress

publisher:
PG:2024-07-30 17:22:42.256 GMT [292390] LOG:  [walsender] connection to <IP_ADDRESS>:21285 to fetch WAL succeeded, running START_REPLICATION PHYSICAL 0/1000000 (term='2')
PG:2024-07-30 17:22:42.256 GMT [292390] STATEMENT:  START_REPLICATION SLOT "sub" LOGICAL 0/1959560 (proto_version '2', publication_names '"pub"')
PG:2024-07-30 17:22:42.257 GMT [292390] LOG:  logical decoding found consistent point at 0/174FB58
PG:2024-07-30 17:22:42.257 GMT [292390] DETAIL:  There are no running transactions.
 And got interesting results. My original assumption was that for some reason replication was stuck.
But looks like it is to true. Please look at flush_lsn of primary before we begin to wait subscriber to caught up.
It is 0/292A7E0. At 5-th iteration subscriber receives WAL up to 0/292A9E0
2024-08-03 09:53:36.569 INFO [test_subscriber_restart.py:63] flush_lsn=0/292A7E0
2024-08-03 09:53:36.574 INFO [test_subscriber_restart.py:27] received_lsn=0/1964B10
2024-08-03 09:53:36.585 INFO [test_subscriber_restart.py:30] count=7824
2024-08-03 09:53:36.586 INFO [utils.py:403] waiting for <function test_subscriber_restart.<locals>.check_that_changes_propagated at 0x7f650bf3edc0> iteration 1 failed
2024-08-03 09:53:37.87  INFO [test_subscriber_restart.py:27] received_lsn=0/2328A40
2024-08-03 09:53:37.169 INFO [test_subscriber_restart.py:30] count=62619
2024-08-03 09:53:37.169 INFO [utils.py:403] waiting for <function test_subscriber_restart.<locals>.check_that_changes_propagated at 0x7f650bf3edc0> iteration 2 failed
2024-08-03 09:53:37.670 INFO [test_subscriber_restart.py:27] received_lsn=0/292A8C0
2024-08-03 09:53:37.761 INFO [test_subscriber_restart.py:30] count=96271
2024-08-03 09:53:37.761 INFO [utils.py:403] waiting for <function test_subscriber_restart.<locals>.check_that_changes_propagated at 0x7f650bf3edc0> iteration 3 failed
2024-08-03 09:53:38.262 INFO [test_subscriber_restart.py:27] received_lsn=0/292A9E0
2024-08-03 09:53:38.342 INFO [test_subscriber_restart.py:30] count=96271
2024-08-03 09:53:38.342 INFO [utils.py:403] waiting for <function test_subscriber_restart.<locals>.check_that_changes_propagated at 0x7f650bf3edc0> iteration 4 failed
2024-08-03 09:53:38.843 INFO [test_subscriber_restart.py:27] received_lsn=0/292A9E0
2024-08-03 09:53:38.959 INFO [test_subscriber_restart.py:30] count=96271
2024-08-03 09:53:38.960 INFO [utils.py:403] waiting for <function test_subscriber_restart.<locals>.check_that_changes_propagated at 0x7f650bf3edc0> iteration 5 failed

So it receives all WAL after the end of all inserts but still count is smaller than expected - loos like subscriber doesn't receive all records.

Looks like it's much more stable after all the fixes -- 99% for the last 7 days, so closing

For some reason, it got much more flaky again and got back to ~90% stability. Let's have another look, reopening

I inspected several recent failures of this test.
Looks like now they are not related with LR itself. All testsI inspected are failed with the following error:
RuntimeError: Run ['/tmp/neon/bin/neon_local', 'endpoint', 'start', '--safekeepers', '1', 'ep-2'] failed:
  stdout:
    Starting existing endpoint ep-2...
    Starting postgres node at 'postgresql://cloud_admin@<IP_ADDRESS>:15387/postgres'
    SIGKILL & wait the started process
  stderr:
    command failed: timed out waiting to connect to compute_ctl HTTP

    Caused by:
        0: error sending request for url (http://<IP_ADDRESS>:15388/status)
        1: client error (Connect)
        2: tcp connect error: Connection refused (os error 111)
        3: Connection refused (os error 111)

    Stack backtrace:
       0: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
                 at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/result.rs:1989:27
          control_plane::endpoint::Endpoint::get_status::{{closure}}
                 at ./control_plane/src/endpoint.rs:718:24
          control_plane::endpoint::Endpoint::start::{{closure}}
                 at ./control_plane/src/endpoint.rs:668:37

I wonder if something is changed in compute_ctl or control_plane so that they sometimes failed to connect?
I want to ask help of somebody more familiar with this components.
I even do not know which log should I check to investigate the reasons of the problem.

In report ep-2 is now panicking:
PG:2024-09-27 12:03:48.940 GMT [324262] PANIC:  [WP] collected propEpochStartLsn 0/1835178, but basebackup LSN 0/1835140
PG:2024-09-27 12:03:48.940 GMT [324250] LOG:  background worker "WAL proposer" (PID 324262) was terminated by signal 6: Aborted

could be related to https://github.com/neondatabase/neon/pull/9099

We merged @arssher fix, but it is still flaky. So perhaps few underlying issues.

This week:

[ ] Konstantin: check new failures

@knizhnik pls, double-check that recent failures (if any) related to SKs

Actually this test seems to be not lucky any more.
At least it is not mention here in our flaky test triage:
https://neonprod.grafana.net/d/a234c404-1e1a-42b1-bd3b-8e9449cf4563/regression-test-suite-flaky-tests?orgId=1&from=now-7d&to=now&viewPanel=3

Indeed, so closing again until we have any new issues


Bump my-account and console versions

console - 2.12.35
my-account - 2.3.37

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7978867440

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7978867440
Status: success


DynamicData - follow-ups from May Azure.Core arch board review (target June release)

From https://github.com/Azure/azure-sdk/issues/5985:

[ ] BinaryData support

[ ] Implement an allow-list of types that can be assigned and serialized; throw on any attempt to assign or serialize a type that is not on this allow list, or POCO that contains a property of a type not on the allow list
[ ] Treat byte[] as an array of byte and not a buffer of binary data to be encoded as a base64 string
[ ] When available, extend DynamicData to support automatic handling of BinaryData based on ContentType property

[ ] DynamicCaseMapping enum

[ ] Explore separating read and write in extension method, in the following shape (with names changed, of course):

ToDynamicFromJson(Write write = defaultStrict, Read read = defaultSupportPascal, DateTime...)

[ ] Ensure this works for the following scenarios:

[ ] RequestContent.Create()
[ ] ToDynamicFromJson()

[ ] Bindings: Get
[ ] Bindings: Set
[ ] Serialization
[ ] Deserialization

[ ] JsonExtensionData
[ ] CosmosSerializationOptions

[ ] Clear migration from CosmosPropertyNamingPolicy.CamelCase
[ ] LINQ query generation

[ ] DynamicDataTimeHandling enum

[ ] Change to take a format string instead of an enum
[ ] Separate out validation that DateTime and DateTimeOffset are UTC, and do this in all cases

Regarding:

Treat byte[] as an array of byte and not a buffer of binary data to be encoded as a base64 string

We decided to use the JsonSerializer default ByteArrayConverter, so these will be treated as base64 strings when assigned to DynamicData.


Use SWRevealViewController With customer navigation bar button

Hello, I try to use customer navigation bar button with SWRevealViewController, and my code is like below:
self.menuButton = [[VBFPopFlatButton alloc] initWithFrame:CGRectMake(0, 5, 15, 15) buttonType:buttonMenuType buttonStyle:buttonPlainStyle animateToInitialState:NO];
self.menuButton.lineThickness = 2;
self.menuButton.tintColor = [UIColor whiteColor];
self.slidebarButton.customView = self.menuButton;
self.navigationItem.leftBarButtonItem = self.slidebarButton;
SWRevealViewController *revealViewController = self.revealViewController;
if ( revealViewController )
{
[self.slidebarButton setTarget: self.revealViewController];
[self.slidebarButton setAction: @selector( revealToggle: )];
[self.view addGestureRecognizer:self.revealViewController.panGestureRecognizer];
}
Then the button can show in the navigation bar, but the question is that when i click it, it doesn't work. I try to add target on the button, no working. Is anyone can give me some help on it ? thanks a lot!

@xiangfly11  I had the same issue but here's my way of solving things, i have the code in swift so please manage accordingly.
        let button: UIButton = UIButton.buttonWithType(UIButtonType.Custom) as! UIButton
        button.addTarget(self.revealViewController(), action: "rightRevealToggle:", forControlEvents: UIControlEvents.TouchUpInside)
        button.setImage(UIImage(named: "Hamburger.png"), forState: UIControlState.Normal)
        button.frame = CGRectMake(0, 0, 24, 19) // image dimension for width n height

        var menuButton : UIBarButtonItem = UIBarButtonItem(customView: button)

        self.view.addGestureRecognizer(self.revealViewController().panGestureRecognizer())
        self.navigationItem.rightBarButtonItem = menuButton

That's all i did and it was working fine, however I used storyboards to initialize the SWReveal but should work if you do the same. I am not aware of VBFPopFlatButton a simple UIbutton should do the trick


Do we really need nixpkgs in inputs instead of the lightweight nix-community/nixpkgs.lib?

It now uses the official lib subtree. Nix will support this natively afaic, but I've worked around the current lack of support for this in #226 because we'll want to support current/older Nix.


snowy train set selection.

Hello, in order to reproduce the training process, I would like to ask you how you selected the 1872 training sets and 601 test sets from 100k snowy pictures. It would be great if you could give a sample list. Thank you again for sharing your excellent research results.
best wishes

Hej, we use images with names containing beautiful_smile. For convenience, we upload the desnowing training data to this google drive. And all validation datasets can be downloaded here.


docs(codemagic_app_preview): add comment to 'PostCommand' class

This pull request improves the PostCommand class in the Codemagic App Preview CLI.

⬇ Builds generated by Codemagic for commit 57ce9470967923ff961919b11e7dbe3de8300f8e ⬇
This is a custom message.

iOS

Android

macOS

  Download link

  Download link

  Download link

(expires Fri, 3 Nov 2023 18:23:52 GMT)Codemagic build: 651dace27e8433f8c5215ea1; comment generated with Codemagic App Preview


[BUG] Tiles are shifting when the robot moves from one tile to the next tile

What we did:
We selected a traffic circle as a prominent location and walked along the edge of a patch of grass with an rtk module.
We have recorded the GPS topic and we perform a Navsat to ENU conversion. We broadcast the ENU conversion from "map"->"gps_link" (gps_link is the frame_id we get from our ublox f9p driver)
What we expect:
That the trajectory matches the satellite image.

What we get
https://user-images.githubusercontent.com/32275/115557868-6b1eef80-a2b2-11eb-91f8-a99349e6dd81.mp4

I think this also addresses the following issue:
https://github.com/nobleo/rviz_satellite/issues/92

Code-wise this makes sense and might be just natural for GNSS signals that have poor accuracy. But I can't rule out that this is yet a bug.
So the "map"->"gps_link" is purely produced by your GNSS receiver? I.e. the the GNSS is your only localization? Are the timestamps well synchronized? Are they running at the same frequency? What's the accuracy of your receiver, i.e. what's the jitter like?

@beetleskin
you see the upper image? these are the RTK corrected GPS values plotted on a mapping service like ArcGIS satellite.  this is what i would expect in rviz. a little drift but it is quiet good in my opinion ;)
have you seen the whole clip from rviz? at the edges of each tile, the tiles are shifting. My TF is looking fine -> see the trajectory which gets recorded ;) the circle remains a circle and should be aligned to the traffic circle.

The shifting at the tiles is very interesting. There doesn't seem to be much magic going on in the conversions.
Would this problem reproduce with an artifical (made up) GPS signal from a generator? And if so, only when doing circles or also straight lines?

@Timple
Thanks for your answer.
After the weekend, I'm happy to give this a try. I just did a big lap around the block with the robot system including Robot_localization. Straight lines and curves were driven here. The shift was still present. I will prepare and upload the material on Monday.

That would still be measured data. It might be easier to debug (isolate) the problem with a dummy publisher of the gps signal.

@Timple
Here you go. I have done the following things:
Wrote a script that broadcasts a position as a TF. The position moves from the initial pose towards the east (x=0-1000m, y=0m).
I then converted the position to latitude and longitude like [here] (https://github.com/cra-ros-pkg/robot_localization/blob/melodic-devel/include/robot_localization/navsat_conversions.h).
When I plot the GPS coordinates with gpsvisualizer.com, it seems to me that the values not only go towards the east, but also quite slightly towards the north. In rviz it goes perfectly to the east because x-axis=east and i broadcast y=0.
I honestly have little theoretical knowledge of geodesy to interpret all this. I tought UTM is UTM.
Here are my rosbag files.
fake_gps_bagfiles.zip
(artifical)XY -> LAT/LON

i have corrected the Navsat-Fix Message by rotating the XY Points ~-2.5 deg before converting them to LatLon.
(artifical)XY -> (rotated) LAT/LON

I meet the same bug too.

I also have the same issue. @TobiMiller Could you explain how you rotated the XY Points 2.5deg in detail?


Stop break with task manager

I have enabled the option "don't let me skip" and disabled the option "allow to postpone".
When a break starts (fullscreen) I still have the option to open my task manager (ctrl+alt+del) and then end the stretchly processes.
So I can simply bypass the break this way, by cheeting using the task manager (windows 10).
Is this how Stretchly suposed to work? When I really want to be forced to take a break (and not being able to cheat)  a need other software?
Thank you for your help :)

Hi and thanks for feedback ;]
Task manager operates at OS level (it's basic part of os that can kill pretty much everything), so there's no way stretchly to override it somehow ;/


Caching Mechanism for choosing skip branch

Hi, I was going over the code for DeepCache and was quite confused with a particular part of the code where you choose the skip branch in the unet model.
from unet_2d_condition.py file, line 1102~1108, Why did you implment this if condition? it seems to limit access of other skip branch or layers.
Also if I'm understanding correctly,
Cache_layer_id : indicates which big block to choose from ex) CrossAttn2Dblock, DownBlock2D,...
Cache_block_id:  indicates which block (small blocks inside the big block) to choose from ex) transformer2dmodel, resnet
is this correct?

Hi, it's because of the mismatch of the down block and the up block.
The cache_block_id/cache_layer_id we use here is used in the downsampling block/layer. However,  the downsampling block and upsampling block that are connected by the skip branch didn't share the same layer_id/block_id. Thus, this part of code functions like a layer/block mapping, and the goal is to find the corresponding layer/block id for this skip branch in the upsampling process


Linker::instantiate_pre could avoid mutating a Store

In #5484, it would have been ideal to check if an instance was "instantiatable" by a Linker much sooner than when we currently check it (at startup instead of when a thread is spawned). Because a Store is not available until the thread is spawned and Linker::instantiate_pre requires a mutable Store, we cannot do this check sooner. If Linker::instantiate_pre were refactored to be called without a Store or if some other method were available to "check that all the imports can be satisfied," then the check in wasi-threads could be moved up and this issue closed.

I was just looking at a wasmtime embedder that constructs an otherwise-unused Store solely for use with instantiate_pre. I agree that it'd be nice to not have to do that!

This isn't a very helpful answer, but I wanted this as well when we introduced instantiate_pre, and there was some complexity of the implementation that made it extremely difficult, so I gave up.

I was struck with inspiration when thinking about this again and created https://github.com/bytecodealliance/wasmtime/pull/5683


docs: Update install for pypi package

PyPi package is being built since v0.15.1.
This PR updates the instructions to install from package instead of the GitHub repo.
Resolves #1208

Also, I believe this resolves https://github.com/instructlab/instructlab/issues/1208, right? It'd be nice to mention it. Thanks!

Also, I believe this resolves https://github.com/instructlab/instructlab/issues/1208, right? It'd be nice to mention it. Thanks!

Thanks for the heads up @leseb. Added context to the description.

@hickeyma Thanks for picking this up - might we want to leave any detail for users who may want to install from main or do local development and install directly from the local requirements file?

@hickeyma Thanks for picking this up - might we want to leave any detail for users who may want to install from main or do local development and install directly from the local requirements file?

@nathan-weinberg This is covered in the contributing guide. It was removed from the readme once the contributing guide was added.

I still would like to see this comment being addressed https://github.com/instructlab/instructlab/pull/1214#pullrequestreview-2082582412, then LGTM :), thanks in advance!

@leseb What needs to be addressed?

I still would like to see this comment being addressed #1214 (review), then LGTM :), thanks in advance!

@leseb What needs to be addressed?

Just amend your commit to match the body of the PR. You've put useful information that needs to be retained in git. That:
[PyPi package](https://pypi.org/project/instructlab/) is being built since v0.15.1.

This PR updates the instructions to install from package instead of the GitHub repo.

Resolves https://github.com/instructlab/instructlab/issues/1208

Thanks!

Just amend your commit to match the body of the PR. You've put useful information that needs to be retained in git.

Done

Just amend your commit to match the body of the PR. You've put useful information that needs to be retained in git.

Done

Thanks!


Introduce endless range (a part of #5085)

We introduced endless range feature, which is proposed in https://github.com/mruby/mruby/issues/5085 and already supported by CRuby.
Current Behavior
> Range.new(1,nil)
bad value for range (ArgumentError)

Behavior after this commit
# mruby
> Range.new(1,nil)
 => 1..
> (1...)
 => 1...
> (1..).each {|n| p n}
1
2
3
(snip)
> ('a'...).each {|c| p c; break if c>='f'}
"a"
"b"
"c"
"d"
"e"
"f"
 => nil
 > "Ruby"[1..]
 => "uby"
 > a = [0, 1, 2, 3, 4]; a[1..] = 5
 => 5
 > a
 => [0, 5]

# CRuby(2.6.6)
2.6.6 :001 > Range.new(1,nil)
 => 1..
2.6.6 :002 > (1...)
 => 1...
2.6.6 :001 > (1..).each {|n| p n}
1
2
3
(snip)
2.6.6 :011 > ('a'...).each {|c| p c; break if c>='f'}
"a"
"b"
"c"
"d"
"e"
"f"
 => nil
2.6.6 :001 > "Ruby"[1..]
 => "uby"
2.6.6 :002 > a = [0, 1, 2, 3, 4]; a[1..] = 5
2.6.6 :003 > a
 => [0, 5]

For other changes, please see the diff.
Things to notice

Range#size returns Float::INFINITY when it is endless. (This behavior is based on CRuby.) Under MRB_WITHOUT_FLOAT environment, we implemented to return nil for now.

# CRuby(2.6.6)
2.6.6 :015 > (1..).size
 => Infinity

# mruby
> (1..).size
=> Infinity
# mruby (built with MRB_WITHOUT_FLOAT flag)
> (1..).size
=> nil

Range#last

According to ISO, Range#last is an alias of Range#end (<IP_ADDRESS>.10), which is actually not the case in current Ruby anymore (e.g. Range#last can take 0 or 1 argument, but Range#end does not take arguments.). Since the core of mruby basically needs to follow ISO, those features in CRuby have been implemeted as extension(mruby-range-ext) in current mruby.
In CRuby, Range#last raises a RangeError when it is endless. (while Range#end returns nil). So we implemented this feature to extension(mruby-range-ext)'s Range#last following that implementation.

# CRuby(2.6.6)
2.6.6 :002 > (1..).last
Traceback (most recent call last):
        5: from /home/wataru/ruby/bin/irb:23:in `<main>'
        4: from /home/wataru/ruby/bin/irb:23:in `load'
        3: from /home/wataru/.rvm/gems/ruby-2.6.6/gems/irb-1.2.4/exe/irb:11:in `<top (required)>'
        2: from (irb):2
        1: from (irb):2:in `last'
RangeError (cannot get the last element of endless range)
# mruby (core)
> (1..).last
 => nil
# mruby (with mruby-range-ext)
> (1..).last
cannot get the last element of endless range (RangeError)

__upto_endless

To implement Range#each, we need to prepare upto method of String corresponding to endless range separately from the existing Stinrg#upto (CRuby also takes the same steps). According to the other implementation in mruby, we implement Stinrg#__upto_endless for private in use.

I will merge this PR after updating master by mruby3 branch.


fix fix that delete bitmap is not calculated correctly when has sequence column

Proposed changes
Issue Number: close #xxx

This problem was introduced by: #17542
row_id does not add 1 when there is a continue statement.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Allow GitHub Action to Support the Project Natively

Description
Since Native CI is callable externally, let' set GitHub Action to call all those default commands then.
Expected Behavior
GitHub Actions are implemented.
Current Behavior
GitHub Actions are not supported (for now).
Associated Data Files
No response

windows's environment CI completely executed and tested.

completed unix CI. Commit: daf0484a6020a3a98cc442b09621b9906e3afd36


feat: out more error info with cmd run failed

There are two reason for this pr:

std::process.Command recommended us to use canonicalize instead of current_dir doc
Convert to absolute path make us easier to locate problems.
Before:

After:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 8 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 9.031%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ops/cmd.rs
0
8
0.0%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.02%

Covered Lines:
220

Relevant Lines:
2436

💛  - Coveralls

Could you clean up the commits for how you would want them presented for review and merging?

Could you clean up the commits for how you would want them presented for review and merging?

Cleaned and all looks good for me. Please go to next step, thanks

Could you clean up the commits for how you would want them presented for review and merging?

Cleaned and all looks good for me. Please go to the next step thanks.

Thanks!


Use Slate Theme as App Theme -> https://bootswatch.com/slate/

with border-radius set to 0!
Related: #6

Closed because of #25


release(master): rust

:robot: I have created a release beep boop
ck3oop-core-rs: 0.1.0
0.1.0 (2024-06-18)
Features

rust-core: mod file parsing (03ce8e1)

ck3oop-ui-rs: 0.0.1
Dependencies

The following workspace dependencies were updated

dependencies

ck3oop-core-rs bumped from 0.0.0 to 0.1.0

This PR was generated with Release Please. See documentation.

:robot: Created releases:

ck3oop-core-rs-v0.1.0
ck3oop-ui-rs-v0.0.1
:sunflower:


Bug fix for invalid channel address

I did:

fix the bug about invalid address for GetChannelByAddr  in (a *Allocation) packetHandler(m *Manager) .
rename ChannelBind's ID to Number and Allocation's method GetChannelByID to GetChannelByNumber, the  number is more intuitive than id.
improve Allocation's test coverage.

Codecov Report

Merging #67 into master will increase coverage by 4.07%.
The diff coverage is 65%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   35.75%   39.82%   +4.07%
==========================================
  Files          14       14
  Lines         786      786
==========================================
+ Hits          281      313      +32
+ Misses        469      436      -33
- Partials       36       37       +1

Impacted Files
Coverage Δ

turn.go
2.71% <0%> (ø)
:arrow_up:

internal/allocation/channel_bind.go
66.66% <57.14%> (+41.66%)
:arrow_up:

internal/allocation/allocation.go
83.33% <81.81%> (+19.29%)
:arrow_up:

internal/allocation/permission.go
54.54% <0%> (+9.09%)
:arrow_up:

internal/ipnet/util.go
53.84% <0%> (+30.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0425436...dea4636. Read the comment docs.

@Sean-Der next time I will ping you  😄 , Thanks.


Disable unsafe container options

Add annotation to disable unsafe container operations:

adding writable vSMB or plan9 file shares to hypervisor isolated containers' UVM
using gMSAs for WCOW containers

(Annotation to disable vSMB direct maps already exists)
Added unit, functional, and cri-containerd tests for disabling writable shares and gMSAs.
Grouped together setting common [LW]COW options in one function to improve readability, and added tests for proper initialization and processing of common creation options

Did a quick run for the small things, will check again by EOD hopefully for a more in depth review

We should probably check that anywhere we call DefaultVSMBOptions will still work as intended. Specifically, if it's a mount we're trying to add as part of our setup work (aka not a mount that the user is trying to make) that we do the right thing.

It would be ideal to have:

A single annotation to disable all unsafe behavior for hostile multi-tenant environments. I don't have a preference on if we keep individual annotations for each type of resource as well, but a single way to say "make this safe" is important. If we do keep individual annotations as well then it should be an error to set one of the other annotations in a way that conflicts.
A shim config option that sets the default value for the "make this safe" annotation.

It would be ideal to have:

A single annotation to disable all unsafe behavior for hostile multi-tenant environments. I don't have a preference on if we keep individual annotations for each type of resource as well, but a single way to say "make this safe" is important. If we do keep individual annotations as well then it should be an error to set one of the other annotations in a way that conflicts.
A shim config option that sets the default value for the "make this safe" annotation.

Actually, we probably don't need #2, and can just use the default annotations feature instead.

I agree with @kevpar. We have a way to validate a container's spec before proceeding, but it would be worth it to invest some time to add conflict detection for all the annotations specifically for the UVM.

It would be ideal to have:

A single annotation to disable all unsafe behavior for hostile multi-tenant environments. I don't have a preference on if we keep individual annotations for each type of resource as well, but a single way to say "make this safe" is important. If we do keep individual annotations as well then it should be an error to set one of the other annotations in a way that conflicts.
A shim config option that sets the default value for the "make this safe" annotation.

That works for me: I should be able to add a translation early on in creation process to translate the uni-bus "disable all unsafe behavior" annotation into the sub-annotations for the individual features and check for conflicts

We should probably check that anywhere we call DefaultVSMBOptions will still work as intended. Specifically, if it's a mount we're trying to add as part of our setup work (aka not a mount that the user is trying to make) that we do the right thing.

Tracking this down, the only two places that DefaultVSMBOptions is called in hcsshim with readOnly not hardwired to true is for adding non-root mounts (hcsoci.setupMounts) and sharing in files to the UVM (uvm.Share) (which looks like is only used for shimdiag share requests).
All the setup works seems to mount as read only.

Can someone inform me why we need to disable gMSA versus just not passing in a gMSA cred? Don't those do the same thing? Isnt it up to the orchestrator to pass in the right opts?

Can someone inform me why we need to disable gMSA versus just not passing in a gMSA cred? Don't those do the same thing? Isnt it up to the orchestrator to pass in the right opts?

The motivation was for situations where the container options are passed in from customers, this adds an additional layer of security to explicitly deny gMSA in certain situations, regardless of the spec.


Step 7 - Buttons hidden within HTML

Describe the bug
Sign In/Out buttons have 'hidden' property in place on the 'web-start' project so are not viewable when working through Step 7.
To Reproduce
Steps to reproduce the behavior:

Follow steps to Step 7
Open 'web-start/public/index.html'
Scroll down to 'Line 65'

         <button hidden id="sign-out" class="mdl-button mdl-js-button mdl-js-ripple-effect mdl-color-text--white">           Sign-out         </button>         <button hidden id="sign-in" class="mdl-button mdl-js-button mdl-js-ripple-effect mdl-color-text--white">           account_circleSign-in with Google         </button>

Expected behavior
Should not have hidden attribute in place

@Joe thanks for the report!  @jhuleatt can you try to reproduce?

I can reproduce this.
I'd guess there is some js that is intended to remove the class from either the in or out buttons??? Depending on which is appropriate.  That does not seem to be running ...

Yup, if I fire off authStateObserver(user) at the bottom of the page then the buttons appear. But the state does not appear to be initialised correctly.

Thanks for the report @JoeEarly and sorry for the delay! I've fixed this in #477


Ubuntu packages update fails

>sudo apt update
...
Get:3 https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease [3,959 B]
Hit:4 http://us.archive.ubuntu.com/ubuntu bionic-updates InRelease
E: Repository 'https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease' changed its 'Origin' value from 'microsoft-ubuntu-bionic-prod bionic' to 'vscode stable'
E: Repository 'https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease' changed its 'Label' value from 'microsoft-ubuntu-bionic-prod bionic' to 'vscode stable'
E: Repository 'https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease' changed its 'Suite' value from 'bionic' to 'stable'
E: Repository 'https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease' changed its 'Codename' value from 'bionic' to 'stable'
N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for details.
Do you want to accept these changes and continue updating from this repository? [y/N] Y
Hit:5 http://us.archive.ubuntu.com/ubuntu bionic-backports InRelease
Get:6 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 Packages [156 kB]
Err:6 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 Packages
  File has unexpected size (84552 != 156065). Mirror sync in progress? [IP: <IP_ADDRESS> 443]
  Hashes of expected file:
   - Filesize:156065 [weak]
   - SHA512:12e6dffcd247d1ff067acfa61a3c4eb6078c326c2858feb4f6f141a1d809e22292a78282414a5c103038ea80bb63cd734c7516782c9809c341335083d4e7611b
   - SHA256:c850f35f1979831ac75641978c397e51519fa22313598ec12bde5f52277044c0
   - SHA1:1f65f4a7388c22bcf7b7f30fb7bc337c60d94b2e [weak]
   - MD5Sum:4153a12e4a5629bfb14ed98f4c8ac234 [weak]
  Release file created at: Thu, 12 Dec 2019 19:59:19 +0000
Reading package lists... Done
W: Conflicting distribution: https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease (expected bionic but got stable)
E: Failed to fetch https://packages.microsoft.com/ubuntu/18.04/prod/dists/bionic/main/binary-amd64/Packages.bz2  File has unexpected size (84552 != 156065). Mirror sync in progress? [IP: <IP_ADDRESS> 443]
   Hashes of expected file:
    - Filesize:156065 [weak]
    - SHA512:12e6dffcd247d1ff067acfa61a3c4eb6078c326c2858feb4f6f141a1d809e22292a78282414a5c103038ea80bb63cd734c7516782c9809c341335083d4e7611b
    - SHA256:c850f35f1979831ac75641978c397e51519fa22313598ec12bde5f52277044c0
    - SHA1:1f65f4a7388c22bcf7b7f30fb7bc337c60d94b2e [weak]
    - MD5Sum:4153a12e4a5629bfb14ed98f4c8ac234 [weak]
   Release file created at: Thu, 12 Dec 2019 19:59:19 +0000
E: Some index files failed to download. They have been ignored, or old ones used instead.

This seems like a transient issue related to Mirror sync in progress?. Can you confirm if you still see this behavior? Thanks.

@bureado - will do tomorrow. have to find which VMs.

@bureado - these are ubuntu VMs with .net deployed. apt update runs fine now.
just for clarity... should deb https://packages.microsoft.com/ubuntu/18.04/prod bionic main be present in /etc/apt/sources.list ? Seems there are warnings given against /etc/apt/sources.list.d/microsoft-prod.list which contains deb [arch=amd64] https://packages.microsoft.com/ubuntu/18.04/prod bionic main

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


fix: Update createImportJob implementation based dev endpoint testing

Use latest spacecat-shared-data-access release: https://github.com/adobe/spacecat-shared/pull/261 to get around this error:
Invalid KeyConditionExpression: Attribute name is a reserved keyword; reserved keyword: status

Also, update the logic in getAvailableImportQueue() to search for an available import queue correctly, which will prevent the situation we observed on dev where 2 jobs were able to claim the same queue:

With this change deployed to dev, the API service is rejecting new import jobs once the queues are all claimed:

:tada: This PR is included in version 1.42.3 :tada:
The release is available on:

v1.42.3
GitHub release

Your semantic-release bot :package::rocket:


Added Nav Bar

Added Nav Bar.
Navbar is visible at route /header.
Responsiveness have been added and hamburger icon is also working properly.
NewHeader is the react component of navbar present in components folder.
I have added css in style.css.
I have also Included bootstrap.
A screenshot has been attached below:

Your branch has conflicts in the package-lock.json file.
Run this once :
npm install<EMAIL_ADDRESS>--save
And commit & push your code 👍🏻

Your branch has conflicts in the package-lock.json file.
Run this once :
npm install<EMAIL_ADDRESS>--save
And commit & push your code 👍🏻

I have run the command and commited the changes.

Mobile View of Website:

I find your element to be quite decent and responsive.. Great job pal👍..!! Appreciate your efforts.!!


Allow calling detach on ignored tenant

Describe your changes
Added a query param to detach API
Allow to remove local state of a tenant even if its not in the memory (following ignore API)
Issue ticket number and link
#3828
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

I have pushed a small refactoring and a test that I've been asking for.


Add version labels to OpenJ9 overrides file

Already did that in the 10.1.x branch, necessary to keep x86_64 and s390x builds independent. In this case, we'll need to respin s390x because of a missing content_set, but no need to respin x86_64 too.

Thanks @osnipso


Fix: fix type checkout missing when assigning a dict to a schema

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

Fixed #135

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/ty.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[x] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 87.82%

Files with Coverage Reduction
New Missed Lines
%

compiler_base/parallel/src/executor/timeout.rs
1
92.98%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
2300

Relevant Lines:
2619

💛  - Coveralls


Made titlebar not show the usertokens

This doesn't work universally, and will crash on some platforms.
You can set title in bat script etc.


Improve feedback for abstract class instantiation error messages

SUGGESTION
Recently, I was trying to use a library written in ES2015 in an Ionic 2 project, and kept getting a Cannot instantiate abstract class 'Foo'. Foo is a concrete class that extends abstract class Bar, which extends abstract class Baz. The problem turned out to be a typo in Bar.d.ts (see below), which (I believe) made Typescript think that Foo did not implement some abstract methods of Bar and/or Baz (I'm still not sure which), but it took me a day and half to figure out what was going on. This error message should have more information about why Foo is abstract: Foo is declared as abstract or Foo does not implement abstract methods ...
TypeScript Version:  2.0.9
Code
Baz.d.ts
export as namespace Baz;

declare abstract class Baz {
  abstract baz(): string;
}

Bar.d.ts
export as namespace BarTypo;

declare abstract class Bar extends Baz {
  abstract foo(): void;
  abstract bar(): string;
  baz(): string;
}

export { Bar };

Foo.d.ts
import { Bar } from './bar.d';

export as namespace Foo;

declare class Foo extends Bar {
  constructor(opts?);

  foo(): void;
  bar(a: string): string;
}

export { Foo };

otherProject.ts
import { Foo } from 'library';

export class Service {
  foo: Foo;

  constructor()  {
    this.foo = new Foo({ opt: true });
  }
}

Expected behavior:
Error: Cannot instantiate abstract class 'Foo'. It does not implement abstract method(s): baz.
OR
Error: Cannot instantiate abstract class 'Foo'. It does not implement abstract method(s): foo, bar.
OR
Error: Cannot instantiate abstract class 'Foo'. It does not implement abstract method(s): baz (from Baz); foo, bar (from Bar).
Actual behavior:
Error: Cannot instantiate abstract class 'Foo'.

Localization makes some of the forms you provided difficult, but I think it's doable. We have not run into the non-obviously abstract ambient class issue.


layers/meta-raspberrypi: Update to latest kirkstone

This is needed to fix a bluetooth issue on BCM2711 based boards
Changelog-entry: Update meta-raspberrypi to latest kirkstone

@resin-jenkins test this please

@resin-jenkins test this please

@resin-jenkins test this please

@resin-jenkins test this please


Fix file extension for pypi artifacts

This got changed from zip to tar.gz as part of the pyproject.toml changes, but our release automation didn't get updated in this spot in response.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @AnandInguva

Example successful run - https://github.com/apache/beam/actions/runs/6931761835/job/18854244039 - and now the source distribution is correctly uploaded - https://pypi.org/project/apache-beam/2.52.0/#files

thanks for fixing everything related to this.

No problem, would've been pretty hard to predict this particular failure


Gradle to maven migration

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (ed37526) to head (f9a7e60).

Files with missing lines
Patch %
Lines

...step/processing/processor/BaseTestStepProcessor.kt
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (ed37526) and HEAD (f9a7e60). Click for more details.
HEAD has 1 upload less than BASE

Flag
BASE (ed37526)
HEAD (f9a7e60)

2
1

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #75       +/-   ##
============================================
- Coverage     66.57%   0.00%   -66.58%
============================================
  Files           269     166      -103
  Lines          8948    5976     -2972
  Branches       1200     856      -344
============================================
- Hits           5957       0     -5957
- Misses         2438    5976     +3538
+ Partials        553       0      -553

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Improve the remaining rough corners of the module system

Motivation
The module system (specifically name resolution) still has a few rough edges, footguns and corner cases that can be removed in a way that doesn't change its core semantics. Similarly, error messages and doc generation need to be smarter about the module system in some areas.
This issue proposes all changes that the author regards as improvements, and they would build on prior work like #116 and #385.
This is not a RFC due to its size, and lack of details. Rather, the idea is to paint the big picture, and have a central place to discuss wether this is a direction the module system should be taken or not.
Proposals

Change wildcard import semantics to be shadow-able by other items and non-wildcard imports.

The shadowing applies to any access to paths in the module, including other use items.
Don't error on non-disjoint wildcard imports, only error on access of a name
publicly visible through more more than one of them
if the names refer to different logical items.
Recommend to use an explicit import to choose between them in the error message.
This would mitigate the dangers of extending the set of exported items in a module, since
downstream users using wildcard imports can always clarify or guard in advance
with an explicit import.
This would enable the liberal use of wildcard imports for things like custom preludes, test modules, etc.
This would address issue https://github.com/rust-lang/rfcs/issues/553 and
https://github.com/rust-lang/rfcs/issues/1285
This should be completely backwards compatible to implement.
The unused import lint would trigger for any wildcard import through
which zero names are resolved.

Expose private imports as regular importable items to submodules

This makes imports non-special in regard to privacy and other imports.
This enables seamless moving around of items by replacing them with a import,
breaking no other code on the inside of a module.
This allows concise patterns:

A single use super::*; in a test submodule to import everything
needed to test the parent.
use self::submodule::*; to flatten a module hierarchy.
mod my_prelude { pub use other_prelude::*; pub use my_items::*; }
to easily merge modules together.

This is backwards compatible if implemented at the same time as the wildcard import change,
since any names becoming visible with this change would not conflict with existing imports:

Existing non-wildcard imports would shadow the additional names in existing wildcard imports.
Existing non-wildcard imports will not change meaning and
existing modules will not fail to compile since imports are currently strictly
forbidden from shadowing other items.

Make imports in non-module scopes see items defined in non-module scopes

This is about making this print "inner a" twice:
fn a() {
    println!("outer a");
}

fn main() {
    {
        fn a() {
            println!("inner a");
        }

        use self::a as b;

        a(); // Currently prints "inner a"
        b(); // Currently prints "outer a"
    }
}

This would address issues like https://github.com/rust-lang/rfcs/issues/959 and https://github.com/rust-lang/rust/issues/27626.

This would remove the corner case of imports not composing well
with items in a nested scope.

This is a breaking change.

However, the breakage scenario is obscure and unidiomatic
enough that a crater run
and community outreach might likely discover no regressions.

Address recursive mutual import issues.

This is basically a bugfix.
This has, however, caused enough trouble to affect decisions about
language semantics in the past.
I am not informed enough about resolve itself to know wether
this is algorithmically feasible to implement in rustc, but
as far as I abstractly know about the problem, it should be doable.
(Say with a fixpoint algorithm gathering the set of possible imports from wildcards, kept finite by normalizing the paths to the canonical path of a item)
Mutual recursive wildcard imports that actually reach items
should become a non-error with the new wildcard import semantics.
This should work, and doesn't today:

  mod a { pub use b::*; pub struct a_item; }
  mod b { pub use a::*; pub struct b_item; }
  use a::b_item;
  use b::a_item;

Mutual recursive (wildcard) imports should be detected and produce a
nice error message. This should fail to compile
(and already does today, though not with a nice message):

  mod a { pub use b::*; }
  mod b { pub use a::*; }
  use a::b_item;
  use b::a_item;

  mod a { pub use b::c; }
  mod b { pub use a::c; }

Error messages and rustdoc output should treat imports and paths of imported
items smarter.

This does not change language semantics.
This describes heuristics to improve error messages and docs.
Each item has a "canonical path" in its crate that uniquely describes its definition:

  mod a {
      pub struct b; // canonical path <crate>::a::b
  }
  use a::b; // non-canonical path <crate>::b for canonical path <crate>::a::b

Each resolvable name is potentially a chain of reexports "terminating"
in a non-import item:

  mod a {
      pub struct b;
  }
  use a::b as c;
  use c as d;
  // Visible names in <crate>:
  // a              terminating in a
  // a::b           terminating in a::b
  // c -> a::b      terminating in a::b
  // d -> c -> a::b terminating in a::b

extern crate statements count as a reexport here.

Each chain of imports in a resolvable name potentially terminates in a
item private from the location of the start of the chain.
In this case, the last visible reexport in the chain is defined
as "visibly-terminating":

  mod a {
      pub use self::c as b;
      struct c;
  }
  // Visible names in <crate>:
  // a            terminating in a,    visibly-terminating in a
  // a::b -> a::c terminating in a::c, visibly-terminating in a::b

Currently, if the compiler prints the path of an item in a error message
it is <name_of_the_crate>::<canonical_path_in_the_crate>. Example:

  use std::rc::Rc as RefCount;

  fn main() {
      let () = RefCount::new(5);
  }

  <anon>:4:9: 4:11 error: mismatched types:
  expected `alloc::rc::Rc<_>`,
     found `()`
  (expected struct `alloc::rc::Rc`,
             found ()) [E0308]

A more useful heuristic would be to print
<resolved-name-in-current-contex> defined at <visibly-terminating-path>.
For example:

  use std::rc::Rc as RefCount;

  fn main() {
      let () = RefCount::new(5);
  }

  <anon>:4:9: 4:11 error: mismatched types:
  expected `RefCount<_>` defined at std::rc::Rc,
     found `()`
  (expected struct `RefCount` defined at `std::rc::Rc`,
             found ()) [E0308]

If there is no visibly-terminating-item, print
extern crate <name_of_the_crate>::<visibly-terminating-path-in-that-crate>
similarly to before. Maybe also add a hash or version number to clear up
issues like in https://github.com/rust-lang/rust/issues/22750.

This indicates to the user that the mentioned item is not part of the
current crate in any way, and that he would have to add a extern crate
item or resolve a version mismatch to change that.

Rustdoc should, for each crate it generates documentation for:

Treat all use statements that are visibly-terminating in the
reexport chain of any other use item in that crate as its terminating item.

This uniformly resolves issues like presenting the libstd facade in the
docs.
If the terminating item is defined in another crate and rustdoc
currently generates documentation for that one as well (to make cross-crate links),
also append a "defined at "
note that links there.

This documents the relationship between dependencies

Treat all other use statements uniformly, for example by showing them simply
as a "reexport" linking to the visibly-terminating item.
Treat items or links to items that don't have a visibly-terminating import
referring to them in the current crate like today.

This handles the common situation of visible definitions or types
defined in another crate that is not also reexported,
like the return type of a pub fn foo() -> Rc<u32> in a crate
not reexporting std or alloc.

Precedence

In https://github.com/rust-lang/rfcs/issues/553 @paulp makes the important
comment to look at what Scala did in this whole space, and the semantics
described at http://www.scala-lang.org/files/archive/spec/2.11/02-identifiers-names-and-scopes.html,
where applicable, seem to mostly match the semantics of Rusts name resolution if the
tweaks described above get applied.
@nikomatsakis has an older unfinished RFC about the new wildcard import semantic.

As discussed in #1285, a revision of these features would greatly ease the pain of writing wrapper libraries that wish to glob-import the items being wrapped, but also publicly re-export a subset of them.
The ability to do:
use foo::*;
pub use foo::Bar;

would be very much appreciated.
:+1:

:+1:

Several of these suggestions are addressed by #1560

Indeed, a lot has been done in the last year :)

Just curious, what is the current status of these efforts?

"Expose private imports as regular importable items to submodules" is done, as is much of "Address recursive mutual import issues". Not sure about the others off the top of my head.


processor in session meta is not valid

When expanding nodemanagers，new nodemanager pid column session_processor table = -1，and it still exists after removal.

m


Logger Fixes for Windows

The way we were printing from LOG caused a crash when embedded on windows. This updates the logger to be more typesafe and generally compatible across platforms.
I also removed exit(1) from the check function. We should never automatically exit the program as a library, this can prevent proper logging if there is indeed a crash.
Also introduces a NO_LOG definition that we should add throughout.

Logs
Logs
 	ucrtbased.dll!00007ffea3b1ac87()	Unknown
 	ucrtbased.dll!00007ffea3b1b370()	Unknown
 	ucrtbased.dll!00007ffea3b1ab16()	Unknown
 	ucrtbased.dll!00007ffea3b1bf8d()	Unknown
 	ucrtbased.dll!00007ffea3a1f128()	Unknown
 	ucrtbased.dll!00007ffea3a1e242()	Unknown
 	ucrtbased.dll!00007ffea3afd4e2()	Unknown
 	ucrtbased.dll!00007ffea3af517f()	Unknown
 	ucrtbased.dll!00007ffea3ae1715()	Unknown
 	ucrtbased.dll!00007ffea3b09579()	Unknown
>	minigpu_ffi.dll!vsnprintf(char * const _Buffer, const unsigned __int64 _BufferCount, const char * const _Format, char * _ArgList) Line 1439	C++
 	minigpu_ffi.dll!snprintf(char * const _Buffer, const unsigned __int64 _BufferCount, const char * const _Format, ...) Line 1931	C++
 	minigpu_ffi.dll!gpu::LOG(gpu::Logger & logger, int level, const char * message, ...) Line 48	C++


Worker start many instances after reconnect to RabbitMQ

After reconnection to RabbitMQ a worker might start with many instances.

cannot replicate the behaviour at the moment. If possible, add better description / usecase

I did not discover this behaviour either.
closing for the moment