Add an implicit residual norm criterion.

This PR adds an implicit residual norm convergence criterion, which checks the reduction in the implicit residual calculated in a solver. Some libraries (example: MFEM) use an implicit residual as their main criterion. This criterion class will allow apples to apples comparison of our solvers to theirs.
The idea is that for solvers such as CG or extensions of CG (BiCG, BiCGSTAB, CGS, FCG...) we can use scalars which are representative of the residual norm of the solution. For example, in CG, the scalar rho is always computed in each iteration and closely follows the error in the solution.
This allows us to save computing the residual norm from the residual vector, which is what we do in most cases to check for convergence in the ResidualNormReduction stopping criterion.
Of course, for some solvers, there is no implicit residual norm available, and for those solvers, this stopping criterion will throw a NOT_SUPPORTED exception.
Edited
Updated modifications:

The ResidualNorm class now can perform all three types of criterion checks: absolute, relative and reduction.
The previous classes are marked with the [[deprecated("message")]] attribute. Some byproducts of this are:
i. Whenever this class is used a warning is thrown at compile time.
ii. As we need to still test the older class functionality, we will always throw the warning during compilation.
A deprecated note is added to the deprecated classes.
As we use ResidualNormReduction kernels everywhere, these are now replaced by ResidualNorm. The default behaviour of ResidualNorm should be the same as ResidualNormReduction, so the change in function name should not affect where ResidualNormReduction was previously called.
ResidualNorm and ImplicitResidualNorm use the same class structure and functions except that they call different check_impl kernels. In the future we might want to create a ResidualNormBase class and derive both from that. But I think currently that breaks interface, so I more or less duplicated the code.

Unrelated modifications:

fill with value functions were added for Array and Dense. I think these are really helpful to just fill the entire values arrays with a single value. This just uses the fill_array kernel that we previously had, so no new kernels are added.
In IDR, we were computing the residual norm in each iteration, but were not updating the stopping criterion with this information, which is now fixed.

I think having this is very useful! However, I am unsure whether "implicit" is the best name, or whether "recurrence residual" is better.

We always pass in the recurrent residual (the explicitly computed residual vector) to the stopping criterion. This is what we check in the relative residual norm reduction stopping criterion. Even though this is also a recurrent residual, I think "implicit residual" might be better suited because the residual norm is implicitly computed, so for example in case of preconditioned CG, the implicit residual norm would be r'*P*r, while the recurrent residual vector would be r and its norm r'*r

Here I would note the distinction between residual, residual norm and implicit residual norm:
residual is exact modulo rounding errors (every solver)
residual norm is exact modulo rounding errors (GMRES)
implicit residual norm is only correlated with the exact residual

Here I would note the distinction between residual, residual norm and implicit residual norm:
(recurrent) residual is exact modulo rounding errors (every solver)
(recurrent) residual norm is exact modulo rounding errors (GMRES)
implicit residual norm is only correlated with the exact residual norm (CG, ...)

I would note that, only in the case of left preconditioned GMRES, the recurrent residual norm (from the Hessenberg least-squares RHS) is the exact preconditioned residual norm. So when convergence is detected based on it, the true residual would typically still not be converged.

Regarding reporting the implicit residuals to the loggers is a good point and I did have a look at it, but I think that breaks our interface as we cannot add another parameter to the Updater class.
Regarding adding three separate criterion classes, I think that would be a lot of duplication and unnecessary code. But if everyone feels that they would prefer to have separate classes, I can do that.

format!

Some new modifications:

The ResidualNorm class now can perform all three types of criterion checks: absolute, relative and reduction.
The previous classes are marked with the [[deprecated("message")]] attribute. Some byproducts of this are:
i. Whenever this class is used a warning is thrown at compile time.
ii. As we need to still test the older class functionality, we will always throw the warning during compilation.
As we use ResidualNormReduction kernels everywhere, these are now replaced by ResidualNorm. The default behaviour of ResidualNorm should be the same as ResidualNormReduction, so the change in function name should not affect where ResidualNormReduction was previously called.
ResidualNorm and ImplicitResidualNorm use the same class structure and functions except that they call different check_impl kernels. In the future we might want to create a ResidualNormBase class and derive both from that. But I think currently that breaks interface, so I more or less duplicated the code.

Unrelated modifications:

fill with value functions were added for Array and Dense. I think these are really helpful to just fill the entire values arrays with a single value. This just uses the fill_array kernel that we previously had, so no new kernels are added.

About reporting to the logger the implicit residual, I think there should be ways to do this without breaking interface? Either by adding an extra overload with the information while keeping the old one, or adding a new parameter with a default value so that the old function calls still works. Since it's only  about adding something new and not removing or changing something, there should be a way to make it work?

@pratikvn I played around with it a bit, and I think I found a good solution: I created a new branch (I did not want to push into yours, and that way, you can decide what to keep) named recur-res-stop-crit_improve. Here are the changes (actually the commit itself) I did: https://github.com/ginkgo-project/ginkgo/commit/d749e01e2066c3002d323e5df94f38a3e08e6b4c
I tried to remove as much code duplication as possible while keeping the interface. Debatable is my solution for ImplicitResidualNorm: I inherit from ResidualNormBase and overwrite the check_impl to have the creation of the initial vectors depending on baseline from ResidualNormBase while having the proper check_impl.
It does not follow the Inheritance IS-A relationship (especially for ResidualNormBase -> ImplicitResidualNorm), but I think we avoid the most code duplication that way. It is possible to have an abstract class, which does not implement check_impl and therefore following IS-A inheritance principle, but that would force all deprecated *ResidualNorm classes to overwrite check_impl, creating more duplicated code.
Note: please also look at the comments I wrote, I am not 100% sure that they are all correct.

@thoasm thank you for the updates and the fixes. I think your solution is good. I think the fact that we dont have to duplicate check_impl for the deprecated criteria is good.
I also added the strided kernels, which I had missed. I think this should be ready for reviewing again.

@tcojean , regarding the logger. Maybe I misunderstand your comment. As I see it, I need to update the criterion_check_started to also take the implicit_residual_norm from the updater, which is passed to the logger in include/.../stop/criterion.hpp line 157. I think I cannot add another GKO_REGISTER_EVENT with criterion_check_started as that sets some variables with the same name so overloading is not possible. Adding something like criterion_check_started_new is possible, I guess without breaking interface, but that again will be in the public interface and will cause naming issues in the future. I would prefer to modify the criterion_check_started and break the interface for good in 2.0.

@pratikvn What I mean is that maybe it works if you add the implicit residual at the end and use an  = nullptr default case, both for the logger event and the criterion updater? Both the current and new interface would work. Of course, that's maybe not optimal in terms of positioning etc.

@upsj , Regarding the logger, I guess @tcojean was also talking about iteration_complete. I completely missed that. I was thinking of criterion_check_x. I will update that.
Regarding the factory parameters, I prefer the with_baseline than separate parameters for the different baselines.

Actually, having another look at the iteration_complete and that it is a public function which is overridden in other loggers, adding parameters, actually breaks interface, I think.

@pratikvn That's what the second on_iteration_complete overload is for. Though I actually got it the wrong way round, this current implementation might cause iteration events to get lost on old loggers. The correct solution would be
    GKO_LOGGER_REGISTER_EVENT(21, iteration_complete, ...)
protected:                                                           \
    virtual void on_iteration_complete(const LinOp *solver, const size_type &it,
            const LinOp *r, const LinOp *x, const LinOp *tau, const LinOp *implicit_tau_sq = nullptr) const {
        this->on_iteration_complete(solver, it, r, x, tau);
    }

and overriding the new on_iteration_complete where necessary

@upsj , I think the problem is that the call of this->on_iteration_complete(solver, it, r, x, tau) inside the new on_iteration_complete is ambiguous because the compiler cannot resolve between the two when you call it with just non-specific parameters. Also I think any call to on_iteration_complete will be ambiguous unless all the parameters are specified.

@pratikvn Oh yeah, when you drop the default value for the last parameter, the ambiguity goes away. You only need to make sure when overriding the new interface that you override both functions, one with your actual implementation, and the other one with
void on_iteration_complete(const LinOp *solver, const size_type &it,
            const LinOp *r, const LinOp *x = nullptr, const LinOp *tau = nullptr) const {
        this->on_iteration_complete(solver, it, r, x, tau, nullptr);
    }

Maybe I am still misunderstanding what you mean here.
Consider a logging call from the gmres apply. This essentially the log function, which calls the on_x based on the Event template parameter, therefore calling on_iteration_complete with the parameters passed into the log function.
The question is as for example in the call to log in gmres,  where you pass in 4 parameters in addition to the solver, the on in the logger does not know which on_iteration_complete to call, because both the on_iteration_complete have the same parameters and have only one extra in the second overload.
Unless we specify all the parameters for the iteration_complete in the log call, this will be ambiguous. And adding parameters to all log calls will break interface, because in MFEM and deal.ii, we do derive and use from the previous loggers.

The new overload with the additional parameter must not have any default parameters, then there is no ambiguity between them. If you specify all parameter, the new overload is used, otherwise the old one is called.

Okay, I think I finally get you mean. :)


OWL-ViT: evaluation on LVIS gets stuck while preparing dataset

Hi! Thanks for your awesome work on OWL-ViT!
However, I have met a problem on using the project. I followed the instruction in README.md to prepare the environment, and installed third-party library. And I used the example command, trying to evaluate. But the program got stuck on this line.
Here is the output.

2022-11-07 03:20:42.996048: W external/org_tensorflow/tensorflow/tsl/platform/default/dso_loader.cc:66] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or director
y; LD_LIBRARY_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64
2022-11-07 03:20:43.116724: W external/org_tensorflow/tensorflow/tsl/platform/default/dso_loader.cc:66] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or director
y; LD_LIBRARY_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64
2022-11-07 03:20:43.117854: W external/org_tensorflow/tensorflow/tsl/platform/default/dso_loader.cc:66] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or director
y; LD_LIBRARY_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64
2022-11-07 03:20:43.743084: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or directory; LD_LIBRAR
Y_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64
WARNING:absl:GlobalAsyncCheckpointManager is not imported correctly. Checkpointing of GlobalDeviceArrays will not be available.To use the feature, install tensorstore.
2022-11-07 03:20:47.933287: E external/org_tensorflow/tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:114] *** WARNING *** You are using ptxas 10.2.89, which is older than 11.1. ptxas before 11.1 is known to miscompile XLA code,
leading to incorrect results or invalid-address errors.
2022-11-07 03:20:47.993549: E external/org_tensorflow/tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:114] *** WARNING *** You are using ptxas 10.2.89, which is older than 11.1. ptxas before 11.1 is known to miscompile XLA code,
leading to incorrect results or invalid-address errors.
2022-11-07 03:20:48.057838: E external/org_tensorflow/tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:114] *** WARNING *** You are using ptxas 10.2.89, which is older than 11.1. ptxas before 11.1 is known to miscompile XLA code,
leading to incorrect results or invalid-address errors.
2022-11-07 03:20:48.116860: E external/org_tensorflow/tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:114] *** WARNING *** You are using ptxas 10.2.89, which is older than 11.1. ptxas before 11.1 is known to miscompile XLA code,
leading to incorrect results or invalid-address errors.
2022-11-07 03:20:49.961280: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcusolver.so.11'; dlerror: libcusolver.so.11: cannot open shared object file: No such file or directory; LD_LIBRAR
Y_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64
2022-11-07 03:20:49.961436: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcusparse.so.11'; dlerror: libcusparse.so.11: cannot open shared object file: No such file or directory; LD_LIBRAR
Y_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64
2022-11-07 03:20:49.961511: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1850] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the gu
ide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
I1107 03:20:49.963742<PHONE_NUMBER>60000 evaluator.py:660] JAX devices: 2
W1107 03:20:49.964679<PHONE_NUMBER>60000 compilation_cache.py:49] Initialized persistent compilation cache at /tmp/jax_compilation_cache
0%|                                              | 0.00/1.29M [00:00<?, ?iB/s]I1107 03:20:50.743195<PHONE_NUMBER>60000 tokenizer.py:36] Downloaded vocabulary from https://github.com/openai/CLIP/blob/main/clip/bpe_simple_vocab_16e6.txt.gz?raw
=true to /root/.cache/scenic/clip
100%|█████████████████████████████████████| 1.29M/1.29M [00:00<00:00, 12.8MiB/s]
2022-11-07 03:20:50.887795: W tensorflow/core/platform/cloud/google_auth_provider.cc:184] All attempts to get a Google authentication bearer token failed, returning an empty token. Retrieving token from files failed with "NOT_FOUND: Could n
ot locate the credentials file.". Retrieving token from GCE failed with "FAILED_PRECONDITION: Error executing an HTTP request: libcurl code 6 meaning 'Couldn't resolve host name', error details: Could not resolve host: metadata".
I1107 03:20:51.263590<PHONE_NUMBER>60000 checkpoints.py:719] Restoring checkpoint from gs://scenic-bucket/owl_vit/checkpoints/clip_vit_b32_b0203fc
I1107 03:20:55.555792<PHONE_NUMBER>60000 dataset_info.py:634] Load pre-computed DatasetInfo (eg: splits, num examples,...) from GCS: lvis/1.2.0
I1107 03:20:56.140138<PHONE_NUMBER>60000 dataset_info.py:540] Load dataset info from /tmp/tmpapikfn5ltfds
I1107 03:20:56.148214<PHONE_NUMBER>60000 dataset_info.py:610] Field info.release_notes from disk and from code do not match. Keeping the one from code.
I1107 03:20:56.148426<PHONE_NUMBER>60000 dataset_info.py:610] Field info.splits from disk and from code do not match. Keeping the one from code.
I1107 03:20:56.148806<PHONE_NUMBER>60000 dataset_builder.py:475] Generating dataset lvis (/openseg_blob/dataset/lvis/lvis/1.2.0)
Downloading and preparing dataset 25.35 GiB (download: 25.35 GiB, generated: 22.29 GiB, total: 47.64 GiB) to /openseg_blob/dataset/lvis/lvis/1.2.0...
Dl Completed...: 0 url [00:00, ? url/s]          I1107 05:20:08.568320<PHONE_NUMBER>47008 download_manager.py:347] Skipping download of https://s3-us-west-2.amazonaws.com/dl.fbaipublicfiles.com/LVIS/lvis_v1_image_info_test_dev.json.zip: File c
ached in /openseg_blob/dataset/lvis/downloads/s3-us-west-2_dl.fbai.com_LVIS_lvis_v1_imagJqn_72umBx8rzrvxAK5qyTBIIaIalLsDPKDknGyjL44.zip
Dl Completed...: 100%|███████████████████████████I1107 05:20:08.571549<PHONE_NUMBER>47008 download_manager.py:489] Reusing extraction of /openseg_blob/dataset/lvis/downloads/s3-us-west-2_dl.fbai.com_LVIS_lvis_v1_imagJqn_72umBx8rzrvxAK5qyTBIIaI
alLsDPKDknGyjL44.zip at /openseg_blob/dataset/lvis/downloads/extracted/ZIP.s3-us-west-2_dl.fbai.com_LVIS_lvis_v1_imagJqn_72umBx8rzrvxAK5qyTBIIaIalLsDPKDknGyjL44.zip.
I1107 05:20:08.587899<PHONE_NUMBER>47008 download_manager.py:347] Skipping download of http://images.cocodataset.org/zips/test2017.zip: File cached in /openseg_blob/dataset/lvis/downloads/images.cocodataset.org_zips_test2017x5CMPJ-Uui8zQOu-7Fj
CXba-h3TxjWjC8V0ONp2Vuro.zip
Dl Completed...: 100%|███████████████████████████I1107 05:20:08.598515<PHONE_NUMBER>47008 download_manager.py:489] Reusing extraction of /openseg_blob/dataset/lvis/downloads/images.cocodataset.org_zips_test2017x5CMPJ-Uui8zQOu-7FjCXba-h3TxjWjC8
V0ONp2Vuro.zip at /openseg_blob/dataset/lvis/downloads/extracted/ZIP.images.cocodataset.org_zips_test2017x5CMPJ-Uui8zQOu-7FjCXba-h3TxjWjC8V0ONp2Vuro.zip.
I1107 05:20:08.614054<PHONE_NUMBER>47008 download_manager.py:347] Skipping download of https://s3-us-west-2.amazonaws.com/dl.fbaipublicfiles.com/LVIS/lvis_v1_train.json.zip: File cached in /openseg_blob/dataset/lvis/downloads/s3-us-west-2_dl.f
bai.com_LVIS_lvis_v1_trai6EW-gXNtpOfBnEkNVjOSyLLHX_KqFGfgGU-e1pFZOOU.zip
Dl Completed...: 100%|███████████████████████████I1107 05:20:08.616075<PHONE_NUMBER>47008 download_manager.py:489] Reusing extraction of /openseg_blob/dataset/lvis/downloads/s3-us-west-2_dl.fbai.com_LVIS_lvis_v1_trai6EW-gXNtpOfBnEkNVjOSyLLHX_K
qFGfgGU-e1pFZOOU.zip at /openseg_blob/dataset/lvis/downloads/extracted/ZIP.s3-us-west-2_dl.fbai.com_LVIS_lvis_v1_trai6EW-gXNtpOfBnEkNVjOSyLLHX_KqFGfgGU-e1pFZOOU.zip.
I1107 05:20:08.624226<PHONE_NUMBER>47008 download_manager.py:347] Skipping download of http://images.cocodataset.org/zips/train2017.zip: File cached in /openseg_blob/dataset/lvis/downloads/images.cocodataset.org_zips_train2017aai7WOpfj5nSSHXyF
BbeLp3tMXjpA_H3YD4oO54G2Sk.zip
Dl Completed...: 100%|███████████████████████████I1107 05:20:08.632148<PHONE_NUMBER>47008 download_manager.py:489] Reusing extraction of /openseg_blob/dataset/lvis/downloads/images.cocodataset.org_zips_train2017aai7WOpfj5nSSHXyFBbeLp3tMXjpA_H3
YD4oO54G2Sk.zip at /openseg_blob/dataset/lvis/downloads/extracted/ZIP.images.cocodataset.org_zips_train2017aai7WOpfj5nSSHXyFBbeLp3tMXjpA_H3YD4oO54G2Sk.zip.
I1107 05:20:08.647421<PHONE_NUMBER>47008 download_manager.py:347] Skipping download of https://s3-us-west-2.amazonaws.com/dl.fbaipublicfiles.com/LVIS/lvis_v1_val.json.zip: File cached in /openseg_blob/dataset/lvis/downloads/s3-us-west-2_dl.fba
i.com_LVIS_lvis_v1_val._sJS-sAaW2DLxybeR8oL4SW7_t5HUGAg0plfGy34d5E.zip
Dl Completed...: 100%|███████████████████████████I1107 05:20:08.651283<PHONE_NUMBER>47008 download_manager.py:489] Reusing extraction of /openseg_blob/dataset/lvis/downloads/s3-us-west-2_dl.fbai.com_LVIS_lvis_v1_val._sJS-sAaW2DLxybeR8oL4SW7_t5
HUGAg0plfGy34d5E.zip at /openseg_blob/dataset/lvis/downloads/extracted/ZIP.s3-us-west-2_dl.fbai.com_LVIS_lvis_v1_val._sJS-sAaW2DLxybeR8oL4SW7_t5HUGAg0plfGy34d5E.zip.
I1107 05:20:08.659612<PHONE_NUMBER>47008 download_manager.py:347] Skipping download of http://images.cocodataset.org/zips/val2017.zip: File cached in /openseg_blob/dataset/lvis/downloads/images.cocodataset.org_zips_val2017T34syyhm7FBBmTyc8qlSu
-1pZHsRXQ902nzo9L74LwU.zip
Dl Completed...: 100%|███████████████████████████I1107 05:20:08.667268<PHONE_NUMBER>47008 download_manager.py:489] Reusing extraction of /openseg_blob/dataset/lvis/downloads/images.cocodataset.org_zips_val2017T34syyhm7FBBmTyc8qlSu-1pZHsRXQ902n
zo9L74LwU.zip at /openseg_blob/dataset/lvis/downloads/extracted/ZIP.images.cocodataset.org_zips_val2017T34syyhm7FBBmTyc8qlSu-1pZHsRXQ902nzo9L74LwU.zip.
Extraction completed...: 0 file [00:00, ? file/s]
Dl Size...: 100%|██████████████████████████████████████|<PHONE_NUMBER>0/27214093950 [00:00<00:00,<PHONE_NUMBER>84.82 MiB/s]
Dl Completed...: 100%|███████████████████████████████████████████████████████████████| 6/6 [00:00<00:00, 50.36 url/s]
I1107 05:20:45.144630<PHONE_NUMBER>47008 native_type_compatibility.py:250] Using Any for unsupported type: typing.Sequence[~T]
I1107 05:20:45.253493<PHONE_NUMBER>47008 bigquery.py:422] No module named google.cloud.bigquery_storage_v1. As a result, the ReadFromBigQuery transform CANNOT be used with method=DIRECT_READ.
Generating splits...:   0%|                                                               | 0/3 [00:00<?, ? splits/s]W1107 05:29:28.448266<PHONE_NUMBER>47008 split_builder.py:227] **************************** WARNING **************************

Warning: The dataset you're trying to generate is using Apache Beam,
yet no beam_runner nor beam_options was explicitly provided.
Some Beam datasets take weeks to generate, so are usually not suited
for single machine generation. Please have a look at the instructions
to setup distributed generation:
https://www.tensorflow.org/datasets/beam_datasets#generating_a_beam_dataset

I1107 05:29:28.450022<PHONE_NUMBER>47008 pipeline.py:188] Missing pipeline option (runner). Executing pipeline using the default runner: DirectRunner.
W1107 05:29:48.097574<PHONE_NUMBER>47008 pipeline_options.py:339] Discarding unparseable args: ['--alsologtostderr=true', '--platform=gpu', '--config=scenic/projects/owl_vit/configs/clip_b32.py', '--checkpoint_path=gs://scenic-bucket/owl_vit/c
heckpoints/clip_vit_b32_b0203fc', '--annotations_path=/openseg_blob/dataset/lvis/lvis_v1_val.json', '--tfds_data_dir=/openseg_blob/dataset/lvis', '--output_dir=outputs']
I1107 05:29:48.098392<PHONE_NUMBER>47008 environments.py:376] Default Python SDK image for environment is apache/beam_python3.7_sdk:2.42.0
I1107 05:36:36.703704<PHONE_NUMBER>47008 translations.py:714] ==================== <function annotate_downstream_side_inputs at 0x7fcb9ecc55f0> ====================
I1107 05:36:37.070872<PHONE_NUMBER>47008 translations.py:714] ==================== <function fix_side_input_pcoll_coders at 0x7fcb9ecc5710> ====================
I1107 05:36:37.433204<PHONE_NUMBER>47008 translations.py:714] ==================== <function pack_combiners at 0x7fcb9ecc5c20> ====================
I1107 05:36:37.437028<PHONE_NUMBER>47008 translations.py:714] ==================== <function lift_combiners at 0x7fcb9ecc5cb0> ====================
I1107 05:36:37.440332<PHONE_NUMBER>47008 translations.py:714] ==================== <function expand_sdf at 0x7fcb9ecc5e60> ====================
I1107 05:36:37.805572<PHONE_NUMBER>47008 translations.py:714] ==================== <function expand_gbk at 0x7fcb9ecc5ef0> ====================
I1107 05:36:37.809968<PHONE_NUMBER>47008 translations.py:714] ==================== <function sink_flattens at 0x7fcb9ecc6050> ====================
I1107 05:36:37.811944<PHONE_NUMBER>47008 translations.py:714] ==================== <function greedily_fuse at 0x7fcb9ecc60e0> ====================
I1107 05:36:38.192294<PHONE_NUMBER>47008 translations.py:714] ==================== <function read_to_impulse at 0x7fcb9ecc6170> ====================
I1107 05:36:38.192996<PHONE_NUMBER>47008 translations.py:714] ==================== <function impulse_to_input at 0x7fcb9ecc6200> ====================
I1107 05:36:38.193770<PHONE_NUMBER>47008 translations.py:714] ==================== <function sort_stages at 0x7fcb9ecc6440> ====================
I1107 05:36:38.196089<PHONE_NUMBER>47008 translations.py:714] ==================== <function add_impulse_to_dangling_transforms at 0x7fcb9ecc6560> ====================
I1107 05:36:38.196668<PHONE_NUMBER>47008 translations.py:714] ==================== <function setup_timer_mapping at 0x7fcb9ecc63b0> ====================
I1107 05:36:38.563957<PHONE_NUMBER>47008 translations.py:714] ==================== <function populate_data_channel_coders at 0x7fcb9ecc64d0> ====================
I1107 05:36:44.928154<PHONE_NUMBER>47008 statecache.py:172] Creating state cache with size 100
I1107 05:36:44.930204<PHONE_NUMBER>47008 worker_handlers.py:908] Created Worker handler <apache_beam.runners.portability.fn_api_runner.worker_handlers.EmbeddedWorkerHandler object at 0x7fcb93f23d50> for environment ref_Environment_default_envi
ronment_1 (beam:env:embedded_python:v1, b'')

I am a beginner of using tensorflow. I have wondered if there is any solution to solve it.
By the way, I actually have LVIS dataset on my disk, but I do not know how to organize it and use it in this program. Could you show the organization of the LVIS dataset?
Looking forward to your comments.

This looks like a TFDS issue rather than an OWL-ViT issue. If you already have the TFDS version of LVIS on disk, you can point the code to the local data dir like this (note the "tfds_data_dir": "//your/data/dir" parts):
python -m scenic.projects.owl_vit.main \
  --alsologtostderr=true \
  --workdir=/tmp/training \
  --config=scenic/projects/owl_vit/configs/clip_b32.py \
  --config.dataset_configs.train.decoder_kwarg_list='({"tfds_data_dir": "//your/data/dir"},)' \
  --config.dataset_configs.eval.decoder_kwarg_list='({"tfds_data_dir": "//your/data/dir"},)'

Since TFDS has this problem, we are not able to work on the OWL-VIT, Could you help me to solve this problem? Is there any version of the code without TFDS?

In principle, you can modify the evaluation code to read the data from other sources. The get_dataset function in the evaluation code (here) is the only place where TFDS is used. You can change this to whatever works for you.
For debugging the LVIS TFDS creation, I suggest reaching out to the TFDS team by creating an Issue at https://github.com/tensorflow/datasets.

@kxqt  Did you manage to solve the above issue? I am also facing the exact same issue.

How long does it take to build the dataset, and how much RAM is required? Does anyone have the pre-built TFDS version of the data?

@rohit901 If I remember around 50gb.
Here's how to prepare the dataset using tfds:
$ python
import tensorflow_datasets as tfds
builder = tfds.builder('lvis', data_dir='/scratch/tensorflow_datasets')
builder.download_and_prepare(download_dir='/scratch/tensorflow_datasets')

Then pass tfds data dir to train script as per docs:
python -m scenic.projects.owl_vit.main \
  --alsologtostderr=true \
  --workdir=/tmp/training \
  --config=scenic/projects/owl_vit/configs/clip_b32.py \
  --config.dataset_configs.train.decoder_kwarg_list='({"tfds_data_dir": "//scratch/tensorflow_datasets"},)' \
  --config.dataset_configs.eval.decoder_kwarg_list='({"tfds_data_dir": "//scratch/tensorflow_datasets"},)'


WIP: Fix spot fleets after the multi-part userdata improvement

This is currently a POC of the possible fix for #727 with ignition, probably simplified/replaced/enhanced with a more simpler solution without ignition.

Verified that this does fix #727 😉

Codecov Report

Merging #732 into master will decrease coverage by 0.48%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   34.33%   33.84%   -0.49%
==========================================
  Files          55       55
  Lines        3073     3117      +44
==========================================
  Hits         1055     1055
- Misses       1859     1903      +44
  Partials      159      159

Impacted Files
Coverage Δ

model/userdata.go
34.95% <0%> (-26.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b542fb1...cbff30c. Read the comment docs.

Implemented, enabled, and verified the simpler fix without ignition.
@redbaron Could you review this? This solution with Base64UserDataRef seemed to be a minimum possible fix for #727 for now. My originally proposed solution with ignition is disabled by default and can be enabled only by modifying code and rebuilding kube-aws.
Also, please let me sync with you that I'd like to address #727 before releasing v0.9.7 final 🙇

Closing this in favor of #735


refactor operation nodes so they don't interfere with layout

So, in order to try out more layout frameworks, I had to refactor how we handle our operation nodes. Previously they were first class react flow nodes, yet we rendered them as children of the group nodes. This was causing issues with the frameworks. So I've pulled them out simply rendered them as content on the group nodes.
I also went ahead and made a bunch of layout improvements that will hopefully tide us over until we get a framework working.
Here's how those improvements handle some of the slightly more complicated maps that were previously broken:

This is awesome!!!!


Add flag to reverse errors

closes #3860

hey @kayagokalp I made the changes you requested, I tried running forc build after adding some errors to examples/counter and I got this error.
error
  --> /Users/mitchmackert/Code/sway/sway-lib-core/src/ops.sw:11:9
   |
 9 |
10 |     fn add(self, other: Self) -> Self {
11 |         __add(self, other)
   |         ^^^^^ Identifiers cannot begin with a double underscore, as that naming convention is reserved for compiler intrinsics.
12 |     }
13 | }
   |
____

would you mind giving me steps to test this correctly? I think I am looking at this the wrong way

hey @gr00vytvniks thanks for the PR, the error looks odd. Can you make rebase/merge master you shouldn't have any lock file is the counter folder as we recently changed that folder to be a workspace, see. This type of core compilation errors can be seen with master forc depending on a released version of std/core. Can you make sure that in examples/counter/Forc.toml you actually depend on local std. You should have something like this in the Forc.toml:
[dependencies]
std = { path = "../../sway-lib-std" }TOML

You should be able to test this with a template project by adding a couple of compile errors. Let me know if you are unsure/stuck 👍

hey @gr00vytvniks thanks for the PR, the error looks odd. Can you make a rebase/merge master as you shouldn't have any lock file is the counter folder as we recently changed that folder to be a workspace, see. This type of core compilation errors can be seen with master forc depending on a released version of std/core. Can you make sure that in examples/counter/Forc.toml you actually depend on local std. You should have something like this in the Forc.toml:
[dependencies]
std = { path = "../../sway-lib-std" }

You should be able to test this with a template project by adding a couple of compile errors. Let me know if you are unsure/stuck 👍

Hey @kayagokalp, The error came from a collision between an old fuelup binary and a cargo binary.

Hey @kayagokalp,  I added a debug build profile like the book instructed but it is giving me this warning.
 ~/Code/sway/examples/counter/ [gr00vytvniks/reverse-errors*] forc build
  WARNING! unused manifest key: build-profiles
  WARNING! unused manifest key: build-profiles
  WARNING! unused manifest key: build-profiles
  WARNING! unused manifest key: build-profiles
  WARNING! unused manifest key: build-profiles
  WARNING! unused manifest key: build-profiles
  Compiled library "core".
  Compiled library "std".
[forc-util/src/lib.rs:243] reverse_errors = false
warning
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:19:9
   |
17 |
18 |         storage.counter = value;
19 |         value
   |         ----- This cast, from integer type of width sixty four to integer type of width thirty two, will lose precision.
20 |     }
   |
____

warning
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:26:9
   |
24 |
25 |         storage.counter = incremented;
26 |         incremented
   |         ----------- This cast, from integer type of width sixty four to integer type of width eight, will lose precision.
27 |     }
28 | }
   |
____

warning
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:12:5
   |
10 |
11 | storage {
12 |     counter: u64 = 0,
   |     ------- This storage declaration is never accessed and can be removed.
13 | }
   |
____

error
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:17:42
   |
15 |
16 |     #[storage(write)]
17 |     fn initialize_counter(value: u64) -> u32 {
   |                                          ^^^ expected: u64
found:    u32
help:     The definition of this function must match the one in the ABI "TestContract" declaration.
18 |         storage.counter = value;
19 |         value
   |
____

error
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:23:42
   |
21 |
22 |     #[storage(read, write)]
23 |     fn increment_counter(amount: u64) -> u8 {
   |                                          ^^ expected: u64
found:    u8
help:     The definition of this function must match the one in the ABI "TestContract" declaration.
24 |         let incremented = storage.counter + amount;
25 |         storage.counter = incremented;
   |
____

  Aborting due to 2 errors.
Error: Failed to compile counter

I went ahead and just changed the default in debug() to true and this was the output :)
error
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:23:42
   |
21 |
22 |     #[storage(read, write)]
23 |     fn increment_counter(amount: u64) -> u8 {
   |                                          ^^ expected: u64
found:    u8
help:     The definition of this function must match the one in the ABI "TestContract" declaration.
24 |         let incremented = storage.counter + amount;
25 |         storage.counter = incremented;
   |
____

error
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:17:42
   |
15 |
16 |     #[storage(write)]
17 |     fn initialize_counter(value: u64) -> u32 {
   |                                          ^^^ expected: u64
found:    u32
help:     The definition of this function must match the one in the ABI "TestContract" declaration.
18 |         storage.counter = value;
19 |         value
   |
____

  Aborting due to 2 errors.
Error: Failed to compile counter

Looks like there's a problem with the formatting of the examples/counter/Forc.toml file. Also some of the should_fail e2e tests are failing incorrectly (not sure if it's related, may just need to re-run the job).

Happy to approve this once merge conflicts are resolved and @kayagokalp gives his approval

As a follow up PR, you could update the documentation so that developers will know how to use this feature. ie as part of a BuildProfile or just via --reverse-order(Not sure what name you guys landed on).

Thanks for this. just some last merge conflicts @gr00vytvniks


Daisy-chain RPC proxy - chain upgradeability idea

Idea by @karlfloersch, storing it here for future upgrade discussion.
Problem: When squash-forking, we get rid  of old DB contents, old API types, etc. in geth. During the transition we may have both, but long-term no more than the latest version should be supported for minimal protocol complexity. Yet, some users like to access older data with the same RPC as the newer data.
Solution: Keep a node running (disconnected, frozen at last block before fork) and serve data with it. Wrap it with a RPC proxy, and "daisy-chain" the request: try latest node first, then try the previous, and then the one before, etc. This proxy can be super minimal/simple, since it only reads error codes and does not "speak" the protocol (i.e. no individual methods to re-route, just handle "not found" etc. errors). Now the RPC proxy can be called for results of any time in the protocol. And users that only need the latest data can access it through a regular non-proxy setup.

Mark has a spec out for this, and is starting implementation. Closing since this is complete.

Is this going to land on the specs repo at some point? I think we should try to centralize the spec information in one location.


Consider a multi tab UI for Queues, Topics, and Subscriptions (and others, probably)

With a SB instance that has "lots" (ie, dozens or hundreds) of Topics, Subscriptions, and Queues, the limitation of only being able to "inspect" one at a time is a usability problem. I often need to work with several different topics, subscriptions, and/or queues in rapid succession, switching back-and-forth between them, etc. It's difficult to do with a large number in the tree view.
If I could open a Topic or Queue "in a new tab" like browsers and many other dev tools do, I could easily keep a "working set" of ones that I'm interested in. What I'm envisioning is that the "details" side (right side) would be tabbed, and there would be a context menu option on the nodes in the tree view such as "Open in new tab." But I'm open to any kind of tabbed UI that would support inspecting multiple nodes at once.

Hi @erizzo what you describe is a limit of the filter syntax supported by the NamespaceManager.GetQueues method. Yes, I could also implement the feature by making a client-side filter, but in this case, the tool should retrieve all the queues, topics, subscriptions and then apply this filter on the client-side.
 You can organize your entities in hierarchical order as follows:

create a category or subset called for example calculator (see the picture below)
create multiple queues called calculator/A, calculator/B, calculator/B etc.
in the connect from select only the type of the entities you want to retrieve, for example, queues
finally, specify a filter like Startswith(Path, 'calculator') Eq true

As shown in the following picture, the tool will only retrieve the queues which path starts with calculator and they will appear all under a folder called calculator. Remember that fully qualified name of a queue is sb://.servicebus.windows.net/ but the queue name can be a relative path like sb://paolosalvatori.servicebus.windows.net/calculator/requestqueue.
Hope this helps! @SeanFeldman @ErikMogensen

I think there is some confusion. I'm not asking for a filter, I'm asking for multi-tabbed UI. Filtering is also a useful feature, but orthogonal to having multiple tabs open. My request can not be satisfied by using a filter, I need to be looking at several different topics/subscriptions/queues at the same time.
Like I said, compare it to a web browser or database browsing tool - I'm not forced to look at only 1 web site or database table at a time.

Understood @erizzo. In this case, we have two options:

the easiest way is to open each queue, topic, subscription in a separate MDI form.
we can create tabs, but in this case we need to understand what is the event that triggers opening a new tab: right click and open in new tab like in a browser? This implementation requires more effort than the previous one, because years ago I had to handle the UI of tabs manually.


Adding service fabric api version 2020-12-01-preview - rebased with master

I took the pr here #10230 and rebased with master to fix the conflicts. Also, update the paths and example to reflect the changes we made on the RP.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
I took @alexgshaw pr here #10230 and rebased with master to fix the conflicts. Also, update the paths and example to reflect the changes we made on the RP
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

/azp run automation - sdk

I to @alexgshaw  pr here  #10230 and rebased with master to fix the conflicts. Also, update the paths and example to reflect the changes we made on the RP @jkochhar please take a look at the last commit.

@chiragg4u could you review this pr. I took the changes from #10230 rebased and update the paths and example to reflect the changes we made on the RP

This has been sighed off by ARM. @fengzhou-msft could you help merge the pr? or could you point to somebody to help?

This has been sighed off by ARM. @fengzhou-msft could you help merge the pr? or could you point to somebody to help?

Hi @yungezz, this has been signed off by arm, could you merge the pr please?

Hi @yungezz, this has been signed off by arm, could you merge the pr please?

hi @a-santamaria could you pls fix CI task failure by following guideline in description of the PR? thanks.

hi @a-santamaria could you pls fix CI task failure by following guideline in description of the PR? thanks.

@yungezz fixed. thanks

@yungezz fixed. thanks

@yungezz the issues are fixed, could you merge the pr please?

hi @msyyc, could you pls help confirm impact to Python SDK? thanks

@yungezz @msyyc these are the breaking changes in python sdk logs:
[ChangeLog] Breaking changes
[ChangeLog]
[ChangeLog]   - Model ManagedCluster no longer has parameter reverse_proxy_endpoint_port
[ChangeLog]   - Model ManagedCluster no longer has parameter use_test_extension
[ChangeLog]   - Model ManagedClusterUpdateParameters no longer has parameter reverse_proxy_endpoint_port
not sure why it's showing this because I didn't make any changes on these modes that are located in the 2020-01-01-preview version. These changes were done in this pr that is already merged: https://github.com/Azure/azure-rest-api-specs/pull/10728.
Can we merge this pr?

@yungezz @msyyc these are the breaking changes in python sdk logs:
[ChangeLog] Breaking changes
[ChangeLog]
[ChangeLog] - Model ManagedCluster no longer has parameter reverse_proxy_endpoint_port
[ChangeLog] - Model ManagedCluster no longer has parameter use_test_extension
[ChangeLog] - Model ManagedClusterUpdateParameters no longer has parameter reverse_proxy_endpoint_port
not sure why it's showing this because I didn't make any changes here for these modes that are located in the 2020-01-01-preview. These changes were done in a previous pr that is already merged: #10728.
Can we merge this pr?

hi @msyyc, is it ok for Python SDK? I don't have concern here. thanks.

@msyyc can you respond to @yungezz so we can merge the pr please?

@msyyc has not responeded. @yungezz can we merge? I'm not going to generate sdks for 2020-01-01-preview which is what the breaking changes validation is complaining about

/azp run

hi @a-santamaria I rerun CI and seems more CI failed, could you pls fix CI failure? For Python SDK breaking change, you're right, it's caused by previous PR, I think it's ok.

/azp run

@yungezz I think they should be fixed now, but not all of them have run. Some checks say "Expected — Waiting for status to be reported"

/azp run

@yungezz I re-ran ci tasks. Only swagger APIDocPreview gets stuck. Can we merge, please?

@yungezz any update?


fix: set up server side styled-components

In #337 I noticed that the initial render for our app is always blank. I had a suspicion that this would be hiding some surprises
If you load that page without JS enabled you'll see that the initial render is missing the styled components styling. I've followed the official guide to integration styled components, and checked that it's the same approach the OWA uses

:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


An error occurred while parsing RTP packet

Hi. I get an error while waiting for a response from a participant. What could be the reason for this?
The error is repeated during the connection.
i am using 2 pc on local network for testing
[warn] [{:srtp_decryptor, #Reference<0.3821044555.2247622657.249818>}] Couldn't unprotect rtp packet:
<<1, 1, 0, 56, 33, 18, 164, 66, 144, 45, 192, 226, 17, 180, 172, 130, 190, 188, 15, 235, 0, 32, 0, 20, 0, 2, 178, 244, 1, 19, 172, 226, 98, 74, 99, 227, 220, 80, 35, 19, 24, 238, 8, 211, 0, 8, 0, 20, 188, 185, 121, 86, 29, 16, 198, 89, 62, 60, 53, 232, 105, 183, 93, 143, 98, 99, 126, 242, 128, 40, 0, 4, 70, 146, 114, 110>>
Reason: :auth_fail. Ignoring packet.
[warn] [:depayloader] An error occurred while parsing RTP packet.
 I think that we see the same warnings and you shouldn't be worried about them

[warn] [{:srtp_decryptor, #Reference<0.3821044555.2247622657.249818>}] Couldn't unprotect rtp packet:
<<1, 1, 0, 56, 33, 18, 164, 66, 144, 45, 192, 226, 17, 180, 172, 130, 190, 188, 15, 235, 0, 32, 0, 20, 0, 2, 178, 244, 1, 19, 172, 226, 98, 74, 99, 227, 220, 80, 35, 19, 24, 238, 8, 211, 0, 8, 0, 20, 188, 185, 121, 86, 29, 16, 198, 89, 62, 60, 53, 232, 105, 183, 93, 143, 98, 99, 126, 242, 128, 40, 0, 4, 70, 146, 114, 110>>
Reason: :auth_fail. Ignoring packet.

This might be interesting. Does it repeat or it occurs only at the beginning of the communication?

After this message, the buffer overflows and crashes.
[warn] [{:srtp_decryptor, #Reference<0.2083819021.4116709377.217648>}] Terminating element possibly not prepared for termination as it was in state :playing.
Reason: {%RuntimeError{message: "InputBuffer :input (toilet): Toilet overflow.\n\nReached the size of 161,\nwhich is above fail level when storing data from output working in push mode.\nTo have control over amount of buffers being produced, consider using pull mode.\nIf this is a normal situation, increase warn/fail size in buffer options.\n\nSee `Membrane.Core.Inpu>
State: %Membrane.Core.Element.State{
controlling_pid: #PID<0.4894.0>,
delayed_demands: #MapSet<[]>,
internal_state: %{
policies: [],
srtp: {ExLibSRTP, #Reference<0.2083819021.4116840449.217761>}
},
module: Membrane.SRTP.Decryptor,
name: {:srtp_decryptor, #Reference<0.2083819021.4116709377.217648>},

I think the whole problem is in the certificates. In a prod environment, they are connected via nginx (proxy). Do I need to connect them directly? Are there any recommendations for connecting certificates?


[EMB-221] Hide deleted forks on a node's forks list view

Purpose
/v2/nodes/<guid>/forks doesn't hide deleted forks
Changes
Make sure, like the v1 view, the NodeForksList view excludes deleted forks.
QA Notes

Create a node
Fork the node
Delete the fork
Go to /v2/nodes//forks

the deleted fork should not be listed.
Ticket
https://openscience.atlassian.net/browse/EMB-221

replaced by https://github.com/CenterForOpenScience/osf.io/pull/8301


readme.md points to wrong npm package name

Under "Usage" we are pointing users to cimpress-fulfillment-location and not fulfillment-location-client.

Related but I don't know where to put issues about the npm set up ...
https://www.npmjs.com/package/fulfillment-location-client mentions the githost repo not the github repo. Probably want to change that too.


Visual tests

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #13
Test URLs:

Before: https://main--sunstar--hlxsites.hlx.live/

After: https://visual-tests--sunstar--hlxsites.hlx.live/

[ ]  If you are adding a new block or a variation to an existing block, has it been added in the block-library ?

🔸 1 visual difference detected

/ (main vs branch)Expected an image 1280px by 3210px, received 1280px by 3727px. 742373 pixels (ratio 0.16 of all image pixels) are different.

The diff images are attached in the artifact

@sdmcraft I am not able to see any diff image as mentioned in the above comment

@sdmcraft I am not able to see any diff image as mentioned in the above comment

You'd need to download the test artifact and unzip it.

BTW, there was a problem with footer handling and it should be addressed with https://github.com/hlxsites/sunstar/pull/27/commits/4b09b15725a0edfb32601f9fd5a37553cf65ddef

@sdmcraft Sorry for being late but left couple of comments here. May be u can check those.


Added virtual-each to dev dependencies

The ember Addon Virtual-Each was missing.
This caused the demo to not display the example correctly.

I thought this would fix the online demo as well. I want to fix the too.

@Alonski I just pushed a new commit to the gh pages branch & everything looks good. Thanks for the PR!


Fix integer overflow in HTTP _addHeaders buffer offset calculations.

Fix an integer overflow in pointer arithmetic.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The requests

https://github.com/aws/amazon-freertos/pull/1173
https://github.com/aws/amazon-freertos/pull/1174

are failing CBMC tests because both are required for all tests to pass.


Nested Framework HandySwift

Hi,
we're using your CSVImporter Framework with Carthage. At first glance this works fine, but then we tried to submit our App to the AppStore (actually a Testflight build) and got severals errors regarding nested Frameworks.
The problem is the embedded HandySwift framework inside the CSVImporter framework. This results in two HandySwift.frameworks inside the final App Archive.
We had this issue with some others Frameworks before. The solution (which is recommended from Carthage itself) is not (!) to embed any dependencies of a Framework, but only embed these dependencies at top-most level (i.e. the actual App). This PR removes the nested Framework HandySwift, builds fine and could be submitted to the AppStore.
The actual fetching of the HandySwift Framework is still triggered by the CSVImporter Framework's Cartfile, but you have to add the HandySwift Framework to your App-Project by hand.

Hey @LordNali thanks for the PR. Could you give me the source where the Carthage recommendation is done? I'm willing to merge this, but I always thought the goal of Carthage is providing a solution for installing dependencies, even if they have sub-dependencies – to prevent dependency hell. So, I wonder if this really is the way to go ...

Sure - sorry I didn't do this in the first place: Begin here there's quiet a long discussion:
https://github.com/Carthage/Carthage/issues/844#issuecomment-147783855
https://github.com/Carthage/Carthage/issues/844#issuecomment-147823805

Thanks @LordNali for the links, I actually remember having read this somewhere else, but just like @kgn I was irritated by the Adding frameworks to unit tests or a framework. To be honest, after checking out your fork and running the build I was surprised that is built successfully without having HandySwift embedded in any way. But then I realized that it must be included via Framework Search Paths so I definitely learned something here. Thanks for that!
I've merged your commit (with a small commit rename and cleanup) and released version 1.7.1 which now includes your change and should not have problems with App Store uploads any more!


⚠ Samsung has degraded performance

In 5be2dde, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2320 ms

Resolved: Samsung performance has improved in 8f96674.


🚀 [Feature Request] - Add Show password button

Is your feature request related to a problem ? Please describe. ✍
Hey, I want to add the show password button on both the login and register pages.

Can you please assign it to me under the GSSOC'23?
Describe briefly how you would implement this enhancement.
Some steps to implement this enhancement-
1. Step 1
2. Step 2
3. Step 3

Additional context or screenshots
Additional context
Are you contributing for a program?
GSSoC2023
Code of Conduct

[X] I have read and agree to the Contributing Guidelines of this project.

@Abhinavcode13 Can please assign it to me?


[Feat]: What is the best workaround for grounding with image input?

Is your feature request related to a problem? Please describe.
I'm frustrated that VertexAI grounding is not supported if input is non-text.
Describe the solution you'd like
Is there currently a convenient workaround for it? I'd like to have this functionality of being able to ask for ex:
input(what this item is made of? + [image]) -> grounded search of what item like this is usually made of in the document -> output(text)
Describe alternatives you've considered
There is obviously a way of making 2 separate calls:

Querying about what is the item in the image
Pass that text output to a model with grounding which inputs only text

However, that increases costs massively.
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The best workaround we have, if you specifically need to use the grounding feature, is to do two separate calls. One to get information about the image/document (without grounding), then another with the image description with grounding enabled.


Technologies used (picom, etc.) is not listed in Wiki

Hi there! I watched your video on Reddit and gave it a try!
Please describe the bug
I followed all steps for building and adding to Xsessions, however when I start from SDDM, Arch Linux, nothing happens but there comes a black-ish bar on top of my SDDM. I guess that Hypr is trying to start some applications as picom, but fails.
Steps to reproduce:
Have a clean build of Arch + KDE, build Hypr, watch it failing to start
Expected behavior
Hypr starts successfully as expected
Screenshots
I will add in the reply
Anything else?
Also, is there any tutorial/wiki on hotkeys? I am a bit lost. I can contribute to wiki if that would be helpful

Bar on top is hardly visible, SDDM itself is unclickable, like it's an image. When I worked with other WMs, like BSPWM, an experience was similar. The bar comes in with an animation, slides down in about 0.5 seconds.

You need to start something.  With the default config, you have no keybinds. (I forgot to mention that, I should make it automatically use the example)
Paste the example config (/example/hypr.conf) into ~/.config/hypr/hypr.conf
Press SUPER+ENTER to open xterm. It should pop up.
To set up a wallpaper, use something like feh or nitrogen. That will make your SDDM login screen disappear.

I have updated the wiki to explicitly say you need to copy the example config. I might make hypr generate a basic config in the future if none are found.
Please let me know if the instructions above fix your issue.

To set up a wallpaper, use something like feh or nitrogen. That will make your SDDM login screen disappear.

Thanks, I did that, but now I got another issue, I will open it


Blackscreen on adrenaline

the newest update should support adrenaline , but on adrenaline v4 the plugin cause blackscreen because when i disable the plugin the adrenaline work

Are you using any other plugins with this?

yes, im using oclock
but it work for everything else

Do you have oclockvita set to all?
The way I have it is that oclockvita is set to certain games such as for example Persona 4 Golden, but I have VITABattery set to *ALL.
This way both of them work just fine for me, however oclock does not work on Adrenaline, but VITABattery does. I don't use oclockvita on adrenaline anyway.

yeah i set the oclock to all
well i guess i need to set oclock for specific game only right now....

Does oclockvita even work on adrenaline?  Atheist by itself?

Oclock can't be used with Adrenaline.
Begin deleting oclockvita asignment to Adrenaline in config.txt.

Thanks for confirming @CelesteBlue-dev.
This is a problem with oclockvita, and not VITABattery.


Can't upgrade magento version

This is due to the location of the download file in mage-setup
A publicly available source can be found here:
http://pubfiles.nexcess.net/magento/ce-packages/

@gsc-dev awesome! i was starting to load them into my google cloud storage, but if nexcess already offers this, all the better. good timing as i'm getting ready to upload new test builds right now.

Pushed out to rc0 tag. Please follow https://github.com/mageinferno/magento2-docker-compose/issues/5 for updates on the new tags/releases. The most recent one contains this fix.

Works well @markoshust
Can't wait to see the changes also applied to php 5.6 branch.
I use some extensions protected by zend guard. Would it be possible to add the loader to the image:
https://www.zend.com/en/products/loader/downloads
     wget .... zend-loader-php5.6-linux-x86_64.tar.gz
     tar -zxvf zend-loader-php5.6-linux-x86_64.tar.gz
     cp zend-loader-php5.6-linux-x86_64/* /etc/php5/cli/
     echo "zend_extension = /etc/php5/cli/opcache.so" >> /etc/php5/cli/php.ini
     echo "zend_extension = /etc/php5/cli/ZendGuardLoader.so" >> /etc/php5/cli/php.ini
     echo "always_populate_raw_post_data = -1" >> /etc/php5/cli/php.ini

@gsc-dev thanks for the info. once i confirm all is final & signed off for php 7 branch, i will definitely backport the changeset to php 5 branch.
thanks for the snippet above for zendguard. i don't see any reason not to add this in. do you have a related install script for ioncube?

Great Mark,
Would be nice if changes are also appil

@markoshust Thanks Mark,
I haven't used ioncube but I believe this is what you are looking for:
https://www.howtoforge.com/install-ioncube-loader-for-all-php-modes-cli-cgi-fcgi-and-fpm-on-debian-wheezy
Cheers

@gsc-dev thanks, I'll see what I can do about getting this in the next release. I didn't want to hold up the new builds to install + test the zendguard/ioncube out, as these last builds took some time to complete.
fyi i pushed out the new images (including php 5), info at https://github.com/mageinferno/magento2-docker-compose/issues/5#issuecomment-212506584


Does this work with cloudflare?

Love this work!
Tried using encrypted .env with cloudflare but am noticing that the decrypted values isn't being inject and that cloudflare is reading the raw values directly.
Here's how I'm running it
dotenvx run -f ./.dev.vars -- wrangler dev
Curious to know if I'm doing something wrong!

can you share a little more of what your wrangler.toml file looks like?
i haven't used wrangler myself. seems like it does not respect a machine's environment variables at first glance. what it calls environment variables are really just hardcoded vars in the toml file?

we'll be adding a dotenvx decrypt command. at that time, we'll probably support piping the output to another file - which then could give you this convenience.

dotenvx decrypt is now available in 1.6.0 and greater.
$ dotenvx decrypt
$ dotenvx decrypt --stdout
$ dotenvx decrypt --stdout > somefile.txt


Test PR A - Change blue to magenta

This is a dummy PR as part of testing https://github.com/Expensify/Expensify.cash/pull/3216. It will soon be reverted.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging in version: 1.0.61-8🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.62-0🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Benchmark Milk-V Jupiter

As the title says...
Similar to https://github.com/geerlingguy/top500-benchmark/issues/35 I will probably run Ansible from a separate computer.

For some reason, trying Ansible from my Mac, I'm getting:
    debug3: sign_and_send_pubkey: signing using ssh-ed25519 [...]
    debug3: send packet: type 50
    Connection closed by <IP_ADDRESS> port 22

And I can't get it to auth with password or key, on either my jgeerling account or root. I can log in via SSH with both key and password via my normal CLI login, it seems like something server-side is blocking things out maybe?
The auth.log even seems to indicate SSH is happy on the server side, the connection just... drops:
2024-07-20T05:13:18.194612+08:00 milkv-jupiter sshd[7779]: Accepted publickey for root from <IP_ADDRESS> port 61453 ssh2: ED25519 [...]
2024-07-20T05:13:35.366477+08:00 milkv-jupiter sshd[7785]: Accepted password for jgeerling from <IP_ADDRESS> port 61454 ssh2

Using my guide for Installing Ansible on a RISC-V computer, I got it up and running. I will have to run this playbook locally, I guess.

Power consumption during the benchmark run is around 10.7W:

Run with Ps 1 and Qs 8: 5.6009 Gflops at 10.7W, 0.52 Gflops/W
================================================================================
HPLinpack 2.3  --  High-Performance Linpack benchmark  --   December 2, 2018
Written by A. Petitet and R. Clint Whaley,  Innovative Computing Laboratory, UTK
Modified by Piotr Luszczek, Innovative Computing Laboratory, UTK
Modified by Julien Langou, University of Colorado Denver
================================================================================

An explanation of the input/output parameters follows:
T/V    : Wall time / encoded variant.
N      : The order of the coefficient matrix A.
NB     : The partitioning blocking factor.
P      : The number of process rows.
Q      : The number of process columns.
Time   : Time in seconds to solve the linear system.
Gflops : Rate of execution for solving the linear system.

The following parameter values will be used:

N      :   34581
NB     :     256
PMAP   : Row-major process mapping
P      :       1
Q      :       8
PFACT  :   Right
NBMIN  :       4
NDIV   :       2
RFACT  :   Crout
BCAST  :  1ringM
DEPTH  :       1
SWAP   : Mix (threshold = 64)
L1     : transposed form
U      : transposed form
EQUIL  : yes
ALIGN  : 8 double precision words

--------------------------------------------------------------------------------

- The matrix A is randomly generated for each test.
- The following scaled residual check will be computed:
      ||Ax-b||_oo / ( eps * ( || x ||_oo * || A ||_oo + || b ||_oo ) * N )
- The relative machine precision (eps) is taken to be               1.110223e-16
- Computational tests pass if scaled residuals are less than                16.0

================================================================================
T/V                N    NB     P     Q               Time                 Gflops
--------------------------------------------------------------------------------
WR11C2R4       34581   256     1     8            4922.54             5.6009e+00
HPL_pdgesv() start time Sat Jul 20 22:50:43 2024

HPL_pdgesv() end time   Sun Jul 21 00:12:46 2024

--------------------------------------------------------------------------------
||Ax-b||_oo/(eps*(||A||_oo*||x||_oo+||b||_oo)*N)=   2.26617141e-03 ...... PASSED
================================================================================

Finished      1 tests with the following results:
              1 tests completed and passed residual checks,
              0 tests completed and failed residual checks,
              0 tests skipped because of illegal input values.
--------------------------------------------------------------------------------

End of Tests.
================================================================================

7.2W, 3.0838 Gflops, for 0.43 Gflops/W (so a bit less efficient, as would be expected, running with 1/4 Ps/Qs:
================================================================================
HPLinpack 2.3  --  High-Performance Linpack benchmark  --   December 2, 2018
Written by A. Petitet and R. Clint Whaley,  Innovative Computing Laboratory, UTK
Modified by Piotr Luszczek, Innovative Computing Laboratory, UTK
Modified by Julien Langou, University of Colorado Denver
================================================================================

An explanation of the input/output parameters follows:
T/V    : Wall time / encoded variant.
N      : The order of the coefficient matrix A.
NB     : The partitioning blocking factor.
P      : The number of process rows.
Q      : The number of process columns.
Time   : Time in seconds to solve the linear system.
Gflops : Rate of execution for solving the linear system.

The following parameter values will be used:

N      :   34581
NB     :     256
PMAP   : Row-major process mapping
P      :       1
Q      :       4
PFACT  :   Right
NBMIN  :       4
NDIV   :       2
RFACT  :   Crout
BCAST  :  1ringM
DEPTH  :       1
SWAP   : Mix (threshold = 64)
L1     : transposed form
U      : transposed form
EQUIL  : yes
ALIGN  : 8 double precision words

--------------------------------------------------------------------------------

- The matrix A is randomly generated for each test.
- The following scaled residual check will be computed:
      ||Ax-b||_oo / ( eps * ( || x ||_oo * || A ||_oo + || b ||_oo ) * N )
- The relative machine precision (eps) is taken to be               1.110223e-16
- Computational tests pass if scaled residuals are less than                16.0

================================================================================
T/V                N    NB     P     Q               Time                 Gflops
--------------------------------------------------------------------------------
WR11C2R4       34581   256     1     4            8940.58             3.0838e+00
HPL_pdgesv() start time Sun Jul 21 09:39:43 2024

HPL_pdgesv() end time   Sun Jul 21 12:08:44 2024

--------------------------------------------------------------------------------
||Ax-b||_oo/(eps*(||A||_oo*||x||_oo+||b||_oo)*N)=   3.03925351e-03 ...... PASSED
================================================================================

Finished      1 tests with the following results:
              1 tests completed and passed residual checks,
              0 tests completed and failed residual checks,
              0 tests skipped because of illegal input values.
--------------------------------------------------------------------------------

End of Tests.
================================================================================

And finally, 2/4 Ps/Qs: 5.6560 Gflops, 10.6 W, for 0.53 Gflops/W
================================================================================
HPLinpack 2.3  --  High-Performance Linpack benchmark  --   December 2, 2018
Written by A. Petitet and R. Clint Whaley,  Innovative Computing Laboratory, UTK
Modified by Piotr Luszczek, Innovative Computing Laboratory, UTK
Modified by Julien Langou, University of Colorado Denver
================================================================================

An explanation of the input/output parameters follows:
T/V    : Wall time / encoded variant.
N      : The order of the coefficient matrix A.
NB     : The partitioning blocking factor.
P      : The number of process rows.
Q      : The number of process columns.
Time   : Time in seconds to solve the linear system.
Gflops : Rate of execution for solving the linear system.

The following parameter values will be used:

N      :   34581
NB     :     256
PMAP   : Row-major process mapping
P      :       2
Q      :       4
PFACT  :   Right
NBMIN  :       4
NDIV   :       2
RFACT  :   Crout
BCAST  :  1ringM
DEPTH  :       1
SWAP   : Mix (threshold = 64)
L1     : transposed form
U      : transposed form
EQUIL  : yes
ALIGN  : 8 double precision words

--------------------------------------------------------------------------------

- The matrix A is randomly generated for each test.
- The following scaled residual check will be computed:
      ||Ax-b||_oo / ( eps * ( || x ||_oo * || A ||_oo + || b ||_oo ) * N )
- The relative machine precision (eps) is taken to be               1.110223e-16
- Computational tests pass if scaled residuals are less than                16.0

================================================================================
T/V                N    NB     P     Q               Time                 Gflops
--------------------------------------------------------------------------------
WR11C2R4       34581   256     2     4            4874.58             5.6560e+00
HPL_pdgesv() start time Sun Jul 21 14:48:40 2024

HPL_pdgesv() end time   Sun Jul 21 16:09:54 2024

--------------------------------------------------------------------------------
||Ax-b||_oo/(eps*(||A||_oo*||x||_oo+||b||_oo)*N)=   3.03925351e-03 ...... PASSED
================================================================================

Finished      1 tests with the following results:
              1 tests completed and passed residual checks,
              0 tests completed and failed residual checks,
              0 tests skipped because of illegal input values.
--------------------------------------------------------------------------------

End of Tests.
================================================================================

It has been done!


TypeError: axe.run arguments are invalid

I know this is an early project. Nevertheless I tried the setup as described in the README but await runAxe(axeContext, axeOptions); gives TypeError: axe.run arguments are invalid
Note this might be more of an issue with https://github.com/testcafe-community/axe but since you've introduced runAxe for the sake of this reporter I thought I fill an issue here.

Want to check some details:

Have you used the example code I provided in the readme?
Which axe-core version is installed?

I have some type fixes in https://github.com/testcafe-community/axe/pull/4 and I hope to have them published soon but I haven't reproduced TypeError: axe.run arguments are invalid yet.

Can you please also check how I set up axe rules and options in this demo project:
https://github.com/lpelypenko/axe-testcafe-demo

I've grabbed te latest version of https://github.com/testcafe-community/axe and I'm not seeing this issue anymore. So fixed.


Get new list after filter into model

Hi, is it possible to get the new list of items after we update filter?
I would like to export table into csv file and let user select with filter information needed.
(the filter is in column header)
Thanks!

A solution can be to select all after filter. How can we do this?

You can access them by attaching to the grid's reporting vars.

Thank you!


Improved grammar & punctuation in DEVELOPMENT.md

whoops, should have made against https://github.com/graphql/graphiql.  closing here, will recreate.


observability: add stream stats to the http dispatcher

Description: stream level stats for the http dispatcher
Risk Level:  low, new stats
Testing: added new integration tests
Docs Changes: will add to public docs if we find these stats useful internally. I want to have tables similar to envoy's, e.g., https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter.html?highlight=virtual cluster#virtual-clusters
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

Can we also create an issue to add docs for this?

It's green now!


clippy::module-name-repetitions

error: item name ends with its containing module's name
  --> src/parser.rs:30:1
   |
30 | / pub struct RequestParser {
31 | |     verification_token: String,
32 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
   = note: requested on the command line with `-D clippy::module-name-repetitions`

error: item name starts with its containing module's name
  --> src/payloads/channel.rs:41:1
   |
41 | / pub struct ChannelCreatedPayload {
42 | |     #[serde(with = "crate::payloads::serde::timestamp")]
43 | |     pub event_time: TimeStamp,
44 | |     pub channel: Channel,
45 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/channel.rs:87:1
   |
87 | / pub struct ChannelTopicChangedPayload {
88 | |     #[serde(with = "crate::payloads::serde::timestamp")]
89 | |     pub event_time: TimeStamp,
90 | |     pub channel: Channel,
91 | |     pub topic: String,
92 | |     pub updater: User,
93 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/message.rs:53:1
   |
53 | / pub struct MessageCreatedPayload {
54 | |     #[serde(with = "crate::payloads::serde::timestamp")]
55 | |     pub event_time: TimeStamp,
56 | |     pub message: Message,
57 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/message.rs:93:1
   |
93 | / pub struct MessageDeletedPayload {
94 | |     #[serde(with = "crate::payloads::serde::timestamp")]
95 | |     pub event_time: TimeStamp,
96 | |     pub message: DeletedMessage,
97 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
   --> src/payloads/message.rs:138:1
    |
138 | / pub struct MessageUpdatedPayload {
139 | |     #[serde(with = "crate::payloads::serde::timestamp")]
140 | |     pub event_time: TimeStamp,
141 | |     pub message: Message,
142 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/stamp.rs:35:1
   |
35 | / pub struct StampCreatedPayload {
36 | |     #[serde(with = "crate::payloads::serde::timestamp")]
37 | |     pub event_time: TimeStamp,
38 | |     pub id: Uuid,
...  |
41 | |     pub creator: User,
42 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/tag.rs:28:1
   |
28 | / pub struct TagAddedPayload {
29 | |     #[serde(with = "crate::payloads::serde::timestamp")]
30 | |     pub event_time: TimeStamp,
31 | |     pub tag_id: Uuid,
32 | |     pub tag: String,
33 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/tag.rs:69:1
   |
69 | / pub struct TagRemovedPayload {
70 | |     #[serde(with = "crate::payloads::serde::timestamp")]
71 | |     pub event_time: TimeStamp,
72 | |     pub tag_id: Uuid,
73 | |     pub tag: String,
74 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/user.rs:32:1
   |
32 | / pub struct UserCreatedPayload {
33 | |     #[serde(with = "crate::payloads::serde::timestamp")]
34 | |     pub event_time: TimeStamp,
35 | |     pub user: User,
36 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/user_group.rs:54:1
   |
54 | / pub struct UserGroupCreatedPayload {
55 | |     #[serde(with = "crate::payloads::serde::timestamp")]
56 | |     pub event_time: TimeStamp,
57 | |     pub group: UserGroup,
58 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
  --> src/payloads/user_group.rs:78:1
   |
78 | / pub struct UserGroupUpdatedPayload {
79 | |     #[serde(with = "crate::payloads::serde::timestamp")]
80 | |     pub event_time: TimeStamp,
81 | |     pub group_id: Uuid,
82 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
   --> src/payloads/user_group.rs:111:1
    |
111 | / pub struct UserGroupDeletedPayload {
112 | |     #[serde(with = "crate::payloads::serde::timestamp")]
113 | |     pub event_time: TimeStamp,
114 | |     pub group_id: Uuid,
115 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
   --> src/payloads/user_group.rs:147:1
    |
147 | / pub struct UserGroupMemberAddedPayload {
148 | |     #[serde(with = "crate::payloads::serde::timestamp")]
149 | |     pub event_time: TimeStamp,
150 | |     pub group_member: GroupMember,
151 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
   --> src/payloads/user_group.rs:201:1
    |
201 | / pub struct UserGroupMemberUpdatedPayload {
202 | |     #[serde(with = "crate::payloads::serde::timestamp")]
203 | |     pub event_time: TimeStamp,
204 | |     pub group_member: GroupMember,
205 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
   --> src/payloads/user_group.rs:246:1
    |
246 | / pub struct UserGroupMemberRemovedPayload {
247 | |     #[serde(with = "crate::payloads::serde::timestamp")]
248 | |     pub event_time: TimeStamp,
249 | |     pub group_member: GroupMember,
250 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
   --> src/payloads/user_group.rs:300:1
    |
300 | / pub struct UserGroupAdminAddedPayload {
301 | |     #[serde(with = "crate::payloads::serde::timestamp")]
302 | |     pub event_time: TimeStamp,
303 | |     pub group_member: GroupMember,
304 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

error: item name starts with its containing module's name
   --> src/payloads/user_group.rs:345:1
    |
345 | / pub struct UserGroupAdminRemovedPayload {
346 | |     #[serde(with = "crate::payloads::serde::timestamp")]
347 | |     pub event_time: TimeStamp,
348 | |     pub group_member: GroupMember,
349 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

payload以下はallow明示
parserはstruct宣言だけlib.rsに移せないか


There is no bind.demo()

Hello, I'd like to inquire about the version of the bind library you are using, and why there is no bind.demo() function.
AttributeError: module 'bind' has no attribute 'demo'

same problem


Add link to Wyoming Advanced Blockchain Lab

I just noticed the link for this is elsewhere in the document.  Closing.


Flag indicate end of stream

Hi, during request streaming it'll be helpful to have a flag to indicate end of generation. Can you help with this feature request?

That's right, looks like the flag is already there in SendResponseCallback , then I guess what I'm asking is to include it in the Triton backend implementation https://github.com/triton-inference-server/tensorrtllm_backend/blob/release/0.5.0/inflight_batcher_llm/src/libtensorrtllm.cc#L892
let me know if I should reopen a ticket there

It'd be nice if you could do that. Thanks!

do u still have further issue or question now? If not, we'll close it soon.


Removes ecowden/loopback-connector-knex

The loopback-connector-knex project I created a while back was an experiment and was never intended as a real, production tool. It has long since been deleted. I certainly wouldn't consider it awesome, so we should probably remove it from the list. 😉

👍


Adapt to display output of VGS

What is the purpose of this PR?

Sorry, didn't mean to file a PR back to the mcneel repository. Am going to close.


Cherry-pick PR:#2469

Cherry-pick PR:https://github.com/operator-framework/operator-sdk/pull/2469

ignoree


all custom "make" for server_source recipe

It seems they have made the old red/black theme default again - and I liked the cleaner exfoliation UI.
I'd submit a PR, but I'm not sure if it is best to open it up to allow for any custom "make" addition or just add a new attribute for "exfoliation_ui" that adds "make install_exfoliation" to the source build/install command.

I would go with the most configurable option and set your preferred option as default :wink:

ok - I'll put together a PR for this.

Merged


Fix “Can connect to a remote peer” test

#1778
The timeout of 1s also worked in 3 consecutive tests, set 5s just in case to avoid test fails. Need to investigate the reasons why MPCF advertises the peer after stopAdvertisingPeer() is called

This change is

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@drinkius @chapko I know this was checked in and I have no argument with that at all. It's fine. But it would be good if you could please just fix the comment so in the future we know why the timeout was there.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 243 at r1 (raw file):

test('Can connect to a remote peer', function (t) {
  setTimeout(function () {

Can we at least put in the bug number or something so that people understand why this timeout is here?

Comments from Reviewable


Helfi ahjo

Features:

Organization chart page
Organizations tree
Taxonomy tree based on Ahjo API response
Administration page to set the configurations and set the cronjob /admin/config/ahjo
Option to force to resync the organizations
A block to add the organizations tree

To test the module:

You need to set the credentials to: /admin/config/ahjo
Press the 'Import Data and Sync' button (you can check the data to admin/structure/taxonomy/manage/sote_section/overview)
Go to Structure - Block layout - Place a block - Sote Section)
To check the organization diagram you have to go to /organizationchart
If you want to force data to resync you have to go to admin/config/ahjo/cron and press 'Run Cron Job Now' button

Could you please rebase this against the current dev branch?

I'll split helfi_ahjo into platform config and hdbt theme and i'll refactor the code.


Error message for undefined atom/bead types

Not a bug but possible enhancement.
This is the error one gets if the [ atoms ] contains a atom/bead type S4 that is not defined in the [atomtypes] section:
Traceback (most recent call last):
  File "/Users/alessandri/miniconda3/envs/polyply/bin/polyply", line 258, in <module>
    main()
  File "/Users/alessandri/miniconda3/envs/polyply/bin/polyply", line 254, in main
    subprogram(**args_dict)
  File "/Users/alessandri/miniconda3/envs/polyply/lib/python3.10/site-packages/polyply/src/gen_coords.py", line 246, in gen_coords
    GenerateTemplates(topology=topology, max_opt=10).run_system(topology)
  File "/Users/alessandri/miniconda3/envs/polyply/lib/python3.10/site-packages/polyply/src/processor.py", line 31, in run_system
    mols.append(self.run_molecule(molecule))
  File "/Users/alessandri/miniconda3/envs/polyply/lib/python3.10/site-packages/polyply/src/generate_templates.py", line 366, in run_molecule
    self.gen_templates(meta_molecule)
  File "/Users/alessandri/miniconda3/envs/polyply/lib/python3.10/site-packages/polyply/src/generate_templates.py", line 353, in gen_templates
    self.volumes[resname] = compute_volume(block,
  File "/Users/alessandri/miniconda3/envs/polyply/lib/python3.10/site-packages/polyply/src/generate_templates.py", line 180, in compute_volume
    rad = float(nonbond_params[frozenset([atom_key, atom_key])]["nb1"])
KeyError: frozenset({'S4'})

This error message for this could be improved. Opening this issue to hear your opinion and in case I can try to add an error message.
(P.S. Sorry I need to catch up with a couple of PRs but I'm planning to schedule some closing-open-PRs hackathon soon :))

@ricalessandri for sure this can become an error message. The only question is from where to raise it. There are several functions that require the beads types to be present. Anyways, let's start with this one and then I'll think about of other places would benefit from the same error message.


Asteroids should spawn outside viewport

Right now new asteroids are cfreated on borders, but should be outside playfield. This is a bit tricky, as we have the logic implemented to let them reenter whenever they leave, so this might need to be disabled initially until first enter

Fixed in #44


fix a bug

Description:
This update addresses a bug where the Roadmap button was not functioning correctly. The issue has been resolved, ensuring that the button operates as intended. Additionally, a new styling feature has been implemented: when the button is active, it will turn white with black text, providing a clear visual indication of its state. This improvement enhances the user experience by making the active button more distinguishable.

This is PR of issuse #1

I cann't lebals it. please help me to lebal it.
@amanazads

It is showing some bugs in the code. The loading speed is also slow and the banner is not loading properly. Can you check it once and fix it ?

I have fixed the bugs; please check them.

Kindly check the nav bar/header. On scrolling up it doesn’t look like as it was earlier. Kindly check and fix it

I've fixed the navigation bar. Please have a look, @amanazads .

on home screen, (roadmap buttons section) put the buttons 3 on left side and three on right according to the original website

Increase some margin between cards, roadmap and footer in home screen

@amanazads please check the website

The issue I assigned as #1 has a level 2 priority. Please fix it accordingly.
@amanazads @yatulearn

Issue has already been assigned as the level 2

Is the code correct?
@amanazads

Good Job

We will merge it very soon

maintain the margin between cards-roadmap and roadmap-footer

maintain the margin between cards-roadmap and roadmap-footer
Sorry, I didn't understand it. can you explain more about it.
@yatulearn

Are you tell about this margin ?

@yatulearn

Are you tell about this margin ?
@yatulearn

notice the black arrow, and set the margins equal upper and lower

@yatulearn I fix the mergin of the rodmap div

please check it out

Good Job. Thank You

I am not able to merge to merge it. Kindly check the issue and resolve it.

your PR has conflicts that need to be addressed. Please review and resolve any issues. After resolving them, you can proceed to create a pull request. It is essential to resolve these conflicts in the branch.


Does not create maccatalyst but mac os

Describe the bug
I was using Surmagic to create xcframework for UnrarKit (https://github.com/abbeycode/UnrarKit/tree/v2.11). But instead of create xcframework for Mac Catalyst, It created xcframework for macOS.
To Reproduce
Steps to reproduce the behavior:

I run the command 'urmagic xcf'
See error '/Users/huynguyen/Downloads/UnrarKit-2.11/ahihi/UnrarKit.xcframework:1:1: While building for Mac Catalyst, no library for this platform was found in '/Users/huynguyen/Downloads/UnrarKit-2.11/ahihi/UnrarKit.xcframework'.'

Expected behavior
support Mac Catalys
Screenshots

![Screen Shot 2022-08-08 at 11 37 30](https://user-images.githubusercontent.com/32290683/183340235-14620a84-25bf-4ab7-82a5-9cdcf04615d3.png)
Details

If you can, please share the output of the -surmagic env- command
Or, please share the list below:

macOS version, [Monterey 12.5)]
Swift version, [5.6]
Your CPU type, [ M1 Pro]

Checklist

[x] If possible, I've reproduced the issue using the master branch of this package
[x] I've searched for existing GitHub issues

Hi @huynguyen230892,
thank you for contributing! Hmm, it's probably a bug, I don't have time to test right now. But I'll try to fix the error as soon as possible on the weekends. Also, please, feel free to contribute 😉
Best

Hello, Any news on this? @gurhub 😁

Hello, Any news on this? @gurhub

Sorry, but not seems possible soon.
Hey! Feel free to contribute to the project by fixing this!


feat: Add Giscus comment system

#72 Support Gisus comment system with auto switch base on Light and Dark theme.

Have some bug


Error message given when features are enabled but not present is not accurate

I had set the "Rust-analyzer > Cargo: Features" setting to have a feature chrono, which, when I opened another project without said feature, caused rust-analyzer to be unhappy. The error message I got, however, wasn't particularly good:

rust-analyzer failed to load workspace: Failed to read Cargo metadata from Cargo.toml file c:\Users\alexs\Documents\Projects\foobar\Cargo.toml, cargo 1.56.0 (4ed5d137b 2021-10-04): Failed to run cargo metadata --manifest-path c:\Users\alexs\Documents\Projects\foobar\Cargo.toml: cargo metadata exited with an error: error: none of the selected packages contains these features: chrono

The complaint I have is that the "failed to run" command runs perfectly fine if you try to do it manually. I'm guessing the real command contains a "--features chrono" or something like that, but for some reason, that part isn't included in the provided "failed to run" command, so when you try to run it yourself, you don't get an error, just confusion.

The error message is created here:
https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/project_model/src/cargo_workspace.rs#L290
We should probably debug format the executed command here instead

This will become much easier once rust 1.57 releases that stabilizes command_access. This will let us use https://docs.rs/cargo_metadata/0.14.1/cargo_metadata/struct.MetadataCommand.html#method.cargo_command + https://doc.rust-lang.org/std/process/struct.Command.html#method.get_args to print the actual command ran.

This will become much easier once rust 1.57 releases that stabilizes command_access.

FWIW, that happened today.


Fixed infinite stream of Vault leader detection events

What does this PR do?
Fix Vault leader detection.
Motivation
When the Vault leader changes, Datadog agent sends an infinite stream of "leader change" events. This is because the script does not keep update self._previous_leader upon change of the leader.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

/azp run

Thanks a lot for your contribution @fabienrenaud!


PT-1573 | fix study level grade translations, e.g. "3rd class"

Description :sparkles:
fix: fix study level grade translations, e.g. "3rd class"
NOTE: There is TECHNICAL DEBT:

The ordinal number translations could be done using i18next but that would require at least v21.0.0 of i18next which is a major breaking release.
Without upgrading to at least v21.0.0 i18next just using a hardcoded support for translating ordinal study level grades with keys:

grade1 for study level grade 1
grade2 for study level grade 2
grade3   for study level grade 3
grade_with_count for study level grades > 3

refs PT-1573
Issues :bug:
Closes :no_good_woman:
PT-1573
Related :handshake:
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Study level grade translations (Finnish/English/Swedish):

Additional notes :spiral_notepad:

Codecov Report

Merging #266 (f288cfb) into master (16790e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   81.49%   81.49%
=======================================
  Files         116      116
  Lines        2416     2416
  Branches      821      821
=======================================
  Hits         1969     1969
  Misses        441      441
  Partials        6        6

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kultus-ui branch is deployed to platta: https://kultus-ui-pr266.dev.hel.ninja :rocket::rocket::rocket:


docs/qvm-qpu-cleanup

This PR cleans up a lot of the documentation on using the QVM and the QPU. From the commit messages:

Removed all but one qvm.run command from basics section, referring the user to the qvm section for more detail on program execution on the qvm.
Folded in all content on the .run method to the qvm section, plus moving example code and actual program execution up as close to the top of the page as possible. The sooner a user can execute code the better.
created two clarifying sections in the qvm docs on the .run method vs the .wavefunction method.
On the qpu page, moved code examples as close to the top of the page as possible, and included clarifying content on get_devices, etc.
Renamed all three endpoint sections for consistency & clarity (The Quantum Virtual Machine (QVM), The Quantum Processing Unit (QPU), The Quil Compiler)

There is still quite a bit of room for improvements in these docs, but this is a start.

Looks good to me


Save event text to local storage

WHEN I click the save button for that timeblock
THEN the text for that event is saved in local storage

event listener created for the save button to save event to local storage