android: Set launchMode="singleTask" instead of "singleTop"

This addresses #620 by making it so the whole app state isn't reset when coming back from Firefox in the web-auth flow. Discussion:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/Flutter.20app.20.2B.20SAML.20auth/near/1776828
Later in that discussion, Greg found that this mode is the most appropriate for our app, and that setting taskAffinity="" is probably a good idea as a security-hardening measure.
Fixes: #620

Thanks for debugging and fixing this!
Let's make this two commits: first taskAffinity, which is an independent hardening measure, then launchMode. Otherwise all LGTM.

Cool; done, PTAL.

Thanks! Looks good; merging, with two commit-message tweaks. One is a minor formatting change to make a paragraph wrap better, and the other a small correction or clarification:
$ git range-diff --creation-factor=90 origin pr/639 @
1:  7588b5a47 ! 1:  138b1e28b android: Set taskAffinity=""
    @@ Commit message
         android: Set taskAffinity=""

         This looks like a security-hardening measure that would be good to
    -    do, independently of the upcoming change to
    -    `launchMode="singleTask"`. Discussion:
    +    do, independently of the upcoming change to launchMode="singleTask".
    +    Discussion:
           https://chat.zulip.org/#narrow/stream/48-mobile/topic/Flutter.20app.20.2B.20SAML.20auth/near/1790071

      ## android/app/src/main/AndroidManifest.xml ##
2:  1e9a27d1f ! 2:  1251a0b06 android: Set launchMode="singleTask" instead of "singleTop"
    @@ Commit message
         when coming back from Firefox in the web-auth flow. Discussion:
           https://chat.zulip.org/#narrow/stream/48-mobile/topic/Flutter.20app.20.2B.20SAML.20auth/near/1776828
         Later in that discussion, Greg found that this mode is the most
    -    appropriate for our app.
    +    appropriate for the main activity of our app:
    +      https://chat.zulip.org/#narrow/stream/48-mobile/topic/Flutter.20app.20.2B.20SAML.20auth/near/1790019

         Fixes: #620

In particular the key about singleTask is that it's appropriate for the "main" or "root" activity of an app. We have some ancillary activities in our merged manifest, like this one (which I guess would get used if we passed [LaunchMode.inAppWebView] to launchUrl):
        <activity
            android:theme="@ref/0x1030007"
            android:name="io.flutter.plugins.urllauncher.WebViewActivity"
            android:exported="false" />

and those wouldn't be appropriate for android:launchMode="singleTask".

I see; interesting. Thanks!


[Feature Request] Curved UI/HUD

There should be able to be a way to set curved opt-in parameter for text, surface, photo and video panels. Not only for following the user, but for a more comfortable reading experience. This should be  an option so we can still create surfaces that look like they are attached to a wall or something. I'm talking about HUD or floating UI.

Hi @SebaSOFT thanks for the feature request. We have added this to our backlog and will update this issue once we have more information regarding release.
Here are some interim options that might meet your needs:

To have a flat object face the user, you can also use Transform Behavior constraints:
https://developer.viromedia.com/virocore/reference/com/viro/core/Node.TransformBehavior.html
Using a 3D asset that is curved and flat and then using a texture or material on top of that. Not ideal but perhaps a short term work around, particularly with the TV example.


Design tweaks

Description of issue
Here is a list of design issues to provide consistency with other components in the app:

[ ] Typography of the map/stages component should be consistent with that of the filter events component:

[ ]  Typeface
[ ]  Typeface size
[ ]  Typeface weight
[ ]  Active state
[ ]  Inactive state

[ ]  Style of the map/stages component should be consistent with that of the filter events component:

[ ]  Height
[ ]  Colour

[ ]  Green line of the map/stages component should be consistent with that of the tab bar:

[ ]  Animate in from right to left on focusing to the Parade section
[ ]  Animate between Map and Stages tab when focussing between the two
[ ]  Weight (height)
[ ]  Colour

[ ]  Vertical keyline of the map/stages component should be consistent with that of the filter events component:

[ ]  Weight (width)
[ ]  Colour

I think this is done. @abinocoe can you confirm?


Support pre-existing mipmaps(and only one miplevel)

Hi, I have a opinion about mipmap process #246.
In my opinion to "Support pre-existing mipmaps", need to check miplevel count more than one.
If it has only one miplevel, need to generate mipmap like before.
Also, I reviewed part of KTX2 spec about mipmip levels.

levelCount=1
means that a file contains only the base level and the texture isn’t meant to have other levels...
https://registry.khronos.org/KTX/specs/2.0/ktxspec.v2.html#_levelcount

Thanks.

I created a PR.
https://github.com/CesiumGS/cesium-unity/pull/284
please check this.
Thanks!

Thanks for the PR @tomlee-dev! And for the issue @progsung!
I think that this logic is still not quite right, though.
As mentioned above, in KTX2 there is a distinction made between "this image has no mipmaps, so they should be generated at runtime" and "this image has no mipmaps because it makes no sense to create a mipmap for this type of image." It is, confusingly, encoded in the levelCount property. With levelCount=0, mipmaps should be generated. With levelCount=1, mipmaps make no sense. This distinction corresponds, I think, to whether mipPositions is empty. An empty mipPositions means to go ahead and generate them. A single mipPosition means "don't generate any more."  In other words, the logic here in cesium-unity is already correct and needs no changes.
However, cesium-native is not behaving correctly. It loses this distinction, and will always fill in mipPositions for KTX2 images. So cesium-native should be modified to only fill in mipPositions if levelCount is greater than 0.
However, the KTX2 API that cesium-native is using doesn't expose levelCount at all. Instead, it exposes a numLevels property. That property sounds the same, but it's different in that it will never be 0. Both of our cases above will have a numLevels of 1.  But, when levelCount is 0 in the file, the KTX2 reader will also set the generateMipmaps property to true.
So, in summary, in GltfReader.cpp, cesium-native should only populate mipPositions when pTexture->generateMipmaps is false.

Thanks. I will keep on eyes about it.


Add prompt 'are you sure you want to leave this page without saving your changes?' on moving forward to next

See https://github.com/LibCrowds/libcrowds-viewer/issues/134

We can add in a little warning message now, although this might get annoying if it has to be shown every time!

Removing the option to browse forward should help this!

@alexandermendes this will be redundant if we simplify the model and don't let people move forward.

Yep cool, not sure where the issue for that has gone now but will tackle it here https://github.com/LibCrowds/vue-pybossa-frontend/issues/255
I guess that means we can close this one for now!


aliases

A common use case of aliases is alias ls='ls --color=auto'. How would this be achieved in s?
One way might be to have a local bin folder in $PATH which chainloads the original ls. (try this out)

While I do like and appreciate the simplicity of this design, I do not know how it will work in practice, having multiple files of the same name in a user's $PATH becomes messy.
s$ echo "ls --color=auto" | > ~/bin/ls
s$ echo $PATH
/home/me/bin:/usr/local/bin:/usr/bin:/bin
s$ whereis ls
ls: /bin/ls /home/me/bin/ls /usr/share/man/man1/ls.1.gz
s$ which ls
/bin/ls

Chooses /bin/ls over the alias /home/me/bin/ls, does not work even if ~/bin/ls is at end not beginning of $PATH:
s$ echo $PATH
/usr/local/bin:/usr/bin:/bin:/home/ed/bin
s$ whereis ls
ls: /bin/ls /home/me/bin/ls /usr/share/man/man1/ls.1.gz
s$ which ls
/bin/ls

This method would work really well for functions though since they are used in a similar style to files, while aliases seem more like substitutions. For example func mkcd "mkdir $1 && cd $1" would create a file in ~/bin with mkdir $1 && cd $1
Perhaps aliases could be similar to how builtins work, but instead of a constant array of a builtin struct it can be a linked list contating two strings which gets added to when alias is called and removed when unalias is called.

I think it works if you do chmod +x though.

Forgot about that thanks, but now I am getting the error /bin/sh: error while loading shared libraries: libc.so.6: cannot open shared object file: Error 24 which appears to be the error code for too many open files.
But I still think that this replicates functions more then aliases, in this example you also have to include $* in the alias to list give arugemts since it is a file not a substitution, which is not how other languages implement aliases but how they do functions.

ah, could this be an infinite loop!

Yes I believe ls is now calling itself inside the new file. This is another issue if we are going to use this method for aliases, which often do override other commands.
I have created a quick builtin for func which creates a file in sbin (set to ./sbin/ right now, should probably be in ~/.sbin/ or ~/.config/s/bin/) with the name given and the command inserted into the new file.
$ set PATH $PATH:sbin
$ func la 'ls -a "$@"'
$ la docs
.  ..  GRAMMAR  notes.txt  README  sh.txt  strings.md  TODO  tokens.txt

const char *sbin = "sbin/";

void
builtin_func(char **argv)
{
	FILE *f;
	char path[PATH_MAX];

	if (!argv[1] || !argv[2])
		reportret(,"%s: two arguments required", argv[0]);

	strcat(path, sbin);
	strcat(path, argv[1]);
	if (!(f = fopen(path, "w")))
		reportret(,"%s: %s: could not create file", argv[0], path);

	fputs(argv[2], f);
	fclose(f);
	if (chmod(path, S_IRWXU))
		report("%s: %s: could not chmod: %s", argv[0], path, strerror(errno));
}

Currently it seems the file is being run in sh not s since it does not insert a shebang. What is the correct shebang for s? Maybe set to #!${PREFIX}/bin/s using PREFIX from config.mk? Or maybe have s source it directly to solve this and so sbin does not need to be in $PATH.
alias would simply be a wrapper to this function which also appends "$@" to the end to simulate the alias functionality in other shells.
Note that in the current proposal $@ will need to be added as a variable that expands to all the given arguments to a script ($1, $2, etc). Could this be done without breaking the one token to one token philosophy, I am not sure how else this crucial part in making shell scripts can be implemented other wise. Maybe is something similar to how rc does this by making all variables arrays? This could probability be opened as a new issue, or added to #8.

Would it be possible to implement func as an s script? We should avoid creating new builtins when possible.

Made an issue about $@ https://github.com/rain-1/s/issues/15

What about #!/usr/bin/env s? Then we don't need to get root to install the thing, just add it to PATH?
by the way, I broke comments when I rewrote the tokenizer before so the shebang line was breaking but the latest commit repairs them.

Would it be possible to implement func as an s script?

I would recommend against separating core components of s into dependencies as it would just fragment the code base, especially when they can be integrated as a builtin in under 20 lines of C. Separating it into a supporting file or s script would just over complicate things and add too many unnecessary lines of code. Writing supporting s scripts should be saved for higher level enhancements and wrappers not core features.
I also argue that the >, <, and >> supporting programs should also be integrated directly into s as builtins, especially since they are already in C. Right now unless you install s as a root user they can not be used since they are not in $PATH. This is a problem for a necessary component such as redirects. Putting them into s would allow us to clean up the code better and require less lines, thus simplify the code base. Having certain features in external programs and others not seems to only complicate the code, consolidating code seems like a better approach.

What about #!/usr/bin/env s

Good idea thanks.

I broke comments when I rewrote the tokenizer before so the shebang line was breaking but the latest commit repairs them

Thanks I was wondering why they were not working for me

Couldn't this be done in an config file, for example ~/.s.rc and you declare aliases in there?
Of course this adds the requirement to somehow parse the file, but it seems like the most portable solution to me.

@ng-0 Adding a rc file is defiantly a feature I want to implement, it should be as easily as adding a interpreter_loop() for the file; however, I do not see how this solves the problem of adding aliases since we still have to implement them for it to work in a config file.


Caret height is changes depending on presence/absence of content in the paragraph node

Steps to reproduce:

Run super_editor's demo app on macOS
Go to "DOC COMPONENTS / Text with hint"
Place the caret on one of the paragraphs
Add a character

Expected: height of the caret remains the same
Actual: height changes
https://user-images.githubusercontent.com/31278849/141997856-7c3f1ce0-1fdd-449b-9ef3-96dad8a60c60.mov
Note: on web I could not reproduce the issue.

I filed a ticket with Flutter related to this: https://github.com/flutter/flutter/issues/107196


There is MySQL compatibility?

Hi, i have an issue with MySQL in Update method. When i do the following:
context
.Template
.Where(h => h.IdTemplate == templateHistorialEntity.IdTemplate)
.Update(h => new TemplateHistorial() {EstaVigente = false});
I get an mysql exception. The query generated is:
UPDATE [databaseName].[TemplateHistorial] SET
[EstaVigente] = 0
FROM [databaseName].[TemplateHistorial] AS j0 INNER JOIN (
[Extent1].[IdTemplateHistorial]
FROM [TemplateHistorial] AS [Extent1]
WHERE [Extent1].[IdTemplate] = 3
) AS j1 ON (j0.[IdTemplateHistorial] = j1.[IdTemplateHistorial])
And as i know, mysql does not support the '[' char. Instead, it use '`' char. And more important, if i replace all bracket, the query still return an error.
So, mysql is supported?
Regards!

Ok, i clone this project in my machine and i see this:
private static IBatchRunner ResolveRunner()
{
var provider = Locator.Current.Resolve();
if (provider == null)
throw new InvalidOperationException("Could not resolve the IBatchRunner. Make sure IBatchRunner is registered in the Locator.Current container.");
        return provider;
    }

when i replace IBatchRunner for MySqlBatchRunner, it work as espected. So, i have another question, how can i parameterized the specific batch runner without have to recompile the project? There is a parameter in .config file?
Thanks!

@jerronwong nice comment, but I'd like suggest simpler approach. I.e. from my viewpoint.
There is an option to configure entity framework via DbConfiguration class. More info here https://msdn.microsoft.com/en-us/data/jj680699.aspx
And here my code:
    public class DbContextConfiguration : DbConfiguration
    {
        public DbContextConfiguration()
        {
            EntityFramework.Locator.Current.Register<EntityFramework.Batch.IBatchRunner>(() => new MySqlBatchRunner());
        }
    }

But that is broken. I had to create my own fork and fix it
https://github.com/OpenCST/EntityFramework.Extended/blob/master/Source/EntityFramework.Extended/Batch/MySqlBatchRunner.cs
My fork contains correct escaping for backticks AND omits references to dbo


Add exception checking for primitives in the 'call_method_unsafe'

Closes #35.

@dmitry-timofeev Result is needed because of non_null! macro - it can return error. Although I'm not sure that argument must be checked at all.

It doesn't care - all it does is skip the null check after the exception check. It can be used for references that we know are never going to be null, but methods returning primitives were the original use case for it IIRC.


Feat: add dedicated supplemental conditions of service page

The type of this PR is: Feat

This PR solves PHIRE-724
Description

This PR adds a new sale agreements app, which replaces the current way of displaying conditions of sale.
This complete work started in the hackathon to improve the business process for managing an individual sale's legal terms. Currently, we manage these in a big markdown file via Forque's pages editor displayed https://www.artsy.net/conditions-of-sale and https://www.artsy.net/page/conditions-of-sale-archive. This process no longer meets our legal requirements.
Considerations

This needs to be sequenced with related changes, so I will likely be putting behind a feature flag before releasing. To be confirmed with the relevant teams. I will leave in Draft status until its ready to be merged.

Related PR(s)

https://github.com/artsy/gravity/pull/17535
https://github.com/artsy/metaphysics/pull/5642
https://github.com/artsy/forque/pull/1131

Review App
https://new-cos.artsy.net/supplemental-cos
Screenshots

Warnings

:warning:

Routes added to routes.tsx should have a corresponding cypress.js smoke test. See the cypress/e2e folder for examples.

  Generated by :no_entry_sign: dangerJS against 07d5c46ea9c41ca202fe1d58b08ecc1ea7791af6


[DOCFIX] Update Tired Locality docs

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10251/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.3 please


Application insights connection string changed

We are creating all our infrastructure using terraform. The first thing we create in an environment is the monitoring tools, including application insights.
We then create function apps, referencing the application insights connection string:
data "azurerm_application_insights" "application_insights" {
  name                = local.application_insights_name
  resource_group_name = data.azurerm_resource_group.resource_group.name
}

resource "azurerm_function_app" "function_app" {
  app_settings = {
    APPLICATIONINSIGHTS_CONNECTION_STRING = data.azurerm_application_insights.application_insights.connection_string
  }
}

However as you can imagine we don't do this very often, and now I see a diff between the environment variable in our application insights variable and what the actual connection string in application insights is:
Our function app:  InstrumentationKey=my-instrumentation-key;IngestionEndpoint=https://westeurope-1.in.applicationinsights.azure.com/
Our application insights instance:  InstrumentationKey=my-instrumentation-key;IngestionEndpoint=https://westeurope-4.in.applicationinsights.azure.com/
Notice the difference in ingestion point.
We have changed nothing in our monitoring infrastructure, the activity log for the application insights workspace does not display anything that might have caused this, and I can't see that the connection string in application insights is subject to change.
What might have happened here? Is this a scenario we need to take into account and update our function apps with new application insights connection strings?
Edit:
This might also be relevant. This is how we report custom events from our functions. We use the applicationinsights package.
new ApplicationInsightsService(new TelemetryClient(`${process.env.APPLICATIONINSIGHTS_CONNECTION_STRING}`), logger).trackEvent(...)

private trackEvent(name: string, properties: { [key:string] : any }) {
    this._client.trackEvent({
        name: name,
        properties: properties
    })
    this._client.flush()
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 180c6ca8-2bdc-4685-ebc5-aaea2236937f
Version Independent ID: 74f63340-7428-a3a7-6d6c-701d3be4348d
Content: Connection strings in Azure Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/sdk-connection-string.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @TimothyMothra
Microsoft Alias: tilee

Thanks for the feedback! We are currently investigating and will update you shortly.

@jokarl My sincere apologies for delay in getting back to this thread. The issue you are experiencing needs some additional troubleshooting and can be better assisted by our support team. If you have support plan please create a support ticket. If not, please send an email to<EMAIL_ADDRESS>with your Subscription details and a link to this thread so we can verify and direct the request accordingly .  We'll continue to investigate this with you directly and will update the thread with any findings that may help others. Thank you
Please note that this channel (the Azure Docs repository) is only for driving improvements related to the Azure documentation. At this point it appears that there's no further edits or updates needed to the documentation. We will go ahead and close this issue, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


Fix: Unable to set delete and close button images without setting size.

The way the guard let statements are currently used, we can't omit the size parameter when calling
updateCloseButton(_ image: UIImage, size: CGSize? = nil)  and updateDeleteButton(_ image: UIImage, size: CGSize? = nil) methods via an instance of SKPhotoBrowser even though the size parameter is optional.
The above methods delegate to calling actionView.updateCloseButton(image:, size:) and
actionView.updateDeleteButton(image:, size:) internally which also delgate to calling configureCloseButton(image:, size:) and configureDeleteButton(image:, size:) which is where the parameters are used with a guard let check.
This PR fixes this issue.

Thank you for your help!


docs: Fix some entries about user inivitations in changelog.

This item was not accurate.

Merged, thanks @mateuszmandera!


Add support for BENTHOS_CONFIG_PATH to benthos-lambda distribution

Adds support for customizing the file path where benthos-lambda looks for configuration when BENTHOS_CONFIG is not defined using a new BENTHOS_CONFIG_PATH environment variable

Looks great @cludden, bonus thanks for updating the docs ❤


EDGE_ID not visible via API if a new environment wa created via an api call

When I create a new edge agent environment via the 2.15.1 portainer api (POST /api/endpoints), the environment get's created, but it does not have the EdgeID visible via the API. The EDGE_ID is though visible via the WebUI. After the agent has connected, the EdgeID is visible.
Is there any particular rason for this behaviour?
To reproduce:

Create an enviroment with the api /api/endpoints with the following headers: Name="foo", EndpointCreationType="4" and URL=PORTAINER_URL
Check the details with /api/endpoints/ID. EdgeKey is there, but EdgeID is missing.
Check the details of the environment via the WebUI. The environment has an existing EdgeID

I found a solution to this issue. I was mentioned here: https://github.com/portainer/portainer/issues/6947#issuecomment-1129505374. Would be nice to have this as an option in the api-call itself
I close this issue


Stuck on Verifying...

This example from dafny-lang/dafny#1718 is stuck on Verifying... for me on my Mac. This is true for both the 3.3 release version, as well as a fairy recent master, of both dafny and the plugin.
trait Group<T(==)> {
  function op(a: T, b: T): (c: T)
  function e(): T

  lemma lemma_e(a: T)
    ensures op(e(), a) == a == op(a, e())
}

class TestGroup extends Group<int> {
  function op(a: int, b: int): (c: int) { a + b }
  function e(): int { 0 }

  lemma lemma_e(a: int)
    ensures op(e(), a) == a == op(a, e())
  {}
}

I believe this happens because the language server encounters an error it's not prepared to handle and therefore doesn't respond to the client. This PR fixes a similar situation, but does so by adding exception handlers for specific types of errors. I suspect we may need to add something to respond specifically to internal translation errors.

Would we move it back to dafny-lang/dafny?

It works for me on Windows+master:

Works for me too on WIndows+master. Would you mind sharing the stacktrace? You may find it within the installation dir of the language server with a name like DafnyLanguageServer*.log. Alternatively, you can enable VSCode's language server logging, which should print errors to the respective output window. In your settings.json, at the following entry to the root object:
"dafny-vscode.trace.server": "verbose"

``
[22:02:12 WRN OmniSharp.Extensions.LanguageServer.Server.Configuration.DidChangeConfigurationProvider] No ConfigurationItems have been defined, configuration won't surface any configuration from the client!
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.Symbols.SymbolTableFactory] could not resolve the symbol of designator named T in GH1718.dfy@(2,32)
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.Symbols.SymbolTableFactory] could not resolve the symbol of designator named T in GH1718.dfy@(2,18)
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.Symbols.SymbolTableFactory] could not resolve the symbol of designator named T in GH1718.dfy@(2,24)
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.Symbols.SymbolTableFactory] could not resolve the symbol of designator named T in GH1718.dfy@(3,17)
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.Symbols.SymbolTableFactory] could not resolve the symbol of designator named T in GH1718.dfy@(5,20)
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier]
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier]
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier]
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier]
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier] Verifying OverrideCheck$$_module.TestGroup.op ...
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier] Verifying OverrideCheck$$_module.TestGroup.lemma__e ...
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier] Verifying Impl$$_module.TestGroup.lemma__e ...
[22:02:13 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier] Verifying OverrideCheck$$_module.TestGroup.e ...
[22:02:14 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier] verified
[22:02:14 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier] verified
[22:02:14 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier] verified
[22:02:14 INF Microsoft.Dafny.LanguageServer.Language.DafnyProgramVerifier] error

Nothing suspicious in this log. Do the other IDE/code interactions, such as code suggestions and jump to definition, stop working once you're stuck on Verifying...?

Closing as it might have been fixed with all the work done last summer. Happy to reopen if it persists


test data not working for prediction

Hi, I am trying to use the test data from the package and perform prediction but ran into this error -

data <- melonnpan.test.data
test <- melonnpan.predict(data)
Error in melonnpan.predict(data) :
All measurements should be normalized to proportions.

sessionInfo()
R version 3.5.3 (2019-03-11)
Platform: x86_64-apple-darwin15.6.0 (64-bit)
Running under: macOS Mojave 10.14.4
Matrix products: default
BLAS: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/3.5/Resources/lib/libRlapack.dylib
locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8
attached base packages:
[1] parallel  stats     graphics  grDevices utils     datasets  methods   base
other attached packages:
[1] melonnpan_0.99.0    GenABEL_1.8-0       GenABEL.data_1.0.0  MASS_7.3-51.4
[5] optparse_1.6.2      AssocTests_0.0-4    fExtremes_3042.82   fGarch_3042.83.1
[9] fBasics_3042.89     timeSeries_3042.102 timeDate_3043.102   combinat_0.0-8
[13] mvtnorm_1.0-11      cluster_2.1.0       ggplot2_3.2.0       data.table_1.12.2
[17] vegan_2.5-5         lattice_0.20-38     permute_0.9-5       doParallel_1.0.14
[21] iterators_1.0.10    getopt_1.20.3       glmnet_2.0-18       foreach_1.4.4
[25] Matrix_1.2-17
loaded via a namespace (and not attached):
[1] Rcpp_1.0.1       compiler_3.5.3   pillar_1.4.2     tools_3.5.3      tibble_2.1.3
[6] gtable_0.3.0     nlme_3.1-140     mgcv_1.8-28      pkgconfig_2.0.2  rlang_0.4.0
[11] rstudioapi_0.10  yaml_2.2.0       withr_2.1.2      dplyr_0.8.1      grid_3.5.3
[16] tidyselect_0.2.5 glue_1.3.1       R6_2.4.0         spatial_7.3-11   purrr_0.3.2
[21] magrittr_1.5     scales_1.0.0     codetools_0.2-16 splines_3.5.3    assertthat_0.2.1
[26] colorspace_1.4-1 lazyeval_0.2.2   munsell_0.5.0    crayon_1.3.4

Hey @EllieYin567 - I just fixed a typo in the code which should resolve the issue on your end. You also need to specify a path to the output file in the above function call. Let me know if it works now.

hi @himelmallick - thank you for fixing the bug and it is working now.


[ci skip] adding user @claytonparnell

Hi! This is the friendly automated conda-forge-webservice.
I've added user @claytonparnell as instructed in #36.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #36

@conda-forge-admin, please restart ci


test: add _cpp suffix to test data generated using C++ SDK.

Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jplevyak yeah, but then you'll end-up with conflict because of:

logging.cc -> logging.wasm,
logging.rs -> logging.wasm.

Well, don't do that :)  I am fine with doing this, I just wanted to point out that it wasn't necessary.
Feel free to merge.

I wanted to say "this only affects tests", but I've just realized that I modified the Makefile in SDK, which it indeed shouldn't be necessary. Let me fix that.

@jplevyak Fixed, PTAL.


postgresqlPackages.pgvecto-rs: 0.2.1 -> 0.3.0

Description of changes
https://github.com/tensorchord/pgvecto.rs/releases/tag/v0.3.0
However, this needs rustc 1.79, so it's failing to build.
Waiting for https://github.com/NixOS/nixpkgs/pull/320250
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This looks good, feel free to ping me again when 1.79 lands on master

Now that 1.79 is in, this should be good to go.
Do you have time to do a quick nixpkgs-review or local test by any chance ?

@happysalada I was waiting for it to be available in master, but I can rebase it on staging if you prefer

You are completely right here, lets wait for it to land on master its just easier.

Rust 1.79 seems to already be in master, but perhaps we should only merge this after Immich supports 0.3.0?
See https://github.com/immich-app/immich/discussions/11091
Especially relevant since https://github.com/NixOS/nixpkgs/pull/324127 requires this package.

I've rebased this on master and it builds now. I had to do a small change to buildPgrxExtension since upstream removed the pg_test feature from their crate.

The PR looks good but youre right we should probably wait for immich support before merging.
Small thing, it looks like there are merge conflicts with master. Youll need to rebase at some point.

Immich will support pgvecto-rs 0.3.0 in the next release: https://github.com/immich-app/immich/pull/11624

https://github.com/immich-app/immich/releases/tag/v1.112.0
Immich 1.112.0 released with support for this. Marking as ready

Should we wait until the updated of immich gets merged ?

Should we wait until the updated of immich gets merged ?

That seems reasonable to me.


ConnPool does not implement Queryable anymore

Codecov Report

Merging #12 into master will decrease coverage by 0.41%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   83.54%   83.12%   -0.42%
==========================================
  Files           4        4
  Lines         237      243       +6
==========================================
+ Hits          198      202       +4
- Misses         29       30       +1
- Partials       10       11       +1

Impacted Files
Coverage Δ

gue.go
87.00% <71.42%> (-1.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796a387...8e2e79d. Read the comment docs.


Auto-polyfill on import

How about automatically running the .polyfill() function when importing a slightly modified version (similar to es6-promise is doing it)?
require('es6-object-assign/auto');

import 'es6-object-assign/auto';

Published as version 1.1.0 ;)


Cannot start completely

Hello,
I encountered a problem to start this plugin, after a successful built of the latest version.

OK, I will try to set up every variable in the example. Anyway, is there any recommendation what to set up for pwd?
Is there any documentation what that variable's purpose? :slightly_smiling_face: (I know the docker documentation but I do not know how to set up completely for this container.)

You can check the config section in the docs to see what is configurable. The environment variable names related to these config settings are simply PLUGIN_{config}. There are other Drone related environment variables that are used, but these aren't documented. If you really want to know what is used, you can simply check the code.
Generally, pwd is set to the project (repository) root. If I'm not mistaken it's only used to resolve a custom email template path (if used).


linux/arm64 docker images missing on Docker Hub

Is there any reason why you're not publishing linux/arm64 images to Docker Hub? I was able to successfully build all the ones I needed locally, so I assume they work just fine?

Yeah it's built just fine, but since building Docker images for arm64 on an x86 machine requires emulation, the build is extremely slow. On my local machine it took upward of 1.5 hours, which means it will be even slower on the GitHub action runners. That's why I haven't added it yet, as it will slow down the CI significantly.
Maybe we should use an external CI provider for that? I'm not sure yet.

One more thing comes to mind: why do you rebuild nss, brotli, nghttp2, etc? Wouldn't apt source curl, apt install build-essentials curl, patch, debuild approach work better? This way you could keep the compilation to the minimum and end up with a clean image?
And, with that in mind, have you considered setting up a deb repository? I realize this is extra work, but vastly simplifies the usage of the project.

One more thing comes to mind: why do you rebuild nss, brotli, nghttp2, etc when building a docker file

nss is always built statically into curl-impersonate to ensure that the TLS signature is the expected one. If the binary is  used on another system with a different nss version, I can't ensure the TLS signature will be the same. It used to be my thinking with respect to brotli & nghttp2 as well, though I now less believe there is a room for errors if a different versions of these libraries is used. So I might in the future just link them dynamically as you suggested. Their build times are insignificant (as compared to nss for example) so I didn't put the time in to change it yet.

And, with that in mind, have you considered setting up a deb repository? I realize this is extra work, but it vastly simplifies the usage from the user's perspective :)

Yes, I hope to have rpm & deb set up in the future. As always, any help with that regard will be highly appreciated.


Renaming default branch

See https://github.com/fortran-lang/fpm/issues/421 for details.
Please collect references in @fortran-lang projects to files inside this repository such that we can fix those links after renaming.

There are no references to the default branch in the repository, therefore I'll go ahead and make the required change in the settings.


chore: update to leatest argocd-operator for 1.14 release

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

CRDs need to be updated here: https://github.com/redhat-developer/gitops-operator/tree/master/config/crd/bases.
Copy all the CRDs except argocdexports from https://github.com/argoproj-labs/argocd-operator/tree/v0.12.0-rc1/config/crd/bases.
@jgwest - Do rollout CRDs need update or they are latest of the required version?

/retest-required

Test also needs an update: https://github.com/redhat-developer/gitops-operator/blob/37dcfecd9e3231e4d12ab55ebd954b19870b1b97/test/openshift/e2e/parallel/1-031_validate_toolchain/01-check.yaml#L8-L11

/test v4.14-kuttl-parallel

/test v4.14-kuttl-parallel

/lgtm

/approve


Issue/67

Coverage increased (+0.08%) to 92.152% when pulling d3d34be1676c932b7ef3ef9caaf377cae1420144 on issue/67 into 1559733b03f505a589c0e2758114bfc374be861c on master.


Add final_stage_user

Codecov Report

Merging #34 (50e0809) into master (0124f59) will decrease coverage by 1.72%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   78.74%   77.02%   -1.73%
==========================================
  Files          10       11       +1
  Lines         207      235      +28
  Branches       25       31       +6
==========================================
+ Hits          163      181      +18
- Misses         44       51       +7
- Partials        0        3       +3

Impacted Files
Coverage Δ

validator/__main__.py
0.00% <0.00%> (ø)

validator/schema/modification_schema.py
100.00% <ø> (ø)

validator/support.py
90.00% <33.33%> (-10.00%)
:arrow_down:

validator/global_session.py
63.63% <63.63%> (ø)

validator/exceptions.py
100.00% <100.00%> (ø)

validator/github.py
100.00% <100.00%> (ø)

validator/schema/image_schema.py
94.11% <100.00%> (-5.89%)
:arrow_down:

validator/schema/rpm_schema.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c097e...50e0809. Read the comment docs.

Thanks.
/lgtm


chore: Extract common select component code

Recently in the ongoing effort to clean up the select component, it was split into Sync and Async components. After splitting they shared alot of common code. This PR is to move some of the shared code into a new common file that each of the components can import from in order to better reuse code.
Overall task is outlined here: https://github.com/apache/superset/pull/20143

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ x ] Has associated issue: https://github.com/apache/superset/pull/20143
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Hi @cccs-RyanK. Thanks for this! Before I dive into the code I have a general comment.
I am not very fond of the idea of having constants, types and common components all within a common file. If we are opting for separation then I believe it makes sense to separate things a bit more.
I'd prefer to see a structure similar to this one:

types.ts: Containing all the shared types
utils.ts: Containing shared functions and constants
BaseSelect.tsx: containing the shared component
This is optional, but we could also have a styles.ts for the common styled components

@michael-s-molina what's your thought about this?

Hi @cccs-RyanK. Thanks for this! Before I dive into the code I have a general comment. I am not very fond of the idea of having constants, types and common components all within a common file. If we are opting for separation then I believe it makes sense to separate things a bit more.
I'd prefer to see a structure similar to this one:

types.ts: Containing all the shared types
utils.ts: Containing shared functions and constants
BaseSelect.tsx: containing the shared component
This is optional, but we could also have a styles.ts for the common styled components

@michael-s-molina what's your thought about this?

What I generally do is to keep things in context and depending on the size of things, break them into related submodules. One thing I don't like is mixing things that belong to different components. For example, I don't like to have a types.ts that contains all sync and async types because they are not shared. When things get bigger, and I have many types or styled-components, then I generally create your suggested structure but under each component folder like this:
AsyncSelect
  types.ts
  styles.ts
  test.ts
  index.ts
Select
  types.ts
  styles.ts
  test.ts
  index.ts
utils.ts (shared)

If I have a few types or styled-components, I generally define them in the component.

AsyncSelect
  types.ts
  styles.ts
  test.ts
  index.ts
Select
  types.ts
  styles.ts
  test.ts
  index.ts
utils.ts (shared)
types.ts (shared)

If I have a few types or styled-components, I generally define them in the component.

This makes sense but I still believe we should not have all the shared parts under one utils file even though this is not very big. For instance, I don't see why styles should be under utils.

This makes sense but I still believe we should not have all the shared parts under one utils file even though this is not very big. For instance, I don't see why styles should be under utils.

Maybe I was not clear but in my example styles would never be under utils. It would belong to the component file if we have a few of them, or to a styles submodule if we have many. So I think we're in agreement.


error with third-party vue component

hi, there's a problem i hit when i try to run my test files with Jest,
/home/link/satiVersion2/dataexa-sati-workbench/node_modules/_vue-echarts@3.0.5@vue-echarts/components/ECharts.vue:1
({"Object.":function(module,exports,require,__dirname,__filename,global,jest){
^
SyntaxError: Unexpected token <
that's how i import them:
import ECharts from 'vue-echarts/components/ECharts.vue'
import 'echarts/lib/chart/bar'
it's untranspiled, i change my jest config like this:
transformIgnorePatterns: [
"/node_modules/(?!vue-echarts|echarts)"
],
but i still doesn't work , please help me?

Hi @constantank, maybe you need to adjust https://facebook.github.io/jest/docs/en/configuration.html#modulefileextensions-array-string ?
Anyway, I'm closing this, because it doesn't conform to our issue template.


Add support to Socket.io

Expected Behavior
Insomnia should be able to connect to socket io server
Actual Behavior
While connecting to socketio simple server made using nodejs and express with socket io with an address ws://locahost:8000/chat, when i try to connect , i get a message of socket hang up. The same server works on postman
Reproduction Steps
Make a simple socket io server
Try to connect with the socket io server
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
latest
What operating system are you using?
Ubuntu
Operating System Version
latest
Installation method
download from
Last Known Working Insomnia version
No response

@rubiin thanks for reporting this. What @Warmachine13 mentioned is the current status - we do not support socket.io at the moment. I've tried it myself a few days ago and even though socket.io uses websockets, we need some extra work to make it compatible.

Please socket.io should be added and hoping it can work locally due to network concerns most times

+1 for this one
Please socket.io

socket.io support would be very useful. It would be nice if this finds away into insomnia

I would be suggesting the socket.io support be available offline also because of countries or regions that do experience network issues

hi, there some way to connect and comunicate with socket.io and insomnia ? i have a nestjs project and i'll trying to connect and test it, but i can't

+1 for this

+1

+1

+1 for this one

+1 for this one
waiting for the postman

+1 for this one
Please socket.io

+1 for this one
waiting for the socket.io

+1

+1

+1

Waiting for this as well. It's frustrating to use different client just for one thing that's not covered by Insomnia 😭

Since pre-request scripts is on beta, this one is the only reason left for me to use Postman, it will be awesome to have this feature 🙏🏻

+1 for this one
waiting for the socket.io

+1

+1

+1

+1

+1 waiting for socket.io support

+1, now so many applications are using socketio to support GPT stream

+1 waiting for socket.io support

No socket io support ? Fine, uninstall Insomnia, welcome Postman

+1, i moved to insomnia from postman due to security issues, but i can connect to my socket.io service :/

+1

+1

+1
Please!

+1

+1.


Rework data storing

Rewrite how students are stored to match the given task in README. Students are directly read into the tree, and if hash collission is found, then stored in a linked-list.

the code must deal with the collisions.

one (1) point is given for the correctly implemented project which correctly recognizes the hash collision case but does handle it by just issuing a warning on s duplicate key for a different value.

two (2) points are given for the correctly implemented project which correctly recognizes the hash collision case and does handle it by implementing a chain per tree node in a form of an appropriate linked list.


Support saving packed scene's metadata

Fixes #76366
This is the initial version, I guess it can be improved a lot. Maybe we can merge some metadata saving code shared between common resource and packedscene, or just leave it like this is fine.
Also there might still many corner cases I did not test. I would appreciate any feedback or alternative suggestions.

Tested locally, it works as expected:
[gd_scene format=3]

[node name="Node3D" type="Node3D"]
metadata/test = 1111

However, I don't see the metadata in the root node of the scene in the editor after clicking Reload in the dialog that appears, even if I close and reopen the scene:

Even restarting the editor entirely won't make it show up. What's worse is that saving the scene in the editor will cause you to lose the metadata :slightly_frowning_face:

Thanks for the testing! I will try to reproduce and fix it!


#1 performOps refactor

iterating over white list and parsing each operation instead of creating all possible combinations.

Solves Issue: #1


How do I user container.seek

IMPORTANT: Be sure to fill in all applicable sections {{ in braces }} or your issue may be discarded.
Overview
{{ I call listOfFrames = container.decode(stream), container.seek(int(relativeTimeStamp)), frame = listOfFrames.next(), and I am not getting the next frame.}}
Expected behavior
{{ frame would contain the frame (more or less) at the time seeked to }}
Actual behavior
{{ frame contains the first frame of the video }}
Traceback:
{{ Include complete tracebacks if there are any exceptions. }}

Investigation
{{ Seeking multiple times, calling next a couple times, hardcoding values into seek, and a few more that I've forgotten now. }}
Research
I have done the following:

[x] Checked the PyAV documentation
[x] Searched on Google
[x] Searched on Stack Overflow
[x] Looked through old GitHub issues
[x] Asked on PyAV Gitter
[ ] ... and waited 72 hours for a response.

Additional context
{{ I apologise if this is a dumb question, I'm new to python.}}

I'm closing this in favour of the Gitter conversation OR the previous issue.


[bug] sg scan -U fails because of leading and trailing empty lines

Hello, this is a follow-up on #580, thanks a lot for having implemented it!
⏯ Playground Link

The issue doesn't appear in the playground: link
💻 Code

This uses the same code and rules as in this section of the docs.
Code (it is important that there's an empty line at the beginning and at the end):

def foo(x):
    return x + 1

y = foo(2)
print(y)

Pattern:
id: change_def
language: Python
rule:
  pattern: |
    def foo($X):
      $$$S
fix: |-
  def baz($X):
    $$$S

--- # this is YAML doc separator to have multiple rules in one file

id: change_param
rule:
  pattern: foo($X)
fix: baz($X)

🙁 Actual behavior

Running sg scan -U deletes the leading and trailing empty lines and returns this:
dedef baz(x):
  return x + 1

y = fobaz(2)print(y)

🙂 Expected behavior

The result should be as in the docs and shouldn't depend on whether there are empty lines at the beginning or at the end.

Thanks for the reporting!
However, I followed this on ast-grep 0.12.4 with the command sg scan -U -r change.yml test.py.
I cannot reproduce the issue. Would you like to use the sg scan -r xxx.yml command? Thanks

I ran sg scan -U -r xxx.yml and sg scan -U -r xxx.yml test.py and the same bug appears in both cases. also have ast-grep 0.12.4.
However, removing -U shows that the detection is fine:
> sg scan -r inst/rules/rules.yml
.\test.py
help[change_def]:
@@ -0,6 +0,6 @@
1 1│
2  │-def foo(x):
3  │-    return x + 1
  2│+def baz(x):
  3│+  return x + 1
4 4│
5 5│
6 6│ y = foo(2)
.\test.py
help[change_param]:
@@ -2,5 +2,5 @@
3 3│     return x + 1
4 4│
5 5│
6  │-y = foo(2)
  6│+y = baz(2)
7 7│ print(y)

I still cannot reproduce it.

Are you on windows?

I am on windows but in your screenshot I don't see any empty line at the beginning of the python file. The bug appears when there are empty lines at the beginning and the end of the file.

Oh thanks!  I can reproduce it!

Thanks! I have identified the problem. Will fix it soon!
The problem is that leading whitespaces are not considered as source code in AST node.
But the AST offset does count these whitespaces. The difference in offset makes the wrong string.

Shipped in 0.12.5!

Awesome, thanks a lot for the quick fix!


Unread-events get marked as seen depending on routes visited.

While debugging/testing for #732 I noticed that the unread-counters weren't decreased. This patch should fix that. The event-reducer looks at the route currently displayed and marks all events belonging to displayed connections as seen.

does not count down matches when I click the matches tab. (may be ok)
does not count down matches when I decline a match (but I feel it should)
does not count down messages for a need when I open the conversation view
counts messages up while I receive them in the conversation view
does not count down requests when I click 'requests' and accept a request.

needs merging now


Status follow and unfollow functions using incorrect param

See line https://github.com/heroiclabs/nakama-defold/blob/master/codegen/main.go#L201 and https://github.com/heroiclabs/nakama-defold/blob/master/codegen/main.go#L213
The functions take user_id as a param and use user_ids in their logic.

Well spotted! Thanks.


New trace types incoming: funnel and funnelarea

funnel is a lot like bar and funnelarea is a lot like pie. Both should be quite easy to add support for.
@angeladaodao we will need icons for both please. Ask @archmoj to provide sample graphics for what they each look like.

Here is a codepen.

LMK if this looks alright to you guys.

Funnel looks great, funnelarea i think uses too many shades? But otherwise is awesome.  I can’t remember offhand how many shades we currently use in the trace selector.
We’ll also need the smaller one-color ones too please.

No problem! Will fix and do the one colour too

any suggestions on this?

Perfect, you rock @angeladaodao ! Please provide the SVGs to @VeraZab as per usual process and she can roll them into the icons repo and we can do the implementation


add guacamole restrictions

What is being addressed
Configure guacamole to have stricter rules
How is this addressed

Update Guacamole config file
https://guacamole.apache.org/doc/gug/configuring-guacamole.html

/test

/test-extended

/test-destroy-env

/test-extended

/test-destroy-env

/test

/test-extended

/test


Bug: Windows default beep sound plays when focusing Files after minimising

Description
Since <IP_ADDRESS> it always plays the windows default beep sound when minimising and then clicking on the app in taskbar then clicking again bring Files up like normal.
Steps To Reproduce

Open Files
Click the taskbar icon to minimize
Click the taskbar icon to focus the window. It will play the default beep sound and the taskbar will highlight like it's in focus
Click the taskbar icon again then Files windows focus like normal.

Steps to fix

?

Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.608
Relevant Assets/Logs
debug.log
debug_fulltrust.log

Alright.


Put token classname for parent element contains todo

Hello. Currently I'm highlighting with green color in my syntax theme only TODO (or FIXME) word and can't highlight the actual text of todo (which I'm really wanna) because it is coming right after .todo as text node and I can't apply styles for it.
span.comment
  span.todo
    TODO
  : test (just an text node)

Maybe it is possible to add a feature which would be add to that parent .comment node one more class which would show that this node contains todo inside?

Atom has an out-of-the-box included package, which adds syntax highlighting to TODO, etc.
todo-show is just about scanning the workspace and showing results with no modifications of the original text, so I do not think this feature will be added.

@mrodalgaard thanks a lot, didn't knew about that, sorry :)


Create boiler plate python module

Notes
Objective is to abstract away reusable code. Identify shared components between hm-config/diag/etc
Acceptance criteria

setup module with README explainig how to import
publish to pypi
waiting for miner keys to exist. read from API instead of waiting for file to load.
miner keys parsing
diagnostics related things: MAC address
~migrate https://github.com/NebraLtd/helium-hardware-definitions~ moved to hm-pythelper #3

Closed by: https://github.com/NebraLtd/hm-pyhelper/pull/9


Добавить команду /settings

Логика

Размер листа. По умолчанию установлен A4 297x210mm. Можно поменять на Гибкий (формат, присланных фотографий). Это значит, что изображения будут конвертироваться в определенном формате.
Спрашивать про назначаемое имя файла. По умолчанию стоит result.pdf. Можно задать значение по умолчанию, а можно спрашивать при каждой отправке.

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
🎉 Congratulations! You've won a share of the $1.500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. But that's not all—connect now, and you'll instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1.500k in BNB! Plus, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, seize the chance to win up to $20,000—it's your golden opportunity!
Winners: @


Articles are marked as read when navigated to with VoiceOver on the Mac

When I move between articles in the timeline using the arrow keys, each article I navigate to gets marked as read. This is probably because, upon gaining focus, the article is displayed in the reader pane. As a VoiceOver user, I find this behavior incredibly annoying, as each article I navigate to eventually vanishes from the "unread" feed. Unlike a sighted user, I need to navigate to each article, just to hear its title and decide whether I want to read it now or later.
This problem can sort of be avoided by disabling cursor tracking when navigating the list, however that's something we can easily forget about, which will mess up our unread feed completely.

I know that this isn't the fix you want, but have you tried using the "m" shortcut key? I marks the current article as unread and moves to the next unread article. That should help you scan articles and effectively leave them as unread. The "u" shortcut key will also mark the current article as unread and may be of some help to you as well.


Idle Notifier: Add ent chopping

Add ent chopping to idle notification plugin
Add ent chopping IDs
Closes #12898

these anim ids are re-used with canoe making, so this would cause the notifier to trigger from that. Which it probably should not. Also this requires the 2h axes now. I am not aware of a good way to differentiate between canoes and ents.

We discussed this further and decided it's probably fine if the idle notifier fires for a player going idle after starting to chop a canoe.


Feature request: Include placeholders for footer, page number, and date

I have read the documentation for creating slides from placeholders here:
https://python-pptx.readthedocs.io/en/latest/dev/analysis/placeholders/slide-placeholders/placeholders-in-new-slide.html
It seems that the placeholders for footer, page number, and date do not get added into a slide. However, I definitely do want those placeholders to be added. Is this possible?

Not to speak for Scanny here but he seems to follow very closely to how Microsoft does it. This is probably because of how the OXML standard dictates it. If you were create slide layouts and have footer/page number/date turn on within the slide master, and then applied those layouts to new slides in the presentation, the footer/page number/date would not be available as shapes you can access.
This is exactly how the process would go if you were to use win32com interoperability server instead of python-pptx. You can verify this quite easily. Open a pptx file in Powerpoint, apply a slide with a specific layout and go to Home -> Editing -> Select -> Selection Pane and now go to View->Slide Master. You can see for the given layout that the the footer/page number/date in the slide master but not on the presentation slide.
Just how it is, sorry.

In PowerPoint, there are distinct operations to add these placeholders to a slide; you can see icons for these in the toolbar:

I believe the placeholders in the slide-master determine where these are positioned and their size and formatting when and if they are added to a slide by clicking one of these buttons, but they are not added to all slides by default. I expect PowerPoint has some way of adding these to a selected group of slides in one operation.
In any case, that particular operation has no API support in python-pptx.


Memory leak / increasing usage in Jupyter for repeated cell execution

I believe that with HoloViews 1.8.3 on Jupyter there is a non-trivial memory leak when repeatedly executing a cell.  This creates an inconvenience when working/refining iteratively with large data sets.
I'm reporting this issue based on a real-world although admittedly somewhat complex use case, and I'll admit that I'm not sure I'm using HoloViews correctly.    I'm seeing that as I repeatedly execute cells in a Jupyter notebook, the memory usage for the kernel grows without bound.  This issues exists whether or not I'm using datashading and large datasets; since the memory increase is proportional to the data size, it's a lot more noticeable/problematic when there is a lot of data, I'll focus on the main case.
I'm combining several techniques in order to create a rich, user-friendly interface for reviewing my data.  (Kudos to HoloViews for being able to do this at all!)  The techniques are:

datashading Scatters of large data sets
creating Layouts of the scatters where the X axis varies across the scatter
creating a HoloMap interface so the user can cycle/explore subsets of the data iteratively
using redim and {+framewise} to ensure that all displays are scaled properly

I've supplied some code below that is a non-proprietary repro of my use case.  It definitely shows the same pattern of increased kernel memory for each cell invocation. Again, I'll say that I wrote it through trial and error, and I am by no means sure that I'm not abusing something and/or that there is a better way to accomplish the same things with HoloViews.
Initialization cell
import pandas as pd
import numpy as np
import holoviews as hv
from holoviews.operation.datashader import aggregate, shade, datashade, dynspread
import sys

hv.extension('bokeh')

n,k = 1_000_000,4
scales=np.linspace(1,10,k)

df = pd.concat([s * pd.DataFrame({
    'x1' : np.random.randn(n),
    'x2' : np.abs(np.random.randn(n)),
    'x3' : np.random.chisquare(1, n),
    'x4' : np.random.uniform(0,s,n),
    'y' : np.random.randn(n),
    's' : np.full(n, 1)
}) for s in scales])

def extend_range(p, frac):
    a, b = np.min(p), np.max(p)
    m, l = (a + b) / 2, (b - a) / 2
    rv = (m - frac * l, m + frac * l)
    return rv

def pad_scatter(s: hv.Scatter, frac=1.05):
    df = s.dframe()
    r = {d.name: extend_range(df[d.name], frac) for d in (s.kdims + s.vdims)[0:2]}
    return s.redim.range(**r)

print(f'df is around {sys.getsizeof(df) // 1024_000} MB')

Running this cell, I get
df is around 218 MB

and my Jupyter kernel is around 1831M.
** Evaluation cell **
%%opts RGB {+framewise}
hv.Layout([dynspread(datashade(hv.HoloMap([(s, pad_scatter(hv.Scatter(df[df.s == s], kdims=[x,'y']))) for s in scales]))) for x in ['x1', 'x2', 'x3', 'x4']]).cols(2)

This gives me a very beautiful scaled layout of shaded scatters.

However, the memory usage as I repeatedly evaluate that cell in the notebook is: 2717M, 3455M, 4441M, 5307M etc.
In reality I'm working with much more data (dataframes of around 10-30GB), and even though I'm on a pretty beefy machine, it starts to become a fairly big problem as I poke around and do trial-and-error exploration.  In reality I find myself having to restart the kernel pretty often.
I'm not using dask - maybe I should be - but I'm not sure that would fix the issue.
This issue does not appear to be related to datashader or the large size of the data. If I run something similar with much smaller n and using only a HoloMap instead of datashading, I see a similar increase in memory - just obviously a much smaller slope because n is smaller.

Thanks for reporting this and thanks for the example - this is important and we need to get to the bottom of the problem!

After you've moved the slider around for a bit and the memory usage has increased, what happens to memory usage if you then run import gc; gc.collect() - does it change?

@ceball
The answer to your question is: it doesn't help.  To be clear, the issue I'm reporting is about increase on re-evaluating the notebook cell, not on moving the slider.  That said, your comment prompted me to test the slider - that also leaks memory.  I can slide 1,2,3,4,3,2,1,2,3,4 etc. and the memory keeps growing.
In either case, the slider or the cell, calling gc.collect() seems to have no effect on the memory.
Also, to be totally clear, I'm looking at VIRT and RES in htop for my measure of memory usage.   I'm on Fedora release 20 (Heisenbug).

the issue I'm reporting is about increase on re-evaluating the notebook cell, not on moving the slider

Ah, sorry, I got distracted by the image loop :)
I wonder if this could be related to the notebook storing all outputs in Out? Although presumably storing Layouts shouldn't increase memory usage much, so seeing a never ending increase during multiple executions of the cell and during slider dragging does sound wrong!

calling gc.collect() seems to have no effect on the memory.

After I suggested that, I then began to remember that python doesn't necessarily return freed memory back to the operating system anyway. I'm out of touch with what current python versions on various operating systems do under different circumstances, though.

I should have added that I think someone might have to profile memory usage inside as well as outside python to find out what's going on; speculation like mine probably doesn't help at all! Although speculation from a holoviews developer might be more useful ;) My experience has been that e.g. pandas copies data when you might not expect it, and you don't know when python will free that memory, and then you don't know if that freed memory will ever make it back to the operating system (it does on some platforms, depending on version of python/c runtime, I think...).
(Although you mentioned holoviews 1.8.3 specifically - does that mean it's something that happens for you now, but didn't happen with previous versions?)

I said speculation isn't a good idea, but I can't help myself...
What happens if you replace hv.Scatter(df[df.s == s] with just hv.Scatter(df? Does memory usage still keep going up?

In the notebook, all inputs and outputs are saved:
Cell executed the first timeL
In[1]:  a=3; a
Out[1]: 3
In the same cell or other cells, both In[1] and Out[1] will be available.
The integer index increases on each execution of the cell.
So, how big is Out[n] in your case?

Here is an example:

Here the second cell was re-executed a bunch of times but the notebook keeps holds onto every intermediate output, even if the user doesn't define their own handle on it!
This isn't new notebook behavior and has nothing to do with HoloViews. That said, this keeps surprising me as the policy of holding every output ever shown in a session just doesn't seem sensible to me: it might have made sense back in the days when everything was simply a string repr, but it doesn't make sense in a world where people are visualizing large datasets.
A sensible policy would be to hold onto the last n outputs, up to some memory limit instead of expanding endlessly - maybe there is some such setting somewhere, I haven't looked into it yet.

One way to check whether it's the Jupyter caching that's causing this is to reset the out variable using %reset out, which should delete all references to the output.

Yes, I agree, demonstrating whether or not it's actually the output caching seems like a good idea. However, even if that is the cause, you may not see memory returned to your operating system after clearing Out anyway (does anyone here know the status of that for cpython on linux these days?). I'm just saying that it might need to be checked carefully (e.g. within python as well as without).
The memory usage going up even just dragging the slider indicates it might not be output caching, maybe? (Or does dragging the slider cause a cell execution that jupyter could cache?)
In any case, output caching ought not to be an issue: holoviews is not creating new data, right? Each execution should not add more than a small amount to the memory being used (compared to the original data size). That's why I'm wondering if e.g. a pandas copy is happening.

I think this is using a DynamicMap as dynspread and datashade are being used. DynamicMaps have a cache that will fill as you move the slider around but you can easily control it with the cache_size parameter:
    cache_size = param.Integer(default=500, doc="""
       The number of entries to cache for fast access. This is an LRU
       cache where the least recently used item is overwritten once
       the cache is full.""")

As you can see, the default is 500 - try setting it to 1 to see if that helps...

Showing my ignorance of holoviews...but what is it caching? Or to put it another way, when I use holoviews, when would I need to worry that holoviews will generate and/or store large amounts of data?

when would I need to worry that holoviews will generate and/or store large amounts of data?

In short, when using a HoloMap everything is static and can be exported to a standalone, offline HTML file which means everything is in memory.
For DynamicMap, output is assumed to be a function (a fixed output for a given set of arguments) which means that holoviews can look up the item in the cache if you revisit a particular slider position (instead of recomputing the same thing again). This cache is as big as cache_size and you can set it to a low value if necessary (e.g 1) and naturally, if the item isn't available in the cache you will need to recompute the value shown.
Hope that makes some sense!

Thanks for answering that. Sorry to be slightly hijacking this issue.

In short, when using a HoloMap everything is static and can be exported to a standalone, offline HTML file which means everything is in memory.

Say I have a huge dataset in "a dataframe" (which might be distributed via dask). If I'm using datashader with holoviews so that any individual plot is a reasonable size, then would I ever really need to worry about memory usage by holoviews?

You shouldn't need to worry as HoloViews' datashader support uses DynamicMap and datashader returns RGB images that shouldn't be too big (i.e sensible for your screen resolution). I suppose it is true that a cache of 500 such RGB images could get quite memory intensive...
@philippjfr Maybe we should reduce the cache_size for the DynamicMaps returned by the datashader operations? Do you think the datashader output RGBs might be taking up lots of space in the cache?

Say I have a huge dataset in "a dataframe" (which might be distributed via dask). If I'm using datashader with holoviews so that any individual plot is a reasonable size, then would I ever really need to worry about memory usage by holoviews?

In theory that's accurate although for interactive use using an out-of-core dataframe can be a bit slow. I'm not sure if caching the RGB outputs of the datashade operation is a real issue since it only caches on key dimensions and datashading works via streams, so you should generally only ever have one value in the cache.
In general working with an in-memory dask dataframe is quite efficient and I'd recommend working with them whenever you think making in memory copies of something might be a concern. Even a groupby on a large dataset shouldn't cause issues because something like nyc_taxi_dataset.groupby('dropoff_hour', dynamic=True/False) would create a HoloMap/DynamicMap of Elements, where the data are simply a dask graph selecting the subset of data for a particular hour, which means the subsets are only in memory while the data is actually accessed for datashading or plotting. Doing the same using a large pandas dataframe would be quite wasteful though since it will make actual copies of each subset/group and insert them into the DynamicMap cache.
So my recommendation for large datasets is to use dask even if they still fit in memory. I'd also be open to decreasing the cache size since in practice I never use the cache in any meaningful way.

@jlstevens, ok, that's great - that's what I was expecting to hear :)
Since the original issue above says that as the data size is increased, the problem becomes worse, that to me implies it should not be related to hv caching of datashaded images (those won't change in size based on the size of the data, right?), and should also not be related to notebook caching of outputs (for the same reason: no large data being created/stored by hv).

that to me implies it should not be related to hv caching of datashaded images (those won't change in size based on the size of the data, right?), and should also not be related to notebook caching of outputs (for the same reason: no large data being created/stored by hv).

Not sure that's accurate, both the input and the output of the datashade operation are cached so whenever you drag the slider it will cache both the raw dataframe and the aggregated image in memory. My bet is that it is indeed the combination of the DynamicMap cache and Jupyter output caching that's causing this.

Cell execution: In Jean-Luc's example, the input data is being created every time, so I understand that the notebook cache would grow every time running the hv.Image cell. However, in the original example, the input data is created before hv is involved: hv will just point to it, not copy it...right?! (My suggestion was that maybe the pandas indexing operation was causing a copy, or something like that. Yes, the images will be cached in memory, but they aren't large compared to the data, right?)
Dragging slider: isn't that the same in the original example? The input data is already created, so hv would just point to it, not copy it? (Again, except if the data's being copied for some reason.)
I'm definitely not going to bet against you. I should have taken my own advice and stopped speculating ;)

I should have read his example more closely, I thought the dataframe was being created inside a function but as you point out it isn't. The other thing is that the example actually uses a HoloMap so dragging the slider should make no real difference, since everything should be pre-allocated. I do wonder if df[df.s == s] is making copies for each subset though, in which case using a dask dataframe along with a dynamic groupby would be more efficient. Either way though this:
hv.Layout([dynspread(datashade(hv.HoloMap([(s, pad_scatter(hv.Scatter(df[df.s == s], kdims=[x,'y']))) for s in scales]))) for x in ['x1', 'x2', 'x3', 'x4']]).cols(2)

is better expressed as:
dataset = hv.Dataset(df)
hv.Layout([dynspread(datashade(ds.to(hv.Scatter, x, 'y', 's'))) for x in ['x1', 'x2', 'x3', 'x4']]).cols(2)

... datashading works via streams, so you should generally only ever have one value in the cache.

Good point! I forgot about that important detail - the DynamicMap cache shouldn't be the issue here.

Update it appears that this is largely a system install issue!  After some more testing, it appears that the only box that this occurs on is a Linux box we use at work that has a more ad hoc installation of holoviews, etc.  When I run on OSX or a Linux setup that is set up via a self-contained environment.yml and fresh conda install, I don't get the same issues.  I'll work with our sysadmins to dig in.

I wanted to back up my suggestion that there's a copy happening...
Outside of the notebook, if I run the OP's "Evaluation cell" in a loop like this:
print("a",time.time()-t0)

for i in range(repeats):
    if copy:
        hv.Layout([dynspread(datashade(hv.HoloMap([(s, pad_scatter(hv.Scatter(df[df.s == s], kdims=[x,'y']))) for s in scales]))) for x in ['x1', 'x2', 'x3', 'x4']]).cols(2)
    else:
        hv.Layout([dynspread(datashade(hv.HoloMap([(s, pad_scatter(hv.Scatter(df           , kdims=[x,'y']))) for s in scales]))) for x in ['x1', 'x2', 'x3', 'x4']]).cols(2)
    print(i,time.time()-t0)

print("b",time.time()-t0)

I see the following with 'copy':
(hvdev) [170907 202555]~/code/ioam/holoviews2$ mprof run -T 0.2 testmem.py 5 1
mprof: Sampling memory every 0.2s
running as a Python program...
repeats=5 slice=True
df is around 218 MB
a 2.94058895111084
0 4.017941951751709
1 5.142473936080933
2 6.26465106010437
3 7.38116192817688
4 8.502644062042236
b 8.502682209014893

And without 'copy':
(hvdev) [170907 202636]~/code/ioam/holoviews2$ mprof run -T 0.2 testmem.py 5 0
mprof: Sampling memory every 0.2s
running as a Python program...
repeats=5 slice=False
df is around 218 MB
a 3.2328739166259766
0 6.466661214828491
1 9.706587076187134
2 12.81578016281128
3 15.873624086380005
4 19.001055002212524
b 19.001084089279175

Not that it's very exciting, but I've attached the script: testmem.py.gz. mprof is memory_profiler 0.47 (https://pypi.python.org/pypi/memory_profiler). I'm using a mac with 16 GB ram.
Presumably in the first case python could at some point garbage collect the objects, but even then whether the memory would be "returned to the operating system" is not clear to me (I think it might depend on the platform).

Actually, here's the script, because I couldn't attach it as a .py file:
import time
t0 = time.time()

import sys
repeats, copy  = sys.argv[1::]
repeats = int(repeats)
copy = False if copy=='0' else True
print("repeats=%s"%repeats,"copy=%s"%copy)

############################################################
### code from issue

import pandas as pd
import numpy as np
import holoviews as hv
from holoviews.operation.datashader import aggregate, shade, datashade, dynspread
import sys

hv.extension('bokeh')

n,k = 1_000_000,4
scales=np.linspace(1,10,k)

df = pd.concat([s * pd.DataFrame({
    'x1' : np.random.randn(n),
    'x2' : np.abs(np.random.randn(n)),
    'x3' : np.random.chisquare(1, n),
    'x4' : np.random.uniform(0,s,n),
    'y' : np.random.randn(n),
    's' : np.full(n, 1)
}) for s in scales])

def extend_range(p, frac):
    a, b = np.min(p), np.max(p)
    m, l = (a + b) / 2, (b - a) / 2
    rv = (m - frac * l, m + frac * l)
    return rv

def pad_scatter(s: hv.Scatter, frac=1.05):
    df = s.dframe()
    r = {d.name: extend_range(df[d.name], frac) for d in (s.kdims + s.vdims)[0:2]}
    return s.redim.range(**r)

print(f'df is around {sys.getsizeof(df) // 1024_000} MB')

############################################################

print("a",time.time()-t0)

for i in range(repeats):
    if copy:
        hv.Layout([dynspread(datashade(hv.HoloMap([(s, pad_scatter(hv.Scatter(df[df.s == s], kdims=[x,'y']))) for s in scales]))) for x in ['x1', 'x2', 'x3', 'x4']]).cols(2)
    else:
        hv.Layout([dynspread(datashade(hv.HoloMap([(s, pad_scatter(hv.Scatter(df           , kdims=[x,'y']))) for s in scales]))) for x in ['x1', 'x2', 'x3', 'x4']]).cols(2)
    print(i,time.time()-t0)

print("b",time.time()-t0)

I also meant to add that I think this issue could be closed, because it doesn't seem to be a problem specific to holoviews. (The issue could always be reopened if new evidence is provided pointing at holoviews doing something wrong.)

@philippjfr If you can confirm that Chris is correct in saying that there is a memory leak, but it isn't HoloViews, then we should close this issue. I'm wondering if we should mention something about this in the docs, but I'm not quite sure where.

I think the issue should only be closed with no further action if it was all just a confusion. Whether or not the problem is HoloView's fault, either we need to mention it in the docs as a caveat, we need to explain how to avoid it in the docs, or we need to chase some other project to get it fixed.  I can't tell from a quick scan of the above which one of these it is.

If you can confirm that Chris is correct in saying that there is a memory leak

I didn't actually say that :) I said there's a copy happening, and it's happening outside of holoviews (in "user-level pandas code").
I also said:

Presumably in the first case [where pandas copy is happening] python could at some point garbage collect the objects, but even then whether the memory would be "returned to the operating system" is not clear to me (I think it might depend on the platform).

As in, I was speculating that maybe hv creates a cycle (involving the dataframe), so the memory won't be freed until garbage collection happens? (Do you know of such a cycle in hv?) And also that even if the memory is "freed" (i.e. the copies of the dataframe get garbage collected), I'm not sure whether or not you will see it by looking at the operating system's report of memory usage by python.
However, beyond the dataframe copy by pandas, all that's just speculation: you may be right to refer to what's happening as a leak, but I guess we'd need to demonstrate that the memory just keeps growing forever in the loop/is never available again for python to use (even after gc runs). So I probably did stop too early to say there's no problem in holoviews.

This issue might be related to the Bokeh issue: https://github.com/bokeh/bokeh/issues/8626
Just leaving this here for findability.

I have similar problem with tf2, pandas and matplotlib and %reset out actually helped, when gc.collect() did not.
Thx, @philippjfr,  but what exactly it does?


A lot of errors during compilation of generated code

I am using native codegen & parser. I was trying to compile generated rs files from created from this file and got these errors:
   Compiling input v0.1.0 (/home/dimanne/devel/scripts/observability/digester)
error: an inner attribute is not permitted in this context
 --> /home/dimanne/devel/scripts/observability/target/debug/build/input-0327159e6708cec6/out/protos/tetragon.rs:6:1
  |
6 | #![allow(unknown_lints)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: inner attributes, like `#![no_std]`, annotate the item enclosing them, and are usually found at the beginning of source files
  = note: outer attributes, like `#[test]`, annotate the item following them

error: an inner attribute is not permitted in this context
 --> /home/dimanne/devel/scripts/observability/target/debug/build/input-0327159e6708cec6/out/protos/tetragon.rs:7:1
  |
7 | #![allow(clippy::all)]
  | ^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: inner attributes, like `#![no_std]`, annotate the item enclosing them, and are usually found at the beginning of source files
  = note: outer attributes, like `#[test]`, annotate the item following them

error[E0753]: expected outer doc comment
  --> /home/dimanne/devel/scripts/observability/target/debug/build/input-0327159e6708cec6/out/protos/tetragon.rs:22:1
   |
22 | //! Generated file from `tetragon.proto`
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: inner doc comments like this (starting with `//!` or `/*!`) can only appear before items
help: you might have meant to write a regular comment
   |
22 - //! Generated file from `tetragon.proto`
22 + // Generated file from `tetragon.proto`
   |

error[E0433]: failed to resolve: there are too many leading `super` keywords
   --> /home/dimanne/devel/scripts/observability/target/debug/build/input-0327159e6708cec6/out/protos/tetragon.rs:614:62
    |
614 |     pub permitted: ::std::vec::Vec<::protobuf::EnumOrUnknown<super::capabilities::CapabilitiesType>>,
    |                                                              ^^^^^ there are too many leading `super` keywords

error[E0433]: failed to resolve: there are too many leading `super` keywords
   --> /home/dimanne/devel/scripts/observability/target/debug/build/input-0327159e6708cec6/out/protos/tetragon.rs:616:62
    |
616 |     pub effective: ::std::vec::Vec<::protobuf::EnumOrUnknown<super::capabilities::CapabilitiesType>>,
    |                                                              ^^^^^ there are too many leading `super` keywords

This is my build.rs:
fn main() {
   protobuf_codegen::Codegen::new()
      .pure()
      .cargo_out_dir("protos")
      .includes(["src/"])
      .input("src/tetragon.proto")
      .input("src/capabilities.proto")
      .run_from_script();
}

@DimanNe Not sure if you are still facing the issue. The following build.rs works for me. I placed both capabilities.proto and tetragon.proto under protos folder like so.
File Structure
.
├── Cargo.lock
├── Cargo.toml
├── build.rs
├── src
│   ├── gen
│   ├── lib.rs
│   └── protos
└── target
    ├── debug
    └── ..

fn main() {
    protobuf_codegen::Codegen::new()
        .pure()
        .out_dir("src/gen")
        .includes(["src/protos"])
        .inputs(&[
            "src/protos/tetragon.proto",
            "src/protos/tetragon/capabilities.proto",
        ])
        .run_from_script();
}

I confirm I have this issue as well.

Oh, I had checked your comment but for some reason I missed the important part.


can not start javafx project

Error: Could not find or load main class application.Main
Caused by: java.lang.NoClassDefFoundError: javafx/application/Application

I am facing the same issue in my project.

Have the same issue, using Adopt OpenJDK and OpenJFX.

@sharidass1408 your jar task should use configurations.runtimeClasspath, as now the JavaFX plugin uses implementation instead of the deprecated compile (that is why configurations.compile doesn't include the JavaFX classes in the fat jar).
The docs/sample already contain this change. See for instance this build.


cardano-tracer: RTView logs live view

Closes #4264
Please note that this PR does not include the search feature for the logs. This feature will be implemented in the next PR (corresponding to #4265).

bors r+


OOBESETTINGSMULTIPAGE

Following the guide I am stuck on windows initialization screen after installation.. Ever someone got something like this? Cant procees any futher and it keep reapearing after pressing the try again button.
First text says something like "Something went wrong"
the second "but you can try again"
the button says "try again"

My bad, it was troublesome in nested VMs, but ok in only one VM


Removed the negative MaxAge cookie condition

Removed the negative MaxAge cookie condition and added check to deny adding cookies with negative MaxAge to Cookies header ref #55

I'm closing this PR because no answer from @brian978


array: Fix structured bindings

Moves all get overloads for frg::array to frg namespace as Clang and GCC expect get to be in inner type's namespace. More info here in Case 2.

hmm, the get invocation should undergo ADL, though, per [dcl.struct.bind]#5, odd that it doesn't.
please add a testcase also

oh, sorry, I read your patch backwards - that explains it :-)
in that case, this looks OK (but perhaps we should keep both overloads, and we should still add a test)

I added a testcase for frg::array but I didn't add a reference test since arrays of references are illegal. I tried to add the get overloads back to the std namespace for bw compatibility, but an error is thrown since the get overload is ambiguous between frg and std namespace.
(btw, I agree that frg::array should be phased out as it is identical to std::array)


Make the DNS provider optionnal [Proposal]

I tried to use your letsencrypt stack. but I ran into a problem : I don't use one of the supported DNS provider.
But sending the certificate to the provider is only useful if the DNS provider provide a reverse-proxy services (like Cloudflare), and thus should be optional, allowing the user to use the stack more easily.
Would it be possible?

Support for HTTP challenge has been added in https://github.com/janeczku/rancher-letsencrypt/commit/2777fcd8eb15fed992a01d41387d2904e010e501


Fix refresh cancelation

Changes drag release logic so that an armed refresh is only canceled if the user has scrolled back up beyond the point where the refresh indicator was armed. (Fixes #138848.)
This is the minimal change I found could be made to restore something like the behavior that I would expect.
This may still need a bit of work, because it only masks the second issue I mentioned, that releasing a drag can cause the scroll position to be animated back up from the release point. There is actually a bug about that: #6052. I would like to see that bug fixed too. This PR doesn't address that, but makes it harder to hit that issue.
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

I honestly have no idea how to write a test for this... @Hixie
(It's a very straightforward fix though, and can be manually tested...)

@Piinks sorry, I didn't notice the failing tests...
Flutter's git main branch doesn't even build out of the box -- I get these errors:
Resolving dependencies...
Note: web is pinned to version 0.3.0 by flutter_test from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

Because every version of flutter_test from sdk depends on web 0.3.0 and manual_tests depends on web 0.4.0, flutter_test from sdk is forbidden.
So, because manual_tests depends on flutter_test from sdk, version solving failed.
exit code 1

I think this is triggering a lot of the test failures. I'll try tinkering with this and see if I can get it working.
As far as writing a test for this, I have absolutely no idea how to do that for a Flutter widget, but I'll try to find examples in the existing tests.

Closing in favor of #139535 -- sorry, I have been battling with a git issue, and it's just easier to submit a new PR.


JVM memory leak fix

Fixes #4021
Changes:

Created phantom reference registry with one thread which cleans up objects when needed.
Also added instrumentation testing support for kotlin target, for KMP testing purposes.

Hi @vcoolish, could you explain a little bit why the old code doesn't work?

because it did register, but never did clean up. so it was a useless implementation of reference registry without actual logic inside to clean up references, only to track them.


feat: 2484 - now when editing we go to the full image with the cropped area on top

Impacted files:

app_en.arb: added a label for the "send image" button (instead of vague "confirm")
background_task_crop.dart: added a product change where we store the crop parameters
background_task_image.dart: added a fake product change where we remove the crop parameters
new_crop_page.dart: added constructor parameters initialCropRect and initialRotation; removed the "new photo" button for UI/UX consistency
product_image_viewer.dart: refactored with 2 or 4 buttons and cleaner code
product_query.dart: added IMAGES product field
pubspec.lock: wtf
pubspec.yaml: upgraded openfoodfacts to 2.2.1 (about ProductImage)
rotation.dart: added method fromDegrees
up_to_date_changes.dart: added images to "overwritable" product fields; now accepts all operation types

What

Before, when we edited an image, we edited it as if it was a full image taken by the camera, even if it was cropped.
Now, we display the full image actually taken by the camera, with the visible cropped area on top.
Some changes on the buttons too, cf. screenshots.

Screenshot

read-only page
crop page

Read-only page with no previous image:

Fixes bug(s)

Closes: #2484

Part of

#766

Codecov Report

Merging #3658 (326bcc1) into develop (7121b0e) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3658      +/-   ##
===========================================
- Coverage    10.65%   10.56%   -0.09%
===========================================
  Files          270      270
  Lines        13474    13584     +110
===========================================
  Hits          1435     1435
- Misses       12039    12149     +110

Impacted Files
Coverage Δ

...mooth_app/lib/background/background_task_crop.dart
0.00% <0.00%> (ø)

...ooth_app/lib/background/background_task_image.dart
0.00% <0.00%> (ø)

...smooth_app/lib/data_models/up_to_date_changes.dart
0.00% <0.00%> (ø)

...th_app/lib/pages/product/product_image_viewer.dart
0.00% <0.00%> (ø)

packages/smooth_app/lib/query/product_query.dart
8.10% <ø> (ø)

...s/smooth_app/lib/tmp_crop_image/new_crop_page.dart
0.00% <0.00%> (ø)

...ckages/smooth_app/lib/tmp_crop_image/rotation.dart
1.69% <0.00%> (-0.10%)
:arrow_down:

...pp/lib/pages/product/common/product_list_page.dart
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you @teolemon for the review!


Warn about dead code

type someType = {
 a : number,
 b : string | null
}

//...

const ff = (data: someType): string => {
  if (data.c === null) {
    return 'field b is smpty';
  }

  return 'some value';
}

At this moment for flowtype this code is correct. Only that this code contains a logical error.
Flowtype could easily detect this error.
data.c === null

Left side is undefined (data.c is always undefined), right side is null. This condition always returns false.
So enough detect that the types specified for the operator compare are disjoint.
Another example:
type someStatusType = 'loading' | 'error' | 'ok';

const getLabel = (status: someStatusType): string => {
  if (status === 'loading') {
    return 'Loading';
  }
  if (status === 'error') {
    return 'Error label';
  }
  if (status === 'complete') {            //dead code
    return 'Complete status';
  }
  return 'ok';
};

This dead code can be detected by this comparison :
status === 'complete'

This types are disjoint ( 'loading' | 'error' | ok' ===  'complete' will always be false).

Flow is a type checker, and doesn't compile your code. The type definitions are removed by Babel.
So Flow won't be adding Dead-Code Elimination.
However, Flow could throw a warning when you do obviously false or obviously true comparisons. Essentially letting you do some sort of manual dead-code detection. In the second example, you probably meant to test 'ok' instead of 'complete'. Showing you a warning instead of silently removing the dead code is probably a better outcome.

Yes, indeed, I mean just about to flowtype reported warnings. Messages will allowing to manually correct code. These messages will be very helpful for refactoring.

Changed title to make that clearer. Fingers crossed.

Thank you :)

This issue makes me frightened before every refactoring.

This would be great.


After ng new (no ssr) ng serve wont compile

Command
serve
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
All of em
Description
ng serve

Building...X [ERROR] File 'src\main.ts' is missing from the TypeScript compilation. [plugin angular-compiler]
Ensure the file is part of the TypeScript program via the 'files' or 'include' property.

Application bundle generation failed. [5.327 seconds]
Watch mode enabled. Watching for file changes...
Minimal Reproduction
Using NVM 1.1.11 on windows 11,  node v20.9.0 and npm 10.1.0.
Ran 'ng new app-name'
Application was generated,
Ran 'ng serve'
Issue listed below
Exception or Error
ng serve
- Building...X [ERROR] File 'src\main.ts' is missing from the TypeScript compilation. [plugin angular-compiler]

  Ensure the file is part of the TypeScript program via the 'files' or 'include' property.

Application bundle generation failed. [5.327 seconds]
Watch mode enabled. Watching for file changes...

Your Environment
Angular CLI: 17.0.1
Node: 20.9.0
Package Manager: npm 10.1.0
OS: win32 x64

Angular: 17.0.3
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.1
@angular-devkit/build-angular   17.0.1
@angular-devkit/core            17.0.1
@angular-devkit/schematics      17.0.1
@angular/cli                    17.0.1
@schematics/angular             17.0.1
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.2

Anything else relevant?
I got this to work thanks to ai telling me to "include": ["src/**/*.ts"] to compiler options, but I want to be able to run ng new on a project and serve the starter app, which isn't happening - also the case when generating a new SSR project, out of the box.

I noticed npm -g list @angular/cli is 17.0.1 and @angular/core is 17.0.3 so I am going to make sure -g @angular/core is 17.0.1 and try again

Duplicate of https://github.com/angular/angular-cli/issues/26379