building without sandbox fails

bazel build --spawn_strategy=standalone packages/...
produces:
ERROR: /private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/external/build_bazel_rules_typescript/internal/tsetse/rules/BUILD:19:1: Compiling TypeScript (devmode) @build_bazel_rules_typescript//internal/tsetse/rules:rules failed (Exit 1)
error TS5033: Could not write file '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/checker.js': EACCES: permission denied, open '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/checker.js'.
error TS5033: Could not write file '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/error_code.js': EACCES: permission denied, open '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/error_code.js'.
error TS5033: Could not write file '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/failure.js': EACCES: permission denied, open '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/failure.js'.
error TS5033: Could not write file '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/rule.js': EACCES: permission denied, open '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/rule.js'.
error TS5055: Cannot write file '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/checker.d.ts' because it would overwrite input file.
error TS5055: Cannot write file '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/error_code.d.ts' because it would overwrite input file.
error TS5055: Cannot write file '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/failure.d.ts' because it would overwrite input file.
error TS5055: Cannot write file '/private/var/tmp/_bazel_ahippler/0dac7dbbfa69c3554d01aab5e4a39c29/execroot/angular/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsetse/rule.d.ts' because it would overwrite input file.
INFO: Elapsed time: 57,444s, Critical Path: 6,03s
FAILED: Build did NOT complete successfully

those .d.ts files are added as "files" in the rules_es5_tsconfig.json

Reproducible at my end as well.
We are using remote cache which disables sandboxing. Workaround for us is using the experimental remote caching functionality build --experimental_remote_spawn_cache.

This is tricky. The root cause is that ts.createProgram walks the imports of the rootFiles, and prefers .ts files it finds on disk over .d.ts files. These .ts files then get included in the emit, even though they are already present as inputs. This issue is https://github.com/Microsoft/TypeScript/issues/22208
Ideally the noResolve option to tsc would avoid the compiler doing this walk. But since we allow any files in node_modules to be implicit inputs to the compilation, we can't produce a files section in the generated tsconfig that always has the complete set of files needed for the compilation.
Another remediation would be a Bazel feature: the action is declared with execution_requirements = { "supports-workers": 1} which means it supports both standalone and worker mode, but I'd rather not have to support and test both and deal with bugs like this - I'd rather have execution_requirements = {requires-workers} or similar. Even if Bazel were to spawn a new process for every compilation, I want it to pass the worker protocol to the typescript compiler, as that's how I know which inputs are meant to be read by this process, and I can hide other files from the TypeScript resolution.
/cc @philwo what do you think about such an execution requirement?

@ulfjack is the current "execution requirement lead" and has a plan for how to restructure them.

That would be incompatible with remote execution, which you probably don't want? Unless you're suggesting that we use remote execution + workers? It certainly doesn't fit into the current execution model, and I'm not sure there's a strong enough use case for changing the model.

We now include node_modules files as inputs to the ts.Program so I think this is fixed.
But we should totally remove the allowActionInputReads behavior to prove that everything is hermetic.


Add C# Pattern Programs

Extend Printing Pattern Programs by creating a collection of C# programs for existing patterns.

Individual Issues To Be Opened For Each Type Of Pattern Section Moving Forward From Here.

Individual Issues To Be Opened For Each Type Of Pattern Section Moving Forward From Here.


Add calendar-specific config for maximumEntries and maximumNumberOfDays

Now you can force specific calendars to use separate settings for maximumNumberOfDays and maximumEntries.
Usable with a config file like:
config: {
    calendars : [ {
        url: "webcal://...",
        config: {
            maximumNumberOfDays: 3,
            maximumEntries: 1
        }
    } ]
}

Thanks for your contribution. To be honest, I think adding a config in a config will create a lot of confusion. I prefer the following setup:
config: {
    calendars : [ {
        url: "webcal://...",
        maximumNumberOfDays: 3,
        maximumEntries: 1
    } ]
}

@MichMich Yeah, that's probably better.  I've made the changes and updated the calendar README.

Awesome. Could you also add an updated CHANGELOG.md?

@MichMich Sure, I wasn't sure what to do with the version number so I bumped it to 2.2.0  Not sure if that's what you wanted or not.
At some point I needed to do a merge which confused me.  Did I accidentally merge with the wrong branch?

@Nosrac You probably based this change form an old master branch. This commit would change 42 files, reverting them back to old versions. Could you please rebase your changes and resubmit a PR to the develop branch? Thanks!


[BUG] - Auto tunneling VPN fails after switching to a roamed LTE

While riding yesterday  found out that wgtunnel 3.4.0 on LOS20/Fairphone FP3+  fails if one crosses a broder and mobile connection switches to roaming.

Setting: Auto Tunneling on mobile data ON
Riding in home country VPN is turned on when leaving home SSID WIFI
after crossing the border i lost connectivity (also no key which shows VPN on shown)
paused Autotunneling and manually switched on the connection worked immediately

unsure how to further debug this one.

I think this one might be fixed with the new auto tunneling changes. I'm going to mark as closed for now. If you encounter the error again, please let me know and we'll reopen this ticket.


SWS-90 Adding dependencies:

k8s.io/client-go
k8s.io/apimachinery
github.com/prometheus

As discussed in https://github.com/swift-sunshine/swscore/pull/17 and in the IRC this PR only holds the dependencies brought from modifying glide.yaml:
package: github.com/swift-sunshine/swscore
import:
- package: github.com/golang/glog
  version: 23def4e6c14b4da8ac2ed8007337bc5eb5007998
- package: gopkg.in/yaml.v2
  version: a5b47d31c556af34a302ce5d659e6fea44d90de0
- package: github.com/gorilla/mux
  version: ^1.6.1
- package: k8s.io/client-go
  version: v6.0.0
- package: k8s.io/apimachinery
  version: release-1.9
- package: github.com/prometheus/client_golang
  version: v0.9.0-pre1
- package: github.com/prometheus/common
  version: 89604d197083d4781071d3c65855d24ecfb0a563

Steps followed are extracted from :
https://github.com/kubernetes/client-go/blob/master/INSTALL.md

LGTM!


using temperature sensors

Got Raspberry Pi 3 recently and I am now testing some basics.  I am running this code to the temp sensor:
var five = require("johnny-five"),
Raspi = require("raspi-io"),
board = new five.Board({
io: new Raspi()
});
console.log("started...");
board.on("ready", () => {
console.log("inside of ready")
var temperature = new five.Thermometer({
  controller: "TMP36",
  pin: 'P1-7'
});

temperature.on("change", () => {
  console.log(this.celsius + "°C", this.fahrenheit + "°F");
});

});
however this is the error I am getting:
pi@raspberrypi:~/projects $ sudo node raspi-io.js<PHONE_NUMBER>258 Device(s) RaspberryPi-IO
started...
1485155355292 Connected RaspberryPi-IO
1485155355303 Repl Initialized

inside of ready
/home/pi/projects/node_modules/raspi-io-core/dist/index.js:503
throw new Error('Pin "' + pin + '" does not support mode "' + mode + '"');
^

Error: Pin "7" does not support mode "2"
at RaspiIOCore.value (/home/pi/projects/node_modules/raspi-io-core/dist/index.js:503:15)
at RaspiIOCore.pinMode (/home/pi/projects/node_modules/raspi-io-core/dist/index.js:484:21)
at Thermometer.analogHandler (/home/pi/projects/node_modules/johnny-five/lib/thermometer.js:14:11)
at new Thermometer (/home/pi/projects/node_modules/johnny-five/lib/thermometer.js:980:10)
at Board.board.on (/home/pi/projects/raspi-io.js:16:23)
at emitNone (events.js:91:20)
at Board.emit (events.js:185:7)
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickDomainCallback (internal/process/next_tick.js:122:9)
Any idea what could be missing?
Cheers!

Hi @pepemarino! Unfortunately the TMP36 is an analog sensor, and the Raspberry Pi does not have any analog inputs on it. You'll need to use a different sensor that uses I2C to communicate, such as the SparkFun TMP102 instead.

Thank you Nebrius!  On my way to Amazon!  :)

Best of luck!


Error: Index 1 out of bounds for length 1

I'm running standalone converter of NOR2QML. When I convert the file NORDIC format to QUAKEML I get the following error:
Number of events: 221
-------------------------------------
Errors found in file and are ignored:
File: collect.out | Row: 28 | Error: Index 1 out of bounds for length 1 | LineText: QS09 EZ IS       1736 15.01                              70   -54.8 0  562 289
File: collect.out | Row: 28 | Error: Index 1 out of bounds for length 1 | LineText: QS09 EZ IS       1736 15.01                              70   -54.8 0  562 289
File: collect.out | Row: 8 | Error: Index 1 out of bounds for length 1 | LineText: QG04 EZ EP   1 C 23 6 56.71                             169   -0.06 7 0.96 131
File: collect.out | Row: 12 | Error: Index 1 out of bounds for length 1 | LineText: QB01 HZ EP   4 C 23 6 57.22                             153    0.36 0 2.53 232
File: collect.out | Row: 16 | Error: Index 1 out of bounds for length 1 | LineText: QG05 EZ EP   2   23 6 57.31                             149    0.43 5 2.93 273
File: collect.out | Row: 20 | Error: Index 1 out of bounds for length 1 | LineText: QG03 EZ EP   3 D 23 6 57.38                             148    0.48 2 3.08 188
.
.
.
File: collect.out | Row: 10 | Error: Index 1 out of bounds for length 1 | LineText: QG06 EZ EP   1 C  628 56.48                             113    0.34 7 5.38   5
File: collect.out | Row: 14 | Error: Index 1 out of bounds for length 1 | LineText: QS08 EZ IP   1 D  628 56.27                             111    0.16 7 5.55 268
-------------------------------------
creating file...
file created at path: /Users/joaofontiela/nor2qml/converter-standalone/target/quakeml.xml
Conversion finished after 1 seconds

I didn't realize the error since the other stations, of the same event, were converted.

Thank you for reporting this issue. The issue was due to a new implementation of weight conversion. It has now been fixed.


sdl: pixels, power, rect, rwops, scancode...: Add documentation #265

This is the last one for SDL lib. Only 4 optional ones left.
Breaking changes:
+ Renamed `Id` to `ID` in `Finger` struct
+ Renamed `SW_YUVTexture` to `SWYUVTexture`

- Unexported `Flags`, `Locked` and `LockData` in `Surface` struct
- Unexported `Rloss`, `Gloss`, `Bloss`, `Aloss`, `Rshift`, `Gshift`, `Bshift`, `Ashift`, `RefCount`, `Next` in `PixelFormat` struct
- Unexported `Version`, `RefCount` in `Palette` struct

This change is

Thank you for so much effort!


Enhancement: Key Functionality for Header Option Selection

Tell us about the task you want to perform and are unable to do so because the feature is not available
Currently, when interacting with the header options in the application, users are unable to utilize the arrow keys to navigate and select options from the list. This enhancement aims to enhance user experience by allowing navigation and selection of header options using the arrow keys. Also , after selecting the option, cursor should move to header value

Hey @PCoder23, are you working on the implementation?

@opxdelwin yes , I am

It is a nice feature to include. But, kindly resolve https://github.com/foss42/apidash/issues/196 which is of higher priority before proceeding with this issue.

sure @animator

This issue is now open to be undertaken as #196 has been resolved.

@ashitaprasad i guess its already resolved with #196

@PCoder23, #196 does not implement the arrow key feature for navigating options in the list, so this issue is still open.

hey @ashitaprasad , can you confirm this behaviour - control/command + space to open the suggestion box and  and then arrow keys to select the options
https://github.com/foss42/apidash/assets/85278795/ffdde701-68a7-4fc4-899a-697cebc08e51
or are we expecting some other behaviour

@PCoder23 Why do you need to press control/command + space
Once the user types a character, the suggestion box automatically opens up.
Now, the user should be able to use up & down arrows to navigate and select an option.

@animator its for when the user wants to see the all the options of header list, initially when the input is empty and is focused. aside that it will behave as you said

@PCoder23 send across a PR for review.

sure

@PCoder23 as you pointed out earlier, this issue has been resolved by #196


Randomly assigned pull requests after 2 weeks

Add a daily job to randomly assign pull requests which have been opened for more than two weeks.

LGTM

Next step.... ever increasing number of nagging emails reminding the owners as the days go by :-)  I can think of a few other projects that could use this.

@duglin i'll set a reminder to keep nagging you

I'm sure I need it too!


Meeting tomorrow @10:30 am

Hi @matthew-brett I was wondering if we can meet with you a little earlier tomorrow so we can have a chance to ask you plenty of questions as we reach the end of our analysis. Thank you in advance.

Sure.  How about 11 tomorrow?

Yes, that's perfect! We'll see you tomorrow at 11.


VQ file: bus signal are split into individual signals

In the VQ file (Verilog post-layout netlist), the bus signals are split into individual signals:
Its should be:
output [15:0] count;
In VQ file:
output \count[0] ,
output \count[1] ,
output \count[2] ,
output \count[3] ,
output \count[4] ,
output \count[5] ,
output \count[6] ,
output \count[7] ,
output \count[8] ,
output \count[9] ,
output \count[10] ,
output \count[11] ,
output \count[12] ,
output \count[13] ,
output \count[14] ,
output \count[15]
counter_16bit.zip

@rakeshm75 @lnsharma This is done intentionally. The problem is that for post-layout simulation with Icarus Verilog all cell ports (including top-level) must be 1-bit wide because Icarus does not support SDF annotations for wide ports. There is even an issue reported in its main repository: https://github.com/steveicarus/iverilog/issues/509

@rakeshm75 @lnsharma This is done intentionally. The problem is that for post-layout simulation with Icarus Verilog all cell ports (including top-level) must be 1-bit wide because Icarus does not support SDF annotations for wide ports. There is even an issue reported in its main repository: steveicarus/iverilog#509

@mkurc-ant : Is it feasible to generate 2 vq files - one with all cell ports of 1-bit wide and other with vector representation of cell ports? These files can  then be accordingly used in different simulators?


Palladium fantasy 2 e

Changes / Comments
Moved the skill level entry field from the hidden toggle row to the visible row in each of the 3 repeating skill sections on the skill tab to make it easier to access during character level up.
Updated the documentation and release notes tab.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Character Sheet Info Roll20 Internal Use only.


Test for OpenVINO Examples

Added test for all OpenVINO examples except SD.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

To fix the code style check you can do the following :
pip install .[quality]
make style


Where is source for urlrelay.com?

RFE: Can you make the source available for urlrelay.com?
I found this description online:

The web service is "urlrelay.com", and yes, it's a web service I created for this purpose. It's built using the AWS serverless model (api gateway, lambda, DynamoDB, cloudfront) so should be highly reliable. No server to go down. And costs me around $0 to run.
It function is to serve as a sort of mailbox, so the Raspberry Pi (which knows its local network IP address) can hand a URL to your browser (which doesn't know the Rasbperry Pi's IP address).
If the Raspberry Pi's local network IP address doesn't change, after you get the url you don't really need urlrelay.com any more, you can just keep using the url it handed you the first time. You only need urlrelay.com when the Pi's IP address is unknown. In worst case you could figure out the IP address from your router, or with a tool like fing; but I didn't want users to need to do that.
I'm not sure about using jambox.local, I don't think that would resolve from your laptop without creating an entry in hosts file or in DNS.

I'll leave it to Kevin to answer, sort of sounds from the description like
there may be no source to share, maybe most easily done with something like
Cloud Formation or terraform.
But I wanted to point out there are other ways to get to the same goal,
which is simply discovery of the local IP used by the jambox.  I use a
slack channel webhook, and dispatch a message with the new URL at boot
time.  That script is run from /etc/rc.local, and is reliable as long as
there is networking available at boot time.  The same approach could be
used to send email, SMS, etc.
Carlos
On Sun, Feb 21, 2021 at 8:43 AM Joe Bowbeer<EMAIL_ADDRESS>wrote:

RFE: Can you make the source available for urlrelay.com?
I found this description online
https://sourceforge.net/p/llcon/discussion/hardware/thread/91475bcb82/#38bc
:
The web service is "urlrelay.com", and yes, it's a web service I created
for this purpose. It's built using the AWS serverless model (api gateway,
lambda, DynamoDB, cloudfront) so should be highly reliable. No server to go
down. And costs me around $0 to run.
It function is to serve as a sort of mailbox, so the Raspberry Pi (which
knows its local network IP address) can hand a URL to your browser (which
doesn't know the Rasbperry Pi's IP address).
If the Raspberry Pi's local network IP address doesn't change, after you
get the url you don't really need urlrelay.com any more, you can just
keep using the url it handed you the first time. You only need
urlrelay.com when the Pi's IP address is unknown. In worst case you could
figure out the IP address from your router, or with a tool like fing; but I
didn't want users to need to do that.
I'm not sure about using jambox.local, I don't think that would resolve
from your laptop without creating an entry in hosts file or in DNS.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kdoren/jambox-pi-gen/issues/51, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKJTEYRYRCHLR75E4PJYPTTAEZ3BANCNFSM4X7EVROA
.

@joebowbeer urlrelay.com is built using the AWS services listed above.  There is a code piece, which is around 300 lines of Python running in a Lamdba function that is invoked when an API method is called.  It's not part of the jambox image, so I'm not currently planning to open-source it.


Cache storage firewall guidance is slightly contradictory

On this section:
https://learn.microsoft.com/en-us/azure/site-recovery/azure-to-azure-support-matrix#cache-storage
you say both
"If you're using firewall enabled cache storage account or target storage account, ensure you 'Allow trusted Microsoft services'."
and
"Note: Don't restrict virtual network access to your storage accounts used for Site Recovery. You should allow access from 'All networks'."
This seems contradictory.
The first appears to imply you CAN restrict virtual network access on a storage account used by Site Recovery, as long as you "allow trusted Microsoft services", but the second seems to indicate you should not have any restrictions at all.
Unless I'm confused (entirely possible), this seems contradictory.
Can you please add clarification to the page, or remove whichever is inaccurate?
Thanks!
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 34d0f2df-de85-c6ab-eb01-f8e028b7f108
Version Independent ID: 5acb187c-f280-5c7d-14fc-7f07160cd50b
Content: Support matrix for Azure VM disaster recovery with Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/azure-to-azure-support-matrix.md
Service: site-recovery
GitHub Login: @ankitaduttaMSFT
Microsoft Alias: ankitadutta

@pgbfnf Thanks for your comment! We will review and provide an update as appropriate.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The updates are in the pipeline.
We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


[Bug] Merged PRs have their commits and files changed metadata 'zeroed'... sometimes.

Gitea version (or commit ref): v1.11.3
Git version: 2.24.1
Operating system: Ubuntu 18.04 (used as a Docker host for Gitea)
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No
[ ] Not relevant

Log gist: N/A

Description
As of recent (within the last month I'd estimate), many PRs have their commits and files changed counters zeroed out after merging. This happens most of the time but weirdly not always on my instance now. Deleting the branch afterwards doesn't make seem to make a difference if that makes a difference.
I'm not sure how a lot of the internal Git plumbing works for Gitea so I haven't managed to take a look at the code directly. I know that #10618 seemed to be somewhat relevant - and the linked PR example in there does indeed show the behaviour below! I'm confused as to why this is shown for me as both branches definitely still exist.
Screenshots

It should be related with #10618. @zeripath

Nope. Merged PRs are displayed by a different set of code.
https://github.com/go-gitea/gitea/blob/7225453d5f4694f69e1a18e42204b52ed9fffc9c/routers/repo/pull.go#L303-L328

So the problem seems to be that the mergebase is incorrect - it's somehow ending up being the head!

This means that v128.go is incorrect.
The trouble is that:
pr.MergeBase, err = git.NewCommand("merge-base", "--", pr.MergedCommitID+"^", gitRefName).RunInDir(repoPath)

Appears to have selected the gitRefName if it's a parent of MergedCommitID instead of the other branch.

Would you reckon this is a migration problem? This has been happening on new PRs straight after merging however.
I tried running it in debug mode (to use breakpoints) with SQLite in VS Code on my Windows machine but hit issues around needing gcc setup properly. I may try and migrate the existing DB to MySQL before investigating further if I get time tomorrow 😃

It's probably the same issue if something recalculates the mergebase.

We need to calculate the merge base from the other parents of the mergecommitid (if there are multiple parents)
git rev-list --parents -n 1 MERGE_COMMIT_ID

Will give the commit id followed by the parents. Can get the merge base from those.
Damn sorry it seemed to work in testing not sure why.

So I've managed to mostly dump the existing SQLite DB into MySQL and a repo. The value of the repo path seems very supsect on my Windows machine:

Obviously that ...+ 9 more shouldn't be there! It should be [redacted]settlementservice.git.

Aah I think I've gotcha, so this bug will appear if the merge commit created by a PR has a parent that's also a merge commit? That would explain it not always appearing!

@jamesorlakin - ah I see how you're getting the problem of the randomly updating merge base.
We're back to the race between the checker and merger - which is mostly fixed in 1.12

Are you sure you're definitely getting this after merging PRs? Could you check what the contenst of the version table is in your DB?

This instance (v1.11.3) is currently on DB version 118:

The MergeBase of the Pull model end up being the commit that gitRefName points to:

It's very strange, and doesn't happen all the time. Some PRs are just fine after merging. I can't seem to figure out any consistent behaviour that would cause this - my theory about merge commits doesn't hold out, as we use a protected branch workflow so every commit the branch points to is a merge commit from a previous PR...

Have they been marked manually merged?

...Marked as manually merged? We just use the big green Merge Pull Request button - no rebasing or anything fancy... if that helps at all!

In the database pull_request table the status column do the broken ones have status ==  3.
There's a check goroutine that has almost zero locking in 1.11 - I've mostly fixed this in master (1.12) - that goes around checking if PRs have been merged. If the checker starts during the PR merging phase and runs at or around the same as the PR being merged - it can see the commit in the git repository and think that the commit has been merged manually. At which point I could imagine it might incorrectly update the MergeBase.

Aah right, indeed there is a status == 3 on a recent 'bad' one.

These two PRs were created and merged today. 556 contained one commit from a branch into dev, and 557 was another PR to merge that into aws which contained a commit and the merge commit from 556. No branches have been deleted at this stage.

OK that means it is very likely to be the checker.

Aah okay, would you reckon to see a lot of manually merged PRs? (what triggers it?)
For reference I have quite a few!

OK so I think I've worked it out:
https://github.com/go-gitea/gitea/blob/139fc7cfee2b872a99a1866ded8bc1f9a43c4c20/services/pull/check.go#L187-L218
This is the checker from release/v1.11. As I've said before there is a race in this code - it's possible to run this as the PR is being merged or just after it is merged.
Line 203:
https://github.com/go-gitea/gitea/blob/139fc7cfee2b872a99a1866ded8bc1f9a43c4c20/services/pull/check.go#L203
Calls TestPatch here:
https://github.com/go-gitea/gitea/blob/139fc7cfee2b872a99a1866ded8bc1f9a43c4c20/services/pull/patch.go#L71-L215
Which updates the pr.MergeBase - but as I say above this can end up being after the PR is merged.
Finally the checker calls:
https://github.com/go-gitea/gitea/blob/139fc7cfee2b872a99a1866ded8bc1f9a43c4c20/services/pull/check.go#L211
https://github.com/go-gitea/gitea/blob/139fc7cfee2b872a99a1866ded8bc1f9a43c4c20/services/pull/check.go#L40-L54
which will update the PR without checking if it is merged or not.
The situation is similar on 1.12 but happens less frequently because we're attempting to prevent some of the raceyness.
I think the answer is to change from pr.UpdateCols to:
// UpdateColsIfNotMerged updates specific fields of a pull request if it has not been merged
func (pr *PullRequest) UpdateColsIfNotMerged(cols ...string) error {
	_, err := x.Where("id = ? AND has_merged = ?", pr.ID, false).Cols(cols...).Update(pr)
	return err
}

would it be possible for any of you to test those PRs? I think that they should fix the problem.

I can try and test the backport by building a new Docker image. I'll try and report back tonight or tomorrow if it's worked. 👍

7 PRs down and I've not seen a zeroed one yet. Thanks Zeripath!

Still sorry that I broke it. The broken PRs will be fixed when the migration in #10786 runs - but you might be able to backport the migration manually or fix the broken PRs in the db.
In case you're interested. The correct git command for finding the merge base is: (With $MERGE_COMMIT_ID and $PR_ID as appropriate)
git merge-base $(git rev-list --parents -n 1 $MERGE_COMMIT_ID) refs/pull/$PR_ID/head

There's nothing to be sorry about, we all make small mistakes here and there. I'm very appreciative of all the work done in an open source project - voluntary work is very respectable and I can see it being a bit of a thankless job at times. Where our team doesn't pay for Gitea (and I'm unfortunately not somebody with financial power to sponsor/donate) I can't expect a support team dedicated to fix things for me 🙂
That said I try and 'pay my debts' to the community that's helped me, so making PRs and generally improving Gitea is in my interest too. Win win!

Hello friends, I found this problem seems like still happens in Gitea v1.11.4
My environment is:
- Gitea version: v1.11.4
- Git version: 2.23.0.windows.1
- Operating system: Windows Server 2008 R2 64bit
- Database: MySQL

A recent pull request:

An old pull request:

you have to manualy fix them - a gitea doctor task for this will be in 1.11.5

@tanrui8765 https://github.com/go-gitea/gitea/pull/10991

ok, got it, thanks~~ @6543

@6543
Hello friend, I deployed the gitea version V1.11.5, and tried to use gitea doctor task to check this problem, the results was OK, but the problem still exist on our gitea repo.
Could you please tell me what to do to manually fix these problems?
Many Thanks

./gitea doctor --all --fix @tanrui8765

Thank you very much @6543, it worked~


CLAS, DDLS, DDLX and DCLS: Deserialization is called twice

It seems all object types with more than one file are affected.
https://github.com/larshp/abapGit/blob/06616580eb500d94d1d6ca165638c7c4ac01cf61/src/zcl_abapgit_objects.clas.abap#L672-L676
Introduced with
https://github.com/larshp/abapGit/commit/a3d26b99016d527d00847948b60ba9c92ec9d443

https://github.com/larshp/abapGit/pull/1529

Ok it seems not ok for all scenarios.


Update keras.md

Use context manager in example

Closing in favor of https://github.com/iterative/dvc.org/pull/4367


Add checks for in-use I2C pins and no I2C pins defined for the board.

Fixes #900

Before adding an LCD display check for I2C pins being defined in the board definition file. If there aren't any then throw an error.
When adding an LCD display check to see if any of the I2C pins are already assigned to non-I2C devices. If yes throw an error.

@DocMoebiuz This needs German translations for the two new error messages and two new error message titles.


Check measure display names

You can probably just check the measures.json file in the mpog_pilot branch of the KB
See MPOG measure specs

ABX01 has the full measure ABX-01-OB: ... in the name. No other measure does, but this matches the MPOG measure specs

Minutes spec'ed on BP-01 but not BP-03: Low MAP Prevention < 65 (15 minutes)

FLuid01 is "Card: Minimizing Colloid Use (Cardiac): MPOG Spec is "FLUID-01-C : Minimizing Colloid Use, Cardiac"

GLU-02, we say "Hyper..." MPOG says GLU-02: Hypoglycemia Management, Intraop (<60 mg/dL)

We don't include the volume...
Mpog has
PUL-01: Protective Tidal Volume, 10 mL/kg PBW
PUL-02: Protective Tidal Volume, 8 mL/kg PBW


Update CSV file for 0.3.0 and new namespace

Codecov Report

Merging #318 (a9557ee) into master (03ec5ca) will increase coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   41.36%   41.56%   +0.19%
==========================================
  Files           9        9
  Lines        1697     1689       -8
==========================================
  Hits          702      702
+ Misses        958      950       -8
  Partials       37       37

Impacted Files
Coverage Δ

controllers/velero.go
35.78% <0.00%> (ø)

controllers/velero_controller.go
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ee1df...a9557ee. Read the comment docs.

/test operator-e2e

/override ci/prow/operator-e2e


Collision events are sent when not actually in contact

Collision events are currently sent for contacts where the distance is below NarrowPhaseConfig.prediction_distance, but not necessarily touching. This can lead to unexpected event triggers as reported by @COCPORN in a situation where a ball sometimes bounces off of an object that despawns on contact and sometimes not.
Collision events should only be sent for contacts that are actually touching.
For now, you can get around the issue with this:
.insert_resource(NarrowPhaseConfig {
    prediction_distance: 0.0,
})

but it can cause contact stability issues in cases where moving bodies bump into each other.

I also just want to say that it is actually quite nice to be able to query for "almost" collisions, like how it works now. Of course this should be fixed but there is also definitely a use case for the way that it works currently, as well. So maybe an unwarranted suggestion but maybe when this does get fixed, also add in a way to query for potential collisions within the prediction distance too?
Some use cases:

Ground detection: It's nice to have a bit of leeway when performing ground detection, I personally just use contacts and coyote time, but I know raycasting is also a common method to look for ground detection, and this would be a similar way to do it as shape/ray casting, but better since you don't have to do an additional query, and it covers the exact shape of the colldier.

Wall Detection: Sometimes when directly next to a wall, if there isn't some force pressing you directly up against the wall, there will be no collision between the target body and the wall since the solver has moved the body to no longer be intersecting with the wall.

This should be fixed by #385. For those use cases I would still recommend using spatial queries like ray casts or shape casts, or even sensors that act as the "enlarged" collider.


无法参与

discord 无法接受邀请，有没有其他的平台供交流

Please use this link: https://discord.com/invite/rqw8dnM8
There are also discussions here on github

Please use this link: https://discord.com/invite/rqw8dnM8
There are also discussions here on github

First of all, thank you very much, but I don't know why this is still happening.The hope is that the project will be mature quicklily enough  make it easier for public to use it.


And.controlled and MultiAnd.controlled should return MultiAnd

related to https://github.com/quantumlib/Qualtran/issues/1271 and https://github.com/quantumlib/Qualtran/issues/1272

Why did you close this?

I thought this use case doesn't follow the controlled protocol ... the _add_ctrled  method for And and MultiAnd doesn't follow the expected signature from your comment https://github.com/quantumlib/Qualtran/issues/1272#issuecomment-2297466324

Can you offer your thoughts on #1304 or provide context for where you want to do And().controlled()

I wrote some more here: https://github.com/quantumlib/Qualtran/issues/1304#issuecomment-2307862322
The contract (irrespective of whether the registers are RIGHT or THRU) is that the controlled version can only add new registers that comport with CtrlSpec.qdtypes. The system has no idea what to do with the extra junk registers. If you wanted to encode the idea that "this junk needs to get cleaned up by And^dag" you'd use something like #1221


build: update circleci config to 2.1

Seems there is some glitch with CircleCI it never detected my other PR / branch #185 so copying here.
I wonder if it has to due with using a period in the branch name which confused it.

Pull Request Test Coverage Report for Build 231

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.185%

Totals

Change from base Build 226:
0.0%

Covered Lines:
371

Relevant Lines:
528

💛  - Coveralls

:tada: This PR is included in version 0.201.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Does not catch 'expected 1 selector or at-rule'

I have a vagrant up build, which is automated via puppet. During a corresponding build, I got an error:
$ vagrant up
[...UNRELATED BUILD OMITTED...]
==> main: Notice: /Stage[main]/Compiler::Start_browserify/Service[browserify]/ensure: ensure changed 'stopped' to 'running'
==> main: Notice: /Stage[main]/Compiler::Start_imagemin/Service[imagemin]/ensure: ensure changed 'stopped' to 'running'
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[touch-jsx-files]/returns: executed successfully
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns: {
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns:   "status": 1,
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns:   "file": "/vagrant/src/scss/style.scss",
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns:   "line": 20,
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns:   "column": 2,
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns:   "message": "Invalid CSS after \"}\": expected 1 selector or at-rule, was \"a: {\"",
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns:   "formatted": "Error: Invalid CSS after \"}\": expected 1 selector or at-rule, was \"a: {\"\n        on line 20 of ../../vagrant/src/scss/style.scss\n>> }\n   -^\n"
==> main: Notice: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns: }
==> main: Error: node-sass /vagrant/src/scss/style.scss /vagrant/interface/static/css/style.css returned 1 instead of one of [0]
==> main: Error: /Stage[main]/Compiler::Initial_compile/Exec[node-sass-initial-compile]/returns: change from notrun to 0 failed: node-sass /vagrant/src/scss/style.scss /vagrant/interface/static/css/style.css returned 1 instead of one of [0]
==> main: Notice: /Stage[main]/Webserver::Service/File[/etc/init/start_gunicorn.conf]: Dependency Exec[node-sass-initial-compile] has failures: true
==> main: Warning: /Stage[main]/Webserver::Service/File[/etc/init/start_gunicorn.conf]: Skipping because of failed dependencies
==> main: Notice: /Stage[main]/Webserver::Start/Service[start_gunicorn]: Dependency Exec[node-sass-initial-compile] has failures: true
==> main: Warning: /Stage[main]/Webserver::Start/Service[start_gunicorn]: Skipping because of failed dependencies
==> main: Notice: Applied catalog in 824.24 seconds
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

However, the corresponding scss-lint, executed via travis ci did not indicate any kind of warning, or error. Is my scss-lint gem package, outdated at 0.38.0, or is this a check that should already exist?

Never mind, had VendorPrefix flagged off during lint.


[BUG] With Ready Set Roll it duplicates the chat message for feature/spell on item

Module Version: v1.3.2
Describe the bug
This bug creates 2 chat logs for every time you use a feature or spell and makes nulls one of the chat logs ability to make targets roll save, take damage, heal, or apply effect.
To Reproduce
Steps to reproduce the behavior:

Create an item
Give the item a spell or feature
Give the item to a character
Have the character use the spell or feature
2 chat logs of that spell or feature shows up and only one can be used, the other is an error

Expected behavior
The item feature/spell should only give one chat prompt that allows targets to click on to roll for a save, as well as to click on if there is an effect to give if they fail. This bug also removes the most current chat of the two saying that it isn't attached to an item anymore
Screenshots

That one is if you click the lower chat log save.

Foundry Version: Version 11, latest Module update
Additional context
Ready Set Roll 2.1.2 is the only module that does anything with chat logs for features and spells.

This was left in magic items 1 as a comment that may possibly solve the issue?
"Hey I just stumbled into this issue not being solved after 2 months. As a fellow developer I know it is easy to throw "compatibility issue" onto other software, but I think the solution here is fairly simple.
I glanced through the code for the module and found code that seem to cause the issue. In OwnedMagicItemSpell.roll().proceed() it calls ChatMessage.create(_) directly, so adding simple condition check here to not post your own message when RSR is enabled would probably solve all issues with doubled chat card."

https://github.com/MangoFVTT/fvtt-ready-set-roll-5e/issues/91

Should be fixed in https://github.com/PwQt/magic-items-2/releases/tag/1.4.0

This did not seem to work for me, updating to 1.4.0 but thank you for the effort!

Issue still exists in 1.4.4


[ZEPPELIN-5053]. Transfer Zeppelin server configuration to a remote interpreter

What is this PR for?
This PR add method init to pass ZeppelinConfiguration in the thrift interface between zeppelin server and interpreter process. And put lifecycle manager initialization in the init method. Zeppelin server will call this init method after interpreter process is started (register with zeppelin server)
What type of PR is it?
[Bug Fix ]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5053

How should this be tested?

https://travis-ci.org/github/zjffdu/zeppelin/builds/730513842

Screenshots (if appropriate)
Questions:

Does the licenses files need update? NO
Is there breaking changes for older versions? NO
Does this needs documentation? No

When this is ready for review, let me know.

@Reamer CI is passed，could you help review and verify it on k8s ?

@Reamer CI is passed，could you help review and verify it on k8s ?

I will test this on K8s today.

@Reamer CI is passed，could you help review and verify it on k8s ?

I will test this on K8s today.

Hi @zjffdu,
I have tested it on K8s. Unfortunately it does not work.
INFO [2020-09-28 15:51:07,059] ({pool-3-thread-2} RemoteInterpreterServer.java[createLifecycleManager]:374) - Creating interpreter lifecycle manager: org.apache.zeppelin.interpreter.lifecycle.NullLifecycleManager

I have found the reason for this. At the moment I have configured Zeppelin only via the environment variable, as described in our example. If you have no configuration file properties are empty.
I see two ways to solve this problem.

Load the same environment key value map into the interpreter pod -> very easy and secure. Just copy this part into interpreter-spec.yaml
Filling properties during startup in the Zeppelin server

Thanks @Reamer for the testing, I would prefer the second approach. Because I think this not only happens in k8s, in other modes it also possible to define configuration via env.

@Reamer I have fixed that in another commit, please help try that in k8s.

Thanks @Reamer for the testing, I would prefer the second approach. Because I think this not only happens in k8s, in other modes it also possible to define configuration via env.

You are right, we should also find a solution for other modes.

@Reamer I have fixed that in another commit, please help try that in k8s.

Now it works on K8s with an environment configuration setup.

Will merge it if no more comment


Add cosmoDC2 documentation

This PR adds cosmoDC2 documentation. The content is mostly copied from https://portal.nersc.gov/project/lsst/cosmoDC2/_README.html but with updated instrcutions or links to existing instructions in the repo.
Fixes #6

About those README files - I'm assuming these copies from the old portal should be removed from the globus endpoint area?
/global/cfs/cdirs/lsst/gsharing/lsstdesc-public/dc2/cosmoDC2_v1.1.4/_README.html
/global/cfs/cdirs/lsst/gsharing/lsstdesc-public/dc2/cosmoDC2_v1.1.4/_README.md

About those README files - I'm assuming these copies from the old portal should be removed from the globus endpoint area?
/global/cfs/cdirs/lsst/gsharing/lsstdesc-public/dc2/cosmoDC2_v1.1.4/_README.html
/global/cfs/cdirs/lsst/gsharing/lsstdesc-public/dc2/cosmoDC2_v1.1.4/_README.md

Yes. These two are the files to be removed.

Yes. These two are the files to be removed.

Ok - those are now removed.  Now pushed to the dev portal: http://lb.desc-web-dev.production.svc.spin.nersc.org/
LGTM

Ok - those are now removed.  Now pushed to the dev portal: http://lb.desc-web-dev.production.svc.spin.nersc.org/
LGTM

Thanks, Heather!

Thanks, Heather!


Allow same url routes to be cached when domain is different

I was trying to use php artisan route:cache and an exception was thrown:
[Exception]
Serialization of 'Closure' is not allowed

After some research, I found out that using php artisan config:cache with php artisan route:cache when using two routes sharing the same url but on two different domains do not work:
Route::group(['domain' => 'app.liftmap.com'], function() {
    Route::get('/', 'AppController@index')->name('application');
});

Route::group(['domain' => 'liftmap.com'], function() {
    Route::get('/', 'AppController@index')->name('application');
});

It works fine when using only php artisan route:cache but not in combination with php artisan config:cache
Is there a way to allow the use of both php artisan route:cache and php artisan config:cache?
Thanks!

Route and Config caching are separate operations, hence it's highly unlikely that one causes another to fail.
Check if you have any routes that use a Closure(anonymous function).
You can do that by running php artisan route:list and looking for Closure word in Action column.
Calling route:cache basically serializes the Router object that is built based on your route definitions.
To do that, Laravel uses serialize method which converts an object to a string. Because PHP doesn't support Closure serialization, in order to cache your routes, you need to use only controller routes.

You cannot use closures for routing if you want to use route caching.

@GrahamCampbell Thanks, but I can read an exception message.
@KKSzymanowski Thanks for you reply. It seems like one of them affects the other though.
I have no routes using a closure

But still, when running php artisan route:cache with no other type of caching, works fine. When running php artisan route:cache after running php artisan config:cache, does not work anymore.

If I delete the bootstrap/cache/config.php file, works perfectly fine. This issue seems to come from having two routes with the same path, just not on the same domain. If I deactivate any of the following routes, php artisan route:cache works fine.

Also, I was loading my domains from the .env file:
MAIN_DOMAIN=liftmap.dev
APP_DOMAIN=app.liftmap.dev

I tried replacing the calls to env('MAIN_DOMAIN') and env('APP_DOMAIN') by plain text domains in the route group I had, now php artisan route:cache works fine, even when using php artisan config:cache before. So it seems like we cannot use closure BUT ALSO we cannot use env() to load domain information when using php artisan route:cache.

In the example of route definitions you provided there is no env call. How does it look like with env calls?

@KKSzymanowski I am using route group in my RouteServiceProvider:
    /**
     * Register application routes
     */
    private function registerAppRoutes()
    {
        Route::group(['middleware' => ['web'], 'domain' => env('MAIN_DOMAIN')], function () {
            Route::group(['middleware' => ['guest']], function () {
                require base_path('routes/guest.php');
            });
            Route::group(['middleware' => ['auth']], function () {
                require base_path('routes/auth.php');
            });
        });
        Route::group(['middleware' => ['web', 'auth'], 'domain' => env('APP_DOMAIN')], function () {
            require base_path('routes/app.php');
        });
    }

Replacing the env() calls in this method by plain text version of the domains works fine, but I need to keep this information in the .env as it is environment dependant.

I'm sorry but I cannot recreate this error. I setup following routes in RouteServiceProvider:
public function map()
{
    Route::group(['middleware' => ['web'], 'domain' => env('MAIN_DOMAIN')], function () {
        Route::group(['middleware' => ['guest']], function () {
            Route::get('/', 'App\Http\Controllers\InquiryController@index');
        });
        Route::group(['middleware' => ['auth']], function () {
            Route::get('/a', 'App\Http\Controllers\InquiryController@create');
        });
    });
    Route::group(['middleware' => ['web', 'auth'], 'domain' => env('APP_DOMAIN')], function () {
        Route::get('/b/{id}', 'App\Http\Controllers\InquiryController@show');
    });

Then in .env file:
APP_DOMAIN="app.liftmap.com"
MAIN_DOMAIN="liftmap.com"

Then I ran:

and everything works fine. Same without config caching.
Can you try to extract some functionality to a separate test project to recreate this error?

Or maybe look in storage/logs for this exception to view the stack trace and find out what is being serialized that is a Closure.

I reproduced it in a fresh app using 5.3. The issue seems to come when using two routes, same path but different domains, pointing to different actions:
This works
Route::group(['domain' => env('MAIN_DOMAIN')], function () {
    Route::get('/', 'TestController@index');
});
Route::group(['domain' => env('APP_DOMAIN')], function () {
    Route::get('/', 'TestController@index');
});

This DOES NOT work
Route::group(['domain' => env('MAIN_DOMAIN')], function () {
    Route::get('/', 'TestController@index');
});
Route::group(['domain' => env('APP_DOMAIN')], function () {
    Route::get('/', 'TestController@guest');
});

Interesting that when I remove bootstrap/cache/config.php it works though. I only run in this issue if running both php artisan config:cache and php artisan route:cache.
Here is a repo demonstrating the issue: https://github.com/foxted/Route-Caching-Issue

First of all, @GrahamCampbell, this is a bug in the framework, don't jump to conclusions too soon. Even if author did something wrong there obviously should be more informative message.
Most importantly @foxted, I found a solution to your problem.

Rename .env.example to .env - that's kinda obvious
Create file config/routing.php

<?php

return [
    'main_domain' => env('MAIN_DOMAIN'),
    'app_domain' => env('APP_DOMAIN'),
];

Change routes to:

Route::group(['domain' => config('routing.main_domain')], function () {
	Route::get('/', 'TestController@index');
});
Route::group(['domain' => config('routing.app_domain')], function () {
	Route::get('/', 'TestController@guest');
});

After that everything works great.
Thing is config:cache caches only config/* files, not .env files so you have to use your enviroment variables through config in order to be able to cache them.
To prove that this is a bug in the framework here are dumps of RouteCollection objects that the RouteCacheCommand tries to serialize.

Using ENV, Without config cache
Using ENV, WIth config cache
Not using ENV, Without config cache,
Not using ENV, With config cache

Last two are the same - it's expected.
First two, well here's the funny story, with config cache, dumped RouteCollection objects takes 5.8 MB(and contains > 2000 Closures) and without it, it takes 8.3 kB(and doesn't contain any Closures).
Graham, I leave you with examining it, for you now far better what is supposed to be in the RouteCollection object.
To get these dumps I added var_dump(not dd to get results without coloring) here:
protected function buildRouteCacheFile(RouteCollection $routes) {
	$stub = $this->files->get(__DIR__ . '/stubs/routes.stub');

	var_dump($routes);
	die;

	return str_replace('{{routes}}', base64_encode(serialize($routes)), $stub);
}

in Illuminate\Foundation\Console\RouteCacheCommand
with-env.with-config.txt
with-env.without-config.txt
without-env.with-config.txt
without-env.without-config.txt

@KKSzymanowski Thanks for investigating. Of course I had a .env, just not published in the example :octocat:
According to your finding, it does seem like the config:cache somehow affects the RouteCollection.
Interesting!


Investigate octokit and rate limiting

We ran into rate limiting (returning 403) from the Github API with octokit, investigate to see what the limit is and if it's too low looking into including the dataset in the deploy.
If the rate limit isn't too low this would be the better solution but we'd need some nice handling / messaging.

Current unauthenticated limit is "For unauthenticated requests, the rate limit allows for up to 60 requests per hour. Unauthenticated requests are associated with the originating IP address, and not the user making requests."

Currently looking into a way to see if I can securely authenticate the request without publicly hard coding a token...

I've added a personal access token, which only has read access to public repos, not best practice but it should be fine to go into prod

Looks like we're going to have to live with the 60 limit, just need to add better handling


Spec is really bad in the sense that it just lists IDL and doesn't explain any use-case for the objects

Like 2.3 Range in common.
If you look at it, you have absolutely no idea what it is supposed to be used for.

Yep, that's true. We're currently using a spec-style document for reference only... :)


Lyla/enable views

"Vertical" is a very basic parent xblock that does not implement very many views. Of special concern is an authoring view. For an xblock developer who wants to implement views that 'vertical' does not have (especially authoring views), the fact that their xblock is wrapped up by default in a parent that does not implement that view means that they have to remove the xblock from that wrapper in order to use the sdk functionality that allows them to inspect non-student_view views. This pull request removes the dependency on 'vertical' for the default cookie-cutter xblock.

Thanks for the pull request, @Lyla-Fischer! I've created OSPR-890 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
We can't start reviewing your pull request until you've   added yourself to the AUTHORS file . Please see the CONTRIBUTING file for more information.

@tusbar / @stvstnfrd - would you guys mind reviewing this?
@Lyla-Fischer Please remember we follow a rebasing, not merge, workflow, so please rebase your branch atop master (rather than merging "branch master" - this leads to a cluttered commit history). See https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

This PR is conflicting with @stvstnfrd’s (https://github.com/edx/xblock-sdk/pull/69).

Rather than figuring out how to rebase after I've merged, I'll create a new pull request after we resolve the "should this even happen" question.

Rebasing after merging master is easy, and will have the nice side effect of removing the merge commit.

@nedbat could you please have a moment to weigh in to the questions asked on this pr

It's going to take me some time to get to this.... :(

Perhaps we can solve this problem in a different way: we can have more than one default scenario generated by cookiecutter.  Would it be bad to have both a single, standalone scenario; and a vertical with three stack blocks scenario?  The first would give you an direct view of your block, free of insufficient intermediaries.  The second would give you an LMS-centric view of the block.

@Lyla-Fischer btw, I can help with the rebasing if you find me on some realtime channel (Slack, IRC, carrier pigeon, whatever).

Added.

The two commits of interest touch the same code, so I just created a new pull request https://github.com/edx/xblock-sdk/pull/93 with a smaller and more compact version of the changes.


Fix vm restore in case of restore size bigger then PVC requested size

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=2086825
Special notes for your reviewer:
Copy of https://github.com/kubevirt/kubevirt/pull/7920 which needs a rebase
Release note:

BugFix: Fix vm restore in case of restore size bigger then PVC requested size

/lgtm
/approve

/test pull-kubevirt-e2e-windows2016
Queued windows jobs had to be cleared due to priority change.

/cherrypick release-0.53


[Task] Interactive command - erase: Erase data

What should be done
Implement the erase interactive command.
It erases all the databases data (PostgreSQL and MongoDB).
Technical recommandation
Drop Mongo's app databse and delete all postgres app users.
Is this task linked with any other ?
Blocked by https://github.com/lenra-io/lenra_cli/issues/21

For Postgres, use mix Ecto.reset() (or equivalent in the released app).


Merge develop branch to v2 branch

Codecov Report

Merging #2457 (bb8de91) into v2 (9c510e2) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v2    #2457      +/-   ##
==========================================
- Coverage   97.65%   97.62%   -0.03%
==========================================
  Files          57       57
  Lines       10823    10823
==========================================
- Hits        10569    10566       -3
- Misses        254      257       +3

Impacted Files
Coverage Δ

botocore/httpsession.py
92.55% <0.00%> (-0.47%)
:arrow_down:

botocore/utils.py
96.84% <0.00%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c510e2...bb8de91. Read the comment docs.


Cancel the workflows in progress in newer build is about to start

Codecov Report

Merging #11 (7c465ae) into master (ce76b90) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 7c465ae differs from pull request most recent head 8834a8b. Consider uploading reports for the commit 8834a8b to get more accurate results

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   92.02%   92.02%
=======================================
  Files           6        6
  Lines         188      188
=======================================
  Hits          173      173
  Misses          9        9
  Partials        6        6

Flag
Coverage Δ

unittests
92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce76b90...8834a8b. Read the comment docs.


I think a timeout of 0 should disable timeouts

this would reflect's puppeteer's use of the timeout option where if 0 is passed the timeout is never triggered. This is useful for some long-running tasks.
Example usage:
    const c: Cluster<PdfTaskData, void> = await Cluster.launch({
      concurrency: Cluster.CONCURRENCY_PAGE,
      maxConcurrency: 1,
      timeout: 0,
      puppeteerOptions: {
        headless: true,
        timeout: 0,
        args: ["--no-sandbox", "--disable-setuid-sandbox"],
      },
    });

with the example above, currently any task will fail. Desired behavior would be that timeouts will never trigger.

I'm happy to open a PR if others also think this should be the case but want to hear if there are any differing opinions first

That would be great. Smaller than zero, like -1 would disable it, won't it?
0 timeout not timing out is often used in testing

yea that would be great to have


[Release] Minimum number of admins

Context
Hosts can now request that Collectives signing up have a minimum number of administrators. New Collectives are encouraged to invite admins when joining a host. Hosts can limit the ability for Collectives to accept money until they have the minimum number of admins.
Project issue: #3593
What's being released?

Updated setting for host admins
Updated process for creating and joining hosts
Limits for Collectives not meeting minimum number of admins criteria
Is this change being released incrementally as a beta? What's the schedule?

Releasing to all hosts who can enable on a case by case basis
Is this release optional or mandatory?

Optional
Who does this release impact?

Hosts, collective admins
When will the project be ready for release?

ASAP
Product Process

[x] Documentation check

[x] host policy https://docs.opencollective.com/help/fiscal-hosts/fiscal-host-settings/policies
[x] host application process https://app.gitbook.com/o/-LWSZizNMEjL8_DrMNdF/s/-LWSZizTt4ZC1UNDV89f/~/diff/~/changes/xHPgzRXP5NSalAEwLXmN/collectives/add-fiscal-host

[ ] Release 🔥 post on Open Collective
[ ] Announcement (update) for Open Source Collective and Open Collective Foundation when implementing

Related releases

two to sign https://opencollective.com/opencollective/updates/two-to-sign-features-on-open-collective

Release post(s)

https://opencollective.com/opencollective/updates/invite-administrators-when-applying-to-a-host
Social Media

I hope this is the right place to post this update; after undertaking a QA round of the latest design file, some details changed slightly to account for text readability and better spacing/padding. Plus, we can use our updated form components to design consistently going forward.
These changes don't seem too complex. I really hope someone can do this update soon 😃 At least as a papercut for next sprint

Before (Version in production)
After

Settings

Improved spacing. Used updated form fields

Edit member modal

Improved vertical spacing. Better text legibility (Help text)

Apply to fiscal host modal

Improved text legibility. Improved spacing. Used updated form components

Figma file in production-ready
@kewitz @SudharakaP @aminakazi


Add net6.0 TFM to tools

Add a net6.0 TFM for the .NET tools.
I've been playing with crank in GitHub Actions today with a repo that only uses .NET 6, and as .NET 5 wasn't installed as well, the tools would fail to run.
You can work around this by setting DOTNET_ROLL_FORWARD=Major so you don't need to install the .NET 5 runtime as well, but adding the additional TFM should make them Just Work™ without the need to do that either.

I didn't think you could multi-target a dotnet tool 🤦


feat(framework): rounded table variant

closed DEV-9107

Looks good! I kind of hate that Th elements are capitalized, but not sure if that's related to this PR.


Question: Is there reason for not using smaller Alpine based python as base image for httpbin

Current httpbin docker uses ubuntu has base image, once it is built image size weigh approx 600 MB.
Is there reason for not using smaller Alpine based python as base image,. Alpine base image with python3 & pips is only 52 MB
docker pull python:3.12.0a4-alpine3.17

Some reasons are discussed in this article https://pythonspeed.com/articles/alpine-docker-python/


Seed endpoint

Allow for seeding without AppSettings. Pass in values in request body.
Description
For Reference: HDS-169

[x] I have updated the acceptance criteria on the task so that it can be tested

Can you update to optionally generate currency? Looks like the exchange rates method is still getting called.
Also, I just got feedback that my PR for optionally using azure app configuration isn't quite working. I will make a PR soon but we'll want to make sure that all of this works if loaded from a json file instead of azure app configuration so we might want to pull that change in first


Update .gitignore

Fixes # .
Motivation

Solution

Open questions

Codecov Report

Merging #2081 (71da7d2) into master (a264250) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2081   +/-   ##
=======================================
  Coverage   98.48%   98.48%
=======================================
  Files         102      102
  Lines        1918     1918
  Branches      404      404
=======================================
  Hits         1889     1889
  Misses         13       13
  Partials       16       16

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Package['wget'] already declared

For version <= 2.3.6: When using multiple classes (modules) on the same server (=server role), the package declaration for wget can also be made elsewhere, resulting in:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: Package[wget] is already declared; cannot redeclare at /etc/puppetlabs/puppet/environments/core/modules/gitlab/manifests/install.pp:183
The correct way to implement the download would be to support both curl as well as wget. As a workaround you could test for the package declaration using stdlib defined().

Sorry, I see it's already fixed.

This module is currently undergoing an overhaul because gitlab changed their package names. Soon it shouldn't even require curl or wget because they finally added repos.

The module doesn't yet work with the 7.10.x releases of gitlab, only 7.0.x


What is the least expensive way to make bodies of different shapes smaller?

I'm using the circleRadius property to make circular bodies smaller. Are there similar properties for rectangles and polygons?
Scaling is not suitable because there is a large load on the processor.

Use surface
l^2 = S
where S is square surface
substitute r or S on code


Cleanup, async/await & let/const

hi @Quramy,
i made some further changes. mainly to async/await. but also some cleanup and the use of let/const.
for review it is probably worth looking at the changes at each commit one by one, as they are not a lot. the whole diff looks overwhelming and is not reflecting the steps well.

ahhh, i just noticed utils.promisify is not available in node 6. so test is failing. i will do a custom promisification.
would you generally be open to the changes? i think it is nice as it reduces the lines of code, by keeping the functionality.

hey @Quramy,
what do you think about async/await?

@gdelmas Sorry for my late reply :bow:
I like async/await syntax too.
And for now unit testing is run in Node.js v6 env, but I think almost dev uses Node >= v8. So we no longer need to support v6.

You can remove https://github.com/Quramy/typed-css-modules/blob/master/.travis.yml#L9 and use promisify.

hey @Quramy,
great to hear from you and happy you also like async/await better. you are completely right, without node6 support there is less code to maintain. i added a new commit to remove node6 support, where i also added the required node version to package.json so that some developer installing this might get a warning. i kept the commit with node6 support in the history, in case someone needs it and wants to fork.

Thanks for your great work!!!

I've published this as v0.5.0 🎉

amazing, thanks @Quramy


Upgrade Spring Boot to the latest version

Update the guide to use the most recent Spring Boot version.
To do so, change the Spring Boot version in:
initial/build.gradle
initial/pom.xml
complete/build.gradle
complete/pom.xml

Dependabot is now configured for this repository. This will be managed at a higher level going forward.


build: support for asan/tsan/msan/ubsan sanitizers

updated version of #89, hopefully building on Travis.

@dho : I simplified the logic a little bit, let me know if you see something fishy.

The only reason that I had these broken out is because some options conflict. (For example, it is not possible to build with asan and msan at the same time, and I believe some other combinations are invalid as well). That said, I'm happy for this to be cleaner since basically nobody should be building these things for a production deployment anyway.
IOW: looks good to me.

Well, I didn't change the setting logic, it's just a bit more compact know. Anyway, closing, as I pushed it on v-c's github.
Thanks!


[SPARK-25142][PYSPARK] Add error messages when Python worker could not open socket in _load_from_socket.

What changes were proposed in this pull request?
Sometimes Python worker can't open socket in _load_from_socket for some reason, but it's difficult to figure out the reason because the exception doesn't even contain the messages from socket.errors.
We should at least add the error messages when raising the exception.
How was this patch tested?
Manually in my local environment.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2269/
Test PASSed.

Test build #94884 has started for PR 22132 at commit 16b4f72.

cc @HyukjinKwon


Feature request: Ability to focus single folder in file explorer

While working, would be pretty darn sweet if we could right click a folder and select an option like "Focused Folder/Directory" or something around those lines.
What this would do is single out this selected directory in your file explorer while collapsing everything else. So you would only see what you are interested in your file explorer (while still having the option to see everything else). This is essentially a filter on the explorer.

Dup of https://github.com/Microsoft/vscode/issues/28905


Node 14.15.0 Unable to send files with multipart formdata

Version: 14.15.0
Platform: Windows 10 2004
Subsystem:

What steps will reproduce the bug?
Uploading a file using express is not working anymore. The file is most of the time (sometimes it works, don't know why) not really sended correctly to the server. I tried using express-fileupload and multer but none of them are working properly.
It's not giving any error, just jamming there without log.

How often does it reproduce? Is there a required condition?
What is the expected behavior?
I expect the file to be on the webserver and my middlewares to continue the request with the file.

What do you see instead?
It it jamming at a point I don't know. All I can see is that if I use a temporary folder, the file is only there partly.

Additional information

The only way for me to get it working is now to downgrade the version of node to 12... Not much interesting.

Hi @superheri sorry you are having trouble. You need to open your issue up on the particular module you are using in order to handle the multipart formdata, though. Express itself does not and presents all uploads as a raw stream of bytes.

@dougwilson The problem exist whatever the library I use, express-fileupload and multer. No difference...

Ok, though both of those module use the same underlying multipart module: busboy. Can you try one that uses a completely different system, for example, https://www.npmjs.com/package/connect-multiparty ?

I will try this and see if it works.

@dougwilson I know it took some times to reply, but I tried using event connect-multiparty and it does not even work. So the bug is either with express or Node

Hi @superheri , Express itself does not provide any handling of request body data; if you are within an Express middleware, the req you have is the raw Node.js request, and the events to get the data (like 'data', 'end', etc.) are from Node.js itself. Express is just a router and a series of helper methods, but under the hood, the req and res objects you are getting are just those from Node.js directly.
If you think it is an Express issue, please provide code that reproduces and the steps to reproduce, but do not include any middleware not included from require('express'). If you are getting the error from using a middleware, you should report the issue to that middleware's GitHub tracker and the author(s) can then take their knowledge of how their middleware works to help track down if it is coming from their middleware or not, and if not, a reduced test case that demonstrates the issue without their middleware involved.


Custom Fancy Zones are deleted after every update

Microsoft PowerToys version
all the version
Running as admin

[X] Yes

Area(s) with issue?
FancyZones Editor
Steps to reproduce
Custom Fancy Zones are deleted after every update
✔ Expected Behavior
save the custom fancy zones
❌ Actual Behavior
custom fancy zones are not saved
Other Software
No response

Duplicate of #11427


Process: Improve dust-app and contextSize computation

Split very large docs before coalescing
Add factors to context size for non OAI model to avoid overflow

Also optimized user objective instructions: https://github.com/dust-tt/dust/pull/8503


Added share button

Added the feature as said in issue no. #141

@AtriSukul1508 kindly review

Hey @AtriSukul1508! Can you please change the label to gssoc23 instead of gssoc, it is not reflecting this way in the leaderboard!


Reset doesn't work for repeater fields

See https://github.com/aristath/kirki/issues/214#issuecomment-201986911

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Reset module was removed in v3.0.12 so I'm closing this ticket.
WP 4.9 adds changesets and many other improvements and a reset feature is planned in the future for WP-Core so keeping a buggy implementation in Kirki doesn't make any sense.


Drop Mesa workaround

Addressing #1701. Needs to be tested on various systems!

I was just testing around with the PC2 display on AMD Renoir  and noticed that most of the more fancy Styles seem to be unsupported with GLSL 1.5. Changing the Size has no effect for anything besides Points and it's always displayed as super tiny dots. I was not able to trigger any unusual behavior with the Points style
We have serious performance regressions with high resolution octomaps when limiting to the older shader versions though, that's why I opened the discussion.
[ INFO] [1644874202.850198482]: rviz version 1.14.14
[ INFO] [1644874202.850307278]: compiled against Qt version 5.12.8
[ INFO] [1644874202.850323799]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1644874202.865892892]: Forcing OpenGl version 0.
[ INFO] [1644874203.187769729]: Stereo is NOT SUPPORTED
[ INFO] [1644874203.187885107]: OpenGL device: AMD RENOIR (DRM 3.41.0, 5.13.0-28-generic, LLVM 12.0.0)
[ INFO] [1644874203.187928259]: OpenGl version: 4,6 (GLSL 4,6).

Interesting, I also tested that on Renoir and it did not work for me with Mesa 21, that's why I requested the workaround to be extended to all 2x versions.
https://github.com/ros-visualization/rviz/pull/1598

Your test was with Mesa 21.0.0 while the fix appeared in 21.0.3 (I'm not sure it has been pinpointed exactly but maybe I misunderstood something ...)

@simonschmeisser Good point, haven't noticed that... Could you put together a minimum working example? It's been some time since I was solving this, so I can't remember what were the steps to receive a failure...

I'm not sure I fully understood your comments. Thus, let me try to summarize. @peci1 and @simonschmeisser, please correct!

With Mesa < 21.0.3 we had a bug with PC2 display showing huge point sizes:
#1508
A corresponding test is available in src/test/send_point_cloud_2.py
Mesa 21.0.3 was fixing this and it is released, both for Bionic (via bionic-updates) and Focal (natively)
Hence, it should be safe to drop the Mesa workaround.
@simonschmeisser observed some new? issue on AMD Renoir, with PC2 display showing all styles other than points as tiny dots only, i.e. ignoring the size attribute
Is this reproducible on other graphic cards or is it specific to AMD? Please file a new issue for this.

Mesa 21.0.3 was fixing this and it is released, both for Bionic (via bionic-updates)

Bionic has only Mesa 20. So this fix hasn't been released there. I (and probably others) are using a customized Mesa PPA to get a newer Mesa on Bionic, as that's the only way to get the new Ryzen GPUs working (together with mainline kernels).

I tested on Bionic+Ryzen GPU+Mesa 21 with and without the Mesa workaround:
With workaround: everything works (I haven't tested performance, though).
Without workaround: Points are displayed with correct size, but there is this (new?) issue with everything except points displaying as a single white dot:

I'll open an issue for the "newly discovered" bug, but I think this PR needs to be hold off until that issue is solved.

Mesa 21.0.3 was fixing this and it is released, both for Bionic (via bionic-updates)

Bionic has only Mesa 20. So this fix hasn't been released there.

You are right. I was writing my comment in a rush obviously...

note that you can manually enforce an older OpenGL standard: rviz --opengl 310.

Yes, but this combines very badly with already existing launch files starting rviz. Maybe if it were an environment variable, it would be easier to set.

What about alias rviz='rviz --opengl 310' in your .bashrc?

<node name="rviz" pkg="rviz" type="rviz" args="-d path/to/config.rviz /> inside an (externally provided) launch file is the hard thing... the alias won't help there

Closing for now, as our GLSL 1.50 scripts are not Mesa-compatible yet.


[Build] Refactor project structure and refactor release tools

Purpose

Changes:

use pypaimon as package name and add necessary files
only build source release instead of wheel because we didn't depend on Cython
Move java bridge module out of python module
Add Github action for build source release

TODO:
Add a script tool for quickly building source release for locally testing or using
Modify API doc and build doc

Tests

API and Format

Documentation

+1


Resource missing in the UI

Just using default motor-admin without any customizations:
My model that is missing:
class Matter < ApplicationRecord
  include UniqueTokenOnCreate
  unique_token_options(name: :reference, length: 5)

  belongs_to :patient
  belongs_to :doctor, optional: true
  has_many :orders, dependent: :destroy
  has_many :matter_comments, dependent: :destroy

  has_one_attached :overview_image
  has_one_attached :dermatoscope_image

  def overview_image_url
    S3UrlHelper.url_for(overview_image)
  end

  def dermatoscope_image_url
    S3UrlHelper.url_for(dermatoscope_image)
  end

  enum :status, {
    pending_payment: 0,
    paid: 1,
    delivery_sent: 2,
    delivered: 3,
    pending_info: 4,
    pending_assessor: 5,
    assessment_started: 6,
    completed: 7,
  }, suffix: true

  enum :symptom, {
    itching: 0,
    bleeding: 1,
    irritation: 2,
    visible_change: 3,
    more_noticable: 4
  }, suffix: true

  enum :planned_action, {
    no: 0,
    biopsy: 1,
    control: 2,
  }, suffix: true

  enum :diagnosis, {
    nevus: 0,
    seborrheic_keratosis: 1,
    basal_cell_carcinoma: 2,
    benign_tumor: 3,
    lentigo_solaris: 4,
    melanoma: 5,
    nevus_deviant: 6,
    deramtofibroma: 7,
    vascular_lesion: 8,
    benign_lichenoid_keratosis: 9,
    actinic_keratosis: 10,
    malign_tumor: 11,
    pigmentation_deviant: 12,
    mb_bowen_disease: 13,
    inflammatory_papule: 14,
  }, suffix: true

  enum :tag, {
    svg_melanoma_recommendation: 0,
    follow_up_dermatoscopy_in_progress: 1,
    follow_up_dermatoscopy_done: 2,
    teaching_case: 3,
  }, suffix: true

  def self.ransackable_associations(auth_object = nil)
    ['doctor', 'patient']
  end

  def self.ransackable_attributes(auth_object = nil)
    ['created_at', 'diagnosis', 'doctor_id', 'id', 'patient_id', 'planned_action', 'status', 'symptom', 'updated_at']
  end

  def display_reference
    "##{reference.upcase}"
  end
end

Therefore, also the associations in the UI is missing
class Patient < ApplicationRecord
  belongs_to :user
  has_many :matters, dependent: :destroy
end

Did I miss anything?
motor-admin 0.4.11
rails <IP_ADDRESS>

@Frexuz there should be an error message regarding this model in your rails server stdout after you try to load the motor admin UI for the first time after boot.
At first glance the model looks good - idk what unique_token_options does - maybe it breaks the model

Thanks for the help :)
This 🤔 That's the :status enum
translation data {:assessment_started=>"Assessment started", :completed=>"Completed", :delivered=>"Package delivered", :delivery_sent=>"Package sent", :paid=>"Paid", :pending_assessor=>"Waiting for assessor", :pending_info=>"Waiting for case information", :pending_payment=>"Waiting for payment"} can not be used with :count => 1. key 'one' is missing.

Full output
19:55:40 web.1  | Started GET "/motor_admin/cable" for ::1 at 2023-05-20 19:55:40 +0800
19:55:40 web.1  | Started GET "/motor_admin/cable/" [WebSocket] for ::1 at 2023-05-20 19:55:40 +0800
19:55:40 web.1  | Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: websocket)
19:55:40 web.1  | Motor::NotificationsChannel is transmitting the subscription confirmation
19:55:41 web.1  | Started GET "/motor_admin/" for ::1 at 2023-05-20 19:55:41 +0800
19:55:41 web.1  | Processing by Motor::UiController#show as HTML
19:55:41 web.1  |   SQL (12.8ms)  SELECT 'configs', MAX(updated_at) FROM "motor_configs" UNION SELECT 'resources', MAX(updated_at) FROM "motor_resources" UNION SELECT 'dashboards', MAX(updated_at) FROM "motor_dashboards" UNION SELECT 'alerts', MAX(updated_at) FROM "motor_alerts" UNION SELECT 'queries', MAX(updated_at) FROM "motor_queries" UNION SELECT 'forms', MAX(updated_at) FROM "motor_forms" UNION SELECT 'api_configs', MAX(updated_at) FROM "motor_api_configs"
19:55:41 web.1  |   Motor::Config Load (0.2ms)  SELECT "motor_configs".* FROM "motor_configs"
19:55:41 web.1  |   TRANSACTION (0.1ms)  BEGIN
19:55:41 web.1  |   Motor::Query Load (0.3ms)  SELECT "motor_queries".* FROM "motor_queries" WHERE "motor_queries"."deleted_at" IS NULL
19:55:41 web.1  |   Motor::Alert Load (0.3ms)  SELECT "motor_alerts".* FROM "motor_alerts" WHERE "motor_alerts"."deleted_at" IS NULL
19:55:41 web.1  |   Motor::Dashboard Load (0.2ms)  SELECT "motor_dashboards".* FROM "motor_dashboards" WHERE "motor_dashboards"."deleted_at" IS NULL
19:55:41 web.1  |   Motor::Form Load (0.2ms)  SELECT "motor_forms".* FROM "motor_forms" WHERE "motor_forms"."deleted_at" IS NULL
19:55:41 web.1  |   CACHE Motor::Config Load (0.0ms)  SELECT "motor_configs".* FROM "motor_configs"
19:55:41 web.1  |   Motor::Resource Load (0.2ms)  SELECT "motor_resources".* FROM "motor_resources"
19:55:41 web.1  |   Motor::ApiConfig Load (0.2ms)  SELECT "motor_api_configs".* FROM "motor_api_configs" WHERE "motor_api_configs"."deleted_at" IS NULL
19:55:41 web.1  |   TRANSACTION (1.4ms)  COMMIT
19:55:41 web.1  |   Rendering layout /Users/frexuz/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/motor-admin-0.4.11/app/views/layouts/motor/application.html.erb
19:55:41 web.1  |   Rendering /Users/frexuz/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/motor-admin-0.4.11/app/views/motor/ui/show.html.erb within layouts/motor/application
19:55:41 web.1  |   Motor::Audit Count (2.6ms)  SELECT COUNT(*) FROM "motor_audits"
19:55:41 web.1  | translation data {:assessment_started=>"Assessment started", :completed=>"Completed", :delivered=>"Package delivered", :delivery_sent=>"Package sent", :paid=>"Paid", :pending_assessor=>"Waiting for assessor", :pending_info=>"Waiting for case information", :pending_payment=>"Waiting for payment"} can not be used with :count => 1. key 'one' is missing.
19:55:41 web.1  |   CACHE Motor::Resource Load (0.0ms)  SELECT "motor_resources".* FROM "motor_resources"
19:55:41 web.1  |   CACHE Motor::Query Load (0.0ms)  SELECT "motor_queries".* FROM "motor_queries" WHERE "motor_queries"."deleted_at" IS NULL
19:55:41 web.1  |   CACHE Motor::Dashboard Load (0.0ms)  SELECT "motor_dashboards".* FROM "motor_dashboards" WHERE "motor_dashboards"."deleted_at" IS NULL
19:55:41 web.1  |   CACHE Motor::Alert Load (0.0ms)  SELECT "motor_alerts".* FROM "motor_alerts" WHERE "motor_alerts"."deleted_at" IS NULL
19:55:41 web.1  |   CACHE Motor::Form Load (0.0ms)  SELECT "motor_forms".* FROM "motor_forms" WHERE "motor_forms"."deleted_at" IS NULL
19:55:41 web.1  |   Rendered /Users/frexuz/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/motor-admin-0.4.11/app/views/motor/ui/show.html.erb within layouts/motor/application (Duration: 364.5ms | Allocations: 521912)
19:55:41 web.1  |   Rendered layout /Users/frexuz/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/motor-admin-0.4.11/app/views/layouts/motor/application.html.erb (Duration: 382.9ms | Allocations: 534961)
19:55:41 web.1  | Completed 200 OK in 499ms (Views: 318.3ms | ActiveRecord: 132.3ms | Allocations: 589139)
19:55:41 web.1  |
19:55:41 web.1  |
19:55:41 web.1  | Finished "/motor_admin/cable/" [WebSocket] for ::1 at 2023-05-20 19:55:41 +0800
19:55:41 web.1  | Started GET "/motor_admin/cable" for ::1 at 2023-05-20 19:55:41 +0800
19:55:41 web.1  | Started GET "/motor_admin/api/notifications?page%5Blimit%5D=0&page%5Boffset%5D=0&filter%5Bstatus%5D=pending&meta=count" for ::1 at 2023-05-20 19:55:41 +0800
19:55:41 web.1  | Started GET "/motor_admin/cable/" [WebSocket] for ::1 at 2023-05-20 19:55:41 +0800
19:55:41 web.1  | Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: websocket)
19:55:41 web.1  | Processing by Motor::NotificationsController#index as HTML
19:55:41 web.1  |   Parameters: {"page"=>{"limit"=>"0", "offset"=>"0"}, "filter"=>{"status"=>"pending"}, "meta"=>"count"}
19:55:41 web.1  |   Motor::Notification Count (1.2ms)  SELECT COUNT(DISTINCT "motor_notifications"."id") FROM "motor_notifications" WHERE "motor_notifications"."recipient_id" IS NULL AND "motor_notifications"."status" = 'pending'
19:55:41 web.1  | Completed 200 OK in 11ms (Views: 0.1ms | ActiveRecord: 6.5ms | Allocations: 4191)
19:55:41 web.1  |
19:55:41 web.1  |
19:55:41 web.1  | Motor::NotificationsChannel is transmitting the subscription confirmation

FYI, I do have translations for that model:
---
sv:
  activerecord:
    attributes:
      matter:
        status:
          assessment_started: Bedömning påbörjad
          completed: Svarat
          delivered: Paket levererat
          delivery_sent: Paket skickat
          paid: Betalt
          pending_assessor: Väntar på bedömare
          pending_info: Väntar på ärende information
          pending_payment: Väntar på betalning

Added the one key to the translations just to test. Getting this:
---
en:
  activerecord:
    attributes:
      matter:
        one: Matter
        other: Matters
        status:
          assessment_started: Assessment started
          completed: Completed
          delivered: Package delivered
          delivery_sent: Package sent
          one: One key <----------------------------------------------
          paid: Paid
          pending_assessor: Waiting for assessor
          pending_info: Waiting for case information
          pending_payment: Waiting for payment

Is status some kind of reserved word? The other enums work fine :) Looks like a motor bug to me

@Frexuz i think i figured out what happened here:
You added enum status name keys into 'activerecord.attributes.matter.status' i18n hash
The problem is that it breaks the rails convention for i18n - 'activerecord.attributes.matter.status' should contain a string (AR model attr name) or a hash with One/Two/Many keys (also for AR model attrs).
So basically storing enum keys i18n in 'activerecord.attributes.matter.status' was a bad idea since it breaks rails convention.
It would be best to move those keys elsewhere - lets' say into 'enums.matter.status'
Closing this ticket since motor admin is built mostly on top of rails conventions which should followed (handling edge cases which violate rails conventions is not a goal)


Possible memory leak

I've noticed a suspicious memory leak issue as of late. I've been using app insights to investigate but I'm starting to think that app insights is the cause of the memory leak, which I find somewhat ironic.

To the best of my ability, _documents seem to grow indefinitely. Can anyone help explain why this would be the case. All I can see is that my heap is growing for each snapshot and that the _documents array grows with it.
I did some further digging, and it looks like this leak happens because live metrics is not enabled? I'm I right in assuming that the QuickPulseStateManager manage live metrics? If live metrics is not enabled why does it retain so much data?

I think the bug here is that calling setSendLiveMetrics(false) inadvertently creates a client. If you omit this line altogether, the client won't be created.

Thanks for the quick response.


Let users request new projects and hall-of-famers

A logged-in user should be able to request to add new projects on Github and new Hall-of-fame members.
About the implementation, we could use Github issues to keep track of these user requests.
Pros:

Nothing to add in the back-end, only Github API would be used.
Github issues and their comments are convenient to follow up a discussion

Cons;

It is not possible to delete Github issues, which is really annoying for tests.
Application admins would have to manually create projects and hall of famers in the admin application (bestof-admin repo) from the issu

New "My requests" view

"Add project" form

Since release 0.6.1, users can also suggest new Hall of Famers members.


i am sorry to bother you about pretrain

when i input “CUDA_VISIBLE_DEVICES=0 python -m torch.distributed.run --nproc_per_node=1 ActCLR-main/main.py pretrain_actclr -c ActCLR-main/config/ntu60/pretext/pretext_actclr_xview_joint.yaml”
it outputs：Traceback (most recent call last):
File "ActCLR-main/main.py", line 55, in
p = Processor(sys_argv)
NameError: name 'sys_argv' is not defined
could you help me to solve this problem，please？
by the way，the main.py is same as you.

You need to use --config instead of -c

You need to use --config instead of -c

thank you very much，it can run successfully！


Connection

Hi, I am hitting a problem, could you please help me out.
I run Redis as name master container in port 6379.
I also run
docker run -d --name redis-sentinel-01 --link master:master -p 32801:26379 lgatica/redis-sentinel
When I try to connect to sentinel, my source like that:
"host": "<IP_ADDRESS>",
"port": 32801
But I got this error: Potentially unhandled rejection [2] Error: Failed to find a sentinel from the endpoints
Please explain what's Im wrong. Thanks

Close issue for not respond


Update accepted_grant_applications.md

Dante M1 was accepted
@Noc2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Ar extension listed as all

Source information
Thunder scans 1.4.30
Source language
Arabic
Steps to reproduce
This extension is Arabic in language
But it's listed as all
Causing confusion for who looking for it
Making a multiple requests for adding it under label source request
And also the bot don't recognize this

Expected behavior
I should be listed as ar
Actual behavior
It's listed as all

Mihon/Tachiyomi version
0.15.3
Android version
Android 12
Other details
I add this request as a small contributer
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

it is under All or Multi section because it have english and arabic versions.


Prebuilding for multiple services using the same image

I have multiple services in my docker-compose.yml with the same image: property. Only one of them has a build: property:
    services:
      app:
        image: my_company/app
        build: .
        ...
      test:
        image: my_company/app

If I just pre-build app then when I try to run the test service, it rebuilds it in the run step.
If I pre-build app and test as described here then it seems to fail to push test to the registry (ECR) and the run step fails because it can't pull the test image.
This is the log output I get for the build step:
    $ docker-compose -f docker-compose.yml -p buildkite12345678908243a0af4110f50924cb4e -f docker-compose.buildkite-488-override.yml push app test
    Pushing app<PHONE_NUMBER>.dkr.ecr.ap-southeast-2.amazonaws.com/ape-ci/my_companyweb:my_companyweb-app-build-488)...
    The push refers to a repository [1234567890.dkr.ecr.ap-southeast-2.amazonaws.com/ape-ci/my_companyweb]
    0662cafed00d: Pushed
    f9afaae22bee: Pushed
    27d6313d90dc: Layer already exists
    ...
    bee4f8ad5631: Layer already exists
    cafed00d0415: Layer already exists
    deadbeefbcf9: Layer already exists
    my_companyweb-app-build-488: digest: sha256:8c61d757b9c74eca29d9aa74576fafd6ef8581f5e079af3e00f7a24423832138 size: 4098
    $ buildkite-agent meta-data set docker-compose-plugin-built-image-tag-app<PHONE_NUMBER>.dkr.ecr.ap-southeast-2.amazonaws.com/ape-ci/my_companyweb:my_companyweb-app-build-488
    $ buildkite-agent meta-data set docker-compose-plugin-built-image-tag-test<PHONE_NUMBER>.dkr.ecr.ap-southeast-2.amazonaws.com/ape-ci/my_companyweb:my_companyweb-test-build-488

Which to me looks like it's asking for test and app to be pushed but it's only pushing app.
Any idea how I can avoid having my run step rebuild my image?
Thanks

Apologies for the slow response, missed this one! I'll try and reproduce this one. Could you confirm what version of the plugin you are on?

Hi @lox,
I probably should have closed this. I think I understand the correct approach now. I've added both images to the build step even though they're the same image.
Because they're the same image it builds the second one from cache so it happens instantly. It then pushes them both to my CI repository and and then the run steps can pull the image they need.
If there's a better approach, I'd love to hear it but that seems to do the job. I'm on 1.7.0 now but I was on 1.5.2 when I reported this.
Thanks
Ritchie


added About.js page and routed so it appears upon click from the footer

Created and Routed to an About page when the user selects it in the footer.

There are merge conflicts now after merging the footer updates into main. Can you please resolve them?


@property shows setter only

Describe the bug
I have a class which has a @property getter and @property.setter. It doesn't show up on the new experimental parser.
To Reproduce
Make a class with a property setter and getter
Expected behavior
Expected to have a property join getter and setter and tag it as writable, as the old parser did, or some other form of making clear that it's a writable property
Screenshots
Source:
class Resolve:

    @property
    def page(self) -> str:
        """Page Attribute

        Returns:
            str: Returns page name
        """
        return self._obj.GetCurrentPage()

    @page.setter
    def page(self, page: str) -> None:
        """Page Setter test

        Args:
            page (str): valid page

        Raises:
            ValueError: _description_

        Returns:
            None: None
        """
        if page in self.pages:
            return self._obj.OpenPage(page)
        validpages = " ".join(map(str, self.pages))
        raise ValueError(
            f'"{page}" is not a valid page. Available pages are: {validpages}'
        )

Docs:

System (please complete the following information):

mkdocstrings-python version: [e.g. 0.6.6]
Python version: [e.g. 3.9]
OS: Mac OS Big Sur

Closing as from further investigating the code it seems it's not implemented yet in griffe as per issue #47

Indeed, not yet implemented. Thank you for reporting and coming back to close. I'll keep improving Griffe, there're many things to do :slightly_smiling_face: