Docs needed on HandConstraint Solver

Describe the Issue
I found out about HandConstraint through this StackOverflow post here, however it isn't documented at all on the Solvers page.
Feature Area
It's quite difficult to be aware of new solvers without them being added to documentation. HandConstraint also looks quite configurable with many options so documentation on how to use it would be quite helpful.
Existing Doc Link
Solvers

P.S. since the question of how to do this came up all the time at the WW partner hacks, I'd like to raise the priority on this one a bit. Thanks!

@Cameron-Micka
This is one of the features that we added in as an "experimental" one (meaning the code is there, but probably not final, missing docs, missing example scenes possibly, etc). We're currently planning out some work here to graduate this feature (meaning adding docs, solidifying on developer story, etc)

Julia asked me in #5500 to open a new issue on docs for HandConstraintPalmUp, but I feel it's easier to re-open this and add to it rather than create a new one.
As my comments on #5500 wrote:

lists both HandConstraint and HandConstraintPalmUp. The section does mention HandConstraintPalmUp but doesn't document it. I know it references a sample scene, but could it be documented here as well? If HandConstraintPalmUp inherits directly from HandConstraint and simply adds a few more properties, that delta could simply be added to the bottom of this section.

Features which extend HandConstraint and would be valuable to document for HandConstraintPalmUp include:

FacingThreshold

FlatHandThreshold

RequireFlatHand

Hi @jbienzms, I might be missing something but I don't see your comments in #5500? But, it sounds like you would like documentation for each of those properties?
Would something like this suffice? https://microsoft.github.io/MixedRealityToolkit-Unity/api/Microsoft.MixedReality.Toolkit.Utilities.Solvers.HandConstraintPalmUp.html#Microsoft_MixedReality_Toolkit_Utilities_Solvers_HandConstraintPalmUp_FacingThreshold
This is where I always struggle to "walk the line" between putting too much or too little in the READMEs vs the comments. I personally prefer granular things like this to live in the comments, but I know everyone discovers things differently

Sorry @Cameron-Micka, I meant to link to #5560 not #5500 for comments.
While that page generated from code comments technically documents the fields / properties of HandConstraintPalmUp, the spirit of this issue is about discoverability. Specifically the kind of discoverability that would help someone understand how to accomplish a certain kind of task or why a feature exists.
Originally this issue was opened because the HandConstraint wasn't documented at all. At the WW hacks a very common question was how to get menus and other things attached to the hands. So I was quite surprised to find out about the solver via Stack Overflow rather than through our own UX Building Blocks guide. It was later of course explained that it wasn't documented there because it was only an experimental feature. But as the feature graduated from experimental to release in #5560 it became more important that the feature be discoverable.
I personally do not believe that code comment documentation is "discoverable". This type of documentation can be quite valuable when you already know what class you're trying to use, but it rarely helps you accomplish a task without knowing the class / method name to use. So, I guess to answer your question of "Would something like this suffice?", I think my answer would be "no" for the following two reasons:

It's not linked to from the Solvers page, so someone has to know where to search for it.

but more importantly:

It doesn't help explain why HandConstraintPalmUp exists beyond HandConstraint or how it can be used to solve a problem.

The Solvers page does begin to explains this by saying:

A derived class of HandConstraint called HandConstraintPalmUp is also included to demonstrate a common behavior of activating the solver tracked object when the palm is facing the user. For example use of this behavior please see the HandBasedMenuExample scene.

But notice the lack of detail on this solver compared to others. OrbitalView and RadialView describe their configuration properties and how the affect the orientation of the attached object. Same with HandConstraint. But for HandConstraintWithPalmUp the instructions are to review a sample scene in order to understand it.

This is where I always struggle to "walk the line" between putting too much or too little in the READMEs

I do very much agree with this. It's always a balance. I truly wouldn't be being so particular about this one if we hadn't seen so many questions and desires around attaching things to hands.
One feature that was asked for quite a lot was how to build left-handed and right-handed layouts for hand-based content. Menus are a great example. People felt that menus should open toward the center of the body. So, for example, if the menu is on the left hand, child menus would open toward the right. If the menu is on the right hand, child menus would open toward the left. I still don't know how to provide guidance around accomplishing this ask. I don't know if anything that's been added to HandConstraint or HandConstraintPalmUp helps make this any easier. Is there a way to query the handedness of the hand which content is about to appear on? Is there any way to say "Use this prefab automatically if appearing on the left hand and use this prefab if appearing on the right hand?"
These are the sort of "discoverability" and "how do I" things I would love to see covered in the Guides section of documentation. Anything you can add to the Solvers document that would help a user understand why PalmUp exists or how to take advantage of the specific capabilities it adds would be quite welcome. If there's anything you can add to the documentation about detecting or honoring handedness, that would be invaluable.

Thank you for the in depth explanation Jared! I see what you mean, I’ll update the Solver docs to call out a few of these points. The solver docs look like they got updated right before my PR got merged, so I’ll need to do some updating to reach parity.

People felt that menus should open toward the center of the body. So, for example, if the menu is on the left hand, child menus would open toward the right.

Luckily this is the default behavior if one specified “Both” handedness for the Solver Tracker. I’ll document this better too! Please let me know if the example scene demonstrates this behavior you have in mind.

I believe Cameron fixed this.


Phishy

Presently, http://play.ceromobi.club/raffle/en/vs2-opt/index.html will present you with a phony facebook game. Actually, I just won $1000.
It then directs you to another domain: consumerproductsusa.com. After submitting an email address, it then took me to amarktflow.com.
In response, I got this charming response (LOL): https://www.dropbox.com/s/u0jy0xtm1cdjsfd/Screenshot%202018-01-20%2012.38.54.png?dl=0
It only gets scammier after that.
What do you know about those other two domains?

@ScriptTiger Would you please explain how you figured that there is a "scam funnel" at play? I'm interested in how you did your detective work.

A "funnel" is just a marketing term for how marketers gain the attention of prospects. With a legitimate business, like Nike, they might have high quality ads on sports related websites, like a a Gold's Gym website, targeting guidos 20-35 years of age with a new line of shoes specific to weightlifting. They might also have another ad campaign on a women's fitness website targeting housewives 30-45 with a new line of pink sports shoes great for lower back support to be more conducive to exercising while pregnant. These legitimate businesses spend millions on focus groups and market research to find out exactly who to target and how to make their ad spend the most efficient possible for the best return on their investment. They also spend quite a lot on "creative," which is the marketing term for all the "copy," or words, they use and all the graphic design that goes into ads, etc., which requires a lot of research to make these efforts effective.
In this case the term "scam funnel" is a bit opinionated, it is someone's attempt at a marketing funnel, albeit an extremely low quality one with no effort or research put into it. Like when you're searching for a specific piece of software you want and you land on an tech website with a billion ads that all say "Click here to download now!" and you can't even find the actual download link. These are called low quality ads because they are technically a form of abuse, which is banned by reputable ad services like Google Ads, because they are trying to trick you into clicking, and they also don't offer a solution to any particular problem or target any particular audience. They basically just want to make money from whoever via ad revenue and don't have any actual real services to offer other than cranking out click bait and just want everyone to click, regardless of who they are or what their needs may be. For actual companies this is a horrible marketing strategy and highly inefficient, but for a couple hustlers living in India it's the perfect way to get out of having a day job.
Depending on how many microsites they have, or tiny, useless sites that clutter up Google results, they could actually make quite a deal of money from unsuspecting clickers that "bounce" after a second of realizing that's not what they were searching for at all.  It's actually quite remarkable how many ways in modern times you can make money for not providing any real service to humanity, and this is one of those ways.

This issue is becoming a permanent fixture of the repo. Is there a lot of organic traffic landing on this issue to make it too good to merge and close? I used a lot of buzzwords in that article, so it's possible I guess.

@ScriptTiger Updating your review as the changes has been made may be a way to confirm that the recommended addition has been made!
Steven @StevenBlack said:

I'll wait to merge this until @paxperscientiam has made the recommended addition.

@StevenBlack, I would just like to point out I only did that because I value @funilrys' opinion and his contributions to our team, not because I feel as though you are actually seeking my approval :P


PhantomJS userAgent

Hi there,
Is there a way to set the useragent for the phantomjs driver/page?
Something like: page.settings.userAgent = 'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.120 Safari/537.36';

Hi, code below should work
capabilities := agouti.NewCapabilities()
capabilities["phantomjs.page.settings.userAgent"] = "'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.120 Safari/537.36';"
capabilitiesOption := agouti.Desired(capabilities)
agoutiDriver = agouti.PhantomJS(capabilitiesOption)


feat: add generateKey option to factories

Told ya so.

Lol, you are actually using this PR. I thought it was throwaway, lol...


New docker image build scripts

New paddlecloud-job build method, do not use FROM paddle* image to avoid large paddle docker image update, which is usually very slow.
Use whl package to update paddle binaries should be fast, it's only less than 50MB.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[5.5] Add support for -dump-pcm compiler mode

Cherry-pick of https://github.com/apple/swift-driver/pull/691
This gets lowered into a -dump-pcm swift-frontend job that outputs a bunch of information about the module to standard output.
Resolves rdar://78739383

@swift-ci please test


path/filepath: always validate full Glob patterns

The functions filepath.Match(pattern, name) and path.Match(pattern, name) return ErrBadPattern if the pattern is invalid, but due to lazy evaluation the error may or may not occur depending on what you match.
Example:
_, err := filepath.Match("a[", "a") // err is nil
_, err := filepath.Match("a[", "abc") // err is "syntax error in pattern"

As patterns are often user input, it would be handy to be able to validate the pattern. If the validation is successful, it should be guaranteed that filepath.Match() will not return an error.
I created a PR for this here and was asked to open a proposal issue first.
Other programming languages seem to either not validate the pattern at all (like Python's glob.glob('a[')), or always validate the pattern (like Java's FileSystems.getDefault().getPathMatcher("glob: a["))). I couldn't find an example where validation depends on what name is matched.

An alternative: make Match evaluate pattern non-lazily. That way there would be no risk that the implementations will diverge and Match will return an error for pattern which passes IsPatternValid.

Per discussion with @golang/proposal-review, we believe that the Match function should evaluate non-lazily (@opennota's suggestion) so that one can use Match to validate a Glob without adding a new function.

@andybons I certainly like that the current implementation is as efficient as possible. I just miss the option to validate a pattern. Maybe calling path.Match(pattern, "") could be a special case that evaluates the complete pattern. This string is unlikely to be used in normal situations, therefore it shouldn't hurt much when the whole pattern is analyzed.
Alternatively there could be path.Compile(pattern) that just compiles a path expression. This would also allow for common special cases to be matched much faster (prefix, suffix), like I did it in a project of mine for the subset of path patterns that I really needed.

Hi, I've been checking this issue and I would like to work on it if no one else is doing it right now as my first contribution.
I see two possible implementations using the same functions.

Adding some extra checks to the current implementation, keeping the laziness but ensuring a consistent repose in case of an invalid pattern (almost no overhead over the current implementation).

Adding a guard clause to check the whole pattern validity straight away (with a small overhead over the current implementation)

As per your previous conversation, you seem more inclined to the second option, right?
Thanks,

We want to make sure that implementation is simple, efficient, and always detects an invalid pattern.  I would tend to think that the second option you list is likely to be the better approach, but I think we're open to any implementation that meets those goals as best as possible.  Thanks.

@ianlancetaylor  I've created a PR (https://go-review.googlesource.com/c/go/+/186937) with a possible implementation for path.Match(pattern, name) function (it's a mix between option 1 and 2 😄  ) let me know what do you think about, before applying the same solution to the filepath.Match
Thanks,


(0.0.22a - 13w01b) Still lava

This is the conventional lava animation, used for all sides of the lava block from 0.0.22a up until inf-20100615 and still for the top and bottom for inf-2010061601808 onwards. I am not aware of any changes made to this texture from 0.0.22a onwards. Documentation of this texture can be found here: https://github.com/UnknownShadow200/ClassiCube/wiki/MInecraft-Classic-lava-animation-algorithm

As the still lava texture used RNG for generation, it may vary between sessions and getting a loopable animation may not be possible.
Worth noting is the fact that Java Edition used an LCG for random generation, whereas Pocket Edition used MT19937. Console Edition almost certainly also used LCG as its initial terrain generation was identical to Java Edition's. While both of these are intended for random number generation, and the results from changing them may not be distinguishable in normal situations, I'd recommend having two copies of the animation be generated, one per RNG type, as to have one texture generated for Java/Console and another for Pocket Edition.

Java version added in https://github.com/NeRdTheNed/MC-TextureGen/commit/e3c3859720c295601fc23fba5c348921a299a692. @muzikbike Should I close this issue, or should this stay open for console edition / pocket edition / other variants?

I assume this is still eligible for closing? Will do it if you don't in a few days

I assume this is still eligible for closing? Will do it if you don't in a few days

Sure, closing now!

The Pocket Edition case has been split into #26.


Is R.partition stable?

Hello,
I'm sorry if this has been answered elsewhere, but I checked the docs as well as the issues and could not find any information about it.
My question is, is R.partition stable? (I.e. will the order of elements of the passed list be maintained in the two new lists?)
I don't see any reason why it shouldn't be, but I'm planning to base a feature off of this, so I would like to know for sure ;-)
Thanks for any answers!

Yes, it is.  partition use  filter to do partition, and  filter keep list items order.

Thank you very much!


Convert patient multiple birth and deceased information

NOTE:  This work was broken off from #94
Describe the bug
Add capability to find and convert the following patient information

Patient.multipleBirthBoolean / PID-24
Patient.multipleBirthInteger / PID-25
Patient.deceasedDateTime / PID-29
Patient.deceasedBoolean / PID-30

To Reproduce
Create a sample HL7V2.6 patient PID segment with aforementioned patient information.
Expected behavior
Patient information should be detected and added to corresponding fields in HL7 FHIR resources.  See also Implementation Notes
Examples:
Multiple birth
{
  "resourceType": "Patient",
  "id": "infant-twin-1",
  "multipleBirthInteger": 1,      OR
  "multipleBirthBoolean": true,
...

Deceased
{
  "resourceType": "Patient",
  "id": "dead-person-example",
  "deceasedDateTime": "2015-02-14T13:42:00+10:00",      OR
  "deceasedBoolean": true,
...

Screenshots
N/A
Desktop (please complete the following information):

OS:  Mac OS
Version Big Sur

Additional context
Add any other context about the problem here.
Implementation Notes
Deceased
If the deceased date is present, parser assumes that deceased is true, and a .deceasedDateTime is created.
Multiple Births
If the multiple births integer is present, parser assumes that deceased is true, and a .multipleBirthInteger is created.

In Release 1.0.8


Assertion failure when doing :ObsidianOpen

🐛 Describe the bug
Thanks for the amazing plugin!
I have the vault path set to absolute (not a link). However, when I try using :ObsidianOpen, I get an error:

I tried debugging it, and the error seems to go away if I do return relative_path instead of return nil at this line. Both relative_path and normalized_path have the same value (the doc name, not the doc path) at this point.
Please let me know if I can provide any other information to help debug this.
Versions
lazy-lock.json

Hey @the-shank, is your vault behind a symlink? There's a known issue about this here: https://github.com/epwalsh/obsidian.nvim#configuring-vault-directory-behind-a-link
Otherwise could you let me know your vault path and the path of the note you're trying to open so I can debug further?

Hey @epwalsh, the vault isn't behind a symlink. And thanks for getting back on this so quickly!
Here are some of the details:
Path to vault: ~/Sync/MyBrain
All notes are directly inside the vault directory.
Test Note: test-nvim-obsidian.md.
Linked Note: test-linked-note.md.
Contents of Test Note:
refs: [[test-linked-note]]

I added a log to debug this and both the relative_path and normalized_path on this line evaluate to test-linked-note.md for this sample test case. And therefore the string.find() on the next line doesn't find the self:vault_name() in relative_path, setting j to be nil.
Please let me know if any other information is required to debug this.

Hey @epwalsh, the vault isn't behind a symlink. And thanks for getting back on this so quickly!
Here are some of the details:
Path to vault: ~/Sync/MyBrain
All notes are directly inside the vault directory.
Test Note: test-nvim-obsidian.md.
Linked Note: test-linked-note.md.
Contents of Test Note:
refs: [[test-linked-note]]

I added a log to debug this and both the relative_path and normalized_path on this line evaluate to test-linked-note.md for this sample test case. And therefore the string.find() on the next line doesn't find the self:vault_name() in relative_path, setting j to be nil.
Please let me know if any other information is required to debug this.

Perfect! I was able to reproduce and I think your proposed fix is the right thing to do. PR here: #291


Trajectory figure not visible in Analysing Earth Example

🐞 Problem
https://docs.einsteinpy.org/en/latest/examples/Analyzing Earth using EinsteinPy!.html
@shreyasbapat @JeS24

This particular example was removed in the last few commits near the end of GSoC 2020. As for the stable version, the figure is present: https://docs.einsteinpy.org/en/stable/examples/Analysing Earth using EinsteinPy!.html.

This particular example was removed in the last few commits near the end of GSoC 2020. As for the stable version, the figure is present: https://docs.einsteinpy.org/en/stable/examples/Analysing Earth using EinsteinPy!.html.


Statements refactor

NOT READY FOR MERGE
Here are two separated commits of the statement refactor @pezra and I talked about. The type hinting was only applied to some of the writers. I'm not exactly sure I like the way the type hints are being passed around so maybe I could get some feedback/suggestions on it before continuing?
p.s. some tests may be failing ATM
Started from discussion: https://github.com/cequel/cequel/issues/306

I didn't mean to push your branch, @jhannus. I assumed the push would be blocked due to access control. I hope you don't mind.

No worries at all just possible failing specs lol. I'll take a look this coming morning +1

If you don't mind i'll keep chipping away at the specs until they are all passing.

I also rebased. In for a penny, in for a pound, as they say.

Yes please! I was hoping to find a better way to pass the type hints to the writers. So that's not finished.
I'm thinking that instead of passing table and columns names to the writers we can pass a schema and figure out the names from there. Since the writers are responsible for assembling the query... We could then figure the queries column types hints from there.
With writing to a single encapsulated statement object each query whether single or batch, prepared or not, it will contain exactly it's own parameters.

@jhannus, let me know what you think. Type hints turned out be to really hard to get working. Once i switch to just preparing everything it all pretty much fell into place.

👍 @pezra thank you. Yeah the type hints where not fun at all but required to optionally prepare. In the fork I have hosted internally thats the way I went. I figured to contribute back though it should be optional possibly for folks who dynamically generate queries but... I'm cool with all prepared all the time if it cool with you 😄

I cherry picked the PreparedStatementManager I was talking about plus setters/getters and specs but its still unused on execute. I would remove the keyspace reference from the Statement instance (less object refs) and use Cequel::Metal::Keyspace#prepared_statement from #execute instead.

@jhannus, it looks to me like the cassandra driver caches prepared statements and prevents duplicates (search https://github.com/datastax/ruby-driver/blob/v2.1.7/lib/cassandra/cluster/client.rb for @prepared_statements[host][cql]). Given that do we need the statement manager?

That would be great. When I read these lines I thought otherwise but I'm seeing other code where they are cached. https://github.com/datastax/ruby-driver/blob/v2.1.7/lib/cassandra/cluster/client.rb#L224-L236. I'll remove those commits.

I rebased to remove those commits 👍

If you rebase i think this is ready to merge

OK all rebased to master.

one more time. i merged another PR at the same time you did this.

Looks like a few things need to change due to the upgrade of the cassandra driver gem.

OK, I got those changes in there as well. We'll see from the spec run if there are still issues with the upgrade.

Rebased because i merged another PR.

@jhannus, i rebased and, i think, fix the last remaining error. However that last rebase was a little weird. Could skim the current set of commits to ensure sure they make sense.

Sure thing...

Looks good 👍

merged! thanks for the improvement and the stick-to-it-iveness to get it to completion.


User/stwum/use base class in tango sim lib gen test

The changes staged here are from the issues raised in the JIRA ticket CB-2866.
Two main changes have been implemented here:

There are sub classes which test for fandango and SIMDD json files in the test_tango_sim_generator script. test_TangoSimGenDeviceIntegrationXML was used as base class for the two new subclasses overriding some functions in both cases.

The fandango json parser checks attributes with SPECTRUM as data_formats and adds max_dim_x and max_dim_y keys and their values if they are not present in the .fgo file. max_dim_x is initialised as the len(the list returned on the key 'value' for each attribute which has SPECTRUM data format)

@samtwum Please look at the CAM - Python style guide document for the guidelines to follow when making a pull request.

@samtwum Do not forget to add the JIRA ticket number on the branch name.

Thanks for the valuable comments! Now to other final sprint ticket ... 🥁 😄


Reorganization / Task list

As the rush of the final week of our project swiftly approaches I feel we need to reorganize ourselves to remain productive.
Since @AMIOL7 fell ill the rest of us need to take over his work too. The following tasks must be worked on and completed:
Task group 1:
Model:

[x] running the simulation (updating from start nodes)
[ ] serializing graph (generate truth table)
[ ] deserialize graph (logic node based on truth table)

View:

[x] #49
[ ] saving and loading user created nodes
[ ] display newly implemented nodes in side menu

Task group 2:

[x] exluding view code from code coverage analysis (as we only test the model)
[x] continous deployment
[x] package artifacts, so they are easily runnable on targeted platforms.
[x] configure CD to leave previous versions available
[x] clean up CI perhaps?

I'd like to make the initiative and assign @pszi and myself to Task group 1 and @bgdxqi and myself to Task group 2.
If you have other recommendations please share. Once we all agreed upon tasks we can close this issue.
We should use this issue (alongside dedicated issues of course) to keep track of our progress.
Ps.: When @AMIOL7 feels better he may join any task he wishes.

@vismate If you need to work with the model, I'd suggest we separate Task group 1, and you only take over in my part in case I will be unable to finish the view in time, but I think

display terminating nodes

and

display newly implemented nodes in side menu

I can very simply get done in the course of an afternoon.
As for

saving and loading user created nodes

if you know how to initiate (de)serialization of the working graph, you could have a crack at that, also if we want saved graphs to be able to be dragged in as nodes, you can look up the API docs on how to make Menus have dynamic content, and if you have a solution, feel free to share as I would like to be included, or at least informed at that.

I think we should use the task listing above to keep track of our progress.
Also, I've implemented whats needed for our final assignment!!

@vismate is deserialization is really needed? If the file will contain truth table, wouldn't it be better to directly access it in simulation loop?

Also, wouldn't it be better, if release is created only if at least unit tests are successful?

@vismate is deserialization is really needed? If the file will contain truth table, wouldn't it be better to directly access it in simulation loop?

What I mean by deserialization here is to load that truth table and store it in memory. I don't think reading a file on each update would be appropriate.
Also, the savefile would also store port labels which need to be loaded to display them.

Also, wouldn't it be better, if release is created only if at least unit tests are successful?

The release job depends on unit tests. I believe this means unit tests must not fail in order to create a new release.
Correct me if thats not correct.

Also, wouldn't it be better, if release is created only if at least unit tests are successful?

The release job depends on unit tests. I believe this means unit tests must not fail in order to create a new release.
Correct me if thats not correct.

Yes, that is correct.

Sorry, my bad. Did not see a "needs" line of code in your commit

@vismate I think we do not need to remove view code from sonarqube. We still need to check that part of code for code coverage, even if view code is not part of unit tests

I have taken a look at the pipeline, there is nothing to fix or improve

@vismate When are you going to submit the last assignment?

@vismate When are you going to submit the last assignment?

After finishing the required documentation. I'll be done with it later today.


Merging Environment Files

Expected Behavior
When setting up config file merging with environments, the middleware merges main files into ocelot.json and other environments to ocelot.[environmentName].json
Actual Behavior
When separating files to ocelot.[xxx].json and ocelot.development.[xxx].json all files are being merged into ocelot.json causing an error that there are duplicate routes
Steps to Reproduce the Problem
Here is an image of my file setup (ocelot.json generated by middleware):

Here is my Program.cs:
`builder.Configuration
.AddOcelot(builder.Environment);
builder.Services.AddOcelot();
`
Specifications

Version: 18.0.0
Platform: Windows
Subsystem: x64 (.NET6)

Is there a solution for this? I can't find documentation on how to get this to operate correctly.

@jacarutech You can separate out folders per environment and move related files in that folders. And configure your program file like,
builder.AddOcelot($"Ocelot/{hostingContext.HostingEnvironment.EnvironmentName}",
                                hostingContext.HostingEnvironment);

Your Ocelot folder structure would be like this:
-- Ocelot
  -- Development
    -- ocelot.test1.json
    -- ocelot.test2.json
  -- Production
    -- ocelot.test1.json
    -- ocelot.test2.json

Please refer to Ocelot document for the same.


Mapping Between Typst Source and Output

Is there a feature/code that enables mapping between the typst source and positions in the output? It'd be nice to be able to map from a position in the source to the page and position on that page, and back again.
I'm using typst.ts on the browser client.

The feature is already at the rust side (for typst-preview) but not exposed in the JS library.

For my own purposes, I've implemented a getMapping function which produces a javascript object allowing mapping between source and output positions. You can see it here.
Basically, I go through all of the glyphs on all of the elements of all the frames on all the pages of the document, and produce a collection of parallel arrays given page number, x, y, source file, offset. Then I can read through the array in javascript to map source to output and back again.
I'd like to contribute what I've done back, but I figured there would probably be some questions about design that would need to be hashed out before I try to put it in an actuall pull request. So I thought I'd get your thoughts here.

It will be very expensive to export entire span mapping from rust side to js side, especially when document keeps changing. It seems you're building some editor and this will become a bottleneck on big documents.
Two aspect:

There are already 3 Mapping Query APIs in Typst-Preview for reference, which can be simplified, improved, and moved it to typst.ts.

From Compiler provided Span to Source Code Location, see EditorActorRequest::DocToSrcJumpResolve

This is used by click outline item and jump to either source code location or scrolling preview into the position

From Source Code to Preview, see EditorActorRequest::DocToSrcJump
From Preview to Source Code, see WebviewActorRequest::DocumentPosition

In https://github.com/Enter-tainer/typst-preview/blob/2517b5f4d8aa22fc11b7fb06e26e501dcd0debb4/src/actor/typst.rs#L20-L22, and https://github.com/Enter-tainer/typst-preview/blob/main/src/actor/webview.rs#L23-L24

https://github.com/Enter-tainer/typst-preview/blob/main/src/actor/typst.rs#L20-L22

Incremental or not:

It will be simpler to have a getMapping API, as rust side doesn't have to keep any state.
Holding state in some object can bring better performance, but the API will be more complicated. https://github.com/Myriad-Dreamin/typst.ts/blob/a429fb9257bffd7ac1acafe54ca4c59d7ac8541f/packages/compiler/src/lib.rs#L475-L475

So far, I appear to be getting away with exporting the whole mapping. My theory was that since I'm exporting a whole pdf anyways, it wouldn't be a big deal to export a mapping of it alongside that. But I did figure I'd likely need to optimize eventually. Exporting the mapping does have the advantage of being very fast to lookup new locations.
The actual mapping logic behind the code you pointed to appears to live here: (https://github.com/Myriad-Dreamin/typst.ts/blob/5f91f5a2207fbcefea8e0c0e8b4c441acbc35c30/compiler/src/service/compile.rs#L501), and I built my code as an adaption of that.
Can you explain how IncrServer is intended to work? I looked at it previously, but I wasn't sure how to do anything useful with that api.

So far, I appear to be getting away with exporting the whole mapping. My theory was that since I'm exporting a whole pdf anyways, it wouldn't be a big deal to export a mapping of it alongside that. But I did figure I'd likely need to optimize eventually. Exporting the mapping does have the advantage of being very fast to lookup new locations.

Sounds great.

Can you explain how IncrServer is intended to work? I looked at it previously, but I wasn't sure how to do anything useful with that api.

Alright, it is in experiment state currently and doesn't get mentioned in the documentation, as I'm not sure how to expose it correctly. The usage of IncrServer is simple though. You can pass an additional IncrServer object to the compile API, so that typst.ts can store state/cache at rust side. Specifically, it stores the state/cache in the IncrServer object.
The goal of IncrServer is to ensure correct lifetime of these state/cache in rust. When IncrServer is destroyed, all related data are dropped at the same time. To avoid using the raw free function from the wasm-bindgen crate directly, I make a promise that destroys the IncrServer after resolved.
typstPlugin.withIncrementalServer(
  (srv: IncrementalServer) => {
    return new Promise((dispose) => {
      const updateDoc = () => {
        const v = await typstPlugin.compile({
          mainFilePath,
          incrementalServer: srv,
        });

        typstDoc.addChangement(["diff-v1", v]);
      };

      callback({ updateDoc, dispose })
    });
  }
);

You can see the experiment code here: https://github.com/mitex-rs/mitex/blob/c5e9f9bf2c5ef9a0f7be1c981f11026a0d732137/packages/mitex-web/src/tools/underleaf.ts#L103-L111

Thought I should update you; I'd still like to contribute something here, but it hasn't gotten to the top of the priority list yet. Its complicated to disentangle my needs (mapping from an AST with its own coordinate system into typst source into the PDF). And UTF-16 vs UTF-8 is really obnoxious.
But a quick thought on IncrServer - have you considered using FinalizationRegistry?

But a quick thought on IncrServer - have you considered using FinalizationRegistry?

I forget to reply it. I investigated it and came to conclusion that we could simplify memory management by FinalizationRegistry, but if the browser, where the compiler is running, doesn't support this feature, the related memory will be leaked. I didn't find a answer that whether it is popular enough and works well on major browsers. Note: wasm-bindgen generates js wrapper containing FinalizationRegistry and silently leaks memory when window.FinalizationRegistry is undefined.

If it were me, I'd say that if wasm-bindgen is willing to use FinalizationRegistry and leak memory if its absent, it's probably good enough for typst.ts. Also, if you provide a manual free/dispose function on top of that, anybody who is concerned to run in environments without FinalizationRegistry can call that.

If it were me, I'd say that if wasm-bindgen is willing to use FinalizationRegistry and leak memory if its absent, it's probably good enough for typst.ts. Also, if you provide a manual free/dispose function on top of that, anybody who is concerned to run in environments without FinalizationRegistry can call that.

Overall it sounds a good direction to start to use FinalizationRegistry, it just lacks of some concrete evidences that it is popular or robust enough. You or I might take some time to investigate it. You know there are some infamous web functions, appearing to be very beautiful, but also hit some curses after using them. But I also usually don't believe people can always dispose them correctly. This is why I did wrap them by a promise, as poorman's FinalizationRegistry. If we cannot use FinalizationRegistry, we can fallback to the current solution, and never expose a low-level free function to use.

I did think for a while. the promise isn't a FinalizationRegistry, it just provides yet another free function that every web people know that is must be resolved to finalize..

Well, I can say that I use FinalizationRegistry already to clean up some resources, and it seems to work well. CanIuse indicates that it's been supported by major browsers for 3-4 years already. I don't know what investigation you would have in mind beyond that.


this.context.close is not a function

I am trying to create a UI for React-Music.
Sometimes (I can't understand not always) my component is unable to unmount because in the willUnmount event this.context.close is not a function.
Which could be the fix for this?

it should be this.audioContext.close() ... I am trying to understand why it is not like that in my node_modules

I have seen that the error is fixed in Master.
Usually in this situations I put the git url of the repo in the packages.json, but in this case it doesn't install anything... why?

Yep this is on master :) https://github.com/FormidableLabs/react-music/commit/54d2978d0beeb07a1a0be312f015242a0ae269c7
I also just tried to install with a github URL but it didn't work :(

I'll get a release pushed

@kenwheeler Just wanted to poke and see if there's an update on the release? (just ran into this as well)
An alternative would be to use the library through git, but somehow I couldn't get that to work.

Curious to know why it doesn't work through the git url... I have tried to fork the repo and to remove the .npmignore but the problem is not that.

@lfittl sorry, was in israel. I'll get it pushed out today

just pushed 1.0.2. holllllllaaaa


TFLite concatenation operator should support float16 data type

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 22.04
TensorFlow installed from (source or binary): source
TensorFlow version (or github SHA if from source): the latest version

Standalone code to reproduce the issue
The doc of concatenation supports all data types, but the kernel implementation doesn't support float16 data type.

Hi @fujunwei ,
We see that the issue template has not been filled, could you please do so as it helps us analyze the issue [tf version, steps followed before you ran into this error or stand alone code/colab gist to reproduce the issue faced.
Thank you!

Hi @fujunwei , We see that the issue template has not been filled, could you please do so as it helps us analyze the issue [tf version, steps followed before you ran into this error or stand alone code/colab gist to reproduce the issue faced. Thank you!

I request it because the document is not match with kernel implementation, do we plan to support it? thanks.

Hi, @fujunwei
I apologize for the delayed response, I was trying to use concatenation operator with float16 data type but it's automatically using float32 instead of float16 please refer this gist-file and I see there is no implementation for float16 data type in the source code so most probably this issue will be considered as feature request and will update you soon, thank you for bringing this issue to our attention.
Thank you for your cooperation and patience.

Thanks so much.

Hi, @pkgoogle
Please take look into this issue. Thank you

Hi @fujunwei, the output documentation seems to match the datatypes supported but the operands says any type. Do you actually need/want float16 dtype to be supported or did you want the documentation to match correctly? Thanks.


RPi / Arm Compile / Installation doc please

📚 Documentation
Trying to get serialport running for ARM is not clearly documented / or lacking detail. Please can we have a proper step by step from first node install to running example.js / hello.js example. Have spent days trying to get serialport running with node v14.5.0 on Arm7, and always get version mismatch problems. Ultimately I downgraded my project to node 10.19 which seemed to work, but all manner of rebuilds with all number of flags completely failed to bring serialport up to usable with 14.5
Have you read the Contributing Guidelines on docs?
Yes

Hi there, I had no problems installing the latest serialport on my brand new RPi4 with latest nodejs and and Raspberry Pi OS. Maybe try upgrading one or all?
<EMAIL_ADDRESS>Node.js v14.11.0
Linux (Raspberry Pi 4) Raspberry Pi OS August 2020

@jet-leeroy what OS are you using. Is python2 on the PATH for the user running the install?

Hey
Sorry, have been away due to work and covid.
The issue is not that it doesn't work, the issue is the documentation
around which versions work with which platforms is light.
I am using a rpi 2 with Ubuntu. First time build spat up a while bunch of
errors probably due to the compiled C native binary being used in the
background for the actual port interface. Eventually dropping my node
version to 12 and rebuilding got it to work, but trying to start with node
14 was a bust. Additionally I had a few build options I needed to use that
took a lot of googling.. I recall some kind of allow unsafe flag I needed
to use at one point.
I'm not saying it doesn't work, I am not a node js dev, my background is
dotnet, so. It took a lot of google to get a a hello world going so I could
move forward.I'm just saying the documentation to get a hello world up on
rpi could've been better. Not everyone is a node dev.
Justin
On Sat, 26 Sep 2020, 17:22 Brian Vanderbusch<EMAIL_ADDRESS>wrote:

@jet-leeroy https://github.com/jet-leeroy what OS are you using. Is
python2 on the PATH for the user running the install?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/serialport/node-serialport/issues/2109#issuecomment-699509222,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMGLUDLVT7XHVB2IUQ6F373SHYBJ7ANCNFSM4OWJQTDA
.

I don't even think this is a node dev thing, I think it's a sysadmin thing.
I read https://serialport.io/docs/guide-installation#compilation-problems early on, and that's how I figured it out. I've had many, many years as both a developer and sysadmin, so I knew how to interpret those instructions to Ubuntu on the RPi (installed build-essential and  python2, then ran update-alternatives so python2 was the default).
With python 2 being no longer installed in many distros by default, including windows, I agree it may be time to tweak the docs a bit.
node-gyp also now states that python 3.8 is supported (looks like it was added back in March), although I haven't tested it personally. Maybe instead of this being a documentation issue specific to RPi, it's a documentation issue to update compilation problems document to reflect modern OS/toolchain states?

go away stale bot

The docs have been updated to reflect that Python 3 is now required.  Are there any other updates to the docs required to address this?

iirc the problem was that python 2 was required. Haven't tested this in a year though, but I can try again in the next day or two.


Loading a template modifies root slot definitions

When a template is loaded, this code merges together the root-level slot definition with the corresponding slot definition in a class's attribute list: https://github.com/cidgoh/DataHarmonizer/blob/c0010697950b82beb55b8770f393c2344dce46c7/lib/DataHarmonizer.js#L141-L149
The issue is that Object.assign modifies the "target" object (in this case self.schema.slots[name]).
To see the effect of this, consider this schema:
id: http://example.org/test
name: test
imports:
- linkml:types
prefixes:
  linkml: https://w3id.org/linkml/

slots:
  s1:
    range: string

classes:
  C1:
    slots:
      - s1
    slot_usage:
      s1:
        required: true
        title: 'C1:s1'
  C2:
    slots:
      - s1
    slot_usage:
      s1:
        title: 'C2:s1'

When DataHarmonizer first loads the template for C1, the C1:s1 column will be required as expected. However if the template is changed to C2, then the resulting column C2:s1 will also be marked as required, which is incorrect.

Thank you so much for catching that!  Tough one to debug perhaps.


Document core plugin system requirements

Users need to know what they need on their system to compile core plugins:

[ ] node
[ ] Ruby
[ ] Go?
[ ] Python
[ ] erlang?

this may not be as important if we just get redistributable binaries for python. Python is the one people get hung up on.


Add example compositions

Coverage increased (+0.01%) to 99.425% when pulling ebe6a72823803f44c75d06b5cfe5323bcd8fd563 on examples into 937c450d3278a5d9e629fc33fe8c0a7eff9d8767 on master.

Coverage increased (+0.01%) to 99.425% when pulling eed23f55490d70478a89f1edf17de765c6d9dfeb on examples into 937c450d3278a5d9e629fc33fe8c0a7eff9d8767 on master.


[crash] Side by side editors crashing

Describe the bug
In the installed 1.11.1 version, whenever I click on the Side by Side editors, I get the error below.
I tried it on multiple resources with different kinds and I received the same error.
Stacktrace
Cannot read properties of null (reading 'getValue')
TypeError: Cannot read properties of null (reading 'getValue')
   at MonacoEditor.componentDidUpdate (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:620110:64)
   at Yi (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:613882:141)
   at dk (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:615093:19)
   at exports.unstable_runWithPriority (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:635069:12)
   at gg (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:611359:10)
   at Uj (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:614887:3)
   at Lj (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:614534:3)
   at file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:611388:18
   at exports.unstable_runWithPriority (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:635069:12)
   at gg (file:///C:/Program%20Files/Kubeshop/Monokle/resources/app.asar/build/bundle.main.js:611359:10)

https://github.com/kubeshop/monokle/pull/2572 - fixed


use rollup build TypeError: chalk$1.blue is not a function

use rollup build TypeError: chalk$1.blue is not a function  ,  project dependencies<EMAIL_ADDRESS><EMAIL_ADDRESS>

This is an issue with Rollup, not chalk. Please take it up with them.


The states of the same genesis block are different for different Axon versions

Contact Details
No response
Current Behavior
The state root of the same genesis block should be the same.
But when run Axon with v0.1.0-beta.5, it returns a different state root with v0.1.0-beta.0.
Expected Behavior
I used git bisect to create a empty dev chain and checked the state root of its genesis block again and again, and finally I found the state root was changed between commit 5819560 and dd629ee.
The state root of the dev chain (ref: devtools/chain) I got through JSON-RPC:

Before commit 5819560 (included): 0x13d66227ff58a309512520b553454300483111ae4d3cfe7c39af2f12047f8893
After commit dd629ee (included): 0x65f57a6a666e656de33ed68957e04b35b3fe1b35a90f6eafb6f283c907dc3d77

OS
Not Associated
Axon version
v0.1.0-beta.x
Kernel
Not Associated
Relevant log output
No log output.
Anything else?

Was the changed state root is as expected?
There should be some checks in CI.

This is caused by #1206 which is a breaking change. So the v0.1.0-beta.2 is not compatible with v0.1.0-beta.1.


Performs Gradle build in PR workflow

Description
Performs the Gradle build instead of check. The build task depends on check and assemble, so this will run both workflows to ensure they continue to work .
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

In my opinion this project should try to conform to standard Gradle conventions to make it easy for client developers to use it. The end users are not necessarily going to be experts in building OpenSearch core, so following the conventions from the OpenSearch core projects is not necessarily ideal.
A standard Gradle build will run assemble and check. I think any developer should be able to pull the project and know they can run ./gradlew build.
For reference, the opensearch-java client has a check on the build process.
https://github.com/opensearch-project/opensearch-java/blob/0ef1246d716482209b3cbb175b675c4dc16e86ae/.github/workflows/build.yml#L22
Also, developers may want to publish to their Maven local for testing. I'm not sure we want to have CI on that, but we can get quite close by verifying build.
publishToMavenLocal --dry-run
:compileJava SKIPPED
:processResources SKIPPED
:classes SKIPPED
:jar SKIPPED
:javadoc SKIPPED
:javadocJar SKIPPED
:sourcesJar SKIPPED
:generateMetadataFileForPublishMavenPublication SKIPPED
:generatePomFileForPublishMavenPublication SKIPPED
:publishPublishMavenPublicationToMavenLocal SKIPPED
:publishToMavenLocal SKIPPED

Would you feel better about this if I split the assemble task into a parallel job and only use a matrix on Java versions instead of including the OpenSearch versions?

In my opinion this project should try to conform to standard Gradle conventions to make it easy for client developers to use it. The end users are not necessarily going to be experts in building OpenSearch core, so following the conventions from the OpenSearch core projects is not necessarily ideal.

I would strongly advocate to follow the same conventions (this is why we migrated to Gradle as well, otherwise I would certainly prefer Apache Maven), it is super easy to use the same command line across all build scripts / Github actions / Jenkins jobs. We are not prohibiting developers from running any valid Gradle task, (build or assemble or check), I would just advocate towards making check sufficient.
It is good you pointed opensearch-java, I never used build to be fair but check only.

I do think moving to Gradle to fit with the OpenSearch projects was a good move.
I think it is fair to say that the OpenSearch core build is quite complicated. It is a fairly unique Gradle build. But, there is such a thing as a conventional Gradle build - ./gradlew build. I'd suggest that since this project can support the standard build, we should support it.
I'd like to ensure that any developer can do the following:
git clone git@github.com:opensearch-project/spring-data-opensearch.git
cd spring-data-opensearch
./gradlew build

As this build process is so light, I think we can fairly trivially verify that this continues to work and not break.

I created an alternative approach in https://github.com/opensearch-project/spring-data-opensearch/pull/48 which runs the assemble step.

OK, if you really want to verify the assemble task, there is no need to use matrix for that (it is important for check) - the task just picks the compiled classes and packages it into JAR, using the baseline JDK-17 should be sufficient I think.

Also, can you clarify your specific concerns about running the build as part of the CI?

Because will run this every day anyway (as part of snapshot publishing)

Because will run this every day anyway (as part of snapshot publishing)

Why wait to catch problems? Let's find them sooner!
I'm trying to read between the lines here and it seems you might be concerned about build time. Running the assemble task only takes about 30 seconds, and this is when it run it its own task as done in #48. I'd imagine it is even less in this PR since the Gradle tasks share the setup and compile. Also, these run in parallel.

OK, if you really want to verify the assemble task, there is no need to use matrix for that (it is important for check) - the task just picks the compiled classes and packages it into JAR, using the baseline JDK-17 should be sufficient I think.

This at least checks that it builds on JDK 19. I think it is worth retaining the matrix so that we know it builds when running on JDK 19.
I've finished the work to make #48 pass. I'm happy to use either of these PRs (but not both). I prefer this current one for its simplicity. But, I'll let you pick which to use.

I've finished the work to make #48 pass. I'm happy to use either of these PRs (but not both). I prefer this current one for its simplicity. But, I'll let you pick which to use.

Thanks @dlvenable , I would prefer the separate step (#48), easier to manage / modify / troubleshoot

Closing in favor of #48.


Cache not found between jobs while being in the same run

I've found a strange bug with cache action. I know about cache being only available to the PR with the branch you are working on, and only when run is finished. this is not an usage issue on my side.
In short, here is what I do with cache.
My CI:
job 1 is recovering a cache using a key, if not available, download the data from somewhere else and upload an artifact, on sucess, cache is updated with the new data if any as cache action do automatically.
job 2 is recovering a cache using the same key, if not available download the artifact and keep going from there. On sucess cache is updated but technically it is not even needed as job1 has already done it.
The problematic workflow: There is a specific situation where this breaks and it should not, when new data is available and job 2 fails.
RUN 1 (new data, broken build)
job 1 is trying to recover cache using a key, there is new data so cache is not available, so data is being downloaded from alternate source and uploaded as artifacts. cache is created from the new data as job1 is successful.
job 2 is trying to recover cache using a key, there is new data so cache is not available, so data artifact is donwloaded instead. job 2 fails to build for an unrelated reason. no cache is created from the new data as the job failed.
All behavior is expected from now
RUN 2 (no new data, build fixed)
job 1 is trying to recover cache using a key it is found, job1 succeed
job 2 is trying to recover cache using a key BUT FAILS FOR AN UNKNOWN REASON, job 2 tries to fallback on artifact, which is not available, job 2 fails.
I can see the cache listed in the cache, but job2 is not able and will never be able to access it, while job 1 can access it super fine.
Let me know If I missed anything here. I could try to create a minimal repo to reproduce this but that would be a fair amount of work so I will wait for some feedback first.

Link to an actual CI failing like this: https://github.com/f3d-app/f3d/actions/runs/5305416707
(Ignore MacOS jobs, something else seems to be going on with these)

I also am experiencing this, we have a workflow that basically does this:
jobs:
  cache_check:
    secrets: inherit
    uses: ./.github/workflows/module-cache-check.yml

  lint:
    secrets: inherit
    uses: ./.github/workflows/module-lint.yml
    needs: [cache_check]

A first job to cache the code, then a second (actually many more) which pull that cache and read from it. Despite being in literally the same run, cache_check consistently finds the key while all other jobs do not. Is this because we're using workflow_call? Bad github behavior?

I'm having an issue where the cache is just not found at all, even between separate runs. #1198

comment

Facing the same issue. Chained jobs can't restore the cache created on the very first job in the chain on the same run

I was running into this issue but was able to resolve it after reading this comment in a similar issue. I found that the absolute path provided needs to be exactly the same in order for cache restore to work properly. If different jobs are using different container images this might be hard to achieve.


Fix cleanup script by actually providing the needed env vars

Description

Cleanup of clusters in the pipeline doesn't work:

 - args: [u"ResponseError: code=404, message=Not found: projects/suse-225215/zones/europe-west3-c/clusters/kubecf-ci---0-0-5.\nNo cluster named 'kubecf-ci---0-0-5' in suse-225215."]

   exit_code: 1

   message: ResponseError: code=404, message=Not found: projects/suse-225215/zones/europe-west3-c/clusters/kubecf-ci---0-0-5.

No cluster named 'kubecf-ci---0-0-5' in suse-225215.

the reason is that we call the cleanup script but the needed vars "$BRANCH" and "$CFSCHEDULER" are not set.
Motivation and Context

How Has This Been Tested?

TODO
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code has security implications.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I would like to avoid the repetition but gomplate is evaluated before Yaml merge keys.


#155543008 Add password validation

What does this PR do?

Add password validation
Add require the old password for reset password
Add more detailed responses

Description of Task to be completed?
The endpoints have been updated:

POST /api/v1/auth/register
PUT /api/v1/auth/reset-password
For both endpoints, the password will be required to be 6-20 characters long, should either contain characters numbers or any of !@#$

The responsonec of the following endpoint will now include the details of the resource added or updated

POST /api/v1/businesses
PUT /api/v1/businesses/<businessId>
DELETE /api/v1/businesses/<businessId>
POST /api/v1/businesses/<businessId>/reviews

How should this be manually tested?
Clone the repository into your machine
$ git clone https://github.com/mwenda-eric/WeConnect.git
Change directory into WeConnect
$ cd WeConnect
Activate Your virtual environment
source <env_folder>/bin/activate
Install project dependencies
pip install -r requirements.txt
Use Postman to test endpoints
Alternatively, you can test using the hosted version of the API:
https://weconnect1-api.herokuapp.com/api/v1/businesses
Any background context you want to provide?
the documentation of this API can be found here:
https://app.swaggerhub.com/apis/miriti/WeConnect/1.0.0/ui
What are the relevant pivotal tracker stories?
#155543008 #155688728

Pull Request Test Coverage Report for Build 39

97 of 105 (92.38%) changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 93.789%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tests/test_update_business.py
8
9
88.89%

app.py
30
37
81.08%

Totals

Change from base Build 33:
1.3%

Covered Lines:
453

Relevant Lines:
483

💛  - Coveralls


Forgot thingy on modrinth

I dont know why this is possible but you have somehow forgotten to put a game version down for https://modrinth.com/mod/ottah/version/A1
Im not too sure if its fixable but just letting you know (If it isnt, modrinth staff might be able to help)

That's strange. I probably messed up something when uploading the version


add example dashflow configurations

done by https://github.com/freewheel/dashflow/commit/d0205b85ae0659c2c6b9d09b7c4752e384a37e8c


⚠ Mobitopup has degraded performance

In 0a4e389, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3634 ms

Resolved: Mobitopup performance has improved in 05c90ce after 7 minutes.


⚠ ClamAV has degraded performance

In 41d33dc, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 451 ms

Resolved: ClamAV performance has improved in 51fe973 after 5 minutes.


Model Architecture of NDWI 4 class segformer

Hi All! I'm interested in using your NDWI 4 class segformer to do some shoreline detection, but I'm noticing that the h5 file 'sat4class_ndwi_512_v2_segformer_fullmodel.h5' contains only the model weights, not the full model. I see on the wiki that you're using the mit-b0 version of segformer. I am wondering, did you code the layers yourself, or download a model architecture from somewhere? I am currently trying to initialize a b0 segformer with your weights so that I can fine tune it on a custom dataset. If you could direct me to where you got the model or how you built it that would be greatly appreciated! Thanks!

Hi @wrosenbluth ! :wave:
The weights for the model were derived from finetuning this huggingface pretrained b0 segformer  with our training tool Segmentation Gym ...
the details on our model implementation are similar to the keras example, and leverage the huggingface TF segformer implementation
Does this answer your questions?
i have not used that 'sat4class_ndwi_512_v2_segformer_fullmodel.h5 model, which i assume is from a zenodo release made by @dbuscombe-usgs .
@dbuscombe-usgs , anything to add?

Ah great, good to see. I have been using this exact segformer from hugging face and loading your weights onto it! I wanted to make sure I wasn't doing something crazy by doing so. Thanks for the response.


Automated cherry pick of #2136: fix guest cannot delete

Cherry pick of #2136 on release/2.11.
#2136: fix guest cannot delete

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@aef27ac). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #2137   +/-   ##
==============================================
  Coverage                ?   7.15%
==============================================
  Files                   ?     451
  Lines                   ?   70314
  Branches                ?       0
==============================================
  Hits                    ?    5029
  Misses                  ?   64873
  Partials                ?     412

Flag
Coverage Δ

#aFlag
7.15% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/kvm.go
3.63% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef27ac...353d28f. Read the comment docs.

/approve
/lgtm


gatk : init at <IP_ADDRESS>

GATK is the industry standard for genetics analysis, more precisely for
identifying SNPs and indels in germline DNA and RNAseq data .
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1167

@SuperSandro2000 Is everything okay for you with the latest version ? Thanks :)


fix fetchResp parse error when recordBatch is empty

Codecov Report

Merging #54 (780d643) into main (e571825) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   94.91%   94.82%   -0.09%
==========================================
  Files          55       55
  Lines        3341     3345       +4
==========================================
+ Hits         3171     3172       +1
- Misses        125      126       +1
- Partials       45       47       +2

Impacted Files
Coverage Δ

codec/fetch_resp.go
88.09% <50.00%> (-3.16%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Unparseable number Issue while writing data to parquet file from Spark DataFrame

Hi,
I created a dataframe in Spark and loaded the data in the dataframe from AWS S3. When I'm writing the data to parquet from dataframe, it throws a following error:
Caused by: java.text.ParseException: Unparseable number: "$250.00-$254.99"
at java.text.NumberFormat.parse(NumberFormat.java:385)
at org.apache.spark.sql.execution.datasources.csv.CSVTypeCast$$anonfun$castTo$2.apply$mcF$sp(CSVInferSchema.scala:261)
at org.apache.spark.sql.execution.datasources.csv.CSVTypeCast$$anonfun$castTo$2.apply(CSVInferSchema.scala:261)
at org.apache.spark.sql.execution.datasources.csv.CSVTypeCast$$anonfun$castTo$2.apply(CSVInferSchema.scala:261)
I do have column in my dataset which has the value "$250.00-$254.99" and this column is defined as StringType in my dataframe.
Any help will be appreciated.
Thanks,
Vivek

Also observing this issue, same scenario.   Column is correctly defined as "StringType":
2017-07-27 15:49:47.768  INFO 6894 --- [           main] o.apache.spark.sql.internal.SharedState  : Warehouse path is '/data/EDI/edi_parquet/NAP/'.
root
|-- TNPTLOG_TRANS_TYPE_NAP: string (nullable = true)
2017-07-27 15:50:05.581  INFO 6894 --- [ker for task 15] o.a.s.s.e.d.parquet.ParquetWriteSupport  : Initialized Parquet WriteSupport with Catalyst schema:
…
"name" : "TNPTLOG_TRANS_REF_NAP",
"type" : "string",
"nullable" : true,
"metadata" : { }
},
and corresponding Parquet message type:
message spark_schema {
optional binary TNPTLOG_TRANS_REF_NAP (UTF8);
Error:
java.text.ParseException: Unparseable number: "P11064441275095"
at java.text.NumberFormat.parse(NumberFormat.java:350) ~[na:1.7.0_75]

Can you guys check if the type of the column is actually numeric?

The column type is string in my case -  both in schema definition and the source data itself, as above.   Yet this error is thrown.

Would.you be able to share codes, input and Spark version?


[Request] Any plan to add Texlive?

Any plan to add Texlive?
Please describe the app you want to add.
App name, description, website, where to download, special note [...]
App name
Texlive
description:
TeX Live is a cross-platform, free software distribution for the TeX typesetting system that includes major TeX-related programs, macro packages, and fonts. It is the replacement of its no-longer supported counterpart teTeX
website
https://www.tug.org/texlive/

This package is huge (3GB+ of the v2019 iso installer), and the installation is complicated with so many customizable install configurations.
This will make me spend more time investigating the installation automation of this application.

install-tl-windows -no-gui -help

I don't know much about Tex, it would be appreciated if someone wants to do contributions.

You can now install TexLive with the experimental stage manifest:
cd ~/scoop/buckets/dorado
scoop install .\experiment\texlive.json

Note: This is an EARLY EXPERIMENTAL STAGE manifest, just a minimal installation, no data persistence (I don't know what files should be persisted). Do NOT use it in production.
Please leave your feedback.

for smaller size solution try https://miktex.org/download#portable, about 224 MB.

What's the difference between miktex and texlive?

I just published a manifest for a full installation of TexLive, https://github.com/chawyehsu/dorado/commit/eb1f9b6c2eea13331f586d2c31e4822a1c35fe9f, which is the latest solution.


Ingestion engine | Incorrect source ammount for "self" path payments

Ingestion engine records incorrect source amount. Should be the sum of all occurred trades on the first step.
Operation example:
From StellarExpert:
https://stellar.expert/api/explorer/public/account/GA2WRYPCCVL6LP4CDMMLVYOAC7YO4PTJKGX3LZPQEBGZQTXSIPUHGLKS/history/all?order=desc&limit=1&cursor=86859915355799553
From Horizon: https://horizon.stellar.org/operations/86859876701057025

Fixed in v0.10.1


[BUG] Unable to install using composer

I tried installing the project using the composer method as outlined here: https://roadrunner.dev/docs/intro-install, in a fresh empty composer project, however, I get the following error:
PHP Fatal error:  Uncaught Error: Class 'Spiral\RoadRunner\Version' in ./vendor/spiral/roadrunner-cli/bin/rr:67

I tried this code:
composer require spiral/roadrunner
./vendor/bin/rr get

The version of RR used: ^2.0 (v2.0.1)

@jwillp Feel free to close the issue if the problem was resolved.


Add security context for example PRs using catalog git-clone

The newest versions of the git-clone catalog task don't run as root. Using this task requires setting the pod's security context to allow writes to volumes from non-root users.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

n/a Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
n/a Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/assign @abayer
I think this problem was introduced in https://github.com/tektoncd/pipeline/pull/5712 but I'm confused why these examples have been passing CI since then (they don't run successfully on my cluster)

Error: error processing import paths in "./config/controller.yaml": error resolving image references: Get "https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:c6ec81a8f848a05701e27e8136dea31b6a5ea711cf5f41cc810e8e4e5b931bea?se=2023-02-09T16%3A10%3A00Z&sig=D1kEVD0%2BRLFfV7X4HBBDVw5qUtETAUSK08TiZHx%2BgmU%3D&sp=r&spr=https&sr=b&sv=2019-12-12": read tcp <IP_ADDRESS>:33224-><IP_ADDRESS>:443: read: connection reset by peer
2023/02/09 16:00:57 error during command execution:error processing import paths in "./config/controller.yaml": error resolving image references: Get "https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:c6ec81a8f848a05701e27e8136dea31b6a5ea711cf5f41cc810e8e4e5b931bea?se=2023-02-09T16%3A10%3A00Z&sig=D1kEVD0%2BRLFfV7X4HBBDVw5qUtETAUSK08TiZHx%2BgmU%3D&sp=r&spr=https&sr=b&sv=2019-12-12": read tcp <IP_ADDRESS>:33224-><IP_ADDRESS>:443: read: connection reset by peer

This doesn't look like a flake, it should be a problem with custom task controller test. Last time I saw this is because the incompatibilty between custom task controller and its dependencies which leads to that we failed to buid the controller.
The kind cluster for our CI has been promoted to v1.24 https://github.com/tektoncd/plumbing/pull/1332, therefore this could be a version mismatch problem.

Error: error processing import paths in "./config/controller.yaml": error resolving image references: Get "https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:c6ec81a8f848a05701e27e8136dea31b6a5ea711cf5f41cc810e8e4e5b931bea?se=2023-02-09T16%3A10%3A00Z&sig=D1kEVD0%2BRLFfV7X4HBBDVw5qUtETAUSK08TiZHx%2BgmU%3D&sp=r&spr=https&sr=b&sv=2019-12-12": read tcp <IP_ADDRESS>:33224-><IP_ADDRESS>:443: read: connection reset by peer
2023/02/09 16:00:57 error during command execution:error processing import paths in "./config/controller.yaml": error resolving image references: Get "https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:c6ec81a8f848a05701e27e8136dea31b6a5ea711cf5f41cc810e8e4e5b931bea?se=2023-02-09T16%3A10%3A00Z&sig=D1kEVD0%2BRLFfV7X4HBBDVw5qUtETAUSK08TiZHx%2BgmU%3D&sp=r&spr=https&sr=b&sv=2019-12-12": read tcp <IP_ADDRESS>:33224-><IP_ADDRESS>:443: read: connection reset by peer

This doesn't look like a flake, it should be a problem with custom task controller test. Last time I saw this is because the incompatibilty between custom task controller and its dependencies which leads to that we failed to buid the controller.

Was this introduced in #6108? If so, let's revert that PR to ensure our CI is green. If not, where else have you seen it, and is there an issue tracking this problem?

Was this introduced in #6108? If so, let's revert that PR to ensure our CI is green. If not, where else have you seen it, and is there an issue tracking this problem?

I don't think so, the issue I saw was addressed by downgrading the dependency, this could be another issue.

/retest

/lgtm

+ kind create cluster --config kind.yaml
Creating cluster "kind" ...
 • Ensuring node image (kindest/node:1.24.7) 🖼  ...
 ✓ Ensuring node image (kindest/node:1.24.7) 🖼
 • Preparing nodes 📦 📦 📦 📦   ...

It is creating with 1.24.x now. Maybe it was a timing issue ? 🤔

+ kind create cluster --config kind.yaml
Creating cluster "kind" ...
 • Ensuring node image (kindest/node:1.24.7) 🖼  ...
 ✓ Ensuring node image (kindest/node:1.24.7) 🖼
 • Preparing nodes 📦 📦 📦 📦   ...

It is creating with 1.24.x now. Maybe it was a timing issue ? 🤔

Ahhhh wierd!
https://storage.googleapis.com/tekton-prow/pr-logs/pull/tektoncd_pipeline/6094/pull-tekton-pipeline-beta-integration-tests/1624035115187310592/build-log.txt
+ kind create cluster --config kind.yaml
Creating cluster "kind" ...
 • Ensuring node image (kindest/node:1.23.4) 🖼  ...
 ✓ Ensuring node image (kindest/node:1.23.4) 🖼
 • Preparing nodes 📦 📦 📦 📦   ...
 ✓ Preparing nodes 📦 📦 📦 📦
 • Writing configuration 📜  ...
 ✓ Writing configuration 📜
 • Starting control-plane 🕹  ...
 ✓ Starting control-plane 🕹
 • Installing CNI 🔌  ...
 ✓ Installing CNI 🔌
 • Installing StorageClass 💾  ...
 ✓ Installing StorageClass 💾
 • Joining worker nodes 🚜  ...
 ✓ Joining worker nodes 🚜

Which is a beta integration test triggered by https://github.com/tektoncd/pipeline/pull/6094

Ah interesting, I might have missed one 😓 😅

Thank you for the quick response and plus that happens to everyone all the time :D
https://github.com/tektoncd/plumbing/pull/1348 is ready!

Wondering if we also need to add the securityContext to v1 taskRunTemplate?

Wondering if we also need to add the securityContext to v1 taskRunTemplate for examples/v1/pipelinerun/pipelinerun.yaml exampe?

no, it's not using the catalog git-clone task; it's running as root: https://github.com/tektoncd/pipeline/blob/2da10fc5ff9d99571b6055bcb86aca12805cb9e0/examples/v1/pipelineruns/pipelinerun.yaml#L85

/approve


Close amounts error types

Close the two pubic enum error types in units::amounts. All the other structs are closed already because they either have private fields or marked non_exhaustive.

With
rustc 1.83.0 (90b35a623 2024-11-26)
cargo 1.83.0 (5ffbef321 2024-10-29)
PR: rust-bitcoin #3674
Commit: 0c369e2c6f5896999822f6287f79bc55f84deedd
Tip: false
Workspace: addresses (main: true)
Features: [default]
Lockfile: /nix/store/iybh1ppa0c0vgp4922yms6r8pblvrh9l-source/Cargo-minimal.lock (main: true)

Nightly: false
Run clippy: false
Run docs: false
Run check-api: false
Release mode: false

This fails with
error[E0433]: failed to resolve: use of undeclared type `Parserror`
  --> units/src/amount/error.rs:60:13
   |
60 |             Parserror::MissingDenomination(_) =>
   |             ^^^^^^^^^
   |             |
   |             use of undeclared type `Parserror`
   |             help: an enum with a similar name exists: `ParseError`

ugh, typo in ParseError - cheers.

IOW the first commit does not build.

I would have also accepted "build your patches and read your diffs - noob"

lol, hilarabad. After writing that joke above I realised I had done neither before force pushing and the second patch was still broken. Face palm.

Will one-ACK merge since this is identical to the verison Sanket acked except for the fixed typo.


Undefined function or variable 'mink'.

Undefined function or variable 'mink'.
Error in fast_nl_patches (line 100)
[vas, ods]=mink(SqDistFull, K);
Error in bm3d_net_res (line 8)
index = fast_nl_patches(resss, 3, 12, 8, mmind);
Error in demo (line 15)
resim = bm3d_net_res(noisy, sigma);

mink was introduced in Matlab R2017b. An alternative is to use the Min-Max Selection package, but it may crash when compiled using a newer compiler.


Error for including "clinicalData", and the content and roles of "Tumor_Sample_Barcode" column in the .maf file

Dear PoisonAlien,
I am sorry to bother you. I was trying to follow through the samples to learn how to use maftools because it is the exact tool I need. Thanks for developing this useful tool.
when I use "laml = read.maf(maf = laml.maf, clinicalData = laml.clin)", I got the an error like this:
Error in read.maf(maf = laml.maf, clinicalData = laml.clin) :
unused argument (clinicalData = laml.clin)
In addition, I was wondering whether the column "Tumor_Sample_Barcode" in the .maf file must use the format like this "TCGA-05-4249-01A-01D-1105-08", or something else such as a normal sample name like "FF_1, FF_2 ,....".  What information will the maftools extract from the sample's barcode?
I would greatly appreciate your kind help.
Jeff

Hi Jeff,
Tumor_Sample_Barcode can be of any format, it doesn't matter.
If your data is from TCGA and is you set isTCGA = TRUE, it will use first 12 characters instead of whole string. i.e, TCGA-05-4249-01A-01D-1105-08 -> TCGA-05-4249
For your first question, I guess you installed maftools from Bioconductor, could you try installing from GitHub source and try again. It's still not updated on Bioconductor release branch.
Let me know if you have issues.

Dear PoisonAlien,
Thanks a lot for your great help!
Jeff


Cannot connect to 1.1.7 default server on Win 10

Guys, I have tried connecting to the default locahost server, but to no avail.
Then I tried creating my own server and changed the ob.cfg file to correspond with the details of the newly created server... no luck
I installed 1.1.7 hoping this would be fixed - nope.
I tried running openbazaar.exe and a little black box (command prompt, but it was part of the app) popped up for 1 second and it said this... ( i had to screen shot very quickly and crop)

so, I cannot connect and I dont know if anybody else is having this issue...

Oh, this is the Python Error Log...

SOLVED!

how'd u solve it? I have the same problem


HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 18s
branch-2 passed

+1 :green_heart:
compile
0m 18s
branch-2 passed

+1 :green_heart:
shadedjars
3m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed

+1 :green_heart:
javac
0m 20s
the patch passed

+1 :green_heart:
shadedjars
3m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 33s
hbase-client in the patch passed.

18m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4651

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 093629bc8d87 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4c08a8a423

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/testReport/

Max. process+thread count
169 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 55s
branch-2 passed

+1 :green_heart:
compile
0m 51s
branch-2 passed

+1 :green_heart:
checkstyle
0m 23s
branch-2 passed

+1 :green_heart:
spotless
1m  6s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m  7s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

-0 :warning:
javac
0m 50s
hbase-client generated 69 new + 36 unchanged - 109 fixed = 105 total (was 145)

+1 :green_heart:
checkstyle
0m 21s
hbase-client: The patch generated 0 new + 283 unchanged - 83 fixed = 283 total (was 366)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
8m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 56s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

29m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4651

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 906aacbf0f85 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4c08a8a423

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt

Max. process+thread count
64 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 43s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 27s
branch-2 passed

+1 :green_heart:
compile
0m 34s
branch-2 passed

+1 :green_heart:
shadedjars
5m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
shadedjars
5m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
hbase-client generated 0 new + 81 unchanged - 11 fixed = 81 total (was 92)

_ Other Tests _

+1 :green_heart:
unit
3m 24s
hbase-client in the patch passed.

29m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4651

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a35b2be73d55 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4c08a8a423

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/testReport/

Max. process+thread count
200 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Rolled back the changes called out above, just cleanups now, proceeding to merge.


Refactor generate package

Close #304
One question for the reviewer is that do we actually  want to exclude the generator files for the release? I tried to use //go:build ignore in the generate package but that will make go generate malfunction with missing function import in between Go files.

@haoming29 I don't think we want to exclude the generator files in the release, at least for now. I think the solution might be some fussing the with the GitHub ci that allows us to generate the generated files and then exclude the generator files solely in the release pipeline. I also think that's a separate issue than this review.

@haoming29 I don't think we want to exclude the generator files in the release, at least for now. I think the solution might be some fussing the with the GitHub ci that allows us to generate the generated files and then exclude the generator files solely in the release pipeline. I also think that's a separate issue than this review.

Make sense to me. I will create another ticket for what we discussed here


Syntax highlighting stops working

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
Syntax highlighting will very regularly 'break' requiring me to re-open my notebook for it to start working again. Sometimes, I will need to restart vscode to get highlighting back.
VS Code Version
Version: 1.81.1 (user setup)
Jupyter Extension Version
v2023.7.1002162226
Jupyter logs
No response
Coding Language and Runtime Version
Python 3.11.4
Language Extension Version (if applicable)
v2023.14.0
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Local

Me too. This could happened after deleting a notebook cell, by clicking "delete" on tools bar in the right-upper corner of a cell. Syntax highlighting was disabled. Code auto filling was disabled. Besides, I cannot jump into function definition with CTRL+left click.

Same issue. Autocomplete disabled etc. The jupyter is essentially reduced to windows notepad. Needless to say this is an extreme issue that should be addressed asap.

The same here

Can you please update to latest Pylance extension and see if you can reproduce?

Happens to me all the time as well.

This issue should be fixed now with latest Pylance extension.


"Renew letsencrypt SSL Cert" button

Good morning. This is non-urgent. Just curiosity.
The "Renew letsencrypt SSL Cert"...what's it for? Certs renew automatically, so I'm just curious what it's for. What its function is. Thanks!!

Yes, previously there was no cron setup for renewing the certificate. I will remove the button from whm interface. Thanks for the heads up :)


doc: Documentation issue in 'boards/nxp/imx8mp_evk/doc/index'

mimx8mp_evk_a53 and mimx8mp_evk_m7 board configurations as described in the document are not present in the sdk-0.16.6
The board configurations are not available in the newest SDK. Do they exist somewhere else?
https://docs.zephyrproject.org/latest/boards/nxp/imx8mp_evk/doc/index.html

I now understand that the name listed in the document page was not explicit enough, and have realized that the board config files must be one of:
imx8mp_evk/mimx8ml8/adsp
imx8mp_evk/mimx8ml8/a53
imx8mp_evk/mimx8ml8/a53/smp
imx8mp_evk/mimx8ml8/m7
imx8mp_evk/mimx8ml8/m7/ddr
so the base board name is imx8mp_evk. So maybe the document can be more explicit (anyway I am a newbie with this build system, so it was not clear to me).
I do see the Note*
"A board may contain one or multiple SoCs, Also, each SoC may contain one or more CPU clusters. "... in the "Getting started guide" which helped when I started exploring the "board" subdirectory and saw the different imx8mp entries.
So this is more of an enhancement request rather than a bug. Sorry!

The documentation is wrong and need to be updated

I see that the doc was updated already... I thought I was seeing things (or going crazy) until I saw the "last generated  date".
It is now very clear. Very nice. Thank you


"final" classes doesn't inject properties

Trying out the Users example form @bwaidelich and latest 3.3.5 Flow I'm experiencing that classes marked as final doesn't get properties injected.
Example here from EventStream (added
\TYPO3\Flow\var_dump($this->streamIterator->current());
\TYPO3\Flow\var_dump($this->eventTypeResolver);

on line 79 for debug information)
✘ soren@kevin  ~/Sites/cqrs-test  ./flow user:makeadmin 985e66db-434e-4a0f-a729-e91e6c9e5937
Flow Variable Dump
Neos\Cqrs\EventStore\RawEvent object
 identifier => string "1" (1)
 type => string "Wwwision.Users:UserHasSignedUp" (30)
 payload => array(4)
   string "hashedPassword" (14) => string "bcrypt=>$2a$14$Zv.O3G1GutG54TtFPmx4E.fEs.0Zt0ODV6i35WRVivbvmX/4jbJCW" (68)
   string "name" (4) => string "Søren" (6)
   string "userIdentifier" (14) => string "985e66db-434e-4a0f-a729-e91e6c9e5937" (36)
   string "username" (8) => string "soren4" (6)
 metadata => array(empty)
 version => integer 0
 recordedAt => DateTimeImmutable object
  date => string "2016-11-09 13:03:42.000000" (26)
  timezone_type => integer 3
  timezone => string "UTC" (3)

Flow Variable Dump
NULL

Call to a member function getEventClassNameByType() on null

  Type: Error
  File: Packages/Application/Neos.Cqrs/Classes/EventStore/EventStream.php
  Line: 76

The annotation
    /**
     * @Flow\Inject
     * @var EventTypeResolver
     */
    protected $eventTypeResolver;

doesn't get injected untill i remove the final  from the class name
A issue of Flow or a issue of this package? I see some issues mentioning final and AOP in the main Flow package
https://github.com/neos/flow-development-collection/issues?utf8=✓&q=is%3Aissue final

Looking deeper this change seems to be somehow haing an effect on the CQRS package
https://github.com/neos/flow-development-collection/pull/644

Yes, the Cqrs package will require the upcoming Flow 4.0 (or dev-master). Sorry for that..

So a quick solution is to require typo3/flow dev-master in composer.json ?

So a quick solution is to require typo3/flow dev-master in composer.json ?

yes, if you dare to work with master ;)
I reponened the issue so we don't forget to adjust the composer dependencies accordingly

I dare untill the 4.0 release :-)


add xenium example

should be merged after #93  and after https://github.com/scverse/spatialdata-plot/pull/237

Maybe with the bounding box query also refer to the spatial_query notebook.

Also maybe with the last screenshot of napari explain that the user sees the exclamation warning in front of the element to warn that visualizing might take long.

Thanks for the notebook and for the suggestions, I applied them. I also added a plot for the 4 channels used in the multimodal segmentation.


Add helpers to get session information based on pin names

[x] This contribution adheres to CONTRIBUTING.md.

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
This PR adds helpers that allows users to filter session information based on the pin names.
The following VIs were added to the measurement helpers library.

Get Sessions and Channels for Pins (N sessions)
This vi allows users to get a list of session details based on a list of pin names.

If there are no sessions that match the pin names then an error is thrown.

Get Session and Channels for Pin (1 Session)
This vi allows the users to get a single session based on the given pin name.

These VIs have been put in a polymorphic VI as shown below,

These APIs follow a similar structure to the ones in measurement link python.
Why should this Pull Request be merged?
This change will allow users to filter their session information based on pin names, when they reserve multiple sessions at once.
What testing has been done?
Manually Tested the VIs using the NI-DCPower example

Spelling - 'indices'. Microsoft style guide suggests 'indexes' except for "in the context of mathematical expressions" but I think there may be precendent for NI to use indices.
https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/i/index-indexes-indices

It seems you're adding these helper VIs but not currently calling them from the example. Am I reading that right? Did you then just do your manual testing for DC-Power and revert those changes? I guess it's fine to have these here but not yet be calling them.

It seems you're adding these helper VIs but not currently calling them from the example. Am I reading that right? Did you then just do your manual testing for DC-Power and revert those changes? I guess it's fine to have these here but not yet be calling them.

As far as I can tell, they aren't used for the python examples either.

I don't really understand the purpose of this PR. Did someone ask for this? I'm afraid that without an example showing how to use these VIs, they just won't get used.

This was a feedback from the customer and was pointed out by Jack in one of the PR comments.
We could not find any current examples which could leverage these APIs, we tried to force it in some examples in python but it just made the examples more complicated. Hence we decided not to update the examples

It seems you're adding these helper VIs but not currently calling them from the example. Am I reading that right? Did you then just do your manual testing for DC-Power and revert those changes? I guess it's fine to have these here but not yet be calling them.

yes joel, that was how it was tested

Spelling - 'indices'. Microsoft style guide suggests 'indexes' except for "in the context of mathematical expressions" but I think there may be precendent for NI to use indices. https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/i/index-indexes-indices

I have updated indices to indexes


Consider adding Pants to the list of tools

Pants is a polyglot open source monorepo build system. It currently supports Python, Go, Java, Scala, and Shell. Adding JavaScript support is high on the community roadmap's priority list. Pants is a BUILD-file oriented system with a design inspired by Blaze, Ant, and others. It is most frequently compared to Bazel; which is reasonable, though there are a number of key differences between the two: https://blog.pantsbuild.org/pants-vs-bazel/
More info is available at https://pantsbuild.org and https://slack.pantsbuild.org. As a team member, I'm happy to answer questions. Thanks for welcoming the project to be submitted for your consideration! https://twitter.com/juristr/status/1514642911492640771?s=20&t=-YfS5beID6oxDqQhLM83zQ

Hi @cczona!
For sure a PR is gladly welcomed! Let me know if you need help with it.

Thank you for the PR! I commented and updated it, let me know!

Thanks for the quick turnaround, and for the updates, which definitely look a lot better than my attempt :)
I commented with a couple more questions to be sure I understand the categories correctly, so that I can ensure that our content make sense.

Answered! Hope it helps!

Thanks for clarifying. Looks like our existing answers make sense with those clarifications. :)

Thanks! Closed in https://github.com/nrwl/monorepo.tools/pull/57

@cczona can you close the issue out?

I just merged the PR, it will be live in a few minutes, the time for CI to pass and deploy to happen. 👍
Closing the issue.