Update README.md

Add the missing CLI arguments to the README file (HVM, tags and Proxy).
Should I also add a note about how to create HVM AMIs or should I just leave it until HVM goes GA and we have formal documentation?

lgtm


Dynamic set of min and max

Thanks by advance for explaining to me what's wrong whis this code ::
https://jsfiddle.net/2xy72dod/116/
It was working well some weeks ago, maybe some upgrades cause regression...

Got it, last firefox nightly bug
Sorry for wasting your time


Install 1.9.3 error in china

$ docker pull ghcr.io/alexxit/go2rtc:latest
it`s working! thanks!

Default images (including Hass addon linked to Docker Hub).
But go2rtc also hosting docker images on GitHub.

thanks


[HUDI-7790] Revert changes in DFSPathSelector and UtilHelpers.readConfig

Change Logs
This PR reverts the changes in DFSPathSelector, subclasses, and UtilHelpers.readConfig API so they still use Hadoop classes, given they are used in Spark and utilities classes, to avoid behavior change and breaking API change.
Impact
As above, makes upgrade easier.
Risk level
none
Documentation Update
none
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Azure CI is green.


Launcher mode and cmd-line arguments

The launcher mode SKIF %COMMAND% does not support being provided cmd line arguments in front of the game path, e.g. SKIF Start Temp %COMMAND%, as this just ends up being evaluated as an invalid path:
2024-02-03 10:29:19.801 ERROR [23856] [SKIF_Startup_LaunchGamePreparation@586] Non-valid path detected: START TEMP H:\Games\SteamLibrary\steamapps\common\Helltaker\Helltaker.exe

Solved in https://github.com/SpecialKO/SKIF/commit/8700bff62933cb3726c1d964816ae4765700e4ca.


MSGFPlusAdapter Problem in Peptide and Protein ID using OpenMS tools

The MSGFPlusAdapter step in the tutorial gives me (using the provided mzML files):
in the stderr:
Fatal error: Exit code 9 ()
java.lang.NullPointerException
	at edu.ucsd.msjava.msutil.Spectrum.getCharge(Spectrum.java:124)
	at edu.ucsd.msjava.msutil.SpecKey.getSpecKeyList(SpecKey.java:91)
	at edu.ucsd.msjava.ui.MSGFPlus.runMSGFPlus(MSGFPlus.java:220)
	at edu.ucsd.msjava.ui.MSGFPlus.runMSGFPlus(MSGFPlus.java:105)
	at edu.ucsd.msjava.ui.MSGFPlus.main(MSGFPlus.java:56)

in the stdout:
Fatal error: Running MS-GF+ returned an error code '255'. Does the MS-GF+ executable (.jar file) exist?

Apparently Spectrum.java:124 tries to get the charge of a precursor (and some spectra seem to have no precursor).

see also
https://github.com/OpenMS/OpenMS/issues/3576
https://github.com/MSGFPlus/msgfplus/issues/39

The first replies in the upstream issues indicate that there is a problem in the mzML file.

Is this still an issue @bernt-matthias?

I think this can be closed.


Use post metadata to prevent scroll pop when available

Summary
Make use of the post metadata when present for the scrolling overhaul
Ticket Link
https://mattermost.atlassian.net/browse/MM-11608

Still pending:

Prevent scroll pop on Long posts
Image dimensions for the message attachments


Make MetaDataURIMixin for composeability

Issues:
Fixes #412
Problem: Converting from Python class names to device uris can require,
among other things, replacing '_' with '-'.  The new mixin is the place for
classname-to-URI manipulation.
Analysis: created MetaDataURIMixin
Tests: all current tests pass

Shipping!


Request for c/z ions detection

Dear Mike,
Absolutely FANTASTIC resource, and thanks for keeping it open!
Quick questions:

Where would I define the parameter for the inclusion of C/Z fragment ions? Say, I did EtHCD experiment and wish to search for the presence of C/Z and B/Y ions.
Would you be able to provide a template of the config/json file where we can find out the various param names available to us?

Many thanks,
James

Hi James,

At the moment, there is only code for generating b/y fragment ions - I don't think there are any blockers preventing the addition of A/C/X/Z ions. I'm open to the idea of adding support for this, let me identify some benchmark datasets and do some testing.
There is an example configuration file at the very bottom of the README: https://github.com/lazear/sage#example-configuration-file - one of my short-term goals for the project is to improve documentation, so if there is something that is not clear, please let me know!

Best,
Mike

Thanks for the prompt reply!
I tried it a few minutes ago... and it is BLAZING fast! When I ran it, I assumed it crashed (with some random error)... but no... it was executed properly and finished misleadingly fast!

Many thanks for being willing to invest time in implementing ABC/XYZ ions. It would be tremendously useful for mixed or multi-fragmentation acquisitions. I have this chemical modification study, and Sage seems ideal for it because of its speed to rapidly screen through many datasets where we are trying different permutations of a method! With some of our shorter gradients (10-mins etc), we can now make acquisition decisions for the subsequent run within 2-3 minutes of completion!

Yup, I saw that config file; I just wanted to be sure if that was the template we should be using :)

Last question:
3. Of course, the search speed is very impressive, and the report (results.sage.tsv) is also intuitive. However, out of curiosity, I was wondering about how you are performing MS1 quant for the peptides. As in aggregation of the intensities of various charge states etc...?

I'm glad you are enjoying it! We also get a lot of use out of being able to rapidly search large datasets and try out permutations.
Hold off on using MS1 quant for production use for another week or so 😄  - I released it as an "experimental" feature, but the quantitative performance is quite poor (relatively low R2, no match-between runs). I have actually been completely rewriting the MS1 quant module from scratch (https://github.com/lazear/sage/compare/master...alt-lfq) and will be releasing it in the next week or so. The rewritten LFQ module rivals IonStar (and I believe MaxQuant) in terms of quantitative performance (and of course, it is still ludicrously fast).
The current algorithm aggregates intensities from various charge states and isotopologues, and calculates the region in a narrow RT & mass-tolerance window most likely to correspond to the precursor by a kernel density estimate of ion counts scaled by intensity.
The new algorithm still considers various charges states (2-4) and M+0 to M+3 isotopes within a narrow RT and mass-tolerance window (direct ion current extraction, a la IonStar, FlashLFQ, Skyline). I have added a hybrid (global regression + local correlation optimized run offsets on a per-feature basis) retention time alignment algorithm that enables match-between runs, as well as scoring MS1 peaks by normalized spectral angle relative to the expected isotopic distribution profile. This dramatically improves quantitative performance on ground truth datasets. You are the first person to get to see some new results:

Compare this to the performance of the current algorithm:

This dataset has E.coli proteins spiked in to human lysates at 1.5x, 2x, 2.5x, and 3x concentrations. The new algorithm in Sage accurately extracts precise quantitative ratios for peptides and proteins.

The isotopic errors essentially adds a mass offset of 1 C13 neutron to the precursor_tol window.
In the case of 50 ppm tolerance, Sage will search at (-50, 50), (+1 C13 -50ppm, +50ppm), (-1 C13 -50ppm, +50ppm), (-2 C13 -50ppm, +50ppm), etc applied to the annotated MS1 ion m/z. This can aid in identification of peptides where the monoisotopic peak is misannotated in the mzML file (e.g. sometimes the M+1 isotopologue is called as the monoisotopic peak). Alternatively, you could search with a (-3.5, +1.25 Da)

Dear Mike,
Thank you for sharing and keeping the development process transparent!!!
It is very exciting to see that you are able to keep it performant while improving quantification accuracy! I will continue testing it and provide you with some more requests and feedback. FYI, I have already implemented it on our HPC and it blazed through ~800 files.
Sincerely,
James

Hi James,
I've just added support for additional fragment ion kinds  - note that this hasn't been "officially" released yet - I haven't had a change to test it out on any EtHCD experiments yet. If you are interested, compiling the latest commit from the master branch would enable you to test this out
{
    "database": {
      "enzyme": {
        "missed_cleavages": 1,
        "min_len": 7,
        "max_len": 30,
        "cleave_at": "KR",
        "restrict": "P"
      },
      "fragment_min_mz": 150.0,
      "fragment_max_mz": 1500.0,
      "peptide_min_mass": 500.0,
      "peptide_max_mass": 5000.0,
      "ion_kinds": ["x", "b", "y"],
   }
...

Currently, the implementation for scoring of fragment ions treats (a/b/c) and (x/y/z) ions as groups. Any a-/c- ions will be counted as b-ions for the purposes of scoring (matched_b, longest_b features for PSM rescoring), and likewise for x-/y-/z-. I have never analyzed any EtHCD data, and I'm not sure how other search engines handle this - does this seem like a reasonable approach, or would you prefer something else?

I was able to test out an EThCD file from MSV000080008 (I used 20151216_07_HeLa_EThCD.mzML). We get excellent agreement with Comet when searching for b/c/y/z ions with ADP-ribosylation as a variable mod.


Unable to connect to the JLR InControl servers.

The problem
Unable to connect to the JLR InControl servers.
What version of JLR Home Assistant Integration has the issue?
2024.4.0
What was the last working version of JLR Home Assistant Integration?
No response
Vehicle type and model
Landrover Discover 2020
Diagnostics information
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response

Already in discussion. See issue #143

Hi. I have the same problem. Integration does not log into incontrol “Unable to connect to the JLR InControl servers.” Logging in to the official web and ios application is hassle-free. Any guidance is welcome.

This is because JLR have blocked access to the api the integration uses.  Please see open issues before raising new ones or commenting on them.  Thanks.  Will close as duplicate on #143

Hi,
for more than 6 and a half years it won't let me reload the JLR
integrations. Useful integration with Siri shortcuts and assist button.. I
hope we will be informed soon about the future of the integration.
Thank you.
Regards, M.
On Sat, Jul 6, 2024 at 2:19 PM Mark Parker @.***> wrote:

This is because JLR have blocked access to the api the integration uses.
Please see open issues before raising new ones or commenting on them.
Thanks. Will close as duplicate on #143
https://github.com/msp1974/homeassistant-jlrincontrol/issues/143
—
Reply to this email directly, view it on GitHub
https://github.com/msp1974/homeassistant-jlrincontrol/issues/144#issuecomment-2211754270,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7CEK3URVR76DYIRKARTPJTZK7OGZAVCNFSM6AAAAABKOC4GROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRG42TIMRXGA
.
You are receiving this because you commented.Message ID:
@.***>


FR: ABI exclusion configuration

There are certain types of annotations or package name structures that are conventionally used as "public-but-private" cases

@Generated-annotated code is usually implementation detail for the code it originates from and is usually exposed (if at all) via something else.
@RestrictedApi (error prone) or @RestrictTo (androidx) annotations
package names with .internal in them
public kotlin code annotated with @PublishedApi, as they're only public for use with inline functions

All of these cases could be candidates to be treated as internal visibility to a module and not part of ABI consideration.
A proposal API for configuring this:
issues {
  abi {
    ignoreGeneratedCode() // Implicitly ignores `@Generated`
    ignoreAnnotations("androidx.annotation.RestrictTo", ...)
    ignorePattern("**.internal.**")
  }
}

This request bears some similarities to this earlier FR.

Consider also @VisibleForTesting.

Resolved by https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/pull/158.


Fixed the alignment and position of navbar(in mobile viewport) and theme change button

I have made few changes in the custom.css file to fix the issue.
🛠 Fixes issue : #187
📇 Changes proposed:
1.I have fixed the issue by making the navbar center aligned and removed the excess padding in the left of navbar list.
2.I have fixed the overlapping of theme change button and table by adding a top margin to the table.
✅ Check List (Mark all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[ ] This PR contains changes in the documentation
[x] This PR contains changes in the Code of the project
[x] The title of my pull request is a short description of the requested changes.

📷 Screenshots

@all-contributors please add @Avilash-Saha  as a contributor of code

Thank you so much:)


Remove multiple "odo app list" entries

This PR puts the app list through a "RemoveDuplicates" function to
remove any duplicate application names.
This is required since we don't have any unique identifies for
applications and thus if we have 2+ components in an application,
multiple deployment config's are returned from OpenShift with the same
application name.
See below for an example of this change:

▶ odo app list
The project 'foo' has the following applications:
NAME
foobar
app

▶ oc get dc
NAME                 REVISION   DESIRED   CURRENT   TRIGGERED BY
foobar-app           1          1         1         config,image(nodejs:latest)
java-fwwm-app        1          1         1         config,image(java:latest)
nodejs-trym-foobar   1          1         1         config,image(nodejs:latest)

▶ odo app list -o json | jq
{
  "kind": "List",
  "apiVersion": "odo.openshift.io/v1alpha1",
  "metadata": {},
  "items": [
    {
      "kind": "app",
      "apiVersion": "odo.openshift.io/v1alpha1",
      "metadata": {
        "name": "foobar",
        "namespace": "foo",
        "creationTimestamp": null
      },
      "spec": {
        "components": [
          "nodejs-trym"
        ]
      },
      "status": {
        "active": false
      }
    },
    {
      "kind": "app",
      "apiVersion": "odo.openshift.io/v1alpha1",
      "metadata": {
        "name": "app",
        "namespace": "foo",
        "creationTimestamp": null
      },
      "spec": {
        "components": [
          "foobar",
          "java-fwwm"
        ]
      },
      "status": {
        "active": false
      }
    }
  ]
}

Closes https://github.com/openshift/odo/issues/1713

odoCmpSubE2e Test odo push with --source and --config flags when --context is used
  create local nodejs component and push source and code separately
  /go/src/github.com/openshift/odo/tests/integration/component.go:203
Created dir: /tmp/123696713
Creating a new project: sfagnrghgi
Running odo with args: [project create sfagnrghgi -w]
[odo]  •  Waiting for project to come up  ...
[odo]  ✓  Waiting for project to come up
[odo]  ✓  Project 'sfagnrghgi' is ready for use
[odo]  ✓  New project created and now using project : sfagnrghgi
Running odo with args: [component create nodejs nodejs --context /tmp/123696713 --app nodejs-push-context-test --project sfagnrghgi]
[odo]  •  Checking component  ...
[odo]  ✓  Checking component
[odo]  •  Checking component version  ...
[odo]  ✓  Checking component version
[odo] Please use `odo push` command to create the component with source deployed
Running odo with args: [push --source --context /tmp/123696713]
[odo]  •  Checking component  ...
[odo]  ✓  Checking component
[odo]  •  Checking component version  ...
[odo]  ✓  Checking component version
[odo]  ✗  Component nodejs does not exist and hence cannot push only source. Please use `odo push` without any flags or with both `--source` and `--config` flags
Running odo with args: [push --config --context /tmp/123696713]
[odo]  •  Checking component  ...
[odo]  ✓  Checking component
[odo]  •  Checking component version  ...
[odo]  ✓  Checking component version
[odo]  ✓  Creating nodejs component with name nodejs
[odo]  ✓  Initializing 'nodejs' component
[odo]  •  Creating component nodejs  ...
[odo]  ✓  Creating component nodejs
[odo]  ✓  Successfully created component nodejs
[odo]  •  Applying component settings to component: nodejs  ...
[odo]  ✓  Applying component settings to component: nodejs
[odo]  ✓  Successfully updated component with name: nodejs
Running oc with args: [get dc nodejs-nodejs-push-context-test --namespace sfagnrghgi]
[oc] NAME                              REVISION   DESIRED   CURRENT   TRIGGERED BY
[oc] nodejs-nodejs-push-context-test   1          1         0         config,image(nodejs:latest)
Running odo with args: [push --source --context /tmp/123696713]
[odo]  ✗  Unable to connect to OpenShift cluster, is it down?
Deleting project: sfagnrghgi

/retest

[odo]  •  Waiting for project to come up  ...
Deleting project:

/test integration

/retest

/approve

[odo]  •  Waiting for project to come up  ...
Deleting project: awtupygzqx
Running odo with args: [project delete awtupygzqx -f]
[odo]  ✗  The project awtupygzqx does not exist. Please check the list of projects using `odo project list`

/retest

/retest


Fix windows build after wstring->string migration

Test: cmake on windows

I have update the description for the commit.

Yeah that's a good iniative to clean up the repo and remove wstring.  Initially it was added because the DIA SDK provides wide characters when parsing pdbs and  I didn't want to pay the cost of the conversion for hundreds of thousands of symbols.  Looking back, that was a bad decision.  I really don't like the use of wstring and the s2ws/ws2s conversions littered everywhere.  The conversion from the DIA SDK strings should be done on demand or in batch on a worker thread.


Corrected version of the logo

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

EDITING AN EXISTING TOPIC OR COLLECTION*
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please explain why these changes are necessary:
The current ActivityPub logo is broken: it misses the gap between A and P.

Thanks so much for your first contribution!  You rock, @mray!


Fix JSON dump error in ecs.update_service with task_definition

ECS update_service is trying to store the full task_definition object rather than the name/arn.
Crash happens when response is JSON serialized.
Traceback (most recent call last):
  File "/home/pior/.virtualenvs/moto/lib/python3.5/site-packages/botocore/endpoint.py", line 204, in _get_response
    proxies=self.proxies, timeout=self.timeout)
  File "/home/pior/.virtualenvs/moto/lib/python3.5/site-packages/botocore/vendored/requests/sessions.py", line 573, in send
    r = adapter.send(request, **kwargs)
  File "/home/pior/.virtualenvs/moto/lib/python3.5/site-packages/botocore/vendored/requests/adapters.py", line 370, in send
    timeout=timeout
  File "/home/pior/.virtualenvs/moto/lib/python3.5/site-packages/botocore/vendored/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
    body=body, headers=headers)
  File "/home/pior/.virtualenvs/moto/lib/python3.5/site-packages/botocore/vendored/requests/packages/urllib3/connectionpool.py", line 374, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.5/http/client.py", line 1194, in getresponse
    response = self.response_class(self.sock, method=self._method)
  File "/usr/lib/python3.5/http/client.py", line 235, in __init__
    self.fp = sock.makefile("rb")
  File "/home/pior/.virtualenvs/moto/lib/python3.5/site-packages/httpretty/core.py", line 332, in makefile
    self._entry.fill_filekind(self.fd)
  File "/home/pior/.virtualenvs/moto/lib/python3.5/site-packages/httpretty/core.py", line 591, in fill_filekind
    status, headers, self.body = self.callable_body(self.request, self.info.full_url(), headers)
  File "/home/pior/dev/py/moto/moto/core/responses.py", line 107, in dispatch
    return cls()._dispatch(*args, **kwargs)
  File "/home/pior/dev/py/moto/moto/core/responses.py", line 167, in _dispatch
    return self.call_action()
  File "/home/pior/dev/py/moto/moto/core/responses.py", line 183, in call_action
    response = method()
  File "/home/pior/dev/py/moto/moto/ecs/responses.py", line 162, in update_service
    'service': service.response_object
  File "/usr/lib/python3.5/json/__init__.py", line 230, in dumps
    return _default_encoder.encode(obj)
  File "/usr/lib/python3.5/json/encoder.py", line 198, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/lib/python3.5/json/encoder.py", line 256, in iterencode
    return _iterencode(o, 0)
  File "/usr/lib/python3.5/json/encoder.py", line 179, in default
    raise TypeError(repr(o) + " is not JSON serializable")
TypeError: <moto.ecs.models.TaskDefinition object at 0x7fa4ea6f3e80> is not JSON serializable

Coverage increased (+0.01%) to 94.293% when pulling 31554b106980917e8ccc7f211ad6bd330942d615 on pior:fix-ecs-task-def-arn-bug into 05c6fc673896c9a500bf5cb7f6fa34510db1d50b on spulec:master.

Thanks


remove hocs from ConnectNanoXScreen

@vsubhuman could you check this one, I have only legder.

/check


Timeline View

This change is

@Aelbannan what happened to this PR? won't fix? need help to fix the conflicts?

@MichelDiz I've just been busy with other things since beginning of March, feel free to merge it in


Web application structure

Add the structure for all the screens of the web application and how they are connected with each other in the README.md of frontend folder

@hitesh22rana  I would like to work in this issue . If it's still open I'd like to get assigned

@hitesh22rana I would like to work in this issue . If it's still open I'd like to get assigned

Sure @Aniket1026 go ahead.
Do comment if u need any assistance, would love to help

Yes , actually I would like to know the flow for the frontend . Not detailed , only the high level view would be fine for me to get the gist  and propose a intermediate structure

Yes , actually I would like to know the flow for the frontend . Not detailed , only the high level view would be fine for me to get the gist and propose a intermediate structure

Alrightyyy, let's start,
so basically, the frontend would consist of multiple screens/pages, so the high level structure of this would be something like.
So I want to duplicate this entire thing in the architectural format which can be then added to the README.md of the frontend folder, as well as explained.
We have 2 kinds of routes :- Public Routes and Private Routes
Public Routes

Home Screen
Authentication

Login
Signup

Private Routes

User Details form (It is must and should be filled in order to further authorize the user, as well as to perform some actions)

DashBoard

Sidebar

Joined organizations

Publish opportunities

Available opportunities

View opportunities

Create custom cover-letter

Topbar

Searchbar
Notifications
Settings
Logout

Organizations

View organization page

join organization

I hope this fixes your doubts.
Do ping me if you require any assistance, would love to help 😄

Yes , actually I would like to know the flow for the frontend . Not detailed , only the high level view would be fine for me to get the gist and propose a intermediate structure

Alrightyyy, let's start, so basically, the frontend would consist of multiple screens/pages, so the high level structure of this would be something like. So I want to duplicate this entire thing in the architectural format which can be then added to the README.md of the frontend folder, as well as explained.
We have 2 kinds of routes :- Public Routes and Private Routes
Public Routes

Home Screen

Authentication

Login
Signup

Private Routes

User Details form (It is must and should be filled in order to further authorize the user, as well as to perform some actions)

DashBoard

Sidebar

Joined organizations

Publish opportunities

Available opportunities

View opportunities

Create custom cover-letter

Topbar

Searchbar
Notifications
Settings
Logout

Organizations

View organization page

join organization

I hope this fixes your doubts. Do ping me if you require any assistance, would love to help 😄

Thanks for explaining me deeply about the structure .
Following the instruction I'll try to propose a intermediate hierarchical high level over view for the frontend which can be added in the readme for understanding the frontend structure and also helpful for other contributors 😊


Profiling will not work if the bundleURL has no port.

If the bundleURL has no port(default 80) , the profile request URL will be <scheme>://<host>:<null>/profile, that will not work. So we should decide if the port exsits first.

@facebook-github-bot import


Use "px" instead of "pt" in website documentation

The v10 guidance page on iconography uses pt in an image and the image's caption. pt font unit does not get used in product development. Replace with px.
https://next.carbondesignsystem.com/guidelines/iconography/usage

Should be good to go! Going to close this one out


Right to left script is displayed left to right in MARC conversion display

Type of change
A defect I think--problem with html coding?
Example RDF records
Please provide URIs or RDF of the bf:Instance. If providing RDF, Turtle is preferred.
https://api.stage.sinopia.io/resource/85bcf909-f9cc-42bc-9fd4-0292367eb1b2
Resource template
Which resource template does this apply to? In which Sinopia environment (development, stage, production)?
stage pcc:bf2:Monograph:Instance
Expected MARC
What MARC did you expect to receive?
السياسة الخارجية الامريكية في الشرق الاوسط
Actual MARC
What MARC did you actually receive (if mapped incorrectly)?
The script is backwards--from L to R rather than R to L--in the MARC conversion display

This is only in this screen--elsewhere it is fine (including if I try to cut and paste it).
Expected mapping logic
Please describe the logic of the mapping.
Arabic script should display R to L when the appropriate keyboard is used
For questions about the script, please contact Magda Gad on slack or @Magda-Gad

See https://www.w3.org/International/articles/inline-bidi-markup/

I have downloaded the record in MARCEdit and Notepad and the text looks fine and in the correct order as below:

This problem just appears in the display of MARC record in the MARC conversion show box in Sinopia as below:

Thanks!


Add GHA links to metadata

This change updates the PyPI project page with pointers to the source/docs/CI locations and adds a GHA badge to the README.

@bbangert mind labeling this PR as hacktoberfest?

@webknjaz sure, like that?


UnicodeEncodeError

Traceback (most recent call last):
  File "pinterest-downloader.py", line 1680, in <module>
    run_direct_main()
  File "pinterest-downloader.py", line 1675, in run_direct_main
    , args.https_proxy, args.http_proxy)
  File "pinterest-downloader.py", line 1545, in run_library_main
    , arg_cut, arg_el, fs_f_max )
  File "pinterest-downloader.py", line 1283, in fetch_imgs
    got_img = write_log(arg_timestamp_log, url_path, shortform, arg_img_only, arg_v_only, save_dir, images, None, arg_cut, break_from_latest_pin)
  File "pinterest-downloader.py", line 927, in write_log
    f.write('Input URL: https://www.pinterest.com/' + url_path.rstrip('/')  + '/\n') # Reuse/refer when want to update
UnicodeEncodeError: 'cp932' codec can't encode character '\uab75' in position 54: illegal multibyte sequence
 Abort.

924 :   with open(log_url_path, 'w', encoding="utf-8") as f:
949 :   with open(log_path, 'w', encoding="utf-8") as f:
962 :   with open(log_path, 'w', encoding="utf-8") as f:

i have no idea how github stuff work so... just gonna leave that here

Encountered the same problem, I added encoding="utf=8" every line started with
with open( ----, 'w') and It is working


Retrieving jpeg data from @route endpoint

Describe the problem
I'm using a generator to write jpeg data i.e. frames to memory and a @route to create an endpoint where the jpeg data can be retrieved. I've read through the entire Bottle documentation and Eel source code and I can't figure out what I'm doing wrong.
Code snippet(s)
import numpy as np
import cv2
import eel
import bottle
from bottle import Bottle, route, Response, static_file
import threading

outputFrame = None
lock = threading.Lock()

def generate():
    # grab global references to the output frame and lock variables
    global outputFrame, lock
    # loop over frames from the output stream
    while True:
        # wait until the lock is acquired
        # check if the output frame is available, otherwise skip
        # the iteration of the loop
        with lock:
            if outputFrame is None:
                continue
            # encode the frame in JPEG format
            (flag, encodedImage) = cv2.imencode(".jpg", outputFrame)
            # ensure the frame was successfully encoded
            if not flag:
                continue
        # yield the output frame in the byte format
        yield(b'--frame\r\n' b'Content-Type: image/jpeg\r\n\r\n' +
            bytearray(encodedImage) + b'\r\n')
# initialize Eel
eel.init('assets')

def onclose(page, sockets):
    pass

@route("/video_feed")
def video_feed():
    # return the response generated along with the specific media
    # type (mime type)
    Response.content_type = "multipart/x-mixed-replace; boundary=frame"
    return Response(generate())

eel.start("main.html", size=(800, 480), position=(0, 0), close_callback=onclose)

...

In my main.html file I have an img tag that should receive the updated frame. I followed this guide https://www.pyimagesearch.com/2019/09/02/opencv-stream-video-to-web-browser-html-page/ and adapted the code from Flask to Bottle as best I could.
<html>
   ...
          <img width="640" height="480" src="http://localhost:8000/video_feed">

</html>

Desktop:

OS: Manjaro Linux 19
Browser: Chromium
Version: 80.0.3987.122

Eel starts the Chromium browser and then CPU usage shoots up to 100% on a single thread and the browser hangs. I'm guess that the image byte string is being generated but not consumed properly. I'm using the latest version of Eel==0.12.2.
Any help would be greatly appreciated. I'm banging my head against the wall over this. Other than this one issue, I'm loving working with Eel!

Well first of all, I don't think your code inside genrator is getting executed. You need to loop over the generator object you receive from calling generator(), to actually execute the code inside of it.
Aside from that I didn't really understand what you are trying to achieve. Is it - you are supplying differernt .jpeg frames to html (from python) so as to achieve a video?

Try refering this: It uses frames coming from webcam, maybe you can tweak it to supply frames from some other source.
https://github.com/samuelhwilliams/Eel/issues/193

@RahulBadenkalSarci That's exactly what I needed! Thank you so much for chiming in and helping me :)


added back button for navigation

😎 -> good job !

Thanks @bonface221


Fix: Process never ends on error when use promise #98

Fixing following issue:
https://github.com/oslllo/svg-fixer/issues/98

Hi, thanks for the PR, please update the browserslist by running npx browserslist@latest --update-db to try and fix the failing tests.

Hi, Thanks,
Can you link the issue to this PR?
And when will the issues would be closed?
Regards

Hi, thanks for the PR, your fix will be available in v4.0.0 that I will be releasing soon.

Your fix in now available in v4.0.0, thanks again for the PR.


Created an Empty Constructor so this can be used in a groovy script.

Groovy requires there to be an empty constructor to be able to construct these in a script.  We are doing this because we enforce our post-steps for our team with groovy scripts and this change will enable us to create and attach this plugin in those scripts.

Are you doing this via the Script Console or via the Groovy post-build step?

According to this groovy mailing list post, Groovy automatically creates a default empty constructor if one doesn't already exist.

@Leander1P @tterrag1098 @ahippo @mattwilliams-stfc @Shovinus since you've recently opened pull requests; I'd appreciate it if you're willing to peer review this pull request.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@samrocketman Java does this as well, and since groovy allows java syntax this is not surprising.

I was doing it via the Groovy post-build step.
On Tue, Nov 3, 2015 at 6:23 PM, Sam Gleske<EMAIL_ADDRESS>wrote:

Are you doing this via the Script Console or via the Groovy post-build
step?
—
Reply to this email directly or view it on GitHub
https://github.com/jenkinsci/slack-plugin/pull/147#issuecomment-153521568
.

From that post it seems that it doesn't if you haven't added the Super,
which I think is not included, I assumed just adding a default constructor
would be an equal solution, you could add the super statement, either would
work.
On Tue, Nov 3, 2015 at 6:28 PM, Sam Gleske<EMAIL_ADDRESS>wrote:

According to this groovy mailing list post
http://groovy.329449.n5.nabble.com/Default-empty-constructor-necessary-td356024.html,
Groovy automatically creates a default empty constructor if one doesn't
already exist.
—
Reply to this email directly or view it on GitHub
https://github.com/jenkinsci/slack-plugin/pull/147#issuecomment-153522718
.

super() is implicit

groovy.lang.GroovyRuntimeException: Could not find matching constructor for: jenkins.plugins.slack.SlackNotifier()
I think that might not be the case, I believe your right but in the instance of trying to call it from the script plugin I think the environment is different than when compiled.  I believe that when compiled there would be an empty constructor created implicitly and the super as well, but when trying to construct an instance with either constructor it fails, others have pointed to this being a quirk of Groovy where it requires a default constructor be declared directly, this is a quirk of Groovy, which should not be confused with java because they are not the same, for reference:
http://stackoverflow.com/questions/25408641/groovy-could-not-find-matching-constructor

Please squash this into a single commit.  After that I guess it wouldn't be a big deal to merge it.

Done

Thanks

Done

@GaelicGamer Please fix merge conflicts

Any update on this?

@GaelicGamer I'm resolving the merge conflict now, testing, and merging this if it all checks out.

After testing, this has been added by another pull request.  I'm closing this one since it's already in master.
ref: https://github.com/jenkinsci/slack-plugin/pull/236/files#diff-f2606fe35028acac90e7e466dc4f5d4cR231


feat: initial implementation of spanfiltering package

Transpilation from parsed AIP filters to Spanner SQL filters.

Codecov Report

Merging #52 (1b61dea) into master (9505b57) will increase coverage by 0.00%.
The diff coverage is 42.56%.

@@           Coverage Diff            @@
##           master      #52    +/-   ##
========================================
  Coverage   42.36%   42.37%
========================================
  Files          18       20     +2
  Lines        2960     3108   +148
========================================
+ Hits         1254     1317    +63
- Misses       1642     1709    +67
- Partials       64       82    +18

Impacted Files
Coverage Δ

spanfiltering/transpiler.go
41.37% <41.37%> (ø)

spanfiltering/transpile.go
100.00% <100.00%> (ø)


TLS version?

I can't seem to find any options here or on Gun about setting the TLS version.

You can pass it in Gun connection options:
config :machine_gun,
  default: %{
    conn_opts: %{
      transport_opts: [versions: [:"tlsv1.3"]]
    }
  }

versions is documented here http://erlang.org/doc/man/ssl.html#type-protocol_versions


code to generate figures in notebooks file

Hi Keunhong,
This is really nice work and I am wondering if you have tested the code to generate figures in the notebooks file (like hypernerf_ap_ds_figure.ipynb). I run this code and seems cannot work. Could you give some hints on how to use these code in  the notebooks file?
Thank you so much!

Hi Heng,
Those are mostly there for posterity and unfortunately they won't run out of the box. The best way to get them running is probably to make a fresh notebook and copy each cell sequentially while making sure you understand each line.
Thanks,
Keunhong

Hi Keunhong,
Thank you so much for your reply! I think I have run one of them successfully and I will keep looking into others.
Thank you again!


Adding comets wake to steam list

There were the following issues with your Pull Request

Commit: de8154d95ffe0e34e197fcd732d0aaf6f8c15d68
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com


Define keywords for flex components

This pull request defines the keywords that can be specified for template messages and flex messages as enums. In addition to keywords, template messages and flex messages can specify values in percentages or pixels.
(e.g. image size in flex message: https://developers.line.biz/en/docs/messaging-api/flex-message-layout/#image-size)
Therefore, we will not define the new enum as a value that can be specified for template messages and flex messages.
The main purpose of this change is to provide support for users who use the bot SDK to have the option to use enums.
Resolve https://github.com/line/line-openapi/issues/42

Thank you for review!


golangci-lint: 1.21.0 -> 1.22.2

Motivation for this change
This PR updates golangci-lint to its latest release. It also replaces the legacy buildGoPackage with buildGoModule.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @anpryl @manveru

@GrahamcOfBorg build golangci-lint


Build(deps-dev): Bump @typescript-eslint/parser from 7.1.1 to 7.6.0 (#5687)

Pull request opened by the merge tool on behalf of #5687

Merged in 5d2781acd74502e338a305904286daa0ea85a1e8


Services button not working and alignment of join us icons ,working of footer

1)The services button is not working. I want to direct on clicking the button to the page including all the past services along with number of people engaged with website through different services. The increase in the number of sample testimonials .
2)Responsiveness in the Join Us icons
3)Clicking on address in bottom should open map to direct to the exact location, working of each option in the footer
#Please assign this issue to me

Yes sure, go ahead @KanchandeepK . Open a PR with required screenshots. We willr eview it soon!


Using multiple operators in a function results in an error

Describe the bug?
NameError occurs when using multiple operators such as + and - in a function
However, it is not certain that this is currently the cause of the error
Reproducible code
>>> add x, y , z  = x + y + z

Expected result
No error
Actual result
Error[#0945]: File <stdin>, line 1, in <module>::a

1 │ add x, y , z  = x + y + z
                    ---------
                            ╰─NameError: Outputという変数は定義されていません

Erg version
Erg 0.5.11-nightly.2
Python version
3.10.6
OS
Windows 10

I am already aware of this problem. In fact, you cannot type this function even in Rust. Please try it. That's how difficult it is to type this function.
In theory, this function has the following type:
add: |Y: Type, Z: Type, X <: Add(Y), X.Output <: Add(Z)|(X, Y, Z) -> X.Output.Output

The reason why the inference fails is that Erg cannot yet quantize the dual projection type.

If it is difficult, does that mean that this will not be resolved in the foreseeable future?

I will work on resolving this issue for a while, but I don't know how long it will take.


Make sure overhead block weights are generated correcly

I'm not sure this we should be using No Relay for overhead weights, as it doesn't include the parachain interaction overhead weights.
Talk with @JoeCap08055 who setup the overhead benchmarks and see what he thinks. The benchmarks look the same below, so perhaps this doesn't matter.
Needs to be resolved before the next release.
Originally posted by @wilwade in https://github.com/LibertyDSNP/frequency/pull/1574#discussion_r1217995423

I think NoRelay is fine... the point of the overhead benchmarks is to calculate the overhead in executing an extrinsic, not including consensus, which would be the part involving the relay chain. None of the substrate examples seem to show running in a relay chain environment. We're interesting in the effort involved in creating a block, not finalizing it.

For reference:
https://github.com/paritytech/substrate/blob/master/utils/frame/benchmarking-cli/src/overhead/README.md

For confirmation, could be worth asking Parity.


Add "checkpoint_mode" kwarg to plotting

The idea behind **kwargs was that we may be able to pass some additional arguments to plotly calls without specifying them directly, like plt.line(data, **kwargs).
I can see it's hard to make it work that way because we have multiple plotly calls
kwargs.get(arg_name, default) doesn't make much sense, we'd be better off just defining arg_name as an argument to the function
but if we can't make it simple and configurable, let's just make it simple and non-configurable. so remove the kwargs and add checkpoint_mode argument

also, please remove the commented code


synt test

added get data loader function for synthetic task
ignore wandb local logging
rebuilt docs
updated minimal traning example notebook for synthetic task
rebuilt docs

error with tests in data

error with tests in data


Attempting to expose docker auth configs to libcompose users

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "vmaster" git@github.com:vito-c/libcompose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


[docs] use versionadded, versionchanged and deprecated directive

📚 Documentation
Use .. versionadded::, .. versionchanged:: and .. deprecated:: directive, so that user knows which features are added / changed / deprecated in which version and they can navigate the docs easily without changing the docs from version to version.
Ref: https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-versionadded
Similar of https://github.com/PyTorchLightning/pytorch-lightning/issues/5676
cc: @akihironitta
What do you think?

@ydcjeff Hi, it'd be nice to have these for sure! but Bolts is still quite unstable, which means that adding these sections may lead to very noisy docs, so how about adding these sections after launching v1? (not sure when it's going be though)

Yes, v1 is a good option.


No Persona bar after update from 8.0.4 to 9.1.1

Summary
I'm in the process of updating a DNN install from 7.4 to 9.2.
I followed the upgrade path and first updated from 7.4.2 to 8.4.2.
After checking everything still functioned I updated to 9.1.1 which seemed to go fine too until the website loaded and I noticed the Persona bar was not loading.

I checked the browser console and noted the following error:
Uncaught TypeError: Cannot read property 'NormalUpdate' of undefined
    at main.js?cdv=166&t=0.44484758900009647:526
    at l (knockout.js?cdv=166&t=0.9757429735691916:44)
    at Object.a.w.a.j (knockout.js?cdv=166&t=0.9757429735691916:47)
    at onResxLoaded (main.js?cdv=166&t=0.44484758900009647:525)
    at util.js?cdv=166&t=0.9757429735691916:69
    at Object.success (sf.js?cdv=166&t=0.9757429735691916:51)
    at j (jquery.js?cdv=166&t=0.9757429735691916:2)
    at Object.fireWith [as resolveWith] (jquery.js?cdv=166&t=0.9757429735691916:2)
    at x (jquery.js?cdv=166&t=0.9757429735691916:4)
    at XMLHttpRequest.<anonymous> (jquery.js?cdv=166&t=0.9757429735691916:4)

The code which throws the error is the following:
viewModel.updateText = ko.computed(function() {
  return viewModel.updateType() === 2 ? util.resx.PersonaBar.CriticalUpdate : util.resx.PersonaBar.NormalUpdate;
});

So util.resx.PersonaBar is undefined.
I searched for hours for a solution but couldn't find anything that worked.
The Website folder is not in the root of the drive, all permissions are set correctly and I checked the bindingredirect for Newtonsoft.Json.
I also tried to update to 9.2.2 but this resulted in an Empty Persona bar with a similar error.
Affected version

[x] 9.2.2
[x] 9.1.1
[x] 8.0.4

Do you have any ideas what could be causing this?

did you clear local browser cache and cookies?

Yes I did

Anyone have any idea how I could fix this?

In 9.2.2 I recently experienced an empty Persona bar (present but not populated) after someone uploaded an edited web.config file in binary mode. The end of the file had a bunch of NULs in it and other miscellaneous stuff from the body of the file. I removed everything past the proper end of the file and uploaded. My Persona bar then appeared and functioned properly. Worth checking. Wish your case is this simple.

did you unblock the downnloaded upgrade package (in file properties) prior to unzipping the files contained and copying it over the existing files?

Hmm, is the file admin/personaBar/scripts/util.js present ? This is where the util.resx is initialized...
Do you get errors in the network tab of the browser developer tools (maybe some files not loading or 404 or 500 errors)?
Did you try different browsers?
Are there other javascript errors before the one for this issue, sometimes one failing script breaks others...

Also, does it happen in the same environment when you install a new 8.0.4 and then upgrade it ? If so, maybe revert then create a page with no modules and the default skin, then upgrade and try if it also happens on that page.

This issue was a support issue, and not a confirmed issue.  Closing for now

For anyone else, make sure you check your newtonsoft.dll versions. Third party modules can mess this up by overwriting the dll to a newer version.

For me this turned out to be a JSON serializer setting I had added in my custom web API code. In my RouteMapper.RegisterRoutes I had the following line:
config.Formatters.JsonFormatter.SerializerSettings.ContractResolver = new CamelCasePropertyNamesContractResolver();
As that's what I prefer for my endpoints. Commenting that line out fixed my problem as camel casing was causing an issue with this DNN API call:
/API/personaBar/localization/gettable?culture=en-US
The code making that call expects Pascal case.
I'd check the API call above and make sure the property names are coming back as Pascal case.


Clean up the dependencies

Focus:

remove any unused dependencies
remove async-std
use minimal necessary features for tokio and libp2p
check if async-trait is still needed
remove serde_derive and replace with --features=derive on serde
update existing dependencies


完善readme.md

Coverage decreased (-4.6%) to 78.462% when pulling 66119855d787a7684183f21d09b0f7217f2de144 on homels-kong:master into 3f4feba38f450e478ce190bd548355ed678d19e4 on lavas-project:master.

Coverage decreased (-4.6%) to 78.462% when pulling 66119855d787a7684183f21d09b0f7217f2de144 on homels-kong:master into 3f4feba38f450e478ce190bd548355ed678d19e4 on lavas-project:master.

欢迎这位小哥下次给我们提PR，我理解这次是测试并且测试成功了吧？？^_^


openeuler 24.03 arm64 default not found

Describe the bug
$ orb create openeuler:24.03 open24
[-32098] create 'open24': make rootfs: image not found: {openeuler 24.03 arm64 default}

OrbStack info:
  Version: 1.7.2
  Commit: 50f93373f351fe839fd72948e6aad032774c0f6c (v1.7.2)

System info:
  macOS: 14.6.1 (23G93)
  CPU: arm64, 11 cores
  CPU model: Apple M3 Pro
  Model: Mac15,6
  Memory: 36 GiB

I can select this distro from ui, cannot create successfully

To Reproduce
No response
Expected behavior
No response
Diagnostic report (REQUIRED)
No response
Screenshots and additional context (optional)
No response

Fixed.


why my elasticsearch one element array will return string

I save my data using the api

curl -XPOST 'http://myip.com/index/type/id' -H 'Content-Type: application/json' -d '{ "twoarr": [ "a", "b" ], "onearr": ["a"] }'

and the mapping create automatically:

{
"type": {
"properties": {
"onearr": {
"type": "string"
},
"twoarr": {
"type": "string"
}
}
}
}

search:

curl -XGET 'http://myip.com/index/type/id' -H 'Content-Type: application/json' -d '{}'

this is the result:

{"twoarr":["a","b"],"onearr":"a"}

why the one element array convert to string automatically......
I want this:

{"twoarr":["a","b"],"onearr":["a"]}

thank you.

Hi, I think this is the default elasticsearch behavior.

From elasticsearch documentaion:

In Elasticsearch, there is no dedicated array type. Any field can contain zero or more values by default

But in elassandra, the elasticsearch properties can be backed by a casandra Set<X>, List<X>, or just X. This is configurable when you define the mapping with a parameter called cql_collection and this is documented here.
The client app may handle that and transforms single values to singleton arrays whenever It knows the properties is logically an array. Don't know if better option exists...

set cql_collection to Set, List or singleton also not work

What do you mean by « also not work » ?
In elasticsearch, all fields are multi-valued, but when a field contains only one value, the field is displayed without brackets.

Le 31 août 2017 à 05:20, BenLuk<EMAIL_ADDRESS>a écrit :
set cql_collection to Set, List or singleton also not work
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/strapdata/elassandra/issues/114#issuecomment-326178500, or mute the thread https://github.com/notifications/unsubscribe-auth/AJzHmc2qFIh7cfL3SXjw9-mGjabKIqp3ks5sdiaLgaJpZM4PFYl_.

The issue here is that ElasticSearch (without Cassandra) returns array with single item in a bracket. We have tested this in the cloud service in Elastic.io. For Elassandra, array with single item is returned without the bracket. The client has to check if this is string (without bracket) then turn the string to a array.
@hksfho  you can show vroyer the codes, the before and after, need to handle the missing bracket.
I am sure why Elassandra and ElasticSearch behaviour differently in this area. If ElasticSearch is app on top of Cassandra (the architecture of Elassandra, it should behave the same as the pure ElasticSearch.
I can see the opportunity to have the ElasticSearch users migrate to Elassandra if they can run their ES app without the code changes.

With elasticsearch, _source document is stored in lucene, with or without brackets for single-value fields. Then, elasticsearch brings back the stored document as you stored it.
In elassandra, _source is not stored as a blob by default, but in some cassandra columns. Then, _source is dynamically rebuild from theses columns, and by default singleton lists or singleton sets are converted to one element (i.e without bracket).
This default behaviour could be change to add brackets in all cases (keep singleton list and set unchanged), but for documents inserted with a no-bracket single value, rebuilt _source would contains brackets surounding the single value (see #80), causing the same different behaviour !
So, the only way to strictly stick the elasticsearch behaviour is to store the _source in a dedicated cassandra column (a compressed blob). This can be done by enabling the _source (disabled by default in elassandra) in your mapping. Then, you will get brackets as you inserted in the _source.
Note that enabling source involve an overhead on disk of course, and changing the _source column in a CQL upsert won't update others columns, nor index its fields. This was primarily intended to store complex geoshape documents.

@vroyer Thanks for your detail explanation. I can see the basic logics. Changing the default behaviour of the system is not a very good idea. We can accept there is variance between ElasticSearch and Elassandra. We have decided to change our client program to handle the issue.
Thanks again. Looking forwards to the upgrade to ES5.5


Freezing application when add this plugin

BUG
Freezing application when add this plugin
What is expected to happen?
application workflow successfully on "  ios "

What does actually happen?
when i add this plugin the application became freezing , cant navigate to any page on " ios " , if i remove it everything work
successfully . but i can't upload it without this plugin because apple support wkWebview
Command or Code
config xml :

need location access to find things nearby

Bluetooth permission is required because of X, Y and Z

Camera is used for scanning barcode

You can upload your profile picture using your Photo Library

You can upload your profile picture using your Photo Library

en

ebdaauserapp

need camera access to take pictures

need microphone access to record sounds

need to photo library access to get pictures from there

need location access to find things nearby

need to photo library access to save pictures there

Environment, Platform, Device
this is issue on all ios system mobile application
What are relevant versions you are using?
Cordova:

work on cordova  ios platform 5.0.1

-built environment ios platform ---> 5.1.1
-built environment ios Xcode---> 11.3
Other Frameworks:

framework7 mobile ( https://framework7.io/docs/ )

Monaca: Cloud-Powered HTML5 Hybrid Mobile App  to upload app to Xcode ( https://console.monaca.mobi/dashboard )

plugin i have

cordova-plugin-app-version

cordova-plugin-call-number

cordova-custom-config

cordova-plugin-device

monaca-plugin-monaca-core

onesignal-cordova-plugin

cordova-plugin-splashscreen

cordova-plugin-whitelist

cordova-plugin-wkwebview-engine

Checklist

[ x ] I searched for existing GitHub issues
[ ] I updated all Cordova tooling to most recent version
[ x ] I included all the necessary information above

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.


is it okay to run model without NMS process?

Hi, Thank you for your great work.
I have a question about effect of no NMS process.
If I change class_threshold 0.05 to 0.3, pretrained model result which is obtained by sparse_inst_r50vd_dcn_giam_aug model changes AP:37.6, AR: 47.5 to AP: 35.1 AR: 40.3
I think Dropped AP  is strange. I guess Inference without NMS process is reason.
Please tell me about the reason.

Hi @chansunsong, thanks for your interest in SparseInst!
NMS has little impact on SparseInst for duplicate removal. SparseInst adopts the one-to-one assignment which forces one ground-truth object to match only one predicted object. Exactly, adding NMS to SparseInst will not improve the performance.
However, directly lowering the threshold will remove many positive predictions. In my opinion, this degradation is not due to the NMS.

This issue will be closed, you can open a new issue if you have other problems or reopen it. Thanks for your interest in SparseInst 😊 . If you find it useful in your work or research, could you give us a star 🌟 or help us recommend SparseInst to your friends.


Some farms show many same month periods

Situation

Some farms show many same month periods

Screenshots

Thanks. Fixed in e04cbc9.


Return 'blockquote' if 'quote' isn't defined

What is this PR trying to achieve?
Fix 500 errors.

In ES6, you can leave off the value of an object property if it matches the name of the key, e.g. {foo, bar} is short for {foo: foo, bar: bar}.

You're right, we should actually be returning blockquote on 146 – will update.

I'm new to this, but I believe Flow, which we're using elsewhere, may well have been able to help out with precisely this kind of thing.

I can see that lines 151 and 146 return a map with a single key body, but we return what looks like a set/collection on line 143. What happens there?

Good catch these functions are meant to return a body part, which is { type: string; value: any } - this bodyPart hasn't been defined, but assuming it would be type Quote { data: string, citation: string } - the HTML should be built in the template.

same issue on 146

@davidpmccormick I think this is right - quote at this point hasn't been defined.

static analysis

Yip - I'll get them in.


When detect card wake up other cpu(Ardunio,Esp12,Esp32) ??

Hello Did any one try wake up board from mfrc522 when detect card ?
I want to make door open with battery powered.

To the best of my knowledge, that's not possible. The mfrc522 can not detect a card without a running and connected mcu.
For your use case add an button which temporarily activates your system and shutdown it automatically.


Added regex pattern for chap password validation

Signed-off-by: Sneha Rai<EMAIL_ADDRESS>

@bhagyashree-sarawate please review.


Change return types, use helper functions

Use the sensirion helper functions for reading out commands since
those incorporate CRC checks and big-endian conversions.
Fix a potential issue with the readout of the product id (SHTC1) /
status (SHT3x) happening too quickly after issuing the command that
could cause probe() to fail since the sensor would not be ready to
reply yet.
The helper functions have int16_t return types thus we change the
return types of all functions to int16_t (harmonizing them with the
other Sensirion embedded drivers).
Remove sht3x_disable_sleep. The command stems from when the SHTCx
and SHT3x had a common header file, the SHT3x never supported sleep
and always returned a failure.

Just some PR unrelated comments:
* I think we start keeping a CHANGELOG.md file here as well

Yup, I also think it's worth adding

* Is it possible to have an SHTW2 and an SHTW2_alt at the same time? I guess not because the SHT_ADDRESS is hard coded.

no, not possible at the moment.


Exclude active blocks from the pending RPC

Fixes #1122

Not quite, I think I fixed existing tests

I'd like to work on the tests before merging this

Tests fixed, and also applied this change to pending_exists


Using promises

Hello!
Are you going to add promise support in foreseeable future?
I would also suggest adding support to usage of work 'authorize' to 'authorise'. I'm used to using 'authorize', though both variants are possible :)

Hi @vgoloviznin sorry for the late reply. I'm adding promises now.
Regarding the naming of functions, if this is an important issue for you, could you perhaps open a separate issue for this? Thanks :smile:

@vgoloviznin This has been published as part of version 2.0.0. Notice a potentially breaking change is that checkRequirements have been removed and the checks have been moved to request instead.


Loopback apprtc console logs shows the error message as seen in the screenshot

Steps:

Join a loopback apprtc call in the device Alex with the build 48.0.2555.0/7614.0.0 dev
Check for the errors in the console log

Expected result:
There should be no errors seen
Actual result:
Call is connected properly, audio and video functions as expected, but i am seeing the error message as seen in the screen shot attached.

Thanks for reporting!
@samdutton have you changed anything yet on computengineondemand?

Jiayang fixed it by reverting a computeengineondemand push.


Leaflet 1.7.1 causes 2 click events to be emitted by Leaflet Controls in Safari

Steps to reproduce
Steps to reproduce the behavior:

set up a basic map, with a control that has a button in it, which listens for click events and posts the events to the console
click the button in the control using Safari on a Mac
see two click events in the console, one with isTrusted:true and another with isTrusted:false attributes

(Using 'force touch' to click the button on a trackpad results in only a single click event being emitted, but it also triggers the Safari preview popup.)
Expected behavior

There should only be one click event emitted, with the isTrusted:true attribute.
Would Leaflet be able to safely filter out the click events with isTrusted:false?
Current behavior

In version 1.6 the expected behaviour is observed. In version 1.7.1 Chrome exhibits the expected behaviour, but Safari doesn't.
The differences between the two events are included below.
MouseEvent 1:
MouseEvent

_simulated: true
composed: false
isTrusted: false
layerX: 15
layerY: 28
offsetX: 15
offsetY: 28
pageX: 410
pageY: 46
screenX: 1390
screenY: 189
timeStamp: 499337
webkitForce: 0
x: 410
y: 38

MouseEvent 2:
MouseEvent

composed: true
isTrusted: true
layerX: 15
layerY: 20
offsetX: 15
offsetY: 20
pageX: 410
pageY: 38
screenX: 1390
screenY: 189
timeStamp: 538265
webkitForce: 1
x: 410
y: 38

_simulated, composed, isTrusted and perhaps webkitForce seem to be the key differences, but it also seems odd that there are different timestamps and Y dimensions between the two events.
Environment

Leaflet version: 1.7.1
Browser (with version): Safari 13.1.2
OS/Platform (with version): OS X 10.13.6 and 10.15.6

Additional context

I noticed this after OpenStreetMap updated to the latest version of Leaflet, where the issue manifests itself by preventing some of the map tools to be used as the first event toggles a tool on and the second toggles it off. Related issue posted at https://github.com/openstreetmap/openstreetmap-website/issues/2811
Minimal example reproducing the issue
Please see https://codepen.io/dankarran/pen/JjXMXzd

Minimal example reproducing the issue

For the sake of clarity: that example is using
    L.DomEvent.on(container, "click", function(e) {

Would Leaflet be able to safely filter out the click events with isTrusted:false?

It would be possible to do so, in addOne() in DomEvent.js, around https://github.com/Leaflet/Leaflet/blob/4f32a5e83525a3a42980c974e48712b058510eb5/src/dom/DomEvent.js#L109
With a new branch in that if-then-else chain, something probably like
} else if (Browser.safari && !Browser.mobile && type === 'click') {
  handler = function (ev) {
    if (ev.isTrusted) { originalHandler(ev); }
  }
  obj.addEventListener('click', handler, false);
} // etc

However, I do not own any Apple hardware (at the moment), so I'm unable to test this; and I don't know if this might impact previous versions of desktop Safari.

The simulated event comes from https://github.com/Leaflet/Leaflet/blob/4f32a5e83525a3a42980c974e48712b058510eb5/src/map/handler/Map.Tap.js#L100
So I suggest changing the condition at https://github.com/Leaflet/Leaflet/blob/4f32a5e83525a3a42980c974e48712b058510eb5/src/map/handler/Map.Tap.js#L87
into something like
if (this._fireClick && e && e.changedTouches && !(Browser.safari && !Browser.mobile)) {

However, I do not own any Apple hardware (at the moment), so I'm unable to test this; and I don't know if this might impact previous versions of desktop Safari, or other browsers (Does the bug maybe reproduce on firefox mobile?).

I think this bug has been introduced at
https://github.com/Leaflet/Leaflet/pull/7010/files#diff-c2e3d5ef35bf1c4a7c6b549ddf734725R134
@johnd0e , can you have a look? Maybe you introduced that change to account for iOS but unintentionally affected desktop macOS?

Thanks for looking into it @IvanSanchez. I'm happy to help testing any proposed changes on Safari on Mac or iOS.
Just to add, there is a related problem in Safari on iOS, but it seems to behave slightly differently. I haven't done much testing on that.

@johnd0e , can you have a look? Maybe you introduced that change to account for iOS but unintentionally affected desktop macOS?

That was definitely meant to address iOS issues, see discussion: https://github.com/Leaflet/Leaflet/pull/7010.
And we use safari property intentionally, in order not to be tooo specific.
Possible quickfixes:

introduce Browser.ios property
or use Browser.safari && Browser.mobile

But what if tomorrow we will get macbook with touchscren? That will break it all again.

So I propose to apply quickfix (Browser.safari && Browser.mobile) ASAP, and then discuss ultimate solution here: #6980

* or use `Browser.safari && Browser.mobile`

I like this approach (as a "quick & dirty" fix).

But what if tomorrow we will get macbook with touchscren? That will break it all again.

You know that my answer, in the end, is gonna be #7200 :-)

You know that my answer, in the end, is gonna be #7200 :-)

I am not so sure)
But anyway, I'd prefer to fix all we can staying in current approach, and then move further (to #7200 or whatever).

Unsure whether this is the same issue (so please forgive tagging on existing ticket), but shift-drag to zoom in is also broken in 1.7.1 on desktop Safari.

@systemed Can you please try shift-dragging using https://s3.amazonaws.com/leafletjs-cdn/content/leaflet/master/leaflet-src.js ? (e.g. https://plnkr.co/edit/v4GzrCYSxpIO1aOo ) That's a build from master that already includes the changes from #7260.

Spot on - that works fine. 👍

As appeared, the same issue affects not only desktop Safari, but also legacy Edge (and who knows what else).
AFAIK atm tap handler is needed for iOS only.
So... May be we should change map.options.tap default to false.

I've updated my codepen to use the code built from master, and also to display the events to make it easier to test on mobile.
It's working well on desktop Safari, but unfortunately, it looks like mobile Safari is still firing off two click events.

If the JS at https://s3.amazonaws.com/leafletjs-cdn/content/leaflet/master/leaflet-src.js is the latest version, it's still firing two click events on iOS Safari.

@dagjomar
Are you able to inspect those events?
It may be different issue.
Because on touchstart (and pointerdown) we prevent click here:
https://github.com/Leaflet/Leaflet/blob/dda26ba96d7dc79213818d1bcc0565b6ac3c69c4/src/map/handler/Map.Tap.js#L43
And I do not see any reason why that might not work.

@johnd0e I'll see if I can get some more details out, and let you know. Would it make a difference what type of element was used (e.g. a or button which would have their own click handlers vs div which wouldn't)?

I've updated the codepen to log some simplified event details to the console on there. The events on iOS seem to be the same as seen on the desktop before this update:
type: click
isTrusted: false
composed: false
_simulated: true
webkitForce: 0

type: click
isTrusted: true
composed: true
webkitForce: 1

Also, a and div elements behave the same, and adding e.preventDefault() in my event handler doesn't solve it.
Let me know if there's anything else you'd like me to try @johnd0e?

Is it possible that the following lines aren't needed, if Safari is firing its own click events on mouseup?
https://github.com/Leaflet/Leaflet/blob/4f32a5e83525a3a42980c974e48712b058510eb5/src/map/handler/Map.Tap.js#L98-L101

By the way, I've just checked and Chrome (v85) on iOS is behaving the same, with two events fired.

Ok, see what I've found:

Preventing mousedown/pointerdown does not cancel click. Only touchstart can be prevented.
But currently Leaflet has rather weird behavior: when pointer events are available - it substitute touch events with pointer events.

That's why we now have those extra clicks.

If it helps as a quick fix as a stopgap (and doesn't break other things), commenting out that simulated event does seem to work for me in both Chrome and Safari on iOS...
https://github.com/Leaflet/Leaflet/blob/4f32a5e83525a3a42980c974e48712b058510eb5/src/map/handler/Map.Tap.js#L100

https://s3.amazonaws.com/leafletjs-cdn/content/leaflet/master/leaflet-src.js
^ this version seems to work way better than 1.7.1 in desktop Safari 14.0.
tap or click fires only once 👍

If it helps as a quick fix as a stopgap (and doesn't break other things), commenting out that simulated event does seem to work for me in both Chrome and Safari on iOS...
https://github.com/Leaflet/Leaflet/blob/4f32a5e83525a3a42980c974e48712b058510eb5/src/map/handler/Map.Tap.js#L100

I had the 2 click event issue on all device (desktop firefox, chrome, ios safari, chrome..) and this resolved the issue

The same problem happens to me and only happens in Safari. Chrome and Firefox are only firing the event once MacOS 10.15.6 and Safari 14.0.
I temporarily downgraded Leaflet to 1.6 and everything works normally.

Is there a chance this bug will be fixed?
Does anyone work on it?

As I've already said: the bug is caused by extremely outdated tap handler (#6980).
To get things off the ground we need to make some decisions: https://github.com/Leaflet/Leaflet/issues/7255#issuecomment-691109158
@IvanSanchez @mourner

To get things off the ground we need to make some decisions: #7255 (comment)

@johnd0e I don't have neither the time to test this, nor any iOS hardware. Anyhow, I'm trusting you on this, so I'm greenlighting #7026 (which feels cleaner than #7029)

Does anyone work on it?

You know what'd be cool, @PeterPan73? For you to go ahead with making a couple of builds from #7026 and #7029, and testing those for further compatibility issues, instead of just putting more pressure on the maintainers.

so I'm greenlighting #7026 (which feels cleaner than #7029)

Unfortunately in last commit of #7026 I had to apply ugly workarounds in order to overcome other bugs (which in turn can be addressed by #7029 and #7059).
So in the end we still will have to deal with #7029 and other connected PRs, that's why I've united them all under https://github.com/Leaflet/Leaflet/projects/1

I run into this issue on macOS 10.15.7 using Chrome 85 DevTools with iOS device enabled. The quickest workaround for me has been to use lodash debounce function.

Today I ran into an issue, which seems connected to this one, so I will post my experience here.
This occurs with the Macbook trackpad and I discovered it, when trying to add a custom contextmenu to the map.
What happens is that, once the map has focus, even if you right click for the contextmenu, Leaflet will fire a simulated   event, which should not be fired and has button value 0. This leads to weird interactions with my close handler for the contextmenu.
To produce the bug you can go to https://leafletjs.com and then:

Click on the map (so the map has focus)
"Right click"
Click on the map
"Right click"

What you will see is that the cursor is in dragging mode and once you twice click on the map (once the close contextmenu and once to trigger click event) the map will jump.
Maybe this relates also to some other issues (e.g. #6865).

This twice click event (on trusted on not) occurs for me on 1.7.1 when simulating mobile on Chrome and Firefox on desktop Linux (didn't happen on 1.6). Works well on real Android touch devices though (Chrome/Firefox tested). I have for now solved it by implementing my own bounce timer in the click event handler, filtering out clicks that happen within 150 ms from the last one.

I have for now solved it by implementing my own bounce timer in the click event handler, filtering out clicks that happen within 150 ms from the last one.

Hi @atorger, how did you implement this? I tried event.originalEvent.preventDefault(); in the onClick event handler, but with no success. Can you share a minimal example? 🙏 😄

I have for now solved it by implementing my own bounce timer in the click event handler, filtering out clicks that happen within 150 ms from the last one.

Hi @atorger, how did you implement this? I tried event.originalEvent.preventDefault(); in the onClick event handler, but with no success. Can you share a minimal example? pray smile

sure:
var lastClick = Date.now();
e.addEventListener('click', function(event) {
var now = Date.now();
var diff = now - lastClick;
lastClick = now;
event.stopPropagation();
if (diff > 150) {
// handle the click event
}
});

Note that this issue also causes bindPopup to not work with markers:

Version 1.7.1: Nothing happens when clicking the marker https://jsfiddle.net/danmichaelo/gnds7a8o/15/
master: Works as expected again 🎉   https://jsfiddle.net/danmichaelo/gnds7a8o/16/

I ran into this problem in firefox as well (and mobile safari). I was not able to reproduce it reliably but the hint that it comes from the tap option led me to the solution which disables tap entirely as I apparently don't need it to open the popup, even on mobile safari:
var map = L.map('map', { "tap": false });

I ran into this problem in firefox as well (and mobile safari). I was not able to reproduce it reliably but the hint that it comes from the tap option led me to the solution which disables tap entirely as I apparently don't need it to open the popup, even on mobile safari:
var map = L.map('map', { "tap": false });

Thank you for this solution, @eikes! I ran into this issue today and that solved it.

I apparently don't need it to open the popup, even on mobile safari:

On mobile safari tap handler is needed to simulate contextmenu event on taphold.

This bug fires two touches when trying to click on map on a mobile device.

I can confirm. multiple users reported popups not working for iOS for our map using Leaflet.

See https://github.com/domoritz/leaflet-locatecontrol/issues/280 and the workaround that fixes the issue.

This issue prevents menus from working on Safari. For example, openstreetmap loses its map tools. As no one is assigned to this bug, it may not get attention.

Today I faced with the same bug on the last version of the iOS. Popup appears and closes instantly due to duplicate click.

disabling tap altogether fixes this for me on safari (using leaflet from react-leaflet)
var map = L.map('map', { "tap": false });

works great!
source: https://bleepcoder.com/leaflet/694192486/leaflet-1-7-1-causes-2-click-events-to-be-emitted-by-leaflet

Disabling tap fixed the problem for me also.  But I'm using React-Leaflet, and the MapContainer component has a tap prop that can be used for disabling tapping.
<MapContainer tap={false}>

For anyone using Vue-Leaflet, setting tap to false seems to work to resolve the issue, but remember that vue-leaflet only allows some options to be passed as props to the map component directly, for the rest (like 'tap') you need to pass a custom 'options' object, as per: https://vue2-leaflet.netlify.app/faq/#how-can-i-specify-leaflet-options-that-aren-t-part-of-a-component-s-props

@johnd0e @IvanSanchez is there now a fix merged or is this still open?

#7026 is meant to fix this, unmerged yet.

Hi! I've read through this thread and I see several notes about this being fixed from the discussions when the thread first started back in 2020 to more recently.
I am still seeing this happening on Safari Desktop.  Is this expected ?
Thanks Justin

@justinjngan see https://github.com/Leaflet/Leaflet/issues/7255#issuecomment-955691965.

This bug is also reproducible on Leaflet 1.7.1 on Gnome Web (Epiphany).

please release 1.7.2 with this fix

@AduchiMergen we are currently in the final phase before releasing 1.8.0. We think we release it with march

@Falke-Design The 1.8 is quite big update which includes breaking changes
IMHO bugfix should be released in a patch update 1.7.2

If 1.8.0 includes breaking changes, why isnt it a 2.0.0 release then??

It has very minor breaking changes that shouldn't affect most codebases, and NPM doesn't upgrade minor versions anyway. v2.0 will have more substantial changes like dropping support for old IE.

Any updates on ETA? I just spent 30 minutes debugging this only to stumble upon this issue after tracing it back to the Marker onClick 😅

@SpencerKaiser can you try leaflet@beta?

@mourner one of the devs on my team (@joswayski) is still looking into it but he did find this one breaking change... looks like the Ukrainian flag is misaligned 🤣 Want us to open new issue for that?
Also do yall have an eta on the next release? I'm fine using the beta build for now, but I'm worried about future releases breaking us, so I'm nervous about checking that in as permanent fix.

@SpencerKaiser yes, please make an issue or at least a minimal reproducible live test case! Seems like some kind of CSS conflict.

Also do yall have an eta on the next release? I'm fine using the beta build for now, but I'm worried about future releases breaking us, so I'm nervous about checking that in as permanent fix.

ETA a few days. Very likely at the end of the week.

The off topic police are going a bit overboard here 🙄 the comment directly above this one is directly related to this issue...

👮


[REFACTOR] auth middleware of default-theme

Description
Currently, the auth middleware of nuxt is written in pure JavaScript.
Acceptance criteria

[ ] the middleware is rewritten in TypeScript

closed via #1824


project does not run on Windows

When trying to run on Windows (using Vulkan) I got the following error:
Error: Error { inner: Inner { source: None, backtrace: None, error: ConfigError(File(Os { code: 123, kind: Other, message: "The filename, directory name, or volume label syntax is incorrect." })) } }

I posted in the Amethyst discord -- I wanted to reach you directly as mentioned in the Readme, but no Discord username/number is mentioned. If you need more info, you can reach out to me there. Chish#2578

@krehera Thanks for logging the issue. Last I checked, the game was running fine on Windows. But that was a long time ago. Will look into this as soon as I get access to a Windows system.

If I run cargo run from inside the space menace root directory on Windows 10, the game runs just fine. However, if I then try to run ./target/debug/space-menace.exe, it does produce the same error you are reporting.
The problem seems to be that some of the relative links to files in the /assets/ or /resources/ folders are run from a different directory and are therefore not resolving. A short-term fix is to only run the game using cargo run.

The game uses the application_root_dir utility function provided by amethyst. From the docs on application_root_dir:

Returns the cargo manifest directory when running the executable with cargo or the directory in which the executable resides otherwise, traversing symlinks if necessary.

So you need to move both the executable as well as the configuration (assets/ and resources/) to the same directory for the executable to resolve the path correctly.
Or just use cargo run as @Jazarro mentions.


no functionality of settings and dashboard page

Describe the bug
the settings and the dashboard have no functionality at all
To Reproduce
Steps to reproduce the behavior:

Go to 'profile page'
Click on 'settings or dashboard'

Expected behavior
in the settings page it should allow to update certain things and in the dashboard it should display things
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser Edge
Version 125.0.2535.67 (Official build) (64-bit)

Already @CoderSwarup working
Thanks


Dissertation abstract

need to find a way to populate the dissertation abstract in CV and in RESEARCH with proper markup.

solved with a paragraph text module instead of the WYSIWYG module.


Appstudio update test-component-pac-ytnw

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-ytnw-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
appstudio-init

✅ Succeeded
11 seconds
clone-repository

✅ Succeeded
17 seconds
sast-snyk-check

✅ Succeeded
15 seconds
appstudio-configure-build

✅ Succeeded
35 seconds
build-container

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
20 seconds
sanity-inspect-image

✅ Succeeded
23 seconds
sbom-json-check

✅ Succeeded
44 seconds
clamav-scan

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
11 seconds
sanity-optional-label-check

✅ Succeeded
10 seconds
sanity-label-check

✅ Succeeded
8 seconds
show-summary


Tweaks to be consistent with TailwindUI

Hey. I noticed there were a couple of changes to this plugin used in the TailwindUI documentation. I've tried to recreate them here.
Note the changes in https://github.com/tailwindcss/typography/commit/105184b8a5aab96491531e8c99130758c4f2e22d in particular. These are some minor deviations from what appears to be live on TailwindUI's documentation at the moment, and fix a couple of visual bugs I've spotted.
If you want to hold off on renaming rich-text to prose, let me know and I can just drop that commit.

Hey! This is unfortunately out of date now that we've rewritten and properly release the plugin today, thanks so much though.

No problem! Thanks for the update!


basic map

make a basic leaflet map showing:

[x] a glider and its dives
[x] active missions
[x] links to mission page
[ ] background layers

Get more background layers from https://leaflet-extras.github.io/leaflet-providers/preview/

Background layers can come from GLIMPSE, or from making our own tileserver with SMHI data


Add folder for Changelogs and create tentative changelog for 3.0.0

Current coverage is 79.31%

Merging #1073 into master will decrease coverage by -0.01% as of 95a3169

@@            master   #1073   diff @@
======================================
  Files          167     167
  Stmts         9680    9680
  Branches       316     316
  Methods          0       0
======================================
- Hit           7679    7678     -1
  Partial          0       0
- Missed        2001    2002     +1

Review entire Coverage Diff as of 95a3169

Powered by Codecov. Updated on successful CI builds.

Here’s a possible rephrasing/expansion of the flexible SQL bit:

can use expressions that don’t begin with select as standalone queries, e.g. 5 + 1
added the ^ (power) operator and literal map syntax to SQL²: {4: "four", 3: "three"}


 in notes

In some cases tags like <span font="SegoeUI"...> appear in the notes. Not sure about what needs to be done to reproduce...
I had already implemented a fix for https://bugs.openjdk.java.net/browse/JDK-8133833 but that doesn't seem to catch all cases.

Included in last pull request


Error with publishcopyof

When I use publishcopyof for sending custom structures with a structure size of 80, it crashes.
how do I configure this, I am using the default toml file.

Do you have more information for us, e.g.

which iceoryx version
which OS
where does the crash happen, on the publisher or subscriber
do you have a backtrace
can you share the content of the struct (the data which can be transferred with shared memory underlies some restrictions)

backtrace
*** Segmentation fault
Register dump:
PC(Program-Counter): 0000007f7fcc7ef4
LR(Link-Register):<PHONE_NUMBER>41ade8
FP(Frame-Pointer):   0000007f7f9225a0
SP(Stack-Pointer):   0000007f7f9225a0
CPSR(Process-State):<PHONE_NUMBER>001000
Fault Addr:<PHONE_NUMBER>000000
X0:<PHONE_NUMBER>000000   X1:  0000007f70001128   X2:<PHONE_NUMBER>000000   X3:<PHONE_NUMBER>000000
X4:<PHONE_NUMBER>423ba4   X5:  0000007f7fe4b180   X6:  0000007f63114000   X7:  0000007f7fe4ad90
X8:  0000007f7f922540   X9:<PHONE_NUMBER>787878   X10:<PHONE_NUMBER>000000   X11:<PHONE_NUMBER>000018
X12:<PHONE_NUMBER>787878   X13: 0000007f7fc031a8   X14: 0000007f7fbe2898   X15: 0000007f70003663
X16: 0000007f7fcc7e74   X17:<PHONE_NUMBER>43d0a0   X18: 0000007f7faa8008   X19: 0000007f63114048
X20:<PHONE_NUMBER>000000   X21: 0000007f70001128   X22: 0000007f70000f30   X23: 0000007f7f922730
X24:<PHONE_NUMBER>423449   X25: 0000007f70001090   X26: 0000007f70000f30   X27: 0000007f7f9227d8
X28: 0000007f70000ff0
Backtrace:
/usr/lib64/libstdc++.so.6(ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE9_M_assignERKS4+0x80)[0x7f7fcc7ef4]
./mcuengine(ZZN3iox3cxx12function_refIFvRNS_4popo6SampleI10ice_ObjectNS_5mepoo12NoUserHeaderEEEEEC4IZNS2_13PublisherImplIS4_S6_NS2_13BasePublisherINS2_17PublisherPortUserEEEE13publishCopyOfERKS4_EUlRT_E_vEEOSJ_ENUlPvS8_E_4_FUNESN_S8+0x60)[0x41ade8]
./mcuengine(ZN3iox4popo13PublisherImplI10ice_ObjectNS_5mepoo12NoUserHeaderENS0_13BasePublisherINS0_17PublisherPortUserEEEE13publishCopyOfERKS2+0x70)[0x41abd8]
./mcuengine(_ZN16IceoryxPublisher17publishStructDataERK10ice_Object+0x44)[0x41a678]
./mcuengine(_ZN9DataWrite19write_0x174_ppsDataERSt3mapINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEiSt4lessIS6_ESaISt4pairIKS6_iEEEh+0x3c4)[0x41c024]
./mcuengine(_ZN11CANAnalysis16parse_0x174_DataB5cxx11EPKhhh+0x1b4)[0x4179e0]
./mcuengine(_ZN11CANAnalysis12parseCanDataB5cxx11EjRKSt6vectorIhSaIhEEhh+0xfc)[0x4192a0]
./mcuengine(_ZN10CanManager14processMessageERKSt10unique_ptrI7MessageSt14default_deleteIS1_EE+0x180)[0x41ed3c]
./mcuengine(_ZN10McuManager15dispatchMessageEv+0x17c)[0x414320]

@lhxsm can you share the data structure you want to publish or at least create one which also triggers the crash based on your custom type?
I'm not quite sure but may it be that a std::string is part of your custom type?

@lhxsm can you share the data structure you want to publish or at least create one which also triggers the crash based on your custom type? I'm not quite sure but may it be that a std::string is part of your custom type?

yes, there is a std::string field in!!!!， I commented out this field and it works fine.
what should I do if I need to use std::string?

@lhxsm
Unfortunately sending a std::string won't work (unless you serialize it yourself) as it's using the process local heap. There are a few more restrictions on the types that can be sent through iceoryx. They are documented here.

what should I do if I need to use std::string? use a char array instead?

As a replacement for std::string you can, for example, use the fixed-size iox::string.

Closing the issue. As @mossmaurice already mentioned, there are restrictions on what can be published with shared memory. For alternatives to STL container and vocabulary types please have a look at iceoryx_hoofs

@mossmaurice @elBoberido
Got it，thanks

@lhxsm btw, i'm now shamelessly advertising my upcoming startup ;) Mainly because it will be the only one which is providing commercial support for eclipse-iceoryx. It will be added to the README once it is official and of course every company offering iceoryx support has the right to be added to the README. But back to the off-topic. If you are working for a company and need a deep dive into iceoryx or training or other support, you can reach me via my github profile.


New pkg: netnsenter

We used the same code pattern to enter a network namespace, execute some
code and return to the orginal network namespace. This patch factorizes
the code in a common package netnsenter.
This same code pattern will be used in a couple places more in the
tracepkt gadget, so it is time to factorize.

Tracepkt gadget: https://github.com/kinvolk/inspektor-gadget/pull/427

Thanks!


add permission control service for saved objects and workspace saved objects client wrapper

Description

add permission control service for saved objects
define workspaceSavedObjectsClientWrapper class and add the client wrapper to savedObjects

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report

Merging #230 (7c6e1ef) into workspace-pr-integr (120d3b7) will decrease coverage by 10.58%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##           workspace-pr-integr     #230       +/-   ##
========================================================
- Coverage                66.11%   55.54%   -10.58%
========================================================
  Files                     3392     1188     -2204
  Lines                    65038    23901    -41137
  Branches                 10496     3994     -6502
========================================================
- Hits                     43000    13275    -29725
+ Misses                   19461     9991     -9470
+ Partials                  2577      635     -1942

Flag
Coverage Δ

Linux_
?

_2
55.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

.../core/public/saved_objects/saved_objects_client.ts
92.55% <100.00%> (ø)

src/core/server/index.ts
100.00% <ø> (ø)

src/core/utils/constants.ts
100.00% <ø> (ø)

... and 2501 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanyl I've addressed all the comments and add an unit test for workspace saved objects client wrapper. Would you like to help me review it again?


Invalid partial search error message in domains?nsIp search that doesn't allow partial search

If the rdap server has the "allow_search_wildcars_anywhere" property (in configuration.properties) turned off and a client execute a domains search by nsIP like this:
http://localhost:8080/rdap-server/domains?nsIp=*100.0.0.*
The following error message is displayed:

{"rdapConformance":["rdap_level_0"],"errorCode":"422","title":"Unprocessable Entity","description":"Partial search can only have wildcards at the end of each label"}

However, the message that should be displayed is :

{"rdapConformance":["rdap_level_0"],"errorCode":"400","description":"Invalid IPv4 address : 100.0.0.*"}

because the wildcards are not allowed in domains?nsIP partial search.

The error used to identify the problem was correct (code 422), only the description wasn't completely related to the search made.
Commit 9ed452fbc507171fedb6a2e7b3fd522991b05fff updates the error description to:
"Partial search can only have a wildcard at the end of each octet/field"

However, the message that should be displayed is :
{"rdapConformance":["rdap_level_0"],"errorCode":"400","description":"Invalid IPv4 address : 100.0.0.*"}
because the wildcards are not allowed in domains?nsIP partial search.

This is related to the issue #57, the server isn't the responsible of valid/implemented partial searches, this should be in the implementation; so, the server only validates what it can (eg. wildcards at the end of the label) and the implementation is responsible to indicate that the use of wildcards isn't allowed for IP query params (eg. domains?nsIp, nameservers?ip).

Verified. When an user executes the following search:

http://localhost:8080/rdap-server/domains?nsIp=052.176.234.*

the server returns the following error message:

{"rdapConformance":["rdap_level_0"],"errorCode":"422","title":"Unprocessable Entity","description":"Partial search using IPs isn't implemented, try another search"}

Verified. When an user executes a search filtering by IP and using a wildcard at the beginning of the octet/field when "allow_search_wildcars_anywhere" property is setted as "false", the server returns the following error message:
{"rdapConformance":["rdap_level_0"],"errorCode":"422","title":"Unprocessable Entity","description":"Partial search can only have a wildcard at the end of each octet/field"}

Closing, fixed in Red Dog v1.2


Tweaks related to Camera2D drag margins

Closes #26102
Fixes #23108
Most important change is that settings H/V offset now forces the camera position to update if drag margins are enabled. It can be used to set it's initial offset and I added some lines to docs that clarify the usage.
From other changes, drag margins are disabled by default as requested in first issue.
I also swapped places of V Offset and H Offset, as usually horizontal stuff comes before vertical one in inspector and that inconsistency was triggering me >.>

Curious. Since we're no longer serializing default values like drag margin, does this mean all existing users will have to manually toggle the status of their h_drag_enabled and v_drag_enabled in their inspector once this patch is applied?

Yeah, that's a slight compatibility breakage.
Users who didn't use drag margins won't be affected, aside from two properties getting removed in .tscn files with Camera2D.
Users who used the drag margins will now need to enable them manually. But that's not much work and if this comes into changelog, affected users will know to adapt their projects on upgrade to 3.2.
tl;dr not really a big deal

Rebased.

Thanks!

@akien-mga Added to the changelog :slightly_smiling_face:


fix: redirectTo action and added watcher for updating the alert message

Any feedback 😄

@asonnleitner I was trying to fix the redirectTo functionality locally with this project. I had the same idea as you.. Remove the place it's getting set to null on login. I have been unsuccessful when trying the following:

Register a user.
Delete cookie.
Full page load  /secret (type in URL bar and press enter to ensure a server page load).
Get redirected to /login via the route middleware. At this point the redirectTo should be set, but when the auth composable logs in, it is still null. This is where I would expect to land back on the /secret path.
I think I'm a little unclear on how the useState composable works. But I'd expect the client and the server to have the same ref and the redirect to work correctly.


Temperamental tests

Some of the tests occasionally fail because of poor training.

Okay, in the tests we calculate the accuracy of the MAFs and I think KDEs too by running a series of two sample KS tests between samples drawn from the DE and the original samples used to train. Occasionally one of these KS tests fails because the training is poor (training varies with the random seed since the weights are initialised differently).
A simpler thing to do would be a KS test between the predicted distributions of log-probability vs the log-probability of the original samples. Might be more robust. Also I think the tests currently work with a NS run but should use something from the scipy.stats package.
Also appears there is a bug with tensorflow too after their recent updates (identified in #59 I think).

Would be good to remove the pytorch dependency from the tests as well. Seems to take a long time to install and not really needed.

and test a wider range of python versions.


[BEAM-272][flink] remove dependency on Dataflow Runner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[X] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[X] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[X] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[X] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

+1 seems good except for the comment by @swegner

Thanks. Merging.


gpm should detect duplicated lines with different sha1 in Godeps file

Currently when I specify some dependency twice in Godeps file (each time with different version) then gpm chooses only one and doesn't report any error.
This can cause a lot of trouble to unwary developer.
gpm should fail in such case, listing dependencies that are duplicated.
I'm opting for failing even when both lines are exactly the same (specify the same dependency version).

Just realised I've never replied to this!
I'm not sure we should add this kind of error-checking code, the error condition in this case involves human error and expecting users to check their Godeps file before adding a new line to it shouldn't be too big of a stretch.
I'm open to reconsider but will close the issue for now, feel free to reopen and generate a discussion about it!
Thanks for your contribution :D

expecting users to check their Godeps file before adding a new line to it shouldn't be too big of a stretch

I disagree.
Do not reporting errors from configuration file is a worst thing a tool can do.
Just to give you one concrete example - image one developer added dependency to Godeps file at the beginning of the file and second developer added the same dependency at the end of the file. Third developer git-merged their branches (which can be done without any errors) and ended up with  Godeps file with dependency being added twice.

That could happen,  but it would involve human error on the side of either the committer or the merger. Fighting off human error is a slippery slope: it's really easy to just add more and more babysitting for users and before you know it there's a whole lot of complexity added that isn't really needed to resolve the main problem, only to go around avoidable corner cases.
This is the kind of functionality that I would write in a plugin, this way we can test the waters and see how necessary the feature really is before adding it to core.


SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

$ npm install -g vue-generator
$ vg wizard

let wizardType;
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10)
at startup (node.js:139:18)
at node.js:968:3

$ node -v
v4.4.5

$ npm -v
4.3.0

Vue generator is build for node v6 or higher. Updating to node v6 will fix your issue.
Official Node Long Term Support for node v4 ends april 2017 so now is a good time to update.
https://github.com/nodejs/LTS#lts-schedule


Add gitlab markdown support

Fix #46
Not using gitlab.com in domain because we need to allow command to work on self-hosted gitlab instances too.

Thanks for this PR (and the other one). Much appreciated! I'll find some time to ship a new version this week :)

Nice ! :+1: