C2955, 'sol::wrap': use of class template requires template argument list (sol3)

Previously I was using a version of sol3 from January 28th with no issues. I updated to the version from march 14th (the most recent as of now), and now I am receiving the following compile error with code C2955:
'sol::wrap': use of class template requires template argument list
This error occurs on line 15906 of sol.hpp (using the single header version of sol3).
Here's the minimum code to cause the error:
const char* TestFunc()
{
	return "Test";
}

Lua["TestFunc"] = TestFunc;

Regardless of the other functions I tried, the error remains. Also tried this, which didn't fix it:
Lua.set_function("TestFunc", TestFunc);

Some info about my build environment:

Compiling with c++17, using msvc 2017 version 15.9.8, targeting x86 windows.
Using the single header version of sol3
Using LuaJIT 2.0.5, statically linked.
Only sol preprocessor define I'm using is "SOL_CHECK_ARGUMENTS", it doesn't make a difference if I use it or not.

Let me know if there's other info that'd be useful to you.

I can't seem to repro this in any way, whether I use different Lua versions, x86 vs x64, or more.

Try with latest sol3 beta. I don't know what the problem is to be honest. Best I can guess is that the function might be coverloaded so its ambigous or something: I cannot repro on Windows or Linux, GCC or VS2017, x86 or x64.

I tried the latest version and I'm still having the same problem. I decided to make a new project to see if I had borked the compile settings. One thing I noticed is that by default, the "permissive" flag is used with VS projects. In my main project I have that flag disabled. If I re-enable that flag, I get a different error:
Error C3779 'sol::stack::stack_detail::unchecked_unqualified_get': a function that returns 'decltype(auto)' cannot be used before it is defined
On line 11531 of sol.hpp
I've uploaded a test project where I get the same result. I've included all the lib files needed to compile: https://github.com/Moneyl/Sol3-compile-error-example
The only compilation flag I changed was setting it to use c++17. Everything else should be the default. It's setup to compile for 32bit windows.

How updated is your VS 2017? (That is, does the Visual Studio Installer say it needs to upgrade?)

Good idea. I updated VS community edition from 15.9.8 to 15.9.9, and updated all VS extensions for good measure. The issue persists on both projects. Also, I did a fresh install of windows 10 and vs 1-2 weeks ago, so I don't believe there should be anything exceptional about my build environment.
I tested out the latest version of sol2 and it's working fine, so at least we know that if worst comes to worst I can revert to sol2. It probably won't make a difference, but I'll try switching over to the multi-header version of sol3 to see if that changes anything.

Nope, that didn't solve the problem.

Out of curiosity I downloaded the visual studio 2019 preview and tested this again with that. The issue still occurs. I have no other ideas on what about my system/build environment could be causing this. For now I'm just gonna use sol2 since it's working fine for me and I don't need any of the new features from sol3 just yet. I'll close the issue, and if I manage to get it working I'll be sure to let you know here / on discord.

I don't know what's going on. I turned off the /permissive flag and everything worked out fine, with the current sol3 and the one packaged in the repository. I tried x64 and x86. I don't know what's going on with your installation of the compiler. Sorry! I wish I could help more, but without a way to reproduce this I can't do much...

Wanted to let you know that using the latest version of sol3 and VS2019 16.3.3 I can now compile my project with sol3. Not sure what was causing it, but I'm glad it's working now.

Nice.
A few bugs I was tracking on Developer Community got fixed and they just pushed 16.3.3, so that's probably why! Glad it's all kosher for you.


[e2e]: generic workflow_dispatch branch1 default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/11511154014
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Fri Oct 25 03:13:46 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/11528371969
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Sat Oct 26 03:10:19 UTC 2024
Tests are passing now. Closing this issue.


[MRTK2] Update OpenXR settings

Overview
Only affects our in-repo project. Regenerated some project settings based on the latest OpenXR packages. Also committed a Unity 2020 file that doesn't hurt older versions.

/azp run


Microsoft Sticky Notes

I would like to NOT have Microsoft Sticky Notes removed automatically.  I added the # before the entry in the Appslist text file, but it is still removed whenever I run the app.
I would also like the option to HIDE the Windows Copilot instead of removing it completely, at least for now while it is in Beta mode.  The problem is there is no standalone installer for Copilot so once it's gone the only way to get back is through a Microsoft Windows or Office Update currently.

Heya,
I am unfortunately unable to reproduce the first issue related to the app being removed even after adding the # symbol. Apps get removed and skipped as expected. Did you save the appslist.txt file before executing the script?
As for copilot. Currently Win11Debloat doesn't remove copilot. It disables the feature on a system wide level. To re-enable it use the registry file called Enable_Copilot.reg, which is included with the script in the Regfiles > Undo folder. You may have to restart your PC after running this reg file.

Ok.  I am not sure what is happening then.  I will try again the next time I build a new image.
Thank you very much for your efforts and your response!

 I'll close this issue, but feel free to open a new issue in the future if you encounter any problems :)


Remove unused svg items

It would be interesting if the generated sprite only included the icons that are actually beeing used.
Now everything you add to the folder gets automatically added to the sprite.

I don't think it will possible. First, it requires processing codes in the build time so the module could extract used icons. Second, what we should do with dynamic icons? (<svg-icon :name="x" />)
The only feasible way is generating sprites on the fly, but this solution will cause performance issues.

Sounds fair. I think it's a fair compromise if you just create a directory for all the items and then another where you just pull the ones you want to use.


Updates instructions to run all specs

The README was outdated with regards to running all the specs from the top level.

Hey @Teapane thanks, I actually wanted to update it to look specifically in the "exercises" directory rather than double globbing. Can you update this based on #124 ?


Duplicate arrows

In the diagram generator, some graphs are coming out with duplicate arrows

Fixed in #42


sync to live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/Downloads.md
:white_check_mark:Succeeded

windows-iotcore/GetStarted.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/GetStarted.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Fix] Slow DynamicTableView cell actions

This PR makes sure that the DynamicTableView actions are dispatched to the main dispatch queue asynchronously. Previously, there were sporadic tap events that were visibly slower than others.
Checklist

[x] Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
[x] Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
[x] Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)

Description

This does not makes sense. The delegate method will always be called on the main thread. This adds an unnecessary on queuing actions. Maybe this avoid the problem you are facing, but it is not fixing the root cause of the issue.
What exactly is the problem you are trying to solve here?

Without the proposed changes, the actions in the exposure submission selection screen (QR/Tan/Hotline) sometimes trigger very slow (>0.5s). It is often noticeable for the QR option that triggers an alert. I am also not a fan of adding the DispatchQueue, however it seems to solve this problem.

 The submission flow uses the button for navigation. Only the overview controller relies on DynamicAction.

 The submission flow uses the button for navigation. Only the overview controller relies on DynamicAction.

Open the overview controller
Click the QR option -> Alert opens -> Decline
Repeat Step 2 a few times until you notice a delay. If you are lucky it will already be the first tap.

This  usually takes a few tries. Christopher approached me with this, me and Sandra were able to reproduce it. When I measured the execution time of the showDisclaimer() method, I did not notice an increase in time even when the alert popup was delayed. I checked SO and found other users with a similar problem when using the didSelectRowAt tableview delegate where this was a proposed solution. (I totally agree its a bit hacky)

I cannot reproduce this on my side. Let's have quick chat about this tomorrow. The only thing I notice is a delay in responsibility of the tap target after dismissing the alert controller which is by design.

What's the suggested regression test for the future? Will someone do step 1., 2. and 3. for every PR in the future and raise a hand if they feel that the delay is back?

This does not makes sense. The delegate method will always be called on the main thread. This adds an unnecessary on queuing actions. Maybe this avoid the problem you are facing, but it is not fixing the root cause of the issue.
What exactly is the problem you are trying to solve here?

You are right, the delegate is always called on the main thread, although this does not mean calling the code in an asynchronous manner can't fix the problem he is experiencing.
Especially when the UITableView is operating in the same thread atm.
The solution is not at all reliable though.
As I mentioned in my comment above, looking at the possible values for action the problem is probably one of these. Executing an unknown block or selector (without sanitization by the way) can have any amount of side effects.

Thanks for all the additional input. I will do some further investigation and reopen the PR if I come up with new findings.

My five cents on this, even though I am not part of the project: Please create an issue first. It will be much more sustainable to discuss how to reproduce this issue and see how many people are affected there instead of several PRs. Use it to verify that there is an issue that other people have too, before you start working on the fix.
This is meant as a general advice for this project and I hope you can take it as a friendly attempt to help. More on this to be found on the internet.


chore: update form generator

#minor
Update to the latest generator.

Remove prefixes
Update LU to support intellisense
Fix activity parameters

Coverage remained the same at 56.723% when pulling 12172d51fcafb16442038f4149074f2052e5a4fd on chrimc/prefix into d71ba4c7786434c68355d984e121acd45579b17c on main.


TkFallback is not tested

There is no unit test for TkFallback class, let's create one.

@yegor256 thanks, I added the "bug" tag

@yegor256 thank you for the ticket reported, I topped your account for 15 mins, transaction 000-15e57ecd

@andrewbol please go ahead, it's your task now, keep this in mind, and don't hesitate to ask any technical questions you may have
This task's budget is 30 mins. This is exactly how much will be paid when the problem explained above is solved. See this for more information

@davvd assign someone else pls

@davvd assign someone else pls

@yegor256 all right, we'll find someone else for this task

@dmzaytsev can you please help? Keep in mind this. If you have any technical questions, don't hesitate to ask right here
The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

@yegor256 the PR has been merged
close the issue please

@dmzaytsev thanks!

@dmzaytsev I just added 30 mins to your account, many thanks for your contribution.. 54223443 spent here
+30 added to your rating, current score is: +105


Fixes #8: allow to set maximumNestingDepth

Add two public methods (to EvalMinifier and JsonSanitizer) that allow setting a custom maximum
nesting depth.
Adds a test method for this behavior (see JsonSanitizerTest).

@mikesamuel You are right. This is now checked in the constructor, and by adding a hard limit that is significantly greater than 64 (4096).

Thanks much.

Sure, thanks for the quick feedback and merge!
Am 29.04.2016 9:26 nachm. schrieb "Mike Samuel"<EMAIL_ADDRESS>
Thanks much.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/OWASP/json-sanitizer/pull/9#issuecomment-215854933


the api is not correct

Maybe the provided api is not updated after new version. I used bower install and the version is ngprogress 1.1.1.
read the source code and find that ngProgress.color('#fff') should be : ngProgress.setColor('#fff');
also .setHeight() instead of .height()

Hey, the latest version in bower is 1.1.2 according to bower info ngprogress. Please try updating the package and let me know if it still is out of sync.


Update sbt-avrohugger to 2.5.3

About this PR
📦 Updates com.julianpeeters:sbt-avrohugger from 2.0.0-RC22 to 2.5.3
📜 GitHub Release Notes
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.julianpeeters", artifactId = "sbt-avrohugger" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.julianpeeters", artifactId = "sbt-avrohugger" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, version-scheme:semver-spec, commit-count:1

Superseded by #132.


D:/Program is not recognized as an internal or external command, executable or a batch file

I have tried installing as per the procedure mentioned in the docs, but keep getting the issue mentioned in the title, when I try to execute
pyrcc5 -o resources.py resources.qrc
Will follow up for any more details

OS: Windows 10
PyQt version: PyQt 5

I met the same problem, have you solve it?

I am facing the same issue. Please help if anyone has any idea about it.

pyrcc is only avaliable in "pyqt5-tools" now. Just install:
pip install pyqt5-tools


cm_plugin_run_custom_task will fail to run a task json if it contains private field

Describe The Bug
cm_plugin_run_custom_task will fail to run a task json if it contains private field. It looks like its because when parsing ${task.as_json}, json_parse will silently convert the boolean value to a string. This seems to happen regardless if I use --collection or not.
A workaround I'm currently using is having the plugin call unset taskjson.private, but im not sure what other boolean fields this issue could be affecting.
To Reproduce

Error Stack
cargo make --allow-private abc
[cargo-make] INFO - cargo make 0.37.12
[cargo-make] INFO - Calling cargo metadata to extract project info
[cargo-make] INFO - Cargo metadata done
[cargo-make] INFO - Project: sample-kmdf-driver
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: abc
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: legacy-migration
[cargo-make] ERROR - Error while running plugin: Source: Unknown Line: 8 - invalid type: string "true", expected a boolean at line 1 column 410
[cargo-make] WARN - Build Failed.

Code Sample
[plugins.impl.test-plugin]
script = '''
taskjson = json_parse ${task.as_json}
taskjson = json_encode taskjson

cm_plugin_run_custom_task ${taskjson}
'''

[tasks.abc]
private = true
plugin = "test-plugin"
script = '''
#!@duckscript

echo "Hello World"
'''

thanks for reporting will check.
i wonder why numbers are ok but bools are not...

confirmed its an issue. the actually fix it, i think i'll have to define a custom deserializer for any non string primitive field that knows to take original type and string type.


problem with pytorch model

I am trying to use shap to interpret genomic deep learning model in PyTorch. The input tensors to shap are three dimensional and have shapes like torch.Size([100, 4, 2000]) for the background and
torch.Size([5, 4, 2000]) for the input samples for shap_values().
I get the following error message:
File "/home/users/bioinf/erane/work/unity/tools/gedai/dna_pytorch_shap.py", line 668, in
main()
File "/home/users/bioinf/erane/work/unity/tools/gedai/dna_pytorch_shap.py", line 215, in main
shap_values = e.shap_values(xdata)
File "/evogene/software/anaconda3/envs/py3.6-env-erane/lib/python3.6/site-packages/shap/explainers/deep/init.py", line 119, in shap_values
return self.explainer.shap_values(X, ranked_outputs, output_rank_order)
File "/evogene/software/anaconda3/envs/py3.6-env-erane/lib/python3.6/site-packages/shap/explainers/deep/deep_pytorch.py", line 221, in shap_values
sample_phis = self.gradient(feature_ind, joint_x)
File "/evogene/software/anaconda3/envs/py3.6-env-erane/lib/python3.6/site-packages/shap/explainers/deep/deep_pytorch.py", line 166, in gradient
grads = [torch.autograd.grad(selected, x)[0].cpu().numpy() for x in X]
File "/evogene/software/anaconda3/envs/py3.6-env-erane/lib/python3.6/site-packages/shap/explainers/deep/deep_pytorch.py", line 166, in
grads = [torch.autograd.grad(selected, x)[0].cpu().numpy() for x in X]
File "/evogene/software/anaconda3/envs/py3.6-env-erane/lib/python3.6/site-packages/torch/autograd/init.py", line 144, in grad
inputs, allow_unused)
RuntimeError: hook 'deeplift_grad' has changed the size of value
On the same machine I can successfully use shap with examples of pytorch MNIST image classification code (like https://www.kaggle.com/ceshine/pytorch-deep-explainer-mnist-example) .  Any hint will be well appreciated.
Eran

Do you get the same error for GradientExplainer as well?

I haven't tested yet my code with GradientExplainer yet. However I have some insight regarding the problem with DeepExplainer. After I isolated the components of my pytorch model, it turned out that the crash occurs in the Conv1d layer of my model. After changing tensor dimensions and using Conv2d instead, I was able to run shap and the results looks fine, although I got a warning message which I am not sure about. I will post it soon.

this is the warning message which I get:
Warning: unrecognized nn.Module: <class 'type'>
Scott, for your question - I don't get the same error with GradientExplainer. With GradientExplainer I can run with either Conv1d or Conv2d.  I also don't get the above warning.

Hmm... @gabrieltseng might have some ideas since he wrote the PyTorch parts.

Hi!
With respect to the warning you are getting (Warning: unrecognized nn.Module: <class 'type'>), this is to tell you that Conv1d isn't implemented in the deep explainer yet. There was a typo in the warning, which has been fixed here: https://github.com/slundberg/shap/commit/714110b0eea969e78437771c50c29dc6cc486605
For the first error, could you send me the model you are using? Because Conv1d isn't implemented in the deep explainer, it should default to not changing the gradient.
Modifying one of the tests to include a conv1d layer does seem to work:
def test_pytorch_regression():
    """Testing regressions (i.e. single outputs)
    """
    try:
        import torch
        from torch import nn
        from torch.nn import functional as F
        from torch.utils.data import TensorDataset, ConcatDataset, DataLoader
        from sklearn.datasets import load_boston
    except Exception as e:
        print("Skipping test_pytorch_regression!")
        return
    import shap

    X, y = load_boston(return_X_y=True)
    num_features = X.shape[1]
    data = TensorDataset(torch.tensor(X).float(),
                         torch.tensor(y).float())
    loader = DataLoader(data, batch_size=128)

    class Net(nn.Module):
        def __init__(self, num_features):
            super(Net, self).__init__()
            self.conv1d = nn.Conv1d(1, 1, 1)
            self.linear = nn.Linear(num_features, 1)

        def forward(self, X):
            return self.linear(self.conv1d(X.unsqueeze(1)).squeeze(1))
    model = Net(num_features)
    optimizer = torch.optim.Adam(model.parameters())

    def train(model, device, train_loader, optimizer, epoch):
        model.train()
        num_examples = 0
        for batch_idx, (data, target) in enumerate(train_loader):
            num_examples += target.shape[0]
            data, target = data.to(device), target.to(device)
            optimizer.zero_grad()
            output = model(data)
            loss = F.mse_loss(output.squeeze(1), target)
            loss.backward()
            optimizer.step()
            if batch_idx % 2 == 0:
                print('Train Epoch: {} [{}/{} ({:.0f}%)]\tLoss: {:.6f}'.format(
                    epoch, batch_idx * len(data), len(train_loader.dataset),
                           100. * batch_idx / len(train_loader), loss.item()))

    device = torch.device('cpu')
    train(model, device, loader, optimizer, 1)

    next_x, next_y = next(iter(loader))
    np.random.seed(0)
    inds = np.random.choice(next_x.shape[0], 20, replace=False)
    e = shap.DeepExplainer(model, next_x[inds, :])
    test_x, test_y = next(iter(loader))
    shap_values = e.shap_values(test_x[:1])

    model.eval()
    model.zero_grad()
    with torch.no_grad():
        diff = (model(test_x[:1]) - model(next_x[inds, :])).detach().numpy().mean(0)
    sums = np.array([shap_values[i].sum() for i in range(len(shap_values))])
    d = np.abs(sums - diff).sum()
    assert d / np.abs(diff).sum() < 0.001, "Sum of SHAP values does not match difference! %f" % (
            d / np.abs(diff).sum())

Hi Gabriel,
Sorry, I think I caused some confusions. I actually had the original error (RuntimeError: hook 'deeplift_grad' has changed the size of value) with the Pool1d layer. After moving to Pool2d, I could run successfully.
The warning( Warning: unrecognized nn.Module: <class 'type'>) is probably related to Conv1d.
So if I understand correctly Conv1d and Pool1d are not yet supported in DeeExplainer. Is there a plan to support them? Is there an updated list of all modules which are supported?
Thanks!
Eran

Hi Eran,
With respect to the warning, it should be fixed by this pull request: https://github.com/slundberg/shap/pull/507 . However, since a conv layer is linear, the default behaviour of the deep explainer when it doesn't recognize the module (to just take the gradient as normally calculated by pytorch) is the correct one, so the results will be correct with a conv1d layer despite the warning.
You are right; there is a bug in the max pool 1d layer; thanks for spotting it! I will look into fixing it.
You can see which modules are explicitly supported here: https://github.com/slundberg/shap/blob/master/shap/explainers/deep/deep_pytorch.py#L313
Thanks,
Gabi

Hi, I'm wondering if it's safe to ignore this warning for the layer types Flatten and/or AdaptiveAvgPool2d?

Hi!

A Flatten layer hasn't been implemented in PyTorch yet. Assuming the flatten layer looks something like what is being implemented here: https://github.com/pytorch/pytorch/pull/22245, then this doesn't affect the gradients - the DeepExplainer should work fine for this.

Support for Adaptive Average Pooling was added here: https://github.com/slundberg/shap/pull/609. However, the correct behaviour for the DeepExplainer for Adaptive Average Pooling layers is to leave the gradient unchanged, since it is linear. This is what the DeepExplainer does when it doesn't recognize a Module, so it should be safe to ignore that warning.

Assuming the BasicBlock you are referring to is this: https://github.com/pytorch/vision/blob/master/torchvision/models/resnet.py#L34, then the explainer should be able to handle it, since all of its component modules have been explicitly implemented.

That information helps a ton, thank you!!

Hi Eran,
With respect to the warning, it should be fixed by this pull request: #507 . However, since a conv layer is linear, the default behaviour of the deep explainer when it doesn't recognize the module (to just take the gradient as normally calculated by pytorch) is the correct one, so the results will be correct with a conv1d layer despite the warning.
You are right; there is a bug in the max pool 1d layer; thanks for spotting it! I will look into fixing it.
You can see which modules are explicitly supported here: https://github.com/slundberg/shap/blob/master/shap/explainers/deep/deep_pytorch.py#L313
Thanks,
Gabi

Hi Gabi,
I had a question, I'm trying to use DeepExplainer for a feedforward Linear model in PyTorch which is run on a Tabular dataset. But I couldn't find any example. Just wanted to know where can I find an example or does DeepExplainer work with Tabular data at all?
I also have a CNN model for text classification and I was curious to know if I can use DeppExplainer for that model or not??
Thank you so much in advance.

I am using a pretrained resnet18 model in fastai for 2 class image classification. I get a similar error
e = shap.DeepExplainer(learn.model, background)

This works fine but the below line gives error
shap_values = e.shap_values(test_images)

Warning: unrecognized nn.Module: Flatten
Warning: unrecognized nn.Module: AdaptiveMaxPool2d
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-63-c68d6304d8ee> in <module>()
----> 1 shap_values = e.shap_values(test_images)

7 frames
/usr/local/lib/python3.6/dist-packages/torch/autograd/__init__.py in grad(outputs, inputs, grad_outputs, retain_graph, create_graph, only_inputs, allow_unused)
    202     return Variable._execution_engine.run_backward(
    203         outputs, grad_outputs_, retain_graph, create_graph,
--> 204         inputs, allow_unused)
    205
    206

RuntimeError: hook 'deeplift_grad' has changed the size of value

The learner created in fastai is like this
learn = Learner(dls, arch, loss_func=CrossEntropyLossFlat(), metrics=[accuracy, f1score],
                                opt_func=ranger,
                                 cbs=[EarlyStoppingCallback(patience = 10, monitor = 'f1_score'),
                                     SaveModelCallback(fname='cat_vs_dog_rs18',
                                                      monitor='f1_score',
                                                      reset_on_fit = False),
                                     ReduceLROnPlateau()])

Could anybody suggest a fix for this?

Hi Gabi,
I had a question, I'm trying to use DeepExplainer for a feedforward Linear model in PyTorch which is run on a Tabular dataset. But I couldn't find any example. Just wanted to know where can I find an example or does DeepExplainer work with Tabular data at all?
I also have a CNN model for text classification and I was curious to know if I can use DeppExplainer for that model or not??
Thank you so much in advance.

@BehnamBarabadi the Deep Explainer should work fine for tabular data

Hi Gabi,
I had a question, I'm trying to use DeepExplainer for a feedforward Linear model in PyTorch which is run on a Tabular dataset. But I couldn't find any example. Just wanted to know where can I find an example or does DeepExplainer work with Tabular data at all?
I also have a CNN model for text classification and I was curious to know if I can use DeppExplainer for that model or not??
Thank you so much in advance.

@BehnamBarabadi the Deep Explainer should work fine for tabular data

@CosmicHunter do you have a script I could use to reproduce the error? (In particular to create dls and arch).

@CosmicHunter do you have a script I could use to reproduce the error? (In particular to create dls and arch).

@gabrieltseng  This is the code for the dataloader and learner that I used.
tf_prob = 0.8
tf_s = 0.8

item_tfms = [Resize((376, 300), method='squish')]
batch_tfms = [Brightness(max_lighting = tf_s, p = tf_prob),
    Contrast(max_lighting = tf_s, p = tf_prob),
    Saturation(max_lighting = tf_s, p = tf_prob), Flip(tf_prob)]

db = DataBlock(blocks = (ImageBlock, CategoryBlock),
                  get_items = get_image_files,
                  splitter = GrandparentSplitter(),
                  item_tfms=item_tfms,
                  batch_tfms=batch_tfms,
                  get_y = parent_label)

dls = db.dataloaders(path, bs=32, num_worker=6)
dls.show_batch(max_n=20)

Model
body = create_body(resnet18, pretrained=True)
head = create_head(nf=1024, n_out=2) # head

arch = nn.Sequential(body, head)

f1score = F1Score(average = 'macro')
learn = Learner(dls, arch, loss_func=CrossEntropyLossFlat(), metrics=[accuracy, f1score],
                                opt_func=ranger,
                                 cbs=[EarlyStoppingCallback(patience = 10, monitor = 'f1_score'),
                                     SaveModelCallback(fname='cat_vs_dog_rs18',
                                                      monitor='f1_score',
                                                      reset_on_fit = False),
                                     ReduceLROnPlateau()])

After this the model is trained and then SHAP is used
import shap
batch = next(iter(dls.train))
images, _ = batch
background = images[:20]
test_images = images[20:24]
e = shap.DeepExplainer(learn.model, background)

The errror comes in the below function
shap_values = e.shap_values(test_images)

@gabrieltseng  This is the code for the dataloader and learner that I used.
tf_prob = 0.8
tf_s = 0.8

item_tfms = [Resize((376, 300), method='squish')]
batch_tfms = [Brightness(max_lighting = tf_s, p = tf_prob),
    Contrast(max_lighting = tf_s, p = tf_prob),
    Saturation(max_lighting = tf_s, p = tf_prob), Flip(tf_prob)]

db = DataBlock(blocks = (ImageBlock, CategoryBlock),
                  get_items = get_image_files,
                  splitter = GrandparentSplitter(),
                  item_tfms=item_tfms,
                  batch_tfms=batch_tfms,
                  get_y = parent_label)

dls = db.dataloaders(path, bs=32, num_worker=6)
dls.show_batch(max_n=20)

Model
body = create_body(resnet18, pretrained=True)
head = create_head(nf=1024, n_out=2) # head

arch = nn.Sequential(body, head)

f1score = F1Score(average = 'macro')
learn = Learner(dls, arch, loss_func=CrossEntropyLossFlat(), metrics=[accuracy, f1score],
                                opt_func=ranger,
                                 cbs=[EarlyStoppingCallback(patience = 10, monitor = 'f1_score'),
                                     SaveModelCallback(fname='cat_vs_dog_rs18',
                                                      monitor='f1_score',
                                                      reset_on_fit = False),
                                     ReduceLROnPlateau()])

After this the model is trained and then SHAP is used
import shap
batch = next(iter(dls.train))
images, _ = batch
background = images[:20]
test_images = images[20:24]
e = shap.DeepExplainer(learn.model, background)

The errror comes in the below function
shap_values = e.shap_values(test_images)

@gabrieltseng is there any fix for this?

@gabrieltseng is there any fix for this?

Hmm... @gabrieltseng might have some ideas since he wrote the PyTorch parts.

Hi @gabrieltseng
Wonderful work!!
This is my model
import tez
class EmotionClassifier(tez.Model):
def init(self, num_train_steps, num_classes):
super().init()
self.bert = transformers.SqueezeBertModel.from_pretrained("squeezebert/squeezebert-uncased")
self.bert_drop = nn.Dropout(0.3)
self.out = nn.Linear(768, num_classes)
self.num_train_steps = num_train_steps
def fetch_optimizer(self):
param_optimizer = list(self.named_parameters())
no_decay = ["bias", "LayerNorm.bias"]
optimizer_parameters = [
{
"params": [
p for n, p in param_optimizer if not any(nd in n for nd in no_decay)
],
"weight_decay": 0.001,
},
{
"params": [
p for n, p in param_optimizer if any(nd in n for nd in no_decay)
],
"weight_decay": 0.0,
},
]
opt = AdamW(optimizer_parameters, lr=3e-5)
return opt
def loss(self, outputs, targets):
if targets is None:
return None
return nn.BCEWithLogitsLoss()(outputs, targets.float())
def forward(self, ids, mask, targets=None):
o_2 = self.bert(ids, attention_mask=mask)[1]
b_o = self.bert_drop(o_2)
output = self.out(b_o)
loss = self.loss(output, targets)
return output, loss
background = df2.sample(100)['comment_text'].values ## array of 100 texts
test_text = df2.sample(5)['comment_text'].values
scaffold = EmotionClassifier()
e = shap.DeepExplainer(model, background)
shap_values = e.shap_values(test_text)
Error……
c:\users\jay\py36\neo\lib\site-packages\torch\nn\modules\module.py in _call_impl(self, *input, *kwargs) 725 result = self._slow_forward(input, *kwargs) 726 else: --> 727 result = self.forward(input, **kwargs)
728 for hook in itertools.chain(
729 _global_forward_hooks.values(),
TypeError: forward() missing 1 required positional argument: 'mask'
Can you help me how can one use SHAP with custom pytorch model, with self.forward method returning loss as well and has two inputs?
Thanks in Advance!!


Update background.js

add functionality for
downloads
history

please wirte commit message as add functionality for downloads or something else ,not update background.js in the future


Fix dangling PID file by checking process name

I know this is still marked as a draft, but it looks reasonable to me, and I'm about to start another round of work on lair. I'm going to merge this through https://github.com/holochain/lair/pull/33 and I'll test / update it as needed going forward.
Thanks for the contribution! :+1:


Helm chart for Enrichment pipeline

Need to determine how we adjust the Ingestion pipeline helm chart to also include Enrichment (both for deployment and for the NiFi flow)
This is just for helping with deployment of the Enrichment pipeline standalone - including DeID (but not ACD, let's leave that up to the user to configure their own)

There is now a Clinical Enrichment pipeline deployable independent of the Clinical Ingestion pipeline. It can be configured to automatically run based on FHIR server updates (FHIR-Trigger) or data can be fed into it directly.  See https://github.com/Alvearie/health-patterns/tree/main/helm-charts/health-patterns#clinical-enrichment


restore readable Changelog, fixes #298

s/\n/\n/g
s/ +\n//g
The URL-decode (" & ' =)

Sorry but the changelog is generated, so this PR is pointless

No problem, good that this was fixed with 919fc8a6db13d2be3c209ddaf030e4b7917d1057.
Please fix the same issue with the gnucobol extension, too.


dashboard/app: no reporting fix bisection results for already fixed bugs

Modify pollCompletedJobs(); for bugs that are already marked as fixed, invalid or duplicate do not report bisection results.
Add TestNotReportingAlreadyFixed() to test that reporting does not occur for already fixed bugs.

Codecov Report

Merging #1415 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
- Coverage    57.9%   57.89%   -0.02%
==========================================
  Files         131      131
  Lines       24840    24846       +6
==========================================
  Hits        14384    14384
- Misses       9788     9794       +6
  Partials      668      668

Impacted Files
Coverage Δ

dashboard/app/jobs.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4680d8...b52d117. Read the comment docs.


[FEATURE] More placeholders

I'd like 2 new placeholders:
%betterTeams_members_<team>% and %betterTeams_members_<team>_online%
%betterTeams_members_<team>% would display how many members are in the specified team.
%betterTeams_members_<team>_online% would display how many members are in the specified team that are currently online.

okay..?
anyway, BookSaw said it's a reasonable feature request, so he may add it.
thanks and have a nice day :)


Poor user and dev experience in Identity email confirmation

From @natelaff on December 30, 2015 19:42
There are two issues using the default template for identity when using email confirmation.
Following the guide here: http://docs.asp.net/en/latest/security/authentication/accconfirm.html
Poor user experience: When you click "Register" it sends the email off, but just redirects the user to the Home controller. Redirecting to something else to indicate they have to confirm their account would be a better example. Perhaps the default template should have such a view OOTB.
Poor dev experience: When logging in with an external account (lets say Facebook) if the account doesn't exist you get thrown into AccountController.ExternalLoginConfirmation, great. This screen requires an email, so you complete the registration then you're logged in but never shoots off the email confirmation link here. Perhaps a commented out section in this action to deal with this would improve the dev experience here.
Copied from original issue: aspnet/Templates#365

From @Ponant on March 6, 2017 9:28
When will this be addressed? It is one year old. A related issue https://github.com/aspnet/Templates/issues/832 .

From @rustd on January 5, 2016 5:4
Thank you for your suggestion. We will look into improving this.

@javiercn, can you please look into this?

@blowdart What should we do here?

Size up the fix, and if it @mkArtakMSFT says there's bandwidth, fix it.

@blowdart I'm asking for your input on the behaviour you expect here.

Add a view which says "An email has been sent to validate your account" or something of that ilk and redirect there.
Fix the external login flow so it verifies emails if enabled.

Can you point me to the implementation of this so I can copy it into my project instead of upgrading my entire project?


major bug - doesnt show up on navigating on to this view.

this issue usually happens when we use listview rather than Flatlist.
Id suggest if you could convert the underlying to Flatlist, this issue will be resolved.

Would you be willing to send a PR?

Seeing the same issue.  Anyone put in a PR yet?

resolved in https://github.com/tableflip/react-native-select-multiple/pull/21


mybatis 3.5.1 mysql LocalDateTime wrong time zone mapping

MyBatis version
3.5.1
Database vendor and version
Mysql 8.0.11
Test case or example project
Example project.
mybatis-bug.zip
Steps to reproduce

Unzip project.
Go to mybatis-bug/env folder and start mysql using docker-compose: docker-compose up.
Go to root folder of project and run it: ./gradlew clean bootRun.

Expected result
--> DB: City{id=3, name='Kyiv', created=2019-05-04T14:38:00.756421}
<-- DB: City{id=3, name='Kyiv', created=2019-05-04T14:38:00.756}

Actual result
Field created is returned in UTC.
--> DB: City{id=2, name='Kyiv', created=2019-05-04T14:35:12.162898}
<-- DB: City{id=2, name='Kyiv', created=2019-05-04T11:35:12.163}

Seems like this commit introduced this issue: https://github.com/mybatis/mybatis-3/commit/963a8a577bc1d9a98e5182a7779a85a3ca834984

Hi @moleksyuk ,
Thank you for the repro, it really saves our time. 👍
As you noticed, we changed the LocalDateTimeTypeHandler implementation in #1478 .
Please see the issue for details.
With your test steps, the server time zone is UTC.
And you (=client) seem to run the test on GMT+0300 time zone.
Although I couldn't find official statement, I think you are supposed to add serverTimezone=GMT%2B3 to the JDBC connection URL in this case. i.e.
jdbc:mysql://localhost:3306/mybatis?serverTimezone=GMT%2B3

Without serverTimezone, you should be able to replicate the issue with a plain JDBC code. e.g.
try (Connection con = getJdbcConnection()) {
  try (Statement stmt1 = con.createStatement()) {
    try {
      stmt1.execute("drop table test");
    } catch (Exception e) {
      //
    }
    stmt1.execute("create table test (id integer, t datetime(6))");
  }
  LocalDateTime ldt = LocalDateTime.now();
  int id = 1;
  try (PreparedStatement stmt = con.prepareStatement("insert into test (id, t) values (?, ?)")) {
    stmt.setInt(1, id);
    stmt.setObject(2, ldt);
    stmt.execute();
  }
  try (PreparedStatement stmt = con.prepareStatement("select t from test where id = ?")) {
    stmt.setInt(1, id);
    try (ResultSet rs = stmt.executeQuery()) {
      rs.next();
      System.out.println("--> DB: " + ldt);
      System.out.println("<-- DB: " + rs.getObject(1, LocalDateTime.class));
    }
  }
}

FYI, I tested various drivers and MySQL Connector/J is the only one (so far) that requires such extra configuration to make it work.
Anyway, please let us know if adding serverTimezone didn't resolve the issue or you found an official documentation that contradicts my explanation.

Hi @harawata

With your test steps, the server time zone is UTC.
And you (=client) seem to run the test on GMT+0300 time zone.
Yep, you are right.

I did some investigation and problem is actually related to mysql driver:

mysql:mysql-connector-java:5.1.47 - stores LocalDateTime to db as is, and it seems logical.
Example:
db time - UTC
java app time - UTC+3
So, if for example LocalDateTime.now() == '2019-05-09 13:00:00 it will be stored in db as 2019-05-09 13:00:00. And of course during read it to LocalDateTime will return the same value.

mysql:mysql-connector-java:8.0.16 - stores LocalDateTime to db with convertion to db timezone 😠 . Why???
Example:
db time - UTC
java app time - UTC+3
So, if for example LocalDateTime.now() == '2019-05-09 13:00:00 it will be stored in db as 2019-05-09 10:00:00. And during read it to LocalDateTime will return 2019-05-09 10:00:00.

Close this ticket due to error in mysql driver.

@moleksyuk ,
I thought it might be the designed behavior, but you are right.
It is filed on their tracker as a bug.
https://bugs.mysql.com/bug.php?id=93444

MyBatis' InstantTypeHandler internally performs conversion between java.time.Instant and java.sql.Timestamp.
You should check that the inserted value in the database matches what you expect.
See this ticket for details.

I'm facing the same problem with MySQL Connector/J 8.0.17
While #1478 changed this:
  // LocalDateTypeHandler.java
  @Override
  public void setNonNullParameter(PreparedStatement ps, int i, LocalDate parameter, JdbcType jdbcType)
          throws SQLException {
-    ps.setDate(i, Date.valueOf(parameter));
+    ps.setObject(i, parameter);
  }

Unfortunately, MySQL Connector/J then does this (AbstractQueryBindings.java#L246):
            } else if (parameterObj instanceof LocalDate) {
                setDate(parameterIndex, Date.valueOf((LocalDate) parameterObj));

            }

which nullifies the gains from #1478 with regards to LocalDate with MySQL 8. This can be fixed with this custom type handler:
public class CustomLocalDateTypeHandler extends LocalDateTypeHandler {

  @Override
  public void setNonNullParameter(PreparedStatement ps, int i, LocalDate parameter, JdbcType jdbcType)
      throws SQLException {
    ps.setDate(i, java.sql.Date.valueOf(parameter), Calendar.getInstance());
  }
}

until/if the MySQL Connector/J is fixed.

This is fixed in MySQL Connector/J 8.0.20 :

When a Calendar was not used, a java.sql.Date value could not always be stored into and then retrieved from a MySQL server consistently. It was because Connector/J always converted a Date value to the server's time zone when storing it on the server as a MySQL DATE; but since a MySQL DATE does not have any time value, the hour, minute, and second parts of the original date was effectively lost. If the converted value is one day ahead of or behind the original value, when the value was retrieved through Connector/J and converted back to the local time zone, there was no time value for adjusting the date back to its original value, resulting in a one-day error. With this fix, any Date value is converted to MySQL DATE value using the JVM's time zone, so that the value is always consistent when being stored and then read back.

Thanks for the info @berniegp !
I did some tests and the fix made in mysql-connector-java 8.0.20 only affected the behavior of LocalDate (and java.sql.Date) and there still was a corner case like 2011-12-30 in Pacific/Apia.
In 8.0.22, bug #93444 has been fixed and LocalDate, LocalDateTime, LocalTime type handlers now should work as expected even when the client is on a different time zone than the server.

Thanks for the info @berniegp !
I did some tests and the fix made in mysql-connector-java 8.0.20 only affected the behavior of LocalDate (and java.sql.Date) and there still was a corner case like 2011-12-30 in Pacific/Apia.
In 8.0.22, bug #93444 has been fixed and LocalDate, LocalDateTime, LocalTime type handlers now should work as expected even when the client is on a different time zone than the server.

no,it does not.It still a mybatis bug.Becuase the old version LocalDateTimeTypeHandler get timestamp first,and the timestamp handler in jdbc can convert the timezone.But the new version LocalDateTimeTypeHandler direct get the value,so does not convert the timezone,so it is a bug and not fix yet.


Setup backcompat tests

Setup some backcompat tests to verify that the sources are stable.

@MikeStall Is this issue still in progress?

Note that Backward Compatibility is not garunteed at this time while in Preview. As needed, tests on Yaml Pack\Unpack will be added on a case-by-case basis for supported scenarios.


Multi-Vehicle Simulation with Gazebo not working: single_vehicle_spawn.launch returns error

There seems to be a problem with the launch files and the models of the UAVs. When I follow the example in the developer guide (https://dev.px4.io/en/simulation/multi-vehicle-simulation.html) the launch (roslaunch px4 multi_uav_mavros_sitl.launch) in step 3 fails with following result:
ERROR [Unknown] Unknown/unhandled parameter: -s
Restoring terminal
process[uav2/iris_2_spawn-8]: started with pid [17474]
[/uav1/mavros:351]: Plugin ftp initialized
[/uav1/mavros:301]: Plugin global_position loaded
process[uav2/mavros-9]: started with pid [17475]
[uav2/sitl_2-7] process has died [pid 17473, exit code 1, cmd <my home folder>/Workspaces/px4/Firmware/build/posix_sitl_default/px4 <my home folder>/Workspaces/px4/Firmware/ROMFS/px4fmu_common -s etc/init.d-posix/rcS -i 2 -d __name:=sitl_2 __log:=<my home folder>/.ros/log/64a1c728-b272-11e8-82c6-3413e83b56c3/uav2-sitl_2-7.log].
log file: <my home folder>/.ros/log/64a1c728-b272-11e8-82c6-3413e83b56c3/uav2-sitl_2-7*.log

This problem originates in the single_vehicle_spawn.launch. If I remove the arg -s [...] part, I get the error for the arg -i [...]. If I also remove that part, the launch proceeds without errors but MAVROS cannot connect to the PX4 SITL flight controller.
This was working properly with v1.8.0 but not with the latest version of the master branch.

Hi @tropappar,
I also ran into this issue. The problem seems to stem from two issues caused by the following code
https://github.com/PX4/Firmware/blob/master/ROMFS/px4fmu_common/init.d-posix/rcS#L84-L88

The shifting of port numbers causes an overlap (specially on port 14557) which shows up as a bind warning then running the launch file.

The MAV_SYS_ID gets thrown off by 1, not sure if this was an issue, but I needed to remove the +1 (see code linked) in order to get it to work.

I'm going to perhaps submit a pull request for my fixes, but for the time being feel free to clone my fixes on https://github.com/k2shah/Firmware. I currently can get the roslaunch px4 multi_uav_mavros_sitl.launch to spawn two quads that I can arm.

@tropappar Can you do a make clean and then rebuild the firmware?
@k2shah You're right, there's a port overlapping, and we can change the local port in https://github.com/PX4/Firmware/blob/master/ROMFS/px4fmu_common/init.d-posix/rcS#L88 to a higher range.
The MAV_SYS_ID should not be an issue, otherwise we need to change the ID in the launch file.

I changed the ID in both the launch file and the rcS file, I was not able to get mavros to connect otherwise. Let me know if I can help, I'm happy to clean up my fixes and submit a PR and attempt to get it to work without changing MAV_SYS_ID

any particular range I should set it for? i was thinking having the
the base UDP ports be
14550 - 14554 and then offset each by 4*idx so that it can scale without future overlaps, are there any port ranges that I need to use/not use?

are there any port ranges that I need to use/not use?

May not be exhaustive, but see: https://dev.px4.io/en/simulation/#default-px4-mavlink-udp-ports

i was thinking having the base UDP ports be 14550 - 14554 and then offset each by 4*idx so that it can scale without future overlaps, are there any port ranges that I need to use/not use?

Yes that makes sense. Since these are the local ports, it doesn't really matter much.

@bkueng A make clean helped to solve the issues with the -i and -s args. Thanks for the hint.
After applying the fixes of @k2shah in https://github.com/k2shah/Firmware/commit/43f396e1b5e6af232a5c083ba170e4399f290458 I am able to arm and take off using MAVROS.

After some more testing I realized there are two ways to start the PX4 SITL simulation: Either using URDF models or using SDF models. Unfortunately, those two ways don't seem quite compatible. All the comments above are related to the URDF models. Simulation can be started using the launch file multi_uav_mavros_sitl.launch. For the SDF format, simulation can be started using the mavros_posix_sitl.launch BUT it requires the +1 in the MAV_SYS_ID!
Unfortunately, the documentation is very poor on the PX4 SITL simulation, so there is a lot of trial and error work involved here...

Yes that's unfortunate, it's hard to pin down what uses the SDF and what uses the scripted UDRF generation. Seems like this is related to why my PR is failing Jenkins. @bkueng can you take a look and help me find what else the rcS file is used for? My guess is that the default ports are hard coded elsewhere too, not sure if i should go down the rabbit hole of changing all the port numbers.
I agree with you with respect to the documentation, there was some old version of the multi uav sim that used different UDRFs. It was a struggle just to find this bug in the first place. Lets hope we can get it resolved for future users!

@tropappar a fix has been pushed. Can close on this?  Thanks to @bkueng  for getting this resolved so quickly!

Can you push the changes to the master, the multi uav simulation is currently not working on ubuntu 18.04 melodic

@pravardhanreddy I'm not sure what changes you mean. Everything should be working, I think :thinking: . Otherwise, I need some more output and information about "not working".

Alright, I'm assuming this is working, otherwise please re-open.

FWIW I would assume so too. @lamping7 and others have played with this recently.


Transpose based on EXIF orientation

Transpose the original image before resizing based on EXIF orientation
information to display image in the correct orientation. If someone
uploads an image from an iPhone (for example) the image is currently
often rendered in the wrong orientation.

Merged in #150


Backport: Errors in rancher logs when delete cluster

Original issue: https://github.com/rancher/rancher/issues/20300

The fix will be available in v2.2.4-rc17

Version: v2.2.4-rc18
I am no longer seeing the issue. A very small handful of [ERROR] entries are seen in the logs but this has been significantly improved. Error entires no longer loop and removal of clusters is significantly faster now. I only had to wait up to 30 seconds to remove many clusters at once (delete all at once).
I consider the issue resolved.


Creating Supporting Information

We were previously able to create Supporting Infromation.
We previously didn't have to add anything in the Definition box.
I have just tried to create one and got this:

@AngelaFaulding I have updated the NHSE test environment with a fix for this.

@pjmonks - this still isn't working. It is still wanting a definition.

A change has now been deployed to the test environment. The "Definition" field is now optional again, if you don't enter a value then it will automatically become the same as "Code" without user intervention required.


Fix PresetText node

Fixes:

#331
#336

Because of Comfy-Org/ComfyUI_frontend#667 (Comfy-Org/litegraph.js#98), it's necessary to subclass nodes to inherit LGraphNode properties.

It seems that the issue is still unresolved.

It seems that the issue is still unresolved.

Do you mean you tested the changes in this PR and the node still doesn't work?

New installation of ComfyUI(Stability Matrix)
git clone https://github.com/christian-byrne/ComfyUI-Custom-Scripts.git
The problem continues.


django setup

I made a folder named Absolute hack for backend

were are your views?

At that time there were not any html file. So, i just change my base too only.

And you could not told the app name as utkarsh told me to setup the app name later


PN Prime Large Window data cannot pass the espfilt stage - how do we SP filter those observations?

I.e. observations like this:

Where PN is only reading out half of all of the CCDs.
That means no corner data, which means that espfilt fails!!
As such the espfilt stage cannot ever complete successfully, and cleaning simply doesn't happen.

Certainly for now it just has to be allowed to fail, we can't include data with an unknown amount of flaring that hasn't been removed.

This is not actually entirely true. For this particular ObsID, the scheduled observation clears espfilt, but the unscheduled does not. Both are in the same mode, so its not PN Large Window's fault.
I misremembered how the default method of espfilt works, and it doesn't actually rely on corner data - so I don't know why that unscheduled one doesn't run through.


Schema v4 Update Guidance: Export Modal

As a PD user exporting a v4 protocol / a protocol with modules, I would like to be reminded that my app and robot have to be on version [tbd] or above before running my protocol.
Acceptance Criteria

[ ] Users informed, on protocol export, that their app and robot must be on version [tbd] to run their protocol, because it includes modules
[ ] Update/information should be displayed as an independent modal, after other export warnings
[ ] User should have the option to "do not show me again"

Design
https://app.zeplin.io/project/5c87a3f55f998e3943ad5d38/screen/5e3a06ed395452b470d63684
Copy
see design

@pantslakz
"This protocol utilizes modules and can only run on app and robot server version 3.17 or higher. Please ensure your OT-2 is updated to the correct version.
Learn more here."


Support setIBMiEnvCmd on connect

Closing as it is documented that "due to limitations in the way that Code for IBM i is architected they will not impact the LIBL shown in the Project Explorer UI"
https://ibm.github.io/vscode-ibmi-projectexplorer/#/pages/ibm-i-projects/iproj-json?id=setibmienvcmd


Link to products on our website for easy purchase

We should link to products of correct frequency on our website for ease of purchase

Fixed in https://github.com/NebraLtd/helium-region-tool


Bug: spin watch broken for nested files

Using spin canary (built from main as of https://github.com/fermyon/spin/commit/47e40b9b38950c55355db575cd1b7ac681292621), I'm seeing behavior where spin watch doesn't trigger a rebuild upon changes to nested files.
Any app with a nested file entry in the watch config should repro, eg watch = ["src/**/*.rs", "Cargo.toml"] as seen in the http-rust example.  When running this example, a re-build is triggered when the Cargo.toml file is amended but not triggered when src/lib.rs is amended.

I had assumed this was due to my manifest refactoring but I couldn't dig up anything relevant. Possibly due to #1784 though that merged Oct 2. @itowlson @calebschoepp

I'm pretty sure it worked at #1784 but will give it a try for sure - thanks!

#1784 works so either something broke in the merge, or it's happened since.


Allow HazelcastLockProvider to reconnect to the client if the connect…

Let clients provide a Supplier, which HazelcastLockProvider can use to refresh the connection to Hazelcast in the event that the connection dies.

Hi, thanks a lot for the PR. I am not a Hazelcast expert, but I would expect that the reconnections should be done by the driver. Can you please explain why setting reconnection mode is not sufficent?

I wasn't aware of that configuration option. I'll see if I can figure out
how to incorporate it into my company's code.
On Thu, May 12, 2022, 1:35 PM Lukáš Křečan @.***> wrote:

Hi, thanks a lot for the PR. I am not a Hazelcast expert, but I would
expect that the reconnections should be done by the driver. Can you please
explain why setting reconnection mode
https://stackoverflow.com/a/48059594/277042 is not sufficent?
—
Reply to this email directly, view it on GitHub
https://github.com/lukas-krecan/ShedLock/pull/1023#issuecomment-1125254810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRS6KLJD4NHWY2KHNL5OY3VJU6NNANCNFSM5VWRFQ7Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

The client configuration is provided by our infrastructure team, but I've asked if the reconnection mode is something they'd be willing to add to the provided XML. That being said, I don't see a way to use the provided client with your alternate approach, although it's probably more useful in the wider world.

Hi, as I think the issue in your configuration I will not merge your PR. If you want to do the reconnect manually, you can wrap HazelcastInstance (in similar way as is done in HazelcastClientProxy). In getMap() method you can implement your reconnect.


Can't find service by service instance id from cache, service instance id is: 152

英文不好，中文说下，异常如下，切换es集群了，为了方便数据没有迁移，会一直报下面的问题，怎么解决？
rg.apache.skywalking.oap.server.core.register.service.ServiceInstanceInventoryRegister - 108 [grpc-default-executor-24] WARN  [] - Service instance 956 heartbeat, but not found in storage.
2019-08-16 14:32:41,008 - org.apache.skywalking.oap.server.receiver.jvm.provider.handler.JVMSourceDispatcher - 51 [grpc-default-executor-83] WARN  [] - Can't find service by service instance id from cache, service instance id is: 152
2019-08-16 14:32:41,008 - org.apache.skywalking.oap.server.receiver.jvm.provider.handler.JVMSourceDispatcher - 51 [grpc-default-executor-75] WARN  [] - Can't find service by service instance id from cache, service instance id is: 956
2019-08-16 14:32:41,009 - org.apache.skywalking.oap.server.receiver.jvm.provider.handler.JVMSourceDispatcher - 51 [grpc-default-executor-44] WARN  [] - Can't find service by service instance id from cache, service instance id is: 902
2019-08-16 14:32:41,009 - org.apache.skywalking.oap.server.receiver.register.provider.handler.v6.grpc.ServiceInstancePingServiceHandler - 68 [grpc-default-executor-24] WARN  [] - Can't find service by service instance id from cache, service instance id is: 956, will send a reset command to agent side
2019-08-16 14:32:41,011 - org.apache.skywalking.oap.server.core.register.service.ServiceInstanceInventoryRegister - 108 [grpc-default-executor-85] WARN  [] - Service instance 902 heartbeat, but not found in storage.
2019-08-16 14:32:41,012 - org.apache.skywalking.oap.server.receiver.register.provider.handler.v6.grpc.ServiceInstancePingServiceHandler - 68 [grpc-default-executor-85] WARN  [] - Can't find service by service instance id from cache, service instance id is: 902, will send a reset command to agent side
2019-08-16 14:32:41,017 - org.apache.skywalking.oap.server.receiver.jvm.provider.handler.JVMSourceDispatcher - 51 [grpc-default-executor-115] WARN  [] - Can't find service by service instance id from cache, service instance id is: 1029
2019-08-16 14:32:41,017 - org.apache.skywalking.oap.server.receiver.jvm.provider.handler.JVMSourceDispatcher - 51 [grpc-default-executor-75] WARN  [] - Can't find service by service instance id from cache, service instance id is: 33
2019-08-16 14:32:41,032 - org.apache.skywalking.oap.server.receiver.jvm.provider.handler.JVMSourceDispatcher - 51 [grpc-default-executor-66] WARN  [] - Can't find service by service instance id from cache, service instance id is: 501
2019-08-16 14:32:41,034 - org.apache.skywalking.oap.server.receiver.jvm.provider.handler.JVMSourceDispatcher - 51 [grpc-default-executor-114] WARN  [] - Can't find service by service instance id from cache, service instance id is: 295
2019-08-16 14:32:41,034 - org.apache.skywalking.oap.server.receiver.jvm.provider.handler.JVMSourceDispatcher - 51 [grpc-default-executor-85] WARN  [] - Can't find service by service instance id from cache, service instance id is: 1149
2019-08-16 14:32:41,035 - org.apache.skywalking.oap.server.core.register.service.ServiceInstanceInventoryRegister - 108 [grpc-default-executor-114] WARN  [] - Service instance 295 heartbeat, but not found in storage.
2019-08-16 14:32:41,036 - org.apache.skywalking.oap.server.receiver.register.provider.handler.v6.grpc.ServiceInstancePingServiceHandler - 68 [grpc-default-executor-114] WARN  [] - Can't find service by service instance id from cache, service instance id is: 295, will send a reset command to agent side

Only one way, reboot all your agents. You have erased the metadata, only 6.3.0+ agents support hot-auto-reboot.

my skywalking oap-server log also has this error.

Does upgrade 6.3 fix this？

This is not a bug fix. This is a new feature provided in 6.3.0

how only 6.3.0+ agents support hot-auto-reboot.


replica discovery hook

Whether there is a hook in the orchestrator, it can be called when a new slave joins the cluster or the slave  is disconnected to notify the business to change

There is no such hook. I'm not sure yet how well that falls within orchestrator's responsibilities. Certainly the user can use orchestrator's API to find about new/removed replicas in a cluster; I think it makes more sense to delegate that to a user's automation.

Thank you for your reply. If you use orchestrator's api for query, a lot of requests will be wasted. If orchestrator can provide hooks, then orchestratr will only push when needed.

If you use orchestrator's api for query, a lot of requests will be wasted.

It's unfortunately pretty much the same if orchestrator does that. orchestrator keeps a state in the backend database; To identify a topology change it would have to read & compare, and will waste a lot of database traffic. What I'm afraid of is that there could potentially be dozens of similar desired events. Event for when a replica joins; for when a replica leaves; for when a replica is stopped; for when it goes into maintenance; for when it is out of maintenance; for when the promotion rule changes; for when a tag changes; etc. etc. etc.
If we implement all these in orchestrator, that's IMO a massive bloat of code. Delegating this to the user allows the user to choose rate of checks, and the specific checks they're interested in.
I'm sorry, there is some balance here between orchestrator and the user, and in this case I prefer that orchestrator gives the user the building blocks they need to accomplish their tasks.

Okay, thanks again for your reply


Don't suggest humanize on printf

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
- Coverage   94.35%   94.35%   -0.01%
==========================================
  Files          95       95
  Lines        9592     9590       -2
==========================================
- Hits         9051     9049       -2
  Misses        382      382
  Partials      159      159

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


deprecation-message-additions

Changes

I added some deprecation messages to the "Roblox Globals" Documentation for some methods that have been replaced. This is to add further context as to why they are replaced, and to further direct readers to the newer methods.

I have none, its mostly for convinience to the reader.
Checks
By submitting your pull request for review, you agree to the following:

[X] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
[X] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
[X] To the best of my knowledge, all proposed changes are accurate.

I think I made a few mistakes before sending the request.
Changes were made to:

delay()
spawn()
wait()

Documentation Link: https://create.roblox.com/docs/reference/engine/globals/RobloxGlobals


Can't get mcrcon to work on Windows

I am trying to follow a minecraft tutorial that uses blender to connect and control the game. As with issue #82 everything worked correctly up to this point, but after seeming to install mcrcon it still acts like it hasn't been installed. Here's what I get from trying it in command prompt: `C:\Users\Global>mcrcon --help
'mcrcon' is not recognized as an internal or external command,
operable program or batch file.
C:\Users\Global>pip install mcrcon
Requirement already satisfied: mcrcon in c:\users\global\appdata\local\packages\pythonsoftwarefoundation.python.3.10_qbz5n2kfra8p0\localcache\local-packages\python310\site-packages (0.7.0)`
And here's the output from blender: `Defaulting to user installation because normal site-packages is not writeable
Looking in links: c:\Users\Global\AppData\Local\Temp\tmpr1p2x4d2
Requirement already satisfied: setuptools in c:\program files\blender foundation\blender 3.0\3.0\python\lib\site-packages (57.4.0)
Requirement already satisfied: pip in c:\users\global\appdata\roaming\python\python39\site-packages (22.2.1)
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: pip in c:\users\global\appdata\roaming\python\python39\site-packages (22.2.1)
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: mcrcon in c:\users\global\appdata\roaming\python\python39\site-packages (0.7.0)
Traceback (most recent call last):
File "C:\Users\Global\Desktop\BlenderMusicSyncV2\MusicSync.blend\script.py", line 40, in
File "", line 8, in
ModuleNotFoundError: No module named 'mcrcon'
Error: Python script failed, check the message in the system console`

Hi. This mcron is not python implementation that you have been installed with pip command.
python version seems to be here: https://github.com/uncaught-exceptions/mcrcon (someone uses same name on their package which causing confusion)
But this one, not the pip version, works on windows command prompt like you have tried to use, but you have to execute commands on same folder where you have extracted the files.

Ah thank you.


Update Grafana 11.3.0 and dependencies

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.76%. Comparing base (342b39e) to head (fd1db37).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   99.76%   99.76%
=======================================
  Files         160      160
  Lines        2508     2508
  Branches      538      556   +18
=======================================
  Hits         2502     2502
  Misses          6        6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[ROS2] foxy-devel branch + foxy compatibility

Currently there's a ros2 main branch which works, as well as a dashing and eloquent branch. But there is no foxy branch and as the latest LTS distribution that people are using, we need to have foxy supported.
I suggest making a foxy branch off of ros2 and rolling back some of the ros2 changes for foxy compatibility.

I created foxy-devel branch and dropped the commits introduced by your PR #233. I have not tested it yet.

build does not succeed on Foxy for me:
--- stderr: teb_local_planner
In file included from /ros_ws/src/plugins/controllers/teb_local_planner/teb_local_planner/src/teb_local_planner_ros.cpp:39:
/ros_ws/src/plugins/controllers/teb_local_planner/teb_local_planner/include/teb_local_planner/teb_local_planner_ros.h:139:8: error: ‘bool teb_local_planner::TebLocalPlannerROS::isGoalReached(const PoseStamped&, const Twist&)’ marked ‘override’, but does not override
  139 |   bool isGoalReached(
      |        ^~~~~~~~~~~~~
make[2]: *** [CMakeFiles/teb_local_planner.dir/build.make:174: CMakeFiles/teb_local_planner.dir/src/teb_local_planner_ros.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:98: CMakeFiles/teb_local_planner.dir/all] Error 2
make: *** [Makefile:161: all] Error 2
---
Failed   <<< teb_local_planner [14.5s, exited with code 2]

build does not succeed on Foxy for me:
--- stderr: teb_local_planner
In file included from /ros_ws/src/plugins/controllers/teb_local_planner/teb_local_planner/src/teb_local_planner_ros.cpp:39:
/ros_ws/src/plugins/controllers/teb_local_planner/teb_local_planner/include/teb_local_planner/teb_local_planner_ros.h:139:8: error: ‘bool teb_local_planner::TebLocalPlannerROS::isGoalReached(const PoseStamped&, const Twist&)’ marked ‘override’, but does not override
  139 |   bool isGoalReached(
      |        ^~~~~~~~~~~~~
make[2]: *** [CMakeFiles/teb_local_planner.dir/build.make:174: CMakeFiles/teb_local_planner.dir/src/teb_local_planner_ros.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:98: CMakeFiles/teb_local_planner.dir/all] Error 2
make: *** [Makefile:161: all] Error 2
---
Failed   <<< teb_local_planner [14.5s, exited with code 2]


Out of bound (IndexError) in param_space when using boolean_limit

1) Confirm the below

[x] My Python version is 3.5 or higher
[x] I have searched through the issues Issues for a duplicate
[x] I've tested that my Keras model works as a stand-alone

2) Include the output of:
talos.__version__ : 1.0.0
3) Explain clearly what you expect to happen
Execute a Scan using boolean_limit option without crashing
4) Explain what actually happened
When using boolean_limit option,  Scan fails because of out of bounds error in  param_space when reduction is applied.
IndexError                                Traceback (most recent call last)
<ipython-input-3-64df655e1857> in <module>
     16     clear_session=True,
     17     save_weights=False,
---> 18     boolean_limit=lambda params: params["neurons"] < 500
     19 )

~/anaconda3/lib/python3.7/site-packages/talos/scan/Scan.py in __init__(self, x, y, params, model, experiment_name, x_val, y_val, val_split, random_method, seed, performance_target, fraction_limit, round_limit, time_limit, boolean_limit, reduction_method, reduction_interval, reduction_window, reduction_threshold, reduction_metric, minimize_loss, disable_progress_bar, print_params, clear_session, save_weights)
    194         # start runtime
    195         from .scan_run import scan_run
--> 196         scan_run(self)

~/anaconda3/lib/python3.7/site-packages/talos/scan/scan_run.py in scan_run(self)
     17
     18         # get the parameters
---> 19         self.round_params = self.param_object.round_parameters()
     20
     21         # break when there is no more permutations left

~/anaconda3/lib/python3.7/site-packages/talos/parameters/ParamSpace.py in round_parameters(self)
    172
    173                 # get the values based on the index
--> 174                 values = self.param_space[index]
    175                 round_parameters = self._round_parameters_todict(values)
    176

IndexError: index 5435 is out of bounds for axis 0 with size 5435

5) Provide a code-complete reference

[x] My bug report includes an input model
[x] My bug report includes a parameter dictionary
[x] My bug report includes a Scan() command
[x] My bug report question includes a link to a sample of the data

NOTE: If the data is sensitive and can't be shared, create dummy data that mimics it.
A self-contained Jupyter Notebook, Google Colab, or similar is highly preferred and will speed up helping you with your issue.
I've simplified the workflow to reproduce the error faster. Please find it on Google Colab:
Google Colab: https://colab.research.google.com/drive/1zTJUiSr3OiIfQDFp-R4AaoOxhajkjTX2?usp=sharing
I can upload the code here if it's better.

I started to look at the code and for the moment it seems that the error comes from this line :
https://github.com/autonomio/talos/blob/dbd27b46a019f6fbfb7b7f08b2eb0de3be0a41ad/talos/parameters/ParamSpace.py#L52
Instead of having self.param_index = list(range(len(self.param_index))))  it seems to me that we should have self.param_index = list(range(len(self.param_space)))))
Can you confirm if I'm right?

It seems that the above message proposes to add a trailing ) but nothing else?
Moreover, self.param_index = list(range(len(self.param_index))) is doing what we want it to do i.e. reset the parameter index. Did you see this happen often, or just once?

It seems that the above message proposes to add a trailing ) but nothing else?

No, it's not about trailing ). Actually, I made a mistake when I made a copy/paste of the code, a mistake which added more ) .  I was proposing to replace  self.param_index = list(range(len(self.param_index))) by  self.param_index = list(range(len(self. param_space))) ; i.e I propose to reinitialize param_indexusing new value of param_space , since param_space  had been modified when  boolean_limit was applied.

Moreover, self.param_index = list(range(len(self.param_index))) is doing what we want it to do i.e. reset the parameter index.

I get it; but since param_space is been modified when applying boolean_limit:
https://github.com/autonomio/talos/blob/dbd27b46a019f6fbfb7b7f08b2eb0de3be0a41ad/talos/parameters/ParamSpace.py#L46-L52
It seems that param_index should be reinitialized using the new param space to avoid out of bound error.

Did you see this happen often, or just once?

It happens almost all the time when I execute a scan. Did you have the time to check the Google Colab I shared? The error is quite easily reproducible is less than 2 min.
I've made the change I proposed locally and I can confirm there's no more issue with this modification.

Makes sense. Thanks for pointing it out clearly.
Do you want to open a PR for it?

Oh it's just a line to change; no need a PR for this. I see you update talos regularly, so I let you update it with your next commit.
Have a nice weekend !

Was this ever fixed? I just had the same issue and looking at the master branch it seems like the change @oubathAI proposed was never applied.


Getting ViewPagerAndroid error in letest virsion.

Which OS ?
Android
Version
Which versions are you using:

react-native-swiper: ^1.6.0-nightly.5
react-native: 0.61.1

Expected behaviour
react-native-swiper should run normally
Actual behaviour
Getting error of "ViewPagerAndroid has been removed from React Native. It can now be installed and imported from 'react-native-viewpager' instead of 'react-native'."

Steps to reproduce

Create new project of react native.
Add library using "npm i --save react-native-swiper@nightly"
run app using "react-native run-android."

@leecade Are you watching this issue..??

@leecade this problem is fixed! #1116


whois => /usr/bin/ld: cannot find -liconv

brew install whois
==> Installing whois from homebrew/homebrew-dupes
==> Downloading https://mirrors.kernel.org/debian/pool/main/w/whois/whois_5.2.10.tar.xz
######################################################################## 100.0%
==> make HAVE_ICONV=1 whois_LDADD+=-liconv whois
Last 15 lines from /home/tseemann/.cache/Homebrew/Logs/whois/01.make:
perl make_ip_del.pl < ip_del_list > ip_del.h
perl make_ip6_del.pl < ip6_del_list > ip6_del.h
perl make_as_del.pl < as_del_list > as_del.h
perl make_as32_del.pl < as32_del_list > as32_del.h
perl make_new_gtlds.pl < new_gtlds_list > new_gtlds.h
perl make_tld_serv.pl < tld_serv_list > tld_serv.h
perl make_servers_charset.pl < servers_charset_list > servers_charset.h
/bio/linuxbrew/bin/gcc-5 -isystem/bio/linuxbrew/include -DHAVE_ICONV  -Os -w -pipe -march=core2 -c utils.c
/bio/linuxbrew/bin/gcc-5 -isystem/bio/linuxbrew/include -DHAVE_ICONV  -Os -w -pipe -march=core2 -c simple_recode.c
/bio/linuxbrew/bin/gcc-5 -isystem/bio/linuxbrew/include -DHAVE_ICONV  -Os -w -pipe -march=core2 -c whois.c
/bio/linuxbrew/bin/gcc-5 -Os -w -pipe -march=core2 -L/bio/linuxbrew/lib -Wl,-rpath,/bio/linuxbrew/lib -o whois whois.o utils.o simple_recode.o -liconv -liconv
/usr/bin/ld: cannot find -liconv
/usr/bin/ld: cannot find -liconv
collect2: error: ld returned 1 exit status

Please provide the output of brew gist-logs whois - thanks!

Whoops, sorry I ran it but forgot to paste in. Here it is: https://gist.github.com/f8061acf98b0ed9e36d9

Ping @sjackman - looks like a Linuxbrew issue. How is iconv handled in linuxbrew?

@tseemann Try brew install homebrew/dupes/libiconv
@mistydemeo Would you be willing to add
depends_on "libiconv" unless OS.mac?

I'm in Thailand. My responses may be delayed.

It's not urgent - focus on your holiday :)
brew install homebrew/dupes/libiconv also fails on Linux due to missing gperf:
if test -n "$GNULIB_TOOL"; then \
  $GNULIB_TOOL --lib=libicrt --source-base=srclib --m4-base=srcm4 --makefile-name=Makefile.gnulib --no-libtool --local-dir=gnulib-local --no-vc-files \
    --import binary-io error gettext gettext-h mbstate memmove progname relocatable-prog safe-read sigpipe stdio stdlib strerror unistd uniwidth/width unlocked-io xalloc libiconv-misc; \
fi
/bio/linuxbrew/bin/gcc-5 -Os -w -pipe -march=core2 lib/genaliases.c -o genaliases
./genaliases > lib/aliases.gperf 3> canonical.sh 4> canonical_local.sh
rm -f genaliases
gperf lib/aliases.gperf > tmp.h
/bin/sh: gperf: command not found
make: *** [lib/aliases.h] Error 127

If i brew install gperf it still fails but later along:
In file included from ./converters.h:122:0,
                 from ./iconv.c:71:
./utf8mac.h:30:33: fatal error: libkern/OSByteOrder.h: No such file or directory
compilation terminated.
make[1]: *** [iconv.lo] Error 1
make[1]: Leaving directory `/tmp/libiconv20151108-71736-14zueuz/libiconv-1.14/lib'
make: *** [install] Error 2

I'm having the same problem with unzip (I'm on Linux).
https://gist.github.com/anonymous/f56490686e7e5c37ee0a28c9d12f9d9e
To my understanding, we don't need -libiconv on linux, as it's included in libc. Can a check be put for the OS, as @sjackman suggested?

/usr/bin/gcc-5 -o unzip -liconv -Lbzip2 unzip.o crc32.o  crypt.o envargs.o explode.o extract.o fileio.o globals.o inflate.o list.o match.o process.o ttyio.o ubz2err.o unreduce.o unshrink.o zipinfo.o unix.o -lbz2
/usr/bin/ld: cannot find -liconv
collect2: error: ld returned 1 exit status
Makefile:283: recipe for target 'unzip' failed

https://gist.github.com/anonymous/f56490686e7e5c37ee0a28c9d12f9d9e#file-01-make-L261

@fabioticconi Installing the precompiled binary bottle should work as a workaround. Try
brew untap homebrew/dupes
brew update
brew install homebrew/dupes/unzip

The original whois issue is resolved. See https://github.com/Homebrew/homebrew-dupes/blob/master/whois.rb#L21


Weather Commands

Hi, really love the mod idea, but there is on slight issue right now. Tempests weather conditions are not linked to the vanilla weathers, so when changing the weather to clear, Tempest will continue to pour rain or snow outside. I would suggest either having tempest be respect general weather commands, or at least have mod specific commands for changing tempest weather conditions. I mean, you could even just hook into the normal weather events and make a percent chance for certain tempest weathers when said weather event is triggered(assuming this isn't how this is already working). That way tempest weathers just override vanillas when called, and mods/players should be able to set/reset weather conditions when needed.

This is intentional behavior. Unlike vanilla weather, weather in Tempest is regional - in other words, it can be raining in some areas while clear in others. Thus, it doesn't make sense for /weather clear to do anything - there is no state where the weather is ever clear everywhere! The system is entirely independent from the vanilla weather system - if you would like to avoid overlaps between the two, you can disable the vanilla weather via gamerule.
That said, I do have plans to add some custom commands that act as better debugging tools when integrated with the right datapack, but there will likely not be integration with the vanilla commands simply due to it really making no sense whatsoever.


Raw data

Hi, the link to the Drive containing the raw data in the README seems to be broken:

Any chance the data is still accessible somewhere? I would like to use it for some simple retargeting from video experiments :)

To be accurate, I'm wondering if the videos and reconstructed hand trajectories shown in the paper are available - i.e. these ones:

Sorry for @giuliano-97 . Since I graduated from University and lost the access to use edu google drive. The video dataset is too large for my personal google drive to host it so that the link breaks. i will try to figure out some way to host it again. Thanks!


useAsObservableSource' cause 'Cannot update during an existing state transition' warning

@observer
class Comp extends React.Component {
  render() {
    return <div>{this.props.p.x}</div>;
  }
}

function Wrapper(props) {
  const p = useAsObservableSource(props);
  // In this case, `Comp` has to be a class component;
  // A functional `Comp` may also cause similar (not exactly identical) render warning in higher versions of `react` and `mobx`.
  return <Comp p={p} />;
}

function App() {
  const [x, setX] = React.useState(0);
  useEffect(() => {
    setX(1);
  }, []);
  return <Wrapper x={x} />;
}

Intended outcome
no error, no warning.
Actual outcome
console error:
Warning: Cannot update during an existing state transition (such as within `render`). Render methods should be a pure function of props and state.

How to reproduce the issue
https://codesandbox.io/s/minimal-mobx-react-project-ve187?file=/index.js
To click the refresh button below while warning is flushed by host.

Versions

mobx-react: 6.2.2
react: 16.8.6
mobx: 4.15.4

duplicated with #884


Feature/add document types

Description
Move document type detection from CLI here and add undefined to optional types.

Motivation and Context

Document type detection is used in both CLI and SDK, so it makes sense to move it here.
undefined in optional types solves what seems to be a bug in typescript-is.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION_GUIDE document.
[x] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Why did you decide to remove description from json schema?

Why did you decide to remove description from json schema?

i did not, that's generated :shrug: i'll investigate

the descriptions are still there, they are just in the referenced object itself, probably because it was ReferencedObject and now is ReferencedObject | undefined and the description does not apply to undefined :shrug:


CMake system prevents composition into other projects

Describe the bug
The current cmake-based build system assumes it is building a static library to be installed into your build environment (e.g. build .a files and copy to /usr/local/lib). As part of this, it sets up a number of build options (CFLAGS, etc.) that should be provided by the app including the SDK. This is particularly important for embedded builds, where every single aspect of the compile and link sequence has to be controlled by the developer.
To Reproduce
The way this manifests itself is as follows...

I want to use the SDK in my existing project, so I add it as a submodule to my git project:
git submodule add https://github.com/Azure/azure-sdk-for-c.git
I include it into my existing cmake build system similarly:
add_subdirectory(libs/azure-sdk-for-c)
Build as I normally would, expecting my compiler and linker settings to be used when building the SDK

Code Snippet
I've created a repository that shows how I "wrapped" the SDK's existing CMake system to have it build as part of the parent's cmake build. The trick here is to use what cmake calls "interface libraries".
Expected behavior
I should be able to add a submodule and then add_subdirectory and it should work without me having to create my own cmake wrapper.

Additionally, it should be much easier to figure out which files are required and which are not. Since the IoT components take a dependency on core/core, there is an implied dependency on core/core/src/az_http_*.c and core/core/src/az_aad.c -- both of which require me to include one of the network stacks hidden under ~/platform.

Just to give some context to this...the example repo is here with the code snippet demo of the "interface" dynamic here.

#652 for some progress

#653 for more progress

Fix is available, https://github.com/Azure/azure-sdk-for-c/releases/tag/1.0.0-preview.2

Reopening as this is tracking some additional work

@PProvost @danewalton did the support for including us as a submodule address this issue?  Is there any additional work needed?

@PProvost @danewalton did the support for including us as a submodule address this issue?  Is there any additional work needed?

The issue of composition is fixed but the follow up comment of “what the dependencies are for a library” is still true. I think this can be rectified by explicitly linking to the libs which are depended upon (target_link_libraries) since we’re ditching the idea of versioning

I'm happy with how it works now. Feel free to close this issue.

Closing thanks @PProvost


0.3-41 update

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Visual Studio Code restarts after closing

Type: Bug
Sometimes, after closing Visual Studio Code, it re-opens in a few seconds by itself.
I suspect this happens when an updated version is released (because I'm greeted with release note tab), but update is not a reason to auto-launch when I need to turn off my workstation.
VS Code version: Code 1.70.2 (e4503b30fc78200f846c62cf8091b76ff5547662, 2022-08-16T05:35:13.448Z)
OS version: Windows_NT x64 10.0.19044
Modes:

System Info

Item
Value

CPUs
AMD Ryzen Threadripper 2990WX 32-Core Processor (64 x 2994)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
127.88GB (108.97GB free)

Process Argv
--crash-reporter-id ebe03453-c6a3-4a56-b9a8-eaf544f1a400

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

doxdocgen
csc
1.4.0

vscode-markdownlint
Dav
0.48.1

prettier-vscode
esb
9.8.0

better-cpp-syntax
jef
1.15.19

remote-containers
ms-
0.245.2

remote-ssh
ms-
0.84.0

remote-wsl
ms-
0.66.3

cmake-tools
ms-
1.12.26

cpptools
ms-
1.12.4

cpptools-extension-pack
ms-
1.3.0

vscode-yaml
red
1.9.1

code-spell-checker
str
2.7.0

cmake
twx
0.0.17

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30557514
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
hb751961:30553087
dsvsc012:30540252
azure-dev_surveyone:30548225
i497e931:30553904
fc301958:30567733

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

There is no 1.71.2. Clicking on check for updates results in:
[Window Title]
Visual Studio Code
[Content]
There are currently no updates available.
[OK]

I know that was a triage bot, but I want to add that being on a latest version is irrelevant to this report because it concerns the update process itself.
This issue is happening for multiple years now and it will always lag 1 version behind.

Happened again on
Version: 1.72.0 (user setup)
Commit: 64bbfbf67ada9953918d72e1df2f4d8e537d340e
Date: 2022-10-04T23:20:39.912Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No

Happened again on
Version: 1.73.0 (user setup)
Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
Date: 2022-11-01T15:34:06.111Z (3 wks ago)
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No

Duplicate of #129168, I believe.

/duplicate #129168


Update .travis.yml

Remove Ruby 1.9
Add Ruby 2.4
Update JRuby to <IP_ADDRESS> which builds on react-rails' travis
Add Fast Finish to matrix (Returns status as soon as anything fails or just before allowed fails)
Attempt to cache Bundler due to comment on L36-37

(attempt to) Fixes #221
TODO:

[ ] PhantomJS currently fails to download.

Well it certainly failed fast! 😆

For maintainers:
Tests for Opal 0.8 appear to fail in the current build but this appears unrelated to the travis config.


关于代码107行

deepFM.py 第107行为：self.y_deep = tf.nn.dropout(self.y_deep, self.dropout_keep_deep[0])，本人在实验中，删除该行，效果反而变好了很多。查阅资料后，发现dropout一般的对象是deep的中间节点，而该行是针对初始节点。
楼主可以自行实验，以加验证。


Fix dead links to inchi-trust

The InChI Trust website has changed the locations of the documentation and FAQ for the InChI software APIs.
Reference Issue
No Issue
What does this implement/fix? Explain your changes.
I have updated the link for the FAQ, but unfortunately the User Guide is no longer directly linkable, but is available for download as part of a zip file of documentation from the main downloads page.

Thanks @jvansan!


Add Luckyluk-e's file

layout: slide
title: "Welcome to our second slide!"
Your text
Use the left arrow to go back!

Sounds like you know what you're doing guys.


Release 0.3.0

@JuliaRegistrator register(branch="release/v0.3")

Registration pull request created: JuliaRegistries/General/55411
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.0 -m "<description of version>" ae328f98c3af2aafbc76ce0660e37df7e57dbf97
git push origin v0.3.0


Question about sync or gn in HTC

Thanks for your work, when I use GN or syncBN in HTC , the performance is lower than htc without gn or syncbn.  so how use syncBN or gn in HTC ?  Thank you .
the syncbn or gn is used in backbone and mask head .

You can use GN or SyncBN in backbone, neck and heads.


Update ObjectCollection.cs

Fixes issue with GameObject staying in NodeList even though it is not a child anymore.
Overview
Remove GameObject from NodeList, when it is not a child of this.transform anymore
!NodeList[i].transform.IsChildOf(this.transform))
Changes

Fixes: #1868

Looks like a clean fix. @cre8ivepark should take a look also.

Retargeted to the patch4_dev branch.


Add bool support to ops.nn.one_hot and ops.nn.multi_hot for the…

… Tensorflow backend.
Other backends already supported it.
Also added unit tests for bool support for both sparse=False and sparse=True.

Codecov Report
Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 57.42%. Comparing base (5c8363b) to head (d04d240).

Files
Patch %
Lines

keras/src/backend/tensorflow/nn.py
27.77%
11 Missing and 2 partials :warning:

:exclamation:  There is a different number of reports uploaded between BASE (5c8363b) and HEAD (d04d240). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (5c8363b)
HEAD (d04d240)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19972       +/-   ##
===========================================
- Coverage   79.22%   57.42%   -21.80%
===========================================
  Files         499      499
  Lines       46782    46794       +12
  Branches     8638     8640        +2
===========================================
- Hits        37064    26873    -10191
- Misses       7971    18246    +10275
+ Partials     1747     1675       -72

Flag
Coverage Δ

keras
57.42% <27.77%> (-21.66%)
:arrow_down:

keras-jax
?

keras-numpy
57.42% <27.77%> (-0.02%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


(Fabric 1.19.2) Animations with loop type "hold_on_last_frame" don't work on blocks

Expected result:

Current result:

Procedure I'm using:

I'm willing to edit any java code I need to if a fix is unable to be implemented in the module

How do I do it manually in the code then?

There isn't a fabric plugin for 1.19.4, and even if there was the mods I'm trying to be compatible with don't support it either. I'm kinda stuck here and the geckolib docs are completely unhelpful

this place is for issues with the plugin, nothing is wrong with the plugin.


feat: Add browser summary metric file

Relevant information
Currently, the Browser summary metrics come from the summary metric service, which we want to get away from. This provides summary metrics that match the golden metrics for browser.
Checklist

[ ] I've read the guidelines and understand the acceptance criteria.
[ ] The value of the attribute marked as identifier will be unique and valid.
[ ] I've confirmed that my entity type wasn't already defined. If it is I'm providing an
explanation above.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jkansagor seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.