Envoy filter can't reslove gateway response for error "http/1.1 protocol error: headers count exceeds limit"

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
We have a server which will add > 100 http headers in http repsonse, then we get http error:
upstream connect error or disconnect/reset before headers. reset reason: protocol error

The code of http handler:
func addHundredHeaders(c echo.Context) error {
	hostname, err := os.Hostname()
	if err != nil {
		return c.String(http.StatusInternalServerError, fmt.Sprintf("os.Hostname got an error: %v\n", err))
	}
	for i := 0; i < 100; i++ {
		headerName := fmt.Sprintf("Custom-Header-%d", i)
		c.Response().Header().Set(headerName, "Hello istio!")
	}
	return c.String(http.StatusOK, fmt.Sprintf("Hello, I am %s and you're accessing addHundredHeaders route. I added a hundred headers to the response!", hostname))
}

We check the debug log in ingress gateway and found these logs.
2024-07-11T09:42:15.574928Z	debug	envoy client external/envoy/source/common/http/codec_client.cc:170	[Tags: "ConnectionId":"317"] Error dispatching received data: http/1.1 protocol error: headers count exceeds limit	thread=37
2024-07-11T09:42:15.574951Z	debug	envoy connection external/envoy/source/common/network/connection_impl.cc:146	[Tags: "ConnectionId":"317"] closing data_to_write=0 type=1	thread=37
2024-07-11T09:42:15.574954Z	debug	envoy connection external/envoy/source/common/network/connection_impl.cc:278	[Tags: "ConnectionId":"317"] closing socket: 1	thread=37
2024-07-11T09:42:15.575041Z	debug	envoy client external/envoy/source/common/http/codec_client.cc:107	[Tags: "ConnectionId":"317"] disconnect. resetting 1 pending requests	thread=37
2024-07-11T09:42:15.575060Z	debug	envoy client external/envoy/source/common/http/codec_client.cc:158	[Tags: "ConnectionId":"317"] request reset	thread=37
2024-07-11T09:42:15.575075Z	debug	envoy router external/envoy/source/common/router/router.cc:1323	[Tags: "ConnectionId":"314","StreamId":"1564276049136181518"] upstream reset: reset reason: protocol error, transport failure reason: 	thread=37
2024-07-11T09:42:15.575149Z	debug	envoy http external/envoy/source/common/http/filter_manager.cc:1035	[Tags: "ConnectionId":"314","StreamId":"1564276049136181518"] Sending local reply with details upstream_reset_before_response_started{protocol_error}	thread=37
2024-07-11T09:42:15.575207Z	debug	envoy http external/envoy/source/common/http/conn_manager_impl.cc:1863	[Tags: "ConnectionId":"314","StreamId":"1564276049136181518"] encoding headers via codec (end_stream=false):
':status', '502'
'content-length', '110'
'content-type', 'text/plain'
'date', 'Thu, 11 Jul 2024 09:42:15 GMT'
'server', 'test server'
	thread=37

We found someone report this issue before, https://github.com/istio/istio/issues/48356.
We try to add envoyfilter to resolve this issue in istio 1.20, however we found that the envoy filter can't resolve the gateway response header issue.
The envoy filter:
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: increase-max-headers-count
  namespace: istio-dev
spec:
  configPatches:
    - applyTo: CLUSTER
      match:
        context: ANY
      patch:
        operation: MERGE
        value:
          common_http_protocol_options:
            max_headers_count: 200
    - applyTo: NETWORK_FILTER
      match:
        context: ANY
        listener:
          filterChain:
            filter:
              name: "envoy.filters.network.http_connection_manager"
      patch:
        operation: MERGE
        value:
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
            common_http_protocol_options:
              max_headers_count: 200

We tested the add > 100 headers to client HTTP request and add > 100 headers to server HTTP response. We found that the envoyfilter works for add > 100 headers to client HTTP request but not for add > 100 headers to server HTTP response.
And we checked the access log in gateway and sidecar. We found response_code 200 in sidecar and response_code 502 in gateway.
{"downstream_peer_issuer":null,"upstream_local_address":"<IP_ADDRESS>:41412","route_name":null,"downstream_tls_cipher":null,"downstream_tls_version":null,"downstream_remote_address":"<IP_ADDRESS>:36442","authority":"<IP_ADDRESS>","request_id":"9b28e963-182c-4042-a5e4-fb0fbdebd9dc","x_forwarded_for":"<IP_ADDRESS>","method":"GET","connection_termination_details":null,"downstream_peer_subject":null,"upstream_transport_failure_reason":null,"response_flags":"UPE","path":"/add-hundred-headers","requested_server_name":null,"user_agent":"curl/7.81.0","response_code_details":"upstream_reset_before_response_started{protocol_error}","bytes_received":0,"upstream_cluster":"network-test-1-svc.testnamespace1-dev.svc.1000.default.kind.port.8080.app_inst.test1.app_svc.test1%3Atestnamespace1-dev","downstream_local_address":"<IP_ADDRESS>:8080","downstream_local_uri_san":null,"response_code":502,"protocol":"HTTP/1.1","downstream_peer_uri_san":null,"duration":2803,"bytes_sent":110,"upstream_service_time":null,"upstream_host":"<IP_ADDRESS>:8080","rlog_id":null,"start_time":"2024-07-11T09:42:12.771Z"}

We checked the config dump of ingress gateway, and found the envoy config has this envoy filter change but I don't know why it can't take effect in ingress gateway.
curl localhost:15000/config_dump | grep max_headers_count
       "max_headers_count": 200
       "max_headers_count": 200
       "max_headers_count": 200
       "max_headers_count": 200
             "max_headers_count": 200
             "max_headers_count": 200
             "max_headers_count": 200

Could you please help to take a look why the envoy filter can't take effect?
Version
$ istioctl version
client version: 1.21.2
control plane version: 1.20-202403.1-dev
data plane version: 1.20-202403.1-dev (2 proxies)
$ kubectl version --short
client Version: v0.0.0-master+$Format:%H$
Kustomize Version: v4.5.4
Server Version: v1.23.6-88+4b9ff38040fb4a

Additional Information
No response

@hzxuzhonghu Thanks for reply.
I have already set max header count through CLUSTER and NETWORK_FILTER. It can resolve sidecar side but the ingress gateway still return 502 error code.
The envoy filter I apply:
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: increase-max-headers-count
  namespace: istio-dev
spec:
  configPatches:
    - applyTo: CLUSTER
      match:
        context: ANY
      patch:
        operation: MERGE
        value:
          common_http_protocol_options:
            max_headers_count: 200
    - applyTo: NETWORK_FILTER
      match:
        context: ANY
        listener:
          filterChain:
            filter:
              name: "envoy.filters.network.http_connection_manager"
      patch:
        operation: MERGE
        value:
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
            common_http_protocol_options:
              max_headers_count: 200

I am not sure, may turn on trace log , and track envoy code

I change the log level to trace, but I didn't found more valuable logs.
After completed header for response header, envoy got this error: 2024-07-17T05:55:50.100214Z	debug	envoy client external/envoy/source/common/http/codec_client.cc:170[Tags: "ConnectionId":"314712"] Error dispatching received data: http/1.1 protocol error: headers count exceeds limit	thread=43
2024-07-17T05:55:50.097724Z	trace	envoy misc external/envoy/source/common/event/scaled_range_timer_manager_impl.cc:60	enableTimer called on 0x559644bed080 for 180000ms, min is 180000ms	thread=43
2024-07-17T05:55:50.097777Z	trace	envoy connection external/envoy/source/common/network/connection_impl.cc:469	[Tags: "ConnectionId":"314711"] raising connection event 2	thread=43
2024-07-17T05:55:50.097788Z	debug	envoy conn_handler external/envoy/source/extensions/listener_managers/listener_manager/active_tcp_listener.cc:159	[Tags: "ConnectionId":"314711"] new connection from <IP_ADDRESS>:36678	thread=43
2024-07-17T05:55:50.097799Z	trace	envoy misc external/envoy/source/common/network/tcp_listener_impl.cc:116	TcpListener accepted 1 new connections.	thread=43
2024-07-17T05:55:50.097806Z	trace	envoy connection external/envoy/source/common/network/connection_impl.cc:614	[Tags: "ConnectionId":"314711"] socket event: 3	thread=43
2024-07-17T05:55:50.097810Z	trace	envoy connection external/envoy/source/common/network/connection_impl.cc:737	[Tags: "ConnectionId":"314711"] write ready	thread=43
2024-07-17T05:55:50.097814Z	trace	envoy connection external/envoy/source/common/network/connection_impl.cc:654	[Tags: "ConnectionId":"314711"] read ready. dispatch_buffered_data=0	thread=43
2024-07-17T05:55:50.097843Z	trace	envoy connection external/envoy/source/common/network/raw_buffer_socket.cc:25	[Tags: "ConnectionId":"314711"] read returns: 94	thread=43
2024-07-17T05:55:50.097878Z	trace	envoy connection external/envoy/source/common/network/raw_buffer_socket.cc:39	[Tags: "ConnectionId":"314711"] read error: Resource temporarily unavailable, code: 0	thread=43
2024-07-17T05:55:50.097907Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:648	[Tags: "ConnectionId":"314711"] parsing 94 bytes	thread=43
2024-07-17T05:55:50.097913Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:590	[Tags: "ConnectionId":"314711"] message begin	thread=43
2024-07-17T05:55:50.097921Z	debug	envoy http external/envoy/source/common/http/conn_manager_impl.cc:391	[Tags: "ConnectionId":"314711"] new stream	thread=43
2024-07-17T05:55:50.097973Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:547	[Tags: "ConnectionId":"314711"] completed header: key=Host value=<IP_ADDRESS>	thread=43
2024-07-17T05:55:50.097990Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:547	[Tags: "ConnectionId":"314711"] completed header: key=User-Agent value=curl/7.81.0	thread=43
2024-07-17T05:55:50.097996Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:841	[Tags: "ConnectionId":"314711"] onHeadersCompleteImpl	thread=43
2024-07-17T05:55:50.097999Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:547	[Tags: "ConnectionId":"314711"] completed header: key=Accept value=*/*	thread=43
2024-07-17T05:55:50.098007Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:1195	[Tags: "ConnectionId":"314711"] Server: onHeadersComplete size=3	thread=43
2024-07-17T05:55:50.098022Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:945	[Tags: "ConnectionId":"314711"] message complete	thread=43
2024-07-17T05:55:50.098039Z	debug	envoy http external/envoy/source/common/http/conn_manager_impl.cc:1194	[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] request headers complete (end_stream=true):
':authority', '<IP_ADDRESS>'
':path', '/add-hundred-headers'
':method', 'GET'
'user-agent', 'curl/7.81.0'
'accept', '*/*'
	thread=43
2024-07-17T05:55:50.098053Z	debug	envoy http external/envoy/source/common/http/conn_manager_impl.cc:1177	[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] request end stream	thread=43
2024-07-17T05:55:50.098087Z	debug	envoy connection external/envoy/source/common/network/connection_impl.h:98	[Tags: "ConnectionId":"314711"] current connecting state: false	thread=43
2024-07-17T05:55:50.098162Z	trace	envoy http external/envoy/source/common/http/filter_manager.cc:572[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] decode headers called: filter=istio.metadata_exchange status=0	thread=43
2024-07-17T05:55:50.098179Z	trace	envoy http external/envoy/source/common/http/filter_manager.cc:572[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] decode headers called: filter=envoy.filters.http.grpc_stats status=0	thread=43
2024-07-17T05:55:50.098188Z	debug	envoy filter source/extensions/filters/http/alpn/alpn_filter.cc:92override with 3 ALPNs	thread=43
2024-07-17T05:55:50.098194Z	trace	envoy http external/envoy/source/common/http/filter_manager.cc:572[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] decode headers called: filter=istio.alpn status=0	thread=43
2024-07-17T05:55:50.098200Z	trace	envoy http external/envoy/source/common/http/filter_manager.cc:572[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] decode headers called: filter=envoy.filters.http.fault status=0	thread=43
2024-07-17T05:55:50.098206Z	trace	envoy http external/envoy/source/common/http/filter_manager.cc:572[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] decode headers called: filter=envoy.filters.http.cors status=0	thread=43
2024-07-17T05:55:50.098213Z	trace	envoy http external/envoy/source/common/http/filter_manager.cc:572[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] decode headers called: filter=istio.stats status=0	thread=43
2024-07-17T05:55:50.098220Z	debug	envoy router external/envoy/source/common/router/router.cc:520	[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] cluster 'outbound|8080||network-test-1-svc.testnamespace1-dev.svc.1000.default.kind' match for URL '/add-hundred-headers'	thread=43
2024-07-17T05:55:50.098306Z	debug	envoy router external/envoy/source/common/router/router.cc:732	[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] router decoding headers:
':authority', '<IP_ADDRESS>'
':path', '/add-hundred-headers'
':method', 'GET'
':scheme', 'http'
'user-agent', 'curl/7.81.0'
'accept', '*/*'
'x-forwarded-for', '<IP_ADDRESS>'
'x-forwarded-proto', 'http'
'x-envoy-internal', 'true'
'x-request-id', '1fad10e8-75e2-4dfb-8fd3-bc6d86147212'
'x-envoy-decorator-operation', 'network-test-1-svc.testnamespace1-dev.svc.1000.default.kind:8080/*'
'x-envoy-peer-metadata-id', 'router~<IP_ADDRESS>~istio-ingressgateway-7ff69994c6-kls55.istio-dev~istio-dev.svc.1000.default.kind'
'x-envoy-attempt-count', '1'
	thread=43
2024-07-17T05:55:50.098343Z	debug	envoy pool external/envoy/source/common/http/conn_pool_base.cc:78queueing stream due to no available connections (ready=0 busy=0 connecting=0)	thread=43
2024-07-17T05:55:50.098349Z	debug	envoy pool external/envoy/source/common/conn_pool/conn_pool_base.cc:291	trying to create new connection	thread=43
2024-07-17T05:55:50.098368Z	trace	envoy pool external/envoy/source/common/conn_pool/conn_pool_base.cc:292	ConnPoolImplBase 0x559644891400, ready_clients_.size(): 0, busy_clients_.size(): 0, connecting_clients_.size(): 0, connecting_stream_capacity_: 0, num_active_streams_: 0, pending_streams_.size(): 1 per upstream preconnect ratio: 1	thread=43
2024-07-17T05:55:50.098375Z	debug	envoy pool external/envoy/source/common/conn_pool/conn_pool_base.cc:145	creating a new connection (connecting=0)	thread=43
2024-07-17T05:55:50.098447Z	debug	envoy connection external/envoy/source/common/network/connection_impl.h:98	[Tags: "ConnectionId":"314712"] current connecting state: true	thread=43
2024-07-17T05:55:50.098460Z	debug	envoy client external/envoy/source/common/http/codec_client.cc:57[Tags: "ConnectionId":"314712"] connecting	thread=43
2024-07-17T05:55:50.098464Z	debug	envoy connection external/envoy/source/common/network/connection_impl.cc:1009	[Tags: "ConnectionId":"314712"] connecting to <IP_ADDRESS>:8080	thread=43
2024-07-17T05:55:50.098684Z	debug	envoy connection external/envoy/source/common/network/connection_impl.cc:1028	[Tags: "ConnectionId":"314712"] connection in progress	thread=43
2024-07-17T05:55:50.098710Z	trace	envoy pool external/envoy/source/common/conn_pool/conn_pool_base.cc:131	not creating a new connection, shouldCreateNewConnection returned false.	thread=43
2024-07-17T05:55:50.098724Z	trace	envoy http external/envoy/source/common/http/filter_manager.cc:572[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] decode headers called: filter=envoy.filters.http.upstream_codec status=4	thread=43
2024-07-17T05:55:50.098731Z	trace	envoy http external/envoy/source/common/http/filter_manager.cc:572[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] decode headers called: filter=envoy.filters.http.router status=1	thread=43
2024-07-17T05:55:50.098742Z	trace	envoy http external/envoy/source/common/http/http1/codec_impl.cc:698	[Tags: "ConnectionId":"314711"] parsed 94 bytes	thread=43
2024-07-17T05:55:50.098758Z	trace	envoy connection external/envoy/source/common/network/connection_impl.cc:614	[Tags: "ConnectionId":"314712"] socket event: 2	thread=43
2024-07-17T05:55:50.098761Z	trace	envoy connection external/envoy/source/common/network/connection_impl.cc:737	[Tags: "ConnectionId":"314712"] write ready	thread=43
2024-07-17T05:55:50.098765Z	debug	envoy connection external/envoy/source/common/network/connection_impl.cc:746	[Tags: "ConnectionId":"314712"] connected	thread=43
2024-07-17T05:55:50.098770Z	trace	envoy connection external/envoy/source/common/network/connection_impl.cc:469	[Tags: "ConnectionId":"314712"] raising connection event 2	thread=43
2024-07-17T05:55:50.098774Z	debug	envoy client external/envoy/source/common/http/codec_client.cc:88[Tags: "ConnectionId":"314712"] connected	thread=43
2024-07-17T05:55:50.098786Z	debug	envoy pool external/envoy/source/common/conn_pool/conn_pool_base.cc:328	[Tags: "ConnectionId":"314712"] attaching to next stream	thread=43
2024-07-17T05:55:50.098794Z	debug	envoy pool external/envoy/source/common/conn_pool/conn_pool_base.cc:182	[Tags: "ConnectionId":"314712"] creating stream	thread=43
2024-07-17T05:55:50.098805Z	debug	envoy router external/envoy/source/common/router/upstream_request.cc:563	[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] pool ready	thread=43
2024-07-17T05:55:50.098817Z	trace	envoy router external/envoy/source/common/router/upstream_codec_filter.cc:61	[Tags: "ConnectionId":"314711","StreamId":"11702537024555385627"] proxying headers	thread=43
2024-07-17T05:55:50.098846Z	trace	envoy filter source/extensions/filters/network/metadata_exchange/metadata_exchange.cc:157	Alpn Protocol Not Found.


Feature proposal: allow user to set specific delay on callback execution

I am trying to write some tests that needs callbacks to be called after a certain delay. Is it possible for callsArgAsync to take a parameter that specifics the exact delay time?

How about just doing setTimeout(function () { stub.yield(); }, myTimeout)?

I'm trying to do sinon.stub(component, "request").callsArgWithAsync(callbackIndex, data). Following your example, I suppose this works:
sinon.stub(component, "request", function() {
        var callback = arguments[callbackIndex];
        setTimeout(function() {
          callback(data);
        }, myTimeout);
}

Is that the best way to do it?

If you want to specify the behavior up front, then yes. You could alternatively write it like this:
sinon.stub(component, "request");
// ...
setTimeout(function () {
  component.request.callArgWith(callbackIndex, data);
}, myTimeout);

I see now that it's a bit much to read / write, but it's a very special case and I don't think it's worth adding more API to Sinon. More thoughts @cjohansen @mroderick?

I don't really see the general use of a specific abstraction for this either.

Hmm I see. Thanks for your help! @cjohansen @mantoni


fix: 修复只有一行数据时异步导出数据为空 close #2681

👀 PR includes

🐛 Bugfix

[x] Solve the issue and close #2681

📝 Description

调整异步导出 requestIdleCallback 的计算逻辑, 兼容只有一行数据的导出链路.
🖼 Screenshot

Before
After

🔗 Related issue link

close #2681
🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

Codecov Report
Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.04%. Comparing base (ecdc9c8) to head (06d358a).
Report is 309 commits behind head on next.

Files
Patch %
Lines

...core/src/utils/export/copy/pivot-data-cell-copy.ts
60.00%
2 Missing :warning:

...ckages/s2-core/src/utils/export/copy/table-copy.ts
66.66%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2682      +/-   ##
==========================================
+ Coverage   75.77%   79.04%   +3.27%
==========================================
  Files         257      274      +17
  Lines       11994    12415     +421
  Branches     2464     2544      +80
==========================================
+ Hits         9088     9813     +725
+ Misses       1398     1063     -335
- Partials     1508     1539      +31

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:tada: This PR is included in version @antv/s2-v2.0.0-next.18 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Feature request] Instance Normalization

Instance Normalization is recently widely used in style transfer and GAN, since it avoid the drawback of batch normalization which brings in-batch correlations. Tensorflow only has quantized version instance norm right now, but a full version is also easy to implement, I am interested in it.
Also I wonder if it is better to implemented in C++ using eigen or simply add some lines in nn_impls.py with the benefit of being able to use fused_batch_norm. Mxnet does the first way while Pytorch use the latter method.

You can use Batch Renormalization in Keras Contrib.

@Zardinality, does batch renormalization satisfy your needs?

Batch renormalization is not exactly what I want, but I found instance normalization in the same file. It is a pity that contrib part of keras isn't contained in tensorflow distribution.

@lllyasviel @StefanoD  The instance normalization paper says: "The key idea is to replace batch normalization layers in the generator architecture with instance normalization layers, and to keep them at test time (as opposed to freeze and simplify them out as done for batch normalization)". I believe the running_mean and running_var in the lua implementations are being used to hack the batch normalization implementation to do instance normalization. Instance normalization is just contrast normalization and the keras-contrib implementation looks right to me. Please point out specific bugs if you identify them.

I reviewed the code and finally found I was wrong. I am sorry for that. The keras implementation is good. 👍
ps: maybe use default axis = -1 is better? Many keras users prefer directly writing "x = InstanceNormalization()(x);" when the last layer is a channel-last conv2d. In this case, it will take them many time to finally found out that they should add "axis=3".
I know that the default axis=None is prepared for dense layer. But the original keras prefers the -1 implementation, right?

I have a tensorflow model that I would like to add Instance Normalization. Is there a way to use Keras Contrib in tensorflow?
Thank you

Are the implementations of Instance Normalization and Layer Normalization identical or similar?

@lllyasviel interestingly enough, axis=None seems to provide better result of axis=-1 (on cycleGAN). I know this is any vague, but I thought it was worth it to put it out there.

tf 2.0  replace the  api of Instance Normalization ?

So is Instance Normalization present in TF2.0 ?


Add an option to verify the signature on decode

Looks like a good idea. I wonder if it would be a good idea for the 'allowed algorithm' to be an array? In many cases, I would expect multiple algorithms to be acceptable rather than requiring a single exact match.

@javawizard Thanks for the PR. I will check and merge it tonight.
@danleyden IMO checking only one algo is the better solution. Checking against different algorithms is a feature that depends on each individual project. We should simply focus on the stability of the lib and keep things simple. It may be a feature for version 2.x to handle multiple allowed algos that the ruby-jwt will check against.

Hello, when it will be pushed to Rubygems? We need to specify the algorithm to avoid vulnerabilities.


Error when try delete image in vCenter. Using nfs not delete the image on disk.

Description
When you execute the command:
oneimage delete 'name_of_image'
if you have the image inside a nfs datastore got this error:
Error removing image from datastore. Manually remove image source X to completely delete the image.
To Reproduce

Import a image to nfs datastore
Instantiate the image
Delete the VM instantiated
Delete image

Expected behavior
Delete the image from disk
Details

Affected Component: [Storage]
Hypervisor: [vCenter]
Version: [5.8.*, master]

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

PR #3464


Tess and Galaxyhub

In TeSS https://tess.elixir-europe.org/
we want to connect work-flows, tools, training material and events. Do we should duplicate this effort?

How do we handle events?

Do you want to keep a track of them? Where? On the Hub?
And do we want also to have feedbacks (only instructors or also trainees)?

(G4) Maybe we scrape galaxy-tagged events published on TES and present them in the galaxy events feed at galaxyproject.org/events (hub-generated)

Apparently the opposite may be easier:

trainer submits an event to the Galaxy hub, either by creating a PR or using a form (to be created) on the Galaxy Training website
TeSS aggregates the events from the Galaxy Hub.

Sounds good to me.  We need to add more 'friendly' ways for people to add content like this (A github issue or PR template was one suggested option)

TeSS is now automatically aggregating

the tutorials from here: https://tess.elixir-europe.org/content_providers/galaxy-training
the events from the Hub: https://tess.elixir-europe.org/content_providers/galaxy-project

I will close this issue then


Webpack v2 Example

Is it possible to use this with webpack v2? If so, would it be possible to add an example using the new loader syntax (with object based config, instead of query params)?
Thanks!

You can use combine-loaders (https://github.com/jsdf/webpack-combine-loaders) to stringify your loader configuration, and that will mostly get you there; e.g.
{
   test: \/.scss$\/,
   use: multi-loader(combineLoaders({ ... }), ... )
}

But I'm also wondering how to ExtractTextPlugin working with multi-loader. Notably, the example here no longer seems to work in webpack 2/3; there is no extracted file after compilation. Anyone have any ideas here?

Thanks a lot for discussing this topic here, saved my day! I'd love to see support for webpack 3 and 4 tho too!

Webpack 2 is realllly old now, and it looks like there's a solution found. The next major version will be webpack v4+.


Fix bulk currency regex

The prior bulk trade message regexes were requiring a period after
the league name which isn't currently happening in the game, thus
all of these types of trades were being dropped.
Description
All bulk queries were being ignored by the trade helper, this fixes that.

Replication Steps
List any bulk currency for sale in the current release version, when you get a trade message it will not be picked up by trade helper.

Screenshots/Video

How Has This Been Tested?

[ ] ran npm run ng:lint - tried running, gave up after multiple minutes with no result
[ ] ran npm run format - see above
[X] ran npm run ng:test
[ ] added unit tests
[X] manually tested

I'm closing this PR since this issue has also been fixed in #309


[Japanese] Improve theme page and drawer translation

Fix mistake at theme page.
Also improve drawer content translation.

That's all

@tamagoez Thank you

Seems build failed

fixed https://github.com/saadeghi/daisyui/commit/f8ba9f57f78c0db51ef794693ad30fc0121f1c9e

Thank you very much


Add documentation for Creating vehicle and sensor description

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[ ] I've agreed with the maintainers that I can plan this task.

Description
Creating vehilce and sensor description is empty,  I'm going to add document it.
Purpose
Adding specific instructions for creating vehicle and sensor descriptions.
Possible approaches
The following three explanations.

Description of vehicle_description configuration.
Description of sensor_description configuration.
Description of individual_parameter, how to be used in sensor_description.

Definition of done
write document and merge it.

@kenji-miyake @mitsudome-r
May I add to the document with this direction?

@Naophis Of course, thank you!


start server: listen tcp :443: bind: permission denied

I love this speedy file server! But when I start the server, I cannot use ports 80 and 443 (because they are restricted, I believe), so I have to start as root. Is there a workaround? I have apache, the webserver, installed on my server running Arch Linux ARM, so a user http was created. But starting the server from that user still can't bind to those ports.

In Linux, port numbers below 1024 are privileged ports. The can only be bound using root or sudo privileges. There are workarounds, but they tend to be complex.
Example: https://stackoverflow.com/q/413807


Add integration tests and fix emergent problems

This formatting enforced looks a little weird. Looks good to go. Is this waiting on any python SDK release?

Unfortunately it relies on https://github.com/aperture-data/aperturedb-python/pull/451


Window image not centered

When I insert the Custom: blind-card into a Custom: vertical-stack-in-card, the curtain is automatically decentralized on the card interface. I tried to solve it by using a built-in style and putting a custom css in it, but it doesn't override it.

This is the code

- type: custom:blind-card
    entities:
      - entity: cover.tradfri_blind
        name: Tenda Studio
        buttons_position: right
        title_position: top
        blind_color: '#636160'

And i've added this piece of custom CSS.

style: |
      .sc-blind-middle {
        margin: auto;
      }

But nothing happens.

This is a bug with the vertical-stack-in-card. use custom:stack-in-card instead and it will be fine.


Issue-add axis and axis ticks

Automated Review Comments
Issues in src/components/Axis.js:

(2, 'Hardcoded string found')
(39, 'Hardcoded string found')
(41, 'Hardcoded string found')
(51, 'Hardcoded string found')
Issues in src/components/AxisTick.js:
(2, 'Hardcoded string found')
(19, 'Line exceeds 80 characters')
(24, 'Hardcoded string found')
(25, 'Hardcoded string found')
(36, 'Line exceeds 80 characters')
(40, 'Hardcoded string found')
(51, 'Line exceeds 80 characters')
(56, 'Hardcoded string found')
(57, 'Hardcoded string found')
(70, 'Hardcoded string found')
(72, 'Hardcoded string found')
(74, 'Hardcoded string found')
(77, 'Hardcoded string found')
(92, 'Hardcoded string found')
(100, 'Hardcoded string found')
(101, 'Hardcoded string found')

I got it.


write string error

hi dear i connected to the device and i get the content too but when i want to write string its give me this error
i try also to connect with Auto-Connection i click on send but it doesnt give an error but still doesnt send to device
13 | There is no connection
this is my code to send to the device
  handleSendButton = () => {
    let command = Buffer.Buffer.from([43, 0, 4, 0, 1, 1, 0]);
    command = command.toString();
    console.log(command);
    RNSerialport.writeString('/dev/bus/usb/001/007', command);
  };

Is Buffer.Buffer a typo?
And what's the result of console.log(command)?

no i convert my message to the buffer with buffer library and send it to the device as string i try also without code above like bellow
but still give me the same result
RNSerialport.writeString('/dev/bus/usb/001/007', "setTrue");
the result of the console looks like this
+♦☺☺
and give some char that the console does not recognized

I have no right device on hand to debug writeString, so I suggest you to convert string to bytes and use writeBytes first, like below:
let command = Array.from("setTrue", (x) => x.charCodeAt(0)); // ref to https://gist.github.com/lihnux/2aa4a6f5a9170974f6aa
RNSerialport.writeBytes('/dev/bus/usb/001/007', command);


[TECHDEBT][PERSISTENCE] Add: connection pooling to persistence layer db connection

Description
The current database connection is established via pgx.Connect() method which is not concurrency safe, so updated the database connection to connect via pgxpool module which establishes connection pooling. Updated configs to apply more connection configurations: max-connections, min-connections, max-connection lifetime, max-connection idle-time and health check intervals.
Issue
Fixes #NA. It was a TPDP w/o an issue
Type of change
Please mark the relevant option(s):

[X] New feature, functionality or library
[ ] Bug fix
[X] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Upgrade github.com/jackc/pgx/v4 -> github.com/jackc/pgx/v5
Modified persistence/db.go -> connectToDatabase() function to use pgxpool for connecting to db
Modified persistence_config.proto, config1.json, config2.json, config3.json and config4.json to include connection pool configurations

Testing

[X] make develop_test
[X] LocalNet w/ all of the steps outlined in the README

Required Checklist

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have tested my changes using the available tooling
[X] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@Prajjawalk Could you close #424, merge this one with main (resolving any conflicts) and reupload it for review after testing?
I believe it should be good to merge then.

@Prajjawalk Could you please:

[ ] See the failing CI issue and tend to it
[ ] Confirm that you've tested this manually with Localnet to confirm everything works. 👍 ?

@Prajjawalk Could you please:

[ ]  See the failing CI issue and tend to it
[ ]  Confirm that you've tested this manually with Localnet to confirm everything works. 👍 ?

@Prajjawalk Could you please:

[X]  See the failing CI issue and tend to it
[X]  Confirm that you've tested this manually with Localnet to confirm everything works. 👍 ?

I fixed the dates one more time and also verified that "everything on my machine". Thank you for the contribution and sorry for the delay.
Let me know if you're interested in helping out more :)


A script to run inference on videostream from a camera. And a couple of minor changes in ReadMe

A script to run segmentation on video stream from a camera.

Thanks for the contribution, again. I will start to review shortly.


Integrate AdminLTEBundle

add advanced page.description and image.description editor : https://github.com/bootstrap-wysiwyg/bootstrap3-wysiwyg/ (this one is embed in AdminLTEBundle) Don't install it on its own ! :)

Are you going to do this one?


Create a new matrix tracking staff access to systems

This will better assist in management and onboarding. Put in place an annual plan to review this access.

Matrix created. Needs AWS and SSH info.
https://docs.google.com/spreadsheets/d/1XMRxusSuxqCMxYDj_6Hw8-u2rTvx2_obMWOeZ1l_Nrk/edit?usp=sharing


[MemoryPool] Added launder where necessary

Before dereferencing (both in implementation & user side), pointers retrieved from byte storage shall be passed through std::launder.
Note that use case at ln:82 may not be required to effectively allocate storage using placement new, but become mandatory as soon as pointer (returned from reinterpret_cast) is returned to user side.

LGTM, thanks!


[fix] github-actions's url

Hello, Christian.
I changed github-actions badge 's url a bit.
I changed to show in README only when pushed to master branch.
Reference
https://github.com/vim-airline/vim-airline/pull/2092

@chrisbra
I want to merge it.
Is that Okay?

Sure

Am 01.04.2020 um 18:30 schrieb IK<EMAIL_ADDRESS>
@chrisbra
I want to merge it.
Is that Okay?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@chrisbra
Thanks!


Fish fails :(

Expected a string, but instead found a redirection
~/.phpbrew/phpbrew.fish (line 470):                 set curr_fs (stat -f %d . ^>/dev/null)  # BSD version
                                                                               ^
from sourcing file ~/.phpbrew/phpbrew.fish
	called on line 15 of file ~/.config/fish/config.fish

from sourcing file ~/.config/fish/config.fish
	called during startup

Latest master

I have the same problem.

Same problem here.

I have no idea with fish, @racklin  please save us XD

I think I have a fix here. Try changing line 470 of phpbrew.fish to
set curr_fs (stat -f %d . >/dev/null ^&1)

@c9s  OK!  New version of  Fish-shell 2.10 seen was changed redirection for stderr.

The new fish shell script seems fix this issue.


unavailable MainAxisAlignment

Steps to reproduce

Actual results

Logs

Flutter Doctor output

When filing an issue, please provide some context and some information so that it can be properly addressed.
Closing from here as there's no acionable information in this issue.
Thank you


Feature/revise sonar image comment

Rewrote the SonarImage.msg comment for clarity.
I believe it's much clearer, though it's also much more verbose.

I think that these suggested edits reveal a significant philosophical difference in how we think of this message =)
The re-written comment suggests that the message should support both 2D and 3D imaging sonars, which I disagree with. I think that the data from those instruments will need different processing approaches and thus aren't interchangeable. e.g. what are you going to do with the sonar viewer that subscribes to data that turns out to be 3D?
I think some of the confusion came in the elevation angles variable -- that wasn't meant to describe the elevation of multple fans in an array, but rather to describe the elevation of individual beams in the fan. This is necessary for some of the fancier multi-beam sonars that also include water column data.

Maybe not a philosophical difference as much as mis-remembering the agreed on scope.  I'll dial out the discussion of 2D sonars ...

Updated based on above comments...

@amarburg -- OK, done with the next pass =)

@lindzey  -- I gave it another pass...


What is EfficientNetV2s? What is it relationship with EfficientNetV2？

I suggest reading the paper, s is for 'small'


Samples tweaks

Re-enable WLT in the RayPins sample, as it's confusing to start off with WLT doing no good.
Replace deprecated MRTK ManipulationHandler use with new ObjectManipulator.
Minor cleanups (renaming objects for clarity).

/azp run


Fix CI and properly format utils.py file

Not a pretty PR, sorry.
I fixed the CI by bumping the version numbers and then the working CI complained about my changes in utils.py so that fix is in here too now.

Not a pretty PR, sorry.

PR's are squash-merged, so the commits don't matter 👍


Update words with spelling

Update words with spelling

Coverage decreased (-1.3%) to 66.612% when pulling b1efa0c78f45ff0dbf70d02a479f754c1729324e on wording-correct into 41f1acc662adf262bc56b26eb03c9737a43c361b on master.


cannot fork and install this repo

Hey Clauderic,
Just an FYI - it is not possible to fork this repo and then install your fork via npm without trouble. I have seen similar problems before.
Essentially, if it doesn't come from the npm registry, you get this:
➜  ✗ ls node_modules/react-infinite-calendar
CHANGELOG.md LICENSE      README.md    node_modules package.json styles.css

Missing all of the important stuff.
I tried adding bin/postinstall like so:
#!/bin/bash

node -e "require('fs').stat('dist', function (e, s) { process.exit(e || !s.isDirectory() ? 1 : 0) })" || npm run build

chmod 755 bin/postinstall
and adding to package.json
...
    "codecov": "cat coverage/*/lcov.info | codecov",
    "postinstall": "./bin/postinstall"
  },
...

But I think crossenv devDependency is giving some trouble there.
Any thoughts on this?

Have you tried removing the .npmignore file? Now that I think of it that might be an issue

Removing the .npmignore does bring all of the necessary files in, but not the dist/ dir. postinstall still will not be able to create the dist/ directory needed to utilize the fork. After removing .npmignore, npm install-ing from a fork looks like this:
➜  ✗ ls node_modules/react-infinite-calendar
CHANGELOG.md             bin                      karma.conf.js            src                      webpack.config.umd.js
LICENSE                  codecov.yml              node_modules             styles.css
README.md                index.html               package.json             test
babel.preprocess.sass.js index.js                 server.js                webpack.config.dev.js

There is no dist/ dir, so a build must occur via postinstall. I think this is because when npm installs a package, it doesn't install devDependencies:
➜  ✗ ls node_modules/react-infinite-calendar/node_modules
lodash

I thought I could solve this by installing crossenv in the root of my project or globally, but actually there are a ton of other devDependencies that will need to be installed, too.
I was thinking maybe a valid solution is to use a bin/ script instead of crossenv which checks to make sure crossenv command exists, and then if it does, uses it, otherwise, ignores it, but then you would need that script to be executable in a windows environment as well if you really wanted to be able to build crossplatform (which is the point of crossenv).
I try to avoid any of these sneaky "dependencies" that then get utilized in the package.json file itself (crossenv, betterscripts, etc). Having the package.json looking into ./node_modules/*/bin/ is one of the weird and confusing magics of npm that probably should be reconsidered.
I think a lot of other people have been solving this type of problem - since the prolification of babel and webpack - by committing the non-best-practice of commiting dist/ to their repository. Aka no dist/ in the gitignore.
I have a pretty solid solution to this that would fix it, but the relative paths in your .babelrc to stuff like preprocessCss makes it impossible. PR was made at https://github.com/clauderic/react-infinite-calendar/pull/50


feat: customize hazard status converter

Description
Modifications will be made to the hazard status converter to make it compatible with Tier IV tools.
Change the "diag" included in the hazard status to just the diag type.
Also convert safety faults to latent faults.
Related links
Parent Issue:

Link

How was this PR tested?
I tested with PSim.
We were able to supress the error content in FMS.
Also, diag that is not linked to MRM can be reported.

Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

memo:

FMSではSage Faultは表示されないので、すべてLatent Faultに変えている


[FEATURE] slack function argument types are any when adding step to workflow

The deno-slack versions
"deno-slack-sdk/"<EMAIL_ADDRESS>"deno-slack-api/"<EMAIL_ADDRESS>
Deno runtime version
deno 1.39.1 (release, aarch64-apple-darwin)
v8 12.0.267.8
typescript 5.3.3

OS info
ProductName:		macOS
ProductVersion:		13.3.1
ProductVersionExtra:	(a)
BuildVersion:		22E772610a
Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:58 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6020

Describe the bug
When adding a slack function step to a workflow, the types for the arguments of that function are any.
For example, for Schema.slack.functions.ReplyInThread I would have expected to see the types from https://github.com/slackapi/deno-slack-sdk/blob/5413c437e61f661e85a947eb3995c4c4870d7e57/src/schema/slack/types/custom/message_context.ts

Steps to reproduce

add step to workflow that uses a slack function
observe types

This should tell me that message_context is the wrong type but it does not
someWorkflow.addStep(
  Schema.slack.functions.ReplyInThread,
  {
    message_context: "this is an invalid message_context",
    message: 'hi',
  },
);

Expected result
Have the correct types
Actual result
Type any
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Thanks for filing. Indeed this is a known issue with the SDK. We do not have plans on addressing this at this time (it is quite a complex feature!) but we would happily accept contributions to address this feature gap.


Missing dutch translation and error handling.

Hey Tim!
I tried using the new dutch translation on your site(https://bible-api.com) but it looks like the website went down after I tried to use the translation. I've noticed that the dutch translation isn't in the table on the website aswell.
Can you add the translation and some proper error handling to avoid this issue?
Wish you the best,
Jasper

I fixed the bug that kept breaking the site. I will update the translations database on the live site when I get time.


Fix formatting in the custom derivatives notebook

Sphinx is apparently quite picky about consistent use of headers: you can't
skip a header level. We were getting warnings like "WARNING: Title level
inconsistent" in the docs build, and sub-headers weren't showing up on this
page after the first section.

The problem is that sphinx defaults to hiding headers at the "wrong" indentation. So the online docs (which I suspect is how most users read them) don't have any subheaders. This makes them harder to read and harder to link to.
e.g.,
Before:

After -- notice the new "Numerical stability" header:


Add word error rate to text statistics

We should add statistics for word error rates for intents and entity types in the statistics.json output.

Closing this, as we're considering dropping the speech-to-intent functionality.


Helper Script for LND Data Backup and Recovery

If people wanna move LND data dir for backup and replay, that should be more supported:

create ZIP (with size/hash in name)
use SCP commands
check ZIP size/hash on replay

I have tested this one with success: https://github.com/vindard/lnd-backup/blob/master/do-lndbackup.sh
Trying to make @vindard to make a PR :)

Thanks for the push @openoms 😂 ... PR in by end of this weekend

@openoms @vindard backing up anything Bitcoin related to dropbox or any 3rd party cloud provider, especially by default, is a bad idea IMO.  Just make a local backup and let users copy it to wherever they want.

The script by default only makes a local backup and archives it into a .tar file.
I've included a gpg encryption option and logic (next commit) that'll only upload to Dropbox if the archive is encrypted. I think that's a fair enough trade-off giving the user the flexibility to do off-site encrypted backups but having the default as a local snapshot.
Other planned remote-backups include an rsync to a remote server and an encrypted+push-to-Google-Cloud for folks who would also want that option. Haven't gotten the time to code those up as yet though.

My goal minimum here is to make it easier for people to backup the LND data dir in emergency cases - when the RaspiBlitz is failing etc. An easy way to get the data off the RaspiBlitz to the laptop of the user. And then have an easy way to play that data back onto a fresh RaspiBlitz.

I think it would be difficult to make regular backups to the users laptop. Having an outdated backup is possibly even worse than having only the cypher seed. I like the idea to make the script run regularly, checking a change in channel states and make an encrypted backup to an always online cloud.
On the first setup from the service menu the user should be asked for

their gpg key (or strong backup password - maybe password D?)
dropbox / google drive (or else - mega.nz?) API key with instructions on the screen about how to get it

I presume it would be the best to run as a service with systemd in the background for regular checks.

GPG key's is needless complication. 99% of users have never used them. So we need to think about the target users for this project. Is it for the gen-public or techies?  I think it the focus should be on simplicity. Don't expose the users to what is not necessary.  Having "hidden features" for the techies is fine.  Just some things to think about.  The more simple (and cheap) it is, the more users there will be.

@rootzoll the default option for the script is to setup a data-backups folder at /home/admin and to maintain an rsync-ed (pretty much same as scp) copy of the entire .lnd dir there. I chose to do the entire dir because the actual data you'd need (channel.db & wallet.db) make up over 90% of the size of the folder, and backing up the whole folder makes restoring easier as well.
I'm not sure if doing the backup "when the RPi is failing" is the best option since as @openoms said, if even 1 bit is off the entire state could be corrupted leading to loss of all in-channel funds. That's why I chose to set it up to be compatible with periodic backups (user's choosing) that can also be run after each channel state change if the user likes.
The "upload to laptop" functionality is where I've included the different remote-upload options. The most convenient for me right now is encrypted upload to Dropbox (shows up immediately on my laptop in synced folder) but there's also the option to do something scp-like if your laptop is on and network available (I haven't coded anything but the "encrypted Dropbox upload" functionality in as yet). Open to other ideas for this "upload" part as well.
@openoms a system service may not be necessary. I currently have it running as a cron job on my RPi (cron's ridiculously easy to setup, & can also be automated via another setup script). The script can be set to run as short as every few mins since the script first checks for channel state changes and then terminates if none are found. I've also included a number of flags and argument-parsing options to facilitate setting up the cron jobs in different ways.

@fluidvoice that's a good point about simplicity and the script is pretty simple from a user's perspective right now. Once the cron job is set (can be an automated process) the user wouldn't even have to know this script is running. The default option places backups right into the home directory on the RPi. This isn't ideal though if the RPi fails since what's best is to have some sort of off-Pi backup option.
Unfortunately, it's probably impossible to do remote backups without some sort of input from the user (api keys, or at the very least an IP address to a remote backup site).
If the user chooses a 3rd-party cloud service specifically the script will not continue without some form of encryption as the default (script has an override flag for this as well).
Gpg setup is actually really easy if you need to do it (keybase.io will do it in a few clicks for you, or a setup script can setup everything for you on the RPi and spit out a string of characters for you to copy and keep safe). Also, there are maybe other symmetric encryption options where we could use the lncli unlock password as the encryption password as well or something.
Given the current state of Lightning Network though (state channel backups etc. are still being worked on and the devs still say it's #reckless to run on mainnet) and the fact that we are running on a Raspberry Pi here, I think it's safe to assume potential users have at least some level of technical competence. For everyone else, those folks maybe shouldn't be running "mainnet LN" quite yet so I'm not sure how much sense it makes trying to completely optimise the script for the broadest audience of people possible as you're suggesting (<- I'm very open to pushback and constructive suggestions on my perspective on this from others).

Anyway folks, script's available at this repo if anyone wants to try it out. @rootzoll maybe you can take a preliminary pass at it and at what I've written here and let me know if it looks like the sort of thing that would make sense for this Issue. I'd be happy to make tweaks, write up some documentation and open a PR if it fits with what folks are looking for 😉

@vindard thanks for the details :)
I decided to go two ways with this. I added a small rescue and restore data script for the v1.1 release. Its goal is to for those "rescue scenarios" and making support easier when people try to move data in a failing blitz scenario. It works just like this:
To backup your lnd data to your laptop you just use:
/home/admin/config.scripts/lnd.rescue.sh backup

and follow the instructions.
To restore the backup data from your laptop back to a RaspiBlitz you use:
/home/admin/config.scripts/lnd.rescue.sh restore

and follow the instructions of the script.
But I agree that making this rescue just as there are already problems with the blitz it might be a bit late. So after v1.1 I would like the background backup script of @vindard - BTW there is a background process already of RaspiBlitz that can take care of executing it in regular periods.

OK testing the lnd.rescue script looks good so far. I will close this issue for v1.1 release - which I want to wrapp up for tomorrow.
To add the script of @vindard I opend a new issue for a future release.


fix(service/response): GetRawBody returns bytes

Correctly return a byte array instead of string.
:warning: BREAKING CHANGE:

This is a needed breaking change to fix the behavior of the method. Your plugins must be updated to correctly handle the new return value type of []byte rather than string.

Fixes https://github.com/Kong/go-pdk/issues/165.

That is a good idea - due to the time constraint right now I will create a task.


Rename externally facing components of project to be "jobs" rather than "CI builds"

This is the second step (after #14) to re-purposing and re-branding the service as a generic job runner rather than only a CI server.
After renaming internally facing names, components, and interfaces, we need to do the same for outwardly facing ones.
Some things we'll want to address::

Change /build endpoint to something like /job or /run or likely /job/run
The domain name should be changed to conjob.io

Be sure this is domain change is coordinated with other builds since there are a few projects that currently use this service for their CI builds.

Other things will likely be discovered as the work progresses.
#14 is a dependency of this issue.

Closed by:
b9a68ce8ffb7613aba143818a813e25b63801b39
678e674307c2583729552c419d16aa046e14d543
e74ef939646469060ccafae46b22482f8e9e2a21
4a452956d89d0056082ea9accea10673c0467d50
Note that the old docker-ci-prototype/simple-ci is still running but will just not receive any updates. Anything using that server should be updated to point at the new service so the old one can be shut down.


Test adding China cloud to identity tests

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/azp run net - identity - tests-weekly


How can I edit a task please? If it's not currently possible then may I add that as a feature request please.
From what I can tell the subcommands under "tasks" are: list add delete show stats clear done undo.
thanks in advance

Hi @Whyglobaleyes , at the moment rchore doesn't support Tasks edit, will add the feature soon!

According to the most recent WHO report, around 422 million individuals overall have diabetes. Individuals with diabetes are said to have a higher gamble of medical problems, for example, coronary episode, stroke, and kidney disappointment.


Can I possibly run stock Kali Sana Desktop?

I was wondering if the above was possible. My theory is that I can by not installing a desktop target and selecting only a release and any other targets that I may need. If I can't, is there another way?

sana is not supported anymore.


Encapsulation of "hidden at launch" into dart api.

Could you please encapsulate "hidden at launch" as a dart function? Pure dart code development will create a better dev experience. 加油奥里给

I haven't found a way to implement hidden at launch without modifying any native code.


Clear showNote if column or note is deleted

Clear show_note of board if the note or the column of the note is deleted. These places are marked as TODO within the server code

Do you mean shared_note?


Fix zero checksum usage

zero checksum acceptance was implemented as a symmetrical feature, but this is not the way it is specified. Each side announces independently from the peer, that it can accept packets with an incorrect zero checksum. In particular, it is completely valid to send a packet containing an INIT ACK chunk with an incorrect zero checksum, as long as the peer announced the support in the INIT chunk.

@edaniels Can you check if this works with old versions of Pion? Can a v3 of Pion (with this commit) connect to an old version of v3 (like v3.2.15) We might need to disable this by default then if not.
If this now matches the behavior in https://github.com/pion/webrtc/issues/2618

Yep! That's unfortunate :/
Thanks for taking care of that

Then we can also add to SettingEngine for people to opt-in

Never mind, this works fine. I was using my go workspace incorrectly. EnableZeroChecksum is already what causes us to emit the parameter. If that's not enabled, we will never send a parameter that cannot be recognized.


valid() should return false if any pending validations

When the remote method is called as part of invoking valid(), the result should be false if there's any validation still pending. Probably...
See also #1044

According to http://stackoverflow.com/questions/2510623/jquery-validation-plugin-valid-does-not-work-with-remote-validation/3884995#3884995, element used to return undefined while the asynchronous call is running.  Is this an option?  Ideally, the response would be asynchronous and wait for the reply.

Any solution?

The error continues... any solution?

Encounter the same error,any bypassing method?

Just wondering if there was any movement on this issue?

I got the same error, there seems to be a workaround using
 .removeData("previousValue");
http://stackoverflow.com/questions/2710548/how-to-use-jquery-to-remotely-validate-a-field-that-depends-on-another-field-in
http://stackoverflow.com/questions/1433139/with-jquery-validation-plugin-i-want-to-change-the-remote-validation-method

Hi - can we re-open this please? This is still an issue (for me)
Basically, calling either/both .valid(...) and .element(...) always returns true, regardless of the state of the input itself.
So I would suggest either removing from the documentation here: https://jqueryvalidation.org/Validator.element/
Or fixing this method so it actually does the thing documented.

@jarfer feel free to provide either a patch for the docs which mentions the exeption for the „remote“ validation or a fix for the library

As I wrote in issue #956 remote validation causes double submit, I found a solution like below can avoid this issue temporary.
theForm.on("submit", function(e) {
    if (!theForm.valid() || theForm.find("input." + this.validator.pendingClass).length) {
         // attention: I have this.validator in my code.
         return false;
    }

    // ...
}

I wonder are there any updates on this issue? Still the form.valid() returns true even though the form has a pending remote validation and submit handler running twice. The codesandbox.io demo is here (see the console window after clicked submit).


Does robotium support android 3.2 ?

From<EMAIL_ADDRESS>on August 08, 2011 20:56:37
In android 3.2 version when i use clickOnText or clickOnButton clickOnImage , these command does not do anything.
But in android 3.1 version these command can work properly.
I'm not sure why the command is not working properly??
Does has any setting less to do in android 3.2 ??
Original issue: http://code.google.com/p/robotium/issues/detail?id=138

From<EMAIL_ADDRESS>on August 08, 2011 22:34:27
Please look at the other open issues before submitting one.
Status: Duplicate

From<EMAIL_ADDRESS>on August 08, 2011 23:52:14
Hi
my problem is not duplicate with issue #127 .
It's only title name as the same with issue #127 .
thanks


Allow "name_or_alias" filtering operation on interface types.

The compiler was unnecessarily strict with checking the validity of name_or_alias targets, and ended up disallowing its use on interface types that contained the necessary fields. This PR relaxes that restriction and updates the schema and tests to reflect that.

Coverage increased (+0.1%) to 93.927% when pulling 09b62dab8077f35d7eac646c89f11d2acba8ad54 on name_or_alias_on_interface_type into 24f9c02ba9a7be562f5e4f3e1b2f123bcf38139c on master.

Tests pass. LGTM.


Implement forceful termination of launched CLI after a timeout in Java ProcessUtils.

Implement forceful termination of launched CLI after a timeout in Java ProcessUtils (connector).
If CLI doesn't respect provided timeout, (and goes zombie), Java side should kill this process.

This is where change should happen https://github.com/slipstream/SlipStreamServer/blob/master/jar-connector/src/main/java/com/sixsq/slipstream/util/ProcessUtils.java#L72
The problem here is to obtain the timeout the CLI was started with.  Might need to update the signature of some of execGetOutput*() methods to explicitly require the timeout.  If the CLI didn't return after timeout + (say) 2 sec - kill it with a system call and report back the collected std/err outputs.


Update release-notes.md

Proposed changes
Zero-fill numbers to two digits in "release date".

I don't think we have this standard around zero-filling dates. @johndmulhausen WDYT?

We don't really have the standard but it doesn't hurt anything and the sentence casing is an improvement. :) Thanks, @scjane 👍


guess uom returning bbl for pore volume when grid crs in ft

Previously rq_import was marking pore volume data from 'ENGLISH' vdb as having uom of ft3. This change corrects this to bbl, which is what Nexus seems to output.
Resolves issue #84

Codecov Report

Merging #86 (5a00254) into master (b6e2dfd) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   37.32%   37.32%   -0.01%
==========================================
  Files          49       49
  Lines       21605    21606       +1
==========================================
  Hits         8064     8064
- Misses      13541    13542       +1

Impacted Files
Coverage Δ

resqpy/property.py
37.69% <50.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e2dfd...5a00254. Read the comment docs.


Created fluentbit-configmap template

Updated deployment-app fluentbit sidecar to use configmap Added fluentbit config to values.yaml

changelog??

@ShawnTurple  No changelog in this repo. We're using commit messages and releases to track changes.


Git ssh caveats

The documentation for using Git with SSH on Azure DevOps was riddled with inconsistencies (telling people URLs changed but never what the old and new URLs are), worrying recommendations (e.g. skipping fingerprint checks), unnecessary and incomplete details (how to run some form of SSH Agent on Windows without establishing context as to the requirements) etc.
I attempted to fix most of these issues in various commits of this PR. Some information (e.g. the egregious values for  HostKeyAlgorithms and MACs that will trip people up a lot) could receive more attention by better placement, though.
If there is anything you would like me to change or fix please let me know and I'll take a look.
This should supersede #12372 as well.

@ijayma,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jborsecnik I don't want to put an undue strain on your resources but it's been now a month since this was assigned to be reviewed and is still without feedback. Additionally, the other PR I mentioned (#12372) has been assigned to the same reviewer and has not received any feedback either (5 months later).
If there is anything I can do to expedite the review process, please let me know.

@vijayma
Could you review this proposed update to your article and enter #sign-off in a comment if it's ready for merge?
Thanks!

This should fix #12323, #12009, #11507 (PubkeyAcceptedAlgorithms +ssh-rsa may not be necessary as far as I can tell), #10462.
This may also alleviate #10544 in some form because references to bash have been reduced to a bare minimum (Linux and Mac users will use whatever shell they prefer and the Windows requirements for SSH etc. have been made more clear up front).
#11064 is obsolete with this PR because we no longer explain in detail how to handle SSH agents. That is most likely beyond the scope of this documentation I think (unless you plan on explaining vendor defaults for Linux (which distributions and agents?), macOS, and various Windows solutions.

@jborsecnik , @chcomley as you were the last to edit/touch the file I propose to update in this PR, I kindly ask that you review my changes as they remain unreviewed since early October 2022 despite having been assigned to someone. As pointed out yesterday I think these changes would fix a number of open issues.
If there is anything you would like me to change please let me know. Likewise, if you believe this PR to be (partially) obsolete please let me know so I will stop investing time here.

@vijayma, @mijacobs - Can you take a look at the changes in this PR?
Thanks.

@Court72 just to let you know: it's been a while and my PR concerning the Git SSH caveats for the Azure DevOps documentation is still awaiting any sort of feedback (closing in on 6 month after I raised it). I am still willing to incorporate feedback and work on the PR. Please let me know how to proceed.

Hi @Okeanos, I've forwarded this PR internally, so you should have some eyes on it shortly. Thank you so much.

@chcomley just to let you know: it's been a while and I am still waiting for any sort of feedback for my PR here. It'd be very great if you could provide any sort of input on how I can proceed here.

@Okeanos - I've followed up with @chcomley via Teams. Thanks for your patience!

@vijayma please review, thank you!

@chcomley @Okeanos Thank you for the ping and for these edits. Let me get the right folks looking at this.
@ShannonLeavitt Can you migrate this PR to an internal PR to the private repo for review?
@Okeanos Moving your PR to our private repo (basically create a branch in our private repo and push all your commits from this PR to that branch and raising a new PR) will allow us to get the full validation and staging experience. We will keep this PR open for visibility and won't close it until we complete the review of the private PR (actually I think it will close automatically when we merge your commits there and sync them back to here)

This is migrated to private repo PR https://github.com/MicrosoftDocs/azure-devops-docs-pr/pull/5851 and it is in the review process. I will report back with an update.

@Okeanos The updated article is live. Thank you for your updates to this article.
https://learn.microsoft.com/en-us/azure/devops/repos/git/use-ssh-keys-to-authenticate?view=azure-devops

[like]  Chrystal Comley reacted to your message:

From: Steve Danielson @.>
Sent: Wednesday, June 21, 2023 3:29:44 PM
To: MicrosoftDocs/azure-devops-docs @.>
Cc: Chrystal Comley @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-devops-docs] Git ssh caveats (PR #12769)
@Okeanoshttps://github.com/Okeanos The updated article is live. Thank you for your updates to this article.
https://learn.microsoft.com/en-us/azure/devops/repos/git/use-ssh-keys-to-authenticate?view=azure-devops
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-devops-docs/pull/12769#issuecomment-1601059544, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIQXSZG2ZK5DNDWSEVSM3SDXMMHORANCNFSM6AAAAAARCUM4FY.
You are receiving this because you were mentioned.Message ID: @.***>


chore: bazel8 transition

Begins the transition to Bazel 8 as the main Bazel version, and moves current tests to a bazel7 integration test. Addresses other issues with the upgrade to Bazel 8 and GraalVM's unstable latest download URLs.

[x] Stable download URLs for Oracle GraalVM
[x] Fixes for latest version of GraalVM (23)
[x] Issue bindist mappings for GraalVM 23.0.1
[x] Add ability to specify GraalVM or Java version as latest

@fmeum wanted you to see this before I issue a release; would you mind greenlighting it on your end with a quick sanity check? the next PR should be a release to BCR for Bazel 8 support.

cc / @meteorcloudy

Looks good, thanks for working on the release!
Once it lands, I'll update GraalVM in Bazel and run some benchmarks on Turbine.

@fmeum thanks likewise for the review 😄


Issues with make up

Stepping through the README for local test setup works mostly as expected, but several issues came up with the make up command. I ended up skipping it and was still able to run the tests, so it's not critical to get it right.

It might be worth it to mention that poetry can be installed via pip install poetry
Depending on how you clone the repo, you will also need to run git submodule init and git submodule update to clone the askem-ta1-dockervm submodule. It might be good to note this in the README
make up appears to try to run the command docker compose up ... instead of docker-compose up ..., which, at least on Ubuntu, does not work
The base docker-compose.yaml file appears to reference a service inside of askem-ta1-dockervm that doesn't exist: skema-unified

Great points.
On item # 3, docker compose vs docker-compose, the former is how the newer version of docker do the command and the latter is the older version.
I believe that Ubuntu 20 by default uses the older version while Ubuntu 22 and forward will all install a version of docker that expects docker compose.
You can upgrade your local version of docker by following the instructions here, if you so desire: https://docs.docker.com/engine/install/ubuntu/#install-using-the-repository

The readme and make file have been updated and should be a smoother process now. Thanks.


Add new payment methods

For example stripe.com

Would you use stripe instead of PayPal, or additionally to it (basically presenting a choice to the user of what payment provider they want to choose)? 🤔

Would you use stripe instead of PayPal, or additionally to it (basically presenting a choice to the user of what payment provider they want to choose)? 🤔

dont know, but you can make it choosable when two options are enabled

Tbh.: Most payment methods are redundant for the donator. There is not much benefit of showing both methods and then giving the donator the additional complexity of deciding what to choose. Additionally, it will be complicated to visually describe the user what these options even mean :/

May I also ask, why you want/need another payment method in the first place? :)

Some countries like Turkish for example cant use paypal i dont know if stripe.com supports it but maybe there is any alternatives.
And also i heard that paypal like to block paypal accounts. We will see in future :)

I've seen some websites use an Amazon payment gateway as well (ie https://real-debrid.com) not sure if that's something worth looking in to?

I mean, once there is support for two payment providers, it shouldn't be too hard anymore to add more :D It's more of a problem to add one when there is only one right now :P (there is only 1 or 2 or many :D).
Right now, I've a somewhat working but more than unstable version on a feature branch, where I work on from time to tim (should push the latest changes, I keep forgetting to commit the stuff I did on a day when it's, in the best case, ... unfinished).
What is working right now:

configuring stripe as a second (or only) payment method
Making a payment with stripe.com (the available payment methods are configured at stripe.com, the UI is fully responsive to these settings
Redeeming a donation when the stripe payment succeeds

What is not done, yet (and where I need to think about):

When a payment fails or is cancelled, the donator sees the "Redeem now" page. When the button is clicked, the donation is not redeemed, as the payment is not fulfilled, however, the experience here is somewhat bad
I kind of dislike the "yet another payment provider UI framework/script inclusion". For starters: It makes the donation process a bit more complicated, and secondly: the benefit is small (embedded in the tools UI), and I like the stripe.com checkout page. It's clean and it will support stuff like G Pay and Apple Pay out-of-the-box, which the embedded UI does not right now.

What is your opinion on the last point? Would it be ok, if the donator is redirected to a payment screen built and maintained by stripe.com when it is selected as a payment method? Instead of having an embedded payment UI (like the one from PayPal right now)?


Add option to SaveSolutionCallback to save in regular intervals in terms of integration time

Closes #19.
Known problems:

Specifying a  dt > t_end sets the final time to dt. This is an upstream bug and should be fixed soon: https://github.com/SciML/DiffEqCallbacks.jl/pull/137
The callback is not called at the end of the simulation. I also think that this should be changed upstream instead of reinventing our own, slightly different PeriodicCallback: https://github.com/SciML/DiffEqCallbacks.jl/pull/138

I also fixed the condition and affect! of the SummaryCallback, which bothered me for a while now.

What now? Where did I get invalidations? I guess from the Base.show? What do I do with that information now?

I set this PR to draft to wait for https://github.com/SciML/DiffEqCallbacks.jl/pull/138.

With https://github.com/SciML/DiffEqCallbacks.jl/pull/137 and https://github.com/SciML/DiffEqCallbacks.jl/pull/138 merged, we can now save the final solution, and the simulation does not run past the final time.

I just checked using times on Roci of main (9b4875da0ad39f3934157484815c9e5bd4a4a476) vs this PR (35aa419028c97873654b1d69379c6aa9dff9d406). All times in seconds, minimum of at least three measurements:

Command
using Trixi
using OrdinaryDiffEq
Total

main
16.16
6.05
22.20

this PR
19.06
5.84
24.89

That's a ~12% increase in using times (~18% if using only Trixi.jl with its own time integrators) due to (I presume) the additional dependency on DiffEqCallbacks, which brings the following dependencies with it:

Calculus
DensityInterface
DiffEqBase
Distances
Distributions
DualNumbers
FastBroadcast
FiniteDiff
HypergeometricFunctions
LineSearches
NSolversBase
NSolve
PDMats
Parameters
PreallocationTools
QuadGQ
Rmath
Rmath_jll
StatusFuns

I do like the ability to write out in constant time intervals, but I am not sure if we want to suffer additional loading times for this feature alone. OTOH, I don't want to stymie our ability to add new and awesome features either, thus I am really torn...

Reinventing the wheel and copying the code from DiffEqCallbacks would solve this, I guess. But then we have additional code that we have to maintain.

That's a ~12% increase in using times (~18% if using only Trixi.jl with its own time integrators) due to (I presume) the additional dependency on DiffEqCallbacks, which brings the following dependencies with it

@ranocha What's your thought on this. Should we maybe make this based on Requires.jl and eventually render it a weak dependency? Since this is imho only related to postprocessing/plotting, I would argue that one additional step before running a simulation (using DiffEqCallbacks) is not too much to ask.

That's a ~12% increase in using times (~18% if using only Trixi.jl with its own time integrators) due to (I presume) the additional dependency on DiffEqCallbacks, which brings the following dependencies with it

@ranocha What's your thought on this. Should we maybe make this based on Requires.jl and eventually render it a weak dependency? Since this is imho only related to postprocessing/plotting, I would argue that one additional step before running a simulation (using DiffEqCallbacks) is not too much to ask.

The problem with DiffEqCallbacks.jl is that it pulls in DiffEqBase.jl and all its dependencies - which we wanted to avoid for latency issues since we can get away with using SciMLBase for everything else.
The problem with Requires.jl is that it doesn't allow us to specify the required version of DiffEqCallbacks.jl including the fixes of @efaulhaber.
The problem with weak dependencies is that they work only on Julia v1.9 and newer.
In the end, I fear there is just no good solution for this...

I am not sure why the invalidations fail but all other tests are passing except the (known) problematic MPI on Windows.

I am not sure why the invalidations fail but all other tests are passing except the (known) problematic MPI on Windows.

It loads more dependencies. Thus, it's reasonable that we get additional invalidations from them.

With Julia v.1.9.0-rc1 (standard setup, no ``--check-bounds=no`) and current versions of all packages, I get

ca. 5.5 seconds for using Trixi on main
ca. 5.7 seconds for using Trixi with this PR

measured via @time @eval using Trixi. This is much better than the results reported above by @sloede due to several reasons:

General improvements in Julia v1.9
Improvements in the package ecosystem switching to package extensions instead of Requires.jl. This also includes changes I made in SummationByPartsOperators.jl (and Octavian.jl).

Thus, I am fine with the additional dependencies here.

This looks already quite good! We just have two open conversations. Once they are resolved, this is ready to be merged from my point of view. Thanks!


collectives parameter should be an array

currently collectives is a "Comma seperated list of collectives".
This makes it hard to override the parameter hierarchically.
We should change it to an array, while keeping the string for backwards compatibility.

So it looks like this was done a while ago. It's in the changelog:
https://github.com/voxpupuli/puppet-mcollective/blob/master/CHANGELOG.md#2014-09-03-release-200
Is this not the case?


Naming two decks with the same name causes it to select the wrong one

If I have multiple classes with a deck named the same thing, for instance both a Warlock and a Paladin deck named "Reno". Selecting either deck from the "Deck" menu with both open the same deck.

This is because the decks are stored by name and not class-name. If you want to fix the problem, you should name your decks with different names. I do hunter-aggro as the name along with shaman-aggro. This will fix the problem until we can make a better fix in the code. Its something I can look into now actually.
:) hopefully I can fix it


How to rebuild graphql schema?

Which Category is your question related to?
API
What AWS Services are you utilizing?
AppSync
Provide additional details e.g. code snippets
OS: OS X 10.13.4
Reproduction steps:

Run amplify add api with the following options
? Please select from one of the below mentioned services GraphQL
? Provide API name: squadhealthcheck
? Choose an authorization type for the API: API key
? Do you have an annotated GraphQL schema: No
? Do you want a guided schema creation: true
? What best describes your project: One-to-many relationship (e.g., “Blogs” with “Posts” and “Comments”)
? Do you want to edit the schema now: No
Update amplify/backend/api/schema.graphql
Run amplify push

Current result
Both GraphQL queries, mutations, subscriptions, and DynamoDB tables are created for the default schema (before changes)
The files inside amplify/backend/api/build/ are not updated as well.
Expected result
Both GraphQL and DynamoDB are setup according to the updated schema from the file amplify/backend/api/schema.graphql

If you want to update the graphql schema, you can edit amplify/backend/api/schema.graphql and run amplify api push command. This should update the DynamoDB tables and graphql statements.
Please fell free to re-open the issue if you're still facing problems when updating the schema or need more clarification.

As you can see in my reproduction steps, I do it. And it doesn't work.
I inspected the code and noticed, that probably compile schema from amplify-provider-cloudformation/lib/utility-functions.js would do the trick with compliling graphQL schema.
I've also found out, compile schema method should be runned when I run amplify api configure command. So I did it, and I got an error:
? Please select from one of the below mentioned services: GraphQL
The selected resource is not managed using AWS Cloudformation. Please use the AWS AppSync Console to make updates to your API - squadhealthcheck
Error: Error updating resource
    at updateWalkthrough (/Users/oskarkaminski/.nvm/versions/node/v9.8.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-api/provider-utils/awscloudformation/service-walkthroughs/appSync-walkthrough.js:211:13)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:118:7)
There was an error updating the API resource

@yuth I can't reopen the issue...

You can try using the ‘amplify api gql-compile’ command?

@kaustavghosh06 I've tried amplify api gql-compile as well. It doesn't do anything. No output in the terminal. Also no change in the files.

The issue lays in the
amplify-category-api/provider-utils/awscloudformation/service-walkthroughs/appSync-walktrough.js
In the 208 line the conditional statement resource.provider !== providerName is true.
providerName has value awscloudformation, while resource.provider has value squadhealthcheck which is the name of my app.
Any ideas why?

@OskarKaminski  I've root caused the issue. Sending a fix for it ASAP (within the next few hours). in the meanwhile to unblock yourself you could use the CLI version 0.1.24 to compile your schema.

Thanks a lot @kaustavghosh06

@OskarKaminski  Just published the fix to NPM. Please install the latest version -> 0.1.27

Thanks @kaustavghosh06. The fix solved the issue. amplify api gql-compile compiles the schema, and print out the info to the console. I guess amplify api push will compile now as well.
Great job!

@yuth  - I guess this issue still exists! After editing amplify/backend/api/schema.graphql and running amplify api push command nothing happends and there are changes in the schema in the aws AppSync console.
amplify --version: 0.1.35

the issue still exists in amplify version 0.1.35

@mkaschke @jtaylor1989 can you confirm that amplify ls show api has provider plugin as awscloudformation?
Refer #565 for details.

@YikSanChan  - it shows the same table as the status table. About the issue: After I deleted the whole stack in aws cloudformation and start from amplify init, add API ... the push works but I don't know why.

@YikSanChan - it shows the same table as the status table.

Could you paste the output of the table (by chance if you have it)

I guess the bug might still be there

Just want to say that "amplify push" works for me today. I edited schema.graphql file and saw that the changes are reflected in AppSync Console.

I've made updates to amplify/backend/api/schema.graphql. Issuing amplify push results in 'No changes detected'. Running amplify api gql-compile resets the file to how it was before my changes. This is with amplify -v 4.13.2

@Tuuleh I had the same issue. Just make sure you're making changes in /backend/api/schema.graphql and not /#current-cloud-backend/api/schema.graphql

@WarrenMT I was modifying /backend/api/schema.graphql and don't quite recall how I resolved this in the end. I might have abandoned that environment and used a different one.

I am also experiencing this issue. I.e. having created a graphql API...

Plugin scan successful

GraphQL schema compiled successfully.

Edit your schema at D:\Josh\Documents\Projects...schema.graphql or place .graphql files in a
directory at D:\Josh\Documents\Projects...

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   amplify/backend/api/showcallDatastore/parameters.json
        modified:   amplify/backend/api/showcallDatastore/schema.graphql
        modified:   amplify/backend/api/showcallDatastore/stacks/CustomResources.json
        modified:   amplify/backend/api/showcallDatastore/transform.conf.json
        modified:   amplify/backend/auth/showcall64896de3/parameters.json
        modified:   amplify/backend/auth/showcall64896de3/showcall64896de3-cloudformation-template.yml
        modified:   amplify/backend/auth/userPoolGroups/parameters.json
        modified:   amplify/backend/auth/userPoolGroups/template.json
        modified:   amplify/backend/auth/userPoolGroups/user-pool-group-precedence.json
        modified:   amplify/backend/backend-config.json
        modified:   amplify/backend/function/showcall64896de3PostConfirmation/amplify.state
        modified:   amplify/backend/function/showcall64896de3PostConfirmation/function-parameters.json
        modified:   amplify/backend/function/showcall64896de3PostConfirmation/showcall64896de3PostConfirmation-cloudformation-template.json
        modified:   amplify/backend/function/showcall64896de3PostConfirmation/src/add-to-group.js
        modified:   amplify/backend/function/showcall64896de3PostConfirmation/src/event.json
        modified:   amplify/backend/function/showcall64896de3PostConfirmation/src/index.js
        modified:   amplify/backend/function/showcall64896de3PostConfirmation/src/package-lock.json
        modified:   amplify/backend/function/showcall64896de3PostConfirmation/src/package.json
        modified:   amplify/team-provider-info.json

no changes added to commit (use "git add" and/or "git commit -a")

but when I go to push changes, amplify says there are none!
D:\Josh\Documents\Projects...>amplify api push

Current Environment: dev

| Category | Resource name     | Operation | Provider plugin   |
| -------- | ----------------- | --------- | ----------------- |
| Api      | showcallDatastore | No Change | awscloudformation |

No changes detected

D:\Josh\Documents\Projects...>amplify status

Current Environment: dev

| Category | Resource name                    | Operation | Provider plugin   |
| -------- | -------------------------------- | --------- | ----------------- |
| Function | showcall64896de3PostConfirmation | No Change | awscloudformation |
| Auth     | showcall64896de3                 | No Change | awscloudformation |
| Auth     | userPoolGroups                   | No Change | awscloudformation |
| Api      | showcallDatastore                | No Change | awscloudformation |

I have amplify v4.18.1

Thanks @kaustavghosh06. The fix solved the issue. amplify api gql-compile compiles the schema, and print out the info to the console. I guess amplify api push will compile now as well.
Great job!

this worked perfect thank you.

amplify api gql-compile and amplify push works fine for me.


forbid unsafe_op_in_unsafe_fn everywhere

Forbid the use of unsafe operations in unsafe fns without
an explicit unsafe block.  I just heard about the feature
yesterday; it was a long time coming.
While the number of occurrences of the unsafe keyword
increases with this change, the total amount of actual
unsafe code decreases.
Signed-off-by: Dan Cross<EMAIL_ADDRESS>

Just my opinion, but I found this easier to "see" what was going on with the "split" and "hide whitespace" options in the diff viewer.

I like it. I generally prefer deny over forbid at the top level, but it's a pretty inconsequential decision most of the time.

I like it. I generally prefer deny over forbid at the top level, but it's a pretty inconsequential decision most of the time.

Thanks. I chose forbid because I don't want someone to be able to turn it off. I'm hoping it becomes the default at some point.


fix +> Category instance

@mikeizbicki,
While working through the linear algebra example, I found and fixed a bug in the (+>) Category instance that caused (a.b) $ x to not equal a $ b $ x. The problem is that the instance of Concrete assumes that the type SVector 3 Double +> SVector 2 Double describes a matrix with 3 columns and 2 rows, while the instance for Category assumes that it means 3 rows and 2 columns (the other way around!).  The linear algebra example file was using the latter convention exclusively, but it wasn't causing problems because ($) was only used with square matrices, which masked the problem.
Here's a minimal example of the problem for GHCI (adapted from the linear algebra example code):
let x = unsafeToModule [2,1,0] :: SVector 3 Double
let a = unsafeMkSMatrix 2 3 [1..6] :: SVector 2 Double +> SVector 3 Double
let b = unsafeMkSMatrix 3 2 [1..6] :: SVector 3 Double +> SVector 2 Double

Then this will give the correct answer of [30,64,98] (I verified with Numpy as a sanity check):
(a.b) $ x

While this will result in an exception:
a $ b $ x

This problem can also lead to type errors if we follow the row,column convention in the examples. a is actually the right shape to right-multiply by x, but a $ x is a type error.
After this fix, we will need to type our matrices the other way around:
let a' = unsafeMkSMatrix 2 3 [1..6] :: SVector 3 Double +> SVector 2 Double

let b' = unsafeMkSMatrix 3 2 [1..6] :: SVector 2 Double +> SVector 3 Double

And then (a'.b') $ x  and a' $ b' $ x will both give correct results.
The underlying problem is that the implementation of (.) for matrices was flipped matrix multiplication, but it should be unflipped. That is, (a . b) should denote AB, not BA. This is the only way to get consistent behavior for (.) and ($). It also makes matrix multiplication in SubHask a lot less confusing :)
This PR also fixes the example and adds a note about how to read matrix type signatures w.r.t. numbers of rows and columns.
Unfortunately I wasn't able to figure out how to write a test for this. It looks like the Template Haskell test system only works for unary type classes. If you have any pointers, I can try to add a test to the PR. I wanted to write a test like this:
law_Concrete_application_composition ::
    (subcat <: (->)
     , Category subcat
     , Eq_ c) => subcat b c -> subcat a b -> a -> Logic c
law_Concrete_application_composition f g x
    = ((f.g) $ x) == (f $ g $ x)

Thanks for catching this very important bug!  All your changes look great.
I like the additional law you propose as well.  Currently, there's no way to check these higher order laws, and this is mostly due to engineering related limitations in template haskell.  GHC 8.0 is fixing a bunch of type system issues that will make subhask nicer, but I haven't been following the template haskell improvements closely enough to know if it'll allow for these higher order laws.  Maybe.

The failed build was due to a travis misconfiguration.  I've reconfigured and it passes.


Link to Trello card (if applicable)
https://trello.com/c/kdSWNyII/9-metecho-commits-list
If this PR relates to a Trello card, don't forget to reference this PR on the card as well.
Description
The commit messages say what you did; this should explain why and/or how.

[x ] Description is in Trello card
Adds documentation to commit-list component

Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).
Text is in the "intro" section of the component.
Show me
Provide screenshots/animated gifs/videos if necessary.

 Metecho commits › list

 Metecho commits › list