Working with phantomjs and yslow as a web service

Usually we can work with phantomjs + yslow like this:
http://yslow.org/phantomjs/
phantomjs yslow.js --info basic http://www.yahoo.com

And phantomjs include web module, http://phantomjs.org/api/webserver/
But this web module  has limit of 10 concurrent requests.
I want to run phantomjs and yslow with web module. How can i run it ?
And how process more than 10 concurrent requests on Phantom ?

Thank you for submitting this ticket!
This issue tracker primarily serves as the tool to report and track bugs, defects, and development tasks.
For general question, code review request, or other related discussion, please post it to either:

the official PhantomJS users mailing-list
Stack Overflow (with phantomjs tag)

If you have not read it yet, please check also a few tips on Effective Q&A.


Questions about your project – mesh structure, person attributes, CSS style, etc.

Good morning, @l0drex !

I would like to know if your project can handle a complex family tree. For instance, can I include both my maternal and paternal relatives, such as uncles, aunts, cousins, and their spouses and descendants? Can I also trace back my ancestors up to the 16th generation, along with their siblings and in-laws?
Can I add new person attributes, for example, citizenship and ancestries?
Can I customise the cards style?
Can I unfold and keep expanding the entire genealogy?
Can I export the entire unfolded genealogy to PNG, PDF, and SVG?

Thank you for your attention!

Good morning! First of all, the page can currently only show family trees, you can't edit them. I'm currently working on that, but it might take a while. For now, I use a spreadsheet with a python script.
You can have ancestors and descendants for any person. I personally have a family tree with 300 people and 11 generations. Customization is not possible from the page itself, but you can fork the project and edit the tailwind classes. Export is only possible by printing the page, for example to pdf. There are a lot of attributes for persons in the gedcomx spec that are all supported. I havent tested custom attributes, they might work or might not.


[BUG] in last release 2.9.3  [235] could not exec ..  syntax error: unexpected '('

Information

**Apktool Version 2.9.3 -
**Operating System Android Termux -
**APK From? Playstore -
**Java Version openjdk 17-internal

[235] could not exec ..  syntax error: unexpected '('

Apktool was never officially supported on Android so I'm sorry - I'm closing this.


Reconsider use of std::sync::Mutex in managing gateway actors

This line of code might be susceptible to deadlocks. Consider applying tokio async mutexes  instead, to manage the gateway actors

As discussed in Discord, memory database also uses standard library mutex ...

Decision: move to tokio mutex in gateway, delete mutex in memory database


Manually control horizontal position of nodes?

Is your feature request related to a problem? Please describe.
I am visualizing a program trace using this nice package and want to display the exact progress over time. So, every node has a time interval. However, this package has no support for this, I can only provide a duration (endTime - startTime) for each node, and somehow the nodes are then layouted using d3-hierarchy's partition mechanism.
Describe the solution you'd like
Ideally, the possible input format would be extended like this:
 {
   "name": "<name>",
   "value": <value>,
+  "start": <value>,  // optional
+  "stop": <value>,  // optional
   "children": [
     <Object>
   ]
 }

If not both values are specified, the layout would still work as before. Some kind of error checking for out-of-parent times etc. might be appropriate.
However, I'm not sure whether this is in the scope of this project. But it would be great!
Describe alternatives you've considered
My current workaround is to transform my program trace into a hierarchy for d3-flame-graph where all "gaps" between nodes are filled up with transparent spacer nodes:
const toFlamegraphData = frame => {
    const data = {
        frame,
        get name() { return frame.name },
        value: frame.endTime + 1 - frame.startTime
    }
    data.children = []
    if (frame.children.length) {
        let time = frame.startTime
        frame.children.forEach((child, index) => {
            // insert dummy to reserve space
            data.children.push({
                value: child.startTime - time,
                children: []
            })
            // insert child
            data.children.push(toFlamegraphData(child))
            time = child.endTime + 1
        })
        // insert dummy to reserve space
        data.children.push({
            value: frame.endTime + 1 - time,
            children: []
        })
    }
    return data
}

And then I wrap all other functions (label, color, etc.) to answer null/transparent for the dummy nodes. But you can imagine the overhead in terms of inner complexity and performance.

+1
This would be super useful feature for displaying datasets that have explicit start and end times for frames. Currently it ends up displaying a left skewed flamegraph by displaying child start == parent start
@LinqLover I ended up implementing something similar to add dummy spacer nodes, but unable to figure out how to style them (to make them transparent). Mind sharing how you made them hidden?

@hrishikeshdok Yes, pretty much this was also my approach. If you still need it, you can find my full code here:
https://github.com/LinqLover/trace4d/blob/8b3fd2665a9bb38c07e78c28d96c0c84e922ae2c/packages/frontend/src/player.js#L248
Interestingly, CSS overrides were not required for me ...


PhysX 3.4 support

Adds support for PhysX 3.4 and also adds support for macOS & linux. Tested it with Windows 10, Linux mint 18.1 & macOS sierra.

Shit i just noticed some tab/space issues in the PR, @Areloch if you wanna just test it further let me know how it goes and i'll fix up the tab/space stuff before you commit it.

@Areloch as from skype, i have enabled gpu stuff in physx 3.4 now for windows & linux, so i will close this PR and re-do a clean one with the white space fixed up too.


feat: skip null elements

Hello there !
Here is my modest contribution regarding this feature request. Basically this allows more lax CSS selector rules in order to target more elements, in particular the forum current language, eg. with html[lang="nl"] .some.selector.
Here are some sources :

Regarding CSS selector rules : https://stackoverflow.com/a/6732899. Following links on this page appears to show many chars are allowed in CSS. I only disabled line returns.
Regarding skipping empty elements (by driver.js author himself) : https://github.com/kamranahmedse/driver.js/issues/25#issuecomment-373857020. Unfortunately, it appears a timeout is necessary

I would need this for a multi-lingual forum. I'd gladly take any criticism.
Best regards

Could you run npm run format to fix above error


Error on documents without any spans

Version: 0.2.9
Platform:         Linux-4.4.0-176-generic-x86_64-with-debian-9.6
Python version:   3.6.7
Pipelines:        en_core_web_md (3.0.0), en_core_web_sm (3.0.0)
If I have any document in my set that does not have any span detected (source), I get an error during the HMM model creation:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-50-8af531598451> in <module>
      7 #docs = [d for d in docs if any([v for (k,v) in d.spans.items()])]
      8 # And run the estimation
----> 9 docs = model.fit_and_aggregate(docs)

/backend/notebook/skweak/skweak/aggregation.py in fit_and_aggregate(self, docs, n_iter)
    300         labelling functions."""
    301
--> 302         self.fit(list(docs))
    303         return list(self.pipe(docs))
    304

/backend/notebook/skweak/skweak/aggregation.py in fit(self, docs, cutoff, n_iter, tol)
    353
    354         # And add the counts from majority voter
--> 355         self._add_mv_counts(docs)
    356
    357         # Finally, we postprocess the counts and get probabilities

/backend/notebook/skweak/skweak/aggregation.py in _add_mv_counts(self, docs)
    530
    531             # And aggregate the results
--> 532             agg_array = mv._aggregate(obs).values
    533
    534             # Update the start probabilities

/backend/notebook/skweak/skweak/aggregation.py in _aggregate(self, obs, coefficient)
    229             return np.bincount(ar, weights=weights, minlength=nb_obs_to_count)
    230
--> 231         label_votes = np.apply_along_axis(count_function, 1, obs.values)
    232
    233         # For token-level segmentation (with a special O label), the number of "O" predictions

<__array_function__ internals> in apply_along_axis(*args, **kwargs)

/usr/local/lib/python3.6/site-packages/numpy/lib/shape_base.py in apply_along_axis(func1d, axis, arr, *args, **kwargs)
    377     except StopIteration:
    378         raise ValueError('Cannot apply_along_axis when any iteration dimensions are 0')
--> 379     res = asanyarray(func1d(inarr_view[ind0], *args, **kwargs))
    380
    381     # build a buffer for storing evaluations of func1d.

/backend/notebook/skweak/skweak/aggregation.py in count_function(x)
    227             ar = x[x>=min_val]-min_val
    228
--> 229             return np.bincount(ar, weights=weights, minlength=nb_obs_to_count)
    230
    231         label_votes = np.apply_along_axis(count_function, 1, obs.values)

<__array_function__ internals> in bincount(*args, **kwargs)

TypeError: Cannot cast array data from dtype('float64') to dtype('int64') according to the rule 'safe'

Current workaround is to filter these documents like this:
docs = [d for d in docs if any([v for (k,v) in d.spans.items()])]
Thanks for this promising library. I worked on getting Snorkel ready for spaCy NER data labeling, but this one looks directly like a realy good fit.

Thanks, I hadn't thought of testing this. It should now be fixed.


Direct support for componentsMap in doczrc?

Hi I am currently trying to extend the default theme using my own custom componentsMap. I noticed that this is only possible by creating a custom theme.  Given that the default theme is really well written and organized, is it possible to expose configuring componentsMap directly in the doczrc file?  Currently we need to write a whole theme from scratch.
Thanks and if this is possible and a reasonable request and approach, I would be willing to help dig more into implementing it!
#question

That's a pretty good idea, I think that is totally possible, I'll try to do this and release in the next version :)

This isn't possible yet since we cannot pass a function in the configuration object. I need to think about how we can change our architecture to accept methods in doczrc, but for now I isn't possible, but still keeping an awesome idea. Please, add your suggestion on our roadmap 🙏
http://feedback.docz.site


Raised styling logic; Added aspect ratio and font tweaks; Added random color and alpha options; Added data plotting at coordinates

New methods
Styling

pylexis.Diagram.set_font(size, weight): Set font size and weight.

pylexis.Diagram.set_aspect(aspect): Set aspect ratio of the grid.
  Parameters
  ----------
  aspect: str or float with aspect ratio of the grid. Use 'square' for square cells, 'auto' for equal sized steps on both axes, or a float for a custom ratio.

Plotting

pylexis.Diagram.add_data_point(year, age, value): Draw a data point in the grid.
  Parameters
  ----------
  year: int with year of the data point.
  age: int with age of the data point.
  value: string-castable value of the data point.

pylexis.Diagram.add_data(year, age, values): Add a list of data points to the Lexis Diagram.
  Parameters
  ----------
  year: list[int] with years of the data points.
  age: list[int] with age of the data points.
  values: list of string-castable values of the data points.

pylexis.Diagram.add_data_unsafe(year, age, values): Add a list of data points to the Lexis Diagram without checking if the data fits in the grid.
  Parameters
  ----------
  year: list[int] with years of the data points.
  age: list[int] with age of the data points.
  values: list of string-castable values of the data points.

pylexis.Diagram.load_data(data, xaxis, yaxis, value): Load data from a list of dictionaries.
  Parameters
  ----------
  data: list of dictionaries with the data to plot.
  xaxis: str with the key of the dictionary that contains the x-axis data.
  yaxis: str with the key of the dictionary that contains the y-axis data.
  value: str with the key of the dictionary that contains the value of the data point.

pylexis.Diagram.save(filename): Save the diagram to a file.
  Parameters
  ----------
  filename: str with the name of the file to save.

Modified Methods

Added 'random' as option for param color in pylexis.Diagram.lexis_fill
Added alpha param in method pylexis.Diagram.lexis_fill

Class Modifications

Added self.fontsize and self.fontweight to standardize font styling across plotted data

README

Updated README to include the new and updated methods
Added examples for new methods

Sounds great!

I deleted the images because they became obsolete.
The next step is make another PR with Readme.md adjustments. :smile:


kmz files is not opening and issue with the selection of area of interest.

I process and finished InSAR using Mintpy and used the kmz file to view in google earth pro. it is only showing color bar.
velocity (2).zip
but same file when i open using QGIS, i can see it but it freezes the qgis and i also can't use basemap.

Also, Is there way to give the coordinates as polygon vector of my area of interest instead of selecting an area. As it is not satellite image or also we cannot zoom in or zoom out. It is hard to select only the study area. I always end of selecting more area then necessary.

Hi @blueyeti1994,
We have heard about this issue from a number of people over the past couple of days. I have submitted a pull request to MintPy adding support to save_kmz.py for data in UTM. I will also add the option to 3_Access_HyP3_Data.ipynb to convert to WGS84 before loading into MintPy.
It may take a little while for the pull request to be merged, but a fix is in process and we will update the Jupyter Book accordingly when it is ready.
Please note that the MintPy notebooks in this repository have been deprecated, so updates will appear in the new  opensarlab_MintPy_Recipe_Book.
All the best,
Alex


Make a layer selection widget

We could make a Jupyter widget to control the background/foreground layer and transparency.

Was this solved fully in PR #64?

Yep!


async-profiler: 2.8.1 -> 2.8.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/jvm-profiling-tools/async-profiler/releases.
meta.description for async-profiler is: "A low overhead sampling profiler for Java that does not suffer from Safepoint bias problem"
meta.homepage for async-profiler is: "https://github.com/jvm-profiling-tools/async-profiler"
meta.changelog for async-profiler is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.8.3 with grep in /nix/store/k4nnc5ipzfgcddxbjnzndnmvd8cwz9hi-async-profiler-2.8.3
found 2.8.3 in filename of file in /nix/store/k4nnc5ipzfgcddxbjnzndnmvd8cwz9hi-async-profiler-2.8.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
async-profiler

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k4nnc5ipzfgcddxbjnzndnmvd8cwz9hi-async-profiler-2.8.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A async-profiler https://github.com/r-ryantm/nixpkgs/archive/695726b7aca96965f0b411e968f8d6117e50b64a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k4nnc5ipzfgcddxbjnzndnmvd8cwz9hi-async-profiler-2.8.3
ls -la /nix/store/k4nnc5ipzfgcddxbjnzndnmvd8cwz9hi-async-profiler-2.8.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

async-profiler

Maintainer pings
cc @mschuwalow for testing.

Result of nixpkgs-review pr 183256 run on x86_64-linux 1

1 package built:

async-profiler


There is a vulnerability in postgresql 42.1.4 ,upgrade recommended

https://github.com/apache/dolphinscheduler/blob/ac15f45b0b51b115ebd02aa3dd739d53c99523b5/pom.xml#L92
CVE-2020-13692  CVE-2018-10936
Recommended upgrade version：42.2.13

i will fix it

@didiaode18 It seems that this pr cannot be found in the pull request list. And you may also need to update the license file on dolphinscheduler-dist module.

@didiaode18 It seems that this pr cannot be found in the pull request list. And you may also need to update the license dependency file on tools.

Thanks for your code review


Searching icon stuck

VSCode Version: 1.50.1
OS Version: Windows 10

Steps to Reproduce:

Global Search
Finish Search
Searching icon never disappears

It's  not reproducible every time, but it did happen quite frequently.

Does this issue occur when all extensions are disabled?: Yes

https://github.com/microsoft/vscode/issues/109371#issuecomment-721871660 would appreciate the same details I'm asking for in that issue


Allow java libraries as deps of scalapb_proto_library.

This fixes https://github.com/bazelbuild/rules_scala/issues/315 by allowing the inclusion of java_library in the deps of scalapb_proto_library.

Can one of the admins verify this patch?

do you want to add a test which has an example with java dependency?
Mainly for future regression.
I can merge as is but for your own sake I recommend adding a small test

seems good, but +1 to a test.

ping: any chance you can add an example to the build so we have some test of this functionality? I'd love to merge this.

I don't have time to get to it at the moment unfortunately. Possibly next week.

I'm going to merge it and we can add the test later. I don't want to block people that are already cherry picking, but it would be very nice to have a test.

👍🏽
On Fri, 3 Nov 2017 at 23:13 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

Merged #322 https://github.com/bazelbuild/rules_scala/pull/322.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/322#event-1325683872, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABUIF8HKNOAtjYoni0QMZpQwkcWngb6fks5sy4H3gaJpZM4QEuCE
.


No recent visitors after 2024.5 update

Hi!
After an upgrade to 2024.5, "Recent Visitor" doesn't work. To be more specific:  "sensor.recent_visitor" sensor was "Unavailable" despite is "Enable" in the settings as you can show bellow.
Please note that I am running the last version of BB integration: 0.0.19 (with the tricks mentioned in this issue)

I just updated to 5.1, and I'm not seeing either issue, this one or #82. I didn't have to patch my langcodes version, and my recent visitor entity is working correctly.
Do you have any birdbuddy related warnings or errors in the logs?
I'm the BB app, do you see any recent visitors there - especially in the Saved view? Sometimes after a restart of HA you might have to wait until the next postcard arrives, since it will populate from new postcards. It does also try to populate from the last saved postcard in the feed as well, but that's only a best-effort attempt.

I have a look at the logs and I only have the following ones:

In BB app, I can seen recent visitors today.

That error looks promising. What's the actual log?

I click on the errror log mentionned bellow and I have the following details:
Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:580
integration: Sensor (documentation, issues)
First occurred: May 3, 2024 at 20:05:38 (3 occurrences)
Last logged: 17:26:40

Error adding entity sensor.etourmi_recent_visitor for domain sensor with platform birdbuddy
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 580, in _async_add_entities
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 892, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1358, in add_to_platform_finish
    await self.async_added_to_hass()
  File "/config/custom_components/birdbuddy/sensor.py", line 148, in async_added_to_hass
    await self._update_latest_visitor()
  File "/config/custom_components/birdbuddy/sensor.py", line 216, in _update_latest_visitor
    medias := [
              ^
TypeError: 'NoneType' object is not iterable

Yeah if the sensor platform didn't load, then it likely wouldn't have finished the rest of the sensors either. I'll take a look at that your, thanks for reporting.

You can try installing the version in the PR branch, with this service call:
service: update.install
target:
  entity_id: update.bird_buddy_update
data:
  version: pr/fix-83

Afterwards it will ask you to restart HA to finish the install. Note it will start saying that there's a newer version (v0.0.19), but that's just because this PR branch isn't released yet.
Let me know if a) your recent visitors entity starts working again, and/or b) the rest of the sensors start working again.

I tried to "update" to pr/fix-38 by using your service call under the "Developer tools" menu tab "services" and I still am in 0.0.19. I also tried to pu the code you provide in configuration.yaml or in a script ("Automation" menu then "Scripts" tab) without success.
I am not very sure this is the good way to use a service call. Could ou please tell me what is the right way to do this?

Doing it from the developer tools screen is the correct place:

After running the service, you'll go back to the Settings menu, and there will be 2 Bird Buddy notifications at the top: one telling you to restart HA, and the other telling you that there is an update available:

You need to ignore the update line, because that will undo the PR version. You'll note that in the dialog - it's trying to replace the pr/fix-83 version with v0.0.19, which is NOT what you want:

But you do have to click the Restart required repair, and actually restart HA. After it restarts, it will continue showing the available update to v0.0.19, but you must continue to ignore it. If you install that, it will remove the PR fix.

Thank you!
I think I still have an issue to run the service install :-( I can see this warning in logs :

OK, that means the HACS update entity isn't right.
When you go to Settings > Devices & Services > Entities tab, and search for "bird buddy", you should see an Update entity owned by integration HACS. That entity is the one you need to use in the service call.

Or in the Dev Tools Service screen, click the Go to UI Mode button in the bottom left, and choose the correct entity from the "Choose Entity" list. Pick the one that DOES NOT have the name of your BB and "Firmware" in the name, that is different, because that's the one to install a BB firmware update. You want the one that is just named "Bird Buddy Update":

I don't have any entities related to bird buddy and own by HACS :-(

Did you install the BB integration via HACS, or installed manually?
Do you have any update.* entities owned by HACS?
I wonder if this might be an Experimental feature of HACS 🤔  If you go to the HACS integration page and then click the "Configure" button, do you have Enable experimental features checked?

I have installed BB integration (and all other one) with HACS and I have no 'update' entities at all.
Yeeahhhh! By activating experimental featured, I have a lot of 'update' entities!!
I can follow your tutorial above!

I did it.
Good news! I now have the recent visitor working (and it seems I have some history):

I can't tell you right now if the sensors are updating without manual reload but it seems not.
I will let you now tomorrow after the night (Paris time).

If it's nighttime, and the BB is in sleep mode, then move off the sensors will update until it's online again.
If it's not in sleep mode and you're also not seeing other entities update still, then there might be another warning or error in your logs?

After the night, it seems that all sensors are updating alone :-)
Battery:

State:

Your fix is working!

Great, thank you for testing. This will be addressed in the next release.


Void / CancelFulfillment

Hello,
I have a question about the OSDM model.
How can it make the void?
On SNCF side, the void is made after the PNR issuing. After a Void, the PNR comes back to the previous status (booking confirmed with TLL) and we can made the issuing again. The Void doesn’t delete PNR information (segments, passengers..).
The Void is not an after sales operation.
Constraints:
•	Should be made the day of the issuing.
•	Only used for technical issuing.
We have seen the specification of the /cancelFulfillment (https://osdm.io/spec/processes/#CancelFulfillment), but the PNR status after a CancelFulfillment is not clear.
Is the CancelFulfillment delete the PNR?
What is the booking state after a CancelFulfillment?
To discuss,
Best regards,
Nicolas

Cancel Fulfillment does desired operation. It moves booking parts from FULFILLED to CONFIRMED. Payments and all bookings are retained. PNR (Booking.bookingCode) is not deleted.
Void, move from FULFILLED to PREBOOKED and restarting booking parts TTL so more changes can be made in the booking, is not natively supported by the OSDM API at the moment. Discuss separately.

TODO Josef - Fulfillment state model diagram misses cancellation and release


Refactor figure generation

(rebased to updated dependencies on July 25, 2024)
This PR follows up from #10 - I've included some of the discussion around this in the dropdown below:
Figure discussion

Member
@clane9 clane9 2 days ago
Leaving a note from our offline conversation. Currently two figures plus qc metrics are being generated here. We discussed decoupling this a bit more. Specifically, we discussed:
Separating the concerns of figure generation and QC metric extraction.
Uncoupling the figures so that there is one generator per figure
Assigning the responsibility of filtering the records to the generator itself. (Currently that responsibility lies outside in the calling pipeline.)
One possible abstraction we discussed was:
class Generator:
    def __init__(self, filters: dict[str, Any]):
        self.filters = filters

    def __call__(self, table: BIDSTable, out_dir: Path, overwrite: bool = False):
        """Filter table and generate figures for each matching record."""
        table = table.filter_multi(**self.filters)
        for _, record in table.iterrows():
            self.generate(record, out_dir, overwrite)

    def generate(self, record: pd.Series, out_dir: Path, overwrite: bool = False):
        """Generate figure for record."""
        raise NotImplementedError

class Pipeline:
    def __init__(self, generators: list[Generator]):
        self.generators = generators

    def run(self, table: BIDSTable, out_dir: Path, overwrite: bool = False):
        for gen in self.generators:
            gen(table, out_dir, overwrite)

For configuring pipelines, we could define the list of figure generators (and their kwargs) in a yaml config. Then at runtime, construct the list of generators and run the pipeline.
figures:
 three_view:
   filters:
     suffix: T1w
 slice_video:
   filters:
     suffix: T1w
 three_view_video:
   filters:
     suffix: bold
 carpet_plot:
   filters:
     suffix: bold
 mean_std:
   filters:
     suffix: bold

The generator lookup could be handled with a global registry, with generators registered via a decorator when the class is defined.
I'm not fully convinced this is the best abstraction, so I'm open to alternatives. In particular, the config looks quite repetitive. This is not necessarily the worst thing, since decoupling is worth some repetition. But it might be a sign we are missing a better idea.
Maybe something along the lines of letting groups of figures be associated with each set of BIDS filters, rather than a 1-1 mapping of filters to figures.
@nx10 thoughts?
Member
Author
@kaitj kaitj 2 days ago •
Hmm, another (not fully flushed out) thought if going the yaml route:
key1:
  filters:
      desc: [True, brain, False]
      suffix: [T1w, T2w, T1map]
  views: [three_view, slice_video]

key2:
  filters:
      suffix: bold
  views: [three_view_video, carpet_plot, mean_std]

The entities provided in filters are zipped and passed along together. If an entity True, it treats that entity as a wildcard (e.g), if False, exclude rows that contain an entity for that filter. Otherwise, the filter has to match exactly. If an entity isn't provided, we can also treat it similar to False (subject entity aside). So in the above case, it would generate the views for sub-_desc-*_T1w, sub-_desc-brain_T2w, and sub-_T1map.
The views will indicate the figure(s) that should be generated for those matching filters. Figure generation time aside, the end-user can always ignore those in NiftyOne itself. The primary keys (e.g. key1, key2) are kind of arbitrary and really are only there to group filters with figures to generate. I don't think that the repetitiveness is necessarily a bad thing, but also don't want it to get too unruly.
As an aside, we're going to need some good documentation so that a user can find the different views that can be generated (irrespective of the implementation method) 😅 .
And also open to other ideas of course.
Member
@nx10 nx10 2 days ago
Yeah either use groups of matrices like @kaitj suggests (would be my preference), or consider "inverting" that tree:
figures:
  t1w: [three_view, slice_video]
  bold: [three_view_video, carpet_plot, mean_std]

Member
@nx10 nx10 2 days ago
Overall I would prefer a Pandas query string or Polars SQL query (for SQL I would just let the user set SELECT * FROM df WHERE {userinput}).
It's always tempting to reimplement a small query DSL because one thinks they don't need all of that complexity, but then slowly realize that the complexity is needed.
Member
@nx10 nx10 2 days ago •
With @kaitj s matrix groups this would look like:
my_t1w_images:
  query: "( desc in (None, 'brain') ) and ( suffix in ('T1w', 'T2w', 'T1map') )"
  views: [three_view, slice_video]

my_bold_images:
  query: "suffix == 'bold'"
  views: [three_view_video, carpet_plot, mean_std]

Group name could also become a tag, then the same logic can be used to generate user defined tags (potentially without views):
really_bad_images:
  query: "whatever_qc_metric < 0"

Member
@clane9 clane9 [2 days ago]
Thanks @kaitj, @nx10 for the good suggestions. Let's go with your guys' preferred direction. I also think having a query option is a good idea. Having a simple way to do basic filters might also be a good idea, but it's less clear to me what the api for this should be. So I think let's just implement the query option for now and decide later on if there are common verbose query patterns we would like to streamline.
The suggestion for QC metric queries is also interesting. On the one hand, I can imagine a use case for generating figures conditional on some QC value. E.g. certain expensive to generate detailed figures might only be useful for bad or borderline data. On the other, it could be a bit of an anti-pattern since filtering by QC values can happen naturally within the fiftyone app. Also, it would require joining the QC metric table(s) with the b2t table prior to figure generation. (Not a big deal but something to note.) @kaitj what do you think about QC based queries?
Member
Author
@kaitj kaitj 2 days ago
Yeah, I like the query option too. I think it'll be familiar too (hopefully) for what I imagine would be the majority of users.
Regarding the QC metric queries, I think we are on a similar page. I can see a use case for it too. In fact, it is likely what we would want to do for identifying problematic images as you noted, but I also think it is probably better to leave that kind of filteirng for within the app or potentially for power(?) users (e.g. interactive plot sort of thing).

First crack at refactoring the figure creations to using a generator for creating the various figures and a "Runner" that actually calls these functions within the analysis workflows. Should be able to extend it to custom figure generation code (see test cases). At the moment it is only doing the figure generation, but I think the metric updates will also get thrown in there. Not sure about the group-level yet, but may also be able to reuse it there.
We had also chatted offline the other day about a yaml config. I ended up writing one and adding into the resources (more as a way to point a user to an example and to use as a default). From an api standpoint, we could directly add support for a nested dictionary config instead of loading a yaml file. For the CLI, I think it's easier to ingest a yaml file than potentially complex optional argument(s).
This PR strips away the QC metric functionality and I am in the process of adding that back in (will be separate PR) while respecting the config that gets passed.

Thanks @kaitj! I just merged #10. Can you rebase and then I can take a look at the changes?

Sounds good. I think once the kinks of this PR are resolved, would still want to hold off on merging until the metrics stuff is also ready.

Made one small update here to pass the entities to the generators as a dict (e.g. entities={"desc": "...", "ext": ".png"}), which should allow it to be more flexible if we need it to be in the future. Previously, it only accepted "desc" and "ext" as arguments.

I am also going to mark this as ready for review. I think the core functionality is there, just a question about the registry refactoring (see response to comment above).

Adding this as a note as it came up during discussion with @clane9 yesterday.
We may want to protect the standard bids entities as they may have meaning associated to each file. Instead, we probably want to use an "extra entity" (e.g. figure). I took a quick look through the current bids standard and extension proposals, but couldn't find anything that might guide us in a direction for this. For now, I am just using figure as the default entity (though some of these are videos 🤷♂) - open to suggestions here.
Additionally, we may want to make this entity customizable instead of static to avoid different outputs with otherwise identical entities being overwritten (e.g. currently if we were to say generate 2 carpet plots with the same entities, only 1 carpet plot would exist; this example is probably better digested with overlays). For now, I've added these into the view_kwargs with figure being protected for the image naming. Currently, the only downside I see to this is that "figure" has to be included in the view_fn without actually being used for anything. From our brief discussions, this may ultimately be another refactor to handle this differently, but I don't want to prevent this from being a blocking issue with the current implementation.
Both of these changes can be seen in 7e11522.


Feature Request: Detaching Tabs

Sometimes you need both terminals and you wont change everytime the tab so detaching the tab to another would be nice and yah retaching too i think =)

Duplicate of #581


Computed value not updated in SSR

Version
3.2.27
Reproduction link
github.com
Steps to reproduce
yarn

node index.js

What is expected?
Computed value is updated and html renders with correct message.

hello world

What is actually happening?
Computed value is not updated and an empty div is rendered.

I'm not sure if this a bug or is it me misusing computed in SSR context, but such an app architecture as in my reproduction demo seems to me completely valid and should work.
There is a computed value in a component which is based on part of app's state. No value serves as indication of the need to fetch data. Normally this should happen either during SSR or on the client if the state (or its part) was not hydrated. Async setup function allows to wait for data to be fetched which should trigger an update of state and computed value.
This acually worked in 3.2.26. New behavior was possibly introduced in commit f4f0966

this.effect.active = !isSSR

maybe this code make computed inactive in SSR env?

I'm reopening this as it is still not fixed (the same reproduction still fails). It looks like it got fixed because of the line that reads msg.value after fetching:

https://github.com/vuejs/core/commit/2f91872e7b64fb5e497529a9ed21c76c602bad2c#diff-c39f837454871308e7768f723b69481a057d8dfa7b021103f976de8b4f4e827bR36

But removing that line from the test makes it fail

BTW a workaround is to read again the computed once it has been fetched:
const App = defineComponent(() => {
  const msg = computed(() => store.state.items?.join(' '))

  // If msg value is falsy then we are either in ssr context or on the client
  // and the initial state was not modified/hydrated.
  // In both cases we need to fetch data.
  onServerPrefetch(async () => {
    await store.fetchData()
    msg.value
  })

  // simulate the read from a composable (e.g. filtering a list of results)
  msg.value

  return () => h('div', null, msg.value)
})

or with await
const App = defineComponent(async () => {
  const msg = computed(() => store.state.items?.join(' '))

  // simulate the read from a composable (e.g. filtering a list of results)
  msg.value

  // If msg value is falsy then we are either in ssr context or on the client
  // and the initial state was not modified/hydrated.
  // In both cases we need to fetch data.
  await store.fetchData()
  msg.value

  return () => h('div', null, msg.value)
})

The root cause is that computed getters are cached before rendering:
https://github.com/vuejs/core/blob/2f91872e7b64fb5e497529a9ed21c76c602bad2c/packages/server-renderer/src/render.ts#L131-L136
If we had to do this, we should access computed getters before caching it. However, this change is unjustified because computed might not be used in the template.
    for (const e of instance.scope.effects) {
      if (e.computed){
        // access computed getters before caching
        e.computed.value
        e.computed._cacheable = true
      }
    }


⚠ Bofrost.es has degraded performance

In ccca1bb, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1594 ms

Resolved: Bofrost.es performance has improved in 96f6b9f after 9 minutes.


WL-3328 rWiki pops up a warning about missing jsMaths library over an…

…d over
Previous fix for the jira got overridden so did it again.

Back to slow builds.


How to change color on selected index change of dropdown inside angular material table

Bug, feature request, or proposal:
Bug.
What is the expected behavior?
It should change the color
What is the current behavior?
It is not changing.
###Approach
In my angular material table there are two dropdowns whose OnChange method gives an output of YES/NO. Now, what i want is, if both the selected indexes are NO, then the color of the selected index will be getting changed into RED.
This is the below html code :-
<ng-container matColumnDef="Eligible To Vote?"><mat-header-cell *matHeaderCellDef mat-sort-header> Eligible To Vote? </mat-header-cell><mat-cell *matCellDef="let element" ><mat-form-field [class.app-input-no-underline]="true"><mat-select id="eligind" placeholder="Select" (ngModelChange)="EligOnChange($event)" [(value)]="element?.detail.Elig_Indc" [(ngModel)]="element?.detail.Elig_Indc" name="elig-voting"> <mat-option>Select</mat-option><mat-option value="1">Yes</mat-option><mat-option value="0">No</mat-option></mat-select> </mat-form-field> </mat-cell></ng-container><ng-container matColumnDef="Voting?" > <mat-header-cell *matHeaderCellDef mat-sort-header> Voting? </mat-header-cell> <mat-cell *matCellDef="let row; let element" [ngClass]="{'mat-cell-no': element == 0}" > <mat-form-field [class.app-input-no-underline]="true"><mat-select id="voting" placeholder="Select" (ngModelChange)="VoteOnChange($event)" [(value)]="element?.detail.Voting_Indc " [(ngModel)]="element?.detail.Voting_Indc" name="voting"><mat-option>Select</mat-option><mat-option value="1" >Yes</mat-option><mat-option value="0" >No</mat-option> </mat-select> </mat-form-field> </mat-cell></ng-container>
In both the dropdowns the ngModelChange is the listener. Below is the respective typescript:
EligOnChange($event) { if ($event !== '0') { } else { alert('a'); this.EligibilityToVote = false; if (this.IsVoting === false) { this.styleClass = 'vote-same-red mat-select-text-value'; } else { alert('sdgf'); } } }
VoteOnChange($event, element) { if ($event !== '0') { } else { alert('a'); this.IsVoting = false; if (this.EligibilityToVote === false) { this.styleClass = 'vote-same-red mat-select-text-value'; } else { alert('sdgf'); } } }
As of now, i am unsuccessful to change the color of the selected index. Please need help
Is there anything else we should know? Stack Traces, Screenshots, etc.
The look alike example link given below
The Stackblitz Code

@postmeback Sorry but I'm not sure we'll be able to help out here. You may have more luck posting on StackOverflow. I recommend trying to clean up your example as much as possible to really show what you are trying to accomplish. I tried to look at the code but it isn't clear what you are trying to do, e.g. this.styleClass doesn't exist so I'm not sure where that fits into your goal.

This is the stackoverflow link

@andrewseguin I have given the respective stackoverflow link...Can you or anyone please help me on this ?


Switch quickly between apple music and spotify

Hello everyone,
I would like to switch between apple music and spotify having an option when we right click instead of going to setting and change it. Also, it would be a good option to add the possibility to have a keyboard shortcut to switch between them or among then if in the future you add more music apps.
Great job, it is a fantastic app

Hey, thanks for suggestions, both of them will be included in the next release (sometime this week)

I just released a new version with these and several other new features 🙌


Publish packages to nuget.org

@kostapetan merge conflict

seems like package doesn't build, needs a readme

This was really quick (and dirty) workflow to publish a version of the framework, I'll re-do it


HBASE-26311 Balancer gets stuck in cohosted replica distribution

Backport

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
branch-2 passed

+1 :green_heart:
compile
3m 22s
branch-2 passed

+1 :green_heart:
checkstyle
1m 17s
branch-2 passed

+1 :green_heart:
spotbugs
2m 13s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

+1 :green_heart:
checkstyle
1m 14s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 54s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

51m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3804/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3804

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux e881f8e67876 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 9eb3706021

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
85 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3804/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 54s
branch-2 passed

+1 :green_heart:
compile
0m 59s
branch-2 passed

+1 :green_heart:
shadedjars
6m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
6m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
152m 54s
hbase-server in the patch passed.

180m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3804/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3804

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 656fef073da0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 9eb3706021

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3804/3/testReport/

Max. process+thread count
3522 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3804/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 34s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 30s
branch-2 passed

+1 :green_heart:
compile
1m 23s
branch-2 passed

+1 :green_heart:
shadedjars
8m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  6s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
8m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
222m 58s
hbase-server in the patch passed.

261m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3804/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3804

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 31511c53c182 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 9eb3706021

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3804/3/testReport/

Max. process+thread count
2396 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3804/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Fix migration conflicts caused by merging + make (merging) protocol for future

I created a new branch 'aisensus-develop' from 'develop' which I synced with the fork first. I then merged all the changes made so far with care into this branch. aisensus-develop is now bug free and our develop branch.


[$500] Android - When you click on 'account' and 'amount' simultaneously, the amount value gets cut off

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open request money
Change the tab to manual
Enter amount and tap next
Tap on account and amount simultaneously

Expected Result:
The amount should preview the amount correctly without cutoff
Actual Result:
The amount gets cut off for some time
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/3f5b8d87-10d5-469c-8de9-51f44669f65c
https://github.com/Expensify/App/assets/93399543/ee2b4afe-7ed1-4fc0-84db-0b788567ddea
Expensify/Expensify Issue URL:
Issue reported by: @jo-ui
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694233345077489
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01912000cb3861249d
Upwork Job ID:<PHONE_NUMBER>613942272
Last Price Increase: 2023-09-12

Hi, I checked the video. The problem is the width of the text including amount.
I think the width of the text is changed dynamically.
It is needed to fix the width
Thanks
Upwork freelancer

Proposal
Problem
When you click on 'account' and 'amount' simultaneously, the amount value gets cut off
Root Cause
When the user clicks on one of the items, the delay before navigation occurs to take the user to the next screen, which allows the user to be able to click on another item. Result in a lag when switching screens
causing this issue.
Changes
We can ignore all other actions when navigation is in progress, by using useFocusEffect in MenuItemWithTopDescription
   const isNavigating = React.useRef(false);

    useFocusEffect( React.useCallback(() => {
        isNavigating.current = false;

        return () => {
            isNavigating.current = true;
        }
    }, []));

    return (
        <MenuItem
            // eslint-disable-next-line react/jsx-props-no-spreading
            {...props}
            onPress={() => {
                if (isNavigating.current) {
                    return;
                }
                props.onPress();
            }}
 />

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0105f9a38c04b2f6d3

I also think that the suggestion you mentioned is great.

Couple things...

I don't have an android phone and I can't tap two things at once if testing via browserstack, looking for help from BZ here
@ArekChr are you able to reproduce?
I haven't come across any/many 'tap twice at once' issues.  I wonder if there is expected flows for any of these since the action isn't normal.   ie. if two taps equal two different actions, which one should be shows?

Going to close, we don't have expected behaviours for tapping twice at the same time.

@mallenexpensify It is not tapping twice at the same time, you just tap on the account and then tap on amount you don't have to be even quick that much see it on the video attached

Thanks for the comment @jo-ui , I was able to reproduce, the amount gets cut off for ~5 seconds when you click the amount right after clicking the user. I'll update the title and OP.

and
https://github.com/Expensify/App/assets/22508304/022cbc87-c9a0-4c11-a5b1-96336e03a683
@ArekChr can you provide any thoughts and also review the proposals above? Thx

I'm wondering if this issue is connected to another one we have. Right now, the input width is set to increase by 2 pixels when the component mounts. This causes a problem if the initial width is zero. Maybe we should leave the width undefined when it's initially zero to avoid this issue. Perhaps we should put this on hold until the related issue is sorted out.

@Julesssss asked to be assigned so.. I did :)
Thanks @ArekChr for the comment

Removed Help Wanted and made this a weekly

think that the suggestion you mentioned is great.

Can you explain why please? I'd love to know if you had a better proposal

Hey @ArekChr, could you please review this proposal?

Bumping this @ArekChr

@Julesssss I think I misunderstood, I thought you were going to be working on the PR.  I just readded Help Wanted.
@ArekChr lelt us know if you're unable to review the proposal in the next 48 hours? Thx

After merging https://github.com/Expensify/App/issues/26628 I'm not able to reproduce the amount cut-off issue.

Also unable to reproduce via BrowserStack so closing, comment if ya disagree or are still able to repro.


How to change the homepage address?

Because I use the website for another purpose, it is not index.php. I changed it to url.php, but I found the code after shortening the address:

close

SO,how can I change to "https://xxxx.xxx/url.php"

Hey,
This is fixed in version 2.3.
Thanks


V4.44.1 to 4.45

The commit to fix the buy/sell labels can be skipped, I think. It's already in the branch https://github.com/BitBoxSwiss/bitbox-wallet-app/commit/a727fdd47cd4ea40d21c12334372a358fc99f35d

The commit to fix the buy/sell labels can be skipped, I think. It's already in the branch a727fdd

Right, I rebased and now the commit is gone from this PR :+1:


Added boilerplate for interactive articles

Figured it out, the routes prop can be an array, and then it works smoothly :). Now all we need to do is set the Interactive component up with some falcor paths and the corresponding (should be very simple) falcor back-end stuff, and though that's not super high prio, as it could easily just be inserted manually into the database, a quick thing on editor tools that uploads your static html file would be awesome.

Don't merge this in as of now though, as we of course don't want it showing test if someone erroneously tried accessing /interactive :P

This is a smart way to do it. I like how you set up the routes so /interactive doesn't isn't bound by the header and footer components. As long as it's tested, I think this is ready to be merged! :)

Yep, thanks!
We just need to come to an agreement on the merging of the boilerplate with this PR though. I'll add the whole conversation below so we don't have to keep looking in the outdated dif:

emilgoldsmith 8 days ago Owner
@zanemountcastle I just realized that doing it this way we still have our initial html  coming from the serverside render, so we probably don't need that in the boilerplate you wrote.
For other reasons I was also thinking that maybe we should just integrate the boilerplate repo you wrote into this component, then we can just use React Helmet etc. to change the head like in other places, yeah? This would also allow for us to change the layout of the boilerplate here and it would automatically apply to all older interactive articles which I think is quite good if for example we wanted to change the header for some UI reason.
What do you say?

zanemountcastle 6 days ago Member
I'm a little confused with what you're suggesting. React Helmet only changes the site's metadata, not the actual navbar that displays at the top of the page.
Wouldn't just injecting the HTML mean that we still have the same standard navigation bar at the top of the page?

emilgoldsmith 6 days ago Owner
What I'm talking about is if we compiled the index.html file from https://github.com/mklasinc/im-article-boilerplate so all the files weren't distributed but all in one html file, and then injected it, it would have the  and  tags and what not. That wouldn't work out.
Yep I know React Helmet just changes the  and  tags and I believe maybe the classnames of body as well or something like that.
What I was suggesting was just implementing the boilerplate in this component, as we won't actually be serving a whole static html file, only the  tag as that's what this component here will actually replace, a  that is the direct child of the  tag. You're talking about the navbar, as of right now, with current implementation, no it won't display the nav bar, which was very much on purpose. Do you want it to? I thought we were doing a different layout thing like NY times, and then had a specific header for the interactive articles that had a different more minimalist design or something like that. And that's what I talked about in terms of the benefits of if we wanted to change the interactive header for any reason in the future as things and preferences change, it would be neat because it would automatically apply to past articles.

Right, so as Miha and Peter currently developing it, they're really only changing the index.html, styles.css, and main.js files.
Since that's all they're doing we could just manually (or using some Webpack plugin) to bring all of that into the single index.html file without the header or footer elements. That's definitely possible, even with them developing on the im-articles-boilerplate right now.
This is what you mean right?

Since that's all they're doing we could just manually (or using some Webpack plugin) to bring all of that into the single index.html file without the header or footer elements.

Yes pretty much. Since what this code right now does, is that it already has this code in the html from the beginning, and then the InteractiveArticleController goes instead of the <div id="main">, right. So for the reasons outlined above that we can change header and footer for all articles at once, and then also because we can't change the <head> tag that comes with the serverside render anyway it also makes sense.
As of right now I've also allowed in the database for uploading separate js and css files, where I thought we should also pretty easily be able to implement a bit of logic that took that code and put it into <script> and <style> tags, but I thought to begin with yeah let's just do that manually and upload a single file.
So if we agree on that would you then add the header and footer to the InteractiveArticleController component @zanemountcastle ?

Okay, this should pretty much be ready though it hasn't been tested since the rebase and the rebase was pretty comprehensive. But I'll test when I get the html file to really test it with.
@zanemountcastle if you could give it a quick once over review again that'd be great because of the rebase.
And do you think you could do something quick like maybe a Material UI spinner or something for the loading on the InteractiveArticleController where I did a TODO comment?
Cheers!


Request to update documentation  && slight issue that I want to report (nothing too severe)

Request to Update Documentation
I was actually having a lot of problem trying to run this, because I couldn't tell if putting the quotation marks mattered or not.
But I eventually got it to work, and I think it would be nice if we had a small section under "CLI Arguments" just to make this easier for people.
It would be best named something like "Example usage" and it would be nice if you just added the following to the markdown:
Command:
go run main.go -Query "from:Technothepig" -Instance "nitter.net" -Format "csv" > tweets.csv
What it does:

scape all the tweets from @Technothepig

Slight issue that I found:
So instances of nitter have this feature where they replace all reddit links to teddit.net, and all youtube links to piped.video links:

While this is a good feature, I don't really want this to appear in the posts that I'm downloading, and there doesn't seem to be any way to disable this from the CLI interface, is there any way to fix this? If you think there is a way, I would be happy to help implement it!

As far as I'm aware Nitter handles settings on requests through cookies. I wrote something to enable HLS Video in order to get video URLs, you can find that code here. If you want to write something to override those settings, that would probably be a good place to start.

Hi @mystery-z ,
apologies for the late reply.
As per your first point: this is about CLI arguments crafting, rather than parsing. To me it's an issue more about passing the value to the code, than having the code "analysed" and therefore correctly set.
Simply put: CLI arguments are in our control, not code's.
FAQ: Yeah, nice, thanks bro, but what does it cost to you to add just that line?
A: I'm worried we are talking about different things, Sir.
Coming to your second point: that is really what people mean by saying "that's a feature, not an issue". Still, I do agree that in certain situations that's a feature not requested and may actually cause issues. I'm not commenting this.
I think it may be of help to have the possibility to specify to have the "native" domains or the "proxy" ones.
To me it sounds like a low-priority feature, therefore I'm worried to have a dedicated spot to implement such a feature. If you may like to write it by yourself and open a PR, please feel free more than open to proceed. Simon already provided you with some inputs
Best,
FP


Allow forced enabling of debug assertions

ABSL_ASSERT() is always a no-op when NDEBUG is defined. This introduces
an indepdendent secondary mechanism for force-enabling these assertions
by defining ABSL_ENABLE_DEBUG_ASSERTS.
See https://crbug.com/1245687 for motivation.

Abandoning this in favor of an internal change.


Add Path dependency to example program

It didn't work for me until I added the Path import. This might be obvious to seasoned Rust programmers, but I'm just starting and I found it rather confusing.

Good work, thanks!


Distorted GUI

VSCode Version: 1.41.1
OS Version: Ubuntu 19.10

Does this issue occur when all extensions are disabled?: Yes
the VS Code Editor GUI distorts when I log in again into my laptop after putting it on sleep.

/duplicate of #69665


Metadata: Keys of the collection of the series are not unique

The collection of existing series from the /editor/{mpId}/metadata.json is of the form { { series-title, series-id}, {...} }. However, series titles are not suitable as keys, as they are not unique. Indeed, if there exist multiple series with the same title (for whatever reason) the endpoint will not deliver all of them.

Needs to be fixed in Opencst's list provider. Same issue exists in the admin interface.


Check app clip

@gre4ixin : This change leads to compile-time warnings for anyone using the library, since requestPermission(with:) itself calls the now deprecated requestAuthorizationAlways() and requestAuthorizationWhenInUse():
/<...>/SourcePackages/checkouts/AsyncLocationKit/Sources/AsyncLocationKit/AsyncLocationManager.swift:118:26: warning: 'requestAuthorizationAlways()' is deprecated: Use new function requestPermission(with:)
            return await requestAuthorizationAlways()
                         ^
/<...>/SourcePackages/checkouts/AsyncLocationKit/Sources/AsyncLocationKit/AsyncLocationManager.swift:121:26: warning: 'requestAuthorizationWhenInUse()' is deprecated: Use new function requestPermission(with:)
            return await requestAuthorizationWhenInUse()
                         ^

@tcobbs-bentley use 1.5.6 version)


Should foyer skip an empty def field?

In order to make a foyer force field file more template-y I propose that foyer should skip an empty def field.
<Type name="opls_001" class="C" element="C" mass="12.0107" def="" desc="" doi=""/>
That way it suggests to someone looking at this file that:

opls_001 is missing a def
This file is obviously a foyer force field file
The empty fields should be filled in

I'd be interested in hearing the cos for this. We can keep the current behavior where a type missing an def is ignored, but this would make things more explicit.
Thoughts?
I was thinking the logic could be added here:
https://github.com/mosdef-hub/foyer/blob/master/foyer/forcefield.py#L329-L330
But I'm not super familiar with foyer so if we decide to do this I might need some guidance in writing the PR.

I like this idea and I think you've identified the right location in the code. This might be as simple then as just adding some additional logic to that if statement to make sure the string is not empty.

I think this would be an improvement. It would be nice if it was explicit that an empty def is different than a missing comment (desc, doi), though the user would figure it out eventually when the atomtypes are missing. I'm not sure if this function would get triggered?
https://github.com/mosdef-hub/foyer/blob/master/foyer/validator.py?utf8=✓#L118

I also support this. We are already parsing the value of def to ensure that it is a valid SMARTS string so you should only have to check if it is non-empty as @summeraz mentioned.


Fix Attribute Consent flow not working for SAML in 5.3.x

Problem
There is a typo in AbstractConsentAction from 5.2.x to 5.3.x, that make Consent flow not worked for SAML in first time consent.
In 5.3.x: 5.3.5 AbstractConsentAction
        final MutableAttributeMap<Object> flowScope = requestContext.getFlowScope();
        flowScope.put("attributes", attributes);
        flowScope.put("principal", authentication.getPrincipal());
        flowScope.put("service", service);

In 5.2.x: 5.3.9 AbstractConsentAction
        requestContext.getFlowScope().put("attributes", attributes);
        requestContext.getFlowScope().put("principal", authentication.getPrincipal().getId());
        requestContext.getFlashScope().put("service", service);

In 5.3.x, service is put inside flowScope , instead it should be on flashScope .
Bug Behavior

CAS 5.2.x Behavior (enabled both SAML and Consent):

Initialized Login with SAML
Login
Show attribute consent page
Click confirm (With consent set to Attribute Name and save for 30 seconds)
Continue with SAML flow
Login Success

CAS 5.3.x Behavior (enabled both SAML and Consent):

Initialized Login with SAML
Login
Show attribute consent page
Click confirm (With consent set to Attribute Name and save for 30 seconds)
Failed to continue SAML flow (because of this bug), it will instead go to the service with a ticket param (e.g. if service is https://www.example.com/saml, it have returned https://www.example.com/saml?ticket=ST-ASDASDASD)
Reinitilzed login with SAML / Refresh the page
Login Success

After fixed
5.3.x flow now work as intended, just like 5.2.x.
Testing
I don't have time for this... See if other can help make the test case if needed, otherwise I might be able to spare some time in the weekend if possible.
Reference
Google group discussion: https://groups.google.com/a/apereo.org/forum/#!topic/cas-user/M3EqWouFjN8

Thanks. Could you explain why flashScope is required/needed here?

I am not familiar with Spring scoping, from what I can see:
In 5.2.x, it is using flashScope, and in 5.3.x it changes to flowScope.
And in 5.3.x, the following flow:

CAS Login > Attribute Consent > SAML

Will failed at the flow from "Attribute Consent" to "SAML".
If I am going to guess it, I think flashScope is needed because from "Attribute Consent" to "SAML" the flowScope "service" is lost somehow. I am really not sure about why without flashScope it will not work.

Andy, thank for this PR. I think I remember some details about this.
I believe FlashScope is needed because here, "service" is resolved as the SAML (or other service), which is needed to find the consent decision.
In the flow though, the service is the callback endpoint, which needs to be used for redirection. I believe I remember putting the resolved service in flash scope was "only" for UI purposes.
For regular CAS services (redirection = consent service), the flash and flow scopes will be the same, but for SAML this makes a difference.

For regular CAS services (redirection = consent service), the flash and flow scopes will be the same, but for SAML this makes a difference.

Could this PR be changed so that we'd only fetch stuff from the same/common spot? The fact that one has to remember the why is rather alarming. Unless there are specific valid reasons for keeping the scope separate, it would be good to keep things consistent.

I agree with @mmoayyed.
However I might needs to seek help from other contributor/ need more time to study Spring flow before implementing the better fix.
For this bug, I found the problem mostly by trial and error.

I think the alternative here might be to put a new element to flowscope which is then exclusively used by consent, e.g. "consentService".
I found the old PR: https://github.com/apereo/cas/pull/2925
Back then, we chose to do it exactly this way.

Unfortunately, I deleted the original attempt in the PR.

Help me understand please: Why wouldn't you want to work with the normal service found in the scope? What is special about consentService that needs to have its own attribute?

I'll give it a try. Sorry for my germanish english...
The moment consent is displayed, the service in the flow is the service redirected to. In the case of SAML (and possibly other protocol implementations), this is the callback endpoint. Using this service for consent is however not appropriate, since the user has to give consent for attribute release to the saml service.
The implementation of the consent action etc. takes this into account correctly, so no problems here.
On the interface side, the service for which the user is asked for consent should of course be displayed. Now, using the flow's service attribute in UI would display the callback endpoint, but, in the background, consent is granted for the SAML service. Therefore, ConsentAction has to somehow pass the "real" service to the view to be displayed to the user.
In my opinion, one way is to overwrite the service attribute for the view alone (flashScope), the other would be to pass a new attribute.

Are we only waiting for port forward?

How about this, we fix this bug by setting the flashScope for service in 5.3.x branch. So at least the bug is fixed in the production branch.
Then we can find an actual solution to this problem, so we don't need to add service to flashScope in CAS 6.x branch.
Does the above sounds like a feasible plan?

Sounds good to me.


Inquiry

Hello!
This webpage seems to be not live now.
Please check on this, ser
Thanks.

There is a link there that leads to the live site.
https://hamishw.com/
that's the link


Change auto-import and type-checking behavior in conformance with Pep 585

Pep 585 says that in Python 3.9, use of the typing module's generics such as Iterable, Generator, etc. is deprecated as those types will be merged with the types of the same names in collections.abc. In addition, typing's generic types that mimic built-in container types, such as List for list and Tuple for tuple, are similarly deprecated in favor of using the built-in types directly, e.g., List[int] should be written as list[int] going forward. In Python 3.7 and 3.8, these two behaviors can be achieved with from __future__ import annotations.
Ideally, in Python 3.9+ or in a 3.7 or 3.8 file containing that __future__ import, Pylance would 1. auto-import the non-built-in types (Iterable, Generator, etc) from collections.abc instead of from typing 2. issue a warning when the user imports those types from typing instead of collections.abc 3. issue a warning if the user uses e.g., typing.List instead of list.

Thanks for the report @rben01, will add this to our proposed enhancements.

Moving this issue to discussion as an enhancement request for comments and upvotes.


[Bug 🐞]: metrics.grid.tf Displays Node Addresses Instead of Node IDs

What happened?
metrics.grid.tf should use the node ID instead of using the node address.

Since it's very confusing for the user to select the node from a list of addresses however it is very simple to select a specific node id.

What did you expect?
The Node Selection should display a list of Node IDs.
What browsers are you seeing the problem on?
Chrome
ZOS info
No response
Dashboard info
No response
weblets info
No response
Relevant log output
No response

@0oM4R can you link the previous issue here


crop button not show in imagecrop popup

Setting -> Users -> Edit Image - Image crop popup
crop button is hidden after mouse hover  on white area near cancel button  text is show slightly.

This was fixed, please check it and we are waiting for your response


Set baremetal flag to false explicitly in helpernode vars file template

What is happening?
The default value of baremetal flag is set to  true in helpernode playbook repo. This is running certain unecessary tasks, which are not required on powervs platform.
Possible solution:
Set the baremetal flag to false explicitly while generating the helpernode vars file template to fix it.

Completed.


NT-1910: UX – Not logged in / Not backer for Comment Composer

📲 What
This change handles the different states of the comment composer in relation to the user state i.e. logged out, not backing, etc.
Also had to update the UI to make the separator disappear as it was still appearing when the composer was gone.
🤔 Why
There are three states -> ENABLED, DISABLED, GONE

GONE -> The comment composer should be completely gone if the user is not logged in.
ENABLED -> If the user is logged in and a backer, or is the creator, the comment composer is enabled.
DISABLED -> If the user is logged in but not a backer, then the comment composer should be in the disabled state

🛠 How
Created an enum that holds these three states, and when the comment view model is initiated, it emits this state to the activity and the view responds accordingly.
👀 See
Logged in: Backing and not backing

Logged out:

📋 QA
Make sure you have a project that you are not backing, a project that you are backing, and a project that you created, and all projects must have comments. Test going to the comments directly from the project page, as well as from the updates page. Then test the different states listed below.
🔴  = no comment composer
🟡  = comment composer disabled
🟢  = comment composer enabled
These are the different states to test:
Logged out = 🔴
Logged in and not backing = 🟡
Logged in and backing = 🟢
Logged in and creator = 🟢
Story 📖
NT-1910: UX – Not logged in / Not backer for Comment Composer

@Arkariang I noticed that too and figured we could update in a subsequent ticket. I'll make a ticket for it :)


try-puppeteer.appspot.com makes a bad impression about the Puppeteer

The fallibility of try-puppeteer.appspot.com is making a bad impact on the Puppeteer PR. Newcomers probably for the first try of  Puppeteer will go to the try-puppeteer.appspot.com and this site doesn't work too often (as we wish to). This can have an impact that Puppeteer is broken technology (not a website).
Possible solutions:

Remove reference to try-puppeteer.appspot.com
Or try to make try-puppeteer.appspot.com less unreliable

Agreed :( Unfortunately there are a bunch of stuff I've ran into with this app:

the key feature is allowing people to run arbitrary code, but that makes it hard to do cleanup work (e.g. reclaim memory) when chrome/pages crashes. Page crashes are pretty frequent and the VM eventually runs out of memory.
I thought some of the additions to puppeteer's unhandled promises cleanup would help 1, but it didn't.
I tried reusing an existing chrome instance across requests, but the node process ends up eating up too much memory. That setup ends up being much worse than launching chrome per request
headless chrome has bugs (see /dev/shim issue) in container env like docker.

One thing I still want to try is dumb-init but haven't got around to it yet. Until these are addressed, I think it's safe to downplay the demo site. I've removed it from the top of the repo.

@ebidel @Everettss maybe I can help. I've been working on a project of which Puppeteer is quite a large part. As a part of this, I created a playground that is pretty much a rip off of @ebidel 's work (sorry...). I saw this issued and decided to rush it out today.
I will be developing and supporting this fulltime: adding server capacity, fixing bugs etc. I think I worked around some of the VM, memory and Docker issues. I'll do a write about this late.
Also, I will be adding all the examples from https://github.com/checkly/puppeteer-examples
Feel free to use it or put it in the README.md for people that didn't find this issue:
https://trypuppeteer.com

@tnolet neat. LMK when that writeup is available! Also feel free to send me PRs :)

@ebidel I touched the Puppeteer source code a bit,  and I have one or two ideas about hooks and a configuration option that would make running Puppeteer "at scale in the cloud" a bit more convenient. More to come soon 😎

@tnolet +1, LMK too.
@ebidel Continuing our Chrome-On-Docker discussion, I've recently noticed a few more things that seem to help keep CPU usage down -

Run content shell instead of full Chromium. I just discovered this accidentally, but I'd to learn more about content shell and it's differences from Chromium.
Start content shell or Chromium with the --single-process flag.

@paambaati do you already have an example of using content shell? This sounds like exactly what I'm looking for. Chrome is a hog. 🤣

@sourcec0de Simple; switch out the chrome binary with the content shell. You can download the ZIP from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_x64/522446/, extract it and run the content_shell executable. Note that this isn't fully tested yet.


$aaFormExtensions.$clearErrors() invocation triggers 'Error: [$rootScope:inprog] $digest already in progress'

I have $scope.$watch's listener which calls the following code:
$formCtrl.$aaFormExtensions.$clearErrors();

This line triggers [$rootScope:inprog] error. In your code I see the following:
1: function $clearErrors() {
2:             if(!scope.$$phase){
3:                scope.$apply($clearErrors);
4:                return;
5:              }
6:             ....

Here scope.$$phase === null and the 3rd line is invoked, but in angular code:
1: function beginPhase(phase) {
2:      if ($rootScope.$$phase) {
3:        throw $rootScopeMinErr('inprog', '{0} already in progress', $rootScope.$$phase);
4:     }

Here $rootScope.$$phase === '$digest' and the error is thrown.
Could you please take a look into this issue or give me some advice how can I fix it ?
Thanks in advance!

Hey if you could give me a plunker of it I'll see if there is something better defensively that can be done to prevent that. Haven't ever tried that in the callback for a watch before, interesting....

Thank you for the quick reply!
Here a plunker with steps to reproduce the issue. FormModel directive from the plunker is used to clear aaFormExtensions errors when model is changed (form.$setPristine() is not enough).
I've investigated that the issue is reproduced in 0.8.26 version (when isolated scope is used).
0.8.23 version has no such issue.
I believe this is related to the following lines in $clearErrors() function.
What do you think?

apparently scope.$$phase isn't enough anymore you need to check scope.$root.$$phase too to make sure a digest isn't already in progress. The latest version should fix the issue, thanks for putting together the plunker!

Actually, it is because an isolated scope doesn't inherit $$phase property from $rootScope.
Thanks for great support! The latest version fixes the issue!

Oh interesting. I wonder if it's just possible to digest 1 isolate scope. Angular should just have a safeApply built in!!

On May 28, 2015, at 3:20 AM, Andrei<EMAIL_ADDRESS>wrote:
Actually, it is because an isolated scope doesn't inherit $$phase property from $rootScope.
Thanks for great support! The latest version fixes the issue!
—
Reply to this email directly or view it on GitHub.


Safari Browser

Animate.css Does not work in Safari 5.1
None of the fadeIns work. Does anyone have a solution?

This package uses gulp and autoprefixer.
Either autoprefixer thinks Safari does not need the -webkit- prefix, or Safari needs to be declared in autoprefixers browsers definition.
I usually explicitly declare the webkit prefix in my sass

It is not desired to, only last 2 browser version is supported
autoprefixer: {
    browsers: ['last 2 versions'],
    cascade: false
},


Add ruby toolchain required for code generation

cc: @tbetbetbe

LGTM

[Current coverage][cc-pull] is 67.90%

Merging [#17][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #17   diff @@
==========================================
  Files            24         24
  Lines           729        729
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            495        495
  Misses          234        234
  Partials          0          0

Powered by Codecov. Last updated by [ee4a7bd...ff0501a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/googleapis/artman/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/googleapis/artman/compare/ee4a7bd110f440f2d87f2d5c02872969e09589b2...ff0501a9c4f75aa87f6abedd13b0c903d87d1fc4
[cc-pull]: https://codecov.io/gh/googleapis/artman/pull/17?src=pr

LGTM

The codecov failures are reported because our CI don't consider docker at all right now. I'll proceed.


Create environment setup script [SATURN-1198]

After discussion offline, this doesn't register a user because in the near future test users will be parameterized.

How do I run the script? I see a new .js file that's probably it, though no new npm script config or anything.

I think I answered my own question:
node integration-tests/scripts/initializeEnvironment.js

Request: add integration-tests/README.md with something like:

Run node integration-tests/scripts/initializeEnvironment.js and follow the prompts.

Could also add some other stuff about the how to run the tests, what they depend on, etc. Just some basic info... nothing crazy.


Network Trace - Field Name/Parameter - Overview Area

The formatting is not correct

I am not able to set a polygon output as a parameter(a separate output, not the overview)

@MikeMillerGIS We will investigate and fix this in the next release

@MikeMillerGIS Can you please provide a GP Service with two polygon output parameters for reproducing this issue?

I emailed the URL Friday.

@MikeMillerGIS We checked our emails and could not find it. It may happen that our email server rejected it because it contained just a URL and a small amount of text. Can you please resend it?

@MikeMillerGIS We are not able to reproduce the issue related to formatting. Following is the screenshot:
Screen Resolution: 1980X1080

Screen Resolution: 1366X768

I am still getting this issue

@MikeMillerGIS We haven't provided any fix for this issue as we are not able to reproduce this yet. Can you please let us know the environment details e.g., screen resolution, browser version, OS version.

Windows 7, Chrome Version 42.0.2311.135 m, 1920x1080,

@MikeMillerGIS, We tested with the same environment and still unable to reproduce this. Is this consistently being reproduced on your side? We'd like to try to reproduce this with an app published on your side. Can you please publish an app and share the link with us?

@MikeMillerGIS, we tried using the gpservice that you provided after the call last week and still not able to reproduce this. Can you please share the widget's config.json and the webmap too?

@MikeMillerGIS As the UI for Save summary options is to be updated as discussed in issue #139, we feel that this issue will no longer be reproduced. We will not make any code changes to fix this issue. We can verify this in next release with the updated UI.

ok, closing for now


Compatibility with 117HD

When using the Fairy Ring Butterflies plug-in with the 117HD plug-in, the butterflies turn red. Neither removing or recolouring them seems possible while 117HD is also active. Is compatibility with 117HD possible?
Thank you for your plug-in regardless!

Hi,
I tested this on my own machine with 117HD on and it appears to work fine?

Can you let me know which 117HD settings you're using, and which ring you're seeing the issue with?
This plugin only changes the model colours, so it shouldn't conflict. Have you tried restarting the client with both enabled?

Thanks for the response. Glad to know it is on my end.
I am seeing the issue with all rings. When I turn 117HD off the plug-in works as intended. But when it is on I see this:

Changing colours also changes nothing

Here are my 117HD settings. I have messed with several ones in attempt to change something but no successes here.

Thanks again!

Ah yes, thanks for this.
I see the issue now. It's specific to the removal option- under the hood this just recolours the butterflies with a colour code of -1, which the default renderer interprets as invisible, but it appears the 117HD plugin changes something that makes it render as red instead.
since, secretly, the removal option is just a "recolour", it takes precedence over any colours you have set, which is why that didn't seem to be working for you either. If you untick the hide option you'll find that the recolour settings should work for you on HD.
No promises, but I'll look into getting the remove option to work with the HD plugin, see if I can find a way to make both renderers happy.

Fixed on latest- found a colour code that works for both standard and HD to remove the butterflies.
@Makaro1 You'll need to wait for the changes to be pulled by the plugin hub


feat(buttons): adding in color changes throughout applicable components

V3 button styling updates

Codecov Report

Merging #661 (1dca10b) into dev (26d7035) will decrease coverage by 0.22%.
The diff coverage is 85.91%.

@@            Coverage Diff             @@
##              dev     #661      +/-   ##
==========================================
- Coverage   89.21%   88.99%   -0.23%
==========================================
  Files         174      174
  Lines        4230     4251      +21
  Branches     1403     1417      +14
==========================================
+ Hits         3774     3783       +9
- Misses        232      237       +5
- Partials      224      231       +7

Impacted Files
Coverage Δ

...es/react-magma-dom/src/components/Banner/index.tsx
100.00% <ø> (ø)

...es/react-magma-dom/src/components/Button/index.tsx
100.00% <ø> (ø)

...om/src/components/Dropdown/DropdownSplitButton.tsx
100.00% <ø> (ø)

...magma-dom/src/components/Pagination/PageButton.tsx
100.00% <ø> (ø)

...magma-dom/src/components/Pagination/Pagination.tsx
93.02% <ø> (-0.16%)
:arrow_down:

packages/react-magma-dom/src/theme/magma.ts
100.00% <ø> (ø)

...ct-magma-dom/src/components/StyledButton/styles.ts
94.11% <85.29%> (-5.89%)
:arrow_down:

...ct-magma-dom/src/components/StyledButton/index.tsx
100.00% <100.00%> (ø)

.../react-magma-dom/src/components/SkipLink/index.tsx
92.00% <0.00%> (-8.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20c725...1dca10b. Read the comment docs.


RPP build defaults

ReadME and CMake changes for build defaults

@r-abishek can you look at the codacy suggestions?

@kiritigowda Fixed it


fix(zmath): fix usages of thisDir for relative @src.file

At least on NixOS x86_64, thisDir() will return relative paths when invoked from ZLS due to @src().file no longer consistently being an absolute path (likely due to Zig stage1 relying on WASI). This actually leads to ZLS crashing entirely, so zig-gamedev needs to be updated to resolve project-relative paths with cwd().
Although this solution seems a bit fragile and will be annoying to implement across the whole of zig-gamedev, it seems to work consistently and successfully allows ZLS to read build configuration properly again.
Note that for general usage of zig build, paths will be generated at comptime as before since @src.file appears to be absolute in those situations.
Also note that currently I have only fixed the issue for zmath, which is why I have created this PR as a draft.

Thanks for the PR!
This complexity is a bit unfortunate, I really liked the simplicity of thisDir(). Would it be possible to refactor the code into a single function?
Also, I can't repro the issue on Ubuntu 22.04, do you think it is NixOS specific?

It's likely possible to refactor it into a single function, I may have
gotten a little carried away.
I doubt it's specific to NixOS, but it's probably difficult to consistently
reproduce. What I know for sure is that the Zig compiler can't guarantee
absolute paths considering it has to work from WASI.
On Mon, Jan 2, 2023, 10:54 Michal Ziulek @.***> wrote:

Thanks for the PR!
This complexity is a bit unfortunate, I really liked the simplicity of
thisDir(). Would it be possible to refactor the code into a single
function?
Also, I can't repro the issue on Ubuntu 22.04, do you think it is NixOS
specific?
—
Reply to this email directly, view it on GitHub
https://github.com/michal-z/zig-gamedev/pull/179#issuecomment-1369052012,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJUDQRCXSFH7ZIXPUEETNTLWQL23FANCNFSM6AAAAAATOKHPTM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Closing due to this behavior being worked around by ZLS (https://github.com/zigtools/zls/pull/898)


Added seqence feature to maintenance script

@vedmaka - @jeffw16 and I were talking about this PR. Neither of us could remember why these three scripts need to be called in this specific order (if they do). I know that it's been almost a year, but - do you know the reason for this order, if there is one?

@yaronkoren, I am not sure either. All the maintenance scripts are async by design, so there are no benefits from starting them in order, I guess. Maybe it's good for custom scripts that are supported by that version of the script runner, not really sure

@vedmaka - okay, thank you. I'm closing this PR - if at some point later there are scripts added that simply have to be run in a certain order, then presumably they could just be named "mw_1...", "mw_2...", etc.


age-plugin-ledger: init at 0.1.0

Description of changes
This is a plugin for age and rage to use a Ledger Nano as a hardware security enclave.
It is highly similar to age-plugin-yubikey which is already present in Nixpkgs.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 231275 run on x86_64-linux 1

1 package built:

age-plugin-ledger

@erdnaxe edited my comment.
Can you do a rebase?

@erdnaxe are you still interested?

@erdnaxe are you still interested?

Yes, but I haven't found the time yet to retest the whole setup. I believe that now the Ledger Nano app for age is directly available in Ledger Live which should greatly simplify the setup.

Updated to 0.1.2. I tested it using Ledger Nano X and S+, both are working great.


Bubble indicator more styling props

From what I saw, the only option to style the bubble indicator is using the bubbleIndicatorColor option, which only let you style the background of the bubble indicator.
The problem appears when I'm using a light theme and I need to make the bubble indicator grey, because white won't be a good choice.
Example:

Now the label disappear because it's the same color as the background. It would be nice if you can add 3 more props:

TextStyle bubbleIndicatorTitleStyle
TextStyle bubbleIndicatorValueStyle
TextStyle bubbleIndicatorLabelStyle

Done,  I updated the code, Could you try using the dependency in this way:
bezier_chart:
    git:
      url: git://github.com/aeyrium/bezier-chart.git
      ref: master

And run : flutter packages upgrade
Check the sample8
I'm ignoring the fontSize for now.
Let me knows if it works.

It's perfect! Good job! 👍


Added mxn currency

I'm from Mexico and I need to see the currency exchanges at my local exchange rate.

Hi, A major refactoring around handling different currencies has been made, including new currencies is now a lot easier and flexible (thanks to @mglagola ). I'm working on top of his new approach to creating a preference system (local storage) where the user can pick which currencies they want to monitor from the ones available in the config file. With that in place, we can just add all possible cryptos in the new config file (the ones supported by the cryptocompare API initially)


Minor code cleanup

Description of changes: Changing ProcessSF2Dict into ProcessDataEntry, plus removing a useless transformation block used in it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-152/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-152/1/index.html

Codecov Report

Merging #152 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #152      +/-   ##
=========================================
- Coverage   79.61%   79.6%   -0.01%
=========================================
  Files         116     116
  Lines        6553    6546       -7
=========================================
- Hits         5217    5211       -6
+ Misses       1336    1335       -1

Impacted Files
Coverage Δ

src/gluonts/dataset/common.py
81.02% <100%> (-0.17%)
:arrow_down:

Looks good.
In the long term I think we should get rid of hard coded field names and allow a generic dataset that can have whatever fields it wants.


Fix elemental system agent config

Signed-off-by: David Cassany<EMAIL_ADDRESS>

There was a missing space... 🤦🏽


[Suggestion] Instruct users to return z.NEVER in .superRefine() when providing a type predicate

As the validation result solely depends on whether ctx.addIssue() is called,
https://github.com/colinhacks/zod/blob/ad4385439d7c0d7a584052dee5aa578fde5a6efd/README.md?plain=1#L1891
and the return value is only used to satisfy the type predicate and is always thrown away,
https://github.com/colinhacks/zod/blob/c9e4ed4095d77f5b43a5ba11d8f76b56ea48e5c6/src/types.ts#L3821-L3822
to prevent users from accidentally forgetting to call ctx.addIssue() while returning a boolean value as described in the example,
https://github.com/colinhacks/zod/blob/ad4385439d7c0d7a584052dee5aa578fde5a6efd/README.md?plain=1#L1931-L1945
instructing users to return z.NEVER instead of a boolean at the end (indicating the value is never used) just like the early return case when providing a type predicate may be a good idea.
  .superRefine((arg, ctx): arg is { first: string; second: number } => {
    if (!arg) {
      ctx.addIssue({
        code: z.ZodIssueCode.custom, // customize your issue
        message: "object should exist",
      });
    }

    return z.NEVER;  // this should satisfy the typing
  })

Hi @zetaraku  I'm guessing you suggest this out of experience :) Shouldn't be a big lift...
I'll take a swing at it!

Hi, @maxArturo.
I knew that the return type is necessary for the inferred refined type so I didn't recommend users to declare their refinement function as refinement: (arg: Output, ctx: RefinementCtx) => z.NEVER but still like refinement: (arg: Output, ctx: RefinementCtx) => arg is something.
I only encourage users to return a z.NEVER in the refinement function. (See the last snippet above)
By the way, refinement: (arg: Output, ctx: RefinementCtx) => z.NEVER actually doesn't work because z.NEVER is a value of never type, not a type itself.

By the way, refinement: (arg: Output, ctx: RefinementCtx) => z.NEVER actually doesn't work because z.NEVER is a value of never type, not a type itself.

Yes understood! It was a copy paste in haste.

I only encourage users to return a z.NEVER in the refinement function. (See the last snippet above)

Sounds good, if your suggestion is to update the docs I think it is an improvement. I'd welcome the PR! Thanks!

I made the PR above to update the docs.
Please take a look at it and let me know if anything needs to be adjusted :)
I wonder if the test cases should be updated to return z.NEVER too. 🤔