"feat:"add new locale for Ukrainian;

I will be very grateful if you add a Ukrainian locale to rocket.chat

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: online content api

First part for #597 (online version). Depends on https://github.com/serlo-org/athene2-assets/pull/7
Allows third parties to include serlo content with reduced layout using an iframe. E.g.:
E.g. <iframe src="https://de.serlo.org/1805?contentOnly">
There are a couple of query parameters to that modify the layout:

contentOnly is a shorthand for all following query params (except hideBreadcrumbs) and basically just shows the content + breadcrumbs
hideTopbar, hideLeftSidebar, hideRightSidebar, hideBreadcrumbs, hideDiscussions, hideFooter hide the corresponding section
fullWidth widens the page container to use full width

TODO

[x] @arekkas: allow to embed content from externally using an iframe (Refused to display <bla> in a frame because it set 'X-Frame-Options' to 'sameorigin'.
[x] @inyono: documentation, send link to simon
[ ] @SimonKoehl: API usage guidelines?
[x] @inyono: above license: Quelle: Die freie Lernplatform serlo.org (link with target blank)
[x] @inyono: hide-breadcrumbs (deactivated by default), w/o editing tools
[x] @inyono: banner(), horizon()

I incorporated the feedback. This is done from my side. Also, I documented the feature, see https://github.com/serlo-org/athene2/wiki/Content-API (@SimonKoehl)

I'm actually not sure if we can allow any source in X-Frame-Options. I'll try and find out.

LGTM


Metadata is missing setting.inputVerificationDelayTimeInMilliseconds

As Per PageLayout Documentation Self Asserted has a bullet list item that states Added a configurable user input validation delay for improved user experience. However, there is no supporting documentation as to how to configure this option.
Please add setting.inputVerificationDelayTimeInMilliseconds to the list of Metadata items for self-asserted technical profiles.
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c33bed9-7e41-92cb-e093-80e5fda0e718
Version Independent ID: 94d903c4-a70f-5357-53b4-6d17afee2aaa
Content: Define a self-asserted technical profile in a custom policy - Azure AD B2C
Content Source: articles/active-directory-b2c/self-asserted-technical-profile.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@Norrch2 Thank you for your feedback . We will investigate and update the thread.

Hi @shashishailaj  I noticed that this was closed without providing an update. I looked at the website and do not see an update. Is this not going to be included?

Hi @Norrch2 The document is updated with below information. It takes some time to reflect the changes. You should be able to see the update now.
setting.inputVerificationDelayTimeInMilliseconds: Improves user experience, by waiting for the user to stop typing, and then validate the value. Default value 2000 milliseconds.


Possible error in the documentation about Asynchronous calls using thrust::system::cuda::par

Dear Thrust developers, first I would like to thank you for all the incredible work you do for the cuda community.
I am on the way to delete part of my own cuda buffers wrapper in order to use your fantastic tools.
I decided to do so after seeing that you implemented a way to use concurrents stream through execution_policy.
Unfortunately, at the beginning my code was not able to compile because I used the documentation here:
https://thrust.github.io/doc/group__execution__policies.html#ga64da56b76f487725a99818cd63662dac
Where you use:
// create two CUDA streams
cudaStream_t s1, s2;
cudaStreamCreate(&s1);
cudaStreamCreate(&s2);
thrust::counting_iterator iter(0);
// execute for_each on two different streams
thrust::for_each(thrust::cuda::par(s1), iter, iter + 1, printf_functor(s1));
thrust::for_each(thrust::cuda::par(s2), iter, iter + 1, printf_functor(s2));
Although I think that thrust::cuda::par.on(s1) would be preferable because the previous example do not compile on my cuda-7.0 toolkit, when placed in .cu files.
Thank you for your work again.

Sorry, I am not able to delete this post.


Let users opt in to a default browser set

User story
Let users opt in to a default browser set
Acceptance criteria

[ ] the banner that notifies them about a new BCD feature lets them opt in to it
[ ] opt in is only shown to beta user

Tasks
If relevant, you can make a checklist for tasks.

[ ] This is an incomplete task.

To clarify after the initial discussion, the idea here is as follows:
We update the notification banner to have an enable button

Perhaps a checkbox as well?

One idea was that, once the user clicks enable, we scroll to the top of the page and load in(With React we do not have to reload the entire page) the feature. Now here, we need to somehow tell the user how they go about disabling the feature if they do not find it useful.
One idea is to add a message just below the support bar:

Something like, "Thank you for enabling browser sets. To disable the features, go to the browser sets section of your profile page."
Alternatively, we could add a button inside the browser set "sidebar":

The problem with this second option, for me, is that it could be unclear whether it refers to the browser set, or the entire feature.
Another option is to have different messaging that points the user back to the compatibility table to disable the feature:

Something like, "Thank you for enabling browser sets. You can disable the features by unchecking the box above the compatibility table."

For this iteration, we also need to update the language in the below as the user will get a default set, and not a configurable set.

This is taking it way too far for an MVP that's supposed to be seen only by beta users. Let's just do the opt-in as initially discussed. When we ask beta users to try this out we can document the opt-in, and let them know there is no opt-out for now. And one sprint after this we implement the opt-in and opt out as specced.

Agreed re the language change


not working when connected to a server

the entire set of commands does not exist while connected to a SMP server. nor does any chat messages. even tried running it in single player first but nothing. I really enjoy this mod but for some reason it is as if it is disabling itself when connected to a server. is there any hidden config options to just make it auto connect if it already has the token and channel to join ?


'docs()' description in the section 'Api from v4' is not correct

In README.md, there is docs() description and it is not correct.
There is no docs() method and there is doc() method.
doc description in README_V4.md should be ported.
I checked it with version 5.0.2
Thanks,

Thanks for report.
Going to update docs


Documentation Update: New Image Build Command

What this PR does / why we need it:
Updates the image build command
Which issue this PR fixes(if applicable):
fixes #2269
Release note:

NONE

@dulek Please help review

/ok-to-test

/lgtm
/approve
yes, the commit 42d28be20 updated the code

/cherry-pick release-1.28


Support repository_rule part 1

This commit adds the ability to support repository rules again.
This is will make smoke testing XCHammer and other programs easier.
Additionally, it's nice to have the option to do this. It doesn't add
too much complexity.
Followups will come to:

add the ability to BuildTest
build RepoTools in Bazel and pass it to the rule

Landing this for now, as there are no functional changes to existing features. I don't want this to bit rot - followups will include more automated testing.


Tasks requiring assistance?

@w8r Just checking if you have any particular things you'd like me to assist with? Any documentation or examples etc?

@rowanwins thanks for the offer! Well, task is more or less done for the essential cases, I only wanted to make them really work with FeatureLayers, grabbing renderers from metadata. Have to look into esri-leaflet-renderers to adapt their code for symbols from SVG to canvas. Then the whole picture would make sense
After that I could use some help with creating examples


test: upgrade node 18 and rename test to release

Upgrade node and semantic-release to v18
Rename test.yml to release.yml

@schabibi1 good points. I was configuring it, taking this one as a reference: https://github.com/storyblok/storyblok-nuxt/blob/main/.github/workflows/release.yml.
Maybe @roberto-butti can help give us some insights?

This will be covered in https://github.com/storyblok/storyblok-vue/pull/220


Two new tools: PointCloudTool & ScribbleTool

The development of two new tools started on June 14 and lasted for more than 3 months. There  may be some uncovered issues in there, but i think it's ready to publish.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


[usbdev,dv] Adds DV changes for error sequences

Adds changes in DV env to support error cases like timeout, PID error, CrC error and bitstuff error.

@alees24

Thanks for this PR. Superseded now that USBDEV has reached V2S status.


Fix unique and non null constraint on user email column

I realized that the migration from yesterday was not optimal, because apparently Sequelize generates different names for indexes when creating with addIndex vs. with {unique: true} on the model itself. The latter introduces an index implicitly, but the name is different (users_email vs users_email_key).
In order for the Model to work properly, we need to redo the index. Also, I noticed that for some reason we removed the NON NULL constraint on the email column in migration 006. Now that we have the index, we shouldn’t allow NULL values anymore, though.

@HildoBijl FYI, I’ve just released this to apply the migration.


Add error details

When Google returns a geocoding error, there is often helpful debugging information in the error message which is currently silently swallowed, this adds that text to the error handling.
Use case: Our API key had referrer enforcement turned on, suddenly today Google cut off out server side API as not allowed, this was unexpected and all we got from the server was request denied, manually curling the api cause the correct details to be exposed:
{
   "error_message" : "API keys with referer restrictions cannot be used with this API.",
   "results" : [],
   "status" : "REQUEST_DENIED"
}

Thanks!


improve floating point precision in backend properties

Small change to how conversions to SI are done in Qiskit, so very small numbers (e.g. 1e-12) are never used, which could cause distortions to precision. This was causing some issues when converting gate_lengths to dt (did not become multiple of dt).

This will be slightly slower, but hardly an impact. Good catch/optimization 👍


input reference and score path

Hi,
Thanks for the cool tool!
I would like to use our own dataset as the reference. Could you remind me how to use the output of cNMF as the reference?
Looks like it needs a .yaml file as the score data, while there isn't a .yaml file in cNMF output folder.
Thank you in advance.

Hi @Bo-UT, thanks for trying it out!
There is an example of using cNMF in the build_reference_vignette.ipynb example. There aren't any scores that are output by cNMF. So doing this just fits the usage of the programs learned by cNMF on new datasets. Any scores derived from this new reference would need to be made by you based on your interpretation and analysis of the cNMF output.
Does that make sense?

Great! Thanks a lot for your prompt response.  I tried
tcat = starCAT(reference='/path/to/test.gene_spectra_score.k_10.dt_0_02.txt',
            cachedir='./cache')
usage, _ = tcat.fit_transform(adata)

However, I encountered  another error
ValueError: Negative values in data passed to NMF (input H)
 ValueError
File ~/miniconda3/envs/single-cell/lib/python3.10/site-packages/sklearn/decomposition/_nmf.py:83, in _check_init(A, shape, whom)
     78 if shape[1] != "auto" and A.shape[1] != shape[1]:
 79     raise ValueError(

 80         f"Array with wrong second dimension passed to {whom}. Expected {shape[1]}, "

 81         f"but got {A.shape[1]}."

 82     )

---> 83 check_non_negative(A, whom)
84 if np.max(A) == 0:
85     raise ValueError(f"Array passed to {whom} is full of zeros.")
File ~/miniconda3/envs/single-cell/lib/python3.10/site-packages/sklearn/utils/validation.py:1650, in check_non_negative(X, whom)
1647     X_min = xp.min(X)
1649 if X_min < 0:
-> 1650     raise ValueError("Negative values in data passed to %s" % whom)

I do check the input adata and scaled adata (sc.pp.scale(adata, zero_center=False)), and all the values are non-negative. Do you have an insight why this error shows? Seems other people also met this kind of error .
Thank you.

Hi,
The error is caused by the reference "test.gene_spectra_score.k_10.dt_0_02.txt" which has negative values. It's fixed by using spectra_*.consensu.txt  from cNMF output.
tcat = starCAT(reference='/path/to/test.spectra.k_10.dt_0_02.consensus.txt',
            cachedir='./cache')
usage, _ = tcat.fit_transform(adata)

spectra_*consensus.txt is an intermediate file #59, and it should be safe to use? or would you recommend to use gene_spectra_tpm*.txt?
Thank you.

We actually found it is best to use a variance-normalized version of the gene_spectra_tpm file, subset to include only the highly variable genes. This will be non-negative, so it won't throw the error you previously got. We've implemented this type of output in the development branch of cNMF, which you can install using pip install git+https://github.com/dylkot/cNMF.git@development.
If you are able to rerun the consensus step of cNMF with the updated version, it will now output a starcat_spectra file which can be used as input into starcat.
Please let us know if you have any issues!

Hi @dylkot ,
Thank you!
Will try and keep you posted.
It seems the top genes from gene_spectra_tpm file are different from top genes fromgene_spectra_score file. Which top genes would you recommend to use?
Thanks.

Top genes are typically best from the gene_spectra_score file. Cheers!

Great.
Btw, the development branch of cNMF works well. Thanks a lot!

It is now pushed to the main branch. Thanks!


[LC0006] Wrong Error message about AutoIncrement  since version v0.25.9

Hi
I got the new version v0.25.9 deployed this morning. Since then I get a strange error message tagged with LC0006.
       field(16; "OGDT Merge Invoices"; Option)         {             Caption = 'Merge Invoices', Comment = 'nl-NL=Verkoopfacturen samenvoegen';             DataClassification = CustomerContent;             OptionCaptionML = ENU = ' ,Reference,Shipment Date,External Doc. No.',                               NLD = ' ,Referentie,Verzenddatum,Extern documentnr.';             OptionMembers = " ",Reference,"Shipment Date","External Doc. No.";         }
The "OptionMembers" line gets marked with "error LC0006: AutoIncrement fields are not possible in temporary tables!"
// Christian

Oh thats interesting, thanks for reporting!
Its strange that I dont get this error.
What version of the AL Extension are you using?

Hi Stefan,
I'm running right now v10.0.687650

hm so thats not the problem. But as I said, If I paste the code you provided into a table I dont get a warning.
Could you provide me a small sample app to reproduce? Then I can see what the problem is

Hi Stefan,
strange... just ran al go to create the sample project for you.
Now after switching between the projects, the issue seems gone.
I closed and reopened VS Code before, that did not do the trick.
Will see if I get it again - but for now we can close this issue.


Feature Request: Hotkey Trigger For IntelliSense Suggestions

The usefulness of IntelliSense could be dramatically improved by including a number-based hot-key quick select for the first 9 elements.
Alfred for Mac includes this feature, and I find it very useful.
With this addition, one could immediately select any of the top selections in the IntelliSense pop-up with a key shortcut such as Control-1 for the first, or Control-2 for the second. The modifier would be configurable for the user, and a sane default would need to be chosen to be shipped in VS Code. If we're getting into configuration, the entire feature could also be turned on and off by a setting.
A screenshot of the proposed behavior is attached to this issue.

It would be very very useful if implement the feature :)

/duplicate of https://github.com/microsoft/vscode/pull/58670


[stable/elasticsearch] Move logging configuration to values.yaml

What this PR does / why we need it:
Move logging configuration from configmap to values.yaml, so to allow customize it, for example to enable slow logs for old versions, don't repeat  log4j2.properties for different versions(v5, v6), so it should be possible to adjust log4j2.properties if needed.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @simonswine

/ok-to-test

/lgtm


Password reset flow does not work if previously logged in with a different email

Steps to reproduce

Setup<EMAIL_ADDRESS>account

Login as<EMAIL_ADDRESS>

Logout

Reset password for<EMAIL_ADDRESS>account

No reset is sent!

Lookup the password reset hash in api:
<EMAIL_ADDRESS>> 2cc7e6ef2e0f02afb9c35b0be5a29bc8

Go to https://id.heroku.com/account/password/reset/2cc7e6ef2e0f02afb9c35b0be5a29bc8

Reset password

Reset is successful, but you are redirected to the login form with<EMAIL_ADDRESS>prefilled, not<EMAIL_ADDRESS>

Logging in with the new password for<EMAIL_ADDRESS>works.

This issue was discovered because of a support ticket: https://support.heroku.com/tickets/357431

@dmcinnes or @adelcambre any ideas on this one?

The login prefill is almost certatingly coming from autocomplete on the user's browser since we don't keep track of or set a default value:
https://github.com/heroku/identity/blob/master/views/login.slim#L21
The no email sent is weird though, we can check our mail logs to see what happened to it...


Change the UI around "Chance of sausage"

Currently the "Chance of Sausage" indicator on stall cards only says LOW, MEDIUM, or HIGH.
Suggestion from H:

Say how many historical data points it's based on so folks can judge the accuracy of the prediction
Add wording around "no data available" if the chance is NULL

AB#133

Changed how we calculate the Chance of Sausage a while ago. This is done apart from the bit about how many data points it's based on.

Closing and merging into https://github.com/keithamoss/demsausage/issues/1746


ITE: drivers/serial: add power management constraint API

Instead of busy wait until completed transaction, the constraint set
is used before enabling tx interrupt to not allow system to enter
suspend when tx is transmitting.
Application defined policy should use the pm_constraint_get function
to check if given state is enabled and could be used.
TEST=Test on hayato board(soc:it8xxx2), the logs print normally before
system enters suspend.
Signed-off-by: Tim Lin<EMAIL_ADDRESS>

The original build condition was the correct one. This device is not doing device power management but actually put constraints in the system / kernel / SoC pm.

Thank you for the explanation.

The PR summary should start with "drivers: uart_ns16550:".  This change is not specific ITE.

The PR summary should start with "drivers: uart_ns16550:". This change is not specific ITE.

Done.


Isolate all the cobra cli commands under cli Folder

Part of fixing #11
Previous State

Previously, cobra CLI commands/flags were bit messed up
Codebase was unstructured

Current Behaviour
part 1

[x] Restructured the whole codebase with efficient manner
[x] Separated all the cobra functions eg. func CreateProjectCommand() *cobra.Command to cli/cmd folder with root.go which is for adding all the cobra cli func with RootCmd. This cobra func is using all the RunFunction  from api folder i.e. apis.go

IMO, the code base structure follows the recommended guidelines, especially using the internal folder this PR removes.
Maybe some things can be restructured, but I don't think it is needed.
PS: I don't want to be intrusive, just an opinion.

IMO, the code base structure follows the recommended guidelines, especially using the internal folder this PR removes. Maybe some things can be restructured, but I don't think it is needed.
PS: I don't want to be intrusive, just an opinion.

Actually here the main aim is to separate all the jargons cli, api which would be more efficient for any contributor also to understand the codebase easily. And PR #16 adding internal/pkg folder which is also signifying all the internal package being utilized!
WDYT?

Let's keep the current folder structure; restructuring isn't necessary as effort has already been invested in this PR.

Let's wait for @Vad1mo what this PR seems to him as it also took a lot of effort and interrelated with #16 to separte the whole api and cli. Doesn't it make this codebase more enhanced than previous state in order to understand by any new contributor?

closing this PR, since it no longer required. // @Vad1mo


Lambda: give the suc constructor is the text with an argument

In the chapter on lambda calculus, this simple patch changes how the suc constructor is given in the text. A consistent way in the introduction of the chapter would be: suc is given an argument, zero takes no arguments and case takes 4 arguments.

Please feel free to squash commits when merging the pull request.


BUGFIX AllowedEmail have wrong type of version column and Add unit tests

Please review and test it carefully

Reviewed.
Thank Hung 👍

Please let me know when you done your review, I'll squash 2 commits

Done, please squash it


code modification

Description of the change:
Reason for the change:
Link to original source:

Closes #

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.G.D.U.L Sampath seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

hey @udaragd - thanks for the typo catch. Unfortunately, we're no longer using this readme file. Please check back in though, because we are adding new issues every day!


Connect to SQL managed instance dialogue box appears after instance's tab has been closed

This was found when I would accidentally click on my SQL managed instance. I would close out of the tab and continue to the correct resource I was trying to view and the dialogue box would open on my screen even though I was longer viewing the instance.
Steps to Reproduce:

Click to open SQL managed instance from controller dashboard.
Quickly close tab.
Wait for dialogue box to still appear. (In this example I was already on the dashboard page for my PostgreSQL instance)

Could add a cancellation token for this kind of scenario to make sure we're only opening opening the dialog when it makes sense.
Even if we don't close the tab but move to another one it would still pop up later on too.
Might even be worth looking into popping up the dialog right away and then displaying a loading spinner until we get the MIAA endpoint info.

Closing this as a duplicate of https://github.com/microsoft/azuredatastudio/issues/13373


Cowboy 2.0 migration

fixes #458

Coverage increased (+0.008%) to 4.928% when pulling 475b34e5b2f8448eb40501a1438f18660cf302d1 on cowboy_2.0 into b27d380c7243a95c3d3b3c3b2a8d6692ebeb4656 on master.


Add support for multi-cert disk cache.

Add support for multi-cert disk cache based on existing single-cert disk cache.

cc: @twifkak

Also sorry for slow response.


how to restore drawables？

Hello, I want to know how to save the drawn content. When I open the app next time, use Controller.addrawables to restore it, or there are other ways to save locally. Does it start to restore next time?

I mean: How to save Drawables in the local area
Hope to get your reply thanks


Add cooking-pod icon

Maybe we can try to explore different designs for the lid?

What about giving it a more obvious handle?

What about giving it a more obvious handle?

I'm okay with that, feel free to create a PR.

Changes applied in #1737


[Calling][Release] 1.12.0 GA to main

Purpose

Bring 1.12.0 GA to main

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull Request Checklist

[ ] Public API changes
[ ] Verified for cross-platform
[ ] Synced with iOS, Web team
[ ] Internal review completed
[ ] UI Changes

[ ] Screen captures included
[ ] Tested for Light/Dark mode
[ ] Tested for screen rotation
[ ] Tested on Tablet and small screen device (5")
[ ] Include localization changes

[ ] Tests

[ ] Memory leak analysis performed
[ ] Tested on API 21, 26 and latest
[ ] Tested for background mode
[ ] Unit Tests Included
[ ] UI Automated Tests Included

How to Test

Open...
Click on...

What to Check
Verify that the following are valid

...

Other Information

Closed as licence is not queued.


[WFCORE-3460] Update the public packages in the org.wildfly.security.elytron module

Depends on https://github.com/wildfly-security/wildfly-elytron/pull/1041
https://issues.jboss.org/browse/WFCORE-3460

Core - Full Integration Build 6271 outcome was FAILURE using a merge of 58501a05a88422c22b76ad3895ed2ca5440c9d18
Summary: Compilation error: Compiler (new) Build time: 00:00:33

Full integration - Windows Build 4711 outcome was FAILURE using a merge of 58501a05a88422c22b76ad3895ed2ca5440c9d18
Summary: Compilation error: Compiler (new) Build time: 00:02:09


Fabricate.find_or_create_by feature

This would clean up many of the issues Factory Girl, Machinist, etc run into.
The goal would be, try to create Fabricate.find_or_create(:database, :name => 'john') so that you do not have to worry about validation errors etc when building multiple fixtures. This is what you run into alot more when you do ! methods.
This can be extended to do find_or_build(:database,...) as well.
Otherwise loving fabrication :)

Some news?

I haven't gotten to this yet. If you guys want to write a fabrication-caching gem that extends it with this functionality like you did for machinist, that would be great.

@paulelliott if I create a fork with this working fine, a pull request will be appreciated? :)
I don't want to add a one more dependency for that :(

Yes, absolutely! Please, make sure there are specs for it though.
-- Paul
On Thursday, December 15, 2011 at 1:51 PM, Gabriel Sobrinho wrote:

@paulelliott if I create a fork with this working fine, a pull request will be appreciated? :)
I don't want to add a one more dependency for that :(

Reply to this email directly or view it on GitHub:
https://github.com/paulelliott/fabrication/issues/6#issuecomment-3166937

@paulelliott I will take a look into this ASAP


allow custom headers

Useful for fetching compressed responses, for example. https://clickhouse.com/docs/en/interfaces/http#compression
iex> {:ok, conn} = Ch.start_link()
iex> Ch.query(
  conn,
  "select * from system.numbers limit 100",
  _params = [],
  format: "CSVWithNames",
  headers: [{"accept-encoding", "gzip"}],
  settings: [enable_http_compression: 1]
)
{:ok,
 %Ch.Result{
   command: :select,
   num_rows: nil,
   rows: [
     <<31, 139, 8, 0, 0, 0, 0, 0, 0, 3, 4, 193, 185, 77, 0, 64, 16, 4, 65, 191,
       195, 32, 130, 155, 157, 125, 211, 65, 194, 4, 3, 137, 252, 169, 250, 248,
       249, 251, 254, 252, 250, 253, 224, 33, ...>>
   ],
   headers: [
     {"date", "Wed, 25 Oct 2023 17:36:19 GMT"},
     {"connection", "Keep-Alive"},
     {"content-type", "text/csv; charset=UTF-8; header=present"},
     {"x-clickhouse-server-display-name", "c8f52f9cd86e"},
     {"transfer-encoding", "chunked"},
     {"x-clickhouse-query-id", "d341876d-edb4-4825-a965-008ab7b2f450"},
     {"x-clickhouse-format", "CSVWithNames"},
     {"x-clickhouse-timezone", "UTC"},
     {"keep-alive", "timeout=3"},
     {"content-encoding", "gzip"},
     {"x-clickhouse-summary",
      "{\"read_rows\":\"100\",\"read_bytes\":\"800\",\"written_rows\":\"0\",\"written_bytes\":\"0\",\"total_rows_to_read\":\"0\",\"result_rows\":\"0\",\"result_bytes\":\"0\"}"}
   ]
 }}

Small compression ration / time test:
 {:ok, conn} = Ch.start_link()
sql = "select * from system.numbers limit {$0:UInt64} format CSVWithNames"

for limit <- [
      10,
      100,
      1000,
      10000,
      100_000,
      1_000_000,
      10_000_000,
      100_000_000
      # 1_000_000_000
    ],
    codec <- ["gzip", "zstd", "lz4", :default, nil] do
  opts =
    case codec do
      nil -> []
      :default -> [settings: [compress: 1]]
      _ -> [settings: [enable_http_compression: 1], headers: [{"accept-encoding", codec}]]
    end

  before = System.monotonic_time(:millisecond)
  resp = Ch.query!(conn, sql, [limit], opts)
  time = System.monotonic_time(:millisecond) - before

  size = IO.iodata_length(resp.rows)

  %{numbers: limit, compression: codec, byte_size: size, time_ms: time}
end

Result:
[
  %{byte_size: 55, numbers: 10, compression: "gzip", time_ms: 25},
  %{byte_size: 48, numbers: 10, compression: "zstd", time_ms: 9},
  %{byte_size: 48, numbers: 10, compression: "lz4", time_ms: 5},
  %{byte_size: 82, numbers: 10, compression: :default, time_ms: 4},
  %{byte_size: 29, numbers: 10, compression: nil, time_ms: 3},
  %{byte_size: 175, numbers: 100, compression: "gzip", time_ms: 3},
  %{byte_size: 165, numbers: 100, compression: "zstd", time_ms: 4},
  %{byte_size: 318, numbers: 100, compression: "lz4", time_ms: 3},
  %{byte_size: 353, numbers: 100, compression: :default, time_ms: 2},
  %{byte_size: 299, numbers: 100, compression: nil, time_ms: 2},
  %{byte_size: 1782, numbers: 1000, compression: "gzip", time_ms: 2},
  %{byte_size: 1671, numbers: 1000, compression: "zstd", time_ms: 8},
  %{byte_size: 3829, numbers: 1000, compression: "lz4", time_ms: 4},
  %{byte_size: 3929, numbers: 1000, compression: :default, time_ms: 2},
  %{byte_size: 3899, numbers: 1000, compression: nil, time_ms: 1},
  %{byte_size: 21572, numbers: 10000, compression: "gzip", time_ms: 3},
  %{byte_size: 21262, numbers: 10000, compression: "zstd", time_ms: 3},
  %{byte_size: 38848, numbers: 10000, compression: "lz4", time_ms: 3},
  %{byte_size: 39836, numbers: 10000, compression: :default, time_ms: 2},
  %{byte_size: 48899, numbers: 10000, compression: nil, time_ms: 1},
  %{byte_size: 213195, numbers: 100000, compression: "gzip", time_ms: 9},
  %{byte_size: 74083, numbers: 100000, compression: "zstd", time_ms: 5},
  %{byte_size: 397842, numbers: 100000, compression: "lz4", time_ms: 7},
  %{byte_size: 411608, numbers: 100000, compression: :default, time_ms: 4},
  %{byte_size: 588899, numbers: 100000, compression: nil, time_ms: 2},
  %{byte_size: 2144414, numbers: 1000000, compression: "gzip", time_ms: 45},
  %{byte_size: 293704, numbers: 1000000, compression: "zstd", time_ms: 24},
  %{byte_size: 3997929, numbers: 1000000, compression: "lz4", time_ms: 43},
  %{byte_size: 4153466, numbers: 1000000, compression: :default, time_ms: 20},
  %{byte_size: 6888899, numbers: 1000000, compression: nil, time_ms: 6},
  %{byte_size: 21788402, numbers: 10000000, compression: "gzip", time_ms: 387},
  %{byte_size: 2980459, numbers: 10000000, compression: "zstd", time_ms: 215},
  %{byte_size: 40014640, numbers: 10000000, compression: "lz4", time_ms: 398},
  %{byte_size: 41831120, numbers: 10000000, compression: :default, time_ms: 157},
  %{byte_size: 78888899, numbers: 10000000, compression: nil, time_ms: 48},
  %{
    byte_size: 229961299,
    numbers: 100000000,
    compression: "gzip",
    time_ms: 3789
  },
  %{byte_size: 30967185, numbers: 100000000, compression: "zstd", time_ms: 2371},
  %{byte_size: 400253481, numbers: 100000000, compression: "lz4", time_ms: 4112},
  %{
    byte_size: 419014292,
    numbers: 100000000,
    compression: :default,
    time_ms: 1584
  },
  %{byte_size: 888888899, numbers: 100000000, compression: nil, time_ms: 643}
]


Warning about incompatible spaCy models.

I get the following error when trying to load en_core_sci_sm:
UserWarning: [W031] Model 'en_core_sci_sm' (0.2.4) requires spaCy v2.2 and is incompatible with the current spaCy version (2.3.0). This may lead to unexpected results or runtime errors. To resolve this, download a newer compatible model or retrain your custom model with the current spaCy version. For more details and available updates, run: python -m spacy validate
  warnings.warn(warn_msg)

Steps to reproduce:
Create clean Conda environment and activate
conda create --name scispacy python=3.8
conda activate scispacy

Install scispacy and install the latest en_core_sci_sm model.
pip install scispacy
pip install https://s3-us-west-2.amazonaws.com/ai2-s2-scispacy/releases/v0.2.4/en_core_sci_sm-0.2.4.tar.gz

Attempt import
(scispacy) $ python -c "import spacy; nlp=spacy.load('en_core_sci_sm')"
/home/davidw/miniconda3/envs/scispacy/lib/python3.8/site-packages/spacy/util.py:271: UserWarning: [W031] Model 'en_core_sci_sm' (0.2.4) requires spaCy v2.2 and is incompatible with the current spaCy version (2.3.0). This may lead to unexpected results or runtime errors. To resolve this, download a newer compatible model or retrain your custom model with the current spaCy version. For more details and available updates, run: python -m spacy validate
  warnings.warn(warn_msg)

Is this warning important or can I ignore it?
Thanks,
Dave

Looks like the spacy 2.3.0 release requires retraining the models. Can you go back to spacy==2.2.4?

That fixed it. Thanks!

I'm going to reopen this because we need to retrain the models for spacy 2.3.0 and other people will hit this, thanks for reporting!

OK sounds good.

I have observed the same problem.
Also, notice that the new 1.10 release of Prodigy requires spacy v2.3. This means that prodigy v1.10 cannot be used to fine-tune ScispaCy models.

I ran into this as well -- 1.10 release of Prodigy requires spacy 2.3
Here are some release notes on spacy 2.3 that mention incompatibility with models trained on earlier versions

closed by #247

i am facing same issue while importing en_core_web_sm in python3 and can't retrain spacy version from 2.3.5 to 2.2.5

i am facing same issue while importing en_core_web_sm in python3 and can't retrain spacy version from 2.3.5 to 2.2.5

I followed the instructions here:
https://spacy.io/usage
pip install -U pip setuptools wheel
pip install -U spacy
python -m spacy download en_core_web_sm

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
en-core-web-sm 3.1.0 requires spacy<3.2.0,>=3.1.0, but you have spacy 3.2.1 which is incompatible.
en-core-web-lg 3.1.0 requires spacy<3.2.0,>=3.1.0, but you have spacy 3.2.1 which is incompatible.
allennlp 2.8.0 requires spacy<3.2,>=2.1.0, but you have spacy 3.2.1 which is incompatible.
Successfully installed spacy-3.2.1

Any fix to this?
UserWarning: [W094] Model 'en_core_web_sm' (2.2.0) specifies an under-constrained spaCy version requirement: >=2.2.0. This can lead to compatibility problems with older versions, or as new spaCy versions are released, because the model may say it's compatible when it's not. Consider changing the "spacy_version" in your meta.json to a version range, with a lower and upper pin. For example: >=3.4.2,<3.5.0   warnings.warn(warn_msg)


Catching errors from an RCTRootView

I want to be able to conceptually catch all errors thrown from an RCTRootView instance rather than displaying the red box. This opens the door for custom error handling and the red box could be implemented as the fallback error handler.

You can add a custom error handler by using RCTSetLogFunction(). This won't disable the RedBox (perhaps it should - TBD), however you can do that separately by setting RCT_DEBUG=0.
If you can think of a better solution that won't break existing expectations, I'd be happy to consider it.
In future, RCTRedBox is likely to become a module, so you'll be able to replace it by passing in an alternative module with the same name vis the moduleProvider block. For now, the only option that doesn't involve changing the RCT_DEBUG preprocessor flag would be to swizzle some methods in the RCTRedBox (we do this in some of our unit tests).

Thanks for the tip about RCTSetLogFunction(). I want to build a sort of custom console for the RCTRootView so this sounds great to start.

Handling soft/hard exceptions with the exceptions manager works well for most cases. I think there are some errors that don't go through that code path but will open up separate issues and/or PRs for those when needed.


"Back to content" link in Article.js is causing a "prop 'to' is undefined" warning

index.js:1 Warning: Failed prop type: The prop to is marked as required in Link, but its value is undefined.
in Link (at Article.js:252)
in Article (at App.js:195)
in component (created by Context.Consumer)
in Route (at App.js:195)
in Switch (at App.js:189)
in main (at App.js:188)
in div (at App.js:187)
in Router (created by BrowserRouter)
in BrowserRouter (at App.js:184)
in App (at src/index.js:6)

Fixed in upcoming commit by replacing link with button.


example.mzML cannot load successfully

hello, the peak list file cannot be uploaded successfully, not even the example.mzML, every time the upload progress reaches  82%, the progress bar will be cleared. Could you please check it? Thank you very much.

this is on the spectrumviewer.org website?

hello, the peak list file cannot be uploaded successfully, not even the example.mzML, every time the upload progress reaches 82%, the progress bar will be cleared. Could you please check it? Thank you very much.

It's a problem from xiSPEC.

ok, thanks (we have more than one thing using this repo)

The example can now be uploaded again.
The server keeps running out of disk space. Can you please provide me with details about the files you are trying to upload (name, file size)? Are you trying to upload peak list files that are very large?

The example can now be uploaded again. The server keeps running out of disk space. Can you please provide me with details about the files you are trying to upload (name, file size)? Are you trying to upload peak list files that are very large?

the file name that I just uploaded is called "20221019-BSA-1.mgf" and is 278,739KB in size.

The example can now be uploaded again. The server keeps running out of disk space. Can you please provide me with details about the files you are trying to upload (name, file size)? Are you trying to upload peak list files that are very large?

my files can be uploaded successfully now, thank you so much!❤


Enable SSA in IR inliner

This adds SSA in IR inlining since some functions to be inlined may require SSA for proper typing.
Closes #6721.

Thanks for the patch @ehsantn.

@ehsantn, am I right that getting rid of multiple assignment to variable of the same name is the main fix? So applying SSA in problematic area does the magic.

Yes, I believe that's correct.

@ehsantn In reviewing this and trying to understand the original bug and how this fixes it, am wondering if something like this https://github.com/numba/numba/pull/6748/files would produce an equivalent effect to that contained in this PR?

I don't think #6748 solves the problem completely, even though it happens to fix this particular reproducer. I just tried, and it doesn't fix the actual use case. To be safe, all code going through type inference should be SSA I think.

Here is an example that doesn't work with #6748 :
import numba
import numpy as np

dummy_one = True

def f(S):
    pass

@numba.extending.overload(f, inline="always")
def f_overload(A):

    def impl(A):
        s = dummy_one
        for i in range(len(A)):
            dummy = dummy_one
            if A[i]:
                dummy = A[i]
            s *= dummy
        return s
    return impl

@numba.njit
def f2(A):
    return f(A)

print(f2(np.array([True, False, True])))


Automatically fix invalid project name input with spaces

Currently Appinventor handle invalid project name with spaces like this:

Why not use underscore to replace space automatically?
Just like this:

This sounds to me like a reasonable enough thing to do.

@ewpatton I would like to work on this issue.

I want to work on this issue

I want to work on this issue

@ewpatton

@mhk19 Please pick another issue, I am working on this one.

Fixed by #2143


No proxy

Which section is this feature request for?
L7 (DDoS Attack Layer 7)
Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
Nope
Describe the solution you'd like
Make it so we can send attacks without the use if proxys
Additional context
Please

You can already send attacks without using a proxy
Just create an empty file in the proxy folder

You can already send attacks without using a proxy
Just create an empty file in the proxy folder
Do you have a new idea?

Ive t

You can already send attacks without using a proxy
Just create an empty file in the proxy folder
Do you have a new idea?

There is no proxy file? No folder

i know
create in  proxies folder


Erorr on local npm install

when npm install
i get this erorr:
61 error code EUNSUPPORTEDPROTOCOL
62 error Unsupported URL Type "workspace:": workspace:*

hi we recommend using pnpm. Let us know if you face any issues after switching.

Hi @bllfoad, are you able to check with pnpm?

Closing this due to lack of activity. Feel free to reopen in case you face any issues installing via pnpm.


New configuration option for footnote extension: BACKLINK_TEXT

BACKLINK_TEXT specifies the text that's used in the link at the end of
the footnote to link back up to the reader's place. It still defaults to
"↩".

I thought this might be useful.

How's that?


Rework map

For map view: Solve #245, #359
For search view: Solve #346, #162, #400, #403
Live at: http://gofullstack.me:3001/
How to check:

For #245 about the map control, http://gofullstack.me:3001/map,  now it should have layers control on the top left to show/hide layers
For #359, about the number of followers/followings, well I'm sure it's enough because we're not using Hello.js anymore. The maximum you can see right now is 1000 markers.
For #346

For map: try a map search: http://localhost:3000/search?q=%23vow%2B%2Fmap, and then type a new search term, the map will reload, or you can switch filter & try a new search term and then back to map, the map will be reload.
For video: try http://localhost:3000/search?q=%23london%2B%2Fvideo, and then change search term to, for example: #newyork

For #162, ab search suggestions:

When you type >=3 chars in search term, it will shows some suggestions. You can either click on it or use up/down arrow and enter.

For #400

Now you can use profanity filter e.g. http://gofullstack.me:3001/advancedsearch?q=hot -%2Fprofanity near:London, by clicking on profanity in advanced search options http://gofullstack.me:3001/advancedsearch (Words section, 6th option)

For #403: this search blue info bar is now smaller:

Currently

[ ] no followers/following on the map
[ ] Europe is missing from the map

[ ] Add info of number of displayed followers as mentioned here https://github.com/loklak/loklak_webclient/issues/359#issuecomment-124820399
[ ] In Activity bar reload on scroll down
[ ] There is an unused area, that does not serve a purpose. You could just attach this area on the right instead of overlaying it. Compare to Facebook sidebar, please.

You can also commit this PR and create a new issue to follow up on the open issues mentioned here.


Change ASM module to default to 32 bit and add 64 bit executor

There is currently no way to distinguish between running 32-bit and 64-bit code in the assembly module so I decided to do something about it.
I defaulted nasm/asm to 32-bit assembly as that is the more common form of assembly most people will be familiar with. I then
added the 64 bit assembly under the names nasm64 and asm64.
The test file for nasm was already written in 32 bit assembly and would always fail since nasm was set to compile in 64 bit mode. I kept this same file and wrote a new test for 64 bit assembly.
As for the main.go file, "go format" was automatically run leading to the indentation being corrected to the go standards. I did not realize it until I pushed my commit, but I can undo that if you would like. Changes at line 81 and 155.
The "executing version" of the language will still return nasm for asm and will now return nasm64 for asm64.

thx, nice


Automatic error report

Problem Description
What steps will reproduce the problem?

Drag and drop a file from windows explorer which has a path containing a # character. Interestingly, it is not a problem if opened from the menu (File -> Open).
Traceback
  File "C:\ProgramFiles\Anaconda3\lib\site-packages\spyder\widgets\editor.py", line 2389, in dropEvent
    files = [f for f in files if encoding.is_text_file(f)]
TypeError: 'NoneType' object is not iterable

Package Versions

Spyder version: 3.2.8
Python version: 3.6.5
Qt version: 5.9.4
PyQt5 version: 5.9.2
Operating system: Windows 10

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.4.0 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.23.0 (OK)
numpy >=1.7      :  1.14.3 (OK)
sphinx >=0.6.6   :  1.7.4 (OK)
rope >=0.9.4     :  0.10.7 (OK)
jedi >=0.9.0     :  0.12.0 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.28.2 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.4.0 (OK)
pylint >=0.25    :  1.8.4 (OK)

Thanks for reporting. This issue was already fixed and it'll be part of our next release (3.3.2)

And you already reported this. Please don't report it again.


sample: add code snippet examples for different endpoints

The Notification Templates was omitted because the api has been changed to workflows. The SDk needs to be updated@

Please still add the notification templates for now. Whenever the SDK methods name change, we will update the readme but it won't change anytime soon.

@unicodeveloper I've added the notification templates section


Reformat UG

Key Summary

Reformat UG to include more details for certain commands such as edit or add
Separate out input constraints into add command and wherever needed instead of the start of the feature list

Codecov Report

Merging #210 (e3de7a5) into master (90e4b46) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e3de7a5 differs from pull request most recent head 4f5fdb9. Consider uploading reports for the commit 4f5fdb9 to get more accurate results

@@            Coverage Diff            @@
##             master     #210   +/-   ##
=========================================
  Coverage     67.71%   67.71%
  Complexity      550      550
=========================================
  Files            96       96
  Lines          1908     1908
  Branches        245      245
=========================================
  Hits           1292     1292
  Misses          531      531
  Partials         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e4b46...4f5fdb9. Read the comment docs.


Fix size categories in YAML Tags

This PR fixes several size_categories in YAML tags and makes them consistent. Additionally, I have added a few more categories after 1M, up to 1T. I would like to add that to the streamlit app also.
This PR also adds a couple of infos that I found missing.
The code for generating this:
for dataset in sorted(os.listdir('./datasets/')):
    if '.' not in dataset and dataset not in ['c4', 'csv', 'downloads', 'cc100', 'ccaligned_multilingual', 'celeb_a', 'chr_en', 'emea', 'glue']:
        infos = {}
        stats = {}
        st = ''
        with open(f'datasets/{dataset}/README.md') as f:
            d = f.read()
        start_dash = d.find('---') + 3
        end_dash = d[start_dash:].find('---') + 3
        rest_text = d[end_dash + 3:]
        try:
            full_yaml = OmegaConf.create(d[start_dash:end_dash])
            readme = OmegaConf.to_container(full_yaml['size_categories'], resolve=True)
        except Exception as e:
            print(e)
            continue
        try:
            with open(f'datasets/{dataset}/dataset_infos.json') as f:
                data = json.load(f)
        except Exception as e:
            print(e)
            continue  # Skip those without infos.
        done_set = set([])
        num_keys = len(data.keys())
        for keys in data:
            # dataset = load_dataset('opus100', f'{dirs}')
            total = 0
            for split in data[keys]['splits']:
                total = total + data[keys]['splits'][split]['num_examples']
            if total < 1000:
                st += "- n<1K" + '\n'
                infos[keys] = ["n<1K"]
            elif total >= 1000 and total < 10000:
                infos[keys] = ["1K<n<10K"]
            elif total >= 10000 and total < 100000:
                infos[keys] = ["10K<n<100K"]
            elif total >= 100000 and total < 1000000:
                infos[keys] = ["100K<n<1M"]
            elif total >= 1000000 and total < 10000000:
                infos[keys] = ["1M<n<10M"]
            elif total >= 10000000 and total < 100000000:
                infos[keys] = ["10M<n<100M"]
            elif total >= 100000000 and total <<PHONE_NUMBER>:
                infos[keys] = ["100M<n<1B"]
            elif total >=<PHONE_NUMBER> and total <<PHONE_NUMBER>0:
                infos[keys] = ["1B<n<10B"]
            elif total >=<PHONE_NUMBER>0 and total <<PHONE_NUMBER>00:
                infos[keys] = ["10B<n<100B"]
            elif total >=<PHONE_NUMBER>00 and total <<PHONE_NUMBER>000:
                infos[keys] = ["100B<n<1T"]
            else:
                infos[keys] = ["n>1T"]
            done_set = done_set.union(infos[keys])
        if (isinstance(readme, list) and list(infos.values())[0] != readme) or (isinstance(readme, dict) and readme != infos):

            print('-' * 30)
            print(done_set)
            print(f"Changing Full YAML for {dataset}")
            print(OmegaConf.to_yaml(full_yaml))

            if len(done_set) == 1:
                full_yaml['size_categories'] = list(done_set)
            else:
                full_yaml['size_categories'] = dict([(k, v) for k, v in sorted(infos.items(), key=lambda x: x[0])])

            full_yaml_string = OmegaConf.to_yaml(full_yaml)
            print('-' * 30)
            print(full_yaml_string)
            inp = input('Do you wish to continue?(Y/N)')
            if inp == 'Y':
                with open(f'./datasets/{dataset}/README.md', 'w') as f:
                    f.write('---\n')
                    f.write(full_yaml_string)
                    f.write('---')
                    f.write(rest_text)
            else:
                break

Note that the lower-bound is inclusive. I'm unsure if this is how it is done in the tagging app.
EDIT:
It would be great if there was a way to make the task categories consistent too. For this, the streamlit app can look into all the datasets and check for existing categories and show them in the list. This may add some consistency.
EDIT:
I understand this will not work for cases where only the infos for some of the configs are present, for example: ccaligned_multingual has only 5 out of several configs present, and infos has only information about them.  Hence, I have skipped a few datasets in the code, if there are more such datasets, then I'll ignore them too.

It would be great if there was a way to make the task categories consistent too. For this, the streamlit app can look into all the datasets and check for existing categories and show them in the list. This may add some consistency.

We can also update the task lists here: https://github.com/huggingface/datasets-tagging/blob/main/task_set.json

Hi @lhoestq,
Thanks for approving.
How do I add the new categories to the tagging app? What I have added is till 1T and not 1M.
I'll also check the task list :)
Thanks,
Gunjan

I think you can change it here: https://github.com/huggingface/datasets-tagging/blob/main/tagging_app.py#L412-L423

Hi @lhoestq,
I have made a PR for size categories.
For tags, I have thought of adding more tags and categories, based on what I know about the existing datasets, any list will not be exhaustive because the contributors can be very specific or very general. Hence, there could be a continuous process of evaluating existing tags and adding more and more.
{
    "image-classification": {
        "description": "image classification tasks",
        "options": [
            "other"
        ]
    },
    "conditional-text-generation": {
        "description": "data-to-text and text transduction tasks such as translation or summarization",
        "options": [
            "machine-translation",
            "sentence-splitting-fusion",
            "extractive-and-abstractive-summarization",
            "abstractive-summarization",
            "extractive-summarization",
            "multi-document-summarization",
            "table-to-text",
            "text-simplification",
            "explanation-generation",
            "code-generation",
            "stuctured-to-text",
            "other"
        ]
    },
    "conditional-speech-generation": {
        "description": "speech generation tasks tasks",
        "options": [
            "text-to-speech",
            "speech-translation",
            "other"
        ]
    },
    "question-answering": {
        "description": "question answering tasks",
        "options": [
            "open-domain-qa",
            "closed-domain-qa",
            "multiple-choice-qa",
            "extractive-qa",
            "abstractive-qa",
            "conversational-qa",
            "multi-document-qa",
            "other"
        ]
    },
    "speech-classification": {
        "description": "speech to label tasks",
        "options": [
            "other"
        ]
    },
    "sequence-modeling": {
        "description": "such as language, speech or dialogue modeling",
        "options": [
            "dialogue-modeling",
            "language-modeling",
            "speech-modeling",
            "multi-turn",
            "slot-filling",
            "other"
        ]
    },
    "speech-recognition": {
        "description": "speech to text tasks",
        "options": [
            "automatic-speech-recognition",
            "other"
        ]
    },
    "structure-prediction": {
        "description": "predicting structural properties of the text, such as syntax",
        "options": [
            "coreference-resolution",
            "named-entity-recognition",
            "part-of-speech-tagging",
            "parsing",
            "sentence-segmentation",
            "single-span-prediction",
            "multi-span-prediction",
            "clause-or-phrase-segmentation",
            "dependency-parsing",
            "constituency-parsing",
            "other"
        ]
    },
    "text-classification": {
        "description": "predicting a class index or boolean value",
        "options": [
            "acceptability-classification",
            "entity-linking-classification",
            "relation-extraction",
            "common-sense-reasoning",
            "fact-checking",
            "intent-classification",
            "multi-class-classification",
            "multi-label-classification",
            "natural-language-inference",
            "semantic-similarity-classification",
            "sentiment-classification",
            "topic-classification",
            "emotion-classification",
            "token-classification",
            "word-sense-disambiguation",
            "offense-classification",
            "hate-speech-classification",
            "language-classification",
            "bias-classification",
            "other"
        ]
    },
    "text-retrieval": {
        "description": "information or text retrieval tasks",
        "options": [
            "document-retrieval",
            "utterance-retrieval",
            "entity-linking-retrieval",
            "fact-checking-retrieval",
            "knowledge-graph-mining",
            "other"
        ]
    },
    "text-scoring": {
        "description": "text scoring tasks, predicting a real valued score for some text",
        "options": [
            "semantic-similarity-scoring",
            "sentiment-scoring",
            "other"
        ]
    },
    "other": {
        "description": "raw data or other task families",
        "options": [
            "data-mining",
            "raw-text",
            "raw-speech",
            "raw-image",
            "other"
        ]
    }
}

Now, I'll sort this, change categories according to this if this sheets okay to you.
I'll also fix spelling others, and some categories which are partially correct, for e.g. other-machine-translation to the correct tag.
Lastly, with the options also we can add a description to make it easier for the users to understand what we mean by each option. Example, for "emotion-classification", we can explain what kinds of data we are talking about, or "single-span-prediction", etc.

Good idea thank you ! Can you open a PR on datasets-tagging for the tasks as well ?
Also you can update the dataset card with the new tasks categories in another PR if you don't mind

Hi @lhoestq,
Thanks, what all do I need to add to merge this PR?

We can merge this one once the PR on dataset sizes is merged on datasets-tagging ;)

Hi @lhoestq,
One problem with this approach is that for datasets like ccaligned_multilingual, the infos won't be complete because we don't have all configs. In that case, people might face trouble finding the datatset using the tag. Although, they probably won't be checking the size tag for a dataset like that.
What do you think?
CC @theo-m

For datasets like ccaligned_multilingual it's important to have all the tags for users to search and find it. Currently is has the full list of tags (without the config names). So you can actually find the dataset, but you don't know what tag correspond to what configuration.


Improve failure message when text is present but invisible.

When testing a page with JS that hides and shows
certain elements, it's useful to know whether a
test failure means that an element has failed to
render, or has rendered but become invisible (or
failed to become visible).
For instance, some jQuery plugins will take
existing elements and hide them, adding some other
elements onto the page that use the originals as
storage. If your tests are written to use the
now-hidden elements they will mysteriously start
failing.
This commit only changes the behavior for failed
tests (rspec and assert) and only for text
queries. It might be nice to extend this to the
other finders.

+1

I've added a couple of comments, but overall I'm iffy on this.   Yes it would probably be helpful for some people to have this type of error message, but it's also that kind of things that will encourage people to just pass visible: false into their text query to get tests passing -- which is not something that should be encouraged.

I'm not convinced it would encourage people to just pass :all into their text queries just to get their tests to pass. If some people don't care about their tests being accurate then there's not much a reasonable error message can do for them :-). And it's not suggesting any action, just pointing out the (possibly new or changed) reality and giving a clue -- which I would have appreciated when working with some buttons that toggle invisible checkboxes on a codebase I was new on last week.

Just the one small change I commented on above, and then it looks good to me.  when you've made that change please squash the commits, and then I'll merge it in

This was squashed and merged as 51c83ed5a93f7a6f36f27019927d2ee7c4e2d599


getExperimentCrossCorrelation, user's own function supported

Hi,
I added support for user's own function in getExperimentCrossCorrelation.
There are still some things that I want to check, but I started to wonder if we want to create a more general function for this?
Function that

Takes user's function as an input

Must take matrix as an input
Must return numeric values

Applies it to all the feature-pairs

I think this should not be too complicated task because we already have working framework
getExperimentCrossCorrelation with own function
devtools::load_all()

data("GlobalPatterns")

tse <- GlobalPatterns
tse <- tse[1:10,]
getExperimentCrossCorrelation(tse, method = "canberra",
                                        mode = "table",
                                        show_warnings = T,
                                        corr_FUN = stats::dist)

getExperimentCrossCorrelation(tse, method = "bray",,
                              show_warnings = FALSE,
                              mode = "matrix",
                              corr_FUN = vegan::vegdist)

-Tuomas

Now, correlation calculation can also be done sample-wise, I added also paired option
# Paired samples
getExperimentCrossCorrelation(tse, method = "bray",
                              direction = "col",
                              paired = T,
                              show_warnings = FALSE,
                              corr_FUN = vegan::vegdist)

# Unpaired samples
getExperimentCrossCorrelation(tse, method = "bray",
                              direction = "col",
                              paired = F,
                              show_warnings = FALSE,
                              corr_FUN = vegan::vegdist)

# features
getExperimentCrossCorrelation(tse, method = "bray",
                              direction = "row",
                              paired = F,
                              show_warnings = FALSE,
                              corr_FUN = vegan::vegdist)

This is just a draft. The name of direction might be better, I think. There are probably some bugs

And as we discussed, we might want new wrapper for paired samples

Looks good.
corr_FUN is now a misleading name if you apply it to distances (like vegan::vegdist). Because the sign in correlation and distance/dissimilarity is different. If this would allow both similarity and dissimilarity methods, a more suitable name could be association_FUN? Then also the function name should be something like getExperimentCrossAssociation. I think this can be feasible because the function is all about pairwise association, and I am not sure if there is a need, from the perspective of this function, to differentiate by sign. Then there would be no need for distinct correlation and dissimilarity functions.
One possible replacement for direction as the argument name is MARGIN which is used in apply family of functions.

I have been trying to optimize the calculation, because in some point it starts to take too long
I wasn't able to improve looping over feature-pairs which is done when using functions stats::cor.test, and user's own functions
However, stats::cor can take matrices as an input, so that can be improved easily

Some ways to optimize:

make sure to not calculate (symmetric) associations twice (A-B vs. B-A) i.e. just upper (or lower) triangular matrix for corelations
fast & optimized implementations may exist (although would pile up dependencies)
can provide an option to reduce dimensionality: the correlation matrices are often very similar if you calculate them with a small random subset of the features, compared to all features.  Perhaps the user could choose to speed up by selecting a given fraction of features at random.

Done
There are but I did not want to use them

Now we allow also user's own function. However, the input must be in specific format, e.g., function(matrix, matrix) is not allowed.
There are some correlation functions that allow this kind of input, but then again getExperimentCrossAssociation might become too complicated because of different inputs and outputs

Should pass the tests now now if synced with master.

Now this is allows user to use own function
Option for paired samples --> only associations between pairs are calculated
When association between two identical assays is measured, association is calculated for only unique variable pairs (feature1 vs feature2 --> values are assigned to other half of variable pairs (e.g. feature2 vs feature1)

We have new dependency: reshape2. I tried tidyverse alternatives but it turned out that they were just too slow (all gained advantage was lost)
Now calculation is significantly quicker

When correlation is calculated without p-values, it is done with stats::cor-function which does it very efficiently

Overall looks very useful. Could we add an example about with a function defined by the user, for instance how to do this with vegan::vegdist ?

That's a good point. If we are able to choose, I would keep data.table due to its remarkable speed benefits. But tidyverse is so pervasive that it might be difficult to avoid.

@TuomasBorman please remove the data.table dependency. Thanks!

Btw. any estimate how much this will slow down the methods? Might be critical for larger data sets.

If we want to speed up calculation when correlation between same assays is measured, we need to use other than tidyverse. I found out that it was very slow with this implementation; almost useless

This sometimes means one has to take step back and have a look where the slowdown is happening.
Usually this leads to a better overall implementation because one trips over weird code implemented by oneself. Talking from experience.

data.table has been specifically optimized speed in mind. If the implementation itself cannot be easily changed (good to check though), and the remarkable improvement mentioned by Tuomas is easily achieved by just changing the package that does melt/cast, then one option is to create another package that focuses on multi-table utilities. Indeed the speed can be a critical issue here as soon as the data sizes increase. Support should be provided also for larger studies if it is easy and feasible to arrange.

I added there random_sample option. This takes a random sample size of a random_sample from the data
@antagomir I guess that was what you meant?

Biggest changes in this PR

User can give own function
If correlation is calculated without p-values --> cor()
paired option
show_warnings was not working correctly in all cases
random_sample option
symmetric option --> only half of the variable pairs are calculated
direction option (is MARGIN better name?)
getExperimentCrossCorrelation --> getExperimentCrossAssociation

I'm ok with both names, but maybe MARGIN would be better
I removed random_sample. It's quite easily done, so it unnecessary as you said

Yess - the random sample option could be in examples, at least if it can lead to considerable speedups.

This is starting to be quite ready, howver one thing came into my mind
Currently sorting is disabled when mode == "table". However, it is possible to store orders as a factor levels. We should probably consider to enable  sorting also in table mode.

I agree, it would be good to add that as an option (and example so it is clear).

This one... There are lots of changes and all should work. I think this is ready

There seems to be one more "Changes requested" from FE. Is that solved, can it be ignored or not?

I have confirmed with @TuomasBorman that this long-pending PR is ready to be merged.


BigInt crashes frontend with TypeError: BigInt value can't be serialized in JSON.

Thanks for this library! It's great for productivity - I'm just getting started.
I get an error in the browser when the API returns an object that contains a BigInt. For example, the JSON looks like:
[{"result":{"data":{"json":[{"id":"bob","createdAt":{"seconds":"1680535620","nanos":737587000}}],"meta":{"values":{"0.createdAt.seconds":["bigint"]}}}}}]

I'm using superjson. It looks like both superjson and trpc-panel are documented to support BigInt. However, returning BigInt causes the app to go into a full white screen.
Do you know what I can try to fix this?
Thanks 🙏

makes sense that this is happening, the return value of the procedure gets passed to JSON.stringify(). Definitely want to fix this, will need to use something else for converting the response into a string.
thanks!

should be fixed in new version

Thanks a lot! 🙏


feat(config): deny unitialized data_directory and state_store

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
To support mandatory initialization of a system parameter, developers can specify None as the default value in the params declaration macro (for_all_undeprecated_params). Then we can utilize system_params_to_kv invoked when the cluster is started for the first time to check for uninitialized params.
ALTER SYSTEM SET data_directory/state_store = DEFAULT; will also result in an error (though the semantic is wrong as discussed in #8851):
SystemParams error: data_directory does not have a default value

Closes #9153
Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[x] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
RisingWave cluster configuration changes

Release note
--data_directory and --state_store must be specified on CLI of the meta node, or the cluster will fail to start.

@huangjw806 We might want to update the docs about system params.
/// Macro input is { field identifier, type, default value }
///
/// Note:
/// - Having `None` as default value means the parameter must be initialized.
macro_rules! for_all_undeprecated_params {
    ($macro:ident
        $(, { $field:ident, $type:ty, $default:expr })*) => {
        $macro! {
            { barrier_interval_ms, u32, Some(1000_u32) },
            { checkpoint_frequency, u64, Some(10_u64) },
            { sstable_size_mb, u32, Some(256_u32) },
            { block_size_kb, u32, Some(64_u32) },
            { bloom_false_positive, f64, Some(0.001_f64) },
            { state_store, String, None },
            { data_directory, String, None },
            { backup_storage_url, String, Some("memory".to_string()) },
            { backup_storage_directory, String, Some("backup".to_string()) },
            { telemetry_enabled, bool, Some(true) },
            $({ $field, $type, $default },)*
        }
    };
}

The third column's value being None means that the corresponding parameter must be specified from CLI.

@arkbriar  Please confirm whether the operator needs to be changed synchronously, thank you!

Please confirm whether the operator needs to be changed synchronously, thank you!

Sure. AFAIK, the operator should work without any change.


'Handle bins' functionality returns 503 error

This issue is to report that the 'handle bins' functionality returns 503 error with incorrect feature (typo) as input, but responds as expected with correct feature as input. The issue was identified with the ICEES Asthma development instance, but applies more globally.

Closing ticket, as issue has been resolved.


[WIP] Give reasons for resolving group (#3008)

This is a work in progress to discuss whether this is detailed enough, and a few questions I have about the code.

This addresses #3008 opened by @mavnn.
I have "surfaced" the information about specific changes that cause the resolver to be run for a group, and when that decision is made, every single individual reason for resolving is listed.
One question is what the desired amount of detail for the different cases is. Currently

all the different NuGet changes are listed individually; if there are multiple changes for a single package, all of them will be listed
if the framework restriction for a group changes, every single package will also be listed as having a framework restriction change; that probably doesn't make much sense
remote file changes will say "Remote file x changed in project y"
settings changes will only say "Group has settings changes"

Is there anything that should have more or less detail?
Ignore the individual commits and changes to files other than DependencyChangeDetection.fs and UpdateProcess.fs; I will rebase and clean those up later.


(ci) pin openai version

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Try to see if pinning the version fixes failing test

Closing this as the underlying issue was not tied to a specific version.
https://community.openai.com/t/intermittent-error-an-unexpected-error-occurred-error-code-400-error-message-this-model-does-not-support-specifying-dimensions-type-invalid-request-error-param-none-code-none/955807/16


document creating a database snapshot

@plorenz Should we mention which POSIX perms are required to send a command to the IPC agent? I didn't see any Unix domain sockets for the controller process, so I'm curious how that works.

I'll change this guide to focus on backing up the controller with the ziti edge db snapshot (via REST API) command, and to remove the mentions of the IPC method, because it's too confusing to promote both alternatives.

@dovholuknf I completed the change we discussed to focus this short guide on backing up the controller db with the edge snapshot operation.


FD_ISSET: take a *const fd_set instead of *mut fd_set

FD_ISSET does not modify its fd_set argument, so it may as well take a
const pointer.  AFAICT the only reason to take a *mut pointer is because
the Linux man page documents it that way (though since glibc implements
it as a macro, the constedness is undefined).  But since libc implements
it directly rather than calling a (nonexistent on most platforms) C
function, we're defining the API ourselves.

r? @JohnTitor
(rust_highfive has picked a reviewer for you, use r? to override)

While I was researching my nix PR, I came across this page about the const-ness of that argument. I'm not enough of an OS expert to opine on whether the arguments are convincing, but thought I'd pass along in case it's useful.

Uhm, it's reasonable indeed but I'd prefer as-is since it may cause some confusion by difference with the original definition.

By "original definition" do you mean existing versions of libc, or what's documented in C libraries?  AFAIK the only place in C that describes the pointer as mutable is in some man pages.  But that's a misnomer since the function is really a macro, and its arguments don't have constedness.  And some operating systems document FD_ISSET as it really is: as a macro.  So I don't think we should feel bound by any constedness described in some OS's man pages.

Fair enough, but on the other hand, it makes the current signature stricter, I think we shouldn't do that without any strong reason or announcement.

Apparently libc does not object to changing the signatures of other functions, even when that causes downstream breakage.  Since that's the case, why not merge this PR?
https://github.com/rust-lang/libc/pull/1891

:umbrella: The latest upstream changes (presumably #1975) made this pull request unmergeable. Please resolve the merge conflicts.

Triage: Re-visiting, I still, however, don't see much motivation for this.
@rust-lang/libc Do y'all have any thoughts on it?

The motivation is const-correctness.  Right now for example, Nix forces users to use a mutable reference in a place where an immutable reference should suffice, just because libc defines FD_ISSET wrongly.
https://docs.rs/nix/0.22.0/nix/sys/select/struct.FdSet.html#method.contains

A *mut will coerce to a *const, so this will most likely not break anything. Also I would agree with @asomers that *const is the correct type to use here.

Thanks for clarifying both!
@Amanieu I'm unfamiliar with this, so feel free to r=you if it makes sense to you.

@bors r+

:pushpin: Commit 3eafb3b0b937f7afd5d1ef1e65e81c1648225788 has been approved by Amanieu

:hourglass: Testing commit 3eafb3b0b937f7afd5d1ef1e65e81c1648225788 with merge 4a53e6dc11ddbd41a7515ad05913fbb78bfc6e09...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 4a53e6dc11ddbd41a7515ad05913fbb78bfc6e09 to master...


build: remove codecov from project

This PR removes the codecov tool from the project due to security vulnerabilities

:tada: This PR is included in version 3.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


HTML

Add HTML for a navigation bar, about section, work section, and contact footer

Add HTML code and file to repository.


Templates section button does not trigger events for closing or opening previous tabs

Describe the bug
Unlike the events visualizer button, clicking on the new templates button opens a new view that covers the whole studio (except the nav bar). When clicking then on any other button like the code one , doesn't quit the examples view.
The only way to close it is to click again on the same examples button, which is not a 100% expected behavior because it is quite inconsistent with the rest.
How to Reproduce
See the following video:
https://user-images.githubusercontent.com/1083296/144412090-a9f801b4-171d-4848-b17a-ec54f90cb8fd.mp4
Expected behavior
Either examples view shows as a popup, or either just as a side view (as the events visualizer, code examples, etc), or we improve the navigation so on any click in any button will close the examples view.

Either examples view shows as a popup, or either just as a side view (as the events visualizer, code examples, etc), or we improve the navigation so on any click in any button will close the examples view.

The question is which would be better? From a UX standpoint, I think modal, @mcturco @boyney123 any thoughts? 🤔

@magicmatatjahu Agreed! I think a modal for the new templates will work just fine. So then the modal should close if you click a different nav item on the left side, as @smoya pointed out, good catch!

Nope, no close by clicking on the nav item. It will be similar to normal modal like:

But content will be templates :) And then you cannot click on the nav - you can try.

@magicmatatjahu Oh! Gotcha. Yes that works too!

Yeah modal sounds good to me! Nice catch @smoya

I can try and pick this up 👍

Think it's fixed in #201

Fixed in the https://github.com/asyncapi/studio/pull/201


Make execute(sql) static.

When invoke for each individual SQL statement, the current check for update vs. query is done against the whole SQL statement. Given H2Statement supports compound statements, it should instead be checked against each individual statement.
This suggests that making the operational execute method static would avoid such leakage in the future.
Resolves #10.

@nebhale If you could export your IntelliJ settings and import order (see https://github.com/r2dbc/r2dbc-spi/issues/15), then we could avoid this barrage of import deltas happening on PRs.


Acronym Form

This is a very minor nitpick.
When acronyms are written, we usually see them as “The Thing We're Referring To (TTWR),” but you've commonly used “TTWR (The Thing We're Referring To)” but also used the former. It might be good to make sure it's consistent throughout the document.
The only one I remember being the former is in the introductory paragraph where you mentioned SEM.

Good catch!


Only require lodash modules used by the package

Tests are passing 100%
Closes #1

One little idea. Given we're using webpack-merge only in Node.js context perhaps we should just use Array.isArray and drop the lodash specific one? What do you think?

Thanks!


API sync

Shouldn't we send the app friendly name as well for more readable reporting?
Should we send the frame drops as well as the total played frames? The motivation is that during a painful live stream event we had a lot of dropped frames.
Discuss naming conventions (see https://github.com/SRGSSR/pillarbox-documentation/pull/96#pullrequestreview-2275519332)

App friendly name: Not useful, we can add a mapping on Grafana.


Github actions

This PR adds automation to docker image building and pushing to Dockerhub by:

Adding the docker-image.yml workflow under the .github/workflows directory
Moving the relevant Dockerfile from the Dockerfiles directory to the root of the project
Configuring the workflow so that it

Triggers on a push to any branch where Dockerfile has been modified
Builds the image of the modified Dockerfile
Logs in to Docker Hub using ATG-FAS service account credentials
Tags the built image with harvardat/BRANCH_NAME:COMMIT_HASH and harvardat/BRANCH_NAME:latest
Pushes the image to Docker Hub

Considerations
First, in order for the workflow to work there needs to be a Dockerfile in the root of the project. Since there seems to be only one Dockerfile that is actually associated with the branch kept in the Dockerfiles directory, I figured it would be ok to simply delete that directory and move the Dockerfile to the root of the project.
Second, it means that the Dockerfile committed to the branch is no longer just for documentation
Last, it means that the branch name now carries significance in the name of the image. It may be worth considering what branch naming convention would could settle on that will also work for harvardat image repositories. If we settle on a useful naming convention, I'll it add to the readme for reference.
Notes
If this PR is accepted, I'll have an identical change to the rstudio repo.

@arthurian - Yes, I totally agree about the prefixing the application type in the image tag. I had originally included that, but removed it for no good reason. Thanks for the other suggestions; I'll make those updates!

LGTM


[BUG] Live upgrade fails for volume if replica instance manager pod was deleted and recreated before longhorn upgrade.

Describe the bug
Live upgrade from longhorn v1.0.2 to the master fails for a volume if the replica instance manager was deleted and recreated before longhorn upgrade.
To Reproduce
Steps to reproduce the behavior:

Deploy longhorn v1.0.2 in a set up of 4 nodes (1 etcd/control plane, 3 workers)
Create a volume with 3 replicas. Write some data into it.
Delete instance-manager-r pod from node 1. This will cause the replica on node 1 fails and once instance-manager-r pod is recreated, Another replica will get created.
Upgrade longhorn to master.
Do the live upgrade of the volume.
Upgrade fails. The replica created with the new instance-manger doesn't come up healthy.

Expected behavior
The upgrade should succeed.
Log
longhorn-support-bundle_56d2ae1f-daa6-4286-a8c0-0cd186f88b37_2020-11-12T01-01-50Z.zip
[longhorn-manager-5bnpc] time="2020-11-12T01:12:57Z" level=debug msg="Volume healthy replica counts doesn't match" controller=longhorn-volume frontend=blockdev node=khush-test-upgrade-wk2 owner=khush-test-upgrade-wk2 state=attached volume=pvc-cc231536-2402-4b87-96ea-47c4d8748852
[longhorn-manager-5bnpc] time="2020-11-12T01:12:57Z" level=debug msg="Volume healthy replica counts doesn't match" controller=longhorn-volume frontend=blockdev node=khush-test-upgrade-wk2 owner=khush-test-upgrade-wk2 state=attached volume=pvc-cc231536-2402-4b87-96ea-47c4d8748852

Environment:

Longhorn version: longhorn-master - 11/11/2020
Kubernetes version: v1.18.10
Node OS type and version: 18.04

Additional context
Initially longhorn was installed using the rancher app and upgraded it using kubectl command.

The root cause of this issue:

When the old instance manger pod is deleted and Longhorn hasn't relaunch instances in the corresponding new instance manager pod, Longhorn system is updated.
At this moment, the old instance manager CR will be cleaned up due to no instances running in it. Then the rebuilding replica will get stuck there.

2020-11-12T00:52:25.907870266Z time="2020-11-12T00:52:25Z" level=warning msg="Error syncing Longhorn replica longhorn-system/pvc-cc231536-2402-4b87-96ea-47c4d8748852-r-196cc646: fail to sync replica for longhorn-system/pvc-cc231536-2402-4b87-96ea-47c4d8748852-r-196cc646: failed to get instance manager for instance pvc-cc231536-2402-4b87-96ea-47c4d8748852-r-196cc646: can not find the only available instance manager for instance pvc-cc231536-2402-4b87-96ea-47c4d8748852-r-196cc646, node khush-test-upgrade-wk1, instance manager image longhornio/longhorn-instance-manager:v1_20201021, type replica"
2020-11-12T00:52:25.908024773Z time="2020-11-12T00:52:25Z" level=warning msg="Error syncing Longhorn replica longhorn-system/pvc-53bc19b8-1c5a-4403-b785-2b9ad5a40083-r-6fce8fa2: fail to sync replica for longhorn-system/pvc-53bc19b8-1c5a-4403-b785-2b9ad5a40083-r-6fce8fa2: failed to get instance manager for instance pvc-53bc19b8-1c5a-4403-b785-2b9ad5a40083-r-6fce8fa2: can not find the only available instance manager for instance pvc-53bc19b8-1c5a-4403-b785-2b9ad5a40083-r-6fce8fa2, node khush-test-upgrade-wk1, instance manager image longhornio/longhorn-instance-manager:v1_20201021, type replica"

Since there is an old replica get stuck in rebuilding state, the live upgrade will keep error out.

2020-11-12T00:55:14.112419317Z time="2020-11-12T00:55:14Z" level=debug msg="Volume healthy replica counts doesn't match" controller=longhorn-volume frontend=blockdev node=khush-test-upgrade-wk2 owner=khush-test-upgrade-wk2 state=attached volume=pvc-cc231536-2402-4b87-96ea-47c4d8748852

Test steps:

Deploy Longhorn v1.0.2
Create and attach a volume
Upgrade Longhorn to master
Delete one replica manager pod. And do live upgrade for the volume before the new replica is created.
Check if Longhorn can reuse the failed replicas and complete the live upgrade

Hmm? Is the fix for #1118 a pre-requirement for this fix? But you also suggested that we don't need to add more fix to #1118. I am confused.

The upgrade is by design disabled during the rebuild process. It should allow the user to finish the rebuild first, then complete the upgrade process. Is it OK to create a new replica instance manager (new version) for this rebuild? or we have to create a replica instance manager with the old version.

@khushboo-rancher Can you check if you can reproduce the case you provide? More accurately, how do you guarantee:

there is 1 stopped old replica + 2 running old replicas
the live upgrade is blocked even if the volume is healthy without error replica.

I tried reproducing the case which I've mentioned but couldn't reproduce because of the merged code I think. I was seeing the issue on upgrading Longhorn v1.0.2 to longhorn Master dated 11/11/2020 with a set up of 4 Nodes (1 etcd/control plane and 3 worker)
However, to have 1 stopped old replica + 2 running old replicas before upgrade, we can follow the below steps.

Have a set up of Longhorn v1.0.2 and a volume created.
Delete instance-r-manager on a node which is not attached to the volume.
On deletion of the instance-r-manager the replica will go to stopped state and a new replica will be rebuilt.
Reduce the replica count to 2 and delete the newly created replica.
Upgrade the set up.

The live upgrade is blocked even if the volume is healthy without error replica.

I didn't see any problem in upgrade in case of healthy replica.
@shuo-wu Does the above answer your question?

Yes. There will be a stopped replica (with spec.FailedAt set) based on the steps you provide. But the error failed to get instance manager for instance is not triggered. Let's ignore #1118 unless we can find a way to reproduce it in the future.

Verified with longhorn master 12/10/2020
Validation - Pass
The live upgrade worked fine in case the instance-manager-r was deleted and recreated before longhorn upgrade. Tried it 3 times.


new next release to includes new Adapter API

next-auth has relased it's beta 4.0.0-beta.1 which uses the new Adapter API, we also need a beta/next release to support it. the current version 0.5.4 does not.

Which adapter are you talking about?

it is prisma. Thanks for the quick response!


Question: axios in React lifecycle

I love your project and have been using it for a while to look for examples. I've just been wondering how the axios instance and interceptors work with React in the way they are implemented now.
I suppose the instance is created once you reload the page and then it gets the token from the store. But what if there is no token at that time? What happens when the token changes during usage of the application? I implemented the axios instance according to bulletproof-react in one of my projects and have the issue that the axios instance is not refreshed after the user logs in (token change).
How does the example work here? Or do we need to put the axios instance in a React hook which can change the values?
Thanks in advance for some clarity 🙏

Maybe putting axios and the interceptors in a React context? Like it is done in this article?

Hey @s1gr1d ,
I am curious, why do you need React to track your tokens?
If the token needs to be refreshed, that should be done in the background without involving React in the process. For that, you can try https://github.com/Flyrell/axios-auth-refresh which allows refreshing tokens within interceptors.

@alan2207 what about auth0 where you have a hook called useAuth0 which exposes a function getTokenSilently which is async 🤔
So in that case I need axios to be inside the react context to being able to inject the token into an interceptor.
In our case we use something like this:
export const ApiClientProvider: FC<PropsWithChildren> = ({ children }) => {
  const { getAccessTokenSilently } = useAuth0();
  const { API_URL } = useEnvContext();

  const value = useMemo(() => {
    const instance = axios.create({
      baseURL: API_URL,
    });

    instance.interceptors.request.use(async (config) => {
      const token = await getAccessTokenSilently();
      config.headers = {
        ...config.headers,
        Authorization: `Bearer ${token}`,
        'Content-Type': 'application/json',
      };
      return config;
    });

    return { apiClient: instance };
  }, [getAccessTokenSilently, API_URL]);

  return <ApiClientContext.Provider value={value}>{children}</ApiClientContext.Provider>;
};

Well it depends on how you get token and store in the browser.
Usually we get token from POST login request.
So I don't think we have to take care of token is changed. maybe user is changed or user manipulates token value on purpose.
We can navigate back to login page and make user re-login again I reckon.


Refactoring Footer&Get_Involved component

Refactoring the Footer & Get_involved as per the proposed style.
Note- Please make sure to follow all the guidelines mentioned in the proposed style properly!

i want to work on this
will submit PR the within 2 days after assignment

@Kajol-Kumari I would Like to work on this.

completed all 3 refactoring PRs. please assign me this issue.
Will submit PR on the same day when assigned

@Kajol-Kumari I would Like to work on this.

@sanjay270899 please go ahead with this issue
Happy Learning :)

@sanjay270899 can you please confirm once if you are working on this issue?

@Kajol-Kumari Yes, I am working on it. Just scss is left.

@Kajol-Kumari Done.


Request for enhancement: combined chart(BarChart (grouped DataSets) and linechart)

Hi I have seen BarChart (grouped DataSets) and Combined-Chart (bar- and linechart). But is there any possible way to do combined chart(BarChart (grouped DataSets) and linechart). Please comment your thoughts. Thanks in advance.

this is known already. I had a PR https://github.com/danielgindi/ios-charts/pull/269 for this. You could try my branch. This is a huge work and daniel does not have time to review yet.


Download location list selection

Describe the solution you'd like
The download location can be selected from the locations of existing tasks
Additional context

If this is just a dropdown of all save locations, then it's certainly doable. This Web UI actually allows you to explore a pseudo "file system" of all downloaded torrents, not sure if that's helpful here.
@Csineneo Also, which Web UI are you currently using? It would be helpful to know so I can better understand the feature requests.

If this is just a dropdown of all save locations, then it's certainly doable

Yes.

which Web UI are you currently using?

It's transmission web control.
Transmission is not stable enough and there are some performance issue. I have been considering switching to to qbittorrent but the ugly webui stopped me until I found yours.


How to obtain training data

hi,
in data_collection script (https://github.com/automl/nas_benchmarks/blob/master/data_collection/train_fcnet.py),  data file "%s_train_data.npy" is specific, but how to obtain these data file?

Hi, wondering about the same as @TQCAI ,
is it possible to retrieve these data @aaronkl ?


OCPBUGS-1995: Drop descheduler operand resource limits

With measurements provided from one of our descheduler contributors the memory consumption of the descheduler in a big cluster can grow over 1.5GB. The same observation holds for the kube-scheduler which has no resource limits defined. Comparing graphs of memory consuption of both the descheduler and the kube-scheduler shows a very similar pattern.

/jira refresh

/lgtm

/approve


Mac M1 doesn't support onnx files

I think this can be solved using conda-forge.
conda install -c conda-forge onnxruntime
I'm using it and it works well.


CM-873 User loses feed with refresh

Tested with an icognito window in Google Chrome and confirmed behavior is fixed locally.

@johols Please confirm this works for you.
@y-himanen @SabineU The two email tests for the expired Token have strange behavior. Locally, the endpoint returns a 422 error for an Invalid Token. However on CircleCI the test returns a 401 code for an Expired Token as expected.
Both errors are fine as far as I'm concerned, but it would be nice if the test could somehow pass in both enviornments. Any idea why it would differ between these two environments?


Atom migrated to using customElements from document.registerElement. Due

Atom migrated to using customElements from document.registerElement. Due
to this move, now there is need to attach some elements to the DOM on
some specs.
オリジナルは @sadick254 が https://github.com/atom/tree-view/pull/1392 にポスト

What are you talking about?


@page collection does include modular pages

Playing around with more advance collections today revealed that when iterating over @page collections that they do include _modular pages as well which they shouldn't.
Using Xdebug I saw that the init method of the _modular page is called and the modular_twig flag set correctly to true at the beginning when the page tree is built.
However when later the collection is generated in the evaluate() method the $pages variable derived from $pages = self::getGrav()['pages']
contains the very same _modular page as instance but with modular_twig flag set to null which results that page included in the collection.

Ok i've investigated this a bit, and i'm not seeing what you are seeing.  After this is processed:
$results = $pages->all($page)->nonModular()->published();

The results do not contain any modular pages.  Now by that i mean pages that the results don't any of the modular sub-pages that constitute a single 'modular.md page.  They do contain the top level modular.md page.
Confusing naming I know! But hope that makes sense.  Here's a screenshot of my debugger:

Notice the /modular page is there as is a regular /modular/random page.  but none of the _showcase, _features modular subpages are in the results.
This is as expected.

If I wouldn't have kept log files from yesterday I would not believe it did happen myself. Today the issue vanished mysteriously after I tried to replicate this with a standard Grav install and now my dev site is OK as well. Maybe there was something still lurking in the cache which triggered this,
Sorry for the stir-up. I will be a bit more cautious with future reports and make always sure to replicate it with cleared cache.

No problem, I actually like potential issues to be raised, it gives me the chance to double check things :)


Pane arrow directional

zeit#828

fixed by hyper-pane, btw

Yes, but the redesign allow it by KeyMap

hyper-pane will be adapted to this redesign or totally deprecated.


Initialize CUDA driver API before using it

Looks like there were some changes in the CUDA driver API that is affecting our GPU tensor support.

Same on copyright and I have same question as Tanmay, do we have a test to catch API changes? otherwise LGTM!

do we have a test to catch API changes?

We do have a test for GPU tensors but for this bug it seems like something has changed in the CuPy/CUDA side. We should call cuInit before using any driver API.

I think we also need to change the copyright in src/pb_tensor.cc as well.


Update whitepaper-powerbi-security.md

Minor change to remove reference to dataflows and paginated reports as premium-only features, since these are both now available in pro (shared capacity)

@paulinbar
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Maximum number of Arguments Supported by a Keyword

Is there any limit for the maximum number of Arguments that a Keyword can take, that comes from a Variable File?
I'm asking this because I found issues trying to run a keyword that takes more than 5 Arguments from a variable file.

No there isn't.
Please send questions to robotframework-users mailing list, to Slack channels, or other such support forums. This tracker is for bug reports and enhancement requests.