Remove-AzsVMImage silently fails to remove gallery item from marketplace

Hi,
I found that Remove-AzsVMImage does not remove the gallery image from the marketplace.  I found the following line of code ComputeAdmin/AzureStack.ComputeAdmin.psm1#L387:
`Get-AzsGalleryItem | Where-Object {$_.Name **-contains** "$publisher.$name.$version"} | Remove-AzsGalleryItem `

-contains should be -like in this case.  This works in my case, but not if it is the correct fix.
Another thing the code should probably should check it actually deleted an item as Remove-AszGalleryItem will not complain there is no object piped to it.

This cmdlet has been moved to Azs.Compute.Admin module. Closing this issue.


打开后图片会重复出现，视频播放卡顿

目前测试的机器是 Quest3。通过 sidequest导入个人的 3D 资源后，所有内容都会重复显示（包括自带的那几张图片）。而且测试了一个 200M 的 3d 视频，目前几乎无法播放，卡帧严重。

是用的最新版本吗？看看文件夹里的文件有没有重复？大视频确实可能卡顿

是用的最新版本吗？看看文件夹里的文件有没有重复？大视频确实可能卡顿

看过文件夹，并没有重复的文件。刚刚我退出去再进入应用，问题已经消失。多谢你了，这个 app 很棒。

Version 0.2 has made great progress. I tried to play some videos, but found that there would be lags. The higher the frame rate, the more serious the lags. At the same time, I found that the CPU level of the software is very high. Is the current image algorithm mainly relying on the CPU? Sharing the two videos I used for testing, I hope they will be helpful.
https://drive.google.com/drive/folders/1EyiiFgUiRW3Bmm0ihOuEQmggSiwUiSJC?usp=sharing

Version 0.2 has made great progress. I tried to play some videos, but found that there would be lags. The higher the frame rate, the more serious the lags. At the same time, I found that the CPU level of the software is very high. Is the current image algorithm mainly relying on the CPU? Sharing the two videos I used for testing, I hope they will be helpful.

Yes, I'm so sorry for that. I use the Videoplayer component of Unity, which is very inefficient, and I can't find a better free solution at the moment.

Ijkplayer、ExoPlayer、VLC，应该都是开源的吧，好似Pico的本地播放器用的是ijk

VLC

好的谢谢，但是涉及到安卓层的东西我就不太懂了😂


[Feature]: Coinselection Autopilot (beignet)

See https://github.com/synonymdev/bitkit/issues/1749
Implement autopilot in beignet and add tests.

I'm thinking about trying this one

I've been experimenting with the @bitcoinerlab/coinselect library, and it works well overall. You can check out my draft PR for details.
However, I just discovered that @bitcoinerlab/descriptors doesn't currently support Taproot. There is an open PR addressing this, but it hasn’t been merged yet.
In hindsight, I think I might have been better off trying a different approach—porting the coin selection algorithms directly into Beignet.

bitcoinerlab author here. Do you need full TR with miniscript support or just standard taproot addresses?


Add apigate proxy response

Add Definitions for Api Gateway Custom Authorizer request and response

More detail

http://docs.aws.amazon.com/apigateway/latest/developerguide/use-custom-authorizer.html

@lsuss addressed all comments, I will add another one for adding response in apigatewayproxyevt, and found one typo in the apigatewayproxyevt, so that will be corrected as well.

One last thing I just noticed now sry.
Please add README.md for apigatewayauthorizerevt  (check other events). And Update the main README.md to add link to your new supported event.
You did a great work btw :+1: you are the very first to help us by adding an event type so it's a special moment for us you know :sunglasses:.


Bug? IndexError: list index out of range

Hello,
Thanks for developing hint, the paper is super interesting! I tried to identify translocations for 12 samples, 6 completed successfully and for 6 of them I am getting the following one of these error messages:
IndexError: list index out of range
IndexError: index 1125 is out of bounds for axis 0 with size 592

I'm also attaching the complete log files that end up in these errors.
Would you have any advice on how to fix this?
Thanks!
Alejandro
Job_806491.txt
Job_806495.txt

Hi, I I had the same problem that with the output 'IndexError: list index out of range
IndexError: index 658 is out of bounds for axis 0 with size 468'。 Have you solved the problem？


Add mandatory ownerEmail json property in example doc

In Create workflow definition JSON example mandatory ownerEmail property is missing

@kishorebanala @apanicker-nflx could you please review this PR for #1904
issue (minor improvement in docs)

Pull Request Test Coverage Report for Build 4613

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.565%

Totals

Change from base Build 4600:
0.0%

Covered Lines:
12857

Relevant Lines:
18482

💛  - Coveralls


Issues with updating my aws_appsync_apiKey

How did you install the Amplify CLI?
npm install -g @aws-amplify/cli
If applicable, what version of Node.js are you using?
v20.12.1
Amplify CLI Version
12.12.3
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
I did not make any changes to the cloud resources in any way at the moment. However, when trying to debug, I tried creating a new API_key in the App_Sync console but because it still did not work, I deleted the key and the cloud resources are currently unchanged.
Describe the bug
My exports file contains an API_key which is not being shown in the App_sync console (The console has no API_key at all !). I tried most solutions provided from previous issues opened but none worked hence opening a new one.
When I create a new API_key and try to push the changes, I receive an error that api_key not found and the key being referenced is the one that does not exist in my App_sync console but only shows in my exports file.
Running "amplify update api" closes without creating a new key as well !
Expected behavior
I am expecting to find a way in which I can create a new API_key that can then remove my 401 error when accessing backend data from amplify
Reproduction steps

amplify update api
Run necessary processes
amplify push

Project Identifier
Project Identifier: 1d7a661e2d7173d4f67a35b3860f5214
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hi @IsaacHarrison28, Thanks for raising this.  This issue seems to be duplicate of #636. Can you please try the steps mentioned here: https://github.com/aws-amplify/amplify-category-api/issues/636#issuecomment-1288164584 and let us know if it resolves your issue?


Doc: Expand on intro

Coverage remained the same at 85.827% when pulling c76fb469e83d165379fbed52c01ad8d06700df45 on doc-intro into 6e500559af19ea5c958f8463c69fa331cba90293 on master.


[Feature] EnvBinding should support dir-style config management

Currently EnvBinding puts all config patch for different environments in one Application yaml. This is not suitable as best practice for multi-env deployment. Instead, we should support dir-style config management.
See https://lundbird.medium.com/managing-kubernetes-environments-with-kustomize-ab3ab819d079

Is it more about an extra CLI tool which provides better local env management or a design issue where EnvBinding k8s object should be broken into different pieces?

a design issue where EnvBinding k8s object should be broken into different pieces?

This one.

a design issue where EnvBinding k8s object should be broken into different pieces?

This one.


feat: SplitHeader should have a clear button

Fixes #7553

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm


[Deprecation] 'webkitURL' is deprecated. Please use 'URL' instead.

When recaptcha__en.js is loaded on Chrome, it gives the following warning
[Deprecation] 'webkitURL' is deprecated. Please use 'URL' instead.

It looks like recaptcha__en.js uses window.webkitURL.  I think a common practice for handling this is doing window.URL || window.webkitURL instead.

Closing old issues that are not related to the PHP client code.


Option 1: use vernier extension

This option will mock an "web bluetooth" like interface to scratch-link.
Surfaces values in scratch for all sensor data.

LGTM. 👍


ConcurrentModificationException in ServerRequestQueue

There is a ConcurrentModificationException in this class due to improper synchronization usage,  spawning new threads to run operations on a list, and using a for-each loop instead of an iterator.  The log is truncated but I can try to provide something more inclusive if necessary.  I have the fix locally but I can't push to a branch to create a pull request due to permissions.
As reported by Crashlytics:
Fatal Exception: java.util.ConcurrentModificationException
at java.util.LinkedList$LinkIterator.next(LinkedList.java:124)
at io.branch.referral.ServerRequestQueue$1.run(ServerRequestQueue.java:70)
at java.lang.Thread.run(Thread.java:841)

@dmkessler Thanks for the report. We have added a temporary fix to the problem in v2.14.3.
Can you please  use this version.
Here is the PR we added to fix the issue https://github.com/BranchMetrics/android-branch-deep-linking/pull/520

@sojanpr I saw the temporary fix.  Thank you for fixing that so quickly for us.  I have created a PR that should address the issue in a more permanent solution located here: https://github.com/BranchMetrics/android-branch-deep-linking/pull/522


1/09 PM Publish

Docs Build status updates of commit 5309971:
:clock10: Full build: the average full build time is 22 min(s) 39 sec(s), this is based on the last 286 build(s) for this repository.

Docs Build status updates of commit 5309971:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-3.3.0/release-notes-azureps.md
:white_check_mark:Succeeded
View (azps-3.3.0)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Paints render in system messages

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Paints render in system messages like timeouts. I would expect that either both the username color is rendered with the paint or none of them. Timeouts should keep the current behavior. /mods; /vips could have paints. Point redemption messages also don't render color therefore they probably shouldn't have paints.
Screenshots

OS and Chatterino Version
This is on 80a08f582ccaf7011d208ffc0b8b77a4d2c37585, freshly merged into my branch.

This also applies to hosting messages.

They render for both on my instance

but you are correct they didnt use to render.

I like having them, I think it should be a setting/toggle

I like having them, I think it should be a setting/toggle

This should be done in Chatterino first (something like "color usernames in system messages"). Feel free to open a discussion there.


Add CopyError and implement fs::copy

Closes #5.
This brings an equivalent API to fs::copy into fs-err. I added a new inner error type instead of expanding the existing error type since this is the only variant with two paths involved right now.

Thanks! I'll publish a new version

Since this new release added a feature, do you think the new version should be 2.1.0?


[5.0] Runtime: Provide ABI space for source location info in unconditional casts.

Currently ignored, but this will allow future compilers to pass down source location information for cast
failure runtime errors without backward deployment constraints.
This is ABI-breaking, by adding new arguments to the end of the signatures of runtime functions. These new arguments are currently ignored, though, so existing compiled code should not immediately break. It is not strictly necessary for convergence, but getting it into Swift 5.0 would allow us to pursue QoI improvements in the future without deployment target gates.
rdar://problem/46543048

Note that I didn't merge this right away in case others disagree about the risk.

LGTM as well.


2 fixes

support for getting non-Lockr value
if someone stored some value before using Lockr, that value can now be getting by using Lockr.get()
can now get value that equals 0 or false
if use Lockr.get(key, defaultValue) and the stored value is 0 or false, the result is defaultValue, not 0 or false. this will fix it.

@Diablohu Can you add related specs for this PR so we can merge it?

just fix/modified Lockr.get() function for the 2 fixes mentioned above, for I encountered 2 problems when using Lockr in an exist product
Problem 1: when using Lockr.get() to retrieve an exist localStorage value, an error encountered
Problem 2: if a value is 0 or false, when retrieve using Lockr.get(), it returns as a missing value

@Diablohu I mean, can you add tests in the lockrSpecs.js file that test your code?

specs added

Awesome work! Thanks for the contribution :100:


Setting config.use_ember_middleware = false does not disable middleware in non-production environments

Following the instructions, I do
#test.rb
 config.use_ember_middleware = false

yet the middleware is still loaded. Here's the boolean logic responsible
#ember-cli-rails/lib/ember-cli/helpers.rb, line 28
def use_middleware?
   rails_config_for(:use_ember_middleware) || non_production?
end

My intuitive understanding is it should be something like
def use_middleware?
   if(rails_config_defined?(:use_ember_middleware))
      rails_config_for(:use_ember_middleware)
  else
      non_production?
  end
end

Which one is the intended behavior?

You're absolutely right. Setting these config parameters should override defaults, not augment logic. It's a bug. Fixed by https://github.com/rwz/ember-cli-rails/commit/9fa822067daedf23a0871ca0d1bd8f9965e480dd

Fixed in 0.1.3


Model-viewer updates

bump new model viewer  version
use current 3d image preview as poster #1245
placement should be in front of you to the ground, 1m before
expecting safari fixes

model-viewer v1.9.1

We can close this since we use model-viewer version 1.10.1 right now

placement should be in front of you to the ground, 1m before

Is this fixed?


Class based component metadata rule

This adds an API to provide class based component metadata rules.

This can get a review now. I have adapted most system tests, leaving a few using the old style as they test old style specific things.
What remains to be done, in subsequent PR:

Adapt samples
Dog food the Gradle build itself

This now also integrates the caching work done by @melix

As discussed with @melix this PR no longer contains the caching bits. It focuses on adding the class based ComponentMetadataRule fully isolated.


hotfix: fixed handle click on LaraDumps

When we tried to click on LaraDumps app handle link using windows on wsl+docker, exhibited an error on VS Code.
Now, we fixed it adding new .env variables and fixing the replace on IdeHandle.php file.
Follow the image:

New variable added:

Replacing on IdeHandle.php:

laradumps.php (config):

Thank you very much for this contribution!


[VS Code] Joining collaboration session: Collaboration session not found.

Error:
Joining collaboration session: Collaboration session not found.
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.379

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.35.0

platformName
Linux

platformVersion
4.15.0-51-generic

Hi @aliruss , thanks for reporting this! The issue title says that the session you were trying to connect was no longer active. Do you think the session did end at the time of your connection or you think that's a real issue?
Thanks!

Hi @setaskin I Installed Live Share extension and it works correctly but audio extension not working :disappointed:

@aliruss , sorry that you are having this issue. Would you provide some more info for us to investigate ? What is the Audio extension version you are using ? Also , your logs may provide us with helpful information. You can access them via the "Live Share: Export Logs" command from the command palette (ctrl + shift + p) and attach them to the issue

@jramsay , can you take a look ?

logs.zip
@setaskin these are the logs


Support latest PSR-15

This PR adds support for http-interop/http-server-middleware: ^1.0.  Also removes Travis tests for PHP 5.6 and HHVM which are not supported by the PSR anymore.

Can we get this merged and released? I'm waiting on it.

Released in v1.0.0.


docs(demo): add tooltip basic demo

@pkozlowski-opensource this also looks awesome.  Please see my comment re showing the full possible range of triggers (say, separate demo w/ dropdown to let the user select?) so that we have 100% API coverage.
Also, we should document (eventually) the valid list of events supported by the triggers property.

@icfantv yup, this is just very basic demo. We should have more. Let's discuss during the today's meeting what we need to add.

@pkozlowski-opensource Is it possible to join the conversation?

@sendilkumarn sorry, we don't have any public dev channel yet... Will discuss this with the entire team to see how we can make things more "in the open".


Update README.md

Hello,
It seems like ENVBUILDER_GIT_USERNAME/PASSWORD is not used, and GIT_USERNAME/PASSWORD works.
Can someone explain why that is?
If this is a mistake in docs, it can be updated by this pull request.

@paviln Hi, you are right about the difference in variable names. envbuilder's main branch uses the new ENVBUILDER_ names, but it has not been published yet, and the last published version v0.2.9 does not support it.
It should be fixed when a new version of envbuilder is published.

I was fooled by the readme too.
There is other files to update as well

https://github.com/coder/envbuilder/blob/8c5c50cad3ae396b73619d36da43ef2ff0ac0be8/testdata/options.golden#L94
https://github.com/coder/envbuilder/blob/8c5c50cad3ae396b73619d36da43ef2ff0ac0be8/docs/docker.md?plain=1#L23

Hey folks, the main version of envbuilder uses the ENVBUILDER prefix for the env variables so all the README is using it and we plan to keep it. For now, you can use the README from the latest published version here https://github.com/coder/envbuilder/tree/v0.2.9.

See also https://github.com/coder/envbuilder/releases/tag/v1.0.0-rc.0


Remove records that are mistaken

Records from the raw data that:

have the same Dossier_ID
Have exactly 2 records for that ID
Have Dossier_Status: Ingepland for the first and Vewerkt en afgesloten for the second

Are mistakes. Lien and Karel have decided that they should be removed.

Some cases/events have exactly two records, but the first one is Opvolging and the second one Verwerkt en afgesloten, eg Dossier_ID == 26732

In fact, I can't find any records with Dossier_Status == "Ingepland", I've probably misunderstood something. Do we mean Opvolging?

These are the combinations I can find for events/cases with exactly two records:

status1|status2
n

Opvolging|Verwerkt en afgesloten
319

Opvolging|Opvolging
33

Verwerkt en afgesloten|Verwerkt en afgesloten
20

Verwerkt en afgesloten|Opvolging
1

Messaged Lien about this to hear her opinion

For my own future reference, you can get these records out as follows:
readr::read_csv("data/raw/rato_data.csv") %>%
  group_by(Dossier_ID) %>%
  mutate(n_records = n()) %>%
  filter(n_records == 2) %>%
  filter(
    Dossier_Status[which.max(Laatst_Bewerkt_Datum)] == "Verwerkt en afgesloten" &
      Dossier_Status[which.min(Laatst_Bewerkt_Datum)] == "Opvolging") %>%
  arrange(Dossier_ID)

And count the combinations like this:

readr::read_csv("data/raw/rato_data.csv") %>%
group_by(Dossier_ID) %>%
mutate(n_records = n()) %>%
filter(n_records == 2) %>%
group_by(Dossier_ID) %>%
summarise(comb_status = paste(Dossier_Status, collapse = "|")) %>%
count(comb_status, sort = TRUE)

Thanks for raising this issue.
It's a bit odd that there's no status ingepland anymore. Perhaps I'm mistaken or it was removed from the data in the WFS.
Anyhow, you're correct that the only two remainig statuses are Opvolging and Verwerkt en afgesloten.
I checked your table, i believe that the 319 records with the consecutive statuses Opvolging and Opvolging are the ones that are opened by mistake and closed afterwards. The others records do not make any sense, in my opinion, and should be considered as errors as well. To be verified by RATO/Emiel.

Overview of dossier_status orders that are not logical to us:
https://docs.google.com/spreadsheets/d/1oIM33fpTivNYAsbVWW-MxHTpXD4_FCxSZMTyNQCwE4E/edit?usp=sharing
We expect:

always start with Opvolging
Verwerkt en afgesloten can only be the last element

To create:

readr::read_csv("data/raw/rato_data.csv") %>%
  filter(Domein != "Werken") %>%
  mutate(.keep = "used", Dossier_Status, Dossier_ID) %>%
  group_by(Dossier_ID) %>%
  summarise(status_col = glue::glue_collapse(Dossier_Status, sep = "|")) %>%
  ungroup() %>%
  group_by(status_col) %>%
  summarise(dossiers_col = glue::glue_collapse(Dossier_ID, sep = ",")) %>%
  filter(!stringr::str_detect(status_col, "^Opvolging.*Verwerkt en afgesloten$")) %>%
  filter(!stringr::str_detect(status_col, "^Opvolging(\\|Opvolging)*$")) %>%
  tidyr::separate_wider_delim(status_col, delim = "|", names_sep = "_", too_few = "align_start") %>%
  mutate(n_dossiers = stringr::str_count(dossiers_col, ",") + 1) %>%
  arrange(-n_dossiers) %>%
  dplyr::relocate(n_dossiers, dossiers_col, .before = status_col_1)

Remove the filters to see all combinations.

@LienReyserhove I remember we brought this up during a meeting with RATO, but I can't find any action points anywhere.
We currently have 1482 cases where there are exactly two records in a case, and the first one is Opvolging and the second one is Verwerkt en afgesloten, to replicate:
raw_data %>% group_by(Dossier_ID) %>%
    mutate(n_records = n()) %>%
    filter(n_records == 2) %>%
    filter(
        Dossier_Status[which.max(Laatst_Bewerkt_Datum)] == "Verwerkt en afgesloten" &
            Dossier_Status[which.min(Laatst_Bewerkt_Datum)] == "Opvolging")

I've updated this google doc: https://docs.google.com/spreadsheets/d/1oIM33fpTivNYAsbVWW-MxHTpXD4_FCxSZMTyNQCwE4E/
To the most recent situation, we currently have 203 different patterns that do not make sense, for a total of 4191 cases (dossiers), most of which have been closed without opening them (3277).
Questions:

Did we ever get an answer from RATO?
Can we identify combinations that are not allowed, and then remove those records from the publication

The dataset is growing quickly with the rats, and this phenomenon has grown with it


Major change proposal: Let user decide what goes into state

Currently we have functions like getDragState(type), getDropState(type), getDragLayerState(). They can be used from render but they're limiting in several ways:

You can't use them in componentDidUpdate or similar lifecycle hooks, you can't compare with previous values and thus react to changes.

Even with PureRenderMixin, you can't opt out of reconciling when the state of mixin changes. For example, you can't make a drag layer that would only update in 10 pixel steps. If you were implementing it yourself, you could have put Math.round(currentOffset.x) into state.x and use PureRenderMixin to avoid extra changes, but getDragLayerState() is opaque and uses underlying component's state as it wishes.

I wonder if we should change the contract so user defines methods that tell us what to keep in state. For example, drag panel that rounds values:
var DragStatePanel = React.createClass({
  mixins: [DragLayerMixin, PureRenderMixin],

  // NEW: let user pick the data
  collectDragLayerState(context) {
    // it's the same familiar context that is passed to configureDragDrop! no magic!
    var isDragging = context.isDragging(),
        clientOffset = context.getCurrentOffsetFromClient();

    return {
      isDragging: isDragging,
      roundedX: isDragging ? Math.round(clientOffset.x / 10) * 10 : null,
      roundedX: isDragging ? Math.round(clientOffset.y / 10) * 10 : null,
    }
  },

  render() {
    // NEW: read directly from your own state
    var { roundedX, roundedY, isDragging } = this.state;
    if (!isDragging) {
      return null;
    }

    return (

Dragging at coordinates: {roundedX}, {roundedY}.

    );
  }
});

Similarly, for drop targets (drag sources are the same):
  // NEW: decide what to pick
  collectDropTargetState(context) {
    return {
      isOver: context.isOver(ItemTypes.ITEM),
      isDragging: context.isDragging(ItemTypes.ITEM)
    };
  },

  componentDidUpdate(prevProps, prevState) {
    if (prevState.isOver && !this.state.isOver) {
      // NEW! do we even need enter() and leave() now?
    }
  },

  render() {
    // NEW: take values from your own state
    var { isOver, isDragging } = this.state,
        backgroundColor = '#222';

    if (isOver) {
      backgroundColor = 'darkgreen';
    } else if (isDragging) {
      backgroundColor = 'darkkhaki';
    }

    return (

        {isOver ?
          'Release to drop' :
          'Drag item here'
        }

    );
  }

If we can do this we might even not need enter and leave that much. I'd like to eventually move away from them in favor of React's componentDidUpdate. This would also allow us not to add enterCurrent and friends because consumer can just use componentDidUpdate for that.
We'd still need over though. Not sure what can be done there.

I really like the idea of leaving it to the consumer to construct their state. It avoids some of the issues with mixins that set state (clashing names and discoverability mostly). In general it seems more correct and flexible also.
collectDropTargetState does this mean its only for targets and not sources? In general though I love this idea.

Could over be handled with something like this for source? Or am I missing the goal of over?

does this mean its only for targets and not sources? In general though I love this idea.

I meant there to be separate methods like collectDragSourceState, collectDropTargetState, collectDragLayerState.

Or am I missing the goal of over?

Usually in over you want just the side effect. It may not really be expressible with a state change you “react” to.

This sounds pretty good. :+1:

We're ready to go ahead with this.
dnd-core already has everything we need except for over hook which we'll add soon.
Things to be considered:

[ ] How do we change drag source / target API?

[ ] We want to remove enter and leave
[ ] We want to rename over to dragOver
[ ] Do we really want drag source / drop target API to differ from dnd-core? In some ways, it should differ because we want to be able to specify things like dragPreview that are specific to React DnD. Instead of passing context and handle, we want hooks to accept context and component, etc. So they're clearly not the same thing. How are they constructed? dnd-core prefers classes (or rather makes them easy to work with), React DnD currently uses plain objects. We need to decide that. We'll probably stick with wrapping sources/targets provided to React DnD into some dnd-core style wrappers before passing them to dnd-core. Similarly, context passed by React DnD to hooks will likely wrap dnd-core's context.
[ ] Exotic things like dragPreview, effectsAllowed, etc. I need them to work (I actually use them). Need to figure out the right API for them.

[ ] How many collect* methods do we need? Is it possible to pass them to mixin in its declaration instead of defining them on component? Can we do the same for registration?
[ ] How do we solve coordinate tracking? See https://github.com/gaearon/dnd-core/issues/6 for thoughts on this. We might come back to this when everything else is ready.

Overall the right course is to start from scratch and make examples work, from the simplest one to more complex ones.

Let's do the work in this branch: https://github.com/gaearon/react-dnd/tree/dnd-core

Superseded by #111, let's track progress there.


Instance to slot mapping

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This pull request will be closed since this functionality will be moved to jobwatcher as a part of scale up code.


Resizing peek window lost code preview.

On resizing peek code window, the code preview disappears.
Changing to other reference in listing files on the right does not retrieve the code

VSCode Version: 1.33.1
OS Version:

Version: 1.33.1
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:20:22.771Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.18.0-18-generic snap

Steps to Reproduce:

Click on code reference to show peek window
Resize peek preview code window

Does this issue occur when all extensions are disabled?: Yes

I cannot reproduce. Is there anything in the error console (F1 > Dev Tools > Console) or any other error showing? Do you resize the height or the middle sash? Can you try to reproduce with latests insider?

Here is what I did with the Insider version.
I installed one by one all the extensions I use in the stable version and at each installation I checked the behavior without reproducing the bug.
I then erased all the extensions to copy the extensions of the stable version to insider without reproducing the bug.
I erased all the configuration files from the insider version and copied the files from the stable version without reproducing the bug.
The only mistake I have in the stable and insider version is this:
gitExec:err:Failed to execute git {
  "exitCode": 1,
  "gitCommand": "config",
  "stdout": "",
  "stderr": ""
  (at GitProvider.gitExec (/home/xarkam/.vscode-insiders/extensions/ms-vsliveshare.vsliveshare-1.0.91/src/contactService/providers/GitProvider.ts:175:21))

I analyzed all the logs files without revealing any error except for the error mentioned above.
When I open the developers tools, I have this error (stable version and insider):
Can not find an application or module for chrome-devtools://devtools/bundled/toolbox.html?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@164c37e3f235134c88e80fac2a182cfba3f07f00/&can_dock=true&toolbarColor=rgba(223,223,223,1)&textColor=rgba(0,0,0,1)&experiments=true

This is so weird... Can you use F1 > Dev Tools > Elements and find the containing split-view-view and see what its height is? Also, please try to drag the separator between tree and editor and see if that restores things

During my screenshots, I put the devtools in windowed mode and then I docked the devtools.
This action emptied the preview window.
Before resize

After resize

Resizing the separator.
When the window is empty, I have no separator.
I moved the separator before resizing the window and I can not reproduce the bug anymore.
I will reset stable vscode. To validate this behavior.

So, I can validate this behavior.
I put an animated gif for ease of understanding.

Thanks! That clarified it... Sorry, took me a while to remember, that's something we have fixed (for current insider) via https://github.com/Microsoft/vscode/commit/7915a1b6d98f29d7cc621e6b850f257547edcc7e


specify stakeholder needs for PAPRa project

Stakeholder needs should be specified, s/t derived requirements (albeit, in the form of user stories) can be mapped to their original stakeholder needs

Capturing stakeholder needs in a manner that can support traceability of requirements will require a modeling language, s/a m30ml for modeling stakeholder needs, user stories, supporting references, and their relationships https://github.com/Mach30/m30ml


Provide support for multiple accounts, add a new state module

This will merge after I add a few tests and merge the production databases

This will close #18, #19, #20, #34


Konachan tags list issue

Bug description
The Konachan website appears to have an issue, where loading the paginated tags list xml document (http://konachan.com/tag.xml?page=1) loads the same page each time. This puts Grabber into an infinite loop, since appending any number to the page will load the same page.
Steps to reproduce

Open tags loader
Choose Konachan
Run it
Die of old age
Open http://konachan.com/tag.xml?page=1 in a web browser
Open http://konachan.com/tag.xml?page=20
Open http://konachan.com/tag.xml?page=999999999999
Cry

Konachan does have a tags list that you can access at http://konachan.com/tag?page=1. It's not an xml, but it does correctly load the tags list. For some reason their xml is broken.

What's interesting is that while the page parameter doesn't work, the limit parameter does, and setting it to 0 dumps the whole tag list in one single call.
Another strange thing is that the tag listing works for yande.re, which also runs Moebooru.
I'll try to investigate further.


add screenshot of LBRY rewards

We should have some new rewards + descriptions tomorrow, let's update this at that time. Will need to update the reward list also.

Thanks Chris, replaced the screenshot and updated the descriptions


[Identity] MsalOpenBrowser refactoring

MsalOpenBrowser's usage of the HTTP client could use some cleaning, as in: separating functions from the main class, for example. I'm sure that if we invest some time thinking how to clean it up, we'll arrive to something interesting, I see it as a matter of spending time doing the cleanup rather than something specific.

The lack of refactoring here is arguably the root cause of a very hard to track CI bug we had. I made a fix here: https://github.com/Azure/azure-sdk-for-js/pull/15497 but further refactoring might help to avoid future problems.

Moving this to the October Milestone since I believe we won’t have time to do this before that date.


Add mysql as a backend for vault

Add the option to add a database (mysql) to be the backend of the vault

I appreciate the time and effort that went into this PR, but would prefer not to merge it.  Feel free to join us in Slack and discuss the desire for non-local Vault backends in an appliance solution.


fix: pin version of npm@9 for VPC facing architecture

Feature or Bugfix

Bugfix

Detail
In the latest release of npm 4 days ago, node 16 is no longer supported. Which leads to failure of the frontend image building when using VPC-facing architecture. In this PR the version of npm is fixed to the previous version. It solves the issue and it is a quick fix, but we need to upgrade to node 18. There are GitHub issues ( #655 #38 ...) dedicated to the node version upgrade, which should be done in a separate PR.
I tried upgrading the version of node directly in the docker image, but it lead to deployment errors (different ones)
Relates
Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

N/A for all
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Build succeeds for me with the changes in my VPC facing deployment


Load from file/string

The ability to load items/stmts/crates from a file (or other source).
Thinking that the source can be parsed using current technology and added into the current mod.

Yes, something like gore's :import or similar would really unlock the potential of this REPL!

Papyrus File Loading Prototyping
Goal
Handling of 'static' code, which does not need to constantly written to the lib.rs file each
REPL cycle. Each 'file' can be written once and referenced in the lib file. This may help
incremental compilation as well.
Storage
Storage would be done on the ReplData. Instead of storing the contents of the code (as this would
be static once written to disk) a hash of the contents is taken. As external crates may be
referenced, a list of CrateType is required. The writing path is required, this is required to
write the file (under ./src), and to remove an entry if required. The path can be used as a key.
struct StaticFile {
    path: PathBuf,
    codehash: Vec<u8>,
    crates: Vec<CrateType>,
}

// storage on ReplData
type StaticFiles = HashSet<StaticFile>;

Notes:

StaticFile is keyed on path for hashing/eq
codehash can be any hash should use blake2
path needs to be validated, it must be relative and must resolve to something under
./src

Adding
A function on ReplData can be used add a static file.
impl ReplData {
    fn add_static_file(&mut self, path: PathBuf, code: &str) -> Result<bool, AddingStaticFileError>
    {
	// validate `path`

	// hash `code`

	// compare `path` in set

	// if non-existent or hashes differ
	// - parse for crates
	// - write to disk, without the crates, under ./src

	// return if updated or unchanged
    }
}

Notes:

code is hashed with the crates inside, but written without.
multiple failure points, hence the return type.
Adding will write the file contents but will not trigger recompilation.

Removing
Removing is done through a function on ReplData. It should only require the path. Removal will
remove the entry and remove the file from disk.
Path validation
A path must resolve to something under ./src, adjacent to where the lib.rs file sits.
Validation can be done by stepping through the path components and only allowing basic file or
folder components (no relative '.' or '..' or root slashes.
Names also need to be valid as module names, so have to be checked for -, or not starting with
correct characters, or including whitespace.
Crate parsing
Crates can be specified using the extern crate crate_name; syntax at the top of the file. There
will be an explicit parsing implementation which requires crate declaration to be at the top.
The first n lines that parse as a crate will be ignored when writing code to disk. Each crate
will be added to a vector to be added to the toml and lib file on REPL cycles.
Linking in REPL cycle
Additions of static files is done on each REPL cycle. The crates are injected into the Cargo.toml
creation, and the lib/root level mods are added to the source code. Rather than ask users to define
the mod name (as paths and names would need to match), paths are parsed for the lib/root mod
addition.
There are no checks done if a static file is defined along a path that won't be included in
compilation. An example of this could be defining a path foo/bar.rs. The way to reference this
would be to add another static file foo/mod.rs with the contents pub mod bar;. The parser
will only add mods if they are at the root level. This means paths foo.rs and foo/mod.rs
would be considered legitimate and be included as mod foo;
Documentation will have to stress the implementation details to ensure users name things
correctly.


fix(compiler-sfc): setup binding has a higher priority than data

fix #11674

Hi @edison1105 , could I know is it possible to include this fix in v3.5.0-rc.2?  I saw we have just released the v3.5.0-rc.1.

@xieyuschen This PR is not a high priority and may not be merged as quickly

@xieyuschen This PR is not a high priority and may not be merged as quickly

oh i see, but should we consider to prioritise it as anyway it's a bug instead of refinement.


Readme.md: .end(done);

Readme.md:
... In order to fail the test case ...
.end(done); would do the job if there is no need to do additional checks.

In order to fail the test case, you will need to rethrow or pass err to done(), as follows:

I believe the documentation is wrong, as this passes:
.end(function (err, res) {
  done(new Error('foo'))
});


chore: manual bump of charts

Signed-off-by: ankitm123<EMAIL_ADDRESS>Charts bumped:

jx-preview
jx-slack
jx-test
jx-ui
jxboot-helmfile-resources
vault-instance

The auto upgrades are blocked because tests fail, trying to isolate the issue

Seems like issue is with build controller.

/retest

/retest

/retest

/retest

/retest

/approve


Ledger integration code

@TriPhan96 please resolve conflicts

@TriPhan96 please resolve conflicts

Move the work to PR #950 for for more convenient on code review. Mention recommendations here are all apply in the new one

Move the work to PR #950 for for more convenient on code review. Mention recommendations here are all apply in the new one


Set T9N_LANGUAGES in settings.json

Hey guys,
Is there any way to set the T9N_LANGUAGES env. in settings.json?
I've tried the following in my "settings.dev.json":
{
  "T9N_LANGUAGES": "da"
}

................................................
{
  "public": {
    "T9N_LANGUAGES": "da"
  }
}

...............................................
{
  "env": {
    "T9N_LANGUAGES": "da"
  }
}

................................................
But all languages is still loaded.
Kind regards

I do not know how you use the JSON file, but I dont think it will work. Any reason you cannot set an environment variable?

I run meteor with "meteor --settings settings.dev.json" to load project specific settings in development, and a settings.prod.json that easily can be transferred to the environment variable in production.
Well, the only reason would be, to avoid frequently changing the environment variable, when developing multiple projects at the same time, where the t9n settings would conflict.
But my question was most out of curiosity, I guess I could use Docker to set environment variables for each project.
It would be a bit easier if T9N_LANGUAGES could be set in a settings.json though.

Ok. I close it for now. If you need this feature reopen the issue. Pull request's are always welcome ;)


Assigning Index object to DataFrame.index which has an "index" column replaces column contents

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):

Windows 10, Ubuntu 19.10

Modin version (modin.__version__):

0.7.2+72.g6961c50.dirty

Python version:

Python 3.7.7

Code we can use to reproduce:

import numpy as np
import modin.pandas as pd

df1 = pd.DataFrame([['ccc', 'xxx', 2], ['bbb', 'yyy', 5], ['aaa', 'zzz', 8]],
                   columns=['index', 'whatever', 'shield'])
print(df1)

df2 = df1.rename({'index': 'name'}, axis='columns')
print(df2)

Describe the problem

If frame contains a column named index (which happens often after reset_index is used with drop=False (by default)), then some weird thing happens. In addition to renaming column label Modin inserts index contents into that column:
  index whatever  shield
0   ccc      xxx       2
1   bbb      yyy       5
2   aaa      zzz       8
   name whatever  shield
0     0      xxx       2
1     1      yyy       5
2     2      zzz       8

while pandas does only renaming:
  index whatever  shield
0   ccc      xxx       2
1   bbb      yyy       5
2   aaa      zzz       8
  name whatever  shield
0  ccc      xxx       2
1  bbb      yyy       5
2  aaa      zzz       8

Source code / logs

The problem is in this like in dataframe.py:
        obj.index = new_index

which assigns an index to a new dataframe object. But when it goes inside of DataFrame.setitem it assigns these values to a column named index instead of object index.

Here is a reproducer without rename
import modin.pandas as pd

df = pd.DataFrame([['ccc', 2], ['bbb', 5], ['aaa', 8]],
                   columns=['index', 'shield'])
print(df)
idx = pd.Index(['111', '222', '333'])
df.index = idx
print(df)

This is patch to tests to test this behavior
diff --git a/modin/pandas/test/utils.py b/modin/pandas/test/utils.py
index 1c517a6..3986cad 100644
--- a/modin/pandas/test/utils.py
+++ b/modin/pandas/test/utils.py
@@ -62,6 +62,12 @@ test_data = {
         ]
         for i in range(NCOLS)
     },
+    "with_index_column": {
+        "index": [1, 2, 3, 4],
+        "col4": [4, 5, 6, 7],
+        "col1": [8.0, 9.4, 10.1, 11.3],
+        "col2": ["a", "b", "c", "d"],
+    },
     # "int_float_object_data": {
     #     "col3": [1, 2, 3, 4],
     #     "col4": [4, 5, 6, 7],
@@ -154,6 +160,7 @@ numeric_dfs = [
     "float_data",
     "sparse_nan_data",
     "dense_nan_data",
+    "with_index_column",
     "100x100",
 ]

The problem is in this like in dataframe.py:
        obj.index = new_index

which assigns an index to a new dataframe object. But when it goes inside of DataFrame.setitem it assigns these values to a column named index instead of object index.

Well quick fix for that is
    obj._set_index(new_index)

now it's directly call the function that change indexes, without going to dataframe.py __setattr__ which looks like this
def __setattr__(self, key, value):
        if key in ["_query_compiler"] or key in self.__dict__:
            pass
        elif key in self:
            self.__setitem__(key, value)
        elif isinstance(value, pandas.Series):
            ...
        object.__setattr__(self, key, value)

so, if key named like some of DataFrame attribute (like index, columns etc) and the DataFrame itself contains a column with that name, then (going by that if-statement):
    elif key in self:
        self.__setitem__(key, value)

we'll try to assign value to a column, instead of calling object.__setattr__(self, key, value) and changing the attribute itself
It's means, that we probably should add a check that key isn't an attribute name (self.__dict__ returns dict with only one field '_query_compiler' so this is not that type of check)

@dchigarev yes, but will that change make it possible to still write df["index"] = some_new_valueor will all such assignments assign todf.index` instead?

with changing self.__dict__ to dir(self) related code works as expected:
    import modin.pandas as pd

    df1 = pd.DataFrame([['ccc', 'xxx', 2], ['bbb', 'yyy', 5], ['aaa', 'zzz', 8]],
                       columns=['index', 'whatever', 'shield'])

    df1["index"] = [1,2,3]
    df2 = df1.rename({'index': 'name'}, axis='columns')

    print(df2)

Output:
   name whatever  shield
0     1      xxx       2
1     2      yyy       5
2     3      zzz       8

Ok I tried implementing this approach referenced above. This does fix some of failing tests, but I still get 449 test failures. Without this fix and with test dataframe that contains "index" column I get 526 test failures from test_dataframe.py.

@dchigarev your suggestion to fix this bug was correct. Problem with my test was that it tested too broadly and resulted in additional failures #1447, #1464 and #1467. I had to narrow down this test and still had to fix additional problems in PR.


Feature/users online status (sidebar)

Pretty basic, just ported to Blaze Components but my first time using. Let me know if I'm doing it wrong @rclai

You're going on the right track with Blaze Components. If you want to access the parent component instance for whatever reason, you can do this.parentComponent().

Thanks @rclai I'll change the code to access the parent instead.

@hellstad i merged you stuff with the develop.. once ur done wiht adding new features please tell us so we can merge.. I made som changes you can check them by yourself

@dstollie does this need any more features? I think direct messages are already being worked on.


Implement IgnoreOutput

Thanks for the important project. It will make transitioning to Combine realistic.
To get my feet wet, I took a stab at IgnoreOutput since it's so trivial. Happy to pick up some more once this one goes in.

Closing this issue since it seems that most people just open a PR and have discussion there.


Sync beefy commitment on demand

A one-shot relayer at this moment and how we would integrate the one-shot relayer in future as follows from @vgeddes:

User on Polkadot signals that they want to speed up their message by depositing a fee in a special account on AssetHub/BridgeHub
An offchain service witnesses that deposit, and invokes the one-shot relayer

Still need to adjust for the change in parameters.go: https://github.com/Snowfork/snowbridge/pull/1216
Only submissions for mandatory commitments need to include an MMR leaf and proof

Only submissions for mandatory commitments need to include an MMR leaf and proof. The one-shot relay doesn't need to include those.

I'd prefer to include the MMR leaf and proof for the oneshot case, I vaguely recalled it won't cost much to add some more data to calldata without validation. And with that it's possible to extend the oneshot case for even the mandatory commitments.


Travis CI: add Node.js 12 and use cache: npm.

Needs #28655
@Johann-S: should we add Node.js 12 in v4 too? Note that I haven't switched to 12 in all places, I still use the current LTS (10).

I don't think we should add Node 12 for v4, because Node 10 will be maintained for a long time compared to our v4

Yup, agreed then.


:sparkles: add doc generation to selflow-cli

Added a command to generate the markdown documentation of the Selflow-CLI.
The documentation is generated based on command definitions created with Cobra.
Documentations are generated in the docs/ecosystem/cli directory to be added to the Docusaurus documentation.
Usage:
# In the repo root
go run ./apps/selflow-cli gen-docs
# OR
nx run selflow-cli:gen-docs

Thanks for your review @lavazais-sylvain ! I made the changes you suggested.
For the format of the generated files, I didn't find a simple way to use the library without recoding the generation functions. I might do it in the future but for now, I just added the nx format on the uncommitted files in the nx gen-docs task after the generation. What do you think about this change?

well, it better now 😃


Asterisk-Java ManagerConnection-0-Reader-0

2017.06.16 06:34:04 WARN  [Asterisk-Java ManagerConnection-0-Reader-0]: org.asteriskjava.manager.internal.EventBuilderImpl - Unable to set property 'statustext' to 'Idle' on org.asteriskjava.manager.event.ExtensionStatusEvent: no setter. Please report at https://github.com/asterisk-java/asterisk-java/issues
2017.06.16 06:36:00 WARN  [socket_c2s-thread-3]: class org.jivesoftware.openfire.streammanagement.StreamManager[<IP_ADDRESS>] - Client acknowledges stanzas that we didn't send! Client Ack h: 65, our last stanza: 58

Can you submit a patch with the necessary setter?


az login error on Archlinux

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az login
Errors:
Paste here the error message you have received. Make sure to remove all sensitive information,
such as user name, password, credential, subscription ID, etc.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az login

Expected Behavior
Environment Summary
Linux-6.1.25-1-MANJARO-x86_64-with-glibc2.37, Manjaro Linux
Python 3.10.10
Installer:

azure-cli 2.46.0 *

Additional Context

Thank you for opening this issue, we will look into it.

It was my mistake, please forget it.


Removing GetToken continue param fixes #017

GetToken() includes a empty continue param.
When MediaWiki 1.38 & 1.39 is put in private mode, this causes an API error as described on issue #017
The fix is to remove the param.
Tested on private & public mediawiki 1.39.
Did not run or fix your test suite.

Can confirm this works for me. Test suite seems to pass still?

Merged. Thanks! I don't use this library myself anymore, so I didn't test your change on a real wiki, but since it worked for two people, that's fine with me. I've tagged a new release 1.3.0. Sorry for the delay in merging this.


Circular dependency between tasks

Syncing and building the projects works just fine, but when I try to run a client (Fabric, Forge or Quilt), I get the following error:
3:42:56 PM: Executing ':Quilt:classes'...

> Configure project :Common
Quilt Loom: 0.12.40

> Configure project :Fabric
Fabric Loom: 0.12.56

> Configure project :Quilt
Quilt Loom: 0.12.40

FAILURE: Build failed with an exception.

* What went wrong:
Circular dependency between the following tasks:
:Common:prepareRemapJar
\--- :Quilt:jar
     \--- :Quilt:classes
          \--- :Quilt:compileJava
               \--- :Common:remapJar
                    \--- :Common:prepareRemapJar (*)

(*) - details omitted (listed previously)

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 5s

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings
3:43:01 PM: Execution finished ':Quilt:classes'.

Full debug log: https://gist.github.com/DAQEM/d4b7e985972fcec4d3f1259980336152
How to reproduce:

Download the files and open them using Intellij.
Wait for it to sync and download all the dependencies.
Generate the runs for forge.
Try to run any of the clients.

Removing compileOnly project(":Common") from the Quilt build.gradle fixed the issue for me.
Everything seems to work just fine. Syncing, Building and running a client.
I don't have that much knowledge of Gradle and multiloader setups, but I don't think this is the best way to fix it.
Any ideas how to fix it with a different solution?

I can't replicate this on my side.
I downloaded the repo, imported into IntelliJ, set the project sdk to 17 as well as configured gradle to use that, refreshed again, genIntelliJ runs and both Forge and Fabric ran fine.
If you remove compileOnly project(":Common") from the Quilt build.gradle you should stop having access to Common classes in the Quilt module... so no, that shouldn't be a great solution...

Yeah that's exactly what I did as well. Very strange. Thanks for checking tho. I'll let you know when I find the solution.

https://github.com/jaredlll08/MultiLoader-Template/issues/17
I've seen other people get this but haven't been able to encounter it myself, maybe applying that fixes it?
I'm thinking of probably switching the common module to VanillaGradle since loom in common comes with quite a bit of issues in a ML Environment.
I'm starting to think that having parchment is not that worth it.


Distribute royalties from contract

Allow sending funds directly to the contract. This way, creators can use the contract address for their royalty address to split royalties. Then the distribute function can allow members to claim their royalties, or an admin can distribute it to all.

Is this high priority for this week?


Add OpenLM LLM multi-provider

OpenLM is a zero-dependency OpenAI-compatible LLM provider that can call different inference endpoints directly via HTTP. It implements the OpenAI Completion class so that it can be used as a drop-in replacement for the OpenAI API. This changeset utilizes BaseOpenAI for minimal added code.

thanks @r2d4! could we add a simple example notebook (a la docs/modules/models/llms/integrations/openai.ipynb)

Thanks for the feedback @dev2049

Added documentation in the form of a notebook
Added the dependency to extras so it isn't downloaded automatically

Let me know if there are any other changes!


Manual sync committee update

If the sync committee update data retrieval fails (most likely because a beacon state is not available), build an update using the standard Beacon API endpoints.
Splits the protocol settings and methods into its own package.
Adds tests for the beacon data store.
First try to get an exact beacon state matching the slot provided, and if it can't be found, provide the best next update

If the sync committee update data retrieval fails (most likely because a beacon state is not available), build an update using the standard Beacon API endpoints.

That's Cool. Considering now we can always get a valid finality update from API endpoints, is the db option still necessary?

That's Cool. Considering now we can always get a valid finality update from API endpoints, is the db option still necessary?

The fallback finality update uses the DB option as a fallback as well. I would feel more comfortable with having the DB option as a backup. Do you have concerns with it?

I would feel more comfortable with having the DB option as a backup. Do you have concerns with it?

So we'll still stick to lodestar with --chain.archiveStateEpochFrequency=1 which saves finality state every epoch, right?
Not much concern.  Just from the perspective of DevOps seems we need a separate cloud instance to run the command storing beacon state periodically for high availability,  then there is some maintenance cost.

So we'll still stick to lodestar with --chain.archiveStateEpochFrequency=1 which already saves finality state every epoch, right?

Yes. 😄

Not much concern. Just from the perspective of DevOps seems we need a separate cloud instance to run the command storing beacon state periodically for high availability, then there is some maintenance cost.

I think it can be a simple cronjob on the EC2 server that will run the relayer anyway. Agreed on the cost. We can always remove it, but having it for launch gives me great assurance.

I think it can be a simple cronjob on the EC2 server that will run the relayer anyway

IIUC the cronjob only make sense on a seperate EC2 instance, it's for backup when the EC2 server running lodestar is down.
Meanwhile the cronjob should point to a different lodestar node which I'd suggest to run a backup lodestar with the mock options --execution.engineMock --eth1=false

I think it can be a simple cronjob on the EC2 server that will run the relayer anyway

IMHO the cronjob make sense only on a seperate EC2 instance, it's for backup when the EC2 server running lodestar is down.
So I'd assume it points to a different beacon node for which maybe we can run a backup lodestar with the mock options --execution.engineMock --eth1=false
In this way we have a more reliable fallback option but it also means more cost.

I had more the scenario in mind where just the beacon relayer is down (perhaps restarting because of a bug or some other issue) like we had that weekend where the beacon relayer was down because it could not find the beacon state. In that case, it would have been fine to have a cron just download beacon states every now and then.
I am also not sure if we will be able to justify running 2 EC instances just for this backup, especially if other people also start running relayers.

Yeah, I'm also not keen to add another instance for this. For the case when the instance is down for a while, we can start lodestar from a history checkpoint,right?


Fix simple typo: internaly -> internally

Issue Type
[x] Bug (Typo)
Steps to Replicate

Examine rest_framework_social_oauth2/oauth2_endpoints.py.
Search for internaly.

Expected Behaviour

Should read internally.

Semi-automated issue generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md
To avoid wasting CI processing resources a branch with the fix has been
prepared but a pull request has not yet been created. A pull request fixing
the issue can be prepared from the link below, feel free to create it or
request @timgates42 create the PR. Alternatively if the fix is undesired please
close the issue with a small comment about the reasoning.
https://github.com/timgates42/django-rest-framework-social-oauth2/pull/new/bugfix_typo_internally
Thanks.

Hi all.
My team and I are constantly using this framework and it seems it has died out there. I contacted the owner by email asking if he would add some of us as maintainers so we could continue to improve it. However we didn't get a response.
I am publishing the project under my profile and we are going to continue to invest time in it.
So I would like to gently ask you to contribute to this project on: https://github.com/wagnerdelima/drf-social-oauth2
Thank you for understanding.


ACM-7564: Design inconsistency in import cluster

https://issues.redhat.com/browse/ACM-7564

/test check

/retest

/retest


Hub: DAO Card Mobile View Improvements

Feature
Exploring the Hub app on a phone/tablet
Expected outcome
For the UI to be fully usable on phone or tablet
Actual outcome
Only slight changes need to be made for mobile improvements:

DAO Cards
Make buttons full width
Alignment changes:

Filter full with to match the button
Sort by left aligned
DAO names 2 lines after a max width (before truncating)

Browser
Brave
Screenshots and context

@earth2travis going to self-assign this as well


chore: import repository https://github.com/pchen2145/jenkins-quickstart.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


!feat(api/gateway): return txdata from submitPFB if it is present

Overview
Closes https://github.com/celestiaorg/celestia-node/issues/2328

Codecov Report

Merging #2329 (3214a1b) into main (dd1a019) will increase coverage by 0.25%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #2329      +/-   ##
==========================================
+ Coverage   50.62%   50.88%   +0.25%
==========================================
  Files         154      154
  Lines        9736     9744       +8
==========================================
+ Hits         4929     4958      +29
+ Misses       4381     4353      -28
- Partials      426      433       +7

Impacted Files
Coverage Δ

api/gateway/state.go
13.13% <83.33%> (+13.13%)
:arrow_up:

... and 6 files with indirect coverage changes


[DNM] bump version to 1.2.0

Once the other 2 PRs are merged, then we can merge this and deploy the new version to nuget

Change notes would be:

Now supports .NET Standard 1.3 / .NET Framework 4.6 ( https://github.com/dotnet/standard/blob/master/docs/versions.md )
Additional arguments
You can also control whitespace trimming and allowing hashes in values
DotNetEnv.Env.Load(false, false);

Both parameters default to true, which means:

trimWhitespace, first arg: true in order to trim
leading and trailing whitespace from keys and values such that

  KEY  =  value

Would then be available as
"value" == System.Environment.GetEnvironmentVariable("KEY")
null == System.Environment.GetEnvironmentVariable("  KEY  ")

False would mean:
"  value" == System.Environment.GetEnvironmentVariable("  KEY  ")
null == System.Environment.GetEnvironmentVariable("KEY")

isEmbeddedHashComment, second arg: true in order to allow inline comments

KEY=value  # comment

Would then be available as
"value" == System.Environment.GetEnvironmentVariable("KEY")

False would mean:
"value  # comment" == System.Environment.GetEnvironmentVariable("KEY")

Which is most useful when you want to do something like:
KEY=value#moreValue#otherValue#etc

unescapeQuotedValues, third arg: true in order to unescape/parse
quoted (single or double) values as being strings with escaped chars
such as newline ("\n"), but also handles unicode chars
(e.g. "\u00ae" and "\U0001F680") -- note that you can always include
unescaped unicode chars anyway (e.g. "日本") if your .env is in UTF-8.
Also note that there is no need to escape quotes inside.

KEY="quoted\n\tvalue"

Would then be available as
"quoted
    value" == System.Environment.GetEnvironmentVariable("KEY")

False would mean:
"\"quoted\\n\\tvalue\"" == System.Environment.GetEnvironmentVariable("KEY")

clobberExistingVars, fourth arg: false to avoid overwriting existing environment variables

KEY=value

System.Environment.SetEnvironmentVariable("KEY", "really important value, don't overwrite");
DotNetEnv.Env.Load(false, false, false, false); // fourth arg false, don't overwrite existing variables
System.Environment.GetEnvironmentVariable("KEY"); // == "really important value, don't overwrite"

Let's merge this in once we're ready for a new NuGet release. Need to find a way to add you as a co-owner on NuGet

@tonerdo forgot about this PR


Visualization doesn't start on local startup on localhost:9999

Hello,
I can run the visualization on a container  kitware/hpccloud:nginx (:8888). But when i start a local development frontend (:9999), then i can't open the visualization, usually i don't see errors in browser console and  i just wait loading of the visualization in long time, but after  there is only one error after long waiting:
index.js:66 WebSocket connection to 'ws://localhost:9999/proxy?sessionId=5e81a76eb69f894b7d835717&path=ws' failed: Connection closed before receiving a handshake response

When i reload the page, then i see that simulation is completed:

Thanks in advance!

Probably because in your dev server you didn't provide a ws socket forwarding rule?

i guess i didn't, usually i start kitware/hpccloud-services with default config.

Maybe the issue is somewhere else. Are you sue that you are getting the server notification?

I am not, after long connection with websocker i have errors with GET http://localhost:9999/api/v1/notification/stream. Where i can setting server notification?

I had no idea, so i had reconfigured the container  kitware/hpccloud:nginx:
FROM nginx

RUN rm /etc/nginx/conf.d/default.conf
COPY docker/nginx/nginx.girder.conf /etc/nginx/conf.d/girder.conf

docker-compose.yml:
  ...
  nginx:
    image: kitware/hpccloud:nginx
    build:
      context: .
      dockerfile: docker/nginx/Dockerfile
    networks:
      - hc
    working_dir: /usr/share/nginx/html
    volumes:
      - ./dist:/usr/share/nginx/html
    ports:
      - '8888:8888'
    depends_on:
      - girder
      - apache
  ...

there are  repositories hpccloud and hpccloud  was merged
and i start  a command for compiling:
    ...
    "build:watch": "webpack --progress --watch --mode development",
    ...


Keywords.json uses incorrect apostrophe character

The Magic comp rules and therefore the Keywords.json file uses "’" as its apostrophe character (unicode: single right quote, 0x2019). However the oracle text files use "'" (unicode: apostrophe, 0x27) as their apostrophe character. This leads to false negatives when doing any sort of comparison between the two.
Keywords.json should convert all single right quotes to apostrophes.

Yeah, it's a pain. Unfortunately there are a lot of programs that default to a single right quote as their apostrophe character- I assume that whatever they're using to build their file is one of them.


CAMEL-8306: Add support for wildcards to match on prefix

Description

Target

[X] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[X] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[X] I checked that each commit in the pull request has a meaningful subject line and body.

[X] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

It would be good to have an unit test for this as well - and also in one or more of the HTTP based components that support rest consumer
And then also find if possible where in the docs, to add some details about this

It would be good to have an unit test for this as well - and also in one or more of the HTTP based components that support rest consumer
And then also find if possible where in the docs, to add some details about this

I look into other HTTP based components, they all use this class(RestConsumerContextPathMatcher).

later, I will add unit test and docs.

Can you add tests where you have both wildcards and static paths, and some with curly placeholders
/camel/myapp/info
/camel/myapp/{id}
/camel/myapp/order/*

Can you add tests where you have both wildcards and static paths, and some with curly placeholders
/camel/myapp/info /camel/myapp/{id} /camel/myapp/order/*

sure

@davsclaus Could you please check if my changes look good

Something is misisng in camel-platform-http I think it would also need this register/unregister.
And did you remove some tests by mistake ?

Something is misisng in camel-platform-http I think it would also need this register/unregister. And did you remove some tests by mistake ?

The platform-http will use existing HTTP server to handle http request, so the routing match strategy involves using the existing HTTP server.

org.apache.camel.component.undertow.ws.UndertowWsConsumerRouteTest.echo
10.03s
FAILURE

org.apache.camel.http.common.CamelServletTest.testDuplicatedServletPath
1.164s
ERROR


Update Haskell package set to LTS 15.8 (plus other fixes)

This PR is test-built by Hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. I'll fix up the remaining errors and merge it on Friday, 2020-04-17 20:00 CET. You can watch this live on Twitch at https://www.twitch.tv/peti343. In addition to the chat features offered by Twitch, there is also a voice conference at https://discord.gg/YTEa3XR that viewers can use to chat with me and with each other.
TODO

[x] Confirm that https://github.com/NixOS/nixpkgs/pull/85446 has fixed ghcWithPackages for ghc-8.10.x.
[x] Investigate why ghc-lib-parser-ex-<IP_ADDRESS> seems to fail to compile for Niklas.
[ ] Split-out a minimal nix docker image: https://github.com/NixOS/docker/pull/13
[ ] Run krank on our override files and collect a TODO list of possibly outdated items.
[x] Update all-cabal-hashes reference.
[x] Merge r-updates, too, if there's time: https://github.com/NixOS/nixpkgs/pull/81307
[x] Merge https://github.com/NixOS/nixpkgs/pull/84980 after we've merged to master to get it in for the next session.

Setup: Encountered missing dependencies:
ghc-lib-parser -any

builder for '/nix/store/4bhjr2nz9i2lyffp6ivqwxf7dxakx4ch-ghc-lib-parser-ex-<IP_ADDRESS>.drv' failed with exit code 1

And indeed, hackage-packages.nix doesn't list in "ghc-lib-parser-ex" a dependency on ghc-lib-parser, even though the cabal file of that version lists the dependency.

@nh2 It looks like that dependency is behind a flag, which is maybe why cabal2nix isn't picking it up.
https://hackage.haskell.org/package/ghc-lib-parser-ex-<IP_ADDRESS>/ghc-lib-parser-ex.cabal

It looks like that dependency is behind a flag, which is maybe why cabal2nix isn't picking it up.

@cdepillabout Thanks! And it looks like the logic is changing again: https://github.com/shayne-fletcher/ghc-lib-parser-ex/pull/42

krank author here. I'm really happy that you are trying krank to track outdated overrides. Please, let me know (here or in krank issue tracker) if there is any improvement I can do.

@guibou I hadn't known about krank until now, that sounds really useful also for my own projects (and especially ugprades of NixOS!).
No specific requests yet, but I noticed one thing: Given that krank is a Haskell program, could you add it to Stackage? That would significantly increase the chances that it itself will not break in nixpkgs (reducing maintenance effort over here), and will also make it much easier to get it to build e.g. in static-haskell-nix.

Next week we'll merge https://github.com/NixOS/nixpkgs/pull/85926.


Group assets into TestCases, generate cases and assets according to schema changes

The PR generally looks OK so I approve it again, to keep momentum on the project.
The most obvious thing I picked up here relates to what you commented the other day: that the TestOutput model is not yet general enough, but mainly tailored to the existing Benchmarking testing output.
We could consider inserting a generic parent 'TestResult' in between 'TestEntity' and 'TestResultPKSet', or even consider renaming the latter to 'BenchmarkingTestResult', although I'm less certain of needing multiple TestResult child class models... maybe one properly designed model will eventually suffice.
In particular, in light of conversations earlier today about the ComponentEnum being generalized to leverage the infores catalog, I note the explicit list of slots for ARA's being tested (the TestResultPKSet is not using the ComponentEnum and in fact, includes unsecret which isn't yet even listed in the ComponentEnum.
I wonder if a more extensible general data model might be appropriate here for reporting results? For example, changing the hardcoded component slots to a single multivalued inlined slot ("component_test_results') of ComponentTestResult defined as:
  ComponentTestResult:
    is_a: TestEntityParameter
    slot_usage:
      parameter:
         range: ComponentEnum
      value:
         description: >-
            The 'value' of should be string descriptive of
            the test result for a given component.

completely agree -- we definitely need to refine this!

@sierra-moxon, I  guess my comments about tagging the infores catalog entries for their status as Translator components may be relevant.


CombatHUD highlight of pilot persists after called shot

From taintedloki on BTA discord... in 0.5.1 when doing a called shot, after called shot resolves the pilot portrait remains highlighted in blue.

Cannot reproduce - let me know if it happens again


Mac: Auto-update prevents to store settings of session

Whenever I install an update (prompted by VS Code) it doesn't open the same file I had opened before.
I think this is caused by a prompt process.exit() that leaves VS Code (or actually Chromium) no chance to persist the local storage to disk. It is reproducible by calling Lifecycle.quit() and from the done handler call process.exit().
Have to follow up with Electron to understand this better.

:+1:

Might be fixed with Electron update.

Nope...

@bpasero since this is the most annoying problem with VSCode, I have to label this bug as "Important"...

@weinand thats fine, but note that there is nothing we can do until we update to Electron 0.36.x.


Prioritize drawers that already have an item over empty ones

Cool approach, the Function Storage system!
Something that bothers me...
setup
Modpack "FTB Direwolf20 1.8" version 1.4.1, client/server setup.
versions
functionalstorage-1.18.2-0.0.17
forge 4.1.47
rftoolsbuilder-1.18-4.0.12
I have a Function Storage system with a controller linked to a bunch of drawers. The controller is placed upon an RFToolsBuilder builder (configured as a quarry) so that the builder puts its stuff into the drawers.
Most drawers are locked, some with upgrades, some with void upgrade.
Some drawers are empty in case there are items that I didn't expect.
experiencend behaviour
In the case that an unwanted item gets in, when I remove those items from the drawer, the next random stuff that gets into the Function Storage system is placed into that drawer, even if there is already another drawer with those items that still has enough capacity.
Example: One drawer empty, one with iron ore (locked), some dirt gets in, is placed into the empty drawer, I make sure no dirt gets in anymore, I remove it the dirt (drawer is empty), next iron ore is being put into that drawer.
expected behaviour
Drawers in the same system that already have the incoming item must always be preferred over an empty one as long as they have the capacity or a void upgrade.
If I can provide more information, let me know.
Thanks
FR²

I can't change how items are inserted safely the mod that inserts selects where it goes #37

I'm experiencing this even when using pipes to pull items from a chest, into the storage controller.
Considering Storage Drawers can and does seem to manage this safely, are you certain this expected behavior? I'm confused how a secondary mod has control over this?


Integration into build-system and initial harness

What does this change do?

Introduces a fuzzing directory containing a fuzzing harness that targets the parse entrypoint and tests the various serializers available in the library.
Introduces a build script that the OSSFuzz integration will use to build the fuzzer twice a day
Integrates the fuzzer into the build-system, using a CMake Option called BUILD_FUZZER

Is it related to an exisiting bug report or feature request?
Implements #208
Pre-merge checklist

[X] I've read CONTRIBUTING.md
[X] I've rebased my changes against the current HEAD of origin/master (if necessary)
[ ] I've added new test cases to verify my change
[ ] I've regenerated toml.hpp (how-to)
[ ] I've updated any affected documentation
[X] I've rebuilt and run the tests with at least one of:

[X] Clang 8 or higher
[ ] GCC 8 or higher
[ ] MSVC 19.20 (Visual Studio 2019) or higher

[X] I've added my name to the list of contributors in README.md

@marzer Apologize for the delay in getting this implemented! This PR represents the majority of what is needed to get this project integrated into OSSFuzz for continuous fuzz-testing. Once this is merged, I will submit a PR to the OSSFuzz project that defines a Dockerfile that will pull this project and run the build.sh

Thanks for this! Looks good to me :)

Also, the CIFuzz job will fail until that Dockerfile is merged into OSSFuzz

Yep, figured as much. No problem.


[FLINK-23615][docs] Fix the mistake in "systemfunctions"

What is the purpose of the change
Fix the mistake in "systemfunctions".
The documentation of the TRUNCATE SQL function states that "E.g. 42.324.truncate(2) to 42.34", which should be "42.32".
Some period in the document also lacks trailing spaces.
Brief change log

The description of TRUNCATE SQL function has been modified in docs/data/sql_functions.yml and docs/data/sql_functions_zh.yml
Add spaces  in docs/data/sql_functions_zh.yml where the specification requires

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no )
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no )
The serializers: ( no )
The runtime per-record code paths (performance sensitive): ( no )
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
The S3 file system connector: ( no )

Documentation

Does this pull request introduce a new feature? ( no )
If yes, how is the feature documented? ( no )

I have observed that the case of data types in the document is not uniform.  Some words in the description are lowercase, the first letter of some words is capitalized, and some words are capitalized.
For example "integer2 可以为负数，使值的小数点左边的 integer2 位变为零。此函数也可以传入只有一个 numeric1 参数且不设置 Integer2 以使用。如果未设置 Integer2 则 Integer2 为 0。" and "将字符串 STRING1 按照 STRING2 正则表达式的规则拆分，返回指定 INTEGER1 处位置的字符串。正则表达式匹配组索引从 1 开始"

Does the style need to be unified？

Does the style need to be unified？

From my point of view it will be great to unify this if the number of changes is limited. If this change will touch a lot of places then I suggest leaving it as it is.

I quite agree with you. I had a quick look at some of the documentation, and this could be quite a project. If necessary I would suggest that a new issue be created specifically to deal with this phenomenon.

Does the style need to be unified？

From my point of view it will be great to unify this if the number of changes is limited. If this change will touch a lot of places then I suggest leaving it as it is.

I quite agree with you. I had a quick look at some of the documentation, and this could be quite a project. If necessary I would suggest that a new issue be created specifically to deal with this phenomenon.

Thanks @tsreaper for the reviewing and @Launche for the contribution.
Merging...

Thanks a lot. This is a memorable contribution for me.


Multiple dependencies cause /vendor issues

My project depends on sharp and smartcrop-sharp which also, naturally, depends on sharp. When I attempt to deploy to netlify, only smartcrop-sharp installs libvips to /vendor, making it so that my script fails to run because my sharp's libvips version doesn't exist. Thoughts?

Hello, libvips is loaded as a shared library, so the first version of sharp to be required will "win". Either ensure require('sharp') occurs before require('smartcrop-sharp') or globally-install libvips before npm install.
https://github.com/jwagner/smartcrop-sharp/pull/3 should address this particular problem too as it moves sharp to be a peer dependency (as well as upgrading).


Add support for Bound filters in Druid

It would be great to support the Bound filter in Caravel.
Have you guys thought about it? I guess it also applies for the Javascript filter.
The backend depends on https://github.com/druid-io/pydruid/pull/60
Any ideas about the frontend? How should the bound filter look like?

Notice: this issue has been closed because it has been inactive for 632 days. Feel free to comment and request for this issue to be reopened.


Why is tornado.application logger ignored?

It appears Sentry do not report any logs from tornado.application logger
https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/tornado.py#L53
ignore_logger("tornado.application")
However, it seems the default logger used by Tornado to report unhandled exceptions:
https://github.com/tornadoweb/tornado/blob/682ff8dec2d095b339b62d875252be932ae4a5f2/tornado/web.py#L1762
def log_exception(
    self,
    typ: "Optional[Type[BaseException]]",
    value: Optional[BaseException],
    tb: Optional[TracebackType],
) -> None:
    """Override to customize logging of uncaught exceptions.
    By default logs instances of `HTTPError` as warnings without
    stack traces (on the ``tornado.general`` logger), and all
    other exceptions as errors with stack traces (on the
    ``tornado.application`` logger).
    .. versionadded:: 3.1
    """
    if isinstance(value, HTTPError):
        if value.log_message:
            format = "%d %s: " + value.log_message
            args = [value.status_code, self._request_summary()] + list(value.args)
            gen_log.warning(format, *args)
    else:
        app_log.error(  # type: ignore
            "Uncaught exception %s\n%r",
            self._request_summary(),
            self.request,
            exc_info=(typ, value, tb),
        )

How are we supposed to propagate uncaught exceptions in a Tornado based application to Sentry with Tornado integration?
Thanks

The Tornado integration hooks into tornado via other means to handle uncaught exceptions. Specifically we monkeypatch log_exception with our own version that reports the exception and calls the old version.
Generally we ignore loggers that have stringified stacktraces logged on them, but this does not seem to be the case here. I can't remember the reason in this specific instance.
I believe we could change the tornado integration to remove this ignore_logger call, and perhaps even rely on the logger for crash reporting instead of the monkeypatching.
Is this currently a problem for you?

Our Python developper suggests to drop Sentry TornadoIntegration ; I would rather keep it but I would expect it to capture uncaught exceptions without additional coding on our part.
-> The workaround is easy (dropping TornadoIntegration) but not satisfying.

The TornadoIntegration is supposed to capture uncaught exceptions, just not via the logging mechanism. Is your problem that you don't see crash reports in Sentry when enabling the integration?

Sorry for not having been clear about this: yes, we do not receive any report in Sentry. I asked our python developper to check locally why the monkeypatch did not work.

when having disabled the integration, could you post a link to an issue that is not captured otherwise?

This is on a closed-source project. I could send the json of the report by another mean.

could you post an abbreviated version of the json here? I only care about the exception message and non-app frames in any case

KeyError: 'SomeMessage'
  File "tornado/web.py", line 1697, in _execute
    result = method(*self.path_args, **self.path_kwargs)
  File "v2/handlers/custom.py", line 45, in get
    someVar = someValue

tornado/web.py in _execute at line 1697
                    await self.request._body_future
                except iostream.StreamClosedError:
                    return
            method = getattr(self, self.request.method.lower())
            result = method(*self.path_args, **self.path_kwargs)  <-------------
            if result is not None:
                result = await result
            if self._auto_finish and not self._finished:
                self.finish()
        except Exception as e:

Name | sentry.python
Version | 0.13.2
tornado | 6.0.3
tornado-http-auth | 1.1.1

Hmm. There should be a log message attached in addition to this. Above the
stacktrace.
On Fri, Nov 15, 2019, 12:34 Benoit Lacelle<EMAIL_ADDRESS>wrote:

KeyError: 'SomeMessage'
File "tornado/web.py", line 1697, in _execute
result = method(*self.path_args, **self.path_kwargs)
File "v2/handlers/custom.py", line 45, in get
someVar = someValue
tornado/web.py in _execute at line 1697
await self.request._body_future
except iostream.StreamClosedError:
return
method = getattr(self, self.request.method.lower())
result = method(*self.path_args, **self.path_kwargs)  <-------------
if result is not None:
result = await result
if self._auto_finish and not self._finished:
self.finish()
except Exception as e:
Name | sentry.python
Version | 0.13.2
tornado | 6.0.3
tornado-http-auth | 1.1.1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/getsentry/sentry-python/issues/553?email_source=notifications&email_token=AAGMPRKCCMEZMA3YPLOY2XDQT2CNHA5CNFSM4JNYN66KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEFFVKI#issuecomment-554326697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGMPRK4DUSK6QKXMBSJIDDQT2CNHANCNFSM4JNYN66A
.

My bad:
Uncaught exception GET /2.0/azaz/XXX?YYY= (<IP_ADDRESS>)
"HTTPServerRequest(protocol='http', host='localhost:1234', method='GET', uri='/2.0/azaz/XXX?YYY=', version='HTTP/1.1', remote_ip='<IP_ADDRESS>')"

That's troubling. It does seem like the monkeypatch doesn't work. Where are you initializing the SDK? Do you override log_exception in a subclass?

We're initializing the Sentry SDK in the main part of our entry script.
We don't override log_exception.
But We've overridden the log_function which we set to Application.log_request.

Removing the overridden log_exception fixed our issue.
Thank you for your time.

Ok, we will fix this. You should not have to fix your code because of this, just as workaround.

Actually @cgiraudeau , do you call the old log_exception from within your override? Or do you only run your code

I was only running my code without calling the old log_exception.
I had a try keeping my overridden log_exception with a call to the old log_exception and it was successful. 500 errors were reported to sentry.
So I think it's not a bug from yours. Maybe adding a line about this in the documentation would be helpful.
Again thank you for your time.

we re-enabled the logger for now


Documentation

yep, that :point_up_2:

Safety notes:

The SoftDevice needs exclusive access to some peripherals (RADIO, some TIMERs, SWI/EGUs, ECB, AAR..), you have to make sure not to use them on your own. Softdevice::enable() takes the PAC register blocks for these so safe code is unable to use them anymore (to be done, #4 ), but this still means you have to make sure to not use unsafe code to somehow still use these peripherals (such as Peripherals::take(), raw pointers, or calling into C code that uses them).
The SoftDevice needs exclusive access to some IRQs and priority levels. You must make sure not to use them. This includes NOT using cortex-m NVIC functions!! Using these is UNSAFE even if they're marked as safe. There is a proposal to split cortex-m so that the "opinionated concurrency model" functions would be opt-in (rust-embedded/cortex-m#239)
PPI? #14


Where are the replays stored?

please help

First, make a replay. Second, Make a folder where ever you want and make sure to REMEMBER where is that folder located. Make a replay, after u reach 100%, go to the same level, press pause and press ReplayBot. Press "Save" and you will see a dialog window, go to the path with the folder, choose your replay name and press save. When you want to load, go to a level where you replay is saved and press pause, press ReplayBot and press load. The same dialog will pop up and just select the replay you saved!
Note: when you are trying to load and you don't see your replay, go to that folder where the replay is, and select it. Or you didn't save the replay or you didn't create the folder.
I hope this helps!


ci: run specs for different Ruby versions

@tindron , may I ask to merge this PR?
Based on this PR, I am working on adding ubuntu-22.04 support (with GDAL 3.4; a couple of specs should be fixed for it).


Add detailed blog view template

This merge includes the implementation of the detailed blog view template. The changes include:

Adding the blog title and body
Displaying the publication date
Including the blog thumbnail image


fix(api): dont raise errors when updating the plate reader substate.

Overview
This pull request Opentrons/opentrons/#16339 fixed an issue where the plate reader was throwing an error when whenever we would open/close the lid/latch of other modules (heater-shaker/thermocycler). However, it introduced an issue where plate reader protocols would be analyzed forever.
Test Plan and Hands on Testing

[x] Connect a plate reader to the Flex and make sure we can successfully run the following protocol.

from typing import cast
from opentrons import protocol_api
from opentrons.protocol_api.module_contexts import AbsorbanceReaderContext

# metadata
metadata = {
    'protocolName': 'Absorbance Reader Multi read test',
    'author': 'Platform Expansion',
}

requirements = {
    "robotType": "Flex",
    "apiLevel": "2.21",
}

# protocol run function
def run(protocol: protocol_api.ProtocolContext):
    mod = cast(AbsorbanceReaderContext, protocol.load_module("absorbanceReaderV1", "C3"))
    plate = protocol.load_labware("nest_96_wellplate_200ul_flat", "C2")
    tiprack_1000 = protocol.load_labware(load_name='opentrons_flex_96_tiprack_1000ul', location="B2")
    trash_labware = protocol.load_trash_bin("B3")
    instrument = protocol.load_instrument("flex_8channel_1000", "right", tip_racks=[tiprack_1000])
    instrument.trash_container = trash_labware

    # pick up tip and perform action
    instrument.pick_up_tip(tiprack_1000.wells_by_name()['A1'])
    instrument.aspirate(100, plate.wells_by_name()['A1'])
    instrument.dispense(100, plate.wells_by_name()['B1'])
    instrument.return_tip()

    # Initialize to a single wavelength with reference wavelength
    mod.initialize('single', [600], 450)

    # NOTE: CANNOT INITIALIZE WITH THE LID OPEN

    # Remove the Plate Reader lid using the Gripper.
    mod.open_lid()
    protocol.move_labware(plate, mod, use_gripper=True)
    mod.close_lid()

    # Take a reading and show the resulting absorbance values.
    result = mod.read()
    msg = f"single: {result}"
    protocol.comment(msg=msg)
    protocol.pause(msg=msg)

    # Initialize to multiple wavelengths
    protocol.pause(msg="Perform Multi Read")
    mod.open_lid()
    protocol.move_labware(plate, "C2", use_gripper=True)
    mod.close_lid()
    # NOTE: There is currently a bug in the byonoy library which stops us
    # from using less than 6 wavelengths in multi measure mode.
    mod.initialize('multi', [450, 570, 600])

    mod.open_lid()
    protocol.move_labware(plate, mod, use_gripper=True)
    mod.close_lid()

    # Take reading
    result = mod.read()
    msg = f"multi: {result}"
    protocol.comment(msg=msg)
    protocol.pause(msg=msg)

    # Place the Plate Reader lid back on using the Gripper.
    mod.open_lid()
    protocol.move_labware(plate, "C2", use_gripper=True)
    mod.close_lid()

Changelog

Dont raise an error when updating the plate reader substate

Review requests

Is there a better way of doing this?
Am I missing anything?

Risk assessment
Low, unreleased.

I'm fine with this, but what case does this leave for when we are building out the module substate without a viable lid? I guess we already would catch that further up the line with like a "labware missing" type of error when trying to move it (in this hypothetical).

Spoke IRL, but this case won't affect us when running the protocol on an actual robot.
As for simulation, we will need to check whether this is an issue, but that can happen separately.


credslayer: 0.1.2 -> 0.1.3

Description of changes
remove broken marker. Update by upstream fixed pyshark incompatibility.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks for the PR, I am closing this since #199456 is merged :-)


Disables save-some-buffers functionality

With recent rustic-20220928.1157, save-some-buffers does not work anymore.
E.g. when I am within a rust project and execute M-x save-some-buffers, buffers are not saved and stay modified.  External files are saved.
It worked fine with some previous version and regression has been probably triggered by https://github.com/brotzeit/rustic/commit/78a71617b93af24f5fadf61e82ec0b303b994a5d
Both rustic-format-trigger and rustic-format-on-save are nil

Debugging in rustic-save-some-buffers
  (let ((buffers (cl-remove-if-not
                  #'buffer-file-name
                  (if (fboundp rustic-list-project-buffers-function)
                      (funcall rustic-list-project-buffers-function)
                    (buffer-list))))
        (b (get-buffer (bound-and-true-p rustic-format-buffer-name))))
+    (message "XXX %s %s %s" buffers b buffer-file-name)

shows that buffers is nil.
In other projects, it seems to work partially.  But there, the argument given to save-some-buffers is ignored.  E.g. when calling M-: (save-some-buffers t), I am asked whether to save the file.  Formerly, it was saved without prompting.

Also, when I call (save-some-buffers t) it ignores the argument (which is supposed to disable the save prompt). Seems to be caused by the advice being set around save-some-buffers.
This package should not be setting advices around built-in Emacs functions, especially without the user's consent. I can't imagine why you would want to mess with the save function in the first place -- either way, this is user-hostile behavior.

This advice has another, fundamental design problem
https://github.com/brotzeit/rustic/blob/c7b58ebc7588d1837de250927089d24aa10e4fbd/rustic-rustfmt.el#L458-L465
The (rustic-buffer-crate t) is evaluated in the context of the active buffer but not in this of the buffer which is to be saved.
rustic-save-some-buffers executes rustic-project-buffer-list in
https://github.com/brotzeit/rustic/blob/c7b58ebc7588d1837de250927089d24aa10e4fbd/rustic-compile.el#L432-L436
which in turn suffers from the same problem, that the project of the active buffer is used to decide about buffers of other projects.
https://github.com/brotzeit/rustic/blob/c7b58ebc7588d1837de250927089d24aa10e4fbd/rustic-rustfmt.el#L365-L368
That's why, running (save-some-buffers t) works when run e.g. from a dired buffer pointing to /tmp but misbehaves when executed from a rust file.

Also, when I call (save-some-buffers t) it ignores the argument (which is supposed to disable the save prompt). Seems to be caused by the advice being set around save-some-buffers.
This package should not be setting advices around built-in Emacs functions, especially without the user's consent. I can't imagine why you would want to mess with the save function in the first place -- either way, this is user-hostile behavior.

In the file rustic-rustfmt.el I had to comment out the following lines:
(advice-add 'save-some-buffers :around
            #'rustic-save-some-buffers-advice)

Leaving this here since I ran into this again on a new machine.

I turn this off for now. I'll try to reproduce and fix the issue.

This package should not be setting advices around built-in Emacs functions, especially without the user's consent. I can't imagine why you would want to mess with the save function in the first place -- either way, this is user-hostile behavior.

@m-cat we added the advice to disable the format functionality for save-some-buffers because they didn't work together. Unfortunately there is no other possibilities than either use an advice or drop the format on save feature completely.
Using rustic-save-some-buffers for rust projects instead of save-some-buffers was a feature request that also didn't convince me but I merged it anyways. It's difficult to make things work for everybody. I agree with you and turn it off and maybe add an option.