Generated query not following case sentitive properties

Version: 3.0.1
Module:  quill-async-mysql
Database: MySQL 5.7
Expected behavior
SELECT X.ID FROM (SELECT DISTINCT X02.* FROM TABLE1 X02 INNER JOIN TABLE2 X11 ON X02.ID = X11.TABLE_2_ID WHERE (X11.TYPE <> 'SOME_TYPE')) X
Note the uppercase X02 in the inner select.
Actual behavior
SELECT X.ID FROM (SELECT DISTINCT x02.* FROM TABLE1 X02 INNER JOIN TABLE2 X11 ON X02.ID = X11.TABLE_2_ID WHERE (X11.TYPE <> 'SOME_TYPE')) X
Steps to reproduce the behavior
Set lower_case_table_names system variable to 0 in MySQL and run the following code:
    val q = quote {
      for {
        (table1, table2) <- query[Table1] join query[Table2] on {
          case (t1, t2) => t1.id == t2.table2Id
        } if table2.type != lift(SOME_TYPE)
      } yield table1
    }

    ctx.run(q).distinct

I've noticed this error occurs only when I'm using distinct.
Workaround
Set lower_case_table_names system variable to 1 in MySQL
@getquill/maintainers

@cartagena What does that code where you create your context look like? Are you using Literal for naming or something else?

@deusaquilus I'm composing SnakeCase and UpperCase as below:
val ctx: MysqlAsyncContext[CompositeNamingStrategy2[SnakeCase.type, UpperCase.type]] = {
    val mysqlConfig = MysqlAsyncContextConfig(config)
    new MysqlAsyncContext(NamingStrategy(SnakeCase, UpperCase), mysqlConfig) with QueryProbing
  }

I've worked around the issue renaming the variable to be all uppercase.
    val q = quote {
      // upper case variable: work around as using distinct in query was breaking quill (https://github.com/getquill/quill/issues/1335).
      query[Table1].join(query[Table2]).on((P, table2) =>
          table2.table1Id == P.id &&
          P.type == lift(SOME_TYPE)
      ).map(_._1).distinct
    }

    ctx.run(q)

I suppose quill just reuses the variable name regardless its case. I've also had issue with a variable named KEY where the generated SQL query as invalid due the misuse of the reserved word KEY.


Remote target (for distributed actor) arguments are not properly deinitialized

Remote target arguments reconstructed on the remote side of the distributed actor are not properly deinitialised.
If the remote target argument is a struct with some class instance references then those class instances are never released, which cause a memory leak.

We implemented minimised test
It perform a remote call on the distributed actor with a struct argument having a reference to the ClassValue instance.
Can find the ClassValue instance initialized twice (first time on the caller side, second time on the remote side), but reinitialised only once (on the caller side):
git clone https://github.com/ordo-one/external-reproducers.git
Cloning into 'external-reproducers'...
remote: Enumerating objects: 135, done.
remote: Counting objects: 100% (135/135), done.
remote: Compressing objects: 100% (88/88), done.
remote: Total 135 (delta 49), reused 91 (delta 23), pack-reused 0
Receiving objects: 100% (135/135), 27.13 KiB | 524.00 KiB/s, done.
Resolving deltas: 100% (49/49), done.
aaa % cd external-reproducers/swift/distributed-system-leak
distributed-system-leak % swift test
Building for debugging...
[5/5] Linking DistributedSystemPackageTests
Build complete! (7.65s)
Test Suite 'All tests' started at 2023-05-11 12:45:03.890
Test Suite 'DistributedSystemPackageTests.xctest' started at 2023-05-11 12:45:03.891
Test Suite 'DistributedSystemTests' started at 2023-05-11 12:45:03.891
Test Case '-[DistributedSystemTests.DistributedSystemTests test1]' started.
Test Case '-[DistributedSystemTests.DistributedSystemTests test1]' passed (0.002 seconds).
Test Suite 'DistributedSystemTests' passed at 2023-05-11 12:45:03.893.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.002 (0.002) seconds
Test Suite 'DistributedSystemPackageTests.xctest' passed at 2023-05-11 12:45:03.893.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.002 (0.002) seconds
Test Suite 'All tests' passed at 2023-05-11 12:45:03.893.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.002 (0.003) seconds
assign<TestActor>: 1
actorReady<TestActor>: 1
resolve<TestActor>
init: 0x0000600002a301d0
recordArgument
remoteCallVoid
init: 0x0000600002a301f0
value=100
deinit: 0x0000600002a301d0
distributed-system-leak %

We would expect the second ClassValue instance constructed on the remote side would be deinitialised, thus the output would also had a line
deinit: 0x0000600002a301f0

Environment

Swift compiler version info

distributed-system-leak % swift --version
swift-driver version: 1.62.15 Apple Swift version 5.7.2 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>)
Target: arm64-apple-macosx13.0

Xcode version info
Deployment target:

distributed-system-leak % uname -a
Darwin mbpro.local 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:38:37 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T6000 arm64

Thanks let me try to reproduce this

Thanks I was able to reproduce this -- we didn't really test with messages being classes as that's a bit unusual but of course it must be supported correctly. I'm investigating this more now.

We reproduced and have a fix incoming, thank you very much for noticing this.

Yes, cherry picking it over to 5.9 as well

More completet fix incoming in:

[Distributed] Ensure to swift_release during destroying decoded distributed call arguments #65952
https://github.com/apple/swift/pull/65941

Hi!
We run our minimised test with the new swift toolchain and see there is no leak now.
Thank you for fixing that.


SuperLU symbol not found : _Destroy_CompCol_Matrix

Problem definition
This report may not be related with bugs, and a prominent solution surely pre-exists elsewhere.
My issue is about an internal linear solver and optimize functions failing to find a superLU function : _Destroy_CompCol_Matrix.
Environment
First of all, I run Scipy in Apple silicon M1. I installed Scipy with Homebrew OpenBLAS with the install command line like -
> OPENBLAS=/opt/OpenBLAS AR=libtool ARFLAGS="-static -o $@" python3 setup.py install

, and versions from 1.6 - most recent 1.7 tried.
My installation results are looking good. All of egg files and .so are successfully generated.
I can successfully run codes
import Scipy
import Scipy.sparse

Reproducing code example:
My problem appears after I import lining, and optimize like -
 import Scipy.sparse.linarg

or
from Scipy.optimize import minimize

Error message:
<!--
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/scipy-1.5.4-py3.8-macosx-11-universal2.egg/scipy/sparse/linalg/__init__.py", line 112, in <module>
    from .dsolve import *
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/scipy-1.5.4-py3.8-macosx-11-universal2.egg/scipy/sparse/linalg/dsolve/__init__.py", line 58, in <module>
    from .linsolve import *
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/scipy-1.5.4-py3.8-macosx-11-universal2.egg/scipy/sparse/linalg/dsolve/linsolve.py", line 11, in <module>
    from . import _superlu
ImportError: dlopen(/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/scipy-1.5.4-py3.8-macosx-11-universal2.egg/scipy/sparse/linalg/dsolve/_superlu.cpython-38-darwin.so, 2): Symbol not found: _Destroy_CompCol_Matrix
  Referenced from: /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/scipy-1.5.4-py3.8-macosx-11-universal2.egg/scipy/sparse/linalg/dsolve/_superlu.cpython-38-darwin.so
  Expected in: flat namespace
 in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/scipy-1.5.4-py3.8-macosx-11-universal2.egg/scipy/sparse/linalg/dsolve/_superlu.cpython-38-darwin.so
-->

As this error analysis, the issue happens from

2): Symbol not found: _Destroy_CompCol_Matrix

and

Expected in: flat namespace in _superlu.cpython-38-darwin.so.

Though I reported this issue into bugs, the problem probably caused by my method of build.
So I ask to investigate this issue with a wide view of aspects.
Scipy/Numpy/Python version information:
Finally, I attached my version information -
<!--
<module 'scipy.version' from '/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/scipy-1.5.4-py3.8-macosx-11-universal2.egg/scipy/version.py'>
<module 'numpy.version' from '/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/numpy-1.22.0.dev0+342.ge69faef03-py3.8-macosx-11-universal2.egg/numpy/version.py'>
 sys.version_info(major=3, minor=8, micro=10, releaselevel='final', serial=0)
-->

This seems like a funky way to install dependencies and build SciPy indeed. You are building with the system Python (/Library/Frameworks/Python.framework/...), I'd strongly recommend not doing that. If you are building SciPy from source because only there are no wheels: either use the experimental wheels at https://anaconda.org/scipy-wheels-nightly/ for macOS arm64, or install your whole stack from conda-forge. The latter is recommended, since it has much better support for arm64 than PyPI right now.
Either way, I suggest we close this issue since the config is not supported and bound to lead to issues. So I'll do that now - please comment though if there's more to talk about, I'm happy to continue the conversation or reopen the issue if needed @goanayven.


Failed to build image(Zeus) with ROS1

I am trying to build Zeus image including ROS1. Using these layers:

meta-ros-common
meta-ros1

I get build issues. Has anyone else had this problem?
Here is the error log:
ERROR: aws-checksums-0.1.5-r0 do_fetch: Fetcher failure: Unable to find revision 519d6d9093819b6cf89ffff589a27ef8f83d0f65 in branch master even from upstream
ERROR: aws-checksums-0.1.5-r0 do_fetch: Fetcher failure for URL: 'git://github.com/awslabs/aws-checksums.git;protocol=https'. Unable to fetch URL from any source.
ERROR: Logfile of failure stored in: /home/alpha/ros1_for_yocto_zeus/tmp/work/core2-64-oe-linux/aws-checksums/0.1.5-r0/temp/log.do_fetch.733201
ERROR: Task (/home/alpha/ros1_for_yocto_zeus/meta-ros/meta-ros-common/recipes-devtools/awslabs/aws-checksums_0.1.5.bb:do_fetch) failed with exit code '1'
WARNING: aws-c-common-0.4.15-r0 do_fetch: Failed to fetch URL git://github.com/awslabs/aws-c-common.git;protocol=https, attempting MIRRORS if available
ERROR: aws-c-common-0.4.15-r0 do_fetch: Fetcher failure: Unable to find revision e3e7ccd35a85f9cd38c67cb1988251f1543b6632 in branch master even from upstream
ERROR: aws-c-common-0.4.15-r0 do_fetch: Fetcher failure for URL: 'git://github.com/awslabs/aws-c-common.git;protocol=https'. Unable to fetch URL from any source.
ERROR: Logfile of failure stored in: /home/alpha/ros1_for_yocto_zeus/tmp/work/core2-64-oe-linux/aws-c-common/0.4.15-r0/temp/log.do_fetch.737671
ERROR: Task (/home/alpha/ros1_for_yocto_zeus/meta-ros/meta-ros-common/recipes-devtools/awslabs/aws-c-common_0.4.15.bb:do_fetch) failed with exit code '1'
NOTE: Tasks Summary: Attempted 4347 tasks of which 2868 didn't need to be rerun and 2 failed.

Thank you @shr-project for your quick response.
I solved the problem with the updated branch revision id


[IRC <> Telegram] Print /me messages from IRC as * ${nick} ${message} in Telegram so they are able to be distinguished.

[IRC <> Telegram] Bridge
Currently /me messages from IRC to Telegram are printed the same as any other message.
/me messages from IRC are an action

Justin slaps bob with a trout

It would be better if we could rint /me messages from IRC as * ${nick} ${message} in Telegram so they are able to be distinguished.

Duplicate of https://github.com/42wim/matterbridge/issues/1136?

My apologies, it is.


"Excluded Users" does not support groups

We manage our exclusions using groups... which we re-use across server CA policies. The picker in this policy will not let me pick groups.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c08f708d-bd04-a587-65c5-78a5f02adebc
Version Independent ID: 7c277e69-3e43-8542-03db-2d4a23dd5442
Content: Baseline policy End user protection (preview) - Azure Active Directory
Content Source: articles/active-directory/conditional-access/howto-baseline-protect-end-users.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@jaffadog
Thanks for your feedback! We will investigate and update as appropriate.

That is correct the selector does not allow the use of groups. If you would like to add a product feedback item to request this ability, it is available on the bottom of the document.

@jaffadog Please reach out via the link MicrosoftGuyJFlo provided for further engagement on this issue. As we've reached the scope of the github issue I will be closing out this thread.


Disable query-level Groovy function by default

In Pinot you can write a Groovy script as part of your query: https://docs.pinot.apache.org/users/user-guide-query/scalar-functions#groovy-scripts. This is a security risk, and we should disable this by default.
cc @mayankshriv

We had some discussion on this earlier too: https://github.com/apache/pinot/issues/7310. I would agree that groovy functions should be disabled by default :-)

+1

PR for adding config for disabling groovy in queries: https://github.com/apache/pinot/pull/8159

Adding table config overrides for disabling groovy #8196


Add Instruction page for Games

I would like to add an instructions page or pop-up to the navbar on each game page. The instructions will provide information on how to play the game.

@Surajit0573 Go for it!


Take xml loaded into a string and convert it back into regular xml format

When a tree is created with newly created xml and then saved as a string, I would something to be able to take it out of string format and put it back into normal xml format for printing purposes.

@akorb1 If you want pretty-formatted XML, use a save callback to insert whitespace.


Navigate - jump back and forth between function definition/call

If I hit Ctrl-J to jump to a function definition, is there a way to jump right back to the function call?
Ctrl-Tab as mentioned here will switch back to the last edited file only.

#13418  Might cater to this feature request.


Add versions 1.0.3 and 1.1.0

Add versions 1.0.3 and 1.1.0

Remove additional Ruby references.

Thank you for adding the Julia versions and correcting my mistakes!


Request add epg site from gameonlivesports australia

Source
https://www.gameonlivesports.com.au/Upcoming-Matches.aspx?t=Where-to-watch-EPL&TournamentID=394&TournamentName=English-Premier-League&FirstTeam=All&SecondTeam=All&MatchTitle=none
Notes
please add epg site from https://www.gameonlivesports.com.au/Upcoming-Matches.aspx?t=Where-to-watch-EPL&TournamentID=394&TournamentName=English-Premier-League&FirstTeam=All&SecondTeam=All&MatchTitle=none

I could not find on this site EPG for any channel. There is only the start time of individual matches with the name of the channel.


trying to check kubernetes yamls

Hi, I'm running:
docker run -v $(pwd):/foobar stelligent/config-lint -rules example-files/rules/kubernetes.yml /foobar/configmap.yaml`

but I get this response:
Failed to load rules: open example-files/rules/kubernetes.yml: no such file or directory

When I run:
docker run -v $(pwd):/foobar stelligent/config-lint -rules

It gives:
flag needs an argument: -rules
Usage of /config-lint:
  -debug
    	Debug logging
  -exclude value
    	Filename pattern

(etc., etc..) So it appears to run ok, but can't find the rules. As I can't look inside the container (it exits straightaway) I'm struggling to debug. I just want to check kubernetes files, nothing else.
Thanks,
Matt

@namloc2001 You will need to put the example Kubernetes rules into your local path and referencing to it accordingly, or you can have your own set of rules that you want to validate against.
For example:
docker run -v $(pwd):/foobar stelligent/config-lint -rules /foobar/path/to/my/rules/kubernetes.yml /foobar/path/to/my/configs/configmap.yaml

If you don't have your own set of custom rules that you want to run against your Kubernetes file then feel free to copy or download the example set that is listed here within the project.
At this time there isn't a default rule set for Kubernetes, but I will go ahead and create a new Issue for this as a new feature request.

Issue #151 has been created to handle this new feature request.

Thanks, I've created a pull request to apply some changes to the README.md as this had me stumped for a while.


Copy/paste in text box.

Hi, when I create a new task, I can't copy/paste into the editor. Feature or bug?

Kanboard version: 1.0.30
Database type and version: Sqlite 3.7.17
PHP version: 5.4.16
OS: CentOS 7.2.1511
Browser: Firefox 38.8.0

ditto in 1.0.31
you can paste in title box fine and can use CTRL V in description/tags but right click context menu doesn't offer paste option in the latter two.

I might not show it in the context menu, but it works just fine with the keyboard shortcut CTRL+V.

Right click seems to be disabled in the Markdown editor.

I haven't figured out what's causing this exactly. I do know that copy/paste works fine in the MDE website demo. The only observable difference is the additional tag "CodeMirror-Empty" at the start of the description element.

The text editor have been rewritten in v1.0.35 and CodeMirror is not used anymore. So this is working now.


Added mutex to sync gRPC Write().

Jenkins job mixerclient/presubmit passed

Jenkins job proxy/mixerclient-pr passed


Anime model - duration per episode

In anime model, does the duration (in minutes) always return an integer?
Does it round to nearest integer or does it return something like 0.5 for 30-second-episode like Ragnastrike Angels?

It rounds up to an integer (minutes).


onAdLoadFailedCallback not called when ad failed to load

MAX Plugin Version
2.3.2
Flutter Version
2.18.5
Device/Platform Info
Android 6.0, Galaxy S6
Current Behavior
No ad showing and onAdLoadFailedCallback not called. So I can't hide the space the ads take up.
Expected Behavior
onAdLoadFailedCallback is called when ad failed to load
How to Reproduce
Step 1: Turn off internet connection
Step 2: Open the screen with ads
Additional Info
No response

Additional: I use MaxAdView for my screen
MaxAdView(
adUnitId: bannerAdUnitId,
adFormat: AdFormat.banner,
listener: AdViewAdListener(onAdLoadedCallback: (ad) {
log('Banner widget ad loaded from ${ad.networkName}');
}, onAdLoadFailedCallback: (adUnitId, error) {
log('Banner widget ad failed to load with error code ${error.code} and message: ${error.message}');
}, onAdClickedCallback: (ad) {
log('Banner widget ad clicked');
}, onAdExpandedCallback: (ad) {
log('Banner widget ad expanded');
}, onAdCollapsedCallback: (ad) {
log('Banner widget ad collapsed');
}, onAdRevenuePaidCallback: (ad) {
log('Banner widget ad revenue paid: $ad.revenue');
}));

Additional: I'm using MaxAdView for my screens
MaxAdView(         adUnitId: bannerAdUnitId,         adFormat: AdFormat.banner,         listener: AdViewAdListener(onAdLoadedCallback: (ad) {           log('Banner widget ad loaded from ${ad.networkName}');         }, onAdLoadFailedCallback: (adUnitId, error) {           log('Banner widget ad failed to load with error code ${error.code} and message: ${error.message}');         }, onAdClickedCallback: (ad) {           log('Banner widget ad clicked');         }, onAdExpandedCallback: (ad) {           log('Banner widget ad expanded');         }, onAdCollapsedCallback: (ad) {           log('Banner widget ad collapsed');         }, onAdRevenuePaidCallback: (ad) {           log('Banner widget ad revenue paid: $ad.revenue');         }))

@hoalt - Can you check if you leave the device by itself for 1-2 minutes to see if the callback eventually fires?

Not working @thomasmso

@anandyadav21219 - Could you enable and send over our plugin's verbose logs?
https://dash.applovin.com/documentation/mediation/flutter/getting-started/advanced-settings#enable-verbose-logging

@thomasmso @hoalt
MaxAdView uses its own method channel. Error events should also be passed through that method channel. Currently, we cannot receive the OnAdViewAdLoadFailedEvent because it uses the shared method channel('applovin_max') to pass error events.
https://github.com/AppLovin/AppLovin-MAX-Flutter/blob/d2223c7579442c8453f5defab875a500da9c84b4/applovin_max/android/src/main/java/com/applovin/applovin_max/AppLovinMAX.java#L800
see #82

PR: https://github.com/AppLovin/AppLovin-MAX-Flutter/pull/89

Fixed in v2.5.0


Update howto-invoke-non-dapr-endpoints.md

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
Updated service invocation steps according to diagram that is included. List had 6 steps while diagram has 4.
Issue reference

@holopin-bot @inirudebwoy Thank you for your contribution!


Event order + Fixes

Worker state change events need to be hooked up before the process is started. This is achieved by initializing the process on next tick.
However, this breaks the assumption that worker.process exists immediately after initialization. To work around this, we re-emit the process message on the worker and subscribe to worker.on('message', ...) instead.
Also fixes a minor edge case where workers do not restart if the restart delay is 0.

Looks good to me.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


New game 1024

New game 1024, first pull request to the master branch

This looks great, thanks!
Just so you know, on Bangle.js 2 you can get screenshots from the actual device by typing g.dump() in the Web IDE when your'e connected :)


HBASE-24696 Include JVM information on Web UI under "Software Attributes"

https://issues.apache.org/jira/browse/HBASE-24696
@ndimiduk

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 52s
master passed

+1 :green_heart:
checkstyle
2m 25s
master passed

+1 :green_heart:
spotbugs
5m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 34s
the patch passed

+1 :green_heart:
checkstyle
2m 38s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
15m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
5m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

54m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux b164c8422e17 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  8s
the patch passed

+1 :green_heart:
compile
2m 11s
the patch passed

+1 :green_heart:
javac
2m 11s
the patch passed

+1 :green_heart:
shadedjars
6m 14s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 52s
hbase-server in the patch failed.

-0 :warning:
javadoc
1m  8s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 24s
hbase-rest in the patch failed.

_ Other Tests _

-1 :x:
unit
148m  8s
hbase-server in the patch failed.

+1 :green_heart:
unit
5m  5s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 27s
hbase-rest in the patch passed.

189m 27s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dba1d203d7b0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/testReport/

Max. process+thread count
4094 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 43s
master passed

+1 :green_heart:
compile
1m 55s
master passed

+1 :green_heart:
shadedjars
5m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
compile
1m 51s
the patch passed

+1 :green_heart:
javac
1m 51s
the patch passed

+1 :green_heart:
shadedjars
5m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 26s
the patch passed

_ Other Tests _

-1 :x:
unit
160m 14s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 59s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 22s
hbase-rest in the patch passed.

197m 12s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9d7a0ba5c276 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/testReport/

Max. process+thread count
4095 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
master passed

+1 :green_heart:
checkstyle
2m 12s
master passed

+1 :green_heart:
spotbugs
4m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
checkstyle
2m 10s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 42s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
5m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

47m 16s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 5d092eac02bd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Max. process+thread count
85 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
2m  9s
the patch passed

+1 :green_heart:
javac
2m  9s
the patch passed

+1 :green_heart:
shadedjars
5m 45s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 49s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
128m 50s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 48s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
2m 51s
hbase-rest in the patch passed.

167m 11s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2b0ae9f0451c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/testReport/

Max. process+thread count
4537 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
master passed

+1 :green_heart:
compile
2m  0s
master passed

+1 :green_heart:
shadedjars
6m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
compile
2m  2s
the patch passed

+1 :green_heart:
javac
2m  2s
the patch passed

+1 :green_heart:
shadedjars
6m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
204m  4s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m 34s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 55s
hbase-rest in the patch passed.

245m 23s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4aba753ef16a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/testReport/

Max. process+thread count
3551 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
2m  7s
the patch passed

+1 :green_heart:
javac
2m  7s
the patch passed

+1 :green_heart:
shadedjars
5m 43s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 51s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
130m 31s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m  7s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 14s
hbase-rest in the patch passed.

169m 24s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9451d1ee7f3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a857c6d90c

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/testReport/

Max. process+thread count
4325 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 30s
master passed

+1 :green_heart:
compile
2m 17s
master passed

+1 :green_heart:
shadedjars
7m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 23s
the patch passed

+1 :green_heart:
compile
2m  7s
the patch passed

+1 :green_heart:
javac
2m  7s
the patch passed

+1 :green_heart:
shadedjars
6m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 40s
the patch passed

_ Other Tests _

-1 :x:
unit
147m 56s
hbase-server in the patch failed.

+1 :green_heart:
unit
5m  2s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 23s
hbase-rest in the patch passed.

191m 18s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6f3ed1733217 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a857c6d90c

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/testReport/

Max. process+thread count
4712 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
master passed

+1 :green_heart:
checkstyle
2m 10s
master passed

+1 :green_heart:
spotbugs
4m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 10s
the patch passed

+1 :green_heart:
checkstyle
2m 15s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 45s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
5m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

47m 14s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux f487303a18ba 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 430602aed8

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 16s
the patch passed

+1 :green_heart:
compile
2m 11s
the patch passed

+1 :green_heart:
javac
2m 11s
the patch passed

+1 :green_heart:
shadedjars
6m 19s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 51s
hbase-server in the patch failed.

-0 :warning:
javadoc
1m 11s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 23s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
148m 59s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m  5s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 12s
hbase-rest in the patch passed.

190m  1s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux db94ff80c926 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 430602aed8

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/testReport/

Max. process+thread count
3882 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 29s
master passed

+1 :green_heart:
compile
1m 52s
master passed

+1 :green_heart:
shadedjars
5m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 36s
the patch passed

+1 :green_heart:
compile
1m 51s
the patch passed

+1 :green_heart:
javac
1m 51s
the patch passed

+1 :green_heart:
shadedjars
5m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
159m 33s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m  7s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 27s
hbase-rest in the patch passed.

196m 26s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2087

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ce1cb607bfd9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 430602aed8

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/testReport/

Max. process+thread count
4106 (vs. ulimit of 12500)

modules
C: hbase-server hbase-thrift hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Check on updates to cloned assets w. Complex props

Wrote 3 questions as clones today on a page. Noticed at the end that they all had the same array values but all other settings were as I set them.
Maybe the array binding needs more clean up prior to repainting or it doesn't reflect the values being updated. Need to dig more to reproduce

This is an issue in the cloning itself and then complex objects being printed into the DOM


Desync Detected

Product and Version [VS/VSCode]:  vscode
OS Version [macOS/Windows/Linux]: windows
Live Share Extension Version: 1.1.1056
Target Platform or Language [e.g. Node.js]:
Python 3.8
What were you doing when you encountered the desync?
editting python file
How often have you encountered desyncs?
first time

Closing this as a duplicate of #2086.


Scrolling acceleration

I recently updated to the last version 0.1.17 and noticed that scrolling is much faster than my previous one (0.1.7). That causes flickering and blank spaces for several seconds. I tried to lower the overscanRowCount but the problem still exist when the scrolling is fast. Is there a way to slower the scrolling acceleration ?

This would be more of a react-virtualized issue, but I think you might be able to mitigate it by increasing the overscanRowCount. Please try that out.

The problem was in my custom node renderer. I had a time consuming operation. Now with the last version of the tree and optimization in my code the scrolling is really fast and there is no flickering in Chrome. In Firefox I cannot accelerate the scrolling so I cannot have flickering even with slow node renderer so may be react-virtualized has different behavior in different browsers but it is still good.
One problem I also found is that when dragging a node it disappears(only the blue area is seen) if I have a matrerial-ui icon with a tooltip property on it in my node renderer. When there is no tooltip the node can be seen.


Automated user plays animation when out of energy

Minecraft version & Mod Version:
Minecraft 1.12, Cyclic 1.7.7
Single player or Server:
Single player
Describe problem (what you were doing / what happened):
When an automated user is set to "Always on" or is receiving a redstone signal, it always plays its active animation, even if it's out of energy.
Crash log (if any): N/A

I think this also happens with Uncrafter, possibly others

Fixed in latest version https://minecraft.curseforge.com/projects/cyclic/files/2466488


Fix mixed case Unix path

@sorpigal : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Edm.DateTime ATOM format is not parsed correctly

When execution reaches https://github.com/SAP/python-pyodata/blob/master/pyodata/v2/service.py#L765
It assumes the format is JSON, however the ATOM formatting is still perfectly valid, but the library seemingly has no mechanism to detect if this is the case or not.
So if this library is used against a server that ATOM-formats its Edm.DateTime, the following error happens:
pyodata.exceptions.PyODataModelError: Malformed value 2022-01-04 for primitive Edm.DateTime type. Expected format is /Date(<ticks>[±<offset>])/

Hi @OmniTroid could you please provide test that would reproduce this behavior?

I have the same error running v1.9.1 of pyodata against an SAP ByDesign tenant's OData service: https://my301795.sapbydesign.com/sap/byd/odata/cust/v1/ablemate/BusinessPartnerCollection?$filter=InternalID eq 'NBS'
The JSON returned:
{
	"d": {
		"results": [
			{
				"__metadata": {
					"uri": "https://my301795.sapbydesign.com/sap/byd/odata/cust/v1/ablemate/BusinessPartnerCollection('00163E0265D71ED28ECFF48DDCD64CF2')",
					"type": "cust.BusinessPartner"
				},
				"ObjectID": "00163E0265D71ED28ECFF48DDCD64CF2",
				"InternalID": "NBS",
				"CSM_KUT": "",
				"ProjectManager_KUT": "",
				"Consultant_KUT": "",
				"ServiceLevel_KUT": "",
				"Platform_KUT": "",
				"LifeCycleStatusCode": "2",
				"RegionCode": "UT",
				"CountryCode": "US",
				"RoleCode": "BBP000",
				"LastChangeDateTime": "/Date(1639167537708)/",
				"SupportThroughDate_KUT": null,
				"BusinessPartnerFormattedName": "Navigator Business Solutions",
				"URI": "nbs-us.com"
			}
		]
	}
}

I believe it's the "LastChangeDateTime" value causing the error. I recognize it's not ATOM formatted, but it seems to be a similar problem handling date. Let me know if another bug would be appropriate.

Hi squeakyboots - thanks for thorough bug report and even own investigation + tryout fix.
I believe you have different problem than Omnitroid (at least, there is still no code to reproduce, maybe it is the same, but it mentions return from server in ATOM formatting, not JSON as you did provided). I would prefer you to create a new bug - I am not doing it, since you are referencing it from your project. Just copypaste there your part and I will copypaste there this answer and then delete both in here.
First of all - your edc scanner is great. This is exactly the tool I wanted to build when I will have some spare time :) I need to check into more detail how you solved the odata v4 support.. isn't that something that should be here as well?
Second - please do a PR with your fix and the new tests (and reference the new bug there). If it fixed your problem, it is worth to be upstream.
Third - there are actually a datetime offset tests - but maybe not with the case that reproduces your bug. Refer to this commit (commit message, code changes and new tests), which re-worked the DateTime + DateTimeOffset and maybe you can reproduce the bug with addition of new line to correct parametrized test.
https://github.com/SAP/python-pyodata/commit/ec56995551779cb99ae0a5734a7ecc3449e5191d#diff-7997cda67851c8c96f44d1246b73701adfa2afb643042bf34d11f872c2c5b974

Based on provided info, this seems like at the moment duplicate of #231.
@squeakyboots  - I totally forgot about your solution for same problem, it does look better than my ugly adding of "+0000" to the input :)  So reused yours to the master branch.

note for original @OmniTroid  - ATOM is at the moment not supported at all in the pyodata, only the literal and JSONs... but should be, that is for sure.. but that is overall new feature.


Nuki Smart Lock Pro (4th generation)

also works for the new hardware version Nuki Smart Lock Pro (4th generation)!
Please adjust the description.
Thank you :-) #

also works for the new hardware version Nuki Smart Lock Pro (4th generation)! Please adjust the description. Thank you :-) #

Via Thread or WiFi?

WiFi

also works for the new hardware version Nuki Smart Lock Pro (4th generation)! Please adjust the description. Thank you :-) #

But you still need a bridge, I guess? Even though 4th gen doesn't mandate use of a bridge for WiFi connection.

We are using 3x Nuki 4th generation with wifi only. No bridge was nessesary so far.


Access denied for root@localhost (using password: YES)

What is wrong?
Database layer is not connecting to local database.
Steps to reproduce
A simple yarn clippy would suffice to see the error, but it doesn't occur in every system.
Maybe a problem of OS (Mac?) ~or of the docker compose v2~ (edit).
Repported by @wayne-smart (please fell free to edit this issue description with more info)

We checked in another machine, running linux, if the problem was caused by:

Version 2 of Docker compose
New version of sqlx-cli
They weren't.

Tested if the ports weren't properly opened, disabling the firewall. It haven't worked.
The solution was to make a brand new setup in a more modern Mac.
Closed because not easily reproducible.


Default duration for to()

It would be great to have defaults for to() that make it obvious things are working.
Whenever I use sequence, I always wonder why it's not working and it's because I forgot to set the options on to() which I almost always do.
Looking at the code to make some personal changes easing has a good sensible default (inOutQuad) but duration has a unexpected default (zero) which makes the results surprising as it appears to not be working.
Might be a small thing but I think it would help onboarding.
Just a thought!

good idea. Originally the goal was to use to(value) to also direct set the value directly. But later I've added set() that does that more clearly. I also added a new default duration for sleep()


[New Port Request] mpfi

Library name: mpfi
Library description: a multiple-precision interval arithmetic library based on mpfr
Project Filelist for MPFI: https://gforge.inria.fr/frs/?group_id=157
I just started using vcpkg and it is awesome. Really makes package management easy. I don't own (or even contribute to) mpfi but it's an awesome library, and fairly widely used, so I'd love to see it included in vcpkg. Many thanks.

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


fix flaky upload badging

In the separate PR, let's try to also port over any debug tags that could be in the original context.

I don't think context exposes that, unfortunately. It's just .Value method. We have "delayed context", but I'm not sure it's worth here or not. Thoughts?

OK merging this! I created https://keybase.atlassian.net/browse/KBFS-3651 for tracking the debug tag thing.


chore: bdd-ghfjxy-import-1585113547 to 0.0.1

chore: Promote bdd-ghfjxy-import-1585113547 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix opening chat and disabling shortcuts in chat

It seems that the Google Meet HTML has changed, so opening the chat window and suppressing shortcuts when typing in the chat stopped working.
This adapts the selectors for the chat button and the chat input field to reflect the current HTML.

I haven't had to use Google Meet for a while, so I'll take your word for it.

Perfect, thank you for the quick reaction! I have asked someone else to verify the new IDs and they confirmed them.
Otherwise, hopefully someone will comment on Greasy Fork if it doesn't work.


Maven plugin cannot save the generated test

Characteristics

Issue Type: bug
Reproducibility: always
Tool/Service/Component: Botsing Maven plugin

Description
Maven plugin throws an error during the compiling and saving the generated test:
[ERROR] Compilation failed on compilation units: [RegularFileObject[/var/folders/t4/0qd1kfm97tz9g17z439t2gmm0000gn/T/EvoSuite_0_1548688017004/org/apache/commons/lang/text/StrBuilder_0_tmp__ESTest.java], RegularFileObject[/var/folders/t4/0qd1kfm97tz9g17z439t2gmm0000gn/T/EvoSuite_0_1548688017004/org/apache/commons/lang/text/StrBuilder_0_tmp__ESTest_scaffolding.java]]
[ERROR] Classpath: /Users/pooria/Desktop/Model_seeding_ISSTA/D4j_sources/new/lang/lang_47/target/classes:/Users/pooria/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar:/usr/local/Cellar/maven/3.5.0/libexec/boot/plexus-classworlds-2.5.2.jar
[ERROR] evosuiteCP: /usr/local/Cellar/maven/3.5.0/libexec/boot/plexus-classworlds-2.5.2.jar
[ERROR] Diagnostic: package org.junit does not exist: 8
[ERROR] Diagnostic: package org.junit does not exist: 9
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 10
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 12
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 13
[ERROR] Diagnostic: package org.junit.runner does not exist: 14
[ERROR] Diagnostic: package org.evosuite.runtime.annotation does not exist: 9
[ERROR] Diagnostic: package org.junit does not exist: 10
[ERROR] Diagnostic: package org.junit does not exist: 11
[ERROR] Diagnostic: package org.junit does not exist: 12
[ERROR] Diagnostic: package org.junit does not exist: 13
[ERROR] Diagnostic: package org.evosuite.runtime.sandbox does not exist: 14
[ERROR] Diagnostic: package org.evosuite.runtime.sandbox.Sandbox does not exist: 15
[ERROR] Diagnostic: cannot find symbol
  symbol: class EvoSuiteClassExclude: 17
[ERROR] Diagnostic: cannot find symbol
  symbol: class RunWith: 16
[ERROR] Diagnostic: cannot find symbol
  symbol: class EvoRunnerParameters: 16
[ERROR] Diagnostic: package org.evosuite.runtime.vnet does not exist: 21
[ERROR] Diagnostic: package org.evosuite.runtime.thread does not exist: 25
[ERROR] Diagnostic: cannot find symbol
  symbol:   class Test
  location: class org.apache.commons.lang.text.StrBuilder_0_tmp__ESTest: 19
[ERROR] Diagnostic: package org.junit does not exist: 20
[ERROR] Diagnostic: cannot find symbol
  symbol:   class BeforeClass
  location: class org.apache.commons.lang.text.StrBuilder_0_tmp__ESTest_scaffolding: 28
[ERROR] Diagnostic: cannot find symbol
  symbol:   class AfterClass
  location: class org.apache.commons.lang.text.StrBuilder_0_tmp__ESTest_scaffolding: 43
[ERROR] Diagnostic: cannot find symbol
  symbol:   class Before
  location: class org.apache.commons.lang.text.StrBuilder_0_tmp__ESTest_scaffolding: 49
[ERROR] Diagnostic: cannot find symbol
  symbol:   class After
  location: class org.apache.commons.lang.text.StrBuilder_0_tmp__ESTest_scaffolding: 61
[ERROR] Diagnostic: package org.evosuite.runtime.vnet does not exist: 21
[ERROR] Diagnostic: package org.evosuite.runtime.thread does not exist: 25
[ERROR] Diagnostic: package org.evosuite.runtime.thread does not exist: 25
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 30
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 31
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 32
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 33
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 34
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 35
[ERROR] Diagnostic: package org.evosuite.runtime.sandbox.Sandbox does not exist: 35
[ERROR] Diagnostic: package org.evosuite.runtime.sandbox does not exist: 36
[ERROR] Diagnostic: package org.evosuite.runtime.classhandling does not exist: 37
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 40
[ERROR] Diagnostic: cannot find symbol
  symbol:   variable Sandbox
  location: class org.apache.commons.lang.text.StrBuilder_0_tmp__ESTest_scaffolding: 45
[ERROR] Diagnostic: package org.evosuite.runtime.jvm does not exist: 53
[ERROR] Diagnostic: package org.evosuite.runtime.sandbox does not exist: 54
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 56
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 57
[ERROR] Diagnostic: package org.evosuite.runtime.agent does not exist: 58
[ERROR] Diagnostic: package org.evosuite.runtime.jvm does not exist: 64
[ERROR] Diagnostic: package org.evosuite.runtime.classhandling does not exist: 65
[ERROR] Diagnostic: package org.evosuite.runtime.sandbox does not exist: 67
[ERROR] Diagnostic: package org.evosuite.runtime.agent does not exist: 68
[ERROR] Diagnostic: package org.evosuite.runtime does not exist: 69
[ERROR] Diagnostic: package org.evosuite.runtime.classhandling does not exist: 86
[ERROR] Diagnostic: package org.evosuite.runtime.classhandling does not exist: 104
[ERROR] Diagnostic: package org.evosuite.runtime.classhandling does not exist: 106
[ERROR] Diagnostic: cannot find symbol
  symbol:   method fail(java.lang.String)
  location: class org.apache.commons.lang.text.StrBuilder_0_tmp__ESTest: 25
[ERROR] Diagnostic: cannot find symbol
  symbol:   method verifyException(java.lang.String,java.lang.NullPointerException)
  location: class org.apache.commons.lang.text.StrBuilder_0_tmp__ESTest: 31
[ERROR] RegularFileObject[/var/folders/t4/0qd1kfm97tz9g17z439t2gmm0000gn/T/EvoSuite_0_1548688017004/org/apache/commons/lang/text/StrBuilder_0_tmp__ESTest.java]

This error happens only in the maven plugin. It seems that the passed classpaths to botsing is not right.

With the latest botsing-maven 1.0.5-SNAPSHOT this problem has been gone.


internal/graphicsdriver/opengl: creating framebuffer fails w/ an error 36054 on OpenGL

Ebitengine Version
760e6b9ebd228554bed191410ce47d8a93a329dd
Operating System

[X] Windows
[ ] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
1.19.1
What steps will reproduce the problem?
One of my players' game is unexpectedly closing during playing (and at random time) with error:
opengl: creating framebuffer failed: 36054.
She claims that she's using DirectX but the error seems to be opengl related so probably ebitengine decided that fallback from directx is necessary. She also claims that the error is random. Sometimes it's once per day, sometimes its 4 times per day.
dxdiag:

What is the expected result?
ebiten.RunGame does not throw an error, and maybe no fallback from DirectX to OpenGL
What happens instead?
ebiten.RunGame throws an error
Anything else you feel useful to add?
No response

She claims that she's using DirectX but the error seems to be opengl related so probably ebitengine decided that fallback from directx is necessary. She also claims that the error is random. Sometimes it's once per day, sometimes its 4 times per day.

As the feature level 12 is not supported, Ebitengine should use OpenGL in this machine.

Can we please do something about it? There are lots and lots of players who for various reasons are unable to reach such feature level and I absolutely hate to tell people that despite having 2d pixel game they are unable to play it.

You can choose feature level by setting an environment variable EBITENGINE_DIRECTX_FEATURE_LEVEL=11_0 (https://github.com/hajimehoshi/ebiten/issues/2466) to force to use DirectX.

Can we please do something about it?

Unfortunately I cannot guarantee that I can fix this issue.

Again with the env variables? What should I do? Check in the game "if dx12 feature level < 12 then set env to 11_0"? That sounds truly ridiculous to make the game creator responsible for such things

Again with the env variables? What should I do? Check in the game "if dx12 feature level < 12 then set env to 11_0"? That sounds truly ridiculous to make the game creator responsible for such things

Yes, again. You can set the variable in your program as you have already done for EBITENGINE_GRAPHICS_LIBRARY.
I plan to add RunGamWithOptions but please wait for it.

That sounds truly ridiculous to make the game creator responsible for such things

:-/

It's not "configuring the graphics library" you are talking about, it's "disabling the primary graphics library by default to many users and if you want to enable it set the env variable but you can't be really sure if the lib is actually available or not" thing.
I'm kinda upset because I was alarming so, so, sooo many times about usability of adding explicit and easy option to set the graphics library and you was so against it "because ebitengine should know better". And now I'm hearing that the same ebitengine is disabling directx for players who actually have compatible dx but with lower feature level, and ebitengine could work on such machine but just decided not to. This results in players with decent machines not being able to play AT ALL because ebitengine in it's smartness decided that there is no compatible game library (unless you, the game creator who should not touch such configs decide, via env variable for some reason, that ebitengine should use featurelevel 11 instead of 12).
On one hand you are strongly in favor of not touching such settings and letting ebitengine decide, and I don't agree with that but I was able to tolerate it as long as players were able to play. But the current state is "I as a game dev must explicitly set the dx featurelevel and kinda guess which featurelevel is available on given machine or otherwise players may not be able to play my game", and that's ridiculous.
RunGameWithOptions is an absolute must in current situation where ebitengine can be clearly wrong.
What I would like to be able to do is to specify which lib should be used first (directx/opengl), and if that primary lib is not available for some reason then fallback to the other lib (so that player can decide whether to use dx or opengl, and if his/her lib of choice is not available then silently fallback to the other). And I would like to not care about dx featurelevels. If player decided to use DirectX and has compatible dx that can be handled by ebitengine and if the game actually executes on dx, he/she should be able to play on that dx, regardless of version or/and featurelevels. If ebitengine supports it it should support run it.

By the way, in general, this error causes due to short of memory. My guess is that your game makes too many images or framebuffers. You can check this with -tags=ebitenginedebug.

I'm kinda upset because I was alarming so, so, sooo many times about usability of adding explicit and easy option to set the graphics library and you was so against it "because ebitengine should know better".

 Without them, I was not sure what is right.
I'll be working on this later, but I don't have infinite bandwidth unfortunately. Do not forget that this is just an OSS made with my spare time, not a commercial ware.

And now I'm hearing that the same ebitengine is disabling directx for players who actually have compatible dx but with lower feature level, and ebitengine could work on such machine but just decided not to. This results in players with decent machines not being able to play AT ALL because ebitengine in it's smartness decided that there is no compatible game library (unless you, the game creator who should not touch such configs decide, via env variable for some reason, that ebitengine should use featurelevel 11 instead of 12).

Actually there is a machine that DirectX doesn't work well with the feature level 11. (https://github.com/hajimehoshi/ebiten/issues/2447) Do you have any other suggestion to fix #2447 and this issue at the same time? I think giving an option to configure this is the best way so far.

What I would like to be able to do is to specify which lib should be used first (directx/opengl), and if that primary lib is not available for some reason then fallback to the other lib (so that player can decide whether to use dx or opengl, and if his/her lib of choice is not available then silently fallback to the other). And I would like to not care about dx featurelevels.

The problem is that a problem can occur AFTER the graphics library (and its feature level) is determined and initialization itself succeeds. In this case, we cannot fallback to other libraries. This OpenGL issue is actually the case.

What about leaving EBITENGINE_DIRECTX_FEATURE_LEVEL for special cases like #2447, but when this env is not set then just use latest available feature level instead of hardlocking on 12_0 and disallow any other?

What about leaving EBITENGINE_DIRECTX_FEATURE_LEVEL for special cases like https://github.com/hajimehoshi/ebiten/issues/2447, but when this env is not set then just use latest available feature level instead of hardlocking on 12_0 and disallow any other?

I was just thinking about that. This might make sense. Actually when #2447 was fixed, I fixed #2459 at the same time, so I'm not 100% confident #2447 was the true fix for their machine. OK, I'm fine to change the default to 11_0.

So, thought the OpenGL issue is not fixed (I don't think this is fixable), was your issue resolved by using the feature level 11?

I can't really tell because I don't really have contact with this player anymore

That's unfortunate.
I'll mark this issue as fixed as there is no action item I can take.
I recommend checking how many images (textures) are used in your game. My guess is a little too many.

As #2581 was fixed, the situation might be improved.


Sinabs dynapcnn doc refractor

Moved hardware tutorials to the top.
Moved instructions for adding support for new chip to FAQ.

Looks good! I fixed a few typos.


Remove version: key from docker-compose files, fixes #3067

The Problem/Issue/Bug:
#3067: docker-compose no longer requires the version: key in compose config files, and it has always been a bit of a mess.
How this PR Solves The Problem:
Remove these things
Manual Testing Instructions:
If it passes testing it should be OK.
Automated Testing Overview:
No changes
Release/Deployment notes:
This has dramatic changes:

Everything on ddev-contrib will have to be updated
The minimum docker-compose version (of the tool) will have to be changed
Docs will need updating (I think; this may already do enough)

I don't think we'll be able to do this.
Per https://docs.docker.com/compose/compose-file/

The latest Compose file format is defined by the Compose Specification and is implemented by Docker Compose 1.27.0+

Unfortunately Ubuntu 20.04 has 1.25 by default, Debian 10 will be lower than that I think.
The motivation here was to lose the version field and let it go, but there are too many old docker-compose things out there.
It would be safe, though, to move to docker-compose config version 3.7 instead of 3.6. It would just break a lot of custom configs.

I won't try this for at least a year as it would require so many users, especially Linux users, to update docker-compose


Add retry limit

In our team it would be preferred to limit the retries to a certain number.
Describe the solution you'd like
We would need two new variables in the Actor class. The variable maxRetries should be overridable.
Integer retryNumber = 0
Integer maxRetries = 0
Currently in the Actor.class the check looks like this:
  if (question.acceptable(lastAnswer)) {           reporters.forEach(reporter -> reporter.success(this, question, answer));           return answer;         }
It would need to be replaced by a wrapper function:

if (question.acceptableWrapper(lastAnswer)) {   reporters.forEach(reporter -> reporter.success(this, question, answer));   return answer; }
default boolean acceptableWrapper(A answer){ if(maxTries!=0 && retryNumber>maxRetries) return answer tryNumber++ acceptable(answer) }
We currently use our own code to do the same. This would be a cleaner approach and it adds a valuable feature to the framework.

Thanks for the suggestion.
Currently there's already a way to customize the number of retries by setting a timeout in your RetryableTask or RetryableQuestion. It is used here in the Actor's check(RetryableQuestion) method to calculate at what time the timeout is reached.
The default timeout is 2 seconds (see here in Retryable).
It is now not clear to me what you want to achieve.

Is it the default of 2 seconds that you'd like to change to something else (e.g. 20 seconds), or
do want to set the number of retries instead of the timeout/interval?

The idea is to be able to set a maximum amount retries.
The proposed solution would give the option to choose whether to use a time based retry or an amount based retry behavior.


Add update object metadata API

This is an experimental feature.  When reviewing please comment about its usability, but focus mainly on correctness.
The code in the controller re-uses an existing physical address, which is supposedly a no-no.  However this case is fine: the physical address is used by the same object being updated.  So the only way for UGC to remove it would be to lose these races:

Thread 1 gets object metadata
Thread 2 deletes the object
👉🏽  Thread 3 performs UGC and cleans up the physical object
Thread 1 writes a new entry for the object with the same physical address
Thread 3 is UGC so it only cleans up objects that were abandoned several hours ago.  Our UGC model allows us to lose the object in this (extreme) case - this is not a new lossage.

Fixes #8251.

@ozkatz for API
(@N-o-Z for API and correctness and code and ..., of course)

@guy-har please review as I missed @N-o-Z' working hours 😭


Remove leading forward-slash for things in the 'core' group

Description
For objects/resources that are in the "core" group, the correct GVK to reference in the tracer config file is /v1.Node, for example (with the forward slash).  I don't think this is a great UX, and would like to change this.
Relates to #62

Fixed in #143


Update Avoiding obstacles Milestone

Review Avoiding obstacles milestone definition, functional and non-functional requirements and update if needed.

Included in this task
I close it to avoid duplicates


rename get_parent_elements to get_parent_symbols

Pull Request Test Coverage Report for Build 159

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 157:
0.0%

Covered Lines:
0

Relevant Lines:
7182

💛  - Coveralls

Depends on https://github.com/pyiron/pyiron_atomistics/pull/26


Manually Correct Matching Algorithm

Changes in this PR:
This PR adds the ability to manually correct the matching algorithm through the use of whitelist and blacklist files. After the linking algorithm has ran and stored all the resulting endpoint to npi organization links, the algorithm then runs a function that uses the whitelist and blacklist files to manually add/delete links from the database. The whitelist file (linkerMatchesWhitelist.json) and the blacklist file (linkerMatchesBlacklist.json) can both be found in the resources/prod_resources directory, and the files are mounted to the endpoint manager docker container among startup. The format for these files can be found in the endpoint manager README file, but for now the files have been left empty.
TO TEST:
To manually test the whitelist and blacklist functionality, add any endpoint to npi organization links that you want to add/remove from the database to the whitelist/blacklist files found in the resources/prod_resources directory following the format shown in the endpoint manager README. Any link added to the whitelist file will be added to the endpoint_organization table in the database, and any link added to the blacklist file will be removed from the endpoint_organization table in the database.
Pull requests into this repository require the following checks to be completed by the submitter and reviewers.
Submitter:

[x] Administrative tasks are complete.

This pull request describes why these changes were made.
The JIRA ticket links to this PR.
The JIRA ticket for this PR is: Lantern 250 JIRA Ticket

[x] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

[x] Code review has been performed.

Code diff has been done and checked to ensure only expected code is being committed.
A linter for the language has been run.

Primary Reviewer:

[ ] Code works.

Code has been run locally and the basic functionality affected by the PR has been checked.
Edge cases have been checked to ensure behavior is as expected.

[ ] Code review has been performed.

Code is maintainable, reusable, efficient, and correct.
Code accomplishes the tasks purpose.
Code follows style guidance appropriate for the language, including passing linter checks.
Code is well commented (which does not mean verbosely commented).

[ ] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

Secondary Reviewer:

[ ] Code works.

Code has been run locally and the basic functionality affected by the PR has been checked.
Edge cases have been checked to ensure behavior is as expected.

[x] Code review has been performed.

Code accomplishes the tasks purpose.

[x] Tests are complete.

Tests have been run locally and pass.

Merger:
Prior to merging, ensure that all checks have been completed. Delete the branch after the merge
is complete.
Create a new branch <branch name>_gomodupdate. Run make update_mods to update the go.mod
and go.sum files to point to master. Create a PR. Require one sanity check reviewer.

I tried running make populatedb with nothing in the whitelist/blacklist files and i got the error signal: killed. i assume it has something to do with reading an empty file (either that or something is wrong with my setup). it seems like it would be a good idea to check whether a file is empty or not (if that's possible) while we currently don't have any real data to run with?

Bri, I must have deleted the line to check for that when I was making changes, I will fix that now

Two things I noticed while running:

If a URL is in the whitelist with a given organization id, it adds it to the endpoint_organization table with no problem, but it doesn't remove any of the other ids that were matched to that URL. My initial thought was that all other matches would be removed if we have a confirmed match; is there a reason why we keep those other matches around?
For some reason it seems like if I try to run make populatedb twice, the first time it works fine, but the second time it gets to the linker and then seems to time out or something because it sits there for like 30 seconds and then all I get is a signal: killed error. Have you seen this/any ideas why this might be happening?

In regards to your first point, I asked Matt about this, and he said that users can specify additions and deletions, so if they ask for a link to be added, then we can add that to the whitelist, and then we can ask them if they want any of the existing links to be removed and add those to the blacklist.
In regards to your second point, I have not noticed that, but I will take a look at it now!

In regards to your first point, I asked Matt about this, and he said that users can specify additions and deletions, so if they ask for a link to be added, then we can add that to the whitelist, and then we can ask them if they want any of the existing links to be removed and add those to the blacklist.

Okay that makes sense, thanks for the clarification!

I was just messing around with this again to see if I was still seeing that same problem, and I found out a little more information:

Every time I ran make run I didn't have a problem with the endpointlinker initially. If the linkMatchesWhitelist file stayed the same every time I ran make populatedb then it worked fine. As soon as I changed linkMatchesWhitelist it would break and wouldn't work even if I changed it back to the original file. Stopping everything and running make run again seems to fix it, so I'm wondering if it has something to do with the files being mounted as volumes?
It seemed to specifically break around the ioutil.ReadAll(jsonFile) in the openLinkerCorrectionFiles function, or at least when i was using print statements it would get to the point before that call, hang for 30+ seconds, then throw the signal: killed error.
If this is just because I'm not supposed to be editing files that are mounted without restarting the container then I guess we don't have to worry about this and I can approve it! If it's something else though, and you're not seeing this error, I guess it's just something weird happening with my computer...

I was just messing around with this again to see if I was still seeing that same problem, and I found out a little more information:

Every time I ran make run I didn't have a problem with the endpointlinker initially. If the linkMatchesWhitelist file stayed the same every time I ran make populatedb then it worked fine. As soon as I changed linkMatchesWhitelist it would break and wouldn't work even if I changed it back to the original file. Stopping everything and running make run again seems to fix it, so I'm wondering if it has something to do with the files being mounted as volumes?
It seemed to specifically break around the ioutil.ReadAll(jsonFile) in the openLinkerCorrectionFiles function, or at least when i was using print statements it would get to the point before that call, hang for 30+ seconds, then throw the signal: killed error.

If this is just because I'm not supposed to be editing files that are mounted without restarting the container then I guess we don't have to worry about this and I can approve it! If it's something else though, and you're not seeing this error, I guess it's just something weird happening with my computer...

I also get this same error, but from doing some research, I have found that If you are using some editors, like vim for example and possibly visual studio, when you save the file it does not save the file directly, but it instead creates a new file and copies it into its place. This breaks the bind-mount of the docker container, which is based on inode, which I researched and inode is a data structure in a Unix-style file system that describes a file-system object. Since saving the file, then, is changing the inode, and this is what may be causing that error we are seeing. When the container is restarted, this creates a new inode, which explains why it would work after restarting the container. Therefore I think this is an unavoidable error that can be avoided by just not chaning mounted files without restarting the container, but if you guys find this is not the case, I am happy to talk about it and try to fix the issue!


Style piggybank mc chip

This replaces https://github.com/cosmicds/hubbleds/pull/434 which had an unnecessarily complicated history for basically 1 new commit.

Oops, meant to commit this to cosmicds org, not this fork.


Trezor - The modal is not loading the addresses when connecting to the app

Title/Description

Environment

Browser: Chrome
OS: Win10 64bits (latest update)
Safe:
Wallet: Trezor One
App Version: 2.16 / 2.15
Environment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app/#/
https://safe-team.dev.gnosisdev.com/app/#/welcome

dev (rinkeby)
staging (rinkeby)
production (mainnet)
PR #

Steps to reproduce

1 - Connect with Trezor
2 - Once connected a modal shows up to pick an address  from a dropdown
Expected result

It shows all the address the trezor has available to choose
Obtained result

The dropdown is empty, is not loading any address.
No error show up in the console
Additional Notes:
Is possible to Import it the account to the MM extension to sign from there
Screenshots

Marking as critical just for the record. I know we discussed on slack already reasons. I think we shouldn't release with this bug.

A rollback of bnc-onboard dependency solved this issue.
There is an open issue discussing this in Blocknative repos


Add a jenkins job to clear the frontend caches

This is intended to be used as a downstream task for the emergency publishing.
Part of improvements during a emergency publishing drill: https://trello.com/c/ktLcZLIN

Realised that this doesn't actually work because it will only clear the cache for Rails running on a single machine, at least if the app is using file store or memcached. I'm doubly unsure how this works if the application uses memory store (I think it might only clear the cache for the rails console process).

Yeah that could work but I'm still not sure about the in-memory cache in those cases. And we would be recreating fabric :)

true, suppose we could use fabric in this script. I kinda liked that this could be a dependant job of the emergency publishing rake task. Not too much of a biggie though.


Test DSL improvements (PLT-5528, PLT-5559, PLT-5617, PLT-5836)

Adds test reporting to a file or json stream (log file contains test execution logs, interpreter state, failure information etc.).
improves syntax for the DSL - dropped tag fields, dropped field prefixes etc.
Implements resource management and concurrent test execution mode which estimates budget for the faucets and runs the tests in parallel.
Adds withdrawal support to the runtime testing operations + pooc role based test to test this feature.
Fixes some threadDelays which I messed up in the marlowe-apps.

Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[ ] Test report is updated (if relevant)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description

Review required
[ ] Substantial changes to code, test, or documentation
[ ] Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
Review not required
[ ] Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
[ ] Formatting, spelling, grammar, or reorganization

[ ] Reviewer requested

Builds locally for me, merging

Thanks!


Add litgpt evaluate command

This adds the litgpt evaluate command along with a wrapper function that allows someone to evaluate models without needing to convert or copy anything manually. I.e., it's just
litgpt finetune lora \
  --checkpoint_dir checkpoints/microsoft/phi-2 \
  --out_dir lora_model

litgpt evaluate \
  --checkpoint_dir lora_model/final \
  --out_dir evaluate_model/ \

Fixes #1168

One question is how to add the tests @carmocca because I assume it's very expensive. One could probably test
it on the smallest phi-2 model and on a small number of examples e.g.
litgpt evaluate \
  --checkpoint_dir checkpoints/EleutherAI/pythia-14m/ \
  --out_dir out/ \
  --repo_id EleutherAI/pythia-14m \
  --limit 10 \
  --tasks "hellaswag"

Still, I don't know if the CI will be able to handle it. I am also not sure if there's a good way to mock this.

@rasbt I think you should be able to update the tests in https://github.com/Lightning-AI/litgpt/blob/main/tests/test_lm_eval_harness.py#L30. In fact we might want to remove the existing eval implementation

Thanks, I hope the test I added suffices

Thanks for all the feedback. These were all great suggestions!
The latest updates include

Make checkpoint_dir a required argument
Set default output_dir as checkpoint_dir/evaluate
Moved evalute.py out of litgpt/scripts
Automatically infer the repo_id from the config file

Question 1:  Should we make output_dir the same as checkpoint_dir by default (evaluate will save the converted model + results.json)?
Question 2: I moved it to litgpt/eval/evaluate.py. Since it's a single module, we could also just make it litgpt/evaluate.py and remove the `eval subfolder. Wdyt?

I reverted it back to the previous version which worked. Sure, it might save the possibly redundant .safetensors intermediate file, but I think we need to get this PR merged as soon as possible so users can evaluate models. We can see if we can avoid this temporary file in the future as an efficiency optimization. It would not affect the user API so there shouldn't be a problem deferring this to the future.

Phew, finally got the test to work. It should be ready to review (and hopefully merge). If you have a moment, I'd appreciate your feedback @awaelchli & @carmocca

I'm trying this out locally but It fails for me on:

Hm, weird, it works fine for me locally. Let me try in a fresh environment, maybe it's an lm_eval version issue

I totally messed up the rebasing, sry

Do you have a backup of the state? It seems like you overwrote most of the previous changes. If not, I should have one. I can force push it again
I would suggest not using rebase inside PRs since it's easier to merge and the commits will be squashed anyways when the PR lands

If you have a backup, that would be safer and nice. I don't know what happened, have done this successfully several times before, but I must have totally messed something up

Done. You'll need to redo any of the last commits you did before your force merge. I think this was only a "cleanup evaluation docs" removing one section

Done. You'll need to redo any of the last commits you did before your force merge. I think this was only a "cleanup evaluation docs" removing one section

Thanks a lot!! And done!!
Actually, I rewrote that part regading --force conversion in the docs, because if users don't know about it, there can be a common gotcha where people update a checkpoint but find that it has the same evaluation performance as before due to the litgpt temp files.


apple add malloc_zone_t definition for x86_64 only.

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit caa06fac88de992990b481205707a1e167939e3c has been approved by Amanieu

:hourglass: Testing commit caa06fac88de992990b481205707a1e167939e3c with merge 3e328bd55e37bbedc9e8540dd14139ce05cf556e...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 3e328bd55e37bbedc9e8540dd14139ce05cf556e to master...


Eazfuscator.net 2023.1 How to reset 30 days?

I installed eazfuscator.net 2023.1, but I modified the system time when I test other programs today, which caused the assessment of expiration cannot be used when opening Eazfuscator.net. In fact, I did n’t use it for less than 7 days. No matter how I delete all about EAZFUSCATOR about EAZFUSCATORThe files with Gapotchenko, including the registry information, cannot restore the 30 -day evaluation and trial. Is there any other way?I originally wanted to buy genuine, but helplessly I had no international credit card and could not pay.Hope to get your reply.
Thank you.

Did you find a solution?

Did you find a solution?

No, I have purchased a legitimate license. For long-term use, I don't want to spend too much time on these unnecessary things, so I bought the genuine version.

At the moment you can just delete the files generated by Eaz and redownload, but this does require a lot of work. I'm planning to work on an open-source fix for this issue soon, though. I'll keep this issue open just for that reason.

Bumping this just wondering if you ever did get a work around to the 30 day time limit.


[Prover] issues with pairs in spec

How to reproduce
Run Prover with the following example:
module 0x42::let_pair {

    spec fun spec_g(): (bool, bool) {
        (true, false) // this works.
    }

    spec fun spec_f(): (u64, bool) {
        (42 , true) // this doesn't work. [1]
    }

    fun f(): (u64, bool) {
        (42, true)
    }
    spec f {
        let (b1, b2) = spec_g(); // this doesn't work [2].

        let p = spec_f(); // this doesn't work either. [3]

        let p2 = (42, true); // this doesn't work either. [4]

        ensures result == (42, true); // it's expected that this doesn't work. However, this feature may be useful. [5]
        ensures result_1 == 42;
        ensures result_2 == true;
    }
}

Prover's output for [1]:
error: expected `u64` but found `u256` in expression list
  ┌─ ./sources/let_pair.move:8:9
  │
8 │         (42 , true) // this doesn't work. [1]
  │         ^^^^^^^^^^^

Even the expression (42 as u64) doesn't work because the spec language doesn't support the type conversion.
(42 as u64) works in spec in upstream/main.
Prover's output for [2]:
error: unexpected token
   ┌─ ./sources/let_pair.move:15:13
   │
15 │         let (b1, b2) = spec_g(); // this doesn't work [2].
   │             ^
   │             │
   │             Unexpected '('
   │             Expected an identifier

It seems that destructing a pair is not supported in the spec lang. This issue is blocking the spec work because working around this is very difficult and combersome.
Prover's output for [3]:
error: [boogie translator] function or tuple result type not yet supported
   ┌─ ./sources/let_pair.move:7:10
   │
 7 │       spec fun spec_f(): (u64, bool) {
   │ ╭──────────^
 8 │ │         //(42, true) // this doesn't work. [1]
 9 │ │         ((42 as u64), true) // this is a workaround.
10 │ │     }
   │ ╰─────^

Error: exiting with condition generation errors

Prover's output for [4]:
error: [boogie translator] Tuple not yet supported
   ┌─ ./sources/let_pair.move:20:18
   │
20 │         let p2 = (42, true);
   │                  ^^^^^^^^^^

Error: exiting with condition generation errors

Prover's output for [5]:
error: undeclared `let_pair::result`
   ┌─ ./sources/let_pair.move:17:17
   │
17 │         ensures result == (42, true); // this doesn't work. expected. [3]
   │

Actually, this error is expected. However, it would very useful to support this because we may often want to specify something like this:
ensures result == spec_f();

Note that both sides are pairs not single values.

@rahxephon89 , I've added two more cases where the tuple fails.

I think this works as designed:

we do not support let (...) or let S{...} in spec blocks. The workaround is to use field selection (s.0). Adding this to the spec language would be very hard, and since there is a workaround, not needed
type inference is not always perfect. So instead of 42 one should use 42u4. We can perhaps add a seperate issue for type inference.
tuples are not value in Move -- unfortunately. You can't ever use something like (x, y) == f().


Is end time exclusive for Spike alert?

Hi, is "end" timestamp exclusive for Spike alert?
If I run the following elastalert with type of Spike, and timeframe = 1hour
elastalert --config /etc/elasticsearch/elastalert.yml --rule my_rule.yaml --start 2016-05-30T00:00:00 --end 2016-05-30T02:00:00
I didn't get any match.
But if I change the end time to 2016-05-30T02:01:00 I will get a match since there are several hits right on 2016-05-30T02:00:00. So I'm wondering if the end time is exclusive.
Thanks!

The query itself IS inclusive of the endtime (https://github.com/Yelp/elastalert/blob/master/elastalert/elastalert.py#L220)
For the spike rule, it looks like it is exclusive (https://github.com/Yelp/elastalert/blob/master/elastalert/ruletypes.py#L371)
Basically, the time between the first event and the one that might trigger an alert must be greater than 2x the timeframe. The first event "resets" after each alert. There are some other exceptions, like if you are using query_key + alert_on_new_data.
I'm not sure if there is any reason for it to be exclusive and not inclusive. I think have the comparison be <= instead of < would be ok.

Thank you for your answer!


Update characteristic.dart

fix：CharacteristicType.bloodType or CharacteristicType.fitzpatrickSkinType was not authorized just now, the result of parsing failed
Status
READY/IN DEVELOPMENT/HOLD
Migrations
YES | NO
Description
A few sentences describing the overall goals of the pull request's commits.
Related PRs
List related PRs against other branches:
branch	PR
other_pr_production	link
other_pr_master	link
Todos
Tests
Documentation
Deploy Notes
Notes regarding deployment the contained body of work. These should note any db migrations, etc.
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
git pull --prune
git checkout <feature_branch>
Impacted Areas in Application
Small description about what will be changed in the app if this PR will be merged
List general components of the application that this PR will affect:
The direct changes inside the app made by this PR

Hi @fe-one,
thank you for your PR.
I would suggest not just simply put "na" as a default value, since in HealthKit it is actually a value for the case "notSet".
Instead you could try to refactor "from" methods for FitzpatrickSkinTypeFactory, BloodTypeFactory, BiologicalSexFactory not to throw InvalidValueException, but return "null" instead.
This will avoid the return from the "Characteristic.fromJson" constructor if any of the properties would throw an error by creating them using "from" method.
static BiologicalSex? from(String string) {     switch (string) {       case 'na':         return BiologicalSex.notSet;       case 'Female':         return BiologicalSex.female;       case 'Male':         return BiologicalSex.male;       case 'Other':         return BiologicalSex.other;       default:         return null;     }   }
I would also encourage you to write a unit test for parsing Characteristics with these factories (I would provide unit testing for other types as well, didn't have much free time though)