[PackageEvaluator.jl] Your package HDFS may have a testing issue.

This issue is being filed by a script, but if you reply, I will see it.
PackageEvaluator.jl is a script that runs nightly. It attempts to load all Julia packages and run their test (if available) on both the stable version of Julia (0.2) and the nightly build of the unstable version (0.3).
The results of this script are used to generate a package listing enhanced with testing results.
The status of this package, HDFS, on...

Julia 0.2 is 'No tests, but package loads.'
Julia 0.3 is 'No tests, but package loads.'

'No tests, but package loads.' can be due to their being no tests (you should write some if you can!) but can also be due to PackageEvaluator not being able to find your tests. Consider adding a test/runtests.jl file.
'Package doesn't load.' is the worst-case scenario. Sometimes this arises because your package doesn't have BinDeps support, or needs something that can't be installed with BinDeps. If this is the case for your package, please file an issue and an exception can be made so your package will not be tested.
This automatically filed issue is a one-off message. Starting soon, issues will only be filed when the testing status of your package changes in a negative direction (gets worse). If you'd like to opt-out of these status-change messages, reply to this message.

closing as outdated


[SPARK-47839][SQL] Fix aggregate bug in RewriteWithExpression

What changes were proposed in this pull request?

Fixes a bug where RewriteWithExpression can rewrite an Aggregate into an invalid one. The fix is done by separating out the "result expressions" from the "aggregate expressions" in the Aggregate node, and rewriting them separately.
Some QOL improvements around With:

Fix aliases created by With expression to use the CommonExpressionId to avoid duplicate aliases (added a conf to fall back to old behaviour, which is useful to keep the IDs consistent for golden files tests)
Implemented QueryPlan.transformUpWithSubqueriesAndPruning that the new logic depends on

Why are the changes needed?

See JIRA ticket for more details on the bug that this fixes.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Added new unit tests.
Was this patch authored or co-authored using generative AI tooling?

No.

cc @cloud-fan @jchen5

The test fails: org.apache.spark.sql.connect.ProtoToParsedPlanTestSuite

thanks, merging to master!


"No books added" message do not appear to the user if they start a new

Issue :
You've done very well so far However there might be some tricks to be added to make the UX feel better.
The "No books added" appears only when the user adds and removes an element.
to fix that add :
(!localStorage.getItem('booksData')) to the condition of creation of that message
if (convertedBooks && convertedBooks.length === 0 && !localStorage.getItem('booksData') ) {
document.getElementById('bookstatus').innerHTML = 'No books added';
Optional :
- Avoid using  => use border bottom for example instead;
- style the h2 tags to follow the design (they are bold)

Hello @AmineHLub,
We appreciate your feedback.

The issues have been fixed.


problems with restricted covariances

I see recurring problems when trying covariances different than "full", that is diag, spherical etc.
The code to reproduce
from smm import SMM
from sklearn import datasets
data = datasets.load_iris()
X,y = data.data.astype('float32'), data.target.astype('int32')
#X = (X-X.mean(0))/X.std(0)
n_classes = len(np.unique(y))
SMM(n_classes,covariance_type='diag').fit(X).predict(X)
Errors: RuntimeWarning: Failed to converge after 1000 iterations, value is nan

Hi Maciej, thanks for providing this feedback, I will have a look to it.


As a new user I can view more information about a particular command

so that I can learn how to use various commands.

done in #103


Remove GPU Types from github

Signed-off-by: Peixin Li<EMAIL_ADDRESS>We were told the internal GPU_TYPES used in pipelines should not be exposed on Github, even types are public-released.
FYI
GPU_TYPES is saved as a secret w/ value like [GPU_TYPE_1,GPU_TYPE_2...] on jenkins

build

build

build

build


Split up obsidian-ex.d.ts into separate files

Request from Discord, looking for opinions.
Currently the typings file is 5000 lines long, and isn't particularly easy to navigate through without dedicated search tools. It would be interesting to split up the typings file into logical chunks for easier lookup.
There are several ways this could be done.
First, how the divisions should be made:

Split up according to inheritance, everything related to View, Editor, Plugin should be separated into individual files
Split up according to type of functionality (all modals, all metadata, all workspace-related, etc.)
...

Second, whether the distributed typings (i.e. npm package) should bundle all these separate files together (so you can still search through a single obsidian-ex.d.ts file), or whether they should stay separated.

@Fevol that's a brilliant idea! It would be helpful if you add the link to the Discord discussion to follow up.
Here is my input

Extract into individual files matching the augmented interfaces. Such as obsidian/App.d.ts and @codemirror__view/EditorView.d.ts (double underscore __ is a standard convention to replace slash /) etc.
Don't put into declare module "..." axillary helpers that are not declared in the original module. For example, don't do

declare module "obsidian" {
    interface InternalPlugins {}
}

because https://github.com/obsidianmd/obsidian-api/blob/master/obsidian.d.ts doesn't define InternalPlugins
This helps to prevent confusion for the client code that can do
import { InternalPlugins } from "obsidian";

which is confusing. I think forcing
import { InternalPlugins } from "obsidian-typings";

has much clearer intent

I see no added value for the gigantic single obsidian-ex.d.ts file

There isn't any discussion to link to, @4Source brought it up in a DM.

Extract into individual files matching the augmented interfaces. Such as obsidian/App.d.ts and @codemirror__view/EditorView.d.ts (double underscore __ is a standard convention to replace slash /) etc.

That sounds good!

Don't put into declare module "..." axillary helpers that are not declared in the original module. For example, don't do (...)

Agreed.

I see no added value for the gigantic single obsidian-ex.d.ts file

Since the package is usually installed in node_modules, it is usually excluded in the IDE search functionality. So if I for instance want to look for a specific class inside the typings, it is much easier to look through a single obsidian-ex.d.ts file than searching through each individual file. But that might also be something I can configure.

We should also make not only typings .d.ts but add some useful implementations in .ts, for example, CustomArrayDict interface would be useful with the sample implementation, for example https://github.com/mnaoumov/obsidian-backlink-cache/blob/master/src/CustomArrayDictImpl.ts

That's fine for me! I wonder if things like EmbeddableEditor would fit here too; or even further: some useful developer functions. I'm not sure if this should be included into this package, or be branched off into its own package (e.g. obsidian-dev-utils)

@Fevol as I already started drafting the PR for this issue I can provide more reasonable feedback

if I for instance want to look for a specific class inside the typings

If you already know the type you want to augment, the navigation is pretty easy

However, it seems that ChatGPT also into the gigantic one https://chatgpt.com/share/ba7a7d40-80cf-4aa5-8543-aac20848c8ef

I'm not sure if this should be included into this package, or be branched off into its own package (e.g. obsidian-dev-utils)

I think the basic implementations of the interfaces is a good fit for this package. But the examples you provided are more suitable for the separate obsidian-dev-utils package. That would be an amazing package for general purpose helpers. I have tons of useful code snippets I use in my own plugins and scripts that other plugin developers could take advantage of.

We should also make not only typings .d.ts but add some useful implementations in .ts, for example, CustomArrayDict interface would be useful with the sample implementation, for example https://github.com/mnaoumov/obsidian-backlink-cache/blob/master/src/CustomArrayDictImpl.ts

I think this might be confusing since the project is called obsidain-TYPINGS and adding additional features should be done separately in my opinion

I think the basic implementations of the interfaces is a good fit for this package. But the examples you provided are more suitable for the separate obsidian-dev-utils package. That would be an amazing package for general purpose helpers. I have tons of useful code snippets I use in my own plugins and scripts that other plugin developers could take advantage of.

This would be a better fit in my opinion.


Feature: add batch size guc for vector and pax extension.

fix #ISSUE_Number

Change logs
add batch size for pax and vector extension.
Why are the changes needed?
both pax and vector needs batch guc.
Does this PR introduce any user-facing change?
no.
How was this patch tested?
no.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


working in swift?

This doesn't compile with swift v 1.2. well i can't get it to function.
UIImage-SVG/Classes/PocketSVG.h:19:9: 'RaptureXML/RXMLElement.h' file not found
and a few more

This worked for me:

Install RaptureXML via cocoapods
Include both UIImage-SVG and RaptureXML in your swift project
Add #import "UIImage+SVG.h" to your App-Bridging-Header.h
Remove #else case in PocketSVG.h

Good luck!

Thanks, i'll have a hack at it.

I installed both UIImage-SVG and RaptureXML via Podfile.
Still, including #import "UIImage+SVG.h" in the bridging heder file leads to a "file not found" compiler error. Works with every other ObjC header file I throw at it.
Anybody have any idea what to look for here?

i don't use podfile so have no clue where it installs but it sounds like a weird kind find path. are you sure the header is in your local directory?   are you sure there is only one copy?  any older versions? previous installs hanging around?

Checked all of it, everything seems to be fine.

Building into a Swift project using use_frameworks! produces:
While building module 'RaptureXML' imported from /Users/fulldecent/Developer/FDChessboardView/Pods/UIImage+SVG/Classes/PocketSVG.h:19:
In file included from <module-includes>:1:
In file included from /Users/fulldecent/Developer/FDChessboardView/Pods/Target Support Files/RaptureXML/RaptureXML-umbrella.h:3:
/Users/fulldecent/Developer/FDChessboardView/Pods/RaptureXML/RaptureXML/RXMLElement.h:32:9: error: include of non-modular header inside framework module 'RaptureXML.RXMLElement' [-Werror,-Wnon-modular-include-in-framework-module]
#import <libxml2/libxml/xmlreader.h>
        ^
/Users/fulldecent/Developer/FDChessboardView/Pods/RaptureXML/RaptureXML/RXMLElement.h:33:9: error: include of non-modular header inside framework module 'RaptureXML.RXMLElement' [-Werror,-Wnon-modular-include-in-framework-module]
#import <libxml2/libxml/xmlmemory.h>
        ^
/Users/fulldecent/Developer/FDChessboardView/Pods/RaptureXML/RaptureXML/RXMLElement.h:34:9: error: include of non-modular header inside framework module 'RaptureXML.RXMLElement' [-Werror,-Wnon-modular-include-in-framework-module]
#import <libxml/xpath.h>
        ^
/Users/fulldecent/Developer/FDChessboardView/Pods/RaptureXML/RaptureXML/RXMLElement.h:35:9: error: include of non-modular header inside framework module 'RaptureXML.RXMLElement' [-Werror,-Wnon-modular-include-in-framework-module]
#import <libxml/xpathInternals.h>
        ^
4 errors generated.
In file included from /Users/fulldecent/Developer/FDChessboardView/Pods/UIImage+SVG/Classes/UIImage+SVG.m:11:
/Users/fulldecent/Developer/FDChessboardView/Pods/UIImage+SVG/Classes/PocketSVG.h:19:9: fatal error: could not build module 'RaptureXML'
#import <RaptureXML/RXMLElement.h>
 ~~~~~~~^
5 errors generated.

@fulldecent did you find a solution on this?

I gave up and used PNG files. The future has not yet arrived.

I gave up and used PDF files. That felt a bit more futuristic than PNG.

:) just doing the same
@nilshott do you work with Single Vector Scale Factor in asset catalog? Couldn't figure out how to set the actual size to be used for rendering.

@martnst I indeed use Single Vector for the assets, and since I create those assets from Sketch, they miraculously know the original size they were created with in Sketch.

okay exporting the PDF icon in a proper size is the trick. Thanks for sharing @nilshott


CrossOver 21.0.0

Should build properly. No runtime tests done yet.

Hi @GabLeRoux, @Gcenx,
This seems to build without any obvious problems. Do you have any thoughts or comments?
Btw.:  I did not runtime-test wine yet.

I did build this last night but figured this morning I’d disabled vkd3d so WineD3D wasn’t usable sigh….
Anyway it’s better to wait for an updated source archive to land as this one is missing MoltenVK/vkd3d and some other components, I’ll let you know once the updated archive lands. (I have an open ticket for this already)

@dasmy & @GabLeRoux of note for CX21.0.0 is the lack of support for macOS Monterey.
The one more things for consideration would be with removing prior versions as CX21.0.0 is much more stable overall compared to prior releases.

I did build this last night but figured this morning I’d disabled vkd3d so WineD3D Vulkan wasn’t usable sigh….
Anyway it’s better to wait for an updated source archive to land as this one is missing MoltenVK/vkd3d and some other components, I’ll let you know once the updated archive lands. (I have an open ticket for this already)

Yep, I was pretty surprised not to see vkd3d in the archive...

@dasmy & @GabLeRoux of note for CX21.0.0 is the lack of support for macOS Monterey.

The previous versions don't support Monterey either, do they?

The one more things for consideration would be with removing prior versions as CX21.0.0 is much more stable overall compared to prior releases.

Definitely - building the older versions seems like a waste of resources. Maybe it will make sense to keep the latest 20.0.x in case someone wants to compare compatibility between versions...

Funny enough, I just learned that the build failures for 20.x.x seem to result from a too recent mingw-w64: version 9.x.x of mingw-w64 contains the DirectX code pieces from wine 6.0 which breaks the build of DXVK.
Unfortunately, there does not seem to exist a home-brew formula for mingw-w64 8.x.x. :-(

The CX20.0.x build fails are due to sincos add the following patch msvcrt: Add sincos to importlib
The alternative to the patch is passing -fno-builtin-{sin,cos}{,f} but I don't like passing multiple flags to CROSSCFLAGS, I wouldn't pass -fcommon for CX21
That patch is also needed for wine-stable-6.0.1, I had requested it get cherry picked but it didn't qualify for getting fast tracked but at the time at least the M1 GPU patches did qualify to be added.

https://github.com/madewokherd/wine-mono/blob/develop/.github/workflows/c-cpp.yml

As every source package comes with its own version of llvm/clang: Do you mean building llvm/clang once from the newest package and then using it for the older ones as well?

https://github.com/madewokherd/wine-mono/blob/develop/.github/workflows/c-cpp.yml

As every source package comes with its own version of llvm/clang: Do you mean building llvm/clang once from the newest package and then using it for the older ones as well?

Basiclly yes as the compiler hasn’t changed since it was initially provided just the source archive layout changed. I’ve build CX21 using the original llvm/clang-8 Xcode toolchain compile without issue.
As upstream is working on implementing its own version of 32on64 that doesn’t require a custom compiler might not longer be required for CX22 at the earliest.

@dasmy & @GabLeRoux if you guys want to quickly see the difference between crossover patch bumps just check my mirror https://github.com/Gcenx/winecx/commit/4939a31816c51cc018f749f7b7c8d99c3a9857b2 Aka crossover-wine-20.0.4

I think -fcommon is now only required for CX19.0.2, just don't quote me on that as I can't confirm this currently.

I think -fcommon is now only required for CX19.0.2, just don't quote me on that as I can't confirm this currently.

I'll give it a try.

Once everything is done and working here I think it’s best to squash and rebase into a single commit.

I was afraid this would be the case when slipping the steps.
Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/Users/runner/work/macos-crossover-cloud-build/macos-crossover-cloud-build/github/actions/configure_wine@v1'. Did you forget to run actions/checkout before running your local action?

@dasmy I’d in understanding this the current built action I’ll be cached and used if available like what MoltenVK does?
If that’s the idea it might be a good idea to instead move compiling the custom llvm/clang to before anything else and just stick to a fixed url for its sources.
I believe this method isn’t a great fit for multiple CX compiles as each image will need to still complete llvm/clang at times, it would make more sense to split of the llvm/clang compiling into its one action that runs before the others and uploads the archive that then gets reused for all subsequent builds. This could lightly also have a cashed image to speed the one time compile of llvm/clang.

Didn’t mean to close ugh dam phone….

@dasmy I’d in understanding this the current built action I’ll be cached and used if available like what MoltenVK does?
If that’s the idea it might be a good idea to instead move compiling the custom llvm/clang to before anything else and just stick to a fixed url for its sources.
I believe this method isn’t a great fit for multiple CX compiles as each image will need to still complete llvm/clang at times, it would make more sense to split of the llvm/clang compiling into its one action that runs before the others and uploads the archive that then gets reused for all subsequent builds. This could lightly also have a cashed image to speed the one time compile of llvm/clang.

Yes, this in general the idea. I am currently reordering the workflow to do exactly that: Have an initial step that restores llvm/clang from cache or restores them (the same for all versions). With my bad experience about quality of the GitHub Action documentation (or my missing capability to read it properly), I am just trying tiny steps one after the other... :-D

@dasmy I’d in understanding this the current built action I’ll be cached and used if available like what MoltenVK does?
If that’s the idea it might be a good idea to instead move compiling the custom llvm/clang to before anything else and just stick to a fixed url for its sources.
I believe this method isn’t a great fit for multiple CX compiles as each image will need to still complete llvm/clang at times, it would make more sense to split of the llvm/clang compiling into its one action that runs before the others and uploads the archive that then gets reused for all subsequent builds. This could lightly also have a cashed image to speed the one time compile of llvm/clang.

Yes, this in general the idea. I am currently reordering the workflow to do exactly that: Have an initial step that restores llvm/clang from cache or restores them (the same for all versions). With my bad experience about quality of the GitHub Action documentation (or my missing capability to read it properly), I am just trying tiny steps one after the other... :-D

... still have to find out, which of the following need to go into the llvm/clang step and which are only for wine (or possibly for both...)
        run: |
          # build tools
          brew install  cmake            \
                        ninja            \
                        mingw-w64        \

          # build dependencies for wine / crossover
          brew install  freetype         \
                        bison            \
                        krb5             \
                        faudio           \
                        sdl2             \
                        gphoto2          \
                        sane-backends    \
                        gst-plugins-base \
                        mpg123           \
                        little-cms2      \
                        libpng           \
                        molten-vk

          # dependencies for dxvk
          brew install  coreutils \
                        meson     \
                        glslang

For llvm/clang cmake & ninja everything else should already be available. However you don’t even need to install cmake as it’s installed into the images by default anyway.

The following are already installed into the GitHub actions images by default;

cmake
freetype
krb5
libpng

@dasmy as your attempting to use the actions locally the @1 won't be required.

@dasmy seems you pushed the same commit it did to squash CX21/20.

@dasmy seems you pushed the same commit it did to squash CX21/20.

Looks like, but yours was in the wine32on64 section, mine was in the wine64 part

@dasmy seems you pushed the same commit it did to squash CX21/20.

Looks like, but yours was in the wine32on64 section, mine was in the wine64 part

Your right I quickly looked and was confused like how did GitHub allow a duplicate commit without a force push… make sense now.

Moved around the brew dependencies so the needed ones are installed for the relevant stage.
The wine patches are now git format even the distversion.h is now a git format patch. (blame upstream projects for using git format patches)
Next is to figure out what to do about DXVK.....

I believe the following items still need to be worked on before squashing down the commits;

LLVM/Clang into a separate workflow? (Like wine-mono)
DXVK (figure out how to build or remove)
Add back missing wine default tools
possible winetricks compatibility.

According to the previous action log it shows that nothing was really download. So the extract failed as it was ether an empty archive or simply didn’t exist.

According to the previous action log it shows that nothing was really download. So the extract failed as it was ether an empty archive or simply didn’t exist.

Yes, it's a bit strange (as usual :-) ): The LLVM step says:
Uploading /Users/runner/work/macos-crossover-cloud-build/macos-crossover-cloud-build/install/build-tools-cx.tar.gz (91.3%)
36
Uploading /Users/runner/work/macos-crossover-cloud-build/macos-crossover-cloud-build/install/build-tools-cx.tar.gz (97.6%)
37
Total size of all the files uploaded is 266194120 bytes
38
Finished uploading artifact build-tools-cx. Reported size is 266194120 bytes. There were 0 items that failed to upload
39
Artifact build-tools-cx has been successfully uploaded!

If the download file name ore anything were wrong, I would have expected to see an error message. Instead, we are getting an (almost?) empty file - see the output of ls...

According to the previous action log it shows that nothing was really download. So the extract failed as it was ether an empty archive or simply didn’t exist.

Yes, it's a bit strange (as usual :-) ): The LLVM step says:
Uploading /Users/runner/work/macos-crossover-cloud-build/macos-crossover-cloud-build/install/build-tools-cx.tar.gz (91.3%)
36
Uploading /Users/runner/work/macos-crossover-cloud-build/macos-crossover-cloud-build/install/build-tools-cx.tar.gz (97.6%)
37
Total size of all the files uploaded is 266194120 bytes
38
Finished uploading artifact build-tools-cx. Reported size is 266194120 bytes. There were 0 items that failed to upload
39
Artifact build-tools-cx has been successfully uploaded!

If the download file name ore anything were wrong, I would have expected to see an error message. Instead, we are getting an (almost?) empty file - see the output of ls...

OK, understood - its a directory, not the actual file... facepalm again

According to the previous action log it shows that nothing was really download. So the extract failed as it was ether an empty archive or simply didn’t exist.

Yes, it's a bit strange (as usual :-) ): The LLVM step says:
Uploading /Users/runner/work/macos-crossover-cloud-build/macos-crossover-cloud-build/install/build-tools-cx.tar.gz (91.3%)
36
Uploading /Users/runner/work/macos-crossover-cloud-build/macos-crossover-cloud-build/install/build-tools-cx.tar.gz (97.6%)
37
Total size of all the files uploaded is 266194120 bytes
38
Finished uploading artifact build-tools-cx. Reported size is 266194120 bytes. There were 0 items that failed to upload
39
Artifact build-tools-cx has been successfully uploaded!

If the download file name ore anything were wrong, I would have expected to see an error message. Instead, we are getting an (almost?) empty file - see the output of ls...

OK, understood - its a directory, not the actual file... facepalm again

Btw.: In principle, we could also simply download the cache again (the first job step took care of it being valid). - I assume, this might be a bit quicker than the upload-download pair. However, the latter is suggested by the docs. Do you have any preference?

Do what’s recommended just keep the cache step within the llvm/clang action

@dasmy you gotten it working!
So next is figuring out what to do about MoltenVK and possible winetricks compatibility etc as the major things are now handled.

@dasmy you gotten it working!
So next is figuring out what to do about MoltenVK and possible winetricks compatibility etc as the major things are now handled.

Yes, following your list from above:

DXVK (figure out how to build or remove)
I added some observations in https://github.com/GabLeRoux/macos-crossover-cloud-build/pull/20/commits/7a2dc8dd3687d87584cae6e7791cfc95378ee956 . Very likely tweaking include paths should help here...
Add back missing wine default tools
What do you mean by this?
possible winetricks compatibility
Are there any issues to be expected? - I think I used wibwtricks with crossover 20.0.4

What do you mean by this?

By default Wine ships some wrapper scripts for easily launching things like winecfg.

Are there any issues to be expected? - I think I used wibwtricks with crossover 20.0.4

Without setting any environment variables winetricks expects wine & wine64 binaries, so making a symlink/bash script or just make a copy of wine32on64 & wine32on64-preloader. As the output is 6.0 from this winetricks will use any needed workaround(s) for wine-6.0 that should be fine.

@dasmy I’m thinking maybe we merge this and deal with MoltenVK/DXVK in another PR.
What’s are your thoughts on this?

@dasmy I’m thinking maybe we merge this and deal with MoltenVK/DXVK in another PR.
What’s are your thoughts on this?

@Gcenx, I am fine with the branch being merged.
Can you maybe do this? - I  am currently on vacation with only mobile phone access :-D
We should just make sure, we don't forget about the open issues, maybe by opening issues ;-)


Allow categories

Before
Previously there was one statement regarding categories and it was under "Private Properties." It stated that private properties go in extensions—anonymous categories—and placed heavy restrictions on named categories. (The wording of the exception to "never" was actually a bit ambiguous to me.)
After
I would like to more explicitly define the usage and naming of categories. This proposal permits categories, so long as they are there to cordon off a logical grouping of functionality and have names that are meaningful and expressive.
Why

Objective-C categories are a common paradigm, taken for granted by many developers and projects, in open source and Apple code. The style guide should address categories.
I believe that the essential idea of the guide's "naming" section—expressiveness—equally applies to categories. Furthermore, descriptive yet concise naming leads to delineating categories in sensible ways. UIView+NYTAdditions.h, for example, explains nothing and may have 1 or 100 methods.

I'm not attached to the wording, but I do consider properly named categories helpful and would like to see them in this guide.

Also, on en-US and pt-BR are included in this PR. Is that a problem?

I like this. XXXAdditions always seemed like a terrible naming strategy to me.

We believe this naming strategy for categories leads to better programming practices and clearer indication of responsibilities. Merging.


OkUrlFactory Missing

okhttp-2.3.0.jar doesn't include com.squareup.okhttp.OkUrlFactory. Please resolve it.

It's in the okhttp-urlconnection artifact, which you'll also need.


Enable syntax highlighting. Improve formatting.

Didn't even notice I forgot the syntax highlight, great!


Callback or event from the DLL?

Callbacks are not very likely but any chance of an event coming back from the loaded DLL?

I don't think I'd like to implement this - it would have a serious impact on the interface design and security. Maybe in a distant future ;)


Syntax highlight in *.md

You may use the smart syntax highlighting as described in http://github.github.com/github-flavored-markdown/.

All the old code blocks have finally been purged. Thanks for the tip. Check out the new README.

Nice :)


Update sbt-ci-release-early to 2.0.42

About this PR
📦 Updates io.shiftleft:sbt-ci-release-early from 2.0.37 to 2.0.42
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.shiftleft", artifactId = "sbt-ci-release-early" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.shiftleft", artifactId = "sbt-ci-release-early" }
}]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #73.


huwai p30 out of focus camera bug

I want to make a PWA QR reader with ionic / angular.
Your example does not work on all mobiles.
I have a problem with the huwai P30. I see the camera as if it had some zoom and it does not focus well when I bring it closer to the qr or another object and therefore it does not scan the qr code. The mobile camera works well and takes pictures correctly. In fact, if I use other qr apps from playstore with (for example qrdroid) the camera works fine.
Why does it blur on the PWA? That could be happening?
Thanks

This library is a QR code scanner, and has no logic for camera access.
It sounds like this is an issue with webcams - If you can confirm this is an issue with jsQR - aka not related to the webcam access, but rather to the call of this library, then feel free to clarify in the issue, however if you're just having trouble getting getUserMedia to work I'm unfortunately not going to be able to help much.
Closing this issue until it's clear it's an issue with jsQR not the webcam capture. Please comment/re-open if you feel this is in error.


Fix boot script/Rebar3

This updates Rebar3 and copies start.boot to vernemq.boot, as required by old runner script.
@varnerac this should allow us to go with the latest Rebar3

Looks good. It passes the release smoke test, so all is well.


Upgrade toolchain to leanprover/lean4:v4.6.0-rc1

The toolchain on the master branch is currently more from 30th July 2023. This PR updates it to leanprover/lean4:v4.6.0-rc1 which is the latest as of 14th Feb 2024. This includes updating the folder structure, .gitignore and lakefile.lean.
It will help circumvent all the lake update issues that arise from the last 7 months of updates in lean and lake, by providing a version of iris-lean that works with a recent toolchain.

Can you revert the folder structure change? This is unrelated to the toolchain upgrade.

I can do that. But isn't it better to move to a folder structure that is currently the standard lake template?

The last three commits revert the folder structure change. Lake build is successful

@digama0 : Are there any further changes to be made?

The lakefile changes are also unnecessary.

Reverted the lakefile.lean changes.


Align pyquaticus flag observations with pyquaticus bridge

This PR renames [retrieve|protect]_flag_* to [own|opponent]_home_*. This is because the MOOS bridge pointed to the flag home rather than the actual flag location, so this aligns the semantics.

This is great! The names for the observations were really confusing to me when I first hopped on the project so this would be super helpful to anyone getting started. Tested and good on my end!


WiP: Update protbuf to v23.1

Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of #27757

patch looks good, thanks for working on this!

Slow progress. Many dependencies are broken. Actively working on it.

possibly related https://github.com/protocolbuffers/protobuf/issues/12523

re the python_headers im not sure we still need to alias them - but if we do i believe we can use
diff --git a/bazel/repositories.bzl b/bazel/repositories.bzl
index fd13e73479..ac50ff6276 100644
--- a/bazel/repositories.bzl
+++ b/bazel/repositories.bzl
@@ -894,7 +894,7 @@ def _com_google_protobuf():
     # https://github.com/google/protobuf/blob/v3.6.1/util/python/BUILD#L6-L9
     native.bind(
         name = "python_headers",
-        actual = "@com_google_protobuf//util/python:python_headers",
+        actual = "@system_python//:python_headers",
     )

 def _io_opencensus_cpp():

There is still a ton of test failures due to a change to the error messages in protobuf JSON parser.

Still about 15 tests are failing. Mobile build is broken for unknown reason. @RyanTheOptimist

Still outstanding issues:

mobile build is broken due to its toolchain not supporting compiler warning that new protobuf enables
dynamic metadata formatter of NaN and Inf values is broken
wasm_config_test and wasm_http_filter_test are broken due to the Failed to load Wasm module due to a missing import: env.emscripten_stack_snapshot. Undiagnosed at this point
router_tool_test broken, undiagnosed at this point

Looks like this one is stalled.  Did we decide to merge now or wait for release?  If we're waiting let's tag it as such just to keep it off the daily on-call spam, and if not let's merge today to max out production time :-)

I think we should just delay it, since release is this week

per offline discussion, landing

/coverage

it doesn't look like this pgv patch ever made it upstream, sent it here https://github.com/bufbuild/protoc-gen-validate/pull/1110


RNTwilioPhone.fetchAccessToken is not a function

I am trying to integrate call masking using Twilio.
while I am trying to startcall() it returns the error RNTwilioPhone.fetchAccessToken is not a function
const callKeepOptions = {
ios: {
appName: 'TwilioPhone Example',
supportsVideo: false,
},
android: {
alertTitle: 'Permissions required',
alertDescription: 'This application needs to access your phone accounts',
cancelButton: 'Cancel',
okButton: 'OK',
additionalPermissions: [],
// Required to get audio in background when using Android 11
foregroundService: {
channelId: 'com.app.xxx',
channelName: 'Foreground service for my app',
notificationTitle: 'My app is running on background',
},
},
};
const options = {
requestPermissionsOnInit: false, // Default: true - Set to false if you want to request permissions manually
};
async function fetchAccessToken() {
axios.get('https://xxxxxxxxxx/api/Account/getTwilioToken').then(res => {
retun res
}).catch(err => console.log('err>>>>>>', err))
};
React.useEffect(() => {
return RNTwilioPhone.initialize(callKeepOptions, fetchAccessToken. options);
}, []);
  async function startCall(to, calleeName, from) {
    try {
      await RNTwilioPhone.startCall(to, calleeName, from);
    } catch (e) {
      console.log('e>>>>>>>>>>>',e);
    }

}

Hi,
Maybe RNTwilioPhone is not initialized yet when you are calling startCall.
Can you show the entire component with the call to startCall?

Hi,
Maybe RNTwilioPhone is not initialized yet when you are calling startCall.
Can you show the entire component with the call to startCall?

Hi,
Maybe RNTwilioPhone is not initialized yet when you are calling startCall.
Can you show the entire component with the call to startCall?

Hello,
also While I am trying to RNTwilioPhone.initialize() it retuns error 'RNTwilioPhone.fetchAccessToken is not a function'
import React, {useState} from 'react'
import { View, Text, Button } from "react-native";
import { RNTwilioPhone } from 'react-native-twilio-phone';
import axios from "axios";
export default function TwilioTest() {
const callKeepOptions = {
ios: {
appName: 'TwilioPhone Example',
supportsVideo: false,
},
android: {
alertTitle: 'Permissions required',
alertDescription: 'This application needs to access your phone accounts',
cancelButton: 'Cancel',
okButton: 'OK',
additionalPermissions: [],
// Required to get audio in background when using Android 11
foregroundService: {
channelId: 'com.app.xxxxxx',
channelName: 'Foreground service for my app',
notificationTitle: 'My app is running on background',
},
},
};
const options = {
requestPermissionsOnInit: true, // Default: true - Set to false if you want to request permissions manually
};
async function fetchAccessToken1() {
  axios.get('https://xxxxxx.com/api/Account/getTwilioToken').then(res => {
    return RNTwilioPhone.initialize(callKeepOptions, res.data.TwilioToken. options);
  }).catch(err => console.log('err>>>>>>', err))
};

  React.useEffect(() => {
    fetchAccessToken1()
  }, []);

  async function startCall() {
    try {
      await RNTwilioPhone.startCall('+00123456789');
    } catch (e) {
      console.log(e);
    }
  }
return (
    <View>
        <Text>Twilio Test</Text>
        <Button title = "call" onPress= {() => startCall()} />
    </View>
)

}

Hi,
Maybe RNTwilioPhone is not initialized yet when you are calling startCall.
Can you show the entire component with the call to startCall?

Hello,
also While I am trying to RNTwilioPhone.initialize() it retuns error 'RNTwilioPhone.fetchAccessToken is not a function'
import React, {useState} from 'react'
import { View, Text, Button } from "react-native";
import { RNTwilioPhone } from 'react-native-twilio-phone';
import axios from "axios";
export default function TwilioTest() {
const callKeepOptions = {
ios: {
appName: 'TwilioPhone Example',
supportsVideo: false,
},
android: {
alertTitle: 'Permissions required',
alertDescription: 'This application needs to access your phone accounts',
cancelButton: 'Cancel',
okButton: 'OK',
additionalPermissions: [],
// Required to get audio in background when using Android 11
foregroundService: {
channelId: 'com.app.xxxxxx',
channelName: 'Foreground service for my app',
notificationTitle: 'My app is running on background',
},
},
};
const options = {
requestPermissionsOnInit: true, // Default: true - Set to false if you want to request permissions manually
};
async function fetchAccessToken1() {
  axios.get('https://xxxxxx.com/api/Account/getTwilioToken').then(res => {
    return RNTwilioPhone.initialize(callKeepOptions, res.data.TwilioToken. options);
  }).catch(err => console.log('err>>>>>>', err))
};

  React.useEffect(() => {
    fetchAccessToken1()
  }, []);

  async function startCall() {
    try {
      await RNTwilioPhone.startCall('+00123456789');
    } catch (e) {
      console.log(e);
    }
  }
return (
    <View>
        <Text>Twilio Test</Text>
        <Button title = "call" onPress= {() => startCall()} />
    </View>
)

}

Thanks @wavemirani,
You are not initializing this module correctly.
Please read the documentation carefully. Then you can check how the module is initialized in the example app.
fetchAccessToken is a function that is calling an API endpoint to get a fresh token.
Twilio is providing some example projects that you can use to create that API endpoint.

Thanks @wavemirani,
You are not initializing this module correctly.
Please read the documentation carefully. Then you can check how the module is initialized in the example app.
fetchAccessToken is a function that is calling an API endpoint to get a fresh token.
Twilio is providing some example projects that you can use to create that API endpoint.

Thanks @MrHertal ,
Now, We are getting fetchAccessToken and calling is working. But now we will calling call with masking which twilio provide so can you please advice us on same.

Thanks @MrHertal ,
Now, We are getting fetchAccessToken and calling is working. But now we will calling call with masking which twilio provide so can you please advice us on same.

Hi @sumerpalgit,
What is call with masking? Do you have a link to Twilio documentation that describes it?

Hi @sumerpalgit,
What is call with masking? Do you have a link to Twilio documentation that describes it?

Hello @MrHertal
Here is link for twilio documentation for : https://www.twilio.com/docs/sms/tutorials/masked-numbers-php-laravel

Hello @MrHertal
Here is link for twilio documentation for : https://www.twilio.com/docs/sms/tutorials/masked-numbers-php-laravel

Sorry @sumerpalgit I cannot help you with this because I have never built call masking.
You should contact Twilio support, I am sure they will help you setting this up.
I will close this issue for now. Let me know if you need help with this package.

Sorry @sumerpalgit I cannot help you with this because I have never built call masking.
You should contact Twilio support, I am sure they will help you setting this up.
I will close this issue for now. Let me know if you need help with this package.


mgmt: mcumgr: Make SMP version 2 to legacy error lookup extensible

Replaces the manual lookup function with a lookup function which is provided when registering MCUmgr handlers which can be used to find the function to translate error codes, allowing out of tree MCUmgr handlers to provide error translation handlers.
Fixes #59343

[x] Code
[x] Release notes
[ ] Documentation update will do as part of #59492

@fabiobaltieri could you merge please?


Need to put a limiter on Smooth

If you don't do this, smooth will create way to many nodes (in the thousands).  We could limit it to a min angle or limit it to how many nodes it creates. Lets keep the polygon nodes to a max of about 50.

Ok, I will get into it!

Solved in #11


Hotfix for hiding behind backgrounds tabbed stacked

Fixes my screw up with https://github.com/way-cooler/way-cooler/pull/413
Fixes warnings

The floating is still an issue, but it's actually only an issue when you create a view. I didn't test enough, and it's actually an issue with view creation calling the focus_on method which forces it to obscure floating views.
I can worry about that fix in a different issue, but it's really not a big deal in the short term


ng new game-2d fails

🐞 Bug report
Command (mark with an x)
- [x ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
?
Description
Apparently can't create a new project with a hyphen in the name.
leege@studio MINGW64 /l/src/game-2d
$ npm install -g @angular/cli
C:\Users\leege\AppData\Roaming\npm\ng -> C:\Users\leege\AppData\Roaming\npm\node_modules\@angular\cli\bin\ng
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\@angular\cli\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

+<EMAIL_ADDRESS>added 110 packages from 91 contributors, removed 61 packages and updated 27 packages in 17.326s

leege@studio MINGW64 /l/src/game-2d
$

leege@studio MINGW64 /l/src/game-2d
$ ng new game-2d
? Would you like to add Angular routing? Yes
? Which stylesheet format would you like to use? CSS    (.css )
Schematic input does not validate against the Schema: {"name":"game-2d","version":"7.3.5","routing":true,"style":"css"}
Errors:

  Data path ".name" should match format "html-selector".

leege@studio MINGW64 /l/src/game-2d
$ ng new game2d
? Would you like to add Angular routing? Yes
? Which stylesheet format would you like to use? CSS    (.css )
CREATE game2d/angular.json (3807 bytes)
CREATE game2d/package.json (1305 bytes)
CREATE game2d/README.md (1023 bytes)...
...etc...

🔬 Minimal Reproduction
ng new game-2d
🔥 Exception or Error
As above:

Schematic input does not validate against the Schema: {"name":"game-2d","version":"7.3.5","routing":true,"style":"css"}
Errors:

  Data path ".name" should match format "html-selector".

🌍 Your Environment

Angular CLI: 7.3.5
Node: 11.9.0
OS: win32 x64
Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.13.5
@angular-devkit/core         7.3.5
@angular-devkit/schematics   7.3.5
@schematics/angular          7.3.5
@schematics/update           0.13.5
rxjs                         6.3.3
typescript                   3.2.4

Hi, the issue here is the number as html selectors should not contain digits.
Seeing specs here: https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name

Perhaps I misreading but the spec to which you point reads as below, where
PCENChar can contain any character in the range [0-9]:
name must match the PotentialCustomElementName
https://html.spec.whatwg.org/multipage/custom-elements.html#prod-potentialcustomelementname
production:
PotentialCustomElementName ::=[a-z] (PCENChar
https://html.spec.whatwg.org/multipage/custom-elements.html#prod-pcenchar)*
'-' (PCENChar
https://html.spec.whatwg.org/multipage/custom-elements.html#prod-pcenchar
)*PCENChar ::="-" | "." | [0-9] | "_" | [a-z] | #xB7 | [#xC0-#xD6] |
[#xD8-#xF6] | [#xF8-#x37D] | [#x37F-#x1FFF] | [#x200C-#x200D] |
[#x203F-#x2040] | [#x2070-#x218F] | [#x2C00-#x2FEF] | [#x3001-#xD7FF] |
[#xF900-#xFDCF] | [#xFDF0-#xFFFD] | [#x10000-#xEFFFF]
On Tue, 12 Mar 2019 at 08:49, Alan Agius<EMAIL_ADDRESS>wrote:

Closed #13885 https://github.com/angular/angular-cli/issues/13885.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/13885#event-2196259323,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfTMAJYj26-RBEgiueKCNIblXlqZsUjks5vV1wHgaJpZM4bqPB7
.

Should I create a new issue with reference to the specs, or have I misunderstood?

Re-opened as your clarification seems a corrrct.
Thank you.

Hi again, actually, this was fixed in this https://github.com/angular/angular-cli/pull/13837
See this spec https://github.com/angular/angular-cli/pull/13837/files#diff-867e0bcfb9109ac41d6c72f11fc039a0R46
Thanks

I have the same issue with v7.3.8 ; Didnt' have any trouble with 7.3.0
Why am I forced to use a BETA version of the next MAJOR version in order to have a fix? Why do not prepare 7.3.9 patch?


Not compatible with SwipeRefreshLayout is very good

when use SwipeLayout as item for listview ,and put listview in SwipeRefreshLayout(support V4),swipeLayout can't intercept touch event when open an item.

can confirm: doesn't work with SwipeRefreshLayout, having some intermittent results

Can you explain the exact details? [SwipeRefresh -> ListView -> SwipeLayouts] is the hierarchy I understand. But what is the expected results compared to the actual results?

Here is my layout.
It is modification of demo from repo
recyclerview.xml
<android.support.v4.widget.SwipeRefreshLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent">
<android.support.v7.widget.RecyclerView xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@+id/recycler_view"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:scrollbars="vertical" />
</android.support.v4.widget.SwipeRefreshLayout>

sometimes swipe doesn't work, the result is intermittent.
try swipe left for delete and pull down to show refresh icon and do again swipe left to delete

You haven't said expected outputs vs actual outputs still @varis.
I'm assuming you're saying it works fine when swiping left/right...You then try to refresh...then it stops working?

quite opposite: it doesn't work well before the refresh and works fine after that

@varis I won't have time to look into it for 3 weeks at least. Theres most likely an issue with touch events getting dispatched. If you want to try and solve the issue and don't understand how Android dispatches touch events through its views watch this video: https://www.youtube.com/watch?v=EZAoJU-nUyI And then just start putting breakpoints in the code. My guess is RefreshLayout for some reason is consuming the touchevents before distributing to its children. I could be wrong though.

I too need help on the same.
I have tried this as well:
listNotifications.setOnTouchListener(new View.OnTouchListener() {
@Override
public boolean onTouch(View v, MotionEvent event) {
switch (event.getActionMasked()) {
case MotionEvent.ACTION_UP:
// swipeContainer.requestDisallowInterceptTouchEvent(false);
return false;
}
return true;
}
});
Tried to consume all events in ListView (which has a swipe layout on item), and only pass on the ACTION_UP event, so that refresh only happens on lifting the finger, but this is not working.

@zjingchuan The latest version has fixed this problem, try it.


translations._load_language (& all settings loads) needs a try/except

🐛 Bug
I was just running some pytests on a non-napari package, in an environment that happened to have napari installed, and started getting errors because napari is registered as a pytest plugin, but was failing to import.  Here's the full trace:

Traceback (most recent call last):
  File "/Users/talley/miniconda3/envs/magicdev/bin/pytest", line 8, in <module>
    sys.exit(console_main())
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/config/__init__.py", line 185, in console_main
    code = main()
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/config/__init__.py", line 143, in main
    config = _prepareconfig(args, plugins)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/config/__init__.py", line 318, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/pluggy/hooks.py", line 286, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/pluggy/manager.py", line 93, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/pluggy/manager.py", line 84, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/pluggy/callers.py", line 203, in _multicall
    gen.send(outcome)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/helpconfig.py", line 100, in pytest_cmdline_parse
    config: Config = outcome.get_result()
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/pluggy/callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1003, in pytest_cmdline_parse
    self.parse(args)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1283, in parse
    self._preparse(args, addopts=addopts)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1172, in _preparse
    self.pluginmanager.load_setuptools_entrypoints("pytest11")
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/pluggy/manager.py", line 299, in load_setuptools_entrypoints
    plugin = ep.load()
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/importlib/metadata.py", line 77, in load
    module = import_module(match.group('module'))
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/__init__.py", line 7, in <module>
    from .viewer import Viewer  # isort:skip
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/viewer.py", line 3, in <module>
    from .components import ViewerModel
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/components/__init__.py", line 19, in <module>
    from .layerlist import LayerList
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/components/layerlist.py", line 8, in <module>
    from ..layers import Layer
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/layers/__init__.py", line 10, in <module>
    from .base import Layer
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/layers/base/__init__.py", line 1, in <module>
    from .base import Layer
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/layers/base/base.py", line 22, in <module>
    from ._base_constants import Blending
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/layers/base/_base_constants.py", line 5, in <module>
    from ...utils.translations import trans
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
    exec(co, module.__dict__)
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/utils/translations.py", line 476, in <module>
    _Translator._set_locale(_load_language())
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/utils/translations.py", line 468, in _load_language
    data = safe_load(fh) or {}
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/__init__.py", line 162, in safe_load
    return load(stream, SafeLoader)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/__init__.py", line 114, in load
    return loader.get_single_data()
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/constructor.py", line 49, in get_single_data
    node = self.get_single_node()
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/composer.py", line 110, in compose_sequence_node
    while not self.check_event(SequenceEndEvent):
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/parser.py", line 403, in parse_indentless_sequence_entry
    if self.check_token(BlockEntryToken):
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/scanner.py", line 115, in check_token
    while self.need_more_tokens():
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/scanner.py", line 152, in need_more_tokens
    self.stale_possible_simple_keys()
  File "/Users/talley/miniconda3/envs/magicdev/lib/python3.8/site-packages/yaml/scanner.py", line 291, in stale_possible_simple_keys
    raise ScannerError("while scanning a simple key", key.mark,
yaml.scanner.ScannerError: while scanning a simple key
  in "/Users/talley/Library/Application Support/Napari/settings.yaml", line 31, column 1
could not find expected ':'
  in "/Users/talley/Library/Application Support/Napari/settings.yaml", line 32, column 19

but the key part is right here:
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/utils/translations.py", line 476, in <module>
    _Translator._set_locale(_load_language())
  File "/Users/talley/Dropbox (HMS)/Python/forks/napari/napari/utils/translations.py", line 468, in _load_language
    data = safe_load(fh) or {}
...
yaml.scanner.ScannerError: while scanning a simple key
  in "/Users/talley/Library/Application Support/Napari/settings.yaml", line 31, column 1
could not find expected ':'
  in "/Users/talley/Library/Application Support/Napari/settings.yaml", line 32, column 19

we should add some tests to make sure that every time we read from from settings, even if that settings file is complete nonsense, napari doesn't crash.
cc @goanpeca

Will fix!
Indeed not nice!

thanks!


Remove push_scope

Remove sentry_sdk.push_scope as well as any tests testing this function.
To be done in potel-base.

merged into hotel-base


refactor: Move SQLConnector into a separate module, for use by both SQLStream and SQLSink

Currently the SQLConnector class is in stream module in the same file as SQLStream, however it is also needed by SQLSink from the sink module. Moving the connector into a sql module would make it easier to work on sinks, and also provide a place for other shared, SQL-related code.

What about having a SQLConnector class and a SQLConnectorSink(SQLConnector) where all the sink specific functions could be housed.  Examples would be create_schema, prepare_column, _adapt_column_type, merge_sql_types, rename_column.


Markdown.Avalonia.Html nupkg has no dlls included

The 11.0.x packages seem to not have any dlls included - is this intended?
Markdown.Avalonia.Html.11.0.1
├── [Content_Types].xml
├── Markdown.Avalonia.Html.md
├── Markdown.Avalonia.Html.nuspec
├── package
│   └── services
│       └── metadata
│           └── core-properties
│               └── 0a9e1c629050405a93362db0b0b38344.psmdcp
└── _rels

I was trying to use the Html plugin for Markdown.Avalonia, but there doesn't seem to be a nuget package with it included.

apologize for the late reply.
I released 11.0.2 packages.
These include assemblies.

Thanks!


Text doesn't reflow when window/pane is resized

[x] I am on the latest Hyper.app version

[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: macOS Sierra 10.12.1

Hyper.app version: Version 0.8.3 (<IP_ADDRESS>3)

Link of a Gist with the contents of your .hyper.js: https://gist.github.com/ravinggenius/9f253955dcbcaebd1307e89cbe253326

Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A

The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue
Printed text doesn't rewrap when window or pane (viewport) is resized (bigger or smaller). When going from a wide viewport to a narrow viewport, existing text that is too wide becomes inaccessible. When going from a narrow viewport to a wide viewport, existing text remains wrapped wherever it was before resizing.
I'm sure maintainers are tired of comparisons to iTerm2, but existing text there is dynamically reflowed whenever a viewport is resized smaller. (Wide text is soft-wrapped.) However existing narrow text is not reflowed when the viewport is widened, unless it was previously soft-wrapped. (This is unfortunate.)
Personally I would like to see all text soft-wrapped and reflowed when windows/panes are resized. To be clear I think text should be soft-wrapped when initially output as well. Then it would reflow correctly when the viewport is widened. At the very least, wide text should not be obscured when the viewport is made smaller.

This is a duplicate of #476 😃


Add datetimepiker and timepiker

Add datetime #piker and time piker:

it's being worked on https://github.com/angular/material2/issues/2519#issuecomment-275792252 https://github.com/angular/material2/pull/2578
Altho it's gotta be said that there was no mention of datetimepicker, are you planning to do that at the same time as datepicker by any chance @mmalerba ? Or at least design it in a way that would allow timepicker extension? From my experience you almost always need both date and time and having it split into two components is both ux unfriendly as well as a little pain in the arse when it comes to combining the two(the way forms work).. this does http://code.promactinfo.com/md2/#/datepicker a fairly good job at combining the two

Yeah, probably no time in the initial implementation, but it will be added after. We will probably go with something pretty similar to that on mobile, but I'm not sure how well it works for desktop. Hopefully the material design team will have some guidance for how to adapt it to desktop soon.

I'm going to start working on this in the datepicker branch, here's the design doc: https://docs.google.com/document/d/1RwPFESCbSSLMSDqxWo7jg4UUpGJTrXX6p5wYlb9pmNc/preview

This looks like a duplicate of https://github.com/angular/material2/issues/675, where we're tracking datepicker's initial version. Specific time support will probably be a later feature and will get its own issue at that time.

For those looking for a angular5/material2 / latest flex time picker, I banged one out last night for a personal project. Feel free to rip it to your needs. https://github.com/SteveDunlap13/MaterialTimeControl


Mobile - Update web-runner v1.2.31

Describe the task
Update web-runner v1.2.31

Refer: https://github.com/Koniverse/SubWallet-Extension/releases/tag/v1.2.31

Implement on issue #1816


SessionServlet: Convert response body for NotFound, BadRequest and Forbidden to json

What changes were proposed in this pull request?
SessionServlet is supposed to deliver json responses. This is not the case in some error cases today. This pull requests converts the response bodies for NotFound, BadRequest and Forbidden to json
https://issues.apache.org/jira/browse/LIVY-525
How was this patch tested?
manual tests since this is a trivial fix.

Codecov Report

Merging #127 into master will decrease coverage by 0.03%.
The diff coverage is 40%.

@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
- Coverage        71%   70.96%   -0.04%
- Complexity      922      924       +2
============================================
  Files           100      100
  Lines          5507     5507
  Branches        827      827
============================================
- Hits           3910     3908       -2
  Misses         1064     1064
- Partials        533      535       +2

Impacted Files
Coverage Δ
Complexity Δ

.../scala/org/apache/livy/server/SessionServlet.scala
67.9% <40%> (ø)
16 <0> (ø)
:arrow_down:

...main/java/org/apache/livy/rsc/ContextLauncher.java
81.63% <0%> (-2.56%)
18% <0%> (ø)

.../scala/org/apache/livy/sessions/SessionState.scala
61.11% <0%> (ø)
2% <0%> (ø)
:arrow_down:

...in/java/org/apache/livy/rsc/driver/JobWrapper.java
80% <0%> (ø)
8% <0%> (+1%)
:arrow_up:

...ain/java/org/apache/livy/rsc/driver/RSCDriver.java
79.23% <0%> (+1.27%)
42% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0442eb0...05b029a. Read the comment docs.

Could you put the bug in the PR title like generally done in other PRs? You could also make the title shorter by saying "body for error messages" instead of listing all error messages...
I'd prefer to define a proper type for this instead of hardcoding the Map construction everywhere. Could be as simple as a case class Error(message: String).

Ok, I'll submit an update - hopefully later this week.

Merging to master. I'll fix the title during merge.


[ fix ] don't use stdbuf if it is broken

It came up in a discussion  with @joelberkeley on discord that the homebrew stdbuf does not work in github macos-latest containers.  It fails complaining about an architecture mismatch:
dyld[2194]: tried: '/opt/homebrew/Cellar/coreutils/9.5/libexec/coreutils/libstdbuf.so' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e')), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/Cellar/coreutils/9.5/libexec/coreutils/libstdbuf.so' (no such file), '/opt/homebrew/Cellar/coreutils/9.5/libexec/coreutils/libstdbuf.so' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e'))

This breaks pack in macos-latest containers if coreutils is installed.
This PR changes the code in pack that locates stdbuf to also verify that it successfully runs before deciding to use it.  (Locally, I added a putStrLn to verify that it still uses stdbuf if it is present and working.)

Thanks for fixing this.


Preserve device in Labels::union and intersection

Built on top of #375 and #378 which should be merged first
TODO: figure a way to test this? Since we don't have cuda on CI

figure a way to test this? Since we don't have cuda on CI

It seems that we can use the "meta" device (device which only tracks size) for these tests!


Deepcopy infra machine remove

Issue: https://github.com/rancher/rancher/issues/36845
Problem
There was an issue where a concurrent map read and write would happen. It is
difficult to diagnose, but this is one place where an unstructured object was
being modified without first deep copying the object.
Solution
Deep copying the object before changing it should stop the panic.
Testing
This is an intermittent issue. Previously, the panic would happen on approximately 1 out of 3 CI runs. The CI has run 6 times for this PR and no panic has been seen.

I think I ran into this bug a few times during initial encryption key rotation implementation, glad to see it fixed.


Scrolling a stack with non-square PixelSpacing resets the camera

If I have a StackViewport with a stack of dicoms that have a non-square PixelSpacing, switching between images causes the camera to reset to its initial position. This is awkward and makes it impossible to zoom in on a cine stack and scroll through time.
If the PixelSpacing is not present or is 1.0\1.0, it behaves how I expect and the camera doesn't reset.

I agree that is awkward, is the data anonymized and whether can you share it?

Here's a synthetic dataset that exhibits the problem.
test_juliaset.zip

can you try now?

So, it turns out that in my actual project, we are further behind the main branch that I remembered. I have been struggling a bit to catch up without producing errors deep inside the renderer... I will need to spend some more time with that.
In the meantime, I tried manually backporting the relevant changes. It seems to work!
The only issue is- and I think this may be due to my incomplete backport-  isEqual(imagePlaneModule.rowCosines, <Point3>rowCosines) is returning False due to rowCosines actually being a Float64Array. Changing the relevant lines to use Array.from() seemed to fix that:
      isEqual(imagePlaneModule.rowCosines, Array.from(rowCosines)) &&
      isEqual(imagePlaneModule.columnCosines, Array.from(columnCosines))

This may not actually be relevant to the fix though, but I thought I'd mention it just in case.

@RoyWiggins can you check again


Add the ability to modify a user

Add the ability to modify a user #278
Fixes #425

Could you add a samples/userModify.hcl (and a blackbox test if you think we need one)?  I've noticed that we've had a lot of regressions introduced lately that we could have caught earlier if we'd had more cases being exercised by blackbox tests.  Thanks!

Using this module as an example:
user.user "created" {
  username = "test1"
  home_dir  = "/home/test1-home"
  state    = "present"
}

file.content "a" {
  destination = "/home/test1-home/foo"
  content = "foo"
  depends = ["user.user.created"]
}

user.user "modified" {
  username = "test1"
  home_dir   = "/home/test1"
  move_dir  = true
  groupname = "daemon"
  depends   = ["user.user.created","file.content.a"]
}

I found it a bit surprising that during initial user creation the home directory wasn't created, but then during user modification if the new home directory target existed it would give me an error.
It would be nice if it would create the home directory for you (unless you specify not to) and if it would not error when moving the home directory (maybe just give the user ownership over everything in that directory and merge it with the existing home directory).
If merging the directories isn't really feasible it would be nice to have a more explicit error message, the one I got was:
root/user.user.modified:
 Error: user modify: usermod: exit status 12
 Messages:
 Has Changes: yes
 Changes: No changes

I added fields for adding a user:

create_home creates the home directory
skel_dir contents are copied to the home directory if create_home is true

The error returned when modifying a user home_dir is "usermod: exit status 12", which indicates the home_dir specified for the modification already exists. This is not an error and the home directory name is modified to the new value indicated. Since we are unsure what other corner cases may be encountered with this status code, I am not in favor of suppressing the error.


Build fails Xcode 13 - error: duplicate interface definition for class 'BugsnagApp'

Describe the bug
A new install of Bugsnag react native fails to build in Xcode 13.0, first time using the RN bugsnag so unsure if its me
Steps to reproduce
Follow the install docs https://docs.bugsnag.com/platforms/react-native/react-native/
Initiate a build in Xcode
See 30 issues under Bugsnag
Environment

Bugsnag version:   "@bugsnag/react-native": "^7.13.1",
React Native:  "react-native": "0.63.4",

Error messages:
/Users/xxx/Code/xxx/xxx/node_modules/@bugsnag/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/include/Bugsnag/BugsnagApp.h:15:1: error: duplicate interface definition for class 'BugsnagApp'

Ahh my fault, I added pod 'Bugsnag'  to my Podfile ios/Podfile and this I think made it try to compile twice resulting in the duplicate interface definition


Release/v1.5.x

Support for FX Window Forwards  (FxFlexibleForward in FpML) - domain definitions and a simple "price to worst" model based on a strip of fx forwards over the exercise period.
I have developed a product and model based on 1.5.1 and would like to submit for review

The description sound great, unfortunately, the PR doesn't contain your changes. Normally, you need to fork Strata first, then make your changes on a branch, and finally raise a PR. Please ask if unsure.
Note that we may also need you to sign a contributor agreement, please send an email to<EMAIL_ADDRESS>so we can contact you and discuss.

Is there anything we can do to help you get your code available for use to review?

My apologies, I'm completely new to Git so not quite familiar with the
workflow around a pull request. I assume I create a branch, push my changes
then make a pull request on that branch?
For now I'll do it "old school" and attach a zip of my source. As of now
I've implemented present value only. Also the model is very simplistic,
it's just a price to worse on a strip of forwards constructed during the
window period. I suppose a more sophisticated model would treat the window
as an american call structured with a down-and-out put but I guess that
might be overkill?
-regards
Richard
On Fri, Dec 1, 2017 at 3:51 AM, Stephen Colebourne<EMAIL_ADDRESS>
wrote:

Is there anything we can do to help you get your code available for use to
review?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenGamma/Strata/pull/1607#issuecomment-348476094,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPWQic04IxBk0awwsO9SKp8k1Yp6l-wks5s7-g1gaJpZM4Qdt40
.

This guide is pretty good for the normal github workflow. However, I suspect you've already cloned Strata and done work on a branch. The trick here is to do the following:

Fork Strata (button in top right)
Add a remote to your fork. ie. Go to your local copy of Strata and do git remote add myfork https://github.com/imode69/Strata.git. This means that your code is now linked to the original Strata as "origin" and your fork as "myfork".
Push your branch to your fork git push -u myfork <branch>
Go to the website of your fork, and you should be able to raise a new Pull Request from there with all of your files in it

I think thats everything, but it might be worth taking a zipped copy of your local directory before starting.
thanks

Thanks for the info, very helpful. Been using Perforce and SVN most of my
career so git is still a bit "foreign" to me.
regards
Richard
On Sat, Dec 2, 2017 at 1:57 AM, Stephen Colebourne<EMAIL_ADDRESS>
wrote:

This guide https://gist.github.com/Chaser324/ce0505fbed06b947d962 is
pretty good for the normal github workflow. However, I suspect you've
already cloned Strata and done work on a branch. The trick here is to do
the following:

Fork Strata (button in top right)
Add a remote https://help.github.com/articles/adding-a-remote/ to
your fork. ie. Go to your local copy of Strata and do git remote add
myfork https://github.com/imode69/Strata.git. This means that your
code is now linked to the original Strata as "origin" and your fork as
"myfork".
Push your branch to your fork git push -u myfork
Go to the website of your fork, and you should be able to raise a
new Pull Request from there with all of your files in it

I think thats everything, but it might be worth taking a zipped copy of
your local directory before starting.
thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenGamma/Strata/pull/1607#issuecomment-348681438,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPWQtxYlCTnPuFqlA2G6805vgCacNg_ks5s8R8QgaJpZM4Qdt40
.


Insufficient content of Readme

Fill content of Readme with useful stuff.

I'll fix it shortly!

Included in pre-release v.0.0.1-alpha.


Currency switch - 1.4.0 - bug

Can you reproduce this issue on default Wordpress theme (eg Storefront)?
Yes
Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang, and Hyyan WooCommerce Polylang Integration?
Yes
What product versions and settings are you using when this issue occurs?

PHP: 7.3.6
WordPress: 5.2.1
WooCommerce: 3.6.4
Polylang: Free
Hyyan WooCommerce Polylang Integration: 1.4.0
Browser: any

Steps to Reproduce

Set up Polylang with at least 2 languages.
Create a product in both languages.
Install any Woocommerce currency switcher (I used Currency Switcher by Realmag and switcher by algoritmika)
Set 2 currencies.
Go to the shop and switch to the additional currency (not the default one).
Add the product to the cart.
Go to the Cart page.
Switch to the second language.

What I Expected
The product prices are correct.
What Happened Instead
The prices of products in the cart are not correct.
Although, the subtotal in the Shipping calculator is correct.
This is a bug introduced in pre-release 1.4.0. I tested it now for a few hours.

Also, possible to test here (EURO is the additional currency):
https://www.test2.liberlapidum.com/test2/

Hmm yes there is a thing added for compatibility with other plugins which manipulate the price - fixes #390, #346 Cart: retain price when switching languages - you can remove the code added in this commit:
https://github.com/hyyan/woo-poly-integration/commit/ec272c0d921e39ebfd497fb2303454d7793bf60d
Or change the priority of the filters....
I will take a look...

for anyone else following this, Algoritmika seem to be rebranding as WP Wham, plugin referred to should be:
https://en-gb.wordpress.org/plugins/currency-switcher-woocommerce/
https://github.com/algoritmika/currency-switcher-woocommerce
and the realmag one:
https://wordpress.org/plugins/woocommerce-currency-switcher/

ok so realmag with the modification, the code is copying the converted price across when changing languages, then the currency switcher is converting it again because it does not know the cart price is already converted.

Great! Thanks for the fix :)


Hero 6 black - multi cam

I would like to use your API to synchronize a same order to 3 cameras. Should I be able to do this if I made an AP mode in my computer ?

Hi, where you able to do this? I would like to the same. Thanks!


Simplify the check for changed specs.

By using Option.contains we can avoid looking up the same key multiple
times.

Hi @unterstein!
Funny story: someone on a reddit thread regarding a patch adjacent to this complained about this line and proposed the fix... so I nicked it (with their approval).

reddit discussion about this: https://www.reddit.com/r/programming/comments/6hnifm/comment/dizr266

Thanks!


Bump transformers to 4.43.2

We need to bump the version to support llama 3.1
The main breaking changes from 4.40 shouldnt affect us:

tokenizer behaviour in TextGenerationPipeline (4.42 -> 4.43)
ConversationalPipeline, FLAVA, idefics, timm, quantization tests (4.41 -> 4.42)
Some minor llama tokenizer changes (https://github.com/huggingface/transformers/pull/28881) but nothing that seems crazy.

@jacob-morrison does this version work in your testing?

@jacob-morrison does this version work in your testing?

Good Q, I'll test now and update here soon


[ZEPPELIN-4403] Support publishable for paragraph

What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
[Feature]
Todos

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4403
How should this be tested?

First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
Strongly recommended: add automated unit tests for any new or changed behavior
Outline any manual steps to test the PR here.

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@hsuanxyz It is related with 2 jiras ? If so, please merge them as one jira.

Overall, PR LGTM, please add description in the PR

@zjffdu The ZEPPELIN-4403 is sub-task, I have removed the main-task link from the PR.

Thanks @hsuanxyz will merge it soon.


DatePicker autofill

Package
filament/forms
Package Version
high than v2.10.23
Laravel Version
v8.83.4
Livewire Version
No response
PHP Version
PHP v8.0.16
Bug description
I have one server with this package at version of v2.10.23 and app is not afflicted by this bug.
My local or staging server has this bug, the version installed  of package is the latest "v2.10.27".
In a form when is present more than field and at least one DatePicker, when another is changed ( with reactive entagle ), the field with DatePicker auto fill her state at 14 gen 2022.
I don't know how to investigate, this date is not reference to any of my data 😕
Any other with this bug?
Steps to reproduce
No response
Relevant log output
No response

After a day of debug in alpine js component dateTimePickerFormComponent maybe i've been found the problem.
In $watch of hour/minute/second the state is setted with a value from getSelectedDate ?? this.focusedDate.
But even if there's no value from state property the action is done anyway! ( this alter the state property with a non null value ).
I think if we check the state !== null the problem will disappear.
what do you think about this?
date-time-picker.js
example for hour $watch
if(this.state !== null){
            let date2 = this.getSelectedDate() ?? this.focusedDate;
            this.setState(date2.hour(this.hour ?? 0));
         }

@danharrin i have create a simple l9 with only filament forms installed.
If you try to change a reactive() field like the select dropdown "type", you can see the bug on date picker ( init with null value ).
Here is a demo to check the bug : https://l9-with-filament-forms.herokuapp.com/form
and here is the repository for consulting the component
https://github.com/Wit3/l9-with-filament/blob/main/app/Http/Livewire/Forms/EditDocument.php

Fixed by #1930


failed to import .md files

Describe the bug
I have a vue3 quasar app, that was using webpack and I migrated to vite, and fixed all of the issues except one thing, which is importing .md files, whenever I try to import an .md file it shows this error:

Reproduction
https://stackblitz.com/edit/vitejs-vite-g4uunx?file=index.html&terminal=dev
Steps to reproduce
No response
System Info
chrome
quasar2
vue3

Used Package Manager
npm
Logs
[vite] Internal server error: Failed to parse source for import analysis because the content contains invalid JS syntax. You may need to install appropriate plugins to handle the .md file format.
Plugin: vite:import-analysis
File: E:/Work/compliance-fe-main-v2-vite/changelog.md
Validations

[x] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

As shown in the error message, you need a Vite plugin that can transform .md files to JS modules so it can be imported. I'm not sure if it's a misconfiguration, but the repro doesn't have a Vite plugin nor a .md file.


fix: constrain 'clap' package version; broke after 'cargo update'

Goal
The goal of this PR is to restore successful build after an upstream dependency broke it.
Closes #1887
Checklist

[ ] Chain spec updated
[ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
[ ] Design doc(s) updated
[ ] Tests added
[ ] Benchmarks added
[ ] Weights updated

Closing in favor of #1897


Support  for PHPUnit 6.0

Laravel Version: 5.3.*
PHP Version: 7.0
Database Driver & Version:

Description:
A new PHPUnit version is released and has some changes that has to be updated in laravel. For example https://github.com/sebastianbergmann/phpunit/commit/ba2241e6e0a634dc333b6e1d2fd6d0e8c16c2f57

5.4 already supports the new namespaced phpunit version. Thank you anyways :)

Laravel 5.3 is closed for features and minor bug fixes now.


Support for sql remote URLs

---
sql:
  gaia: https://uwdata.github.io/mosaic-datasets/data/gaia-5m.parquet
---

An alternative to consider / a complement would be to allow FileAttachment("https://uwdata.github.io/mosaic-datasets/data/gaia-5m.parquet"[, options]); the options could indicate the extension/mimeType.

This would be incredibly useful.


[Bug]: storage integration with storage_aws_external_id

Terraform CLI Version

=1.0

Terraform Provider Version

=1.0

Terraform Configuration
resource "snowflake_storage_integration" "edw_storage_integration" {
  provider = snowflake.EDW_SYSADMIN
  name     = "xx"
  type     = "EXTERNAL_STAGE"
  enabled  = true
  storage_allowed_locations = [
    "xx"
  ]
  storage_provider        = "S3"
  storage_aws_role_arn    = local.workspace.storage_aws_role_arn
  storage_aws_external_id = "xxxxx"
}

Category
category:other
Object type(s)
resource:storage_integration
Expected Behavior
I would expect that storage integration will be created with the provided storage_aws_external_id. In snowflake I can run create or replace storage integration with specific storage_aws_external_id.
Actual Behavior
Can't configure a value for "storage_aws_external_id": its value will be
│ decided automatically based on the result of applying this configuration.
Steps to Reproduce

create storage integration specifying storage_aws_external_id
terraform plan

How much impact is this issue causing?
Medium
Logs
No response
Additional Information
No response
Would you like to implement a fix?

[ ] Yeah, I'll take it 😎

Reading through the go code, I believe the attribute storage_aws_external_id is computed. I wonder if this could be changed depending if the storage_aws_external_id attribute is specified in the resource. If it is use that string, if it is not, compute.

Hey @jsantora-uom. Thanks for reaching out to us.
I believe this is a duplicate of #2624. Please confirm.

That is correct, thanks @sfc-gh-asawicki, feel free to close this one, I'll watch the other ticket.


K8s code executor

Why are these changes needed?
Using docker container for code executor is inconvenient when utilizing autogen through a kubernetes cluster.
Code executor using Kubernetes pod can address security concerns by leveraging Kubernetes RBAC policies.
New feature

autogen.coding.kubernetes: module
autogen.coding.kubernetes.PodCommandLineCodeExecutor: class
extra requires [kubernetes] for setuptools

Test cases

test/coding/test_kubernetes_commandline_code_executor.py: test case
test/coding/test_kubernetes_commandline_code_executor.md: test case guide

Documentation

website/docs/topics/code-execution/kubernetes-pod-commandline-code-executor.ipynb

LICENSE

Added Apache License 2.0 to the project because it includes the Kubernetes Python SDK, which is licensed under Apache License 2.0.

Related issue number
#2967
Checks

[x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[x] I've made sure all auto checks have passed.

@questcollector hey thanks for the PR! We will get back to you in a few days.

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.

I'll align it with 0.4 version.👌

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.

I rebased it on 0.2 branch. I'll update kubernetes pod commandline code executor to align autogen 0.4 as new PR👌

@questcollector - thanks! well done. I think there are just a couple of pre-commit checks to fix to green the CI

we're happy to take this for 0.2, for 0.4 how do the guidelines seem to you (https://microsoft.github.io/autogen/dev/user-guide/extensions-user-guide/index.html#creating-your-own-community-extension) @questcollector ?

@questcollector - thanks! well done. I think there are just a couple of pre-commit checks to fix to green the CI

oops 😅 I applied pre-commit. Thank you.
@jackgerrits 👌Thank you😊. I will make pod commandline executor by creating community extension.

Looks like there are still CI issues here that need to be fixed before this can be merged.

Looks like there are still CI issues here that need to be fixed before this can be merged. (I reverted a seemingly unrelated change to gitignore)

Oh sorry for extra works, I fixed test code.
Code block importing kubernetes package moved into try block.
I think it will prevent issues about build actions.
Thank you for reviewing this PR


Bitstamp added euro support

Added euro support on bitstamp.
Implemented:

Balance
Order books
placing limit order
query open orders

can you check on the failed build?

@timmolter  Done, tests are passing now.
I saw that you also closed the corresponding ticket. But i didn't implement all api calls. (only the one my bot needs and i can test)

Thanks, @Achterhoeker . I'll merge this after I refactor it a bit.

Replaced by #1247.


Plugin time interval+refresh controls on detail pages

Kiali incorporates the time controls (interval and refresh selection) as part of the common design shared by all pages, including details:

But in the context of the plugin layout, these controls have been omitted to facilitate the integration with the common elements of the OpenShift Console:

The "Service Mesh" tabs require alternative "time controls" for this particular context.
This topic has been discussed with @andrew-ronaldson and there could be several options to consider:

One possibility could be to have something closer to the "minigraph" timestamp (that opens a small modal to allow the user to select/change the time selection and refresh), or also to add an action in the "minigraph" kebap.
Perhaps one can be more visible for users but in any case, the goal of this issue is to discuss this topic, get feedback from UX / @andrew-ronaldson about what could be the best option, and implement this alternative that should be available only on this context.
The issue is created under the plugin, but the work would require changes in the kiali UI (just to follow the introduced pattern of conditional rendering when the "parent kiosk" mode is active).

I was thinking something like this screenshot. Add the clock icon and make the text clickable to open a modal with the time range controls. This option would need a tooltip to show the full time detail because of the truncation.
Alternatively, we could have the time range dropdown option to select from the defaults or a custom range with the modal. The con of that is it doesn't display the full time info.

Making the time range clickable and showing a modal sounds fine.
My question is: where to accommodate the time controls in the other tabs? The time controls are common for all the Overview, Traffic, Inbound metrics and Traces tab (that's what is available for "Services"). That's the reason why those controls are currently at the top. By removing the time controls from the top and bringing them inside the Overview tab, we may also need to add these controls inside the other tabs (although, probably on the other tabs it is more straigh forward, because those have toolbars).

This option would need a tooltip to show the full time detail because of the truncation.

@andrew-ronaldson I think I don't understand this sentence. What should have a tooltip, and what would be truncated?

@lucasponce I have a question. In your main comment, I see you wrote that this alternative that should be available only on this context. Does that mean that what is being discussed here should only affect the "parent kiosk" mode, while the standalone Kiali should remain unchanged?

Does that mean that what is being discussed here should only affect the "parent kiosk" mode, while the standalone Kiali should remain unchanged?

Correct. The "standalone" mode should not change. All these features should be under a conditional logic that detects the "kiosk" mode, similar to that implemented for links.

Closing, as I think this is now complete.