Can't handle the condition that device name changes after reboot

It seems like hwameistor can't handle the condition that device name changes after reboot.
before reboot:
root@pw3:~# pvs
  PV         VG                   Fmt  Attr PSize    PFree
  /dev/sdb   LocalStorage_PoolHDD lvm2 a--  <500.00g <390.00g
  /dev/sde   LocalStorage_PoolHDD lvm2 a--  <100.00g <100.00g

root@pw1:~# kubectl get localdisk -o wide | grep pw3
NAME      NODEMATCH   OWNER                PHASE   HEALTH   RESERVED
pw3-sda   pw3         system               Bound   Passed   true
pw3-sdb   pw3         local-storage        Bound   Passed
pw3-sdc   pw3         system               Bound   Passed   true
pw3-sdd   pw3         system               Bound   Passed   true
pw3-sde   pw3         local-storage        Bound   Passed
pw3-sdf   pw3         local-disk-manager   Bound   Passed
pw3-sdg   pw3         local-disk-manager   Bound   Passed
pw3-sdh   pw3         local-disk-manager   Bound   Passed

lrwxrwxrwx 1 root root   9 Jul 10 18:56 scsi-0QEMU_QEMU_HARDDISK_pw-hot-plug-4 -> ../../sdf

after reboot:
root@pw3:/dev/disk/by-id# pvs
  PV         VG                   Fmt  Attr PSize    PFree
  /dev/sde   LocalStorage_PoolHDD lvm2 a--  <100.00g <100.00g
  /dev/sdf   LocalStorage_PoolHDD lvm2 a--  <500.00g <390.00g

root@pw1:~# kubectl get localdisk -o wide | grep pw3
NAME      NODEMATCH   OWNER                PHASE       HEALTH   RESERVED
pw3-sda   pw3         system               Bound       Passed   true
pw3-sdb   pw3         local-storage        Bound       Passed
pw3-sdc   pw3         system               Available   Passed   true
pw3-sdd   pw3         system               Available   Passed   true
pw3-sde   pw3         local-storage        Bound       Passed
pw3-sdf   pw3         local-disk-manager   Bound       Passed
pw3-sdg   pw3         local-disk-manager   Bound       Passed
pw3-sdh   pw3         local-disk-manager   Bound       Passed

lrwxrwxrwx 1 root root   9 Jul 13 14:27 scsi-0QEMU_QEMU_HARDDISK_pw-hot-plug-4 -> ../../sdd

As we can see, sdb for lvm storage change to sdf, but localdisk doesn't realize it and its attributes don't change. And sdf for disk storage change to sdd, but pw3-sdd becomes incomprehensible.
I feel like it's inconsistent for hwameistor if device name changes after reboot
Hwameistor verion: v0.10.3

@AmazingPangWei Thanks for your feedback.
For now, we recognize and use disk by its devpath, i think it is reasonable to distinguish a disk by some unique, invariant attribute such as serial number.
We will fix this later and make some adjustment on the system above the disks.

How does this event happen? (I know it has to do with the order in which disks are scanned by the kernel). Did you do anything manual? Because this is a low probability event in our test results, of course, it does not mean that it will not happen, I just wonder how to easily and quickly reproduce this problem.

Well, it will be easy to reproduce if you have a virtual machine namely vm.

Prepare a vm node(for me, vm is node pw3).
Add a new disk when vm is running.
Check the new disk.

root@pw3:~# lsblk | grep sdi
sdi                                                                    8:128  0    10G  0 disk
root@pw3:~# ll /dev/disk/by-id/ | grep sdi
lrwxrwxrwx 1 root root   9 Jul 13 17:50 scsi-0QEMU_QEMU_HARDDISK_pw-hot-plug-7 -> ../../sdi
lrwxrwxrwx 1 root root   9 Jul 13 17:50 scsi-SQEMU_QEMU_HARDDISK_pw-hot-plug-7 -> ../../sdi

root@pw1:~/hwameistor# kubectl get localdisk -o wide | grep sdi
pw3-sdi   pw3                              Available   Passed

Claim it for disk storage

root@pw1:~/hwameistor# kubectl edit localdisk pw3-sdi
spec:
+ owner: local-disk-manager

root@pw1:~/hwameistor# kubectl apply -f - <<EOF
> apiVersion: hwameistor.io/v1alpha1
> kind: LocalDiskClaim
> metadata:
>   name: pw3-localdisk
> spec:
>   description:
>     diskType: HDD
>     capacity:<PHONE_NUMBER>0
>   nodeName: pw3
>   owner: local-disk-manager
> EOF

root@pw1:~/hwameistor# kubectl get localdisk -o wide | grep sdi
pw3-sdi   pw3         local-disk-manager   Bound       Passed

Create a workload that use block storage sdi. For simplicity, I use deployment with 1 replicas.

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: deployment-disk-volume
spec:
  accessModes:
    - ReadWriteOnce
  volumeMode: Block
  resources:
    requests:
      storage: 10Gi
  storageClassName: hwameistor-storage-disk-hdd

---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  replicas: 1
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      nodeSelector:
        kubernetes.io/hostname: pw3
      containers:
        - name: nginx
          image: nginx:latest
          imagePullPolicy: IfNotPresent
          volumeDevices:
            - name: data
              devicePath: /dev/pw-disk
          ports:
            - containerPort: 80
      volumes:
        - name: data
          persistentVolumeClaim:
            claimName: deployment-disk-volume

Enter nginx container and check block device

root@pw1:~/hwameistor# kubectl exec nginx-deployment-59555c5d4-wtnbv -i -t  -- /bin/bash
root@nginx-deployment-59555c5d4-wtnbv:/# ls -l /dev/pw-disk
brw-rw---- 1 root disk 8, 128 Jul 13 10:11 /dev/pw-disk

As you can see MAJ:MIN(8:128) matches /dev/sdi, so /dev/pw-disk is the /dev/sdi

reboot vm.
Check disk again

# sdi changed to sdb
root@pw3:~# ll /dev/disk/by-id/ | grep pw-hot-plug-7
lrwxrwxrwx 1 root root   9 Jul 13 18:31 scsi-0QEMU_QEMU_HARDDISK_pw-hot-plug-7 -> ../../sdb
lrwxrwxrwx 1 root root   9 Jul 13 18:31 scsi-SQEMU_QEMU_HARDDISK_pw-hot-plug-7 -> ../../sdb

# My another disk changed to sdi
sdi                                                                    8:128  0     1M  0 disk

root@pw3:~# ll /dev/disk/by-id/ | grep sdi
lrwxrwxrwx 1 root root   9 Jul 13 18:31 ata-QEMU_HARDDISK_QM00007 -> ../../sdi
lrwxrwxrwx 1 root root   9 Jul 13 18:31 scsi-0ATA_QEMU_HARDDISK_QM00007 -> ../../sdi
lrwxrwxrwx 1 root root   9 Jul 13 18:31 scsi-1ATA_QEMU_HARDDISK_QM00007 -> ../../sdi
lrwxrwxrwx 1 root root   9 Jul 13 18:31 scsi-SATA_QEMU_HARDDISK_QM00007 -> ../../sdi

When pod is running again, enter nginx container:

root@nginx-deployment-59555c5d4-k4sfl:~# ls -l /dev/pw-disk
brw-rw---- 1 root disk 8, 128 Jul 14 01:34 /dev/pw-disk

you can see nginx container is using new sdi, but which is not original sdi

I did the same test on my virtual machine, maybe due to the different types of disks, the device name did not change after I restarted the virtual machine. Subsequent tests may include scenarios where the device name changes after the virtual machine is restarted.

@FloatXD Try to hot plug many disks(step 2), and there is a high probability that device name changes after reboot.

For now, we recognize and use disk by its devpath, i think it is reasonable to distinguish a disk by some unique, invariant attribute such as serial number.

Maybe ID-PATH should also be considered. I did this test:
Before reboot:
root@pw2:~# lsblk | grep sdd
sdd    8:48   0    10G  0 disk

root@pw2:~# ll /dev/disk/by-path/ | grep sdd
lrwxrwxrwx 1 root root   9 Aug  1 14:59 pci-0000:02:00.0-scsi-0:0:0:3 -> ../../sdd

After reboot:
root@pw2:~# lsblk
NAME   MAJ:MIN RM   SIZE RO TYPE MOUNTPOINTS
sda      8:0    0   600G  0 disk
├─sda1   8:1    0     1M  0 part
└─sda2   8:2    0   600G  0 part /
sdb      8:16   0    10G  0 disk
sdc      8:32   0     1T  0 disk
sdd      8:48   0     1M  0 disk

root@pw2:~# ll /dev/disk/by-path/ | grep sdd
lrwxrwxrwx 1 root root   9 Aug  1 15:03 pci-0000:00:1f.2-ata-3 -> ../../sdd
lrwxrwxrwx 1 root root   9 Aug  1 15:03 pci-0000:00:1f.2-ata-3.0 -> ../../sdd
root@pw2:~# ll /dev/disk/by-path/ | grep sdb
lrwxrwxrwx 1 root root   9 Aug  1 15:03 pci-0000:02:00.0-scsi-0:0:0:3 -> ../../sdb

As you can see, sdd has become to sdb and /dev/disk/by-path/pci-0000:02:00.0-scsi-0:0:0:3 still point to the correct device.

Wow, that's great!!

For rbd device, which do not have Model、Vendor、Serial、By-path Devlinks like this:
apiVersion: hwameistor.io/v1alpha1
kind: LocalDisk
metadata:
  creationTimestamp: "2023-07-27T09:27:50Z"
  generation: 8
  name: pw1-rbd0
  resourceVersion: "49706513"
  uid: fc4cbe56-1b99-4b18-8980-b35805f4aaf6
spec:
  capacity:<PHONE_NUMBER>0
  devicePath: /dev/rbd0
  diskAttributes:
    devType: disk
    type: SSD
  nodeName: pw1
  raidInfo: {}
  reserved: true
  smartInfo:
    overallHealth: Failed
  state: Active
  uuid: d41d8cd98f00b204e9800998ecf8427e
status:
  claimState: Available

have you considered this situation?

devices which don't have both Serial and by-path symlink will not be abstracted to a LocalDisk object.
However, does RBD have an attribute type Serial to identify it? If so, we should fill it into the attribute of Serial. How to obtain this identifier will be achieved by means specially adapted to RBD devices.

this will be implemented in another PR


voidtools.Everything.Alpha version <IP_ADDRESS>5

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree [company="hobedere.com"]

@microsoft-github-policy-service agree

Close with reason: Replaced by PR 82819 to avoid pull request being stale;


Naomi Ibe

Following the contributors guidelines, I've made some changes in my branch files. All the boxes aren't checked yet though, I'm still working on the tasks

Hi @Amarajah! I noticed your pull request has branch conflicts which won't allow your pull request to be accepted.

Hi @Ranecodes thank you very very much!!! Please could you help me verify that I actually did it correctly this time? Its showing "Able to merge" tho


currentLang doesn't get defaultLanguage setting

Current behavior
In app.module.ts, translateModule is imported with a default language en.
in app.component.ts,  this.translate.currentLang = undefined.
I need to use this.translate.use('en');I feel it is a bit redundant to get this.translate.currentLang = 'en'
Expected behavior
this.translate.currentLang = 'en'. as soon a defaultLanguage is set
Minimal reproduction of the problem with instructions
app.module.ts
imports: [
  TranslateModule.forRoot({
      defaultLanguage: 'en',
  }),
],

app.component.ts
ngOnInit() {
   this.currentLang = this.translate.currentLang;
    console.log(this.currentLang);
  }

Environment

ngx-translate version: 12.1.1
Angular version: 9.0.1

Browser:
- [x] Firefox version 73

For Tooling issues:
- Node version: v12.15.0
- Platform:  Linux

@ocombe is it possible to have a look at this one? I would also expect that the currentLanguage would contain the defaultLanguage.


add intelligent tiering storage class

Added support for configuring storage class at the time of writing data.
Currently supported Storage classes are standard and Intelligent Tiering.

Info on S3 Storage classes: https://aws.amazon.com/s3/storage-classes/
Cleaned up the PR https://github.com/prestosql/presto/pull/2686

Merged, thanks!


Single-instruction-read/writes atomics

We have Mutex. However, opening a critical section (disabling interrupts) to just read or write a Mutex<Cell<u8>> seems a bit overkill: the read or write is a single instruction, which makes it impossible for an interrupt to hit in the middle.
How about this crate also provides some form of atomics with respect to what the Send and Sync markers mean in our context?
(I beleive they would be implemented this way, I'd be very willing to open a PR)
use core::cell::UnsafeCell;

pub struct SingleCoreAtomicUsize {
	inner: UnsafeCell<usize>,
}

/// Safety:
/// We only provide `get` and `set`, which all take a single instruction, so no interrupt may hit in the middle
unsafe impl Sync for SingleCoreAtomicUsize {}

impl SingleCoreAtomicUsize {
	pub const fn new(val: usize) -> Self {
		Self {
			inner: UnsafeCell::new(val),
		}
	}
	pub fn get(&self) -> usize {
		unsafe { *self.inner.get() }
	}
	pub fn set(&self, val: usize) {
		unsafe { *self.inner.get() = val }
	}
}

This is AtomicUsize

This is AtomicUsize
But is this available on single-core platforms, e.g. Cortex M0? I thought it wasn't.

The atomic types are available everywhere (if not, that's a bug in Rust or LLVM), but CAS operations might not be. load and store are always available.
You still need to synchronize access between interrupt handlers and idle. As written, SingleCoreAtomicUsize causes data races between every get and set, which is undefined behavior.

The atomic types are available everywhere (if not, that's a bug in Rust or LLVM), but CAS operations might not be. load and store are always available.

Thanks, I will double check this.

You still need to synchronize access between interrupt handlers and idle. As written, SingleCoreAtomicUsize causes data races between every get and set, which is undefined behavior.

I don't understand what data race you're talking about. Could you give an example of a scenario where the data race would trigger, and how it's UB?

The unsafe impl Sync allows use of SingleCoreAtomicUsize across threads, but there is no inner synchronization, so any usage of get or set from more than one thread would be a data race, as the stores and loads happen unsynchronized with each other.
This is still the case if you replace "thread" with "interrupt handler". For example, the compiler might assume that a value loaded by subsequent gets stays the same if there is no set inbetween. This is wrong in the presence of interrupts.
The Relaxed ordering is all you need as long as you only need to synchronize accesses of the AtomicUsize itself, not any other data (the other orderings are used when writing lock free data structures with atomics, and affect how the compiler synchronizes non-atomic accesses to the actual data stored in the data structure).

Thanks a lot for the explanation :+1: I think I understood almost all of it now! :)

The compiler might assume that a value loaded by subsequent gets stays the same if there is no set inbetween. This is wrong in the presence of interrupts.

From the UnsafeCell documentation:

UnsafeCell is a type that wraps some T and indicates unsafe interior operations on the wrapped type. Types with an UnsafeCell field are considered to have an 'unsafe interior'.
The compiler makes optimizations based on the knowledge that &T is not mutably aliased or mutated, and that &mut T is unique. UnsafeCell is the only core language feature to work around the restriction that &T may not be mutated.

I thought this explained it prevented that kind of optimizations.and enforced actually re-reading the value everytime it's asked.
Does it actually only force re-read if the compiler detects it might have changed due to some mutable aliasing, but in the same execution flow?

That was just an example of an assumption that a compiler might make. You'd have to ask that question in terms of Rust's language semantics to get a complete answer, and I'm not sure how the precise answer looks there.

@Ten0
Here is a real example with your code https://godbolt.org/z/GsYx1q
you can see that
    // Wait for the flag
    while FOO.get() == 0 {
        // nop
    }

is compiled to
    // Wait for the flag
    if FOO.get() == 0 {
        loop {
            // nop
        }
    }

Compiler assumes there is no data races in the code, so value of FOO can never change inside the loop. Which means no need to read it every time we can check it only once.

This exact problem actually can occur with the bare-metal Mutex, which is why we added documentation in #34 after discussion in https://github.com/rust-embedded/bare-metal/pull/33#issuecomment-634210146. In the cortex-m crate, compiler fences or memory clobbers are used when entering and leaving critical sections to ensure the compiler does not move accesses outside the the critical section, as otherwise @pftbest's example above would miscompile the same way.

Great, thank you for all the examples and references!
Closing this as it's already in core.


Request to disable team-side notifications per user

We (Support) have been seeing a lot of requests to disable certain Heroku Team-wide email notifications on a per-user basis. This uptick in interest is what has lead to me creating this issue.
After a discussion with Kevin, I'm creating this issue to recommend that we do something (the implementation of which is certainly not clear at this point) to allow users to disable these on a case-by-case basis.
Here is the support ticket which prompted this.

Hi @slant! Has this been taken into consideration? I find it very frustrating to have to make gmail filters to stop seeing emails from certain teams/apps.
I think this could be a very good addition to Heroku!

I would also find this useful. Working in a large team, I have responsibility for only a subset of apps, but get notifications for all of them. I am similarly forced to rely on gmail filters, which is a bit troubling, as if I am subsequently assigned to work on a project, I will need to remember to reconfigure my filters.


[Deleted Object]s (free()'d objects) should be treated as null

Currently any free()'d objects, when passed to a function or read from a variable, aren't treated as null for the purposes of comparison. It'd be nice to see them treated as null, so I can do if some_object, and if some_object happens to have been free()'d beforehand (that is, when you print that object, it prints [Deleted Object]), it will be treated the same as if some_object was actually null (since it effectively is null at that point).

I'm not sure to which extent this is possible. There is a semantic difference between a freed object and a null. And I think this system to detect deleted object isn't present in release builds.
Consider this:
var a = Object.new()
b = a
a.free()

At this point should a and b be set to null? For the sake of simplicity for the scripting language, it could be so. Setting both variables effectively to null is much better than to just treating freed objects as null. But it is not trivial to make it happen for what I understand.
The question is: how to implement this in an efficient way that works reliably even on release builds (without having to check all the time if the object is freed or not)?

That's what is_instance_valid valid was added for. The correct way in this case would be checking both for null and is_instance_valid.

And I think this system to detect deleted object isn't present in release builds.

If it's anything, I did encounter [Deleted Object] being printed on a release build while trying to figure this out.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

@reduz Was this implemented when Variant was made to store ObjectID?


[Issue 2899] Distribution by counties!

Resolves #2899
Description
Ability to have show the distribution by counties. at a high level.
Addition of optional areas_served partial to partner profile.   This allows partners to select the counties they serve, and assign a percentage to each.
Distribution by county 'report'.  Note this is not currently exportable.
Button leading to distribution by county report added to dashboard
Import of US counties

NOTE:   The Import of US counties job ( load_us_counties) will have to be run when this is promoted !!!!!!!

Some decisions I'm not 100% sure are the best:
1/  County has full name (e.g. Washington County, Vermont)  and region (Vermont) only -- maybe it should have the short name (without region) also.  But I think we could run a job to extract it in the future if we have need.  Chose region rather than state, because we include US territories.
2/ I chose show, rather than index or something else for the action for distribution_by_county.   It is an endpoint rather than a jumping off point, though I can imagine a world where we would want to have links on each county. Will show be confusing - i.e. will people think there is a corresponding ActiveRecord?
3/  Not 100% happy with the name "served_area" for the model.   Service areas?  Served_areas at least matches up with areas_served, which is the title of the partial.  I thought about using client_share as the name,  but served_area allows the possibility of having other things about the area in the future better.
I do expect we will be asked to expand this in the future, to show (for example) diapers by county.   But let's see what happens -- that should not require more input.
Dependency:
gem "activerecord-import"
And it does use js, including select2.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
New automatic tests
manual testing as I went along
Note that you will have to either bin/setup or just run the load_us_counties rake job in order to manually test .

Hey @dorner.   Would love your review, but even if it passes muster, let's not merge it until what's in the current main gets deployed to production (I don't want any QA issues with this to hold up the current release.)

With re the questions above:

You can add a migration that calls the Rake task.
It probably would be best to name it anything other than show since there is no corresponding model. You could even just call it distributions_by_county again.
I think ServedArea is a bit clunky but clear in what it represents. I don't think it needs to be changed.

Thanks, @dorner!  I hope to address most of these this week, FYI.

I think I've caught everything except the stimulus controller -- which is not yielding easily.

The tests are all passing on local.

Alas, there is still a problem with this -- the deletion is not working properly.  Putting it to a WIP state.

Ok.  The problem with the removal of served areas has been solved -- I'm a little concerned with my solution, though.  With the data-actions on delete_served_area_button in ui_helper.rb,  can we be sure that the first click will complete before the second one starts,  or are we going to have to go down the road of zeroing the value, and then somehow calling the enveloping controller.     It seems to be working, but my sample set is small.

I'm also getting a fair number of cases where these new tests are failing on first go.  It seems to be related to Faker.Address.unique.community calls.   They always pass on the second go.     Setting it aside for the nonce, as I have some  meaty support stuff to work on, but will want to revisit.

Per @awwaiid's vocal request,  I've merged main in, and found one of the tests that sometimes fail as an example: the test is at ./spec/models/partners/served_area_spec.rb:23   and the error is
Faker::UniqueGenerator::RetryLimitExceeded: Retry limit exceeded for community

This just reinforces my dislike of using randomly generated data in tests. If there is a failure, you can't reliably reproduce it, and it makes writing the tests themselves a lot harder.

Have changed the county factory to use a sequence instead of a unique community.  Bleah.

Don't forget to dd a migration that calls the Rake task. :)

@cielf is this ready for re-review? Haven't looked at it in a while.

@dorner  Yes.  I believe it is.

Hmmm.... that's odd -- it only did 1 check when I put the latest thing up -- I've not seen that before.  Noting it to @dorner, and also requesting a re-review

Looks like we've got a real conflict here!   We've taken somewhat different approaches, etc.

@cielf all looks good - now we have a conflict with schema.rb :laughing:

@dorner Yeah.  I can handle that.  Just use the most recent one.

Holding my breath and pushing merge!  (We don't have anything else that's big in the pipe for this release)


Change the default for num_epochs to 1 from None in make_csv_dataset

The default for the num_epochs parameter in make_csv_dataset is None:
    num_epochs: An int specifying the number of times this dataset is repeated.
      If None, cycles through the dataset forever.

This is really confusing to the user (at least, it was very surprising and confusing to me). I could not tell why my training appeared to be 'hanging'. It turned out it was due to this default. I propose that this be changed to 1. Looping forever is highly unexpected and leads to many user time cycles left trying to debug and understand what's happening.
I'm filing this per the discussion in TFRS regarding this problem which took a long time to troubleshoot and fix. Per that discussion,

[the]... default [...] goes against the compositional nature of tf.data APIs (where you'd normally stick a .repeat() at the end if you want an infinite dataset).

(Opening an issue here to replace https://github.com/tensorflow/io/issues/1377 per @yongtang 's suggestion).

:+1:
In the tf.data world the usual way to get an infinite dataset is to use dataset.repeat(). It is therefore surprising that this repeats infinitely by default. I suspect this is because this API predates the modern tf.data functions?

Good point, I guess we'll find out once we hear from some folks @ tf core.

@dgoldenberg-audiomack I agree 100%, it shouldn't repeat by default. Switching the default on the experimental.make_csv_dataset symbol will likely break existing users though, so it is prudent to wait until we migrate make_csv_dataset out of "experimental". I'm adding a TODO reminder in the code.

Thanks, @aaudiber, I think that sounds like the right time to do it. Maybe this ticket can be referenced from that epic when it comes around.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Add a blog entry for Zoltan Csizmadia as a new committer

https://lists.apache.org/thread/0c4s279gyxcl8lxg69q33grznn8kksjd
Jira

[ ] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://issues.apache.org/jira/browse/AVRO-XXX
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[X] Added a new entry to the site's blog section

Cherry-picked to branch-1.11.


No IntelliSense for generic literal types

From https://github.com/microsoft/vscode/issues/83375

TypeScript Version<EMAIL_ADDRESS>
Search Terms:

suggest / completions
intellisense
generic

Repo
For the typescript:
function test<T extends "x" | "y">() {}

test<''>

Trigger intellisense inside the quotes in test<''>

Expected behavior:
Suggestions for x and y returned.
Actual behavior:
No suggestions returned

Note that this issue also occurs with class heritage.
type S = 'a' | 'b' | 'c';

abstract class C<T extends S> {}

class ImplC extends C<''> {} // try autocomplete in the ''

But it works fine with variables.
type S = 'a' | 'b' | 'c';

type G<E extends S> = Readonly<E>;

let a: G<''>;  // autocomplete works fine here


feat(components): add spinner component

Spinner
This PR adds a Vercel style spinner component

@olekbaran What do you think about using an svg icon from lucide-react and animate-spin?
import { Loader2 } from "lucide-react"

<Loader2 className="animate-spin" />

@olekbaran What do you think about using an svg icon from lucide-react and animate-spin?
import { Loader2 } from "lucide-react"

<Loader2 className="animate-spin" />

I think my loader is a better match for the components' style and more in line with your original idea. The whole library is designed with the Vercel style, so I made a loader that replicates it. But, the final decision is all yours.


Custom KeyInfo, avoid adding empty/unneeded namespaces

I'm trying to create a custom KeyInfo. This mostly works with something like this:
function AssertionKeyInfo(assertionId) {
  this.getKeyInfo = function(key, prefix) {
    return `<wsse:SecurityTokenReference wsse11:TokenType="http://docs.oasis-open.org/wss/oasis-wss-saml-token-profile-1.1#SAMLV1.1" wsu:Id="STR-${uuidv4()}"
          xmlns:wsse11="http://docs.oasis-open.org/wss/oasis-wss-wssecurity-secext-1.1.xsd">
          <wsse:KeyIdentifier ValueType="http://docs.oasis-open.org/wss/oasis-wss-saml-token-profile-1.0#SAMLAssertionID">${assertionId}</wsse:KeyIdentifier>
      </wsse:SecurityTokenReference>`;
  };
}

This is the result:
<ds:KeyInfo>
	<wsse:SecurityTokenReference wsse11:TokenType="http://docs.oasis-open.org/wss/oasis-wss-saml-token-profile-1.1#SAMLV1.1"
		xmlns:wsu="" wsu:Id="STR-ce7f89b3-d5c0-459c-b2e7-3fd656ff7cb9"
		xmlns:wsse11="http://docs.oasis-open.org/wss/oasis-wss-wssecurity-secext-1.1.xsd"
		xmlns:wsse="">
		<wsse:KeyIdentifier ValueType="http://docs.oasis-open.org/wss/oasis-wss-saml-token-profile-1.0#SAMLAssertionID">_81d5fba5c807be9e9cf60c58566349b1</wsse:KeyIdentifier>
	</wsse:SecurityTokenReference>
</ds:KeyInfo>

The problem is that the prefix wsu and wsse is added here.
This is not needed because the namespaces are already defined outside the signature.
Is there a way to prevent adding these namespaces?
I guess this happens because the signature is parsed as a separate document?
var signatureDoc = new Dom().parseFromString(this.signatureXml)

I could create a PR, but not sure about the best method. Maybe getKeyInfo shoud be done inside createSignature so that I can use dummySignatureWrapper with some extra namespaces defined in options?

A dummySignatureWrapper doesn't work. The namespace is always added. Not sure if there is a solution for this.

There is a bigger reason to this - namespace propagation in xmldom does appear to work correctly, see examples of this in jindw/xmldom#247. I would suggest following up there in addition to the PR you have submitted, but it seems that the package is no longer actively maintained, and I already have too much on my hands tending to this package.

Are there sections of the XML signature spec that address the correct behavior here?
https://www.w3.org/TR/xmldsig-core2/


Create a terraform module for knative-operator charm

Context
According to the terraform modules organization spec, this is the first step to provide a terraform solution module. We need to create a terraform module for each charm.
What needs to get done
Create a terraform module for this charm that complies with the spec.
Definition of Done
Charm has a terraform module

Closed by #227 and #228


access content in multiple namespaces

I wanted to verify that it is possible to get data from multiple namespaces, and if so how that is accomplished?
The index page of the example appear to try and do this https://github.com/isaachinman/next-i18next/blob/master/example/pages/index.js
The confusion I has was that withNamespaces() never attempted specify 'footer', that was only in the namespacesRequired() above.  Is this correct?

Sorry, can you explain what you mean?
Yes, for whatever namespaces you declare in namespacesRequired, those namespaces will be loaded for that page, both on the client and server. It doesn't matter how many.
withNamespaces provides namespaces to the component that it wraps. However, namespacesRequired provides the total available namespaces to the entire React tree. Does that make more sense?

This  makes sense, thanks for the clarification!

Hi @mengqing, please remember that next-i18next is built on top of react-i18next.
You can check the withNamespaces docs here. Basically, you would do:
class Footer extends React.Component {
  render() {
    return (
      <React.Fragment>
        {this.props.t('footer:description')}

{this.props.t('something-else:hello')}

      </React.Fragment>
    )
  }
}

export default withNamespaces(['footer', 'something-else'])(Footer)


fix: change "main" module to avoid shebang

Shebangs prevent BundlePhobia from calculating the bundled size.
https://bundlephobia.com/result?p=meta

Ideally, BundlePhobia shouldn't choke on shebangs, since node doesn't.
/cc @pastelsky

@mateodelnorte can you think of any adverse affects of changing this?

@aleclarson have you tested this does what you need? once you point to index, it's probably going to pass your command because there's nothing to do. index.js is empty.

@mateodelnorte I see your point! What are your plans for index.js? Will it expose a programmatic API or is require('meta') meant to be identical to the meta CLI? I think the former makes more sense. You can always require('meta/bin/meta') or even move it to require('meta/bin').

no plans for it. it's just a forgotten artifact from when I first made the repo.
the larger question is what you want to solve, though. what's the intention of bundling meta? making it installable without npm?

I was trying to use BundlePhobia to see which dependencies are heaviest. Maybe there's a better tool out there?

that, I dunno. but another good direction for this would be to package meta so that it doesn't require npm to install. pkg is a great one for that. you might be able to rejigger ./index.js to reference other files in meta. but another thing that's going to get in your way is that all commands are separate processes. they call each other in the same way git child commands do, where it will detect that a file exists with the name meta-git-stash and translate you calling meta git stash into executing this command. that's all in commander.js.

Closed in favor of #65


Bump scala-cli to 1.4.1 + drop old cli management

cc @WojciechMazur @Kordyjan

I will wait for @bishabosha's review before merging this. unless we have some time constraints for backporting (@WojciechMazur ?)

I will wait for @bishabosha's review before merging this. unless we have some time constraints for backporting (@WojciechMazur ?)

There won't be a 3.5.1-RC2 before 3.5.0 is published, so don't worry about the backports


Include subsecond Exif information in pictures

I'm interested in using the capture_continuous() method to capture street sceneries while driving. Later on I'd like to geotag the pictures using a GPX track. Since the camera v2 is able to capture more than one picture per second, there may be cases where multiple Exif tags DateTimeOriginal show the same capture time. Because of this geotag software will geotag different pictures to the exact same coordinates, which is annoying when showing the capture locations on a map.
The Exif standard contains tag such as SubSecTimeOriginal to store subsecond values that could be used to geotag pictures more precisely. However, it seems that these tags are not written to picture by default.
Could these tags be added to picamera or is there a workaround to get these tags written?
BTW: I read https://github.com/waveform80/picamera/blob/974540f38793c79c69405948e2fffafb3a1025dd/picamera/camera.py#L1774-L1778 but assume this can only be used for Exif tags that don't change over time.

The firmware is missing the mapping for the string IFD0.SubSecTimeOriginal to tag number 0x9291. I'll look at adding it.
Most people aren't moving fast enough to make a huge difference within 1 second without motion blur or rolling shutter effects, but there probably are enough to make it worthwhile finding the 5 mins to add it.

@6by9 : Thank you, I'd be happy I you could have a look!

I'd looked in the wrong place. EXIF.SubSecTime, EXIF.SubSecTimeOriginal, and EXIF.SubSecTimeDigitized are al supported at the codec level (as correctly documented in the PiCamera docs). I'd looked at code that was automatically adding metadata based on the camera parameters.
@waveform80 would be better placed to answer whether you can update exif tags between continuous captures.

Erm ... good question ... I'm pretty sure it should be possible to modify the exif_tags dict during iterations of capture_continuous (I've had a cursory glance at the stuff down in encoders.py which seems to support this assertion). I'd suggest just trying it and let me know if it doesn't work!

@waveform80 : I set the values of exif_tags like this:
camera.exif_tags['EXIF.SubSecTime'] = datetime.datetime.now().microsecond)[:-3].zfill(3)

This seems to work fine. A complete script can be found at https://github.com/ltog/mapillary_utils/blob/master/raspi/autocapture.py .
Is this what you meant?
Thank you for your hints!


Vulkan rendering support on Android

This change enables Vulkan rendering for Android, based on the SurfaceView implementation from PR #36603. There are still some issues to solve, but as a first step Android is now functional again on the 4.0 branch.
Only Vulkan rendering is supported for now, but I've kept the old GL implementation along with this changes, so it should be easy to enable GLES2 again when it's ready.
CC @RandomShaper @m4gr3d @akien-mga @reduz
Remaining issues:

Missing 3D support (needs a new renderer implementation & shaders)
Shaders currently fail because of descriptor set limits (tested on Galaxy Note 5):

ERROR: On shader stage 'Vertex', uniform 'transforms' uses a set (4) index larger than what is supported by the hardware (4).
   at: shader_create (drivers\vulkan\rendering_device_vulkan.cpp:3728) - Condition "set >= limits.maxBoundDescriptorSets" is true. returned: RID()

Colors are off, maybe a texture format issue?
Example with TextureRect :

Normal
Android

Vulkan validation layers are not working (fails on vkGetInstanceProcAddr)
It's disabled on Android for now to avoid crashes.

Errors when using format list in RenderingDeviceVulkan::texture_create
vmaCreateImage fails with VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT (returns VK_ERROR_OUT_OF_HOST_MEMORY)
It's disabled on Android for now to avoid crashes.

Errors in RenderingDeviceVulkan::compute_pipeline_create
vkCreateComputePipelines returns VK_ERROR_INITIALIZATION_FAILED in some cases

ERROR: vkCreateComputePipelines returned error -3
   at: compute_pipeline_create (drivers\vulkan\rendering_device_vulkan.cpp:5143) - Condition "err" is true. returned: RID()

Missing VR support
There's specific initialization for GL, based on xrMode, it's not handled for Vulkan.

Missing fallback to GLES2

Building templates with Android API 18 to 23
Vulkan support should be disabled in this case.

Properly handle onVkSurfaceChanged event to update the rendering system
Right now, pausing and resuming the app causes it to restart completely instead.

Implementation Notes:

New Android SDK requirements for building templates (Vulkan headers and libs):
NDK version: 20.0.5594570
Min Android API: 24

The Vulkan loader is taken from the Android NDK, because the one we're using for other platforms doesn't support Android platform.
https://github.com/KhronosGroup/Vulkan-Loader/issues/96

VkRenderer calls GodotLib directly, so I got rid of vk_renderer_jni. It seems easier to have one common place for calls from GL or Vulkan implementations.

Fix for GodotInstrumentation in AndroidManifest.xml
This is used to force the app to restart.
I've kept the same hack that was used for GL to restart the whole app after paused, but we might want to improve it later by restarting only the rendering system.

Plugins:
Added vulkan specific callbacks in addition to the GL ones, but maybe the interface could be harmonized between the two to make it easier for the user.

Bugsquad edit: Fixes #36919.

@akien-mga Thanks for the review! I've just pushed some changes based on your comments.

I think this is OK, although it may need to be refactored to use the DisplayServer code that will be merged in a week or two.

Thanks @m4gr3d! I've just pushed some changes that should address your previous comments.
So here are the remaining things to do before this PR can be merged:

Validate it's safe to call Main::setup() on the UI thread, then Main::setup2(Thread::get_caller_id()); on the render thread after it's created
Change the calls for plugins after PR #37174 is merged
Refactor the c++ part after the DisplayServer branch is merged

@akien-mga @reduz I'm done with making the Android port compatible with display servers. So if these changes are ok, I think it might be ready to merge when this last thing is validated:

Main::setup() is called on the UI thread, then Main::setup2(Thread::get_caller_id()); on the render thread after it's created by the android app. The parameter passed in setup2 allows to override Thread::_main_thread_id. It looks like it was made before for android but wasn't used recently. It seems to work so far but do you think it's safe to use it?

Thanks for the review @reduz! I've just added the #warning you asked for.
If everything's good around the display server code, this PR should be ready to merge.

after trying to rebase android editor onto this branch, I found some small things that I think should be refactored...
by my understanding and how it looks display server should process everything that the user input and outputs, that means that process_{input} (process_touch for example) should be moved to display_server_android from os_android as well, I can see that when I tried to merge my ( @m4gr3d for now, later I'll try your implementation) that things doesn't go where they should be

@thebestnom Ok, that makes sense. Thanks for the feedback! I can change it some time this week, but if you decide to do it in the meantime, please let me know and feel free to open a PR :)

@pouleyKetchoupp working on it :)

@pouleyKetchoupp hey, I commited everything but it doesn't let me open PR into https://github.com/nekomatata/godot/tree/android-vulkan-rendering

@thebestnom It looks like you would have to actually fork from my repo to be able to do that :/
I'll just cherry-pick the changes from your commit instead.

It looks like you would have to actually fork from my repo to be able to do that :/

I'm not sure, I can open PR to different forks, I think the problem is that it's team only repo or somthing like that, but it doesn't matter that much...
I wanted to make some commant on the code in the PR... so Ill just say it here,
while I moved most of the things as is, I changed process_event to be process_key_event and moved the implementation from java_godot_ lib_jni to the display server cause it made no sense for it to be there

Ok! I've seen the change with key events and it makes sense too. I've just pushed a new version that includes your changes.

Some comments from IRC:
23:39 <reduz> m4gr3d[m]: I think it's ok, just to make clear, Main::setup2() , Main::iteration() and the events that come from DisplayServer, should all be in the same thread
23:40 <reduz> m4gr3d[m]: which on android so far is the same thread used by Vulkan/OpenGL to render
23:40 <reduz> m4gr3d[m]: we could move the game logic to an other thread and leave the render thread only for rendering, but that will need some small changes to the engine, and I would probably prefer to implement this once everything else is working

Let's merge as is and refine in future PRs :)

Thanks!

Tested a local build, it's not finding vk_mem_alloc.h. #thirdparty/vulkan/ should be added to the CPPPATH.

Tested a local build, it's not finding vk_mem_alloc.h. #thirdparty/vulkan/ should be added to the CPPPATH.

It works after upgrading the NDK from r20 to r21 as r21/sources/third_party/vulkan/src/layers/vk_mem_alloc.h as been added, so we'll have to document r21 as minimum required version.

Tested a local build, it's not finding vk_mem_alloc.h. #thirdparty/vulkan/ should be added to the CPPPATH.

It works after upgrading the NDK from r20 to r21 as r21/sources/third_party/vulkan/src/layers/vk_mem_alloc.h as been added, so we'll have to document r21 as minimum required version.

@akien-mga @pouleyKetchoupp We can specify an NDK version in the build.gradle file as shown here.
We could use that to enforce the NDK version that's used.

@m4gr3d In order to be more flexible when GLES2 is supported again, we could detect the NDK version during the build, and when the requirement is not met, show a warning and disable Vulkan support.

@m4gr3d In order to be more flexible when GLES2 is supported again, we could detect the NDK version during the build, and when the requirement is not met, show a warning and disable Vulkan support.

@pouleyKetchoupp that sounds overly complex and I'm not sure what the benefit would be done resolving the correct ndk version is a fairly simple task.

can't you just use ndkVersion in build.gradle? there is no benefit from using older ndk from my understanding

Can someone make a tracker issue for all the issues mentioned in first comment?

@Anutrix Ok, I can make one.

@Anutrix Tracker issue: #39033


The grammar doesn't handle empty table headers though those seem to be supported?

https://github.com/cucumber/cucumber/tree/master/datatable has examples with empty table headers.

Yup, just the simplest implementation right now.
https://github.com/cucumber/cucumber/tree/master/datatable#for-contributors
Patches absolutely welcome. 😄 👍

The features I have which originally lead me to file this now parse with the latest github branches, thanks. Now I just wait for the next release. :)

Published v0.6.0. :)


Allkinds project update for Showcase

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

[ ] You have updated the .github/CODEOWNERS file according to your changes.
[ ] You have registered new documents to /sidebars.js if any.

Hi @allkindsxyz ,
Could you take a look at the image file you included? It appears to be an invalid image source.
Thank you!

Fixed the image source

Hi Jessie,
Fixed the image.
Best regards,
Dima
On Thu, Jul 27, 2023 at 12:49 AM Jessie Mongeon @.***>
wrote:

Hi @allkindsxyz https://github.com/allkindsxyz ,
Could you take a look at the image file you included? It appears to be an
invalid image source.
Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/dfinity/portal/pull/1730#issuecomment-1652645056, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AP5KYESDLJG4WUBZQUP4S5LXSGNJFANCNFSM6AAAAAA2YR264A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @allkindsxyz ,
Did you intend to close this merge request?
Thanks

No, I am not. Sorry for this.
Best regards
Dima
On Thu, 27 Jul 2023 at 17:17, Jessie Mongeon @.***>
wrote:

Hi @allkindsxyz https://github.com/allkindsxyz ,
Did you intend to close this merge request?
Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/dfinity/portal/pull/1730#issuecomment-1653716663, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AP5KYEQMQKW5MZU3WUDEBM3XSJZ7DANCNFSM6AAAAAA2YR264A
.
You are receiving this because you were mentioned.Message ID:
@.***>


Cannot able to see files in geotrellis-landsat-emr-demo

upload: viewer/site.tgz to s3://geotrellis-test/emr/site.tgz
upload: server/target/scala-2.10/server-assembly-0.1.0.jar to s3://geotrellis-test/emr/server-assembly-0.1.0.jar
upload: ingest/target/scala-2.10/ingest-assembly-0.1.0.jar to s3://geotrellis-test/emr/ingest-assembly-0.1.0.jar
The three above mentioned files are missing in the repository. Please look in to it if they are available indifferent path.

Hi @rajesh7221 ! These files should not be in the repo, they can be build from this repo sources. Try to run make upload-code.

Thanks for the quick response.While running this command 'make upload-code'.Do we need to update the files in config-aws.mk or any other place. Because I cannot able to get the above mentioned files it is ending up with errors. Please let me know

Yes you need your own credentials file. The reference on how to build this project can be found here (Makefile ref), and here (Readme.md ref).


Applying rule to app with minimized windows results in layout with invisible windows

What's wrong?
When you apply a rule to an app that has existing windows that are minimized, yabai includes those windows in the layout but leaves them minimized. The result is a layout with holes for invisible, minimized windows. See attached video.
https://user-images.githubusercontent.com/121654/190479767-15050840-1331-4da9-8c45-d2c34bf1e420.mp4
Reproducing
Using any two apps that can open multiple resizable windows:

Start Terminal.app (Alacritty, in my video) and open two or more windows
Start Minimized.app (Firefox, for me) and open at least one window, then minimize all Minimized.app windows
In one of the terminal windows, run yabai --verbose
In the other terminal window, run:
a. yabai -m config layout bsp
b. yabai -m rule app=. manage=off
Terminal.app windows will snap into, then out of the layout.
Then, run, replacing Terminal and Minimized with the actual app names under test:
a. yabai -m rule 'app=^Terminal$' manage=on
b. yabai -m rule 'app=^Minimized$' manage=on

The result will be a layout with holes in it, for the minimized application's windows.
Possible solution
PR #1417 makes the check for minimized windows more general so they are excluded by yabai's window manager.

Same issue exists for hidden windows. Fixed on master.


chore(*): Resolve joint debugging problem

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @your-reviewer

Release note:

NONE

/assign @gaocegege @FogDong

ping @FogDong


Possible helpful framework

Dear TurugaLab,
Here you can find WaveBlocks framework, another differential wave optics simulator.
Maybe you can get some ideas and hints from the implementation :)
I will give chromatix a try and will be happy to help if required.
Cheers!
Josue

Hi Josué,
Thanks for sharing --- looks like we have a lot of similar ideas!
We actually also originally built a library in PyTorch for simulating a 4f microscope, which we scaled to multiple GPUs in order to optimize large PSFs for snapshot microscopy using deep learning.
This turned out to be pretty slow for various reasons, and we've since found that jax results in much more performant (and memory efficient) simulations for optics --- and also makes it very easy to parallelize those simulations both on a single GPU and across multiple GPUs.
If you do try out chromatix, I'd love to know what you think! That said, we're in very early stages. There's a lot of stuff that's missing right now that your library can do (like microlens arrays). We'll be working on those kinds of things soon. I'm happy to answer any questions you might have (my email: debd@janelia.hhmi.org).
Best,
Diptodip


chore: remove repetitive words

Motivation
remove repetitive words
Test Plan
(If you changed any code, please provide clear instructions on how you verified your changes work.)
Related PRs
(Link any related PRs here)

I suggest tackling an existing issue: https://github.com/AleoNet/snarkVM/issues


Bugfix/remove script timeout attribute

What kind of change does this PR introduce?

Remove the script.timeout as it's not defined anywhere in the HTML standard https://www.w3.org/TR/html52/semantics-scripting.html#the-script-element, and there's no effect as I tested in modern browsers with network throttling enabled:
var script = document.createElement('script')
script.src = 'https://code.jquery.com/jquery-3.5.1.js'
script.timeout = 120
script.onerror = () => console.log('error')
script.onload = () => console.log('load')
document.head.appendChild(script)

The browser would spend more than 10 minutes (20:33:40 - 20:44:44) to load the script without timeout:

Did you add tests for your changes?
No. But I've updated all those examples with script.timeout.

Does this PR introduce a breaking change?

I don't think so.
What needs to be documented once your changes are merged?
Nothing.

Are there any updates on this? The configuration output.chunkLoadTimeout seems to only be used on this line. I have been getting ChunkLoadError timeouts and am looking to increase the timeout.


parser: support show analyze status

What problem does this PR solve?
Support new syntax for show analyze status.
For https://github.com/pingcap/tidb/pull/10172
What is changed and how it works?
Update the parser for show statement.
Check List
Tests

Unit test

Code changes

Has exported function/method change

Side effects

None

Related changes

Need to update the documentation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


i dont know english, but i have screenshots

Challenge Bonfire: Confirm the Ending has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

Failed to state a problem, Closing.
Quote Reference
Feel free to re-open if you want to describe what is wrong.

The problem is the text being displayed on the highlighted test.

It could be that test is missing message:  part


Make "Bug Report" button hideable (PC ver)

What happened?
It's covering a few games' UI hence ruining visibility
Steps to reproduce
Nothing
Operating System
Windows 10  (10.0.22000) 64bit
Wallet
Wallet Connect
CPU
AMD Ryzen 7 3700X 8-Core Processor
GPU
NVIDIA GeForce GTX 1070 8088MB
RAM
32679MB
Kernel Version
1.0.0-2503059035.commit-0dd1ae6
Unity Version
desktop-1.0.387-20220615161653.commit-3df2ab6
Realm
No response
NameTag
No response

Issue in scenes


Customise model code not working

I tried to use a custom model, as documented in the README, but ran into the SUPPORTED_MODELS check here:
https://github.com/AutoGPTQ/AutoGPTQ/blob/be78af8d4fd80b5afa0a8a7df7b0e0ec44420003/auto_gptq/modeling/_base.py#L666
It looks like there is also a check here which would cause it to fail:
https://github.com/AutoGPTQ/AutoGPTQ/blob/be78af8d4fd80b5afa0a8a7df7b0e0ec44420003/auto_gptq/modeling/_base.py#L825

You need to also add the model type into a few places. Look at this as an example: https://github.com/AutoGPTQ/AutoGPTQ/pull/481/files


CBAPI-3539: Update SDK to use watchlist manager v3 instead of v2 APIs

Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Tests have been added that prove the fix is effective or that the feature works.
[x] New and existing tests pass locally with the changes.
[x] Code follows the style guidelines of this project (PEP8, clean code, linter).
[x] A self-review of the code has been done.

What is the ticket or issue number?

https://jira.carbonblack.local/browse/CBAPI-3539
Pull Request Description

Replaces the v2 Watchlist APIs with v3 APIs, which includes ensuring that the org key is properly formatted into the URIs whenever necessary.
Does this introduce a breaking change?

[ ] Yes
[x] No

How Has This Been Tested?

Unit tests have been adjusted to reflect the changes.  No net loss of coverage as a result.  Additionally, a UAT script has been added.

Added in most recent commit.


Merge metadata-update-2023-09-13 into main

Automatic sync PR to update reference files from contrib

We'll likely want to make sure that the splunk distro has been released before pulling from contrib directly. If these are from 0.85.0 we've yet to adopt them.

Good point. I can revert if needed; how long till 0.85 for our distro?


Initial PR for secondary-scheduler-operator code

The secondary-scheduler-operator is developed following the example of cluster-kube-descehduler-operator.

/assign @ingvagabund @soltysh

@ArangoGutierrez for this operator we have decided on the library-go patterns used by most of the other core operators, specifically this aligns well with the scheduler and descheduler operators

@ArangoGutierrez for this operator we have decided on the library-go patterns used by most of the other core operators, specifically this aligns well with the scheduler and descheduler operators

Awesome, thanks for the pointer

https://github.com/openshift/secondary-scheduler-operator/pull/1/commits/965a58d05fb1276317c1614407a6353fcb4a62be#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261 moves cmd/secondary-scheduler-operator/main.go → main.go which is not expected by the Makefile. Can you please move the file back under the original directory?

manifests/4.8 and the CSV should also be updated to 4.9

965a58d#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261 moves cmd/secondary-scheduler-operator/main.go → main.go which is not expected by the Makefile. Can you please move the file back under the original directory?

to add to this, cmd dir is currently located under pkg, it should be in the root. So right now it's pkg/cmd/operator when it should just be cmd/secondary-scheduler-operator (change the command/package name to be secondary-scheduler-operator rather than just operator in that dir too)
After that (and @ingvagabund's comments), please squash back down to just 2 commits: 1 for code, and 1 for vendor. Then we can merge and continue to iterate from there

Thanks for adding the feedback @wangchen615. At this point I'd like to merge what we have. This PR is getting large and it will be better (and easier) in my opinion to start iterating on smaller changes as we find them.
/lgtm
/approve

Think I'll need to manually merge, so we need to get prow set up too (started here: https://github.com/openshift/release/pull/21755)


Add sample images to the unstable environment

Run an Nginx that serves (publicly) some sample images, and reference them in the XML.

Can probably still code-name this service file-store_nginx or similar, since it fulfills that role.

Proposed JATS starting point for https://github.com/libero/libero/issues/128 and https://github.com/libero/libero/issues/129:
<fig xml:base="[base-uri]">
    <caption>
        <title>[text]</title>
        <p>[text]</p>
    </caption>
    <graphic xlink:href="[uri]" mime-subtype="[web format]" mimetype="image"/>
</fig>

<caption> is optional, as are its children.
@xml:base not required if the @xlink:href is absolute.
@mimetype/mime-subtype not required if @xlink:href has a known file extension (eg xlink:href="some-image.jpg".
other <graphic> are ignored, and the whole <fig> is if they all are.
assumes that TIFFs etc are already converted to a web format.

/cc @Melissa37

Drafting a sample-configuration change to add the nginx container stubbing file-store.

https://github.com/libero/sample-configuration/pull/29


Connection Failed! Error and No Information about Fixing

The error Connection Failed! shows up whenever any kwmc command except for kwmc help is used.
It also shows up in the upper-left corner of the nerdbar widget for Übersicht.
There is no information included in the README or anywhere else about fixing this error.
The problem is particularly worse in v1.1.5 and doesn't get solved automatically as it did in v1.1.4 and older.

Connection Failed is the message showns when kwmc is unable to connect to the local server kwm runs on 3020. The only thing that makes sense is that your Kwm seems to crash for some reason.

Okay, so did the update break my kwm? If so, how can I fix it?
I am running OS X 10.11.4 on an 11" MacBook Air.

The syntax of some kwmc commands changed. Just compare your .kwmrc file to the one provided with homebrew, and update ones that got changed.

I'm using the default .kwmrc which came with v1.1.5.

Just to make sure, you placed the default .kwmrc at $HOME/.kwm/kwmrc yeah?
Also, you might need to upgrade to the latest xcode, or disable the borders.

I've had this problem and it was fixed by updating xcode, if that helps

My Xcode is v7.3, the latest one. That shouldn't be the issue.

Any update on this? I'm 99% certain this is caused by a faulty kwmrc file.

I still get the error, but with less frequency. I think that the issue has to do with my system.

Do you still have issues running version 2.0.1 ?
Keep in mind, you have to update your $Home/.kwm/kwmrc due to syntax changes.

There are no issues with v2.0.1. :+1:
Also, the latest version on homebrew is v1.1.5. I don't know if that's intentional, but just wanted to point that out. I had to install v2.0.1 from the source.

I am not sure what I am doing wrong? I have installed kwm just now from homebrew. First time installing it. I followed the instructions after install:
homebrew/binary/kwm: stable 2.0.3
Tiling window manager with focus follows mouse for OSX.
https://koekeishiya.github.io/kwm/
/usr/local/Cellar/kwm/2.0.3 (6 files, 5.4M) *
  Built from source
From: https://github.com/Homebrew/homebrew-binary/blob/master/kwm.rb
==> Caveats
Copy the example config from /usr/local/Cellar/kwm/2.0.3/kwmrc into your home directory.
  mkdir -p ~/.kwm
  cp /usr/local/Cellar/kwm/2.0.3/kwmrc ~/.kwm/kwmrc

To have launchd start homebrew/binary/kwm at startup:
  sudo cp -fv /usr/local/opt/kwm/*.plist /Library/LaunchDaemons
  sudo chown root /Library/LaunchDaemons/homebrew.mxcl.kwm.plist
Then to load homebrew/binary/kwm now:
  sudo launchctl load /Library/LaunchDaemons/homebrew.mxcl.kwm.plist

Nothing happens, and if I try kwmc start or kwmc config launchd enable I get Connection failed!. I can start kwm manually /usr/local/opt/kwm/kwm but when I try to use cmd-return to launch iTerm I get this error FSPathMakeRef(/Applications/iTerm2.app) failed with error -43.
Thanks

The homebrew instructions are wrong and should not be used. Undo the changes homebrew told you to do:
sudo launchctl unload /Library/LaunchDaemons/homebrew.mxcl.kwm.plist
sudo rm /Library/LaunchDaemons/homebrew.mxcl.kwm.plist

and do the following instead:
cp /usr/local/opt/kwm/*.plist ~/Library/LaunchAgents`
launchctl load -w ~/Library/launchAgents/homebrew.mxcl.kwm.plist`

@koekeishiya Awesome thanks! Now it is starting on it's own. cmd-return does not open a iTerm though? Also how did you remove you titlebars in the screenshot?

Awesome thanks! Now it is starting on it's own. cmd-return does not open a iTerm though? Also how did you remove you titlebars in the screenshot?

Make sure you have iTerm2 and not just iTerm, by default cmd-return will try to run open -na /Applications/iTerm2.app
For information about my setup, see #2


⚠ Bofrost.lu has degraded performance

In f0d6684, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1268 ms

Resolved: Bofrost.lu performance has improved in b0f058d after 6 minutes.


Does not give proper GLSL code

I am trying to optimize this vertex shader
uniform mat4 ModelViewMatrix;
uniform vec3 Position;
uniform vec2 Size;

#if __VERSION__ >= 330
layout(location = 0) in vec2 Corner;
layout(location = 3) in vec2 Texcoord;
#else
in vec2 Corner;
in vec2 Texcoord;
#endif

out vec2 uv;

void main(void)
{
    uv = Texcoord;
    vec4 Center = ModelViewMatrix * vec4(Position, 1.);
    gl_Position = ProjectionMatrix * (Center + vec4(Size * Corner, 0., 0.));
}

But when I click optimize I get
򀨑R

Seeing similar behavior sometimes.
I had to call it with glVersion = 2 to keep this from happening on a shader using gl_PointCoord - else I got this weird output instead of an error message, for instance.
@zz85
It might be a good idea to pull up the code.
To have an easy life and be on the safe side, just revert my patch and compile with -fno-strict-aliasing option for now. I got some notifications on the Mesa issue which I filed back then, so an upstream fix will float around eventually.
I recently revived the node script from glslunit to bake GLSL to source files and added optimization based on this tool (work in progress in the glslprep.js repository). This way, it's a single & easy to invoke build step without native code to be packaged. It takes a template for the wrapper source code, so should adapt to pretty much anything.

@tschw How can I do that ?

@SuicSoft
https://github.com/tschw/glslprep.js/blob/gh-pages/src/glslunit/compiler/preprocessor.js#L238-L265


Cannot make instance from Class

Exception has occurred: TypeError
__init__() takes 1 positional argument but 3 were given
line 8, in main
    client = GfycatClient(my_id, my_secret)

Code:
from gfycat.client import GfycatClient

def main():
    my_id = 'some_id'
    my_secret = 'some_secret'
    client = GfycatClient(my_id, my_secret)

main()

The pip version of this project seems to be out of date, I had the same issue. If you download the source directly from GitHub and include it in your project that way, it works as expected.

I think you could probably also install it using pip like this:
pip install gfycat==0.1.4

I have updated the pip package which should fix this! You can run
pip install --upgrade gfycat to update the package


Muesliswap transaction

Hey guys I need a little help here.I just sell 1LQ token on muesliswap .The order was filled I went thru the transactions...Nami wallet showing that I have received 42 ADA , ive checked the adres balance on scanner it's showing correct amount ....But still I can't see my ADA in the wallet .I can't send it can't use it (everything seems to be fine when u checking the adress , the ADA it's not showing in the wallet)...Please help me I'm using this wallet for a first time....Here u got the address if u wanna check it :
addr1q8v2xts4e3g3j7qzgalm4eapc76hpkgy0adtv7p4gwdr3y0dnfdyust0rm40gttq4tqqeggjqqnleeyk55kpz0u93jyqkqx545

Works fine, have to disconnect wallet from the site ...

Works fine, have to disconnect wallet from the site ...


docs: added eventing and volume resize features to the replicated storage user guide - advanced operations

@avishnu please review the content added and share your feedback with the suggested changes, if any. If no further changes are required, please approve/merge the PR. Thanks!


PPX not found when building in an alpine docker container

When using this lib in a docker container built from alpine you'll get errors saying things like
Command line: /app/node_modules/@baransu/graphql_ppx_re/ppx '/tmp/camlppx375570' '/tmp/camlppx57df4b'
and
FAILED: packages/worker/src/Foo.reast
/app/node_modules/bs-platform/lib/bsc.exe  -w -30-40+6+7+27+32..39+44+45+101+A-9-40-42-48-102 -warn-error +A-3-44 -color always -bs-jsx 3 -ppx /app/node_modules/@baransu/graphql_ppx_re/ppx  -o packages/worker/src/Foo.reast -bs-syntax-only -bs-binary-ast /app/packages/worker/src/Foo.re
sh: /app/node_modules/@baransu/graphql_ppx_re/ppx: not found

Switching to a container that's not built on Alpine fixes the issue.

Does the post install script copied ppx binary in place? Is the file available and in correct place?

@baransu it is and even when I go into the docker container and run it manually I get that same error.

So the outputted ppx file is there, but not executable (it does have executable permissions) because of the lack of glibc.
We were able to fix this for our project for now, by installing glibc into our alpine image by adding the following to our dockerfile (I still have to check and see if there are newer glibc versions to use instead).
RUN wget -q -O /etc/apk/keys/sgerrand.rsa.pub https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub
RUN wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.28-r0/glibc-2.28-r0.apk
RUN apk add --no-cache glibc-2.28-r0.apk

The reason it worked with the original mhallin ppx was because that was built in alpine already using opam (It didn't have any dynamic deps specific to alpine either so it worked in "vanilla" linux as well). When building via esy (at least esy installed via npm), glibc is required at build time at least. I did not check if it was required at run time when built that way, or if a version of esy built in alpine without glibc (if such a thing is reasonably feasible) would work outside of alpine.
The following is only really relevant if building it with glibc in docker works both in "vanilla" linux and in alpine-without-glibc, but I'm including it in case it is, because then the build/deploy pipelines can be updated to provide a linux version that works everywhere without the additional step of installing glibc (which adds a noticeable % increase to the docker image size).
The esy devs seem to recommend using esy-docker (https://github.com/andreypopp/esy-docker) as a baseline for building things via esy in docker. Note that the project is behind a bit (e.g. node 10 and esy 0.4.3), and is also somewhat complicated (it uses some makefile and config to add several discrete dockerfiles that expect a certain project structure and more. I took the output from there and tweaked it to use more current versions of (almost) everything, and added a script to go with it to output alpine compatible builds (that again may or may not require glibc at which point there is no benefit if they do)  and output them locally
Dockerfile
# Inspired by https://github.com/andreypopp/esy-docker

FROM node:12.13-alpine as build

ENV TERM=dumb LD_LIBRARY_PATH=/usr/local/lib:/usr/lib:/lib

RUN mkdir /esy
WORKDIR /esy

ENV NPM_CONFIG_PREFIX=/esy
RUN npm install -g --unsafe-perm esy@latest

# now that we have esy installed we need a proper runtime

FROM alpine:3.8 as esy

ENV TERM=dumb LD_LIBRARY_PATH=/usr/local/lib:/usr/lib:/lib

WORKDIR /

COPY --from=build /esy /esy

RUN apk add --no-cache ca-certificates wget bash curl perl-utils git patch gcc g++ musl-dev make m4

RUN wget -q -O /etc/apk/keys/sgerrand.rsa.pub https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub
RUN wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.28-r0/glibc-2.28-r0.apk
RUN apk add --no-cache glibc-2.28-r0.apk

ENV PATH=/esy/bin:$PATH

# gql stuff

RUN git clone https://github.com/baransu/graphql_ppx_re /app

WORKDIR /app
RUN mkdir -p /builds

RUN esy install
RUN esy build

build.sh
mkdir -p output
docker build -t gql-ppx-alpine-builder .
docker run --mount type=bind,src=$(pwd)/output,dst=/builds gql-ppx-alpine-builder cp _build/default/src/bucklescript_bin/bin.exe /builds/bin.exe

Well poop, Building it that way does not work in alpine without glibc, so that is precisely 0% helpful :/

Ok well I get some other oddball error using it via that process, probably because I'm only copying in that binary and not anything else
Fatal error: exception Failure("Ast_mapper: OCaml version mismatch or malformed input")

@johnhaley81 @maxkorp I just released v0.4.9. It’s build using alpine image and should work on alpine and other common distributions. I tested it using ldd. Please let me know if it resolves your problem 🙂

Awesome work! Just curious. Must we always ship compiled PPXs for each architecture? Seems like quite a hassle to maintain for each PPX. Is there no better way like shipping bytecode (or compiling as a postinstall step or so).

I'm not sure about bytecode runtime, but with post-install compile you would need while esy env with ocaml and whatnot. A few minutes and few GB required to test ReasonML with GraphQL.
We probably need only 3 binaries, each one for one major OS (generic Linux - solved by compiling on alpine with static linking, macOS and Windows).

Closing the issue as it's resolved since version 0.4.9. Please create a new issue ore reopen if it's still a problem.


GKE v2 Provisioner: add Register Cluster option

For the GKE v2 Provisioner, we need to add a function to register a cluster. This should match what we do in EKS currently (let us know if you need details on that).

This will need the UI to be done to fully test. In the UI, you should be able to select a cloud credential, and then be able to select from a list of clusters that already exist in GKE. Should test that it gets registered successfully, that you have kubectl access to it, that properties like the kubernetes version are visible from the rancher UI, and that changes made from Rancher or from the GKE console don't overwrite each other.

This was tested via test plan


Can you only run online browser on google shell?

No, any machine that has Docker can run it on it. For example, you can buy a VPS server and run it on it.


Links to sections with section number does not work

I'm using sphinxcontrib-confluencebuilder==1.2.0 from pip.
Confluence builder does not properly publish links to sections of the document when they use section numbers.
It works properly for documents without section numbers.
For example, we have a similar RST document:
Some installation manual
----------------------------

This is some installation manual.

Follow these steps to install the software:

#. `Install AAA`_
#. `Configure BBB`_
#. `Install CCC`_

Install AAA
~~~~~~~~~~

aaaaaaaaaaaaaaaaaaaaaa

Configure BBB
~~~~~~~~~~~~~

bbbbbbbbbbbbbbbbbbbbbbbb

Install CCC
~~~~~~~~~~~~

cccccccccccccccccccccc

When this is built it looks like that:
9. Some installation manual

This is some installation manual.

Follow these steps to install the software:

1. Install AAA (hypertext)
2. Configure BBB (hypertext)
3. Install CCC (hypertext)

9.1. Install AAA

aaaaaaaaaaaaaaaaaaaaaa

9.2. Configure BBB

bbbbbbbbbbbbbbbbbbbbbbbb

9.3. Install CCC

cccccccccccccccccccccc

Hypertext links to these subsections look this way:
http://some.wiki.address/display/namespace/9.+Some+installation+manual#id-9.Someinstallationmanual-InstallAAA,
but it doesn't work for confluence, because it expects this link
http://some.wiki.address/display/namespace/9.+Some+installation+manual#id-9.Someinstallationmanual-9.1.InstallAAA.
When I turn off section numbers (confluence_add_secnumbers = False), links are generated in the same way, but they work.
Your plugin is missing section number support for links.

The changes outlined in #365 are now available on the main branch and will be available next stable release (v1.3+). Will mark as pending-next-release and will close up when the release has been completed (see #362 for more details).

v1.3 is now available on PyPI -- marking as closed.

v1.3 is now available on PyPI -- marking as closed.


Articles needs to be update and Clarity

[Enter feedback here]
The article doesn't contain information about the Android based devices where only 'CAP' licenses are assigned. under the Configure Intune to enroll Teams Android-based devices section. Clarity needs to be added that Step 1 and step 2 needs to be followed also for the devices where only 'CAP' licenses are assigned.
We had multiple tenants impacted due to this.
https://portal.microsofticm.com/imp/v3/incidents/details/245590300/home
Incident-241818509 Details - IcM (microsofticm.com)
These are engineering escalations which were raised to confirm. This Github request is raised after agreement with TEAMS Devices PM - Kruthika
please reach out if needs more clarification

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 407c4f68-9737-d86c-2a08-cbbeaef6da00
Version Independent ID: 3324088c-b0b2-dec3-575d-c1fb76bfb730
Content: Deploy Teams phones and Teams displays using Intune - Microsoft Teams
Content Source: Teams/devices/phones-displays-deploy.md
Service: msteams
GitHub Login: @cichur
Microsoft Alias: v-cichur

Probably not a good idea to share internal URLs and aliases in a public forum.

Edited it. @ndambrosio

@SanguptaMSFT Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

We updated the article with the additional information. The changes are now live https://docs.microsoft.com/en-us/microsoftteams/devices/phones-displays-deploy#configure-intune-to-enroll-teams-android-based-devices


Ccp 274 write review portal

Pull Request Test Coverage Report for Build 1125

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 42.632%

Totals

Change from base Build 1120:
0.008%

Covered Lines:
1787

Relevant Lines:
4030

💛  - Coveralls


Debug() vs DebugFormat() vs DebugException()

For every logging level (e.g. Debug) there are methods with following signatures:
Debug(message)
Debug(func)
Debug(message, formatArgs)
Debug(exception, message, formatArgs..)
DebugException(message, exception)
DebugException(message, exception, formatArgs)
DebugFormat(message, formatArgs)
DebugException and DebugFormat seems to be redundant since the same can be achieved using Debug(..) method calls.
Do we really need them?

these are duplicates:

Debug(message, formatArgs) and DebugFormat(message, formatArgs)
Debug(exception, message, formatArgs..) and DebugException(message, exception, formatArgs)

They appear to be duplicates. However removing them will be a breaking change and a new major version. As I'm deprecating this library (see #270) so I won't be making fixes here.


Fix filepath wildcard for avro/parquet

Below changes have been tested and confirmed to work. Also proposing alternative approach since I'm not a big fan of guessing whether we are dealing with Avro vs Parquet:
Approach (1)

This PR, minimal change. Basically checking to see if the matching files has the relevant extensions and routing it to either AvroSampler or ParquetSample

Approach (2)

Not in this PR, but I think we should create a new arg called mode (which can be either parquet, avro or bigquery) and have that be a required field. It will be a breaking change, but then it will help avoid guessing which Sampler to use.

I'm a fan of adding an optional parameter called --input-mode, similar to how we do it in BigDiffy https://github.com/spotify/ratatool/tree/master/ratatool-diffy#usage, just to keep the names consistent. In general, I'm not a fan of "guessing" what the input type is, but I also don't want to break existing users' workflows, so adding an optional parameter that we use, and inferring the input type if that parameter isn't there would work for me!

I'm a fan of adding an optional parameter called --input-mode, similar to how we do it in BigDiffy https://github.com/spotify/ratatool/tree/master/ratatool-diffy#usage, just to keep the names consistent. In general, I'm not a fan of "guessing" what the input type is, but I also don't want to break existing users' workflows, so adding an optional parameter that we use, and inferring the input type if that parameter isn't there would work for me!

@benkonz, I like the approach. I will create a ticket to add --input-mode. I agree that we shouldn't break existing users' workflows.


When this library is going to be released to pub.dev?

When this library is going to be released to pub.dev?

Same question curious if we can use via pub.dev

We will be releasing this to pub.dev and public beta later this month!

The library now publicly available in Pub.dev as segment_analytics!


Command 'AL: Download packages' resulted in an error

A system error occurred (ENOENT: no such file or directory, open '/Users/pankaj/.vscode/extensions/sergiogp1.al-packages-0.0.1/resources\onprem_versions.txt')
Above error is observed on Mac OS, the path mention at the end has backslash "\onprem_versions.txt" this is not recognised on Mac OS or Linux
After initial observation the file path opens the required file /Users/pankaj/.vscode/extensions/sergiogp1.al-packages-0.0.1/resources\onprem_versions.txt
Look forward for the support on the matter

work around for Mac or Linux -
cp ~/.vscode/extensions/sergiogp1.al-packages-0.0.1/resources/onprem_versions.txt ~/.vscode/extensions/sergiogp1.al-packages-0.0.1/resources\onprem_versions.txt
cp ~/.vscode/extensions/sergiogp1.al-packages-0.0.1/resources/sandbox_versions.txt ~/.vscode/extensions/sergiogp1.al-packages-0.0.1/resources\sandbox_versions.txt
This would create the file as per the package and would proceed ahead


Webpack 5 migration codemods

Errors provided by webpack v5 is very useful, but would be much better to process webpack.config.js using codemods, for this purpose I started working on plugin @putout/plugin-webpack for code transformer putout.
Right now it handles two kinds of errors:

Exclamation mark separated loader lists has been removed in favor of the 'use' property with arrays
Query arguments on 'loader' has been removed in favor of the 'options' property

Any ideas or improvements highly appreciated, and I want to ask core webpack team, what do you think about such way of doing migration? I find it very useful for my projects, because fix all things by hand again and again is pretty frustrating.

Ideally we should move to 0CJS for most of projects/cases instead of creating complex and confusing migration tools, but we have webpack migrate in webpack-cli, if you want to help with this, feel free to feedback


CSGMesh fails to render after creation

Godot version
v3.3.2-stable_mono_x11.64
System information
Linux Mint 20.1, GLES3, Nvidia RTX3070 (Driver version 460.84)
Issue description
If you add a CSGMesh as a child of any Spatial node and add any of most mesh types to it the mesh is not rendered. Instead the following error is printed to the output tab:
 drivers/gles3/rasterizer_storage_gles3.cpp:4084 - Index p_surface = 0 is out of bounds (mesh->surfaces.size() = 0).
 servers/visual_server.cpp:1595 - Condition "vertex_data.size() == 0" is true. Returned: Array()
 modules/csg/csg_shape.cpp:738 - Condition "arrays.size() == 0" is true. Returned: _post_initialize(new ("") CSGBrush)

If you move the CSGMesh under some other node, it starts rendering correctly. It can even be moved back to the original place after that and it continues to work. Reloading the project also seems to cause the CSGMesh to render correctly. The problem only happens after a mesh is added to a previously unused CSGMesh.
Some mesh types, like capsule and sphere, do not cause the bug for some reason. Others, including cube, cylinder, plane, prism or quad do.
Steps to reproduce

Create an empty project
Create a new 3D scheme (Spatial as root node)
Create a new CSGMesh as a child of the Spatial
Add a cube, cylinder, plane, prism or quad mesh to the CSGMesh node
The mesh won't render and instead the error listed above is printed to the output tab

Minimal reproduction project
This won't hopefully be necessary as the bug requires adding only 1 node to an empty project. The bug also fixes itself if loading from a project so the CSGMesh node would need re-creating anyway.

cc @madmiraal

Duplicate of #46610.


An option to display instruction addresses

Describe the feature
Add an option to show instruction address (PC) of the topmost method in a stack trace.
Use Case
Currently, async-profiler displays information on the method/function level. Sometimes, for low-level performance analysis, it is important to know where exactly CPU time is spent inside a method.
Proposed Solution
As an intermediate step to the instruction-level profiling, we will add an option to record PC address of the currently running method for each execution sample. In this case, each stack trace will include a synthetic frame with the address at the top of every stack trace.
The option is -F pcaddr (or features=pcaddr when running as an agent).
Example:
asprof -e cpu -f profile.html --cstack dwarf -F pcaddr PID

Acknowledgements

[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Implemented in pcaddr branch.

Together with --lines it would be very interesting to try it!

And decoding the assembly address with the actual instruction performed in some format (at&t, intel, ...). Due to skidding it won't be that relevant, but using PEBS/IBS it could be still be useful (thinking about simd instr or some unexpected call...)

Yes, disassembling code around these addresses will be the next step. Not in the nearest release, though.

Thanks @apangin 🙏 it has passed a long time since we talked about this, and you didn't forgotten


Re-arrange dev deps back, try force --production=false

Unfortunately yarn also ignores dev deps if NODE_ENV set to production
So, for release prod we had to revert your changes in package.json:
https://github.com/GoodDollar/GoodDAPP/commit/f3e798778f4bf6c1dec6c01de4386df771cdf552
https://github.com/GoodDollar/GoodDAPP/commit/dfdd08ef65fbf7af6f014bf8cdd5a952509b0dcd
But yarn have a flag could override the NODE_ENV setting during packages install:
https://classic.yarnpkg.com/en/docs/cli/install/#toc-yarn-install-production-true-false
Need to try to use it

[ ] restore package.json changes (reverts 2 commits from above)
[ ] try to install packages locally with NODE_ENV=production and --production=false flag then build app
[ ] if this is working, set yarn install --production=false as netlify's build command (in settings or better in the toml file for prod env only)
[ ] try deploy prod with that settings

seems  to be working with --production=false


Stopping service

Your Environment

Plugin version: 0.25
Platform: Both
OS version: 11.2.1
Device manufacturer and model: iPad Air 2
React Native version:
Plugin configuration options:
Link to your project:

Context

Cannot simply stop the service, would need to stop and reconfigure the service to not send to the server. This seems counter intuitive.
Expected Behavior

User can disable service
Actual Behavior

Can only configure the service
Possible Fix

FYI This is all possible in 0.5x version.


Improve the kind dev guide

Problem Statement
I tried to run the controller on kind, and find documentation about it, but the commands seem to be off slightly, so I fixed it 🙂
Related Issue
N/A
Proposed Changes
Update the documentation as needed.
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[x] My changes have reasonable test coverage
[x] All tests pass with make test
[x] I ensured my PR is ready for review with make reviewable

Ah, it seems I don't have much to add to the latest doc! Thanks, I'm closing the PR 🙂


How to configure Amazon prometheus (AMP) as a data source?

AMP as a data source to External Grafana is not working fine. SIgV4 auth is also not supported by Grafana Operator. We would support for AMP as a data source via Grafana Operafor to External Grafana and it does not work. Below is the Yaml snippet im using :
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaDatasource
metadata:
  name: grafanadatasource-sample-amp
spec:
  instanceSelector:
    matchLabels:
      dashboards: "external-grafana"
  datasource:
    name: amp-datasource
    type: prometheus
    access: server
    url: "https://<<my-url>>"
    isDefault: false
    jsonData:
      'tlsSkipVerify': false
      'timeInterval': "5s"
    editable: true

For those of us that don't talk AWS, is AMP=Amazon Managed Service for Prometheus?

@elamaran11 can you provide us with a bit more information.
What is needed and what is missing?
jsonData and secureJsonData is of type json.RawMessage which means that you can put any data you want in there.

So looking at https://github.com/grafana-operator/grafana-operator/issues/935 it seems like what you are missing is sigv4 auth.
So I haven't worked with the AWS sdk earlier, https://github.com/grafana/grafana-aws-sdk but my understanding is that it seems to be a base for plugins.
And in version 9 of grafana something changed around it (I don't have time to read more about it right now)
https://grafana.com/docs/grafana/latest/release-notes/release-notes-9-0-0-beta1/#breaking-changes
Since your grafana instance is deployed in AWS I assume all the needed plugins is installed.
So the only thing we need to understand is how should we set those values from an API point of view. Or is it even a change in the operator and not just configuration of the datasource and send in the correct jsonData?

@NissesSenap #935 is totally a different problem. We only support Prometheus as a Datasource for Datasource creation in Grafana Operator. Cloud providers have few other data sources and it would be great if Grafana Operator can support other Datasources so we can create complete integration.

So me and @elamaran11 spoke a bit on slack yesterday.
He sen't me this output
    {
        "id": 1,
        "uid": "wkoUbqG4k",
        "orgId": 1,
        "name": "Prometheus-V2",
        "type": "prometheus",
        "typeName": "Prometheus",
        "typeLogoUrl": "public/app/plugins/datasource/prometheus/img/prometheus_logo.svg",
        "access": "proxy",
        "url": "https://amazonaws.com/something/something",
        "password": "",
        "user": "",
        "database": "",
        "basicAuth": false,
        "isDefault": false,
        "jsonData": {
            "httpMethod": "POST",
            "sigV4Auth": true,
            "sigV4AuthType": "ec2_iam_role",
            "sigV4Region": "us-east-1"
        },
        "readOnly": false
    }

so just as I thought sig4v is located in json data.
So to get this to work I think you only need to set the following.
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaDatasource
metadata:
  name: grafanadatasource-sample-amp
spec:
  instanceSelector:
    matchLabels:
      dashboards: "external-grafana"
  datasource:
    name: amp-datasource
    type: prometheus
    access: server
    url: "https://<<my-url>>"
    isDefault: false
    jsonData:
      'tlsSkipVerify': false
      'timeInterval': "5s"
      "sigV4Auth": true,
      "sigV4AuthType": "ec2_iam_role",
      "sigV4Region": "us-east-1"
    editable: true

Please give it a try.

@NissesSenap Thanks for the pointers, SigV4 is working now with this additional json data. Thanks much


Disable processing transition logs

This is now handled by a Lambda in AWS which reads from Athena, exports to an S3 bucket which is then read by the Transition tool directly.
Depends on #8137.
Trello Card

My puppet knowledge isn't really good enough to know the answer to these, so I was wondering how / if the actual cron job will be deleted once $enable_cron is false - it looks like the code to create the cron is inside an if https://github.com/alphagov/govuk-puppet/pull/8136/files#diff-8def73b3037908d4605b2496346bb283R115 which won't get triggered so ensure => $ensure won't fire?
I've a similar question about the passive check https://github.com/alphagov/govuk-puppet/pull/8136/files#diff-8def73b3037908d4605b2496346bb283R125 i.e. will it be left hanging around without explicitly deleting it.
and last question - will we still need https://github.com/alphagov/govuk-puppet/pull/8136/files#diff-8def73b3037908d4605b2496346bb283R134, because its installation not variable controlled

Yup agreed, enabled needs to be left true for now but ensure set to absent, then the whole lot can be delete. With the Icinga check, you should also be able to add an ensure => absent to it. Same with mawk.

@bevanloon @rubenarakelyan Good point! I've updated the class to correctly remove resources when enabled or enable_cron is set to false.


Global user settings for initial status of extension

It would be nice, if there would be global User settings (Preferences > Settings), which define the initial status of the extension for every new window or file view. All three states should be possible: NORMAL, OFFSET, OFF.
Up to now it is permanently set to NORMAL for splitted views.

I second that. It starts scroll syncing automatically when viewing unrelated files. I have to turn it off when that happens. The times I need to sync scroll is less than the times I don't need to sync scroll. So the default (at least for me) can be off.

Since the last commit for this repo is dated back to April 2020, I’d like to show how I changed the extension to default-off.

After installation of the extension go to VSCode’s extension folder (on my Mac it resides here: ~/.vscode/extensions/) and edit this file ~/.vscode/extensions/dqisme.sync-scroll-1.3.0/out/states.js
(An overview where you can find the VSCode extensions on Mac, Windows, and Linux can be found here: https://code.visualstudio.com/docs/editor/extension-marketplace#_common-questions)
Go to this line:
https://github.com/dqisme/vscode-sync-scroll/blob/8568216d44385424e07913295c86f43a276a2613/src/states.ts#L50
Change protected defaultValue = ON_OFF.ON to protected defaultValue = ON_OFF.OFF, save, and restart VSCode, if it’s running.

This sets the extension to default-off. I hope, this helps ...

Exactly what I was looking for, @TobiasWantzen, much appreciated!

Just a minute ago, I just published a new release (v1.3.1) that now you can use the only one status bar item to change the  mode with three options: NORMAL, OFFSET and OFF.
And the default mode is OFF, so I hope it won't bother you when you open a new split panels workspace 😃
Please check it out, and thanks for your feedback 👍 @TobiasWantzen @kaedys @akinuri @QuentiumYT

@QuentiumYT Especially thanks for your feedback that retrigger me into this extension, I will look into your re-version and maybe try to merge some ideas into this one, and I would be more than welcomed inviting you to collaborate on it together if you wish. 😃

Thanks @dqisme for coming back to this extension! It was late yesterday and couldn't create a PR directly. Sadly it breaks my fork with the new global mode, but it looks interesting!
Thanks for your proposition, I'm not an expert with typescript but I can always do some PR if I see something useful to add :)


Unable to update, update error reported.

./scan4all -version
[INF] Current Version: 2.0.7
 ./scan4all -update
[FTL] Program exiting: no input list provided

I found that scan4ll is updated, and I reported an error when I tried to update
I using the Compilation installation method :see_no_evil:
git clone https://github.com/hktalent/scan4all.git
cd scan4all
go build

$ ./scan4all -update
2022/08/18 09:57:16 wait for init config files ...
2022/08/18 09:57:16 init config files is over .
2022/08/18 09:57:16 DbName  config/scan4all_db
2022/08/18 09:57:16 wait for all threads to end
[INF] Running CONNECT scan with non root privileges
2022/08/18 09:57:18 debug fetch "https://github.com/hktalent/scan4all/releases/download/2.7.5/scan4all_2.7.5_macOS_amd64.zip"
2022/08/18 09:57:20 debug response 200 OK – application/octet-stream (23718 KiB)
2022/08/18 09:57:20 debug copy to "/var/folders/_l/pnb2t_9s0f192bqlz1348vpr0000gn/T/update-148219058"
[================================================] 100%
2022/08/18 09:57:23 debug copied
2022/08/18 09:57:23 debug unpacking "/var/folders/_l/pnb2t_9s0f192bqlz1348vpr0000gn/T/update-148219058"
2022/08/18 09:57:24 debug copy "/var/folders/_l/pnb2t_9s0f192bqlz1348vpr0000gn/T/unpackit-3311748681/scan4all" to "/Users/51pwn/go/bin/scan4all.tmp"
2022/08/18 09:57:24 debug renaming "/Users/51pwn/go/bin/scan4all.tmp" to "/Users/51pwn/go/bin/scan4all"
[INF] Successfully updated to scan4all_2.7.5_macOS_amd64.zip
2022/08/18 09:57:24 start clear noRpt cahe


Native Animated Event issues

I've found some issues with the Native Animated Event

If I hold a touchable view in the scrollview, then stop scrolling, when I release the touch, the onPress of the touchable view is fired, that makes Native Animated Event almost unavailable in real use case.
'Native Animated Event' will made onScroll related events such as onEndReached unavailable in ListView, because the onScroll won't be called at all when turn on useNativeDriver, that breaks the common use case of ListView too.

I'm wondering is there any workaround for those issues, as I really need this Native Animated Event feature to improve the performance of my app. @janicduplessis

+1

I'm experiencing this on 0.36. Native animation works fine, but onEndReached is never called.
@nihgwu Did you manage to find a fix or a workaround?
@janicduplessis This is a big deal I think ..

@ramilushev This issue should be on both platforms and I don't know how to fix it, still waiting for @janicduplessis 😔

The problem is that we don't send the event to JS if it is handled natively. I suggest removing this and always send the event.
See https://github.com/facebook/react-native/blob/master/React/Base/RCTEventDispatcher.m#L149 and https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/EventDispatcher.java#L117
We should also change the EventListener interfaces so they don't return a bool anymore. Let me know if one of you would like to send a PR, if not I'll try to work on this soon.

This is solved in RN 0.40 by https://github.com/facebook/react-native/pull/10981 right?

@AlbertBrand thanks for reminding, closing it.

This is still an issue for me, I am using RN v0.43.2
I pass the renderScrollComponent prop to ListView and render an Animated.ScrollView as a scroll component which has an Animated.event() for onScroll
The onScroll event is still not propagated and events such as onEndReached are never called.
@nihgwu could you share an example of how you got it to work? Thanks.

I have the same problem, @nihgwu could you share an example?

const AnimatedListView = Animated.createAnimatedComponent(ListView)
no need to define renderScrollComponent