[Snyk] Security upgrade django from 3.2.15 to 3.2.21

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

requirements.txt

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

661/1000  Why? Recently disclosed, Has a fix available, CVSS 7.5
Denial of Service (DoS) SNYK-PYTHON-DJANGO-5880505
django:  3.2.15 -> 3.2.21
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

Codecov Report

Merging #357 (60d0daf) into develop (5490e7d) will increase coverage by 1.60%.
Report is 31 commits behind head on develop.
The diff coverage is 94.62%.

@@             Coverage Diff             @@
##           develop     #357      +/-   ##
===========================================
+ Coverage    93.33%   94.94%   +1.60%
===========================================
  Files          129      318     +189
  Lines         4829    10833    +6004
  Branches       444      719     +275
===========================================
+ Hits          4507    10285    +5778
- Misses         234      415     +181
- Partials        88      133      +45

Files Changed
Coverage Δ

apartment/api/serializers.py
100.00% <ø> (ø)

...tions/0008_add_uuid_to_apartment_project_models.py
100.00% <ø> (ø)

apartment_application_service/wsgi.py
100.00% <ø> (ø)

application_form/api/sales/views.py
96.57% <ø> (ø)

application_form/api/serializers.py
100.00% <ø> (ø)

...tions/0021_application_date_of_birth_ssn_suffix.py
100.00% <ø> (ø)

...ations/0038_applicationapartment_apartment_uuid.py
70.00% <ø> (ø)

...orm/migrations/0040_lotteryevent_apartment_uuid.py
70.00% <ø> (ø)

...ations/0042_apartmentreservation_apartment_uuid.py
70.00% <ø> (ø)

...ct_terminated_to_reservation_agreement_canceled.py
100.00% <ø> (ø)

... and 128 more

... and 106 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Scandinavian characters

Hi!
I created a file with VS Code:

How this shows in browser ääÄÄ?

When I open this in browser it shows like this:
How this shows in browser Ã¤Ã¤Ã„Ã„?
If I reopen this file in notepad and save it then the characters are ok. Why?
In settings:
// The default character set encoding to use when reading and writing files.
"files.encoding": "utf8",
Br, Pauli
Br, Pauli

@PauliSu It is a good idea to keep your files as UTF8, as you've been doing so far. But browsers have no way of knowing the charset, therefore you should use an HTTP header to indicate content type or use <meta charset="UTF-8"> in the <head> section.

ok, thanks! I'll try that.


Refactoring Nonce Propagation in Struts Tags for CSP

Hello Struts devs!
This PR is a follow up to WW-5084: Add Content Security Policy support to Struts to make all Struts tags CSP ready. After our inital CSP implementation we realized that other Struts tags like <s:doubleselect>, <s:head> also include <script> or <link/> blocks, and we wanted to make sure enabling CSP will not compromise any of the functionality for the existing tags! Here's a summary of the changes we made:

Modify the UIBean class to add the nonce value as a parameter so tags that need the nonce value can access it
Add nonce.ftl and <include /> it for tags that need the nonce attribute
Modify the showcase JSP files to use <s:script> and <s:link/> instead of <script> and <link/>
Add support for FreeMarker tags<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
Co-authored-by: Ecenaz Jen Ozmen - @eozmen410
Co-authored-by: Giannis Chatziveroglou - @gchatz22
Co-authored-by: Santiago Diaz - @salcho

Looks good good, yet some tests are failing - it looks like out integration tests cannot pass because an app cannot be started.

Hi.  According to the Travis CI report, only the JDK 8 run failed (JDK 9 and 11 passed).  There does not seem to be any changes in the PR that would pose a problem for JDK 8, so it seems weird.
Maybe @eozmen410 could confirm that their branch completes a local build using JDK 8 as well ?  If a local JDK 8 build works (or fails), it might help narrow down a possible cause for the failure during the CI build.

Hi @JCgH4164838Gh792C124B5 , I've enabled integration tests only for JDK8's build (using STRUTS_IT=true variable in travis you can see) and it's the reason behind why it fails only. It really runs showcase app in an embedded jetty and tests the app via jwebunit real http requests/responses.

Coverage decreased (-0.002%) to 49.747% when pulling f70999c401703c478b486c352978b1e50bf9a820 on salcho:post-ww-5083 into 6210afa747a67cabcddd6d72f675ed3d8023bda5 on apache:master.

Hi @JCgH4164838Gh792C124B5 ,
I've pushed a small commit that removes all the <#rt> tags as you mentioned. I agree that it's cleaner this way, thanks for that and thanks @yasserzamani for fixing the JDK issue 👍


Client Side Error

getting error in client side setup
2020-05-09T18_38_20_895Z-debug.log

This is really old version, I see Angular CLI 6.
I’ll update this repo to latest Angular 9.1 next week. Stay tuned.

thank you.

sir any new update?

Hi rushikeshwalvekar, Sorry to keep you waiting, I tried to upgrade this repo, but couldn't make it work, there are too many issues. upgrading Angular 6 to 9 is easy, but GraphQL is not working properly yet. I will defer this repo until next Graph QL library update.
Once again, I'm sorry, I couldn't be of much help to you with this repository.
I will bring this GitHub repository offline.

Amit


Key Mapping seems off with your version of the Pico Code

I set up the keypad with the code that was provided on the Thingiverse listing and the keypad outputs the correct macros which I verified working when I have teams in focus or simply view what is sent when I open a text document. When I switch to the code you provided the key mapping seems to be off. I know there is a discrepancy in the documentation on the project where the diagram is not accurate so it seems you changed the key mapping for your version. Is it possible to have a version that doesn't change the keymappings in the original code?

Hey,
Sure... Yeah I'm not sure how the original key mapping would work. Maybe it's just me...
Anyway, here is the location of the files you requested:
https://github.com/jamesbrindle/Keypad4TeamsGlobalKeys/tree/master/PicoFiles/Code/ThingyverseMapping
The code.py contains the original mapping - starting at GP14 as opposed to GP10.
Regards,
J


build(deps): upgrade dependencies

This is an auto-created PR to upgrade our dependencies according to https://github.com/mashcard/mashcard/blob/master/.github/workflows/dependency_updater.yml.

@melchior-voidwolf Could you take a look at this lint error?
Error: @mashcard/uploader:lint:type: ../design-system/src/components/Form/FormField.tsx(27,32): error TS2339: Property 'message' does not exist on type '"" | FieldError | Merge<FieldError, FieldErrors<any>>'.

The type annotation of react-hook-form has been updated, causing some writes in the code to fail


thatonecalculator img info

fixes image sizing
adds my pfp

I was about to fix these today! Thanks!


Host and Device Allocator Fix

This PR removes an extra stream (called modStream) by moving code to the default stream (stream=0). I also specified the stream for a few memsets to avoid conflicts with other streams. This seems to have cleared up previous issues with the host and device allocators. I will upload validation plots soon.
New Timing

Current Master

Validation plots: https://www.classe.cornell.edu/~gsn27/www/PR183_valfull/#1.6
Comparison to master: Here

do you understand why this seems to be faster (particularly pT5s)?

do you understand why this seems to be faster (particularly pT5s)? This doesn't look like the typical variation in the timing. I haven't seen it that fast in a while.

It's because I moved over variables to the allocators that were previously causing errors. I don't understand exactly why the scaling improves though.


Perf: Asynchronous event handling server/agent

What changes were proposed in this pull request?
Whole set of changes implemented under AMBARI-20562.
Major server agent interaction rework.
How was this patch tested?
Basic deploy scenarios.
Unit tests were mostly fixed and merged.
Some were commented out as we need to merge quickly, number of conflicts start to grow exponentially.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/530/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/589/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/640/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/642/
Test FAILed.
Test FAILured.


No executable permissions on s2i scripts on Windows

I have the same problem as #620 but when I create an app with minishift on Windows system
/usr/bin/container-entrypoint: line 2: /usr/libexec/s2i/usage: Permission denied
/usr/bin/container-entrypoint: line 2: exec: /usr/libexec/s2i/usage: cannot execute: Permission denied

Is this a problem in s2i or in minishift?

Likely neither.  What s2i builder image are you trying to use?

And how did you "create an app"?  This looks like you're just trying to run one of the s2i builder images directly (they default to printing out their usage information) w/o having actually run an s2i build to add your app's source code and produce an application image.

The image I use is openshift/base-centos7
this is the Dockerfile

FROM openshift/base-centos7

ENV ESPORT_SCHEDULE 1.0

LABEL<EMAIL_ADDRESS>\
      io.k8s.description="Platform for building Spring.io project" \
      io.k8s.display-name="Esport-Schedule builder" \
      io.openshift.expose-services="8080:http"
#      io.openshift.tags="builder,x.y.z,etc."

RUN curl --silent --location https://rpm.nodesource.com/setup_8.x | bash - && \
    yum install -y java-1.8.0-openjdk maven nodejs && \
    yum clean all -y

# TODO (optional): Copy the builder files into /opt/app-root
# COPY ./<builder_folder>/ /opt/app-root/

COPY ./s2i/bin/ /usr/libexec/s2i

RUN chown -R 1001:1001 /opt/app-root

USER 1001

EXPOSE 8080

CMD ["/usr/libexec/s2i/usage"]

The steps I made are:
docker build -t esport-centos7 .

s2i build . esport-centos7 esport-app

oc new-app https://github.com/lunixgames/esport-schedule -l name=esapp

If I try
docker run -p 8080:8080 esport-app

it works as expected

s2i build . esport-centos7 esport-app

this does an s2i build using esport-centos as the s2i builder image.  not surprising it works.

oc new-app https://github.com/lunixgames/esport-schedule -l name=esapp

this is going to detect the Dockerfile in your repo and setup a Docker strategy build that effectively does a "docker build ." on your repository.  Since your Dockerfile ends with:
https://github.com/LunixGames/Esport-Schedule/blob/master/Dockerfile#L28
The image it produces is going to try to run that (And apparently it's not marked executable, nor is it what you really want).
What you need to do:

push your "esport-centos7" s2i build image to a registry (either the openshift internal one, or
dockerhub) so that openshift will be able to pull it down during the s2i build process.

Tell new-app to use that image as the s2i builder image and to use the s2i strategy to build your repository: oc new-app --strategy=source someregistry/namespace/esport-centos7~https://github.com/lunixgames/esport-schedule -l name=esapp

Ahh I see, thanks. Closing the issue.


React app miniature event

Description
The bases for the new event component has been made.
This component includes:

A banner
A "like" button for a future implementation of a favorite category for the user
The icon and the name of the group organizing the event
The title of the event
The date and time
The location of the event
A "join" button

The main layout has been established, however some features still need to be implemented:

A ... menu for more actions
A share button
Change the way the date is displayed

The main goal of this request is to share the event component so that the event page can start implementing it.
Screenshots

Great job on implementing event creation components on the Nantral Platform website, François! The added functionality for adding location and date information as well as the favorite button is sure to make the user experience more convenient and efficient. Keep up the excellent work!


Razor scaffolding 2

@seancpeters,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

This looks right to me, but figured it'd be best to have a second opinion.

Looks good to me. Will wait for the travis ci build before merging.


sqlite error

I got this error on raspbian (raspberry pi 4) which causes context data cannot be stored so welcome pages, notification always appear on launch. Any idea on this?
ERR [storage state.vscdb] open(): Unable to open DB due to Error: Cannot find module '../build/Release/sqlite'
Require stack:
- /usr/share/code-oss/resources/app/node_modules.asar/vscode-sqlite3/lib/sqlite3.js
- /usr/share/code-oss/resources/app/out/vs/loader.js
- /usr/share/code-oss/resources/app/out/bootstrap-window.js
- /usr/share/code-oss/resources/app/out/vs/code/electron-browser/workbench/workbench.html

The SQLite error messages don't only appear in the log today and not only on RPi 4. I saw this in December 2018 and is nothing new. I suspect that it exists longer. I haven't seen this before, because I have never looked in the log before.
Despite this error message, Code-OSS should run normally.

I just spent a good 2 hours on this problem

new rpi 4, installed code-oss from headmelted
open vscode, notice opt-out notification for telemetry
update settings to opt-out
every time i open vscode i see the opt out message
search for an hour for anything bug report about the notification always appearing - nothing
checked the logs found the sqlite3 exception
spent a couple of hours trying to build sqlite and update npm and node -- never fixed the module note found exception
decided to finally give up and report the bug to this repo..and found this bug

so.. yeah -- it would be nice if this gets fixed or anyone can find a work around
Thanks!

@payonel - I have build a version for myself. You can download it here https://github.com/tuanpham-dev/vscode-arm-builder/releases. I will create pull request for this soon.


Deploy application to Netlify

Describe the bug
I'll help you deploy the application to Netlify.
Deploy application to Netlify
npx next build
netlify
I'll wait for the deployment to complete and provide you with the live URL once it's ready.
An error occured while streaming this message.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-prydky
Steps to reproduce
Deploy application to Netlify
Expected behavior
Deploy application to Netlify
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 68697770,
  "usedJSHeapSize": 63525506,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = thomasbim
Chat ID = ae17a9bceb81

Additional context
Error:
An error occured while streaming this message.

Appreciate the feedback! We are aware of this message and are tracking it here: #1022.


[11.x] ISPN-12352 Set license information when missing

https://issues.redhat.com/browse/ISPN-12352

thanks @pruivo


Is it possible to use AWS Lambda runtime CPP with AWS SDK CPP on Ubuntu 20.04?

Confirm by changing [ ] to [x] below:

[ x] I've gone though Developer Guide and API reference
[ x] I've searched for previous similar issues and didn't find any solution

Platform/OS/Hardware/Device
Ubuntu 20.04
Describe the question
I've tried several times to use AWS Lambda runtime CPP with AWS SDK CPP on Ubuntu 20.04 and always had to back up to Ubuntu 18.04 because I encountered  major issues when running my lambdas. Compilation was ok, but then I had segmentation faults, memory corruption problems, etc. Everything works as expected on Ubuntu 18.04.
Is it possible to use AWS Lambda runtime CPP with AWS SDK CPP on Ubuntu 20.04?

I use the Docker image of Ubuntu 20.04. This image has GCC 9 and Cmake 3.16. My program is implemented with C++11.
If I launch one time my lambda (which uses AWS Lambda C++ runtime) it works fine. But if I launch it again, I get this error:
Error: Runtime exited with error: signal: broken pipe

Hi @NatxoM ,
Sorry for the late response, could you activate and provide the trace logs for the SDK ?
Also, I have a feeling this is mostly on the AWS Lambda C++ runtime and not the c++ SDK though, the logs should clarify that by giving a more complete story though.
Make sure to remove any mention of your credentials from the logs before posting them.

I have same issue:
Runtime exited with error: signal: broken pipe

Hello @technic ,
Thank you very much for reaching out.
This issue submission was closed due to missing information.
Could you please open a new issue with detailed information about your use case, reproduction steps as well as trace logs so we can further investigate the behavior you are experiencing?
You can do so here under reporting bug.
Thank you very much for your time and collaboration.
Sincerely,
Yasmine

It happens randomly, hard to reproduce.

@yasminetalby Oh, I didn't! Thanks for pointing this out :)

@technic of course! Let me know if you have any further questions
Best regards,
Yasmine


Implement Home Page Mockup

Please do work for this task in a branch named issue-6.

Done already


Use regex that does not catastrophically backtrack

The nested quantifier used in the encodeCodeBlocks regex can
catastrophically backtrack when it encounters unterminated ejs or hbs
tags. Fixes #260

published in 4.2.1


All queries and LoginAsync respond with Invalid Response - but REST and OSX SDK works fine.

Issue Description
I am able to authorize a user via REST and OSX just fine. But I am building VB.NET application (VS2015) to no avail.
I am greeted "Invalid response from server"
Steps to reproduce
Imports Parse
....
Private Async sub fromMain_Load(sender as Object, e As EventArgs) Handles Me.Load
Dim myConfig as ParseClient.Configuration
myConfig.ApplicationId = "myid"
myConfig.WindowsKey = "mydotnetkey"
myConfig.Server = "https://myserver/myapp"
ParseClient.Initialize(myConfig)
Try
Await ParseUser.LogInAsync("Dave","dave")
Catch ex As Exception
MsgBox(ex.Message)
End Try
End Sub
If I add a "/" to the end of the server address I get an "unauthorized" message back.
Also tried via C#
        Parse.ParseClient.Initialize(new ParseClient.Configuration
        {
            ApplicationId = "myappid",
            Server = "https://myserver.com/invmanager",
            WindowsKey = "my .net key"
        });
        try
        {
            ParseQuery<ParseObject> query = ParseObject.GetQuery("Clinics");
            ParseObject MyClinic = await query.GetAsync("WFITGOpHUj");
        }
        catch (Exception etest)
        {
            Console.WriteLine("Error {0}", etest.Message);
        }

Expected Results
CurrentUser to be set (or data queried)
Actual Outcome
ex.Message = "Invalid response from server" after the LogInAsync is called (or any query)
Environment Setup
Server
parse-server version (Be specific! Don't say 'latest'.) : 2.3.7
.net SDK installed via nuget 1.7
Operating System: Win10, VS2015, VB,
Hardware: Asus desktop
Localhost or remote server? Server running on Ubuntu 14.04
Database
MongoDB version: 3.0.14
Storage engine: Mongo locally installed
Hardware: ASUSTeK rack server X86_64, P9D-M Series
Localhost or remote server? (AWS, mLab, ObjectRocket, Digital Ocean, etc): Local
Logs/Trace
Include all relevant logs. You can turn on additional logging by configuring VERBOSE=1 in your environment.
Cleaned out logs, ran .NET program again. no logs
Also - tried just querying data - same thing - invalid response.
Again - it works fine via REST and OSX (using same ApplicationID and server - albeit different client keys of course).

Huh.
Started working.
Did need to do a slightly different way of authenticating the server.... (thanks to ... you know who you are)...
string server = "https://myserver.com/myapp/"
Parse.ParseClient.Initialize(new ParseClient.Configuration
{
ApplicationId = "my app",
WindowsKey = "mydotnetkey".
Server = string.IsNullOrEmpter(server
}


Now it's "no-move" who don't work!

@ts-thomas I tested now, but now it's "no-move" who don't work! i tried in some differents way to use!

fixed in v0.2.8


⚠ SceneTime has degraded performance

In 37d9591, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1800 ms

Resolved: SceneTime performance has improved in e7ed743 after 6 minutes.


"App updated" notification mechanism seems broken

Describe the bug
In our app we use:
https://kit.svelte.d:ev/docs/modules#$app-stores-updated
and the following config:
version: {
      name: Date.now().toString(),
      pollInterval: 60 * 1000
    }

It worked quite well.
Recently we made an deps bump (sveltekit 1.0.11 => 1.3.9), and the bug started to show on our environments.
The bug:
the polling to APP_URL/_app/version.json works and the updated store keep being true. Our notification component telling the user to reload the app show itself at each poll.
Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-s85ex1?file=src/routes/+page.svelte
(Bug shows in npm run build && npm run preview mode or when deployed).
Locally, I reproduced it on a brand new sveltekit project created with npm create svelte@latest
Logs
No response
System Info
(not relevant IMHO, as we have also the bug in our cloud envs, which have a different OS/config)

  System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1
    Memory: 52.05 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.1 - ~/.nvm/versions/node/v18.12.1/bin/node
    npm: 8.19.2 - ~/.nvm/versions/node/v18.12.1/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 109.0.5414.119
    Firefox: 109.0.1
    Firefox Developer Edition: 102.0
    Safari: 16.2
  npmPackages:
    @sveltejs/adapter-auto: ^2.0.0 => 2.0.0
    @sveltejs/kit: ^1.5.0 => 1.5.0
    svelte: ^3.54.0 => 3.55.1
    vite: ^4.0.0 => 4.1.1

Severity
blocking an upgrade
Additional Information
When I search in built/generates files, I find the timestamp returned by the url polled (APP_URL/_app/version.json) in output/client/_app/version.json

I'm tending towards saying that, if you specify a version.name config, you're responsible for making sure it's consistent across multiple evaluations - whether it's coming from an environment variable, or you're looking up a git commit hash, or whatever. I don't really know what would be involved in making sure, within the framework, that we only ever evaluate the configuration once.
If that's the direction we go, that would make this a documentation issue.

Thanks, beloved maintainers !

If that's the direction we go, that would make this a documentation issue.

Yes, I was wondering if we weren't a bit mislead by documentation. It states that default value is Date.now().toString(), so we thought we could give this config entry this value, without realizing the behavior underneath.
On our side, I think we're currently fine with deleting the version.name entry (anyway, IMHO a commit sha-1 would be cleaner for us, as we don't do environment specific builds).

@Conduitry made a small doc update attempt

closed via #8956


fix(lib): add support for requiring library in non-browser environments

This PR along with bevacqua/crossvent#9 should be fine. Still need to wait until the other PR is merged to bump crossvent version in package.json

@bevacqua Any thoughts on getting this merged, would really help with univeral/ssr projects.

@bevacqua Is there a plan to get traction on this and bevacqua/crossvent#9? I've got an isomorphic Angular app eagerly awaiting these fixes.

why not merge this???!!!

@bevacqua merging this will really help me and my project. Do you know if this will happen soon? thanks :)


Update RUM Event Schema

What does this PR do?
Update the event schema to only post session.is_active on View events.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1383 (82f1dc4) into develop (ca81ad7) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1383      +/-   ##
===========================================
- Coverage    81.93%   81.90%   -0.03%
===========================================
  Files          363      363
  Lines        13015    13015
  Branches      2188     2188
===========================================
- Hits         10663    10659       -4
- Misses        1685     1686       +1
- Partials       667      670       +3

see 9 files with indirect coverage changes


[idea] Valtio like updates with Jotai?

I'm not sure if this is the right place, but from the repo name only I wanted to do something like this.
const proxyAtom = withProxyEffect(atom(0), { sync: true, proxy });
  ...
const $state = useAtomValue(proxyAtom);
  ...
onClick={() => $state.value++}

const proxyAtom = atomWithProxyEffect(0, null, { sync: true, proxy });
...
const $state = useAtomValue(proxyAtom);
...
onClick={() => $state.value++}

Was this API considered, or is this repo specifically intended for syncing a jotai atom with a valtio proxy?
Example: https://codesandbox.io/s/jotai-demo-forked-skvmhs
What do you think? Would something like this fit in jotai-valtio?

I haven't considered such an API. Maybe because I'd simply do proxy.value++.

is this repo specifically intended for syncing a jotai atom with a valtio proxy?

That was my motivation, but it's not limited if someone else has an idea and can take the lead.
On the other hand, if we were able to create jotai-effect, this wouldn't be very useful because we can do it with jotai-effect, I guess.

Welcome back Dai-Shi 😌.
Since state lives in the store in Jotai, this makes it unavailable to convert to a Valtio proxy.
The current api for jotai-valtio allows for Valtio -> Jotai but not Jotai -> Valtio. This is my motivation for introducing a new api. I think only withProxyEffect would be necessary to achieve  Jotai -> Valtio.

Can't atomEffect https://github.com/pmndrs/jotai/discussions/2136 do Jotai -> Valtio?

The main issue I've been having with using atomEffect this way is in supporting the initial read of the withProxyEffect atom. Because, atomEffects are designed to run async (post read). But I'll keep trying to get this to work.
Here's a simple prototype of withProxyEffect. The main drawback is that the initial read returns undefined. I have a more complex example that fixes this, but it is suffering from another strange bug.
const defaultOptions: Required<ValtioOptions<any>> = {
  sync: true,
  proxyFn: proxy,
};

type ProxyStore<Value> = {
  proxyState: ProxyState<Value>;
  unsubscribe: () => void;
};

export function withProxyEffect<Value>(
  atomToSync: WritableAtom<Value, [SetStateAction<Value>], any>,
  options: ValtioOptions<Value> = defaultOptions
) {
  const proxyAtom = makeProxyAtom(atomToSync, options);
  return makeWithProxyEffect(proxyAtom, atomToSync);
}

export function makeWithProxyEffect<Value>(
  proxyAtom: WritableAtom<ProxyStore<Value> | null, [boolean | ProxyStore<Value> | null], void>,
  atomToSync: WritableAtom<Value, [SetStateAction<Value>], any>
) {
  const derivedAtom = atom((get) => {
    const proxyStore = get(proxyAtom);
    const state = get(atomToSync);
    if (proxyStore === null) return;
    const { proxyState } = proxyStore;
    if (state !== snapshot(proxyState).value) {
      proxyState.value = state as Value;
    }
    return createProxyWrapper(proxyState);
  });
  return derivedAtom;
}

export function makeProxyAtom<Value>(
  atomToSync: WritableAtom<Value, [SetStateAction<Value>], any>,
  options: ValtioOptions<Value> = defaultOptions
) {
  const { sync, proxyFn } = { ...defaultOptions, ...options };

  const proxyAtom = atom<null | ProxyStore<Value>, [boolean | null | ProxyStore<Value>], void>(
    null,
    (get, set, isInit) => {
      if (isInit) {
        const value = get(atomToSync);
        const proxyState = proxyFn({ value }) as ProxyState<Value>;
        const unsubscribe = subscribe(
          proxyState,
          () => {
            const { value } = snapshot(proxyState);
            if (value !== get(atomToSync)) {
              set(atomToSync, value as Value);
            }
          },
          sync
        );
        set(proxyAtom, { proxyState, unsubscribe });
      } else {
        get(proxyAtom)?.unsubscribe?.();
      }
    }
  );
  proxyAtom.onMount = (init) => {
    init(true);
    return () => init(false);
  };
  return proxyAtom;
}

function createProxyWrapper<T>(state: ProxyState<T>): ProxyState<T> {
  return new Proxy(state, {
    get(target, property: string) {
      return target[property as keyof ProxyState<T>] as T;
    },
    set(target, property: string, value: any) {
      if (property === 'value') {
        target[property] = value;
        return true;
      }
      return false;
    },
  });
}

Hmm, I wonder if Jotai -> Valtio makes sense for multiple provider use case.
ex: https://twitter.com/dai_shi/status/1447892237753278466

Hmm, I wonder if Jotai -> Valtio makes sense for multiple provider use case. ex: https://twitter.com/dai_shi/status/1447892237753278466

The proxy is treated as Jotai state so it cannot be accessed outside of the react component tree.
Does this feel natural?
ex: https://codesandbox.io/s/pensive-wood-lspvpd
Perhaps its better to think of this utility as "updating jotai atoms like how Valtio does it", rather than "converting Jotai into Valtio".

Perhaps its better to think of this utility as "updating Jotai atoms like how Valtio does it", rather than "converting Jotai into Valtio".

Yeah, that makes sense.

Would something like this fit in jotai-valtio?

It's different from the original motivation, but it's another style of integration, so it should fit.
I wouldn't mind adding it here if you keep maintaining it, but my suspicion is whether if people would use it and if I'd actually recommend it, because if you design Jotai atoms "atomic", deep proxy updating shouldn't be necessary.

I'll submit a PR and we can continue the discussion there. Closing this ticket for now.

https://github.com/jotaijs/jotai-valtio/pull/5


vendor: Update k8s dependencies to latest

@giuseppe @runcom PTAL
Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

@giuseppe Once userns lands then the delta to it should be smaller if we can get this in first.

/test all

/test e2e

all tests are happy \o/

LGTM

LGTM


Installing on Windows

\requirements\app.in
line 23 and line 24
should be changed to
rq-win; os_name=='win'
redis; os_name=='win'
when installing on Windows.
Maybe make mention of this in Developing.md?

Thanks, Siem. We are not developing on Windows since a while, but it worked for us back then. Can you confirm this change works for you and? Which Windows version are you using?

Yes, with these changes it works on my Win10 machine. I know I'm only 1/2 developer if you work on a Windows system....

Nah, Windows is coming along the last few years!
I really hope we can find the time to provide better docs and a tutorial to get started soon. One of our most important jobs in the next few months.

Thanks for reporting. It seems that os_name=="nt" was only still in use for Windows 7 (and earlier, probably). I'll update to cover both cases.


fix(server): correctly handle errors on listen

The Promise constructor doesn't automatically catch errors if its handler
function is async. Use try/catch to avoid unhandled rejections.
If the server is closed because the port is already in used, use a
non-zero exit code and log it as an error.

Is it mainly to handle the exceptions raised by the readyHooks?

@thetutlage yes

but the same reasoning can be used for the other lines, in case they result in a thrown error (for example if server.listen() gets wrong values as its port or host arguments)

Thanks 👍


Release plugin as a Gem

Releasing this plugin as a Gem would mean users could receive updates as and when they are made (i.e. if they are using bundler, you can run bundle update. You can find out more about creating Gems here: http://guides.rubygems.org/make-your-own-gem/
For users who wish to install locally, this is still possible (and you can provide instructions on how to do so), but basically it would mean copying the file from {repo}/lib/ to {your install}/_plugins/.
The Jekyll organisation on GitHub has a number of it’s own plugins released this way, and is a good place to see what’s considered best practice.

Give it a go: gem install jekyll-crosspost-to-medium

Nice! Works like a charm gem :+1:


Rewrite part of Commands rustdoc

Explain it is flushed in the same schedule run (was not obvious to me)
Point to apply_deferred example
Remove mentions of System::apply_deferred and Schedule::apply_deferred which are probably too low level for the most users

With https://github.com/bevyengine/bevy/pull/9822 merged the story here is a little more complex now.

Suggestions how to rephrase it?
I submit PRs to rustdoc comments, when I'm trying to understand something, and apparently I don't always understand it correctly.
Also that PR says:

This PR auto inserts sync points if there are deferred buffers on a system and there are dependents on that system (systems with after relationships).

Doesn't it mean that apply_deferred example is outdated — apply_deferred call is no longer needed here?
https://github.com/bevyengine/bevy/blob/8067e46049f222d37ac394745805bad98979980f/examples/ecs/apply_deferred.rs#L22-L29

Doesn't it mean that apply_deferred example is outdated — apply_deferred call is no longer needed here?

Yeah probably. You can still add apply_deferred manually and the algorithm will respect it, but the algo doesn't merge manually added sync points together only the auto added ones. For that reason I would not recommend not adding sync points in manually. For the example it might make sense to make a new schedule that disables auto inserted sync points. That or just delete it. That should be done in a separate PR of course.

Suggestions how to rephrase it?

I think the main point of emphasis should be that it's enough to add a before/after relationship between the systems for them to see the effect of commands.

Changed the docs — updated with new knowledge for me, and moved it to apply_deferred.


Free Response Question No. 1

FRQ
Iteration with 2D array

2.7
FRQ finished with nice insights,
Arrays are completed. Prints the array horizontally and with objects. Also added to the song to make it more complete.


Topology bind/overlay cleanup

The main goal is to cleanup the topology file as much as possible.
The two main changes to achieve this are:

Move bind address from topology to env (the bind address is only important for its own instance).
Define AS global overlay ports for infra/dispatcher and BR.
Currently we have a default overlayPort and also we can specify different overlay port per service.
The proposal is to have a default overlayPort for all infra/dispatcher and another overlayPort for BRs.
It also introduces a requirement of a different address per IFID.

To support multiple IFIDs on the same address #1001 (ie. IXP networks), we need to determine the IFID of a packet by its source address which should match an IFID remote address (this is obviously subject to address spoofing).

Topology was simplified in https://github.com/scionproto/scion/pull/3440.
Regarding the points in the top comment:

bind addresses for services are no longer supported in Go code; bind addresses for underlay (overlay, in the old terminology) ports are still supported s.t. BRs can sit behind NATs
custom bind underlay (overlay, in the old terminology) ports are ignored
ASes still have underlay UDP port 30041 hard-coded

Note that this only changed how topology files are interpreted in Go applications, the file format itself was not changed, so the Breaking change label is removed.


Added Laos Dailing Code

Laos phoneCode empty

Hi, I see there are couple of empty localized names. If you can fill them all I can merge this. Btw it would be much better if you create separate pull request for every feature next time.


Add API to check if TextEditor is in preview status

The use case that I have in mind for it is to defer linting on preview tabs.
Also see https://github.com/atom/atom/issues/9165#issuecomment-165405260
Reference: https://github.com/atom/atom/pull/10171

Fixed by #10178


Adding Multus and Calico CNI to Minikube

Adding support for Calico and Multus to Minikube and increasing the default timeout for creating deployments to 240s

tested on minikube in macos.
networking suite working as expected.


Support bigint

The CDDL specification mentions bigint in the following section
      biguint = #6.2(bstr)
      bignint = #6.3(bstr)
      bigint = biguint / bignint
      integer = int / bigint
      unsigned = uint / biguint

However, historically we don't support any kind of bigint and instead just use big_int = _CDDL_CODEGEN_EXTERN_TYPE_
This isn't great because every Plutus datum needs bigint, so anybody that wants to use cddl-codegen to generate code for their dApp (ex: projected NFT dApp) needs to tackle this
In my opinion, we have two options:

Mention somewhere in the docs that if you need bigint and is for Cardano to just import relevant CML crate and use BigInt from it
Add bigint as part of the static types shipped in cddl-codegen. This means code duplication if you're using multiple cddl-codegen generated libraries, but this is the same as having duplicate definitions of DeserializeError which we already do

It should be worth noting that big_int (defined in conway.cddl), while very similar, is NOT the same as the bigint defined in the CDDL/CBOR RFC spec.
big_int = int / big_uint / big_nint
big_uint = #6.2(bounded_bytes)
big_nint = #6.3(bounded_bytes)

bounded_bytes = bytes .size (0..64)
  ; the real bounded_bytes does not have this limit. it instead has a different
  ; limit which cannot be expressed in CDDL.
  ; The limit is as follows:
  ;  - bytes with a definite-length encoding are limited to size 0..64
  ;  - for bytes with an indefinite-length CBOR encoding, each chunk is
  ;    limited to size 0..64
  ;  ( reminder: in CBOR, the indefinite-length encoding of bytestrings
  ;    consists of a token #2.31 followed by a sequence of definite-length
  ;    encoded bytestrings and a stop code )

So it has the same general structure and might USUALLY be equivalent, but the bytes are encoded in a special way, I assume to get around copyright issues when storing bytes on-chain without the cumbersome 64 byte limit that we had with transaction metadata.
If we export anything we should be consistent with Int ideally. Right now Int is always output whenever it is used, we could do the same with bigint. This Bigint would need to be slightly different from CML's BigInt due to that encoding detail.

but this is the same as having duplicate definitions of DeserializeError which we already do

You can avoid this now by passing in --common-import-override=cml-core (or wherever DeserializeError, serializaton module, etc are)
On another note, if creating cddl-codegen libs to work with plutus datums is going to be a common thing we could provide docs + a tool similar to what we do for transaction metadatums. We could even go a step further and allow that tool to now only validate the cddl to see if it conforms like the existing one in tools/metadata-cddl-checker but to also have it call cddl-codegen with the appropriate parameters and maybe even generate some basic conversion functions like we have in cip25/cip36 to go to/from the custom type to PlutusDatum (or TransactionMetadatum/Metadata if we update the tx one too).


Added a getter in HelixBrokerStarter to get the access control factory

Codecov Report

Merging #2182 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2182      +/-   ##
==========================================
- Coverage   69.78%   69.78%   -0.01%
==========================================
  Files         824      824
  Lines       39141    39145       +4
  Branches     5272     5272
==========================================
+ Hits        27314    27316       +2
- Misses      10023    10024       +1
- Partials     1804     1805       +1

Impacted Files
Coverage Δ

...kedin/pinot/broker/broker/BrokerServerBuilder.java
87.23% <100%> (+0.27%)
:arrow_up:

...ot/broker/requesthandler/BrokerRequestHandler.java
87.12% <100%> (ø)
:arrow_up:

.../pinot/broker/broker/helix/HelixBrokerStarter.java
70.83% <50%> (-0.45%)
:arrow_down:

...impl/dictionary/DoubleOnHeapMutableDictionary.java
68.88% <0%> (-8.89%)
:arrow_down:

.../pinot/core/query/reduce/InAndNotInComparison.java
74.19% <0%> (-6.46%)
:arrow_down:

...r/helix/SegmentOnlineOfflineStateModelFactory.java
56.38% <0%> (-6.39%)
:arrow_down:

.../impl/dictionary/LongOffHeapMutableDictionary.java
81.81% <0%> (-5.46%)
:arrow_down:

...impl/dictionary/FloatOffHeapMutableDictionary.java
89.09% <0%> (-5.46%)
:arrow_down:

...not/core/query/pruner/DataSchemaSegmentPruner.java
53.65% <0%> (-4.88%)
:arrow_down:

...e/operator/dociditerators/BitmapDocIdIterator.java
60.71% <0%> (-3.58%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41215a...889afde. Read the comment docs.


Make cache key the pnpm lock file

:tada: This PR is included in version 5.9.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


FacetBasis(..., facets=) raises IndexError

def is_outer_boundary(x):
    return np.logical_or(
        np.isclose(abs(x[0]-.5), .5),
        np.isclose(abs(x[1]-.5), .5),
    )

mesh = skfem.MeshTri().refined(1)
basis_p1 = skfem.Basis(mesh, skfem.ElementTriP1())
basis_p1.get_dofs(facets=is_outer_boundary)  # no exception here
fbasis_p1 = skfem.FacetBasis(mesh, basis_p1.elem, facets=is_outer_boundary)

\scikit-fem\skfem\assembly\basis\boundary_facet_basis.py in __init__(self, mesh, elem, mapping, intorder, quadrature, facets, _side, dofs)
     69         else:
     70             self.find = facets
---> 71         self.tind = self.mesh.f2t[_side, self.find]
     72         self._side = _side  # for debugging
     73

IndexError: only integers, slices (`:`), ellipsis (`...`), numpy.newaxis (`None`) and integer or boolean arrays are valid indices

I think facets must be an array of facet indices, so you must do facets=mesh.facets_satisfying(is_outer_boundary)). You think it should support Callable?

Hmmm. You have me in a bind.  If I look from the inside out, I see why it is how it is. But if I think as a user, from the outside in, the inconsistency makes no sense.
get_dofs() is already scary complicated. Documenting and testing functions as powerful and flexible as that one is hard to do...  and I tend to favor "one thing in, one thing out" as a rule....
On the other hand, clean and consistent abstractions make it so, so, so much easier to code without having to constantly look up docs/source.
I suppose I vote that (..., facets=*) should support the same interface, wherever it is encontered. Ditto for (..., elements=*).
And I discovered when writing the extended doc draft that (..., facets=*) makes zero sense for P0.  But it doesn't raise an exception explaining that.  So I would also nominate an issue for fixing the exceptions that are raised when you supply (..., facets=*)  or (..., elements=*) in a context that makes no sense.

Your suggestion suppressed the exception. The following runs successfully.
fbasis_p1 = skfem.FacetBasis(mesh, basis_p1.elem, facets=mesh.facets_satisfying(is_outer_boundary))

But there is still some confusion:
def is_outer_boundary(x):
    return np.logical_or(
        np.isclose(abs(x[0]-.5), .5),
        np.isclose(abs(x[1]-.5), .5),
    )

mesh = skfem.MeshTri().refined(1)
basis_p1 = skfem.Basis(mesh, skfem.ElementTriP1())
basis_p1.get_dofs(facets=is_outer_boundary)
fbasis_p1 = skfem.FacetBasis(mesh, basis_p1.elem, facets=mesh.facets_satisfying(is_outer_boundary))

points, weights = fbasis_p1.quadrature
global_points = fbasis_p1.mapping.F(points)
plt.subplots(figsize=(5,5))
plt.plot(global_points[0], global_points[1], 'or')
skfem.visuals.matplotlib.draw(mesh, ax=plt.gca())
plt.xlabel('x[0]'); plt.ylabel('x[1]');

Why are these quadrature points not all on the facets I specified?  Identical code produces plots that make sense for CellBasis (see https://github.com/kinnala/scikit-fem/discussions/817)

Change mapping.F to mapping.G which is the boundary mapping part of Mapping.

If you want to see only the facets you specified, then I suggest you plot global_points = fbasis_p1.global_coordinates().value:

FacetBasis (which is an alias to BoundaryFacetBasis) will by default only consider outer boundaries so your facets=... is not really necessary.

If you want to do internal facets there is InteriorFacetBasis but there is a caveat related to side keyword argument since the value of the basis on the internal facet is not unique in general, e.g., Crouzeix-Raviart element is not continuous across the entire internal facet.

And I discovered when writing the extended doc draft that (..., facets=*) makes zero sense for P0. But it doesn't raise an exception explaining that. So I would also nominate an issue for fixing the exceptions that are raised when you supply (..., facets=*) or (..., elements=*) in a context that makes no sense.

Sometimes it is hard for me to predict what makes no sense. If you add exceptions to everything, then you end up blocking some kind of unexpected use cases that other people were using in their code. I recently had this issue with meshio where I resorted to forking the library and commented one line which was essentially raise Exception.

I resorted to forking the library and commented out one line which was essentially raise Exception.

I guess except for really fatal things, why should a library raise Exception? It should have raised MeshioExceptionBlahBlah so you can just try except around it instead of forking and commenting. Or maybe your saying you needed meshio.something() to complete, and knew that it could, but instead it raised.  That is annoying.

If you add exceptions to everything

Numpy faced this problem with divide by zero, etc and decided to add options to make that an exception or not. So you're right, it is sometimes very hard to know where to draw the lines. What should a function do when it can complete, but knows its return value is questionable/invalid?

Edit 2: Now looking at it more carefully, why does it not make sense? I think it works as expected, i.e., evaluates P0 on quadrature points on the boundary?

I am under the impression that P0 is in general undefined on the facets because that's the exact spot where it is discontinuous. Therefore evaluating functions there would be invalid mathematically and unpredictable computationally.

I guess except for really fatal things, why should a library raise Exception? It should have raised MeshioExceptionBlahBlah so you can just try except around it instead of forking and commenting. Or maybe your saying you needed meshio.something() to complete, and knew that it could, but instead it raised. That is annoying.

That's exactly the case, it stopped short because of the exception even though the rest of the function would work just fine.

I am under the impression that P0 is in general undefined on the facets because that's the exact spot where it is discontinuous. Therefore evaluating functions there would be invalid mathematically and unpredictable computationally.

Mathematically we have the concept of a "trace". The value of the trace depends on the side which is used to approach the discontinuity. On external boundary the trace is unique because nothing happens outside of the domain. On internal facets you pick this by the kwarg side: InteriorFacetBasis(..., side=0) or side=1.

If you want to see only the facets you specified, then I suggest you plot global_points = fbasis_p1.global_coordinates().value

This worked, and worked for CellBasis as well. Is global_coordinates() the recommeded way to access the quadrature locations? (I'll update https://github.com/kinnala/scikit-fem/discussions/817 if so.)

If you want to see only the facets you specified, then I suggest you plot global_points = fbasis_p1.global_coordinates().value

This worked, and worked for CellBasis as well. Is global_coordinates() the recommeded way to access the quadrature locations? (I'll update #817 if so.)

Yes in the sense that it is also used by w.x inside the form definitions (BilinearForm and LinearForm).

Speaking of BilinearForm and LinearForm
def f(x):
    """arbitrary function definition"""
    return  # array of function evaluated at x

@BilinearForm
def laplace(u, v, w):
    return dot(grad(u), grad(v))

@LinearForm
def rhs(v, w):
    return f(w.x) * v

A = skfem.asm(laplace, basis_p1)
b = skfem.asm(rhs, basis_p1)

Is it correct that after the above code, (and taking \phi_i and \phi_j to be the ith and jth basis functions in basis_p1)

Yes

And after the above code plus
@skfem.Functional
def test1(w):
    return w['g']

x = skfem.asm(test1, basis_p1, g=f(basis_p1.global_points().value))

@skfem.Functional
def test2(w):
    return f(w.x)

y = skfem.asm(test2, basis_p1)

@skfem.Functional
def test3(w):
    return w['g'](w.x)

z = skfem.asm(test3, basis_p1, g=f)

The first works mainly due to backwards compatibility but I'd discourage using it in the docs. The second one is also correct. I'm not sure about the third one though. I need to think what happens there.

Is it correct that after the above code, (and taking \phi_i and \phi_j to be the ith and jth basis functions in basis_p1)

Yes

A = skfem.asm(laplace, [basis1_p1, basis2_p1], basis3_p0])

compute

using the union of the basis functions and possibly over subdomains of Omega?
Is this an equivalent piece of code?
A = np.vstack([
    skfem.asm(laplace, basis1_p1),
    skfem.asm(laplace, basis2_p1),
    skfem.asm(laplace, basis3_p0),
])

skfem.asm will loop over all possible combinations of bases, assemble the same form for all combinations, and sum the resulting matrices. This functionality was mainly created for stuff that have jump terms as explained here: https://scikit-fem.readthedocs.io/en/latest/howto.html#assembling-jump-terms


model flow chart does not represent code anymore

https://github.com/allfed/pytradeshifts/blob/main/results/figures/model_flow_chart.png

https://github.com/allfed/pytradeshifts/blob/main/docs/Model Description Flow Chart/flow.dot is used to create the figure

Would also make sense to make this nicer and add a final arrow to postprocessing

Solved in https://github.com/allfed/pytradeshifts/pull/33


Raise minimum PHP requirements

Since there's no sense to start new project with 7.4 when there's stable 8.0, raising minimum requirements for the application templates and demos (but not packages) could be done.

What's the purpose?

It makes no sense to start new project on an outdated PHP while it makes sense to use individual packages on existing PHP 7.4 projects.


[Question] How to use FTP upload?

Hi,
I've set up the connection to Azure Web App using Post-build action "Publish an Azure Web App". The problem I see is that it tries to  connect to some sort of GIT repository there, which I'm not utilizing (at least to my knowledge).
So the question is: how to use FTP instead of GIT? Is it possible only through Jenkins Pipeline?
Sorry if my questions feel dumb but I'm completely new to Azure and I'm discovering everything along the way :)

FTP is deprecated in latest version. Now WAR Deploy is used for Java app, and Git Deploy for other languages.

Oh, that might be an issue. So what should I do in the following scenario:

local GIT,
local Jenkins,
Build made on Jenkins,
Want to just upload compiled sources to Azure Web app?

Azure Web App just use Git as something like storage rather than source control. You can specify your build artifacts and the plugin will check in and push those files to server.

Is it possible to use Jenkins build result/workspace files?
I don't get what GIT is for in this flow. What I imagine is:
private git -> jenkins pull -> jenkins build -> upload dist folder to Azure Web Apps
Can you shed some light on this? Am I completely wrong with my assumptions and what I seek in comparison to what this plugin and Azure allows?

This plugin does the job that upload dist folder to Azure Web App in your flow. Git is one of the two ways to do that. Each Azure Web App has a corresponding Git server. This plugin checks in your dist files and does git push to the server. Azure Web App then automatically triggers a git pull to deploy your files to target location. So here Git is just a way to upload your files. Nothing related to your source code.
You can find details on how this works in Kudu documents.
In short, just fill in your dist files pattern in filePath field and don't worry about Git. That's internal implementation details. If you met some issues when use Git via http proxy, see this article.

BTW, FTP deploy is still in code base. If you prefer that you can change this line:
https://github.com/jenkinsci/azure-app-service-plugin/blob/9882789dc1a598430165b47aee12817ea982ea82/src/main/java/com/microsoft/jenkins/appservice/WebAppDeploymentCommandContext.java#L153
to
 builder.withStartCommand(FTPDeployCommand.class);

Awesome :) Thanks for the explanation, I will try that and get back to you :D

Turned out that I've made mistake with setting up source folder and the plugin wasn't throwing any error if the path with sources doesn't exist.
After fixing it I see some progress but new error appears:
> git push https://xxx.scm.azurewebsites.net:443/xxx.git master:master
ERROR: Build step failed with exception
hudson.plugins.git.GitException: Command "git push https://xxx.scm.azurewebsites.net:443/xxx.git master:master" returned status code 128:
stdout:
stderr: fatal: unable to access 'https://xxx.scm.azurewebsites.net:443/xxx.git/': Invalid file descriptor

	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2002)
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1721)
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$8.execute(CliGitAPIImpl.java:2081)
	at com.microsoft.jenkins.appservice.commands.GitDeployCommand.execute(GitDeployCommand.java:114)
	at com.microsoft.jenkins.appservice.commands.GitDeployCommand.execute(GitDeployCommand.java:1)
	at com.microsoft.jenkins.azurecommons.command.CommandService.runCommand(CommandService.java:88)
	at com.microsoft.jenkins.azurecommons.command.CommandService.execute(CommandService.java:96)
	at com.microsoft.jenkins.azurecommons.command.CommandService.executeCommands(CommandService.java:75)
	at com.microsoft.jenkins.azurecommons.command.BaseCommandContext.executeCommands(BaseCommandContext.java:77)
	at com.microsoft.jenkins.appservice.WebAppDeploymentRecorder.perform(WebAppDeploymentRecorder.java:203)
	at hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
	at hudson.model.Build$BuildExecution.post2(Build.java:186)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
	at hudson.model.Run.execute(Run.java:1823)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)
Build step 'Publish an Azure Web App' marked build as failure
Finished: FAILURE

Any idea what might be happening here?

I've increased git http buffer git config http.postBuffer 524288000 and it solved the errror.
Build and push to Azure now works without error but I don't see any changes online. Do I need some additional setup on Azure do make it work?
Seen branch in repository origin/master
Seen 1 remote branch
 > git config core.sparsecheckout # timeout=10
 > git checkout -f master
 > git add angular/dist/0.000bc02b7f8fef843f62.chunk.js # timeout=10
 > git add angular/dist/3rdpartylicenses.txt # timeout=10
 > git add angular/dist/MaterialIcons-Regular.012cf6a10129e2275d79.woff # timeout=10
 > git add angular/dist/MaterialIcons-Regular.570eb83859dc23dd0eec.woff2 # timeout=10
 > git add angular/dist/MaterialIcons-Regular.a37b0c01c0baf1888ca8.ttf # timeout=10
 > git add angular/dist/MaterialIcons-Regular.e79bfd88537def476913.eot # timeout=10
 > git add angular/dist/assets/Home_ContactsCoaching.svg # timeout=10
 > git add angular/dist/assets/Home_GetStarted.svg # timeout=10
 > git add angular/dist/assets/Home_ToolsTemplates.svg # timeout=10
 > git add angular/dist/assets/TopNav_UserProfile.svg # timeout=10
 > git add angular/dist/assets/UXLab_toolsAndTemplates.png # timeout=10
 > git add angular/dist/assets/UXlab_contacts.png # timeout=10
 > git add angular/dist/assets/UXlab_getStarted.png # timeout=10
 > git add angular/dist/assets/wow_icon_contactsCoaching_1920px.png # timeout=10
 > git add angular/dist/assets/wow_icon_getstarted_1920x.png # timeout=10
 > git add angular/dist/assets/wow_icon_toolsTemplates_1920px.png # timeout=10
 > git add angular/dist/favicon.ico # timeout=10
 > git add angular/dist/index.html # timeout=10
 > git add angular/dist/inline.d9b134101eb7ece0451f.bundle.js # timeout=10
 > git add angular/dist/main.e3d74b36e9a29553554d.bundle.js # timeout=10
 > git add angular/dist/polyfills.8d911633195c2fb7185f.bundle.js # timeout=10
 > git add angular/dist/styles.2fb50bd5603d6919d036.bundle.css # timeout=10
 > git add angular/dist/vendor.d283d5869414d5cccdef.bundle.js # timeout=10
 > git add angular/dist/web.config # timeout=10
Deploy repository is up-to-date. Nothing to commit.
Done Azure Web App deployment.
Finished: SUCCESS

I've played around with plugin configuration and it worked :D
I had to set it up like this:
Files: **/*
Source Directory: angular/dist
Target Directory left empty

Thanks for everything, it really helped me wrap my head around how Azure and this plugin works :)

Great to know that!


Constants as triggers (reduce deferred connection usage)

Problem
Deferred connections were invented to solve the problem that caused by constant implementation - New component is infinite emitter. As a result everywhere where constants are used we need to somehow limit them. To avoid explicit Lock bloat we added -> (...) syntax. This however has some problems:

It makes (manual) analysis of a program (tracing) harder because of lots virtual of lock:sig and lock:data entities moving data around
This technique really defers receiving, not sending, that's one of the reasons we can't have buffered channels by default, see #681 for details
Another form of connection exist, that also makes programs a bit more noisy. (As a counterpart - deferred connections might still remain because they are solving their own problem, that is mostly critical for constants, but not exclusively existing with them)

Solution
At least for constants consider usage of chained connections instead of deferred. Instead of x -> (y -> z) write x -> y -> z where y is constant reference or message literal.
Before
:foo -> (42 -> :bar)

Translates to:
const s = 'definitely not a valid URL'

// ...

#bind(s)
send42 New
---
:foo -> lock:sig
send42 -> lock:data
lock:data -> :bar

Trace:
sent | :foo | {}
send | send42 | 42
recv | lock:sig | {}
recv | lock:data | 42
sent | send42 | 42 // at least 1 more time in this case
sent | lock:data | 42
recv | :bar | 42

After
:foo -> 42 -> :bar

Translates to:
const s = 'definitely not a valid URL'

// ...

#bind(s)
send42 NewV2
---
:foo -> newV2:sig
newV2:data -> :bar

Trace:
sent | :foo | {}
recv | send42 | {}
sent | send42 | 42 // exactly 1 time in this case
recv | :bar | 42

Benefits

No () noise (especially good for nested defers)
No sent | __newXXX__ and __lockXXX__ noise in trace logs
Less channels and function calls, less message passing (better performance and memory consumption)
Ability to add automatic buffers

No () noise

Maybe especially good when defer and chain are combined:
:start -> [(1 -> add:acc), (2 -> add:el)]

// vs

:start -> [1 -> add:acc, 2 -> add:el]

Please note that #617 must be implemented for this
Steps To Implement

Implement NewV2 (with obviously better name)
Make changes to desugarer to support chained connections with const refs / msg literals
Consider removing deferred connections (must be thought of very carefully, this is still powerful feature - they solve real problem and they are universal in a way that they can infinitely nest!)

BTW New might not be the best name for what it is

What about cases where we don't mind have infinite sending? I.e. when you have at least 1 port bound to dynamic data and 1 or more to constants?

^ Well, that still lead to #681 problem so... Better not to have it

Then the question is - do we always bind our constants to some receiving event?

Problem - using with other sugar forms
We need to support refs and literals in binary/ternary/switch/match expressions
(1 + 1) -> ...

($a + $b) -> ...

... -> switch {
    $foo -> ...
    $bar -> ...
}

Options we have

Close this issue and keep everything as is
Support 2 versions (and maybe same should be done for #741)
Figure out how to keep only trigger semantics version and support these cases


Understanding API Gateway Lambda Proxy versions - Gateway using V1, serverless java container uses V2?

I am attempting to implement a simple lambda function using Javalin 4.6.4 (from #425), but I think my problem isn't related to Javalin. Using version 1.8.2 of the java container.
I have set up a simple API Gateway resource, GET "/", and have enabled "Use Lambda Proxy Integration". It calls my Lambda function. But the proxy cannot deserialise the request, with this exception:
com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "resource" (class com.amazonaws.serverless.proxy.model.HttpApiV2ProxyRequest), not marked as ignorable (12 known properties: "requestContext", "rawQueryString", "body", "queryStringParameters", "isBase64Encoded", "routeKey", "version", "stageVariables", "rawPath", "cookies", "headers", "pathParameters"])

I can see clearly that the HttpApiV2ProxyRequest class doesn't have a resource field.
But the API Gateway Documentation clearly states that the API Gateway Lambda Proxy integration does have a resource field, and others too: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html
{
  "version": "1.0",
  "resource": "/my/path",
  "path": "/my/path",
  "httpMethod": "GET",
  "headers": {
    "header1": "value1",
    "header2": "value2"
  },
//... etc

I think it's a version problem - but I've no idea why API Gateway is using version 1.0. Of course, if I turn off Lambda Proxy Integration, nothing works there either:
com.amazonaws.serverless.exceptions.InvalidRequestEventException: The incoming event is not a valid HTTP API v2 proxy request

I'm sure it's my error, I just don't know how to fix it.

Ah. I had chosen "REST" API because all my other lambdas are on REST APIs, and it describes it as working for "Lambda, HTTP, AWS Services" - definitely a cooler, longer list than the "HTTP API" option.
V2 is much less overtly helpful than V1. Deployed and I think I have a route, but GET / returns an Internal Server Error and the logs show this:
{
    "requestId": "VAyFqhInrPEEJVA=",
    "ip": "<IP_ADDRESS>",
    "requestTime": "09/Jul/2022:18:34:12 +0000",
    "httpMethod": "GET",
    "routeKey": "GET /{proxy+}",
    "status": "500",
    "protocol": "HTTP/1.1",
    "responseLength": "35"
}

Does that look right?

I think I prefer V1, but it's (probably) working now. Closing this.

Hi @v79,
we are supporting both V1 and V2 so you can pick whatever you prefer (see https://github.com/awslabs/aws-serverless-java-container/wiki#lambda-handler-classes).


What is the purpose of the ssh_tunnel in Justfile

Hi there!
I'm curious what the purpose of these lines in the Justfile are?
ssh_tunnel:
  ssh -L 27017:ameo.design:27017 -L 6379:ameo.design:6379<EMAIL_ADDRESS>

I use it for local dev, to allow me to connect to the MongoDB and Redis running on my server as if they were running on localhost.  It's nice so that I don't have to set up special firewall rules to expose them to my IP address if I'm working remotely etc. and it gives me access to the live prod database so I can compare results to the live site as I work.

Cool! Thanks for explaining!


Running rubocop --auto-gen-config ignores RSpec/BeforeAfterAll offense

Expected behavior
After running rubocop --auto-gen-config, all the offenses are added to the .rubocop_todo.yml file, and then, if you run rubocop -a you should have 0 offenses detected.
Actual behavior
I ran rubocop -a and there's still 1 offense related to the RSpec/BeforeAfterAll cop
Steps to reproduce the problem

In your rails_helper file, define something like this:

RSpec.configure do |config|

  config.before(:all) do
    ...
  end

  config.use_transactional_fixtures = true

end

Install rubocop, rubocop-rails and rubocop-rspec with the versions mentioned below
Run rubocop --auto-gen-config
Run rubocop -a
Check that you have 1 offense

RuboCop version
1.7.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.18.0, running on ruby 2.7.6 arm64-darwin21)
  - rubocop-performance 1.5.2
  - rubocop-rails 2.11.3
  - rubocop-rspec 2.4.0

@pirj I only had 2 offenses in the whole repo, so I'm sure it didn't exceed that number

Let's double-check if it's a cop deficiency, or it works as designed. May I kindly ask you to run the above command, @mwolman ?

I'm inclined to close this, as the behaviour seems to be as expected.
Thanks for reporting, this motivated me to check some gen-config related code and docs.


Footer fixed on Mobile

The footer becomes fixed at the bottom and doesn't scroll when i reach mobile UI. Been unsuccessful in getting to position appropriately and scroll.
I removed my CSS and made a test page, and it still happens.

Can you provide a codepen that reproduces the issue for you?

Here it is in jsfiddle http://jsfiddle.net/mqxd5dz6/1/

The footer should be within  the content area of the layout. In this  case the <main> element, since it has the .mdl-layout__content class. All page content goes within that.


chore: release 0.7.2

:robot: I have created a release beep boop
0.7.2 (2023-03-21)
Other

prepare pipeline again (a05d484)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mowies/lifecycle-controller/releases/tag/v0.7.2 :sunflower:


feat: support launching orioledb for local dev

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 11 (27.27%)  changed or added relevant lines in 2 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 58.535%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/start/start.go
2
5
40.0%

cmd/start.go
1
6
16.67%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
12.31%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
5689

Relevant Lines:
9719

💛  - Coveralls


can not login to gitea admin account

according to this feature https://github.com/threefoldtech/tf-gitea/issues/8 , we had access admin successfully with Nginx was working as a reverse proxy with gitea but now I can not log in when using the gitea self-signed https with port 3000
when login go below

fixed after https://github.com/threefoldtech/tf-gitea/commit/b63f8429483290e96fadbc7a9ca0bf9ff9c1232a
the new flist has been build with new fix https://hub.grid.tf/bishoy.3bot/threefolddev-gitea_all_in_one-latest.flist

closing as it working now


[Snyk] Security upgrade org.springframework.security:spring-security-web from 6.2.1 to 6.2.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity
Reachability

114/1000  Why? Confidentiality impact: High, Integrity impact: Low, Availability impact: None, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): Required, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00043, Social Trends: No, Days since published: 3, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 7.03, Likelihood: 1.61, Score Version: V5
Open Redirect SNYK-JAVA-ORGSPRINGFRAMEWORK-6444790
org.springframework.security:spring-security-web:  6.2.1 -> 6.2.3
No
No Known Exploit
No Path Found

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect

Hi @RoKrish14 this was already closed on PR from dependabot https://github.com/eclipse-tractusx/vas-country-risk-backend/pull/112


Migrate the engine to AndroidX

The engine is still using the support libraries.  Now, that we generate Maven artifacts, we can update the engine dependencies: https://github.com/flutter/engine/blob/3103499019d4b5235b44806a3ea387e1dca5c66a/tools/android_support/files.json

@shihaohong are we actually conceptually depending on SDK 29 now via https://github.com/flutter/buildroot/pull/291? If so, this is a good reason to try to migrate earlier rather than later.

@xster Yes, the engine depends on Android SDK 29 now


[SPARK-23313][DOC] Add a migration guide for ORC

What changes were proposed in this pull request?
This PR adds a migration guide documentation for ORC.

How was this patch tested?
N/A.

Test build #86969 has started for PR 20484 at commit 20f99c6.

cc @gatorsmile and @cloud-fan .

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/509/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/510/
Test PASSed.

Merged build finished. Test PASSed.

Test build #86970 has started for PR 20484 at commit 1bb23ef.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/511/
Test PASSed.

Test build #86969 has finished for PR 20484 at commit 20f99c6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86969/
Test PASSed.

Merged build finished. Test PASSed.

Test build #86971 has started for PR 20484 at commit df08899.

Test build #86970 has finished for PR 20484 at commit 1bb23ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86970/
Test PASSed.

Merged build finished. Test PASSed.

Test build #86971 has finished for PR 20484 at commit df08899.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86971/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/513/
Test PASSed.

Merged build finished. Test PASSed.

Test build #86973 has started for PR 20484 at commit 239714a.

Test build #86973 has finished for PR 20484 at commit 239714a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86973/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/517/
Test PASSed.

Test build #86977 has started for PR 20484 at commit fc5b395.

Test build #86978 has started for PR 20484 at commit 7b3b0a4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/519/
Test PASSed.

Test build #86977 has finished for PR 20484 at commit fc5b395.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #86978 has finished for PR 20484 at commit 7b3b0a4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86978/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86977/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/524/
Test PASSed.

Merged build finished. Test PASSed.

Test build #86984 has started for PR 20484 at commit cb149f2.

Test build #86984 has finished for PR 20484 at commit cb149f2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86984/
Test PASSed.

@dongjoon-hyun Do our native readers respect Hive confs? If not, we need to clearly document it. I think this is a common question from the existing users of ORC readers, since they are respected in the prior versions.

Actually, I handed over all confs to ORC library. The following is all supported ORC configuration.

https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/OrcConf.java

Please note that the confs are interpreted by both Hive Conf Name and ORC Conf Names. Yesterday, @tgravescs asked about hive.exec.orc.split.strategy. For now, it's not recognized by ORC library according to OrcConf.java.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/547/
Test PASSed.

Merged build finished. Test PASSed.

Test build #87011 has started for PR 20484 at commit 436c0f4.

Test build #87011 has finished for PR 20484 at commit 436c0f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87011/
Test PASSed.

Test build #87102 has started for PR 20484 at commit 354a525.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/624/
Test PASSed.

Test build #87102 has finished for PR 20484 at commit 354a525.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87102/
Test PASSed.

@dongjoon-hyun What we need to add in the migration guide is to help the existing ORC users migrate their existing queries that are built on ORC tables.
The Hive ORC confs can be set in the hiveconf? the table properties? the serde properties (our options)? Are they still working after we implicitly/automatically convert them to use our new ORC reader? If not, we need to documents them. This also answers the questions by @tgravescs in the JIRA.
I knew there are a few conf-related bugs. It might be too late to fix them in the RC of 2.3 release, but we have to identify and document them. Thanks for your works!

I understand the situation, but I hope this will not introduce a regression due to the change of default value of convertMetastoreOrc. I created another PR, https://github.com/apache/spark/pull/20522.

With a combination of #20517 and #20522 , (1) configuration names, (2) table properties, (3) serde properties, (4) convertMetastoreOrc/Parquet=true are tested and fixed.
The only remaining thing looks like Hive ORC confs.

How about users setting the ORC-related confs in HiveConf configuration files? Are they still effective in Hive?

I'm looking at that.
BTW, can we finish table property issue in Apache Spark 2.3 at #20522 ?
Given that users already experience this for STORED AS PARQUET Hive table until now. Is it okay to mention that ORC table will do the same with Parquet table from Spark 2.3?

For the HiveConf configuration file, I tested manually. It works correctly.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/648/
Test PASSed.

Test build #87136 has started for PR 20484 at commit d259d66.

Test build #87136 has finished for PR 20484 at commit d259d66.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87136/
Test PASSed.

Are they still effective in Hive?

I just want to confirm whether all the Hive readers work fine. Could you add a test case like what we did in CliSuite?

@dongjoon-hyun This is still a regression to the existing Hive ORC users. cc @cloud-fan @sameeragarwal Maybe we should fix it before the release?

Just FYI, https://github.com/apache/spark/pull/20536 is reverting the conf convertMetastoreOrc back false. However, we still can turn it on by default in 2.3 after we fix the regression.
Thanks!

I see. I removed spark.sql.hive.convertMetastoreOrc and Hive ORC table stuff from this PR accordingly. We can add that later if we fix the regresson of convertMetastoreOrc/Parquet.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/678/
Test PASSed.

Test build #87177 has started for PR 20484 at commit 40c8e02.

why did you remove the bit about the orc configs?

Test build #87177 has finished for PR 20484 at commit 40c8e02.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87177/
Test PASSed.

Oh, I thought in this way, @tgravescs .

For ORC files, the parameter names (ORC/Hive) are the same as we see https://github.com/apache/spark/pull/20517 .
For Hive tables, we don't need a migration because we didn't touch it after #20536 . Although users turn on by manually, the table properties of Hive ORC tables are ignored completely without #20522 .

ok

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/817/
Test PASSed.

Test build #87342 has started for PR 20484 at commit 59e957a.

Test build #87342 has finished for PR 20484 at commit 59e957a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87342/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/823/
Test PASSed.

Test build #87351 has started for PR 20484 at commit 6136d25.

Test build #87353 has started for PR 20484 at commit 8ae87fc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/825/
Test PASSed.

LGTM except the above comment.

Test build #87351 has finished for PR 20484 at commit 6136d25.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87351/
Test PASSed.

Test build #87353 has finished for PR 20484 at commit 8ae87fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87353/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/826/
Test PASSed.

Test build #87354 has started for PR 20484 at commit 6887d19.

Test build #87354 has finished for PR 20484 at commit 6887d19.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87354/
Test PASSed.

Thanks! Merged to master and 2.3.

Thank you, @gatorsmile , @tgravescs , @felixcheung .


Fix the release process of Operator

Error: INSTALLATION FAILED: chart "nebula-operator" matching 1.6.2 not found in nebula-operator index. (try 'helm repo update'): no chart version found for nebula-operator-1.6.2
Apparently, the chart index does not have 1.6.2 yet.

https://github.com/vesoft-inc/nebula-operator/pull/292


Suffix

Issue #, if available:
This is enhancement of cdk deployment.
Description of changes:
When deploying with cdk, it was difficult to experiment quickly due to resource name conflicts during redeployment.
Therefore, "resource_suffix" was sdded to the cdk.json.sample files in a bid to prevent duplicate resource name errors when trying cdk redeploy.

deployment.md : added explanation for resource_suffix field
source/cdk/app.py : applied resource_suffix to MyAesSiemStack
source/cdk/mysiem/aes_siem_stack.py : applied suffix to the resources that will cause duplicate error during stack deployment
source/cdk/cdk.json.public.sample : resource_suffix added
source/cdk/cdk.json.vpc.sample : resource_suffix added
added .idea directory to gitignore

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks! We will check your solution soon.

This PR is closed as there are no plans for multi-region support. but thanks for the PR


[feature] implement wildcard subdomains for APIs' public_dns

An API's public_dns can now contain one '*' at the start or at the end of the string, and on a dot border (same rules as http://nginx.org/en/docs/http/server_names.html#wildcard_names).
If so, it will get special treatment during the lookup and the resolver will try to match any given Host header against all wildcard public_dns.
We keep things efficient by guaranteeing O(1) lookup for non wildcard public_dns. Only wildcard public_dns and paths will be O(n).
Implements #297.

:+1:


IA-1024 pagination

:warning: going along with this

remove redirect on search change
fix pagination issues on orgunits search & submissions forms
adding cypress tests on orgunits search
testing pagination features

Cypress testing are failing because blsq-component is not merged yet

Cypress testing are failing because blsq-component is not merged yet

But what about the python tests?


Want to Add popular program of Rat In A Maze in java.

Hey @1dharode,
Want to add a popular Program of RAT IN A MAZE in java
Please assign this issue to me under hacktoberfest 2022 and help me in starting my first contribution.
I have already starred the repo and forked it.

Hello, I want to work over this, please assign it to me.

Hi @1dharode , Kindly please assign me this issue.

Pls assign me this


Geoloc position of gateways in uplink packets

Hello,
With my colleagues we are not sure but we remember that the gateway bridge added geoloc meta-data (static not with a gps on gateway) that we set up in the UI in all uplink packets. Since we upgraded to Chirpstack we don't have this feature anymore.
Are we correct or our memory is failing us ?
Thank you for your help,
ngonzalez

I'm not really sure about what you mean....


Add fluxconfig.Validate() func call in validate/update webhook

Issue #, if available:
Description of changes: Add fluxconfg.Validate() func call in validate/update webhook
Testing (if applicable):

Unit test
make run controller, kubectl apply -f fluxconfig.yaml for create and update

1.6595422910437675e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/validate-anywhere-eks-amazonaws-com-v1alpha1-fluxconfig", "UID": "c988d1d8-685c-4bc1-abb3-3e8a64fca1dc", "kind": "anywhere.eks.amazonaws.com/v1alpha1, Kind=FluxConfig", "resource": {"group":"anywhere.eks.amazonaws.com","version":"v1alpha1","resource":"fluxconfigs"}}
1.6595422910441718e+09	INFO	fluxconfig-resource	validate create	{"name": "test-gitops"}
1.6595422910475402e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validate-anywhere-eks-amazonaws-com-v1alpha1-fluxconfig", "code": 200, "reason": "", "UID": "c988d1d8-685c-4bc1-abb3-3e8a64fca1dc", "allowed": true}

1.6595423790662584e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/validate-anywhere-eks-amazonaws-com-v1alpha1-fluxconfig", "UID": "e066ecd9-ab21-40d5-a93c-2daead8882eb", "kind": "anywhere.eks.amazonaws.com/v1alpha1, Kind=FluxConfig", "resource": {"group":"anywhere.eks.amazonaws.com","version":"v1alpha1","resource":"fluxconfigs"}}
1.6595423790665731e+09	INFO	fluxconfig-resource	validate update	{"name": "test-gitops"}
1.6595423790687742e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validate-anywhere-eks-amazonaws-com-v1alpha1-fluxconfig", "code": 422, "reason": "Invalid", "UID": "e066ecd9-ab21-40d5-a93c-2daead8882eb", "allowed": false}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Cleanup of files and incorporate Codacy analysis

This PR cleans up the source files and re-organizes them into better modules. It also does the following:

README.md updated to point to correct uber-jar file for examples.
Apache commons-cli removed and replaced with JCommander.
Test files cleaned up.
Explicit scopes inserted instead of relying on default package protection.
Codacy issues addressed.

Codecov Report

Merging #7 into master will increase coverage by 3.06%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
+ Coverage     77.48%   80.55%   +3.06%
  Complexity      199      199
============================================
  Files            12       13       +1
  Lines           875      833      -42
  Branches         59       54       -5
============================================
- Hits            678      671       -7
+ Misses          191      155      -36
- Partials          6        7       +1

Impacted Files
Coverage Δ
Complexity Δ

src/com/chip8java/emulator/runner/Runner.java
0% <0%> (ø)
0 <0> (?)

src/com/chip8java/emulator/runner/Arguments.java
0% <0%> (ø)
0 <0> (?)

src/com/chip8java/emulator/components/Memory.java
100% <100%> (ø)
10 <1> (?)

...mulator/listeners/ResetMenuItemActionListener.java
100% <100%> (ø)
2 <1> (ø)
:arrow_down:

.../com/chip8java/emulator/components/ScreenMode.java
100% <100%> (ø)
5 <2> (?)

...8java/emulator/listeners/StepMenuItemListener.java
100% <100%> (ø)
3 <0> (ø)
:arrow_down:

src/com/chip8java/emulator/components/Screen.java
95.87% <100%> (ø)
19 <2> (?)

...ava/emulator/components/CentralProcessingUnit.java
93.66% <100%> (ø)
136 <0> (?)

...java/emulator/listeners/TraceMenuItemListener.java
100% <100%> (ø)
3 <0> (ø)
:arrow_down:

...rc/com/chip8java/emulator/components/Keyboard.java
42.1% <33.33%> (ø)
6 <2> (?)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d075883...f51f2e4. Read the comment docs.


CreateHubbardHamiltonian README.md is out of date

HubbardSimulation.qs and HubbardSimulationSample.csproj no longer exist (referenced in the manifest).

Thanks for bringing this up. This is about the README.md in
https://github.com/Microsoft/Quantum/tree/master/Chemistry/CreateHubbardHamiltonian
as the name implies this sample shows how to create Hubbard Hamiltonians in C# using the chemistry library.  The README.md was probably copied from the original https://github.com/Microsoft/Quantum/tree/master/Samples/src/HubbardSimulation which does the HubbardSimulation without using the chemistry library (it predates it).
It indeed needs to be fixed.


get_contract_deployment_info that returns both service and raiden deployment info by default

get_contracts_deployed() had two problems

you had to call it twice to get all deployment data #774
the name sounded like the function deploys contracts, but it doesn't #671

This PR fixes both by introducing a new interface function get_contracts_deployment_info() that takes module: str instead of services: bool.  Moreover, module defaults to all, meaning "give me deployment info for all modules".
Also get_contracts_deployed() is deprecated.

I have to change README too.

I realized somehow deployment['contracts'] were just overwritten when I do deployment.update(another_deployment).

@LefterisJP merge?


Add supported package definition type

We are adding a new type to cosmos. This type will represent the supported packaging formats. The  idea is that we will use this type in contexts where we only want to support certain packages.

@larioj left a few comments.

@larioj looks good, I'm just a bit uncertain about some use cases; where should or shouldn't we be using SupportedPackageDefinition?

Notes on the latest changes

Add response contains a v3Package.
Package storage decodes types based on the media type. This is not compiler checked.
The commits are actually well organized.


when layoutType is floating, i got this error

Exception caught by widgets library ═══════════════════════════════════
Remote uid can not be null or 0
'package:agora_rtc_engine/src/render/video_view_controller.dart':
video_view_controller.dart:1
Failed assertion: line 74 pos 16: 'canvas.uid != null && canvas.uid != 0'

Hey @kyawthet-wam,
Thanks for reporting the issue. We'll release a fix for this soon.

the same issue when I pinned the remote user.


feat: [UIE-8137] - IAM RBAC: add new user details component

Description 📝
IAM RBAC - user details component.
This component is almost identical to an existing one in the Account, with some adjustments.
One difference is the addition of a new field showing the number of assigned roles.
Changes  🔄
List any change(s) relevant to the reviewer.

new user details component

Target release date 🗓
1/14/25 (dev)
Preview 📷
Include a screenshot or screen recording of the change.
:lock: Use the Mask Sensitive Data setting for security.
:bulb: Use <video src="" /> tag when including recordings in table.

Before
After

📷

📷

How to test 🧪
Prerequisites

Ensure the Identity and Access Beta flag is enabled in dev tools
Click on the username in the users table or click on the user's menu View User Details

Verification steps
(How to verify changes)

[ ] Confirm user details renders.

 Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿  Providing accessibility support

[x] I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

[x] All unit tests are passing
[x] TypeScript compilation succeeded without errors
[x] Code passes all linting rules

Will the IAM user details page replace the exiting Account/Users page?
If not, it seems like these components share significant component code with the existing components from src/features/Users/UserProfile -- can we find a way to abstract the components so we can avoid duplicating the code?
@aaleksee-akamai

Will the IAM user details page replace the exiting Account/Users page?
If not, it seems like these components share significant component code with the existing components from src/features/Users/UserProfile -- can we find a way to abstract the components so we can avoid duplicating the code?
@aaleksee-akamai

yes, it will
@hkhalil-akamai

@aaleksee-akamai Conflicts should be resolved and updated with latest before merging this branch.


Moved tkinter to try/except in mcdc/visualizer

@jpmorgan98 This isn't quite what you said you wanted to do in #214, but it maybe accomplishes the goals of that? Moving the tkinter module to the existing try/except module in mcdc/vis and adding a sys.exit() to the ImportError exception handling makes it so that any vis-dependency-related errors only print when trying to call mcdc.visualizer().
Making this a draft since I'm on a Mac that can't use the dependencies, I can only test the exception handling haha. If someone else could test that the visualizer itself still works, perhaps this small change is a good option?

I was planing on moving that whole visualizer to a sub-folder such that a user would have to import mcdc.visualizer. Kinda like scipy's integration library. That all these errors will show if a user specifically imports them