[RN 0.63.3] main.jsbundle does not exist.

when I tried to build a bundle app using Xcode I got the error down here, with react native version  [RN 0.63.2], so I searched for a solution and I saw that it had been solved in [RN 0.63.3], and then I upgraded react native to the latest version, but the issue still persists.
Environment:
System:
    OS: macOS 11.1
    CPU: (8) arm64 Apple M1
    Memory: 105.41 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 15.6.0 - /opt/homebrew/bin/node
    Yarn: 1.22.10 - /opt/homebrew/bin/yarn
    npm: 7.4.0 - /opt/homebrew/bin/npm
    Watchman: 4.9.0 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK:
      API Levels: 23, 29, 30
      Build Tools: 29.0.2, 30.0.3
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.87<IP_ADDRESS>42882
    Xcode: 12.3/12C33 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_275 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.3 => 0.63.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

When I tried to archive app in Xcode I got this error:

error: File /Users/sohaib/Library/Developer/Xcode/DerivedData/test-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle does not exist. This must be a bug with
+ echo 'React Native, please report it here: https://github.com/facebook/react-native/issues'

Some of the solution written in similar issues before is to create a main.jsbundle using this command:

react-native bundle --entry-file index.ios.js --platform ios --dev false --bundle-output ios/main.jsbundle --assets-dest ios

then to navigate to "Build Phases" tab and add it in "Copy bundle resources" section.
the app will work but without assets, and sometimes it is crashing.

and also one of the solutions is:
a. In Xcode, go to Build Phases -> Bundle React Native code and images
b. Change this part of the script ../node_modules/react-native/scripts/react-native-xcode.sh to ENTRY_FILE=index.ios.js ../node_modules/react-native/scripts/react-native-xcode.sh

it did not work with me, and I tried all the solutions posted on GitHub and Stackoverflow.
this is my bundle react native code and images:
export NODE_BINARY=node
export EXTRA_PACKAGER_ARGS="--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map"
export SENTRY_PROPERTIES=sentry.properties
../node_modules/@sentry/cli/bin/sentry-cli react-native xcode
../node_modules/react-native/scripts/react-native-xcode.sh

EDIT:
here is some debug code:
+ DEST=/Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app
+ [[ Release = *Debug* ]]
+ [[ -n '' ]]
+ case "$CONFIGURATION" in
+ DEV=false
+++ dirname /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/scripts/react-native-xcode.sh
++ cd /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/scripts/..
++ pwd
+ REACT_NATIVE_DIR=/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native
+ PROJECT_ROOT=/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/../..
+ cd /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/../..
+ '[' -z '' ']'
+ export NVM_DIR=/Users/sohaib/.nvm
+ NVM_DIR=/Users/sohaib/.nvm
+ [[ -n '' ]]
+ [[ -s index.ios.js ]]
+ ENTRY_FILE=index.js
+ [[ -s /Users/sohaib/.nvm/nvm.sh ]]
++ command -v brew
+ [[ -x '' ]]
+ [[ -x /Users/sohaib/.nodenv/bin/nodenv ]]
++ command -v brew
+ [[ -x '' ]]
+ [[ ! -x node ]]
+ [[ -d /Users/sohaib/.anyenv/bin ]]
+ source /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/scripts/node-binary.sh
++ '[' -z /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/@sentry/cli/sentry-cli ']'
++ type /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/@sentry/cli/sentry-cli
+ '[' -z '' ']'
+ export NODE_ARGS=
+ NODE_ARGS=
+ '[' -z '' ']'
+ export CLI_PATH=/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/cli.js
+ CLI_PATH=/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/cli.js
+ '[' -z '' ']'
+ BUNDLE_COMMAND=bundle
+ [[ -z '' ]]
+ CONFIG_ARG=
+ BUNDLE_FILE=/Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle
+ /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/@sentry/cli/sentry-cli /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/cli.js bundle --entry-file index.js --platform ios --dev false --reset-cache --bundle-output /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle --assets-dest /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app --sourcemap-output /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/IntermediateBuildFilesPath/Nadeera.build/Release-iphoneos/Nadeera.build/DerivedSources/main.jsbundle.map
warning: the transform cache was reset.
                 Welcome to React Native!
                Learn once, write anywhere

events.js:292
      throw er; // Unhandled 'error' event
      ^

Error: EMFILE: too many open files, watch
    at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:178:28)
Emitted 'error' event on NodeWatcher instance at:
    at NodeWatcher.checkedEmitError (/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/sane/src/node_watcher.js:143:12)
    at FSWatcher.emit (events.js:315:20)
    at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:184:12) {
  errno: -24,
  syscall: 'watch',
  code: 'EMFILE',
  filename: null
}
+ [[ false != true ]]
+ [[ ! -f /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle ]]
+ echo 'error: File /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle does not exist. This must be a bug with'
error: File /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle does not exist. This must be a bug with
+ echo 'React Native, please report it here: https://github.com/facebook/react-native/issues'
React Native, please report it here: https://github.com/facebook/react-native/issues
+ exit 2
+ DEST=/Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app
+ [[ Release = *Debug* ]]
+ [[ -n '' ]]
+ case "$CONFIGURATION" in
+ DEV=false
+++ dirname ../node_modules/react-native/scripts/react-native-xcode.sh
++ cd ../node_modules/react-native/scripts/..
++ pwd
+ REACT_NATIVE_DIR=/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native
+ PROJECT_ROOT=/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/../..
+ cd /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/../..
+ '[' -z '' ']'
+ export NVM_DIR=/Users/sohaib/.nvm
+ NVM_DIR=/Users/sohaib/.nvm
+ [[ -n '' ]]
+ [[ -s index.ios.js ]]
+ ENTRY_FILE=index.js
+ [[ -s /Users/sohaib/.nvm/nvm.sh ]]
++ command -v brew
+ [[ -x '' ]]
+ [[ -x /Users/sohaib/.nodenv/bin/nodenv ]]
++ command -v brew
+ [[ -x '' ]]
+ [[ ! -x node ]]
+ [[ -d /Users/sohaib/.anyenv/bin ]]
+ source /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/scripts/node-binary.sh
++ '[' -z node ']'
++ type node
+ '[' -z '' ']'
+ export NODE_ARGS=
+ NODE_ARGS=
+ '[' -z '' ']'
+ export CLI_PATH=/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/cli.js
+ CLI_PATH=/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/cli.js
+ '[' -z '' ']'
+ BUNDLE_COMMAND=bundle
+ [[ -z '' ]]
+ CONFIG_ARG=
+ BUNDLE_FILE=/Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle
+ node /Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/react-native/cli.js bundle --entry-file index.js --platform ios --dev false --reset-cache --bundle-output /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle --assets-dest /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app --sourcemap-output /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/IntermediateBuildFilesPath/Nadeera.build/Release-iphoneos/Nadeera.build/DerivedSources/main.jsbundle.map
warning: the transform cache was reset.
                 Welcome to React Native!
                Learn once, write anywhere

events.js:292
      throw er; // Unhandled 'error' event
      ^

Error: EMFILE: too many open files, watch
    at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:178:28)
Emitted 'error' event on NodeWatcher instance at:
    at NodeWatcher.checkedEmitError (/Users/sohaib/Nadeera/Nadeera-Users-App/node_modules/sane/src/node_watcher.js:143:12)
    at FSWatcher.emit (events.js:315:20)
    at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:184:12) {
  errno: -24,
  syscall: 'watch',
  code: 'EMFILE',
  filename: null
}
+ [[ false != true ]]
+ [[ ! -f /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle ]]
+ echo 'error: File /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle does not exist. This must be a bug with'
error: File /Users/sohaib/Library/Developer/Xcode/DerivedData/Nadeera-bvztmcrighttuoceblsiwoeawquk/Build/Intermediates.noindex/ArchiveIntermediates/Nadeera/BuildProductsPath/Release-iphoneos/Nadeera.app/main.jsbundle does not exist. This must be a bug with
+ echo 'React Native, please report it here: https://github.com/facebook/react-native/issues'
React Native, please report it here: https://github.com/facebook/react-native/issues
+ exit 2

Thank you. 🙏

I upgraded react native to [RN 0.63.4] and same error appears. 🙁

I upgraded react native to [RN 0.63.4] and same error appears. 🙁

I am so sorry, I found the error, it was with node, Xcode can't find node, so what I did was searching for node path: which node and then export it in the NODE_BINARY this way:
export NODE_BINARY=/opt/homebrew/bin/node

thanks🙏

I am so sorry, I found the error, it was with node, Xcode can't find node, so what I did was searching for node path: which node and then export it in the NODE_BINARY this way:
export NODE_BINARY=/opt/homebrew/bin/node

thanks🙏

How did you debug it?
@SohaibKtb

Same here... I can't build on physical device


docs(introduction): add GA plug-in.

Add GA plug-in for MCS Introduction document.

Deploy preview ready!
Built with commit 09f5db6162e1d89ceb7341a306955b3fe884f1bb
https://deploy-preview-313--mcs-lite-introduction.netlify.com

Deploy preview ready!
Built with commit 09f5db6162e1d89ceb7341a306955b3fe884f1bb
https://deploy-preview-313--mcs-lite-mobile-web.netlify.com

Deploy preview ready!
Built with commit 09f5db6162e1d89ceb7341a306955b3fe884f1bb
https://deploy-preview-313--mcs-lite-ui.netlify.com


[CPU][DT] ExpandVector hoists arith op outside of generic op

This issue leads to a compilation error when DT is enabled:
Repro:
iree-opt test.mlir --iree-global-opt-expand-vectors

func.func @main(%157 : tensor<256128xi1>, %49 : tensor<256128x1536xf32>) -> tensor<1536xf32> {
  %c0 = arith.constant 0.0 : f32
  %c22 = arith.constant dense<22.0> : tensor<1536xf32>
  %158 = tensor.empty() : tensor<256128xf32>
  %159 = linalg.generic {indexing_maps = [affine_map<(d0) -> (d0)>, affine_map<(d0) -> (d0)>], iterator_types = ["parallel"]} ins(%157 : tensor<256128xi1>) outs(%158 : tensor<256128xf32>) {
  ^bb0(%in: i1, %out: f32):
    %1923 = arith.uitofp %in : i1 to f32
    linalg.yield %1923 : f32
  } -> tensor<256128xf32>
  %160 = tensor.empty() : tensor<1536xf32>
  %161 = linalg.fill ins(%c0 : f32) outs(%160 : tensor<1536xf32>) -> tensor<1536xf32>
  %162 = linalg.vecmat ins(%159, %49 : tensor<256128xf32>, tensor<256128x1536xf32>) outs(%161 : tensor<1536xf32>) -> tensor<1536xf32>
  %163 = tensor.empty() : tensor<1x1x1536xf32>
  %164 = linalg.generic {indexing_maps = [affine_map<(d0) -> (d0)>, affine_map<(d0) -> (d0)>, affine_map<(d0) -> (d0)>], iterator_types = ["parallel"]} ins(%162, %c22 : tensor<1536xf32>, tensor<1536xf32>) outs(%160 : tensor<1536xf32>) {
  ^bb0(%in: f32, %in_794: f32, %out: f32):
    %1923 = arith.mulf %in, %in_794 : f32
    linalg.yield %1923 : f32
  } -> tensor<1536xf32>
  return %164 : tensor<1536xf32>
}

Output:
#map = affine_map<(d0) -> (d0)>
module {
  func.func @main(%arg0: tensor<256128xi1>, %arg1: tensor<256128x1536xf32>) -> tensor<1536xf32> {
    %cst = arith.constant 0.000000e+00 : f32
    %cst_0 = arith.constant dense<2.200000e+01> : tensor<1536xf32>
    %0 = tensor.empty() : tensor<1536xf32>
    %1 = linalg.fill ins(%cst : f32) outs(%0 : tensor<1536xf32>) -> tensor<1536xf32>
    %expanded = tensor.expand_shape %arg0 [[0, 1]] : tensor<256128xi1> into tensor<1x256128xi1>
    %2 = arith.uitofp %expanded : tensor<1x256128xi1> to tensor<1x256128xf32>
    %expanded_1 = tensor.expand_shape %1 [[0, 1]] : tensor<1536xf32> into tensor<1x1536xf32>
    %3 = linalg.matmul ins(%2, %arg1 : tensor<1x256128xf32>, tensor<256128x1536xf32>) outs(%expanded_1 : tensor<1x1536xf32>) -> tensor<1x1536xf32>
    %collapsed = tensor.collapse_shape %3 [[0, 1]] : tensor<1x1536xf32> into tensor<1536xf32>
    %4 = linalg.generic {indexing_maps = [#map, #map, #map], iterator_types = ["parallel"]} ins(%collapsed, %cst_0 : tensor<1536xf32>, tensor<1536xf32>) outs(%0 : tensor<1536xf32>) {
    ^bb0(%in: f32, %in_2: f32, %out: f32):
      %5 = arith.mulf %in, %in_2 : f32
      linalg.yield %5 : f32
    } -> tensor<1536xf32>
    return %4 : tensor<1536xf32>
  }
}

See how arith.uitofp is no longer within a generic op after running this pass, which is incorrect.

Looking into this, seems really odd... any idea if this IR was compiling on any version of ExpandVectors?

I'm at:
commit f66f28f61057008b0f7f0d9e0cea921b6e470803 (HEAD -> main, origin/main, origin/HEAD)
Author: Stella Laurenzo<EMAIL_ADDRESS>Date:   Thu Nov 9 20:06:32 2023 -0800

@KoolJBlack mentioned that it was compiling for him at (one day earlier):
commit bd603723299a81498327610ccc4444ced1db1662 (HEAD -> main, upstream/main)
Author: Max191<EMAIL_ADDRESS>Date:   Wed Nov 8 14:47:16 2023 -0500

It is added by @Max191 https://github.com/openxla/iree/pull/15372
Should be a simple fix, we have this pass to convert elementwise ops into linalg ops: https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Linalg/Transforms/ElementwiseToLinalg.cpp

Or we should just teach the pass to generate a generic op: https://github.com/openxla/iree/blob/2f9a1e173237b0948ef4f2bd3e03c85856d1be27/compiler/src/iree/compiler/GlobalOptimization/ExpandVectors.cpp#L109-L113

Or we should just teach the pass to generate a generic op:
https://github.com/openxla/iree/blob/2f9a1e173237b0948ef4f2bd3e03c85856d1be27/compiler/src/iree/compiler/GlobalOptimization/ExpandVectors.cpp#L109-L113

I think this is a better fix.

@NatashaKnk @Max191 could you coordinate on this issue?

Ok, so @Max191 is taking a look? Just have in mind that this ExtendVector might go away once @NatashaKnk extends the pad op to support 1D inputs and we can preserve linalg.vecmat/linalg.matvec until encoding materialization.

I think he is probably off for today. I will raise it to him on Monday. Is @NatashaKnk able to fix it?

Ah, I see what's happening. Yeah, I can pick it up

Ah, I see what's happening. Yeah, I can pick it up

Nice, thank you so much!

Sorry for the confusion here, but now that I'm looking at it a bit further, I might be missing the point of 15372. Isn't adding a generic op here undoing what it's trying to do to begin with?

Sorry for the confusion here, but now that I'm looking at it a bit further, I might be missing the point of 15372. Isn't adding a generic op here undoing what it's trying to do to begin with?

Sorry, I missed this thread until now. If you haven't already fixed this I can put out a quick patch tomorrow. Thank you for offering to pick it up though!
Creating the generic op here is actually ok, because the main point here is to separate out the casting of the operands from the matmul. I did this so that we could represent matmuls with unsigned inputs and eventually lower them to microkernels that take advantage of the signed times unsigned operands. Generic or not, as long as it is a separate op, this will work fine. In fact, setEncoding will eventually turn those ops into generics anyway. We should keep these casting ops as generics the whole way though so we don't get failing cases when it misses the setEncoding like this.
There are a couple places where I think I created the ordinary castOpInterface ops on tensors, so I can put out a patch to use generics everywhere instead if you haven't already done this.

Gotcha, that makes sense. If you think it's best to do it everywhere at once, please feel free to do it. Thanks!


Laravel-mix with WordPress issue with extract()

Laravel Mix Version: 6.0.13
Node Version (node -v): v15.11.0
NPM Version (npm -v): 7.6.0
OS: Debian GNU/Linux 10 (buster)

Description:
I'm trying to use laravel-mix with WP and when I try to use extract(), I see things getting bundling into (manifest/vendor/app).js but when I include the script in my page, nothing gets executed.
The js/app.js file looks like this:
(self["webpackChunk_theme"] = self["webpackChunk_theme"] || []).push([["/js/app"],{
...
]);

so I guess it makes sense that nothing happens, but I'm wondering what I'm supposed to add to get the scripts to run.
Thank you for any insight.

This is not specific to WP. Also finding that in non-laravel environments, using extract() causes no JS to be executed at all when landing on the page.

There were some issues in old webpack versions. Can you try upgrading your dependencies and seeing if that fixes it? A good number of our tests don't run in a laravel-like environment so that's unlikely to be an issue.

that was it. Not sure which dependency was causing it, but that fixed it. At least it's Friday....

I don't think I have any dependency to update in my case.

Oh I spoke too soon. It is working for me too now. The output file looked the same, so I didn't think something had changed.


Canary: add the appLicensing capability

This should allow the package to be installed without AppXSvc consulting the store or the licensing service.
It's free and open-source. It shouldn't need a license to run.

For future self:

Capability scenario
Capability usage

App Licensing
The appLicensing restricted capability allows apps to run without the need of a license. You cannot submit your app to the store if you declare this capability in your manifest.We don't recommend that you declare this capability in applications that you submit to the Microsoft Store. In most cases, the use of this capability won't be approved.

This is a good question that I'm not sure we have an answer too 😆 We're not immediately planning on publishing the Canary builds to the Store though. This just lets someone actually grab the .msix of the Canary build out of the Release pipeline and install it, without having to run it unpackaged.
There may be more similar PRs as we learn more in this space 😄


specs: Update output root derivation

Updates the specs to match the current implementation of the output root, ie.
keccak256(version, stateRoot, withdrawerStorageRoot, latestBlockhash)

Codecov Report

Merging #357 (08e3c49) into main (de4182d) will decrease coverage by 0.05%.
 Consider uploading reports for the commit 8417605 to get more accurate results

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   55.72%   55.67%   -0.06%
==========================================
  Files          46       46
  Lines        3781     3781
==========================================
- Hits         2107     2105       -2
- Misses       1425     1427       +2
  Partials      249      249

Impacted Files
Coverage Δ

opnode/l1/receipts.go
30.50% <0.00%> (-3.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4182d...8417605. Read the comment docs.

This needs a rebase and then the CI should work


The 'tree' component can not set the 'default-checked-keys' data

this is my Demo,please:
https://jsfiddle.net/6cnufu8z/7/

tred to set the 'defKeys',but not useful


Run CI on fewer Julia versions

Fixes #28

Codecov Report

Merging #30 (d035c3c) into master (6d7c74c) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   79.51%   79.66%   +0.14%
==========================================
  Files           2        2
  Lines         371      295      -76
==========================================
- Hits          295      235      -60
+ Misses         76       60      -16

Impacted Files
Coverage Δ

src/forwarddiff.jl
94.44% <0.00%> (-0.56%)
:arrow_down:

src/AbstractDifferentiation.jl
78.70% <0.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7c74c...d035c3c. Read the comment docs.


19-Remove-Nth-Node-From-End-of-List Java Solution

Your pull request will get reviewed. Thank you for being patient.

Looks good, thanks!


Firefox runner sometimes doesn't run

first report through Discord https://discord.com/channels/1253608412890271755/1253621269308506204/1319043711233163327
not able to reproduce locally


Redundant TerminationDirection of ServiceInterfacePoint

There is a direction attribute in the SIP with TerminationDirection datatype. There is also a terminationDirection attribute in the LayerProtocol of SIP. I think the Direction attribute of SIP is redundant. What if the TerminationDirections are different in different LayerProtocols in a SIP, how can we define the direction attribute in this SIP?

Agree. This is also applicable to the NodeEdgePoint and ConnectionEndPoint classes.

TAPI Call 6/6/2017:  Agreed


documenting spectral weights

Link to this branch's docs with my changes.
This should close #54. Notably missing in this PR is the description of the configuration for grids, but that is because #48 seems to be a catch-all for configuration. I will certainly add the configuration information if it is desired here, but I thought this was specifically for the code documentation.

Codecov Report

Merging #122 (96a5db4) into main (d65d71f) will increase coverage by 1.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   81.16%   82.75%   +1.58%
==========================================
  Files         100      100
  Lines        5140     5567     +427
==========================================
+ Hits         4172     4607     +435
+ Misses        968      960       -8

Impacted Files
Coverage Δ

src/spectral_weight.F90
83.72% <ø> (ø)

src/spectral_weight_factory.F90
100.00% <ø> (ø)

src/spectral_weights/UV_Index.F90
100.00% <ø> (ø)

src/spectral_weights/eppley.F90
100.00% <ø> (ø)

src/spectral_weights/exp_decay.F90
100.00% <ø> (ø)

src/spectral_weights/gaussian_filter.F90
100.00% <ø> (ø)

src/spectral_weights/notch_filter.F90
100.00% <ø> (ø)

src/spectral_weights/par.F90
100.00% <ø> (ø)

src/spectral_weights/phytoplankton_boucher.F90
100.00% <ø> (ø)

src/spectral_weights/plant_damage.F90
100.00% <ø> (ø)

... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[CCXDEV-14098] Update io-utils in order to reduce the glitchtip events

Description
Update io-utils in order to reduce the glitchtip events
Type of change

Bump-up dependent library (no changes in the code)

Testing steps
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

/retest


ionicView.leave and ionicView.enter events fire wrongly

Short description of the problem:
I have these two events in my controller and they both fire wrongly. my ionicView.leave event fires when i enter the controller and my ionicView.enter event fires upon leaving the controller. Its so weird. Why is this happening? Also, it only gets called when it is $rootScope and not $scope
What behavior are you expecting?
I am expecting both events to fire correctly.
Steps to reproduce:

Go to ur controller, add an ionicView.leave and ionicView.enter event
Create a function to enter and leave the controller wt the view
Try with $scope and $rootScope

$rootScope.$on('$ionicView.leave', function() {
    console.log('on the way leaving')
  })

$rootScope.$on('$ionicView.beforeEnter', function() {
    console.log('on the way entering')
  })

Hello, thanks for opening an issue with us! Would you be able to provide a plunker that demonstrates this issue? Thanks for using Ionic!

Hello! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!


3rd party idp Oauth support

All of the Oauth appears to be around Service Now being the idp correct? It looks to me like there is no support for a 3rd party like Azure Active Directory to act as the token provider. I have this setup in our SNOW instance, but if I can avoid writing a bunch of code you've already done I'm all for being lazy.
Just trying to make sure I've got it right before I start digging on how to get it to work with ours.

Nah, happens to all of us :)


Update volumes doc to fix broken link and describe new file.

Fixes #7810

+cc @jsafrane @thoraxe

TY!

NP! I'm a bit concerned about keeping the doc up-to-date with the file a few directories over, but we'll see what Eric has to say. Might just move this description to the examples directory entirely. Thanks for reporting this!

Looks good to me, thanks!

@mbforbes
I'd suggest inlining the example rather than linking it.  This will be more helpful to readers.
If there is a concern is about inlined examples getting stale, then someone could do either of the following things:

generate final docs by merging the example and a template doc.  Allows examples to remain in examples dir.
generate examples by extracting them from a doc with inlined examples.  examples would be bracketed by something like # BEGIN API EXAMPLE and # END.

@nikhiljindal I think has been working on doc automation.  He may have ideas.

I merged this since it is an improvement.


DRILL-4970: Prevent changing the negative value of input holder for cast functions

Problem description in DRILL-4970

Not entirely thrilled with focusing on one bug without cleaning up the entire area, but that is another discussion.
+1


Feature Request: Window transparency

Would it make sense to support setting the window transparency (and blur) via CSS?

With Electron, transparency is possible on the BrowserWindow (window) in conjunction with CSS. Blur is only possible with CSS, but it won't blur because there is no layer behind document.
In other words, blur needs to be implemented in Electron in order for blur to work. Transparency is possible already though.

@mainee Did you look at electron vibrancy? https://github.com/arkenthera/electron-vibrancy . You can fork and rebuild with transparency and blur.


ERROR: django-admin2 0.7.1 has requirement django-filter==1.0.0, but you'll have django-filter 2.3.0 which is incompatible.

can you update django-filter dependency?

@nab5m this works is inside #473

Thank you :)

i think should be fixed in master

@auvipy this isn't on master.
This commit is only available in develop branch.

ops


Improve README with Build/Setup Instructions

The README should clearly explain how to setup the environment in both possible scenarios:

Using the hardware board
Emulating the board.

Partially solved by #35

@pcppcp Do you think that adding instructions for how to run the wallet with a hardware board would be nice? Or it is too much hardware/OS dependent to be put in the readme?


Reformat for installation via pip

Entails adding a setup.py and moving the config and plugin folder (#143), but shouldn't be terribly much work. (keyword: shouldn't)

Finished as of d32ce1e.


Data corrections for Points of Interest in South America

Task description:
The Microsoft Open Maps editorial team is looking to improve or correct the map data for various points of interest in South America.  We will also use all available aerial and street level imagery assets available in OSM. We intend to edit the roads, buildings, and land uses in close proximity to some POI's in South America. Some examples of the entities we will be focusing on:
*Airports
*Hospitals
*Universities
*Stadiums
Additionally, we may edit some other map features such as water bodies, natural features, and landuse features.
We will be processing this according to OSM local guidelines, and adhering to the Organized editing guidelines.
Mapping Guidelines:
We will be updating road, landuse, and building geometry and conflicting tags where found. We will look at the most recent aerial and streetlevel imagery to enhance current features, and reach out to the local community where necessary. The team will follow OSM guidelines for any editing which takes place.
Area of Focus:
This will be across the South American continent.
Data Sources:
All available imagery and street level sources in JOSM will be used to verify edits.
Changeset Comments:
The team will be adding changeset comments that follow OSM changeset guidelines and adding #MSFTOpenMaps to the changeset description.
Error Detection:
We will use the validator in the JOSM tool to look for errors, following the wiki as well as the LearnOSM guidelines.
Additional Info:
For any questions, comments, concerns, feel free to email the team at openmaps(at)microsoft.com or use the changeset comments section.

Hi mfrasca,
Thanks for the suggestion. We will also include a description in the changeset comments describing fixes being made, for example, "Adding missing roads and road attributes near universities #MSFTOpenMaps"


update #82: respondent data dto contains a username

The pr request refers to: https://dev.azure.com/survey-project/Survey/_boards/board/t/Survey Team/Issues/?workitem=82
It adds username in a response of '/api/respondents/all' endpoint. This is because we want to display it in the admin panel.

I merge with my own review because of the dealine


Container is now considered dirty if not attached.

Container is now considered "dirty" if it is NOT attached. Generally , "dirty" may not be the best way to describe this state, rather saved (vs not saved) would have probably been more appropriate. The logic does not take into account any DataStoreRuntime ops (like creating channels etc.) So, as long as the Container is not attached, the flag will always be "dirty".
With this PR there are no changes to container interfaces, but one small improvement could be to expose isDirty flag on the Container Runtime and let Container just proxy the state up. Something similar to what Fluid Container does with Container object in regards to this same flag. In other words, make it explicit the ownership of this flag is with the runtime, and skip the state duplication.

The logic does not take into account any DataStoreRuntime ops (like creating channels etc.) So, as long as the Container is not attached, the flag will always be "dirty".

There are no ops if container is detached. There could be ops if container is attaching or attached.

@ssimic2 The docs wording looks OK, but I am going to wait to do another pass once you've figured out some of the nuances with Wes, in case some of those details need to be included in the docs.

this doesn't exist today, but i could see a detached container being dirty vs saved, as we allow serialization of the detached container, so a user may want to know if there are changes since the last time it serialized. given this, we may not want to couple attach state and dirty/saved
i'd like to see an issue here with some level of design discussion

this doesn't exist today, but i could see a detached container being dirty vs saved, as we allow serialization of the detached container, so a user may want to know if there are changes since the last time it serialized. given this, we may not want to couple attach state and dirty/saved

It's less about detached state (as we build serialization and rehydration for both attached & detached states to preserve user data). You are right, that host may want to know if anything changed since last serialization.
As of now, hosts do not need this capability. I.e., no host wants to periodically save document state and know if it needs to update their save. They all want to save document state only on user moving away. So, I propose we do not add yet that complication, and clearly document what dirty means in current system.

this doesn't exist today, but i could see a detached container being dirty vs saved, as we allow serialization of the detached container, so a user may want to know if there are changes since the last time it serialized. given this, we may not want to couple attach state and dirty/saved
i'd like to see an issue here with some level of design discussion

Hey @anthony-murphy I'd love to hear more about these use cases, and if anyone has needed /requested them. It's OK if its not pressing need, I'm curious how some of these use cases do evolve over time. Is it us offering "you can also do this" or its something that's coming through partners.
Some general thoughts on APIs that are surfaced to end users (as this one in) ... We should be very cognizant of the mental model that we form. In other words, we should be able to reason about API fairly quickly, without (whenever possible) needing to link into further concepts/APIs, or/and explain contextual terminology. In my head, when I onboarded, isDirty being false meant the doc is live (aka attached) and saved (no pending ops). All concrete/known concepts, and no further explanations were needed to reason about what isDirty meant. Name could have been better (maybe saved), but I understood intention. Of course over time you learn about other concepts (like readonly vs rw containers), but as long as these concepts map to state/ops (the terminology which we used to explain isDirty) then we don't need them in the context of our flag explanation. For all API changes that may introduce additional reasoning/concepts behind meaning of isDirty we should have a high bar and let those come in only when there is a highly significant value. And again this is general thought, the serialize use case may or may not land into this bucket.
I'll check with Wes on load nuances to see if we can handle transient state more gracefully here.

this doesn't exist today, but i could see a detached container being dirty vs saved, as we allow serialization of the detached container, so a user may want to know if there are changes since the last time it serialized. given this, we may not want to couple attach state and dirty/saved
i'd like to see an issue here with some level of design discussion

Hey @anthony-murphy I'd love to hear more about these use cases, and if anyone has needed /requested them. It's OK if its not pressing need, I'm curious how some of these use cases do evolve over time. Is it us offering "you can also do this" or its something that's coming through partners.
Some general thoughts on APIs that are surfaced to end users (as this one in) ... We should be very cognizant of the mental model that we form. In other words, we should be able to reason about API fairly quickly, without (whenever possible) needing to link into further concepts/APIs, or/and explain contextual terminology. In my head, when I onboarded, isDirty being false meant the doc is live (aka attached) and saved (no pending ops). All concrete/known concepts, and no further explanations were needed to reason about what isDirty meant. Name could have been better (maybe saved), but I understood intention. Of course over time you learn about other concepts (like readonly vs rw containers), but as long as these concepts map to state/ops (the terminology which we used to explain isDirty) then we don't need them in the context of our flag explanation. For all API changes that may introduce additional reasoning/concepts behind meaning of isDirty we should have a high bar and let those come in only when there is a highly significant value. And again this is general thought, the serialize use case may or may not land into this bucket.
I'll check with Wes on load nuances to see if we can handle transient state more gracefully here.

This all sounds right to  me. I wonder if we should just introduce the concept of saved which is what you allude to here, and leave dirty as is. I've seen a few people get tripped up by the word dirty, so moving to a better concept would be worth it. We could even consider deprecating dirty if we don't think its valuable as an independent concept

this doesn't exist today, but i could see a detached container being dirty vs saved, as we allow serialization of the detached container, so a user may want to know if there are changes since the last time it serialized. given this, we may not want to couple attach state and dirty/saved
i'd like to see an issue here with some level of design discussion

Hey @anthony-murphy I'd love to hear more about these use cases, and if anyone has needed /requested them. It's OK if its not pressing need, I'm curious how some of these use cases do evolve over time. Is it us offering "you can also do this" or its something that's coming through partners.
Some general thoughts on APIs that are surfaced to end users (as this one in) ... We should be very cognizant of the mental model that we form. In other words, we should be able to reason about API fairly quickly, without (whenever possible) needing to link into further concepts/APIs, or/and explain contextual terminology. In my head, when I onboarded, isDirty being false meant the doc is live (aka attached) and saved (no pending ops). All concrete/known concepts, and no further explanations were needed to reason about what isDirty meant. Name could have been better (maybe saved), but I understood intention. Of course over time you learn about other concepts (like readonly vs rw containers), but as long as these concepts map to state/ops (the terminology which we used to explain isDirty) then we don't need them in the context of our flag explanation. For all API changes that may introduce additional reasoning/concepts behind meaning of isDirty we should have a high bar and let those come in only when there is a highly significant value. And again this is general thought, the serialize use case may or may not land into this bucket.
I'll check with Wes on load nuances to see if we can handle transient state more gracefully here.

This all sounds right to me. I wonder if we should just introduce the concept of unsaved which is what you allude to here, and leave dirty as is. I've seen a few people get tripped up by the word dirty, so moving to a better concept would be worth it. We could even consider deprecating dirty if we don't think its valuable as an independent concept

Yes, @ChumpChief called it something very similar. So maybe isUnsaved as a flag. @vladsud @tylerbutler your thoughts? I would not have two different behaviors though. It would add unnecessary confusion. I'd say we move this current change in, and if we decide to rename the flag, let's handle that through another ticket that will just deal with deprecation/alternative API, essentially renaming identical behavior.

I think whatever name we chose; it will have roughly same outcome - someone will assume different behavior.
That said, "synchronized" seems like a better term if we really want to point to a fact that it's about state in the cloud (though synchronized assumes bi-directional communication, whereas here we only assess one way.
Apps use "saving" & "saved" in UX for same thing ("saving" might be deceiving in offline as it assumes active process, but that's what we use)

I think whatever name we chose; it will have roughly same outcome - someone will assume different behavior. That said, "synchronized" seems like a better term if we really want to point to a fact that it's about state in the cloud (though synchronized assumes bi-directional communication, whereas here we only assess one way. Apps use "saving" & "saved" in UX for same thing ("saving" might be deceiving in offline as it assumes active process, but that's what we use)

All good points @vladsud. I would say, lets wrap up the requested changes this PR is targeting and take this as a separate point then. All earlier comments are resolved, so please give it another look when you get a chance.

@ssimic2 The docs wording looks OK, but I am going to wait to do another pass once you've figured out some of the nuances with Wes, in case some of those details need to be included in the docs.

@tylerbutler this PR is a bit old, but it should be ready to merge after the build goes through. Please give it another pass, and let me know if you have any further thoughts. I'd love to hear your take on the naming conversation we had with @anthony-murphy and @vladsud above. I'll open another ticket that will focus on renaming (of existing behavior) only.

@ssimic2 The docs wording looks OK, but I am going to wait to do another pass once you've figured out some of the nuances with Wes, in case some of those details need to be included in the docs.

@tylerbutler this PR is a bit old, but it should be ready to merge after the build goes through. Please give it another pass, and let me know if you have any further thoughts. I'd love to hear your take on the naming conversation we had with @anthony-murphy and @vladsud above. I'll open another ticket that will focus on renaming (of existing behavior) only.

https://github.com/microsoft/FluidFramework/issues/8960

A note should be added to the BREAKING.md file as this is change in behavior.


Refactory/check permissions

Related to: https://github.com/shellhub-io/shellhub/issues/1203

@all-contributors please add @henrybarreto as code


set an access code to the room

I saw in the project there is a feature for access code and join by access.
But how can I use this feature?
Thanks

Access codes were an implementation so when you loose connection momentarily you do not lock yourself out of the room.
This functionality has been reworked since we have a management service.
If you configure the management service. You can login with a user that has permission for a specific room and set default permissions.
I have made more documentation on the edumeet-docker repo.


Performance issue with IFormFile

opened by @prashanthi-ediga here: https://github.com/dotnet/core/issues/1031
Issue Title
Reading the stream from http posted file using IFormFile is very slow.
General
We have implemented an ASP.Net application to read very large Excel Files(100 MB).
Our requirements was to not save the file to any temp location or save file at server.
So, we have implemented an API which reads stream data using 'HttpPostedFileBase' and send this stream to openXMLReader. The performance is very good and we were able to achieve good results with 100 MB file for 1000 concurrent users in a ramp up period of 5 minutes.
Recently,we had to move to .net core in which 'HttpPostedFileBase' was not supported.
So I am using IFormFile to read stream data and pass it to excelReader.
But the performance degraded to a great extent.As the number of concurrent users increase the performance is degrading rapidly.
I have seen few blogs stating to use 'MultipartReader' for large files.But this is storing the stream to a temporary path which is not possible in our scenario.
Code Sample:
[HttpPost]
public string ReadExcel_OpenXML(IFormFile postedFile)
{
var inputStream = postedFile.OpenReadStream();
....
}
Can you please suggest any alternative or fix to this.
Please let me know if you need any other details.
Thanks,
Prashanthi.

@prashanthi-ediga, MultipartReader does not store data in a temp file by default. You control where the content goes, see this sample:
https://github.com/aspnet/Entropy/blob/1a4d2e0607c374b8c2aa2403029d9cb4ad33db20/samples/Mvc.FileUpload/Controllers/FileController.cs#L57

Hi @Tratcher,
I need to get the data directly as a stream. In the example that you have mentioned the stream is stored at :
targetFilePath = Path.Combine(_hostingEnvironment.ContentRootPath, Guid.NewGuid().ToString());
Can you please provide an example or guide me to directly get the data as stream instead of storing it to temp file.
Thanks,
Prashanthi.

fileSection.FileSteam is the name of the raw file upload stream in that sample. Pass that to your Xml reader.


Clerk get broken when clearing cookies manually.

[x] @clerk/nextjs

Dependencies + versions
Provide a json with the dependencies used in your project (copy paste from yarn.lock / package-lock.json) or a github project / template that reproduces the issue.
Include the @clerk/ packages and their versions!*
Example:
{
  "dependencies": {
    "next": "13.4.3",
     "@clerk/nextjs": "^4.18.2",
  },

}

Description
I have followed the docs to setup Clerk.
// middleware.ts
import { authMiddleware } from "@clerk/nextjs";

export default authMiddleware();

export const config = {
    matcher: ["/((?!.*\\..*|_next).*)", "/", "/(api|trpc)(.*)"],
};

// layout.tsx
export default function RootLayout({ children }: { children: React.ReactNode }) {
    return (
        <ClerkProvider>
            <html lang="en" suppressHydrationWarning>
                <head />
                <body
                    className= "min-h-screen bg-background font-sans antialiased"
                >
                    {children}
                </body>
            </html>
        </ClerkProvider>
    );
}

when running the app on locahost it redirects me to login. which is correct. but
when I clear the cookies by my self (open inspector and remove all cookies and clean local storage), Clerk starts to behave like it is broken. unlimited redirect from my localhost to clerk and vice versa.

and I'm getting this error message in my console
🔒 Clerk:
The <SignUp/> and <SignIn/> components cannot render when a user is already signed in, unless the application allows multiple sessions. Since a user is signed in and this application only allows a single session, Clerk is redirecting to the Home URL instead.
(This notice only appears in development)

Hello @bacharSalleh! Thank you for opening this issue. This is indeed a bug that will be solved when #1241 is merged to production!


vMerge 2.0.10: Cannot load Merge window / vMerge Options

Hello,
I use vMerge frequently to merge TFCS changesets. Every now and then, I experience an issue where, after selecting desired changesets in the Changesets View and clicking "Perform Merge" I get a progress bar and when it reaches 100%, nothing happens.. (the actual Merge window is not displayed). When this happens, this is accompanied with another issue as below:

Versions:
vMerge 2.0.10
IDE: Visual Studio Professional 2022, Version 17.1.5
OS: Windows 10 Version 21H2 (OS Build 19044.1645)
See attached log file.
vMerge, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=133d2d8b3063fdce.log
P.S. Thank you for solving the previous issue. Works like a charm!

you can try the new version on the market.


do not auto-set json content-type

Just like Accept, if Content-Type is set, do not change it.
This allows using a custom content-type such as application/vnd.api+json, which is required by the JSON-API specification, with a JSON payload.

:+1:

I initially assumed if you wanted a specific content type you'd just set the header and JSON.stringify to body instead of json, but I see why this is important.

Thanks @naugtur!


chore: rename to horaedb

This refers to https://github.com/CeresDB/horaedb/issues/1319.

@jiacai2050 I think it's mergable now. Or we should wait for someone's extra review?

Copyright 2022？

Sure. Let me change it.


Remove default AppContext and cleanup globals

This is an updated version of a closed pull request. This change keeps the context in the zone but removes the implicit global context.

[x] Remove the implicit global _defaultContext. This caught a bunch of places that we were assuming a context exists (and modifying it). We now require an AppContext to be constructed and the application code to call the runInZone method.

[x] Move some global variables from globals.dart into their own files.

@devoncarew

lgtm


Allow slice to be passed to Struct or create Array/Slice function

Hi,
It would be nice if Struct can populate slice/array without wrapping it into a struct. Example below:
package main

import (
  "testing"

  "github.com/brianvoe/gofakeit/v6"
)

type person struct {
  Name string `fake:"{name}"`
}

func TestPassSlice(t *testing.T) {
  persons := make([]person, 10)
  gofakeit.Struct(&persons)

  if persons[0].Name == "" {
    t.Errorf("slice not populated")
  }

  gofakeit.Struct(&struct {
    Persons []person
  }{persons})
  if persons[0].Name == "" {
    t.Errorf("struct not populated")
  }
}

$ go test
--- FAIL: TestPassSlice (0.00s)
    gofakeit_test.go:18: slice not populated
FAIL
exit status 1

I agree with this. I should have all the functions i need in order to make this happen. Let me take a crack at it.

Ok pushed. v6.2.0 I added a function called Slice.
Example usage:
var S []string
Slice(&S)

I := make([]int8, 3)
Slice(&I)

type Basic struct {
  S string `fake:"{firstname}"`
  I int
  F float32
}

var B []Basic
Slice(&B)

Let me know if that works for you.

Plus i better see you in the github stars list! 😄

@brianvoe

Let me know if that works for you.

It works, thanks 🥰

Plus i better see you in the github stars list! 😄

Oh no, I don't know how it happened. Let me fix that unforgivable mistake. Done 😃

Ok good I almost had to call the cops on you for not staring it.


Move implementations to separate folder(namespace?)

Currently implementation namespaces clutter up the root and sit next to unrelated systems like shader management.
This mostly applies to the Primitives namespaces, and possible the PostProcessing one.
Alternatively, these could be more distinguished from implementation by adding more relevant features.

Done on v2.


Dashboard page should remember sort order

as a user
when i sort my dashboard page and then navigate away
then the next time i visit that page, i expect the order to be the same as before.
let's store in user's local data.

connect #15544

this would be so nice!

First pass at this will just do it in redux and will not persist it into local storage.


fix: dont continue to next screen on failure

Description
Was not correctly returning early if there was as error.
This was noticed for and fixes the case of sellAmount < minimumSellAmount
Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Risk
almost no risk
Testing
Enter a low amount (below $1) and see that it doesnt let you continue with the trade
Screenshots (if applicable)
BEFORE:

AFTER:

Actually, that prod bug might be unrelated:

Actually, that prod bug might be unrelated:

I believe this PR fixes those errors as well. Ive seen it white screen like you did with different assets selected and this fixed it for me


PNK staked, ETH Paid to jurors, PNK redistributed at pages/Home/CourtOverview/Stats.tsx

https://github.com/kleros/kleros-v2/blob/master/web/src/pages/Home/CourtOverview/Stats.tsx #625

so in this issue, replace the hardcoded value with the real-time fetch USD values, am I right?


Feature detection code does not compile with 2.0.2

TypeScript Version:  2.0.2
Code
function selectText( elem:HTMLInputElement, start:number, end:number )
{
    if( elem.createTextRange )
    {
        var selRange = elem.createTextRange();
        selRange.collapse( true );
        selRange.moveStart( "character", start );
        selRange.moveEnd( "character", end );
        selRange.select();
    }
    else if( elem.setSelectionRange )
    {
        elem.setSelectionRange( start, end );
    }
    else if( elem.selectionStart )
    {
        elem.selectionStart = start;
        elem.selectionEnd = end;
    }
    elem.focus();
}

Expected behavior:
The function checks by presence of Function or Property on the HTMLInputElement what
code to apply to select the text in the input field and should compile fine because I think
that is a common way to do feature detection.
Actual behavior:
It produces the following error:
TS2339: Property 'createTextRange' does not exist on type 'HTMLInputElement'.
Of course HTMLInputElement declares createTextRange as a Function createTextRange(): TextRange; but that should not stop me from treating the Function as a Property.

Of course HTMLInputElement declares createTextRange as a Function createTextRange(): TextRange; but that should not stop me from treating the Function as a Property.

the issue here is that in lib.d.ts HTMLInputElement does not declare a property createTextRange. I could not find a reference for it on MDN either.
You can augment the interface declaration for HTMLInputElement to define createTextRange as such:
interface HTMLInputElement {
    createTextRange?(): Range;
}

function selectText(elem: HTMLInputElement, start: number, end: number) {
    if (elem.createTextRange) {
        var selRange: Range = elem.createTextRange();
        selRange.collapse(true);

   }
}

(createTextRange is a non-standard IE-only property on some element types.)


Stop using knative.dev/serving in cmd/ and pkg/

This should leave conformance testing as the only knative.dev/serving dependency left. I will follow up with another PR.

LG, but tests look unhappy

/lgtm


xwing: fix mlkem768 keys

Hi,
since some changes were made in the mlkem768 package, I tried to fix the xwing package. I hope this is helpful for you.

@FiloSottile are there any plans to merge this in? I see there's been some activity in crypto/internal for the port of this package, so I'm not sure if this project should by considered abandoned or not at this point.

Now that ML-KEM is standardized, this would be even more useful.

Implemented draft-connolly-cfrg-xwing-kem-04 and matched the latest mlkem768 cached API.
/cc @dconnolly @bwesterb


Update setup-nginx-proxy-with-minio.md

Fix typo in nginx config file path:
/etc/nginx/sites-enables/minio instead of enabled.

Thanks - we generally need to clear up this file, as it was migrated as-is w/o further review.
If you notice anything else, please let us know.

Thank you, will do!


Deprecate python infra servers

After the Go versions fully replace the Python versions, we should deprecate them and remove the code from the repo.

As soon as this is closed, https://github.com/scionproto/scion/issues/1549 can also be closed.


add a few hostlists

None of the hostlists I could find seemed to cover my region properly, so I created one.

Thanks Brian! @brianclemens.
This is a perfect Pull Request.  Perfect in every way.  I love it.  Brian "gets" it.
Here's what I've decided to do.
Brian, normally I would not accept this PR because we have this rule that our sources must be well curated, which means there needs to be a notable history of list maintenance and updates.
I'm making an exception here because,

this PR is perfect,
the data covers Asia, an area we need to expand,
it includes extensions, which we can do better at growing and maintaining.

That said I'm merging this PR but I want you to understand, our rule about curation still holds.   I'd like to see this contribution move forward with updates, several times per year.  In other words, be active and update your repo, whenever you can.
Good?
Presuming we understand each other, merging.  This will show in the next release, coming later today (probably).

Understood.  I have been using these blocklists on my own routers here for a while now, so maintaining the repo and keeping responsive to issues shouldn't be an issue.  Thanks for merging!


Fix export_test.py extra_symbols issue.

Apparently the export() function takes an extra_symbols parameter that wasn't being passed, causing runtime errors. This fixes it.

Can you sign http://developer.mbed.org/contributor_agreement/ ,please?

@Timmmm

Have done. Same username.

Thanks !


address a11y and seo issues

There were a couple low hanging fruit updates to fix some accessibility and seo issues:

add meta description tag
add meta viewport tag
add lang attribute to html element
add favicon

scores for current site:

scores with this commit:

ignore the best practice degradation...that's due to running on localhost.


resolve merge conflicts in git-auto-export repositories

We're seeing occasional errors that indicate a merge conflict:
https://sentry.io/organizations/mit-office-of-digital-learning/issues/2812912811/events/e02444636044473f9d885923fea58cc7/?project=1757731
If a course author is doing multiple changes and publishes in a short period of time, it's possible for these changes to be executed on different nodes in the cluster. Each node will have it's own working directory, which can get out of sync with the upstream repository.

This is still happening: https://mit-office-of-digital-learning.sentry.io/issues/2812912811/?project=1757731
It threatens our ability to rely on the git auto exports as an archive of course changes. However, if hasn't affected anyone's actual work at this time.


[Explore] Ensure links don’t need to perform an extra HEAD request.

We should define routes for those vanity URLs and just immediately route to the right location.

@ashfurrow We do this nowadays, right?

(Re-open if we don’t)

We don't - there are too many now, it's literally any Profile ( which can effectively be attached to so many model objects )

This is only for the ARMutableLinkViewController - https://github.com/artsy/eigen/blob/master/Artsy/View_Controllers/ARMutableLinkViewController.m

Isn’t that good enough?

IMO Yes - just wanted to make sure everyone is on the same page


repeat on AnimationControlle does not calculate initial value correctly

Steps to reproduce
Example 1: Create an AnimationController like this:
controller = AnimationController(
        duration: const Duration(seconds: 2),
        vsync: this,
        lowerBound: 100,
        upperBound: 300);
controller.repeat();

Example 2: Create an AnimationController like this:
controller = AnimationController(
        duration: const Duration(seconds: 2),
        vsync: this,
        lowerBound: -100,
        upperBound: 200);
controller.repeat();

Expected results
The first animation starts with the value 100 and the second starts with the value -100.
Actual results
In the first example the animation starts with the value 200 and in the second example Flutter throws the following exception:
Assertion failed: file:///opt/flutter/packages/flutter/lib/src/animation/animation_controller.dart:889:12 _initialT >= 0.0 is not true

Code sample
Here is a DartPad that shows both issues: https://dartpad.dev/?id=79b890fd2a994d6e3f5ac210f433e7d5
Flutter Doctor output
Tested on the latest release and the latest main.

Thanks for the report and potential fix. Seeing the same behavior as reported.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.16.8, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.16.8 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 67457e669f (2 days ago), 2024-01-16 16:22:29 -0800
    • Engine revision 6e2ea58a5c
    • Dart version 3.2.5
    • DevTools version 2.28.5
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.19.0-15.0.pre.36, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.19.0-15.0.pre.36 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 31116770ed (2 hours ago), 2024-01-31 19:23:05 -0800
    • Engine revision f4fbabf1eb
    • Dart version 3.4.0 (build 3.4.0-97.0.dev)
    • DevTools version 2.31.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


(#122) Fix Remove-Item Call in Jenkins Script

Description Of Changes
Fix Remove-Item call in Jenkins script to work correctly
Motivation and Context
Command wasn't working as expected
Testing
Spun up QSG instance, tested on VM and confirmed changes work as intended.
Change Types Made

[ ] Bug fix (non-breaking change)
[ ] Feature / Enhancement (non-breaking change)
[X] Breaking change (fix or feature that could cause existing functionality to change)
[X] PowerShell code changes.

Related Issue
Fixes #122
Change Checklist

[ ] Requires a change to the documentation
[ ] Documentation has been updated
[ ] Tests to cover my changes, have been added
[ ] All new and existing tests passed.
[ ] PowerShell v2 compatibility checked.

We should consider bringing this back over to C4BAE


chore: add newrelic gem to gemfile

Changes

add new_relic gem to gemfile
configure newrelic.yml file

Type of Changes

[x] new feature
[x] setup
[ ] chore
[ ] bug fix
[ ] refactor
[ ] other:

Checklist

[x] Tests added for new functionality
[x] All other tests are also passing (please note if not)

Current coverage %: 98.25

Number of reviewers

[x] 1
[ ] 2
[ ] 3

Emoji or GIF about how you feel rn (optional)

New relic looks so cool! Thanks @exasperlnc @cariperi !


Add Read-only Transaction check to function calls

At client_context.cpp:320-331 we check if a statement would be a valid read-only statement for read-only transactions. However, the expressions within the statements could contain functions that could perform a write. We currently don't check this. As well, we don't seem to check if macro functions are read-only either. We perhaps want to handle this in the binding stage instead of the parser stage as above.

We should introduce a more scalable infrastructure to track if a statement/expression/function is modifying the database or not (perhaps during binder phase). @andyfengHKU or @acquamarin should take a look at this.


[Parallel Tests] - Add optional filter label to worker pods

Right now pachd assumes every worker pod in a namespace belongs to it. I started looking at supporting multiple pachds using multiple namespaces, but it gets hairy to handle exposing the etcd and postgres services to the sidecars in every namespace. Debugging is also a pain.
This is an alternate approach where pachds can attach a label to their worker pods, and only care about pods with their label. This allows us to run pipelines from multiple pachds in a single namespace without them clobbering each other.

Does this use one etcd and one PG for all the pachs?

This PR just adds the filter label to the worker pods, but yes in this model we would use one common etcd and postgres with different prefixes and databases for each test.

@msteffen @chainlink Do y'all have strong objections to this approach? The PR kind of stalled out, this is the last thing blocking adding the parallel testing framework.

I'm good with this to unblock testing but would like to circle back on the multi namespace complexity as we're likely going to want to use namespaces for multi tenancy.


SHA1 Case issue

https://github.com/rclone/rclone/issues/7345

I was wondering if solution mentioned here: https://github.com/rclone/rclone/issues/7345#issuecomment-1821463100
Replace:
https://github.com/rclone/rclone/blob/master/fs/operations/operations.go#L119
return srcHash == dstHash, ht, srcHash, dstHash, nil

with
return strings.ToUpper(srcHash) == strings.ToUpper(dstHash), ht, srcHash, dstHash, nil

solves this problem?

I've created pull request: https://github.com/henrybear327/Proton-API-Bridge/pull/27 but given that I couldn't exactly reproduce this issue (no idea in which case Proton would return uppercase SHA1 instead of lowercased one) it is somewhat blind fix.

I will review it along with other changes that I have queued up on my side! Thank you for the PR!
Indeed, as you said, the way to test it is ... hard. What I usually do is upload files from rclone side and see if I can open it with web and iOS, and the other way around ...

Instead of using == to string compare, it would be more semantically correct to use the strings.EqualFold() which assumes UTF-8 and will not convert full-casing. This is the perfect use for this!
For future reference, for complex Unicode cases, there is "third party" package from the golang devs: Fold
This is overkill, If you want to be extra safe with Unicode then the precis from the secure package subdir would be best.

SHA-1 hash shouldn't have weird unicode issues, so I think using strings.EqualFold() should be sufficient!
Thank you for the references and ideas! :)


Performance improvements

I'm popping this in as a draft to let people start looking at it.
Unfortunately its pretty big, but some of these changes are
just rubocop formatters, which I've kept in separate commits.

So more manageable chunks:
https://github.com/sanger/samples_extraction/pull/173/commits/51f8a992d4bdb75fe3675ee39130494102ebe1d9
Where it all started, trying to update dependencies and confirm performance impact. Real world impact of the hash changes was negligible, and has definitely been eaten up by subsequent changes.

Suggested review chunks:
Where it all started, the upgrade to ruby 2.7.x
https://github.com/sanger/samples_extraction/pull/173/commits/51f8a992d4bdb75fe3675ee39130494102ebe1d9
This required I confirm that the hash changes had no significant impact on performance
This is followed by a few minor updates to gems:
https://github.com/sanger/samples_extraction/pull/173/files/879f6490abda9c2f0a8a8ee3fcf77211143e78da..69a17d76f76cea16981c0f2d320b9d2f0b25747a
And then I'm updating rubocop, which is massive and almost exclusively autofixes. I have actually sanity checked this one. I've pulled this out as otherwise you'll have trouble seeing anything of importance
https://github.com/sanger/samples_extraction/pull/173/commits/0ce533a2927b9d04e2fa6ef928b6600bd1bb39a7
Then a lot of gem updates (including rails), some useful info in the commit messages:
https://github.com/sanger/samples_extraction/pull/173/files/879f6490abda9c2f0a8a8ee3fcf77211143e78da..8df053d50d8e86c075e8d195a60730c0649b1fda
Next the Rubocop helped me find unreachable code:
https://github.com/sanger/samples_extraction/pull/173/files/bba85d62abb91e7e96a026a16f020da2cf64f067
We move reracking into the same process:
https://github.com/sanger/samples_extraction/pull/173/files/e4eb0c97014388ebe5a12dac1f4ff1e48140788c
Then what follows is a bit of refactoring while I try to unpick the code.
https://github.com/sanger/samples_extraction/pull/173/files/745044896ec537cf1fdbd301cb5d2be1c9aebd6c..79617c3ec35aad9af0bbcdebedc106a30d2d2985
Rubocop whitespace changes:
https://github.com/sanger/samples_extraction/pull/173/files/3831e306b18c48d6074846669895e81d215eb99a
Then the bulk of the changes:
https://github.com/sanger/samples_extraction/pull/173/files/ac3778c65c79ea82304b321f910778edea23dd05..af9f085a816c9d71a0df423fec3f63e573d88edf


usage of ternary operator vs if else statement

I saw in a few places in time.h where ternary operators are used on return.
This looks fine for short statements, but obscure logic with longer ones like this.
https://github.com/abseil/abseil-cpp/blob/1b465af3bf865f588251470ea0dec60851a24041/absl/time/time.h#L1495
Not that the clients need to understand the logic, but I'm just wondering if there's a reason for doing this vs just using if-else like in
https://github.com/abseil/abseil-cpp/blob/1b465af3bf865f588251470ea0dec60851a24041/absl/time/time.h#L1468

The former function is constexpr. The latter is not. At least in C++11, a series of if-statements isn't constexpr.

I see, thanks!


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: foongminwong sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Liberapay

Hello,
I love your content and I want to donate to you to support your work :)
I would love to donate to you over Liberapay. It would be awesome if you post the donation link on Github and YouTube.
Thanks!

Thank you for your interest! I am not currently on Liberapay. In fairness, I'm not really developing software yet. I'm primarily making tutorials on YouTube and sharing my code here. The best way to support the channel is by becoming a channel member. It's similar to Patreon, and channel members get advanced access to my new videos. If this is something you might be interested in, you can click on the "Join" button on my channel page: https://www.youtube.com/c/juliafortalentedamateurs Thanks!

I actually wanted to support your content without a Google account. Liberapay is free open source.

Oh, I see. Well, the customer is always right! I have just created a Liberapay account. The username is the same as my GitHub account: julia4ta. Let me know if you have any issues with it. Thank you for your interest!
julia4ta Liberapay


"Reconfigure this VM" button

Hello,
I have a difficulty with a function to reconfigure VM in ManageIQ.
I have a provider (VMWare) configures, when I select a "virtual machine> configuration> reconfigure this VM" the option "Network Adapters" appears where the users can view / create a network interface on any VLAN which I cannot release.
I need a way to remove the option of "Network Adapters", or make this group of users able to view and only appear in the dropdown the VLAN that was enabled for that group.
Is there any way to do this?
Thank you.

/cc @gmcculloug

At the moment I do not believe there is a way to hide or filter this option at all.  @lfu would know a little more about the internals for this feature.  Might be easy to add RBAC filtering on the network resources.
Otherwise, maybe need to consider exposing a new product feature to support showing/hiding the section completely.

Closing as it's been a month since last response. If this is still an issue, please reopen


Avoid memory leaks/cancel tasks using async.cancelAll

@tsuharesu please take a look how we gonna solve the memory leak issues by calling async.cancelAll. This function should be call when object is not needed anymore (like in Activtity.onDestroy). The significant changes are in AsyncUi.kt file. Thanks!

Cool one! Nothing leaking from MainActivity, can see GithubActivity leaking and compare results.
👍

thanks @tsuharesu !


OSError: [Errno 36] File name too long

  File "/var/graphite/env/lib/python2.7/site-packages/kenshin-0.2.6-py2.7-linux-x86_64.egg/kenshin/utils.py", line 24, in mkdir_p
    os.makedirs(path)
  File "/var/graphite/env/lib64/python2.7/os.py", line 150, in makedirs
    makedirs(head, mode)
  File "/var/graphite/env/lib64/python2.7/os.py", line 157, in makedirs
    mkdir(name, mode)

a 340 characters metric name

Maximum filename length on XFS is 255 bytes.
https://en.wikipedia.org/wiki/Comparison_of_file_systems#Limits
.hs file successful created, but symlink failed.
Ignore filename too long while os.symlink or set a limit(for each part of metric name) in Kenshin Storage? @zzl0

3 options:

Optimize metric names.
Ignore filename too long while os.symlink or set a limit(for each part of metric name) in Kenshin Storage
Investigate how the graphite team solve this problem

https://github.com/graphite-project/carbon/issues/181

Adding a regex and a string manipulation on every insert can be very costly at high volume. There used to be code to "correct" malformed metrics but it was removed because of the performance impact. If you want good metric namespaces you should send good metric namespaces, the code shouldn't be a nanny that everyone has to pay for.

match ^.*[^.]{256,}.*$
    send to blackhole
    stop
    ;

add this to relay.conf will prevent bad metrics send to rurouni cache
limit (256 here) depends on your file system

@camper42 想了下，我觉得你应该在这里（即 instrumentation.incr('creates')前面）加上检查指标格式的逻辑，如果不合法就拒绝，并用 instrumentation 统计不合法的指标数量。
为什么这个检查对 cpu/性能 消耗不大？

只有新的指标才会走到这里。
而且我们使用了 token_bucket 控制新指标的数量（我们线上应该是1000 个每分钟，具体参见 settings.MAX_CREATES_PER_MINUTE）。


managed server listen address is always set to IP

When a managed server is created, the listen address is always set to IP address.  This occurs even if the MS_HOST variable is passed.  The behavior can be observed in the WebLogic console.  A problem can arise if the managed server container is restarted and it does not get the same IP.  The result is the managed server will not start.  To fix this the and add-server.py script is updated to set listen address as hostname when the MS_HOST variable is passed.  (the host name should be passed as the container name).  The container IP will be resolved as long as the default docker bridge is not being used.  The existing behavior is unchanged when MS_HOST is not passed,  mshost defaults to msinternal

@mriccell, mind to take a look at this? If possible test it too?

This change looks good!  @aquasheep20 Thank you so much for contributing!

I looked at the 1213-domain image and in the Dockerfile there is no way for a user to pass in the MS_HOST name.  The MS_HOST should be set in the ENV of the Dockerfile.

file removed
-MZ

Once @mriccell approves, we merge.


JUnit 5 Migration

Motivation and Context
Need to migrate Case API, Exception Manager, UAC QID Service and Support Tool to JUnit 5
What has changed
Updated pom.xml
Updated tests
Build run to check nothing breaks
How to test?
Run maven clean install
Links
https://trello.com/c/VYaJVu9x
https://www.baeldung.com/junit-5-migration

 Junit 5 migration - finish the job (5)


ghc: when building with 8.0.2 or later, enable parallel builds

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

I've already enabled that a few lines below. Could be made better :)

Merged in ef65917803560ff84e15918c1f0fefe35869d38c.

Um, I meant 711c23577749dea88514df778fd73e42c2f3eb45.

@domenkozar Whoops!  I missed that; @peti, thanks for merging!


Design question: Stream and Linq?

Per the documentation:

result.First(); // Bruce Wayne
result.First(); // Selina Kyle as you already consumed the previous "first" record!

We do understand that if the Result was supposed to be treated like a Stream, in that you can consume parts when it's ready without needing to wait the whole thing materialized from wire; also each part can only be consumed once, (without Seeking of cause).
But doing Linq on this Stream is a bit worrying. We have been educated over the years, that Linq statement normally "defer"/"lazy" on execution, so one could keep on building/chain it, until the materialization point, i.e. iterate over it, or those ToList() methods.
At any other context, code snippet
var r1 = result.First();
var r2 = result.First();

would imply in fact r1 equals to r2, they hold the same "query" thus data.
What this actually should be is:
var r1 = result.GetNext();
var r2 = result.GetNext();

(Or use the MoveNext pattern)
So I wonder if this is something that can be improved/clarified?

Hi @xied75,
Thanks for your feedback, the reason to settle down on this API was a balance between convenience and correctness.
We thought of just implementing IEnumerator<T>:
while( result.MoveNext() )
{
    var record = result.Current;
    // do something
}

But also we greedily want to have great Linq methods for free if we implements IEnumerable<IRecord>. Then we end up implementing IEnumerable<IRecord>.
In most cases, especially only one iteration of the stream is needed, it works pretty okay. Thus we decided let's try this and document strange behaviour to use Linq with Streaming such as First.
Then for the cases where multiple iteration is needed, we can also use Linq's List method to save the stream into a list.
Thanks again for letting us know your thoughts about our API. We will think more about using the suggested use pattern of Linq in our next API design.
Cheers,
Zhen

Hi @xied75,
Since our IStatementResult is defined as a stream of records, rather than a collection of them - as you're already aware of - creates enumerators over a changing record set. Exposing the result stream with an IEnumerable brings in better integrity with the existing language features which drove us to that decision.
Returning consistent results across IEnumerable calls, like in supporting multiple enumerations, we need to buffer all the records internally which both requires extra resources and also increases the code complexity. However, it is perfectly valid for the user to explicitly convert the IEnumerable into a ICollection and do any number of enumerations afterwards, depending on his own use case.
On another side note, our async API returns instances of IStatementResultCursor which exposes a cursor-like behaviour - which I guess conforms to your expectations.
We may come up with an improved API in a future major version, and will keep your suggestions in mind as @zhenlineo already stated.
Thanks.
Ali

@zhenlineo @ali-ince Thanks for the reply. Just want to repeat, what I was concerned, is more on the "correct abstraction", especially around what 99% C# programmers believe or understand. If an abstraction is bent too much, it might not be suitable at all. This is really where the difficulty lies in API design.
Thanks for the good work, keep going... 👍

Hey All,
I just got started with neo4j and the C# driver, and i must say I am baffled and confused by this design choice.
Why would a simple .Count() discard all the entries of a result?
Why would iterating over a IEnumerable discard all the results by default?
This behaviour mimics quantom physics in a way... you changethe state by simply observing it.
Now.. all is made clear when it's explained WHY this is the case ( treating the results as a stream) but it's pretty counter intuitive.
Wouldn't support for 2 types of APIs be less confusing, even if one is simply a wrapper around the streams that does .ToArray() ?


Omnibus for migration

Make sure we are also documenting the new features etc. and actually cutting new releases


Fix zoom in/out with Ctrl-Mousewheel

This feature is broken since version 2.0.

Thanks for looking at this! I need to do some testing, but this might be similar to some in-progress changes on the fix/zoom-scroll-wheel branch for bug 1958585 (https://github.com/PintaProject/Pinta/compare/master...fix/zoom-scroll-wheel)

This change appears to no longer be needed, v2.1.1 (in my case installed from flathub) has working Ctrl-MouseWheel scrolling

It's been a while since I've looked at it since I've been busy with the GTK4 port, but I think the issue (at least for bug 1958585 that I was trying to fix) was that Ctrl+wheel was able to zoom, but caused the image to shift around instead of staying centered under the point you zoomed from

I think this change was likely correct for the GTK3 branch of Pinta - the coordinates needed to be transformed to the child canvas widget
During the GTK4 port, which had a lot of changes related to event handling, the combination of https://github.com/PintaProject/Pinta/commit/9eac98a6dd8197bcf4e8878ecb7025191921f6d5 and https://github.com/PintaProject/Pinta/commit/0d2c241678cdfb7b0e7f3f872a105b066dba3a56 now have the correct  position being used
I've included you in the contributor credits for this - thanks for looking into it!


backend_oculus: elevate the render and main thread's priority

This dates back to Oculus 0.6.0. Ever since then we have not been
passing the thread ids. The TimeWarp thread itself has always been
elevated.

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

Planning to merge on Tuesday.


Feedback

Sorry if this isn't the best place to put this, feel free to move it to discussion!
Here's a little app i made for demonstrative purposes: https://stackblitz.com/edit/vitejs-vite-v6umf3?file=src/App.tsx
After using this library for a couple days, I've gathered some feedback:

Possible to add an invalidate function to the cache?
The implementation I use is:

function invalidate<TParams extends any[], TValue>(
 cache: Cache<TParams, TValue>,
 ...args: TParams
) {
 cache.evict(...args);
 cache.prefetch(...args);
}

possible to notify subscribers when an eviction happens? Currently no notification is given, unless its an evictAll i believe.
similarly, evicting and forcing an update afterwards does not cause the suspense fallback to show. Intended? You can see it in the app above by going to the posts, and clicking evict current page
the current eviction policy seems unpredictable and aggressive, sometimes causing surprising evictions. In the app above, if you go to the posts, you'll see that sometimes when pressing the next button, a complete cache blowout has occurred forcing a suspense fallback. Will also notice it in the users demo (loading a new user will sometimes show all other previously loaded users are now evicted).

I was thinking a possible strategy is to allow the user to provide their own implementation of the internal cacher so to leave the eviction policy to them. I would personally want to use a LRU cache, but some might consider another type of cache. Providing the inversion of control could satisfy all use cases. What do you think?

I commonly want to know if the current cache item is revalidating (no suspense fallback). What does an api like this sound like for read:

const [value, revalidating] = Cache.read()

my current implementation for this is using this helper function:
function useRead<TParams extends any[], TValue>(
  cache: Cache<TParams, TValue>,
  ...args: TParams
) {
  const value = cache.read(...args);
  const status = useCacheStatus(cache, ...args);
  return [value, status === 'pending'] as const;
}

provide built in hooks? this one is not really a big deal and philosophically i can understand it not being part of the cache. But something like useCacheStatus(cache, ...) to Cache.useStatus(...) etc
the current getValueIfCached throws an error if rejected, which makes it cumbersome in some cases. Thoughts on providing a cache.peek function that returns the raw record or undefined?
In my implementation i paired it with a function called cache.evictIf(predicate, ...args) that was useful in ErrorBoundaries to evict if the cache was rejected before reseting the error boundary

some other points

the subscribeToStatus calls the subscription callback immediately causing an unnecessary render on mount when using uSES
the type inference feels lacking, I think the load function should provide all the signatures it needs instead of having to manually supply the generics.

Mind moving this to one or more discussion threads? I think it's better suited for that.


Bug: More issues with event_filter

#254 doesn't seem to have fully fixed things for me yet unfortunately.
When I launch napari-micromanager from a script:
import napari
from pymmcore_plus import CMMCorePlus

v = napari.Viewer()
dw, main_window = v.window.add_plugin_dock_widget("napari-micromanager")

core = CMMCorePlus.instance()
core.loadSystemConfiguration()

napari.run()

then it freezes multiple times as everything is loaded.

This seems to be due to the event filter as when I comment out this line:
https://github.com/pymmcore-plus/napari-micromanager/blob/f3cb1693a0780df9c02111eee7621b7bf22837f6/src/napari_micromanager/_gui_objects/_toolbar.py#L109
the behavior no longer occurs. I also added some counting code and found that the event filter seems to be called upwards of 20000 times before I even interact with the window.
I've also found that if then go and try to move the window around i get a Segmentation fault (core dumped)
napari: 0.4.17
Platform: Linux-5.17.15-76051715-generic-x86_64-with-glibc2.35
System: Pop!_OS 22.04 LTS
Python: 3.9.16 | packaged by conda-forge | (main, Feb 1 2023, 21:39:03) [GCC 11.3.0]
Qt: 5.15.2
PyQt5: 5.15.9
NumPy: 1.24.3
SciPy: 1.9.1
Dask: 2023.4.1
VisPy: 0.11.0
magicgui: 0.7.2
superqt: unknown
in-n-out: 0.1.7
app-model: 0.1.4
npe2: 0.7.0

OpenGL:
- GL version: 4.6 (Compatibility Profile) Mesa 22.3.5
- MAX_TEXTURE_SIZE: 16384

Screens:
- screen 1: resolution 1920x1080, scale 1.0

accidentally hit enter before I meant to post so many edits above - but @tlambert03 do you also see this and/or have any insight into potentially lessening the impact of the event filter

we should ask @fdrgsp ... he's been using it much more than I have.

per a tip from @fdrgsp on zulip using pyside2 seems to fix it. Though ideally it should work with PyQt5 also :/

ok will have a look

I've been unable to reproduce this on macOS 13 with
napari: 0.4.17
Platform: macOS-13.3.1-x86_64-i386-64bit
System: MacOS 13.3.1
Python: 3.10.11 | packaged by conda-forge | (main, May 10 2023, 19:07:22) [Clang 14.0.6 ]
Qt: 5.15.2
PyQt5: 5.15.9

the event filter is only there to force the toolbar to be on the top.  So, if you want to add an environment variable to disable it, or anything else you want to do to make it work better for you, it's fine with me.
The event filter being called a gazillion times isn't in itself too surprising (any and all events pass like wildfire through the widget tree...).  But it should almost never hit that conditional: event.type() == QEvent.Type.Move and obj is self...  (though of course simply evaluating that could perhaps be the problem?  not sure why it would be os specific)

@ianhi, please recheck.  Since I was unable to reproduce even on PyQt5, I'm inclined to close this, but still waiting to hear from you

I can still reproduce this on python 3.11. It resolves if I export QT_API=pyside2 before running.

Since I can reproduce I'm also happy to spend a bit of time on this next time I come by HMS

that would be great too :)

solved by #280


Allow dispensation from multiple prescriptions

Coverage increased (+0.4%) to 32.48% when pulling 91e65038deb4d0f977ff76e87301c936453fbe38 on ynurmahomed:dispensation into 83858e831f713264ebdce019c0358835e54fc30c on esaude:master.

 1.0.1_30 Feature: Change pharmacy dispensation UI to satisfy multiple prescriptions requirement [8]

Coverage increased (+0.4%) to 32.48% when pulling 8f90c5d5a5aab22e6debb19bc69b9a29520e11f4 on ynurmahomed:dispensation into 83858e831f713264ebdce019c0358835e54fc30c on esaude:master.

This depends on new functionality from pharmacy-api.

#267 has conflicts with this one, I'm going to merge this then fix the other.


No 'version' key in the manifest file for custom integration 'xiaomi_vacuum'

After upgrading to HA Core 2021.3.0, this error shows up in logs:
No 'version' key in the manifest file for custom integration 'xiaomi_vacuum'. This will not be allowed in a future version of Home Assistant. Please report this to the maintainer of 'xiaomi_vacuum'
xiaomi_vacuum integration installed through HACS

With the latest home assistant update:
https://www.home-assistant.io/blog/2021/03/03/release-20213/#breaking-changes
Custom integrations: Version warning

Custom integrations now require a version key in their manifest file, this also means that all custom integrations now require a manifest file.
If you are using a legacy custom integration like custom_components/awesome.py this now needs to move to custom_components/awesome/init.py so you can add custom_components/awesome/manifest.json to it.
For more information about integration, manifests have a look here: https://developers.home-assistant.io/docs/creating_integration_manifest
For now, this will create a warning on startup. But this will eventually be blocked from loading if it’s missing a version in the manifest.
If you see these warnings, please report the issue with the author of that custom integration.

Added a verision to manifest.json.