Improve focus_follows_mouse with mouse_follows_focus off

Expected behavior:
When opening floating windows, or changing focus with keyboard, the "focus_follows_mouse" should be suspended, unless we move the mouse to another window than the current one. (could it help https://github.com/koekeishiya/yabai/issues/407 ?) .
I feel this behavior more natural, for background info I come with i3 experience.
Note that it applies to both autofocus or autoraise when mouse_follows_focus is off.
Example of configuration to reproduce:
yabai -m config layout bsp
yabai -m config window_topmost on
yabai -m config focus_follows_mouse autofocus
yabai -m config mouse_follows_focus off

If you want to test with modal:
yabai -m rule --add app="^System Preferences$" manage=off

If you want to test with keyboard .skhdrc:
alt - left: yabai -m window --focus west
alt - down: yabai -m window --focus south
alt - up: yabai -m window --focus north
alt - right: yabai -m window --focus east

Typical use-case:

two windows are split vertically
mouse is over the left window
change focus to the right window with the keyboard (alt-tab or alt-right)

Current behavior:
4a) mouse moves toward the right window, yabai focuses the left window
5a) mouse reaches the right window, yabai focuses the right window
6a) mouse moves to the left window, yabai focuses the left window
Expected behavior:
4a) mouse moves toward the right window
5a) mouse reaches the right window
6a) mouve moves to the left window, yabai focuses the left window

At first I thought this sounded like a great solution, but after thinking about it for a while I see a few notable issues with the approach so far. These could potentially be solved, or at least it could be documented behaviour to clarify certain cases.
So let's say we extrapolate your suggestion for more complex layouts, e.g three windows are all split vertically. Mouse is over the left-most window. Change the focus to the right-most window using whatever keyboard-centric method available to you. Now move the mouse toward the right-most window:
Current behaviour:
Yabai focuses the left-most window as that's the window below the cursor.
It reaches the center window and changes focus again.
It reaches the right-most window and focuses the right window.
Suggested behaviour:
Yabai does not focus the left-most window
It reaches the center.. what is the expected behaviour?
It reaches the right-most window.. behaviour depends on the previous step.
This also applies to the following type layout:
 A |
---| C
 B |

I think the key part of the solution is:  the "focus_follows_mouse" should be suspended, unless we move the mouse to another window than the current one
I'm not sure how Yabai is implemented and what are the possibilities of the OS API. However, I'd suggest to everytime a focus change is detected from window A to window B, Yabai captures the old focused window A id.
Then, everytime Yabai detect mouse change, if it goes over any other window different than A, it changes the focus.
So, in practice, it will be:
Three windows split vertically
Current behaviour:
Yabai focuses the left-most window as that's the window below the cursor.
It reaches the center window and changes focus again.
It reaches the right-most window and focuses the right window.
Suggested behaviour:
Yabai does not focus the left-most window
It reaches the center, Yabai focus the center
It reaches the right-most window, Yabai focus the right-most window.
Does it sound good?

I'm still not convinced this is a solution to an actual problem and would like to go back from solution space to problem space. Can you describe why the current behavior is problematic?

The proposal started after one specific problematic.
Let's say you reuse the yabai configuration mentionned in the initial ticket, plus this one:
 yabai -m config focus_follows_mouse autoraise
You also need a keyboard shortcut to launch MacOS System Preferences.

Start with two windows split vertically.
Put your mouse on the left window.
Launch System Preferences with keyboard shortcut, normally it opens in the center of the screen, right between the two windows managed by Yabai.
-> MacOS will give automatically focus to System Preferences
You move the mouse toward the System Preferences in order to clic on buttons
-> Yabai detect mouse move and assign focus & raise to the left window. The System Preferences window is now hidden between your left window.
You move the mouse toward the right side of the System Preferences (the one visible)
-> unfortunately, your mouse trajectory was hover the right window for a single pixel (like coming from the middle of the screen), so Yabai detect mouse hover right window and raise it.

Then you're screwed because you have open a System Preferences, but it has been automatically hidden behind your windows by Yabai. The probability seems maybe a bit unrealistic, but it occurs to me frequently.

You can always just either use mouse follows focus or hold down fn to temporarily disable focus follows mouse.
I think the proposed change introduces more problems than it fixes.

I think on UX point of view, using fn is really a key which should never been used. To me, this fn is for handling edge-cases, not to manage daily scenarios.
In term of problems in the implementation, I'm not sure to follow which problems it raises.
Also, that's only a suggestion of implementation, but if we look on how i3 works, it seems to change focus only when cursor cross windows borders. Does it sound more realistic for you ?
It will have the same beneficial impact on UX: moving the cursor within an unfocused window will not change the focus.

You can always change the modifier key to be something else than fn, that's just the default key so that it is mostly out of the users way, by default.
I do like this suggestion more than the original one, but I think it may be problematic to achieve in practice, in terms of performance. There is no way for us to know when the cursor crosses a window border, which means that every time the mouse is moved, we need to check what the window is, and whether the previous mouse movement was outside or inside this windows boundary to determine the action to be taken.

I experimented with some private API that notifies us when the mouse enters inside a tracking region of a window, and it works well for some applications and not so well for others, because some applications only apply tracking regions to certain parts of the window.
I don't think it is feasible to perform the boundary check manually as mentioned in my comment above.


Fixed the reported bug of the config test in #190

Noticing the bug reported in #190, I then fixed all issues that existed in the tests/config_tests.py.
Description

I made three changes to the code. First, I moved the configuration files, including Pipelines and Models, into the Kinetics directory. This fixed the issue of "FileNotFoundError". Second, all PyLint errors were addressed, making the code rate 10.00/10. Finally, I added more comments further to describe the objective of each unit test function.
How has this been tested?

config_tests
As for the code running, I tested it with python tests/config_tests.py.
As for the format test, I executed the command pylint tests/config_tests.py.

data_tests
As for the code running, I tested it with python tests/data_tests.py.
As for the format test, I executed the command pylint tests/data_tests.py.

sampler_tests
As for the code running, I tested it with python tests/sampler_tests.py.
As for the format test, I executed the command pylint tests/sampler_tests.py.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue) Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Same error:
FileNotFoundError: [Errno 2] No such file or directory: '/home/bli/plato/configs/Kinetics/Models/kinetics_full_models.yml'

Fixed all issues. Please access the "How has this been tested?" section above to test the code.

I tried to fix as many PyLint errors as possible in datasources/multimodal_base.py, but the following errors still need attention:
multimodal_base.py:248:4: W0221: Number of parameters was 1 in 'DataSource.get_train_set' and is now 2 in overridden 'MultiModalDataSource.get_train_set' method (arguments-differ)
multimodal_base.py:254:4: W0221: Number of parameters was 1 in 'DataSource.get_test_set' and is now 2 in overridden 'MultiModalDataSource.get_test_set' method (arguments-differ)

I tried to fix as many PyLint errors as possible in datasources/multimodal_base.py, but the following errors still need attention:
multimodal_base.py:248:4: W0221: Number of parameters was 1 in 'DataSource.get_train_set' and is now 2 in overridden 'MultiModalDataSource.get_train_set' method (arguments-differ)
multimodal_base.py:254:4: W0221: Number of parameters was 1 in 'DataSource.get_test_set' and is now 2 in overridden 'MultiModalDataSource.get_test_set' method (arguments-differ)

I noticed that there are also other pylint errors. I will stop my current work to fix these issues.

I am still waiting for follow up work in this PR.


PL: Add documentation about fields.json files to PL README

overview
As an Opentrons Protocol Developer, I want to have docs to understand how to add protocols with parametric fields to PL (in APIv2 land) with a fields.json file

Closed in apiv2 branch


[API][SIMS-#681]MSFAA send file

Tasks:

[x] Create a new reference application id column in the MSFAA number table and insert it while a new MSFAA number is created
[x] Fetch all the MSFAA numbers, where the requested date is null. Fetch the referenced application, student, offering, and institution details to create the records in the MSFAA send file records.
[x] Create sequence control for full time, part time files separately and reset the sequence every day to generate the files.
[x] Create sequence control for file.
[x] Using similar process to CRA, create fixed fixed file and send to zoneB SFTP server
[x] Populate column date_requested in MSFAANumbers table

Nice work @guru-aot 👍. Minor comments.


Validate uploaded files

Fixes #1085

Coverage decreased (-0.06%) to 91.304% when pulling bc88df5e0d8b486c831e73698a4521f494655b02 on josenavas:verify-biom into 66d5e4b9f456cf7d1d6167796a9ce2ab2d99bf8d on biocore:master.

Yay!! Can I have a review in here?

@josenavas, I'm reviewing this right now.

Coverage decreased (-0.04%) to 91.327% when pulling f99b50106b66429ee05ca66d9586d501efa7d786 on josenavas:verify-biom into 66d5e4b9f456cf7d1d6167796a9ce2ab2d99bf8d on biocore:master.

Thanks @josenavas!


Add CSV max filesize check (#190)

:heart: Thank you for your contribution!
Description
Fixes #190 by means of adding a file size check to invenio_previewer.extensions.csv_papaparsejs.can_preview.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

[x] I'm aware of the code of conduct.
[x] I've created logical separate commits and followed the commit message format.
[ ] I've added relevant test cases.
[ ] I've added relevant documentation.
[ ] I've marked translation strings (for relevant code).
[ ] I've followed the CSS/JS and React guidelines (for relevant code).
[ ] I've followed the web accessibility guidelines (for relevant code).
[ ] I've followed the user interface guidelines (for relevant code).
[ ] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
[x] I've NOT included third-party code (copy/pasted source code or new dependencies).

Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

@psaiz Question: The new CSV file previewer is supposed to stream the CSV file so it's not loading the full file right?
@daglueck Given the answer from @psaiz I would say that the limit should be significantly higher to allow for larger CSV files to be previewed - say e.g. 100MB.

Based on your comments, I've added a separate validation function (@alejandromumo ) and increased the max file size to 100 * 1024 * 1024 (@lnielsen ). I've added a new config variable PREVIEWER_CSV_MAX_BYTES to differentiate CSV from JSON/XML. Let me know if you had imagined this in a different way.
@lnielsen I didn't know that a new csv previewer was added. How does it work with the max file size, will it simply not load the file if it's too big (as with XML/JSON I guess) or will it truncate the file (like with TXT)? I was assuming here it won't load the file since otherwise there might be parsing issues. If on the other hand it does truncate the file, the wording of PREVIEWER_CSV_MAX_BYTES might need to be adjusted.


Add case-when clause in math expression

support case-when-else clause in math expression

👍

LGTM

@navis can this be done by a case function like the "if" function instead of updating the grammar? trying to keep the language simple.

@himanshug I don't know well on antlr. Could you do that?

@navis i meant the way "if" is implemented. it is a function only. so there could just be a function called "case" that accepts 1+2n+1 arguments. user would write something like
case(case_expr, predicate1, then1, predicate2, then2, ..... else_expression)
instead of
CASE case_expr WHEN predicate1 THEN then1 WHEN predicate2 THEN then2.... ELSE else_expression
that would not be baking case syntax in the language grammar itself and possible keep parsing and language simple since this is supposed to be a tiny minimal language.
that said, i see this can be debated but just my 2 cents.

@himanshug I prefer SQL like grammar but respect your intention. I'll do that.

@navis merge conflicts


Checkpointing fails to save config data because it is a dict not a str

Describe the bug
Saving model checkpoints fails with stack trace:
Traceback (most recent call last):^M
  File "/mnt/nvme/home/dashiell/gpt-neox/train.py", line 27, in <module>^M
    pretrain(neox_args=neox_args)^M
  File "/mnt/nvme/home/dashiell/gpt-neox/megatron/training.py", line 106, in pretrain^M
    iteration = train(^M
  File "/mnt/nvme/home/dashiell/gpt-neox/megatron/training.py", line 613, in train^M
    save_checkpoint(^M
  File "/mnt/nvme/home/dashiell/gpt-neox/megatron/checkpointing.py", line 208, in save_checkpoint^M
    save_ds_checkpoint(iteration, model, neox_args)^M
  File "/mnt/nvme/home/dashiell/gpt-neox/megatron/checkpointing.py", line 201, in save_ds_checkpoint^M
    f.write(config_data)^M
TypeError: write() argument must be str, not dict^M

To Reproduce
python3 deepy.py --conf_dir configs 1-3B.yml local_setup.yml
Expected behavior
The checkpoint should save without failing.

Time for everyone’s favorite game: running a binary search on the commit history until we find out what went wrong 🙄
@dashstander Have you ruled out this being a weirdness of the new Stability cluster by running it on another GPU source?
@haileyschoelkopf what is the most recent commit that you know you’ve successfully saved a model with?

I've loaded a model with the most recent commit on main (ebd47f6e9b72cbdba51f5393958d0d3bd95c6e64), would need to dig for most recent commit.
maybe relevant (though I'll make a separate issue for it):
Checkpoints saved using DeeperSpeed can't be loaded using the deepspeed_main branch with new upstream Deepspeed. Not sure if this is solely due to the issue Igor mentioned about not saving iteration in Adam optimizer state, or if it's some other format change over Deepspeed versions.
traceback for that:
Traceback (most recent call last):
  File "/fsx/hailey/deepspeed-main-neox/gpt-neox/evaluate.py", line 76, in <module>
    main()
  File "/fsx/hailey/deepspeed-main-neox/gpt-neox/evaluate.py", line 35, in main
    model, neox_args = setup_for_inference_or_eval(use_cache=False)
  File "/fsx/hailey/deepspeed-main-neox/gpt-neox/megatron/utils.py", line 440, in setup_for_inference_or_eval
    model, _, _ = setup_model_and_optimizer(
  File "/fsx/hailey/deepspeed-main-neox/gpt-neox/megatron/training.py", line 437, in setup_model_and_optimizer
    neox_args.iteration = load_checkpoint(
  File "/fsx/hailey/deepspeed-main-neox/gpt-neox/megatron/checkpointing.py", line 235, in load_checkpoint
    checkpoint_name, state_dict = model.load_checkpoint(
  File "/fsx/shiv/torchtest/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 2647, in load_checkpoint
    load_path, client_states = self._load_checkpoint(load_dir,
  File "/fsx/shiv/torchtest/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 2713, in _load_checkpoint
    self.load_module_state_dict(state_dict=checkpoint['module'],
  File "/fsx/shiv/torchtest/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 2507, in load_module_state_dict
    self.module.load_state_dict(state_dict, # TODO
  File "/fsx/shiv/torchtest/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1620, in load_state_dict
    raise TypeError("Expected state_dict to be dict-like, got {}.".format(type(state_dict)))

I should prob make an issue on Deepspeed about whether there's a way to update checkpoints to newer DeepSpeed versions.

I'm on DeeperSpeed and GPT-NeoX main. I actually think this is an(other) SlurmRunner issue. It's failing specifically with the version of the config files that are saved as strings in the arguments. Those specifically were giving me trouble when implementing the SlurmRunner and there's Deep(er)Speed logic to basically clean them up. They get written back to strings to get passed in to srun as a command line arg, but it's too much of a coincidence for me not to suspect it.
Maybe make another issue about loading the checkpoints? Or comment on #673 ? That seems like something we should all be aware of

Ok, yeah, this is a SlurmRunner thing. To make NeoX and the DeepSpeed SlurmRunner compatible I needed to go in and clean up those configs before passing them to srun. But now the when the argument dict is parsed here all of the configs are so clean they're getting parsed into dicts instead of being left as strings.
My proposed solution is to check for this when serializing the configs and either use json.dumps or f.write as needed. I'm about to get kicked out of the cafe I'm in, but I'll make a PR to that effect tonight.

(Made an issue at #732)!


Remove buggy total balance from CLI

Description
Returning total: 3.963877391197344453575983046348115674221700746820753546331534351508065746944e+75
Tested
Not tested
Other changes
None
Related issues
None
Backwards compatibility
Yes

The issue is to remove it, or fix that number?

Well I'm not sure why we try to calculate this number in the first place..


deleted the dummy_files directory to test the workflow again

No big code changes, just deleted the dummy_files folder

Workflow did not work because I had to reformat the files in my branch first, trying again in another pull request, nothing else changed


API to get SSARegister for a register at a given LLIL instruction

Is your feature request related to a problem? Please describe.
When analyzing x86 reps instruction's LLIL (which is lifted to a loop), there is no way to get the ILRegister and it’s version for a register (say rdi, rsi or rcx) at a given LLIL instruction.
Describe the solution you'd like
In MLIL SSA, I could use get_var_for_reg(register) and get_ssa_var_version(var) to get the SSAVariable. Similar APIs for LLIL SSA would solve the problem of accessing SSARegister
Describe alternatives you've considered
Mixing LLIL and MLIL for the analysis

As innocuous as this request seems, we don't keep track of the same information in LLIL that we do in MLIL - which means that more effort would be required to implement this than we originally expected.
The steps we use in the MLIL algorithm internally is:

Find block containing instruction
Find any assignment to this variable before the instruction in the current block, return that assignment's version
If the variable is not assigned before this instruction in the current block, look for last assignment in other blocks (and return the value of that assignment).
No previous assignments, return entry version

Steps 1, 2, and 4 are dead simple, and that's as far as I got in today's BugBash.  The difficult part to solve there is step 3; in the MediumLevelILSSATranslator, we keep track of variable assignments at the block level using an internal function AddVarAssignForBlock, which we'd need to replicate in our LowLevelILSSATranslator.  The other option would be to walk backwards through blocks, but I'm not sure if the interaction between backwards block traversals and SSA-form guarantees reaching the "correct" answer.


Require function whitespace problem.

Hello.
When it try to get module with require require("react-native") everything is ok.
But when I wrap module name with whitespace require( "react-native" ) I've got an error:
Invariant Violation: Application

I have this problem on OS X 10.10 with node 0.12.0

cc @amasad, would be nice to make this error message better

it'd be better to fix it :)

Came across this issue as well :/ It seems that the id arg passed into the require func defined in require.js is incorrect when spaces are used in calling the require func.
require( "react-native" )

require("react-native")

If someone wants to take a stab at fixing this:
look here https://github.com/facebook/react-native/blob/master/packager/react-packager/src/DependencyResolver/haste/DependencyGraph/index.js#L603
and here https://github.com/facebook/react-native/blob/master/packager/react-packager/src/DependencyResolver/haste/index.js#L28


What is the admin URL?

I did docker-compose up and waited for something to happen.  Went to <IP_ADDRESS> and got this:  https://www.screencast.com/t/spSzAm4Fb  (making the words admin panel a link would be most useful)
<IP_ADDRESS>:81 (admin port from docker compose) said connection reset.
Running docker-compose up without -d yields this:  https://www.screencast.com/t/YoNCnL0cr1  Maybe there is an error?
Looking forward to trying this - looks great from the screenshots!

Looks like your DB isn't initializing. What docker image are you using for it?

For other google users: Admin Panel URL is http://npm_ip:81
Why this is closed without resolution? I'm reading docs and also don't know what is admin panel url (In docs there is a lack of this info!!!) ! It's insane to relay on such basic information and not provide it.

The admin panel port is documented in both the quick setup in step 4 and in the docker container logs when starting the image. Though we can add even more information about that.
The actual issue also had nothing to do with the title, it was about the database connection not working, and it was opened a while ago, and a lot has changed since then. Also there were no further responses, thus it was closed.


Adding new maintainer @noCharger

Description
Welcoming new maintianer @noCharger
Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] New functionality has javadoc added.
[ ] New functionality has a user manual doc added.
[ ] API changes companion pull request created.
[ ] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-project/admin FYI

Added @noCharger as the maintainer.
Looks like codeowners file is still invalid with below error:
Unknown owner on line 2: make sure @pjfitzgibbons exists and has write access to the repository

Please fix it. You can ask the maintainer if they still wish to be the maintainer. If yes, we can retain the access back else please consider moving them to emeritus section.
Thanks!

Added @noCharger as the maintainer. Looks like codeowners file is still invalid with below error:
Unknown owner on line 2: make sure @pjfitzgibbons exists and has write access to the repository

Please fix it. You can ask the maintainer if they still wish to be the maintainer. If yes, we can retain the access back else please consider moving them to emeritus section. Thanks!

Thanks, will create another PR to update it.

Since it has been a long time since they moved.
You can move them to emeritus:
https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#removing-a-maintainer


Add read_tile to store interface

Refs https://github.com/mapzen/tileserver/issues/1

@zerebubuth could you review please?

:+1: looks good to me.


Test scene generation methods

Could you make a short tutorial regarding how to make the test scenes? I want to make some additional scenes for this project but don't know where shall I start.
Many thanks.

Currently the test scenes are all hard coded since this project is just meant to teach these techniques. The goal is to learn from this and integrate it into your own engine/codebase. There is a LOT of hard coded bits for each scene so it isn’t really practical to make a tutorial for it.


Feature/suspend gestures (Fixes: #468)

adds methods to suspend and resume a sliders reactions on touchmove/mousedrag (also hides the controls if there are any for the time of suspension)

Yes! Thank you for this. I'm using it like this, works well for when users need to zoom in (look at tiny images on tiny phones with their tiny eyes) without letting them accidentally swipe to the next slide.
  window.addEventListener('touchend', () => {     if (window.visualViewport.scale !== 1) {       sliderFloors.suspendTouchAndDrag();     } else {       sliderFloors.resumeTouchAndDrag();     }   })


README.md broken link for "How to Make a Good Submission".

The link to this video is currently not functional.  https://bugcrowd.com/resource/how-to-make-a-good-bug-submission/

great

Sorry., do you accept my apology?
On Sat, Jan 15, 2022, 6:25 PM MONSTAR @.***> wrote:

great
—
Reply to this email directly, view it on GitHub
https://github.com/bugcrowd/bugcrowd_university/issues/14#issuecomment-1013770423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATCARQO7FO3XORJWXUYY2FDUWH66NANCNFSM5KQRPQDA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sorry., do you accept my apology?
What are you even apologising for?

I thought i got the original message as a result of not making good bug reports

ohh that wasn't a big deal no of you to apologize

https://www.bugcrowd.com/resources/webinars/how-to-make-a-good-submission/
^This is the updated link

wow


Add hook to update shader code before compilation

Should help for https://forum.babylonjs.com/t/recent-material-pipeline-changes/6885/12

I have tested this by inlining all pbr functions, it worked saved for a small error:
outParams.ambientOcclusionColor = mix(ambientOcclusionColor, aoStoreInMetalMap, vReflectivityInfos.z);

ambientOcclusionColor is a in parameter but also appears in outParams.ambientOcclusionColor, so making the latest wrong after the replace. I have just updated the name of the in parameter to ambientOcclusionColorIn.


[python package]: suggestion: lgb.Booster.predict() should check that the input X data makes sense

In particular, I'm thinking about these things:

if the input is an np.array, check that the columns is the same as the number of features the lgb.Booster object uses.  if not, throw a warning.
if the input is a pd.Dataframe object, should check that the feature_names of the lgb.Booster object is a superset of the columns of the pd.Dataframe
if feature names in the booster object are repeated, or if column names in the pd.Dataframe are repeated, fall back to 0.

if these things sound reasonable I'd be happy to add these checks to the lgb.Booster.predict() function prior to calling the lgb._InnerPredictor.predict()

@j-mark-hou  sure, very happy to see this feature.

@j-mark-hou any updates ?

I think maybe this should be rolled into a more systematic rewrite of the pandas api.  There's some current things about the implementation that I don't quite understand, and unfortunately I don't currently have the time to dig deeper into this.  Sorry, I'll let you know if I revisit this at some point in the future.

Currently, it leads to some kind of inconsistency:
In [1]: from lightgbm import LGBMClassifier, Dataset, train
   ...: import numpy as np
   ...:
   ...: x_data, y_data = np.random.rand(1000, 100), np.random.rand(1000) > .5
   ...: x_bad = np.random.rand(1000, 101)
   ...:
   ...:
   ...: def sklearn_style():
   ...:     clf = LGBMClassifier()
   ...:     clf.fit(x_data, y_data)
   ...:     return clf.predict(x_bad)
   ...:
   ...:
   ...: def xgboost_style():
   ...:     dataset = Dataset(x_data, y_data)
   ...:     params = {'application': 'binary'}
   ...:     booster = train(params, dataset)
   ...:     return booster.predict(x_data)
   ...:

In [2]: sklearn_style().shape
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-2-281be6aeee0d> in <module>()
----> 1 sklearn_style().shape

<ipython-input-1-adc7de9c0c86> in sklearn_style()
      9     clf = LGBMClassifier()
     10     clf.fit(x_data, y_data)
---> 11     return clf.predict(x_bad)
     12
     13

~/.pyenv/versions/3.6.2/lib/python3.6/site-packages/lightgbm/sklearn.py in predict(self, X, raw_score, num_iteration)
    674
    675     def predict(self, X, raw_score=False, num_iteration=0):
--> 676         class_probs = self.predict_proba(X, raw_score, num_iteration)
    677         class_index = np.argmax(class_probs, axis=1)
    678         return self._le.inverse_transform(class_index)

~/.pyenv/versions/3.6.2/lib/python3.6/site-packages/lightgbm/sklearn.py in predict_proba(self, X, raw_score, num_iteration)
    704                              "match the input. Model n_features_ is %s and "
    705                              "input n_features is %s "
--> 706                              % (self._n_features, n_features))
    707         class_probs = self.booster_.predict(X, raw_score=raw_score, num_iteration=num_iteration)
    708         if self._n_classes > 2:

ValueError: Number of features of the model must match the input. Model n_features_ is 100 and input n_features is 101

In [3]: xgboost_style().shape
[LightGBM] [Info] Number of positive: 506, number of negative: 494
[LightGBM] [Info] Total Bins 25500
[LightGBM] [Info] Number of data: 1000, number of used features: 100
[LightGBM] [Info] Finished loading 100 models
Out[3]: (1000,)

Imho, check on feature count is really important, and this lack of assertion may lead to harsh, not so easy to debug issues.

Closed in favor of being in #2302. We decided to keep all feature requests in one place.
Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

I may be interested helping improve this. What would be the ideal behavior here? Does LightGBM make predictions only based on column order (like sklearn), or based on column names?

The shape of data for prediction is now checked at cpp side, thanks to #2464.
The next steps may be to check the type and order of features, and their names in case of pandas DataFrame.

Reopening because I'm working on this.


[ILVerify] Added first tests

https://github.com/dotnet/corert/issues/3569
-Added a .sln solution file
-Changed the main ILVerify project to the new .csproj format + ILVerify now targets netcoreapp2.0
-Added an xunit based project for testing  - 1 Method for testing methods with valid IL, 1 Method for testing methods with invalid IL.
-This xunit based test project uses Theory and MemberData  to feed the test methods based on a naming convention defined in the comment in ILMethodTester.cs (one it's finished they will be in the readme file)
-Added the first .il file (with 2 small tests) as a test driver
One potential issue:
-netcoreapp2.0 won't work with VS2015 and the last RTM release of VS2017. I use the latest VS2017 preview, which supports netcoreapp2.0, plus of course command line tooling also works. Alternatives to netcoreapp2.0:

netcoreapp1.1: The code base has some APIs, which are not part of netstandard 1.x, so it would need more massage. Plus I guess on the long run we want to target netcoreapp2.0 anyway.
stay with the old format: I think we want to migrate away from that, but I gave it a try: I was not able to have a working setup after ~2 hours.

So my suggestion: let's go with netcoreapp2.0 and VS 2017 preview, or command line. (edit: -a few hours later- after seeing the failing builds I'm not so sure anymore...)
Further questions:
-How should we compile the .il files? I saw an .ilproj on the TypeSystem solution, but that also seems to be the old format. Currently I call ilasm manually. (so that step is definitely missing in this PR)
-What should be the output folder of the ilasm compilation? (currently the tests expect the dlls to be in the same folder (src\ILVerify\tests\ILTests), which I guess is not what we want).
-For the tests I think a base library is needed (with System.Object, etc.). I use the CoreTestAssembly from the TypeSystem tests as a "dummy mscorlib". This is how I reference it: https://github.com/dotnet/corert/compare/master...gregkalapos:Tests?expand=1#diff-099cd076d34a4cba24feb47d7aedd9fcR17. But I guess that's wrong.. How should I do that?
Thanks

ILVerify.Tests.csproj : error MSB4057: The target "BuildAndTest" does not exist in the project.
Same for the other project (ILVerify.csproj).
Is this maybe, because the .NET CLI under Tools\dotnetcli is an old version that does not understand the new .csproj format? I think this was already mentioned here: https://github.com/dotnet/corert/pull/3666#issuecomment-302911932
Although I updated the .net cli in that folder on my machine (to 2.0.0-preview1-005977), but that throws the same error, so i'm not sure.
I'm out of ideas. Could someone help out? @jkotas ?

let's go with netcoreapp2.0 and VS 2017 preview

That's fine.

The target "BuildAndTest" does not exist in the project.

Exclude ILVerify from the end-to-end build in https://github.com/dotnet/corert/blob/master/src/dirs.proj#L10 unconditionally. We will add it back once #3682 is fixed.

For the tests I think a base library is needed (with System.Object, etc.). I use the CoreTestAssembly from the TypeSystem tests as a "dummy mscorlib".

I think the ILVerify tests should use the real System.Private.CoreLib.dll/System.Runtime.dll.

Thanks! ...still WIP, I pushed a change, which fixes some of the things, the last two are missing (theory + project reference to .il), i'm working on them.

I pushed a new version with the ILMethodTester.cs file, which is a theory+memberdata based test scaffolding. With that writing new test basically means: just add the IL code, follow the naming conventions described in the comments for the ILReader.GetMethodsWithInvalidIL and ILReader. GetMethodsWithValidIL methods and that’s it, ILMethodTester.cs takes care of the rest.
If this reaches a state where we are happy with it, I will add a short “how to add new tests” section to the readme file.

LGTM otherwise. Thanks!
@MichalStrehovsky Would you mind taking a look as well?

I have a question:
Is there a way to somehow improve the feedback on test executions? Currently if we will have let's say 500 test methods with valid IL code than the TestMethodsWithValidIL theory will run 500 times and we will have 500 lines with that method name in VS in Test Explorer (or on the console), but nothing more. TestCase.MethodName is actually intended for logging (but I don't use it currently). What would be the preferred way to log that in every test execution? I guess that would be useful.

we will have 500 lines with that method name in VS in Test Explorer (or on the console), but nothing more.

I think it has to do with TestCase being opaque type that xunit does not know how to deal with, related to my comment https://github.com/dotnet/corert/pull/3725#discussion_r118936501.
The output for public void Test1(TestCase valueName) where TestCase is not serializable is like this - you cannot tell which one is which:
Passed   repro.UnitTest1.Test1(valueName: TestCase { })
Passed   repro.UnitTest1.Test1(valueName: TestCase { })

The output for public void Test1(string valueName, int x) is like this:
Passed   repro.UnitTest1.Test1(valueName: "Hello", x: 1)
Passed   repro.UnitTest1.Test1(valueName: "World", x: 2)

I see. I looked at IXunitSerializable but I thought adding a bunch of extra code to make one line pretty (this one: retVal.Add(new TestCase[] { newItem }); ) is a bad trade-off. But if it also gives us nice outputs than it's definitely worth it. I will implement IXunitSerializable.

I revisited the part with IXunitSerializable:

Since one property of the test parameter is a MethodDefinitionHandle it’s hard to serialize it
I thought about getting rid of the MethodDefinitionHandle and store that information as a basic type, but the code this leads to became ‘not nice’.
I also noticed that when a test fails xunit actually prints the data passed to the method (it basically does a ToString() on every property) -> we will see which method fails.
So I would say: we should not implement IXunitSerializable.
Additionally, I would add ITestOutputHelper to the constructor and log the method name in the first line of the two test methods (https://xunit.github.io/docs/capturing-output.html). This would give us enough info on which methods are tested and which one is failing.

So in sum if no one disagrees I would push a last change with:

Adding ITestOutputHelper to ILMethodTester
Do the fix described here https://github.com/dotnet/corert/pull/3725#pullrequestreview-40823110

Since one property of the test parameter is a MethodDefinitionHandle it’s hard to serialize it

MethodDefinitionHandle is just a wrapper around metadata token. You can convert it to int using MetadataTokens.GetToken, and serialize the int.

You can convert it to int using MetadataTokens.GetToken, and serialize the int.

That is what I needed! Thanks.


Version NetCore 3.1    ???    -->   net5  or net6 preview?? please update

Some details
How many services are in your application? (including things like databases, redis):

[ ] 1-2
[ ] 3-5
[ ] 6-10
[ ] 10+

What did you use tye for?

[ ] Local development
[ ] Deployment

How is your code organized?

[ ] One service per repo
[ ] Many services in one big repo
[ ] Other (please explain)

What did you think of tye?

@WuMianRen Are you requesting that the Tye CLI/host itself move to .NET 5/6, or something else?  As .NET Core 3.1 is in LTS for quite some time, and overlaps .NET 6 which will also be a LTS release, I expect that we'd move to .NET 6, but not until it GAs later this year.  That said, I'm not sure yet how we'll manage, say, arm64 vs. amd64 flavors of .NET; it's something that needs some investigation.

@philliphoff could Tye at least run with .NET 5?  that is current recommended even for MacOS.  When I run with just .NET 5 I see this:
It was not possible to find any compatible framework version
The framework 'Microsoft.AspNetCore.App', version '3.1.0' was not found.

The following frameworks were found:
5.0.9 at [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]

You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at:

https://aka.ms/dotnet-core-applaunch?framework=Microsoft.AspNetCore.App&framework_version=3.1.0&arch=x64&rid=osx.11.0-x64

@paulyuk Where's the recommendation for using .NET 5 on Mac?  (Not questioning, but curious given it's not a LTS release.) I don't believe that .NET Core 3.1 apps can "just run" on .NET 5 via configuration, as one could do with .NET Framework.  So we'd either have to move Tye to .NET 5, or multi-target and multi-release Tye for both Core 3.1 and 5.  Then the question would be, if 5, why not 6 (given we're already at Preview 7) and that is going to be a LTS release?  And then, if 6, is that arm64 (M1-compatible) 6 or amd64 6?  I have a branch that is a PoC for arm64 6 support so that I can be productive on my M1 Mac, but it would require much more testing to consider it "ready for release", and then the question is still how to best to support the various flavors of 6.

@philliphoff
ok。thakn you
First, I learned about tye from dapr
Then start the research on it
But as more programs are developed and deployed
My native environment began to become complex
SDKs of multiple dotnets appear (e.g. 2.1 2.2 3.1 5.0 6.0 preview 1-6)
Sometimes I don't want so many SDKs on the server
So I put forward this issue, and think that type follows the life cycle of NETCORE, at least in terms of version
But you have replied, and I will update it to the LTS of net6
So this issue is meaningless
Thank you again


feat: base docs

Excellent work!

It seems that the Last updated label in the Details page at the top shows 1970 (first ts by default). Can we double check that once deployed it will change to the current time of the deployment or if we have to modify something - modify it prior to deployment
The grid for rollups has the zk sync one on the right with a gap after Polygon zkEVM. Lets fix that

as far as i understand we are checking for the last commit date on main for specific slug. Considering this is not on main yet the date is supposed to be 1970 as a default
it looks like this is the way flex arranges elements inside a container. There is no "empty" element in the middle that cannot be seen.  If we want them reordered in a specific way let's ask somebody from the frontend devs to modify the css correctly.


Switch to headless Chrome for blocklyeditor unit tests

We currently use phantomjs for the Blockly unit tests, but the developer has since abandoned the project. There is also a really annoying bug in phantomjs on macOS that causes the tests to take minutes to run (every exit has a multiple second delay). We should investigate using headless Chrome to run the unit tests and move off of phantomjs.

+1  (absolutely).
== Hal
Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
On Thu, Dec 20, 2018 at 5:56 PM Evan W. Patton<EMAIL_ADDRESS>wrote:

We currently use phantomjs for the Blockly unit tests, but the developer
has since abandoned the project. There is also a really annoying bug in
phantomjs on macOS that causes the tests to take minutes to run (every exit
has a multiple second delay). We should investigate using headless Chrome
to run the unit tests and move off of phantomjs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mit-cml/appinventor-sources/issues/1485, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAwLtxTOdYesP8EWugX8eVa8EkNnZhCKks5u7BWBgaJpZM4ZdC7W
.


Listen on local IPv6 and IPv4 simultaneously

Now proxy listening only on IPv4 (<IP_ADDRESS>), but not on IPv6. It seems by default windows uses IPv6 DNS address.

It's safer, but it makes it very difficult to support dualstack networks.


How to get the extractive summary

Hello, I can train the model, I just get a label of extractor, but I can't find how to get the first phrase extrator summay .Could you tell me how to fix it?

Please refer to the paper to better understand how extractor/abstractor works. I don't quite understand your questions. Feel free to reply further details and I'll try my best to help.

closing due to no further discussion.


I've manually checked the files here, and ran a virustotal scan on all of them, and had no malware reports. Any reason you believe this is a virus particularly?

the insane amounts of obfuscated code in main.js

No, not jszip.min.js, im talking about main.js

I believe i may have been mistaken, that zip library is indeed legit.


Update Readme.md

Hello, your Readme.md does not have a space at the end and it is causing me to lose sleep at night. My midnights are filled with Paranoia from not adding the space. I have slept a total of 3.5 hours this week and my doctor and my therapist and my physician and my mom are about to knock me out so that I can rest. Please fix this space so that I can finally sleep at night. thanks

lmao


Support for Transport NSW (Australia) travel information

Description:
New sensor to enable pulling transport information from Transport NSW (Australia) on Bus, Train or Ferry leave times.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
- platform: transport_nsw
  name: 'Bus 139'
  stopid: '209677'
  route: '139'
  apikey: !secret transport_api

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @Dav0815,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

@Dav0815 Are you aware that this PR is empty?
If that is the case and on purpose, you might want to add the "WIP: " tag to indicate it is a work in progress.


[Feature Request] A way to drag an object along a single axis

[Feature Request] A way to drag an object along a single axis
Hi,
I'm trying to make an object be dragged only along one axis. I want it to be able to get translated using some transform manupulators (like arrows) pointing in each axis similar to any 3D editor. I'm trying to do this in normal ViroViewScene, no AR/VR. Any idea if this can be done using what we have currently (version 1.11.0)? Also on the topic of transform manipulators, is there a way to make them render on top the object. Right I'm just making them long enough to extend beyond the cube.
Screenshot from a 3D editor and my scene.

Update: The thing I did was that I set the dragging type to FIXED_TO_PLANE. Then I change only the x,y or z coordinate of the parent cube depending on which arrow was dragged. After that I set the arrow position back to (0,0,0) so that is stays in the center of the cube. This mostly works but sometimes a weird bug happens. After i bring the arrow back to (0,0,0) it leaves an afterimage on the position where I really dragged it. The hitbox stays on the actual arrow which is on the cube. The afterimage stays there and moves along which the cube. Here's the code I use to set a dragListener to each handle and a gif of what's happening.
`handle.setDragType(Node.DragType.FIXED_TO_PLANE);
handle.setDragPlanePoint(new Vector(0f, 0f, 0f));
handle.setDragPlaneNormal(planeNormal);
handle.setDragListener(new DragListener() {
@Override
public void onDrag(int i, Node node, Vector local, Vector world) {
Vector oldPos = parent.getPositionRealtime();
Vector newPos;
if(lineToDrag.x == 1f) {
newPos = new Vector(world.x, oldPos.y, oldPos.z);
} else if(lineToDrag.y == 1f) {
newPos = new Vector(oldPos.x, world.y, oldPos.z);
} else {
newPos = new Vector(oldPos.x, oldPos.y, world.z);
}
parent.setPosition(newPos);
            node.setPosition(new Vector(0f, 0f, 0f));
        }
    });`

He @toniuyt123, thanks for reaching out!
Currently all dragging callbacks implement their own dragging behaviors (the renderer actually drags the object). It may be possible to overwrite the object's position in the onDrag callback as you have done above.
That being said, the above situation is a bit strange, could you share with us the full code? (For example, We're not sure what the handle is etc).

Indeed that was the problem. I decided to go with this solution. I added a clickListener to the Handled so they don't transfer the event to the cube and when we have a CLICK_UP I set the it's position back to 0. It still appears away form the origin when dragging sometimes but when I release it goes back and doesn't leave a copy. I guess setting the handle position to 0 in the onDrag() function isn't enough to make it appear like it doesn't move all the time. This will do for now, however, thanks for your help.
handle.setClickListener(new ClickListener() {
            @Override
            public void onClick(int i, Node node, Vector vector) {

            }

            @Override
            public void onClickState(int i, Node node, ClickState clickState, Vector vector) {
                if(clickState.equals(ClickState.CLICK_UP)) {
                    node.setPosition(new Vector(0f, 0f, 0f));
                }
            }
        });


Shorten code

Not much shorter - but every line in this >3000 LOC class which is gone is a good line ;-)
Also this way resolveTitle() could be moved outside this class and save a dozen more lines ..

We lose 2 lines, true. But we gain a function call every time we call the method.
The file is huge. But tweaking around the edges isn't the way to fix this.
If we move out all the static Intent constructors for example we'd save a lot more lines and keep the complexity of the code the same.

A function call is cheap and this method is only called once in onCreate
Sure 2 lines is not much but A penny saved is a penny earned .. also this way you can easily move the function in a separate class now and gain a dozen more lines

You can get rid of the switch statement by adding the string resource to the enum.
    enum Action {
        COMPOSE(R.string.compose_title_compose),
        REPLY(R.string.compose_title_reply),
        REPLY_ALL(R.string.compose_title_reply_all),
        FORWARD(R.string.compose_title_forward),
        EDIT_DRAFT(R.string.compose_title_compose);

        private final int titleResource;

        Action(@StringRes int titleResource) {
            this.titleResource = titleResource;
        }

        public int getTitleResource() {
            return titleResource;
        }
    }

Then setTitle() becomes:
    private void setTitle() {
        setTitle(mAction.getTitleResource());
    }

Nice idea - doing now exactly this


FI-1273: Async UI updates

This branch updates the UI to poll for results while tests are running and show a progress bar, along with the associated backend improvements to support this.

Codecov Report

Merging #23 (9b83f0b) into main (c169ef0) will increase coverage by 0.04%.
The diff coverage is 97.05%.

:exclamation: Current head 9b83f0b differs from pull request most recent head adcd5ef. Consider uploading reports for the commit adcd5ef to get more accurate results

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   94.22%   94.27%   +0.04%
==========================================
  Files          83       84       +1
  Lines        1819     1850      +31
==========================================
+ Hits         1714     1744      +30
- Misses        105      106       +1

Impacted Files
Coverage Δ

lib/inferno/apps/web/serializers/test_session.rb
100.00% <ø> (ø)

...pps/web/controllers/test_sessions/last_test_run.rb
91.66% <91.66%> (ø)

lib/inferno/apps/web/controllers/test_runs/show.rb
100.00% <100.00%> (ø)

...pps/web/controllers/test_sessions/results/index.rb
100.00% <100.00%> (ø)

lib/inferno/apps/web/router.rb
95.45% <100.00%> (+0.21%)
:arrow_up:

lib/inferno/apps/web/serializers/test_group.rb
100.00% <100.00%> (ø)

lib/inferno/apps/web/serializers/test_run.rb
100.00% <100.00%> (ø)

lib/inferno/apps/web/serializers/test_suite.rb
100.00% <100.00%> (ø)

lib/inferno/dsl/runnable.rb
94.40% <100.00%> (+0.09%)
:arrow_up:

lib/inferno/entities/test.rb
87.32% <100.00%> (+0.36%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c169ef0...adcd5ef. Read the comment docs.


Add a helm chart for DC website

Following the README from this file, the helm chart in this PR was installed with the result below.
https://dc-website-2022-12-08.alexc.site/
Some assumptions being made.

Only supports single ingress (no MCI for now).

https://github.com/datacommonsorg/website/tree/master/build/helm is outdated and should be deleted during followup cls.


Add contact us page.

Category

[ ] Documentation
[ ] Resource Addition
[x] Codebase
[x] User Interface
[x] Feature Request

Description
Want to add a contact us page where the users can be in touch with us . Please assign me this issue under JWOC ' 24

@Sneha123-zudo Good idea. But currently, we don't want to implement it to the website as we have the social links and GitHub Discussions to help with that. So, we're closing this one.


developer.log outputs extra quotes

first:
import 'dart:developer' as _dev;

run:
    _dev.log('XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXSXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX');
    _dev.log('XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX');

out put:
[log] "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXSXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
[log] XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

For the first time, there are more quotation marks at both ends of the output.

flutter doctor -v

[✓] Flutter (Channel stable, 2.2.3, on macOS 11.5.2 20G95 darwin-arm, locale zh-Hans-CN)
    • Flutter version 2.2.3 at /Users/pptutor1/flutter
    • Framework revision f4abaa0735 (2 months ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/pptutor1/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (2 available)
    • Muhuai的iPhone (mobile) • 315176f9be1f5f8fa0a61b9ab35e61b0454b9f9d • ios            • iOS 14.7.1
    • Chrome (web)           • chrome                                   • web-javascript • Microsoft Edge 93.0.961.38

• No issues found!

/cc @bkonyi

any update?

same

I'm unable to reproduce this with the standalone VM on Linux or an Android Flutter application.
@mo-ah-dawood @xSILENCEx are you both encountering this on iOS devices? Where are you seeing this output?

run on different physical devices:
_dev.log('operatingSystem:${Platform.operatingSystem}');
final String str = 'X' * 1000;
_dev.log('XXXXXXXXXXXXXXXXXX');
_dev.log(str);

output:
[log] operatingSystem:ios
[log] XXXXXXXXXXXXXXXXXX
[log] "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

[log] operatingSystem:android
[log] XXXXXXXXXXXXXXXXXX
[log] "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

I'm unable to reproduce this with the standalone VM on Linux or an Android Flutter application.
@mo-ah-dawood @xSILENCEx are you both encountering this on iOS devices? Where are you seeing this output?

@bkonyi  Maybe the previous String is not long enough
run on different physical devices:
_dev.log('operatingSystem:${Platform.operatingSystem}');
final String str = 'X' * 1000;
_dev.log('XXXXXXXXXXXXXXXXXX');
_dev.log(str);

output:
[log] operatingSystem:ios
[log] XXXXXXXXXXXXXXXXXX
[log] "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

[log] operatingSystem:android
[log] XXXXXXXXXXXXXXXXXX
[log] "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

[log] operatingSystem:macos
[log] XXXXXXXXXXXXXXXXXX
[log] "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

@xSILENCEx I'm still unable to reproduce on Linux, Android, and OSX. Where are you seeing these logs output? Are they on a terminal, an IDE debug console, the DevTools or Observatory logging pages, etc?

@xSILENCEx I'm still unable to reproduce on Linux, Android, and OSX. Where are you seeing these logs output? Are they on a terminal, an IDE debug console, the DevTools or Observatory logging pages, etc?

yes, on vscode debug console

After testing, this only appears on vscode

then I tried to use print, it output:

cc @DanTup who might have a better idea as to what's going on if this is something you're only seeing in VS Code.

Yeah, there's definitely a VS Code DAP bug here - I've opened https://github.com/Dart-Code/Dart-Code/issues/3741. I'll keep this issue open until I've verified the SDK DAP (which will soon replace the Dart-Code one) doesn't have the same issue.

Confirmed the SDK DAP doesn't have this issue, so closing this. The VS Code issue is also fixed for the next release of the VS Code extension. Thanks!


Create footer

Add a footer with the standard links about the library's

Privacy Policy
Rules and Regulations
Policy on Patron-Generated Web Content
[Terms and Conditions](Terms and Conditions)

Include also the language "An NYC Space/Time Directory project."
Include also the Library's trademark: © The New York Public Library, Astor, Lenox, and Tilden Foundation 2013-2016 (not sure how this is done in other footers -- am assuming there's a way that the date updates automatically)
This footer will need to be included on all S/T pages so ideally we'll be able to pick it up as a template and drop it in other projects. I'm also including this ticket in the repo for Maps by Decade.
Can use footer on this page as reference: http://transcribe.oralhistory.nypl.org/

Created!


Newest JSII image has corrupted AWS CLI

Describe the bug
Open a new container using latest image. Type the command:
aws s3 ls

Result is :
rosetta error: failed to open elf at /lib64/ld-linux-x86-64.so.2
 Trace/breakpoint trap

(image is authenticated with Access Key and Session token in environment variables)
Regression Issue

[ ] Select this option if this issue appears to be a regression.

Expected Behavior
A list of buckets in the authenticated account
Current Behavior
rosetta error: failed to open elf at /lib64/ld-linux-x86-64.so.2
Trace/breakpoint trap
Reproduction Steps
Authenticate environment
aws s3 ls
Possible Solution
A quick search of the error message on the web suggests the issue could be an x86/arm mix up issue.
Additional Information/Context
Image Info:
public.ecr.aws/jsii/superchain
1-bookworm-slim
sha256:e36c4b9d76a7712f31fea38b587da511cd9bb92386a8bebec55763831d0bd346
f05f7edf15b5
2 days ago
4.65GB
It appears this may also have been an issue in: sha256:9ff38d9c44e10394e7c7bd242c265fc8af856a7d5b49607f6351db4828b2a37
I'm reasonably certain this has worked in the past - the CLI is installed as it attempts to run and then fails. This is the simplest symptom to isolate - the problems initially manifested when our long time scripts using integ-runner started failing with odd missing module errors.
SDK version used
N/A
Environment details (OS name and version, etc.)
Full image info shown above

I've gotten the SHA for some older images and this has been consistent behavior for a while and now appears unrelated to issues I saw running integ-runner recently. I'll close this. If I can demonstrate an issue running integ-runner that is newly introduced I'll open a new Issue. Thanks.


Added sensor support for the gogogate2 temperature

Description: As a user of the gogogate2 interface I want to retrieve the temperature data that is available from gogogate2 api.
Related issue (if applicable): fixes #NA
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#NA
Example entry for configuration.yaml (if applicable):

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ x] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ x] Tests have been added to verify that the new code works.

Hi @krotte1,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hi @krotte1,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


Laziness

We are paying to calculate the attributes even when the implementation is noop.  Can we do better?  Something like what log4s / log4cats do with macros?

I had a similar task at work. We solved it with overloading:
trait Trace[F[_]] {
  protected def spanInternal[A](name: => String, params: => Seq[TraceParam], fa: F[A]): F[A]

  final def span[A](name: => String)(fa: F[A]): F[A] =
    spanInternal(name, Nil, fa)

  final def span[A](name: => String, param1: => TraceParam)(fa: F[A]): F[A] =
    spanInternal(name, Seq(param1), fa)

  final def span[A](name: => String, param1: => TraceParam, param2: => TraceParam)(fa: F[A]): F[A] =
    spanInternal(name, Seq(param1, param2), fa)

  // and so on
}

This option just works, but it's far away from the perfect solution. I guess macros is more suitable.
scala-logging has some good example, both in scala 2 and scala 3: https://github.com/lightbend/scala-logging/blob/main/src/main/scala-3/com/typesafe/scalalogging/LoggerMacro.scala

I'm most familiar with log4s, but it's similar to LoggerMacro.  I suspect log4cats is the closest to what we need to do.  It's similar to those other two, but its return types are effectful, like ours.  Pretty sure our macros would need some F.unit instead of ().
I hate to introduce this complexity, but I strongly suspect it's going to be worthwhile if we want to get this into major libraries and not worsen the experience.

Resolved by #22


Unable to fetch stage details when using string interpolation in pipeline

I added the following in my .drone.yml:
environment:
  build_number: ${BUILD_NUMBER}

and this shows up in my logs:
{"commit":"bd36d59f700cdf217d8efc030ebe3d4dec7b4fc0","event":"push","level":"debug","msg":"webhook parsed","name":"bazare-public","namespace":"tjimsk","time":"2019-01-04T21:15:04Z"}
{"commit":"bd36d59f700cdf217d8efc030ebe3d4dec7b4fc0","event":"push","level":"debug","msg":"trigger: received","ref":"refs/heads/master","repo":"<repository-name>","time":"2019-01-04T21:15:04Z"}
{"fields.time":"2019-01-04T21:15:06Z","latency":1589002566,"level":"debug","method":"POST","msg":"","remote":"<IP_ADDRESS>:51760","request":"/hook","request-id":"596a9389-0fe3-4f72-b3c8-a815e94c1e15","time":"2019-01-04T21:15:06Z"}
{"level":"debug","machine":"drone-74666b56c4-lqt8k","msg":"manager: accept stage","stage-id":2,"time":"2019-01-04T21:15:06Z"}
{"level":"debug","machine":"drone-74666b56c4-lqt8k","msg":"manager: stage accepted","stage-id":2,"time":"2019-01-04T21:15:06Z"}
{"level":"debug","msg":"manager: fetching stage details","step-id":2,"time":"2019-01-04T21:15:06Z"}
{"arch":"amd64","build":2,"error":"runtime error: invalid memory address or nil pointer dereference","level":"error","machine":"drone-74666b56c4-lqt8k","msg":"runner: unexpected panic","os":"linux","pipeline":"public","repo":"<repository-name>","stage":1,"time":"2019-01-04T21:15:06Z"}
{"arch":"amd64","level":"debug","machine":"drone-74666b56c4-lqt8k","msg":"runner: polling queue","os":"linux","time":"2019-01-04T21:15:06Z"}
{"arch":"amd64","kernel":"","level":"debug","msg":"manager: request queue item","os":"linux","time":"2019-01-04T21:15:06Z","variant":""}
{"level":"debug","msg":"events: stream eror","request-id":"729b25b5-260a-457c-be9e-f1b51bb7b4dc","time":"2019-01-04T21:16:12Z","user.admin":true,"user.login":"tjimsk"}
{"level":"debug","msg":"events: stream closed","request-id":"729b25b5-260a-457c-be9e-f1b51bb7b4dc","time":"2019-01-04T21:16:12Z","user.admin":true,"user.login":"tjimsk"}

The pipeline gets stuck instead of reporting it can't find the variable.  That should be handled better as even the logs don't really say that much.

DRN

Gotcha.  Thx.
However, should it stop the pipeline from starting?

we have an existing issue for this at https://github.com/drone/drone-yaml/issues/13


How to Change Default Color from #f63366 to Another?

Hello - is there an easy way to modify the color of #f63366 to another color of choice?

Are you talking about the TabBar or the Stepper Bar?
Either are possible, but better stick with Streamlit's color conventions. If you would you can propose an update and make a pull request.


Thread.current is unnecessarily noasync

https://github.com/swiftlang/swift-corelibs-foundation/blob/c28bf23e18e217709dddd5c2c1b3ee1f2a4151cb/Sources/Foundation/Thread.swift#L85
Thread.current is very useful as a debugging mechanism to understand the ordering of code running concurrently and/or in parallel. This is very useful to use from async functions.
Sure, the workaround is just
extension Thread {
    public static var currentThread: Thread {
        return Thread.current
    }
}

but that shouldn't be necessary.

Maybe it's useful for debugging, but it's wrong to conflate a task with a thread. Making this API available in async contexts seems like a mistake to me. @phausler did the original audit, though, so pulling him in for his opinion.


Calendar view

hello dears,
is there any possibility of having a calendar view in AT UI?
thanks :)

sorry, Calendar component is not included in the new version v1.4.0.
i think you can use a third-party calendar temporarily. :(
btw, which type of calendar view do you want?

ah, ok.
like this one, https://github.com/charliekassel/vuejs-datepicker,
the problem, is that, I have to customize it in order to be consistent with AT UI :\

@koppthe Does the Component Wish List #3  consider adding Calendar?

@yoyo837 of course, but no recently


Can't add poolboy as dependence

I don't know why, but it occurred. I add poolboy as  my dependence, use your tool to create a release, I found it can't add poolboy as it's dependence. You can try it.

No, included_applications will not "simply load them". It does more. You should use load as the type to have the app only load when the release is run: http://www.erlang.org/doc/man/rel.html
This is supported in relx by simply adding load to a tuple with the app name in the relx list of applications: {release, {rel_name, "vsn"}, [app_name, {another_app, load}]}.

Also see http://learnyousomeerlang.com/the-count-of-applications#included-applications

@tsloughter Yeah I've mentioned in other places since this one was closed about what included_applications is actually for. Learned that the hard way :/

Ah ok. Someone linked me to this in the Elixir channel after they said it appeared to be your suggested solution after I told them not to use it :)

Damn it haha. I'll have to update the docs to talk about it then. Thanks for running interference :). Normally I'm in IRC during the day, but today was heads down on work projects.

It was me :disappointed: So what is the suggested approach now @bitwalker?

@aaronjensen Put all of your dependencies in :applications. If you do not want an OTP application you have as a dependency to start, then you'll want to use the suggestion @tsloughter made:

Create rel/relx.config
Put {release, {your_app_name, "your_app_vsn"}, [your_app_name, {another_app, load}]}. in relx.config.

I haven't tested this myself, so it may break some assumptions with how I'm merging in relx.config, but if so, just open an issue for it. On my roadmap is providing a better release configuration mechanism for exrm, probably before I release 1.0.


[UI] Display Kubernetes Context Name in MeshSync Flush Data confirmation modal

Current Behavior
In the Settings page under the Environments tab, users can click to flush the MeshSync data for a specific Kubernetes context that they have connected to Meshery. When they click to flush this data, only the data for that context is removed, but the confirmation model that shows displays to the user does not show the name of the Kubernetes context.
Desired Behavior
The confirmation model should display the Kubernetes cluster name in quotation marks, so that the user is confident that only MeshSync data for the specific (currently selected) Kubernetes cluster will be deleted.
Implementation

Acceptance Tests

Confirmation title bar should be:
Flush MeshSync data for "<k8s cluster name">?
Detailed message shown should be:

Are you sure that you want to remove MeshSync data for the "<k8s cluster name>"?

Fresh MeshSync data will be repopulated for this context, if MeshSync is actively running on this cluster.

Screenshot
Here's a screenshot of the current implementation that is missing the cluster name.

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

hello @leecalcote in 2 days  , as my exams come to a halt . I will be back here to finish this one 💯 .
PS:- I am missing this place.

Can I work on this?

hi @leecalcote I am on this now can you please assign?


feat:Exceptions support in requirement test

Please review -

Added support for exceptions tag in  section
Added exception field for testing in sample_requirement.log with an incorrect value, Incorrect value here is not generating an error as field is in exception section(vendor_product)
Unit tests updated

<field name="app" value="SNMP DUMMY_APP"/>
            <field name="transport" value="tcp"/>
            <field name="protocol" value="ip"/>
            <field name="vendor_product" value="Incorrect vendor product"/>
         </cim_fields>
         <missing_recommended_fields>
            <field>bytes</field>
            <field>bytes_in</field>
            <field>bytes_out</field>
         </missing_recommended_fields>
         <exceptions>
            <field name="vendor_product" value="Incorrect vendor product" reason="testing exceptions"/>
         </exceptions>

:tada: This PR is included in version 1.10.0 :tada:
The release is available on:

v1.10.0
GitHub release

Your semantic-release bot :package::rocket:


fix(util-mock): fix chokidar.watch choking on mock db-journal

fixes #11657

Description of changes
This fixes the dynamo local journal causing lstat issues.
Issue #11657

Description of how you validated changes
I tested with adding many transactions to the system. With the fix the mock setup doesn't error when the journal appears briefly.
Checklist

[x] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[x] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for tracking this down and contributing a fix @joekiller!
Something went wrong with our PR automation, would you mind rebasing and force pushing again to see if that resolves the issue?

you mind rebasing and force pushing again to see if that resolves the issue?

@jhockett I have done as requested. I'm unsure if the ci issue is resolved.

Thanks for trying @joekiller, it's still not executing the full PR workflow in CircleCI, but I'm not sure why.
Here's the error message:
Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.
Please sign out of CircleCI and log back in with your VCS before triggering a new pipeline.

Did you disable a permission related to CircleCI in your GitHub account settings?

@joekiller were you able to check your Circle CI configuration?

@jhockett @danielleadams apologies it was unclear to me that I needed to grant circle ci authorization to read my public information. I've done so now and will try to get it to trigger again with a force push.

@joekiller no worries - I've started the integration tests for you.


Add newer glibc versions

I think we should add at least 2.36 & 2.39, c.f. https://github.com/mayeut/pep600_compliance/issues/362
On the other end, 2.5 and 2.12 can likely be dropped, as they're completely gone for Python >=3.7, and used for less than 1% of downloads for even older Python versions.
2.23 would be the next candidate for removal after that - it's only really relevant for the Python 3.5 plot, which is arguably not that important anymore either (as 3.5 is ~0.4% of all downloads), and could probably be dropped itself as well.

versions added at 95a4cc4a0f570d097a6cc95bec70161257297802
removals will happen at a later date.

Thanks a lot!


When perPositionHeight and ImageMaterialProperty are used together to create a polygon texture, the texture is displayed abnormally

When perPositionHeight and ImageMaterialProperty are used together to create a polygon texture, the texture is displayed abnormally, and it is strangely stretched and rotated. But if perPositionHeight is not used, the texture rendering is the result I want when it is attached to the ground and when it is not attached.
let polygonGraphic = self.viewer.entities.add({
name: '2',
polygon: {
hierarchy: polygonCoords,
perPositionHeight: true,
material: new Cesium.ImageMaterialProperty({
image: renderCanvas,
repeat: Cesium.Cartesian2(1.0, 1.0),
transparent: true,
color: Cesium.Color.WHITE.withAlpha(1),
})
}
})

Thanks for posting! Since it's unclear whether this is a bug in Cesium, please open a thread in our community forum. More people keep up with new threads on our forum so you're more likely to get on there. If you include a full Sandcastle as well as your texture it might be easier to figure out the issue.


Uncaught exception

https://github.com/wirepas/wirepas-mqtt-library/blob/de70261fdca19282b4b58cde77c7a99946c55d7c/wirepas_mqtt_library/wirepas_network_interface.py#L210
This call might raise a RuntimeError which is not handled.

Hello!
Yes you are right.
But it shouldn't never happen. It should happen if the https://github.com/wirepas/backend-apis/blob/master/gateway_to_backend/protocol_buffers_files/config_message.proto#L116 is different than 1.
But since we have defined the protobuf gateway api, we have never break the backward compatibility, so version should be 1 everywhere.
But I realized that this field is poorly documented.
If you faced this issue, I guess you have your own gateway implementation.
But anyway I will add it soon.
Thanks for the bug report.
Gwendal

Hi,
that actually happened when i published an empty payload to gw-event/status/<some gw id> in order to remove the retained configuration of a gateway which was no longer in use.


[stable/kafka-manager]: add Kafka Manager chart

Signed-off-by: Giacomo Guiulfo<EMAIL_ADDRESS>
What this PR does / why we need it:
This adds the Kafka Manager chart. It's is based on #2917 and this, but includes several enhancements, such as:

The new image supports newer versions of Kafka (like 1.0.0+)
Service Accounts.
Highly customizable automatic cluster feeding through the API.
Enhanced liveness/readiness probes.
Documented values in the README.md.
Optional Zookeeper dependency for the setup.
And some other small chores...

Special notes for your reviewer:
As I mentioned, this PR is similar to #2917. But I still decided to open a different one since that other one has gone stale and doesn't include as many features.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @unguiculus

/assign @davidkarlsen

/ok-to-test

@unguiculus Those are all the available parameters. The reason why I decided to include them all (with default values), is because they all must be present on the POST request or otherwise the request won't work.

You could still provide a working configuration. What if they add another parameter? You'd need to update the chart.

@unguiculus Oh I see, yeah it might have to be updated if a new image supports more parameters.
But still, if the configuration is provided as a string as you suggested, the string will have to be updated as well, making it fall under the same problem.
Any ideas? Perhaps just a test to ensure the POST request succeeds?

Well the thing is that this POST request corresponds to an HTML form. It's not a fancy JSON API with proper documentation or helpful response messages (it responds with HTML). This way of configuration is not something intended but instead something that just "works".
The configuration provided with this chart is what the form has for default values, but still every single value can be configured independently as the user wants to from the values.yaml file. Also, users can still configure their clusters from the web UI, which is the typical way of doing it.

I see, but this sounds like a brittle solution. Kafka Manager can be configured with a config file. Why dont you do that?

@unguiculus True, but only very few things are configurable through the config file such the zkHosts and basicAuth. This chart allows those values to be configured through environmental variables.
However, it is not possible to configure clusters through the config file. I looked through the code and wasn't able to find anything helpful. There is an open issue about it: https://github.com/yahoo/kafka-manager/issues/244, in which people suggest doing the solution that this chart is employing.

Hi @maver1ck
All your comments were addressed, thanks for the review!
@unguiculus Could you take another look? Thanks!

Hi @giacomoguiulfo Thanks for fixing everything.
I don't have general LGTM permission (yet), so I can't help :(

@giacomoguiulfo
One more problem
+ curl http://kafka-manager-kafka-manager:9000/clusters -X POST -d name=default -d zkHosts=kafka-cp-zookeeper:2181 -d kafkaVersion=1.1.0 -d jmxEnabled=true -d jmxUser= -d jmxPass= -d jmxSsl=false -d logkafkaEnabled=false -d pollConsumers=true -d filterConsumers=false -d activeOffsetCacheEnabled=false -d displaySizeEnabled=false -d tuning.brokerViewUpdatePeriodSeconds=30 -d tuning.clusterManagerThreadPoolSize=2 -d tuning.clusterManagerThreadPoolQueueSize=100 -d tuning.kafkaCommandThreadPoolSize=2 -d tuning.kafkaCommandThreadPoolQueueSize=100 -d tuning.logkafkaCommandThreadPoolSize=2 -d tuning.logkafkaCommandThreadPoolQueueSize=100 -d tuning.logkafkaUpdatePeriodSeconds=30 -d tuning.partitionOffsetCacheTimeoutSecs=5 -d tuning.brokerViewThreadPoolSize=4 -d tuning.brokerViewThreadPoolQueueSize=1000 -d tuning.offsetCacheThreadPoolSize=4 -d tuning.offsetCacheThreadPoolQueueSize=1000 -d tuning.kafkaAdminClientThreadPoolSize=4 -d tuning.kafkaAdminClientThreadPoolQueueSize=1000 -d tuning.kafkaManagedOffsetMetadataCheckMillis=30000 -d tuning.kafkaManagedOffsetGroupCacheSize=1000000 -d tuning.kafkaManagedOffsetGroupExpireDays=7 -d securityProtocol=PLAINTEXT
/usr/local/script/addClusters.sh: line 4: curl: command not found

@giacomoguiulfo
One more problem
+ curl http://kafka-manager-kafka-manager:9000/clusters -X POST -d name=default -d zkHosts=kafka-cp-zookeeper:2181 -d kafkaVersion=1.1.0 -d jmxEnabled=true -d jmxUser= -d jmxPass= -d jmxSsl=false -d logkafkaEnabled=false -d pollConsumers=true -d filterConsumers=false -d activeOffsetCacheEnabled=false -d displaySizeEnabled=false -d tuning.brokerViewUpdatePeriodSeconds=30 -d tuning.clusterManagerThreadPoolSize=2 -d tuning.clusterManagerThreadPoolQueueSize=100 -d tuning.kafkaCommandThreadPoolSize=2 -d tuning.kafkaCommandThreadPoolQueueSize=100 -d tuning.logkafkaCommandThreadPoolSize=2 -d tuning.logkafkaCommandThreadPoolQueueSize=100 -d tuning.logkafkaUpdatePeriodSeconds=30 -d tuning.partitionOffsetCacheTimeoutSecs=5 -d tuning.brokerViewThreadPoolSize=4 -d tuning.brokerViewThreadPoolQueueSize=1000 -d tuning.offsetCacheThreadPoolSize=4 -d tuning.offsetCacheThreadPoolQueueSize=1000 -d tuning.kafkaAdminClientThreadPoolSize=4 -d tuning.kafkaAdminClientThreadPoolQueueSize=1000 -d tuning.kafkaManagedOffsetMetadataCheckMillis=30000 -d tuning.kafkaManagedOffsetGroupCacheSize=1000000 -d tuning.kafkaManagedOffsetGroupExpireDays=7 -d securityProtocol=PLAINTEXT
/usr/local/script/addClusters.sh: line 4: curl: command not found

Oh my bad. I just fixed it. It should be good now 👍

I found next thing.
Kafka manager is killed every minute or two
2018-11-15 08:09:26 +01:00 - Liveness probe failed: HTTP probe failed with statuscode: 401
 count: 3
 reason: Unhealthy

My configuration
zkHosts: "kafka-cp-zookeeper:2181"

clusters:
  - name: "default"
    zkHosts: "kafka-cp-zookeeper:2181"
    kafkaVersion: "1.1.0"
    jmxEnabled: "true"
    pollConsumers: "true"
    tuning: {}

basicAuth:
  enabled: true
  password: abc123

ingress:
  enabled: true
  hosts:
  - kafka-manager.domain.com
  annotations:
    external-dns.alpha.kubernetes.io/target: ingress.domain.com

/assign

@giacomoguiulfo
Hopefully last thing :)
Could we make a Chart in a way than diff without changing values will be empty ?
This is the diff after installation. There are two problems:

random job name
configmap change

kafka, kafka-manager-kafka-manager-bootstrap, ConfigMap (v1) has changed:
  # Source: kafka-manager/templates/configmap.yaml
  apiVersion: v1
  kind: ConfigMap
  metadata:
    name: kafka-manager-kafka-manager-bootstrap
    labels:
      app: kafka-manager-kafka-manager
      chart: kafka-manager-1.0.0
      heritage: Tiller
      release: kafka-manager
  data:
    addClusters.sh: |
      #!/bin/bash
      set -ex
-     echo "Running at<PHONE_NUMBER>5418"
+     echo "Running at<PHONE_NUMBER>5501"
      curl http://kafka-manager-kafka-manager:9000/clusters -X POST -d name=default -d zkHosts=kafka-cp-zookeeper:2181 -d kafkaVersion=1.1.0 -d jmxEnabled=true -d jmxUser= -d jmxPass= -d jmxSsl=false -d logkafkaEnabled=false -d pollConsumers=true -d filterConsumers=false -d activeOffsetCacheEnabled=false -d displaySizeEnabled=false -d tuning.brokerViewUpdatePeriodSeconds=30 -d tuning.clusterManagerThreadPoolSize=2 -d tuning.clusterManagerThreadPoolQueueSize=100 -d tuning.kafkaCommandThreadPoolSize=2 -d tuning.kafkaCommandThreadPoolQueueSize=100 -d tuning.logkafkaCommandThreadPoolSize=2 -d tuning.logkafkaCommandThreadPoolQueueSize=100 -d tuning.logkafkaUpdatePeriodSeconds=30 -d tuning.partitionOffsetCacheTimeoutSecs=5 -d tuning.brokerViewThreadPoolSize=4 -d tuning.brokerViewThreadPoolQueueSize=1000 -d tuning.offsetCacheThreadPoolSize=4 -d tuning.offsetCacheThreadPoolQueueSize=1000 -d tuning.kafkaAdminClientThreadPoolSize=4 -d tuning.kafkaAdminClientThreadPoolQueueSize=1000 -d tuning.kafkaManagedOffsetMetadataCheckMillis=30000 -d tuning.kafkaManagedOffsetGroupCacheSize=1000000 -d tuning.kafkaManagedOffsetGroupExpireDays=7 -d securityProtocol=PLAINTEXT || exit 1;
kafka, kafka-manager-kafka-manager-bootstrap-ed95b031, Job (batch) has been removed:
- # Source: kafka-manager/templates/job.yaml
- apiVersion: batch/v1
- kind: Job
- metadata:
-   name: "kafka-manager-kafka-manager-bootstrap-ed95b031"
-   labels:
-     app: kafka-manager
-     chart: kafka-manager-1.0.0
-     heritage: Tiller
-     release: kafka-manager
- spec:
-   template:
-     metadata:
-       labels:
-         app: kafka-manager
-         release: kafka-manager
-     spec:
-       serviceAccountName: kafka-manager-kafka-manager
-       restartPolicy: OnFailure
-       volumes:
-         - name: script-volume
-           configMap:
-             name: kafka-manager-kafka-manager-bootstrap
-             defaultMode: 0744
-       containers:
-       - name: kafka-manager-bootstrap
-         image: "zenko/kafka-manager:<IP_ADDRESS>"
-         imagePullPolicy: IfNotPresent
-         command: ["/usr/local/script/addClusters.sh"]
-         volumeMounts:
-           - name: script-volume
-             mountPath: "/usr/local/script"
-   backoffLimit: 20
+
kafka, kafka-manager-kafka-manager-bootstrap-27d2f6f1, Job (batch) has been added:
-
+ # Source: kafka-manager/templates/job.yaml
+ apiVersion: batch/v1
+ kind: Job
+ metadata:
+   name: "kafka-manager-kafka-manager-bootstrap-27d2f6f1"
+   labels:
+     app: kafka-manager
+     chart: kafka-manager-1.0.0
+     heritage: Tiller
+     release: kafka-manager
+ spec:
+   template:
+     metadata:
+       labels:
+         app: kafka-manager
+         release: kafka-manager
+     spec:
+       serviceAccountName: kafka-manager-kafka-manager
+       restartPolicy: OnFailure
+       volumes:
+         - name: script-volume
+           configMap:
+             name: kafka-manager-kafka-manager-bootstrap
+             defaultMode: 0744
+       containers:
+       - name: kafka-manager-bootstrap
+         image: "zenko/kafka-manager:<IP_ADDRESS>"
+         imagePullPolicy: IfNotPresent
+         command: ["/usr/local/script/addClusters.sh"]
+         volumeMounts:
+           - name: script-volume
+             mountPath: "/usr/local/script"
+   backoffLimit: 20

Hello @maver1ck
In my experience, it is a bad practice to use helm hooks. It often leads to timeouts when installing or upgrading (and therefore failures), especially when the chart is used as a dependency. That was my original implementation but decided to go forward with the hash name.
Since the configmap always changes (because of the echo date), then a new job always runs whenever installing or upgrading. It is also conflict free, and the previous job gets deleted. In a way, you can think of this as an "implementation" of the "helm.sh/hook": post-install, post-upgrade hook, but that won't cause you any issues.

@giacomoguiulfo
From my side consecutive installation of the same Chart should generate same config.
Random resource names make CI/CD more difficult.
What's the exact behaviour of the Job you want to achieve ?

@maver1ck Basically, if the ConfigMap doesn't change, the job will not run post-upgrade. That's why I made it dynamic.

Maybe it is good enough. My only concern is about failures and if data is lost. Would that mean I have to change the configuration even though I don't need to, to add the cluster back again?

I think if you lost configuration this means that you last ZK. (because configuration is stored there)
Then not working Kafka Manager is your smallest problem. ;)

Well, in that case, I can remove the date. The random job name is still needed though.

Yep. I tested all solutions and if changing configmap doesn't trigger job to run.
So we have only two options:

Random Job name
Hooks

I vote for 2.

@maver1ck I removed the line you mentioned and went with option 1. This is not the only chart that does this btw, see kafka's job. Let me know if this OK. Thanks for your reviews again.

/LGTM
(but probably I don't have right)

@cpanato @davidkarlsen
Could you please merge this Chart ?

I would say to update the labels to the new standard helm labels.
what do you think @davidkarlsen ?

Hello @cpanato. What exactly are these labels you are referring to? instance and managed-by?

@giacomoguiulfo
I think the answer is here:
https://github.com/helm/helm/blob/master/docs/chart_best_practices/labels.md#standard-labels

@cpanato I updated the labels to the new standard ones. Could you take another look over this PR? Thanks! cc @davidkarlsen @unguiculus

Why don't you use the offical image yahoo/kafka-manager?

@unguiculus
Where did you find official image ?

Sorry, I was wrong. There's indeed no official one.

Any chance this can get merged, or is there anything else to address? Thanks in advance :) @unguiculus

/lgtm


Good stuff..

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Add more test cases for streams functions and queries

Add test cases for the issue in #21817
Add test cases to cover all scenarios of let clause in query expressions

Assigned to Lasini Liyanage

Completed in https://github.com/ballerina-platform/ballerina-lang/pull/22614 ...


Resovle request, which was failed.

If occurred some error in resolve request, for example - server is unrechable, ocLazyLoad return deferred.reject;
But in future, even if server is reachable, if some module rerequest same dependencies, it will immidiately returned as rejected.
reject come from ocLazyLoad.js:803:37
@version v1.0.0-beta.2
This is a Bug or a Hint? And how I can redefine this beahiour - if the request failed,with the second same request was an attempt to resolve it.

hu that's really not what is supposed to happen. I wonder if it's because the browser caches the error and returns it everytime after that ?

I wonder if it's because the browser caches the error and returns it everytime after that ?
No, Browser don`t cache. I tested on several browsers, - Chrome with cache disabled, Firefox.. maby caching requests, Opera with cache disabled, MS IE not tested. I created custom function thet call $http.get request with same file, and it resolved normaly.

Ok, I'll check it out then, it's probably some internal caching inside the lib then :)
If you have a working use case (code or plunkr) it would help !

I can`t simulate this on plunkr because for investigate the problem we need to manage network or server for become unreachable.
Some code:
JS:

angular
.module('app', ['ui.router','oc.lazyLoad']);
angular.module('app')
.config(
[          '$stateProvider', '$urlRouterProvider',
function ( $stateProvider,   $urlRouterProvider ) {
$stateProvider
.state('sign', {
templateUrl: 'components/login/views/login.main.html',
}
})
.state('sign.forgotPassword', {
url: '^/forgot-password',
templateUrl: 'part.forgot-password.html',
resolve: {
deps: ['$ocLazyLoad',
function( $ocLazyLoad ){
return
$ocLazyLoad.load(['components/login/scripts/forgotPasswordCtrl.js']);
/* This is where a bug */
}]
}
});

HTML (login.main.html):

Test

Thanks, that should do it

Fixed!
It's weird that no one else ever reported this, because this bug was probably here since a really long time :)

I also met the same problem, have to solve


Samung Phones MediaLibraryService throws ForegroundServiceDidNotStartInTimeException

Version
Media3 1.1.1
More version details
api 'androidx.media3:media3-ui:1.2.0'
api 'androidx.media3:media3-exoplayer:1.2.0'
api 'androidx.media3:media3-exoplayer-hls:1.2.0'
api 'androidx.media3:media3-exoplayer-dash:1.2.0'
api 'androidx.media3:media3-exoplayer-ima:1.2.0'
api 'androidx.media3:media3-cast:1.2.0'
api 'androidx.media3:media3-session:1.2.0'
Devices that reproduce the issue
From Firebase Crashlitycs only :
Samsung (Galaxy S22 Ultra, S22+, S20+, S22 Ultra, S20+, S23 Ultra)
Phone that i do not have
Devices that do not reproduce the issue
Phones that i have tested : Samsung S21, Pixel 8, Motorola
Reproducible in the demo app?
No
Reproduction steps
I suppose when player start playing music. It's happened on some samsung devices as firebase crashlytics report
Expected result
No crash and no need for custom notification
I'm using MediaSessionService started in foreground using SessionToken(nInterface.getActivity(), ComponentName(nInterface.getActivity(), PlayerService::class.java))
Inside my service implementation i use ExoPlayer (androidx.media3:media3-exoplayer:1.2.0 ) and MediaSession.Builder for media3 notification with control. No extra custom notification implementation.
onForegroundServiceStartNotAllowedException listener does not trigger on any of my phone. I suppose default media3 notification should be enough
I can paste code if needed with my MediaSessionService implementation
Actual result
Playback crash with :

Fatal Exception: android.app.RemoteServiceException$ForegroundServiceDidNotStartInTimeException
android.app.ForegroundServiceDidNotStartInTimeException - Context.startForegroundService() did not then call Service.startForeground()

Media
Not applicable
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Duplicate of #167
Please check whether you have implemented playback resumption correctly (docs) specifically if you add the media button receiver, you have to implement the callback.
If this does not help please comment in the other issue and add a stack trace from Crashlytics.