Incorrect behavior using "all" variable value

Describe the bug
After updating the plugin to version 2.0 in the variable settings, the "All" option began to work incorrectly: now if you select "all", then all variable values are added to the query. In previous versions (before 2.0), there was a different behavior: when selecting "all" in the variable, operators with such a variable were not included in the query.
Versions
Grafana 8.5.10, plugin 2.0.1
Query
SELECT fromhost AS host, count(priority) AS priority
  FROM logs.syslog
 WHERE $__timeFilter(devicereportedtime)
       AND message LIKE '%$find_in_messages%'
       AND message LIKE '%$search_in_found%'
       AND fromhost IN ($host)
       AND priority IN ($priority)
       AND facility IN ($facility)
       AND syslogtag IN ($syslogtag)
 GROUP BY fromhost
 ORDER BY count(priority) DESC LIMIT 10

To Reproduce
Steps to reproduce the behavior:

Add variables of "query" type, enable "all" option in settings
Select "all" in the list of variable values
Add variables to sql query conditions
Check execution of query in the "query inspector"

Expected behavior
Waiting for the behavior of the plugin before version 2.0 using the "all" option in the variable (see description)
Screenshots

Additional context

@Catwoolfii The plugin no longer supports automatically removing template variables if all is selected. Please use $__conditionalAll(condition, $templateVar) to do the same thing. You can read more about the conditionalAll macro here: Macros


Enable the iPXE ping command

Description
Enable the built in ping command inside of the iPXE environment.
Why is this needed
Operators debugging network issues sometimes find it useful to be able to issue ping commands from the iPXE environment to verify network configuration.
How Has This Been Tested?
The added test exercises the change.
How are existing users impacted? What migration steps/scripts do we need?
No impact
Checklist:
I have:

[x] added unit or e2e tests

Looks good, thank you! would you mind adding this functionality to the doc? https://github.com/tinkerbell/boots/blob/master/docs/IPXE.md

Good catch! Done.


docs: move discord pill to top of readme

Can you do this same change in the Overview document of the docs?

@tylerslaton done


Add example of building Slurm on top of Rocky 8

Builds the latest Slurm V6 image on top of HPC Rocky 8 image and deploys a simple cluster using the image. This example is meant to be a demonstrator to show how it is possible to build Slurm.
Notes:

This calls ansible directly instead of using Slurm Packer module to avoid complexity of importing external Packer module.
This does custom ansible install instead of using ansible runner as python upgrade breaks selinux bindings when done from within a virtual environment.

Tested:

Manually run blueprint and test how cluster (srun hostname).
Added integration test that does deploy/destroy

Submission Checklist
Please take the following actions before submitting this pull request.

Fork your PR branch from the Toolkit "develop" branch (not main)
Test all changes with pre-commit in a local branch #
Confirm that "make tests" passes all tests
Add or modify unit tests to cover code changes
Ensure that unit test coverage remains above 80%
Update all applicable documentation
Follow Cloud HPC Toolkit Contribution guidelines #

To Reviewer: I will add documentation and integration test once you have given a first pass approval of the methodology of the blueprint.

I submitted test manually (build 4c971653-eee2-45f3-8d9c-1cb7c2634145) and it is passing.
I will update triggers once it is submitted.


InteractionManager.SourcePressed is obsolete while InteractionManager.InteractionSourcePressed doesn't work as well

What does this effect?
MRDesignLabs_Unity_Tools(master)/HUX
Unity editor version:
Unity 2018.1.6f1
Describe the bug
While using HUX toolkit in Unity project, I have faced an error in InteractionManager.cs:
Assets/Extern/MRDesignLab/HUX/Scripts/Interaction/InteractionManager.cs(131,57): error CS0619: `UnityEngine.XR.WSA.Input.InteractionManager.SourcePressed' is obsolete: `SourcePressed is deprecated, and will be removed in a future release. Use InteractionSourcePressed instead. (UnityUpgradable) -> InteractionSourcePressedLegacy'
As I change from 'SourcePressed' to 'InteractionSourcePressed' it gives me:
Assets/Extern/MRDesignLab/HUX/Scripts/Interaction/InteractionManager.cs(131,57): error CS0123: A method or delegate HUX.Interaction.InteractionManager.InteractionManager_SourcePressedCallback(UnityEngine.XR.WSA.Input.InteractionSourceState)' parameters do not match delegate `System.Action<UnityEngine.XR.WSA.Input.InteractionSourcePressedEventArgs>(UnityEngine.XR.WSA.Input.InteractionSourcePressedEventArgs)' parameters

Also, even it says (UnityUpgradable) -> InteractionSourceReleasedLegacy, API Updater doen't provide any possible solution/fix.


docs(Composition|Shorthand): improve pages

This PR:

renames Augmentation page to Composition because previous name it's not clear
adds a section about unhandled props to Composition page
updates comments on Shorthand Props page

Codecov Report

Merging #3707 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3707   +/-   ##
=======================================
  Coverage   99.83%   99.83%
=======================================
  Files         175      175
  Lines        3120     3120
=======================================
  Hits         3115     3115
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75740b8...fa0ff3b. Read the comment docs.


Optional argument syntax

The documentation page for functions shows two different syntaxes for named/optional arguments:

test_named(times: 1, data: 3.0);
testme(3, 2.0, 5.0, .rate = 6.0);

Which one is correct?

The first one is the new one. The second is the deprecated one which will be removed in 0.7.0

Is the doc being updated?

Yes, so where did you find the second one? It should be fixed.

Here:
https://c3-lang.org/language-fundamentals/functions/

Found it, it should be correct now.


405 Method Not Allowed

I'm trying to build manually the protobuf files with: buf generate --template buf.sdk.gen.yaml --include-imports -o /tmp/tmp-protobuf/cosmos-sdk ../cosmos-sdk-go/proto but keep getting Failure: 405 Method Not Allowed.
buf.sdk.gen.yaml is pointing to buf.build/prost/plugins/prost:v0.2.1-1 but https://buf.build/prost/ is empty. Has anything been removed since?
Thanks.

I assume this means that the buf/prost integration has changed yet again. Sigh.

I opened #429 to attempt to address this but the plugin at the new location is no longer working


Implement Basic Auth for HTTP Ingresses

Basic Auth; Follows haproxy ingress controller standard https://github.com/kubernetes/ingress/tree/master/examples/auth/basic/haproxy HAProxy Ingress read user and password from auth file stored on secrets, one user and password per line.
Each line of the auth file should have: user and insecure password separated with a pair of colons: <username>::<plain-text-passwd>; or user and an encrypted password separated with colons: <username>:<encrypted-passwd> Secret name, realm and type are configured with annotations in the ingress
Auth can only be applied to HTTP backends.
// Only supported type is basic
AuthType = "ingress.kubernetes.io/auth-type"

// an optional string with authentication realm
AuthRealm = "ingress.kubernetes.io/auth-realm"

// name of the secret
AuthSecret = "ingress.kubernetes.io/auth-secret"

https://cbonte.github.io/haproxy-dconv/1.7/configuration.html#3.4

ref; #424


[Enhancement] Code reuse is extracted as a method.[EventMeshTestUtils]

Fixes #3654.
Motivation
New methods are created getUserAgent, getPackageMsg, getEventMeshMessage.
the code was reusable so extracted as method.
Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

please check checkstyle.

@monish-byte
Download this plugin：

Import the checkstyle of the local project and check the box.

Following this step will solve the problem.

hey @Alonexc I have applied the changes you asked for. What should be the next step?

Select eventmesh checkstyle, then click that button on the left, which will usually check automatically.


Resolve warning in distributed tests

This is a small follow-up to https://github.com/dask/dask/pull/8002

Looks like this resolves the failure we saw in https://github.com/dask/dask/pull/8002. Planning to merge after CI finishes


[Enhancement] [Feature] Toolbar for files

There are some features and enhancements we are working on that will add functionality to files (Add folders, cancel uploads) and some others have been requested or may potentially come in the future (Delete multiple, add search box to Project Organizer) . We may need to do a general and consistent approach to Files/Folders related actions through a toolbar.
The problem:

We currently rely on inline buttons on an action column. Some folders have a few buttons but we may need the functionality when folders come; for instance rename folder.
We will have actions that are not specific to a row in files, for instance Cancel all Uploads, Multiple Delete
Currently the methods used in Project Organizer (PO) and Files pages are separate. PO uses a contextually changing menu. Files uses inline buttons in an Action column. These uses need to be unified to be the same method (though not the same toolbars)

Potential Solutions
A : Keep things as they are make best use of inline icons through the action column

Pros:

Takes less time
less likely to create regression errors
Can make use of existing notification tools
Current suggestion for cancel uploads can be used.

Cons:

Doesn't actually solve the problem, pushes the issue to later
Add folder will need to use a modal

Estimated Time: 3 days that includes

Finalize cancel upload design
Work with chris to turn Add folder into modal

B : Use the exact same method that PO uses for contextual buttons.

Pros:

Known method, familiar to users
Some time to develop but not as long as C

Cons:

Doesn't provide a cohesive toolbar experience, not all options are visible

Estimated Time: 1 week that includes

Adding to Files page
Adding to project overview page

C : Design new toolbar structure that will require revising PO and adding to Files.

Pros:

Allows thinking through and unifying all actions
Potentially get rid of action column
Extendable for future

Cons:

More time to develop
Needs more testing

Estimated Time: 2 weeks that includes

Adjusting Treebeard to work with the toolbar
Adding to Files page
Adding to project overview page
Revising Project Organizer page
Checking compatibility with other Treebeard instances

Suggestions for C:

Edit: Added cancel buttons to search and rename to go back to toolbar.

Open to discussion and contributions; especially from @JeffSpies , @brianjgeiger , @lbanner and @GaryKriebel

I like.

Perhaps cancel uploads does the same as search/rename--do we want multiple
actions available when canceling? It will be greyed out most of the time
anyway.
On Mon, Mar 23, 2015 at 11:31 AM, Brian J. Geiger<EMAIL_ADDRESS>wrote:

I like.
—
Reply to this email directly or view it on GitHub
https://github.com/CenterForOpenScience/osf.io/issues/2282#issuecomment-85050733
.

In that case Cancel Uploads would be the only thing possible to do while uploads are in progress until the user clicks X to go back to icons.
Another idea is to go back to contextual buttons like Project Organizer and only show buttons if they can be clicked. I think combining that with the new toolbar design would still give good outcomes. So a combination of B and C.

@lbanner this suggestion is now in production so we can close the issue.


Error loading module. Only CUDA backend is supported

I have been setting this up in Ubuntu 22 in a Virtualbox Vm.
I have followed the instructions as indicated, except for the part to get the weights.  Instead I curled them as below:
curl https://www.googleapis.com/storage/v1/b/aai-blog-files/o/sd-v1-4.ckpt?alt=media > sd-v1-4.ckpt
when i try: python3 scripts/dream.py  (or with the -l extension), I receive the following output:
Error loading model.  Only the CUDA backend is supported
Traceback (most recent call last):
File "/home/alan/stable-diffusion/ldm/simplet2i.py", line 536, in load_model
self.device = self._get_device()
File "/home/alan/stable-diffusion/ldm/simplet2i.py", line 527, in _get_device
device_type = choose_torch_device()
File "/home/alan/stable-diffusion/ldm/dream/devices.py", line 7, in choose_torch_device
if torch.backends.mps.is_available():
AttributeError: module 'torch.backends' has no attribute 'mps'
Any Ideas?

Forgot to mention after seeing the CUDA error, I installed:
sudo apt install nvidia-cuda-toolkit

This:
elif(torch.backends.mps.is_available()):
needs to be changed to this:
elif hasattr(torch.backends, 'mps') and torch.backends.mps.is_available():
If I'm faster than the others I'll actually get this pushed before someone else.

I guess everyone is asleep!


Shell dereferences invalid pointer when printing demo command help

On a shell over uart, typing "demo\r" without any option causes a bad pointer de-refence:
==30417==    at 0x804AD0C: _vprintk (printk.c:196)
==30417==    by 0x804FFA3: shell_fprintf_fmt (shell_fprintf.c:38)
==30417==    by 0x804F7BD: shell_fprintf (shell.c:1409)
==30417==    by 0x804FADC: help_item_print (shell.c:1537)
==30417==    by 0x804FB62: help_options_print (shell.c:1561)
==30417==    by 0x804FEB8: shell_help_print (shell.c:1662)
==30417==    by 0x804EECB: shell_execute (shell.c:1080)
==30417==    by 0x804E87C: shell_state_collect (shell.c:770)
==30417==    by 0x804F69F: shell_process (shell.c:1366)
==30417==    by 0x804F3B5: shell_thread (shell.c:1232)
==30417==  Address 0xa is not stack'd, malloc'd or (recently) free'd

This is what it prints before the issue:
uart:~$ demo
demo - Demo commands
Options:

@aescolar thanks for reporting. I have assigned it to the authors.

Hi,
It seems it is related to #10192, I have compiled my application with no debug options and it work correctly.
I will fix it.

@aescolar : Do you still observe this problem?

@jarz-nordic : Yes, you can just fetch and checkout https://github.com/aescolar/zephyr/tree/native_uart , and see it happen there. (That branch is on top of your last shell fix 73c21780272d1f7f4382c9213c463f3ddbca5716)
just do:
cd $ZEPHYR_BASE
mkdir build/ ; cd build/
cmake ../samples/subsys/shell/shell_module/  -GNinja -DBOARD=native_posix  -DCONFIG_NO_OPTIMIZATIONS=y -DCONFIG_NATIVE_UART_0_ON_STDINOUT=y
ninja
echo -e "demo\r" | valgrind zephyr/zephyr.exe

This being the output:
build$ echo -e "demo\r" | valgrind zephyr/zephyr.exe
==28775== Memcheck, a memory error detector
==28775== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==28775== Using Valgrind-3.10.1 and LibVEX; rerun with -h for copyright info
==28775== Command: zephyr/zephyr.exe
==28775==

uart:~$ demo
demo - Demo commands
Options:
==28775== Thread 5:
==28775== Invalid read of size 1
==28775==    at 0x804AB3C: _vprintk (printk.c:196)
==28775==    by 0x804FB56: shell_fprintf_fmt (shell_fprintf.c:38)
==28775==    by 0x804F38F: shell_fprintf (shell.c:1408)
==28775==    by 0x804F6AE: help_item_print (shell.c:1536)
==28775==    by 0x804F734: help_options_print (shell.c:1560)
==28775==    by 0x804FA6B: shell_help_print (shell.c:1661)
==28775==    by 0x804EC31: shell_execute (shell.c:1078)
==28775==    by 0x804E608: shell_state_collect (shell.c:768)
==28775==    by 0x804F293: shell_process (shell.c:1365)
==28775==    by 0x804F097: shell_thread (shell.c:1231)
==28775==    by 0x8049EDA: _thread_entry (thread_entry.c:29)
==28775==    by 0x8052539: posix_thread_starter (posix_core.c:301)
==28775==  Address 0xa is not stack'd, malloc'd or (recently) free'd
==28775==
==28775==
==28775== Process terminating with default action of signal 11 (SIGSEGV)
==28775==  Access not within mapped region at address 0xA
==28775==    at 0x804AB3C: _vprintk (printk.c:196)
==28775==    by 0x804FB56: shell_fprintf_fmt (shell_fprintf.c:38)
==28775==    by 0x804F38F: shell_fprintf (shell.c:1408)
==28775==    by 0x804F6AE: help_item_print (shell.c:1536)
==28775==    by 0x804F734: help_options_print (shell.c:1560)
==28775==    by 0x804FA6B: shell_help_print (shell.c:1661)
==28775==    by 0x804EC31: shell_execute (shell.c:1078)
==28775==    by 0x804E608: shell_state_collect (shell.c:768)
==28775==    by 0x804F293: shell_process (shell.c:1365)
==28775==    by 0x804F097: shell_thread (shell.c:1231)
==28775==    by 0x8049EDA: _thread_entry (thread_entry.c:29)
==28775==    by 0x8052539: posix_thread_starter (posix_core.c:301)

@jarz-nordic : Have you been able to reproduce it in native_posix?

@aescolar : Not yet, today I was polishing my PR with shell documentation. I will take care tomorrow.

@aescolar : I cannot find this branch: native_uart on your fork.
The website you are linkig is not available.

@jarz-nordic That branch is already merged merged in master. So no need to fetch my branch anymore.

@aescolar : I found a bug.
Function _vprintk cannot parse *

There is no need to prove it :)
We just need either the shell to not use vprintk in a way it cannot handle, or fix vprintk to be able to handle the way it is being used.


Add name prop to input

Hello.
I have added the prop "name" in the input to be able to send the value if the component is inside a HTML
Thank you

Just adding a name prop isn't a good solution in my opinion. Please look for any issues/PRs on the topic


No-arg viewPager() DSL function is useless

inline fun ViewManager.viewPager() is useless since ViewPager requires an ID and leads to instant crash without it. Minimal (useless, but not leading to crash) viewPager setup looks like viewPager { id = 1 }.

4 months and there is no tracking on this issue?

It's not that critical, I think.

i'm not being able to use viewPager, it crash when i set the pager

Obviously, you need to set ID.
viewPager {
    id = 100500
}

i already did it but it doesn't fix my issue, i had to use XML views to that particular case

val pager = ...
val pager = ...

Something is wrong here, isn't it?

«Instant crash» does not help understanding what's going on. Stack trace does.

trust me if i were able to get any stack trace most probably i were able to fix it, how ever <> means exactly that, app crash with no exception throwing, seems to be something at a very low level

Your problem is not related to Anko.

if anko were not the problem then using the xml equivalent should fail too right? well that's not my case because XML view is working properly

the problem is setting the adapter

using the xml equivalent should fail too

No way to set adapter through XML.
Your question is unrelated to this issue — you can ask it on StackOverflow or in Kotlin Slack.

i mean using equivalent xml view then setting the adapter via myViewPager.adapter = myPager


make listview compatible with annotated queryset. #57

#57

The many to many fields seem to be broken with this pull request.


a EventDeserializer for spooldir

A simple EventDeserializer for spooldir.A deserializer that parses text lines from a file.Matching line/multiLine against the regular expression.

Can one of the admins verify this patch?


[RFC] New Home Page

Status: Open for comments

Need
Right now when starting Backstage, the user enters the catalog. While the catalog contains a lot of stuff, it's probably not what a user is looking for when opening Backstage, in the end it's just one of Backstage's core features.
Proposal
I propose to add a home page that has the same composability as the entity page. The home page is always in the view of a single team. As a user might be part of multiple teams, the page contains a switcher to choose another team (maybe even a team that the user is not part of). The last selected team is stored, so the page opens again in the previous state.
The home page can be used to show:

Team KPIs, like vulnerabilities, runtime metrics, error rates, ... (but not on the component level, but aggregated)
Owned entities
Open PRs in related repositories
Required actions, e.g. "Review the costs of project XYZ..."
Activities in the context of the team
News of the portal itself
Starred entities
...

Implementation
I propose to either make this part of the catalog, or as a new plugin called home. We can reuse most of the features that can be used to configure the entity page (like EntityContext, EntitySwitch, useEntity, ...). Instead of passing the current entity, we pass the entity of the selected team to each widget (Entity*Card). Widgets that already work in the context of a team can be reused here (like OwnershipCard), others can use the existing hooks to request all entities owned by the team. I would avoid passing all owned entities into the widgets, as widget might use more efficient ways to retrieve the required data.
The cool greetings feature could also be moved from the catalog page to the home page.
Context
Here are some older screenshots with ideas for this page:

And some thoughts by @freben. Please comment with some more references if you know any!
Alternatives
It is already possible for an integrator of Backstage to swap out the home page and place custom content there. But I think this could already be part of Backstage out of the box.
Risks
There is already a group entity page so there could now be two places with the same content. But I think that the use-case is different. It's "What are the ownership and members of a team?" vs "What are my KPIs, status, and my ownership?". The home page would focus more on what is relevant for the team itself.

I'm right there with you!
Two key features:

Update to sidenav separating home from catalog
Dismissable intro card

I've created an internal plugin-homepage for exactly this purpose, and reworked the sidenav like so:

Also, those I've shown my system to really question the value, even if the concepts of developer experience are well understood.  So ideally some intro card a user can hide after they know what it is. Tells the user what this Backstage or software catalog thing is, where to start or link out to get more info, possibly a few visually pleasing hero links for like creating a golden path component or seeing their data, that sort of thing.  But then let them hide it once Backstage is just their default homepage or their first thing after coffee in the morning.

Possibly also a built in announcements/news card?  May be relatively similar to the pulse card in the screen shot above, but something where the integrator could announce to the teams.  e.g., we still have some teams who do small code freezes, and would be nice to let leaders bubble those things up, or changes to tools that could be announced, and then quickly dismissed. (to be fair, that could be it's OWN plugin I guess!)

Thanks for creating the RFC to get the discussion going! This has been long-desired and is definitely something we have and appreciate internally at Spotify, as shown in the first screenshot. I've seen similar home pages from many companies mature in their Backstage adoption.
It makes sense to me as a separate (but included out of the box in create-app) plugin from the catalog. This can definitely benefit from the composability changes, since it should be flexible to add many different types of content from other (sometimes internal) plugins.
Some other minor inspiration; the cost-insights plugin has a group switcher underneath the header that behaves as you describe:

I saw this video from @dtuite showing dynamic addition of cards; supporting customizing and reorganizing the content of the home page could be a super cool long-term goal. An MVP that's only customizable by the Backstage administrator makes a lot of sense as a starting point, though.

Sharing here for reference https://youtu.be/UZTVjv-AvZA?t=1787 - @soapraj's demo on the new Backstage homepage inside Spotify during the Backstage Community Session on May 19th!
(It was a call out during the meetup to share when the recording is up 😁 )

@OrkoHunter Thanks for sharing, Any ETA on when the new home page will be available on Opensource?.

Hey, our team will be working on parts of this during the summer so will assign it us for now and you will be able to track issues in a milestone sometime next week!

Hello everyone! We have now opened up a PRFC (Pull Request For Comments) for this, which you can find here. Looking forward to hearing all your suggestions!

Question:
Will this be covering the Welcome Experience for users login into platform for the first time ?
Bare Minimal would be the option to have HomePage Sliders, which can highlight key features...links to important docs, etc.

Question:
Will this be covering the Welcome Experience for users login into the platform for the first time ?
Bare Minimal would be the option to have HomePage Sliders, which can highlight the key features...links to the important docs, etc.

Hi @kiranpatel11, thanks for your input! The scope of our current work is to create an easily composable home page. As soon as we're confident in the API, we'll begin looking at what components we can contribute with, and a Welcome Experience component certainly makes sense from my perspective, although we do have some other ideas as well.
We hope to create a system where it will be easy for everyone to contribute with new components that can be integrated into any homepage!


cryptsetup: 2.1.0 -> 2.3.3

Changes:

https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.2.0-ReleaseNotes
https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.2.1-ReleaseNotes
https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.2.2-ReleaseNotes
https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.3.0-ReleaseNotes
https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.3.1-ReleaseNotes
https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.3.2-ReleaseNotes
https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.3.3-ReleaseNotes

The python bindings were removed in 2.1.0.
Successfully booted my 20.03 on LUKS-encrypted root using this package.

Motivation for this change
Release notes told me:

All users of cryptsetup 2.x should upgrade to this version.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg test installer

Added 2c23cba that removes cryptsetup as a dependency of blivet since it breaks evaluation and the blivet cryptsetup support hasn't worked since nixos-19.09. cc @aszlig

@GrahamcOfBorg test installer.encryptedFSWithKeyfile installer.luksroot installer.luksroot-format2 installer.luksroot-format1

Tests passed and no further comments so let's just merge this.
Thanks.


Map Popup Issues

Steps to Reproduce
1.Go to website
2.Click on Map
3.In world map,click on Iceland
4.Click on Vik
5.Click on close popup
Expected Result
The popup should close.
Actual Result
The popup doesn't close.

@namwen is this closed ?

This is a major bug

This is fixed hence closing the issue


Update Ecto dep to version 2.0.0-beta1

This is the first step to update Scrivener to use Ecto 2+ (it is using the beta version). The tests are green and my internal app is running as well. Waiting for the final release.
Ref.: http://blog.plataformatec.com.br/2016/02/ecto-2-0-0-beta-0-is-out

@erichkist Thanks for submitting this. As @josevalim mentioned, I plan on doing something a bit different than you're suggesting with version requirements.
My plan is to have scrivener's major version follow ecto. On ecto 2.0 release, I'll be cutting a new 2.0 release for scrivener. I plan to support a rolling window of 2 major versions for scrivener, so after the 2.0 release I'll support 2.0 on master and 1.x on a long-lived branch. The version requirement on master will be ~> 2.0 and the version requirement on the 1.x long-lived branch will be ~> 1.0. Would love your thoughts on this approach @josevalim.

@drewolson Ok. I'll update the PR when you confirm the approach :smile:

@erichkist I'm going to go with strategy that I described above. If you could change your version requirement to ~> 2.0, I'll pull this in when Ecto 2.0 is released and I cut the scrivener 2.0 branch.

@drewolson Sure. I updated to ~> 2.0.0-beta until the Ecto 2.0 release (~> 2.0 isn't registry and fails both project).

I've merged this PR into the v2 branch. Thanks!


Allow dusty upgrade to upgrade to RC if explicitly requested

@jsingle Based on the rsync branch, should clear up once that gets merged

Seems reasonable :camel:

Accidentally hit "close PR" lol


When will the code be shared？

Hi, it's an excellent work. When will the code be published?

Hi,
Thanks for your interest in my work. I am still organizing the code.
Since I just graduated with my PhD I will be moving and traveling in the coming weeks, so there will be some delay. I apologize for the inconvenience. If there is any urgent request, please directly send an email to<EMAIL_ADDRESS>

大佬@donglao ，现在不疫情吗？还能去哪玩耍啊-》^^《-

Hi, the Matlab demo code is already there. I will organize the evaluation toolkit and upload it today.

HI ,any plans of releasing the python version of the codebase .What changes miust be made to use other optical flow methods other than SOBOLEV Flow used in the paper which inherently takes care of masked region as mentioned in the paper .

Hi ,any plans of releasing the python version of the codebase .What changes miust be made to use other optical flow methods other than SOBOLEV Flow used in the paper which inherently takes care of masked region as mentioned in the paper .

Hi, since Sobolev Flow was originally written in C++ with MatLab wrapper, migrating the codebase to Python is non-trivial. An alternative solution is to use the flow inpainter proposed by TFG (or an edge-guided version from FGVC). I believe those models can propagate optical flow into masked regions. However, there will be no refinement as done by Sobolev Flow.

Hi, based on the current codebase, you may simply place the input image at
the center of a larger "image" and zero pad the boundaries, and adjust the
flow field & mask accordingly, so that you will have a scene template
larger than the original image. I think I also have the MatLab code for a
full-scene template from another project that you may use as well. Please
contact my email @.*** if you are interested.
On Mon, May 13, 2024 at 6:10 AM LIKITH P @.***> wrote:

What changes need to be done to get tye full scene template instead of the
cropped version .Can you share the codebase of the full scene template
inference if possible .
Thank you ,
Likith P
On Mon, 13 May, 2024, 09:16 donglao, @.***> wrote:

Hi ,any plans of releasing the python version of the codebase .What
changes miust be made to use other optical flow methods other than
SOBOLEV
Flow used in the paper which inherently takes care of masked region as
mentioned in the paper .
Hi, since Sobolev Flow was originally written in C++ with MatLab
wrapper,
migrating the codebase to Python is non-trivial. An alternative solution
is
to use the flow inpainter proposed by TFG (or an edge-guided version
from
FGVC). I believe those models can propagate optical flow into masked
regions. However, there will be no refinement as done by Sobolev Flow.
—
Reply to this email directly, view it on GitHub
<
https://github.com/donglao/videoinpainting/issues/1#issuecomment-2106579811>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A6SZ2TSKZPGVB6UTKGH2HHLZCAZPRAVCNFSM5GESQUQKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJQGY2TOOJYGEYQ>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/donglao/videoinpainting/issues/1#issuecomment-2107538645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ45O22ZODE5MHPENIH47NDZCC3ULAVCNFSM5GESQUQKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJQG42TGOBWGQ2Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you.I have  contacted you over your UCLA email id from my official university email .Looking forward for your response.


Feature Request: "SetupRHEL.sh"

Description
Hello, notAperson535. I am a user of your software "OneClick-macos-Simple-KVM", which allows me to run macOS on Linux with a simple script. I appreciate your work and I think it is very useful. However, I have a feature request for you. Could you please make a setup file for Red Hat-based systems such as Rocky Linux? I would like to use your software on this distribution, but I am not sure how to install the dependencies and configure the settings. It would be great if you could provide a setup file that automates this process for Red Hat-based systems. Thank you for your consideration and your awesome software.
Alternatives I've considered
I've considered "Virtualbox" but it has propietary components, and it's more memory-consuming.

@victinifan360 Could you help me out with this on the discord server? If you can't, here is fine too, but I reply more on discord

Did you try the installFedora.sh? Fedora is the upstream of RHEL and package names will be likely the same.


When deleting and immediately creating MC (through automation) sync MC job fails

Expected Behavior
New MC will be added - and sync will succeed
Actual Behavior
New MC will be added - but sync is failing
Steps to Reproduce
Have an MC run through automation delete and create a new one
Additional Information
All tasks of sync job succeed, except the one that sync the domains.
Status

[ ] Reproduced

[ ] In Progress
SyncingDomainsError.zip

[ ] Validated

Logs are in SyncingDomainsError.zip file.

@ychoma is this consistently reproducible? If not can you provide details on the steps?

Verified by automation with build Version: 1.0.0-SNAPSHOT (Build:37-g6ed4efb, 2017-07-30T22:51:00Z)


chore(NODE-4993): update fle hash to pull in promise tests

Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?

Double check the following

[ ] Ran npm run check:lint script
[ ] Self-review completed using the steps outlined here
[ ] PR title follows the correct format: type(NODE-xxxx)[!]: description

Example: feat(NODE-1234)!: rewriting everything in coffeescript

[ ] Changes are covered by tests
[ ] New TODOs have a related JIRA ticket

https://spruce.mongodb.com/version/63cef3c32fbabe7240977b0a/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC


[Frontend] Add macros for config

This is a PoC to start using macros for configuration templates.
This may be moved to a higher level in the hierarchy of templates, so more files can use them.
Also, it's easily extendable to simplify administration templates.

@xphere Can you rebase this PR please?

Rebased and pushed!


Double github icons

In the right corner there are 2 github icons/links. Should only be 1 the second one probably got there because of a bad merge 😄

I could not find two GitHub icons, Could you please tell me where exactly the two icons appear. I can help with this.

created pull request for this #298

Sorry guyz but let me tell you one thing or you can say the first rule of OSS is first comment in the issue that you started working on it or just ask can i work on this then only proceed , it's a indication that someone already working on this which will saves other developer's time

can i take this one

Sorry @evergreen2001 but there are already 2 PR

this got fixed however now it's completetly gone :S If anyone have time they can add it back :) closing this for now


[fusion-plugin-apollo#167] Log errors

This issue was migrated from fusionjs/fusion-plugin-apollo#167 and was originally reported by @slonoed.

I want to continue a discussion from this PR https://github.com/fusionjs/fusion-plugin-apollo/pull/166
The previous version has the ability to specify formatError function, which allows to log errors and used by me only for logging.
The new version doesn't have anything to log errors.
This is the critical feature.
I want to get an official decision will it be implemented (in some way or another). If yes, when?
As a workaround, I can implement my custom wrapper on top of all resolvers.

As a workaround, I can implement my custom wrapper on top of all resolvers.

You can also use graphql-middleware instead of "manually" wrapping all resolvers.


feat(switch): change --branch to --create

git branch uses --branch to create a new branch, but git switch uses --create. This PR changes git-branchless switch to match git switch.

By the way, feel free to close this if users are used to -b / --branch! git switch has quite a different interface to git checkout, and I feel like it's probably best to match what git switch does instead of git checkout for git-branchless switch.

@mlcui-google thanks for the fix! Originally, this command was git branchless checkout, so it matched the interface of git checkout. Now it's better to match git switch, like you noticed.
It's slightly unfortunately because git branchless switch also lets you switch to commits, not just branches, so the flag --create becomes ambiguous (is it creating a commit or a branch?). But I doubt anyone will be confused.


Enhancement/project entity

The project_update was using the Ayon api via httpx, but this is mixed with the existing server/kitsu/utils.py which uses Entity models to save and update. This PR moves the update to the utils.py and changes it from an API call to an Entity.save(). The utils is currently a mixture of entity and api, this and a few more planned PRs can convert them all to entity calls for consistency. As the code is run server-side it is simpler to use entity and the model approach so that is what I went for here. Plus it makes the test cases easier.
Previously the project_update change  just the project.attrib for the AYON project - this allows fps, resolution etc to be updated in Kitsu and those changes to update the Ayon project. This PR extends this to also update the Ayon statuses and taskTypes based on changes to statuses and taskTypes in Kitsu once the project.update event is fired.
Tests and mocks are added to ensure the project is updating correctly.
cd tests
poetry run pytest tests/test_push_project.py

I've managed to resolve merge conflicts and fix a few minor issues in the process, so this is the last of those 3 PRs. i merged develop here, so it is testable as is. Could you @scottmcdonnell and @iLLiCiTiT (possibly @MilaKudr ) check if i haven't screwed something up? If we successfully merge this, I'll try to replace httpx calls with native server functions.

Excellent! I have all of the httpx calls replaced with entities + tests in the big PR #35 - so I can add a new PR with more entity changes shortly if that suits.


Text to speech converter

you can Contribute by completing either of the two  Enhancement tasks mentioned in the Readme file.

hello sir, can you assign this issue to me?

Cam you please assign this task to me ?

@Ank-1234 and @ghost

hello sir, can you assign this issue to me?

yes u can do it

hello sir, can you assign this issue to me?

yes you can do it

Sir, Can you please assign TASK 2 ( "changing to voice to female voice" )to me?

@TechVine bhaiya please assign me in this issue..I can do it

assigned

Please assign this issue to me

good afternoon sir, Can you please assign this issue to me...

Can you please assign this issue?

sir, can u assign this issue to me ?

Pls assign me

Pls assign me

assigned..........

I request you, please assign this task to me.

Can You Please Assign The Task To Me


Resolve relative paths

I know that @ryanflorence has mentioned some work on relative URLs in other threads, but I thought that I'd make a pull request with a possible working option based on RFC 1808.
I left in comments so that hopefully it should be understandable, but you might also need to reference the RFC 1808 steps. It passes the tests described by 1808, albeit with one modification:
In 1808, anything after the final forward slash in the base url is removed before resolving URLs. However, in React Router, the content after the final forward slash is the base for its children, so it should not be stripped. The tests have been updated to reflect this.
Note: I'm exporting the makeRootRelative function because it was convenient while I was writing this, but the tests for it should just be folded into the createRouterPath tests.
Currently the only tests are the examples from the RFC, so those will probably need to be expanded to ensure correctness, but hopefully this can be a good starting point for addressing the issue (mostly because I dislike writing to={`${pathname}/bar`}).

I think that this is at a decent place right now.
The main interaction is done through a resolveLocation function. It takes a location (either a string or a location descriptor) and a base string, which is the absolute pathname to resolve with. If the base string is not provided, it will end up using / as the base.
<Link> and <Redirect> components resolve their to props based on their match parent.
This doesn't try to automatically resolve locations when a user is manually navigating. In order to do that, the resolveLocation function should be exported and the user would just need to resolve based on the pathname of the match that they are in:
import { resolveLocation } from 'react-router'

class MyComponent extends React.Component {
  back(loc) {
    const { match, router } = this.context
    const base = match && match.parent && match.parent.pathname
    router.transitionTo(resolveLocation('..', base))
  }
}

(I'm not actually exporting it in the lastest PR, but that's a simple fix)

Rebased for the latest version. The new match context is a bit annoying to work with, but everything checks out.

When's this coming in?

I'm afraid this PR is a bit oudated, but I'd like to explain how we're handling relative <Route>s and <Link>s in v4 using the match object.
Relative <Route>s can use the match.path to get the accumulated <Route path> at the position they are rendered:
<Route path="/users/:id" render={({ match }) => (

    <Route path={`${match.path}/profile`} component={UserProfile}/>

)}/>

Relative <Link>s can use the match.url to get the portion of the URL that matched at the position they are rendered:
<Route path="/users/:id" render={({ match }) => (

    <Link to={`${match.url}/profile`}>user profile</Link>

)}/>

Thanks for taking the time to contribute :) Please take another look at v4. We're pushing for a beta this week.

@mjackson I think one main use-case for relative paths would be to use .. for going up one level in the hierarchy. Can you do that with relative <Link>s in v4? The last time I checked this was not yet possible.

@sgoll Yes, you should be able to use relative <Link to> in v4. It's actually the history library's job to do that, where we're using the resolve-pathname module to resolve relative locations. So, e.g. if you history.push('../foo') it will do the right thing.
You will also probably be interested in the discussion going on in https://github.com/ReactTraining/react-router/pull/4332#issuecomment-271921374


use openapi-python-client (see GENERATOR.md)

fixes #1
https://github.com/displague/metal-python/tree/openapi-python-client

client = AuthenticatedClient(base_url="https://api.example.com", token="SuperSecretToken")

How do we define the correct token header? Any option to set the default base_url for README.md (or do we maintain README.md after the initial creation?)
no tests? no examples?


Add constant summand to row compression for Evaluation Arguments

Currently, the registers in some row (or the relevant parts of it) are compressed into a single value by taking the verifier-randomized non-linear sum. For example, for the Evaluation Argument between the Program Table and the Instruction Table, using verifier supplied values $\alpha, \beta, \gamma$, this function is $\mathsf{compress}_{\alpha, \beta, \gamma} : \texttt{ip}, \texttt{ci}, \texttt{nia} \mapsto \alpha \cdot \texttt{ip} + \beta \cdot \texttt{ci} + \gamma \cdot \texttt{nia}$. Notably, we have $\mathsf{compress}_{\alpha, \beta, \gamma}(0, 0, 0) = 0$.
The running evaluation of an Evaluation Argument is initialized with 0. Using verifier-supplied $\epsilon$, the update rule is $\mathsf{update\_running\_eval}_\epsilon : \texttt{re}, \mathsf{compressed\_row} \mapsto \epsilon \cdot \texttt{re} + \mathsf{compressed\_row}$ where $\mathsf{compressed\_row}$ is the appropriate evaluation of $\mathsf{compress}$. Notably, we have $\mathsf{update\_running\_eval}_\epsilon(0, 0) = 0$.
This means that a prover can sneak in an arbitrary amount of all-zero rows before the first not-all-zero row is absorbed into the running evaluation. One way to overcome this is by altering the function $\mathsf{compress}$ to take additional verifier-supplied value $\delta$:
$$\mathsf{compress}_{\alpha, \beta, \gamma, \delta}: \texttt{ip}, \texttt{ci}, \texttt{nia} \mapsto \alpha \cdot \texttt{ip} + \beta \cdot \texttt{ci} + \gamma \cdot \texttt{nia} + \delta$$

An arguably more elegant solution is to initialize the Evaluation Argument's running evaluation with 1 instead of 0.


using latest pytgcalls

No need to change else new tg users will not able to use it

i am not aware about pyrogram and pytgcalls latest stuff or the stuff which is used in Yukki, Recently due to 64 Bit upgrade, there's some issue which has been solved for time being.I ll look towards it and get to a solution soon


Game config - set resolution

Hello guys,
the resolution property in the game config is ignored, from version 3.16.1 and above.
It's a bug or a change?
this is a demo https://codepen.io/samme/pen/wyVKBG, if you downgrade to 3.15.1 it works as well.
Thanks

https://github.com/photonstorm/phaser/blob/master/CHANGELOG-v3.50.md#removal-of-resolution-property-from-across-the-api

https://github.com/photonstorm/phaser/blob/master/CHANGELOG-v3.50.md#removal-of-resolution-property-from-across-the-api


Error viewer loading very small images

Before Creating an issue

Are you running the latest version?Yes, V4.8.6
Are you reporting to the correct repository? Yes, OHIF iewer
Did you search existing issues? Yes

Bug Report
Viewer loading very small images with magnification of over 400%.
And not displaying patient information.
Describe the Bug
Have connected OHIF Viewer with Conquest via DICOMWEB-proxy.
was initially getting error on loading images but after searching on the forum and web was able to get images loading but they are too bloody. on checking realized the magnification is about 402%, not showing patient information and img undefined.
What steps can we follow to reproduce the bug?

Search for same issue on forum and net.

Checked with DICOMWEB-PROXY team
3.Getting attached error

...

Please use code blocks to show formatted errors or code snippets

:warning: Reports we cannot reproduce are at risk of being marked stale and
closed. The more information you can provide, the more likely we are to look
into and address your issue.

The error message seems similar to https://github.com/OHIF/Viewers/issues/1882.

they are too bloody. on checking realized the magnification is about 402%, not showing patient information and img undefined.
I'm not sure what do you mean by "too bloody". Are you talking about the default windowing?
Also, magnification here is most likely not a bug, OHIF is simply trying to stretch your image to fill the space in the viewer.

Metadata errors can be a bug, but to reproduce that you'd have to share sample DICOM files that OHIF is digesting, i.e. sent from dicomweb-proxy.

Could you kindly provide the data if it has been anonymized and you can confirm that there is no patient health information present in any of the headers or embedded within the pixel data?


Add changelog entry for Query server TLS support

Signed-off-by: rjs211<EMAIL_ADDRESS>
Which problem is this PR solving?

Add changelog entry for Query server TLS support

Short description of the changes

Adding changelog entry for changes done in #2337

@yurishkuro Hello. I added a simple entry.  A few points for further disambiguation could be to specifying the fallback values for the host-ports, something along the lines of:
In case the dedicated ports are used, but either of both flsgs are *not* explicitly set, the default values are used.

I havent included the above in this PR as is not a part of #2337 but rather a part of #2387.  Please do let me know how to proceed.

@yurishkuro Hello. I added a simple entry.  A few points for further disambiguation could be to specifying the fallback values for the host-ports, something along the lines of:
In case the dedicated ports are used, but either of both flsgs are *not* explicitly set, the default values are used.

I havent included the above in this PR as is not a part of #2337 but rather a part of #2387.  Please do let me know how to proceed.

Feel free to include that too, the more complete the description of the behavior the better.

Feel free to include that too, the more complete the description of the behavior the better.


Updating ReadMe with toolkit Roadmap and cadence

We will always ensure to have the readme be updated with latest roadmap and release cadence.
We will be transparent about upcoming feature work and breaking changes.
Hope this addresses a lot of awesome developer feedback we got. Thank you!

Is there a preview link where we can read the final?

https://github.com/NeerajW/HoloToolkit-Unity/blob/master/README.md

@StephenHodgson I am currently working with our design team to improve this landing page. It will revamp icons, typography, layout etc.

@NeerajW, don't forget to checkout my updated getting started page.


map not showing, timeout (snap and telnet)

Steps to reproduce

sudo snap install mapscii
mapscii

OS: fedora 29
terminal: terminator (also tried konsole)
shell: zsh (also tried bash)
Current behavior
 mapscii
center: 52.512, 13.42   zoom: -0.17   mouse: 57.908, -149.212 { FetchError: request to http://mapscii.me/0/0/0.pbf failed, reason: connect ETIMEDOUT <IP_ADDRESS>:80
    at ClientRequest.<anonymous> (/snap/mapscii/3/lib/node_modules/mapscii/node_modules/node-fetch/index.js:133:11)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:309:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1281:8)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)

  name: 'FetchError',
  message: 'request to http://mapscii.me/0/0/0.pbf failed, reason: connect ETIMEDOUT <IP_ADDRESS>:80',
  type: 'system',
  errno: 'ETIMEDOUT',
  code: 'ETIMEDOUT' }
center: -22.719, 71.841   zoom: -0.17   mouse: -63.713, 120.788

Expected behavior
A map being shown.
(On a side note telnet mapscii.me also doesn't work. Timeout trying to connect to <IP_ADDRESS>)

Dear @NoeelMoeskops, thanks for checking in - the vector tile and telnet server will be back up tomorrow, its being moved from one data center to another and wasn't seen as critical.
Will keep this issue open until then - your patience is much appreciated :beer:

hmm, oke. wasn't the point of downloading mapscii that you wouldn't need to connect to a remote server in order for it to function?

mapscii tile server + telnet server back online - thanks again for your patience :)
it would work completely offline as long as you got the mbtiles (vector tiles container) offline as well - the osm2vectortiles planet.mbtiles is 54GB big - iirks!
running the client moves the whole processing & rendering to the client side - and by doing so allowing a much better experience with less delays (and less stress on my CPUs compared to telneting in xD).
tile server can be set @ config.js and must to be able to respond to queries like /{z}/{x}/{y} with a vector tile.
cheers!

forgot to mention: source in the config can either be a http(s) or local path - so you don't need a tile server, just a local copy of the planet.mbtiles or any other vector tile container for full offline functionality.

Thanks for clearing things up!

Is there a way to specifically get the tiles? Map not showing up on local.

Hey @LWFlouisa, thanks for checking in - the server was down during a data center outage, all back and running again! :sparkles: :beers:

@LWFlouisa

Is there a way to specifically get the tiles?

Due to a license dispute between @OSM2VectorTiles and @mapbox it is not possible to download the whole planet.mbtiles anymore.
There is an open ToDo to port MapSCII to its successor OpenMapTiles - see #9


GraphQL method

Prisma Client's $graphql method is extremely useful. Hope to see this implemented in photonjs.

Hey @joshhopkins! I agree that it can be a useful feature. Since Prisma 2 is not really tied to GraphQL anymore, the API doesn't make as much sense for us.
That being said, we may end up exposing the internal query protocol sometime in the future.
How do you currently use $graphql?

For more complex cases where bindings aren't needed, I often create my own interface using GraphQL. It works well and is consistent with how we think on the frontend.

@joshhopkins have you seen the new select API? This should be a better replacement. Can you confirm whether this solves your question?

Remind @joshhopkins 🐰


Reproducing the stage1 and stage2 Model problem on L40s

Thank you for your excellent job.
I followed your work and download the released dataset from your link.
Since you have kindly provided an end-to-end script and processed dataset file. I thought we can quickly reproduce your excellent work. But After two days of training, we get our LLaVA-phi2 model. It can infer by your code.
But It can not reproduce the excellent accuracy in your paper. Would you mind sharing any train logs or detailed information with us. Therefore, we can debug the training process and find out what happened.

Do you mean the checkpoint of stage 2? The result of table 3 you want to reproduce or table 7?

Do you mean the checkpoint of stage 2? We do not mention the results of stage 2 in paper. The result of table 3 you want to reproduce or table 7?

Exactly. I carefully read your paper and find the relevant experimental result in Table.10 in the supplementary materials.
According to the 'phi-2' without MOE, the VQA^T and VQA^v2 scored 68.7 and 77.1. But our result scored 31 and 49. A large margin of the performance with the result.

Addtionally, I think it is necessary to clarify our dataset used to reproduce.

Stage1: --data_path ${JSON_FOLDER}/llava_image_.json
Stage2:     --data_path ${JSON_FOLDER}/la_tune_256k.json
${JSON_FOLDER}/lrv_tune_331k.json ${JSON_FOLDER}/lvis_tune_220k_.json
${JSON_FOLDER}/svit_tune_157k.json ${JSON_FOLDER}/nlp_tune.json \

I think you misunderstood our paper. The LLaVA-phi in table 7 is not obtained by training with stage 2 data. Please refer to variant c of table 5 and the Effect of Training Strategy subsection to figure out the setup.
We did not validate the results of stage 2 with stage 2 data, but to make sure your results are consistent, we did just now. The result we got on textqa was 31.7 aligned with you.
By the way, if you want to get the better results, you can take the LLaVA-1.5 data (which is the stage 3 data in MoE-LLaVA) and train a non-MoE version. That would actually be an LLaVA-phi and have no connection to MoE-LLaVA.

I think you misunderstood our paper. The LLaVA-phi in table 7 is not obtained by training with stage 2 data. Please refer to variant c of table 5 and the Effect of Training Strategy subsection to figure out the setup.
We did not validate the results of stage 2 with stage 2 data, but to make sure your results are consistent, we did just now. The result we got on textqa was 31.7 aligned with you.
By the way, if you want to get the better results, you can take the LLaVA-1.5 data (which is the stage 3 data in MoE-LLaVA) and train a non-MoE version. That would actually be an LLaVA-phi and have no connection to MoE-LLaVA.

Thx a lot. This project is very good and open to the community. I will keep in touch with you to further explore the protential of the method.

@LinB203
Hello, Lin. I am now working on integrating MIniCPM LLM with your work. Since the MiniCPM shares a large similarity with Phi-2. I followed the phi-2 pipeline and implement the whole pipeline. The model succeed in loading parameter correctly, but the stage1 pretraining suffer from large loss (~5). Is this phenomenon normal for the llm backbone?

We have actually finished training moellava-minicpm. we provide train_state.json for reference. Please feel free to open a new question if you have one.
stage3.json
stage1.json
stage2.json

We have actually finished training MoE-LLaVA-minicpm. we provide all three stages train_state.json for reference. Please feel free to open a new issue if you have one. stage3.json stage1.json stage2.json

Thank you. My init loss is the same with you. I will reopen a new issue if more questions are met.

We have actually finished training MoE-LLaVA-minicpm. we provide all three stages train_state.json for reference. Please feel free to open a new issue if you have one. stage3.json stage1.json stage2.json

Thank you. My init loss is the same with you. I will reopen a new issue if more questions are met.

Btw, we are traianing on 384×384 resolution. So the final loss maybe a little different.
As the json shows, the loss rises dramatically in the last few steps causing the last saved checkpoint to be unavailable. So I suggest you can save more checkpoints during the process. e.g. if you train 5198 steps in total, maybe 5000 steps will be much better than the last.

Btw, we are training on 384×384 resolution. So the final loss maybe a little different.
As the json shows, the loss rises dramatically in the last few steps causing the last saved checkpoint to be unavailable. So I suggest you can save more checkpoints during the process. e.g. if you train 5198 steps in total, maybe 5000 steps will be much better than the last.
This seems to be a problem caused by minicpm, I haven't encountered it in other models.

I am currently working on 336x336 resolution. I didn't came up with the phenomenon of increase loss on the end.
Unlucky , I met another problem. After Stage-2, my loss is exactly the same with you.
But when I intended to evaluate the whole result on TextVQA. The model seems to output endless and repeated results. The tokenizer and conversation template are aligned with llama-2, which might be align with MiniCPM.
Canon ODADADADADADADA
  0%|                                                                                | 1/5000 [00:06<8:34:01,  6.17s/it]
OCRupupupupupupupupupupD D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D D F ACRupupup" The small small small small small small s
mall small small small small small small small small a C RUP
  0%|                                                                                | 2/5000 [00:10<7:10:31,  5.17s/it]
ThisESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTESTEST
  0%|                                                                                | 3/5000 [00:11<4:43:20,  3.40s/it]
No Single Single Single Single OCR
  0%|                                                                                | 4/5000 [00:16<5:18:11,  3.82s/it]
The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The
 The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The Th
e The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The T
he The The
  0%|▏                                                                                | 5/5000 [00:20<5:37:25,  4.05s/it]
Number Number Number                                                      2,,,,,,,,,,,,,,,2, O,,,,2, O,, a player from the baseball baseball baseball player from the "
2,, O,, a                2, a player from the "2,
  0%|▏                                                                                | 6/5000 [00:25<5:48:18,  4.18s/it]
The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The
 The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The Th
e The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The The T
he The The
  0%|▏                                                                                | 7/5000 [00:29<5:55:32,  4.27s/it]
RoleEPEPEP OCR
  0%|▏                                                                                | 8/5000 [00:34<5:59:31,  4.32s/it]
AITITOCR
  0%|▏                                                                                | 9/5000 [00:38<6:09:30,  4.44s/it]
The Phot Phot Phot Phot Phot Phot Phot Phot Phot Phot Phot Phot L L L L L L L L ACR
  0%|▎                                                                                | 10/5000 [00:43<6:09:02,  4.44s/it]
OffCR
  0%|▎                                                                                | 11/5000 [00:47<6:10:14,  4.45s/it]
OCR Honey Honey Honey Honey
  0%|▎                                                                                | 12/5000 [00:52<6:11:34,  4.47s/it]
The OCRCR
  0%|▎                                                                                | 13/5000 [00:56<6:12:15,  4.48s/it]
Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk Sk
  0%|▎                                                                                | 14/5000 [01:01<6:12:51,  4.49s/it]
  0%|▎                                                                                | 14/5000 [01:01<6:07:58,  4.43s/it]

The implementation of my MINICPM template are as follows.
conv_minicpm = Conversation(
    system="You are a helpful language and vision assistant. "
           "You are able to understand the visual content that the user provides, "
           "and assist the user with a variety of tasks using natural language.",
    roles=("USER", "ASSISTANT"),
    version="minicpm",
    messages=(),
    offset=0,
    sep_style=SeparatorStyle.LLAMA_2,
    sep="<s>",
    sep2="</s>",
)

Hi Lin, thanks for your great work and thoughtful interactions.
I have a question, from the finetune_moe.sh,
https://github.com/PKU-YuanGroup/MoE-LLaVA/blob/c7a5a42efe8dbd092d1c8e51e6265996f5a138b8/scripts/v1/phi2/finetune_moe.sh#L16C26-L16C62
The final MoE-LLaVA is finetuned from a Stage 2 finetuned checkpoint. I finetuned one Stage 2 checkpoint as your shared in https://github.com/PKU-YuanGroup/MoE-LLaVA/blob/main/scripts/v1/phi2/finetune.sh. The result is
yes/no: 78.6
number: 21.48
other: 41.93
overall: 54.72

I'm not sure if this result is reasonable. Would you please share some evaluation metrics of this checkpoint on the VQAv2 dataset? It would be much appreciated if you could share these checkpoints. Thanks.

@LinB203 Hi Lin, thanks for your great work and thoughtful interactions. I have a question, from the finetune_moe.sh,
https://github.com/PKU-YuanGroup/MoE-LLaVA/blob/c7a5a42efe8dbd092d1c8e51e6265996f5a138b8/scripts/v1/phi2/finetune_moe.sh#L16C26-L16C62
The final MoE-LLaVA is finetuned from a Stage 2 finetuned checkpoint. I finetuned one Stage 2 checkpoint as your shared in https://github.com/PKU-YuanGroup/MoE-LLaVA/blob/main/scripts/v1/phi2/finetune.sh. The result is
yes/no: 78.6
number: 21.48
other: 41.93
overall: 54.72

I'm not sure if this result is reasonable. Would you please share some evaluation metrics of this checkpoint on the VQAv2 dataset? It would be much appreciated if you could share these checkpoints. Thanks.

You can find an accuracy score in the results. You can check them. In addition, You can evaluate your model offline on TextVQA dataset. In my reproduction(More gradient accumulation), the VQA-v2 and textvqa score is slightly below the report. But the difference is within 1%.

Hi @cydiachen , many thanks for your kind reply and your shared information. Greatly appreciated!
I run the evaluation on the TextVQA dataset and get a score of 33% (before MoE) and 47% (after MoE). Is this result reasonable? I checked your previous comments in this thread, our results seemed similar on this dataset.
But in Table 10 of the paper, the score is 67.8% (without MoE) and 68.7% (with MoE), which had a large higher margin to our results.


Update service-bus-dotnet-hybrid-app-using-service-bus-relay.md

Updating the section around transportClientEndpointBehavior to indicate this is just a warning and not a blocking issue.

Excellent addition @joepeavey, thank you for contributing. #sign-off


vscode plugin show samples not working

Description:

Steps to reproduce:
ballerina: show samples in vscode, search grpc, select grpc server stream example
Affected Versions: v2.0.0-swan lake
OS, DB, other environment details and versions:
macOS Catalina
it reports error: /Library/Ballerina/distributions/ballerina-slalpha4/examples/grpc-server-streaming/grpc_server_streaming.bal not existed.
Maybe filenames are wrong, I see grpc_server_streaming_service.bal and grpc_server_streaming_service_client.bal there.

I see many errors like this when select the examples.


drop @primate/build and move to rcompat/build

Using https://github.com/rcompat/rcompat/issues/2

halt until https://github.com/oven-sh/bun/issues/8975 is resolved

8c50220


pluto implementation for CI

rdy for merge

Pluto implementation functional
Documentation still needs fixing
Please handle issue about example branch before merging this PR!

One more fix for examples necessary: pushing to examples branch still broken. I will try to fix it today

Fixing from mobile worked :)
Should be ready to merge now ;)


feat: add sentry logging

Add Sentry integration to virtool-workflow

Experiencing issues with the PR not refreshing after a git push --force.
Closing this PR and opening another one.


Some Quesions

Hello, thank you for your excellent work! I would like to ask about the hierarchical approach used in your paper to expand the window size. From the code, it seems that the shifted window operation was not employed. Does the interaction of information between windows rely on the combination of channel self-correlation and spatial self-correlation in "SCC" to compensate for this? Do you think it would be appropriate to consider incorporating the shifted window operation?

Hi, thanks for your interest! Yes, there is no window shifting operation in our method, and HiT-SR mainly relies on multi-scale large windows to directly expand the receptive field (the comparisons of receptive fields can be found in Fig. 7 of our paper). I think bringing the window shifting back to HiT-SR might contribute to the performance, but the inference speed will be slower (please see the rightmost image of Fig. 1b for the speed comparison, where the blue bars used window shifting operations).
Hope this helps!


docs: update license badge according to the chosen one

When I changed the licence to BSD, I forgot to update the badge.

I also updated the action version in the readme.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Enfeeble + Blasphemy lowers damage

Having Enfeeble enabled lowers the damage in the build.

Build: https://pastebin.com/LX07HiBC
Cheers,
Fearwar

You also have Projectile Weakness in the build, and you only have the ability to apply one curse to the enemy, so when Enfeeble is active it takes precedence (both by being a Blasphemy curse, and because it is before Projectile Weakness in the skill list).


Add ability to have MaxBackups zero to rotate a single file.

Do you mean that you'd like max backups zero and maxsize 100MB to simply delete the file and create a new one when it gets above 100MB?  Can you explain why you'd want to do that?  When the file rotated, you'd lose all your log information, so if anything goes wrong soon after rotation, you'd have no idea what was going on.
A better option is to make the max size half as much (in this example, 50MB), and have max backups 1.  Then you'd still be limited to using 100MB of disk space for logs, but you'd never be in a situation where you have no log history.

I meant rolling over one file, like taking the last half of the contents and over writing the first half, and putting the new data at the last half.

And without a time suffix

I guess I don't know why you wouldn't just have maxbackups be 1 and make maxsize 50.
The main problem is that this would be a breaking change for people that already use maxbackups=0 and just use maxage to delete old log files.  We'd need some sort of new value to indicate that you want to rotate internally to a single file, and I don't really see that this really fixes any problem with the package as it is.  It's also a significant difference from how everything else in the package works (and how most every other rotation scheme works, to my knowledge).

Main reason is so that the file is stably named so other things can refer to it without it changing or getting removed and recreated.

I don't think this is doable in the current system.


TypeError: Cannot read property 'deleteAll' of undefined

Below code results in a promise rejection with the error TypeError: Cannot read property 'deleteAll' of undefined
import { mobileMessaging } from 'infobip-mobile-messaging-react-native-plugin';
mobileMessaging.defaultMessageStorage().deleteAll(() => {
       console.log('Deleted all messages');
 });

I added this line of code to the initialization defaultMessageStorage: true. I didn't get the error but messages didn't get deleted.

Hi @vokecodes, I suppose plugin version you are using is 5.0.1? Could you may be share logs and which platform are you testing?

@riskpp Yes, 5.0.1. Testing on Android. Shared logs via mail.

Hi @vokecodes, from my side everything looks fine.
You can check may be you've missed something from the Default message storage doc.
I've just implemented following in Example app
Don't forget to add defaultMessageStorage: true to the config.
//components/homeScreen.js
//Implemented methods for default storage
class HomeScreen extends React.Component {
...
  deleteAll() {
    mobileMessaging.defaultMessageStorage().deleteAll(() => {
      console.log('Delete all');
    });
  }

  findAll() {
    mobileMessaging.defaultMessageStorage().findAll((messages) => {
      console.log('Find All, Messages: ' + JSON.stringify(messages));
    });
  }
 }
 ...
 //Added buttons to the home screen
 render() {
    return (
      <View style={styles.infoView}>
      ...
        <Button
            title="Delete All on default storage"
            onPress={() => this.deleteAll()}
        />
        <Button
            title="Find all messages from default storage"
            onPress={() => this.findAll()}
        />
      </View>
    );
}

Resulting logs:
 LOG  Event: ["messageReceived",{"body":"Text1","title":"Title1"}]
 LOG  Event: ["messageReceived",{"body":"Text2", "title":"Title2"}]
 LOG  Find All, Messages: [{"body":"Text1","title":"Title1"},{"body":"Text2","title":"Title2"}]
 LOG  Delete all
 LOG  Find All, Messages: []

Check the format of the number it should correspond to https://en.wikipedia.org/wiki/E.164, more information also here

Yes, I formatted it
 Invalid phone number:<PHONE_NUMBER>13 (number does not have valid country/network prefix)

Hi @vokecodes, could you check the number one more time, it doesn't look valid per this rules - https://en.wikipedia.org/wiki/E.164

I used a random test number but need to use a real phone number.


Fix createTable on Mysql not preserving primary key information when remarks also defined on the column

Description
Mysql losses primary key and other information if we do a alter column modify .... remarks statement.
So ensure that the initial "create" includes all the remarks and do not attempt to modify them after the fact.
Fixes #2301
Fixes #2634
Fixes #1793
Fixes #1214
Fixes #1210

I closed a bunch of similar issues to #2301 to consolidate tracking

Fix addresses a bug where incorrect SQL is generated.
New test harness tests added and passing.
Fix meets criteria to move to ready to merge without manual testing.

Passing Test Harness Tests
Passing Functional Tests


Determine the future of build/test configuration files in flutter/engine.

Background
Today we "encode" how to build and test the engine in at least three different places:
ci/builders/*.json
Encodes:

What platform is needed to run a "build"
What gn flags to use (i.e. --runtime-mode, and so on) for a build
What target(s) to build (i.e. delegates to ninja) for a build
What target(s) to run as tests (i.e. a non-zero exit code is a failure) for a build

For example:
// Not a 1:1 reproduction.
{
  "builds": [
    {
      "drone_dimensions": [ /* what platform is needed, i.e. Linux, etc */ ],
      "gn": [ /* flags */ ],
      "name": "platform_debug",
      "tests": [ /* executables to run */ ],
    },
  ],
}

Note that many, but not all of the "tests": [ ... ] invocations are to testing/run_tests.py.
testing/run_tests.py
Encodes:

A number of directories or utilities that are used multiple times (i.e. FONTS_DIR, or BUILDROOT_DIR)
Environment variables that are conditionally added or modified
Minor file operations (moving, copying, sym-linking, deleting) to prepare a test (or cleanup after)
A combination of both C++ and non-C++ targets to execute tests with

For example:
# Not a 1:1 reproduction.

# Example of top-level variables.
BUILDROOT_DIR = os.path.abspath(os.path.join(os.path.realpath(__file__), '..', '..', '..'))
OUT_DIR = os.path.join(BUILDROOT_DIR, 'out')
GOLDEN_DIR = os.path.join(BUILDROOT_DIR, 'flutter', 'testing', 'resources')
FONTS_DIR = os.path.join(BUILDROOT_DIR, 'flutter', 'third_party', 'txt', 'third_party', 'fonts')

# Example of platform checks.
def is_asan(build_dir):
  with open(os.path.join(build_dir, 'args.gn')) as args:
    if 'is_asan = true' in args.read():
      return True
  return False

# Example of conditional environment variables.
def metal_validation_env():
  extra_env = {
      'MTL_SHADER_VALIDATION': '1',  # Enables all shader validation tests.
      'MTL_SHADER_VALIDATION_GLOBAL_MEMORY': '1',  # Validates accesses to device and constant memory.
      'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY': '1',  # Validates accesses to threadgroup memory.
      'MTL_SHADER_VALIDATION_TEXTURE_USAGE': '1',  # Validates that texture references are not nil.
  }
  if is_aarm64():
    extra_env.update({
        'METAL_DEBUG_ERROR_MODE': '0',  # Enables metal validation.
        'METAL_DEVICE_WRAPPER_TYPE': '1',  # Enables metal validation.
    })
  return extra_env

# Example of declaring paths to run tests on (there are other specific executable cases).
def build_dart_host_test_list(build_dir):
  dart_host_tests = [
      (os.path.join('flutter', 'testing', 'litetest'), []),
      (os.path.join('flutter', 'testing', 'skia_gold_client'), []),
      (os.path.join('flutter', 'testing', 'scenario_app'), []),
  ]

# Based on the flags, runs variants of tests.
def main():
  if 'dart-host' in types:
    dart_filter = args.dart_host_filter.split(',') if args.dart_host_filter else None
    dart_host_packages = build_dart_host_test_list(build_dir)
    tasks = []
    for dart_host_package, extra_opts in dart_host_packages:
      if dart_filter is None or dart_host_package in dart_filter:
        tasks += list(
            gather_dart_package_tests(
                build_dir,
                os.path.join(BUILDROOT_DIR, dart_host_package),
                extra_opts,
            )
        )
    success = success and run_engine_tasks_in_parallel(tasks)

.ci.yaml
Encodes:

How to run pre/post-submit checks
Which builder (i.e. platform_debug) to build and run tests for
Optional other arguments around timeouts, conditional runs, and conditional branches

For example:
# Not a 1:1 reproduction.
targets:
  - name: Linux linux_android_emulator_tests
    enabled_branches:
      - main
    recipe: engine_v2/engine_v2
    properties:
      config_name: linux_android_emulator
      dependencies: >-
        [
          {"dependency": "goldctl", "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"}
        ]
    timeout: 90
    runIf:
      - .ci.yaml
      - ci/builders/linux_android_emulator.json
      - DEPS
      - lib/ui/**
      - shell/platform/android/**
      - testing/scenario_app/**
      - testing/skia_gold_client/**

Proposal
There can be more than one proposal.
On end-state I think we all agree that:

This (^) is not sustainable, we already run the risk of under-testing or over-testing;
We need to stop leaking implementation details about how builds and tests work across the entire repository;
We can "know", for a given platform, all possible build and test targets;
Our CI and local development process, as much as possible, uses the same workflows.

As a straw-man, you can imagine writing GN rules for every single build and test target (including non-C++), and just using GN throughout the system (behind the et tool). There might be other approaches worth considering (like our own metadata format), but we should keep the end state in mind.
Goals:

Avoid divergence between CI and local development, that is, our et tool should be used in production;
Deliver incremental milestones that add value to the repo (instead of just more code), in other words, make users happy;
Have a kick-ass engine development workflow.

Acknowledged.

From android triage: The android team doesn't have a strong opinion on where to consolidate, but agree that consolidation is good!


iOS 13 dark mode issue

Thank you for the great library and quick response (as always)!
There seems to be 2 issues with the dark mode implementation:

The top tip remains white (minor issue)
There's a white strip on the left for like 5-10pt.

I've attached a screenshot here. Would love to get a fix!

@danqing
It should work release 2.0.0 I've pushed a fix for this.

I can't published release version. :(
cocoapods issue: https://github.com/CocoaPods/CocoaPods/issues/9176

Hmm the top arrow is now black (correct), but the white strip on the left is still present. Is that supposed to be fixed?

@danqing
Yes!

Hmm I can confirm that the issue is still present on master. (latest Xcode, ios 13 simulator, using your example app)
Looks like sometimes it works fine, but if for example I swipe up and go to a different app and then go back I will still see the white strip.
Lemme know if you can't repro the issue.

Oh and I didn't notice it until now, but if you look at the screenshot above, the blue checkmark has a weird background color too.

@danqing
I've fixed that release 2.0.2 :)
Thanks you!

I think the issue is still present. it doesn't appear the first time the pop up is shown, but if you background the app and come back again, you still see the white strip on the left of the popup.


Add user based filtering for ApplicationAuthenticationDAO struct

Extract DB.Debug() to func in ApplicationAuthentication Dao struct
Move tenancy condition to getDB()
Add user filtering to applicationAuthenticationDAO

Reason why  getDb has parameter is that statement .Model(&m.ApplicationAuthentication{}). doesn't work for some usages like DB.Debug().Updates(...) - so it is reason why I leave it optional.
Links

issue: https://github.com/RedHatInsights/sources-api-go/issues/356

@MikelAlejoBR @lindgrenj6 Thanks for you insights - I added tenancy to getDB method and also userid filtering + added tests for user based filtering.

That's actually what we want though - because if the user_id is null that
means it's not a user-based source but still in the tenant. e.g. a
cloud-meter source would show up as well as an app-studio one.
Jacob Lindgren
Senior Software Engineer - Insights Platform
Red Hat
@.***     M:<PHONE_NUMBER>
On Wed, Jul 27, 2022 at 11:36 AM Mikel Alejo @.***>
wrote:

@.**** approved this pull request.
LGTM, just a comment
In dao/application_authentication_dao.go
https://github.com/RedHatInsights/sources-api-go/pull/456#discussion_r931274062
:

@@ -37,6 +38,25 @@ type applicationAuthenticationDaoImpl struct {
UserID   *int64
}

+func (a applicationAuthenticationDaoImpl) getDb() *gorm.DB {

if a.TenantID == nil {

panic("nil tenant found in applicationAuthentication db DAO")

}

query := DB.Debug()
query = query.Where("tenant_id = ?", a.TenantID)

if a.UserID != nil {

query = query.Where("user_id IS NULL OR user_id = ?", a.UserID)

The IS NULL bit maybe is a leftover? Because I think that would match the
following:
id tenant_id app_id auth_id user_id
1 12345<PHONE_NUMBER>10
Even if the specified user ID is different from 101010.
—
Reply to this email directly, view it on GitHub
https://github.com/RedHatInsights/sources-api-go/pull/456#pullrequestreview-1052809137,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMVZ6CDIM3BMUFXADURLBTVWFQQ3ANCNFSM54WRUR2A
.
You are receiving this because you were mentioned.Message ID:
@.***>

That's actually what we want though - because if the user_id is null that means it's not a user-based source but still in the tenant. e.g. a cloud-meter source would show up as well as an app-studio one.

That's right, yeah, I was tunnel visioning. Thank you!

I forgot to cover case where UserID is not present in request.
This can happen for example for requests with PSK - when x-rh-sources-user-id header is not present in request.
I believe that in this case we should list records without ownership (column user_id==NULL):
https://github.com/RedHatInsights/sources-api-go/pull/456/commits/7b3f120645f9ddfd7add9f46d65defe7b714b4f3#diff-e44569a4d110df92cdbe0c0dc8f996ce5cee5a46031f0d7dff34ff43c263a25eR52
@lindgrenj6 @MikelAlejoBR Is it OK for you ?


Support openforcefield.topology.Molecule?

It would be very helpful to standardize support for all of these through the openforcefield.topology.Molecule class, which is now stable enough to use as a standard exchange format.

Yes, I agree those functions need standardization. It is on my to do list.

Fixed by #68


Disable animations of accordion panes.

disable animations on collapse/expand actions
expand first pane by default (if present)

Fixes #318

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyLauncherPRs/16/
Hooray Jenkins reported success with all tests good!


Persistent Running "V" Formatter message

When attempting to use the formatter on save it doesn't work and this message appears until you cancel it.
"[v]":{
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "vlang-vscode.extension",
}

Is this still happen on you @ChildishGiant ?


Implementation of  Ghost deployment(Lazy Loading) test cases for WSO2 AS (JIRI TA-591)

Implementation of  Ghost deployment(Lazy Loading) test cases for WSO2 AS (JIRI TA-591)
this includes

Ghost deployment (Lazy Loading) test caes for WSO2 AS.
Rest web service artefact  to retrieve the web-app/tenant lazy loading information.
add new  "tests-common" module in between  "modules/integration" and  other common sub modules like "tests-common/admin-client","tests-common/ui-pages","tests-common/integration-test-utils".

Hi Saneth,
Can you let me know once you are done with above changes? I will mege this right away.
Thanks.

@kasunbg  this can be merge now...  I have done all changes.


Persistable Decision Diagrams

Despite the fact that Adiar works by storing everything on disk, we currently do not allow the user to truly save/load files on disk.
Solution

[ ] Move meta information into a __meta_file_stats_base struct that it publicly inherits.

[ ] Store meta information (i.e. everything in the node_file class and the variables in the decision_diagram). This can be done within the file header of the node file, as shown in the External memory queue example.

[ ] Store non-shareable information of the BDD, e.g. the negate flag. What seems best to me is to just store this within a simple text file with the following lines.

.version = <adiar version> ( see #140 )
With the version number we can warn the user for the need to migrate older files. This will be useful if we ever implement complement edges.
.diagram_type = <bdd / zdd>
With this we know what type of decision diagram to return (or can verify it is the right type).
.negate = <negation flag>
Should be used with the constructor of the decision_diagram
.nodes = <path/to/file>
.levels = <path/to/file>

[ ] void bdd_save(const bdd &f, std::string file_path):
Move the underlying temporary file and mark it as a persistent file instead. This way we do not duplicate the entire (possibly several GiB sized) file.

Check with persistent() whether it already is stored on disk

If it is, then skip the rest and just create the text file.

Use path() to obtain the original path and name
Use set_persistent(true) to not remove it
Change the file path to the desired place with set_path(...)

The nodes have the given file name but appended with .nodes
The levels have the given file name but appended with .levels

Use some file moving function in std to move the original file too

[ ] bdd bdd_load(std::string file_path):

Make node_file have a constructor taking the node_elems_path and level_infos_path as arguments and creates a node_file (and loads the user data). The main logic would be in __meta_file.
Using the above constructor, create a node_file and then use the current constructor for a bdd that takes both a node_file and a negate boolean and return that.

These functions can be defined in adiar/bdd/io.cpp and adiar/zdd/io.cpp

The third point above is the fancy way to move the whole thing. If it does not work out, then we can always go back to the trivial solution which is just copying the entire content to the desired files. This uses N + L extra space, but this file was created from somewhere and most likely included an adiar::reduce at some point. So, we can be quite sure, that we already have the space needed and can merely copy the entire thing.
Yet, we have the issue that we cannot be sure the prior file went out of scope.

I moved this into the Symbolic Model Checking Milestone since this is probably when we need it ourselves to store and load the transition function etc.

The rewrite in #397 also cleans up the code for files. Specifically, it also exposes TPIE's perstistence of a file and adds move and copy functions for a file. This covers the most risky parts of this issue!


[base-ui][MenuItem] added disableCloseOnClick prop

closes: mui/base-ui#46

[x] I have followed (at least) the PR section of the contributing guide.

We recently moved the development of the Base UI to a separate repository: https://github.com/mui/base-ui. We're pausing accepting external contributions until we complete the planned API change. After these changes are done, we will port this PR to the new repo.
Thanks for your contribution anyway!


CREATE - add dynamo creation scripts along with some basic automation

Simple addition to the repository which provides users/operators with a basic dyanmodb configuration that they can use to quickly get up and running, potential follow up PR's would include, refactoring the shell script into python and including it as part of the repository, turning the bash script into basic cloudformation, more makefile automation, cleaner README (part of which will be included with the merging of #217) and other items. However, I wanted to keep this as atomic as possible, it allows devs to get up and running quickly, now.
Rationale/Motivation around this PR is simple, users should be able to get off the ground and running as fast as possible, currently there is an option within the python codebase to produce a "get_or_create_table" but it doens't include the configuration, the table would require further configuration to be useful.
Let me know if you want this to be rebased.

Coverage remained the same at 58.094% when pulling da446ec1ad8effdaf3557c59b3d1598956463cf5 on JohnVonNeumann:add-script-to-provision-base-dynamodb into c1311a8dcf7a72b460ad520718b2d82f6e3fb0bd on Netflix:master.

Yo, life has been busy, did this end up getting the tick on your end? The other PR from what I understand doesn't have a lot to do with this one.

Nah all good, I've been busy, as I'm sure you have. I can remove the dynamo creation scripts, now that I look at it, I'm unsure what I was trying to achieve with it haha.

Sounds good, please keep PR's coming. I have fixed my filter problem so I should actually see them now.
On Tue, Aug 27, 2019 at 6:55 PM, JohnVonNeumann <<EMAIL_ADDRESS>> wrote:

Nah all good, I've been busy, as I'm sure you have. I can remove the
dynamo creation scripts, now that I look at it, I'm unsure what I was
trying to achieve with it haha.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (
https://github.com/Netflix/repokid/pull/218?email_source=notifications&email_token=ACBG7ICF3LXK33RUR5MYM5TQGXLIDA5CNFSM4HFGBLE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JUKIY#issuecomment-525550883
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/ACBG7IG374WFNY25R4HR7RDQGXLIDANCNFSM4HFGBLEQ
).

Can do, got some stuff I wouldn't mind sinking my teeth into on this project, so when I find some time I'll have a go.

@mcpeak Fixed up mate. Removed the cruft. Cheers.

Burning this branch, scalped so much of the original changes that it's literally got nothing left. I was going to remove the Makefile rule for checking host system installs but just leaving the check_aws_region rule seems like I'm just adding for the sake of adding. I think there's automation to be done on the project, but this isn't it.


Fork ts loader

Significantly increases build time even with async: true. We seem to lose a little bit of error context but at the same time we appear to gain a simple stack trace in console.
✖ ｢core｣: (client) /home/brian/Documents/Development/pixeloven/examples/react-ssr-example/src/shared/components/pages/Home/Home.tsx
./src/shared/components/pages/Home/Home.tsx
[tsl] ERROR in /home/brian/Documents/Development/pixeloven/examples/react-ssr-example/src/shared/components/pages/Home/Home.tsx(33,37)
      TS17002: Expected corresponding JSX closing tag for 'asdsda'.
 @ ./src/shared/components/pages/Home/index.ts 10:13-30
 @ ./src/shared/components/pages/index.ts
 @ ./src/shared/routes.ts
 @ ./src/client/index.tsx

Might explore forking the overlay and error handler to better integrate with this plugin.

@jimmynotjim yup it works! I setup a local test environment using our bootstrap app we all built! Going to try and document the workflow a little more so we can all use it.