PHOENIX-6186 - Store last DDL timestamp in System.Catalog

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 46s
4.x passed

+1 :green_heart:
compile
1m 26s
4.x passed

+1 :green_heart:
checkstyle
6m 49s
4.x passed

+1 :green_heart:
javadoc
1m 48s
4.x passed

+0 :ok:
spotbugs
4m 12s
root in 4.x has 1008 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 43s
phoenix-core in 4.x has 954 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 11s
the patch passed

+1 :green_heart:
compile
1m 30s
the patch passed

+1 :green_heart:
cc
1m 30s
the patch passed

+1 :green_heart:
javac
1m 30s
the patch passed

-1 :x:
checkstyle
5m 35s
root: The patch generated 116 new + 14751 unchanged - 41 fixed = 14867 total (was 14792)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 43s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  3s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m 14s
phoenix-core generated 1 new + 954 unchanged - 0 fixed = 955 total (was 954)

-1 :x:
spotbugs
4m 23s
root generated 1 new + 1008 unchanged - 0 fixed = 1009 total (was 1008)

_ Other Tests _

-1 :x:
unit
159m 53s
root in the patch failed.

+1 :green_heart:
asflicense
1m 26s
The patch does not generate ASF License warnings.

215m  3s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 332]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 332]

Failed junit tests
phoenix.end2end.IndexExtendedIT

phoenix.end2end.UpgradeIT

phoenix.end2end.index.ImmutableIndexIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux cd7751438141 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 605656c

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/testReport/

Max. process+thread count
6864 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Three tests failed (IndexExtendedIT, UpgradeIT, ImmutableIndexIT),  but two were timeouts (the index tests), and all pass when run locally so appear to be flappers.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 44s
4.x passed

+1 :green_heart:
compile
1m 22s
4.x passed

+1 :green_heart:
checkstyle
10m 10s
4.x passed

+1 :green_heart:
javadoc
1m 50s
4.x passed

+0 :ok:
spotbugs
3m 59s
root in 4.x has 1007 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 41s
phoenix-core in 4.x has 953 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 24s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
cc
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

-1 :x:
checkstyle
10m 20s
root: The patch generated 242 new + 22485 unchanged - 111 fixed = 22727 total (was 22596)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 43s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  2s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  7s
phoenix-core generated 2 new + 952 unchanged - 1 fixed = 954 total (was 953)

-1 :x:
spotbugs
4m  5s
root generated 2 new + 1006 unchanged - 1 fixed = 1008 total (was 1007)

_ Other Tests _

-1 :x:
unit
122m 19s
root in the patch failed.

+1 :green_heart:
asflicense
1m  3s
The patch does not generate ASF License warnings.

189m 46s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.AddColumnMutator.validateAndAddMetadata(PTable, byte[][], List, Region, List, List, long, long, boolean):in org.apache.phoenix.coprocessor.AddColumnMutator.validateAndAddMetadata(PTable, byte[][], List, Region, List, List, long, long, boolean): new String(byte[])  At AddColumnMutator.java:[line 341]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

FindBugs
module:root

Found reliance on default encoding in org.apache.phoenix.coprocessor.AddColumnMutator.validateAndAddMetadata(PTable, byte[][], List, Region, List, List, long, long, boolean):in org.apache.phoenix.coprocessor.AddColumnMutator.validateAndAddMetadata(PTable, byte[][], List, Region, List, List, long, long, boolean): new String(byte[])  At AddColumnMutator.java:[line 341]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

Failed junit tests
phoenix.end2end.index.LocalMutableTxIndexIT

phoenix.end2end.OrphanViewToolIT

phoenix.end2end.UpsertSelectIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 5c9c5c9e0156 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / ac0538b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/testReport/

Max. process+thread count
7059 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 44s
4.x passed

+1 :green_heart:
compile
1m 39s
4.x passed

+1 :green_heart:
checkstyle
8m  8s
4.x passed

+1 :green_heart:
javadoc
2m 11s
4.x passed

+0 :ok:
spotbugs
5m 44s
root in 4.x has 1007 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 47s
phoenix-core in 4.x has 953 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 36s
the patch passed

+1 :green_heart:
compile
1m 56s
the patch passed

+1 :green_heart:
cc
1m 56s
the patch passed

+1 :green_heart:
javac
1m 56s
the patch passed

-1 :x:
checkstyle
8m 18s
root: The patch generated 261 new + 22473 unchanged - 125 fixed = 22734 total (was 22598)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
javadoc
1m  4s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m 29s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
4m  5s
phoenix-core generated 1 new + 952 unchanged - 1 fixed = 953 total (was 953)

-1 :x:
spotbugs
5m 24s
root generated 1 new + 1006 unchanged - 1 fixed = 1007 total (was 1007)

_ Other Tests _

-1 :x:
unit
136m 55s
root in the patch failed.

+1 :green_heart:
asflicense
1m 11s
The patch does not generate ASF License warnings.

207m 19s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

Failed junit tests
phoenix.end2end.index.PartialIndexRebuilderIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 276926976dc9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 2aaf2e2

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/testReport/

Max. process+thread count
6771 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ChinmaySKulkarni - I believe this takes care of all the issues we've discussed. Please let me know if there's any other issues you see.

Added test for tenant views
Added test to confirm that set property doesn't update ddl timestamp
Server PTable doesn't replace the client PTable in the cache, only updates the ddl timestamp field in the client-side PTable. (We do still send the server table back in the result object though; made more sense to me than making a new field in the protobuf, and someone else might need to do something similar someday)
Reverted the pom.xml change mistakenly added
5.Added bootstrap code to 4.16 upgrade path to set the ddl timestamp of existing table and view header rows to PHOENIX_ROW_TIMESTAMP(). Added test for this into UpgradeIT and confirmed that BackwardCompatibilityIT still passes.
Added logic to cascade DDL timestamp changes to child / descendent views with a test in AlterTableWithViewsIT to verify.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 35s
4.x passed

+1 :green_heart:
compile
1m 49s
4.x passed

+1 :green_heart:
checkstyle
8m 46s
4.x passed

+1 :green_heart:
javadoc
2m 15s
4.x passed

+0 :ok:
spotbugs
5m 27s
root in 4.x has 1007 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 51s
phoenix-core in 4.x has 953 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 52s
the patch passed

+1 :green_heart:
compile
1m 50s
the patch passed

+1 :green_heart:
cc
1m 50s
the patch passed

+1 :green_heart:
javac
1m 50s
the patch passed

-1 :x:
checkstyle
8m 58s
root: The patch generated 273 new + 24127 unchanged - 127 fixed = 24400 total (was 24254)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 59s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m 26s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
4m 25s
phoenix-core generated 2 new + 952 unchanged - 1 fixed = 954 total (was 953)

-1 :x:
spotbugs
5m 42s
root generated 2 new + 1006 unchanged - 1 fixed = 1008 total (was 1007)

_ Other Tests _

-1 :x:
unit
131m 23s
root in the patch failed.

+1 :green_heart:
asflicense
1m 14s
The patch does not generate ASF License warnings.

203m 55s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(PhoenixConnection) may fail to clean up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:[line 2557] is not discharged

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(PhoenixConnection) may fail to clean up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:[line 2557] is not discharged

Failed junit tests
phoenix.end2end.OrphanViewToolIT

phoenix.end2end.UpgradeIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 8c48313f922a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 7cbebb4

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/testReport/

Max. process+thread count
6904 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/7/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 38s
4.x passed

+1 :green_heart:
compile
1m 21s
4.x passed

+1 :green_heart:
checkstyle
11m  5s
4.x passed

+1 :green_heart:
javadoc
1m 46s
4.x passed

+0 :ok:
spotbugs
4m  1s
root in 4.x has 1000 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 43s
phoenix-core in 4.x has 946 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 15s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
cc
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

-1 :x:
checkstyle
11m 11s
root: The patch generated 276 new + 24786 unchanged - 127 fixed = 25062 total (was 24913)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 41s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  5s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  6s
phoenix-core generated 2 new + 945 unchanged - 1 fixed = 947 total (was 946)

-1 :x:
spotbugs
4m  5s
root generated 2 new + 999 unchanged - 1 fixed = 1001 total (was 1000)

_ Other Tests _

-1 :x:
unit
132m  0s
root in the patch failed.

+1 :green_heart:
asflicense
1m 15s
The patch does not generate ASF License warnings.

196m 25s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(PhoenixConnection) may fail to clean up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:[line 2602] is not discharged

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(PhoenixConnection) may fail to clean up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:[line 2602] is not discharged

Failed junit tests
phoenix.end2end.index.SaltedIndexIT

phoenix.end2end.ReverseScanIT

phoenix.util.IndexScrutinyIT

phoenix.end2end.index.MutableIndexReplicationIT

phoenix.end2end.index.InvalidIndexStateClientSideIT

phoenix.end2end.index.IndexCoprocIT

phoenix.end2end.index.IndexVerificationResultRepositoryIT

phoenix.end2end.UnionAllIT

phoenix.end2end.index.IndexVerificationOutputRepositoryIT

phoenix.end2end.index.GlobalImmutableNonTxIndexIT

phoenix.end2end.SequenceIT

phoenix.end2end.DeleteIT

phoenix.end2end.index.MutableIndexSplitForwardScanIT

phoenix.end2end.index.LocalImmutableNonTxIndexIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux a365babc095a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 20d2a6d

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/testReport/

Max. process+thread count
6871 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/8/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ChinmaySKulkarni - After fixing the test failure in UpgradeIT, we got another test run.  It looks like in this latest run the minicluster got into a bad state where tables couldn't be created, and this led to a bunch of failures. I've rerun them all locally and they look fine.
As far as I know, this patch should be ready to go for 4.x branch. Anything else that needs to be changed or added? Thanks!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 32s
4.x passed

+1 :green_heart:
compile
1m 27s
4.x passed

+1 :green_heart:
checkstyle
11m 22s
4.x passed

+1 :green_heart:
javadoc
1m 51s
4.x passed

+0 :ok:
spotbugs
4m  1s
root in 4.x has 1000 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 42s
phoenix-core in 4.x has 946 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 21s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
cc
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

-1 :x:
checkstyle
11m 29s
root: The patch generated 401 new + 25081 unchanged - 238 fixed = 25482 total (was 25319)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 43s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  4s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  5s
phoenix-core generated 3 new + 945 unchanged - 1 fixed = 948 total (was 946)

-1 :x:
spotbugs
4m  5s
root generated 3 new + 999 unchanged - 1 fixed = 1002 total (was 1000)

_ Other Tests _

-1 :x:
unit
1m 22s
root in the patch failed.

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

64m 13s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) may fail to clean up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:[line 2604] is not discharged

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) passes a nonconstant String to an execute or addBatch method on an SQL statement  At UpgradeUtil.java:to an execute or addBatch method on an SQL statement  At UpgradeUtil.java:[line 2604]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) may fail to clean up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:[line 2604] is not discharged

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) passes a nonconstant String to an execute or addBatch method on an SQL statement  At UpgradeUtil.java:to an execute or addBatch method on an SQL statement  At UpgradeUtil.java:[line 2604]

Failed junit tests
phoenix.util.PhoenixRuntimeTest

phoenix.compile.WhereCompilerTest

phoenix.compile.TenantSpecificViewIndexCompileTest

phoenix.compile.WhereOptimizerTest

phoenix.mapreduce.util.PhoenixConfigurationUtilTest

phoenix.compile.ViewCompilerTest

phoenix.compile.QueryCompilerTest

phoenix.compile.QueryOptimizerTest

phoenix.query.QueryPlanTest

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux e994088abb66 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 565b0ea

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/testReport/

Max. process+thread count
486 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@shahrs87 - I'm curious -- what is the source is for the "split lines indent 8 spaces" rule you mention? You may very well be right, but I don't see anything in dev/PhoenixCodeTemplate.xml that has a value of 8 that looks relevant, and I do see <setting> id="org.eclipse.jdt.core.formatter.indentation.size" value="4"/</setting>

I'm curious -- what is the source is for the "split lines indent 8 spaces" rule you mention?

Tried searching for the property name but couldn't find one. But other places in phoenix code base uses 8 spaces. Eg: https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java#L883, https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java#L1042
Again this is a very very nit comment. please feel free to ignore also. :)

I'm curious -- what is the source is for the "split lines indent 8 spaces" rule you mention?

Actually found the property. It uses this property:
<setting id="org.eclipse.jdt.core.formatter.continuation_indentation" value="2"/>
The value 2 is multiplier of tabulation size property.
<setting id="org.eclipse.jdt.core.formatter.tabulation.size" value="4"/>
Thats how it comes to 8 spaces. :)
`

Reran IndexMetaDataIT and ViewMetadataIT locally and they both passed.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m 38s
4.x passed

+1 :green_heart:
compile
1m 42s
4.x passed

+1 :green_heart:
checkstyle
9m  5s
4.x passed

+1 :green_heart:
javadoc
1m 55s
4.x passed

+0 :ok:
spotbugs
4m 16s
root in 4.x has 1000 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 53s
phoenix-core in 4.x has 946 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 18s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
cc
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

-1 :x:
checkstyle
11m 30s
root: The patch generated 394 new + 25081 unchanged - 238 fixed = 25475 total (was 25319)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 41s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  4s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  3s
phoenix-core generated 3 new + 945 unchanged - 1 fixed = 948 total (was 946)

-1 :x:
spotbugs
4m  7s
root generated 3 new + 999 unchanged - 1 fixed = 1002 total (was 1000)

_ Other Tests _

-1 :x:
unit
131m 26s
root in the patch failed.

+1 :green_heart:
asflicense
1m 14s
The patch does not generate ASF License warnings.

196m  1s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) may fail to clean up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:[line 2604] is not discharged

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) passes a nonconstant String to an execute or addBatch method on an SQL statement  At UpgradeUtil.java:to an execute or addBatch method on an SQL statement  At UpgradeUtil.java:[line 2604]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) may fail to clean up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:up java.sql.Statement  Obligation to clean up resource created at UpgradeUtil.java:[line 2604] is not discharged

org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) passes a nonconstant String to an execute or addBatch method on an SQL statement  At UpgradeUtil.java:to an execute or addBatch method on an SQL statement  At UpgradeUtil.java:[line 2604]

Failed junit tests
phoenix.end2end.index.DropColumnIT

phoenix.end2end.BackwardCompatibilityIT

phoenix.end2end.UpsertSelectIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux f1b085061fa0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / b97696b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/testReport/

Max. process+thread count
6281 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/12/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126 Are any checkstyle, javadocs, spotbugs, findbugs warnings relevant here ? I know that there is some noise but don't know whether any of them are related to patch ?

@shahrs87 - Of the three findbugs errors, the first is unclear to me, the second is complaining about a potential resource leak in the boostrap code (valid complaint) and the third is complaining about a potential SQL injection vulnerability (incorrect, but understandable). I've changed it to use a PreparedStatement in a try-with-resources executing a constant string.
Went through the checkstyle findings. The line lengths checks looks misconfigured (it's 80 but should be 100, and we routinely let things a little longer than 100 slide).

@ChinmaySKulkarni , @shahrs87 , assuming the test runs are OK, are there any other changes you'd like, or is this ready to go? Thanks for your reviews.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m 10s
4.x passed

+1 :green_heart:
compile
1m 23s
4.x passed

+1 :green_heart:
checkstyle
9m 39s
4.x passed

+1 :green_heart:
javadoc
1m 51s
4.x passed

+0 :ok:
spotbugs
4m  9s
root in 4.x has 1000 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 55s
phoenix-core in 4.x has 946 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 21s
the patch passed

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
cc
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

-1 :x:
checkstyle
11m 30s
root: The patch generated 395 new + 25081 unchanged - 238 fixed = 25476 total (was 25319)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 44s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  6s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  9s
phoenix-core generated 2 new + 945 unchanged - 1 fixed = 947 total (was 946)

-1 :x:
spotbugs
4m  7s
root generated 2 new + 999 unchanged - 1 fixed = 1001 total (was 1000)

_ Other Tests _

-1 :x:
unit
133m 43s
root in the patch failed.

+1 :green_heart:
asflicense
1m 16s
The patch does not generate ASF License warnings.

198m 23s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

Failed junit tests
phoenix.end2end.AlterTableWithViewsIT

phoenix.end2end.ExplainPlanWithStatsEnabledIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 2d10649caf18 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 110f5b7

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/testReport/

Max. process+thread count
6653 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/13/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The two test failures were both timeouts and passed locally.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 29s
4.x passed

+1 :green_heart:
compile
1m 23s
4.x passed

+1 :green_heart:
checkstyle
11m 21s
4.x passed

+1 :green_heart:
javadoc
1m 51s
4.x passed

+0 :ok:
spotbugs
4m  2s
root in 4.x has 1000 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 35s
phoenix-core in 4.x has 946 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 18s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
cc
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

-1 :x:
checkstyle
11m 31s
root: The patch generated 340 new + 25061 unchanged - 258 fixed = 25401 total (was 25319)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 42s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  4s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  2s
phoenix-core generated 2 new + 945 unchanged - 1 fixed = 947 total (was 946)

-1 :x:
spotbugs
4m  4s
root generated 2 new + 999 unchanged - 1 fixed = 1001 total (was 1000)

_ Other Tests _

-1 :x:
unit
135m 35s
root in the patch failed.

+1 :green_heart:
asflicense
1m 10s
The patch does not generate ASF License warnings.

200m 30s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

Failed junit tests
phoenix.end2end.PointInTimeQueryIT

phoenix.end2end.UpgradeIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 29d23cc37380 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 110f5b7

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/testReport/

Max. process+thread count
6458 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/14/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/phoenix/pull/935 does not apply to 4.x. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/phoenix/pull/935

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/15/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 43s
4.x passed

+1 :green_heart:
compile
1m 22s
4.x passed

+1 :green_heart:
checkstyle
11m 19s
4.x passed

+1 :green_heart:
javadoc
1m 47s
4.x passed

+0 :ok:
spotbugs
4m  0s
root in 4.x has 1000 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 40s
phoenix-core in 4.x has 946 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 17s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
cc
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

-1 :x:
checkstyle
11m 32s
root: The patch generated 340 new + 25058 unchanged - 258 fixed = 25398 total (was 25316)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
javadoc
0m 43s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  2s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  6s
phoenix-core generated 2 new + 945 unchanged - 1 fixed = 947 total (was 946)

-1 :x:
spotbugs
4m 11s
root generated 2 new + 999 unchanged - 1 fixed = 1001 total (was 1000)

_ Other Tests _

-1 :x:
unit
131m 36s
root in the patch failed.

+1 :green_heart:
asflicense
1m 15s
The patch does not generate ASF License warnings.

196m 34s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

Failed junit tests
phoenix.end2end.join.HashJoinGlobalIndexIT

phoenix.end2end.index.AlterIndexIT

phoenix.end2end.index.txn.RollbackIT

phoenix.end2end.DropIndexedColsIT

phoenix.end2end.IndexToolForNonTxGlobalIndexIT

TEST-[GroupByIT_0]

phoenix.end2end.UpsertSelectIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux ae73e107ab8f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / cd657db

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/testReport/

Max. process+thread count
6186 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/16/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 46s
4.x passed

+1 :green_heart:
compile
1m 23s
4.x passed

+1 :green_heart:
checkstyle
11m 16s
4.x passed

+1 :green_heart:
javadoc
1m 49s
4.x passed

+0 :ok:
spotbugs
4m  0s
root in 4.x has 1000 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 41s
phoenix-core in 4.x has 946 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 17s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
cc
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

-1 :x:
checkstyle
11m 32s
root: The patch generated 301 new + 25102 unchanged - 220 fixed = 25403 total (was 25322)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
javadoc
0m 43s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  4s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  6s
phoenix-core generated 2 new + 945 unchanged - 1 fixed = 947 total (was 946)

-1 :x:
spotbugs
4m  4s
root generated 2 new + 999 unchanged - 1 fixed = 1001 total (was 1000)

_ Other Tests _

-1 :x:
unit
132m  9s
root in the patch failed.

+1 :green_heart:
asflicense
1m 15s
The patch does not generate ASF License warnings.

196m 57s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 330]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 8844591b7f86 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 510ca96

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/testReport/

Max. process+thread count
6450 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/17/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 42s
4.x passed

+1 :green_heart:
compile
1m 24s
4.x passed

+1 :green_heart:
checkstyle
10m 49s
4.x passed

+1 :green_heart:
javadoc
1m 46s
4.x passed

+0 :ok:
spotbugs
4m  6s
root in 4.x has 1003 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 40s
phoenix-core in 4.x has 949 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 25s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
cc
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

-1 :x:
checkstyle
11m 22s
root: The patch generated 338 new + 25077 unchanged - 257 fixed = 25415 total (was 25334)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
javadoc
0m 44s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  5s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  3s
phoenix-core generated 2 new + 948 unchanged - 1 fixed = 950 total (was 949)

-1 :x:
spotbugs
4m  6s
root generated 2 new + 1002 unchanged - 1 fixed = 1004 total (was 1003)

_ Other Tests _

-1 :x:
unit
151m 53s
root in the patch failed.

+1 :green_heart:
asflicense
1m 15s
The patch does not generate ASF License warnings.

216m 16s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

Failed junit tests
phoenix.end2end.AlterMultiTenantTableWithViewsIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux f73c56c70ae4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / ed7f1a6

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/testReport/

Max. process+thread count
6680 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/18/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 40s
4.x passed

+1 :green_heart:
compile
1m 24s
4.x passed

+1 :green_heart:
checkstyle
11m 14s
4.x passed

+1 :green_heart:
javadoc
1m 49s
4.x passed

+0 :ok:
spotbugs
4m  5s
root in 4.x has 1003 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 43s
phoenix-core in 4.x has 949 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 25s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
cc
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

-1 :x:
checkstyle
11m 21s
root: The patch generated 338 new + 25077 unchanged - 257 fixed = 25415 total (was 25334)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
javadoc
0m 46s
phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)

-1 :x:
javadoc
1m  3s
root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)

-1 :x:
spotbugs
3m  6s
phoenix-core generated 2 new + 948 unchanged - 1 fixed = 950 total (was 949)

-1 :x:
spotbugs
4m  7s
root generated 2 new + 1002 unchanged - 1 fixed = 1004 total (was 1003)

_ Other Tests _

-1 :x:
unit
137m  6s
root in the patch failed.

+1 :green_heart:
asflicense
1m 17s
The patch does not generate ASF License warnings.

204m  8s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

FindBugs
module:root

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)  At UpgradeUtil.java:[line 2604]

Failed junit tests
phoenix.end2end.IndexBuildTimestampIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/935

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 3dd6dc9b6fba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / ed7f1a6

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/artifact/yetus-general-check/output/diff-checkstyle-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/testReport/

Max. process+thread count
6417 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/19/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the reviews, @ChinmaySKulkarni and @shahrs87 ! Squashed and merged. I've opened up a PR at #977 for the master branch and will also commit there if tests are green.


[WIP] yaml/lint: Fix path discovery and lint files

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

resolved in #33849


Blazor-server canvas flickering

I'm trying to implement the following tutorials - https://github.com/mizrael/BlazorCanvas using blazor server side. But already on example nr.2 I see how any object is drawn on canvas is flickering.
I've made a test and created a separate solution with the same code, but instead using blazor wasm - no flickering at all.
That's the problem with blazor server?

hi @Bobetti , is there  a particular reason why you want to use Blazor Server? All the calls to the HTML Context happen on the client-side, so I can think that flickering might be due to occasional calls to the backend which inevitably slow down the app.
If you definitely need to communicate with a server, I would suggest to expose an API (possibly with a fast transport like gRPC) and call it only when really necessary. Keep also in mind that Blazor WASM is single-threaded (for now) so any call will block the rendering.

Thing is, I'm writing a project management software using Blazor-server. As a small part of my service, I want to implement a whiteboard functionality for the image feedback process. Images are loaded from Azure blobs and clients can draw any comments on them.
Starting doing tutorials from the above post, I noticed, that even such a simple thing as - show an image on canvas - not suitable for Blazor-server, image is flickering all the time.
Seems to me I must find some other way around...


[patch] update packages

Signed-off-by: kpango<EMAIL_ADDRESS>

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   93.77%   93.77%
=======================================
  Files           9        9
  Lines         466      466
=======================================
  Hits          437      437
  Misses         19       19
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b71bc2...b7ca2ce. Read the comment docs.


[iOS] The keyboard animation is not so smooth and has some junk and laggy on 120HZ promotion devices

It is tested on iPhone 13 Pro(120HZ) and iPhone12(60HZ), release mode:
When the keyboard showup, the textfield will pushup normally but not so smooth.
Also tested iPhone13Pro on low power mode(60HZ),or on iPhone12(60HZ), the animation is not that bad.
Here is the code example

Code

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {

    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const TextFieldPage(),
    );
  }
}

class TextFieldPage extends StatefulWidget {
  const TextFieldPage({Key? key}) : super(key: key);

  @override
  State<TextFieldPage> createState() => _TextFieldPageState();
}

class _TextFieldPageState extends State<TextFieldPage> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
        mainAxisAlignment: MainAxisAlignment.end,
        children: [
          const Spacer(),
          const Text('Keyboard animation', style: TextStyle(fontSize: 26)),
          const Spacer(),
          SizedBox(
              height: 60 + MediaQuery.of(context).padding.bottom,
              child: const CupertinoTextField(
                decoration: BoxDecoration(color: Colors.red),
              )),
        ],
      ),
    );
  }
}

Flutter doctor
[✓] Flutter (Channel master, 3.1.0-0.0.pre.2241, on macOS 12.5 21G72 darwin-arm
    (Rosetta), locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.70.1)
Scanning for devices is taking a long time...[✓] Connected device (2 available)
[✓] HTTP Host Availability

Do you have the CADisableMinimumFrameDurationOnPhone property set to 1 in Info.plist?
This enables the faster ProMotion refresh rates.

Yes, I set

@luckysmg
Is this different from https://github.com/flutter/engine/pull/34871 ?

This is the issue I will linked to that PR

Could you reproduce it?

I can reproduce it but I don't sure others can or not

Could you reproduce it?

Tried using latest master on iPhone 6s (OS 15.3.1), but didn't observe the same behavior, although, the first time it opens the keyboard, it probably shows a jank, not after subsequent attempts. Do you see the same behavior ?
https://user-images.githubusercontent.com/67046386/184360047-33c48664-4eb9-489b-b83a-f750f91454df.MP4

@darshankawar  Yes.But this issue will come out in 120HZ devices like iPhone13Pro, Could you reproduce it😄

I don't have that device to verify on, so it would be good if you could share what you see on that device, so we can compare.

Ok,I will upload a video later

https://user-images.githubusercontent.com/49340347/184362113-d3579137-f379-4ed5-9cc3-6fdcc5293f5e.MP4
When I start record video, the junk will reduce....... But it still have some..

The last two time toggle,You can see that junk? When I doesn't record video, every time is like that.

Hi @sundayla I see the your comment in https://github.com/flutter/flutter/issues/101653#issuecomment-1169809142
Could you reproduce it with the code example in this issue?

@luckysmg I have the same problem, however it is noticeable even with a 60hz device.
The problem is that these microlags are not shown in the performance overlay / profiler. You can also test if you are above 8ms or 16ms while the lags are noticeable. (For me it is always under 8 / 16ms).
The problem is not only when opening the keyboard, in my app almost every animation is affected, sometimes the animations run 100% smooth and then there are some microlags again.

In conclusion, yes this issue still exist and able to reproduce.

@luckysmg I have the same problem, however it is noticeable even with a 60hz device. The problem is that these microlags are not shown in the performance overlay / profiler. You can also test if you are above 8ms or 16ms while the lags are noticeable. (For me it is always under 8 / 16ms).
The problem is not only when opening the keyboard, in my app almost every animation is affected, sometimes the animations run 100% smooth and then there are some microlags again.

This maybe related with shader.......When you first run some animation, it is normal to have some laggy...
But..I mean the keyboard animation on Promotion devices, the laggy is more obvious and transparent to see...

@sundayla
When you start record video, did the junk reduce a little?

Every time I want to record the junk to show, the junk will reduce and become not that transparent.....

@sundayla  Agree with you.
You can see My PR https://github.com/flutter/engine/pull/34871
This is to make the keyboard animation's refresh rate to adjust with the refresh rate using for rendering. Hoping it can be landed....

And You can check out my engine branch to test whether the animation is smoother a lot than before.......
I think the comparsion is very transparent.

This maybe related with shader.......When you first run some animation, it is normal to have some laggy... But..I mean the keyboard animation on Promotion devices, the laggy is more obvious than others and more transparent to be discovered...

No I don't mean the shader compilation jank, the lags also occur when the animation has been displayed 10 times before. Sure the 1st time there is usually a larger lag, the subsequent times it is always only micro stutter.
The last version which did not have these problems was 3.0.1, at least this was the case for me.

Thanks for the update. Based on the report and verification, keeping this issue open and labeling.


Immich has a new logo

It isn't in the main release yet, only in git, but not a bad idea to update already :)

Sounds good!
So when do we start sorting by github stars instead of alphabetically? ;)


Teku fails if deposit snapshots cannot be loaded

Description
If Teku 23.12.0 is unable to get the deposit snapshots from the checkpoint sync provider, e.g. because that provider is unreachable, it fails to start.
Logs
eth-docker-devel-consensus-1  | 2023-12-13 22:35:38.055 INFO  - Listening on http://<IP_ADDRESS>:5052/
eth-docker-devel-consensus-1  | 2023-12-13 22:35:38.062 INFO  - Loading deposit tree snapshot from https://holesky.beaconstate.inf/eth/v1/beacon/deposit_snapshot
eth-docker-devel-consensus-1  | 2023-12-13 22:35:38.071 INFO  - Syncing     *** Target slot: 550378, Head slot: 550371, Waiting for execution layer sync, Connected peers: 0
eth-docker-devel-consensus-1  | 2023-12-13 22:35:38.235 ERROR - Failed to load deposit tree snapshot
eth-docker-devel-consensus-1  | java.io.FileNotFoundException: File 'https://holesky.beaconstate.inf/eth/v1/beacon/deposit_snapshot' not found
eth-docker-devel-consensus-1  | at tech.pegasys.teku.beacon.pow.DepositSnapshotFileLoader.lambda$loadFromUrl$1(DepositSnapshotFileLoader.java:90) ~[teku-beacon-pow-23.12.0.jar:23.12.0]

Steps to Reproduce (Bug)
Deliberately configure an unreachable checkpoint sync url, start a Teku that was synced previously
Expected behavior: [What you expect to happen]
If Teku can't reach the checkpoint sync provider for deposit snapshots, it starts without and loads snapshots via the engine API/eth1 provider
The current behavior is brittle and makes the checkpoint sync provider into a single point of failure
Versions (Add all that apply)

Software version: 23.12.0

It looks like this is an issue with the url? should it be https://holesky.beaconstate.info/eth/v1/beacon/deposit_snapshot?
do you have checkpoint-sync-url=https://holesky.beaconstate.inf?

Sought clarification incorrect route was to replicate the circumstance and show the concern. We'll need to dig into the details on this one and determine severity.

Thanks again for reporting this issue. I'll look into it.
In the meantime, if you want to eliminate that single point of failure in your setup, you can use the flag --deposit-snapshot-enabled to revert back to the previous behaviour (forcing Teku to use the bundled deposit tree snapshot instead of trying to read if from the Beacon API).

We will revert this behaviour in 23.12.1 and reintroduce it in our next version with a proper fallback mechanism implemented (#7715)

@yorickdowne This was fixed on 23.12.1


Add new conversion blocks 'from_Hz' and 'to_Hz' to the MSL (from Modelica_LinearSystems)

Reported by dietmarw on 24 Mar 2009 10:43 UTC
In the Modelica_LinearSystems library are two convenient conversion blocks that would be handy to have in the MSL:
Modelica_LinearSystems.Internal.to_Hz
Modelica_LinearSystems.Internal.from_Hz

The place I would put them would be:
Modelica.SIunits.Conversions.to_Hz
Modelica.SIunits.Conversions.from_Hz

So any chance of moving them there? The Modelica_LineraSystems could be updated accordingly to avoid duplicates (also one could take that opportunity to get rid of the dummy enumeration which is still used in that library and not necessary anymore).

Migrated-From: https://trac.modelica.org/Modelica/ticket/156

Comment by otter on 21 Jun 2009 10:03 UTC
Fixed in e3f1125508aaad02aaf20bebe7820ba0dd6fcf31

Comment by otter on 21 Jun 2009 10:08 UTC
Fixed in e3f1125508aaad02aaf20bebe7820ba0dd6fcf31 and 6ea746c4165f9572ac7ada2d3b2f4532ce3b55c1


Update author field to correctly link to Sidebery author's GitHub

Changed from Shaan to shanto.

He has his Github correctly linked in the description of the mod.


Add break my face by ajr

Song Name
break my face
Artist Name
ajr
Source
Youtube
Youtube Link
d6SZAbp3F6s
Direct File Link
No response
Song ID
368392
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 4225700

reject
video got taken down


Fix Jenkins cleanup

Jenkins would fail if the needcleanup file didn't exist because the
shell test would return 1 which Jenkins considers a failure. Instead
properly test the file condition.

An other proposal in #659

Good catch @jhesketh ! Can we make that part of #659 ?

Nice. Thanks!


Error handling and messages

Handle some edge cases, probably needs a couple of error messages as well.

What if files dissappear at unexpected points?
What if users try to name project something that exists (e.g. temp-file) or is reserved or starts with dot?

Related to issue #12.
Some relevant lines can be seen in adbf77c2de6c3a396daec39a58a57ef76346e276.

I'm not sure that this belongs here, but it would be handy to warn the user if $EDITOR is empty.  It took me a while to debug the error that arises from that situation.

In any case, it certainly needs fixing!

@nikklassen : Thanks for the heads-up! Added a test to check whether $EDITOR is set before add, copy and edit actions.

Sweet, thanks!


breaks at end of file

The feature explorer hangs when you try to record the feature till the last time point (i.e. dragging your clicks on the 'Fine Timeline' box until the very end) and you won't be able to interact with the feature explorer anymore. I tried to label as close to the end as possible, but my last few time points might be missing data.
reported by @sooyounga

fixed by 873da9a4d023c73a0f68c3acfedb6e89cd41a9c9


Use index-swap when reindexing

Following these issues: https://github.com/meilisearch/meilisearch-rails/issues/234 and https://github.com/meilisearch/meilisearch-rails/issues/263
We could improve this method behavior by adding the fix for issue #234 and also make the creation of a new temporary index then adding the data, and then switching it to the current index name using index swap.
So we can run it in production without downtime.

This issue is related to this one: https://github.com/meilisearch/integration-guides/issues/223

This presents a couple of difficulties to implement on ms_reindex! on models, primarily because indexes are not 1:1 mapped to models.
The primary issue is about shared indexes. Since currently we only keep track (and can only keep track) of the indexes on models, reindex! does not in fact know what models are on an index.
For the sake of argument imagine a Movie model and a ShortFilm model which have a shared index with uid "Video".
Attempting to keep track of them with some sort of configuration hash is no good. Models in Rails are lazy-loaded, which means the meilisearch do ... end block may not have run for Movie when we call reindex! on ShortFilm so our gem will be blind to the Movie config and swap the entire index with ShortFilm only. While we can reasonably assume that every model will be loaded in time in a production environment, it would be a nasty surprise to someone opening bin/rails console to do some housekeeping to find that calling reindex! on ShortFilm will remove all Movie entries from the "Video" index.
Attempting to cache this on some sort of persistent configuration would likely be vulnerable to edge case bugs with newly added models or updated meilisearch configurations that have not been cached yet.
The current reindex! method does not have to worry about any of this since it does not remove documents from the index (apart from those that fail the if or unless condition).
From the algoliasearch-rails README on shared indexes:

Notes: If you target a single index from several models, you must never use MyModel.reindex and only use MyModel.reindex!. The reindex method uses a temporary index to perform an atomic reindexing: if you use it, the resulting index will only contain records for the current model because it will not reindex the others.

Essentially, they defer judgement about whether or not to do an index swap or a regular reindex to the user. I am personally not sure if I like that idea, it seems to me like it could cause trouble for users who aren't well versed in the terminology or have so many models that it is not feasible to expect them to be accurate in determining if an index is shared or not.

Curious if there has been any movement on this? I would really like to reindex without worry

Bump on this 👁

Bump on this 👁

I'm not sure what you want from this issue exactly. I outlined the problem with using index-swap, are you saying that you would want it implemented regardless?

Considering the issue hasn't been closed, I assumed it was still up for discussion @ellnix. I do believe not deleting documents as part of re-index is a bug, as it's not a behaviour a user would expect. So whether it's a shared index or something else, I feel like it should be addressed. Otherwise, everyone would have to implement their own "reindex!", that first goes through all the documents to find those that got deleted, delete them and then do another pass re-indexing the existing documents. I feel like the rails integration should be able to handle it for us


Investigate flexibility of tool with phetlib integration at the script level

Discussed during meeting,
We would like to bias the flexibility of the tool in using our existing PhET libraries without embedding new functionality or abstraction into the tool code. Yes, this will make the scripts more complex, but less development will be needed on the tool side and more focus on the script side (which can involve everyone). We hope to generate enough example scripts that 1.) there's something to lean on to create new scripts and 2.) there are sufficient examples to modify on the fly, or even 3.) enough examples exist that someone might just "plug n play" from existing scripts.
I'm pairing that idea with our need to communicate values, variables, etc between scripts (e.g., a model environment script gets the mass value from another script).
Assigning JG and JB to flesh out details, questions, and needs.

I looked into getting a reference to the model directly in the paper program like this:
In program code:
  // NOTE: One strategy that I believe we could get working by copying some projector code into board
  const modelProperty = await paper.get( 'model' );
  console.log( modelProperty );

  modelProperty.link( modelProperty => {
    if ( modelProperty.altitudeProperty ) {
      modelProperty.altitudeProperty.link( altitude => {
        console.log( altitude );
      } );
    }
  } );

And adding a way to get the actual modelProperty from papyrus - in Program.js:
      else if ( sendData.name === 'model' ) {

        // TODO: I hoped that you could possibly reference the model over here, but that is not possible. This method
        // TODO: Could maybe be moved to Board.js though!
        console.log( this._program().number.toString() );
        this._worker.postMessage( {
          messageId,
          receiveData: { object: this._program().number.toString() },
        } );
      }

As noted by the TODOs, this might work but we would need this code to be run from Board (instead of Projector) so we have access to the modelProperty.
But we decided not to continue with this because it makes it harder to use phet-lib. We prefer writing javascript functions in programs that can be evaluated from Board in papyrus.

@jbphet @jessegreenberg Any notes you want to add about our integration of phetlib you want to make here before closing?

Any notes you want to add about our integration of phetlib you want to make here before closing?

Here is a summary of how we are supporting the use of phetlib from Paper Programs at this point in time:

There is a "Simulation Design Board" that exists where the PhET code is interpreted and run.  It extracts code and data from the local storage and uses it to place UI and other view components on the board and set up relationships between them.
On the Paper Programs side, there are three handlers that can be defined which can access PhET code.  The are onProgramAdded, onProgramChangedPosition, and onProgramRemoved.  The names are fairly self explanatory.  And example program will be pasted below.
So far, this seems to work reasonably well for a lot of things.  However, it does have some downsides.  One is that the code being defined on the Paper Program side and then being sent as a string to the board has only local scoping, so no common code can be shared between the different handlers.  This is unusual, and is likely to be confusing to users.

// Altitude Image

// Add an image to the sim where it's vertical position is linked to a Property that sets the altitude.

importScripts('paper.js');

(async () => {

  const onProgramAdded = ( paperProgramNumber, scratchpad, sharedData ) => {

    // const imageSource = 'girlInAir.png';
    // const imageSource = 'lunarLander.png';
    const imageSource = 'birdInAir.png';

    // Create a Scenery image node.
    const imageElement = document.createElement( 'img' );
    imageElement.setAttribute( 'src', `media/images/${imageSource}` );
    const imageNode = new scenery.Image( imageElement, {
      maxWidth: 100
    } );

    // Add to the view
    sharedData.scene.addChild( imageNode );

    // Assign to the scratchpad so that we can move it and remove it later
    scratchpad.imageNode = imageNode;

    // Adjust the position of the image as the altitude property changes.
    const model = sharedData.modelProperty.value;
    if ( model.altitudeProperty ) {

      // Assign to the scratchpad so we can unlink when the program is removed
      scratchpad.altitudeListener = altitude => {
        const viewAltitude =  sharedData.displaySize.height * ( 1 - altitude / 10 );
        imageNode.centerY = viewAltitude;
      };
      model.altitudeProperty.link( scratchpad.altitudeListener );
    }
    else {
      alert( 'No altitudeProperty in model, add that program first' );
    }
  };

  // Called when the program is removed.
  const onProgramRemoved = ( paperProgramNumber, scratchpad, sharedData ) => {
    console.log( `onProgramRemoved called for ppn ${paperProgramNumber}`);
    const model = sharedData.modelProperty.value;

    // Remove the image from the view
    if ( scratchpad.imageNode ){
      sharedData.scene.removeChild( scratchpad.imageNode );
      scratchpad.imageNode = null;
    }
    else {
      alert( 'Error: imageNode node not found in scratchpad data.' );
    }

    // Remove the listener that moves the image with the model
    if ( model.altitudeProperty && scratchpad.altitudeListener ) {
      model.altitudeProperty.unlink( scratchpad.altitudeListener );
      scratchpad.altitudeListener = null;
    }
    else {
      alert( 'altitudeProperty and altitudeListener missing during removal' );
    }
  };

  // Add the state change handler defined above as data for this paper.
  await paper.set('data', {
    paperPlaygroundData: {
      updateTime: Date.now(),
      eventHandlers: {
        onProgramAdded: onProgramAdded.toString(),
        onProgramRemoved: onProgramRemoved.toString()
      }
    }
  } );

    // Get a canvas object for this paper.
  const canvas = await paper.get('canvas');

  // Write a message on the Canvas.
  const ctx = canvas.getContext('2d');
  ctx.font = '20px sans-serif';
  ctx.textAlign = 'center';
  ctx.fillStyle = 'rgb(155,25,34)';
  ctx.fillText('Image at', canvas.width / 2, canvas.height / 2 - 10);
  ctx.fillStyle = 'rgb(155,25,34)';
  ctx.fillText('Altitude', canvas.width / 2, canvas.height / 2 + 20);
})();

Notes added above.  I think we can close this, and use more specific issues for the next steps.


Numbers for dune benchmarks are not stable

Tracking issue for examining why? First thing to do would be to check the numbers locally.

Numbers are stable now, fixed by #156.


Unable to connect to the database.

[root@izbp1finc6d22c39tcxmzuz umami]# npm -v
7.5.1
[root@izbp1finc6d22c39tcxmzuz umami]# node -v
v15.8.0
[root@izbp1finc6d22c39tcxmzuz umami]# yarn -v
1.22.19
[root@izbp1finc6d22c39tcxmzuz umami]# pwd
/root/umami/umami
[root@izbp1finc6d22c39tcxmzuz umami]# ls -a

operating steps
1.yarn install
2.create .env : DATABASE_URL=mysql://root:xxxx@xxxx:3306/umamidb
3.yarn build

Make sure your username and password do not have any weird characters that can cause the connection to fail. Also verify that you can connect manually from somewhere else.

Yes my database is normal and the password contains. And /, and can be used for normal remote connections

The connection is a url, so you need to encode any special characters in your username/password. See https://developer.mozilla.org/en-US/docs/Glossary/percent-encoding

连接是一个 url，因此您需要对用户名/密码中的任何特殊字符进行编码。请参阅https://developer.mozilla.org/en-US/docs/Glossary/percent-encoding
That's it. Thank you.

连接是一个 url，因此您需要对用户名/密码中的任何特殊字符进行编码。请参阅https://developer.mozilla.org/en-US/docs/Glossary/percent-encoding

I have a question. Does umami have to use nginx as the reverse proxy?

No, you can have the app run on port 80 if you want.

No, you can have the app run on port 80 if you want.

Ok, do visitor pages not support embedding in https pages?

If you want SSL, you need a reverse proxy.