Upgrading from v17 to v18 wants to destroy my AutoScalingGroups

Description
While trying to upgrade my repo to v18, I noticed that all my ASGs are going to be recreated, destroying all my worker nodes. I'm using "Worker groups", now called "self_managed_nodes"
Seems like the aws_autoscaling_group resource used to be called workers and now is called this. This will recreate all of my autoscaling groups. Am I wrong?
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/e90c877a741ab3cc4215376a70f7bcc360b6a3d2/workers.tf#L3
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/self-managed-node-group/main.tf#L265

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: v18.23.0

Terraform version: Terraform v0.14.11

Provider version(s):

+ provider registry.terraform.io/hashicorp/aws v3.75.2
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.11.0
+ provider registry.terraform.io/hashicorp/local v2.2.3
+ provider registry.terraform.io/hashicorp/null v3.1.1
+ provider registry.terraform.io/hashicorp/random v3.2.0
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/hashicorp/tls v3.4.0
+ provider registry.terraform.io/terraform-aws-modules/http v2.4.1

Please see https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/UPGRADE-18.0.md

Dang, that's a lot of work for me, we have a ton of clusters which 10 ASGs each, plus some dependencies. I know that y'all are doing this for free, and we shouldn't complain, but why were the resource names changed? By doing that y'all forcing everyone to mess up with the state ... :(

In v18 nearly everything changed - it had to, the module was untenable and reached a critical point in terms of maintainability and being able to support requests. It was a breaking change so I made as many changes as possible to put the project back on a path that we could support for many more years to come. its just the unfortunate nature with Terraform that breaking changes can be very disruptive/destructive since there are no abstractions

Didn't have to, you just changed some names.

@bryantbiggs it would help with migration if name prefix could be specified with no - suffix being added by the module https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/self-managed-node-group/main.tf#L269
Would you mind adding name_prefix variable, default to empty for backward compatibility, if not empty use it instead of name + -, so exact name prefix can be specified and used, as alternative to collecting all names of all ASGs of all clusters and hardcoding them which https://github.com/clowdhaus/eks-v17-v18-migrate/blob/main/v18.tf#L84-L90 suggests?

For codifying the moves, I've temporarily forked the terraform-aws-eks module, added moved blocks to moved.tf, and after one round of apply can switch away from the fork.
The suffix logic is a problem though. I can codify in the fork my prefix to be same as before (configuring name + use_prefix, and removing that trailing - eks module is adding), but to be able to get away from the fork, exact name_prefix support upstream is needed.


Create Display Pages

Please do assign me this issue

I agree that front end is kind of bad now, what kind of Display pages do you need?
We definitely need a new home page and in a search bar , we can sort document

Yeah, that's what I am looking for. The display pages are for showing the documents. I'll assign this to you

can i know what kind of display pages?

Im kind of new to this but ill do everything i can to make it better

Its better if you talk through the gitter channel.

ok


Entity extraction is case sensitive. How can we make it case insensitive

Rasa NLU version (0.10.4):
Used backend / pipeline ( spacy_sklearn):
Operating system (windows):
Issue:
Hi,
I am using spacy_sklearn as backend for training my models with rasa nlu. When i query models with the same case as defined in the training data, entity extraction is working fine. But if i use small case it does not extract the entities. Is there any way we can make entity extraction as case insensitive. There is a open issue #729 .
Content of configuration file (if used & relevant):

I am using tensorflow and I have exact same issue. does anyone has any solution for this?


Consider publishing the git tags corresponding to different released versions

When answering questions about the BSON library on Stack Overflow, it's useful to be able to link to the code corresponding to a given version without having to divine the SHA from the history. In the absence of a CHANGELOG (or even in addition to one), this helps your users understand what has changed between versions and allows people to figure out if a commit is present in a given release.

Well, sure.. But I don't have enough time for this recently. Could @kyeah help?

Added tags after v0.4.0. Is it ok? @shepmaster

Thank you! I know it's difficult to go back and figure out the right commits for each release. It's also tricky to remember to push them when you create a new version (not that I've ever done that, of course 😇 )


error after update tailwind to 3

@StorytellerCZ

this is .postcssrc.js

You haven't defined NODE_ENV. This is a plain old JS error. console.log ctx to look at the shape of the data when you build.

@csellis How should I define it?
Where exactly does ctx come from? Does it come from environmental variables or from the package. json?

@csellis
On the other hand, after defining the environmental variable NODE_ENV, I get this error.

This is a duplicate of #51


Fixed: Admin

Fixed #142
Added feat to add and edit Problems and Tracks in admin
https://github.com/code100x/daily-code/assets/136337515/1a69a24b-4ad8-4036-9a70-9e866a5f4b2b

Added feat to link Track and Problems
https://github.com/code100x/daily-code/assets/136337515/909b0819-cb9a-424c-80aa-770af1985d1d

good start
its missing

image in the track
A way to attach problems to tracks

LMK if u'd like to work on it. If not we can merge this as is and someone else can pick it up

What does LinkProblems do?

Added feat to link Track and Problems

What does LinkProblems do?

it lets users add existing Problems to a track by using ProblemID.
I have attached video of it

link.mp4

good start its missing

image in the track
A way to attach problems to tracks

LMK if u'd like to work on it. If not we can merge this as is and someone else can pick it up

image in the track

it shows the image link for now do you want it to image
and image link when click on edit

LMK if u'd like to work on it. If not we can merge this as is and someone else can pick it up

I would like to work on it and #176

hey @hkirat ,
I have Added auth to Admin and

good start its missing

image in the track

Changed the image link text to 'Image'.
Now, I will work on #176. You can merge it, or I can commit to this PR only, whichever you prefer.
https://github.com/code100x/daily-code/assets/136337515/f0bafb0f-ca54-4da4-9849-8fa0d0f1889b

@hkirat
Added #176
https://github.com/code100x/daily-code/assets/136337515/1787577a-703b-480b-8ed4-281a7a2e1b04

reviewing

Didnt review it too much will be merging and winging it
If there are follow ups will create and more issues and tag you @ShubhamMewara
/bounty $125

Can't we add a role in the authOptions callback,
Verify the role from .env file
Similar to how it's done in cms
And in /app/admin, add a layout.tsx file which will check the if the role is admin, otherwise redirect to "/"
@hkirat @ShubhamMewara

@nimit9 can you tell why that is a better option?

Will have to manually add the admin boolean to the db.

ok, I will do it if @hkirat asked thank you.

Didnt review it too much will be merging and winging it If there are follow ups will create and more issues and tag you @ShubhamMewara /bounty $125

Ok , Thank you

Determining admin role can be done anyhow, but adding the check in layout.tsx makes more sense.
This way, there will be a central check done for admin.
Anyone can add the feature in /admin without worrying about how to protect it.

Ah that probably makes sense why it was done re: local development
Personally I like it better for it to be in the DB
For this repo this is fine

Also I'm going through the change and it is very comprehensive.
Amazing job @ShubhamMewara

@hkirat
Thank you so much!

Yes, good job @ShubhamMewara.

Yes, good job @ShubhamMewara.
Thank you.


Occasional Monitoring install issue

Spotted in Rancher 2.5.3 intermittently, Monitoring install fails because CRDs aren’t installed. However CRDs are installed, and it’s part of the “install monitoring” function.
It's unclear what to do next since it’s disconnected and the install appears to have stopped. There’s not even something to delete.

Closing as stale - please re-open if there are still problems


speech.streamingRecognize randomly silently not working (v1)

The problem is I am using v1 and the latest<EMAIL_ADDRESS>It worked perfectly for 6 months (even v1beta) until yesterday when it just randomly (and silently!) stops working. I mean one call of streamingRecognize may go well and recognition starts, but then second or third call of streamingRecognize just don't receive any input (and I'm getting you're streaming to slow error). Using the same code!
And even in recognition starts, the quality is very low. Often leading to completely wrong results.
What happened??? We use google speech API for our paying customers and this is very important.
Environment details

OS:  amazon linux 4.4.44-39.55.amzn1.x86_64
Node.js version: v7.2.1
npm version: 3.10.10
using<EMAIL_ADDRESS>
Steps to reproduce
var Speech = require('@google-cloud/speech')({
  credentials: require(_base + '/google_cloud_credential.json')
});

    self.recognizeStream = Speech.streamingRecognize({
            config: {
                encoding: 'MULAW',
                sampleRateHertz: 8000,
                languageCode: "ru-RU",
            },
            singleUtterance: false,
            interimResults: true
    });

    self.iStream.pipe(self.recognizeStream)
    .on('error', function(err) {
                    logger.error('google-speech error:', err);
                    self.restartRecognizing(); //GOOGLE BUG: randomly crashes https://github.com/GoogleCloudPlatform/google-cloud-node/issues/1894
                })
    .on('end', function(err) {
                    logger.trace('google-speech end:', err);
                })
    .on('close', function(err) {
                    logger.error('google-speech close: ', err);
                    self.restartRecognizing(); //GOOGLE BUG: randomly crashes https://github.com/GoogleCloudPlatform/google-cloud-node/issues/1894
                })
    .on('data', function(data) {
                    //logger.warn(data);
                    require('tracer').setLevel('info');

                    if(data.results && data.results[0] && data.results[0].alternatives)
                        logger.warn("isFinal: %s,  conf: %s,  stab: %s,  trans: %s,  delay=%s", data.results[0].isFinal, data.results[0].alternatives[0].confidence, data.results[0].stability, data.results[0].alternatives[0].transcript, Number(self.thisDate-self.prevDate));

                    if(!self.isListeningEmitted && data && data.results && data.results[0] && !data.results[0].isFinal)
                    {
                        self.isListeningEmitted = true;
                        self.emit('started_hearing_speech');
                    }
                    if(data && data.results && data.results[0] && data.results[0].alternatives && !data.results[0].isFinal)
                    {
                        self.thisDate = Date.now();
                        if(!self.prevDate)
                            self.prevDate = self.thisDate;

                        logger.debug("isFinal: %s,  conf: %s,  stab: %s,  trans: %s,  delay=%s", data.results[0].isFinal, data.results[0].alternatives[0].confidence, data.results[0].stability, data.results[0].alternatives[0].transcript, Number(self.thisDate-self.prevDate));
                        self.prevDate = self.thisDate;

                        if(self.timer)
                            clearTimeout(self.timer);

                        if(!self.isFired)
                            self.timer = setTimeout(self.onRecognizedText.bind(self), 800, data.results[0].alternatives[0].transcript);
                    }
                });

Hi @bloodcarter,
Thanks for reporting.
This sounds like a backend issue...let me see what we can find out.

And also I can see s lot of errors in my Google cloud console (charts with
API usage and errors). If you need them, I can make a screenshot. Thanks.
Чт, 17 авг. 2017 г. в 21:31, Luke Sneeringer<EMAIL_ADDRESS>
Hi @bloodcarter https://github.com/bloodcarter,
Thanks for reporting.
This sounds like a backend issue...let me see what we can find out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2541#issuecomment-323107518,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APyuxq9bXP3grkTGrA90APlHp_1Xv0Lkks5sZFwtgaJpZM4O6HVE
.

--
--Vladislav Chernyshov
Co-founder @ Dedal
http://beta.ded.al
https://medium.com/dedal

Yes, the screenshot would be greatly appreciated.

@lukesneeringer here you are. As you can see the number of errors start rising after Google released v1 after july 30, and reaches it's peak today.

Any updates on this?

Thanks for the screenshot, @bloodcarter.
Did you start seeing a problem after a client library upgrade, or did this happen silently?

Silently. I tried to upgrade only after that.
чт, 31 авг. 2017 г. в 1:14, Luke Sneeringer<EMAIL_ADDRESS>
Thanks for the screenshot, @bloodcarter https://github.com/bloodcarter.
Did you start seeing a problem after a client library upgrade, or did this
happen silently?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2541#issuecomment-326074708,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APyuxjWyFtR_QQAdKq3yN7SuSvQVCLTZks5sdaaKgaJpZM4O6HVE
.

--
--Vladislav Chernyshov
Co-founder @ Dedal
http://beta.ded.al
https://medium.com/dedal

Thanks @bloodcarter.
Can you provide us with your project ID? The Speech team wants to do some backend investigation.
(Feel free to email it to me if you prefer.)

Hey @lukesneeringer ,
I opened an issue here https://issuetracker.google.com/issues/65186018. You can find the project ID there. Thanks!

Any updates on that?

@bloodcarter I have been following this thread since I have the same issue. I updated my npm google cloud speech package last week to 0.10.3 and streamingRecognize is working again, though I don't think there was ever an announcement regarding that

Can somebody from Google confirm that? @lukesneeringer

Any updates?

i am using google cloud speech api in node js.when i send local audio file it gives the result but when i try to send live stream it gets stopped within second .can anyone help for this?

It looks like https://issuetracker.google.com/issues/65186018 is tracking this issue, as it is one for the backend team. Please follow there, and if the results of that issue indicate there is work to do from here, we will address it then.
@jagadesh18 I'm not sure, it sounds unique to the modules you're using and your code. It might be best to ask that on StackOverflow. If you believe it is a bug in our client library, please open a new issue.


Polish dialyzer warnings on supervisor init/1

On R15B01, dialyzer complains of init/1 supervisor specs. This fixes it.

Wait. R15B01? What do you mean?

just out of habit. R15B that is ^^_

Sorry it takes so long, I'm just not finding the time to build that R15B plt and try it. ;) I'll do that tomorrow evening in the train.

No worries. Just a minor thing.

I don't really know how you did that pull request but I can't retrieve it to test it before merging. Could you create a branch based on master containing that commit, then send a pull request for that branch? If you're not sure how exactly I'll setup some kind of tutorial on the wiki or something. Thanks.

hum. i had to delete and refork cowboy and maybe that's why you are experiencing errors. weird though.
can you please try to use the diff file directly:
https://github.com/extend/cowboy/commit/f3de0869801d3909cc5a5d5dbee81941481a0c2e.diff
if that doesn't work i can submit a new pull request.
by the way, i'm not really sure why dialyzer complains of the current return specs {ok, {{simple_one_for_one, 0, 1}, [{_, _, _, _, _, _}, ...]}}.. After all, the ones that i've submitted can actually be simplified to {_, _, _, _, _, _}.

I can but that diff doesn't contain author information. I'll look better when I get home.-- Envoyé depuis mon HP Pre3Le 23 févr. 2012 21:41, Roberto Ostinelli<EMAIL_ADDRESS>a écrit : hum. i had to delete and refork cowboy and maybe that's why you are experiencing errors. weird though.
can you please try to use the diff file directly:
https://github.com/extend/cowboy/commit/f3de0869801d3909cc5a5d5dbee81941481a0c2e.diff
if that doesn't work i can submit a new pull request.
by the way, i'm not really sure why dialyzer complains of the current return specs {ok, {{simple_one_for_one, 0, 1}, [{_, _, _, _, _, _}, ...]}}.. After all, the ones that i've submitted can actually be simplified to {_, _, _, _, _, _}.
Reply to this email directly or view it on GitHub:
https://github.com/extend/cowboy/pull/146#issuecomment-4144740

ok, let me know.


Fixed #24877 -- Call process_exception on exceptions raised in render

This change should be mentioned in the 1.9 release notes (not sure about elsewhere in the documentation).

I added a change in the release notes. Please let me know if it's in the right place in the file.

buildbot, add to whitelist.

I'm not sure how to fix the following failing test: http://djangoci.com/job/pull-requests-trusty/2248/database=sqlite3,label=trusty-pr,python=python3.4/testReport/middleware_exceptions.tests/MiddlewareTests/test_exception_in_render_passed_to_process_exception/
Adding from __future__ import unicode_literals doesn't seem to have fixed the problem. I guess that's because the text of the exception is a string, while response.content is always binary? Should I force_text(response.content) in the assertion?

You can add a b'' prefix: self.assertEqual(response.content, b'Exception caught')

I added the b prefix as you can see in the PR code, but the tests keep failing for some reason: http://djangoci.com/job/pull-requests-trusty/2257/
As you can see on the test fail page it looks like it's still referencing the previous version of the code (self.assertEqual(response.content, 'Exception caught')). I ran the tests locally on Python 3 and they're running fine.

buildbot, test this please.

buildbot, test this please.

merged in f5d5867a4a6aeddd58ff855a01ab4e438d938ac1, thanks!


[SPARK-14541][SQL] Support IFNULL, NULLIF, NVL and NVL2

What changes were proposed in this pull request?
This patch adds support for a few SQL functions to improve compatibility with other databases: IFNULL, NULLIF, NVL and NVL2. In order to do this, this patch introduced a RuntimeReplaceable expression trait that allows replacing an unevaluable expression in the optimizer before evaluation.
Note that the semantics are not completely identical to other databases in esoteric cases.
How was this patch tested?
Added a new test suite SQLCompatibilityFunctionSuite.
Closes #12373.

Test build #58524 has started for PR 13084 at commit 301d97a.

Test build #58524 has finished for PR 13084 at commit 301d97a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait RuntimeReplaceable extends Unevaluable
case class IfNull(left: Expression, right: Expression) extends RuntimeReplaceable
case class NullIf(left: Expression, right: Expression) extends RuntimeReplaceable
case class Nvl(left: Expression, right: Expression) extends RuntimeReplaceable
case class Nvl2(expr1: Expression, expr2: Expression, expr3: Expression)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58524/
Test FAILed.

Test build #58532 has started for PR 13084 at commit 3248fb5.

Test build #58532 has finished for PR 13084 at commit 3248fb5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58532/
Test PASSed.

Merged build finished. Test PASSed.

cc @hvanhovell wanna review this?

LGTM

Merging to master and branch 2.0.


[Event Request] Codeunit 13 - OnBeforeCheckRecurringLine

Consider adding an event to override the check of recurring gen journal lines in method CheckRecurringLine.
local procedure CheckRecurringLine(var GenJnlLine2: Record "Gen. Journal Line")
    var
        DummyDateFormula: DateFormula;
        IsHandled: Boolean; //added
    begin
        //added+
        OnBeforeCheckRecurringLine(GenJnlLine2, GenJnlTemplate, isHandled);
        if isHandled then
            exit;
        //added-

        with GenJnlLine2 do
            if "Account No." <> '' then
                if GenJnlTemplate.Recurring then begin
                    TestField("Recurring Method");
                    TestField("Recurring Frequency");
                    if "Bal. Account No." <> '' then
                        FieldError("Bal. Account No.", Text021);
                    case "Recurring Method" of
                        "Recurring Method"::"V  Variable", "Recurring Method"::"RV Reversing Variable",
                      "Recurring Method"::"F  Fixed", "Recurring Method"::"RF Reversing Fixed":
                            if not "Allow Zero-Amount Posting" then
                                TestField(Amount);
                        "Recurring Method"::"B  Balance", "Recurring Method"::"RB Reversing Balance":
                            TestField(Amount, 0);
                    end;
                end else begin
                    TestField("Recurring Method", 0);
                    TestField("Recurring Frequency", DummyDateFormula);
                end;
    end;

Signature:
[IntegrationEvent(false, false)]
    local procedure OnBeforeCheckRecurringLine(VAR GenJournalLine: Record "Gen. Journal Line"; GenJnlTemplate: Record "Gen. Journal Template"; VAR IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


⚠ ClamAV has degraded performance

In 3719ae8, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 85 ms

Resolved: ClamAV performance has improved in 476f0b8.


Crash on opening 'NSInvalidArgumentException'

Since today Vienna crashes on my every time I'm trying to start it. :(
Process:               Vienna [1153]
Path:                  /Applications/Vienna.app/Contents/MacOS/Vienna
Identifier:            uk.co.opencommunity.vienna2
Version:               3.1.16 :891d05ea: (6187)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Vienna [1153]
User ID:               501

Date/Time:             2017-12-08 09:30:23.288 +0100
OS Version:            Mac OS X 10.12.6 (16G1114)
Report Version:        12
Anonymous UUID:        07B77D04-2B2F-E2FE-3D3F-D7E6471908B8

Time Awake Since Boot: 250 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Application Specific Information:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSArrayM insertObject:atIndex:]: object cannot be nil'
abort() called
terminating with uncaught exception of type NSException

Application Specific Backtrace 1:
0   CoreFoundation                      0x00007fffa451957b __exceptionPreprocess + 171
1   libobjc.A.dylib                     0x00007fffb98f81da objc_exception_throw + 48
2   CoreFoundation                      0x00007fffa443551d -[__NSArrayM insertObject:atIndex:] + 1389
3   AppKit                              0x00007fffa2011298 -[NSView replaceSubview:with:] + 258
4   AppKit                              0x00007fffa203e74d -[NSTabView _switchTabViewItem:oldView:withTabViewItem:newView:initialFirstResponder:lastKeyView:] + 959
5   AppKit                              0x00007fffa21b609b -[NSTabViewItem setView:] + 196
6   Vienna                              0x00000001078feed4 Vienna + 388820
7   Vienna                              0x00000001078db5f1 Vienna + 243185
8   Vienna                              0x00000001078d7674 Vienna + 226932
9   CoreFoundation                      0x00007fffa44933af -[NSSet makeObjectsPerformSelector:] + 239
10  AppKit                              0x00007fffa1f548bb -[NSIBObjectData nibInstantiateWithOwner:options:topLevelObjects:] + 1442
11  AppKit                              0x00007fffa1f4baf0 loadNib + 375
12  AppKit                              0x00007fffa1f4b258 +[NSBundle(NSNibLoading) _loadNibFile:nameTable:options:withZone:ownerBundle:] + 850
13  AppKit                              0x00007fffa1f4adf2 -[NSBundle(NSNibLoading) loadNibNamed:owner:topLevelObjects:] + 201
14  AppKit                              0x00007fffa1f4abaf +[NSBundle(NSNibLoading) loadNibNamed:owner:] + 414
15  AppKit                              0x00007fffa1f45b2b NSApplicationMain + 498
16  libdyld.dylib                       0x00007fffba1d9235 start + 1
17  ???                                 0x0000000000000001 0x0 + 1

Likely a corrupt database, so you can try and remove it (~Library/Application Support/Vienna/messages.db) and restart Vienna if you need to get it to run again quickly.

Thanks. I just tried it out and unfortunately it did not help.

I have just tested a new Vienna release and Vienna finally loads again. This is great. Howevere, when I put back my messages.db backup into ~Library/Application Support/Vienna/ , then Vienna still won't load my subscriptions. Is there any advice on how I could re-import subscriptions from an old messages.db backup?

Something like this (in Terminal) might help :
$ cd ~/Library/Application\ Support/Vienna/
$ sqlite3 messages.db
SQLite version 3.19.3 2017-06-27 16:48:08
Enter ".help" for usage hints.
sqlite> .dump rss_folders
...
sqlite> .quit
$

This helped a bunch, thank you!


WebSocket on Triple

What is the purpose of the change
Refer: https://github.com/apache/dubbo/issues/14298
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Hold, this also requires adding triple client.


UI auto updating as time goes by

Is your feature request related to a problem? Please describe.
"The Button" sits over there <--- on one of my screens, and it stays there all day. But as time goes by, nothing updates.
Describe the solution you'd like
Would be great if the following UI elements auto updated throughout the day:

Currently running timers
Time progress bar and associated numbers

Worth noting I'm running it as an "app" in Edge so I don't even get a browser refresh button - I have to press Ctrl-R to see updates. Not the end of the world but auto updating times would be great.

Have previously used https://momentjs.com/ to do this, but didn't give the flexibility needed to do the decimal time durations. Would prefer a vanilla JS approach to avoid including a library and keep things small and simple.


Quick question.

Sorry for opening an issue for this, but I'm trying to use the Swift 2.3 version of Alamofire in my project. But what version do I need to use in my Podfile?

You can use pod 'Alamofire', git: "https://github.com/alamofire/Alamofire.git", branch: "swift2.3".


Add a scroll-to-top button

Title says it all.

Can I work On this issue?

assing me on that issue

@Anupamgupt @debjitpurohit This issue is assigned to a fellow core member. Follow the #github channel on Discord to stay notified for other new issues or suggest your own improvements in the #custom-issues forum.

Please assign me this issue.

hey , Can you plzz assign this issue to me . i want to work on it .

please assign this issue to me. I am excited to work on it.

Working on this issue


GEODE-7697: OpenSSL 1.1.0 minimum required, removed openssl-compat

I've updated the minimum version to 1.1.1.

Despite that fact that people shouldn't be using OpenSSL 1.1.0 or less, is there a compelling reason to remove support for it?

Yes, the OpenSSL documentation is explicit that it is not thread safe, and we see a host of runtime bugs because of it. Forcing a minimum version fixes them and reduces the amount of code we have to maintain for backwards compatibility that never actually worked.

Yes, the OpenSSL documentation is explicit that it is not thread safe, and we see a host of runtime bugs because of it. Forcing a minimum version fixes them and reduces the amount of code we have to maintain for backwards compatibility that never actually worked.

For clarity, what is not thread safe? The whole of OpenSSL prior to 1.1.1?

We've merged the SSL code into the client proper, so this is no longer relevant.


Doesn't handle npm dependencies of dependent project

Having project B with a set of npm dependencies defined in gradle using the plugin syntax it's not possible to add project B as a dependency to project A without redefining all npm dependencies in project A.
i.e.
in project B:
...
apply plugin: 'org.jetbrains.kotlin.frontend'
...
kotlinFrontend {
    ...
    npm {
        dependency("some-dependency", "$some-dependency_version")
    }
}

in project A
...
apply plugin: 'org.jetbrains.kotlin.frontend'
...
dependencies {
    compile project(':B')
}

doesn't work, because project A is missing some-dependency npm module.
Because of this it's hard to manage project with multiple subprojects, cause it results managing all dependiencies in a root project.

up


Fixing rare iin with 13-digits.

According to documentations, when both checksum returns 10, Individual Identification Number cannot be used.
Example of such bad iin: Birth - 1989-04-02, Male, Population - 1584

Thanks


clicking the "Open file" icon in the main window will crash Spyder

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "E:\P\Anaconda3\lib\site-packages\spyder\plugins\editor.py", line 1840, in load
self.edit_filetypes = get_edit_filetypes()
File "E:\P\Anaconda3\lib\site-packages\spyder\config\utils.py", line 119, in get_edit_filetypes
pygments_exts = get_pygments_extensions()
File "E:\P\Anaconda3\lib\site-packages\spyder\config\utils.py", line 86, in get_pygments_extensions
for lx in lexers.get_all_lexers():
File "E:\P\Anaconda3\lib\site-packages\pygments\lexers_init.py", line 53, in get_all_lexers
for lexer in find_plugin_lexers():
File "E:\P\Anaconda3\lib\site-packages\pygments\plugin.py", line 53, in find_plugin_lexers
yield entrypoint.load()
File "E:\P\Anaconda3\lib\site-packages\pkg_resources_init.py", line 2404, in load
self.require(*args, **kwargs)
File "E:\P\Anaconda3\lib\site-packages\pkg_resources_init_.py", line 2427, in require
items = working_set.resolve(reqs, env, installer, extras=self.extras)
File "E:\P\Anaconda3\lib\site-packages\pkg_resources_init_.py", line 872, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.VersionConflict: (pyparsing 2.2.0 (e:\p\anaconda3\lib\site-packages), Requirement

Could you post the output of
conda list

please?

Closing because of lack of response.

I am sorry for the late response, I did'nt follow the thread :(
I upload the condalist.txt you asked for
condalist.txt

According to your list, you have two different versions of pyparsing, so I think that's what's causing this error:
pyparsing                 2.1.5                     <pip>
pyparsing                 2.2.0            py35hcd8862f_1

Thank you very much. I will try to do a full uninstall and install.
I do not have time to do so the next few days, but I will report back the
result. Thanks again
Op 24 okt. 2017 18:35 schreef "Carlos Cordoba"<EMAIL_ADDRESS>
According to your list, you have two different versions of pyparsing, so I
think that's what's causing this error:
pyparsing                 2.1.5
pyparsing                 2.2.0            py35hcd8862f_1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/5444#issuecomment-339052270,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfMU-IDpFWZvbHK-KCs46eUezdaC6lENks5svhHjgaJpZM4P1cHJ
.

Yesterday I did a full uninstall/install of Anaconda, and updated the most important items.
Everything is just working fine now :)
I suppose that an installation of SymPy I did with pip, caused the mismatch problem.
Thanks again for pointing out the version mismatch.

Good to know you finally solve this problem!!
Just a word of warning for the future: always try to install packages with conda first, then go to conda-forge, and finally, if no package is available in those two, please use pip.
Mixing pip and conda is not a good practice, and could easily break your Anaconda installation (as it was the case here :-).

I learned this the "hard" way.
I won't make the same mistake again! :)
Op 1 nov. 2017 14:08 schreef "Carlos Cordoba"<EMAIL_ADDRESS>Good to know you finally solve this problem!!
Just a word of warning for the future: always try to install packages with
conda first, then go to conda-forge, and finally, if no package is
available in those two, please use pip.
Mixing pip and conda is not a good practice, and could easily break your
Anaconda installation (as it was the case here :-).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/5444#issuecomment-341101232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfMU-P0RyRtPR70brL-SBsPo75k3VsDCks5syG1HgaJpZM4P1cHJ
.


Yb/linux

Debugged Linux support and added tests for Windows and Linux

We will have to squash all my commits, they're dirty

I am squashing these commits and pulling


provisioner-app: Make T1 intermediate key length and type dynamic

In upstream solo2, the T1 intermediate key is a 32-byte Ed255 key.  In 8e70f9d88924e3ead105f9c60aee13b9b1516ef6, we changed it to a 64-byte P256 key.  We should have a more flexible solution that allows 32 or 64 bytes and lets the user specify the key type.

As we’re no longer a fork of solo2, this is not necessary any more.


Add command to reset state

https://user-images.githubusercontent.com/3683420/223568303-8fd553b2-f731-43ac-b64e-7db0b98997fe.mov

Not really sure how to test this to be honest.

Could have an external function that is registered in the extension. Just give the function the workspace state instead of the whole context. You could then test that function with a mockMemento to make sure all of the correct keys are called. the main reason for adding that test would be to document the behaviour.
Maybe add extension/src/persistence/util.ts & extension/src/persistence/register.ts. Register would take the workspaceState object and so would the util. The test could be done on the util (wouldn't test the registered function as it would cause unexpected result in development)... remember to stub reload window 😁
edit: this is a suggestion.

Thanks that was really useful.


VSCode Auto Import not working correctly

Describe the bug
It seems that the auto import for this package inside a TypeScript Repo in VSCode is not working correctly.
Instead of importing the real modules it always tries to import it from the type definitions.
Clicking this menu element:

leads to this import:

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
No response
Expected behavior
No response
Screenshots or Videos
No response
Platform

OS: macOS

Additional context
No response

Hmm. I can't reproduce and I auto import in VSCode (into other apps) all the time. Can I quickly ask for your VSCode and TypeScript versions?

Actually now I can repro. The heuristic here is surprising but let me try and figure it out.

OK, this might be better

Thanks for your quick fix. Now it works like expected 👍


Develop your first integration solution page steps are not working

When follow the guidelines in the Develop Your First Integration Solution page the following API is generated.
<?xml version="1.0" encoding="UTF-8"?>
<api context="/healthcare" name="HealthcareAPI"
xmlns="http://ws.apache.org/ns/synapse">
	<resource methods="GET" uri-template="/doctor/{doctorType}">
		<inSequence>
			<clone>
				<target>
					<sequence>
						<call>
							<endpoint key="GrandOakEndpoint" />
						</call>
					</sequence>
				</target>
				<target>
					<sequence>
						<payloadFactory media-type="json">
							<format>{ "doctorType": "$1" } </format>
							<args>
								<arg evaluator="xml" expression="$ctx:uri.var.doctorType" />
							</args>
						</payloadFactory>
						<call>
							<endpoint key="PineValleyEndpoint" />
						</call>
					</sequence>
				</target>
			</clone>
			<aggregate>
				<completeCondition>
					<messageCount max="-1" min="-1" />
				</completeCondition>
				<onComplete expression="json-eval($.doctors.doctor)">
					<respond />
				</onComplete>
			</aggregate>
		</inSequence>
		<faultSequence />
	</resource>
</api>

When we run it, following error is shown in console and response is not returned.  Compare the generated code with code given in https://mi.docs.wso2.com/en/latest/get-started/quick-start-guide/#step-1-set-up-the-workspace and verify
[2024-08-19 09:27:53,494]  INFO {EndpointDeployer} - Endpoint named 'PineValleyEndpoint' has been deployed from file : /Volumes/anupama/MI/MI_HOME/wso2mi-4.3.0/tmp/carbonapps/-1234/1724077673475Healthcare_1.0.0.car/PineValleyEndpoint_1.0.0/PineValleyEndpoint-1.0.0.xml
[2024-08-19 09:27:53,497]  INFO {EndpointDeployer} - Endpoint named 'GrandOakEndpoint' has been deployed from file : /Volumes/anupama/MI/MI_HOME/wso2mi-4.3.0/tmp/carbonapps/-1234/1724077673475Healthcare_1.0.0.car/GrandOakEndpoint_1.0.0/GrandOakEndpoint-1.0.0.xml
[2024-08-19 09:27:53,521]  INFO {API} - {api:HealthcareAPI} Initializing API: HealthcareAPI
[2024-08-19 09:27:53,521]  INFO {Axis2SynapseEnvironment} - Continuation call is set to true
[2024-08-19 09:27:53,523]  INFO {APIDeployer} - API named 'HealthcareAPI' has been deployed from file : /Volumes/anupama/MI/MI_HOME/wso2mi-4.3.0/tmp/carbonapps/-1234/1724077673475Healthcare_1.0.0.car/HealthcareAPI_1.0.0/HealthcareAPI-1.0.0.xml
[2024-08-19 09:27:53,523]  INFO {CappDeployer} - Successfully Deployed Carbon Application : Healthcare_1.0.0{super-tenant}
[2024-08-19 09:27:53,524]  INFO {AppDeployerServiceComponent} - Dashboard is configured. Initiating heartbeat component.
[2024-08-19 09:27:53,554]  INFO {PassThroughListeningIOReactorManager} - Pass-through HTTP Listener started on <IP_ADDRESS>:8290
[2024-08-19 09:27:53,555]  INFO {PassThroughListeningIOReactorManager} - Pass-through HTTPS Listener started on <IP_ADDRESS>:8253
[2024-08-19 09:27:53,556]  INFO {StartupFinalizer} - WSO2 Micro Integrator started in 2.56 seconds
[2024-08-19 09:27:53,625]  INFO {PassThroughListeningIOReactorManager} - Pass-through EI_INTERNAL_HTTP_INBOUND_ENDPOINT Listener started on <IP_ADDRESS>:9201
[2024-08-19 09:27:53,633]  INFO {PassThroughListeningIOReactorManager} - Pass-through EI_INTERNAL_HTTPS_INBOUND_ENDPOINT Listener started on <IP_ADDRESS>:9164
[2024-08-19 09:27:54,826]  INFO {AuthenticationHandlerAdapter} - User admin logged in successfully
[2024-08-19 09:29:11,129]  INFO {TimeoutHandler} - This engine will expire all callbacks after GLOBAL_TIMEOUT: 120 seconds, irrespective of the timeout action, after the specified or optional timeout
[2024-08-19 09:29:11,258] ERROR {SequenceMediator} - {api:HealthcareAPI} Missing property in path $['doctors'] com.jayway.jsonpath.PathNotFoundException: Missing property in path $['doctors']

With the PR https://github.com/wso2/docs-mi/pull/1020 this doc is removed, as the step-by-step guide is available in quick start guide.


applySuggestions hangs on "Opening editor..."

I ran eslint-interactive via npx. OS is Fedora Silverblue 39.

@eddie-dunn I think this is the same as #328. Could you try the solution described in the issue?

Probably because eslint-interactive is using ESLint v9. ESLint v9 loads the flat config by default, not the legacy config. The .eslintrc.js is not loaded by default because it is a legacy config.
To load the legacy config, start eslint-interactive with the ESLINT_USE_FLAT_CONFIG=false environment variable set.

Please try https://github.com/mizdra/eslint-interactive/issues/347#issuecomment-2084150296 :)


Updated README.md

I saw some typos so I thought I would fix them for you. I also included some links here and there. Hope this is ok.

Thanks!


Make spark-rapids-ml run against cuml23.02

With this PR, spark-rapids-ml can run on both cuml 22.10 and cuml 23.02. ( I didn't test 22.12)

build

FYI, I've been running fine on 22.12 in my dev environment.

build

build


Feature request: different roots for different actions

To get arcane to cooperate with the InheritedResources gem, I had to do a little metaprogramming trickery that allows an overwrite of the self.root method for each action because I didn't find a way to get the current action inside of the #root function. I think adding a reference point like that would make a good addition to the gem in general.

I'm very sorry for the immense wait, not very nice of me to leave you hanging like this. What if you could specify a method in the chain to select the root key?
params.at(:published_article).refine


Pages + Content priority

Logo
Brigade name
Mission
Activities we do
Next meetup
WIP projects
Past project showcase
How to get involved as a volunteer
How to partner
Email us
Join Slack
Why donate
Sponsors
Donate
About CfA.org

Header

Logo
Brigade Name

Home page

Mission & activities
Next 2 Meetups
Contact us to get involved (email, slack)
Sponsors (Civic Tech Chat, Microsoft)
About CFA + Donate

Project Showcase page

YGL
Member project 1
Member project 2 ...

Work with Us page

Blurb for orgs + call to action to email us
Blurb for volunteers + call to action to attend a meetup

Events

Summary paragraph
Events from Meetup + CTA to RSVP


Add RemoteSlurmJob to connect SLURMCluster to a remote Slurm cluster

Hello 👋  Thank you for considering this feature request :) I have been looking over dask-jobqueue (together with prefect) to allocate resources on a Slurm cluster I have access to. dask-jobqueue seems exactly what we'd need for this, thank you for maintaining it 🙇
Context
In the case where Slurm and a python process (script or notebook) are not running on the same host SlurmCluster will not be able to spawn any jobs and error.
Slurm added a REST API: https://slurm.schedmd.com/rest_api.html
Feature
Could we add a RemoteSlurmCluster and RemoteSlurmJob that largely extend SlurmCluster/SlurmJob and instead of using subprocess.Popen we'd do an HTTP request instead?
class RemoteSLURMJob(SLURMJob):
    @contextmanager
    def job_file(self):
        # we don't need the script file but only the script itself. to not alter `async def start(self):` we yield the script here.
        yield self.job_script()

    async def _submit_job(self, script):
        # formatting should be according to:
        # https://slurm.schedmd.com/rest_api.html#slurmctldSubmitJob
        return requests.post('slurm-url/jobs/submit')  # reach out to API

    def _job_id_from_submit_output(self, out):
        # out is the JSON output from _submit_job request.post
        # See https://slurm.schedmd.com/rest_api.html#v0.0.36_job_submission_response
        return out['job_id']

    @classmethod
    def _close_job(cls, job_id):
        # See: https://slurm.schedmd.com/rest_api.html#slurmctldCancelJob
        requests.delete(f'slurm-url/job/{job_id}')

class RemoteSLURMCluster(SLURMCluster):
    job_cls = RemoteSLURMJob

As far as I can tell this should be a drop-in replacement.
Thoughts? (tagging @mrocklin @lesteve for visibility, hope you would have time for a review.)

This proposal sounds totally reasonable to me. Do you have any interest in raising a PR?

Very much! I'm only waiting on the infrastructure that I have access to to enable the SLURM REST API, so I can test it.
Would you have time for a review sometime this week/next week @jacobtomlinson?

Happy to review but I think it best for one of the core maintainers of this repo (@guillaumeeb, @lesteve) to do the final merge.

This sounds also totally reasonable to me, as it keeps the general concept of dask-jobqueue and should be pretty readable by the look of your snippet!
This is really nice to have a REST API for submitting job, Slurm is definitely a nice job scheduler.
So waiting for your PR 👍 !

Just curious, your use case is to create a SlumRemoteCluster on a host

where Slurm is not installed (for example sbatch does not exist) but you have access to the Slurm REST API endpoint
which is in the same network as the Slurm cluster (I don't know the exact technical term but what I mean is that the Dask scheduler on this host need to communicate over HTTP to the Dask workers on your computing nodes)

Did I get this right?
If so it does not feel like this is a very common situation but I may be missing something of course ...

@lesteve thank you for responding 🙇♂ I've been poking around dask-jobqueue for a few days now and am very happy to see it's been very well maintained. Thank you for this.

Just curious, your use case is to create a SlumRemoteCluster on a host

where Slurm is not installed (for example sbatch does not exist) but you have access to the Slurm REST API endpoint
which is in the same network as the Slurm cluster (I don't know the exact technical term but what I mean is that the Dask scheduler on this host need to communicate over HTTP to the Dask workers on your computing nodes)

Did I get this right?
If so it does not feel like this is a very common situation but I may be missing something of course ...

Yes, that would be correct.
I wouldn't know how to determine if this is a common situation. However I would argue that since SLURM has introduced an REST API to be able to remotely start jobs there must be some users.
The usecase would be allowing a docker container running inside a HPC cluster to call out to SLURM to schedule dask-workers with specific (GPU) resource requirements.
Inside the docker container;

Start SlurmRemoteCluster scheduler
HTTP call to SLURM REST API to start n workers with x resources
n workers come online and register with scheduler
workload processed
HTTP call to SLURM REST API to close n workers
Stop SlurmRemoteCluster scheduler

OK running the Dask scheduler inside a docker container (on a login node I assume) is a use case that makes sense. I did not think of this, thanks!
For security reasons I would think that cluster sys-admins would not allow connecting to the Slurm REST API endpoint from the outside, but maybe these kind of security constraints are only in place for "big" clusters.

inside a docker container (on a login node I assume)

Yes - or at least somewhere where it can send/receive calls from the SLURM REST API. I would say "inside" the cluster.

Has there been any progress here?

inside a docker container (on a login node I assume)

this is exactly my use case (except with a Singularity container, but it still means I don't have the sbatch binary directly available).

This could be of interest as well: https://gist.github.com/willirath/2176a9fa792577b269cb393995f43dda
It's ssh'ing back to the host system where srun etc are available.

Has there been any progress here?

Unfortunately the associated PR has gone stale... But there was some work on it, so if anyone want to keep going it would be nice!

+1 for this.

+1

+1


Doc Request - Automation Conditions Tuturial/Examples

Howdy!
This is a super rad plugin, and I think it might be helpful to suggest how it might be used for automations in HA. For example if a user wanted to create a simple automation that turned on 'Christmas lights' if Christmas was the next holiday and it was 14 days until Christmas <- How would we best do that?
I can create some template values paired with a simple numeric state. The template value gets slightly more complicated for some users, and with the attribute nesting HA/Jinja doesn't seem happy at me. Any tips to help with condition writing? And maybe if so there are a few good additions to docs to help folks get started?
{{ 'christmas' in states.sensor.next_holiday.next_holiday_future.holiday }}

The above errors out with the following:

In 'template' condition: UndefinedError: 'homeassistant.helpers.template.TemplateState object' has no attribute 'next_holiday_future'

AND
condition: numeric_state
entity_id: sensor.next_holiday
attribute: days_until_next_holiday
below: 14

Happy to PR some docs up, but first I'd need to understand how it works, and how I am messing up. Thanks!

Hi. Good points. thanks for saying so.

For example if a user wanted to create a simple automation that turned on 'Christmas lights' if Christmas was the next holiday and it was 14 days until Christmas <- How would we best do that?

That would be a template condition with something like:
condition:
  alias: "Almost Christmas!"
  condition: template
  value_template: >
     {{ states('sensor.next_holiday') == 'Christmas' and
        state_attr('sensor.next_holiday','days_until_next_holiday') < 14  }}

I'll add this and a few other examples to the docs if this helps.


Restrict request params of CreateHook for repos and orgs to known subset

Fixes #1015.

Thank you, @gauntface!
Merging.


luci-app-fwknopd: Invalid UCI config keytype and hkeytype

Using luci-app-fwknopd (git-18.219.52706-a49e4e4-1) with fwknopd (2.6.9-4) and it generates invalid entries to UCI configuration that is not recognized by fwknopd (keytype and hkeytype) as shown below:
config access
        option SOURCE 'ANY'
        option KEY_BASE64 '<KEY_VALUE>'
        option keytype 'Base 64 key'
        option HMAC_KEY_BASE64 '<HMAC_KEY_VALUE>'
        option hkeytype 'Base 64 key'
        option FW_ACCESS_TIMEOUT '60'

It generates some warnings from fwknopd as shown below:
Mon Aug 13 11:49:25 2018 daemon.err fwknopd[7586]: [*] Ignoring unknown access parameter: 'keytype' in /var/etc/access.conf
Mon Aug 13 11:49:25 2018 daemon.err fwknopd[7586]: [*] Ignoring unknown access parameter: 'hkeytype' in /var/etc/access.conf

This issue doesn't block fwknopd to function correctly.

These are hints for the luci interface.  Fwknop warns, but otherwise ignores this info.  I don't consider it a bug.


RuleBasedIpFilter can not reject connection

I used RuleBasedIpFilter to reject some remote IP's connection, but sometimes the reject action do not success. I create a class MyIPFilter extends from RuleBasedIpFilter and override the channelRejected to print some information like "channelRejected", and I found the "channelRejected" was printed, so I think accept function tested the reject rule and return false, but the decoder in pipeline after MyIPFilter always be fired and throw the exception when I readBytes from in buffer in decode function. If I add a customer handler extends from ChannelInboundHandlerAdapter after RuleBasedIpFilter, sometimes the new handler will call exceptionCaught with exception "connection close by peer".
What happened or why this happened? Does this is a issues?
All of 4.0.31,4.0.32,4.0.33 have this problem.

Can you show us the exact code ?
Also the connection close by peer can happen if the remote peer closed the exception in between.

Thank for your reply.
I wrote a question at stackoverflow, but there was nobody answer from then on. There had detail code and echo information, url is http://stackoverflow.com/questions/34026784/same-ip-block-code-using-netty-rulebasedipfilter-but-one-is-success-another-fai

The exceptionCaught is not occur everytime. Besides, not all of the pipeline, which has DelimiterBasedFrameDecoder, work fine, some reject and stop fire to next decoder, others reject but still fire to next decoder.

I will close this for now. If you still think there is an issue please reopen with more infos


HTTP/2 Support

What are the current plans regarding HTTP/2 support for the REST API? I think it would make sense to be HTTP/2 by default, and have an option for opting into the older protocol or support falling back.

Thats actually a great suggestion! The golang http driver defaults to HTTP/2. Its on the client to initiate the http requests using http/2. The js client consumes the rest endpoints also defaults to http/2 (if supported by the browser). On the other hand, all other clients (in different languages use the gRPC endpoint which uses http/2 and protobuf under the hood.
So i believe we already have this feature implemented!

Okay awesome, thanks!


Move building from source docs to contributing guide

Fixes #1647
This collects the branching conventions and build instructions to the contributing guide and explains where to find the plugin jar after a successful build.

build

I will follow up on this by updating the https://nvidia.github.io/spark-rapids/docs/dev/testing.html section of our doc to be building and testing and point to the contributing guide.


Point to new embed-flutter.html

https://dartpad.dartlang.org/embed-flutter.html is the new location. I just changed the text to tell people to go to the new location.
This is a "hacky" temporary fix that shouldn't break anything since I'm just changing the "placeholder" message.
[#1363]

Thank you for submitting this -- your PR actually put us in an awkward spot, though. :)
Over the past few weeks, we've been readying a reorganization of DartPad's code that adds Flutter support to the front page. That reorg, which we just published, removes the file that you've modified here, so it doesn't make sense to merge this PR. Because we didn't want to spoil the surprise, though, I couldn't just say that on your pull request when you submitted it, which is why it's been sitting here for so long.
This is a long way of saying:

Thanks for making a contribution.
We can't actually merge it.
Please don't interpret the ten days it took me to respond as any sort of comment on your PR or its importance. We'd love for you to continue looking for ways to contribute.

No problem. Glad that things well at Flutter Interact!


FAQ page - Public View

@S7mitbarua

Improved wireframe for FAQ Page.
Link to Figma
https://bhpa.vercel.app/public/faq

Opened ticket! For FAQ- I need to ask Katharine or Chris what kinds of should BHPA should have on the Frequently Asked Questions sections (before we further) attempt to design.

I coded the basic FAQ as seen on https://bhpa.vercel.app/public/faq . We need the content from Chris I believe


Add Call Graph [WIP]

TODO:

[x] Call Graph Docking

[x] Move to own Window
[x] Bundle in one TabPane for Docking
[x] Refocus of method (navigation)

[x] Method Handles (?)
[x] Dynamic methods
[x] Fix NPE
[x] Support for workspace updates:

[x] Add Library
[x] Add new class
[x] Update Class
[x] Delete Class
[x] Remove Library

[x] LinkerResolver caching
[x] Show unresolved calls
[x] Threading Issues?
[x] Cache ClassInfo?
Make Toggle for Call Graph

This PR is stuck, as it needs an inheritance graph which can resolve methods correctly compliant with JVM behavior.
https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-5.html#jvms-<IP_ADDRESS>

Thanks to @xxDark with https://jitpack.io/#xxDark/jlinker , I will try to implement further calls.

On another note, I will probably swutch to a standalone tab (dock) instead of it being at the right.

Migrated to new branch under: https://github.com/Col-E/Recaf/tree/dev4/recaf-api/src/main/java/software/coley/recaf/services/callgraph
Anything seem to be missing?

Feedback from xDark, can address on dev4

There are reports, these colors are not very suitable. If someone can give better ones, I would gladly accept and integrate.
Otherwise, I would put this as ready to be merged.

Its finally been ported over to dev4 🥳
06987b0996c417dd17e8b743c1423d1122e0644d

Closing now that 4.X has the same functionality, we can continue from there rather than on this 3.X branch


support other width:height ratios than 4:3

especially very wide and not high views lead to a bad reset view

Fixed in v1.5.9


feat: shared browser install when calling getBinary() multiple times + support custom cache directory

This improves getBinary() so if it's called multiples times for the same browser version, the install process will occur exactly once.
This works by using a singleton pattern (if the function was called previously, the already pending promise is returned). In prevision of #24
This also fixes a small issue introduced with #18 where the quiet install would actually be the default if not specified
Also, during the addition of tests for this I had to implement #19 to simulate a download failure and ensure that the singleton would get reset (meaning end-user would be able to retry launching the browser later if they handled the previous error), so it also closes #19

I think it would be great if you were able to enable parallel tests in this PR!

I suspect the issue is that --parallel runs tests in different processes. You'd somehow need to create a file lock to tell other processes to "just wait until the binary is downloaded".

More hanging tests, unfortunate.

I think I understand what's happening, it's not possible to enable parallel currently because all the tests spawn the browsers on same port 9222, so all the tests conflicts together 😅

Oh that's definitely possible, let me see if I can make a PR that dynamically adapts the port.

Oh that's definitely possible, let me see if I can make a PR that dynamically adapts the port.

I think the way to do is is to let chrome choose the remote debugging port automatically, that's how puppeteer does it:
https://github.com/puppeteer/puppeteer/blob/1a734257f203c5f73744a9f06a1d590aff9f8ac8/packages/browsers/src/launch.ts#L140C21-L140C21
export const CDP_WEBSOCKET_ENDPOINT_REGEX =
  /^DevTools listening on (ws:\/\/.*)$/;

I think the way to do is it to let chrome choose the remote debugging port automatically

I did this originally, but the issue is that firefox's debug protocol prints a different message. Technically, there are other issues with FF support atm so maybe we just don't care about that for now and come back to it later. FF should be in 0.4.0 if all goes well.

Maybe it doesn't? I don't remember why I stopped doing that. Weird. I'll just do that. Give me ~5 minutes.

Still working on it. Turns out this is a slightly bigger refactor than I would have expected 😅

Let's see: https://github.com/lino-levan/astral/pull/26/files

@lowlighter merged my PR. Could you try to update your branch?

@lowlighter merged my PR. Could you try to update your branch?

I'll rebase it 👍
Still making some changes on it

It seems to works on Linux now (don't know for mac os since it gets canceled before the result)
Still needs to check for windows, not sure why the executable isn't able to boot somewhere along the tests

not sure why the executable isn't able to boot somewhere along the tests

This usually means that there was an error running the executable and it usually prints out a log. No idea why there isn't a log or why it's failing to boot. Strange. I can test your branch on MacOS right now.

All tests pass on my Mac.

It seems I can reproduce on Windows, not sure if it's separate errors, but it may be possible that when spawning the browser there is an exclusive lock that get attached to the DLL so it's not possible to create another instance of it ?
Wait for selector => ./tests/wait_test.ts:5:6
error: Error: The process cannot access the file because it is being used by another process. (os error 32): open '******\.astral\118.0.5943.0\chrome-win64\chrome.dll'
      const file = await Deno.open(path, {
                   ^
    at async Object.open (ext:deno_fs/30_fs.js:574:15)
    at async decompressArchive (file:///******/astral/src/cache.ts:111:20)
    at async _getBinary (file:///******/astral/src/cache.ts:238:5)
    at async launch (file:///******/astral/src/browser.ts:166:12)
    at async file:///******/astral/tests/wait_test.ts:7:19

Wait for function => ./tests/wait_test.ts:20:6
error: Error: Your binary refused to boot
    throw new Error("Your binary refused to boot");
          ^
    at runCommand (file:///******/astral/src/browser.ts:50:11)
    at eventLoopTick (ext:core/01_core.js:183:11)
    at async launch (file:///******/astral/src/browser.ts:220:33)
    at async file:///******/astral/tests/wait_test.ts:22:19

I think I'll check later, thanks for helping and for implementing #26

Sounds good. Let me know if you want me to investigate further (though I'd have to obtain a windows computer!).

I have experimented some last stuff before sleeping, ssems that on Windows for some reason the exit code 21 gets triggered when ran in parallel really quickly
It seems to be a "NETWORK_CHANGED" error:
https://source.chromium.org/chromium/chromium/src/+/main:net/base/net_error_list.h;l=90-91
I wonder if it's because there is special handling for the bindings that occurs on windows to reuse the same process 🤔 ?
One thing to note is that it doesn't occur with --headless=old (though even if the tests passed it hangs on local machine)
The dirty fix I put needs to be removed, it was just for testing the CI.
It seems that all tests are "passing", but there are Web socket leaks on windows, I'm not sure where it does occurs. I thought it was maybe in page but apparently it had no effects

@lino-levan
Ok I think I've mostly achieved to make everything work, but since this PR got quite huge I think I should split the different changes into smaller PR to make changes more trackable/reversible and clean some stuff so it's easier for you to review
I think there was a potential op leak in celestial bindings related to Websockets
While Websocket.close() starts closing the websocket, it may actually not be closed instantly (I've confirmed by checking the ws.readyState after and before, and sometimes you may have ws.CLOSING state rather than Websocket.CLOSED.
Looking at other people with same issue https://github.com/denoland/deno/issues/12815#issuecomment-974057915 it looks like it's intended that you look that the websocket has been closed yourself.

Splitting the PRs would be great. Reviewing this (and reverting these changes if need be, as you mentioned), would definitely be a challenge. I appreciate the work!

Unless you really want to split this PR, outside of my one nit, this LGTM.

I'll split the PRs if you don't mind 👍
The lock file shouldn't be combined with the combined cache features since they're not entirely related, especially since I think that one day we may have Deno.flock() not in unstable anymore so it'll be way easier to perform the cleanup
I think it's better for tracking changes anyways

Did the three PRs cover this one? Is there more that this PR does?

Did the three PRs cover this one? Is there more that this PR does?
Edit: I guess the locking logic isn't implemented?

Yeah it's still missing the lock feature, I'll rebase shortly, but I have a design question for you though
This pr actually has 2 "lock mechanisms", one promise based and the other lock file based
The promise one is intended to limit the download of a same browser to a single one within the same process (calling launch() multiple times would just return the previous promise created, instead of starting a new install). Using promises has the advantage of not requiring any permissions since it's in memory
The lock file has been added because for parallelism in different process, it's not possible to use the promise mechanism.
Technically the lock file also achieve the same as the promise based so we could use only a lock file, the only thing is that it requires write permissions (but technically I think the user would already have given write access to the astral cache)
Should I just keep the lock file then ?

I think just the lock file makes sense to me.

@lino-levan Ok this is finally ready !
Thanks again for your patience, hope I didn't disturb too much with my PRs 🙇


Refactor render error

This PR includes:

Resolves #987, now it's possible edit/disable 404 error in passwords#create
Refactor the errors rendering (not the resource's errors), so it's possible to change how to return them. In my opinion, we shouldn't be using errors for an array with a message, in the frontend you have to ask if it's an array vs hash (instead of asking error vs errors), it's kind of ugly. As I don't know if I can make that change (because I can break ng-token-auth), I moved how the errors are returned to a method.
Removed @error_status and @errors from passwords/unlocks controller, they made the possible flows more complex
Added Ruby 2.2 and 2.4 to Travis, so we can support more rubys.
Renamed is_json_api, following the ruby style guide

I don't see any problems with this PR, looks good to me. Will wait for one more positive review before merging though!

@MaicolBen I can merge this if conflicts are solved!

These changes look good and are definitely an improvement. My only concern is that changing the error format will break compatibility with existing clients.
@MaicolBen - what do you think about adding a deprecation warning to the old format for the next release, and then switching over to a new format by default in the following release?

@zachfeldman Rebased
@lynndylanhurley I don't know if the deprecation could help here because the frontend won't change it until we change how we send the responses (it isn't like the methods or fields removal).

Thanks @MaicolBen ! Looks good to merge to me but will wait to merge until @lynndylanhurley blesses it or decides we need a deprecation warning.

will wait to merge until @lynndylanhurley blesses it or decides we need a deprecation warning.

Has the error format changed with this PR? Maybe I misunderstood but I thought this PR just provided an easier way to override the error format.

@lynndylanhurley As you said, this PR doesn't change the error format (you can see there aren't test changes), only provides an easy way. In the description, I recommend not using arrays for an error message, but that can be done in another PR for the next release.

Cool, that's what I thought, just making sure.
This looks good to merge. Let's address the error format issue in another thread.


Disambiguate fladistctapp docket numbers

From https://github.com/freelawproject/courtlistener/issues/4256
We return docket numbers as we find them in the HTML. However, we should prepend f"{district_number}D" to the docket number, as is done in the opinion files themselves.

These 2 are asigned to the same docket:

Some more evidence of the full docket numbers

This is now working
https://www.courtlistener.com/opinion/10103065/robert-anthony-zaccaro-v-state-of-florida/?q=court_id%3Afladistctapp&type=o&order_by=dateFiled desc&stat_Published=on


Pool 1305 gov new governance site designs

I added this to figma, but might be useful while reviewing. This table is all the states for the VotingPowerCard components when looking at it on the main ProposalsUI page.

@ddesrosier Getting Module not found: Can't resolve 'lib/components/UsersPoolVotesCard'

Here's what the loading screen looks like 🙈  😄

The current network text is unreadable on the light theme:

If we update the Card component (I believe it's Card) from bg-default to bg-card then we'll get white backgrounds for cards that will stand out against the off-white body background on the light theme. I changed one of them using the Chrome devtools inspector as a demo:


Apparmor profile for rsync

Similar to what was done with the unpackers in https://github.com/lxc/lxd/pull/9906, rsync should also be contained by Apparmor.

I'll take it.

Thanks!

@Viktor-Yakovchuk thanks!


remove symlinks for windows

currently if you try to build zine-sample-site on windows, zig will try to download zine and fail because of the symlinks:
Fetch Packages [3/1] Checkout... C:\git\zine-sample-site\build.zig.zon:6:20: error: unable to unpack packfile
            .url = "git+https://github.com/kristoff-it/zine.git#f2e6974344221bff95d465f7b037237d51f8b7d5",
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: unable to create symlink from 'tree-sitter\tree-sitter-ocaml\interface\corpus\module-items.txt' to '../../ocaml/corpus/module-items.txt': AccessDenied
note: unable to create symlink from 'tree-sitter\tree-sitter-toml\tree-sitter\CONTRIBUTING.md' to 'docs/section-6-contributing.md': AccessDenied
note: unable to create symlink from 'tree-sitter\tree-sitter-toml\tree-sitter\script\reproduce' to 'run-fuzzer': AccessDenied
note: unable to create symlink from 'tree-sitter\tree-sitter-typescript\tsx\corpus\common' to '../../common/corpus': AccessDenied
note: unable to create symlink from 'tree-sitter\tree-sitter-typescript\typescript\corpus\common' to '../../common/corpus': AccessDenied
note: unable to create symlink from 'tree-sitter\tree-sitter\CONTRIBUTING.md' to 'docs/section-6-contributing.md': AccessDenied
note: unable to create symlink from 'tree-sitter\tree-sitter\script\reproduce' to 'run-fuzzer': AccessDenied
C:\git\zine-sample-site\build.zig.zon:6:20: error: unable to unpack git files: InvalidGitPack
            .url = "git+https://github.com/kristoff-it/zine.git#f2e6974344221bff95d465f7b037237d51f8b7d5",

I just removed the symlinks in this PR and now it works.  Not sure if these symlinks are needed for something else?

Thanks!

I was able to build successfully on macOS so I guess they aren't that important afterall :^)


Question : Following the guide from reactnative native modules for Android throws error

Hi devs.
In process of creating Native modules for Android (Following what is mentioned in https://facebook.github.io/react-native/docs/native-modules-android.html#content)
I get this error while app compilation .
..src/main/java/com/azharapp/AnExampleReactPackage.java:15:error: AnExampleReactPackage is not abstract and does not override abstract method createViewManagers(ReactApplicationContext) in ReactPackage
Thanks.

And also please tell us where to write the Java files for the native modules. Can they be siblings to MainActivity.java..  ?
Thanks

You need to implement the createViewManagers method and createJSModules. The package file will be something like this,
class AnExampleReactPackage implements ReactPackage {
    @Override
    public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
        return Arrays.<NativeModule>asList(
                new WebSocketModule(reactContext),
                new IntentModule(reactContext)
        );
    }

    @Override
    public List<Class<? extends JavaScriptModule>> createJSModules() {
        return Collections.emptyList();
    }

    @Override
    public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
        return Arrays.asList();
    }

I don't think the package for the native modules really matters. As long as you can access the package class in the MainActivity, you should be good to go.

Worked Perfectly .. Thank you very much !!
Closing.

For those, visiting this link for similar issues, some more info. I realised that your react package should be added in addition to the MainReactPackage. So it goes like this
mReactInstanceManager = ReactInstanceManager.builder()
.setApplication(getApplication())
.setBundleAssetName("index.android.bundle")
.setJSMainModuleName("index.android")
.addPackage(new MainReactPackage())
.addPackage(new AwesomeReactPackage())
.setUseDeveloperSupport(BuildConfig.DEBUG)
.setInitialLifecycleState(LifecycleState.RESUMED)
.build();

well i am getting "

method does not override from its superclass

" error while implementing ReactPackage interface... ReactPackage does not contain such method I've seen


airnode-validator allows duplicate provider names in chains[n].providers

Version
master
Present Behaviour
A config.json with duplicate chains[n] provider names is valid.
Expected Behaviour
I think this should be disallowed by airnode-validator because of how the provider URL is fetched using the name in buildEVMState, and to avoid confusion within logs.
https://github.com/api3dao/airnode/blob/ad642715afcfb9fe690239ce5f3e0482a4b289fb/packages/airnode-node/src/providers/state.ts#L11-L19
Steps to reproduce
Run airnode-validator, e.g. its CLI, against a config.json with duplicated chains[n].providers, for example:
      "providers": {
        "exampleProvider": {
          "url": "${PROVIDER_URL}"
        },
        "exampleProvider": {
          "url": "${PROVIDER_URL2}"
        }
      },

(and also update the secrets.env to have both url variables for interpolation).

Closing as new duplicate keys overwrite old ones when JSON is parsed upstream of any validation. Consequently it's not worth checking for this rather silly and unlikely error.
const p = JSON.parse(`{
  "providers": {
    "provider1": "text",
    "provider1": "new"
  }
}`);
console.log(p);

Output:
{ providers: { provider1: 'new' } }

Interesting that JSON.parse() doesn't mind this


Problem with WikiLink rendering

I have added the WikiLink extension. But when I render this
This is a link [[http://www.example.com/]].

This is a link [[Example http://www.example.com/]].

I get:

This is a link http://www.example.com/.

This is a link Example http://www.example.com/.
<

(Note the wrong href attributes.)
Am I doing something wrong or is this a bug?

@mnlipp, wiki links are for page references not links.  +/<> characters in the wiki page ref are changed to dashes - before creating the link with the page ref. It has options and link resolver that can be implemented to create custom page ref to link resolution.
GitHub Wiki, for example, ignores directory structure when resolving a link to an actual file.

Thanks for the clarification. I found this as first search result and had different expectations.

@mnlipp, the example you looked at is correct. If you notice the page ref is passed through, in this case with the exception of adding a prefix and suffix of /. You can get this effect with by setting WikiLinkExtension.LINK_PREFIX option to / and WikiLinkExtension.LINK_FILE_EXTENSION option to /. The file extension is really just a suffix to the page reference.
There is no option to add a class but if needed it can be added either in the extension or via a custom attribute provider.


Add support for a single node having multiple bus types

Is your enhancement proposal related to a problem? Please describe.
I have i3c-controller.yaml that was made internally which has bus: i3c, and I have i3c-devices.yaml that has on-bus: i3c. But for the way i3c works, i2c devices can also compatible on the same bus (example: the i2c eeprom which includes i2c-device.yaml which has on-bus: i2c and won't look for the i3c buses. If I try to include i2c-controller.yaml from i3c-controller.yaml it complains with the error message 'bus' from included file overwritten ('i2c' replaced with 'i3c')
Describe the solution you'd like
I would like to see that the bus:  key can be a list, and they can also be merged rather than being overwritten through include: . For example: bus: [i3c, i2c]
Some devices also would support both i3c and i2c protocols. This could pose an issue when the scripts select the proper binding. I would imagine someone would always prefer i3c over i2c bindings and the priority could be included in the order of the list where it will first try to find a binding for i3c and select that. If not, it will walk down the list and select a binding for i2c.
Also the define generated should always match the binded bus, so that when selected with DT_ON_BUS, it will end with what protocol it is. For example, if there is an at24 eeprom (an i2c device) on an i3c bus, it will still return i2c with DT_ON_BUS.

wow... it's been a long time since I first wrote about this issue I found, but now as with interest coming upon other companies with i3c, I think it's time I revisit this issue
Reason for a Solution
I3C is a rather unique bus compared to other buses that zephyr supports. It supports I2C (to an extent) which zephyr has had support for a rather long time along with many existing device drivers that use I2C. It is rather important to maintain full compatibility with this bus API to take advantage of all the existing (and future) work done with I2C within Zephyr on a new I3C implementation.
by nesting the i2c_driver_api within the i3c_driver_api as the first item within it. This allows for all calls with the I2C APIs to an I3C dev to "Just Work"™
API Definition
__subsystem struct i3c_driver_api {
	struct i2c_driver_api i2c_api;
	// rest of the i3c specific api...
};

I3C Driver Implementation
static const struct i3c_driver_api i3c_device_driver_api = {
	.i2c_api = {
		.transfer = i3c_i2c_transfer,
		.configure = i3c_i2c_configure,
	},
	// rest of the i3c specific functions
};

Two Proposals for Fixes
Option 1: changing bus to allow for lists
One method of fixing it would be to change the zephyr device tree implementation within edtlib.py for the bus definition. Currently, the bus parameter only supports a single string. This will be problematic for binding on an i3c bus which can utilize all the existing i2c drivers and have their on-bus: i2c which won't bind to something defined as bus: i3c.
The bus would have to be defined as a list (ex. bus: ["i3c", "i2c"]) for it to bind both i3c and i2c devices. This also leaves support for it to just be defined as a string. The preference is also encoded in the list order so if there are bindings for both i3c and i2c, it will choose i3c as that is first in the list.
The only caveat I can see with this is if you have a device that supports i3c and i2c, it will always select i3c. I can't think of a use case right now where you'd want to force a device driver to use its i2c implementation as i3c is superior in every way to i2c... but with the way the zephyr build system is structured with bus and on-bus with it's compat. I can't think of any other workaround....
example implementation
https://github.com/zephyrproject-rtos/zephyr/pull/46451
Option 2: nest i2c devices as child-bindings on an i3c node
The other method I can think of fixing it would be to define a child-binding for an i3c-controller. This would be a childing node where all i2c devices would, but as with the way DT_BUS() works in all the existing I2C drivers, it would only return the child node. A work around would be to have a very specific compat for this that would be known to the gen_defines.py which would know to print out it's parent node for the DT_BUS() macro given it the i3c controller node.
example implementation
https://github.com/XenuIsWatching/zephyr/commit/a92f3d89dab54f078e69efb61753dac254f862c3


Pact

Fixes #
contract.md in order to not contradict the "design-first" rule
Proposed Changes

Adding PACT mandatory for CORE APIs and recommended for the rest of them

NodeJs and Java seeds in progress. We are co-creating them with several teams. We will add links to the seeds and examples asap.


Add some more Room options to SQL and admin page

each room should have it's own restrictions in addition to the general rooms group options.
From time, To time, active days.
we should create forms in room options and matching SQL table as well.

sounds great! would you mind adding 'Group general capabilities' TLV/strings array to the group_options as well? I could really use it for the form generation, in order to create checkboxes for the user to chose from...

Rotem is responsible for this part, i will assign him for this task.
nevertheless i have added some more room options as needed.


Make handling of long numerals an option that is disabled by default

Description
This change adds a config param named enableLongNumeralSupport which is false by default and users who wish to deal with precise long numerals can enable it.
This change needs to be added to the docs
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] Linter check was successfull - yarn run lint doesn't show any errors
[X] Commits are signed per the DCO using --signoff
[ ] Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

What's the reason for this? What are the downsides of always serializing long numerals correctly?

It is possible that users have adapted their logic to having imprecise numbers and are not ready to accept BigInts. One could argue that what we release in 2.3.0 was an enhancement but some could also argue that by successfully serializing BigInts (and not throwing) and deserializing long numerals into BigInts, we broke status quo and went against the universally known limitation of JSON.parse and JSON.stringify that people expect; one could argue that doing this by default is a breaking change.

What do you think about calling this serializeLongNumerals?

We could surely name it serializeLongNumerals for those who will be using it by importing the Serializer but the Client needs a switch to use or not use this. Instead of the Client and Helpers each having conditions to use serialize or serializeLongNumerals, in this PR, I handle the condition in only one place which is inside serialize.

This PR needs an update to USERS_GUIDE, too, please.

Done.

looks like we need a 2.3.1 release?

Can someone ELI5 why this is a breaking change?

Can someone ELI5 why this is a breaking change?

Unless I misunderstood something, we released 2.3.0 where the handling of long numerals is enabled by default, and 2.3.1 would disable it by default.


Fix authentication to private repos rebar3 hex user auth --repo [REPO]

Hey @derekkraan can you provide steps to reproduce the issue?

Hey, @starbelly, yes. This is the short version since I'm just on mobile now. I am working on a private repo for hosting (among others) Erlang packages. Running rebar3 hex user auth --repo codecodeship results in the auth data being saved for hexpm (in the rebar3 state) and not for code code ship, resulting in further calls (such as rebar3 hex publish --repo codecodeship) failing due to missing keys.
I hope this makes sense. I can do a better write-up on Monday when I'm back in front of a computer if necessary.

@derekkraan Ahhh I see, I literally just reproduced the issue right before you replied. This LGTM!

This bug fix reveals some other latent bugs.

We're not setting api_organization to undefined in fetching / building hex config at runtime (line 241 of rebar3_hex_config.erl)
We're not setting api_repository for non-hexpm config, this is included by default for hexpm default config, but not so for this case. This is probably per testing with nothing but hexpm and in that referring to it as hexpm vs an alternative name.

Of course, there's a fun dialyzer error to fix as well :) I'm happy you have opened this PR though so we can solidify this use case!

@starbelly there seems to be some confusion in the codebase. I believe that dialyzer is complaining about the attribute name, which doesn't exist on the type config() (only repo_name). I am not really sure what to do about this, since rebar3_hex is using name all over the place. Is this a bug? Do I need to set both name and repo_name in rebar.config?
I added some code to make sure that api_organization and api_repository are both being populated with undefined when that is appropriate.

Setting name appears to be enough to also set repo_name. I think this PR is good to go.

@derekkraan LGTM! (for real), this helped uncover yet another bug, but I'll fix that up in another PR. Thank you!


test: fix failing test AutoOperateTestExample and rename to AutoOperateExampleTest

Fix the failing test AutoOperateTestExample by adding the missing dependencies.
Renamed the test class to AutoOperateExampleTest to follow the naming convention.

Codecov Report
Patch and project coverage have no change.

Comparison is base (2133335) 91.68% compared to head (b301222) 91.68%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev     #110   +/-   ##
=========================================
  Coverage     91.68%   91.68%
  Complexity     1143     1143
=========================================
  Files           111      111
  Lines          2683     2683
  Branches        263      263
=========================================
  Hits           2460     2460
  Misses          115      115
  Partials        108      108

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

well done


ValueError('Data passed to ks_2samp must not be empty')

https://github.com/eic/EICrecon/actions/runs/6951726322/job/18914942243#step:11:127

Resolved by #10

Not fixed.

https://github.com/eic/EICrecon/actions/runs/6974064668/job/18979747841?pr=1144#step:11:631

Can't reproduce locally... which is annoying.


Update to EF Core 2.2

fixes #121

Improve test portability

This is most likely not needed, as 2.2 is backwards compat

Ok. I did plan eventually to update all used NuGet Dependencies to latest versions.
Guess no need to rush.

I will test and report back

same issue


Updated README with example output format syntax

A minor change, however as a new user of the software I was unsure what the syntax for specifying the output format was.
Did I need the ., or should it be all caps, or was there some other way of invoking it?
I spent a minute or so trying to figure it out.
This small example will mean that it will be immediately clear what the syntax is.

Thanks for the PR.  Hopefully this will save future users some time and avoid some confusion.
For future reference, you can run the following to see the help command:
audioconvert convert --help

This will output the following:
Usage: audioconvert convert [OPTIONS] INPUT_DIRECTORY OUTPUT_DIRECTORY

  Convert Input Directory Audio to Output Directory Audio

Options:
  -o, --output-format [.aiff|.flac|.m4a|.mp3|.mp4|.wav]
                                  Target output format
  -w, --workers INTEGER           Number of worker processes to run
  --help                          Show this message and exit.

Overall, the changes LGTM.


bash scripts using mapdir

Hi,
I noticed the wasmtime cli flags have been redesigned in https://github.com/bytecodealliance/wasmtime/issues/6741. But the bash script here seems to still be using the old ones. Maybe it's better to update them.

Sure! You want to take a stab at this change?

Sure! You want to take a stab at this change?

Sure, my pleasure.


DCOS-21772: add CI/CD

Green build without deployment

Deployment doesn't seem to work because the repo is not cloned. I am honestly unsure if it wouldn't be better making it a postrelease hook instead 🤔
https://jenkins.mesosphere.com/service/jenkins/job/Frontend/job/UI-Kit Pipeline/view/change-requests/job/PR-5/5/
(working around is possible but not so nice)

@DanielMSchmidt we want to have the storybook build/GH pages updated on each PR merged.
The UI Kit page should have the most recent from master. Basically a "nightly" build.
Let's try to figure out a way to have it done. I have a couple ideas how we can handle that so I will set a meeting for us including @Poltergeist

BTW, this is really good, thanks for opening the PRs! 🎉 ❤

@weblancaster I think the only thing we still need is to store a GH token for this repo in our Jenkins secrets 👍

@weblancaster I don't know if we need hold merge. It is done from a code perspective, only permissions in Jenkins / GH need to be updated :)


Breaks when user settings are added

I followed the advice on the default .sublime-settings and put this in my user configuration LaTeXWordCount.sublime-settings:
{
  "LaTeX": {
    "exclude_footnotes": false
  }
}

Then, when I run the word count, nothing appears to happen. This is printed on the console:
Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 549, in run_
    return self.run(edit)
  File "WordCount in /Users/jonchan/Library/Application Support/Sublime Text 3/Installed Packages/LaTeX Word Count.sublime-package", line 142, in run
  File "WordCount in /Users/jonchan/Library/Application Support/Sublime Text 3/Installed Packages/LaTeX Word Count.sublime-package", line 89, in wordcount_latex
TypeError: 'NoneType' object is not iterable

I've also tried this with "exclude_abstract": false. This doesn't happen when the user config file is deleted, and appears to happen even if a blank file is present.

Hmm the current version can't look up default values that are nested in other config elements, so as a workaround for now you could simply copy-paste the entire "LaTeX" configuration block and adjust the exclude-options in there, i.e. have this as your user package settings:
{
	"LaTeX": {
		"markup_commands": ["text\\w+", "uppercase", "uline", "emph", "caption"],
		"exclude_headers": false,
		"exclude_footnotes": false,
		"exclude_appendices": true,
		"exclude_abstract": false
	}
}

Please let me know if that works for you

It does! Any ideas on how to fix it? I don't know Python, so I can't help.


Offload HostVNicDetail to NetAdapterWorkerPrepare, and fix #1

Fix three bugs:

HostVNIcs are queried twice (once by as a host vnic, and again by NativeNicDetail)
Bug #1
Removed Get-VMNetworkAdapterFailoverConfiguration query for host vNICs because it only applies to VM NICs.

Hi Tom,

It looks form this change that now the output is not saved in a named Host vNIC directory anymore.
It's also not clear if the Host vNIC has both the NetAdapter and VMNIC sides of the device captured.
Please confirm the before and after Get-NetView output still displays the named Host vNIC directory AND contains both outputs highlighted below
*   @.***

From: Tom Molenhouse @.>
Sent: Wednesday, October 13, 2021 2:23 AM
To: microsoft/Get-NetView @.>
Cc: Omar Cardona @.>; Review requested @.>
Subject: Re: [microsoft/Get-NetView] Offload HostVNicDetail to NetAdapterWorkerPrepare, and fix #1 (#52)
@tmolenhhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftmolenh&data=04|01|ocardona%40microsoft.com|ca864441b903453cc8a908d98e2b1718|72f988bf86f141af91ab2d7cd011db47|1|0|637697138003796156|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=7AyIkegDQzIej9ZxIv6mh4HrBXhxumjOoZMYu%2F8iTcY%3D&reserved=0 requested your review on: #52https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FGet-NetView%2Fpull%2F52&data=04|01|ocardona%40microsoft.com|ca864441b903453cc8a908d98e2b1718|72f988bf86f141af91ab2d7cd011db47|1|0|637697138003806117|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=zMzOC8XB8MW0enpwY9P3Z9dMXpwIF%2Fq2S79q%2FPrhTK4%3D&reserved=0 Offload HostVNicDetail to NetAdapterWorkerPrepare, and fix #1https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FGet-NetView%2Fissues%2F1&data=04|01|ocardona%40microsoft.com|ca864441b903453cc8a908d98e2b1718|72f988bf86f141af91ab2d7cd011db47|1|0|637697138003806117|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=hk9cZxZMu3Y5Bo7fTMqYDNrm3xZTyw%2BZ6PK44ht5g10%3D&reserved=0.

You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FGet-NetView%2Fpull%2F52%23event-5455750250&data=04|01|ocardona%40microsoft.com|ca864441b903453cc8a908d98e2b1718|72f988bf86f141af91ab2d7cd011db47|1|0|637697138003816069|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PIklVAiGHTT%2BHUitWNAh5KSlzuJ7pUNDGHXQnqVM%2Fm4%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE7FREF5GIDJQFJ3EBZ32P3UGVFYJANCNFSM5F4WLY2A&data=04|01|ocardona%40microsoft.com|ca864441b903453cc8a908d98e2b1718|72f988bf86f141af91ab2d7cd011db47|1|0|637697138003816069|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=oCYClI854NawNwC5Yjm0oJ91tSX4JB5xZ10yVOVR%2BnM%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|ocardona%40microsoft.com|ca864441b903453cc8a908d98e2b1718|72f988bf86f141af91ab2d7cd011db47|1|0|637697138003826027|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=v1hXyhhiprBroo6rGLcjHFbbae0w%2FZ0P2DqbvAea8Ic%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|ocardona%40microsoft.com|ca864441b903453cc8a908d98e2b1718|72f988bf86f141af91ab2d7cd011db47|1|0|637697138003826027|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=G7d72h4hfq86%2FDBGxMsm9IG3LvBkF%2B40wsscO1dpTl8%3D&reserved=0.

In the After output below, the Host vNIC 11 Container name is dropped.
How do we quickly distinguish usage?  For example, standard Host vNIC vs Container NICs?

From: Tom Molenhouse @.>
Sent: Thursday, October 14, 2021 1:12 AM
To: microsoft/Get-NetView @.>
Cc: Omar Cardona @.>; Review requested @.>
Subject: Re: [microsoft/Get-NetView] Offload HostVNicDetail to NetAdapterWorkerPrepare, and fix #1 (#52)

I can confirm that both NetAdapter and VMNIC/VMNetworkAdapter sides are still captured.
Here is how the folder structure has changed:

Before
(Note that both folders marked with green are identical contents. Same is true for red marked folders):
[before]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F16905767%2F137275076-58329cb8-2c5c-40dc-a6b0-57b2a631f7eb.png&data=04|01|ocardona%40microsoft.com|3a3599f4b7e14a9d63b608d98eea40ae|72f988bf86f141af91ab2d7cd011db47|1|0|637697959026980507|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=wF91fRl0fuG2xfBaQlPpdxHvjblx8Rtdh%2FevrOeJUTc%3D&reserved=0
After:
[after]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F16905767%2F137275145-5745808f-58fb-4862-8fc1-c37bbece0307.png&data=04|01|ocardona%40microsoft.com|3a3599f4b7e14a9d63b608d98eea40ae|72f988bf86f141af91ab2d7cd011db47|1|0|637697959026990466|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=giVlBaNbV1cY7PBtogb6GzaCKIWqfYASH0PPKvntCFA%3D&reserved=0

You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FGet-NetView%2Fpull%2F52%23issuecomment-943119027&data=04|01|ocardona%40microsoft.com|3a3599f4b7e14a9d63b608d98eea40ae|72f988bf86f141af91ab2d7cd011db47|1|0|637697959026990466|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=G0avGE21oCqqN3VP%2FAtH9Zvbd7%2Fs%2B1f%2FxD8s2NE%2B8OU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE7FREDFFQIU6A4MGFJUIWTUG2GDZANCNFSM5F4WLY2A&data=04|01|ocardona%40microsoft.com|3a3599f4b7e14a9d63b608d98eea40ae|72f988bf86f141af91ab2d7cd011db47|1|0|637697959027000424|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=f65jBH0hEh%2FcGOSj6IqWKPBWlbkqKclpNlcnmy2hUp8%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|ocardona%40microsoft.com|3a3599f4b7e14a9d63b608d98eea40ae|72f988bf86f141af91ab2d7cd011db47|1|0|637697959027010376|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=O4VWPxcxZAMwin2Ar5lYYu79jINe3ZtD3eNVIXMRQ9o%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|ocardona%40microsoft.com|3a3599f4b7e14a9d63b608d98eea40ae|72f988bf86f141af91ab2d7cd011db47|1|0|637697959027010376|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=q%2BEqZWkNmtBsbIwqeImP8Vk%2BIVH1fPWsgytjjcrEIWo%3D&reserved=0.

Point still stands that "Container NIC abc" is just the naming convention HNS uses for its vNICs.

The name does not convene any additional information beyond stating it is attached to the Default Switch. Get-NetView makes this painfully clear, so I'm confused by your claim that it can expedite investigations. Especially when my experience has been exactly the opposite.