Federation with External Identity Providers

My apologies if this is a duplicate - I have been using IdServer v2 for quite some time with basic setup with web-apps as RP's. I now need to configure IdServer as a Federation Gateway, so that it can accept token from Azure Active Directory.

Under Protocols -> WS-Federation -> I have Enabled, Enable Sign-In, Enable Federation, Enable HRD all selected (except Allow ReplyTo parameter).
Under Identity Providers I have added a new entry called adfs, Type - WSStar and the AADS's WS-Federation Endpoint and Thumbprint. Enabled & Include in HRD both are checked.

I have one client web app setup as RP.
when I navigate to the client web app, I get the redirection to idserver, but I always see just the Username Password login, not the HRD options for ADFS.
What am I missing?

Ok, I finally found the solution, just sharing for anyone else who come across the same.

All settings and configs remain the same. Except that I  had to use the hrd endpoint in place of wsfed endpoint in the RP web app's web.config. But I had read somewhere not to use hrd ep, so it was a bit confusing to use it or not, in the end it worked out though.
In Azure app, the App Id point to the STS issuer uri. Here all paths point to IdSvr since that will be the RP to Azure. That's it. It works seamlessly now.


youtube-dl: 2020.06.06 -> 2<IP_ADDRESS>

Motivation for this change
https://github.com/ytdl-org/youtube-dl/releases/tag/2020.06.16
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Upstream has released 2<IP_ADDRESS>

I updated the PR to the new version.

Ported to stable as dce9ef51057e2a1e5f78ec84cb0a8c3a3b218992.


Lock icon after SELECT

Description
I'm using dbeaver for linux, and sometimes I'm facing and odd behavior when I use SELECT, see:
... when I let the cursor over the query and I execute, the lock icon appears:

... when I select my entire query and I execute (for same query), the lock icon disappears:

Is there some hidden rule/explanation to the lock icon appears/disappears? This behavior doesn't always happen, it's intermittent, I haven't discovered a pattern.
Thank you since now.
DBeaver Version
Community Edition <IP_ADDRESS>308061552
Operating System
Ubuntu 20.04.6 LTS
Database and driver
"Driver for MySQL 8 and later" connected to MySQL "5.6.32-log" (SELECT version();)
Steps to reproduce

execute a simple SELECT letting cursor over query
execute a simple SELECT selecting all query

Additional context
No response

Hi @rodrigoguariento , thanks for the report.
Can you use MySQL 5 driver instead of MySQL 8 and write back if it helps?

It's been a while since no update here. If the issue is still actual please let me know and provide additional information.

Your suggestion solved my problem! Thanks.


Add fixed-load rate controller to calliper generator

fixes #1587

@duckling69 Hi thanks for the contribution, please could you add unit tests to please otherwise we can't accept the PR and as you can see the code coverage has reduced with the addition of the new code.

@davidkel did the review changes


OS3 meeting upload menu has several bugs

The OS3 meeting upload menu has some bugs:

[ ] the name of the selected file is not displayed.
[ ] the KnightRider bar has no animation.
(If a meeting is imported twice, there is no check if users already exist. Users are created again with a number after the name.) -> delegated to backend

Reproduction:

download an OS3 meeting file in https://testintern.openslides.com/62/mediafiles
open now on dashboard level committees and open a desired committee
click on the three-dot-menu and choose import meeting
use the OS3 meeting file and select it for upload
try to upload it

For third bug:
6. upload the meeting again and observe/compare duped names.
What should happen:

File name appears in the upload menu.
Addtionally the KnightRider bar works or some other visual feedback appears, which indicates, that the system is still working. Currently, without visual feedback, it is not possible to determine if the system is doing something or if the upload is interrupted.
The import should check if an account still exists, add it to the meeting and don't create additional duped users with numbers in the name.

I do believe the this specific import is handeled in the backend.
The problems with the display and animation is clearly client-side, however as for the faulty result (of newly created users), that would be a backend problem.
I'm opening an issue in the backend for this.

Issue created: OpenSlides/openslides-backend#1429
@MSoeb could you check if you have anything to add to that issue?

@luisa-beerboom Yes, the Issues describes the problem well.

Except of the the linked backend issue, the first two checkboxes should be fixed.


useful backup information for databases taken using t-sql snapshot ap…

…proach
Added the following query that i think will add value to the content:
select database_name,type,backup_size,backup_start_date,backup_finish_date,is_snapshot from msdb.dbo.backupset where is_snapshot='1';

@perrysk-msft
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@emad-almousa Thanks for your contribution.
We have noticed the number of contributions from you, and we appreciate your passion in wanting to improve the documentation. However, there are some formatting and style basics that are outlined in the contributor guide, that you should be mindful of.
When editing existing content, your contribution needs to match the existing style exactly. You also need to check your spelling and grammar carefully.
Additionally, your contribution has to add value to the millions of readers we get looking at our documentation every year. Adding something that you think is cool, might seem valuable to you, but may not meet our editorial guidelines. Every contribution you make needs to be maintained for the lifetime of the product, and that includes the people who are translating our content into multiple languages. For instance, we still have many articles that contain wording first written in the 1990s.
You can visit https://learn.microsoft.com/style-guide/ to read our text formatting and style guide. Please pay particular attention to text formatting, voice, and style.
Again, thank you. Please don't take offence if we close your PRs. As you get more familiar with how we do things here, you'll begin to recognise what we will find valuable.
I would also like to encourage you to start your own blog if you have not yet done so, to practice your writing. That's the best way to learn.

This change has been included in an internal PR, which modifies the formatting to match our style guide. This PR will be closed automatically, and the change will be published in the next day or so.
Thank you again for your contribution.

@rwestMSFT   Thanks for your feedback. In the future I will be more careful about formatting style, spelling,....etc.  My objective is to improve the documentation within the context of the topic and technology itself....at the end your team are the SME's to decide and review if the "proposed" suggestion worth addition or not.
side remark: I have 3 blogs that I proactively write content in:
https://sqlserverwarrior.wordpress.com/
https://geodatamaster.com/
https://databasesecurityninja.wordpress.com/
Thanks again and Have a Nice Day
Emad

@emad-almousa Thank you for responding. I will add those URLs to my personal RSS feed.
We appreciate your contributions, so please keep them coming. You should already see the refreshed snapshot article today with your contribution, and you listed as a contributor.
Here's a link to the section: https://learn.microsoft.com/en-us/sql/relational-databases/backup-restore/create-a-transact-sql-snapshot-backup?view=sql-server-ver16#list-backupset-details-for-t-sql-snapshot-backups
If you click on the list of contributors, your name is third in the list.


Wip/core vertx decouple

Reopening, as this was meant to be merged and not closed imho.

Re-opening to merge @mcarolan PR.


Batocera-EmulationStation Mac Port, compiled but not working. Open Gl Error

Hi to everyone, i compiled the old ES 2.1 version on mac and succeded in making it working. But it's to old and without all the improvements batocera's team made.
I tried to compile batocera's ES and it succeded, but it automatically closes just after launch, and throws an OpenGl error:
/Users/pablojimenez/Github/EmulationStation/Debug/emulationstation ; exit;
Nov 25 16:44:28 lvl0: 	GL error: glGenTextures(1, &texture) failed with error code: 1280
Nov 25 16:44:28 lvl0: 	GL error: glEnable(GL_TEXTURE_2D) failed with error code: 1280
Nov 25 16:44:28 lvl0: 	GL error: glEnableClientState(GL_VERTEX_ARRAY) failed with error code: 1282
Nov 25 16:44:28 lvl0: 	GL error: glEnableClientState(GL_TEXTURE_COORD_ARRAY) failed with error code: 1282
Nov 25 16:44:28 lvl0: 	GL error: glEnableClientState(GL_COLOR_ARRAY) failed with error code: 1282
Nov 25 16:44:28 lvl0: 	Error - File type unknown!
Nov 25 16:44:28 lvl0: 	GL error: glMatrixMode(GL_PROJECTION) failed with error code: 1282
Nov 25 16:44:28 lvl0: 	GL error: glLoadMatrixf((GLfloat*)&_projection) failed with error code: 1282
Assertion failed: (!err), function FontFace, file /Users/pablojimenez/Github/EmulationStation/es-core/src/resources/Font.cpp, line 21.
Abort trap: 6
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
Any idea on how to face the error??
Thanks in advance
Pd: i didn't edit any file, just compiled the source as it is

There are 3 possible GL engines GLES, GLES3 & desktopGL when compiling
Try to change using "-DGLES=OFF -DGLES2=OFF -DGL=ON" with cmake or maybe "-DGLES=ON -DGLES2=OFF -DGL=OFF"
If it does not work try to play with thoses lines in the code  :
SDL_GL_SetAttribute(SDL_GL_CONTEXT_MAJOR_VERSION ...
SDL_GL_SetAttribute(SDL_GL_CONTEXT_MINOR_VERSION ...
To change the major & minor version to use.
If does not work... I don't use a Mac, so...

Thanks a lot, i will give it a try and post the results!!

Hi @fabricecaruso now it throws this error:
-- Configuring done
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
SDLMIXER_INCLUDE_DIR (ADVANCED)
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/external/libcheevos
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
used as include directory in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
SDLMIXER_LIBRARY (ADVANCED)
linked by target "es-core" in directory /Users/pablojimenez/github/batocera-emulationstation/es-core
linked by target "emulationstation" in directory /Users/pablojimenez/github/batocera-emulationstation/es-app
CMake Warning (dev) in external/libcheevos/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "libcheevos":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in external/libcheevos/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "libcheevos":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in external/libcheevos/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "libcheevos":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in external/libcheevos/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "libcheevos":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in external/libcheevos/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "libcheevos":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in external/libcheevos/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "libcheevos":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in external/libcheevos/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "libcheevos":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in external/libcheevos/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "libcheevos":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in es-core/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "es-core":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in es-core/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of "es-core":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in es-app/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of
"emulationstation":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) in es-app/CMakeLists.txt:
Policy CMP0021 is not set: Fatal error on relative paths in
INCLUDE_DIRECTORIES target property.  Run "cmake --help-policy CMP0021" for
policy details.  Use the cmake_policy command to set the policy and
suppress this warning.
Found relative path while evaluating include directories of
"emulationstation":
"SDLMIXER_INCLUDE_DIR-NOTFOUND"

This warning is for project developers.  Use -Wno-dev to suppress it.
-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.


Board Review: Storage ADLS

The Basics

Service team responsible for the client library: Storage
Link to documentation describing the service: @seanmcc-msft to provide a link
Contact email (if service team, provide PM and Dev Lead): Sean McCullough and Peter Marino

About this client library

Name of the client library: Storage ADLS
Languages for this review: .Net first, then map to other languages
Link to the service REST APIs: Storage ADLS
Link to the reference documentation: https://microsoft-my.sharepoint.com/:w:/p/seanmcc/ESIRXEIpSDRPsksvzL2usTEB-PoeNzqopWoTMAQTWRczjA?e=8zZGc3
Link to several samples: Samples in the document

To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will be reviewed together.  Other languages may be included as required.
Champion Scenarios
A champion scenario is a use case that the consumer of the client library is commonly expected to perform.  Examples might be "Update Firmware", "Download a file", "Recognize faces in a list of pictures".  Champion scenarios are used to ensure the developer experience is exemplary for the common cases.  You need to show the entire code sample (including error handling, as an example) for the champion scenarios.

Champion Scenario 1:

Describe the champion scenario
Link to the code sample

_ Repeat for each champion scenario _
Agenda for the review
The following agenda will normally be followed:

Introduction to the service (10 minutes max)
Class Heirarchy (general) and public API surface - https://microsoft-my.sharepoint.com/:u:/p/seanmcc/EV6Ss_sxgOVGkyn0uXU8wkIBdA2Mb8pI6SHkCm1baGjeKg?e=9jdSfH

To ensure consistency, discuss any language then indicate how the other languages are constructed

Per-language exceptions and examples
Implementation of champion scenarios (top 3-4 only) with code in preferred language

Include samples as attachments for other languages - all languages under consideration must be provided

Thank you for your submission

Before the end of the week, can you provide to the arch board:

A presentation that goes over the service.  Specifically:

Who is the feature for?  (Primarily services, primarily clients, experienced azure devs, beginners, how big is the audience, etc.)
What problem is the feature solving
How does the feature solve that problem conceptually
Add the presentation to the issue so we keep track of it.

Upload a definition of the API somewhere where we can comment on it.  Ideally, apiview.azurewebsites.net (since KC likes that for .NET reviews and you’ve picked .NET as the initial review).  Add a link to the apiview review within the issue.

Provide sample code on how a customer would use the API to solve the problem that it is purported to solve within the issue.

Scheduled 9/19

Link to notes: (MICROSOFT INTERNAL): https://microsoft.sharepoint.com/teams/AzureDeveloperExperience/_layouts/OneNote.aspx?id=%2Fteams%2FAzureDeveloperExperience%2FShared Documents%2FGeneral%2FAzure SDK - General&wd=target(Board Meetings.one|19375C24-42BA-455A-A479-8E59FBB01EF3%2FStorage ADLS - 9\%2F19\%2F2019|2B0B83AD-6E35-472A-A9A4-00CCDB6085B1%2F)
onenote:https://microsoft.sharepoint.com/teams/AzureDeveloperExperience/Shared Documents/General/Azure SDK - General/Board Meetings.one#Storage ADLS - 9/19/2019&section-id={19375C24-42BA-455A-A479-8E59FBB01EF3}&page-id={2B0B83AD-6E35-472A-A9A4-00CCDB6085B1}&end


widget macro doesn't work with reexports

I've created a library crate with bunch of reexports to have one place to rule all external dependencies related to relm and gtk.
pub use gtk;
pub use gtk::glib as glib;
pub use libadwaita;
pub use relm4;
pub use relm4_macros;
pub use relm4_components;
pub use tracker;

If I use relm widget macro from my reexports I receive
    | #[relm4_macros::widget(pub)]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `relm4`
    |
    = note: this error originates in the attribute macro `relm4_macros::widget` (in Nightly builds, run with -Z macro-backtrace for more info)
    | #[widget(pub)]
    | ^^^^^^^^^^^^^^ could not find `gtk` in the list of imported crates
    |
    = note: this error originates in the attribute macro `widget` (in Nightly builds, run with -Z macro-backtrace for more info)

If I build my app with -Z macro-backtrace then it points to lib.rs:105 in relm4-macros.
Even adding use for gtk and relm4 like below doesn't help.
use my_reexports::gtk;
use my_reexports::relm4;

Is only workaround to abandon widget macro?

The error makes sense because it's recommended for proc macros to use ::relm4 or ::gtk for imports so they don't accidentally use the wrong trait in case it comes to naming conflicts, for example if you add a module named gtk (https://doc.rust-lang.org/reference/procedural-macros.html#procedural-macro-hygiene). Yet, I wonder if in the case of the widget macro this isn't necessary because naming conflicts are very unlikely...

@mskorkowski any thoughts on this issue? Do you think it's worth to change the widget macro to work with re-exports?

Sorry for late replay. I'm agains breaking hygiene of widget macro. Having things done at random in macros is asking for tickets here.  I was trying to make relm4-macros support the syntax like
#[widget(pub, ::my_reexports::smth as relm4, ::my_reexports::smth_else as gtk)]

and propose the PR but while I could parse the arguments InputStream and extend Attrs, I didn't manage to work around code generation errors yet (this is my first time playing with macros for real). I'm getting invalid token errors.
List of requirements I thought of:

No changes are needed in existing code, so #[widget()] and #[widget(pub)] must work as is
New arguments must default to ::relm4 and ::gtk
All arguments are optional
No order of arguments is implied, so pub, ...as relm4, ...as gtk, or ..as relm4, pub, ...as gtk, or any other order must work

Other option I considered was to create unhygenic_widget macro. Would still work, but for me it looks like ugly compared to first solution.

That sounds great! Btw. the gtk imports don't seem to be necessary and probably can be replaced by relm4 paths: ::gtk::glib::Sender to ::relm4::Sender because Relm4 re-exports this type. Also make sure your version is up to date, I pushed changes to the macro yesterday (that will make it a bit easier for you, I guess).
At this point, I think we should add proper argument names to the macro to make it more clear. Something like this:
#[widget(visibility = pub, relm4 = ::my_reexports::smth)]

Let me know if I can help you with parsing or code generation :)

I've rised PR which adds #[widget(visibility = pub)] syntax. Now I know what I was doing wrong so the rest should follow pretty soon.

Since PR got merged, when do you plan to do the release?

A 0.2-beta release would be an option as well, that could be used in the meantime. What do you think?

Fixed with https://github.com/AaronErhardt/relm4/pull/37


prePersist event called twice

If declare @ODM\prePersist in abstract document used as base document for all other documents then method declared as prepersist is called twice if persist inherited document. Check pls following code:
/** @ODM\MappedSuperclass /
abstract class BaseDocument
{
//...
/* @ODM\PrePersist */
public function prePersist()
{
//
}
}
/** @ODM\Document */
class SomeDocument extends BaseDocument
{
//...
}

I added a test here and it is working correctly. https://github.com/doctrine/mongodb-odm/commit/7d05c39f35636efd245a46067a72a4ce1601f732

Hi Jonathan,
Thank you for your reply. But this test does nothing about bug that I posted.
Try to run this test:
dm->persist($test);
        $this->dm->flush();

        $this->assertEquals(1, $test->prePersist);

        $test->field = 'test';

        $this->dm->flush();

        $this->assertEquals(1, $test->preUpdate);
    }
}

/** @ODM\MappedSuperclass */
class PrePersistTestDocumentBase
{
    public static $prePersist;
    public static $preUpdate;

    /** @ODM\Id */
    public $id;

    /** @ODM\String */
    public $field;

    /** @ODM\PrePersist */
    public function prePersist()
    {
        $this->prePersist++;
    }

    /** @ODM\PreUpdate */
    public function preUpdate()
    {
        $this->preUpdate++;
    }
}

/** @ODM\Document */
class PrePersistTestDocument extends PrePersistTestDocumentBase
{

}

This test fails with the following message:

1) Doctrine\ODM\MongoDB\Tests\Functional\PrePersistTest::testPrePersist
Failed asserting that 2 matches expected 1.

This is the bug what I meant.

Thank you.

PS: Sorry for my bad English.

2012/2/7 Jonathan H. Wage
:
> I added a test here and it is working correctly. https://github.com/doctrine/mongodb-odm/commit/7d05c39f35636efd245a46067a72a4ce1601f732
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/doctrine/mongodb-odm/issues/197#issuecomment-3842239

--
Best regards,
Andrew Lebedenko.


Infinite warnings while using mask

I am getting infinite warnings while using Rasters.mask
using Rasters, Shapefile, DataFrames
raster = Raster("DATA/Harmonized_DN_NTL_2020_simVIIRS.tif")
shp = Shapefile.Table("DATA/world_shapefile/in_primary_countries.shp") |> DataFrame
japan_index = findall( x -> x == "Japan", shp.name)
japan = crop(raster; to = shp.geometry[japan_index])
japan_masked = mask(japan, with = shp.geometry[japan_index])

┌ Warning: (Band,) dims were not found in object
└ @ DimensionalData.Dimensions ~/.julia/packages/DimensionalData/yMNeq/src/Dimensions/primitives.jl:648
┌ Warning: (Band,) dims were not found in object
└ @ DimensionalData.Dimensions ~/.julia/packages/DimensionalData/yMNeq/src/Dimensions/primitives.jl:648
┌ Warning: (Band,) dims were not found in object
└ @ DimensionalData.Dimensions ~/.julia/packages/DimensionalData/yMNeq/src/Dimensions/primitives.jl:648
┌ Warning: (Band,) dims were not found in object
└ @ DimensionalData.Dimensions ~/.julia/packages/DimensionalData/yMNeq/src/Dimensions/primitives.jl:648

I am also getting these while using Rasters.zonal
zonal(sum, raster; of=shp.geometry)

The performance also seems bad and variable. On some occasions, it takes 30 seconds and on some, it takes up to an hour. I am unable to replicate that, perhaps it's related to my memory usage.
For replication, the tif file can be obtained here. And the Shapefile can be obtained here.
I've also tried the same with a different tif file.
PS:
I am making a tutorial on using Rasters, and this is something I found while making the Jupyter notebook for it.
https://github.com/xKDR/datascience-tutorials/blob/main/rasters.ipynb

I think this is already fixed on master, and the 0.4.5 patch version should be registered in the next half hour.
Good work on the notebook! will this be in a blog post or something similar?

Is it fixed! The speed is spectacular.
I've been teaching raster analysis at a few places, so I thought I'll make a notebook + video and circulate it.


How to Delete Bluicache using blueprint

i need to delete bluicache from blueprint  cause i did a javascript change and it didn't upadte the page .

There's no built in utility that deletes the cache that I'm aware of. Code contributions welcome


How can this work with a Vec

As far as I can tell there's no way to make this work:
use thiserror::Error;
use async_graphql::ServerError;

#[derive(Error, Debug)]
pub enum DataError {
  #[error("{0:?}")]
  GraphQLError(#[from] Vec<ServerError>)
}

That's right, this crate is specifically for single errors. For working with multiple simultaneous errors, you would want to find another approach. I don't have crate recommendations.


Spectrum Painter block missing

Hello,
I have installed spectrum_painter and its dependencies in ubuntu 18.04. But when I run Paint_tx.grc in gnu radio companion, it is still missing couple of blocks as shown in attached image.
Can you help me out?

I must have missed this in my notifications, but better late than never.
Unfortunately, I cannot help you with this. The spectrum painter for GNURadio is a separate project from this. I think you need to install the following project instead: https://github.com/drmpeg/gr-paint

Closing this to do some cleanup.


Cannot manipulate gradients during training in estimator

Description
In current estimator framework, api fit_batch() forward the training batch through the network, compute the loss and gradients and update network parameters with gradients. The default
fit_batch() function is shown as below:
def fit_batch(self, train_batch, batch_axis=0):
        data, label = self._get_data_and_label(train_batch, self.context, batch_axis)
        batch_size = train_batch[0].shape[batch_axis]

        with autograd.record():
            pred = [self.net(x) for x in data]
            loss = [self.loss(y_hat, y) for y_hat, y in zip(pred, label)]

        for l in loss:
            l.backward()

        self.trainer.step(batch_size)

        return data, label, pred, loss`

The problem is in some use cases like gradient accumulation, users may not update gradient at each batch. They apply gradients on network parameters periodically. There is no way to implement the gradient accumulation feature in customized estimators.
One possible option is to create a handler to update/apply gradients at the end of each batch, but it violates the definition of handlers since handlers are not supposed to apply gradients on network parameters.  Gradient updates should be processed in the fit_batch() api.
So a viable way to resolve the problem is to decompose the fit_batch() function into two methods:

computations of loss/gradient
applying gradients on network parameters

between these two methods we could add some customized api to process gradients, e.g., gradient clipping or gradient accumulation.

Thanks @liuzh91 for raising the issue. I agree the current fit_batch is not sufficient to suppose the use-case.
What do you mean with "handlers are not supposed to apply gradients on network parameters"?
If we allow handlers to apply gradient to network parameter, an alternative solution to your problem could be to remove the trainer.step from the current def fit_batch implementation and introduce a GradientUpdateHandler? Similar to how LoggingHandler and MetricHandler are constructed by default in estimator.fit, if not provided by the user, the GradientUpdateHandler would be default implement the estimator.step behavior.
Users would be free to provide their own subclass of GradientUpdateHandler that could extend the handler to do gradient clipping or gradient accumulation.

Thanks @liuzh91 for raising the issue. I agree the current fit_batch is buggy as it cannot support this standard use-case.
What do you mean with "handlers are not supposed to apply gradients on network parameters"?
If we allow handlers to apply gradient to network parameter, an alternative solution to your problem could be to remove the trainer.step from the current def fit_batch implementation and introduce a GradientUpdateHandler? Similar to how LoggingHandler and MetricHandler are constructed by default in estimator.fit, if not provided by the user, the GradientUpdateHandler would be default implement the estimator.step behavior.
Users would be free to provide their own subclass of GradientUpdateHandler that could extend the handler to do gradient clipping or gradient accumulation.
Hi @leezu , if we can introduce a gradient update handler for estimator class, then the problem is solved. "handlers are not supposed to apply gradients on network parameters" for this part, I mean the common workflow in current estimator framework is to update/apply gradients in the fit_batch routine instead of using a standalone handler. Handlers are used to process other information, e.g., metrics, logging information, etc.

@roywei: @liuzh91 just noticed you self-assigned this issue 4 days ago. In the meantime he prepared https://github.com/apache/incubator-mxnet/pull/16900 Do you think that change is in order? Or would you suggest any other change. Sorry for the inconvenience in case you also started working on it already..


Implement upsert clause

Works towards https://github.com/cashapp/sqldelight/issues/1436
Still to do: table alias syntax of INSERT, maybe some other things?.. Do I need to implement tablesAvailable on UpsertClauseMixin too? It seems to work fine with me just implementing queryAvailable but I don't totally understand the difference between them

I believe this pull request is now complete, but having just seen https://github.com/cashapp/sqldelight/issues/1436#issuecomment-558231458 I realise I ought to have run it past you before doing the work. Is upsert support something you'd consider merging at this point, or do you want SQLDelight to have a SQLite versioning mechanism first? @AlecStrong

yes - but feel free to leave this open. I've got to think through how the actual dependencies will look but the nice thing about upsert is its a straightforward additive change, so its a good test bed for the versioning stuff
regardless this looks good, thank you for putting the time in on it. It'll definitely go in, just need to get the versioning/dialect support in first which might take some time

@AlecStrong For future reference, what is tablesAvailable? Given that an upsert introduces a table into scope, I assumed I needed to implement it, but my tests ended up passing without

I put some work on a blog series for sqldelight internals a while back i never published. I should get around to that.
it details whats sqlite-psi actually does and what that specific api is for, heres a draft of it https://medium.com/@anstrong22/sqldelight-behind-the-scenes-sqlite-psi-f00df7cef3e4


Add Morpho Optimizers Adapters

Adding the following adapters:

Morpho AaveV2 Optimizer
Morpho AaveV3-ETH Optimizer
Morpho CompoundV2 Optimizer

Hey @tomrpl , thanks for submitting the PR and sorry for the delay, but I can't get the branch to run.
There's a comma missing in the package.json, which is an easy fix, but even after that I'm getting building errors with npm run build.
Can you please fix them? Also I'd be great if you could make the PR editable by repo authors, as we might want to do some refactors.

Hey @tomrpl , thanks for submitting the PR and sorry for the delay, but I can't get the branch to run.
There's a comma missing in the package.json, which is an easy fix, but even after that I'm getting building errors with npm run build.
Can you please fix them? Also I'd be great if you could make the PR editable by repo authors, as we might want to do some refactors.

Thanks for making the changes. We're in the process of reviewing them before merge. It shouldn't take long.

@tomrpl Apologies for the delay merging, but we have to work on a solution for an issue that has arisen with your adapters.
We have a positions resolver that creates a unique mapping between a protocol token and an adapter, this is done so that protocol tokens can be resolved recursively in case they are layered e.g. wstEth -> stEth -> Eth.
Since your adapters use the same protocol tokens as aave and compound, that's causing an error.
We are discussing how we are going to solve it, but chances are we'll include some sort of property in the adapter that skips adding tokens to the resolver.

We had to do a big rebase so merged in a separate PR


Typescript definitions, optionals

If using typescript, the demo example code won't work right. All of the properties on interface GridProps are required. I am thinking only a couple should be required and all else should be marked as optional.

Hi, I'm checking the reason for this error and I should make a version available with the fix.

Available in version 1.2.4
Thanks for raising this point.


OBS installation of ungoogled-chromium doesn't load pages

I've installed on my Ubuntu machine ungoogled-chromium using the OBS repos, all is fine, but when trying to open a page, any page, nothing load. Just sits there all fancy and judgemental.
Normal google chrome or firefox work perfectly fine.

Duplicate of #1698


bug: Usage line truncated, other rendering issues

Note how the usage line is truncated:
% pdm run insiders -h
Usage: insiders [-h] [-V VERSION] [--debug-info DEBUG_INFO] [--completion COMPLE

  Manage your Insiders projects.

  This tool lets you manage your local and remote Git repositories for projects that offer an Insiders version.

  Options
    [-h, --help]               Print the program help and exit.
    [-V, --version VERSION]    Print the program version and exit.
    [--debug-info DEBUG_INFO]  Print debug information.
    [--completion COMPLETION]  Print shell-specific completion source. Valid options: complete, generate.

  Subcommands
    create                     Create public/insiders repositories.
    pypi                       Manage PyPI-related things.

Subcommand help is truncated at the same length:

Also, my create subcommand has a link at the and it extends on all the contents after it:

The docstring:
class CommandCreate(HelpOption):
    """Create public/insiders repositories.

    This command will do several things:

    - Create public and insiders repositories on GitHub
        (using the provided namespace, username, repository name, description, etc.).
    - Clone these two repositories locally (using the provided repository paths).
    - Initialize the public repository with a `README` and a dummy CI job that always passes.
    - Optionally initialize the insiders repository by generating initial contents
        using the [Copier PDM template](https://github.com/pawamoy/copier-pdm).
    """

It's probably caused by the code I suggested to pre-render displayables before inserting them in the format string :bow:

mmm. it's probably because of terminal escape codes increasing the overall length of the line, which would be exacerbated on the first line because there's a lot of start/stop of color codes.
I had thought i addressed this by turning off overflow the final print, while retaining it on the one being printed to a buffer.

Somewhat challening mostly because the tests by default run in the non-terminal mode that wont line wrap at all

lmk if you notice any more of these kinds of bugs! I've found rich strangely difficult to work with when performing writes to a Console then re-printing to a real console. perhaps it just goes with the territory.

Great work, it's fixed :rocket:


Add POST:/submissions and POST:/presubvalidation

@KerstenBreuer Haven't run this yet and your validation as well as the uniqueness validation is still missing, but it would be great of you could give feedback if you think this is okay conceptually.

@KerstenBreuer If you find the time it would be great if you could have another look at this, it's feature complete from my side.
As for the error schema, I've extended it to have an entity member intended to be used for entity (resource) IDs. Thus, when there are multiple resources the response could refer to, we can use that to specify the resource as in
{
"entity":"DMR-12345",
"field":"ZIP Code",
"message":"Invalid zip code"
}

Should this maybe be renamed to resource to remain in REST speak? 🤔

@KerstenBreuer If you find the time it would be great if you could have another look at this, it's feature complete from my side.
As for the error schema, I've extended it to have an entity member intended to be used for entity (resource) IDs. Thus, when there are multiple resources the response could refer to, we can use that to specify the resource as in
{
"entity":"DMR-12345",
"field":"ZIP Code",
"message":"Invalid zip code"
}

Should this maybe be renamed to resource to remain in REST speak? 🤔

Great. I think both is fine and should be clear what it is referring to.


Hosting Eel on the web.

Hey there,
I was wondering if there is any way to host an eel app on the web. Any ideas?

At the end of the day, yes, an Eel app could be made available on the web just like any other webserver. That said, this library has been primarily designed for smaller local apps and prototypes, so running it open on the web isn't really the primary purpose. To officially support that I'd want to spend more time investigating the implementation for security concerns, which at the moment isn't a really on the todo list. I'm a little loathe to provide documentation around how to deploy Eel on the web in case people take that as implicit official support, but Eel runs bottle internally and there should be plenty of documentation around for how to deploy that (e.g. to Heroku or similar).

Hi @samuelhwilliams
Can you please elaborate "primarily designed for smaller local apps". Does it mean it will break if people use Eel on a bigger scale? or is it because it will be slower or probably use a lot of memory which on small local apps would not be noticeable but can be seen in larger local apps? Kinda noob in this area.
Thanks

I was more emphasising the "local" aspect than the "smaller" aspect to be honest - as in Eel is designed mostly for offline local apps rather than being served over the web to multiple users. I'm not sure much thought has been applied to what happens when multiple users are using the app at the same time, and there could be race conditions.
For running simpler local Python scripts using HTML/CSS/JS for the layout/visuals, Eel is a fine choice that allows developers to build something useful fast. For creating complex multi-user browser-based sites and services, probably something else is a better fit. If you don't want the user to use the browser at all (i.e. native desktop apps) then you're looking at things like TkInter, wxPython, PyQT and similar things.

@samuelhwilliams
I see. Thanks!

Ahh gottit. Also, Eel is pretty darn good. I've just completed my first GUI App. Its at https://github.com/JeswinSunsi/PentyDesktopAssistant . Thankss.


modernized device support table

Docs Build status updates of commit af5d326:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/point-and-commit.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added & Fixed

Number (Fixed)

Tag (Fixed)

emit (Fixed)

Can you elaborate what changes you've made? What have you fixed that was broken?

Number (Fixed)

Tag (Fixed)

emit (Fixed)


1.6.2 tag missing on GitHub

The newest tag is v1.6.1. Could you please push the tag corresponding to 1.6.2 release?

Done. Thanks for the reminder!


Response Description Styling looks off

I am on version v5.1.0, and have followed the setup instruction, but am noticing that the Description column in Responses section seems to not be styled correctly.  Am I missing some stylesheet somewhere?

I see the same so I guess that's just the styling. If you have issues or suggestions around the look and feel of the UI, then you should post those to the swagger-ui repo instead of this one.


Prevent postMessage Exceptions

50% fix for issue #78. I hadn't accounted for that use-case when working on PR #61. This cleans that up.
Issue I'm fixing can be tested before/after at this uri: https://www.olark.com/

Any idea when this update will end up in the Chrome webstore?

With 0.5.8 tomorrow

Awesome, thanks :)

@spalger v0.5.8 has been sent to the webstore, will be available for update shortly

Thanks @rev087 :beers:

For posterity: http://stackoverflow.com/questions/29459541/uncaught-syntaxerror-unexpected-token-m


Use IntegratingCallback to integrate flows and basin forcings

Fixes https://github.com/Deltares/Ribasim/issues/1473.
To do:

[ ] Update TrapezoidIntegrandAffect.integrand_value in update_basin! for integrands that contain the basin forcings (both for flow integration and bmi integration)
[ ] TrapezoidIntegrandAffect.integrand_value_prev can be removed, if the integration is done in this order:

function (affect!::TrapezoidIntegrationAffect)(integrator)::Nothing
    (; integrand_func!, integrand_value, cache, integral) = affect!
    (; dt) = integrator

    cache .= integrand_value
    integrand_func!(integrand_value, integrator.p)
    cache .+= integrand_value
    cache .*= 0.5 * dt

    integral .+= cache
    return nothing
end

[ ] Test the integration around a discontinuity of the basin forcings
[ ] Add docstrings, inline comments

A drawback of the current way flows and basin forcings are computed is that a vector for all these values is allocated at each timestep, while they are later averaged over the saveat intervals. It would be nice if the IntegratingCallback would support passing the saveats to predefine the integration intervals, maybe that's worth making an upstream issue.

I just realized I made a wrong assumption about how IntegratingCallback and IntegratingSumCallback work. I thought that the integrand function was only evaluated at time points of the integrator, but it is in fact called at several different points:
https://github.com/SciML/DiffEqCallbacks.jl/blob/a35955b8480356503e3df492a9e02249cef00cd0/src/integrating.jl#L175C5-L177C55
The problem with this is that we don't know the value of the integrand at these in between points. The t_temp in the code linked above are between the tprev and t, so as a (silly) workaround we could cache the value of the integrand at tprev and do a linear interpolation.
There's probably also a bug in these functions, where it checks whether the ODEproblem is in-place instead of the integrand function.

Although this was a fun dive into creating a custom callback, it didn't reach its goal, namely reducing the complexity of the integration code.


Page  "Purchase requisition consolidation" not found in D365

Page  "Purchase requisition consolidation" not found in D365

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 64e0b952-06c2-1c2c-aa04-dd972d200a2b
Version Independent ID: a98addf4-b0e2-f503-b40b-4ae182114c78
Content: Purchase requisition overview - Supply Chain Management | Dynamics 365
Content Source: articles/supply-chain/procurement/purchase-requisitions-overview.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @RichardLuan
Microsoft Alias: riluan

It's "Consolidation opportunities" at Procurement and Sourcing > Purchase requisitions > Approved purchase requisition processing in D365

Thank you for the input on our documentation. We really appreciate it.

Created bug 582857 to track this issue.


Invalid Add-on repository!

When I try to add https://github.com/petretiandrea/home-assistant-tapo-p100/ as a repository through HACS it always tells me: Invalid Add-on repository!
I've installed the add-on manually for now, but would like to keep it easily updated.
Best tapo addon out there!

I added a video to show the installation steps in the README.md. Try it and report any issue :)

Worked, thanks so much! Closing


Support Kafka Client <IP_ADDRESS>

Release candidates are available here already:
https://repository.apache.org/content/groups/staging/org/apache/kafka/

https://github.com/cakesolutions/scala-kafka-client/pull/30


Visual Rules list supports iconography for showing just badges, just mesh colorings, and both

Summary of changes 🔍

Icon that appears at the beginning of visual rule should represent what type of conditions are created under the rule. Is it mesh colorings or badges alone or are there both.

Testing 🧪

Turn this the visual rule flag on: localStorage.setItem('cardboard.feature.visualRulesFeature',true);
Then go to Behaviors> Visual Rule> you should see a ringer appear for the rule that has only alerts in it, and a cube for the rule that only has mesh coloring conditions in it.
Viewing the icon for when both badge and mesh coloring conditions both exist in a rule will currently require you to go to one of the mock data .json files and add a value range that represents a badge. The conditions flyout is not yet built.

https://msazure.visualstudio.com/One/_workitems/edit/15913880/
Checklist ✔

[ ] Linked associated issue (if present)
[ ] Added relevant labels
[ ] Requested developer reviews
[ ] Request UI review from design / PM
[ ] Verify all code checks are passing

Can we add some stories for the list that include mock data for only badge, only color and then one with both? They can be a single test but we should have list items that have each of those scenarios.


Flow-typed objects destroy autocomplete capability in all editors

In my case I am using objects as enums.
Untyped universe

This particular enum constraints the valid set of screens to which I could route to in my app. It allows me to use it elsewhere in my app like this:

FlowTyped universe
Leveraging FlowType is powerful. Now when I try to reference a invalid key in my enum, I immediately get a flow warning. I mean here it seems pointless, but in my app structure flow types are defined in a standalone file.

That blessing, however, comes at a very high cost: I lose the autocomplete results no matter what editor I use (tested on atom and vscode). NO MORE AUTOCOMPLETE

Why is it that flow-typed objects lose the autocomplete capability? I was not sure where was the right place to post this. Since it did not work for neither atom nor vscode, I thought I start here to ask for guidance.

PhpStorm:

Works as expected.
So it seems that the issue isn't related to flow itself and you should address it to the developers of editors.

Thanks for investigating. I posted this over here https://github.com/flowtype/flow-for-vscode/issues/188


Swap flags packages in order to better support config file usage

Most of the other projects I maintain which support configuration files use the pelletier/go-toml package. For those projects I tend to also use alexflint/go-arg and setup a shared config structure to hold values for both. I also setup a series of "getter" methods to retrieve needed values and enforce a precedence level.
Because the Nagios plugin works fine using flags, the existing options should be retained. For new binaries in this project, support for using a mix of flags/config file settings would be available.
This work will be incorporated before I finish GH-2.

Still on the fence about this one. I've found some other ways to do what I need for GH-2, so putting this on the backburner for now.


[SPARK-47659][CORE][TESTS] Improve *LoggingSuite*

What changes were proposed in this pull request?
The pr aims to improve UT related to structured logs, including: LoggingSuiteBase, StructuredLoggingSuite and PatternLoggingSuite.
Why are the changes needed?
Enhance readability and make it more elegant.
Does this PR introduce any user-facing change?
No.
How was this patch tested?

Manually test.
Pass GA.

Was this patch authored or co-authored using generative AI tooling?
No.

cc @gengliangwang @cloud-fan @HyukjinKwon @dongjoon-hyun

Thanks, merging to master


Add docs for directives

fix https://github.com/microsoft/typespec/issues/4864
fix https://github.com/microsoft/typespec/issues/3269

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


No Hook logging to CloudWatch logs

This issue is connected with https://stackoverflow.com/questions/72526742/cloudformation-hooks-do-not-push-logs-to-cloudwatch-logs

That's interesting. The logs showed up in CloudWatch for me when I last tested the hook. I did not provide any custom configuration for cloudwatch, just went with whatever was generated by the init command.

The issue with me was that I forgot to specify log level:
LOG.setLevel(logging.INFO)

Ah! Thanks for following up 👍


fix Issue 15212 - BigInt should implement opCast!long and opCast!int

https://issues.dlang.org/show_bug.cgi?id=15212

:white_check_mark:

I don't see anybody objecting to this, so I'm going to press the button.

Auto-merge toggled on


LONI

i2g has a directory called 'library', which has subfolders, 'modules' and 'workflows'.
i'm not sure why it is called 'library' instead of 'LONI',
but regardless, i'd like a folder in m2g called either 'library' or 'LONI' which contains all the LONI stuff.
@willgray can perhaps opine on why we'd call it library vs. LONI.
note that i haven't just done it myself because i was unsure if moving such stuff would break something.

Yah.  LONI has a library containing modules and workflows, both a
"personal" library for things that are locally stored and a "server"
library for things on a distributed server.  Dean and I settled on the
library -> modules, workflows organization awhile back, which seems to work
well.  We are consistent across i2g and ocpMatlab (which has basic data
access modules, not algorithms)
Does that make sense?
I2G currently has the following folder structure:
data:  very small files are committed; else a place for the result of data
downloads via wget
documentation:  how to use I2G.  This is where the examples will go as we
build
external:  tools that others have built that we use, like gala or vlfeat or
ilastik
library:  LONI modules and workflows
packages:  subfolders containing each algorithm
test:  unit/system tests for QA/QC
(old is deprecated and will disappear as the new workflows are built.)
Best,
Will
On Wed, Mar 11, 2015 at 9:11 AM, joshua vogelstein<EMAIL_ADDRESS>
wrote:

i2g has a directory called 'library', which has subfolders, 'modules' and
'workflows'.
i'm not sure why it is called 'library' instead of 'LONI',
but regardless, i'd like a folder in m2g called either 'library' or 'LONI'
which contains all the LONI stuff.
@willgray https://github.com/willgray can perhaps opine on why we'd
call it library vs. LONI.
note that i haven't just done it myself because i was unsure if moving
such stuff would break something.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/57.

ok, great, @gkiar please make it so.
@willgray - all the stuff currently in 'src' in 'm2g', where does that belong in your organization? packages?

That's right, packages.  As a suggestion, I find it easier to have the code
for each module in a subdirectory, although that may be more trouble than
it's worth for m2g right now.
Best,
Will
On Wed, Mar 11, 2015 at 9:54 AM, joshua vogelstein<EMAIL_ADDRESS>
wrote:

ok, great, @gkiar https://github.com/gkiar please make it so.
@willgray https://github.com/willgray - all the stuff currently in
'src' in 'm2g', where does that belong in your organization? packages?
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/57#issuecomment-78266533.

Great, thanks for clarification, guys. @willgray there is only one script
per module and they're all named very similarly to the modules - so I don't
think that is necessary now either.
On Mar 11, 2015 10:01 AM, "William Gray"<EMAIL_ADDRESS>wrote:

That's right, packages. As a suggestion, I find it easier to have the code
for each module in a subdirectory, although that may be more trouble than
it's worth for m2g right now.
Best,
Will
On Wed, Mar 11, 2015 at 9:54 AM, joshua vogelstein <
<EMAIL_ADDRESS>
wrote:

ok, great, @gkiar https://github.com/gkiar please make it so.
@willgray https://github.com/willgray - all the stuff currently in
'src' in 'm2g', where does that belong in your organization? packages?
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/57#issuecomment-78266533.

—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/57#issuecomment-78267763.


add revive for go

Hi,
Can we have an addition to the go linters for revive? https://github.com/mgechev/revive
I copied the golangci-lint definition and added this locally and it seems to work
function! neomake#makers#ft#go#revive() abort
    return {
        \ 'exe': 'revive',
        \ 'args': ['%t'],
        \ 'cwd': '%:h',
        \ 'errorformat':
            \ '%f:%l:%c: %m,' .
            \ '%f:%l: %m'
        \ }
endfunction

Thanks

Sure, please create a PR.
From the description it looks like it could be preferred automatically (based on executable('revive') then also over golint?
https://github.com/neomake/neomake/blob/ba38b8786ce68c36fc3cd2139a7820b25bea378a/autoload/neomake/makers/ft/go.vim#L10

Also example output, and a test would be nice to have then here or with the PR.

how would I make it have a -config and -exclude options that you can set?

Does it support config files that it picks up automatically?
That's usually the best.

it would appear that revive only looks in your home directory for a config, so I could do something similar to what pylama does
let config_file = neomake#utils#FindGlobFile('revive.toml')

I'm not sure about exclude, but I did just realise it doesn't make sense to have it specified anyway because we're running revive against specific files.

Hmm.. not sure what problem you are trying to solve.
See https://github.com/neomake/neomake/issues/1859 for appending args to existing makers.

Does that allow for adding arguments before the last argument?
Because the -config argument has to come before the path you're linting.

The path gets appended automatically in the end (via append_file=1 setting).
Check also https://github.com/neomake/neomake/pull/2161.

ah, awesome :)


Add documentation building to Travis

This should hopefully add a process for building the documentation and running the doctests with Travis (following https://juliadocs.github.io/Documenter.jl/stable/man/hosting/), we will see.

Great! Looks like it works except that Documenter.jl needs to be added to the testing dependencies in Project.toml


Download website not available via HTTPS

It really is a problem to download a security plugin via non-secure connection. Please get an HTTPS certificate for your downloads.floragunn.com server.

The "official" way to download and install the plugin is via maven. This is HTTPS as well as pgp  signed. The site you refer to is the download page for the Search Guard Bundle which is not supposed to be deployed to production.
So pls. look here     http://search.maven.org/#search|gav|1|g%3A"com.floragunn" AND a%3A"search-guard-2" and http://search.maven.org/#search|gav|1|g%3A"com.floragunn" AND a%3A"search-guard-ssl" . The pgp key you can validate against is here https://github.com/floragunncom/search-guard/blob/master/KEYS and we strongly recommend you do this instead of relying only on a SSL secured connection.
Despite of this we will provide SSL secured downloads and pgp signature for the bundle soon.

Changed download location to https://floragunn.com/downloads/ and added SHA-256 hash.


Support for enum controls

Describe the bug
I don't seem to be able to make enum/dropdown controls. I've tried setting the control to a table, but this doesn't work.
Expected behavior
I'd like to be able to set up a dropdown list of options for a prop.
Steps to reproduce
Using typescript:
const controls = {
	state: [State.A, State.B, State.C],
};
export = {
	summary: "A generic button component that can be used anywhere",
	roact: Roact,
	controls: controls,
	story: (props: { controls: typeof controls }) => {
		return (
			<Whatever
				matchmakingState={props.controls.state}
			/>
		);
	},
};

This syntax can't really work, but from looking at the code it seems as though something like this is supported, but nothing is documented for this.

Enums should work for this. What does the generated lua code look like?


APP-169 Android Sample "Cell monitor"

http://jira.kaaproject.org/browse/APP-169
Blocked by http://jira.kaaproject.org/browse/APP-148 - not integrated in sandbox.
Code is working, I am working on integration process.
Please, review code.

Please, rebase on develop.

Rebased

Don't commit build directories or any auto-generated content.

Deleted

Fixed

Fixed

LGTM

how was this tested?
Sandbox already supports gradle plugins/build?

Yes, I already do it

please, resolve merge conflicts locally and update the PR


[Production] MFR rendering pdb file error

Steps

Go to the MFR project
Attempt to render a pdb file.

Expected
A pdb file will render.
Actual
The user sees a black screen that disappears into a blank white one.
This problem occurs in Firefox and Safari as well as IE

Is it expected that pdb files should render? And do they, in fact, render in any browser currently? -- Thanks

They are expected to render. Also, any files that aren't meant to render should have an "unsupported file type" style message.

'K

This is a CORS issue for FF/IE/Safari, and seemingly only when using OSF Storage. It's also present for .pdf's under the same circumstances

Can it be overcome?

Yes, though there are currently more important issues that would take less effort to fix. There was a similar albeit broader problem before, and these were the deferred cases from that fix.

Also, regarding your earlier question about browsers: this isn't an issue in Chrome because it's a bit more liberal with allowing redirects

OK -- I prioritized low -- and thank you.

This should now be fixed on develop/staging. @jeg3tw Can you verify?

This works in firefox on staging and production.

Opens in Safari -- Looks cool! -- Tested and working in IE as well @sloria

Thanks for checking @samanehsan and @lbanner


Change SON2x2 Footprint to have N and P variants

The current SON2x2 Footprint is for the PFET, but there are NFETs available in this footprint which have the drain/source reversed. This PR splits the footprint into N and P variants.

Ugh, this ties in to needing a better way of managing different pinouts for the same package but for now could you amend to leave the original SON2x2 in place for backcompat, then add the new SON2x2P and SON2x2N for the new stuff?


Introduce Tencent as a known JVM vendor

Context
Tencent is a notable contributor to OpenJDK, and has been publishing its own OpenJDK distribution, exactly Kona JDK, for years.

https://github.com/Tencent/TencentKona-8
https://github.com/Tencent/TencentKona-11
https://github.com/Tencent/TencentKona-17

And SDKMAN already supports Tencent Kona JDK

https://sdkman.io/jdks#kona

This PR just adds Tencent as a known JVM vendor so that we can easily apply Kona JDK with Gradle toolchain feature.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@jvandort
Could you please review this PR?
If you have any concern, please let me know.

Please rebase this into master and we can get this merged

@jvandort
I just updated the commit.
Could you please review it?

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Have you tested this? Can you confirm that the java.vendor property on these VMs are equal to tencent?
Since we do not test provisioning and using these toolchains from all vendors, I will take your word on this one

It looks like your PR is failing sanityCheck.
Please run ./gradlew sanityCheck locally and address the issues reported by the binary compatibility check

Have you tested this?

When this PR was submitted, I did run the tests, like sanityCheck.
But, I just tried to execute that task and always encountered the below problem,
Error resolving plugin [id: 'org.gradle.toolchains.foojay-resolver-convention', version: '0.7.0']
> A problem occurred configuring project ':build-logic-commons:basics'.
   > Dependency verification failed for configuration ':build-logic-commons:basics:classpath'
     One artifact failed verification: kotlin-stdlib-1.9.20.jar (org.jetbrains.kotlin:kotlin-stdlib:1.9.20) from repository Gradle Central Plugin Repository

The failed task log contains the below lines,
[16:30:00]W:		 [Gradle failure report] Caused by: org.gradle.api.GradleException: Detected binary changes.
[16:30:00]W:		 [Gradle failure report]     - current: gradle-kotlin-dsl-shared-runtime-8.6.jar, gradle-api-metadata-8.6.jar,  ...
[16:30:00]W:		 [Gradle failure report]     - baseline: gradle-antlr-8.5.jar, gradle-api-metadata-8.5.jar, ...

The current jars are different from the baseline jars. But I don't understand it.
Does it have something to do with my changes?

Can you confirm that the java.vendor property on these VMs are equal to tencent?

The value of that property is Tencent.
I supposed it is case insensitive.
KnownJvmVendor(String indicatorString, String displayName) {
    this.indicatorString = indicatorString;
    this.indicatorPattern = Pattern.compile(indicatorString, Pattern.CASE_INSENSITIVE);
    this.displayName = displayName;
}

Can you confirm that the java.vendor property on these VMs are equal to tencent?

The value of that property is exactly Tencent. I supposed it is case insensitive.
KnownJvmVendor(String indicatorString, String displayName) {
    this.indicatorString = indicatorString;
    this.indicatorPattern = Pattern.compile(indicatorString, Pattern.CASE_INSENSITIVE);
    this.displayName = displayName;
}

The current value seems fine then

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

@jvandort
Thanks for approving and merging this PR very much!
In addition, I just moved to another network environment, and resolved all the dependencies and build Gradle successfully.
My project now can use Kona JDK builds via Gradle toolchain with my Gradle build.

Glad you got thr build working. These changes should be present in our nightly soon


Multiple publishes using msdeploy.exe causes directory repetition until file name is to long and crashes VS.

I'm using Visual Studio Enterprise 2015, version 14.0.25431.01 Update 3 and a .net core project. The SDK does not change the result.
Steps to reproduce:

Create new .net core project.
Create custom publish target.
Default target location.
Default settings.
Publish.
Observe the added directories after the msdeploy execution: '\bin\Release\PublishOutput'.
Publish again.
Observe that the msdeploy execution has now created another set of directories inside the first: '\bin\Release\PublishOutput\bin\Release\PublishOutput'
Repeat publish until file name becomes to long and crashes VS.

I also have found that even if I manually delete all of the published output as well as the publish profiles, the next publish still results in the same behavior.

This issue was moved to aspnet/Tooling#927


DT-27: add subnet and firewall changes for CPM

I'll fold https://github.com/communitiesuk/delta-common-infrastructure/pull/53 into this


Blending mode not affecting to Stroke

Context
Please explain here below what you were doing when the issue happened
Steps to Reproduce
Please break down here below all the needed steps to reproduce the issue

Go to layer style
Add a fill color
Add a 4px or more stroke (to properly see it)
Change Blending mode to overlay
See how it's not affecting to the stroke

Current Result
https://www.dropbox.com/s/0swe9lk7ohw5qm2/Kapture 2017-05-25 at 15.03.28.gif?dl=0
(too big for GH 😞 )
Expected result
Comp-op affecting to line + fill
Additional info
SMOKE_MG17

That's a "problem" in the Maps API (windshaft repository), not here.

Issue moved to CartoDB/Windshaft-cartodb #692 via ZenHub


Update meta.yaml

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-linter, please rerender

@conda-forge-admin, please rerender


Implementing feedback

What This PR Does
This PR adds Flask-API functionalities for the Shopping list-API application.
The functionalities affected include.

Add functionality for changing password
Adds functionality for resetting password
Adds prices and quantities data for shopping list items
Adding timestamps for creation and modification of shopping lists
updates flassger documentation

Review
Please review the code structure and complexity and make suggestions
on any improvements that can be made and should be made.
Testing
All test are included in the tests_api.py file in the  tests\ folder on the project root directory.
You can run test locally by  navigating to the project root directory and then run the following command  nosetests tests
Project structure
A visual description of the project structure (UML Diagram) can be found in the Designs folder

Running the application
You can run the application like this python app.py. More documentation can be found here

Coverage increased (+1.4%) to 92.428% when pulling 1e26cbb9b2f0cc64bb8ee5a467045b2bfa4e8051 on develop into d1ba42b9125a11cc36d28127c61d7feddfa1d40b on master.


Make operationId more unique by adding controller

Fix for https://github.com/iheartradio/play-swagger/issues/237

In this case, I think we should make operationId more flexible in general. I assume we can already override it directly in the routes file? That's the easiest fix.

I just tried this in a project and it failed. Perhaps I missed something when testing this, but adding operationId: ListUsers in my routes did nothing.
Admittedly, I am not a java/scala developer but this block seems to suggest that the value is always set to the call method (which is just the http verb) https://github.com/iheartradio/play-swagger/blob/031cc7b3b6608c6788d9e44b0e54f1d217cf58d5/core/src/main/scala/com/iheart/playSwagger/SwaggerSpecGenerator.scala#L414-L419
Even just supporting configuration of the operationId from the routes file would unblock me.

@LucasRoesler Thanks for looking into that. We should make that configurable from the routes file first.

@LucasRoesler operationId is a key name, an identifier for the swagger endpoint, so it can't get overriden by your root swagger file. I'd say the only way forward is to have a custom operation id policy class like @joprice suggested here


add node 12 to build; remove node 11

node 11 is no longer maintained

Coverage remained the same at 92.353% when pulling 1ee49df8f3b185eb47369862f2e1bdd7dea3f881 on boneskull/node-12-build into f3ed729b6908f3893e6f87722c6e996cca5f7733 on master.

to be clear about the why's of that hack around browser tests:

the browser tests are the only place where we allow native modules to be downloaded and/or compiled.  we need these to launch the browser tests.
unfortunately, this also means we get canvas, which is a transient dependency of builder.
canvas provides a prebuilt binary for node 10
canvas does not provide a prebuilt binary for node 12, which means we must compile it from source
...and the prerequisites to do so are not available in the default travis environment

So we could either download all of those dependencies (which is a handful of stuff grabbed via apt) and build canvas from source which we won't even use, because it's for building the docs.... or we just run the browser tests in Node.js v10.  the Node.js version doesn't really matter, because these are browser tests, after all.

I would not consider this a breaking change as long as we support versions of Node.js prior to v11. We can consider this "implicit support".
in the far future, when we drop Node.js v10 support, we will be essentially dropping Node.js v11 support as well.

closing in lieu of #3919


Set length value to zero in case of failed convertion

If passed value in strconv.Atoi causes integer overflow, function returns max possible int value along with error. In this case, in this library, while error is only saved, the resulting value is ignored and further passed into cycle. So my suggestion is to set this value to zero.

@dsp25no FYI, I have no write access to this repo, and can't merge myself


[fix] allow enum binding

Hi,
this PR will enable enum binding in modal parameters, this will allow to call
<button type="button" wire:click="$dispatch('openModal', {'component':'invoices.select-invoice','arguments':{'type':'outbound','status':'pending',}})">
    select invoice
</button>

with a modal like this one:
class SelectInvoice extends ModalComponent
{
    #[Rule('required')]
    public \App\Enums\Type $type;

    #[Rule('nullable')]
    public \App\Enums\Status $status;

    //...
}

before this fix, you will encounter this exception: Target [App\Enums\Type] is not instantiable.
with 6 lines of code, the enum value is resolved to its calss

Thanks!


Unable to focus or input text in TextField-widget in Overlay without giving its own materialApp.

I'm having trouble using TextField in overlay in my app.
In my app I'm trying to get text input from user in a custom overlay.
TextField does require the Material-parent but I can not get it to work without giving it its own MaterialApp.
Without MaterialApp I can not focus on the textfield or get the soft keyboard opened or insert any text into it even with hardware keyboard.
But long pressing and then pasting text does work. (?)
I am debugging in Android emulator.
How should one use TextField in overlay?
It does not seem right to create two MaterialApp widgets nested together. The MaterialApp creates and hosts the overlay's, right?
Or should the overlay be regarded as completely separate app which means it really should include its own MaterialApp-widget? The Overlay-class documentation only talks about making it possible to draw independent child widgets on top of owther widgets. Where should one read more information about Overlay?
This is also somewhat related to this StackOverflow question, where also the inclusion of MaterialApp-widget was questioned.
Steps to Reproduce
Use the included code.

Open new overlay with included button.
Try to focus on the TextField by tapping.

Reproduce code
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(home: MyHomePage());
  }
}

class MyHomePage extends StatelessWidget {
  static OverlayEntry menuOverlay;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Flutter textfield in overlay Demo'),
      ),
      body: Column(
        children: <Widget>[
          RaisedButton(
              onPressed: () => Overlay.of(context).insert(new OverlayEntry(builder: (BuildContext context) => MenuOverlay())),
              child: const Text('show overlay')),
        ],
      ),
    );
  }
}

class MenuOverlay extends StatefulWidget {
  MenuOverlay({Key key}) : super(key: key);

  @override
  _MenuOverlayState createState() => _MenuOverlayState();
}

class _MenuOverlayState extends State<MenuOverlay> {
  @override
  Widget build(BuildContext context) {
    return Stack(
      children: <Widget>[
        Positioned(
          top: 100.0,
          right: 10.0,
          child: Container(
            constraints: BoxConstraints(maxWidth: 200, maxHeight: 200),
            child:
           // MaterialApp( home:
              Material(
                type: MaterialType.transparency,
                child: TextField(
                  decoration: InputDecoration(hintText: 'Please enter a text'),
                  onSubmitted: print,
                ),
              ),
           // ), // MaterialApp
          ),
        ),
      ],
    );
  }
}

Logs
Flutter status
Output of flutter doctor -v:
# flutter doctor -v
[√] Flutter (Channel stable, v1.0.0, on Microsoft Windows [Version 10.0.17763.348], locale en-GB)
    • Flutter version 1.0.0 at C:\Users\username\development-tools\flutter_windows_v1.0.0-stable\flutter
    • Framework revision 5391447fae (3 months ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[√] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at C:\Users\username\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 33.3.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[√] VS Code (version 1.31.1)
    • VS Code at C:\Users\username\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 2.24.0

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

• No issues found!

To create a TextField in an Overlay you need to provide an enclosing FocusScope. My apologies: I don't think there's any way you could have known that.
Here's a version of your test app that manages the focus correctly:
https://gist.github.com/HansMuller/55f4e530a8e96777ad53af8bb20fb83b

I appreciate the fast answer!
But sadly your submitted Flutter app does not work on my android emulator. It does not gain focus, even if giving the text field autofocus: true,-parameter. Did you run it on some real hardware? Is this an issue within the emulator?
I even tried to put MaterialApp inside the submitted FocusScope-widget and with that the TextField cannot be focused. That's strange, because it works without the FocusScope-widget.
The MaterialApp does include it's own FocusScope, if I'm looking at Flutter inspector's widget tree correctly.
Is there still something missing?

I've verified that the test app works correctly on an Android emulator as well as a device.
However, a fix for FocusScope that was only added at the end of January is needed: https://github.com/flutter/flutter/pull/27365. Unfortunately this change has yet to land in a "good" dev build (it was in dev 1.3.9  which was considered a "bad build" for reasons unrelated to focus scopes) so for the moment to get the fix you'd have to build on the current Flutter repo. With any luck we'll have a new dev build that includes the fix soon. It's being worked on now.
Sorry about that.

Subscribing because there is a common input design pattern I am trying to implement where a textfield is brought up on an overlay and sits on top of the keyboard but it doesn't work smoothly without autofocus or focus nodes working in Overlays. The best that can be done before this fix hits is to show the textfield in the overlay and then when the user taps on it the keyboard comes up. But that's not really an elegant design.

Hi @guidezpl
Not able to reproduce this issue using your code sample  on latest dev channel on physical device or emulator

Code Sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(home: MyHomePage());
  }
}

class MyHomePage extends StatelessWidget {
  static OverlayEntry menuOverlay;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Flutter textfield in overlay Demo'),
      ),
      body: Column(
        children: <Widget>[
          RaisedButton(
              onPressed: () => Overlay.of(context).insert(new OverlayEntry(
                  builder: (BuildContext context) => MenuOverlay())),
              child: const Text('show overlay')),
        ],
      ),
    );
  }
}

class MenuOverlay extends StatefulWidget {
  MenuOverlay({Key key}) : super(key: key);

  @override
  _MenuOverlayState createState() => _MenuOverlayState();
}

class _MenuOverlayState extends State<MenuOverlay> {
  @override
  Widget build(BuildContext context) {
    return Stack(
      children: <Widget>[
        Positioned(
          top: 100.0,
          right: 10.0,
          child: Container(
            constraints: BoxConstraints(maxWidth: 200, maxHeight: 200),
            child:
                // MaterialApp( home:
                Material(
              type: MaterialType.transparency,
              child: TextField(
                decoration: InputDecoration(hintText: 'Please enter a text'),
                onSubmitted: print,
              ),
            ),
            // ), // MaterialApp
          ),
        ),
      ],
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-3.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-3.0.pre at /Users/taha/Code/flutter_dev
    • Framework revision 0af027f805 (5 days ago), 2020-07-04 12:19:20 -0700
    • Engine revision a751393804
    • Dart version 2.9.0 (build 2.9.0-20.0.dev 22da8934ac)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.1

[✓] Connected device (4 available)
    • SM M305F (mobile)      • 32003c30dc19668f          • android-arm64  •
      Android 10 (API 29)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E • ios            • iOS
      13.5.1
    • Web Server (web)       • web-server                • web-javascript •
      Flutter Tools
    • Chrome (web)           • chrome                    • web-javascript •
      Google Chrome 83.0.4103.116

• No issues found!

Just added a label, @Valtteri-Jokinen are you still facing this issue?

The original use-case in our app was redone to not use overlays to circumvent the problem.
Good if the issue has been fixed on the dev channel. Unfortunately I currently have no way to test if the issue is also fixed on the stable channel.
If the issue has been fixed then this issue can be closed.
Sorry for late reply.

Hi @HansMuller
given your last message I feel safe to close this issue, if you disagree please write in the comments and I will reopen it.
Thank you

I don't think this issue has been "fixed" in either branch, possibly because it's really about how one is supposed to implement it properly. I switched to dev and it didn't make a difference. @HansMuller's comment, however, saved the day.


vue-identicon fails to decode address length on polkadot icon

How to replicate:
-> https://dev-vue-polkadot.netlify.com/#/settings select polkadot
-> https://dev-vue-polkadot.netlify.com/#/addressbook and paste one of your valid address, delete one-two-three chars from address, paste new one address
Expected error: identicon is the same one, not new one.
Right behaviour: should generate new one icon

Fixed with release 0.0.7


create menu and implement a simple scene change

A small menu for navigating between

settings ( at a later point )
exit
and "start game"

is required so that we can link from a default screen towards this game easily.

added this feature in 0199690 on branch prototype/overworld