More configure flags

@maxim-belkin, this is the final set of configure flags. I apologize for it taking so long - it was extremely tedious.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Does your submission pass
brew audit --strict <formula> (where <formula> is the name of the formula you're submitting)?
[x] Have you built your formula locally prior to submission with brew install <formula>?

No tests, so the formulae don't pass a strict audit.

@rwhogg thanks! I would probably use a shell script to extract these flags... something like:
#!/bin/bash
cd $(brew --prefix)/Library/Taps/linuxbrew/homebrew-xorg
for file in *.rb; do
  name=${file%.rb}
  brew fetch $name
  cd $(brew --prefix);
  tar xf ${name}*tar.bz2;
  cd  ${name}*
  echo "Formula $name:"
  ./configure --help | grep -e "disable-dependency-tracking" -e "disable-silent-rules"
  cd $(brew --prefix)/Library/Taps/linuxbrew/homebrew-xorg
done

I would probably use a shell script to extract these flags...

Yeah, in retrospect I wish I had done that...


Add new feature to cluster data on the fly

supports running k-means on Orly's genomic data

support affinity propagation


TS typings missing in npm package

index.d.ts is missing after package installation

Maybe adding it in files section of package.json will fix that

Created pull request with the fix:
https://github.com/theBowja/genshin-db/pull/33
Please release new version of package to npm after merging. Thanks!

oh wow thanks


Solve #48 - Bug in deepEquals

Solves #48

Hey @micouz ,
Thanks a lot for submitting the PR.
Would it be possible for you to add some tests for deepEquals, so far we have none and it would prevent the issues you found in the first place.
Thanks in advance,

Hi @gor181 ,
My PR is a quick fix to solve a problem I have in a production app. I agree it's not optimal, however I don't intend to spend time to write tests for this particular problem. It has already been solved quite a few times (underscore, lodash, ramda and node-deep-equal are the implementations I know of), so I'd rather use one of those proved implementations instead.
The good thing about Lodash is that its functions are available as individual components on npm, so there is no need to import the whole library. Here's the one we need:
https://www.npmjs.com/package/lodash.isequal
What do you think ?

Hey @micouz ,
I agree.
Are you using your fork at the moment?

@gor181 Right now as a very short term solution I just applied the quick fix directly in the lib files in node_modules. Not pretty, but it's a small early stage project and I'm the whole team, so it can wait a while as is until a definitive solution is reached.

hey @micouz ,
Do you have an example where the deepEqual fails? I have tried to reproduce and I have noticed that sometimes there is "magical" _meta property (check image below):

Is this the same behaviour you have been experiencing?

What's even worse I think that chart.js directly mutates the props:
https://github.com/chartjs/Chart.js/blob/master/src/core/core.controller.js#L612-L633
by adding the _meta tag.

Hi @gor181,
I confirm you that chart.js does mutate its props. I discovered that because I sometimes deep-freeze my app state to prevent accidental mutations.
Tomorrow I'll try to give you more info so you can reproduce the bug.
Cheers,

Hi @gor181,
I can't reproduce the bug anymore, which is both good and bad. It would still be a good idea to switch to lodash.isequal, but from my side there's not point in merging this PR anymore.

hey @micouz ,
Thanks, I have started to work on implementation which includes isEqual.
Should be done soon.
Thanks for all the efforts.

Thanks @gor181, I'll close this up then.
Cheers,


Multiple dataframe viewers opened when viewing the exact same DF variable

Each time you click on a DF to view the DF, we open a new one.
This feels like a very poor UX, its like clicking on an ipynb and opening a new notebook everytime.
(when opening a large DF the memory usage doubles, after all we're cloning the JSON in memory for each webview).
We know the variable, hence it should be easy to check if it has already been displayed, also we have a refresh icon.

Now that we have refresh, this behavior does seem off.

Not reported by anyone, else closing this issue


input placeholder attribute with translate pipe ( 'HELLO' | translate ) and [matChipInput...] attributes does not update inside

Bug, feature request, or proposal:
Bug/proposal
What is the expected behavior?
  <mat-form-field>     <mat-chip-list #chipList>       <mat-chip *ngFor="let entry of dataSelected" [removable]="removable" > {{entry.displayName}}   </mat-chip>       <input placeholder="{{ 'HELLO' | translate }}" [matChipInputFor]="chipList" [matChipInputSeparatorKeyCodes]="separatorKeysCodes"         [matChipInputAddOnBlur]="addOnBlur" />     </mat-chip-list>   </mat-form-field>
EXPECTED - 'HELLO' should be translated to 'Hello'
What is the current behavior?
'HELLO' is shown as 'HELLO' for the first time when page is rendered.
when i click on input the placeholder floats with expected value 'Hello'.
Same issue occurs when i translate the language, Only this field doesn't translate as it is the only input tag i have inside mat-chip-list.
What are the steps to reproduce?
Working on it. I will update as soon as possible. Till then I have explained as much as I can.
What is the use-case or motivation for changing an existing behavior?
while using plugin "ngx-translate" npm package, we may come across situation that translations are provided with URL link / from another server. (as i came across such situation).
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular: 6.0.9
Material: 6.0.0
OS: linux x64
Typescript: 2.7.2
Browsers: Chrome 68.0.3440.106 (Official Build) (64-bit),
Firefox 61.0.1 (64-bit),
Safari 11.1.2 (13608.3.8)
Is there anything else we should know?
I am using "ngx-translate" npm package with "HttpLoaderFactory"
ngx-translate/core: 9.1.1
ngx-translate/http-loader: 3.0.1
All placeholder translations working fine, except the one which is inside mat-chip-list.
When i remove [matChipInputFor], [matChipInputSeparatorKeyCodes], [matChipInputAddOnBlur]
attributes the placeholder translation works fine.

Can you provide a reproduction in StackBlitz.  This will help us to investigate the issue you are seeing.

Closing as we are not be able to reproduce this issue.


Support syntax tree visualizer

Something similar to what LinqPad does, that'd be pretty awesome. (even a textual representation can be helpful though).

@alrz Sounds like a good idea, can't promise any specific timeline though.

@alrz Can you please link to some screenshots of good visualizers?
What information would be essential?
For context, I just prototyped something that would be useful for me, but I'm thinking whther I should go with a simple tree instead (this one can't really show trivia well):

http://www.linqpad.net uses a tree,

Also check out https://astexplorer.net.

@alrz OK, one more question -- what if I do something like https://roslynquoter.azurewebsites.net/ instead? Provides the same info, but also demonstrates the code to create a Syntax Tree as well.

That was actually what I had in mind when I said a textual representation, but forgot to provide the link. That'd be definitely useful. Thanks!

An update: tried to be too smart here, got stuck for a while and lost some motivation -- so this might be on a backburner for a week or two.

@alrz
I wasn't able to do the quoter within a reasonable time, so I did the UI first.
Current version at the 'edge':
https://edge.sharplab.io/#v2:C4LghgzsA0AmIGoA+BXCBLAdgcwAQGUBPKAUwFsBuAWACgAHFAIwBt0BjXN5yCXAYVwBvWrlG4GLdrgBuAe3SxcAWQAUASiFituEWIC+tPUA
I plan to release this to the main site very soon (day or two).
No hover yet, I'll probably do a separate ticket for that.

Done! Please raise new issues if you find any bugs/improvements.


certmgr: 1.6.4 -> 3.0.3, migrate to buildGoModule and by-name

Description of changes
fixes https://hydra.nixos.org/build/241297385
fixes #271296

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Please test @RobbieBuxton
nix shell github:nixos/nixpkgs/refs/pull/271299/head#certmgr-selfsigned

@pbsds Thanks for fixing this before I could blink lol, yeah no problems anymore on my end!

Result of nixpkgs-review pr 271299 run on aarch64-linux 1

1 package built:

certmgr

Could this be backported to 23.11?
nix shell github:NixOS/nixpkgs/nixos-23.11#certmgr-selfsigned -c certmgr version
error: hash mismatch in fixed-output derivation '/nix/store/chw7m5ssvzqgzasd6nvyfik79z4plm43-cloudflare-certmgr-pull-51.patch.drv':
         specified: sha256-OmOz6CeO1GTZ5NIVqhhnJWNP5K7X2LX28q+KlkrgGko=
            got:    sha256-0TEvUWH+ybtLiNxJAcpq7mThQzU6iQ1ykYVcikAyhVI=
error: 1 dependencies of derivation '/nix/store/38zbnb57frmlxvxwr67d7qi40755flyv-certmgr-1.6.4.drv' failed to build


Recommendation how to use DynamicCallOnStaticMethodsRule

Larastan Version: 0.6.2
--level used: 6

Description
I tried exploring to use DynamicCallOnStaticMethodsRule from https://github.com/phpstan/phpstan-strict-rules

Check that statically declared methods are called statically

The use-case is to prevent (accidentally? intentionally for sake of consistency?) calling something defined as static function… as $this->… when self:: should be used.
When I enabled it, I was greeted with thousands of errors because of all the static calls to \Illuminate\Database\Eloquent\Builder, \Illuminate\Database\Query\Builder and some from the Illuminate\Database\Eloquent\Relations namespace.
Some specific error examples:
  226    Dynamic call to static method
         Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Mod
         el>::orderBy().
…
  299    Dynamic call to static method
         Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Mod
         el>::forPage().
…
  73     Dynamic call to static method
         Illuminate\Database\Eloquent\Relations\HasMany<Illuminate\Database\El
         oquent\Model>::where().

List goes on, I've > 400 such errors 😅
So right now I've to use these ignoreErrors:
    - '/Dynamic call to static method Illuminate\\Database\\Eloquent\\Builder/'
    - '/Dynamic call to static method Illuminate\\Database\\Query\\Builder/'
    - '/Dynamic call to static method Illuminate\\Database\\Eloquent\\Relations\\/'

Is there anything Larastan can assist doing here? 🤔

🙈 Fully closing your eyes helps on the short-term :)

This is a known issue with that rule I think. #355 and #483 are the same types of issues. I still don't know exactly how to solve this.
I was thinking the issue comes from here maybe. So this has to change dynamically somehow.

Can you maybe test with changing to false here? Just to confirm again, it solves some of the issues.

Can you maybe test with changing to false

I can confirm (I guess), hard to say because now I get > 400 "Static call to instance method" errors; but yes, it flipped the side.
Interestingly, from the ignoreErrors I pasted, only two were reported as being unused
     Ignored error pattern /Dynamic call to static method
     Illuminate\\Database\\Query\\Builder/ was not matched in reported errors.
     Ignored error pattern /Dynamic call to static method
     Illuminate\\Database\\Eloquent\\Relations\\/ was not matched in reported
     errors.

The one ignoring Dynamic call to static method Illuminate\\Database\\Eloquent\\Builder is still encountered it seems.

I tried to search the issues for DynamicCallOnStaticMethodsRule. I know see the mistake I made, because although I installed the phpstan-struct-rules package, I only did this to enable this one rule, not everything.

Anyway, feel free to close this in favour of the existing ones. I don't think this issue brings news to the table…

Thank you Markus.
You may comment or open another issue Anytime!


Create _io_bdrhapsody.py

io for BDrhapsody scRNA scTCR and scdCODE data, preprocessed with the BDrhapsody-pipeline

Closed and reopened because the CI was stuck...

Thanks for adding this!
I'll give more detailed feedback later, but there are two more general things that need to be addressed:

We need a test-case that checks the function works as expected. Could you add a small sample file (like the first hundred lines of a real file) to the scirpy/tests/data/bd_rhapsody folder? And a test function to https://github.com/scverse/scirpy/blob/master/scirpy/tests/test_io.py (just like the test_read_10x_csv).
All code needs to be formatted using the black formatter.

Closed in favor of #351


Release @google-cloud/error-reporting v0.6.3

This pull request was generated using releasetool.

Release is at https://github.com/googleapis/nodejs-error-reporting/releases/tag/v0.6.3

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


[Feature]: Tooltip change to represent no new changes to pull

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
This is a tooltip content change, providing a better context of pull status.
Why should this be worked on?
The current tooltip "You have uncommitted changes, please commit before pulling the remote changes" is confusing when the user simply wants to discard their local changes and pull the latest remote code. This misleading message creates the impression that pulling is not possible with uncommitted changes, leading to miscommunication and frustration for the user.

I would like to share the analysis related to this issue:
Tooltip Message Update:
Current Situation: When the remote branch is ahead of the local branch and the user has uncommitted changes.
Proposed Change: Update the tooltip message to: "You have uncommitted changes. Please commit or discard your changes before pulling the remote changes."
Pull Button Status:
The pull button will remain disabled until the user commits or discards their changes.
Applicable Scenario:
This scenario applies only to unprotected git branches.
In summary, we need to update the tooltip message as described above.
@RoopKrrish9696 , do let me know if these changes are fine with you.


[SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

Co-authored-by: Sören Reichardt<EMAIL_ADDRESS>What changes were proposed in this pull request?
This PR introduces the necessary Maven modules for the new Spark Graph feature for Spark 3.0.

spark-graph is a parent module that users depend on to get all graph functionalities (Cypher and Graph Algorithms)
spark-graph-api defines the Property Graph API that is being shared between Cypher and Algorithms
spark-cypher contains a Cypher query engine implementation

Both, spark-graph-api and spark-cypher depend on Spark SQL.
Note, that the Maven module for Graph Algorithms is not part of this PR and will be introduced in https://issues.apache.org/jira/browse/SPARK-27302
A PoC for a running Cypher implementation can be found in this WIP PR https://github.com/apache/spark/pull/24297
How was this patch tested?
There is a DummySuite in spark-cypher to enforce building the modules.

@mengxr would be great if you could have a look

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10312/
Test PASSed.

Test build #105018 has started for PR 24490 at commit 02e803a.

Test build #105018 has finished for PR 24490 at commit 02e803a.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DummySuite extends SparkFunSuite

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105018/
Test FAILed.

Test build #105019 has started for PR 24490 at commit 5708086.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10313/
Test PASSed.

Test build #105019 has finished for PR 24490 at commit 5708086.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105019/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10333/
Test PASSed.

Test build #105043 has started for PR 24490 at commit b65a7b0.

For now, I added [test-maven] tag to the title in order to trigger Maven build.
To move forward, we also need to update SBT build file.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10337/
Test PASSed.

Test build #105047 has started for PR 24490 at commit b65a7b0.

@dongjoon-hyun What are the necessary steps to update the SBT build file?

For scala build, we need to update project/SparkBuild.scala and the related files. Before updating project directory, we need to decide Maven project structure first; external or not. Let's wait for the PMC's decision.

Test build #105043 has finished for PR 24490 at commit b65a7b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105043/
Test PASSed.

Test build #105047 has finished for PR 24490 at commit b65a7b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105047/
Test PASSed.

@dongjoon-hyun I'm working with @s1ck to create a shared jar of okapi-relational and rename it transitive dependencies. So the graph component only has this one external dependency. The size is about 18MB.

That's nice. Thank you for updating, @mengxr !

Here are a flattened list of runtime transitive dependencies of okapi-relational:
com.lihaoyi:acyclic_2.12:
com.lihaoyi:fastparse_2.12:
com.lihaoyi:sourcecode_2.12:
com.lihaoyi:ujson_2.12:
com.lihaoyi:upack_2.12:
com.lihaoyi:upickle-core_2.12:
com.lihaoyi:upickle-implicits_2.12:
com.lihaoyi:upickle_2.12:
org.apache.commons:commons-lang3:
org.apache.logging.log4j:log4j-api-scala_2.12:
org.apache.logging.log4j:log4j-api:
org.atnos:eff_2.12:
org.opencypher:ast-9.0:
org.opencypher:expressions-9.0:
org.opencypher:front-end-9.0:
org.opencypher:parser-9.0:
org.opencypher:rewriting-9.0:
org.opencypher:util-9.0:
org.parboiled:parboiled-core:
org.parboiled:parboiled-scala_2.12:
org.scala-lang.modules:scala-xml_2.12:
org.scala-lang:scala-compiler:
org.scala-lang:scala-library:
org.scala-lang:scala-reflect:
org.typelevel:cats-core_2.12:
org.typelevel:cats-kernel_2.12:
org.typelevel:cats-macros_2.12:
org.typelevel:machinist_2.12:

All are licensed under either Apache or MIT. Some test packages got pulled into runtime. I submitted a clean-up PR here: https://github.com/opencypher/morpheus/pull/907

Hi, @s1ck . Could you update this PR if the dependency is reduced?

@dongjoon-hyun We are currently looking into solving an issue around shading Scala libs. @mengxr described the issue here: https://contributors.scala-lang.org/t/tools-for-shading-a-scala-library/3317
This blocks us from introducing just one dependency that contains the needed Scala libs.
Do you have experience in shading Scala libs without running into downstream issues?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11116/
Test PASSed.

Test build #105860 has started for PR 24490 at commit 3af6ce7.

@dongjoon-hyun We have successfully reduced the dependencies using a shaded jar including relocated dependencies. Please have a second look.
@felixcheung The META-INF folder within the shaded jar lists all licenses (Apache 2.0 / MIT) and the libs that use them. Are there specific requirements where the license list should be stored?
@mengxr The shaded jar has been produced solely using Gradle Shadow, we did not fix annotations with ScalaShade or any other tooling. Instead, we removed leaking references to relocated libraries from our APIs. This allows us to successfully compile and run spark-cypher tests. I can summarize the relocation story in another PR comment but would not involve the mailing list, as this is basically unblocked now.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11118/
Test PASSed.

For scala build, we need to update project/SparkBuild.scala and the related files. Before updating project directory, we need to decide Maven project structure first; external or not. Let's wait for the PMC's decision.

I updated ScalaBuild.scala and can successfully run sbt compile. @dongjoon-hyun which additional locations do we need to update?

Test build #105862 has started for PR 24490 at commit bf7db46.

Test build #105860 has finished for PR 24490 at commit 3af6ce7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105860/
Test FAILed.

Test build #105862 has finished for PR 24490 at commit bf7db46.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105862/
Test FAILed.

Looks like the unit tests are failing in the Hive Thrift Server module. Not sure this PR affects that module?

@dongjoon-hyun Could you please have another look at the PR? Thanks!

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11319/
Test PASSed.

Test build #106068 has started for PR 24490 at commit bf7db46.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11321/
Test PASSed.

Test build #106070 has started for PR 24490 at commit bf7db46.

Test build #106070 has finished for PR 24490 at commit bf7db46.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106070/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11322/
Test PASSed.

Test build #106071 has started for PR 24490 at commit bf7db46.

Test build #106071 has finished for PR 24490 at commit bf7db46.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106071/
Test FAILed.

Test build #106068 has finished for PR 24490 at commit bf7db46.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106068/
Test PASSed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11338/
Test PASSed.

Test build #106086 has started for PR 24490 at commit bf7db46.

Test build #106086 has finished for PR 24490 at commit bf7db46.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106086/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11342/
Test PASSed.

Test build #106090 has started for PR 24490 at commit bf7db46.

Test build #106090 has finished for PR 24490 at commit bf7db46.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106090/
Test FAILed.

@dongjoon-hyun how can we fix the mima issue? I tried running dev/mima -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos locally and it never failed.

Test build #106113 has started for PR 24490 at commit de198f0.

Test build #106113 has finished for PR 24490 at commit de198f0.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106113/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11364/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11374/
Test PASSed.

Test build #106122 has started for PR 24490 at commit afcf94a.

Test build #106122 has finished for PR 24490 at commit afcf94a.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106122/
Test FAILed.

Test build #106125 has started for PR 24490 at commit b1d3e7a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11377/
Test PASSed.

Test build #106125 has finished for PR 24490 at commit b1d3e7a.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106125/
Test FAILed.

Thank you for updating. @s1ck . Ya. The MiMa failure looks weird to me, too.
Could you give us some advice for MiMa issue please, @mengxr , @gatorsmile , @srowen , @JoshRosen ?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11394/
Test PASSed.

Test build #106141 has started for PR 24490 at commit c4dc60d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11395/
Test PASSed.

Test build #106142 has started for PR 24490 at commit 76fbe12.

Test build #106141 has finished for PR 24490 at commit c4dc60d.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106141/
Test FAILed.

Test build #106142 has finished for PR 24490 at commit 76fbe12.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106142/
Test FAILed.

@srowen @dongjoon-hyun It seems that something unrelated to this PR changed.
Successful run: https://github.com/apache/spark/pull/24490#issuecomment-498075761
First failed run: https://github.com/apache/spark/pull/24490#issuecomment-498104960
Both builds point to the same commit: https://github.com/apache/spark/commit/bf7db46d7dc548ffecb84d5696281951a46e5ae7

Try running ./dev/mima locally to see why it fails, if there is any more info. There's no output for some reason here. It may well be some issue with how it's run in Jenkins.

@dongjoon-hyun how can we fix the mima issue? I tried running dev/mima -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos locally and it never failed.

@srowen I tried it with the same params that CI uses, I got exit code 0. I also tried without arguments, exit code 0.

@s1ck You need to add new modules to https://github.com/apache/spark/blob/76fbe121ab2e829f75389c6fd466afcf2ec3b9d1/project/SparkBuild.scala#L335
This will disable mimi check. Mima doesn't work for new module since it cannot fetch old versions of them.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11485/
Test PASSed.

Test build #106236 has started for PR 24490 at commit 31d11ca.

Test build #106236 has finished for PR 24490 at commit 31d11ca.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106236/
Test FAILed.

Test build #106237 has started for PR 24490 at commit 47bd5bc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11487/
Test PASSed.

Test build #106237 has finished for PR 24490 at commit 47bd5bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106237/
Test PASSed.

@zsxwing Thanks! That fixed the build.
@srowen @dongjoon-hyun Could you please have another look and finish your reviews? Thanks.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11562/
Test PASSed.

Test build #106315 has started for PR 24490 at commit 47bd5bc.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11563/
Test PASSed.

Test build #106316 has started for PR 24490 at commit 47bd5bc.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11564/
Test PASSed.

Test build #106317 has started for PR 24490 at commit 47bd5bc.

Test build #106315 has finished for PR 24490 at commit 47bd5bc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106315/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11568/
Test PASSed.

Test build #106321 has started for PR 24490 at commit 47bd5bc.

Test build #106321 has finished for PR 24490 at commit 47bd5bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106321/
Test PASSed.

Test build #106316 has finished for PR 24490 at commit 47bd5bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106316/
Test PASSed.

Test build #106317 has finished for PR 24490 at commit 47bd5bc.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106317/
Test FAILed.

Checkstyle checks failed at following occurrences:
[ERROR] Failed to execute goal on project spark-cypher_2.12: Could not resolve dependencies for project org.apache.spark:spark-cypher_2.12:jar:3.0.0-SNAPSHOT: Could not find artifact org.apache.spark:spark-graph-api_2.12:jar:3.0.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :spark-cypher_2.12
Build step 'Execute shell' marked build as failure
Finished: FAILURE

This also breaks the style check. Could any of you investigate it ASAP? Or we might need to revert this PR.

If you can't figure it out in a few mins, the right way is to revert, fix, and then remerge.

I can have a look, but I'm also surprised that CI didn't complain before the merge. Any ideas @gatorsmile ?

@gatorsmile Where did you find that log output? I can only find a failing test:
org.apache.spark.sql.kafka010.KafkaContinuousSourceSuite.subscribing topic by name from latest offsets (failOnDataLoss: true)

We don't have a style issue.
$ dev/scalastyle
Scalastyle checks passed.

$ dev/lint-java
Using `mvn` from path: /usr/local/bin/mvn
Checkstyle checks passed.

I'll going to monitor the ongoing Jenkins.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.7/5969/ (SBT/Hadoop-2.7)
https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-2.7/6459/console (Maven/Hadoop-2.7)
https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-2.7-jdk-11-ubuntu-testing/ (Maven/Hadoop-2.7/JDK11)

@s1ck . You can check the master lint result here.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Compile/job/spark-master-lint/10363/

It's not green.

master branch shows green in the following Jenkins jobs and Maven/Hadoop2.7 also looks good so far. This commit is safe.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.7/ (SBT/Hadoop-2.7)
https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Compile/job/spark-master-lint/ (Lint)

The root cause of the problem is not inside Apache Spark repository. AmbLab Jenkins script is still using --force option which is deprecated at Apache Spark 2.0.0. We should clean up at this time. I can volunteer for that if the repo becomes accessible to me.

@dongjoon-hyun I have admin access. I think @shaneknapp can grant it and interested committers should probably have it. Are there any more jobs to change? that looks OK now?

Oh, could you give me the access, too? Thanks, please. I sent an email Shane yesterday, but he is off until 13th unfortunately.
We need to update old Jenkins script and bring back https://github.com/apache/spark/pull/24824 .

I just mean I think I can modify Jenkins job configs if that's what's needed. Do you know which ones need modifying? or are they not in the Jenkins job configs in the UI? I don't think I have access to give admin access, or don't know how to do that.

Thanks. Then, at least, for the three profiles for master branch, could you remove --force from the following MVN declaration? I'm not sure the name of script. But, the following is the Jenkins' result.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-2.7/6458/console

+ [[ master < branch-1.5 ]]
+ MVN='build/mvn --force -DzincPort=3428'
+ set +e
+ [[ hadoop-2.7 == hadoop-1 ]]
+ build/mvn --force -DzincPort=3428 -DskipTests -Phadoop-2.7 -Pyarn -Phive -Phive-thriftserver -Pkinesis-asl -Pmesos clean package

FYI, you can remove --force from all active branches because --force is deprecated at 2.0.0.

OK, I see it now, I removed this from both of the mvn master builds.

IIUC, this looks like just because of the known issue in mvn checkstyle:check command (called by lint-java script). It requires all dependencies of a module (even dependencies are just other sub-modules) can be found in the local repo (You can run mvn install to install sub-modules) or a remote repo.
It's green now because this Jenkins job ( https://amplab.cs.berkeley.edu/jenkins/job/spark-master-maven-snapshots/ ) pushed the artifacts to https://repository.apache.org/content/repositories/snapshots/. Hence maven can download all artifacts of sub-modules from this repo now.
In general, the java style check may fail if someone adds multiple maven projects, until the artifacts are pushed to the apache snapshot repo. But this should be fine since that's rare and we push snapshots every day.
By the way, I also noticed that java style check is enabled in the PR build now: https://github.com/apache/spark/blob/742f805177e3fafae61a760b570b5bb2825237b3/dev/run-tests.py#L593 This issue may happen in the PR build if a PR also adds Java files which will trigger java style check. Java style check needs to be disabled until the artifacts of this project are pushed to the apache snapshot repo. Not sure where to document this. ( I learnt this issue in one of my old PRs https://github.com/apache/spark/pull/10744#issuecomment-172677275 and disabled the java style check in https://github.com/apache/spark/commit/4bcea1b8595424678aa6c92d66ba08c92e0fefe5#diff-9657d18e98a7dc82ca214359cfd6bdc4 )


Adds isSubtype() and parentSubtype() functions to RoSGNode

Solves https://github.com/sjbarag/brs/issues/582

Made some Changes so subtypeHierarchy is updated both in builtin types and in components that ar e loaded through XML - see the tests


Fix Restrict the import of VARCHAR(0) data to avoid coredump #40940

cherry pick from #40940

run buildall


Request for aws_mskconnect_* resources

What resource do you need?
Terraform Resource Name:
aws_mskconnect_connector
aws_mskconnect_custom_plugin
aws_mskconnect_worker_configuration
What is your use case?
Use of Debezium source/S3 sink connectors

Related https://github.com/upbound/provider-aws/issues/374


Fix text function not being optimized.

This fixes the issue brought up in #204, but was not actually fixed by the change.
It seems like uglify optimizes the previous change out.
@paolocaminiti @jridgewell Any thoughts?

I suppose if both uglify and closure are fine this way then that's the best bet, the comment is enough to remember the rationale.
Here is an ongoing thread about deopts, the case is not present, I'll be adding an example. As sparhami said the initial usage seems fine in itself but V8 doesn't recognize it.
https://github.com/GoogleChrome/devtools-docs/issues/53

Booo uglify... But this is fine. We can add a regression test, too:
import { text } from "incremental-dom";

it('do not leak arguments', () => {
  text('value', () => {
    expect(this).to.equal(undefined);
  });
});

I suppose if both uglify and closure are fine this way then that's the best bet, the comment is enough to remember the rationale.

Here is an ongoing thread about deopts, the case is not present, I'll be adding an example. As sparhami said the initial usage seems fine in itself but V8 doesn't recognize it.
GoogleChrome/devtools-docs#53

I was mistaken, our usage was actually bad. Since object lookup is the same as property access (and arrays are really just objects with some optimizations), the previous usage was equivalent to someObj.prop(), where someObj becomes the context. In this case, since the context is the arguments object, it counts as leaking it and thus cannot be optimized.


Error when compile with arm-none-eabi-gcc-9.2.1

Is it possible to build tflite micro with arm-none-eabi-gcc-9.2.1, when i build the library use the defualt download gcc ererything works fine. Since the whole project of mine, which i want to add tflm in is build use arm-none-eabi-gcc-9.2.1, so i change the gcc version to arm-none-eabi-gcc-9.2.1 in tensorflow/lite/micro/tools/make/downloads/gcc_embedded/  that cause the build error.
Here is the make command i use:
make -f tensorflow/lite/micro/tools/make/Makefile BUILD_TYPE=release TARGET=cortex_m_generic TARGET_ARCH=cortex-m33 OPTIMIZED_KERNEL_DIR=cmsis_nn microlite -j8
and the errors occurs below
In file included from tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Include/arm_nnsupportfunctions.h:33,                  from tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.c:32: tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.c: In function 'arm_relu_q15': tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Include/Internal/arm_nn_compiler.h:187:20: error: implicit declaration of function '__qsub16' [-Werror=implicit-function-declaration]   187 |     #define QSUB16 __qsub16       |                    ^~~~~~~~ tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.c:71:16: note: in expansion of macro 'QSUB16'    71 |         mask = QSUB16(0x00000000, buf);       |                ^~~~~~ tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.c: At top level: cc1: error: unrecognized command line option '-Wno-unused-private-field' [-Werror] cc1: all warnings being treated as errors tensorflow/lite/micro/tools/make/Makefile:709: recipe for target 'gen/cortex_m_generic_cortex-m33_release/obj/third_party_kernels/tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.o' failed make: *** [gen/cortex_m_generic_cortex-m33_release/obj/third_party_kernels/tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.o] Error 1 make: *** Waiting for unfinished jobs....
any ideal to solve it?

also happens to other kernel in cmsis-nn
                 from tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.c:32: tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.c: In function 'arm_relu_q15': tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Include/Internal/arm_nn_compiler.h:187:20: error: implicit declaration of function '__qsub16' [-Werror=implicit-function-declaration]   187 |     #define QSUB16 __qsub16       |                    ^~~~~~~~ tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.c:71:16: note: in expansion of macro 'QSUB16'    71 |         mask = QSUB16(0x00000000, buf);       |                ^~~~~~ In file included from tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Include/arm_nnsupportfunctions.h:33,                  from tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q7.c:32: tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q7.c: In function 'arm_relu_q7': tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Include/Internal/arm_nn_compiler.h:186:19: error: implicit declaration of function '__qsub8' [-Werror=implicit-function-declaration]   186 |     #define QSUB8 __qsub8       |                   ^~~~~~~ tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q7.c:71:16: note: in expansion of macro 'QSUB8'    71 |         mask = QSUB8(0x00000000, buf);       |                ^~~~~ In file included from tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Include/arm_nnsupportfunctions.h:33,                  from tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/BasicMathFunctions/arm_elementwise_mul_s8.c:32: tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/BasicMathFunctions/arm_elementwise_mul_s8.c: In function 'arm_elementwise_mul_s8': tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Include/Internal/arm_nn_compiler.h:188:20: error: implicit declaration of function '__sadd16' [-Werror=implicit-function-declaration]   188 |     #define SADD16 __sadd16       |                    ^~~~~~~~ tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/BasicMathFunctions/arm_elementwise_mul_s8.c:119:15: note: in expansion of macro 'SADD16'   119 |         a_1 = SADD16(a_1, offset_1_packed);       |               ^~~~~~ tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.c: At top level: cc1: error: unrecognized command line option '-Wno-unused-private-field' [-Werror] cc1: all warnings being treated as errors tensorflow/lite/micro/tools/make/Makefile:709: recipe for target 'gen/cortex_m_generic_cortex-m33_release/obj/third_party_kernels/tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.o' failed make: *** [gen/cortex_m_generic_cortex-m33_release/obj/third_party_kernels/tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q15.o] Error 1 make: *** Waiting for unfinished jobs.... tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q7.c: At top level: cc1: error: unrecognized command line option '-Wno-unused-private-field' [-Werror] cc1: all warnings being treated as errors tensorflow/lite/micro/tools/make/Makefile:709: recipe for target 'gen/cortex_m_generic_cortex-m33_release/obj/third_party_kernels/tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q7.o' failed make: *** [gen/cortex_m_generic_cortex-m33_release/obj/third_party_kernels/tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/ActivationFunctions/arm_relu_q7.o] Error 1 tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/BasicMathFunctions/arm_elementwise_mul_s8.c: At top level: cc1: error: unrecognized command line option '-Wno-unused-private-field' [-Werror] cc1: all warnings being treated as errors tensorflow/lite/micro/tools/make/Makefile:709: recipe for target 'gen/cortex_m_generic_cortex-m33_release/obj/third_party_kernels/tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/BasicMathFunctions/arm_elementwise_mul_s8.o' failed make: *** [gen/cortex_m_generic_cortex-m33_release/obj/third_party_kernels/tensorflow/lite/micro/tools/make/downloads/cmsis_nn/Source/BasicMathFunctions/arm_elementwise_mul_s8.o] Error 1

Hi @hmVictorYu
What host platform are you building on, e.g. Linux and what is the download link?
If you could provide a draft PR or copy paste the code where the downloaded version is updated here, it would help: https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/tools/make/arm_gcc_download.sh


Validation Problem

Pytorch:1.8.0
CUDA:11.1
I use the command, but it can't run. Like Stopping, I do mistake?
python3 val.py --labels /home/minggatsby/GitHub/datasets/annotations_trainval2017/annotations/person_keypoints_val2017.json --images-folder /home/minggatsby/GitHub/datasets/val2017 --checkpoint-path /home/minggatsby/GitHub/models/checkpoint_iter_370000.pth
then, I use ctrl+c
^CTraceback (most recent call last):
File "val.py", line 178, in
evaluate(args.labels, args.output_name, args.images_folder, net, args.multiscale, args.visualize)
File "val.py", line 132, in evaluate
total_keypoints_num += extract_keypoints(avg_heatmaps[:, :, kpt_idx], all_keypoints_by_type, total_keypoints_num)
File "/home/minggatsby/GitHub/lightweight-human-pose-estimation.pytorch/modules/keypoints.py", line 12, in extract_keypoints
heatmap[heatmap < 0.1] = 0
KeyboardInterrupt

Validation can be extremely slow if network weights were not loaded properly. Is it the full log after running val.py? Does demo run well with this checkpoint?

I run the command, my camera already run, but I can't see any windows. Maybe it's my opencv or qt problem?
python3 demo.py --checkpoint-path /home/minggatsby/GitHub/models/checkpoint_iter_370000.pth --video 0

Looks like something went wrong. You can try to run the demo with --cpu option to check if it is a gpu-related issue. In general try to localize the line in the code which causes the freeze (or works an enormous time), it may give a hint.

I am using other computer about rtx 2070 super / cuda 10.2 / cuDNN : <IP_ADDRESS>-1 / Pytorch 1.8.0 / opencv 4.5.1.
I run the following command , its error.
python3 demo.py --checkpoint-path /home/minggatsby/GitHub/models/checkpoint_iter_370000.pth --video 0
Traceback (most recent call last):
File "demo.py", line 166, in
run_demo(net, frame_provider, args.height_size, args.cpu, args.track, args.smooth)
File "demo.py", line 93, in run_demo
heatmaps, pafs, scale, pad = infer_fast(net, img, height_size, stride, upsample_ratio, cpu)
File "demo.py", line 68, in infer_fast
stages_output = net(tensor_img)
File "/home/minggatsby/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/minggatsby/GitHub/lightweight-human-pose-estimation.pytorch/models/with_mobilenet.py", line 115, in forward
backbone_features = self.model(x)
File "/home/minggatsby/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/minggatsby/anaconda3/lib/python3.8/site-packages/torch/nn/modules/container.py", line 119, in forward
input = module(input)
File "/home/minggatsby/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/minggatsby/anaconda3/lib/python3.8/site-packages/torch/nn/modules/container.py", line 119, in forward
input = module(input)
File "/home/minggatsby/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/minggatsby/anaconda3/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 399, in forward
return self._conv_forward(input, self.weight, self.bias)
File "/home/minggatsby/anaconda3/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 395, in _conv_forward
return F.conv2d(input, weight, bias, self.stride,
RuntimeError: cuDNN error: CUDNN_STATUS_NOT_INITIALIZED
===================================================================================
then, I run the following command, it has windows, it can run. However, it still has some error hint.
python3 demo.py --checkpoint-path /home/minggatsby/GitHub/models/checkpoint_iter_370000.pth --video 0 --cpu
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)
QObject::moveToThread: Current thread (0x55b0ee071e00) is not the object's thread (0x55b0edb95150).
Cannot move to target thread (0x55b0ee071e00)

Great, that it works!


Ignore NULL values

Is your feature request related to a problem? Please describe.
The NULL values in the Fiware entities have this syntax:
  "<property_name>": {
       "type" : "Property",
       "value": {
          "@type":  "Intangible",
          "@value":  null
      }
    }

I have a sensor with 4 fields: Humidity1, Humidity2, Humidity3 and Battery. If one of the measurements fails when I create the sensor, this field has a null value in Orion and quantumLeap saves it as an object (see syntax above) and therefore crateDB has this error:
ProgrammingError('SQLActionException[ColumnValidationException: Validation failed for batterylevel: Cannot cast {"@type"=\'Intangible\', "@value"=NULL} to type bigint]')

Describe the solution you'd like
I think it's a good idea for quantumLeap to ignore the value when it has the syntax described above
Describe alternatives you've considered
Another  alternative could be saved the value as Null

@husqD thanks for reporting this. I've got one question though what's the type of the BatteryLevel prop? Looking at the error code it was supposed to be an integer but in your example you've got a type of Intangible. We don't support multiple types for attributes/properties. The first time QL receives an attribute it tries to determine its type and then creates a DB column accordingly. If later on the prop type changes, on receiving the new prop value you'll get a DB type mismatch which causes the error you reported. Could it be that what happened in your tests is this:

Connect device.
Device sends battery level of integer type and value x, e.g. 10.
DB column batterylevel gets created w/ type of bigint and a row gets inserted with value of x.
Device sends battery level of Intangible type and value of null.
DB insert fails b/c of type mismatch.

Notice how the type changed from step 2 to step 4. Like I said we don't support this. Also, in principle I don't think these two NGSI-LD properties should be considered the same?
"batteryLevel": {
    "type" : "Property",
    "value": {
        "@type":  "Integer",
        "@value":  10
    }
}

"batteryLevel": {
    "type" : "Property",
    "value": {
        "@type":  "Intangible",
        "@value":  null
    }
}

i.e. they just happen to share the same name but probably have a different LD context expansion?

Hi @c0c0n3,
I use the Iot-Agent for Lorawan and when I create a device I define humidity measurements in this way:
{
          "object_id": "h1",
          "name": "soilMoisture1",
          "type": "Property",
          "metadata": { "unitCode": {"type": "Text", "value": "P1" }}
 },

My problem is that in my application the user can manage his own dataloggers. When he defines a sensor, he can choose if the datalogger has 1, 2 or 3 soil moisture sensors. So, if the user defines a datalogger with two moisture sensors but the datalogger sends only the measurements from one moisture sensor, the iot-agent gives the intangible value to the second sensor.
This is an example of a datalogger with two humidity measurements defined, but one has not been sent yet (due to sensor failure or human error), so the iot-agent gives it an intangible value:
{
    "@context": <MyContext>,
    "type": "Device",
    "batteryLevel": {
        "value": 3670,
        "type": "Property",
        "observedAt": "2021-04-26T06:45:52.876Z",
        "unitCode": "2Z"
    },
    "soilMoisture1": {
        "value": 12,
        "type": "Property",
        "observedAt": "2021-04-26T06:45:52.876Z",
        "unitCode": "P1"
    },
    "soilMoisture2": {
        "type": "Property",
        "value": {
            "@type": "Intangible",
            "@value": null
        },
        "unitCode": "P1"
    },
    "hasAgriParcel": {
        "object": "urn:ngsi-ld:AgriParcel:001",
        "type": "Relationship",
        "observedAt": "2021-04-26T06:45:52.876Z"
    }
}

This only happens if the measurement has never been sent, so the iot-agent can't give it a value type. And as a consequence QuantumLeap saves the value as an object.

@husqD thanks so much for the example and for clarifying what's going on. Like I said QL doesn't support changing attribute/property type over time. I realise this is a bit of a bummer, but we don't have any easy way to support that at the moment. But maybe there's a workaround...

So, if the user defines a datalogger with two moisture sensors but the datalogger sends only the measurements from one moisture sensor, the iot-agent gives the intangible value to the second sensor.

I've never come across this Intangible type in the IoT agents and if I search for it in the Lorawan agent repo it doesn't look like it's anywhere in the code base:

https://github.com/Atos-Research-and-Innovation/IoTagent-LoRaWAN/search?q=Intangible

Which Lorawan agent version are you on? Could it be that it's actually the device using that type? i.e.
device algo

if no soilMoistureN:
    send (soilMoistureN, Intangible, null)
else
    send (soilMoistureN, Property, valueOf(soilMoistureN))

Or maybe there's some custom mapping defined in the agent config that maps null to Intangible? Is there any way you could change that so soilMoistureN always has a type of Property? Given your setup I'm not sure you can, but I'm asking just in case...

@c0c0n3 thanks for your reply,
The intangible type is an iotagennt-node-lib thing. You can check it in the metadata support section of this
documentation: https://iotagent-node-lib.readthedocs.io/en/latest/advanced-topics/index.html
This error is caused by a human error in the lorawan backend. If a user defines a datalogger with two soil moisture measurements, but only sends one value, the iotagent-node-lib gives intangible to the missing value, because it does not know what kind of value it is.
It's not really a big problem, I can try to check the value in the IoT-Agent, but I think it could be useful if quantumLeap could check if the value is intangible to ignore it.

@husqD

The intangible type is an iotagennt-node-lib thing

Holy moly! It's one of those new NGSI-LD changes I missed. Thank you sooo much for the reference!

I think it could be useful if quantumLeap could check if the value is intangible to ignore it.

Agreed! This should be part of the changes we're slowly trying to implement to complete support for NGSI-LD. Well, strictly speaking it's not part of the spec, but for practical purposes we should take it into account I reckon since it made it into the agents lib, so it's going to affect all agents under the sun!

Thank you @c0c0n3!!
I am glad to know that it will be considered.  It is appreciated that there are developers with your patience and good humor.

@husqD well, thank you for taking the time to help us out and for patiently explaining things, it usually takes me a bit to catch on to what peeps are saying---don't judge me, old age you know :-)

Hey there,
just to get this straight... there is no way of excluding Null values from QL's response? QL does not yet support simple query language, does it? Thanks as always :)

@SBlechmann i think your request is unrelated to the one from @husqD so i recommend to open up a specific issue for it
at the time being there is no way to strip null values as you said, but in some queries it may be possible to do so, without creating a mess in the data structure.

@chicco785 yea, I guess you are right, I'm gonna open a seperate issue. Thanks for the answer!


471 create camera cancel bottom sheet

#471
https://user-images.githubusercontent.com/13311268/222974139-6b21fca7-63f0-4c71-92fa-a503febbf82c.mov

@albullington Thanks for the review! Went ahead and put in those changes
iOS + android views

Back button (swipe to go back) on android + outside click to close
https://user-images.githubusercontent.com/13311268/223342533-80c8d68a-5251-455b-8439-13f5f4ae0a14.mov


Rename _separate to forward_wav

Proposition: rename _separate to forward_wav in BaseModel.
This is something that was a bit discussed in #305  : asking users to overwrite a private method doesn't feel right. This fixes it.
Possibly in conflict with #305

This is ready IMO.
Waiting for review.

See comments, otherwise LGTM

/rebase


Screen updates are not stable

Description
Screen updates are not stable
https://youtu.be/5rGbVSVFMZk
I am developing Android applications using SkiaSharp and SkiaSharp.Views.Forms (using Xamarin.Forms).
I am suffering because this application is not stable frame rate.
I am programming to update the screen at 60 FPS, but the update is not stable.
I wonder why
For some reason the screen update is done at 60 FPS only during the touch, and if there is no touch it will be a slow screen update.
There is no touch related setting in the code.
What kind of place do I have to check to update the screen at 60 FPS?
Code
Buildable solution:
https://www.dropbox.com/s/aquap1xwfxinz3j/SkiaSharpFrameratesProblem.zip?dl=0
<ContentPage x:Class="App5.MainPage"
             xmlns="http://xamarin.com/schemas/2014/forms"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:forms="clr-namespace:SkiaSharp.Views.Forms;assembly=SkiaSharp.Views.Forms">
    <forms:SKCanvasView x:Name="Canvas"/>
</ContentPage>

public partial class MainPage
{
    public MainPage()
    {
        InitializeComponent();
    }

    protected override void OnAppearing()
    {
        base.OnAppearing();

        var stopwatch = Stopwatch.StartNew();
        var tp = new SKPaint
        {
            Style = SKPaintStyle.Fill,
            Color = SKColors.DarkBlue,
            IsAntialias = true,
            TextSize = 70.0f,
        };

        var timer = new Timer(1000.0 / 60.0);
        timer.Elapsed += (_, __) => Device.BeginInvokeOnMainThread(Canvas.InvalidateSurface);
        timer.Start();

        var x = 0;

        Canvas.PaintSurface += (_, e) =>
        {
            var interval = stopwatch.ElapsedMilliseconds;
            stopwatch.Restart();

            e.Surface.Canvas.Clear(SKColors.LightGray);

            e.Surface.Canvas.DrawText($"Interval:{interval}", new SKPoint(150, 150), tp);

            if ((++x) >= 120)
                x = 0;

            e.Surface.Canvas.DrawText("$", new SKPoint(150 + x * 4, 300), tp);
        };
    }
}

Basic Information
Android: OnePlus6(Oreo 8.1)
SkiaSharp: 1.60.3
Xamarin.Forms: <IP_ADDRESS>7

Commenting to mention that fixing the issue here: https://github.com/mono/SkiaSharp/issues/552
Could possibly fixup this problem.

Please let me know if you know the reason.
This case is FPS 60 only while touching.
What is the reason why the frame rate is low if I do not touch it?
I feel wondering why the frame rate will be high during  touch.

This is very interesting... I had a look and as long as you don't touch the screen, you get about 45 fps just fine - this is less that 60 fps because maybe of something we are doing that can be improved. But that is not the issue here.
As soon as I touch the screen, the frames drop to about 30 fps and hover around there. Then, when I drag my finger across the screen, the fps go up to 45 again.
This happens with the plain Android view, so appears to have nothing to do with Xamarin.Forms or the Forms view directly.
I will investigate this and see what I find.

Hey @mattleibow have you been able to find any solutions to this yet? I am running into the same problem with Xamarin.Forms when deployed on a real android device. The issue doesn't seem to be present when on an emulator. I am on Xamarin.Forms version <IP_ADDRESS>3527-pre3, VS Pro 17, and SkiaSharp.Views.Forms 1.60.3. Thanks!

You better use SKGLView if you want real time or independent updates on the view. Because Timer updates inaccurate and therefore View invalidations may happen with noticeable delays, and thus new visual updates hardly depend on how soon the last update happened. And in the end your 1000.0 / 60.0 interval will not give you expected results.
Also counting frame interval is a bit wrong though works in this case. It is usually done like this
time = stopwatch. ElapsedMilliseconds;
interval = time - lastTime;
lastTime = time;


solved #534 Added monthly rent calculator

🚀 Pull Request
Description
solved #534 Added monthly rent calculator
https://github.com/user-attachments/assets/7645685a-31ff-41fa-9cae-d91fcfa405ce

Related Issue
If this pull request addresses an issue, link to it here (e.g., Closes #123).

Type of Change
What kind of change does this pull request introduce?

[ ] 🐛 Bug fix
[ ] 🚀 New feature
[ ] 📄 Documentation update
[ ] 🛠 Code improvement/refactor
[ ] 🖼 UI/UX update
[ ] Other (please specify)

Screenshots (if applicable)
Add screenshots or screen recordings to demonstrate the new feature or fix.

Checklist
Please ensure the following tasks are complete before submitting the pull request:

[ ] I have tested my changes and ensured they work as expected.
[ ] I have added any necessary documentation or comments.
[ ] I have checked the existing issues and pull requests to avoid duplicates.
[ ] I have starred this repository.
[ ] I have reviewed my code for best practices and readability.
[ ] I have included any relevant tests (if applicable).

Additional Context
Add any other relevant information or context about the pull request here.

@gauravsingh1281 pleaase review this and add level3 as this is my third pr o fthis issue faced many conflicts

@gauravsingh1281 please merge this fast


feat: added get feeds endpoint

Related Issue (Link to issue ticket)

#66
Description

Fetching feeds/posts for user using websocket to inject newly created post
Context

How Has This Been Tested? Screenshots (if appropriate - Postman, etc)

Pytest

Responses

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Explain the nesting cause it looks repetitive

Explain the nesting cause it looks repetitive

When getting post, post can either be just a normal post( that have not being reposted) or a repost of another post.
That's where the original post and original post owner comes in
So every repost has a field to identify the original post.


Re-applies fair search design

Fixes #1920.
I couldn't quite get the colours right since the icon is a different image – I thought it made more sense for the icons/text size to match the main search than to adhere to exactly what it used to look like. @katarinabatina I'm happy to work on this more, here's what fair search looks like now:

Main search remains unchanged.

close button feels nicer too 👍

Wunderschön! I love the ARSearchViewControllerStyling class 👏


Fix content type name before charset recognition

Hi. I faced little bug in HeaderHelper.class. It is building default charset for content type in a such way:
if (encoderConfig.shouldAppendDefaultContentCharsetToContentTypeIfUndefined()) {
     contentType += "; charset=";
     if (encoderConfig.hasDefaultCharsetForContentType(contentType)) {
         contentType += encoderConfig.defaultCharsetForContentType(contentType);
     } else {
         contentType += encoderConfig.defaultContentCharset();
     }
}
return contentType;

So it means that content type is modified with "; charset=" part before passing this value to EncoderConfig#hasDefaultCharsetForContentType. And in my case with "application/json" I've got
"application/json; charset=". Instead of getting charset as UTF-8 that is configured in EncoderConfig#DEFAULT_CHARSET_FOR_CONTENT_TYPE as default for json content type I've got ISO-8859-1 that is used as global default charset.
Pls review and share your thoughts. Thanks.

@johanhaleby pls review.

Thank you the PR and your patience, well spotted!

In Spring Boot the current supported version of Rest Assured is 3.3.0 (https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-dependencies/build.gradle#L1380). Can we add this fix also to the 3.x version of Rest Assured?

Just FYI Spring removed the charset parameter completely spring-projects/spring-framework#22788 since https://tools.ietf.org/html/rfc7159#section-11 does not define any parameters for application/json.

I see that 3.3.x is not maintained. Can this be cherry-picked to 4.2.x @johanhaleby ?

@marcingrzejszczak I tried backporting it to 3.x but it was really difficult and I have to give up. I'll try 4.2 next.

@marcingrzejszczak I actually think it worked! I'm really surprised myself :)

I.e. version 4.2.1 should be available in maven central now

Thanks @johanhaleby !

Hey @wilkinsona can we bump Boot to use Rest Assured 4.2.1 ?

Yep: https://github.com/spring-projects/spring-boot/issues/22303.


To add left shift operator in Bitwise calculator

I would like to add left shift operator in bitwise calculator

Hi, I want to work on this issue I will start working on it from 3rd April. I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018

Go ahead
Deadline 5 April,2021 11:59 PM IST

is this issue still open? can i work on this issue?
as deadline is over


Add option to save model config to txt file

Add option to export all model config including variable values and RTM settings, date, time and other metadata to text file.

added feature in commit 7a2de17db72957e5c6a3c507125f0a96c3119483


Merged this some days ago but they still show.

What is this PR about?

It is the pull request I made the last time but it still shows on my repo.

OK, but it changes 0 files: https://github.com/flet-dev/flet/pull/307/files

OK, but it changes 0 files: https://github.com/flet-dev/flet/pull/307/files

Yes

And it mentioned the last merge as a change.


Multiple copies of React being loaded because of storybook

Bug or support request summary
I have a repo with two packages - one containing a reusable component library and another containing an app. I am using Storybook to test the reusable component library - it is a devDependency defined in the library package. Everything works fine here, Storybook is able to display the components.
However, when I use this library to build the app, I get the following error from React:
Element ref was specified as a string (container) but no owner was set.
This could happen for one of the following reasons:

1. You may be adding a ref to a functional component
2. You may be adding a ref to a component that was not created inside a component's render method
3. You have multiple copies of React loaded

See https://fb.me/react-refs-must-have-owner for more information.

Essentially the app is picking up a second copy of React because it is a dependency of Storybook. If I remove the Storybook dependency and rebuild the app, it works fine.
Steps to reproduce
I have created a small example that reproduces this issue. Please see here: https://github.com/nareshbhatia/react-multiple-copies-issue. Steps to reproduce are detailed in the README.
Storybook version

@storybook/react 3.4.0

Released as 3.4.1

Hi @Hypnosphi, thanks for the help. I see that you removed the hard dependency on React and changed it to a peer dependency. This does help, but it does not solve the issue. In order to run Storybook, I have to now include React in my library myself. I added it as a devDependency to make sure that it is not picked up by other dependent packages. In spite of this, when I run my app (which depends on this library), it somehow picks up two copies of React and crashes - with the same error.
At this point, it is not a Storybook issue, but a general issue with any tool that depends on React and uses it in a library package. I don't know how to investigate this further - my guess is that it's an issue with either npm or webpack. If you have any suggestions, I can try them. FWIW, I cleaned up my minimal example to reproduce the issue more easily: https://github.com/nareshbhatia/react-multiple-copies-issue.

You're importing 'react' package from your source files, so you need to have it as direct dependency anyway. There's no guarantee that your indirect dependencies end up installing into the root of your node_modules (and are therefore available for import)

Yes I am using Lerna for my monorepo. lerna bootstrap creates the symlinks. No experience with yarn workspaces. Is it a similar concept?
By "hoist react devDependencies", you mean to simply move the React dependency to the root package, correct? I had it set up that way earlier, but the app was still picking up two copies of React.
Your "third package" solution seems to be the most viable, although not a great developer experience. Will give that a shot.

Do you have a guess for the root cause? Is it webpack, npm or something else. The way I have set this up, it should work - at least if everyone is behaving properly!!!

Is it a similar concept?

Yes. You can actually use yarn for bootstrapping and lerna for publishing (that's what we do in storybook main repo). It deduplicates and hoists all the common dependencies automatically
https://yarnpkg.com/lang/en/docs/workspaces/

I had it set up that way earlier, but the app was still picking up two copies of React.

Probably that's because myapp still had its own react dependency


Added documentation of ssh_host_attribute

This feature solves problems as in Issue #300, but I only found it from digging the source.

Covered by #364 already


Connect Ruby on Rails back-end and React front-end

This exercise is going to have you create a React front-end with a Rails back-end and connect them to displaya random message.
In the backend app I was able to implement the following:

[ ] Create a new Rails API app called 'hello-rails-back-end'.
[ ] Initialize your project with Git.
[ ] Make sure that your project has a Postgres database set up.
[ ] Create a table for storing your messages and create 5 different greetings.
[ ] Create an API endpoint that selects a random greeting from your table (you will need a controller with an action and rails route).

And in this app, I was able to implement the following:

[ ] Create a new React app called 'hello-react-front-end'
[ ] Initialize your project with Git.
[ ] Create the App component with react-router.
[ ] Create the Greeting component that will display a greeting. Set it up as a route in your App component.
[ ] Create a store, an action and a reducer that will connect to you API endpoint to get the random greeting.
[ ] Display the random greeting in your Greeting component.

Hi @ridwanediallo,
Thank you for reviewing my PR.


Closing position on futures market help

Hi,
thanks for package first.
Could you please provide example how to close position on futures ?
thank you and appreciate it .

I came to this page after searching for the same problem.
I haven't tested yet, but this is what I found.
https://github.com/sammchardy/python-binance/issues/536

Just create an order in the opposite direction.


Display May be fixed by on discussion lists

Example URL: https://github.com/sindresorhus/got/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

It would be useful to see May be fixed by #... here

This would be lovely but unless this information is exposed via the API the only way I can think of is to fetch each issue’s HTML page separately and parse that information. We can’t fetch 20 pages

If it's not exposed through the API, it's definitely worth emailing<EMAIL_ADDRESS>to suggest it.

I'll email them :fire:

Yo! GitHub did it! There's also the reverse for PRs (i.e. "this will close x issues")

Time to drop our "has pr" label

Great news! :D


Allow custom clients to inject custom launchers into electron builds

Right now, if a custom client wants to provide their own command line launcher, and ship it with the electron builds... they have to, e.g. uncompress, tar update, recompress... We could make this a lot smoother by adding a few lines to the electron builder.

This fix has been integrated into the dev branch. It will be integrated with master in the next stability swap. https://github.com/starpit/kui/pull/17


typo: EXPLAINATION -> EXPLANATION

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3252

PR #3253   👈

This comment was auto-generated by Graphite.


create JSON _metadata.json

Is your feature request related to a problem? Please describe.
create -2023-10-16T103021\S2-L2A_mosaic_2023-10-16T103021_metadata.json based on properties  from exolab workflow
Describe the solution you'd like
*_metadata.json  with

[x] Product,Item,
[x] Asset,
[x] DateItemGeneration
[x] ProcessorHashLink
[x] ProcessorReleaseVersion
[x] state
[x] description
[x] creation_timestamp_ms
[x] update_timestamp_ms
[x] start_timestamp_ms
[x] task_type,destination_uris
[x] attempt
[x] batch_eecu_usage_seconds
[x] id
[x] name
[ ]
[x] system:index
[x] PROCESSING_BASELINE
[x] SENSING_ORBIT_NUMBER
[x] SPACECRAFT_NAME
[x] date
[x] index_list
[x] percentData
[x] scene_count
[x] system:band_names
[x] system:bands,system:footprint
[x] system:time_end
[x] system:time_start

JSON is proposed by @rdataflow

solved with https://github.com/swisstopo/topo-satromo/commit/7104ee72567e38c453a10221287c4d09d3bc13bd


Release cobigen-tsplugin-v7.1.0

This issue has been automatically created. It serves as a container for all release related commits

Automatically processed.
The decisions taken by the developer and the context of the decisions throughout the script:

User confirmed that tests are running on CI and the build is not failing.


Final Edits and Comparison with Cycamore

This PR got a bit bigger than I intended, so apologizes in advance.
This PR includes:

updates to the README on how to install dependencies and define a prototype using this archetype
remove files that aren't needed anymore from the examples directory
Update the archetype file (openmcyclus/DepleteReactor.py) include:

Updating datatypes, doc strings, and defaults for different state variables
Adding new state variables (or moving variables to be state variables) to match better with the Cycamore Reactor archetype
Adding capacities for the ResBufMaterialInvs
Request tracked materials
Defining requests to be exclusive (must be met in full, no partial fuel assemblies)
Remove recording information about the discharged assemblies to the database (no longer needed with the requested material being tracked)
Reflect changes to the Depletion class
Add function to record the position of the archetype to the database

Updates to the Depletion (openmcyclus/depletion.py) class include:

Reading in only materials instead of an entire model
Passing the updated materials from update_materials instead of writing to the materials.xml file
Update the run_depletion method to better match what is done in DepleteReactor
Add conversion of atom fraction to weight fraction to get_spent_comps()

Update the unit tests to reflect the changes in openmcyclus/depletion.py
Add a directory for the comparison with Cycamore:

comparison/Comparison-results.ipynb to hold the results of the comparison
comparison/OpenMC_model.ipynb to show how the cross sections were generated for OpenMCyclus, and the spent fuel compositions that were used in Cycamore
comparison/cycamore_recycle.xml: Cyclus input file using the Cycamore Reactor archetype
comparison/openmcyclus_recycle.xml: Cyclus input file using the OpenMCyclus DepleteReactor archetype

The CI is still broken, partly because of Issue #12. This will be investigated and updated in a future PR. The unit tests all pass locally. This PR should conclude the primary development of OpenMCyclus::DepleteReactor!

@yardasol Do you have any other comments or suggested changes for this PR?

Thanks for the feedback @yardasol. I think I have addressed your comments now (I must have missed a few from your last review, my apologies).


Update row aftersave()

        protected override void AfterSave()
        {
            base.AfterSave();

            new SqlUpdate("Appointment")
                .Set("Prescribed", true)
                .Where("Id=="+Request.Entity.AppointmentId) ;
        }

i want to update after save, is above right way?, as its not working

new SqlUpdate("Appointment") // prefer fld.TableName
   .Set("Prescribed", true) // prefer fld.Prescribed
   .Where(new Criteria("Id") == Request.Entity.AppointmentId) // prefer fld.Id == Request.Entity.AppointmentID
   .Execute(uow.Connection, ExpectedRows.ZeroOrOne);

here uow is not accessible

ohh find your connection or unit of work in current object. its already set and ready for use.

Yes seen its been there but how can i access it in aftersave()

use intellisense

Sorry but again i have error

Look at diff .Where(new Criteria("Id") == Request.Entity.AppointmentId)

Ohh and use Request.Entity.AppointmentId.Value
criteria doesnt accept nullable values.

.Where(new Criteria("Id") == Request.Entity.AppointmentId.Value)
Yes this worked and also following works fine
.Where(new Criteria("Id") == new Criteria(Request.Entity.AppointmentId.ToString()))
@VictorTomaili thankyou for your precious time


RENAME / DROP DATABASE update

You cannot rename / drop a database if it is set as the current database.
Closes #3090.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/888e105ed561725eee1932b7c7c3b12ae63169b2/

TFTRs @rmloveland!

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/579bf3f9be0742d3cad53d49250fba7b6b138cd6/


Determine if scaled image is oriented

Type of issue

[ ] Bug report
[x] Feature request

Uploader type

[ ] Traditional
[ ] S3
[x] Azure

Note: Support requests cannot be accepted due to lack of time.

Feature Request
Feature request details
It would be really helpful if we have an API to find out if a scaled image is oriented.  We can determine this using other third party libraries but since fineuploader is already fetching the orientation data from EXIF, we believe using additional libraries would cause unnecessary overhead.
Thanks

Fine Uploader will orient any image with EXIF data during scaling by default, so there should be no need to use another library to do this.


Automated cherry pick of #11219: fix(host): avoid delete removed disk failed

Cherry pick of #11219 on release/3.5.
#11219: fix(host): avoid delete removed disk failed

Codecov Report

Merging #11222 (3a65028) into release/3.5 (6a15e02) will increase coverage by 1.76%.
The diff coverage is 0.93%.

@@               Coverage Diff               @@
##           release/3.5   #11222      +/-   ##
===============================================
+ Coverage         5.98%    7.74%   +1.76%
===============================================
  Files              796      249     -547
  Lines           125693    34263   -91430
===============================================
- Hits              7522     2654    -4868
+ Misses          117504    31345   -86159
+ Partials           667      264     -403

Flag
Coverage Δ

aFlag
7.74% <0.93%> (+1.76%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/baremetal/cronjobs.go
0.00% <0.00%> (ø)

pkg/baremetal/manager.go
0.50% <0.00%> (-0.01%)
:arrow_down:

pkg/baremetal/utils/ipmitool/ipmitool.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/jointbase.go
0.00% <ø> (ø)

pkg/cloudcommon/db/metadata.go
4.96% <0.00%> (-0.08%)
:arrow_down:

pkg/cloudcommon/db/opslog.go
1.36% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudcommon/db/rbac.go
0.75% <0.00%> (-0.03%)
:arrow_down:

pkg/cloudcommon/db/sharablebase.go
6.01% <0.00%> (-0.06%)
:arrow_down:

... and 492 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb9a97...3a65028. Read the comment docs.


Upstream main sync 03/21

Rebases the latest commits on main

Not really sure if we should be doing PRs for this or just pushing the rebases?


✨ Added Support for backgroundImage property for every primitive type

Far too long PR for what it was intended but I will try to go over parts of the code to explain what changes I made and why.
TL;DL of this is, Coil doesnt expose its core modifier, so to apply the backgroundImage property not only for verticalStack but for other primitives types I had to go over some refactoring and ended up doing some cleanup too.
there was some code duplication between primitives as well, I got this opportunity to make it cleaner too.

I will trigger a android-example build from this branch before merging into main, and I will test it some more and ask Ben for some help with testing.
I agree that at this point it is risky to make this huge amount of change, it really took some time to make that because I was really trying to avoid any major refactory, but since applying the backgroundImage as a modifier wasnt possible, that was the path I had to take for this one


App Release action is failing

Bug Report 🐛

Expected Behavior
App release action should build the apk and create a new release.
Current Behavior
The action is failing in installing dependencies stage.
Possible Solution
Update the App release workflow to use the current Flutter version.
Steps to Reproduce
The issue can be reproduced when any new commit is pushed to master branch.

@himanshusharma89 There hasn't been any update on this issue. Anyone else want to take up this issue?


python3Packages.hole: 0.6.0 -> 0.7.0

Motivation for this change
Update to latest upstream release 0.7.0
Change log: https://github.com/home-assistant-ecosystem/python-hole/releases/tag/0.7.0
Fix build (https://hydra.nixos.org/build/159232898)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147109 run on x86_64-linux 1

2 packages built:

python38Packages.hole
python39Packages.hole


Production Mode?

Its default Test Mode how to make it Production Mode?

what do u mean ?

when i testing its says testing payment . i want it live payment

yeah just pass parameter (desc title etc)  according to your need

its shows testing. i need actual transaction

https://github.com/GJJ2019/easy_upi_payment/blob/73fa84850e0c4bebd26016e8356dd03b21795422/example/lib/app/features/main/view/main_view.dart#L241

description is mendatory?


[Workspace Feeds] [External] Create a new Expensify Card workspace page - empty state

Part of the Workspace feeds project.
Implement the following part of the design doc.
@koko57 @VickyStash @allgandalf @DylanDylann

I will take over this one

Hi, I'm Nicolay from Callstack - expert agency - and I would like to work on this issue.