Streamline functional/tests exec by doing a pre-check for a running ipfs daemon

If no ipfs daemon is present/running, the tox test runs/hangs for a lengthy period of time when entering the functional/tests portion.  It might be a more streamlined experience to perform a pre-check on the ipfs daemon state and fail fast rather than running/hanging.

You are right about feedback being a bit low atm when ipfs deamon isn't running. I've implemented a tiny decorator that should fix this (locally), but I'm not sure if I should fail or skip those tests. Ideally those tests should be skipped but a big warnings messages should be shown instead; something that apparently isn't possible. :disappointed:
What do you think? Skip them or fail them? Do you know of any way to show a message for a skipped test?

I think my feeling is that there should be a test for having the daemon running in the first place. If there's no daemon, that fails. Then the rest of the functional tests should be skipped. That way you get the feedback that the daemon isn't running, but don't have to wait for all of the tests to fail. Thoughts?

I had similar thoughts on this, so I'l just do as you suggested @whereswaldon.


scientific notation negative numbers

Negative numbers are coming with scientific notation for example this number:
-229.196852 will be shown as 3.4028236692093845e+32 whenever query by SDK,
Is there any workaround?

It look that it's a bug in apache-arrow library which should be fixed in v13 (apache/arrow#35067). Meanwhile, I'll try to find some workaround on our end

@kravets-levko is the problem persists in ODBC driver as well?

@amirjalali1 TBH I don't know, but it looks that this problem is related to this driver only

Hi @kravets-levko any update on the issue, is this still open or in triage?

Hi @vishalsingh2972 (and others in this thread). apache-arrow@13 was released few days ago, so I'm going to check if the issue is fixed there. Will keep you posted. Sorry for the delay

Upgrading to<EMAIL_ADDRESS>fixed this issue. The fix will become available with v1.5.0 release which is going to be published in few days


Asynchronous loading of jQuery and jQuery UI

jQuery and jQuery UI can be pretty large and a burden to load on every page, if Sortable is only being used on a single page. I have a solution that loads the libraries asynchronously, only when a sortable directive is encountered. Would it be of interest to submit a PR for this feature?

I would be very interested to take a look at an example pen and possibly
add a reference into README.
What do you mean with "every page"?
If ui-sortable is defined as a module of an angular app, then jquery &
jquery-ui should be already loaded. To be precise, jquery should be loaded
before angular itself (except if you are manually patching angular.element).
Since ui-sortable js file is loaded after angular, how this solution works?
On Sat, May 16, 2015, 18:31 Kristiyan Kostadinov<EMAIL_ADDRESS>wrote:

jQuery and jQuery UI can be pretty large and a burden to load on every
page, if Sortable is only being used on a single page. I have a solution
that loads the libraries asynchronously, only when a sortable directive is
encountered. Would it be of interest to submit a PR for this feature?
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/ui-sortable/issues/364.

It loads jQuery and jQuery UI when the link function of sortable is executed. It doesn't seem to be a problem that jQuery is loaded after Angular has been bootstrapped (albeit I'm not sure if Angular uses it at this point), the Sortable works fine and it hasn't given me any trouble (I've been using this method for about a year now). Keep in mind that no other parts of my app depend on jQuery and I don't know what would happen if they did. Here's the monkey patch I did to defer the Sortable directive:
angular.module('ui.sortable').config(['$provide', function($provide) {
    $provide.decorator('uiSortableDirective', ['$delegate', '$window', 'utilities', function($delegate, $window, utilities){
        var directive = $delegate[0];
        var link = directive.link;

        directive.compile = function(){
            return function(){
                var args = arguments;
                var dis = this;

                utilities.loadDependency('js/lib/jquery-1.9.0.min.js').then(function(){
                    utilities.loadDependency('js/lib/jquery-ui.min.js').then(function(){
                        angular.element.fn = angular.element.fn || $window.jQuery.fn;
                        angular.element.fn.jquery = angular.element.fn.jquery || $window.jQuery;

                        // 0 is the scope, 1 is the element
                        args[1] = $(args[1]);

                        link.apply(dis, args);
                    });
                });
            };
        };

        return $delegate;
    }]);
}]);

If necessary I can include the utilities service that loads the script, but it basically just inserts a script tag, binds a load listener and returns a promise that gets resolved when load is fired.

I was thinking of adding an extra property like ui-module-link to the
options object, that would accept a callback, that could optionally return
a thenable.
The decorators seem to work fine :+1: though.
It would be great if you could fork one of the codepens found in README and
apply your use case. I would then be more than happy to review and merge a
PR adding this example right next the requirejs example link.
On Sat, May 16, 2015, 20:39 Kristiyan Kostadinov<EMAIL_ADDRESS>wrote:

It loads jQuery and jQuery UI when the link function of sortable is
executed. It doesn't seem to be a problem that jQuery is loaded after
Angular has been bootstrapped (albeit I'm not sure if Angular uses it at
this point), the Sortable works fine and it hasn't given me any trouble
(I've been using this method for about a year now). Keep in mind that no
other parts of my app depend on jQuery and I don't know what would happen
if they did. Here's the monkey patch I did to defer the Sortable directive:
angular.module('ui.sortable').config(['$provide', function($provide) {
$provide.decorator('uiSortableDirective', ['$delegate', '$window', 'utilities', function($delegate, $window, utilities){
var directive = $delegate[0];
var link = directive.link;
    directive.compile = function(){
        return function(){
            var args = arguments;
            var dis = this;

            utilities.loadDependency('js/lib/jquery-1.9.0.min.js').then(function(){
                utilities.loadDependency('js/lib/jquery-ui.min.js').then(function(){
                    angular.element.fn = angular.element.fn || $window.jQuery.fn;
                    angular.element.fn.jquery = angular.element.fn.jquery || $window.jQuery;

                    // 0 is the scope, 1 is the element
                    args[1] = $(args[1]);

                    link.apply(dis, args);
                });
            });
        };
    };

    return $delegate;
}]);

}]);
If necessary I can include the utilities service that loads the script,
but it basically just inserts a script tag, binds a load listener and
returns a promise that gets resolved when load is fired.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/ui-sortable/issues/364#issuecomment-102658257
.

Sure thing. I was thinking that it would be a cool feature to add to the module itself, although it could be considered an edge case.

Any feedback on this?
Have you been able to mock an example to add in README?

Ah sorry, I've been busy recently. I've added it to my list.

@thgreasi I made it into an addon so its a little bit more reusable. Here's a link to the demo, if you want to include it in the examples: http://crisbeto.github.io/angular-ui-sortable-loader/

:+1: will add a link in README as soon as I'm home.


adjust multiple notes to the hierarchy note using one command

now people need to run adjust hierarchy note command every time to insert breadcrumb into hierarchy note. The command should be add multiple and delete multiple by allow users to select multiple HNitem and do batch operation.

This can be implemented in AHN and Duckview


Overlapping of Flow lines

Is there a way to separate the overlapping flow lines which are the case as shown in the  above case?
The flow line from 00001E(no) to 000036 is overlapping with the lines from  000026(no) which is further overlapping with the line from 00003A(no)

https://github.com/adrai/flowchart.js/pull/191 addresses the y axis, this seems to need the x axis fixed, fyi.


added /me message support

This adds the support for /me messages so the bot can ponder things to itself in a channel.
For instance, this will create a /me message:
@listen_to('Are you ready?', re.IGNORECASE)
def ready(message):
    message.send_webapi('thinks he is ready',me_message=True)

Need to make some slight changes.


fix: support baseFlags on SfCommand

What does this PR do?
Fix compilation errors when SfCommand has baseFlags. Can be merged independently of https://github.com/salesforcecli/sf-plugins-core/pull/519
What issues does this PR fix or reference?

Can you do your change against https://github.com/salesforcecli/plugin-data/pull/843 probably [here]
(https://github.com/salesforcecli/plugin-data/pull/843/files#diff-ee69f30e4a3ba9ed75d920f9ff0387e1b64fe82e6f412bfb4c0ad078c792c78cR45)


too slow at plotting polygons

See the next examples [in a M1 Mac]:
using GeoMakie, GLMakie
using Downloads: download
using GeoMakie.GeoJSON

countries_file = download("https://datahub.io/core/geo-countries/r/countries.geojson")
countries = GeoJSON.read(read(countries_file, String))

function slow()
    cmap = [:white, :black]
    fig = Figure()
    ax = Axis(fig[1,1])
    n = length(countries)
    hm = poly!(ax, countries; color= rand(0:1,n),
        colormap = cgrad(cmap, categorical=true),
        strokecolor = :black, strokewidth = 0.5,
    )
    Colorbar(fig[1, 2];
        colormap = cgrad(cmap, categorical=true),
        colorrange= (0,1)) # this is also kinda not ideal, the colormap from hm should just work.
    fig
end
@time slow() # second run

25.778192 seconds

and using the GeoAxis
function with_geo()
    cmap = [:white, :black]
    fig = Figure()
    ax = GeoAxis(fig[1,1])
    n = length(countries)
    hm = poly!(ax, countries; color= rand(0:1,n),
        colormap = cgrad(cmap, categorical=true),
        strokecolor = :black, strokewidth = 0.5,
    )
    Colorbar(fig[1, 2];
        colormap = cgrad(cmap, categorical=true),
        colorrange= (0,1)) # this is also kinda not ideal, the colormap from hm should work.
    fig
end

@time with_geo() # second run

25.894986 seconds

Yeah, I've had that problem as well.  I think CairoMakie might be lowering this to mesh, which causes both the insane file sizes and this issue.  Am looking into it.

This is with Glmakie... I think @rafaqz is looking into it right now since it likely is a geo interface issue...

Could be...the issue is that a lot of geo stuff is in multipolygons, and we only specialize for GeometryBasics polygons.  I'll push a patch up for CairoMakie with a fix on that end.

If this is slow in GLMakie, has anyone profiled to see where most time is spent?

We need to profile a single multiploygon, this MWE is much too big to profile. I got side tracked trying earlier.

Ok for me this alone is terrible:
@time multipoly = GeoMakie.to_multipoly.(GeoMakie.geo2basic(countries));
#  41.531221 seconds (36.89 M allocations: 2.336 GiB, 47.79% gc time)

Then creating the figure is actually relatively fast:
function faster(countries)
    cmap = [:white, :black]
    fig = Figure()
    ax = Axis(fig[1,1])
    n = length(countries)
    hm = poly!(ax, countries; color= rand(0:1,n),
        colormap = cgrad(cmap, categorical=true),
        strokecolor = :black, strokewidth = 0.5,
    )
    Colorbar(fig[1, 2];
        colormap = cgrad(cmap, categorical=true),
        colorrange= (0,1)) # this is also kinda not ideal, the colormap from hm should just work.
    fig
end

@time fig = faster(multipoly);
# 1.110449 seconds (146.72 k allocations: 99.732 MiB, 66.78% gc time)

And displaying is again quite slow:
@time display(fig)
# 7.980616 seconds (17.69 M allocations: 893.942 MiB, 94.68% gc time)

Where exactly it spends its time I'm not sure, because @profview didn't really show anything usable. But if it's 95% gc time, that's not good :D But should be fixable.

The problem with this:
@time multipoly = GeoMakie.to_multipoly.(GeoMakie.geo2basic(countries));
#  41.531221 seconds (36.89 M allocations: 2.336 GiB, 47.79% gc time)

boils down to the fact that we have JSON data, and every point we extract gets its own little array because nothing in the pipeline seems to force known-size types like StaticArrays.

Totally, I'll look at forcing it to a Tuple

If we use written out structs in GeoJSON the above conversion GeoMakie.geo2basic(countries) would take:
julia> @time geo2basic(JSON3.read(read(fn), GeoJSON2.GeoJSON));
  0.167426 seconds (1.44 M allocations: 136.101 MiB)

This should be fixed in the latest Makie.

@evetion also has a PR to make GeoJSON.jl faster: https://github.com/JuliaGeo/GeoJSON.jl/pull/63


Button Component in Slushy

Button Component Specification for Slushy
The Button component is a fundamental part of the Slushy component catalog. It must adhere to the following acceptance criteria:
1. Size Variants
The button must support the following size options, with appropriate padding and font sizes:

small
medium
large
xlarge

2. Text Color
The text color depends on the button's background:

Lighter Variants (e.g., primary, info): Text color should be white (--white).
Darker Variants (e.g., secondary, success): Text color should be black (--black).

3. Background Colors
The background color varies by variant:

Primary: --blue-500
Secondary: --grey-200
Danger: --red-500
Success: --green-500
Warning: --yellow-500
Info: --blue-300
Disabled: --grey-300

4. Borders
The border color follows the background, using a slightly darker shade:

Primary: --blue-600
Secondary: --grey-400
Danger: --red-600
Success: --green-600
Warning: --yellow-600
Info: --blue-400
Disabled: --grey-400

5. Disabled State
A disabled button must:

Have a background color of --grey-300.
Use --grey-500 for the text color.
Display a cursor: not-allowed.

6. Hover and Active States

Hover: Slightly darken the background color to indicate interactivity.

Example: primary hover background should be --blue-400.

Active: Adjust the background to a slightly darker shade to show the button is pressed.

Example: primary active background should be --blue-600.

7. Documenting Component States
The component must include detailed documentation of its different states using varying inputs. This includes:

Variants: primary, secondary, danger, success, warning, info, and disabled.
Sizes: small, medium, large, and xlarge.
States: Default, hover, active, and disabled.
Examples:

A primary button in the small size in its default state.
A danger button in the large size in both hover and active states.
A success button in the medium size in the disabled state.

Each example should display the button’s appearance and behavior, clearly identifying the state and input combination.
8. Button Text
The button's text must be passed as children, not as a prop. Example:
<Button variant="danger" size="medium">Are you sure?</Button>

9. Event Binding
The component must accept an onClick prop for event handling. Example:
<Button variant="primary" size="large" onClick={handleClick}>Submit</Button>

Creating the Button Component
To create the component in an Nx workspace, run:
nx g @nx/react:component libs/slushy/src/lib/components/button/Button.tsx

During setup, answer:

Should this component be exported in the project? true

After generation:

Remove the .module.scss and .spec.tsx files.

To create the component’s story, use:
nx g @nx/react:component-story

Options for the generator:

Path of the component: lib/components/button/Button.tsx

Summary

Color Variants: primary, secondary, danger, warning, info, success, disabled.
Size Variants: small, medium, large, xlarge.
Disabled State: Unique styling (cursor: not-allowed).
States Documentation: Includes visual and behavioral examples of all state and input combinations.
Children: Button text passed as children.
Events: Supports onClick for event handling.

Are we using global scss for components?


password support

redisearch-py should support database passwords like redis-py does.
Optimally, it should also support the same connection pool and ssl settings that can be passed to the redis-py Redis object.

Hello @kerneljake,
The redisearch-py client supports the provisioning of an arbitrary connection object (pooled or otherwise) via the conn initialization argument, per the class' __init__ signature:
def __init__(self, index_name, host='localhost', port=6379, conn=None)

🙂

✅


Put together SDK bundles on the CI

I experimented a bit with getting executables linked with the static stdlib also.

Dumb question – how will the SDK bundle (if it’s a Swift SDK?) know where the NDK is installed?

I'm bundling the NDK sysroot with this SDK bundle, so you will no longer have to download the NDK separately. 😃 That cross-compiles fine for me locally on linux, but I will run it through the CI here to make sure it works well before releasing.


Feature request: NtLoadDriver support

Motivation
Hello,
I know you are not porting low level NTAPI to Rust in this project, but IMO this one is a bit special. The NtLoadDriver call is easy to call from C/C++, but is really hard not to mess in Rust due to the pointer to UNICODE_STRING as parameter.
Source: https://docs.rs/ntapi/latest/ntapi/ntioapi/fn.NtLoadDriver.html
Could you consider supporting this very specific NTAPI function in windows-rs ?
All the best !
Drawbacks
Main drawback:

If you port this, you will have to maintain an undocumented NTAPI function

Rationale and alternatives

Support another way to easily load drivers in Windows using Rust

Additional context
No response

shouldn't NT APIs availabilities requests be placed to the wdkmetadata repo?

shouldn't NT APIs availabilities requests be placed to the wdkmetadata repo?

Hello,
Is it a legitimate interrogation or should I open the issue on wdkmetadata already ?
BR,
Nariod

Is it a legitimate interrogation or should I open the issue on wdkmetadata already ?

Both. I will suggest to wait for the repo owners. They can transfer it to the wdkmetadata repo in case that's appropriate.

Will transfer this request.


create statements according to CMIF 2 specification

Begin including CMIF version 2 features by allowing the <note> element? Include an XPath in the configuration that evaluates to the language code?

new scope of issue:
How to compile CMIF v2 statements in <ref> elements from diverse source TEI documents. Can this be done with XPath configurations?


Enforce Conventional Commits

The following is commented away in our README but we never implemented this feature. It is a great way to standardize commit messages as well as to produce a great standardized input for automation tools, which for example, can automatically produce change logs for every deployment.

We automatically enforce the conventional commits format for commit messages. This can be frustrating for junior developers, but I promise that you'll quickly get used to it! -->

The Conventional Commits specification is a lightweight convention on top of commit messages. It provides an easy set of rules for creating an explicit commit history; which makes it easier to write automated tools on top of. -->

hey, you can assign this task to me
as far as I understand every commit message should be checked if it is written in "conventional commit style"

This bounty is for enforcing it with a precommit hook

@pavlovcik
wallet: 0x336C033842FA316d470e820c81b742e62A0765DC
pls also check this weird thing https://github.com/ubiquity/ubiquity-dollar/pull/378#issuecomment-1352988358

@pavlovcik
wallet: 0x336C033842FA316d470e820c81b742e62A0765DC
pls also check this weird thing #378 (comment)

@pavlovcik The PR is merged, the issue is closed, but there is a question regarding "this weird thing ^"
Should I perform the payment?

There's a small issue with the last commit where lint-staged should be enabled (@rndquu please fix) then we can release payment.

Issue is resolved!

0x336C033842FA316d470e820c81b742e62A0765DC

https://etherscan.io/tx/0x93fd0fbe4e05ff9c8c5984c818c755b4e379bbd55aa953dff9147347796a5ca9


Docs: Formatting tweaks and fixes

This tries to apply a more consistent style to the docs:

Use more of the Sphinx directives for things like files
Better cross-linking of functions to each other
I changed the highlight color for code items to a shade of green rather than the default pink
I fixed up some paragraphs which were outdated or missing information

Preview: https://brianward.dev/bridgestan/latest/index.html


scheduler doesn't respect queue_name_prefix

ActiveJob has a config:
config.active_job.queue_name_prefix = Rails.env

I think scheduler should add prefix automatically, probably here:
https://github.com/resque/resque-scheduler/blob/master/lib/resque/scheduler.rb#L237

@Extrapolator214 For the location this queues or for the Redis keys?

Sorry, it was a long time ago, I don't have access to that project anymore. As far as I remember, the problem was in Redis keys. Basically we had Redis on the server and wanted to use it for 2 separate environments (not the best idea, but cost effective in the beginning of a project), so Redis keys were the same and resque jobs from different environments read the same queue.


ModalRoute Rebuilds Transition Widgets Every Frame

Steps to reproduce

Run the code sample
Tap the pageBuilder button
Tap the transitionsBuilder button

Expected results
pageBuilder and transitionsBuilder should each execute once.
Actual results
pageBuilder executes 1 time, while transitionsBuilder executes 38 times.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: HomeScreen(),
    );
  }
}

class HomeScreen extends StatefulWidget {
  const HomeScreen({super.key});

  @override
  State<HomeScreen> createState() => _HomeScreenState();
}

class _HomeScreenState extends State<HomeScreen> {
  var pageBuilderCount = 0;
  var transitionsBuilderCount = 0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Home Screen'),
      ),
      body: Center(
        child: Column(
          children: [
            const Spacer(flex: 3),
            Text('$pageBuilderCount builds'),
            ElevatedButton(
              style: ButtonStyle(
                backgroundColor: WidgetStateProperty.all(Colors.blue),
                foregroundColor: const WidgetStatePropertyAll(Colors.white),
              ),
              onPressed: () {
                Navigator.push(
                  context,
                  PageRouteBuilder(
                    pageBuilder: (context, animation, secondaryAnimation) {
                      ++pageBuilderCount;
                      WidgetsBinding.instance.addPostFrameCallback((_) => setState(() {}));
                      return FadeTransition(
                        opacity: animation,
                        child: Scaffold(
                          backgroundColor: Colors.blue,
                          appBar: AppBar(
                            title: const Text('pageBuilder'),
                          ),
                          body: const SizedBox(),
                        ),
                      );
                    },
                  ),
                );
              },
              child: const Text('pageBuilder'),
            ),
            const Spacer(),
            Text('$transitionsBuilderCount builds'),
            ElevatedButton(
              style: ButtonStyle(
                backgroundColor: WidgetStateProperty.all(Colors.red),
                foregroundColor: const WidgetStatePropertyAll(Colors.white),
              ),
              onPressed: () {
                Navigator.push(
                  context,
                  PageRouteBuilder(
                    pageBuilder: (context, animation, secondaryAnimation) {
                      return Scaffold(
                        backgroundColor: Colors.red,
                        appBar: AppBar(
                          title: const Text('transitionsBuilder'),
                        ),
                        body: const SizedBox(),
                      );
                    },
                    transitionsBuilder: (context, animation, secondaryAnimation, child) {
                      ++transitionsBuilderCount;
                      WidgetsBinding.instance.addPostFrameCallback((_) => setState(() {}));
                      return FadeTransition(
                        opacity: animation,
                        child: child,
                      );
                    },
                  ),
                );
              },
              child: const Text('transitionsBuilder'),
            ),
            const Spacer(flex: 3),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/1063446/286a8d5d-80b9-4ec1-9986-0724557e15e8

Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.0, on macOS 14.5 23F79 darwin-arm64, locale en-US)
    • Flutter version 3.22.0 on channel stable at /opt/homebrew/Caskroom/flutter/3.22.0/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5dcb86f68f (13 days ago), 2024-05-09 07:39:20 -0500
    • Engine revision f6344b75dc
    • Dart version 3.4.0
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/user/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile)     • emulator-5554                        • android-arm64  • Android 14 (API 34) (emulator)
    • iPhone 15 Pro Max (mobile)      • 9CF6C1A2-E96A-4D3D-B878-1392E4F72A14 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript • Google Chrome 124.0.6367.210

[✓] Network resources
    • All expected network resources are available.

• No issues found!

ModalRoute builds a _ModalScope which builds a ListenableBuilder which calls buildTransitions.
Source:
                        child: ListenableBuilder(
                          listenable: _listenable, // immutable
                          builder: (BuildContext context, Widget? child) {
                            return widget.route.buildTransitions(
                              context,
                              widget.route.animation!,
                              widget.route.secondaryAnimation!,

ListenableBuilder listens to a merger of animation and secondaryAnimation.
Source:
    final List<Listenable> animations = <Listenable>[
      if (widget.route.animation != null) widget.route.animation!,
      if (widget.route.secondaryAnimation != null) widget.route.secondaryAnimation!,
    ];
    _listenable = Listenable.merge(animations);

This means ListenableBuilder calls buildTransitions on every frame of the transition.
The documentation says buildTransitions is called "each time the Route's state changes while it is visible" but does not mention that it is called unconditionally for every transition frame.
Source:
  /// The [buildTransitions] method, in contrast to [buildPage], is called each
  /// time the [Route]'s state changes while it is visible (e.g. if the value of
  /// [canPop] changes on the active route).

It also does not mention the performance implications of using buildTransitions over buildPage when it recommends that users place their transition widgets there.
The Material widget layer follows this recommendation when it ties MaterialPageRoute into the app theme via MaterialRouteTransitionMixin.
Source:
  @override
  Widget buildTransitions(BuildContext context, Animation<double> animation, Animation<double> secondaryAnimation, Widget child) {
    final PageTransitionsTheme theme = Theme.of(context).pageTransitionsTheme;
    return theme.buildTransitions<T>(this, context, animation, secondaryAnimation, child);
  }

In doing so, it causes every page transition in a MaterialApp to incur the additional cost of Theme.of(context) every frame.
Hash table lookups and widget builds are cheap, but is there a reason for the framework to incur these costs? Especially during a transition when it must produce frames as quickly as possible?
If there is a reason, perhaps the framework could document this behavior and recommend to developers that they place their transition widgets in buildPage whenever those widgets will not change for the duration of the transition.
On the other hand, could this behavior be a bug?

Thanks for the report. Reproduced the same result as above.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.22.1, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.22.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (11 hours ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 125.0.6422.76

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.22.0-44.0.pre.10, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.22.0-44.0.pre.10 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fe0932f2c0 (76 minutes ago), 2024-05-22 22:19:25 -0400
    • Engine revision b8b82454e3
    • Dart version 3.5.0 (build 3.5.0-178.0.dev)
    • DevTools version 2.36.0-dev.10
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 125.0.6422.76

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

The rebuilding of transition widgets every frame is mentioned in the Navigator documentation:
Source:
/// The page route is built in two parts, the "page" and the
/// "transitions". The page becomes a descendant of the child passed to
/// the `transitionsBuilder` function. Typically the page is only built once,
/// because it doesn't depend on its animation parameters (elided with `_`
/// and `__` in this example). The transition is built on every frame
/// for its duration.

If this is intentional, I'm curious to know the reason. Transition widgets do not need to rebuild because they listen to their animations and rebuild themselves.
Is the idea to support widgets that do not subclass AnimatedWidget? Such widgets could reconfigure themselves every frame within ModalRoute.buildTransitions based on the values of animation and secondaryAnimation. It is the case that _ModalScopeState listens to the animations and provides an implicit AnimatedBuilder.


Release 0.4.0

Exposed connection object in Client #24
Fixed errors and warning with latest Dart SDK
Removed deprecated linter rules
Fixed coverage configuration
Updated logging to 0.11.4
Updated test to 1.14.2
Updated uuid to 2.0.4

Pull Request Test Coverage Report for Build 53

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
42 unchanged lines in 11 files lost coverage.
Overall coverage decreased (-3.0%) to 86.332%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/client/client.dart
1
2
50.0%

Files with Coverage Reduction
New Missed Lines
%

lib/src/command/command.dart
1
96.77%

lib/src/commands/list.dart
1
92.86%

lib/src/commands/scripting.dart
1
66.67%

lib/src/protocol/reply.dart
1
95.45%

lib/src/commands/key.dart
2
84.62%

lib/src/exception.dart
2
60.0%

lib/src/commands/sortedset.dart
3
74.36%

lib/src/commands/cluster.dart
5
88.64%

lib/src/commands/geo.dart
5
90.57%

lib/src/commands/string.dart
6
68.42%

Totals

Change from base Build 48:
-3.0%

Covered Lines:
1238

Relevant Lines:
1434

💛  - Coveralls


2.0.0

[x] Move to standardrb and run standardrb --fix
[ ] Rework Test suite
[ ] Ensure only compatible with maintained Ruby versions
[x] Remove JWT client

I'm going to need to use parts of this very soon, and would like to help get this to a stable state. However, the test suite logs have since expired, and could use some guidance on what's left to implement :)


Possible to add deadzone/antideadzone settings per-stick or axis for dinput/8?

XInputPlus is overkill for simply setting deadzones especially when the native gamepad support of a game works fine as is, plus it's predicated on having a real or virtual xinput compatible pad. There are a few older games out there that have absolutely or nearly no deadzone (Daytona USA Deluxe, Crazy Taxi 3, Starsky & Hutch for example) and no way to set it in-game, which results in twitchy controls on controllers that have no or minimal firmware or driver deadzone.
I currently use https://github.com/d-b/gurumin-pad, but it has no configuration whatsoever. I figured out the % values in hex and made multiple DLLs for different percents, but this is a really hacky solution.
I've scoured github for weird wrappers and the like but I haven't found a simple drop in dinput wrapper that can do this with settings. It's all overkill, virtual gamepad rerouting or other systemwide things.
ThirteenAG's NFS widescreen fixes do include a deadzone-setting-by-percentage, if the implementation can be worked with.

Gurming pad has sources though.
Can't you just try to set a different PROJECT_DEADZONE value?

Of course. Didn't bother setting up a compile environment though just for
that when I could set the project deadzone value in hex. It'd just be nicer
to have more fine-grained control and have it built in dxwrapper. It's
already able to do a lot for 3D and a decent bit for sound. dinputto8 is a
godsend, though. My personal solution is usually a 15-20% deadzone
gurumin-pad and if the game is dinput I use dinputto8 to make it work, and
the vast majority of games work with this.
It'd be much better to fork it over into a generic deadzone wrapper with
ini configuration, but that's beyond me. My brother could probably do it,
but he's not familiar with Windows APIs though.
I don't think it's beyond the scope of this project, but that isn't up to
me to call. I do think if something can be done better, it's worth doing,
though. There's so many amazing graphics wrappers these days but not near
as much for input, and what's out there has meaningful ways to be improved
or iterated on.
On Wed, Nov 25, 2020 at 6:59 AM mirh<EMAIL_ADDRESS>wrote:

Gurming pad has sources though.
Can't you just try to set a different PROJECT_DEADZONE value?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/elishacloud/dxwrapper/issues/97#issuecomment-733691444,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFJNBGVT24XRIWMK6QRLITSRT5R7ANCNFSM4UCKH7CA
.

Thanks for the suggestion!  However, I don't have any plans to do this.  Closing this issue.


Added important note as per CSS feedback

I will take this to live via my PR. Won't go live until 10/1.


Updating README.md, CONTRIBUTING.md, SECURITY.md

I am closing this PR as it has been fixed by other PRs


[ffigen] Add compiler option -Wno-nullability-completeness by default

Closes: https://github.com/dart-lang/native/issues/1073

coverage: 93.734% (+0.001%) from 93.733%
when pulling 09f581c3b2cf0a8154eeb7b3f8da96679b7e30e5 on ffigen-compiler-opt
into 630a7a38826dd6b6f7148311c4b6a247dc3d54c2 on main.


Smappee V004

Is it an important bugfix? Or why that fast in stable?

Thanks for the question, I know now, that i did it wrong in the past. I'll show up here later.

;-) no problem.
The idea of stable repo is really to have Version in there that had „settled“ and proofed by users.
Exceptions are important bugfixel


[W5][W10-3]Liu Xuan

Add update command for person.

Good update! Update is quite useful and your style is good. Maybe try to include more test next time.


[5pt] Add CatFIM generation capability to API Service

To move into a CI/CD posture for the NWS Flood Categorical HAND FIM, we will rely on the API Service for the following features:

[ ] Allow option to run generate_categorical_fim.py
[ ] After generate_categorical_fim.py runs, do automatic copy of output GDB to Transfer drive (email Brad for full path)

@nickchadwick-noaa Could you please post an update for this issue? If there are any hold-ups that I can help address, please let me know.

The CatFIM capabilities has been added to the "Release" feature on the FIM API. See #373 for more details.


Remove hardcoded prefix word in Licences and Translators wedges when overflow is 0

Hi,
Setting a custom title, I would expect to see that string without a prefix in front of it.
<me.jfenn.attribouter.wedges.LicensesWedge
    overflow="0"
    title="Open Source Licences"
    showDefaults="false">
    <me.jfenn.attribouter.wedges.LicenseWedge repo="TheAndroidMaster/Attribouter" />
</me.jfenn.attribouter.wedges.LicensesWedge>

will produce "View Open Source Licences".
Removing the overflow="0" will produce the desired string of "Open Source Licences".

It's not actually hardcoded, there is a string resource you could override, but fair enough, I can't actually remember what my reason for doing this was anyway.

Thanks! It will be consistent in both states (with and without overflow 0) then.


refactor: do not get line/column info for tokens except on error

This is another performance improvement. Ish.
When running benchmarks in dev/debug mode, this showed a 35% decrease in runtime (edit: 26% when I generated HTML reports) on the sample-calibrations file (parse in ~2.33s rather than ~3.6s). It also showed a ~15% improvement on most corpus files, but ~8% regression on three of them.
When running in normal bench mode (basically release), the story is a bit different. Before these changes, parsing the sample calibrations file happened in ~223ms on avg, and ~239ms after these changes (~7% regression). Corpus files also showed a single-digit-percent performance regression.
OTOH, the sample calibrations had 15% outliers in the initial run and 5.6% outliers after applying changes. I am not sure whether criterion includes the outliers in average calculations or not.

Attaching a screenshots of the plotted criterion report for reference.

Re:

OTOH, the sample calibrations had 15% outliers in the initial run and 5.6% outliers after applying changes. I am not sure whether criterion includes the outliers in average calculations or not.

Per the book,

Note, however, that outlier samples are not dropped from the data, and are used in the following analysis steps along with all other samples.

I suppose the reasoning for this is given in the comments outliers/mod.rs, which say
//! WARNING: There's no formal/mathematical definition of what an outlier actually is. Therefore,
//! all outlier classifiers are *subjective*, however some classifiers that have become *de facto*
//! standard are provided here.

@Shadow53 what was your running environment like at the time of data collection? Was your laptop doing other things, too, or just running benchmarks?

@Shadow53 can you fix the commits to use the Fix: prefix. We haven't switched to angular yet 😅


Html code

Web Page Design

Welcome to My Web Page

Table Example

Name
Age
City

John Doe
25
New York

Jane Smith
30
Los Angeles

Mike Johnson
35
Chicago

List Examples
Ordered List

First item
Second item
Third item

Unordered List

Item one
Item two
Item three

© 2024 My Web Page

can you discribe the issues?


fix few_shot demo under multi class directory while running onnx inference

delete open onnx file encoding param

PR types
Bug fixes
PR changes
Others
Description
while running the demo's onnx inference task, it'll throw an error ValueError: binary mode doesn't take an encoding argument. It should be deleted.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


500 for substance treats query

For example:
https://api.monarchinitiative.org/api/bioentity/substance/CHEBI%3A40036/treats/?fetch_objects=true&rows=100
Stack trace ends with:
File "/opt/biolink-api-master/biowikidata/wd_sparql.py", line 94, in resolve_to_wikidata
(_,is_curie,p) = prefix_map.dbprefix2prop()[prefix]

@cmungall Testing with fixes made in branch issue-135 yields proper result for this query.
Adding an example URL that uses CHEBI:28748:
https://api.monarchinitiative.org/api/bioentity/substance/CHEBI%3A28748/treats/?fetch_objects=true&rows=100
which gives three Disease Ontology IDs:
[
    "DOID:1612",
    "DOID:2394",
    "DOID:11054"
]

OK.
We should have this method return association objects rather than a list. Let me check with others what our strategy should be

Given https://github.com/monarch-initiative/dipper/pull/562 we may best be waiting until it ingests


Unexpected internal error

Hi,
I'm getting the following error from resp.bytes(); I'm trying to figure out if this is an internal error to reqwest or to the server? Also; how would I match against this if I wanted to implement retrying?
    1: request or response body error: error reading a body from connection: stream error received: unexpected internal error encountered
    2: error reading a body from connection: stream error received: unexpected internal error encountered
    3: stream error received: unexpected internal error encountered

I believe that message is from http2, indicating the server send an INTERNAL_ERROR reset code.

That could be made clearer... Do you have the versions of reqwest, hyper, and h2?

reqwest: 0.11.11
hyper: 0.14.20
h2: 0.3.14


Allow tmux session name to be passed as env var

For normal usage this change should be a NOOP. However it enables the
use case where the user might want to predefine what session gets
connected to when the shell is launched. Running zsh will still net
you a connection to the last used tmux session or a new one named
"zprezto" if none exists. However env tmux_session=myname zsh will
connect you specifically to a session called 'myname' including creating
it if it doesn't exist.
This is particularly useful in window managers where a key binding might
open a terminal with a predefined session or even show a list of current
sessions and open a new terminal connected to that session.

I don't use tmux that often. I'll let users who do vote on this. There are a few other tmux-related pull requests you may want to verify.

Thanks. There seems to be a little overlap with #607 and merging one or the other of these would require some minor rebasing to fix. Functionally however they cover different ground.

I tried rebasing this since the conflicting PR was merged some time ago but the result didn't actually work as advertised. I'll re-open this when I figure out how to make it work again.


Sign images with Cosign

This PR tracks the efforts to sign the published images using Cosign and rebase to the signed image with ostree-image-signed.
Here's the current progress so far:

Extended the publish.yml action to install and sign the images with Cosign. The image signatures are stored alongside the images on the container registry, and can be verified locally with cosign verify. The private key is stored in a GitHub Secret, which means a new private key needs to be configured for forks of this repository.
Configured containers-policy.json(5) and containers-registries.d(5) to specify the path to the public key ocitree.pub. When pulling the images with podman pull, the signatures are verified as expected.

Now, the remaining problem is to get rpm-ostree to verify the signature during a rebase / upgrade. For some reason, it doesn't reject images with incorrect or no signatures, even though it rebases to ostree-image-signed:<IMAGE> just fine.

Whoops, accidentally closed this. This is still an ongoing issue.

Reopened in PR #3.


bug: attempt to index field 'uv' (a nil value)

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.5
Operating system/version
macOS 14.3.1
Describe the bug
When installing the latest version of lazy nvim, the following error is shown: share/nvim/lazy/lazy.nvim/lua/lazy/init.lua:40: attempt to index field 'uv' (a nil value)
Stacktrace:

/share/nvim/lazy/lazy.nvim/lua/lazy/init.lua:40: in function 'setup'
in function 'require' /.config/nvim/init.lua:1: in main chunk

This issue only occurs on the stable branch, if I use v10.17.0 lazyvim works just fine.
Steps To Reproduce

Remove ~/.local/share/nvim and ~/.local/state/nvim
Install the latest version of lazy nvim, branch stable or v.10.18.0.
Error is shown

Expected Behavior
The field reference error is not shown.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

@folke Thanks, it works now.

@folke, thanks!


Add $attributes option typehint

Thanks for the great module!
Could you add the $attributes option to the parameter list of all the icon methods?
The icon classes have for instance:
 * @method string adHtml(string $classnames = '', ?int $width = null, ?int $height = null)

But the underlying formatHtml() in Hyva has a fourth $attributes parameter available. This is important for instance when providing a title tag, to change the mouseover text from the icon name.
    public function renderHtml(
        string $icon,
        string $classNames = '',
        ?int $width = 24,
        ?int $height = 24,
        array $attributes = []
    ): string {

Example usage:
<?= $awesomeiconssolid->listHtml("w-5 h-5", 25, 25, ['title' => $escaper->escapeHtmlAttr(__('Add to list'))]) ?>

Currently this works (because it's a magic method), but PhpStorm doesn't think the parameter exists.

Thanks a lot @rhoerr for pointing that out!
Fixed with release 2.1.6


no license

your pypi page suggests MIT license, but here there is absolutely nothing. So legally it is not possible to use this library.

Thanks for reporting! I added a LICENSE.md file (which GitHub recognizes as MIT), which I'm guessing is what you were looking for.

Thanks for reporting! I added a LICENSE.md file (which GitHub recognizes as MIT), which I'm guessing is what you were looking for.

Yeah :)
Not that I have any intention of using this, since I already made https://github.com/ltworf/typedload/ but I was just taking a look

Yeah :)
Not that I have any intention of using this, since I already made https://github.com/ltworf/typedload/ but I was just taking a look

Yep I noticed you'd made the typedload library. ^_^ Looks useful, and is potentially a superset of what trycast is trying to do. Sadly I can't depend on it for my work projects due to the GPL license.

Yep I noticed you'd made the typedload library. ^_^ Looks useful, and is potentially a superset of what trycast is trying to do. Sadly I can't depend on it for my work projects due to the GPL license.

Good luck then :)
Personally I don't care to make a library that might end up used in proprietary projects.

Good luck then :)
Personally I don't care to make a library that might end up used in proprietary projects.


Issue #85 - fixes for CoreSizeLimitHandler

Issue #85
CoreSizeLimitHandler was not resetting its read/written counts for each request.
While testing this fix I also discovered that because it is using an HttpStream.Wrapper it is bypassing the GzipHandler, so I have changed this to also wrap the Request and Response instead of relying on wrapping the stream.
Note this CoreSizeLimitHandler is only used for Jetty 12 code, the Jetty 9 one does not have these issues.

Please also wait for a review from @gregw before merging.
I will also open a PR to test and fix this in Jetty, and once that is released we can use the Jetty version of this handler.

Should we still wait?
How can we add a test for this?

@ludoch this was approved in https://github.com/jetty/jetty.project/pull/11051, with some remaining changes requested for the javadoc. So I'd say we're good to merge here.
I have tested this manually by deploying to prod, and I have added an additional test in the Jetty PR for this.
But would be good to add tests here as well.
If you want you can merge now and I can do a separate PR with tests early next week.


coqPackages.coqhammer: 1.1.1 → 1.2

Motivation for this change
Add support for Coq 8.11
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build coqPackages_8_11.coqhammer coqPackages_8_10.coqhammer

Merged in 20.03 as 694b4ca705f32a373856518858e38b79747e3d85


Breadcrumb picker does not open when typing a non-alphabetical character

Issue Type: Bug

Enable breadcrumbs
Focus the breadcrumbs
Type a numerical character (tested with 0-9) or a special character that is valid for a file name (i.e. - or _ )

Actual Result: The find window does not open and start searching for file matches.
Expected result: The find window does open and start searching for file matches (like when an alphabetical character is typed).
VS Code version: Code 1.26.1 (493869ee8e8a846b0855873886fc79d480d342de, 2018-08-16T18:38:57.434Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4810MQ CPU @ 2.80GHz (4 x 2793)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.94GB (4.37GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Can confirm the behavior when you start typing numbers, however, special characters (like - or _ or ö) are recognized and the search is executed.
Tested on version 1.27.0

Yes, the problem is that given a key event, we have no clue what visible character that event (or a sequence of multiple events) will generate. Therefore we move focus to the text input box on keydown so that on keyup  the input box does its magic. However, we cannot do that for all keys, e.g. ctrl or cmd.
@camwar11 @DonkeyKongJr What I am wondering is how you enter those, e.g ü? Is there a button on your keyboards or via composition '¨ + u' makes ü?

@jrieken Yes, I am using a German keyboard. There are dedicated buttons for special characters like ö, ä, ü, ß etc, but they are recognized just fine from the breadcrumb control and the text input is shown.
However, when start typing with numbers nothing really happens. I would expect that it behaves the same as when start typing letters.
I totally agree on special keys like cmd or ctrl since they are used for other shortcuts or system wide, but usually you won't search with them anyways.

However, when start typing with numbers nothing really happens. I would expect that it behaves the same as when start typing letters.

Yeah, number should be honored

Hm, numbers and hyphen works for me. Must be super keyboard/os specific...

That's interesting.
Tested it on both macOS (Mojave) and Windows 10 and neither of them worked for me for numbers.
However, what I found out is that on macOS special characters are recognized and on Windows not. So there is definitely a difference on the OS you run.

One more interesting thing that I noticed just after updating to 1.27 Release.
When typing the numbers above the letters it gets recognized but when using the dedicated numpad it won't.

With 1.27 this started to work a lot better because we rely on the information the OS gives us. I have tried with my old German keyboard (good old student times) and I can trigger filtering with all kinds of characters like ü, ß, 0-9, !, @, etc.

[...] but when using the dedicated numpad it won't.

That also worked for me... Are you sure the numpad was enabled?

Does the num pad work inside the editor and does it work inside the breadcrumbs picker when having started with another character?

Yes to both.

Ok, let try the following

F1 > Open Keyboard Shortcuts File
in the lower right, press 'Define Keybinding'
press one of the keys on the numpad and write down what 'name' it has, e.g. numpad8
Then F1 > Inspect Key Mappings and find the name from the step before and share the info

I used key 7, which gave me "numpad7". When I find "Numpad7" in the Inspect Key Mappings page, I get this:
"Numpad7": {
"vkey": "VK_HOME",
"value": "",
"withShift": "",
"withAltGr": "",
"withShiftAltGr": ""
},

Ok, now we have something... Our keyboard logic here things the value being produced is "" (the empty string) and therefore we ignore that key event.What surprises me is that pressing it inside the editor or an input box prints/renders something...

this is now using the default tree filter/find logic


Extractions for GlobalProtect Description items for ease of searching

Is your feature request related to a problem?
The extractions for globalprotect events should ideally include 'Reason' data (auth failure message details) or other error messages broken out from the overall 'Description' field.
Describe the solution you'd like
Currently I've set up some test inline extractions
^\d+\s+\d+-\d+-\d+\w+\d+:\d+:\d+-\d+:\d+\s+\w+-\w+-\w+\d+\s+-\s+-\s+-\s+-\s+\d+,\d+/\d+/\d+\s+\d+:\d+:\d+,\d+,\w+,\w+,\d+,\d+/\d+/\d+\s+\d+:\d+:\d+,,\w+-\w+-\w+,\w+-\w+,\d+,\d+,\w+,\w+,"\w+\s+\w+\s+\w+\s+\w+\s+\w+.\s+\w+\s+\w+:\s+\d+.\d+.\d+.\d+,\s+\w+\s+\w+:\s+\w+,\s+\w+\s+\w+:\s+\w+@\w+.\w+,\s+\w+\s+\w+\s+\w+:\s+\w+\s+\w+\s+\d+\s+\w+\s+,\s+\d+-\w+,\s+(?P[^,]+)
I think something like this should work:
[extract_globalprotect_failure_reason]
SOURCE_KEY =  description
REGEX = Reason: (?<failure_reason>[^,]+)
Other global protect message description data that would be helpful as individual extract items...
VPN type:
Client OS version:
error:
Source region:
Config name:
Client OS:
Machine Certificate CN :
Host ID:
(Note Machine Certificate CN has a space in the message before the : which is not always obvious)
Describe alternatives you've considered
Manually creating inline extractions but these should be in the default app config files.
Additional context
Trying to build reports to send data to Help Desk to troubleshoot VPN issues.

This is legacy as GlobalProtect has it's own log type.


How to get additional input when call new_ctx?

What is the problem your feature solves, or the need it fulfills?
We use pingora as library, pingora don't listen, just handle stream from another acceptor.
Service::handle_event(pingora_stream, self.inner.clone(), self.close_recv.clone())
            .instrument(pingora_span)
            .await;

In fn new_ctx we need some input from stream to create our Self::CTX
use pingora::{
    proxy::{Session as PingoraSession}
};
struct MyCtx {
    foo: String,
}
fn new_ctx(&self) -> Self::CTX {
    // How I can get info from handle_event?
    let s = MyCtx{
        foo: ??
    };
    Self::CTX { sess: s }
}
async fn upstream_peer(
        &self,
        session: &mut PingoraSession,
        ctx: &mut Self::CTX,
    ) -> pingora::Result<Box<HttpPeer>>
{
    ctx.foo;
}

Describe the solution you'd like
when call new_ctx, add stream as input which come from Service::handle_event, so we can access data in
// MyPingoraStream impl IO trait
struct MyPingoraStream {
    foo: String,
}
fn new_ctx(&self, stream: &dyn Any) -> Self::CTX {
    let pingora_stream = stream.downcast_ref().unwrap();
    let s = MyCtx{
        foo: pingora_stream.foo
    };
    Self::CTX { sess: s }
}

Describe alternatives you've considered
Service::handle_event add another struct foo as input, foo as input when call new_ctx

Thanks for your patience in asking this, and sorry for the delay. Would you mind giving more info on what your use case is for this, like what kind of additional data is necessary and why it's necessary prior to request filters? Regardless of how the stream events are being handled, both the CTX and Session should be available for mutation in the HTTP handling phase callbacks, in the CTX case early_request_filter is available immediately after the struct is created.

we have own listener logic, so before http process, we already have some data(local_addr), and need to add to CTX when create it, httpfilter  need read that data

I'm confused because early_request_filter accepts both a Session and CTX. If all you need is the Session object to access your extra data, I don't see why you can't set the data in CTX within the http filter itself.
As part of your custom listener logic, presumably you are using an API like set_socket_digest when creating the Stream, so that you can init the local addr in the Session? On a proxy Session, the server_addr API should give you access to that digest's local_addr, so a ctx.local_addr = session.server_addr().unwrap() in the http filter would seem to suffice.


"hosted" dev build/deploy of cellxgene

Development/demo deployment build and packaging of cellxgene hosted on AWS/EB.  Includes compression, CORS, etc.
Much of the configuration and patterns can be borrowed from the cxg-tiledb prototype repo.
End result will be ability, by any party with an AWS account, to build & deploy the cellxgene repo into EB, resulting in the same features as the current proto site.

[ ] WSGI app
[ ] A Makefile target to build the application deployment zip
[ ] Makefile target to build the EB dev configuration (allowing user to eb deploy) for a "dev" environment
[ ] Cursory/starter documentation of the WSGI app configuration (eg, CXGDATAROOT environment variable), and brief build/deploy process (eg, in dev_docs or a README or whatever is convenient).

I've pushed a PR for this:  https://github.com/chanzuckerberg/cellxgene/pull/1200/commits

This tracking issue is completed.  The config subsystem was moved to #203


Randomly getting [Errno 30] when using Jupyter Python notebooks

VSCode Version: 1.51.1
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-11T01:11:34.018Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.4.0

OS Version: MacOS Catalina 10.15.4

I am often getting an [Errno 30] read-only filesystem error when I use Jupyter notebooks on VS Code, and I currently don't see a pattern in this error: sometimes it works, sometimes it does not.
When it doesn't, I cannot perform any writing operation, so even a simple code such as
`import pandas as pd
df=pd.DataFrame()
df['col1']=[1,2,3]
df.to_csv('test.csv')`
will fail.
It happens on the Insider version as well. I searched extensively on the web, found very little, asked on SO here but I wasn't able to solve it.
I am actually enjoying VS code very much, but this is a major issue to me that makes it impossible to use it as a working tool.
Please tell me if I can provide any additional information.

/extPython


IHS httpd.conf duplicate rewrites

These two blocks make both the same, forward to HTTPS and forward host to /homepage. I would recommend to just keep the second block.
https://github.com/HCL-TECH-SOFTWARE/connections-automation/blob/c1856b66ea96c24b10c54ff45c53da76b84721b3/roles/third_party/ibm/ihs/ibm-http-httpdconf/templates/httpd.conf.j2#L1080-L1086
https://github.com/HCL-TECH-SOFTWARE/connections-automation/blob/c1856b66ea96c24b10c54ff45c53da76b84721b3/roles/third_party/ibm/ihs/ibm-http-httpdconf/templates/httpd.conf.j2#L1119-L1128

Hi @sabrina-yee,
still annoying to remove each time after deploying something with the Ansible roles.
Any comment from Dev?
I prefer the block within <IfModule mod_rewrite.c> because it does not break the http, when the rewrite role is not available.
Regards,
C

Apologies for the delay. I just sent a follow up to the Dev team on this and will circle back soon.

@stoeps13 duplicate block has been removed, thanks.