fix: do not show onboarding modal unless tab is active

This PR resolves this issue
Description
When the user moves from Home to My Collection and back to Home quickly, the first time modal (Share artists you collect) shows up, and after clicking the button the app becomes unresponsive, until the user kills the app.
Suggested approach: only show the modal if the user did move to a different screen.

PR Checklist

[] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

do not show onboarding modal unless tab is active - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (do not show onboarding modal unless tab is active - mounir)

  Generated by :no_entry_sign: dangerJS against 0d7e69e986bd2685906f02ad0bce0dedc7f4789f

I don't know why the artwork form tests are failing right now (and not on main), but this PR has a fix for the tests: https://github.com/artsy/eigen/pull/9161

Update: the issue still happens 🙃

@MrSltun thanks for testing this out. I think i just removed to add the vars to the deps array

@MounirDhahri Still breaks 😫 let's pair on it tomorrow?

Let's do it

@MrSltun , we don't need migrations for added actions


Simplify Schema Template

Remove IMNode templateRoot in Template and add a Map directNodes instead, makes it easier to find the mounted node when traverse from MTree root to node in template.

Coverage increased (+0.03%) to 66.759% when pulling c34d38628ed257a3a361d2040022fde5989a19ab on bigreybear:tree_template into 206412a7ea01ad44a93abbb496904ae139ea37e7 on apache:master.


Duplicated error message when the master playlist is available but not the variants

Hello, I can see double errors on the screen "hlsjs: Video file not found"
and the error event is fired twice when the master playliste is available but not the variants(multiple bitrates)
Is it normal ?
also I had a bigger issue when I was using the release version ... so I switched to the minimal version : is that normal ?  Well apparently the minimal version is not the same as the full version of the hlsjs : the full version loads the flash engine as if the hlsjs is not even loaded.
Thanks.

Player view : basically double messages :

console view shows

Double error message:
I can observer this as well, it's a Flowplayer 7 thing; it doesn't happen with Flowplayer 6 which bails out quicker. I'll file a report against core if I don't forget and you don't beat me to it.
That being said, it can be dealt with, as you can see in this demo:
http://flowplayer.org/api/live-check.html
Version 6 for comparison:
http://flowplayer.org/v6/api/live-check.html

Your other question is not clear. The github README - https://github.com/flowplayer/flowplayer-hlsjs#features - tells you the hls.js version (currently v0.6.20) packed into the latest plugin version, which shoud be loaded as per https://flowplayer.org/docs/plugins.html#hlsjs-assets from //releases.flowplayer.org/hlsjs/flowplayer.hlsjs.min.js
Both the github README and the plugin page point to the hls.js docs of the currently packed version etc.
What exactly is the problem?

I think I was able to solve this in the plugin.


Fix issue in readme

$response should be returned instead of the int from write.

Coverage remained the same at 99.325% when pulling 842fee6de5f3e7703886c0fc8e75e48a6a8f2d84 on jenssegers:patch-1 into 5e83de582e633161e94d03de42b17129b22817bb on slimphp:4.x.


Extracting multipart rar for Universal app

Hi,
I'm testing out creating Universal apps for Windows 10 and I'm trying to extract multipart rar files. It starts out fine but I'm getting error: "Multi-part rar file is incomplete.  Entry expects a new volume: filename.ext". Extracting file with WinRAR is no problem, so there should not be any issues with my archive.
Here is my code:
using (var stream = await file.OpenAsync(FileAccessMode.Read))
                    {
                        var archive = ArchiveFactory.Open(stream.AsStreamForRead());

                        foreach (var entry in archive.Entries)
                        {
                            if (!entry.IsDirectory)
                            {
                                _sourceAnalysis.Files.Add(entry.Key);

                                var entryStream = entry.OpenEntryStream();

                                var extractedFile = await _settings.SourceStorageFolder.CreateFileAsync(entry.Key,CreationCollisionOption.ReplaceExisting);

                                using (var outputStream = await extractedFile.OpenStreamForWriteAsync())
                                {
                                    await entryStream.CopyToAsync(outputStream);
                                }
                            }
                        }
                    }

Any ideas as to what might be wrong?

The issue is that using the stream overload for open means that the code doesn't know where to look for the next volume file.  Either give Open a path or you have to give all the volume streams at once and in order.

The only static method allowed on ArchiveFactory seems to be Open(Stream, Options) for Universal apps

Look at RarArchiveFactory

Got it working using RarArchive.Open(streams). Requires a lot more manual labor on my end if I'm going to create something that supports any kind of multi-rar, ordinary rar or zip though. But I guess that should be achievable. Thanks.

You could implement file stuff for UWP.  I just didn't do it as making a portable library that doesn't access the file system directly was easier


[Follow up] Trino getting started docker compose

Description
This PR

Renames getting-started/trino/docker-compose-trino.yml to getting-started/trino/docker-compose.yml
Fix minor style and grammar issues

Follow up to #42
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Documentation update
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Followed README, ran on docker and Trino CLI works
Checklist:
Please delete options that are not relevant.

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

Thanks @kevinjqliu for the fix.


chore(package): update jest to version 16.0.2

https://greenkeeper.io/

Coverage remained the same at 67.308% when pulling a3211b8a5a1e306621bdb64e0566da684f1ca89a on greenkeeper-jest-16.0.2 into 1a9ab110f5f7a0d021a7f01e9238242c2f0d079c on master.


add_request_headers will crash Ambassador if the header is already existing in request

Describe the bug
Ambassador will crash when using add_request_headers with a header which already exits in the request.
To Reproduce
Steps to reproduce the behavior:

define a mapping containing a add_request_headers:
add_request_headers:     Authorization: "Bearer myClientToken"

make a request:
curl -H "Authorization: myServerToken" https://<myservice>

curl result is:
curl: (52) Empty reply from server

log shows:
[2018-07-20 15:54:21.725][54][critical][assert] source/common/http/header_map_impl.cc:326] assert failure: *ref_lookup_response.entry_ == nullptr [2018-07-20 15:54:21.725][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:125] Caught Aborted, suspect faulting address 0x2e [2018-07-20 15:54:21.725][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:94] Backtrace thr<54> obj</usr/glibc-compat/lib/libc.so.6> (If unsymbolized, use tools/stack_decode.py): [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #0 0x7f2a39d63a70 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #1 0x7f2a39d64c50 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:104] thr<54> obj</usr/local/bin/envoy> [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #2 0xf82970 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #3 0xf82e15 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #4 0xc60bb2 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #5 0xc3ad26 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #6 0xc42b02 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #7 0xc43062 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #8 0xb756a6 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #9 0xbf6728 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #10 0xbee7b4 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #11 0xbeded0 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #12 0xc7ddbf (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #13 0xc7bd76 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #14 0xc7bd9a (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #15 0xc880d4 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #16 0xc7c8c8 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #17 0xc7c79c (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #18 0xbeb470 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #19 0x91faca (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #20 0x91fb61 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #21 0x917051 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #22 0x917f18 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #23 0x917db0 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #24 0x915786 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #25 0x919595 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #26 0x90caf7 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #27 0x90bb53 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #28 0x90bb83 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #29 0xe940b1 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #30 0xe9480e (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #31 0x90679d (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #32 0x8f70f8 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #33 0x8f6c1d (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #34 0x8f77ee (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #35 0x4e4f7b (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #36 0xeed2ed (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #37 0xeed312 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:104] thr<54> obj</usr/glibc-compat/lib/libpthread.so.0> [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #38 0x7f2a3a480586 (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:104] thr<54> obj</usr/glibc-compat/lib/libc.so.6> [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<54> #39 0x7f2a39e2097e (unknown) [2018-07-20 15:54:21.726][54][critical][backtrace] bazel-out/k8-dbg/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:121] end backtrace thread 54 got SIGCHLD PID=46 was killed with signal=6 Due to abnormal exit, force killing all child processes and exiting exiting due to lack of child processes AMBASSADOR: envoy exited with status 1

Expected behavior
as the it is called 'add_request_headers' another header should be added. If it violates some specification, an appropriate http error should be returned.
Versions (please complete the following information):

Ambassador:  0.35.3
Kubernetes environment AWS EKS
Version
kubectl version Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.1", GitCommit:"b1b29978270dc22fecc592ac55d903350454310a", GitTreeState:"clean", BuildDate:"2018-07-18T11:37:06Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"} Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-28T20:13:43Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

@flynn @plombardi89 This is a limitation in Envoy 1.7.
What happens is that request_headers_to_add are inserted only a after headers enclosed in the virtual host level. If header already exists (either inserted by the auth filter or by downstream client), it will reach this logic:
https://github.com/envoyproxy/envoy/blob/3f59fb5c0f6554f8b3f2e73ab4c1437a63d42668/source/common/http/header_map_impl.cc#L326
if (cb) {
    key.clear();
    StaticLookupResponse ref_lookup_response = cb(*this);
    ASSERT(*ref_lookup_response.entry_ == nullptr); // This function doesn't handle append.
    maybeCreateInline(ref_lookup_response.entry_, *ref_lookup_response.key_, std::move(value));
  } ..

Which in  upstream Envoy, it has been replaced by this:
https://github.com/envoyproxy/envoy/blob/976991c3b8ac5a5ddf0430731dd155788cb636a7/source/common/http/header_map_impl.cc#L370
if (cb) {
    key.clear();
    StaticLookupResponse ref_lookup_response = cb(*this);
    if (*ref_lookup_response.entry_ == nullptr) {
      maybeCreateInline(ref_lookup_response.entry_, *ref_lookup_response.key_, std::move(value));
    } else {
      appendToHeader((*ref_lookup_response.entry_)->value(), value.c_str());
      value.clear();
    }
  } ..

Latest version also allows deciding whether or not headers should be appended:
https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/base.proto#envoy-api-msg-core-headervalueoption
route_config:
  request_headers_to_add:
  - header:
       key: Authorization
       value: Bearer 123
     append: false # This allows appending or override downstream headers
```


Mouse response sluggish in the text editor with higher DPI mouse

VS Code Version: 1.54.3
OS Version: Windows 10 10.0.19042

Steps to Reproduce:

Have a high DPI mouse. I'm using Jelly Comb Ergonomic BueTooth/2.4GHz mouse model MV045. I'm working on 4K TV monitor, 30 fps.
I'm working on a AC-powered laptop, so CPU throttling doesn't seem an issue.
Open any code file. I'm working with Python, although the issue is still noticeable with a plaintext file.
Move the mouse in the text editor. You will notice that the cursor movement lags noticeably behind the physical movement. It does quite impair the pointing precision, because it really breaks visual feedback. Very aggravating.
The  mouse (described above) has a DPI switch. When switched to lower dpi, the lag is reduced, but then mouse needs very wide movement.
Lower DPI mouse (for example low end Dell wireless mouse) doesn't suffer from this.
Other software, such as Visual Studio, doesn't suffer from such lag.

Does this issue occur when all extensions are disabled?: Yes

To add: Mouse movement in other panels, such as file list or git changed file list, doesn't seem to lag.

@alegrigoriev Could you please record a screen capture of the problem, that might help me understand the problem better. Do you use editor.cursorSmoothCaretAnimation ?


Return: could add a command as returnNotNull

There are too many codes like
if err != nil {
return err
}
So, if add a command like
retNotNull err
if err is nil, just do nothing

Sorry, the langauge is frozen and this has already been discussed many times.

Thanks


xp not being added

I bumped up my Zero save a couple levels because I couldn't get past a mission, but now all XP I gain just... doesn't show?

In case anyone else has this issue: Click on "Sync" next to the XP field after changing the character's level to make the XP match the new level.
If you don't do this, you will still earn XP in game, but as the XP is less than what is required for the level of the character, you will first need to earn enough XP to legitimately gain the modded level before seeing any progress on the XP bar (and being able to earn new levels).


map+reduce, tricky behavior or a bug?

So this piece of code:
R.map(item =>
  R.reduce((result, value) => {
    result.push(value);
    return result;
  }, [], item),
  [[1], [2], [3], [4]]
)

returns totally expected result:
[
  [1],
  [2],
  [3],
  [4],
]

While this piece of code:
R.map(
  R.reduce((result, value) => {
    result.push(value);
    return result;
  }, []),
  [[1], [2], [3], [4]]
)

Does not:
[
  [1, 2, 3, 4],
  [1, 2, 3 ,4],
  [1, 2, 3, 4],
  [1, 2, 3, 4],
]

If you get your head around it: yes, you pass an array, yes, its passed by reference, yes, it binds once within a function, but, isn't ramda supposed to never mutate anything?

Ramda APIs don't mutate anything, but they intentionally do not try to block client code from doing so (in this case the magic would be to clone the initial value passed to reduce).
In fact, performance-sensitive code sometimes takes advantage of the current behavior:
https://github.com/ramda/ramda/blob/master/src/groupBy.js
However, if you want immutability guaranteed, using R.append (rather than array.push) would produce a consistent result in both of your examples.


Deprecated graceful-fs

I have the following warning when installing node-svn-ultimate:
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs version 3 and before will fail on newer node releases. Please update to<EMAIL_ADDRESS>as soon as possible.
Any plans to follow the graceful-fs version?

I've updated the dependency fs-extra which caused this warning, i have published v1.0.3

Thanks you. It works.


no device type supports both of those nodes and the other nodes colocated with them.

clipped_gradients, _ = tf.clip_by_global_norm(gradients, 1.0)

File "D:\anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\python\ops\clip_ops.py", line 222, in clip_by_global_norm
use_norm = global_norm(t_list, name)
File "D:\anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\python\ops\clip_ops.py", line 161, in global_norm
half_squared_norms.append(gen_nn_ops.l2_loss(v))
File "D:\anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\python\ops\gen_nn_ops.py", line 4662, in l2_loss
"L2Loss", t=t, name=name)
File "D:\anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\python\framework\op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "D:\anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\python\framework\ops.py", line 3290, in create_op
op_def=op_def)
File "D:\anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\python\framework\ops.py", line 1654, in init
self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access
InvalidArgumentError (see above for traceback): Cannot colocate nodes 'model/optimizer/global_norm/L2Loss_17' and 'model/optimizer/gradients/model/inference/CudnnRNN_1_grad/CudnnRNNBackprop' because no device type supports both of those nodes and the other nodes colocated with them.
Colocation Debug Info:
Colocation group had the following types and devices:
CudnnRNNBackprop: GPU
Identity:
L2Loss: CPU
Colocation members and user-requested devices:
model/optimizer/gradients/model/inference/CudnnRNN_1_grad/CudnnRNNBackprop (CudnnRNNBackprop)
model/optimizer/gradients/model/inference/CudnnRNN_1_grad/tuple/control_dependency_3 (Identity)
model/optimizer/global_norm/L2Loss_17 (L2Loss)
     [[Node: model/optimizer/global_norm/L2Loss_17 = L2Loss[T=DT_FLOAT, _class=["loc:@model/optimizer/gradients/model/inference/CudnnRNN_1_grad/CudnnRNNBackprop"]](model/optimizer/gradients/model/inference/CudnnRNN_1_grad/tuple/control_dependency_3)]]

Why? and how to fix it, thanks

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

CUDA 9
CUDNN 7
Windows 10
2x GPU 1070


Pull Request for Issue #86 - Fix dependency vulnerabilities

Fixes #86
Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

Update esdoc dev dependency version
Remove away marked (sub-dependency of esdoc) vulnerability
Bump package.json version by minor increment
Update License End-Year based on existing test requirement

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Additional vulnerabilities was flagged out by running npm audit, and it was suggested to bump up mocha version to 5.x.x.  Should i fix that within this Pull request too?

This is awesome @robincher!
I've added this to our backlog for a review and merge.
With Best Regards,
Elmer

Hi @thinkingserious , additionally i updated the dev dependency - mocha to the latest. The previous version 2.x.x was having vulnerabilities if you run npm audit. I have run the local test and its all good

Note to code reviewers: we need to make sure none of these updates are breaking changes.

Hello @robincher,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

Opps sorry @thinkingserious , i have a separate PR (incoming), so i have reverted the wrong commits. Need you to resign the CLA again :(

Closing in favor of https://github.com/sendgrid/sendgrid-nodejs/pull/1010


multi zone consumer group: cg metadata propagation(fast and slow path)

This diff adds the multi_zone cg metadata propagation. Here's a summary of the change

Move DLQ creation from frontend to metadata. This is because replicator also needs to create cg by calling metadata so all logic needs to happen in metadata
cg CUD fast path. Request flow: local frontend->local controller (will call metadata to create cg locally)->local replicator->remote replicator(will call metadata to create cg locally)
cg CUD slow path: replicator in each zone will talk to authoritative zone, and compare (update is not in this diff because the current diff is too large now)

related thrift change: https://github.com/uber/cherami-thrift/pull/12
@GuillaumeBailey you're only required to review change #1 (change in metadata_cassandra) but feel free to review the whole PR

Changes Unknown when pulling e6a6457420b35d72e8efd2178c61ba407aba670c on multi_zone_cg into ** on master**.

Coverage decreased (-0.1%) to 68.557% when pulling 0d3d7eeb11b1c43b5a7164e97cffbbcc5e695dea on multi_zone_cg into 9e38ccaad4a3a1941fc5b5f6be1bb96b9ecedbd9 on master.

Coverage decreased (-0.5%) to 68.184% when pulling 92e51172164bf32b9cd98a51c499180664a7a825 on multi_zone_cg into 9e38ccaad4a3a1941fc5b5f6be1bb96b9ecedbd9 on master.

Coverage decreased (-0.09%) to 68.571% when pulling bd172eadb99aae866310f0d9ac69ca160d058c06 on multi_zone_cg into 9e38ccaad4a3a1941fc5b5f6be1bb96b9ecedbd9 on master.

Coverage decreased (-0.06%) to 68.601% when pulling 2c57283388ad4af7f3c45262132bfa6dc8a14a8c on multi_zone_cg into 9e38ccaad4a3a1941fc5b5f6be1bb96b9ecedbd9 on master.

Coverage decreased (-0.03%) to 68.583% when pulling 521fc2a3a7e93ed10fadcc9e1ff2eed045c8985f on multi_zone_cg into 0becde916e9ebd9cc1ad39624225245dc3d59232 on master.

Coverage decreased (-0.1%) to 68.496% when pulling 49868026e5ef53a2ceccee69961fa20160b60297 on multi_zone_cg into 0becde916e9ebd9cc1ad39624225245dc3d59232 on master.

Coverage decreased (-0.3%) to 68.65% when pulling 30e83d797ada86665d9f01f172411617423fa1d4 on multi_zone_cg into<PHONE_NUMBER>f9df1b8a4684a7422702976d62a93b on master.


WIP - 20 Allow AC Reveal in Player Window

Looking for early feedback. Is this heading towards what was envisioned?

I don't like how this approach clutters the UI, but the functionality seems good. I think if you put this behind a Player View option it would be a good start, but I'd like to see a more subtle impact on the UI for this.

@cynicaloptimist open to suggestions on what a more subtle approach may look like. I design like an engineer :)

It would be best for this button to be a command (as well as the original hide/reveal combatant button).
FYI, I'm planning to do a big rework on how commands are displayed. The new design might wind up with them appearing directly on the selected or hovered combatant, instead of on the sidebar.

Sounds like it might be best for me to wait until your command refactor is complete, then I can readdress this. Will leave open for now as a reminder.


Run netty4.1.58 test case error

Expected behavior
Actual behavior
Run netty4.1.58 test case error
Steps to reproduce
@Test
public void test02(){
        PooledByteBufAllocator allocator = newAllocator(true);
        ByteBuf byteBuf = allocator.ioBuffer(128);
        System.out.println(byteBuf);
    }

run test02 case，report the following error
Unrecognized option: --illegal-access=deny
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.58.final
JVM version (e.g. java -version)
1.8
OS version (e.g. uname -a)
macos

This is not a Netty bug. Check your runtime configuration.

thanks, i will check it.

@xiaoheng1 how do you solve this problem. where idea need to configure

@xiaoheng1 i also meet the same problem. how do you solve it.

You can search illegal-access=deny in pom.xml and comment this out and try

Commenting it out should not be necessary. Sounds like a Java 9 (or greater) profile is somehow enabled. Could be Maven is running with a mix of Java versions, e.g. java command invoking one version and JAVA_HOME pointing to another version. Or something else is wrong with the environment. So that's what people need to investigate if they run into this issue.

Commenting it out should not be necessary. Sounds like a Java 9 (or greater) profile is somehow enabled. Could be Maven is running with a mix of Java versions, e.g. java command invoking one version and JAVA_HOME pointing to another version. Or something else is wrong with the environment. So that's what people need to investigate if they run into this issue.

it’s ok when i uncheck the java11 profile.

Commenting it out should not be necessary. Sounds like a Java 9 (or greater) profile is somehow enabled. Could be Maven is running with a mix of Java versions, e.g. java command invoking one version and JAVA_HOME pointing to another version. Or something else is wrong with the environment. So that's what people need to investigate if they run into this issue.

it’s ok when i uncheck the java11 profile.

Thank you. I solved it

I solved it

Commenting it out should not be necessary. Sounds like a Java 9 (or greater) profile is somehow enabled. Could be Maven is running with a mix of Java versions, e.g. java command invoking one version and JAVA_HOME pointing to another version. Or something else is wrong with the environment. So that's what people need to investigate if they run into this issue.

it’s ok when i uncheck the java11 profile.

Thank you. I solved it

Thank you , I solved it too.
This problem may happen when there are 2 versions of jdk, comment out the profile about jkd11 in pom.xml then it is solved.


💡Determine data to display on user Dashboard

Create tickets for queries and mutations that will need to be created for all the necessary data.
🔗 Resources
https://supabase.com/docs/guides/with-react
See "Account Page" section
const getProfile = async () => {
        try {
            setLoading(true)
            const { user } = session

            let { data, error, status } = await supabase
                .from('profiles')
                .select(`username`)
                .eq('id', user.id)
                .single()

            if (error && status !== 406) {
                throw error
            }

            if (data) {
                setUsername(data.username)
                setWebsite(data.website)
                setAvatarUrl(data.avatar_url)
            }
        } catch (error) {
            alert(error.message)
        } finally {
            setLoading(false)
        }
    }

This function will retrieve data from 'profiles' table, and set states for Username, Website, Avatar. This is a good starting template.

This ticket is going to pertain to user information such as username, account age, etc. Other tickets will be created for setting up the users watch queue, favorites, etc.

Created the following tickets to improve the initial user structure of the DB and connect it to the application.
#52
#79
#80


Spinner hijacks signals without option to override.

Describe the bug
If I have custom signal capture behavior set up within my application, I want to be able to respect this even if I am running the spinner.
However, it seems that if the spinner is running, it hijacks my signal (exits the spinner without error) and pretends nothing has happened.
To Reproduce
Take this basic example, if while the spinner is running I hit ctrl+c it will exit with code 0 instead of the desired 123.
package main

import (
	"log/slog"
	"os"
	"os/signal"
	"time"

	"github.com/charmbracelet/huh/spinner"
)

func main() {
	sigChan := make(chan os.Signal, 1)
	signal.Notify(sigChan, os.Interrupt)
	go func() {
		<-sigChan
		slog.Debug("cancel handler got SIGINT")
		os.Exit(123)
	}()

	s := spinner.New()

	myFunc := func() {
		time.Sleep(1 * time.Hour)
	}

	err := s.Action(myFunc).Run()
	if err != nil {
		slog.Error("error", err)
	}
}

This is compounded if we move the spinner into a loop it can't break out of, as we'll never be able to exit.
package main

import (
	"log/slog"
	"os"
	"os/signal"
	"time"

	"github.com/charmbracelet/huh/spinner"
)

func main() {
	sigChan := make(chan os.Signal, 1)
	signal.Notify(sigChan, os.Interrupt)
	go func() {
		<-sigChan
		slog.Debug("cancel handler got SIGINT")
		os.Exit(123)
	}()

	s := spinner.New()

	myFunc := func() {
		time.Sleep(1 * time.Hour)
	}

	for {
		err := s.Action(myFunc).Run()
		if err != nil {
			slog.Error("error", err)
		}
	}
}

Expected behavior
Tea based applications take in ProgramOptions one of which is WithoutSignalHandler which would allow using our own SignalHandler logic instead of hijacking it.
In func (s *Spinner) Run() error you're passing some default ProgramOptions
p := tea.NewProgram(s, tea.WithContext(s.ctx), tea.WithOutput(os.Stderr))

Would be beneficial to allow optional passing of tea.WithoutSignalHandler() (as well as maybe some of the other options); allowing for a more usable spinner.
Desktop (please complete the following information):

OS: macOS
Version Sonoma 14.6.1

Additional context
Add any other context about the problem here.

it doesn't really hijack the signal, but it does hijack ctrl+c.
i believe the problem runs a bit deeper, even, we might need something like this: https://github.com/charmbracelet/bubbletea/pull/1255

Not sure if my issue is similar, but the following code hijacks my ctrl+c, and when entered, the input is cancelled, but the program continues to run with no error returned.
var value string

err := huh.NewInput().
	Title("Favourite colour?").
	Prompt("? ").
	Value(&value).
	Run()

if err != nil {
	return err
}

// continues running; `err` == `nil`

Tested an fmt.Scanln and ctrl+c worked properly. Been trying to figure out a solution for a bit now with not much luck.

both issues should be fixed by #491


ms-playwright-print-deps.exe as malware while running on server?

I've implemented Playwright in my asp.net core application so I can programmatically print a pdf a page from our Blazor client side application.
In development, and in servers that I control, this works like a charm.  Runs without issue in debug and release modes.
However when I deploy to servers I have a bit less control over, i.e. client's servers, Symantec starts to flag ms-playwright-print-deps.exe as malware.

What is ms-playwright-print-deps.exe?  I can't find a reference to it anywhere in the repo
Is there anyway to configure playwright installation/my application so this isn't an issue/a thing the system tries to run?

Trying to understand what is happening behind the scenes so I can work with the client's IT department to unblock this exe, or if I can somehow avoid having it called.

What is ms-playwright-print-deps.exe?

print-deps.exe is a tool used to check if the OS has all the dependencies needed to run the browser.

I can't find a reference to it anywhere in the repo

You can find the code upstream. https://github.com/microsoft/playwright/tree/master/browser_patches/winldd

Is there anyway to configure playwright installation/my application so this isn't an issue/a thing the system tries to run?
Trying to understand what is happening behind the scenes so I can work with the client's IT department to unblock this exe, or if I can somehow avoid having it called.

One way to avoid that check now would be installing the browsers in a path you will know and then call LaunchAsync pass the executablePath.
What do you think about this issue @arjunattam?

@kblok Thanks!  Worked like a charm.  I'm happy to close this issue unless there is more conversation to be had around it.
My code in case anyone stumbles here again in the future:
 using var playwright = await Playwright.CreateAsync();
 await using var browser = await playwright.Chromium.LaunchAsync(executablePath: @"C:\website\ms-playwright\chromium-799411\chrome-win\chrome.exe);

Awesome!
Let's wait for @arjunattam's feedback.

Symantec starts to flag ms-playwright-print-deps.exe as malware.

This is pretty bad it will also bite Playwright (typescript) users, we'll have to do something about it. I'm not sure yet which part makes it look like malware, it might be some of the Win APIs that we call. Maybe there's a way to sign the binary or something to make it look less suspicious.

@benhysell would you mind checking if the exe inside this zip runs in your server? thanks!
PrintDeps.exe.zip

@kblok is that exe in the latest release?  If so I'm happy to pull down the latest NuGet and give it a go.

@benhysell we want to be sure that that will fix the issue before shipping a new version.

@kblok Sorry, I can't pull down random exe's from GitHub to run on a client's server.
Going forward I've configured our systems in release to not have to rely on the .exe, this is the safest path for us so I never have to tangle with the anti-virus in the future.
Happy to give it test if/when this gets packaged up.

@kblok Sorry, I can't pull down random exe's from GitHub to run on a client's server.

That's totally understood.

Happy to give it test if/when this gets packaged up.

It is currently available in next version of our npm<EMAIL_ADDRESS>If you can try that, it'd be great.

@yury-s I'm using the NuGet package in my asp.net project...the easiest path for me to test would be if you published a vNext version of that.
I do not completely understand the architecture and interdependencies of playwright, i.e.

I can't find printdeps.exe on any of the systems I've installed the NuGet on

I had a hard finding the file that was getting flagged ms-playwright-print-deps.exe, I finally located it in c:\windows\temp

Not understating the architecture/interdependencies I'm not apt to go 'off-roading' testing .exes.  Again happy to pull down a NuGet vNext and give it a go.

@benhysell  No worries, I think Dario found a way to test it and the fix didn't quite work so we need to investigate further. In any case thanks for looking into this.

I had a hard finding the file that was getting flagged ms-playwright-print-deps.exe, I finally located it in c:\windows\temp

The file name looks odd to me as well but I'm not too familiar with how it is repackaged in case of NuGet, also it might be the antivirus renamed it or something, the original binary we build is PrintDeps.exe


[EN DateTimeV2] hyphenated date ranges produce bad results

To Reproduce

in the python repl, try out hotel 10/1 - 11/7
You get

{
        "start": 6,
        "end": 14,
        "resolution": {
                "values": [
                        {
                                "timex": "2011-10-01",
                                "type": "date",
                                "value": "2011-10-01"
                        }
                ]
        },
        "text": "10/1 - 11",
        "type_name": "datetimeV2.date"
}

Expected behavior
Should be a DT range XXX-10-01 - XXX-11-07
Platform (please complete the following information):
Python 3.7, master

Closing this one as an issue specifically for JavaScript and Python was created.


created and added a sample map png and tmj file for a prospective app…

Aidan created and added a sample map png and tmj file for a prospective app.

Map is AI-generated, which provides a good starting point! We'll want to update maps over time to make them higher quality, so let's add this map to the beta map list. Possible workflow: create tiles in Canva using their free images (eg. grass, sand, trees, etc)., make a map with them using Tiled, then import to Phaser project.


gcc: do not install sys-include headers for cross-compilers.

Before the change include headers for cross-compilers like pkgsStatic looked like this:
$ nix build -L --impure --expr 'with import ./. {}; pkgsStatic.stdenv.mkDerivation { name = "probe"; buildCommand = "echo | $CXX -x c++ -E -v - |& fgrep -B10 search; exit 1"; }' |& unnix

#include "..." search starts here:
#include <...> search starts here:
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/include/c++/13.0.1
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/include/c++/13.0.1/x86_64-unknown-linux-musl
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/include/c++/13.0.1/backward
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/sys-include
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/include
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/include
 /<<NIX>>/musl-static-x86_64-unknown-linux-musl-1.2.3-dev/include
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/include-fixed
End of search list.

Note that .../sys-include inhibits the effect of musl-static-x86_64-unknown-linux-musl-1.2.3-dev/include.
After the change the paths look as expected:
$ nix build -L --impure --expr 'with import ./. {}; pkgsStatic.stdenv.mkDerivation { name = "probe"; buildCommand = "echo | $CXX -x c++ -E -v - |& fgrep -B10 search; exit 1"; }' |& unnix

#include "..." search starts here:
#include <...> search starts here:
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/include/c++/13.0.1
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/include/c++/13.0.1/x86_64-unknown-linux-musl
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/include/c++/13.0.1/backward
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/../../../../x86_64-unknown-linux-musl/include
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/include
 /<<NIX>>/musl-static-x86_64-unknown-linux-musl-1.2.3-dev/include
 /<<NIX>>/x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/include-fixed
End of search list.

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Lightly tested a few targets from x86_64-linux host:

pkgsCross.mingw64
pkgsCross.riscv64
pkgsCross.mmix

All seem to work.

This change has broken pkgsStatic.netbsd.compat on staging-next, which is needed for fts, for example by glib.

Can reproduce locally as:
$ nix build -f. -L pkgsStatic.netbsd.compat
...
       > checking how to run the C preprocessor... x86_64-unknown-linux-musl-cpp
       > configure: error: in `/build/cvs-export/tools/compat':
       > configure: error: C preprocessor "x86_64-unknown-linux-musl-cpp" fails sanity check
       > See `config.log' for more details

I suspect we are using unwrapped version of cpp here and are missing standard -idirafter flags. It was previously masked by the default path. Looking to confirm.

Confirmed it's unwrapped:
bash-5.2$ dev>which x86_64-unknown-linux-musl-gcc
/nix/store/dskdlhryjxq1bdk8qsmjncc4z7ak79yn-x86_64-unknown-linux-musl-stage-final-gcc-wrapper-13.0.0/bin/x86_64-unknown-linux-musl-gcc

bash-5.2$ dev>which x86_64-unknown-linux-musl-cpp
/nix/store/bsh1kvhm5sia7ps46fyzcgycjfqg1jyi-x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/bin/x86_64-unknown-linux-musl-cpp

And preoprocessor is validated against system headers without any extra include paths:
configure:3142: x86_64-unknown-linux-musl-cpp  conftest.c
In file included from /nix/store/bsh1kvhm5sia7ps46fyzcgycjfqg1jyi-x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/include/syslimits.h:7,
                 from /nix/store/bsh1kvhm5sia7ps46fyzcgycjfqg1jyi-x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/include/limits.h:34,
                 from conftest.c:10:
/nix/store/bsh1kvhm5sia7ps46fyzcgycjfqg1jyi-x86_64-unknown-linux-musl-stage-final-gcc-13.0.0/lib/gcc/x86_64-unknown-linux-musl/13.0.1/include/limits.h:205:75: error: no include path in which to search for limits.h
  205 | #include_next <limits.h>                /* recurse down to the real one */
      |                                                                           ^
configure:3142: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "libnbcompat"
| #define PACKAGE_TARNAME "libnbcompat"
| #define PACKAGE_VERSION "noversion"
| #define PACKAGE_STRING "libnbcompat noversion"
| #define PACKAGE_BUGREPORT<EMAIL_ADDRESS>| #define PACKAGE_URL ""
| /* end confdefs.h.  */
| #ifdef __STDC__
| # include <limits.h>
| #else
| # include <assert.h>
| #endif
|                    Syntax error
configure:3172: error: in `/home/slyfox/dev/git/nixpkgs/cvs-export/tools/compat':
configure:3174: error: C preprocessor "x86_64-unknown-linux-musl-cpp" fails sanity check
See `config.log' for more details

As a workaround you can try to pass CPP="$CC -E". Ideally we will need to wrap cpp as well.
If it's a wider spread breakage we'll need to roll the sys-include removal back and try again when more fixes are applied.

Proposed the cpp wrapping fix as https://github.com/NixOS/nixpkgs/pull/221677

Another regression manifested itself: https://github.com/NixOS/nixpkgs/issues/245455
Proposed the revert in https://github.com/NixOS/nixpkgs/pull/245550


Provide wrapped functions with all the options exposed

A follow-up to #52, but can be done concurrently.
The current functions can remain intact and a new set of functions can be added as a cheap wrapper for raw procedures.
-- current
withWindowOpen :: MonadUnliftIO m => String -> m () -> m ()

-- proposed
withWindowOpen' :: (MonadUnliftIO m, StateVar Bool isOpen) => ImGuiWindowFlags -> isOpen -> String -> m () -> m ()

Fancy wrappers (labels, lenses, etc.) can be provided as alternatives in their own packages.
Cons: this will double the amount of functions published. The previous implementation, however, can be rebased upon those new expanded.
Alternative 1: Add all the arguments to existing functions. A breaking change, a bit noisier to write but lighter on maintenance.
Alternative 2: Rename current shortcuts to underscored, add expanded versions like in A1. Also a breaking change and may require breakage again when "expandable defaults" are to be implemented.

It is possible to put expanded version in a separate module, so "sensible default" shortcuts would stay at their place, and special scenarios could incorporate something like DearImGui.LowLevel.


Switch likes label with timestamp label on feed cells

The number of likes should be above the heart, and the timestamp should be below the song label. The UI doesn't work well as is.

I believe this is due to our "cell convention". We put followers count below the name. Not to the right of it. Also dates/times don't change a lot in length compared to count and could vary the amount of song title we can display which could look odd.

Things that are alike should be grouped together, hence like count should be near the heart icon, so you can see it go up when you like it. Right now the likes counter is essentially hidden. Nobody cares about the date posted, its already chronological, the number of likes is what people really care about. I don't see how this would change the UI much, label widths would stay the same since date posted and likes would just swap, they're both about the same length anyway.

see following twitter post for example, notice how date posted is grouped with name, and likes count is right next to the heart


Some more help in the README...

In the README, would like some help with what version of php this requires, and how I would specify (via js route or php route) which map it should render (where the map is in the data directory).
A sample map in the data/lib directory would be useful to explain how things hang together.
(Thanks for the LICENSE file.. this is the closest that I've found to something that I need. So if I can get this working, I will absolutely contribute back)

Hi Erin,
I updated the README, it was outdated. PHP is not required any more and the data-folder is going to be deleted. I created a small README.mm that is going to be loaded if you load index.html without parameters. You should get it going without any problems. Please tell me if this is not the case.

Yes! Thanks. I did figure it ou, but the confirmation and the example are very helpful, thanks!

Fixed by 75413ba40abff1bc6acd955fbc87a80b5d1bbd68


x/build/devapp: dummy issue. Please ignore.

Gerrit ID: 10660

16140

Gerrit ID: 22285

22515

14840

22400 :goat:

Closing this. It has served its purpose.


Examine possibility of merging passes

Right now the separation of passes is very close to how lslint and LL's compiler worked, but walking the AST isn't free. Right now the most cumulatively expensive part of the code is the tree walking logic, merging things into fewer passes == fewer tree walks == faster.
At least symbol resolution and type checking could be merged into one visitor (maybe with a flag field to determine whether to actually check types / resolve symbols.)

recalculateReferenceData() could also be eliminated by being smarter about tracking what we're folding when we fold.


⚠ Bofrost.nl has degraded performance

In a9634df, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 3279 ms

Resolved: Bofrost.nl performance has improved in b02e465.


[CLOSED] Create systemd Provider

 Issue by TauZero
Tue Mar 15 21:09:12 2016
Originally opened as https://github.com/mistifyio/mistify/issues/52

Provide the following funcitonality:

Create process : accept parameters and generate file via template
Remove process
Start/Stop/Restart process
Status of process
List managed processes

 Comment by TauZero
Wed Mar 16 21:54:47 2016

Looks like we can use https://godoc.org/github.com/coreos/go-systemd/dbus to interface with systemd.

 Comment by TauZero
Mon Mar 21 22:02:17 2016

Up to the point where only Create remains, and then some review/polish.


Please create log folder in the respective sre-run output directory to avoid filling up install folder

Ask: Please create log folder in the respective sre-run output directory to avoid filling up install folder
Reason: Since root/home hive-sre installation folder is getting filled up very quickly with logs, subsequent runs fail in our automation flow with “out of disk space” error. Can the log folder for respective runs be created in respective output folders?

Application Log output moved to Output directory.


Made ES snapshot deletes synchronous

ES snapshot delete are async. You can only have one inflight
at a time, otherwise you'll get an error:
{
  "error" : {
    "root_cause" : [
      {
        "type" : "concurrent_snapshot_execution_exception",
        "reason" : "[snapshotXX] another snapshot is currently running cannot delete"
      }
    ],
    "type" : "concurrent_snapshot_execution_exception",
    "reason" : "[snapshotXX] another snapshot is currently running cannot delete"
  },
  "Status. 503.
}

This change waits for the delete to happen. Hopefully, some of the pain
from #2568 will be eased.
Closes #2568

i made an assumption. now i'm convinced its wrong

looking at curator, it doesn't check if the snapshot is deleted. It just tries to delete the next one, and retries if that fails. Some discussion in https://discuss.elastic.co/t/curator-delete-snapshot-always-timeout/147637/3


New message from a new contact

When I receive a new message from a new contact, I call wac.Store.Contacts[RemoteJid]
it returns the empty object look like this:
type waHandler struct{
	c *whatsapp.Conn
	jid string
	created uint64
}

func (h *waHandler) HandleTextMessage(message whatsapp.TextMessage) {
	if message.Info.FromMe == false && message.Info.Timestamp >= h.created  {
		contact:= h.c.Store.Contacts[message.Info.RemoteJid]
return  { Jid:"" Name:"" Notify:"" Short:"" }

The Store.Contacts retrieves data from a contact (if) stored on the cellphone of the whatsapp account. If the contact is not stored in the cellphone, it will retrieve empty.

O Store.Contacts recupera dados de um contato (se) armazenado no celular da conta do whatsapp. Se o contato não estiver armazenado no celular, ele será recuperado vazio.

Right. how would I get the name or notification name, I try call Store.Chats(RemoteJid), but not success.

There is no way. The only way to retrieve a contact data is if the cellphone has the contact stored in it. The picture can be retrieved(see #164 ) if the contact has it set to public.

There is no way. The only way to retrieve a contact data is if the cellphone has the contact stored in it. The picture can be retrieved(see #164 ) if the contact has it set to public.

ok my friend thank so much, i will close the issue.


Reflection metadata is not considered for inner bean definitions

If a PropertyValue is a inner bean definition, we don't inspect it to generate reflection metadata for its injection points, if any.

Fixed by 203c7e40fc5762d0


Exercise 5

Am I allowed to modify the Maybe class? Like changing the methods from private to public.

I didn't change any of the given method and was able to finish the exercise just fine

I didn't change any of the given method and was able to finish the exercise just fine

Did u change the methods from private to public? If not, how else did u do your equals method?


Update font-angkor to latest

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thanks for the PRs!


Markdown editor fixes

Coverage remained the same at 40.123% when pulling 9ad62bb7fcf36c6fd63749bc6aafe76219e1f574 on MMP0:patch-36 into 33e90093b766c62faf6239e5ca348f2c3af64a0a on NyaaPantsu:dev.

Changes Unknown when pulling d9b772779a1de30e8a15357c5470ab1ffd4a3fb5 on MMP0:patch-36 into ** on NyaaPantsu:dev**.

Coverage remained the same at 40.123% when pulling d9b772779a1de30e8a15357c5470ab1ffd4a3fb5 on MMP0:patch-36 into 951f94d98880519049bcdbf412c3899e1016bf9d on NyaaPantsu:dev.

Coverage remained the same at 40.123% when pulling 686b91e901bda840dff2f9a0be51550f6b1c8bb8 on MMP0:patch-36 into 44e304977b664c1ea7ef6d76d1924512d2064739 on NyaaPantsu:dev.


Improve DCE behavior.

As discussed here, not only is this slightly faster, it lets DCE know it's supposed to keep these constructor functions.

Do you now if the fields of these classes will still be removed by DCE?
Perhaps we'll need to @:keep each of the classes as well to prevent that?

Based on the article, it should work without any @:keep annotations. The idea is that DCE is able to tell that this is a reference to the constructor, whereas previously it only saw a reference to the class. I assume what happened is it kept the class itself but removed the constructor, and that's why Type.createInstance() failed.


Benchmarking: treat as core topic

At present, only some exercises have benchmarks. In Go, benchmarks are considered core tests, therefore all our exercises should have benchmarks.
I can think of five steps (please point out what I've forgotten or a better way to do it) to addressing benchmarks comprehensively

update the README to include info about benchmarks, including how to write them
review all the current exercises to come up with a checklist of those that don't have benchmarks
add benchmarks to all the exercises that don't have them
add benchmarking as a topic
make sure we have exercises that address benchmarking

Go supports benchmarks with only minimal work.  Exercises which address benchmarking is a really good idea.  There are good things to learn in that regard.   Don't any benchmarking focused exercises need to begin with problem-specifications and be language track independent, at least to start.

Thoughts:

We may have existing problems which address benchmarking, although I can't think of any off the top of my head. I don't think it would be particularly hard to write one.
I looked at the topics list, and there isn't a topic for benchmarking (there isn't even a topic for testing 😭).
As I understand it, a new problem does not have to start with a language independent problem-specification. It depends. Many problems that are added to Exercism are adapted from existing problems found elsewhere, in which case, writing a language independent problem-specification is a viable first step. For a new problem, however, I would be wary of writing (and/or requiring) a generalized version before a language specific version exists.


What pre-processing does the agent itself do for Atari?

Hi,
Thanks for your great repository.
What pre-processing gets done behind the scenes by the agents when playing an Atari game like breakout?  I'm not talking about the pre-processing done by the env object but rather by the agent itself - can anyone point me in the right direction?
e.g. it seems that the env produces observations with pixel values 0-255 so i'm guessing the agent at least divides the pixel value by 255 to make the values in range 0-1?

Hello,

so i'm guessing the agent at least divides the pixel value by 255 to make the values in range 0-1?

you are right. It is in the documentation in fact ;)
In the code, i already answered that question in that issue: https://github.com/hill-a/stable-baselines/issues/328

Thanks a lot. I've added that change but am still unable to get it working for some reason. I've written a colab to show the issue below.
Have you got any ideas why a PyTorch model with the exact same weights as the Baselines model isn't able to play the game properly?   e.g. are there other preprocessing steps that a baselines agent does internally besides normalising to 0-1?
https://colab.research.google.com/drive/1-IIjA1oKUjg5eoctajpl06OoHzU-5-_9

As I wrote to you in https://github.com/araffin/rl-baselines-zoo/issues/31, please open an issue for that, this will easier for other to find it afterward ;)

ok will do that now


Remove StreamsConfig References in StreamsBuilderFactoryBean

Fixed via https://github.com/spring-projects/spring-kafka/commit/55b1eb033ed48f1790b7c092a76b49d6b616de1a


Shift in dem.value_at_coord or dem.show

Describe the bug
There seems to be a diagonal ~ half-pixel shift between the DEM.show() displays and the DEM.value_at_coord() output.
To Reproduce
import xdem
img = xdem.DEM(gu.examples.get_path('everest_landsat_b4'))
target_x, target_y = 486811, 3097050 # example of coordinate
fig,ax=plt.subplots(1,1)
img.show(vmin=50, vmax=200, ax=ax)
ax.set_xlim(target_x-60,target_x+60); ax.set_ylim(target_y-60,target_y+60) # zoom on the area
ax.scatter(target_x, target_y,c='r') # plot the desired coordinate on the image plot
ax.set_title('at ({}, {}), dem.value_at_coords={}'.format(target_x, target_y, np.round(img.value_at_coords(target_x, target_y), 2))) # prints as figure title the value returned by value_at_coords()
ax.plot([486805, 486805, 486805+30, 486805+30, 486805],[3097056,3097056-30, 3097056-30, 3097056, 3097056]) # if coord falls in this blue polygon
ax.plot([486820, 486820, 486820+30, 486820+30, 486820],[3097040,3097040-30, 3097040-30, 3097040, 3097040]) # it returns the value of this orange one
Expected behavior
The value_at_coord() value does not return same value as the plot most of the time, I expect that the value_at_coords() (169 in the example, value of the orange box pixel) matches the show() pixels (131 in the example, under the red point).
System (please complete the following information):

OS: Ubuntu 22
Environment : xdem (0.0.7, 823fff239daa864748677e4d6bcb6bd153c15969 commit), geoutils (0.0.10)

Thanks for the reproducible example, helped a lot!
Found the guilty line: https://github.com/GlacioHack/geoutils/pull/351/commits/326772649c5d6a6c9a3c0bb7e61c1acd4a8bcb60
Turns out our test_value_at_coords function had the same value for neighbouring pixels, and so it went unnoticed. This is fixed as well: https://github.com/GlacioHack/geoutils/pull/351/commits/147363ebe9c3ce53b55a7a7f9407f3219387295a
Will be closed when #351 is merged.


Database creation problem

psql "dbname=eicu user=eicu options=--search_path=eicu_crd" -v ON_ERROR_STOP=1 -f postgres_create_tables.sql
psql: FATAL:  Peer authentication failed for user "eicu"
Makefile:347: recipe for target 'eicu-build-gz' failed
make: *** [eicu-build-gz] Error 2

This error suggests there's a problem connecting to your postgres database using peer authentication. Have you checked that you're running this script as the eicu user? Otherwise, have you tried resolving this issue using another means of authentication? E.g., see https://gist.github.com/AtulKsol/4470d377b448e56468baef85af7fd614.


addPart() stopped working

what did i do to it

oh i just needed to delete the db and let the program remake it because the one i had on my hard drive had an older schema


Add ticket information to site

Either add the below link:
http://bsidesrdu2018.eventzilla.net
Or add the following button widget:
 Register Now
or the following bigger widget:

or this:

Added ticket information to the website via 8241783.


HPCatalogForSMS Issue

I am having issues with MSEndpointMgr downloading the HP Softpaqs.  It was just working a couple of weeks ago but now I am getting a "Start-BitsTransfer : HTTP status 404: The requested URL does not exist on the server" error when starting.  I saw issue #232 and changed the $HPSoftPaqCab variable on line 11956 in the DriverAutomationTool.ps1 file to "https://hpia.hpcloud.hp.com/downloads/sccmcatalog/HpCatalogForSms.latest.cab".  If I go directly to that URL on the server it downloads the file.  When I look in the BITS-client log in Event Viewer it says "BITS stopped transferring the BITS Transfer transfer job that is associated with the https://ftp.hp.com/pub/softlib/software/sms_catalog/HpCatalogForSms.latest.cab URL. The status code is 0x80190194."  So it looks like it is still trying to download from the old URL.  Is there some other place that the download location is set that I am missing?  I am using v6.4.9.

Same problem here...

Same problem here, using 6.5.2.

I have been working around the issue by manually downloading the hpCatalogForSms.latest.cab from https://hpia.hpcloud.hp.com/downloads/sccmcatalog/HpCatalogForSms.latest.cab and extracting the HP CatalogForSms.xml file.  I also manually download the HPClientDriverPackCatalog.cab file from https://ftp.hp.com/pub/caps-softpaq/cmit/HPClientDriverPackCatalog.cab and extract the HPClientDriverPackCatalog.xml file.  I then copy both xml files to the Driver Automation Tool\Temp directory on the server overwriting the existing files.  This allows me to start the program and build my driver packages.  I haven't had time to dig into this any further at this point.

Had the same problem. deleting both HPClientDriverPackCatalog.cab and HPClientDriverPackCatalog.xml solves the issue.


Detecting header

Hello, I'm trying to use your lib in a Vue Single File component, it works very well, thank you for the effort to create this.
However I'm facing an issue, after to apply the header, eslint keep me giving the error, even with the header there.
Examples:
No header, showing the error to be fixed

After to run the --fix, works, the header is there

If I keep running --fix, the header continues to be added sequentially.
Do you have any idea about it?
Ps: Nothing special to be reproduced, just a clean vue3 project, typescript and eslint. All the other rules are working well.

Interesting, I hadn't experienced this behavior. Thank you for pointing out this issue, I will work to reproduce this and find a solution.

The reason this happens is because the plugin will look for a comment block at the beginning of the file, and then insert the missing comment before the first JS AST node. The JS AST no longer starts at the beginning of the file so this check will always fail.

I see, so in other words, it's because is a Vue Single File component and the JS is only inside the tag <script>  so is impossible to put the header in the very first line of the file, right?

Right, the AST content exposed by ESlint will only include valid JS nodes. I would like to continue searching for a solution that could handle non-JS files consistently with JS files, but it will take some time to properly support additional languages. I've introduced a new version of this plugin that fixes the issue you've described (where the plugin produces an error even after the fix is applied), but this still inserts the comment with respect to the JS being linted.

Yeah, at least the process to fix it's working, now is important to understand how the code knows where is the right place to put the header but doesn't know where to search to check if the header is already there.

I spent some time today trying to find parsers for Vue which could produce an AST that would let this plugin detect and parse header comments, but I wasn't able to find any that would support this. Unfortunately, the most popular and well documented Vue parser I could find,vue-eslint-parser, does not support comment nodes. I would prefer to avoid adding logic to perform this work in this project, so I'm not sure when I will be able to better support Vue SFC files. I will mark this issue as closed but am certainly open to enhancing support for Vue.
Feel free to follow up if you have any ideas or experience further issues.


Known limitations text is unclear

The wording of the known limitations text is unclear.  Are sign-in frequency controls respected when a conditional access policy also includes a custom control?
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e03d33c6-c60b-153c-bf76-a127be502170
Version Independent ID: 7bbf1dc5-bd91-d03a-7939-439bfbee85c9
Content: Custom controls in Microsoft Entra Conditional Access - Microsoft Entra ID
Content Source: docs/identity/conditional-access/controls.md
Service: entra-id
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@IanT-UofT
Thanks for your feedback! We will investigate and update as appropriate.

@IanT-UofT
Yes, sign-in frequency controls are respected when a conditional access policy also includes a custom control.
The known limitations text in the documentation likely refers to potential limitations with custom controls themselves, not their interaction with sign-in frequency.
Here's a breakdown:
Sign-in frequency controls: This is a built-in Azure AD Conditional Access feature that defines how often a user needs to re-authenticate based on specific settings.
Custom controls: These are integrations with third-party identity providers or security solutions that extend the capabilities of Conditional Access policies.
Since sign-in frequency controls are a core feature of Conditional Access, they work independently of any custom controls included in the same policy.
Here are some additional points to consider:
The order of policies might affect the evaluation. If a policy with sign-in frequency control is evaluated before a policy with a custom control, the sign-in frequency will be applied first.
Custom controls might introduce additional authentication steps, but they shouldn't interfere with the enforcement of sign-in frequency settings.
Here are some resources for further clarification:
Microsoft Entra documentation on Conditional Access session controls: https://learn.microsoft.com/en-us/entra/identity/conditional-access/concept-conditional-access-session (This page might not explicitly mention custom controls, but it explains session controls which include sign-in frequency)
Microsoft Entra documentation on custom controls: https://learn.microsoft.com/en-us/entra/identity/conditional-access/controls


Update site/README.md to show a better way to install svgbob

Let me merge this since it's very trivial and I'm sure it works.


Can't STOP a crawl

I have a routine where I am looking for a PDF on a site.  Once it is found, I need to STOP the crawl.
How can I do this?
Thanks,
Josh

+1


[New Port Request] plotcpp

Library name:plotcpp
Library description: This is a thin C++ wrapper for gnuplot program, it was made to simplify ploting data from C++ programms in binary format. Now it supprot only a small subset of gnuplot functionality, but allows to pass any gnuplot command as string.
Source repository URL:https://github.com/Kolkir/plotcpp
Project homepage (if different from the source repository): NA
Anything else that is useful to know when adding (such as optional features the library may have that should be included): NA

Not required.


Fix deprecation warnings for abc module in Python 3.7

Fixes #415:

In Python 3, import Mapping from collections.abc, in Python 2 continues to import from collections
Removes an import of collections Iterable since it wasn't being used in the module

Signed-off-by: Dan Yeaw<EMAIL_ADDRESS>

Does someone have time to take a look at this PR? :heart:

@edschofield Is there anything blocking this? :gift:

Thanks for doing this!


[minor] IDE warning 'vue-image-zoomer. d. ts is not a module.'

Hi, thanks for a great module!
When I use the module in a vue 3 / typescript / webpack setting, PHPstorm tells me there is an issue with:
import { VueImageZoomer } from 'vue-image-zoomer';

node_modules/ vue-image-zoomer/ dist/ vue-image-zoomer. d. ts is not a module.

But webpack compiles without errors and it works fine.

nope...

@finnef will look how the declaration file is being built and try to resolve it :) dont use ts myself, bit old school and been left behind with it!

@samjonesigd I'm also getting the same error. Will be helpful if resolved ASAP.

Should be fixed in 2.4.3, if not then ill have to get TS working myself to resolve :)  @smShakil @finnef


Rerunning plotting bug

Reuses windows (?) and combines scenarios

Has this been resolved (over the last 18 months :))?

@cliffckerr  Closing this issue as it's seen no activity for six months.


[CI][Packacking][Java] java-jar nightly builds fail with Connect Reset related to maven-shade-plugin

Describe the bug, including details regarding any error messages, version, and platform.
Following the discussion in https://github.com/apache/arrow/pull/35430#issuecomment-1536756434, the java-jar nightly builds have been failing since 2023-05-05:

<EMAIL_ADDRESS>2023-05-04: https://github.com/ursacomputing/crossbow/actions/runs/4880720274/jobs/8715652875
2023-05-05: https://github.com/ursacomputing/crossbow/actions/runs/4891509316/jobs/8732835157

Error:  Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project arrow-vector:
Execution default of goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade failed:
Plugin org.apache.maven.plugins:maven-shade-plugin:3.1.1 or one of its dependencies could not be resolved:
Failed to collect dependencies at org.apache.maven.plugins:maven-shade-plugin:jar:3.1.1 -> org.ow2.asm:asm:jar:6.0:
Failed to read artifact descriptor for org.ow2.asm:asm:jar:6.0: The following artifacts could not be resolved:
org.ow2.asm:asm:pom:6.0 (absent):
Could not transfer artifact org.ow2.asm:asm:pom:6.0 from/to apache (https://repo.maven.apache.org/maven2/):
Connection reset -> [Help 1]

Component(s)
Continuous Integration, Java, Packaging

I close this because we don't see this problem recently.


Example of custom theme does not work in 2.0.0

Bug, feature request, or proposal:
Example to define a custom theme imports a file that doesn't exist.
@import '~@angular/material/core/theming/all-theme';
https://material.angular.io/guide/theming
What is the expected behavior?
A correct example. I'm still figuring out how to work with custom themes in Angular2.
What is the current behavior?

What are the steps to reproduce?
Install latest via npm and there is no theming folder in @angular2-material/core
 "@angular2-material/core": "^2.0.0-alpha.8-2"

Try: npm install --save @angular/material, @angular2-material/core does not get updates anymore ...

Oh, I see. Got the versions mixed up...

does this issue fixed?


Tokenbuilder for declarative token specifications

All tools are nicely suited for creating simple JWT, but having the configs for multiple recipients on one command line is tricky at best.
What we should have is a token tool that consumes a JSON or YAML file for the different parameters of our token. The tool would have a configuration parameter and accept payload and thats it. This allows one to declare the JWT outcome separately from running the command.
The following example illustrates how a token declaration might look like:
token:
  format: compact
  # global claims and defaults
  iat: now
  exp: 1h
  jwks: my/jwks/default.jwks
  sign:
    - jwks: my/jwks/file.jwks
       kid: mysignkey
       alg: RS256
      # other parameters
      aud: for your eyes only
      claims:
         # application specific claims
    - kid: mydefaultkeyid
       alg: ES256
  enc:
    recipients:
    - jwks: my/friends.jwks
      kid: freds_key
      alg: RSA-OAEP
      # other parameters
      claims:
         # application specific claims
    - jwks: my/friends.jwks
      kid: lauras_key
      alg: RSA-OAEP
      # other parameters
      claims:
         # application specific claims

This will allow users to declare what their token should look like and the tool will create a suitable token.

[ ] The tool should be able to select appropriate default values if configuration is missing.
[ ] The tool should override bad statements (like the format in the example above) with suitable one.

Instead of loose ends the payload should be placed under payload.


Automate the Build of the Page.

Automate the Build of the Page.
Do not sort by stars at all, instead just sort by the scores from the perf tools.
I now have all those tools working via command line, just need to finish connecting the dots.
The only thing that will not be fully automatic is the indicator of which ones have search, for that I will just have an array variable of which themes have the search, and I can add to it whenever a theme implements search.

The script is now fully completed, the only thing left is to setup a cron job, but I will run it manually for a while just to make sure there are not any gotchas.


only drop garbage if there is room

Garbage will not drop until there is room.
Research
This requires game-mechanics research, ask the experts.

[ ] when will garbage not drop?
[ ] is there a delay between next drop or business as usual?

also see related issue #172
garbage will not drop if there is zero room for it in the visible section of the playfield.  That said, it may drop if it can partially (even a fraction of a row) fit in the visible section.
Also consider #108.  During this initial drop (spawn) and each subsequent row drop due to stack-lowering of the garbage block, if when it lands it doesn't completely fit itself on the play field, it causes screen shake (and associated shake time where you can't die)

after a garbage blocks initial drop AND landing are complete, another garbage block may enter the screen.


[TYPES] Rework types to correspond with TypeScript standards

It's not encouraged in TS ecosystem to make importable ambient declaration files for npm packages.
The recommendation is to make typings for the package itself.
This PR adheres to this recommendation (enabling an implicit typings support in a TS-friendly environment) while adding and fixing TinySlider instance types according to the documentation. This fixes #292.

Bonus backward-compatible feature - rebuild() with new options. rebuild(options) now accepts an optional options parameter which helps with handy slider reinstantiation using different settings.

@ganlanyuan, what do you think?

No need to pass new options to rebuild(), since its purpose is to use original options.
If someone need to pass new options, just run a new tns():
var slider = tns(…);
slider.destory();
slider = tns(newOptions);

So could you remove the newOptions from rebuild()?
Thanks

Okay, I'll just leave the types fix then.

@ganlanyuan, done.

NPM patch time, I guess?..


Write profiles documentation

Follow up task of https://github.com/freme-project/Broker/issues/96

We do not need profiles when we have the new architecture


Support colorblind mode

Support colorblind mode
Daltonization algorithm copied from EdenEast/nightfox.nvim

Nice job, I have to make some tests before merging

Made some refactorting here : #15
It's merged as an experimental feature :)
Thanks a lot for your work !


chore(chat): Refactor IconUrl without api prefix (Issue #2060)

Description:
Need to save iconUrl for custom applications without api/ prefix
Issues:

Issue #2060

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


Enable composeModelMatrix for meshlayers

Background
For v8 API audit

Change List

compose modelMatrix with instance modelMatrix for mesh layers
add tests
update documentations
update mesh example app

Coverage increased (+2.3%) to 83.683% when pulling be19018f3ba654171d3e1e49245b427faae0538d on xx/mesh into 96036f8eb264c5e2bc6005c8984ddc79982f18d2 on master.


Inline methods from a library is not fully covered

Hello 👋
I have recently moved my all asserts below
assertTrue { it is SomeClass }

with
assertIs<SomeClass>(it)

assertIs is an inline method in Kotlin Stdlib and covered: https://github.com/JetBrains/kotlin/blob/6a670dc5f3/libraries/kotlin.test/common/src/test/kotlin/kotlin/test/tests/BasicAssertionsTest.kt#L323-L357
But my overall coverage decreased. It seems like Kover is not recognizing this for the inline methods. It behaves like I do own this method, and there is no test written for inline methods of other libraries.
In case you want to see the PR: https://github.com/Oztechan/CCC/pull/511

Hi, sorry for the delay,
could you please indicate the names of the functions whose coverage disappeared after the changes were made?
The final coverage takes into account only the function invokes of your project, the function calls of the standard library are not included in the report.
A call of this type does not affect the percentage of coverage in any way because no project functions are called inside the block.
assertTrue { it is SomeClass }

Hello @shanshin thank you for your message, meanwhile I think I put the title wrong, just updated.
So here are my reports:
https://codecov.io/gh/Oztechan/CCC/compare/d7295893f5b302e5293da52a671a9fc6cc76aa56...8144e243a3fa7c305005c4c5c3b544f7b360b08d/diff
in case you are not able to see the reports, I am attaching a sample screenshot too:

As you can see, all the new lines are partially covered and overall class coverage is decreased.

@mustafaozhan, do you use only codecov to analyze the percentage of project coverage?

Usually evaluating coverage  for tests from 'commonTest' source set not make sense. In the future releases, this will be excluded from the report (same as a 'test' source set).
It was not possible to reproduce the error locally
assertIs<Any>(it)

the line is completely covered.
Perhaps the problem is in displaying coverage in codecov, an example of an XML report would be useful.

Hey @shanshin here is my coverage report, I couldn't upload here.
https://gist.githubusercontent.com/mustafaozhan/153a54519478ba4cc57e09d7878f549b/raw/67784289c98d408b2c9f6ba58652b12444299ea7/report.xml

Fixed in 0.6.0, feel free to reopen if the problem reproduced again.


Change TokenNetwork to TokenNetworkERC20

We will have a TokenNetwork library with the core code and multiple contracts that use TokenNetwork but implement the specified token interface. E.g. TokenNetworkERC20

Is this basically string replacements all over?  Then I can take it.


Hide VLT checkout logging

and show it only when gradle is executed with '-i'
maybe this will be helpful: https://docs.gradle.org/current/userguide/logging.html#logging_with_slf4j

very minor priority, closing. reopen if needed


Fix settings not being reflected in Docker containers

Fixes #193
After the initial docker-compose up -d ... instructed in Running lintreview services in Docker
 the web and worker containers don't recognize any changes in settings.py

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   88.77%   88.77%
=======================================
  Files          41       41
  Lines        2084     2084
=======================================
  Hits         1850     1850
  Misses        234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5368002...3bbd006. Read the comment docs.

IMHO mounting a file is not a good idea. Containers should be exactly that: contained. If you need to change settings, rebuild and re-deploy your container.
This would be especially troublesome in Swarm mode, where the container might die and pop up on another host that doesn't have that local file. Luckily, swarm mode has configs which are the proper way to handle this.

Closing as @sjawhar raises a good point. Docker based deploys should use environment variables and not a mounted settings file.


Introduce Kino.start_child

Today, if we call start_link in a cell, as we reevaluate the cell, we will leak processes. The idea is to expose a Kino.start_child, that accepts a child specification, and starts it associated to the current cell. This way, if the cell needs to be re-evaluated, we terminate the processes before re-evaluating it.

Closed via #50.


Add long-term loan flag to Loans

Implements #3746.
I added references to long-term loan everywhere I could find a reference to "gift", so it should be included everywhere.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (821241a) 85.74% compared to head (5880be3) 59.78%.

:exclamation: Current head 5880be3 differs from pull request most recent head 4fab8b7. Consider uploading reports for the commit 4fab8b7 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##           development    #3747       +/-   ##
================================================
- Coverage        85.74%   59.78%   -25.96%
================================================
  Files             2039     1535      -504
  Lines            75487    46804    -28683
================================================
- Hits             64723    27980    -36743
- Misses           10764    18824     +8060

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.