Gym API?

Hey, noob question here:
Is there an example showing how to interface with brax the same way you would with a gym Env?
If not, then why? Is there any particular reason why you make  your own Env class rather than create a new gym.Env subclass?

Hello Fabrice,
JAX's functional semantics make it a bit tricky to implement the gym API where the Env itself is supposed to maintain state, and still work for end-to-end training.
But the good news is that you can easily create gym Environments by calling create_gym_env in place of create_env, which will wrap the environment with a gym.Env.  See:
https://github.com/google/brax/blob/main/brax/envs/wrappers.py

Interesting. I'd suggest creating a simple example notebook/script where this gets used.
Other questions:

Does this GymWrapper support rendering? If not, are there plans for adding support for it (which seems to already be present for the other envs?)
What is the right way of "scaling up"/vectorizing this GymWrapper? (I assume you wouldn't want users to pass it to one of the  gym.vector.VectorEnv subclasses, for instance?)
How well would you expect this GymWrapper to "scale" compared to the jax-only version?

Right now we only support visualization via the three.js webview.  Actual rendering - as in a python function that returns an image buffer - is on our roadmap!  But don't have an ETA yet.
re: vectorizing, we have only used to gym wrapper for CPU training on multi-process envs, so no batching dimension in the gym env.  That said, VectorEnv class looks good.  We could extend the create_gym_env to return VectorEnv if you specify a batch dimension.  Feel free to submit a PR if that would be helpful to you.
performance: as long as you're careful to avoid copying data between CPU and accelerator (for example, by ensuring your learner is jitted too, and that the actions you pass to step are on device), then there should be no runtime performance penalty to using a gym wrapper, just a very small jit time cost for a bit of extra function tracing.

OpenAI/StableBaseline VectorEnv automatically calls reset on a worker when the episode finished.
In brax however I guess that because how vmap works one needs to check if a given episode in the batch is done and treat this on the agent side (e.g.: ignore data from finished episodes in the batch) since there is no way to reset a single episode in the batch, right?
Thank you!

Hi @floringogianu - yes, we leave it up to the user to decide how to reset.  For the case of training, we actually do reset individual episodes within a batch.  We support this in the training env wrapper, see here:
https://github.com/google/brax/blob/main/brax/training/env.py#L57

Thank you for the quick reply and for pointing to that example.


build some help scenes. people have no idea how the skeleton works

can we pull help scenes from the Microsoft Kinect documentation

Make it more clear how to stand/interact so the kinect can easily recognize the climber


Cuda C side calculations for complex numbers

Need to finish cuda functions for the cuda kernels.

Did this tag get closed?

Issue still open. Complex numbers have fallen in priority since we migrated convolutions away. The boiler plate is there.

https://github.com/deeplearning4j/nd4j/issues/555


update cli, gh action, and docs to include all features

I'm updating rich-click docs right now.
Having working_dir: as an option in the Github Actions would be extremely helpful. For now I need to do either
<!-- RICH-CODEX working_dir: . --> or use a fake_command on literally every command in the docs to make it work the way I want. Adding working_dir: "." to the GH action would be great.
While I was at it, I also updated the table to reflect everything available in the CLI, as I noticed it wasn't in parity.

Update: won't use these for rich-click docs after all, but they're still good changes.

Woops, forgot to run pre-commit. Did so!

Running into an actual issue this time.

This started happening when I added | fold -w 120 to the command output. 🤔
I wonder if we can just add a --fold parameter instead?

Never mind the --fold parameter, I found via Google a unicode-safe way to do that.
Also, give this PR a few minutes... I'm making some more changes.

Ready for re-review!


how can i use isso in django?

hello there, i wanna use isso in my blog, which is build by django,  can u give me some help?

@supertpx hi, have you figured out how to install isso on django?)


[DNS] listing zones does not work

Description
When running openstack dns zone list, following error is shown (with --debug):
'ZoneController' object is not callable
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/cliff/app.py", line 415, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python3.9/site-packages/osc_lib/command/command.py", line 39, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python3.9/site-packages/cliff/display.py", line 117, in run
    column_names, data = self.take_action(parsed_args)
  File "/usr/lib/python3.9/site-packages/otcextensions/osclient/dns/v2/zone.py", line 68, in take_action
    data = client.zones(**query)
TypeError: 'ZoneController' object is not callable
clean_up ListZone: 'ZoneController' object is not callable
END return value: 1

Versions
Python 3.9.1
openstacksdk: 0.53.0
otcextensions: 0.13.0

I tried it with:
openstackclient==4.0.0
openstacksdk==0.55.0
otcextensions==0.13.0
Python 3.8.5
it is working as expected. Could you notify me if it is still an issue for you.

Reproducing right now with
OpenStack 5.4.0
OTC extensions 0.13.0
OpenStackSDK 0.55.0

Could you provide the output openstack: --os-cloud machine dns zone list --debug
via WebEx pls.

The issue reproduces when there is python-designateclient installed:
...
Installing collected packages: python-designateclient
Successfully installed python-designateclient-4.2.0

~ ⌚ 16:22:58
$ openstack --os-cloud machine dns zone list
'ZoneController' object is not callable

~ ⌚ 16:24:15
$ sudo pip uninstall python-designateclient
Found existing installation: python-designateclient 4.2.0
Uninstalling python-designateclient-4.2.0:
  Would remove:
    /usr/lib/python3.9/site-packages/designateclient/*
    /usr/lib/python3.9/site-packages/python_designateclient-4.2.0.dist-info/*
Proceed (y/n)? y
  Successfully uninstalled python-designateclient-4.2.0

~ ⌚ 16:24:59
$ openstack --os-cloud machine dns zone list -c status
+--------+
| status |
+--------+
| ACTIVE |
| ACTIVE |
| ACTIVE |
...

this is known "bug" in the connection of different clients. It all depends on the order of installed packages. Normally you should not install "openstackclient", but "python-openstackclient" only. Then this will not happen, and you will avoid similar problems in every other case that works in OTC different compared to OpenStack

I suppose, this should be mentioned in the installation guide: https://python-otcextensions.readthedocs.io/en/latest/install/pip_install.html#id1 There are some mentions of openstackclient


Stories folder restructuring

Moves all stories to component named subfolder under /stories folder
Moves any story assets in /stories/assets
Moves any story components into /stories/components

@libertymayc Seems like there are some conflicts to resolve


Use getEntityKey instead of buildEntityKey

Signed-off-by: Vítor Avelino<EMAIL_ADDRESS>Fixes #3755

There are some WARNING in Circular dependency detected: when building the app.

There are some WARNING in Circular dependency detected: when building the app.

I reverted 4 of the 14 changed files back to what it was before and added a note as we discussed.


fix lobby style so that all elements are on same height

closed by https://github.com/sopra-fs23-group-13/meme-it-client/compare/main...84-fix-lobby-style-so-that-all-elements-are-on-same-height


Third Edition of "Python for Probability, Statistics, and Machine Learning"

Sorry, I haven't found the github page for the 3rd edition of your above-mentioned book. So I'm making here a comment on a typo in the 3rd edition.
On page of 48 of the 3rd edition, "Lesbesgue theory" should read "Lebesgue theory".

Thanks! I'll fix it in the next edition.


[NoSsr][base] Convert code to TypeScript

Convert the NoSsr and related modules (everything inside mui-base/src/NoSsr) to TypeScript, to increase consistency with other MUI Base components.
There should be no functional changes.
Use other components as a reference.

Hi @michaldudak. Can I take this issue?

Sure, go ahead!


Can we get a license on this?

Hi there! I'm hoping to use this as a basis for a small project but I'm not sure what the legal implications would be. I'm assuming that you're intending for this to be freely usable, so would you mind adding a license? Thanks!

@nwkotto Done. 👍
Please share your project whenever maybe I'll add it to the README or something. 🤷♀

Awesome, thanks (and for the quick response)! Will see how it pans out and will let you know if we do make some progress. Thanks for creating this boilerplate -- really saved us some time.


error reading config file at circle.yml: open .circleci/config.yml: no such file or directory

I've got a repository with a circle.yml file in its topmost directory. Builds work fine on circleci.com, but I get this error when trying to run them locally:
$ circleci build

FATA[2018-05-25T15:43:44Z] failed to compute task config                 error="error reading config file at circle.yml: open .circleci/config.yml: no such file or directory"

Would it be possible to add support for ./circle.yml rather than enforcing ./.circle/config.yml?

./circle.yml is a CircleCI 1.0 configuration file. The CircleCI Local CLI is a tool for CircleCI 2.0 so that will not be supported.

Hmm, ok. IMO since the webapp supports it, it'd be really nice if the local tool did too, but I understand not wanting to maintain multiple code paths.
Oh well, thanks anyway!

You can set the path to the config file yourself, if you want, with the -c flag.

Thanks Daniel, I must have overlooked that flag!

@stephenmathieson CircleCI 1.0 will be EOL and thus won't run by the end of August. This is why we can't justify adding support.
@dnephin Still won't run. The Local CLI can't build CircleCI 1.0 projects.

@felicianotech my ./circle.yml file contains v2 configuration

@stephenmathieson Really? Oh okay that's strange. Then yes that changes everything. The flag Daniel pointed out will work for you then. Sorry, that's the default filename for 1.0 so I thought it was a 1.0 config.

Cool, thanks for clarifying!


Ability to fully manage wifi subsystem

From @GoogleCodeExporter on May 31, 2015 11:28
Right now we can get a list of found hotspots with wifiGetScanResults, but
cannot choose what AP to connect to. With that option it could be easy to code
a priority list, for example, and automatize the selection of which AP to
connect to based on whatever needs you have.

Thank you for the great work!

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 5 Feb 2011 at 1:44
Copied from original issue: damonkohler/android-scripting#513

From @GoogleCodeExporter on May 31, 2015 11:28
Is there any update on this ?

Original comment by<EMAIL_ADDRESS>on 21 Feb 2014 at 6:16


Obsolete modulation by host of symbiont adenylate cyclase activity

Please provide as much information as you can:

GO term ID and Label
GO:0075075 (modulation by host of symbiont adenylate cyclase activity)

Reason for deprecation
It has no annotations (http://amigo.geneontology.org/amigo/term/GO:0075075) and I cannot determine that this capacity in a host has ever existed.

"Replace by" term (ID and label)
If all annotations can safely be moved to that term

"Consider" term(s) (ID and label)
Suggestions for reannotation

Are there annotations to this term?

How many EXP: 0

Are there mappings and cross references to this term? (InterPro, Keywords; check QuickGO cross-references section)

Is this term in a subset? (check the AmiGO page for that term)

Any other information
This term has two children that cover negative and positive regulation by host of symbiont adenylate cyclase activity. They have no annotations should be ditched as well.

Hello,
I propose to obsolete all classes 'modulation by organism of other organism molecular function that are not used.
These term have no annotations and can be obsoleted now:
Not used, to obsolete
induction by symbiont of host catalytic activity
induction by virus of host catalytic activity
induction by virus of host endoribonuclease activity
induction of autolysin activity in other organism
modulation by host of symbiont adenylate cyclase activity
modulation by host of symbiont peptidase activity
modulation by symbiont of host adenylate cyclase activity
modulation by symbiont of host peptidase activity
modulation by virus of host catalytic activity
modulation of peptidase activity in other organism involved in symbiotic interaction
negative regulation by host of symbiont adenylate cyclase activity
negative regulation by host of symbiont catalytic activity
negative regulation by host of symbiont peptidase activity
negative regulation by symbiont of host adenylate cyclase activity
negative regulation by symbiont of host catalytic activity
negative regulation by symbiont of host peptidase activity (2 annotations; deleted)
negative regulation of catalytic activity in other organism involved in symbiotic interaction
negative regulation of peptidase activity in other organism involved in symbiotic interaction
positive regulation by host of symbiont adenylate cyclase activity
positive regulation by host of symbiont catalytic activity (1 annotation; deleted)
positive regulation by symbiont of host adenylate cyclase activity
positive regulation of catalytic activity in other organism involved in symbiotic interaction (1 annotated; deleted)
suppression by virus of host ATP-dependent RNA helicase activity
suppression by virus of host protein kinase activity
suppression by virus of host protein tyrosine kinase activity

I need to review the following with @pmasson55
induction by virus of host cysteine-type endopeptidase activity involved in apoptotic process
modulation by virus of host PP1 activity
modulation by virus of host protein serine/threonine phosphatase activity
modulation by virus of host ubiquitin-protein ligase activity
negative regulation by host of viral exo-alpha-sialidase activity
suppression by virus of host catalytic activity
suppression by virus of host cysteine-type endopeptidase activity involved in apoptotic process
suppression by virus of host JAK1 activity
suppression by virus of host PKR activity
suppression by virus of host TBK1 activity
suppression by virus of host TYK2 activity
These will remain as grouping classes
modulation by host of symbiont catalytic activity
modulation by symbiont of host catalytic activity
Thanks, Pascale

Merged

GO:0052405 negative regulation by host of symbiont molecular function (no annotations) into
GO:0052403 negative regulation by host of symbiont catalytic activity

and

GO:0052428 modulation by host of symbiont molecular function
GO:0052422  modulation by host of symbiont catalytic activity
namespace: biological_process

After discussion with @pmasson55 , I will fix other terms under 'GO:0052205 modulation of molecular function in other organism involved in symbiotic interaction' in different tickets.


[$2000] Prefix and value are not aligned in Room name input

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to + > New room

Expected Result:
# prefix and input value should be vertically aligned
Actual Result:
# prefix and input value are not vertically aligned
Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.60-0
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: chiragsalian
Slack conversation: https://expensify.slack.com/archives/C03TQ48KC/p1674843422126589?thread_ts=1674842607.782939&cid=C03TQ48KC
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0126bc590fd5d06fe2
Upwork Job ID:<PHONE_NUMBER>969490432
Last Price Increase: 2023-02-07

Proposal
After #12447, border bottom line height set to 2. This is the main root cause.
Input height is now 52 including bottom line.
We can adjust vertical paddings based on preference of space between label and input text.
Solution1: (adjust paddingBottom)

update paddingBottom of textInputPrefix to 7
https://github.com/Expensify/App/blob/703b5c4bd262d11f8467cbd7b3959df3bac03633/src/styles/styles.js#L824
update paddingBottom of baseTextInput to 9
https://github.com/Expensify/App/blob/703b5c4bd262d11f8467cbd7b3959df3bac03633/src/styles/styles.js#L769
update paddingBottom of picker to 9
https://github.com/Expensify/App/blob/703b5c4bd262d11f8467cbd7b3959df3bac03633/src/styles/styles.js#L29

This solution guarantees that:

input container height (including 2px bottom border) = 52
paddingTop = 23
paddingBottom (excluding 2px bottom border) = 7
input text height = 20

Solution2: (adjust paddingTop)

update paddingTop of textInputPrefix to 24
https://github.com/Expensify/App/blob/703b5c4bd262d11f8467cbd7b3959df3bac03633/src/styles/styles.js#L823
update paddingBottom of textInputPrefix to 6
https://github.com/Expensify/App/blob/703b5c4bd262d11f8467cbd7b3959df3bac03633/src/styles/styles.js#L824
update paddingTop of baseTextInput to 24
https://github.com/Expensify/App/blob/703b5c4bd262d11f8467cbd7b3959df3bac03633/src/styles/styles.js#L768
update paddingTop of picker to 24
https://github.com/Expensify/App/blob/703b5c4bd262d11f8467cbd7b3959df3bac03633/src/styles/styles.js#L30
And also adjust multiline input style:

    textInputMultiline: {
-       scrollPadding: '23px 0 0 0',
+       scrollPadding: '24px 0 0 0',
    },

    textInputMultilineContainer: {
-       paddingTop: 23,
+       paddingTop: 24,
    },

This solution guarantees that:

input container height (including 2px bottom border) = 52
paddingTop = 24
paddingBottom (excluding 2px bottom border) = 6
input text height = 20

I prefer Solution 1
NOTE: this proposal is based on inputHeight is set to 52. If we should change this value, proposal can be updated accordingly.
Need confirmation from design team.

@aldo-expensify @mananjadhav when you have some time please have a look at the proposals being posted. I'm posting here so that the "overdue" label gets removed.

Proposal
Apply same height as Input and in this case it will be 52, to match the same level vertically align it to the center.
diff --git a/src/styles/styles.js b/src/styles/styles.js
index 4b1d1982ae..87f4617253 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -819,7 +811,10 @@ const styles = {
textInputPrefix: {
         position: 'absolute',
         left: 0,
         top: 0,
-        height: '100%',
+        height: variables.inputHeight,
+        display: 'flex',
+        alignItems: 'center',
         paddingTop: 23,
         paddingBottom: 8,
         color: themeColors.text,

Proposal
Problem
Here is the style of prefix. The height is 51 (20 + 8 + 23)

But the height of text input is 52

Solution
We shouldn't change the padding value of input or prefix, they should be same. That why I want to update the lineHeight of prefix:
In https://github.com/Expensify/App/blob/main/src/components/TextInput/BaseTextInput.js#L258-L268
In this case the height of prefix is 52

                                       <Text
                                            pointerEvents="none"
                                            selectable={false}
                                            style={[
                                                styles.textInputPrefix,
+                                               {lineHeight:this.state.height - 31},
                                                !hasLabel && styles.pv0,
                                            ]}
                                            onLayout={this.storePrefixLayoutDimensions}
                                        >
                                            {this.props.prefixCharacter}
                                        </Text>

Result

Thanks for the proposals folks. I don't think we should fiddle with the padding. We could change the height or the line height.
I am going to tag @Expensify/design to have a look on what's the right way to handle this.

we also can create the new variables for the padding-top and padding-bottom as I can see we use these variables at many places

@Expensify/design Can someone please help if we want to update the padding or the height of the input?
cc - @aldo-expensify

Hm, it seems like we doubled this unnecessarily. @aldo-expensify @shawnborton what's your take on this?

Hm, it seems like we doubled this unnecessarily.

This is new to me, but it makes sense considering the SO. The issue already has a few proposals from which we will likely pick one, and the issue seems to be pretty simple work.

@aldo I believe until we select a proposal and assign the contributor to the issue this will be interpreted as not having any proposals yet.
Which contributor do you and @mananjadhav select as having the best solution? Please assign them to the GH!

@aldo I believe until we select a proposal and assign the contributor to the issue this will be interpreted as not having any proposals yet.

Oh! I didn't know that

Which contributor do you and @mananjadhav select as having the best solution? Please assign them to the GH!

None for the moment. I was waiting to see if @shawnborton had some insight on which direction it was better to go (this question)

I think it makes sense to only update the style of the prefix and not change the padding on the input itself.

Thanks for the feedback @shawnborton. With the given proposals I think @Pujan92's proposal of setting the height equal as inputHeight is simple and straightforward.
cc - @aldo-expensify @shawnborton

@mananjadhav that proposal is relying on changing style and alignment too:
display: 'flex',
alignItems: 'center',

I'm just wondering if it is just safer to change the lineHeight or padding of the prefix from a support/compatibility perspective. Maybe my concern is completely unfounded and flex/center will work perfect all the time. Do you have some thoughts on that? :)

@aldo-expensify IMO this is a more generic solution irrespective of the line-height for the prefix text.

Ok, lets go with https://github.com/Expensify/App/issues/14632#issuecomment-1410854087

📣 @Pujan92 You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@mananjadhav @aldo-expensify PR is ready for review!

Merged! thanks @Pujan92 !

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.70-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/14983

If no regressions arise, payment will be issued on 2023-02-20. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mananjadhav / @aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mananjadhav / @aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mananjadhav / @aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@Pujan92] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Switching this back to daily.

Update testrail test adding a step to verify the alignment of the #:

I don't think it is worth discussing further steps on how to prevent this. It is very minor miss-alignment and including a new checklist step like If you modified the style of a text input, check that the room name prefix # is still aligned is too specific / low value to be added there.

@Pujan92 created the PR on Feb 9th and merged on Feb 10th so eligible for 50% bonus. I'm going to keep the payment at $1000 + $500 bonus since the issue only doubled due to Aldo not assigning @Pujan92 right away when in reality we had enough proposals and didn't need to double the offer.
@Pujan92 and @mananjadhav I'll issue payment for $1000 + $500 do you agree with the above?

Yes @flaviadefaria it makes sense as the proposal we chose and shortlisted was the one before we doubled the issue:

Thanks for the payout @flaviadefaria

@Pujan92 @mananjadhav you're both paid so closing this GH.


Nest redundant  ion-nav-view in ionTabs, state name format issue.

I found nest redundant  ion-nav-view  when I debug ion-tabs.
<ion-nav-view name="game" ...>
  <ion-nav-view ..>
     <ion-view>

After drive deeply,  there is a wired name composition in navViewController.js:42
if (navViewName.indexOf('@') < 0) navViewName = '@' + parentViewName + '.' +navViewName;

I  traced $state.$current.locals at navView.js:185,  it has different statename format
$state.$current.locals =
 .....
<EMAIL_ADDRESS>Object

Obviously,  game@app dont match @app.game,  if I fix statename format,  nest  ion-nav-view is gone
<ion-nav-view name="game" ...>
     <ion-view>

Is it bug?

Greetings @janckerchen!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Hey @janckerchen, thanks for the research. Can you put together an example codepen that demonstrates the issue?

I wakeup and calm down, go back the issue.  I must  apologize, there is abstract state with inline template in my states define which add ion-nav-view. so just forget it.


#837: Changed type of exception

Closes: #837
Changed the exception, that is thrown when there is no git installation from IllegalStateException to CliException

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
24 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 67.265%

Files with Coverage Reduction
New Missed Lines
%

com/devonfw/tools/ide/git/GitContextImpl.java
24
63.64%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
6565

Relevant Lines:
9410

💛  - Coveralls


ScreenSaver does not comply with Energy Saver presets

Hi, amazing ScreenSaver, but I have noticed that the screenSaver does not comply with the Energy Saver presets. If the ScreenSaver is running and a preset to put the display to sleep is set for a given period of time, the display will never go to sleep. Hope you can fix this...

There was a bug with this a while ago, but John fixed it.
Are you running the current version? https://github.com/JohnCoates/Aerial/releases

Evidently not.. ;-)
Thanks. just downloaded the latest version, I was running a Beta.
The download locations in GitHub are a little convoluted.
JC

On Dec 29, 2016, at 11:13, Alistair McMillan<EMAIL_ADDRESS>wrote:
There was a bug with this a while ago, but John fixed it.
Are you running the current version? https://github.com/JohnCoates/Aerial/releases https://github.com/JohnCoates/Aerial/releases
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/JohnCoates/Aerial/issues/296#issuecomment-269643732, or mute the thread https://github.com/notifications/unsubscribe-auth/AXrY8C6X_Ep-FwABPwBPqixrM-HXC36Mks5rM84kgaJpZM4LXpKG.

Cool. If you're happy feel free to close this issue. :)

Everything working OK now...


[2009] Edit course accredited body

Context
We'd like the ability to modify a course's accredited provider, in order to do this the frontend requires a list of all the accredited providers for a given provider's courses and the ability to update the accredited provider's course.
Changes proposed in this pull request
Permit the modification of a course's :accredited_provider_code, also add testing to afford some confidence when editing providers serialisation for accrediting bodies & course updating in future.
Guidance to review
Checklist

[X] Make sure all information from the Trello card is in here
[X] Attach to Trello card
[X] Rebased master
[X] Cleaned commit history
[X] Tested by running locally

 Edit course accredited body

Where in this PR is the bit that does:

list of all the accredited providers

@fofr It already did that, I just needed to add a test for it https://github.com/DFE-Digital/manage-courses-backend/blob/376ac19a5c46b3b6e2192f78d044432201460d21/spec/serializers/api/v2/serializable_provider_spec.rb#L22


Environment not being reset in main.py

Hi,
I just feel this is an issue, that when done variable is true, the env.reset is not called, which can cause problems if I'm not wrong, unless problem is infinite horizon and every state can visited with non-zero probability.

#162 Does this answer your question?


Throws ENOTSUP if asked to parse a torrent located on a Windows network drive

Running test/fs.js:
not ok 1 Error: ENOTSUP: operation not supported on socket, scandir 'T:\code\github\create-torrent\node_modules\webtorrent-fixtures\fixtures\Leaves of Grass by Walt Whitman.epub'
  ---
    operator: error
    expected: |-
      undefined
    actual: |-
      { [Error: ENOTSUP: operation not supported on socket, scandir 'T:\code\github\create-torrent\node_modules\webtorrent-fixtures\fixtures\Leaves of Grass by Walt Whitman.epub'] errno: -4049, code: 'ENOTSUP', syscall: 'scandir', path: 'T:\\code\\github\\create-torrent\\node_modules\\webtorrent-fixtures\\fixtures\\Leaves of Grass by Walt Whitman.epub' }
    at: end (T:\code\github\create-torrent\node_modules\run-parallel\index.js:16:15)
    stack: |-
      Error: ENOTSUP: operation not supported on socket, scandir 'T:\code\github\create-torrent\node_modules\webtorrent-fixtures\fixtures\Leaves of Grass by Walt Whitman.epub'
          at Error (native)

Where T:\ is a shared drive on Windows .
I will further investigate this issue.

Fixed by https://github.com/feross/create-torrent/pull/52

3.26.1


Remove optimizer for DeepSpeed inference

Refactor/Feature
Recently in DeepSpeed it was merged to support making the optimizer optional for inference https://github.com/microsoft/DeepSpeed/pull/1514.
Currently in our plugin we pass in an optimizer always: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/plugins/training_type/deepspeed.py#L573. This is required to partition the parameters appropriately, however this shouldn't be needed now :)
We should wait till a release is made for DeepSpeed. Also we need to be cautious if the user uses a later version of deepspeed and does require an optimizer to be passed. @carmocca do you think we need a deprecation process for this?
Motivation
Cleaner code, and probably less hacky.
cc @borda @justusschock @awaelchli @akihironitta @SeanNaren

@carmocca do you think we need a deprecation process for this?

In the past, we have updated our minimum required versions for 3rd party packages (jsonargpare, fairscale, ...) without deprecations for them. Unless you think there's enough difference between the 2 DeepSpeed versions so that it's worth supporting both, I would just update it.


EO was up to 0.29.4

PR-Codex overview
Focus of this PR:
This PR focuses on making changes to several EO files in the codebase related to collections, such as list, multimap, map, range, set, and hash-code-of.
Detailed summary:

In list-tests.eo, the values in the list are changed from a and b to 10 and 500.
In multimap.eo and map.eo, the elements-amount method is replaced with an if statement.
In range-of-ints.eo, the range object is modified to accept start and end arguments instead of an empty list.
In range.eo, the range object is modified to accept start and end arguments instead of an empty list.
In set.eo, the lst.is-empty method is replaced with reduced. and at..
In hash-code-of.eo, the rec-hash-code method is modified to use the hc object instead of an empty list.
In range-tests.eo, the simple-range, range-with-floats, range-with-out-of-bounds, and range-with-wrong-items-is-an-empty-array methods are modified to accept start arguments instead of an empty list.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Graur you can close this one because #204 is merged

@maxonfjvipon Yep, thanks!


🎉 Release 2.0.0

2.0.0 - 2023-09-10
💥 Breaking changes

Move "skip ci" logic into global pipeline conditions [#2216]
Deprecate "platform" filter in favour of "labels" [#2181]
fail hard on deprecated pipeline keys [#2180]
client lib: remove useles "sync" option from RepoListOpts [#2090]
Drop deprecated built-in environment variables [#2048]

🔒 Security

Check permissions on repo lookup [#2357]
Change token logging to trace level [#2247]
Validate webhook before change any data (#2221) [#2222]
Validate webhook before change any data [#2221]
Fix WOODPECKER_GRPC_VERIFY being ignored (#2077) [#2082]

✨ Features

Add repos list for admins [#2347]
Add org list [#2338]
Add option to configure tolerations in kubernetes backend [#2249]
Support user secrets [#2126]
Add opt save global log output to file [#2115]
Add ping command to server to allow container healthchecks [#2030]

🐛 Bug Fixes

Fix: change tasks.task_data column type to longblob in mysql [#2418]
Fix health check [#2412]
Do not list archived repos for all forges [#2374]
fix(server/api/repo): Fix repair webhook host [#2372]
Delete repos/secrets on org deletion [#2367]
Fix org fetching [#2343]
Show correct event in pipeline step list [#2334]
Add min height to mobile pipeline view and fix overflow [#2335]
Fix grid column size in pipeline log view [#2336]
Fix button loading spinner when activating repos [#2333]
Fix migration [#2319]
make WOODPECKER_MIGRATIONS_ALLOW_LONG have an actuall effect [#2251]
Docker build dont ignore ci env vars [#2238]
Handle parsed hooks that should be ignored [#2243]
Set correct version for release branch releases [#2227]
Bump default git clone plugin (#2215) [#2220]
Bump default git clone plugin [#2215]
Show all steps (#2190) [#2191]
Show all steps [#2190]
Fix pipeline config collapsing [#2166]
Fix 'add-orgs' migration (#2117) [#2145]
Fix 'add-orgs' migration [#2117]
Fix UI and backend paths with subpath (#1799) [#2133]
Fix vite server [#2134]
Fix UI and backend paths with subpath [#1799]
docs: Environment Variable Seems to be DOCKER_HOST, not DOCKER_SOCK [#2122]
Fix swagger response code (#2119) [#2121]
Fix swagger response code [#2119]
Forge Github Org: Use login instead of name (#2104) [#2106]
Forge Github Org: Use login instead of name [#2104]
Fix translation key [#2098]
client.go: Backport fix RepoPost path [#2100]
client.go: Fix RepoPost path [#2091]
Fix alt text contrast in code boxes [#2089]
Fix WOODPECKER_GRPC_VERIFY being ignored [#2077]
Handle case where there is no latest pipeline for GetBadge (#2042) [#2050]
Handle case where there is no latest pipeline for GetBadge [#2042]

📈 Enhancement

close sidebar on outside click [#2325]
Use API error helpers and improve response codes [#2366]
Import packages only once [#2362]
Only show commit title [#2361]
Use full width header on pipeline view and show repo name [#2327]
Show that repo is disabled [#2340]
add spacing to pipeline feed spinner [#2326]
make: autodetect host platform [#2322]
Add "plugin" support to local backend [#2239]
Rename grpc pipeline to workflow [#2173]
Pass netrc data to external config service request [#2310]
Create settings-panel vue component and use InputFields [#2177]
Use browser-native tooltips [#2189]
Improve agent rpc retry logic with exponential backoff [#2205]
Skip settings proxy config with WithProxy if its empty [#2242]
Move hook and events-stream routes to use /api prefix [#2212]
Add SSH clone URL env var [#2198]
Small improvements to mobile interface [#2202]
Switch to upstream ttlcache [#2187]
make EqualStringSlice to generic EqualSliceValues [#2179]
Pass netrc to trusted clone images [#2163]
Use Vue setup directive [#2165]
Release file lock on USR1 signal [#2151]
Add header to pipeline log and always show buttons [#2140]
Make sure we dont have hidden options for backend and pipeline compiler [#2123]
Enhance local backend [#2017]
Don't show badge without information [#2130]
CLI repo sync: Show forge-remote-id [#2125]
CLI repo sync: Show forge-remote-id [#2103]
Lazy-load TimeAgo locales [#2094]
Improve user settings [#2087]
Allow to disable swagger [#2093]
Change master to main [#2044]
Remove default branch fallbacks [#2065]
Remove fallback check for old sqlite file location [#2046]
let generic datastore error include func name [#2041]

📚 Documentation

clarify setup with gitlab with RFC1918 nets and non standard TLDs [#2363]
Clarify env var CI in docs [#2349]
docs: yaml cheatsheet for advanced syntax [#2329]
Improve explanation for globs in when:path [#2252]
Fix usage description for backend-http-proxy flag [#2250]
Restructure k8s documentation [#2193]
Update list of "projects using Woodpecker" [#2196]
Update 92-awesome.md [#2195]
Better blog title/desc [#2182]
Fix version in FAQ [#2101]
Add blog posts/tutorials [#2095]
update version docs about versioning [#2086]
Fix client example [#2085]
Update docs deps to address cves [#2080]
fix: global registry docs [#2070]
Improve bitbucket docs [#2066]
update docs about versioning [#2043]
Set v1.0 documents as default and mark v0.15 as unmaintained [#2034]

Misc

fix(deps): update golang deps non-major [#2437]
fix: change config.config_data column type to longblob in mysql [#2434]
chore(deps): update postgres docker tag to v15 [#2423]
fix(deps): update dependency esbuild-loader to v4 [#2433]
fix(deps): update dependency clsx to v2 [#2432]
fix(deps): update dependency @vueuse/core to v10 [#2430]
fix(deps): update dependency @svgr/webpack to v8 [#2429]
fix(deps): update dependency @kyvg/vue3-notification to v3 [#2427]
fix(deps): update dependency @intlify/unplugin-vue-i18n to v1 [#2426]
chore(deps): update typescript-eslint monorepo to v6 (major) [#2425]
chore(deps): update react monorepo to v18 (major) [#2424]
chore(deps): update dependency prettier to v3 [#2420]
chore(deps): update dependency eslint-config-prettier to v9 [#2415]
chore(deps): update dependency @tsconfig/docusaurus to v2 [#2410]
chore(deps): update dependency typescript to v5 [#2421]
chore(deps): update dependency concurrently to v8 [#2414]
Add renovate deps groups [#2417]
fix(deps): update module xorm.io/xorm to v1.3.3 [#2393]
chore(deps): update dependency marked to v9 [#2419]
chore(deps): update dependency @types/marked to v5 [#2411]
fix(deps): update module github.com/rs/zerolog to v1.30.0 [#2404]
fix(deps): update module github.com/jellydator/ttlcache/v3 to v3.1.0 [#2402]
fix(deps): update module github.com/xanzy/go-gitlab to v0.91.1 [#2405]
fix(deps): update module github.com/antonmedv/expr to v1.15.1 [#2400]
chore(deps): update dependency axios to v1 [#2413]
fix(deps): update module github.com/prometheus/client_golang to v1.16.0 [#2403]
fix(deps): update module github.com/urfave/cli/v2 to v2.25.7 [#2391]
fix(deps): update module google.golang.org/protobuf to v1.31.0 [#2409]
fix(deps): update kubernetes packages to v0.28.1 [#2399]
fix(deps): update module github.com/swaggo/swag to v1.16.2 [#2390]
fix(deps): update dependency @easyops-cn/docusaurus-search-local to ^0.36.0 [#2406]
Harmonize pipeline status information and add a review link to the approval [#2345]
fix(deps): update module github.com/stretchr/testify to v1.8.4 [#2389]
fix(deps): update module github.com/caddyserver/certmagic to v0.19.2 [#2401]
chore(deps): update postgres docker tag to v12.16 [#2397]
fix(deps): update module github.com/mattn/go-sqlite3 to v1.14.17 [#2387]
fix(deps): update module github.com/google/uuid to v1.3.1 [#2386]
chore(deps): update dependency unplugin-vue-components to ^0.25.0 [#2395]
fix(deps): update dependency @intlify/unplugin-vue-i18n to ^0.13.0 [#2398]
chore(deps): update dependency unplugin-icons to ^0.17.0 [#2394]
chore(deps): update golang docker tag [#2396]
fix(deps): update module github.com/moby/moby to v20.10.25+incompatible [#2388]
fix(deps): update module github.com/docker/docker to v20.10.25+incompatible [#2385]
fix(deps): update module github.com/docker/cli to v20.10.25+incompatible [#2384]
fix(deps): update module github.com/alessio/shellescape to v1.4.2 [#2381]
fix(deps): update golang.org/x/exp digest to 9212866 [#2380]
Configure Renovate [#2360]
Add option to render button as link [#2378]
Add release helper [#1976]
Fix typo in GitLab docs [#2376]
Execute make generate with new versions [#2365]
Truncate commit message in pipeline log view header [#2356]
Increase header padding again [#2348]
Use html list for changed files list [#2346]
Fix mobile login view [#2332]
fix regression and add trace in clone for local backend [#2241]
Check for correct license header [#2137]
Add TestCompilerCompile [#2183]
Use min/max width for pipeline step list [#2141]
Use fix width for pipeline step list [#2138]
Fix docs workflow [#2128]
Add some tests for bitbucket forge  [#2097]
Support bitbucket Dir() [#2045]
Use consistent woodpecker color scheme [#2003]
Publish releases and branch tags to quay.io too [#2069]
Bump default clone image version to 2.1.0 [#2053]
Fix wrong repo url used by badges (#2037) [#2039]
Fix wrong repo url used by badges [#2037]

it should be v1.1.0 ?!?

it should be v1.1.0 ?!?

It should not. If we have breaking changes its 2.0.0 otherwise we need to deal with breaking changes differently: #2383

and can we remove dependabot pulls from the cangelog

You can add skip-changelog to those, however I would keep them.

I don't think the next release should wait for all the tasks in the next release project.
Do any of the remaining issues in that project require breaking changes?

I don't think the next release should wait for all the tasks in the next release project. Do any of the remaining issues in that project require breaking changes?

Not sure about that project board. We used https://github.com/woodpecker-ci/woodpecker/discussions/2170 to plan the next release and bundle breaking changes. Please comment in there.

Huh, why was this closed? Is there a new issue I can track to keep informed about the release?
I'm waiting on this as it fixes a few issues I'm having and would update the Nix package as soon as it's released

#2526


exchange rate dataset

Thanks for your work! I noticed that there is no experimental result of the exchange rate dataset in the paper. Did you do experiments on the exchange_rate dataset? If you have done experiments, can you provide the parameter settings for the optimal results of the exchange rate data set?

Hi, thanks for the question! We haven't done it since we are cautious about this dataset, which we have explained in appendix A.1.1 .  We expect to see the future development on analyzing this problem.


Cross Compile tensorflow for arm using a different python version

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):   Host linux ubuntu 18.04 amd64 , Target : linux ubuntu 18.04 arm 32 bit
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: None
TensorFlow installed from (source or binary): source
TensorFlow version: 2.1.0
Python version:  3.6.9
Installed using virtualenv? pip? conda?:  python venv
Bazel version (if compiling from source):  4.0.0
GCC/Compiler version (if compiling from source):  arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04
CUDA/cuDNN version: no
GPU model and memory: no

Hi,
i am cross compiling tensorflow ( version 2.1.0 ) since i need the new delegate features for my hardware accelerator.
I tried to install directly tensorflow lite from the official binaries for linux arm 32 however when i run a model i get the "illegal instruction" which is probably due to different floating point support of the processor and/or avx instructions (those ideas come from other github issue)
My board is the Pynq Z2 from tul with arm processor on 32 bit architecture running a linux based OS. I am following the procedure for building  tensorflow from source for the rasberry ( i changed some of the compiler flags for correctly match my architecture) however i cannot change the python version of the wheel ( i need a cp36 instead of a cp35 ) from the build process. Is there any workaround?
If you are wondering why i did not install python3.5, it is becouse there may be some incompatibility with the pynq package.
PS i tried to change brutally the name of the wheel, from cp35 to cp36, but when i import tensorflow into the python enviroment i get the incompatibility error of the two version.

HI franout,
Can you give more details about the steps you have tried? Also want to ask if you want to build whl for TensorFlow, or TensorFlow Lite. These are the instructions I'm aware of for each packages, but not sure where you encountered wheel version issue.
TensorFlow: https://www.tensorflow.org/install/source_rpi#python-3
TensorFlow Lite: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/tools/pip_package

my first try was to cross compile tensorflow lite for the zynq board, but i got the error about the pybind11 includes ( i didn't find the #38903 ).
Therefore i cross compiled the entire tensorflow, without any problems following the guide you already cited (cross compile tensorflow for raspberry). Following that i obtained a wheel for python3.5 ,My question is: Is possible to produce a wheel for python3.6 instead?
Anyway, I tested the wheel for python3.5 on the board ( i needed to build  python3.5 from scratch on the board) and it is up and running now.
https://github.com/franout/tensorflow_for_pynqz2  Here you can findthe wheel for the Pynq Z2 board ( zynq 7000 xilinx SoC) and the modified build script of the raspberry.

Update CROSSTOOL_PYTHON_INCLUDE_PATH to point Python3.6 if you want to produce a wheel for Python 3.6
https://www.tensorflow.org/install/source_rpi#python-3


Feature/Core game bug fix - Dhampir's racial feat Life Dominant Soul doesn't work

The Dhampir Racial Feat Life Dominant Soul should allow a Dhampir to heal for half the normal amount from any positive channeled energy, such as from Cure Wounds, however in game it only seems to work with the actual channel ability (and even then its iffy). It'd be awesome to be able to heal a Dhampir without jumping through all the extra hoops after you take this feat like you should be able to.

This is actually false, as it specifically states that positive energy that can be used to deal damage to undead is not affected by the feat. It even gives the examples of Cure Wounds and Lay on Hands.


Changed "Redis Labs" to "Redis Inc"

Updated name of "Redis Labs" to reflect the current name of the company.

@MSFTeegarden : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Extra space between nick and message

Which version of matterbridge are you using?
version: 0.10.2 4a25e66
Please describe the expected behavior.
Setting RemoteNickFormat in the configuration file to have one trailing space is expected to produce just one space between nick and relayed message.
Please describe the actual behavior.
Messages relayed between irc and xmpp work fine, with one space between nick and relayed message.
Messages relayed from Mattermost to irc and xmpp work fine, also with one space.
Messages relayed from either irc or xmpp to Mattermost have two spaces between the nick and relayed message, in this case the bridge seems to be inserting an extra space.
Please add your configuration file
I believe the only relevant configuration item is setting RemoteNickFormat:
RemoteNickFormat="[{NICK}] "

Good catch, fixed in master. (and will be in 0.11.0-beta1)


escape list arguments to reval

this makes the reval example compatible with both IPC formats
h"[string]"
and
h(f;arg0;arg1;...)

Thanks for the catch. And FWIW you made the site Honor Roll
http://code.kx.com/q/about/thissite/#honor-roll


Don't work with python 3.7

When will be compatibility with python3.7?

Python 3.7 support is blocked by https://github.com/eventlet/eventlet/issues/526
The folks over at eventlet are working hard on this and it looks like there has been progress recently

@ikasymov Could you please provide the symptom of how it does not work with 3.7?


Replaceable test parameters can also replace test case names

The current implementation of Replaceable test parameters looks for the key to be replaced in all the config XML and will arbitrarily replace any string in that XML:
https://github.com/LIS/LISAv2/blob/master/TestControllers/TestController.psm1#L237
For example, if a test case name contains a replaceable test parameter key, the test case name itself will be different.
Possible fix: Make sure that XML items are changed and not substrings.

Ideally the replaceable parameters should only replace the values under  tag, but there's exception in cases in FunctionalTests-InfiniBand.xml. The cases has INFINIBAND_INTEL_TOTAL_REBOOT_COUNT not under .
If we can move the INFINIBAND_INTEL_TOTAL_REBOOT_COUNT under , then we can update to only replace parameters under

@juhlee-microsoft @adriansuhov can you please ack this and transform NumberOfReboots as a test param, not part of the main test definition part.

Acked, @adriansuhov and I work on new branch merging to master soon. We can make a change in new PR. Sounds better?

PR #736

@juhlee-microsoft  How is PR 736 fixing the issue?

PR #736

This PR doesn't resolve the issue.
Actually, Adrian is right. If the "Replaceable Key" is present in testname, then it will replace the testname as well.

https://github.com/LIS/LISAv2/pull/748 Probably this will fix.


Create "FAQ" like document for common errors/resolutions when setting up the app

A few I can think of off the top of my head

[ ] Mongoid won't boot: this is usually mongoid not shutting down properly and won't boot again (usually just have to mongod --repair )
[ ] Wrong node version:  Daria uses 10 but the new default is 13. This can lead to webpack giving errors about SHAs and missing asset files. (Logged it at https://discuss.rubyonrails.org/t/webpacker-gets-mad-when-using-default-locally-when-node10-expected/75003 )

Do you think these gotchas might be a good fit for https://github.com/DCAFEngineering/dcaf_case_management/blob/master/docs/SETUP.md ? From the context it looks like this came up on repo setups.

wontfix


Remove irrelevant fields from flattened fall student voice survey

Follow-on to https://github.com/studentinsights/studentinsights/pull/2400

selfie


Model Registry Settings: Add model registries table with db config viewer, delete action and stub for permission management modal

Closes RHOAIENG-6970
Closes RHOAIENG-2230 (followup to https://github.com/opendatahub-io/odh-dashboard/pull/2828)
Description

Adds the Model Registries table to the Model Registry Settings page
Adds a stub modal for the "Manage Permissions" button, to be implemented in another story
Adds a "View database configuration" kebab action which opens a modal. All details are displayed immediately except the password, which shows a loading skeleton while the associated secret is fetched.

For displaying the password in this modal, refactors the backend service so it handles secrets along with modelregistries
If there is an error fetching the associated secret or decoding the password from it, an inline alert is shown.

Adds a "Delete model registry" kebab action with a modal requiring typing the name for confirmation.
Using the updated backend service, adds databasePassword to the values passed when submitting the CreateModal

Note: Does not include the Database Status column from the mockups, that is blocked by backend work and has been moved into a followup story.
cc @yih-wang
Table:

Kebab menu:

Password loading state:

Password loaded (clicking the eyeball shows it):

Password loading error state:

Delete modal:

Delete modal with name entered correctly:

How Has This Been Tested?

Tested viewing existing model registries that were created on the shared cluster for testing, including viewing database details. Tested the password loading error by creating a model registry referencing a nonexistent secret and trying to view its details. Tested the delete operation.
Test Impact

Cypress tests will be added in a separate PR, they'll conflict with tests @gitdallas has already started on
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@mturley Thanks for all the work! They look really great!
Can you use a plain alert for the case when the password cannot load? Additionally, is it possible for the user to successfully fetch the password with another attempt? If so, it might be beneficial to add a retry button here, like my second screenshot.

Pushed the change to switch to inline alert and updated the screenshot above.

@lucferbux if you look at the Delete modal screenshots, am I correct in assuming that the default permission group shown in the message there (currently "TODO: group here") is something we can't fill in until we figure out RHOAIENG-6636 (RBAC story), or is that maybe known based on the registry name?

/hold
let's rebase this after https://github.com/opendatahub-io/odh-dashboard/pull/2828 and implement the Secret logic part of submitting that create modal as part of this PR. That PR also establishes cypress tests that this PR can add to.

/unhold
@lucferbux this is ready for review now, sorry for the delay on the cypress tests!

/hold
Dallas found an issue I'm looking into

/unhold
False alarm. Need to test with local backend instead of start:dev:ext since the changes aren't on the cluster

Pushed changes to address some feedback after a Slack conversation with @gitdallas:

When creating or deleting a registry, the modal does not close until the list of registries has been fully refreshed (so we no longer get a lag between the submit completing and the list of registries changing).
When viewing database details, instead of showing a one-line loading skeleton while the password loads, the whole modal shows a spinner. The skeleton component seemed potentially confusing (if it's taking a while, it could just look like an intentionally obscured password). If there is an error loading the password, the rest of the database details will still be shown. Updated the loading state screenshot in the description above.

Code looks great, there are a few open questions that i wanna discuss with you @mturley so we can do follow ups, but so far, it can be merged!

(feel free to resolve all comments once you read them so we can proceed merging the pr)

Looks like the bot is happy to merge with unresolved conversations now 🤷
@lucferbux should we open followup issues for the 2 points you raised above (refactoring to use useGenericObjectState and supporting display names for registries)?


Add node cordon action

Problem:
Users can only do node eviction by enabling the maintenance mode, it should also allow the user to cordon the node without evicting the VMs.
Solution:
Add node cordon and un-cordon action
Related Issue:
https://github.com/harvester/harvester/issues/573
Test plan:
Test via API:

node can be cordon and un-cordoned.
can't deploy VM to a cordoned node.

As this is not mentioned in the original issue, I would like to know in what circumstance users want to perform a cordon action?

As an enhancement, this action would allow the user to cordon the node and doing some debugging work without evicting the VMs to the other node. let me know if u think it's better to create a separate issue for it, thanks.

yeah I think it fits another issue

@gitlawr done https://github.com/harvester/harvester/issues/917, thanks


FancyZones doesn't apply last known zone flag after reboot (even after snapping window again)

Microsoft PowerToys version
"0.53.3"
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
Create a custom layout (I have 5) <- Not sure if this is required.
Snap an explorer window (shift-drag) to one of the zones.
Close/open explorer window and all is well (it snaps back to the last zone).
Reboot the PC.
Open explorer windows and it's not in the right spot (maybe that's okay, it's never been open in this session).
Snap explorer window to a zone and close it.
Open explorer window again and it does not go back to the last know (snapped) zone (consistently wrong if more windows are opened or if same window is closed/opened again).
Open PowerToys, select FancyZones, uncheck and re-check "Move newly created window to their last known zone"
Now explorer window will consistently snap back to the zone it is last closed in when re-opened.
The setting needs to be toggled for FancyZones to realize it should be active.
✔ Expected Behavior
After a reboot, FancyZones' "Move newly created window to their last known zone" is active, if checked active.
❌ Actual Behavior
After a reboot, windows snapped to zones, even when FancyZones' "Move newly created window to their last known zone" is set active, do not snap back to their last known position.
Other Software
No response

This is still true in 0.55.0
I may add, is also true if the machine goes to sleep and wakes from sleep (now testing in 0.55.0) - FancyZones will not restore windows to the last position, even if you re-snap them.  Even if you toggle the setting, it doesn't work.
If you kill FanzyZones after sleep (with no explorer window open) and start in, and open explorer, the window does snap to the last place it was snapped to when FancyZones was still running before closing it (or maybe before sleep - I tried the same zone so not sure if there's a distinction there).  It's like the FancyZones "service" didn't wake when the computer woke.


feature/sqrt: implement Sqrt for field elements (#4)

See #4 .

@ThomasPiellard --> line 961 is the Legendre method correct?
If so: l = z^((q-1)/2) --> if l == 0, return 0, if l == 1 return 1, else return -1.
So line 965, we compare against 1, in Montgomery form


[stable/consul] joinPeers and joinWan stability and reliability improvements

What this PR does / why we need it:
I tweaked the logic around the joinPeers and joinWan lists to make them more reliable when dealing with slow-to-resolve DNS.
I also changed the joinPeers list to be authoritative. This allows me to deploy a global consul cluster across GKE clusters.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ x] DCO signed
[ x] Chart Version bumped
[ x] Variables are documented in the README.md
[ x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test
/lgtm


[tool_crash] FileSystemException: Cannot open file, OS Error: Operation did not complete successfully because the file contains a virus or potentially unwanted software., errno = 225

exception
FileSystemException: FileSystemException: Cannot open file, path = 'D:\Flutter\build\app\outputs\flutter-apk\app-release.apk' (OS Error: Operation did not complete successfully because the file contains a virus or potentially unwanted software.
, errno = 225)
#0      _File.throwIfError (dart:io/file_impl.dart:675:7)
#1      _File.openSync (dart:io/file_impl.dart:490:5)
#2      _File.readAsBytesSync (dart:io/file_impl.dart:574:18)
#3      ForwardingFile.readAsBytesSync (package:file/src/forwarding/forwarding_file.dart:91:43)
#4      ForwardingFile.readAsBytesSync (package:file/src/forwarding/forwarding_file.dart:91:43)
#5      _calculateSha (package:flutter_tools/src/android/gradle.dart:943:32)
#6      AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:593:36)
<asynchronous suspension>
#7      AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5)
<asynchronous suspension>
#8      BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5)
<asynchronous suspension>
#9      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27)
<asynchronous suspension>
#10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#11     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#12     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:9)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:285:5)
<asynchronous suspension>
#15     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:115:9)
<asynchronous suspension>
#16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#17     main (package:flutter_tools/executable.dart:90:3)
<asynchronous suspension>

flutter doctor
[✓] Flutter (Channel stable, 3.13.8, on Microsoft Windows [Version 10.0.22621.2428], locale ar-SY)
    • Flutter version 3.13.8 on channel stable at d:\flutterSdk
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6c4930c4ac (18 hours ago), 2023-10-18 10:57:55 -0500
    • Engine revision 767d8c75e8
    • Dart version 3.1.4
    • DevTools version 2.25.0

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at D:\AndroidSDK
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.6.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.6.33829.357
    • Windows 10 SDK version 10.0.22000.0

[✓] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[✓] VS Code (version 1.83.1)
    • VS Code at C:\Users\HP\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.74.0

[✓] Connected device (4 available)
    • SM G532F (mobile) • 42001e79fe01c305 • android-arm    • Android 6.0.1 (API 23)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.22621.2428]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 118.0.5993.72
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 118.0.2088.46

[✓] Network resources
    • All expected network resources are available.

• No issues found!

https://stackoverflow.com/questions/77294420/flutter-contains-troj-gen

Closing as duplicate of https://github.com/flutter/flutter/issues/61997


[DONOTMERGE] Remove image field in values file

What this PR does / why we need it

Remove multus-cni image fields to keep downstream workflow not being broken.
Details for the Release Notes (PLEASE PROVIDE)

Which issue(s) this PR fixes

Fixes: #None
Describe testing done for PR

make e2e-test passes
Special notes for your reviewer

closing this one since it is not needed


Updating the actions migration

:nut_and_bolt: Description: What code changed, and why?
The update runs the migration in the background.
It also migrates each action index one at a time and then delete it.
:chains: Related Resources
#444
:+1: Definition of Done
The action migration runs in the background
:athletic_shoe: How to Build and Test the Change

start_all_services
Get a version of the code before the initial migration git checkout b97055d5329cb171a7583c5fc0a68a6f83a6d340
rebuild components/ingest-service && rebuild components/automate-deployment
Add some actions with chef_load_actions 1000
Ensure there are "actions-*" indexes with es_list_indices
To watch the log run sl | grep "ingest-service.default" &
git checkout lancewf/action_migration
rebuild components/automate-deployment && rebuild components/ingest-service
ensure that the ingest-service is healthy before migration is complete.
Ensure all the "actions-*" indexes are removed and you still see events on the event feed page.

:white_check_mark: Checklist

[x] I have read the CONTRIBUTING document.
[ ] Tests added/updated?
[ ] Docs added/updated?
[x] All commits have been signed-off for the Developer Certification of Origin.

:camera: Screenshots, if applicable

These changed were added in from this PR https://github.com/chef/automate/pull/4229


Fixed #29871 -- saving new instance on setting pk = None

Ensured that setting pk = None sets all parent_ptr_id's as well as
all AutoField's in the parent heirarchy to None. This follows the
current documentation on copying model instances:
https://docs.djangoproject.com/en/3.0/topics/db/queries/#copying-model-instances
Thanks Simon for the initial patches on Trac!

I forgot to thank Tim for his work!
https://github.com/django/django/pull/10549

buildbot, test on oracle.

I added test without multi-models inheritance.

@ChetanKhanna Thanks for this patch :+1: Welcome aboard :boat:
@charettes Thanks for the review and initial patch :star2:


Revert "Pre-calculate application start order"

Reverting the commit which causing our tests to fail. The commit forcefully stops the application if it is already running which causes the test cases which gradually start applications to fail. Here is one of the failing scenarios:
    Hashed = couch_passwords:hash_admin_password(?PASS),
    ok = config:set("admins", ?USER, ?b2l(Hashed), _Persist=false),
    .....
    Started = test_util:start_applications([chttpd]),
    .....
    {Started, Ctx}.

Call to test_util:start_application causes config app to be restarted. Which means it looses all configuration.

Leaving state between tests seems like a broken test rather than the thing that's trying to make sure that tests don't do exactly that. I'd change the tests to not be yucky rather than revert this.


1 - Transition Rules: Create API

Closes #1347
This PR adds the capability to add transition rules specific attributes in the document. Testworld tests help in using them.

@mikiquantum will do!


Support GHC 9.0

Installing this with GHC 9.0 I get:
[__2] trying: quickcheck-instances-<IP_ADDRESS> (dependency of extra *test)
[__3] next goal: base (dependency of extra)
[__3] rejecting: base-<IP_ADDRESS>/installed-<IP_ADDRESS> (conflict:
quickcheck-instances => base>=4.5 && <4.15)
Seems you need to relax the base constraint.

Blocked on https://github.com/tibbe/hashable/issues/193

https://hackage.haskell.org/package/quickcheck-instances-<IP_ADDRESS>/revisions/


DeepLink chain not executed as expected

Thank you for the wonderful Coordinator library. I am having an issue related to deeplink chain.
The issue is that the deeplink only runs to the MarketsRoute route, while the StockMarketRoute does not execute.
return .multiple(
                .dismissToRoot(),
                .popToRoot(),
                deepLink(AppRoute.home, HomeRoute.markets, MarketsRoute.stocks, StockMarketRoute.counterDetail)
)

I will explain a little bit about the Coordinator in the demo project. HomeTabCoordinator is a tab bar controller that contains 3 tabs: NewsCoordinator, MarketsCoordinator, UsersCoordinator. MarketsCoordinator is a page view controller that has 2 pages: StockMarketCoordinator and UTMarketCoordinator.
Can you help me identify where the problem is?

This really depends on how you're using XCoodinator. I'd have to see how you're using XCoordinator to give you better advice, but my general solution to this is to wrap your ViewControllers in a wrapper object that conforms to Presentable then override this function in that that wrapper where the strongRouter is the Coordinator that presents that ViewController
public func router<R: Route>(for route: R) -> StrongRouter<R>?

basically when you transiton a ViewController despite UIViewController conforming to presentable, it itself is not a Router the coordinator that displays that ViewController is the Router so you have to point to that router in that function in order for deep linking to execute as expected.
You could do something like this
class  MyModule: Presentable {
  let viewController: UIViewController!
  unowned var presentingCoordinator: MyCoordinator

  init(viewController: MyViewController, coordinator: MyCoordinator ) {
    self.viewController = viewController
    self.coordinator = coordinator
  }
  public func router<R: Route>(for route: R) -> StrongRouter<R>? {
      coordinator.strongRouter
  }
}

....

class MyCoordinator {
...

  override func prepareForTransition(on route: MyRoute) -> TransitionType {
    switch route {
      case .initialRoute:
         let module = MyModule(viewController: MyViewController(), coordinator: self)
         return .present(module)
     ....
    }
  }
}

now since you presented the module that knows about the router Deep linking should start working properly. This problem actually comes up again in other situations. This is my general workaround.


Fix IMX477 image on camera info

The IMX477 image couldn't be loaded because the file extension was "jpeg" and the image path expects "jpg" files

Thanks for the spot


fix: sqlness failed due to region failover

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR fixes sqlness failure caused by region failover wrongly kicks in for dropped or renamed table.
Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Does this mean the root cause for this is that we are using <cluster_id, datanode_id, catalog, schema, table, table_id, region_id> for region failure detection?

@v0y4g3r No, just a corner case for region failover.


Add support for MarshalJSON

I couldn't seem to see anything around why there may not be a MarshalJSON method as well as an UnmarshalJSON, is that intended?

Actually maybe this isn't needed, and I may have thought it was needed due to #242

This could alternatively be a new Validator that handles the generation of
Example (Apache-2.0 licensed) code that's output from oapi-codegen for the same purpose:
func (a Pong) MarshalJSON() ([]byte, error) {
	var err error
	object := make(map[string]json.RawMessage)

	object["ping"], err = json.Marshal(a.Ping)
	if err != nil {
		return nil, fmt.Errorf("error marshaling 'ping': %w", err)
	}

	for fieldName, field := range a.AdditionalProperties {
		object[fieldName], err = json.Marshal(field)
		if err != nil {
			return nil, fmt.Errorf("error marshaling '%s': %w", fieldName, err)
		}
	}
	return json.Marshal(object)
}

For the following (OpenAPI):
    Pong:
      type: object
      required:
        - ping
      properties:
        ping:
          type: string
          example: pong
      additionalProperties:
        type: string

Alternatively could we conditionally generate a MarshalJSON method if we detect we have AdditionalProperties?

(This may also need tweaking for the unmarshalJSON implementation)


Bug Report

Expected Behavior
Start the container with the docker-amundsen-atlas.yml file,
and then run the python3 script example/scripts/sample_data_loader_atlas.py
and create elasticsearch indexes
Current Behavior
when using docker-amundsen-atlas.yml it starts with elasticsearch:6.8.13
But when I try to use databuilder and run:
python3 example/scripts/sample_data_loader_atlas.py
Indices are not created in elasticsearch
/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/elasticsearch/connection/base.py:200: ElasticsearchWarning: the default number of shards will change from [5] to [1] in 7.0.0; if you wish to continue using the default of [5] shards, you must manage this on the create index request or with an index template
warnings.warn(message, category=ElasticsearchWarning)
/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/elasticsearch/connection/base.py:200: ElasticsearchWarning: [types removal] The parameter include_type_name should be explicitly specified in create index requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', and requests are expected to omit the type name in mapping definitions.
warnings.warn(message, category=ElasticsearchWarning)
2022-03-08 23:14:52,179 elasticsearch WARNING  PUT http://localhost:9200/table_9334a18b-9105-4251-83a3-fb74ae4f3e4d [status:400 request:0.015s]
2022-03-08 23:14:52,179 databuilder.callback.call_back INFO     No callbacks to notify
Traceback (most recent call last):
File "example/scripts/sample_data_loader_atlas.py", line 406, in
job_es_table.launch()
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/amundsen_databuilder-6.7.1-py3.8.egg/databuilder/job/job.py", line 76, in launch
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/amundsen_databuilder-6.7.1-py3.8.egg/databuilder/job/job.py", line 72, in launch
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/amundsen_databuilder-6.7.1-py3.8.egg/databuilder/publisher/base_publisher.py", line 40, in publish
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/amundsen_databuilder-6.7.1-py3.8.egg/databuilder/publisher/base_publisher.py", line 37, in publish
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/amundsen_databuilder-6.7.1-py3.8.egg/databuilder/publisher/elasticsearch_publisher.py", line 93, in publish_impl
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/elasticsearch/client/utils.py", line 347, in _wrapped
return func(*args, params=params, headers=headers, **kwargs)
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/elasticsearch/client/indices.py", line 145, in create
return self.transport.perform_request(
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/elasticsearch/transport.py", line 466, in perform_request
raise e
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/elasticsearch/transport.py", line 427, in perform_request
status, headers_response, data = connection.perform_request(
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/elasticsearch/connection/http_urllib3.py", line 291, in perform_request
self._raise_error(response.status, raw_data)
File "/home/user/amundsen-new/amundsen/databuilder/venv/lib/python3.8/site-packages/elasticsearch/connection/base.py", line 328, in _raise_error
raise HTTP_EXCEPTIONS.get(status_code, TransportError)(
elasticsearch.exceptions.RequestError: RequestError(400, 'mapper_parsing_exception', 'Root mapping definition has unsupported parameters:  [schema : {analyzer=simple, type=text, fields={raw={type=keyword}}}] [cluster : {analyzer=simple, type=text, fields={raw={type=keyword}}}] [description : {analyzer=simple, type=text}] [display_name : {type=keyword}] [column_descriptions : {analyzer=simple, type=text}] [programmatic_descriptions : {analyzer=simple, type=text}] [tags : {type=keyword}] [badges : {type=keyword}] [database : {analyzer=simple, type=text, fields={raw={type=keyword}}}] [total_usage : {type=long}] [name : {analyzer=simple, type=text, fields={raw={type=keyword}}}] [last_updated_timestamp : {format=epoch_second, type=date}] [unique_usage : {type=long}] [column_names : {analyzer=simple, type=text, fields={raw={normalizer=column_names_normalizer, type=keyword}}}] [key : {type=keyword}]')
Possible Solution
Is it possible to have an atlas compatible version of search, frontend and metadata?
Even upgrading to elasticsearch 7 doesn't seem to work properly.
Steps to Reproduce

docker-compose -f docker-amundsen-atlas.yml up
wait for all services to start

cd databuilder
source venv/bin/activate
pip3 install --upgrade pip
pip3 install -r requirements.txt
python3 setup.py install
pip install apache_atlas atlasclient
python3 example/scripts/sample_data_loader_atlas.py

Screenshots (if appropriate)
Context

Your Environment

Amunsen version used:
Data warehouse stores:
Deployment (k8s or native):
Link to your fork or repository:

issues resolved by setting the versions to:
amundsen-frontend:3.12.0
amundsendev/amundsen-metadata:3.9.0
amundsendev/amundsen-search:2.11.1
elasticsearch:8.0.0

@leotuxbr how about you create a pr to update that dockercompose file with the right version?


[HOTFIX] Fix search tags

Purpose
The UI for search tags was behaving badly. Clicking the little X on a tag did nothing.

This updates that UI to behave as expected, i.e.:

when a tag is clicked, and it is not already part of the query, it is added (to the query string)
when the little X on a tag is clicked, and it is part of the query, it is removed (from the query string)

Changes

Update search code relevant to tagging to be more readable and predictable

Side effects
None

Review complete; no bugs found. :star:


Adding in error code for 524 response

No message for 524 response so a key error message appears rather than a server error message. Added in entry for a 524 response to prevent this.

Current coverage is 100% (diff: 100%)

Merging #40 into master will not change coverage

@@           master   #40   diff @@
===================================
  Files           1     1
  Lines          30    30
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           30    30
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update dc64f8b...b7ea47b

Hmmm.....I wonder if we should really support these kinds of "unofficial" server response codes. I think I'm ok with it, but I'd suggest we support the full suite of Cloudflare, nginx, etc. codes. Mind updating the pull request with the info here?

Thanks. Looks great.

Was thinking of going in and setting a case for when there's no error code so that a KeyError isn't produced. I'll go ahead and do that now!

Thanks!


Short solution needed: "How to change figure name" (python-matplotlib)

Please help us write most modern and shortest code solution for this issue:
How to change figure name (technology: python-matplotlib)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

How to change figure title


[Bug] While downloading the MQTTX setup file for Windows, Microsoft Defender shows it as a potentially malicious file

What did I do
Tried to download the MQTTX setup file for Windows
What happened
Microsoft Defender shows that it's a malicious file
Expected
It shouldn't be a malicious file
Environment

OS: Windows 10
MQTTX version v1.6.0

More detail

Here's what Microsoft Defender considers as malicious files:
https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-smartscreen/microsoft-defender-smartscreen-overview

@nrd26 Yes, we should offer MQTT X to Microsoft for review, it's OK, not enough I don't think it's necessary.
Thank you for your suggestion


[bug] Unable to load asset 'path to file'

Describe the bug
Unable to load asset error with the following example:
void _openEditor(path) async {
    File file = File(path);
    bool fileExists = await file.exists();
    if (fileExists) {
      print('File exists at: $path');
    } else {
      print('File does not exist at: $path');
    }
    imagePath = path;
    if (!context.mounted) return;
    await Navigator.push(
      context,
      MaterialPageRoute(
        builder: (context) => ProImageEditor.asset(
          path,
          onImageEditingComplete: (byte) async {
            Directory appDocDir = await getApplicationDocumentsDirectory();
            File file = File('${appDocDir.path}/${DateTime.now().millisecondsSinceEpoch}.jpg');
            await file.writeAsBytes(byte);
            if (!context.mounted) return;
            imagePath = file.path;
            Navigator.pop(context);
          },
        ),
      ),
    );
  }

Knowing that passing and checking if fileExists returns true.
Steps to Reproduce

Take Picture
Call Editor Function
Error appears with exception in editor.

Expected Behavior
To load the image as expected.

Thanks for your bug report.
I noticed that you attempted to open a file using ProImageEditor.asset. To successfully open a file, you should utilize ProImageEditor.file. Below is an example demonstrating how to integrate it with your code. Please note that ProImageEditor.asset is exclusively designed for opening assets explicitly declared in your pubspec.yaml file.
void _openEditor(path) async {
    File file = File(path);
    bool fileExists = await file.exists();
    if (fileExists) {
      print('File exists at: $path');
    } else {
      print('File does not exist at: $path');
    }
    imagePath = path;
    if (!context.mounted) return;
    await Navigator.push(
      context,
      MaterialPageRoute(
        builder: (context) => ProImageEditor.file(
          file,
          onImageEditingComplete: (byte) async {
            Directory appDocDir = await getApplicationDocumentsDirectory();
            File file = File('${appDocDir.path}/${DateTime.now().millisecondsSinceEpoch}.jpg');
            await file.writeAsBytes(byte);
            if (!context.mounted) return;
            imagePath = file.path;
            Navigator.pop(context);
          },
        ),
      ),
    );
  }

Thank you for this feedback, i may have been a bit confused between asset and path, but using asset as such instead of .file actually was returning the above error, i managed to go around this by doing the below:
void _openEditor(path) async {
    final pathOfXFile = await path.readAsBytes();
    if (!context.mounted) return;
    await Navigator.push(
      context,
      MaterialPageRoute(
        builder: (context) => ProImageEditor.memory(
          pathOfXFile,
          onImageEditingComplete: (byte) async {
            Directory appDocDir = await getApplicationDocumentsDirectory();
            File file = File('${appDocDir.path}/${DateTime.now().millisecondsSinceEpoch}.jpg');
            await file.writeAsBytes(byte);
            if (!context.mounted) return;
            imagePath = file.path;
            Navigator.pop(context);
          },
        ),
      ),
    );
  }

which works like a charm for both picked images from image_picker & captured images.


Display Minecraft version somewhere in the book

Technically implemented in 1!0.1.0a8, but I'd like for it to be displayed a bit more prominently somewhere.


Sendmsg failing with EINVAL when trying to run Servo

I tried compiling and running the Servo web browser in WSL (using Xvfb), and ran into an issue related to the IPC implementation:
[pid 24291] socketpair(PF_LOCAL, SOCK_SEQPACKET, 0, [9, 11]) = 0

[pid 24313] sendmsg(9, {msg_name(0)=NULL, msg_iov(2)=[{"c\0\0\0\0\0\0\0", 8}, {"\0\0\0\0\0\0\0\0\0\0\0\21http://servo.org/\0\0\0"..., 99}], msg_controllen=24, {cmsg_len=24, cmsg_level=SOL_SOCKET, cmsg_type=SCM_RIGHTS, {53, 54}}, msg_flags=0}, 0 <unfinished ...>
[pid 24313] <... sendmsg resumed> )     = -1 EINVAL (Invalid argument)

Interesting sendmsg features used are:

Socket type SOCK_SEQPACKET
msg_iovlen == 2
SCM_RIGHTS to send file descriptors

Source code is available as MIT/Apache if you want to take a look.
May be related to https://github.com/Microsoft/BashOnWindows/issues/376

Just an update that the fix for this has been checked in the dev branch and should soon hit the release branch. Please keep the feedback coming. We are looking at them.

Just FYI that this should be fixed in 15042. If the issue persists, please let us know. Thanks again for the post.


Add license auditing to github actions CI

Goal
Uses license finder to validate the licenses present in required dependencies.

Since both Laravel 6.0 & 8.0 versions are still seeing releases, the audit workflow forces the installation of the appropriate illuminate package versions, ensuring both release tracks are covered.


Fix ApiKey plan selection

Issue
NA
Description
Apply https://github.com/gravitee-io/gravitee-api-management/pull/2459 on 3.19.x

🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of APIM master. (Same login and password as APIM master)

Still missing commit 19ca1ce8c1e9e72534d7416c00586c7398970e3b


add editorconfig file

.editorconfig file allows basically all IDEs to configure basic formatting rules for any file type (by file name pattern).

@MeirionHughes, I'll send an initial PR, but I guess You'll need to decide yourself what the exact settings should be (I won't reformat anything with that initial PR)

I sent a PR, but You may want to change the settings in it


history.push

hello, I am using the push method as shown below.. basically passing state along with pathname:-
history.push('/url',search:"someText");
but when i reload my page , only url exists and the state is gone..
how to resolve this issue

location.state does not persist across page loads. It should only be used for temporary data, like the location to redirect to after logging in.
If you need to ensure that data is attached to a location, you will need to use either location.search or location.hash (or include the data in the pathname).
history.push({ pathname: '/url', search: '?someText' });

@pshrmn i have understood your explination. But what if i say that my state should be persistant and i dont want to show the data in the URL . so is there any way ?

localStorage might work.
I would recommend asking either on StackOverflow or Reactiflux. Those venues are setup for answering questions, while the issues section here is intended for reporting bugs.


Allow clipping by MultiPolygon

Currently, the canvas immediate renderer calls context.beginPath() once for each composite part of a MultiPolygon.  This makes it so a MultiPolygon cannot be used to generate a clip path.  For example, here is a geometry representing two diamonds used as a clip path:

Only the last composite part is used in clipping.  Instead, all parts should be used.
This branch makes it so we only call context.beginPath() once per MultiPolygon (instead of once per composite part).  In addition, we only fill and stroke after drawing all parts - this means MultiPolygon parts should not be overlapping.
The tests show the corrected behavior when clipping by a MultiPolygon.

Nice! Please merge when green.


Use clientId rather than ScopeId in Guacamole Audience

PR for issue
What is being addressed
We should be using the ClientId in the Guacamole Audience rather than the ApplicationIdURI
How is this addressed

Remove workspace_identifier_uri
Use the client_id that is stored in the KeyVault instead
Update documentation
Update E2E tests

/test-extended

/test-force-approve


Channel filters does not match messages in production env

What happened?
All messages are counted as Other

Reposilite version
3.x
Relevant log output
No response

I'll try and take a look at this tonight. 👍


Inconsistent CSS declarations

It seems that the CSS declarations made by vue-toasted.min.css and vue-toasted.js are not compatible, leading to the wrong CSS being included in the Vue app if used like this:
import Toasted from 'vue-toasted';
Vue.use(Toasted);

If used like this it works for now:
import Toasted from 'vue-toasted';
Vue.use(Toasted);

import 'vue-toasted/dist/vue-toasted.min.css';

The solution is unintuitive though, so it would be nice if this could be fixed.

this is being fixed in the latest version


added merge two sorted linked list

🛠 Issue (#309 )

Issue no #309
👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@khushigarg1 The code is good. But add some comments explaining the approach.

Done!

Add a screenshot of output. Also codefactor is showing one issue. see it! Try to fix it.

Done please check

Can you take the input from user instead of giving directly in program. It makes user friendly program.

Okay sure

Can you take the input from user instead of giving directly in program. It makes user friendly program.

Done!

Can you take the input from user instead of giving directly in program. It makes user friendly program.

Done please check

@Arun9739  please approve!