nix: remove myself from "code ownership" and 2.3 maintenance

Description of changes
I have no further plan to review CppNix code anymore, as I will dedicate myself to Lix development.
None of my machines are running CppNix anyway.
@flokli Godspeed on 2.3!

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Paging the Nix maintenance team so they can find suitable replacements in the meantime.
cc @thufschmitt @fricklerhandwerk @roberth @Ericson2314 @edolstra @tomberek.

Most people probably didn't even notice that I've also been codeowner/maintainer for a while, so less impact, but Given that I mostly run Lix these days, I don't think I can make calls suc as when it's appropriate to bump stable Nix.
That means, sooner or later I'll drop my maintainer status as well.

Is it documented somewhere what needs to be done to maintain the Nix package in Nixpkgs? I consider taking it.

Not aware of this, but off the top of my head[1]:

Keep Nix versions we've packaged up-to-date and apply security patches (and backport those!)
Add new nix_X_Y attributes for new minors (and update latest attribute) and backport of appropriate
Clean up unmaintained Nix minors.
Keep nixVersions.git up-to-date[2] and backport.
Decide which minor will be the next nixVersions.stable.

Special care must be exercised here given that 2.18 was kept for very good reasons so far. I recommend to have a few power-users (or be one yourself :p) to run a newer minor for a while for ~everything (means Hydra, home-manager etc) to see if there are notable regressions.

[1] feel free to document it somewhere, not having the time for this currently.
[2] This tracks Nix's master and is updated weekly. I usually run the lib tests against nixVersions.git as part of that procedure. Reasons are:

catch issues related to our packaging as early as possible
allow downstream users of Nix (e.g. home-manager, colmena or nix-darwin) to find issues on master with the way the use Nix without having to add another flake input just for that

@RaitoBezarius  you listed your procedure for quality assurance here https://github.com/NixOS/nixpkgs/pull/315262#issuecomment-2139592225

Build over all supported systems
Build static binaries and test them
Cross compile to classical supported systems
Run i686, misc tests & all installer tests using that specific Nix
Run library eval tests (normally, ofborg takes care of this for you, but double check it)
Verify that nixos-enter behave as expected (a catastrophic regression for the stable Nix in general)
Build Hydra with that Nix and verify it works out of the box
Verify that the new Nix's fetchers work with things like npins, with some interesting cases, e.g. private forges, allRefs = true;, etc.
Evaluate ALL of nixpkgs with nix-eval-jobs which tests two things: nix-eval-jobs compat and Nixpkgs evaluation ~correctness

I suppose you don't roll all of that by hand. Is there code to make all of that run with one command?

Evaluate ALL of nixpkgs with nix-eval-jobs which tests two things: nix-eval-jobs compat and Nixpkgs evaluation ~correctness

nix-eval-jobs has been pinned to a specific nix version for a long time. There is no need test this when upgrading the current default nix version. I already test this when releasing a new nix-eval-jobs version anyway.

@RaitoBezarius you listed your procedure for quality assurance here #315262 (comment)

Build over all supported systems
Build static binaries and test them
Cross compile to classical supported systems
Run i686, misc tests & all installer tests using that specific Nix
Run library eval tests (normally, ofborg takes care of this for you, but double check it)
Verify that nixos-enter behave as expected (a catastrophic regression for the stable Nix in general)
Build Hydra with that Nix and verify it works out of the box
Verify that the new Nix's fetchers work with things like npins, with some interesting cases, e.g. private forges, allRefs = true;, etc.
Evaluate ALL of nixpkgs with nix-eval-jobs which tests two things: nix-eval-jobs compat and Nixpkgs evaluation ~correctness

I suppose you don't roll all of that by hand. Is there code to make all of that run with one command?

I run this by hand mostly, I take care of bumps slowly over time, I never do all of that in one day or even in one week.

Evaluate ALL of nixpkgs with nix-eval-jobs which tests two things: nix-eval-jobs compat and Nixpkgs evaluation ~correctness

nix-eval-jobs has been pinned to a specific nix version for a long time. There is no need test this when upgrading the current default nix version. I already test this when releasing a new nix-eval-jobs version anyway.

Really the aim is to validate evaluation correctness, fixing nej compat is a secondary task of this task. I caught regressions in nej this way as well :P. Feel free to replace nej by the right instantiation of nix-env.

nix-eval-jobs has been pinned to a specific nix version for a long time. There is no need test this when upgrading the current default nix version. I already test this when releasing a new nix-eval-jobs version anyway.

fwiw this is probably also about checking if any code in here causes issues with a new Nix.
Btw I'm sorry, I missed

@Ma27 are you still maintaining nix in nixpkgs or not?

in the other PR!
For now I'd say I'm out. PR will follow. Will revisit if Lix is released eventually and the packaging is shared[1].
Btw this means someone else needs to also take care of nixVersions.git.
[1] I heard rumors about Meson being merged downstream.

I consider taking it.

I don't think I'm equipped in terms of time, qualification, or hardware to take on such a responsibility (of which I already have more than enough).

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2024-06-03-nix-team-meeting-minutes-149/46582/1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2024-06-05-nix-team-meeting-minutes-150/46583/1

@Aleksanaa don't merge master to PR branches, it's clutter.

@Aleksanaa don't merge master to PR branches, it's clutter.

It's online conflict resolver. I forgot that.
Can I just squash-merge?

I think it's safer to fix this in the CLI.


Random hangs (unresponsive) on latest x64 Supermium (122.0.6261.85 64 bit)

Describe the bug
The latest Supermium 122.0.6261.85 64 bit randomly hangs, it doesnt matter which webpage I am on, even with 1 or 2 tabs open.
When this occurs, a relaunch is required every time. Very annoying bug, and ruins the experience for me.
I had to go back to version 119.0.6045.192 (64-bit) because it seems like this is the last properly stable Supermium version which works without any issues. I dont know what you guys did, but whatever you did seems to have sort of broken both 121 and 122 versions of Supermium.
To Reproduce
I have not been able to reproduce the behavior. This truly seems random, although it might not be the case (perhaps it can be reproduced).
Expected behavior
Obviously I expect any browser or app to work without hanging/crashing/freezing etc.
Screenshots

Desktop (please complete the following information):

OS: Windows 7 SP1 x64
Supermium 122.0.6261.85 64 bit
All drivers and windows updates at latest version
User profile (User Data folder) is not "fresh", it comes from previous installations of Supermium

You can vote for this: https://github.com/win32ss/supermium/discussions/346
As fact, now it is just the "alpha preview". And not for everyday use.

Please try the latest release.

Any word on if the latest version fixes the hangs?  I am hesitate about setting it all up and getting it configured how I like just to have it still having the hanging issue.

Any word on if the latest version fixes the hangs? I am hesitate about setting it all up and getting it configured how I like just to have it still having the hanging issue.

Not sure why you need to "getting it configured" since it technically works without changing a single thing in your settings/profile.
All you do is update the actual browser files, the dir that has 122.0.6261.85 and chrome.exe in it.
Anyway,  I will update this, but it is too soon. I just tried the latest version today, and no hangs/crashes yet. But it is too soon to tell, havent been using it enough to be sure.
It looks promising so far though.

@DankiestCitra When I copied the dir that has 122.0.6261.85 and chrome.exe in it to the install of 119 some settings got reset and I needed to reinstall all the extensions I use again, the extension settings came back when they were reinstalled but it was a pain in the ass cause some of the addons I use aren't on the chrome store anymore


Centralize access to getEnvVarOrSysProp

We put some duplicated code in #81; review all points that access this and centralize the logic (in the same place where we test it)

9035dc2


Error creating graph: Invalid argument: No OpKernel was registered to support Op 'Placeholder' with these attrs.  Registered devices: [CPU], Registered kernels:
  <no registered kernels>

	 [[Node: OnlineTraining/Model/Placeholder_1 = Placeholder[dtype=DT_FLOAT, shape=[2000,400]]()]]

How can I generate a complete file for this? If necessary I can also upload the test.pb file for testing.

@drpngx @cwhipkey Sorry for the late response. Unfortunately adding tensorflow/core/kernels:android_tensorflow_kernels doesn't solve my problem. I work around this missing kernel issue by manually adding all needed //tensorflow/core/kernels/*.cc *.h files to srcs. Maybe I was wrong about some details, but I will update if I solve it more elegantly.

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

It has been 44 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

This is probably still an issue, but I figured out how to put this in the build scripts. It would be VERY nice thought if the selective thing would work.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 29 days with no activity and the awaiting response label was assigned. Is this still an issue?

We are closing this issue for now due to lack of activity. Please comment if this is still an issue for you. Thanks!


Full Topic List not appearing on RPi 4

Hello!
I'm very excited to begin using the Create3 for some interesting SLAM projects. I've spent the better part of two days trying to get the basic ros2 setup running on a RPi 4 that I have connected via usb to my Create 3.
I follow the instructions on your website: https://iroboteducation.github.io/create3_docs/setup/pi4/
However, after completing them and checking for the available topics, All I see is
ubuntu@irobot:~$ ros2 topic list
/parameter_events
/rosout

Please help me figure out what's wrong with my installation.
System Info:
Ubuntu 20.04.4 LTS (GNU/Linux 5.4.0-1062-raspi aarch64)
RMW_IMPLEMENTATION=rmw_cyclonedds_cpp
Note: I also tried the RWM Fast-DDS since I didn't understand in the instructions where to find my robot's "Application Configuration page"
Bottom of ~/.bashrc:
export _colcon_cd_root=/opt/ros/galactic/
source /usr/share/colcon_argcomplete/hook/colcon-argcomplete.bash
source /opt/ros/galactic/setup.bash
export RMW_IMPLEMENTATION=rmw_cyclonedds_cpp
export CYCLONEDDS_URI=/home/ubuntu/ros_install/profile.xml
export FASTRTPS_DEFAULT_PROFILES_FILE=/home/ubuntu/ros_install/profile_fast.xml

RMW profile (located in ~/ros_install/):
<CycloneDDS>
   <Domain>
     <General>
        <DontRoute>true</DontRoute>
    </General>
   </Domain>
</CycloneDDS>

This profile was found here under Multiple network Interfaces due to being on my company's WiFi

Hi there,
I'm a little confused. It looks like that RMW profile you're using is one you would want on a laptop; on your Pi, if you're connected both to the robot with usb0 and to your local network with wlan0, you'll want to use the multiple network interfaces XML config on the Pi, which is

usb0,wlan0

Using this (maybe reboot after changing the file just to make sure everything's settled), you should be able to see the robot with a ros2 topic list. The robot's RMW can be forced to Cyclone by connecting to it with a browser to {robot ip}/ros-config, or if you know you're connected with the Pi, you can just  curl -X POST -d "ros_domain_id=0&ros_namespace=&rmw_implementation=rmw_cyclonedds_cpp" "http://<IP_ADDRESS>/ros-config-save-main" from the prompt.


Merge 2.10.x -> 2.11.x

Conflicts were resolved by taking the changes from 2.10.x.

Can one of the admins verify this patch?


Add strong distro type from grype

Follow up to https://github.com/anchore/syft/pull/742

We've opted to remove the module cycle before continuing with this feature


Convert release pipelines to yaml

The release pipelines we have now - such as https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_release?_a=releases&view=all&definitionId=30 - should be converted into checked-in yaml files for a more controlled review process and visibility.

@Charles-Gagnon @anthonydresser @alanrenmsft can we close this?

There's still other pipelines we need to convert so probably not - but we can split that into separate issues for each pipeline if we want as well for better tracking. (I just did the SqlToolsService one)

Do we have a list of the other pipelines that need to be updated?

Not directly, I'll try and get that done before I leave otherwise I'll go through after I get back.


chore: bump node versions

Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

Yup we got on v3 via https://github.com/freeCodeCamp/crowdin-config/commit/5fba1579a44a5d65abbf530b1273cbd5b97fe017
Their release page is all you get about the changes.
They introduced a couple of breaking changes, one of which we already are compliant with (the use of node-version), and the other thing is we need to move to the latest Node versions (16), which this PR does.
So we should be OK - unless that's not what you are confirming?

Just for clarification sake...
The version of node here only impacts our test running environment for the QA checks. The actual QA checks running on Crowdin run in a severely outdated environment (doesn't even support ES6).


[BUG] Pinned tweets are not shown

Describe the bug
The fact that a tweet is pinned in a Twitter account isn't reflected on Fritter.
To Reproduce
Steps to reproduce the behavior:

Open the Twitter handle of AppleTV+ in any web browser.
Open the Twitter handle of AppleTV+ in Fritter.
Observation: Pinned tweets from Twitter are not reflected in Fritter.

Screenshots
Screenshots taken at the time of creating this issue:
From Twitter:

From Fritter:

Device

OS version: Android 12
Fritter version: 2.16.3

This looks like it's caused by a change on Twitter's side, where they no longer return the pinned tweets in the API response. I think there's an alternative way I can fetch that data though...

It does not work.
Device specifications:
Device: Android 12 (stock)
App version: 3.0.0-beta3
Attachments:
Twitter screenshot below:

Fritter screenshot below:


exit 1 vs task.complete result=Failed

This document has been advocating for years to use exit 1 when issuing task.logIssue type=error. I am wondering why when you can achieve the same thing by issuing task.complete result=Failed. The main advantage of using task.complete seems to be that it does not produce an additional error in the ADO build UI.
When exit 1 is used, there's an additional error that may say something like PowerShell command exited with 1. In my opinion, this is not something you'd like to present to the user/developer in most of the cases.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 16bf0bbb-8b63-6384-aa33-b5b1e2b8cfe3
Version Independent ID: f4da8dbd-a02f-bbdf-2cf2-60e081339237
Content: Logging commands - Azure Pipelines
Content Source: docs/pipelines/scripts/logging-commands.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-scripts
GitHub Login: @juliakm
Microsoft Alias: jukullam

@san7hos I apologize for the delay in responding. I checked with the product team and their feeling is that exit 1 is more representative of what happens when a pipeline fails. I'll double-check to make sure that task.logIssue type=error is also mentioned in our docs.


Warn tapping of non-visible area when test

Description
Hi,
In unit tests, finding widget (find.text('foo')) works even if it's invisible but tapping it (tester.tap) does nothing. This behavior makes it harder to write tests. It would be nice if flutter test warns tapping of non-visible area.
NOTE: I honestly don't think the change is well-written but mainly wanted to get attention from the maintainers.
Thank you.
Related Issues
https://github.com/flutter/flutter/issues/48463.
Tests
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

@dnfield Hi, thanks for the review! I know the current change is not sufficient to merge. Could you give me the direction? I'd love to get this done 💪

Hey, I consider this one to be super important. It did cost me two hours or so and I guess I am not the only one to have stumbled upon it. Can I help in any way? I never contributed to flutter, but would give it a try.

I see two options:

The tester fails, because the element is not visible and thus can't be tapped.
The tester scrolls to the element automatically (with ensureVisible) and only fails if the element does not exist.

I guess solution 1. is better, what do you think?


G5/feature/notification center

Adding the notification center, update some CSS and update some components

LGTM, but fix those issues ^^

On it ^^


[Feature] Large model test

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
add the large model test with proper arguments

What is the new behavior (if this is a feature change)?
we only do the large model test with --largemodel arguments

If the arguments are not passed, the large model test will not run.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

Have unit tests been run against this PR? (Has there also been any additional testing?)
working on it

Related Python client changes (link commit/PR here)
no

Related documentation changes (link commit/PR here)
no

Other information:
no

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added / updated (for bug fixes / features)

An example without passing --largemodel

tox

tox --largemodel

Testing on github actions unit_test_CI. expected behavior: large model tests should be skipped: https://github.com/marqo-ai/marqo/actions/runs/4321767270

Correct output was also observed on EC2 instance


cannot encode non-string keys

The library appears unable to encode dictionaries with non-string, e.g. integer, keys. This is the case at the top level and inline.
For example, using master (59d83d0d51a976f11a74991fa7d220fc630d8bae):
$ python3
Python 3.10.4 (main, Jun 29 2022, 12:14:53) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import toml
>>> toml.__file__
'/PATH/TO/REPO/toml/toml/__init__.py'
>>> toml.__version__
'0.10.2'
>>> toml.dumps({1: 'a'})
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/PATH/TO/REPO/toml/toml/encoder.py", line 60, in dumps
    addtoretval, sections = encoder.dump_sections(o, "")
  File "/PATH/TO/REPO/toml/toml/encoder.py", line 193, in dump_sections
    if not isinstance(o[section], dict):
KeyError: '1'
>>> toml.TomlEncoder().dump_inline_table({'1': {1: 'a'}})
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/PATH/TO/REPO/toml/toml/encoder.py", line 167, in dump_inline_table
    val = self.dump_inline_table(v)
  File "/PATH/TO/REPO/toml/toml/encoder.py", line 168, in dump_inline_table
    val_list.append(k + " = " + val)
TypeError: unsupported operand type(s) for +: 'int' and 'str'

Bah, I see now that in this example the integer is intended to be interpreted as a string, i.e. keys are only strings [spec].
In that case this handling is not unreasonable. It might make sense to catch and raise an error or cast to string … but that's another matter.


Produce stable links for latest version of the slides

Runs a github action (worflow/slides.yaml) which will produce the two versions of the slides (essentials & full) and commit them to the "download" branch. The github action should run on every commit, pull request and on Sunday 23:55.
The result should be stable links to the slides, if not mistaken those should be
https://github.com/hsf-training/cpluspluscourse/blob/download/talk/C%2B%2BCourse_essentials.pdf
https://github.com/hsf-training/cpluspluscourse/blob/download/talk/C%2B%2BCourse_full.pdf
and the base directory
https://github.com/hsf-training/cpluspluscourse/tree/download/talk
The PR also contains the ignore of xdv files in the .gitignore.
Fixes #171

PS: Many thanks to @bernhardmgruber and @hageboeck for inspiration from their previous github actions ;-)

Having linkable latest versions of the PDF would be really cool! :)
(Btw, to trigger builds, you can also do git commit --allow-empty (if there isn't a button to do this on github))

Having linkable latest versions of the PDF would be really cool! :)
(Btw, to trigger builds, you can also do git commit --allow-empty (if there isn't a button to do this on github))

It kind of works, but we discussed it yesterday and there is a possibility we blow up the repo because we commit one pdf after the other. I'm now trying to avoid this.

I close this PR and come back to it when the current issue is solved.

This should work now as expected. I.e. there are two branches in the repo "emptyrepo" and "download" , the github action will

first "reset --hard" the download branch to emptyrepo
then will run (in parallel) the builds of the two (so far) versions of the slides and commit and push them to download

this way, once a new github action will run, the previous tip of download will point to void (after the hard reset) and should be garbage collected after some time by github.com. Can somebody confirm this last point?

https://stackoverflow.com/questions/56020314/how-frequently-do-github-run-git-gc-on-repositories  seems to be daily.
Btw, just saw that there still is an issue with github not finding the emptyrepo upstream (which is strange).
A different option that I see would to do
# checkout download branch still containing old files
# create new files
# now git status will show us dirty files
# We now edit the last commit to use the new files
git commit --all --amend --no-edit
# And force push it on the server
git push --force

(A completely different approach would be to upload to Google drive and then create a link for that: https://github.com/marketplace/actions/google-drive-upload-git-action)

https://stackoverflow.com/questions/56020314/how-frequently-do-github-run-git-gc-on-repositories seems to be daily.
Btw, just saw that there still is an issue with github not finding the emptyrepo upstream (which is strange).
A different option that I see would be to do
# checkout download branch still containing old files
# create new files
# now git status will show us dirty files
# We now edit the last commit to use the new files
git commit --all --amend --no-edit
# And force push it on the server
git push --force

thanks the daily gc is very fine, then I hope we should not easily blow up the repo.
the problem with the emtpyrepo branch is probablly that this action only runs within a PR for the moment? I could imagine once merged that it should be ok. I just ran it again and it looks there are some permission problems on the upstream repo (here)

(A completely different approach would be to upload to Google drive and then create a link for that: https://github.com/marketplace/actions/google-drive-upload-git-action)

thanks that's good to know. we discussed this yesterday and said its probably easier if we leave everything within github b/c of credentials setup. I propose to see if the current version works. If any issues this is certainly also viable.

git commit --all --amend --no-edit
git push --force

That sounds like a good option. Then you don't need the empty repository branch.

Just realised that the github action in the PR in the upstream repo fails with
+ git push origin download
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 talk/C++Course_essentials.pdf
remote: Permission to hsf-training/cpluspluscourse.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/hsf-training/cpluspluscourse.git/': The requested URL returned error: 403
Error: Process completed with exit code 128.

not sure, maybe this is because its still inside the PR and needs to be merged first?

This was exactly the problem. I pushed the changes to master and the action was able to start committing.

This PR has been superseded by #225.

Since the #225 is merged, I will close this PR then.


Returning QR base64

at login, i would like to return just a base64 string and convert it to qrCode using PHP. Still testing GoLang! Can you help me to return base64 QR in json format and not a QRcode in the terminal? I'm using the login example so far
#436 didn't help me

terminal := qrcodeTerminal.New()
qrCode := <-qr
terminal.Get(qrCode).Print()
qrToImg(qrCode)

func qrToImg(qrCode string) {

	err := qrcode.WriteFile(qrCode, qrcode.Medium, 256, "qr.png")
	if err != nil {
		fmt.Fprintf(os.Stderr, "No se pudo crear el archivo de imagen QR")
	}
}

The qrCode variable contains the raw QR-code as a string. You can do with it whatever you want.
Maybe check out one of the HTTP-Rest projects implementing this project (e.g. go-whatsapp-rest). Maybe it is easier to integrate the REST-API within your PHP project.


support lifetime injection

upgrade Hosting.Abstraction to 8.0.0
support lifetime injection

AddApplicationLifetime
AddApplicationLifetime

https://github.com/NeverMorewd/Hosting.Avaloniaui/issues/1


Guide corrections to make it more up-to-date

Changed patcher executable file name to match current naming scheme, added warning box to direct users to Domino's guide if they want to use Food Channel - Domino's.


Slow API gateway endpoints

When deploying Lambda functions with jaws dash, the resulting endpoints are very slow (500ms+). The strange thing is that the exact same Lambda function is performing well (+/- 40ms) when creating the API gateway endpoint manually. API gateway and Lambda are both in regio eu-west-1. I'm aware of the Lambda cold-start issues, but the problem remains when firing multiple subsequent requests.
The difference is visible when comparing these 2 URLs:
https://enxk7hdlkl.execute-api.eu-west-1.amazonaws.com/dev/users/list
https://enxk7hdlkl.execute-api.eu-west-1.amazonaws.com/dev/users/test

/list is generated by jaws dash, and /test is created manually from the AWS console. Both point to the same Lambda function (no new function is created for the second function).

@joostfarla Thanks, I'll look into this tonight :)

@ac360 thanx! Did you manage to reproduce this in other regions?

When I query the AWS API for the integration details of both calls, the most important difference I noticed is that the first (slow) request contains a key "credentials" which is absent in the manually created method. Could this be be IAM related?

@joostfarla This appears to be an API Gateway issue.  The AWS team has been alerted and they are working on it.  The problem is detailed in this issue.
I'm going to implement the fix suggested in that issues tomorrow, along with some other API Gateway updates.  Thanks again for spotting this issue.  It looks like AWS didn't even notice it.

Thanx! Great to see such a quick response!

Still working on this one...  Ran into another AWS bug preventing me from implementing the fix.
https://forums.aws.amazon.com/thread.jspa?threadID=216626&tstart=0

UGH!  Took all day to fix this one.  But I think I fixed it.  I ran some tests and indeed ~500ms improvements now.  I'm not sure if this will result in a breaking change though.  But it's fixed.  Thanks for pointing this one out @joostfarla.   This is a huge win for JAWS :+1:
Fixed in 5b5371b0afdd940d16ea96e12d622510955168a0

This is great! @ac360, many thanx for your hard work!!

Hi
I have problem with api gateway (using Lambda)
when I am doing post request from my android device over network the response is very very slow till i am getting timeout
but when i am enable wifi on my device the response it within milliseconds
I cant find an explanation or what to do

Hey @doriwal
Unfortunately that's pretty hard to tell. Seems to be some non-serverless related problem since your application works the way it should if you use a wifi connection.
I'd recommend to raise this question on StackOverflow with some insights into the code and the setup you have.


PDF attachment contents missing in Outlook Emails on CI 3.1.0

Hi there,
Our problem had developed once we had upgraded to version 3.1.0. We had been including .pdf documents within our emails for a year now. For various purposes, on  CodeIgnitier versions 3.0.4 & 3.0.0 prior to that. Our initial code hadn't changed and we started to receive 'blank' .PDFs, they were successfully attached however, it seems the contents were empty; corrupted and/or unsuccessfully included to the Email when being attached in Outlook.
I managed to produce a test case for this below, of which if you do spot a possible mistake, please let me know:
<?php
/**
 *
 */
class SandboxCI extends CI_Controller {

    /**
     *
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     *
     */
    private function get_pdf_path()
    {
        $file_path = FCPATH . 'assets/sandbox/hello_world.pdf';

        if ( !file_exists( $file_path ))
        {
            log_message( "debug", "Attempted to get file at: $file_path" );
            return false;
        }
        else
        {
            return $file_path;
        }
    }

    /**
     *
     */
    public function send_email()
    {
        //Clear just in case.
        $this->email->clear(TRUE);

        //Init
        $this->email->initialize(array(
            'mailtype'  => 'html',
            'protocol'  => 'sendmail',
            'mailpath'  => '/usr/sbin/sendmail',
            'charset'   => 'utf-8',
            'wordwrap'  => TRUE,
            'validate'  => TRUE
        ));

        //Get a dummy 'Hello World!' pdf that we've saved locally.
        $pdf = $this->get_pdf_path();

        if ( !$pdf )
        {
            log_message( "error", "Test PDF not found" );
            return false;
        }

        $this->email
             ->to<EMAIL_ADDRESS>)
             ->from<EMAIL_ADDRESS>)
             ->subject( "Test Attachtment on CI ". CI_VERSION );

        //Location: home/site/assets/sandbox/hello_world.pdf
        if ( !$this->email->attach( $pdf ))
        {
            echo '
Unable to attach the PDF
';
            return false;
        }

        $message = '
Hello, World!
';

        $this->email->message( $message );
        $sent = $this->email->send( FALSE );

        if (  $sent )
        {
            echo 'Email sent';
        }
        else
        {
            echo 'Failed to send Email';
        }

        echo '

'. $this->email->print_debugger() .'
';
        return $sent;
    }
}

Once arrived at your Inbox in Outlook. it will appear as, at 240 Bytes, just the space reserved for a .pdf

The $this->_attachments  at _append_attachments() appears to have the correct variables filled:
 Array
(
    [0] => Array
        (
            [name] => Array
                (
                    [0] => /public_html/assets/sandbox/hello_world.pdf
                    [1] =>
                )
            [disposition] => attachment
            [type] => application/pdf
            //Cut down for easier reading..
            [content] => JVBERi0xLjUNCiW1tbW1DQoxIDAgb2JqDQo8PC9UeXBlL0NhdGFsb2cvUGFnZXMgMiAwIFIvTGFu
Zyhlbi1HQikgL1N0cnVjdFRyZWVSb290IDEyIDAgUi9NYXJrSW5mbzw8L01hcmtlZCB0cnVlPj4+.....
            [multipart] => mixed
        )
)

Which seems to be OK - However it seems the only difference would be the Email headers, pre/post 3.1.0.
3.1.0 >=
Content-Type: multipart/mixed; boundary="B_ATC_579f0d9ccd677"

This is a multi-part message in MIME format.
Your email application may not support this format.

--B_ATC_579f0d9ccd677
Content-Type: multipart/alternative; boundary="B_ALT_579f0d9ccd5cc"

--B_ALT_579f0d9ccd5cc
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello, World!

--B_ALT_579f0d9ccd5cc
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

=3Chtml=3E=3Cbody=3E=3Ch1=3EHello, World=21=3C/h1=3E=3C/body=3E=3C/html=3E

--B_ALT_579f0d9ccd5cc--

--B_ATC_579f0d9ccd677
Content-Type: application/pdf; name="hello_world.pdf"
Content-Disposition: attachment;
Content-Transfer-Encoding: base64
JVBERi0xLjUNCiW1tbW1DQoxIDAgb2JqDQo8PC9UeXBlL0NhdGFsb2cvUGFnZXMgMiAwIFIvTGFu
Zyhlbi1HQikgL1N0cnVjdFRyZWVSb290IDEyIDAgUi9NYXJrSW5mbzw8L01hcmtlZCB0cnVlPj4+

<= 3.0.6
Content-Type: multipart/mixed; boundary="B_ATC_579f0a9379cc6"

This is a multi-part message in MIME format.
Your email application may not support this format.

--B_ATC_579f0a9379cc6
Content-Type: multipart/alternative; boundary="B_ALT_579f0a9379c49"

--B_ALT_579f0a9379c49
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Hello, World!

--B_ALT_579f0a9379c49
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

=3Chtml=3E=3Cbody=3E=3Ch1=3EHello, World=21=3C/h1=3E=3C/body=3E=3C/html=3E

--B_ALT_579f0a9379c49--

--B_ATC_579f0a9379cc6
Content-type: application/pdf; name="hello_world.pdf"
Content-Disposition: attachment;
Content-Transfer-Encoding: base64

JVBERi0xLjUNCiW1tbW1DQoxIDAgb2JqDQo8PC9...

Reverting the Email.php helper to version 3.0.4 worked fine, however I'm not entirely sure on how the RFC Headers should be created for such instances.
If you need anymore test data; please let me know!
Cheers,
Robert.

Ok, there's two things I see at first glance ...

You're comparing 3.0.4 to 3.1.0, which means you're skipping 2 versions in between - 3.0.5 and 3.0.6. Please verify the exact "point of failure".
There are changes related to attachments in 3.1.0 (see #4583), but they don't relate to the Subject encoding. In fact - there are zero changes affecting this between 3.0.4 and 3.1.0, which leads me to believe you're also doing something else different (maybe a different environment? idk)

Either way, we do need more details.

Had the same problem couple of weeks back with email attachments not working... switched to phpmailer...

Had the same problem couple of weeks back with email attachments not working... switched to phpmailer...

Thank you, that is very helpful.

will do some testing later today... :-)

Good morning!
Having downloaded & tested 3.0.5 - there's no problem. Attachment appears should, at 257 Kilobytes with the contents intact & un-corrupted. Made a couple of changes to the code at thread start to make sure the filesize is of a suspected size & $mail->attach() is separated into it's on if() statement, just to make sure it's not failing.
Secondly, I realised it wasn't very helpful publishing the headers; as it's the boundaries of the multi-part data that's the important thing here, which there's a subtle but big change between 3.0.5 & 3.1.0. (Should there be a newline after Content-Transfer-Encoding: base64 on 3.1.0?) on how these are constructed.

@MackieeE Thanks for the further input, I'll try to see if I there's any clue in there.
However, please don't edit your original (and already long enough message) - it makes my replies senseless and the conversation hard to follow.

@narfbg Quite right; I'll put any further input as a new comment for future references. I can understand a year from now it may look like a complete jumbled conversation :)
This is all being tested with PHP 7.0.8 mind you; If there's anything else you'd like me to change or test. Please let me know!

Indeed, a second newline characters is missing and I'm quite sure that's not intentional.
Is that the problem for sure?

That seems to be it. Since adding an intentional extra $this->newline, it's worked perfectly.

I'm running the server on Ubuntu 14.04.01 and this has also been tested on Redhat 4.4 as well. Both producing the same result a missing newline at: _append_attachments
However it should add a newline regardless before & after (empty($this->_attachments[$i]['cid']) but this isn't showing at the debug.

It doesn't matter what you test it on server-side, that code is platform-independent.
Anyway, the referenced commit should fix it.

对比正常的邮件原文和ci发出的邮件原文，发现CI发出的附件“Content-Transfer-Encoding: base64”和附件的正文内容编码间缺少一个换行符，
查看CI的内核/libraries/Email.php文件，
1470行，.'Content-Transfer-Encoding: base64'.$this->newline
在后面再添加一个".$this->newline"问题解决。
另，在1471行，.(empty($this->_attachments[$i]['cid']) ? '' : 'Content-ID: <'.$this->_attachments[$i]['cid'].'>'.$this->newline.$this->newline)
可以看出，如果指定了附件的id，貌似会换行两次，如果没有指定，附件将无法下载。
需要修改内核文件才解决问题，这个bug比较低级，希望官方尽快处理，我的版本是3.1.0

Adding extra "$this->newline" works for me.
Was:
. 'Content-Transfer-Encoding: base64' . $this->newline
Is:
. 'Content-Transfer-Encoding: base64' . $this->newline. $this->newline

@skycyclone  这种修复它，非常感谢你

@skycyclone @vhuerta We speak English. Not a clue what you are trying to say, and your comments are not helpful!


Arbitrum E2E test on CI

Before we can start with E2E test, we need to

[x] rebase the existing Arbitrum branch on top of latest main
[x] make sure the contracts still work with our latest main and Arbitrum's latest master

For the E2E test we need to
~- [ ] fork the latest Arbitrum Nitro repo and apply our patches to facilitate local E2E testing~
~- [ ] fork the latest arbitrum-sdk repo and apply our patch to facilitate local E2E testing (we might avoid this, but this needs to checked)~ (addressed by using our relayer)
~- [ ] clone our Nitro fork, making sure to use the patched branch~
~- [ ] clone our arbitrum-sdk fork, making sure to use the patched branch~  (addressed by using our relayer)

[x] start all Nitro containers
~- [ ] from the forked arbitrum-sdk repo invoke yarn gen:network to generate a custom network config~
[x] run the e2e-test.py script
[x] run the relayer, configured with the local Nitro RPC and the custom network config
[x] verify the results

We also need to

[x] update CircleCI config to also run Arbitrum E2E, in parallel with other E2E tests
~- [ ] submit relevant patches to Arbitrum repos~

Acceptance criteria

Arbitrum E2E test is run successfully under CircleCI

@istankovic can you please Update the issue description if it needs updating

Thanks for the reminder, I've updated the description.

@fredo, you mentioned to me that we don't need to do everything that is listed here. That's why I asked @istankovic to update the issue description. However, there are now more todos. Did I misunderstand that we don't need everything, or should you align with @ivan (vice versa)?

more points does not necessarily mean more work. maybe more detailed description.
It remains that the inclusion into the CI does not necessarily need to be done in order to verify that the contracts work.
this was the point of our discussion.
for everything else please align with @istankovic

@istankovic do we need to do #1242 before we can close this issue or will this issue result in #1242 not needing to be done?

Done in #1433.


Add safety check to sample mutex implementation

Due to inconsistent freeing strategy in pkparse.c the sample mutex
implementation in threading.c could lead to undefined behaviour by
destroying the same mutex several times.
This fix prevents mutexes from being destroyed several times in the
sample threading implementation.

I have updated the PR.

Reviewed, tested, approved and merged.


Actions columns in double

Hi, thank you for this app, i was looking for something like that for months !
When I add what needed (like the doc), I have two action columns with same buttons.
Any clue ?

Hey,
that's strange. There is even a test that should cover this case.
Could you please provide some more information about your environment? e.g. Django version, do you use additional extensions for your AdminModel?

This should be fixed. Thanks to @torwald-sergesson (#2)


Different deploy architecture: library approach

Wonderful project and appreciate the easy config object(s).
The fork-as-deploy/install is limiting though.  It makes it hard to config, override, and then upgrade the code base.  Any changes I make to my fork might cause merge errors later.
It would be really nice if this was an installable library, where one would include the library (JS/CSS) on the page, then a bit of JS to instantiate and configure.

This would mean cardkit could be maintained in bower or npm and managed like any other dependency.

Hey @zzolo,
I've definitely thought about this in the past, and would love to do something like this. I'm actually in the middle of some concepting and experimenting around what an updated version of CardKit might look like, specifically looking at making the configuration process cleaner.
I'll keep this issue open as a question, and report back with my findings!

Hey @zzolo,
We have a new version of CardKit coming soon that works as an installable library. You can find out more here: https://github.com/times/cardkit/issues/52

Awesome!  Let me know if/when I can help test it out.


Add metrics on scalable tasklist

Provide metrics add task count/poll for task count/add task latency/poll for task latency on per tasklist per partition

https://github.com/uber/cadence/pull/2807


Non-Composite Resource Type Deprecation Strategy

Now that composite resource is to be launched as the primary resource type, we should deprecate all other resource types.
In general:

[ ] Remove Items from dropdown on the "create resource" page
[ ] E-mail users to let them know of our plans
[ ] Migration path for converting existing
[ ] Figure out how modeling resources
[ ] Figure out iconography / tagging for resource types

TODO: Break this into smaller tickets

@jsadler2 Great. Please link to the sub-tickets from the description of this one. Feel free to edit my description.

The subticket for the model resource types is https://github.com/hydroshare/hydroshare/issues/2959.

@dtarb Is this covered by other GitHub Issues?

Yes.  Closing


IntelliSense on SubPageLink

When we write a SubPageLink IntelliSense does not detect anything after the first comma.

This is a bug, It will be fixed


Build errors potentially due to Rust toolchain

For approx. the last week I've been stuck building with the following error. Confirmed on MacOS, Linux amd64 and Linux arm64:
cargo +nightly build -r --target x86_64-unknown-linux-musl
warning: patch for the non root package will be ignored, specify patch at the workspace root:
package:   ~/llrt/llrt_core/Cargo.toml
workspace: ~/llrt/Cargo.toml
warning: ~/llrt/Cargo.toml: `panic` setting is ignored for `test` profile
error: "~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/Cargo.lock" does not exist, unable to build with the standard library, try:
        rustup component add rust-src --toolchain nightly-x86_64-unknown-linux-gnu
make: *** [Makefile:87: build] Error 101

Haven't been able to find any leads online.
rustc +nightly --version
rustc 1.82.0-nightly (3e9bd8b56 2024-08-08)

At this point, the nightly build should be improved.
% rustc +nightly --version
rustc 1.82.0-nightly (ca5d25e2c 2024-08-09)

Related: https://github.com/awslabs/llrt/pull/527#issuecomment-2275555790

This was a cargo but in latest nightly. Should be fixed now


Getting Caught error: runtime error: invalid memory address or nil pointer dereference trying to import basic OpenAPI spec

This tool looks really cool!  Unsure if this is a bug or I'm doing something wrong, but I'm unable to sync a basic OpenAPI spec file
Process
On Ubuntu 20.04:
wget https://github.com/danielgtaylor/restish/releases/download/v0.20.0/restish-0.20.0-linux-amd64.tar.gz
tar xfv restish-0.20.0-linux-amd64.tar.gz
./restish api edit

Update config to
  {
    "$schema": "https://rest.sh/schemas/apis.json",
    "myip": {
      "base": "https://api.ipify.org/",
      "spec_files": ["/home/liam/myip.yaml"]
    }
  }

create file /home/liam/myip.yaml with
openapi: 3.1.0
info:
  title: My IP
  version: 0.0.1
paths:
  /:
    get:
      summary: Get your own IP
      operationId: getMyIP

Finally run: ./restish -v  api sync myip
Result
DEBUG: Configuration: map[app-name:restish cache-dir:/home/liam/.cache/restish color:true config-directory:/home/liam/.config/restish home-directory:/home/liam rsh-ca-cert: rsh-client-cert: rsh-client-key: rsh-filter: rsh-header:[] rsh-ignore-status-code:false rsh-insecure:false rsh-no-cache:false rsh-no-paginate:false rsh-output-format:auto rsh-profile:default rsh-query:[] rsh-raw:false rsh-retry:2 rsh-server: rsh-timeout:0s rsh-verbose:true server-index:0 tty:true]
DEBUG: API loading took 8.76647ms
ERROR: Caught error: runtime error: invalid memory address or nil pointer dereference
DEBUG: goroutine 1 [running]:
runtime/debug.Stack()
	/opt/hostedtoolcache/go/1.18.10/x64/src/runtime/debug/stack.go:24 +0x65
github.com/danielgtaylor/restish/cli.Run.func1()
	/home/runner/work/restish/restish/cli/cli.go:849 +0x71
panic({0xf3aa20, 0x19a91e0})
	/opt/hostedtoolcache/go/1.18.10/x64/src/runtime/panic.go:838 +0x207
github.com/danielgtaylor/restish/openapi.openapiOperation(_, {_, _}, _, _, _)
	/home/runner/work/restish/restish/openapi/openapi.go:416 +0x1d5b
github.com/danielgtaylor/restish/openapi.loadOpenAPI3({0x12f4f58, 0xc00047c0b0}, 0x107f312f406458?, 0xc00018ce10, 0x7f315609c108?)
	/home/runner/work/restish/restish/openapi/openapi.go:618 +0x15d2
github.com/danielgtaylor/restish/openapi.(*loader).Load(_, {{0xc00074a660, 0x5}, {0x0, 0x0}, 0x0, {0xc00074a668, 0xd}, {0xc00074a675, 0x1}, ...}, ...)
	/home/runner/work/restish/restish/openapi/openapi.go:803 +0x1b1
github.com/danielgtaylor/restish/cli.load(_, {{0xc00074a660, 0x5}, {0x0, 0x0}, 0x0, {0xc00074a668, 0xd}, {0xc00074a675, 0x1}, ...}, ...)
	/home/runner/work/restish/restish/cli/api.go:81 +0xe2
github.com/danielgtaylor/restish/cli.Load({0xc00074a660, 0x16}, 0xc00074c300)
	/home/runner/work/restish/restish/cli/api.go:180 +0x1aab
github.com/danielgtaylor/restish/cli.initAPIConfig.func5(0xc000018000?, {0xc000741a60, 0x1, 0x2?})
	/home/runner/work/restish/restish/cli/apiconfig.go:221 +0x8a
github.com/spf13/cobra.(*Command).execute(0xc000018000, {0xc000741a40, 0x2, 0x2})
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x847
github.com/spf13/cobra.(*Command).ExecuteC(0xc00074c300)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3bc
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
github.com/danielgtaylor/restish/cli.Run()
	/home/runner/work/restish/restish/cli/cli.go:857 +0x818
main.main()
	/home/runner/work/restish/restish/main.go:40 +0x23a

Digging some more, if I update myip.yaml to include a responses block as follows:
openapi: 3.1.0
info:
  title: My IP
  version: 0.0.1
paths:
  /:
    get:
      summary: Get your own IP
      operationId: getMyIP
      responses:
        "200":
          description: text body containing your IP address

then it all works.
I don't think (based on https://swagger.io/specification/#operation-object) that the responses block should be required?


Global Alert - show the actual error message in the banner (#1019 #1028)

@kcole16 @ilblackdragon
Wallet already has a functionality to show proper error in Global Alert banner - but the error from RPC need's to have a type property. For example, error, when there is a lack of storage balance to cover adding another 2FA confirmation, seems not to have type, so it's showing default error.
With this change, all Global Alerts will also show the actual error message.
Ideally, all RPC errors should have a type property, and in Wallet, we should have all these types listed in translations files.

@kcole16 @corwinharrell
A new Global Alert is ready. I prepare it from scratch, so it's not using semantic ui anymore.

it's not using semantic ui anymore

Praise god

@marcinbodnar this looks fantastic. Great job. 🚀

Love this! Big improvement. Just a couple of thoughts:

After being redirected back to profile post recovery setup, the global alert only shows for ~0.5
sec before disappearing (might be an existing issue). Can we fix that too?
Can we vertically align the global alert icon, it's just slightly off (please see attached)
Is there a reason for introducing a new font? (cc @corwinharrell). I am working on replacing our current font with one global font (Inter) here

@Patrick1904 The only new font is the one being used for the raw RPC output that I'd like to be monospace. Are we using a monospace typeface elsewhere? If so we can default to what we're already using.

@Patrick1904

After being redirected back to profile post recovery setup, the global alert only shows for ~0.5
sec before disappearing (might be an existing issue). Can we fix that too?

What kind of recovery did you use?

Can we vertically align the global alert icon, it's just slightly off (please see attached)

In this situation, when there is no text it looks off, but it looks good that way if there is a text. I wonder, what is the situation when only 'Success` header is displayed?

@Patrick1904

After being redirected back to profile post recovery setup, the global alert only shows for ~0.5
sec before disappearing (might be an existing issue). Can we fix that too?

What kind of recovery did you use?

Whenever I am logged in and start the recovery setup flow from the profile, and then get redirected back to the profile

Can we vertically align the global alert icon, it's just slightly off (please see attached)

In this situation, when there is no text it looks off, but it looks good that way if there is a text. I wonder, what is the situation when only 'Success` header is displayed?

I believe this was when I disabled seed phrase from the profile. Might want to align the icon vertically with the main heading/title (cc @corwinharrell)

@Patrick1904 @corwinharrell
Bug with disappearing alert after setting up recovery was not related to these changes. I fixed it for seed phrase, phone, and email.
Also adjusted Alert with only header visible.


Add support for postgres.js

Can we please have the support for postgres.js. It's a far away better than pg which is currently used as a driver in postgresql client.

Curious to hear why you think its "far away better"

Because it's fast, It has got multiple utility functions to help with queries and multiple features around which is mentioned in it's README already but I do agree on your point for a driver which is already working fine 👍🏻

How would you benefit from its features if it would be integrated? You would still work with the ORM API, not with that library directly.
Regarding benchmarks, I kinda doubt it would make a measurable difference with real world usage, the bottleneck are the actual queries you process, not the client. Just looking at the benchmark code and they are not even doing any joins, just selects, and only one of them is accessing real table, rest is using values known from the query (e.g. select 1). The client may be faster, but that was never the bottleneck if you measure in actual apps.
Feel free to experiment with this, if you can make it work as a knex dialect, adopting it would be probably very easy, in a similar fashion as mariadb driver works currently - it extends the mysql knex dialect and patches some minor things in knex. Here is some PoC for such knex dialect: https://github.com/knex/knex/issues/3642#issuecomment-588054490

@B4nan Postgres.js uses prepared statements and does pipelining by default which is the main reason for the better benchmarks. That means the results will actually be better once you use it in real world projects with heavier query plans and higher network latency.

Interesting, I recently saw some adapter for it so the api is compatible with node-postgres, so we might have easy way to have a new driver with postgres.js with very low effort.

Is this planned for V6?

Not really, I have too much to do for v6 and too few time for this. Unless there is a knex dialect that uses it, it would be non trivial task to do.
In the long run, I am considering replacing knex as the backend for SQL drivers with something more modern that would support it out of box, so maybe with v7. Could be kysely, could be even drizzle.


NativeAOT: This operation is only valid on generic types

Is being compatible with ahead-of-time compilation a goal of Tinyhand?  The following works fine in Debug & Release:
using Tinyhand;
using ns;
var engineTinyHandOptions = Tinyhand.TinyhandSerializerOptions.Standard;

// Create simple test object, serialize to file
var obj = new Test() { Str = "TestString", i = 1 };
var bytes = Tinyhand.TinyhandSerializer.Serialize<Test>(obj, engineTinyHandOptions);
File.WriteAllBytes("out.th", bytes);

// Deserialise from file
FileStream stream = new FileStream("out.th", FileMode.Open);
var returnObject = Tinyhand.TinyhandSerializer.Deserialize<Test>(stream, engineTinyHandOptions);
Console.WriteLine(returnObject.Str);
stream.Close();

namespace ns
{
    [Tinyhand.TinyhandObject(ImplicitKeyAsName = true)]
    public partial class Test
    {
        public string Str;
        public int i;
    }
}

However if I publish as a self-contained executable using NativeAOT I get the following error at runtime:
Unhandled Exception: Tinyhand.TinyhandException: Failed to serialize ns.Test value.
 ---> System.TypeInitializationException: A type initializer threw an exception. To determine which type, inspect the InnerException's StackTrace property.
 ---> System.InvalidOperationException: This operation is only valid on generic types.
   at System.Reflection.Runtime.TypeInfos.RuntimeTypeInfo.GetGenericTypeDefinition() + 0x33
   at System.Reflection.Runtime.TypeInfos.NativeFormat.NativeFormatRuntimeNamedTypeInfo.GetGenericTypeDefinition() + 0xe9
   at Tinyhand.Resolvers.GeneratedResolver.TryGetFormatter[T]() + 0x57
   at Tinyhand.Resolvers.StandardResolver.FormatterCache`1..cctor() + 0xb4
   at System.Runtime.CompilerServices.ClassConstructorRunner.EnsureClassConstructorRun(StaticClassConstructionContext*) + 0xd6
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.ClassConstructorRunner.EnsureClassConstructorRun(StaticClassConstructionContext*) + 0x16f
   at System.Runtime.CompilerServices.ClassConstructorRunner.CheckStaticClassConstructionReturnGCStaticBase(StaticClassConstructionContext*, Object) + 0xd
   at Tinyhand.Resolvers.StandardResolver.TryGetFormatter[T]() + 0x11
   at Tinyhand.ResolverExtensions.GetFormatter[T](IFormatterResolver) + 0x39
   at Tinyhand.TinyhandSerializer.Serialize[T](T, TinyhandSerializerOptions, CancellationToken) + 0x164
   --- End of inner exception stack trace ---
   at Tinyhand.TinyhandSerializer.Serialize[T](T, TinyhandSerializerOptions, CancellationToken) + 0x21e
   at <Program>$.<Main>$(String[]) + 0x74
   at ConsoleApp1!<BaseAddress>+0x3427ba

Changing the resolver (e.g. to only use GeneratedResolver, or a CompositeResolver) doesn't appear to help.  This is using the  latest version of Tinyhand from nuget (0.20.1).  Perhaps we are missing a .IsGenericType check somewhere?
Supporting AOT platforms (e.g. iOS, consoles) is a goal of the MessagePack-CSharp project, albeit using their custom mpc.exe solution for generating code, rather than using a source generator.

@clarvalon
Thanks for the bug report
I fixed the issue.

I added .IsGenericType check in GeneratedResolver.TryGetFormatter()as you mentioned.
TinyhandModule.Initialize() is required in your code.

// Add this code before Serialize()
TinyhandModule_YourAssemblyName.Initialize(); // Adding assembly name is required to avoid name conflict in multiple assemblies.

By default, Tinyhand loads generated formatters using ModuleInitializerAttribute.
But it seems ModuleInitializerAttribute doesn't work when using NativeAOT + publishing as a self-contained executable.
It may be NativeAOT's problem.
The current solution is to call the Initializer method manually.
Supporting AOT platforms is the main reason I chose a source generator rather than dynamic code generation.

#96
#97

Thank you for the quick turnaround, and your excellent work on this project!
I can confirm the fix and call to Initialize() works.  I've now gotten my engine working with NativeAOT & TinyHand for state serialization, and performance is absurdly fast 😄

Glad it worked out.
Let me know if you have any questions.


Azure Billing API billingSubscriptionName

What is this field billingSubscriptionName? Reference: https://learn.microsoft.com/en-us/rest/api/billing/2019-10-01-preview/invoices/list-by-billing-subscription?tabs=HTTP
I've tried using this particular API request, and I receive back a 404 error. I've tried using the subscription ID and the subscription name, but 404 each attempt. I've confirmed that I'm using the correct billingAccountName because I'm getting back hydrated responses with other API requests. This seems to be the only API request that is giving me a 404, and it's unfortunate because it's the one I need.

@mclacore Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@mclacore The billingSubscriptionName --> is your concerned subscription id.
I am sending you the sample REST API that I invoked at my end and got the successful response. Hope this helps.

https://management.azure.com/providers/Microsoft.Billing/billingAccounts/default/billingSubscriptions/12345-12345-1234-1234/invoices?api-version=2020-05-01&periodEndDate=2022-09-30&periodStartDate=2022-09-01

@mclacore I wanted to do quick follow-up to check if you had a chance to look at my above comment. Please let us know if you had any updates on this. Awaiting your reply.

@mclacore I also see that you referenced the documentation for 2019-10-01-preview. It's recommended that you refer to the latest stable version 2020-05-01 which shows a similar example to what @navba-MSFT shared.

@bradenwatkins sorry was on PTO.
So the newer version works, but it's also only limited to Microsoft Partner Agreement and Microsoft Customer Agreement type of subscriptions. It doesn't seem to support Microsoft Online Service Program, which is what we need it for.


test: add tests in setting file

This function GetUploadXlsx Path can be returned an invalid value dependent of value is pass.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Rafael Firmino seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove streetview

Pull Request Template
Description
Removed the references to streetview on the gazetteer because it is no longer needed.
GitHub Issue
https://github.com/GEOLYTIX/xyz/issues/1504

https://github.com/GEOLYTIX/xyz_plugins/pull/193
This PR can be used along side this PR To test


Invalid column reference in Table.AddColumn outputs null instead of an error

Preflight Checklist

[X] I have installed the latest version of Power Query SDK.
[X] I have checked existing resources, including the common issues and the release notes.
[X] I have searched for similar issues.

Power Query SDK
0.2.1
Regression From
No response
Platform
Windows
Architecture
x64
OS Version
No response
VSCode version
No response
PQSdkTool Path
No response
Bug Description
In Power Query, when Table.AddColumn's column generator function references a non-existent column, the output generated for the new column should be an error.
Steps to Reproduce

Create a new connector project with a .test.pq file defined as follows (the connector's contents don't matter):let
    Source = Table.View(null, [
            GetRows = () => #table({"A"}, {{1}}),
            GetType = () => Value.Type(GetRows())
        ]),
    Added = Table.AddColumn(Source, "B", each if [NonExistent] <> null then 1 else 2)
in
    Added

Evaluate the test script file.

Actual Experience
The following two-column table is returned:

A
B

1
null

JSON version of the above:
"Output": [
    {
        "A": 1,
        "B": null
    }
]

Expected Experience
Column B should contain an error, not a null value.
Additional Context
If the same M code is evaluated in Power BI's Query Editor, the following output is produced (reflects the expected error):

Wondering if the root issue here is not-Table.AddColumns specific, but rather is that any errors in table cells are rendered out as null by the SDK.
The following expression outputs a table whose third row contains an error in column a when run in Query Editor but contains null when run by the SDK.
Table.Pivot(
    Table.FromRecords({
        [key = "x", z = 123, attribute = "a", value = 1],
        [key = "x", z= 456, attribute = "c", value = 3],
        [key = "y", z= 456, attribute = "a", value = 2],
        [key = "y", z= 456, attribute = "a", value = 4]
    }),
    {"a", "b", "c"},
    "attribute",
    "value"
)

Converting errors to null is by design for our console-based output. We're limited on what we can do outside of the PQ experience. Our options are to either throw an exception or return the cell value as null. I believe the previous VS SDK exposed a project property that let you choose the behavior, but I'm not sure we need to expose that behavior. Longer term, we want to use an embedded PQ experience for testing, which should give you the behavior you're looking for.
Here is a longer response regarding errors that Curt wrote up a while back:

We distinguish informally between “top-level errors”, “row-level errors” and “cell-level errors”. These can best be described as follows. Let’s say that your query calculates and returns some table value T. After T has been calculated, we iterate over the rows of T and return the values in each row. A top-level error is one which happens in the process of calculating T. It entirely prevents T from being produced. A row-level error is one which happens when fetching the next row of T. Because the state of the enumeration is unknown, we have to abandon it and report a failure. A cell-level error is one which happens when calculating an individual value in a row of T. Because it doesn’t prevent us from reading other values or continuing to iterate through the rows, it is the least blocking.

Here's the fun part. You can “upgrade” the error by forcing it to be examined “early”. So if your calculation of the top-level value forces enumeration of the table, then a row-level error gets turned into a top-level error. And if the process of moving to the next row forces evaluation of an error value, then a cell-level error gets turned into a row-level error. Consider

let
    Source = #table({"A", "B"}, {{"1", "2"}, {"3", "A"}}),
    AsNumber = Table.TransformColumnTypes(Source, {{"B", type number}}),
    Filtered = Table.SelectRows(AsNumber, each [B] < 100),
    Buffered = Table.Buffer(Filtered)
in
    Buffered

Source has no errors.
AsNumber contains a cell-level error for the B column in the second row.
Filtered upgrades this to a row-level error because it forced evaluation of the cell-level error when moving to the second row.
Buffered upgrades this to a top-level error because it forced the entire table to be enumerated before returning.

Now, top-level and cell-level errors have pretty well-defined behavior because in both cases there’s effective a single value which is in an error state. Row-level errors are a bit of an oddball, because there are no language semantics for enumeration; it’s just something which happens. So there’s no way to trap or represent these. If in the above example you were to look at the value of “Filtered” in Excel, you’d see a single row consisting entirely of error values, and that’s the best we can do inside of M itself. It’s much easier to distinguish these in our consumption layer, because now enumeration is a first-class operation. So enumeration can be made to throw the exception instead of having to rely on a row full of errors.

Thank you, @mattmasson, for sharing that explanation.
@CurtHagenlocher, you should seriously consider turning this into a blog post for the PQ blog...or as a guest contribution for my blog! :-)

Hmm....with a text-based output format (like the SDK currently provides), I could imagine outputting error info on a cell-by-cell basis by rendering each individual M cell value as a "try record" of sorts...something like:
"Output": [
    {
        "A": [HasError = false, Value = 1, Type = number],
        "B": [HasError = true, Error = {error goes here)]
    }
]

Technically works, but not the prettiest. At least, it's an idea, for what it's worth (may be more of interest to provide an error-enhanced output format option like this if the SDK's base library is expanded to be a general-purpose "run PQ to produce output" tool).
Would a much simpler fail-safe for now be to add a top-level Boolean property to the output of run-test indicating whether any cell-level errors were encountered? So, in the case of the example table, the consumer (e.g. me) could notice that this property is true. While that won't reveal which cell(s) errored, or what the error(s) was, at least the consumer would be warned that they shouldn't trust the nulls they're receiving, as they might actually represent suppressed errors.


Is there an issue with Unity2017.2.p2

Overview
Experiencing severe color seperation when walking around an anchored object. Even with explicitly set stabilization plane.
Expected Behavior
Anchored Hologramm should be in focus and is absolutly not expected to show color seperation as described here: https://developer.microsoft.com/en-us/windows/mixed-reality/hologram_stability
Actual Behavior
After anchoring an Object view is fine. Walking around it (after 90 degrees) shows extreme Color Separation, although movement is slow.  Downgrading to Unity3D 2017.2.f1 shows normal behaviour.
Steps to reproduce
Use Unity3D patch release 2017.2.p2. Use MRT demoscene tab to place. Place object in spatial room. Walk around.
Unity Editor Version
2017.2.p2
Mixed Reality Toolkit Release Version
latest i guess.

latest i guess.

latest from the master branch or the latest release?

Now i am embarressed. i pulled with github Desktop and copied necessary files to my Project. base is: https://github.com/Microsoft/MixedRealityToolkit-Unity.git and pull was from 2 weeks ago.
is there some file inside holotoolkits Folders to check a Version number?
I am very sorry, i know These Kind of questions are cumbersome!

No worries! It just really helps when we're trying to pinpoint the issue.
You're right, we really ought to add a version number to the license or readme someplace.
In either case, I'm not sure anything has really changed with the anchoring recently.  That stuff has been pretty stable up until now.
I have not tested MRTK compatibility with the new patch release yet, as we were waiting for a special MRTP build, so I cannot attest to knowing the changes Unity has rolled out.
Sounds like this could potentially be an Editor bug.  Try creating some repro steps that don't include the MRTK just to rule it out.

Currently i'm having this issue, MRTP5 build. When walking 90 degrees around the placed object heavy color seperation occurs and when standing behind the object it wont stay stable on the ground, it heavilly drifts.
When recording with the mixed reality capture its visible that the object moves towards the camera when standing at the point of heavy color seperation. Almost like the Hololens loses track of depth.
I can't remember but i think it does not happen when the stabilization plane is not set. But than the holograms are not stable then in my case.
Its almost like the stabilization plane doesn't rotate towards the camera in the build, Not able to test this as remote crashes the editor.

This seems to be similar to https://github.com/Microsoft/MixedRealityToolkit-Unity/issues/1481


gui: make max tooltip more legible

This resolves an issue found by @kloaec. I've changed the tooltip position to Bottom instead of Left and added some blank spaces so that text is padded at screen edge.

Full screen:

utACK 617845234c4e64e02b47d4e29971b094f38f5281


Make linter action lint an entire file even if it encounters an error

It appears the linter action catches only the first lint error in each file. For files with multiple lint issues, this means only finding out about them one line at a time. The linter should be reconfigured to lint the entirety of the file and report all issues on the first pass.

I think that's okay. Since you set up pre-commit, I have been having very few issues with the linter.


workflows: new "CI house keeping"

The e2e libvirt CI on pull request has pushed images to ghcr.io/confidential-containers/cloud-api-adaptor.
This added the ci_house_keeping.yaml workflow to run daily to clean up unused caa imags (e.g. when the pull request is closed).

How I used the script to clean up images from my fork:
[wmoschet@wainer-laptop cloud-api-adaptor]$ ORG=wainersm PACKAGE_BASE_API=/users REPO=cc-cloud-api-adaptor ./hack/ci/gh_cleanup_images.sh
::group::Delete images from closed PRs
PR cc-cloud-api-adaptor/pull/62 is closed
Delete image version=127568786
Delete image version=127568770
Delete image version=127568788
Delete image version=127568773
Delete image version=127568765
Delete image version=127568791
Delete image version=127568793
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr62
PR cc-cloud-api-adaptor/pull/62 is closed
Delete image version=127563353
Delete image version=127563358
Delete image version=127563364
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr62-dev
PR cc-cloud-api-adaptor/pull/61 is closed
Delete image version=127357586
Delete image version=127357587
Delete image version=127357588
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr61-dev
PR cc-cloud-api-adaptor/pull/60 is closed
Delete image version=127311708
Delete image version=127311705
Delete image version=127311717
Delete image version=127311713
Delete image version=127311711
Delete image version=127311720
Delete image version=127311724
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr60
PR cc-cloud-api-adaptor/pull/60 is closed
Delete image version=127309604
Delete image version=127309606
Delete image version=127309608
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr60-dev
PR cc-cloud-api-adaptor/pull/59 is closed
Delete image version=127228715
Delete image version=127228712
Delete image version=127228726
Delete image version=127228723
Delete image version=127228718
Delete image version=127228729
Delete image version=127228732
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr59
PR cc-cloud-api-adaptor/pull/59 is closed
Delete image version=127224439
Delete image version=127224440
Delete image version=127224443
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr59-dev
PR cc-cloud-api-adaptor/pull/58 is closed
Delete image version=127184131
Delete image version=127184126
Delete image version=127184136
Delete image version=127184120
Delete image version=127184117
Delete image version=127184139
Delete image version=127184140
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr58
PR cc-cloud-api-adaptor/pull/58 is closed
Delete image version=127180530
Delete image version=127180533
Delete image version=127180537
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr58-dev
PR cc-cloud-api-adaptor/pull/46 is closed
Delete image version=116862925
Delete image version=116862922
Delete image version=116862929
Delete image version=116862917
Delete image version=116862918
Delete image version=116862933
Delete image version=116862937
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr46
PR cc-cloud-api-adaptor/pull/46 is closed
Delete image version=116860596
Delete image version=116860597
Delete image version=116860599
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr46-dev
PR cc-cloud-api-adaptor/pull/45 is closed
Delete image version=116812394
Delete image version=116812397
Delete image version=116812389
Delete image version=116812392
Delete image version=116812386
Delete image version=116812402
Delete image version=116812404
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr45
PR cc-cloud-api-adaptor/pull/45 is closed
Delete image version=116810190
Delete image version=116810193
Delete image version=116810196
Deleted image ghcr.io/wainersm/cloud-api-adaptor:ci-pr45-dev
::endgroup::
::group::Delete dangling images
Delete image version=127299932
Delete image version=127299930
Delete image version=127299926
Delete image version=127299925
Delete image version=127299923
Delete image version=127299922
Delete image version=127299920
Delete image version=127298973
Delete image version=127298970
Delete image version=127298968
Delete image version=116791282
Delete image version=116791280
Delete image version=116791277
Delete image version=116791275
Delete image version=116791273
Delete image version=116791272
Delete image version=116791270
Delete image version=116787084
Delete image version=116787081
Delete image version=116787078
Delete image version=116742122
Delete image version=116742115
Delete image version=116742110
Delete image version=116742104
Delete image version=116742098
Delete image version=116742092
Delete image version=116742089
Delete image version=116741312
Delete image version=116741307
Delete image version=116741302
Delete image version=116741296
Delete image version=116741290
Delete image version=116741283
Delete image version=116741279
Delete image version=116738135
Delete image version=116738131
Delete image version=116738128
::endgroup::

hey @fidencio ! you might be interested on that script as we are starting to publish kata containers images on ghcr.io

Rebased the code and changed the workflow to run weekly as suggested by @ldoktor

Thank you @wainersm, it looks good to me although I wasn't able to test it due to permission issues so without seeing the json responses from GH I can not guarantee it's all correct. Anyway the approach to get all images and check if that PR is closed or not especially with PR caching seems good to me.
One thing I don't understand is why don't we remove the old images on PR update directly? I mean this upkeep script would be still useful in case some PR fails to remove it for whatever reason so I believe this upkeep script should be here, but perhaps we could even try removing the images on PR update to faster remove the outdated images (at least if I understand it correctly)

@ldoktor can you ptal and provide your review comments.

@wainersm based on the last comment from @ldoktor, is anything pending ?

@wainersm based on the last comment from @ldoktor, is anything pending ?

Not really, it was just a suggestion that we might additionally use on.pull_request.types.closed and clean the images directly on PR close. Still having a cleaner job running makes sense to me in case the on-closed pipeline fails. So the only question is whether we want to add it as well or just rely on weekly cleanup.


Fix TLS mailing

1. Why is this change necessary?
Mail servers requiring TLS are not working because of a typo.
2. What does this change do, exactly?
Swap tsl with tls.
3. Describe each step to reproduce the issue or behaviour.
Try to send mails through an SMTP that requires TLS encrypted connections (eg smtp.office365.com)
4. Please link to the relevant issues (if any).
Probably many, eg https://forum.shopware.com/discussion/65384/e-mail-versand-office365
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-7820
Please use this issue to track the state of your pull request.

You should change it here too:
https://github.com/shopware/platform/blob/de4b8307bc53caf5930f6dcfe71c44a51d5ed786/src/Core/Content/MailTemplate/Service/MailerTransportFactory.php#L38

@hlohaus oh, that file didn't exist in the branch where I debugged the problem (6.1), so I didn't realise that MailerFactory is deprecated. I updated the TransportFactory too now.

Thank you for your contribution :blue_heart: :tada:


File size of library

I'm trying to build this library, but the file size in the dist folder is about 4.1 MBs, which doesn't look right.
Anyways, after looking at the demos, I saw that the dist file is around 1.7 MBs, which also doesn't look right.
Is this library actually that big or is that just some misconfiguration of webpack?

It's not that big.    The demo is huge because it includes all of babel to do client side evaluation of ES6/JSX code.   In addition it includes a complete copy of subschema and react for the demo.    So its  a bit huge.
The dist folder includes several distributions, and sourcemaps.  The sourcemaps are generally bigger than the source.

You're right. I spent some more time and the final result is ~300KB (the noreact version).
I'm wondering if that size can be further reduced somehow? Are you using uglify somewhere?


Write proper plural msgstr[0]

Fixes the same problem as #21 (with tests!).
Before this PR, untranslated plurals were written as follows:
msgid "1 destination"
msgid_plural "{{$count}} destinations"
msgstr ""

POEdit is unable to open a file containing such plural entries. And gettext utility msgcat throws the following error when trying to read the file:
zh-CN.po:44:10: syntax error
zh-CN.po:49:10: syntax error
zh-CN.po:54:10: syntax error
zh-CN.po:6337:10: syntax error
msgcat: found 4 fatal errors

My change will generate this result:
msgid "1 destination"
msgid_plural "{{$count}} destinations"
msgstr[0] ""

The gettext docs aren't totally clear on this point, but that does appear to be the correct syntax. And neither msgcat nor POEdit throw any errors when reading that kind of plural entry.

This PR has a couple other mostly-unrelated changes. (Sorry! I normally hate that.)

I upgraded all devDependencies because I couldn't even npm install with the previous ones

grunt-jscs-checker was renamed to grunt-jscs (https://github.com/jscs-dev/grunt-jscs/commit/033b836)
alias option in grunt-browserify doesn't seem necessary anymore? Browserify v3 was 3+ years ago now!

I removed lodash.isarray in favor of the native Array.isArray. There was already code depending on Object.keys and Array.prototype.filter (https://github.com/rubenv/pofile/blob/v1.0.2/lib/po.js#L309), which are also ES5-only, so I didn't see any reason to not use Array.isArray.

I would be happy to remove any of those changes if you want a cleaner PR. Just let me know!

Love it!
I normally hate it as well when people tack on extra changes, but let's admit it: some maintenance was probably overdue (sucks that we have to do it though!).
See no reason not to merge it.

Thanks for the quick merge!

Published to NPM as v1.0.3. Thanks a lot!

My change will generate this result:
msgid "1 destination"
msgid_plural "{{$count}} destinations"
msgstr[0] ""

Poedit dev here. My understanding of the file format is that this is still incorrect, the number of msgstr[] entries must match the nplurals value from the Plural-Forms header. See POT files generated by GNU gettext's xgettext, they output English Plural-Forms with nplurals=2 and plural entries are always output as
msgid "%d foo"
msgid_plural "%d foos"
msgstr[0] ""
msgstr[1] ""

by it. Poedit tries not to choke on bad inputs, so that alone is not proof of correctness ;)

The gettext docs aren't totally clear on this point

GNU gettext manual is indeed not very good as a PO format reference. It's best to consult "official" GNU gettext tools' output as examples or consult Pology's unofficial, but great PO format reference.

@vslavik Thanks for weighing in!

Thanks @vslavik! After testing, I think you are correct about the number of msgstrs matching the nplurals. Here's what I've come up with:
messages.po file (i.e., POT), generated by xgettext as nplurals=INTEGER:
msgid "1 thing"
msgid_plural "%i things"
msgstr[0] ""
msgstr[1] ""

zh-CN.po file (nplurals=1), after using msgmerge to pull the POT changes in:
msgid "1 thing"
msgid_plural "%i things"
msgstr[0] ""

pl-PL.po file (nplurals=3), after using msgmerge to pull the POT changes in:
msgid "1 thing"
msgid_plural "%i things"
msgstr[0] ""
msgstr[1] ""
msgstr[2] ""

So the reason my PR worked for me was that zh-CN was the only problem language in my project. Whoops. 😊
I'll work on getting another PR soon to output the proper number based on nplurals.


the problem about building my flutter app.

same as #272 , the problem occurred when I try to build my app.(my flutter app has no problem occurred when I run it with flutter run)
e: C:\Users\sdjal\AppData\Local\Pub\Cache\hosted\pub.flutter-io.cn\fluttertoast-7.1.8\android\src\main\kotlin\io\github\ponnamkarthik\toast\fluttertoast\MethodCallHandlerImpl.kt: (45, 84): Unresolved reference: R
e: C:\Users\sdjal\AppData\Local\Pub\Cache\hosted\pub.flutter-io.cn\fluttertoast-7.1.8\android\src\main\kotlin\io\github\ponnamkarthik\toast\fluttertoast\MethodCallHandlerImpl.kt: (70, 68): Unresolved reference: R
e: C:\Users\sdjal\AppData\Local\Pub\Cache\hosted\pub.flutter-io.cn\fluttertoast-7.1.8\android\src\main\kotlin\io\github\ponnamkarthik\toast\fluttertoast\MethodCallHandlerImpl.kt: (85, 64): Unresolved reference: R

I tried to change my compileSdkVersion,targetSdkVersion to 30 and my minSdkVersion to 18, but it doesn't work.
And i don't want to change my gradle version because it'll get more problems caused by other sdk.
Maybe the warning before the error can help:
w: C:\Users\sdjal\.gradle\caches\transforms-2\files-2.1\09454473a42aae3315ec17d0e8dba6e4\jetified-kotlin-stdlib-jdk7-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.4
w: C:\Users\sdjal\.gradle\caches\transforms-2\files-2.1\0f93dec1cca0b151efd4318a3ec970ab\jetified-kotlin-stdlib-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.4
w: C:\Users\sdjal\.gradle\caches\transforms-2\files-2.1\164a6c97dbd4f554198bb77e768fcc8d\jetified-kotlin-stdlib-common-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.4

A temporary solution to this problem is to downgrade to version 7.1.6.
In pubspec.yaml:
dependencies:
      ...
      fluttertoast: 7.1.6
      ...

then
$ flutter pub upgrade


Migrate samples metrics to V2

Fixes issue - https://github.com/Azure/azure-sdk-for-js/issues/14476

/check-enforcer override


⚠ Bofrost.be has degraded performance

In 6c33ece, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1229 ms

Resolved: Bofrost.be performance has improved in a3878d3.


ERR connect miio.device next try 2 minutes Error:Could not connect to device handshake timeout

I have problem connection since yesterday impossible to reconnect my roborock S6 to my homebridge , i have error message :
ERR connect miio.device next try 2 minutes Error:Could not connect to device handshake timeout
I restarted roborock , wifi, homebridge

same here

I have this, too, but only just installed the plugin so will run through docs to make sure I haven’t messed up.

Did you find a fix for this? Mine started doing this too.

It didn't help me. See #444

@zifou2015, did you manage to reconnect your device?

Hey,
did anyone have new information on that topic? I have exactly the same issue since a couple of days. Interestingly, when i installed and configured the plugin everything was working fine. Then, after some days the connection issues began and the roborock isnt responding in homekit anymore. I also tried restarting the docker and my wifi (no fritzbox, its a vodafone station). Here is my config and my homebridge console:

@Rene1695 did you reconfigured the wifi in the robot or used the Roborock app? Sometimes doing any of those 2 generates a fresh token and invalidates previous ones.

@afharo: no nether i reconfigured the wifi in the robot nor i used the roborock app. When the error occurs i double checked the token in the config.js with the Mi cloud token app. I can confirm that the token has not changed.
Surprisingly since a couple of days, the error is gone and i can use the roborock in homekit again. I had some wifi issues with vodafone (and also connection issue with some Matter devices). So i have done a lot of network resets and now it is working.
Sadly i can not really describe, what the solution to this problem is, because i did not really understand the problem with the plugin. Looking at the output log file confirms, that there is communication with the roborock (e.g. SoC value was transmitted). This lets me conclude, that the token must be correct on both sides. But then there was this handshake timeout which i can not explain.
Anyway, it is working now. If the issue will raise again, i will report to you. Thank you so far :)


add http/https proxy support on local

add local_http_port config to provide http proxy service.
https_proxy=http://localhost:8080 curl -v https://www.google.com/
http_proxy=http://localhost:8080  curl -v http://www.google.com/
https_proxy=http://localhost:8080 go get -u golang.org/x/sys/...

nope ，ss is a socks5 proxy，should not assume any http proxy
this can be added as a util tool
Best regards
✉✉✉✉✉✉✉✉✉✉✉✉✉✉
Arthur lee
Sent from my iPhone

On 9 Aug 2017, at 9:13 AM, Peter Jiang<EMAIL_ADDRESS>wrote:
add local_http_port config to provide http proxy service.
https_proxy=http://localhost:8080 curl -v https://www.google.com/
http_proxy=http://localhost:8080   curl -v http://www.google.com/
http_proxy=http://localhost:8080 go get -u golang.org/x/sys/...
You can view, comment on, or merge this pull request online at:
https://github.com/shadowsocks/shadowsocks-go/pull/236
Commit Summary
add http/https proxy support on local
File Changes
A cmd/shadowsocks-local/httpproxy.go (119)
M cmd/shadowsocks-local/local.go (17)
M sample-config/client-multi-server.json (1)
M shadowsocks/config.go (13)
Patch Links:
https://github.com/shadowsocks/shadowsocks-go/pull/236.patch
https://github.com/shadowsocks/shadowsocks-go/pull/236.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Update Routing.MD file to correct the typo

Made a small change to correct the spelling from assocated to associated

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@ljnotes Thank you!


Handle plurals correctly in MaterialLocalizations

Per _nameToPluralValue in GlobalMaterialLocalizations (see https://github.com/flutter/flutter/pull/12410)
The rules for mapping from an integer value to "one" or "two" etc. are locale specific and an additional "few" category is needed. See http://cldr.unicode.org/index/cldr-spec/plural-rules
The necessary information is in the intl package although it may not be exposed as a public API at the moment.

@HansMuller I looked at that URL but I couldn't figure out how to implement "few" from this.

Hi @HansMuller
Is this issue valid?
https://api.flutter.dev/flutter/intl/Intl/pluralLogic.html
Thank you

@TahaTesser
I also think this issue is invalid.

Hi @YeungKC
Thanks
Closing
If anyone disagree, please write in the comments and I will reopen it.
Thank you


Allow to configure trace propagation in Sender

v1 was relying on the now archived sdk for servicebus, which had built-in trace propagation.
v2 needs to provide trace propagation in its Sender.

closed by #113


MINIFI-242 - Initial integration tests focused around backwards compa…

…tibility
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] - N/A - If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
[X] - N/A - If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?

For documentation related changes:

[X] - N/A - Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

reviewing

hey @brosander,
these are really great and an awesome start to getting some more testing available.  would you mind adding a few blurbs to our README about the docker profile and running them?

@apiri added said blurbs

rebased after merge of #75

@brosander thanks for the update and rebase.  Looks great.  This functionality is top notch to get some nice testing setup, thanks!  will get merged


Ram Usage is going too high

I am having Hp pavilion gaming laptop with 8 gb ram . Normally my laptop’s ram usage is 28-40% but when I open Chrome and use autoclicker in (https://suvidha-mp.wb.gov.in/ ), after login in, my laptop’s ram usage hikes to 90-99% and chrome gets hang .

Can you check your configuration if you have used retry / recheck without interval value .

If possible do share configuration with us

Can you check your configuration if you have used retry / recheck without interval value .

yes I checked it was zero then i changed it to 0.1sec and now it is solved . Thanks to you for providing such a good extension free


Unpublished parts should not be viewable

We can now choose unpublished parts in the picker. However, the modules list shouldn't be shown but the view that explains to the user that this hasn't been published yet (also the view that contains the external link if enabled) should be shown.

Assigning to @bp323 for review

Coverage remained the same at 100.0% when pulling 74db68fa7334042facc974f400f7d377b4c598ec on Coenego:issue-405-unpublished-parts into bed1b272a8a73c639a92cfae1bd5d74908327ede on CUL-DigitalServices:master.

A couple of functional issues:

When I select a drafted part in the pickers, the view flickers from calendar to empty view to calendar again.
When I refresh that state I get the empty view as expected, but the minimised class is not applied as expected.

Back to @Coenego for followup

Coverage remained the same at 100.0% when pulling 1361cbb1a607a0db57d5f2bf0030feafad283f1f on Coenego:issue-405-unpublished-parts into 57f2f1b582598a0dd3666e3313a30a5dc94b53ff on CUL-DigitalServices:master.

Looks good, only need to sort out the module bar that shouldn't be shown.

Coverage remained the same at 100.0% when pulling 78ae778ef2cafda83894c9238de948914e7b4545 on Coenego:issue-405-unpublished-parts into 062f56fd72ba50c2c3e4ccc53ca26cc75384ff45 on CUL-DigitalServices:master.

Assigning to @bp323 for review

Coverage remained the same at 100.0% when pulling 93b60f3f40b27cd50ffbbbab713b718847a9bb29 on Coenego:issue-405-unpublished-parts into 062f56fd72ba50c2c3e4ccc53ca26cc75384ff45 on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 93b60f3f40b27cd50ffbbbab713b718847a9bb29 on Coenego:issue-405-unpublished-parts into 062f56fd72ba50c2c3e4ccc53ca26cc75384ff45 on CUL-DigitalServices:master.

Verified and merged.


Update CMAKE_PREFIX_PATH to CMAKE_INSTALL_PREFIX

Description of changes
This fixes what I believe is a small mistake/typo in the README.
In the CMake configure command, previously -DCMAKE_PREFIX_PATH was provided which is used to tell CMake where to look for installed libraries (not where to install the library that will be built). For that, you need to use -DCMAKE_INSTALL_PREFIX which I believe it what was intended here.
The flow is usually something like this...
cd aws-sdk-cpp
cmake -B build -DCMAKE_INSTALL_PREFIX=../aws-demo/install -DBUILD_ONLY="s3"
cmake --build build --target install
cd ../aws-demo
cmake -B build -DCMAKE_PREFIX_PATH=install
cmake --build build

There's a chance I've misunderstood and the intention was to find existing libraries, if so please ignore this.
Thanks!
(For reference see the CMake docs CMAKE_PREFIX_PATH and CMAKE_INSTALL_PREFIX.
Check all that applies

[x] Did a review by yourself.
[ ] Added proper tests to cover this PR. (If tests are not applicable, explain.)
[ ] Checked if this PR is a breaking (APIs have been changed) change.
[ ] Checked if this PR will not introduce cross-platform inconsistent behavior.
[x] Checked if this PR would require a ReadMe/Wiki update.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for approving. Is there anything else needed before it can be merged? Thanks!


Copy Ben's Webpack 4 to 5 upgrade

Copies Ben's Webpack 4 to 5 upgrade

Steps to test

Start Local with its the master branch
In this repo: yarn build && npm pack
You'll see a .tar.gz file in this repo's root
Go to a site with at least 1 large image on it
Tools > Image Optimizer > Scan for Images > Optimize Images:

Expected:

This is needed before we can do https://github.com/getflywheel/local-addon-image-optimizer/pull/78

Thanks a lot for reviewing this, @nickcernis!


Add move_scoreatpercentile()

Add a moving window scoreatpercentile function. It could be based on the move_median code with some slight modifications.

:+1:  is this complicated to implement ?

My four year old comment makes it sound easy. But you know how that goes. The move_median code is the most complicated code in bottleneck. And I'm not too excited about using it as the basis of other function until it can handle NaNs.
It is already a scoreatpercentile function if you want the score at the 50th percentile. You could hack something together to move the 50th percentile. If you do, let us know how it goes.

bn.move_median now supports NaNs and min_count. So we are in good shape to add a move_percentile function.