When will TFRT integration be fully released?

Click to expand!
Issue Type
Support
Have you reproduced the bug with TF nightly?
No
Source
source
Tensorflow Version
master, commit id 1bd12b4863759e44da4139628973f372655b14f6
Custom Code
No
OS Platform and Distribution
Linux
Mobile device
No response
Python version
No response
Bazel version
6.1.0
GCC/Compiler version
8.3.1
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Firstly, the TFRT integration is disable in .bazelrc.
Comment out TFRT deleted packages in .bazelrc, add deps for tensorflow serving, fix some reference in BUILD, blah, blah, blah...The build is still broken.
diff --git a/.bazelrc b/.bazelrc
index e26bf6de7f8..48edf30f4c7 100644
--- a/.bazelrc
+++ b/.bazelrc
@@ -694,10 +694,10 @@ build:ubsan --linkopt -fsanitize=undefined
 build:ubsan --linkopt -lubsan

 # Disable TFRT integration for now unless --config=tfrt is specified.
-build      --deleted_packages=tensorflow/core/tfrt/stubs,tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/ir,tensorflow/compiler/mlir/tfrt/ir/mlrt,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/mlrt,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/compiler/mlir/tfrt/transforms/mlrt,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/mlrt,tensorflow/core/tfrt/mlrt/attribute,tensorflow/core/tfrt/mlrt/kernel,tensorflow/core/tfrt/mlrt/bytecode,tensorflow/core/tfrt/mlrt/interpreter,tensorflow/compiler/mlir/tfrt/translate/mlrt,tensorflow/compiler/mlir/tfrt/translate/mlrt/testdata,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils,tensorflow/core/tfrt/utils/debug,tensorflow/core/tfrt/saved_model/python,tensorflow/core/tfrt/graph_executor/python
+# build      --deleted_packages=tensorflow/core/tfrt/stubs,tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/ir,tensorflow/compiler/mlir/tfrt/ir/mlrt,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/mlrt,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/compiler/mlir/tfrt/transforms/mlrt,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/mlrt,tensorflow/core/tfrt/mlrt/attribute,tensorflow/core/tfrt/mlrt/kernel,tensorflow/core/tfrt/mlrt/bytecode,tensorflow/core/tfrt/mlrt/interpreter,tensorflow/compiler/mlir/tfrt/translate/mlrt,tensorflow/compiler/mlir/tfrt/translate/mlrt/testdata,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils,tensorflow/core/tfrt/utils/debug,tensorflow/core/tfrt/saved_model/python,tensorflow/core/tfrt/graph_executor/python
 # TODO(b/240450920): We are in the process of migrating JitRt backend to XLA
 # and while we are doing this we can't keep it buildable/testable in OSS.
-build:tfrt --deleted_packages=tensorflow/core/tfrt/stubs,tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/ir,tensorflow/compiler/mlir/tfrt/ir/mlrt,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/mlrt,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/compiler/mlir/tfrt/transforms/mlrt,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/mlrt,tensorflow/core/tfrt/mlrt/attribute,tensorflow/core/tfrt/mlrt/kernel,tensorflow/core/tfrt/mlrt/bytecode,tensorflow/core/tfrt/mlrt/interpreter,tensorflow/compiler/mlir/tfrt/translate/mlrt,tensorflow/compiler/mlir/tfrt/translate/mlrt/testdata,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils,tensorflow/core/tfrt/utils/debug,tensorflow/core/tfrt/saved_model/python,tensorflow/core/tfrt/graph_executor/python
+# build:tfrt --deleted_packages=tensorflow/core/tfrt/stubs,tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/ir,tensorflow/compiler/mlir/tfrt/ir/mlrt,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/mlrt,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/compiler/mlir/tfrt/transforms/mlrt,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/mlrt,tensorflow/core/tfrt/mlrt/attribute,tensorflow/core/tfrt/mlrt/kernel,tensorflow/core/tfrt/mlrt/bytecode,tensorflow/core/tfrt/mlrt/interpreter,tensorflow/compiler/mlir/tfrt/translate/mlrt,tensorflow/compiler/mlir/tfrt/translate/mlrt/testdata,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils,tensorflow/core/tfrt/utils/debug,tensorflow/core/tfrt/saved_model/python,tensorflow/core/tfrt/graph_executor/python

 # TF Fuzztest config
 try-import fuzztest.bazelrc
diff --git a/tensorflow/compiler/mlir/tfrt/ir/mlrt/tf_ops.td b/tensorflow/compiler/mlir/tfrt/ir/mlrt/tf_ops.td
index<PHONE_NUMBER>d..cee88fb112b 100644
--- a/tensorflow/compiler/mlir/tfrt/ir/mlrt/tf_ops.td
+++ b/tensorflow/compiler/mlir/tfrt/ir/mlrt/tf_ops.td
@@ -19,8 +19,8 @@ limitations under the License.
 include "tensorflow/compiler/mlir/tfrt/ir/mlrt/tf_mlrt_dialect.td"
 include "tensorflow/compiler/mlir/tfrt/ir/mlrt/mlrt_dialect.td"
 include "tensorflow/compiler/mlir/tensorflow/ir/tf_op_base.td"
-include "third_party/tf_runtime/include/tfrt/compiler/opdefs/tfrt_op_interfaces.td"
-include "third_party/tf_runtime/include/tfrt/compiler/opdefs/tfrt_traits.td"
+include "external/tf_runtime/include/tfrt/compiler/opdefs/tfrt_op_interfaces.td"
+include "external/tf_runtime/include/tfrt/compiler/opdefs/tfrt_traits.td"

 // tf_mlrt.tf_await returns a tensorflow Tensor. It is a fake op that is only
 // used during parallelization and has no runtime implementation.
diff --git a/tensorflow/compiler/mlir/tfrt/transforms/mlrt/BUILD b/tensorflow/compiler/mlir/tfrt/transforms/mlrt/BUILD
index beb50129756..ec69705437e 100644
--- a/tensorflow/compiler/mlir/tfrt/transforms/mlrt/BUILD
+++ b/tensorflow/compiler/mlir/tfrt/transforms/mlrt/BUILD
@@ -74,7 +74,7 @@ cc_library(
         "//tensorflow/compiler/mlir/tfrt/ir/mlrt:tf_mlrt_tpu_ops",
         "//tensorflow/core/tfrt/fallback:fallback_state",
         "//tensorflow/core/tfrt/fallback:op_kernel_runner_cache",
-        "//third_party/protobuf",
+        "@com_google_protobuf//:protobuf",
         "@llvm-project//mlir:FuncDialect",
         "@llvm-project//mlir:FuncTransforms",
         "@llvm-project//mlir:IR",
@@ -150,7 +150,7 @@ cc_library(
         ":assign_op_key",
         ":passes",
         ":while_to_map_fn",
-        "//base:vlog",
+        # "//base:vlog",
         "//tensorflow/compiler/mlir/tensorflow:dump_mlir_util",
         "//tensorflow/compiler/mlir/tensorflow:error_util",
         "//tensorflow/compiler/mlir/tfrt:import_model",
diff --git a/tensorflow/core/tfrt/graph_executor/BUILD b/tensorflow/core/tfrt/graph_executor/BUILD
index 7cef54cdb69..7e4537869c1 100644
--- a/tensorflow/core/tfrt/graph_executor/BUILD
+++ b/tensorflow/core/tfrt/graph_executor/BUILD
@@ -152,7 +152,7 @@ cc_library(
     visibility = ["//visibility:public"],
     deps = [
         ":config_proto_cc",
-        "//google/protobuf:any_cc_proto",
+        # "//google/protobuf:any_cc_proto",
         "@com_google_absl//absl/status",
         "@com_google_absl//absl/status:statusor",
     ],
@@ -161,7 +161,7 @@ cc_library(
 tf_proto_library(
     name = "config_proto",
     srcs = ["config.proto"],
-    protodeps = ["//google/protobuf:any"],
+    # protodeps = ["//google/protobuf:any"],
     visibility = ["//visibility:public"],
 )

@@ -187,7 +187,7 @@ cc_library(
     hdrs = ["sync_resource_state.h"],
     visibility = ["//visibility:public"],
     deps = [
-        "//tensorflow_serving/util:any_ptr",
+        "@tensorflow_serving//tensorflow_serving/util:any_ptr",
         "@tf_runtime//:tensor",
     ],
 )
diff --git a/tensorflow/core/tfrt/graph_executor/sync_resource_state.h b/tensorflow/core/tfrt/graph_executor/sync_resource_state.h
index 1571fc01352..159f1714a71 100644
--- a/tensorflow/core/tfrt/graph_executor/sync_resource_state.h
+++ b/tensorflow/core/tfrt/graph_executor/sync_resource_state.h
@@ -18,7 +18,7 @@ limitations under the License.
 #include <utility>
 #include <vector>

-#include "third_party/tensorflow_serving/util/any_ptr.h"
+#include "tensorflow_serving/tensorflow_serving/util/any_ptr.h"
 #include "tfrt/tensor/dense_host_tensor.h"  // from @tf_runtime
 namespace tensorflow {
 namespace tfrt_stub {
diff --git a/tensorflow/workspace3.bzl b/tensorflow/workspace3.bzl
index 91871db22c8..c16b5d0ab9b 100644
--- a/tensorflow/workspace3.bzl
+++ b/tensorflow/workspace3.bzl
@@ -2,6 +2,7 @@

 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 load("//third_party:tf_runtime/workspace.bzl", tf_runtime = "repo")
+load("//third_party:tensorflow_serving/workspace.bzl", tensorflow_serving = "repo")
 load("//third_party/llvm:workspace.bzl", llvm = "repo")

 def workspace():
@@ -16,6 +17,7 @@ def workspace():
     )

     tf_runtime()
+    tensorflow_serving()

     # https://github.com/bazelbuild/bazel-skylib/releases
     http_archive(
diff --git a/third_party/tensorflow_serving/workspace.bzl b/third_party/tensorflow_serving/workspace.bzl
new file mode 100644
index<PHONE_NUMBER>0..5e5f54b6f1a
--- /dev/null
+++ b/third_party/tensorflow_serving/workspace.bzl
@@ -0,0 +1,20 @@
+"""Provides the repository macro to import TFRT."""
+
+load("//third_party:repo.bzl", "tf_http_archive", "tf_mirror_urls")
+
+def repo():
+    TFRT_COMMIT = "bd203faa888dd5ce90f21e3ee9af92dbc90b8a25"
+    TFRT_SHA256 = ""
+
+    tf_http_archive(
+        name = "tensorflow_serving",
+        sha256 = TFRT_SHA256,
+        strip_prefix = "serving-{commit}".format(commit = TFRT_COMMIT),
+        urls = tf_mirror_urls("https://github.com/tensorflow/serving/archive/{commit}.tar.gz".format(commit = TFRT_COMMIT)),
+        # A patch file can be provided for atomic commits to both TF and TFRT.
+        # The job that bumps the TFRT_COMMIT also resets patch_file to 'None'.
+        patch_file = None,
+    )

Standalone code to reproduce the issue
bazel build  --incompatible_fix_package_group_reporoot_syntax=false tensorflow/core/tfrt/graph_executor:graph_executor

Relevant log output
external/tf_runtime/lib/basic_kernels/opdefs/tfrt_base.cc:80:9:   required from here
bazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/CallOpInterfacesIncGen/mlir/Interfaces/CallInterfaces.h.inc:155:56: error: 'class tfrt::compiler::CallOp' has no member named 'setCalleeFromCallable'; did you mean 'getCallableForCallee'?
   return (llvm::cast<ConcreteOp>(tablegen_opaque_val)).setCalleeFromCallable(callee);
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
          getCallableForCallee
bazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/CallOpInterfacesIncGen/mlir/Interfaces/CallInterfaces.h.inc:155:84: error: return-statement with a value, in function returning 'void' [-fpermissive]
   return (llvm::cast<ConcreteOp>(tablegen_opaque_val)).setCalleeFromCallable(callee);
                                                                                ^
cc1plus: warning: unrecognized command line option '-Wno-unused-local-typedef'
Target //tensorflow/core/tfrt/graph_executor:graph_executor failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 72.836s, Critical Path: 33.33s
INFO: 247 processes: 21 internal, 226 local.
FAILED: Build did NOT complete successfully

@bchetioui , Could you please take a look into this, it is related to your commit https://github.com/tensorflow/tensorflow/commit/1bd12b4863759e44da4139628973f372655b14f6

@sachinprasadhs @ychensha Hi, just to confirm, did you narrow down the failure to my commit? It is a very small change which doesn't add/remove any dependency to any file, and has nothing to do with TFRT---I'd be surprised if it had anything to do with the failure reported here.

Understood, Thank you!


HHH-7809: Use SessionFactory.name for the CacheManager... or a UUID

Closes HHH-7809 // @chrisdennis wdyt?

@henri-tremblay Here's what I think we want. I'll look into adding some test later this afternoon

Thanks @alexsnaps. Everything seems meaningful. I'll let @chrisdennis play with it since he's the one on the topic.

Applied upstream with UUID changes discussed here.  Thanks guys!


Complying with E501

This change revives the E501 Flake8 option (line too long).
There is a large diff because of separating BASIC_WORDS into another file.

Black is also failing due to well-known bug: https://github.com/psf/black/issues/2964
we need upgrading it

#196 fixes the issue around Black.


Handling commands tutorial crashes node process

Follow the Handling Commands section of this tutorial http://docs.botframework.com/builder/node/guides/core-concepts/
Expected result:
hello
Hi! What is your name?
John
Hello John!
set name
What would you like to change it to?
John Smith
hello
Hello John Smith!
quit
Actual Result:
hello
Hi! What is your name?
John
Hello John!
set name
What would you like to change it to?
John Smith
--crash--

This seems to be the same bug that I wrote thoroughly about here. We should link these bugs together.

Closing this issue which looks like it was solved with V3 via #532 . Thanks!

great


Self Hosted AI OpenAI api endpoint

Is it possible to use the endpoint of OpenAI to use a self hosted au instead of OpenAI?

You can change the answer behaior (with your own model) and change this based on that
Good luck!


[HDBProcedure] Reserved word row

SAP DBTech JDBC: [257]: sql syntax error: incorrect syntax near "row": line 2 col 8 (at pos 76)
When the row word is used as a parameter for IN, hana returns error.
Example:
PROCEDURE "DEMO"."demo::get_user"(
		IN row "DEMO"."demo::users",
		OUT error TABLE (
			"HTTP_STATUS_CODE" integer,
			"ERROR_MESSAGE" NVARCHAR(100),
			"DETAIL" NVARCHAR(100)

		)
	)
	LANGUAGE SQLSCRIPT
	SQL SECURITY INVOKER
	DEFAULT SCHEMA LEARNING
	---READS SQL DATA
AS
BEGIN
   declare u_id string;
   declare u_name string;

   select ID, NAME into u_id, u_name from :row;

END;

Target
Adjust the content of the procedure to change the reserved word row to row1

Fixed with #1553


Add setting for max number of expanded books

This PR fixes #11482
Add a setting for maximum amount of books expanded in the Notebooks Viewlet.
Here's a gif of how it works:

Coverage decreased (-2.6%) to 37.598% when pulling 917a5795cf072ac44a0fc3d2e87bb9840ad8ee63 on bavaldez/collapseBooks into 9d1587f00861ba9e98b92a3198d31481349de27e on main.

Did you talk with @MsSQLGirl about this solution? This seems like it should solve it but I'm a little worried about discoverability - might be worth seeing if she has any ideas how she'd like this to function.

@Charles-Gagnon yes we did. This can be enabled at the workspace level, which is sufficient for that particular scenario.

The behavior seems to be what we are expecting. + @rajeshka & @joberume to review.
@barbaravaldez  - I'll review the text / label of the settings to ensure that the intent of the setting is clear. Thanks :)


After reboot untether and unc0ver say it’s unsupported

I make a reboot yesterday and now unc0ver+untether is unsupported

Close password reboot

I don't use any password on my phone

After restart open cydia it will crash,right after cydia crashed ooen untethered with the icon of uncover jailbreak and it will restart,after restart cydia will open


no support for -dbgsym packages

In stretch, debian added support for dbgsym packages [1].  Here is some sample output.  Packages are built with debuild.
aptly repo include -no-remove-files=true -config=../aptly.conf -repo=stretch artifacts
gpgv: Signature made Wed 06 Jan 2016 10:11:54 PM CST using DSA key ID A8AC8032
gpgv: Good signature from "Gary Kramlich (grim<EMAIL_ADDRESS>Loading repository stretch for changes file gplugin_0.0.21_amd64.changes...
[+] gir1.2-gplugin-0.0_0.0.21_amd64 added
[+] gplugin_0.0.21_source added
[+] libgplugin-dev_0.0.21_amd64 added
[!] libgplugin-gtk-bin-dbgsym_0.0.21_amd64 has been ignored as it doesn't match restriction
[+] libgplugin-gtk-bin_0.0.21_amd64 added
[+] libgplugin-gtk-dev_0.0.21_amd64 added
[+] libgplugin-gtk0-dbg_0.0.21_amd64 added
[+] libgplugin-gtk0_0.0.21_amd64 added
[+] libgplugin-loaders_0.0.21_all added
[!] libgplugin-lua-dbgsym_0.0.21_amd64 has been ignored as it doesn't match restriction
[+] libgplugin-lua_0.0.21_amd64 added
[!] libgplugin-python-dbgsym_0.0.21_amd64 has been ignored as it doesn't match restriction
[+] libgplugin-python_0.0.21_amd64 added
[+] libgplugin0-dbg_0.0.21_amd64 added
[+] libgplugin0_0.0.21_amd64 added
[!] Some files were skipped due to errors:
  artifacts/libgplugin-gtk-bin-dbgsym_0.0.21_amd64.deb
  artifacts/libgplugin-lua-dbgsym_0.0.21_amd64.deb
  artifacts/libgplugin-python-dbgsym_0.0.21_amd64.deb
ERROR: some files failed to be added

I've been trying to figure out how the package restrictions work, but so far haven't been able to grok it enough to fix it.
[1] https://wiki.debian.org/AutomaticDebugPackages

forgot to add my aptly version
$ apt-cache policy aptly
aptly:
  Installed: 0.9.6~dev+156+g339bf0a
  Candidate: 0.9.6~dev+156+g339bf0a
  Version table:
 *** 0.9.6~dev+156+g339bf0a 500
        500 http://repo.aptly.info nightly/main amd64 Packages
        100 /var/lib/dpkg/status

@grimmy most probably we need some fix here https://github.com/smira/aptly/blob/master/deb/changes.go#L167
aptly internally tries to make sure that only packages which were built from that .changes are processed.

Okay, I was looking at that part, but it wasn't quite clicking on how it worked.  I'll hopefully get a chance to look at it again soon, but I'm not sure when.

Match is done on Source:  field in stanza, so it works usually for all binary packages generated from some source package.

@grimmy if you could upload .changes file and packages built to some place, it would help me to debug the issue.

@smira here you go
https://guifications.org/jenkins/view/GPlugin/job/gplugin-debian-stretch-amd64/lastSuccessfulBuild/artifact/debian/stretch/artifacts/debs/

@grimmy sorry for being so slow, but URL doesn't work right now - it gives Proxy Error

The only thing I'd change in .changes processing is to add temp dir to aptly config, so it can be on the same filesystem as the rest of the repo. (swap os.TempDir() for some user setting, or default to os.TempDir())
Then copy with reference/hardlink is possible, and verify the checksums after copy to temp dir. That way all files in temp dir could be safely processed.

I'm ok with custom temp dir (even though I think env variable TMPDIR could be used), but I don't think hard-linking makes sense, as it doesn't protect from files being overwritten while being processed (after checksum check).
Let me dig into the reasons behind query filters

Ah, I remember now why aptly cross-checks .changes file and packages.
This is required to support uploaders.json (https://www.aptly.info/doc/aptly/repo/include/) - .changes file is checked to comply with uploaders.json rules and now package files should match whatever is specified in .changes. Otherwise I can prepare .changes file which matches something I'm allowed to upload, but instead upload protected package.

@sobczyk ^

but you could do it in different order:

parse .changes (and verify this files GPG sig)
copy it to TempDir
verify with uploaders.json (afaik it's atomic, if one package is not allowed the whole .changes is not included)
copy all referenced files to TempDir
verify all hashes
filter Changes.Files by extension (deb, ddeb, udeb, dsc)
add filtered to local repository

We can thus omit CollectPackageFiles and PackageQuery, since ordering allows us to.

verify with uploaders.json (afaik it's atomic, if one package is not allowed the whole .changes is not included)

uploaders.json is applied to .changes file (not to packages), as .changes file for example might contain local repo name to push new packages to, so we still need to make sure that packages referenced in .changes are related to it.
For me the easiest fix would be to add package filter with <name>-dbgsym match to the query

uploaders.json is applied to .changes file
my mistake, but it holds that uploaders.json allow the .changes and associated files to pass or not (all or nothing)
Point 3 in my example flow takes care of that.

I think, I'll rewrite this tomorrow, it'll be faster than explaining

OK i get not what you told me about uploaders.json and the PackageQuery,
the user could prepare a fake .changes with packages that do not belong there, and upload what he is not supposed to upload.
Shouldn't then the filtering in ImportPackageFiles reject the whole .changes on premise that some files might be compromised?
Right now it includes packages that match, rejects other

For me the easiest fix would be to add package filter with -dbgsym match to the query
That's what I've done before, and the problem was that it wasn't matched against fields in changes.

I think I'll implement the easiest solution, that you suggested, match -dbgsym and same source.
The best long term solution would be to allow specifying PckageQuery in uploaders json and scrap the one in the source.


Fail early, in modern GENERIC builds, if globalThis isn't available (PR 11799 follow-up, issue 12596)

It probably doesn't hurt to explicitly check for globalThis as well, in addition to the existing checks.

/botio-linux preview

Looks like a good additional safeguard to me. Thanks!


Can we call nix-instantiate without --parse?

In linter.ts#L95, we call nix-instantiate with the --parse argument.
If we omit it, we will also get diagnosis for things like pkgs.foozz doesn't exist.
Currently it only analyzes syntatical errors like misplaced semicolons/parens etc and missing top-level variables.
Other than the fact that omiting --parse is slow, is there any other reason we can't use that?
nix-instantiate takes 1.4s to execute on my machine. Whereas, nix-instantiate --parse only takes 0.1s.
If there are no other issues, I think I'll be able to do a PR that runs nix-instantiate --parse first, and then fires off nix-instantiate in the background and update the output once it completes.

I will be glad to accept the PR if it is opt-in  while explaining the tradeoffs in the settings.


GDScript: Do not produce UNUSED_SIGNAL warning for common implicit uses

Closes #89632.

In 4.x, signals are first class values, but sometimes people use the old API and implicitly reference signals via strings.
With this PR the UNUSED_SIGNAL warning is not produced in the following cases:

Signal(self, <constant signal name>);
emit_signal(), connect(), and disconnect() with constant signal name.

Cherry-picked for 4.3.1.


Need License

I was thinking Apache 2.0 or MIT?  Just something open source.

went with Apache 2.0


year-archive.html to only show blog title link

Hi, I would like to alter year-archive.html so that only the hyperlink of the title to each blog entry shows up. I do not want the Published data nor the first bit of each blog to show up. How do I do this? Thank you!

how do you solve this problem? I also facing this problem


UU Quickbans

http://www.smogon.com/forums/threads/np-sm-uu-stage-4-scary-monsters.3614035/#post-7498133

Your link isn't to a quickban announcement thread, and your diff shows you making more changes than just quickbans.


Apply search screen design

Kind (Required)

Improvement

Overview (Required)

Title says everything.

But don't need create detail function in this issue. (ex. function that can search by voice #438 )
Include each item design about session and speaker!

Links

https://www.figma.com/file/4r9becvhDy3GfXaXex8E8d/App?node-id=842%3A907
https://www.figma.com/file/4r9becvhDy3GfXaXex8E8d/App?node-id=842%3A1207

Sorry, give up 🙏 I don't have time to work on this issue...

@rnitame
Thank you for your reply!
If you have time, please try again other issue.
we always wait your contribute!


Add scenario_execution

Please Add This Package to be indexed in the rosdistro.
Name
scenario_execution
Source:
https://github.com/intellabs/scenario_execution
Purpose:
Scenario Execution for Robotics is a backend- and middleware-agnostic library, that enables the robotics community to perform reproducible experiments at scale. Written in Python and built upon the generic scenario description language OpenScenario2 and py-trees, Scenario Execution reads a declarative scenario definition from a file, translates it to a py-trees behavior tree and then executes it. The backend-agnostic implementation allows Scenario Execution to be used with both, robotics simulators (e.g. Gazebo) and physical robots.
Checks

[X] All packages have a declared license in the package.xml
[X] This repository has a LICENSE file
[X] This package is expected to build on the submitted rosdistro

CC: @clalancette for REP144 thoughts.


Target ios 9 & macOS 10.11

carrying out #609 for the xcodeproj

SwiftLint found issues
Errors

File
Line
Reason

Endpoint.swift
97
Force tries should be avoided.

  Generated by :no_entry_sign: danger

Ace.


All sensor states report Unavailable

Please check Services, Known Bug / Issues and Troubleshooting over here first: https://github.com/fuatakgun/kia_uvo/blob/master/README.md
Region and Brand of car
EU Kia EV9
Version of the integration
2.22.0
Describe the bug
All sensor states report Unavailable
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
The itegration has been working fine for over a week, but today for no reason all the sensors report "Unavailable" A restart of HA has not helped. The Kia Connect mobile app is working fine.

Same here. My integration failed to setup. When I turn on debugging and reload the integration, I can see that it successfully logs in, reads sensor data at towards the end of the logs I see this
2024-03-19 00:11:33.514 DEBUG (SyncWorker_2) [hyundai_kia_connect_api.KiaUvoAPIUSA] hyundai_kia_connect_api - last_updated_at - after 2024-03-18 23:13:55+00:00
2024-03-19 00:11:33.514 DEBUG (SyncWorker_2) [hyundai_kia_connect_api.KiaUvoAPIUSA] hyundai_kia_connect_api - SOC Levels couldn't be found. May not be an EV.
2024-03-19 00:11:33.514 DEBUG (SyncWorker_2) [hyundai_kia_connect_api.KiaUvoAPIUSA] hyundai_kia_connect_api - last_updated_at - before<PHONE_NUMBER>1355
2024-03-19 00:11:33.514 DEBUG (SyncWorker_2) [hyundai_kia_connect_api.KiaUvoAPIUSA] hyundai_kia_connect_api - last_updated_at - after 2024-03-18 23:13:55+00:00
2024-03-19 00:11:35.511 DEBUG (MainThread) [custom_components.kia_uvo.coordinator] Finished fetching kia_uvo data in 5.183 seconds (success: False)

This issue is the duplicate of #837

I haven't investigated why yet, but it seems like it is the Geocoding API that is silently failing. Can you try to disable the "Enable Geolocation Entity using OpenStreetMap" option in the integration configuration?

I started experiencing this same problem within the last 24-48 hours.  As suggested, I disabled "Enable Geolocation Entity using OpenStreetMap" and now the integration is working again.

Same experience: the integration stopped providing entities yesterday midday, about 24h ago, and disabling the geolocation entity config option immediately recovered normal operation.

Yes, disabling geolocation fixed the issue. Thanks @damz!

Same here, i disabled geolocation and now everything is fine 😊

After you disable geolocation is lat long look correct?    When I manually test the geolocation API it has no issue.
Here is an example API call to geo location: https://nominatim.openstreetmap.org/reverse?lat=57&lon=-112&format=json&addressdetails=1&zoom=18&

Yes- the lag long entity remains accurate and up to date.

excuse me guys, quite new with HA. How do I disable the "Enable Geolocation Entity using OpenStreetMap" option in the integration configuration? :) thanks

excuse me guys, quite new with HA. How do I disable the "Enable Geolocation Entity using OpenStreetMap" option in the integration configuration? :) thanks

Settings>Devices>Hyundai/Kia Connect, then on the one line that should exist for your kia account, click "Configure"
Uncheck "Enable Geolocation Entity using OpenStreetMap"
And don't feel bad, HA's UI can be desperately confusing if you don't already know all the implementation details of what you're trying to do, and sometimes if you do ;)

Looks like we have two thread on this.   I put code in for lat Lon protection.  I could use debug logs from someone who has functional location entity to understand what's happening here.

Lets track this in #853

Thanks for the information. I found it, but to be my surprise it was already unchecked and the integration is still not working, whether its checked or unchecked. Do you have any suggestions where to look further? Thanks


[SPARK-29300][TESTS] Compare catalyst and avro module benchmark in JDK8/11

What changes were proposed in this pull request?
This PR regenerate the benchmark results in catalyst and avro module in order to compare JDK8/JDK11 result.
Why are the changes needed?
This PR aims to verify that there is no regression on JDK11.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This is a test-only update. We need to run the benchmark manually.

Test build #111597 has started for PR 25972 at commit 8627495.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16600/
Test PASSed.

Test build #111597 has finished for PR 25972 at commit 8627495.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111597/
Test FAILed.

Retest this please.

Test build #111613 has started for PR 25972 at commit 8627495.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16611/
Test PASSed.

Test build #111622 has started for PR 25972 at commit 0e40aae.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16620/
Test PASSed.

Test build #111613 has finished for PR 25972 at commit 8627495.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111613/
Test PASSed.

Test build #111622 has finished for PR 25972 at commit 0e40aae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111622/
Test PASSed.

Merged to master.
Thank you so much, @wangyum !


[Feature] support create or replace view

Fixes #27767
CREATE OR REPLACE VIEW could be used to update existed view definition.
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 28 / 33 (84.85%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
21
26
80.77%
[3867, 3868, 3869, 3881, 3882]

:large_blue_circle:
com/starrocks/sql/ast/AlterViewStmt.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/CreateViewStmt.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 28 / 33 (84.85%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
21
26
80.77%
[3867, 3868, 3869, 3881, 3882]

:large_blue_circle:
com/starrocks/sql/ast/AlterViewStmt.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/CreateViewStmt.java
2
2
100.00%
[]

@Mergifyio backport branch-2.5 branch-3.0 branch-3.1


Add helm schema

This PR is a requirement for https://github.com/cilium/cilium/pull/30631
Changes

Update golang to 1.21.7 (required for building helm-schema)
Install ubergesundheit/helm-schema

I've pushed the container image to quay.io/geraldpape/helm-toolbox:v1.1.0 to work with it in the other PR

The required functionality was released as version 0.9.0 in dadav/helm-schema
I've built and published the container image as quay.io/geraldpape/helm-toolbox@sha256:44006b7a4ff1efa57cd3100369bd6ff39e9f2de6340594a596bfce3e954d1a36


Experiment: Websockets

Exploring the possibilities based on the discussion: https://github.com/RobinTail/express-zod-api/discussions/991
Will use socket.io library as on optional peer dependency for that.

coverage: 99.465% (-0.5%) from 100.0%
when pulling b1f32ddfe73c728012c1949c990b077c7866f404 on exp-websockets
into 9ee6a99fff7afc93e3365596fd726550061d5263 on master.

At this moment it seems that the feature should probably be a separate package.

closing this PR in order to continue in a separate repo:
https://github.com/RobinTail/zod-sockets


Add scale method to Rect struct

Mainly intended to make collision detection with bounding_rect() more
usefull by allowing correction of size of bounding_rect(). The best
solution for collision detection and general physics is still to use
some dedicated engine for it, this is just a handy util for people that
don't need full blown physics engine but need some basic collision
detection.

Maybe adding some sort of more permanent way of scaling bounding_rect would also be necessary for some use cases?

I think this is fine for now. If we notice through use the need for a permanent way of scaling, it will be added.


Convert the codebase to python

The easier way to start this can be by using poetry

@all-contributors please add @danascape for main

@all-contributors please add @danascape for code


ensure-billing.js: 29: session: callback.session

Issue summary
after migrating to V6 in your migrate instruction indicated in ensure-billing.js:
confirmationUrl = await shopify.billing.request({
        session: callback.session,
        plan: Object.keys(shopify.config.billing)[0],
        isTest: !isProdOverride,
      });

but in production i got "callback undefined" error
Reduced test case
i change to
confirmationUrl = await shopify.billing.request({
        session,
        plan: Object.keys(shopify.config.billing)[0],
        isTest: !isProdOverride,
      });

now error go away, but is it allowed here ?
what is purposes callback was for ?

@valorloff That's a copy and paste error in the migration guide ... I think you're referring to this section?
As you can see in the call to shopify.billing.check() earlier in the method, it's just session, which is what it also should be in the call to request.
Thanks for pointing this out, will correct.


withJson method is missing from Response class

I am trying to upgrade Slim framework used in my project from version 3 to version 4 and during the process I suddenly found out that withJson method has gone from the Response class. I want to understand why it is gone? I understand that Response class implements PSR-7 ResponseInterface, where withJson method is not included. But I don't think implementing ResponseInterface forbids Response class having some helper methods which will be very helpful.

You need to use https://github.com/slimphp/Slim-Http decorators to have access to the old helper methods.


Support build with jemalloc

Dragonwell  observe a significant memory usage benefit from using jemalloc, so please consider adding this as a build option.

@joeyleeeeeee97 can you give some more context here?  Is it a make build compile-time option or??

@joeyleeeeeee97 can you give some more context here?  Is it a make build compile-time option or??

@karianna  We add Jemalloc while making JDK and make that a default memory manager.
Something like
export=BASIC_LDFLAGS_JDK_LIB_ONLY="-L${JEMALLOC_PATH} -ljemalloc"

@karianna  We add Jemalloc while making JDK and make that a default memory manager.
Something like
export=BASIC_LDFLAGS_JDK_LIB_ONLY="-L${JEMALLOC_PATH} -ljemalloc"


chore(main): release 1.3.6

:robot: I have created a release beep boop
1.3.6 (2024-07-07)
Bug Fixes

update npm yml 5 (259eaea)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.3.6
:sunflower:


Invalidated diagnostics live forever

Updating source follows this pattern:
            self.db.update_file(self.filename, module_source.text);

            let diagnostics = self.db.diagnostics(self.filename);
            for diagnostic in &diagnostics {
                dada_error_format::print_diagnostic(self.db, &diagnostic)?;
            }

These diagnostics are "accumulated" by salsa. From what can tell these diagnostics stick around forever. If the source text changes then the diagnostics remain, but they reference text that no longer exists.
I have run into this in the repl, which continuously updates the source text.
At the moment the repl doesn't "commit" steps that fail to compile or run. That is, if enter foo() and foo doesn't exist, the repl will update the source to include a function that tries to call foo(), see that it fails and "revert" the changes so that call is no longer part of the source text. The result is that subsequent steps continue to observe that failed diagnostic, but it prints incorrectly:
>>> foo()
Error: can't find anything named `foo`
   ╭─[<repl-input>:2:17]
   │
 2 │ __repl_result = foo()
   ·                 ─┬─
   ·                  ╰─── here
───╯
compilation failed
>>> 4
Error: can't find anything named `foo`
   ╭─[<repl-input>:2:17]
   │
 2 │ ╭─▶ __repl_result = 4
 3 │ ├─▶ __repl_expr_1(__repl_result).await
   · │
   · ╰──────────────────────────────────────── here
───╯
compilation failed

Here the second step produces the same diagnostic but it is now pointing to different text.
I think I can mostly work around this behavior by ignoring previously-seen diagnostics, but this seems like a bug - the fixed diagnostic should disappear or otherwise be identifiable as invalidated.

Yeah, the salsa branch we are based off of has some bugs =)
I've been putting off fixing them because I wanted to make progress on dada but ...


a tslint.json placed in a directory above tsconfig.json is not applied

Say there is a monorepo structure such as this one
- tslint.json
- node_modules/...
- packages/a/tsconfig.json
- packages/a/src/...

then tslint.json is not automatically found and applied (it is with the "old" tslint plugin)
if a tslint.json is placed in packages/a/tslint.json that just extends the root one then it will work

In that example, which folder have you opened in the editor?

A source file inside packages/a/src

Did you only open a single file in your editor? Or an entire subfolder?

a single .ts file

Also, maybe unrelated, when the tslint.json location is set in the plugins section of the tsconfig.json pointing to the root folder, if vscode is closed and reopened again then tslint won't work until such tsconfig.json file is resaved.
When using the extends trick it is ok.

Btw, what I mean by a single .ts file is that the workspace is pointing to the root, and then I double click on that single .ts file to open it.

A commit was just done to use tslint.json that extends to the root one, so if you clone that repo you may want to use this branch for example instead: https://github.com/mobxjs/mobx-state-tree/tree/better-liveliness-warning

I am also experiencing this with descending tslint files
Project is an ASP.NET Core project with Angular 6.X.X
/tsconfig.json
/ClientApp/tsconfig.json (A)
/ClientApp/src/tsconfig.json (B)

/ClientApp/tsconfig.json (A)
{
  "defaultSeverity": "error",
  "extends": "tslint:recommended",
  "jsRules": {},
  "rules": {  },
  "rulesDirectory": []
}

/ClientApp/tsconfig.json (B)
{
  "extends": "../tslint.json",
  "rules": {
    "component-selector": [
      true,
      "element",
      "app",
      "kebab-case"
    ],
    "directive-selector": [
      true,
      "attribute",
      "app",
      "camelCase"
    ]
  },
  "linterOptions": {
    "exclude": [
      "test.ts",
      "main.ts",
      "polyfills.ts"
    ]
  }
}

When I run the CLI or through Visual Studio with tslint-microsoft-contrib the excluded files are not excluded as expected. Which leads me to believe it is not being loaded in reference to the directory it sits in.

@xaviergonz Looks like that branch no longer exists. Do you have a link to version of that project where it doesn't work?

Same issue here, but I'm opening the whole monorepo in vscode
tslint.json
packages/
  package1/
    tsconfig.json

linter is not working and it did with the old extension

Closing as TSLint has been deprecated in favor of ESLint. We are archiving this repo as this project is no longer maintained


Continue supporting IE11 in examples and legacy buld

This pull request modifies the webpack configurations for the example and legacy build to transpile for IE11, including all dependencies. Because geotiff brings in dependencies that publish code with async/await, we can no longer use buble for transpiling. So this pull request also gets rid of the buble dev dependency, and uses babel instead, which we have as dependency already for the worker build.
This pull request fixes one of the problems described in #12730.

@mike-000, can you please test the examples and the legacy build from this pull request in IE11? I don't have access to such an old browser.

Do you have a download link available?  The deploy preview examples do not work in any browser.

@mike-000 The examples preview should work again now, and I added a legacy build test map to the preview entry page (https://deploy-preview-12734--ol-site.netlify.app).

Examples and legacy build working in both Chrome and IE (when copied and polyfills used)

@mike-000 I added the polyfills to https://deploy-preview-12734--ol-site.netlify.app. Can you please test again if it works out of the box now in IE?

I just found a rusty Windows virtual machine with Internet Explorer on it. I could verify that both the legacy build preview and the preview examples work fine there. So this is now ready for review.

Yes, it is working.  The new WebGL examples have highlighted some more polyfills are needed, e.g. Array.from()

Thanks for testing, @mike-000.

Yes, it is working. The new WebGL examples have highlighted some more polyfills are needed, e.g. Array.from()

I'll leave that to you to document/add those, if that's ok for you. Thanks in advance!


hasMany value show a blank rectangle

Hello,
I have this simple selector :
{{select-2
    content=skills
    value=choosedSkills
    multiple=true
}}

With this controller :
export default Ember.Controller.extend
  choosedSkills: (->
    @model.get('skills')
  ).property('choosedSkills')
  skills: (->
    @store.findAll 'skill'
  ).property('skills')

I think all skills of the model should be assigned but I have this result :

When I try this :
export default Ember.Controller.extend
  choosedSkills: (->
    [{name: 'test', description: 'test'}]
  ).property('choosedSkills')
  skills: (->
    @store.findAll 'skill'
  ).property('skills')

It works.
Does ember-select-2 works with hasMany associations ?

@GCorbel I created an issue for this last week with the same issue: #105. I haven't heard anything back but looking through the code, it appears that ember-select-2 does not currently support hasMany because it setting the array instead of adding/removing from it which throws a console error seen in #105. If you open your console and are seeing this read-only error, you should go ahead and add your info to #105 and close this issue.

Confirmed. Furthermore, if the value is a property of a DS object, the two way binding is broken, too.

It works now.

How can it work now? There have been no commits to this repo since before you even opened this issue......
@GCorbel

I saw. It maybe because of an update of ember...

Same issue with ember 1.13.3 and ember data 1.13.5

for everyone getting similar error (select2 with multiple option and hasMany), in last comment of this issue: https://github.com/iStefo/ember-select-2/issues/105 I've posted a workaround that worked quite well for me.


The character '0' (zero) is appended to words that lack punctuation

The following lines (line 196, inference.py)
    if label[0] != "O":
        word += label[0]

have the effect of appending a '0' (zero) character to output words that have no punctuation. Should be
    if label[0] != "0":  # <-- zero, not oh
        word += label[0]

Hi @nilsdacke, thanks for posting the issue and addressing it with a PR :-)
Could you provide more context and an example of where the issue occurred in your use-case?
Our label map is:
"0": "OU",
"1": "OO",
"2": ".O",
"3": "!O",
"4": ",O",
"5": ".U",
"6": "!U",
"7": ",U",
"8": ":O",
"9": ";O",
"10": ":U",
"11": "'O",
"12": "-O",
"13": "?O",
"14": "?U"
The idea is that if the first character of a label is "O" then we add no punctuation, and if it is not "O" we add the first character as the punctuation - so using "O" as an identifier is intentional on our part.
Essentially your commit introduces the exact issue you are trying to fix (c.f. unit tests in the PR) so we need a bit more information on the issue to address it.

Hi,
Thanks for the reply and for the nice tool :-)
I see, if you use 'O' to represent no punctuation, then it works. I thought
it was '0' (zero).
However, line 202 of inference.py has:
    if label[0] != "0" and label[0] in [".", "!", "?"]:
        next_auto_uppercase = True

which seems to suggest that '0' (zero) is used. (In the line above it makes
no functional difference as the comparison to '0' is redundant.)
Which is the more conventional choice, '0' (zero) or 'O' (oh)?
Thanks,

Simon

On Mon, Jul 11, 2022 at 1:41 PM Martin Carsten Nielsen <
@.***> wrote:

Hi @nilsdacke https://github.com/nilsdacke, thanks for posting the
issue and addressing it with a PR :-)
Could you provide more context and an example of where the issue occurred
in your use-case?
Our label map is:
"0": "OU",
"1": "OO",
"2": ".O",
"3": "!O",
"4": ",O",
"5": ".U",
"6": "!U",
"7": ",U",
"8": ":O",
"9": ";O",
"10": ":U",
"11": "'O",
"12": "-O",
"13": "?O",
"14": "?U"
The idea is that if the first character of a label is "O" then we add no
punctuation, and if it is not "O" we add the first character as the
punctuation - so using "O" as an identifier is intentional on our part.
Essentially your commit introduces the exact issue you are trying to fix
(c.f. unit tests in the PR) so we need a bit more information on the issue
to address it.
—
Reply to this email directly, view it on GitHub
https://github.com/danspeech/punctfix/issues/10#issuecomment-1180306059,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR53WRKFLUNJNAIQR6SWCG3VTQCADANCNFSM522DWS2A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Good catch! That's a mistake on our end - the comparison to "0" can and should be removed.
If you feel like updating your PR with the removal we'd be happy to merge it :-)
As for conventions we have gone for 'O' (oh) over 0 (zero) due to it's use as a blank in NER tagging tasks, whether or not that makes it a conventional choice I'll leave for you to decide.

Martin

Hi @nilsdacke , we will remove this superfluous check, thank you for making us aware of it.
If you have an example where "0" (zero) is appended to a word, we would be very happy to see it.
-- Søren


[3.0] Fix NullPointerException on consumer startup#8078

修复Consumer启动时报空指针异常的问题，相关issue：https://github.com/apache/dubbo/issues/8078
What is the purpose of the change
修复Consumer启动时报空指针异常的问题，相关issue：apache#8078
Brief changelog

方法 ReferenceAnnotationBeanPostProcessor#isAnnotatedReferenceBean 增加判空逻辑。

Verifying this change
按照现有单元测试即可。
Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

LGTM


add flakes support and convert to poetry

ci and other things

looks good to me on first view, i will test this evening

Awesome stuff, thanks :+1:


Feature | FOB Manager

Would be a nice feature if the FOB's have a own permission system so that only the High-Commander and the FOB-Commander(s) can handle the features on the FOB's who permissed to.

Only High-Commander can give permissions.

Player can get the permissions of 1 or more FOB's.

Only the FOB-Commander(s) and the High-Commander can build, recycle and handle ressources (F, A, S) on the given FOB(s).

FOB-permissions can given to 1 or more playsers.

Only the FOB-Commander(s) and the High-Commander can given vehicle permissions for in his FOB builded vehicles.

Only the FOB-Commander(s) can give permissions to respawn on his FOB.

Same general topic as in #95


Submitting python or R script alone with dependency box checked results in failure

Describe the issue
Submitting python or R script by itself, without any dependencies(additional files), with the dependency box checked results in a failure
To Reproduce
Steps to reproduce the behavior:

Open the Python or R script editor
Paste in any python cmds e.g. print("Hello World")
Select Run as Pipeline
Leave the Include File Dependencies box checked
click Ok

Screenshots or log output
If applicable, add screenshots or log output to help explain your problem.
Log Output

Paste the log output here.

Expected behavior
Deployment information
Describe what you've deployed and how:

Elyra version: 3.7.0rc0
Installation source: pypi
Deployment type: local
Operating system: macos

@akchinSTC I tried reproducing this and I was able to successfully submit a pipeline from both python and r scripts, using the default checked box for file dependencies, for existing files and newly created ones, no request errors. What am I missing? 🤔

@karlaspuldaro - that worked and the entry box remains grayed out to provide an example for users. Thanks for this

If I understood it correctly, the suggested fix on #2637 is disabling the check to enable dependencies by default. But if the user goes and checks the box, isn't it going to see the same issue? Shouldn't we try to fix the actual problem and avoid the issue when the checkbox is checked?
NOT A CONTRIBUTION

I think the proposed fix is to remove the default value (.e.g, *.py or *.r).  It sounds like the box can remained checked by default.  I would suggest we not have the box checked by default if there are no defaulted values though.  (Sorry if that change was also made.  I only see the defaultValue removed, so I assume the box is still checked.)

@lresende @kevin-bates is correct, we just removed the default value from the input box, the check box is still checked as default and the placeholder value is still there grayed out to guide users on what kind of input is expected.
We can leave the box unchecked by default as well.

Ah, thanks @karlaspuldaro, I didn't realize the text (value) was grayed out - that makes sense.  Would it be possible to not have the box checked with the text grayed out and when the box gets checked, enable the grayed out default value?  That seems like a more intuitive user experience (to me).

I still think we have a bug on the backend and we are trying to mask it via these UI changes.
NOT A CONTRIBUTION

I still think we have a bug on the backend and we are trying to mask it via these UI changes.

@lresende - I see what you are saying and have included the failed request's complete stack trace. Seems like the request needs to fail more gracefully when no dependencies are found.
I could see a nice UX being something that would ignore the lack of dependencies only when a wild-card is used to express them and fail when they've been specified explicitly, but that might be more difficult, so the two cases (where neither expression yields files) should probably be handled gracefully.

Complete stack trace of submit request
[I 2022-04-05 16:28:09.553 ElyraApp] kfp 'untitled':'untitled' - processing operation dependencies for id: cdd8d815-9de6-489f-9ee4-f132a6d6da8f
[E 2022-04-05 16:28:09.561 ElyraApp] Dependencies were not found building archive for operation: untitled
    Traceback (most recent call last):
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/processor.py", line 384, in _upload_dependencies_to_object_store
        dependency_archive_path = self._generate_dependency_archive(operation)
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/processor.py", line 368, in _generate_dependency_archive
        archive_artifact = create_temp_archive(
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/util/archive.py", line 124, in create_temp_archive
        raise FileNotFoundError(filenames_set - matched_set)  # Only include the missing filenames
    FileNotFoundError: {'*.py'}
[E 2022-04-05 16:28:09.563 ServerApp] Uncaught exception POST /elyra/pipeline/schedule?1649201287849 (::1)
    HTTPServerRequest(protocol='http', host='localhost:8888', method='POST', uri='/elyra/pipeline/schedule?1649201287849', version='HTTP/1.1', remote_ip='::1')
    Traceback (most recent call last):
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/processor.py", line 384, in _upload_dependencies_to_object_store
        dependency_archive_path = self._generate_dependency_archive(operation)
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/processor.py", line 368, in _generate_dependency_archive
        archive_artifact = create_temp_archive(
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/util/archive.py", line 124, in create_temp_archive
        raise FileNotFoundError(filenames_set - matched_set)  # Only include the missing filenames
    FileNotFoundError: {'*.py'}

    The above exception was the direct cause of the following exception:

    Traceback (most recent call last):
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/kfp/processor_kfp.py", line 243, in process
        kfp_argo_compiler.Compiler().compile(pipeline_function, pipeline_path, pipeline_conf=pipeline_conf)
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/kfp/compiler/compiler.py", line 1175, in compile
        self._create_and_write_workflow(
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/kfp/compiler/compiler.py", line 1227, in _create_and_write_workflow
        workflow = self._create_workflow(pipeline_func, pipeline_name,
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/kfp/compiler/compiler.py", line 1005, in _create_workflow
        pipeline_func(*args_list, **kwargs_dict)
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/kfp/processor_kfp.py", line 226, in <lambda>
        pipeline_function = lambda: self._cc_pipeline(  # nopep8 E731
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/kfp/processor_kfp.py", line 543, in _cc_pipeline
        self._upload_dependencies_to_object_store(runtime_configuration, cos_directory, operation)
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/processor.py", line 409, in _upload_dependencies_to_object_store
        raise FileNotFoundError(
    FileNotFoundError: Node 'untitled' referenced dependencies that were not found: {'*.py'}

    The above exception was the direct cause of the following exception:

    Traceback (most recent call last):
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/tornado/web.py", line 1704, in _execute
        result = await result
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/handlers.py", line 125, in post
        response = await PipelineProcessorManager.instance().process(pipeline)
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/processor.py", line 147, in process
        res = await asyncio.get_event_loop().run_in_executor(None, processor.process, pipeline)
      File "/opt/conda/envs/elyra-dev/lib/python3.9/concurrent/futures/thread.py", line 58, in run
        result = self.fn(*self.args, **self.kwargs)
      File "/opt/conda/envs/elyra-dev/lib/python3.9/site-packages/elyra/pipeline/kfp/processor_kfp.py", line 247, in process
        raise RuntimeError(
    RuntimeError: Failed to compile pipeline 'untitled' with engine 'Argo' to: '/var/folders/4w/qxgsbhyx1y93qlk9mnzwjryc0000gn/T/tmpj2jo4mcs/untitled.tar.gz'
[E 2022-04-05 16:28:09.566 ServerApp] {
      "Host": "localhost:8888",
      "Connection": "keep-alive",
      "Content-Length": "904",
      "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.109 Safari/537.36",
      "X-Xsrftoken": "2|a34dac9b|23f1949905e4e197499df20dc5812ce7|1648499639",
      "Authorization": "token 91b1f288ecf0807a26a6428cc5184ebe1f6ba7b7947703bd",
      "Content-Type": "text/plain;charset=UTF-8",
      "Accept": "*/*",
      "Sec-Gpc": "1",
      "Origin": "http://localhost:8888",
      "Sec-Fetch-Site": "same-origin",
      "Sec-Fetch-Mode": "cors",
      "Sec-Fetch-Dest": "empty",
      "Referer": "http://localhost:8888/lab/tree/alice/Kubernetes/untitled.py",
      "Accept-Encoding": "gzip, deflate, br",
      "Accept-Language": "en-US,en;q=0.9",
      "Cookie": "username-localhost-8889=\"2|1:0|10:1646962480|23:username-localhost-8889|44:MDA2YzgyNzQwNzcwNDI1YmJiNTVjOTRlZGVhNDMyMDc=|22f00454036963a563adccef1d3c10b85b8acad285443174978098d3e29ce574\"; _xsrf=2|a34dac9b|23f1949905e4e197499df20dc5812ce7|1648499639; username-localhost-8888=\"2|1:0|10:1649201285|23:username-localhost-8888|44:NWU2OTZhNzVlYmFhNDU0YjliNmYyYjE0ZmI2ODA5MGU=|f4ada548736947b50391fa1d8625312b12581ddba68a582cd5e4b98acb58b44f\""
    }
[E 2022-04-05 16:28:09.566 ServerApp] 500 POST /elyra/pipeline/schedule?1649201287849 (::1) 1713.37ms referer=http://localhost:8888/lab/tree/alice/Kubernetes/untitled.py

@karlaspuldaro - when attempting to reproduce this, did you ensure that the directory in which your Lab file explorer was listing did not have any additional python or R files besides the script being submitted?  I found that if simply touched another file (e.g., foo.py) then the submission worked fine.  It failed only when there were no other python files present (besides the script itself).

@kevin-bates Thank you for the info, and I was able to reproduce the issue now, the request failure happens on the scenario you described and requires better handling dependencies on the backend.
On the frontend do we still want the file dependency box unchecked by default as part of these changes?

On the frontend do we still want the file dependency box unchecked by default as part of these changes?

I personally think so, but the problem is certainly lessened with a fix to the backend.  That said, I think there could be some ambiguity that folks might think their actual script is considered a dependency by virtue of it also satisfying the wildcarded *.py, when, based on the above, it is not.  So if the box were not checked by default, it might make that particular area less ambiguous to the user.

Changing the front-end behavior might also have unexpected consequences on the folks that have their script to work when they have other dependencies. I would say we fix the actual "backend problem" and let users provide feedback on the UI as things have been working the current way for a while.
NOT A CONTRIBUTION


Release/1.6.2

Coverage decreased (-0.02%) to 96.992% when pulling 8fdc3d8624f23106bc34143381861ed4ff4d5cac on release/1.6.2 into f648a462d2babddae0fb6a32bf6aa38f7de6e80f on master.


h1

I would like the h1 element within my header to be separate from the other h1 elements so that I may style it differently.

In the center section of css, you are styling all h1 every where.

[ ] You should change this to only the h1 in #center.
[ ] You can now style header h1 { }in the header section.

/*------------------------------------*\
  #CENTER SECTION
\*------------------------------------*/

#center h1 {
  word-spacing: 25px;
  letter-spacing: .25em;
  font-family: "Smooth Stone";
  font-size: 2.5em;
  align-self: center;
  text-shadow: 1px 2px #F5F5DC;
}


update submodule sitl_gazebo

CI mixer failure unrelated

No I haven't seen the issue yet. I'll take a look at it


Bounded, more efficient pprint function

When printing the tags for a trace, some of them may get very large. As a quick and dirty fix for #52 before that is completed, a bounded pprint function could be created. This would be the same as pprint, but when printing each top-level keys value, it would only print the first (say) 200 characters, and if the limit was hit, add a trailing elipsis.
This would be more efficient than our current implementation which pprints the entire datastructure, then trims the string. It would also be more useful as it would show at least part of each key, rather than one big value dominating the rest of the string.
Another option to do perhaps in conjunction with the idea above is to use fipp as it is much faster. We still want to not print the whole string though, as the string might get way too big.

Fixed in 0.3.2 release.


update RHCOS support version from 4.12 to 4.14 and new parameter 'use_internal_bastion' in inventory.yaml

Add a new parameter use_internal_bastion: true as default under inventory.yaml.

add-new-compute-node.yaml  will add workers info automatically in /etc/haproxy/haproxy and /var/named/xx.zone when use_internal_bastion: true.

destroy-computes.yaml will remove workers info automatically in /etc/haproxy/haproxy and /var/named/xx.zone when use_internal_bastion: true.

04-destroy.yaml will remove workers and masters info automatically in /etc/haproxy/haproxy and /var/named/xx.zone when use_internal_bastion: true .

Signed-off-by: Meng Jie Min<EMAIL_ADDRESS>

@shhull

MengJie, another suggestion: if we have the use_external_bastion parameters in the inventory, then we don't need to have the user run bastion.yaml separately. We can just put bastion.yaml directly into the playbook for 01 if use_external_bastion = true.


Follow-up changes for the Material sprint branch

Addressing remaining comments in #472

Hi,
Thanks for your contribution, however Sunflower is going to be archived in favour of maintaining a smaller set of up-to-date set of compose-samples, that can be found here: https://github.com/android/compose-samples, as well as snippets that can be found here: https://github.com/android/snippets.
Please feel free to keep your fork up-to-date for your learning, but this repository will be archived shortly.


Add additional keys to adopted resource spec

Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/766
Some resources require more than an ARN/Name/ID to describe a single resource. This PR adds an additionalKeys field to the AWSIdentifiers to allow for arbitrary identifiers as needed by any resources.
Generator code to support this change: https://github.com/aws-controllers-k8s/code-generator/pull/62

@RedbackThomson is gonna rework this PR, sometime next week
/hold

/unhold
/approve

/lgtm


new homepage design

deployed to https://david.marlowe.iohkdev.io/#/

Homepage comments: it looks way better, but a few detailed points.

text in the diagrams should be closer to the icons it is describing.
inconsistency in distance of text from icons in diagrams
even in full screen I have to scroll the homepage on my 15" mac book pro screen: can we make the height of the diagrams smaller?
another way of making the height smaller: put the three buttons at the foot of the page in horizontal alignment
click on "browse example files" leads to a menu offering "demo files" … let's use "example" throughout
would be clearer to say "open project" rather than "open" (given that there is also "open example")
we could omit "ready to go?" too, I think: it's not clickable :-)
need to add telegram at bottom RH corner

Oop, spotted a bug. The twitter link goes here:


Allow key provider option

Proposal
This PR aims to make key_cb option configurable.
Motivation
This has been done so we could store our private key in an environment variable, avoiding the hastle of setting up a file storage just for this file.

Hello, @piacsek! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

SourceLevel has finished reviewing this Pull Request and has found:

1 possible new issue (including those that may have been commented here).

See more details about this review.

Thanks for your contribution ❤

Thanks for your contribution ❤

No prob, mate! Hope to keep contributing. 😸


Indices type does not switch to uint above 65535

The type of the index should switch from unsigned short to unsigned int above 65535, as seen here, but that doesn't happen. It seems to only switch above 265535. (also this twitter thread
I've narrowed down the error to the indices.max() function. For a simple cube (1 mesh, 1 primitive):

indices.max() is 23
len(indices) is 36

36 is the correct number of indices 2 * 3 * 6, this causes the type to not switch as it underestimates the count.
Switching max_index = indices.max() to max_index = len(indices) actually fixes the issue. But the issue might be in indices.max() itself? I tested with multiple meshes in a single primitive, one above the threshold and one below and len(indices) works just fine.

Hello,
At export, vertices get split up so that they have unique attributes (normal, UV, etc.). Flat shading, sharp edges, UV seams, etc will cause some vertices to be duplicated, to have the unique attributes.
For default cube, for example, here is the indice array:
1 14 20  1 20  7 10  6 19 10 19 23 21 18 12 21 12 15 16  3  9 16  9  22 5  2  8  5  8 11 17 13  0 17  0  4
There is 36 indices, but max indice is 23.
I can't see any bug here. This explains why unsigned int is not needed for export of 65535 length array of indices : indices value at not that high.

I see, it seems I completely misunderstood the issue 😅 I kept looking at the indices count, but yeah the vertex count is what defines the index type. The number 265535 might be a total accident.

No problem.
We are all infinite learner!

@nothke (Aside: the reason byte color vertex colors export as ushort is because byte color in Blender = 8-bit sRGB. Vertex colors in glTF are linear and 8-bit sRGB = 12-bit linear, hence 16-bit is the smallest type that can represent it losslessly.)


Inputs with tooltip set can't be focused on first click on iOs, it needs 2.

Hi,
When I click on my input that have a tooltip, I can't type directly. It needs a second click to actually focus the input and display the keyboard.
This occurs only on iOs (iPad + iPhone).
Is this a bug ?
Thanks

Hi, is there anything new about this issue ? Still waiting for a fix.

Hello,
I have found that using specifically "click" for the trigger prevent the bug. As tooltip default to "hover" and keep that specification even for touch device, it would be convenient to set "click" per default for touch device. I will check how I can do that.

+1, thanks for your comment poupougnac, that worked great for me.  Is there a reason why "focus" wouldn't be the default?  I know you all are busy though :)

This is related to #3687, which has more information.
Closing as a duplicate, although I highly recommend rethinking using a tooltip/popover in iOS due to poor/non-sensical UX.


Add @discardableResult to await

Would it be possible for you to add @discardableResult to wait?
It generates a warning if we just want to try await a function whose return value we do not care about.

@mylemans I had never run into the use case personally but it seems like a reasonable thing :)
I'm going to add it for the next version

Thanks, it's appreciated 👍

@mylemans this is up in https://github.com/freshOS/then/releases/tag/4.1.1 :)


fix(lint): golang-client lint errors

Closes https://github.com/celestiaorg/celestia-app/issues/3919
Overview

Fix the lint errors of golangci-lint.
Merge this PR to this branch.

Added backport to v2.x label b/c I originally noticed these lint issues were on v2.x branch.


fix: glue column types

Description
I'm trying to use dbt_utils.union_relations macro, but I get the following error:
TYPE_MISMATCH: line 11:6: Unknown type: string
Same error for types binary and timestamp.
The AthenaColumn class is implemented which resolves the problem with col.data_type attribute.
Models used to test - Optional
I've created 2 source models:
create table "sandbox"."tbl1"
  with (
    table_type='iceberg',
    is_external=false,
    location='s3://<bucket_name>/dbt/sandbox/tbl1',
    format='parquet'
  )
  as
select
localtimestamp(6) as ts,
'abc' as txt,
cast(12.23 as decimal(18,2)) as dcml,
from_hex('34c5b859b4764c0da59cca7675a74fbe') as bnr

create table "sandbox"."tbl2"
  with (
    table_type='iceberg',
    is_external=false,
    location='s3://<bucket_name>/dbt/sandbox/tbl2',
    format='parquet'
  )
  as
select
localtimestamp(6) as ts,
'abc' as txt,
cast(12.23 as decimal(18,2)) as dcml,
from_hex('34c5b859b4764c0da59cca7675a74fbe') as bnr

also there is sources config:
---
version: 2

sources:
  - name: tbl
    schema: sandbox
    tables:
      - name: tbl1
      - name: tbl2

and finally the dbt model is
{{
    config(
        materialized='table',
        table_type='iceberg',
        schema='sandbox'
    )
}}

{{ dbt_utils.union_relations(
        [
            source('tbl', 'tbl1'),
            source('tbl', 'tbl2'),
        ],
    )
}}

This model runs correctly with updated class but fails with mentioned issues without fixes.
Checklist

[x] You followed contributing section
[x] You added unit testing when necessary
[x] You added functional testing when necessary

@svdimchenko nice job, I left some suggestions, let me know what you think, overall looks good:)

@svdimchenko please fix the conflicts.
@Jrmyy could you have another look?


Make base64 encoding for secret false by default

This is also the default in auth0, they should match

We are actually looking at pulling the information from the tenant instead.  We made it true by default to not break legacy, but it should be false by default for new stuff, so the best answer is to just query the management API to get the right value and not have it be settable.  Or at least set it up correctly the first time.


added video of more than 15 mins on css

link for video:https://drive.google.com/file/d/1x-lA5OGtdxSz7g_RqsnwU4QGsBzV-U8Y/view?usp=sharing

🛠 Fixes Issue

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@myhacktech ur voice volume is very low i guess from next try to improve it either use a earphone or speak loudly

@myhacktech this time give u lvl 2 but from next time add at least 2 videos of 10-15 mins min for lvl2


Question: What is the status of this Repo?

There is a lot of promise in this repo, however it looks like it is very early in it's development.
Has this repo stalled? There haven't been any commits in the past 6 months at time of writing.
The only components that I see implemented are Buttons, Icons and Images.  There are ton more, and I'm not at all expecting them to all be implemented while Blazor is still experimental but I'm curious as to whether or not I am looking in the right spot.
Are there examples of the usage of these components?

Hello @DerekChasse
The person who asked to create this repo and migrate the content is probably out of time to maintain it.
However, since now a lot changed on both OfficeUI and the new Microsoft Design language, I'll get back and review it once I get back to vacation later this month.
Please keep tuned on other issues so you can grab more updates soon.
Thanks!


Style support for DDerl

First of all, big Kudos to everyone that was Hackergarten and improved DDerl to what it is now on management station. They anoying bug of 'moving buttons on closing window' is finally banned. Moreover minimizing of windows to a bottom bar is included as a new feature even before I had the time to place it as a wish - fantastic!
Still I noticed something while working with the new version:
1.) I do spent much more time doing my work / trying to get arround in DDerl
Why is this, I think the black / bold color of the toolbar + buttons distract me too much and my eyes keep changing the focus to the lower part of the screen instead of stay focused on the data (which is in some times not easy :).
Therefore I would request the old look & feel to come back. Is it possible to add the new look & feel as a style and keep the old style as default ? Style support has been 'wished' by operation anyway some of them even want colored buttons (search for peace colors in google...).

@tgdriph3 thanks for the feedback, @c-bik created an issue with suggestions for improvements #230 , I think keeping the old gray default with highlighting would solve this problem. Closing this one as duplicated.


send tokens

@trbutler4 I'd love to work on this

@trbutler4 I'd love to work on this

I will assign you. You should see a "TODO(34)" comment in the code. This will involve calling a java class that will be implemented in rust, there is a walkthrough of how that works in the rust in android guide

@EjembiEmmanuel Hey, have you made any progress on this? We should be using the startknet jvm library instead of rust.

Unblocking this issue @EjembiEmmanuel

This should be added to the StarknetClient. Search for TODO(#24) in the code

hey @trbutler4 can i work on this

Hi! @trbutler4 can I hop in?
I’m Lindsay, Software Eng based in Costa Rica.
Experienced in full stack dev, but specialized in frontend. Currently learning about web3 and blockchain. I’be been contributing for the last months, feel free to check my od contributions!

hey @trbutler4 can i work on this

cant give u all the issues :)

Hi! @trbutler4 can I hop in? I’m Lindsay, Software Eng based in Costa Rica. Experienced in full stack dev, but specialized in frontend. Currently learning about web3 and blockchain. I’be been contributing for the last months, feel free to check my od contributions!

I will assign you. We are using this library: https://github.com/software-mansion/starknet-jvm
there should be an example in their repo for sending tokens

Perfect, I'll take a look at that. Thank you!

Perfect, I'll take a look at that. Thank you!

hey @lindsaymoralesb how is this issue coming along?

hey @trbutler4 sorry, I've been loaded with work and haven't been able to work on this! I may be able to work on it next week, but feel free to unassign if it's a blocker. tx!

Hi @trbutler4 , can I work on this please I’m ready to work.

Hey @trbutler4 i want to work on this

Hi @trbutler4 , please can I be assigned this?

@trbutler4  I can take on this issue

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have been using Kotlin to develop mobile apps for more than four years, and I am strongly motivated to take on this challenge.

closing this issue, it will still need to be done but I want to structure issues differently for ODHack


[bug] Incorrect Type Definition for TrayIconEvent

Describe the bug
The TrayIconEvent type definition in tray.d.ts does not include a type property, which exists at runtime. This discrepancy leads to TypeScript type errors when attempting to access event.type in the action handler of TrayIcon.
Reproduction
No response
Expected behavior
The TrayIconEvent type should include a type property (e.g., 'click', 'doubleClick', etc.) to allow proper TypeScript type checking and IntelliSense support.
Actual TrayIconEvent Type Definition:
export type TrayIconEvent = {
    click: TrayIconClickEvent;
} | {
    enter: TrayIconEnterEvent;
} | {
    move: TrayIconMoveEvent;
} | {
    leave: TrayIconLeaveEvent;
};

Expected TrayIconEvent Type Definition:
export type TrayIconEvent =
    | { type: 'Click'; click: TrayIconClickEvent }
    | { type: 'DoubleClick'; click: TrayIconClickEvent }
    | { type: 'Enter'; enter: TrayIconEnterEvent }
    | { type: 'Move'; move: TrayIconMoveEvent }
    | { type: 'Leave'; leave: TrayIconLeaveEvent };

Full tauri info output
[✔] Environment
    - OS: Mac OS 15.1.1 arm64 (X64)
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.79.0 (129f3b996 2024-06-10)
    ✔ cargo: 1.79.0 (ffa9cf99a 2024-06-03)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: 1.79.0-aarch64-apple-darwin (environment override by RUSTUP_TOOLCHAIN)
    - node: 20.17.0
    - pnpm: 9.11.0
    - npm: 10.8.2
    - bun: 1.1.4

[-] Packages
    - tauri 🦀: 2.0.5
    - tauri-build 🦀: 2.0.1
    - wry 🦀: 0.46.3
    - tao 🦀: 0.30.3
    - tauri-cli 🦀: 2.0.0-rc.9
    - @tauri-apps/api : 2.0.0-rc.4 (outdated, latest: 2.1.1)
    - @tauri-apps/cli : 2.0.0-rc.9 (outdated, latest: 2.1.0)

[-] Plugins
    - tauri-plugin-shell 🦀: 2.0.0-rc.3
    - @tauri-apps/plugin-shell : 2.0.0-rc.1 (outdated, latest: 2.0.1)
    - tauri-plugin-dialog 🦀: 2.0.1
    - @tauri-apps/plugin-dialog : 2.0.0 (outdated, latest: 2.0.1)
    - tauri-plugin-fs 🦀: 2.0.1
    - @tauri-apps/plugin-fs : 2.0.0-rc.2 (outdated, latest: 2.0.2)
    - tauri-plugin-updater 🦀: 2.0.2
    - @tauri-apps/plugin-updater : 2.0.0
    - tauri-plugin-deep-link 🦀: 2.0.1
    - @tauri-apps/plugin-deep-link : 2.0.0-rc.2 (outdated, latest: 2.0.0)
    - tauri-plugin-single-instance 🦀: 2.0.1
    - @tauri-apps/plugin-single-instance : not installed!
    - tauri-plugin-process 🦀: 2.0.1
    - @tauri-apps/plugin-process : 2.0.0

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../frontend/dist
    - devUrl: http://localhost:1420/
    - framework: Vue.js
    - bundler: Vite

Stack trace
No response
Additional context
Reproducible on Latest Version (2.0.5): Yes

Check out the tauri info output you posted. Your JS packages are all still on pre-release versions. Once updated it should work as expected https://github.com/tauri-apps/tauri/blob/dev/packages/api/src/tray.ts


fixed issue with spaces infront of GO statements

Now supports spaces.
Pretty common to have spaces when you create a right 'margin' to align text in your migration script.

cool, thanks

it's out in 0.0.9 :)


Consider changing namespace

The Acf namespace does not properly reflect the package. Consider renaming this to a more descriptive namespace, or simply using Samrap\Acf.

I think Samrap\ACF would be cool.  I also personally much prefer a capitalized "ACF" as it's an acronym.

I agree with the base namespace being Samrap as that is the convention. As far as the class name, there is a good discussion here about following the PSR StudlyCaps rule when dealing with acronyms. I personally prefer following strictly to StudlyCaps as do some large frameworks like Zend, Laravel, etc. For that reason, I will be changing the full namespace to Samrap\Acf, leaving the class name unchanged  :)

Implementing this I realize it makes the most sense to namespace everything under Samrap\Acf, so the final class name would be Samrap\Acf\Acf. Not sure how I feel about that. But without it, the internal classes are Samrap\Fluent\Builder, etc.

Confirming that the root namespace of this project will be Samrap\Acf.


beforeFeature / afterFeature

What are you trying to achieve?
There are some actions that I need to execute after running all tests in a feature.
I am wondering if we already have something like "beforeFeature / afterFeature".
What do you get instead?
I've already analyzed the before/after and the beforeSuite/afterSuite. The first one doesn't work for my case because it executes once for each scenario. The second doesn't have access to the browser.
So, basically, I want a command that behaves like before/after but runs only once at the and of the feature execution.
Details

CodeceptJS version: 0.4.8
NodeJS Version: 6.2.1
Operating System: IOS
Nightmare version: 2.7.0

Yes, browser is started automatically before a test. You can start it manually:
Consider using beforeSuite with manualStart: true option enabled.
Then you will need to create a custom method like I.startBrowser():
startBrowser() {
  return this.helpers["WebDriverIO"]._startBrowser()
}

And this should work in beforeSuite context:
BeforeSuite((I) => {
  I.startBrowser();
});

Also add restart: false option, to keep browser up between tests

@DavertMik will this still work for Nightmare even though it's the WebDriverIO helper? It seems the OP is using Nightmare (as am I), but I don't see manualStart in the helper object for Nightmare.
Thanks

Ah, I believe I see how it works now for Nightmare:
CodeceptJS/lib/helper/Nightmare.js:
_beforeSuite() {
    if (!this.options.restart) {
      return this._startBrowser();
    }
}

...
_startBrowser() {
    this.browser = this.Nightmare(this.options);
    this.browser.on('dom-ready', () => this._injectClientScripts());
    this.browser.on('console', (type, message) => {
      this.debug(`${type}: ${message}`);
    });

    if (this.options.windowSize) {
      let size = this.options.windowSize.split('x');
      return this.browser.viewport(parseInt(size[0]), parseInt(size[1]));
    }
}

So I set restart: false in place of manualStart: false and then created a custom helper function but used Nightmare Helper method rather than WebDriverIO:
'use strict';

class Utility extends Helper {
  startBrowser() {
    return this.helpers["Nightmare"]._startBrowser()
  }
}

module.exports = Utility;

That worked well for me.

Closing due inactivity


Abstract field is being duplicated in metadata views

Abstract field is being duplicated in metadata views.

Fixed.  Removed function used to render parent "notes" field.


Create palindrome

I have created that file palindrome.js

No buddy ,
I think you made a lil mistake
First thing ,
Did you fetch and merge before making contributions  ?
Second thing,
this repo is not for code contributions , pls read the readme carefully


Mac cleanup would cause iCloud synchronization failure

After a Mac cleanup, iCloud may cause MacOS to have trouble syncing with iCloud, including desktop files and notes.

My MacOS is 13.2.1（22D68), and after mac-cleanup, and the files in my folder cannot upload to iCloud automatically, and also cannot download fils automatically, and any service about iCloud cannot normal execution.
I found out that by performing the following three steps, I can reset iCloud service.

Turn off Wi-Fi first.
Navigate to ~/Library/Application\ Support.
Run sudo rm -rf CloudDocs.

Therefore, I suspect it might be due to deleting a folder inside ~/Library/Application\ Support. However, the exact reason may require further investigation.


Big numbers means big responsabilities

Describe the bug
Big numbers are not displayed nicely on the header with a 15" screen
To Reproduce
Steps to reproduce the behavior:

Login when you are rich AF
Look at your money and dislike the way they are printed, they make you look poorer

Expected behavior
See 19M or some other cool expandable shorthand that on hover or on click show the whole number
Screenshots

Desktop (please complete the following information):

OS: MacOS
Browser Chrome
Version 72

We have to decide if the fix I suggest make sense for everyone and/or what else we can do to show massive numbers, the chain will grow so also block numbers will hit big numbers

the SDK is going to send us Atoms, not uAtoms in the future... so this will be resolved when that is completed.

Lol this description is golden

still @sabau is correct - we may have some millionaire-atom-hodlers who this will be ugly for.

Other UIs just shorten the numbers at some point: 1000000 becomes 1m

ah true!
1k, 1M, 1B

still, we agreed to do the math until the REST API returns Atoms instead of uAtoms

Let'S make big numbers font size smaller

[ ] add a class if long numbers
[ ] do calculation for uAtoms

i'd like to leave the font size as is for now - if this is an issue in the future we can add more dynamic font sizes. is that ok?


Implement account delete functionality.

Related to #256. Should implement functionality to delete a user account. Unfortunately in line 297 of controllers/accounts.js, the redirect is not working. Any help or ideas?

@funkaoshi Thank you very much for your feedback! I will fix the encoding, that was my bad :smile: .
@funkaoshi regarding your other comment: Unfortunately I don't get what you mean. Are you saying the Account Settings -> Delete Account is an action that does not require me to be authenticated? But it only occurs after the login is done and even contains a check if the current user is the user conducting the action... So I don't really get your comment. Could you please explain?
Thanks a lot again for your support!

@fabianschwarzfritz You need to be authenticated to delete your account. After your account is deleted you won't be authenticated (or have an account!). We need to send you to a page we know isn't going to 403. The login page is as good a page as any.
I might be misunderstanding the code!

@hhaidar needs to sign off on changes FYI.


build: drop typescript 3.9 checks

Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see https://github.com/angular/angular/pull/39313).
Also updates the Firebase functions to TS 4.0.
Note: this is merge-safe since it only changes build-related code.

Unblocking since the Framework PR has landed.

@crisbeto I don't think we can remove the tests until Google is off 3.9

The Framework team dropped support on their end though. See https://github.com/angular/angular/pull/39313.

They changed the supported TS range for CLI apps, but they still have the tests for it (Andrew's PR says those will be removed in a follow-up, and that follow up would also be blocked on Google finishing updating to 4.0)

Alright, re-blocking this one.

@crisbeto is this merge ready again?

Looks like support was dropped in v11 from the Framework repo. Unblocking.


background hero layout aligns long titles to the left on mobile

Currently, when one has a long title and the layout is set to either background or hero, the title is aligned to the left. I believe a center alignment would look more desirable.
On inspecting your website, changing the title to a longer name and using mobile view, I was able to reproduce the same thing I got on my own config. The screenshot below is when using Firefox but I have confirmed the same on a chromium browser (Brave).
Screenshot

Also noticed the same case with long headlines.
Mine is short so it isn't affecting me but I've noticed that on one of the theme users.


Fresh install stuck after login?

Expected results
Website to load after login
Actual results
Website doesn't load.

Screenshots

No errors in browser console or network tab.
How to reproduce the bug
Follow the official guide. https://superset.incubator.apache.org/installation.html#superset-installation-and-initialization
Note that I remove and then create a new virtualenv between each of the following.
Started with latest stable pip install superset, but started getting errors. Checking this github, was able to resolve: https://github.com/apache/incubator-superset/issues/7025 with a pandas downgrade; and https://github.com/apache/incubator-superset/issues/7514 with a move to master (f7d3413a501d8b643318fe7c0641eba608a079f5).
Environment
(please complete the following information):
$ superset --version  # see above for commit hash
Flask 1.0.2
Python 3.7.3 (default, Mar 27 2019, 09:23:15)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)]
$ python --version
Python 3.7.3
$ node --version
v10.15.3
$ npm --version
6.9.0

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@SamuelMarks quick question to clarify - did you first try to install superset via pip and then tried building from the git repo? If the latter is true then you'd probably need to build static assets, I remember having the same problem when not following the steps outlined in https://github.com/apache/incubator-superset/blob/master/pypi_push.sh#L18-L22

Thanks @elukey ! - That got me further, now stuck on:

(note that I ran a git pull, and am now on fc3b043462cf00e8415e8ece22f4d01b131b9cd7; also there are still no errors in console or non-200 network requests)

@SamuelMarks I usually pick one of the release branches when building, the tip of master might be a bit unstable but should work. Can you please add a bit more info about what "stuck" means now? Are you able to navigate other panels? Is there any log (JS/python/etc..) that indicates what it is happening?

Just tried again, it's working now


BUG Contact us section is not properly display in light mode

Describe the bug

BUG Contact us section is not properly display in light mode (Label or not display )
Expected behavior

Screenshots (Mandatory)

Additional Context (Mandatory )
JWOC
Are you contributing under any open-source program ?

@AftabMankapure I will assign you this only after completion of the previous PR

@AftabMankapure this issue has already been solved . Sorry to close this issue


Problem adding advanced dynamic content

Hi all,
I have problem with adding advanced dynamic contect. I created marketing email and passed error checking. After i add "custom code" with value:

Your reference:

D_AVTO{{this.poc_name}}

External Campaign Name 2{{this.poc_segmentname}}

I receive error when trying to perform Test Send (error checking): "Text: Your message includes dynamic content that won't evaluate correctly when you send it. Please check for errors in the expressions, for example unsupported relationships or properties.".
I create this expression below,  based on example on this page:

You have purchased:

{{this.name}}

I also tried to replace entity relationship  with "contact.msevtmgt_eventregistration_contact_msevtmgt_contactid"and remove conditions but without success:

You have purchased:

{{this.msevtmgt_name}}

despite below expression that I found in one of the comments is working:

{{this.msevtmgt_name}}

Can someone confirm that first expression should work? Is there any workaround to get data from selenceted related entity (1:N) with (example contact can have more related record on entity poc_dynamic_data and I want to add the one which match conditions)
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad8c1bb2-2910-4e89-3225-90846bf5a4dd
Version Independent ID: 19251bed-3612-22ef-dca2-fcbcb64d3bab
Content: Add dynamic content to marketing emails (Dynamics 365 for Marketing)
Content Source: ce/marketing/dynamic-email-content.md
Service: dynamics-365-marketing
GitHub Login: @kamaybac
Microsoft Alias: kamaybac

Hi @tomo00051, thank you for contacting Microsoft.
I quickly tried a couple of your examples. Your examples based on event registrations worked for me (didn't produce errors), and these examples are essentially identical to the one given in the help topic. I tried your first example, but that did produce errors (as did the literal example from the help topic). The reason that the help-topic example generates an error for me is because the relation shown there doesn't exist on my system. Your relation likewise doesn't exist here. It could be that your relation is either missing from your instance or isn't formulated correctly. Your third example (where you used the relation and field name for event registration) did work for me (didn't produce an error) using copy/paste from your message.
Here are some things to try: 1: Make sure your related entity is set to sync with the marketing services. 2: Use assist-edit to create the relation for the {{ #each ... }} expression. 3: Make sure the field name ({{this.name}}) really exists on the related entity.
I think I may replace the theoretical example in the help topic with the working out-of-box example of event registration, but that won't really help your issue (the form we show in the help topic is correct). Consider writing to the forum to get more input on your issue (https://community.dynamics.com/365/marketing/f/768)

Hi @kamaybac, thanks for quick reply.
The problem was in the wrong relationship, instead of

I should write

After I fixed the problem with wrong relationship, I tested marketing email using Test Send. But sent “test marketing email” did not contained result of the expression  {{this.in2_name}}. Then I found out that I missed "Field values from lookups and related tables aren't shown in the Preview tab of the designer, or in test sends."
After, I tested it through customer journey expression was resolved correctly. Problem is solved.
Summary:

1:N relationship for should be "first entity"."related entity""first entity""lookup field"
Entities you use should be set to sync with the marketing service
You cannot test it using "Test Send", but only through customer journey

Hi @tomo00051 , thanks for following up with your solution! That's useful for me, and I'm glad to hear it's working for you now. Your summary is correct, though I wouldn't necessarily rely on that naming convention for relations; instead I recommend always using assist edit to place your relation, entity, and field expressions to ensure they are correct and exist. I considered mentioning the issue with some types of dynamic data not working in preview or test sends in my initial reply; I'm glad to hear you found that detail and worked it out.