Align with fsharp/fsharp & Microsoft/VisualFSharp via cherry-picking

Covers commits on Microsoft/VisualFSharp
reduced version of https://github.com/fsharp/fsharp/pull/686
d0cc249b951374257d5a806939e42714d8a2f4c6 thorugh 91da9dbdf6a492372c0e3d497efcf0b726be357c
Squashed commit of the following:
commit b1e018d6449ef927419dc46a5bac112d74acb914
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:51:10 2017 -0400
Update DEVGUIDE.md

commit 324afafc0cc8f6cf128214d29f0dc37f9669f574
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:48:30 2017 -0400
shorten directory path for some vsintgration tests

commit 01a663668bb906f8a1faf08a8ff2255b8ce8b477
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:45:22 2017 -0400
Clickable QuickInfo with "go to type" (#2574)

* custom tooltip test

* tagClass augmented

* kinda works

* getting there

* module, alias

* not sure if works

* fix build

* go away!

* parens out

* halleluyah it builds

* blank space on empty doc removed

* more sensible

* handle linked files

* collapse empty TextBlocks

* styling, simple tooltip, handle scripts

* dismiss quickinfo on navigation

* reliably dismiss quickinfo session

* interface instead of boxing

commit 117789cfa1b5df0d9057113ab4d6c892cf44e053
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:41:21 2017 -0400
Fix for #2595, ported from fsharp/fsharp (#2605)

* Fix for #2595, ported from fsharp/fsharp.

* Fix .targets to work with xbuild and msbuild

Fix Microsoft.FSharp.targets with a workaround so resources are included
correctly when building with either msbuild or xbuild.

commit 89f5b7495e6c23b258bad8f9c1f7fa9f9ca95ced
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:39:06 2017 -0400
Add non-regression test for backtick member completion (#2660)

as I had to chase down where `and CompletionItem = string * string * (unit -> string) * DeclarationType` was originating from, I had to make it a single case DU to find places which would break and eventually find the source (Salsa.Privates.SimpleOpenFile.AutoCompleteAtCursorImpl); I think having it as a DU is better, and we should avoid type alias over mere tuples as finding their source is difficult.

I had to surface "nameInCode" into CompletionItem to add my test.

I added AssertCtrlSpaceCompletion taking higher order function to enable arbitrary checks on the completion lists.

commit c6473c3aecfc35b243ac9784c747e97988b34f41
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:38:19 2017 -0400
additional test categories (#2655)

commit 5ea0da7ae2b32cf3cd6e0743a678bd0da7295fff
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:37:02 2017 -0400
cherry-pick  7c714a36... Update the Markdown documentation

commit ab0cb957f4a4d0c3fb6fef99ef18fbd3dbb76e80
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:34:29 2017 -0400
Fix vs std11 commands (#2645)

* Only return VSConstants.S_OK for commands we handle.

* Remove do keyword

commit 78dcc372bf6d047ad1d37065702a18d654a612d8
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:34:00 2017 -0400
Update error message for #569 (#2635)

* Update error message for #569

* fix test

commit b1f12453bbffbc641d802fc7fa19bcdf9bbbf3b9
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:32:47 2017 -0400
remove wrongly left a costly sprintf "%A" parsed-input which makes completion very slow

commit a88439d7faa647795b560a6a94c685e81f2349b2
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:32:18 2017 -0400
Trigger completion optimistically (#2594)

* port Roslyn's C# completion triggering logic as is

* fixed: completion do not trigger at all

* fix position

* fix a test

* do not provide completion on certain places

* fix muting completion on Named(Wild) pat in binding

* do not provide completion on ctor / lambda parameter names + tests

* fix binding traversing in completion

* fix tests

* fix the last failing test

* "trigger completion after a character is typed" setting in a new completion property page

* force intellisense property page loading

* do not commit completion on space in auto triggering mode

* fix completion list ordering

commit 654ebfa046cd596b497912f9ff0feff0debe501c
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:31:07 2017 -0400
Use Primary GUID when opening items from SolutionExplorer (#2606)

* Use Primary GUID when opening items from SolutionExplorer

* Declare LogicalViews our EditorFactory can handle

commit 213287f0061b2f5118b7093085b6ed4aad30be88
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:30:37 2017 -0400
testcase for issue https://github.com/Microsoft/visualfsharp/issues/2554

commit 1c894b553a7658df6cd8cfeed7d341fe44cae44f
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:29:58 2017 -0400
Splitting seq.fs (#2598)

* Split seq.fs(i) in preperation for iseq

* Made mkConcatSeq internal

Don't polute surface area

commit 83ccd326de6262ce9b506a840b5846e09967b9db
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:28:48 2017 -0400
Remove ci_prt3 dependence on build net40 (#2601)

* Remove ci_prt3 dependence on build net40

* Fix ci_part2 build break

commit 85fe4c429faf9278b4e0a857c58a9d9db5a44669
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:27:36 2017 -0400
Fix for generic constraint evaluation error in FSI (#2590)

* Add a test to reproduce the issue

* proposed fix for #2411

* do not try to check non nominal argument types

* move local functions out (temporarily)

* try other fsimode???

* * try to move back local functions, adding type annotation might help with proto compiler
* disable test through pipe, no clue why it fails in fsharqa, works locally

* fix naming for policheck

commit 77ef387f1beef132a52c4bedf2c5078eaa4924c0
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:26:50 2017 -0400
Fix completion list ordering (#2583)

* fix getting type of lhr

* add a test

* fix completion items ordering

* Revert "add a test"

This reverts commit 5a57cb470aeb995cd7a4b41695c13b185f172f2c.

* rewrite items ordering, add tests

* extension methods are shown at the bottom of completion list and they don't participate in MRU hints logic

* shorter sort text

commit d539c67082ebe073d8013728696762087df96f7a
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:26:22 2017 -0400
Address mono build issue

commit 5cb3d57f0b5ee0f1f1b2e9ef77ec6abd9fab604d
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:25:50 2017 -0400
visualfsharp.unittests needs msbuild v12.0

toolstask isn't available with msbuild 15.0

commit b67f099b80147cdd5c97ef4dd09c1c0d8fe653ec
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:25:23 2017 -0400
* Replace usages of Array.toList |> List.map
* in queryableTypeGetMethodBySearch, do not map parameter types if the expected length is not matching

commit 6d72c55206ecfad37b488e960149c6e3bd08c0f0
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:24:26 2017 -0400
optimize GetEnvironmentLookupResolutionsAtPosition (#2580)

commit 9c970eaca0f805a73effb2e279dc2761a4ecb037
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:23:58 2017 -0400
update F# templates to no longer unconditionally override FSharpTargetsPath. (#2575)

* update F# templates to no longer unconditionally override FSharpTargetsPath.
This allows to set FSharpTargetsPath from outside.

* also allow override of FSharpTargetsPath in portable project templates

* use PortableFSharpTargetsPath for portable templates

* updated templates: better spacing

* unify conditions

commit cb0cb4e791806c27715de2cee481b67b44e5d523
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:23:11 2017 -0400
Update README.md

commit 7de962724f2367f573a33018b12479c461a1df20
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:20:54 2017 -0400
cherry-pick 32cc9315

commit ea081171eb1a5e9869b0e8642904852f998959a0
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:19:32 2017 -0400
set theme colors at startup (#2567)

commit e50284bba9a8fe89fc6488b0294197df2516e0cf
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:19:00 2017 -0400
Completion: better glyphs and proper items list ordering (#2532)

* add distinct list for priority completion items (wip)

* Revert "add distinct list for priority completion items (wip)"

This reverts commit a854f2646b682079c83841ac1cdb1595799b1197.

* it works

* smarter completion items ordering

* show type's own instance methods and properties first

* show type's own static methods and properties first

* own IL fields are shown first

* order fields, props, methods, events

refactoring

* simple MRU completion items priority

* fix tests, normalize mru items hints, refactoring

* fix priorities inside mru

* completion items glyphs take accessibility into account, proper glyph for extension members

* fix a test

* fix completion item description ordering regression

* rename GlyphMajor to FSharpGlyph and make it a union instead of enum

remove GlyphMinor
remove the old navbar and tests

* minimize diff

* make MRU list keyed by Item.FullName instead of DisplayName

fix a bug with emptyArray.max

* fixed: FullNameOfItem throws being called on Item.Types (TType.<anything but TType_app>)

* fixed again: FullNameOfItem throws being called on Item.Types (TType.<anything but TType_app>)

* fix stack overflow

* fix tests

* fix tests

* fix tests

* port rest of the code from priority-in-completion branch

* minimize diff

* fix wrong accessibility in CompletionItem

commit e5d942833b96675339d50fda8b1138e85f2e463f
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:18:15 2017 -0400
add fsharpqa test to the list

commit 530d9b18a5233152ed68ab7d9d8f9484e5ed0b21
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:15:46 2017 -0400
Follow-up to #2497. (#2536)

Fix FSharpSource.targets so ILComparer builds on mono.
In build.sh, preface invocations of nunit-console.exe with `mono`,
so it runs as expected. Move the net40-fsharpqa tests last,
unit tests (when they work) are faster than the tests in fsharpqa
so we'll fail faster when there's an obvious breaking change.

commit f7d4ce880332ec1bcadd938dc2eace7337f51b23
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:15:06 2017 -0400
Remove ocaml and F# Comment if defs (#2530)

* Remove comment ifdefs

* 'fix

* Last test case update'

commit a5e75321f73f4d8e67f9fcac45268f11b6bbbde5
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:14:14 2017 -0400
Do not suggest already opened namespaces and modules in "Add Open" code fix (#2515)

* do not suggest already opened namespaces and modules in "Add Open" code fix

* check if we can obtain symbol via GetSymbolAtLocation

* Revert "do not suggest already opened namespaces and modules in "Add Open" code fix"

This reverts commit a085f3976bac3038cca3804b247d5f71848714d2.

Conflicts:
	vsintegration/src/FSharp.Editor/CodeFix/AddOpenCodeFixProvider.fs

commit 63c300e83eec1adef0bd3f4f36de6727761ffa54
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:13:02 2017 -0400
Quick Info: proper glyphs for namespaces, structures and operators (#2282)

* show proper glyphs for namespaces and structures

* glyphs for literals and delegates

* fix layout for struct records and unions

* proto does not like Option.defaultValue

* show [<Struct>] in layout instead of "struct" for struct records and DUs

* show proper glyph for operators in QuickInfo

* fix test compilation

* layout `Measure` and `Struct` special attributes as types

prettier records layout

* fix a test

* Revert records layout change

* fix TypeChecker

* do not print [<Struct>] for ordinary structures

commit c989723d1be7b2fc506d1841bcf1159e0484e8e8
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:11:08 2017 -0400
Add signature file and fix 2498 (#2508)

* add signature file

* fix 2489

* another sig file

* another sig file

* error logger for GetProjectOptionsFromScript

* fix build

* fix build (2)

commit 2fd026b058fcb5429d350c6232e078db93087222
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:10:03 2017 -0400
adjust to use punctuation

commit 78f97dfe6830b3d42017d2f1179c433c739ebb2e
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:06:00 2017 -0400
highlight disposable types

commit 39fd874b84a2d4cf7848635507aaec81e1a7fd75
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:00:55 2017 -0400
Tastops.fullNameOfParentOfNonLocalEntityRef and Tastops.fullNameOfParentOfNonLocalEntityRefAsLayout used to perform two comparison by accessing nested properties (up to 4 get per call: `nlr.Path.Length = 0 || nlr.Path.Length = 1` (#2295)

replaced with `nlr.Path.Length < 2`

commit d742aa30eea8fff24e416b9061f7752468ca6b3d
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 17:00:20 2017 -0400
Unused opens analyzer (#2477)

* UnusedOpensDiagnosticAnalyzer

* it works

* remove unused code

refactor

* RemoveUnusedOpens Code Fix

* fix crash on EnclosingEntity

* refactoring

* add Seq.toImmutableArray combinator

* bug fix

handle nested modules

* fixed: it does not work on attributes

remove unused opens

* dog food

commit feb685a4d0c6df48bbbe46f7d76e26079d66fe05
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:59:31 2017 -0400
highlight reference cells as mutables (#2470)

commit ea73f705b0decd82bff2c8981a014d4d69fd1118
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:58:28 2017 -0400
Remove a couple of roadblocks in loading Fsharp.core projects (#2482)

commit 45fa75c5aa46fb371c13bdf289d02200db3bb5b6
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:57:51 2017 -0400
Trigger add open for FS0043 (#2474)

* Trigger add open for FS0043

* Contains -> StartsWith

* fixed: AddOpenCodeFixProvider may suggest name qualifying for operators

commit 8e373bacb8c69b385823f2d2e8c4987b87ac92fe
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:57:13 2017 -0400
Highlight "raise", "reraise", "typeof", "typedefof", "sizeof", "nameof" as keywords (#2475)

* highlight "raise", "reraise", "typeof", "typedefof", "sizeof", "nameof" as keywords

* fix compilation

* colorize forgotten "int8" and "uint8" as keywords

commit fcb4314ead075c76c493dc62b96e0ebcc9cfb5e5
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:50:35 2017 -0400
Enable IsModule test for Core CLR (#2464)

Fixes https://github.com/Microsoft/visualfsharp/issues/2462

commit 80aa32ff86d2f8f5f4a5aa30713712ea5d619d3a
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:50:04 2017 -0400
Doh

commit 1d96a76953a0aa9f503a743f9268248fab04772b
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:49:35 2017 -0400
Make transitive builder cancellation explicit  (#2460)

* make transitive project cancellation explicit

* fix build

* add time stamp cache

* updates to avoid work items

* add time stamp cache (2)

* avoid duplicate cancellation check (cancellation is implicit on bind of cancellable)

* add time stamp cache (4)

* fix build (6)

* add debug output

commit 37577b65773e78fd7326396529a99e55724127a1
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:48:51 2017 -0400
reverse integrate all fsharp/fsharp changes (#2442)

* integrate all from fsharp/fsharp

* integrate all from fsharp/fsharp

* fix build

* fix build

* fix build

* fix build 3

* fix build

* fix build

* fix build

* revert chagnes to tests

* fix build

* simplify variables

* fix build

* fix build

* fix build

* fix resources

* fix resources (2)

* fix tests

commit eda7a690b99019131a0c68437ce77fcb253d5a32
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:32:57 2017 -0400
add test

commit c131854acc1d3ffcca7cd850e0e5a9fa45033ad7
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:31:08 2017 -0400
fix '*' and '^' operator coloring

commit 9443021f0ea1cef99f264d887437671b49145ca5
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:30:37 2017 -0400
do not highlight any types as keywords

highlight a number of intrinsic functions as keywords

commit bf62d1d49694cf7d711902bfdde6f4b6442689ef
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:30:10 2017 -0400
Colorize Punctuation

also `<-` as keyword

commit e3b5b8f2cb7260edb5ea3abecdde22d786753108
Author: Jared Hester<EMAIL_ADDRESS>Date:   Sun Mar 26 16:29:31 2017 -0400
colorize type argument

@cloudRoutine Hmm.... We normally do this via integrating (merging)
visualfsharp --> fsharp --> FSharp.Compiler.Service

rather than cherry-picking.

My mistake, the last time I had to move stuff across to them you told me to cherry-pick it, so I figured that was the way it was typically done.
I can split off all of the conifguration and organization commits and then reapply them on top of a merge if you think that'd be better

I can split off all of the conifguration and organization commits and then reapply them on top of a merge if you think that'd be better

It's hard to tell.  Normally I just merge and fixup conflicts.  If it's equivalent to that then we can do that

maybe i'll try again some other day...

@cloudRoutine I really, really want to get everything totally aligned and fully integrated.  We would then start building FSharp.Compiler.Service in Microsoft/visualfsharp.
It's possible we would still build the nuget package from here in case we need to make rapid fixes - but no feature development. The only feature drift I could imagine is Fable support, which requires a whole different test/tool chain to validate.
Perhaps we could make a big push on this alignment this week.

i'd gotten to the point where it was building successfully and only 10 tests were failing, but I wasn't especially confident in all of my changes.
a suggestion on how we could make the alignment easier in the future - most places where #if COMPILER is used seem like types that it would be more useful to have the compiler service expose. So if we got rid of COMPILER as one of the defines for FCS add || COMPILER_SERVICE to the 10 or so places where having #if COMPILER defined was actually useful and change all of the
type (* internal *) foo = ...

to
#if COMPILER
type internal foo
#else
type foo
#endif
    (args ) =

it should cut out a bit of merge conflict resolution busywork

@cloudRoutine Yeah, we have to just align that stuff somehow, agreed


Improve queryAssignedElements decorator browser compatibility

Context
Internally queryAssignedElements was using the newer HTMLSlotElement.assignedElements method. This newer method doesn't have ShadyDOM polyfill support, but would still leave some browsers unsupported if it did have polyfill support.
Using Modern browser breakdown as a guide, assignedElements is not supported until Firefox 66. This leaves Firefox versions 64 and 65 without support.
How
Until there is a better plan forward, revert the private implementation of the decorator to use the fully supported assignedNodes method.  The behavior of the decorator remains unchanged.
Testing
This is a private implementation change, so the existing unit tests should cover this. No functional changes.
Also testing via cl/420366110
Size of decorators before changes (on main):
Name                                   Size     Minified  Gzipped  Brotli
----------------------------------------------------------------------------
decorators/query-assigned-elements.js  74 B     73 B      87 B     62 B
decorators/query-assigned-nodes.js     71 B     70 B      86 B     63 B

decorators/query-assigned-elements.js (DEV)  519 B     518 B     380 B    323 B
decorators/query-assigned-nodes.js (DEV)     593 B     592 B     442 B    362 B

Size of decorators after change:
Name                                   Size      Minified  Gzipped  Brotli
-----------------------------------------------------------------------------
decorators/query-assigned-elements.js  74 B    73 B      87 B     62 B
decorators/query-assigned-nodes.js     71 B    70 B      86 B     63 B

decorators/query-assigned-elements.js (DEV)  685 B     684 B     464 B    391 B
decorators/query-assigned-nodes.js (DEV)     606 B     605 B     421 B    361 B

The release size is the same after this change, only dev has slightly increased in size.

Note, this has passed tgp.


Allow null color in JFXColorPicker

Fixes #698

Thanks @micheljung for the fix 👍 , however before merging with master can you fix the change in line 207.
the label text fill is computed using the gray scale color instead of the actual color, so circleColor.getRed() needs to be changed to circleColor.grayscale().getRed()

Oops, good catch, wasn't intended :) Fixed

Thanks @micheljung for the PR 👍


Refresh interval override

Describe the solution you'd like
Overriding default of refreshInterval . Managing a lot of secrets and manually set refresh interval to them kinda takes time , would be good to have something in Values.yaml to override this value by default
What is the added value?
Saves a lot of time
Is there is a such option ? If not would be grateful if it will be added.

It seems that the one hour default is part of the v1beta1 api
Would be a great feature

My opinion: the problem i see is, that this contradicts the spec.refreshInterval defaults on the CRD level and leaves the user with galse expectations. Also, we would have to maintain this, although there is a solution to it:
I'd suggest users that want this feature to use a policy tool like kyverno to mutate the resources on the fly.

Happy to check kyverno, it looks useful! Thanks for sharing.
Just to double-check:
Are you talking about the spec.refreshInterval from ExternalSecret?
If it is the case, I don't see anything about defaults in the doc so I was not expecting anything on my side, is there a default value for it?

https://github.com/external-secrets/external-secrets/blob/main/apis/externalsecrets/v1beta1/externalsecret_types.go#L327-L328 it's set here (kubebuilder is codegen) @SlevinWasAlreadyTaken


multiple requirements.txt files

How does one set up a monorepo with multiple packages, each using their own requirements.txt?
Using one //third_party/pypi would be the best, but perhaps right now the easiest is to use //third_party/LOCALPACKAGE/pypi/... or //third_party/pypi/LOCALPACKAGE/...

The pip_generate tool currently does not generate version-specific dependencies, partially since it relies on pip to resolve dependencies, and it can't have more than one installed. This means you have two choices:

Create a "merged" requirements.txt and feed that to pip_generate, to create a single pypi_rules.bzl file with all the merged dependencies (this is what I do)
Generate separate pypi_rules.bzl files for each separate package, and have their BUILD files reference the correct ones.

I think it depends on if you want to use a single, consistent version of every Python package across your code, or if you want the separate packages to be able to specify conflicting versions. IMO,  I think an advantage of a monorepo is you can upgrade everything at once, so I would go with the single "merged" requirements.txt.
Hope that helps!


Release notes could do with a link to upgrade instructions

Description of problem
Our release notes do not link to any install or upgrade instructions.
Description of solution
Provide links to a set of simple instructions explaining how to install and upgrade DNN to the latest version.
Description of alternatives considered
You could include a simple set of upgrade instructions in the notes?
Additional context
One of my colleagues pointed this gap out when I sent them a link to the latest release - they had to google to find out how to upgrade their install.
Affected version

[x] 9.2.2

I suggest using a link, which can easily been redirected.

I would assume that dnn.ly is just an alias for bit.ly, which doesn't allow changing URLs after creating them.  What about just dnnsoftware.com/upgrade, which could be a page on the site that is setup as a redirect?

I would assume that dnn.ly is just an alias for bit.ly

You would be correct.

What about just dnnsoftware.com/upgrade

Could @CBPSC arrange such a thing for us?

I can definitely create a /upgrade page. Are you wanting it to redirect to the wiki/upgrading-dotnetnuke page?

We added these into the RC and they’ll be including going forward with each release.


Adding filters to dance types

Description
This PR introduces filters to dance_types.
Fixes #219
Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[x] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

Before and After
"do a forward roll then jump up in the air and say yeah"
Before:
{'action_sequence': [{'action_type': 'DANCE',
                      'dance_type': {'dance_type_name': [0, [2, 3]]}},
                     {'action_type': 'DANCE',
                      'dance_type': {'dance_type_name': [0, [5, 9]]}},
                     {'action_type': 'OTHERACTION'}],
 'dialogue_type': 'HUMAN_GIVE_COMMAND'}

After:
{'action_sequence': [{'action_type': 'DANCE',
                      'dance_type': {'filters': {'triples': [{'obj_text': [0,
                                                                           [2,
                                                                            3]],
                                                              'pred_text': 'has_name'}]}}},
                     {'action_type': 'DANCE',
                      'dance_type': {'filters': {'triples': [{'obj_text': [0,
                                                                           [5,
                                                                            9]],
                                                              'pred_text': 'has_name'}]}}},
                     {'action_type': 'OTHERACTION'}],
 'dialogue_type': 'HUMAN_GIVE_COMMAND'}

Testing
Tested locally
Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[x] I have added relevant collaborators to review the PR before merge.

I added some changes on the locobot side when doing the interpreter updates.  can you add Anurag as reviewer also?

I added some changes on the locobot side when doing the interpreter updates. can you add Anurag as reviewer also?

Yes just added him


macos: Crashes when in Notebook or Console menus, can't seem to use the application at all

Running on mac OS Sonoma, with jpterm version… either 2.3 or 0.2.11? I’m not sure how to read the version information from pip and the program doesn't come support for a --version command line flag.
(Output from pip inspect)
// [...]
    {
      "metadata": {
        "metadata_version": "2.3",
        "name": "jpterm",
        "version": "0.2.11",
        "summary": "Jupyter in the terminal",
// [...]
    }

I can get as far as this menu:

Trying to select anything in that Select dropdown by pressing Enter puts the program into this state:

Quitting with Ctrl-C just yields a message about handling the KeyboardInterrupt, which is of no diagnostic value.
^C^CException ignored in: <module 'threading' from<EMAIL_ADDRESS>Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 1583, in _shutdown
    lock.acquire()
KeyboardInterrupt:

Did you try to create a new notebook?
What was in the dropdown menu?
Can you try to click instead of hitting Enter?

Selecting by clicking doesn’t result in a crash. This is the content within the dropdown:

I see there is nothing in the dropdown menu, but you should at least see python3.
Do you have ipykernel installed?
Could you show the output of pip list?
Are you running in local mode or through a server (with jpterm --server ...)?

Sorry for the delayed response. ipykernel is installed. This is the output of pip list: pip-list.txt
(Perhaps the packages are outdated; I’ll check later. Regular Jupyter notebooks do work.)
I get the same result running jpterm with and without the --host flag pointing to the URL that jupyter notebook prints to stdout.


[sdk] dry-run erroring

Reported by LiFi.

running unit test not facing any issue, going to test on testUi


removed dependency on Guava from job-dsl-core module

job-dsl-plugin uses transitive dependency from Jenkins core.
This should avoid problem if Jenkins core uses a different of Guava than the Job DSL plugin.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests


[Request] Support 'Scope by Storage' type view/queries

I am in an environment with heavy use of storage scoped logs (logs originate outside the project and are routed there via logging sinks), and it does not seem possible to query these logs with this plugin yet.
Example:
in GCP Log Explorer UI, change scope to scope by storage.
create query (simple logname = projects/myproject/logs/myapp)
run query and verify.
copy/paste query into Grafana GCL datasource
No Data found

We are in the same situation here.

The scope feature has been added to rel 1.2.1. It implemented as dropdown menus with project/bucket/view. Let us know if you find any issue or have any feedback. Thanks!


added installation of root certs

Without the updated root certificates the Remi key installation fails.

didn't fix the issue. I'll be back


Multi Instancing problem

Dear Friend,
I need two instance of Logger in my app with different configurations. I wrote bellow sample code but found there is a problem in multi instancing.
            var config1 = new LoggingConfiguration();
            var fileTarget1 = new FileTarget();
            config1.AddTarget("file", fileTarget1);
            fileTarget1.Layout = "${message}";
            fileTarget1.FileName = "1.txt";
            var rule1 = new LoggingRule("1", LogLevel.Trace, fileTarget1);
            config1.LoggingRules.Add(rule1);
            LogManager.Configuration = config1;
            Logger Logger1 = LogManager.GetLogger("1");

            var config2 = new LoggingConfiguration();
            var fileTarget2 = new FileTarget();
            config2.AddTarget("file", fileTarget2);
            fileTarget2.Layout = "${message}";
            fileTarget2.FileName = "2.txt";
            var rule2 = new LoggingRule("2", LogLevel.Trace, fileTarget2);
            config2.LoggingRules.Add(rule2);
            LogManager.Configuration = config2;
            Logger Logger2 = LogManager.GetLogger("2");

        Logger1.Info("1111111111111");
        Logger2.Info("2222222222222");
        Logger1.Info("1111111111111");

Result : only (second) file contains "222222" and first file is missed!!!!
Type :Question
NLog version: 4.3.11
Platform:  .Net 4.5
Current NLog config : C# Code Config

What is the current result? single 1.2.txt contains "2222222222"
What is the expected result? 2 Files each contains related messages
Did you checked the Internal log?yes (attached)log.txt

Think the clue is that only one LoggingConfiguration is allowed.
So when you do this, then the previous one is discarded:
LogManager.Configuration = config2;
You should append the two loggers (with targets) to the same LoggingConfiguration, and then assign it to the LogManager.

I assume your question has been answered, if not, let us know!


chore: add coverage GitHub action

Using GitHub actions to run coverage reports.

My first PR for this was from my fork, but GH secrets are not passed to actions from forked repos.


Already have a streaming service? Want to start a new one? House them here for MORE Exposure, feedback, teamwork, delegating tedious work, and countless other time-saving and network-building things to get done here at Content for Developers!!! I'm in it to win it, and winning it in my book is crossing the finish line with a team of incredible, hard-working, and inspiring people.
Join US NOW!

hi @mathcodes , I would like to contribute on this enhancement. Could you please assign it to me


Magic Comments not working for images

I am trying to preload/prefetch an image so that I don't have to be connected to the internet at the exact moment to display the image. It's for a "you are offline" page in my app.
I was reading online that the webpack magic comments feature might be able to do that.
https://medium.com/webpack/link-rel-prefetch-preload-in-webpack-51a52358f84c
It's not working for me.
Bug report
The image that I am trying to preload/prefetch does not show and there is no <link rel tag added to the DOM.
If the current behavior is a bug, please provide the steps to reproduce.
Checkout the demo repository here:
https://github.com/aubreyquinn/preload-webpack-demo/tree/main
What is the expected behavior?
I should be able to pre-fetch an image and have the link rel tag added to my DOM.
Other relevant information:
  "devDependencies": {
    "@babel/core": "^7.19.6",
    "@babel/preset-env": "^7.19.4",
    "@babel/preset-react": "^7.18.6",
    "babel-loader": "^8.2.5",
    "css-loader": "^6.7.1",
    "file-loader": "^6.2.0",
    "html-webpack-plugin": "^5.5.0",
    "style-loader": "^3.3.1",
    "webpack": "^5.74.0",
    "webpack-cli": "^4.10.0",
    "webpack-dev-server": "^4.11.1"
  },
  "dependencies": {
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  }

It should be implemented by HtmlWebpackPlugin, webpack generate links only for JS assets

Hi @alexander-akait ! That's great! Thank you! Do you have a small code sample of how to do that with the plugin?

No, it should be implemented by an author of the plugin

What you may need is this plug-in: https://github.com/principalstudio/html-webpack-inject-preload.

It also supports "rel='prefetch '".

I ask @jantimon (https://github.com/jantimon/html-webpack-plugin/issues/1768#issuecomment-1270227968) to mvoe html-webpack-plugin to webpack-contrib to I will fix a lot of issues and implement such things

https://github.com/jantimon/html-webpack-plugin/issues/1317
@aubreyquinn I create a PR that supports entry point preload that might suit your need.

@icy0307 Yeah, we should improve it in html-webpack-plugin


Fix for 2 vulnerable dependency paths

node-flowdock currently has a 2 vulnerable dependency paths, introducing 2 different types of known vulnerabilities.
This PR fixes vulnerable dependencies.

ReDOS vulnerability in the hawk dependency.
remote memory exposure  vulnerability in the request dependency.

You can see Snyk test report of this project for details.
This PR changes Package.json to upgrade request to the newer 2.74.0 version, and will fix all the vulnerabilities.
You can get alerts and fix PRs for future vulnerabilities for free by watching this repo with Snyk.
Stay Secure,
The Snyk Team

please :)

@snyk-community any chance you can fix the merge conflict to make this an easier action for the maintainers?


Minimum React Native version support

I would like to only support RN versions from the past year. The thinking is that if you are not upgrading your RN app for more than a year, you are also probably not upgrading core dependencies like this one. This would put us at RN v0.64.
This means publishing patches to older major versions if the latest has more recent requirements. For example, if we decide that v7 only supports RN 0.68 with new architecture, we will continue to support v6 for RN versions up to a year old.
Thoughts?

I agree it can be problematic to maintain old react-native version.
In all RN modules I saw, they said they don't support of version ...
Now with turbo module and new architecture, I am not sure of the exact impact in terms of dependancies.
maybe @douglowder can give some clues

react-native-maps already does something similar, even more strict actually: https://github.com/react-native-maps/react-native-maps#compatibility


chore(turbo): cleanup turbo config

Signed-off-by: Paul Schultz<EMAIL_ADDRESS>

/override "UI Tests with Node.js 20"
UI Tests are not applicable to this PR.

/lgtm


Support a data that may be passed in PONG from the server

According to the https://github.com/daltoniam/Starscream/issues/229 added optional data parameter that may be filled by a server with PONG.

I'm fine with this change, but could I request it be pointed at the swift 3 branch? It is a breaking change, so better to be included in that release. Also is there a use case you can share for this? I haven't see a setup that requires the PONG data on the client side (not saying there isn't, just have personally seen it before).

Ok, I will do this. I created app where server only kept web socket connection when client was sending ping repetitively. Pong message was used to store connection latency (pong data has timestamp when ping was requested and id).

I ended up just manually putting these changes into the Swift 3 branch. Thanks!


0.7 test fails on s390x

While trying to package mio-0.7 for fedora rawhide, it fails to pass the test: https://kojipkgs.fedoraproject.org//work/tasks/5377/43905377/build.log
test tcp_listener_ipv6 ... FAILED
failures:
---- tcp_listener_ipv6 stdout ----
thread 'tcp_listener_ipv6' panicked at 'the following expected events were not found: [ExpectEvent { token: Token(0), readiness: Readiness(1) }]', tests/util/mod.rs:158:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
    tcp_listener_ipv6

and
test tcp_stream_ipv6 ... FAILED
failures:
---- tcp_stream_ipv6 stdout ----
thread 'tcp_stream_ipv6' panicked at 'the following expected events were not found: [ExpectEvent { token: Token(0), readiness: Readiness(1) }]', tests/util/mod.rs:158:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
    tcp_stream_ipv6

Could you rerun this with RUST_BACKTRACE set to 1 or full? Currently we don't really have enough information to debug this.
Btw I would recommand running all tests on any CI with the RUST_BACKTRACE env var set for any rust projects to get a more detailed error log and backtrace.

I enabled RUST_BACKTRACE and it disappeared. Probably random bug, feel free to close if I can't provide more details.

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }', tests/tcp_listener.rs:279:24
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: std::panicking::rust_panic_with_hook
   6: rust_begin_unwind
   7: core::panicking::panic_fmt
   8: core::option::expect_none_failed
   9: core::result::Result<T,E>::unwrap
             at /builddir/build/BUILD/rustc-1.43.0-src/src/libcore/result.rs:1003
  10: tcp_listener::start_connections::{{closure}}
             at tests/tcp_listener.rs:279
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
test no_events_after_deregister ... FAILED
test tcp_listener_std ... ok
test tcp_listener_two_streams ... ok
test tcp_listener_ipv6 ... FAILED
failures:
---- no_events_after_deregister stdout ----
thread 'no_events_after_deregister' panicked at 'unable to accept connection: Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }', tests/tcp_listener.rs:204:34
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt
   4: std::panicking::default_hook::{{closure}}
   5: std::panicking::default_hook
   6: std::panicking::rust_panic_with_hook
   7: rust_begin_unwind
   8: core::panicking::panic_fmt
   9: core::option::expect_none_failed
  10: core::result::Result<T,E>::expect
             at /builddir/build/BUILD/rustc-1.43.0-src/src/libcore/result.rs:961
  11: tcp_listener::no_events_after_deregister
             at tests/tcp_listener.rs:204
  12: tcp_listener::no_events_after_deregister::{{closure}}
             at tests/tcp_listener.rs:186
  13: core::ops::function::FnOnce::call_once
             at /builddir/build/BUILD/rustc-1.43.0-src/src/libcore/ops/function.rs:232
  14: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
  15: __rust_try
  16: __rust_maybe_catch_panic
  17: test::run_test::run_test_inner::{{closure}}
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- tcp_listener_ipv6 stdout ----
thread 'tcp_listener_ipv6' panicked at 'the following expected events were not found: [ExpectEvent { token: Token(0), readiness: Readiness(1) }]', tests/util/mod.rs:158:5
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt
   4: std::panicking::default_hook::{{closure}}
   5: std::panicking::default_hook
   6: std::panicking::rust_panic_with_hook
   7: rust_begin_unwind
   8: std::panicking::begin_panic_fmt
   9: tcp_listener::util::expect_events
             at tests/util/mod.rs:158
  10: tcp_listener::smoke_test_tcp_listener
             at tests/tcp_listener.rs:68
  11: tcp_listener::tcp_listener_ipv6
             at tests/tcp_listener.rs:35
  12: tcp_listener::tcp_listener_ipv6::{{closure}}
             at tests/tcp_listener.rs:34
  13: core::ops::function::FnOnce::call_once
             at /builddir/build/BUILD/rustc-1.43.0-src/src/libcore/ops/function.rs:232
  14: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
  15: __rust_try
  16: __rust_maybe_catch_panic
  17: test::run_test::run_test_inner::{{closure}}
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
failures:
    no_events_after_deregister
    tcp_listener_ipv6

Both tests fail (I think) on the same issue: connection to the listener in start_connections. Maybe the thread that gets started never gets a chance to run?
Could you try running using only a single test thread:
RUST_BACKTRACE=full cargo test --all-features -- --test-threads=1

@elmarco @ignatenkobrain any update on this?

Closing due to inactivity.


Control header start page for article doctype

It is not currently possible to configure the starting page position of running content for the article doctype.
As of #945 it is possible to specify the position of the running content (headers and footers) in the document using a theme file, e.g.:
running_content:
  start_at: toc

This is a great improvement. However, it only applies to the book doctype -- setting the start_at variable has no effect for article doctypes (unless they have a title page set).
This is because the value of start_at is explicitly only read from the theme file if a title page is set. Otherwise, both header and footer are hardcoded to start on the first page of the document.
Nevertheless, it would be ideal to be able to configure this for all article types, including articles without title pages. An example of a situation where this would be needed is regular articles where the running header contains the title and/or author name. Currently this results in roughly the following PDF output:
[HEADER] TITLE

[H1] TITLE

Article text

The duplicate title at the top of the page looks quite odd, and for this reason is usually omitted on the first page of articles. The exception of course as reported in #606 is for articles where organizational or other information is required to be printed on each page, including the title.
Since I had the opposite requirement (i.e., the appearance of the header on the first page of the article was not acceptable), I patched Line 249 of converter.rb to the following:
num_front_matter_pages =<EMAIL_ADDRESS>body_start_page_number - 1]

This allows for the start page to be specified by setting start_at to any desired position in the theme file and works quite well for my use case (since I don't ever have the need to print a header on the first page of articles).
However, for this to be more generally useful, it would need to address a few other factors:

Only read from the theme file if the start_at variable has been specified
Default to current behaviour if the above variable is not set
Allow for the footer position to be specified separately (e.g., when numbering in the footer is still needed even when there is no header)

I think it should be fairly straightforward to accommodate the first two of these using something like the following starting on Line 248:
      elsif @theme.page_numbering_start_at
        num_front_matter_pages =<EMAIL_ADDRESS>body_start_page_number - 1]
      else
        num_front_matter_pages = [body_start_page_number - 1] * 2
      end

This would preserve the current default behaviour, but make it optionally configurable using a theme file, as is already possible for the book doctype. EDIT: I'm not sure how to separate the footer configuration though.
From reading through the other issues, it seems a possible stumbling block might be the unpredictable effect of starting page numbering on arbitrary pages, [EDIT] though from a few tests this seems to have been solved already. In any case, it would be great to have this additional flexibility of being able to control the appearance of the header and footer without having to re-patch the gem source on each update.

This is a duplicate of #1455. To start the running content after the first page, set the running_content_start_at to the value 2 (instead of the default 1). To start the page numbering after the first page, set the page_numbering_start_at to the value 2 (instead of the default 1).


support serialization of identity gate by converting it to phasedXZ

fixes https://github.com/quantumlib/Cirq/issues/4833

We discussed adding a separate identity gate in the prior discuss on this (see https://github.com/quantumlib/Cirq/issues/4833#issuecomment-1050377165). Any reason not to do that? I think the goal of serialization has been to preserve circuits as much as possible, rather than converting to "equivalent" gates, but we haven't made a firm commitment to that goal.

superseded by https://github.com/quantumlib/Cirq/pull/6479


HTTP Error 500

Hi!
I have tried to use MS2Decide on my own data (btw congratulations on the preprint - exciting idea!), but encountered an issue I wasn´t able to fix (unfortunately, I am not an expert in coding ...). Perhaps you can help me:
C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\site-packages\urllib3\connectionpool.py:1099: InsecureRequestWarning: Unverified HTTPS request is being made to host 'gnps.ucsd.edu'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings
warnings.warn(
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\site-packages\ms2decide\K_estimation.py", line 81, in K_estimation
gnps_res = closest_gnps_by_id(task_id, mgf_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\site-packages\ms2decide\ClosestGNPS.py", line 389, in closest_gnps_by_id
df_anno = _gnps_annotations_download_results(job_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\site-packages\ms2decide\ClosestGNPS.py", line 261, in _gnps_annotations_download_results
with urllib.request.urlopen(gnps_download_link.format(task_id)) as url:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\urllib\request.py", line 215, in urlopen
return opener.open(url, data, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\urllib\request.py", line 521, in open
response = meth(req, response)
^^^^^^^^^^^^^^^^^^^
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\urllib\request.py", line 630, in http_response
response = self.parent.error(
^^^^^^^^^^^^^^^^^^
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\urllib\request.py", line 559, in error
return self._call_chain(*args)
^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\urllib\request.py", line 492, in _call_chain
result = func(*args)
^^^^^^^^^^^
File "C:\Users\c7401401\AppData\Local\anaconda3\envs\ms2decide_env\Lib\urllib\request.py", line 639, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 500: Internal Server Error
-> I tried it with both, the test data and also my own - with the FBMN workflow on GNPS being successful. But the workflow always returns this error message.
Thank you very much in advance for your help!
Best regards from Innsbruck,
Fabian

Dear Fabian
Thank you for your email. Which OS are you using on your computer ? Which library search have you used strict or iterative ?

Thank you for your response. I am using Windows 11 and I have tried both options for the library search strict and iterative - both yield the same error message.
Best regards, Fabian

Dear Fabian. Thank you for your answer.
Could you please send me your files (mgf, csv, sirius identifications.tsv) on<EMAIL_ADDRESS>Best,
Mehdi


Fr translation for Docs v2

Hi Remi!
This is an attempt to translate the new doc (v2) into french.  This commit contains the 'why_immutability'

Another PR that was opened before seem to have added why_immutability too + other docs. This probably isn't needed anymore, right?

Yup, seems like it. I didn't see the other request

No problem. Thanks for your work anyway! Better luck next time :)


Error on inline code elements

Hi! I'm experimenting with ox-json with the intention of exporting my Org documents for processing with external tools. Your package is very promising. Thanks you for the effort you put into it. Unfortunately I ran into a problem.
With this minimal Org document:
Content with ~inline code~.

I'm getting this JSON in place of the inline code:
{
  "$$data_type": "org-node",
  "type": "code",
  "ref": "org0874718",
  "properties": {
    "standard-properties": null,
    "value": {
      "$$data_type": "error",
      "message": "Expected string or symbol, got [org-element-deferred org-element--substring (1 12) nil]"
    }
  },
  "contents": []
}

I'm using Doom Emacs.
GNU Emacs     v29.1            nil
Doom core     v3.0.0-pre       HEAD -> master 986398504 2023-10-07 02:33:45 +0200
Doom modules  v23.09.0-pre     HEAD -> master 986398504 2023-10-07 02:33:45 +0200

Below is the whole pretty printed JSON document.
{
  "$$data_type": "org-document",
  "properties": {
    "title": [],
    "filetags": [],
    "author": [
      "Tad Lispy"
    ],
    "creator": "Emacs 29.1 (Org mode 9.7)",
    "date": [],
    "description": [],
    "email": "***@***",
    "language": "en"
  },
  "contents": [
    {
      "$$data_type": "org-node",
      "type": "section",
      "ref": "org3bf75fb",
      "properties": {
        "standard-properties": null
      },
      "contents": [
        {
          "$$data_type": "org-node",
          "type": "paragraph",
          "ref": "org5e029c1",
          "properties": {
            "standard-properties": null
          },
          "contents": [
            "Content with ",
            {
              "$$data_type": "org-node",
              "type": "code",
              "ref": "org0874718",
              "properties": {
                "standard-properties": null,
                "value": {
                  "$$data_type": "error",
                  "message": "Expected string or symbol, got [org-element-deferred org-element--substring (1 12) nil]"
                }
              },
              "contents": []
            },
            ".\n"
          ]
        }
      ]
    }
  ]
}

Hi @tad-lispy, thanks for your interest in this package. Unfortunately at this point I do not have any plans to develop or maintain it further. I ultimately decided that org mode and Emacs are too much trouble and have switched to Obsidian for all my note taking needs.

Ok. Thanks for the heads up. It is quite a lot of hassle sometimes. I guess someone else or I will have to fork it and take it from where you left off.
Somewhat funny, I was in the middle of writing my update when I saw your response, so I hope you don't mind me leaving it here for future reference.

Looks like the problem is related to the breaking changes introduced in Org Mode 9.7, which although not released yet, somehow found it's way into my Emacs.
Org mode version 9.7 (9.7-??-e90a8a69a @ /home/tad/.config/emacs/.local/straight/build-29.1/org/)

The changes are described here: https://list.orgmode.org/874jnudps5.fsf@localhost/
The key seems to be getting the data from deferred nodes.

In case anyone else is interested in this, here is my fork adapted to Org 9.7: https://gitlab.com/tad-lispy/ox-json. At the moment it's a hack, but it seems to be working.

Well I got back into this a little just to convert my old library of notes to markdown, ended up taking the time to at least make a proper new release with all the changes since 0.2.0. Now that I've re-familiarized myself with it a bit I'll take a look into this.


barman-cloud-backup fails with "Part number must be an integer between 1 and 1000"

My base backups are failing, and I've tracked it down to this:
{"level":"info","ts":1677975525.336761,"logger":"barman-cloud-backup","msg":"2023-03-05 00:18:45,335 [2472973] ERROR: Upload error: An error occurred (InvalidArgument) when calling the UploadPart operation: Part number must be an integer between 1 and 1000, inclusive (worker 0)","pipe":"stderr","logging_pod":"pool1-cnpg-1"}
{"level":"info","ts":1677975525.64154,"logger":"barman-cloud-backup","msg":"2023-03-05 00:18:45,639 [2472161] ERROR: Error received from upload worker: An error occurred (InvalidArgument) when calling the UploadPart operation: Part number must be an integer between 1 and 1000, inclusive","pipe":"stderr","logging_pod":"pool1-cnpg-1"}

Related to https://github.com/EnterpriseDB/barman/issues/284
I'm using Scaleway object storage, which apparently only supports up to 1000 parts. Therefore, this error appears after exceeding 20GB.
A solution could be to add a configuration option for the barman --max-archive-size flag (as far as I can tell it's not available in CNPG at the moment).

I'm closing this since it's a bug in Barman and not in CloudNativePG, when it's fixed there it will be fixed in the new operand image


[chore] run go fmt

Some formatting was off
Change management
type=routine
risk=low
impact=sev5

wow this is a great diff...
it's replaced spaces with tabs

This Pull Request was merged without enough reviews
Please go here to review and +1

@grahamjenson ?^ :(


Asking for Experiments Results

Hi all,
It's great to know this project and the github instructions are in great detailed.
We are working on research and trying to replicate their results; however, the experiments take forever for us to get the result.
I'm wondering could you kindly share the CSV files rollup.csv and rollup_mcpat.csvwith us so that we can start to analyze the results.
It's will be really helpful if you can sent those files to my email<EMAIL_ADDRESS>or whatever way you feel comfortable.
Thank you.

The excel file provided in the experiment directory (https://github.com/CMU-SAFARI/Hermes/blob/main/experiments/MICRO22_AE.xlsx) contains all the stats from our runs. You can use it for replicating the results. I’ll update it with the power stats soon.

@YangHangWu The power number is now added to the MICRO22_AE.xlsx file.
Closing this issue for now. We can reopen it if required.


Make Class Diagrams usable in Stackedit and Live Editor

This PR resolves all tasks in #748 and therefore also #609.

Pull Request Test Coverage Report for Build 692

27 of 30 (90.0%)  changed or added relevant lines in 3 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 54.326%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/diagrams/class/classRenderer.js
0
1
0.0%

src/diagrams/class/parser/classDiagram.js
18
20
90.0%

Files with Coverage Reduction
New Missed Lines
%

src/diagrams/class/parser/classDiagram.js
3
56.63%

Totals

Change from base Build 671:
0.04%

Covered Lines:
2057

Relevant Lines:
3761

💛  - Coveralls

Thx! Would be nice to get further with the class diagrams.

Is this supposed to work in StackEdit? It's not working for me.

@rafaelbenavent it does not work in StackEdit yet.
At first mermaid has to release a new Version to npm including this fix.
Then Stackedit has to upgrade the mermaid dependency.
This PR is a prerequisite to make the classDiagrams work in Stackedit, thus the name. (I also tried that out locally with the Stackedit repo.)


Error building DC

Operating System Version: Debian 11.3
Deploying via (VirtualBox/VMWare/AWS/Azure/ESXi): Virtualbox
Vagrant Version (if applicable): 2.2.14

detection@network:~/DetectionLab/Vagrant$` vagrant -v
Vagrant 2.2.14

detection@network:~/DetectionLab/Vagrant$ cat /etc/debian_version
11.3

detection@network:~/DetectionLab$ vagrant plugin list
vagrant-libvirt (0.3.0, system)
vagrant-proxyconf (2.0.10, global)
vagrant-reload (0.0.1, global)
  - Version Constraint: > 0
winrm (2.3.6, global)
winrm-elevated (1.2.3, global)
winrm-fs (1.3.5, global)

detection@network:~/DetectionLab/Vagrant$ vagrant up
Bringing machine 'logger' up with 'virtualbox' provider...
Bringing machine 'dc' up with 'virtualbox' provider...
Bringing machine 'wef' up with 'virtualbox' provider...
Bringing machine 'win10' up with 'virtualbox' provider...
==> logger: Checking if box 'bento/ubuntu-20.04' version '202112.19.0' is up to date...
==> logger: Configuring proxy for Apt...
==> logger: Configuring proxy environment variables...
==> logger: Configuring proxy for Git...
==> logger: Machine already provisioned. Run `vagrant provision` or use the `--provision`
==> logger: flag to force provisioning. Provisioners marked to run always will still run.
==> dc: Checking if box 'detectionlab/win2016' version '1.9' is up to date...
An error occurred executing a remote WinRM command.

Shell: Cmd
Command: hostname
Message: Unable to parse WinRM response: Missing end tag for 'meta' (got 'head')
Line: 145
Position: 3739
Last 80 unconsumed characters:

ERROR

The requested URL (503).

Please close this ticket, the issue Ive had was caused by having set a local proxy (on the host env).
But additionally it seems that vagrant plugin install vagrant-proxyconf does not set the proxy in windows environments.
Ive had to set that manually and do a manual vagrant provision dc to get things provisioned properly

@jo3rg thanks for letting me know you figured it out! In the future, I think you have permission to close your own issues :)


Model of the Unifi 8 switch ?

Hello
For which Unifi switch model is it intended? The old metal model or the new plastic one?
Thank's

Sorry just saw this...
It's for this one:
https://a.co/d/9OiBYGS
ASIN 	B01MU3WUX1
UPC<PHONE_NUMBER>48<PHONE_NUMBER>64<PHONE_NUMBER>84


Extra use case and some lints

Github actions
version 0.4.0

@naomijub Can you turn off the clippy nursery lints please?

@bonsairobo  done

@naomijub Thanks! Hope you find them useful.


Streamline API by removing promises

Is your feature request related to a problem? Please describe.
Returning a promise from a constructor makes the API harder to use, we can remove this layer of abstraction easily.
Describe the solution you'd like
const observable = new Accelerometer(options);
observable.catch(err => {
	// Sensor not available
})

Additional context
This should be a rather small improvement on the JS side of things

should rather have static method to check which are available

Why would you prefer this?

Still gonna do it when there is time :)


Skip docker pull when dealing with local images

It would be nice to have an option to disable 'docker pull' in case we have already dowloaded images or created our own and haven't yet pushed to any kind of private/personal registry.

+1

+1 https://youtrack.jetbrains.com/issue/TW-43003

+1
This would be useful in the event that your private registry goes down as well.  Builds should fail because the latest image can't be pulled.  I should be to use what the system currently has.

How would we tell if an image is local or not?

Related to #6

@jonnyzzz
A docker run command does an implicit pull if the image does exist on the localhost, but it does not update the image in the event that there is a newer one in the remote registry.  Im assuming that the code in the plugin is doing an explicit docker pull command just prior to starting up the image.  I'd like to have the ability to define whether or not we want to do an explicit pull.
To your question above though, would a docker images command suffice to determine if the image is local?

It looks like we need a checkbox in the settings to disable pull. Would you
like to come up with a pull request for that?
In the case of non-local image it's required to pull an image to make sure
we are running on actual image, not a cached one
On Jan 24, 2017 6:50 PM, "Sean Humbarger"<EMAIL_ADDRESS>wrote:
@jonnyzzz https://github.com/jonnyzzz
A docker run command does an implicit pull if the image does exist on the
localhost, but it does not update the image in the event that there is a
newer one in the remote registry. Im assuming that the code in the plugin
is doing an explicit docker pull command just prior to starting up the
image. I'd like to have the ability to define whether or not we want to do
an explicit pull.
To your question above though, would a docker images command suffice to
determine if the image is local?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jonnyzzz/TeamCity.Virtual/issues/24#issuecomment-274881409,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPpr7-vdFtneI4SX8729FjoDFFV--hWks5rVjnugaJpZM4Doq_H
.


The stm32 SPI driver does not work if one tries to send several buffers with a frame size of 16 bits.

Problem description
The stm32 SPI driver's send functions receive a set buffers to be sent one next to the other. If the SPI's transaction's frame size is set to 16 bits and more than one buffer wants to be sent, the data sent is wrong. In particular, some of the data is not sent.
This occurs because:

The SPI spi_buf_set length represents the length of the buffer in units of
frame size.
The function spi_context_get_next_buf calculates the length of the next
buffer wrong, because it assumes that the above parameter is set in bytes.
Thus, it divides this length by dfs, which gives the wrong result.

E.g. let's suppose an SPI transaction with a frame size of 16 bits, sending 3 elements (3 half-words, so 6 bytes). len will be 3, and dfs will be 2. spi_context_get_next_buf will calculate the buffer length as 3/2 = 1 (integer division), which is wrong.
Notice the first buffer in the spi_buf_set is sent correctly because transceive in spi_ll_stm32 does spi_context_buffers_setup(&data->ctx, tx_bufs, rx_bufs, 1);, in other words, it hard-codes dfs to 1 regardless of the transaction frame size.
I'm using a nucleo-h743zi board as target platform.
How to reproduce
This issue contains an attached file which is a Zephyr application called 'spi-double-buffer' that can be placed in zephyr/samples/basic, then built and run to reproduce the error. It has been tested on a nucleo-h743zi board.
spi-double-buffer.zip
The command to build it would be: west build -p always -b nucleo_h743zi zephyr/samples/basic/spi-double-buffer
Below you can fined a code summary about the above:
struct spi_cs_control csc = {...};

struct spi_config cfg = {
    .frequency = 200000,
    .operation = SPI_OP_MODE_MASTER |
                    SPI_WORD_SET(16) |
                    SPI_TRANSFER_LSB,
    .slave = 0,
    .cs = &csc,
};

s_buf[0] = 0xaaaaaaaa;
s_buf[1] = 0x55555555;
struct spi_buf tx_buf[2] = {
    {.buf = s_buf, .len = 2},
    {.buf = &s_buf[1], .len = 2},
};
struct spi_buf_set tx_bufs = { .buffers = tx_buf, .count = 2 };

int rc = spi_write(spi1, &cfg, &tx_bufs);
rc = spi_write(spi1, &cfg, &tx_bufs);
return rc;

A capture of a logic analyzer is shown below

As you can see, the data above is wrong. It should send 64 bits in each transaction, but it sends 48 (as expected, as the second buffer's length is divided by 2 due to the problem mentioned above)
Proposed change
Avoid dividing the buffer length by dfs in spi_context_get_next_buf

The SPI spi_buf_set length represents the length of the buffer in units of
frame size.

This is incorrect. The length is specified in bytes.

Notice the first buffer in the spi_buf_set is sent correctly because transceive in spi_ll_stm32 does spi_context_buffers_setup(&data->ctx, tx_bufs, rx_bufs, 1);, in other words, it hard-codes dfs to 1 regardless of the transaction frame size.

And that seems to be the actual problem. spi_context_buffers_setup() should be called with the correct dfs value and in your test application you should use:
struct spi_buf tx_buf[2] = {
    {.buf = s_buf, .len = sizeof(s_buf[0])},
    {.buf = &s_buf[1], .len = sizeof(s_buf[1])},
};

Then the output should be as expected (i.e. 64 bits sent).

This is incorrect. The length is specified in bytes.

I see. I imagine that means that using frame sizes smaller than 1 bytes is not supported. I will update my PR to fix the actual problem. I suggest to add to this comment: @param len is the length of the buffer or,[...] that the length must be specified in bytes.


Task2

Math operations

SourceCode/2024/May 2024/Bhavya/Task2/project.json
Main.xaml
Activity Assign has a default name: Add a more descriptive title to make it easier to understand what the activity does.
Activity Input Dialog has a default name: Add a more descriptive title to make it easier to understand what the activity does.
Activity Message Box has a default name: Add a more descriptive title to make it easier to understand what the activity does.

Please avoid duplicate names. Code contains 2 occurrences of "Input Dialog display name".

Score: 4/5
Dependency packages
Dependency package UiPath.Excel.Activities is not used: Remove unused packages to improve process execution time.
Dependency package UiPath.Mail.Activities is not used: Remove unused packages to improve process execution time.
Dependency package UiPath.Testing.Activities is not used: Remove unused packages to improve process execution time.
Dependency package UiPath.UIAutomation.Activities is not used: Remove unused packages to improve process execution time.

Please remove unused dependencies to optimize the process.

Score: 4/5
NoFile
NoFile: Your organization requires your project to have an Automation Hub URL defined. Use Project Settings to add the missing information.

SourceCode/2024/May 2024/Bhavya/Task2/project.json
Here are the code review comments:
Login.xaml

The Click event handler for the "Login" button can be simplified by removing the unnecessary If statement and directly navigating to the next page.
Make sure to handle potential exceptions when interacting with the UI elements.

Main.xaml

There's a lot of repetition in the For Each loop. Consider using a more functional approach, such as LINQ, to simplify the logic.
The If statement checking for an empty string can be replaced with a null-coalescing operator (??) for better readability.

Report.xaml

The report generation process seems to be quite complex. Have you considered breaking it down into smaller, more manageable steps?
The Try Catch block is catching all types of exceptions. Consider making the catch more specific to handle only expected errors.

Workflow.xaml

The workflow logic appears to be tightly coupled with the UI. Consider moving the business logic to a separate class or library for better maintainability.
There are many unnecessary Wait For statements. Try to minimize delays in your workflow by using more efficient waiting mechanisms, such as async/await.

Score: 4/5
Note: These comments are meant to be constructive and helpful, rather than critical or judgmental. The goal is to provide feedback that will help the developer improve their code quality and maintainability.

SourceCode/2024/May 2024/Bhavya/Task2/project.json
activity1.xaml

The Set Excel File Path activity is using a hard-coded path. Consider using a more dynamic approach by passing the file path as an argument or using environment variables.
The Read Range activity has a fixed range, can you make it more flexible by allowing users to input the range?
activity2.xaml
There are no comments in this file. It's good practice to add brief descriptions for each activity and section.
DataGrid.xaml
You're using a deprecated method (GetRows) instead of the recommended one (GetItems). Update your code to use the new method.

Score: 4/5

SourceCode/2024/May 2024/Bhavya/Task3/project.json
dependencies
Dependency package UiPath.Excel.Activities is not used: Remove unused packages in order to improve process execution time.
Dependency package UiPath.Mail.Activities is not used: Remove unused packages in order to improve process execution time.
Dependency package UiPath.UIAutomation.Activities is not used: Remove unused packages in order to improve process execution time.
Main.xaml
Used ToString display name is defined many times. Current allowed threshold is 1. Code contains 5.: Names of activities should give a clear indication of how they are being used. Default names are usually too generic. Please avoid duplicate names.
Log Message not used in workflow Main.: Using Log Message activities is important both during development and after release. They help understanding the flow path which is very useful for maintenance and, when an error occurs, to easily identify the source and the cause.
NoFile
Your organization requires your project to have an Automation Hub URL defined: Use Project Settings to add the missing information.
Score: 4/5

SourceCode/2024/May 2024/Bhavya/Task2/project.json
activity1.xaml

The file name is descriptive and follows the convention "action_verb_object"
No issues found with activity sequencing or handling
Some activities have duplicate names, consider renaming them for clarity
There are no comments explaining what each activity does; add comments to make it easier for others to understand the code

activity2.xaml

The file name is not descriptive and doesn't follow the convention "action_verb_object"
There's a missing If activity with incomplete logic; complete the condition or remove the unnecessary part
Some activities have long names, consider renaming them for brevity
Add comments to explain what each activity does

activity3.xaml

The file name follows the convention "action_verb_object" but could be more descriptive
There's a For Each loop with no limit set; add a limit or check if the collection is empty before iterating
Some activities have unnecessary delays; consider using a better approach for handling timeouts

activity4.xaml

The file name follows the convention "action_verb_object" but could be more descriptive
There's an If activity with multiple conditions; consider combining them into a single condition or breaking it down further
Add comments to explain what each activity does

score: 4/5
Note: I've kept the scoring at 4/5 as some of the suggestions are minor improvements and don't affect the functionality of the code.

SourceCode/2024/May 2024/Bhavya/Task3/project.json
Main.xaml

Log Message not used in workflow Main: Using Log Message activities is important both during development and after release. They help understanding the flow path which is very useful for maintenance and, when an error occurs, to easily identify the source and the cause.
Recommendation: Add meaningful log messages throughout the workflow to better understand its execution.

Score: 5/5
Note: This review focuses on providing actionable suggestions that are easy to understand. It avoids introducing unnecessary jargon or technical terms.

SourceCode/2024/May 2024/Bhavya/Task4/project.json
main.xaml: Log Message not used in workflow
The log message activities are important for understanding the flow path during development and identifying errors after release. It's recommended to add log messages throughout the workflow.
Activity If has a default name:
Consider giving the activity a more descriptive title to make it easier to understand what the activity does.
NoFile: Your organization requires your project to have an Automation Hub URL defined.
Use Project Settings to add the missing Automation Hub URL definition.
Dependency packages:
The following dependency packages are not used in this workflow:
* UiPath.Excel.Activities
* UiPath.Mail.Activities
* UiPath.Testing.Activities
* UiPath.UIAutomation.Activities
Remove unused dependencies to improve process execution time.
Activity If has a default name:
Consider giving the activity a more descriptive title to make it easier to understand what the activity does.
Activity Message Box has a default name:
Consider giving the activity a more descriptive title to make it easier to understand what the activity does.
Score: 5/5

SourceCode/2024/May 2024/Bhavya/Task2/project.json
Activity.cs

The code seems fine for the most part.
There are some empty lines between functions which can be removed to make the code more concise.

BusinessLogic.cs

The code logic looks good, but there's a lot of repeated code. Can you consider extracting common functionality into separate methods or classes?

DataAccess.cs

You're using a loop to iterate over a list and then perform some action on each item. This can be simplified by using the ForEach method.

Main.xaml

The xaml file seems fine, but there's an unused variable (emailBody) which can be removed.

Utility.cs

There are some magic numbers used in this file. Can you replace these with named constants or enums to make the code more readable?

Score: 4/5

SourceCode/2024/May 2024/Bhavya/Task3/project.json
Main.xaml
Your Log Message activity is not being utilized in the workflow Main. It's crucial to use these messages during development and after release, as they help understand the flow path, making maintenance easier and error identification more straightforward.
Score: 5/5
Dependency packages
The following dependency packages are not used:

UiPath.Excel.Activities
UiPath.Mail.Activities
UiPath.UIAutomation.Activities

Consider removing unused packages to improve process execution time. This will help your workflow run more efficiently and reduce unnecessary dependencies.
Score: 4/5
ToString display name
The code contains multiple instances of using ToString display names, exceeding the allowed threshold of 1. It's essential to avoid duplicate names and provide a clear indication of how activities are being used.
Score: 3/5

SourceCode/2024/May 2024/Bhavya/Task4/project.json
Main.xaml
Log Message not used in workflow Main.
This is important for both development and release phases. Log Messages help understand the flow path, making maintenance and error troubleshooting easier.
No issues found
Score: 5/5

SourceCode/2024/May 2024/Bhavya/Task2/project.json
Workflow.xaml

The DoWork activity has a high number of iterations (100). Consider optimizing the loop or breaking it down into smaller chunks for better performance.
The Read CSV activity uses the default file path, which might lead to issues when running the workflow on different machines. Consider using environment variables or hardcoding the file path.

Activities.xaml

There are unused activities (UiPath.Mail.SendEmail, UiPath.Testing.RunTest) that can be removed to improve process execution time.
The UiPath.UIAutomation.ClickElement activity uses a hardcoded XPath expression. Consider parameterizing it for better flexibility and reusability.

Score: 4/5
Note: I've focused on providing actionable feedback for the developer, without introducing unnecessary corporate jargon or technical terms. I'll ensure to keep my responses concise and easy to understand throughout this conversation.

SourceCode/2024/May 2024/Bhavya/Task3/project.json
Here's the review:
Main.xaml
Your log messages in the workflow "Main" are not being used, which makes it harder to understand and debug your process later on. Make sure to use them during development and after release.
Score: 4/5
Unused packages
You have three unused dependency packages: UiPath.Excel.Activities, UiPath.Mail.Activities, and UiPath.UIAutomation.Activities. Remove these unused packages to improve the execution time of your process.
Score: 4/5
Used ToString display name
The same display name is being used multiple times in your activities. This can make it hard to understand what each activity does. Please rename them to give a clear indication of how they're being used and avoid duplicate names.
Score: 4/5
Overall Score: 12/15

SourceCode/2024/May 2024/Bhavya/Task4/project.json
Main.xaml
The Log Message activities are not used in the workflow "Main.". This can make it difficult to understand the flow path and debug any issues that may arise.
Solution: Use Log Message activities throughout the workflow to provide meaningful information about what's happening during execution. This will help with development, maintenance, and debugging.
Score: 5/5
Dependency packages
The following dependency packages are not used in this project:

UiPath.Excel.Activities
UiPath.Mail.Activities
UiPath.Testing.Activities
UiPath.UIAutomation.Activities

Solution: Remove unused packages to improve process execution time and reduce the overall size of the project.
Score: 5/5

@Bhavyajetty2
Task – 2
Code verified.
Task – 3
Code verified.
Task – 4
Code verified.


No option to disable selection

Is there any way to disable highlighting/selection of certain elements when selecting with a mouse cursor? On a surface level it seems like the options object argument for the text method has no such property and neither do vectors nor images. It would be nice to be able to specify this, especially for images and vector graphics so that it's possible to only select and highlight text without grabbing other non-text elements when copying/pasting something from a document is likely. I've had personal poor UX trying to copy/paste text because it selects nearby vector graphics or say, rectangles that frame the text. Any current workaround for this?

None that i know

Any update on this? Would really help with my project right now


Updates for v3.25.0

Description

Updates for v3.25.0
Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@huoqifeng I believe @mgleung had trouble getting s390x to build properly for the release. He can explain in more detail what issues he was encountering.

@huoqifeng there were some build issues with s390x for the apiserver so I ended up removing that build for v3.25.0 so it would not block the release. You can see the exact issues in the test run for https://github.com/projectcalico/go-build/pull/413 .
On an unrelated note, it looks like our script did not pick up your changes for a release note since a release note was not provided. We can definitely fix that with v3.25.1, but we'll also need to figure out the containerized build issues for s390x.

Yeah, I'll be looking at https://github.com/projectcalico/go-build/pull/413


Sharing extensions

This PR defines only Protobuf types. Construction and validation of corresponding Java objects would be done in a separate PR.

Current coverage is 80.39% (diff: 100%)

Merging #204 into master will decrease coverage by 0.03%

@@             master       #204   diff @@
==========================================
  Files           147        147
  Lines          5406       5406
  Methods           0          0
  Messages          0          0
  Branches        595        595
==========================================
- Hits           4348       4346     -2
- Misses          949        950     +1
- Partials        109        110     +1

Powered by Codecov. Last update f90e517...03c7708


Forced to include "Sprites.png" in assets

This is just annoying. I guess the content workflow is just janky in general!

Fixed! There are now just 5 things required lol


bash: line 41: warning: here-document at line 1 delimited by end-of-file (wanted `password')

Hi guys,
I am running into this error message in both Windows and ubuntu
2023-11-24 12:27:04 bash: line 41: warning: here-document at line 1 delimited by end-of-file (wanted password') 2023-11-24 12:27:04 bash: -c: line 42: syntax error: unexpected end of file 2023-11-24 12:27:28 bash: line 41: warning: here-document at line 1 delimited by end-of-file (wanted password')
2023-11-24 12:27:28 bash: -c: line 42: syntax error: unexpected end of file
I Did not make any changes to the yaml file

I forgot to remove the <<>> from the .env


Jittery bounce when scrolling in Chrome on iOS

Debug info
Version: 1.0.2
Motion: false
Supports WebGL: true
Feature Phone: no
Standalone Mode: no
Screen Width: 320px
Screen Height: 452px
DPR: 2
Device Memory:
Concurrency:
UA: Mozilla/5.0 (iPhone; CPU iPhone OS 11_3 like Mac OS X) AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/73.0.3683.68 Mobile/15E148 Safari/604.1

Describe the bug
Opening the web app and scrolling causes a 10-20 second long jittery bounce effect that gradually slows down.
It also seems the bottom of the page, where the About button is,
loses its position in the blue area as a result, and once lost in the black overflow it appears the button does not work.

Hi @Krinkle - thanks for the report.
I'm looking at the app v1.0.3 and on my iPhone and can not reproduce the bug. Could you check if the bug still exists on 1.0.3?

Aye, it still happens I'm afraid. Same as before.
Version: 1.0.3
Motion: false
Supports WebGL: true
Feature Phone: no
Standalone Mode: no
Screen Width: 320px
Screen Height: 451px
DPR: 2
Device Memory:
Concurrency:
UA: Mozilla/5.0 (iPhone; CPU iPhone OS 11_3 like Mac OS X) AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/73.0.3683.68 Mobile/15E148 Safari/604.1

It works fine in Mobile Safari and Firefox Focus, but in Chrome for iOS, dragging upwards from anywhere on the screen (to scroll down) results in this jittery chain reaction.
Note that it happens without a screen recording active as well (in case the reduced screen height during recording was a concern). I suspect it might have something to do with the pull-to-refresh behaviour that Chrome has, which makes touch and scroll gestures quite hard to get right in this browser. I don't remember the specifics, though.


Update Virtualbox to 5.1.20-114629 - remove outdated versions

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Updated to 5.1.20-114629
Remove lion and mountain lion support.
#32560

Sorry @vitorgalvao, I updated this just as you approved it. Oracle bumped the version to 114629.


Ratings broken!

Thanks for lib :)
Just trying to implement it using floating values for 5 star rating component. Doesnt seem to work. It weird that for 5 it somehow is taking as 0.5 or less (if you look closely)
<Rating
                  className="flex"
                  ratingValue={5}
                  readonly
                  transition
                  size={20}
                  allowHalfIcon
                  fillColorArray={[
                    "#f17a45",
                    "#f19745",
                    "#f1a545",
                    "#f1b345",
                    "#f1d045",
                  ]}
                />

Not sure, what I am doing wrong

Check this codesandbox it may help you . Also, please update to the latest version to avoid any possible bugs.
Let me know if still you need any help.
Thank you.


convert html to flat text for LHN uses

@parasharrajat @Luke9389  will you please review this?
[Explanation of the change or anything fishy that is going on]
I'm adding a new function to replace the HTML report message that use for showing text on LHN.
Fixed Issues
$ https://github.com/Expensify/App/issues/8134
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
__tests__/ExpensiMark-FlatText-test.js
What tests did you perform that validates your changed worked?

> Confusing stuff
Tell me about it

Type above text and should be converted to text Confusing stuff Tell me about it
QA

What does QA need to do to validate your changes?
Verify that __tests__/ExpensiMark-FlatText-test.js is pass.
What areas to they need to test for regressions?
The function created is used on showing the converted html last message on LHN.

I have read the CLA Document and I hereby sign the CLA

recheck

Any things I should update here?

cc: @Luke9389

This PR caused a bug https://github.com/Expensify/App/issues/17658. The html to text function should have also unescaped html entities e.g. < to <.


Hdfs file transfer

This now works
into('hdfs://...', 'myfile.csv')

It uses the create_file or append_file methods of the webhdfs client.
Question - I currently dump the entire data of the file into the call.  Is this a terrible idea?  Should I partition first?
@danielfrg @quasiben

Sending a GB file in 4k chunks sounds unpleasant

It does sound unpleasant, i dont remember where i saw that.
I found this, a little bit dated but should give and idea: http://randomlydistributed.blogspot.com/2012/01/webhdfs-performance.html
So apparently ssh/scp and then hadoop fs is not that good
I'll try this latter and see how it works without chunks.

Wow.  Those numbers are surprising.
OK, WebHDFS it is.

I'll try this latter and see how it works without chunks.

I'll be interested in those results.

Hive tests have recently started failing for me.  Has anything changed on the cluster?

Yeah -- i've been futzing with it.  I'll try and set it back to a working state

No rush.  There are other things I can work on.

Plus this made me improve my tests

ok -- should be working now

Actually, may be better to test again this cluster: http://<IP_ADDRESS>

Couple of things:
I got this warning while importing into: from into import into
/Users/drodriguez/anaconda/envs/conda-cluster/lib/python2.7/site-packages/multipledispatch/dispatcher.py:23: AmbiguityWarning:
Ambiguities exist in dispatched function append

The following signatures may result in ambiguous behavior:
	[HDFS(JSON), JSON], [JSON, SSH(JSON)]
	[HDFS(JSONLines), JSONLines], [JSONLines, SSH(JSONLines)]
	[HDFS(CSV), CSV], [CSV, SSH(CSV)]

Consider making the following additions:

@dispatch(HDFS(JSON), SSH(JSON))
def append(...)

@dispatch(HDFS(JSONLines), SSH(JSONLines))
def append(...)

@dispatch(HDFS(CSV), SSH(CSV))
def append(...)
  warn(warning_text(dispatcher.name, ambiguities), AmbiguityWarning)

I had to rename the files to have csv extension but the files are text files, the upload worked fine though
I had to do: into('hdfs://hdfs@<IP_ADDRESS>:50070:/user/hdfs/100Mb.csv', '/Users/drodriguez/Downloads/100Mb.csv') instead of into('hdfs://hdfs@<IP_ADDRESS>:50070:/user/hdfs/100Mb.txt', '/Users/drodriguez/Downloads/100Mb.txt')

You can safely ignore the warnings for now.  They do bring up a good point though.  How should we handle loading HDFS(.) <- SSH(.)?
Extending the fancy uri syntax to textfiles should be easy.
Very glad to know that we can load moderately large files without being clever about it.

Something else i just noticed is that if i run the command twice:
into('hdfs://hdfs@<IP_ADDRESS>:50070:/user/hdfs/100Mb.csv', '/Users/drodriguez/Downloads/100MB.csv')
into('hdfs://hdfs@<IP_ADDRESS>:50070:/user/hdfs/100Mb.csv', '/Users/drodriguez/Downloads/100MB.csv')

It will append the content so the file in HDFS will be of 200 MB, i am not sure if that is expected behavior.

Some (simple) stats I got uploading from my laptop (ATX office) to the cluster (EC2).
100 MB file
%%timeit -n1 -r1
into('hdfs://hdfs@<IP_ADDRESS>:50070:/user/hdfs/100MB.csv', '/Users/drodriguez/Downloads/100MB.csv')

1 loops, best of 1: 2min 48s per loop

Memory measured by the OS X activity monitor was around 436 MB while uploading
1 GB
%%timeit -n1 -r1
into('hdfs://hdfs@<IP_ADDRESS>:50070:/user/hdfs/1GB.csv', '/Users/drodriguez/Downloads/1GB.csv')

1 loops, best of 1: 28min 58s per loop

Memory usage i saw in the activity monitor: 5.64 GB for a while then 3.78 GB until it finished.
For me the times are not really surprising, specially 1GB taking ~10 times 100MB.
Memory I am guessing is because it loads the whole file into memory, so there is something to improve there.
In any case it worked fine!

OK, I'm partitioning into sets of 100k lines.  Is this too much?
@quasiben HDFS complained when I sent in bytes.  I suspect even breaking on lines is pretty fundamental to how HDFS partitions data.

100k sounds good to me

In regards to repeated calls to into causing appends
into('hdfs://hdfs@<IP_ADDRESS>:50070:/user/hdfs/100Mb.csv', '/Users/drodriguez/Downloads/100MB.csv')
into('hdfs://hdfs@<IP_ADDRESS>:50070:/user/hdfs/100Mb.csv', '/Users/drodriguez/Downloads/100MB.csv')

Yes, this was intended.  This ends up being useful when you want to put a lot of things into one thing (like many CSV files into one database table).
We should probably make this more obvious in documentation.

Is there reason to implement things like the following?
HDFS(CSV) <--> SSH(CSV)

And if so, how?

The ambiguity warnings you saw before should now be gone.

OK, this is passing.  However I had to skip a couple of python3 tests with Temp(SSH(CSV)) that fail intermittently (but seem totally fine when run locally)


Export picture error

When a mind map exports a picture, image. PHP outputs the error message Error call PhantomJS, return code 1. How to do this?

Hi @tk-zc, thanks for the bugreport.
The My Mind app itself is not able to export images, so we were using a hack here: in order to export an image, we simply called a remote server service to do a screenshot of the map inside of an invisible headless browser (running on said server).
The server we used is apparently no longer working. This is not a fault of the My Mind app itself and cannot be really fixed by pushing code changes. We need to find another hosted server service that could do these screenshots for us.

Hi @tk-zc, thanks for the bugreport.
The My Mind app itself is not able to export images, so we were using a hack here: in order to export an image, we simply called a remote server service to do a screenshot of the map inside of an invisible headless browser (running on said server).
The server we used is apparently no longer working. This is not a fault of the My Mind app itself and cannot be really fixed by pushing code changes. We need to find another hosted server service that could do these screenshots for us.

Hi @ondras ,Now that the problem of exporting pictures has been solved, I can run phantomjs phantomjs-my-mind.js URL output.png from the local command line to export pictures. Thank you very much for your help.
eg: phantomjs phantomjs-my-mind.js http://<IP_ADDRESS>/tools/my-mind-master/index.html?Url=http%3A%2F%2F<IP_ADDRESS>%2Ftools%2Fmy-mind-master%2Fexamples%2FGoldfish.my output.png

Might be relevant: https://github.com/ondras/my-mind/wiki/Saving-images-client-side

Exporting images should work once again! See #134 for more info.


Qc-meg

Updating qc to more basic version. Running the code needs to be discussed still as diffrent than MEG team!

Hi @Urszula11 , you've asked @oscfer88 to review this. Are you specifically waiting for him to check / add something or is this ready to merge already? Thanks.

@pravsripad Yes, I am waiting for him to ensure my part is compatible with the rest of MEEG code

@Urszula11 @pravsripad Sorry, I missed this.
Is there anything specific that you want me to check, @Urszula11 ?

@oscfer88 I meant only the QC code

Hi @oscfer88 @Urszula11 , please check this out to see if we can merge and close the changes here.


Update install docs for .NET 9

Summary
Some stuff is unchanged as I'll need to capture screenshots and hashes for download files after they're released.
Fixes #43342
Fixes #43341
Fixes #42479

Internal previews
Toggle expand/collapse

📄 File
🔗 Preview link

docs/core/install/how-to-detect-installed-versions.md
How to check that .NET is already installed

docs/core/install/linux-alpine.md
Install .NET on Alpine

docs/core/install/linux-debian.md
Install the .NET SDK or the .NET Runtime on Debian

docs/core/install/linux-fedora.md
docs/core/install/linux-fedora

docs/core/install/linux-opensuse.md
Install the .NET SDK or the .NET Runtime on openSUSE Leap

docs/core/install/linux-rhel.md
Install .NET on RHEL and CentOS Stream

docs/core/install/linux-scripted-manual.md
Install .NET on Linux by using an install script or by extracting binaries

docs/core/install/linux-sles.md
docs/core/install/linux-sles

docs/core/install/linux-snap-runtime.md
Install .NET Runtime with Snap

docs/core/install/linux-snap-sdk.md
Install .NET SDK on Linux with Snap

docs/core/install/linux-ubuntu-install.md
Install .NET SDK or .NET Runtime on Ubuntu

docs/core/install/linux-ubuntu.md
Get OS version info which adds the $ID and $VERSION_ID variables

docs/core/install/localized-intellisense.md
docs/core/install/localized-intellisense

docs/core/install/macos-notarization-issues.md
macOS Catalina Notarization and the impact on .NET downloads and projects

docs/core/install/macos.md
Install .NET on macOS

docs/core/install/remove-runtime-sdk-versions.md
Remove the .NET runtime and SDK

docs/core/install/templates.md
Manage .NET project and item templates

docs/core/install/upgrade.md
docs/core/install/upgrade

docs/core/install/windows.md
Install .NET on Windows

Thank you for updating the RHEL install instructions too!

No problem @omajid I try to keep it all up to date regardless. So if something is wrong, please let me know and I'll get working on it.

Everything is good, as far as I can tell! Thanks again!


Document Ruby gem 3.0 changes, add upgrade guide

Update docs to mention changes in the Ruby 3.0 gem.
Add an upgrade guide to help users guide them through the upgrade. The
most important step though is probably upgrading to the latest 2.x
series gem as that prints and logs warnings for all the things that may
break in Ruby gem 3.0.
Closes #418

This PR is a basis for the upgrade guide, and we may add more instructions and information to it if we make any other changes. I'd like to know if everyone is okay with this guide so far.


Copy "toString" functions from old repository

Already done for Room

Done for Creeps, RoomPositions and Structures


Investigate possibilities of connection problems monitoring

[ ] Document parts of the browser connections system that can be useful for logging
[ ] Check possibility of running browser heartbeat code in a separate worker for improving heartbeat reliability

Causes of the The {userAgent} browser disconnected problem:

testcafe and hammerhead code problems
not enough memory
unexpected system dialogs (Allow multiple downloads, Choose color, Print and etc.)
absence of system components (some actions require an ICCCM/EWMH-compliant window manager on Linux)

Additionally to the things mentioned by @miherlosev, I think we should also note problems, when a browser is connected, but test execution hangs indefinitely, until TestCafe process is interrupted, e.g. by pressing <Ctrl> + C:

testcafe and hammerhead code problems
network problems (resulting in failed driver requests to server)
infinite redirect

I have used TestCafe in both my current position and in my previous position, and in both cases we face a persistent, unsolvable intermittent issue:  TestCafe fails to receive contact from a BrowserStack browser before TestCafe times out, reporting: "Unable to establish one or more of the specified browser connections. This can be caused by network issues or remote device failure."
For some reason the issue occurs with Firefox on BrowserStack more than other browsers.

@harry7771
Hello,
There are some problems related to connect stability using BrowserStack. This can be caused for many reasons, for example: https://github.com/browserstack/browserstack-local-nodejs/issues/41. We'll think about ways to stabilize the launch of tests and "loss of connection" notifications.

Thanks. I've messed around with increasing/decreasing all of the TestCafe and BrowserStack timeouts that I can with no luck.  I just can't get TestCafe to wait around a half-minute more for BrowserStack to catch up to it.
Thanks for whatever your team is able to do.  I and many others will be anxiously awaiting a fix!

We decided to integrate these ideas into the main list in https://github.com/DevExpress/testcafe/issues/2413


Add installation instructions for FreeBSD

lsd just landed in FreeBSD ports.

Hey, thanks for the PR. But I missed this PR merged https://github.com/Peltoche/lsd/pull/371 in.


adding auto-approve

robots!
https://www.pivotaltracker.com/story/show/172659174

This PR should fix the broken test here: https://github.com/trussworks/legendary-waddle/pull/200

Thanks @cblkwell . Rerunning.


Data sent to Garmin Device

I believe the data being sent to the Garmin Device has changed in the dev branch, which has led to a breakage in what is shown on a garmin device.
Previously one of the properties was "trendRaw" but it used the text description i.e "FortyFiveDown" or "DoubleUp", now it appears that the data sent uses the special characters →, ⇈.  See this link for how its used Link to GarminWatch repo
Another useful property was "glucoseDateInterval" which is similar to "lastLoopDateInterval" which is no longer be sent across. This was useful for when showing the time when the BG value was last updated if looping has been disabled due to something like a manual basal being set.
It would be nice if these 2 properties could be reinstated back if possible.

I don't use the Garmin myself. Please PR, if needed.

What does that mean? If all users want to continue to use the garmin functionality one of us need to fix it?

I've done some hacks to see if they work will test throughout the next few days if it works, I'll refine and create a PR 👍

PR Raised https://github.com/Artificial-Pancreas/iAPS/pull/470