Not working when putting template literals on their own line

When opening the template literals at the same line as the opening

)

to this
const Windows = () => (

    <Taskbar />

);

Anyway, would it be hard to fix this and allow both ways? Because even if i didn't use prettier, the second code is still a valid styled jsx syntax...

@GabrielDuarteM You need to write `} on the same line
const Windows = () => (

    <Taskbar />

+    `}</style>

)

to this
const Windows = () => (

    <Taskbar />

);

Please see this example

@u3u Well, this works and solves my problem, but I still think that this is a workaround to a scenario that the extension does not cover, but should, because it works perfectly with well with styled-jsx...

@GabrielDuarteM
Yes, this is just a solution.
This extension should improve it.

Know that, I'll try to fix it, any merge request is welcome (it's nicer if provide test case).

I know this isn't the most robust and safe method but it works for me. I am not very good at regex so I know it needs improvement but it works whether the {` is on the same line or not.
Begin:
"(?<=

This issue seems to still exist and should be reopened.

This issue seems to still exist and should be reopened.
@atombender Could you show me an example code of this issue?

Screenshot of issue.
vscode-styled-jsx v1.0.0
vscode v1.29.0-insider

I've also got prettier enabled.

I've also got prettier enabled.

I found the cause for the problem in my case. I had this extension enabled for extended JS syntax highlighting. It takes over the javascript mode. Disabling the extension and using the built-in JS syntax works.


ReactWrapper.key returns undefined for empty string keys

Current behavior
  it('asd', () => {
    const foo = [{ a: '' }, { a: '2' }, { a: '3' }];
    const wrapper = mount(
{foo.map(i => )}
);
    expect(wrapper.children().first().key()).toBe('');
  });

results in:

Expected behavior
I expected the test to pass.
Your environment
API

[x] shallow
[x] mount
[x] render

Version

library
version

Enzyme
3.1.0

React
16.2.0

Adapter

[x] enzyme-adapter-react-16
[ ] enzyme-adapter-react-15
[ ] enzyme-adapter-react-15.4
[ ] enzyme-adapter-react-14
[ ] enzyme-adapter-react-13
[ ] enzyme-adapter-react-helper
[ ] others ( )

Does the same thing happen with shallow?
What about with other versions of React?

@ljharb This happens with shallow as well yes. I'm not sure if this happens with other versions of React. This issues popped up in our repo when I did a minor version bump of our prod deps:
Diff
diff --git a/ui/package.json b/ui/package.json
index a47590a10e..9ae4e2b1e9 100644
--- a/ui/package.json
+++ b/ui/package.json
@@ -102,48 +102,48 @@
     "classnames": "^2.1.3",
     "debug": "2.6.9",
     "dom-delegate": "~2.0.3",
-    "domify": "~1.3.1",
+    "domify": "~1.4.0",
     "domready": "^1.0.8",
-    "enzyme-adapter-react-16": "^1.0.1",
+    "enzyme-adapter-react-16": "^1.1.1",
     "escape-html": "~1.0.1",
     "events": "^1.0.2",
     "extend": "^2.0.1",
-    "findandreplacedomtext": "0.4.4",
+    "findandreplacedomtext": "0.4.6",
     "glob": "^5.0.10",
-    "handlebars": "^4.0.6",
-    "hbsfy": "^2.7.0",
+    "handlebars": "^4.0.11",
+    "hbsfy": "^2.8.1",
     "highlight.js": "^9.12.0",
     "humanize": "^0.0.9",
     "immutable": "^3.8.2",
     "inherits": "^2.0.1",
     "is-jpg": "~1.0.0",
     "jsonify": "file:libs/jsonify",
-    "knockout": "3.4.2",
+    "knockout": "3.5.0-beta",
     "lodash": "^4.2.0",
     "minimist": "^1.2.0",
-    "moment": "^2.8.3",
+    "moment": "^2.20.1",
     "mout": "^0.11.0",
     "nlp_compromise": "^1.1.3",
-    "node-sass": "^4.6.0",
+    "node-sass": "^4.7.2",
     "partialify": "^3.1.5",
     "promisify-native": "^1.0.0",
     "prop-types": "15.6.0",
     "quantize": "^1.0.2",
     "quill": "0.19.10",
     "ramda": "^0.25.0",
-    "raven-js": "^3.15.0",
-    "react": "^16",
+    "raven-js": "^3.22.1",
+    "react": "^16.2.0",
     "react-css-transition-replace": "^3.0.2",
-    "react-dom": "^16",
+    "react-dom": "^16.2.0",
     "react-redux": "^5.0.5",
-    "react-test-renderer": "^16",
+    "react-test-renderer": "^16.2.0",
     "react-transition-group": "1.2.1",
-    "react-virtualized": "^9.9.0",
+    "react-virtualized": "^9.18.2",
     "redux": "^3.4.0",
     "redux-immutable": "^3.0.8",
     "redux-logger": "^2.7.0",
     "redux-thunk": "^1.0.3",
-    "request": "^2.36.0",
+    "request": "2.83.0",
     "reselect": "^2.5.4",
     "shaka-player-spotify": "2.1.4-sp.3",
     "slick": "^1.12.2",
@@ -151,10 +151,10 @@
     "spotify-cosmos-api": "^1.7.3",
     "spotify-deferred": "^0.3.0",
     "spotify-eventemitter": "^2.1.0",
-    "spotify-gaia": "^0.6.0",
+    "spotify-gaia": "0.8.0",
     "spotify-liburi": "^4.5.0",
     "spotify-modal": "^1.1.0",
-    "spotify-player": "^2.0.0",
+    "spotify-player": "2.1.2",
     "spotify-simple-navbar": "^1.0.0",
     "spotify-tree": "^1.1.2",
     "teamcity-service-messages": "^0.1.9",

As you can see, React goes from 16.0.0 -> 16.2.0
The React changelog doesn't seem to contain anything that looks related.
I'll try downgrading React to 16.0.0 again and see if that has any effect.

I dug around a bit more. The behavior of empty string key prop changes between:
-    "enzyme-adapter-react-16": "^1.0.1",
+    "enzyme-adapter-react-16": "^1.1.1",

The test described in this issue passes on<EMAIL_ADDRESS>but fails on<EMAIL_ADDRESS>

I think I found the commit.
https://github.com/airbnb/enzyme/commit/8c21e406afb1f958bab19aa66be265eb80d5a28c#diff-359ceaf4dec809e15a7f54fb0e2c2f42
Would you be interested in a PR fixing this issue @ljharb ?

I guess all of those el.key || undefined should be el.key || (el.key === '' ? '' : undefined), though that seems kind of awkward. Should definitely be a helper rather than repeat everywhere.

Seems like a good change; a PR to fix it would be great!

Opened PR https://github.com/airbnb/enzyme/pull/1524 for this issues


Support implicit type conversion from string to boolean

Description
The previous PR https://github.com/opensearch-project/sql/pull/117 was closed because develop branch is being replaced with main. Thus rebase and republish.
Changes

Add missing cast function for byte and short: because after changes, cast function must exist for implicit conversion to the type.
Support implicit conversion from string to bool by wrapping original function builder during compile time. In particular, if there is mismatch between unresolved (user given) and resolved function signature, wrap argument(s) of "mismatched" type by cast function. Please see user manual and design doc below for more details.

Documentation

User manual: https://github.com/dai-chen/sql-1/blob/support-cast-bool-to-string-rebased/docs/user/general/datatypes.rst
Design doc: https://github.com/dai-chen/sql-1/blob/support-cast-bool-to-string-rebased/docs/dev/TypeConversion.md

TODO: Remove special case for conversion between numbers and fix all failed UTs.
Issues Resolved
https://github.com/opensearch-project/sql/issues/113
Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented.

[x] New functionality has javadoc added
[x] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #166 (d8582d1) into main (27e8b3c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #166   +/-   ##
=========================================
  Coverage     99.89%   99.89%
- Complexity     2471     2496   +25
=========================================
  Files           245      245
  Lines          5748     5807   +59
  Branches        333      338    +5
=========================================
+ Hits           5742     5801   +59
  Misses            5        5
  Partials          1        1

Impacted Files
Coverage Δ

...ava/org/opensearch/sql/data/type/ExprCoreType.java
100.00% <100.00%> (ø)

...in/java/org/opensearch/sql/data/type/ExprType.java
100.00% <100.00%> (ø)

...c/main/java/org/opensearch/sql/expression/DSL.java
100.00% <100.00%> (ø)

...h/sql/expression/function/BuiltinFunctionName.java
100.00% <100.00%> (ø)

...expression/function/BuiltinFunctionRepository.java
100.00% <100.00%> (ø)

...arch/sql/expression/function/FunctionResolver.java
100.00% <100.00%> (ø)

.../expression/operator/convert/TypeCastOperator.java
100.00% <100.00%> (ø)

...h/sql/opensearch/data/type/OpenSearchDataType.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e8b3c...d8582d1. Read the comment docs.

Do we have docs list what is the allowed conversion between String -> Bool?

Do we have docs list what is the allowed conversion between String -> Bool?

Will add this to user manual. Thanks!

Do we have docs list what is the allowed conversion between String -> Bool?

Will add this to user manual. Thanks!

Done. Added to user manual: https://github.com/dai-chen/sql-1/blob/support-cast-bool-to-string-rebased/docs/user/general/datatypes.rst#boolean-data-types


Correct the code that pulls the docker envfile

With the change to CNI the loop that pulled the envfile was consuming all of the other nodes... so the loop ended.  This checks that a file is present before calling cat.

@openshift/networking PTAL


refactor: move compile step to first run of server

Fixes #2884 in a less npm-dependent manner than my previous PR.
@dignifiedquire How do you feel about this solution?

Looks like this works, unless the CI jobs cache the static resources between builds. I assume I should squash these commits?

Going to have to modify the server unit tests to handle the way it's now calling back to webServer.listen.

What's the best course of action for making a test for this? File I/O has unpredictable execution times, so we should use a flag or event to detect - are we doing something similar elsewhere in the tests that could be mimicked?
Also, it seems like the set timeout on a single test is 2000ms, which might not necessarily be long enough to bundle & write the files.

You can increase the timeout by doing
it('is slow', function mytest () {
  this.timeout(5000)
})

For filesystem, we use a mock file system in other unit tests, e.g. https://github.com/karma-runner/karma/blob/10fac0745f3b14cb753119650552c191220f4d8b/test/unit/web-server.spec.js#L17

Correct me if I'm wrong, but it seems like using a filesystem call makes more sense here than using a mock filesystem since we're looking for the actual existence of these files.

The Node 6 and 8 jobs on Travis crashed during their package installs for some reason.

@dignifiedquire Does this look good to you? Travis failed on conditions unrelated to the PR.

The travis build fails with
<EMAIL_ADDRESS>invalid

That's pretty alarming ;-)

Ah, it failed differently this time.

@EzraBrooks Couldn't this be done in a way that don't slow down the first run everytime? Putting the burden of compiling client-side like this to every users for a niche use-case doesn't seems a very nice idea to me.

I don't think it's a niche use case to not have a private npm registry and want to work with a fork of a major repository like this.  It checks for existence of the files - it doesn't just assume they don't exist.

I queued the Travis job back up and it ran fine. It had errored on an apt install previously for some reason.

Thank you :octocat:


Updated polish translations.

Based on the strings file from today.

Cool, thank you so much! Could you rebase this branch to the tip of master? Github isn't happy with the other commits that have modified this file from where your branch started, so a quick rebase should be all that's needed.


Cumulus__dev_namespaced org auto-created with duration 1 day

$ cci org browser

The scratch org is expired
Attempt to recreate the scratch org? [Y/n]:
Org config was refreshed, attempting to recreate scratch org
2019-07-25 08:43:55: Creating scratch org with command: sfdx force:org:create -f orgs/dev.json --durationdays 1 -a "Cumulus__dev_namespaced"<EMAIL_ADDRESS>
Why 1 day when CumulusCI.yml in Cumulus repository says dev_namespaced: days=3 ?

The configuration in cumulusci.yml was probably updated after the dev_namespaced org was already initialized in your keychain. Delete ~/.cumulusci/Cumulus/dev_namespaced.json to reset it.


Please consider having git and the github-cli tool installed by default

Hmm, I'm not sure. I'm trying to keep the VM image as small as possible. Both to reduce download time and due to the limited disk size on GitHub runners.

I can understand the use of having git, but what's the use case for github-cli? Isn't that something that can be handled outside of this action?
An alternative approach, which I've already been thinking of, would be to allow custom VM images. Just specify a URL to an image and it would use that one instead. Is that something that could work? The image would most likely be a fork of one of the existing *-builder repositories: https://github.com/cross-platform-actions.

The way I'm using the Github CLI is in things like this where I test and package my code in one job, store it as an artifact, then use gh run download to get that artifact in the OpenBSD VM so I can see if it passes its tests and installs.
Testing with the tarball generated in another job is important here. I added this workflow because I once used GNU tar to package up some code that included a sparse file and OpenBSD's tar couldn't properly extract the tarball.
Allowing completely custom images would be nice. I'd like to create one for Solaris.

The way I'm using the Github CLI is in things like this where I test and package my code in one job, store it as an artifact, then use gh run download to get that artifact in the OpenBSD VM so I can see if it passes its tests and installs.

I see. I would insert a step before the step with the cross-platform-actions/action action to download the artifact. The https://github.com/actions/download-artifact action looks like what's needed. The way I use this action is as a step among other steps, I'm not using only one step and using this action exclusively for platforms like FreeBSD and OpenBSD. Here's an example of a workflow: https://github.com/jacob-carlborg/dlp/blob/master/.github/workflows/ci.yml. As you can see at the bottom, I use regular steps and actions to extract the version and creating/uploading a GitHub release, even for the FreeBSD platform: https://github.com/jacob-carlborg/dlp/blob/b458332fe8ebf89d5a077a441b874c55a581c722/.github/workflows/ci.yml#L145-L159.

Allowing completely custom images would be nice. I'd like to create one for Solaris.

Allowing arbitrary operating systems would not be supported. Different operating systems might require different configurations for the hypervisor or a completely different hypervisor (as in the case of Solaris and NetBSD). It would only be possible to build custom images of already supported operating systems. The use case would be the one you have described here: setting up additional pre-installed software.
In the case of Solaris, it's on my todo list to add support for it. It will most likely be after NetBSD, which I'm currently working on.

Ah-ha, that makes things so much simpler! Thanks.


Update greeting to feature-2

:star: PR built and available in a preview environment dlish-spring-boot-http-gradle-pr-2 here


Integrate with opendal

Hi, thanks for creating Spring Rust! I'm from the OpenDAL community and I'm considering whether we could collaborate to build a Spring integration for OpenDAL.
https://github.com/apache/opendal

OpenDAL offers a unified data access layer, empowering users to seamlessly and efficiently retrieve data from diverse storage services. Our goal is to deliver a comprehensive solution for any languages, methods, integrations, and services.

By adding opendal integration, users can visit s3, azbobl, oss, obs and more storage services.
What do you think?

OpenDAL looks like a good project. But this project is my side job, so this task has a lower priority. I need to finish the previous tasks before I can start this. If you are interested in implementing it, welcome to submit a pull request. The spring-rs extension plugin is very convenient.


Home Assistant Integration

Hello @goodfield ,
can you tell me how to implement your api into configuration.yaml of Home Assistant?
I found that thread eq3-max-i2c-one-wire in the Home Assistant forum, but component thermostat.max is not existing anymore (component climate.max is also not existing)
Do you have any hint for me how to get it working? Thanks in Advance, Thomas

Hi
sorry, but i'm not longer using home assistant ... this library was never integrated into home-assistant, that's why you can't use it.
You would have to write a plugin for home assistant (https://home-assistant.io/developers/), for the communication you could use this api.
Best regards,
David


Disabling "discovery:" also disables "Hass.io"-tab

Home Assistant release with the issue:
0.76.2
Last working Home Assistant release (if known):
0.75.0
Operating environment (Hass.io/Docker/Windows/etc.):
Docker on Intel-NUC
Component/platform:
System
Description of problem:
Disabling discovery in configuration.yaml leads also to disabling the Hass.io-tab
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
discovery:

vs.
#discovery:

Additional information:
Whether this is a bug or not I don't know - however, it seems illogical and for nothing else a bit annoying if the Hass.io-tab is only available with "discovery" enabled - I only want my system configured with specific devices and definitely not have the discovery function enabled generally.

The docs clearly indicate that you either need discovery: or hassio: in your configuration.yaml to enable the Hass.io panel.

Thought I had found the problem :-(
Me previous configuration included hassio: and excluded discovery:
After upgrading, hass.io-tab disappeared - no matter if hassio: was in the configuration or not.
Used a absolutely pristine configuration.yaml and then made one change at a time - and ended with the conclusion above.
Now, when adding hassio: and removing discovery:, the hass.io-tab appears as it should.
Seems strange - but the issue is not an issue and will be closed right away :-)


Emacs support

Description
This is probably a long shot, but would it be possible to create an emacs version of this color scheme?

Definitely! I don't know how emacs is structured, but perhaps someone will create it. It's a possibility nonetheless!
Take a look at https://github.com/sainnhe/forest-night/wiki. You'll find ports and we'll continue to add ports as this list grows!

Porting this color scheme to other apps is not hard IMO, all you need to do is simply replacing the color code in the corresponding gruvbox color scheme and adjust some UI colors, I finished these jobs in a single commit based on gruvbox-material. So you can consider porting this color scheme based on greduan/emacs-theme-gruvbox.
Since I and @jef don't use emacs, it might be better to be ported and maintained by emacs users. You can try to port it by yourself, or consider posting on emacs communities (e.g. r/emacs) to seek help.

If there is still interest in this topic, I recently started porting everforest hard dark to emacs.
Its far from being complete at the current state, but it is still very usable.
repo if this peaks interest: https://sr.ht/~theorytoe/everforest-hard-dark-theme/

As a bit of an update, my emacs port is pretty usable at this point.
I have implemented both hard-dark and hard-light, with medium and soft on the way.
If you wish to close this issue and link the project in the wiki, go ahead as it is nearly complete.
Repos:

https://github.com/Theory-of-Everything/everforest-theme
https://git.sr.ht/~theorytoe/everforest-theme

Great work!

As a bit of an update, my emacs port is pretty usable at this point. I have implemented both hard-dark and hard-light, with medium and soft on the way. If you wish to close this issue, go ahead.
Repos:
* https://github.com/Theory-of-Everything/everforest-theme

* https://git.sr.ht/~theorytoe/everforest-theme

Hey, just wanted to let you know that ~git.sr.ht~ isn't working and the GitHub repository is readonly so I'm unable to open an issue that I've been facing with the theme. Do you mind making the GitHub repository the actual repository?

I have re-opened the issues
I have stopped using sourcehut for a multitude of reasons, so the github should be the canonical repo for now


Call of Cthulhu Character Sheet calculations

CoC 7th ed character sheets seem to be calculating  max HP and MP incorrectly and locking it out.
Hit Points: Con + SIZ divided by 2. Round up any fractions.
Magic Points: Same as POW
This is not the calculation being shown.

The calculations are correct. You entered your stats wrong. You need to multiply them by 5.

Yes I have made some changes for sanity and movement calculations
But the HP and MP is correct.
As @Villadelfia said, your stats must  be converted to % so times 5 :)

So please close this issue :)


Pippo integration with Security framework

I wanted to know if there are plans to integrate any security framework with Pippo. Possible candidates could be:

pac4j
Apache Shiro

Or... any other framework

I don't plan to add new module in the near future in Pippo. I wish to consolidate, test and document what already exists. In the same time, I am happy to help new initiatives. So, if you are interested in a security framework please create a project, share this project with us on Github and I am ready to contribute. I am curios to see a security framework integrated in Pippo, not something complicated/big.

A security framework should resolve two problems:

authentication
authorization

I prefer something light, extensible, easy to integrate in Pippo (maybe not complete from the features point of view). In the end, Pippo is the land of choice for people that write small and medium application (from complexity point of view) so in this context I prefer libraries in same note.

I am toying with the idea of building an integration for pac4j. Seems like a popular choice by other micro frameworks like Ratpack or Jooby.
So I have a few questions:

Any thoughts or preferences about pac4j?
Would you be willing to add it as part of Pippo (as in a pippo-security-parent and pippo-pac4j?

@codematix

Any thoughts or preferences about pac4j?

I don't know to much about pac4j so I cannot tell you to much.

Would you be willing to add it as part of Pippo (as in a pippo-security-parent and pippo-pac4j)?

In the first phase I prefer a new repo, something like pippo-pac4j. A new module in Pippo means supplementary code to maintain and we should concentrate our efforts on core.
I am curios to know how other Pippo users resolve the security aspect in their applications. Maybe we can choose/adopt something that it's already integrated with Pippo.

In the first phase I prefer a new repo, something like pippo-pac4j. A new module in Pippo means supplementary code to maintain and we should concentrate our efforts on core.
I am curios to know how other Pippo users resolve the security aspect in their applications. Maybe we can choose/adopt something that it's already integrated with Pippo.

Yes it would be great to hear from other Pippo users as to how they have managed to implement the security aspect into their applications and also what their preference would be for a first-class security integration with Pippo.
About my experience, I have been using Spring Framework and the Spring Security modules for my applications. It has served us well in the past by integrating with most authenication/authroization systems.
We are trying to build some new products in our current project and as part of that, we are closely evaluating Pippo. We are very pleased with what we see in Pippo and want to see if we can use a off-the-shelf security framework like pac4j/Shiro can be integrated with Pippo.
I would request the Pippo community to voice out their preference/thoughts of a security framework integration with Pippo.

Maybe it's useful http://www.pac4j.org/docs/how-to-implement-pac4j-for-a-new-framework.html.

@decebals Yes that is what I am using to build the integration along with referring to some other integrations.
Please consider contributing to my attempt at this - pippo-pac4j

@decebals I am curios to know how other Pippo users resolve the security aspect in their applications. Maybe we can choose/adopt something that it's already integrated with Pippo.

Below my simple contribution.
Authentication controllers (www and web services) I did not put in because they had a lot of specific logic, but they followed the basic flow of validating username and password. The controller to "log in" to web services (ie getting JWT) validates username and password, and if valid returns the token (JWT). The next requests for web services must be made through the token (JWT).
AuthenticationFilter: check if the user is authenticated at each request (www) (screen requests);
WebServiceAuthenticationFilter: check if JSON Web Token (JWT) is valid for web services requests;
RequireRole: annotation for Pippo to intercept access to the method and check the authorization;
RoleHandler: business logic to check authorization;
CustomRouteContext: to force controller methods to define some of the authorization annotations;
public class PippoApplication extends ControllerApplication {
	protected void onInit() {
		ANY("/p/.*", new AuthenticationFilter()); // Check if the user is authenticated at each request (www)
		ANY("/ws/p/.*", new WebServiceAuthenticationFilter()); // Check if (JWT) JSON Web Token is valid for web services requests
	}
}

/////

/**
 * '/p/.*'
*/
public class AuthenticationFilter implements RouteHandler {

    @Override
    public void handle(RouteContext routeContext) {
        Pair<Boolean, String> loggedAndValidAndStatus = SecurityHelper.loggedAndValid(routeContext);
        boolean loggedAndValid = loggedAndValidAndStatus.getFirst();
        if (loggedAndValid) {
            routeContext.next();
        } else {
            String status = loggedAndValidAndStatus.getSecond();
            routeContext.setSession(Constantes.KEY_SESSION_ORIGINAL_DESTINATION, routeContext.getRequest().getApplicationUriWithQuery());
            routeContext.flashWarning(status);
            routeContext.redirect(Constantes.PATH_LOGIN);
        }
    }

}

/////

/**
 * '/ws/p/.*'
 * Filter for web services to check if the JSON Web Token of the requester is valid.
 * <p>
 * The token must be passed in the request header in the attribute {@link JsonWebTokenHelper#ATTR_JSON_WEB_TOKEN}.
 * </p>
 */
public class WebServiceAuthenticationFilter implements RouteHandler {

    private static final Logger log = LoggerFactory.getLogger(WebServiceAuthenticationFilter.class);

    @Override
    public void handle(RouteContext routeContext) {
        String jwtString = JsonWebTokenHelper.getJsonWebToken(routeContext);
        try {
            if (StringUtils.isBlank(jwtString)) {
                throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " attribute in header");
            }

            final String username;
            try {
                username = JsonWebTokenHelper.getUsername(jwtString);
            } catch (Exception e) {
                throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " invalid token");
            }

            if (StringUtils.isBlank(username)) {
                throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " user not defined in the token");
            }

            UserService userService = GuiceInjector.get().getInstance(UserService.class);
            User user = userService.getByUsername(username);
            if (user == null) {
                throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " no user for the informed token");
            }

            String jwtBase64Key = user.getJwtBase64Key();
            if (StringUtils.isBlank(jwtBase64Key)) {
                throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " need to sign in to get the token");
            }

            JsonWebTokenHelper.validateJWT(jwtString, jwtBase64Key);

            SecurityHelper.setLoggedUser(routeContext, user);

            routeContext.next();
        } catch (MalformedJwtException e) { // string is not a valid JWS
            throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " in invalid format.");
        } catch (SignatureException e) { // JWS signature validation fails
            throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " with invalid signature.");
        } catch (ExpiredJwtException e) { // Se o token estiver expirado
            throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " expired.");
        } catch (MyException e) {
            throw e;
        } catch (Exception e) { // Other
            throw new MyException(JsonWebTokenHelper.ATTR_JSON_WEB_TOKEN + " impossible to validate", e);
        } finally {
            if (routeContext.hasSession()) {
                routeContext.invalidateSession();
            }
        }
    }

/////

@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.METHOD)
@Interceptor(RoleHandler.class)
public @interface RequireRole {

    String roleName() default "";

    String description() default "";

}

/////

public class RoleHandler implements RouteHandler {

    private static final Logger log = LoggerFactory.getLogger(RoleHandler.class);

    @Override
    public void handle(RouteContext routeContext) {
        log.trace("RoleHandler.handle");

        Method method = PippoJarvisUtils.getMethod(routeContext.getRoute());

        log.debug("Checking authorization for '{}'", LangUtils.toString(method));

        RequireRole requireRole = method.getAnnotation(RequireRole.class);

        final String roleName = requireRole.roleName();
        User user = SecurityHelper.getUsuarioLogado(routeContext);

        UserService userService = GuiceInjector.get().getInstance(UserService.class);

        boolean authorized = userService.authorize(user, roleName);
        if (!authorized) {
            throw new MyException("You are not authorized to take the action: " + roleName, "/p/home", true);
        }

        // here the user can access the method
    }

}

/////

public class CustomRouteContext extends DefaultRouteContext {

    protected CustomRouteContext(Application application, Request request, Response response, List<RouteMatch> routeMatches) {
        super(application, request, response, routeMatches);
    }

    // Requires that all controller methods have at least one of the authorization annotations
    // TODO: The annoying thing to intercept here is that here are not only the routes of Controllers, but also of Filters and other
    @Override
    protected void handleRoute(Route route) {
        if (ControllerRouteHandler.class.isAssignableFrom(route.getRouteHandler().getClass())) {
            Method method = PippoJarvisUtils.getMethod(route);
            if (method.isAnnotationPresent(Public.class) || method.isAnnotationPresent(RequireRole.class)) {
                super.handleRoute(route);
            } else {
                throw new MyException("Need to apply security policy on " + LangUtils.toString(method) + ".", "/p/home", true);
            }
        } else {
            super.handleRoute(route);
        }
    }

}

/////

@AutoService(RouteContextFactory.class)
public class CustomRouteContextFactory extends DefaultRouteContextFactory {

    @Override
    public CustomRouteContext createRouteContext(Application application, Request request, Response response, List<RouteMatch> routeMatches) {
        return new CustomRouteContext(application, request, response, routeMatches);
    }

}

/////

public final class SecurityHelper {

    public static Pair<Boolean, String> loggedAndValid(RouteContext routeContext) {
        if (SecurityHelper.userLoggedIn(routeContext)) {
            String clientIpSession = getIpUsuarioLogado(routeContext);
            String clientIp = routeContext.getRequest().getClientIp();
            if (clientIp.equals(clientIpSession)) { // If IP has not changed
                return new Pair<Boolean, String>(true, "Authenticated and valid user.");
            } else { // If IP has changed, re-login
                return new Pair<Boolean, String>(false, "Your IP has changed. Authentication required again.");
            }
        } else { // If unauthenticated user
            return new Pair<Boolean, String>(false, "Authentication required.");
        }
    }

}

@mhagnumdw Your code looks good. The code is easy to understand and follow.
The part with CustomRouteContext is a little bit tricky. For example I don't understand the utility of this class.
Take an example:
if (method.isAnnotationPresent(Public.class) || method.isAnnotationPresent(RequireRole.class)) {
    ...
}

I see here a simplification, if the web method  is not annotated with @RequireRole then, by default, the web method is public (no security constraint). Again, I feel that CustomRouteContext is not needed.

if (method.isAnnotationPresent(Public.class) || method.isAnnotationPresent(RequireRole.class)) {
...
}
I see here a simplification, if the web method is not annotated with @RequireRole then, by default, the web method is public (no security constraint). Again, I feel that CustomRouteContext is not needed.

@decebals You're right. I'm in the process of migrating from Pippo 1.1.0 to 1.5.0 and this is a remnant code.

@codematix Thanks for your contribution!


refactor Keyboard package

Refactors the keyboard package to heavily rely on shared roots, for reusing of signals/event-listeners/computations, and every other primitive would be only quering a set of data in signals provided by them.
Adds a primitive for handling keyboard shortcuts.

TODO:

[ ] move from uvu to jest for now for testing — cannot properly test primitives that use a shared root, without the solid in dependencies not working properly.
[ ] add tests for createKeyHold and createShortcut
[ ] update docs

The vitest problem is solved, you just need to inline all solid-using dependency packages (including internal if imported through node).

Still can't get it to work...
This still fails:
import { isServer } from "@solid-primitives/utils";
test("...", () => {
  expect(isServer).toBe(false);
});

You need to inline @solid-primitives/utils, too, since it is otherwise imported by node.

I think I'm doing it here if it's correct: https://github.com/solidjs-community/solid-primitives/blob/320d05f74e8894e45a6af6c6bcad419e287db6c1/packages/keyboard/vite.config.ts

I'll have a look later.

Okay, I'm gonna merge it as it is.
@atk Hopefully someday this daunting problem will finally go away :D


RedisAdapter not assignable to AdapterConstructor

import { Server as ServerIO } from 'socket.io';
import { createClient as redisCreateClient } from 'redis';
import { createAdapter as redisCreateApter } from<EMAIL_ADDRESS>

const pubClient = redisCreateClient({ url: envConfig.REDIS_HOST });
const subClient = pubClient.duplicate();

const data = await Promise.allSettled([
    pubClient.connect(),
    subClient.connect().then(() => {
        server.#io.adapter(redisCreateApter(pubClient, subClient));
    })
]);

for (const job of data) {

    if (job.status === 'rejected') {
        throw new Error(`Error connect to redis database ${job.reason}`);
    }

}

Package versions

<EMAIL_ADDRESS>"8.0.0",
"redis": "4.5.1",
"socket.io": "4.5.4",
"typescript": "4.9.4"

According to TS RedisAdapter not is compatible or assignable to AdapterConstructor.
Argument of type '(nsp: any) => RedisAdapter' is not assignable to parameter of type 'AdapterConstructor'.
  Type '(nsp: any) => RedisAdapter' is not assignable to type '(nsp: Namespace<DefaultEventsMap, DefaultEventsMap, DefaultEventsMap, any>) => Adapter'.
    Type 'RedisAdapter' is not assignable to type 'Adapter'.
      Types have separate declarations of a private property 'encoder'.

Had the same issue... tracked it down to this line which introduced that encoder property that TypeScript complains about...
https://github.com/socketio/socket.io-adapter/blob/4e3991f740808afc91eb7b12b8845595cc3a158d/lib/index.ts#L233-L250
It wasn't there back in 2.4.0:
https://github.com/socketio/socket.io-adapter/compare/2.4.0...2.5.0#diff-d5a4b3a0309f2337144861084c1014523cced561eb722cb9684c63f5e41e0567R231
so temporary solution here I guess is downgrading back to 2.4.0...
npm remove<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>
Old version compiles fine:

For now, I down to<EMAIL_ADDRESS>The issue is with ^2.5.0 version as commented before.

This should be fixed by https://github.com/socketio/socket.io-redis-adapter/commit/7aecf01c361602f17ee3759da1ceeabb460d4519, included in version 8.0.1.


Safari Support

The Firefox support is great. It would be awesome if the extension could also support safari to give users more options.

Hi, porting to Safari requires a lot of work and I prefer to work on new features instead. But a lot of users would like to use it on Safari I will reconsider :)
If you want this feature please vote by adding +1👍 to the first comment by @qfettes !


Checkpoint usability issues

There are a number of usability issues that have surfaced while documenting checkpoints.

[ ] CheckpointLoader, CheckpointSaver and RunDirectoryUploader all have pretty out of date docstrings (Pain level: moderate)
[ ] save_folder that is a relative path should be relative to CWD, not the run directory. (Pain level: high)
[ ] Saving to object store requires the RunDirectoryUploader callback to be provided as well. This is not obvious and probably shouldn't be required (Pain level: mild)
[ ] Checkpoints should be saved as pytorch checkpoint files, not tarballs (Pain level: high)

Additional notes:
Save folder
Since the user is specifying the save_folder, it really should be respected. If they used a relative path, assume they meant relative to the CWD, not relative to some run directory. If we are concerned about checkpoint files overwriting others, we can either error or use the timestamp to ensure the filename is unique.
Saving to object stores
This is not particularly high priority, but is a usability issue. To use the object store, we should do as much as possible to just specify the URI as the save_folder and not require a separate callback.

There are a number of usability issues that have surfaced while documenting checkpoints.

[ ]  CheckpointLoader, CheckpointSaver and RunDirectoryUploader all have pretty out of date docstrings (Pain level: moderate)
Agreed; this will be fixed by #396
[ ]  save_folder that is a relative path should be relative to CWD, not the run directory. (Pain level: high)
OK, this can be changed.
[ ]  Saving to object store requires the RunDirectoryUploader callback to be provided as well. This is not obvious and probably shouldn't be required (Pain level: mild)
For this one and the above one, we should probably remove the run directory, and instead just have an object store provider pool that is attached directly to the state. Callbacks that currently write to the run directory would write directly to the object store provider. (A local directory could also function as an object store provider)
[ ]  Checkpoints should be saved as pytorch checkpoint files, not tarballs (Pain level: high)
Could you elaborate on the use case for accessing a checkpoint directly? I don't think there is a standard format for how to checkpoint the training state.

 If they used a relative path, assume they meant relative to the CWD, not relative to some run directory. If we are concerned about checkpoint files overwriting others, we can either error or use the timestamp to ensure the filename is unique.
Saving to object stores This is not particularly high priority, but is a usability issue. To use the object store, we should do as much as possible to just specify the URI as the save_folder and not require a separate callback.
You would need credentials to upload to a URI, in which case you would need the object store provider.

Good points. For checkpointing, ideally our format would work with torch.load and torch.save, and use the *.pt extension. The use case for loading the checkpoint directly is, say, analyzing the model weights, or even extracting them for deployment purposes with a different toolchain.

Perhaps we try to hit up the "High" pain level issues in v0.4, and defer the rest of v0.5?

Agree it would make sense to have a weights only checkpoint format for these cases. Is there any industry standard? (Onnx?)

I think the main point is to make the file loadable with torch.load. It's fine if the model weights are nested, ie state_dict["state"]["model"]. Just using a tarball is going to look strange to any user of Pytorch.

I presume one would need credentials to upload to an object store, in which case it would be more than a URI.

You're definitely right. I think it should basically mirror the args from CheckpointLoader with an ObjectStoreProvider.

save_folder that is a relative path should be relative to CWD, not the run directory. (Pain level: high)
I realize that this will be a bit more complicated, since we will need to differentiate between relative paths that are relative to the run directory vs to CWD. Can we defer this to 0.5 (thinking to fix it with something like #421) and just make it super clear in the docstring to use an absolute path if you don't want it relative to the run directory? Alternatively we could add a relative_to_run_directory flag as a short-term solution.

I'll add another one in (cc: @ajaysaini725

[ ] We want to programmatically retrieve the paths of the saved checkpoints after training. e.g.:

trainer.fit()

saved_checkpoints = trainer.checkpoint_saver.saved_files  # absolute path

#522 fixed the checkpointing docstrings, and #470 fixed the callback docstrings

#421 and the new checkpoint API (https://www.notion.so/Checkpoint-API-Redesign-f0ee88d4bd5149b6a091589ed3f465f5) will fix the other issues identified in this issue. However, these changes are scheduled for v0.5, not v0.4.1


code is unavailable.

I want to use your code and data for your FashionGan paper. Will it be available soon?

Everything is uploaded now. Sorry for the delay!


Share the script for T3Bench evaluation

Congratulations on your excellent results. Could you please share the script for T3Bench evaluation? Thank you.

Second 👀


webview_flutter package

Keyboard does not close after search results returned.

Go to any website enter a search string in the search field and press enter on the keyboard.
the search page displays the result but the keyboard remains open.

Tested on www.google.com and other websites.

@dcruzwil
There's similar open issue describing your case, 36478.
Please follow-up there for updates and any questions.
Closing this as duplicate.


Resource tabs do not have correct aria roles

See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Tab_Role

They do now.


Draft Pull Request not Recognized as Hunter Activity

Bounty hunter was adding commits and comments to the draft pull request but the bot still followed up asking for updates.
This should be fixed.

Do you have any updates @devpanther? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Fri Aug 18 2023 05:57:07 GMT+0000 (Coordinated Universal Time)

Originally posted by @ubiquibot in https://github.com/ubiquity/ubiquibot/issues/593#issuecomment-1687532864

IMO, that's not the problem related to draft. Please check https://github.com/ubiquity/ubiquibot/blob/8646aa11fc9b9edfcc355615a096f12e7935e607/src/helpers/issue.ts#L622C27-L622C27
It fetches commits from a pull request but by default, it only gets first 30 commits.
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28
We may need to fetch all the commits from the pull request and check activity of last commit.

/start

IMO, that's not the problem related to draft. Please check https://github.com/ubiquity/ubiquibot/blob/8646aa11fc9b9edfcc355615a096f12e7935e607/src/helpers/issue.ts#L622C27-L622C27
It fetches commits from a pull request but by default, it only gets first 30 commits.
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28
We may need to fetch all the commits from the pull request and check activity of last commit.

Thanks for the diagnosis! Looks like the next function loads all of the data. We should consider removing the old function that only loads a single page of data.

/start

Do you have any updates @byteballet? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Wed Sep 06 2023 06:37:29 GMT+0000 (Coordinated Universal Time)

Oh, I had serious toothache so I am starting right now.


Fix the issue which component Name is Unknown

Please answer these questions before submitting pull request

Why submit this pull request?
[x] Bug fix
[ ] New feature provided
[ ] Improve performance

Codecov Report

Merging #4672 into master will decrease coverage by 51.07%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28530cd...fba7217. Read the comment docs.


BACKPATTER_BACK_TO_FIRST keeps toolbar color

Hi!
Using version 1.3.1 and back pattern BACK_TO_FIRST, when changing section and pressing back, the first toolbar keeps the color of the second section.

Fixed in the 1.3.2


As a flexible tutor, I want to be able to edit my student’s lesson timings

so that I can accommodate any changes in timing requested by them.

Completed in #87


Nats

Restructure code to use external event source - e.g. Nats.io
Move EventSource code to EventSource package
Move Binder code to binder package.
Change build process to run up docker image of NatStreamingServer in order to test event source code.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add support for new mobile bar/left ribbon replacement

Describe the feature
Hey Phillip,
I hope you're doing well! With the new public release, I thought I might ask about a feature I'd like to see in the mobile app.
I would love if the settings for the left ribbon would now be applied to its new replacement in the mobile app, the long press menu on the right of the "tool bar" (next to the tab switcher).
Do you think this is possible?
Does this fix a problem? If so, specify.
I think that this would be a nice addition to the plugin as it would bring the functionality on par with the desktop experience. Many people on Discord have asked about it as well.
Did you consider other alternatives?
There aren't really any alternatives. The left ribbon settings are currently useless on mobile and I don't know of any other plugin which modifies that list of commands.
Screenshots and recordings
I'll clarify the position in the tool bar with two screenshots in a few minutes. Okay, for anyone else reading this, this is the button I'm talking about:

Yes, that is definitely something I will be working on! Stay tuned for the next update 👀

also just confirming that this doesn't work on android but mostly so I get the notification when it's solved! :)

I miss the left ribbon 😞

Has been following this issue for a while, and updated to 0.3.0 as soon as I heard (the number of plugins I have installed has made my mobile toolbar basically unusable). However, even testing on a fresh vault, I wasn't able to get commands hidden:

iOS 15, Obsidian Mobile v1.4.1, tested on a fresh vault.

seconded, we may need a new issue created

Alternatively if I can at least order the custom commands up top that will already be super useful #10 (related)

Can be a good workaround until this is fixed.

and perhaps a useful feature of itself

Is v3.0 supposed to address adding/hiding on the new mobile(phone) ribbon on the bottom right? Adding commands to the ribbon works for me, but can't hide the defaults (and therefore can't order properly). (?_?)

y'all, we should make new issues. lots of creators don't have notifications on old issues. highly recommend new issues.

y'all, we should make new issues. lots of creators don't have notifications on old issues. highly recommend new issues.

I do read all the issues! I just don't have enough time to work on Commander at the moment. If someone knows a fix for this, I would greatly appreciate a PR, otherwise it might take a few more weeks


Can't install

while trying to install  >npm install ng2-smart-table --save
i got this error screen :

is there any solution ?!
thanks

This isn't a ng2-smart-table issue - You might want to try renaming the folder like it suggests


Use desired branding for 3.0 previews

Should be suffix-less 'preview'

We are not using this repo anymore for 3.0. We can take it out of the prod con list.


Fixed the elasticsearch operations error

If err raise in creating the object of elastic search, we make the object equal to None.
Added ping method to elastic search operations. This will help to test the successful connection of ElasticSearch.

@athiruma are you sure this is the issue ?

yes,
return self.__es.ping()
59
AttributeError: 'ElasticSearchOperations' object has no attribute '_ElasticSearchOperations__es'. Did you mean: '_ElasticSearchOperations__es_host'?


Transformations on Json config files

Hi,
With recent projects in .NET Core that uses .json as source for config settings, how can we provide 'transformations' within our nuget packages so that they add/update/remove content into current app.config (json format) files ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40bb9dee-46d6-4064-83e8-ba2e22ac6afe
Version Independent ID: aac0bbd8-645b-ccf8-bec9-e0d970c8b089
Content: Source and config file transformations for NuGet packages
Content Source: docs/create-packages/Source-and-Config-File-Transformations.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

This question is better placed to the asp.net core or .net core team.
Can you please file it into their repo?

@lisberPontes, I believe I'm aiming to achieve the same thing. I want generate a Nuget with a default key\values in appsettings.json file that must either replace or add key\values into the target project appsettings.json where is being added that nuget package. But I'm only able to replace the whole file content.
Did you find a way to achieve it?


Throw error if text value is not valid

Address: #751

@zabil  and @sriv I have fixed all the review comments. Can you pls look at it now?

Sorry, found something, will fix it!!

@saikrishna321 FTs are still failing.

@gaugebot recheck the pull request.


Update Spectral fitting class to use SpacecraftFile

See #72
e.g.
#from cosipy.coordinates.orientation import Orientation_file
from cosipy.spacecraftfile import SpacecraftFile

Done in PR #78


Golden Test Failure output doesn't support golden files in nested directories

Steps to Reproduce

Write a test that uses the matchesGoldenFile(fileName) assertion, and specify a filename with a nested sub-directory.
import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  group('Golden Failure Output Bug', () {
    testWidgets('blue container', (tester) async {
      await tester.pumpWidget(Container(color: Colors.blue));
      await expect(find.byType(Container), matchesGoldenFile('subdir/blue_container.png'));
    });

    testWidgets('red container', (tester) async {
      await tester.pumpWidget(Container(color: Colors.red));
      await expect(find.byType(Container), matchesGoldenFile('subdir/red_container.png'));
    });
  });
}

When you generate goldens, the appropriate reference images are generated. However, if the widget under test changes and the goldens fail, the failure images are inappropriately generated.
In this case, both tests will compute to the same file name and override each other:

The issue is that the code for generating the failure file name naively assumes that the image is not in a directory. Line 156
Here is a screenshot of the debugger from my actual use case

[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.14.6 18G1012, locale en-US)
• Flutter version 1.12.13+hotfix.5 at /Users//Library/Code/flutter
• Framework revision 27321ebbad (7 days ago), 2019-12-10 18:15:01 -0800
• Engine revision 2994f7e1e6
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users//Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 28.0.3
• ANDROID_HOME = /Users//Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3, Build version 11C29
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.4)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 36.0.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[✓] VS Code (version 1.41.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.7.1
[✓] Connected device (1 available)
• iPhone 11 Pro Max • B3D5F663-0ED7-4880-8552-4A0D186F7F50 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
• No issues found!

Hey @coreysprague thanks for filing this!
The naming issue is an easy fix. Beyond that, I am curious, would you expect the failures directory of image diffs to be generated in the subdirectory as well?
For example:
My base directory is tests, which contains tests.dart, and I have a golden master image in tests/goldens1.
When comparison of tests/goldens1/golden1.png fails, would you expect

tests/goldens1/failures
or
tests/failures

for the location of the output? Right now the implementation assumes that golden files may be contained within many subdirectories, and therefore provides all output in one directory where the actual test is. (Aside from the naming issue of course).

Tests/Failures seems good to me, but I don’t have a strong preference either way. Thanks!

Thanks for the feedback and again for bringing this to our attention! The fix should land soon.


fix(solid-query): Persist client implementation

This change fixes some loose ends with the solid query's implementation of the persist client

It simplifies the implementation using the new persistQueryClientRestore and persistQueryClientSubscribe functions
Gets rid of extra computations in createBaseQuery
Also fixes some underlying bugs mentioned in #6930 (thanks to @Brendonovich)

This should be fixed in v5.24.3+ Example here https://stackblitz.com/edit/github-wa8e73?file=package.json


Invalid configuration: private method `load' called for Psych:Module

Was trying to intrgrate with ST3 but get no response.
Try to do it through command line but also not working and displayed the titled error message

Running on Mac Yosemite
ruby 2.0.0p481 (2014-05-08 revision 45883) [universal.x86_64-darwin14]
Sass 3.4.9 (Selective Steve)
scss-lint 0.31.0

I tried to remove gem, but the answer of my system was:
gem "psych" cannot be uninstalled because it is a default gem

@Raffaele I don't know the exact answer to your question as I'm not a Ruby nor Gem expert but it is possible to just install v2.0 side-by-side to your current installed version. In order to make it work for me I just ran
gem uninstall psych
gem install psych -v 2.0

and then  gem list --local | grep psych then shows the following:
➜  some_folder git:(master) ✗ gem list --local | grep psych
psych (2.0.8, 2.0.0)

:+1:

Everybody who is still seeing this error:
gulp update --system

Could help. This was probably an issue in ruby gems itself (see here for a more detailed discussion https://github.com/bbatsov/rubocop/issues/1510)


Inconsistent GKE creation example and number of node suggestion

in this page, the doc suggests to have at least 4 nodes for GKE :
If you use GKE, please ensure your cluster has at least 4 standard GKE nodes. If you use Minikube, please ensure you have at least 4GB RAM.

However in the setup page the command that is used to create example GKE cluster creates them with 3 nodes.
 gcloud container clusters create <cluster-name> \
  --cluster-version=1.10.5-gke.4 \
  --zone <zone> \
  --project <project-id>

Following the example is inconstant.

@salrashid123 Could you take a look?

our suggestion is 4 nodes and its what we use on the DM template too.
however:
The gke cluster verison specifies fully qualified  1.10.5-gke.4
while the DM template specifies the version alias  1.10.5 alone
both are wrong at the moment  1.10.5 doens't exist so deployments will fail (esp the DM version).  I'll submit an issue about it right now.
https://cloud.google.com/kubernetes-engine/versioning-and-upgrades#specifying_cluster_version

istio_DM template

We can pick either

1.10.6
1.10.7

LMK which one istio targets

The PR i submitted above removes the whole GKE version spec in the command.  Would recommend removing it in the gcloud command here too


Change regex to exclude Sass partials in sub-directories

This pull request refers to #35. I noticed that you exclude Sass partials in "stylesheets", but not in sub-directories. Regex is explained in code comments and rejects partials in sub-directories.
I was not sure how to test this. Let me know if you have an idea what exactly to test in a Clash test.

Excellent! I'll work up a test for it. Thanks for your help!

@parkr @imathis re testing of Jekyll websites, can you point me to projects using tests other than than Clash to test Jekyll websites? I am wondering if people use Rsense + Capybara? While Clash tests are easy to write, I find them hard to understand because because often you need to look at actual directory diffs to understand what is being tested.

I've added tests and merged this in. I hadn't assumed subdirectories in in assets before, and while creating a test case for this, I discovered some other issues.

If a user copied assets using the octopess ink copy command, subdirectories weren't retained.
Sass partials in subdirectories were being added to the _site/stylesheets/ and css tags if the user configured stylesheets not to be combined.

So thanks a bunch! Here's a look at the stuff that I added after your commits.

Thanks, for fixing this!


textarea html in webview not trigger onchange event on iOS

Bug description:

when i change value at textarea html tag, onfocus and onkeypress event has triggered, but onchange event is not triggered.
So, i cannot edit value at textarea.
I should use multi line text input, so i cannot use input html tag.
input html tag triggers onchange event, so i could edit and update the value.
is this bug?
To Reproduce:

Expected behavior:

Screenshots/Videos:

Environment:

OS: ios
OS version: 15.5
react-native version: 0.68.1
react-native-webview version: 11.18.1

i found that textarea css user-select property set none at safari browser :(
so i add textarea { user-select:auto;}


feat: convert to typescript

BREAKING CHANGE: This module now requires creating a new Resource object.
Old Code
const resource = require('@google-cloud/resource')({
  projectId: ...
});

New Code
const Resource = require('@google-cloud/resource');
const resource = new Resource({
  projectId: ...
});

What happened to the coverage?

I honestly have no idea.  Let me fix that before merging :)


VisitableSchemaType is no longer exported

Due to https://github.com/apollographql/graphql-tools/commit/51d2ccf4953567267d69f505b752fba18a100254, VisitableSchemaType is no longer exported from index.ts. While it is not a problem for js users, it introduces an issue for typescript users.
The problem is that the constructor function of SchemaDirectiveVisitor takes a VisitableSchemaType as follow
https://github.com/apollographql/graphql-tools/blob/248527d497aa1fe5ff5648e94bf38366121d9d92/src/schemaVisitor.ts#L668-L674
This lead to an extra import { VisitableSchemaType } from 'graphql-tools/dist/schemaVisitor'; for users who use SchemaDirectiveVisitor with typescript.
A simple fix is to re-export VisitableSchemaType. But a better fix is to create an interface for the config variable and export it.

Because of this problem, we're having problems when writing tests for our directive.
export class HasRoleDirective extends SchemaDirectiveVisitor {...}

  const directive = new HasRoleDirective({
    name: 'testHasRoleDirective',
    args: directiveArgs
  })

Ends up:
error TS2674: Constructor of class 'SchemaDirectiveVisitor' is protected and only accessible within the class declaration.

Ok, let's add the constructor:
import { VisitableSchemaType } from 'graphql-tools/dist/schemaVisitor'

export class HasRoleDirective extends SchemaDirectiveVisitor {

  constructor (config: {
    name: string
    args: { [name: string]: any }
    visitedType: VisitableSchemaType
    schema: GraphQLSchema
    context: { [key: string]: any }
  }) {
    super(config)
  }

This time this:
error TS2345: Argument of type '{ name: string; args: { [name: string]: any; }; visitedType: import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/packages/apollo-voyager-keycloak/node_modules/graphql-tools/dist/schemaVisitor").VisitableSchemaType; schema: import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/pack...' is not assignable to parameter of type '{ name: string; args: { [name: string]: any; }; visitedType: import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/packages/apollo-voyager-server/node_modules/graphql-tools/dist/schemaVisitor").VisitableSchemaType; schema: import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/node_m...'.
  Types of property 'visitedType' are incompatible.
    Type 'import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/packages/apollo-voyager-keycloak/node_modules/graphql-tools/dist/schemaVisitor").VisitableSchemaType' is not assignable to type 'import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/packages/apollo-voyager-server/node_modules/graphql-tools/dist/schemaVisitor").VisitableSchemaType'.
      Type 'GraphQLSchema' is not assignable to type 'VisitableSchemaType'.
        Type 'import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/packages/apollo-voyager-keycloak/node_modules/@types/graphql/type/schema").GraphQLSchema' is not assignable to type 'import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/node_modules/@types/graphql/type/schema").GraphQLSchema'.
          Types of property 'astNode' are incompatible.
            Type 'import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/packages/apollo-voyager-keycloak/node_modules/@types/graphql/tsutils/Maybe").default<import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/packages/apollo-voyager-keycloak/node_modules/@types/graphql/language/ast").SchemaDefiniti...' is not assignable to type 'import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/node_modules/@types/graphql/tsutils/Maybe").default<import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/node_modules/@types/graphql/language/ast").SchemaDefinitionNode>'.
              Type 'import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/packages/apollo-voyager-keycloak/node_modules/@types/graphql/language/ast").SchemaDefinitionNode' is not assignable to type 'import("/home/aliok/Desktop/code-redhat/aerogear/apollo-voyager-server/node_modules/@types/graphql/language/ast").SchemaDefinitionNode'.
                Types of property 'directives' are incompatible.
                  Type 'ReadonlyArray<DirectiveNode> | undefined' is not assignable to type 'ReadonlyArray<DirectiveNode>'.
                    Type 'undefined' is not assignable to type 'ReadonlyArray<DirectiveNode>'.

Please make the constructor public and also export VisitableSchemaType otherwise it is problematic to create an instance of a directive in typescript.

@alvis I'm happy to pick this up if you're still looking to get this fixed.

Closed by #1307, rolled into #1306


mobile: Add CONNECT Proxy support for iOS

This commit enables reading the iOS system proxy settings in Envoy Mobile and using those settings
to configure the NetworkConfiigurationFilter, so that the transport socket can use HTTP CONNECT to
go through the configured proxy.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@alyssawilk Still need to fix some things and add some more tests (better network_configuration/filter test coverage and PAC URL test coverage), but I added two tests in HTTPRequestUsingProxyTest.swift, one for http and the other for https, and both work fetching a URL through the test proxy, so I think this is ready for an initial pass.

/retest

Alyssa said she's good with the PR and Ryan's approval, so I'm going to merge.  Thanks for the awesome reviews everyone!


Create the chat supervisor entity

Purpose
This is the main entry-point (for the client-side) to the server part of the chat system. This actor is responsible for creating the necessary lobbies.
It is responsible for handling all messages of the supervisor message protocol:

InitiateConversation

and the confirmation messages:

ConversationInitiated

Duplicate of #1.


HA multi-master deploy controller behavior

Version:
v1.17.2+3592d0bd on Ubuntu 19.10 amd64
1 node deployed with:
K3S_TOKEN=asecret INSTALL_K3S_COMMIT=3592d0bdd9e0656d9f1704548ccf199039f27136 ./k3s.sh server --no-deploy=coredns,servicelb,traefik,local-storage --disable-cloud-controller --disable-network-policy --cluster-init
2 nodes deployed with:
K3S_URL=https://k3s01.khaus:6443 K3S_TOKEN=asecret INSTALL_K3S_COMMIT=3592d0bdd9e0656d9f1704548ccf199039f27136 ./k3s.sh server --no-deploy=coredns,servicelb,traefik,local-storage --disable-cloud-controller --disable-network-policy
Describe the bug
I'm not sure which nodes are running the deploy controller. All of them? Just the one that's currently holding the lease for kube-controller-manager?
To Reproduce
Configure 3 nodes as described above
Expected behavior
Clear knowledge over which node is responsible for deploying manifests from the filesystem
Actual behavior
Unknown behavior

We have long had the distinction between --cluster-init and --server flags. The primary server deploys the manifests. Closing as OOD.

Actually all of them deploy the manifests 😬


When will NPM be updated?

I see based on the files here that 1.4 has been released, however NPM still has 1.3.1.  When can we expect NPM to be updated to 1.4?

I realized I left a mistake after doing npm version (which creates a commit) and pushing it. I was working on the docs, noticed a mistake in the code, pushed c99cf7806ef6d04329da0a9a09b778dcbe39b472, and then got busy. 1.4.0 probably won't be on npm. You'll see 1.3.1 and then 1.4.1. Just waiting until I've updated the docs pages. Sorry for the delay.
Meanwhile, you can use npm install tmijs/tmi.js#c99cf7806ef6d04329da0a9a09b778dcbe39b472 (or any other "commit-ish")

No worries, I just wanted to make sure I wasn't missing something.  Thanks!  I'll wait for 1.4.1


[SPARK-1507][YARN]specify num of cores for AM

Hi @XuTingjun mind closing this issue then? It's confusing to have both open.


Fix typo acitvemq in step-eip.adoc

typo acitvemq to activemq
Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Done.  I'm somewhat new to the process.
On Mon, Jan 8, 2024 at 8:42 AM Andrea Cosentino @.***>
wrote:

@.**** approved this pull request.
Can you please do the same on main branch? Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/apache/camel/pull/12700#pullrequestreview-1809586684,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVPNVFWGO47BDDV67M2OMLYNQOW7AVCNFSM6AAAAABBRXNDLOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBZGU4DMNRYGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add support for Hopper GPU

Description of changes:
Related Issues:
Linked Issues:

Issue #

Issues closed by this PR:

Closes #

@xinhaoc It would be great to update this PR for merging into main.

@xinhaoc It would be great to update this PR for merging into main.

OK


[DNM] check ansibleee-runner image

Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/413

recheck

recheck


Add Support for DR-HSH009AS

You already have a DR-HSH009S supported the DR-HSH009AS is identical, just the plug is different which has a ALCI Safety Plug. The rest is all the same.
Model: DR-HSH009AS
Number of Speeds: No speeds
Does the fan support oscillating: Yes, can oscillate in 3 positions pointing to floor / mid / ceiling and auto
What preset modes are supported: H1, H2, H3, and Eco mode which can be set to a specific temperature.
Is temperature supported: yes when in Eco Mode.

For those who has the DR-HSH009AS with the ALCI Safety Plug, Downloading the main branch will get it to work. It appears as a DR-HSH009S even though its a DR-HSH009AS. Just that the climate domain wont load because of an error in the climate.py file in the dreo custom component folder.
Here is the error:
2024-03-16 15:17:57.752 ERROR (MainThread) [homeassistant.components.climate] Error adding entities for domain climate with platform dreo
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 507, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 662, in _async_add_entity
capabilities=entity.capability_attributes,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 276, in capability_attributes
supported_features = self.supported_features
^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dreo/climate.py", line 202, in supported_features
supported_features |= ClimateEntityFeature.TURN_OFF
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/enum.py", line 784, in __getattr__
raise AttributeError(name) from None
AttributeError: TURN_OFF
2024-03-16 15:17:57.800 ERROR (MainThread) [homeassistant.components.climate] Error while setting up dreo platform for climate
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 367, in _async_setup_platform
await asyncio.gather(*pending)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 507, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 662, in _async_add_entity
capabilities=entity.capability_attributes,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 276, in capability_attributes
supported_features = self.supported_features
^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dreo/climate.py", line 202, in supported_features
supported_features |= ClimateEntityFeature.TURN_OFF
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/enum.py", line 784, in __getattr__
raise AttributeError(name) from None
AttributeError: TURN_OFF

I just comment this section in the climate.py restart HA and it works.
        # if self.device.poweron is not None:
        #     supported_features |= ClimateEntityFeature.TURN_OFF
        #     supported_features |= ClimateEntityFeature.TURN_ON

But its missing the osc mode on the climate card.

@andy-cooper did you want to look at this?

Should be in there


goroutine  in sync is not recover and maybe leak

Thanks, I'll check that

use sync.once to protect  goroutine creation  13ccbbb


Fixed typo

changed apikey to api_key
Description of the change:
Reason for the change:
Link to original source:

Closes #

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @akhilrj,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Please invite me to the GitHub Community Organization

Name
Divakar
Discord Username (if applicable)
DIVA#1399
Additional Context
I am an active OS contributor, willing to explore more and contribute my work towards communities. Compounding my insights,learnings and work.
I am eagerly waiting to join this community

It's great having you contribute to this project
If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Invitation sent for the GitHub Organisation. Welcome to the community 🎉#
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/jaidevstudio/people
Like this

Tips for practising:
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps

Please check your email or organisation page 🙏


Remove dependency on bower

Removes use of bower in favour of NPM.
Maintained bower'esque behaviour of copying across entire module folder to wwwroot/lib.
fixes #2127

@VishalMadhvani @dpaquette Is this going to require new developers to run the gulp script in order to get started?  If so, that probably needs to be documented, since currently gulp was not previously required to get up and running in the dev environment.  I'm not super familiar with npm, but would it be possible to run the gulp script when npm install is run to avoid having to instruct new developers they need to run gulp?  We should also remove the bower sections from existing docs.

@dchristensen done :)
Happy up update the wiki's once this is merged in.


[release/1.0] archive: fix logic for skipping mknod when running in userns

Signed-off-by: Akihiro Suda<EMAIL_ADDRESS>cherry-pick https://github.com/containerd/containerd/pull/2163

Codecov Report

Merging #2179 into release/1.0 will increase coverage by 0.01%.
The diff coverage is 50%.

@@               Coverage Diff               @@
##           release/1.0    #2179      +/-   ##
===============================================
+ Coverage        50.56%   50.57%   +0.01%
===============================================
  Files               81       81
  Lines             7169     7171       +2
===============================================
+ Hits              3625     3627       +2
  Misses            2849     2849
  Partials           695      695

Flag
Coverage Δ

#linux
50.57% <50%> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

archive/tar_unix.go
52.38% <50%> (+1.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd0439...a3372da. Read the comment docs.

LGTM


[3pt]  - Add tests for comments counter - Student B

Make sure that function for the comments counter is covered with unit tests using Jest.

We have created a commentCouter.test.js file and we can cover it with a unit test using jest.

Hello @SurafelGetachewT SurafelGetachewT, my Good partner
The test cases and test was reviewed and Quality is Excellent and the App passed the test
Kudos: 👏🏾


Prompt validation does not visualize the output (errors)

using inquirer a prompt with validate function should show the validate output, but with vorpal it is somehow omitted.
this.prompt([
	{
		type: 'input',
		name: 'test',
		message: 'Please type something different than `test` to see an error pop up... or type `test` to continue',
		validate: function (val) {
			if (val != 'test') {
				return "Please answer with the word test";
			}
			return true;
		}
	}
], function(answers) {
	console.log(answers);
});

in Inquirer you can see this work perfectly in the examples/input.js example. however the error gets lost somewhere in the process within vorpal I assume.

throw the error instead of returning it
            if (val != 'test') {
                throw "Please answer with the word test";
            }
        }```

@jackyjieliu will try, however I doubt that's going to be the issue, I'm positive that it is vorpal who surpresses the errors, since inquirer.js (used by vorpal) tells us to do it by returning an errorMessage.
see the third input in their examples. https://github.com/SBoudrias/Inquirer.js/blob/master/examples/input.js
// ...
{
    type: "input",
    name: "phone",
    message: "What's your phone number",
    validate: function( value ) {
      var pass = value.match(/^([01]{1})?[\-\.\s]?\(?(\d{3})\)?[\-\.\s]?(\d{3})[\-\.\s]?(\d{4})\s?((?:#|ext\.?\s?|x\.?\s?){1}(?:\d+)?)?$/i);
      if (pass) {
        return true;
      } else {
        return "Please enter a valid phone number";
      }
    }
  }
// ...

Got it. Will check out as soon as I can!

I've got the same problem here,

This is a tough one since Vorpal has completely taken over rendering, so it'll probably also have to take over looking for the validate parameter, calling it, and rendering the output.

Yes, that's correct.

I've just created a PR that hopefully fix the issue. I've tested in one project I'm working and it fixes the issue on the 3 instances I'm validating.


Problem to start/create the integration: KeyError: 'access_token' / TypeError: 'HassLogger' object is not callable

Version of the custom_component
0.0.14
Configuration
Through the integration (no yaml)
Describe the bug
Impossible to start the integration or even reload it... If I recreate the integration, I cannot login... so no debug log available as the integration has been removed and no way to recreate it...
Debug log

2023-06-15 08:26:59.223 WARNING (MainThread) [homeassistant.util.async_] Detected blocking call to sleep inside the event loop. This is causing stability issues. Please report issue to the custom integration author for porscheconnect doing blocking calls at custom_components/porscheconnect/__init__.py, line 94: access_tokens = await controller.getAllTokens()
2023-06-15 08:27:02.022 WARNING (MainThread) [homeassistant.util.async_] Detected blocking call to sleep inside the event loop. This is causing stability issues. Please report issue to the custom integration author for porscheconnect doing blocking calls at custom_components/porscheconnect/__init__.py, line 94: access_tokens = await controller.getAllTokens()
2023-06-15 08:27:04.918 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry <email_removed> for porscheconnect
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/porscheconnect/__init__.py", line 94, in async_setup_entry
    access_tokens = await controller.getAllTokens()
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyporscheconnectapi/client.py", line 32, in getAllTokens
    return await self._connection.getAllTokens()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyporscheconnectapi/connection.py", line 204, in getAllTokens
    token = await self._requestToken(application)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyporscheconnectapi/connection.py", line 229, in _requestToken
    jwt = self.jwt_payload_decode(token_data["access_token"])
                                  ~~~~~~~~~~^^^^^^^^^^^^^^^^
KeyError: 'access_token'

If I try to reload the integration, I am getting this error
2023-06-15 08:28:29.874 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry <email_removed> for porscheconnect
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/porscheconnect/__init__.py", line 94, in async_setup_entry
    access_tokens = await controller.getAllTokens()
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyporscheconnectapi/client.py", line 32, in getAllTokens
    return await self._connection.getAllTokens()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyporscheconnectapi/connection.py", line 204, in getAllTokens
    token = await self._requestToken(application)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyporscheconnectapi/connection.py", line 211, in _requestToken
    await self._login()
  File "/usr/local/lib/python3.11/site-packages/pyporscheconnectapi/connection.py", line 128, in _login
    _LOGGER("We already have a code in session, skip login")
TypeError: 'HassLogger' object is not callable

I just pushed version 0.0.15 that should fix the login problems, I haven't seen the HassLogger error but hopefully it should not be a problem with this version.

Problem fixed... Thank you for the very quick fix !!!


"drush php" doesn't work as expected

Describe the bug
Drush php shell is exited after a command is run.
To Reproduce
Steps to reproduce the behavior:

ddev ssh
drush php
echo 'hello';

Expected behavior
Drush php shell should continue to run.
Version and configuration information (please complete the following information):
php: 7.1
ddev config:
cli   	        v1.1.1
web   	drud/ddev-webserver:v1.1.0
db    	drud/ddev-dbserver:v1.1.0
dba   	drud/phpmyadmin:v1.1.0
router	drud/ddev-router:v1.1.0
commit	v1.1.1

Additional context
The described bug might appear in other php versions.
Solution
Remove pcntl_fork,  pcntl_waitpid, pcntl_wexitstatus, pcntl_signal_dispatch from disabled_function in /etc/php/7.1/fpm/php.ini

Sounds like a fine solution to me.

Are you able to make it work fine with custom php config? (Just changing disabled_functions)? (https://ddev.readthedocs.io/en/latest/users/extend/customization-extendibility/#providing-custom-php-configuration-phpini)

Yes, that works.

Could you provide your config please? Thanks!

Path: .ddev/php/my-php.ini
[PHP]
disable_functions =

Seems great. Any downside to this that you know of?

No.


Multiple notifications fix

This week there were some problems at the payment gateway, and they sent the same notification a couple times to the notification endpoint (what can teoretically happen for various reasons any time - server problems, etc.), and we had dozens of active recurrent payments created. So I've added a check for this to the notification method. Sometimes instead of payment data, the gateway sends an error response to the status request, that is handled in this pr too.

thanks for the review, I've changed it, take a look please..

Merged via https://github.com/remp2020/crm-gopay-module/commit/f1779228ada469af5787d13ac00c0d7b100af0b3.


Custom error types

It would be nice for downstream error handling if frisbee had custom error types like FrisbeeRequestError, or even allowed for specifying error types in config.

Not sure where we would add this?  Can you give an example of usage or make a PR so I know what you mean?  We pretty much just use native errors.


Bump fabric-protos-go to latest

Finish cleanup related to the peer admin service.

https://dev.azure.com/Hyperledger/Fabric/_build/results?buildId=17213&view=logs&j=a11cdf60-0d11-5130-c801-1b4953009464&t=849b73ad-cbaa-5065-7214-c0ac3d42920d
Looks like a gossip flake, I doubt that it's related to the proto updates.. should we create a JIRA?


RetryPolicy for output messages?

What is the default RetryPolicy for messages send by the OpcPublisher used as IotEdge module ?
Can the RetryPolicy be changed (e.g. using commandline parameters) ?

Offline message storage can be configured in IoT Hub, retry policy cannot.   Since our officially supported hosting mode is IoT Edge we are not going to add this functionality in the coming months, hence I am closing it.


Refine cell value coercion to number in filtering logic

Fix for #494:

refine number coercion in filtering logic to avoid formatted numbers to be converted to wrong value by Number

Codecov Report

Merging #495 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #495      +/-   ##
=========================================
+ Coverage   87.58%   87.6%   +0.01%
=========================================
  Files          38      38
  Lines        4390    4397       +7
  Branches      334     330       -4
=========================================
+ Hits         3845    3852       +7
+ Misses        524     523       -1
- Partials       21      22       +1

Impacted Files
Coverage Δ

src/tablefilter.js
92.07% <100%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5405e...f0c9a80. Read the comment docs.

:shipit:


#94 Add optimisation on emissions sensor.

Wait with merge until final tests have run (tonight).

Btw our emissions sensor is more fine-grained (15 minutes rather than 1 hour), so the schedules may take slightly longer to compute (more time steps).

One approach would be to adjust the horizon when using this optimization.


Native middleware

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time.
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with npm run test and lint the project with npm run lint and npm run prettier

Finished implementing the most requested frameworks' middlewares. It was a mess, but it works, so Idc.


Failed to add ruleset

!

duplicate of #38
I'll publish a new build

thanks @Thesola10

@Artemis-chan pls update the release message as you see fit

@Thesola10 already did 👍🏼


Q: sub-domains support?

Hi!
Thank you for your job! It's great!
Could you please approach me, how sub-domains could be supported?
Thanks

https://github.com/julienschmidt/httprouter#multi-domain--sub-domains


shacl validation

The ontologies are made general to not include too many restrictions (to prevent issues when creating the datasets). However, we would like to test the datasets, the current approach is using shacl.

What is the status with this branch @horstf ? Are you still working on that or should we assign someone else to the issue?

Hi, sorry for the late reply, so the integration into the dodo file you mentioned in the pull request is done as i see it. I'm not exactly sure what the next steps to do are but i can definitely continue to work on this issue. What more is missing for the shacl validation integration?


Add Dynamic Objects to Importer

Dynamic Objects IPs and Ports are provided by big tech companies, they can vary daily. Firewall Vendors seem to store these information in their own databases and provide them to the Firewall Managers via Internet.
Checkpoint
Distinguishes between Aplications (used in Service) and Updatable Objects (used in SRC and DST). I can't figure out how to get current ports for Applications or current IPs from Updatable Objects via API. The API call "show-updatable-objects-repository-content" returns "info-url" for each Updatable Object. This URL links to non-standardized documentation pages of the Internet Company. You can see this list online
https://support.checkpoint.com/results/sk/sk131852
Fortinet
Internet Services contain IPs and Ports. They are stored in the Internet Services Database https://www.fortiguard.com/services/isdb
You can get all names and IDs per API (see first payload) and get a full description with IPs and ports for each individual Internet Service (see second payload)
payload = {
        "id": 1,
        "method": "exec",
        "params": [
            {
                "data": {
                    "action": "get",
                    "resource": "/api/v2/monitor/firewall/internet-service-basic",
                    "target": [
                        "adom/<adom>/device/<device>"
                    ]
                },
                "url": "sys/proxy/json"
            }
        ],
        "session": mySessionId,
        "verbose": 1
    }

payload = {
        "id": 1,
        "method": "exec",
        "params": [
            {
                "data": {
                    "action": "get",
                    "resource": "/api/v2/monitor/firewall/internet-service-details?city_id=0&count=1000&country_id=0&id=327880&region_id=0&start=0",
                    "target": [
                        "adom/<adom>/device/<device>"
                    ]
                },
                "url": "sys/proxy/json"
            }
        ],
        "session": mySessionId,
        "verbose": 1
    }

could you also add sample results for the two API calls?


addon-info empty propType column

Describe the bug
The propType column is empty
Code snippets
Playing with the source code it looks that, in the PrettyProType.js file
const PrettyPropType = props => {
  const { propType, depth } = props;
  if (!propType) {
    return unknown;
  }

  const { name } = propType || {};

  if (propTypeComponentMap.has(name)) {
    const Component = propTypeComponentMap.get(name);
    return <Component propType={propType} depth={depth} />;
  }

  // Otherwise, propType does not have a dedicated component, display proptype name by default
  return {name};
};

when you do  const { name } = propType || {}; that's wrong because propType is a string, not an object
System:

OS: MacOS 10.13.6 (High Sierra)
Browser: Chrome Version 72.0.3626.28 (Official Build) beta (64-bit)
Framework: react
Addons: info
Version: 4.1.2

Additional context
I'm using Typescript

I noticed this today as well.

I'll create an PR (if that is even allowed--I need to check).

Already fixed: https://github.com/storybooks/storybook/blob/06e3e8da16bd04b8bf3f5399a41c7c7fc97eb089/addons/info/src/components/types/PrettyPropType.js#L40
Just needs to be released.


prefix rizzo_sailthru path with app name

I don't think adding dispatch dependency to the newsletter form is good choice, it's too difficult to maintain over time :-1:

ok, closing it


[MXNET-489] MKLDNN Pool test

Description
Add pooling operator test for MKLDNN integration
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Add pooling operator test for MKLDNN integration

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@zheng-da

the main change to the implementation code is that we are standardizing our API. I changed the method name from SetDataHandle to SetNewMem (and will change some other operators to same) to be consistent with our other operators. Also, we have two helpers (CreateNewMem / CommitOutput) to assist with our request type. It is not absolutely necessary here since we mainly want to support kWriteTo (for now) but the other operators have it as well.