Add extra user information when migrating release

It is similar with issues or comments to save original author and id on release when migrating from other git services.

@lafriks done.

Codecov Report

Merging #8331 into master will decrease coverage by <.01%.
The diff coverage is 13.79%.

@@            Coverage Diff             @@
##           master    #8331      +/-   ##
==========================================
- Coverage   41.66%   41.66%   -0.01%
==========================================
  Files         496      497       +1
  Lines       65524    65541      +17
==========================================
+ Hits        27303    27307       +4
- Misses      34704    34718      +14
+ Partials     3517     3516       -1

Impacted Files
Coverage Δ

models/migrations/migrations.go
1.3% <ø> (ø)
:arrow_up:

models/release.go
52.6% <ø> (ø)
:arrow_up:

modules/migrations/gitea.go
8.69% <0%> (-0.05%)
:arrow_down:

models/migrations/v98.go
0% <0%> (ø)

modules/migrations/github.go
83.85% <57.14%> (-0.5%)
:arrow_down:

models/repo_mirror.go
2.27% <0%> (-11.37%)
:arrow_down:

services/mirror/mirror.go
18.93% <0%> (-1.14%)
:arrow_down:

modules/log/event.go
64.61% <0%> (-1.03%)
:arrow_down:

models/repo_list.go
74.14% <0%> (+0.97%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f889967...d4904a1. Read the comment docs.


Fail to initialize ORM engine

I did an update from gogs 8.10 to 8.13. After copying my custom and data folder in to the gogs folder I got an error message:
[...s/routers/install.go:70 GlobalInit()] [E] Fail to initialize ORM engine: sync database struct error: Cannot add a NOT NULL column with default value NULL

I am using gogs with sqlite

There is 8.13 version available ?

0.8.13. Sorry, my fault

@angus-g Thanks，the problem is solved:grinning:

Fine. The solution of angus-g works. Thanks a lot

This issue is claimed to be fixed by merging #2262


WIP: Send cloudtrail logs to sumologic

I found a bug in this so it's probably not a sensible idea to merge this (yet).

This should be good to go now 🐐


Update EIP-7251 Contract Address

What was wrong?
The contract address of the system contract for EIP-7251 has been updated in the following PR:

https://github.com/ethereum/EIPs/pull/9127

How was it fixed?
The address has now been updated.
Cute Animal Picture

I've updated the branch to only include the change to EIP-7251 since the update to EIP-2935 is taking longer than expected, and the test changes for EIP-7251 have now merged to main in EEST.
I'll open a separate PR for the EIP-2935 changes.


[Info] Update smali/baksmali to 2.3

There's a new smali/baksmali version which support new dex format in particularo for android P

@superpoussin22 I update all dependencies.
But I don't think this will improve anything because jadx don't use smali for parsing dex files. For now smali lib used only in jadx-gui for show smali code.


Ruff 269 not supporting keep-runtime-drying

Fix #318 and generic issues wrt ruff 269 dropping keep-runtime-drying

Correctly link to #318


how to reduce the size of directory?

it need too many hours when training the model.how to solve it?

Hello @xumin2501, please try the newest code, with the newer api, it shall be faster.
Thanks,
Yu-Hsiang


More readable Solution for  Use an IIFE to Create a Module

i think this is more readable because we can create each functionality separate from the module .. later add it to the module

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason: Though your solution is just as valid, there is no real reason to change a working solution that is never seen by the end user.
Thank you and happy coding.


added String.regexEscaped

Returns an escaped string for inclusion in a regex pattern. See #879
Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 5.0.
[x] New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 688 tests, with 0 failures (0 unexpected) in 19.459 (21.170) seconds

:book:
tvOS: Executed 650 tests, with 0 failures (0 unexpected) in 3.679 (4.173) seconds

:book:
macOS: Executed 513 tests, with 0 failures (0 unexpected) in 3.963 (4.145) seconds

  Generated by :no_entry_sign: Danger

Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃

Sure, happy to help out!


Clicking on the downloaded Exe causes my windows explorer to crash

All I did was download the stable release and click on it to cut and paste it somewhere else and my windows explorer crashes like the exe is a virus attempting to prevent deletion. I'm sure there isn't any viruses in the exe but this is very concerning, I've never had this issue except with files containing viruses.

That sounds like more an issue with a broken explorer extension.
Neither viruses, which anything you've had this problem with isn't (true viruses haven't been common since the early 2000s), nor malware / trojans like you're more likely talking about can do anything to Explorer to prevent deletion if they haven't been run yet.
Especially not anything as complex as hooking specific actions performed on them.
Especially when that action is "cut" which doesn't actually DO anything to the file that's noticable to anything not already installed.
Any of those things, in the event of actual malware that had already been run, would probably wait for the paste target, leave it alone if it's not recycle bin, and move it somewhere like a temp directory silently if it even needed its original executable around any more (neither viruses nor other malware would, as the first would have already infected other executables and the second doesn't rely on some fixed-location original file being in place).
I suppose an older version of malware designed to detect newer versions could do this, but it would still be easier for it to just execute the new file silently to upgrade itself as soon as you clicked on it and not do anything suspicious like crashing explorer.
Bad explorer extensions or terrible third party anti-virus software could potentially do this along with tons of other software that's broken in some way or another and hooked something in explorer.  Windows event viewer will tell you the reason explorer actually crashed.


kscript --interactive does not resolve the variables defined inside .kts file

I am trying to repl connect to .kts file which is defined such
#!/usr/bin/env kscript

val myName = "Namig"

and it can not resolve it.
Here is the logs:

kscript --interactive test.kts
[kscript] Creating REPL
Welcome to Kotlin version 1.8.21 (JRE 11.0.12+0)
Type :help for help, :quit for quit
println(myName)
error: unresolved reference: myName
println(myName)

I am thankful in advance for your efforts and creating such a beautiful project which makes
my life easier when writing script.

I don't know if-- interactive mode was ever intended to resolve pieces of the code in the script. In my understanding, it is only for resolving dependencies and putting them into the scope of REPL. That functionality definitely works:

(code based on the example from README)


Pin 1.56 rust toolchain

Set absolute toolchain version for rust workflows
Checklist

[x] Change is covered by automated tests

@ilammy oh rust guru, does this change work for us?


[Spike] Verify if "disks are not removed during downscale" for AWS as well

Please take a look at #1574. We need to verify if the problem exists in AWS as well and create proper bug report when needed. :+1:

Tested on 2 different deployments (ubuntu+redhat) in AWS, and this issue doesn't exist - disks are properly removed. Taking this into account, I suggest we can close this issue.

@mum0l what is output of this task?

It looks like I missed some comment from @mum0l and it should be just verified and moved to DoD.

Unfortunatelly I cannot reproduce it now. What I did was simply downscale the app, and looked into gui + CLI if disks are removed.

Disks are removed properly during downscale.


#442: Add profiling support to CLIs

This addresses #442.

Merged, rerunning tests

Rebased and squashed to see if Codacy will be less confused...


Package Initialization Error

Diagnostics
Request: GET https://api.teletype.atom.io/protocol-version

Versions
Teletype version: v0.13.3
Atom version: 1.31.1
Platform: win32

Thanks for the report! I'm going to go ahead and close as a duplicate of #372 so you can subscribe there for updates if you'd like. If you can, please let us know if you're consistently seeing this error or if you saw it just once. It would also be useful to know if you access the internet via a proxy.


Type inference not 100% correct with ||

TypeScript Version:  2.3.2
Code
interface Foo {
    type: 'foo';
}

interface Bar {
    type: 'bar';
}

interface Else {
    type: any;
}

type Types = Foo | Bar | Else;

function getFoo(a: any): Foo | undefined {
    if (a.type === 'foo') {
        return a;
    }
}

function getBar(a: any): Bar | undefined {
    if (a.type === 'bar') {
        return a;
    }
}

function getElse(a: any): Else {
    return a;
}

function checkType(a: any) {
    return (
        getFoo(a) ||
        getBar(a) ||
        getElse(a)
    );
}

Expected behavior:
Hovering over checkType should show Foo | Bar | Else as return types.
Actual behavior:
Hovering over checkType shows Else as return types.

Foo and Bar are subtypes of Else. The type checker erases them as part of an optimization IIRC.
For the same reason for example "foo" | string will result in just string

@ajafff indeed. A nice way to see this in action is to write
type Types = Foo | Bar | Else;
type TypesType = Types['type']; // any

I see, thanks.


Update yajl_lex.c

added support for single-quote as string representer in JSON array(ex, [0,'myname','age'])

Both http://json.org/ and the ECMA JSON standard say that it's not valid to do this. I would suggest this patch not be accepted, or at least hidden behind a default-off flag.

A string is a sequence of zero or more Unicode characters, wrapped in double quotes, using backslash escapes.


Improve CI

build matrix - crypto backends x rust/hacspec
style check
generation of fstar (using hacspec v2) moved to #57

Resolved with #55


Ability to delete an image

Hey,
first of all thanks for the greatest image viewer!
As to the issue, I'd like a feature to delete an image we're currently browsing locally - or from the left pane. Right click, hotkey, through toolbar menu... doesn't matter. It's rather annoying having to locate the file from your disk again.

By default this has a keybinding is Shift+Delete.  Confirmation
will be asked for before deleting.  An attempt will be made to move
the file to trash/recycle bin if supported, and if that fails the file
will be deleted permanently. The confirmation dialog can be turned
off from the preferences dialog and from the confirmation dialog itself.
Deleting files from archives is not supported.
Also on Windows video files cannot be deleted while playing,
gstreamer seems to have it actively open.

Thank you! Works like a charm.


Typescript 4.7.3 bracketed class property compilation error strictPropertyInitialization:true

Bug Report
🔎 Search Terms
strictPropertyInitialization bracketed class property
🕗 Version & Regression Information
Typescript 4.7.3, 4.7.2
⏯ Playground Link
Playground link with relevant code
💻 Code
enum A {
  A = 'A',
  B = 'B'
}

class B {
  [A.A]: string;

  constructor() {
    this[A.A] = '1';
    this.A = '1';
    this['A'] = '1';
  }
}

🙁 Actual behavior
Compilation error:
Error: Property '[A.A]' has no initializer and is not definitely assigned in the constructor.
🙂 Expected behavior
Seems it should be compiled without errors.

Probably related to #45974 aka "Control-Flow Analysis for Bracketed Element Access".  Could you please edit your post to fill out the bug report template to help the TS team?

@RyanCavanaugh still not working
https://www.typescriptlang.org/play?ts=4.8.4#code/KYOwrgtgBAglDeBYAUFWUC8UDkNsBoU0AhTHY7FAXxRQGMAbAQwGcWpSlUoBtGAOhgBdAFxQWAFwBOASxABzANy1udAPYhJUsHQlqpACgCUCImigSAFjJZ9BQstgCM2ZdzRWbgxy7fmL1ra42A5Yzq5mNMhUQA

It works in nightly. You have the Playground set to a build that was produced before the PR was merged.


When using three finger to move between full screen applications, the reverser seems to unable to handle it

This is my personal config
Using two finger browsing web is fine

That reverses, scoring, but not other gestures


Fix path logging in aas_shell

Fixes logging in aas_shell  due to the backslashes in windows due to them also being an escape character in cprintf

Ignore the first commit, please. I noticed that it may be better to do this without changing the value of cmd

Shall we merge it as is?

Shall we merge it as is?

Yes, the last commit should be fine.

You mean "with the last commit", right? I cannot merge a single commit from a PR but the whole PR with all the commits in order.

Otherwise it shouldn't be a problem, as the code from the first commit is pretty much re-written.

I am not worried about the "mess" as long as the final code is efficient and tidy. The "mess" only shows the work.
So if you are happy with the code as is (i.e., after all the commits), then I can merge it.

I am not worried about the "mess" as long as the final code is efficient and tidy. The "mess" only shows the work.
So if you are happy with the code as is (i.e., after all the commits), then I can merge it.

Should be fine for merging then. Thanks.


'invalid data in items of array legs' when parsing openapi spec

Describe the bug
When parsing this openapi spec, get the following error and warnings:
Error
Unable to parse this part of your OpenAPI document:
invalid data in items of array legs
Reference(ref='#/components/schemas/OrderObject')

Warnings
Warning(s) encountered while generating. Client was generated, but some pieces may be missing

WARNING parsing GET /accounts/{account_id} within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id} (Path parameters do not match with path)

WARNING parsing DELETE /accounts/{account_id} within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id} (Path parameters do not match with path)

WARNING parsing PATCH /accounts/{account_id} within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id} (Path parameters do not match with path)

WARNING parsing POST /accounts/{account_id}/documents/upload within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id}/documents/upload (Path parameters do not match with path)

WARNING parsing GET /trading/accounts/{account_id}/account within accounts. Endpoint will not be generated.

Incorrect path templating for /trading/accounts/{account_id}/account (Path parameters do not match with path)

WARNING parsing DELETE /accounts/{account_id}/recipient_banks/{bank_id} within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id}/recipient_banks/{bank_id} (Path parameters do not match with path)

WARNING parsing GET /accounts/activities/{activity_type} within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/activities/{activity_type} (Path parameters do not match with path)

WARNING parsing GET /accounts/{account_id}/ach_relationships within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id}/ach_relationships (Path parameters do not match with path)

WARNING parsing POST /accounts/{account_id}/ach_relationships within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id}/ach_relationships (Path parameters do not match with path)

WARNING parsing DELETE /accounts/{account_id}/ach_relationships/{ach_relationship_id} within accounts. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id}/ach_relationships/{ach_relationship_id} (Path parameters do not match with path)

WARNING parsing GET /trading/accounts/{account_id}/orders within trading. Endpoint will not be generated.

Incorrect path templating for /trading/accounts/{account_id}/orders (Path parameters do not match with path)

WARNING parsing POST /trading/accounts/{account_id}/orders within trading. Endpoint will not be generated.

Incorrect path templating for /trading/accounts/{account_id}/orders (Path parameters do not match with path)

WARNING parsing DELETE /trading/accounts/{account_id}/orders within trading. Endpoint will not be generated.

Incorrect path templating for /trading/accounts/{account_id}/orders (Path parameters do not match with path)

WARNING parsing GET /trading/accounts/{account_id}/orders/{order_id} within trading. Endpoint will not be generated.

Incorrect path templating for /trading/accounts/{account_id}/orders/{order_id} (Path parameters do not match with path)

WARNING parsing DELETE /trading/accounts/{account_id}/orders/{order_id} within trading. Endpoint will not be generated.

Incorrect path templating for /trading/accounts/{account_id}/orders/{order_id} (Path parameters do not match with path)

WARNING parsing PATCH /trading/accounts/{account_id}/orders/{order_id} within trading. Endpoint will not be generated.

Incorrect path templating for /trading/accounts/{account_id}/orders/{order_id} (Path parameters do not match with path)

WARNING parsing GET /trading/accounts/{account_id}/positions within trading. Endpoint will not be generated.

Incorrect path templating for /trading/accounts/{account_id}/positions (Path parameters do not match with path)

WARNING parsing GET /accounts/{account_id}/documents/{document_id}/download within documents. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id}/documents/{document_id}/download (Path parameters do not match with path)

WARNING parsing POST /accounts/{account_id}/recipient_banks within funding. Endpoint will not be generated.

Incorrect path templating for /accounts/{account_id}/recipient_banks (Path parameters do not match with path)

To Reproduce

Run the command:
openapi-python-client  generate --url https://raw.githubusercontent.com/alpacahq/bkdocs/master/assets/openapi.yaml
See the terminal output

Expected behavior
No errors
OpenAPI Spec File
https://raw.githubusercontent.com/alpacahq/bkdocs/master/assets/openapi.yaml
Desktop (please complete the following information):

OS: macOS 11.5.1
Python Version: 3.9.7
openapi-python-client version: 0.10.5

Alright, I've reproduced the issue and figured out where it's coming from! OrderObject is a recursive schema that, unfortunately, isn't supported yet (see #466). There have been a few attempts to implement it but, alas, none of them have quite worked out.
It's definitely on the roadmap to fill that gap, but I have no idea when it'll get done.
The "good" news is that is only a warning (at least when I run it), so the rest of the client that is supported will be generated. Of course that's only good news if you don't need that particular schema 😅.
Sorry about that, I'm going to use this as an opportunity to make that error message a bit clearer.


Support for OpenTelemetry instrumentation grpc

Migrated from ApplicationInsights-Python
Hello, may I ask whether you could add support for grpc instrumentation? Thanks.
[1] https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-grpc
Current status:
This is not currently a estimated date at which point this will be added as part of the distro. However, you can still trigger the instrumentation yourself after calling configure_azure_monitor. For instance, SQLAlchemy is not a part of the distro, but you can still use it with the distro. See the associated sample here

Hi @jeremydvoss  and @lzchen , may I ask whether there is any plan to support this feature request? Thanks.
FYI, the provided link for sample here is broken.

@yli02
No immediate plans currently. Here is the updated link to the sample.

@lzchen , thanks for the info.
The following setup seems working fine with us so far.

configure_azure_monitor()

grpc_client_instrumentor = GrpcInstrumentorClient()
grpc_client_instrumentor.instrument()


Proposal: validate GBFS version 2.1-RC

case
https://gbfs.beryl.cc/v2/Cornwall/gbfs.json is a 2.1-RC feed.
online validation return :

Detected version 2.1-RC and validate with 2.0
Invalid GBFS feed
87 errors

documentation
https://github.com/MobilityData/gbfs/releases/tag/v2.1-RC

Released May 22, 2020.
MINOR release - Backwards compatible with v2.0
New features:

Add vehicle type definitions
Add geofencing, virtual station, and dockless support

Hello and welcome!
Best practice is to only use an RC feed if you are an early adopter of a feature and there is no official version yet. Once all the features in an RC are implemented, it becomes an official version. Bearing that in mind we don't validate release candidates if an official corresponding version exists. I would encourage Beryl to use v2.1 (or even better our latest version, v2.3!).
Hope that helps!

This v2.1-RC feed can now be validated by selecting version v2.1 in the dropdown. Thank you!

Link: https://gbfs-validator.mobilitydata.org/validator?url=https%3A%2F%2Fgbfs.beryl.cc%2Fv2%2FCornwall%2Fgbfs.json


Check if model is loaded

As improvement, I would prevent the user to use the playground of the service is the model is not loaded in memory, otherwise an user that click on the Open and try to chat right away with Mistral will have "Load failed" error.

Duplicated https://github.com/premAI-io/prem-app/issues/412


[NUCLEO_L0/DISCO_L0] Improvements

See détails in the different commits (sorry for all the "merge branch" commits but I still don't know how to squash them even with a rebase).
Tested pass with automated tests suite.

Resolved via https://github.com/mbedmicro/mbed/commit/bdaddafd92ba2b269c3dc33a2bd04ea404dd8656


[GSoc2024] Added labels in dataset_meta.json of widerface_dataset to solve import issue #7258 of opencv/cvat

Summary
To fix the Widerface import issue which is being caused due to the missing labels in the widerface_dataset of datumaro, dataset_meta.json file has been edited by adding the "face" label, which the CVAT is looking for during its import process. fix #7258 of opencv/cvat

How to test

This has been tested using the dataset wf_dataset1.zip
Checklist

[x] I submit my changes into the develop branch
- [ ] I have added description of my changes into CHANGELOG
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
[x] I have linked related issues

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2022 CVAT.ai Corporation
#
# SPDX-License-Identifier: MIT

Hi, thank you for sending the PR! Please fix the failing tests.

Thank you for contributing into the project! The next step is to update CVAT dependency on Datumaro.

@zhiltsov-max Could you please tell me what should I be doing next?

Please send a PR in CVAT that updates the sever dependencies here.

@zhiltsov-max I've created a PR for the cvat repo that updates the cvat depency on datumaro PR #7703.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 756

Questions ?
Please refer to the Backport tool documentation


Prevent HTMLization of the JS array @ events#new

Title. Basically preventing " from turning into "es, breaking the JS script

https://jfire.io/blog/2012/04/30/how-to-securely-bootstrap-json-in-a-rails-view/


RuntimeError: cannot schedule new futures after interpreter shutdown

Describe the bug
After Transcoding 100% there I getting this error attaching console screenshot also for your reference.
Expected behavior
After transcoding, it should be uploaded on my s3 account.
Screenshots
https://ibb.co/xCS7TyZ
Local machine (please complete the following information):

Windows 10 (21H1)
ffmpeg version 2021-09-05-git-a947098558-full_build-www.gyan.dev

I have downgraded Python 3.9 to Python 3.8 Now it is Working !
I have pulled the project I'll work on this case!

Describe the bug After Transcoding 100% there I getting this error attaching console screenshot also for your reference.
Expected behavior After transcoding, it should be uploaded on my s3 account.
Screenshots https://ibb.co/xCS7TyZ
Local machine (please complete the following information):

Windows 10 (21H1)
ffmpeg version 2021-09-05-git-a947098558-full_build-www.gyan.dev

Describe the bug After Transcoding 100% there I getting this error attaching console screenshot also for your reference.
Expected behavior After transcoding, it should be uploaded on my s3 account.
Screenshots https://ibb.co/xCS7TyZ
Local machine (please complete the following information):

Windows 10 (21H1)
ffmpeg version 2021-09-05-git-a947098558-full_build-www.gyan.dev

I have downgraded Python 3.9 to Python 3.8 Now it is working !
I have forked the project I'll work on this case!


Document UI configuration possibilities

How to configure for example header content, colours, fonts

See my PR for a beginning, I think CSS Variables, here variables.js is an easy way to go.

The following customizations can be made:

Changing the Logo, under src/components/header.js
Upload a new Logo under src/images
Changing the Fonts, upload under src/fonts, import and CSS-Changes at src/components/layout.js
Changing the Colors, take a look at src/styles/variables.js

Note to 4.:
There are no colors in the templates. We only use variables (src/styles/variables.js).
We use the following default colors / variables:
skoHubWhite: 'rgb(255, 255, 255)',
skoHubDarkGreen: 'rgb(15, 85, 75)',
skoHubMiddleGreen: 'rgb(20, 150, 140)',
skoHubLightGreen: 'rgb(40, 200, 175)',
skoHubThinGreen: 'rgb(55, 250, 210)',
skoHubBlackGreen: 'rgb(5, 30, 30)',
skoHubAction: 'rgb(230, 0, 125)',
skoHubNotice: 'rgb(250, 180, 50)',
skoHubDarkGrey: 'rgb(155, 155, 155)',
skoHubMiddleGrey: 'rgb(200, 200, 200)',
skoHubLightGrey: 'rgb(235, 235, 235)',
To change a color, the RGB values can be adjusted. HEX codes are also possible. The names of variables should only be changed if you use "search and replace" to adapt the names also in the templates.

Note to 3.:
We use fonts that are self-hosted.
If you want to change a font, please upload the new font to the src/fonts folder. You can get fonts from Google Fonts (download / free of charge).
Then you have to adjust the CSS at src/components/layout.js. First: Change the import-path at line 18 and following. Secondly: Change @font-face at line 80 an following. Third: Change the font-family in the body-tag, at line 125 an following. That's all.

@sroertgen Can you please take this?

@acka47
I will document this in the README.
Then we can integrate this into #185 to make it configurable via the config file.


Create direct.kodiVerse.json

Too bad the dev of this addon cant follow the basic Kodi addon ID requirements, no capital letters.


global this.state is not accessible inside renderContent or renderHeader in Accordion

Issue Description

As the title say , the global this.state is not accessible inside renderContent or renderHeader in Accordion
renderContent(item)
{
console.log(this.state.anyVariable);
// Red page error => Cannot read property 'anyVariable' of undefined
}
Expected behaviour
To log the anyVariable value
Actual behaviour
it see this.state as undefined !!
Is the bug present in both iOS and Android or in any one of them?
I only tested it inside IOS

I did not bind the function in the constructor , I gonna close it


Fix test for get_ticker

This test case was already written, but was overwritten by a test method with the same name later in the file.
Removing the duplicate test case revealed a functional test case with a single mistake.

Fixed by adding the missing region_code parameter and updating expected http json response.

Let me know if this was intentional.

seems like this conflicted with: https://github.com/tedchou12/webull/pull/148

seems like this conflicted with: https://github.com/tedchou12/webull/pull/148


error: TETRAHEDRON element is not marked for refinement.

Dear sir:
I load a 3D mesh from gmsh with all cells are tetrahedron.  I want to do a uniform refinement. but i got the following errors.
Verification failed: (tet->GetRefinementFlag() != 0) is false:
--> TETRAHEDRON element is not marked for refinement.
... in function: void mfem::Mesh::Bisection(int, const mfem::DSTable&, int*, int*, int*)
... at line 6587 of file: mesh/mesh.cpp

Can you post the code that you use to load the mesh and to refine it?

thanks, i have sucessfully resolved it.
  ifstream file;   file.open ("./input/cubic0.msh", std::ifstream::in);   Mesh *mesh = new mfem::Mesh();   mesh->Load	(file,1,1, true );


[SPARK-38775][ML] cleanup validation functions

What changes were proposed in this pull request?
1, remove unused extractInstances and extractLabeledPoints in Predictor;
2, remove unused checkNonNegativeWeight in function;
3, move getNumClasses from Clasifier to DatasetUtils;
4, move getNumFeatures from MetadataUtils to DatasetUtils;
Why are the changes needed?
to unify to methods
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing testsuites

@dongjoon-hyun  Ok, I will hold on this PR since its target version is 3.4

Thank you so much!

We can revisit this now. Rerun tests I think?

+1 for restarting. Thank you, @zhengruifeng and @srowen .

Sure, let me update this PR

Thanks all!


Make js assets comply to javascript strict mode

tl;dr

Replace yii = (function ($) { with window.yii = (function ($) { in assets/yii.js
This is not about adding "use strict;" to yii assets!

I'm currently implementing a build chain for my custom javascript modules in ES2015. I use browserify, babelify and minifyify to transpile, concat and minify all my scripts to a single file. I also want to include some bundled yii assets like yii.js or yii.activeForm.js.
Unfortunately yii.js is not strict mode compliant:
https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Strict_mode
This means, you can not concatenate it with other sources, that use "use strict;" somewhere - which is what browserify does. The main problem is, that yii.js uses an undefined variable in global scope:
yii = (function ($) { ...

This leads to Uncaught ReferenceError: yii is not defined in the browser. This could simply be fixed by doing this instead:
window.yii = (function ($) { ...

Alternatively a var could be added: var yii = ....  It's not required and not recommended that yii.js also gets a "use strict;" statement. This way the file can be used in both modes: strict and non-strict as it complies to both standards.
For the record: I've also opened an issue at browserify-shim, but I think this should rather be fixed on the yii side.

This is already fixed by #12584


[Only Test] codecov/codecov-action@v5

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

LGTM

The job Build / Coverage (master, Scala 2.13, Hadoop 3, JDK 17) (build_coverage.yml) has been suspended for 10 months now, as follows:

1.https://app.codecov.io/github/apache?search=spark

2.After clicking in above https://app.codecov.io/github/apache/spark

The last successful commit trigger was: 78f7c30

3.This job should have failed every day for the past 10 months, as shown below:
https://github.com/apache/spark/actions/runs/12410482233/job/34646325911

4.I think we need a repo type token (Repository upload token)
https://docs.codecov.com/docs/codecov-tokens#repository-tokens
We can obtain it from the following page: https://app.codecov.io/gh/apache/spark/config/general

5.After obtaining the token on the above page, we can make the following settings
ref:
https://docs.codecov.com/docs/codecov-tokens#using-your-token
https://docs.codecov.com/docs/codecov-tokens#using-your-token

6.But unfortunately, I do not have the corresponding permissions, as follows:

So, who can help me configure step 5? @HyukjinKwon @zhengruifeng @dongjoon-hyun

Also, I think we can fix the issue with codecov/codecov-action@v4 first and then consider upgrading.

PR submitted for fixing codecov/codecov-action@v4 as: https://github.com/apache/spark/pull/49251


Remove unused pre-msi jdk code

Codecov Report

Merging #639 into master will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   95.66%   96.04%   +0.37%
==========================================
  Files          28       28
  Lines        2401     2500      +99
  Branches      202      199       -3
==========================================
+ Hits         2297     2401     +104
+ Misses        104       99       -5

Impacted Files
Coverage Δ

browser/model/jdk-install.js
100% <ø> (ø)
:arrow_up:

browser/services/platform.js
86.39% <0%> (-0.38%)
:arrow_down:

browser/model/installable-item.js
100% <0%> (ø)
:arrow_up:

browser/model/cygwin.js
100% <0%> (ø)
:arrow_up:

browser/services/componentLoader.js
100% <0%> (ø)
:arrow_up:

browser/pages/start/controller.js
100% <0%> (ø)
:arrow_up:

browser/pages/location/controller.js
100% <0%> (ø)
:arrow_up:

browser/directives/pathValidator.js
100% <0%> (ø)
:arrow_up:

browser/pages/install/controller.js
100% <0%> (ø)
:arrow_up:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86e11f...2b0ce2a. Read the comment docs.


Want to apply sampling only to traces with spans that match multiple conditions

I am currently creating a sampling rule to use refinery in production. I created the following rule to exclude health checks against my_server.
[ds]

	Sampler = "RulesBasedSampler"

	[[ds.rule]]
		name = "drop healtchecks"
		drop = true
		[[ds.rule.condition]]
			field = "http.target"
			operator = "="
			value = "/health-check"

However, unintentionally all the traces like below were dropped.

The reason is that the rule traverses all spans and applies the rule if it matches the given condition. In this case, my_server uses the health check endpoint of my_server2.
I have added a condition to the rule to fix this.
[ds]

	Sampler = "RulesBasedSampler"

	[[ds.rule]]
		name = "drop healtchecks"
		drop = true
		[[ds.rule.condition]]
			field = "trace.parent_id"
			operator = "not-exists"
		[[ds.rule.condition]]
			field = "http.target"
			operator = "="
			value = "/health-check"

However, due to the logic I mentioned earlier, such a trace would be dropped.
Is there a way to set up the filter that "the filter is applied to the traces that contain at least one span that matches the n conditions" rather than "given n conditions, if the trace contains n spans that match the condition, apply the filter". If not, I would appreciate if you support this.

Hi @sozuuuuu
Thanks for creating the issue. I'm not sure how we'd work around this, I'll check with some other folks who are better versed in setting up more complicated rule sets and report back.

Hi @sozuuuuu - I'm sorry for the delay in getting back to you, we've been really busy the past few weeks.
Have you found a workaround for the issue?

FWIW, this is also something we'd like to be able to do. For context, we have a number of microservices logging to a single dataset in Honeycomb, and we use the rules-based sampler to sample these services. These services sometimes interact with each other: we often see traces that start at service A and then make calls to services B, C, D, etc.
These services can see dramatically different load levels between them, and we'd like to be able to sample per-service – it would be hard to accurately and predictably account for differing request volume with a single across the board sampling setting.
What we'd like to be able to do is something like:

For traces originating at service X, sample at 10
For traces originating at service Y, sample at 100
...

The issue noted above makes this difficult – it's not easy to confidently identify "Traces originating at service X" or "Traces originating at service Y". Our first attempt was something like:
[[dataset.rule]]
  name = "service X traces"
  SampleRate = 100
  [[dataset.rule.condition]]
  field = "meta.span_type"
  operator = "="
  value = "root"
  [[dataset.rule.condition]]
  field = "service_name"
  operator = "="
  value = "X"

If this rule were only satisfied if both conditions were satisfied by a single span, we'd be able to do what we want. As written, the rules-based sampler effectively makes the first condition (matching a root span) a no-op (some span within any trace should be the root span, barring errors), leaving only the second condition. By itself, service_name = X is too broad – it will match traces originating at service X, but also traces originating elsewhere that happen to call service X at some point.
If we were able to add an attribute to a rule telling refinery that it needs to be evaluated per-span (and not per-trace), I think that would help us do what we want. For example:
[[dataset.rule]]
  name = "service X traces"
  SampleRate = 100
  MatchSpan = true
  [[dataset.rule.condition]]
  field = "meta.span_type"
  operator = "="
  value = "root"
  [[dataset.rule.condition]]
  field = "service_name"
  operator = "="
  value = "X"

MatchSpan = true could tell refinery that each of the conditions needs to match the same span in a trace for the rule to be matched. If that setting is false (or omitted), we get the current behavior.
I hacked together a quick proof of concept of how this could look in code. Not sure if this is something you're interested in. It does add a fair amount of complexity to the rule sampler, so I could see why it wouldn't be desirable. I'd be happy to polish up that MVP a bit and open a PR if it is something you'd consider incorporating in refinery, though.

Hey - thanks for the write up and proof of concept @isnotajoke.
I like the general idea of introducing a rule property to require all conditions match a single space instead of any span within the trace. We would be interested in exploring this further if you're willing to create a PR and we'll help where we can.

Thanks @MikeGoldsmith ! I'll polish that up and submit it as a PR when it's ready.

Fixed by #440. A new release will be processed soon.


Entypo import not working

import IconVector from 'react-native-vector-icons/Entypo';
And "filter" icons shows nothing.
I have configured packages.json like this.
"rnpm": { "assets": [ "fonts" ] },
And copied relevant ttf files to fonts folder.
And did run react-native link
Still not working. Please help me

Have you tried following the troubleshooting guide:
Make sure you've copied the font to android/app/src/main/assets/fonts.
Delete the android/app/build folder.
Recompile the project.
This worked for me. Good luck!

Well, the font files already exist in that path.
'react-native-vector-icons/FontAwesome';
This works fine but other fonts are not imported.
Please help me who has similar experience and solution.

Suspect this if fine with modern RN and auto linking


ipfs-pack tutorial

@flyingzumwalt Wanna update the install portion to mention that we have pre-built binaries now?
Also, maybe name the tutorial files something like 01-something.md so that they stay in order on the filesystem? (just a nitpick)
Also, even if this isnt 100% done i think we can merge it just to get it out and into peoples hands :)


"kill switch" support

Please add support for a "kill switch".
Previously, the typical implementation of the "kill switch" was to configure iptables to only let through the traffic routed over the IP address of the VPN gateway. If the VPN connection broke, iptables prevented the traffic from going over the normal network interface.
(If I've missed it - or it is provided otherwise - please close the ticket (with explanation).)

Reddit thread has some fresher ideas. UFW can be used. And in context of WireGuard: the WG has the PostUp/PreDown actions which facilitate "kill switch" implementation:
https://www.reddit.com/r/WireGuard/comments/bpmssc/configuring_wireguard_with_a_kill_switch/

This is not as easy as it looks.  For example, we can not use UFW as that would force people to install UFW to manage the firewall and that would just be abusive towards people running distributions that come by default with alternatives to UFW.
These scripts do not aim to provide a substitute for the PIA Desktop applications, which have been designed with kill switch and split tunnel. The idea is to provide a baseline that people can use and adapt to their own requirements. For battle-tested security, please use the Desktop applications.
Because each system is different, this repo will become confusing and over-complicated very fast if we start adding:

killswitch
split tunneling
autostart on boot
compatibility for exotic platforms

That is why we encourage people to fork this repo and accommodate the scripts to their requirements. If their versions are well written, we can add those versions to the 3rd Party section in the README.
My current opinion is that we should close both this ticket and also https://github.com/pia-foss/manual-connections/issues/62, as supporting this for everybody is just not possible. I will think over the next weeks if there is any way to adapt this to the code in this repo without making the code complicated and hard to understand.

You can use "iptables" for the kill switch. This is a generic Linux tool. That would be also a great demo on how to do it, since it would be abstract enough, and familiar to all. Many ways to do it doesn't mean you need to implement all possible ways. Most generic way would be fine.

As useful the scripts are, they still require high level of expertise in the VPN software/setup. Correct configuration of "kill switch" is simple - if you understand/know what you need to do. Even minor mistakes might lead to problem and leakage of traffic. (I'm noob. In the past I've spent nearly 2 weeks making kill switch working correctly - and now (since PIA changed everything again) I need to repeat that experience again. (Worse, now you don't support Ubuntu VPN anymore, leaving a lot of gaps to fill.))

As complexity goes, the code is more than OK. It's shell, and you can always run it with "-x". The problem is the quirky interfacing between PIA backend and local VPN daemons. It's hard to know what is done why: is it required by backend? is it required by the VPN daemon? or is it required for something else entirely? I.e. don't mix up "code hard to understand" with "subject matter hard to understand". There are lots lots more shell experts than VPN/PIA experts.

P.S. Re Desktop app. I haven't tried it recently, but in the past it was obscenely "user friendly", i.e. exclusively GUI, and not even copy-paste supported everywhere. (For most automation, I don't mind GUI running. But some do.)
If PIA desktop software supported few basic command line command (start, stop, status & query of forwarded ports) that would have been a great & easy option too. (I.e. configure it once in the GUI, then start/stop it from the scripts.) In the past I've asked PIA support about some basic command line support for the desktop client, but received flat out rejection.

@g00nix I have tried standard "desktop" client & found that (despite flat out rejection ~2 years ago) it now supports the command line interface (to manage the UI). So at least me and my use-cases appear to be covered. (I stopped using headless systems for VPN after few screw-ups with my "killswitch".) If no-one else is interested, then the ticket could be closed. Otherwise, I would suggest to document (or at least mention) that desktop client now support management via command line (piactl connect, piactl get portforward).

Awesome ideas! Thank you! I will add this to the roadmap for 2021!


Remove listeners for newer services when conflicts occur.

This PR adds the CreationTime to the service struct and populates it
in the k8s service registry. When available, services will be sorted
by their creation time. Conflicts will cause the listeners for newer
services to be dropped.
Partial fix for #5992

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [costinm,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@rshriram @costinm PTAL

@rshriram

You definitely need to add creation time for service entries (externalservices in the service registry, as well as cloudfoundry/consul. Otherwise, the logic you have in listeners will fail)

Let me send out a PR to update the API repository.

@rshriram @costinm I've created https://github.com/istio/api/pull/579 to add creation_timestamp to the ServiceEntry proto.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [costinm,nmittler]
pilot/OWNERS [costinm,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Actually, looking closer to the external service registry, I'm not convinced that we need the new field on ServiceEntry.  I may be able to make the change

@rshriram I've added support for external services.  Let me know the change is sufficient.

You don't need any API changes.. This is purely code change

Let's break things up - separate PR for the VirtualService and the others is fine, iterate.
Lint errors and we can merge (and get it into the hand of people testing).
Maybe we can default the timestamp in the entry to the time it is first seen, if nothing else is available.
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [costinm,nmittler]
pilot/OWNERS [costinm,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wrong branch! rebase to release-1.0

Closing .... will create a new PR against the release-1.0 branch.


Swift example should call completion handler

Swift example for receiving notifications in README:
func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
    print(userInfo)
}

I think this violates the documentation for this callback which says

As soon as you finish processing the notification, you must call the block in the handler parameter or your app will be terminated.

I would suggest immediately calling the completion handler with .newData.

Fixed in 254e6b7


With regards to jquery

Are you going to be leaving jquery as a dependency for the project? I have not used ng2 but ng1's approach was to more or less leave it out.

Yes i am planning to use it because SUI depends on it, it would be really great to rewrite everything on vanilla js with use of ngAnimation.

Hello. Could you specify necessary jquery version as peer dependency of this project? This way when it is installed with npm, developer will be notified to resolve peer dependency. Thanks!

pretty sure it works with jQuery 1.12.4. maybe create a fork to pull request with this
"peerDependencies": {
    "jquery": "1.12.x"
  }

Semantic UI requires jQuery 2.1.4, please use that version for optimal performance.
Putting it as peerDependencies is not bad option at all.

If it works on 2.1.4 it should by default work with 1.12.4 with just more browser support

Ok, that have sense.
I will update documentation regarding that.

I tested ngSemantic with jQuery slim version ( https://code.jquery.com/jquery-3.0.0.slim.min.js ) without success.

I would love to see a jquery free version of this. We're using bootstrap 4 now, but SUI is something I'm really considering but jquery is a tough pill to swallow.

That would take a big amount of time since all directives are wrappers around SUI's jQuery call.


Invalid Swift Support - after deliver to testflight

Bitrise Build Issue Report template
Description of the issue
I Receive: Invalid Swift Support - The SwiftSupport folder is missing. Rebuild your app using the current public (GM) version of Xcode and resubmit it.
From itunesconnect after delivery to testflight.
Environment:
Using: XCode 8.1.x MacOS 10.12 (Sierra)
Plugin for deployment to TestFlight:
Deploy to iTunes Connect / TestFlight (with Deliver)
EMBEDDED_CONTENT_CONTAINS_SWIFT is set to YES for all configurations
Reproducibility

Does a "Rebuild" help? (You can trigger a rebuild from the Build's page, by clicking the "Rebuild" button in the top right corner of a finished build) : NO

Does a rebuild without caches help? (You can remove the Cache:Pull and Cache:Push steps temporarily to not to use the cache, or you can delete all the caches on the Settings tab of the app. : NO

If it's an issue which happens sporadically, what's the frequency? (e.g. Once a day ; about x% of the builds) : always

Does upgrading the build Step to the latest version help? : NO

When did the issue start? : 05.12.2016

Linux/Android stack builds
Can it be reproduced by running the build locally, after doing a clean git clone (git clone the repository, into a new directory, somewhere on your Mac/PC) and running the build from there with the Bitrise CLI ( https://www.bitrise.io/cli )? If no, can it be reproduced with Docker (using the same docker images / environment we use on bitrise.io)? Related guide: http://blog.bitrise.io/2016/08/08/debug-your-android-linux-builds-locally-with-docker.html .
Not reproduced locally
Other stacks
Can it be reproduced by running the build locally with our CLI ( https://www.bitrise.io/cli ), after doing a clean git clone (git clone the repository, into a new directory, somewhere on your Mac/PC) and running the build from there with the CLI ( https://www.bitrise.io/cli )?
Build log
Please attach the build log (you can download the build log from the build's page,
once the build is finished, using the "Download log" button - floating at the bottom right corner of the log viewer),
or if you can't attach the whole log then send the full log through a private channel (e.g. email - https://www.bitrise.io/contact ), with a link to the related GitHub issue.
Relevant part of the build log:
+------------------------------------------------------------------------------+
| (6<EMAIL_ADDRESS>                                                    |
+------------------------------------------------------------------------------+
| id: xcode-archive                                                            |
| version: 2.0.3                                                               |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: go                                                                  |
| time: 2016-12-06T02:17:17-08:00                                              |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[02:17:17]  * [OK] Step dependency (xcode) installed, available.
INFO[02:17:17]  * [OK] Step dependency (go) installed, available.

ipa export configs:
- ExportMethod: ad-hoc
- UploadBitcode: yes
- CompileBitcode: yes
- TeamID:
- UseDeprecatedExport: no
- ForceTeamID:
- ForceProvisioningProfileSpecifier:
- ForceProvisioningProfile:
- ForceCodeSignIdentity:
- CustomExportOptionsPlistContent:

You specified Export Method ad-hoc in the Xcode Archive step.
App Store / iTunes Connect / TestFlight only accepts app-store signed builds.
Simply change the export method option in the Xcode Archive step to app-store (and of course supply the required app store signing files if you did not do that before).
After that it should work.

I've tried with app-store also. Same issue. AppStore provision profile and
certificate are added to bitrise.
2016-12-06 13:19 GMT+02:00 Viktor Benei<EMAIL_ADDRESS>
You specified Export Method ad-hoc in the Xcode Archive step.
App Store / iTunes Connect / TestFlight only accepts app-store signed
builds.
Simply change the export method option in the Xcode Archive step to
app-store (and of course supply the required app store signing files if
you did not do that before).
After that it should work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bitrise-io/build.issues/issues/22#issuecomment-265125410,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABucEFGvxrqHYGde7e25ufqVe0j4YYUjks5rFUSygaJpZM4LFSAK
.

--
Best regards,
Kirill Kirikov

Please attach a build log where the build is signed with App Store signing

Also, did you try to upload from Xcode.app? It might also be a configuration issue in your Xcode project, e.g. "Received the same message from Apple and fortunately fixed it just changing the Embedded Content Contains Swift Code to No." (source: http://stackoverflow.com/a/38633504/974381)

I'll close this issue due to lack of information, but if you can reply to my previous questions @KiriKiri we'll reopen it!


feat(#477): rich-text-editor-and-apply

IMPORTANT: Always create an issue before a PR and provide enough information so that others can review

Explain the details for making this change.
What existing problem does the pull request solve?

Test plan (required)
Demonstrate the code is solid.  Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Closing issues
List all issues this PR resolves

closes #477

Pre-Merge checklist
Complete these items before requesting reviews

[x] Static Analysis Rules Validated
[x] All commits follow naming conventions

Sub-tasks Checklist

[x] UI Implementation
[x] UI Test
[x] Backend Implementation
[x] Backend Tests
[ ] Integration Tests
[ ] System Tests
[ ] Documentation

@danseremet @a-drew made the changes have a look

great job on the rework, I'll let dan finish the review.


Receive STX: Updates

Receive STX: tab/group

[x] The Copy Address Buttons need to be operational.
[x] Show History of Mainnet and Testnet as collapsible areas through out the Wallet.
[x] Present Mempool Tx's relative to Testnet and Mainnet as pending Transactions

moving QR code todo to Beta Milestone Issue


[Feature request] bounded with equality (ie [low, high] rather than (low, high))

It would be great to add an option to bounded so that it supports interval constraints with equality.
Current behaviour:
julia> bounded(0., 0., 1.)
ERROR: ArgumentError: Value, 0.0, outside of specified bounds (0.0, 1.0).
Stacktrace:
 [1] bounded(val::Float64, lower_bound::Float64, upper_bound::Float64)
   @ ParameterHandling ~/.julia/packages/ParameterHandling/QaqXk/src/parameters_scalar.jl:54

This would be nice, but I'm not sure how you could achieve this in practice. Do you have any thoughts?

(The reason that we only support open intervals at the minute is because the bijections that we use map the bounds to -Inf and Inf )

Agree - I've just had a look at the code for how it's currently implemented, and it's tricky to see how we'd adapt it to this. I'll have a think.


larval protocerebral bridge definition

Need to reconcile competing defs.  Each appears to have useful information.  e.g. new def has lineage information and information about tracts and relationships to other domains (compartments) but clear statement of what this domain is part_of and doesn't mention that in two unfused halves.
Would be good to nail down the mix of primordial and differentiated chracteristics:  differentiated vs undifferentiated neurons.
From @fewtrem:
PB: Protocerebral Bridge
Previously included in the CPM compartment.
Formed from the DPMm1 and DPMpm1/2 and CM4 lineages, this small tubular-like primordium is
shaped like a dorsally convex crescent, attached to the posterior surface of the IPp compartment.
Turning anterior-medially, it connects to its contralateral counterpart right posteriorly of the
PLPC(DPLp1) commissure and Fan-shaped Body.
[Pereanu2010 https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2905803/]
Current FBbt term:
embryonic/larval protocerebral bridge primordial: "The primordium of the adult protocerebral bridge in the larval brain. It consists of bilaterally symmetrical tubular shaped region containing both differentiated and undifferentiated synapses, in the posterior inferior protocerebrum (IPp or CPM). It curls around the dorsal side from the posterior, growing during the larval period towards the midline. Fusion of the two halves only occurs at 48h after pupariation." [FlyBase:FBrf0210156 = Young, J.M., Armstrong, J.D. (2010)]
SubClassOf: 'synaptic neuropil domain'
SubClassOf: 'primordium
'part of' some 'embryonic/larval posterior inferior protocerebrum'
obsoleted FBbt term:
larval protocerebral bridge: Synaptic neuropil domain of the third instar larval brain that is the precursor of the adult protocerebral bridge. Unlike in the adult, this exists as a pair of separate domains that do not join across the midline. Each has an arched shape, and segmentation is only barely discernible."  [FlyBase:FBrf0210156 = Young, J.M., Armstrong, J.D. (2010)]
comment "This term has been obsoleted because it refers to the same structure as 'embryonic/larval protocerebral bridge primordial' (FBbt:00111206) [FBC:MMC]. mc160810"

@fewtrem.  Comments please.

embryonic/larval protocerebral bridge primordial
"The primordium of the adult protocerebral bridge in the larval brain, formed from the DPMm1 and DPMpm1/2 and CM4 lineages.  It consists of bilaterally symmetrical tubular shaped region containing both differentiated and undifferentiated synapses, attached to the posterior surface of the posterior inferior protocerebrum (IPp). It curls around the dorsal side from the posterior, growing during the larval period towards the midline. Fusion of the two halves only occurs at 48h after pupariation, right posteriorly of the PLPC(DPLp1) commissure and Fan-shaped Body." [FlyBase:FBrf0210156 = Young, J.M., Armstrong, J.D. (2010)]
[Pereanu2010 https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2905803/]
SubClassOf: 'synaptic neuropil domain'
SubClassOf: 'primordium
'part of' some 'embryonic/larval posterior inferior protocerebrum'


Generalization of real vs synthetic

Hi,
I have a confusion about '4.1 Training on ModelNet40' in main paper, where indicates 'training is done on ModelNet40 and testing is done on ScanObjectNN ... '. I wonder that when train the networks on ModelNet40, how many classes in training set ? 40 classes in original ModelNet40 dataset or 11 common classes listed in table 1 in Supplementary Materials.
Thanks

I figure out the problem. Thanks.

Great!


Add feature-gated support for defmt::Format

Supports defmt::Format operating with the types in this driver. This is especially useful for outputting Errors. To enable operating with defmt, set the feature "defmt" in the dependency.

coverage: 88.71% (-0.09%) from 88.8%
when pulling a4fb8aa64cb7972134d0e6a5e621e23b57a1907e on Radiator-Labs:master
into 3a222c4e7e7a37efd6514624d812af90ed545556 on eldruin:master.

Changes have been made. I chose not to add doctest examples in lib.rs, as I do not know how to enable the feature within the doctest context. Since usage is basically like anything else that derives debug or format, this is a pretty trivial usage. Hopefully the example in the readme is sufficient.


Rebaseline tests and remove those that need to be fixed

Once https://github.com/LLNL/serac_tests/pull/18 is merged, the heat transfer changes will go away from this PR's diff

Question: are these results already within the old tolerances?

Question: are these results already within the old tolerances?

That's a good question.. It shouldn't be hard to do a search and replace for the field names and see if they pass.

I tested the old tolerances by doing the following:

serac: checked out my integration tests pr https://github.com/LLNL/serac/pull/1067
serac_tests: checked out to the current serac_tests on develop https://github.com/LLNL/serac_tests/tree/52028ec9c912418b2952b9d8ce6c7801ab6ec64c

cd <serac_repo>/tests/integration
find . -type f -name *.json | xargs sed -i 's/temperature/serac_temperature/g'
find . -type f -name *.json | xargs sed -i 's/velocity/serac_velocity/g'
find . -type f -name *.json | xargs sed -i 's/adjoint_displacement/serac_acceleration/g'
find . -type f -name *.json | xargs sed -i 's/displacement/serac_displacement/g'

create a new serac build
make -j
salloc -N2 -Aeng --exclusive -t30 -ppbatch ats.sh

This was the result:
ATS SUMMARY April 17, 2024 17:59:46
FAILED:  24
tolerance_test(dyn_direct_solve_serial),
tolerance_test(dyn_direct_solve_parallel),
tolerance_test(dyn_solve_serial),
tolerance_test(dyn_solve_parallel),
serac(qs_direct_solve_serial),
serac(qs_direct_solve_parallel),
serac(qs_linear_serial),
serac(qs_linear_parallel),
serac(qs_solve_serial),
serac(qs_solve_parallel),
serac(thermal_expansion_serial),
serac(thermal_expansion_parallel),
tolerance_test(dyn_exp_solve_serial),
tolerance_test(dyn_exp_solve_parallel),
tolerance_test(dyn_imp_solve_serial),
tolerance_test(dyn_imp_solve_parallel),
tolerance_test(dyn_imp_solve_restart_serial),
tolerance_test(dyn_imp_solve_restart_parallel),
tolerance_test(dyn_imp_solve_time_varying_serial),
tolerance_test(dyn_imp_solve_time_varying_parallel),
serac(static_reaction_exact_serial),
serac(static_reaction_exact_parallel),
tolerance_test(static_solve_serial),
tolerance_test(static_solve_parallel)
PASSED:   34
SKIPPED:  10

Some of the tests are supposed to be commented out, so really these are the ones that fail:

dyn_direct_solve
dyn_solve
dyn_exp_solve
dyn_imp_solve
dyn_imp_solve_restart
dyn_imp_solve_time_varying
static_solve

Some notes:

I'm assuming adjoint_displacement = serac_acceleration?
serac_temperature_rate appears to be new and therefore cannot be tested

Closing in favor of this new PR: https://github.com/LLNL/serac_tests/pull/21
It was easier for me to start fresh, since I'm now using the old baselines and changing these as needed - rather than rebaselining everything.


[QUES] How to mock Ffmpeg module for testing

Here is the code i used to mock FFMpeg by using dependency injection
$this->instance(
    Frame::class,
    Mockery::mock(Frame::class, function (MockInterface $mock) {
        $mock->shouldReceive('save')
            ->andReturn( $mock );
    })
);

$this->instance(
    MediaVideo::class,
    Mockery::mock(MediaVideo::class, function (MockInterface $mock) {
        $mock->shouldReceive('frame')
            ->andReturn( resolve(Frame::class) );
    })
);

$this->instance(
    FFMpeg::class,
    Mockery::mock(FFMpeg::class, function (MockInterface $mock) use($user, $file) {
        $videoPath = "videos/{$user->id}/{$file->hashName()}";
        $mock->shouldReceive('open')
            ->with( storage_path("app/{$videoPath}") )
            ->andReturn( resolve(MediaVideo::class) );
    })
);


Generic Oracle Refactor

Closes #1056 & #1019
Refactor exchange rate oracle service to a more generic oracle service. This should be achieved by:

Add additional OracleSources similar to coingecko and coinmarketcap modules
Extend OracleSource trait to be generic over OracleInfo
Extend MetricSource trait to be generic over MetricsInfo
Refactor traits to include associated types for trait functions outputs
The goal is to untie the dependancies at first to exchange rates. Then allow for other oracles such as a weather oracle to be easily added. Then to adapt the old exchange rate oracle code to this new more generic framework.

Hi @murerfel. It still isnt done. I need to refactror more and need comment removals etc but just wanted to open up. If there is anything glaring that jumps out let me know. Ill comment here and tag you when I feel it is ready ready passing all tests etc


Revise list of schools to distinguish between enrolled schools and eligible schools

On the list of schools page, distinguish between schools that are enrolled and those that are just eligible (initially all local primary schools, eventually all B&NES schools).
There should be a strong visual indicator, suggest splitting the page into:

Participating schools (list of cards as it is now)
Eligible schools as a separate, less prominent list further down the page.

closed by PR#61


error while starting the docker container: unsatisfied condition: cuda>=10.2

After proceeding with the installation of the nvidia-toolkit my result of this command shows:

docker run --gpus all nvidia / cuda: 9.0-base nvidia-smi

------------------------------------------------- ---------------------------- +
| NVIDIA-SMI 418.87.01 Driver Version: 418.87.01 CUDA Version: 10.1

but when proceeding with the commands:
Install commands:
wget -N https://raw.githubusercontent.com/opendatacam/opendatacam/v3.0.0-beta.2/docker/install-opendatacam.sh
chmod 777 install-opendatacam.sh
./install-opendatacam.sh --platform nvidiadocker

when finished downloading give me:
Error response from daemon: Cannot restart container opendatacam: OCI runtime create failed: container_linux.go: 349: starting container process caused "process_linux.go: 449: container init caused " process_linux.go: 432: running prestart hook 0 caused \ \ "error running hook: exit status 1, stdout:, stderr: nvidia-container-cli: requirement error: unsatisfied condition: cuda> = 10.2, please update your driver to a newer version, or use an earlier cuda container \\ \ n \\ "" ": unknown

the image is installed but I can't start the container correctly
- the result of command nvidia-smi on my computer are:
~$ nvidia-smi
Wed May 13 23:57:36 2020
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 418.87.01    Driver Version: 418.87.01    CUDA Version: 10.1     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GT 750M     On   | 00000000:08:00.0 N/A |                  N/A |
| N/A   54C    P8    N/A /  N/A |    279MiB /  2002MiB |     N/A      Default |
+-------------------------------+----------------------+----------------------+

the results of nvcc --version :
$nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2017 NVIDIA Corporation
Built on Fri_Sep__1_21:08:03_CDT_2017
Cuda compilation tools, release 9.0, V9.0.176
With Cuda 9 and GeForce GT 750M compatibility 3.0 is it possible to install opendatacam?

With Cuda 9 and GeForce GT 750M compatibility 3.0 is it possible to install opendatacam?

I honestly don't know. Could you try to install latest CUDA 10.2 ?
I had put some guide back in the days that might help you:
https://developer.nvidia.com/cuda-downloads
https://github.com/opendatacam/opendatacam/blob/master/documentation/nvidia-docker/INSTALL_NVIDIADOCKER.md#22-install--update-nvidia-driver

Hi tdurand, I gave up on installing using a docker and installed it directly on the computer. It is likely that I made a mistake in installing the nvidia docker or my nvidia driver is not compatible with the latest nvidia toolkit. After installing directly on my computer, I was able to install opendatacam and now I am using it correctly. Congratulations on creating this tool.

great ! thanks


test_invalid_utf8: Use distinct if/else branches

pytest isn't able to report the expected value when using the X if Y else Z syntax.
See pytest-dev/pytest#7727

Forcing an error does show the expected reporting:
===================================================================================================== FAILURES =====================================================================================================
________________________________________________________________________________________________ test_invalid_utf8 _________________________________________________________________________________________________

vim = <pynvim.api.nvim.Nvim object at 0xb608d1f0>

    def test_invalid_utf8(vim):
        vim.command('normal "=printf("%c", 0xFF)\np')
        assert vim.eval("char2nr(getline(1))") == 0xFF
        if IS_PYTHON3:
            assert vim.current.buffer[:] == ['\udcff']
        else:
            assert vim.current.buffer[:] == ['\xff']

        vim.current.line += 'x'
        if IS_PYTHON3:
            assert vim.eval("getline(1)", decode=False) == '\udcffx'
>           assert vim.current.buffer[:] == ['\udcffxy']
E           AssertionError: assert ['\udcffx'] == ['\udcffxy']
E             At index 0 diff: '\udcffx' != '\udcffxy'
E             Full diff:
E             - ['\udcffx']
E             + ['\udcffxy']
E             ?          +

test/test_buffer.py:175: AssertionError

Guess I didn't need to force a failure to see how this looks.  Python 2 tests are failing and probably have been since they were added:
    def test_invalid_utf8(vim):
        vim.command('normal "=printf("%c", 0xFF)\np')
        assert vim.eval("char2nr(getline(1))") == 0xFF

        if IS_PYTHON3:
            assert vim.current.buffer[:] == ['\udcff']
        else:
>           assert vim.current.buffer[:] == ['\xff']
E           AssertionError: assert [''] == ['\xff']
E             At index 0 diff: u'' != '\xff'
E             Full diff:
E             - [u'']
E             + ['\xff']

Note that assert 1 == 2 if 0 else 3 does not fail, but only assert 1 == (2 if 0 else 3)..!?

Distinct branches are good for code coverage though anyway.

I'm not sure what the correct behavior is supposed to be for Py2.  @Shougo or @bfredl, can you advise?

the correct default behaviour in python2 should be no decoding, i e get the raw '\xFF' byte out (and no unicode string)

the correct default behaviour in python2 should be no decoding

Maybe you can push the right changes to my branch?  I'm not familiar with the pynvim APIs.

Closing in favor of #492, which rips out the py2 code, thus getting rid of the bug.


1.12.0-beta1 keybinding resolver resolves ctrl+backspace to ctr+delete

Description
With v1.12.0-beta1, using a keyboard with standard swedish layout, it seems as if ctrl+backspace is bound to the wrong action, even if defined properly in the keymaps file.
(This worked in the latest stable release AFAIK.)
Steps to Reproduce

Download latest beta releas https://github.com/atom/atom/releases/tag/v1.12.0-beta1
Toggle keybinder resolver Ctrl+Period
Type Ctrl+backspace
Observe that it says Editor:delete-to-end-of-word
Open the keymaps file by clicking the link in the keybinder resolver bar
Search for ctrl-backspace
Observe that it says Editor:delete-to-beginning-of-word

Expected behavior:

keymaps and keybinder resolver information matches
ctrl+backspace is bound to Editor:delete-to-beggining-of-word

Actual behavior:

keymaps and keybinder resolver information does not match
ctrl+backspaceis bound toEditor:delete-to-end-of-word`

Versions
$ atom --version
Atom    : 1.12.0-beta1
Electron: 1.3.6
Chrome  : 52.0.2743.82
Node    : 6.3.0

$ apm --version
apm  1.12.5
npm  3.10.5
node 4.4.5
python
git 2.8.1.windows.1
visual studio 2015

Can you reproduce this in safe mode atom --safe?
Have you checked the contents of your keymap.cson.

Also if you can upload a screenshot of your keybinding resolver that would be great.

@Ben3eeE

Yes, it's reproducable in atom --safe
The keybinding resolver links to a win32.cson file in my AppData folder, cannot find a keymap.cson. The contents of the keymaps seems correct to me (see reproduction step 5-6-7)

Also if you can upload a screenshot of your keybinding resolver that would be great.

This actually made me realize that the bug is with the keybinding resolver, because it resolves to ctrl-delete when I am hitting ctrl-backspace!

Interesting, Ctrl-Backspace resolves correctly for me on Atom 1.12.0-beta1, Swedish layout, Windows 7.
Do you have any more information that can help reproduce this? Can you try the latest stable release and check if it resolves correctly there? Does Backspace without Ctrl resolve correctly? What about other modifier keys like Alt or Shift

I am using Windows 10
all keys with modifiers (including ctrl) seems to work, except ctrl-backspace which maps to ctrl-delete
Installed 1.11.1 and it works as expected (ctrl-backspace is bound properly)

windows version 1607 (OS-version 14393.321)

$ atom --version
Atom    : 1.11.1
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0

$ apm --version
apm  1.12.5
npm  3.10.5
node 4.4.5
python
git 2.8.1.windows.1
visual studio 2015

Thank you so much for reporting back, I have successfully reproduced this.
It seems to happen depend on the state of the Num Lock, Caps Lock and Scroll Lock keys.
 Please let me know if you're still having problems with backspace.

This should be fixed in 1.12.0-beta2, which was just published. Please let me know if you're still having problems with backspace.

I can confirm that it is working as intended. Thanks for fixing it so fast.


fix: getMissingItemLabelFn issues with null and change detection

Pull Request Test Coverage Report for Build 816571269

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 93.75%

Totals

Change from base Build 813678635:
0.2%

Covered Lines:
916

Relevant Lines:
956

💛  - Coveralls


Please publish a new npm patch release to fix jcenter with this already commited fix

👋🏽 I read about the state of the project maintainers wise.
If you guys have some time, could you deploy a 5.2.1 with this fix? (Before 6.0.0)
https://github.com/react-native-video/react-native-video/commit/fd821d2c5cb9d2bc8d52396250993f965886b567
In the current state, the project does not work on android without this simple fix and it may look broken for new users.
If it's too time consuming, maybe pinning an issue telling users to install the repo with the master branch would be beneficial.

you can try this PR #2795

5.2.1 published, let me know if it is OK


The donut diagram on sidebar is too big on sub-pages in narrow windows

The donut diagram on sidebar is too big on sub-pages in a narrow window, as below:
https://user-images.githubusercontent.com/17035406/216651170-71d2aa5d-1155-4de0-a0db-2b19cf592d5b.mov
Applying CSS there may help with this issue:
https://github.com/ELIXIR-Belgium/elixir-toolkit-theme/pull/145#issuecomment-1415987301
(Thanks, @bedroesb, for pointing out the lack of CSS!)

Closing this issue since we decided that we can live with this for now.


[nrf noup] allow link metrics series for all children

Thread Conformance document requires a Link Metrics Subject to
support at least one active link metrics serier per attached SED.
Signed-off-by: Eduardo Montoya<EMAIL_ADDRESS>

Is this really noup, i. e. no need to fix this upstream?


Adding cloudsuite graph analytics benchmark

Thanks for the pull request. I took a pass and added comments. It also looks like there are some merge conflicts that will need to be resolved. It may be good to rebase your local branch and push the new version to GitHub with -f option.

I fixed all the bugs, including the merge conflict.
Can you take another pass?

Thanks, I took another pass. Just a few style comments from me. Depending on the timing between this and #931, there may be merge conflicts in benchmark_sets.py, so look out for that. Since I've moved off the team responsible for merging code, I'm going to request @hildrum take a look at this. Let her know when you have made the changes and want this merged in.

Thank you very much @skschneider.
Hi, @hildrum, I applied all the suggestions, you can merge this changes if they are ok.

Thanks!


Replace the osm files by osm-testdata

The osm files in the test directory have a license incompatible with Apache.
We could replace them with osm-testdata which has a public license.
https://github.com/osmcode/osm-testdata/tree/master
This is also an opportunity to test the osm parsers more systematically.

Closed by #816


CAMEL-13626: Change camel-parent with camel-bom in examples

Sorry, I forgot you're a committer now :-(

No problems :).


Add a new page with statistics

This PR adds a new page to gather various statistics about Fink data. It contains 3 tabs:

heatmap
daily statistics
timelines

A fourth one will join later concerning TNS confirmed data.
Heatmap
The Heatmap tab shows the number of alerts processed by Fink for each night
since the beginning of our operations (2019/11/01). The graph is color coded,
dark cells represent a low number of processed alerts, while bright cells represent
a high number of processed alerts.

Daily statistics
The Daily statistics tab shows various statistics for a given observing night. By default,
we show the last observing night. The first row shows histograms for various indicators:

- Quality cuts: difference between number of received alerts versus number of processed alerts. The difference is simmply due to the quality cuts in Fink selecting only the best quality alerts.
- Classification: Number of alerts that receive a tag by Fink, either from the Machine Learning classifiers, or from a crossmatch with catalogs. The rest is "unclassified".
- External catalogs: Number of alerts that have a counterpart either in the MPC catalog or in the SIMBAD database.
- Selected candidates: Number of alerts for a subset of classes: early type Ia supernova (SN Ia), supernovae or core-collapse (SNe), Kilonova, or Solar System candidates.
You can change the night by using the dropdown button

The second row shows the number of alerts for all labels in Fink (from classifiers or crossmatch).

Since there are many labels available, do not hesitate to zoom in to see more details!

Timelines
The Timelines tab shows the evolution of several parameters over time. By default, we show the number of
processed alerts per night, since the beginning of operations.

You can change the parameter to show by using the dropdown button. Fields starting with SIMBAD: are labels from the SIMBAD database. Note that you can also show the cumulative number of alerts over time by switching the button on the top right :-)

REST API
If you want to explore more statistics, or create your own dashboard based on Fink data,
you can do all of these yourself using the REST API. Here is an example using Python:
import requests
import pandas as pd

# get stats for all the year 2021
r = requests.post(
  'https://fink-portal.org/api/v1/statistics',
  json={
    'date': '2021',
    'output-format': 'json'
  }
)

# Format output in a DataFrame
pdf = pd.read_json(r.content)

Note date can be either a given night (YYYYMMDD), month (YYYYMM), year (YYYY), or eveything (empty string).

Feedback ;)

Separate total stats from daily on the top panel. A bar? different colour?

Daily statistics page stats could also be cool for the total stream

For the daily statistic a lot of feedback. Would by more descriptive in titles, rearrange the order (see image to get a sense of the order of processing in the pipeline) and add relative percentages (most of us will look directly at percentages)..... Selected candidates plot may benefit from a log scale.

Thanks!
header
I am not a huge fan of vertical rule:

I can enclose the two first stats that are daily ones:

Total stream

Daily statistics page stats could also be cool for the total stream

I do not understand what you mean :-(
Daily stats
title
Would by more descriptive in titles --> OK
Order
I do not think showing plots in the order of processing in the pipeline makes sense to users. The current order goes from more data to less data: who gets selected -> who get classified (in the general sense of having a label) -> who is already known from catalog -> who is candidates
Percentage
OK I would add percentage inside the bars, but I would keep numbers as well in the axes.
Candidates
Selected candidates plot may benefit from a log scale --> Right!

Note for daily stats, the histogram at the bottom is not only SIMBAD -- it is all labels in Fink. But because we have so many, they are not all shown from the default view. You need to select a region to zoom in, and many other labels (incl. Fink ones) would appear.

Happy with a square around daily stats!
"Daily statistics page stats could also be cool for the total stream" Meaning we can have also a tab with the statistics from the whole data we have processed, same items just more data.
I like the order because that's very useful to explain how things work but won't be strongly against yours.... but more info in titles is necessary
and yes, keep numbers but just to a dd percentages that gives a good first glance!
Thanks!


[web] Logging dart.developer.postEvent is spammy in non-Chrome browsers

This is not a big deal in Chrome, these logs are invisible by default. You can only see them if you enable "Verbose" logging:

But in other browsers (e.g. Safari), the verbose logs are visible and there's no way to hide them:

Duplicate of https://github.com/flutter/flutter/issues/75225


⚠ ClamAV has degraded performance

In 872a4b4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in b7cf254 after 5 minutes.


ProDOS 2.4.2: fix VCB-related bug that got fixed early in 2.5

Description
Make sure that all P8 2.5 VCB fixes are ported back to 2.4.3
Expected Behavior
Actual Behavior
Possible Fix
Steps to Reproduce

Context

Your Environment

Hardware:

ProDOS8 version:
Non-Operating System release software being used:

Fixed in 2.4.3


Messages are dropped in pipeline if no working endpoints

	// Send puts the message on the outbound send.  It always succeeds,
	// unless the buffer(s) are full.  Once the system takes ownership of
	// the message, it guarantees to deliver the message or keep trying as
	// long as the Socket is open.
	Send([]byte) error

The guarantee to deliver the message or keep trying is false if WriteQLen is > 0.
assuming I send two messages "foo" "bar" to an unresponsive endpoint. I expect two failures,
instead I get 1.
package main

import (
	"fmt"
	"log"
	"os"
	"time"

	"github.com/gdamore/mangos"
	"github.com/gdamore/mangos/protocol/push"
	"github.com/gdamore/mangos/transport/ipc"
	"github.com/gdamore/mangos/transport/tcp"
)

func die(format string, v ...interface{}) {
	fmt.Fprintln(os.Stderr, fmt.Sprintf(format, v...))
	os.Exit(1)
}

func NewPool(urls ...string) mangos.Socket {
	var sock mangos.Socket
	var err error
	if sock, err = push.NewSocket(); err != nil {
		die("can't get new push socket: %s", err.Error())
	}

	sock.AddTransport(ipc.NewTransport())
	sock.AddTransport(tcp.NewTransport())

	sock.SetOption(mangos.OptionWriteQLen, 1)
	for _, url := range urls {
		if err = sock.Dial(url); err != nil {
			die("can't dial on push socket: %s", err.Error())
		}
	}
	return sock
}

func Send(s mangos.Socket, msgs ...string) {
	for _, msg := range msgs {
		s.SetOption(mangos.OptionSendDeadline, 100*time.Millisecond)
		if err := s.Send([]byte(msg)); err != nil {
			log.Println(msg, "failed:", err)
		}
	}

	if err := s.Close(); err != nil {
		log.Println("Failed Close", err)
	}
}

func main() {
	Send(NewPool("tcp://<IP_ADDRESS>:8080"), "foo", "bar")
}

$ ./bin/failure
2016/01/07 11:18:43 bar failed: send time out

So, with a non-zero queue depth, we will queue the messages immediately, even if there is no where for them to get.  The message is still dropped on the floor, but there is no notification back to the app.  This is the drawback of using a non-zero queue depth.
The comment does need to be fixed though.

Actually, the comment is right.  Going back it does exactly what it says.
The message fails immediately if the queue is full, otherwise the system queues it for later delivery, and will keep attempting to deliver the message ~forever.  Basically, the queue length is the size of a channel, and we leave the message in the channel.
There is a special exception made for messages that have a deadline.  In that case, we may later discard the message instead of delivering it, if we find that the message's deadline has expired.  Again this occurs without notification to the app.
The comment can be clarified somewhat to make this easier to understand.

I think the documentation should further expanded to describe how to achieve reliable delivery (i.e. set to 0 queue length to 0), I'll whip up a PR for this.
Not sure I agree that the comment was correct. But I understand what you are getting at.
It would be nice for there to be an error on Close if there are messages left in the channel. i.e. shutdown the network connections and len(c).
This behaviour exists leads me to question if the transports are properly cleaned up prior to the Close function returning. I'll read the code for that later.

It would be nice for there to be an error on Close if there are messages left in the channel. i.e. shutdown the transport connections and len(c).

@james-lawrence - I agree. There should be some sort of error returned specifying that there is data still waiting to send. For example, if I have a push socket and there is no pull socket connected, the push socket will lose data if it closes after the timeout.
A more reasonable approach after calling Close() on the socket would be to return some sort of error (or the data left in the queue) after the timeout, so that the consumer of the mangos api can do something with the data instead of just losing it forever.
@gdamore - I'm curious how other people handle gracefully closing a socket so they don't lose data. Does setting sock.SetOption(mangos.OptionWriteQLen, 0) prevent this problem?


Expose core mods from backend to frontend

Hmm, for that we need to signal core mods from backend to front-end. I don't think we have something for that yet... :/

Originally posted by @GeckoEidechse in https://github.com/R2NorthstarTools/FlightCore/pull/110#discussion_r1054898148

Without a need for signals, this is more a problem of code sharing between frontend and backend.
I think we should explore automatically building Typescript types, using a tool like https://github.com/Aleph-Alpha/ts-rs

I think we should explore automatically building Typescript types, using a tool like https://github.com/Aleph-Alpha/ts-rs

Once #140 is merged which uses ts-rs, we could create a global const vector and expose that via ts-rs I think. Alternatively if that doesn't work the fall back would be to have a function call that returns the list of core mods.

Turns out you cannot use ts-rs for global consts. It's only for structs (which makes sense I guess). I think it'll make most sense to a have a call into backend that fetches the list of consts where necessary.

Actually, the only place where we declare some const a second time is in https://github.com/R2NorthstarTools/FlightCore/blob/a7e28562bb64e800f30b4f82a942ece2284b4121/src-vue/src/plugins/store.ts#L249 which is planned to be replaced with a call to backend anyway... ^^


Android Device crash happened on first time app launch.

Stack trace
Crash happening on Real Android device only at very first time app launch.
We also used code push integration : https://github.com/microsoft/react-native-code-push
Please let me know if any more clarification needed
React native SDK Details:
"@datadog/mobile-react-native": "^1.8.5",
"@datadog/mobile-react-navigation": "^1.8.5",

Crash logs:
com.facebook.react.bridge.NoSuchKeyException: nativeLongTaskThresholdMs

at com.facebook.react.bridge.ReadableNativeMap.getValue(ReadableNativeMap.java:113)
at com.facebook.react.bridge.ReadableNativeMap.getValue(ReadableNativeMap.java:117)
at com.facebook.react.bridge.ReadableNativeMap.getDouble(ReadableNativeMap.java:154)
at com.datadog.reactnative.DdSdkConfigurationExtKt.asDdSdkConfiguration(DdSdkConfigurationExt.kt:20)
at com.datadog.reactnative.DdSdkImplementation.initialize(DdSdkImplementation.kt:56)
at com.datadog.reactnative.DdSdk.initialize(DdSdk.kt:30)
at java.lang.reflect.Method.invoke(Native Method)
at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:188)
at com.facebook.jni.NativeRunnable.run(Native Method)
at android.os.Handler.handleCallback(Handler.java:900)
at android.os.Handler.dispatchMessage(Handler.java:103)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
at android.os.Looper.loop(Looper.java:219)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228)

Reproduction steps
No response
Volume
50
Affected SDK versions
1.8.5
Latest working SDK version
not sure
Does the crash manifest in the latest SDK version?
Yes
React Native Version
0.71
Package.json Contents
No response
iOS Setup
No response
Android Setup
No response
Device Information
All android device
Other relevant information
No response

Hi @bgrajesh57, thanks for reaching out!
Did you recently update the version of the SDK?
The error message you are sharing could mean that the native layer of your app is indeed running @datadog/mobile-react-native version 1.8.5 but the javascript layer is running an older version.
This could be the case if you upgraded the SDK but didn't bump the version number of your app. In this case, codepush bundles still using the older version of the SDK could be used on the JS side, which could explain the issue.
You should be able to fix this by either bumping the version of your app or removing old bundles on codepush.
Let me know if that solves your issue!

Hi @louiszawadzki I didn't update datadog sdk recently also we are using code push lib version is
react-native-code-push": "8.1.0"

Should i required to update latest version  ?
https://github.com/DataDog/dd-sdk-reactnative/releases/tag/2.1.1
I have bump app version when app installed I can see latest bundle. the problem is very first time app install its crashed
let me know  any other thoughts
Thanks

@bgrajesh57 thanks for clarifying this!
Could you share how you initialize the SDK?
Can you also share if any change was made to the configuration in one of the codepush bundles?
Does any particular change seems to have triggered this issue?
Thanks a lot :)

Hi @louiszawadzki  Thanks for the inputs,
Something we have to do with code push implementation form our end. so closing this.
Many thanks !!!


Use extends instead of manual merge

This requires package users to install eslint-config-airbnb as a dependency, which is unfortunate, but less hacky.

 Will fix.

This makes sense.


Link failed builds in job failure message

Link the top 3 failed builds in job failure notification message.
This makes triaging easier and immediately going to the failed
job console.

/lgtm

May want to do a test run after merge


Destroy mutex on subchannel destruction

This is needed for tools that check for lock order inversions.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Docker.ping() + LocalDockerITCase

Implemented Docker.ping(), added the first integration test + build profile for integration tests.

Pull Request Test Coverage Report for Build 40

3 of 10 (30.0%) changed or added relevant lines in 3 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.4%) to 30.921%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/com/amihaiemil/docker/RtDocker.java
2
5
40.0%

src/main/java/com/amihaiemil/docker/UnixSocket.java
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/com/amihaiemil/docker/UnixSocket.java
4
16.28%

Totals

Change from base Build 38:
1.4%

Covered Lines:
94

Relevant Lines:
304

💛  - Coveralls

@rultor merge it

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)


Fix warning notice

Fix the warning notice shown with WP_DEBUG/WP_DEBUG_DISPLAY enabled.
"Notice: Function wp_register_script was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks. This notice was triggered by the elementor-hcaptcha-api handle."
Call the register_scripts() function using the right way for Wordpress.

Thank you for this! I will update the README.


Fix do_server() socket from remaining open after naccept is supposed to reach 0

When -naccept is passed to s_server, the listening socket remains open while handling clients, even after naccept is supposed to reach 0.
This is caused to to the decrementation of naccept and closing of the socket happening a little too late in the do_server function.
This causes a weird behaviour where clients can still connect to the server, but will never be handled (instead of just getting rejected by the OS).
Fixes https://github.com/openssl/openssl/issues/26229.

@mattcaswell WDYT?

Unfortunately this is is larger than what can be accepted with CLA: trivial. Could you please sign a CLA?
https://openssl-library.org/policies/cla/index.html

@t8m As requested, I have signed a CLA.
I have also rebased this commit and removed the CLA: trivial line from the commit message.

Rebased.


Video not playing due to CORS issue

I am playing a video using Plyr and getting this issue-
Failed to load http://--video url --: Redirect from 'http://--video url --' to 'https://--video url --' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://admin.lc' is therefore not allowed access.
One the frontend, I am using BackboneJS and CoffeeScript. Any idea how to fix that?

That’s nothing to do with Plyr. That’s an issue with your server configuration. You only need the crossorigin attribute if you’re hosting captions on a different origin.
Sam

On 15 Aug 2018, at 3:00 am, mlearncore2018<EMAIL_ADDRESS>wrote:
I am playing a video using Plyr and getting this issue-
Failed to load http://--video url --: Redirect from 'http://--video url --' to 'https://--video url --' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://admin.lc' is therefore not allowed access.
One the frontend, I am using BackboneJS and CoffeeScript. Any idea how to fix that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

is there a way to bypass this?


Load UCX libs explicitly

What
Fix SIGSEGV issue when JVM calls malloc
Why ?
UCX should be initialized in the main thread to avoid collisions with JVM when malloc/mmap hook is registered.
How ?
Load the UCX library once UCX shuffle manager is created.

@yosefe @petro-rudenko Could you help me to review the code change? Thanks.