Backport Sonatype publishing and datatypes module for v0.3.x

Backports #394, #406, and #391

/ok-to-test

@ches these flaky tests are driving me crazy. Meeting with the team this week to see if we can find the root cause.

I think this pull request makes the javadoc-plugin runs on every build hence errors in our Javadoc will cause Maven build and CI to fail.
I think the current failure is due to these lines:
https://github.com/ches/feast/blob/36ea2394454f5dede1087c31ec640cea38675ed6/core/src/main/java/feast/core/service/SpecService.java#L144
We should encode <, > characters in Javadoc as < and > respectively
https://github.com/ches/feast/blob/36ea2394454f5dede1087c31ec640cea38675ed6/core/src/main/java/feast/core/service/SpecService.java#L85
@param GetFeatureSetRequest should be @param request
I found that by looking at full log output

@davidheryanto how do we bubble up these problems through the logs without having to click on the full build log? Is the exit code being ignored at the build stage?

Thanks @davidheryanto for digging out the cause.

I think this pull request makes the javadoc-plugin runs on every build hence errors in our Javadoc will cause Maven build and CI to fail.

Indeed #394 added the Javadoc plugin bound to the jar goal, so when end-to-end tests run mvn package that is triggering. That PR also fixed the doc formatting issues but some of the docs changed completely with functional changes on master, so I excluded them from the cherry-pick.
An end-to-end test phase is a frustrating time to fail on malformatted Javadoc… (and generating them is a bit of a waste of time outside of release preparation). Perhaps we can do something like:

For tests, run mvn package with -Dmaven.javadoc.skip
Worry about Javadoc cleanup at release preparation time, automated in a release build

Or if you'd like for contributors to maintain error-free Javadoc proactively:

Run some type of Coding Standards check early in the build steps, including invoking a goal from the Javadoc plugin
For tests, run mvn package with -Dmaven.javadoc.skip

Javadoc skip could be enabled by default in the root build, and disabled in a release profile.
(Aside: I've noticed Spotless formatting check isn't happening currently, because it defaults to verify phase and CI doesn't go that far—been meaning to raise this elsewhere, it could fall under such a fail-fast standards check).
Let's take that discussion to a separate issue, I'll fix the straggler HTML encoding issues here momentarily to get CI green for this one.

/retest

Investigating the failure will take me some time—I don't want to shirk that responsibility, but before I spend it can anyone quickly recognize it as something that has been fixed on master that I should maybe pull in? Because it seems unlikely to me that it's a regression introduced by this branch, GitHub doesn't seem to show that status checks passed on the latest commit on v0.3-branch.
To save you a click, it's a single failure in the bq-batch-retrieval.py suite, the test_get_batch_features_with_file case:
>   assert output["entity_id"].to_list() == [int(i) for i in output["file_feature_set_v1_feature_value"].to_list()]
E   TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

bq-batch-retrieval.py:90: TypeError

The print statement of the dataframe in question shows:
  file_feature_set_v1_feature_value
0                              None
1                              None
2                              None
3                              None
4                              None

I think it is due to missing wait after running Feast apply.
I hope this will fix that.
https://github.com/gojek/feast/pull/412

/retest

I'll bring #406 into this PR as we discussed there, but I would really like to get #391 closed first.

Thanks @davidheryanto for digging out the cause.

I think this pull request makes the javadoc-plugin runs on every build hence errors in our Javadoc will cause Maven build and CI to fail.

Indeed #394 added the Javadoc plugin bound to the jar goal, so when end-to-end tests run mvn package that is triggering. That PR also fixed the doc formatting issues but some of the docs changed completely with functional changes on master, so I excluded them from the cherry-pick.
An end-to-end test phase is a frustrating time to fail on malformatted Javadoc… (and generating them is a bit of a waste of time outside of release preparation). Perhaps we can do something like:

For tests, run mvn package with -Dmaven.javadoc.skip
Worry about Javadoc cleanup at release preparation time, automated in a release build

Or if you'd like for contributors to maintain error-free Javadoc proactively:

Run some type of Coding Standards check early in the build steps, including invoking a goal from the Javadoc plugin
For tests, run mvn package with -Dmaven.javadoc.skip

Javadoc skip could be enabled by default in the root build, and disabled in a release profile.
(Aside: I've noticed Spotless formatting check isn't happening currently, because it defaults to verify phase and CI doesn't go that far—been meaning to raise this elsewhere, it could fall under such a fail-fast standards check).
Let's take that discussion to a separate issue, I'll fix the straggler HTML encoding issues here momentarily to get CI green for this one.

I prefer the latter option so that we proactively maintain error-free docs.
Are we happy to move this to an issue?

/lgtm
/approve

Are we happy to move this to an issue?

Sorry I didn't update my comment, but I created one already at #408.
I will bring the changes from #406 into this branch as part of the backport, just wanting to get #391 through first. We can mark this PR on hold in the meantime.

/lgtm

Are we happy to move this to an issue?

Sorry I didn't update my comment, but I created one already at #408.
I will bring the changes from #406 into this branch as part of the backport, just wanting to get #391 through first. We can mark this PR on hold in the meantime.

Oh damn, I didn't see there were new comments here. I already did an /lgtm so the merge went ahead.
Can we use a separate PR for that?

Oh damn, I didn't see there were new comments here. I already did an /lgtm so the merge went ahead.
Can we use a separate PR for that?

I already cherry-picked in the squash of #406 here so we're good with that. The only open part was my question to David just above from the last commit I tacked on. If we need any change for that I'll open a new PR.

Oh damn, I didn't see there were new comments here. I already did an /lgtm so the merge went ahead.
Can we use a separate PR for that?

I already cherry-picked in the squash of #406 here so we're good with that. The only open part was my question to David just above from the last commit I tacked on. If we need any change for that I'll open a new PR.

Ok, in that case it should be fine I think!


Non numeric node IDs

This would be infinitely more practical if I could add nodes and edges by unique string ID rather than numbers.
For example, G6 graph visualization library works exclusively with string IDs.

Here's my attempt so far. I'll put it in a helper package if I get my project working correctly.
This seems to work ok until I try using the BellmanFord algorith on a larger graph (hundreds of nodes and edges)....
const g = createWeightedDiGraph([
    ['btc', 'usd', -Math.log(20549.38), -Math.log(1/20549.38)]
]);

function createWeightedDiGraph(edgeInfo) {
    const labels = edgeInfo.reduce((acc, [n1, n2, weight]) => {
        const indices = [acc.symbolMap[n1], acc.symbolMap[n2]];

        if (indices[0] === undefined) {
            const i = indices[0] = acc.symbolArray.length;
            acc.symbolMap[n1] = i;
            acc.symbolArray.push(n1);
        }
        if (indices[1] === undefined) {
            const i = indices[1] = acc.symbolArray.length;
            acc.symbolMap[n2] = i;
            acc.symbolArray.push(n2);
        }

        return acc;
    }, {symbolMap: {}, symbolArray: []});

    //edgeInfo.forEach(())

    const g = new jsgraphs.WeightedDiGraph(labels.symbolArray.length);

    edgeInfo.forEach(([n1, n2, weight, rweight]) => {
        const i1 = labels.symbolMap[n1],
              i2 = labels.symbolMap[n2];

        if (weight !== undefined) {
            console.log('adding edge', n1, '->', n2, '(', weight, ')');
            g.addEdge(new jsgraphs.Edge(i1, i2, weight));
        }
        if (rweight !== undefined) {
            console.log('adding edge', n2, '->', n1, '(', rweight, ')');
            g.addEdge(new jsgraphs.Edge(i2, i1, rweight));
        }

        g.node(i1).label = n1;
        g.node(i2).label = n2;
    });

    return {g, labels};
}


Asking for the model checkpoint

Hi,
Thank you for your work.
I clone your repo and ran the training for V1M dataset.
However, I only got 0.46597322821617126/0.6202007253741613 for IoU/F-score.
It is quite much lower than the results you reported on the paper.
Can you please clarify this?

Hi, please make sure you open the visual backbone with adapter for tuning. Last six layers should be enough. If you not sure, you can print out the trainable parameters' name here.


Tickscript not write zeros when no data exist for data batch query

URL for relevant page?

What products and version are you using?
Chronograf Version: 1.7.14
Influxdb Version     : 1.7.8
Kapacitor Version     : 1.5.2
Where did you look before opening the issue?
Influxdata doc and many websites with similar topic.
Issue
I have this tickscript:

var outputDB = 'chronograf'
var outputRP = 'autogen'
var outputMeasurement = 'ADTopupCost'
var triggerType = 'alerta'
var message = ' {{.Time}} {{.TaskName}} {{.ID}} {{.Name}} {{.Level}} {{ index .Fields "value" }}'
var data = batch
|query('SELECT SUM(operation_cost) as topupCost FROM "telegraf"."autogen"."TransformTimestampTOPUP" WHERE operation_code='RC' and user_code='GCM'')
.offset(20m)
.period(5m)
.every(5m)
.align()
.groupBy(time(5m), *)
.fill(0)
|first('topupCost')
.as('topupCost')
var trigger = data
@ADTopupCost()
trigger
|influxDBOut()
.create()
.database(outputDB)
.retentionPolicy(outputRP)
.measurement(outputMeasurement)
.tag('triggerType', triggerType)
The result espected is what the tickscript write zeros in the outpub measurement when no data is in the source table and field selected.
The real result is:
When any of the intervals selected has value (Ej: 24567, 0,0,0,0) the zeros was writed in the output. But when intervals selected not has any value, this present error: "No result" instead of answer all intervals whit zeros(Ej: 0,0,0,0,0).
Can anybody help me whit this?

@wvxi This issue is specific to Kapacitor and should be filed on the Kapacitor repository. I'm transferring it there.


fix the issue about join param

The reason that the original code fails is that this is not binded to u object.

Awesome! I didn't see it, thanks


Create fr_CA.lang

Here you go. There's not a lot of changes (at least for now), but I think that's always a cool thing for users to have the choice between multiple languages.
Also, would it be possible to talk a bit via email? Do you have any email address where I can talk with you? Thanks.

Ah nice :)
Yeah you can talk to us on the public discord https://discord.gg/0lgcQkrag2RthHte
Or email us at<EMAIL_ADDRESS>


Is it possible to import caffe model on Python 3?

As stated in the documentation, chainer.functions.caffe.CaffeFunction only supports Python 2.7. However in the "Install Chainer" section, it says
Caffe model support

Protocol Buffers
protobuf>=3.0.0 is required for Py3

Thus I am curious whether caffe model import is supported in Python 3.
Thank you very much for your help.

Sorry, the document is wrong. You can use caffe model with protobuf 3 (it is now beta3) on Python3.
https://pypi.python.org/pypi/protobuf
protobuf 2 is not supported on Python3.

Thank you so so much for your reply at this time!


fix(config): use original jest config object

Summary
Jest config string doesn't contain the correct value for testRegex therefore micromatch in compiler failed to validate file name against this value, see related issue reported for jest team to handle: https://github.com/facebook/jest/issues/9778.
This PR switches to use original jest config object to get the correct value for testRegex, close #1509
Test plan
Green CI
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

Pull Request Test Coverage Report for Build 4373

13 of 13 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 92.879%

Totals

Change from base Build 4371:
0.1%

Covered Lines:
1152

Relevant Lines:
1187

💛  - Coveralls


[runner] Don't save settings on Settings app start

Summary of the Pull Request
This is my best guess of what is happening, so please question everything I wrote bellow. :)
Couldn't reproduce the issue on update, but managed to reproduce it in a different way (details bellow) and it looks like the same issue. Fixes modules being disabled after PowerToys update. More details bellow. I haven't seen any downside to removing this code, let me know if you can think of any.

PR Checklist

[x] Closes: #24606
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
There is a race condition while PowerToys is being started after the update because of the following logic https://github.com/microsoft/PowerToys/blob/main/src/Update/PowerToys.Update.cpp#L184 which ends up starting PowerToys right after the install (update) second time as installer is running it as well in the end: https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs#L200
When starting PowerToys twice one after another in very short time period, what can happen is that second instance of runner will send a message to tray window to run settings app
where removed get_general_settings will get is_enabled() state of the modules before the modules are actually enabled by first instance of runner here  and overwrite the settings file with this new state where most of the modules are disabled because default value of m_enabled is false for most of the modules (except PowerRename, ImageResizer, File Locksmith). This state can be seen in logs coming out of nowhere by searching for fancyzones:"false".

Validation Steps Performed
Building and running main branch test following:

Run PT from Visual Studio
Enable all PT modules (just to be sure modules are enabled)
Stop PT
Run PT from Visual Studio
As soon as PT icon appears in sys tray double-click it to open settings
Observe in settings that some modules are disabled

Do the same with this change and observe that modules stay enabled.

Your logic sounds good to me, and it might be the cause of the issue. Simplifying updating process won't hurt as well. 🙂
I wonder what was the original idea behind saving these settings here though. Does everything still work if you start PowerToys without having general settings.json?

Git blame points to the PR way back in the past, so no idea why was this added originally.
I didn't find any regressions so far.

Q: We can also remove starting PowerToys from PowerToys.Update::InstallNewVersionStage2 as it's already being started from the installer, right? New version will show What's new page every time

Will do this as a follow-up if this gets merged, i.e. we don't find regressions here

Could #21014 be releated too?


no_std support

Async-trait hardcodes paths to std instead of using paths to core/alloc (which is now stable). Async/await can be made to work on no_std through various hacks (such as https://github.com/SunriseOS/core-futures-tls ). As such, I believe it makes sense to use paths pointing to core/alloc instead.

Thanks, fixed in 0.1.3.


ISSUE-625 Support server side routes with dots in them

Fixes issue with 404 from server on URL such as this:
http://localhost:3000/fuel-savings/test.two
See:
https://github.com/coryhouse/react-slingshot/issues/625
Checklist

[X] Latest code from master has been merged into the pull request branch
[X] Honors the seven code virtues

[X] Working, as opposed to incomplete
[X] Unique, as opposed to duplicated
[X] Simple, as opposed to complicated
[X] Clear, as opposed to puzzling
[X] Easy, as opposed to difficult
[X] Developed, as opposed to primitive
[X] Brief, as opposed to chatty

[X] Code is camelCased
[X] No commented out code (if required, place // TODO above with explanation)
[X] No linting issues
[X] Automated tests exist and pass
[X] Build is successful (npm run build)
[X] Works in IE 11, Chrome, Firefox, and Edge

Thanks!
:heart:

Coverage remained the same at 91.525% when pulling effdd67b081b701d9432da1c7a4a117a2cce7279 on samuelneff:issue-625-period-404-fix into 207d66ed689642a50d9891cea86d63d8429f79ad on coryhouse:master.

@nickytonline yes, without htmlAcceptHeaders then the server will not serve .js files. I tried without it first and then learned I needed that option as well.

Just noticed your comment in the linked issue about htmlAcceptHeaders

Hmm. Looks like the AppVeyor build is jammed. When you have a sec @coryhouse, can you take a peek? Thanks

Appveyor shows the build passed so must just be a communication hiccup. Merging. Thanks!


Is it possible to support heading/block links?

Hello, congratulations for the plugin, very useful! Do you think it will be possible to support heading/block in your plugin in the future? Thanks!

+1

it should be quite easy to implement this (at least I hope). The following code reads the content of #Daily Log from a note. But the output sucks (probably due to dataview styling it wrong):
// taken from https://www.reddit.com/r/ObsidianMD/comments/u77mju/dataview_table_to_show_note_contents/
let pages = dv.pages("#test");
// Loop through pages
for (let p of pages)
{
  let noteText = await dv.io.load(p.file.path);
  let regexPattern = /#{1,6}\s(Daily Log)\n(.+?)(?:\n#{1,6}|$)/sg;
  let matches = regexPattern.exec(noteText);
  let fileName = p.file.name;
  let sectionName = matches[1];
  let sectionText = matches[2];
  console.log ("Debug",sectionText)
  // Insert into document however you like
  dv.el("b", sectionText);
}

the code being used in the plugin is quite simple and would probably only need:

check if link contains #
if yes use part of the code above to read the section between the headers

hope the developer comes back and takes a look.


⚠ Cioos National CKAN has degraded performance

In 8c3b3c0, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 12453 ms

Resolved: Cioos National CKAN performance has improved in da6ee25 after 7 minutes.


Mark Text style fontVariant as iOS only

fontVariant implemented in #9045. Appears to have lost platform annotation. Also fixes indentation.

By analyzing the blame information on this pull request, we identified @grabbou and @davidaurelio to be potential reviewers.

@facebook-github-bot shipit

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.


Reflection: remove debugging left overs

The dump method is not generally available.  This broke the Azure CI
which builds in release mode.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @jckarter @xedin

Build failed
Swift Test Linux Platform
Git Sha - 01f0d09485b64d2bafac80cd94cc2505493a8d4a

Build failed
Swift Test OS X Platform
Git Sha - 01f0d09485b64d2bafac80cd94cc2505493a8d4a


fixed typo in JS Environment builtins

fixes a minor typo when registering JS Environment builtins.

Good catch, thanks!


Update AssetList.java

bugfix

Can one of the admins verify this patch?

@AppInventorWorkerBee ok to test

On Sep 11, 2019, at 01:25, App Inventor Worker Bee<EMAIL_ADDRESS>wrote:
Can one of the admins verify this patch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ewpatton Should I also add icons for other types of files? It looks like it's more consistent.


exclude netlib (archives) and flens CMake files from installation

cc @SylvainCorlay

fixes #77
after that IMO we should make a (point) release.

+1 on a point release. There seems to have been quite a few issues fixed.


Referencing already registered schemas

Hello there - great project!
I have a large directory with a lot of already defined zod schemas. It would be really easy to run registry.register on all of these to build up a schema collection.
My issue: registry.registerPath requires me to reference those schemas again. If possible I'd love to use something like registry.definitions("someRegisteredSchema") instead to avoid adding a whole lot of references that basically already exist.
UseCase/Example: We're building a nuxt application with layers, where our schema definitions are in a different layer. Our user-facing api offers dynamic route handlers like /api/projects/[projectId]/[resourceType] auto-loading the matching schema for resourceType. It would be way easier to just define the response using that resourceType-String, like "it returns an array of type Server".
Or I'm thinking to complicated, not sure yet.

It's me, thinking too complicated 🙈
registry.registerPath({
  method: "get",
  path: "/projects",
  description: "Get all projects",
  summary: "Get all projects",
  responses: {
    200: {
      description: "List with Projects",
      content: {
        "application/json": {
          schema: {
            type: "array",
            items: {
              $ref: "#/components/schemas/Project",
            },
          },
        },
      },
    },
  },
  parameters: [{ $ref: "#/components/parameters/simulate" }],
});

Just in case someone else is looking for that.


Investigate comment problems with OneOf fields1

While updating https://github.com/johanbrandhorst/grpcweb-example I noticed the comments in the generated file regarding the oneof fields looked off. Investigate whether it is consistent with protoc-gen-go.

Fixed in https://github.com/johanbrandhorst/protobuf/commit/ad1fa0a714191d86968323acbf734f160f8060c7


Making internal UrlManager cache protected(instead of private) to all…

There is an rare issue with UrlManager internal private cache. For example we have this rule configuration:
 'urlManager' => [
    'class' => 'yii\web\UrlManager',
    'enablePrettyUrl' => true,
    'showScriptName' => false,
    'hostInfo' => 'http://www.test.dev',
    'baseUrl' => '/',
    'suffix' => '/',
    'rules' => [
        [
            'pattern' => '/special-cities/<city:(moscow|kazan|barcelona)+>',
            'route' => 'company/index',
        ],
        [
            'pattern' => '<city:[\w-]+>/cities',
            'route' => 'company/index'
        ],

    ]

We have special rule for 3 cities and the second universal rule. If we start generating our urls with URL that matched by second rule (for example "London"), than ALL other cities, including cities from the first rule we by matched by second rule (NOT the first one). That is how internal cache work - it just saves the first matched rule in private property and than use it for same routes.
For example:
  echo Url::to(['company/index', 'city' => 'kazan'], true) . "\n";
  echo Url::to(['company/index', 'city' => 'moscow'], true) . "\n";
  echo Url::to(['company/index', 'city' => 'london'], true) . "\n";

will be:
http://www.test.dev/special-cities/kazan/
http://www.test.dev/special-cities/moscow/
http://www.test.dev/london/cities/
Its correct! But if we use:
echo Url::to(['company/index', 'city' => 'london'], true) . "\n";
echo Url::to(['company/index', 'city' => 'kazan'], true) . "\n";
echo Url::to(['company/index', 'city' => 'moscow'], true) . "\n";

the result will be:
http://www.test.dev/london/cities/
http://www.test.dev/kazan/cities/
http://www.test.dev/moscow/cities/
Its incorrect because of internal cache.
Fix
We can implement some public settings. Like $useCache in UrlRule or $useInternalCache in UrlManager. But the case is pretty rare and I think it is not it worth it. Better just to make cache overridable (protected instead of private) so the developers could override it or turn it off.
So I made it in this pull request.

I agree since I see no straightforward way to implement it without causing drawbacks.


failure fetching info for vobject

Might have to do with the unusual version (https://pypi.python.org/pypi/vobject/0.8.1c)?
All I get is
  resource "vobject" do
    url ""
     ""
  end

Yeah, 0.8.1c looks like a release candidate to 0.8.1, which is marked released but hidden on pypi without downloads, and the API and website do different things when the apparently newest release is hidden: http://chat-logs.dcpython.org/day/pypa/2015-05-22#04.31.57.tdsmith
poet could try to do something clever here but hopefully these cases are rare.


Prioritize critical CSS inject js in AMP pages

I open this issue as suggested by @jmarantz  in #1263
I send the config files in a private mail....

Quick recap for context in this bug:
https://github.com/pagespeed/mod_pagespeed/issues/1263 tracked pagespeed not invalidating AMP pages by disabling any filters that inject scripts, etc.  This was closed and released with 1.12.
later in that bug, Lofesa found his site was being AMP-invalidated by PageSpeed, despite our thinking this is fixed.  The site is reached from these URLs.
https://intersindical.intersindicalrm.org/la-confederacion-intersindical-rechaza-folleto-hazte-oir/amp/
https://intersindical.intersindicalrm.org/la-confederacion-intersindical-rechaza-folleto-hazte-oir/?amp
This AMP site is powered by two Wordpress AMP plugins:
https://wordpress.org/plugins/amp/
https://wordpress.org/plugins/accelerated-mobile-pages/
In my testing locally, I was unable to repro this problem.  Specifying 'amp' in the HTML tag prevented the injection of pagespeed style rendering scripts with prioritize_critical_css enabled.

Lofesa -- in the config files you shared, there is some caching going on outside PageSpeed.  Could you flush those caches just to be sure?  You can also flush the pagespeed cache while you are at it.
There is a fastcgi_cache_path and some open_file_cache* directives.
I can't really think of what scenario an external cache would cause this bug, but it's worth flushing just to be sure.

HI @jmarantz
I think these 2 caches are not related. The fastcgi_cache is defined in the http section but is not used by the php-fpm config fot the WP site, I have a moodle site with an diferrent php-fpm config that uses it. Anyway this cache has a ttl of 20 minutes.
The open_file cache has a ttl of 5 minutes and is used to put in ram memory static files.
If I use the workaround posted by @jeffkaufman  in #1263 (disabling Prioritize critical CSS for request with /amp/ or /?amp) the js is not injected.

Extrange things
As you can see, the js script for Prioritize critical CSS is in the amp page but...
1.- In the google amp validator the https://intersindical.intersindicalrm.org/la-confederacion-intersindical-rechaza-folleto-hazte-oir/amp/ allways get validated status
2.- In the ampproject validator some thimes get invalidated status because the script is here and some times get validated. Mostly if you run the validator for the 1st time get invalid status and in the 2dn run get valid status

I was poking around your HTML to see if anything in there might fool our AMP detector.  I suspected maybe a byte-order-marker.  But I didn't see one in your HTML when fetched with "?PageSpeed=off".  In my tiny testcase I duplicated the first bytes from your HTML exactly and it works fine in ngx_pagespeed on my machine.
My next thought is to send you a source patch which would add some debug logging to PageSpeed's AMP-related code, so we could figure out where it's going wrong.  Would you be able to apply a source patch?

Sure. I am glad to help. You can send the pach to the email address I send you the config files  and I apply to the NPS and regenerate the rpm´s, no problem on that. If you think I must change anything in config files you can say it


Internal querystring parser doesn't support arrays

I noticed the internal default querystring parser doesn't support arrays. I do remember you removed qs as a dependency in 1e5e96b, so I was wondering if you are interested in supporting it before I make a PR. I'm guessing it'd add about 15 lines of code to the internal one.
As an aside, there are more querystring packages on npm than your current one has lines of code, sadly.

For you - would it not make sense to plugin qs?
I suppose it's a bit more difficult in a non CJS/webpack/browserify environment.
The idea here was to keep internal qs as simple as possible. Is there even a standard way of parsing arrays?

would it not make sense to plugin qs?

Yes I know you can provide your own querystring implementation, so I was wondering where you are drawing the line for feature support for your internal qs implementation.

Is there even a standard way of parsing arrays?

foo=a&foo=b should result { foo: ['a', 'b'] }, but I've also seen foo[]=a&foo[]=b, probably because there is no way to specify a single item array with the former.
Hmmm given that, maybe it should be left as-is.

Yeah the more I dig the bigger the mess I see... Is an empty array just not there, foo[]=, or foo= ? or maybe just foo[]? sigh... Lack of standards here hurts.

Well, we have a couple options here, perhaps i should just bring back
the qs module by default and make things easier. This is a router after
all. The other option for you is to just pull in qs to your app.
Sorry that i keep "rejecting" your PR proposals. Just being careful with
how the project evolves. I really apreciate your contributions regardless.
On Tuesday, 10 November 2015, Nathan Black<EMAIL_ADDRESS>wrote:

Yeah the more I dig the bigger the mess I see... Is an empty array just
not there, foo[]=, or foo= ? or maybe just foo[]? sigh... Lack of
standards here hurts.
—
Reply to this email directly or view it on GitHub
https://github.com/QubitProducts/cherrytree/issues/118#issuecomment-155304098
.

Sorry that i keep "rejecting" your PR proposals

NP, and honestly this was a question and I convinced myself against it. Query string parsing is totally not standardized, so a simple parser in < 20 lines with the option of providing your own is the best way, which is what cherrytree does now.

Just being careful with how the project evolves

That's the right default reaction. Any addition is ever ongoing maintenance, or a breaking change that requires upfront notice and user pain. I've rejected more PRs to mocha-phantomjs than I've accepted in the last year or so :/


Can't create cross resource reference if the terraform field type is Number

What happened?
Context:

https://github.com/crossplane-contrib/provider-jet-datadog

Attempt to create cross resource reference for ServiceLevelObjective resource pointing to Monitors

    p.AddResourceConfigurator("datadog_service_level_objective", func(r *tjconfig.Resource) {
        r.ExternalName = tjconfig.IdentifierFromProvider
        r.Kind = "ServiceLevelObjective"
        r.ShortGroup = "monitor"
        r.References["monitor_ids"] = config.Reference{
            Type:      "Monitor",
        }
    })

It fails with type mismatch error
ERRO Running error: buildir: analysis skipped: errors in package: [/Users/xnull/upstream/provider-jet-datadog/apis/monitor/v1alpha1/zz_generated.resolvers.go:36:42: cannot use mg.Spec.ForProvider.MonitorIds (variable of type []*float64) as []*string value in argument to reference.FromPtrValues /User
s/xnull/upstream/provider-jet-datadog/apis/monitor/v1alpha1/zz_generated.resolvers.go:48:35: cannot use reference.ToPtrValues(mrsp.ResolvedValues) (vadiff --git a/apis/monitor/v1alpha1/zz_generated.deepcopy.go b/apis/monitor/v1alpha1/zz_generated.deepcopy.go

I've tried to override the field type ( thanks @ezgidemirel ) with
r.TerraformResource.Schema["monitor_ids"].Type = schema.TypeString

but it failed runtime with
    Message:               observe failed: cannot run refresh: refresh failed: Incorrect attribute value type: Inappropriate value for attribute "monitor_ids": set of number required.: File name: main.tf.json

reporting the underlying terraform type mismatch
I've also tried to play with Extractor function but it looks like it always has to return ExtractValueFn of crossplane-runtime but it also eventually return string.
CC: @turkenh
How can we reproduce it?
git clone https://github.com/crossplane-contrib/provider-jet-datadog.git
cd provider-jet-datadog
vi config/monitor/config.go

Add the reference configuration to config/monitor/config.go
+               r.References["monitor_ids"] = config.Reference{
+                       Type: "Monitor",
+               }

make reviewable

to reproduce the type mismatch failure

I think this is a missing feature in reference resolver in crossplane-runtime affecting all providers. It assumes that the value could either be string or []string. There are some helpers for pointers, maybe we could get away with adding helpers for float/int etc?

I guess this would block building a hcloud provider as well, since it has integer id's.
For example:
https://registry.terraform.io/providers/hetznercloud/hcloud/latest/docs/resources/network#attributes-reference

@muvaf can we revive this?

I just wanted to say that I've started working on implementing support for cross-resource references for other primitives than string. So far I've added support for float64 but will add support for all basic types.
From my understanding, the best way to solve this is by updating the crossplane-runtime and add methods that support converting resolved references to other primitives than strings and also to update the crossplane-tools code generation to make sure the correct funcs are used to convert the resolved values.
The initial commit for supporting this can be found in my fork of crossplane-runtime and crossplane-tools
E.g. in the case where the the source is of type []*float64, crossplane-tools will now generate the following code instead:
    for i3 := 0; i3 < len(mg.Spec.ForProvider.Reviewers); i3++ {
    mrsp, err = r.ResolveMultiple(ctx, reference.MultiResolutionRequest{
--       CurrentValues: reference.FromPtrValues(mg.Spec.ForProvider.Reviewers[i3].Teams),
++       CurrentValues: reference.FromFloatPtrValues(mg.Spec.ForProvider.Reviewers[i3].Teams),
	    Extract:       reference.ExternalName(),
	    References:    mg.Spec.ForProvider.Reviewers[i3].TeamsRefs,
	    Selector:      mg.Spec.ForProvider.Reviewers[i3].TeamsSelector,
	    To: reference.To{
		    List:    &v1alpha1.TeamList{},
		    Managed: &v1alpha1.Team{},
	    },
    })
    if err != nil {
	    return errors.Wrap(err, "mg.Spec.ForProvider.Reviewers[i3].Teams")
    }
--  mg.Spec.ForProvider.Reviewers[i3].Teams = reference.ToPtrValues(mrsp.ResolvedValues)
++  mg.Spec.ForProvider.Reviewers[i3].Teams = reference.ToFloatPtrValues(mrsp.ResolvedValues)
     mg.Spec.ForProvider.Reviewers[i3].TeamsRefs = mrsp.ResolvedReferences
    }


(2272) Professions can have many organisations

This sets up a new join table to join professions to organisaitons and vice versa, with a role column, allowing us to specify the nature of the relation.
I've also added a data migration to add existing organisations to the new relation, as well as changing the update action to update both relations to keep everything in sync before we make any further changes.
Once this code is deployed, we'll need to run the data migration on staging/prod like so:
script/npm run data:migrate ./src/db/data/20223828934-update-organisation-relations.ts

We'll also need to make sure this is deployed to prod (and the migration run) before the subsequent changes are made, otherwise things will break

@pezholio can we hold off on merging this one until we've done the next production deploy (likely today)


Where can I find the download file?

After successful generation, there will be a file named "final.mp4" in the folder.
If it's not there, the generation might have failed.
You can check the terminal for any error messages.


Binary data in a string makes the download button to fail

I'm using downloadify to save image data which is a binary string, this causes the download button to fail to popup the save dialog, this is tested against the online demo.
I will attach some data that causes it to fail (just paste it into the Downloadify Example.

Yes, same problem here. Any solution?


Onboarding screen blocked at the step of adding a new server despite the DefaultServerList GPO

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: https://docs.mattermost.com/install/troubleshooting.html.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary
Despite the configuration of Mattermost servers by GPO, the onboarding screen in version 5.2.0 requires the manual configuration of a server to access the application.
Environment

Operating System: Windows 10 + Windows server 2019 with Mattermost 5.2.0 admx pack
Mattermost Desktop App version: 5.2.0 (via msi installer)
Mattermost Server version: 7.2.0

Steps to reproduce

Configure group policy "DefaultServerList" ;
Install Mattermost Desktop 5.2.0 ;
Open Mattermost Desktop.

Expected behavior

The user should not need to configure any servers as these are managed by a GPO ;
The user should land directly on the discussion channels.

Observed behavior

The user remains stuck on the "Let's connect to a server" onboarding page ;
It seems to be mandatory to fill in the server information ;
The server pushed by GPO does appear at the top left, but the button is greyed out.

Possible fixes
N/A.

Same issue on our installation. We get quite a lot of complains from our users, I hope this is fixed quite fast.

Same Issue here. Hope this gets fixed fast, very annoying for the users.

Fixed by https://github.com/mattermost/desktop/pull/2346

I've updated to 5.2.1. Doesn't seem to be fixed yet.

For our installation it seems to be fixed with version 5.2.1.

Nope, not fixed, at least not at my system. I was still on the working 5.1.1 and updated today to 5.2.1 and iam now getting this screen every time i restart the app.

Same here. Not fixed with 5.2.1

Same here. Just rolled out the update to 5.2.1 and got the Onboarding Screen again.


Request: Contributor Access

@Abdenasser
I would like to dedicate 5-12 hours a week on this project. It would be great if u can grant me contributor access

@laciferin2024 what would you exactly need?

contributor access to this repo

sure, will take some time to set that up


wrapping in left nav still looks funny

longer field names look centered.
example on Stage
https://stage.sinopia.io/editor/ld4p:RT:bf2:Monograph:Work:Un-nested
see the first field "Contribution (Creator/Contributor)"
Why isn't "Contribution" left aligned?

and
https://stage.sinopia.io/editor/ld4p:RT:bf2:Monograph:Instance:Un-nested
"Statement of Responsibility" looks like it's a subsection of "Title Information" but it is not

If I zoom out on my browser, the problem resolves:

but I don't think my default browser view is especially Zoomed in
can we make things align/wrap properly even when not zoomed out?

I don't see the problem you're seeing at standard resolution. It only occurs when I'm zoomed in to 133%.


Broken "Testing with Grunt" link in docs

On the Docs page there is a link called Testing with Grunt under the Testing section, which points to a non-existing page.
I assume it' supposed to point to the Building and Testing with Grunt page.

Going out today in the next site release.


Add support for connection retry logic equivalent to MultisubnetFailover

In .NET 4.6.1, SqlClient is intelligent enough to automatically detect if the SQL connection is to a  AlwaysOn Availability Group or a SQL Cluster and sets MultisubnetFailover which optimizes client failover behavior.  See https://blogs.msdn.microsoft.com/dotnet/2015/11/30/net-framework-4-6-1-is-now-available/  and https://msdn.microsoft.com/en-us/library/hh205662(v=vs.110).aspx
Even if the Golang equivalent doesn't support MultisubnetFailover auto detection, it would be nice to offer an similar connection string option that can be manually set.

If I correctly understand what MS are saying in their blog, this may have already been implemented by PR #124 last year.  My understanding of MultiSubnetFailover=true is that it will make the .NET driver dial the various members of the cluster in parallel, so you don't have to wait for one to timeout before trying the next one.   Since #124, the Go driver will always do this when connecting to an Availability Group.

Will the Go driver also do this when connecting to a SQL Cluster instance?

I'm not sure how SQL Clusters are implemented.  The specific behaviour of the driver which implements AG connections is:

Resolve DNS host name into a list of IP addresses
Dial them all in parallel
Proceed with the first one that accepts a connection
Error if they all timeout

If a SQL Cluster connection is presented to clients in the same way as an AG connection, then it should work fine.  The code doesn't really know that it's connecting to an AG per se, it only knows that the DNS resolution returns a list rather than a single IP address.

Thank you for the update.  I have tested the Go driver against a SQL 2016 availability group and compared the results against a C# application using .NET 4.6.2.  In the majority of cases, the C# application transitions seamlessly when the availability group fails over.  However, the Go driver always reports an error: xxx:1433': dial tcp <IP_ADDRESS>:1433: i/o timeout
I have made the Go and C# test applications to have the same logic.  I am including a link to the Go application: (https://play.golang.org/p/f2VVOjDQ3N)  I have tried various settings for the "dial timeout" field but there is always an error reported.  Could the behavior of the Go driver be updated to match the C# one?  If needed, I can try to post the C# code as well.

I can't quite see how this would work given the architecture of the Go sql package.  The problem is that AG failover isn't really seamless.  You have an open TCP connection to one server in the cluster, and if that server dies, you have to establish a new connection to another server, authenticate again, etc.  If you were in the middle of a transaction, you have to start over again from the beginning.
I think the go sql package will sometimes transparently retry a single statement if a connection throws an error (so for example, if you got a connection from the pool that had timed out, you don't have to deal with that).  But it couldn't possibly be expected to save and replay an arbitrary number of SQL statements within a transaction.  So in the most general case, it's inevitable that an error will be passed up to the application, which will have to catch it and decide what to do.
I have no idea what kind of magic the .NET driver might be doing to make it appear more seamless.  I'm not familiar with that technology at all, but I suppose the relationship between the driver and the programming language are quite different.  For a single statement, it could be trapping the error, establishing a new connection, and retrying it for you.  But this is actually a dangerous thing to do -- depending on the failure mode this could lead to the statement being executed twice.
Anyway, all the stuff that we've written in Go deals well enough with AG failover by handling the error in one way or another.

I think it would be possible; you would need to create a package private mapping per DSN that then would write down the current state of the remotes: remote 1 appears down , remote 2 looking good, use that first.

I don't think caching the last-known-good server and trying it first would be any better than the current approach of always trying all servers in the cluster in parallel.  It would definitely be worse when a failover occurs.
In any case, this wouldn't address the central problem raised by @LukeMauldin   When the primary server in an AG cluster fails, a new primary is elected.  All clients have to find the new primary and establish a new connection.  I believe it to be impossible to hide that failover process from the client without the risk of statements (e.g. inserts) being executed twice.

Thank you for all of your responses. After much consideration, I agree that the retry logic should be contained entirely in the application.


Add uwp led dts

dts: bindings: Add unisoc,uwp-gpio.yaml
dts: arm: Add gpio port0
boards: arm: Add led dts
soc: arm: Update uwp dts_fixup.h
drivers: gpio: Update uwp gpio with dts
drivers: led: Update uwp led with dts

This must combine another pull request of repository apps
https://github.com/bublover/apps/pull/new/update_led_dts


do a clean out of scripts

think these are one-offs that never got cleaned
there's some in here from @mstriemer and @magopian

r+, thanks for the cleanup ;)

Looks good, thanks.


Link simulated graphene 4D STEM dataset

Link to https://zenodo.org/record/4476506#.YBLo9NbTVH4 in our section on publicly available 4D STEM test datasets.

More links for this dataset:

https://arxiv.org/pdf/2108.04625.pdf
https://gitlab.com/pyptychostem/pyptychostem

Since we don't support this format yet, we should defer this issue until #1081


Using FixedElements configuration with a header that is fixed after scroll

I am having the issue that my fixed header disappears when I open the mmenu, and I've attached the fixedElements configuration. I tried adding the FixedTop class, and also tried using the configuration:
        classNames: {
            fixedElements: {
               fixedTop: "is-fixed"
            }
         }

The 'is-fixed' class is what is added to my header on scroll to make it fixed when it reaches the top. However, since the configuration is happening on page load (and the header isn't yet fixed on page load, and the is-fixed class isn't yet attached to the element until scrolled to the top), the fixedElements configuration isn't working. Any thoughts on how I could still stop my header from disappearing when it isn't yet fixed on page load?
Thanks!

Same thing happens to me! Couldn't found any solution yet. My header is
"position: fixed;" and disappears when I open the menu, and returns after
the menu closes.
#header { height: 40px; width: 100%; position: fixed; left: 0; top: 0; }
It's not obstructive, so I didn't concerned too much about it, but it sure
needs to be fixed. It took me hours trying to figure it out a workaround
playing with CSS, without success.
On Mon, Jan 12, 2015 at 2:47 PM, lcavezza<EMAIL_ADDRESS>wrote:

I am having the issue that my fixed header disappears when I open the
mmenu, and I've attached the fixedElements configuration. I tried adding
the FixedTop class, and also tried using the configuration:
    classNames: {
        fixedElements: {
           fixedTop: "is-fixed"
        }
     }

The 'is-fixed' class is what is added to my header on scroll to make it
fixed when it reaches the top. However, since the configuration is
happening on page load (and the header isn't yet fixed on page load, and
the is-fixed class isn't yet attached to the element until scrolled to the
top), the fixedElements configuration isn't working. Any thoughts on how I
could still stop my header from disappearing when it isn't yet fixed on
page load?
Thanks!
--
Reply to this email directly or view it on GitHub
https://github.com/BeSite/jQuery.mmenu/issues/272.

The plugin searches for the "fixedTop" elements when the plugin is fired. It's not "live", there is no "onClassnameChange" event or something like that.
I'd recommend to clone the header and give the "fixedTop" classname to only one of the two. After that, don't add/remove the classname when scrolling, but show/hide the two elements.


[Events] User can't get to "Create event" button using a TAB

Environment: ALL
Reproducible: always
Build found: 27.04.2023
Preconditions
Steps to reproduce

Go to https://www.testgreencity.ga/#/events
Swith to 'Create event' button with 'TAB' button on keyboard

Actual result
"Create event" button can't be selected by TAB
Expected result
"Create Event" bttn  is selected
Postconditions
User story and test case links
E.g.: "User story #3193
Labels to be added

pressing the space bar or enter button "Create event" does not respond and the "Create event" page does not appear

Hi!
This task was only about  using TAB for crete event.
Actual result
"Create event" button can't be selected by TAB
Expected result
"Create Event" bttn is selected.
Requirements for using the space bar or the enter button in the task were
not specified.
Maybe you need to add it to this task card.
пн, 29 мая 2023 г. в 13:23, DanaIuich @.***>:

pressing the space bar or enter button "Create event" does not respond and
the "Create event" page does not appear
—
Reply to this email directly, view it on GitHub
https://github.com/ita-social-projects/GreenCity/issues/5744#issuecomment-1566928882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AON7PROO7ZITKTRVSRMKTO3XIR2K5ANCNFSM6AAAAAAXVTK77A
.
You are receiving this because you were assigned.Message ID:
@.***>


Which ffpmeg version is used?

Which ffpmeg version to use, I use the 4.1 version to get avcodec.Contex is nil

A few PRs are now merged.


"pip install Feast" does not work properly

Hi,
I'm having issue to install Feast using pip in host as well as container. I've tried in the following way to install in container:
$ docker pull python:3.7
$ docker run -it -d --name "feast" python:3.7
$ docker exec -it feast  bash
$ pip install Feast
$ python
>>> import feast

The error i'm getting :
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'feast'

The feast module is installed successfully and works fine if i install using "setup.py".

Hey, thanks for raising the issue! It looks like the problem is that we're missing the __init__.py files, which while is no longer required to define directories, is still required for packaging the modules.
Will make a PR and push a new version asap!

@shihabuddinbuet It should work now. The installed version should be 0.1.0.post0

@zhilingc It is working now. Thanks for the update :) .


http/3

Is it possible to use HTTP 3 with this version of curl? I know you're able to extend the default curl to add http 3 support but I'm not sure how one would make those changes to this library.

I don't really know in detail how HTTP3 works, but just wondering if it's harder to impersonate browsers on this protocol version, or conversely easier?

From the README: https://github.com/lwthiker/curl-impersonate/blob/main/README.md :

The resulting curl looks, from a network perspective, identical to a real browser.

From https://curl.se/docs/http3.html https://github.com/curl/curl/blob/master/docs/HTTP3.md ::

HTTP/3 and QUIC support in curl is considered EXPERIMENTAL until further notice. It needs to be enabled at build-time.

It's probably trivial to passively fingerprint curl HTTP/3 as compared with e.g. Chrome and Firefox's HTTP/3 QUIC UDP packets?

With curl 8.5.0, HTTP3 is no longer experimental, for the ngtcp2 builds.
https://curl.se/changes.html#8_5_0
https://github.com/curl/curl/pull/12235


bindl generate make targets should verify that Bindl exists

The Problem
Usually 1 person will set up Bindl for the project. Other members of the project will only care about the dependency that they're using (i.e. bin/ko) but won't care for how it's getting downloaded or updated.
The erroneous flow I see is

I swap a project over to Bindl.
Teammate tries to install bin/ko
Teammate runs into issues since they don't have Bindl.
Teammate reaches out to me to figure out how to get Bindl to work.

Solving this problem removes a step that will be easily forgotten and explicitly sets Bindl itself as a dependency.
My Current Workaround
I manually modified the generated file that says "DO NOT MODIFY".
One Option I Was Thinking Of
Either through bindl.yaml or through commandline. I was thinking of an optional flag. The target would need to be defined by the user (unless #13 is implemented).

Current

# THIS FILE WAS GENERATED BY BINDL 0.0.5 (4b5fba05cd01309ca791844d65e97a3309b7ec0d) (go1.18) ON 2022-04-20T22:36:26Z
# DO NOT MODIFY - ANY MODIFICATIONS WILL BE OVERWRITTEN

# For this file to work appropriately, bindl must already be setup in the machine
# through bootstrap or other mechanisms.

BINDL_PROGRAMS?=$(shell bindl list --oneline)
BINDL_PROGRAMS_PATH?=$(addprefix bin/,$(BINDL_PROGRAMS))

.bindl-lock.yaml:
	bindl sync

# On the other hand, lockfile is a regular pre-requisite where we would like for
# programs to be re-validated if lockfile was modified, in case the versions have changed.
$(BINDL_PROGRAMS_PATH): .bindl-lock.yaml
	bindl get $(@F)

Feature Request

# THIS FILE WAS GENERATED BY BINDL 0.0.5 (4b5fba05cd01309ca791844d65e97a3309b7ec0d) (go1.18) ON 2022-04-20T22:36:26Z
# DO NOT MODIFY - ANY MODIFICATIONS WILL BE OVERWRITTEN

# For this file to work appropriately, bindl must already be setup in the machine
# through bootstrap or other mechanisms.

BINDL_PROGRAMS?=$(shell bindl list --oneline)
BINDL_PROGRAMS_PATH?=$(addprefix bin/,$(BINDL_PROGRAMS))

.bindl-lock.yaml: bin/bindl
	bindl sync

# On the other hand, lockfile is a regular pre-requisite where we would like for
# programs to be re-validated if lockfile was modified, in case the versions have changed.
$(BINDL_PROGRAMS_PATH): .bindl-lock.yaml bin/bindl
	bindl get $(@F)

Does make show a different error message with the new dependency? Because it would end up being a recursive rule (bin/bindl qualifies under $(BINDL_PROGRAMS_PATH)).
Previously the dependency was there, but I removed it because in the event bindl was not bootstrapped, the error message wasn't clear.
I think the alternative that we can do is to do something like this:
bin/bindl:
	curl --location https://bindl.dev/bootstrap.sh | bash

.bindl-lock.yaml: | bin/bindl

(notice the pipe in the rule, which denotes order-only pre-requisite)

Because it would end up being a recursive rule (bin/bindl qualifies under $(BINDL_PROGRAMS_PATH)).

😵💫  I see what the issue was now.
A thought though -- what if instead of making a fully globbing make target, Bindl explicitly updates the Makefile.bindl as well everytime (if specified in bindl.yaml)?
I still have some binaries that I need to install (not through Bindl) that I would like to keep in bin/, so it would make sense for the make targets to be specific to what Bindl has control over.
Downside is that this solution would make bindl gen make implicitly part of bindl get.

Downside is that this solution would make bindl gen make implicitly part of bindl get.

Since we're not expecting users to always use Makefile (because we don't want hard dependency on Makefile), this flow would need to go through "after bindl get, if Makefile.bindl exists, run bindl gen make".
Another layer of complexity would be people not using Makefile.bindl name but instead bindl.mk 🙃
Let's talk about this more broadly and less prescriptive: what user experience do we want? If I'm following correctly, I would translate the discussion above into "bootstrapping experience", specifically "how can Bindl feel transparent and integrated to users, such that they don't need to care about Bindl". Does that align with what you're thinking?


vue-tsc: useCssModule() in script setup component breaks checking

Vue - Official extension or vue-tsc version
2.1.8
VSCode version

(using vue-tsc CLI)

Vue version
2.7.16
TypeScript version
5.6.3
System Info
No response
package.json dependencies
No response
Steps to reproduce
Test.vue:
<template>
    <div/>
</template>

<script setup lang="ts">
    import {useCssModule} from 'vue'

    const $style = useCssModule()
</script>

<style module lang="scss">
    .test {
        color: rebeccapurple;
    }
</style>

vue-tsc --noEmit --skipLibCheck -w

What is expected?
No bogus issues found.
What is actually happening?
vue-tsc reports
resources/js/components/common/Test.vue:8:32 - error TS1005: ',' expected.

8     const $style = useCssModule()
                                 ~

resources/js/components/common/Test.vue:8:33 - error TS1109: Expression expected.

8     const $style = useCssModule()
                                  ~

Link to minimal reproduction
No response
Any additional comments?
Bug is new in 2.1.8, reverting to 2.1.6 fixes the issue.

Duplicate of #4951

Ah, sorry. I checked yesterday if this was known and forgot to check again today before reporting ^^'


Added collection support.

This is merged with the latest master and updated so that it works correctly with promises.
I'm still open to renaming the IIIFResource/IIIIFResource base class/interface if you can think of a better name. I wonder if the Manifesto::loadManifest method should be renamed to match (i.e. loadIIIFResource) since it may return a Promise resolving to either a Manifest or a Collection at this stage of development.
Those semantics aside, though, I think this is a decent start to the functionality. Let me know what you think! Thanks!

Closing so I can reopen against dev branch. Sorry!


removed template, added bootstrap cdn and changed homepage layout

initial pr to remove the template and add bootstrap cdn.

Thanks, @reveurguy for improving.


Temp Fusion PR

OPS Build status updates of commit f8a2196:
:clock10: Preparing: average preparing time is 45 sec(s)

OPS Build status updates of commit f8a2196:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\qh34-s, target branch: master, target branch commit: 84def263733e577ddc658e3844911b94df0459a4, source branch: fusion/winter-ready, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@alexbuckgit We need to delete this branch and create a new post-winter-ready branch from master. The commits from this branch were all squashed when I merged into master.


Incorrect number of elements shown when element exceeds container height

Hello,
I have implemented a multi-level nested tree of collapsible elements, by taking advantage of
heightForIndex

and
updateRows

Everything seemed to work as expected, until some of my data branches had a big number of descendants, such that the total height of the root element was greater than that of the container.

As I start scrolling, at some point, it stops functioning properly, as it shows less items than needed to fill the container area. I have verified that heightForIndex is calculated correctly and accurately. The calculation is done via
  heightForIndex: (idx)->
    entry = @get('content').objectAt(idx)
    if entry.get('collapsed')
      return @rowHeight * entry.get('selfAndDescendantsRows')
    else
      @rowHeight

where selfAndDescendatsRows is a computed property inside the model that populates the tree / list.
This is very disappointing because other than this issue, the whole system works impressively well, so any help would be much appreciated.
thanks!

This is very disappointing because other than this issue,

ya it's a bummer, we will need to fix this. But a good scenario :)

For a tree-view like structure I built a component (in-house), that has no nested list views, but rather just indents items based on their depth in a single list view.
The code slightly more complicated than the straightforward way, but uses much less elements than other approaches and is always fast, no matter how many nodes are open/visible.
Maybe that would work for you as well.

I would gladly try your component as well tp, thanks!

This will probably be fixed on the pack branch.

This will probably be fixed on the pack branch.

maybe, im unsure about this specific use-case though.

Hello. Any news on this one? Haivng the same issue and would be glad to have this solved!

I'm sorry we didn't get back to this previously, but at this point this repo is essentially unmaintained.  Please use @html-next/vertical-collection or ember-collection for similar functionality.
Closing...


[FLINK-22891][runtime] Using CompletableFuture to sync the scheduling…

… of checkResourceRequirements
The result of ScheduledFuture#isDone can be false negative

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @wangyang0918

Thanks for the review, @xintongsong . PR updated.

@flinkbot run azure

It seems we incorrectly merge an outdated commit. Will fix this in another hotfix.


Add conda install info?

I had in my head that this is lomap2 on conda-forge? If so add this to the main README.md?
Also, should the repo be renamed LOMAP2 for consistency with that? (And this would also help mark the transition from the MobleyLab one to the OpenFE one.)

I had in my head that this is lomap2 on conda-forge? If so add this to the main README.md?

Opened #9 to add this info. Thanks for catching it!

Also, should the repo be renamed LOMAP2 for consistency with that? (And this would also help mark the transition from the MobleyLab one to the OpenFE one.)

We ended up putting the 2 in the conda-forge name because there is a package on PyPI called lomap. If we're ever able to release to PyPI (requires official RDKit release on PyPI), we'd prefer PyPI to use the same name as conda-forge.
But we never discussed changing the name of the repo here. @richardjgowers : Thoughts on this?

I'm not Richard, but I'd argue that the conda-forge renaming might be a convenient argument to rename entirely to eliminate confusion with the version we first introduced many years ago, which really no longer exists since it's undergone one total rewrite already and probably will end up very different again now that it's with you guys. :)


feat: support development environment in switcher

Added missing dev environment in envSwitcher when running on localhost.

Not sure if Development should show the Last mod date for preview?

Not sure if Development should show the Last mod date for preview?

Hmm, since development is not actually a content environment per se, it depends on which env is being proxied by the simulator. This info could be derived from the hlx:proxyUrl meta tag.

Development will now show the preview last mod date.

:tada: This PR is included in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


remove useless padding, and move sizedbox

Please merge it for us 😁

Is this merged yet? I am still seeing the overflow in the widget. Also the version on pub.dev is 0.1.1 while in the source is 0.1.1+3. When can i expect a merge please?

I'll be closing this PR since I'm going with another soltution. If the problem persists, I'll be open to suggestions again! Thanks for the contribution.


NodeSecure Next - Vision for the future

I think we should deeply discuss the future of NodeSecure in term of ideas and core values. We have already had more or less all together thoughts and ideas.
The idea is not necessarily to restrict ourselves in our choices to date but rather to establish a more solid foundation to present the project to future collaborators and users.
Some of the core ideas I have in mind:

Visualization
Customization
Neutrality (In the world of security I mean).
Accessibility ?

I think that these guidelines should come from our project ideas (we should not invent them out of thin air).

In the last meeting we agreed on scheduling a meeting to discuss it.
I think we should plan this in September to be sure no one is in vacation.

I think we missed the 'plan this in september' 🤣
Also, as Fraxken said on discord, we may want to add a bullet point about:

how can we work on the dev education?

@tony-go @antoine-coulon @fraxken

I think we need two hours. So maybe we can schedule this a week-end or at the evening. Beginning of february for example?

Sounds good!
Next week could fit for me

I'm available on weekends and in the evening, so whenever you want.

I'm more likely to be available on evenings

No matter on my side

If the meeting is hold tonight, here is the agenda:

The project and its evolution (it's the nostalgic moment 😅)
Core ideas for the NodeSecure org/project as a whole;

Being educational on security (and open source). Pushing the best practices, writing articles and videos etc...
Neutrality (we should always promote what's best for developers and end-users, even if it mean doing marketing/communication for third-party initiatives or products as long as they are in line with our values).
Keep engaging new juniors and experimented contributors (to build a strong and active community).

We must set example on applicating best pratices (that's why the recent work on improving security of our projects is critical).

Note Those ideas/values concerns and impact the collaborators and contributors of each individuals projects.

Core ideas for NodeSecure packages and tools;

Visualization
Customization
Accessibility
TBC (discussion between collaborators and contributors required)

Important projects for 2023 (no orders);

CI
CLI
Authors
Database

Continuous improvement of our analysis (back-end) packages is obviously just as critical (JS-X-Ray, Scanner, Vulnera).

I distinguished between what was more technical and what was more human.

Meeting record (french): https://www.youtube.com/watch?v=MRNSR35KSF4


Update configuration-page.md

Removing a misleading reference of removal page url to mobile clients section

Docs Build status updates of commit 31477dc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/tabs/how-to/create-tab-pages/configuration-page.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d3562f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/tabs/how-to/create-tab-pages/configuration-page.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/tab-requirements.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6b20438:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/tabs/how-to/create-tab-pages/content-page.md
:bulb:Suggestion
View
Details

msteams-platform/tabs/how-to/create-tab-pages/configuration-page.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/tab-requirements.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/create-tab-pages/content-page.md

Line 25, Column 57: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /javascript/api/overview/msteams-client?view=msteams-client-js-latest. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 25cdfe4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/tabs/how-to/create-tab-pages/configuration-page.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/create-tab-pages/content-page.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/tab-requirements.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Settings menu not loading appropriately when right-clicking a file

I'm getting a misbehavior of the 'Settings' menu (via 'File' > 'Settings'). If I open atom via the command line (either 'atom' or 'atom --safe'), and open a file from the 'Open' option, everything works fine.
However, if I open the same file in Windows by right-clicking the file and selecting 'Open with atom' (launching a new instance of atom), when I go to the 'settings' menu and select 'Packages', 'Themes', or 'Updates', the system is unable to load any information about installed packages, etc.

However, inside the 'Settings' menu, the information still appears for the submenus 'Settings' and 'Keybindings'.
I deactivated all non-core packages to see if this solved the problem - it didn't.
Some info about my system:
*OS: Windows 10, home edition, build 10.0.10586
*atom --version output:
Atom    : 1.10.2
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0

apm --version output:
apm  1.12.5
npm  3.10.5
node 4.4.5
python 3.5.1
git 2.9.3.windows.3
visual studio

Try this:

Completely exit all instances of Atom.
Launch Atom in safe mode.
In the settings-view open the Systems tab and check all three options.
Close Atom and try to reproduce this issue.
In the settings-view systems tab check all options as you want.

From the picture the settings-view that opens is from an older version of Atom(No Systems tab is visible) so it is possible your shell integrations are not correctly updated.

That worked!
Would it be advisable to update my atom installation? From the 'Settings' > 'Updates', my systems tells that all packages are up to date. At the 'Help' > 'Update' menu I also get the information that my system is up to date.

As long as all launch options report Atom version 1.10.2 or newer in the about dialog you should be fine.
/cc @damieng another problem caused by shell integrations not updating.

Yeah this has been fixed in master, 1.10 and 1.11 branches but won't take affect until the next releases, sorry for the inconvenience.


Alias Raven.send to Rave.send_object_message

headdesk. Yeah, we probably shouldn't be overriding send.

Yeah, probably not. I'm happy to just rename the method as well. Although, I'm not sure if you want to do that since it is likely to break existing implementations.

Yeah. A lot of people are using Raven.send in their job processors are well. We'll definitely need a deprecation cycle.

Closing in favor of #326 for now. Thanks for pointing this out.


Split java code into two modules

I think it might be better to organize the java code in a library part and a client part.
That way the library part can be uploaded into maven central and reused by other projects without them getting the main class in their class path.
My suggestion is to do this by setting up the maven project to be multi-module, with a library module and client module.

Can this be done without affecting the organisation of the code in the repository? (genuine question from a non-Java person here!)

Quick answer: no.
Long answer:
Right now the (maven) java code layout is this:
* java
** src
*** main
*** test
** pom.xml

This proposal would move it into something like this:
* java
** lib
*** src
**** main
**** test
*** pom.xml
** client
*** src
**** main
**** test
*** pom.xml
** pom.xml

This would also make the java code produce two different artifacts, one from the library module that would be suitable to distribute to maven central, and one from the client module, that would be suitable to distribute from somewhere else, as maven central is for dependencies.

OK, but all changes remaining within the java subdirectory of this repository, and all tests would still be executed on Travis... Good.

I'd suggest holding off on that, though, as per my comment on #1375.

No problem :)
My main motivation is to be able to read data from a CT log in my project. Right now I have achieved this by copying all the java classes from this project into mine. I thought that it be some quick community service to help you with getting your artifacts onto maven central, so that I can depend on an more official release.
Just drop me a message when you have finished your reorganisation.

Excellent! And your "quick" community service is greatly appreciated. :smiley:
I'll watch for your PR getting merged, try to get that done quickly afterwards, and update this issue once it's done.

I've now moved the Java code to its own separate repository:
https://github.com/google/certificate-transparency-java
This should generally leave you with a lot more freedom to propose such reorganisations. I'll close this issue here, feel free to create an equivalent one over there.


Automate - Provisioning First and Last name are no longer required.

Fields are not being populate during life-cycle provisioning so
There is no reason to make them required.
This eliminates 2 required fields when provisioning.
https://bugzilla.redhat.com/show_bug.cgi?id=1349607
@miq-bot add_label bug, fine/yes

@miq-bot add_labe automate, provisioning

@miq-bot add_label automate, provisioning

@tinaafitz
Please Review

@billfitzgerald0120 Looks good.
@mkanoor Please review.

👍

Fine backport details:
$ git log -1
commit 40a1ac584534fd7954e2810f69cdc3abfd64ff8f
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Mon Apr 10 16:50:41 2017 -0400

    Merge pull request #14694 from billfitzgerald0120/name_not_required

    Automate - Provisioning First and Last name are no longer required.
    (cherry picked from commit fa4d05bf081f03a9e11db5175086ffe43482da48)

    https://bugzilla.redhat.com/show_bug.cgi?id=1441270

Euwe backport details:
$ git log -1
commit e4f721dba4ac65c61d4b3831315f08e2ce0e8864
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Mon Apr 10 16:50:41 2017 -0400

    Merge pull request #14694 from billfitzgerald0120/name_not_required

    Automate - Provisioning First and Last name are no longer required.
    (cherry picked from commit fa4d05bf081f03a9e11db5175086ffe43482da48)

    https://bugzilla.redhat.com/show_bug.cgi?id=1441423


My application does not switch to production mode.

I have an application based on vue-cli and webpack. When you run the npm run build, the application does not go into production mode.
I already checked the documentation and apparently it is correct.
Thank you for your help.
vue --version = 2.2.0
<EMAIL_ADDRESS><EMAIL_ADDRESS>

with npm run build

with npm run dev

Please open issue in template repo.


feature support covar and covar_samp function

Proposed changes
Issue Number: close #30486
support covar and covar_samp function
+---------------------+
| covar(x, y)                |
+---------------------+
| 0.8944271909999    |
+---------------------+
1 row in set (0.21 sec)
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


How to use out of setup()?

The documention precise how to use vuejs3-logger outside of components, but I get an error when trying to use it outside (vuex store):
Vue warn]: inject() can only be used inside setup() or functional components.

import { inject } from 'vue'
…
async my_vuex_method() {
    …
    const logger = inject('vuejs3-logger')
    …
}

Thanks for porting vuejs-logger to vue3!

@sheoak Hi, thanks for filing an issue. I will try to look at it today and give you feedback.

@MarcSchaetz funny you just replied here a few minutes ago. I actually built a little solution for myself here and would like to suggest it as a implementation.
Basically, the behavior of other plugins nowadays seems to be to provide a createLogger function as a named export.
This createLogger then builds the logger and also has a key install which would be used by the app.use to call with the app and possible options.
All this could then be used by the user in a plugins/logger.js to build their own logger which has the same preferences inside components and outside.
In the mean time, I basically did the same for myself with a bit of a workaround (wrapping the vuejs3-logger in it's own plugin createLogger 🙈.
Maybe the code below will be helpful (it's workaround):
import VueLogger from 'vuejs3-logger'

const isProduction = process.env.NODE_ENV === 'production'

export const options = {
  isEnabled: true,
  logLevel: isProduction ? 'error' : 'debug',
  stringifyArguments: false,
  showLogLevel: true,
  showMethodName: true,
  separator: ':',
  showConsoleColors: true,
}

function createLogger(options) {
  return {
    install (app, installOptions = {}) {
      options = {...options, ...installOptions }
      app.use(VueLogger, options)
      console.log(`INSTALLING THE LOGGER`)
      console.log(`self:`, this)
      Object.assign(this, app.$log)
    }
  }
}

const loggerCreated = createLogger(options)

// outputs only the `{ install: … }` because at this point the logger is not installed and thus the `Object.assign` was not run. This however is also not possible to do any different way without going into the guts of the `vuejs3-logger` because the necessary function (`initLoggerInstance `) is currently `private`.
// console.log(`loggerCreated:`, loggerCreated)

export const logger = loggerCreated
export const log = loggerCreated

The improvement with official support of a createLogger function would solve all the issues and would make the logger available upon first call and not just after it actually was initiated with app.use.
Again, hope this helps and am looking forward to an update to this plugin 🌸.

Quick followup: with a bit more testing, this workaround does not work properly. I am experimenting with a createLogger function in my own local copy of vue3-logger however, I am not confident in Typescript and all that 🙈 . But maybe I can provide a scaffold based on my findings.

Further findings: This time it actually worked 🙈. The logger is now accessible outside of components and can be loaded by simply doing import { log } from '@/plugins/logger' in my project.
Please note again, I am not proficient in Typescript so this is probably "ugly" for some 🙈.
Here is the function I added to the vue3-logger.ts file:
public createLogger(options: ILoggerOptions) {
    options = Object.assign(this.getDefaultOptions(), options);

    if (this.isValidOptions(options, this.logLevels)) {
      const $log = this.initLoggerInstance(options, this.logLevels);
      $log.install = function (Vue: any, options: ILoggerOptions) {
        Vue.provide('vuejs3-logger', $log);
        Vue.config.globalProperties.$log = $log;
      }
      return $log
    } else {
        throw new Error(this.errorMessage);
    }
}

And here is my plugins/logger.js file which loads and creates the logger.
I have not found a way to directly export the createLogger so that I can simply do a import { createLogger } from 'vuejs3-logger' for now. But maybe a official release will fix that and someone with more understanding can get that done 🥇 .
import VueLogger from 'vuejs3-logger/src'

const isProduction = process.env.NODE_ENV === 'production'

export const options = {
  isEnabled: true,
  logLevel: isProduction ? 'error' : 'debug',
  stringifyArguments: false,
  showLogLevel: true,
  showMethodName: true,
  separator: ':',
  showConsoleColors: true,
}

const loggerCreated = VueLogger.createLogger(options)

export const logger = loggerCreated
export const log = loggerCreated

The documention precise how to use vuejs3-logger outside of components, but I get an error when trying to use it outside (vuex store):
Vue warn]: inject() can only be used inside setup() or functional components.

import { inject } from 'vue'
…
async my_vuex_method() {
    …
    const logger = inject('vuejs3-logger')
    …
}

Thanks for porting vuejs-logger to vue3!

@sheoak Ok, so I looked into it. The setup() is part of the dependency injection system of Vue3 and can only be called by components.
There are two solutions which I think are the simplest to go for.
Using the build-in Vuex logger
Vuex comes with it's own logger implementation, which can print useful informations about statechanges out of the box.
import { createLogger } from 'vuex'

const store = new Vuex.Store({
  plugins: [createLogger()]
})

Output:
mutation trylog @ 18:46:41.820
  prev state {}
  mutation {type: "trylog", payload: undefined}payload: undefinedtype: "trylog"
  next state {}

Call app.provide() to store the logger outside components.
createApp(App) returns you a reference to the application. There you can call provide() to register a value to a key.
The VueLogger stores itself into app.config.globalProperties.$log. So you could do something like this:
// main.ts

import VueLogger from 'vuejs3-logger';

const app = createApp(App)        // Create the application
                .use(VueLogger);  // Register VueLogger plugin

app.provide('vuejs3-logger-vuex', app.config.globalProperties.$log);  // Register the logger instance with another key
app.use(store);  // Register Vuex Plugin

app.mount('#app')

// store.ts
// ...

const logger = inject('vuejs3-logger-vuex');
logger.debug('Log message from store');

// ...

Further findings: This time it actually worked see_no_evil. The logger is now accessible outside of components and can be loaded by simply doing import { log } from '@/plugins/logger' in my project.
Please note again, I am not proficient in Typescript so this is probably "ugly" for some see_no_evil.
Here is the function I added to the vue3-logger.ts file:
public createLogger(options: ILoggerOptions) {
    options = Object.assign(this.getDefaultOptions(), options);

    if (this.isValidOptions(options, this.logLevels)) {
      const $log = this.initLoggerInstance(options, this.logLevels);
      $log.install = function (Vue: any, options: ILoggerOptions) {
        Vue.provide('vuejs3-logger', $log);
        Vue.config.globalProperties.$log = $log;
      }
      return $log
    } else {
        throw new Error(this.errorMessage);
    }
}

And below is my plugins/logger.js file which loads and creates the logger.
I have not found a way to directly export the createLogger so that I can simply do a import { createLogger } from 'vuejs3-logger' for now. But maybe a official release will fix that and someone with more understanding can get that done 1st_place_medal .
import VueLogger from 'vuejs3-logger/src'

const isProduction = process.env.NODE_ENV === 'production'

export const options = {
  isEnabled: true,
  logLevel: isProduction ? 'error' : 'debug',
  stringifyArguments: false,
  showLogLevel: true,
  showMethodName: true,
  separator: ':',
  showConsoleColors: true,
}

const loggerCreated = VueLogger.createLogger(options)

export const logger = loggerCreated
export const log = loggerCreated

@chrisspiegl  Thanks for the suggestion. I created a new issue (#2) for that. Would you please post your last comment there again? Thank you very much.

@MarcSchaetz Thank you for the suggestions with the vuex logger that is incredibly helpful and I did not know about before.
And I have posted my comment in the other issue 👍.

Great! I will try this as soon as possible, very helpful thank you!

The documention precise how to use vuejs3-logger outside of components, but I get an error when trying to use it outside (vuex store):
Vue warn]: inject() can only be used inside setup() or functional components.

import { inject } from 'vue'
…
async my_vuex_method() {
    …
    const logger = inject('vuejs3-logger')
    …
}

Thanks for porting vuejs-logger to vue3!

@sheoak Ok, so I looked into it. The setup() is part of the dependency injection system of Vue3 and can only be called by components.
There are two solutions which I think are the simplest to go for.
Using the build-in Vuex logger
Vuex comes with it's own logger implementation, which can print useful informations about statechanges out of the box.
import { createLogger } from 'vuex'

const store = new Vuex.Store({
  plugins: [createLogger()]
})

Output:
mutation trylog @ 18:46:41.820
  prev state {}
  mutation {type: "trylog", payload: undefined}payload: undefinedtype: "trylog"
  next state {}

Call app.provide() to store the logger outside components.
createApp(App) returns you a reference to the application. There you can call provide() to register a value to a key. The VueLogger stores itself into app.config.globalProperties.$log. So you could do something like this:
// main.ts

import VueLogger from 'vuejs3-logger';

const app = createApp(App)        // Create the application
                .use(VueLogger);  // Register VueLogger plugin

app.provide('vuejs3-logger-vuex', app.config.globalProperties.$log);  // Register the logger instance with another key
app.use(store);  // Register Vuex Plugin

app.mount('#app')

// store.ts
// ...

const logger = inject('vuejs3-logger-vuex');
logger.debug('Log message from store');

// ...

How can I use it in an external js file? for example, a js file encapsulates axios request? According to the api refrence, the provide/inject feature cann't be called outside setup function.  Except exporting the app instance createApp function returned, is there a more elegant way to do this?

I've been having similar issues, I wanted to use vuejs3-logger in Pinia but provide/inject didn't work somehow..
This is how I ended up doing, not sure if this is too hacky..
const app = createApp(App);
const pinia = createPinia();

pinia.use(({ store }) => {
  store.$log = markRaw(app.config.globalProperties.$log);
});

app.use(pinia);
app.use(router);
app.use(logger);

app.mount('#app');


Fix scroll up bug ref. #109

No need to hide results when busy.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


2.x - Performance optimizations geared towards legacy Polymer({...}) use

Behaviors:

Now mixed in lazily rather than at class time. This change means behaviors are no longer in the element's prototype chain.
A memoized list of behavior lifecycle methods is constructed at finalization time and then used at runtime.

Adds Polymer.legacyOptimizations flag which avoids copying element templates (needed for subclassing) and turns on stripWhitespace for all templates.
TemplateStamp: A TreeWalker is now used to crawl through template nodes. This should be slightly faster when the ShadyDOM polyfill is used.
Polymer.telemetry: now properly records registered elements, even if they have not been created

Also maybe add a test like
const b1 = { ready() {..} };
const b2 = { ready() {..} };
const b3 = { ready() {..} };
const b4 = { ready() {..} };
const sup = Polymer({is: 'sup', behaviors: [b1, b2], ready() {..} })
class sub extends mixinBehaviors([b3,b4], sup) { ready() {..} }

And verify that the lifecycle order goes:
sub, b4, b3, sup, b2, b1


Multi-input (image and continuous/categorical variables) models on Colab

Hello,
I have a project which combines both image data (Xrays) and clinical variables (both continuous and categorical) in a binary classification task. I would like to set this up in LUDWIG.
Based on the examples from the User Manual and Example page, it seems that the CSV file should contain the addresses of the images, and then all the other variables of interest can be stored in subsequent CSV columns.

Can we clarify if this is the best method for Google Colab? What do the addresses look like for the files stored on the mounted gdrive? Is there a way to point to these files without including their address in a CSV column?

Any considerations for the combiner?

Thanks!

@AnthonyBozzo - we haven't developed / tested anything with Google Colab. All the functionality for image classification examples is for running ludwig locally on your laptop. In this case CSV should contain either absolute file paths for the images or relative ones to the path of the CSV. Possibly it will work with Google Colab but ones needs to test and I'm not sure how paths are managed there.

To add to it, we are currently thinking about ways foe users to provide also raw images instead of paths, which would allow you to load the data from gdrive and then provide it to ludwig without the paths, but we are still working on it. If you find a handy way to make absolute paths work in Colab let us know!

Closing this for the moment, feel free to reopen if you have further questions, or open a thread on Gitq


thanks your work

thanks for your contribution.
is this repo still suitable for edgeSAM?

Yes, you can refer to https://github.com/dinglufe/segment-anything-cpp-wrapper.


Issues with gzip encoded responses

Not sure whether net-http is at fault here or zlib. In any case, when trying to use the standard http library, if the response is gzip encoded, the request hangs when trying to read the response. An example error + backtrace is here.
Using rbx-3.60, rubysl-net-http v2.0.4, rubysl-zlib v2.0.1
Steps to reproduce:
Make a request to http://gzip.com and try and read the body. e.g.
require 'net/http'

uri = URI('http://gzip.com')
puts Net::HTTP.get(uri)

This eventually times out and you get an error like the one in the gist (that one is a bit different since the call is wrapped by HTTParty). I would guess that zlib is still waiting on some data to properly finish, and it's not receiving it, hence the timeout and EOFError.

This issue is not actually to do with gzip encoding. It happens whenever the response contains multi-byte characters. The culprit is actually the Net::BufferedIO class, which counts characters and not bytes. When the request contains multi-byte characters it counts incorrectly and tries to read more data from the socket than is available. Issue on rubysl-net-protocol


Add LSC (Superpixel segmentation using Linear Spectral Clustering)

This PR adds LSC [1] superpixels for image segmentation.
Some infos:

Implementation here is properly cited in respect with authors.
Implementation is derived using BSD, authors [2] [3] agreed for the license terms used here.
Implementation booth follows opencv's coding standard but author original code.
Implementation behave as original one and speed is improved using opencv parallelism.
Implementation can handle CV_XXUC{Y} multichannel imagery too (tested on multispectral).
Implementation have documented flexible parameters and follows original matlab demo.

[1] http://jschenthu.weebly.com/projects.html
[2] Zhengqin Li <li-zq12 at mails dot tsinghua dot edu dot cn>
[3] Jiansheng Chen <jschenthu at mail dot tsinghua dot edu dot cn>
Authors are invited to this PR review, they may interact within process.

:+1: nice one!

@cbalint13, thank you very much for the contribution! and sorry again for a huge delay :+1:


Youtube documentation is out of date

Describe the bug
The current Youtube docs say that a URL should be printed in the logs.  This no longer happens, instead a browser window is opened.  This presents an issue for those configuring on their servers.  The docs should be amended to say that the first run should occur on a local machine, and that the configs can be copied to the server after that

Thanks Greg :)
There's also a project dedicated to documentation. Just wanted to make sure this issue is correctly registered

@ypatios The markdown doc under docs/guides/admin/ is what you want to update.  The docs project is the code powering docs.opencast.org, which deploys the docs from this project's docs/guides directory.


Fixed build_join_dependency to handle Squeel's join nodes.

This fix a compatibility issue with Squeel.

I don't see any tests for this fix -- how are you managing to push a Squeel join node through to build_join_dependency? Can you show a use case that fails without this patch?

Well I'm not sure how I managed to push the Squeel join, this happen in a relatively complex bit of code.
My controller send a scope (some are made using Squeel, others are more simple) dynamically to the model, but that seems to happens only when the relation is already scoped with a specific scope:
  scope(:with_course_inscriptions,
        joins(:course) \
          .includes(:course) \
          .joins { inscriptions.outer } \
          .group { course_events.id })

  scope :with_not_enough_inscriptions, lambda {
    with_course_inscriptions \
      .having { count(inscriptions.id) < coalesce(courses.minimum_inscriptions, 1) } \
      .select { courses.minimum_inscriptions } \
      .select :id # for count
  }

This is then passed to meta_search and it complains about Squeel::Nodes::Join being an unknown class. I wonder if it has to do the the group clause, which doesn't seems well handled by AR (the count method for example return a Hash that will_paginate doesn't handle).
I'll see if I can narrow it down.

Sorry, I still hadn't had the time to look further into this but while moving to Rails 3.2 I've checked that the bug is still there and here's the stacktrace, maybe it could be useful:
meta_search (1.1.3) lib/meta_search/builder.rb:279:in `build_join_dependency'
activesupport (3.2.1) lib/active_support/core_ext/enumerable.rb:27:in `group_by'
activesupport (3.2.1) lib/active_support/core_ext/enumerable.rb:26:in `each'
activesupport (3.2.1) lib/active_support/core_ext/enumerable.rb:26:in `group_by'
meta_search (1.1.3) lib/meta_search/builder.rb:268:in `build_join_dependency'
meta_search (1.1.3) lib/meta_search/builder.rb:39:in `initialize'
meta_search (1.1.3) lib/meta_search/searches/active_record.rb:42:in `new'
meta_search (1.1.3) lib/meta_search/searches/active_record.rb:42:in `search'
activerecord (3.2.1) lib/active_record/relation/delegation.rb:14:in `search'
activerecord (3.2.1) lib/active_record/relation.rb:240:in `scoping'
activerecord (3.2.1) lib/active_record/scoping.rb:98:in `with_scope'
activerecord (3.2.1) lib/active_record/relation.rb:240:in `scoping'
activerecord (3.2.1) lib/active_record/relation/delegation.rb:14:in `search'
app/controllers/intranet/base_controller.rb:21:in `course_events_scope'

Strangely enough, Squeel doesn't anywhere in the stacktrace. I really don't get it!

This happens to me when I use squeel in the join of a scope.
This doesn't work:
scope :where_user_is_editor, lambda{|user| joins{charity_editors}.where{charity_editors.id == user.id}}
But this does:
scope :where_user_is_editor, lambda{|user| joins(:charity_editors).where{charity_editors.id == user.id}}


correct delta_pre_compare for DBInstance

In PR #95, we added a customPreCompare function to
pkg/resource/db_instance/hooks.go and changed the generator.yaml to
use a code snippet instead of the
templates/hooks/db_instance/delta_pre_compare.go.tpl template file.
However, we did not delete the
templates/hooks/db_instance/delta_pre_compare.go.tpl file and when I
went to do the updating DB instance tags patch, nobody noticed that I
had added a call to compareTags into the (now-unused) template file.
This meant that compareTags is never called which means changes to
tags were not being properly on DBInstance resources.
This patch moves all the custom code for delta pre-checks back into the
template file and gets rid of the custom code snippet in generator.yaml,
consolidating all this logic into the template file.
Issue: aws-controllers-k8s/community#1276
Signed-off-by: Jay Pipes<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

/test rds-unit-test

e2e test failure is normal here, should be fixed in #108

gopkg.in is struggling a lot lately..

/test rds-unit-test

/test rds-unit-test

/test rds-unit-test

Looks like gopkg.in/yaml.v2 is having some issues. Tracking the problem here https://github.com/niemeyer/gopkg/issues/78