[BUG] useXFlagValue not updating on ConfigurationChanged events

Observed behavior
I've implemented what I thought to be the final implementation of the Flagsmith provider for OpenFeature, we'll be reviewing the PR internally before submitting it to js-contrib. It works entirely as expected except for this scenario.
Essentially the flow is as follows
Consumer:
OpenFeature.setProvider(new FlagsmithProvider({
    environmentID: "env",
    cacheFlags:true
}));

Flow:

Flagsmith SDK: gets flags from local storage, calls onChange
Open Feature Provider: gets onChange event

Emits a Ready event
Emits a ConfigurationChanged event
Successfully evaluates with values based on local storage

Flagsmith SDK: gets flags from server, calls onChange
Open Feature Provider: gets onChange event

Emits a Ready event
Emits a ConfigurationChanged event if the flags have indeed changed
Successfully evaluates with values based on flags from the server

Flagsmith SDK: persists new flags in local storage

In a non-react implementation this works perfectly when the the application listens to ProviderEvents.ConfigurationChanged and re-renders with new evaluated values.
Expected Behavior
I think the React SDK only checks for evaluation updates after a contextChanged has been triggered, I'd expect it to respond to ConfigurationChanged events if the new evaluations don't equal previous evaluations. Reading the docs it does seem like both context and configuration changes should be triggering the hooks, from what I've seen it's just context doing it.
If I trigger a context change via OpenFeature.setContext({...}) the hooks do successfully update, e.g. here. Setting context goes through the exact same flow as the last 3 steps above.
Steps to reproduce
Initialise a provider update its state without context changing and asynchronously trigger a ConfigurationChanged event.
I've been able to validate that the config changed event in my reproduction did trigger and that OpenFeature.getClient().getNumberValue() returns a newer value than the hook.

On testing this with multiple frameworks it seems I am only able to replicate this in an SSR context, I'll do some more digging and re-open if there's an issue.

@kyle-ssg I believe what you are describing is implemented in our react demo app here. Here, every 2 seconds we change the flags on the in-memory provider, which results in a re-render of the component based on the ConfigurationChanged event. I just tested it out and it seems to be working.
Can we sanity check a couple things?

what version of the react SDK are you using?

have you manually installed @openfeature/core or @openfeature/web-sdk? They should be installed automatically as peers, so they shouldn't be in your package.json

does the domain of the client match the domain of the provider?

Versions:
    "@openfeature/react-sdk": "^0.2.2-experimental",
    "@openfeature/web-sdk": "^1.0.0",

I'll remove web-sdk, I didn't realise it'd be a peer dependency.

Hey @toddbaert thanks for getting back to me
Versions:
    "@openfeature/react-sdk": "^0.2.2-experimental",
    "@openfeature/web-sdk": "^1.0.0",

I'll remove web-sdk, I didn't realise it'd be a peer dependency. As for the domains, the provider is set without one so it's always the default.
As for replication it may be a bit difficult since the provider isn't published yet. I'll look at why the sample app works and mine doesn't. I do know that:

this.events.emit(ProviderEvents.ConfigurationChanged) is called
ConfigurationChanged is being emitted
getNumberValue is resolving with a new value

There must be something else under the hood with my provider implementation that causes the hook not to re-evaluate.

Ok yeah my last point is the issue, there's a race condition.

App: First render with default flags useNumberFlagValue(...)=>12
Provider: calls back with configuration change as a result of reading cache (pretty much immediate for web)
Open Feature - initialises configuration changed handler ever so slightly too late since it's in useEffect

I'm wondering whether I can avoid this issue Flagsmith's SDK side / whether configchanges would beat useEffect in other scenarios / providers, I'm not sure how long the asynchronous the delay for useEffects could be.
Our web cache can technically be synchronous, we just make it async to genericise other platform storage e.g. react native.

Ahh very interesting.
OK if I'm understanding correctly, that means that you are basically missing only 1 initial event in your test app due to this race condition; if you got additional changes from the Flagsmith backend, you would see those, yes?

If this first event is always just a result of reading from cache, maybe it's worth doing that read from cache in the initialize, which will mean we have read the cached state before anything is rendered.
Then, only subsequent changes coming from the network will cause further change events, long after all the handlers are set up.

Ahh very interesting.
OK if I'm understanding correctly, that means that you are basically missing only 1 initial event in your test app due to this race condition; if you got additional changes from the Flagsmith backend, you would see those, yes?

Yeah exactly if a change event occurred 50ms later we'd get a re-render due to the hook.

If this first event is always just a result of reading from cache, maybe it's worth doing that read from cache in the initialize, which will mean we have read the cached state before anything is rendered (seems like not a bad idea since this is guaranteed to be fast).
Then, only subsequent changes coming from the network ("real" change events) will cause further change events, long after all the handlers are set up.

Yeah I think maybe you're right, default flags can probably hold off on our end until cache is evaluated.

I can confirm that moving Flagsmith to synchronous cache fixes the issue I observed.
I think this can be closed, but I'm not 100% sure. Technically if a Provider's init is very fast I think this could still be replicable?

Ok it seems in that case the synchronous state above, it can be resolved by setting this the Provider constructor, not on initialize.
I think I'll close this as all paths lead to being able to resolve this in providers.

Thanks @kyle-ssg , good to have this discussion for posterity and education anyway.


Prevent browsers from caching schema responses

Should fix time out messages described here:
https://github.com/silverstripe/silverstripe-mfa/issues/414

Cheers for the PR - I've modified it to use the "official" method of disabling HTTP cache headers here - https://github.com/silverstripe/silverstripe-mfa/pull/417 which also targets the 4.2 branch so that we can tag a patch release once it's been merged

Cheers for the PR - I've modified it to use the "official" method of disabling HTTP cache headers here - https://github.com/silverstripe/silverstripe-mfa/pull/417 which also targets the 4.2 branch so that we can tag a patch release once it's been merged


Correct behavior for unexpected parameters on update requests?

There are a couple branches of parameter validation where we are ignoring erroneous inputs:

Users passing updated parameters that don't exist on a plan.
Users passing enum values that aren't part of the acceptable set of values.

In both cases, we strip them from the request parameters. I think they should be Bad Request 400s, mainly because I think these represent a user's explicit intent, and they will be surprised when that intent has silently been ignored because it is fundamentally invalid. Looking for some thoughts on this before I submit my changes.

Solved with #734, they're errors and should be 400 responses.


Feat/automate headscale unit test

Solving issue #2

This PR is no longer required as headscale-client module has been externalized in its own repository : https://github.com/adrienmrgn/headscale-client


reallocate if capacity is not enough

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 469 (4.48%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 9.093%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/reedsolomon/generated.go
21
469
4.48%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
433

Relevant Lines:
4762

💛  - Coveralls


Remove version: BookStairs.bookhunter version 0.13.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/bookstairs/bookhunter/releases/download/v0.13.0/bookhunter_0.13.0_windows_386.zip
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 910)


Review all fonts

I have detected several wrong font sizes and weights, please review.
Few examples in the image are

attached but it seems there are more.

This font seems different:

Are this fonts with those values?

Yes, all fonts are exactly the same as in the design, it's just as it look like for some reason, this was an issue addressed in previous widgets also.


Enable GCS aliases for releases

This allows us to have a pointer to the latest release, like a docker
tag.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-cni_istio
f5eee683c9c4925caeb84950d2e23092bb896cf9
link
/test e2e-simpleTests-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-cni_istio
f5eee683c9c4925caeb84950d2e23092bb896cf9
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests_istio
f5eee683c9c4925caeb84950d2e23092bb896cf9
link
/test e2e-simpleTests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-cni_istio
f5eee683c9c4925caeb84950d2e23092bb896cf9
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests_istio
f5eee683c9c4925caeb84950d2e23092bb896cf9
link
/test e2e-simpleTests_istio

pilot-multicluster-e2e_istio
f5eee683c9c4925caeb84950d2e23092bb896cf9
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Mac Client stays at "loading…" screen

Keybase GUI Version: 1.0.21-20170428110011+0ccdf77
Choosing "Log in" from the tool menu opens a key base screen, which displays "Loading…" forever.
It's not possible to log in.

Please send a keybase log send and report your log ID


Elementwise multiplication - operation example or explanation for implicit

Hello,
I would love to get some help to make below working, i have trouble understanding the signature in terms of the implicits required.
it would be highly appreciated if the answer gives me some link to do further study.
I intend to multiply the elements by elements for the matching index, so below i expect it to return
0  0
4  5

code below:
import breeze.linalg.DenseMatrix.ones
import breeze.linalg.{*, DenseMatrix}
import spire.implicits.rightModuleOps

val m1=DenseMatrix((1,2),(4,5));
val m2=DenseMatrix((0,0),(1,1))
m1 :* m2

it has error when i try to compile
could not find implicit value for parameter ev: spire.algebra.RightModule[breeze.linalg.DenseMatrix[Int],breeze.linalg.DenseMatrix[Int]]

output in console for creating the m1 and m2
val m1: breeze.linalg.DenseMatrix[Int] =
1  2
4  5
val m2: breeze.linalg.DenseMatrix[Int] =
0  0
1  1

what should I do to get create/load/import the required implict? what is the implicit trying to do?

oh.... maybe i should have used :*=, i just found it in the code base when searching for :*

Sorry for being slow. The operator for elementwise multiplication is now *:* because it has better precedence behavior


GL sharing: Test name adjustment and Windows compilation clarification.

Fix issue #332

Quick instruction how to build GL tests on Windows:

download from the Internet : glew-2.1.0-win32.zip freeglut-MSVC-3.0.0-2.mp.zip
extract include\GL header files to OpenCL-CTS\test_conformance\gl\GL\
extract library files (glew32 and freeglut) to OpenCL-CTS\lib\x64\
generate solution adding params: -DGL_IS_SUPPORTED=ON -DCLConform_GL_LIBRARIES_DIR=lib\x64
run compilation
finally copy dlls (freeglut.dll glew32.dll) from zip packages to binary localization

Ubuntu:

freeglut and glew packages installation needed
generate solution adding params: -DGL_IS_SUPPORTED=ON
no header/library files copy needed
run compilation


OCW-2 #comment Updated to work with Google's latest version of oauth2…

…client library.
For reference: https://github.com/google/oauth2client/issues/401

Beyond that one very minor issue it looks great.

Coverage increased (+0.03%) to 69.65% when pulling 65623358f8138f2ece343005287da34ea4a58588 on OCW-2 into 03d681f52873fcef1af0e550aacd4d891ba44725 on master.


Add terms for software domain

It looks like the best source is http://www.microsoft.com/Language/en-US/Terminology.aspx but requires us to show the origin of terms, which we currently can't do.
I'm also investigating http://iate.europa.eu/tbxPageDownload.do


Prevent creation of windows ami datasource when we don't define windows worker nodes

I have issues
I'm submitting a...

[ ] bug report
[x] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
I've just created an EKS cluster and I saw that the module is creating eks_worker_windows automatically.
Is there a way to prevent eks_worker_windows creation? I would like to keep my state as clean as possible.
Thanks.

Humm... Sounds wired. The module create linux boxes by default.
It creates windows boxes only when platform=windows.
Please share your code, module version, terraform versions and plan output.

Sure,
module version: 13.1.0
code:
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "13.1.0"

  cluster_name                    = var.cluster_name
  cluster_version                 = "1.18"
  cluster_create_timeout          = "1h"
  cluster_endpoint_private_access = true

  subnets = [
    module.vpc.k8s_subnet_eu_central_1a,
    module.vpc.k8s_subnet_eu_central_1b
  ]

  vpc_id = module.vpc.main_vpc_id

  node_groups = [
    {
      name                 = "default-node-group"
      instance_type        = "t2.medium"
      asg_desired_capacity = 1
      min_capacity         = 1
      max_capacity         = 3
      key_name             = ""
    }
  ]
}

plan:
Terraform will perform the following actions:

  # data.aws_eks_cluster.cluster will be read during apply
  # (config refers to values not yet known)
 <= data "aws_eks_cluster" "cluster"  {
      + arn                       = (known after apply)
      + certificate_authority     = (known after apply)
      + created_at                = (known after apply)
      + enabled_cluster_log_types = (known after apply)
      + endpoint                  = (known after apply)
      + id                        = (known after apply)
      + identity                  = (known after apply)
      + name                      = (known after apply)
      + platform_version          = (known after apply)
      + role_arn                  = (known after apply)
      + status                    = (known after apply)
      + tags                      = (known after apply)
      + version                   = (known after apply)
      + vpc_config                = (known after apply)
    }

  # data.aws_eks_cluster_auth.cluster will be read during apply
  # (config refers to values not yet known)
 <= data "aws_eks_cluster_auth" "cluster"  {
      + id    = (known after apply)
      + name  = (known after apply)
      + token = (sensitive value)
    }

  # module.eks.aws_eks_cluster.this[0] will be created
  + resource "aws_eks_cluster" "this" {
      + arn                   = (known after apply)
      + certificate_authority = (known after apply)
      + created_at            = (known after apply)
      + endpoint              = (known after apply)
      + id                    = (known after apply)
      + identity              = (known after apply)
      + name                  = "my-cluster"
      + platform_version      = (known after apply)
      + role_arn              = (known after apply)
      + status                = (known after apply)
      + version               = "1.18"

      + timeouts {
          + create = "1h"
          + delete = "15m"
        }

      + vpc_config {
          + cluster_security_group_id = (known after apply)
          + endpoint_private_access   = true
          + endpoint_public_access    = true
          + public_access_cidrs       = [
              + "<IP_ADDRESS>/0",
            ]
          + security_group_ids        = (known after apply)
          + subnet_ids                = (known after apply)
          + vpc_id                    = (known after apply)
        }
    }

  # module.eks.aws_iam_policy.cluster_elb_sl_role_creation[0] will be created
  + resource "aws_iam_policy" "cluster_elb_sl_role_creation" {
      + arn         = (known after apply)
      + description = "Permissions for EKS to create AWSServiceRoleForElasticLoadBalancing service-linked role"
      + id          = (known after apply)
      + name        = (known after apply)
      + name_prefix = "my-cluster-elb-sl-role-creation"
      + path        = "/"
      + policy      = jsonencode(
            {
              + Statement = [
                  + {
                      + Action   = [
                          + "ec2:DescribeInternetGateways",
                          + "ec2:DescribeAccountAttributes",
                        ]
                      + Effect   = "Allow"
                      + Resource = "*"
                      + Sid      = ""
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
    }

  # module.eks.aws_iam_role.cluster[0] will be created
  + resource "aws_iam_role" "cluster" {
      + arn                   = (known after apply)
      + assume_role_policy    = jsonencode(
            {
              + Statement = [
                  + {
                      + Action    = "sts:AssumeRole"
                      + Effect    = "Allow"
                      + Principal = {
                          + Service = "eks.amazonaws.com"
                        }
                      + Sid       = "EKSClusterAssumeRole"
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
      + create_date           = (known after apply)
      + force_detach_policies = true
      + id                    = (known after apply)
      + max_session_duration  = 3600
      + name                  = (known after apply)
      + name_prefix           = "my-cluster"
      + path                  = "/"
      + unique_id             = (known after apply)
    }

  # module.eks.aws_iam_role.workers[0] will be created
  + resource "aws_iam_role" "workers" {
      + arn                   = (known after apply)
      + assume_role_policy    = jsonencode(
            {
              + Statement = [
                  + {
                      + Action    = "sts:AssumeRole"
                      + Effect    = "Allow"
                      + Principal = {
                          + Service = "ec2.amazonaws.com"
                        }
                      + Sid       = "EKSWorkerAssumeRole"
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
      + create_date           = (known after apply)
      + force_detach_policies = true
      + id                    = (known after apply)
      + max_session_duration  = 3600
      + name                  = (known after apply)
      + name_prefix           = "my-cluster"
      + path                  = "/"
      + unique_id             = (known after apply)
    }

  # module.eks.aws_iam_role_policy_attachment.cluster_AmazonEKSClusterPolicy[0] will be created
  + resource "aws_iam_role_policy_attachment" "cluster_AmazonEKSClusterPolicy" {
      + id         = (known after apply)
      + policy_arn = "arn:aws:iam::aws:policy/AmazonEKSClusterPolicy"
      + role       = (known after apply)
    }

  # module.eks.aws_iam_role_policy_attachment.cluster_AmazonEKSServicePolicy[0] will be created
  + resource "aws_iam_role_policy_attachment" "cluster_AmazonEKSServicePolicy" {
      + id         = (known after apply)
      + policy_arn = "arn:aws:iam::aws:policy/AmazonEKSServicePolicy"
      + role       = (known after apply)
    }

  # module.eks.aws_iam_role_policy_attachment.cluster_AmazonEKSVPCResourceControllerPolicy[0] will be created
  + resource "aws_iam_role_policy_attachment" "cluster_AmazonEKSVPCResourceControllerPolicy" {
      + id         = (known after apply)
      + policy_arn = "arn:aws:iam::aws:policy/AmazonEKSVPCResourceController"
      + role       = (known after apply)
    }

  # module.eks.aws_iam_role_policy_attachment.cluster_elb_sl_role_creation[0] will be created
  + resource "aws_iam_role_policy_attachment" "cluster_elb_sl_role_creation" {
      + id         = (known after apply)
      + policy_arn = (known after apply)
      + role       = (known after apply)
    }

  # module.eks.aws_iam_role_policy_attachment.workers_AmazonEC2ContainerRegistryReadOnly[0] will be created
  + resource "aws_iam_role_policy_attachment" "workers_AmazonEC2ContainerRegistryReadOnly" {
      + id         = (known after apply)
      + policy_arn = "arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
      + role       = (known after apply)
    }

  # module.eks.aws_iam_role_policy_attachment.workers_AmazonEKSWorkerNodePolicy[0] will be created
  + resource "aws_iam_role_policy_attachment" "workers_AmazonEKSWorkerNodePolicy" {
      + id         = (known after apply)
      + policy_arn = "arn:aws:iam::aws:policy/AmazonEKSWorkerNodePolicy"
      + role       = (known after apply)
    }

  # module.eks.aws_iam_role_policy_attachment.workers_AmazonEKS_CNI_Policy[0] will be created
  + resource "aws_iam_role_policy_attachment" "workers_AmazonEKS_CNI_Policy" {
      + id         = (known after apply)
      + policy_arn = "arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy"
      + role       = (known after apply)
    }

  # module.eks.aws_security_group.cluster[0] will be created
  + resource "aws_security_group" "cluster" {
      + arn                    = (known after apply)
      + description            = "EKS cluster security group."
      + egress                 = (known after apply)
      + id                     = (known after apply)
      + ingress                = (known after apply)
      + name                   = (known after apply)
      + name_prefix            = "my-cluster"
      + owner_id               = (known after apply)
      + revoke_rules_on_delete = false
      + tags                   = {
          + "Name" = "my-cluster-eks_cluster_sg"
        }
      + vpc_id                 = (known after apply)
    }

  # module.eks.aws_security_group.workers[0] will be created
  + resource "aws_security_group" "workers" {
      + arn                    = (known after apply)
      + description            = "Security group for all nodes in the cluster."
      + egress                 = (known after apply)
      + id                     = (known after apply)
      + ingress                = (known after apply)
      + name                   = (known after apply)
      + name_prefix            = "my-cluster"
      + owner_id               = (known after apply)
      + revoke_rules_on_delete = false
      + tags                   = {
          + "Name"                             = "my-cluster-eks_worker_sg"
          + "kubernetes.io/cluster/my-cluster" = "owned"
        }
      + vpc_id                 = (known after apply)
    }

  # module.eks.aws_security_group_rule.cluster_egress_internet[0] will be created
  + resource "aws_security_group_rule" "cluster_egress_internet" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + description              = "Allow cluster egress access to the Internet."
      + from_port                = 0
      + id                       = (known after apply)
      + protocol                 = "-1"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 0
      + type                     = "egress"
    }

  # module.eks.aws_security_group_rule.cluster_https_worker_ingress[0] will be created
  + resource "aws_security_group_rule" "cluster_https_worker_ingress" {
      + description              = "Allow pods to communicate with the EKS cluster API."
      + from_port                = 443
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 443
      + type                     = "ingress"
    }

  # module.eks.aws_security_group_rule.workers_egress_internet[0] will be created
  + resource "aws_security_group_rule" "workers_egress_internet" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + description              = "Allow nodes all egress to the Internet."
      + from_port                = 0
      + id                       = (known after apply)
      + protocol                 = "-1"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 0
      + type                     = "egress"
    }

  # module.eks.aws_security_group_rule.workers_ingress_cluster[0] will be created
  + resource "aws_security_group_rule" "workers_ingress_cluster" {
      + description              = "Allow workers pods to receive communication from the cluster control plane."
      + from_port                = 1025
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 65535
      + type                     = "ingress"
    }

  # module.eks.aws_security_group_rule.workers_ingress_cluster_https[0] will be created
  + resource "aws_security_group_rule" "workers_ingress_cluster_https" {
      + description              = "Allow pods running extension API servers on port 443 to receive communication from cluster control plane."
      + from_port                = 443
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 443
      + type                     = "ingress"
    }

  # module.eks.aws_security_group_rule.workers_ingress_self[0] will be created
  + resource "aws_security_group_rule" "workers_ingress_self" {
      + description              = "Allow node to communicate with each other."
      + from_port                = 0
      + id                       = (known after apply)
      + protocol                 = "-1"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 65535
      + type                     = "ingress"
    }

  # module.eks.kubernetes_config_map.aws_auth[0] will be created
  + resource "kubernetes_config_map" "aws_auth" {
      + data = (known after apply)
      + id   = (known after apply)

      + metadata {
          + generation       = (known after apply)
          + labels           = {
              + "app.kubernetes.io/managed-by" = "Terraform"
              + "terraform.io/module"          = "terraform-aws-modules.eks.aws"
            }
          + name             = "aws-auth"
          + namespace        = "kube-system"
          + resource_version = (known after apply)
          + self_link        = (known after apply)
          + uid              = (known after apply)
        }
    }

  # module.eks.local_file.kubeconfig[0] will be created
  + resource "local_file" "kubeconfig" {
      + content              = (known after apply)
      + directory_permission = "0755"
      + file_permission      = "0644"
      + filename             = "./kubeconfig_my-cluster"
      + id                   = (known after apply)
    }

  # module.eks.null_resource.wait_for_cluster[0] will be created
  + resource "null_resource" "wait_for_cluster" {
      + id = (known after apply)
    }

  # module.eks.module.node_groups.aws_eks_node_group.workers["0"] will be created
  + resource "aws_eks_node_group" "workers" {
      + ami_type        = (known after apply)
      + arn             = (known after apply)
      + cluster_name    = "my-cluster"
      + disk_size       = (known after apply)
      + id              = (known after apply)
      + instance_types  = [
          + "t2.medium",
        ]
      + node_group_name = (known after apply)
      + node_role_arn   = (known after apply)
      + release_version = (known after apply)
      + resources       = (known after apply)
      + status          = (known after apply)
      + subnet_ids      = (known after apply)
      + version         = (known after apply)

      + scaling_config {
          + desired_size = 1
          + max_size     = 3
          + min_size     = 1
        }
    }

  # module.eks.module.node_groups.random_pet.node_groups["0"] will be created
  + resource "random_pet" "node_groups" {
      + id        = (known after apply)
      + keepers   = (known after apply)
      + length    = 2
      + separator = "-"
    }

And in my state i see this:
{
      "module": "module.eks.module.eks",
      "mode": "data",
      "type": "aws_ami",
      "name": "eks_worker_windows",
      "provider": "provider[\"registry.terraform.io/hashicorp/aws\"]",
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "architecture": "x86_64",
            "arn": "arn:aws:ec2:eu-central-1::image/ami-07bffee763ff72ecf",
            "block_device_mappings": [
              {
                "device_name": "/dev/sda1",
                "ebs": {
                  "delete_on_termination": "true",
                  "encrypted": "false",
                  "iops": "0",
                  "snapshot_id": "snap-0b9da638a127e8e17",
                  "volume_size": "50",
                  "volume_type": "gp2"
                },
                "no_device": "",
                "virtual_name": ""
              },
              {
                "device_name": "xvdca",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral0"
              },
              {
                "device_name": "xvdcb",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral1"
              },
              {
                "device_name": "xvdcc",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral2"
              },
              {
                "device_name": "xvdcd",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral3"
              },
              {
                "device_name": "xvdce",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral4"
              },
              {
                "device_name": "xvdcf",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral5"
              },
              {
                "device_name": "xvdcg",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral6"
              },
              {
                "device_name": "xvdch",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral7"
              },
              {
                "device_name": "xvdci",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral8"
              },
              {
                "device_name": "xvdcj",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral9"
              },
              {
                "device_name": "xvdck",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral10"
              },
              {
                "device_name": "xvdcl",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral11"
              },
              {
                "device_name": "xvdcm",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral12"
              },
              {
                "device_name": "xvdcn",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral13"
              },
              {
                "device_name": "xvdco",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral14"
              },
              {
                "device_name": "xvdcp",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral15"
              },
              {
                "device_name": "xvdcq",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral16"
              },
              {
                "device_name": "xvdcr",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral17"
              },
              {
                "device_name": "xvdcs",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral18"
              },
              {
                "device_name": "xvdct",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral19"
              },
              {
                "device_name": "xvdcu",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral20"
              },
              {
                "device_name": "xvdcv",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral21"
              },
              {
                "device_name": "xvdcw",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral22"
              },
              {
                "device_name": "xvdcx",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral23"
              },
              {
                "device_name": "xvdcy",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral24"
              },
              {
                "device_name": "xvdcz",
                "ebs": {},
                "no_device": "",
                "virtual_name": "ephemeral25"
              }
            ],
            "creation_date": "2020-10-30T17:29:22.000Z",
            "description": "Microsoft Windows Server 2019 Core optimized for EKS and provided by Amazon",
            "executable_users": null,
            "filter": [
              {
                "name": "name",
                "values": [
                  "Windows_Server-2019-English-Core-EKS_Optimized-1.18-*"
                ]
              },
              {
                "name": "platform",
                "values": [
                  "windows"
                ]
              }
            ],
            "hypervisor": "xen",
            "id": "ami-07bffee763ff72ecf",
            "image_id": "ami-07bffee763ff72ecf",
            "image_location": "amazon/Windows_Server-2019-English-Core-EKS_Optimized-1.18-2020.10.29",
            "image_owner_alias": "amazon",
            "image_type": "machine",
            "kernel_id": null,
            "most_recent": true,
            "name": "Windows_Server-2019-English-Core-EKS_Optimized-1.18-2020.10.29",
            "name_regex": null,
            "owner_id": "801119661308",
            "owners": [
              "amazon"
            ],
            "platform": "windows",
            "product_codes": [],
            "public": true,
            "ramdisk_id": null,
            "root_device_name": "/dev/sda1",
            "root_device_type": "ebs",
            "root_snapshot_id": "snap-0b9da638a127e8e17",
            "sriov_net_support": "simple",
            "state": "available",
            "state_reason": {
              "code": "UNSET",
              "message": "UNSET"
            },
            "tags": {},
            "virtualization_type": "hvm"
          }
        }
      ]
    }

You're just getting the windows ami (ami data source). It doesn't do anything. As you can notice in your plan, there are no windows node.

Yes i now, but I'm not using it so it's quite annoying to have it in the state. Is there a way to remove it?

Yes, i know but it's quite useless to keep it in the state if i don't use it. Is there a way to remove it?

We can't right now. I don't think, this make any harm, But I'll happy to review a PR for that.

Thanks @barryib

have same problem, is this resolved yet ?

The windows AMI lookup is currently breaking upgrading clusters to v1.19 as there isnt a v1.19 windows AMI available yet (at least not in my regions).
Bit annoying to troubleshoot because TF just exits with an error "Your query returned no results." and doesn't actually tell you which resource caused the problem 🙄
Workaround is to change the worker_ami_name_filter_windows variable.

how about if we don't want to use any windows AMI ? , because right now, that data state is always shown on a plan (always changing)

I just opened https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1371 to address this. Will you please review it and test it ?


Async?

Hello, is there a way to do the processing asynchronously?

we use Q for that

@watdafox Elaborate?

Well, on our project, we use Q to make the entire process a promise.

Call a custom function where vibrantjs does its magic (behind a Q.defer).
Wait for the promise to be completed before continuing with vibrantjs data.

https://git.popcorntime.io/popcorntime/desktop/blob/feature/materialDesign/src/app/lib/views/browser/item.js#L528

Thanks for sharing.
Yea, there's many ways to do this async, there's a lot of promises libraries.
And to be honest, it's not that intensive of a calculation to begin with (takes a milisecond at max), so I don't really see the point of adding it to vibrant itself or something.
Answer to the initial question: use Q, or ES6 promises
Offtopic: @sv244 told me you guys were using vibrant, I think it's really cool, popcorn time is my favorite way to waste time!
If you have any questions, feel free to ask any time. (here or on twitter @jarizwarts)


docs: Add Clear Linux installation guide.

This commit documents the steps needed to setup Clear Containers
3.0 in Clear Linux.
Fixes #601.
Signed-off-by: Salvador Fuentes<EMAIL_ADDRESS>

@jodh-intel thanks for your comments, all addressed.
@iphutch can you please take a look?
Thanks.

Also, all lines associated with a number need to be indented to begin where the text directly following the number begins.

@iphutch thanks, all issues addressed.

@iphutch, @jodh-intel, fixed issues, can you re-review?
Thanks

lgtm

The F26 CI run has failed due to #622.

seems like coveralls is now stuck, anyone know how to fix it?

@sboeuf - do you know what has happened here? Both Ubuntu Jenkins CI logs seem to have "disappeared" (HTTP ERROR 404)?
This change passed under Fedora, and really doesn't need a coveralls run as it's a doc-only change. Merging.
lgtm.


Support for bcrypt migration

I am sure you already know about  bcrypt—probably the Django app, too. To everyone else not familiar, it is, at its core, a (much) securer way to store users’ passwords.
django-bcrypt is very easy to install (unless you run Windows). The only issue is with pre-existing users who already have a password in the database converted by Django’s default SHA1. In order to migrate these passwords to bcrypt, people can either include BCRYPT_MIGRATE = True in settings.py and run a manual check_password() on all users manually—or they can write a manual check in their log-in view as detailed here:
def login(request):
    if request.method == 'POST':
        form = AuthenticationForm(request.POST)

        if form.is_valid():
            user = form.get_user()

            if user.password.startswith('sha1'):
                user.set_password(form['password'])
                user.save()

            # [etc]

The latter is preferable. I don’t know how you want to implement this specifically, so I refrained from doing a pull request, as it was guaranteed to get completely refactored to your own style anyway.

I believe better password hashing (with bcrypt?) will be released in Django 1.4. I'm waiting on that, if it's not sufficient, bcrypt will be made part of userena as above. Thanks for showing how it could be done.

Will be implemented in Django 1.4: See Using bcrypt with Django
For people using < 1.4, there is django-bcrypt, implementing it is the responsibility of the project leader, which can be done by overriding the SigninForm. We can't make that decision for them.


Refine TF Object Detection Examples For New API

Type of Change
feature or bug fix or documentation or validation or others
API changed or not: No
Description
detail description
JIRA ticket: 2594
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR : as title
How has this PR been tested?
how to reproduce the test (including hardware information) : Extension
Dependency Change?
any library dependency introduced or removed: No

Please update the examples/README.md for the refined examples.

/Azurepipeline run Model-Test

Please follow the latest example readme template to refine the readme structure.

Need extension test for these models @chensuyue

extension test

Extension for yolo_v3: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/4137/

Rebuild extension of all other models except ckpt: https://inteltf-jenk.sh.intel.com/view/lpot-validation/job/intel-lpot-validation-top-mr-extension/4153/

Extension test: https://inteltf-jenk.sh.intel.com/view/lpot-validation/job/intel-lpot-validation-top-mr-extension/4173/

Extension test: https://inteltf-jenk.sh.intel.com/view/lpot-validation/job/intel-lpot-validation-top-mr-extension/4173/

Please check acc and perf gap.
Check CKPT model fp32 benchmark.

Extension for models with ckpt: https://inteltf-jenk.sh.intel.com/view/lpot-validation/job/intel-lpot-validation-top-mr-extension/4190/

Extension for models with ckpt: https://inteltf-jenk.sh.intel.com/view/lpot-validation/job/intel-lpot-validation-top-mr-extension/4199/


what is your offline score

Hello！
First of all, thank you very much for your open source.
I am very interested in your implementation, so I downloaded your code and implemented it on my machine. My GPU is TiTanic Xp.
After I finished running the file "model.py" with setting epochs=15, and I got the result of the validation set loss of about 0.203 (training set loss is about 0.17). The results of the model training don't seem so good!
I find you have a ranking of 23 on kaggle and an online score of 0.12988, so I would like to ask, what is your offline score? How can I use this open source code to achieve the same validation loss as you?
Looking forward to your reply.Thanks again!
@aerdem4

Hi, thanks for your question. The validation error you see is on one fold. When you run it for all the folds and take average of the models generated in each fold you get some gain from ensembling. In addition, if you look at postprocessing, I do some extra things to improve my score. As a last remark, logloss is a class balance sensitive metric, therefore logloss on train/val set and test set (Kaggle LB) can be very different since Kaggle didn't split them randomly.

Thank you very much for your reply!
I understand what you mean. By the way, how does the correct rate of the test set be estimated? Is the probability greater than 0.9?

Thank you very much for your reply!
I understand what you mean. By the way, how does the correct rate of the test set be estimated? Is the probability greater than 0.9?
@aerdem4


Investigate replacing makeWrapper shell script with an executable

Just capturing a discussion from #nixos IRC:
<shlevy> replace makeWrapper with a c program  [15:52]
<phreedom_> shlevy: now that may be more interesting  [15:53]
<shlevy> phreedom_: It would be really easy
<shlevy> But I suspect people will complain about the opacity of it all
<shlevy> Want to be able to cat the wrapper and see what it's doing to the env
<phreedom_> shlevy: you can always just replace the #!/bin/bash with
            #!/faster/wrapper  [15:54]
<phreedom_> i don't know how much you are going to save over sh
<phreedom_> it needs benchmarking
<shlevy> True

Before starting anywork, we should:
<phreedom_> ocharles: for example try benchmarking wrapped and non-wrapped app
            first

I would mostly need this for wrappers to preserve shell environment. Currently if I run tox, it wraps the tox executable in a bash script and it doesn't include current shell environment.
Current workaround is to use source $(which tox)

See also the previous discussion at
http://lists.science.uu.nl/pipermail/nix-dev/2014-November/014984.html
where execline was proposed as an option...
On Mon, Apr 13, 2015 at 6:49 PM Domen Kožar<EMAIL_ADDRESS>wrote:

I would mostly need this for wrappers to preserve shell environment.
Currently if I run tox, it wraps the tox executable in a bash script and
it doesn't include current shell environment.
Current workaround is to use source $(which tox)
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/1263#issuecomment-92422902.

Could we somehow include debugging info? Maybe in a separate file suffixed with -info

Hmmm, I suppose we could make the bash script as well to aid in debugging...
On Mon, Apr 13, 2015 at 6:56 PM Domen Kožar<EMAIL_ADDRESS>wrote:

Could we somehow include debugging info? Maybe in a separate file
suffixed with -info
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/1263#issuecomment-92424209.

-1. I don't think we should replace shell wrappers with C. We should make wrappers that match the language of the program they're wrapping (wrapper language == real prog language). I don't have any refs now, but there are problems with the current approach, and this is not solved by switching to C.

I don't think a Github issue is the right place to capture this discussion - the mailing list would be better. I don't feel strongly about this, and would like to close the issue. Any objections?

In fact, if you have objections let me know, but otherwise I will close this. Shoot first, ask questions later ;)

Nfŕt
Sent from my Samsung device
-------- Original message --------
From: Oliver Charles<EMAIL_ADDRESS>Date: 12/16/16  4:23 PM  (GMT+07:00)
To: NixOS/nixpkgs<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [NixOS/nixpkgs] Investigate replacing makeWrapper shell script
  with an executable (#1263)
Closed #1263.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/NixOS/nixpkgs","title":"NixOS/nixpkgs","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/NixOS/nixpkgs"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #1263."}],"action":{"name":"View Issue","url":"https://github.com/NixOS/nixpkgs/issues/1263#event-896430176"}}}


thread based sort ?

related: https://chapel-lang.org/blog/posts/std-sort-performance/

IMO, this shouldn't be a focus. Maybe this would also be better placed in https://github.com/JuliaCollections/SortingAlgorithms.jl or elsewhere.

I think it's not a totally unreasonable thing to put in here if someone wants to write the algorithm, but I agree it's not really something I'd focus on personally.

This won't be our focus any time soon, if at all, which is why I'm closing this.


Added code to handle medical care policies

Sent you a msg on Steam ;) Hope you're doing fine!!

I've added the medcare to base code but defaults should be kept from vanilla. Thanks Deno


Desktop software CPU usage

Describe the bug
MaxMix desktop software is constantly using about 16% of my i7-4790K CPU.
To Reproduce
Steps to reproduce the behavior:

Launch MaxMix 1.0 without any MaxMix device connected.
Launch Windows TaskManager.
Check CPU usage for MaxMix software in the TaskManager.

Expected behavior
Desktop software should use less CPU.
Screenshots

Desktop :

OS: Windows 10 Pro.
Version: 19.09

Additional context
Have not inspected the code yet, but I suppose the software is sending handshake too often ?

That's weird, I can't repro it. It peaks at ~7% when it connects but 99% of the time is at 0%.
I have an i9-9900K though.
Can you repro it 100% of the time and what are your machine specs?

It's also interesting that it's using 37.6MB. With it running and with 5 applications open playing sound mine stays around 25MB

i5-4670k 4.6GHz 16GB ram, Win 10 Home x64.
I see it go as high as 40%. I have 4 applications opened when taking this screenshot.

Ok. To be clear the repro steps are to just launch maxmix without the controller plugged in?
I’ve tried that and also launching it, plugging in the controller, opening up a few apps, disconnecting the controller.
Am I missing something?
I will profile it regardless but I’d love to reproduce it.
I’ll try on a different computer tomorrow also.

Ok. To be clear the repro steps are to just launch maxmix without the controller plugged in?

Yup. Drops to 0% once it's plugged in. I do have a COM1 device that is always connected to my system. I have no idea what driver/device is it referring to (just windows things~), but my speculation is that it could be polling that device which is not a MaxMix.

Huh, that’s a good point. I’ll try to connect another serial device to see if I can reproduce it.
Thanks!
Ruben Henares

On Aug 6, 2020, at 23:59, SchemingWeasels<EMAIL_ADDRESS>wrote:

Ok. To be clear the repro steps are to just launch maxmix without the controller plugged in?
Yup. Drops to 0% once it's plugged in. I do have a COM1 device that is always connected to my system. I have no idea what driver/device is it referring to (just windows things~), but my speculation is that it could be polling that device which is not a MaxMix.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, the repro steps are exactly as described (no device attached)
The behavior is consistent on my machine. 100% reproducible.
Like @SchemingWeasels I have a default COM1 available. I tried disabling it, then rebooted.
After that MaxMix is back to normal (< 1% CPU).
At least we know what is happening :)

Oh nice! Cool you were able to narrow it down some more.
Ok great, I should be able to repro it hopefully.
Ruben Henares

On Aug 7, 2020, at 06:15, Sébastien Atoch<EMAIL_ADDRESS>wrote:

Yes, the repro steps are exactly as described (no device attached)
The behavior is consistent on my machine. 100% reproducible.
Like @SchemingWeasels I have a default COM1 available. I tried disabling it, then rebooted.
After that MaxMix is back to normal (< 1% CPU).
At least we know what is happening :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Test

Testing discord integration.


e2e: use rancherctl to install elemental-operator chart

See apps option here: https://ranchermanager.docs.rancher.com/reference-guides/cli-with-rancher/rancher-cli#commands.

Maybe this can be done at the same time as the changes needed for https://github.com/rancher/elemental-operator/issues/329.

I think we cannot install the elemental-operator with rancherctl as long as it is not added into the marketplace.


To do list structure

This branch's purpose was to:

Set up a new project with webpack
Create an index.html file and write your HTML markup here. Create an empty To Do List placeholder
Create an index.js file and set an array of some simple to-do tasks
Write a function to iterate over the tasks array and populate an HTML list item element for each task.
Render a dynamically created list of tasks in the dedicated placeholder. The list should appear in order of the index values for each task.
Create a style.css and set rules for the To-Do List. Load them with Webpack Style/CSS Loader

Hi, @evillaz 👋,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Status: Invalid Code Review Request

You have submitted a project, that has failed linters. Kindly fixed them before requesting a review.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

yes sorry for that missed eslintrc config


apsl-react-native-button breaks jest

Fix/merge or open defect on their project

Hey, I am having the same problem, did you find a solution / workaround to this issue?
Thanks, Thomas

Fixed w/ https://github.com/bartonhammond/snowflake/releases/tag/0.1.2


Cartesian Product based testing

At 21Gram for our TypeScript stuff we have a utility function that takes a recursive/nested set of test values and provides a callback that runs your test code based on the cartesian product of the inputs. It's pretty dope.
It'd be nice to have something like it in Swift too.

Gotta keep an eye on this lib: https://github.com/swiftlang/swift-testing
Either I might contribute there, or have a general purpose cartesian product producer here... dunno, postponed for now until anyone needs it.


not working with valet

if i install it via composer and link it with valet it does not work.
I have tried it already with MAMP – it was working perfectly!
Vue is not loading – means: Output of index .twig is <hello-world…
Would be great if it is possible to work with it via valet!

@angrotheman definitely works with Valet! That's what I use for all my projects, and even all reproductions for this repo.

do you do something special? or just install it?

Nothing special.
if you're running yarn dev or npm run dev your css files won't be output

think i have it.
Safari don't load the app.js because it is not https. Tried it in Chrome and there is everything perfect.

@angrotheman Yeah if you're securing your valet install, you may want to set the https option in your vue.config.js file to true and also set https://github.com/chasegiunta/craft-vue/blob/e541df8cf1032e3b4d42bdb0a9490b14ea28130e/config/twigpack.php#L22
to reflect https

thanks for your fast help, I think it is working now! Your repo is really great to start with vue & craft

No problem! Glad you're up & running.

@angrotheman Yeah if you're securing your valet install, you may want to set the https option in your vue.config.js file to true and also set
https://github.com/chasegiunta/craft-vue/blob/e541df8cf1032e3b4d42bdb0a9490b14ea28130e/config/twigpack.php#L22
to reflect https

sorry… I try now hours but I don't get it work…
chrome want to load socks-node/info from HTTPS://localhost
but my localhost is not secured. can I changed it? if I set https to true it will load anything with https

@angrotheman Yeah if you're securing your valet install, you may want to set the https option in your vue.config.js file to true and also set
https://github.com/chasegiunta/craft-vue/blob/e541df8cf1032e3b4d42bdb0a9490b14ea28130e/config/twigpack.php#L22
to reflect https

sorry… I try now hours but I don't get it work…
chrome want to load socks-node/info from HTTPS://localhost
but my localhost is not secured. can I changed it? if I set https to true it will try to load anything from https


[BUG] Classes added via tailwind.config.js not recognized

Describe the bug
Using the official docs, adding a new class and referencing it in render are not recognized.
To Reproduce
Steps to reproduce the behavior:

Use official docs to add new class
Attempt to use new class
See error

Expected behavior
Custom utilities should be recognized
Screenshots

The VSCode Intellisense extension does see the class as valid though:

**Environment (please complete the following information):**

OS: [e.g. macOS, windows 10]
Softwares + version used:

VSCode 1.60.1

👋 Just wanted to add that I tried requiring in the config file like https://github.com/francoismassart/eslint-plugin-tailwindcss/issues/51 without any luck. I logged-out the config file as it's read inside of where this linter reads in the value and do see it there too.

@francoismassart Thanks for the continued work on this plugin! I saw the recent updates and figured I'd give this another shot, but am unfortunately still unable to use custom classes:

Any tips on what I could try? I attempted to use the eslint settings object; passing through my config tailwind.config.js path via a string and also from a require() without any luck.

Hi @zslabs I don't know yet how to work on this issue as I never used that specific feature...

Hey @francoismassart appreciate the response! Is it the correct assumption that custom classes made within tailwind.config.js should be recognized correctly?
I noticed when adding a plugin like https://www.npmjs.com/package/tailwind-gradient-mask-image I was still getting the warning, so I wanted to make sure I understood how classes are parsed from the config. Thanks!

I did plan to extract all the classnames generated by a plugins but it can become a performance issue because e.g. the official typography plugin can generate more than 238.000 classnames.
For now, please:

disable the rule on specific line
or
add your classnames to the whitelist option

Gotcha, thanks for the explanation and workaround suggestions. Appreciate you making this tool!

I’ll keep you posted when you can skip the whitelist option for this. 😉


Symbol Designer displays Favorite ID in top of Symbol Attribute Set table… why?

The Symbol Designer displays the Favorite ID (a GUID, created by the editor simply to identify favorites in a machine readable format) in top of Symbol Attribute Set table… why?  It doesn't add anything to a user of the tool's understanding.  I would suggest just not showing the value.
From Favorites stress testing.

@csmoore can the "favorite ID" guid be removed from the display?

It can (very easily) - time permitting I was thinking about replacing this with a user-friendly name (like the style items have - ex. "Infantry : Friendly"), but for now we can just remove the line/GUID.

Removed the FavoriteID row and added a friendly name to the Display/Label attributes row in #127 ex:

Some more testing showed that these names weren't being reliably updated. So I had to modify how this worked to get the name to update reliably - this is how it looks now (added Name row) - ready to verify in next build:

Assigning back to @BobBooth to verify this has been resolved after the next build.

Verified.


Template commands nested in {literal} ... {/literal} are still parsed.

According to Closure documentation all text within {literal} blocks should not be parsed, including template commands.
{namespace test}

/**
 *
 */
{template .render}

		{literal}
			{template .snippet}
				Code snippet.
			{/template}
		{/literal}

{/template}

When attempting to render this template, the following error is thrown.
soynode: Compile error
 In file test.soy, template test.render: Lexical error at line 12, column 25.  Encountered: <EOF> after : ""
In file test.soy:12:17: parse error at '{': expected eof, {deltemplate, or {template
		{/literal}
                ^

soynode: Error: Error compiling templates
    at ChildProcess.onExit (/Projects/temp/node_modules/soynode/lib/SoyCompiler.js:308:25)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
soynode: emit error Error: Error compiling templates
    at ChildProcess.onExit (/Projects/temp/node_modules/soynode/lib/SoyCompiler.js:308:25)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

A similar error is thrown if {namespace name} is included inside the {literal} tags.

This package is just a nodejs wrapper around https://github.com/google/closure-templates, we do not control the template syntax.


Could I use "inputmask" with number (decimal) field of Simple Schema?

I would like to use inputmast with number (decimal) field fo Simple Schema.
// Simple Schema
amount: {
    type: Number,
    label: "Amount",
    decimal: true
  },

// Template
Config inputmask (...000,000.00)

But have problem with type Number.
Please help me.

The output is probably string so you will have to do parseFloat before saving it.


[FEATURE] Support v2 Data Engine - Experimental

Is your feature request related to a problem? Please describe (👍 if you like this request)
This epic is for getting the v2 data engine to the experimental level to support the feature parity of the v1 data engine and live upgrade. This will require the underlining SPDK modules support, SPDK gRPC server, Instance Manager, and Longhorn Manager enhancement, also some refactoring efforts from 1.5.0 will be considered.
Describe the solution you'd like
The related sub-issues will be created and added to this epic via Zenhub.

[x] Volume Live Upgrade - Data plane (1.7)
[x] Online replica rebuilding (1.7)
[X] TRIM (1.7)
[ ] Delta replica rebuilding via snapshot checksum (1.8)
[ ] Snapshot checksum (*1.8)
[ ] Volume Live Migration (1.8)
[ ] Backing image (1.8)
[ ] Volume Live Upgrade - Control Plane (1.9)
[ ] Disaster Recovery Volume (1.9)
[ ] Zero-copy/Fast Clone (1.9)
[ ] Volume Expansion (1.9)
[ ] Volume Encryption (1.9)
[ ] Delta replica rebuilding via delta snapshot (1.9)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
cc @longhorn/dev-data-plane

1.6 will be still preview with some new features introduced, so 1.7 will be an experimental version instead.

Moved this to 1.9.0, as all primary items should be ready in 1.9. cc @derekbit


Clean exit when unable to determine instrument or technique.

Avoid pipeline crash by adding a clean exit when is unable to determine instrument (camera used) or observing technique.

Coverage increased (+0.1%) to 38.313% when pulling 29b3bd16a4745ab936bdde95bbff75bbfb575746 on simontorres:clean_exit_instconf_none into 73ac424ab3a6a2ca7db529bbe028327d19df4d65 on soar-telescope:master.


Git.io deprecation notice

Hello, I've found that some of your files in this repo is still using https://git.io/, and this service will be discontinued in the future. (ref: Git.io deprecation)
Theses files are: docs/architecture/porting-existing-aspnet-apps/example-migration-eshop.md

This is an automated message from NPMMirror(https://github.com/npmmirror), a bot developed by Nova Kwok(https://github.com/n0vad3v).

Should be fixed by #29183.

Fixed by https://github.com/dotnet/docs/pull/29183.


Observable class vs builders

From what I understand Observable has static methods in it. Maybe those static methods should not be described on the Observable class.
Maybe we need an Observables object (not class).
Here's the point at which we need to investigate what other libraries are doing:

latest master on https://github.com/Reactive-Extensions/RxJS
https://github.com/cujojs/most

I see for example that most works with plain functions. Maybe that's not bad at all.
I mean I can see people doing this:
import * as Mx from "monix-reactive"

const stream: Mx.Observable<number> = Mx.intervalAtFixedRate(1000)

The advantage of using plain functions, btw, is that it's easier to minify the code with tools such as Webpack / Rollup.
But then not everybody works with Google Closure and the interoperability of that with TypeScript definitions is experimental anyway.
And I have a feeling that an Observable class would get large.

@alexandru from memory: Class methods and functions do not have the same variance behaviour.
So the would maybe help to make a decision.
(The former are bivariants while the later are more what you would expect .. I guess )

@sledorze that changed from version 2.6 in --strict mode

Under --strictFunctionTypes function type parameter positions are checked contravariantly instead of bivariantly.

As in monix Observable operators and builders also share same namespace within Observable class we can export all together from monix-reactive package too, just like in your example:
import * as Mx from "monix-reactive"

const stream: Mx.Observable<number> = Mx.intervalAtFixedRate(1000).pipe(Mx.map(_ => _ * 2))

Going to try that and see how it looks.

@lostintime that changed for functions only

@sledorze looks like I missed that, it's mentioned just below the quote I used :) Thanks!

Devil .. :)


Provide means to expose ALPN protocol names for custom protocols on Routes

This issue is to capture the notes from a discussion on slack, thanks to @jpeach! See also #227.
Routes currently support HTTPRoute & TCPRoute. In order to support routes for custom protocols ala FooRoute ) may require changes to the Listeners to expose ALPN protocol names.
Has there been any progress or thought on how routes for custom protocols will be supported?
Thanks!

Some examples of non-HTTP ALPN usage:

https://aws.amazon.com/blogs/iot/mqtt-with-tls-client-authentication-on-port-443-why-it-is-useful-and-how-it-works/
https://tools.ietf.org/html/rfc7443


Improve sqlmesh format behaviour

Trying to capture a few concerns in a single place:
Audits
As it stands, the audits property on MODEL will get re-written into a single line (more or less). This can be quite problematic for models that have complex or a lot of audits.
For example,
MODEL(
  audits [
    not_null(columns=[
      foo_id,
      foo_normalised,
      bar_normalised,
      total_weight,
      overall_rank,
      cumulative_total_weight_share,
      market_rank,
      market_cumulative_total_weight_share,
      total_weight_decile,
      tier,
    ]),

    unique_values(columns=[foo_id]),

    accepted_range(column=foo_normalised, min_v=0, max_v=100),
    accepted_range(column=bar_normalised, min_v=0, max_v=100),
    accepted_range(column=total_weight, min_v=0, max_v=100),
    accepted_range(column=cumulative_total_weight_share, min_v=0, max_v=1),
    accepted_range(column=market_cumulative_total_weight_share, min_v=0, max_v=1),

    accepted_values(column=tier, is_in=['Tier 1', 'Tier 2', 'Tier 3', 'Long Tail']),
    accepted_values(column=total_weight_decile, is_in=['Decile_01', 'Decile_02','Decile_03','Decile_04','Decile_05','Decile_06','Decile_07','Decile_08','Decile_09','Decile_10']),
  ],
);

Will be re-written to
MODEL(
  audits [not_null(
    columns = [foo_id, foo_normalised, bar_normalised, total_weight, overall_rank, cumulative_total_weight_share, market_rank, market_cumulative_total_weight_share, total_weight_decile, tier]
  ), unique_values(columns = [foo_id]), accepted_range(column = foo_normalised, min_v = 0, max_v = 100), accepted_range(column = bar_normalised, min_v = 0, max_v = 100), accepted_range(column = total_weight, min_v = 0, max_v = 100), accepted_range(column = cumulative_total_weight_share, min_v = 0, max_v = 1), accepted_range(column = market_cumulative_total_weight_share, min_v = 0, max_v = 1), accepted_values(column = tier, is_in = ['Tier 1', 'Tier 2', 'Tier 3', 'Long Tail']), accepted_values(
    column = total_weight_decile,
    is_in = ['Decile_01', 'Decile_02', 'Decile_03', 'Decile_04', 'Decile_05', 'Decile_06', 'Decile_07', 'Decile_08', 'Decile_09', 'Decile_10']
  )],
);

Similarly, we often apply comments to audits to document their purpose, e.g.:
  audits [
    forall(criteria=[
      /* This is a comment about this complicated audit */
      foo IS NOT NULL OR (
        some_date < '2023-11-30' OR
        something_else IN('a', 'b') OR
        /* See this conversation https://slack.com/archives/ABCD/p777 */
        (some_date BETWEEN '2024-02-24' AND '2024-02-25') OR
        /* See this conversation https://slack.com/archives/ABCD/p777 */
        (some_date BETWEEN '2024-03-14' AND '2024-03-16')
      )
    ]),
    /* ensure the this column is well formed, but don't fail since we expect this to change in time */
    accepted_values_non_blocking(column=hs_tenant, is_in=('foo', 'bar', 'baz')),
    /* ensure that the interval has some data */
    number_of_rows(threshold=100),
  ],

this gets re-written as
  audits [not_null(
    columns = [hs_shopped_on_time_utc, hs_user_id, hs_availability_id, hs_check_in_date, hs_check_out_date, hs_tenant, hs_lodging_id, hs_rate_count, hs_rate_provider_count]
  ), forall(
    criteria = [NOT foo /* This is a comment about this complicated audit */ IS NULL
    OR (
      some_date < '2023-11-30'
      OR something_else IN ('a', 'b')
      OR (
        some_date BETWEEN '2024-02-24' AND '2024-02-25'
      ) /* See this conversation https://slack.com/archives/ABCD/p777 */
      OR (
        some_date BETWEEN '2024-03-14' AND '2024-03-16'
      ) /* See this conversation https://slack.com/archives/ABCD/p777 */
    )]
  ), accepted_values_non_blocking(column = hs_tenant, is_in = ('foo', 'bar', 'baz')) /* ensure the this column is well formed, but don't fail since we expect this to change in time */, number_of_rows(threshold = 100) /* ensure that the interval has some data */],

We can probably live without the comments, but it would be important to keep the one-audit-per-line format for maintainability by people.


RKE1 Node Pools not displayed in Cluster Management in Explorer

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Deploy a rancher server based on rancher/rancher:master-head 5d2b7ac
Provision a Linode RKE cluster from the rancher with two node pools - 1st pool for one node with all roles set and 2nd poll for one node with worker role set (for the rest use default values)
Wait until the Cluster is reported as Active in Cluster Management in Explorer (and not grayed out in the cluster list)
In Cluster Management / Explorer click on the Linode Cluster name and switch to Node Pools tab

Result:

The cluster doesn't report any used Node Pools:

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): rancher/rancher:master-head 5d2b7ac
Installation option (single install/HA): any

Currently on rancher/rancher:master-head c7f3cce with RKE1 EC2 cluster the following is shown - looks like the json is not rendered at all. @richard-cox do you think the opened PR https://github.com/rancher/dashboard/pull/3293 will also address this?

@thehejik Close, #3291 will implement this feature. Hopefully should merge by tomorrow

Test report:
Tested on rancher/rancher master-head e546ffe
Now RKE1 node pools and nodes itself are displayed - the output seems reasonable. I was also able to scale up node count on EC2 and on Linode within node pools.

This is how it currently looks on RKE1 EC2 cluster with one allroles pool:

similary on RKE1 Linode clustes with three pools each for one role:

Closing.


Support reset cursor to a batch index of the batching message

Is your feature request related to a problem? Please describe.
We have support ack the batch message index since 2.6.0. But it's not supported by the reset cursor operation. So, if users reset the cursor to a batch index of the batch message then when consuming messages again, it will get these batch index again.

I will work on it


Extra space appears at the beginning of uncommented line in html/css

VSCode Version: Code 1.14.0 (b8cd5b9556d8b70ea560d35b903422363f6c5c40, 2017-07-10T18:36:31.751Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author (truncated)
Version

python
don
0.6.7

Steps to Reproduce:

Open any html/css file
Comment line with ctll+/
Uncomment line with ctll+/
Extra space appears at the beginning of uncommented line

Reproduces without extensions: Yes

If you comment and uncomment a block using Shift+Alt+A in any language, two extra spaces are added -- one in the beginning and another in end of the block.

Already fixed by https://github.com/Microsoft/vscode/pull/30818 . Thank you.


feat: Implement Hubs

Motivation
We need a class definition for the Hub object.
A Hub is made up of a collection of services (RPC, GossipSub, Engine...) that together implement all of its behaviors.
fixes https://github.com/farcasterxyz/hub/issues/64
Change Summary
Created a Hub class.

Pulled in PubSub peer discovery to run alongside gossip to keep the libp2p peerlist up to date
Added new RPC API to Publish messages to Hubs (Hubs will then publish those to the rest of the network via Gossip)
Added support for bootstrapping a Hub off of a list of other Hub addresses. https://github.com/farcasterxyz/hub/issues/64
Wrote a test that bootstraps a Hub off of an existing Hub on a network.

Note - we need a lot more tests here as we flesh out more features. Filed https://github.com/farcasterxyz/hub/issues/129
Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] The title of this PR adheres to the conventional commits standard
[x] The PR has been tagged with the appropriate change type label(s) (i.e. documentation, feature, bugfix, or chore)

Codecov Report
Base: 90.56% // Head: 90.05% // Decreases project coverage by -0.51% :warning:

Coverage data is based on head (ef7bfa6) compared to base (4e879ff).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   90.56%   90.05%   -0.52%
==========================================
  Files          36       37       +1
  Lines        1845     2041     +196
  Branches      315      353      +38
==========================================
+ Hits         1671     1838     +167
- Misses        166      195      +29
  Partials        8        8

Impacted Files
Coverage Δ

src/engine/index.ts
88.61% <ø> (ø)

src/hub.ts
80.85% <80.85%> (ø)

src/network/node.ts
84.52% <81.57%> (+6.74%)
:arrow_up:

src/network/rpc.ts
91.34% <90.90%> (-0.06%)
:arrow_down:

src/network/typeguards.ts
89.28% <91.66%> (-1.63%)
:arrow_down:

src/engine/mock.ts
96.66% <100.00%> (+0.11%)
:arrow_up:

src/network/protocol.ts
93.75% <100.00%> (+2.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: channels icons size 200 instead of 300

fix: channels icons size 200 instead of 300

:hammer_and_wrench: Type Of Change

[x] Fix
[ ] Feature
[ ] Refactoring
[ ] Documentation

:book: Description
Make channels icons size 200 instead of 300, requested by design

Will the "All channels" also be updated since it uses the same one? That one should remain at 18, while only those within the Channels group should bump down to 14.

hmmm did not know that.. Yeah I will have to make an additional change for this to work.

In fact I think I will just allow setting the icon size independently.

Added iconSize prop, valid values 200 and 300.

I'm guessing you'll need to make the change directly in product codebase specifically for the Channel ones to be 200

Yep that's right


add guava explicitly to LS classpath

fixes https://github.com/salesforce/bazel-vscode-java/issues/109

We cannot bring in an old version of Guava. This is causing trouble. Instead we have to align the Caffeine library to use the new Guava version.


Type information from promise executor bodies is not carried into the parent scope

TypeScript Version:  3.7.2
Code
type MockPromise = {
    promise: Promise<void>;
    triggerPromiseResolution: () => void;
};

function foo(): MockPromise {
    let triggerPromiseResolution: (() => void) | undefined = undefined;

    const promise = new Promise((res, _rej) => {
        triggerPromiseResolution = res;
    });

    return {
        promise,
        triggerPromiseResolution,
    };
}

Expected behavior:
This should typecheck.
In step 9. of https://www.ecma-international.org/ecma-262/6.0/#sec-promise-executor, promise executors are specifically run before the promise constructor returns.
Actual behavior:
This throws the following error
Type 'undefined' is not assignable to type '() => void'.(2322)
input.ts(3, 5): The expected type comes from property 'triggerPromiseResolution' which is declared here on type 'MockPromise'

Playground Link: http://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=17&pc=2#code/C4TwDgpgBAsg9gYwNYAUBOcC2BLAztAXigG8AoKCqMDHfALinSzwgB4A3ObAEwD4BucpWBpsAczEQ0TWhABKEXHAA2AV2DY4AOwYAKAJRQCvKJx6CAvoNIAzVVoQbtUG3DgGG8ZDJYkhFZQhgKBFxSWkaFgUlNScdKF0DIxMzbkMAHyh7bggbbC0IbiMsrRy8gu5rSigEbVxg6mZ8YoKAd0ZI-A4uPkS0RQAaKAB9foArQ2M-aurQiSkffGiVdU0tYv7cQWqLfSrKfuBVNHWyGcpG2QH-GbnwxflFFbjrncsgA
Related Issues: I couldn't find any, but I think this would depend on

function asserts making assertions about values in their parent scopes
Propagating asserts through other functions, e.g. something like:

declare class Promise<TReturn> {
  constructor<T_Assertion = empty_assertion>(executor: (res, rej): asserts T_Assertion): asserts T_Assertion
}

Inferring asserts from function bodies

I realize this is a pretty big ask that has a lot of requirements, but I didn't see any discussion around it so I figured this might be a good place to start. I'm working around this right now by casting through unknown.
Type assertions are great to work with, thanks for 3.7.2! 🙂

#9998

Also #11498


Add PlatformApiClient

First pass at a central PlatformApiClient to handle authenticated get, post, patch, and delete requests against Platform API endpoints.
Better test coverage TK

Update the CHANGELOG as well


2.2 beta: Strings absent from Localizable.strings

About one third of the nvALT interface is untranslated, because the strings are absent from Localizable.strings, and thus unavailable for translation. Here are the most obvious absences:
From Preferences.nib

"Show menu bar icon (restart required)"
"Hide Dock Icon" [and the word "Show" when it's toggled]
"URL Import:"
"Convert imported URLs to Markdown"
"Process with Readability"
"Hold down Option while dragging a link to the notes list to temporarily enable Readability."
"Auto-pair:"
"Match opening characters, like a left bracket, with closing characters."
"Direction:"
"Right-To-Left (RTL)"
"Text and Background Colors affect User Color Scheme only."
"Always Show Grid Lines in Notes List:"
"Alternating Row Colors:"
"Use nvALT Scrollbars:  " [extra space should be removed]
"Keep Note Body Width Readable:"
From MainMenu.nib

"Edit With"
"Insert Link"
"Collapse Notes List"
"Color Schemes"
"B/W"
"Low Contrast"
"User Scheme"
"Show Word Count"
"Preview"
"Toggle Preview Window"
"Toggle Source View"
"Lock Note to Preview"
"Print Preview / PDF"
"Save Preview HTML"
"Enable Markdown Completion"
"nvALT Home"
"Enter Full Screen"
"Use Selection for Find"

Thanks. Will add to Localizable.strings


OpDecorate should not allow an arbitrary number of arguments

The following should assemble, but should not disassemble.
   OpDecorate %1 LinkageAttributes "abc" !1 !0

The !1 is 1, which is interpreted as linkage attribute "Import".   The instruction ends up having 6 words, the last being value 0.
However, the binary parser (and disassembler) should reject this input because that last !0 word is extraneous.
The root cause is that the grammar in opcode.inc has a last operand class of OperandVariableLiterals, so that expands to zero or more literals.  Instead that should be dropped, and we should allow processing of the decoration enum word to add just the right number and type of operands to the operand pattern.

Credit to @dmircevski for starting the conversation about using short string inputs.  The linkage attributes decoration is the only case where a string literal comes before yet another operand.  Making a test case to cover that exposed this issue.

Even less exotic test case. This should not assemble, but it does:
│OpDecorate %1 LinkageAttributes "abc" Import 1 2 3


Segmentation fault (core dumped)

On executing sh train_bert.sh  getting error Segmentation fault (core dumped)
Configuration of My VM
RAM - 26 GB
GPU - 2 (Tesla T4 )
Any Comment will be highly appreciated.

Could you please copy the script details here?

CUDA_VISIBLE_DEVICES=0
python train.py
-task ranking
-model bert
-train ./data/train_rank_toy.jsonl
-max_input 1280000
-save ./checkpoints/scibert.bin
-dev ./data/dev_toy.jsonl
-qrels ./data/qrels_toy
-vocab allenai/scibert_scivocab_uncased
-pretrain allenai/scibert_scivocab_uncased
-res ./results/scibert.trec
-metric ndcg_cut_10
-max_query_len 32
-max_doc_len 256
-epoch 1
-batch_size 4
-lr 2e-5
-eval_every 1000

I've tested this, and it worked fine.
Could you copy the whole error code, and share the version of python, pytorch and transformers?

Traceback (most recent call last):
  File "inference.py", line 200, in <module>
    main()
  File "inference.py", line 176, in main
    state_dict = torch.load(args.checkpoint)
  File "/home/hexaai/InformationRetrival/env/lib/python3.6/site-packages/torch/serialization.py", line 525, in load
    with _open_file_like(f, 'rb') as opened_file:
  File "/home/hexaai/InformationRetrival/env/lib/python3.6/site-packages/torch/serialization.py", line 212, in _open_file_like
    return _open_file(name_or_buffer, mode)
  File "/home/hexaai/InformationRetrival/env/lib/python3.6/site-packages/torch/serialization.py", line 193, in __init__
    super(_open_file, self).__init__(open(name, mode))
**FileNotFoundError: [Errno 2] No such file or directory: './checkpoints/bert.bin'**

Kindly help me.

train.sh set the eval_every to 1000, the dev set will be evaluated every 1000 steps, then the best performed model will be saved. But the toy dataset is too small to reach 1000 steps, so there is no model saved.
I've changed the eval_every to 10, you can try it out :)

We've shared the checkpoints of models trained on trec-covid and msmarco dataset.
You can preprocess the user topics and articles to format in https://github.com/thunlp/OpenMatch/blob/master/docs/openmatch.md, and inference.
The inference.py outputs a file in standard trec format by default, each line is like follows:
query_id Q0 doc_id rank score run-tag

if you don't want the trec file, we have the test function in inference.py which outputs a dict:
{query1: [(doc1_ranking_score, doc1_id), (doc2_ranking_score, doc2_id), ...], query_2: ...}

you can format the output yourself with this.

Could you please share the entire project description in the readme.md file
It will be helpfull for me to know the actual concept of the project a test it with some other dataset.
Thank You.

I think your question is more in general about IR not about this open source project. As long as you can run the example successfully, I think this issue can be closed.


Documentation

add docs for the pkg

I think this documentation is fairly complete, and ready to be merged. Any recommendations on points I should included or clarify further?


.pre-commit-config.yaml

This PR adds minimal pre-commit hooks.

@lbdreyer Awesome, thanks! :rocket:


Firebase AARs being changed after every change in project's package/product name, any way to spare the change?

[REQUIRED] Please fill in the following fields:

Unity editor version: 2020.3.25f1
Firebase Unity SDK version: 8.7
Source you installed the SDK: .unitypackage.
Problematic Firebase Component: .
Other Firebase Components in use: analytics, app-unity, common, crashlytics-ndk, crashlytics-unity, installations-unity.
Additional SDKs you are using: google.android.appbundle-1.6.0, google.play.appupdate-1.6.0, google.play.assetdelivery-1.6.0, google.play.billing-3.2.1, google.play.instant-1.6.0, google-play-plugins-1.6.0.
Platform you are using the Unity editor on: Linux.
Platform you are targeting: Android.
Scripting Runtime: IL2CPP.

[REQUIRED] Please describe the question here:
I'm using one Unity project to create multiple apps (each with its unique flavor, but based on the same code), each with different package/product name that published as separate app at Google Play Store. I need to switch between the flavors of the app often, and each time Android Resolver scanning everything and the following firebase files are changed:

com.google.firebase.firebase-analytics-unity-8.7.0.aar
com.google.firebase.firebase-app-unity-8.7.0.aar
com.google.firebase.firebase-common-20.0.0.aar
com.google.firebase.firebase-crashlytics-ndk-18.2.5.aar
com.google.firebase.firebase-crashlytics-unity-8.7.0.aar
com.google.firebase.firebase-installations-unity-8.7.0.aar

Each flavor has its unique firebase configuration file, but they all use the same firebase packages. I don't know why these files keep being change after each Android Resolve run after package name change. Is there a way to spare this changes, or they include an injection of package name that forces them to be updated?

Hi @a-l-e-x-d-s-9,
I see that you've filed a similar ticket in the resolver queue as seen here. Let's continue our discussion there so that our conversation is contained in one thread. That being said, I'll close this issue.


windows stacktrace not properly symbolized (built with bazel)

I'm using Google glog (glog-0.5.0, latest release at the time) on windows together with bazel 4.1.0 (which is the latest stable release at the time).
I'm initializing the library and install the failure signal handler right at the start:
int main(int argc, char* argv[]) {
  // Initialize Google's logging library.
  google::InitGoogleLogging(argv[0]);
  google::InstallFailureSignalHandler();
  // rest of program ...

I compile with
bazel --bazelrc tools/bazel_windows.rc build --verbose_failures -c opt myapp/myapp:app
which I'm calling from the x64 Native Tools Command Prompt for VS 2019 (Visual Studio 2019 Developer Command Prompt v16.6.3)
and I have
build --copt -g
build --strip=never

in my bazel_windows.rc
but when my app crashes, the output I'm getting is:
*** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1625663873" if you are using GNU date ***
    @     0x7ffa3ec91881 raise
    @     0x7ffa3ec92851 abort
    @     0x7ffa3ec91f9f terminate
    @     0x7ff9f3361aab (unknown)
    @     0x7ff9f3362317 (unknown)
    @     0x7ff9f33640d9 (unknown)
    @     0x7ffa40eb207f (unknown)
    @     0x7ffa40e61454 (unknown)
    @     0x7ffa40e611a5 (unknown)
    @     0x7ffa3e954b59 (unknown)
    @     0x7ff9f3406480 (unknown)
    @     0x7ff63571b38e (unknown)
    @     0x7ff635452d90 (unknown)
    @     0x7ff6357b55d3 (unknown)
    @     0x7ff63562349f (unknown)
    @     0x7ffa3ec41bb2 _configthreadlocale
    @     0x7ffa3f707034 (unknown)
    @     0x7ffa40e62651 (unknown)

What do I need to do to get a meaningful stacktrace?

I'm not sure I'm able to help here: I don't know anything about either how the stacktrace symbolization works, or how debug info on Windows works.
If I were you, I'd probably try running the binary in a debugger rather than relying on glog's stacktraces: apologies in advance if this is an unhelpful suggestion. You could also try https://groups.google.com/g/bazel-discuss to see if anyone else has run into this.

@MrMabulous Could you please verify glog at head? This change should be sufficient to obtain a symbolized stacktrace.

I'll close the issue in the meantime. Please let us know if the issue persists.


Omit MachineConfig and MachineConfigPool CRDs from release payload

What this PR does / why we need it:
The MachineConfig and MachineConfigPool CRDs are not needed in a
HyperShift cluster and they should be removed from the UI.
This change is to omit them from the release payload applied to the
guest cluster.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # CONSOLE-2984
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

Does it matter these may already be in existing clusters (e.g. IBM)?

Does it matter these may already be in existing clusters (e.g. IBM)?
You're right, this won't remove them from existing clusters. Let me add a manifest to do that.

updated to handle the upgrade case

/lgtm

/hold
This is failing the single test create:
=== CONT  TestCreateCluster
    util.go:196:
        failed waiting for image rollout
        Unexpected error:
            <*errors.errorString | 0xc0004ca780>: {
                s: "timed out waiting for the condition",
            }
            timed out waiting for the condition
        occurred

So the issue is that the node tuning operator fails to start because it watches MachineConfigs and MachineConfigPools by default:
W0422 03:53:21.874247       1 reflector.go:324] github.com/openshift/machine-config-operator/pkg/generated/informers/externalversions/factory.go:101: failed to list *v1.MachineConfigPool: the server could not find the requested resource (get machineconfigpools.machineconfiguration.openshift.io)
E0422 03:53:21.874548       1 reflector.go:138] github.com/openshift/machine-config-operator/pkg/generated/informers/externalversions/factory.go:101: Failed to watch *v1.MachineConfigPool: failed to list *v1.MachineConfigPool: the server could not find the requested resource (get machineconfigpools.machineconfiguration.openshift.io)

/hold
Cesar could we consider the implications of this as well for the SRV-IO POCs?

/hold

/unhold
Not we are allowing the manual applying for now just for POC demos with SRV-IO but these are not valid resources in hypershift

/lgtm


Added Github Action

We just got granted the Beta program

Oh, I did not mean to merge this.. It must have been a keyboard shortcut... Im sorry.