Convert bool to lowercase string for anilist

Description
Convert the boolean for isAdult to a lowercase string, as that is what the anilist search graphql expects, and fails if you pass it a python boolean (True or False)
Issues Fixed or Closed

Fixes #844

Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas

Log of run after change
|============================== Running Current Season Test Collection ==============================|
|                                                                                |
| Sync Mode: sync                                                                                |
|                                                                                |
| Builder: anilist_search: {'season': 'spring', 'year': 2022, 'adult': False, 'sort_by': 'score', 'limit': 100} |
|                                                                                |
| Processing AniList Search:                                                                         |
|       Sort By Average Score                                                                             |
|       Limit to 100 Anime                                                                                |
|       Season is spring                                                                                |
|       Year is 2022                                                                                |
|       Adult is False                                                                                |
| query ($page: Int) {Page(page: $page){pageInfo {hasNextPage}media(sort: SCORE_DESC, type: ANIME, season: SPRING, seasonYear: 2022, isAdult: false){id}}} |
|                                                                                |
| 86 AniList IDs Found: [140960, 125367, 142984, 141774, 129201, 140350, 121176, 133891, 116605, 123330, 134732, 124032, 137281, 125124, 132052, 142455, 111321, 132010, 132532, 132171, 127911, 132474, 117197, 125447, 141014, 136080, 129193, 142074, 140457, 138459, 143150, 136226, 133412, 135384, 130586, 141350, 140002, 140830, 142219, 132526, 130319, 109911, 133175, 137633, 143203, 142016, 114108, 133124, 144676, 143455, 132351, 138452, 140085, 143289, 139303, 142842, 139273, 133898, 147728, 113689, 147226, 140842, 145968, 146488, 126783, 108357, 132679, 148295, 117074, 143202, 136303, 139376, 132232, 130705, 145813, 146865, 145848, 138425, 131520, 138700, 142549, 144853, 142806, 143080, 140787, 117756] |

superseded by a994080232679478a935df7d2d3ff947b28897c7


Scoreboard lines issue

Hello @r4g3baby i configured a scoreboard of 17 lines but ingame it shows only 14 lines mean it starts from 2 and ends on 16.
Here is scoreboard value:
simple2:
titles: '&a&lHypo&f&lCraft'
scores:
16:
- '&7&m+----------------+'
- '&7&m------------------'
15: '&7» &4&l⭐&b&lPlayer'
14: '     &f%player%'
13: ''
12: '&7» &4&l⭐&b&lHealth'
11: '     %hearts%'
10: ''
9: '&7» &4&l⭐&b&lRank'
8: '     &f%luckperms_prefix%'
7: ''
6: '&7» &4&l⭐&b&lBalance'
5: '     &f%vault_eco_balance_fixed%$'
4: ''
3: '&7» &4&l⭐&b&lPlaytime'
2: '     &f%playtime_time%'
1:
- '&7&m+----------------+'
- '&7&m------------------'
 Here is the output of scoreboard in minecraft:

Hey, this is not an issue with SimpleScore. The vanilla Minecraft client only renders 15 scoreboard lines.


Invalid non-string unique_id

Since HA 2024.10 non-string unique_id raise a log error
2024-10-06 20:53:34.524 ERROR (MainThread) [homeassistant.config_entries] Config entry 'AirCo' from integration midea_ac has an invalid unique_id '152832116814780', please create a bug report at https://github.com/mill1000/midea-ac-py/issues

Ditto.
ERROR (MainThread) [homeassistant.config_entries] Config entry 'Living Room AC' from integration midea_ac has an invalid unique_id '151732605042151', please create a bug report at https://github.com/mill1000/midea-ac-py/issues

Caused by this core PR https://github.com/home-assistant/core/pull/125662
Fix here: https://github.com/mill1000/midea-ac-py/pull/251

Thanks for the quick feedback. I'll wait for the HA update to be released.

Resolved for me, thank you.
One restart after upgrading the integration, and then one more to be rid of the error.


Add support for app "preferences" (low priority constraints)

Currently the unmet constraints for a given app would stop the app from deployment. It would be great to have the ability to have preferences, that are basically "best effort" constraints. For example, if I have a preference to run app App-1 on host Host-1, but host Host-1 is not available, Marathon will run app App-1 on another host, but if Host-1 is available, then marathon will run the app on it.
This would help in failover scenarios as well. For example, I could have 10 slaves and 10 apps that I need to run 1 app per slave. If one of the slaves dies, then marathon will launch that app on one of the live slaves making that slave to have 2 running apps. One the failed slave is back online, I would be able to restart the failed-over app and it will go back to the original slave.

Marathon wouldn't really be able to support this unless it was implemented on Mesos? I don't think marathon should duplicate the scheduling logic and try to second-guess where mesos is deciding to run the tasks.
To put this in a different way it could be would you say "Mesos should kill tasks if it knows it can better satisfy the constraints if re-launched"?

@solarkennedy I see. So this I should cross create this issue for Mesos?

To put this in a different way it could be would you say "Mesos should kill tasks if it knows it can better satisfy the constraints if re-launched"?

I would say this is out of scope. The preferences would only be used for launching new tasks and not "rebalancing" current running tasks.

I understand what you mean now. Yes, marathon could do.
What if, instead of adding a new concept, it was just a new parameter or variations on the constraints, like BEST_EFFORT_GROUP_BY or something like that?
Because in the end, you are describing the situation where you would rather have marathon satisfy the instance count requirement, at the expense of the constraint asked to be imposed?

BEST_EFFORT_* works and looking at the code, is very backwards compatible. Alternatively we can add an optional parameter to each constraint, so we can have hostname:UNIQUE: where default priority (if omitted) could be "ENFORCE" which would state the current behavior and other value could be "PREFER" which would mean low priority. This could let us have more options in future if needed at the cost of a lil headache now.
BTW, I wasn't quite able to understand your comment "Marathon wouldn't really be able to support this unless it was implemented on Mesos?" Aren't these constraints implemented on the Marathon side?
https://github.com/mesosphere/marathon/blob/master/src/main/scala/mesosphere/mesos/Constraints.scala

You are totally right, I had a misconception on how constraints were implemented.

Any news on this?

Netflix Mesos Fenzo scheduler support soft costrains. Take a look at   https://github.com/Netflix/Fenzo/blob/master/README.md

Related to this https://github.com/mesosphere/marathon/issues/2063

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3350. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


deprecated javascript still shown in toolbox

The function radio.onDataReceived is still shown in the javascript toolbox/menu, but it does not work, and the docs say it is deprecated and replaced with onDataPacketReceived
Please remove it, because it is hard to debug why it does not work if you don't read the docs and see it is deprecated.

This is already fixed in the beta website (add /beta to the URL); it will be fixed in the live website when we do our next release


Feature: override AuthenticationInterceptor

You can override the adapt and retry method based on your business scenario
Issue Link :link:

https://github.com/Alamofire/Alamofire/issues/3805#issue-2048551904
Goals :soccer:

Implementation Details :construction:

Testing Details :mag:

@jshier Can you help for this PR?

I was initially okay with this change, but properly subclassing AuthenticationInterceptor requires more than just opening up the method, it would need expose a way to safely access and mutate the internal state, which would then expose the Protected type we use for thread safety. That seems too much exposure for functionality that can also be accomplished by composing the existing AuthenticationInterceptor into a new RequestInterceptor that customizes the behavior you need, or by simply copying code. So I won't be accepting this PR, sorry.


Update model documentation

Update the existing provenance model documentation in /docs to reflect the changes done during github2prov development.

[ ] Update node attributes
[ ] Update list of system notes / github resource events
[ ] Update node names
[ ] GitHub2PROV specific explanations

Maybe we should change the document structure to better account for GitHub/GitLab duality.


Validations when using fields_for not displaying correctly

Hey!
Another fields_for related issue that I've come across.
Here is a screenshot of the form that I am working on (standard devise goodness)

As you can see the validations are working great for the first-level form fields.
Here is the form's view itself:
<%= form_for(resource, as: resource_name, url: registration_path(resource_name), layout: :basic) do |f| %>

  <%= f.text_field :first_name, autofocus: true %>

  <%= f.text_field :last_name %>

  <%= f.fields_for :foo, fieldset: false do |foo| %>
    <%= foo.text_field :name, label: 'Company' %>
  <% end %>

  <%= f.email_field :email %>

  <%= f.password_field :password, help: 'Minimum 8 characters' %>

  <%= f.password_field :password_confirmation, autocomplete: "off" %>

  <%= f.submit "Sign up", class: 'btn-lg btn-block' %>

<% end %>

However for the foo model, I have this validator:
validates_uniqueness_of :name, case_sensitive: false

When I run a debugger and check the errors on the resource I can see the proper error listed:
(added \n for readability)
#<ActiveModel::Errors:0x000001143b0528
@base=#<User id: nil, email<EMAIL_ADDRESS>
encrypted_password: "$2a$10$AiSLZb7QcPt9cNbCeubVmeyO/32le4NbTEoF0vEGsL/...",
reset_password_token: nil,
reset_password_sent_at: nil,
remember_created_at: nil,
sign_in_count: 0,
current_sign_in_at: nil,
last_sign_in_at: nil,
current_sign_in_ip: nil,
last_sign_in_ip: nil,
created_at: nil,
updated_at: nil,
first_name: "",
last_name: "Montag",
publisher_id: nil,
invitation_token: nil,
invitation_created_at: nil,
invitation_sent_at: nil,
invitation_accepted_at: nil,
invitation_limit: nil,
invited_by_id: nil,
invited_by_type: nil,
invitations_count: 0>,
@messages={
:"foo.name"=>["has already been taken"],
:first_name=>["can't be blank"],
:email=>["has already been taken"]}
>

The :foo.name error is in resource.errors correctly, however it isn't showing up on the form at all.
The model relations in question are:
User
belongs_to :foo

foo
has_many :users

And the resource in the form is a User
Any ideas? Am I missing something?
<3

Hey @KMontag42,
First of all, I assumed you created your own registration controller similar to the following:
class RegistrationsController < Devise::RegistrationsController
  def new
    build_resource({})
    self.resource.foo = Foo.new
	respond_with self.resource
  end

  private

  def sign_up_params
  	allow = [:email, :password, :password_confirmation, [foo_attributes: [:name]]]
  	params.require(resource_name).permit(allow)
  end
end

Then, if you look at the error section in bh documentation, you will see "Fields inside bootstrapped forms submitted with invalid values are automatically highlighted," which makes me think bh does not know how to deal with errors occurs in fields_for. You need to tell bh that fields_for will also have error messages by using the customize :errors option, so you want to do something like the following:
<%= f.fields_for :foo, fieldset: false, errors: {icons: true, messages: true } do |foo_form| %>
      <%= foo_form.text_field :name, label: 'Company' %>
      <% if resource.foo.errors.any? %>

          <% resource.foo.errors.full_messages.each do |msg| %>

<%= msg %>

          <% end %>

      <% end %>
    <% end %>

Unfortunately, bh only highlights the text_field :name even though the messages option is specified as true. However, you don't need a form_for or devise to display error messages. You can display the error messages by iterating all error messages of foo attributes.
I also suggest you to specify accepts_nested_attributes_for :foo in your  User model to ensure the Foo is saved through User.

This is exactly what I needed! Thank you so much for the information and very detailed response!!


Require country_select_without_sort_alphabetical fails

Following the instructions in the README, I added the following to my Gemfile:
gem 'country_select', require: 'country_select_without_sort_alphabetical'

After bundling it seems to have been installed:
$ bundle list | grep country
  * country_select (8.0.0)

however, I get the following on launching the server:
$ rails server
~/.rvm/gems/ruby-3.0.1@bundler/gems/bootsnap-1.13.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:17:in `require': cannot load such file -- country_select_without_sort_alphabetical (LoadError)
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bootsnap-1.13.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:17:in `require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bundler-2.3.6/lib/bundler/runtime.rb:60:in `block (2 levels) in require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bundler-2.3.6/lib/bundler/runtime.rb:55:in `each'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bundler-2.3.6/lib/bundler/runtime.rb:55:in `block in require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bundler-2.3.6/lib/bundler/runtime.rb:44:in `each'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bundler-2.3.6/lib/bundler/runtime.rb:44:in `require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bundler-2.3.6/lib/bundler.rb:176:in `require'
	from ~/Projects/app/config/application.rb:9:in `<main>'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bootsnap-1.13.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32:in `require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bootsnap-1.13.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32:in `require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/activesupport-6.1.4/lib/active_support/dependencies.rb:332:in `block in require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/activesupport-6.1.4/lib/active_support/dependencies.rb:299:in `load_dependency'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/activesupport-6.1.4/lib/active_support/dependencies.rb:332:in `require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/railties-6.1.4/lib/rails/commands/server/server_command.rb:138:in `block in perform'
	from <internal:kernel>:90:in `tap'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/railties-6.1.4/lib/rails/commands/server/server_command.rb:135:in `perform'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/railties-6.1.4/lib/rails/command/base.rb:69:in `perform'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/railties-6.1.4/lib/rails/command.rb:48:in `invoke'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/railties-6.1.4/lib/rails/commands.rb:18:in `<main>'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bootsnap-1.13.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32:in `require'
	from ~/.rvm/gems/ruby-3.0.1@bundler/gems/bootsnap-1.13.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32:in `require'
	from bin/rails:4:in `<main>'

@koppen there was a breaking change in 8.0.0 that was mentioned in the release notes. I also created https://github.com/countries/country_select/pull/211 to remove that reference from the readme.

The only breaking change I see in the release notes is related to priority countries, which we don't use, so I definitely missed that bit.
The change in #211 would definitely have helped me - thanks! :)


Integrate Slang

Slang doesn't have a CMake to build it. Maybe download the binaries at build time and cache them like Vulkan SDK

Fixed with CMake integration


Update dependabot settings

Description
Update the dependabot versioning strategy to increase-if-necessary.
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#versioning-strategy
Motivation and Context
When the pyproject file gets updated, it changes the hash in the lock file, so further changes require a rebase. Lots of the time we don't actually need to update the versions in pyproject.toml. So hopefully changing the strategy will reduce the number of merge conflicts we have with dependabot PRs.
How Has This Been Tested?
Read dependabot manual.
Checklist

[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.

I'm not clear on what increase-if-necessary means when applied to entire projects as opposed to individual dependencies.


clean code EventEmitter

split all method

Thanks for the PR! This module copies the Node core EventEmitter code though; it's easier to do that when it's in a single file, like it is in Node.

I did it to keep the code up and so it's easier

I think it's easier to apply updates if it's more similar to Node, because we can copy paste into the file and don't have to think about converting it to the modular structure.

@goto-bus-stop thank's


Remove mipsevm CLI hardcoding

Reopen of #107 because I couldn't get it to run the CI otherwise, rebased on top of #109.

The fault injection scenario keeps failing because of a socket error. I suspect it's simply too long-lived to work well on Github? It works well locally. This is already tracked by #99 but it seems to have gotten worse. Merging for now.

Checks did run successfully (except fault injection, as per #99), just rebase, so not waiting for them to re-run.


[Question]: I cannot figure out if Internet access works in librechat?

What is your question?
Hello, can you please explain if librechat has functionality to scrape web pages or is it on the roadmap?
More Details
scrape webpages would be nice to have. chatgpt does it already. maybe Google search is what i should be looking at?
What is the main subject of your question?
No response
Screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

We have a couple of plugins that can access the internet, for both the plugins endpoint and the assistants endpoint.


Reward safe address mistakes in issue 204 and 220

https://github.com/safe-global/safe-user-allocation-reports/blob/42697e4438244c992ec993c417ea885b06a3d8af/review/valid_reports.csv
Although these mistakes have nothing to do with me , i should point it out.
Thanks for the Safe team and all witch hunters.

For #220, 0x984129b1c8d6048df516d81f730475af7d0e4232 is used as specified in the issue: https://github.com/safe-global/safe-user-allocation-reports/issues/220#issue-1367323364
Fpr #204, 0xcee6063D59e3fF951677AD1E1B2b58C686efFA50 is used as specified in the issue: https://github.com/safe-global/safe-user-allocation-reports/issues/204#issue-1367189619
Where exactly do you see a mistake?

Found the mistake, thanks a lot.

Can someone brief me what was the mistake in #204 , please❓
The SAFE address stated here for #204 is correct and match with my submission.
I understand someone commented his ADDRESS as a reply to my report but I believe the team would have ignored his address already
I can also see the mistake in #220 was the last 2 digit in the address was switched but I see no mistake in #204 yet.
Can someone tell me what's wrong, please ❓
Cc: @tschubotz @farmerxx

Yes! I found the error now.
The error is still not fixed, please @tschubotz
It was only fix for the first address on the list while the last digit for addresses has changed. This usually happen when one highlights number on drag is down on Excel
0xcee6063D59e3fF951677AD1E1B2b58C686efFA50 ✅
0xcee6063D59e3fF951677AD1E1B2b58C686efFA51 ❌
0xcee6063D59e3fF951677AD1E1B2b58C686efFA52 ❌
0xcee6063D59e3fF951677AD1E1B2b58C686efFA53 ❌
0xcee6063D59e3fF951677AD1E1B2b58C686efFA54 ❌
0xcee6063D59e3fF951677AD1E1B2b58C686efFA55 ❌
Please fix it @tschubotz
Cc: @lukasschor

Yes! I found the error now.
The error is still not fixed, please @tschubotz It was only fix for the first address on the list while the last digit for addresses has changed. This usually happen when one highlights number on drag is down on Excel
0xcee6063D59e3fF951677AD1E1B2b58C686efFA50 ✅ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA51 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA52 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA53 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA54 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA55 ❌
Please fix it @tschubotz Cc: @lukasschor

https://raw.githubusercontent.com/safe-global/safe-user-allocation-reports/main/review/valid_reports.csv
Now it was fixed, no need to worry.

Alright, Thank you, friend


Fixed some serialization issues when multiple players are used

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.08%. Comparing base (3e72c2e) to head (1594072).

Files with missing lines
Patch %
Lines

NetAF/Serialization/GameSerialization.cs
33.33%
0 Missing and 2 partials :warning:

NetAF/Logic/Game.cs
85.71%
0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   85.09%   85.08%   -0.02%
==========================================
  Files         121      121
  Lines        3240     3251      +11
  Branches      530      534       +4
==========================================
+ Hits         2757     2766       +9
  Misses        298      298
- Partials      185      187       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HLSL: way to treat discard as OpDemoteToHelperInvocation without requiring SPIR-V 1.6/Vulkan 1.3

In DXC, there is an option to treat discard as OpDemoteToHelperInvocation -fspv-extension=SPV_EXT_demote_to_helper_invocation.  This is needed because OpKill can lead to undefined behavior in derivatives following the kill if it's executed outside of uniform flow control (OpKill is basically broken and has been deprecated).  Could we get an option like -fspv-extension=SPV_EXT_demote_to_helper_invocation so that that even for example for SPIR-V 1.3 we use the extension, i.e.:
               OpExtension "SPV_EXT_demote_to_helper_invocation"

...
               %7118 = OpLabel
               OpDemoteToHelperInvocation
               OpBranch %19382

Also, I noticed that DXC treats clip(x) as OpKill even under this option.  I'm not sure if that's a bug with DXC, but it seems like probably clip and discard should be treated the same?
Some background: https://github.com/microsoft/DirectXShaderCompiler/issues/2823

I also filed an issue on DXC for the clip question: https://github.com/microsoft/DirectXShaderCompiler/issues/5937

Putting q2 actually b/c we want to do it in Q1 but likely blocked on capability system...

This is now implemented. You can opt in to this behavior with
-profile spirv_1_4+SPV_EXT_demote_to_helper_invocation.


Add example to get kubernetes audit logs

Towards https://github.com/giantswarm/roadmap/issues/1898

Currently configured on gorilla https://github.com/giantswarm/workload-clusters-fleet/blob/main/management-clusters/gorilla/organizations/giantswarm-production/workload-clusters/zj88t/apps/promtail/configmap.yaml


Anerdw: Watch aknniherbscentre.com

Anerdw requests the watch of the watch_keyword aknniherbscentre\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

aknniherbscentre\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Fastnlight in Charcoal HQ


Update kops.md

kops uses DNS for discovery, both inside the cluster and outside so that you can reach the kubernetes API server
from clients.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.
For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17
For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh
For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>
If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/assign

@vyask Thank you for your contribution. Please sign the CLA so we can accept your PR for review.

Hi,
I did sign CLA last week, either on Fri or Sat.
thanks
Vyas

@justinsb can you serve as the technical reviewer for this PR? Just add a /lgtm when you feel the PR is technically correct. Thanks
/cc @justinsb

/assign @justinsb
Hi  @justinsb can you serve as the technical reviewer for this PR? Just add a /lgtm when you feel the PR is technically correct. Thanks

/assign @sftim
@sftim  can you serve as the technical reviewer for this PR? Just add a /lgtm when you feel the PR is technically correct.


Saving metadata in Dashboard properties is broken

Summary:
Saving metadata in Dashboard properties is broken.
Steps to Reproduce:

Edit dashboard  --> Edit Dashboard Properties --> Advanced
Change properties JSON, for example, totally remove default_filters or filter_scopes section
Click Save button to close edit Modal
Click Save button in dashboard header to finish edit mode

Investigation:
The root problem is, when you click the first save, new dashboard metadata send to backend, but after this save, this change is not updated in the dashboard redux store. So that when you click 2nd save, other old dashboard metadata sent to backend again, which overwrite the first request. The last change is overwritten.
Workaround:
There is a workaround that currently works (but it's not intuitive and likely we will have to explain it to all our users as they raise this issue): Click save only on modal, and not again on dashboard. Leave dashboard without saving the changes. The changes made on the Advanced Properties modal will actually get saved.
Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

@zuzana-vej thank you for reporting this.
@nytai can you take a looks at this

@zuzana-vej thank you for for reporting this. I wasn't able to reproduce this bug based on the step provided on commit hash a95e5c9327738489fd9fb547134f7ff4ea8c37af. Is ENABLE_REACT_CRUD_VIEWS set to True in superset/config.py?
Here is the video I tried to reproduce the bug:
https://www.loom.com/share/32547542dee24eb5bb5029b232c7e694

@lilykuang I think @zuzana-vej is referring to editing on the actual dashboard

Yes on the actual dashboard. @graceguo-supercat  can confirm, she did some debugging too. It should be reproduceable on dashboard, if not let me know I can add a video.

This seems related to the recent work that I did in this area. There's clearly components / modals that fetch and save straight to the endpoints without going through redux/actions here. This is convenient for the dashboard list view, but breaks down in the context where this is embedded in an app that does its own state management and triggers its own (delayed) save event.
The deep fix involves things like:

merging all "properties" / modals into a single modal with all properties (CSS, properties, filter mapping, auto-refresh)
"Ok" on that screen should just merge into the redux store, and not commit to database until user hits save
look into the implications that this has on the list view's "edit action" modal. My vote there would be to NOT allow the modal there and force the user to open the dash, get in edit mode and do the changes there.

I think ideally these modals should be more "dumb" to maximize reuse. OnSave should just delegate to a callback. This callback can be a redux action that just pushes the changes to state or a handler that fires a patch request... or both.
I'd be more in favor of only allowing dashboard edits on the dashboard page if it loaded faster and we could jump straight into edit mode. Having to click through, wait for the dashboard to load, toggle edit mode, then click into the properties modal is quite a journey for a quick edit.

I talked with a few folks about expected behavior and found some places where we could make improvements here. I've started work that is in progress that I've linked above, and should have something ready next week.

I'll be consolidating some of the modals and fixing the save not delegating to redux issue sometime next week

I know that there are some usability features that we're discussing to improve this flow, but do you all think that https://github.com/apache/incubator-superset/pull/11220 has fixed this particular issue?

No, it didn't. Right now, (after #11220 merged) this is what happens if user tries to edit dashboard metadata (e.g. best way to test this on your test dashboard is to change color of one of the lines on your chart in the dashboard metadata tab).
Right now, what happens, is:

user edits metatada (e.g. change color of a line on a chart)
user clicks save on modal (all good)
user clicks save on dashboard --> and gets the message "this dashboard has changed, please reload"
when user reloads, the change is actually applied

So in a way it solves the issue - change is applied, but user currently gets a warning message which will confuse them.
cc: @graceguo-supercat
High level I do agree we don't have to build the perfect long term solution since there are planned improvements.

I am going to close this because looks like https://github.com/apache/incubator-superset/pull/10834 resolved the issue. Thanks @eschutho!


Move benchmarks to run docker containers

Is your feature request related to a problem? Please describe.
Currently the benchmarks run the binaries themselves, this is ok for developers as they will have all of the dependencies already available and should be able to build the artifacts. However, for increased reproducibility I think it would be better to have the benchmarks run in containers. This standardises the version and we can publish tagged images from GH releases.
Describe the solution you'd like
The benchmarks run the nodes in docker containers rather than using the local enclave objects.
Describe alternatives you've considered
Continuing running as is, see above.

Completed for lskv nodes, not yet for etcd.


Resubmitting since repo is public

Resubmitting because repo is now public. Also updated some links and made a few whitespace changes to follow PEP8.

Thanks, @srosagomez, for your contribution! The style-checker fails due to the length of the markdown cells for these notebooks, which we can ignore as running style checks succeed for the code cells on both local testing and the style checker. You can go ahead with the merge.


Adds vtkAlgorithm support

Do not merge (yet)
I wanted to open a PR to let you know I'm heavily using GeoVista and working to tailor it to my needs.
This branch requires a dev branch in PyVista: https://github.com/pyvista/pyvista/pull/3318
A few more things I want to do:

[ ] Clean up these code changes
[ ] Support 3D data (rectilinear and structured grids)
[ ] Optimizations

@banesullivan Awesome PR, thanks for contributing. Super excited that you're using geovista 🤩
I'm currently working on some fundamental infrastructure changes this month to address some issues, with the aim of making a first release. But after that I'd be more than happy to look at extending the geovista.bridge to support 3D meshes. I think that's completely possible, building on what's already there.

This is too outdated... going to open a new PR


Forbid future index-states in CI

This prevents future index-states to land in our cabal project.
In any case this will also be forbidden by cabal itself in the near future, so it is here just as a sanity check.

It is indeed very ad-hoc, but it happened just now:
❯ cabal build all
Warning: Requested index-state 2024-06-18T14:00:00Z is newer than
'cardano-haskell-packages'! Falling back to older state
(2024-06-18T12:42:43Z).

This was for some time a future index-state

Closing as cabal-install <IP_ADDRESS> was released


[no-use-before-declare] too strict on class members

Given this example:
class Foo {

    // variables go here

    constructor() {
        this.fooBar = sequence(this.foo, this.bar);
    }

    // methods go here

    public fooBar:() => void;
    private foo():void {}
    private bar():void {}

}

Since fooBar is a function, I like to group its declaration with the rest of the class methods.
However tslint throws a variable 'fooBar' used before declaration error.
I think this is too strict because those declarations are TypeScript compiler markers that don't result in any generated JavaScript. This is the generated JS for the example:
var Foo = (function () {
    function Foo() {
        this.fooBar = sequence(this.foo, this.bar);
    }
    Foo.prototype.foo = function () { };
    Foo.prototype.bar = function () { };
    return Foo;
})();

Completely legit.
The ordering of the members that I use here might be debatable, but [member-ordering] is supposed to check that, not [no-use-before-declare].
Possibly related to the fix for #89

I just tried both examples with the most up-to-date version of tslint and there were no issues. Can we close this one?


[Issue] Missing 15.1.1531.10 Baseline

Looking forward to this baseline being released.

Created a single task for tracking all missing baselines, please follow: https://github.com/microsoft/CSS-Exchange/issues/313


[kafka_consumer] set an upper bound to the number of contexts.

What does this PR do?
Tackles two issue:

Since the auto collection of consumer groups, topics and partitions was introduced we're under risk of creating way too many contexts. This PR will set an upper bound to the number of contexts the check may collect. If the value of potential contexts is exceeded the check will not submit any metrics.
We will not submit consumer offsets if the offsets are not available in the broker. Although the metrics are available, it changed behavior and could affect existing monitors and dashboards.

Currently I'm just computing the context leaves, which is equal to the total number of partitions across all topics. The actual number of contexts generated would exceed that, by virtue of the different valid permutations. The rationale was basically setting a reasonable upper bound on the number of different partitions collected in a production cluster. We could always be more strict regarding the precise number of contexts.
Motivation
Collateral spotted during QA.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning

[x] Bumped the version check in manifest.json
[x] Updated CHANGELOG.md. Please use Unreleased as the date in the title
for the new section.

As said - merging! :)


Add more information in RequestContext class

As per discussion in https://github.com/apache/pinot/pull/11437#discussion_r1326698944 adding more information to RequestContext class. Most of the fields already existed in BrokerResponse so adding more information in RequestContext class to use in Event Listener implementation as part of #10606.

Codecov Report

Merging #11708 (aff099f) into master (cf8fd93) will decrease coverage by 48.60%.
Report is 4 commits behind head on master.
The diff coverage is 22.58%.

@@              Coverage Diff              @@
##             master   #11708       +/-   ##
=============================================
- Coverage     63.04%   14.45%   -48.60%
+ Complexity     1117      201      -916
=============================================
  Files          2342     2342
  Lines        125780   125835       +55
  Branches      19334    19335        +1
=============================================
- Hits          79301    18185    -61116
- Misses        40828   106108    +65280
+ Partials       5651     1542     -4109

Flag
Coverage Δ

integration
?

integration1
?

integration2
?

java-11
?

java-17
14.44% <22.58%> (-48.46%)
:arrow_down:

java-20
14.43% <22.58%> (-48.47%)
:arrow_down:

temurin
14.45% <22.58%> (-48.60%)
:arrow_down:

unittests
14.45% <22.58%> (-48.60%)
:arrow_down:

unittests1
?

unittests2
14.45% <22.58%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...roker/requesthandler/BaseBrokerRequestHandler.java
47.12% <100.00%> (+0.72%)
:arrow_up:

...ava/org/apache/pinot/spi/trace/RequestContext.java
0.00% <ø> (ø)

...thandler/SingleConnectionBrokerRequestHandler.java
18.18% <0.00%> (-0.24%)
:arrow_down:

...requesthandler/MultiStageBrokerRequestHandler.java
18.97% <0.00%> (-0.29%)
:arrow_down:

.../apache/pinot/spi/trace/DefaultRequestContext.java
0.00% <0.00%> (ø)

... and 1516 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@siddharthteotia @jackjlli Can you take a look?

@walterddr @Jackie-Jiang can you please review?

hey @walterddr can you help in reviewing this?


Events: Fix unusable infinite bombs with empty inventory

Infinite bombs would not be selectable in the menu if you didnt have another item available, which can happen when uncle gives you a sword
The selected item also would be refreshed (in Link_ReceiveItem) before we enable the bombs so you'd have to menu from an empty slot to equip them

I encountered this same issue working on my bombs-only mode (since I have the player start with infinite bombs), and while fixing it noticed that the menu still behaves a little funny if you only make the change in this PR.
Specifically, when you open the menu with infinite bombs and no other items, the menu will not show the bomb selected and will go away if you press any button instead of letting you use direction keys to attempt (and fail) to select another item.
It's not a huge deal since it doesn't affect ability to access bombs or cause any other problems (as far as I can tell), but for consistency's sake the following addition to hooks.asm fixes it (changing two other places the menu checks if you have any items to use the new code):
;--------------------------------------------------------------------------------
org $0DDDE8 ; <- 6DDE8 - equipment.asm : 148 (LDA $7EF340)
JSL.l SearchForEquippedItem
;--------------------------------------------------------------------------------
org $0DDE70 ; <- 6DE70 - equipment.asm : 273 (LDA $7EF340)
JSL.l SearchForEquippedItem
;--------------------------------------------------------------------------------

I noticed that but didn't care for it since it was irrelevant as far as escape is concerned. Thanks for the edits, I've included them in the commit


Some minor additions/fixes to master

Added NuFit v4.0 osc params (cfg file)
Fix to atmospheric muon stage, not uses a consistent method to get the correct arrays from the input data

Looks good, I quickly checked nufit4 values and they look correct


Added some context and updated example with new correct filepath

Closing this as an alternate PR got merged that does the same thing


Bump all of our dependencies.

In order for me to bring in the automated networking support (as well as use current versions of Docker), we need up to date dependencies.
Currently trying this out and will remove the WIP tag when ready.

Ok, awesome. This is working really well after the dependency bump. I was happy to see that at least for the defaults, I didn't have to make any changes for APIs.
/cc @parente @minrk

+1


TEOC Provisioning error

Getting this error when attempting initial setup:
PnP.PowerShell module found
Checking if site already exists at /sites/TEOC_SITE_2
Site doesn't exist, creating new site at /sites/TEOC_SITE_2
https://xxxxxxxxx.sharepoint.com/sites/TEOC_SITE_2
Creating lists in TEOC_SITE_2 site
Error Message:  File not found
App Provisioning failed.

@Electric-Velcro Thank you for reporting this.
Please confirm the path of the EOC-SiteTemplate.xml file. Make sure you have entered the fully qualified path of the XML file (e.g., C:/Scripts/EOC-SiteTemplate.xml). Additionally, here is the deployment guide link for your reference.
https://github.com/OfficeDev/microsoft-teams-emergency-operations-center/wiki/Deployment-Guide#1-provisioning-teoc-site


Terminal Buffers not shown in tabline

environment

vim: NVIM v0.3.8
vim-airline: 0.12
OS: Ubuntu 18.04
Have you reproduced with a minimal vimrc: NO
What is your airline configuration:
Plug 'vim-airline/vim-airline'
let g:airline#extensions#tabline#enabled = 1
" Show just the filename
let g:airline#extensions#tabline#fnamemod = ':t'

if you are using terminal:

terminal: wslmintty
$TERM variable: screen-256color
color configuration (:set t_Co?):
if you are using Neovim:
does it happen in Vim: I'm not sure if vim has :term

actual behavior
When opening :term tabline doesn't show the buffer
expected behavior
Show terminal buffer in tabline
screen shot (if possible)

Please write this config in your vimrc.
let airline#extensions#tabline#ignore_bufadd_pat =
    \ '\c\vgundo|undotree|vimfiler|tagbar|nerd_tree'

yes, this is expected and in the help. @kazukazuinaina  show how to configure it. Have a look at :h vim-airline and then search for ignore_bufadd_pat.

Thank you for the supplementary additional information, Christian.


FIX:  TS error for useContext

TS error for useContext
I'n Editor.tsx, I haven't been able to get rid of the error underneath wordiablesState, setWordiablesState
- Code in suspect: const [wordiablesState, setWordiablesState] = useWordiablesContext();
- Console Report:
 // TS BUG: both items in array are throwing off tslinter
 // TS Report: Type 'object' is not an array type.ts(2461)

Checklist

[x] Remove TS lint error

[x] Make sure state is accessible

[x] Make sure state is updatable
Update 4/29/22
Fix the error by wrapping context with Object.values to iterate through the object, and then I was able to destructure the produce Array in a way that TS will accept. However, the dispatch isn't happy because it'll try to rerender state while updating it (out of sync). I have never used dispatch without a reducer, which could be one of my issues.

Here's their error
Warning: Cannot update a component (`WordiablesWrapper`) while rendering a different component (`Editor`). To locate the bad setState() call inside `Editor`, follow the stack trace as described in https://reactjs.org/link/setstate-in-render
Editor@webpack-internal:///./src/components/Editor.tsx:67:124
main
div
Layout@webpack-internal:///./src/components/Layout.tsx:15:20
div
Home
WordiablesWrapper@webpack-internal:///./src/context/wordiablesContext.tsx:17:20
App@webpack-internal:///./pages/_app.tsx:39:21
ErrorBoundary@webpack-internal:///./node_modules/.pnpm/next@12.1.5_d7d27f3bc85bacccfb9132af84144489/node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:20638
ReactDevOverlay@webpack-internal:///./node_modules/.pnpm/next@12.1.5_d7d27f3bc85bacccfb9132af84144489/node_modules/next/dist/compiled/@next/react-dev-overlay/client.js:8:23177
Container@webpack-internal:///./node_modules/.pnpm/next@12.1.5_d7d27f3bc85bacccfb9132af84144489/node_modules/following/dist/client/index.js:323:24
AppContainer@webpack-internal:///./node_modules/.pnpm/next@12.1.5_d7d27f3bc85bacccfb9132af84144489/node_modules/next/dist/client/index.js:825:20
Root@webpack-internal:///./node_modules/.pnpm/next@12.1.5_d7d27f3bc85bacccfb9132af84144489/node_modules/next/dist/client/index.js:949:21

Solved: The code structure of the context file has been simplified to maintain easier typing.  The initialState of the context is now an array with strings instead of objects.  Reducing the context state to its essentials (in this case, just the wordibles: string) has made it easier to declare the correct data types of the context.
Moving the logic into a library makes more sense because then I could write an algorithm that will infer attributes of the Wordiable based on its position in the context's Wordiables array.


Add push_url as a keyword for push_meta

See the very minute confusion at https://github.com/godotengine/godot/issues/94128

Thanks!


focusFollowMouse delay

Allow a user-configurable delay to the 'focusFollowMouse' feature
Windows itself allows us to set a delay for its focus-follows-mouse feature, it would be nice if Terminal did too.
Ideally this would not be "additive" to Windows delay. E.g. this scenario:

I have both delays set to 500ms
I have two panes open in terminal, pane A and pane B
I exit the Terminal window with pane A focussed
I re-enter the Terminal window via pane B's area

then I should not have to wait 1000ms for pane B to gain focus, only 500ms.

Out of curiosity, are there other apps that have their own configurable delay that's non-additive with the system's setting?
I guess the Terminal's version of the settings would act like a "override" of the system setting. The trick here would be looking up the actual value of the system setting, which I doubt there's be a way to do reliably. Then again, almost everything I think isn't possible to look up is usually somewhere on SystemParametersInfo
In general, I'm cool with this, esp. since there's OS precedence for this kind of thing.


Merge webpack plugin configuration / DefinePlugin

Current Behavior
If you add a DefinePlugin section to your webpack.haul.js / config plugins, it will override the default DefinePlugin stuff set up for you by makeReactNativeConfig. For example, you could have a webpack.haul.js like:
module.exports = ({ platform }) => ({
  entry: `./index.js`,
  plugins: [
    new webpack.DefinePlugin({
      'API_HOST': JSON.stringify(process.env.API_HOST),
    }),
  ]
});

If you try to run your app, you'll get mysterious errors such as undefined variable __DEV__, but after looking into it the problem is that the plugins are overridden.
Expected Behavior
I think there are a few options here.

haul should be able to intelligently merge plugins
haul should provide documentation / a clear path for merging of plugins
Just for my specific case, haul should provide the ability to forward environment variables or other fine grained configuration.

Haul Configuration (webpack.haul.js)
Sufficient to reproduce:
module.exports = ({ platform }) => ({
  entry: `./index.js`,
  plugins: [],
});

Your Environment

software
version

Haul
v1.0.0-beta.13

react-native
0.53.0

node
9.5

npm or yarn
1.3.2

The base config gets passed as an argument to the exported function to generate the app configuration. This allows you to spread the plugins as well:
module.exports = (_, { plugins }) => ({
  entry: `./index.js`,
  plugins: [
    new webpack.DefinePlugin({
      ...
    }),
    ...plugins,
  ],
});

We say in the configuration docs that you should merge the passed config yourself. https://github.com/callstack/haul/blob/master/docs/Configuration.md

If you are want to customize the webpack configuration, like loaders etc., define them as usual, and merge the passed configuration in

It's not possible for Haul to intelligently merge config automatically. It'll be flaky and also prevent people from overriding stuff when they actually need to.

I'm not sure that just closing the issue is the right way. I think that the issue should be addressed somehow, because merging plugins that are already used internally in Haul is extremely unconvinient and it doesn't documented anywhere. This is the only way I could get it working:
let definePluginId = defaults.plugins.findIndex(p => p.constructor.name === 'DefinePlugin');
defaults.plugins[definePluginId].definitions['process.env']['MY_ENV'] = JSON.stringify(process.env.MY_ENV);

I do agree that merging should be done manually, but not this way (it's an unreliable and unconvinient ad hoc solution). Ideally, webpack plugins themselves should be able to merge configurations when defined multiple times, but in this case I think that providing some API to swap plugins and fetch their default configuration would already be a huge improvement.

This would be lots of easier with this PR https://github.com/callstack/haul/pull/372, still in the progress but I hope it will be soon in the master! Stay tuned. 🙏

@jukben sounds great. I looked through the PR, but couldn't understand how it could solve the problem for DefinePlugin though. Could you elaborate a bit? Thanks!

You are right. In this case, the effect would be the same. It will be cleaner, but you have to still find the plugin and rewrite it manually.

@baygeldin with the new config format you can use something like webpack-merge to do the merging. I think it's better that we don't try to solve this problem because there are other tools which try to solve it already.

That's a good point. Although looking at webpack-merge sources I'm not sure if it can merge plugins configuration, but it can swap plugins though. Anyway, babel-plugin-transform-inline-environment-variables works perfectly for my usecase, so it's okay. Thanks for your help. Keep it up, Haul is a great tool :)


Global thunks

Codecov Report

Merging #773 (1509084) into main (407585e) will decrease coverage by 0.01%.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   85.33%   85.31%   -0.02%
==========================================
  Files         311      311
  Lines       29006    29015       +9
==========================================
+ Hits        24753    24755       +2
- Misses       4253     4260       +7

Impacted Files
Coverage Δ

lib/app/src/error.rs
0.00% <0.00%> (ø)

lib/app/src/file_finder.rs
0.00% <0.00%> (ø)

lib/app/src/infra/file_path.rs
80.00% <0.00%> (-3.48%)
:arrow_down:

lib/app/src/external_package_topological_sorter.rs
100.00% <100.00%> (ø)

lib/hir-mir/src/module_compiler.rs
90.65% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407585e...1509084. Read the comment docs.


ratio is never set

messageStoreConfig's default role is  ASYNC_MASTER ,and -c config is parse and use after this part ,so is it never set ratio?
https://github.com/apache/rocketmq/blob/31a7edd618d70c62ad2bdfcda187c16ff7cfd37e/broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java#L100-L103

what 's your mean

brokerRole in MessageStoreConfig will be changed at the broker role change.

i mean that  the code in if block will never execute

i mean that the code in if block will never execute

BrokerRole need specify in broker.conf if you want to deploy a master-salve cluster.


Set campaing ID from cookie if present for RFQ, landing pages and get in touch

If user lands on website with some cmp id value in the query string like https://www.moleculardevices.com/events?cmp=1234, then cookie will be set for that particular cmp id and leads will be assigned to that particular cmp id which is there in the cookie/query string  rather than default cmp id for that particular page/form.

As discussed in the call this works as follows:
Only on:

quote-request page - implemented by @kapildhiman
contact us page - https://github.com/hlxsites/moleculardevices/pull/1101
landing pages - https://github.com/hlxsites/moleculardevices/pull/1088

The cmp is only replaced, if there is a value for this parameter in the hubspot url. it is not added if the url doesn't have one.


TransitionGroup does not remove DOM elements

When TransitionGroup wraps For component, removing one or more items from the array passed to the For component does not remove DOM elements.
https://stackblitz.com/edit/solidjs-templates-6yr2yt?file=src/App.tsx
In this example there is list of names. Swapping rows (up/down buttons) works and is properly animated, but removing rows (x button) does not.

Hmm.. I know why this is happening, and we could definitely document this better. Honestly, I copied Vue's implementation here which may not have been the best reference.
It comes down to, if you don't provide your own animation handlers in JS(onExit) the only way we know things are done is if there is a DOM animationend or transitionend event. So in absence of adding exit animations the elements aren't removed.
Easiest way to do it is:
.s-exit-active {
  transition: opacity 0.1s;
}
.s-exit-to {
  opacity: 0;
}

But this is non-obvious and you would think there would be opt-in. And yet this is how the Vue API works I believe.

Thanks, that fixed the issue. I agree that at least a mention in the documentation would be a good idea. This example you provided is enough to get the general idea.


add volume api support for convoy

@ibuildthecloud This requires python-agent changes to be implemeneted.

Can you rebase?


Add bulk get for actor state

/area runtime

Describe the feature
Because actor state supports granulated state it would be more performant if state APIs also supported getting state from multiple state granules in single call.

Hi, we have similar problem, but for state management usage out of Actor, for some data storage through state manager (client.GetStateAsync), and some bulk get for the state, maybe with some filtering, would help us. In the current situation it's not possible for us to store more values through state store, because we would have to get them by calling GetStateAsync for each entity. Drivers for MongoDB, CosmoDB or other languages support filtering and aggregations, counting, it would be great to have ability for more sophisticated calls to API and then from SDKs.

I created similar issue 1339 , which is extending bulk get for basic state store usage, without actors

Can you provide more details on your specific scenario here?

Example you have state that keeps count of state granules. In my case I would have liked to do something like this but I refactored my code to work differently and I don't use multiple state granules anymore because of this problem.

Let's say they are like comments with keys like comment_1 comment_2 and so on and you have 10 of them so count is 10.
You call the actor and ask give me first five comments. Then you need to get states with keys comment_1 through comment_5.
Or you call actor and want last 5 states then you need to get comment_6 through comment_10.

C# SDK doesn't support Task.WhenAll because it can't since it caches state into Dictionary that is not thread-safe so you can't have concurrently running tasks inside a actor that reads or writes state. Related issue is here https://github.com/dapr/dotnet-sdk/issues/271
So what this means you need to get every state granule one at a time if bulk get is not supported. I think either you need to add bulk get or fix dotnet-sdk to be thread safe.

Actually there is a third option, just add bulk get to dotnet-sdk that would use Task.WhenAll underneath but would work with its non-thread-safe caching.

It'd be helpful to extend the state store API to include bulk get operations and then pass that through to the Actor SDK / API. I'm not sure why BulkGet was omitted from the state store, maybe there was a reason?
// Store is an interface to perform operations on store
type Store interface {
	Init(metadata Metadata) error
	Delete(req *DeleteRequest) error
	BulkDelete(req []DeleteRequest) error
	Get(req *GetRequest) (*GetResponse, error)
	Set(req *SetRequest) error
	BulkSet(req []SetRequest) error
}

I'm currently playing around with an event sourced based actor implementation on Dapr for a POC which requires grabbing all the existing events on activation. The use case doesn't allow snapshotting and just storing the "current" state. Right now I'll probably just deal with the large number of round trips to state (or store all events in a single large item that gets updated) but neither of those are practical for a real implementation.

@plaisted are you still up for implementing this for non-actors first?


Path in remote storage should be configurable

Today, the path is not configurable and is simply /<workspace-name>/ inside the remote storage bucket. It would be nice to be able to set an arbitrary path in the snapshot() macro to override the default.

Could possibly be achieved very easily by supplying the storageURL config with the path you want. like gcs://bucket-name/arbitrary/path/to/workspace


Variable Declaration Split to Declaration + Assignment statement

https://github.com/flozender/jgit/commit/45e79a526c7ffebaf8e4758a6cb6b7af05716707?diff=split#diff-61139ff71d8675ad33d046412d1fca65a59c31c8325cc757238d3283eb2219f6R128
RevWalk revWalk = new RevWalk(repo);
has been split to statements
RevWalk revWalk = null;
revWalk = new RevWalk(repo);
I thought we were avoiding the unnecessary added/deleted edits around = and ;

This is another case: https://github.com/JetBrains/intellij-community/commit/9fbf6b852bd9766060307aff960fb597d55e24d3
File: CachingEnumerator.java

@pouryafard75


gulp 'on finish' hook?

.on('end', function () {

});

Please direct future support questions to stack overflow

I apologise @callumacrae - I hit 'comment' prematurely.
What I was going to say is:
I often have tidy-up work to do after gulp tasks have run. Closing down DB connections, ensuring mocha has finished, etc.
I can't put this logic in a separate task and run it, because the order of execution is not guaranteed. I can use a lib like https://www.npmjs.com/package/run-sequence, but then I'm writing a lot of 'wrapper' tasks just to do some clean-up.
I'd like to suggest a global 'on finish' task, like:
gulp.on('finish', function() { /* whatever /* });
... that runs, no matter which tasks are called from the CLI.

gulp.task('my-tasks', [...all tasks...]);

gulp.task('default', ['my-tasks'], function () {
  // close everything down here
});

Alternatively, check out the beforeExit event on the process module: https://nodejs.org/api/process.html#process_event_beforeexit

@callumacrae thanks for the suggestion, but that won't solve it.
'beforeExit' is only emitted when Node actually intends to exit. If there are open DB connections or file handles left, it will never get to that point.
Throwing clean-up code in 'default' doesn't solve it either, because I have over 50 separate tasks outside of 'default'.
Take this code:
// Get random user
gulp.task('_user:random', function (done) {
    return db.instances.User.random().then(function (user) {
        return console.log(user.dataValues);
    });

});

gulp.task('user:random', function(done){
    runSequence('_db:open', '_user:random', '_db:close', done);
});

You can see that I'm creating TWO tasks:

For the actual task logic itself.
A "wrapper" for that logic, that will open the DB and close it.

I need to do it this way because I have other tasks that include _user:random as part of a sequence of tasks that ALL depend on the DB being open... whereas user:random is a "standalone" task that I might call via the CLI.
This makes for incredibly messy code, since I ultimately have one task that works as part of a sequence, and another that operates on its own.
It'd be much more elegant if I could do something like this:
gulp.on('beforeExit', ()=>{
   if (db) db.connection.close();
});

That way,  I wouldn't need any ugly wrappers, since any outstanding DB connections, files or anything else pending could be cleaned up, so the process could then exit.

Normally, Node.js exits when there is no work scheduled, but a listener for 'beforeExit' can make asynchronous calls, and cause Node.js to continue.

process.on('beforeExit', function(){
    console.log('GOT HERE!');
})

The console never logs when there's open DB connections.
Am I missing something?

Use gulp 4, run-sequence is bad
If you want something to run after each task, there is a task_stop event (as well as task_start, task_err, and task_not_found)

@contra Is 4 ready for primetime? NPM is still on 3.9.
task_stop runs after every task. I need an event that emits very end of ALL the tasks.
So if I run something like:
gulp db:rebuild fixtures:insert some:other:task
... an event would be emitted when they've all finished.
Anyone that is using Sequelize connection pooling would find this immediately useful. There is currently no "middle event" between tasks finishing and process emitting beforeExit... which is the crack I'm falling into.

This isn't something that is going to be introduced (3.x or 4.x branch) as it is not a problem we are trying to solve.  3.x branch is done changing and 4.0 is about function composition.  It is a crazy edge case and there are ways to implement this in userland.  Going to lock this as we don't need bikeshedding spamming our inboxes.


build build-dependent versions.json before build builds

add cs-version to build script b/c github action builds before it releases (currently version file is only generated in release step
Fixes #164
What this PR solves / how to test:

fix failed build

to test:

npm run clean
npm run build
✅

@evanderkoogh 👀

And people wonder why release engineering is a proper job these days :D
Thanks for that!


Update SearchFilter to Foundry VTT 0.7.9

Which class should be updated?
SearchFilter
For which version should the class be updated?
Foundry VTT 0.7.9

Taking this.


[Bug] Website is too zoomed in

the preview website is overly zoomed in i can't even browse it, this happens on firefox on linux and it doesn't even load on mobile...

Semi.Avalonia is not specifically optimized for mobile devices or web platforms. However, we recently added a button to collapse the TabControl, which might help improve the browsing experience.

Actually, I want to apologize... the issue turned out to be on my side, I'm using librewolf with ResistFingerprinting enabled and that messes with Avalonia when it tries to get the dimensions of my browser.
sorry...


[BUG] made build tools files executable

Changing file modes of shell scripts in build_tools.
❯ chmod +x build_tools/fail_on_missing_init_files.sh
❯ chmod +x build_tools/run_examples.sh

thanks!
can you explain why this works and how you arrived there?
Would be keen to learn.

This was the error:

/home/runner/work/_temp/eb86de82-ffe2-410b-a2c0-761c6bcf4458.sh: line 1: build_tools/fail_on_missing_init_files.sh: Permission denied

And this was the code:
      - name: Check for missing init files
        run: build_tools/fail_on_missing_init_files.sh
        shell: bash

Now, I knew bash can't run any file directly in shell unless it's executable, one has to make them executable or do bash <file_name>. In case there are special scenarios, I am unaware, but don't really care much as I am not a shell person and will probably never be.
I faced similar issues in Gitlab CI before with my work projects, and switched to auto check of this sort of things with pre-commit hooks since then (check-shebang-scripts-are-executable and check-executables-have-shebangs). It was same here, checked the file mode, saw it's not executable, changed and it worked.

I see. But, how is this different from sktime or skbase where the same works? It is a content identical copy, this confuses me.

File contents do not make a file executable, file mode does. The files in skbase and sktime are already executable. You can try changing file modes on these repositories as well, e.g. make them non-executable with chmod -x <file_name>, and they should fail in CI afterwards.
I know too less about these stuff to explain well. These can give some ideas, and there can be other better references:
https://en.wikipedia.org/wiki/File-system_permissions
https://linuxhint.com/linux_chmod_command_tutorial_beginners/
https://www.redhat.com/sysadmin/linux-file-permissions-explained
https://kb.iu.edu/d/abdb


Enhance Function component

[X] Added ability to work with short closures
[X] Added pointer cursor
[X] Added tests
[X] Added showcases

Fixes: https://github.com/TexteaInc/json-viewer/issues/72

still have the error

There still have Hydration errors. let me check later

There still have Hydration errors. let me check later

I think that's because the server-side treat every function as the same(whether arrow function). but the client side is not.
Maybe we should turn NoSsr here?

Yeap code is obfuscating by SSR and it should be disabled.
But the bug the function name doesn't match with it. I've fixed it.

It's completely ready for review and merge.


Fix copyright headers on middle-reflink.c and perf.sh

I've tested the code locally and verified the comments don't break it.


Remove unused private member

@psigen The private member class_decl_ isn't used in Parameter class.  Can we remove this and change the constructor of Parameter not to take class_decl as well?

I was a bit torn on this.
The reason that I was leaving in this argument was that I wanted to maintain parity with the other type classes which build up their parameters in the same way.  For example, it seemed like this should have at least the same arguments as a Method, since this is even more specific in scope.  Also I wasn't convinced that we might not need this argument to access some property in the future.
Would it be possible to mark it unused via a macro, similar to the strategy in DART and Aikido?

That make sense. Let's leave it as it is.

Would it be possible to mark it unused via a macro, similar to the strategy in DART and Aikido?

We used this tactic, but I don't know if there is a way for a member variable.

@jslee Perhaps we can apply the UNUSED macro on both the constructor arg and the member variable inside the constructor:
Parameter::Parameter(const ::chimera::CompiledConfiguration &config,
                     const ParmVarDecl *decl,
                     const FunctionDecl *method_decl,
                     const CXXRecordDecl *class_decl,
                     const std::string default_name)
: ClangWrapper(config, decl)
, method_decl_(method_decl)
, class_decl_(class_decl)  // <--- Let's add this line
, default_name_(default_name)
{
    // Reserved for future use.
    UNUSED(class_decl_);  // <-- Should mark member as "used"?

    register_methods(this, {
        {"name", &Parameter::name},
        {"type", &Parameter::type},
    });
}


HackathonPLUS - LionSwap

LionSwap
Project code warehouse (optional)：https://github.com/LionswapTeam/Lionswap
Project Description:

LionSwap is committed to creating a decentralized, censorship-resistant, safe, multifunctional platform to eliminate agency. It builds a positive cycle  to promote each other by integrating Swap, NFT, DAO and other sectors.
LionSwap solves the liquidity problem of user token assets on Plat/Alaya, and provides the PlatON/Alaya ecosystem with the liquidity and value-added channel of digital assets. It can offer a certain degree of innovation in financial risk management to expand the applied ecology at the same time. the users participating in LionSwap can bring not only more players and data to the PlatON/Alaya ecosystem, but also the innovative design of application scenarios to enhance the diversity of the ecological community.
-In future expansion plan of  LionSwap, it will provide fertile soil for intellectual property contributors to empower NFTs development innovatively and support the NFT ecological construction vigorously through community autonomy.

Project plan: // Goals and deliverables in each stage

V1.0 infrastructure

LionDEX

Trade
Farm
Other

V2.0 Upgraded/Newly added items1

LionDEX

Farm: governance

LionNFT 1

NFT creation
NFT transaction
NFT casting
NFT mirror authorization

LionNFT 2

Initial NFT

V3.0 Upgraded/Newly added items2
* LionDAO

Milestone 1-V0.1 version demo to provide transaction and liquidity

Estimated Working Hours: 10 working days

Deliverable number
Deliverable
Illustrate

0a.
Open source protocol
Apache 2.0 / MIT / Unlicense

0b.
Documents
Requirements documents, framework documents of platform transactions, technical framework plan and design documents

0c.
Test guide
Test case

1.
Product and interaction design
Product and UI design with updated and completed the main page design and front-end function development

2.
Wallet link
Samurai wallet integration

3.
Factory
Factory contract, responsible for deploying matching contract

4.
Router
Matching contracts are used to create trading pairs. Each trading pair will have a matching contract. Initial assets need to be added to provide liquidity when creating

5.
Pair
Used to bring the token exchange and  the deposit/withdraw liquidity (Add/Remove Liquidity) operations

Milestone 2 — V0.3 version adds farm section

Estimated Working Hours: 10 working days

Deliverable number
Deliverable
Illustrate

0a.
Open source protocals
Apache 2.0 / MIT / Unlicense

0b.
Test guide
Test case

1.
V0.1 version tuning
Solving the problems that may occur in the V0.1 version and optimizing

2.
Front-end page
Completing UI page for front-end page development

3.
Farm sector
Add LP, withdraw LP, liquidity rewards, application for project entrying into the farm

Milestone 3-V0.6 version tuning

Estimated working hours: 5 working days

Deliverable number
Deliverable
Illustrate

0a.
Open source protocals
Apache 2.0 / MIT / Unlicense

0b.
Test guide
Test case

1.
V0.3 version update
To optimize by solving the problems that may occur in the V0.3 version

Milestone 4-V1.0 version released

Estimated working hours: 3 working days

Deliverable number
Deliverable
Illustrate

0a.
Open source agreement
Apache 2.0 / MIT / Unlicense

0b.
Documentation
Product basic tutorial, test case and test result report

0c.
Test guide
Test case and test result report

1.
V1.0 Version 1.0 implemented
Version 1.0 released

Contact<EMAIL_ADDRESS>LAT address : lat1csfaqf8tygzsatsqa7t0vucjkqnf5vwneznk42

LionswapV1.0 milestone completed content:
1.Milestone 1-V0.1 version demo to provide transaction and liquidity
2.Milestone 2 — V0.3 version adds farm section
3.Milestone 3-V0.6 version tuning
4. Milestone 4-V1.0 version released
Swap plate
※Samurai wallet integration
※Factory contract, responsible for deploying matching contract
※Matching contracts are used to create trading pairs. Each trading pair will have a matching contract. Initial assets need to be added to provide liquidity when creating
※Used to bring the token exchange and the deposit/withdraw liquidity (Add/Remove Liquidity) operations
※Product and UI design with updated and completed the main page design and front-end function development
※Requirements documents, framework documents of platform transactions, technical framework plan and design documents
Farm section
※Add LP, withdraw LP, liquidity rewards, application for project entrying into the farm
Link address: www.lionswap.network

@LionswapTeam
Are there relevant deliverables? Can be submitted via PR (create your project folder under the active folder)


[GOBBLIN-179] Add shim layer for Gobblin state

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-179

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Add shim layer for Gobblin state

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Existing test that were disabled during package migration work.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@htran1 Please review.


open from right

hi,how to open drawerlayout from right edge?

@tq09umn I will add this feature later.


WIP: use lazy loading for TLS certs on activator

testing only

Codecov Report
Base: 86.23% // Head: 86.20% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (43853d4) compared to base (9b9a951).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   86.23%   86.20%   -0.03%
==========================================
  Files         197      197
  Lines       14774    14778       +4
==========================================
  Hits        12740    12740
- Misses       1733     1736       +3
- Partials      301      302       +1

Impacted Files
Coverage Δ

cmd/activator/main.go
0.00% <0.00%> (ø)

pkg/reconciler/configuration/configuration.go
82.93% <0.00%> (-1.43%)
:arrow_down:

pkg/autoscaler/statserver/server.go
78.10% <0.00%> (+2.18%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


TextDocument archetype

Part of https://github.com/rerun-io/rerun/issues/2793

What

Rename datatypes.Label to datatypes.utf8
Rename components.Label to components.Text
Add new archetypes.TextDocument { body: components.Text }

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested demo.rerun.io (if applicable)

PR Build Summary
Docs preview
Examples preview
Recent benchmark results
Wasm size tracking

I'll handle the rebase on top of the new roundtrip stuff, force push incoming :warning:


Fixes #464: Kafka sink ignores neo4j.batch.timeout.msecs when neo4j.batch.parallelize = false

Fixes #464

Various fixes documentation

Mergin this as the Java CI is green


[RN 0.68] Compilation issue on iOS

Hi,
After migration to RN 0.68, I have a compilation issue:
AppDelegate.mm:35:2: use of undeclared identifier 'CrispSDK'

AppDelegate.m has been replaced with AppDelegate.mm
So I have added #import <Crisp/Crisp.h> and   [CrispSDK configureWithWebsiteID:...] AppDelegate.mm as done before in AppDelegate.m
Is there any extra step on RN 0.68 ?
Thanks !

fixed by replacing #import <Crisp/Crisp.h> with #import <Crisp/Crisp-Swift.h>


Update staking pool diversity link

Description

Current link for "View Staking Pool Diversity" leads to https://pools.invis.cloud/ which redirects back to https://clientdiversity.org/
Replaces link with https://www.rated.network/ which fulfills the same purpose

Thanks @wackerow!


travis: Automatically invalidate caches if new package versions exist

While working on #101 I discovered that because we cache .cabal, we'll get conflicts (and thus build failures) if there's a new version of a cabal package we use.
That's less than ideal (and we had to manually clear the cache to fix the build), but I believe there's a way out. Should examine the work done in https://github.com/hvr/multi-ghc-travis/blob/master/make_travis_yml.hs - it seems to check the install plan and compares it to the last known one. If there's a change, it clears the packages and asks cabal to reinstall. I think this will work, though it may need some testing... and depending on how often our used packages release new versions opportunities to test may be rare.

Also a thing to note is that the symptom of the problem may change a little bit. Now that _test/bootstrap only asks to cabal install the not-yet-installed packages, if an already-installed package gets a new version, we'll just silently not install it. And if the new version happens to break us, well we won't find out until we clear our cache.
This is actually the opposite situation as the one I found myself in a while ago. In that situation, we were broken unless we clear the cache. In our current situation, we may find that we are broken only if we clear the cache.
Nevertheless, both situations are undesirable. But can I stop to ask: What is the chance that we will break? In the current situation, if we clear the cache and _test/bootstrap asks cabal install to install the full list of our exercises' dependencies, would cabal install really pick a set of versions that would cause breakage? What would cause this to happen?
You see that now I need some help thinking about this since the nature of the issue has changed since the time when I filed it.

It believe it will not break on newer versions, but it will break on new dependencies.
A new dependency will not necessarily be compatible with all the versions of installed packages and will not install, so we live in cabal hell. We'll have to clear all the cache to allow it to build.
This is really undesirable, because we are joint-testing the repository and the history's cache. Failing will not tell us if there is really something wrong with the repository of if we just met an unfortunate install order.
From what I understand, this problem is intrinsic to installing packages globally.

Maybe we could try to avoid this problem allowing cabal to reinstall packages, but I don't know if it would work.
With this issue, we are trying to solve problems already addressed by newer versions of cabal sandboxes, and stack, which was designed specifically to allow reproducible builds.
If we really want to keep testing with global packages, maybe we should forget about caching it. It feels like we're trying really hard to use a tool for something it was not designed.

I see, you are right. If we add a new dependency we could run into problems.
This issue has changed a lot from when I originally filed it. When I filed it I had a clear solution plan in mind (https://github.com/hvr/multi-ghc-travis/blob/master/make_travis_yml.hs), but now that we changed how we bootstrap, the problem and thus the solution have changed.
Then, I currently don't understand the problem well enough to be able to take any action on this issue. If, for example, we can find a potential dependency that we might add that would break our build given our cache, then we'd be able to discuss what to do. With clear reproduction steps, only then can we test whether a solution has solved the problem.
I may spend some time trying to find such a dependency, but if I cannot find, I can't really consider this issue actionable, so I may be tempted to close it. Or at least unsubcribe.

Where might I start looking to look for potential candidates that could break though? Clearly I can't pick packages at random, but must be something principled

I'm stunned that it appear that with a single cabal installs it worked but with individual cabal installs we apparently fail on old-locale

I guess you met this problem when you tried to install packages individually with cabal install.

I may spend some time trying to find such a dependency, but if I cannot find, I can't really consider this issue actionable, so I may be tempted to close it. Or at least unsubcribe.

This issue is related to a design choice we made. I don't think we can do anything about it without making major changes, so I would mark it as wontfix and close it.
If we decide in the future to drop support for ghc-7.6.3, we will not need cabal install anymore and the problem will be automatically solved. Until then, if someone adds a new dependency and it breaks, I'll clear the cache manually and rerun the job.
We already have an overly-complex Travis, and it's probably less work to manually solve those problems than trying to write and debug an even more complex solution. Of course, that will be annoying for contributors that will have failing tests without understanding why.

I'm stunned that it appear that with a single cabal installs it worked but with individual cabal installs we apparently fail on old-locale
I guess you met this problem when you tried to install packages individually with cabal install.

Hmm, now that bootstrap will install all packages though, it's less clear how we will see the problem now, but now you give me an idea as to how to reproduce the problem, with old-locale as the hint - thanks for this reminder.
We are agreed that we'll close for now. If we run into problems in the future the experience gained can be described there and we'll be better able to come up with a solution when we have a clear problem


Engineering issues for May 17

Add your discussion items below.
@tlosbo
@mauricereeves
@Mr0grog
@mry-usds
@RickHawesUSDS
@ronaldheft-usds
@carlosfelix2
@joemeree

Something I worked on over the weekend was adding fluent assertions to the project in a branch to make unit tests easier to read and more...well..."fluent." I would like to give a quick demo of what that looks like and if there's interest I'll convert over the rest of the unit tests.

I can give an overview of the zero-downtime deployment work I've done here: https://github.com/CDCgov/prime-data-hub/pull/1064


How to use twig template, I tried to develop according to example, but it doesn't work

How to use twig template, I tried to develop according to example, but it doesn't work.
Looking forward to your reply, thanks.
Code Link

Hello @leolilac,
your partials/layout.twig file uses tabs, therefore the twigjs can't compile this template. Please reformat the template using spaces.
Try run the working example Twig with Webpack.

已收到，谢谢


[FEA] Add meta-data about dependencies to results

A proper analysis will eventually lead to devs asking what the cudf version was, what the RMM version was, etc.
Furthermore, if a benchmark run is broken by a recent PR, a dev may not realize that and think the benchmarking infra is broken when they see a missing point.
The results published should either incorporate additional meta-data or a separate text file that's associated by commithash, date, both, or something should be added.

@mike-wendt prototyped an implementation of my ideal solution described above, and it looks exactly how I was hoping it would:

If we can formalize Mike's solution and add it to our benchmark jobs/workflow, I'd consider this issue closed.

Assuming a patch or update of some kind is in place to ASV, all that's left to fully realize this would be:

update the rapids-pytest-benchmark plugin to tell asvdb to accept and set the requirements field. asvdb already knows how to handle these
have the nightly job get the commit hashes for the dependencies we want to include, and pass them to the rapids-pytest-benchmark plugin (the plugin already has a generic meta-data arg for this) to pass to asvdb.

For reference: https://github.com/mike-wendt/asv/pull/1

Closing this now that this PR has been merged and the tooltips are working.


Support other semantics nodes in Checkbox/Radio/SwitchListTile

Fixes #131619
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This fix will cause a lot of accessibility test failures, so I'm closing this.


Revert "Whitespace"

Reverts SymbiFlow/prjxray#1112
FYI @JakeMercer
This causes make format to take >10 minutes on an active tree.  Something about the filtering is broken and causes it to touch built files.

No worries, I'll take a look at it, might be better to whitelist patterns instead of blacklisting.  Or filtering based on what Git is tracking.


Integration Settings Scripts

These scripts will allow you to report and update integration settings in Defender for Cloud for multiple subscriptions.
get-integration-report.ps1 script will report on:
Defender for Servers Plan
Defender for Cloud Apps Integration
Defender for Endpoint Integration
Defender for Endpoint Unified Agent
Defender for Endpoint: Exclude Linux Servers Public Preview Flag
Sentinel Bi-Directional Alert Sync Settings
enable-integration-settings.ps1 will update:
Defender for Servers Plan
Defender for Cloud Apps Integration
Defender for Endpoint Integration
Defender for Endpoint Unified Agent
Defender for Endpoint: Exclude Linux Servers Public Preview Flag
Sentinel Bi-Directional Alert Sync Settings

Merging


❓ How can I know the exact timing of video recording has been started?

Question
Hi, thank you for this awesome library!
I'm developing an app that supports video recording with a timer and trying to migrate from react-native-camera.
My current implementation is like this:
const record = (duration) => {
  camera.startRecording();
  setTimeout(() => {
    camera.stopRecording();
  }, 5000);
}

In this way, the actual duration of a recorded video would fluctuate from 3 to 5 seconds.
To set a timer accurately, I need to start a timer when the actual recording happens, not when I call camera.startRecording().
I looked at the implementation bit, but couldn't find an easy way to know the timing. I was imagining like
startRecording({
  onRecordingStart: () => { /* start a timer here */ };
})

I would like to know if I'm doing something wrong or if there is a technical limitation on this.
I also found a similar issue: https://github.com/mrousavy/react-native-vision-camera/issues/742
The code mentioned in the issue gives me an impression that it's not supported yet: https://github.com/mrousavy/react-native-vision-camera/blob/main/example/src/views/CaptureButton.tsx#L119
Thank you!
What I tried
Use setTimeout after calling startRecording()
VisionCamera Version
2.13.0
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Hi!
Yeah, I am migrating VisionCamera to TurboModules/Fabric and have a few more options here. Right now I'm limited by RN's architecture, but once we're migrated we can await startRecording that should work for you then :)

Okay, thanks!
Maybe a dumb question, do you think it's easy to add another callback similar I mentioned in the description, not await?
startRecording({
  onRecordingStart: () => { /* start a timer here */ };
})

I'm wondering if I can folk repo and add this callback by myself as a workaround until architecture migration. Measuring accurate time is a core part of my app.

do you think it's easy to add another callback similar I mentioned in the description, not await?

On the native side callbacks and Promises are currently essentially the same thing. It is not supported to have two for one function, so I need to wait for TurboModules.
I think I'm gonna go with await rather than a callback, purely an API design decision.

As a really dirty workaround you can add a event to the <Camera> component (onRecordingStarted) that fires when a recording is started, that way you can time better :)

On the native side callbacks and Promises are currently essentially the same thing.
I see, that makes sense...

On the native side callbacks and Promises are currently essentially the same thing.

I see that makes sense.

As a really dirty workaround you can add an event to the  component (onRecordingStarted)

Probably I would go this way. Thank you so much! I'll close this issue.

For future readers, here is a repository with onRecordingStart prop. It's based on vision camera 2.13.0.
https://github.com/Sidebook/react-native-vision-camera/tree/v2.13.0-start-recording-callback

Started working on something here: https://github.com/mrousavy/react-native-vision-camera/pull/2194
as of now this doesn't really work, but we'll see what we can do


support graphs for daily active

[ ] Blue color please
[ ] Support N parameter too

I will make a PR for this 👍


Consistency improvements

Updated headings and moved Technologies section to end
Please use this template to ensure easier processing of your pull request
Category

[x] Content fix
[ ] New article

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

Contents of the Pull Request
Updated position of technology section and renamed Management & Giovernance to Governance, Risk, Compliance and Security
Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to master branch. Released documents are in live branch.
(DELETE THIS PARAGRAPH AFTER READING)

Docs Build status updates of commit 45362fe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Community/microsoft365-maturity-model--customization-and-development.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


visualize golden test failures clearly in our Manager

Question: how to know which golden file corresponds to which test log failure?
[TODO]

Question: how to show the images?
firstly, simply make it a pseudo-snapshot?
can refine later if needed.
[TODO]

wait, another approach: no need to send as log snapshot... just tell Manager what is the path!

basic idea is ok, still need improvement


Ensure --regions CLI option can be used twice

As raised by @adrivinca. This was previously-untested behaviour that the "water-ix" CLI command relied on; changes in #137 caused it to no longer work.
The PR restores the original behaviour by refining the code passed to exec_cb(), and adds a test to confirm.
How to review

Read message_ix_models/util/click.py in the diff.
Note the CI checks all pass, especially the newly-added .tests.util.test_click.test_regions().

PR checklist

[x] Continuous integration checks all ✅
[x] Add or expand tests; coverage checks both ✅
~Add, expand, or update documentation.~ N/A
~Update doc/whatsnew.~

thanks a lot. all looks fine to me. Also the test.


Camera still open during /dispatch roundtrip

Options:
a) Send /dispatch request. Wait for response. Then, show success check mark. (current option)
b) Send /dispatch request. Show success check mark. Incorrect! we have no proof anything was delivered at all.
c) Send /dispatch request. Show a spinning screen. Wait for response. Then, show success check mark.
Implement (c)

Added 1 intermediate "dispatching Scene".


 You have written the stupidest tutorial of all I have read, for a month now I have not been able to simply connect the database to the site. WHAT I do not do. NOTHING WORKS. I ask here - some nonsense is written in response. My question is, why is there no simple tutorial with steps so that all this can be repeated ??? Right now I am creating a ./creata_ctl create model ../../ - and ... and nothing. Everything just hangs at this stage and that's it. And I do not understand, am I missing something? Should the program hang like this? What should I get in the end ??? What a nightmare, just horror

Ubuntu 24
Drogon 1.9.6
my model.json file:
{
"rdbms": "postgresql",
"host": "<IP_ADDRESS>",
"port": 5432,
"dbname": "losdevelop",
"user": "losdevelop",
"passwd": "kaizer1los",
"tables": ["envidata"],
"relationships": {
"enabled": false,
"items": []
}
}

Is this the kind of language you always use when asking for help? I don't have anything to say about your question right now. Good luck.

Well, I ask for good advice. From the people who created this + give a micro hint on how to make this product if not better, then more adequate to the declared characteristics.

Or is this a proposal to kneel? Like, we did something, it doesn't work.... ... ... kneel and we, maybe, so be it, will condescend to answer you. Great, but then warn in advance that you have such communication established

Go see a docter plz

What a nightmare. Your parents have given birth to the stupidest thing ever.

 He confidently holds the lead


[v3.0] UI display error

In version 3.0, Using dark theme after turning off the mica effect can cause UI display errors.

I am not currently clear about the root cause of the problem. This issue may be fixed in future versions.

Fixed in v3.5.


[HUDI-678] Make config package spark free

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
Make hudi-client config package spark free.
Brief change log

Introduce AbstractConfig and subclass, currently only support SPARK.
Introduce ConfigHelpers to create AbstractConfig.
Introduce HoodieEngineType enum class, would specify to SPARK, FLINK, NATIVE.
Introduce HoodieEngineConfig class to specify HoodieEngine, now only supports SPARK.

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #1418 into master will decrease coverage by 66.84%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #1418       +/-   ##
============================================
- Coverage     67.47%   0.63%   -66.85%
+ Complexity      230       2      -228
============================================
  Files           338     296       -42
  Lines         16365   14435     -1930
  Branches       1671    1472      -199
============================================
- Hits          11043      92    -10951
- Misses         4583   14340     +9757
+ Partials        739       3      -736

Impacted Files
Coverage Δ
Complexity Δ

...a/org/apache/hudi/client/config/ConfigHelpers.java
0% <0%> (ø)
0 <0> (?)

...n/java/org/apache/hudi/index/hbase/HBaseIndex.java
0% <0%> (-84.22%)
0 <0> (ø)

...java/org/apache/hudi/client/HoodieWriteClient.java
0% <0%> (-69.78%)
0 <0> (ø)

.../org/apache/hudi/client/config/AbstractConfig.java
0% <0%> (ø)
0 <0> (?)

.../apache/hudi/client/AbstractHoodieWriteClient.java
0% <0%> (-70.9%)
0 <0> (ø)

.../org/apache/hudi/index/bloom/HoodieBloomIndex.java
0% <0%> (-94.74%)
0 <0> (ø)

...ava/org/apache/hudi/client/config/SparkConfig.java
0% <0%> (ø)
0 <0> (?)

...org/apache/hudi/common/model/HoodieEngineType.java
0% <0%> (ø)
0 <0> (?)

...java/org/apache/hudi/config/HoodieWriteConfig.java
0% <0%> (-83.85%)
0 <0> (ø)

...ava/org/apache/hudi/config/HoodieMemoryConfig.java
0% <0%> (-76%)
0 <0> (ø)

... and 307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b7e9e...b43f27d. Read the comment docs.

@vinothchandar Updated the PR to address your comments.

@vinothchandar Any concerns here?

@leesf sorry behind on reviews.. Will get stuff ready for you by your day time

@leesf sorry behind on reviews.. Will get stuff ready for you by your day time

No worries..

@vinothchandar Updated the PR to address your comments, PTAL, thanks.


Links to build scans not fetched and reported to summary or PR comments

Build scans is published but setup gradle does not retreive the url.
Versions used:

Gradle 8.8
gradle/actions/setup-gradle@v3
com.gradle:develocity-gradle-plugin:3.17.5
Develocity 2024.1.5

Thanks for the report.
We have test coverage for this combination of versions, so there must be something about your project that is causing this to fail.
The Job Summary functionality works via Gradle init scripts, which are automatically injected into Gradle User Home. These init-scripts write a results file to $RUNNER_TEMP/.build-results.
Can you please check the following:

Do you see "gradle action failed to write build-results file" in your Gradle output?
Add a step following the Gradle invocation to list the results of the $RUNNER_TEMP/.build-results directory?
In the same step, cat all of the .json files in .build-results to check contents. These JSON files should contain the Build Scan link but I assume in your case they do not.

The added step would look something like this (untested):
    - name: Print build results
      working-directory: ${{ env.RUNNER_TEMP }}
      shell: bash
      run: |
        echo "RUNNER_TEMP = $RUNNER_TEMP"
        ls -la $RUNNER_TEMP
        ls -la $RUNNER_TEMP/.build-results
        find $RUNNER_TEMP/.build-results -name *.json -type f -exec cat {} \;
        echo ""

Once I have a better feel for where this might be failing, I can publish a release with some additional logging to help dig deeper.

@warting Have you been able to work out what might be causing this? Do you have any custom init-scripts written to ~/.gradle/init.d?
Without further details of your issue it's difficult to see how it can be fixed.

@warting I'm going to close this issue as non-reproducible. If you have more details that might help us track down the underlying problem, please comment here and I'll be happy to reopen.