Various minor changes to speed up tests.

See commit messages for explanations.

buildbot, test on oracle.

Hmm. Will have more of a think on the timeouts. I didn't have these failures locally.
The changes in the introspection-related tests should be fine though.

buildbot, test on oracle.

buildbot, test on oracle.

Thanks :rocket: On Oracle:

test
before
after

test_include_materialized_views
148.0s
12.717s

test_include_views
150.0s
9.971s

That's exactly what I was hoping for!

That's great. however not the final word. I already got a failing test on a PR which could be related (cache.tests.PyLibMCCacheTests.test_touch, https://djangoci.com/job/pull-requests-bionic/database=postgis,label=bionic-pr,python=python3.6/8623/).

@claudep Indeed, but these failures did crop up on occasion before. I don't have a rate of how often, but these things are hard to measure reliably anyway.
I thought the saving made it at least worth trying, on the basis that we can review over the coming days/weeks and tweak or revert if we perceive it to be worse.
So thank you for the first report! 😄
In case you missed it, I discussed this above: https://github.com/django/django/pull/13496#discussion_r506282061

I've just seen the same failure of test_touch on my PR.

Thanks for the heads-up @timgraham.
So here is the relevant bit of the test:
        # cache.touch() updates the timeout.
        cache.set('expire1', 'very quickly', timeout=1)
        self.assertIs(cache.touch('expire1', timeout=2), True)
        time.sleep(1.0)
        self.assertIs(cache.has_key('expire1'), True)
        time.sleep(1.5)
        self.assertIs(cache.has_key('expire1'), False)

So the flow is:

Set with a short timeout.
Update to a longer timeout while verifying the key is still set.
Wait long enough for the original timeout to have expired.
Then check the key is still set.
Wait long enough for the longer timeout to expire.
Then check the key is not set.

We're failing at step 4. For that to happen we must be losing a whole second somewhere… ☹
I note that there is some guidance on troubleshooting timeouts. I wonder if anything crops up in the memcached stats related to maximum connections @felixxm?

Hmm. Just seen a lot more touch failures.
It is rather strange that we would need to wait for multiple seconds. Are all parallel test runs executed on the same memcached instance on CI? I presume that there is some sort of key prefixing if so, otherwise this is bound to fail. Or are too many parallel runs causing too many connections or too much load on memcached per the link in my previous comment.
Perhaps it is just easier to revert 177a49e79c882603da64d45995f5fd60dce8c852, but it feels like there is some underlying problem…

I presume that there is some sort of key prefixing if so, otherwise this is bound to fail.

Yes, based on a Python version, database and build name, so it's properly isolated.

Perhaps it is just easier to revert 177a49e, but it feels like there is some underlying problem…

Agreed let's revert it (#13565), there is no doubt that it caused more frequent failures. We need to investigate this more closely :detective:


Spark: Update Hadoop/AWS Sdk version + set all to Spark3

TL;DR

Updates Hadoop/AWS version to support IAM role fetch via https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html
Default flytekit[all] to Spark 3.x

Type

[ ] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

Can you change this to be a PR into the annotations branch?
Also, on that branch, this information is currently in two places - the lazy loader file, and also the main setup.py file. It'll be merged back shortly but could you just change it in both places for now?

Created https://github.com/lyft/flytekit/pull/334 for annotations branch

Can you change this to be a PR into the annotations branch?
Also, on that branch, this information is currently in two places - the lazy loader file, and also the main setup.py file. It'll be merged back shortly but could you just change it in both places for now?

Created https://github.com/lyft/flytekit/pull/334 for annotations branch


Clarify Docstring Practices

Problem
Due to some miscommunication between Slack, GitHub, and code commits, I am going to solidify the documentation about how to document functions in this codebase.
Solution
Going to add best practices we follow to contributing.md and possibly going to make some additional documentation files if the need arises.
@Wikunia aside from specifying that we will completely document exported functions and minimally document internal functions, is there anything else you can think of to add or clarify?

Just a small note: Not only functions but also types.
You might want to mention the way to link between functions there as well.

When you say types what do you mean by that? Could you give me an example of what you are thinking?
What do you mean by "the way to link between functions"? Confused by what you are saying there.

type = (mutable) struct :wink:
Maybe give an example of
[`javis`](@ref)

This is going to be one of the final issues I am going to check before we release because I want to run my formatter on everything and do a thorough comparison to BlueStyle to make sure we are in good shape. :+1:


Make further improvements to Add Org modal

Overview
We've made great progress on the Add Org modal found at http://localhost:3000/join-index thanks to Max and Bruce. A few more improvements are wanted:
Action Items

[ ] Allow URLs to be entered by user with or without http(s):// prefix
[x] Store the Parent Org in state so the dropdown remains populated when user selects "Back" on Step Two
[x] Display selected Parent Org name to user, not its ID
[x] (If possible) indicate to user what needs to be completed before the "Next" button on Step One will become enabled

Resources/Instructions
Figma design link: https://www.figma.com/file/EFoSuj1b9G4aZ7bN8OX8tf/CivicTechIndex---Master-Design-File?node-id=4495%3A18593

Re-opening due to addressing first checklist item on front end as well as possibly back end (issue has been opened against back end as well to relax their validation for urls in /api/organizations endpoint)


EncryptedPayload elements in the body

I am using the following within a server used for MDES Pre-Digitization
cb := field_level_encryption.NewFieldLevelEncryptionConfigBuilder()
flconfig, configError := cb.WithDecryptionKey(decryptionKey).
WithEncryptionCertificate(encryptionCertificate).
WithEncryptionPath("encryptedPayload", "encryptedPayload").
WithDecryptionPath("fundingAccountInfo.encryptedPayload", "fundingAccountInfo.encryptedPayload").
WithEncryptedValueFieldName("encryptedData").
WithEncryptedKeyFieldName("encryptedKey").
WithEncryptionKeyFingerprint(remotecertfingerprint).
WithEncryptionKeyFingerprintFieldName("publicKeyFingerprint").
WithIvFieldName("iv").
WithFieldValueEncoding(field_level_encryption.HEX).
WithOaepPaddingDigestAlgorithm(reqCryptoInfo.ReqAlgorithm).
WithOaepPaddingDigestAlgorithmFieldName("oaepHashingAlgorithm").
//WithOaepPaddingDigestAlgorithmFieldName("oaepPaddingDigestAlgorithm").
Build()
We are currently getting this error
2024-09-03T03:02:21,956 [es5stl150158902072791538] [] [Camel (camel-1) thread #1428 - Threads] ERROR c.m.m.i.c.c.IssuerServiceLoggerUtils - Error for provision request id 614978362
com.mastercard.mdes.servicefacade.issuer.decorator.service.exception.IssuerWebMalformedResponseMdesException: The issuer service responded successfully with a malformed entity
3 * Client Inbound Response Detail
3 * STATUS 200
3 > Connection: keep-alive
3 > Content-Length: 1778
3 > Content-Type: text/plain; charset=utf-8
3 > correlation-id: 23b9fa91469ca129fad39bc01f7a6bb9
3 > Date: Tue, 03 Sep 2024 08:02:21 GMT
{
"activationMethods" : [ {
"type" : "TEXT_TO_CARDHOLDER_NUMBER",
"value" : "xxx-xxx-8183"
} ],
"auxTcis" : [ "Orlando" ],
"avsResponse" : "AVS_NOT_SUPPORTED",
"cvcResponse" : "NOT_PROCESSED",
"decision" : "REQUIRE_ADDITIONAL_AUTHENTICATION",
"encryptedPayload" : {
"encryptedData" : "5b55afb89ce8cd3e89ac3e7ed497ecd60c7edada7f6a8c113a22b708e71b846fa9ab5b3a00547d78c744031b93f7721f4235f92f412fb6ccfc6f27a0834bd9309d5f73a6c2057bddbd48d0e98b73781905311031b0d0a3bb1804e00117b441404a1e9ea269a5d028909e6c575482d98c2807ce3596ea7fe622d920b5669d37e8a63ce653a77dcbc8bf1d97797ceb4c19b056d37620e57eca87734b75f6b2eb3b68df7ccc34005790ccccbef07f3d461af09a06046086e8d6fa71d33b00b91321a38900497ebda9d983255c08ee3607c4c257e07867f4a183543d63141b199f91d94093dad38e4361b349e85e0ea4965d5ce2ea0d6320b527c3cbe95c0b6a8fe423f30125aa6fe1c2cad5424decfc87e90bc9d183a29e6880760c4bc90ea4971e26f22b0f1f5b04a33cf22e86cabdbff3d382e6c0436a8066682389918b2eeb41",
"encryptedKey" : "9cff4554525863a6699fd76d078b1ff79b7c12db5ccdc9c79cdb30adb9ad4792580a6f91268ba65bc8591a7d73346cde2f1cb8ce65a6c44a97a6ce7b2b658929c93615e24638cf5210465150326bfb7bd6db9e1d48945875392f44868a73f6a897800ef1f82c666fd7cc70c881cddf66cb5ad7dd09fc19cc408f79737d0b2f311bfff909514bad68599394e0958b502852fb4c525707061c286a2f5c2748a598a5485a7b7c0b5ea73b3435d294de334d5b3bb4242a3a960ad9adc4de33d9319d58204afe513beed60f1858b7f380cbd1bd1c5b5d32e3e855b9e43f695ce4803a4b7e16c4e603bd2aa972e3387fe7603282857c66b45039bb2875a44f50c3498d",
"iv" : "c50ac2a8b7e350eb1a64ea92c9a936e7",
"oaepHashingAlgorithm" : "SHA256",
"publicKeyFingerprint" : "ca0846ce7f4f2498f2020cd1dc834e2451cd67a3554866b3c4c423620450ef08"
},
"issuerProductConfigId" : "UP1234",
"panSequenceNumber" : "001",
"responseId" : "50a9de53-593a-483c-8f79-442419ec8bbb",
"services" : [ "DIGITIZATION" ],
"tcis" : [ "Madrid" ],
"tokenRequestorId" : "50120834693"
}
The suggestion was to change replace oaepPaddingDigestAlgorithm oaepHashingAlgorithm
WithOaepPaddingDigestAlgorithmFieldName("oaepHashingAlgorithm").
//WithOaepPaddingDigestAlgorithmFieldName("oaepPaddingDigestAlgorithm").
During my testing this never really was an issue, but I complied. My next real concern is that the test crew will ask "encryptedData"   "encryptedKey" "iv" "oaepHashingAlgorithm" "publicKeyFingerprint" to be populated in the clear JSON.  So far, I can only get these values to appear within encryptedPayload during encryption.
Is there a way to get these values into the clear JSON prior to encryption?
Should this even be an issue since during my testing I had no issues with encryption or decryption of requests and response.  BUT we’re using different code and possibly criteria.

This is not currently supported. Do re open if you have more questions.


driver: MultiCqe support for Driver Drop

Handles LifeCycle::CompletionList in driver Drop logic
During the first pass over all lifecycles, identifies if CompletionLists are finished or not.

If they are, it changes the Lifecycle to Completed with null data.
If they are not, adds them to the cancel list, and converts to Ignored

This means that after this pass, we will never observe CompletionList in the lifecycles. This means the existing termination logic is ok unchanged. The ignored entry will stay until removed from the Lifecycle slab by the call to complete.
Fixes a gap left by #158 and unblocks #123

Just realised there is nothing stopping a op polling after the runtime drops

I've another commit for this, in progress

@FrankReh : I've made an update optimizing the drop logic

Now We don't have to allocate vec, we just mark the Op as ignored, and submit completions for those that have been ignored. This is ok, as no poll will occur during Drop, and the slab will be gone once its finished drop.

During the await loop, remove the completions from the slab, so we don't keep iterating over them. There is some odd structure there to avoid double borrows

I do wonder about both this and the original though. How do we know we've awaited all the AsyncCancel's we've pushed? I don't think either the oringal or this handle that properly

How do we know we've awaited all the AsyncCancel's we've pushed?

It doesn't need to wait for the AsyncCancel's to be done. It uses a loop at the bottom to wait for the original's to move to complete I believe.  I'll double check that now.

Odd, this page. My approval shouldn't be counted if another change comes in.

We'll there was a bug in the original - things wouldn't move to complete. Submitted may have moved to waiting, and would never be polled. That is fixed here

@FrankReh I'm happy this and the original awaited all the ops in the slab. I just don't know it its safe to drop the rings if there are in-fligh AsyncCancels, which we don't account for

@frank, I'm going to have 1 more edit. I think we can do the wait logic in a single pass of the slab

@FrankReh Cancel is called exactly once for each outstanding op. The logic is pretty much the same as the orignal, only without a vec

Iterate over the slab, and change each lifecycle to either completed or ignored
iterate again (which may be more expensive than iterating over the vec, but doesn't allocate), and for each item marked ignore, issue a cancel exactty once
Iterate a final time, waiting for the slab to be empty, which will occur once all the completions come in.

I just don't know it its safe to drop the rings if there are in-fligh AsyncCancels, which we don't account for

I've never read a warning in the liburing stuff about having to wait for quiescence before closing a uring fd. I believe we should proceed like it is safe. If you want, I or one of us can pose the question to the liburing author as an issue on their git repo but I really think the answer is the kernel protects itself from the uring fd being closed and doesn't need the user land to wait for things to be cleaned up.
So to be clear, I think it's a good idea we make the drop wait to see the active operations completed but we don't need to wait to see our async cancels themselves being completed. It's only against the kernel modifying userland data that we are trying to protect ourselves but async cancels don't use userland buffers.

@FrankReh The number of defunct processes I've had whilst doing dev this week say otherwise

@FrankReh Cancel is called exactly once for each outstanding op. The logic is pretty much the same as the orignal, only without a vec

Iterate over the slab, and change each lifecycle to either completed or ignored
iterate again (which may be more expensive than iterating over the vec, but doesn't allocate), and for each item marked ignore, issue a cancel exactty once for each item marked Ignored
Iterate a final time, waiting for the slab to be empty, which will occur once all the completions come in.

Fair enough. Let me look through it again.

Although, maybe AsyncCanels are ok. I don't know. I've been ungracefully exiting with send_zc buffers in flight

@ollie-etl I don't think you should be trying to get this mergable today. I'm assuming you want it in the release but if a release goes out this weekend like Noah wondered about, I think we should have a follow up release very soon after that with the PRs that have been consuming so much of our time over the last two weeks. I wouldn't even try to get any of my work into the follow on. It would be purely to catch up to with the current PRs that were ready.

@FrankReh I think I've addressed the quadratic behaviour

Looking at the wrong section

@ollie-etl Yes, easy to look in the wrong section. So for @Noah-Kennedy 's benefit, we no longer think this fixes his earlier version. This just makes it possible to handle CompletionList entries too. But I probably like the last loop here better, even without counting the handling of CompletionList being included here.

@FrankReh Comments addressed

@ollie-etl please run cargo fmt, then I will merge.


some campaign tiles in finder are linked to <IP_ADDRESS>

saw it previously with https://github.com/DoSomething/ServerConfig/issues/72
then just saw it again today by filtering by Sex and Relationships and 2 of the first 8 campaigns had http://<IP_ADDRESS> instead of https://www.
campaigns were http://<IP_ADDRESS>/campaigns/support-survivors and http://<IP_ADDRESS>/campaigns/project-shutdown
cc: @sergii-tkachenko

Found this again

I've made a change in Jenkins, hopefully it'll fix this. We need to keep an eye on this @mikefantini.

Manually fixed current content.

@sergii-tkachenko @mikefantini going to close this out, feel free to re-open if we are still seeing this


added code 365 problem extension

Description
This pull request introduces a new Chrome extension that displays the Code 360 Problem of the Day. The extension includes a welcome page with a typewriter effect and a subsequent page showing the problem description with a link to the Code 360 website.
Fixes:  #865

Type of change

[ X] New feature (non-breaking change which adds functionality)

Checklist:

[X ] I have made this from my own
[ X] I have taken help from some online resourses
[ X] My code follows the style guidelines of this project
[ X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[X ] I have made corresponding changes to the documentation
[ X] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

I am contributing upon Gssoc24

@Sulagna-Dutta-Roy I have Added code 360 extension please check it.


[23.05] luci-app-adblock-fast: update to sync with principal package

Maintainer: me
Compile tested: x86_64, Dell EMC Edge620, OpenWrt 23.05.5
Run tested: x86_64, Dell EMC Edge620, OpenWrt 23.05.5
Depends on https://github.com/openwrt/packages/pull/25238
Signed-off-by: Stan Grishin<EMAIL_ADDRESS>(cherry picked from commit ea170f1f6abb4578823617f2e0e9ffee6b7c68f3)

Closing this, I'll have to do a cherry-pick with multiple commits to catch up to the snapshots version.


Link for pretrained models (including glove_50_300_2.txt) down

Hi,
the Google drive link for the pretrained models file e2e-coref.tgz is down (https://drive.google.com/file/d/1fkifqZzdzsOEo0DXMzCFjiNXqsKG_cHi/). This is also the only source of glove_50_300_2.txt, which is required for the reproduction of all results afaik.
@kentonl, could you update the Google drive link? Or if anyone else has the file glove_50_300_2.txt, could you share it? Thank you very much! Without it, this code is non-usable.

According to many forks, the file used to be located at http://lsz-gpu-01.cs.washington.edu/resources/glove_50_300_2.txt, but that source is down as well sadly.

Pinging some people who made successful PRs to this repo and might have glove_50_300_2.txt still stored locally: @heyitsmine @SaltyHash123 @nelson-liu
If you have the file glove_50_300_2.txt, I would appreciate it if you could share it with me - thank you very much :)

Hey there,
i've checked it but unfortunately i don't have anything related to this project anymore. Maybe you should contact the author (Kenton Lee) directly.


filesystem.getDirectoryItems

filesystem.lua: Added getDirectoryItems, functionally similar to love.filesystem.getDirectoryItems
Unsure if you are taking pull requests, but thought I should return the favor by filling in  some missing functionality. This framework is ace, it's cuts all the LOVE garbage while giving more freedom over the rendering.
Here is some more filesystem functionality if you want it: https://pastebin.com/ZhRMgHWC
Use, don't use, alter or cherry pick however you wish.

Scheduled for today.

Thanks!

@revolucas I've also included your other contributions. Let me know if there's anything else I can do.


Release improvements

Instructions on how to release, script to generate the changes to HISTORY.md, and pre-commit to check usage docs links in docstrings are correct.

please review.


Level system optimized

The old level system is not optimized cause for this systems we have two options:

using switch/case (for optimize speed if we can't use shortest way)
using shortest way

for this system i think better option is using shortest way cause we lose a lot of lines of codes.
in this system (new one) i created a array which is have all levels XP so we can use just one [ if ] instead a lot of [ if ] and just in 2 lines of code.
Hope you enjoy it :) Happy Nowruz

also we can decrease lines by moving line 247 to 249 like if(!inNaN( HERE )) but it's your choice

also we can decrease lines by moving line 247 to 249 like if( levelsXP.includes(messagefetch) ) but it's your choice

benazam dash shayan dmt garm ye test azash migiram badan merge mikonam


Remove then/catch guards

The then/catch guards on transactions and patches seemed like a good idea at the time, but I discovered that it prevents returning a patch/transaction in a promise chain.

Fixed in latest (yet unreleased) version


kube3d: 3.4.0 -> 4.0.0

Motivation for this change
Bump kube3d/k3d to 4.0.0
Since this is a major version bump and still in-progress I've created this as a draft PR to try things out as it's being developed.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS (x86_64)
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

As mention here: https://github.com/NixOS/nixpkgs/pull/109253#issuecomment-763478305
Maybe we can make the k3sVersion easier to override? something like
{ lib, buildGoModule, fetchFromGitHub, installShellFiles
,  k3sVersion ? "1.19.4-k3s1" }:

As mention here: https://github.com/NixOS/nixpkgs/pull/109253#issuecomment-763478305
Maybe we can make the k3sVersion easier to override? something like
{ lib, buildGoModule, fetchFromGitHub, installShellFiles
,  k3sVersion ? "1.19.4-k3s1" }:

Yeah I'm open to it.
https://github.com/rancher/k3d/blob/main/version/version.go#L37-L38
I've been thinking for a while now I don't think it actually does anything :thinking:
k3d version grabs it as is:
https://github.com/rancher/k3d/blob/608f24a6e3d43e596416db046cb24df20da65405/cmd/root.go#L176-L179
But the get version function fetches the latest version anyway if the arg is set to true
https://github.com/rancher/k3d/blob/main/version/version.go#L63-L74
These lines set the latest argument to false but they seem to be lines specifically designed to let you set an exact image so you'd think you'd be setting the k3s version yourself :thinking: :thinking: :thinking: :thinking: :thinking:
https://github.com/rancher/k3d/blob/7b8506b1d90d6cf7c9337a71b1a0c7a1a216834f/cmd/cluster/clusterCreate.go#L185
https://github.com/rancher/k3d/blob/5092a90d56fb2fa1df3c42dc49aa7977d4968fab/cmd/node/nodeCreate.go#L69
The default "simple" config seems to use true
https://github.com/rancher/k3d/blob/683a92792eb30ab174e806baffcf0bc3364c4f80/pkg/config/transform.go#L46-L56

Yeah I'm open to it.
https://github.com/rancher/k3d/blob/main/version/version.go#L37-L38
I've been thinking for a while now I don't think it actually does anything :thinking:
k3d version grabs it as is:
https://github.com/rancher/k3d/blob/608f24a6e3d43e596416db046cb24df20da65405/cmd/root.go#L176-L179
But the get version function fetches the latest version anyway if the arg is set to true
https://github.com/rancher/k3d/blob/main/version/version.go#L63-L74
These lines set the latest argument to false but they seem to be lines specifically designed to let you set an exact image so you'd think you'd be setting the k3s version yourself :thinking: :thinking: :thinking: :thinking: :thinking:
https://github.com/rancher/k3d/blob/7b8506b1d90d6cf7c9337a71b1a0c7a1a216834f/cmd/cluster/clusterCreate.go#L185
https://github.com/rancher/k3d/blob/5092a90d56fb2fa1df3c42dc49aa7977d4968fab/cmd/node/nodeCreate.go#L69
The default "simple" config seems to use true
https://github.com/rancher/k3d/blob/683a92792eb30ab174e806baffcf0bc3364c4f80/pkg/config/transform.go#L46-L56

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

Result of nixpkgs-review pr 106176 run on x86_64-linux 1

1 package built:

kube3d

I feel like k3d should just use latest less a flag or envvar is set to a specific version. Or if a full docker image is specified by a flag or envvar use that instead.

But you can already specify the image version in the CLI, isn't it? With the --image argument. IMO, makes sense to use the latest version, but I think it is better to stick to the same version used upstream. Envvars would be nice, but not supported by k3d. But they added support for a config file, you can use that to always use the latest version
Other than that, 4.0.0 was released! Let's merge this

I feel like k3d should just use latest less a flag or envvar is set to a specific version. Or if a full docker image is specified by a flag or envvar use that instead.

But you can already specify the image version in the CLI, isn't it? With the --image argument. IMO, makes sense to use the latest version, but I think it is better to stick to the same version used upstream. Envvars would be nice, but not supported by k3d. But they added support for a config file, you can use that to always use the latest version
Other than that, 4.0.0 was released! Let's merge this

/marvin opt-in
@jlesquembre can you post / status needs_merger (without the space)? The PR creator can't post it

/marvin opt-in
@jlesquembre can you post / status needs_merger (without the space)? The PR creator can't post it

/status needs_merger

/status needs_merger


Fix build-system to better work with vcpkg

Copy cmake's config files to a zycore subfolder under lib/cmake makes no sense and will harm the integration with vcpkg.
When building dynamic libs under Windows, .dll file won't be copied to install path.

And please grant a tag for this commit, I'm porting this repo to vcpkg 😸

Not sure about this one.
In Zydis it's done the same way as part of a previous fix: https://github.com/zyantific/zydis/commit/8080ae55edf2e248f525ed2c8fea35cf3521d5cd.
I sadly don't know which way is correct. We have to make sure "regular" installation does not break and we definitely want to make sure it's consistent in both modules.

@Tachi107 you contributed a lot of CMake related changes in the past. What do you think? 🙂

At least on Debian and Arch, having a sub-directory per library appears to be the common case:
Debian
$ ls -la /usr/lib/aarch64-linux-gnu/cmake
total 164
drwxr-xr-x   8 root root   4096 Oct 12 15:46 .
drwxr-xr-x 139 root root 131072 Oct 12 15:46 ..
drwxr-xr-x   2 root root   4096 Sep 20 11:58 Boost-1.74.0
-rw-r--r--   1 root root   3434 Aug 28 11:13 BoostDetectToolset-1.74.0.cmake
drwxr-xr-x   2 root root   4096 Sep 20 11:58 boost_headers-1.74.0
drwxr-xr-x   2 root root   4096 Sep 27 12:19 expat-2.4.9
drwxr-xr-x   2 root root   4096 Sep 20 11:58 xsimd
drwxr-xr-x   2 root root   4096 Oct 12 15:46 zycore
drwxr-xr-x   2 root root   4096 Oct 12 15:46 zydis

Arch
# ls -lha /usr/lib/cmake
total 256K
drwxr-xr-x 1 root root 4.0K Oct 12 13:56 .
drwxr-xr-x 1 root root  20K Oct 12 13:56 ..
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 Boost-1.80.0
-rw-r--r-- 1 root root 3.6K Sep 19 22:28 BoostDetectToolset-1.80.0.cmake
drwxr-xr-x 1 root root 4.0K Oct 12 13:52 DBus1
drwxr-xr-x 2 root root 4.0K Sep  4 00:04 Gpgmepp
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_atomic-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_chrono-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_container-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_context-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_contract-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_coroutine-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_date_time-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_exception-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_fiber-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_filesystem-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_graph-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_graph_parallel-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_headers-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_iostreams-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_json-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_locale-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_log-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_log_setup-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_math_c99-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_math_c99f-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_math_c99l-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_math_tr1-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_math_tr1f-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_math_tr1l-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_mpi-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_mpi_python-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_nowide-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_numpy-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_prg_exec_monitor-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_program_options-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_python-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_random-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_regex-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_serialization-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_stacktrace_addr2line-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_stacktrace_basic-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_stacktrace_noop-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_system-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_test_exec_monitor-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_thread-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_timer-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_type_erasure-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_unit_test_framework-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_wave-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:55 boost_wserialization-1.80.0
drwxr-xr-x 2 root root 4.0K Oct 12 13:56 expat-2.4.9
drwxr-xr-x 2 root root 4.0K Sep  4 00:04 json-c
drwxr-xr-x 2 root root 4.0K Sep  4 00:04 libevent
drwxr-xr-x 2 root root 4.0K Sep  4 00:04 libxml2
drwxr-xr-x 2 root root 4.0K Oct 12 13:56 xsimd
drwxr-xr-x 2 root root 4.0K Sep  4 00:04 zstd

Copy cmake's config files to a zycore subfolder under lib/cmake makes no sense and will harm the integration with vcpkg.

From CMake's documentation, <prefix>/(lib/<arch>|lib*|share)/cmake/<name>*/ is also always checked. Why does it create issues with vcpkg?

Copy cmake's config files to a zycore subfolder under lib/cmake makes no sense and will harm the integration with vcpkg.

I issued this because I'm currently porting zycore to vcpkg and when integrating vcpkg with CMake, find_package won't search for config file in subfolders under [vcpkg_root]/installed/share/zycore/*, but there is a way to fix this in vcpkg's config file, I'll do it that way.

When building dynamic libs under Windows, .dll file won't be copied to install path.

However this should be fixed. If you build and install this library statically on Windows, you will find .dll file won't be installed, because according to CMake's document, .dll files belong to the RUNTIME artifacts.

However this should be fixed. If you build and install this library statically on Windows, you will find .dll file won't be installed, because according to CMake's document, .dll files belong to the RUNTIME artifacts

Sure. But won't removing the LIBRARY line cause issues when installing shared libraries?

It won't, tested on both Linux and Windows.

I can confirm that it does not break anything on CMake 3.23 to do it like this, but I'd still leave the LIBRARY line in there. We've had issues with this before, see:
https://github.com/zyantific/zycore-c/issues/46
https://github.com/zyantific/zycore-c/pull/47
Quoting @Tachi107 from this post:

Leaving this for future reference: in CMake 3.14, these various  DESTINATION  fields are implied by default, so they can be removed to make the code a bit cleaner :)

In other words: removing this is fine on CMake >= 3.14, but will probably break on older versions. Our minimum supported CMake version is currently 3.9.  Let's keep both LIBRARY and RUNTIME if that works.

nd let's do the same changes for the zydis module as well.

Zydis already has this line because it also install binaries. I just didn't realize that CMake had the glorious idea of adding a platform specific exception for Windows to put .dlls into the executable directory, which is why we didn't add it in zycore.

#cmake

Added

Of course. My port of Zycore is still not accepted by vcpkg's maintainers, so a few days waiting to the new release of Zydis won't harm anything 😄
By the way, Zydis & Zycore are amazing, thanks for your great work 👍

https://github.com/zyantific/zycore-c/pull/56#issuecomment-1276685744
This comment expressed all my concerns perfectly :)
Should an ARCHIVE section also be added? CMake's documentation says that static libraries get installed there

@Tachi107

Should an ARCHIVE section also be added?

Seems like ARCHIVE is already specified 🙂

Oops, right 😅


django-model-publisher.readthedocs.org

The README contains the origin docs at: https://django-model-publisher.readthedocs.org/
Should the docs not created under https://django-model-publisher-ai.readthedocs.io/ ?!?

...and some files still contains 'jp74' ;)


Fix renew and revoke lease

Currently unable to renew or revoke database credential leases since the API is incorrectly implemented in node-vault. This change fixes the problem.
This fix was original proposed in kr1sp1n/node-vault#52.
See:
https://www.vaultproject.io/api/system/leases.html#renew-lease
https://www.vaultproject.io/api/system/leases.html#revoke-lease

@seyfert Yeah, I guess they changed the API within the latest updates. Please check the linting errors of your PR and fix: https://travis-ci.org/kr1sp1n/node-vault/jobs/297431347

Thanks @seyfert 🙏

@kr1sp1n when do you think you'll create a new release that includes this change?


Integration Not Working For Tuya Based Apps

Describe the bug
I Have a ASC which I use for my pool pump which is linked on the "CBI Home" App, also  I have a smart plug & LED stip which is connected via "Connex Connect" app, these devices don't get picked up via the Tuya V2 integration. In order to get them to work what I needed to do was download the smartlife app, connect the devices via the smart life app & then add the tuya v2 integration and select smart life. After that the devices get picked up and I'm able to add them to my home assistant
Expected behavior
I would expect the devices to get picked up as they are tuya based
Home Assistant Version
2021.7.4
**Device specifications
===1st Device===
{
"result": {
"active_time":<PHONE_NUMBER>,
"biz_type": 18,
"category": "kg",
"create_time":<PHONE_NUMBER>,
"icon": "smart/icon/ay1568393722790s1w0j/6abbcaa0f077752d24da192083d80cae.png",
"id": "bfa41dd4d0016603445kcz",
"ip": "XXX.XXX.XXX.XXX",
"lat": "XXXXX",
"local_key": "XXXXXXXXXX",
"lon": "XXXX",
"model": "ASC-W-001",
"name": "Pool Pump",
"online": true,
"owner_id": "25978055",
"product_id": "yrzel5nutomegk6z",
"product_name": "ASC (Wi-Fi)",
"status": [
{
"code": "switch_1",
"value": false
},
{
"code": "countdown_1",
"value": 0
},
{
"code": "add_ele",
"value": 0
},
{
"code": "cur_current",
"value": 0
},
{
"code": "cur_voltage",
"value": 2455
},
{
"code": "cur_power",
"value": 0
}
],
"sub": false,
"time_zone": "+02:00",
"uid": "eu1613400365682nNwdy",
"update_time":<PHONE_NUMBER>,
"uuid": "a42be2480fdb2f52"
},
"success": true,
"t":<PHONE_NUMBER>576
}
===2nd Device===
{
"result": {
"active_time":<PHONE_NUMBER>,
"biz_type": 18,
"category": "cz",
"create_time":<PHONE_NUMBER>,
"icon": "smart/icon/ay153323666394154UBr/653ee4c34ac8f22a6654d88b10ec9a1a.png",
"id": "1417375050029165ee48",
"ip": "XXX.XXX.XXX",
"lat": "XXXX",
"local_key": "XXXX",
"lon": "XXXX",
"model": "CC-P1000",
"name": "TV Plug",
"online": true,
"owner_id": "25978055",
"product_id": "hzfu3vhaqdbcb7jq",
"product_name": " Smart Wi-Fi 3 Pin Plug",
"status": [
{
"code": "switch_1",
"value": true
},
{
"code": "countdown_1",
"value": 0
},
{
"code": "cur_current",
"value": 264
},
{
"code": "cur_power",
"value": 111
},
{
"code": "cur_voltage",
"value": 2428
}
],
"sub": false,
"time_zone": "+02:00",
"uid": "eu1613400365682nNwdy",
"update_time":<PHONE_NUMBER>,
"uuid": "1417375050029165ee48"
},
"success": true,
"t":<PHONE_NUMBER>979
}
===3rd Device===
{
"result": {
"active_time":<PHONE_NUMBER>,
"biz_type": 18,
"category": "dd",
"create_time":<PHONE_NUMBER>,
"icon": "smart/icon/ay153323666394154UBr/b6d65cd852735f0864de0cc012a8654b.png",
"id": "bf96c8077fbd7116e9v0cb",
"ip": "XXX.XXX.XXX.XX",
"lat": "XXXX",
"local_key": "XXXXXXX",
"lon": "XXXX",
"model": "CC-L1007",
"name": "LED Strips",
"online": true,
"owner_id": "25978055",
"product_id": "pziv6njdahielifx",
"product_name": "Smart Wi-Fi LED Light Strip",
"status": [
{
"code": "switch_led",
"value": true
},
{
"code": "work_mode",
"value": "colour"
},
{
"code": "colour_data",
"value": "{"h":256,"s":1000,"v":500}"
},
{
"code": "scene_data",
"value": "{"scene_num":1,"scene_units":[{"bright":0,"h":46,"s":1000,"temperature":0,"unit_change_mode":"static","unit_gradient_duration":13,"unit_switch_duration":14,"v":716}]}"
},
{
"code": "countdown",
"value": 0
}
],
"sub": false,
"time_zone": "+02:00",
"uid": "eu1613400365682nNwdy",
"update_time":<PHONE_NUMBER>,
"uuid": "139a867b50c80464"
},
"success": true,
"t":<PHONE_NUMBER>347
}

Only Tuya Smart and SmartLife App are supported now.

are there any plans to add support for all/additional tuya based apps?


Replaced Legacy .zip packaging with the new DualityTemplates .zip packaging

Reminder to delete the feature branch now that this is merged 🙂

I will, first fixing some other things see chat :)


[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-04-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@raych1 We have just copied from the previous api version, not sure why this failed. Can you please let me know if new tests were added wrt avacado checks

I don't see any changes here requiring ARM review, signing off.

@raych1 We have just copied from the previous api version, not sure why this failed. Can you please let me know if new tests were added wrt avacado checks

@asmaskar , can you confirm if the default tag in readme.md has all the swaggers included to release as the error complains about the tag doesn't have all the apis comparing to previous version? In addition, please resolve the conflicts.

@raych1 I have fixed the default tag and conflicts

@asmaskar , @raych1 : this PR need to be merged after PR - https://github.com/Azure/azure-rest-api-specs/pull/20969

@asmaskar , @raych1 : this PR need to be merged after PR - #20969 (minor change to be consistent with tag naming)

merged now - https://github.com/Azure/azure-rest-api-specs/pull/21142

@raych1 Can this be merged now?


Attempt to clarify to schema vs migration field types

At least 3 times last week issues came up on the slack channel due to confusion between Ecto types and types that can be used in a migration. I have attempted to raise the visibility of this in the documentation for both Ecto.Migration and Ecto.Schema. Hope it helps.

@josevalim updated.

Yes, let's fix both! Thank you for all of these updates! :)

Will fix shortly

@josevalim updated, ready for review.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


[Telemetry dashboard] PowerShell appears twice on the SDK link tab

On the Code snippets SDK link clicks telemetry, PowerShell appears twice!!

This has been resolved


python310Packages.aiosmb: 0.3.8 -> 0.4.2

Description of changes
Update to latest upstream release

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 191640 run on x86_64-linux 1

17 packages built:

crackmapexec
python310Packages.aesedb
python310Packages.aiosmb
python310Packages.aiowinreg
python310Packages.asyauth
python310Packages.lsassy
python310Packages.msldap
python310Packages.pypykatz
python310Packages.winacl
python39Packages.aesedb
python39Packages.aiosmb
python39Packages.aiowinreg
python39Packages.asyauth
python39Packages.lsassy
python39Packages.msldap
python39Packages.pypykatz
python39Packages.winacl


Fix CASCADE-related problems

Summary
This PR fixes two problems:

Quoted renote deletions not being federated to remote servers when CASCADE is invoked.
CASCADE-invoked deletions not being federated to relays.

It seems necessary to branch Activity in Renote and Quote, so I will test it later.

Thank you guys🥰


[BUG] Resync triggers unreal Work metrics

Describe the bug
Resyncs trigger reprocessing of Work objects that haven't changed and this ends up generating unrealistic work_apply_time_seconds because this metric is based on a timestamp set on an annotation whenever the Work object was created/updated, so we end up with metrics that always hit the maximum bucket limits and are not really useful.

@sschepens, thank you for the issue. You are right, that specific metrics will increase even when the work is not changed. I can think of a few ways to improve it. For example, we can only increase this if there is change. I think most of the functionality is there, I wonder if you want to give it try?


Waiting for tree to go green is failing consistently

There are two types of errors. The first one is a problem with the json result translation:
_checkPRs error in flutter/plugins: type 'List<dynamic>' is not a subtype of type 'List<Map<String, dynamic>>?' in type cast

The second one is because the queries to graphql are timing out for roll PRs with 100s of checks:
OperationException(linkException: ServerException(originalException: null, parsedResponse: Response(data: null, errors: [GraphQLError(message: Something went wrong while executing your query. This may be the result of a timeout, or it could be a GitHub bug. Please include `AF2A:5A52:4325712:9340D0F:61E78945` when reporting this issue., locations: null, path: null, extensions: null)], context: Context({ResponseExtensions: Instance of 'ResponseExtensions'}))), graphqlErrors: [])

Setting as P0 as this is blocking all the rolls and affecting everyone using the waiting for tree to go green label.

\cc @CaseyHillers who was working on a similar issue.

I rolled back to a good version. I thought I fixed this in https://github.com/flutter/cocoon/pull/1552, but it looks like I need another cast.
For the second issue, I'm not sure why we're still seeing timeouts. I'll look into other ways we can speed up the graphql query.

Another issue popped up: The tree status is being marked as failing, and removing the label.
I'm going to revert my original change as it didn't speed up the query.

I did some research into how to optimize the graphql queries:

Lower pagination amounts. Right now we query for 100 pull requests with the waiting for tree to go green label. This isn't a normal amount, and it's more likely to be around 10 max. We can lower this amount which would speed up the query (likely by a factor of 5)
Multiple pass through. We can break the query into multiple parts. Eg (A) Get node ids of pull requests with waiting for tree to go green (B) Query these node ids for the PR state that we need to process auto-submission.

I'll send a PR for (1) as it's a quick fix. (2) can likely be done with a single PR, but I'd like to see the impact (1) has.
If necessary, it may be quicker to instead rely on webhooks for when the label is added, and track those PRs in datastore to be polled.

+1 to lower the pagination amounts. Relying on webhooks and datastore may not be an option as the auto-submit bot will be the first part to be separated to a microservice or independent service. The context is we would like to make the auto-submit bot configurable and generic enough to be used on both dart and flutter repositories.

The pagination decrease wasn't enough. I'm adding
{
  rateLimit {
    limit
    cost
    remaining
    resetAt
  }
}

to our github graphql queries to try and debug this more.

Still failing for the framework, checking what can be removed from the current queries to speed up the queries.

I tried adding pagination (gets 1 pull request at a time, and make multiple graphql requests), and that still timed out.
The issue is that the labels -> pull request query is very expensive. Removing the label query, and leaving it for something that is scanned in Cocoon made the graphql query take <1 second.
I'm currently investigating the feasibility of removing the querying from GraphQL, and using package:github for it. For now, removing the label will still need to be a GraphQL mutation

I created a proposal in https://flutter.dev/go/autosubmit for fixes necessary. I'll start working on MVP tomorrow and throughout next week.

Fixed with https://github.com/flutter/cocoon/pull/1677


A helper function to aid in re-ordering records in nested forms

Is your feature request related to a problem? Please describe.
When integrating a library like SortableJS for drag and drop reordering of records in nested forms, it's currently super-cumbersome to properly reorder them within an AshPhoenix form so they don't re-render in their old order.
Describe the solution you'd like
Our current setup has SortableJS set up to send an LV event with the item paths in the desired order, eg. def handle_event("reposition", %{"items" => ["form[steps][1]", "form[steps][0]"]}, socket). Each resource (in this case Step) has a position field to determine the order it should appear in.
We can get the new position value for each record with Enum.with_index, so it would be awesome to be able to pass that in to a new helper function within AshPhoenix to do the setting of the values and re-ordering in one fell swoop.
It could be something like
def handle_event("reposition", %{"items" => paths}, socket) do
  order_field = :position
  new_positions = Enum.with_index(paths)

  form =
    socket.assigns.form
    |> AshPhoenix.reorder_nested(new_positions, order_field) # new helper?

  # ... rest

Describe alternatives you've considered
Currently we've (well, with your help) got it done inline manually, with some gnarly code that looks like the following:
    updates =
      paths
      |> Enum.with_index()
      |> Enum.map(fn {path, index} -> %{form_path: path, position: index} end)

    socket =
      Enum.reduce(updates, socket, fn %{form_path: path, position: position}, socket ->
        update_nested_form_value(socket, path, "position", position)
      end)
      |> update(:form, fn form ->
        Map.update!(form, :forms, fn forms ->
          Map.update!(forms, :steps, fn nested ->
            Enum.sort_by(nested, fn nested_form ->
              Ash.Changeset.get_attribute(nested_form.source, :position)
            end)
            |> Enum.map(fn nested_form ->
              position = AshPhoenix.Form.value(nested_form, :position)

              %{
                nested_form
                | name: form.name <> "[#{key}][#{position}]",
                  id: form.id <> "_#{key}_#{position}"
              }
            end)
          end)
        end)
      end)

where update_nested_form_value is defined as:
  defp update_nested_form_value(socket, form_path, field_name, value) do
    updated_form =
      AshPhoenix.Form.update_form(socket.assigns.form, form_path, fn form ->
        updated_params = Map.put(AshPhoenix.Form.params(form), field_name, value)
        AshPhoenix.Form.validate(form, updated_params)
      end)

    assign(socket, form: updated_form)
  end

Which works but it's not pretty by any means. Plus it would need to be copied and pasted and rewritten if we had a more deeply nested form.
It seems like a reasonable candidate for having a helper for it in AshPhoenix IMO!

With Ecto you'd do this with sort_param on cast_assoc, eg.
# Schema
cast_embed(changeset, :addresses, sort_param: :addresses_sort)

# Data
%{"name" => "john doe", "addresses" => %{
  0 => %{"street" => "somewhere", "country" => "brazil", "id" => 1},
  1 => %{"street" => "elsewhere", "country" => "poland"}
}, "addresses_sort" => [1, 0]}

This would re-order the records in memory so when the form re-renders, things render in the correct order.
I think you'd typically want to persist the order though, with an attribute on the resource? My initial example used a position attribute.


fix: refresh after chequebook withdraw deposit

🐝 PR preview in Swarm
Preview URL: https://bah5acgza5kip47skjz42rn32hlwykxaesqxejdyppipqdjwnctivcqsnsjna.bzz.link
Swarm Hash: ea90fe7e4a4e79a8b77a3aed855c04942e448f0f7a1f01a6cd14d151424d925a
Commit Hash: 648ba0675e9d2e43a338be88577628ae093bcc38
Commit Message: fix: refresh after chequebook withdraw deposit


doesn't work with Firefox 'Reader View'

First of all, if you haven't tried it, you should. :) Firefox 'Reader View' is awesome--it gets rid of all the distraction an a page, and just presents the text of the article you're trying to read, without ads, without distractions, you can just read the content. I was slow to adopt it, but now I love it and I use it all the time, as often as I can.
Unfortunately, Saka Key stops working after I go into Reader View on a page. I'm not sure if its even possible to fix this in a WebExtension world, but it would great if so.

So... I've actually been working on my own Reader View extension, which uses the same library used by Firefox's Reader View. The sad news is it's in the early prototyping stage and not ready for use.
Saka Key doesn't work in Firefox's Reader View because Firefox's Reader View works by replacing the page with a new page in which Content Scripts cannot be loaded.

Related Firefox bug (look at other bugs blocking/blocked by it) and Vimium bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1286387
https://github.com/philc/vimium/issues/2609


Segmentation fault (PID 24925)
version: PipelineDB 0.9.5 at revision ae8cf36ba5b428b5d72d1fd3f964a2cb8a3e5071 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 5.4.0-6ubuntu1~16.04.1) 5.4.0 20160609, 64-bit
backtrace:
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(debug_segfault+0x28)[0x618738]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x113d0)[0x7f003e48d3d0]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW[0x65dbc9]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(RewriteFromClause+0xd)[0x6603ad]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(ExecCreateContViewStmt+0xb1)[0x5ba0e1]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(standard_ProcessUtility+0x78b)[0x6d658b]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(ProcessUtilityOnContView+0xcd)[0x65868d]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW[0x6d33b4]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW[0x6d3f55]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(PortalRun+0x16c)[0x6d49dc]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(PostgresMain+0x1160)[0x6d1a20]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW[0x473ebd]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(PostmasterMain+0xeb4)[0x67b464]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(main+0x410)[0x474f80]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f003d426830]
pipelinedb: pipeline tmp [local] CREATE CONTINUOUS VIEW(_start+0x29)[0x475049]

@hedayat thanks for reporting! This query will no result in an error, as set operations in CVs are currently not supported. Please comment on #1033 with your use case and/or any information you'd like us to take into account if and when we do add set operations support to CVs. Thanks!

Actually, I later found out that what I want is continuous transforms rather than this view. :P
However, such a CV might be useful when you need to use different queries when NEW and/or OLD are NULL.

Gotcha, in the case that new and old are NULL a simple CASE ... WHEN statement would probably also suffice.

Yes, but AFAIK you'll need to repeat this CASE statement for each column, which will be annoying if the number of columns are many (assuming the postgresql/pipelinedb is smart enough to do the comparison only once, or else there will be performance penalty too).


Access object from "parent" data fetcher

Hi,
Thank you for this awesome lib : )
Having a schema like:
Dogs
  type(GraphQLList(DogType))
  dataFetcher(DogsDatafetcher)

DogType
  name
  breed (BreedDatafetcher)

Is there some nice way BreedDatafetcher could communicate with the DogsDatafetcher to get a DogObject retrieved there to provide the data?
What I did is return the DogObject alongside other data returned from DogsDatafetcher.
Then in BreedDatafetcher i would get the DogObject using:
DogObject dog = ((Map<String, DogObject>)(environment.getSource())).get("DOG_OBJECT")
{ dogs { name breed }}

Hi,
I think you solution is the preferred (or currently the only) way. If you want to access some contextual data you access the source object  and the previous datafetcher is responsible to provide the informations you want to access.

Thanks a lot Andi


Outdated README with glslify

I'm having trouble parsing some of what's in the readme, mainly with how this module was much tighter coupled to the older version of glslify.

var shader = createShader(vertexSource, fragmentSource[, uniforms, attributes])
...
The format of uniforms and attributes is consistent with glslify's output

I'm not sure what this format looks like and what exactly these are supposed to do when you feed them in.

var shader = createShader(gl, glslifyResult)

Also this says to take the glslify result, which is no longer relevant. Or if that formatting is relevant, it's not clear how to use it with how glslify has changed.

I've updated the readme and removed references to glslify. Hopefully that clears things up, let me know if there's anything else!

Perfect! That's a lot less magical now.


[SDK Automation] Establish base line for SDK automation for TypeSpecs

Objective
Establish a baseline for the SDK automation results, which will be used as a reference for future SDK automation runs.
Task

Execute SDK automation for all TypeSpecs in the specification repository.
Identify any issues reported by the SDK automation.
Implement necessary fixes based on the identified issues.

Spec PRs created covering all TypeSpecs
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3481
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3482
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3485
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3486
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3487
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3489
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3490

Python fails for:
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3485/checks?check_run_id=28928592993
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3487/checks?check_run_id=28932298671
https://github.com/test-repo-billy/azure-rest-api-specs/pull/3489/checks?check_run_id=28975547996

JS SDK Generation Failure RCAs

Incorrect tspconfig for RLC: batch 3

DotNet issues tracked at here

the


Workaround asp service crash

After a recent change in MSBuild (https://github.com/Microsoft/msbuild/commit/b8d01363d9781b38e202a692b07914924eb16df5#diff-32568b659f3471e9ecdeb620a363af3c), the ASP form intellisense stopped working. There was no visible error in VS, it just reverted back to the html autocomplete, and thus failing some DDRITS.
It happens because the ASP process is not being able to find Microsoft.Build.Framework when referenced from Microsoft.Build.Utiliites.Core. It probably needs to set some assembly resolvers?
VSTS bug: https://devdiv.visualstudio.com/DevDiv/MSBuild/_workitems/edit/574986
The temporary workaround is to ifdef out the code that depends on framework. In this case this is simple to do, since the code is just detecting whether to run tests or not.
Another better workaround is to just teach MSBuild the name of the new process.

@dotnet-bot test OSX10.13 Build for CoreCLR please

@dotnet-bot test OSX10.13 Build for CoreCLR please


[SPARK-13526] [SQL] Move SQLContext per-session states to new class

What changes were proposed in this pull request?
This creates a SessionState, which groups a few fields that existed in SQLContext. Because HiveContext extends SQLContext we also need to make changes there. This is mainly a cleanup task that will soon pave the way for merging the two contexts.
How was this patch tested?
Existing unit tests; this patch introduces no change in behavior.

@rxin

Test build #52092 has started for PR 11405 at commit 814ae1d.

Test build #52092 has finished for PR 11405 at commit 814ae1d.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52092/
Test FAILed.

Merged build finished. Test FAILed.

Looks pretty good overall.

Test build #52093 has started for PR 11405 at commit fe0f792.

Test build #52093 has finished for PR 11405 at commit fe0f792.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52093/
Test FAILed.

Build finished. Test FAILed.

retest this please

OK, I think I addressed all of your comments.

Test build #52094 has started for PR 11405 at commit 60852ff.

LGTM

Test build #52094 has finished for PR 11405 at commit 60852ff.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52094/
Test FAILed.

Compilation failed.

retest this please

Test build #52104 has started for PR 11405 at commit 775f6c2.

Test build #52106 has started for PR 11405 at commit c9af485.

:)

Test build #52106 has finished for PR 11405 at commit c9af485.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52106/
Test FAILed.

Tests are failing locally. I'm investigating.

Test build #52104 has finished for PR 11405 at commit 775f6c2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52104/
Test FAILed.

Test build #52113 has started for PR 11405 at commit ee3d95b.

retest this please

OK, latest round should pass tests.

Test build #52114 has started for PR 11405 at commit d151fd1.

Test build #52113 has finished for PR 11405 at commit ee3d95b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52113/
Test FAILed.

Test build #52114 has finished for PR 11405 at commit d151fd1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52114/
Test FAILed.

Alright, all previously failing tests pass locally. Jenkins retest this please.

Test build #52130 has started for PR 11405 at commit c76a095.

Test build #52130 has finished for PR 11405 at commit c76a095.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52130/
Test FAILed.

Merged build finished. Test FAILed.

Test build #52132 has started for PR 11405 at commit bdf1a5d.

Test build #52132 has finished for PR 11405 at commit bdf1a5d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52132/
Test PASSed.

Merging this in master.


Problems to access the preview of a markdown file using orca

Issue Type: Bug
CC: @isidorn
CC: @joanmarie
When editing a markdown file, if I activate the previewer by pressing ctrl+shift+v, I cannot browse the displayed content.
Steps to reproduce:

Create an empty folder.
Inside the folder created in the previous step, create 3 empty files called a.js, b.js and c.js.
I don't know if this is important in reproducing the problem, but this is how I reproduce it.
Copy the README.md file present in the VSCode repository to the folder created in the first step.
It may be a false impression, but it seems that the problem is more evident when I use this file.
Launch orca.
Launch VSCode and open the folder created in the first step.
Open the README.md file present in this folder.
Activate the preview pressing ctrl+shift+v and  Try to navigate using arrows.

Actual results:
Orca stays mute.
Expected results:
It should be possible to browse the displayed content as if I were browsing a web page.
 This works fine on macOS. But with VoiceOver there is a command ctrl+alt+shift+down to start browsing the preview. Is there something like this that is expected from Orca? To drill down into the webview?
Because I tried to repro with Orca and Orca indeed stays silent, but I am not sure if I am missing something.
Also was this working before? If yes, when did it stop working?

@isidorn
Once the preview is activated it should be possible to navigate with the arrows in the displayed content, without any additional intervention.
I can't say it worked before as I started using this feature recently, but I also can't read the information of the extensions when I press the enter key when focusing on the name of one, although I can't say that the two problems are related.

TL;DR: Did you switch to browse mode prior to pressing the arrow keys?
Details:
I just gave this a try. When the preview first appears, Orca thinks the focus should be on the page tab. I'll look into why in a moment. But given that this is the case, I was on a page tab (not the document) in focus mode. Under those conditions, reading the document indeed does not work. What I did was the following:

Switch to Orca's browse mode (Orca + A)
Start down arrowing. Orca started presenting the on-screen contents -- including the page tabs, so:
Press H to jump to the next heading because the Readme preview had a heading. Orca presented this heading as expected.
Continued reading the preview of Readme.md using the arrow keys

I will grant you that this user experience isn't great. Ideally focus would start out in the document and not on the newly-selected/active page tab. I'll look into why this is taking place, and either fix it in Orca or make a request of VSCode. :smile:  But at least for me, the preview of the markdown file can be read by Orca.

@isidorn: Probably not. Mind you, I'm still investigating what's going on. Lots of accessibility events....

Every time I try to reproduce the problem, I get different events and see different issues.

One time the problem was that the document claiming focus has an index in parent of -1 (that indicates the accessible object associated with the document is in a potentially-bad state, such as being destroyed). I could try to work around that in Orca, and it might already be fixed in Chromium, but:
Some times there is no focus event at all for the document and the focused state is missing. If it's missing from the state set because AT-SPI2 has a stale value, then I can try to work around that in Orca by clearing AT-SPI2's cache. But if the document then continues to claim that it's not focused, Orca shouldn't change what has focus.

@isidorn: While I'm working on workarounds, could you please see if the problem is also present using a fairly recent Chrome/Chromium in Linux rather than Electron?

@joanmarie I just tried with Chrome 98 using https://vscode.dev/github/microsoft/vscode and I can reproduce this. Note that I do not have the latest Orca version. So it does not seem electron related.

Let's reopen to give more time for the investigation on the Orca side

TL;DR: Did you switch to browse mode prior to pressing the arrow keys?
No.

Switch to Orca's browse mode (Orca + A)
Start down arrowing. Orca started presenting the on-screen contents -- including the page tabs, so:
Press H to jump to the next heading because the Readme preview had a heading. Orca presented this heading as expected.
Continued reading the preview of Readme.md using the arrow keys
Confirmed, works as described.
However, if I press ctrl+tab to go back to the readme.md file and then press ctrl+tab to go back to the preview, the previous steps no longer work.
I need to restart orca for the steps described above to work.

Closing since this issue has not been actively recently and it is also unclear if there is anything to do on the VS Code side


Add UnNest to Nested Types Page

I just wanted to document this here before I forgot! I'm happy to make this change.
I think that the UnNest function should be mentioned in the Nested types section in addition to the SELECT overview.
In general, I think there might be a few other Postgres functions that aren't in the docs just yet, but we can track those in separate issues.

Yes, that makes sense. I think the UNNEST function actually warrants an extra page, since it is a "special" function in the sense that it changes the result cardinality. The functions in the Nested types section could contain UNNEST with a reference to this separate page.

Looks great, thank you!!


too many decimals when setting a RGBa value

When setting a RGBa value with for example $("#colorpicker").val("rgba(47, 47, 47, 0.36)")
the value in the color picker is rgba(47, 47, 47, 0.36078431372549)

is there some bug that set the alpha value with 14 decimal places or is it an issue with jquery?
Thanks

I'm unable to reproduce this behavior. Could you share a page where I can try your version?

Sure have a look here https://jsfiddle.net/SuperDOS/dyg01eqL/12/
The input field is correct but not in the input.clr-color field

That looks like a Chrome bug as I'm unable to reproduce it on Firefox or Safari. I will see what I can do to mitigate it.

It is indeed a Chrome/Chromium bug and it's already been reported here: https://bugs.chromium.org/p/chromium/issues/detail?id=1300389
I'm thinking of a workaround now, I will let you know when/if a fix is available.

A fix has been released. I will revert it when Chromium fixes the bug.


fix(side-navigation): fix selected style rule no constrained enough

Fix a bug where all the children of a selected side navigation would get the selected style
(Not adding in the changelog since it does not appear in the current release of lumx)
StoryBook: Deploying...

Before:

https://1e0d3d2e--5fbfb1d508c0520021560f10.chromatic.com/?path=/story/lumx-components-side-navigation-side-navigation-item--items-and-sections
After:

https://5fbfb1d508c0520021560f10-pnuulschev.chromatic.com/?path=/story/lumx-components-side-navigation-side-navigation-item--items-and-sections


build out makefile

Some features:

build executable
build pod - don't have anywhere to push it yet, it may be a localhost sort of thing
build systemd files

may consider writing this in ansible, so I can deploy remotely
need scripts to build bots, create systemd files, and deploy

dropping this, will migrate to mage, so I can combine the shell scripts and make tools into one


use binary search instead of linear for get_val in merge

Codecov Report

Merging #1548 (8b5aa2b) into main (20c8790) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #1548   +/-   ##
=======================================
  Coverage   93.93%   93.93%
=======================================
  Files         249      249
  Lines       46066    46066
=======================================
  Hits        43274    43274
  Misses       2792     2792

Impacted Files
Coverage Δ

src/indexer/sorted_doc_id_multivalue_column.rs
97.80% <75.00%> (-2.20%)
:arrow_down:

src/postings/stacker/expull.rs
98.57% <0.00%> (-0.48%)
:arrow_down:

src/fastfield/multivalued/mod.rs
98.02% <0.00%> (+0.79%)
:arrow_up:

bitpacker/src/bitpacker.rs
100.00% <0.00%> (+0.98%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


nested loop sequential or parallelization runtime

I have recently started using Pynndescent to create nearest neighbor graphs. It performs much faster and is more stable than sklearn nearest neighbor graph alternative.
The problem I am trying to solve is about scale: I generate a data-set whose columns are used to compute nearest neighbor graphs which means that for a 500 x 50 matrix (the example below) I have to compute 50*(50-1)/2 nearest neighbor graphs which is 1225 calls to pynndescent. This takes 9 seconds on my machine which is very limiting because I would like to do this for significantly larger data-sets (i.e. N = 1000 as opposed to 50 ).
Are there ways to optimize and do something else than a for loop? I serialize instead of the naive nested loop but python threading and multiprocessing haven't produced better result than the solution below.
data = np.random.normal(0,1, (500,50) )

  idx = list(itertools.combinations( range(data.shape[0]),2))

  count = len(idx)

  s = np.empty( N , dtype=np.float16 )

    for i in range(count):
        s[i] = NNDescent(data[:,idx[i]], metric='euclidean', n_neighbors = 5).neighbor_graph[1].sum()

Off the top of my head I don't see any obvious ways to improve this significantly. There is just a lot of computation work to be done, and I'm not sure there are ways around that. You would have to look into deeper algorithmic approaches to cut down on work I think.


Push current version (0.4.1) to repository!

Hi, I've published 0.4.1 to NuGet

Hi, I've published 0.4.1 to NuGet

Thx :-)

Thx :-)


Add instrument category

Codecov Report

Merging #4 into main will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8        10    +2
  Lines          114       127   +13
=========================================
+ Hits           114       127   +13

Impacted Files
Coverage Δ

qual_id/categories/instrument.py
100.00% <100.00%> (ø)

qual_id/pattern.py
100.00% <100.00%> (ø)

test/categories/test_instrument.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 255c267...0b2f0b6. Read the comment docs.

in the pattern class there is a conflict. to finish, just delete part of the instrument code?


minor tweaks

Okay. Tnx.

@Ergonomicmike
I have a stratux-setup bash script I just hacked together if you want to give it a try?
It's mostly what's in image/spindle/wheezy-stage4 but with some mods/tweaks. Theoretically, you should be able to setup stratux on a stock RPi2 (and possibly an RPi3) OS without the need to use the release image. I've not had a chance to test it yet, probably get to it Monday evening.

I'd like to experiment with that, too, Joseph, if you're willing.
On 03/06/2016 11:14 PM, Joseph Poirier wrote:

@Ergonomicmike https://github.com/Ergonomicmike
I have a stratux-setup bash script I just hacked together if you want
to give it a try?
It's mostly what's in image/spindle/wheezy-stage4 but with some
mods/tweaks. Theoretically, you should be able to setup stratux on a
stock RPi2 (and possibly an RPi3) OS without the need to use the
release image. I've not had a chance to test it yet, probably get to
it Monday evening.
—
Reply to this email directly or view it on GitHub
https://github.com/cyoung/stratux/pull/308#issuecomment-193105315.

is skypuppy your reddit user name

skypuppy7 over there (it would not let me have skypuppy)
On 03/06/2016 11:49 PM, Joseph Poirier wrote:

is skypuppy your reddit user name
—
Reply to this email directly or view it on GitHub
https://github.com/cyoung/stratux/pull/308#issuecomment-193115241.

Is that a good thing or a bad thing?  :)
On 03/06/2016 11:49 PM, Joseph Poirier wrote:

is skypuppy your reddit user name
—
Reply to this email directly or view it on GitHub
https://github.com/cyoung/stratux/pull/308#issuecomment-193115241.


fix task 'config' property getting overwritten

setFrom overwrites whatever is there before. Changed to from which only adds, does not overwrite.
In practice, setFrom was causing an issue for me where trying to set the config file for a specific Detekt task was not working becuase it was being overwritten by what I put in the plugin extension config. The overwrite only occured for some Detekt tasks and not others, adding to the confusion. I suspect this is because the order of when gradle executed certain blocks of code mattered. My expectation is all configured files to be used, none should replace any other and especially not in a silent, confusing, unpredictable way.
With this change, order of when gradle executes different blocks of code no longer matters and all config files are used reliably both from the plugin extension and from task properties.

How are you configuring the task to override the config? Can you provide a code snippet?
The proposed PR is half a fix that leaves an issue - instead of replacing the task's config, it will add the extension's path(s) to the end of the task's config paths.

Detekt tasks should have a way to input configuration without having to use any files at all

This can partially be achieved by using TextResourceFactory and https://docs.gradle.org/current/dsl/org.gradle.api.resources.TextResource.html#org.gradle.api.resources.TextResource:asFile().
The config will still be passed to detekt as a file but it will simplify your task config a lot.

config.from(generatedConfigFile)

Why aren't you using setFrom to override the default config in the task? set adds a new file to the list but if you want to override config you should use setFrom.

I am assuming this is because the order in which different configuration blocks in gradle execute is unpredictable.

I don't think this is correct, it might be unexpected in some cases, but it should be predictable and consistent, and if it wasn't, that sounds like a Gradle issue rather than something we can fix properly in the detekt plugin.

this PR is just a band-aid and doesn't resolve some bigger issues. If you still are not sure about merging it, maybe we could at least leave the PR open and come back to it another time after working on some of these other issues?

Yes please. Opening individual new issues for each of the issues you're seeing would be best, with reproducers. I'm going to close this PR for now though since recreating it is trivial if it turns out this is the right approach (or it can be reopened), but I'd prefer to leave the current functionality as is and introduce convention to set the default on the task once Gradle 8.8 is out which should resolve this too.

introduce convention to set the default on the task once Gradle 8.8 is out

See #7356


Remove duplication of X chromosome alleles

With the X chromosome, if only one allele is reported for a SNP, the allele is doubled such that the X chromosome genotype will always be a string of length 2. Some data sources report two X chromosome alleles for all X chromosome SNPs, even if the individual is a male. So, by doubling single alleles, this makes all X chromosome data consistent.
However, instead of doubling alleles, it'd be better to analyze the X chromosome SNPs to determine if only one allele should be reported (i.e., if an individual is male). Any heterozygous SNPs not in the pseudoautosomal region could then be flagged as a discrepant SNP.

I can suggest a cut-off for whether the number of heterozygous  X chromsome SNPs indicates a female vs a male with discrepant SNPs. I've used 3.125% which seems to work OK. I can maybe write up a deeper analysis if you think that would be valuable.

Thanks @castedo.

I'm going to take a look at this now.

I will initially use the threshold of 3.125% that was suggested by @castedo .

When working on this, I noticed that there are sometimes duplicate rsids which means that I am not able to overwrite the genotype column values. We could drop_duplicates in the index and take the value of the first occurrence which would make things a lot simpler. Thoughts?
https://stackoverflow.com/questions/27236275/what-does-valueerror-cannot-reindex-from-a-duplicate-axis-mean

Dropping duplicate SNPs sounds good. However, I think we should track them as discrepant SNPs that get returned after loading a file (same as returning any heterozygous SNPs in the non-PAR region as discrepant SNPs for a file determined to be male).

I have made a start at this here: https://github.com/apriha/snps/pull/48
I was not 100% sure the best way to add the discrepant SNPs but we can discuss in the PR.


Scrolling via a saved url

Hi guys,
I found a small bug I think, in the gh-pages -> assets/apps.js file. Line 8:
location.replace(el.id);
...should be
$location.replace(el.id);
Once changed it loads the page and scrolls to the proper place.
AngularJS + Bootstrap is the bomb! Thanks.

Can you verify this is still an issue? Thanks for reporting though :+1:

I actually think this is intentional. I tried tweaking this, and while this behavior is suboptimal, I'm not sure there is a better way.

Closing as per prior investigation.


Markdown "Show Source" should go to previous tab if open

Issue Type: Bug

When using the Markdown preview, the "Show Source" action should be smart enough to know that the source is open and go to that tab. Same applies to the preview tab, if there is already a preview tab open switch focus there. Otherwise you're in this endless loop of creating duplicate tabs.
VS Code version: Code - Insiders 1.35.0-insider (a5536b8f5a16a10d859f3dec1e59701671bf069e, 2019-05-20T05:15:57.974Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (8 x 3100)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
16.00GB (0.67GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (30)

Extension
Author (truncated)
Version

vscode-browser-preview
auc
0.5.4

vscode-opennewinstance
chr
0.0.6

bracket-pair-colorizer
Coe
1.0.61

vscode-svgviewer
css
2.0.0

vscode-eslint
dba
1.9.0

gitlens
eam
9.7.4

vsc-material-theme
Equ
2.8.2

prettier-vscode
esb
1.9.0

azure-virtual-machine-explorer
for
0.0.2

vscode-pull-request-github-insiders
Git
1.137.0

vscode-colorize
kam
0.8.10

theme-monokai-pro-vscode
mon
1.1.13

vscode-azureappservice
ms-
0.14.0

python
ms-
2019.4.12954

remote-containers
ms-
0.53.0

remote-ssh
ms-
0.37.0

remote-ssh-edit
ms-
0.37.0

remote-ssh-explorer
ms-
0.37.0

remote-wsl
ms-
0.36.0

azure-account
ms-
0.8.4

azurecli
ms-
0.4.5

vscode-typescript-tslint-plugin
ms-
1.0.0

debugger-for-chrome
msj
4.11.3

vetur
oct
0.21.0

vscode-docker
Pet
0.6.2

vscode-yaml
red
0.4.0

code-settings-sync
Sha
3.2.9

ayu
tea
0.18.0

WebTemplateStudio-dev-nightly
WAS
0.0.1914003

markdown-all-in-one
yzh
2.3.1

(17 theme extensions excluded)

I'd like to give this a try

Ok, I could use some help on this issue. I traced the click call to the function openTextDocument in extHost.api.impl.ts, but am not sure if I should be making any changes here since it will very likely affect other functionalities as well.
I also noticed that if I have the file already open in the same split window pane, it will open that instead of creating a new split pane, but it is calling the same code with the same parameters here even when it opens a new pane with a new tab. So I am confused how calling the same function with the same parameter exhibits different behaviors (opening a new pane with a new tab vs opening an already open tab in the same pane).

Some pointers around this would be very helpful, thanks

@mjbvz sorry for tagging you, not sure if you got a chance to see my previous comment. Can you please help out?

@chirag64 The api you linked to is a good starting point but that is part of core VS Code. You want the caller of that api, which in the case is the markdown extension.
How I think this feature should work:

In the markdown extension, we maintain a list of active previews. These should track which column created the preview. This is likely already passed in with PreviewSettings, we just don't store the resourceColumn anywhere as far as I remember.
When the show source command is invoked, use the preview's column information to decide which column to show the preview in


chore: optimized test description

Types

[ ] 🎉 New Features
[ ] 🐛 Bug Fixes
[ ] 📚 Documentation Changes
[ ] 💄 Code Style Changes
[ ] 💄 Style Changes
[ ] 🪚 Refactors
[ ] 🚀 Performance Improvements
[ ] 🏗 Build System
[ ] ⏱ Tests
[x] 🧹 Chores
[ ] Other Changes

Background or solution

🤖 Generated by Copilot at a85158d

Clarify the descriptions of the test suites and test cases for the unRecursive file system watcher in file-node-watcher.test.ts (link, link, link, link, link, link, link, link, link)
Specify that the test cases for the recursive file system watcher in file-node-watcher.test.ts only apply to watched files, not any files (link, link)

Changelog

Optimized test description

@wjywy commit 太多了，压一下或者重新切分支提交吧


Improve the examples' directory structure

This is a collection of general improvements in regards to the directory structure of our examples that I think will benefit both users and developers, things that have been bothering me over the years.
In the first commit, I made each example its own workspace member. This has a couple of advantages:

It should in theory allow cargo to parallelize the compilation of examples better. This is useful in particular when running cargo test, and when using rust-analyzer.
You can easily remove individual examples from the workspace if you don't want them to build (e.g. while using rust-analyzer) by editing the workspace manifest. For instance you might want to have just one example in the workspace while working on something, so that incremental compilation is faster.
It's clear which example uses which dependencies.

Mostly just less confusing to new users.
If you only want to build one example, you don't need to build the dependencies of all the other ones.

Specifying files relative to the example's directory is cleaner, compare e.g. src/bin/<example>/file.ext vs. file.ext.

Unrelated to workspace members, I find these to be fine improvements as well:

There's less nesting: compare examples/src/bin/teapot/main.rs to examples/teapot/main.rs. This makes it faster to browse.
Each example is in a directory now unlike there being a mix of files and directories, which makes it easier to find the one you're looking for.
The naming of the examples is consistent now, wheras before there would be a mix of _ and --separated names. I went with the - because that's what all our public crates use.

The second commit, besides adjusting the shader paths, makes the runtime-shader example work no matter where you are in the workspace. This was driving me MENTAL. Made me cuckoo I tell you. Institution-ready. Reason being that I like to run examples while having my cursor over them in vifm and hitting a shortcut to run it, which wouldn't work for this one.
The fourth commit, besides adjusting the shader paths, moves the lib.rs file from the examples directory to the teapot directory, and makes it a module of the example. Having this file in the examples directory was quite strange and confusing.
In the sixth and ninth commits I made all output files be stored in the directory of the example, rather than in your current working directory, so that it's clear which files come from where and don't pollute what they're not supposed to.

I noticed that when running the run_all.sh script, it has to compile every example before running it individually, instead of compiling all of them in advance so they can all run in quick succession. That's a bit inconvenient.
Other than that, everything looks good.

Yeah I get the same. As if the first compile wasn't enough or something?

I find the script extremely helpful for quickly making sure all the examples work and aren't crashing or triggering validation errors. It's part of my standard routine before posting a PR. I never had any slowdown issues, so I'd just let it compile everything in the background and then quickly step through all the example programs.

Much better now, thank you!


Android: cannot find symbol method 'init'

Environment
"@capacitor/*": "^6.0.0",
"@sentry/capacitor": "^0.18.0",
"@sentry/vue": "^7.114.0",
"vue": "^3.4.31",
Steps to Reproduce

Clone this repo
Install dependencies via npm install
(Rename .env.sample to .env and add the DSN)
Run ionic cap build android
Try to run the app via Android Studio

Expected Result
The code in MainActivity.java should work without any problems.
package io.ionic.starter.capacitor_sentry_test;

import android.os.Bundle;
import com.getcapacitor.BridgeActivity;
import com.getcapacitor.Plugin;
import io.sentry.capacitor.SentryCapacitor;
import java.util.ArrayList;

public class MainActivity extends BridgeActivity {
  @Override
  public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    // Initializes the Bridge
    this.init(savedInstanceState, new ArrayList<Class<? extends Plugin>>() {{
      // sentry-capacitor plugin
      add(SentryCapacitor.class);
    }});
  }
}

Actual Result
This issue somehow seems related to #62, whose issue I also experienced but which was resolved after manually syncing the project with the Gradle files.
But now I get the following error for the code in MainActivity.java.
'init()' has private access in 'androidx.fragment.app.FragmentActivity'

.../capacitor-sentry-test/android/app/src/main/java/io/ionic/starter/capacitor_sentry_test/MainActivity.java:14: error: cannot find symbol
    this.init(savedInstanceState, new ArrayList<Class<? extends Plugin>>() {{
        ^
  symbol: method init(Bundle,<anonymous ArrayList<Class<? extends Plugin>>>)

Thank you for the repro, we will investigate what is going on with the crash.

Hi, the MainActivity code shown is only compatible with Capacitor 2, Capacitor 3 or newer automatically initializes capacitor, all you need is to use the following snippet:
public class MainActivity extends BridgeActivity {
  @Override
  public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    // Initializes the Bridge with the desired plugins
    this.registerPlugin(SentryCapacitor.class);
  }
}

If in your specific case the initialization of Capacitor is required, you can also add     this.registerPlugin(SentryCapacitor.class); after super.onCreate

Thanks, that solves this issue. Maybe I followed the docs a little too well in this case since it only mentions capacitor 3 but not capacitor 3 or newer. ;)


Property sign cannot understand mixed case key values.

BKCommonLib version: bergerhealer/BKCommonLib@f93b967
TrainCarts version: -Unrelated-
Spigot version: -Unrelated-

Problem or bug: The method LogicUtil#contains(T value, T... values) uses Object#equals(Object obj) instead of String#equalsIgnoreCase(String anotherString), requiring the property key value to be all lowercase instead of allowing mixed case.
Expected behaviour: --
Steps to reproduce:

PR created, see above.

Nature of above PR changed, unable to fix issue, require further changes.

Ill make the further changes needed

This should do it: https://github.com/bergerhealer/TrainCarts/commit/5d7dd49c4eff2fca6352655ff7e4f12590809900


Update README.md

Issue #

Description of changes

New/existing dependencies impact assessment, if applicable
test

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test


Small fixes in discogapic

Fix callable classes.

Codecov Report

Merging #1889 into master will not change coverage.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master    #1889   +/-   ##
=========================================
  Coverage     85.22%   85.22%
  Complexity     4738     4738
=========================================
  Files           439      439
  Lines         18787    18787
  Branches       2001     2001
=========================================
  Hits          16012    16012
  Misses         2073     2073
  Partials        702      702

Impacted Files
Coverage Δ
Complexity Δ

...degen/transformer/java/JavaSurfaceTransformer.java
97.7% <50%> (ø)
74 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf114a...908ffb6. Read the comment docs.

PTAL


Alternate PR to #3970

LGTM

I also need to add a before_request for #7024 to get session information from cookies. However, this PR does not seem to solve the problem: the intended use as per the provided example does not work.
FLASK_APP_MUTATOR = lambda x: x.before_request = f

results in a SyntaxError: can't assign to lambda with Python 3.6.8. Currently, assignments are not supported in Python, and this is apparently going to change in Python 3.8.
My understanding is that the most workable current alternative is to add the before_request handler in __init__.py.


cmd: Use readline library.

Using this library we have history and auto-completion out of the box.

Current coverage is 61.01% (diff: 100%)

Merging #98 into master will not change coverage

@@             master        #98   diff @@
==========================================
  Files            40         40
  Lines          1652       1652
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1008       1008
  Misses          585        585
  Partials         59         59

Powered by Codecov. Last update 761ba5e...1c6b320


Pin systemjs to avoid breakage

SystemJS version 0.21.0 works, but version 0.21.1 breaks with various Unable to load transpiler to transpile errors. Pin the version to 0.21.0 for now to avoid this issue.
I filed an upstream issue to get this fixed: https://github.com/systemjs/systemjs/issues/1809
Fixes #9617.

Trivial.


Update devopera.webmanifest

Changing orientation to "any". There no reason why we should limit it to portrait only, IMHO.

LGTM, @mathiasbynens?

LGTM