Day 14 Lab - App crashes when I try to open the Gallery

I think you're having an issue with your getPosts method where I have images that were saved earlier in the week without a date, and your method requires that a date be on the record -- without one, it's trying to force unwrap a nil value.  To fix this, move the let date statement up into the if let above it.

Because I'm getting a crash when I try to open the Gallery, I can't check the following:

Implement a pinch gesture recognizer on GalleryViewController, that affects the collection view layout.
Create a custom protocol and use delegation to send back the image selected from
GalleryViewController to the HomeViewController for further editing.


occurred ExecutionPhaseError in the generated test

Description
I use the latest main utbot-cli ，but an error test with ExecutionPhaseError is generated
Expected behavior
Test cases can be generated normally or exceptions can be handled correctly
Actual behavior
Example: an error test with ExecutionPhaseError is generated
Visual proofs (screenshots, logs, images)
Example:
public void testFail_errors() {
assertThrows(org.utbot.instrumentation.instrumentation.execution.phases.ExecutionPhaseError.class, () -> xxxx);
}

Environment
java version: 11
utbot-cli version: latest main

@harzss
If you still face the issue, please provide the details of your case.
Class or method under test.
Thank you in advance.


Namespace-aware xarray.ufuncs

[x] Closes #7848 (partially)
[x] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

Re-implement the old xarray.ufuncs module to allow generic ufunc handling for array types that don't implement __array_ufunc__:
import jax.numpy as jnp
import numpy as np
import xarray as xr
import xarray.ufuncs as xu

x = xr.DataArray(jnp.asarray([1, 2, 3]))
print(type(xu.sin(x).data))
print(type(np.sin(x).data))

# <class 'jaxlib.xla_extension.ArrayImpl'>
# <class 'numpy.ndarray'>

This looks great! Could you please also add a brief note to whats-new.rst?

This looks great! Could you please also add a brief note to whats-new.rst?

Yes will do. Shall we add these back to the main api docs as well, same as before minus the deprecation notice?

Yes, please!
On Sun, Nov 17, 2024 at 1:22 PM Sam Levang @.***> wrote:

This looks great! Could you please also add a brief note to whats-new.rst?
Yes will do. Shall we add these back to the main api docs as well, same as
before
https://github.com/pydata/xarray/pull/6491/files#diff-9ceb22fb61ab27613e143e733f0d2ef128c1f72125ae3c6324465955bd093f93
minus the deprecation notice?
—
Reply to this email directly, view it on GitHub
https://github.com/pydata/xarray/pull/9776#issuecomment-2481582943, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJFVVI36XVHPN3ZAPCCSL2BECIVAVCNFSM6AAAAABRVS4J72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBRGU4DEOJUGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Subtracting datasets in xarray 2024.6.0 leads to inconsistent chunks

What is your issue?
When I call groupby() on a dataset and try to subtract another dataset from the result, I get an error that says
ValueError: Object has inconsistent chunks along dimension lead. This can be fixed by calling unify_chunks().
Adding a call to unify chunks beforehand resolves the issue, but for some strange reason this chunking issue only occurs with more recent versions of xarray. When I run the same code below with xarray 2022.3.0, I can run the same code without calling unify chunks. Does anyone know what may have caused the discrepency?
Here's the relevant section of code I was running when I encountered the problem. in the snippet below, the members variable is a list of paths to netcdf files that contain the output from an ensemble of ocean models. I think the error should be reproducible with any group of netcdf files and similar operations:
ds = xarray.open_mfdataset(members, combine='nested', concat_dim='member').sortby('init')
ensmean = ds.mean('member')
climo = ensmean.sel(init=slice('1993-01-01', '1993-12-31')).groupby('init.month').mean('init').load()
anom = model_ds.groupby('init.month') - climo

And here's the output from xarray.show_version():
INSTALLED VERSIONS
------------------
commit: None
python: 3.12.4 | packaged by conda-forge | (main, Jun 17 2024, 10:23:07) [GCC 12.3.0]
python-bits: 64
OS: Linux
OS-release: 3.10.0-1160.102.1.el7.x86_64
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US
LOCALE: ('en_US', 'ISO8859-1')
libhdf5: 1.14.3
libnetcdf: 4.9.2

xarray: 2024.6.0
pandas: 2.2.2
numpy: 2.0.0
scipy: None
netCDF4: 1.7.1
pydap: None
h5netcdf: None
h5py: None
zarr: None
cftime: 1.6.4
nc_time_axis: None
iris: None
bottleneck: None
dask: 2024.7.1
distributed: 2024.7.1
matplotlib: None
cartopy: None
seaborn: None
numbagg: None
fsspec: 2024.6.1
cupy: None
pint: None
sparse: None
flox: None
numpy_groupies: None
setuptools: 71.0.4
pip: 24.0
conda: None
pytest: None
mypy: None
IPython: None
sphinx: None

Ah this is my mistake, we need to loop over variable and chunk them individually here:
https://github.com/pydata/xarray/blob/ad35a1059f0d10c29f9ed28bc87192b6b88b6cb3/xarray/core/groupby.py#L706-L713


EC 11.2.1, 11.2.3 - oc_id service is not configured to start on boot

On EC 11.2.1 and 11.2.3, the oc_id service is not configured to start on boot. After rebooting two HA frontends:
user@machine:~/chef_server/upgrade/$ sudo private-chef-ctl status
run: nginx: (pid 9012) 3014s; run: log: (pid 1048) 106525s
run: oc_bifrost: (pid 8885) 3016s; run: log: (pid 1011) 106526s
down: oc_id: 5045s; run: log: (pid 1047) 106525s
run: opscode-account: (pid 8922) 3016s; run: log: (pid 1044) 106525s
down: opscode-certificate: 5043s, normally up; run: log: (pid 1032) 106526s
run: opscode-erchef: (pid 8934) 3016s; run: log: (pid 1045) 106525s
run: opscode-reporting: (pid 10208) 2531s; run: log: (pid 1046) 106525s
opscode-webui disabled
```

Note the lack of a 'normally up' in the oc_id line. Checking the runit directory confirms that the service is not set up to auto-start:
```
user@machine:~/chef_server/upgrade/$ ls -la /opt/opscode/service/oc_id/
total 20
drwxr-xr-x 4 root root 4096 Sep 30 11:22 .
drwxrwxr-x 10 root root 4096 Oct 24 14:08 ..
-rw-r--r-- 1 root root 0 Sep 30 11:22 down
-rw-r--r-- 1 root root 0 Sep 30 11:22 keepalive_me
drwxr-xr-x 4 root root 4096 Sep 9 15:06 log
-rwxr-xr-x 1 root root 285 Sep 9 15:06 run
drwx------ 2 root root 4096 Oct 24 13:35 supervise
user@machine:~/chef_server/upgrade/$
```
Removing the 'down' file and running '/opt/opscode/embedded/bin/sv start oc_id' brought it back up, but running 'pcc reconfigure' re-created the 'down' file:
```
Recipe: private-chef::oc_id
* file[/opt/opscode/sv/oc_id/keepalive_me] action create (up to date)
* file[/opt/opscode/sv/oc_id/down] action create
- create new file /opt/opscode/sv/oc_id/down
```
The only values in private-chef.rb related to oc_id are these:
```
oc_id['administrators'] = %w(user user2 userZ)
oc_id['ha'] = true
oc_id['vip'] = '<IP_ADDRESS>'
```
And the docs page says that true is the default value for oc_id['enable']

The net result is that it's impossible to reboot frontends without breaking private supermarket, and the fix is to log on and start it manually.

Based on the discussion in https://github.com/opscode-cookbooks/enterprise-chef-common/issues/21 I think we should close this issue.  Any objections?

Agreed.


Items keep changing after quitting and re-joining the game.

As the title says for some reason this mod causes both items and scraps change. While with scraps its okay because they don't change the value of the scraps it becomes a problem when items change and even sometimes disappear even though not exceeding the number of how many items you can have.
Here's the initial:

And after reloading the game:

I found out that this happens when equipment is added that is also counted as scrap items. I also noticed that overlapping names also causes it to change. Still can't figure out why other mods do this.


fix: correct defect on sorting objects

Summary
Add missing cases for sorting arrays.
SUMMARY_GOES_HERE
Full changelog

[Implement ...]
[Fix ...]

Issues resolved
Fix #XXX
Documentation

[ ] Link to the website documentation PR

Testing

[ ] Unit tests
[ ] E2E tests
[ ] Manual testing on Universal
[ ] Manual testing on Kubernetes

Codecov Report
Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 41.14%. Comparing base (52a75e3) to head (f33ef9a).

Files
Patch %
Lines

pkg/state/types.go
0.00%
7 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   41.16%   41.14%   -0.03%
==========================================
  Files          74       74
  Lines       10795    10802       +7
==========================================
  Hits         4444     4444
- Misses       5890     5897       +7
  Partials      461      461

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[ISSUE-709] Improve release workflow

Purpose
Issue dell/csi-baremetal#709
Added workflow input parameter for branch to release from.
PR checklist

[ ] Add link to the issue
[x] Choose Project
[x] Choose PR label
[ ] New unit tests added
[ ] Modified code has meaningful comments
[ ] All TODOs are linked with the issues
[ ] All comments are resolved

Testing
It's impossible to test in this repo before this PR is merged as will be executed workflow code from master branch of this repo even if another branch as code source will be chosen in csi-baremetal repo. See this line comment
Tested on fork. Releases created by automation:
https://github.com/misanthropicat/csi-baremetal/releases/tag/v1.0.0-test
https://github.com/misanthropicat/csi-baremetal-operator/releases/tag/v1.0.0-test

@misanthropicat please create temporary release for test purposes

@misanthropicat please create temporary release for test purposes

I did it on fork + it's impossible to do before this PR merge as will be executed workflow code from master branch of this repo even if another branch as code source will be chosen. See this line comment

@misanthropicat please create temporary release for test purposes

I did it on fork + it's impossible to do before this PR merge as will be executed workflow code from master branch of this repo even if another branch as code source will be chosen. See this line comment Test releases on fork: https://github.com/misanthropicat/csi-baremetal/releases/tag/v1.0.0-test, https://github.com/misanthropicat/csi-baremetal-operator/releases/tag/v1.0.0-test

@misanthropicat please add this information to the Testing section

@misanthropicat please create temporary release for test purposes

I did it on fork + it's impossible to do before this PR merge as will be executed workflow code from master branch of this repo even if another branch as code source will be chosen. See this line comment Test releases on fork: https://github.com/misanthropicat/csi-baremetal/releases/tag/v1.0.0-test, https://github.com/misanthropicat/csi-baremetal-operator/releases/tag/v1.0.0-test

@misanthropicat please add this information to the Testing section

Done.

@misanthropicat do we need to update documentation?


Disallow new identifications of taxa de-activated by swaps and merges

There are a few ways identifications can be created using inactive taxon concepts, including

Vision suggestions (the model is based on a static list of taxon IDs, any of which could become de-activated before the next model comes out)
Cached taxa in the iPhone app

While dealing with this for splits is possibly tricky, we can definitely create new identifications with the active synonyms of taxa de-activated by swaps and merges.
See http://www.inaturalist.org/observations/7932434

Pretty sure 1 is resolved now right?
Looks like if you enter it as placeholder text on iOS, Android, or through the browser uploader, it can map to an inactive taxon.
A link to this report on the forum (why I'm looking at this--closing out old bug reports).

Regarding point 1, there is at least some delay on the CV still because I made a taxon inactive via a swap August 3, 2020 and it was still coming up in the CV a month later:

Running the CV on that same image now (Dec 2020) gives the new taxon for Argynnis instead.


Getting issue with

Describe the bug
I am getting the following issue while using theme: sb2nov

To Reproduce
I ran the following cmd/steps:-

rendercv new "Alex"

Changed the theme name under design in yaml file

rendercv render Alex_CV.yaml

Screenshots

So what will be the quick fix , for sb2novfor now

Sone ideas :-
Can you create a flag for theme name itself while creating a yaml file ? so yaml file will create accordingly as per theme

Hello, in the next release, there will be a theme option for the rendercv new command. Thank you for the suggestion!


Benchmarks for ability to do math with physical units

Not yet ready for review.

This is ready for review, though I haven't yet had the chance to test it directly on existing models, so there may be some tweaking. Still, most of the concepts I wanted to capture are present.

@r-barnes Thank you for submitting your task! We are in the process of pairing submissions with task reviewers and will be in touch soon.

@cdfreeman-google and @ajslone: I've implemented the max_examples API.

#356 seems to test a duplicate functionality, but has a fixed number of examples and only tests direct conversions; this PR can generate examples on the fly and tests both unit math and direct conversions.

#372 is similar to this task with some differences:

This task generates problems on the fly; #372 has a fixed set of problems.
This task asks for explicit unit-based arithmetic; #372 only asks for the implicit arithmetic necessary to perform conversions.
This task uses a variety of problem wordings; #372 uses a single wording for each type of problem.
#372 tests a model's ability to learn and work with new systems of units; this task tests a model's knowledge of existing SI and Imperial units.
#372 has some ambiguity in units; care has been taken in this task to avoid ambiguity.
#372 has chained units conversion; this task does not.
Both tasks have subtasks with varying levels of difficulty.

@r-barnes Thanks, I have added the area units (ft^2, m^2, km^2, mile^2) and removed the temperature units as of now at https://github.com/r-barnes/BIG-bench/pull/1 . I haven't modified the readme though (my authorship info is: Vikas Raunak, viraunak@microsoft.com).

@vyraun : Thanks! I've merged your change and added you as an author in the README - please verify that your information is correct.

Great, thanks @r-barnes ! The information looks good.

@r-barnes We are now requesting that task authors please include an explicit section in the README.md file called "data source", listing exactly where you got your data from (or explicitly state that you made it up yourself). Many thanks!

Hi @r-barnes, I'm one of the reviewers for this task.  Also tagging @mathopus who is reviewing 372.  We would suggest merging your task with #372, by using the python code to generate static examples that you then add to the JSON file.  Do you have strong objections to this?

@ramasesh, I'm generally alright with this, but have some reservations.

This task judges models based on the relative error of their response whereas I believe #372 will judge success based on string matching of some sort (perhaps BLEU). The relative error allows a model to perform, eg, quantized calculations and still receive credit for it. String matching seems as though it has some distinct disadvantages for judging numeric correctness. If the BIG-Bench libraries can be modified to include support for numeric comparisons, I'd feel better about merging (@chiafullo).
This task judges model performance across units, three levels of problem difficulty, several wordings, and several choices of number of digits. Collectively this offers quite a bit of opportunity to tease apart what drives/hinders performance. I can unfold this into a JSON task, but getting sufficient density in a 4D space to draw conclusions could require a large number of problems. If there's a per-task wall-time budget, does that interfere with the authors of #372 getting their compute done? If a random subset of tasks are selected imbalance between JSON sizes might be problematic.
For reproducibility purposes, I'd want to keep the scripts used to generate the JSON in the repo.
@vyraun would also have to approve.

How do @sajantanand and coauthors feel? Also, there's a #419 now as well, also from @sajantanand. How does that fit in?

Hi all! Let me address what Richard has pointed out in his most recent comment.
(1) Our 'unit conversion' task #372 is a multiple choice task, so we are evaluating whether the model assigns the highest probability to the one possible answer that is correct. This is an all or nothing scoring system and doesn't allow for this relative error approach that Richard discussed.
(2) For each of our 5 subtasks, we are programmatically generating questions that fit within the confines of that subtask. At the moment, we have 5000 examples per subtask, but we can easily change this by regenerating task.json files.
(3) We have another 'unit_interpretation' task #419 that differs from both our previous task and Richard's and Vikas' task. Logistically, again it is a multiple choice task with three subtasks. This task asks word problems involving units that you might see in a basic physics class, such as: "36 seconds multiplied by 4 times per second is ()."; "A bell rings 2 times every hour. It will ring 48 times in () hours."; and "A car is driving at 6 miles per hour, and is 24 miles from destination. It is () hours from destination." These questions are significantly more difficult than pure unit conversion or arithmetic with unit conversion itself, as the model must first determine what arithmetic is needed based on the word problem.
We'd be happy to combine tasks wherever possible!

@aditya2211 are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

@nullstring are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

Great, thanks everyone for being flexible.  (also tagging @mathopus who is a reviewer for #372).  I think we would be happy with merging #275 and #372, if we can do this in a way that makes everyone happy.  It sounds like the main issue is adding the numerical comparison as a metric, which the BIG bench organizers have said they are happy to do.
@vyraun, are you okay with this merger?

@ramasesh yup, I am okay with the merger, given we have added support for numerical comparisons, as @r-barnes pointed out above.

@r-barnes and @vyraun, how would you like to merge the tasks? We can either chat here or exchange emails (possible set up a zoom call if that's easier). My email is<EMAIL_ADDRESS>(1) Did we determine whether individual subtasks can be scored differently? All of our subtasks must be scored with the Multiple Choice Metric comparing the predicted answer choice to the correct one.
(2) Are we going to include all the subtasks? Your second subtask on unit conversion is the one that overlaps with ours, as all other parts of your task is unit arithmetic, which we do not do at all.
(3) Richard, you mentioned that some of our used units are ambiguous. Do you remember which ones struck your eye? I can fix this ambiguity.
(4) We currently have 5k examples per subtask. Should we reduce this to alleviate computation load?

Sorry for the delay in replying, I have an out-of-town guest.
I'm in MST and can be free tomorrow (Sunday) or Monday evening for a discussion. Feel free to email me at<EMAIL_ADDRESS>If I don't hear back, I'll put together a PR merging #275 into #372.
Per your questions @sajantanand :

"Did we determine whether individual subtasks can be scored differently?" I think we can set up subtasks to do this; however, I don't think I saw a place where the organizers said they could add a relative numeric error metric (please link if I missed it). I might be able to figure out how to do this and add it to the PR.
I'll have to look at the tasks to develop an opinion here. It sounds like your number #419 is more mathematical. Perhaps dividing the tasks between these as appropriate?
I'll take a look tomorrow and try to remind myself.
I don't have a strong opinion here; the organizers seem to have a good computation budget and the inputs, at least, for these tasks are not too long.

"Did we determine whether individual subtasks can be scored differently?" I think we can set up subtasks to do this; however, I don't think I saw a place where the organizers said they could add a relative numeric error metric (please link if I missed it). I might be able to figure out how to do this and add it to the PR.

It would be great if you added this as a metric for json tasks!  It should be a fairly straightforward PR -- the changes would be similar to those for adding BLEURT:
https://github.com/google/BIG-bench/pull/343
https://github.com/google/BIG-bench/pull/437
Thank you for your submissions and hard work!

@Sohl-Dickstein : I've added a relative error metric in #459

@ramasesh : I've opened a PR on #372 to merge the unit conversion tasks.

Closing this PR in favour of #372 .

The amount of tasks we received this round is tremendous.  With so many tasks to review we have decided to extend the review period to Tuesday, June 29.
Reviewers: if the submitter has made revisions please be sure to notify me with a formal ”accept” or ”does not meet criteria” by Tuesday, June 29  (if you haven't already done so).
this is an automated message


Multiple PayPal checkout buttons not appearing correctly on page

Our website is hosted with BigCommerce, and I have noticed recently that our PayPal buttons do not all appear as expected on the cart page. The cart page has 3 locations where the button is supposed to appear.
Location 1: Mobile-only top location
Location 2: Desktop-only top location
Location 3: Mobile and Desktop bottom location
The buttons used to appear in all three locations as expected, but recently I've noticed that only Location 1 is appearing, and the other two locations do not show a button.
Is PayPal performing some sort of logic to prevent the button from appearing multiple times on a page? This is troublesome for us since we need the button to appear in multiple places. For example, here is the mobile layout, which works correctly since the mobile-only top location is the first one in the markup. The PayPal button appears correctly underneath the AmazonPay button:

However, there should also be a PayPal button in Location 3 underneath the Amazon button, but as you can see, it does not appear:

Additionally, on desktop, no PayPal buttons appear since desktop uses Location 2 and Location 3:

The website is https://www.storeyourboard.com. Just add a product to your cart to see the issue. Feel free to tinker around if needed. paypal.version says 4.0.224. Using Chrome Version 69.0.3497.100 (Official Build) (64-bit).

Anyone seeing this? The issues is still occurring.

Hi, can you please fill out an issue and answer all of the requested questions? Otherwise it's difficult for us to debug.


fix: deepzoom crash type error

This PR resolves []
Description
This PR fixes this sentry deepZoom type error crash that doesn't have huge impact but why not 😅

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

deepzoom crash type error - gkartalis

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (deepzoom crash type error - gkartalis)

  Generated by :no_entry_sign: dangerJS against ae508330b083cf77c1d6061f2162b835f7963a92


Elon musk and Mark Zuckerburg are censoring my Twitter and fb as well as messenger. Trying to spread Christian religious beliefs and messenger completely deleted the whole sentence with Jesus in it!!!

@githubteacher @carolynshin @brianamarie @crichID @JasonEtco @hectorsector @snyk-bot @


Can't read input from argv

Hi,
I wrote https://github.com/mactynow/drone-s3cache and it's working fine when I pass values from stdin. However when I try to add it to my pipeline I get the following error :
Traceback (most recent call last):
  File "/opt/drone/plugin/main.py", line 39, in <module>
    main()
  File "/opt/drone/plugin/main.py", line 13, in main
    payload = drone.plugin.get_input()
  File "/usr/lib/python2.7/site-packages/drone/plugin/input.py", line 23, in get_input
    payload_str = _get_input_from_stdin()
  File "/usr/lib/python2.7/site-packages/drone/plugin/input.py", line 38, in _get_input_from_stdin
    raise ValueError("No plugin input was found in argv or stdin.")
ValueError: No plugin input was found in argv or stdin.

I checked in https://github.com/drone/drone-python/blob/master/drone/plugin/input.py and it should work, except if drone doesn't pass its arguments after -- anymore... Any ideas?
If there is something that needs to be fixed I'll be happy to issue a PR.

From what I see, it's now passing everything as environment variables. Let me know if I'm wrong.

This is correct if you are running a version of Drone later than 0.4 (for which this library was made for). You probably don't need drone-python at all these days, since we're no longer parsing stdin/argv.

Alright, I'm running 0.5, that's why. Well, at least it generates the docs etc... so that's actually quite useful. I'm closing this, thanks!

@MacTynow

it generates the docs

you still need to write docs! 😛


Feature: Set up automated releases

Context
Releases are not currently being produced
Proposal
Add proper release production from CI via GH Actions.

[ ] Release a rust crate with cargo-release
[ ] Release the built .so & .control files as release artifacts

[ ] Support a matrix of:

[ ] arch (i.e. amd64, arm64/aarch64)
[ ] pg version (pg10,pg11,..,pg16)
[ ] libc (i.e. glibc, musl) (musl might not actually work for now...)

[ ] Release to pgxn (pgxn-release-shell-action or pgxn-action)

Alternatives
N/A
Additional Links
N/A

@t3hmrman I've tried to fork the repository to help out with this, but you're using a custom image for the container which I don't have permission to use.
I was going to try out creating the release with this action: Upload to Release Action. Let me know if I can helpyou any further.

Hey @natanchagas thanks for taking a look at this -- the CI image is the one you're referring to right?
It should be possible to build the CI image locally in your fork, but I think that workflow is somewhat painful like you noticed. To make it easier I need to publish the CI
Since in addition to the docker container this ticket actually contains stuff for publishing the crate, I think it might be better if I handle this one... In addition to making the CI image available more easily (so you can use it from your fork)

@natanchagas If you're still up for it, how do you feel about tackling https://github.com/VADOSWARE/pg_idkit/issues/8 ?
It should be possible to make progress on that (and add an action for it, for example) without access to any other images

Resolved by #53


Make filter configurable

What would you like to be added:
Make filter configurable
Why is this needed:
Filters should have standard configuration injection

close via #242


[Question] "this mod does not require Fabric API"

Hi. This is very useful. Do you plan a Forge version for 1.18.2 and 1.19.1 (When forge once get updated)?

Hey, thanks for asking.
I actually tried to port this mod to forge, but I couldn't get past the loading screen with the least descriptive error message ever.
So, there might be a forge version, if I find a way to fix this.

Forge version is now out: (1.18.2 only. For now)
https://modrinth.com/mod/rbip/version/0.6-1.18-forge
https://www.curseforge.com/minecraft/mc-mods/recipe-book-is-pain/files/3884622


Skip Windows Python 3.5 (instead of Python 3.6)

Should have the same effect in terms of packages generated. Though it fixes an issue where Python 3.5 was not deploying, but Python 3.6 would deploy.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


GSAGH-468-Problem-with-Analyse-component-and-a-clean-model

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (426353c) 89.9% compared to head (255aa96) 89.9%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #641   +/-   ##
=====================================
  Coverage   89.9%   89.9%
=====================================
  Files        486     486
  Lines      35877   35879    +2
  Branches    4494    4495    +1
=====================================
+ Hits       32267   32269    +2
  Misses      2410    2410
  Partials    1200    1200

Files
Coverage Δ

GsaGH/Helpers/Assembly/ModelAssembly.cs
84.5% <100.0%> (+<0.1%)
:arrow_up:


Travis iOS build failing

Building the iOS was failing for a Pull Request
https://github.com/vostpt/mobile-app/pull/65/checks?check_run_id=245752227

Solved in developer


chain switcher for developers

Issue: Coinbase Smart Wallet has no way to switch chain programmatically or within their settings UI.
Solution: Pass ?showChainSwitcher=true to url to see the current chain / switch chain dropdown.
Default:

Hover:

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Creation of record array from list of lists/tuples

Adds support for creating a record array from a list of tuples
a_b_type = np.dtype([('a', 'i8'), ('b', 'f8')], align=True)

@njit
def create():
    new = np.array([(1., 2.), (3., 4.)], a_b_type)
    return new

Thanks for the PR - marking as "in progress" whilst the tests are red - I've had a quick skim through the failures and I'm assuming it's due to the code and not a testing error, but let me know if you need a re-run.

@eric-wieser , thanks for the review. It's only my second time extending compiler passes, so all feedback is very welcome.
I addressed your comments, and added new tests.

@eric-wieser , I see your point about nested record arrays (above and in gitter). It would be nice to cover them. However, that would require a quite some change, because I would have to build a recursive function to deal with repeatedly nested fields, plus some way to deal with fields which are arrays.
I realized half-way through that this constructor is not so necessary because np.empty works and the user can fill the structure manually.
I think I'll park this PR for now, close the other more important ones that I have open and then return to this one and try to cover all cases.


feat(icon): change the svg for xs, s bacteria icons

Updates the svg for xs, s bacteria and closes #484

@masoudmanson can you check it out?


compactor occupies all threads in risedev d

Describe the bug
When running e2e with short barrier interval on a cluster started with risedev d, wait_epoch and heartbeat time out.
risedev d will not start separate compactor nodes and compactor is embeded in compute nodes. The issue is most likely to caused by compactor occupying all threads in the compute node after #2591 since I saw long running compactor tasks with many splits.
To Reproduce
git commit: 3a22be299fd326065577d0ee31a90f5ee1b8113c

Change the barrier interval to 30ms.
risedev d
./risedev slt -p 4566 "./e2e_test/v2/streaming_delta_join/*.slt" and ./risedev slt -p 4566 "./e2e_test/v2/streaming/*.slt"
Check the logs:

risingwave_rpc_client::meta_client: Failed to send_heartbeat: timeout deadline has elapsed
risingwave_storage::monitor::monitored_store: Failed in wait_epoch: Hummock error: Wait epoch error timeout

Expected behavior
Compactor should not occupies all threads when it is embeded in compute node and timeout should not happen.
Additional context
frontend-4566.log
meta-node-5690.log
risedev.log
compute-node-5688.log

@xxhZs found out the timeout issue when implementing concurrent checkpoint and realized that this issue also happened on main.
I was able to reproduce the heartbeat timeout but not the wait_epoch timeout.

cc @zwang28

Note that the issue doesn't only occur in embedded compactor scenario. compact_shared_buffer may encounter the same issue, when many splits can spawn many tasks.
Yielding compaction more frequently can fix this issue (reproduced and tested). The downside of this approach is a compaction may take more time, due to scheduling overhead. Though it's not measured accurately yet.
What do you think?

This commit https://github.com/singularity-data/risingwave/commit/8b52d0d691fd05a622292c227c9e9795255c2b1e might bring significant overhead, as we yield every time we add a new key. I would prefer to yield on block switch. For example, we can modify TableIterator to have a parameter "yield_on_block". Every time we seek to a new block in TableIterator, we force a yield.

Maybe related to this issue: https://github.com/singularity-data/risingwave/pull/2630

compact_and_build_sst only yield on block miss. So we'll have at most (#compaction_tasks x #splits) tokio tasks that seldom yields.
Note that the issue doesn't only occur in embedded compactor scenario. compact_shared_buffer may encounter the same issue, when many splits can spawn many tasks.
Yielding compaction more frequently can fix this issue (reproduced and tested). The downside of this approach is a compaction may take more time, due to scheduling overhead. Though it's not measured accurately yet.
What do you think?

Ideally, I think we need a separate thread pool for compaction task instead of mixing the compactor threads, actor threads, I/O threads to avoid doing the yielding tricks.

Ideally, I think we need a separate thread pool for compaction task instead of mixing the compactor threads, actor threads, I/O threads to avoid doing the yielding tricks.

What about putting crucial tasks in separate thread pool, e.g. pin_version, send_heartbeat?

What about putting crucial tasks in separate threads

I guess it won't be easy. Maybe we can consider having multiple tokio runtimes and investigate it a little bit now?

cc @wangrunji0408 expert on tokio runtime and scheduler


Add a feature that allows to listen to a given voice

Is your feature request related to a problem? Please describe.
I want to have speech recognition to have a command like pattern with an IoT device.
My app sends commands to the IoT device depending on the speech recognition.
But the speech recognition should only work to the owner of the smartphone that has the app installed on.
Describe the solution you'd like
The solution should be able to work offline (if possible). I don't want the smartphone to do internet requests, since I don't want to wait for the response to come back. I don't know enough AI, but I guess the expected solution would be to have an AI model that the user can train "quickly" and then, a specific function or some options passed to the start() method of SpeechRecognition should be able to recognize only the user voice thanks to the model trained.
Describe alternatives you've considered
Displaying a one-time code on the user app that the user should say for each voice command in order to authenticate its request. Arg, that's really not user friendly.

The feature could use that: https://github.com/alphacep/vosk-api (but does not seems to work for me rn)

This plugin uses the SDKs provided by Apple and Google as part of the OS, which don't have that feature.
There are no plans on integrating 3rd party speech recognition SDKs


Note section typo

The last sentence in the Note section for "Generate system-assigned managed identity" has a typo.
When you delete a service instance, the associated managed identity **will be deleted along.**

Recommend changing to:
When you delete a service instance, the associated managed identity will also be deleted.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9075f4a4-f8ca-9143-8998-41e2be0b39b8
Version Independent ID: 60c67249-9bd5-0a3c-10e3-839d44922d2e
Content: Managed identity - Azure Data Factory
Content Source: articles/data-factory/data-factory-service-identity.md
Service: data-factory
Sub-service: security
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@boclifton-MSFT
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Install quirk / Key illumination levels / Key consistency

Version
alpha4d
What is the issue?
1. LED remains lit after update and Shutdown
Shutdown via menu screen after install of Alpha4d.333
Current draw present with Bot LHS LED lit.
This is only for power down via menu shutdown after the firmware update, unplug and power up, and it does not repeat on the next shutdown.

2.No_Hi-light
The high brightness does not change from the previous (mid?) setting.
Incremental light levels from the low end but the top two are the same.
https://github.com/user-attachments/assets/68d6743d-6e88-4873-9c1d-c24235ee1e7b
3. No_Consistency
Inconsistent tones has two issues.

I can't get a button to repeat or another to replace it while it is sounding, its as though once triggered it holds on until the envelope is finished.
The buttons will trigger their LEDs without sounding for light touch, I have tried all the sensitivity ranges for a noise threshold of 21.
For the current firmware it doesn't function as a keyboard were you can just play nots reliably, which makes it not usable for live performances which has been requested elsewhere.
https://github.com/user-attachments/assets/0ebf6778-59ad-4021-8f67-db3088ed0455

Highlights should all be consistent. There are some places I previously set them as a constant, but I believe I have removed all constants and changed to the HighLight variable. I made sure to refresh the led buffer before the shutdown procedure finishes, so you shouldn’t see any more lights stuck on.
the other issues sounds like the note hanging/note tracking issue which has also been resolved for scales/classic.


Nuxt 3: Variable X is declared but its value is never read.ts(6133)

Hello,
I'm using Nuxt 3 + VS Code + Vue Language Features (Volar) + TypeScript Vue Plugin (Volar).
When I define variables within my script, Volar doesn't seem to recognize that I'm using those in my template.
Here is an Example. Menus.vue
<template>
    <AdminFormBuilder
        @isLoading="setIsLoading"
    >
        <template #form:before>
            <AdminCrudHeader
                :isLoading="isLoading"
            />
        </template>
    </AdminFormBuilder>
</template>

<script lang="ts" setup>
const isLoading = ref(false)
const setIsLoading = (value: boolean) => {
    isLoading.value = value
}
</script>

Hovering over setIsLoading tells me 'setIsLoading' is declared but its value is never read.ts(6133)

Duplicate of #1729

I met this too in Nuxt3.
After I refer to 1168#.
do:

then:
(In nuxt3 methods that do not need to import "Vue")


Says shortcode has no .Inner when it does

I have a short code read-more.html with the contents

    Click here to reveal text

    Click here to hide text

    {{ .Inner }}

However when I use the shortcode.
{{< read-more >}}
 ....
{{< /read-more >}}

I get this error
ERROR: 2016/02/24 Shortcode 'read-more' in page '...' has no .Inner, yet a closing tag was provided
If I leave off the closing tag than Hugo simply inserts read-more.html and ignores the {{.Inner}} variable. I've tried moving {{.Inner}} around and interacting with it in different ways but always either doesn't recognize it or ignores it if I leave off the closing tag.

As I cannot reproduce this neither understand how on earth this check could fail, there must be something else in play.

What is the output of hugo version?
What OS?

The failing project; is it in the open on GitHub? If not, can you put a minified failing version out there for me to look at?

version: Hugo Static Site Generator v0.15 BuildDate: 2015-11-25T07:35:21-07:00
OS: Ubuntu 14.04
I created a new project to try to reproduce the error but it worked correctly in the new project.
Then, after in worked in the test project and without any changes, it started working in the original project.
Something weird is going on but I have no idea what it is.
You can find the project here
here is the shortcode file
here is the markdown page that was failing
But it started working so idk what to tell you or if you even want to look at it.

As I said, I have no clue -- my best guess is that the error message is wrong, that "something else" was going on -- because the "inner check" is a pretty standard regexp.

Alright, I'll mark it as closed. If I find a way to reproduce it I'll open a new issue with instructions on how to reproduce it.

For me, fixing this issue was as simple as restarting the hugo server I had running.

This still happens: if you add a short code while the server is running, it's picked up incorrectly and causes the error above. Restarting the server helps

This is happening for me too. Hugo Static Site Generator v0.16-DEV BuildDate: 2016-02-06T17:14:17Z
I was running the server with "hugo server -ws ."

Then I added a shortcode to a page which didn't yet exist (e.g. {{% warning %}}This is a **Warning!**{{% /warning %}}
Then added the definition for the shortcode in the theme which was being used (themes/<themeName>/shortcodes/warning.html)  - e.g.

  Warning! {{ .Inner }}

That's when I got this error ERROR: 2016/12/01 16:11:51 shortcode.go:266: Shortcode 'warning' in page 'overview/access-keys.md' has no .Inner, yet a closing tag was provided
Restarting hugo fixed it.

Please don't comment on old issues, and esp. not if you use an ancient Hugo version.


Use shell built-in case to determine toolkit version

In Dockerfile_binary_openvino, the use of pwd piped to grep and checking
grep's result code is here replaced with a simple shell native case
instead. This increases readability and maintainability; should there be
difference between toolkit version it is quite simple to extend the
case. (A bonus is increased performance by using shell natives, even if
that is hardly noticable on a modern computer.)
Fixes #39
Change-Id: I40ad3ac1e98c45e8b197498130412ebe8f03705a
Signed-off-by: Joakim Roubert<EMAIL_ADDRESS>

those changes will be included in PR https://github.com/IntelAI/OpenVINO-model-server/pull/36
but components are configured only for the releases 2019*
The reason is that in 2019 there were introduced changes which makes the dockerfiles incompatible with older binary releases.


Serialiser is not interchangeable

The class has two attributes 'serialize' and 'deserialize'.  The documentation says the consumer can assign their own choice for serialisation, but this stopped being true upon v2.
The most practical choices for serialisers used also do the writing, so it's not practical to have them swappable.  And there might be a performance cost going through that level of redirection.
I'm more interested in making the class easily sub-classable (if it isn't already).  I have two other backends I want/need to try out, so this should be put to the test soon.

The two attributes have been removed as of v5.09


Expected output tests for codegen bugs

Nice! Combining this with https://github.com/elm-lang/elm-compiler/pull/1134 because I can't rebase on this PR for some reason.


Error in Creating Domain: missing DOMAIN_HOME directory '/u01/oracle/user_projects/domains/sample-domain1'

Hi,
I am following "Quick Start" in the documentation https://oracle.github.io/weblogic-kubernetes-operator/quickstart/
All the steps till "Prepare for a Domain" works fine.
During "Create a Domain", I am getting error. When I see "sample-domain1-ns", the pod sample-domain1-introspect-domain-job-xxxx  showing status as "Terminated: Error"
In the logs, I find following line at the end:
Error: missing DOMAIN_HOME directory '/u01/oracle/user_projects/domains/sample-domain1'.
To investigate, I have run the build.sh separately to create and tag the image. By adding extra commands in Dockerfile, I see that the above domain directory is created and there in the image.
Please advise how to make it work.
I am running the steps from a OEL7 vm on OCI.
Regards.
sibendu

Here is the my-input.yaml. I had built the image separately by running  ./docker-images/OracleWebLogic/samples/domain-home-in-image/build.sh and pushed to my docker hub account.
Copyright 2018, 2019, Oracle Corporation and/or its affiliates.  All rights reserved.
Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
The version of this inputs file.  Do not modify.
version: create-weblogic-sample-domain-inputs-v1
Port number for admin server
adminPort: 7001
Name of the Admin Server
adminServerName: admin-server
Unique ID identifying a domain.
This ID must not contain an underscope ("_"), and must be lowercase and unique across all domains
in a Kubernetes cluster.
domainUID: sample-domain1
Determines which WebLogic Servers the operator will start up
Legal values are "NEVER", "IF_NEEDED", or "ADMIN_ONLY"
serverStartPolicy: IF_NEEDED
Cluster name
clusterName: cluster-1
Number of managed servers to generate for the domain
configuredManagedServerCount: 5
Number of managed servers to initially start for the domain
initialManagedServerReplicas: 2
Base string used to generate managed server names
managedServerNameBase: managed-server
Port number for each managed server
managedServerPort: 8001
Boolean indicating if production mode is enabled for the domain
productionModeEnabled: true
WebLogic Server Docker image that the operator uses to start the domain.

The create domain scripts generate a WebLogic Server Docker image with a domain home in it.
By default, the scripts tag the generated WebLogic server Docker image as either
domain-home-in-image or domain-home-in-image-wdt based on the domainHomeImageBuildPath
property, and use it to set the image element in the generated domain YAML file.

If this property is set, the create domain scripts will use the value specified, instead of the
default value, to tag the generated image and set the image in the domain YAML file.

A unique value is required for each domain that is created using the scripts.

If you are running the sample scripts from a machine that is remote to the Kubernetes cluster where
the domain is going to be running, you need to set this property to the image name that is intended
to be used in a registry local to that Kubernetes cluster. You also need to push the image to
that registry before starting the domain using the kubectl create -f or kubectl apply -f command.
See README.md for more help.
image: sibendudas/weblogic:<IP_ADDRESS>
Image pull policy
Legal values are "IfNotPresent", "Always", or "Never"
imagePullPolicy: IfNotPresent
Name of the Kubernetes secret to access the Docker Store to pull the WebLogic Server Docker image
The presence of the secret will be validated when this parameter is enabled.
#imagePullSecretName:
Name of the Kubernetes secret for the Admin Server's username and password
The name must be lowercase.
If not specified, the value is derived from the domainUID as -weblogic-credentials
weblogicCredentialsSecretName: sample-domain1-weblogic-credentials
Whether to include server .out to the pod's stdout.
The default is true.
includeServerOutInPodLog: true
Specifies whether the log home is stored on the persistent volume.
If set to true, then you must specify the 'logHome', 'persistentVolumeClaimName'
and 'domainPVMountPath' properties.
The default is false.
logHomeOnPV: false
The in-pod location for domain log, server logs, server out, and node manager log files
If not specified, the value is derived from the domainUID as /shared/logs/
This parameter is required if 'logHomeOnPV' is true.
Otherwise, it is ignored.
logHome: /shared/logs/domain1
Port for the T3Channel of the NetworkAccessPoint
t3ChannelPort: 30012
Public address for T3Channel of the NetworkAccessPoint.  This value should be set to the
kubernetes server address, which you can get by running "kubectl cluster-info".  If this
value is not set to that address, WLST will not be able to connect from outside the
kubernetes cluster.
#t3PublicAddress:
Boolean to indicate if the channel should be exposed as a service
exposeAdminT3Channel: false
NodePort to expose for the admin server
adminNodePort: 30701
Boolean to indicate if the adminNodePort will be exposed
exposeAdminNodePort: false
Name of the domain namespace
namespace: sample-domain1-ns
Java Option for WebLogic Server
javaOptions: -Dweblogic.StdoutDebugEnabled=false
Name of the persistent volume claim
If not specified, the value is derived from the domainUID as -weblogic-sample-pvc
This parameter is required if 'logHomeOnPV' is true.
Otherwise, it is ignored.
persistentVolumeClaimName: domain1-weblogic-sample-pvc
Mount path of the domain persistent volume.
This parameter is required if 'logHomeOnPV' is true.
Otherwise, it is ignored.
domainPVMountPath: /shared
Base WebLogic binary image used to build the WebLogic domain image
The operator requires WebLogic Server <IP_ADDRESS>.0 with patch 29135930 applied.
The WebLogic Docker image, weblogic:<IP_ADDRESS>, has all the necessary patches applied.
Refer to WebLogic Docker images for details on how
to obtain or create the image.
See README.md for more help.
domainHomeImageBase: container-registry.oracle.com/middleware/weblogic:<IP_ADDRESS>
Location of the WebLogic "domain home in image" Docker image sample in the
https://github.com/oracle/docker-images.git project.
If not specified, use "./docker-images/OracleWebLogic/samples/12213-domain-home-in-image".
Another possible value is "./docker-images/OracleWebLogic/samples/12213-domain-home-in-image-wdt",
which uses WDT, instead of WLST, to generate the domain configuration.
domainHomeImageBuildPath: ./docker-images/OracleWebLogic/samples/12213-domain-home-in-image

Here is the my-input.yaml. I had built the image separately by running ./docker-images/OracleWebLogic/samples/domain-home-in-image/build.sh and pushed to my docker hub account.

Here is the my-input.yaml  (extension changed to .txt).
I had built the image separately by running ./docker-images/OracleWebLogic/samples/domain-home-in-image/build.sh and pushed to my docker hub account. During docker build, it seems the domain_home folder is present in the image.
my-inputs.yaml.txt

Thank you. The image and other details in domain.yaml is correct. As I restart the domian with kubectl apply -f domaijn.yaml; the pods are up and running.
However I am unable to access the WLS console.  I tried by port-forward the admin server pod for 7001/ 30701 , but none of this seems working.

Are you not able to bring up the WLS console login page at all? Please check that you have created your domain with exposedAdminNodePort: true in your my-inputs.yaml. After the domain has started, verify that a node port type service has been created for the admin server, such as:
sample-domain1-admin-server-external   NodePort    <IP_ADDRESS>           7001:30701/TCP       29s
Could you provide more details on the environment and network setup that you kubernetes cluster is running on so we could provide better help? Thanks!

I am using OKE. With exposedAdminNodePort: true, it exposed the NodePort; and I am able to configure Load balancer to access the console. Thank you. I am closing this.

I am using OKE. With exposedAdminNodePort: true, it exposed the NodePort; and I am able to configure Load balancer to access the console. Thank you. I am closing this.


propagate status code from resolver

fixes https://github.com/hyperledger/firefly/issues/1167

Closing this while we find a better solution


Why use SSH to clone this repository?

I used the git clone command to clone this repository by HTTPS to my catkin workspace, and an error occurred during compilation.
Later, I followed the prompts in the README and used SSH to clone this repository. The package can be compiled correctly.
I want to know what is the difference between using HTTP cloning and SSH cloning?

There should be no difference. Could you have missed the  --recursive flag the first time when you were cloning with HTTPS?

I did miss this parameter.
What is the role of this parameter? If this parameter is not used, will the repository be missing some files?

This repository contains a submodule, that's like another repository in this repository. The --recursive flags indicates that git should clone these sub repositories too.


Change the way to create ConfigMap

closes #9849
kubectl doesn't support creating configmaps using urls. https://github.com/kubernetes/kubernetes/issues/64007#issuecomment-390141844
This PR changes the way to create example ConfigMap.

/lgtm

preview is here
original

/approve


Post deployment trigger

Hello,
First, I want to thank you for your contribution to the GitOps Ecosystem.
Just want to know, if we can use this operator in order to trigger post-deployment action.
For example, once a deployment is achieved by Flux, I want another deployment to take place.
Thanks in advance.

For example, once a deployment is achieved by Flux, I want another deployment to take place.

Yes, this is covered by https://github.com/fluxcd/kustomize-controller/blob/master/docs/spec/v1alpha1/kustomization.md#kustomization-dependencies

Thank you, Stefan, for getting back to me
I started experimenting with the new gitops toolkit and I must admit that it's really cool!
I'm targeting the following use case:

Deployment A: a new rollout update
Workload B (Example: Tekton pipeline that will update an API GW once the Deployment A is rolled out )  (K8S manifests unchanged in Git)

I'm afraid customization dependencies won't suit this use case.
Side question: is it on your radar to implement deployment sync based on image tags like the old Flux
Thanks

is it on your radar to implement deployment sync based on image tags like the old Flux

Yes, the image update controller is listed on our roadmap here https://toolkit.fluxcd.io/roadmap/#flux-image-update-feature-parity


Testing

Do you plan on added testing to your mapping programs, maybe something similar to https://github.com/Team-ALGO2/ALGO2/blob/master/Final/tests/unittest.c#L19-L84.
This would allow for easier collaboration and more confidence when pushing a new commit or PR.

I will probably add testing once I finish the other two algorithms. Currently this project is low-priority.


CONTRIBUTING.md guideline file missing

I wasn't able to find a CONTRIBUTING.md file with contributing guidelines for Draft - I've usually seen them at the root of repositories. There is a 'contributing' folder in the draft repo, but no real contributing guidelines that I've found. Could we look at adding something?

Yes that sounds like a great idea. I've actually started taking a stab at restructuring the documentation into a website in #770 that centralizes around a few core concepts including a contributing guide. We can reference to that in CONTRIBUTING.md once it's done. For now @raravena80's PR in #797 should be a good starting place to work on how we wanna shape the CONTRIBUTING docs.
Does that sound like something you'd be interested in influencing? :)

@bacongobbler I'd love to help however I can! I see you have #801 open now to at least knock this issue out. Should we close it and follow up there? Thanks for your help here!

This needs to be closed @bacongobbler - #801 sorted it.

We generally close issues once the PR has been merged; that way if we need to close PRs in favour of another or back it out we can continue to track it here. Makes it easier to triage :)

But yes once #801 is merged this issue will automatically close. :)


ensure we use nightly with fmt

Pull Request Test Coverage Report for Build 190222376

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.849%

Totals

Change from base Build 190172507:
0.0%

Covered Lines:
4440

Relevant Lines:
4834

💛  - Coveralls


Cannot install "Microsoft C++ Build Tools" is requred

pip install -r requirements.txt
`Collecting beautifulsoup4==4.9.1
Using cached beautifulsoup4-4.9.1-py3-none-any.whl (115 kB)
Collecting lxml==4.6.3
Using cached lxml-4.6.3.tar.gz (3.2 MB)
Preparing metadata (setup.py) ... done
Requirement already satisfied: pyotp==2.4.0 in c:\users\makma\appdata\local\programs\python\python311\lib\site-packages (from -r requirements.txt (line 3)) (2.4.0)
Requirement already satisfied: python-dotenv==0.14.0 in c:\users\makma\appdata\local\programs\python\python311\lib\site-packages (from -r requirements.txt (line 4)) (0.14.0)
Requirement already satisfied: selenium==3.141.0 in c:\users\makma\appdata\local\programs\python\python311\lib\site-packages (from -r requirements.txt (line 5)) (3.141.0)
Requirement already satisfied: soupsieve==2.0.1 in c:\users\makma\appdata\local\programs\python\python311\lib\site-packages (from -r requirements.txt (line 6)) (2.0.1)
Requirement already satisfied: urllib3==1.25.10 in c:\users\makma\appdata\local\programs\python\python311\lib\site-packages (from -r requirements.txt (line 7)) (1.25.10)
Building wheels for collected packages: lxml
Building wheel for lxml (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [74 lines of output]
Building lxml version 4.6.3.
Building without Cython.
Building against pre-built libxml2 andl libxslt libraries
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-cpython-311
creating build\lib.win-amd64-cpython-311\lxml
copying src\lxml\builder.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\cssselect.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\doctestcompare.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\ElementInclude.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\pyclasslookup.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\sax.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\usedoctest.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml_elementpath.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml_init_.py -> build\lib.win-amd64-cpython-311\lxml
creating build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes_init_.py -> build\lib.win-amd64-cpython-311\lxml\includes
creating build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\builder.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\clean.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\defs.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\diff.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\ElementSoup.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\formfill.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\html5parser.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\soupparser.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\usedoctest.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html_diffcommand.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html_html5builder.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html_setmixin.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html_init_.py -> build\lib.win-amd64-cpython-311\lxml\html
creating build\lib.win-amd64-cpython-311\lxml\isoschematron
copying src\lxml\isoschematron_init_.py -> build\lib.win-amd64-cpython-311\lxml\isoschematron
copying src\lxml\etree.h -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\etree_api.h -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\lxml.etree.h -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\lxml.etree_api.h -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\includes\c14n.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\config.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\dtdvalid.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\etreepublic.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\htmlparser.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\relaxng.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\schematron.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\tree.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\uri.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xinclude.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xmlerror.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xmlparser.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xmlschema.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xpath.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xslt.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes_init_.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\etree_defs.h -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\lxml-version.h -> build\lib.win-amd64-cpython-311\lxml\includes
creating build\lib.win-amd64-cpython-311\lxml\isoschematron\resources
creating build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\rng
copying src\lxml\isoschematron\resources\rng\iso-schematron.rng -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\rng
creating build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl
copying src\lxml\isoschematron\resources\xsl\RNG2Schtrn.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl
copying src\lxml\isoschematron\resources\xsl\XSD2Schtrn.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl
creating build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_abstract_expand.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_dsdl_include.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_schematron_message.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_schematron_skeleton_for_xslt1.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_svrl_for_xslt1.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\readme.txt -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
running build_ext
building 'lxml.etree' extension
error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for lxml
Running setup.py clean for lxml
Failed to build lxml
Installing collected packages: lxml, beautifulsoup4
Running setup.py install for lxml ... error
error: subprocess-exited-with-error
× Running setup.py install for lxml did not run successfully.
│ exit code: 1
╰─> [76 lines of output]
Building lxml version 4.6.3.
Building without Cython.
Building against pre-built libxml2 andl libxslt libraries
running install
C:\Users\makma\AppData\Local\Programs\Python\Python311\Lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_py
creating build
creating build\lib.win-amd64-cpython-311
creating build\lib.win-amd64-cpython-311\lxml
copying src\lxml\builder.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\cssselect.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\doctestcompare.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\ElementInclude.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\pyclasslookup.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\sax.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\usedoctest.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml_elementpath.py -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml_init_.py -> build\lib.win-amd64-cpython-311\lxml
creating build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes_init_.py -> build\lib.win-amd64-cpython-311\lxml\includes
creating build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\builder.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\clean.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\defs.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\diff.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\ElementSoup.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\formfill.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\html5parser.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\soupparser.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html\usedoctest.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html_diffcommand.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html_html5builder.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html_setmixin.py -> build\lib.win-amd64-cpython-311\lxml\html
copying src\lxml\html_init_.py -> build\lib.win-amd64-cpython-311\lxml\html
creating build\lib.win-amd64-cpython-311\lxml\isoschematron
copying src\lxml\isoschematron_init_.py -> build\lib.win-amd64-cpython-311\lxml\isoschematron
copying src\lxml\etree.h -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\etree_api.h -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\lxml.etree.h -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\lxml.etree_api.h -> build\lib.win-amd64-cpython-311\lxml
copying src\lxml\includes\c14n.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\config.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\dtdvalid.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\etreepublic.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\htmlparser.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\relaxng.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\schematron.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\tree.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\uri.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xinclude.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xmlerror.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xmlparser.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xmlschema.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xpath.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\xslt.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes_init_.pxd -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\etree_defs.h -> build\lib.win-amd64-cpython-311\lxml\includes
copying src\lxml\includes\lxml-version.h -> build\lib.win-amd64-cpython-311\lxml\includes
creating build\lib.win-amd64-cpython-311\lxml\isoschematron\resources
creating build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\rng
copying src\lxml\isoschematron\resources\rng\iso-schematron.rng -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\rng
creating build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl
copying src\lxml\isoschematron\resources\xsl\RNG2Schtrn.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl
copying src\lxml\isoschematron\resources\xsl\XSD2Schtrn.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl
creating build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_abstract_expand.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_dsdl_include.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_schematron_message.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_schematron_skeleton_for_xslt1.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\iso_svrl_for_xslt1.xsl -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
copying src\lxml\isoschematron\resources\xsl\iso-schematron-xslt1\readme.txt -> build\lib.win-amd64-cpython-311\lxml\isoschematron\resources\xsl\iso-schematron-xslt1
running build_ext
building 'lxml.etree' extension
error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> lxml
note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.`

I'm no longer going to update this repository. Please use this new and improved one that makes use of the Epic Games desktop app rather than logging in via the browser:
https://github.com/MasonStooksbury/Free-Games-V2


Bug: correct global z-index fix

Describe the bug
Z-index needs to be applied to positioned top-level containers in the order of overlap:

header: 3
content: 2
footer: 1

Some of the items that exist, that are positioned inside the above containers, like the avatar image, need to also be fine-tuned when hard-coding them wasn't needed.
Steps to reproduce

Go to https://hot.opensauced.pizza
Hover over the middle hot repo
It should overlap the content and look like this:

Affected services
hot.opensauced.pizza
Platforms
No response
Browsers
No response
Environment
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

A lot of these elements conflicting with the z-index have been removed in the new design. We may be good on this, and can potentially close it.

A lot of these elements conflicting with the z-index have been removed in the new design. We may be good on this, and can potentially close it.

Agreed, if we run into future z-index requirements, the above pattern should be kept, having z-index on the top-most container elements so the children components can successfully overlap markup that is outside of the container viewport! 🍕 🚀


spring cloud bus id spell bug

Describe the bug
If server.port is not written in application.yml, bus id = applicationName:0:random, this code should take the default value of server.port 8080.
If you write server.port in application.yaml, bus id = applicationName:port:random
bug code position:
org.springframework.cloud.bus.ServiceMatcherAutoConfiguration#serviceMatcher
ServiceMatcher serviceMatcher = new ServiceMatcher(pathMatcher, properties.getId(), configNames);

If server.port is not written in application.yml, bus id = applicationName:0:random, this code should take the default value of server.port 8080.

Why?

spring boot container set server.port is 8080，not 0 。why take 0？

I am just wondering if the fact it is 0 is causing something to not work?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

org.springframework.cloud.bus.BusAutoConfiguration
@EventListener(
classes = {RemoteApplicationEvent.class}
)
public void acceptLocal(RemoteApplicationEvent event) {
if (this.serviceMatcher.isFromSelf(event) && !(event instanceof AckRemoteApplicationEvent)) {
if (log.isDebugEnabled()) {
log.debug("Sending remote event on bus: " + event);
}
        this.cloudBusOutboundChannel.send(MessageBuilder.withPayload(event).build());
    }

}

when application.yml without server.port
as the code。the event object‘s bus id is application:8080:random，but the serviceMatcher's bus id is application:0:random
when application.yml config server.port is 8080
the event object's bus id is application:8080:random，the serviceMatcher's bus id is application:8080:random

Could you describe the problem that manifests as a result of this?  Or better yet provide a sample that reproduces the problem?  This code has been like this for a long time so I am hesitant to change it.

I'm sorry for not describing the problem clearly because of my poor English.Next, I will describe the problem with the help of Google Translate。（Source language: Chinese）
Step 1: If there is no server in application.yml Port, then the bus id will be application: 0: random
Step 2: The spring container does not have application.yml and does not configure server.port without specifying the listening port. It will listen to port 8080 by default
Step 3: When I use spring cloud bus (the spring container is initialized), I will get the server.port 8080 from the spring container
Step 4, because the ID of spring cloud bus is obtained during initialization The port is empty, so the default is 0. Because the two IDs are inconsistent, when sending a bus event, it is found that the event was not sent by itself, resulting in the event cannot be sent through the spring cloud stream.
The causes of the bug are as follows:

Because the spring cloud bus id is initialized in BusEnvironmentPostProcessor

public static final String DEFAULT_SERVICE_ID_STRING = "${vcap.application.name:${spring.application.name:application}}:${vcap.application.instance_index:${spring.application.index:${local.server.port:${server.port:0}}}}:${vcap.application.instance_id:${cachedrandom.${vcap.application.name:${spring.application.name:application}}.value}}";

When EnvironmentPostProcessor is called by the Spring container, server.port has not been assigned the default value of 8080 by spring. Therefore, the spring cloud bus id will be application: 0: random

If server.port is configured in application.yml, there will be server only when BusEnvironmentPostProcessor is executed If the port is not empty, the spring cloud bus id will be application: server. port: random

4.I don't want to submit the code, because it is too troublesome, so I bother you

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

I want to explain that when you get the ${server. port} configuration item, it does not match the spring life cycle. It should not be obtained at EnvironmentPostProcessor, because it cannot be obtained at this time

Boot sets the default 8080 here https://github.com/spring-projects/spring-boot/blob/f2294babaf50710a90af1c02a630202afecc94d2/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/server/AbstractConfigurableWebServerFactory.java#L44


fest

Hey @hungster, thanks for the PR but I think you misunderstood the open issues.  The Readme is fine as is. Feel free to add more items to x.txt and y.txt


mod Files

Hi! Really appreciate you remaking this mod and sorry for creating an issue for a useless question but i dont know how to use Github however, when i download the mod from Fabric 1.20 i get a file which im not sure where i should put it. Can you assist please? Thanks!

Same as other mods: put it to a folder named mods in your game files.

Thats what i did the first time as it seemd pretty intuitive however i dont see the changes in the game,

Get the mod as a .jar file, please DO NOT extract it.

the files comes in a Jar extension which i just change to .jar, yet no changes. Am I missing something?

Any ideas?

@VindicateS1 If you downloaded the source code, that is why it's not working. Download the actual jar file from the github repository and then it should work just fine.

The only file i downloaded is the Jar file from the main page:

Am I missing a menu? @DatrixTHLK2024

@VindicateS1 If you look at your previous comment on this you mentioned the fact you changed the zip file into a jar file.  If so, the jar file is the correct file and you needn't download anything else for it to work. Unfortunately, I can't tell you whether it works or not seeing as how I can't seem to get it to work on 1.20.4 of fabric 0.15.7...Sorry about that...


Textfield initialization through this.refs.form.reset(model) fix.

Looks good, please go ahead an merge.


Enforce a size limit on StringSetData

Fix #32649

Make StringSetData set mutable. This avoids copy and create new ImutableSet every time

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Tested TextIOIT: write then read 100,000 files

user counter elements_read 3,754,869, should be 100,000,000, counter still dropped after overall stringset grows

"Elements added 100,000" and job progress both works when job running

It has

WARNING 2024-10-04T03:25:05.938Z StringSetData reaches capacity. Current size: 100023, last element size: 77. Further incoming elements will be dropped.

warning log.
Dataflow job id: 2024-10-03_20_11_47-11842727745111768860

After more testing changed the cap to be 1 MB. This should be good for ~10k number of elements.
also tested on a simple pipeline GenerateSequence->Report LIneage on every element
HEAD (jobid: 2024-10-04_06_15_24-8505055598897377194)
throughput, several hundreds elements / s, cloud profiler shows stringset add takes most of time:

This PR (job id: 2024-10-04_06_23_39-4373466717598467131)
pipeline finishes immediately:

Saw log:
StringSetData reaches capacity. Current size: 1000004, last element size: 58. Further incoming elements will be dropped.

confirm the cap is effective.
user counter work: elements_read	1,000,000

Can we move the size enforcement to Lineage class rather than forcing it for a particular metric type only which makes it inconsistent with others?

Found actually this is impossible. Lineage is a wrapper of StringSet, whose actual implementation is DelegateStringSet, backed by runner's StringSetData. In Lineage class there is no visibility of the current stringset size, and even if we add track (e.g. a static int) of how many strings we put into Lineage, we do not know the current set size as we do not know if the newly added element already exist in the set

Can we move the size enforcement to Lineage class rather than forcing it for a particular metric type only which makes it inconsistent with others?

Found actually this is impossible. Lineage is a wrapper of StringSet, whose actual implementation is DelegateStringSet, backed by runner's StringSetData. In Lineage class there is no visibility of the current stringset size, and even if we add track (e.g. a static int) of how many strings we put into Lineage, we do not know the current set size as we do not know if the newly added element already exist in the set

Thank you for considering and exploring this.  This seem like correct description of current implementation. We can incrementally add more to support the above need.
Here is what I am thinking,
StringSet can expose a an API size() which gives the current size of StringSet metric. This will of course be backed by DelegateStringSet and runner's StringSetData. This will allow Lineage class to get visibility into the current size. Based on the current size Lineage class enforce a limit. Generically other consumer/user who uses StringSet metric might want to know the current size of the Set.
At large beside the two points mentioned in (https://github.com/apache/beam/pull/32650#discussion_r1788181568) I believe a better design will be to have StringSet metric expose APIs and feature enabling consumers such as Lineage to use the metric for their use cases (in this case size limit) (bottom up) rather than top down wherein the use case of consumer is built in the metric itself. We want the beam's core metric to be generic.
Also the size limit of metric is a Dataflow specific limitation based of limit of ReportWorkItem/GFE. Other runner might or might not have it. We should avoid coupling it with Beam's core metric.

Other runner might or might not have it. We should avoid coupling it with Beam's core metric

Though didn't get into it, I suspect there is a limit not limited to Dataflow. Under portable framework where runner API backed by grpc messages, then when client query for job status, the response size should have certain limit

Other runner might or might not have it. We should avoid coupling it with Beam's core metric

Though didn't get into it, I suspect there is a limit not limited to Dataflow. Under portable framework where runner API backed by grpc messages, then when client query for job status, the response size should have certain limit

That makes sense.

WDYT of breaking this PR in two parts:

Making StringSetData set mutable
Size limit enforcement (This can go in later separately)

WDYT of breaking this PR in two parts:

Making StringSetData set mutable
Size limit enforcement (This can go in later separately)

Yeah this PR essentially contains two fix, corresponding to two related issues in #32649. Mutable set will fix slowness.
However we still need limit enforcement to fix metrics breakage. Even with #32662 in the metrics system will still break for FileIO read patterns like gs://bucket/folder/**/some_data.txt so I think both fix is needed for the current release

WDYT of breaking this PR in two parts:

Making StringSetData set mutable
Size limit enforcement (This can go in later separately)

Yeah this PR essentially contains two fix, corresponding to two related issues in #32649. Mutable set will fix slowness. However we still need limit enforcement to fix metrics breakage. Even with #32662 in the metrics system will still break for FileIO read patterns like gs://bucket/folder/**/some_data.txt so I think both fix is needed for the current release

Yes correct, I was thinking we can submit Making StringSetData set mutable today but it is upto you if you want to keep them together.

Can we do the minimal here to unblock Beam 2.60.0? Later, we can keep improving.

Please update CHANGES.md to mention the impacted Beam versions by this issue. @Abacn

Please update CHANGES.md to mention the impacted Beam versions by this issue. @Abacn

Did in #32664. The issue was introduced in Beam 2.59.0

Can we move the size enforcement to Lineage class rather than forcing it for a particular metric type only which makes it inconsistent with others?

Found actually this is impossible. Lineage is a wrapper of StringSet, whose actual implementation is DelegateStringSet, backed by runner's StringSetData. In Lineage class there is no visibility of the current stringset size, and even if we add track (e.g. a static int) of how many strings we put into Lineage, we do not know the current set size as we do not know if the newly added element already exist in the set

Thank you for considering and exploring this. This seem like correct description of current implementation. We can incrementally add more to support the above need.
Here is what I am thinking, StringSet can expose a an API size() which gives the current size of StringSet metric. This will of course be backed by DelegateStringSet and runner's StringSetData. This will allow Lineage class to get visibility into the current size. Based on the current size Lineage class enforce a limit. Generically other consumer/user who uses StringSet metric might want to know the current size of the Set.
At large beside the two points mentioned in (#32650 (comment)) I believe a better design will be to have StringSet metric expose APIs and feature enabling consumers such as Lineage to use the metric for their use cases (in this case size limit) (bottom up) rather than top down wherein the use case of consumer is built in the metric itself. We want the beam's core metric to be generic.
Also the size limit of metric is a Dataflow specific limitation based of limit of ReportWorkItem/GFE. Other runner might or might not have it. We should avoid coupling it with Beam's core metric.

We discussed this offline.
Here is the summary of the discussion for future.
If size is exposed based on the StringSetData then the size will be for that specific bundle since  one metric may have multiple metrics containers (backed by different stringsetdata). This can confuse user if exposed a api level and also breaks the abstraction which Beam as a programming model strives to provide.
The current size enforcement also has this issue but since it is not exposed to user to consume. the stringsetdata limit happens to work with FileIO because currently FileIO report source and sink metrics in a loop, so it happens to write to single metrics container on a single worker. Hence the size enforcement is tied to FileIO implementation. So this is not an ideal fix but we need to solve the FileIO large file issue somehow.
I will propose to drop the limit enforcement on string set completely in anyway. We will limit the number of reported files in FileIO itself to ensure we do not hit it. This will avoid FileIO implication and implementation being tied to a metric type.
See comment. https://github.com/apache/beam/pull/32662#issuecomment-2400436239


Fix up API endpoints config

For https://github.com/kubernetes-incubator/kube-aws/issues/520. loadBalancer was missing entirely.
Not sure where to put worker.apiEndpointName, does it default to anything? I'd like to resolve this documentation issue in the same PR as worker.apiEndpointName is not listed in the default cluster.yaml:
Error: Failed to initialize cluster driver: file cluster.yaml: worker.apiEndpointName must not be empty when there're 2 or more API endpoints under the key `apiEndpoints` and one of worker.nodePools[] are missing apiEndpointName

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   38.15%   38.15%
=======================================
  Files          44       44
  Lines        3108     3108
=======================================
  Hits         1186     1186
  Misses       1728     1728
  Partials      194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae49569...6b25111. Read the comment docs.

@c-knowles Thanks for the fix!
Regarding worker.apiEndpointName, it defaults to the only API endpoint if omitted. If it was omitted when apiEndpoints has 2 or more items, a validation error occurs.

@mumoshu ok I've added those details.
I was trying to come up with idea to better document the configuration, I feel the current method is becoming unwieldy and difficult to read. My last commit is one idea, feel free to remove it before merge or I can. The idea is we would remove a lot of the comments from cluster.yaml and place them in structured markdown instead for an easier to digest form. cluster.yaml could still contain a skeleton plus some defaults. Another idea is I could setup some better documentation using a github static site generator or whatever they use for the new kube API reference.

p.s. if you like any of the ideas, I can pick up a task to migrate everything across including any PRs in flight.

@c-knowles Thanks for the suggestion!
I like the idea of writing a documentation dedicated for explaining cluster.yaml but I'd basically like to keep up to, for example, 3 lines per the comment for a setting key in cluster.yaml.
However, I do believe migrating the following long comments to dedicated documentations would help:

https://github.com/kubernetes-incubator/kube-aws/blob/aeccbb266/core/controlplane/config/templates/cluster.yaml#L609-L622

Probably into a doc named like "Bringing your own route table"?

https://github.com/kubernetes-incubator/kube-aws/blob/aeccbb266/core/controlplane/config/templates/cluster.yaml#L652-L783

Probably into a doc named like "Customizing a network topology"?

@mumoshu ok sure, can I ask the reasons why you wish to keep cluster.yaml verbose? I'm just curious about overall plans to improve this area. Ideally I'm still thinking a full schema would be good.
I will take a task about separating those ones you mention. My initial thoughts are adding both of them as a section in a simple github pages website (plus the bit I've already done). I'm not sure about the publishing to the coreos website, not even sure why that link is still maintained?

@c-knowles Thanks for your efforts!

ok sure, can I ask the reasons why you wish to keep cluster.yaml verbose?

I'd just like to keep cluster.yaml self-contained enough for basic setups.
Relatively long comments might be for more advanced setups and therefore I thought they should go to dedicated docs.

My initial thoughts are adding both of them as a section in a simple github pages website (plus the bit I've already done).

It sounds good but the only concern I have is that, in longer term, aggregating too many topics into a single doc would make it harder to be read?
I just wanted separate docs dedicated to respective topics so that we don't bloat each doc size like we (unfortunately) do for cluster.yaml today.
Your thoughts?

@mumoshu ok makes sense, at first we can just separate the particularly verbose parts then and see where we get to. A github site using simple Jekyll theme would allow separate markdown files for the different sections/topics so I think it fits with your idea of having separate docs just they are on the same site. If you are happy for me to proceed with that I'll create an issue now and start on it soon.

@c-knowles I like the idea of having a github pages site for the doc but I'm not really sure if I have an enough permission to enable it on this repo

So, would it work if we add the doc/ dir to the master branch?
I'd been using the gh-pages branch for a long time in my other projects which worked great, but there's no option in the web ui to choose to use gh-pages branch.

@c-knowles Would you mind starting from just adding new docs to Documentation/ (and links to them from README.md) which already exists as of today, and then migrate to a gh pages site (if possible) or an another website (if any) in the future?

@mumoshu the docs folder has to exist for it to be selectable.

@mumoshu I've extracted your two current top items from https://github.com/kubernetes-incubator/kube-aws/pull/526#issuecomment-293773312 into separate tasks. For this PR do you want me to remove the idea markdown for now or rename it?

@c-knowles Assuming we're going to add a completely different docs for the separate tasks, I guess we'd better remove the doc added in this PR for now.
I'm all for ways you'd feel easier though!

@mumoshu I agree, let's assume that for now - all ready here. I've kept a copy of the idea locally for when we do the new docs.

@c-knowles LGTM. Thanks for your continuous efforts 👍


fixing broken deprecation namings

Fixes #3170.
The deprecated decorator should not be used in a way it was directly used.
The pattern was:
old_function = deprecated(
    deadline='v0.9', fix='Use cirq.new_func instead.')(
        cirq.new_func)

The main problem is that we pass in the new function into the deprecated decorator...now it does return a new function instance that is a decorated one and hence the old function gets a good wrapper around it. However, the name calculation in case name arg is not defined cannot determine what the name of old_function is.
There are two ways to fix this AFAICT (unless I'm missing some python magic that can tell what the name of the variable is that is calling the current function - which I found to be not possible):
1.) set name and duplicate the variable (function) name
old_function = deprecated(
    deadline='v0.9', fix='Use cirq.new_func instead.', name = 'old_function')(
        cirq.new_func)

2.) use the decorator on a proper def
@deprecated(
    deadline='v0.9', fix='Use cirq.new_func instead.', name = 'old_function')
def old_function(*args,**kwargs):
     return cirq.new_func(*args,**kwargs)

I chose 2 in my solution, a bit more verbose but there is no duplication at least.

Automerge cancelled: A required status check is not present.
Missing statuses: ['cla/google']

Automerge cancelled: A required status check is not present.
Missing statuses: ['cla/google']

@googlebot please rescan


[Bug]: Popover does not work on a scaled canvas

Browser
Chrome
Package version
3.0.18
React version
18.2.0
Description
The Popover should display adjacent to the selected element but instead it is placed further left on a zoomed out div and further right on a zoomed in div.
Source code

          Content here

      }
    >

Reproduction
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems

Hello Brian,
thanks for reaching out.
I was only able to reproduce what you've mentioned in our Popover component page, by setting, for example, transform: scale(0.5) in the Playground content element.
Standard zoom from Chrome 103 didn't impact the component for me. Which browser are you using?
Nonetheless, using the renderWithPortal property solved this for me. Enabling this property will allow the popover to be rendered in the root stack context using React Portals  (however, depending on your use case - ie: if transform: scale is applied to the whole document - this might not be the solution).
Could you please share your source code with us or let us know if enabling that property solved it for you?
Thank you,
RC

@rubencarvalho that does the trick, amazing buddy thanks! How did I not know about React portals also!? Thanks for the bit of education too ;-)