[$500] [HOLD for payment 2023-12-06] Chat - Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/30582
Action Performed:

Go to staging.new.expensify.com
Create 2 accounts, one will be used as employee and second as an admin
Request 1:1 money as employee from the admin
As admin, go to the 1:1 chat and click Pay With Expensify

Expected Result:
The 'Pay with Expensify' option should be visible only once when the admin opens the dropdown.
Actual Result:
Encountering a duplicate 'Pay with Expensify' option when the admin opens the dropdown
Workaround:
Unknonw
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/4e9bbb0f-fdab-44ea-b319-d71a2f10cd13
View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @kadiealexander
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01878c6382f2f8f9a9
Upwork Job ID:<PHONE_NUMBER>305871360
Last Price Increase: 2023-12-07

Proposal
Please re-state the problem that we are trying to solve in this issue.
The button to settle with the a verified bank account is mislabeled as "settle with expensify".
What is the root cause of that problem?
The button to settle with the a verified bank account is mislabeled as "settle with expensify".
What changes do you think we should make in order to solve the problem?
Changed the label of the button by adding a new localization key.

I cannot repro on main

I cannot repro in staging either

@mountiny
Your currency must be USD.

I still cannot repro if I use USD and VPN in the US

@vit I am still able to reproduce.

ok yeah the report needs to be on USD

PR is in a review

Hey @situchan, could you please sort the bugzero checklist?

[x] The PR that introduced the bug has been identified. Link to the PR:
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30582/files#r1416698670
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug. N/A as caught by Applause during PR test
[x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Hey @situchan are you paid via Upwork or Newdot?

Roger, sent you a contract!

Payouts due:

[x] Contributor+: $500 @situchan

Upwork job is here.


unable to open file: name = './datasets/vg/imdb_1024.h5'

When I train the model I encounter the following error, Unable to open file (unable to open file: name = './datasets/vg/imdb_1024.h5', errno = 2, error message = 'No such file or directory', flags = 0, o_flags = 0)
I hope you will see my question and reply, thanks.

This file is part of the dataset setup. I think you might have missed setting up the dataset.
dataset prep
I can help more if you can describe what stage you are training for.

Thank you for your reply. I have solved this problem, but I have a new problem. I am doing a model evaluation using the following command python test.py --test_task 1 --init_weight_path /mypath/pretrained_model/updated_distill_KD_gnd_a0.2_t10_last_model.pth ,but the page stays at the current stage for more than 30 minutes without change.

And I would like to ask, if I need to specify the GPU 's id, is it possible to modify this code?

I get some errors when I test the model using the following command. The error message is ```
terminate called after throwing an instance of 'std::runtime_error'
what():  NCCL Error 1: unhandled cuda error
Aborted (core dumped)
The command is `CUDA_VISIBLE_DEVICES=2,3 python test.py --test_task 1 --cuda --init_weight_path  /mypath/pretrained_model/updated_distill_KD_gnd_a0.2_t10_last_model.pth"`

I downloaded from this link, https://svl.stanford.edu/projects/scene-graph/dataset/imdb_1024.h5, but still can not open, how do you solve?

Sorry for the late reply! Let me take a look into this and try to reproduce the error.

抱歉回复迟了！让我看一下并尝试重现该错误。

Thank you!! and Have you solved it？

抱歉回复迟了！让我看一下并尝试重现该错误。

hi～Could you please provide the file imdb_1024.h5 again?
After testing below, I find that the file type is recognized as HTML document, ASCII text, with very long lines, not HDF5 file.


Env support

Check for existing issues

[X] Completed

Describe the feature
it would be nice to have some basic syntax highlighting for .env files
If applicable, add mockups / screenshots to help present your vision of the feature
No response

+1


Error with latest client & p2pool

2015-11-09 13:48:20.429566 > Error while calling merged getauxblock on http://<IP_ADDRESS>:7338/:
2015-11-09 13:48:20.429667 > Traceback (most recent call last):
2015-11-09 13:48:20.429696 >   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 577, in _runCallbacks
2015-11-09 13:48:20.429735 >     current.result = callback(current.result, *args, **kw)
2015-11-09 13:48:20.429762 >   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1155, in gotResult
2015-11-09 13:48:20.429787 >     _inlineCallbacks(r, g, deferred)
2015-11-09 13:48:20.429823 >   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1097, in _inlineCallbacks
2015-11-09 13:48:20.429857 >     result = result.throwExceptionIntoGenerator(g)
2015-11-09 13:48:20.429886 >   File "/usr/lib/python2.7/dist-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
2015-11-09 13:48:20.429931 >     return g.throw(self.type, self.value, self.tb)
2015-11-09 13:48:20.429966 > ---  ---
2015-11-09 13:48:20.430017 >   File "/home/rig/p2pool/p2pool/util/deferral.py", line 41, in f
2015-11-09 13:48:20.430057 >     result = yield func(*args, **kwargs)
2015-11-09 13:48:20.430088 >   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1097, in _inlineCallbacks
2015-11-09 13:48:20.430119 >     result = result.throwExceptionIntoGenerator(g)
2015-11-09 13:48:20.430149 >   File "/usr/lib/python2.7/dist-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
2015-11-09 13:48:20.430180 >     return g.throw(self.type, self.value, self.tb)
2015-11-09 13:48:20.430226 >   File "/home/rig/p2pool/p2pool/util/jsonrpc.py", line 133, in _http_do
2015-11-09 13:48:20.430258 >     raise Error_for_code(resp['error']['code'])(resp['error']['message'], resp['error'].get('data', None))
2015-11-09 13:48:20.430296 > p2pool.util.jsonrpc.NarrowError: -12 Error: Keypool ran out, please call keypoolrefill first
This is running on Xubuntu 64bit. Previous version ran fine.

Judging from the final message, your keypool ran out. :)  Please use keypoolrefill or unlock the wallet to recreate new keys.  Unlike some previous versions, the current one does not reuse addresses for mining.  This is the same in upstream Bitcoin.

Right, sorry - news to me. Is it a case of starting i0coind with the -keypoolrefill command or can I enter it via ssh when the wallet is running?
Sorry for my ignorance - never came across this before......

No problem!  I don't have experience with the option, but it should suffice to issue i0coin-cli keypoolrefill SOMELARGENUMBER via SSH (unlock the wallet first, of course).  Also, very important, make sure to create a fresh backup afterwards!

Sorted. Thanks domob!


I would like to obtain the dataset or checkpoint train of your work

Hi, I'm a student and I wanted to test your model, but the dataset is not available in the link. If you could provide me with a copy or the workout checkpoint, I would greatly appreciate it.

The dataset should be available. Can you please check again. However, due to account migration, the models and evaluation files have been deleted. Kindly reach out to authors who have used SGCP as their baselines, incase they have a copy saved.

I was able to download it, thank you.


Develop rules for StoryRAMP structuring within the StoryRAMP Viewer

Rules are documented and established for how a technical user can create a StoryRAMP product by creating/editing a JSON configuration.

Doesn't make sense anymore.


Error when recognize face

Hello,
I checkout newest source and run, it shows the error below:
App crashed:
[AVAssetWriter startWriting] Cannot call method when status is 1
It comes from this function:
func start() {
    guard state == .pending else { return }
    state = .writing
    assetWriter.startWriting()
    assetWriter.startSession(atSourceTime: .zero)
}

Thank you.

@chinhnd Can you verify if your backend is configured correctly? how are you create a new session?

Closing due to lack of inactivity, please re-open if this is still an active issue.


feat: export to html

and you can move scenes with right and left arrow keys.

Nice feature!

Yay!
https://user-images.githubusercontent.com/490574/116799217-4d634d00-ab32-11eb-90c1-8be369dfeee8.mov


2024.14.8 - Shows "offline" instead of "asleep"

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Before upgrading to 2024.14.x, Teslamate would correctly identify the vehicle as "asleep" when asleep.  It appears after upgrading that anytime the vehicle is in a sleep state it is reported as "Offline"
I will point out that I have two vehicles that are in the same location.  One is running 2024.3.25 and the other 2024.14.8.  The car on the older version reports everything correctly.
I have also noticed that the Tesla app itself also uses a different term when displaying the vehicle in a sleep state.  It appears to show "asleep for" instead of "last seen"
Expected Behavior
"Asleep" state should be reported as such
Steps To Reproduce
Upgrade to 2024.14.x
Wait for vehicle to fall asleep
Check status
Relevant log output
2024-06-03 07:13:31.622 [info] Streaming API: Vehicle offline
2024-06-03 07:13:31.622 car_id=1 [warning] Stream reports vehicle as offline, fetching vehicle state ...
2024-06-03 07:13:31.910 car_id=1 [info] Start / :offline
2024-06-03 07:13:31.929 car_id=1 [info] Disconnecting ...

Screenshots

Additional data
No response
Type of installation
Docker
Version
v1.29.1

Here it is in the offline state

This is not entirely an 'issue', and we have a healthy discussion going here #3753. As a product, there is not a decision to start marking 'offline' as sleep. Historically, it was two different states.

The same problem appears when entering Asleep after the update.
2024.8.9 Asleep / 2024.14.8 Offline
Teslamate 1.29.1
2022 Model 3 (Ryzen)

This is not a TeslaMate issue. Tesla API reports "offline" for intel MCUs since 2024.8.3 and for all MCUs (expect MCU2 upgraded) since spring update, 2024.14.x
There are rare cases the Tesla API still report sleep state, if you car falls asleep while charger plugged in in some cases.


Added information about the official Prisma plugin in JetBrains IDEs

The WebStorm team has added support for Prisma recently, It includes complete Prisma schema language syntax support with semantic highlighting, code completion, automatic brace, and quote insertion, and Rename refactoring.
And it works better than the plugins mentioned here, which are not supported in recent versions

See https://github.com/prisma/docs/pull/4487

@janpio Thanks for the link


Add support for system values reporting

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[X] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
[X] Make sure you are making a pull request against the main branch (left side). Also you should start your branch off our main.
[X] Check your code additions will fail neither code linting checks nor unit test.

Description
Adds support for systems stats reporting.
Now it is possible to report CPU load, RAM Usage, HDD Usage, and total bytes transmitted/received.
This change allows the Edge SDK to report system values, which can be seen in the vitals widget.

As discussed with @leandropineda , we'll leave the network implementation for later, ready for a re-review


BUG: series.fillna() fails with quoted numbers

Here's a simple example:
import pandas as pd
import numpy as np

x = pd.Series(range(5))
x.iloc[1] = np.nan
x.fillna(0) # works
x.fillna('foo') # works
x.fillna('0') # crash

in the function _putmask_smart(), two numpy arrays are compared to determine if they have compatible dtypes. However if one array contains quoted numbers, then the test does NOT resolve as element wise compare, but rather as a "normal" python comparison. This means the result is False, rather than an array, and the attempt to get False.all() obviously fails.
Not sure exactly why the arrays don't compare as expected -- perhaps there are other criteria that would trigger it -- but an easy fix is to add AttributeError to the try/except clause as a "valid" error.

@jlowin this needs a test and release note.

closing pls reopen if/when updated


Fix parent_first_{packages,resources}.properties to delegate msgpack class loading to parent

This PR fixes parent_first_{packages,resources}.properties to delegate MessagePack classes loading to parent classloader. In the 0.8.25 or older versions, a plugin classloader loads MessagePack classes if the plugin uses MessagePack classes directly. On the other hand, Embulk core also loads MessagePack classes by parent classloader. So, When the Value objects are passed to the plugin side from Embulk, LinkageError happens.
As we will have a plan to change plugin SPI to solve such issues, this PR fixes the current plugin classloader mechanism.
This PR fixes #691.

LGTM > https://github.com/embulk/embulk/issues/691#issuecomment-310816690

@dmikurube Please take a look when you have time.

@muga Let me try summarizing the issue and the fix.
Premise

The Embulk core requires msgpack-java 0.8.11.
Problems happened when plugins try to use msgpack-java 0.8.12.
The plugins have had msgpack-java 0.8.12 as compile and non-provided in their build.gradle.

Before this fix
org.msgpack things have not been included in parent_first_packages. PluginClassLoader for the plugins loaded the plugin's embedded msgpack-java 0.8.12 for org.msgpack.*.
In that case, the following classes co-existed on the same JVM.

The Embulk core's org.msgpack.* (0.8.11) loaded by the system class loader
The plugin's org.msgpack.* (0.8.12) loaded by PluginClassLoader

They were considered as "different classes" as they were loaded with different class loaders -- they couldn't be linked.
I finally thought that the root problem was not version conflicts. It's a problem of duplicated classes loaded by different class loaders. Can I confirm this at first, @muga?
(Therefore, I guess the same problem still happens even if the plugin uses msgpack-java 0.8.11, the same version with the Embulk core. Can you try if you have some extra time, @civitaspo?)
After this fix
PluginClassLoader returns org.msgpack.*, which have already been loaded by the system class loader. No org.msgpack.* are loaded from the plugin. There are no duplicates. The superficial matter disappears by the fix.
Remaining potential problem
The duplicated org.msgpack.* are however still in the plugin although they're not loaded by PluginClassLoader. It can be a potential problem in the future -- I think a fix is needed even on the plugin's side.
@civitaspo In the example of embulk-filter-linkage_error, it's worth trying the following build.gradle with the released Embulk 0.8.25 without this fix
// Pattern 1
dependencies {
    compile  "org.embulk:embulk-core:0.8.25"
    provided "org.embulk:embulk-core:0.8.25"
    compile "org.msgpack:msgpack-core:0.8.12"
    provided "org.msgpack:msgpack-core:0.8.12"
    testCompile "junit:junit:4.+"
}

// Pattern 2
dependencies {
    compile  "org.embulk:embulk-core:0.8.25"
    provided "org.embulk:embulk-core:0.8.25"
    compile "org.msgpack:msgpack-core:0.8.11"
    provided "org.msgpack:msgpack-core:0.8.11"
    testCompile "junit:junit:4.+"
}

In case a direct dependency depends on msgpack-core indirectly, I guess the following build.gradle may work...
dependencies {
    compile  "org.embulk:embulk-core:0.8.25"
    provided "org.embulk:embulk-core:0.8.25"
    compile("org.komamitsu:fluency:1.3.0") {
        exclude group: "org.msgpack", module: "msgpack-core"
    }
    compile "org.msgpack:msgpack-core:0.8.12"  // or "0.8.11"
    provided "org.msgpack:msgpack-core:0.8.12"  // or "0.8.11"
    testCompile "junit:junit:4.+"
}

(This fix should be anyway applied independent from the root cause, though.)

(Just changing build.gradle to org.msgpack:msgpack-core:0.8.11 may work fine because Gradle removes classpath/msgpack-core-0.8.11.jar from the built gem. We may need to force-locate msgpack-core-0.8.11.jar to check that.)

@dmikurube Thank you for summarizing the problem. Yes, the root cause is not versions conflict. It is the conflict of the classes loaded by different classloaders. And build.gradle change that you suggested should work 👍

@dmikurube Yes, we will. Anyway, thank you for reviewing. Merging.


[BUG/Help]

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I want to run this on a R7-6800H laptop using CPU however I do not have a NVIDIA card to run the quantize python code. can someone provide me a int8 or 16 version of quantized model or give me some instructions on how to write one to let CPU to do the work?
P.S Should the model works in LLaMa.cpp?
Expected Behavior
No response
Steps To Reproduce
have a laptop with out NVIDIA GPU and run the quantize python code.
Environment
- OS:windows 11
- Python:3.10.9
- Transformers:according to requirements.txt
- PyTorch:requirements.txt
- CUDA Support (`python -c "import torch; print(torch.cuda.is_available())"`) :False

Anything else?
No response

This might be what you are looking for: https://huggingface.co/THUDM/chatglm-6b-int4
Load it on CPU:
model = AutoModel.from_pretrained("THUDM/chatglm-6b-int4",trust_remote_code=True).float()
8G RAM is required.


Support tree-shakeable icons

This PR builds on the work from @Rowno and @Chrischuck to get tree shake-able icons shipped in Evergreen.
Note: this is not quite ready for shipping, but it's close. We could probably ship after adding types for the new icons.

[x] generate icon names export
[x] generate individual icon files
[x] generate map of icon names to icon components (for backwards compatibility in <Icon icon='foo' />)
[x] generate index.js exports of all individual icons
[x] remove @blueprintjs/icons from the final builds (only use generated types to reduce build size)
[x] reduce build size from 350kb to ~240kb (closer to today's 212kb)
[x] generate typedefs for individual components
[x] remove usage of <Icon /> internally wherever possible in a non-breaking way
[x] update docs
[ ] ship as a minor version!

BEFORE (350kb gzipped, blueprintjs is duplicated)
AFTER (238kb gzipped,  no blueprintjs duplication)

@Chrischuck had to split into my own branch since I don't have push permissions for your fork.

Ok, I think this might be ready for prime time review!
I'm happy to remove the generated icons from git, but it might be nice to see when there are changes to the icons in future versions.

Amazing foundation by @Chrischuck and @Rowno 👏


Bump dev and prod dependencies for post-release

Coverage remained the same at 63.345% when pulling 0a002e5d9cb486d29e7cc78bf0982c4116675bda on compulim:bump-deps-4.6.1-0 into 6c9834a3713bc1e774c2dd58923e2801bc45bbf2 on microsoft:master.


Add option to return a copy of data

It is useful when you generate an accessor for global variable like slice or map. In order to improve safety I would like to return a copy of that type.
Example of modification global variable
var data = []string{"1", "2", "3"}

func Get() []string { return data }

func main() {
	ddd := Get()

	ddd[0] = "X"
	fmt.Println(Get())
}

So in that case I would like to specify behaviour that will copy slice (in Get) before return:
func Get()[]string{
  res := make([]string, len(data))
  copy(res, data)
  return res
}

Hi @kazhuravlev , thank you for the detailed feedback. However, this request might extend beyond the current scope of the project. Have you considered using immutable collections to achieve this level of safety? e.g. https://github.com/benbjohnson/immutable


Make links on the HTML5 editor more readable

This also tweaks the focus style to apply to all elements for better keyboard navigation.
Preview
Before

After

Thanks!

Thanks!

Cherry-picked for 3.2.4.

Cherry-picked for 3.2.4.


why async must use async() {...} or async(fun...), but not async {...}?

i thought i can use like:
`
private fun updateTime() = async {
while (true) {
val time = sdf.format(Date())
uiThread {
timeText.text = time
}
        Thread.sleep(10000)
    }
}

`
but androidstuio gave me an error: Unsupported [async block/lambda... use async() {...} or async(fun...)
i am studying kotlin,  i think i can use like async {...}
i really want to know the reason. anyone can help?
thanks!

May'be async reserved as keyword.

hi @Jamefrus , here is the async:
fun  T.async(task: AnkoAsyncContext.() -> Unit): Future {
val context = AnkoAsyncContext(WeakReference(this))
return BackgroundExecutor.submit { context.task() }
}
from anko-common-0.8.3-sources.jar!\org\jetbrains\anko\Async.kt
i think it's just a fun.

it's really strange. in anko-common-0.8.3-sources.jar!\org\jetbrains\anko\Async.kt, there is another fun asyncResult:
fun <T, R> T.asyncResult(task: AnkoAsyncContext<T>.() -> R): Future<R> {
val context = AnkoAsyncContext(WeakReference(this))
return BackgroundExecutor.submit { context.task() }
}
it can be used like asyncResult {...}
so async is really special, but we don't know the reason.

@Jamefrus  u r right, http://stackoverflow.com/questions/34803897/what-are-the-reserved-keywords-in-kotlin
thanks!

and it was replaced with doAsync in the latest release


Replace express-request-id

@andrewrlee this is a quick draft of trying to pull the code into our own repo. Not tested, just thought I'd get your thoughts 🙂

@andrewrlee I've made all the changes and all seems to be working well on dev. @tpmcgowan this sorts one of the issues with updating the express-request-id module by removing it 😁


fixed readthedocs.yml

In one of the pull requests I made I forgot to merge readthedocs.yml, and currently, the docs badge shows the docs build is failed.
So here it is.
Built docs: https://elephant.readthedocs.io/en/docs_fix2/

Coverage remained the same at 70.943% when pulling 145c469c313b226cf10da985acb89f169829428b on docs_fix2 into 73628d1798d053247c6a4af6e1dd9ad6476551c3 on master.

[Merging despite CI checks not showing complete -- on travis all is fine]

On travis all is fine because travis does not check the docs build. Currently, readthedocs does not support API not to merge the PR if the docs are failing. They're working on it, however. So basically we never sure about the docs unless it's merged in the master and then readthedocs starts building the docs, and only then we can see if it's successful or not. We might think to add the docs build as another test on travis. However, this breaks the logic of CI since one instrument starts doing the job of another one...


bump version of electron-prebuilt to 0.27.2

That's already part of my #42 fwiw.

closed in favor of #42


Table fixes and improvements

This PR does three things:

some code cleanup
COSMIC_ID linkouts are fixed
The ANN field is rendered in a simplified version that shows the entire contents in a tooltip.

Thanks for the PR,  looks good.


refactoring of log messages

added error codes for all warning/error messages
synchronized some messages for mysql/postgresql
removed old/redundant messages
added killing processes in integrations tests via pidof to catch situations with sighup/restart on acra-server
change blocking method in main function for acra-server, swapped SIGHUP with SIGTERM handler. actually it doesn't change any logic but tried it to fix unknown sighup messages on circleci. thought that maybe it is some golang runtime special behavior with closing channel at end or something like that...
pass logger's with context to inner functions to log debug messages with related client/zone id
avoid error logs with decryption failures when it expected and are allowed (binary data but not acrastruct) and use warnings instead errors when it failure on acrastruct (to notify clients because may be situation when clients think that all data correctly encrypted but it's not)

return usage of sighup handler as last block function because it didn't fix sighup problem
applied your suggestions as one commit to avoid many commits for each suggestion


Standardize search boxes with fuzzy string match/auto-complete

Could all of our search boxes make use of fuzzy string matching (or maybe called auto-complete?)?
I noticed that this feature exists when searching the resource types but not when searching the StructureDefinitions by id. In the latter case, you have to type in the exact string to find the resource.

@znatty22 right now that's because it would slow down the frontend to preload tens of thousands of IDs - the table is loaded as the page scrolls, so the search bar doesn't know all the IDs up front. If this is something that we want to change we can, it just will probably be a lot slower on initial load

Hmm ok, maybe we don't need auto-complete on all of the search boxes but it would be really useful for the StructureDefinition one. Is that possible?


Fix preprocess logic in to_dataset

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #245

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[ ] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[ ] HISTORY.rst has been updated (with summary of main changes).

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

The passed preprocess function is kept in the kwargs and overridden there if needed.

Does this PR introduce a breaking change?
Other information:

Works on my machine.


move metrics from settings to client classes

Affects: all versions.

When configuring the sonar instances from admin page in UI the entries change order. So the metrics in properties file do not match the order of the UI admin page. This PR moves the metrics from properties file to client classes.

Hi @fidelcoria-aa could you explain why you are moving metrics from properties file to the class?

Sure
Problematic situation:
Suppose you have 2 sonar instances SonarA and SonarB. You go to Admin UI Page to enter Sonar details (url, username, password). While other information is added to properties file (version, metrics, etc.) SonarA has index 0 and SonarB has index 1.
Now notice the order of values in properties file is fixed, when you update SonarA password and click save... the order in the database changes. So SonarA has index 1 now and starts using the wrong properties file vales. (This seems to be a bug with Mongo or Mongo Driver, I was not able to pin point problem)
Fix:
Fetch version every time and Do not store version (because the order changes as discussed above). And same applied for the Metrics fields

Great, thanks for the clarification.  I noticed that this PR doesn't make use of PR #5 , specifically getSonarVersion(instanceUrl) to collect versions from the url.  Were you planning on implementing that back in so that the version still fetches from server?

Well, once #5 is merged to master. Then #6 can be merged into master if no conflicts. If there are conflicts then I can resolve conflicts

@fidelcoria-aa there seems to be an issue with the new changes collecting metrics63andAbove and metricsBefore63.  They are null when the properties files have metrics.

Hmm. I wonder if it has to do with changing the metrics type from List to String. I'll take a look

I tested with sonar instance version 6.0 and version 6.7.2 and it worked as expected both times.
I also did a full integration test with 6.7.2: I enabled a sonar project on a dashboard and ran the collector and it used the metrics string from properties file.

Thanks Fidel, Courtney will test it with 5.6 version and get back


Add Manifest details to PWA page

We should show the data from the Manifest on the PWA detail page. We can either show it as a beautified JSON or find another way of visualizing the data.

I'm wondering the best way to show the raw manifest. This doesn't look very good:

@ithinkihaveacat @juliantoledo Ideas?

I think that's okay, especially for MVP—? As an alternative, could just link to our copy?

Yes, for MVP is great. Let's do some CSS later next week.


Update queue-based load leveling pattern

Update example section to use more modern Azure services.  Details: Could not find a part of the path 'T:\cjwl\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\cjwl\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\cjwl\building-blocks\extending-templates\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 845747f:
:clock10: Preparing: average preparing time is 46 sec(s)

OPS Build status updates of commit 845747f:
:clock10: Incremental building: average incremental building time is 22 sec(s)

OPS Build status updates of commit 845747f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

bread/toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

docs/patterns/_categories.yml
:white_check_mark:Succeeded

docs/patterns/_images/queue-based-load-leveling-overwhelmed.png
:white_check_mark:Succeeded
View

docs/patterns/_images/queue-based-load-leveling-worker-role.png
:white_check_mark:Succeeded
View

docs/patterns/queue-based-load-leveling.md
:white_check_mark:Succeeded
View

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\n3tw\bread\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\n3tw\building-blocks\extending-templates\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\n3tw\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit f627372:
:clock10: Preparing: average preparing time is 46 sec(s)

OPS Build status updates of commit f627372:
:clock10: Incremental building: average incremental building time is 22 sec(s)

OPS Build status updates of commit f627372:
:warning: Validation status: warnings

File
Status
Preview URL
Details

toc.json
:warning:Warning

Details

bread/toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

docs/patterns/_categories.yml
:white_check_mark:Succeeded

docs/patterns/_images/queue-based-load-leveling-overwhelmed.png
:white_check_mark:Succeeded
View

docs/patterns/_images/queue-based-load-leveling-worker-role.png
:white_check_mark:Succeeded
View

docs/patterns/queue-based-load-leveling.md
:white_check_mark:Succeeded
View

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\ear1\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\ear1\bread\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\ear1\building-blocks\extending-templates\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 1d4941b:
:clock10: Preparing: average preparing time is 46 sec(s)

OPS Build status updates of commit 1d4941b:
:clock10: Incremental building: average incremental building time is 22 sec(s)

OPS Build status updates of commit 1d4941b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

bread/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

docs/patterns/_categories.yml
:white_check_mark:Succeeded

docs/patterns/_images/queue-based-load-leveling-function.png
:white_check_mark:Succeeded
View

docs/patterns/_images/queue-based-load-leveling-overwhelmed.png
:white_check_mark:Succeeded
View

docs/patterns/_images/queue-based-load-leveling-worker-role.png
:white_check_mark:Succeeded

docs/patterns/queue-based-load-leveling.md
:white_check_mark:Succeeded
View

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\q1bk\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\q1bk\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\q1bk\building-blocks\extending-templates\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Set 'GO111MODULE=on' when building ocs-operator

This allows make ocs-operator to succeed when running within
$GOPATH/src.

That works for me as well. Let me quickly test it out, and update this PR.

I didn't encounter this problem. What was the specific error that occurred? I'm unsure if setting GO111MODULES=on is the right solution here or not.

@davidvossel It is needed if your repo is cloned under GOPATH - see here:

Once installed, you can then activate module support in one of two ways:

Invoke the go command in a directory outside of the $GOPATH/src tree, with a valid go.mod file in the current directory or any parent of it and the environment variable GO111MODULE unset (or explicitly set to auto).
Invoke the go command with GO111MODULE=on environment variable set.


Bugfix: multi-touch doesn't work correctly

I fixed a bug that multi-touch doesn't work correctly.

@taka-okayama Can you review the PR?


Update mobilebroadbandmodem_isresetsupported.md

Broken link

@stevewhims : PR passed acceptance checklist. Please evaluate further and approve/merge if appropriate. Thanks!


chore: update the doc and remove unnecessary config file

This pull request tries to remove the unnecessary GLAuth config file. The charm does not need the config file to be present at the beginning anymore.

albeit this is technically a reasonable thing to do I'm not sure it s the best one
i would expect that if I run the rock without anything it starts up and gives me a minimum working glauth server, is that the case if we remove the config? can glauth start without a config file?

albeit this is technically a reasonable thing to do I'm not sure it s the best one
i would expect that if I run the rock without anything it starts up and gives me a minimum working glauth server, is that the case if we remove the config? can glauth start without a config file?

Nope. If we purely run the container without mounting a config file, it will not start the service. The reason I removed it is that the charm no longer needs it and we have to maintain a copy of the config file (If something is changed in the upstream for the config, we have to remember to come here to check and modify it if needed.)

i would proabably keep it then, we are supposed to build off a tag or specific commit, so on source change we would have to double check the config
happy to go with whatever the team decides though, let's discuss at standup


Solution error

Please, append Sio.Heart and Sio.Identity projects to source code repository. This projects was not loaded to source code solution.

Hi @DmitryAA sorry for have you found the issue. We are in the process for clean up all source code now. Will keep you posted when it is done.

Thank you for annswer. Сan your made goods subcategories for cms goods, if is it possible?

@DmitryAA : FYI, you can take a look on this quick tutorial video https://youtu.be/GiKp7J3Vbv0

Thank you for video. It is very good information for me. Can you restoring  main cms site https://swastika.io working.

Thank you for video. It is very good information for me. Can you restoring main cms site https://swastika.io working.

yes, the main cms site is now working. thanks for your information.


Use sendmmsg to reduce system call overhead

I noticed sendmsg was 35% of the flame graph for the large streams benchmark, so I finally had a go at this. It yields a roughly 15-30% improvement in each one of the throughput benchmarks! Oddly, sendmmsg is still about 35% of the flame graph, and cranking the batch size way up doesn't seem to help any. We'll probably need to dive into libc or the kernel or even investigate generic segmentation offload or similar to make further headway on this particular bottleneck.

Looks like macOS doesn't expose this; there's sendmsg_x, but the comments describe it as unstable. How do we feel about using that?

Using the fallback for now, since sendmsg_x isn't even bound in the libc crate.

Investigation suggests that the remaining sendmmsg presence is just how much time it takes to send UDP packets on Linux. Further optimization will have to come from elsewhere, or resort to userspace networking.

sendmmsg isn't nearly so prominent in profiles the benchmark introduced in #507 which should be pretty similar to the existing "large streams" benchmark, so maybe criterion is confusing things somehow. The performance benefit seems to stand, however, perhaps in part due to fewer calls into the reactor machinery.


Building grid texture not visible on certain phones

Extruded buildings should have a grid texture sampled from building-grid.gif:

This works as expected on desktop, iOS, and most Android devices. However, on the Moto X (2014) and the Galaxy S5, the grid is not visible:

No GL errors are reported and driver capabilities don't seem to be correlated to the issue.

You already know this, but for documentation, I did see the building grid texture on my S5 this morning.

@blair1618 Is there a styling ask here or is this a Tangram bug?

Most likely this is on the tangram side, but as of now we do not know why certain phones including s5 are not showing building grid texture.

@tallytalwar @nvkelso It's actually not anything we can solve within tangram - it's an issue with the custom shaders in the eraser-map scene file and the limitations of certain devices. I'm pretty confident that if you loaded the WebGL version of eraser-map on those devices you would see similar issues.

@blair1618 I don't think we can guarantee that WebGL version on these devices would show similar issues. Possible browser masks certain issues.
Example, previously the dots style issue (now fixed) was not working on S5 tangram-es, but was working in the web renderer on S5 chrome.

Update on this:

Still broken on S5 (5.0) and MotoX (5.1)
Works on S5 (4.4).
Does not work with another test 128x128 png texture image. So not specific to a gif texture.
Seems to be an issue with usage of v_texcoords in global injected functions. (material block specifically). We saw something similar with usage of TileCoords method which was causing issues with rendering of dots styles on certain devices.

Attaching the test png texture here.


Check negative evolution until we reach minimum ratio only

The plugin should respect common-java:InsufficientBranchCoverage, common-java:InsufficientLineCoverage setup, minimumBranchCoverageRatio and/or minimumLineCoverageRatio respectively. If the file coverage degrades but still is more then the minimum ratio, PR should be approved. It should not be a fight for the last coverage ratio.
https://github.com/AmadeusITGroup/sonar-stash/issues/58

Moved to AmadeusITGroup/sonar-coverage-evolution#2


cant load PSReadline

Console work without PSReadline. What does it mean, is it critical? and how I can load it?

Same issume on win10 x64  Atom1.10

+1 Same issue.

May be you can try Platformio Ide Terminal,but there is another issue of PSReadLine.

@Aisuko Interesting... I installed Platformio IDE and not getting the same error. Might keep it installed, didn't realize it was a whole IDE for atom, looks sick so far!

+1 same issue on win10 x64 1.6.0

+1 win10 x64

UPDATE: HERE IS A FIX:
GO to the extension settings page and add in the "Shell arguments" option, paste this: -ExecutionPolicy Bypass
Works for me in powershell Win x64

UPDATE: HERE IS A FIX:
GO to the extension settings page and add in the "Shell arguments" option, paste this: -ExecutionPolicy Bypass
Works for me in powershell Win x64

emmm... can you tell me where is extension setting page?

@sunweifei

Also see https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.security/set-executionpolicy?view=powershell-6


PR for Release 1.4

This is the dev to master PR for making a release 1.4 for nf-core/rnaseq. Lots of changes, so please have a look and review 👍
PR checklist

[x] This comment contains a description of changes (with reason)
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
[x] Ensure the test suite passes (nextflow run . -profile test,docker).
[x] Make sure your code lints (nf-core lint .).
[x] Documentation in docs is updated
[x] CHANGELOG.md is updated
[x] README.md is updated

Hi @ewels @MaxUlysse @olgabot !
Just merged in the separate PR with all the fixes to have your raised concerns done - should be fine now I hope 👍

Travis CI seems to have taken a day off today - but we got 68 full tests with GH Actions, so should be fine 👍

I was looking at the params definition in nextflow.config and conf/base.config, and basically, I would put all params in nextflow.config.
we have defined twice igenomes_base.

I guess the tools 1.7.1 release is something I will wait for (when we release very soon?) ...

Can’t remember why we didn’t just use Pearson’s in the first place... Sorry for any trauma that this decision caused over the years 😂

Will get the container updated once more - preseq has been upgraded at bioconda now, rsem also compiling with R 3.6.1 now, so once this is done this is really good to go I believe 👍
Will then need another approval, e.g. @ewels or @drpatelh :-)

Oh. Ok then. Ill have a look :+1:

See https://github.com/nf-core/rnaseq/pull/314


Gravity option for wand.image.Image.crop

This pull request resolves issue #222. It introduces gravity keyword argument to Image.crop. If said argument is given, it auto-assignes x & y offsets based gravity type.
Example:
from wand.image import Image
with Image(filename='rose:') as image:
    image.crop(width=20, height=20, gravity='center')

Coverage decreased (-0.9%) to 84.23% when pulling 8ba7948f453ab15d610ba8d795b62fc3fbe5628c on emcconville:issue-222-gravity-crop into bcd9ea68b3d582147dc20c66dba3fb19f11ba572 on dahlia:0.4-maintenance.

Coverage decreased (-0.9%) to 84.23% when pulling f0cd1ae3d9925ec8bd36d63b68273a9d51d68343 on emcconville:issue-222-gravity-crop into bcd9ea68b3d582147dc20c66dba3fb19f11ba572 on dahlia:0.4-maintenance.

Coverage decreased (-0.9%) to 84.23% when pulling f0cd1ae3d9925ec8bd36d63b68273a9d51d68343 on emcconville:issue-222-gravity-crop into bcd9ea68b3d582147dc20c66dba3fb19f11ba572 on dahlia:0.4-maintenance.

Coverage decreased (-0.9%) to 84.23% when pulling f0cd1ae3d9925ec8bd36d63b68273a9d51d68343 on emcconville:issue-222-gravity-crop into bcd9ea68b3d582147dc20c66dba3fb19f11ba572 on dahlia:0.4-maintenance.

Coverage increased (+0.09%) to 85.22% when pulling 934c51b1c3978ba39dff403b7767a167fa34a7dc on emcconville:issue-222-gravity-crop into bcd9ea68b3d582147dc20c66dba3fb19f11ba572 on dahlia:0.4-maintenance.

Coverage increased (+0.09%) to 85.22% when pulling 934c51b1c3978ba39dff403b7767a167fa34a7dc on emcconville:issue-222-gravity-crop into bcd9ea68b3d582147dc20c66dba3fb19f11ba572 on dahlia:0.4-maintenance.

Coverage increased (+0.09%) to 85.22% when pulling 934c51b1c3978ba39dff403b7767a167fa34a7dc on emcconville:issue-222-gravity-crop into bcd9ea68b3d582147dc20c66dba3fb19f11ba572 on dahlia:0.4-maintenance.

Thank you!  I will merge it if you write changelog for this.

Coverage increased (+0.09%) to 85.22% when pulling 6f5406bf8100a8eb49ef291b1cfaacd70117f808 on emcconville:issue-222-gravity-crop into bcd9ea68b3d582147dc20c66dba3fb19f11ba572 on dahlia:0.4-maintenance.


Gravity

I use RTL direction and I need to use dialog box with gravity of right, however there isn't such an option in your GravityEnum. Also it does not contain CENTER_HORIZONTAL gravity which you've used in your demo code (https://github.com/afollestad/material-dialogs#gravity) .
So how is it possible to change the gravity to right?

Are you not familiar with how gravity works on Android Jellybean and above?
Left is replaced with start, right is replaced with end. I updated the README, that was a typo.

On RTL devices, right and left get flipped around automatically. Start becomes right instead of left, and end becomes left instead of right.


Add '--strict' flag respect

In #8 job with skipped scenario will pass the test(see here) I think it should be configurable with a strict flag to decide if skipped scenarios should fail the whole test.

Well, this is not exactly skipped scenario - this scenario is not even taken to test function. So I don't think that --strict flag would do anything in that case.

The Behat run inside Behat is already run with --strict, in fact skipping features with #8 does not mark tests are skipped.
Please reopen if @Zales0123 or me are missing something with :tada:


Added CheckedConsumer.andThen()

Codecov Report

Merging #2107 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #2107      +/-   ##
============================================
- Coverage      97.5%   97.48%   -0.02%
  Complexity     5196     5196
============================================
  Files            92       93       +1
  Lines         11932    11934       +2
  Branches       1576     1576
============================================
  Hits          11634    11634
- Misses          148      150       +2
  Partials        150      150

Impacted Files
Coverage Δ
Complexity Δ

vavr/src/main/java/io/vavr/CheckedConsumer.java
0% <0%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb47ca...60502d4. Read the comment docs.


BUG Add navbar to feedback page

Describe the bug

add navbar to feedback page
Expected behavior

navbar is required to feedback page
Screenshots (Mandatory)

Additional Context (Mandatory )
Are you contributing under any open-source program ?

JWOC

@apu52  pls assign me under JWOC

@AftabMankapure The over all feedback pg is not linked with CSS file maybe. try to fix that also.

@apu52 thank for you support see you again in any other Competition

@apu52 thank for you support see you again in any other Competition

same to you. Thanks for all of your great contributions


[BUG]: Table view toggle button gets enabled for Heatmap chart

What is the bug?
After removing stats from the PPL query when we select Heatmap chart from the chart selector the table view gets enabled and when we click on table view toggle button the page turns blank
How can one reproduce the bug?
Steps to reproduce the behavior:

Go to Observability/Event Analytics/Explorer page
Navigate to Visualizations page
Remove stats section from the PPL query and click on Refresh button
Select the Heatmap chart option from chart selector dropdown
Click on table view toggle button
Observe the issue

What is the expected behavior?
If we don't have stats in the PPL query then the table view toggle button should be disabled
Do you have any screenshots?

@anirudha @mengweieric
cc: @abasatwar @spattnaik

Bug has been fixed and tested.


find panic reboots with /usr/bin/last

Wow nice hack! Thanks.

And thank you for maintaining this!


make is easy to configure this via inventory

What does this Pull Request do?
Make the urls as variable so they can be configured more easily in the inventory.
How should this be tested?

Replace the role with the PR
Vagrant up
Verify the things get index in Fedora

Interested parties
@Islandora-Devops/committers

@whikloj
Addressed your feedback.
Triplestore url is used here as well: https://github.com/Islandora-Devops/ansible-role-blazegraph.  Will update that role as well.

vagrant up


Database Navigator: group table names by prefix #ux #roomsaver

Is your feature request related to a problem? Please describe.
I have databases with really long and verbose table names, i.e.:
  ..
  module_xx
  module_todo
  module_todo_category
  module_todo_category_toggl_link
  module_todo_dependency
  module_todo_menu
  module_todo_menu_item
  module_todo_type
  module_todo_type_keyword
  module_todo_type_keyword_option
  module_todo_type_option
  module_todo_type_option_link
  module_yy
  ..

This means I have to extend the Navigator sidebar really wide so I could see what I'm dealing with. Wasting screen space I need for writing queries and seeing results.
Describe the solution you'd like
an option to enable table name prefix hiding, so that list would be:
  ..
*module*
	_xx
	_todo
	    _category
	    _toggl_link
	    _dependency
	    _menu
	    _item
	    _type
	    _keyword
		    _option
		      _option
		       _option_link
	_yy
  ..

every line should correspond to the actual table its shortened for
unless if there is not a root table for that prexix, its just a meta line (like with module)
also note how the _*_link tables are positioned. the middle group meta line is omitted from the tree, since it would not affect readability
ofcourse using a more compact symbol instead of the  chars used in this example
Describe alternatives you've considered
adding another physical display for Navigator :dagger: :D
Additional context
as a bonus, those groups could be collapsible too (default: exploded)

This sounds like a good idea. Thank you!

whats the prognosis? :)


Store parsed data more similarly to provided data

With https://github.com/chartjs/Chart.js/pull/6768 merged and parsing: false, the uPlot benchmark is still spending about 10% of its time in _parse. This PR brings it down to a trivial amount.
I think what is happening in master is that by adding a new _parsed attribute to the element that the element can sometimes no longer fit in the memory allocated to it and so new memory must be allocated with the old being garbage collected. By just using the data directly we see a very big speedup

hey @benmccann would you mind throwing me a PR into the uPlot repo with the Chart.js updates needed to run the current v3? i'd like to test periodically :)

done! see here: https://github.com/leeoniya/uPlot/pull/65

This is very similar to #6816 in performance:


Log error when JsonWebKey parameter types are not as expected

Parameters are expected to be strings, if not we need to log the error.
see: public JsonWebKey(IDictionary<string, object> dictionary)

We should consider if the constructor that takes a dictionary makes sense first. we should lock on the design for Beta7.

We don't fix it in 4.x since there is no logging module.


Refactor Question - Improving ImportExcel module import time

Hi @dfinke,
Are you open to a PR to change the way the module is "built" for testing and publishing to reduce the amount of time it takes to import the module?
On my Windows 11 laptop it takes ~7.5 seconds to import the module in PowerShell 5.1 as published to PSGallery. The bulk of that time is spent on dot-sourcing the .PS1 files in the Private, Public, Charting, InferData, and Pivot subfolders. The next longest import step is importing plot.ps1 which only takes ~98 milliseconds.
In a quick and dirty test where I take all the contents of those subfolders and embed them in the .PSM1 file, the import time drops to only 362 milliseconds. The issue is less noticeable in PowerShell 7 where the current import time is only 1.1 seconds, but "compiling" all the functions into the .PSM1 file still reduces the import time by 20x, down to 53 milliseconds.
I haven't started yet but the idea would be to keep the current project structure, and change the build/CI process so that the version of the module being tested and published is "compiled" by inserting as much as possible into the PSM1 file beforehand.
I use this pattern another module where there are a total of 197 files in the Classes, Public, and Private folders with each function residing in its own file. The published version of the PSM1 file has over 15k lines and imports in ~3.6 seconds.

Thanks for the question. Have thought about that for a while. I'd be open to it.
I'm running Win 11 both version of PS import using -force in ~2 sec.
I have not thought through the scenarios where bugs could arise or debugging efforts.

Okay, I'll get started! What's your current CI? I see references to Azure DevOps, AppVeyor, and GitHub Actions and I'm not sure if DevOps/AppVeyor are still being used or if those references are stale.

Thanks, really appreaciate it! GitHub Actions is preferred. Az is still enabled.
Note: I'm not sure how I can get this into enough folks hands or forewarn users of this sizable and potential impact. Also, I an not confident of the test coverage to uncover issues.
Additionally. I have other commitments. I may not get to review this for some time.
Given these risks, it could be months before I decide against it or merge the PR.

Thanks for the notice - I can understand that. If you end up merging any of it, maybe it marks a major version increment to signal that there might be breaking changes (even though the goal is that there aren't).
Looking at the repo a bit closer, there are some other structural changes I think could improve the developer experience, including the addition of a pwsh devcontainer. I don't think any changes I have in mind would make a difference to module users other than to improve the import time, but I know any change like this can have unintended side effects.

I may have gotten a bit carried away... however, the tests pass on all three OS's and the import times are significantly faster when importing the "compiled" copy. I won't send a PR until we've had a chance to chat about all the changes, and to make sure that the CI pipelines and dev experience are 100%, and I understand that may not happen for a while - no worries. I may take a look at some of the open issues or submit a couple bug fixes separately.
Here's a rundown of the changes which you can view at joshooaj/ImportExcel. One of the neat additions is the devcontainer so that you can launch a codespace on GitHub or build in a devcontainer on your local machine if you have docker installed. You should try running the command mkdocs serve from a codespace or devcontainer - it'll start serving a dev copy of the ImportExcel docs site which is (for now) published to GitHub Pages under my repo.

Moved all module source into the ImportExcel subfolder.
Moved all documentation / examples into the docs subfolder.
Added build.ps1 as an entry-point to build the module. Building...

Creates an output folder at Output/ImportExcel/version/.
Copies the contents of ImportExcel/ to the output folder.
Merges the files that are normally dot-sourced into ImportExcel.psm1.
Removes unneeded subfolders and files from the output module folder.

Added RunTests.ps1 to configure and run Pester.

Fixed a test that had unpredictable results because it depended on the OS "system" folder having a minimum number and assortment of files.
Added Before.tests.ps1 with a BeforeDiscovery and BeforeAll block where the freshly compiled ImportExcel module can be imported once and used in the rest of the tests without importing in each individual file. Though maybe this should change for better compatibility with the Pester VSCode extension?

Fixed a handful of SuppressMessageAttribute attributes attached to empty param blocks outside of any function - this caused an issue when merging standalone PS1 files into the PSM1 file.
Changed the way Import-LocalizedData was used to make it cleaner, and easier to support localization in the future.
Added .devcontainer/devcontainer.json with Dockerfile to provide a ready-to-run dev experience.
Added launch and build configs for VSCode to provide F5 and CTRL+Shift+B support.
Added mkdocs.yml and made some minor changes to docs files to improve the appearance of docs built by mkdocs.
Added docs.yml GHA workflow for publishing to GH-Pages.
Updated GitHub Actions to build/test and publish pester test results, and added a new workflow for building and publishing the docs site from the contents of the docs folder.

Sweet! If you're up for it. I can schedule a zoom chat and you can level set me so I can let it percolate.

Sounds good, I'm free today and pretty flexible any other day so feel free to shoot an invite over to joshooaj at gmail any time 😎


No validation failures reported using RuleFor().Custom(x=> x)

System Details

FluentValidation versions:

<IP_ADDRESS>
8.0.0-rc1

Issue Description
I'm currently migrating vom FluentValidation <IP_ADDRESS> to <IP_ADDRESS>. In our project there are a few validators that define rules like this:
Custom(e => new ValidationFailure(string.Empty, "ERROR"));

The Custom() method is marked as obsolete and the appropriate warning (CS0618) recommends using RuleFor().Custom() instead. But using this method, no errors are reported.
Example:
class Program
{
  static void Main(string[] args)
  {
    var validator = new EntityValidator();
    var entity = new Entity();

    var result = validator.Validate(entity);
  }

  public class EntityValidator : AbstractValidator<Entity>
  {
    public EntityValidator()
    {
      this.RuleFor(e => e).Custom((e, ctx) => new ValidationFailure(string.Empty, "ERROR FROM RECOMMENDED METHOD"));
      this.Custom(e => new ValidationFailure(string.Empty, "ERROR FROM OBSOLETE METHOD"));
    }
  }

  public class Entity { }
}

result only contains the validation failure "ERROR FROM OBSOLETE METHOD". The failure "ERROR FROM RECOMMENDED METHOD" is not included in result.
Version 8.0.0-rc1 is also affected.

Hi, your call to Custom isn’t right. You need to call ctx.AddFailure to record the custom error message.
Please see the documentation for details: https://fluentvalidation.net/custom-validators#writing-a-custom-validator

Ok, sorry!
Don't know why I haven't seen that this is an Action, not a Func.


Update LICENSE.txt

Minor change to the copyright statement to match EPFL style.

Please retest.

superseded by #538


yabai sometimes crashes after I close a window

So, every once in a while after I close a window using ⌘W, yabai crashes. It doesn't happen under any other circumstances, it crashes only after I close a window.
yabai-v5.0.1, but it happened before (4.x.idontremember). OS 12.6, Intel Mac. I have two monitors if it's relevant.
Crash report
-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               yabai [48986]
Path:                  /usr/local/opt/yabai/bin/yabai
Identifier:            yabai
Version:               ???
Code Type:             X86-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2022-10-06 08:37:07.8688 +0300
OS Version:            macOS 12.6 (21G115)
Report Version:        12
Anonymous UUID:        8D30552F-49D8-7448-9CC3-D0FBD38D8EF5

Sleep/Wake UUID:       B0DEA142-1B02-4335-A13A-7933971CBA76

Time Awake Since Boot: 250000 seconds
Time Since Wake:       229386 seconds

System Integrity Protection: disabled

Crashed Thread:        1

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Application Specific Information:
abort() called

Kernel Triage:
VM - Compressor failed a blocking pager_get

Thread 0::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	    0x7ff80421897a mach_msg_trap + 10
1   libsystem_kernel.dylib        	    0x7ff804218ce8 mach_msg + 56
2   CoreFoundation                	    0x7ff80431c36d __CFRunLoopServiceMachPort + 319
3   CoreFoundation                	    0x7ff80431a9f8 __CFRunLoopRun + 1276
4   CoreFoundation                	    0x7ff804319e3c CFRunLoopRunSpecific + 562
5   yabai                         	       0x101206704 main + 1972
6   dyld                          	       0x107f3252e start + 462

Thread 1 Crashed:
0   libsystem_kernel.dylib        	    0x7ff80421f00e __pthread_kill + 10
1   libsystem_pthread.dylib       	    0x7ff8042551ff pthread_kill + 263
2   libsystem_c.dylib             	    0x7ff8041a0d24 abort + 123
3   SkyLight                      	    0x7ff80935b23a iterator_seek + 220
4   SkyLight                      	    0x7ff80935b788 SLSWindowIteratorGetTags + 32
5   yabai                         	       0x1011f30e4 window_tags + 132
6   yabai                         	       0x1011f25db window_serialize + 491
7   yabai                         	       0x1011fa126 window_manager_query_windows_for_spaces + 470
8   yabai                         	       0x1011e9540 handle_message + 29600
9   yabai                         	       0x10120d66f EVENT_HANDLER_DAEMON_MESSAGE + 319
10  yabai                         	       0x1011ded0e event_loop_run + 158
11  libsystem_pthread.dylib       	    0x7ff8042554e1 _pthread_start + 125
12  libsystem_pthread.dylib       	    0x7ff804250f6b thread_start + 15

Thread 2:
0   libsystem_kernel.dylib        	    0x7ff80421f092 __accept + 10
1   yabai                         	       0x1011ed28c message_loop_run + 60
2   libsystem_pthread.dylib       	    0x7ff8042554e1 _pthread_start + 125
3   libsystem_pthread.dylib       	    0x7ff804250f6b thread_start + 15

Thread 3:
0   libsystem_pthread.dylib       	    0x7ff804250f48 start_wqthread + 0

Thread 4:
0   libsystem_pthread.dylib       	    0x7ff804250f48 start_wqthread + 0

Thread 1 crashed with X86 Thread State (64-bit):
  rax: 0x0000000000000000  rbx: 0x000070000316d000  rcx: 0x000070000316c4a8  rdx: 0x0000000000000000
  rdi: 0x000000000000a60f  rsi: 0x0000000000000006  rbp: 0x000070000316c4d0  rsp: 0x000070000316c4a8
   r8: 0x00007ff80935b0e6   r9: 0x0000000000000260  r10: 0x0000000000000000  r11: 0x0000000000000246
  r12: 0x000000000000a60f  r13: 0x0000600001780640  r14: 0x0000000000000006  r15: 0x0000000000000016
  rip: 0x00007ff80421f00e  rfl: 0x0000000000000246  cr2: 0x000000012f9c1000

Logical CPU:     0
Error Code:      0x02000148
Trap Number:     133

Binary Images:
    0x7ff804217000 -     0x7ff80424efff libsystem_kernel.dylib (*) <8cc28466-fd2f-3c80-9834-9525b7beac19> /usr/lib/system/libsystem_kernel.dylib
    0x7ff80429c000 -     0x7ff80479efff com.apple.CoreFoundation (6.9) <93c48919-68af-367e-9a67-db4159bc962c> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
       0x1011db000 -        0x101216fff yabai (*) <0caeb122-a126-3c17-8a3d-8040c9654c77> /usr/local/Cellar/yabai/5.0.1/bin/yabai
       0x107f2d000 -        0x107f98fff dyld (*) <71febccd-d9dc-3599-9971-2b3407c588a8> /usr/lib/dyld
    0x7ff80424f000 -     0x7ff80425afff libsystem_pthread.dylib (*) <b5454e27-e8c7-3fdb-b77f-714f1e82e70b> /usr/lib/system/libsystem_pthread.dylib
    0x7ff80411f000 -     0x7ff8041a7fff libsystem_c.dylib (*) <e42e9d7a-03b4-340b-b61e-dcd45fd4acc0> /usr/lib/system/libsystem_c.dylib
    0x7ff809220000 -     0x7ff8095befff com.apple.SkyLight (1.600.0) <6563e632-526d-3c88-8035-049fcca8ca93> /System/Library/PrivateFrameworks/SkyLight.framework/Versions/A/SkyLight

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 7
    thread_create: 7
    thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=846.6M resident=0K(0%) swapped_out_or_unallocated=846.6M(100%)
Writable regions: Total=1.3G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=1.3G(100%)

                                VIRTUAL   REGION
REGION TYPE                        SIZE    COUNT (non-coalesced)
===========                     =======  =======
Activity Tracing                   256K        1
ColorSync                          204K       23
CoreGraphics                         8K        1
Kernel Alloc Once                    8K        1
MALLOC                           256.7M       35
MALLOC guard page                   24K        5
MALLOC_MEDIUM (reserved)         720.0M        6         reserved VM address space (unallocated)
MALLOC_NANO (reserved)           384.0M        1         reserved VM address space (unallocated)
ObjC additional data                15K        1
STACK GUARD                       56.0M        5
Stack                             10.0M        5
VM_ALLOCATE                       4768K       11
__CTF                               756        1
__DATA                            17.4M      283
__DATA_CONST                      12.0M      167
__DATA_DIRTY                       534K       97
__FONT_DATA                          4K        1
__LINKEDIT                       645.4M        8
__TEXT                           201.2M      303
__UNICODE                          592K        1
dyld private memory               1024K        1
mapped file                       44.5M        8
shared memory                      768K       14
===========                     =======  =======
TOTAL                              2.3G      979
TOTAL, minus reserved VM space     1.2G      979

-----------
Full Report
-----------

{"app_name":"yabai","timestamp":"2022-10-06 08:37:08.00 +0300","app_version":"","slice_uuid":"0caeb122-a126-3c17-8a3d-8040c9654c77","build_version":"","platform":1,"share_with_app_devs":1,"is_first_party":1,"bug_type":"309","os_version":"macOS 12.6 (21G115)","incident_id":"28A874BA-3DF8-4D91-AA56-2BC0F549DA26","name":"yabai"}
{
  "uptime" : 250000,
  "procLaunch" : "2022-10-03 01:43:15.6445 +0300",
  "procRole" : "Unspecified",
  "version" : 2,
  "userID" : 501,
  "deployVersion" : 210,
  "modelCode" : "iMac18,3",
  "procStartAbsTime" :<PHONE_NUMBER>8699,
  "coalitionID" : 610,
  "osVersion" : {
    "train" : "macOS 12.6",
    "build" : "21G115",
    "releaseType" : "User"
  },
  "captureTime" : "2022-10-06 08:37:07.8688 +0300",
  "incident" : "28A874BA-3DF8-4D91-AA56-2BC0F549DA26",
  "bug_type" : "309",
  "pid" : 48986,
  "procExitAbsTime" :<PHONE_NUMBER>36993,
  "cpuType" : "X86-64",
  "procName" : "yabai",
  "procPath" : "\/usr\/local\/opt\/yabai\/bin\/yabai",
  "parentProc" : "launchd",
  "parentPid" : 1,
  "coalitionName" : "homebrew.mxcl.yabai",
  "crashReporterKey" : "8D30552F-49D8-7448-9CC3-D0FBD38D8EF5",
  "wakeTime" : 229386,
  "sleepWakeUUID" : "B0DEA142-1B02-4335-A13A-7933971CBA76",
  "sip" : "disabled",
  "isCorpse" : 1,
  "exception" : {"codes":"0x0000000000000000, 0x0000000000000000","rawCodes":[0,0],"type":"EXC_CRASH","signal":"SIGABRT"},
  "ktriageinfo" : "VM - Compressor failed a blocking pager_get\n",
  "asi" : {"libsystem_c.dylib":["abort() called"]},
  "extMods" : {"caller":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"system":{"thread_create":7,"thread_set_state":0,"task_for_pid":7},"targeted":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"warnings":0},
  "faultingThread" : 1,
  "threads" : [{"id":1936802,"queue":"com.apple.main-thread","frames":[{"imageOffset":6522,"symbol":"mach_msg_trap","symbolLocation":10,"imageIndex":0},{"imageOffset":7400,"symbol":"mach_msg","symbolLocation":56,"imageIndex":0},{"imageOffset":525165,"symbol":"__CFRunLoopServiceMachPort","symbolLocation":319,"imageIndex":1},{"imageOffset":518648,"symbol":"__CFRunLoopRun","symbolLocation":1276,"imageIndex":1},{"imageOffset":515644,"symbol":"CFRunLoopRunSpecific","symbolLocation":562,"imageIndex":1},{"imageOffset":177924,"symbol":"main","symbolLocation":1972,"imageIndex":2},{"imageOffset":21806,"symbol":"start","symbolLocation":462,"imageIndex":3}]},{"triggered":true,"id":1936929,"threadState":{"r13":{"value":105553140909632},"rax":{"value":0},"rflags":{"value":582},"cpu":{"value":0},"r14":{"value":6},"rsi":{"value":6},"r8":{"value":140703283130598,"symbolLocation":0,"symbol":"reset_window"},"cr2":{"value":5093724160},"rdx":{"value":0},"r10":{"value":0},"r9":{"value":608},"r15":{"value":22},"rbx":{"value":123145354137600},"trap":{"value":133},"err":{"value":33554760},"r11":{"value":582},"rip":{"value":140703197949966,"matchesCrashFrame":1},"rbp":{"value":123145354134736},"rsp":{"value":123145354134696},"r12":{"value":42511},"rcx":{"value":123145354134696},"flavor":"x86_THREAD_STATE","rdi":{"value":42511}},"frames":[{"imageOffset":32782,"symbol":"__pthread_kill","symbolLocation":10,"imageIndex":0},{"imageOffset":25087,"symbol":"pthread_kill","symbolLocation":263,"imageIndex":4},{"imageOffset":531748,"symbol":"abort","symbolLocation":123,"imageIndex":5},{"imageOffset":1290810,"symbol":"iterator_seek","symbolLocation":220,"imageIndex":6},{"imageOffset":1292168,"symbol":"SLSWindowIteratorGetTags","symbolLocation":32,"imageIndex":6},{"imageOffset":98532,"symbol":"window_tags","symbolLocation":132,"imageIndex":2},{"imageOffset":95707,"symbol":"window_serialize","symbolLocation":491,"imageIndex":2},{"imageOffset":127270,"symbol":"window_manager_query_windows_for_spaces","symbolLocation":470,"imageIndex":2},{"imageOffset":58688,"symbol":"handle_message","symbolLocation":29600,"imageIndex":2},{"imageOffset":206447,"symbol":"EVENT_HANDLER_DAEMON_MESSAGE","symbolLocation":319,"imageIndex":2},{"imageOffset":15630,"symbol":"event_loop_run","symbolLocation":158,"imageIndex":2},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":4},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":4}]},{"id":1936955,"frames":[{"imageOffset":32914,"symbol":"__accept","symbolLocation":10,"imageIndex":0},{"imageOffset":74380,"symbol":"message_loop_run","symbolLocation":60,"imageIndex":2},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":4},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":4}]},{"id":19507301,"frames":[{"imageOffset":8008,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":4}]},{"id":19508793,"frames":[{"imageOffset":8008,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":4}]}],
  "usedImages" : [
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>17184,
    "size" : 229376,
    "uuid" : "8cc28466-fd2f-3c80-9834-9525b7beac19",
    "path" : "\/usr\/lib\/system\/libsystem_kernel.dylib",
    "name" : "libsystem_kernel.dylib"
  },
  {
    "source" : "P",
    "arch" : "x86_64h",
    "base" :<PHONE_NUMBER>61952,
    "CFBundleShortVersionString" : "6.9",
    "CFBundleIdentifier" : "com.apple.CoreFoundation",
    "size" : 5255168,
    "uuid" : "93c48919-68af-367e-9a67-db4159bc962c",
    "path" : "\/System\/Library\/Frameworks\/CoreFoundation.framework\/Versions\/A\/CoreFoundation",
    "name" : "CoreFoundation",
    "CFBundleVersion" : "1866"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>,
    "size" : 245760,
    "uuid" : "0caeb122-a126-3c17-8a3d-8040c9654c77",
    "path" : "\/usr\/local\/Cellar\/yabai\/5.0.1\/bin\/yabai",
    "name" : "yabai"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>,
    "size" : 442368,
    "uuid" : "71febccd-d9dc-3599-9971-2b3407c588a8",
    "path" : "\/usr\/lib\/dyld",
    "name" : "dyld"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>46560,
    "size" : 49152,
    "uuid" : "b5454e27-e8c7-3fdb-b77f-714f1e82e70b",
    "path" : "\/usr\/lib\/system\/libsystem_pthread.dylib",
    "name" : "libsystem_pthread.dylib"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>01376,
    "size" : 561152,
    "uuid" : "e42e9d7a-03b4-340b-b61e-dcd45fd4acc0",
    "path" : "\/usr\/lib\/system\/libsystem_c.dylib",
    "name" : "libsystem_c.dylib"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>40128,
    "CFBundleShortVersionString" : "1.600.0",
    "CFBundleIdentifier" : "com.apple.SkyLight",
    "size" : 3796992,
    "uuid" : "6563e632-526d-3c88-8035-049fcca8ca93",
    "path" : "\/System\/Library\/PrivateFrameworks\/SkyLight.framework\/Versions\/A\/SkyLight",
    "name" : "SkyLight"
  }
],
  "sharedCache" : {
  "base" :<PHONE_NUMBER>90240,
  "size" :<PHONE_NUMBER>8,
  "uuid" : "73669942-bd8a-3e40-951f-7fbe07b51cb8"
},
  "vmSummary" : "ReadOnly portion of Libraries: Total=846.6M resident=0K(0%) swapped_out_or_unallocated=846.6M(100%)\nWritable regions: Total=1.3G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=1.3G(100%)\n\n                                VIRTUAL   REGION \nREGION TYPE                        SIZE    COUNT (non-coalesced) \n===========                     =======  ======= \nActivity Tracing                   256K        1 \nColorSync                          204K       23 \nCoreGraphics                         8K        1 \nKernel Alloc Once                    8K        1 \nMALLOC                           256.7M       35 \nMALLOC guard page                   24K        5 \nMALLOC_MEDIUM (reserved)         720.0M        6         reserved VM address space (unallocated)\nMALLOC_NANO (reserved)           384.0M        1         reserved VM address space (unallocated)\nObjC additional data                15K        1 \nSTACK GUARD                       56.0M        5 \nStack                             10.0M        5 \nVM_ALLOCATE                       4768K       11 \n__CTF                               756        1 \n__DATA                            17.4M      283 \n__DATA_CONST                      12.0M      167 \n__DATA_DIRTY                       534K       97 \n__FONT_DATA                          4K        1 \n__LINKEDIT                       645.4M        8 \n__TEXT                           201.2M      303 \n__UNICODE                          592K        1 \ndyld private memory               1024K        1 \nmapped file                       44.5M        8 \nshared memory                      768K       14 \n===========                     =======  ======= \nTOTAL                              2.3G      979 \nTOTAL, minus reserved VM space     1.2G      979 \n",
  "legacyInfo" : {
  "threadTriggered" : {

  }
},
  "trialInfo" : {
  "rollouts" : [
    {
      "rolloutId" : "5fb4245a1bbfe8005e33a1e1",
      "factorPackIds" : {

      },
      "deploymentId" : 240000015
    },
    {
      "rolloutId" : "5fc94383418129005b4e9ae0",
      "factorPackIds" : {

      },
      "deploymentId" : 240000486
    }
  ],
  "experiments" : [
    {
      "treatmentId" : "5b729754-3882-4560-826f-9c0bc27d77c6",
      "experimentId" : "6192fb082171a2330e561df0",
      "deploymentId" : 400000035
    }
  ]
}
}

I think it's related to #1395

I'm experiencing the same issue and while I can confirm that it has also been happening on v4, frequency increased a lot with v5 release. I have a default stack layout but set some spaces to bsp and this bug results in the bsps being lost.
I think I can work around that using rules in the meantime, but would still be nice if it got fixed :)

The issue revealed by the above stack trace should be resolved on master.

The issue revealed by the above stack trace should be resolved on master.

Tested this by installing yabai using brew install yabai --HEAD and unfortunately ran into this issue again.
I also realized this time it's actually reproducable - it happens whenever I close a kitty window by using exit in the running shell.
Here's another error log from today:
-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               yabai [71177]
Path:                  /usr/local/opt/yabai/bin/yabai
Identifier:            yabai
Version:               ???
Code Type:             X86-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2022-10-18 03:40:16.8866 +0200
OS Version:            macOS 12.6 (21G115)
Report Version:        12
Bridge OS Version:     6.6 (19P6067)
Anonymous UUID:        D70781EE-C5E8-7FD1-576B-7B4736DFDC69

Time Awake Since Boot: 3300 seconds

System Integrity Protection: disabled

Crashed Thread:        1

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Application Specific Information:
abort() called

Thread 0::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	    0x7ff8065e397a mach_msg_trap + 10
1   libsystem_kernel.dylib        	    0x7ff8065e3ce8 mach_msg + 56
2   CoreFoundation                	    0x7ff8066e736d __CFRunLoopServiceMachPort + 319
3   CoreFoundation                	    0x7ff8066e59f8 __CFRunLoopRun + 1276
4   CoreFoundation                	    0x7ff8066e4e3c CFRunLoopRunSpecific + 562
5   yabai                         	       0x10e6ff3f4 main + 1956
6   dyld                          	       0x116b1e52e start + 462

Thread 1 Crashed:
0   libsystem_kernel.dylib        	    0x7ff8065ea00e __pthread_kill + 10
1   libsystem_pthread.dylib       	    0x7ff8066201ff pthread_kill + 263
2   libsystem_c.dylib             	    0x7ff80656bd24 abort + 123
3   SkyLight                      	    0x7ff80b72623a iterator_seek + 220
4   SkyLight                      	    0x7ff80b726788 SLSWindowIteratorGetTags + 32
5   yabai                         	       0x10e6ebb5e window_tags + 142
6   yabai                         	       0x10e6eb062 window_serialize + 482
7   yabai                         	       0x10e6dfdf8 handle_message + 28712
8   yabai                         	       0x10e70635f EVENT_HANDLER_DAEMON_MESSAGE + 319
9   yabai                         	       0x10e6d58ce event_loop_run + 158
10  libsystem_pthread.dylib       	    0x7ff8066204e1 _pthread_start + 125
11  libsystem_pthread.dylib       	    0x7ff80661bf6b thread_start + 15

Thread 2:
0   libsystem_kernel.dylib        	    0x7ff8065ea092 __accept + 10
1   yabai                         	       0x10e6e5ccc message_loop_run + 60
2   libsystem_pthread.dylib       	    0x7ff8066204e1 _pthread_start + 125
3   libsystem_pthread.dylib       	    0x7ff80661bf6b thread_start + 15

Thread 3:
0   libsystem_pthread.dylib       	    0x7ff80661bf48 start_wqthread + 0

Thread 4:
0   libsystem_pthread.dylib       	    0x7ff80661bf48 start_wqthread + 0

Thread 5:
0   libsystem_pthread.dylib       	    0x7ff80661bf48 start_wqthread + 0

Thread 1 crashed with X86 Thread State (64-bit):
  rax: 0x0000000000000000  rbx: 0x000070000d4ad000  rcx: 0x000070000d4ac518  rdx: 0x0000000000000000
  rdi: 0x0000000000005607  rsi: 0x0000000000000006  rbp: 0x000070000d4ac540  rsp: 0x000070000d4ac518
   r8: 0x00007ff80b7260e6   r9: 0x0000000000000125  r10: 0x0000000000000000  r11: 0x0000000000000246
  r12: 0x0000000000005607  r13: 0x00006000003687a0  r14: 0x0000000000000006  r15: 0x0000000000000016
  rip: 0x00007ff8065ea00e  rfl: 0x0000000000000246  cr2: 0x00007fee91f0532e

Logical CPU:     0
Error Code:      0x02000148
Trap Number:     133

Binary Images:
    0x7ff8065e2000 -     0x7ff806619fff libsystem_kernel.dylib (*) <8cc28466-fd2f-3c80-9834-9525b7beac19> /usr/lib/system/libsystem_kernel.dylib
    0x7ff806667000 -     0x7ff806b69fff com.apple.CoreFoundation (6.9) <93c48919-68af-367e-9a67-db4159bc962c> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
       0x10e6d0000 -        0x10e70ffff yabai (*) <7d31ddce-5874-3924-86ab-8b0f386f8220> /usr/local/Cellar/yabai/HEAD-c888d80/bin/yabai
       0x116b19000 -        0x116b84fff dyld (*) <71febccd-d9dc-3599-9971-2b3407c588a8> /usr/lib/dyld
    0x7ff80661a000 -     0x7ff806625fff libsystem_pthread.dylib (*) <b5454e27-e8c7-3fdb-b77f-714f1e82e70b> /usr/lib/system/libsystem_pthread.dylib
    0x7ff8064ea000 -     0x7ff806572fff libsystem_c.dylib (*) <e42e9d7a-03b4-340b-b61e-dcd45fd4acc0> /usr/lib/system/libsystem_c.dylib
    0x7ff80b5eb000 -     0x7ff80b989fff com.apple.SkyLight (1.600.0) <6563e632-526d-3c88-8035-049fcca8ca93> /System/Library/PrivateFrameworks/SkyLight.framework/Versions/A/SkyLight

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 4
    thread_create: 4
    thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=846.6M resident=0K(0%) swapped_out_or_unallocated=846.6M(100%)
Writable regions: Total=1.3G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=1.3G(100%)

                                VIRTUAL   REGION
REGION TYPE                        SIZE    COUNT (non-coalesced)
===========                     =======  =======
Activity Tracing                   256K        1
CG backing stores                318.2M        8
ColorSync                          204K       23
CoreGraphics                         8K        2
Kernel Alloc Once                    8K        1
MALLOC                           383.4M       57
MALLOC guard page                   24K        5
MALLOC_MEDIUM (reserved)         240.0M        2         reserved VM address space (unallocated)
MALLOC_NANO (reserved)           384.0M        1         reserved VM address space (unallocated)
ObjC additional data                15K        1
STACK GUARD                       56.0M        6
Stack                             10.5M        6
VM_ALLOCATE                       4808K       21
__CTF                               756        1
__DATA                            17.4M      282
__DATA_CONST                      12.0M      167
__DATA_DIRTY                       534K       97
__FONT_DATA                          4K        1
__LINKEDIT                       645.4M        8
__TEXT                           201.2M      303
__UNICODE                          592K        1
dyld private memory               1024K        1
mapped file                       53.4M       12
shared memory                      792K       17
===========                     =======  =======
TOTAL                              2.3G     1024
TOTAL, minus reserved VM space     1.7G     1024

-----------
Full Report
-----------

{"app_name":"yabai","timestamp":"2022-10-18 03:40:16.00 +0200","app_version":"","slice_uuid":"7d31ddce-5874-3924-86ab-8b0f386f8220","build_version":"","platform":1,"share_with_app_devs":0,"is_first_party":1,"bug_type":"309","os_version":"macOS 12.6 (21G115)","incident_id":"F129D220-E208-46F4-BDD6-BEF264C32552","name":"yabai"}
{
  "uptime" : 3300,
  "procLaunch" : "2022-10-18 03:36:19.4344 +0200",
  "procRole" : "Unspecified",
  "version" : 2,
  "userID" : 501,
  "deployVersion" : 210,
  "modelCode" : "iMac20,2",
  "procStartAbsTime" :<PHONE_NUMBER>769,
  "coalitionID" : 7912,
  "osVersion" : {
    "train" : "macOS 12.6",
    "build" : "21G115",
    "releaseType" : "User"
  },
  "captureTime" : "2022-10-18 03:40:16.8866 +0200",
  "incident" : "F129D220-E208-46F4-BDD6-BEF264C32552",
  "bug_type" : "309",
  "pid" : 71177,
  "procExitAbsTime" :<PHONE_NUMBER>239,
  "cpuType" : "X86-64",
  "procName" : "yabai",
  "procPath" : "\/usr\/local\/opt\/yabai\/bin\/yabai",
  "parentProc" : "launchd",
  "parentPid" : 1,
  "coalitionName" : "homebrew.mxcl.yabai",
  "crashReporterKey" : "D70781EE-C5E8-7FD1-576B-7B4736DFDC69",
  "bridgeVersion" : {"build":"19P6067","train":"6.6"},
  "sip" : "disabled",
  "isCorpse" : 1,
  "exception" : {"codes":"0x0000000000000000, 0x0000000000000000","rawCodes":[0,0],"type":"EXC_CRASH","signal":"SIGABRT"},
  "asi" : {"libsystem_c.dylib":["abort() called"]},
  "extMods" : {"caller":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"system":{"thread_create":4,"thread_set_state":0,"task_for_pid":4},"targeted":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"warnings":0},
  "faultingThread" : 1,
  "threads" : [{"id":251104,"queue":"com.apple.main-thread","frames":[{"imageOffset":6522,"symbol":"mach_msg_trap","symbolLocation":10,"imageIndex":0},{"imageOffset":7400,"symbol":"mach_msg","symbolLocation":56,"imageIndex":0},{"imageOffset":525165,"symbol":"__CFRunLoopServiceMachPort","symbolLocation":319,"imageIndex":1},{"imageOffset":518648,"symbol":"__CFRunLoopRun","symbolLocation":1276,"imageIndex":1},{"imageOffset":515644,"symbol":"CFRunLoopRunSpecific","symbolLocation":562,"imageIndex":1},{"imageOffset":193524,"symbol":"main","symbolLocation":1956,"imageIndex":2},{"imageOffset":21806,"symbol":"start","symbolLocation":462,"imageIndex":3}]},{"triggered":true,"id":251108,"threadState":{"r13":{"value":105553119840160},"rax":{"value":0},"rflags":{"value":582},"cpu":{"value":0},"r14":{"value":6},"rsi":{"value":6},"r8":{"value":140703320662246,"symbolLocation":0,"symbol":"reset_window"},"cr2":{"value":140662627390254},"rdx":{"value":0},"r10":{"value":0},"r9":{"value":293},"r15":{"value":22},"rbx":{"value":123145525317632},"trap":{"value":133},"err":{"value":33554760},"r11":{"value":582},"rip":{"value":140703235481614,"matchesCrashFrame":1},"rbp":{"value":123145525314880},"rsp":{"value":123145525314840},"r12":{"value":22023},"rcx":{"value":123145525314840},"flavor":"x86_THREAD_STATE","rdi":{"value":22023}},"frames":[{"imageOffset":32782,"symbol":"__pthread_kill","symbolLocation":10,"imageIndex":0},{"imageOffset":25087,"symbol":"pthread_kill","symbolLocation":263,"imageIndex":4},{"imageOffset":531748,"symbol":"abort","symbolLocation":123,"imageIndex":5},{"imageOffset":1290810,"symbol":"iterator_seek","symbolLocation":220,"imageIndex":6},{"imageOffset":1292168,"symbol":"SLSWindowIteratorGetTags","symbolLocation":32,"imageIndex":6},{"imageOffset":113502,"symbol":"window_tags","symbolLocation":142,"imageIndex":2},{"imageOffset":110690,"symbol":"window_serialize","symbolLocation":482,"imageIndex":2},{"imageOffset":65016,"symbol":"handle_message","symbolLocation":28712,"imageIndex":2},{"imageOffset":222047,"symbol":"EVENT_HANDLER_DAEMON_MESSAGE","symbolLocation":319,"imageIndex":2},{"imageOffset":22734,"symbol":"event_loop_run","symbolLocation":158,"imageIndex":2},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":4},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":4}]},{"id":251128,"frames":[{"imageOffset":32914,"symbol":"__accept","symbolLocation":10,"imageIndex":0},{"imageOffset":89292,"symbol":"message_loop_run","symbolLocation":60,"imageIndex":2},{"imageOffset":25825,"symbol":"_pthread_start","symbolLocation":125,"imageIndex":4},{"imageOffset":8043,"symbol":"thread_start","symbolLocation":15,"imageIndex":4}]},{"id":264535,"frames":[{"imageOffset":8008,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":4}]},{"id":267604,"frames":[{"imageOffset":8008,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":4}]},{"id":268024,"frames":[{"imageOffset":8008,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":4}]}],
  "usedImages" : [
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>48832,
    "size" : 229376,
    "uuid" : "8cc28466-fd2f-3c80-9834-9525b7beac19",
    "path" : "\/usr\/lib\/system\/libsystem_kernel.dylib",
    "name" : "libsystem_kernel.dylib"
  },
  {
    "source" : "P",
    "arch" : "x86_64h",
    "base" :<PHONE_NUMBER>93600,
    "CFBundleShortVersionString" : "6.9",
    "CFBundleIdentifier" : "com.apple.CoreFoundation",
    "size" : 5255168,
    "uuid" : "93c48919-68af-367e-9a67-db4159bc962c",
    "path" : "\/System\/Library\/Frameworks\/CoreFoundation.framework\/Versions\/A\/CoreFoundation",
    "name" : "CoreFoundation",
    "CFBundleVersion" : "1866"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>,
    "size" : 262144,
    "uuid" : "7d31ddce-5874-3924-86ab-8b0f386f8220",
    "path" : "\/usr\/local\/Cellar\/yabai\/HEAD-c888d80\/bin\/yabai",
    "name" : "yabai"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>,
    "size" : 442368,
    "uuid" : "71febccd-d9dc-3599-9971-2b3407c588a8",
    "path" : "\/usr\/lib\/dyld",
    "name" : "dyld"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>78208,
    "size" : 49152,
    "uuid" : "b5454e27-e8c7-3fdb-b77f-714f1e82e70b",
    "path" : "\/usr\/lib\/system\/libsystem_pthread.dylib",
    "name" : "libsystem_pthread.dylib"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>33024,
    "size" : 561152,
    "uuid" : "e42e9d7a-03b4-340b-b61e-dcd45fd4acc0",
    "path" : "\/usr\/lib\/system\/libsystem_c.dylib",
    "name" : "libsystem_c.dylib"
  },
  {
    "source" : "P",
    "arch" : "x86_64",
    "base" :<PHONE_NUMBER>71776,
    "CFBundleShortVersionString" : "1.600.0",
    "CFBundleIdentifier" : "com.apple.SkyLight",
    "size" : 3796992,
    "uuid" : "6563e632-526d-3c88-8035-049fcca8ca93",
    "path" : "\/System\/Library\/PrivateFrameworks\/SkyLight.framework\/Versions\/A\/SkyLight",
    "name" : "SkyLight"
  }
],
  "sharedCache" : {
  "base" :<PHONE_NUMBER>21888,
  "size" :<PHONE_NUMBER>8,
  "uuid" : "73669942-bd8a-3e40-951f-7fbe07b51cb8"
},
  "vmSummary" : "ReadOnly portion of Libraries: Total=846.6M resident=0K(0%) swapped_out_or_unallocated=846.6M(100%)\nWritable regions: Total=1.3G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=1.3G(100%)\n\n                                VIRTUAL   REGION \nREGION TYPE                        SIZE    COUNT (non-coalesced) \n===========                     =======  ======= \nActivity Tracing                   256K        1 \nCG backing stores                318.2M        8 \nColorSync                          204K       23 \nCoreGraphics                         8K        2 \nKernel Alloc Once                    8K        1 \nMALLOC                           383.4M       57 \nMALLOC guard page                   24K        5 \nMALLOC_MEDIUM (reserved)         240.0M        2         reserved VM address space (unallocated)\nMALLOC_NANO (reserved)           384.0M        1         reserved VM address space (unallocated)\nObjC additional data                15K        1 \nSTACK GUARD                       56.0M        6 \nStack                             10.5M        6 \nVM_ALLOCATE                       4808K       21 \n__CTF                               756        1 \n__DATA                            17.4M      282 \n__DATA_CONST                      12.0M      167 \n__DATA_DIRTY                       534K       97 \n__FONT_DATA                          4K        1 \n__LINKEDIT                       645.4M        8 \n__TEXT                           201.2M      303 \n__UNICODE                          592K        1 \ndyld private memory               1024K        1 \nmapped file                       53.4M       12 \nshared memory                      792K       17 \n===========                     =======  ======= \nTOTAL                              2.3G     1024 \nTOTAL, minus reserved VM space     1.7G     1024 \n",
  "legacyInfo" : {
  "threadTriggered" : {

  }
},
  "trialInfo" : {
  "rollouts" : [
    {
      "rolloutId" : "6112dda2fc54bc3389840642",
      "factorPackIds" : {
        "SIRI_DICTATION_ASSETS" : "620aec83b02b354d3afd2f50"
      },
      "deploymentId" : 240000143
    },
    {
      "rolloutId" : "6112e14f37f5d11121dcd519",
      "factorPackIds" : {
        "SIRI_TEXT_TO_SPEECH" : "634710168e8be655c1316aaa"
      },
      "deploymentId" : 240000229
    }
  ],
  "experiments" : [

  ]
}
}

@koekeishiya Your last commits seem to have solved this problem, cannot reproduce it now. Thanks a ton for your work! <3

c888d80540a580c61e68ee3f6682fb0099962f0e had some crashes, but far less often than before.
4d8e90092a756a1ac7bdeb46545b1fefd3f93978 (or 8153385c08f6d2be465e408fac647f46a130f5c7) fixed that completely.


RemoteDeletePolicy for auto backup is needed

I just found that MysqlBackup have a RemoteDeletePolicy field. But RemoteDeletePolicy of auto backups is retain, which means users have to delete physical backups from remote storage manually.
Can we support  RemoteDeletePolicy in MysqlClusterSpec to support automatic deletion of remote storage?

Hi @bluven, This field was added recently in version 0.3.0-rc.3. More information can be found here.

Great! Thanks!


Check smoketest buffer/memory binding behavior

Issue by tobine (MIGRATED)
Thursday Nov 17, 2016 at 21:49 GMT
Originally opened as https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1172

Smoketest has a buffer that is bound to memory without calling vkGetBufferMemoryRequirements(). The spec implies that this should not be done and there's a pending validation warning to flag this case. Understand smoketest behavior in this regard and update as appropriate.

 Comment by tobine (MIGRATED)
Friday Nov 18, 2016 at 18:36 GMT

@Tony-LunarG in most reasonable cases I would think the returned value for one buffer should apply to all identically created buffers but I don't believe that's required by the driver. There are some guarantees given by the implementation in the spec, but size doesn't appear to ever be guaranteed.
I do think it should be a warning if a user is binding memory to a buffer or image for which the memory requirements have not been explicitly requested for that exact buffer or image.
If a user is comfortable creating a bunch of identical buffers, only retrieving memory requirements for one of them, and then binding them all to memory, they can simply ignore the warning.
I suspect there will be a reasonable number of new Vulkan users who fail to call vkGetBufferMemoryRequirements() at all and make assumptions about memory that will benefit from the warning.

Closing this issue as Vulkan-Tools does not contain smoketest anymore.


Request Timed Out

I've been trying to get localtunnel/server to run on an EC2 AWS instance. The client seem to connect (and get the subdomain) okay but requests to the subdomain are getting timed out. I'm running both the server and nginx via docker as per the repo's readme.md.
CONTAINER ID        IMAGE                                    COMMAND                  CREATED             STATUS              PORTS               NAMES
d84a573a26e1        localtunnel                              "node -r esm ./bin..."      53 minutes ago      Up 8 minutes                            localtunnel-nginx

It's running on a micro EC2 instance (1CPU, 1GB Ram) with Ubuntu Server version 16.04
All incoming TCP ports > 1000 are opened, internal firewall is disabled.
Running curl on the domain?new returns a JSON string, so I guess nginx and nodejs are talking to each other successfully:
$ curl https://xxxxxx?new
{"port":32783,"max_conn_count":10,"id":"yellow-eel-34","url":"https://yellow-eel-34.xxxxxx"}

I've installed the wildcard cert successfully:
$ openssl s_client -showcerts -connect xxxxxxx:443
CONNECTED(00000005)
depth=1 C = US, O = Let's Encrypt, CN = Let's Encrypt Authority X3
verify error:num=20:unable to get local issuer certificate
verify return:0
---
Certificate chain
 0 s:/CN=*.xxxxxxx

Running docker logs on localtunnel doesn't show any errors. But localtunnel-nginx does:
2018/04/06 07:42:20 [error] 5#5: *6 upstream timed out (110: Operation timed out) while reading response header from upstream, client: x.x.x.x, server: , request: "GET / HTTP/2.0", upstream: "http://<IP_ADDRESS>:3000/", host: "tricky-dog-77.xxxxxx"

How do I go around troubleshooting this?

Try the latest version of the server - I have refactored a lot of the logic and it might point to a specific error better.


Command-tilde hotkey with caps lock enabled does not switch between windows

VS Code Version: 1.53.2
OS Version: Darwin x64 19.6.0

Steps to Reproduce:

Launch Code with more than one window open
Turn on Caps Lock
Press command-tilde (MacOS switch application window hotkey)

Expected outcome: switch focus between open windows.
Actual outcome: nothing happens.

Does this issue occur when all extensions are disabled?: Yes

@dfcowell I could not reproduce. Are you using the US keyboard layout or another one?

This is strange, I was able to reproduce consistently when I created this report, but I just tried again now and I can't. Closing until I can reliably reproduce. Sorry for wasting time.