google_sign_in: signInSilently breaks the app when it starts

Hi,
I get an error if I use signInSilently function when app starts.
This is the code of main.dart file:
    void main() async {
      // Create Persistor
      final persistor = Persistor<AppState>(
        storage: FlutterStorage(),
        serializer: JsonSerializer<AppState>(AppState.fromJson),
      );

      // Load initial state
      final initialState = await persistor.load();
      bool logged = false;

      if (initialState.isLoggedIn && initialState.accessToken != null && initialState.loginType != null) {
        initialState.silentlyLogin(); // <---- HERE I GET THE ERROR
        logged = true;
      } else {
        initialState.logout();
      }

      final store = Store<AppState>(
        appReducer, /* Function defined in the reducers file */
        //initialState: initialState ?? AppState.initial(),
        initialState: initialState != null && logged ? initialState : AppState.initial(),
        middleware: [persistor.createMiddleware()],
      );

      runApp(Amalarte(store: store));
    }

    class MyApp extends StatefulWidget {
     ...
    }

This is the silentlyLogin function of my state:
   void silentlyLogin() async {
       switch (loginType) {
         case "google":
           globals.googleSignIn.signInSilently();
           break;
       }
   }

This is globals file:
    GoogleSignIn googleSignIn = GoogleSignIn(
      scopes: [
        'profile',
        'openid',
      ],
    );

I get the error on the line 551 del file message_codecs.dart:
throw PlatformException(code: errorCode, message: errorMessage, details: errorDetails);

I do not why and I do not know howto solve it.

I found the message error:
sign_in_required

I read this is a problem about app not authorized.  But the normal signin works like a charm. The silent login does not work.

Encountering this issue as well (but we've only observed it on iOS). We use firebase auth (with Google as the only enabled provider).
We've been doing this in our development environment-- building the app directly onto the ios device.
These are the steps that repro the issue most consistently:

Install app (debug build, if it matters) & sign in normally
Uninstall the app
Rebuild onto the device
At this point, our app attempts to silently sign in if there's a firebase user where at least one provider is google
Exception throws sign in required

Silent sign in fails whenever the app is updated. We've also found that attempting to login after getting this platform exception via interactive sign in hangs. Reopening the app seems to resolve this.
[VERBOSE-2:ui_dart_state.cc(148)] Unhandled Exception: PlatformException(sign_in_required, com.google.GIDSignIn, The operation couldn’t be completed. (com.google.GIDSignIn error -4.))
#0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:564:7)
#1      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:302:33)
<asynchronous suspension>
#2      GoogleSignIn._callMethod (package:google_sign_in/google_sign_in.dart:226:58)
<asynchronous suspension>
#3      GoogleSignIn._addMethodCall (package:google_sign_in/google_sign_in.dart:268:20)
#4      GoogleSignIn.signInSilently (package:google_sign_in/google_sign_in.dart:311:48)
#5      SignInService.signInWithGoogle (package:{OUR APP}/services/sign_in_service.dart:99:16)
<asynchronous suspension>
#6      new SignInService.<anonymous closure> ({OUR APP}/services/sign_in_service.dart:61:19)
<asynchronous suspension>
#7      _rootRunUnary (dart:async/<…>

Aside: we have tried catching the error by wrapping in try/catch blocks, setting signInSilently({suppressErrors: false}), and using catchError

@GiacomoK Could you try signInSilently(suppressErrors:false) to catch the error?

I can't catch the exception but the IDE (VS Code) stops and spits back

@stocksp What do you mean by 'I can't catch the exception but the IDE (VS Code) stops and spits back'?
Could you share a minimum app to reproduce the issue?

All I meant was that I wrapped the call to .signInSilently in a try catch but I don't catch anything.  It just breaks right in the IDE with the Exception I posted above.  Here is the code
void initState() {
super.initState();
state = AppState.free;
_googleSignIn.onCurrentUserChanged.listen((GoogleSignInAccount account) {
setState(() {
_currentUser = account;
});
print('Change Sign in: $account');
});
try {
_googleSignIn.signInSilently(suppressErrors:false); // here is where we stop
} catch (e) {
print('SigninSilent error $e');
}
print('Done with initState');

}

All I meant was that I wrapped the call to .signInSilently in a try catch but I don't catch anything. It just breaks right in the IDE with the Exception I posted above. Here is the code
void initState() {
    super.initState();
    state = AppState.free;
    _googleSignIn.onCurrentUserChanged.listen((GoogleSignInAccount account) {
      setState(() {
        _currentUser = account;
      });
      print('Change Sign in: $account');
    });
    try {
      _googleSignIn.signInSilently(suppressErrors:false); // <--here is where we stop
    } catch (e) {
      print('SigninSilent error $e');
    }

    print('Done with initState');
  }

I can post up my project tomorrow if it would help. It currently is using Firebase Vision stuff, so I'll have to remove my google plist stuff. I'll be able to revisit this late tomorrow morning and should be able to rebuild a simplified project without the Firebase. I saw this issue with signInSilently before I introduced Firebase...

@stocksp Thank you for providing the code block. Since _googleSignIn.signInSilently(suppressErrors:false) returns a Future, you won't be able to catch the error using a try-catch block directly.
You can do something like      _googleSignIn.signInSilently(suppressErrors: false).catchError((dynamic e){        print('$e');      });
to catch the error.
There are more ways to catch error of a Future, you can find more details here.
https://www.dartlang.org/guides/libraries/futures-error-handling

@cyanglaz thanks a million for your comment (I'm a reactNative dev so I'm still flailing with Dart).  I was  having an issue with the Vision package ... ended up deleting the pod lock file and reinstalling.  signInSilently now works as advertised !!

@GiacomoK Could you try signInSilently(suppressErrors:false) to catch the error?

Tried the same initial code with this line edited:
await globals.googleSignIn.signInSilently(suppressErrors: false);
But I always get this error:
sign_in_required

@GiacomoK The error could be caused by not having a valid signed-in google account on the device. If you can catch the error, then you should be able to handle gracefully for user. (Ask user to sign in regularly again for example)

@GiacomoK Any updates from your end? Was @cyanglaz's idea helpful?

I feel like I'm in the same boat here. Based off a few SO answers, I updated and looked into my debug.keystore multiple times thinking it was something to do with that. What makes me think it isn't a mismatched SHA1 or SHA256 problem though is that I can successfully login if I remove the initial request to signInSilently on my login page. After I auth, if I close the app, add back the signInSilently request, and restart the debugger the call to sign in silently will also work.
What doesn't work is if I haven't signed in at all or am signed out and then hit the signInSilently -- I get a com.google.android.gms.common.api.ApiException: 4 platform error that I cannot catch. I am also awaiting as @cyanglaz suggested:
// inside async func
try {
  GoogleSignInAccount _currentUser = await _googleSignIn.signInSilently(suppressErrors: true);
} catch (e) {
// } on PlatformException catch (e) { // doesn't work either
  print("$e");
}

The only thing I'm doing non-standard since having created the flutter project was follow this advice in changing version numbers when I was having a seperate problem.

@GiacomoK The error could be caused by not having a valid signed-in google account on the device. If you can catch the error, then you should be able to handle it gracefully. (Ask user to sign in regularly again for example)

What you mean with this?

could be caused by not having a valid signed-in google account on the device

@GiacomoK I mean that signInSilently would only work if the user has already signed in. As the document in the Google Sign-In api states: Attempts to sign in a previously authenticated user without interaction.. You can find more details here: https://developers.google.com/identity/sign-in/ios/api/interface_g_i_d_sign_in

@Nolence Is it happening on iOS or Android? Could you paste your flutter doctor -v here?

Woah, thanks @cyanglaz! Yup, the IDE was catching the uncaught exception and that was the issue.

I had Uncaught Exceptions checked. If you're still interested, here's the flutter doctor -v output:
[√] Flutter (Channel beta, v1.3.8, on Microsoft Windows [Version 10.0.17763.437], locale en-US)
    • Flutter version 1.3.8 at C:\src\flutter
    • Framework revision e5b1ed7a7f (6 weeks ago), 2019-03-06 14:23:37 -0800
    • Engine revision f4951df193
    • Dart version 2.2.1 (build 2.2.1-dev.0.0 571ea80e11)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\rexma\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[!] Android Studio (version 3.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[√] VS Code (version 1.33.1)
    • VS Code at C:\Users\rexma\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 2.25.1

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

! Doctor found issues in 1 category.

I haven't tested it with an Apple device yet, but I'll update this when I do (I'm assuming it'll work though).

@GiacomoK I mean that signInSilently would only work if the user has already signed in. As the document in the Google Sign-In api states: Attempts to sign in a previously authenticated user without interaction.. You can find more details here: https://developers.google.com/identity/sign-in/ios/api/interface_g_i_d_sign_in

@cyanglaz  It seems that was my problem.
I tried this (my app is on Android):

open the app and signin NOT silently (I chose my google account)
close the app
reopen the app and signin silently. Everything worked like a charm.

Thanks.

It seems like the issue has been resolved! I am closing the issue now. If any related issue has been found please feel free to open another one with details.

**I get an error on this code line

**
googleSignIn.signInSilently (suppressErrors: false) .then ((account) {
handleSignIn (account);
}). catchError ((err) {
print ('Oturum açma hatası: $ err');
});
}
HELPME PLEASE `import 'package:cloud_firestore/cloud_firestore.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:selfca/models/user.dart';
import 'package:selfca/pages/activity_feed.dart';
import 'package:selfca/pages/create_account.dart';
import 'package:selfca/pages/profile.dart';
import 'package:selfca/pages/search.dart';
import 'package:selfca/pages/timeline.dart';
import 'package:selfca/pages/upload.dart';
import 'package:google_sign_in/google_sign_in.dart';
final GoogleSignIn googleSignIn = GoogleSignIn();
final usersRef = Firestore.instance.collection('users');
final DateTime timestamp = DateTime.now();
User currentUser;
class Home extends StatefulWidget {
@override
_HomeState createState() => _HomeState();
}
class _HomeState extends State {
bool isAuth = false;
PageController pageController;
int pageIndex = 0;
@override
void initState() {
super.initState();
pageController = PageController();
// Detects when user signed in
googleSignIn.onCurrentUserChanged.listen((account) {
handleSignIn(account);
}, onError: (err) {
print('Error signing in: $err');
});
// Reauthenticate user when app is opened
googleSignIn.signInSilently(suppressErrors: false).then((account) {
handleSignIn(account);
}).catchError((err) {
print('Error signing in: $err');
});
}
handleSignIn(GoogleSignInAccount account) {
if (account != null) {
createUserInFirestore();
setState(() {
isAuth = true;
});
} else {
setState(() {
isAuth = false;
});
}
}
createUserInFirestore() async {
// 1) check if user exists in users collection in database (according to their id)
final GoogleSignInAccount user = googleSignIn.currentUser;
DocumentSnapshot doc = await usersRef.document(user.id).get();
if (!doc.exists) {
  // 2) if the user doesn't exist, then we want to take them to the create account page
  final username = await Navigator.push(
      context, MaterialPageRoute(builder: (context) => CreateAccount()));

  // 3) get username from create account, use it to make new user document in users collection
  usersRef.document(user.id).setData({
    "id": user.id,
    "username": username,
    "photoUrl": user.photoUrl,
    "email": user.email,
    "displayName": user.displayName,
    "bio": "",
    "timestamp": timestamp
  });

  doc = await usersRef.document(user.id).get();
}

currentUser = User.fromDocument(doc);

}
@override
void dispose() {
pageController.dispose();
super.dispose();
}
login() {
googleSignIn.signIn();
}
logout() {
googleSignIn.signOut();
}
onPageChanged(int pageIndex) {
setState(() {
this.pageIndex = pageIndex;
});
}
onTap(int pageIndex) {
pageController.animateToPage(
pageIndex,
duration: Duration(milliseconds: 300),
curve: Curves.easeInOut,
);
}
Scaffold buildAuthScreen() {
return Scaffold(
body: PageView(
children: [
// Timeline(),
RaisedButton(
child: Text('Logout'),
onPressed: logout,
),
ActivityFeed(),
Upload(),
Search(),
Profile(),
],
controller: pageController,
onPageChanged: onPageChanged,
physics: NeverScrollableScrollPhysics(),
),
bottomNavigationBar: CupertinoTabBar(
currentIndex: pageIndex,
onTap: onTap,
activeColor: Theme.of(context).primaryColor,
items: [
BottomNavigationBarItem(icon: Icon(Icons.whatshot)),
BottomNavigationBarItem(icon: Icon(Icons.notifications_active)),
BottomNavigationBarItem(
icon: Icon(
Icons.photo_camera,
size: 35.0,
),
),
BottomNavigationBarItem(icon: Icon(Icons.search)),
BottomNavigationBarItem(icon: Icon(Icons.account_circle)),
]),
);
// return RaisedButton(
//   child: Text('Logout'),
//   onPressed: logout,
// );
}
Scaffold buildUnAuthScreen() {
return Scaffold(
body: Container(
decoration: BoxDecoration(
gradient: LinearGradient(
begin: Alignment.topRight,
end: Alignment.bottomLeft,
colors: [
Theme.of(context).accentColor,
Theme.of(context).primaryColor,
],
),
),
alignment: Alignment.center,
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
crossAxisAlignment: CrossAxisAlignment.center,
children: [
Text(
'FlutterShare',
style: TextStyle(
fontFamily: "Signatra",
fontSize: 90.0,
color: Colors.white,
),
),
GestureDetector(
onTap: login,
child: Container(
width: 260.0,
height: 60.0,
decoration: BoxDecoration(
image: DecorationImage(
image: AssetImage(
'assets/images/google_signin_button.png',
),
fit: BoxFit.cover,
),
),
),
)
],
),
),
);
}
@override
Widget build(BuildContext context) {
return isAuth ? buildAuthScreen() : buildUnAuthScreen();
}
}
`


checkpoints (and logs) fine-tuned on English train set

Please provide checkpoints for the MSCOCO and MULTI30 dataset

Hi,
Sorry for my late rely.
Recently, I got an even higher results than those reported in the paper. I will release this ckpt later.

Is it possible to release these chackpoints?


"Feature" availability check error"

What are you trying to achieve?
If you run a test without specifying "Feature", the test runs or sended error message.
What do you get instead?
In fact, it is different. The test pulls up "Before" from another file and runs the test.
Details

CodeceptJS version: 2.3.1
NodeJS Version: v11.10.0
TypeScript Version: v8.4.1
Operating System: macOS
Protractor || WebDriverIO || Nightmare version (if related)
Configuration file:

# paste suite config here

Sorry, why you would ever do this?


Normalize the package name for Doc.Ms readme

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=713510&view=logs&j=df6dbc9d-9cb6-55ac-00c8-bc457d14297a&t=44cfd120-b037-5184-ffdd-7a7fc47afe90
The readme we get from the workflow: sdk-template-readme.md which is the same as before.

/check-enforcer override


[Task Description Rework] Task Creation UI

Tracking progress of the create-UI part of #122

[x] Task Type

[x] Task Group

[ ] Task

[x] Component Type: Text
[x] Component Type: Image (Media Item)
[x] Component Type: Video (Media Item)
[ ] Component Type: Image (External)
[ ] Component Type: Video (External)
[x] Target Type: Single Media Item (whole)
[x] Target Type: Single Media Segment (with Range)
[ ] Target Type: Multiple Media Items
[x] Target Type: Judgment

Target Type Single Media Item can currently be created but causes errors when the competition is to be saved.

Target Type Single Media Item can currently be created but causes errors when the competition is to be saved.

I cannot confirm this behaviour. Is this still an issue?

no, this should be fixed.

Then we can close #145


Add Dockerfile and its usage tutorial

@rohithpv Please help me to review this PR :pray:

@bsmock Could you please help to review this PR :smile:


Profile no longer shows badges

https://techprofile.microsoft.com/en-us/dteron is an example. It appears they've hit a limit of some kind where the UI no longer is capable of rendering all of the badges/trophies. I've checked in multiple browsers with same results.

Duplicate of issue already reported by another user.


passed division to the math.div function

Hi, @MosDeef !
Thanks for your PR, and I wonder how you came to know this repo(especially Issue #9),
since it is just a simple webpage for datamining lab of Kookmin Univ., Korea.

Hi, @MosDeef ! Thanks for your PR, and I wonder how you came to know this repo(especially Issue #9), since it is just a simple webpage for datamining lab of Kookmin Univ., Korea.

Hiya - I just came across it browsing the good-first-issue tags and looked like something I could handle

Highly appreciate for your contribute @MosDeef !
But if you don't mind, can I assign this task for our lab members, to practice on git/github?

Highly appreciate for your contribute @MosDeef ! But if you don't mind, can I assign this task for our lab members, to practice on git/github?

Not at all 😊

Thanks ! 😄


ModuleNotFoundError: No module named 'paho'

I run pne-chat after pip install promptulate. It shows the following error:
Traceback (most recent call last):
  File "/home/zeeland/.local/bin/pne-chat", line 5, in <module>
    from promptulate.client.chat import main
  File "/home/zeeland/.local/lib/python3.10/site-packages/promptulate/client/chat.py", line 28, in <module>
    from promptulate.agents import ToolAgent
  File "/home/zeeland/.local/lib/python3.10/site-packages/promptulate/agents/__init__.py", line 2, in <module>
    from promptulate.agents.tool_agent.agent import ToolAgent
  File "/home/zeeland/.local/lib/python3.10/site-packages/promptulate/agents/tool_agent/__init__.py", line 1, in <module>
    from promptulate.agents.tool_agent.agent import ToolAgent
  File "/home/zeeland/.local/lib/python3.10/site-packages/promptulate/agents/tool_agent/agent.py", line 11, in <module>
    from promptulate.tools import BaseTool, Tool
  File "/home/zeeland/.local/lib/python3.10/site-packages/promptulate/tools/__init__.py", line 10, in <module>
    from promptulate.tools.iot_swith_mqtt import IotSwitchTool
  File "/home/zeeland/.local/lib/python3.10/site-packages/promptulate/tools/iot_swith_mqtt/__init__.py", line 1, in <module>
    from promptulate.tools.iot_swith_mqtt.tools import IotSwitchTool
  File "/home/zeeland/.local/lib/python3.10/site-packages/promptulate/tools/iot_swith_mqtt/tools.py", line 4, in <module>
    import paho.mqtt.client as mqtt
ModuleNotFoundError: No module named 'paho'

import paho is not a good way for developer. I think we should not import paho when initialization.
I think we can import paho when run the tool.
class IotSwitchTool(Tool):

    def _run(self, question: str, *args, **kwargs) -> str:
        import paho.mqtt.client as mqtt
        ...

There is another error.

@ruanrongman

API wrapper get the same problem. We should import package when run it.

ok


Project data

Closed bc/ I did the merge manually as there were some local conflicting changes. Lgtm!


Scrolling while dragging creates an offset with dragged div and cursor

Hello @clauderic ,
Again, thanks for this library!
Here's an issue I haven't been able to solve. I am using Next.
When I grab an item and I drag it close the the limit of the screen, the screen scrolls (as it should) but the div get offset from the cursor while doing so... I'm not sure why, but I was able to recreate the issue in this sandbox: https://5lscly.sse.codesandbox.io/dashboard/library
You can edit the sandbox via this link: https://codesandbox.io/s/gallant-wozniak-5lscly?file=/src/components/FolderSubTile.js
Make sure you navigate to "/dashboard/library" to access the grid.
I'd like to eliminate that offset and make the cursor stay on the same point while dragging the div AND scrolling. The issue only happens when you scroll while dragging the div...
Also, here's a clip of the issue:
https://user-images.githubusercontent.com/88408622/171493632-63164e6f-1164-44c7-834d-88ef7d34f19e.mp4
Does anyone know a solution to this?
Thanks! :)

Hey @camachomarco, this issue only happens if you don't use the <DragOverlay> component. Also, this issue was fixed in the latest version of @dnd-kit. Make sure you upgrade to the latest version of @dnd-kit/core (and also upgrade all the @dnd-kit other packages since @dnd-kit/core is a dependency/peer dependency)


LMS1xx setting scan configuration error

For LMS1xx using ROS1 I get:
[1669718842.752241476] [ INFO] [/sick_lms_1xx:SickScanCommon::init_scanner] Sending mLMPsetscancfg request: { scan_frequency=5000, active_sector_cnt=1, angular_resolution[0]=5000, start_angle[0]=-450000, stop_angle[0]=2250000 } [1669718842.752257883] [ INFO] [/sick_lms_1xx:SickScanCommon::sendSopasAndCheckAnswer] Sending  : <STX>sMN mLMPsetscancfg \x00\x00\x13\x88\x00\x01\x00\x00\x13\x88\xff\xf9\x22\x30\x00\x22\x55\x10<ETX> [1669718842.753645922] [ INFO] [/sick_lms_1xx:SickScanCommon::sendSopasAndCheckAnswer] Receiving: <STX>sFA 11<ETX>
So an error code sFA 11, some unrecognized command. I suppose this could be due to current firmware version, but at least the developers guide does not mention any firmware versions this command would be limited to.
To reproduce
Basically used your official guide for ROS1 with
catkin_make_isolated --install --cmake-args -DROS_VERSION=1 -DLDMRS=0 -DSCANSEGMENT_XD=0 -Wno-dev
Then launched using
roslaunch sick_scan sick_lms_1xx.launch
with setting in the launch file changed to
use_binary_protocol=false
and otherwise just ip and port changed for the lidar. The lidar has the firmware sRA FirmwareVersion 9 V1.80.1. The lidar works, I can interface it using e.g. this driver

Thanks for your feedback. A firmware version >= 2.0 is required for setting the scan configuration (details can be found in https://github.com/SICKAG/sick_scan_xd/issues/122). Please update the lidar firmware and retry. I am closing the ticket for now. Please feel free to reopen the issue in case of further problems.


Branch sync - Merge master with dev 1.19

Sync master with dev-1.19
cc: @zacharysarah @jimangel @kbarnard10

/lgtm
All red X's appear to be failed builds, but this PR has build successfully. Would like another set of eyes before merging. Thanks!

/approve


[feature]do we need reposition function?

Definitely. Required for the zoom functionality to be useful. I'd use a UI component similar to the existing one for the re-positioning. (see pic) There's a similar extension that already supports repositioning. (https://chrome.google.com/webstore/detail/youtube-zoom/bbafphllnkfgkcbilhekaooohoiabojh)

Thank you for your feedback. As you say, repositioning is necessary when you are using zooming. Now we are working on this function and it will be released in the next version😉

Definitely. Required for the zoom functionality to be useful. I'd use a UI component similar to the existing one for the re-positioning. (see pic) There's a similar extension that already supports repositioning. (https://chrome.google.com/webstore/detail/youtube-zoom/bbafphllnkfgkcbilhekaooohoiabojh)

Thank you for your feedback. As you say, repositioning is necessary when you are using zooming. Now we are working on this function and it will be released in the next version.

Added in the v1.1.1


Improve help window

Changed URL to point to our user guide
Added a screenshot to show the command summary. A screenshot is used instead of hardcoding every single command for better maintainability.

Codecov Report

Merging #85 (76c4ca0) into master (0792f14) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
- Coverage     55.03%   54.97%   -0.07%
  Complexity      408      408
============================================
  Files            88       88
  Lines          1708     1710       +2
  Branches        194      194
============================================
  Hits            940      940
- Misses          716      718       +2
  Partials         52       52

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LGTM, just that help_summary.png will need to be updated after the UG is updated.

Yup it is intended so that we only need to change that 1 picture instead of hardcoding the entire list of commands again

LGTM 👍


Any chance of some more detailed instructions?

If you have time it would be useful to know.
What needs to be installed on the Python side?
How do I use it in my code?

Thanks for you interest. I'll see if I can find time for proper docs - we were just waiting for someone external to want to use it I guess.
We use this package for a Node.js web service, based on it's Dockerfile I think all dependencies are installed with
pip install bagit

and we're only using it with Python 2 so far.
In that project you can also see how to use the validation API in this file:
const Bag = require('bagit');
const debug = require('debug')('bagit');
let fastValidation = true;

let bag = new Bag('/path/to/bag');
        bag.validate(fastValidation)
            .then(res => {
                debug('bag is valid: %s', res);
            }).catch(err => {
                debug('bag is _IN_valid: %s',err);
                }
});


Feature Request: Option to automatically compress SQLite DB using sqlite-zstd

There was recently a thread on HN that popped up about a new SQLite extension that lets you claw back some storage space without affecting performance: https://github.com/phiresky/sqlite-zstd
Would be neat to have this on by default. The benchmark shows some pretty sizable disk saving. Announcement post here as well.

This looks interesting but it is very experimental at the moment and I'm not sure how portable the sqlite extension is and whether it would be easy to transpile and integrate into the CGO-free sqlite (modernc.org/sqlite) that PocketBase is using by default.
For now this will remain out of the roadmap, but I'll keep an eye on the project.

Old issues cleanup: I'm closing this as I don't plan working on it. With the upcoming PocketBase v0.23 release users will have the option to specify custom connectDB function as part of the app config allowing custom SQLite builds if they needed (as long as they satisfy the std database/sql abstraction).


Fix build with Qt 5.14

In file included from Renderer.h:10,
from PropDialog.h:9,
from PropDialog.cpp:8:
Annotation.h:38:11: error: ‘QImage’ does not name a type

LGTM.  Thanks for sending that in! If you find any other needed includes for 5.14, let us know.

I'm going to let Ken merge this in, it's his project so I'll let him have the pleasure of merging.


Release 1.6.3

@spotbugs/everyone Please review this PR to support Gradle 4.10. Thanks a lot!

@KengoTODA  You should probably update the gradle versions in .travis.yml as well

oracle-java8-set-default_8u151-1~webupd8~0_all.deb is missing from http://ppa.launchpad.net/webupd8team/java/ubuntu/pool/main/o/oracle-java8-installer/ , but u181 is there.  Maybe we need an apk update / upgrade in before_script in .travis.yml as well?

@henrik242 I've force pushed the changes that enable apt-get update before the build, let's wait the build result...

You should probably update the gradle versions in .travis.yml as well

After we switch to Gradle 4.10, change env.matrix as follows:
    - GRADLE_VERSION=default
    - GRADLE_VERSION=4.11-20180823092818+0000
    - GRADLE_VERSION=5.0-20180906235859+0000

@KengoTODA Looks good! By the way, I'm not authorized to merge in this repo (only in the main repo), could you add me?

Thanks @henrik242, I've invited you to this repo so please check it!

Hi @KengoTODA
Regarding:

After we switch to Gradle 4.10, change env.matrix as follows:

You can skip 4.11 because that are older nightly builds which later became 5.0. 5.0 is going through pretty big changes so you will need to keep 5.0 version up to data to have guarantees that everything is still working. We will be working on migration for our plugins so we will be discovering possible issues in following weeks.

@chali thank you, I've stopped using 4.11 in #50.


Add sensors

Description:
Add the following sensors that provide interesting data when using a variable speed geothermal system:

Compressor Power
Fan Power
Aux Power
Loop Pump Power
Compressor Speed
Fan Speed

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io TBD
Checklist:

[ x] The code change is tested and works locally.
[ x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x ] Documentation added/updated in home-assistant.io

@sdague I looked around your component and tried adding some sensors to it. So far it works on my system. I am no python expert or programmer so let me know if you think I may be breaking something.

Thanks @mdallaire !


Question: Is it safe to host publicly behind a reverse proxy?

If I host the app behind a reverse proxy (Nginx/Apache) is it safe to be hosted on a publicly available server if I attach an SSL certificate to the webserver?

Yes, but of course it's always a good idea to take precautions where you can.
If you run the binary, I'd recommend running as a user that doesn't have access to any important files outside the scope of the application.
You can also disable password login to the web UI. Or just put an auth gateway like Authelia in front of the whole app without breaking functionality.
Even in the worst case scenario, if someone gains access to the hub and / or your private key, they can't use that to run commands on your remote systems.
Let me know if you have questions about anything specific.


[DOC] Implement a tool to bulk import user accounts to IS

Describe the improvement
Doc issue for Implement a tool to bulk import user accounts to Asgardeo feature.

Documentation for the bulk user import feature is available at the following link: onboard-multiple-users.


Permission Question

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
So I get that you create roles and add members to group, then add that role to the shelves, but then the permissions don't cascade down to the books and chapters and pages unless you do the " copy permission" is there a way to have whatever permission shelve has apply to everything under it to NEW and existing items automatically ? some sort of script or is there an option ?
Exact BookStack Version
v23.06.2
Log Content
No response
PHP Version
No response
Hosting Environment
Docker Compose
Nginx Proxy Manager
Bookstack
SAML2 for SSO

There's no in-platform automatic way. Open request in #1596.
There is a "Copy Shelf Permission" command which can do this externally from command line (including being scheduled if desired). This can run on all shelves in the system. Just be aware that books on multiple shelves will only get the permissions from one of the shelves (Whichever runs through the process later).
Alternatively, if you have some PHP skills, you could listen to book creation events via the logical theme system then trigger this process upon such events.

okay thanks for the info. however if one edits and makes some changes to  php files and afterward theres an update to bookstack does that update erase the past changes ?

If you're making changes to core app files, then yes, that may conflict with git during update (on a normal install) or be wiped (if in a docker container).
The logical theme system allows customizations outside of core app files, so they run as an extension to the platform.
This may still conflict with updates (if your logic is depending on internal code that's changed) but the changes should persist and they can be toggled off via "toggling off" (removing the option) the theme. They wouldn't stop the updates or be lost in the say way as changing core app files.

okay this makes sense, thanks

Hello, thanks for the hint. I managed to achieve the result with the following code in the theme's functions.php.
Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function (string $activityType, $detail) {

    $validTypes = [ActivityType::BOOK_CREATE];
    if (!in_array($activityType, $validTypes)) {
        return;
    }

    if ($detail instanceof Book) {
        $contextBookshelfId = session()->get('context_bookshelf_id', null);
        $shelf = Bookshelf::visible()->find($contextBookshelfId);
        if ($shelf) {
            $shelfPermissions = $shelf->permissions()->get(['role_id', 'view', 'create', 'update', 'delete'])->toArray();
            $detail->permissions()->delete();
            $detail->permissions()->createMany($shelfPermissions);
            $detail->rebuildPermissions();
        }
    }
});


Sub task with code block or blankquotes can't render.

The sub task with code block or blankquotes can't render.
See following image.
sub task is bebind by 4 blocks.

- [ ] asdqwd
    - [ ] qqq
    > blankquote1
    - [ ] www
    ```
    code bland 1
    ```
    - [ ] eee

> blankquote2

    - [ ] eee

- [ ] 111
```js
code bland 2
```
- [ ] 222

1. 111
2. 222
    1. 231
    > qwe
    ```js
    qwd
    ```
    2. 222
    3. 2d1

Context (Environment)

Obsidian version: 0.15.6
Tasks version: 1.8.2
[x] I have tried it with all other plugins disabled and the error still occurs

Hi, thank you for the report and for including your text. Much appreciated.
Looking at the documentation of Getting Started docs for Tasks, it says:

Tasks only supports single-line checklist items.

So as far as I understand it, this is not a bug, but the currently-intended behaviour of the plugin.


Can't have single line let-else and control braces on next line

let-else always expands to multiple lines if control_brace_style = "AlwaysNextLine". I don't know if this is a bug or simply not supported.

When you get a chance could you please share some minimal code snippets, specifically what you were anticipating and what you're actually seeing?
The former in particular isn't clear to me, but I will say that a let-else statement will only be formatted on a single line provided it's possible to put the entire statement on one line. If that's not the case (either due to a non-default config option or due to one or more of the requirements articulated in the style guide not being met) then the multi-line formatting would apply.

Sure, this happened when I typed the line
let Some(position) = q_windows.single().cursor_position() else { return };

I use the next config (relevant lines only)
control_brace_style = "AlwaysNextLine"
single_line_let_else_max_width = 200

So the line gets expanded to this
let Some(position) = q_windows.single().cursor_position()
else
{
	return;
};

Though the let else statement fits in one line, it is being formatted to multiple lines. This is not necessarily wrong, given that I'm using control_brace_style = "AlwaysNextLine", but I'm not sure if not respecting single_line_let_else_max_width is intended the behavior. Also I'm wondering if having something like control_brace_style = "NextLineWhen" so only it's not expanded when single_line_let_else_max_width it's not exceeded would be something that should be added.
Note that having control_brace_style = "AlwaysSameLine" does  keeps the statement in one line unless the limit it's exceeded, similar to what I want.

It actually looks like control_brace_type = "ClosingNextLine" actually prevents any single-line if-else or let-else block.
For example:
let foo = if true { 0 } else { 1 };

This gets formatted to...
let foo = if true {
    0
}
else {
    1
};

I always wondered why rustfmt didn't allow me to have a single-line if/else (or let/else), but this option is what does it.


Feature/local driver

Runs revolver against a local JSON dump (from saveResources) of resources to test behaviour.
Utilizes the real drivers so ensure all the configured drivers are in pretend mode.
Example config. Doesn't require any AWS permissions.
---
defaults:
  settings:
    region: ap-southeast-2
    timezone: Australia/Melbourne
    timezoneTag: Timezone
    organizationRoleName: none
    revolverRoleName: none
    localResourcesFile: resources.json

  drivers:
    - name: ec2
      active: true
      pretend: true
    - name: snapshot
      active: true
      pretend: true
    - name: rdsInstance
      active: true
      pretend: true

  plugins:
    powercycle:
      active: true
      configs:
        - tagging: strict
          availabilityTag: Schedule

accounts:
  includeList:
    - accountId: "123456789012"
      settings:
        name: local-aws
  excludeList: []

organizations: []

Example config needs (empty) organizations tag to be valid:
organizations: []

Why is this processing "unsupported" (by normal drivers) resource-types?  I'm seeing it attempt to read schedule tags on lots of resourceType:snapshot for example

Why is this processing "unsupported" (by normal drivers) resource-types? I'm seeing it attempt to read schedule tags on lots of resourceType:snapshot for example

Updated logic to instead utilize the original drivers, make sure pretend mode is on.


Some CMake fixes

Add a previous step for pypi_package_sdit target, so the
qiskit_simulator binary is removed before creating sdist
distributable package.
Simplified CMake dependencies
Fixed MacOS builds for semi-static compilation
Fixed Linux platform-tag for wheels distributable

How Has This Been Tested?
These changes are related to the build system, so I have test the locally following these steps:

Creating an out directory and moving into it.
Linux: $ cmake ..
Mac: $ cmake .. -DCMAKE_CXX_COMPILER=g++-7 ..
make pypi_package
Check that distributable packages meet these conditions:

qiskit-0.4.9.tar.gz doesn't include the simulator binary (qiskit/backends/qiskit_simulator)
qiskit-0.4.9....whl has the correct platform tag on Linux and Mac
qiskit_simulator included in Mac wheel, is statically linked with gcc/stdc++ libraries.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

Ups! Closing it... I will PR against  stable.


fix(test): rm .dat dir after testing

Plus, remove two small dependencies.
fix: https://ci.appveyor.com/project/depjs/dep/branch/master/job/g1w55m85dr3159ic

🐑


kdevelop-pg-qt: 2.2.1 -> 2.2.2

Description of changes
Fix build with Qt 5.15.8
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build libsForQt5.kdevelop-pg-qt

Result of nixpkgs-review pr 213414 run on x86_64-linux 1

5 packages built:

libsForQt5.kdev-php (plasma5Packages.kdev-php)
libsForQt5.kdev-python (plasma5Packages.kdev-python)
libsForQt5.kdevelop (plasma5Packages.kdevelop)
libsForQt5.kdevelop-pg-qt (plasma5Packages.kdevelop-pg-qt)
libsForQt5.kdevelop-unwrapped (plasma5Packages.kdevelop-unwrapped)


[WIP] Update Query Experiments

This is just an experiment to show another method of https://github.com/firebase/FirebaseUI-Android/pull/1660

@samtstern It looks great now than our previous version. Thank You!

Sure let's go with 'updateOptions', thanks!
On Thu, Jul 25, 2019, 5:29 PM Shreyas Patil<EMAIL_ADDRESS>wrote:

@PatilShreyas commented on this pull request.
In
database/src/main/java/com/firebase/ui/database/FirebaseRecyclerAdapter.java
https://github.com/PatilShreyas/FirebaseUI-Android/pull/2#discussion_r307549823
:

  */

public void updateQuery(@NonNull Query newQuery) {

   mSnapshots.updateQuery(newQuery);

public void setOptions(@NonNull FirebaseRecyclerOptions options) {

Can we name it something different? Like 'changeOptions()',
'updateOptions()' or any so it will be easy to recognize this operation as
it is setting new options in the adapter.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PatilShreyas/FirebaseUI-Android/pull/2?email_source=notifications&email_token=ACATB2TQ4AQUEF7KBMC6YYTQBJAPHA5CNFSM4IG5PZJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7UUFDY#pullrequestreview-266945167,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACATB2UPYCPPUTRX6YLEZ6TQBJAPHANCNFSM4IG5PZJA
.


PR提了都一个月了，不继续审核了？

Please wait for @lijiarui to review. She's quite busy those weeks so we can not have enough resources to deal with the blog posts from our community.
Thank you very much for your patient.

We have too many PRs in our queue due to our busy schedule, so I review & merge most of them today.
The PRs which has been merged are listed below:

https://github.com/wechaty/wechaty.js.org/pull/379, blog URL: https://wechaty.js.org/2020/07/23/kuakua-wechaty
https://github.com/wechaty/wechaty.js.org/pull/488, blog URL: https://wechaty.js.org/2020/08/22/market-wechat-robot
https://github.com/wechaty/wechaty.js.org/pull/525, blog URL: <https://wechaty.js.org/2020/09/14/ads-filer-groupbot?
https://github.com/wechaty/wechaty.js.org/pull/554, blog URL: https://wechaty.js.org/2020/09/30/wechat-file-schedule-box-clafixed
https://github.com/wechaty/wechaty.js.org/pull/569, blog URL: https://wechaty.js.org/2020/10/15/wechaty-wangke-bot
https://github.com/wechaty/wechaty.js.org/pull/572, blog URL: https://wechaty.js.org/2020/10/22/wechat-fanli-robot
https://github.com/wechaty/wechaty.js.org/pull/576, blog URL: https://wechaty.js.org/2020/10/22/wetchat-bot-chat
https://github.com/wechaty/wechaty.js.org/pull/580, blog URL: https://wechaty.js.org/2020/10/30/daily-message-and-chatbot

@lijiarui Please review if you need any additional followups, and feel free to close this issue after everything is OK.

Closed this issue because all qualified PRs have been merged, cheers!


Improve submodule checking

Problem was when using git-rev-sync inside virtual machine. Then parentRepoPath would be host machine's path. This is  wrong because path is sometimes absolute. Now it checks upper folder which is parent repo and it's module folder if it has this child repo as submodule

@kurttheviking Busy with the kid? :D

@bigp  I have shipped an updated version (git-rev-sync@1.9.0). Feel free to upgrade and let me know if you encounter any issues. Thanks!

I'm from the same team as @henrikra, we just upgraded the git-rev-sync to 1.9.0 and it seems to be working nicely. Thanks!

@Arkkimaagi great thanks!


Feature/safe call

Further to the topic #1280, I has finished the implementation of the @SafeCall feature.
Except the protection from 'NullPointerException' also 'ArrayIndexOutOfBoundsException' and 'NegativeArraySizeException' have been added.
Please take a look at the test 'SafeCallArray.java'. It describes these protections.
@rzwitserloot suggests a good idea about a default value that should be assigned instead of null.
That feature is implemented using the conditional operator (?:) and can be expressed like:
@SafeCall int intVar = getNullInteger() ? intVar : -1;
See tests 'SafeCallDefaultValue.java' and 'SafeCallIllegalUsingDefaultValue.java'.
About the magic method-wrapper "onNull", this is an interesting idea, but I didn't analyse and didn't try to implement that feature so cannot say how hard it is. It needs time.

Hi, this is a very interesting feature, I'm wondering why this PR is not merged.
It's open since 2017.


Remove sample metrics webapp

Closes #225

Current coverage is 1.91% (diff: 100%)

Merging #226 into master will increase coverage by 0.02%

@@            master      #226   diff @@
========================================
  Files           30        30
  Lines          422       417     -5
  Methods        381       378     -3
  Messages         0         0
  Branches        20        18     -2
========================================
  Hits             8         8
+ Misses         414       409     -5
  Partials         0         0

Powered by Codecov. Last update f344da1...f91c7e0

Looks good.


Detect IN_PASSPORT

DESCRIPTION
An IN_PASSPORT (Indian Passport Number) is a unique number assigned by the Government of India to passport holders. It certifies the identity and citizenship of the passport holder for international travel. It is important to detect IN_PASSPORT to prevent potential identity theft and fraud, and to ensure the passport holder's sensitive information remains secure and protected.
DETECTION STEPS
An IN_PASSPORT consists of eight characters:

The first character must be an uppercase letter (A-Z)
The remaining seven characters are a combination of integers (0-9)

Example: E7654321

Hey @lailacodes, Question, should the detection process reject passport numbers that contain any alphanumeric character or lower case letter ?

@Dyamondgrate Lowercase letters are not used in the IN_PASSPORT, so it should reject them. The IN_PASSPORT number should also adhere to the format of the first character being an uppercase letter and the following characters being integers from 0-9. Also, I'm going to update the detection steps for more clarity because none of the characters should be symbols either.

Looks good

Is there a specific regular expression we should use to detect the IN_PASSPORT format accurately?

Seems very interesting how an individuals personal information is protected


Remove enum.cr TODO due to 0.22 released

It is no longer needed. In fact, make std_spec is green without this TODO.

Hmm, crystal on CI is not latest version...?

It seems the docker images are outdated :-(.
@jhass would you trigger a rebuild for 0.22.0?

@MakeNowJust we are on hold due to some CI issues, once that is solved we will merge this.

Travis passed now :)

Thanks @MakeNowJust and @jhass


Removed configuration support

Why not preserve configuration support and support new config entry flow too? Removing this functionality is cumbersome to some users... Power users

@moralmunky I'm feeling this would be a step backwards from the progress we've made so far, what's your opinion on this?

moralmunky's comments posted to #53:

Short answer, we don't need it.
Long answer for anyone that wants to understand why.
As someone who has resisted moving away from yaml configuration and heavily organized my configuration into drop in packages, I understand the want to keep this.
The HASS team appears to be moving away from external yaml and creating methods to store settings to without yaml. Most of the components that have become official integrations loose their yaml settings. There are also recommended way to migrate a system so you don't have to set up each individual integration by hand. This integration is not complicated and does not have extensive set up options. I also thing the ability you added to reconfigure the Integration is also a case against reinstating yaml configuration.


feat: matomo events

:tada: This PR is included in version 0.21.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Network console no activity

I couldn't see any network calls (request) under the Chrome development tools. Is it just me or it is everyone?

@ryderlee It depends on how you're making the requests. If you use the fetch api inside of the renderer. This will use the browsers's fetch method. If you use node's http module or any node related request, the request will not show up in the network panel.

Closing because this is not an issue with this project, but please feel free to ask more questions 😊

http://pastebin.com/HtmAaJq0 <--- I made a pastebin here. The joke is I can see the console.log output but not the Ajax call info under the network tab :(

Does fetch work for you?

Hurray! Surprise me, fetch works, at least in the Devtools console, I am switching to "fetch" now! Can I ask why?

If you use the fetch api inside of the renderer.

Whoops. Didn't seem to have finished my sentence 😂 fetch is a browser api. Not related to node. So it has devtools integration because it is part of the browser. Fetch is great. Promise-based api. Great for chaining
fetch('some-json-api.com')
  .then(result => result.json())
  .then(console.log)
  .catch(console.log)

@amilajack thanks very much for your help
Just to share what I figure out :
fetch('some-json-api.com')
.then(result => {return result.json()})
.then(result => {console.log(result)})
hope that helps.

My example and your's are equivalent. Mine is shorthand
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions#Shorter_functions


Add GetUsers endpoint

Add GetUsers endpoint
Delete session when refresh token is expired
Minor changes to TokenError
Organize functions in ecdar_api.rs

LGTM


Feature request : OpenAPI 3.0 support

Are there any plans to add support for OpenAPI 3.0? https://github.com/Rebilly/ReDoc/issues/312

Here is the specification: https://github.com/OAI/OpenAPI-Specification and https://swagger.io/docs/specification/about/

Really excited to be able to do this
https://github.com/OAI/OpenAPI-Specification/issues/57


Improve document API for stored fields.

Currently stored fields have to look at binaryValue(), stringValue() and numericValue() to guess the type of the value and then store it. This has a few issues:

If there is a problem, e.g. all of these 3 methods return null, it's currently discovered late, when we already passed the responsibility of writing data from IndexingChain to the codec.
numericValue() is used both for numeric doc values and storage. This makes it impossible to implement a double field that is stored and doc-valued, as numericValue() needs to return simultaneously a number that consists of the double for storage, and the long bits of the double for doc values.
binaryValue() is used both for sorted(_set) doc values and storage. This makes it impossible to implement keyword fields that is stored and doc-valued, as the field returns a non-null value for both binaryValue() and stringValue() and stored fields no longer know which field to store.

This commit introduces IndexableField#storedValue(), which is used only for stored fields. This addresses the above issues. IndexingChain passes the storedValue() directly to the codec, so it's impossible for a stored fields format to mistakenly use binaryValue()/stringValue()/numericValue() instead of storedValue().

This is great, thanks for looking into it. It moves "type-guessing" into the one place that should be doing it, which is the generic Field.java
i didn't really think too deeply about implementation but I suppose there might be a few options:

"Box" the value along with its type, like what you've done here (are there perf implications?)
change api of the visitor, e.g. to provide field's type (like the enum inside your current "box") before the value

@rmuir I tried your idea of using a different method per type of stored value, and I liked the result: StoredValue no longer escapes the document API and the default impl for merging became more straightforward.

I went one step further:

StringField now implements storedValue() instead of relying on the guessing of Field#storedValue()
IntField, LongField, FloatField and DoubleField now support storing the value

This looks good to me overall, so I marked the PR as ready for review, what do you think?

Thanks for removing the type-guessing from the "structured" fields and supporting store! Can we fix the class-level javadocs for IntField & co?
They still say this: "If you also need to store the value, you should add a separate StoredField instance."

Thanks for catching this, I just pushed a fix.


Moved the setting of ulimit from the startup script to the docker file.

When I tried to run the docker file on AWS received an error similar to "ulimit: open files: cannot modify limit: Operation not permitted".  It looked similar to the issue at http://stackoverflow.com/questions/24961576/docker-error-while-creating-couchbase-ulimit-open-files-cannot-modify-limit and moving the ulimit command from the startup script to the docker file fixed the problem for me.
I am very new to docker, neo4j and bash scripts, so what I have done might be sub-optimal :-)

did you try to run it with --privileged ?
https://docs.docker.com/reference/run/#runtime-privilege-linux-capabilities-and-lxc-configuration

also the enviroment variable is not taken into account during build b/c it is not set, it was a runtime setting

Sorry, I forgot one small, tiny detail :$ ... I was tryng to run the container on a single-instance AWS Beanstalk docker envrionment. Running the docker instance locally works just fine. Using the docker file to build an instance in AWS causes the problem I saw.  I understand that this is a beta and not for production\serious use .... I just thought I'd try it :-)
It seems that running the --privileged flag is not recommended (
Stack Overflow)  and I'm not sure it's officially supported in an AWS Beanstalk environment.
You're right about the environment variable not being taken into account.

Seems like a reasonable compromise might be to put the standard ulimit -n 4000 in the Dockerfile to handle cases like this, and leave the if statement that looks for $NEO4J_OPEN_FILES in the startup script, so if a user really needs a different limit they can set it at runtime.

@jbhannah yes that sounds good, care to send a PR for it?

@jexp Done.

This has been implemented in #7.

Cool, thanks guys.

@britebit FYI: I have now take this out altogether and documented the use of docker run --ulimit instead (see 070bd66).
I found that ulimit in the Dockerfile was having no effect because those settings are only per-session.


feat!: properly implement constants in c#

Description
Enable the C# Class and Record Generators to properly handle constant values.
Related Issue
fixes #1471
Checklist

[x] The code follows the project's coding standards and is properly linted (npm run lint).
[x] Tests have been added or updated to cover the changes.
[ ] Documentation has been updated to reflect the changes.
[x] All tests pass successfully locally.(npm run test).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-9 of 24 (62.5%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 92.164%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/generators/csharp/renderers/ClassRenderer.ts
4
6
66.67%

src/generators/csharp/constrainer/ConstantConstrainer.ts
9
16
56.25%

Files with Coverage Reduction
New Missed Lines
%

src/generators/csharp/constrainer/ConstantConstrainer.ts
1
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
6005

Relevant Lines:
6345

💛  - Coveralls

I think we have to do this change on the next branch, as the serializer currently in place will break as they will try assign values to the constants 🤔

Similar to https://github.com/asyncapi/modelina/pull/1799

@jonaslagoni No, I can definitely add a migration guide for this. I probably won't have the time for it until Friday though.

@jonaslagoni No, I can definitely add a migration guide for this. I probably won't have the time for it until Friday though.

No worries, no rush :v:

Changed the target branch to next :v:

I think we have to do this change on the next branch, as the serializer currently in place will break as they will try assign values to the constants 🤔 I think that either we add an issue after this PR is merged, or we adapt the presets where needed.

If you point me to the correct place I might be able to adapt the serializers right in this PR / add a second PR before we merge this one?

You have the presets here: https://github.com/asyncapi/modelina/blob/master/src/generators/csharp/presets/JsonSerializerPreset and https://github.com/asyncapi/modelina/blob/master/src/generators/csharp/presets/NewtonsoftSerializerPreset.ts
I think you only need to make changes to renderSerializeProperty and renderDeserializeProperty and check whether the model has a constant value, if so, dont serialize what you get, just set it 🙂

You have the presets here: https://github.com/asyncapi/modelina/blob/master/src/generators/csharp/presets/JsonSerializerPreset and https://github.com/asyncapi/modelina/blob/master/src/generators/csharp/presets/NewtonsoftSerializerPreset.ts
I think you only need to make changes to renderSerializeProperty and renderDeserializeProperty and check whether the model has a constant value, if so, dont serialize what you get, just set it 🙂

Im still trying to understand the serializer so forgive me if this is a dumb question, but do we really need to change the renderDeserializeProperty function? Writing to the constant values would be a problem for sure, but deserialising shouldn't be a problem, because it only reads that property, right?

Most likely correct @moritzkalwa 👍 you can use the runtime test to ensure it works 😄

/rtm


Swiper is hypersensitive on macBooks touchpad with horizontal inertial scrolling

One "swipe", no matter how strong, should equal one slide. That is not the case on a MacBook's trackpad with inertial scroll, where one swipe often slides one than one slide.
You can see this behaviour on this service I am building right now.
The Swiper's documentation does not mention how to deal with inertial scrolling.
The issue is so severe, that it is go or no go for Swiper on my service(s) / websites.
Cheers

i think this is similar to #1810

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


GeoPandas Centroid Issue

calculate_area_type uses GeoPandas centroid method like this:
centroids_gdf["geometry"] = centroids_gdf["geometry"].centroid
When I run this as part of the Scenario Quickstart, centroids_gdf["geometry"] returns a pandas Series, not a GeoPandas DF, so the returned object cannot be used in subsequent spatial joins. Is this a recent change with GeoPandas? Or is the wrong version being used in the develop branch?

Interesting. I just ran the test test_calculate_area_type() and test_write_cube_roadway() without trouble with the latest versions of develop branch and geopandas==0.7.0.  Do those tests pass for you?
I also ran the scenario quickstart notebook without problems (other than the bike plot issue)

Yes, must have been a problem with my configuration. Thanks.


Delete duplicate blockchainevents when migrating

Should fix any environments that got into a bad state between 0e559460a4ee2c68a66c23a5ca108bc98e7dfded (1.1.0-rc.1) and d75f2d4a0cd689df174d57d8e40d4c623c129e0d (1.1.0-rc.4).

Codecov Report

Merging #1063 (9d5b690) into main (cd6a4d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   99.99%   99.99%
=======================================
  Files         307      307
  Lines       20294    20294
=======================================
  Hits        20292    20292
  Misses          2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


sc-10247 fix reviewers note section in the PDF file

Scope of changes
sc-10247 fix reviewers note section in the PDF file
Type of change

[x] bug fix
[ ] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
https://app.shortcut.com/rotational/story/10247/fix-reviewers-note-section-in-the-pdf-file
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report
Base: 44.10% // Head: 25.00% // Decreases project coverage by -19.09% :warning:

Coverage data is based on head (6b34998) compared to base (0cebf93).
 Consider uploading reports for the commit ab409ff to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #845       +/-   ##
===========================================
- Coverage   44.10%   25.00%   -19.10%
===========================================
  Files         617      351      -266
  Lines       23035     3199    -19836
  Branches     1405      762      -643
===========================================
- Hits        10159      800     -9359
+ Misses      11551     2386     -9165
+ Partials     1325       13     -1312

Flag
Coverage Δ

unittests
25.00% <ø> (-19.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...gds-admin-ui/src/pages/app/details/VaspDocument.js

...b.com/trisacrypto/directory/pkg/gds/interceptor.go

...src/pages/app/details/CertificateDetails/Detail.js

...risacrypto/directory/pkg/bff/api/v1/credentials.go

...b/gds-admin-ui/src/redux/selectors/review-notes.js

web/gds-admin-ui/src/services/autocomplete.js

...ils/BasicDetails/components/AddressesFieldArray.js

web/gds-admin-ui/src/components/Field.js

web/gds-admin-ui/src/layouts/Menu.js

web/gds-admin-ui/src/components/Pagination.js

... and 256 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


meteor support

I've been using this package with the velocity framework and wanted to know if you were interested in supporting this as a meteor package. In case you already have a meteor username I would just have to change it in the package.js

Seems like a good idea and safe enough (purely additive).


TOOLSREQ-6431: Add Support for xrefs to Admonitions

NOTE: This seems to work in practice but two xspec tests are not working. Creating a draft PR so I don't forget, but this is not ready for review.
Adding support for cross-references to admonitions (notes, tips, warnings) by

Giving them the pagenum class in param.xsl so that xrefs in PDFs display
the page number (as dictated by the CSS theme), and 2) adding handling in
xrefgen.xsl so that a warning is display if the linked admonition has no
title. This is necessary because admonitions are valid with and without
titles.

 Not sure what to do about that (if anything). As mentioned above, the relevant files for the diff are param.xsl and xrefgen.xsl.
Priority: Low - Kristen mentioned that these references are rare and we have the one off in case it's necessary.
See TOOLSREQ-6431

UPDATE: The opfc.xspec and ncx.xpsec tests were failing, but they are also failing for master. That requires some additional investigation, but doesn't seem relevant to this PR.

I see your note about tests, but did you write a new one for this change?

@hackermatthew That's a good point, I had meant to add new tests, but forgot in the interim. I pushed a new commit with new tests added to xrefgen.xspec.


[MM-12738] Migrate OAuth app actions from user_actions.jsx and admin_…

Summary
Migrated actions:

allowOAuth2
getOAuthAppInfo
getAuthorizedApps
deauthorizeOAuthApp

Updated corresponding components
Ticket Link
MM-12738
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)
[x] Touches critical sections of the codebase (OAuth related actions)

Requesting review from @sudheerDev as he's given more thoughts about this.

PR is updated, have a look please

@deanwhillier, done

Thats great, thanks again @MirlanMaksv!

I made mistake in user_settings_security test, now it is polluting test output with a warning. Here is the PR with a fix.
I am sorry for troubles


Customized Cleaning not working anymore

Describe the bug
When I try to enable Customized Cleaning, its trying to turn on, but after a second return to off
To Reproduce
Just trying to turn on "Customized Cleaning"
Additional Information (please complete the following information)

Model Name: dreame.vacuum.r2254
Firmware Version: 4.3.3_1709
dreame-vacuum v2.0.0b14
Home Assistant Version: Core - 2024.4.3 \ Supervisor - 2024.04.0
Configuration Type [With or without map support]: with map suport (latest beta)
Errors or warnings shown in the HA logs (if applicable):  nothing in logs. I've also got a script, that enable "Customized Cleaning" and change cleaning mode in rooms. No error about settings "Customized Cleaning", but got an error when trying to change cleaning mode:

2024-04-22 18:58:17.015 WARNING (MainThread) [homeassistant.helpers.service] Referenced entities select.mijia_infinite_robot_vacuum_mop_1s_room_8_cleaning_mode are missing or not currently available
2024-04-22 18:58:17.015 WARNING (MainThread) [homeassistant.helpers.service] Referenced entities select.mijia_infinite_robot_vacuum_mop_1s_room_5_cleaning_mode are missing or not currently available

Try reloading the integration.

already tried, also tried reboot HA

Enable the info logs, repeat the process and send me the output.

As I said before, nothing happend in logs 😢

2024-04-22 21:12:16.440 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration dreame_vacuum which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant 2024-04-22 21:12:29.793 INFO (MainThread) [custom_components.dreame_vacuum] Integration loading: Mijia Infinite Robot Vacuum-Mop 1S 2024-04-22 21:12:29.794 INFO (MainThread) [custom_components.dreame_vacuum] Integration starting... 2024-04-22 21:12:30.028 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Connecting to device 2024-04-22 21:12:30.129 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Connected to device: dreame.vacuum.r2254 4.3.3_1709 2024-04-22 21:12:30.842 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property STATE Added: 6 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property ERROR Added: 0 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property BATTERY_LEVEL Added: 44 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CHARGING_STATUS Added: 1 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property STATUS Added: 6 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CLEANING_TIME Added: 0 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CLEANED_AREA Added: 0 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SUCTION_LEVEL Added: 1 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property WATER_VOLUME Added: 2 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property WATER_TANK Added: 0 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property TASK_STATUS Added: 0 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property RESUME_CLEANING Added: 1 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CARPET_BOOST Added: 0 2024-04-22 21:12:30.843 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MOP_CLEANING_REMAINDER Added: 0 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CLEANING_PAUSED Added: 0 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property FAULTS Added: 0 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property NATION_MATCHED Added: unknown 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property RELOCATION_STATUS Added: 0 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property OBSTACLE_AVOIDANCE Added: 1 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AI_FURNITURE_DETECTION Added: True 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AI_OBSTACLE_DETECTION Added: True 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AI_OBSTACLE_PICTURE Added: True 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AI_FLUID_DETECTION Added: False 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AI_PET_DETECTION Added: True 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AI_OBSTACLE_IMAGE_UPLOAD Added: True 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AI_IMAGE Added: False 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AI_PET_AVOIDANCE Added: False 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property FUZZY_OBSTACLE_DETECTION Added: False 2024-04-22 21:12:30.844 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property PET_PICTURE Added: True 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property PET_FOCUSED_DETECTION Added: False 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property LARGE_PARTICLES_BOOST Added: False 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CLEANING_MODE Added:<PHONE_NUMBER>-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property UPLOAD_MAP Added: 1 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SELF_WASH_BASE_STATUS Added: 0 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CUSTOMIZED_CLEANING Added: 1 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CHILD_LOCK Added: 0 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CARPET_SENSITIVITY Added: 2 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property TIGHT_MOPPING Added: 0 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CLEANING_CANCEL Added: 0 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property Y_CLEAN Added: 0 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property WATER_ELECTROLYSIS Added: 1 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CARPET_RECOGNITION Added: 3 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SELF_CLEAN Added: 1 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property WARN_STATUS Added: 101 2024-04-22 21:12:30.845 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CARPET_CLEANING Added: 2 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AUTO_ADD_DETERGENT Added: 1 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CAPABILITY Added: 0 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SAVE_WATER_TIPS Added: 0 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DRYING_TIME Added: 2 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property LOW_WATER_WARNING Added: 0 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MOP_WASH_LEVEL Added: 1 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AUTO_MOUNT_MOP Added: 0 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SCHEDULED_CLEAN Added: 0 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SHORTCUTS Added: [] 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property INTELLIGENT_RECOGNITION Added: 0 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property COLLISION_AVOIDANCE Added: 1 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property FILL_LIGHT Added: 1 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AUTO_DRYING Added: 1 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property STAIN_AVOIDANCE Added: 1 2024-04-22 21:12:30.846 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MOPPING_TYPE Added: 0 2024-04-22 21:12:30.847 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MOP_PAD_SWING Added: 1 2024-04-22 21:12:30.847 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AUTO_WATER_REFILLING Added: 0 2024-04-22 21:12:30.847 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MOP_IN_STATION Added: 0 2024-04-22 21:12:30.847 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MOP_PAD_INSTALLED Added: 0 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DEVICE_CAPABILITY Added: 0 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DND Added: True 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DND_START Added: 22:00 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DND_END Added: 08:00 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DND_TASK Added: [{"id":0,"en":true,"st":"22:00","et":"08:00","wk":127,"ss":0}] 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MULTI_FLOOR_MAP Added: 1 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MAP_LIST Changed:<PHONE_NUMBER>/1058343170/9 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property RECOVERY_MAP_LIST Added: {"object_name":"1752213257/1058343170/8"} 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MAP_RECOVERY_STATUS Added: 0 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MAP_BACKUP_STATUS Added: 0 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property WIFI_MAP Added:  2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property VOLUME Added: 30 2024-04-22 21:12:30.848 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property VOICE_PACKET_ID Added: 20 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property VOICE_ASSISTANT Added: 0 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property EMPTY_STAMP Added: 0 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CURRENT_CITY Added:  2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property VOICE_TEST Added: 0 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property TIMEZONE Added: Europe/Moscow 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SCHEDULE Added:  2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SCHEDULE_CANCEL_REASON Added: 0 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MAIN_BRUSH_TIME_LEFT Added: 163 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MAIN_BRUSH_LEFT Added: 54 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SIDE_BRUSH_TIME_LEFT Added: 63 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SIDE_BRUSH_LEFT Added: 31 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property FILTER_LEFT Added: 74 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property FILTER_TIME_LEFT Added: 111 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property FIRST_CLEANING_DATE Added:<PHONE_NUMBER> 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property TOTAL_CLEANING_TIME Added: 8162 2024-04-22 21:12:30.849 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property CLEANING_COUNT Added: 105 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property TOTAL_CLEANED_AREA Added: 7089 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property TOTAL_RUNTIME Added: 0 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AUTO_DUST_COLLECTING Added: 1 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AUTO_EMPTY_FREQUENCY Added: 1 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DUST_COLLECTION Added: 1 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property AUTO_EMPTY_STATUS Added: 0 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SENSOR_DIRTY_LEFT Added: 46 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property SENSOR_DIRTY_TIME_LEFT Added: 13 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MOP_PAD_LEFT Added: 51 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property MOP_PAD_TIME_LEFT Added: 41 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DETERGENT_LEFT Added: 36 2024-04-22 21:12:30.850 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Property DETERGENT_TIME_LEFT Added: 6 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability AI_DETECTION 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability AUTO_EMPTY_BASE 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability AUTO_RENAME_SEGMENT 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability AUTO_SWITCH_SETTINGS 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability BACKUP_MAP 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability CARPET_RECOGNITION 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability CRUISING 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability CUSTOM_CLEANING_MODE 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability CUSTOMIZED_CLEANING 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability DND 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability DND_TASK 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability FLOOR_MATERIAL 2024-04-22 21:12:30.902 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability LIDAR_NAVIGATION 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability MAP 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability MOP_PAD_LIFTING 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability MULTI_FLOOR_MAP 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability OBSTACLES 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability SELF_WASH_BASE 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability SHORTCUTS 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability TIGHT_MOPPING 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability VOICE_ASSISTANT 2024-04-22 21:12:30.903 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.device] Capability WIFI_MAP 2024-04-22 21:12:30.920 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.map] Request map from device [{'piid': 2, 'value': '{"frame_type":"I"}'}] 2024-04-22 21:12:31.001 INFO (SyncWorker_3) [custom_components.dreame_vacuum.dreame.map] Get Recovery Map List:<PHONE_NUMBER>/1058343170/8 2024-04-22 21:12:36.011 INFO (Thread-6) [custom_components.dreame_vacuum.dreame.map] Get Recovery Map List:<PHONE_NUMBER>/1058343170/8 2024-04-22 21:12:57.092 DEBUG (Thread-16) [custom_components.dreame_vacuum.dreame.device] Device update: 5 2024-04-22 21:13:01.595 DEBUG (Thread-19) [custom_components.dreame_vacuum.dreame.device] Device update: 5 2024-04-22 21:13:06.823 DEBUG (Thread-20) [custom_components.dreame_vacuum.dreame.device] Device update: 5 2024-04-22 21:15:42.155 DEBUG (Thread-45) [custom_components.dreame_vacuum.dreame.device] Device update: 10 2024-04-22 21:15:49.274 DEBUG (Thread-48) [custom_components.dreame_vacuum.dreame.device] Device update: 10

You are right there is nothing in the logs but it should be so problem may be related to your HA. I have no clue about it if there is nothing happening in the logs.

Tried to reinstall via HACS, does not helped.
After that I delete device, add it again and problem fixed. I think problem was in xiaomi account, after relogin all fine.
Thanks for your help.


PowerRename add extensions to extension-less files

📝 Provide a description of the new feature
At the moment there is no way to add an extension to an extension-less file with regex.
When working with files from different systems I often have a set of files where I know the type but the file doesn't have an extension so I need to add one in order for Windows to handle it correctly. I cannot do this with PowerRename and have to resort to ReNamer (http://www.den4b.com/products/renamer) which allows me to do so.
Otherwise PowerRenamer is great! :-)

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@maxscan
did you try?

Hi Enrico
Thanks for the quick reply!

Thanks so much,
Max


Don't raise an error when asking for callers of an uncallable node [phab:D1219]

Created by zarko at 2017-01-05 19:26:23:
Ported from a patch by schroederc

schroederc accepted this revision at 2017-01-05 19:28:31

schroederc wrote at 2017-01-05 19:28:40:
Thanks!

zarko closed via commit 5a6a077bb5bfe2014a2acaf65e8750950dfa24e6 at 2017-01-05 20:23:02


[PE-D][Tester D] Incorrect display of error message for edit

When I tested out the functions with invalid indices -1, 0 and 10, only the one with positive integer gave me an error message that says candidate index provided is invalid. However, when I tested out with -1 and 0, I got back an invalid command format error message. I think to resolve this we can check the logic of the index first and throw the specific error when the index is invalid.

Labels: type.FunctionalityBug severity.High
original: ttzuche/pe#5

Error message is correct since it was clearly stated that parameters INDEX must be POSITIVE. Hence, any integers less than equal to 0 is considered a command format error since the user is not following the stated command format


closing the tab in browser does not kill the software in the background

@mmertama Closing the tab in browser does not kill the software in the background
Steps to reproduce:

open calc example
replace constructor with Gempyre::Ui ui(Calc_resourceh, "calc.html", "brave", "");//change the name to your browser
close the tab.
app won't close.
tried it with Librewolf (a fork of Firefox). Same behavior.

The previous release didn't have this problem. this problem appeared in 1.0.0.

There was some regression in 1.0.0 - I just pushed 1.0.1 that fix the issue among others. Please verify if there is still the issue.


removed extra whitespace

In the readme file there are 2 lines with extra whitespace. This is not a huge problem however many text editors (such as Atom which I use) remove this whitespace automatically when you save your files. This causes many people who want to change something else in the readme to have to go in and undo the automatic whitespace removal.
Here is an example of that happening.
I also had the same issue when I made my first commit to a pull request and you can see here where I had to go back an undo the change.
While this is not something that needs to be fixed, it would be nice to removed the whitespace to reduce any future issues.

Thanks!


feat(chart): Allow Braille/Dot charts to overlap with Block

The Chart widget allows multiple line/scatter plots to be drawn on the same axis.  Prior to this commit, for a given tile of the canvas, the output was entirely determined by the top-most line plot to touch that tile.
In most cases, two overlapping lines cannot be rendered on top of each other.  For example, drawing Marker::Braille on top of Marker::Dot requires replacing the character being drawn.  However, Marker::Block is an exception, as a block may be accurately represented as either symbols::block::FULL in the foreground, or with a background color.
This commit updates the rendering of the Chart widget to allow two line/scatter plots to overlap, where the first chart uses Marker::Block, and the second chart uses either Marker::Braille or Marker::Dot.

As an example of the visual effect, screenshots from an interface I'm working on.
Before, where the red Marker::Braille and the dark green Marker::Block overlap, the dark green disappears entirely:

After, where the red Marker::Braille and the dark green Marker::Block overlap, the dots are drawn on top of the dark green background:

Neat idea and effect. I may take me a bit of time to dig into the code change for this one.
A small question though, I wonder whether this makes sense as the default, or if it should instead be an option that can be configured? What do you think?

Neat idea and effect. I may take me a bit of time to dig into the code change for this one.

Thank you!  I realized looking at it that there's a larger delta than I had expected.

Core functionality change, to have the symbol, foreground and background each apply separately.
Usage of new functionality, where the apply_color_to_bg functionality is only applied for the Marker::Block style.
Moving the for dataset in &self.datasets inside the .paint function causes overlapping charts to be resolved within the chart's Canvas, rather than within the Buffer as a whole.

All other changes are to keep the same user-facing functionality within the updated canvas.

A small question though, I wonder whether this makes sense as the default, or if it should instead be an option that can be configured? What do you think?

For the core functionality, separating out the symbol/fg/bg, I'd lean to have it enabled unconditionally, mainly because all the existing user-facing functionality can be implemented with symbol/fg/bg potentially coming from separate layers.  It would allow for additional marker types (e.g. a Marker::Highlight that would change the foreground color to highlight something, without changing the symbol) that can't be expressed with the current Layer class.
For the user-facing functionality, I was going back and forth on whether it should be a separate Marker variant (e.g. Marker::Background) rather than a special behavior of Marker::Block.  I ended up having it be part of Marker::Block, because it would have no visual difference when the plots are non-overlapping, and the change to overlapping commands is limited to the Canvas widget.
So I think it would make sense as a default behavior for Marker::Block, but only because it occurs within a context used for drawing images rather than displaying text.


Failed to find source path

https://sourceb.in/E7E4CxfG0I
Repository: https://github.com/railwayapp/nixpacks

I just released v0.5.29 which should fix this bug. Once Flowistry updates, please let me know if this fixes your issue.

Fixed, thank you!