Communities & Collections tree browser updates - Replaced #2597

References
Description
This PR fixes two issues with the community collection list page:

The show more button not rendering after selection and more pages available.
When multiple show more nodes without unique id, the nodes are not being placed or expanding correctly.

Instructions for Reviewers
Set communityList.pageSize to a small number (less than half the number of top-level communities and less then subcommunities under a community).
communityList:
  # No. of communities to list per expansion (show more)
  pageSize: 4

Navigate to Communities & Collections page. Click show more pages and expand communities/subcommunities which multiple pages at the same level. The described issues above should no longer occur.
List of changes in this PR:

The condition to render the show more button has been updated to render when more pages are available after selection. Previously it was not rendering after a selection and more pages are available.
The id of the show more node added to the tree must be unique otherwise it is placed at the wrong level and clicking pages the wrong page (level). To make the node id unique, it was appended with hyphen and a newly generated UUID. The condition during getNextPage was updated to match node.id startsWith collection or community.

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[ ] If my PR fixes an issue ticket, I've linked them together.

NOTE: This is already at +1 since it's just an update version of the #2597 PR which was approved by @artlowel already.  This PR has the same changes, but is just based on an updated branch.


Windows.UI.Core.Preview namespace not present in cppwinrt 200316.3?

Trying to implement the CloseRequested handler for UWP but the namespace doesn't seem to be available - is this still an option? Build is set to minimum 10.0.17134.0 and the winrt version is 200316.3 - as near as I can tell the UI.Core.Preview namespace should require only build 15063. Now I'm wondering if this capability is no longer around. As everything else is working fine I don't want to update winrt or VS 16.5.4 unless necessary.

C++/WinRT doesn't filter by version. Double check that the input set of winmd files contains the types you're looking for. Ignoring Velocity, nothing should prevent them from showing up like any other.

Thanks for the quick response! What I needed was to #include  <winrt/Windows.UI.Core.Preview.h> in my pch file. That took me past this bump...

Yes, includes are still necessary. 😉

Same as Windows.UI.Core.AnimationMetrics namespace not present in cppwinrt 210714.1


cocoapods version 2.1.6 is broken

First up, thanks for a great library! :-)
Anyways, trying to install (or update an existing install) by using the following line in the podfile
pod 'KVNProgress'

gives a warning that pods cannot find the Pods/KVNProgress/LICENSE file. Additionally, Xcode cannot compile as it is missing a file KVNProgressConfiguration.h.
changing podfile line to
pod 'KVNProgress', '2.1.4'

resolves issue

Thanks for your support and for noticing :)
So what you say is that having pod 'KVNProgress' in the Podfile and then you do a pod install or pod update and the command returns you the missing files error?
I will look at this issue in priority!

thats right. if you force it to use 2.1.4, it works as intended.
Thanks! :)

Can you confirm that all is working well now? :)

Tested it earlier today, it's working perfectly. Thanks again :)
Sent from my iPhone

On 21 Jan 2015, at 6:11 pm, Kevin Hirsch<EMAIL_ADDRESS>wrote:
Can you confirm that all is working well now? :)

Reply to this email directly or view it on GitHub.

Thank you very much! I am closing this issue then ;)


Update background color and text color

This pull request updates the background color and text color in the index.module.css and custom.css files. The background color is changed to #05486c and the text color is changed to #edf7f6. This improves the overall accessibility of the application.
The choices of colors are related to CFIA Colour Palette, as well as the use of https://docusaurus.io/docs/styling-layout/#styling-your-site-with-infima
I also tried to test the website with IBM Equal Access Accessibility Checker available there : https://github.com/IBMa/equal-access

Could you provide a screenshot, please?

I follow this palette :

In order to generate the different shades of colors chosen : https://docusaurus.io/docs/styling-layout/#styling-your-site-with-infima
Light color : #387fa3

Dark color : #389579

Can you post a screenshot of the updated look, please?

@RussellJimmies


Investigate possible incorrect query results related to ORC decimal min/max statistics

https://issues.apache.org/jira/browse/ORC-517 doesn't say this causes correctness problem
But   https://github.com/apache/orc/pull/405/files#diff-a0861c5ad0775baf23793ac86da5fbb6R502-R507
ignores stats written by older writers, suggesting there was a correctness problem.

I took a look at this yesterday, and was able to reproduce the incorrect stats issue. I don't think we need to explicitly skip stats for that generation of the writer though. The stats are always more inclusive than they need to be, so I don't think this will cause incorrect results from predicate pushdown.

Thanks for checking @alexjo2144


StubRequestFilter  used to encode the URL is not working as expected.

my Sample url  :
Get /uri?filter={"accountID":1}
I've the stub for the Get with the
wireMockRule.stubFor(get("uri?"+URLEncoder.encode(filter={"accountID":1}))
I've written the custom StubRequestFilter to encode the query param  .
But request fails with IllegalArgumentException , because of UrisyntaxException.
public class EncodeRequestFilter extends StubRequestFilter {

	@Override
	public String getName() {
		return "encode-uri";
	}

	@Override
	public RequestFilterAction filter(Request request) {

		System.out.println("Coming to encode filter");
		//request.isBrowserProxyRequest();
		Request wrappedRequest = RequestWrapper.create().transformAbsoluteUrl(this::encodeAbsoluteUrl).wrap(request);
		wrappedRequest.isBrowserProxyRequest();
        //System.out.println(wrappedRequest.getAbsoluteUrl());
		return RequestFilterAction.continueWith(wrappedRequest);
	}

	private String encodeAbsoluteUrl(String absoluteUrl) {
		int idxOfQueryParam = absoluteUrl.indexOf("?");
		String queryParam = absoluteUrl.substring(idxOfQueryParam + 1);

		if (queryParam.contains("{"))// has json value as part of query encode it .
		{
			try {
				String encodedQuery = URLEncoder.encode(queryParam, StandardCharsets.UTF_8.name());
				return absoluteUrl.substring(0, idxOfQueryParam + 1).concat(encodedQuery);
			} catch (UnsupportedEncodingException e) {
				return absoluteUrl;// Ignoring the exception.Let the request fail
			}
		}
		return absoluteUrl;
	}

}

If you think this is a bug, please can you post a failing test case.
If you're just asking for some help implementing a filter, please post on the mailing list

The absoluteUrlTransformer set on the requestWrapper is never used .
Caused by:java.net.URISyntaxException: Illegal character in query at index 23:
/uri?filter={"accountid":"1"}
	at java.net.URI$Parser.fail(URI.java:2848)
	at java.net.URI$Parser.checkChars(URI.java:3021)
	at java.net.URI$Parser.parseHierarchical(URI.java:3111)
	at java.net.URI$Parser.parse(URI.java:3063)
	at java.net.URI.<init>(URI.java:588)
	at java.net.URI.create(URI.java:850)
	at com.github.tomakehurst.wiremock.jetty9.JettyUtils.getUri(JettyUtils.java:93)
	at com.github.tomakehurst.wiremock.servlet.WireMockHttpServletRequestAdapter.isBrowserProxyRequest(WireMockHttpServletRequestAdapter.java:257)
	at com.github.tomakehurst.wiremock.extension.requestfilter.RequestWrapper.isBrowserProxyRequest(RequestWrapper.java:271)
	at com.github.tomakehurst.wiremock.verification.LoggedRequest.createFrom(LoggedRequest.java:69)
	at com.github.tomakehurst.wiremock.stubbing.InMemoryStubMappings.serveFor(InMemoryStubMappings.java:82)
	at com.github.tomakehurst.wiremock.core.WireMockApp.serveStubFor(WireMockApp.java:204)
	at com.github.tomakehurst.wiremock.http.StubRequestHandler.handleRequest(StubRequestHandler.java:53)
	at com.github.tomakehurst.wiremock.http.AbstractRequestHandler.handle(AbstractRequestHandler.java:60)
	at com.github.tomakehurst.wiremock.servlet.WireMockHandlerDispatchingServlet.service(WireMockHandlerDispatchingServlet.java:120)

{, } and " are considered unsafe characters accounting to https://www.ietf.org/rfc/rfc1738.txt. Java takes a fairly strict view of this, so this is why it's throwing an error.
If you URL encode your query parameters at the calling end, this should resolve the problem e.g. /uri?filter=%7B%22accountid%22%3A%221%22%7D.

You are right  .
But i don't have the code access to change the uri before the call comes to Wiremock .
So was trying with the requestfilter  .
Can't we use the requestFilter to accomplish the same  ?

No, it's already too late by that point unfortunately.

I see from the Wiremock Docs page ,RequestWrapper  could be used to  Transformation of the URL.
What are the scenarios i could use it ?

Sure, you can use it to transform URLs, but the URL will have been parsed by Java's URI class by the time it arrives at your filter.

Hmm Tom i see the issue comes when the RequestWrapper.isBrowserProxyRequest() method is called
Which inturn calls WireMockHttpServletRequestAdapter.isBrowserProxyRequest() .
Since the RequestWrapper will have the transformers  , can we pass it to WireMockHttpServletRequestAdapter.isBrowserProxyRequest() and invoke the transfomers there  .So the call to URi.create() would succeed.

I get the exception in class JettyUtils  .
```

public static URI getUri(Request request) {
HttpURI httpUri = getHttpUri(request);
    URI uri;
    try {
        Method getUriMethod = HttpURI.class.getDeclaredMethod("toURI");
        uri = (URI) getUriMethod.invoke(httpUri);
    } catch (NoSuchMethodException | SecurityException | IllegalAccessException | InvocationTargetException e) {
        uri = URI.create(httpUri.toString());
    }

    return uri;
}

Always the exception block gets executed and UR.create() , is throwing me the excpetion.

Yeah, actually that particular call doesn't really need to convert to a URI, since it's just used to check whether it's relative or absolute. Changing it to just do the absolute check directly against's Jetty's native class would probably solve this issue.
I'll mark this as a feature request and see about putting this in the next release.

@tomakehurst  Thank you .

Hi Tom ,
Any updates on this feature  , and may i know when can i expect this .
Thanks in advance

No updates and no idea when I'll be doing it, sorry.

Please could you suggest me changes which i can do it resolve it  , may be i'll try doing it from my end  .

Instead of converting URI.create(httpUri.toString());
Can we have a check if httpUri.toString().startsWith("http) or httpUri.toString().startsWith("httsp") ?
and continue .
And just for my information , method  isBrowserProxyRequest() why are we checking it ?


getTrackableId()

Hi,
in function getTrackableId() there is something I don't understand, first is why is returning $trackable I think is $trackable_id, second where is defined the property $model->trackable_id?
Regards,
Marco

Fixed. $model->trackable_id is something you can set manually. It's like a fallback. You can set it on your model and this will default to that.


Open topic status menu from followed topic icon in left sidebar

For convenience, clicking on the followed topic icon in the left sidebar should open the topic status menu. This is the same menu we currently open from the followed topic button in the topic header bar.

CZO thread

@zulipbot claim

@zulipbot claim

@zulipbot claim


Preserve original GEM before updating?

Describe the bug
My unit is MST2_EU_SE_ZR_P0241T (2 SD cards). It is completely stock and has GEM 3.5. Since that version is incompatible with the MIB2 Toolbox, it will be replaced with GEM 4.11 during the installation.
I would like to preserve a copy of the old GEM jar for educational and research purposes.
To Reproduce
N/A
Expected behavior
MIB2 Toolbox installer dumps the original GEM jar on the SD card.
Screenshots
N/A
Firmware (please complete the following information):

Brand: SEAT
Hardware MST ZR
Version 241

Additional context
I've looked at the 1.4.2 release. I was thinking of making the following changes to it:
diff --git a/install.sh b/install.sh
index d74caa0..a2967b6 100644
--- a/install.sh
+++ b/install.sh
@@ -95,6 +95,7 @@ if [ -d "$DESTINATION$ESD_FOLDER" ]; then
 	#GEM_SIZE=$(ls -la "$DESTINATION/tsd/hmi/HMI/jar/GEM.jar" | awk '{print $5}' 2>/dev/null)
 	#if [[ "$GEM_SIZE" = "187047" || "$GEM_SIZE" = "187234" || "$GEM_SIZE" = "242383" ]]; then
 		echo "Updating GEM to version 4.11..."
+		cp -fv $DESTINATION/tsd/hmi/HMI/jar/GEM.jar $VOLUME/dump/GEM.jar
 		if [[ -e "$VOLUME/toolbox/gem/cpu/onlineservices/1/default/tsd/bin/system/GEM.jar" ]]; then
 			cp -fv $VOLUME/toolbox/gem/cpu/onlineservices/1/default/tsd/bin/system/GEM.jar $DESTINATION/tsd/hmi/HMI/jar/GEM.jar
 			echo "GEM update is finished."
diff --git a/sigs_disk.txt b/sigs_disk.txt
index 538ead5..a1504f3 100644
--- a/sigs_disk.txt
+++ b/sigs_disk.txt
@@ -92,7 +92,7 @@
 437cec05b11ee16258eaa69d11d1ee3a  ./cpu/onlineservices/1/default/tsd/etc/persistence/esd/scripts/copy_skins.sh
 437cec05b11ee16258eaa69d11d1ee3a  ./toolbox/gem/cpu/onlineservices/1/default/tsd/etc/persistence/esd/scripts/copy_skins.sh
 442a2abd3a6f0330c0f47a0c3a7d7dd9  ./tools/compress-mcf.py
-4468d7700a52a8fb4d6cc32e4fd0e84e  ./install.sh
+2551d4ccdd9ea290655ef4d287d57620  ./install.sh
 45179ee42a7a8c0f91f3ac1399b323ef  ./cpu/onlineservices/1/default/tsd/etc/persistence/esd/scripts/dump_mapcfg.sh
 45179ee42a7a8c0f91f3ac1399b323ef  ./toolbox/gem/cpu/onlineservices/1/default/tsd/etc/persistence/esd/scripts/dump_mapcfg.sh
 454b1c8baf22eaa00dfaa7a567ba8ee1  ./toolbox/devesd/VW_V01_Nav_position_main.esd
diff --git a/sigs_sd.txt b/sigs_sd.txt
index 3afc125..c6f6076 100644
--- a/sigs_sd.txt
+++ b/sigs_sd.txt
@@ -91,7 +91,7 @@
 437cec05b11ee16258eaa69d11d1ee3a  ./cpu/onlineservices/1/default/tsd/etc/persistence/esd/scripts/copy_skins.sh
 437cec05b11ee16258eaa69d11d1ee3a  ./toolbox/gem/cpu/onlineservices/1/default/tsd/etc/persistence/esd/scripts/copy_skins.sh
 442a2abd3a6f0330c0f47a0c3a7d7dd9  ./tools/compress-mcf.py
-4468d7700a52a8fb4d6cc32e4fd0e84e  ./install.sh
+2551d4ccdd9ea290655ef4d287d57620  ./install.sh
 45179ee42a7a8c0f91f3ac1399b323ef  ./cpu/onlineservices/1/default/tsd/etc/persistence/esd/scripts/dump_mapcfg.sh
 45179ee42a7a8c0f91f3ac1399b323ef  ./toolbox/gem/cpu/onlineservices/1/default/tsd/etc/persistence/esd/scripts/dump_mapcfg.sh
 454b1c8baf22eaa00dfaa7a567ba8ee1  ./toolbox/devesd/VW_V01_Nav_position_main.esd

However, I have no way of testing if this will work before I run it on the unit.
EDIT:
Another way would be to just dump the stock eMMC, however, as far as I know (do correct me if I am wrong), the only way to do this without toolbox being installed is to read it directly from the eMMC, which requires disassembling the unit and is something I would like to avoid.

There is no need to preserve this file. If you want to go back to stock just reinstall your firmware. It's also only used in development. No real user would ever go into the GEM besides using the toolbox.

All gems are also backwards compatible so it's like you want to preserver windows 98 because you PC came with it 😅

Thanks for the quick response.
Yes, I am aware I do not need to preserve it. I want to.
Theoretically speaking, would the changes in the patch I provided above work as expected and dump the original GEM onto the SD? I am not familiar with the update-from-sd process, so I'm just speculating on the changes needed.
Thanks.

If you want to go back to stock just reinstall your firmware.

I cannot find a dump with the same firmware as mine, this is partially why I want to dump it.

Just use one from the same train. So every 02xx would be fine

The only 2xx i have found is an update to 253, but I've looked at the files it contains and it doesn't come with GEM. I suppose that's because 253 ships with 3.5 as well.
I've also googled for the jar itself but I'm unable to find it. As far as I can tell getting it from the dump is the only way to get it.

The gem is in the firmware. It will be replaced when installing.
I'll not assist further on storing or saving a useless file which don't need to be restored and can be restored with firmware installation.


feat: Add prefetch prop to

Type of changes

Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #6135
<nuxt-link> currently allows disabling prefetching with a specific link using a no-prefetch prop, but on the other hand, there is no way to prefetch a specific link when links prefetching is disabled globally via nuxt.config.js with prefetchLinks: false.
This PR adds a prefetch prop to <nuxt-link> which can be used when prefetchLinks is set to false.
Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly. (PR: https://github.com/nuxt/docs/pull/1550)
[x] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report

Merging #6292 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #6292      +/-   ##
==========================================
- Coverage   95.73%   95.69%   -0.04%
==========================================
  Files          79       79
  Lines        2650     2650
  Branches      682      682
==========================================
- Hits         2537     2536       -1
- Misses         97       98       +1
  Partials       16       16

Flag
Coverage Δ

#e2e
100% <ø> (ø)
:arrow_up:

#fixtures
50.22% <ø> (ø)
:arrow_up:

#unit
92.3% <ø> (-0.04%)
:arrow_down:

Impacted Files
Coverage Δ

packages/vue-renderer/src/renderer.js
93.49% <0%> (-0.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ca1ce...c5cf500. Read the comment docs.

What about prefetchLinks: “on-demand”?

What about prefetchLinks: “on-demand”?

Maybe the best option is to wait for the PR https://github.com/nuxt/nuxt.js/pull/6287 to be merged?

My apologies to have to do this, but I have just added a compileTemplate test helper method I would like you to ask to use to add unit tests (using vue-test-utils) instead of adding new fixtures. Adding new fixtures is not preferred as building each fixtures takes at least 10 seconds to the total test time.
You can have a look at nuxt-loading.test.js for an example of an existing component unit test.
For this pr you could use the compileTemplate function as follows:
// nuxt-link.client.prefetch.test.js
const compiledTemplatePath = await compileTemplate('components/nuxt-link.client.vue', 'nuxt-link.client.prefetch.vue', { router: { prefetch: true } })

// nuxt-link.client.noprefetch.test.js
const compiledTemplatePath = await compileTemplate('components/nuxt-link.client.vue', 'nuxt-link.client.noprefetch.vue', { router: { prefetch: false } })

For quick reference, here is the link to the vtu docs

I tried to do some tests but I faced some issues mounting the <nuxt-link> component with vue-test-utils:

Its probably because extends: Vue.component('RouterLink') fails. Did you add a stub or fake router-link component? See: https://vue-test-utils.vuejs.org/api/components/#routerlinkstub

I tried but it has no effect 😕

What about something like this?
import { createLocalVue } from '@vue/test-utils'

const localVue = createLocalVue()
// register stub component so nuxt-link extends its render fn
localVue.component('RouterLink', {
  render: h => h('a')
})

What about something like this?
import { createLocalVue } from '@vue/test-utils'

const localVue = createLocalVue()
// register stub component so nuxt-link extends its render fn
localVue.component('RouterLink', {
  render: h => h('a')
})
// load nuxt-link

Still face the issue 😕, I made a WIP commit to show you the code :) (I also needed to fix a bug in the compileTemplate helper)

Hmm, could you try to explicitly set the router-link component as a stub in the mounting options as described here?

Still facing the warning 😕
I tried : stubs: ['router-link'], stubs: ['RouterLink'], stubs: { 'router-link': true }

@lmichelin Hope you dont mind, but as I didnt knew the correct answer myself I just tried fixing this on your branch. The tests should work now.
Feel free to improve them further if you wish!

Nice! Thanks a lot for your help 😃

And btw do you agree with the fix in compileTemplate https://github.com/nuxt/nuxt.js/pull/6292/commits/374363a214a37d1c49c45323bcc82b804a9db5b5

Great work here @lmichelin 👏
One thing came to my mind when I read prefetch and no-prefetch props, what about deprecating no-prefetch in favour of :prefetch="false"?

I asked the question here https://github.com/nuxt/nuxt.js/pull/6292#discussion_r317368260 but @pi0 preferred not to deprecate it.

@lmichelin Let us know btw if you think this PR is now ready or if you wish to make some other changes, thanks :)

It's ok for me!


refactor: track show memo column based on account

GitHub Issue (if applicable): #2097
Explanation of Bugfix/Feature/Modification:
Enabled the Hidable Memo Field feature by default and updated the code to maintain hidden state scoped to each individual account.

maybe i'm doing something wrong, but i'm getting this error trying to compile:
After pulling the package my first steps were
yarn install
yarn watch
$ node scripts/generateFeedChanges
$ eslint --ignore-path .eslintignore ./src ./scripts || exit 0

/Users/Repositories/githubDesktop/toolkit-for-ynab/pr2119/scripts/updateLocalizationStrings.js
  70:22  error  Do not access Object.prototype method 'hasOwnProperty' from target object  no-prototype-builtins

✖ 1 problem (1 error, 0 warnings)

$ yarn build:webpack --env.buildType=development
$ webpack --env.buildType=development
Hash: b364380ed7c5281545e2
Version: webpack 4.40.2
Time: 7676ms
Built at: 08/18/2020 2:52:01 PM

Changing line 70 to this fixed it
if (Object.prototype.hasOwnProperty.call(node, key)) {

woops, just pushed a change to fix it


Better object subtype support

This does not yet address the exceptionDetails field but I'm not sure if that's easily possible (it might involve some bigger changes to how bugger handles evaluation to make that part work). But it's close.
Fixes https://github.com/buggerjs/bugger/issues/71
Fixes https://github.com/buggerjs/bugger/issues/70

Released in v2.3.0


build: fix build issue in 0.5.5

Fixes the build issue introduced in 0.5.5. We'll have to do a 0.5.6 release sadly.
It does add a few nice improvements though:

now also includes src in package.json
source maps point to source files, so whenever you now click on a type / method in e.g. vscode from credo you will be shown the source TS code rather than the build js code. Making debugging a lot easier I'd say :)

Yeah it has some impact on the bundle size as you include the src, but I think it's well worth it because of the goto source now actually works and that makes debugging a lot easier.

Yeah it has some impact on the bundle size as you include the src, but I think it's well worth it because of the goto source now actually works and that makes debugging a lot easier.

If it is included in the final production bundle, I am not sure I think it is worth it. Unpacked size of @credo-ts/core is already 4.7MB. Now, with the src it will be more than double so likely something around 10MB (for just core!) and if we also include atleast libaskar.so we will add another 5-7 MB... This is getting really big IMO.

Okay -- now released 0.5.6 as there was a build issue with 0.5.5. I'll look into it again. I like it when packages publish source code, but if it's not desired it's easy to not do it


Add Javascript sentry for production

See here for example: https://github.com/bihealth/varfish-server/search?l=HTML&q=sentry

Done.


Fix broken API references in universe/python

Update some API references that had fallen out of use.
Notably this no longer ran, since docker.#Run now asks for an "input" not an "image," alpine.#Image became alpine.#Build and you have to reference its output. Additionally, fix up the FIXME tag in the simplest way possible, though a better solution may exist.

Thank you for the contribution, @NotTheEconomist!
I think we should adopt the same pattern as bash.#Run (https://github.com/dagger/dagger/blob/main/pkg/universe.dagger.io/bash/bash.cue): use core.#WriteFile to write the file, rather than relying on cat.
The problem with cat is shell escaping which might cause problems with quotes, etc

The problem with cat is shell escaping which might cause problems with quotes, etc

Yeah I had a similar concern, but it was not immediately obvious how to do it another way. I'll use bash.#Run as a reference and update the PR a little later on today.

Alright, try it now

Fixed up the DCO just now, too.

Great, looks good to me!
/cc @helderco @shykes for universe API change review

Clean up your commit history and I think it will be ready to be merge

Whoa, I messed up that rebase, hold tight :)

Nothing to see here, folks! Just a guy that's been working on Perforce projects for too long remembering how git works... :)

Nothing to see here, folks! Just a guy that's been working on Perforce projects for too long remembering how git works... :)

Haha no worries :)
I'm waiting for CI to pass then will merge.
Thanks again for your contribution, greatly appreciated!

I started test, let's wait for a last approval of @helderco or @aluzzardi and if tests works, let's can merge it


reset password not working

Dear all,
I have tried with various versions to reset password, without any success. Just nothing happens.
Maybe I am doing something wrong?
Thanks for your help and advise. Working on Manjaro Linux.

Resetting passwords is actually not currently implemented into the server software, we already have a feature request open for that at https://github.com/getferdi/server/issues/16


fix: update to eye v9.7.9

fix: update to eye v9.7.9

:tada: This PR is included in version 12.5.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v12.5.7

Your semantic-release bot :package::rocket:


Undefined method 'split' for nil class

To reproduce, locally create a work. attach cat_scan.pdf
cat_scan.pdf

stack trace locally
[ActiveJob] [CreateDerivativesJob] [8dfff7f2-de0d-453a-9e6f-a24c03f22cb1] Error performing CreateDerivativesJob (Job ID: 8dfff7f2-de0d-453a-9e6f-a24c03f22cb1) from GoodJob(default) in 95.34ms: NoMethodError (undefined method `split' for nil:NilClass):
/usr/local/bundle/gems/derivative-rodeo-0.5.3/lib/derivative_rodeo/storage_locations/base_location.rb:66:in `from_uri'
/usr/local/bundle/bundler/gems/iiif_print-c6b566e6c435/app/services/iiif_print/derivative_rodeo_service.rb:361:in `input_uri'
/usr/local/bundle/bundler/gems/iiif_print-c6b566e6c435/app/services/iiif_print/derivative_rodeo_service.rb:331:in `rescue in lasso_up_some_derivatives'
/usr/local/bundle/bundler/gems/iiif_print-c6b566e6c435/app/services/iiif_print/derivative_rodeo_service.rb:323:in `lasso_up_some_derivatives'
/usr/local/bundle/bundler/gems/iiif_print-c6b566e6c435/app/services/iiif_print/derivative_rodeo_service.rb:269:in `block in create_derivatives'
/usr/local/bundle/bundler/gems/iiif_print-c6b566e6c435/app/services/iiif_print/derivative_rodeo_service.rb:268:in `each'
/usr/local/bundle/bundler/gems/iiif_print-c6b566e6c435/app/services/iiif_print/derivative_rodeo_service.rb:268:in `flat_map'
/usr/local/bundle/bundler/gems/iiif_print-c6b566e6c435/app/services/iiif_print/derivative_rodeo_service.rb:268:in `create_derivatives'
/usr/local/bundle/gems/hyrax-3.5.0/app/models/concerns/hyrax/file_set/derivatives.rb:52:in `create_derivatives'
/usr/local/bundle/gems/hyrax-3.5.0/app/jobs/create_derivatives_job.rb:12:in `perform'
/app/samvera/app/jobs/create_derivatives_job_decorator.rb:8:in `perform'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/execution.rb:39:in `block in perform_now'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:109:in `block in run_callbacks'
/usr/local/bundle/gems/i18n-1.14.1/lib/i18n.rb:322:in `with_locale'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/translation.rb:9:in `block (2 levels) in <module:Translation>'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:118:in `instance_exec'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:118:in `block in run_callbacks'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/logging.rb:26:in `block (4 levels) in <module:Logging>'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:168:in `block in instrument'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:168:in `instrument'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/logging.rb:25:in `block (3 levels) in <module:Logging>'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/logging.rb:46:in `block in tag_logger'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/tagged_logging.rb:71:in `block in tagged'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/tagged_logging.rb:28:in `tagged'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/tagged_logging.rb:71:in `tagged'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/logging.rb:46:in `tag_logger'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/logging.rb:22:in `block (2 levels) in <module:Logging>'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:118:in `instance_exec'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:118:in `block in run_callbacks'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:136:in `run_callbacks'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/execution.rb:38:in `perform_now'
/app/samvera/hyrax-webapp/lib/active_job_tenant.rb:38:in `block in perform_now'
/app/samvera/hyrax-webapp/lib/active_job_tenant.rb:57:in `block in switch'
/usr/local/bundle/gems/apartment-2.2.1/lib/apartment/adapters/abstract_adapter.rb:85:in `switch'
/usr/local/lib/ruby/2.7.0/forwardable.rb:235:in `switch'
/app/samvera/hyrax-webapp/lib/active_job_tenant.rb:56:in `switch'
/app/samvera/hyrax-webapp/lib/active_job_tenant.rb:37:in `perform_now'
/usr/local/bundle/gems/sentry-rails-5.16.1/lib/sentry/rails/active_job.rb:9:in `block in perform_now'
/usr/local/bundle/gems/sentry-rails-5.16.1/lib/sentry/rails/active_job.rb:35:in `block in record'
/usr/local/bundle/gems/sentry-ruby-5.16.1/lib/sentry/hub.rb:59:in `with_scope'
/usr/local/bundle/gems/sentry-ruby-5.16.1/lib/sentry-ruby.rb:371:in `with_scope'
/usr/local/bundle/gems/sentry-rails-5.16.1/lib/sentry/rails/active_job.rb:23:in `record'
/usr/local/bundle/gems/sentry-rails-5.16.1/lib/sentry/rails/active_job.rb:8:in `perform_now'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/execution.rb:24:in `block in execute'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:109:in `block in run_callbacks'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/railtie.rb:28:in `block (4 levels) in <class:Railtie>'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/execution_wrapper.rb:90:in `wrap'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/reloader.rb:73:in `block in wrap'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/execution_wrapper.rb:86:in `wrap'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/reloader.rb:72:in `wrap'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/railtie.rb:27:in `block (3 levels) in <class:Railtie>'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:118:in `instance_exec'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:118:in `block in run_callbacks'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:136:in `run_callbacks'
/usr/local/bundle/gems/activejob-<IP_ADDRESS>/lib/active_job/execution.rb:22:in `execute'
/usr/local/bundle/gems/good_job-2.99.0/lib/models/good_job/execution.rb:351:in `block (2 levels) in execute'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:168:in `block in instrument'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:168:in `instrument'
/usr/local/bundle/gems/good_job-2.99.0/lib/models/good_job/execution.rb:350:in `block in execute'
/usr/local/bundle/gems/good_job-2.99.0/lib/good_job/current_thread.rb:84:in `within'
/usr/local/bundle/gems/good_job-2.99.0/lib/models/good_job/execution.rb:345:in `execute'
/usr/local/bundle/gems/good_job-2.99.0/lib/models/good_job/execution.rb:246:in `perform'
/usr/local/bundle/gems/good_job-2.99.0/lib/models/good_job/execution.rb:162:in `block in perform_with_advisory_lock'
/usr/local/bundle/gems/good_job-2.99.0/lib/models/good_job/lockable.rb:163:in `block in with_advisory_lock'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/scoping/default.rb:34:in `block in unscoped'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:281:in `scoping'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/scoping/default.rb:34:in `unscoped'
/usr/local/bundle/gems/good_job-2.99.0/lib/models/good_job/lockable.rb:163:in `with_advisory_lock'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/delegation.rb:97:in `block in with_advisory_lock'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:281:in `scoping'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/delegation.rb:97:in `with_advisory_lock'
/usr/local/bundle/gems/good_job-2.99.0/lib/models/good_job/execution.rb:157:in `perform_with_advisory_lock'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/delegation.rb:97:in `block in perform_with_advisory_lock'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:281:in `scoping'
/usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/delegation.rb:97:in `perform_with_advisory_lock'
/usr/local/bundle/gems/good_job-2.99.0/lib/good_job/job_performer.rb:27:in `next'
/usr/local/bundle/gems/good_job-2.99.0/lib/good_job/scheduler.rb:270:in `block (2 levels) in create_task'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/execution_wrapper.rb:90:in `wrap'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/reloader.rb:73:in `block in wrap'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/execution_wrapper.rb:90:in `wrap'
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/reloader.rb:72:in `wrap'
/usr/local/bundle/gems/good_job-2.99.0/lib/good_job/scheduler.rb:269:in `block in create_task'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/safe_task_executor.rb:24:in `block in execute'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `block in synchronize'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `synchronize'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `synchronize'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/safe_task_executor.rb:22:in `execute'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/ivar.rb:170:in `safe_execute'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/scheduled_task.rb:298:in `process_task'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/timer_set.rb:165:in `block (2 levels) in process_tasks'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:352:in `run_task'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:343:in `block (3 levels) in create_worker'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:334:in `loop'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:334:in `block (2 levels) in create_worker'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:333:in `catch'
/usr/local/bundle/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:333:in `block in create_worker'

@kirkkwang locally, does this work not have a thumbnail too, from the works index page?

@ShanaLMoore correct, because a thumbnail is a derivative and the create derivative job didn't work correctly

Is this still an issue?

I tested with my own 6 page PDF.
https://adl.s2.adventistdigitallibrary.org/concern/generic_works/538a6bcf-e2b7-429e-b15a-f19530a9a7d9?locale=en
BUGS:
The splitting worked, but we have double the number of child works showing in the items list. On Production we usually only see the child works with page numbers attached. However, on staging, there are a string of JPEGs in the item list.
All child works are showing in the UV, so the work is duplicated in the UV.

@KatharineV Would you mind if we create a separate issue for the duplicate children? It seems like the original issue is solved.

That makes sense

From: Shana Moore @.>
Sent: Thursday, September 19, 2024 4:20 PM
To: scientist-softserv/adventist_knapsack @.>
Cc: Katharine Van Arsdale @.>; Mention @.>
Subject: Re: [scientist-softserv/adventist_knapsack] Undefined method 'split' for nil class (Issue #145)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@KatharineVhttps://github.com/KatharineV Would you mind if we create a separate issue for the duplicate children? It seems like the original issue is solved.
—
Reply to this email directly, view it on GitHubhttps://github.com/scientist-softserv/adventist_knapsack/issues/145#issuecomment-2362102415, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4FYSKCEXZ3ZQYQLNUKIQC3ZXMWYDAVCNFSM6AAAAABGH34FQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGEYDENBRGU.
You are receiving this because you were mentioned.Message ID: @.***>

Also, how would you prioritize it? A must solve before cutover or can it wait? @KatharineV

Great question. It's medium-high priority because the duplication of the work in the UV is illogical and will drive our users crazy, not to mention it will be very unweildy with our longer works. We have thousand page PDFs sometimes, and we want to rely on the UV as our primary viewer (although we could turn it off long enough to get the 80,000+ periodicals imported from the OAI feed).
Did this issue not happen when you folks were testing? Am I the first one to see it? If so, is it possible that I'm doing something that is causing the duplication of child works and in the UV??? Eek!

From: Shana Moore @.>
Sent: Thursday, September 19, 2024 4:23 PM
To: scientist-softserv/adventist_knapsack @.>
Cc: Katharine Van Arsdale @.>; Mention @.>
Subject: Re: [scientist-softserv/adventist_knapsack] Undefined method 'split' for nil class (Issue #145)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Also, how would you prioritize it? A must solve before cutover or can it wait? @KatharineVhttps://github.com/KatharineV
—
Reply to this email directly, view it on GitHubhttps://github.com/scientist-softserv/adventist_knapsack/issues/145#issuecomment-2362106728, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4FYSKCV3VP27IRSWPK53LLZXMXCPAVCNFSM6AAAAABGH34FQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGEYDMNZSHA.
You are receiving this because you were mentioned.Message ID: @.***>

@KatharineV No, there is a bug reported in Hyrax so it's probably not just your application that it's happening to.


[Cherry-pick to 4.15] Move Dotnet generators from Samples to "generators" - VSIX - Empty Bot (#6053)

#minor

Add VSIX Empty bot

Add launchSettings.json file

Pull Request Test Coverage Report for Build 291196

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 78.66%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs
2
90.91%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs
3
90.91%

/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs
3
89.62%

Totals

Change from base Build 289740:
-0.02%

Covered Lines:
24859

Relevant Lines:
31603

💛  - Coveralls


[Event Request] Table 37 Sales Line - OnValidate "Qty. to Ship" - OnValidateQtyToShipOnAfterCheckQuantity

Please add an Event OnValidateQtyToShipOnAfterCheckQuantity in OnValidate "Qty. to Ship" in Table 37 Sales Line
[Event Request] Table 37 - Sales Line - OnValidate "Qty. to Ship"
field(18; "Qty. to Ship"; Decimal)
{
    AccessByPermission = TableData "Sales Shipment Header" = R;
    Caption = 'Qty. to Ship';
    DecimalPlaces = 0 : 5;

    trigger OnValidate()
    var
        ItemLedgEntry: Record "Item Ledger Entry";
        IsHandled: Boolean;
    begin
        "Qty. to Ship" := UOMMgt.RoundAndValidateQty("Qty. to Ship", "Qty. Rounding Precision", FieldCaption("Qty. to Ship"));

        GetLocation("Location Code");
        ...
                Error(Text008, "Outstanding Qty. (Base)");
        end;

        OnValidateQtyToShipOnAfterCheckQuantity(Rec, CurrFieldNo); // <-- NEW EVENT

        if (CurrFieldNo <> 0) and (Type = Type::Item) and ("Qty. to Ship" < 0) then
            CheckApplFromItemLedgEntry(ItemLedgEntry);

        UpdateQtyToAsmFromSalesLineQtyToShip();
    end;
}

[IntegrationEvent(false, false)]
local procedure OnValidateQtyToShipOnAfterCheckQuantity(var SalesLine: Record "Sales Line"; CurrFieldNo: Integer)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47021.


Segmentation fault: 11

run:
./dain-ncnn-vulkan -0 ~/0.png -1 ~/1.png -o ~/test.png

but get:
[0 Apple M1]  queueC=0[1]  queueG=0[1]  queueT=0[1]
[0 Apple M1]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 Apple M1]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[0 Apple M1]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1
Segmentation fault: 11

platfrom:

MacBook Air M1 with 8G RAM
macOS 12.5 (21G72)

model version:

20220728

I'm getting this as well. Release 20210210 works and 20220728 always segfaults.
This seems to happen independent of the command line parameters, so long as any kind of frame interpolation is attempted it fails before the first frame.
I've run dain-ncnn-vulkan in my debugger,  it segfaults inside NCNN:

It looks like ncnn::create_layer() returns nullptr because it has no layer_creator for layer no. 27 (Reshape). Both layer_registry and layer_registry_avx have other layer_creators, but are empty on index 27.
(Tested on Gentoo Linux AMD64, Intel Xeon v1 w/AVX and NVidia RTX 3090 w/Vulkan Compute and CUDA 11 working)

I looked a bit further and was able to make it work.

Looks like dain-ncnn-vulkan explicitly sets NCNN's WITH_LAYER-reshape to OFF. Turned it ON gets rid of the nullptr and dain-ncnn-vulkan works again!

I also encountered the same problem. Can anyone tell me how to solve it?
[0 AMD Radeon RX 6750 XT]  queueC=1[2]  queueG=0[1]  queueT=2[2]
[0 AMD Radeon RX 6750 XT]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 AMD Radeon RX 6750 XT]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[0 AMD Radeon RX 6750 XT]  subgroup=64  basic=1  vote=1  ballot=1  shuffle=1

Looks like dain-ncnn-vulkan explicitly sets NCNN's WITH_LAYER-reshape to OFF. Turned it ON gets rid of the nullptr and dain-ncnn-vulkan works again!

Thank you very much! That solved the problem for me, too! (Ubuntu 22.04)

I looked a bit further and was able to make it work.

Looks like dain-ncnn-vulkan explicitly sets NCNN's WITH_LAYER-reshape to OFF. Turned it ON gets rid of the nullptr and dain-ncnn-vulkan works again!

thanks very much for your solution, but i'm like a coding noob and don't know exactly how to turn that WITH_LAYER-reshape on, if you or anyone could help me out i would be eternally grateful.

thanks very much for your solution, but i'm like a coding noob and don't know exactly how to turn that WITH_LAYER-reshape on, if you or anyone could help me out i would be eternally grateful.

Modify the src/CMakeList.txt file before compiling. It's already in there, just change the OFF to ON. But you must compile it from source. At least for Linux, this bug also crashes the prebuilt version.


Marvel example: Home code cleaning

In marvel example: reorganise home screen code and separate provider, model and UI in deferent files which make it more readable.

Hello and thanks!
I gave a quick glance at the changes and I don't agree with them.
I am against splitting files by kind, and as such I am against something like "providers.dart" or "models.dart".
I'm open to alternative ways to split home.dart though – just not this one.
But in general, I'd say there's nothing wrong with home.dart as it is. Related things should be together.

Hello again!
I'll close this PR as explained previously.
Your work is very appreciated though!


Update logos for Scribble + Input

Boy I did really not go back around and update a couple of the submissions, aye? 😅
Thanks


Provide project UUID in the user UI if not an admin

ISSUE TYPE

Enhancement Request

COMPONENT NAME
UI
CLOUDSTACK VERSION
GA
CONFIGURATION
http://qa.cloudstack.cloud:8080
SUMMARY
In case a user is not an admin, how will he/she find out in the UI the project ID? maybe display aside the name in the View dropdown.
Workaround
Use Developer Tools (F12) in browser to sneak for the UUID in the dropdown either an API tool like Cloudmonkey.

Hi @synergiator sorry if I didn't understand properly, but as a user I am able to see a project's UUID by clicking on it (Projects -> click on the project -> See ID at the left) - can you explain further?

never mind, need to double check. thx.

Appears a non-issue, thanks for reporting @synergiator pl re-open if you're able to reproduce the issue.


Add Smarter handling for Recipes within the alloy forge

yeet

Should be pretty close to done

Now it is done.


Connecting to sidecar fails due to CORS

Describe the bug
Calling https://testnet-explorer.blockstack.org/transactions
results in
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://sidecar.staging.blockstack.xyz/sidecar/v1/tx?type%5B…type%5B%5D=contract_call&type%5B%5D=token_transfer&limit=200. (Reason: CORS header 'Access-Control-Allow-Origin' missing).

This sometimes happens when the node/sidecar has stalled or failed, and has yet to be reset. I am going to close this out now as I have not been able to recreate this issue. If it persists, please feel free to reopen this ticket.


Does not work with structured arrays

.npy files can contain structured arrays, as described here, fail to open with error:
Uncaught SyntaxError: Unexpected token ( in JSON at position 28

Example, in python create the structured array:
np.save('test/out.npy', np.array([('Rex', 9, 81.0), ('Fido', 3, 27.0)],
             dtype=[('name', 'U10'), ('age', 'i4'), ('weight', 'f4')]))

Serve the out.npy file:
cd test
npx serve

Try to load that out.npy file:
> np.load("http://localhost:3000/out.npy")
Promise {
  <pending>,
  [Symbol(async_id_symbol)]: 4454,
  [Symbol(trigger_async_id_symbol)]: 5
}
> Uncaught SyntaxError: Unexpected token ( in JSON at position 28

Here is a rough idea of how to parse a structured array. It changes things a bit with the library, but this stand-alone example worked with a structured array that I was working with. Maybe this will be helpful for others.

const dtypes = {
  u1: {
    bytesPerElement: Uint8Array.BYTES_PER_ELEMENT,
    dvFnName: 'getUint8'
  },
  u2: {
    bytesPerElement: Uint16Array.BYTES_PER_ELEMENT,
    dvFnName: 'getUint16'
  },
  i1: {
    bytesPerElement: Int8Array.BYTES_PER_ELEMENT,
    dvFnName: 'getInt8'
  },
  i2: {
    bytesPerElement: Int16Array.BYTES_PER_ELEMENT,
    dvFnName: 'getInt16'
  },
  u4: {
    bytesPerElement: Int32Array.BYTES_PER_ELEMENT,
    dvFnName: 'getInt32'
  },
  i4: {
    bytesPerElement: Int32Array.BYTES_PER_ELEMENT,
    dvFnName: 'getInt32'
  },
  u8: {
    bytesPerElement: BigUint64Array.BYTES_PER_ELEMENT,
    dvFnName: 'getBigUint64'
  },
  i8: {
    bytesPerElement: BigInt64Array.BYTES_PER_ELEMENT,
    dvFnName: 'getBigInt64'
  },
  f4: {
    bytesPerElement: Float32Array.BYTES_PER_ELEMENT,
    dvFnName: 'getFloat32'
  },
  f8: {
    bytesPerElement: Float64Array.BYTES_PER_ELEMENT,
    dvFnName: 'getFloat64'
  },
};

function parse(arrayBufferContents) {
  const dv = new DataView(arrayBufferContents);

  const headerLength = dv.getUint16(8, true);
  const offsetBytes = 10 + headerLength;

  const hcontents = new TextDecoder("utf-8").decode(
    new Uint8Array(arrayBufferContents.slice(10, 10 + headerLength))
  );

  const [, descr, fortranOrder, shape] = hcontents.match(
    /{'descr': (.*), 'fortran_order': (.*), 'shape': (.*), }/
  );

  const columns = [...descr.matchAll(/\('([^']+)', '([\|<>])([^']+)'\)/g)].map(
    ([, columnName, endianess, dtype]) => ({
      columnName,
      littleEndian: endianess === "<",
      bytesPerElement: dtypes[dtype].bytesPerElement,
      dvFn: (...args) => dv[dtypes[dtype].dvFnName](...args),
    })
  );

  const [, numRows] = shape.match(/\((\d+),\)/);

  const stride = columns
    .map((c) => c.bytesPerElement)
    .reduce((sum, numBytes) => sum + numBytes, 0);

  const data = [];
  let i, c, offset, dataIdx, row;
  const numColumns = columns.length;
  for (i = offsetBytes; i < numRows; i++) {
    offset = 0;
    row = {};
    dataIdx = i * stride;
    for (c = 0; c < numColumns; c++) {
      row[columns[c].columnName] = columns[c].dvFn(dataIdx + offset, columns[c].littleEndian);
      offset += columns[c].bytesPerElement;
    }
    data.push(row);
  }

  return data;
}

Wow thank you for the thoughtful comments @jeffpeck10x!! Would you be interested in turning this into a PR? Otherwise I'm happy to incorporate these suggestions in my next dev push :)

Thanks @j6k4m8 . I don't think I have the time to generalize this into a more complete approach. I did end up taking this a little farther, although ended up ultimately using Apache Arrow for my use-case.  That said, here is some helpful code to get this started.
The following function should reliably fetch columns and numRow from the header:
function parseHeaderContents(hcontents) {
  const [, descr, fortranOrder, shape] = hcontents.match(
    /{'descr': (.*), 'fortran_order': (.*), 'shape': (.*), }/
  );

  let offset = 0;
  const columns = [...descr.matchAll(/\('([^']+)', '([\|<>])([^']+)'\)/g)].map(
    ([, columnName, endianess, dtype]) => {
      const littleEndian = endianess === "<";
      const ret = {
        columnName,
        dvFnName: dtypes[dtype].dvFnName,
        TypedArray: dtypes[dtype].TypedArray,
      };
      offset += dtypes[dtype].bytesPerElement;
      return ret;
    }
  );

  const [, numRows] = shape.match(/\((\d+),\)/);

  return { columns, numRows };
}

I ended up writing the following parse function to get at the data when I was experimenting:
function parse(arrayBufferContents) {
  const dv = new DataView(arrayBufferContents);

  const headerLength = dv.getUint16(8, true);
  const offsetBytes = 10 + headerLength;

  const hcontents = new TextDecoder("utf-8").decode(
    new Uint8Array(arrayBufferContents.slice(10, 10 + headerLength))
  );

  const { columns, numRows } = parseHeaderContents(hcontents);
  const columnNames = columns.map((c) => c.columnName);
  const offsets = columns
    .map((c) => c.TypedArray.BYTES_PER_ELEMENT)
    .reduce((arr, v, i) => [...arr, v + arr[i]], [0]);
  const stride = offsets.pop();
  const dvFnNames = columns.map((c) => c.dvFnName);
  const dataViews = offsets.map(
    (offset) => new DataView(arrayBufferContents, offsetBytes + offset)
  );
  const dataViewGetters = dataViews.map((dv, i) => dv[dvFnNames[i]].bind(dv));
  const data = columnNames.reduce(
    (obj, columnName, i) => ({
      ...obj,
      [columnName]: new columns[i].TypedArray(numRows),
    }),
    {}
  );

  for (let j = 0; j < columnNames.length; j++) {
    const columnName = columnNames[j];
    const getter = dataViewGetters[j];
    const column = data[columnName];

    for (let i = 0; i < numRows; i++) {
      column[i] = getter(i * stride, true);
    }
  }

  return data;
}

I think there are ideas from that which can be used to generalize the approach.

I know this all goes in a slightly different direction than your library, although using your library as the base gave me a really good headstart, just to even realize that I can use DataViews and offsets, and where to find the metadata in the headers. So, if any of this helps to improve the versatility of your library, great! And full circle. Don't feel like any pressure to do this though. In my particular use-case, as mentioned, I am all set with Apache Arrow IPC (ultimately needed to send this data between two processes, so more suited anyway).


Fix compilation on latest nightly

core::ptr::invalid_mut from the strict_provenance nightly feature seems to have been silently renamed to core::ptr::without_provenance_mut breaking vek on the latest nightly toolchain.

Thanks!


DictParameter fails when containing empty lists

Related to #1657, #1780
The following error occurs at the end of the run when running a task with a DictParameter whose default is a (key -> empty list) pair or a (key -> empty list).
Uncaught exception in luigi
Traceback (most recent call last):
  File "luigi/retcodes.py", line 74, in run_with_retcodes
    worker = luigi.interface._run(argv)['worker']
  File "luigi/interface.py", line 238, in _run
    return _schedule_and_run([cp.get_task_obj()], worker_scheduler_factory)
  File "luigi/interface.py", line 198, in _schedule_and_run
    logger.info(execution_summary.summary(worker))
  File "luigi/execution_summary.py", line 418, in summary
    return _summary_wrap(_summary_format(_summary_dict(worker), worker))
  File "luigi/execution_summary.py", line 356, in _summary_format
    str_output += '{0}\n'.format(_get_str(group_tasks[status], status in _PENDING_SUB_STATUSES))
  File "luigi/execution_summary.py", line 147, in _get_str
    params = _get_set_of_params(tasks)
  File "luigi/execution_summary.py", line 190, in _get_set_of_params
    params[param] = {getattr(task, param[0]) for task in tasks}
  File "luigi/execution_summary.py", line 190, in <setcomp>
    params[param] = {getattr(task, param[0]) for task in tasks}
  File "luigi/parameter.py", line 793, in __hash__
    self.__hash = functools.reduce(operator.xor, hashes, 0)
TypeError: unhashable type: 'list'

The following two tasks will raise an error at the end of the run, even when completing successfully:
class TaskA(luigi.Task):
    dict_a = luigi.DictParameter(default = {"a": []})

class TaskB(luigi.Task):
    dict_b = luigi.DictParameter(default = {"b": [""]})

However, a non-empty list inside the default parameter prevents the error from happening:
class TaskC(luigi.Task):
    dict_c = luigi.DictParameter(default = {"c": ["c"]})

As will adding any other item to the dictionary, including a second empty list:
class TaskD(luigi.Task):
    dict_d = luigi.DictParameter(default = {"d": [], "e": []})

I think this is related to the fact that ListParameters are converted to tuples (#859, #1614) so they are immutable. The list inside the DictParameter isn't treated as a ListParameter before running through FrozenOrderedDict, so it breaks. However, I'm not sure why it doesn't break with more than one item in the dict.

Oh, I didn't realize you could pass lists as keys (arbitrary json stuff, documentation says). Perhaps the normalize method need to do some "recursive freezing". Note that the FrozenOrderedDict is from luigi, so I wouldn't be surprised if it has some weird unexpected way to calculate a hash (maybe it explains why it doesn't break with more than one item in the dict)
By the way, if you happen to have time to fix the code. Please also make FrozenOrderedDict and DictParamEncoder _private. :)

@sguermond, hi again. We just merged a patch that potentially could solve this issue. Can you try and see if the issue is resolved for you now?

@sguermond Any update here? If the above patch resolved this, I'll close this issue. Thanks

We close for now to decrease the number of open issues. Feel free to re-open this at will if you still can reproduce this.


sublime4: 4107 -> 4113, sublime4-dev: 4106 -> 4112

Motivation for this change
Bump versions
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 130308 at 63e74d69 run on aarch64-linux 1

2 packages built successfully:

sublime4
sublime4-dev

anyone?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/563

Result of nixpkgs-review pr 130308 run on x86_64-linux 1

2 packages built:

sublime4
sublime4-dev

https://i.imgur.com/t675ojt.png


entityremovedhook

Does not appear to return an Entity.
If I use attackhook, with the code:
clientMessage("The Entity Type ID IS: " + Entity.getEntityTypeId(entity))
I get a message that show the ID number of the device used.
If I then use the same clientMessage while using entityRemovedHook, I only see a 0 returned.

Use this code:
function attackHook(attacker, victim) {
clientMessage("Victim's EntityType ID:" + Entity.getEntityTypeId(victim));
}

@KairusDarkSeeker thanks for that.  That is basically the code I am using.  If you use an egg to HIT an enemy, It does not appear to work (at least in the BL 1.9.10 used with 0.11).  I will re-try this with 0.12 when I get a moment to...I worked around this for now...although I would still love to get this working with an egg.  This was someone else's MOD, that I thought was cool...kind of Pokemonish...toss an egg at a MOB, when the egg gets detected as destroyed, if the egg occupys the same space as a MOB, a spawn egg is dropped.  Really creative idea!  For now, I am using UltraPeach's mob capsule mod (I updated it for 0.11+).  Trying to see if Ultrapeach wants the code...or if I can push it public.  Anyway, thanks again for the help!

oh I forgot if it returns 0 means the sytem is buggy

@KairusDarkSeeker okay, thanks.


Fixing github issue1

Will respect environment.

Thanks for this PR!
I adopted the idea, made it pass stylechecks and added a testcase, see https://github.com/ad2games/rails_migrate_mutex/commit/95cddaea0390b1d85014e512632b829a9c54880c
It's also released as version 1.2.0.


OSD-24208 (Part 2): Add official ARM support to the curl probe

What does this PR do?
Note: this PR will appear to contain all of the commits from #252 until that PR is merged. Consider reviewing that one first.
Using the cpu.Architecture type added in #250, this PR adds support for ARM-based curl probe instances.
Also fixes OSD-24415 using AMI IDs from this build.
Checklist

[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have made corresponding change to the default configuration files
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have tested the functionality against gcp / aws, it doesn't cause any regression
[ ] I have added execution results to the PR's readme

Reviewer's Checklist

[ ] (This needs to be done after technical review) I've run the branch on my local, verified that the functionality is ok

How to test this PR locally / Special Instructions

Logs

/test all

Codecov Report
Attention: Patch coverage is 5.06329% with 75 lines in your changes missing coverage. Please review.

Project coverage is 31.82%. Comparing base (990f9fa) to head (9b83dc3).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   32.77%   31.82%   -0.96%
==========================================
  Files          13       13
  Lines        1144     1191      +47
==========================================
+ Hits          375      379       +4
- Misses        751      794      +43
  Partials       18       18

Files
Coverage Δ

pkg/probes/legacy/legacy.go
89.65% <100.00%> (+0.36%)
:arrow_up:

pkg/verifier/package_verifier.go
0.00% <ø> (ø)

pkg/probes/curl/curl_json.go
75.60% <50.00%> (-0.34%)
:arrow_down:

pkg/verifier/aws/aws_verifier.go
25.26% <0.00%> (-1.41%)
:arrow_down:

pkg/verifier/aws/entry_point.go
0.00% <0.00%> (ø)

/test all


Fix array slicing indices on 3-dim transform

x[0] was being used as the slicing index on all 3 dimensions when slicing a 3d array.

LGTM :-)  I'm gonna merge and we can enhance other parts if needed.


Can't auth with username containing @

Repro steps:

Try to login to mongo with connections string like mongodb://username@example.com:password@localhost/ or mongodb://username%40example.com:password@localhost/
Get error

Action: cosmosDB.attachDatabaseAccount
Error type: Error
Error Message: Username containing an unescaped at-sign
Version: 0.11.0
OS: linux
Product: VSCodium
Product Version: 1.38.1
Language: en

Call Stack
extension.bundle.js:253:234753
l extension.bundle.js:253:240574
QueryReqWrap.callback extension.bundle.js:253:242137
QueryReqWrap.onresolve [as oncomplete] dns.js:199:10

Hi @SkeLLLA
Thanks for reporting.  I will investigate what we can do to automate this for users, but the current workaround is to escape @ signs with a \ (backslash.  For example:
mongodb://username\@example.com:password\@localhost

I didn't remember if I tried escaping, so I can't be sure that it works or not.
However handling this case should be pretty simple:

Find the latest index of @.
Everything before that index (username and password) should be escaped, and after - that the host part.


Fixed release process for the nodified UI

Will probably just use https://github.com/maxogden/electron-packager in
the future as release.sh reinvents the wheel. It's extra work to use
release.sh and we don't even utilize electron's cross-platform
capabilities as well (i.e. our executable doesn't have an icon as well
as other features)

Once electron-packager has been integrated electron-builder can be used to create installers to make a more streamline system https://github.com/loopline-systems/electron-builder

Yush :D

@lukechampine

merge conflicts?

This is being closed in favor of #115


error

Error while creating build definition: The pipeline is not valid. A task is missing. The pipeline references a task called '4fa3aac0-0020-4832-9089-9979c9dd3e69'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 0.*, job 'Phase_1', step 'Bower_3'.)

@maryamfarajidev please install the required extension from marketplace.
Please refer to #626 if you have created a new organization.


Failed to install on OS X 10.12.6

Wasn't able to install the latest version with opam. Was able to install 1.5.0.
> opam install cppo

The following actions will be performed:
  ∗  install cppo 1.6.0

=-=- Gathering sources =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[cppo] Archive in cache

=-=- Processing actions -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[ERROR] The compilation of cppo failed at "jbuilder build -p cppo -j 4".

#=== ERROR while installing cppo.1.6.0 ========================================#
# opam-version 1.2.2
# os           darwin
# command      jbuilder build -p cppo -j 4
# path         /Users/ben/.opam/system/build/cppo.1.6.0
# compiler     system (4.05.0)
# exit-code    127
# env-file     /Users/ben/.opam/system/build/cppo.1.6.0/cppo-9545-6d07ae.env
# stdout-file  /Users/ben/.opam/system/build/cppo.1.6.0/cppo-9545-6d07ae.out
# stderr-file  /Users/ben/.opam/system/build/cppo.1.6.0/cppo-9545-6d07ae.err

=-=- Error report -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
The following actions failed
  ∗  install cppo 1.6.0
No changes have been performed

Hopefully there's a useful error message in /Users/ben/.opam/system/build/easy-format.1.3.0/easy-format-9587-6d07ae.err. Can you see something in there?

The file exists but it's zero bytes.
/Users/ben/.opam/system/build/easy-format.1.3.0/easy-format-9587-6d07ae.info contains this:
> cat easy-format-9587-6d07ae.info
# opam-version         1.2.2
# os                   darwin
# command              jbuilder build -p easy-format -j 4
# path                 /Users/ben/.opam/system/build/easy-format.1.3.0
# compiler             system (4.05.0)
# env-file             /Users/ben/.opam/system/build/easy-format.1.3.0/easy-format-9733-6d07ae.env
# stdout-file          /Users/ben/.opam/system/build/easy-format.1.3.0/easy-format-9733-6d07ae.out
# stderr-file          /Users/ben/.opam/system/build/easy-format.1.3.0/easy-format-9733-6d07ae.err

Same for the cppo and biniou directories

I don't know, but I would check jbuilder because it's a recent dependency. Does the command jbuilder exist at all on your system?

jbuilder shows up in opam list but the command is not available via the command line. Should it be available via the command line?
> opam list
# Installed packages for system:
base-bigarray        base  Bigarray library distributed with the OCaml compiler
base-bytes           base  Bytes library distributed with the OCaml compiler
base-threads         base  Threads library distributed with the OCaml compiler
base-unix            base  Unix library distributed with the OCaml compiler
conf-m4                 1  Virtual package relying on m4
conf-which              1  Virtual package relying on which
cppo                1.5.0  Equivalent of the C preprocessor for OCaml programs
easy-format         1.2.0  High-level and functional interface to the Format module of the OCaml standard librar
jbuilder       1.0+beta12  Fast, portable and opinionated build system
ocamlbuild         0.11.0  OCamlbuild is a build system with builtin rules to easily build most OCaml projects.
ocamlfind           1.7.3  A library manager for OCaml

In your shell you should run ``eval opam config env ```, which will set some environment variables. Typically opam would give you such warning, but I'm not sure in your case.

which jbuilder should definitely show you the path to jbuilder, yes.

As you suspected it turns out this is an opam issue.
I installed opam and then immediately tried to install your libraries.
Opam added an init script to my .bash_profile:
. /Users/ben/.opam/opam-init/init.sh > /dev/null 2> /dev/null || true
but the script wasn't run until I opened a new terminal window.
Sorry and thanks for the help!

Sure, no problem.

Now that I know jbuilder is expected to be in $PATH opam config exec opam install cppo did the job as well.


Russian LT/LTS: Updated time format in accordance with CLDR and www.timeandunits.com

Simple format change for Russian locale.

@Viktorminator @Oire any thoughts on this one?

@joelmheim, @ichernev, well, that might be true (and might be not). I.e., they say that it should be 7:48 instead of 07:48, for example? this makes sense. @socketpair, your thoughts please, also?

http://www.ifap.ru/library/gost/86012001.pdf
Но я там не нашёл ничего про нули...

В реальной жизни, нули не пишут.

I did not find description of that in standard. It seems (I'm not sure) in russian standard we have to use leading zero. But Сегодня в 08:00 looks too robotic for me. Eventually, I vote for (approve) this path.

Hi there!
If I understood right, behavior of calendar() method was changed - the function stops adding a leading zero.
This change was included into new version 2.20.0 that was a minor.
Of course, it don't break API interface. But the result of method execution is different to old version and it was not bugfix.
Is it a really minor change according to semver?

I think we generally consider locale changes 'bugfixes'. This, of course, is not perfect. If you have ideas how to independently version each locale file, let us now. (I'm not sure it's best to major-version Moment for each locale change.)


Wash package name

Description
Changed package name from Kony to VoltMX standards and bump minor version
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Doesn't work without internet

I'm using this plugin and it works perfectly with internet and GPS but when I turn off the internet it doesn't track the location. Any ideas? I'm trying on Android
Config:
desiredAccuracy: 10,
stationaryRadius: 0,
distanceFilter: 0,
interval: 1000,
debug: false,
stopOnTerminate: false,
startOnBoot: true
document.addEventListener('deviceready', onDeviceReady, false);
function onDeviceReady () {
var callbackFn = function(location) {
console.log('[js] BackgroundGeolocation callback:  ' + location.latitude + ',' + location.longitude);
};
    var failureFn = function(error) {console.log('BackgroundGeolocation error');};

backgroundGeolocation.start();

I believe if you want to do this with the existing code in the plugin you need to make use of syncUrl and syncThreshold - I've used these successfully so that without internet it will still store the locations, and then send them to the server when it can; as per the documentation. But if you're wanting to do something other than POST them to a server; this might not be what you're looking for.

Notice: this issue has been closed because it has been reported for branch 2.x or later. It could be already fixed in v3 or is not relevant anymore. You may reopen this issue if it has been closed in error.


compress still uses /uglifyjs when no -local

/uglifyjs does not seem to exist anymore, but the script still uses it, if not -local
Maybe remove it, or allow custom url to be passed in ?

Ah, I wasn't even aware that that file still existed. Attached patch removes it.


Remove unnecessary addition of derived models to effective type candidates

It turns out that code I put in to replace the isDerivedFrom checks in the prior implementation of getEffectiveType isn't needed. This is great because I was going back to it because I realized it should have been recursive, and to put a comment where code would need to change with property overrides but then I ended up deleting the code. :)
Also added an additional test with another level of inheritance and renamed another to match the naming of nearby tests.

Sigh, I knew this was too easy, there's another bug that made this part unnecessary against our tests accidentally, it seems. Working on better tests and another round. :(

Fixed in #779 (third time's a charm? 🤞)


Ignore errors generated by AsyncObjectPool.giveBack

Possible fix for #132.  We want to keep the original future result exactly intact, and ignore any errors from giveBack.  This could also be done with recoverWith but looks ugler (and less efficient) that way.  I haven't yet done extensive testing on this -- there should probably be a test case for use that causes a database error, and makes sure it can catch it on the way out.

Can you get a spec for this showing the bug?


Fix olympus session request error after skipping 2FA Upgrade

Related issue : #21301
Since last week of 05/2023, requests to : https://appstoreconnect.apple.com/olympus/v1/session are now rejected if account is not configured with 2FA.
Skipping this request avoid non 2FA account to get stuck without authentication.

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Non 2FA accounts can't use fastlane in CI since 2 weeks now.

Resolves #21301
Description

Comment the request to olympus/session after completing skip 2FA upgrade.

Publish the fix in my git then rebuild my CI docker image pointing fastlane gem to this git and make sure all is working as before.
Testing Steps

👍

Hmm, I was about to merge this since it is currently broken but it seems to throw my application into an infinite loop. I wonder what this olympus session was required for. I also noticed that the key exchange with the server looks completely different now (it does look like SRP but not sure if it is SRP-6a like someone mentioned in #21301), perhaps if that was fixed fetching this olympus session would also continue working properly

I've confirmed this is working on both Enterprise and non-Enterprise accounts using an old login that does NOT have 2FA enabled. It's unfortunate that using a username/password login is still required, but so far the App Store Connect API (which is the only thing that API keys can be used with) is extremely limited. For example, the API does not support renewing APNS certificates. Nor does it support Enterprise accounts at all.

Hmm, I was about to merge this since it is currently broken but it seems to throw my application into an infinite loop. I wonder what this olympus session was required for. I also noticed that the key exchange with the server looks completely different now (it does look like SRP but not sure if it is SRP-6a like someone mentioned in #21301), perhaps if that was fixed fetching this olympus session would also continue working properly

Hi,
This fix should impact only non-2FA accounts.
Even with a normal login through Apple website / skip 2FA upgrade , you can't get anymore an olympus session.
Check this post : https://github.com/fastlane/fastlane/issues/21301#issuecomment-1574912808

If found a particular usage of this function in https://github.com/fastlane/fastlane/blob/0495da3504f8506587161c5ffb468f9694e65635/spaceship/lib/spaceship/client.rb#L420 :
          # We use the olympus session to determine if the old session is still valid
          # As this will raise an exception if the old session has expired
          # If the old session is still valid, we don't have to do anything else in this method
          # that's why we return true

This is small : https://github.com/fastlane/fastlane/blob/0495da3504f8506587161c5ffb468f9694e65635/spaceship/lib/spaceship/client.rb#L573
# Get the `itctx` from the new (22nd May 2017) API endpoint "olympus"
# Update (29th March 2019) olympus migrates to new appstoreconnect API

    def fetch_olympus_session
      response = request(:get, "https://appstoreconnect.apple.com/olympus/v1/session")
      body = response.body
      if body
        body = JSON.parse(body) if body.kind_of?(String)
        user_map = body["user"]
        if user_map
          self.user_email = user_map["emailAddress"]
        end

        provider = body["provider"]
        if provider
          self.provider = Spaceship::Provider.new(provider_hash: provider)
          return true
        end
      end

      return false
    end

Maybe this line have impacts :
https://github.com/fastlane/fastlane/blob/0495da3504f8506587161c5ffb468f9694e65635/spaceship/lib/spaceship/client.rb#L585

re:

so far the App Store Connect API (which is the only thing that API keys can be used with) is extremely limited

I recommend to file feedback to Apple if you haven't already. You can reference these FBs:

FB9161884
FB7339579
FB8989082

Also wanted to add a note that we're using this branch currently to sidestep the ADC issues with the latest published version of Fastlane, and has been working great for us.

My team has been able to test this again, and it seems to be working now. Not sure what happened earlier. Anyway, given that there have been multiple confirmations that it is working, and I see several forks have been created, it probably makes the most sense to merge!


Add 'help lsp' command and write help.

At least one language server is required to use LSP plugin. Instructions for installing these servers are important, as LSP plugin cannot be used without them.
Currently, help explains the installation of language servers for Go and Python. For Python, the active fork pylsp is installed, with optional type checking and moderate settings.

Nice! Thanks for adding the documentation!

Thank you for adding LSP - the missing link - to Micro! Bonus points for unobtrusive UI.


.Net Script "machine.config" when installed, breaks all .net application

.Net Script "machine.config" when installed, breaks all .net application
Specifically breaks powershell.

See https://github.com/simeononsecurity/.NET-STIG-Script/issues/1


Make vscode svelte's style tag compatible when using useVitePreprocess instead of svelte-preprocess

Describe the problem
I'm currently using useVitePreprocess and it works wonderful. It's faster because of esbuild, you can use $aliases inside style tags and everything is awesome. Unused CSS also gets removed and classes contains the scoped random symbols. In fact, it produces the same CSS as svelte-preprocess.
The issue is... the vscode extension doesn't handle <style lang="postcss"> when using useVitePreprocess. It breaks on things like nesting.
I know useVitePreprocess is experimental, but can we get this working please?
Describe the proposed solution
useVitePreprocess able to work with .svelte files
Alternatives considered
I can use svelte-preprocess but it duplicates CSS in dev mode. Also.. why use another tool when we are already using vite?
Importance
would make my life easier
Additional Information
No response

sorry this belong to language-tools repo, didn't know!


Label should take the background in LabelStyle to compute the prefSize

Fix #5736. If the label smaller than the background, the background will stretch down do the label size.

This can't be merged, as it has tilemap stuff in it. Will do it manually (and in the other places it is needed).


Update lt.js

Typo fixes

Coverage remained the same at 69.022% when pulling c342a41a6739b12d42c0d8fb5d8822b7a18e7f63 on priithansen:patch-1 into fcda40f194e1af150fea73a336bf094e3a19a87b on chmln:master.

Thanks! :+1:


'save image' button dead on firefox?

in Quotable, when I hit "save image" either one of two things happens:

I get a dialogue telling me my quote doesn't fit and to reduce the font size
nothing

in safari (launched to check that I'm not nuts), #1 is still true (and works as expected), #2 opens a new window with the image.

Ah yikes, not sure when that bug came back. Electron runs Chromium, so I haven't been testing Firefox as rigorously as I should, but we've solved this issue before.

Oh ugh, SVG + Firefox + html2canvas don't play together. We use PNG assets on quotable/factlist for this reason. I should note that in the docs.

RE: the Safari issue, that's just what Safari does with data URIs, unfortunately. You can still save from that new tab.

Oh right, yes, I was pinging safari as the expected behavior.
On Thu, Jul 30, 2015 at 4:20 PM, Tyler Fisher<EMAIL_ADDRESS>wrote:

RE: the Safari issue, that's just what Safari does with data URIs,
unfortunately. You can still save from that new tab.
—
Reply to this email directly or view it on GitHub
https://github.com/nprapps/lunchbox/issues/54#issuecomment-126493377.

Closing in favor of #64


Unsupported or undefined Opauth strategy

Unsupported or undefined Opauth strategy
C:\wamp\www\googlel\lib\Opauth\Opauth.php on line 120
This the exact error When i try to implement the opauth example

Well: #112 is still an issue. You would have to patch it yourself probably.