[Bug] Version conflicts with the protobuf inside the pulsar client

Search before asking

[X] I searched in the issues and found nothing similar.

Version
Pulsar client & client admin 3.0.2
Minimal reproduce step
We have grpc application which is using protobuf 3.25.x, however when we build the proto files, the protobuf packed inside the pulsar client which is using an old version override our dependencies, causing issues in the grpc runtime envrionment, even if we tried to exclude from the gradle, it doesn't works, because it built inside the client jar directly
What did you expect to see?
The protobuf library inside the pulsar client shouldn't override our dependencies
What did you see instead?
It took priority to load the library from the pulsar client
Anything else?
We have a workaround to use pulsar-client-original & pulsar-client-admin-original client instead
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Try to use pulsar-client-all

<!-- https://mvnrepository.com/artifact/org.apache.pulsar/pulsar-client-all -->
<dependency>
    <groupId>org.apache.pulsar</groupId>
    <artifactId>pulsar-client-all</artifactId>
    <version>3.0.3</version>
</dependency>

instead of
<dependency>
    <groupId>org.apache.pulsar</groupId>
    <artifactId>pulsar-client</artifactId>
    <version>3.0.3</version>
</dependency>
<!-- https://mvnrepository.com/artifact/org.apache.pulsar/pulsar-client-admin -->
<dependency>
    <groupId>org.apache.pulsar</groupId>
    <artifactId>pulsar-client-admin</artifactId>
    <version>3.0.3</version>
</dependency>

pulsar-client-all will shade these deps.

pulsar-client-all has the same issue, the problem is the protobuf library inside the pulasr client is overriding our dependency, is it possible to decouple the protobuf from the client jar?

I believe that the unshaded dependency has the artifact Id pulsar-client-original. Use should be able to override the version of protobuf when that is used.

pulsar-client-all skipped shade protobuf-java
And protobuf-java introduced by pulsar-client-origin.
Maybe
    <dependency>
      <groupId>org.apache.pulsar</groupId>
      <artifactId>pulsar-client-original</artifactId>
      <version>3.0.3</version>
      <exclusions>
        <exclusion>
          <groupId>com.google.protobuf</groupId>
          <artifactId>protobuf-java</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
    <dependency>
      <groupId>org.apache.pulsar</groupId>
      <artifactId>pulsar-client-admin-original</artifactId>
      <version>3.0.3</version>
      <exclusions>
        <exclusion>
          <groupId>org.apache.pulsar</groupId>
          <artifactId>pulsar-client-original</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

can works

yes, that's what we are using now
we understand you shaded dependencies in the pulsar-client, if you rename the packages for the shaded dependencies, then it won't affects the end user, we can use our own version of the protobuf with the pulsar-client

yes, that's what we are using now we understand you shaded dependencies into the pulsar-client, if you move the shaded dependencies to under a shaded package, then it won't affects the end user, we can use our own version of the protobuf with the pulsar-client

This issue with protobuf in Pulsar client is similar to the problems with Avro (#9718, #13096, #21230) and Jackson (#6528) where you need to use pulsar-client-original dependency. I agree that this is not optimal.
Just a reminder that "we" and "you" are the same in an open source project. It's "we", the community, that can impact the development and improvements to Apache Pulsar. Contributions are welcome!
Subscribing to the dev mailing list and joining the #dev channel in Slack are ways to get connected with the Apache Pulsar community.

There's a slightly unrelated issue in Pulsar in upgrading the protobuf version that Pulsar uses internally between Pulsar and Bookkeeper. The version has to be the same in Pulsar and Bookkeeper currently. Dev mailing list thread is https://lists.apache.org/thread/s9g6w31vtwzgqf162hhlcr2nx3y68gv5 . It points to the Bookkeeper mailing list thread which contains more details.

Regarding contributions, I think that a useful first contribution would be to update the documentation for Pulsar Java client to include the information about the workarounds for using a custom version of protobuf.

I'm wondering why do we skipped shade protobuf-java in pulsar-client, pulsar-client-admin and pulsar-client-all?
Can we just shade it?

Regarding contributions, I think that a useful first contribution would be to update the documentation for Pulsar Java client to include the information about the workarounds for using a custom version of protobuf.

we will take some time to check the documentation, and might try to create some PRs later

I'm wondering why do we skipped shade protobuf-java in pulsar-client, pulsar-client-admin and pulsar-client-all? Can we just shade it? @lhotari

@dao-jun You can always try. :) I don't think that shading is a solution. The reason is that it's expected to work with protoc generated classes which extend com.google.protobuf.GeneratedMessageV3. If you shade protobuf, that would break.

slightly related to #19565 since that's making improvements in protobuf support.

From 3.0.0, com.google.protobuf:protobuf-java is included directly in pulsar-client-admin without relocation.
In my understanding, pulsar-client-admin is a java wrapper for pulsar RESTful api. What does protobuf-java in pulsar-client-admin used for?
~ download() {
  version=$1
  wget https://repo1.maven.org/maven2/org/apache/pulsar/pulsar-client-admin/${version}/pulsar-client-admin-${version}.jar
  unzip -tl pulsar-client-admin-${version}.jar | awk 'gsub(/\//,"/") < 3'
}

~ download 3.0.0
--2024-04-06 12:31:10--  https://repo1.maven.org/maven2/org/apache/pulsar/pulsar-client-admin/3.0.0/pulsar-client-admin-3.0.0.jar
Connecting to <IP_ADDRESS>:6152... connected.
Proxy request sent, awaiting response... 200 OK
Length: 25830684 (25M) [application/java-archive]
Saving to: ‘pulsar-client-admin-3.0.0.jar’

pulsar-client-admin-3.0.0.jar                           100%[=============================================================================================================================>]  24.63M  7.83MB/s    in 3.3s

2024-04-06 12:31:15 (7.38 MB/s) - ‘pulsar-client-admin-3.0.0.jar’ saved [25830684/25830684]

Archive:  pulsar-client-admin-3.0.0.jar
    testing: META-INF/                OK
    testing: META-INF/MANIFEST.MF     OK
    testing: META-INF/DEPENDENCIES    OK
    testing: META-INF/LICENSE         OK
    testing: META-INF/NOTICE          OK
    testing: org/                     OK
    testing: org/apache/              OK
    testing: META-INF/maven/          OK
    testing: findbugsExclude.xml      OK
    testing: io/                      OK
    testing: io/airlift/              OK
    testing: META-INF/services/       OK
    testing: META-INF/versions/       OK
    testing: META-INF/io.netty.versions.properties   OK
    testing: META-INF/native/         OK
    testing: META-INF/native-image/   OK
    testing: META-INF/native/libnetty_resolver_dns_native_macos_aarch_64.jnilib   OK
    testing: META-INF/native/libnetty_resolver_dns_native_macos_x86_64.jnilib   OK
    testing: META-INF/LICENSE.md      OK
    testing: META-INF/NOTICE.md       OK
    testing: META-INF/NOTICE.markdown   OK
    testing: META-INF/LICENSE.txt     OK
    testing: META-INF/NOTICE.txt      OK
    testing: lib/                     OK
    testing: lib/libcpu-affinity.so   OK
    testing: META-INF/nar/            OK
    testing: META-INF/native/libnetty_transport_native_io_uring_x86_64.so   OK
    testing: META-INF/native/libnetty_transport_native_io_uring_aarch_64.so   OK
    testing: com/                     OK
    testing: com/google/              OK
    testing: google/                  OK
    testing: google/protobuf/         OK
    testing: google/protobuf/any.proto   OK
    testing: google/protobuf/api.proto   OK
    testing: google/protobuf/descriptor.proto   OK
    testing: google/protobuf/duration.proto   OK
    testing: google/protobuf/empty.proto   OK
    testing: google/protobuf/field_mask.proto   OK
    testing: google/protobuf/source_context.proto   OK
    testing: google/protobuf/struct.proto   OK
    testing: google/protobuf/timestamp.proto   OK
    testing: google/protobuf/type.proto   OK
    testing: google/protobuf/wrappers.proto   OK
    testing: META-INF/native/libnetty_transport_native_epoll_x86_64.so   OK
    testing: META-INF/license/        OK
    testing: META-INF/license/LICENSE.aix-netbsd.txt   OK
    testing: META-INF/license/LICENSE.boringssl.txt   OK
    testing: META-INF/license/LICENSE.mvn-wrapper.txt   OK
    testing: META-INF/license/LICENSE.tomcat-native.txt   OK
    testing: META-INF/native/libnetty_tcnative_linux_x86_64.so   OK
    testing: META-INF/native/libnetty_tcnative_linux_aarch_64.so   OK
    testing: META-INF/native/libnetty_tcnative_osx_x86_64.jnilib   OK
    testing: META-INF/native/libnetty_tcnative_osx_aarch_64.jnilib   OK
    testing: META-INF/native/netty_tcnative_windows_x86_64.dll   OK
    testing: lib/libcirce-checksum.so   OK
    testing: com/scurrilous/          OK
    testing: digesterRules.xml        OK
    testing: properties.dtd           OK
    testing: PropertyList-1.0.dtd     OK
    testing: META-INF/services/org.apache.pulsar.shade.com.fasterxml.jackson.databind.Module   OK
    testing: META-INF/services/org.apache.pulsar.shade.org.glassfish.jersey.internal.inject.InjectionManagerFactory   OK
    testing: META-INF/services/org.apache.pulsar.shade.com.fasterxml.jackson.core.ObjectCodec   OK
    testing: META-INF/services/org.apache.pulsar.shade.org.glassfish.hk2.extension.ServiceLocatorGenerator   OK
    testing: META-INF/services/org.apache.pulsar.shade.javax.ws.rs.ext.MessageBodyWriter   OK
    testing: META-INF/services/org.apache.pulsar.shade.org.glassfish.jersey.internal.spi.AutoDiscoverable   OK
    testing: META-INF/services/com.scurrilous.circe.HashProvider   OK
    testing: META-INF/services/org.apache.pulsar.shade.javax.ws.rs.ext.MessageBodyReader   OK
    testing: META-INF/services/org.apache.pulsar.shade.com.fasterxml.jackson.core.JsonFactory   OK
    testing: META-INF/services/reactor.blockhound.integration.BlockHoundIntegration   OK
No errors detected in compressed data of pulsar-client-admin-3.0.0.jar.

@Shawyeok Because admin-api depends on client-api, some classes like Auth MessageId are defined in client-api.

@Shawyeok Because admin-api depends on client-api, some classes like Auth MessageId are defined in client-api.

It looks like pulsar-client-admin just depends on it and not using it.
On the client side, the only feature that depends on protobuf at runtime is ProtobufSchema. However, pulsar-client-admin does not provide related capabilities. Therefore, I think pulsar-client-admin can change to declare dependencies on protobuf in the pom.xml, similar to pulsar-client, instead of directly copying protobuf-related classes into the shaded jar.

@Shawyeok
you can try to remove client-api from admin-api and build it.

@Shawyeok Because admin-api depends on client-api, some classes like Auth MessageId are defined in client-api.

It looks like pulsar-client-admin just depends on it and not using it.
On the client side, the only feature that depends on protobuf at runtime is ProtobufSchema. However, pulsar-client-admin does not provide related capabilities. Therefore, I think pulsar-client-admin can change to declare dependencies on protobuf in the pom.xml, similar to pulsar-client, instead of directly copying protobuf-related classes into the shaded jar.

Thank you @Shawyeok , that's a correct observation, there are mistakes in how protobuf-java is included in the shaded clients. I'll look into resolving this problem while upgrading protobuf-java used by Pulsar to address CVE-2024-7254. Mailing list message is https://lists.apache.org/thread/73jk2mx4nj82kxwvwgcqz5m63scqcy2s. It should be possible to use Pulsar client with a client application provided protobuf-java version, as long as it's compatible at a very granular level. Since now we'll need to upgrade protobuf-java in Pulsar to 3.25.5, some client applications might break since protoc generated stubs are coupled to the version that they were generated with. It should be possible to allow the client application to use an older version (or a newer version in the future).

@Shawyeok Because admin-api depends on client-api, some classes like Auth MessageId are defined in client-api.

It looks like pulsar-client-admin just depends on it and not using it.
On the client side, the only feature that depends on protobuf at runtime is ProtobufSchema. However, pulsar-client-admin does not provide related capabilities. Therefore, I think pulsar-client-admin can change to declare dependencies on protobuf in the pom.xml, similar to pulsar-client, instead of directly copying protobuf-related classes into the shaded jar.

Thank you @Shawyeok , that's a correct observation, there are mistakes in how protobuf-java is included in the shaded clients. I'll look into resolving this problem while upgrading protobuf-java used by Pulsar to address CVE-2024-7254. Mailing list message is https://lists.apache.org/thread/73jk2mx4nj82kxwvwgcqz5m63scqcy2s. It should be possible to use Pulsar client with a client application provided protobuf-java version, as long as it's compatible at a very granular level. Since now we'll need to upgrade protobuf-java in Pulsar to 3.25.5, some client applications might break since protoc generated stubs are coupled to the version that they were generated with. It should be possible to allow the client application to use an older version (or a newer version in the future).

Thanks @lhotari , I noticed this issue remain unresolved in recent LTS 4.0.0 release (candidate-1), so I opened a PR https://github.com/apache/pulsar/pull/23468 to address this.


GenreRepository throws fatal error

Hey wtfzdotnet, thanks for this great API wrapper!
Currently I'm facing an issue with it. When I try to call the Genre Repository via
$repository = new \Tmdb\Repository\GenreRepository($client);
$genre      = $repository->getMovies(18);
it throws a fatal error: Call to undefined method Tmdb\Factory\GenreFactory::createMovie() in [...]\vendor\wtfzdotnet\php-tmdb-api\lib\Tmdb\Factory\AbstractFactory.php on line 130
Stacktrace excerpt:
6	0.0950	2030448	Tmdb\Repository\GenreRepository->getMovies( )	..\index.php:26
7	0.1290	2582448	Tmdb\Factory\AbstractFactory->createResultCollection( )
..\GenreRepository.php:67
Your help is greatly appreciated.
Thanks!

I'll have a look at this later tonight when I get home from work!

Could you check which version you are running by the way? :)

I'm using version 2.0.3

@webphax this has been fixed in a6a7783467086f1dfabafd0405ad0028ee36888b, waiting on feedback from Travis to release 2.0.4. Thanks for the report!

I released 2.0.4 which contains the fix, happy coding!

@wtfzdotnet, many thanks, works perfect!

Anytime! If you have any questions non bug related, feel free to post in the google+ community, or just contact me :)

Hi @wtfzdotnet, as the GenreRepository is working now, I'm facing another problem with it. When I try to load the genre model it returns the genre with id = 18 by default:
$genre_repository = new \Tmdb\Repository\GenreRepository($client); var_dump($genre_repository->load(878));
returns
object(Tmdb\Model\Genre)[52]   private 'id' => int 28   private 'name' => string 'Action' (length=6)
In this case it seems to work:
var_dump($genre_repository->getApi()->getGenre(878));
returns
array (size=2)   'id' => int 878   'name' => string 'Science Fiction' (length=15)
Thanks!

@webphax update to 2.0.5 and your problems will be gone :), can't believe these things are popping up right now. Hope it's a long haul forwards from now on!

@webphax make that 2.0.6, getting a bit too used being on hhvm I guess :P


Add support for whitespace control character.

This matches up with Shopify/liquid#746 to resolve issues Shopify/liquid#216, Shopify/liquid#215, Shopify/liquid#214, Shopify/liquid#194, Shopify/liquid#171, Shopify/liquid#162
This pull request is designed to be standalone and will pass all tests without its counterpart Shopify/liquid#746 however Shopify/liquid#746 requires this pull request and will be updated with this dependancy once merged.

ping @Shopify/liquid

This adds support for {{- and {%- syntax which will lstrip! and -}} and -%} which will rstrip!

Now matches up to Shopify/liquid#773

I'd love to avoid the cycle through the Ruby VM to call rstrip!/lstrip!.
Ideally we should parse white-space as a special token, then modify the token to be marked for render-skipping if {%- or -%} are encountered.

I see now that this would make it harder to match with Shopify/liquid#746 - alright, let's not overthink it. Thanks!

Yeah I would have liked to avoid it but the trade off isn't worth it at this stage. To keep the functions inline on both sides makes maintenance easier. Also as I'm pulling back the last token if needed it requires conversion from a ruby object then back again where as this approach keeps it clean and only a few lines

Makes sense and looks pretty good overall.

Alright we are passing again. Detection of the whitespace control characters has now been pushed back in to the tokenizer so there is no need to push and pop any existing values.

really nice work Mike.

tobi
CEO Shopify

On Thu, Jul 7, 2016 at 8:18 AM, Mike Angell<EMAIL_ADDRESS>wrote:

Alright we are passing again. Detection of the whitespace control
characters has now been pushed back in to the tokenizer so there is no need
to push and pop any existing values.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Shopify/liquid-c/pull/30#issuecomment-231061305, or mute
the thread
https://github.com/notifications/unsubscribe/AAABW7m4s55YijtSESQGVQYhVRGXmrgdks5qTO6AgaJpZM4I_Yjh
.

Definitely the better solution, nice.

Ok new change from using ruby rstrip is done which makes this pretty final. As such run the final performance benchmark
Current
Calculating -------------------------------------
          parse:     80.921  (± 3.7%) i/s -      4.851k in  60.028478s
    parse & run:     32.196  (± 3.1%) i/s -      1.932k in  60.069380s

This feature
Calculating -------------------------------------
          parse:     80.791  (± 3.7%) i/s -      4.844k in  60.031186s
    parse & run:     32.109  (± 3.1%) i/s -      1.926k in  60.046058s

The results show the performance impact of this feature is very minimal.

@pushrax @tobi @dylanahsmith Where to from here? We would love to be able to start using this

There were some corner cases that you missed as noted above.  But overall this is looking very good now.  Nice work

@dylanahsmith is this what you were thinking?

I think just shifting this removes this issue. So flowing through this previously this would have allowed {.- where . being any character. However i think shifting this only allows {%- and {{- as the tag. So the only flows are

These 3 characters are at the end of a string and become a raw token
These 3 characters are at the start and become a token or variable and run their own loops
This is the last token and as such there will be no other tag following that will trigger the lstrip

Is there anything else needed for this to progress?

It looks like https://github.com/Shopify/liquid-c/pull/30/files#r70563502 still hasn't been addressed.  That was my last concern.

Ok i've added a reset after this line so it will only be set if it is found.

Ok this and the ruby version look like they are ready to go. What do we need to do to get this moving.


IconModule with HttpClient

IconModule does not work while removing Http '@angular/http' from the project to use the new HttpClient of Angular 4.3.

Will be fixed by https://github.com/angular/material2/pull/6702.


It doesn't work with randomized Mac on Android 10. I must turn off randomized Mac to use it.

Sorry I no longer maintain this project. Feel free to fix it and I will merge the fix.


#1356 Grey out items with no changes

Add internationalisation to the selection step page
Fix placeholders on other pages
WIP.

Looks good to me! I noticed "WIP"? Am I ok to merge?

👍 I am doing PRs for each of the items as there are quite a few on the import/export list 🐪

Merging to make way for next one :)


Add check for falsy hiddenTextarea

in calculateNodeHeight, hiddenTextarea can be false if not running in browser context,
which can cause tests to fail when accessing undefined style property further in the function.

@ablamunits thanks for the PR, could u specify though when this is a problem? calculateNodeHeight shouldnt run in a non-DOM context and its guarded against that here

@Andarist I am using mocha along with jsdom-global for testing. Perhaps the use of jsdom-global plays a role here, but I am not too sure.
It looks like in your code you are relying on an undefined reference to the element to decide whether the node height calculation should take place. However, I don't believe that calculateNodeHeight, as a function, should be tightly coupled with that use. Moreover, as it seems, some testing environments are handling the reference well.
Please let me know if there is something I might be missing here.

Would be great if you provide a simple repo with reproduced issue, so I could check how it behaves there exactly.

@Andarist
Thanks, I will try to set up a quick repo with an example soon.

Hi @Andarist
I have composed a minimal example showing the test error in a separate repo here.
In the example, I am trying to create a simple wrapper component around Textarea, called MyCustomTextarea. In my tests for the custom component, I am simply interested in validating that the value is rendered correctly and the onChange callback is called.
To see the error, please clone, install deps and test with npm run test.
The error does not reproduce when running tests with Karma: npm run test-with-karma
Thanks!

Ok, so I see what's going on here. The problem lays in the switch of the context you are making here. react-textarea-autosize is required while its still in a non-DOM environment, but you polyfill it later with jsdom-global.
I dont think that adding just next defensive check is the solution here. Im open however for a proposal how we could restructure the code better. Ofc please raise ur concerns

@Andarist
Thank you for taking a look. Would it be a reasonable suggestion to perform the checkes of whether or not the code is running in a browser context on demand? Instead of upon require?

Personally I dont like such solution as the code is working just fine and the proposed change is purely for satisfying the testing edge case.
Maybe we could expose a function though which you could use in your tests to reassure that the hiddenTextarea is there before you create an instance of Textarea. Maybe this would help others with some other edge cases too, although I cant think of any right now.

To be honest, I think that by doing that you will be exposing the users to your implementation details.. I don't think something like the existence of hiddenTextArea is the user's concern.
I love that this component is described as a drop-in replacement, and I agree that this is an edge case, but I think it is still a bug.
With that being said, sometimes the reasonable solution is also the simplest one. I would love to contribute and give a shot at any solution here that would not require exposing functions for the sake of testing.

I think this is already fixed by this line. calculateNodeHeight shouldnt be called in non-browser environments. If the issue is still not fixed please open a new one.


Weak call-by-value evaluation definition (WIP)

This is a work-in-progress to define wcbv evaluation to express (i.e. at least conjecture) the erasure property of extraction.

Right, I forgot that part, maybe even further we could have a custom observational equality definition. I’ll fix it

It seems that erase would never fail. If so, should its return type be term, not typing_result term?

sort_of can fail with NotEnoughFuel


Set -resync flag for registrator reregistering all services

This allows registrator and the service registry to get back in sync if they fall out of sync

this lgtm, is there anything blocking this?


Fix shape-bug for CSC in middle_outer_views

Create the correct shape of the view returned from middle_outer_views when self is a CSC

Hello and thanks for the fix. This looks good, but could you add a test showing a case that used to fail and is now fixed by these changes?

Absolutely


Example app doesn't populate Products datagridview

[Enter feedback here]
Running the example app as specified does not display data in the dataGridViewProducts datagrid.
You need to add:
this.productBindingSource.DataSource = dbContext.Products.Local.ToBindlingList();
after the line:
this.categoryBindingSource.DataSource = dbContext.Categories.Local.ToBindingList();

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ed8b20d5-5fe5-a2c9-e024-8c24ff0846a1
Version Independent ID: ed8b20d5-5fe5-a2c9-e024-8c24ff0846a1
Content: Get Started with Windows Forms - EF Core
Content Source: entity-framework/core/get-started/winforms.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

@Falconeer I just downloaded and ran the sample project and it is working as expected. Are you perhaps missing the dataGridViewCategories_SelectionChanged code?

I copied the code from the article, not from source control.
On Sat, Mar 18, 2023, 3:19 PM Arthur Vickers @.***>
wrote:

@Falconeer https://github.com/Falconeer I just downloaded and ran the
sample project and it is working as expected. Are you perhaps missing the
dataGridViewCategories_SelectionChanged code?
—
Reply to this email directly, view it on GitHub
https://github.com/dotnet/EntityFramework.Docs/issues/4291#issuecomment-1474996569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFL65XAGGHQQMF63KPAHCTW4YRHRANCNFSM6AAAAAAV5PMASI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Well, then I'm guessing you made a mistake.


Use angular to render the /account page instead of node ejs

When the user logs in, the user is navigated to /account. This page is rendered by the node ejs engine which renders server/views/index.ejs. This page is separate from our angular application and thus needs to be updated separately when we update the design of our app.
Proposal

Make a new route in angular for /account
Define an angular service that should be able to detect if a user is logged in or not.
This service can be accessed throughout the app and can be used to render pages accordingly

@sudheesh001 @fuksi @prasht63

Doing this would still suppot ejs right ? Breaking that would cause serious issues and lots of extra computation from our side to keep the elements in the right places.

@sudheesh001 see #157

@aneeshd16 Is this still related ? the /account used to be the place the tweet functionality used to work from, #92 reference solves that problem because now we don't need a specific route to tweet but rather the tweet functionality is present in everypage as its integrated with the lightbox modal that appears from top nav bar. If this is what is the required functionality, I believe this bug is good to close.

yep, this issue does not make sense now. Closing.


Authinterceptor signature typehints

Small bug fix which corrects the return type hint

Also def intercept_service(self, continuation, handler_call_details): is missing type hints


Quick Accent doesn't have Greek letters anymore

I updated to PowerToys 0.74.0 and I found that Quick Accent doesn't have Greek letters anymore. I work in a research lab and I have to use Greek letters often. It used to be really convenient. Please add Greek back. Thank you

Hi @masterrite. This should be resolved with PowerToys 0.74.1. If it doesn't resolve your issue, you can open an issue with the product's repository. If you visit the PowerToys repository, then you'll be able to create an issue to leave product questions/feedback.


Docs: Add headless library examples to fresh components

I'd like to add components using like these:

Headless UI https://headlessui.com/
Radix UI https://www.radix-ui.com/

Instructions on how to use it are here, but hopefully it will be included in the repository so that people don't get lost.
https://github.com/denoland/fresh/discussions/606

Radix UI seems not compatible with preact, so I'm testing headless-ui on my repo:
https://github.com/hashrock/fresh-components-beta
https://fresh-components-beta.deno.dev/
Dialog seems to work fine. It's especially difficult to make Modal, so I think it's worth posting it as a sample. However, the dropdown style can be a little strange. The Switch component works fine when reloaded, but sometimes it behaves strangely like this video.
https://github.com/denoland/fresh/assets/3132889/1f20e630-2384-4db5-b905-824b0f8d7017

@hashrock any specific issues you ran into? Happy to take a look.


Pipeline testing

WIP
Started on pipeline testing

Pull Request Test Coverage Report for Build 141

7 of 8 (87.5%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+6.7%) to 70.565%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/scala/org/codefeedr/plugins/StringSource.scala
1
2
50.0%

Totals

Change from base Build 132:
6.7%

Covered Lines:
175

Relevant Lines:
248

💛  - Coveralls


[5.3] Always pass the socket to the broadcaster if interactWithSocket trait is used on the event

Closes: https://github.com/laravel/framework/issues/13929
I'm not sure if this is the best way to go about doing this tho.
But for now i'm seeing if you like it.

Fixed this in a slightly different way. Thanks.

Oh yeah, forgot about data_get :)
Thanks for heads up.


Update Team in Readme

Add @shivaniprakash95 in the EvalAI-ngx team.
@deshraj Please review the PR.

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   69.04%   69.04%
=======================================
  Files           5        5
  Lines          42       42
  Branches        1        1
=======================================
  Hits           29       29
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a6cf0...8d31976. Read the comment docs.


[Feature] Make buttons without labels round

…to look more native. i use this CSS:
.ytd-menu-renderer[button-renderer=""] .cbox {
    display: none;
}
.ytd-menu-renderer[button-renderer=""] .yt-spec-button-shape-next__icon {
    margin-inline: -10px !important;
}

check beta
I used your example but implemented it differently. Compare it


Error when using "acute accent" ´ in Scenario and Scenario Outline name

Summary
Error when using "acute accent" ´ in Scenario and Scenario Outline name
Expected Behavior
Scenario being executed
Current Behavior
Error
C:\Ruby23-x64\bin\ruby.exe -EUTF-8 -e $stdout.sync=true;$stderr.sync=true;load($0=ARGV.shift) C:\Ruby23-x64\bin/cucumber "C:/Users/cbaumann/RubymineProjects/IBE testing/features/3 Passenger Checkout Page/[TIBE-75] B2B Checkout Passenger information collection.feature" --format Teamcity::Cucumber::Formatter --expand --name "^First passenger (doesn\´t) equal contact$" --color -r features
invalid multibyte character (ArgumentError)
C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/cucumber-3.1.0/lib/cucumber/cli/options.rb:112:in block (2 levels) in parse!' C:/Ruby23-x64/lib/ruby/2.3.0/optparse.rb:1547:in block in parse_in_order'
C:/Ruby23-x64/lib/ruby/2.3.0/optparse.rb:1534:in catch' C:/Ruby23-x64/lib/ruby/2.3.0/optparse.rb:1534:in parse_in_order'
C:/Ruby23-x64/lib/ruby/2.3.0/optparse.rb:1528:in order!' C:/Ruby23-x64/lib/ruby/2.3.0/optparse.rb:1620:in permute!'
C:/Ruby23-x64/lib/ruby/2.3.0/optparse.rb:1642:in parse!' C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/cucumber-3.1.0/lib/cucumber/cli/options.rb:150:in parse!'
C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/cucumber-3.1.0/lib/cucumber/cli/configuration.rb:27:in parse!' C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/cucumber-3.1.0/lib/cucumber/cli/main.rb:66:in block in configuration'
C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/cucumber-3.1.0/lib/cucumber/cli/main.rb:65:in tap' C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/cucumber-3.1.0/lib/cucumber/cli/main.rb:65:in configuration'
C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/cucumber-3.1.0/lib/cucumber/cli/main.rb:30:in execute!' C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/cucumber-3.1.0/bin/cucumber:9:in <top (required)>'
C:/Ruby23-x64/bin/cucumber:22:in load' C:/Ruby23-x64/bin/cucumber:22:in <top (required)>'
-e:1:in load' -e:1:in '
Process finished with exit code 2
Steps to Reproduce (for bugs)
Create feature file with Scenario where the names contains an "acute accent", run the scenario.
Your Environment

Ruby: ruby 2.3.3p222 (2016-11-21 revision 56859) [x64-mingw32]
Cucumber:
cucumber (3.1.0)
cucumber-core (3.1.0)
cucumber-expressions (5.0.17, 5.0.15)
cucumber-tag_expressions (1.1.1)
cucumber-wire (0.0.1)
Operating System and version: Windows 8.1 Enterprise

Could you please format output and source code using fenced code blocks so it's easier to read?
The error should go away if you remove the escape character (\) in front of the accent - no escaping is needed.

You also seem to be mixing regular expressions and cucumber expressions. Regular expressions are delimited with / at the beginning and end, while cucumber expressions use " or ' at the beginning and end.

Got this from the comments under 364.
But this issue has nothing to do with cucumber or regular expressions.
I have a feature file, containing the following line
Scenario Outline: First passenger (doesn't) equal contact

When trying to run it, I get the error posted above.

What are you trying to do @christianbaumann? It looks as though you're trying to use the command line to specify a step definition to run. Cucumber doesn't work that way - you can only specify what scenarios to run.
Can you explain exactly what you're doing? Are you using RubyMine to run a specific scenario? How are you interacting with RubyMine to do that?

It looks like Cucumber is given command line arguments with incorrect encoding. It's RubyMine supplying the arguments, so I think you have to report the bug with them.
A couple of things to try:

Can you run the scenario from the command line, outside RubyMine?
Can you verify that your feature file is saved with UTF-8 encoding?

Closed due to inactivity. Sounds like a RubyMine bug.


Remove empty bridging header

While reviewing a PR, I noticed that this project contains an empty bridging header. It is unlikely to be needed in the future, so this PR removes it. If it ends up being needed again, Xcode will offer to create one.

@esreli Done!

@esreli Thanks!


Download for Harms / Stitching - Going in Error for Unknown Reasons

Describe the bug in current situation
On TRA-2023-31685, the when the Harms Package is being stitched together (i.e., 'Download for Harms' was selected), the 'Download for Harms' keep throwing an error. There are no files in error on the package, nor am I aware of any issue with the divisional tag used for these records.
Link bug to the User Story
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
High
Chance of Occurring (high/medium/low/very low)
Low
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
PROD
Steps to Reproduce
Steps to reproduce the behavior:

Go to TRA-2023-31685
Click on the Records tab
Select 'Download for Harms'
See error

Actual/ observed behaviour/ results
Harms package is being thrown into error during stitching for unknown reasons.
Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

Confirmed records from PROD can be downloaded and uploaded in TEST to test issue.

Legacy issue, and have not had it come up recently. Closing as this ticket as it is stale.


fix: retry maven deploy

:tada: This PR is included in version 1.5.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


streaming tutorial_2 for python and rust

Tutorial two for RabbitMQ streams for Python and Rust clients.
It fixes a small thing on the Python tutorial1 as we don't need to install the type_extension dependency.

Rust client tutorial_2 hidden till this bug in the Client (necessary for the tutorial): https://github.com/rabbitmq/rabbitmq-stream-rust-client/issues/222 get fixed


vim-hy still being actively maintained?

Is someone still actively maintaining this plugin? If not, I'd be happy to take over.

Ah, didn't see the emoji reactions. Cool!
I might end up rehauling the plugin based more on the clojure syntax/indent files, hopefully I'm not stepping on anyone's toes if I end up gutting parts of the existing plugin.


What are the purposes of label_pad_token_id and padding_value in DPOTrainer?

Why is it required to set these two arguments? My first guess was that padding_value would be the pad token? But it's not clear to me why these are specified, and why they are separate from the tokenizer's values, tokenizer.pad_token and tokenizer.pad_token_id, and how these two interact, or if they should be set to agree with each other.

cc @kashif

@nathan-az so I have refactored the trainer and removed the need for padding_value which is essentially the tokenizer.pad_token_id used to pad the input_ids so that sequences have the same shape in a batch...
g'day nathan! I noticed that we were using the padding_value to also pad the attention mask which is either 0 and 1 and thus now i explicitly set the pad values for the attention mask to 0 and take thepadding_value from the tokenizer.pad_token_id and use it appropriately. The refactoring is here:
https://github.com/huggingface/trl/pull/885

Closing this for now, feel free to reopen should you have further questions!


Add codeVersion as an option to Log4j2 appender

Added the ability to use the rollbar version feature with log4j
  <Rollbar name="ROLLBAR">
        <accessToken>${rollbar.access.token}</accessToken>
        <environment>${environment}</environment>
        <codeVersion>${version}</codeVersion>
    </Rollbar>

Released in https://github.com/rollbar/rollbar-java/releases/tag/v1.6.0


fix(qemu): panic due to unchecked nil map

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[ ] Tested your changes against relevant architectures and platforms;
[x] Ran make fmt on your commit series before opening this PR;
[ ] Updated relevant documentation.

Description of changes
The following lines cause a panic due to assignments to a nil map:
https://github.com/unikraft/kraftkit/blob/8a562d8303c2d6483a3dc8dc6b0b2c540e430098/machine/qemu/v1alpha1.go#L181
https://github.com/unikraft/kraftkit/blob/8a562d8303c2d6483a3dc8dc6b0b2c540e430098/machine/qemu/v1alpha1.go#L191

Nice catch! Could you just adjust the Git commit title so that it matches the PR title (removing the machine/)? Thanks!


Link to Base Styleguide page under /web/resources is broken.

Hi,
The Base Styleguide page link under web/resources is broken and is throwing 404.
Can someone pls fix it so that we contributors can refer to it as an when needed while making any contribution :)
Thanks,
Moin

Thanks for the feedback, we've got an update coming next week that should fix this.

No worries,
Thanks
On Sep 23, 2016 2:20 AM, "Pete LePage"<EMAIL_ADDRESS>wrote:
Thanks for the feedback, we've got an update coming next week that should
fix this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/WebFundamentals/issues/3163#issuecomment-249023921,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG8fecSowr8hgQ8uj1RA6KUKHIc5s9gFks5qsuoWgaJpZM4JZDS3
.


I did all the step and open the game and just a blank space. How to fix it? Thank you

I open the game and just see a blank space.

same here, tried everything mentioned #22 here as well, still not working on the Quest 3 device


[MRG] Allow str argument in raw.drop_channels

This allows to provide a string argument (the channel name) if only a single channel should be dropped.

@cbrnr please see why CIs complain.

thanks @cbrnr


Quoted error messages are parsed incorrectly

This code for some reason generates an UnexpectedCharacter error instead of producing empty output:
#if 0
#error "abc"
#endif

This is because the lexer only parses valid GLSL tokens and # (for the preprocessor). Looking at two open-source GLSL preprocessors:

ANGLE (WebGL) accepts #error "abc" because " gets tagged as an "other" token here and later the handling of #error appends all the token text until the next newline.
glslang has pretty decent string parsing that's used both for #error and #include

We should define how good a string parsing we want to do, then use it for #error.


Do not crash on torch.export

Fix file name length issue when torch.export.export is called under depyf
The name used in the lazy_format_graph_code when using torch.export.export contains the "nn_module_stack" dictionary of the first module call of the model, which is an unreadable and long string.
As a prefix it contains a hard-coded string "pre insert_deferred_runtime_asserts" and then the result of  f"exported program: {first_call_function_nn_module_stack(gm.graph)}", where the function call returns the dict.
This means that currently at least splitting by ':' will give useable name.
As export requires full graph we will have only one graph, so it will probably not be confusing.

This should handle #72

@gilfree thanks for the fix!


Add image migration scripts

In order to move images between OS clouds,
several steps are required. This is currently
being used for providing a clone of the EBI
servers at UoD.

These commits switch to using the openstack client (recommended over the individual clients where possible http://docs.openstack.org/cli-reference/common/cli_install_openstack_command_line_clients.html), and parse the json output to check for completion:
https://github.com/manics/infrastructure/commit/ac1cb8383b46ad81076f23800fa0e627f0290248
https://github.com/manics/infrastructure/commit/ee024fab99cd50b0c8cf37875b0a14bbdb7760e5

Pushed.

Merging as the current state of things.


Update cats-effect to 3.3.1

Updates org.typelevel:cats-effect from 3.3.0 to 3.3.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #206 (ffb4242) into master (f8261e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   87.30%   87.30%
=======================================
  Files          28       28
  Lines         843      843
  Branches       39       39
=======================================
  Hits          736      736
  Misses        107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8261e7...ffb4242. Read the comment docs.

Superseded by #209.


feat: more rust in trampoline

Summary
This is an experimental PR to replace more unsafe calls with more rust while still trying to keep the binary size small enough. These changes roughly increase the size of the trampolines to about 40kb~. This is a alternate PR to https://github.com/astral-sh/uv/pull/5751.
The primary changes here include

Switch to use rust path components for ease of path management
Leverage std::process::exit for process exit and cleanup
Use std::io::Error::last_os_error for IO Errors to remove FormatMessage complexity
Use std::env::current_exe to get the current executable instead of GetModuleFileNameA

Test Plan
Added one more existing test case to trampoline tests.

CC @konstin since you already pre-reviewed some of the changes

On my machine the wheel goes from 11798922 bytes to 11827535 bytes, a 0.2% increase so totally fine size wise.


[WIP] Code quality, browserify, es6, tooling

Opening this PR for visibility with #678 .  This branch is still very much under development.
Changes contained herein are massive and will cause breakages for anybody currently in development.  This would be for a v3.0.0 release due to the massive changes in the codebase.
Major items addressed or being addressed in this MR:

[x] adds .editorconfig
[x] adds npm support and node_modules for external dependency management
[x] adds project information to package.json file
[x] adds build tasks: gulp build and gulp dist (and many more supporting tasks) to transpile, concat, minify, etc source files into the assets dir.
[x] adds src dir for development
[x] adds support for ES6/ES2015 via babel
[x] adds eslint and eslint-plugin-airbnb ruleset
[x] moves script import to foot of index.html
[x] updates script to only import bundle.js
[x] removes need for load_modules function in modules.js and removes scripted insertion of script tags
[x] manually instantiates each file/class previously located inside the MODULES array.
[x] adds callbacks in appropriate places for each module file
[x] manually adds some functions to window for use elsewhere
[x] begins addressing lint errors/warnings (eslint found 14,494 total errors/warnings)
[x] add documentation for build tools
[x] add ava and nyc for testing and reporting

Upcoming tasks (in no particular order):

[x] separate out concerns across smaller files. (This is a biggie)
[ ] remove everything from the window object and fix all the global functions, vars. (Another biggie)
(https://github.com/n8rzz/atc/tree/feature/clean-the-window)
[x] add npm run test task(https://github.com/n8rzz/atc/tree/feature/clean-the-window)
[x] translate files to ES6 where applicable
[ ] integrate lodash where applicable
[ ] remove if logic in favor of default parameters
[x] abstract common modules across application into self-contained units
[ ] remove need for Fiberdependency in favor of plain es6 inheritance.
[ ] update for/in loops to use either for or _map when iterating through arrays.  for reasons why, see: http://stackoverflow.com/questions/5263847/javascript-loops-for-in-vs-for
[ ] simplify if/else if/else logic blocks.  Some methods/functions are 500+ lines long. There is room for abstraction and simplification there.

I'll add to/update this list as I continue to make progress.  Feel free to add comments and feedback as you see fit.  I didn't open this MR just to look at it! 😄

@erikquinn  So the above list is accurate to what I have currently merged in to my develop branch.  However, I am actively developing on this branch, If you'd like to take a peak: https://github.com/n8rzz/atc/tree/feature/clean-the-window.
The meat of this work is the 1st and second items of my todo list above.  I decided to start with the aircraft.js file because, wow, sooo many lines.

@n8rzz I was hoping we might be able to push the upgrades live somewhat incrementally.... if it does have to be kind of "everything at once", perhaps it's best to put this work on a separate branch eg zlsa/v3 which would eventually be merged into zlsa/gh-pages?
That way, we are all able to test locally and find and make whatever small fixes and amendments that might be needed before pushing it live to the main branch of the game. This way, it doesn't all have to be 100% perfect in a single supermassive PR, because that could take quite a while to do (I would think). Thoughts?

@erikquinn Yeah, sorry about that.  I kinda just went for it.  But, now that I think of it, it would probably be best to do all at once.  There are a lot of changes and I'd hate to affect any other development.  An all at once plan will be a little pain once instead of a little pain many times.
I think a zlsa/v3 branch would be the best plan anyway.  With a refactor this size (I have or will have touched essentially every line of js), I am expecting at least some bugs.  I've been trying to carefully test everything as I go, but I don't know the app as well as the rest of you.  So I'm sure I will have missed something.  I would feel much better knowing it's been kicked around a little bit before being released out into the wild.
Good news is with the new file structure, finding and fixing bugs should be significantly easier.

The thing that always gets me about refactors is this: If I've done a good job, the end user will hardly notice a difference.  But the code that runs it all looks completely different.  Crazy.

But, now that I think of it, it would probably be best to do all at once. There are a lot of changes and I'd hate to affect any other development. An all at once plan will be a little pain once instead of a little pain many times.

^ My thoughts exactly: if we're going to do it, let's just put the rest on pause, do it RIGHT once and for all.

I am expecting at least some bugs. I've been trying to carefully test everything as I go, but I don't know the app as well as the rest of you.

^ Oh, for sure, but the benefits immeasurably outweigh the potential bugs, as it would make it so much easier to work with for those of us working on implementing improvements to the "meat and bones" of the simulator. I'll make some time to look through what you've done and make comments, ask questions, etc so we can all be on the same page. And once it's workable, we can post a link for people to test it on the web instead of having to check out a local copy.

The thing that always gets me about refactors is this: If I've done a good job, the end user will hardly notice a difference. But the code that runs it all looks completely different. Crazy.

^ That's the idea! :wink:
Thanks a lot for taking the time to offer up all these improvements; they will make a really big difference. I think I speak for everybody when I say your help is quite welcome! :+1:

Added branch zlsa/v3, and made it the target branch for this PR.

@erikquinn I'm making good progress here.
Here is the loading profile for the current site:

and here is the loading profile for my develop branch:

With the changes I've made so far, load time has decreased by over a second.  Ship it!

I look forward to your feedback!  I have tried to leave a lot of breadcrumbs along the way as I travel through the app.  There are a lot of spots that can be improved, some that I'm doing now and some that will take a little more time.  I've noticed a very high frequency of hasOwnProperty checks, is there any reason for these?  I'm not sure these are all entirely necessary and may be better accomplished with initializations so at least you know the property exists.
The process of a refactor often starts with a sledge hammer approach; smash big bits of code and let the pieces fall where they may.  I'm taking more of a surgical approach, working on smaller sections at a time and making sure my changes won't have side effects.  I am trying to lay the groundwork, though, for future smaller refactors like moving the functions in the util folder to more appropriate folders and also adding tests for those functions.  I've started doing that in some areas, but those are smaller changes that I think can wait until the big stuff is done.
To be honest, I've spent most of my time fixing the spacings and adding curly brackets to ifs and fors.  Curly brackets always, it just makes things easier to ready and reason about.  It also doesn't rely on spacing to be interpreted correctly.  This isn't yaml after all, lol!
Ok, back to work...

I have removes the fonts and images task from gulp dist.  They are still available as a  tool, but will no longer run with that specific command.

Just a quick update:
Still making good progress. I've moved over to a feature branch for the last few days just to keep things isolated.  I'm almost finished tying everything together in encapsulated classes that get attached to the window.  There is still a fair amount of work to do to move everything away from global window functions.  Once I'm done on this current branch, there will be a very good base for making those changes.  It's just taking time.
I'll merge this latest work in by the end of the weekend.  yay!  another 30 or so commits for this PR.

@erikquinn Fiber is officially gone!  The main refactor is done!  Load times, have improved:

However, work continues...
There is still a lot of work to do (see updated checklist above).  I have already begun abstracting and simplifying (see: 996e567).

Most of the main modules are still attached to the window, only now they are all encapsulated in instances that live in App.js.  The next step is to explicitly pass them as parameters to only the files that need them.
As I simplify methods, I have started adding comment blocks to each method.  This is, so far, inconsistent throughout the app.  But its a start.
util.js needs to be split into smaller files grouped by concern and tests need to be added.
Various other abstractions and simplifications have been called out via TODO and FIXME comments and will be addressed soon.

When you review this, it would be easier to just pull the repo and look at the code.  I have added a readme to the tools/ folder that walks through getting this set up locally.  I've done my best to make changes in small chunks and then test things after making those changes.  But, alas, I'm sure there are some bugs that have snuck in.  I am aware of two that are on my radar and will be addressed as part of my continuing refactor efforts.  With the amount of changes made here, git bisect is your best friend when zeroing in on a bug.  Seriously, know it, use it, love it.
I think this is coming along nicely, the code base is much more readable now and I'm moving towards a much better separation of concerns.  These last commits are a great example of abstraction and simplification.
I do want to call out, if it isn't already painfully obvious, that I have touched every line of code in this project with the exception of the contents of the parser.js file.  That means that some file histories (git histories) are going to be lost.  Many files have been split up, renamed, or simply removed.  So be aware that the gits will say I wrote a lot of this.  I didn't.  I've just moved it around and made it look pretty.

Wow... At first glance, much of the new code blows my mind! :heart_eyes: But I love how the whole thing feels, it just will take some re-learning on my part. There are (of course) some issues I've come across, but nothing worrying; I'm just thrilled with all the progress! :tada:
Will have to play around with it more later, gather a high-priority hit list of stuff that broke, and then we can go bug smashing :beetle: :hammer:
In the meantime though, unless there are important things you wanted to amend, I think it might be a decent idea to take a minute to clean up any obvious breakages, and then merge this into the v3 branch and post a testing link, in order to give the contributors some time to help by generating a comprehensive list of issues that I may not have noticed. Then, I (or anybody) can address the bug fixes simultaneously with your continuance along your list of "upcoming tasks", thus accelerating the timeline to getting 3.0 to the big stage.
I'm getting weirdly excited by all this! haha

Awesome, I'm glad you like what I've done. Funny thing is, even though it is laid out completely differently, a lot of the old code remains mostly untouched.  Well, other than syntax changes and some simplifications here and there.  There is a healthy amount of es6 sprinkled in there, now, too.  And lodash.  Lodash makes things soooo much easier. https://lodash.com/docs/4.16.2
I've updated my list above, there are still two items that I would like to finish before we tag this as v3.0.0 and start QAing.  Both of those tasks are in progress right now and should be done by the weekend.  After that, I'd feel comfortable with starting to squash bugs.
How would you like to handle tracking of those bugs;  A specific tag on the existing issues board or create issues on my fork and address them there?  Its up to you, I'm not picky just so long as there is a place to collect them, track them and make comments.
ES6 has a way of making javascript fun again.  Its totally normal.  Once you start dreaming in javascript, though, then you might want to start getting concerned.  Waking up in the morning with visions of _map(this.waypoints, (waypoint) => waypoint.name) and such, then you may have a problem.

One other thing, if you have any questions about what I'm doing or why (or both) please don't be afraid to ask!  I love talking javascript and I especially love talking about specific implementations.  I don't get defensive about my code and code reviews are a daily thing at my job. So I'm not shy about critiques and/or justifying the why.
So please ask if you're curious or say something if you see something you don't like!!

For those interested, my fork is live at: https://n8rzz.github.io/atc/
I think, just to keep things together (and @erikquinn feel free to chime in) we should log any issues with this potential v3 codebase at: https://github.com/n8rzz/atc/issues
That way we can keep everything together, but separate.  I will continue with the last two items above and merge that into gh-pages once its ready.

Unfortunately, I didn't get as much accomplished as I would have liked.  I was successful in moving everything in util.js to proper concerned function files.  There are still a few functions left in that file that may eventually move to a not-yet-created stringHelpers.js file.  As of right now, though, there isn't a huge need for such a file.  I did not get a chance to move the main controllers off of the window.  That will have to wait for another day.
I think we're at a good stopping point here to start QAing the crap out of this beast.  I have already logged a few issues that I'v found.  Mostly minor stuff, although the ILS track one is somewhat concerning.  I'll have to check the current game to see if I can reproduce it there.
For anybody that decides to help out on bugfixes, I'd like to follow a specific branching and merging strategy:

any bugfix should be done on a specific branch off of gh-pages with a title bugfix/ATC-{ISSUE_NUMBER}.
gh-pages is a protected branch in my fork.  So once a fix is done, please submit an PR and I'll get that merged after a review.

I'm hopeful we'll be able to move through any bugfixes relatively quickly, but I've been through QA many times before and I know that that is not always the case.
At any rate, after we're done with QA I think my next order of business will be a refactor/simplification of the AircraftInstanceModel and the AircraftFlightManagementSystem along with [probably] Legs and Waypoints.  There is a lot of room for refactor in all of those files, every time I'm in them I need to restrain myself from going on a refactor binge.
Everything is up-to-date on my fork's gh-pages branch.  So feel free to take it for a spin (https://n8rzz.github.io/atc/) and log any issues you find (https://github.com/n8rzz/atc/issues).  If possible, please provide screenshots and steps to reproduce.  Also include your browser if you are not on Chrome.

@erikquinn yes.  And IntelliJ and Vim.
My current editor of choice is Atom.  I'm really liking it, too, it's giving vim a run for it's money.  I don't think I'll ever go back to SublimeText (2 or 3).  Too many weird bugs and not a lot of support.  Atom is great because it's easy to customize, it's built on electron and the community is very active.  Plus, being a client side developer, there is something poetic about writing code for browsers in a browser.  And it's pretty fast too.  My only complaint is with the current eslint plugins.  I have two and both are, in my opinion, sub-par.
IntelliJ is great, but it's so slow.  I was on a Scala project a while ago and IntelliJ was very useful there.  I could run the db and debug the scalas right in the IDE.  I do use it very occasionally for the merge tool and history diffing.
Now, though, probably 85% Atom 10% Vim 5% IntelliJ.

I forgot to add VSCode to that list as well.  I recently just started using that instead of Monodevelop  when I work with C# in Unity.

VSCode all the way!

closing this in favor of #702


[WIP][WB-6400] Enable login timeout

https://wandb.atlassian.net/browse/WB-6400
Description
This PR enables setting a timeout in the prompt choices part of wandb.login()
(PR is replicated from: https://github.com/wandb/client/pull/2503)
Usage:
* wandb.login() # defaults to 30s timeout
* wandb.login(timeout=10) # times out after 10 seconds of no response
~~* wandb.login(timeout=0) # Never times out ~~
Enables optional login timeout:

wandb.login() - Never times out
wandb.login(timeout=10) - times out after 10 seconds.

Implementation details:
Timing out thread didn't work with inputs. This implementation uses select and termios to timeout stdin event in uninx/linux and msvcrt for windows
Testing
Tox tests failed as  wandb.utils.propt_choices is monkey patched. I haven't messed with those files yet.
wandb.utils.propt_choices was monkeypatched to accept input_timeout parameter.
Release Notes
Below, please enter user-facing release notes as one or more bullet points.
If your change is not user-visible, write NO RELEASE NOTES instead, with no bullet points.
------------- BEGIN RELEASE NOTES ------------------
Enables login timeout defaulting to 30s if not provided explicitly
* wandb.login() # defaults to 30s timeout
* wandb.login(timeout=10) # times out after 10 seconds of no response
*  wandb.login(timeout=0) # Never times out
Enables optional login timeout:

wandb.login() - Never times out
wandb.login(timeout=10) - times out after 10 seconds.

------------- END RELEASE NOTES --------------------

Closed in favor of:
https://github.com/wandb/client/pull/2664


Replace Segment with Tabs

I want to replace Segment (All, Favorites) with Tabs. How would the code look like?
I'm asking because I've tried to replace with tabs but it didnt work.
Regards

Hello! Thanks for opening an issue with us! As this seems like more of a support question i will urge that you ask this question on our forum. Thanks for using Ionic!

 No one ever responds!

@thebasix The best way to get help is to post on the forums or in the Ionic Worldwide Slack channel. It helps to be descriptive about what you are trying to accomplish including images of your desired result, what you have tried, code examples and/or a repository. @mhartington frequents the forum and the Ionic Worldwide Slack. I recommend the #ionic-v2 channel for Ionic 2 questions. I'm not sure what your end goal is, but we don't recommend using tabs inside of content. The Ionic Tabs component should be used for navigation (it resembles Material Design bottom navigation: https://material.google.com/components/bottom-navigation.html) and the Ionic Segment should be used for changing between views (it resembles Material Design tabs: https://material.google.com/components/tabs.html).


Figure out how to find out if a value is quoted or a mulitline string

Following up on https://github.com/wise-agents/wise-agents/issues/279.
If we have test: "${INT}, and INT=2, we should end up with the dict {"test": "2"}, at present we end up with {"test": 2}.
One option is to check the index of the value in the node which I have attempted to do here https://github.com/kabir/wise-agents/tree/env_var_parsing_quotes. If the character before/after is a quote it is taken to be a string.
But this does not take into account multiline strings, of which there are several types in YAML https://yaml-multiline.info
Although, MAYBE if a value spans several lines, it must be a string (unless it is a dict or an array)?

I think we should use INT='2' if we want a String

@kabir all done? can be closed?

No


Parse config is not returning config data.

I was using config data through Parse.Config.get,but since last week it seems to be not working at all ?
Any suggestion would be helpfull !

@asif13 do you have some logs to show this behavior? Also, could you set an earlier version of Parse Server and check if it returns the expected config?


Print function

Presumably Python 3 compatibility is desirable at some point.

Thanks! LGTM, so merging.


File not found

For some reason I am getting this build error:

This is in Bulk_Generics_4.cpp, but If I comment the line out I get the same error referring to the same file being "not found" in other files. I have checked my search paths, but there does not appear to be anything wrong with it:  $(UNITY_IOS_EXPORT_PATH)/Libraries/libil2cpp/include

Do you use pods in your project? I had the same issue when I tried to integrate Unity to a project which uses Cocoa Pods. Try setting up a new project and compare the build settings of these projects, especially header search paths and library search paths. It should work after this adjustment.

Download full resolution images
Available until Aug 9, 2017
https://www.icloud.com/attachment/?u=https%3A%2F%2Fcvws.icloud-content.com%2FB%2FAe-_53fh1krne_elcKjX4HQtt29nAfZYKWUzkhQCj9S0ryJxc9ihVLxe%2F%24{f}%3Fo%3DAo2fKhR9nzb1RlHRlsOJCge6TswdLtE3yBexV9d_F_-L%26v%3D1%26x%3D3%26a%3DBU1KbiT4LRQTA6UJPQEA_wHIAP8icxDF%26e%3D1502313896%26k%3D%24{uk}%26fl%3D%26r%3D30692E9D-A838-4395-9100-F9B06AC7284A-1%26ckc%3Dcom.apple.largeattachment%26ckz%3D5CAEDCF9-F5D3-426E-9ADB-99FA9DE29EDE%26p%3D68%26s%3D_cdIEWF7V06GtT3iNvBBIktDeNg&uk=PSwuDW4iJcFyzBFU8GRDWw&f=Images.zip&sz=763258I have not used any pods yet. After creating the unity scene and then building it for iOS, I added the Library and Classes folders to the Xcode project (no copy items if needed, and I selected Create Groups, not Create Folder References for both). Using the xcconfig file, I updated UNITY_RUNTIME_VERSION to 5.6.2f1 and UNITY_IOS_EXPORT_PATH to the path of the build folder created with Unity. All the rest of the settings should be automated. Nothing appears to be different, but for some reason I just always get compile errors.
I have attached my example project so you can see it easier as well as a screenshot of the project structure from Xcode and another screenshot the errors I am getting when I try to build.
Thank you so much for your time and help!
Eric
Click to Download
https://www.icloud.com/attachment/?u=https%3A%2F%2Fcvws.icloud-content.com%2FB%2FAQtpP7trC1Rs0p38HYuTslDW2a3KAYbUmwrAzUmY8X7ILu-Iukj0WbSK%2F%24{f}%3Fo%3DAk316Se6ddjS4XVd0RfcbFXKMVdTP4sZZkGDwTotolx2%26v%3D1%26x%3D3%26a%3DBZGL1OWUfOoSA6UJPQEA_wHIAP9yzNM3%26e%3D1502313896%26k%3D%24{uk}%26fl%3D%26r%3D9FCCC074-2407-45B7-981C-9998A8EF5CA5-1%26ckc%3Dcom.apple.largeattachment%26ckz%3D5CAEDCF9-F5D3-426E-9ADB-99FA9DE29EDE%26p%3D68%26s%3DzDEUhSvCAvKMzoDW3d-SKDTFWps&uk=-9ESIAZzrlbEJ2CU7xMS0w&f=CubeProj-SWIFT.zip&sz=422992291CubeProj-SWIFT.zip
423 MB

On Jul 10, 2017, at 1:18 PM, DogeWowzie<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Do you use pods in your project? I had the same issue when I tried to integrate Unity to a project which uses Cocoa Pods. Try setting up a new project and compare the build settings of these projects, especially header search paths and library search paths. It should work after this adjustment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/blitzagency/ios-unity5/issues/45#issuecomment-314207242, or mute the thread https://github.com/notifications/unsubscribe-auth/Aciopv4HliIruFA30_GJztBsJh6eo-E7ks5sMnkfgaJpZM4OQLhb.
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png https://github.com/blitzagency/ios-unity5 https://github.com/blitzagency/ios-unity5/issues/45#issuecomment-314207242

I could not compile your project, because you did not your Unity classes properly. But make sure your Header Search Paths in Build Settings look like this:
$(inherited)
$(PROJECT_DIR)/ios_build/Libraries
$(PROJECT_DIR)/ios_build/Libraries/Plugins/iOS

Well the reason they don’t show up is because when I dragged those folders into the project I did NOT check the box for “copy items if needed”. So they are just referenced through UNITY_IOS_EXPORT_PATH. I don’t have the path you mentioned.
This is my Header Search Paths:
$(UNITY_IOS_EXPORT_PATH)/Classes
$(UNITY_IOS_EXPORT_PATH)/Classes/Native
$(UNITY_IOS_EXPORT_PATH)/Libraries/libil2cpp/include

On Jul 11, 2017, at 10:58 AM, DogeWowzie<EMAIL_ADDRESS>wrote:
$(inherited)
$(PROJECT_DIR)/ios_build/Libraries
$(PROJECT_DIR)/ios_build/Libraries/Plugins/iOS


Fixing link to the api documentation

My attempt at fixing the issue I submitted: #12

Looks good! 👍


Allow Alternative Means of Providing upstream_auth

Problem Description
upstream_auth currently only takes in a string with the credentials in plain text, which means that your upstream credentials are either persisted in plain text on disk in the config file or clearly visible in the process list when passed via CLI flags.
Proposal
There should be some method of providing the upstream proxy credentials securely, such that they are not stored on disk in plaintext nor visible from the process list. OfflineIMAP for example allows users to provide a python script that can load the credentials from any source, e.g. GPG.
Alternatives
The user could opt into being prompted to enter their credentials upon launching mitmproxy. This could also be integrated with the system keychain so that the user can elect to have the password automatically unlocked when they login to their machine.

You could conceivably write a simple addon that fetches credentials and then updates the option. It's very unlikely that we will adopt a more elaborate scheme here.

I would argue that secure credential entry should be the default, but I can agree to disagree. Thank you for your consideration!


[T2A2][W15-A3]Marcus Ng Wen Jian

Ready for review
Tutorial Group 6
Wednesday 1500-1600 Team A3

@marcusngwj

in general good work on this. keep it up!
try to improve on the minor comments made throughout the code.


Prompt's with same messages on different pages

Version
v.5.1.2
Steps to reproduce
I have two pages with a Prompt component on both of them. Both pages have the same messages pass as properties to Prompt.
Page 1:
   <Prompt
 	when={blockLeavePage}
 	message="Do you want leave the page? All unsaved changes will be lost!"
   />

Page 2:
   <Prompt
     when={blockLeavePage}
     message="Do you want leave the page? All unsaved changes will be lost!"
   />

Both of those pages have cross-links to each other.
Expected Behavior
Prompt will work even with the same messages on different pages.
Actual Behavior
Then I navigate to the page with Prompt on it with the same message as the page from which i came, the Prompt doesn't work anymore.
I fount the pease of code in the Prompt  component, which responsible for such behavior:
 return (
	 <Lifecycle
	   onMount={self => {
	     self.release = method(message);
	   }}
	   onUpdate={(self, prevProps) => {
	     if (prevProps.message !== message) {
	 	self.release();
	 	self.release = method(message);
	     }
	   }}
	   onUnmount={self => {
	     self.release();
	   }}
	 message={message}
	 />
 );

prevProps.message !== message - is the problem.
Is this line has any special meaning or some special case? I definitely would like to have the same messages on all the pages of my editor part of the app.

I'm not 100% sure why that line is there, but I believe it's to stop an infinite loop.
The easiest way to workaround this is to put a key={location.key} prop on your Prompt so that the component is reinstantiated each time and doesn't have any previous props.

I'm not 100% sure why that line is there, but I believe it's to stop an infinite loop.
The easiest way to workaround this is to put a key={location.key} prop on your Prompt so that the component is reinstantiated each time and doesn't have any previous props.

This solution didn't work.


Windows terminal pane is non-responsive after long idle git log

Windows Terminal version
1.13.10734.0
Windows build number
10.0.22000.556
Other Software
git - git version 2.35.0.windows.1
profile is powershell, PSVersion  5.1.22000.282
Steps to reproduce
Working via RDP,
Opening a terminal pane with git repo,
Run git log and leave it "alive"
Return after a few hours and try to send any keyboard command in this pane
Expected Behavior
Response to the keyboard command
Actual Behavior
nothing - no keyboard command is received. Then pane next to it works fine.
Also mouse scrolling works as expected. Only keyboard input is the issue.
Recovery - Alt+Pause to exit the state
The issue is seen occasionally, not easily reproduced
After hitting this once, and recovering - got issue https://github.com/PowerShell/PSReadLine/issues/3260

Does this happen if you run the same git log command with a different shell? Command Prompt, or even a 7.x version of pwsh instead/?
This gives me vibes of #13386 and #12607, but at least in the latter case, there's not usually a way to break out of it


@1aurabrown => [AsyncImageLoading] Add request logging and refactor.

This tries to replicate the format used by AFHTTPRequestLogger for SDWebImage:
2015-02-13 20:11:05.063 [NETWORK] | [Success] 200 'https://d32dm0rphc51dk.cloudfront.net/sbk-ujRq86RgJLlDoxiHDQ/tall.jpg' [0.0001 s]

2015-02-13 20:11:08.267 [NETWORK] | [Error] 403 'https://d32dm0rphc51dk.cloudfront.net/Cy1tDMUKkF_H-QN4BIDlDA/square.jpg' [0.5112 s]: Error Domain=NSURLErrorDomain Code=403 "The operation couldn’t be completed. (NSURLErrorDomain error 403.)"

I’m wondering if re-using the NETWORK category is adding too much noise or not. I can change it to e.g. IMAGE, but it is really network… Maybe this is just something to keep an eye on and change it later if needed?

In addition it slightly refactors the category by making all methods use 1 single entry point.

Taking over, she's not in.
This looks good to me :+1:

Good to merge on :green_apple:

Thanks @ortaSent using CloudMagicOn Fri, Feb 13, 2015 at 14:51,  artsy/eigen<EMAIL_ADDRESS>wrote:            Taking over, she's not in.
This looks good to me
—Reply to this email directly or view it on GitHub.

My bad!

These tests are marked as pending in #158 - merging as rosy-green.

Kk cool, sounds goodSent using CloudMagicOn Fri, Feb 13, 2015 at 16:12,  Orta<EMAIL_ADDRESS>wrote:            Merged #164.
—Reply to this email directly or view it on GitHub.


Whether to delete user from GitHub child teams

src group: no users.
dest GitHub team: no users but has a nested child team that has users.
Current behavior to sync src to dest will not remove the users from the child team.
Option 1: add feature to update memberships in child team too - issues with this is we cannot get the child team info directly from https://docs.github.com/en/rest/teams/members?apiVersion=2022-11-28#list-team-members, have to query the child team and iterate on each child team to remove the user: https://docs.github.com/en/rest/teams/teams?apiVersion=2022-11-28#list-child-teams
Option 2: avoid child teams/nested teams

Option 3: Make it a configuration option and let end-users decide 😄

Option 3: Make it a configuration option and let end-users decide 😄

It could cause conflicts and unexpected outcomes though.
for example, mappings like:
src groupA <-> dest GitHub teamA (has child team - teamB)
src groupB <-> dest GitHub teamB
It will make GitHub teamB have two different sources - src groupA or src groupB

I think it's reasonable to say that a mapping is either recursively authoritative (delete subteams) or top-level authoritative (only manage top-level)


Update sft_trainer.mdx to add note on launching DDP training

As requested here: https://github.com/huggingface/trl/issues/1303#issuecomment-1920437586
Fixes #1303

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Make Barrier type more obvious

Coverage remained the same at 35.014% when pulling 08f35bdbfca7364cfdfdf34c32768633f203ad1d on qingweibinary:qingwei/style_barrier_type into 103728a2055ea5a96958ebd6737b8286b609a9ec on binary-com:master.

Coverage decreased (-0.008%) to 35.006% when pulling e34d65ff5bcf838caad1321fa14ef7be408eda2c on qingweibinary:qingwei/style_barrier_type into 103728a2055ea5a96958ebd6737b8286b609a9ec on binary-com:master.


Exculde test files from coverage

see
 ---------- coverage: platform linux, python 3.8.19-final-0 -----------
  Name                                        Stmts   Miss Branch BrPart  Cover
  -----------------------------------------------------------------------------
  src/bids_validator/__init__.py                  4      0      0      0   100%
  src/bids_validator/bids_validator.py           97      5     42      8    91%
  src/bids_validator/test_bids_validator.py      90      0      7      0   100%
  -----------------------------------------------------------------------------
  TOTAL                                         191      5     49      8    95%
  Coverage XML written to file coverage.xml

maybe by taking the tests folder out of the package?

fair enough

@Remi-Gau If you want some more justification: https://nedbatchelder.com/blog/201908/dont_omit_tests_from_coverage.html


TypeError: Cannot read properties of undefined (reading 'pattern')

Hey, just installed  "@julr/adonisjs-prometheus": "^1.0.0", and getting this error.
node_modules/@julr/adonisjs-prometheus/build/src/collectors/http_collector.js:44
        return excludedRoutes.includes(ctx.route.pattern);
                                                 ^

TypeError: Cannot read properties of undefined (reading 'pattern')

Thanks for the issue
Fixed with version 1.0.1


Use ?raw=true suffix on images

Describe the bug
Add ?raw=true to the end of image url's so they open full-screen when clicked
To Reproduce
N/A
Expected behavior
Images open full-screen when clicked rather than in the GitHub file browser
Screenshots
N/A
Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):
N/A
Additional context
N/A

Closed by commit # 104b4a9


x/pkgsite: support standard lib documentation in dev.fuzz branch

@julieqiu requested a tracking issue for this:
We would like pkg.go.dev to support showing the standard library documentation at the tip of the dev.fuzz branch. For example<EMAIL_ADDRESS>

<EMAIL_ADDRESS>can now be viewed at pkg.go.dev.


Support choosing Prometheus sync mode between federate and remote

Support choosing Prometheus sync mode between federate and remote  …
Problem:

Remote reader mode only allow project-level Prometheus to share the
metrics from cluster-level Prometheus
Remote reader mode cannot save the namespace-related metrics from
cluster-level Prometheus

Solution:

Add prometheus.sync.mode to choose
Add a "federate" scrape job when deploying federation mode

Issue:
rancher/rancher#17390

@orangedeng , change ne .Values.level "cluster" to eq .Values.level "project".

LGTM

LGTM


Where is the code? Why still don't open source?

Hi, thanks for your interest in our project. Unfortunately, our previous submission was rejected, and it has been currently under review by RAL (with ICRA). Hopefully, we can get some feedback/comments soon. The code will be released when the manuscript receives some positive comments.

No description provided.

Hi, thanks for your interest in our project. Unfortunately, our previous submission was rejected, and it has been currently under review by RAL (with ICRA). Hopefully, we can get some feedback/comments soon. The code will be released when the manuscript receives some positive comments.


add support for $latitude and $longitude on people.set modifiers

Addresses #191

Thanks @wneild, this has been published in v0.14.0.


Observer and Membership request

I'd love to join the CC workgroup as an evangelist.

Since you've been added as an observer (thanks for following the process!), going to close this 👍


Add a blog post to async recipe

📖 Documentation
https://dev.to/gnomff_65/fp-ts-sequencet-and-sweet-sweet-async-typed-fp-5aop
It would be very helpful because it mentions sequenceT (and somewhere should be mentioned sequenceS).

We could add a section before "Work with a list of dependent tasks", something like "Working with a tuple of tasks"

That, or add a link to https://gcanti.github.io/fp-ts/introduction/learning-resources.html Blog posts


Fix mock mode

Currently, mock mode doesn't do anything. I'd like to evolve this in a few ways

make it functional again for totally offline work with stub data. Unclear if this means dummy JSON data at the request level or something more like retrofitmock. Latter is more practical, but former hooks in nicely with the next bullet. Maybe we can do both.
I think it would be really neat if recent responses for certain services could somehow be cached and included in a bugsnag reports. This would make debugging issues or crashes much easier.
services need a debug-only API hook to potentially provide their data. I'm not sure how to do this in a sane way across Gradle module boundaries.

Elaborating on the second point: if a private bug reporting mechanism was instituted in such a way that a logging interceptor was enabled for the scope of a report and sent up privately (such as to Bugsnag), that could be possible. Can't do it automatically without hurting perf, but feasible. Some services might be able to support this via unique page IDs (reddit)


Add support for input file wildcards.

Currently, config needs to be specified on a per file basis.
With this PR, the same config can be applied to all files that match a pattern.
Note that we only support simple wildcard patterns and not full regex so it's simple and intuitive.

Thanks for the review.


Fix bug always true

I do not know much English.
Always gives true, if at least one time to set true.
Thank you for your work.

That's not a bug. CoffeeScript expression:
useTabs = true if options.tabs

compiles to:
if (options.tabs) {
  useTabs = true;
}

it is BUG!!! If use your script on client side and change your tabs on true 1 TIME, tabs option always will be TRUE. Only RELOAD page fix this!

@edDimensi I now see where you're coming from. html2jade started out as a command-line tool and browser support was added later so there could be other corner-case issues like this. JS module's singleton semantic also contributed to the problem.
Anyway, other flags also had similar problem so I went ahead and fixed them all directly without merging your PR.
Thx for reporting the bug and pushing back when I made erroneous conclusions.


Article status sync bug

I’m not sure what exactly the bug is, so I’ll describe what I see.
I’m running NetNewsWire on two Macs in my office.
On Mac #1, I refresh, then read everything. Then refresh again, and there’s nothing new. Totally fine.
On Mac #2, I refresh, and I get new articles (as expected) that match what’s on Mac #1. However — they’re marked as unread, when I have read them on Mac #1.
I refresh Mac #2 again, and they’re still unread.
Then I login to the Feedbin website — and they are properly marked as read there.
It’s just on Mac #2 where they’re still marked as unread.

Ignore the links to issues 1 and 2. :) GitHub made those links.

Maybe there’s a conditional GET thing misbehaving? I haven’t dived into this area of the code, so I don’t know what it could be.
When I refresh Mac 2, the Xcode console shows me this:
2019-05-26 16:39:15.336325-0700 NetNewsWire[33609:3382387] [Feedbin] Refreshing articles...
2019-05-26 16:39:15.480284-0700 NetNewsWire[33609:3363928] [Feedbin] Done refreshing articles.
2019-05-26 16:39:15.480318-0700 NetNewsWire[33609:3363928] [Feedbin] Refreshing article statuses...
2019-05-26 16:39:15.793224-0700 NetNewsWire[33609:3363928] [Feedbin] Done refreshing article statuses.
2019-05-26 16:39:15.793264-0700 NetNewsWire[33609:3363928] [Feedbin] Refreshing missing articles...
2019-05-26 16:39:15.795556-0700 NetNewsWire[33609:3363928] [Feedbin] Done refreshing missing articles.

I think I know what happened here.   We save unread statuses for articles that we don't have an article for yet, but the processing to mark a status from read to unread depends on an article being present.
Frankly, I don't know how we haven't ran into this problem yet.  I've been bouncing back and forth between my phone and desktop and should have triggered it too by now.
I'll have a fix for it in this evening or first thing tomorrow morning.

I was successfully able to recreate this bug.
Steps:

Set refresh feeds to manual
Subscribe to a new feed on the Feedbin site
Wait for a status sync to get the new unread article statuses into NetNewsWire
Mark all as read on the Feedbin site
Wait for a status sync to get the now read articles statuses into NetNewsWire
Do a full article refresh

Before you would have the new feed articles in an unread state.  After the fix, they are in the correct read state.


CLOUDSTACK-9137 Allow domain admin to manage private gw

To create a private gateway you need a root admin account. This does not make sense, as you can do a lot more with such a powerful account. Other network related API calls can be made by a domain admin.
This PR allows domain admins to create their own private gateways.

@remibergsma Can domain admin1 delete gateway created by domain admin2? If the existing code is properly handling these scenarios then fine.

It seems this is more complex than it seemed. Since we've to put in a 'physical network id' (which is obviously owned by ROOT domain, this does not work yet.
Creating fails:
(admin) 🐵 > create privategateway gateway=<IP_ADDRESS> ipaddress=<IP_ADDRESS> netmask=<IP_ADDRESS> vpcid=cc80ae2c-c3ad-4ea3-96f4-dc40970c81e4 vlan="lswitch://uuid"
Error 531: Acct[74caa349-7f41-4e1a-b4b1-d386c0c2a1a2-rbergsma] does not have permission to operate within domain id=9c2baf29-9846-11e5-9afa-525400b8977a
cserrorcode = 4365
errorcode = 531
errortext = Acct[74caa349-7f41-4e1a-b4b1-d386c0c2a1a2-rbergsma] does not have permission to operate within domain id=9c2baf29-9846-11e5-9afa-525400b8977a
uuidList:

This is the mentioned domain id:
(admin) 🐵 > set profile root
(root) 🐵 > list domains id=9c2baf29-9846-11e5-9afa-525400b8977a filter=name
count = 1
domain:
name = ROOT

Most likely due to the physical network id. Hmm..


Add model for update for registry since it is different than its crea…

This PR updates the model for updating the registries since it is different than the model for creation registries.
This PR fixes the following issue. https://github.com/goharbor/terraform-provider-harbor/issues/134

I haven't been able to properly test it yet since I only have one instance of Harbor at the moment. It should work the way it is but I need an endpoint which accept access id and access key.
If anyone with multiple Harbor instances up could test this PR it would be appreciated.
Running it with the below code yields a 500 as it does in the GUI which is correct.
resource "harbor_registry" "main" {   provider_name = "docker-hub"   name          = "test_docker_harbor_2"   endpoint_url  = "https://hub.docker.com"   access_id     = "foo"   access_secret = "bar" }

@naitmare01 I can help you testing this, ping me on slack and we can get this PR going. You can also try to use https://demo.goharbor.io/ for testing

#293


3+1 gratis

This feature allows customers to get 1 item free when they buy 3 items.

I would like to try to implement it. So I'm assigning myself to this issue. 🙂

Most of the work is already done by @ag4ta (thanks!)
What is left is:
The 3+1 free process is not enabled yet, because we don’t have any logic to turn the promotion on/off.
(To enable it we will need to only call the enable_three_plus_one_free_process in processes/lib/processes.rb)
There is also no explicit and clear information on UI that the 3+1 promotion has been applied to the order (the total amount is just lower than the sum of all products amounts)


[Issue-11-1] Trigger agent termination and call panic if AeronClient or commit position is closed in checkForClockTick

Missing checks are implemented (see checkForClockTick) but Agent termination is not triggered. Close Agent and call panic if AeronClient or commit position is closed.
Note: In Java when an AgentTerminationException or one of its sub-classes (e.g. ClusterTerminationException) is thrown the Agent will be terminated. This needs to be emulated in go implementation as well.

Deprecated in favor of https://github.com/gravity-technologies/aeron-go/pull/31


From stweil's custom makefile - calculate MAX_ITERATIONS from EPOCHS

See https://github.com/tesseract-ocr/tesstrain/issues/157#issuecomment-615873731 for the patch

I did not suggest that modification myself because it requires an existing list.train. That means it is not a general solution, and it is very likely that people will get unexpected results.
So we need a better solution to really support epochs. Maybe all programs which use the iteration parameter (lstmtraining, others?) can be enhanced to allow either a number (for iterations) or a number followed by epochs (for epochs).

Even if not merged, keeping this code in the PR makes it easier to find :-)

Even if not merged, keeping this code in the PR makes it easier to find :-)

Please use wiki for taking notes not issue tracker or PR.

Please use wiki for taking notes not issue tracker or PR.

Pull request https://github.com/tesseract-ocr/tesseract/pull/3236 allows a more stable implementation. With that change, we either need only an update of the tesstrain documentation because a negative value for MAX_ITERATIONS is then interpreted as epochs. Or we can add an EPOCH parameter which is forwarded to a negative MAX_ITERATIONS.

Pull request https://github.com/tesseract-ocr/tesseract/pull/3236 allows a more stable implementation. With that change, we either need only an update of the tesstrain documentation because a negative value for MAX_ITERATIONS is then interpreted as epochs. Or we can add an EPOCH parameter which is forwarded to a negative MAX_ITERATIONS.

we can add an EPOCH parameter which is forwarded to a negative MAX_ITERATIONS.

I would prefer this option. Thanks!

we can add an EPOCH parameter which is forwarded to a negative MAX_ITERATIONS.

I would prefer this option. Thanks!

Closing, in favor of https://github.com/tesseract-ocr/tesstrain/pull/228

Closing, in favor of https://github.com/tesseract-ocr/tesstrain/pull/228


GEN: Add comments to the tests for clarification

Additional comments for the test loops

@rgommers FYI

Thanks @ilayn, merged.

GEN is for generated code, it doesn't mean "general". You wanted MAINT

Oh, I didn't know that. Thanks!


fix uniqueness of generics in type alias signatures

When declaring a type alias with a type variable which is used more then once, this variable will be duplicated in the signature. I moved the unique call into the getGenerics function so it is also applied when called in Elm.alias.

Good catch!  Sorry I didn't see this PR when it went up, I must have missed it.


Add tutorial for evaluating LangGraph agents

Fixes  #1635

This PR adds a detailed tutorial to guide users through building a ReAct agent using LangGraph. The tutorial also walks users through setting up an evaluation pipeline using Ragas to assess the agent's performance.

Yeah, that makes sense! Adding it to the integration/langgraph section for now sounds like a good to me.

also could you add the integration to reference section: https://github.com/explodinggradients/ragas/blob/main/docs/references/integrations.md and provide a link to that in the docs
and add the integrations md file to https://github.com/explodinggradients/ragas/blob/895f9c02ba9c6f8c20628a215ae8b718ee3f6643/mkdocs.yml#L90-L92 so that it is part of the doc site


ARROW-8113: [C++] Lighter weight variant<>

[x] Unit tests for util::Variant<>
[x] Compilation time and code size comparison to ensure this refactoring is beneficial
[x] Benchmark comparison to ensure compute and nested parquet are not impacted
[ ] More docstrings and comments

Locally (release build, no ccache):
$ ninja
ninja: no work to do.
$ export OBJS=`ls src/arrow/CMakeFiles/arrow_objlib.dir/compute/**/*.o`

$ git checkout master && rm $OBJS && time ninja $OBJS
real    0m16.918s
user    2m41.702s
sys     0m2.495s

$ du -h --total $OBJS | tail -n 1
total 7.3M

$ git checkout 8113-Implement-a-lighter-weigh && rm $OBJS && time ninja $OBJS
real    0m14.363s
user    2m19.939s
sys     0m2.125s

$ du -h --total $OBJS | tail -n 1
6.6M    total

drive by comment.  just want to make sure we aren't using the same idioms for variant (i.e. they are compatible with C++ std)?

@emkornfield I'm implementing a subset of std::variant's functionality but all members which are present are compatible; if we switch to using std::variant at some point no code will break. We will need to keep the mutable-pointer visit overload since that's non standard, but IMHO that's acceptable overhead

@bkietz presumably this yields smaller code size, too?

Updated description with build times and code sizes for a release build

This seems to speed up the compute layer a bit.

Before:

ArrayArrayKernel<Add, Int64Type>/32768/100       3781 ns         3780 ns       738685 bytes_per_second=8.07385G/s items_per_second=1083.65M/s null_percent=1 size=32.768k

After:

ArrayArrayKernel<Add, Int64Type>/32768/100       3615 ns         3614 ns       777365 bytes_per_second=8.44344G/s items_per_second=1.13326G/s null_percent=1 size=32.768k

@bkietz Do you plan to update this?

@pitrou yes but not soon

Rebased, I'm writing some micro-benchmarks.

AppVeyor seems to indicate that MSVC isn't picking up / implementing the copy constructor correctly :-(

@bkietz You may want to review the changes I've done. I think only docs and comments remain to be done.

I added some docstrings. I think this is ready now.

Hmm, I forgot to push some changes...

@pitrou thanks for picking this up! Looks good to me

Ok, I'll rebase a last time to make sure this doesn't break anything.

I don't know why but It seems that this causes g++ 9 crash:
https://github.com/ursa-labs/crossbow/runs/1522097163#step:4:1237
during GIMPLE pass: pre
In file included from /usr/include/c++/9/functional:59,
                 from /arrow/cpp/src/arrow/vendored/string_view.hpp:1480,
                 from /arrow/cpp/src/arrow/util/string_view.h:25,
                 from /arrow/cpp/src/arrow/buffer.h:31,
                 from /arrow/cpp/src/arrow/array/data.h:26,
                 from /arrow/cpp/src/arrow/array/array_base.h:26,
                 from /arrow/cpp/src/arrow/array/builder_binary.h:30,
                 from /arrow/cpp/src/arrow/compute/kernels/codegen_internal.h:26,
                 from /arrow/cpp/src/arrow/compute/kernels/codegen_internal.cc:18:
/usr/include/c++/9/bits/std_function.h: In static member function 'static void std::_Function_handler<void(_ArgTypes ...), _Functor>::_M_invoke(const std::_Any_data&, _ArgTypes&& ...) [with _Functor = arrow::compute::internal::MakeFlippedBinaryExec(arrow::compute::ArrayKernelExec)::<lambda(arrow::compute::KernelContext*, const arrow::compute::ExecBatch&, arrow::Datum*)>; _ArgTypes = {arrow::compute::KernelContext*, const arrow::compute::ExecBatch&, arrow::Datum*}]':
/usr/include/c++/9/bits/std_function.h:298:7: internal compiler error: Segmentation fault
  298 |       _M_invoke(const _Any_data& __functor, _ArgTypes&&... __args)
      |       ^~~~~~~~~
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-9/README.Bugs> for instructions.
make[2]: *** [src/arrow/CMakeFiles/arrow_objlib.dir/build.make:1610: src/arrow/CMakeFiles/arrow_objlib.dir/compute/kernels/codegen_internal.cc.o] Error 1

We can reproduce this on local:
(cd cpp/examples/minimal_build && docker-compose build static && docker-compose run --rm static)

https://issues.apache.org/jira/browse/ARROW-10867 may be related.