[feature] "Periodic" mode for tf.pad

System information
N/A
Describe the problem
If I have a matrix
[[1, 2, 3],
 [4, 5, 6],
 [7, 8, 9]]

It would be nice if I could use something like tf.pad( ... 'PERIODIC') to pad around the dimensions to get a matrix like
[ [9, 7, 8, 9, 7],
  [3, 1, 2, 3, 1],
  [6, 4, 5, 6, 4],
  [9, 7, 8, 9, 7],
  [3, 1, 2, 3, 1] ]

While there seems to be a work around by manually slicing and joining, this would seem nifty to have in tf.pad already to make expressions that assume periodic boundary conditions a bit easier.
Source code / logs
N/A

Hi I would like to work on this. Can I take up this issue?

Hi, I don't know whether the issue is already resolved, but if not I would like to give it a try. I was thinking of the following solution:

Of course, adoptions and tests need to be made before the code can be implemented in TensorFlow. I would like to take up and finish the issue if still needed? This is my first time contributing so if you have some tips for me I would love to hear them.

This is a stale issue with no recent activity. I am closing this issue. Check the recent TF versions and open a new issue/feature. Thanks


Extra command args for master + Using basic auth causes failure for readinessProbe

Hello,
I noticed a couple items when using this chart, let me know if they should be broken up into two separate issues, but for now...

in the values.yaml, when I have args_include_default: true, and I want to include extra arguments in args: [], it ends up removing the default arguments when I really expected it to add to them. I can see in the template how the if-condition is causing that, but wondering now if that is intended behaviour, or instead should be changed so that args are added above the default args.

When I enabled basic authentication on the UI, which I performed just by passing a web-auth arg to master, the deployment failed due to
Readiness probe failed: HTTP probe failed with statuscode: 401

Now, of course  one can enable basic authentication on a readiness probe, but where our chart is basically an umbrella chart pointing to this one, I don't have as much control. It would be nice if we could enable basic auth more concretely through the  values.yaml file, and the template know when it is enabled and adjust the readinessProbe accordingly. Let me know if there's another way to get this working.
Thanks

Hi @yosri2005

I think args_include_default is intended to be used like "use the default args" or "you provide all args yourself". Not a mix. So if you want extra args then you must provide them all in that case.
I see. I think it might be worth adding all probes to values.yaml or adding an option to disable probes completely. This would solve the problem for you.

I don't have as much control

Of course you do, you can make a PR to this chart 🙂

It would be nice if we could enable basic auth more concretely through the values.yaml file, and the template know when it is enabled and adjust the readinessProbe accordingly. Let me know if there's another way to get this working.

Sounds great, open a PR!

Thanks @max-rocket-internet, I will look into it!

@max-rocket-internet Pull Request 199 is now open for you review. Thank you.


Simplify core package

Description of the change

Rename ResourceData and ResponseData as SchemaReader and SchemaWriter, respectively.
Rename NewResourceData and NewResponseData as SchemaReaderFactory and SchemaWriterFactory, respectively.
Provide a default implementation for CreateContext, ReadContext, UpdateContext and DeleteContext operations in core/default_context_handlers.go. It will greatly simplify how to write resources and datasources to standard API that is comprised of POST, GET, UPDATE and DELETE for the respective CRUD operations and that also just return a simply ID after the create (POST) call.
Use the appropriate Terraform logging framework by replacing calls to log.Printf("[DEBUG] ...") by calls to tflog.Debug.
Migrate the following resources and data sources to the new proposed framework:

cyral_integration_hc_vault
cyral_saml_certificate
cyral_integration_slack_alerts
cyral_integration_microsoft_teams
cyral_repository_user_account

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] Jira issue referenced in commit message and/or PR title

Testing
Testing report:
go clean -i github.com/cyralinc/terraform-provider-cyral/...
rm -f terraform-provider-cyral_v4.7.2
rm -rf ./out
rm -rf ~/.terraform.d/plugins/local/terraform/cyral/4.7.2
gofmt -w .
mkdir -p out/
# Build for both MacOS and Linux
GOOS=darwin GOARCH=amd64 go build -o out/darwin_amd64/terraform-provider-cyral_v4.7.2 .
GOOS=darwin GOARCH=arm64 go build -o out/darwin_arm64/terraform-provider-cyral_v4.7.2 .
 You can start reviewing and providing feedback as you please.


account requirement and instructions

This a work in progress. It looks like there is some linting(?) being done, but I don't know if it's coming from me or Front End Foxes.
@MicheleCynowicz Can you help me figure this out?

This is interesting @artikgupta 🤔  it looks like this might be coming from some automatic linter you have running in your IDE (that's your code editor application, or Integrated Development Environment).
What IDE are you using? I am usually using VS Code when I work, and it is possible to have automatic linting installed with a VS Code extension.
We probably should add our own linting file and linting rules to this repository so that changes we don't want from others' IDEs will be marked as unable to merge. In the meantime we can review your IDE setup and I can show you how to undo these types of changes during our next Pair Programming session.

I am using vs code. Looking forward to the next session. Thank you.

This PR addresses the acceptance criteria for #140
@MicheleCynowicz ready for review

This looks good Arti! Thanks for this. I am going to leave this PR open for a short while so I can compare how the page renders with your linter's added features. I like some of the things that have been added, but I need to make sure Vuepress does the right thing with them.

This PR had lots of issues so I have decided to raise a new PR (#178) to address the same issue (#140).


Only build pushes to master on Appveyor

To mirror Travis config, refs https://github.com/atom/atom/pull/8110

Hmmm, weird that this didn't kick off an Appveyor build – does that config not mean what I think it means? :disappointed:

The way that reads to me is that it only builds master, since this isn't on master yet ... it won't kick off an Appveyor build?

That's true for branches, but I was expecting Appveyor to still build PRs with this config like Travis does. After looking into it more, it seems that we don't have the setting for building PRs enabled on Appveyor itself (see http://help.appveyor.com/discussions/questions/203-auto-run-tests-on-pull-requests).

Yo @mnquintana, whats the status of this?

So I think someone with admin access on Appveyor needs to flip the switch for allowing builds on PRs

@mnquintana I updated that setting :+1: Wanna make a dummy push to make sure this works?

@joshaber Looks good, thanks!


Sources: add https://bitaps.com/api/

Custom but well documented APis, blocks with no txids

withdrawn


Resurrect HTML5 platform, add it to CI (no rendering yet)

In this PR:

Fix new Mutex implementation to build properly with NO_THREADS.
Resurrect old dummy rasterizer, still missing bunch of feature (notably export related stuff/textures/meshes), can now build and run simple project.
Fix Javascript platform after PoolVector removal (and now uses dummy rasterizer until GLES2 is back).
Add JS template (release) to CI, using latest emscripten.

Note: I plan to rebase my Feb work on threads, closure compiler, and engine startup on top of this PR.

CC @RandomShaper for Mutex changes.

Thanks a lot!


Homepage and License links to QuickLook

Hey there,
the "Homepage" and "License" links on the settings page link to QuickLook.
https://github.com/files-community/Files/blob/f7ce0ce12947886a3c281145ba14ffdece40c63c/Files/Views/SettingsPages/About.xaml#L215-L225

@d-Rickyy-b We're having a little trouble understanding this issue, can you add more details about the issue you're having?

Hi @yaichenbaum - I am very sorry. I totally missed that the links at the bottom of the about page are actually related to the QuickLook project. I just expected to find a link to the "Files" homepage. My bad!
It's just now that I saw that there's actually "QuickLook" prepended to it.

@d-Rickyy-b Thanks for the update!


Re-visit plugin registration / interface

Describe the solution you'd like:
Currently the identity and cluster provider plugins are created and registsred as part from init functions and imports. For example:
https://github.com/fidelity/kconnect/blob/main/pkg/plugins/identity/saml/saml.go#L53
This has the effect that the plugin is created before the main function is run and so the logger isn't setup from the command line arguments by then. This means we end up with code in each of the exported functions to ensurethe logger is setup:
https://github.com/fidelity/kconnect/blob/main/pkg/plugins/identity/saml/saml.go#L75
This isn't good as its easy to forget to add it and really it should be done in 1 place.
We have 2 options:

Delay the creation of the plugins until they are needed. This means changing the plugin registration mechanism.
Add a function to the plugin interface called Setup/Initialize that is called by the registry when you Get a plugin: https://github.com/fidelity/kconnect/blob/main/pkg/provider/registry.go#L71

May be influenced by the discussion of #155

This has been done via #291


Re-adding protobuf java subpackage and adding check section

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

Adds back protobuf java subpackage, as it will be required for future packages such as Hadoop. As well as adds check section that runs built-in unit tests for the protobuf make and java subpackage.
Change Log

Re-added back protobuf java subpackage. As it will be required for future packages such as Hadoop
Added check sections that runs main make tests and also java subpackage tests

Does this affect the toolchain?

NO
Test Methodology

Local
Pipeline build id: Official pipeline build

Sorry I have not done any updates on this. This PR is not ready in the current state, now that we determined that we cannot vendor maven m2 as it might contain binaries. I will update this PR once we add maven tools to allow to provide dependencies via system instead of using m2 cache.


Some theory and examples for async client-side fetching

I've seen a lot of questions about this problem and none of the solutions I've seen out there quite address it in a flexible enough manner for my purposes, so I decided to do this little write-up. If nothing else, hopefully it generates some useful discussion.
Disclaimer: This is an approach that worked for me, I don't claim it's perfect, correct or that it addresses your particular needs.
The problem
You're building an app that needs to fetch some data before it renders the routes. This is simple if you don't care about transitioning down the path before this data is fetched. In such case, you can just use componentDidMount (or use Rx to react to something like redux-router state change) to run whatever methods are needed. The server-side aspects of this have been covered endlessly and the match solution works well.
Let's say, however, that you do care about transitions. I'm currently working on a universal React-based e-commerce website where the data has to be fetched first before the previous components unmount. The site should also be capable of displaying a global loading indicator if any data dependencies are being fetched.
A more relatable example: GitHub project view. The page transitions happen after page data is loaded — while displaying a global loading indicator — not before.
The theory and the potential solution
The react-router render tree always starts with one component, this means that we can nest our actual routes within any number of components that don't have a path on them and that render absolutely no markup (but rather simply this.props.children).
By creating a top component that sits below the router but above our app, we can use componentWillReceiveProps and shouldComponentUpdate to isolate our app from router changes while letting it go about its business undisturbed.
Furthermore, this also means you're free to pass down new properties that will, for example, show a global loading indicator (or progress bar). Because the code relies on componentWillReceiveProps, this means that it also won't run on the back-end. It could probably be expanded to support server-side but I already had a match based solution that worked for me.
Now, for some sample code:
import React, { Component, Children } from 'react';

import _map from 'lodash/collection/map';
import _isEqual from 'lodash/lang/isequal';

export default class TransitionManager extends Component {
  static propTypes = {
    children: React.PropTypes.element.isRequired
  }

  constructor(props) {
    super(props);

    this.state = {
      isAppHydrating: false
    };
  }

  // this basic version only re-renders if we're done hydrating
  shouldComponentUpdate(nextProps, nextState) {
    return !nextState.isAppHydrating;
  }

  // 1. Check that the new location is actually different and requires our intervention
  // 2. Get all dependencies and run them, passing in whatever properties you need.
  //    Keep in mind, these are static functions that don't have any awareness beyond
  //    what you pass to them.
  componentWillReceiveProps(nextProps) {
    if (_isEqual(this.props.location, nextProps.location)) {
      return;
    }

    const promises = _map(
      getAllDataDependencies(nextProps.children),
      fetchData => fetchData(nextProps, this.props)
    );

    if (promises.length > 0) {
      this.setState({
        isAppHydrating: true
      });

      Promise.all(promises).then(this.willTransition.bind(this, nextProps));
    } else if (this.state.isAppHydrating) {
      this.setState({
        isAppHydrating: false
      });
    }
  }

  // For cases where the user presses another link before we're done,
  // we need to check that our location data is the most recent.
  // This could be avoided by using promises that support cancellation.
  willTransition(transitionProps) {
    if (!_isEqual(this.props.location, transitionProps.location)) {
      return;
    }

    this.setState({
      isAppHydrating: false
    });
  }

  render() {
    return this.props.children;
  }
}

// Iteration here is more complex due to these being actual elements rather classes.
// If you're using redux-router, you'll also need to test for WrappedComponent.
function getAllDataDependencies(children) {
  return iterate(children, []);
}

function iterate(children, accumulator) {
  Children.map(children, child => {
    if (child.type.fetchData) {
      accumulator.push(child.type.fetchData);
    }

    if (child.props && child.props.children) {
      iterate(child.props.children, accumulator);
    }
  });

  return accumulator;
}

Hopefully the comments made that clear enough to parse. From this base state, you could further extend the class by storing a copy of old this.props.children in the app state and using cloneElement to generate a version that passes new props down to the component — these could contain things like data loading progress status or simply information about the transition about to happen.
Note that if you're not doing server-side rendering then you will need to make sure to update this code to actually run on componentWillMount, otherwise you will not get any initial data. You'll probably also want to make other tweaks to enable loading indicators, etc.
Further Disclaimer: It's possible this breaks some internals of react-router. I haven't found any issues yet but I haven't used the full api to be completely certain.

"You're building an app that needs to fetch some data before it renders the routes. "
So what is it people call "isomorphic", and what's the point of doing server-side rendering, if there's no data in it ?

Well this problem probably goes beyond react-router. To accomplish this whole thing you need some state management and something that tells you what needs to be updated.
This something might be Relay, but I haven't tried it yet.
By the time I simply listen for route change and if route changes that I request server for new page but instead getting HTML I ask server for JSON only.
You may take a look if you like.
Server side, notice routes /:date and / and sendState function.
Listening for location change on client and most important is fetching new state from server on location change

that depends on architecture yep but the concern seem quite recent;
well so far never read that much about it
hope it'll get more attention

@bbnnt wait mate, seems you don't understand.
Once you send http request to an URL data are being fetched on the server and with this data your default app state is being rendered.
So there are data in the app, that's purpose of server side rendering. We wipe out need for ajax call for data once is page firstly rendered.
Just like Gmail has this progress bar when you hit refresh, with react, there's no need for this anymore. With data got from database or whatever, you feed react that renders html for your app and app state in JSON you send along with HTML to the browser.
Look at project I referenced above. You see everything there.

Nope fore sure I don't fully understand what's going on :/
Let me ask you :

"We wipe out need for ajax call for data once is page firstly rendered." : you never fetch the server again ?
"Just like Gmail has this progress bar when you hit refresh, with react, there's no need for this anymore. " : new mails will come up your app automatically ?

you do fetch server again, when you need it of course (e. g. you filter over emails, you go to different page). On the contrary, with angular you mostly make ajax call once javascript loads and in that ajax you receive state (data - emails list, filters - list, user object...) of the app.
if Gmail used server-side rendering than you would received rendered HTML of the app and somewhere in HTML you'd get <script>window.initial = "//state object here with emails and everything"</script> which you may use further in your app.

My concern is about his quote "The site should also be capable of displaying a global loading indicator if any data dependencies are being fetched."
Isn't he talking about this "gmail hit refresh" ?

Practically yes.
He wants to display progress bar when there's some Ajax fetching, but is has nothing to do with refreshing of whole page.
But in Gmail case. It has to fetch data using Ajax on every page refresh, with server-side rendering, you don't have to fetch anything to render app, as stated above.

@bbnnt A hypothetical lifecycle of an isomorphic app would go something like this:

Server receives a request for a path
We use match to get the correct render tree
Get data based on the render tree, where each route might have its own dependencies
Send fully rendered HTML together with the initial state to the client
<Link> is pressed by the user and triggers a new route
react-router does its things and passes new props to its render tree
TransitionManager component, as described above, intercepts and delays rendering new components until all data dependencies have been retrieved.

@vojtatranta I believe your solution displays a loading indicator but it also renders the new state of the app, without the new data. Correct me if I'm wrong on that.

@apapirovski nope, I mean exactly same this as you.
I used Gmail as example of app that is not rendered on the server.

@vojtatranta I understand that you're rendering on the server but in your app, when history listener is triggered, it initiates data fetch. That's all fine but it doesn't stop the new routes from being rendered while the data is fetched.
Imagine your component had another route (say About) which rendered a completely different component (StaticPage) from a different state (Static). Now the Gallery component would transition out and the new component would transition in, but it would have no data to show and so would just show a loading indicator.
The point of the middleware component is to avoid that blank render because in some apps it's undesirable. That's why I gave the example of GitHub — when you switch between views, it fetches the data while displaying a loading indicator over the current page.

@apapirovski Ahaaa,
I see. Yup, that is true.
In this case I rely on Redux, because since the state is not changed (router objects are just mutated and redux ensures implementation of shouldComponentUpdate), the whole app does not rerender.
But otherwise, you are right.
I haven't yet used TransitionManager, looks bit too complicated for simple task like this.
I would also recommend you to use some kind of state managing library (redux, some flux) which would solve this just like in my case.
You would also got rid off setState calls, which would make everything more clear

@vojtatranta I do use Redux. The solution above is generalized for people who don't. Redux or the redux-router don't solve the problem.
Think about it like so:

You have a route component App with path /
You have 3 sub-routes each rendering a separate component with a separate store
You're fetching data from more than one service (but even if it was one, doesn't matter)

Here are the issues:

You need a Promise that tells you whether ALL of your dependencies down the new render tree have been fetched. It's not enough that the app state has changed (something else might've changed, not the exact stores we need), it has to be fully hydrated.
You need to be able to pass new properties such as isFetching down the render tree, which means you need to be able to clone the old render tree, so you avoid rendering the new components that react-router wants to render.
And finally, we want to allow our user to continue interacting with our app. Blocking shouldComponentUpdate in our App component means that we might not let through their interactions while the data is loading.

Which is why we abstract the solution above the App — it gives us more flexibility and keeps our App pure. TransitionManager can be pulled out of the routes at any time without impacting the rest of the app.

To those issues:

I solve this by creating action type STATE_CHANGED which I implemented on stores where I knew that they were affected by url change,  this works nice but causes many app rerenders (which I have in TODO)

Otherwise you are right I am curious about any full-featured example with TransitionManager, would be great if you shared one. Thanks.

Actually this turns out to be very interesting problem. I would like to know some other opinions @knowbody, and maybe someone from redux community...

I don't have a full redux implementation that I'm happy with but in my head it goes something like:

dependecy decorator to define actions that need to happen before render
TransitionManager to crete a wall between the router and the app (and only allow router to impact the app when it's ready for it)
Middleware that tracks the lifecycle of the transition, that way we can avoid stupid stuff like cloneElement and just listen to the transition store where necessary.

Something like that. To make it fully featured, I think the dependency probably needs to specify whether it's blocking or not, that is whether the app can render without it.

@apapirovski a route change that would behave like a promise ?

BTW, I have a separate implementation of async data fetching in a routing context for react-router-relay: https://github.com/relay-tools/react-router-relay/blob/v0.6.2/src/Container.js#L59-L64 (sorry, this code snippet isn't going to make as much sense as it might if you haven't seen the code for Relay.RootContainer).
It's quite possible that whatever I have in the Relay context will have to stay separate, just because Relay has its own semantics around loading states, and it'd make more sense for react-router-relay to stick to those than to general React Router async data handling, but I thought it was pertinent to this discussion.

Oops hit tab once too many times.

@apapirovski Any problems with your solution so far? I am very excited about your solution and plan to use it for my project :)

I'll ask the same question as @imouto1994 to @apapirovski. Becuase it's difficult to do the same thing that was so easy in the earlier version of react-router, and this seems to be the best solution I can think off...

No problems with it although I'm using redux-router and have switched over to a middleware approach.

Are you following the way of react-redux-universal-hot-example ?

I have't looked at their implementation but I assume it's similar. I don't think there's much flexibility in terms of how you do it if you're using middleware.

@apapirovski Do you mind sharing about how you tackle the problem that fetched data before navigation complete might crash the current route if it also uses same data with the next route?

Assuming you're using Flux or redux, you could just structure your stores in such a way that data is tied to a key, which could be a param or a slug or something else unique to each path. Then the component would only update when both conditions are met.
shouldComponentUpdate would also work but would have the side-effect of not allowing any re-renders on that component, even if they're not related to the fetching.

This one worked for me:
import React from 'react';
import Actions from '../../actions/Actions';
import isEqual from 'lodash/lang/isEqual';

const ComponentProvider = React.createClass({
    propTypes: {
        Component: React.PropTypes.func.isRequired,
        initialData: React.PropTypes.object
    },

    getInitialState() {
        return {
            isAppHydrating: false,
            data: undefined
        };
    },

    // re-render if we're done hydrating
    shouldComponentUpdate(nextProps, nextState) {
        return !nextState.isAppHydrating;
    },

    componentWillReceiveProps(nextProps) {
        if (isEqual(this.props.location, nextProps.location)) {
            return false;
        }

        if (nextProps.Component.fetchData) {
            this.setState({ isAppHydrating: true });
            this._addLoading();
            this._getDependencies(nextProps);
        }
        else if (this.state.isAppHydrating) {
            this.setState({ isAppHydrating: false });
        }
    },

    _getDependencies(transitionProps) {
        transitionProps.Component.fetchData(transitionProps.params)
            .then(data => {
                this._saveNewData(transitionProps, data);
            })
            .catch(nodata => {
                this._saveNewData(transitionProps, nodata);
            });
    },

    _saveNewData(transitionProps, data) {
        if (!isEqual(this.props.location, transitionProps.location)) {
            return false;
        }
        this._removeLoading();
        this.setState({
            isAppHydrating: false,
            data: {
                [transitionProps.Component.displayName]: data
            }
        });
    },

    _addLoading() {
        Actions.toggleLoading(true);
    },

    _removeLoading() {
        Actions.toggleLoading(false);
    },

    render() {
        const { Component } = this.props;
        return <Component {...this.props} data={this.state.data || this.props.initialData} />;
    }
});

export default ComponentProvider;

https://github.com/rackt/async-props

@apapirovski I know this issue is old, but did you get an example working where the old route hangs out until the promises are resolved?

@apapirovski i'm also seeing the app scroll to the top when the transition starts, any ideas on that?

apapirovski did you get a redux version of this working? I have had success with just setState, but integrating it with redux has proved to be more challenging than I thought.

for anyone landing on this from google, I have built a module for redux usage that fits the bill!
https://www.npmjs.com/package/react-redux-transition-manager


Add support for Windows files and services to TestInfra

This PR, which also contains changes in https://github.com/philpep/testinfra/pull/480 which we needed to get testinfra to work on windows, adds support for Windows files and services, allowing tests to be written against these objects.
I was having trouble running the tests (they seem to require a French locale), so I'm hoping Travis will check this PR

@fatal-exception @philpep What is the status with this PR?

@fatal-exception @philpep any progress on the PR?

@tdas3001 I've no time and no knowledge to review or maintain this. So unless there's a new maintainer able to handle it, windows support will remain minimal.


CI lint issues because golangci-lint is updated to v1.16.0

https://github.com/kata-containers/tests/pull/1427

/home/travis/gopath/src/github.com/kata-containers/agent
/home/travis/gopath/src/github.com/kata-containers/agent/pkg/types
/home/travis/gopath/src/github.com/kata-containers/agent/pkg/uevent
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/client
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/grpc
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/mockserver
grpc_test.go:872:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_CPU, 100, 120},
		^
grpc_test.go:873:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_FSIZE, 100, 120},
		^
grpc_test.go:874:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_DATA, 100, 120},
		^
grpc_test.go:891:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_CPU", 100, 120},
		^
grpc_test.go:892:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_FSIZE", 100, 120},
		^
grpc_test.go:893:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_DATA", 100, 120},
		^
The command ".ci/static-checks.sh" failed and exited with 1 during .
Your build has been stopped.

Maybe we should create a docker image containing all the golang static checkers so that their versions are managed by ourselves.

Maybe we should create a docker image containing all the golang static checkers so that their versions are managed by ourselves.

We have version control for golangci-lint in test now.
https://github.com/kata-containers/tests/blob/0c8be9468395da61ec4ea672bdc003be8a10a350/versions.yaml#L55


Problem with outside visibility

I'm using this ftp server on my android box using Termux.
Using the LAN, my ftp server works great. But when I'm accessing from outside of my LAN it doesn't work. I got the message Socket couldn't write, but all my permissions of files and directories are 777, and I think that I got an 5000ms timeout error once in the past.
One thing to note is that my ls it is not on /bin/ls but it is on /data/data/com.termux/files/usr/bin/ls.
So here it is my program:
process.chdir(__dirname);

const FtpSvr = require('ftp-srv');
const ftpServer = new FtpSvr('ftp://<IP_ADDRESS>:3000', {anonymous: true, pasv_range: 8000});

ftpServer.on('login', ({connection, username, password}, resolve, reject) => {
	if(username === 'daniel' && password === 'ola') {
		resolve({root: './data/'});
	} else {
		resolve({root: './data/anonymous'});
	}
});

ftpServer.listen();

and here is an image of an outside test of my server using https://ftptest.net/:

Can someone help me?

It appears the FTP server is timing out waiting for a passive connection (https://github.com/trs/ftp-srv/blob/master/src/commands/registration/list.js#L43). If a connection is not established, you will get the error 425 No connection established.
Have you forwarded the pasv_range ports? With your option, it will attempt to use ports 8000 - 65535.

I forwarded the pasv_range ports and it solved. Thank you


vimPlugins.lispdocs-nvim: init at 2021-01-26

Motivation for this change
Add https://github.com/tami5/lispdocs.nvim
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111434 run on x86_64-darwin 1

1 package built:

spacevim

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111434 run on x86_64-darwin 1

1 package built:

spacevim

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111434 run on x86_64-linux 1

2 packages built:

spacevim
vimPlugins.lispdocs-nvim

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111434 run on x86_64-linux 1

2 packages built:

spacevim
vimPlugins.lispdocs-nvim


Is waifu2x-caffe 32-bit version available?

Hello,
My system is win7 32-bit version, an old computer.however, I still wish to run waifu2x-caffe program in my computer.
Is it possible to publish 32-bit version?
Thx.

I very much doubt that's technically possible. Doing an upscale by CPU on my machine (3 times upscale, Level 2 denoising...), takes from 2 to 4GB of RAM alone. A x86 (32-bit) OS can only handle 4GB of memory, including VRAM (GPU Memory). So, unfortunately, it's impossible to run on 32-bit right now. And, no, the program won't limit its memory use if it can't: it just crash if it runs out of RAM.
So yeah.

Try looking on https://code.google.com/archive/p/2dimagefilter/downloads


Tests configuration changes

The key for choosing specific tests today has the same name as the test.
We got feedback that this is confusing and inconsistent between tests.
# Current format:

        - elementary.all_columns_anomalies:
            all_columns_anomalies:
              - null_count

# Suggested format:

        - elementary.all_columns_anomalies:
            monitors:
              - null_count

Also - we should accept the param 'all' as another option to activate all the monitors, as this is more intuitive than all by default.

hey @Maayan-s is this something that is open for contribution? I would be interested in helping with this or another issue, do you have any advice on where to start with this enhancement?

Hi @Ecalzo! we are defiantly open for contributions and I'd love to help with guidance and questions (also feel free to reach out anytime here or on Slack). This specific issue introduces a breaking change to the way users configure monitors and therefore requires some extra thinking on how to keep backwards compatibility. We will think about it in the next few days and document the conclusions here.
In the meantime, here are some additional issues that could be a good fit and in similar areas in the code (both have detailed design descriptions) -

Custom anomaly threshold support
Enable passing timestamp_column as a test param

Once you feel comfortable with the changes I'd be happy to help with opening a PR and running the tests.
Thanks!


Unblock perfdash upgrade

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR is for unblocking the perfdash upgrade.
Which issue(s) this PR fixes:
Fixes #1792

Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@mm4tt

/ok-to-test

/lgtm
/approve

Adding @jprzychodzen, the current scalability oncall.
Kuba, could you push the new perf-dash version once this PR merges?

Sure, I will push new perf-dash.
Thanks for this change!

FYI - new perf-dash is up and running.


Add support for downloading with apt-get in Ubuntu

hi @OrBin ,
your project is cool, and i'm happy to contributing in!

Closed in #11. Thanks @mrunderline.


is ubcbot/autotest working correctly?

I am unable to increase my grade above a 30%.
I cannot find any unhandled errors, all promises with a then have a catch, all awaits are in a try catch block.
Please help!
Thanks.

Yes, autotest is working. This is not the right place for support on your tests though. I would clone your repo and try running the tests there. The first time you do it nothing will work, because your implementation depends on local state the autotest server won't have.

Can you look at the logs for commit: 3b2f7815bcc4086e6971a1abb5a47f42338d0e90 and help me figure out why I am not getting "Container did not complete on time"? Thanks, Corey


NIFI-5280: Preventing duplicate bulletins

NIFI-5280:

Preventing duplicate bulletins that are registered under different contexts (e.g. Controller and Component).

@mcgilman thanks, was able to verify that the logic makes sense, all looks good. +1 merged to master.


Does it support converting to ONNX format models？

I use C#，
Does it support converting to ONNX format models？
Or how to use C # to call this model？

Instead of converting from faster-whisper format, you can directly convert the pytorch models to onnx format.
For example, if you want to convert large-v2, you can use the workflow mentioned in this page on https://huggingface.co/openai/whisper-large-v2
https://huggingface.co/docs/transformers/en/serialization#exporting-a--transformers-model-to-onnx-with-cli

thank you,I try later

Hey @lmxin123, did you try? How did it go?

Hey @lmxin123, did you try? How did it go?

Not yet, I haven't found a way yet


Find out gaps between Kong 3.0 features and KIC expressions

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
Kong 3.0 release included several improvements and new features, especially the new DSL based router. We need to investigate on what features are available in Kong, but could not be expressed using KIC. These gaps will force users who want to use the features to call Kong admin API directly, instead of using KIC.
Proposed Solution

find out what features in Kong 3.0 could not be expressed using KIC CRDs (KongIngress, KongPlugin,...)
find out how to use expression based router to translate path matches in resources having path match, e.g: Ingress, HTTRRoute

Additional information
No response
Acceptance Criteria

[ ] We have a document to record what features in Kong 3.0 are not supported in KIC, and brief proposals to implement them
[ ] We have method to translate path matches in k8s resources(Ingress,HTTPRoute,...) to expressions of Kong 3.0 router

replaced by https://github.com/Kong/kubernetes-ingress-controller/issues/3730


HIVE-28009: Shared work optimizer ignores schema merge setting in case of virtual column difference

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

@kasakrisz, could we please add a test for this


the host lazy load public suffix info when needed

Lazy load public suffix list info to allow reducing relying on public suffix cache
see https://github.com/thephpleague/uri-components/pull/11#issuecomment-362548228

Hi, any progress? Same issue with payum descibed by @pamil

sorry for the delay .. I'll release a patch this week if I have time ... too much work not enought time 😢

@piotrantosik version 1.7.1 is released 🎉

Thanks, tested and works perfectly


Pass Kanister server info to kando for communication

Change Overview

Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

#XXX

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Addressed by other commits!


XFC0000	Cannot resolve type ":AdvancedEntry"

I could not find any information about this, I am using the example available at https://enisn-projects.io/docs/en/uranium/latest/themes/material/components/TextField
And when I try to compile or run I get the following error:
Severity	Code	Description	Project	File	Line	Suppression State
Error	XFC0000	Cannot resolve type ":AdvancedEntry".	TestProject	F:\Projects\TestProject\TestProject\Features\Login\LoginView.xaml	28

Which goes to
<material:TextField Title="Email:" AllowClear="True"
                    Icon="{FontImageSource FontFamily=FASolid, Glyph={x:Static fa:Solid.Envelope}}">
    <validation:RequiredValidation />
    <validation:RegexValidation Pattern="{x:Static input:AdvancedEntry.REGEX_EMAIL}" Message="My Error Message!" />
</material:TextField>

Line 28 being:
<validation:RegexValidation Pattern="{x:Static input:AdvancedEntry.REGEX_EMAIL}" Message="My Error Message!" />

And I have the following namespaces defined
xmlns:material="clr-namespace:UraniumUI.Material.Controls;assembly=UraniumUI.Material"
xmlns:validation="clr-namespace:InputKit.Shared.Validations;assembly=InputKit.Maui"
xmlns:fa="clr-namespace:UraniumUI.Icons.FontAwesome;assembly=UraniumUI.Icons.FontAwesome"

What am I doing wrong here? I cannot find anything on it.

Hi @tekinomikata
Sorry, it's my bad. There is a missing information on documentation. REGEX_EMAIL comes from a different namespace.
Can you please try adding the following namespace to your page:
https://github.com/enisn/UraniumUI/blob/1c8e59451b561f0e15e5de0baaafb06b83438374/demo/UraniumApp/Pages/InputFieldsPage.xaml#L5
Or you can remove Email validation rule since it's not inluded UraniumUI. That validation comes from InputKit.


Update docs for Swift interceptors

Updates the documentation to reflect the changes in https://github.com/connectrpc/connect-swift/pull/186.
The copy matches Interceptor.swift's inline documentation from that PR with the addition of an auth example here.

@eseay can you please take a look at this when you get a chance?

LGTM to me, but @eseay's opinion will probably be more helpful :)

Thanks for the reviews/feedback @akshayjshah @eseay!


Modify design space during optimisation

I am trying to optimise a set of integer parameters for a deep learning model using GPyOpt, by minimising the test loss of a trained model constructed with those parameters. In some situations the loss consistently evaluates to NaN, and I would like to exclude these from the search space since they inconveniently occur close to where the optimum is thought to be.
In Design_Space::indicator_constraints appears to build a hypercube of the design space and mark any points at which constraints do not hold. Would it be safe to modify the result of this to exclude further specific points? Ideally this would be something done during optimisation as new bad points were discovered - at present the only way I can currently do this is to add additional pointwise constraints and re-run the optimisation after bad points are discovered.

Note that my current approach I am essentially having to loop the optimization process externally, re-using saved evaluations and running run_optimization(max_iter=1) after creating pointwise constraints, for any existing evaluations that yielded NaN loss - here's a snippet excluding the outer loop to demonstrate:
import GPy, GPyOpt
import logging
from GPyOpt.methods import BayesianOptimization
from GPyOpt.models import GPModel
import pandas as pd
import numpy as np
import math as m

from mycode import vae_eval
# vae_eval(x) builds a model using parameters x, trains it and then returns loss evaluated against a test dataset

evals_filename = '../data/past_evals.txt'
nans_filename = '../data/past_nans.txt'
domain = [
          {'name': 'myvar1',        'type': 'discrete',    'domain': list(range(5,81))},
          {'name': 'myvar2',        'type': 'discrete',    'domain': list(range(1,11))},
          {'name': 'myvar3',     'type': 'discrete',    'domain': list(range(5,81))},
          {'name': 'myvar4',        'type': 'discrete',    'domain': list(range(10,81))},
          {'name': 'myvar5',        'type': 'discrete',    'domain': list(range(1,21))},
          {'name': 'myvar6',     'type': 'discrete',    'domain': list(range(1,61))},
]

#
# Wrap everything below in a loop to explore multiple locations with GPyOpt, rather than using max_iter
#

gp_Y = None
gp_X = None

try:
    gp_evals = pd.read_csv(evals_filename, delimiter="\t", usecols=['Y', 'var_1','var_2', 'var_3', 'var_4', 'var_5', 'var_6'])
    logging.info("Using previous results in " + evals_filename)

    gp_nans = pd.read_csv(nans_filename, delimiter="\t", usecols=['Y', 'var_1','var_2', 'var_3', 'var_4', 'var_5', 'var_6'])
    logging.info("Loaded bad points from " + nans_filename)
    gp_nans.append(gp_evals[gp_evals['Y'].isnull()], ignore_index = True)
    gp_nans.to_csv(nans_filename)

    # Exclude NaN locations
    constraints= []
    for i,bad in gp_nans.iterrows():
        constraints.append({'name': 'constr_{}'.format(i),
            'constraint': '(x == [{},{},{},{},{},{}]).all(axis=1)*1 -.5'.format(bad['var_1'], bad['var_2'], bad['var_3'], bad['var_4'], bad['var_5'], bad['var_6'])})

    gp_evals.dropna(inplace=True)
    gp_Y = np.array([[x] for x in gp_evals["Y"]])
    gp_X = np.array(gp_evals.filter(regex="var*"))
except:
    logging.info("No previous evaluation data available, starting from scratch")

opt = BayesianOptimization(f=vae_eval,
            domain=domain, constraints=constraints,
            model=GPModel(kernel=GPy.kern.Matern52(input_dim=6, ARD=True)),
            X=gp_X, Y=gp_Y)
opt.run_optimization(max_iter=1, verbosity=False)
opt.save_evaluations(evals_filename)

However I think this is awkward and may scale poorly with large numbers of samples.

Running the loop externally is fine, although we have a better API for that now: suggest_next_locations. And I think you should actually look into using it, because it has following parameter:
:param ignored_X: matrix of input configurations that the user black-lists, i.e., those configurations will not be suggested again (default, None).

This can be updated in between iterations, and should help you with those points that break the loss evaluation

Sounds very promising. Will look into this API. Thanks!


[Enhancement] Check storage_root_path config in be.conf

Enhancement

The wrong path configuration(See Figure 1, The semicolon is incorrectly written as a comma) results in too many migration tasks and a large number of resources, The memory footprint of the be server continues to rise until it goes down
Expected behivour
First, split the storage_root_path string use semicolon then get a array, the number of commas for each array element is 0 or 1, and more than 1 is a problem path.

The reason is that the path is parsed into property and ignored directly, resulting in one less disk and triggering a large number of Clone tasks


⚠ TorrentLeech has degraded performance

In 076eea8, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 2524 ms

Resolved: TorrentLeech performance has improved in 3e4227f after 8 minutes.


add Core module to place common utilities such as FileSystem extensions

motivation: with the introduction of TSC there is no more room for common SwiftPM utilities such as FS extensions
changes:

add Core module that dependends on TSC and make everything depend on it
add FS extensions for getting ~/.swiftm and SwiftPM's cache directory
adjust code to latest TSC FS changes

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Kerri - Game window opens a new window

The game window should not be a new window, but a state change on the same page. (I think creating a new JFrame instead of a JPanel is causing the issue in GameView)

Made it a feature where clicking on game card opens a new window and keeps the original window in ResultsView


marshal sending partial topic updates periodically

Issue was a regression with 6f82eaf where we were sending partial
topic updates everytime were looping through claimTopics. This was
happening because we were starting from an empty list and building
and sending notifications accordingly. The fix is to use previous list
and update it and send notifications as necessary. I've updated
the test to cover this case too and have tested it on a machine
in prod this time to verify

@DrTall

LGTM (comments are all nitpicks)

So, can we pull this now before @zorkian comes back? We should fix the regression ASAP.

Oh yes, sorry. I'm used to him doing the pulls after reviews. Will merge now.


test prepared statements with acra-censor

add usage of prepared statements in acra-censor tests and refactored connections to re-use the same code (connections with different drivers and text/binary prepared statements per db type) in several places
add query as is if can't normalize to QueryIgnore handler to allow ignore queries that can't parse

So, at the end:
AcraCensor can filter prepare statements only using QueryCapture/QueryIgnore (by comparing incoming SQL char-by-char with SQL from config file). AcraCensor can't apply allow/deny rules for SQL requests with prepared statements.


ScrollSpy textarea loses focus in Opera 11

As the title says, the ScrollSpy textarea loses focus in Opera 11 each time the component reaches a nav target while dragging the scrollbar manually (not using the mouse wheel).
E.g. in the example on http://twitter.github.com/bootstrap/javascript.html#dropdown, if I start dragging the scroll bar of the textarea down with my mouse and reach the "@mdo" target, the textarea stops scrolling and the mouse cursor "detaches" from it.
It works in the latest Chrome and Firefox browsers as supposed though.
Tested with Opera 11.61 on Windows 7.

What textarea?

Oh, sorry! It turns out it's a div, not a textarea (foolishly assumed it was without looking at the source).
It's the .scrollspy-example div. I've captured a quick video showing what happens. You can see it here:
http://www.youtu.be/epifY0dVmc4.
Hope that helps!

oh lol, OPERA

And?

I am able to reproduce this, also running Opera 11.61 on Win7 x64.
It only happens if you click and drag the scrollbar. Using the mousewheel to scroll down works fine.
I don't get why Opera gets such flack. It's a damn fine browser. It's been first to market with many browser features that people accept as commonplace nowadays.

 treatment. It's a sign of affection really ;).

Of course ... I don't think any Opera user could argue against the fact that Opera is the red-headed (red-circled?) stepchild  of the browser world.
It would be nice to get this sorted though.

yup - what mark said. I :heart: opera

Misunderstanding from my side then. Apologies for that :)


[Serverless Mini Agent] Add _dd.mini_agent_version tag to all spans

What does this PR do?
Adds _dd.mini_agent_version span tag to all spans.
Motivation
https://datadoghq.atlassian.net/browse/SVLS-5167
Additional Notes
Previously there was an aas.environment.mini_agent_version span tag added for Azure Functions. This tag is being replaced for a span tag that will be applied in all relevant environments: Azure Functions, Google Cloud Functions, and Azure Spring Apps.
Set DD_MINI_AGENT_VERSION environment variable to the package version of datadog-serverless-trace-mini-agent. Then reference this environment variable in the packages that are run from datadog-serverless-trace-mini-agent.
Set the version of datadog-trace-mini-agent to match the version of libdatadog so the Serverless Mini Agent version is only managed in a single package moving forward.
How to test the change?
Azure Spring Apps

Build mini agent locally
Build an Azure Spring App with persistent storage
ssh into the Azure Spring App instance and upload the Datadog Java Tracer and Serverless Mini Agent
Add -javaagent:/persistent/dd-java-agent.jar to the JVM options
Set DD_TRACE_TRACER_METRICS_ENABLED to true
Start the Serverless Mini Agent

Azure Functions / Google Cloud Functions

Build mini agent locally
Deploy Azure Function or Google Cloud Function with mini agent binary in root path
Set DD_MINI_AGENT_PATH

Azure: /home/site/wwwroot/datadog-serverless-trace-mini-agent
Google: /workspace/datadog-serverless-trace-mini-agent

Codecov Report
Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.43%. Comparing base (a2cd10a) to head (070f006).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   70.45%   70.43%   -0.02%
==========================================
  Files         213      213
  Lines       28408    28418      +10
==========================================
+ Hits        20014    20017       +3
- Misses       8394     8401       +7

Components
Coverage Δ

crashtracker
25.14% <ø> (-0.08%)
:arrow_down:

datadog-alloc
98.73% <ø> (ø)

data-pipeline
50.00% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
86.43% <ø> (ø)

ddcommon-ffi
75.29% <ø> (ø)

ddtelemetry
58.95% <ø> (ø)

ipc
84.13% <ø> (ø)

profiling
78.09% <ø> (ø)

profiling-ffi
56.76% <ø> (ø)

serverless
0.00% <0.00%> (ø)

sidecar
35.42% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
71.01% <100.00%> (-0.13%)
:arrow_down:

trace-normalization
98.24% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.16% <ø> (ø)

trace-utils
90.96% <71.42%> (-0.08%)
:arrow_down:


Use LLVM 11 when target environment is musl

The latest Alpine Linux does not support LLVM 12 yet so use LLVM 11 if target env is musl
Signed-off-by: Junyeong Jeong<EMAIL_ADDRESS>

Ok. I understand that.
How about passing LLVM version string via cfg or feature option?

That could possibly work. Or we could just ship both a llvm11 and a llvm12 feature, and default to llvm12

@rsdy Features llvm11 and llvm12 are added. LLVM12 is default and LLVM11 is only used if it is specified.

oh no, I must miss something.

Looking good! Thanks for sorting this.


Using Content-Length to determine SIP message size

As stated in "RFC3162 - 20.14 Content-Length" the header must be used to determine message-size when transporting SIP over TCP.
The Content-Length header is utilized to determine the payload size if it is present, otherwise payload size will be determined by the size of the buffer being parsed.
The setTruncated flag will also be set during parsing if the buffer being parsed does not contain enough data, to honor the Content-Length header.

it's RFC RFC3261 not RFC3162

furthermore, the SIP decoder works regardless of transport layer protocol. but the mandate of content-length is only for TCP not UDP.

furthermore, the SIP decoder works regardless of transport layer protocol. but the mandate of content-length is only for TCP not UDP.

While that is true the RFC also states:

Applications SHOULD use this field to indicate the size of the
message-body to be transferred, regardless of the media type of the
entity.

Could it not then be argued that if the header is there, it should be used?

will this break any TCP SIP that doesn't have the content-length header? at the very least there must be some tests for that scenario. I'm reluctant to merge anything breaking especially when it's a "should" in RFC not a MUST

will this break any TCP SIP that doesn't have the content-length header? at the very least there must be some tests for that scenario. I'm reluctant to merge anything breaking especially when it's a "should" in RFC not a MUST

That makes total sense, they way it has been implemented, it SHOULD not change current behaviour if the header is not there, but I will add tests to ensure this fact.

will this break any TCP SIP that doesn't have the content-length header? at the very least there must be some tests for that scenario. I'm reluctant to merge anything breaking especially when it's a "should" in RFC not a MUST

On second thought .. the RFC does state that the "Content-Length" header MUST be used when on protocols like TCP

The Content-Length header field indicates the size of the message-
body, in decimal number of octets, sent to the recipient.
Applications SHOULD use this field to indicate the size of the
message-body to be transferred, regardless of the media type of the
entity.  If a stream-based protocol (such as TCP) is used as
transport, the header field MUST be used.

But as tests currently does not cover decoding any requests without the "Content-Length" header, I will add this, also I will ensure the behavior of the .GetContentLength() does not change, compared to the current implementation.

I added one more test to show that length of the message body is only limited when the Content-Length header is present in the message. I see no reason in pushing the message through IP and UDP/TCP respectively, as the parser acts the same regardless of the transport.


Add Forge::processIndexes() to create indexes on existing table

Closes #4814
This PR allows creating indexes on an existing table.
It is used following addKey(), addPrimaryKey(), addUniqueKey(), and addForeignKey() to add indexes to an existing table. It is used instead of or in place of  createTable().
This is the last part of https://github.com/codeigniter4/CodeIgniter4/pull/6430
Closes #6453
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

@codeigniter4/database-team Please Review

Can you add a test case for without foreign key name?

I can, but I don't see it as necessary because _processForeignKeys() is called the same as with create table and there are tests that cover this already. I used names because it simplified the test. Your not going to get anymore code coverage with a test without names.

As far as coverage is concerned, the coverage value we are getting now is line coverage, which means nothing more than knowing lines that are not covered.
Just because the coverage does not increase does not mean that the additional tests are useless or not. At the very least, branch coverage should be compared.
Looking at the implementation in this foreign key case, there is certainly no need to add it.
And as you say, testForeignKey() covers it.

🕺🥳🚀


Allow layout to be set via json data

If page.layout is set in data it will be used for rendering.

Hey buddy, Thank you so much for the pull request and the suggestion. I was busy in academic works. I just released v1.3.0 which allows setting layout from data. I have added a test to check this. Thanks again.


PDF with images are not rendering in Internet Explorer

Link to PDF file (or attach file here):
Configuration:

Web browser and its version: IE 11
Operating system and its version: Windows 7
PDF.js version: all versions (pdfjs-1.7.225, pdfjs-1.8.188 and pdfjs-1.9.426). Screenshots are from 1.9.426.
Is an extension: No

Steps to reproduce the problem:

Choose any .PDF file with images
Render the .PDF file in Internet Explorer

What is the expected behavior? (add screenshot)
Screen should load same as .PDF.
Screenshot from Chrome

What went wrong? (add screenshot) Screenshot from IE11
Images were not displaying on screen.

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
Not available
Processed .PDF file attached (ImageAndText.pdf)
ImageAndText.pdf

This has become an issue for me as well. Any updates?

Actually this is not an issue but a scenario. Please check you graphic card display driver. mine were 4 years old. I updated to latest drivers and it started working fine.
This issue should not be observed on all machines.


New version of #315

@bezineb5 I don't have your name so I'm using your github username as your name instead

Please hold while I try to solve the wasm issue


add-and-remove-functions

Init project using webpack
Created index and js files dynamically using webpack
Created todo list
User can add task
User can remove task
Tasks persist in local storage

**Hello Reviewer this is my final review, please let me know if you require any changes before you submit. 🙏 **


Drop support for kubernetes < 1.20 for cilium extension

How to categorize this PR?

/area networking
/kind cleanup
What this PR does / why we need it:
Drop support for kubernetes < 1.20.
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/6911
Special notes for your reviewer:
Release note:

Cilium networking no longer supports Shoots with Кubernetes version < 1.20.

/lgtm


Migrate tt_lib_bindings.cpp  -

Tracking Issue : #11513
Migrate tt_lib_bindings.cpp to TTNN

Closing as work is already in progress


@alloy => Initial work on turning on OHHTTP stubs only

Alright, so.
The aim of this PR was to initially build out AROHHTTPNoStubAssertionBotand to turn on forced exceptions around networking.I started this, but once I had got deep enough into the PR I began to realise that this is still a flawed approach,
The problem lay in that it was difficult to loop back from the Exception raised by the networking API to the bit of code that caused it. I concluded that this wasn't going to be fun, and wouldn't make life easier in the future, which was the entire point.
So I started wondering what it would take to use some of the techniques I requested in Moya within Eigen. The notable one being stubs as first class citizens. We now have synchronous networking in tests.
This is the stack trace for a simple networking call:

And here's a complicated one:

You can now determine exactly what test is making what networking request. Note this only affects things going through the API.
The API client will log out example OHHTTP code if you don't have a stub for some networking that happens inside the app. I opted against making it an exception, it's really obvious when you see it.

The API client will log out example OHHTTP code if you don't have a stub for some networking that happens inside the app.

Oh yeah, epic win :100: :+1:

I opted against making it an exception, it's really obvious when you see it.

One thing you could do is in the printed message include a function that people can break on, like is done with unsatisfiable AutoLayout constraints.

Right now it tells you to do this: printf("Add a breakpoint in ArtsyOHHTTPAPI.m or look above for more info. \n\n\n");
I think only you add them via magic

I’m luvin’ this, very well done, sir :+1:
I get that you’re not raising an exception atm, but why not have the printed message include a filtered stack trace with the util I made for you?

I’m gonna hold off with merging this until all normal work is done, just to be sure that I don’t loose any time anymore this week.

Oh, nice, stack trace idea = :+1:

I rebased this branch and am only seeing the 6 failures that are currently on master as well. Will merge this after some last-minute adhoc fixing on the App Store release.

The only failures are the ones that @1aurabrown is still working on, so MERGE TIME!


add lbry is hiring on footer

Results

based on Mr Jeremy last comment . in my closed PR

@ykris45 Jeremy already added that to the code :)


Split metadata-attribute with multiple values into multiple metadata-attributes?

Hi Pascal,
it is so much fun to work with the Norconex Collector, thank you.
Well documented and easy fast results.
Is there a way to Split a metadata-attribute with multiple values into multiple metadata-attributes with single value?
I found the splitTagger, but it does not split values into multiple attributes.
https://www.norconex.com/collectors/importer/latest/apidocs/com/norconex/importer/handler/tagger/impl/SplitTagger.html
Example:
<meta name="area" content="Technology,Engineering />

into
<meta name="area" content="Technology/>
<meta name="area" content="Engineering />

Thank you
Best regards
Sascha

Thanks for the great feedback!  I am glad you like it.
The SplitTagger is meant to do what you want.   If that's not working for you, can you share your config?
I tried your above example in the importer section, using the sample configuration provided in the documentation and it worked just fine:
<importer>
  <postParseHandlers>
    <handler class="com.norconex.importer.handler.tagger.impl.SplitTagger">
      <split fromField="area" regex="true">
        <separator>\s*,\s*</separator>
      </split>
    </handler>
  </postParseHandlers>
</importer>

I can confirm the value was split.  The HTML does not get re-written, but the value is becoming a list of strings, instead of a single CSV string.

Thank you, that's exactly the config which I also use.
I confim that the value is splitted this way:
area=Technology^|~Engineering

as far as i understood, this is not equal with:
<meta name="area" content="Technology/>
<meta name="area" content="Engineering />

Can you confirm that?

Yes, that's the same thing.  What you want is to extract the area into separate values.  What you are reporting seeing is simply the internal storage format.  Normally, you are expected to use a Committer to store extracted data.  You will then see it stored as multiple values.  What Committer are you using?  Don't you get separate values?

That helped a lot.
Thank you


add pushTokens/notifications table

This adds the tables to the Admin they are needed, for the pushNotifications.
Note that the RLS does not work for the Admin right now. I'll do that after my first exam. For now if you can't see anything on the table please deactivate the RLS for testing.

did completely overlook this because you did not add the reviewers :D


Add website icon and necessary meta tag to template and change picture in info box and other place

Close #94 and close #92
Hello! I finish both issues in one pull request because it's related.
Change some symbol on infobox
I change BPM, circle, slider and spinner count on infobox to make it look better.

Add necessary meta tag
I added necessary like website icon, favicon and some necessary information. I add opengraph image and some embed setting to make the social network render the card like we want.

Let's merge it now!


UI feature - Notebook markdown toolbar (#9853)

Markdown editor toolbar - initial commit

Moved icons. Refactored new toolbar component to include markup.

Edited markdown toolbar component and referencing in textCell component markup.

Completed UI updates for selected cell toolbar and markdown toolbar.

Modified import path to Event class. Changed EventEmitter to Emitter.

Cleaned up newly added toolbar components

Works sometimes sometimes editor is null

Removed commented out code and styles. CellToolbar and MarkdownToolbar: moved component markup into html file.

Added icon for highlight. Removed more commented code. Re-scoped two styles to their parent components. Corrected templateUrl reference for the new toolbars.

Adjusted paths to SVG icons from toolbar stylesheet.

Add lists and links

Refactor out of component, add actionbar

Support for nothing selected, quick bug fix

Updated split view icons. Added markdown tool backgrounds and cell border colors to color registry and parent components. Updated toolbar icons to use mask as this allows the SVG icon colors to be adjusted on theme change.

Added colorRegistry entries for code cell. Removed colors from styles. Running registerThemingParticipant from code.component.

Revised code component style rules and corrected syntax.

Merged in Chris' working branch and removed unused markup.

Corrected styles and moved another color into colorRegistry for use in new markdown toolbar.

Corrected style error. Overrode left position of content inside textCell and codeCell. Added more entries to colorRegistry.

Moved toolbar and editor icons to common-icons location. Updated related stylesheet. Revised color theming rules for markdown and code cells.

Added themed border between markdown and preview. Moved all notebook themes into notebookStyles.ts

Merged in latest from origin/master and included a small but significant style tweak to light theme code cell toolbar.

Add Undo Support for Markdown Toolbar (#9915)

Remove comment

Renamed registered notebook colors and prefixed with notebook. Moved markdown component theme colors into notebookStyles.ts. Removed colors from cellToolbar styles. Revised icon class names to generic names for better re-use. Removed commented markup.

Co-authored-by: chlafreniere<EMAIL_ADDRESS>Co-authored-by: Chris LaFreniere<EMAIL_ADDRESS>
This PR fixes #

/merge

Merging PR based on approval from @chlafreniere


Use digger.yml from PR branch (not main) in GH app flow

Currently with the GH app digger.yml is always taken (and updated) from the main branch. Implications:

A change to digger.yml cannot be tested until it's merged
PRs that include a change in digger.yml need to be split in 2 parts
Against the "shift left" principle / best practice

Reasoning behind current behavior:

digger.yml will only be picked from the main branch if you use the app with backend, its because at the moment we could not think of the right data model for storing the digger.yml for every branch, or if we want to pick it from the repo on events. So we refresh it on merge to main branch for now while a better solution emerges

Addressed in #1116


The model and loaded state dict do not match exactly when trying to load pretrained weights

Hi,
When I am trying to run a training epoch using pretrained weights, I am getting a warning that the model and state dict do not match exactly. As I have not modified anything, I suspect that it is a weight/config mismatch.
Whilst there is an example for convnext_tiny, I am making some assumptions here as I am trying to train convnext_base, the command I am using is:
python tools/train.py configs/convnext/cascade_mask_rcnn_convnext_base_patch4_window7_mstrain_480-800_giou_4conv1f_adamw_3x_coco_in1k.py --cfg-options model.pretrained=https://dl.fbaipublicfiles.com/convnext/coco/cascade_mask_rcnn_convnext_base_1k_3x.pth
Is this the correct pretrained model for this config?
Thanks!

have you resolved it ? i meet the same question

Unfortunately I was never able to resolve it, so abandoned investigating it further as it doesn't look actively maintained


Fix to build with latest amazon Linux

PR enables build to succeed with latest amazon Linux.
EPEL is required for ClamAv.
Copies missing libs.
Tested with both local SAM & in AWS.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Petri Laakso seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hopefully it helps to say that these changes also worked for me - the lambda's now successfully work.

Be good if @petrilaakso could sign the CLA to get this merged along with everything upstream that is waiting for this PR.
(of course, one could just fork ...)

Sorry about the delays here - this is handled by https://github.com/upsidetravel/bucket-antivirus-function/pull/52


Flipping Usage Descriptions on iOS Location

It looks like the location usage checks for iOS are correct in source code; however, it doesn't look like those changes are in the compiled version on NuGet.  Could you please promote?  Thanks!

There is already a pre-release available on nuget


fix bug for updateCell with space value

When you press delete in cell of column with option allow empty value set to false, then in cell have writed space char and not 0.
For fix this bug, i propose add this code in obj.updateCell
obj.updateCell = function(x, y, value, force) {
[...]
            if(value=='') {
                value = obj.options.columns[x].allowEmpty ? '' : 0;
            }

            // History format
            var record = {
                x: x,
                y: y,
[...]

How about this solution are applied only for column type number? And that would be easily achieved by onafterchanges or updateTable? In most recent versions we have a new attribute call validations, which will be a nice addition to help validate the data through customizable rules and help the user to fix the data before persistance. This implementation will force the user to use allowEmpty all the time, in the case the user experience will be different from other spreadsheet software.


fix: avoid modifying git with the git sha

to reduce git conflicts
fixes https://github.com/jenkins-x/issues/issues/42

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test kube

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
53b47d013685fadfb4390fdc38141a32374e826b
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Blank frame when out of focus

When the app is out of focus, it appears to stop processing graphics.  I think this is intended behavior to save on system resources, but completely kills the use case for me, as I would like to use the app on a 2nd monitor on chrome OS.  As soon as I click off the app onto my main screen (or anywhere else) the app goes blank.
Can you please add a toggle to allow graphics to keep processing even when out of focus?

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Per roll settings - each attack can choose how to roll

This could be a big one.. not sure about this.

won't do


Move sidecars into gitops

This turns off automatic sidecar injection, and instead creates the sidecar at the deployment level using github actions, and istioctl kube-inject.  Making the sidecar part of the deployment adds more control and certainty to the process, makes the sidecar completely declarative, and allows flagger to progressively shift traffic from one version of the sidecar to the next during an upgrade.
I recommend squashing this, as there are lots of unnecessary commits.
Also, I wasn't able to figure out how to get the github token set up for your update-istio create pull request step, so I'm keeping my main branch slightly off for the demo.

There were some problems with this branch.  I will resubmit after my demo tomorrow.


fix for some AWs that do not complete

Issue link

#657
What changes have been made

Changes to addqueue method which exists only after informer and etcd has status.
Verification steps

I have manually run scale tests and confirmed all AWs complete
(base) abhishekmalvankar@Abhisheks-MBP perf-test % kubectl get appwrappers --all-namespaces -o json | jq '.items[] | select(.status.Succeeded != 1) | {namespace: .metadata.namespace, name: .metadata.name, status: .status}'
(base) abhishekmalvankar@Abhisheks-MBP perf-test %

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[X] Manual tests
[ ] Testing is not required for this change

I'm hoping I did my PR onto your PR right, but I made a few small adjustments to the perf.sh script that seems to be working well.  I rebuilt the mcad image based on PR 658 and it's running very well, not seeing any hanging appwrappers - I've run up to 300 so far.
As a control, I also ran the same perf.sh against the codeflare-operator:v1.0.0-rc.1 release and that one does well with 5 and 20 appwrappers, but is consistently hanging with 50 appwrappers.  The jobs all show complete, but the appwrappers are fighting to write to etcd.
I think this PR is a big improvement, if we can just get the small perf.sh tweaks in there.

It's looking really good @asm582, I've built the image and then done:
helm install mcad-controller --namespace kube-system --generate-name --set  image.repository=quay.io/jbusche/mcad-controller --set image.tag=comp-stat-try2

and then running your newly modified perf.sh and it's looking really good:
AppWrappers     Total Time (seconds)    MCAD Image
50      181 seconds     Abishek PR 658
50      182 seconds     Abishek PR 658
100     343 seconds     Abishek PR 658
200     670 seconds     Abishek PR 658
300     1011 seconds    Abishek PR 658

I'm also watching the appwrappers and it's cleanly finishing even the long runs, which was NOT the case in the regular rc.1 image.
watch "kubectl get appwrappers --all-namespaces -o json | jq '.items[] | select(.status.Succeeded != 1) | {namespace: .metadata.namespace, name: .metadata.name, status: .status}' |wc -l"
0

@jbusche  Can you please approve the PR?


[SUPPORT] timestamp with logical type is timestamp-mills will cause data inconsistencies

Describe the problem you faced
a table with col ts type is timestamp and it is a precombineKey
background：
flink streaming load and spark will sync to hive partitioned table every day.
question:
when use spark to query the table, the result show ts is 55758-12-02 03:30:01.0, and if I use spark to query the table to sync other hive table, the data update record will lose, the new data has been load into log file, but the hive table only contain old value after sync. After compact, if I sync to hive again, the result is correct.
analysis:

commit instance, hoodie.properties all of them logical type are timestamp-mills

in spark code, when convert structType to avroType unable to distinguish accuracy type, will use timestamp-micros

so, when use spark mergeingfileIterator, base file use timestamp-micros, logfile use timestamp-mills, because avroschemastr is timestamp-mills

so, if ts long value is<PHONE_NUMBER>683, base file will get<PHONE_NUMBER>683000, log file is<PHONE_NUMBER>683.
the spark timestampType look like can not distinguish mills and micros, if we direct conver structType to avroType, something data quality will happpend.
@YannByron @yihua @wzx140 @danny0405
To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version : 0.13.1

Spark version : 3.2.0

Hive version :

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

can not distinguish mills and micros, if we direct conver structType to avroType

Can we fix it, both Spark struct type and avro logical timestamp type takes along the precision, theoretically feasible?


Revert "Merge pull request #248 from Shopify/bugsnag-integration"

This reverts PR #248. I don't think we should make assumptions about the usage of Bugsnag. As long as we make integrating Bugsnag possible, and document it in the README, it should suffice.

Let's expand the documentation. But I don't think we need to implement the generator before merging this since we are not even including this gem yet in the generators. If an app configure this wrongly, given our documentation explain it well, it is the price to pay for being early adopters.

Let's expand the documentation. But I don't think we need to implement the generator before merging this since we are not even including this gem yet in the generators. If an app configure this wrongly, given our documentation explain it well, it is the price to pay for being early adopters.

Okay I expanded the README a bit more about error handlers. Let me know if you need any more info mentioned in there!

Okay I expanded the README a bit more about error handlers. Let me know if you need any more info mentioned in there!


Consolidate templating approach -- right now .tmpl, .omgdtml, etc. largely due to splitting repos.

counter point: tmpl exists at the user level within their game for resources etc, while omgdtmpl indicates it's for the cli tool; maybe this is fine as long as it's just those two


[BUG] Listing visibility issue in chapter 11

Hi,
Thanks for creating this introduction to GTK with rust. I'm new to rust and GTK and this introduction helped me a lot.
Bug description
First listing of mod.rs looks like that

On this stage to run the app and display UI we need to add also new method (constructor) otherwise app will not build in main.rs Would be nice to put that as highlighted part of this snippet (change color to white :) )

@maciejczekaj you mean new?

Ah yes, I see your point but in later chapters I am not highlighting every single line. Unless it is necessary to understand the concept of course. In that case, adding constructors has been mentioned multiple times already.


Rename Yabeda exported_instance label

Context
We currently send the cloud foundry instance id as "exported_instance" label so it doesn't override the "instance" label generated by prometheus. But we want to drop the prometheus one because it changes at each deployment and creates millions of time series in prometheus and influxdb.
Changes proposed in this pull request
Instead we're going to send the instance id as "app_instance" which is used to replace the prometheus instance label as configured in cf-monitoring.
Related to: https://github.com/DFE-Digital/cf-monitoring/pull/45
Guidance to review
Check metrics in the review app
Check configuration in cf-monitoring and use https://relabeler.promlabs.com/
Link to Trello card
https://trello.com/c/SgUDbsA2
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] Required environment variables have been updated added to the Azure KeyVault

 Remove or rename instance label from prometheus metrics


Closed in favor of #184


WebUI node management

Description
Node info is limited in the Cluster Admin section of the WebUI. With the latest changes in the cluster-resize branch, we now have more capabilities we can take advantage of.
The node list can contain the following attributes for each node:

Node ID
Cluster ID
IP address
Web port
Gossip port
Coordinator
Buttons:

Remove node
Set coordinator

We also should have the ability to display the cluster status and appropriately handle errors when attempting requests to locked handlers during a resize operation.
Success criteria (What criteria will consider this ticket closeable?)

[ ] Node metadata and buttons above are present in WebUI
[ ] Cluster status indicator
[ ] API errors should be detected and displayed properly (including cluster resize status if applicable).

Moved to https://github.com/pilosa/webui/issues/


Stack to construct

Change Summary
Overview
This is a major refactor of our AWS infrastructure. It is best practice to focus on lifecycle for Stacks and deployment updates to avoid circular dependencies. We were running into a few circular dependencies because we had Stack A depending on Stack B, which would then want to try and update Stack A again. Putting everything into the same deployment unit makes sure that these updates get processed and deployed in the correct order.
There is a lot of thrash just changing names from "abc_stack" to "abc_construct", might be advantageous to avoid the "_specific_name" in the future...
We have 3 primary stacks now, with our previous fine-grained Stacks turning into Constructs.

Networking Stack (sets up VPC)
SDC Stack (sets up all resources that the SDC uses/needs)
I-ALiRT Stack (sets up all resources for the I-ALiRT processing)

The easiest way to review this might be to step through by commits. I tried to break the process up into small incremental commits. Although there were two other PRs that were merged during this process and it was easier to merge them in than rebase through all the commits.
Testing
I have deployed this all into a separate dev account and it deploys successfully and works as expected from an initial cut at depositing a file and querying the DB for that file.

Looks good to me! I didn't test the deployment, but if you ran this code today then I'd say it's good.

@bmcclellan-cu, I have just pushed up the latest changes that I deployed from today. The most recent couple of commits include the work from Jackson for the HostedZone certificate.


Remove Hex stuff from LatticePhysicsWriter

The very generic LatticePhysicsWriter class has some references to hex-assembly-based reactor design:
https://github.com/terrapower/armi/blob/9da65879499bda3b9f1e9829e3d9f935275eeaa7/armi/physics/neutronics/latticePhysics/latticePhysicsWriter.py#L114
This variable name is not generally applicable to ALL reactors, and we need to ditch this from the class.  Likewise, if the class has any other similar cruft in it.

@john-science A few questions. Do you want to remove any hex reactor references? I'm assuming you guys still use a hex geometry at some point in the workflow for the natrium reactor.

@KevinKapka

Do you want to remove any hex reactor references? I'm assuming you guys still use a hex geometry at some point in the workflow for the natrium reactor.

ARMI has to support ALL reactor types, not just Natrium. For instance, even TerraPower has the MCFR reactor project, which doesn't have assemblies at all.  So this means that crucial base classes in ARMI, like this generic "lattice physics" one shouldn't be specific to hex-assembly-based reactors.
We can create a sub-class of this for "HexAssemblyLatticePhysicsWriter".  And that could stay in ARMI or move over to internal Natrium code.

Do you want it just to refer to them all as layers?

Sub-classes, sure.

If LatticePhysicsWriter isn't called unless the reactor is in fact hexagonal...is that okay?

As you are aware, people will want to do Lattice Physics work for ALL reactors, including the MCFR project. So, any reactor (including one of our MANY benchmark reactors) that needs MC2 will need to use this class.
The goal, here, and for all of ARMI, will be to separate out hex-assembly-specific logic from generic logic.  That way we can support ALL reactors.  We don't have to drop support for hex-assembly-based-reactors to do that. We just use subclasses.
Does the goal make sense?