[CP Staging] Fix autofocus on Sign In page

Details

It fixes regression caused by Focus Trap.
Fixed Issues

$ https://github.com/Expensify/App/issues/43664
PROPOSAL: N/A
Tests

Try to login.
Verify that input field is focused.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as in tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/56261019/f71c3f7f-cc7b-445c-b18d-026331fcffb8

Android: mWeb Chrome

https://github.com/Expensify/App/assets/56261019/8d253bb6-1427-4deb-8984-5f0d24f30cde

iOS: Native

https://github.com/Expensify/App/assets/56261019/a83eac46-60bc-4556-ae2e-710cf5a9435a

iOS: mWeb Safari

https://github.com/Expensify/App/assets/56261019/fcd8579f-6bff-42ce-a3eb-be79b6ae6e4a

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/56261019/5c1fbb69-a984-4cad-a279-b17b5cdbc617
https://github.com/Expensify/App/assets/56261019/ab009ce2-565b-4534-ab28-0a80e532ed5d

MacOS: Desktop

https://github.com/Expensify/App/assets/56261019/e7a5b8a2-2ff2-40b8-a3e6-7ab6eac506d0

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@jnowakow Could you add a space between $ and the issue link in the Fixed issues section? I think it's required for automation to work.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.83-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Ugly wrapped generics

I got the following (inside a class)
  private final Map<Integer,
  DbCategorisationLevel> levels = new HashMap<>();

While I would have expected:
  private final Map<Integer, DbCategorisationLevel> levels = new HashMap<>();

maybe give this a shot yourself? :)

This was closed by 88145f8


Updated README.md in DrivingMissData

Reviewed purposed changes, @amiya-1998, this change and more is addressed in #2
Closing PR, marking as duplicate and not merging.


ensure apache licence is maintained across the repository

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
Review the contributing guidelines for this repository; remember in particular:

do not modify code without testing for regression
provide simple unit tests to test the changes
if you change the schema you must patch the test databases as well, see Updating the schema
the PR must not fail unit testing

Description
Using one or more sentences, describe in detail the proposed changes.
Adding a test case to check all existing modules for correct apache licensing
Use case
Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.
All modules in the repository should have an apache 2 licence and follow the same format. This test case ensures that it does not get lost when a module is updated and automatically checks new modules for the presence of the licence
Benefits
If applicable, describe the advantages the changes will have.
All modules, even newly added, will be checked for the correct licence
Possible Drawbacks
If applicable, describe any possible undesirable consequence of the changes.
Testing
Have you added/modified unit tests to test the changes?
Yes
If so, do the tests pass/fail?
Pass
Have you run the entire test suite and no regression was detected?
Yes

Pull Request Test Coverage Report for Build 106

26 of 28 (92.86%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 50.673%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

modules/t/housekeeping_apache2.t
26
28
92.86%

Totals

Change from base Build 94:
1.0%

Covered Lines:
640

Relevant Lines:
1263

💛  - Coveralls

Pretty much. Way easier to read that way, at least for me.


Added JPP_1000 to test the implicit creation of data structures

Hi Son,
in opposite to
https://github.com/test-fullautomation/robotframework-testsuitesmanagement/issues/214
this new test case JPP_1000 is successful.

Hi Holger,
hm... to avoid confutions I would propose to create pull-requests only against @namsonx 's stabi branch?
Thank you,
Thomas

Hi Thomas,
I wanted to do this. Most probably a clicking mistake. I retry.

Hi Thomas,
Successor of this pull request is:
https://github.com/test-fullautomation/python-jsonpreprocessor/pull/141
This pull request can be deleted.

closed due to accidentally wrong destination branch.


Keyboard shortcut to change external display only

Before opening the issue, have you...?

[X] Searched for existing issues

Is your feature request related to a problem? Please describe
impossibilty to change external display brightness only
Describe the solution you'd like
im extremely thankful of being able to use ddc on m1 now !
just wanted to submit an idea which i am suprised not to see implemented yet:
using a custom shortcut ,whatever it be ,to control external display brightness only ,while keeping macbook display at the same brightness (in my case 0 nits/off )
Describe alternatives you've considered
im extremely thankful of being able to use ddc on m1 now !
just wanted to submit an idea which i am suprised not to see implemented yet:
using a custom shortcut ,whatever it be ,to control external display brightness only ,while keeping macbook display at the same brightness (in my case 0 nits/off )
Anything else?
No response

There is a shortcut to change brightness for the internal display only (ctrl+brightness), we could add an other that does this in reverse and change external displays only (shift+ctrl+brightness).

There is a shortcut to change brightness for the internal display only (ctrl+brightness), we could add an other that does this in reverse and change external displays only (shift+ctrl+brightness).

thanks that would be awesome !! also yes my syntax sucks ahaha

I added this to 3.1.0. There is an unsigned interim version here to test.

I added this to 3.1.0. There is an unsigned interim version here to test.
Update: the shortcut is now changed to ctrl+command+brightness (shift+ctrl+brightness was colliding with fine control if somebody wants to control internal display only)

works wonders,amazing ! i assume it'll be released as stable or at least beta ,within the next couple of days right?
thanks again and have a good day!

We don't have an exact timetable, but surely we'll release it eventually. :)

Thanks for this suggestion I was just looking for it as a new MonitorControl user!
I just switched away from my two Thunderbolt Displays and they worked as follows, if I pressed the volume or brightness keys on my wireless keyboard, they only changed the external monitor. If I pressed those keys on the laptop, the only changed the laptop values.
Any way this can be added as an option for MonitorControl; thanks in advance!

I added this to 3.1.0. There is an unsigned interim version here to test.
Update: the shortcut is now changed to ctrl+command+brightness (shift+ctrl+brightness was colliding with fine control if somebody wants to control internal display only)

Thanks for this suggestion I was just looking for it as a new MonitorControl user!
I just switched away from my two Thunderbolt Displays and they worked as follows, if I pressed the volume or brightness keys on my wireless keyboard, they only changed the external monitor. If I pressed those keys on the laptop, the only changed the laptop values.
Any way this can be added as an option for MonitorControl; thanks in advance!

Hi, this does not seem to be easily possible. MonitorControl uses MediaTapKey which does not currently distinguish between the brightness key from a Magic Keyboard and a built-in keyboard. MediaTapKey relies on IOKit's special key designations which also don't seem to distinguish between these. There is a distinction in real life of course and apparently some apps can capture this (for example Hammerspoon returns a different code for them and also Karabiner can distinguish between strokes from different keyboards). You might want to try to add a new Feature Request regarding differentiating between built-in/external keyboard keytaps here: https://github.com/MonitorControl/MediaKeyTap. If the devs make it work, MonitorControl can also implement something like this.

Hi, this does not seem to be easily possible. MonitorControl uses MediaTapKey which does not currently distinguish between the brightness key from a Magic Keyboard and a built-in keyboard. MediaTapKey relies on IOKit's special key designations which also don't seem to distinguish between these. There is a distinction in real life of course and apparently some apps can capture this (for example Hammerspoon returns a different code for them and also Karabiner can distinguish between strokes from different keyboards). You might want to try to add a new Feature Request regarding differentiating between built-in/external keyboard keytaps here: https://github.com/MonitorControl/MediaKeyTap. If the devs make it work, MonitorControl can also implement something like this.

Thanks for the insight, I will try my luck with them. :)


Realms icon with incorrect offset

I don't know whether I should be reporting this to Mod Menu or Replay Mod but the fact is I have both and they both add a button to the game's main menu. The diamond shape that normally appears on the right of the Realms button now does not appear on that button but is offset on the screen somewhere.

Could you send a screenshot please?

1.16.1, latest build for it on CurseForge, GUI scale does not seem to be relevant
https://imgur.com/sd0DJyj

It was a replaymod issue and it's fixed now.
https://github.com/ReplayMod/ReplayMod/issues/373
https://github.com/ReplayMod/ReplayMod/commit/5721b6f8c9b174f0c7cea1aa5c99b12c036b059d

Ah, nice.


[FLINK-16948][docs] Change docs to better highlight embedded vs remote module configurations

Update the docs based on user feedback to better highlight how to use io modules in embedded vs remote modules.

@knaufk Would you want to take a look at this.

LGTM


External sources: more options & docs

I am interested in using external sources. What I am missing in either features or the documentation (if the feature already exists):

How do I set the delimiter for my CSV file?
How do I specify a local path?
What do the list of tables mean and how can I document that? The CSV/parquet would be a single table, why are there multiple in the docs?

Ah so the request is to update https://github.com/jwills/dbt-duckdb#external-materializations-and-sources to include info on how to setup CSV external sources?

Correct :)


Add documentation for all default validation rules

This library is great! I would very much like to use it in a project I'm working on but I can't find any documentation that spells out each of the validation rules that it enforces.  Do you have a list somewhere that I just missed?

Hi @scott-abernethy66, thanks for your interest!
You're right that there is currently no list that spells out each validation rule that is enforced. It follows the RFC for email addresses when doing validation, but those are not very easy to parse through 🙂
I think it would be a good idea to list out the things that are always enforced when doing basic validation. I do already have a list of additional validation rules that can be applied.
I am currently out of town traveling for a few weeks but I will try to get to this as soon as I get back!

Hi @scott-abernethy66, thank you for your patience on this issue.
I just recently merged #124, which is a feature addition to the library that provides details on why certain email addresses failed validation. As part of that, there is now an enum that enumerates many of the various validation rules that are enforced based on the RFCs: https://github.com/RohanNagar/jmail/blob/master/src/main/java/com/sanctionco/jmail/FailureReason.java
Each reason is documented with JavaDocs to explain it in a bit more detail. Do you think this documentation is what you were looking for?

@scott-abernethy66 please see https://javadoc.io/doc/com.sanctionco.jmail/jmail/latest/com.sanctionco.jmail/com/sanctionco/jmail/FailureReason.html for the description of what I mentioned in my previous comment.
I am going to consider this done for now, but if you need something more please feel free to reopen the issue.


Vue SSR server-plugin.js breaks on hot-reload

Version
2.6.14
Reproduction link
https://github.com/rafaelmmadeira/vue-ssr
Steps to reproduce

Start dev server: npm run dev
Change App.vue text content and save (HRM should trigger)

What is expected?

Application detects changes, rebuild itself and the browser shows updated content

What is actually happening?
Application crashes on server-plugin.js :

Digging deeper at server-plugin.js that's what i found:

The issue is related to the entryInfo.assets processing. Initially it holds only the server bundle (omiting unnecessary entryInfo data):

{...., "assets":[ { "name":"server-bundle.js" } ], ... }

After some change at the code (HRM is activated) it holds the following:

{ ...., "assets":[ { "name":"server-bundle.js" }, { "name":"main.61bde893519a27dd85a8.hot-update.js" } ], ... }

I understand that the second entry is related to the hot reload feature.

Changing the entryInfo.assets (vue-server-renderer/server-plugin.js line 96) processing from

var entryAssets = entryInfo.assets .map(getAssetName) .filter(isJS);
to
var entryAssets = entryInfo.assets .map(getAssetName) .filter(isJS && ((file)=> !file.endsWith('.hot-update.js')));

seems to have resolved the crash issue.

I'm using (omitting unnecessary here):
{
"dependencies":{
      "vue":"^2.6.14",
      "vue-router":"^3.5.1",
      "vue-server-renderer":"^2.6.14",
      "vuex":"^3.6.2",
      "vuex-router-sync":"^5.0.0"
   },
   "devDependencies":{
      "webpack":"^5.38.1",
      "webpack-cli":"^4.7.2",
      "webpack-dev-middleware":"^5.0.0",
      "webpack-hot-middleware":"^2.25.0",
      "webpack-manifest-plugin":"^3.1.1",
      "webpack-merge":"^5.8.0",
      "webpack-node-externals":"^3.0.0"
   }

Although it seens a bug at vue-server-render, the webpack-hot-middleware package, which is generating the the additional bundle, is quite outdated (lastest release was on May 15, 2019).

Are these not supposed to work together anymore?

Thanks in advance.

I was able to make it work with<EMAIL_ADDRESS>and vue 2.6.14.


update() does not convert enum value

I'm using propel2 in the current dev-master version and in my schema.xml I use an enum type like this:
<table name="my_table" idMethod="native" phpName="MyTable">
...
  <column name="status" required="true" type="ENUM" valueSet="status1, status2, status3" default="status1" />
...

Then I want to do a bulk update of this table using the following code:
MyTableQuery::create()
    ->filterByStatus(array(
        MyTableTableMap::COL_STATUS_STATUS1,
        MyTableTableMap::COL_STATUS_STATUS2
    ))
    ->update(array(
        'Status' => MyTableTableMap::COL_STATUS_STATUS3
    ));

But this will result in an SQL error like this:

SQLSTATE[HY000]: General error: 1366 Incorrect integer value: 'status3' for column 'status' at row 1

This is because the update() function does not convert the enum value as it does for the filterByStatus() function.
Instead I have to do something like this to get the internal integer value of the enum value and then use this for the update:
$valueSet = MyTableTableMap::getValueSet(MyTableTableMap::COL_STATUS);
$status3Int = array_search(MyTableTableMap::COL_STATUS_STATUS3, $valueSet);
...
    ->update(array(
        'Status' => $status3Int
    ));

Please let me know if this is an issue in propel or if this is really the way I have to do it.

+1

I'm not sure if this is really a bug or just a limitation in the current enum implementation. I'd rather want to wait for the merge of #786. With this PR you can pass a string as column value as you wanted to use.

Is this still relevant or can it be closed?

@dereuromark : Do be honest, I totally forgot about this ticket and even didn't know anymore that I created it 😉 It was 5 years ago. Since I'm not using Propel2 not since a long time, I would suggest that you guys from the Propel2 community/development decide if this is something you want to change or not.


feat: allow themes to customise editor error highlight colours

This adds a new colour contribution point, testExplorer.errorDecorationBackground which theme authors (ie. me 😇) can use to customise the line highlight colour used when a test case fails. The colour inherits from the core colour inputValidation.errorBackground which immediatelly improves how the error decoration looks in built-in themes. It fits much more nicely now!

Any hopes in getting this merged in so I can tweak the highlights in my theme? 🙏 🎨

Thanks for the PR.

Weeey thanks for merging! 🚀🎉


Fixed some spelling errors

I found some little spelling errors in Finnish language on the app. I fixed these and this is also my first little contribution to this project.

👍

Yea, I thought that too! Maybe I sometime do the complete rewording to like "more-professional" words. Now I mostly corrected spelling errors.


memory leak related to uv.send_async

I made an ad-hoc by-line process output reader and it seems that I found a memory leak.
I wrapped into a min working example below. This is supposed to uv.async_send the lines of the output of a certain process. I setup a process that prints data endlessly. The output is stored in current_chunk, but it's only temporary: each time data arrives, I look at the chunk and extract the lines, except for the last one (in case the last line did not arrive completely).
If you keep the uv.send_async line below, memory consumption of the lua process will grow endlessly. If you remove it, the memory consumption remains still. In both cases, each line is discarded.
local uv = require("luv") -- "luv" when stand-alone, "uv" in luvi apps-- WIP luv (related to luvit)

local stdout = uv.new_pipe()
local handle, pid =
   uv.spawn(
      "yes",
      {stdio = {nil, stdout, nil},
       args = {}
      },
      function(code,signal)
         -- ignore
      end)

local current_chunk  = "" -- accumulated data until a \n
local no_more_output = false
-- process each line
cb = uv.new_async(function(line)
      -- discard line
      if no_more_output then
         cb:close()
      end
end)

uv.read_start(stdout, function(err, data)
                 assert(not err, err)
                 if data then
                    -- append received data into current_chunk
                    current_chunk = string.format("%s%s", current_chunk, data)
                 else
                    no_more_output= true
                 end

                 -- split chunk into lines to send to `callback`
                 lines={}
                 for line in string.gmatch(current_chunk, "[^\n]+") do
                       table.insert(lines, line)
                    end
                    if not no_more_output then
                       -- pop last chunk back into current chunk for next iteration
                       last_item_position = #lines
                       current_chunk = table.remove(lines, last_item_position)
                    end

                    -- send the lines to the callback
                    for _,l in pairs(lines) do
                       -- this line below creates a memory leak
                       uv.async_send(cb, l)
                    end

                    -- close uv stuff if everything's done
                    if no_more_output then
                       uv.async_send(cb, nil)
                    end

end)
uv.run()

Happens with these lua versions:
% lua -v
Lua 5.3.3  Copyright (C) 1994-2016 Lua.org, PUC-Rio
% luajit -v
LuaJIT 2.1.0-beta3 -- Copyright (C) 2005-2017 Mike Pall. http://luajit.org/

As far as I can tell, what's happening here is this, from the Libuv docs:

Warning: libuv will coalesce calls to uv_async_send(), that is, not every call to it will yield an execution of the callback. For example: if uv_async_send() is called 5 times in a row before the callback is called, the callback will only be called once. If uv_async_send() is called again after the callback was called, it will be called again.

Luv currently expects a callback for every call of async_send to be able to free the memory for the data sent. Since not all sends are actually getting a callback called, though, that memory is never being freed.
With your example code, a script that prints the numbers 1-100, and a couple prints added:
read_start cb	"0\n"
lines to be sent	{  }
read_start cb	"1\n2\n3\n4\n5\n6\n"
lines to be sent	{ "01", "2", "3", "4", "5" }
read_start cb	"7\n8\n9\n10\n11\n12\n13\n"
lines to be sent	{ "67", "8", "9", "10", "11", "12" }
async cb	{ "12" }
read_start cb	"14\n15\n16\n17\n18\n19\n20\n"
lines to be sent	{ "1314", "15", "16", "17", "18", "19" }
read_start cb	"21\n22\n23\n24\n25\n"
lines to be sent	{ "2021", "22", "23", "24" }
async cb	{ "24" }
...

That's 2 async_cb's called for around 24 async_send calls.
I'm not totally sure what the solution here would be, though.

This is actually both a memory leak and a bug, as we are just dropping data here that we shouldn't be. Minimal test case:
  test("multiple sends coalesce", function(print, p, expect, uv)
    local async
    async = uv.new_async(expect(function(data)
      p(data)
      uv.close(async)
    end))
    uv.async_send(async, 'this string will be lost')
    uv.async_send(async, 'this string will be sent')
  end)

This will only print
"this string will be sent"

meaning the "this string will be lost" string is both leaked and is never sent to the send callback.
I think we need to treat async data as a stack that we push onto in luv_async_send and then pop until it's empty in luv_async_cb, calling into Lua with the popped data each time.

Seems like a good fix, but I wonder if any users are somehow relying on the libuv behavior.

Libuv doesn't handle any passing of data, so the coalesced callbacks are reasonable (the only intention of Libuv's async is just to wake up a thread).
I guess it's possible that some Luv user is calling async_send with the same data multiple times and then expecting only 1 callback call with that data, but it seems fairly unlikely, and, with our current implementation, that will leak the data for every coalesced callback.
It's a little unfortunate that our binding does not match the Libuv code; it'd probably be better if we had split the actual data sending part into a luv-specific function (async_send_data or something).

Ah okay. A queue makes sense then.

I don't mind changing my code at all, although I believe anyone using uv.send_async should be covered by either fixing this coalesced-call-memory-leak within luv code or by the leak being thoroughly documented (perhaps a warning?)


Panic instead of exit, so we can recover and retry

We are using go-pivnet to automate installs of PAS using om-tiler. The payload which drives these installs is a single go binary, which has retry logic build in. However as of lately we often have customers complain about stalled installs. After investigation we found the root cause to be related to the use of log.Fatalf in the go-pivnet library. Since log.Fatalf calls os.exit(1) which gives us not way to recover.
Switching to log.Panicf will allow us to use recover to retry temporary issues. The error we are facing is:
2019/06/22 13:09:27 Exiting with error: API token request failed: Post https://network.pivotal.io/api/v2/authentication/access_tokens: dial tcp: i/o timeout

Which should be fine to retry.

We'll take a look at this pull request and get back to you, @rkoster .

@rszumlakowski Thanks!


Adds French Guiana nationality

Source: https://en.wikipedia.org/wiki/French_Guiana

@baron816, could you run rake update_cache on this.


Cordova app with angularjs

I am trying to make android mobile app using ionic. I have created an application in MEAN.js framework and it is working properly and now i am trying to convert this application into an android mobile application so i tried a lot but could not find a proper solution. Please help me to find the way for creating android mobile app using ionic. Thankyou.

Greetings @NavneetNile!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Greetings @NavneetNile!
My sensors indicate that you have created an issue on our tracker requesting usage help, rather than an actual error with Ionic framework.
This GitHub issue tracker is used to track framework features, problems, and development.
If you wish to get help using the framework itself, the recommended place is the forum. There are many humans there who would be happy to offer sage advice.
Thank you for allowing me to assist you.


Fixed bugs when assigning a VLAN to an Interface

Closes #5580
What's Changed

Screenshots

TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example App Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Quick question, how are we checking if VLAN is global? Is it that if there are no locations assigned to the vlan, it is automatically global?

Yes, if there are no locations assigned to the VLAN it's considered Global


bugfix for import error

bugfix for TimeWindow import error

Codecov Report

Merging #229 (9d20a85) into master (c6f04e9) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   44.05%   44.05%
=======================================
  Files         118      118
  Lines       15256    15256
=======================================
  Hits         6721     6721
  Misses       8535     8535

Impacted Files
Coverage Δ

python/mspasspy/algorithms/RFdeconProcessor.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f04e9...9d20a85. Read the comment docs.


fix: BootNotification must respect the OCPP specification

The issue comes from request.BootNotificationRequest which is an empty object and then tsc accept everything instead of "empty object only".

@juherr thank you for taking PR!! seems great 👍👍  I will confirm this in today.

I've confirmed that it works, so I'll merge it. Thank you for the fix PR.


Enable LDAPS connections to Active Directory

This PR adds the capability to use LDAPS to Active Directory. LDAPS will be on by default but fallback to LDAP is automatic if a secure connection can't be established. Customers using private non-public Certification Authorities can upload their trust chain to secret manager to allow for server certificate verification.
This PR closes #41.

@idofl I think this is good to go. Would you mind doing validation against Managed AD?


Make queue for fedora messaging durable

Related to: https://github.com/packit-service/packit-service/issues/221
Feel free to reject if you know of a reason this might break stuff.

No idea how it works, let's wait for @rpitonak

We set it also in the fedora-messaging config so I'm wondering which one takes precedence.

So I tried to set that to True and it doesn't seem to work for me:
[WARNING pika.channel] Received remote Channel.Close (406): "PRECONDITION_FAILED - inequivalent arg 'durable' for queue '36C4424F-5FA4-4DE1-B898-A05AD6F0CB03' in vhost '/public_pubsub': received 'true' but current is 'false'" on <Channel number=1 OPEN conn=<SelectConnection OPEN transport=<pika.adapters.utils.io_services_utils._AsyncSSLTransport object at 0x7f6e831c63d0> params=<URLParameters host=rabbitmq.fedoraproject.org port=5671 virtual_host=/public_pubsub ssl=True>>>
[INFO fedora_messaging._session] Channel <Channel number=1 CLOSED conn=<SelectConnection OPEN transport=<pika.adapters.utils.io_services_utils._AsyncSSLTransport object at 0x7f6e831c63d0> params=<URLParameters host=rabbitmq.fedoraproject.org port=5671 virtual_host=/public_pubsub ssl=True>>> closed (406): PRECONDITION_FAILED - inequivalent arg 'durable' for queue '36C4424F-5FA4-4DE1-B898-A05AD6F0CB03' in vhost '/public_pubsub': received 'true' but current is 'false'

:(
it would make sense to look how fedora infra projects set up their queues

So I tried to set that to True and it doesn't seem to work for me:

That was because I tried to connect to already existing queue with different durable arg.
Using a new queue uuid works OK.
Anyway, we don't set it in code anymore so I'll create a new PR.


Update Fennel lexer to include forms from latest version.

Also separate out declarations from other special forms and macros.

Merged, thanks for the contribution!


VS 2022 cannot find path to MSBuild.

Hi
Used version: 1.1.4
The logic for getting the path to MSBuild.exe is failing for the following reason:

When using msbuild.config('version', '17.0');
VS 2022 is installed under 'Program Files'.
The location of MSBuild is here: C:/Program Files/Microsoft Visual Studio/2022/Community/MSBuild/Current/Bin/MSBuild.exe
Node process.env['ProgramFiles'] gives 'C:\Program Files (x86)'

Debugging is really hard because errors are being logged to console, which is not visible when invoked outside of the command line.
if(msbuildDir === undefined){
console.log('** Could not find VS IDE / tools install folder. Please install at least the VS Build Tools in the "programFiles" dir. **');
}

Also after this error, the code just carries on without terminating causing the whole process to crash.

Resolved in commit 6fb5d83. "Add log to file for improved troubleshooting. Add support for env build path."
See readme for an alternative way to set build paths using the environment variable "MsbuildPath".

Not sure why this was closed or what has been fixed.
The path is currently resolving to non-existent file C:\Windows\microsoft.net\Framework\v17.0\msbuild.exe.


underline showing in the rendered HTML as

Any ideas why underline is showing in the rendered HTML as <!----> instead of <u></ul>?

No, no ideas.


[RTMP] How to push a local video when there are no livestream.

Hello, i'm sorry if the problem has already been post.
I'm actually looking to a ningx rtmp server which send video flux to Twitch.
But (obviously there is a but) , i'm looking to have a server which do the following :

If no one send a flux with OBS or XSplit, the server send a local video to Twich
If someone send a flux, the server switch to this flux whitout being deconnected on Twitch
The server switch again to the local video when the flux get stopped.

I think there is some issue with on_play or on_connect but i'm not sure about how it's works.
If anybody have any idea, it coul'd be great.
P.S : Actually, it's possible to have little delay offline between the switch because it could be possible to have a computer which take the flux from the server then send it to Twitch, so i'll juste have few seconds black screen i guess.
Thanks a lot for your time.

+1

+1

+1

+1


Bindless Validation: Instrument descriptor-based loads and stores

Essentially, support UBOs and SSBOs, scalar and array (sized and unsized).

The shaderc smoketest was the only CI failure and I am pretty sure it was not due to my change which was isolated to --inst-bindless-check which is not (at least should not) be part of any compilation outside of the GPU Validation Layer.

Agreed, the smoketest failure is a symptom of the fact that https://github.com/KhronosGroup/SPIRV-Headers/pull/103 was merged but the Glslang had not yet updated SPIRV-Headers for its own tests, so validation results are different.


Add tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d235cf3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   75.94%
=======================================
  Files           ?       11
  Lines           ?       79
  Branches        ?        0
=======================================
  Hits            ?       60
  Misses          ?       19
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d235cf3...ff544dc. Read the comment docs.


Investigate GraphQL controllers

Investigate abstraction for creating GraphQL instead of REST-ish controllers.

3 years later, what is the recommended way of doing GraphQL with Saturn now? Is there any? Is it possible (in a production quality/setup)?

@AlexeyRaga Probably the best way right now is not to involve Saturn and use AspNetCore middleware from

graphql-dotnet pretty solid and pretty popular but a bit too low-level in my experience (using this in production)
hot chocolate newer solution than graphql-dotnet and removes a lot of boiler plate when mapping types (haven't tried it but it looks like it solves lots of issues that graphql-dotnet has)
FSharp.Data.GraphQL native F# implementation of a GraphQL server that might need a bit of glue to hook into Saturn but it is also a bit low-level like graphql-dotnet

You will need to experiment with these to see which one suits your needs the best


MAINT: stats.gaussian_kde: raise informative message with degenerate data

Reference issue
gh-10205
What does this implement/fix?
gh-10205 reported that gaussian_kde raised a confusing error for their data. The data is degenerate: it lies in a lower-dimensional subspace of the space in which it is expressed. This PR documents that gaussian_kde does not support such data and attempts to clarifies the error message and outline a possible solution.
Additional information
After merging this, we can remove the defect label from gh-10205 and use it to track two enhancements for KDE: support for singular matrices and eliminating regular use of the covariance matrix inverse (gh-5087). I think we can accomplish both with scipy.linalg.ldl.

Looks like I need to add the error in a second place or maybe at a higher level.

Except for the test failure, yeah.

Thanks @rkern. Looks like those are resolved and the two CI failures are unrelated and being worked on. Please merge if it looks good to you, or let me know if you want someone else to review.


add "sidewalk=none" to list of deprecated tags

This PR standardizes the tag for streets that don't have sidewalks to sidewalk=no, which is the tagging used by both JOSM and iD.

In addition,

sidewalk=no is the tagging used by Vespucci
sidewalk=no is the tagging used by StreetComplete (which was recently updated in streetcomplete/StreetComplete#3194).  Note that the prior use of sidewalk=none in StreetComplete was likely the cause of the recent 100K tag increase of sidewalk=no; the tagging schema change here will help maintain consistency across the community of OSM editing software.

@ZeLonewolf Have you opened or found equivalent JOSM issue already? (at https://josm.openstreetmap.de/)

@ZeLonewolf Have you opened or found equivalent JOSM issue already? (at https://josm.openstreetmap.de/)

@matkoniecz it appears that JOSM is already using sidewalk=no, which is consistent will all the other editors.  So it looks like no change is needed in JOSM.  Here's a screenshot I took of the the street dialog with the sidewalk pull-down menu opened:

I was thinking about equivalent of this one - validator asking to replace none by no

Good point!  I will make an issue in Trac.

Good point!  I made an issue in JOSM's issue tracker:
https://josm.openstreetmap.de/ticket/21242

The wiki now https://wiki.openstreetmap.org/wiki/Key:sidewalk#Deprecation_of_sidewalk.3Dnone has this to say:

[…] the deprecation of sidewalk=none in favour of sidewalk=no, though retagging is not always supported. […] Please note that updating none to no without manual review should be done in compliance with the Automated Edits code of conduct.

I think that this means that we should put this on hold for now.
Btw, here's a recent usage comparison:

It seems clear that the growth spike of sidewalk=none was entirely fueled by SC mistake and once it went away it went to being dead

@tyrasd What else do we need here? Are you expecting formal deprecation proposal before adding this deprecation rule?
In my opinion tagging situation is clear enough in this case

sidewalk=no has gotten approximately 100k more instances over the last 4 months while sidewalk=none is pretty much stagnant. I don't think that there is any reason to delay adding this deprecation rule.

Going by https://github.com/openstreetmap/id-tagging-schema/issues/401#issuecomment-1133035676 - though it is a bit different one, as it is about no longer promoting tag rather than active deprecation

until we have at least one of the following:
the tag's status is deprecated on the wiki
there is significant drop in usage compared to the current numbers and negative trend
usage of the tag remain stagnant for a longer time (~1 year)

Stably listed as deprecated at https://wiki.openstreetmap.org/wiki/Key:sidewalk#Values
http://taghistory.raifer.tech/#***/sidewalk/no&***/sidewalk/none shows completely flat organic use (while sidewalk=no use increased by 500 000 and doubled), with some drops from bot retagging
new organic usage is not there at all

I also considered proposing worldwide bot edit retagging remaining cases.

I have actually unwittingly submitted this change as part of a larger PR with typos for sidewalk tags: #1278. I'd be happy to remove the none→no deprecation from my PR in favor of this one.
In any case, I thought I'd add my voice to the comments above and the general sentiment in the other discussions linked from the wiki, which IIUC pretty much all agree with deprecating none as long as it's explicitly documented as such (which has been the case for almost 3 years now).

@waldyrious no pride in ownership here.  If your PR is merged, I'll happily close this one as complete.

I agree, we should merge this. It is on the edge of of what we call "clear cut" PRs in our WIP process guidlines. But given the consensus here and overall, I thing this is fine.
A bit of documentation:

The wiki still says the same. Which I consider a good enough +1.
Side note: It would be great if we where used clear message in the wiki like "X is deprecated, use Y instead"
The usage stats show a downward trend and the other tag has now significant more usage. This trend is what Martin was waiting for last time, so also a +1
Side note: It will be interesting to see if this change will reduce the numbers.
The JOSM ticket has no progress for the last 2 years and and the discussion there read similar to the one here. Maybe the merge here will trigger activity there as well. +0

Other notes:

I extended the WIP guidelines with the "indicators for consensus" that you linked, @matkoniecz, thanks for that. https://github.com/openstreetmap/id-tagging-schema/pull/1229/commits/6776de01e228681d671186e8bc7d412c22aaabd0
We really should add proper sidewalk fields to make all the existing data visible. I hope that this will be easier once https://github.com/openstreetmap/id-tagging-schema/issues/1202 continues.
PS: Lets not forget the :both variant, @waldyrious :-)


DatePicker and DPField accept a Date object

General summary
Allow <DatePicker /> and <DatePickerField /> to accept a javascript Date object as property.
Check list

[ ] (if has style) Add need: review-integration label
[ ] (if has textual documentation) Add need: review-doc label
[x] (if has code) Add need: review-frontend label
[x] (if has react) Check through the react dev check list
[x] (if fix or feature) Add need: test label

Check out the contribution guide for general guidelines for submissions to the design system.

@pidupuis Does it seem ok to you?
Also we need to test the compatibility with your PR https://github.com/lumapps/design-system/pull/384

@maximevast Could you make the two merge commit disappear the commit history?
We prefer having clean commit history in PRs (by rebasing onto master rather than merging master into the branch)

Done :)


Cache binaries when running "node dist\cli.js run-tests underscore" multiple times

When working on a type definition and running node dist\cli.js run-tests underscore multiple times the flow binaries are downloaded each time and I was wondering, if they could not be cached?
There is actually caching in place but it is broken on the windows platform.

Fixed with PR #831


add a way to open code examples directly in Sketch

We could add a url scheme handler to open the Run Script panel with a given code, that way we could add buttons in the documentation to open code examples directly in Sketch

Potentially nice to have, a copy-past does the job for now which could itself be improved by including the copy source button as found in many other documentation websites.


HDDS-5733. Incorrect calculation of iteration related metrics in ContainerBalancer

What changes were proposed in this pull request?
ContainerBalancer incorrectly calculates dataSizeBalancedGB and countDatanodesInvolvedPerIteration. Datanodes involved are counted twice if they had been involved earlier.
This Jira fixes these bugs.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5733
How was this patch tested?
TestContainerBalancer UT

@lokeshj1703 @JacksonYao287 please take a look!

@siddhantsangwan Thanks for the contribution! @JacksonYao287 Thanks for the review! I have committed the PR to master branch.


build: implement integration test for zksync contracts

This pr closes #186

An extra comment, what is the prefunded initial balance of the wallets?
If you are setting up balances manually, I think it is too high. For tests purposes, try to set to 1000ETH

An extra comment, what is the prefunded initial balance of the wallets? If you are setting up balances manually, I think it is too high. For tests purposes, try to set to 1000ETH

The balance of the prefunded wallets is automatically set in the used Dockerized L1-L2 chains, altering these values wouldn't be easy.


Start Zhizuku Server without adb on no root devices

Brevent app here has experimental mode where the server can be started without adb.
https://github.com/brevent/Brevent
Is it possible to start Shizuku Server using a similar technique?

Did you mean network adb?
https://github.com/brevent/Brevent/blob/master/brevent/src/main/java/me/piebridge/brevent/ui/SimpleAdb.java
It's simple version of network adb, and I think it's easy to implement it use third-party library.
Brevent cannot be started without adb on unrooted devices.

it seems @rexii2300 has misunderstanding on Brevent: https://github.com/brevent/Brevent/issues/3
just close it.

@liudongmiao I opened this issue before we clarified the server and root requirements. I now understand Brevent can't be started without adb on unrooted devices. I'll close the comment now


Feature/octo 1253 expan results in json

implementation not ideal, currently it depends on a fixed results structure in regards to labels (variant, metric, subgroup_metric, subgroup, statistic, pctile, value)
does not support results created by trend() because of indexing issue and the addition of a new label (time)
this may be enough for now, but needs to be revisited

Coverage increased (+0.4%) to 77.015% when pulling fd5000a6b514e32b377f0cf465a6446d47f48c17 on feature/OCTO-1253-expan-results-in-json into d7f6efd1e8b66c8f677b4aa0c902ccb276f48e86 on dev.


feat: Flex component

Overview
New Flex and FlexItem primitives.
Will eventually replace Container and Item.
PR Checklist

[ ] Related to Abstract designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

Description

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f43f6fcad68b0c55cdc8c69--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f43febd804ed2336961b88d--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f43ffabbef76351411cb039--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f442ea277c0ad012ed43204--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f4431ea43b9411b621733a7--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f443b9a35d6746aff64b20c--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f4444ae43b9412b9c172f8a--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f4583a70acf0cf597ccfd44--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f458f6ac5e307989f9719d7--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f45909e76e2089b7cc06774--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f45939e76e20886e1c06ab2--gamut-preview.netlify.appDeploy Logs


Update ammonite-repl, ammonite-repl-api to 2.1.0

Updates

com.lihaoyi:ammonite-repl
com.lihaoyi:ammonite-repl-api

from 2.0.4 to 2.1.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi" } ]

labels: library-update, semver-minor

Subsumed by https://github.com/almond-sh/almond/pull/565.


Update DP count/histogram and add documentation

I am currently working on the following:

Add more fleshed out documentation for the remaining proto json files.
Update DP Count/Histogram to have reasonable default min/max values.

We merged this PR but I'm leaving it open for now because of histogram bugs -- @Shoeboxam and I are talking about it


Unpublish request for chat contain file for version if file was unpublished earlier with another version of chat

EPAM AI DIAL chat version
0.21.0
How to reproduce
Steps:

create chat with file
create publication request for chat with file v0.0.1
by admin approve request
create publication request for chat with file v0.0.2
by admin approve request
create unpublish request for chat with file v0.0.2 -> chat and file were unpublished, file was removed from Manage attachments from Organization
create unpublish request for chat v0.0.1 -> request form contain file section -> bug

Actual result
creation unpublish request failed with error
Expected result
if file from chat was unpublished earlier than next unpublish requests for other versions should not contain file in request
Confidential information

[X] I confirm that do not share any confidential information

Temporarily remove files from unpublish requests untill nested folder concept is ready.

Ticket can not be tested until concept of unpublish files will be defined


Recurrence evaluation increases modelsize

Hey guys,
I noticed after performing:

one train iteration
set model:evaluate()
one evaluation iteration
set model:training()
while using a Recurrence with an rnn module (e.g. FastLSTM)
the modelsize increases and increases until the memory (GPU-RAM) is full.

The file is a small example demonstrating the issue.
Watching the GPU memory (Nvidia):
watch nvidia-smi

So far I could reproduce it on three different computers.
Can anybody with a deeper knowledge of the recurrence modul tell me what I am doing wrong?
Thx guys
test.txt
require 'torch'
require 'cutorch'
require 'nn'
require 'cunn'
require 'rnn'

local tempm =
        nn.Sequential()
        :add(nn.CSubTable())
        :add(nn.FastLSTM(1000,300,3))
        :add(nn.Linear(300,1000))
        :add(nn.Sigmoid())

local model = nn.Sequencer(
       		nn.Recurrence(tempm, 1000, 1, 3)
            )

local criterion = nn.SequencerCriterion(nn.BCECriterion())

model:cuda()
criterion:cuda()
model:zeroGradParameters()
model:training()

local inputs = { torch.rand(1000):cuda() , torch.rand(1000):cuda() , torch.rand(1000):cuda() }
local targets = { torch.rand(1000):cuda() , torch.rand(1000):cuda() , torch.rand(1000):cuda() }

for i=1, 100 do
	model:zeroGradParameters()
	print('Epoch '..i..' training:')
	for ii=1, 500 do
		local outputs = model:forward(inputs)
		err = criterion:forward(outputs, targets)
		local gradOutputs = criterion:backward(outputs, targets)
		model:backward(inputs, gradOutputs)
		model:updateParameters(0.001)
		model:zeroGradParameters()
	end

	print('Epoch '..i..' eval')
	model:forget()
	model:evaluate()
	for ii=1, 100 do
		local outputs = model:forward(inputs)
		err = criterion:forward(outputs, targets)
	end
	model:forget()
	model:training()
end

@angelifrangite The problem seems to be with evaluation. Looking into it.

yes I think so too.
While debugging I noticed that just calling
model:evaluate()
model:training()

doesn't produce the problem.
Just the
model:forward()

seems to set something internally that is not resetted by :training()
Sorry for not providing better information.

@angelifrangite Just noticed that you are using a FastLSTM within your Recurrence. That is really non-standard, or at least it is a use-case we have yet to unit test. So I think the issue has something to do with the fact the forget() isn't being propagated to FastLSTM. Let me build this into a unit test and find a fix.

@angelifrangite This https://github.com/Element-Research/rnn/commit/48d1cdd3482980abdfc6f1c53bebaba5608f504f fixes it . Thanks for letting us know!

Holy...that was fast. It works perfect now!
Thank you very much.


Failed to install debian package of on-http, on-tftp, on-dhcp-proxy, on-taskgraph, on-syslog

For example,  I tried to run command :  "apt-get install on-http" and get error message:
Service disabled due to absence of /etc/default/on-http
invoke-rc.d: initscript on-http, action "start" failed.
dpkg: error processing package on-http (--configure):
 subprocess installed post-installation script returned error exit status 1

@PengTian0 : You are following the install instructions from the readthedocs?
http://rackhd.readthedocs.io/en/latest/rackhd/ubuntu_package_installation.html
Section <IP_ADDRESS>.

No..  I can install it follow the instructions now.
Thanks!
But I'm curious about why we create a empty file under /etc/default .
The files under /etc/default are configuration files.
But RackHD already puts configuration file under /opt/monorail.

@pscharla : I followed the install instructions Section <IP_ADDRESS>(b)
The instructions tell users installing rackhd before touching /etc/default/$service


Create Prime_sieve.cpp

Created the prime sieve code with Comments for every logic.

@avinash201199  please review it and merge it . I have added comments.


[Docs] Clean some components

That is some hard work. thanks a lot :+1: :+1:

fix that little thing and then merge. it's all good :+1: :+1:

:scream: :scream: I can't believe I forgot to export it! Thanks a lot @oliviertassinari :grin:
This is ok to merge :+1: :+1:

@alitaheri Perfect, that's just the beginning. I'm gonna implement some of https://github.com/callemall/material-ui/issues/2435. I need a better mobile interface, before starting on react-native.

Sounds good to me. I'm gonna focus on some issues, regressions and migration of Docs. so we can release 0.14.1 fast! people are waiting for the regressions to go away :D


Border, Padding, and Margin shorthands

Shorthand helpers for border-width, border-color, border-style, margin, padding, and the general directionalProperty helper.

@mxstbr Wanted to get your eyes on this implementation before I wrote up the docs for it.

Looks really good from a first glance! 😱

Current coverage is 100% (diff: 100%)

Merging #56 into master will not change coverage

@@           master   #56   diff @@
===================================
  Files          18    25     +7
  Lines          73    96    +23
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
+ Hits           73    96    +23
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update c800b90...7043d14

@mxstbr should be good now.

I'm seeing some totally unrelated commits we already have in master here?

Odd I'm not seeing those, let me re-push the rebase onto master and see if that fixes it for ya.

k @mxstbr did another force push of my branch. I've had some wonkiness going on with my pushes today, as I'm working from Taiwan and the connection isn't always stable. Hopefully that fixed it.

Awesomeeee!!


ConditionalAccessPolicy Requires Interactive Session

It's not possible to run the following in a non-interactive PowerShell session:
Set-SPOTenant -ConditionalAccessPolicy BlockAccess
It instead provides an error:
Set-SPOTenant : Windows PowerShell is in NonInteractive mode. Read and Prompt functionality is not available.
When running interactively, it returns a confirmation prompt as follows, which cannot be bypassed with a -Force prompt (parameter cannot be found).

[Y] Yes  [N] No  [S] Suspend  [?] Help (default is "Y"):

Expected behavior is that the parameter responds to a -Force command, or does not require a prompt. Other parameters that I've tested don't have this behavior. Is there a way to bypass this prompt for non-interactive sessions?

Small addition: it also doesn't respect -Confirm:$false. Again, 'a parameter cannot be found that matches parameter name 'Confirm'.

Hello @gh05ted how are you? Hope you are doing great.
I checked and as you say, this cmdlet does not supports -Force parameter. So for that inquiry I need to kindly suggest https://sharepoint.uservoice.com/ that way, your request can reach the product team so they add support for it.
Thank you

Thanks @get-itips. Raised: https://sharepoint.uservoice.com/forums/330318-sharepoint-administration/suggestions/40953460-enable-setting-conditionalaccesspolicy-without-int

Thanks @get-itips. Raised: https://sharepoint.uservoice.com/forums/330318-sharepoint-administration/suggestions/40953460-enable-setting-conditionalaccesspolicy-without-int

Great! will vote for it.

@gh05ted  Thank you very much for your kind feedback also thanks for logging this issue as a User Voice. Concerning team will evaluate and take the appropriate action, as per their schedule. We proceed here to close it. Thanks again for taking out some time and sharing your feedback.

It doesn't make sense to have to "vote" to have the very basic and well-established -Confirm switch implemented.


WASI Support

Hey I'm interested in this project, as it solves a problem I've had with a lot of my projects. One of the main languages I'm interested in generating types for is WASI (WebAssembly System Interface), is there interest in the project to support WASI?

Hi @XAMPPRocky, while I don't know any alternatives specifically for WASI, I do know a great resource for generating TypeScript bindings from Rust+WebAssembly projects: tsify.
I had actually given a talk about it a couple of months ago, here are the repo and slides.

I think that would require #![no_std] support to be added

typeshare actually works on #![no_std]. You just have to use the typeshare_annotation crate directly, as the core crate pulls in std dependencies, presumably for Kotlin and Swift FFI.


adding "-ignore-contents" option to "drive diff"?

Currently I see that the command drive diffcompares the contents of files which are present on both sides but have different time stamps. It even displays the differences between text files.
However, I think it could be very useful for (at least some) users if we could choose comparing time stamps only, for example by adding another option like -ignore-contents.

Hello @Sadi58, thanks for this request and welcome to drive, if I hadn't yet welcomed you.
So I see, you are suggesting some sort of short mode, right?

@Sadi58 thank you again for the feature request, addressed by PR https://github.com/odeke-em/drive/pull/587. Please get the latest from master, if you might not already know, it can be done by
$ go get -u github.com/odeke-em/drive/drive-gen && drive-gen

Please re-open if the problem persists.

Thanks a million!!!
I'm currently using the latest version at http://ppa.launchpad.net/twodopeshaggy/drive/ but will try this new feature as soon as I can switch to the git version or the ppa gets updated ( whichever comes first ;-)

Now that PPA has been updated I'm glad to report gratefully that this works like a charm! :-)


Incorrect amount of "lines" in XML formatter

Current behavior
Incorrect amount of "lines" when switching the indentation to 4 spaces in the XML formatter output.
Meanwhile it doesn't appear to properly recognize two spaces in the input.
How to reproduce it (as minimally and precisely as possible)

Expected behavior
I would expect the divider lines to match the provided, if not in-, at least the selected output
Screenshots
No response
Workaround
No response
Affected platforms
Windows
Affected DevToys kind
DevToys (app with GUI)
DevToys Version
Version <IP_ADDRESS> | X64 | RELEASE | 94bb8213 | 94bb8213
Relevant Assets/Logs
No response

This issue also exists with json, but there the lines are always at 4 spaces regardless of what the indentation is set to.

Hi,
I'm not sure to understand the behavior that you expect. Would you like to preserve the 2 extra spaces in  that are in addition to the 2 spaces indentation in the input?

On the left side you can see how the vertical bars are correctly indented at once every four spaces. On the right, however, the vertical bars are at once every two spaces. They don't dynamically adjust to the selected indentation of four spaces and always remain at two.
Json files have the same issue in reverse, where the vertical bars are always set for an indentation of four spaces.

Oooooh I see! That's probably because Monaco Editor (the code editor we use) is configured to use a 2 space indentation instead of 4. Good catch!

Not only v1.x; also occurs in v2.0.


could not find any adb devices(USB debugging turned on)

[ ] I have read the FAQ.
[ ] I have searched in existing issues.

Environment

OS: Windows 11
scrcpy version: 2.0
installation method: manual build
device model: Honor X9a
Android version: 12

Describe the bug
It says, "could not find any adb devices". I even have usb debugging turned on! help!

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#device-not-detected

Still not working...

Scrcpy may only work once your device is detected by adb (adb devices). Check stackoverflow to resolve your adb issue.

Still not working...

Have you found any solution for this? I'm facing the same issue


rdar://109108066 (Derive '-external-plugin-path' compiler arguments in SwiftPM)

This derives the required -external-plugin-path arguments when using an OSS toolchain with SwiftPM.

@swift-ci please smoke test

Not really sure how to test this, but I manually checked that all Swift targets get the relevant arguments.

Fun, looks like NSDictionary is different on macOS vs Linux?
/home/build-user/swiftpm/Sources/PackageModel/UserToolchain.swift:459:167: error: extra argument 'error' in call
        if localFileSystem.exists(toolchainPlistPath), let toolchainPlist = try? NSDictionary(contentsOf: URL(fileURLWithPath: toolchainPlistPath.pathString), error: ()), let overrideBuildSettings = toolchainPlist["OverrideBuildSettings"] as? NSDictionary, let isSwiftDevelopmentToolchainStringValue = overrideBuildSettings["SWIFT_DEVELOPMENT_TOOLCHAIN"] as? String {

I guess since this is supposed to be macOS only, we can conditionally compile.

@swift-ci please smoke test

@swift-ci please smoke test windows

@swift-ci please smoke test

@swift-ci please smoke test windows

@swift-ci please smoke test windows

@swift-ci please smoke test

@swift-ci please smoke test windows

@swift-ci please smoke test windows

@swift-ci please smoke test windows

No Windows, I guess  ¯\_(ツ)_/¯

@swift-ci please smoke test windows


Update link to dcms in setup.md

Fixing link to download DCM files
Related issues
Customer notified us of issue of broken link
Testing
Describe how this change was tested.

/azp run

/azp run


[1.21.1-1.5.1] ModifyTrinketSlot Power does not work

Hello, so I tried shappoli's ModifyTrinketSlot Power. I tried adding a glove slot, but it did not work.
This is my JSON Content for the power:
{
  "type": "shappoli:modify_trinket_slot",
  "modifier": {
    "slot": "hand/glove",
    "operation": "addition",
    "value": 1
  }
}

Is it not working currently, or am I doing something wrong?

So I am guessing, the data field modifier tries to use the vanilla one.
Maybe renaming "modifier" to "slot_modifier" might work?
[18:09:08] [Render thread/ERROR] (Apoli) There was a problem reading power "namespace:gauntlet_slot" from data pack [namespace]: Error decoding data at field modifier: Required field "id" is missing!

Hi there, thanks for reporting the issue!
The documentation for Shappoli 1.21 currently might be a little out-of-date because of a bunch of internal Apoli/Origins changes. I intend to update it when Origins starts releasing stable versions.
Since 1.21, "Slot Entity Attribute Modifiers" requires the id field to be present. Also I think "addition" operation is no longer valid and you should use "add_value" instead. So your power should look like this:
{
  "type": "shappoli:modify_trinket_slot",
  "modifier": {
    "id": "example:your_modifier",
    "slot": "hand/glove",
    "operation": "add_value",
    "value": 1
  }
}
``` [Here](https://github.com/shap-po/shappoli/blob/1.21.1/src%2Ftest%2Fresources%2Fdata%2Fshappoli%2Fpowers%2Ftrinket%2Fadd_trinket_slots.json) is an example of the power that should work. You can see up-to-date power examples in the test directory on GitHub.
Hope I could help and let me know if you have any other questions!

Okay, thank you.
However I think there is another bug. You can't add a slot when it is not defined before in the trinkets json.
But when I add, for example another glove slot, there is an index out of bounds exception:
Here the disconnect log:
https://mclo.gs/c4u9b3W

Thanks for providing the log! Gonna check it in a few days once I have a free time


File.Read and file.write suggestions

I had a few suggestions for the File class
File.Read and File.Write should by default use the size of the object for the last parameter.
File.Read and File.Write should take in all basic data types..
object
uint
int
byte
byte[]
float
double
decimal
bool

best way to do the first suggestion would to be make buffer types that the user can pass in
File.Write(data, DataType.uint)

data = File.Read(DataType.uint)

Good idea !
Here is the example code you can use in 11.0.22(https://www.nuget.org/packages/Love2dCS/11.0.22).
using System;
using Love;

namespace Test
{
    [Serializable]
    struct Player
    {
        public float x;
        public float y;

        public override string ToString()
        {
            return $"{{{x},{y}}}";
        }
    }

    class Test : Scene
    {
        public override void Load()
        {
            string pathBool = "data-bool.dat";
            Resource.SaveData(pathBool, false);
            Console.WriteLine("data  " + Resource.LoadData<bool>(pathBool));

            string path = "data-player.dat";
            var p = new Player();
            p.x = 123.2f;
            p.y = 20.2f;
            Resource.SaveData(path, p);
            Console.WriteLine("data  " + Resource.LoadData<Player>(path));
        }

        public static void Main(string[] args)
        {
            Boot.Init(new BootConfig
            {
                WindowWidth = 400,
                WindowHeight = 400,
            });
            Boot.Run(new Test());
        }
    }
}


Ericderegt patch 1

Update README and yml

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7086f01). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #2   +/-   ##
========================================
  Coverage          ?   94.8%
========================================
  Files             ?       2
  Lines             ?     250
  Branches          ?       0
========================================
  Hits              ?     237
  Misses            ?      13
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7086f01...230eb38. Read the comment docs.


Abbreviations have many duplicate expansions

Now that we can use NASA-Acronym.py to query the acronyms.json file from the command line, I have noticed that many abbreviations have similar expansions.
@joelmalissa asked me to design a tool to find the duplicate expansions so they can be addressed.
By my count there are a total of 43054 acronyms, 21761 of them are overloaded (having multiple expansions), and from that list there are 2845 that have possible similar expansions (spelled slightly differently, or different punctuation).
Examples: FFRR ATL PRSD ...
$ python3 NASA-Acronyms.py -vvv FFRR
First-Flight Readiness Review                                LaRC      8192  2
First Flight Readiness Review                                HSF       4333  3
$ python3 NASA-Acronyms.py -vvv ATL
Advanced Technology Laboratory                               LaRC      1775  2  <--
Attitude Timeline                                            LaRC      1776  2
Atlanta International Airport                                LaRC      1777  2
Advanced Technology Laboratories                             HSF       993   3  <--
Aero-Thermal Lab (Marquardt)                                 HSF       994   3
Avionics Test Laboratory                                     HSF       995   3
$ python3 NASA-Acronyms.py -vvv PRSD
Power Reactive Storage and Distribution                      LaRC      19146 2
Power Reactant Storage and Distribution                      LaRC      19147 2

The code is not ready yet, but I came up with something here: https://gist.github.com/mbruzek/dccc141a498a7eca19ca2c3183595069

@joelmalissa contacted me and asked for less verbosity. I strongly believe that you need to see ALL the expansions for context when trying to decide which duplicate to eliminate, but I came up with a new find_similar.py that lets you set the verbosity level.
https://gist.github.com/mbruzek/89efbf573409f7d9ecfa9413abc2d63e
Run the program with one level of verbosity like this:
$ python3 find_similar.py -v

$ python3 find_similar.py -vv


Permit setting account member status directly in Terraform schema

Currently, the status always defaults to "" which translates to "pending" by default, but this change allows setting a status attribute in the Terraform schema.
Closes #1654

thanks for the PR! 🙌


Add files via upload

Create bztg-oldenburg.de
IT long term classes:
2 years: https://www.bztg-oldenburg.de/bildungsangebot/technikerschulen/elektrotechnik/
3 years: https://www.bztg-oldenburg.de/beruf/it-systemelektronikerin/
...
Thank you!

Let' s add a contributing file, so we can work better, together!
stanislas-paris.txt

@stefanrosemann Pull request merged. Thank you!
@stanroux16 Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new separate request with correct information. Thank you for your understanding!


Google Safe Browsing has set your site to unsafe

when visiting the site i got this:

so i proceeded and tryed to download a file then got this notification:

Same here when visiting today.

Use this one DownGit

found problem
safe browseing report
i assume someone used downgit to download malware hosted on github to others computers.

Duplicate of https://github.com/MinhasKamal/DownGit/issues/58 but this issue has more info

Have you seen this guy's other repos? No wonder this gets flagged! https://github.com/MinhasKamal?tab=repositories&sort=stargazers&type=source

I had the same issue in my tool but I was able to fix it by blocking specific URLs.

https://github.com/download-directory/download-directory.github.io/issues/112

Until DownGit is fixed, you can use either GitZip or https://download-directory.github.io

Use this one DownGit Whit out issue


Expose tags, original operation and preprocessing data

Hi :)
I'm working on a tool that uses openapi-to-graphql internally, and I needed a few minor changes in the source code:

Expose tags from source OAS as part of the operations. This is useful because other OAS tools uses tags.
Expose the raw OAS operation object.
Allow access to the preprocessing (IR) object to make it simple to access data.

As a side note, a few points to improvement:

I think this tool should leverage GraphQL extensions feature (https://github.com/graphql/graphql-js/pull/2097) and keep the OAS metadata as part of the created schema. It will make it simpler to get the source OAS object (instead of trying to guess it from the operation name or field names).
I understand that adding compiled lib to the repo allow developers to be able to install this tool directly from GitHub, but it also causes issues with rebases and merge changed - maybe it could be better to publish alpha version per each commit (we are doing something similar in graphql-code-generator repo) instead?

Thank you for this tool, it's really helpful, and it's approach really simplifies the integration between GraphQL and OAS :)

@dotansimha Sorry for the late reply but thank you so much for this PR! I like these changes! I think exposing the preprocessing object and the extensions idea would greatly boost usability. I'm not entirely sure if we should expose everything in the preprocessing object, however. I will have to take another look.
Yeah, we aren't exactly sure how we should present the code on GitHub and in our NPM package. We're open to any advice. I will take a look at your repo! It seems like an interesting idea.
All in all, thank you so much for contributing and your kind compliments! Hope you continue using OtG in the future!

@dotansimha I really dropped the ball on this one. It's been over an entire year. I had a really hectic year last year that prevented me from working on OtG as consistently as I wanted to and I just forgot to follow up. It's not really an excuse but it's the best I can come up with. I'm really sorry about that. Hope you were still able to use OtG and thanks for the contribution!


⚠ ClamAV has degraded performance

In cb0a534, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 118 ms

Resolved: ClamAV performance has improved in cb73718.


Considerations for running gadgets through a configuration file

We want to provide a "docker-like" experience for eBPF in Inspektor Gadget by implementing support for containerized gadgets https://github.com/inspektor-gadget/inspektor-gadget/issues/1929.
One aspect we still need to consider is the possibility of providing a mechanism similar to "docker-compose" for running multiple gadgets.
The purpose of this issue is to discuss this possible support.
ref https://github.com/inspektor-gadget/inspektor-gadget/issues/1669

Replaced by #2492.


Include dotnet_8 image for egg-t-modloader

This will fix the "You must install or upgrade .NET to run this application" issue with newer tModLoader.
I discovered that someone had already reported it (https://github.com/pelican-eggs/eggs/issues/2910), but decided to leave the rest in the dark, but with his "update the yolk" clue, I was able to figure it out myself.
Description
Checklist for all submissions

[x] Have you followed the guidelines in our Contributing document?

[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

[x] Have you tested and reviewed your changes with confidence that everything works?

[x] The egg was edited here in GitHub

Please move your PR to the right repo, this one is not used anymore, look here to find the right one for you:
https://github.com/orgs/pelican-eggs/repositories and you can not change the json manual, make the changes in a panel and then export them and fully replace the file here

Please move your PR to the right repo, this one is not used anymore, look here to find the right one for you: https://github.com/orgs/pelican-eggs/repositories and you can not change the json manual, make the changes in a panel and then export them and fully replace the file here

Ok alright!


Test coverage

Key areas to cover with tests:

Data access:  Authorized users can access data on the site; unauthorized users can't.
Data quality:  Data can be imported without quality loss.

We should talk about how to test School data- I've got some thoughts about what I've done that doesn't work, would like to hear what you think.

@hunterowens That sounds like a great conversation. I'm in Chicago this Thursday through Sunday for Do Good Data, and then again May 11—15.

Still here, let's do it.
On Fri, Apr 24, 2015 at 6:34 PM, Alex Soble<EMAIL_ADDRESS>wrote:

@hunterowens https://github.com/hunterowens That sounds like a great
conversation. I'm in Chicago this Thursday through Sunday for Do Good Data,
and then again May 11—15. We should get together in person if you're still
in Chi.
—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/somerville-teacher-tool/issues/18#issuecomment-96101364
.

ToDo:

[ ] Feature tests for roster column sorting
[ ] Feature tests for profile charts

More of an ongoing process than a separate issue, should be part of every PR.


Remove explicit check for AWS environment variables

I have some trouble using guild pull s3 while being ssh-ed on en EC2 machine.
Guild keeps asking for AWS_ACCESS_KEY_ID, but it is not needed, since aws-cli grants access automatically through aws permissions.
Indeed, aws s3 ls works just fine, without any AWS_ environment variables set.
And this simple boto code also works:
import boto3
s3 = boto3.client('s3')
s3.list_buckets()

I suspect there is an unnecessary manual check in guild for the env vars being set, that should be removed.
One should instead check the output of the aws command, and only if it fails, check the environment variables do display a nice error message.

Agree with this, would love to just have Guild utilize the credentials stored when the AWS CLI is setup.

This is fixed in master and will be available in 0.7.0.rc10.

The fix is now generally available in 0.7.0. If this is still an issue, please re-open and we'll sort it out. Thanks again for the report.


Update download in ut

Signed-off-by: shiyu22<EMAIL_ADDRESS>

Codecov Report

Merging #555 (6794fe2) into main (6a7df04) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   72.70%   72.41%   -0.29%
==========================================
  Files         139      139
  Lines        5198     5198
  Branches      778      778
==========================================
- Hits         3779     3764      -15
- Misses       1180     1191      +11
- Partials      239      243       +4

Impacted Files
Coverage Δ

towhee/hub/repo_manager.py
81.08% <0.00%> (-9.91%)
:arrow_down:

towhee/data/random_erase.py
86.36% <0.00%> (-4.55%)
:arrow_down:

towhee/utils/hub_utils.py
70.51% <0.00%> (-3.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7df04...6794fe2. Read the comment docs.

/lgtm
/approve


私有api被拒 CMTimebaseCreateWithMasterClock

ITMS-90338: Non-public API usage - The app references non-public symbols in Frameworks/KSYMediaPlayer.framework/KSYMediaPlayer: _CMTimebaseCreateWithMasterClock. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed. For further information, visit the Technical Support Information at http://developer.apple.com/support/technical/
Best regards,

我也是相同的问题，直接提不上去。。。有解决办法没咯


Build Choose wallet setup UI

Issue #754

[x] Create wallet setup UI
[x] Add routes to options

Proof

@otech47 @sofiaromorales Federated is only for admins right? Also, Should I build the pages for each option in this same PR?

We can disable the federated option for nor


Anyway to Disable the Output in Logs?

Would be nice if it was possible to set an option in the config such as disableLogs: “true” so that the log output would not be shown every 2 seconds

@Hanh94 Using this.log.debug() for items that don't always need to be visible is the best way I've found to give control to the users. Unless they launch homebridge with debug enabled those messages will just get discarded.

@Hanh94 Using this.log.debug() for items that don't always need to be visible is the best way I've found to give control to the users. Unless they launch homebridge with debug enabled those messages will just get discarded.

Hi @gileswells ,Thank you for your feedback.
We will make adjustments in the next release.

Hi @kylewhirl @gileswells , We already support dynamic logging in v1.1.4, please update the plugin


fixed a bug in model_dump_custom

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.71%. Comparing base (a25f38b) to head (bb85b31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   95.70%   95.71%
=======================================
  Files          26       26
  Lines        2095     2099    +4
=======================================
+ Hits         2005     2009    +4
  Misses         90       90

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Draft comms for 4.3.1 release

What
Tell users about release of GOV.UK Frontend v4.3.1
Why
So users know what fixes have been released.
Who needs to work on this
Content design / tech writer
Done when
Where applicable, comms drafted for:

[ ] Mailchimp
[ ] Slack (#govuk-design-system and #design on x-gov Slack; #govuk-design-system and #frontend on GDS Slack)
[ ] What's New panel of Design System homepage
[ ] Roadmap on  Design System website
[ ] Comms has been reviewed by the team and is ready to go when we release

I've started a bit of a draft here: https://docs.google.com/document/d/1FZRplMwDmDxAM5Y4bJVi4PbxbyaoZxserb27zFiHQSk/edit#heading=h.oe987g5cr2yt


formatting using clang-format-9

Summary of proposed changes:

Changed clang formatter to /opt/rocm/hcc/bin/clang-format, which is clang-format-9
Needs to pass CI

Moving the include headers broke some dependencies.

That it definitely did, but my latest commit should fix those issues. It passed the compilation stage, so when it finishes that stage, it should be safe to merge.


about IDF1  IDP  IDR .

Hello, I ran the model you proposed, but the  IDF1  IDP  IDR results, which performance is very bad, are different from yours. What could be the cause? looking forward to your reply.
Thank you very much! Sincerely,
Evaluating ...
... MOT16-02
Preprocessing (cleaning) MOT16-02...
......
Removing 626 boxes from solution...
*** 2D (Bounding Box overlap) ***
IDF1  IDP  IDR| Rcll  Prcn   FAR|   GT  MT   PT   ML|    FP    FN   IDs    FM|  MOTA  MOTP MOTAL
23.0 66.9 13.9| 30.7  90.3  0.98|   54   7   21   26|   587 12356    77   179|  27.0  75.2  27.4
... MOT16-05

Preprocessing (cleaning) MOT16-05...
........
Removing 1 boxes from solution...
*** 2D (Bounding Box overlap) ***
IDF1  IDP  IDR| Rcll  Prcn   FAR|   GT  MT   PT   ML|    FP    FN   IDs    FM|  MOTA  MOTP MOTAL
34.7 56.7 25.0| 45.0  90.9  0.37|  125  16   68   41|   307  3747    75   140|  39.4  75.6  40.5
... MOT16-09

Preprocessing (cleaning) MOT16-09...
.....
Removing 758 boxes from solution...
*** 2D (Bounding Box overlap) ***
IDF1  IDP  IDR| Rcll  Prcn   FAR|   GT  MT   PT   ML|    FP    FN   IDs    FM|  MOTA  MOTP MOTAL
38.4 66.1 27.1| 63.5  92.3  0.53|   25   9   13    3|   280  1921    57    77|  57.0  75.2  58.1
... MOT16-11

Preprocessing (cleaning) MOT16-11...
.........
Removing 2 boxes from solution...
*** 2D (Bounding Box overlap) ***
IDF1  IDP  IDR| Rcll  Prcn   FAR|   GT  MT   PT   ML|    FP    FN   IDs    FM|  MOTA  MOTP MOTAL
51.1 71.0 39.9| 58.1  94.0  0.38|   69  11   29   29|   340  3844    42    78|  53.9  79.2  54.4
... MOT16-13

Preprocessing (cleaning) MOT16-13...
.......
Removing 0 boxes from solution...
*** 2D (Bounding Box overlap) ***
IDF1  IDP  IDR| Rcll  Prcn   FAR|   GT  MT   PT   ML|    FP    FN   IDs    FM|  MOTA  MOTP MOTAL
22.9 62.0 14.1| 30.8  80.7  1.13|  107  11   40   56|   844  7922    60   198|  22.9  72.2  23.4
********************* Your Benchmark Results (2D) ***********************
IDF1  IDP  IDR| Rcll  Prcn   FAR|   GT  MT   PT   ML|    FP    FN   IDs    FM|  MOTA  MOTP MOTAL
20.2 43.0 13.2| 41.0  89.8  0.65|  380  54  171  155|  2358 29790   311   672|  35.8  75.8  36.4

I am not sure what's your problem. Please check the new evaluation code in python.

May I ask where the new evaluation code in python i can get ? I can only find a matlab version of motchallenge-devkit on mot website.

https://github.com/longcw/MOTDT#evaluate

Thanks a lot!


Fix #3321: commit tag shortener

Short commit references now working with a 7 to 40 SHA length'  (Issue #3321) and base.ShortSha() function has been modified to uniformize short SHA's representation (length: 7).

Thanks!


streamlit error when click "start" button.

see the error info:
84|omni_we |   File "/home/ops/anaconda3/envs/omni/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/exec_code.py", line 85, in exec_func_with_error_handling
84|omni_we |     result = func()
84|omni_we |   File "/home/ops/anaconda3/envs/omni/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 576, in code_to_exec
84|omni_we |     exec(code, module.dict)
84|omni_we |   File "/data/app/ai/mini-omni/webui/omni_streamlit.py", line 257, in
84|omni_we |     main()
84|omni_we |   File "/data/app/ai/mini-omni/webui/omni_streamlit.py", line 242, in main
84|omni_we |     recording(status)
84|omni_we |   File "/data/app/ai/mini-omni/webui/omni_streamlit.py", line 158, in recording
84|omni_we |     stream = audio.open(
84|omni_we |   File "/home/ops/anaconda3/envs/omni/lib/python3.10/site-packages/pyaudio/init.py", line 639, in open
84|omni_we |     stream = PyAudio.Stream(self, *args, **kwargs)
84|omni_we |   File "/home/ops/anaconda3/envs/omni/lib/python3.10/site-packages/pyaudio/init.py", line 441, in init
84|omni_we |     self._stream = pa.open(**arguments)
84|omni_we | OSError: [Errno -9996] Invalid input device (no default output device)

Did you start streamlit remotely or in your local computer? You need to start the streamlit locally with Pyaduio installed. Please refer: https://github.com/gpt-omni/mini-omni?tab=readme-ov-file#faq

I get a similar error usually (local streamlit) but typically it works the second time I hit start.

I get a similar error usually (local streamlit) but typically it works the second time I hit start.

yes, it shows a overflow error (I don't know the reason, sad) and the second time it works fine.
I will close it for now, please feel free to re-open.