RC-0: navigation failed to blank page

Short description of the problem:
navCtrl.push(...) after a login attempt works only with Chrome developer tools (android device).
Otherwise, it goes to the redirect page, and quickly shows a blank page instead.
It's the same behavior with setRoot
UPDATE
In a more simple scenery, with no redirect before login, still leads to blank page.
https://github.com/ecureuill/Ionic2RC-Auth0.git3
So  I guess it is not a bug specific to method push() or setRoot.
Could be a problem between ionic navigation and angular navigation?
UPDATE
What behavior are you expecting?
Steps to reproduce:

ionic serve

open Chrome developers tool (android device)

navigate (works)

ionic serve

navigate (don't work)

import { Component } from '@angular/core';
import { NavController } from 'ionic-angular';

import { AuthService } from '../../providers/auth0'

import { HomePage } from '../home/home';

@Component({
	selector: 'page-login',
	templateUrl: 'login.html'
})
export class LoginPage {

	constructor(public navCtrl: NavController, private auth: AuthService) {
		this.redirectTo();
	}

	public get autenticado(): boolean {
		return this.auth.authenticated();
	}

	login() {
		this.auth.lock.show();
	}

	redirectTo() {
		if (this.auth.authenticated()) {
			this.navCtrl.push(HomePage);
		} else {
			this.auth.lock.on('authenticated', authResult => {
				this.navCtrl.push(HomePage);
			});
		}
	}
}

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
https://forum.ionicframework.com/t/page-coming-as-blank-after-login-in-ionic-2-rc0/65077
Which Ionic Version? 1.x or 2.x
2.0RC-0
Run ionic info from terminal/cmd prompt: (paste output below)
Your system information:
Cordova CLI: 6.3.1
Gulp version:  CLI version 3.9.1
Gulp local:
Ionic Framework Version: 2.0.0-rc.0
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
OS: Distributor ID:	Debian Description:	Debian GNU/Linux 8.6 (jessie)
Node Version: v4.5.0

Try calling redirectTo() after the LoginPage has entered, with ionViewDidEnter.

Same behaviour.
Bellow, more code details
app.module.ts
import { NgModule } from '@angular/core';
import { Storage } from '@ionic/storage';
import { IonicApp, IonicModule } from 'ionic-angular';
import { MyApp } from './app.component';

/* --------------- PAGES ------------------ */
import { HomePage } from '../pages/home/home';
import { LoginPage } from '../pages/login/login';
/* --------------- PROVIDERS ------------------ */
import { AuthService } from '../providers/auth0';
///JWT Config
import { AuthHttp, AuthConfig} from 'angular2-jwt';
import { Http } from '@angular/http';

 export function getAuthHttp(http) {
     return new AuthHttp(new AuthConfig({
       noJwtError: true
     }), http);
 }

@NgModule({
  declarations: [
    MyApp,
    LoginPage,
    HomePage
   ],
  imports: [
    IonicModule.forRoot(MyApp)
  ],
  bootstrap: [IonicApp],
  entryComponents: [
    MyApp,
    HomePage,
    LoginPage,
      ],
  providers: [
    Storage,
    AuthHttp,
    AuthService,
    {
      provide: AuthHttp,
      useFactory: getAuthHttp,
      deps:[Http]
    }
  ]
})
export class AppModule { }

login.ts
import { Component } from '@angular/core';
import { NavController } from 'ionic-angular';
import { AuthService } from '../../providers/auth0'
import { HomePage } from '../home/home';

@Component({
	selector: 'page-login',
	templateUrl: 'login.html'
})
export class LoginPage {

	constructor(public navCtrl: NavController, public auth: AuthService) {
	}

	public get autenticado(): boolean {
		return this.auth.authenticated();
	}

	login() {
		this.auth.lock.show();
	}

	ionViewDidEnter() {
		this.redirectTo();

	}

	redirectTo() {
		if (this.auth.authenticated()) {
			this.navCtrl.setRoot(HomePage);
                        this.navCtrl.push(HomePage)
		} else {
			this.auth.lock.on('authenticated', authResult => {
				this.navCtrl.setRoot(HomePage);
			});
		}
	}
}

login.html
<ion-header>
    <ion-navbar>
        <ion-title>login</ion-title>
    </ion-navbar>
</ion-header>
<ion-content padding *ngIf="auth.authenticated()">
    <button ion-button (click)="redirectTo()" >Home</button>
    {{auth.authenticated()}}
</ion-content>
<ion-content padding *ngIf="!auth.authenticated()">
    <button ion-button (click)="login()">Login</button>
    {{auth.authenticated()}}
</ion-content>

auth0.ts
import {Storage} from '@ionic/storage';
import {AuthHttp, JwtHelper, tokenNotExpired} from 'angular2-jwt';
import {Injectable, NgZone} from '@angular/core';
import {Observable} from 'rxjs/Rx';

// Avoid name not found warnings
declare var Auth0: any;
declare var Auth0Lock: any;
// declare var faker = require('faker');

export class Auth0Vars {
  //application's clientId in Auth0.
    static AUTH0_CLIENT_ID = "...";
    static AUTH0_DOMAIN = "...";
}

@Injectable()
export class AuthService {

  jwtHelper: JwtHelper = new JwtHelper();

  auth0 = new Auth0({ clientID: Auth0Vars.AUTH0_CLIENT_ID, domain: Auth0Vars.AUTH0_DOMAIN });

  lock = new Auth0Lock(Auth0Vars.AUTH0_CLIENT_ID, Auth0Vars.AUTH0_DOMAIN
    , {
    redirect: false, //popup options
    autoclose: true,
    avatar: null,
    closable: false,
    rememberLastLogin: false,
    language: 'pt-br',
    theme: {
      primaryColor: 'green',
      logo: 'assets/img/logo.jpg',
      labeledSubmitButton: true //This option indicates whether or not the submit button
      // should have a label, and defaults to true. When set to false, an icon will be shown instead.
    },
    languageDictionary: {
      title: "Teeth"
    },
    }
  );

  local: Storage;
  refreshSubscription: any;
  user: Object;
  zoneImpl: NgZone;

  constructor(private authHttp: AuthHttp, zone: NgZone, local : Storage) {
    this.zoneImpl = zone;
    this.local = local;

    this.lock.show();

    // Check if there is a profile saved in local storage
    this.local.get('profile').then(profile => {
      this.user = JSON.parse(profile);
    }).catch(error => {
      console.log(error);
    });

    this.lock.on('authenticated', authResult => {
      this.local.set('id_token', authResult.idToken);

      // Fetch profile information
      this.lock.getProfile(authResult.idToken, (error, profile) => {
        if (error) {
          // TODO: tratar erro
          console.error("erro ao retornar perfil", error);
          return;
        }

        profile.user_metadata = profile.user_metadata || {};
        this.local.set('profile', JSON.stringify(profile));
        this.user = profile;
      });

      this.lock.hide();

      this.local.set('refresh_token', authResult.refreshToken);
      this.zoneImpl.run(() => this.user = authResult.profile);
      // Schedule a token refresh
      this.scheduleRefresh();

    });

  }

  public authenticated() {
    // Check if there's an unexpired JWT
    return tokenNotExpired();
  }

  public login() {
    // Show the Auth0 Lock widget
    this.lock.show();
  }

  public logout() {
    this.local.remove('profile');
    this.local.remove('id_token');
    this.local.remove('refresh_token');
    this.zoneImpl.run(() => this.user = null);
    // Unschedule the token refresh
    this.unscheduleRefresh();
  }

  public scheduleRefresh() {
    // If the user is authenticated, use the token stream
    // provided by angular2-jwt and flatMap the token
    let source = this.authHttp.tokenStream.flatMap(
      token => {
        // The delay to generate in this case is the difference
        // between the expiry time and the issued at time
        let jwtIat = this.jwtHelper.decodeToken(token).iat;
        let jwtExp = this.jwtHelper.decodeToken(token).exp;
        let iat = new Date(0);
        let exp = new Date(0);

        let delay = (exp.setUTCSeconds(jwtExp) - iat.setUTCSeconds(jwtIat));

        return Observable.interval(delay);
      });

    this.refreshSubscription = source.subscribe(() => {
      this.getNewJwt();
    });
  }

  public startupTokenRefresh() {
    // If the user is authenticated, use the token stream
    // provided by angular2-jwt and flatMap the token
    if (this.authenticated()) {
      let source = this.authHttp.tokenStream.flatMap(
        token => {
          // Get the expiry time to generate
          // a delay in milliseconds
          let now: number = new Date().valueOf();
          let jwtExp: number = this.jwtHelper.decodeToken(token).exp;
          let exp: Date = new Date(0);
          exp.setUTCSeconds(jwtExp);
          let delay: number = exp.valueOf() - now;

          // Use the delay in a timer to
          // run the refresh at the proper time
          return Observable.timer(delay);
        });

      // Once the delay time from above is
      // reached, get a new JWT and schedule
      // additional refreshes
      source.subscribe(() => {
        this.getNewJwt();
        this.scheduleRefresh();
      });
    }
  }

  public unscheduleRefresh() {
    // Unsubscribe fromt the refresh
    if (this.refreshSubscription) {
      this.refreshSubscription.unsubscribe();
    }
  }

  public getNewJwt() {
    // Get a new JWT from Auth0 using the refresh token saved
    // in local storage
    this.local.get('refresh_token').then(token => {
      this.auth0.refreshToken(token, (err, delegationRequest) => {
        if (err) {
          alert(err);
        }
        this.local.set('id_token', delegationRequest.id_token);
      });
    }).catch(error => {
      console.log(error);
    });

  }
}

having the same issue!

another update:
if chrome dev tools device is set to an IOS device there is no problem. If it is set to an Android device the problem is also there in dev tools

I have the same problem. After a successful login I set the rootPage using:
this.navCtrl.setRoot(HomePage);

and this was giving me a white page of doom but was able to fix the issue by replacing:
<ion-nav id="nav" #content [root]="rootPage"></ion-nav>

with
<ion-nav id="nav" #content></ion-nav>

on my home page.

@leommoore i tried your solution,
unfortunately it doesnt work for me. Ik does however now show the navbar but thats it..

Please, have a look in this
https://github.com/ecureuill/Ionic2RC-Auth0.git3
After login, with no redirect, still lead to blank page.
So, problem is not specific to .push

To try to figure out whats is the problem, Auth0 team ask me about the navigation. Can someone help to answer this?

Hello all! Since this seems to be an Auth0 related issue and not a framework issue I am going to close this issue for now. Thanks!

@jgw96 not really, my login page just posts to my own json api without using Auth0, I don't use any plugin for this, my login process sends and receives everything through http post and get.
after a succesfull login i go to the login page using: this.navCtrl.setRoot(ProfilePage);
This worked in beta11 and 10.
Also other pages where i set the root the same way work fine, those are all fired by a click though, that is the only difference.
The problem is only on android devices, google chrome, and in the chrome developer tools if you set the device to an android device, ios devices in developer tools work fine.
there is a workaround though. Wrapping the setRoot in a timeout fixes the problem.
let _self = this  setTimeout(function(){         _self.navCtrl.setRoot(ProfilePage);         console.log('timeout finished')         }, 3000);
So this is not an Auth0 problem but a framework related problem.

If it'st necessary a timeout to works, maybe it's related to 8449
I try call my redirect method in ngAfterViewInit instead ionViewDidEnter and it's seems to work. Moreover, fix my problem of keep logged after login
@fishgrind  can you try this?

I'm kinda having same issue. I'm checking user auth(from firebase) with ngOnInit() and define rootPage on app.component.ts. When I run the app on my device, its just blank page without any console errors. Then if I switch different app and return my app. It works like before.

@ecureuill
unfortunately that isnt the issue as i am calling setRoot from a function after receiving data from the json api. But thanks for your input!

If I use image on page, it works :)

After moving to RC0 I did not have this problem. But after I got info that one page is blank after opening, next I run it in with ionic serve and wow... even at startup it is blank. But I noticed a small flicker when I see login page, and after that nothing there. DOM elements seems to be just fine.
Used remove [root]="rootPage" from above and did work somehow, not sure if it solution or temporal effect. I do not use any side frameworks...

it's really funny. DOM elements/page are there, i can inspect those. But they're not visible. All CSS opacity and everything seems OK, but just elements are not visible...

Yes, I've noticed that.
After redirect to HomePage, it come back to LoginPage, and I guess that it is "blank" because content should be resized.

Havent figured out how to reproduce it but... in my case..

Link to the same task which has assignee: https://github.com/driftyco/ionic/issues/8510

Update:
I guess the problem is with some transition, because I have this problem only with nav.push, nav.pop but not with nav.setRoot works perfectly pages. Also it is strange that some pages have this issue all the time while others do not have (depends on items on the page?)
As a workaround I have impolemented setRoot pages and overwrittent backbutton actions:
      platform.ready().then(() => {
            platform.registerBackButtonAction(() => {

with inside code of such type:
if (this.nav.canGoBack() || this.nav.getActive() && this.nav.getActive().isOverlay
                ) {
                    Logger.log("Popping back");
                    this.nav.pop();
                }
                else if (this.nav.getActive() && this.nav.getActive().instance && this.nav.getActive().instance.isRootPage
                ) {

The instance is the Page class that you have at the moment and you can put there any property you want, so isRootPage is true/false for my home page. Thus you can intercept navigation and place pages from one place whatever you want, based on class properties.

I can also confirm this issue:
Im using ng2-ui-auth and not auth0 as authentication service.
Im using ionic Events to know when the user is authenticated:
    this.events.subscribe(AUTH_EVENTS.fail, (err) => {
      console.log(`Caught event: ${AUTH_EVENTS.fail}, with: ${err}`);
        this.nav.setRoot(ProviderSelectorPage)
    });

This cause a blank screen. setting timeout around the setRoot method solve the problem

I have the same issue here
when running on android, on some pages, the page loads as white screen.
before RC everything worked great.
using chrome inspect i found the ion-page has no expected attribute show-page (which sets the
opacity to 1) ,thus the page has opacity of 0!
this happens on 2 specific pages after nav.push
(those pages are more complex and has more data - though i don't see how its related)
I'm trying some css workaround....

Hello all! I am going to close this issue as a duplicate of https://github.com/driftyco/ionic/issues/8510. Thanks!

@ts1812 good finding. If you find workaround, please, inform here or at #8510

Thank you, I see you already fixed this.
Well I'm not that a github/ionic guru so How can I simply update my version ?:)
thank you


Please public build 0.13.0 to npm

Your API DOC is v0.13.0, but npm i and npm search get 0.12.0.
It takes me a lot time to debug my code, and read local source code, and check your github document and your github source code...

If you want to access the v0.12.0, check here the related tag here: https://github.com/GoogleChrome/puppeteer/tree/v0.12.0

But API doc now is 13……

Agreed that it's confusing we rev the docs in master and point to those instead of the current stable release. We've tried to address that with clear labelling at the top of the API docs saying what version you're on, but people tend to miss that. When you install the stable release from npm, our everything points you to the -alpha docs.
A proper doc story will help: https://github.com/GoogleChrome/puppeteer/issues/1068


SwiftPM support will be outdated on Swift 5

This project now has a Package.swift file whose swift-tools-version is 3.0, but Swift 5 drops support for Swift 3 language mode, so this package cannot be used from SwiftPM on Swift 5.
Could you update the manifest or add additional one of<EMAIL_ADDRESS>(or<EMAIL_ADDRESS>and cut a new release?
Ref: https://github.com/Carthage/Carthage/issues/2694

This should be fixed now with 4.0.2. Please please let me know if you run into any issues on this. I don't use SPM often enough to really smoke test this.


fix(codepipeline-actions): set service as backing resource for EcsDeployAction

Adds cross-account deployment support to EcsDeployAction CodePipeline action by setting the ActionProperties.resource property introduced in #3012 to the target ECS service.
Pull Request Checklist

[x] Testing

Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
CLI change?: coordinate update of integration tests with team
cdk-init template change?: coordinated update of integration tests with team

[ ] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated
Design: For significant features, design document added to design folder

[ ] Title and Description

Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[ ] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Thanks for the subtle PR @strax !
Note that I haven't explicitly tested whether cross-account support works for ECS services - it might be that we will need to create some Roles inside the service, for example, with a lazy-assigned physical name. Let us know what you find out!
Thanks,
Adam


Don't error with "used before assigned" when declared type includes void

fixes https://github.com/microsoft/TypeScript/issues/52003

FWIW:
While the “used before assigned” error definitely seems like a bug, I note that it’s never sound to narrow void out of a union, as the whole point of void is that it specifies a “return arity” of zero, and any function type with higher return arity (i.e. any other return type) is assignable to it.  So if you do something like cond ? voidRet() : stringRet() and get a string | void, you can’t be sure, even if you get a string back, that it’s not bogus, since voidRet may in fact have returned a string, but its void return type is an implicit promise that the caller won’t access anything it happens to return (since in reality “zero return arity” isn’t a thing).

@fatcerberus ye, I realize that - but TS is very conservative about breaking changes, and apparently this is the current behavior:
declare const a: string | void

if (typeof a === 'undefined') {
  a // undefined
}

if (typeof a !== 'undefined') {
  a // string
}

That's why I've implemented this as a fix. Personally, I would prepare a different fix - one that wouldn't remove void from the union etc but to do that I would have to get a signal from the TS team member that this is what they want.

From reading #52003, I think the Not A Defect tag means that we don't want to fix that bug. So I think this PR should be closed?
@RyanCavanaugh feel free to speak up if I interpreted Not A Defect incorrectly.

FWIW Not a Defect tag was added after the PR was opened.

Yeah, this is the kind of fix we need to reject if we don't want to bleed performance forever. People should not be declaring variables of type void in the first place.


Feature Jcarousel with wrap: circular shows empty element after the last element in the list

I've created a feature jcarousel with 3 li items in ul with wrap set to circular and set the visibility to display only one element. I have also defined overflow visible on the clip to display the previous and next element in the list. The problem occurs when the last item is in the clip.
What's supposed to happen is that the first element in the list should be displayed next in jcarousel-overlay-right. Instead there is a blank item.
Actual result:

|1|2|3|   ->     |2|3|____|
Expected Result:

|1|2|3|   ->     |2|3|1|
This issue is also observed when scrolling back to top of the list. The last element is supposed to be displayed in jcarousel-overlay-left whereas a blank item is displayed.
Please do let me know if there is a workaround for this issue.

This was never fixed then...?


cudaDriverEntryPointQueryResult not defined

During installation (from main branch with pip install .), it reports error: ‘cudaDriverEntryPointQueryResult’ was not declared in this scope
on line 98 of transformer_engine/common/util/cuda_driver.cpp
98 |   cudaDriverEntryPointQueryResult driver_result;
I try to search for dependency and It seems that this is not defined anywhere in this project.  Where is it defined and how to solve the problem? Thanks.
I'm using python 3.12.4,  cuda-11.8 and pytorch=2.4.0

Can you try upgrading to CUDA 12.0 or newer? See https://github.com/NVIDIA/TransformerEngine/issues/1086#issuecomment-2274405040.

@timmoon10 Could you update our installation instructions? We are still listing 11.8 as the prerequisite here: https://docs.nvidia.com/deeplearning/transformer-engine/user-guide/installation.html

Yeah the problem was solved when I use CUDA-12.2


bevy_asset WARN when loading .png

I created a 100x100 square in Paint, saved it as a .png and tried to load it into bevy, but I got the following Warning
[WARN bevy_asset :: asset_server: encountered an error while loading an asset: Error reading image file redsquare.png: failed to load an image, this is an error in 'bevy_render'.
Code
fn add_people(mut commands: Commands, asset_server: Res<AssetServer>, mut materials: ResMut<Assets<ColorMaterial>>) {
    let texture_handle = asset_server.load("redsquare.png");
    commands.spawn()
        .insert_bundle(SpriteBundle {
            sprite: Sprite {
                size: Vec2::new(100.0, 10.0),
                ..Default::default()
            },
            material: materials.add(texture_handle.into(),
            ),
            transform: Transform::from_xyz(10., 20., 0.),
            ..Default::default()
        });

Then, when I tried to load another .png from the github repository, it worked perfectly.
bevy = "0.5"
Windows 10
My redsquare.png

I think I understand the problem. I hadn't created the file directly in Paint. I created the file using VsCode with a .png extension, edited and saved it with Paint. I did the same thing again and received the same Warning.

Cool, so it's a malformed file issue as I suspected. I wonder if we can repair this, or at least report a better error. Given that it renders, it sounds repairable.

Message has been improved in current main:
WARN bevy_asset::asset_server: encountered an error while loading an asset: Error reading image file red.png: failed to load an image: Format error decoding Png: invalid signature, this is an error in `bevy_render`.

The png is not valid. In our case, it's done by https://github.com/image-rs/image that often rejects invalid files instead of trying it's best to render them.
Most browsers or image viewers often try their best to display even invalid image...
related to #2201
In your case, your image is actually not a png but a bmp (try changing the extension and running with --features bmp)


Cannot find path '\source\module' because it does not exist.

Hello,
The build-PwshRuntimeLayer.ps1 script seems to be broken. Get-Content at line 28 takes the $_ from pipleline and its throwing error. If we replace $_ with $_.FullName. It works.
Get-ChildItem -Path $sourcePath/modules/Private -Filter *.ps1 | ForEach-Object {Get-Content $_ | Select-Object -Skip 2 | Out-File -FilePath $sourcePath/modules/pwsh-runtime.psm1 -Append}
Thanks
Abdul

Another issue that I observed is that the Out-File messes up the encoding of the pwsh-runtime.psm1. I am not sure if anyone has observed this but I tested this on two machines and it ended up making the file unreadable. Adding -Encoding UTF8 with Out-File solved the problem.

For the build-PwshRuntimeLayer.ps1 issue, are you running this from the same folder?
I've tested this on PowerShell for Windows as well as Linux and am not able to reproduce.
If you do  Get-ChildItem -Path $sourcePath/modules/Private -Filter *.ps1 | %{Write-Host $_}, do you not get a list of filenames?

It seems its having issues while running this in Windows PowerShell. Running it in PowerShell Core executes without a problem.
Windows PowerShell:

PowerShell Core:

$_.FullName executes without issues on both PowerShell environements.

I have this issue as well when I build locally. Windows PowerShell seems to resolve $_ to $_.Name instead of $_.FullName.
I've pushed an update to the build script to change it to $_.FullName

Validated. Worrking as expected in Windows PowerShell and PowerShell core.


Unable to get telemetry information from Estimote Stickers

Hi!
I'm trying to get telemetry information from the stickers but I haven't managed to do it. After following the tutorials and reading about some issues I had before the stage at which I am right now, I have reached to this code:
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        EstimoteSDK.initialize(getApplicationContext(), "real id taken from the cloud", "real token taken from the cloud");
        final BeaconManager beaconManager = new BeaconManager(this);
        beaconManager.setTelemetryListener(new BeaconManager.TelemetryListener() {
            @Override
            public void onTelemetriesFound(List<EstimoteTelemetry> telemetries) {
                for (EstimoteTelemetry tlm : telemetries) {
                    Log.d("TELEMETRY", "beaconID: " + tlm.deviceId +
                            ", temperature: " + tlm.temperature + " °C");
                }
            }
        });
        beaconManager.connect(new BeaconManager.ServiceReadyCallback() {
            @Override
            public void onServiceReady() {
                beaconManager.startTelemetryDiscovery();
            }
        });
    }

    @Override
    protected void onResume() {
        super.onResume();
        SystemRequirementsChecker.checkWithDefaultDialogs(this);
    }

Once I execute this code, I'm not able to see more than:

09-16 11:03:21.650 4990-5003/com.example.jevora.estimote D/ScanRecord: parseFromBytes
09-16 11:03:21.650 4990-5003/com.example.jevora.estimote D/ScanRecord: first manudata for manu ID

I cannot see in the logcat any telemetry message nor an exception. I have checked using Estimote app that the sticker I'm using had it enabled and with the frequencies correctly set.
Do you know what may be the problem?
Thanks

Hello @jevora
At first we need to be 100% sure that your sticker is advertising telemetry packets. As far as I know, our Android App doesn't allow to turn telemetry on stickers yet. I conclude, that you checked that on our cloud, or iOS app. If so, please make sure that you can connect to your sticker.
Secondly, I don't recall any "first manudata" log in our SDK - is it flooding your logcat? If so, I think this comes from a lower level. I remember having this log once on a Samsung device - could you tell me if you are using it?
Also, make sure that your sticker has "motion only advertising" disabled. Or try shaking it constantly while scanning with your app.
I'm waiting for your response and we will proceed further :)

Hello @pawelDylag
Thanks for the fast answer. Yes, Samsung S5 :)
I saw in the Android APP that Advertising intervals (still and motion) were set to 2588 and 1294 respectively. Primary packet type is nearable and Estimote Default as secondary. This is what I can see in the web:

Is there any problem with the config?.
Thanks!

Ok, I know what the problem is :)
Stickers don't advertise general telemetry packet. All telemetry information is contained in it's Nearable packet. So in order to get telemetry data from your sticker, you need to setup NearableListener and start NearableDiscovery - all your data will be inside Nearable object.
Let me know if this solution was helpful :)

Hi @pawelDylag
Yes, I have managed to read the measures taken from the stickers. Thanks!
I've checked the documentation and I've seen the fields x-y-zAcceleration. These fields are variating through the measures when sticker is being moved. I would like to know what is the precision they have.
I've put it on a table and hit the table and measures are rarely changed. It seems not to be very sensitive like sensors on phones and tables, am I right? I have removed the plastic of the sticker to see if it was absorbing some energy but results are similar. Is this right or I should calibrate them somehow?
Best

Hello once again @jevora
As far as I know, sticker is sending it's packet every 2,5 s. So if you hit the table, there is a low possibility that the sensor will get your measurement and send it in a packet. So no, for measuring single hits, sticker is not very precise. Bear in mind the delay caused by packet transmission frequency and a time for it to reach your phone antenna.
If you have a questions about use-cases for your sticker, feel free to contact our support here: https://forums.estimote.com/
For any questions about our SDK or Android  - I am here to help you :)

@pawelDylag
hey you have such tutorial for android as such as ios for android stickers
I am not able to find and I stuck into it please help. I want to measure motion, temperature, enter/exit region. I want UI for android nearable.
Waiting for your answer.
Thanks in advance, and hope you we you will pick me out from this issue


What type of JS module pattern is used in exercism?

This sounds like a ridiculous question, but I've never been all that fond of modules, and mostly avoided them. But in the first few exercises on Exercism, I found the modules to be very nice - and it would certainly help my coding to use this style more. What specific pattern is this, or does anybody have a URL where I can do more practice writing these kind of modules, or reading reference materials about them? Thanks!

@mspanish I'm glad to hear you're enjoying the track!
Exercism's JavaScript track uses CommonJS modules.  Support for CommonJS is baked in to Node JS.  However, if you want to package together modules into code for the browser, you will need to include a tool such as Webpack or Browserify in your build process.
Here's a blog post about CommonJS and how require works: https://blog.risingstack.com/node-js-at-scale-module-system-commonjs-require/
Please feel free to ask if you have more questions.

Thanks very much 👍


Modify the command dds motd send to allow the option to send only to unit personnel

Read this before submitting the PR

Always create a Draft PR first
Go through sections 1-5 below, fill them in and check all the boxes
Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Modify the client to accept the option to send only to unit persoonel
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

[X] New feature

[ ] Breaking: Why / How? Add info here.
[X] Non-breaking

[ ] Bug fix
[ ] Security Alert fix

[ ] Package update

[ ] Major version update

[ ] Documentation <!-- Should be checked if the PR adds or updates the CLI documentation -- anything in docs/ directory. -->
[ ] Workflow
[ ] Tests only

4. Additional information

[X] Sprintlog
[ ] Blocking PRs

[ ] Merged

[ ] PR to master branch: If checked, read the release instructions

[ ] I have followed steps 1-8.

5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

[x] Black

[x] Pylint

[x] Prettier

[x] Yamllint

[x] Tests

[x] TestPyPI

[x] CodeQL

[x] Trivy

[x] Snyk

This is the same as the other PR. I will review after merge this time, but as I said I want to review tasks that have a direct affect on the users. This time I was finishing up a report before I could review.


PowerToys run crashing after system wakes up from sleep

Microsoft PowerToys version
0.68.1
Installation method
WinGet
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
I'm not exactly sure, but ever since my windows reinstall in January, PTR will sometimes just crash when my system wakes up from sleep. Not very annoying since it happens like 2 times a week and can be easily fixed by restarting powertoys.
here's the bug report:
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.22621.0
IntPtr Length: 8
x64: True
Date: 04/04/2023 08:53:10 pm
Exception:
System.InvalidOperationException: Dispatcher processing has been suspended, but messages are still being processed.
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

✔ Expected Behavior
Just simply opening powertoys run to launch an app
❌ Actual Behavior
It says "something went wrong" and now powertoys needs to be restarted
Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/18166
fix will be in 0.69 which will be released soon


Accesssing session without having a chat interaction

Hey @dotcypress,
first things first: I like what you do here. Really clean design and nice to use! I play around a little with the telegram api and your framework feels very elegant.
Currently I try to do a Pocket integration. Therefore I need to do oauth. The pocket api will execute a callback by accessing a redirect uri. From there, I want to store the access authentication token into the users session. But this uri is out of the context of the current session. As the redis session is stored as soon as all middleware runs through, I cannot use local scoping either. Do you have any ideas how to solve this with the current architecture?
If not I have some ideas for a solution:

setup a separate session store and sync with redis in session (feels bulky)
setup a 2nd client to the same redis session and insert access token via that global client (I know the session key. But also this feels weird...)
(my preference) export the redis session store so it is accessible outside a chat interaction. This needs altering to your code. Would also be useful for the in-memory session.

What do you think? I could provide a PR for 3).
Cheers
Sven

Hey @mischkew
Thank you for your feedback. 👍
Solution 3 is implemented and published as 4.0.0


how to make capacity-scheduler.xml take affect

Short summary about the issue/question:
I changed the capacity-scheduler.xml as follow, but no matter I refresh or start after deleted , it does not take affect:

so, am I missing something to configure?  Thx for any reply.
OpenPAI Environment:

OpenPAI version:  0.14
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): ubuntu 16.04 server
Kernel (e.g. uname -a): Linux  4.4.0-116-generic
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

Firstly, capacity-scheduler.xml is generated from template, so any change on it is meaningless.
Then, PAI doesn't expose and fully test these configurations. If you really want to customize them, please try YARN API, which should be at http://master_ip:8088/ws/v1/cluster/scheduler-conf.

thanks, I sloved it by calling YARN API.


Fix get_params in RandomResizedCrop

Small fix for PR #343.
The function get_params in RandomResizedCrop can't be static anymore.

Fixed in #345.


With Powertoys running, using the Windows Screen Capture Tool hangs it and Edge.

Microsoft PowerToys version
0.71.0
Installation method
GitHub
Running as admin
No
Area(s) with issue?
General
Steps to reproduce

With Powertoys running, open the Windows Screen Capture Tool.
Select a region of the screen to capture.
Try to paste in Gmail, or Discord, or anything in Edge.

✔ Expected Behavior
The copied image is pasted.
❌ Actual Behavior
Edge hangs, the Windows Screen Capture Tool, and Powertoys hangs.
And none wants to die when trying to close them. Only after terminating the capture tool with Task Manager the other apps unhang.
Notes: I tried disabling every tool in Powertoys, with the same results.
After closing Powertoys, the procedure of taking screen shots and pasting them works flawlessly.
This is happening for several version of Powertoys, but I don't know since which one.
Other Software
Microsoft Windows 11 Pro 22H2 v 22621.1992
Microsoft Windows Screen Capture Tool, v 11.2304.21.0.
Microsoft Edge v 114.0.1823.79 (64 bits)

Hi, thanks for the report. Were you using Powertoys utility called Screen Ruler before the bug occurred?
/needinfo

@tiago304 does this still occur when you update to PowerToys 0.77? Also are you able to update Windows beyond 22H2? /needinfo

This issue does not occur with PowerToys 0.77.0.
Windows 11 Pro 23H2 22631.3007
Microsoft Windows Screen Capture Tool 11.2310.54.0
Edge 120.0.2210.144
I don't know which version of PowerToys or anything else fixed this, sorry.
Thank you.


Framework should provide support to call external protocol related validations and configurations

Is your suggestion related to an experience ? Please describe.
When sending an oauth request, the user is prompted to provide mandatory claims that are been configured at the service provider. These mandatory claims are requested regardless of the scope requested by the request.
For example:
If the country is set as a mandatory claim of the SP and a request is sent using the scope=openid, the user will be prompted to provide the country after login. Since the openid scope does not contain country claim, it will not be send in the response and therefore it is not necessary ask the user to enter the country value.
Even though country is set as a mandatory attribute, it should be filtered based on the scope and should not be prompted for the user at login.
With the current implementation, prompting missing mandatory claims are handled by the framework and there is not way to incorporate scope based filtering during this flow since scope is specific to oauth protocol and scope based validations are handled separately by the identity-inboud-auth-oauth repo.
Describe the improvement
There should be a way to add protocol specific configurations and validations to the framework if needed.
Additional context
Suggestions:

scope based filtered claims can be added to the context from the post authentication handler and later be used in the missing claim handler. This method will do this filtering every time the user login, even when the missing claim handler will not be needed for most of the time.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


No Lorem class in Faker.Net 1.0.3 NuGet

Lorem class does not exist in Faker.Net 1.0.3 NuGet, .Net 4.0. Checked with ILSpy

The nuget package references a different project https://github.com/oriches/faker-cs
This needs to get updated.

Created Isse #13 to hopefully get this fixed.


Make a code review

The code review and improvements needed.

Closing as there is no further action on it :)


Code Coverage Support added

Expresso's Code Coverage support added to nodeunit
inorder to use it.
you've define requires as follows
var a = require('a');
instead
var a = require('../lib/a')
Then it'll automatically detect this and added code coverage support.
and display the summery.
If you need more information add -cr option
eg:- nodeunit -cr tests
if you need to ommit Code Coverage you can use -ci option
eg:- nodeunit -ci tests
And this will not affect existing tests written in Nodeunit and above little require modification adds the coverage support

Hi arunoda, thanks for your work on this. However, I'm unable to see any coverage output when I run test suites using your updated code. It runs the tests fine, but there's no coverage report.
I have the code under test in 'lib' and the tests in 'test'. The tests reference the code in lib by doing require('../lib/foo'). I run the tests by doing "nodeunit -cr test" in the project directory. Am I missing something?

I think we need a solution that doesn't require a particular directory structure.  Perhaps 'test' and 'lib' can be defaults, but a way to pass in the paths via the command line seems like a necessary feature.

Yes :) A simple thing
You've to require('foo') instead of require('../lib/foo')
That's how they detect for code coverage. If not they just ignore it.
On Sun, Oct 30, 2011 at 3:45 AM, Caolan McMahon <
<EMAIL_ADDRESS>
Hi arunoda, thanks for your work on this. However, I'm unable to see any
coverage output when I run test suites using your updated code. It runs the
tests fine, but there's no coverage report.
I have the code under test in 'lib' and the tests in 'test'. The tests
reference the code in lib by doing require('../lib/foo'). I run the tests
by doing "nodeunit -cr test" in the project directory. Am I missing
something?
--
Reply to this email directly or view it on GitHub:
https://github.com/caolan/nodeunit/pull/74#issuecomment-2567272

--
Arunoda Susiripala
@arunoda http://twitter.com/arunoda
http://gplus.to/arunodahttps://github.com/arunoda
http://www.linkedin.com/in/arunoda

I agree with you. lib should be default but there should be some option to
add folders to the list.
On Sun, Oct 30, 2011 at 3:51 AM, Bryan Donovan <
<EMAIL_ADDRESS>
I think we need a solution that doesn't require a particular directory
structure.  Perhaps 'test' and 'lib' can be defaults, but a way to pass in
the paths via the command line seems like a necessary feature.
--
Reply to this email directly or view it on GitHub:
https://github.com/caolan/nodeunit/pull/74#issuecomment-2567287

--
Arunoda Susiripala
@arunoda http://twitter.com/arunoda
http://gplus.to/arunodahttps://github.com/arunoda
http://www.linkedin.com/in/arunoda


스탯 아이콘 폰트수정

:tada: This PR is included in version 1.4.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


NETOBSERV-634 UI Consistency: Side panel styling

Side panel updates:

wording / styling
tabs (Details / Raw JSON / Metrics)
sticky header (scroll is under the selected tab)
expandable groups for Source / Destination
added Namespace & Node infos when available on topology

One interesting thing would be to add long descriptions on each field like:

However there is no value if we don't add particular details. I guess we could start from https://www.iana.org/assignments/ipfix/ipfix.xhtml and update according to our usage.
Can someone help me to write these ? Then I would be happy to implement !
@stleerh @jotak

This looks good! The only thing I would change if it's possible is the Side panel Title. Can it be the resource name (P) dns-pod-blah-blah-blah-24 instead of "Pod"?

This looks good! The only thing I would change if it's possible is the Side panel Title. Can it be the resource name (P) dns-pod-blah-blah-blah-24 instead of "Pod"?

Yes I can do that when you click on a single item @andrew-ronaldson but what about edges (source + destination) ?
It's also the same for table row :thinking:

One interesting thing would be to add long descriptions on each field like

It could be nice. Some fields are pretty obvious (pod, kind, namespace...) other are less (direction, collection latency..) , we just set a description on those who aren't obvious? (or an info icon + tooltip?) It's also to avoid making the user having to scroll to much.

Also, I wonder if we need to keep the "kind / owner kind" fields as they are already displayed as icons

/lgtm
tested and reviewed
@jpinsonneau do you want to try your suggestions in this PR or later?

/lgtm tested and reviewed @jpinsonneau do you want to try your suggestions in this PR or later?

I have created a followup so we can really focus on the content
https://issues.redhat.com/browse/NETOBSERV-671

+1 with Andrew's suggestion. Do you think the full edge name "pod-xxx to pod-yyy" would be too long for a title?

Yes this become too long and we will need to truncate

Also remember the side panel is resizable so in some cases we can have a really small space here

rebased + added ResourceLink on title for node selection

Can we match the heading size on the sidebar title?

I want to throw this out there to see what others think.  The Details section is very long.  What if the field name and value were combined on one row and only wraps if it doesn't fit.  Would that make it easier to read?  IMO, the use case for this section is to view fields that are not in the table or to copy the data to report in a bug, etc. This would be different than how the Pod section shows it, which is on separate rows.

One interesting thing would be to add long descriptions on each field like

It could be nice. Some fields are pretty obvious (pod, kind, namespace...) other are less (direction, collection latency..) , we just set a description on those who aren't obvious? (or an info icon + tooltip?) It's also to avoid making the user having to scroll to much.

I agree.  The ones that I don't think are obvious are: Start Time, End Time, Owner, Owner Kind, Direction, Duration, Collection Time, and Collection Latency.

I want to throw this out there to see what others think.  The Details section is very long.  What if the field name and value were combined on one row and only wraps if it doesn't fit.

I like the idea and that would work fine with large panels like this:

However, as soon as the panel is normal / small I would move back all values under their titles for consistency.
Does it makes sense ? @stleerh @andrew-ronaldson
I can create a followup for this about "responsive UI" with similar behaviors in other views

Can we match the heading size on the sidebar title?

Fixed title size:

Also took the opportunity to add a message on External / Unknown nodes:

Check commit https://github.com/netobserv/network-observability-console-plugin/pull/214/commits/41e1f95eb353e7a95118f12f817b7e3119a4bb25

@stleerh I fully agree, if we can avoid too much scrolling and having more info in one sight, I like it :)

It would be good to have a PF empty state for those unknown nodes.
The title font-weight on the linked version is smaller than the non-linked ones. Sizing looks good though.
Based on the details side panel of the dev console it looks like we can reduce the spacing between field labels and info. I see 14px font-size and 1.66em line-height. Also they have some side-by-side content for shorter fields.

Rebased branch, no changes on my side

/ok-to-test

/qe-approved

/lgtm
Just a remark: we need to care about the separation of concerns and all this kind of things / code quality; the element-panel component was already doing multiple various things, now it's growing a little bit, whereas I think it's a very good candidate for more composition.
I'll do it via https://issues.redhat.com/browse/NETOBSERV-474 (I've already started it) ; but that's something to care about continuously.

/approve


Add Steve to CONTRIBUTORS.md 🤠

docs(contributors): Add Steven to contributors list
Summary
This PR adds myself (Steven Steinwand) to the Wagtail contributors list. In previous contributions, I worked on integrating Tailwind to wagtail version 3.0 as well as page editor header, and sidebar updates.
Details
I noticed that my name was missing from the CONTRIBUTORS.md file and am submitting this PR to ensure the file accurately reflects my previous contributions the project 😁.
Contributions List
https://github.com/wagtail/wagtail/pull/8231
https://github.com/wagtail/wagtail/pull/8003
https://github.com/wagtail/wagtail/issues/7918
https://github.com/wagtail/wagtail/issues/7919
https://github.com/wagtail/wagtail/issues/8135
https://github.com/wagtail/wagtail/issues/8641
https://github.com/wagtail/wagtail/pull/9189
https://github.com/wagtail/wagtail/pull/9072
Thank you to the Wagtail team for considering this update!

NOOOOOOOOOOOOOOOOOOOOOOOOOOO!

Thanks for fixing this bug so fast team! 😂


Move filtering of null OperationIdentifier in ProblemReporter

Closes #27416

@bot-gradle merge

WARN: This is a feature pull request but no changes to release note found.

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


Enable dependency flow of secret-manager to engineering services repositories

Currently we don't have automatic updates of the secret-manager tooling in eng services repositories.
The instructions for enabling this in a repo are simple:

add an entry to version.details.xml
add an entry to .config./dotnet-tools.json
Create a subscription for the ".NET Eng Services - Int" or ".NET Eng Services - Prod"  channels depending on whether we want to update for every main build or every production build.

This simplifies the process of pushing updates.

[ ] Arcade
[ ] Helix-machines
[ ] Helix-service
[ ] Dnceng itself (do we need/want this loop? this one is less necessary but might be nice for consistency?)

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

suggest covering the dnceng outputs generally as part of this work. the list of assets produced (see https://maestro-prod.westus2.cloudapp.azure.com/679/https:%2F%2Fgithub.com%2Fdotnet%2Fdnceng/latest/graph) looks manageable


[Fix] Offline payment methods

Se corrige crash en la selección de medios off.

Codecov Report

Merging #689 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #689   +/-   ##
=======================================
  Coverage   28.98%   28.98%
=======================================
  Files         243      243
  Lines       17545    17545
  Branches     1525     1525
=======================================
  Hits         5086     5086
  Misses      11926    11926
  Partials      533      533

Impacted Files
Coverage Δ

...dopago/providers/ReviewAndConfirmProviderImpl.java
3.96% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b0c71...838a50a. Read the comment docs.


gettingstarted/bookshelf/app:  more dynamic startup

It appears there's test failures due to connection refused for
TestMainFunc, which invokes the application rather than the other
tests which render handlers.
On the suspicion something else is leaving the static port 8080 in
a temporarily unusuable state, this change picks a port randomly
and then passes it via the PORT environment variable which is used
by appengine.Main to override the serving port.
Also fixes a minor typo in internal/webtest.

Example from http://sponge/a35b6719-a1c6-44da-a258-cb326a250da1
=== RUN   TestMainFunc
--- FAIL: TestMainFunc (1.97s)
app_test.go:135: Get http://localhost:8080/books: dial tcp [::1]:8080: connect: connection refused

So, was able to get more insight here.  It seems the issue is related to changes in the appengine packages, likely https://github.com/golang/appengine/pull/170.  Because this is a flex app, it attempts to resolve information by interrogating a GCE metadata server.  This causes panics in everywhere that's not a GCE vm, and its racy between goroutines which is yielding the different errors.
The strategy of running this app locally is likely to continue to cause problems.  Likely the quickest option is to remove this build+run test for now, and leave the tests that exercise handlers.  I'll go ahead and remove the test with a followup change, but feel free to let me know if you'd prefer to see a different resolution here.

Remaining test failure is related to DLP.  Tracking that internally as 118816377.


spike: some experiments on use(obserable) - very rough

Extremely rough, actual implementation code that isn't even close to working.
Run test:
yarn install
yarn test packages/react-reconciler/src/__tests__/ReactUseObservable-test.js

For more context, see https://coolsoftware.dev/blog/a-path-towards-observable-values-in-react/

The diff looks bigger than it is because my editor formatted it, but you'll wanna look for the use<T function, or readObservable for net-new code (will add this to PR as well):
https://github.com/coolsoftwaretyler/react/pull/2/files#diff-aeec998530b94be0e2111b96b6b40c165ef6b57c122401e3a3e0dacd0767f9a8R1172

In https://github.com/coolsoftwaretyler/react/pull/2/commits/7c40b75ea89a2ee42aa68c389c616f47b9c6c651, I just started logging the name value in Sync, and the output when you run the test contains:
Running tests for default (experimental)...
  console.log
    name First

      at Sync (packages/react-reconciler/src/__tests__/ReactUseObservable-test.js:97:15)

  console.log
    name Second

      at Sync (packages/react-reconciler/src/__tests__/ReactUseObservable-test.js:97:15)

I also changed the names to First and Second for more clarity.
So it seems like the observability is working, but I'm making a silly mistake in the test set up here.

FYI use needs to work even when there is no dispatcher!

Hey @rcharmeyer - can you say more about what you mean here?

Hey @rcharmeyer - can you say more about what you mean here?

Nevermind, I was just hallucinating a use case that doesn't exist.

Hey @rcharmeyer - can you say more about what you mean here?

Nevermind, I was just hallucinating a use case that doesn't exist.

Haha I 100% understand. The last few days have been full of that for me. Thanks for taking a look anyway! If you know more about React internals than me, I'd appreciate any insights you have.

Heyo, I think I got it.
Since this hacky code doesn't know anything about memoizedProps and React doesn't know about it, the reconciler was bailing out early. That's why the console logs ran (ahead of the actual reconciliation step), but the output wouldn't update in test rendered output or when I was demoing in a real browser.
So now the callback calls fiber.memoizedProps = null which strikes me as 100% not the way this should be handled.
But, it makes this demo minimally functional. Run yarn test packages/react-reconciler/src/__tests__/ReactUseObservable-test.js and see that updating the observed value gets it to update the rendered output.


SSH private key read with ?ssh-format=openssh causes ^M (DOS/Windows line-ending)

When using op to get an SSH private key and use it for CI/CD purposes i ran into this issue.
op read "op://some-vault/some-entry/private key?ssh-format=openssh" > /tmp/key.txt
there are windows line endings
$ grep -r $'\r' /tmp/key.txt
-----BEGIN OPENSSH PRIVATE KEY-----
lz+m8YgbS6fn/D+URRBMAAAAAAECAwQF
-----END OPENSSH PRIVATE KEY-----

When trying to load the key this will result in an error
Load key "/tmp/key.txt": error in libcrypto
removing the line endings with dos2unix or tr -d '\r' fixes this.

Thanks @bartekpacia ! That indeed seems like that was the root cause of this.
I'm going to close this ticket as solved, but please let us know if you're still running into this after that CLI fix and we can re-open to investigate further.


rsync'ing files from WSL 2's file system to a mounted external USB drive is unbearably slow

Please fill out the below information:

Your Windows build number:  Microsoft Windows [Version 10.0.19041.264]

What you're doing and what's happening: Running the rsync command to sync files and directories from WSL 2's file system to an external USB drive is painfully slow

What's wrong / what should be happening instead:
With WSL 1, once I sync'd 400GB of files initially it would only take about 30 seconds to sync ~10 changed files from a mounted internal drive to an external drive. This is my backup process.
With WSL 2, if I do the same thing, it takes literally 20 minutes to sync ~10 changed files.
I'm not sure if it's slow because the permissions are different and those need to be sent over the wire as changes or if it's the new network based mounts with WSL 2.
Here's the output of what happens within WSL 2 after syncing a few file changes:
sent 76,436,320 bytes  received 30,590 bytes  72,929.81 bytes/sec
total size is 460,726,438,034  speedup is 6,025.17

In this case I was syncing an mp3 and a few text files, so it does seem like rsync in itself is mostly working because the mp3 is 69mb in size. I wonder what is happening behind the scenes tho. Is it transferring meta data changes on all of the files due to the permissions changing since WSL 2 has proper Linux permissions but a mounted external drive does not?
This is an issue for me because now with WSL 2, it's expected we put our source code in WSL 2, which means I can't run my backup script from WSL 1 since I'm backing up a combination of things in my WSL 2 file system and mounted drives.

/dupe #4197

@therealkenc Were you able to 100% classify this as a poor file system performance related bug or is it  something to do with the permissions being different when syncing a WSL 2 file with proper Linux permissions to a Windows mounted drive which is causing rsync to do a ton of extra work?

rsync has to getdents(2) all the directories and stat(2) all files, whether they are touched or not. That is slow; slow enough to dominate the wallclock in some cases. It is not somuch "extra" work. It is expected work that takes a terrifically long time.


Broken Test 'Basic JavaScript: Profile Lookup'

Describe your problem and how to reproduce it:
The problem is for test cases:
"Bob", "number"
"Bob", "potato"
To reproduce run solution 1 which is the same solution I came up with
https://www.freecodecamp.org/forum/t/freecodecamp-challenge-guide-profile-lookup/18259
Attached is a screenshot of me running the same code on my browser's console returning the correct result.

Add a Link to the page with the problem:
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/profile-lookup
Tell us about your browser and operating system:

Browser Name: Chrome
Browser Version: 81.0.4044.122 (Official Build) (64-bit)
Operating System: macOS 10.15.4

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
PS Love the platform and the format keep up the awesome work. I guess this is part of my giveback.

Hi @joelszn
The second return on line 41 should return No such property, in the screenshot it shows that both returns are No such property.
The code pasted in the JS console is correct.

Nice eyes @hassaanp. Yea, I think this is just a typo there. Take another look @joelszn and let us know if you still think there's a problem. Otherwise, you can probably close this. Thanks.

good eyes @hassaanp I didn't notice this. It ran successfully afterward. Sometimes it's the simple things that we look over!


fix: typo in pocketbase.go

Thank you. I'll apply it locally as there are some other planned changes to the pocketbase.go methods.

Ok


thread 'main' panicked at 'called Result::unwrap() ... on :latest

Describe the bug
My container auto-updated today and then proceeded to crash. It seems any container in the 2.2x series is failing for me on armv6 with the following message:
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" }', library/std/src/sys/unix/time.rs:418:72

To Reproduce
Docker pull the latest container and start it with the following compose file:
version: "3.3"

services:
  web:
    image: joseluisq/static-web-server:2.19
    container_name: web
    env_file: ./.settings.env
    ports:
      - 8080:80
    volumes:
      - ./web:/public:ro
    restart: unless-stopped
    command: -g info

settings.env contains the following values:
SERVER_PORT=80
SERVER_ROOT=/public
SERVER_ERROR_PAGE_404=/public/404.html

Expected behavior
The container not crash.
Logs/Screenshots
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" }', library/std/src/sys/unix/time.rs:418:72

Environment and Specs

static-web-server: 2.21
OS: Raspberry Pi OS armv6
Docker: 20.10.17
Client: N/A

I gave it a quick try in an ARM64 using linux/arm/v6 and works for me fine using the latest SWS version.
docker run -it --rm -p 8080:80 --platform linux/arm/v6 joseluisq/static-web-server:2.20.1-alpine uname -a
# Unable to find image 'joseluisq/static-web-server:2.20.1-alpine' locally
# 2.20.1-alpine: Pulling from joseluisq/static-web-server
# 33ec62e98cee: Pull complete
# f19c8f4d8a6a: Pull complete
# 669dd6581d2e: Pull complete
# 6e5f682ad5e4: Pull complete
# a37d07888f06: Pull complete
# Digest: sha256:167a4cfeb614ac2f0b3dddc4bd4e317cff8b837a58558ba318552a4624a5b045
# Status: Downloaded newer image for joseluisq/static-web-server:2.20.1-alpine
# Linux c80373ec6127 5.15.49-linuxkit-pr #1 SMP PREEMPT Thu May 25 07:27:39 UTC 2023 armv7l Linux

docker run -it --rm -p 8080:80 --platform linux/arm/v6 joseluisq/static-web-server:2.20.1-alpine -g info
# 2023-07-21T09:53:14.479824Z  INFO static_web_server::info: static-web-server 2.20.1
# 2023-07-21T09:53:14.481297Z  INFO static_web_server::info: log level: info
# 2023-07-21T09:53:14.481995Z  INFO static_web_server::info: server bound to tcp socket [::]:80
# 2023-07-21T09:53:14.482087Z  INFO static_web_server::info: runtime worker threads: 4
# 2023-07-21T09:53:14.482177Z  INFO static_web_server::info: runtime max blocking threads: 512
# 2023-07-21T09:53:14.483030Z  INFO static_web_server::info: fallback page: enabled=false, value=""
# 2023-07-21T09:53:14.483125Z  INFO static_web_server::info: security headers: enabled=false
# 2023-07-21T09:53:14.483203Z  INFO static_web_server::info: auto compression: enabled=true
# 2023-07-21T09:53:14.483280Z  INFO static_web_server::info: compression static: enabled=false
# 2023-07-21T09:53:14.483352Z  INFO static_web_server::info: directory listing: enabled=false
# 2023-07-21T09:53:14.483422Z  INFO static_web_server::info: directory listing order code: 6
# 2023-07-21T09:53:14.483490Z  INFO static_web_server::info: directory listing format: Html
# 2023-07-21T09:53:14.483571Z  INFO static_web_server::info: cache control headers: enabled=true
# 2023-07-21T09:53:14.483848Z  INFO static_web_server::info: basic authentication: enabled=false
# 2023-07-21T09:53:14.483927Z  INFO static_web_server::info: log remote address: enabled=false
# 2023-07-21T09:53:14.484001Z  INFO static_web_server::info: redirect trailing slash: enabled=true
# 2023-07-21T09:53:14.484073Z  INFO static_web_server::info: ignore hidden files: enabled=false
# 2023-07-21T09:53:14.484151Z  INFO static_web_server::info: grace period before graceful shutdown: 0s
# 2023-07-21T09:53:14.484246Z  INFO static_web_server::info: health endpoint: enabled=false
# 2023-07-21T09:53:14.489352Z  INFO Server::start_server{addr_str="[::]:80" threads=4}: static_web_server::server: close time.busy=0.00ns time.idle=299µs
# 2023-07-21T09:53:14.490685Z  INFO static_web_server::info: http1 server is listening on http://[::]:80
# 2023-07-21T09:53:14.490776Z  INFO static_web_server::info: press ctrl+c to shut down the server
# 2023-07-21T09:53:31.647948Z  INFO static_web_server::handler: incoming request: method=HEAD uri=/

curl -I http://localhost:8080/
# HTTP/1.1 200 OK
# content-length: 536
# content-type: text/html
# accept-ranges: bytes
# last-modified: Thu, 20 Jul 2023 21:57:48 GMT
# vary: accept-encoding
# cache-control: public, max-age=86400
# date: Fri, 21 Jul 2023 09:53:31 GMT

--
I'm suspecting that this is most likely a Docker-related thing but not sure. Because looks like the container isn't allowed to get the current time.
Can you please try the Alpine or Debian variant and share how it goes after?
If that is a Docker thing then it could be related to https://github.com/moby/moby/issues/40734

I just tested 2-alpine and that fails with the same log:
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" }', library/std/src/sys/unix/time.rs:418:72

I will test the security opt change next.

Tested adding security-opt to my compose like so:
version: "3.3"

services:
  web:
    image: joseluisq/static-web-server:latest
    container_name: web
    env_file: ./.settings.env
    security_opt:
      - seccomp:unconfined
    ports:
      - 8080:80
    volumes:
      - ./web:/public:ro
    restart: unless-stopped
    command: -g info

And the container starts as expected. So I think this can be closed as this looks to be Docker related.

I just quote below what I think should be worth it to note.

Running with --privileged is not a solution; the reason it works with --privileged is that it disables all (or at least most) security measures that containers provide (among which, disabling seccomp).
I think the problem occurred when running a ubuntu:20.04 container on an older version of ubuntu (16.04), which has a 4.x kernel, so the issue in that case was that the container is making syscalls that the host didn't understand (or at least libseccomp on the host)
https://github.com/moby/moby/issues/40734#issuecomment-638267023

Also, https://github.com/nodejs/docker-node/issues/1780#issuecomment-1267370041

TL;DR: you'll need to update your host to:

Docker version 19.03.9 or newer
libseccomp version 2.4.2 or newer

Just for future users.


All fields is hidden if I add MegaFilter to cards

Hi!
laravel/nova                                     2.12.0
digital-creative/nova-mega-filter                v0.2.8

    use HasMegaFilterTrait;

    public function cards(Request $request)
    {
        return [
            MegaFilter::make([
                'filters' => [
                     // some any filters
                ],
            ]),
        ];
    }

Without MegaFilter card all columns is visible.

This code drop all fields:
``vendor/digital-creative/nova-mega-filter/src/HasMegaFilterTrait.php:67```
$fieldsToShow = $this->getFilterState($request, $card);

Workaround:
    use HasMegaFilterTrait {
        availableFields as disabledAvailableFields;
    }

    /**
     * Get the fields that are available for the given request.
     *
     * @param  \Laravel\Nova\Http\Requests\NovaRequest  $request
     *
     * @return \Laravel\Nova\Fields\FieldCollection
     */
    public function availableFields(NovaRequest $request) {
        return parent::availableFields($request);
    }

Thats indented, you need to set the columns to be able to have them.
public function cards(Request $request)
    {
        return [
            MegaFilter::make([
                'filters' => [
                     ....
                ],
                'columns' => [
                    Column::make('Customer Name', 'name')->addFilter(new ActiveFilter()),
                    Column::make('Assets'),
                    Column::make('Payments')
                ]
            ])
        ];
    }

@milewski What for? I want to use all available columns. Why hide them?

That is how this package works, be able to toggle the columns on/off is one the baked in functionality.. If you want all fields to be always available and not able to toggle you need set them all and call ->permanent() on all of them so they are not able to be toggled off


WIP: Repack blobs

This is work in progress on the code that repacks blobs into new packs.
The code requires the new index format (that was already documented in Design.md), the code takes care to also read the old format and output a warning on stderr. When the check command is run, it converts all indexes to the new format, so users can upgrade and we can remove the code handling the old index format eventually.
Closes #243

I've extracted a few commits from this into #294 in order to break this PR into smaller ones.

I've extracted more commits into #310.

This PR now introduces the optimize command and changes the behaviour of the check command:

check only tests for errors
optimize converts index format if necessary and rebuilds pack files so that unused blobs can be dropped


Minified version doesn't "stick" event when switching months.

Issue reproduced in this plunker: http://plnkr.co/edit/SpB35NS9YjxobwF4HBsQ?p=preview
Steps to reproduce:

Add new event.
Switch back and forth months.

The newly added event disappears from the calendar.
When loading unminified version of ui-calendar it works fine.

ok, well we should not even had that min file in the repo. so thanks. :) I removed it.
if you use the most updated minified file from master it works. This needs to be built from the command line via 'grunt minify' http://plnkr.co/edit/H9wKUTpbIONkscIRFK6A?p=preview

Thanks for the update!, it would still be cool to have a minified version in the Bower package though.

Why the minified file was removed?


Fix Windows ZipPath failure

[x] Add a test case for opening DBF files from within a Zip archive, as is done with PUDL.
[ ] Make accessing DBFs within Zip archives work on Windows. See: catalyst-cooperative/pudl#749

It turns out that the issue was on the PUDL side -- in the way that the paths for looking within the zipfiles were being specified (using OS-specific path separators through the pathlib.Path class). However I have added test cases that demonstrate how it should work in here now.


fix(minify): fix default htmlmin options

Right now the bundler minifies html like so:
Input:
<template>
</template>

Output (note the space):
<template> </template>

Output with this PR (no space):
<template></template>

Is that safe?

I think it is safe. However @ahmedshuhel chose these options with a reason so it might not be safe.

@ahmedshuhel Any thoughts on this? I know we discussed the options. I can't remember the details of the conversation though  ;)

What if the layout depends on at least one whitespace? Those would be then be removed.
It is good practice not to depend on spaces in your html to fix your layout. Instead of spaces, css should be used to position the elements. Those are the guidelines set by Google and others.
I would say the default shouldn't be to have conservativeCollapse set to true.

@ahmedshuhel Isn't there a way to override the settings?

@Gheoan We may want to be conservative with our default options. However, I remember discussing with @ahmedshuhel that there should be a way to override them in the bundle config. @ahmedshuhel Can you clarify please?

@EisenbergEffect The htmlmin options can be oberriden per bundle.


libsql: provide more return info for sync

This PR changes the return type of sync to a struct that provides the current commit fno and how many frames that sync call required. This should give more insight to users to understand how much data has been synced.

It is not helping in review that you're reformatting code not changed in the PR.

I am not sure why my editor is formatting something but running cargo fmt isn't. I need to look into that since those changes should be enforced by CI.


Added ScaledObject parameter StartReplicaCount to scale from 0 to N

This pull request introduces a new parameter, startReplicaCount, to the ScaledObject in order to change the scaling behavior from 0. The goal is to facilitate scaling from 0 to N replicas, instead of the default 0 to 1.
This change can be useful in scenarios where applications need fast responsiveness when is activated.
Checklist

[ ] I have verified that my change is according to the deprecations & breaking changes policy
[ ] Changelog has been updated and is aligned with our changelog requirements
[ ] A PR is opened to update our Helm chart
[ ] A PR is opened to update the documentation on (repo)
[ ] Commits are signed with Developer Certificate of Origin

Relates to #
PR Helm chart: https://github.com/kedacore/charts/pull/606
PR Documentation: https://github.com/kedacore/keda-docs/pull/1308

Hello!
Thanks for the contribution, but this is already supported: https://keda.sh/docs/2.13/concepts/scaling-deployments/#idlereplicacount
You can set idleReplicaCount: 0 and then, KEDA will scale from 0 to minReplicaCount and from minReplicaCount to 0.

Hello @zroubalik,
Thank you for your reply. When the startReplicaCount is configured as 5, it enables scaling between 0 and the specified startReplicaCount value. Then the scaling process from startReplicaCount to 0 can be decremental and gradual, in example following sequence such as 5 -> 4 -> 3 -> 2 -> 1 replicas.
In contrast, utilizing idleReplicaCount restricts scaling to occur solely between minReplicaCount:5 and idleReplicaCount:0 without decrementing gradually replicas.
I'd appreciate your thoughts


Just have a try as example of tuling bot. But method message.self() seems work improper.

In src/message.ts I suppose  method message.self() denotes that it checks whether message is sent by self. But it seems compare between message-id and user-id.
code segment as below:
public self(): boolean {
const userId = Config.puppetInstance()
.userId
const fromId = this.obj.id

I do like your contribution and just wonder whether the method is as my expectation or not.

hi @kyle-yu ,
thanks for your review, and you are right, fromId should get from this.obj.from.
it's a mistake made by me, just fixed in the master.
please feel free to let me know if there's other mistakes made by me, appreciated it.


nixos/test-driver: Run commands with pipefail set

Motivation for this change
Bash's standard behavior of not propagating non-zero exit codes through a pipeline is unexpected and almost universally
unwanted. Default to setting pipefail for the command being run; it can still be turned off by prefixing the pipeline with
set +o pipefail if needed.
Things done

Tested by constructing a test with a failing command early in the pipeline
[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

just out of curiosity, what kind of situation did you run into?

Result of nixpkgs-review pr 125683 at 548708c5 run on x86_64-linux 1

2 packages built successfully:

nixos-install-tools
tests.trivial

@tfc  A concrete example where running without this could create a false positive is in the test introduced in #125404, where if the curl command fails, the whole pipeline still succeeds because jq returns zero when given empty input. This should also apply to https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/discourse.nix and https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/keycloak.nix for the same reason.

makes sense. can you please schedule a selection of tests that do some heavy piping between processes to see if we don't break anything? if a test breaks after such change then the test itself might be broken but we should handle that.

I've run lots of tests now and the problem I encountered was that when grep -q is used with curl, it closes the pipe early, which curl doesn't handle gracefully, but exits with an error, failing the pipeline. To fix this, I've simply removed the -q flag from grep where it's used with curl.

The change it self lgtm, but I'm concerned that this may break tests in surprising ways for other who do not know about this change.
Was solving grep -q sufficient? How many tests can we expect to be broken still?

Yes, solving the grep -q issue was enough for all the test I ran, and I ran quite a few, focusing on those who make heavy use of piping. I think curl is an outlier here, where most programs don't error when the pipe is closed early. Considering that all or almost all curl commands I could find have the -f flag specified, the test authors seem to have assumed that pipefail was already in effect, as I did when I wrote some of them.

The change looked good, so I've kicked off https://hydra.nixos.org/eval/1676118 before merging, so we can find any new failures on hydra. It's currently evaluating with the change.

I've started evaluation after the change, twice, but the evaluations disappeared before completion. I don't know why.
We'll have to check for newly failed tests when the next evaluation does complete.

Hm, yeah, the error log at https://hydra.nixos.org/jobset/nixos/trunk-combined#tabs-errors contains lots of
warning: error: SQLite database '/nix/var/nix/db/db.sqlite' is busy

errors, but also ends with the rather cryptic
error: [json.exception.type_error.302] type must be string, but is null

so, maybe one of those is the culprit?

Those errors are somewhat expected and happen during evaluation of nixpkgs. The tests evaluated fine and are listed here but many other changes were in that batch. I've checked most of them and they seem to fail for reasons unrelated to your pr.

I see. The database warning doesn't appear in the successful evaluations I checked, so it seemed out of place, but I don't know much about Hydra :shrug:


Release 0.2.0

First release on non-test pypi

Codecov Report

Merging #3 (0676a69) into master (bb11147) will not change coverage.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   84.52%   84.52%
=======================================
  Files          10       10
  Lines         265      265
=======================================
  Hits          224      224
  Misses         41       41

Files Changed
Coverage Δ

...ustom_admin_pages/tests/test_custom_admin_pages.py
87.75% <83.33%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Will you make it to produce machine code like c and c++.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @Neerajsh8851 last year when I have released the version 1.4 it's was just for prototype, since we got this much attention, last from last few months i am currently working on a rust based interpretor for our Vedic Lang.
Hopefully we gonna release it soon


Harvest should include remediation steps for EMS alerts

Start with a runbook annotation pointing to public docs and add local docs if needed for dark sites

[ ] Active sync events
[X] All other events

This issue is done. Moving active sync events to separate issue


Use of lovell/sharp/master/preinstall.sh is deprecated, will be removed at end of 2016

Hello,
A quick Github search reveals this repo still contains at least one refence to the deprecated preinstall.sh script at https://raw.githubusercontent.com/lovell/sharp/master/preinstall.sh
At the end of 2016 this script will be removed and the URL will return a 404 status code.
sharp v0.12.0+ does not require the use of this script.
Please take and maintain a copy if still required by this repo.
Thank you for using libvips/sharp!
Cheers,
Lovell

That's some good maintaining! :+1:

Thanks :)


adding a note about -i

Hey guys, thanks for the great project!
I was going through the documentation to set up a playground environment locally but I was immediately blocked when I was trying to create a custom action other than just hello-world (or even any interactions using wsk was giving errors). In short, I was basically getting
error: Unable to obtain the list of actions for namespace 'guest': Get https://localhost/api/v1/namespaces/guest/actions?limit=30&skip=0: x509: certificate signed by unknown authority

After a half an hour worth of investigation, I realised that make hello-world was using -i to create the functions, which bypasses the SSL and I was able to create, delete and list using wsk by adding -i. To help others to avoid the same issue, I propose adding a short note to inform the new users about -i usage in the makefile.

The build is failing at the maven archetype build. Given that this is a README only change, I'll go ahead and merge it as is.


[RAG] Introduce reranking to the RAG retrieval process

Introduce reranking step to retrieval process
Add RAG example with reranking enabled

Frequently, not all results retrieved by RetrievalAdvisor are truly relevant to the user query. This is because, during the initial retrieval stage, it is often preferable to use faster and more cost-effective models, particularly when dealing with a large volume of data. The trade-off is that the retrieval quality may be lower.
Providing irrelevant information to the LLM can be costly and, in the worst case, lead to hallucinations. Therefore, in the second stage, we can perform re-ranking of the results obtained in the first stage and eliminate irrelevant results using a more advanced model (e.g., Cohere Rerank).

done and close this issue.

#54


pin vs. pins

@disintegrator @geek Is there any difference between defining multiple clients declaring a pin and just a single client with a pins array? Concretely, I am comparing the following scenarios:
Multiple clients
var seneca = require('seneca')()
  .use('seneca-amqp-transport')
  .client({
    type: 'amqp',
    pin: 'name:contact'
  })
  .client({
    type: 'amqp',
    pin: 'role:email'
  });

Single client with an array of pins
var seneca = require('seneca')()
  .use('seneca-amqp-transport')
  .client({
    type: 'amqp',
    pins: ['name:contact', 'role:email']
  });

I'm asking this, because, currently, the plugin doesn't show the same behavior in those scenarios. First one will create two clients, each one with its own res queue; while the second one, creates only one.
Same question goes for listeners, actually. What about those?

So, @geek can correct me here. But my understanding is they're working as expected. The first is saying I specifically want two clients (use case, multiple port numbers) the second is say I want both of these messages to go to the one client (use case, granular definition of multiple pins to one client).
Bear in mind too order is important. so client one has preference to client two if both declare the same pins, client one will be called before client two.

@mcdonnelldean Great. You are confirming my suspicions, then. Thanks.


[FIXES#311]added contributer name and fixed typo in README

sorry the list is for those who've contributed examples to the project or significant additions like a new translation.


Added EMPD2 samples contributed by Finsinger

Hi! I'm your friendly automated EMPD-admin bot!
Thank you very much for your data submission! I will now run some tests on your data.
In the meantime: please review your test data on the EMPD viewer using
this link: https://EMPD2.github.io/?repo=EMPD2/EMPD-data&branch=Finsinger&meta=Finsinger.tsv
This bot is helping you merging your data. I am checking for common issues and I can fix your climate, country or elevation data.
Type @EMPD-admin help in a new comment in this PR for usage information.
Make sure, that all the commands for the @EMPD-admin are on one single line and nothing else. Only
@EMPD-admin help
will work, not something like
<other words> @EMPD-admin help
or
@EMPD-admin help <other words>
Note that you can also run these tests on your local machine with
pytest.

Hi! I'm your friendly automated EMPD-admin bot!
I found some errors in your data submission. You may fix some of them using the @EMPD-admin fix command.
Please ping @Chilipp if you have difficulties with your submission.
Critical tests..PASSED
Full test report
============================= test session starts ==============================
platform linux -- Python 3.7.2, pytest-4.3.1, py-1.8.0, pluggy-0.9.0
rootdir: /opt/conda/lib/python3.7/site-packages/empd_admin/data/tests, inifile: pytest.ini
collected 37 items / 34 deselected / 3 selected
/opt/conda/lib/python3.7/site-packages/empd_admin/data/tests/test_critical.py ...
=============================== warnings summary ===============================
opt/test-env/lib/python3.7/site-packages/socks.py:58
/opt/test-env/lib/python3.7/site-packages/socks.py:58: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Callable
-- Docs: https://docs.pytest.org/en/latest/warnings.html
============= 3 passed, 34 deselected, 1 warnings in 3.39 seconds ==============

Formatting tests..FAILED
test_formatting.py::test_trailing_spaces..FAILED

error
E   AssertionError: Found 1 cells with trailing spaces
    assert not 1
     +  where 1 = len(                     SiteName\nSampleName                   \nFinsinger_a8  Biviere Cesaro )

1 failed samples

SiteName

Finsinger_a8
'Biviere Cesaro '

Displaying 1 of 1 samples

Full test report
============================= test session starts ==============================
platform linux -- Python 3.7.2, pytest-4.3.1, py-1.8.0, pluggy-0.9.0
rootdir: /opt/conda/lib/python3.7/site-packages/empd_admin/data/tests, inifile: pytest.ini
collected 7 items
/opt/conda/lib/python3.7/site-packages/empd_admin/data/tests/test_formatting.py F...sss
=================================== FAILURES ===================================
/opt/conda/lib/python3.7/site-packages/empd_admin/data/tests/test_formatting.py:15: AssertionError: Found 1 cells with trailing spaces
=============================== warnings summary ===============================
test_formatting.py::test_trailing_spaces
test_formatting.py::test_trailing_spaces
/opt/test-env/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
return f(*args, **kwds)
-- Docs: https://docs.pytest.org/en/latest/warnings.html
========== 1 failed, 3 passed, 3 skipped, 2 warnings in 3.10 seconds ===========

Metadata tests..FAILED
test_meta.py::test_country..FAILED

error
E   AssertionError: Found 2 invalid Countries: Finsinger_a12, Finsinger_a24
    assert not 2
     +  where 2 = len(               OriginalSampleName  ... Country_ok\nSampleName                         ...           \nFinsinger_a12                  13  ...      False\nFinsinger_a24                  26  ...      False\n\n[2 rows x 76 columns])

2 failed samples

Country
nat_earth
empd_countries
okexcept(Country)
Country_ok

Finsinger_a12
Italy

Italy
False
False

Finsinger_a24
Italy
France
France
False
False

Displaying 2 of 2 samples

Full test report
============================= test session starts ==============================
platform linux -- Python 3.7.2, pytest-4.3.1, py-1.8.0, pluggy-0.9.0
rootdir: /opt/conda/lib/python3.7/site-packages/empd_admin/data/tests, inifile: pytest.ini
collected 20 items
/opt/conda/lib/python3.7/site-packages/empd_admin/data/tests/test_meta.py ..F.................
=================================== FAILURES ===================================
/opt/conda/lib/python3.7/site-packages/empd_admin/data/tests/test_meta.py:80: AssertionError: Found 2 invalid Countries: Finsinger_a12, Finsinger_a24
=============================== warnings summary ===============================
test_meta.py::test_meta_exists
test_meta.py::test_meta_exists
/opt/test-env/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
return f(*args, **kwds)
-- Docs: https://docs.pytest.org/en/latest/warnings.html
=============== 1 failed, 19 passed, 2 warnings in 6.28 seconds ================

@EMPD-admin fix trailing

Hi! I'm your friendly automated EMPD-admin bot!
I processed your command and hope that I can help you!

fix trailing

PASSED
Full test report
============================= test session starts ==============================
platform linux -- Python 3.7.2, pytest-4.3.1, py-1.8.0, pluggy-0.9.0
rootdir: /opt/conda/lib/python3.7/site-packages/empd_admin/data/tests, inifile: pytest.ini
collected 7 items / 6 deselected / 1 selected
/opt/conda/lib/python3.7/site-packages/empd_admin/data/tests/fixes.py .
=============================== warnings summary ===============================
opt/test-env/lib/python3.7/site-packages/socks.py:58
/opt/test-env/lib/python3.7/site-packages/socks.py:58: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Callable
-- Docs: https://docs.pytest.org/en/latest/warnings.html
============== 1 passed, 6 deselected, 1 warnings in 2.55 seconds ==============

@EMPD-admin accept Finsinger_a12:Country Finsinger_a24:Country

@EMPD-admin test

Hi! I'm your friendly automated EMPD-admin bot!
I processed your command and hope that I can help you!

test

All tests passed!

@EMPD-admin finish --commit

Hi! I'm your friendly automated EMPD-admin bot!
I processed your command and hope that I can help you!

finish --commit

Finished the PR!
You may want to have a final look into the viewer (https://EMPD2.github.io/?repo=EMPD2/EMPD-data&branch=Finsinger) and then merge it.


Make ? open help too, and close it also with ? or h

Add ? for invoking help, and let the same key close it.
Fixes https://github.com/altsem/gitu/issues/124

Hey @abitrolly!
If think this'd make sense, if it were not for the plans to later add search functionality - which is commonly bound to / and ?.
As found in: https://github.com/altsem/gitu/issues/5

@altsem left some ? binding related comments in https://github.com/altsem/gitu/issues/5#issuecomment-2471565549

I did some googling. I think Doom Emacs uses ? for the help menu (haven't confirmed this).
Is that the case for other evil-mode ways of using Magit?
If that is the case, it feels like a no-brainer to copy this behaviour.

@altsem Magit itself uses ? - https://github.com/niyumard/Doom-Emacs-Cheat-Sheet?tab=readme-ov-file#magit

Let's merge this then :)
I noticed h -> h or ? -> ? opens up a manual in Doom. But we don't have one yet, so seems fine.
Thanks for talking some sense into me.


group req and res into blank nodes

As described in https://github.com/solid/test-suite/pull/44#discussion_r320836679

Thanks for this! Very useful to have these as notes. I've have begun the work on this one.