How to access a value inside of an expression of a "dropdown column" in "matrixdynamic question" to use it within visibleIf?

Are you requesting a feature, reporting a bug or asking a question?
Asking a question
What is the current behavior?
      // this is not very helpful since the index may not be 0
      visibleIf: "{life-events.0.life-event} equal 'car-accident'",

      // tried these, no luck

      // visibleIf: "{life-events.life-event} equal 'car-accident'",
      // visibleIf: "{life-event} contains 'car-accident'",
      // visibleIf: "{life-events.life-event} contains 'car-accident'",
      // visibleIf: "{life-events} contains {'life-event': 'car-accident'}",

What is the expected behavior?
      visibleIf: "{life-events.life-event} contains 'car-accident'",

How would you reproduce the current behavior (if this is a bug)?
Provide the test code and the tested page URL (if applicable)
Tested page URL:  https://plnkr.co/edit/nDPTc4HsG0G6RudtVK1Z?p=preview
Test code

Survey.Survey.cssType = "bootstrap";
Survey.defaultBootstrapCss.navigationButton = "btn btn-green";

window.survey = new Survey.Model({ questions: [
          {
            type: "matrixdynamic",
            name: "life-events",
            title: "Enter the date you are",
            addRowText: "Add Life Event",
            removeRowText: "x",
            columns: [
              {
                name: "life-event",
                cellType: "dropdown",
                title: "Life event(s)",
                columnName: "life-event",
                isRequired: true,
                choices: [
                  {value: "car-accident", text: "Had a car accident"},
                  {value: "left-work", text: "Left work"},
                ]
              },
              {
                name: "life-event-date",
                title: "Date",
                cellType: "text",
                inputType: "date",
                dateFormat: "mm/dd/yy",
                isRequired: true
              }
            ],
            rowCount: 2
          },

    {
      type: "comment",
      name: "car-accident-comment",
      title: "How did your car accident happen?",

      // this works only if they select "Car accident" as the first life event,
      // if the user selects it in the second row after they click "Add Life Event"
      // it won't work since the index would be 1
      visibleIf: "{life-events.0.life-event} equal 'car-accident'",

      // tried these, no luck
      // visibleIf: "{life-events.life-event} equal 'car-accident'",
      // visibleIf: "{life-event} contains 'car-accident'",
      // visibleIf: "{life-events.life-event} contains 'car-accident'",
      // visibleIf: "{life-events} contains {'life-event': 'car-accident'}",

      isRequired: true
    },

    {
      type: "comment",
      name: "left-work-comment",
      title: "How or why did you leave work?",

      // same issue here
      visibleIf: "{life-events.1.life-event} equal 'left-work'",

      isRequired: true
    }
]});
survey.onComplete.add(function(result) {
	document.querySelector('#surveyResult').innerHTML = "result: " + JSON.stringify(result.data);
});

survey.setValue("region", "Africa");

$("#surveyElement").Survey({model:survey});

Specify your

browser: Chrome
browser version:  67.0.3396.99
surveyjs platform (angular or react or jquery or knockout or vue): Vue
surveyjs version: 2.5.16

Thanks!

@akhoury I have created an example: https://plnkr.co/edit/hR7b59TyUaHsmJJtO4OC?p=preview
visibleIf should be: "{row.car-accident} equal 'left-work'" or "{panel.car-accident} equal 'left-work'"
You may use matrixdynamic or paneldynamic or both and make some questons readOnly in the panel.
Thank you,
Andrew

I see, thanks @andrewtelnov but I was hoping to make the expression on a totally different page, not in the same row or panel, is there a way to do that? sorry if I wasn't 100% clear at first

@akhoury ok, I have updated the example accordingly.
Please take into account, that I'm using the latest version 1.0.33.
Thank you,
Andrew

I'm sorry again, but I got confused, do I have to use a panel on the next page in order to access the matrixdynamic's values? is there a way to do it for a simple question?
something like ?
window.survey = new Survey.Model({
  pages: [
    {
    questions: [{
      type: "matrixdynamic",
      name: "life-events-matrix",
      valueName: "life-events",
      title: "Enter the date you are",
      addRowText: "Add Life Event",
      removeRowText: "x",
      columns: [{
        name: "life-event",
        columnName: "life-event",
        cellType: "dropdown",
        title: "Life event(s)",
        isRequired: true,
        choices: [{
          value: "car-accident",
          text: "Had a car accident"
        }, {
          value: "left-work",
          text: "Left work"
        }, ]

      }, {
        name: "life-event-date",
        title: "Date",
        cellType: "text",
        inputType: "date",
        dateFormat: "mm/dd/yy",
        isRequired: true
      }],
      rowCount: 1
    }]
  }, {
    questions: [{
      type: "comment",
      visibleIf: "{panel.life-event} equal 'car-accident'"
    }]
  }]
});

@akhoury panel dymic and matrix dynamic are shared the same data, valueName: "life-events".
For every row in matrix dynamic, you will have one panel in panel dynamic. On adding/removing/changing rows in matrix dynamic, data in panel dynamic will change accordingly.
To which row are you going to bind your question?
Simple question is one value. You want to edit the array. How do you want to edit the array in one text question?
Panel dynamic solves this issue. It was created to edit the array of objects, same as matrix.
Thank you,
Andrew

I see I see, it makes sense now, i guess I kind of wished there is a way to eval a full javascript expression, even if there is a little bit of performance hit; with a small and finite number of questions it won't be a huge hit.
Thank you for your quick responses! and awesome work!

by the way, this is kind of what i mean about being able to execute any javascript expression in the "visibleIf" expression, along with limiting the context in it to the surveyModel.data
now I can do something like:
visibleIf: "eval( this['life-events'] ? this['life-events'].map(e => e['life-event']).indexOf('car-accident') > -1 : false )",

I check if there is "eval( ... )" in the expression, if there is, I eval it with a context.
example here
https://plnkr.co/edit/LJq0ppyJyVDnJYdKFg4d?p=preview
However, i have to do it on onAfterRenderPage, onValueChanged events and after the survey is initialized at first.

@akhoury visibleIf expression should return true or false.
You may use built-in or your own custom functions. Here is the documentation
Thank you,
Andrew

Oh! "functions in expressions" are exactly what I want! thanks!


Has this library abandoned maintenance? Haven't seen the update for a long time

@vitusortner @mqus anything to share on this? I need support for JOIN statements, and starting to wonder if I might need to look for alternative libraries. Would be a real shame, I really like the semantics and structure of this one and think you've done an amazing job so far.

Hi, thanks for bringing this up! To begin with, the maintenance has not been abandoned. The last months have been super busy and I'm looking forward to spending more time working on improvements again soon.
To speed this process up, we need your support. Tell us about the problems you're facing and the features you're wishing for. In case you're interested in helping manage the community around the library or ship updates – we're always happy about contributions.

@vitusortner I need a release version, #531 has been merged for a long time. But there has not been a release version, and now I use source code integration, which is a bit inconvenient. Thanks.

@vitusortner That's wonderful news, thanks for letting us know. The one problem I hit repeatedly is, at its core, covered by  #94.

@T-Oner I am not sure what exactly do you need, but maybe this will be helpful 'SELECT * FROM contacts ORDER BY firstName || " " || lastName', when done in this manner code is generated correctly


Struct as parameter in action

I am trying to call an action with two parameters of which one is a struct. I saw this issue but can not figure out how to properly call it from eosjs. The error messages are also rather cryptic ;).
struct string_field {
  bool is_private;
  std::string value;
};

/// @abi action
void create(const account_name& account, const string_field& first_name);

"structs": [{
      "name": "string_field",
      "base": "",
      "fields": [{
          "name": "is_private",
          "type": "bool"
        },{
          "name": "value",
          "type": "string"
        }
      ]
    },{
      "name": "create",
      "base": "",
      "fields": [{
          "name": "account",
          "type": "name"
        },{
          "name": "first_name",
          "type": "string_field"
        }
      ]
    }

I tried  "andi" , { is_private: false, value: "Andi" }} and { account: "andi" }, { first_name: { is_private: false, value: "Andi" } } both did not succeed (Error: Required uint8 string_field.is_private create.first_name action.data transaction.actions).
Thanks a lot!

This was the correct solution: { account: "andi", first_name: { is_private: 0, value: "Andi" } } note that the boolean expects a uint8. If you are having a similar problem run contract[your_action]() without arguments to see example usage.


Document convention of using expedited flag for when we force interruption of planned work

This was suggested by @gabrielamafra to help us get visibility on the frequency and characteristics of urgent requests that interrupt planned or in progress work.
The idea is that if any work is deemed so urgent that is MUST jump the queue, we should clearly flag this, so that we can see how often we end up needing to break concentration/focus and disrupt our plans. By making this visible, we'll be able to identify patterns that should help us reduce the frequency, thus giving us more time to focus and build up/maintain momentum, and greater assurance that we are spending our time working on the important stuff.
Let's

[ ] Record this convention in our COORDINATION.md document
[x] Start putting it in practice, beginning with labeling the current interrupting work (see https://github.com/informalsystems/apalache/labels/expedite)

Here are some perhaps useful references:
Section 'Types of Kanban Classes of Service for Risk Management' in How to Manage Risk with Kanban Classes of Service? explains how expedites compare to other types of tasks
As for managing expedites in our project board, the most recommended approach is to use a swimlane (as explained here - you can search for "expedite" to see this specific example), which is essentially a new line (rather then a new column). Since github doesn't support swimlanes, we can virtually just keep expedite cards at the top of the column to create a similar effect.
The guidelines on How to Manage Unplanned Work in Kanban can also be a nice read.

Super helpful. Thanks!
I agree simulating a lane with the labels is probably a good solution for now. We can also use alternate views to filter these out. I created one here: https://github.com/orgs/informalsystems/projects/30/views/11


Lsps re-attach twice

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Neovim version
NVIM v0.10.0-dev-115+g240c41e1a
Operating system/version
ubuntu 22.04
Terminal name/version
gnome terminal
$TERM environment variable
xterm256-color
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
Affected language servers
any
How to reproduce the issue

Add below code to core/event.lua, which should clear the diagnostics for .env.

vim.api.nvim_create_autocmd("LspAttach", {
	pattern = ".env",
	callback = function(args)
		require("null-ls").disable({ "shellcheck" })
		local client = vim.lsp.get_client_by_id(args.data.client_id)
		if client.name == "null-ls" then
			local ns = vim.lsp.diagnostic.get_namespace(client.id)
			vim.diagnostic.disable(nil, ns)
			vim.lsp.buf_detach_client(args.buf, client.id)
		end
	end,
})

The diagnostics will be cleared at first, but soon the null-ls got re-attached  for some reason.

Actual behavior
as above
Expected behavior
No response
Support info
I'm recently start playing with docker and some docker projects will have an .env file which will be diagnosed by shellcheck from null-ls. However, shellcheck diagnosis is useless for .env, therefore I want to remove it.
Snippets of .env:
# Mattermost settings
## Inside the container the uid and gid is 2000. The folder owner can be set with
## `sudo chown -R 2000:2000 ./volumes/app/mattermost`.
MATTERMOST_CONFIG_PATH=./volumes/app/mattermost/config
MATTERMOST_DATA_PATH=./volumes/app/mattermost/data
MATTERMOST_LOGS_PATH=./volumes/app/mattermost/logs
MATTERMOST_PLUGINS_PATH=./volumes/app/mattermost/plugins
MATTERMOST_CLIENT_PLUGINS_PATH=./volumes/app/mattermost/client/plugins
MATTERMOST_BLEVE_INDEXES_PATH=./volumes/app/mattermost/bleve-indexes

after applying above autocmd, the diagnosis disappeared for one second and it shows up again.
Also it's still in the LspInfo

Logs
`.local/state/nvim/lsp.log`:

[START][2023-04-18 16:03:18] LSP logging initiated
[WARN][2023-04-18 16:03:18] ...lsp/handlers.lua:137	"The language server copilot triggers a registerCapability handler despite dynamicRegistration set to false. Report upstream, this warning is harmless"

Additional information
No response

Side note: it seems like we can remove neodim, I comment out neodim and the dimming affect is still there.

u can directly set another filetype for *.env to avoid this issue (based upon ur latest commit b372a34):
diff --git a/lua/core/event.lua b/lua/core/event.lua
index be9c970..b572443 100644
--- a/lua/core/event.lua
+++ b/lua/core/event.lua
@@ -87,6 +87,8 @@ function autocmd.load_autocmds()
                        { "BufWritePre", "MERGE_MSG", "setlocal noundofile" },
                        { "BufWritePre", "*.tmp", "setlocal noundofile" },
                        { "BufWritePre", "*.bak", "setlocal noundofile" },
+                       -- disable bashls and shellcheck for *.env
+                       { "BufNewFile,BufRead", "*.env", "setlocal filetype=env" },
                        -- auto change directory
                        -- { "BufEnter", "*", "silent! lcd %:p:h" },
                },

Side note: it seems like we can remove neodim, I comment out neodim and the dimming affect is still there.

This comes from LSP semantic tokens (:Inspect would probably give @lsp.type.comment). We need to keep neodim b/c not all servers support semantic tokens.

that's another workaround i'm considering.
but i'm wondering if attaching lsp twice would take some performance hit?

This comes from LSP semantic tokens (:Inspect would probably give @lsp.type.comment). We need to keep neodim b/c not all servers support semantic tokens.

got it! this make sense, or maybe we can further disable 'neodim' on some filetype to prevent rendering highlights twice?

+  { "BufNewFile,BufRead", "*.env", "setlocal filetype=env" },

That's another workaround I'm considering, but thanks for writing it in such a concise form!
However, the thing is that seems like a weird behavior when the LSPs got attached twice. Maybe it might cause a bit of performance hit?

I remember why I don't want to use this method, since all highlights are gone too lol.

I think the ability to detach lsps from some files is still necessary.
For example, docker-compose.yml is a yaml file for sure, but yamlls is basically unusable when attaching to it.
But I still want it;s filetype to remain yaml b/c docker_compose_language_service need it to be yaml.^1

Ah, I've got it! Will check this issue after ! Refactor Treesitter highlights (currently working on this, lots of thingy to do lol). We could have a new user command :NullLsToggle <server> using null-ls's private API.

Perhaps we can further exclude neodim on some known filetypes which there's LSP has semantic tokens? In this way we can prevent rendering the highlights twice ( I know this might be too trivial to implement, totally understandable not doing it ).

This is possible, we could check if a server supports textDocument.semanticTokens before attaching neodim to that server.

Ah, I've got it! Will check this issue after ! Refactor Treesitter highlights (currently working on this, lots of thingy to do lol). We could have a new user command :NullLsToggle <server> using null-ls's private API.

Understandable! Sometime I wonder how u have the knowledge to do all these lol
nvim super man! :superhero:

Perhaps we can further exclude neodim on some known filetypes which there's LSP has semantic tokens? In this way we can prevent rendering the highlights twice ( I know this might be too trivial to implement, totally understandable not doing it ).

This is possible, we could check if a server supports textDocument.semanticTokens before attaching neodim to that server.

I can work on that first.

Sometime I wonder how u have the knowledge to do all these lol

Probably b/c I read some of the fundamental documentations before lol (:h starting, :h cmdline, :h options, :h events, :h api, :h lua, :h lsp, and :h quickref as its name suggests, is a good place for concise reference).
Help pages are always very helpful 😆

Reopening b/c I have a plan to implement this.

For those whom might interested:
After #872 got merged, I added an autocmd to Toggle those source when dealing with .env:
-- auto stop bashls, shellcheck and shfmt when editing docker-related files
	vim.api.nvim_create_autocmd("LspAttach", {
		pattern = {
			".env",
		},
		callback = function()
			vim.api.nvim_command([[LspStop 1 (bashls)]])
			vim.api.nvim_command([[NullLsToggle shellcheck]])
			vim.api.nvim_command([[NullLsToggle shfmt]])
		end,
	})


sudo_cmd

Getting this error after following steps on Debian 12:
~/ARK_Ascended_Docker# sudo ./manager.sh status
./manager.sh: line 14: sudo_cmd: unbound variable
Not sure how I would correct this, the variable seems to be set correctly in manager.sh

Please do a git pull and try again. It should hopefully be fixed now :)


SyntaxError: expected expression, got '<'

The file tipuesearch_content.js has no an layout defined than Jekyll 3.4.3 is using the other layout, the default in my case.
This issue make the generated JS file with HTML content. Than the javascript break. The output error is  SyntaxError: expected expression, got '<' why the build file starts with the default template, <DOCTYPE html....
To solve this I added a variable in the liquid tipuesearch_content.js.
The header as follow:
---
# Content index for Tipue Search
# https://github.com/jekylltools/jekyll-tipue-search
# v1.2
layout: null
---

It is "simple" but avoid this error. Perhaps you can add it by default. Thank you!

This makes senses. thanks for your help!


add runlog for Aave OUSD allocation

add runlog for Aave OUSD allocation

Merging since the TX has already been executed by the strategist


Add ts-loader

Is your feature request related to a problem? Please describe.
We build ts files using tsc, but we can use webpack instead if we use ts-loader
Describe the solution you'd like
use ts-loader https://webpack.js.org/guides/typescript/

We don't need ts loader because ts loader is in charge of converting typescript (es6) to javascript (es6)


Cannot find an overload for 'contains' that accepts an argument list of type '([Int], Expression)'

I tried the expression:
userTable.filter(contains([1, 2, 3, 4, 5], entryId))

from the example. But I got the following error:
Cannot find an overload for 'contains' that accepts an argument list of type '([Int], Expression<String>)'

Short answer: it's type-safe, like Swift in general.
Long answer: please use Stack Overflow. I'll elaborate on the above there if you don't understand.
From the README:

Communication

Need help or have a general question? Ask on Stack
Overflow (tag sqlite.swift).
Found a bug or have a feature request? Open an issue.
Want to contribute? Submit a pull request.

None of the issues you've reported seem to be bugs or feature requests, but rather questions on how to use SQLite. Please use the appropriate forum so it's easier to sort through issues here that are actual bugs.

@stephencelis Okay I will do. Here is the post: http://stackoverflow.com/questions/29677248/cannot-find-an-overload-for-contains-that-accepts-an-argument-list-of-type
Sorry for interrupting you. This lib is still too small to get an answer on StackoverFlow there are only 10 Questions under the tag. I posted two but get no answer.

@confile I monitor Stack Overflow and answer there when I can.

@confile I also only see one question from you, not two. Are you sure you posted the other one?

@stephencelis Thanks for answering my first question. You very right.
Here is the link to the second one. http://stackoverflow.com/questions/29678874/use-nsarray-in-sqlite-statement
I appreciate your help.


install problems on raspberry PI

I'm trying to install frontail on a raspberry PI model 3 with raspbian lite
it did not have NPM installed.
so I installed nodejs (9)
 curl -sL https://deb.nodesource.com/setup_9.x | sudo -E bash -
sudo apt-get install -y nodejs

that worked fine
I ran NPM after that and it told me how to use it (normal behavior)
then I ran sudo npm i frontail -g
that did not work: this is what I got
pi@frontail:~ $ sudo npm i frontail -g
npm WARN deprecated<EMAIL_ADDRESS>connect 2.x series is deprecated
npm ERR! code 128
npm ERR! Command failed: /usr/bin/git clone --depth=1 -q -b master git://github.com/zipang/daemon.node.git /root/.npm/_cacache/tmp/git-clone-26f673d4
npm ERR! fatal: could not create leading directories of '/root/.npm/_cacache/tmp/git-clone-26f673d4': Toegang geweigerd
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2017-12-26T01_12_48_185Z-debug.log
pi@frontail:~ $

I can't cd to /root/npm/ as I don't have access, I guess that is part of the problem.
Any idea what I did wrong?

I was waiting on another solution, I missed that this is now closed.
Is there not another way to package this for ARM?

I have fixed my install problem
I removed everything from node / Npm
and then
curl -sL https://deb.nodesource.com/setup_9.x | sudo -E bash -
apt-get install nodejssudo npm i frontail -g


added option to disable click battery for caffeinate

Thanks! I simply renamed the option on settings & I modified the way the onClick prop was given to the DataWidget component in order to prevent the hover effect when the click behaviour is disabled.


Implement InputPin from embedded-hal

Quick implementation of the embedded-hal InputPin trait so that avr-hal can be used with bitbang-hal for a software-serial like experience.
(I'm not actually sure how to implement a timer, though, so I haven't gotten anything working. I'm also not sure where to begin.)

(I'm not actually sure how to implement a timer, though, so I haven't gotten anything working. I'm also not sure where to begin.)

Yeah, that's a bigger task... In the meantime, maybe the Delay type is sufficient for your needs?

No unfortunately, bitbang_hal consumes a Timer object specifically, and it looks like Delay is a busy-loop, not timer based, which means I can't just steal it.
I have a scaffold type compiling, and I have some resources on timers that I'm struggling through, so hopefully a PR with a Timer will follow soon (but it won't be very good and may have to be implemented chip specific).


[Screen Reader-Home Page-Navigation]Name Property is not defined for the Video Play button for videos showing under Get inspired section.

User Experience:
If any control have incorrect role defined then the person with visual related disability will find it difficult to interpret the proper fields information. This will hinder him to access all the controls of the page efficiently and also not compatible with AT.
Test Environment
OS: RS2 Version 1703(OS Build 15063.483)
Platform: Edge.
Prerequisites: Turn on Narrator
Repro Steps

Navigate to https://makecode.com/
Navigate through all controls (say computing education, about Microsoft makecode, get inspired, resources elements etc)lying on the page
Navigate to Video showing under Get Inspired section.
4-Verify, If Name property is defined for the video play button or not.

Actual Result
Name Property is not defined for the Video Paly button for videos showing under Get inspired section.
Expected Result
Name Property should be defined for the Video Paly button for videos showing under Get inspired section.
MAS Reference
https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={248054a6-5e68-4771-9e1e-242fb5025730}
Suggested fix
Using ARIA role to expose the control type of user interface component
e.g.
< div role="toolbar" tabindex="0" id="customToolbar" >
< img src="img/btn1.gif" role="button" tabindex="-1" alt="Home" id="b1" title="Home" >
Please Refer attachment for more details

Please refer the attachment:

MAS4.1.2_HomePage_Navigation.zip

This is part of the YouTube embed feature and we cannot make any change to it.

Needs to be forwarded to YouTube.

External youtube bug


Add google analytics

We have no way of telling if anyone is actually using this

true, but i think there are other ways to view usage without resorting to google analytics.  i left out google analytics bc it seems intrusive...is it just me?

closed by #9


refactor: rename ReplaceCardinalitiesRequestV2, remove old code, simplify and extract methods in OntologyResponder

Pull Request Checklist
Task Description/Number

Issue Number: DEV-1563

rename ReplaceCardinalitiesRequestV2
remove unused code
simplify existing code
Introduce OntologyLegacyRepo as a wrapper around the cache
extract methods from OntologyResponder.replaceClassCardinalities(ReplaceCardinalitiesRequestV2) separating  the individual concerns: checking preconditions, assembling the new model and persisting.

Basic Requirements
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix: represents bug fixes
[x] Refactor: represents production code refactoring
[ ] Feature: represents a new feature
[ ] Documentation: documentation changes (no production code change)
[ ] Chore: maintenance tasks (no production code change)
[ ] Style: styles updates (no production code change)
[ ] Test: all about tests: adding, refactoring tests (no production code change)
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does this PR change client-test-data?

[ ] Yes (don't forget to update the JS-LIB team about the change)
[x] No

PR name could be simplified, for example refactor: ReplaceCardinalitiesRequestV2 refactor - all the info you've placed in the description anyway.

The PR title will become the first line of the squashed merge commit, so I would like to keep as it is rather descriptive.


[NEW ICON] Windows Server

Skill Name
Windows Server
Why?
Mentioned in #50
Windows Server is commonly used today, and is a skill that relates to servers.
People should be able to show that they have knowledge with Windows Server and/or formal training with Windows Server.
Reference Image
No response

it takes skill to tolerate using Window Server and not switching to Linux :^)

This one isn't really a skill, probably not going to add


Updated track selection for exoplayer

This request was created in connection with the issue  #3312

fixed trackId for video tracks
fixed video tracks selection by index and resolution
fixed audio tracks selection by language and index
removed track selection by title (title is not unique track property)
audio/text tracks title is based on label now (contains the human-readable text)

Video audio/video tracks selection is possible only supported formats now.
Selecting video by resolution takes into account multiple formats with exact height to support (saving ads)
Selecting video by index is possible only first group (as the most common case)
Selecting a audio/text track by title has been removed, since track titles may not be unique and in the case of several groups of tracks do not allow the correct selection.
Titles of Audio/text tracks are set based on format.label (the human-readable text).

Thanks @gizomo, it looks good 👍 Could you update trackId type in docs and events.ts, please?

Done

Does this track selection already work on iOS?

Does this track selection already work on iOS?
No, it doesn't. I haven't worked on this yet

@freeboub @gizomo
I think we can close this PR
(This PR was replaced by PR #3778 and merged)


[3pt]  - Create feature: add  new like - Abbas

When the user clicks on the Like button of an item (on Homepage), the interaction is recorded in the Involvement API and the screen is updated.

https://github.com/Log-benjamin/Microverse-Javascript-Capstone/pull/51


FontAwesome 5 Pro

As the FA5 release date rapidly approaches (30 June, last I looked), I am going to be interested in incorporating my pro license into some of my apps.  However, I know that we cannot just give away FA5 Pro Icons.
The only solution I see is for me to generate my own version of MA.M.IP, but I am unsure as to how to incorporate the FA5 Pro icons (or any icons, for that matter) into it.  Can a quick-guide be generated?  Or, as a separate concept, could a private repo be created that has FA5 icons incorporated, and we just control access to it? (Not sure how we can ensure access is limited to only those who have purchased the Pro pack...)
I'm also open to suggestions on any other ideas.

Just found out that Symbolicons is also doing a Pro version... which means that this issue (feature request?) should apply to that as well.
I think the only way to do it is to fork the report and incorporate what I want myself, so maybe the larger issue at hand is creating a user guide to give some insight as to how to do that. Thoughts, @punker76?
Sent from my Htc HTC6535LVW using FastHub

@punker76 can you package the script you use to parse SVG files in the next release?

For anyone who needs it, I created a Python file that generates a custom DataFactory for PackIconFontAwesome.  I didn't include any error handling because I am lazy, and values are hard-coded (you'll need to swap in the location of your FontAwesome folder).
Also, the script assumes that the directory follows the structure that FontAwesome ships in - specifically that there is one master directory (e.g. svgs) with sub directories for the various icon types (brands, regular, etc.).
Finally, I specifically created this with FontAwesome icons in mind, but it can be easily adapted for other icon types.
The file can be found at this gist - hope it helps!

I realized that I forgot PackIconFontAwesomeKind...
... I'm reworking the script to operate off the the icons.json metadata file to accomplish the full spectrum.  Everyone ignore the above comment lol.
@punker76, this definitely isn't closed yet.

New update...
Got both files to generate correctly, but now there is an issue with the number of items in a single class.  I'll be working to break out the PackIconFontAwesomeKind into several types this evening:

PackIconFontAwesomeBrandsKind
PackIconFontAwesomeLightKind
PackIconFontAwesomeRegularKind
PackIconFontAwesomeSolidKind

I may also tackle DuoTone at a later date, but I have no pressing requirement for it.  Updates I make to my script can be tracked via the gist link I posted above.

Gist is updated with the latest version.  A few caveats:

Some names changed, as each icon type is now its own kind.  Items like DrawPolygonSolid are now PackIconFontAwesomeSolid.DrawPolygon.  Obviously, this is breaking
There are a ton of other refactors that have to be done to make this work.  Basically, search for PackIconFontAwesome everywhere and replace it with PackIconFontAwesome[Type].  Same goes for PackIconFontAwesomeKind => PackAwesomeFontAwesome[Type]Kind
Because of limitations in C#, you cannot build all of the Types at once.  The next step (on my end) would be to create separate projects for each Type.  Right now, I really only need light, so this is not a pressing matter for me

@punker76, if I were to create a PR that breaks the FA icon pack into multiple types (brands, light, regular, and solid) for the official release, how much traction would that get on your end?  It would make life easier for others who want to ingest the full Pro version in their own repos, and it would allow for better expansion of the FA icon pack as it continues to grow down the line.


[Cody] remove cody-pro feature flag dependency

Similar to: https://github.com/sourcegraph/sourcegraph/pull/59660
Remove dependency on cody-pro feature flag which was added during Dec GA release. Things are now stable and it is a good time to cleanup.
Test plan

Connect to a local sourcegraph instance
Visit /site-admin/feature-flags and remove the cody-pro feature flag.
Visit /cody/manage and make sure you are on a free plan.
Check in IDE that Upgrade buttons are showing up.

thanks @thenamankumar for helping us cleanup!
@abeatrix @DanTup could you help review this?


pick how to do css

think im happy with current set-up. just need to tidy somethings into components


Is there any way that I can place multiple camera like Tesla autopilots 8 camera setup ??

I want to add multiple camera and place at exact location like the figure given below .

how can I place at exact location and evaluate if it is placed correctly or not. Any drag and drop feature might have been better

If you are using the carla ROS bridge have a look at the file https://github.com/carla-simulator/ros-bridge/blob/master/carla_ego_vehicle/config/sensors.json.
For example there is one RGB camera:
"type": "sensor.camera.rgb",
"id": "front",
"x": 2.0, "y": 0.0, "z": 2.0, "roll": 0.0, "pitch": 0.0, "yaw": 0.0,

If you have your desired sensor locations then it's easy to add multiple cameras.
You could use the ROS tf tree to validate the positions.


Feature/pure proxy factory

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 17 (58.82%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-15.2%) to 48.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/ERC3652PureProxyFactory.sol
6
8
75.0%

contracts/ERC3652Factory.sol
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-15.2%

Covered Lines:
10

Relevant Lines:
17

💛  - Coveralls


introduce iohelper; extract common io function out of serialize

serialize.readFull -> iohelper.ReadAll(io.Reader, buf []byte)

along with a buddy: iohelper.ReadAtAll(io.ReaderAt, offset int64, buf []byte)

and:

iohelper.WriteAll(io.Writer, buf []byte)
iohelper.WriteAtAll(io.WriterAt, offset int64, buf []byte)

Other helper function:
Convert a ReaderAt object to a wrapped Reader object,
to simplify Marshal and MarshalAt implementations.
The returned Reader object should maintains offset itself.
Obviously this Reader does not support concurrent read.
iohelper.NewAtReader(r io.ReaderAt, offset int64) io.Reader
iohelper.NewAtWriter(w io.WriterAt, offset int64) io.Writer

发现io包里有现成的...不需要NewAtReader了.


All unit tests fail?

Using up-level cmake:
%cmake3 --version
cmake3 version 3.6.3
Using up-level compiler (6.3.0, on the list)
%c++ --version
c++ (GCC) 6.3.0
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Tests built with a couple of innocuous warnings like this:
.../json/test/src/unit-serialization.cpp:71:18: warning: ‘std::ostream& nlohmann::operator>>(const
nlohmann::basic_json<>&, std::ostream&)’ is deprecated [-Wdeprecated-declarations]
But all tests fail: "0% tests passed, 70 tests failed out of 70"
Any idea what may be happening?

We compile and execute the test suite without problems using GCC 6.3.0 on Ubuntu, see https://travis-ci.org/nlohmann/json/jobs/287422140.
Did you run the tests like this?
$ mkdir build
$ cd build
$ cmake ..
$ cmake --build .
$ ctest

Yes, I ran them exactly as directed on the page https://github.com/nlohmann/json#projects-using-json-for-modern-c, except that I am working on CentOS 7 (1611) not Ubuntu.
I just looked:
%ctest --version
ctest version <IP_ADDRESS>
By chance is there a ctest version requirement that I may not be meeting?
[https://avatars3.githubusercontent.com/u/159488?v=4&s=400]https://github.com/nlohmann/json#projects-using-json-for-modern-c
GitHub - nlohmann/json: JSON for Modern C++https://github.com/nlohmann/json#projects-using-json-for-modern-c
github.com
to the files you want to use JSON objects. That's it. Do not forget to set the necessary switches to enable C++11 (e.g., -std=c++11 for GCC and Clang).
Thanks,
-don-

From: Niels Lohmann<EMAIL_ADDRESS>Sent: Monday, October 16, 2017 10:41:07 AM
To: nlohmann/json
Cc: Don Doerner; Author
Subject: Re: [nlohmann/json] All unit tests fail? (#787)
We compile and execute the test suite without problems using GCC 6.3.0 on Ubuntu, see https://travis-ci.org/nlohmann/json/jobs/287422140https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fnlohmann%2Fjson%2Fjobs%2F287422140&data=02|01|don.doerner%40quantum.com|6db5d1e5c7f04a363a9308d514bd159a|322a135f14fb4d72aede122272134ae0|1|0|636437724702033883&sdata=cIwnVXAsVZvqLw1ZR%2F4W%2F53zKAGnGt7CQPE1nbUEpL8%3D&reserved=0.
Did you run the tests like this?
$ mkdir build
$ cd build
$ cmake ..
$ cmake --build .
$ ctest
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnlohmann%2Fjson%2Fissues%2F787%23issuecomment-336965230&data=02|01|don.doerner%40quantum.com|6db5d1e5c7f04a363a9308d514bd159a|322a135f14fb4d72aede122272134ae0|1|0|636437724702033883&sdata=5IsPE5gcYbE%2FJp8JBdo8Pc5DaUAvn88c2WWX9sewSog%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPcb3vsZ9qBWQUEkzwK0FVpX8wMf9URiks5ss5UzgaJpZM4P6-KU&data=02|01|don.doerner%40quantum.com|6db5d1e5c7f04a363a9308d514bd159a|322a135f14fb4d72aede122272134ae0|1|0|636437724702033883&sdata=eX2iKWdwMeow292Mjy28XZ%2FaqEMXtB%2FZb9hiEc7ze1Y%3D&reserved=0.
The information contained in this transmission may be confidential. Any disclosure, copying, or further distribution of confidential information is not permitted unless such privilege is explicitly granted in writing by Quantum. Quantum reserves the right to have electronic communications, including email and attachments, sent across its networks filtered through security software programs and retain such messages in order to comply with applicable data security and retention requirements. Quantum is not responsible for the proper and complete transmission of the substance of this communication or for any delay in its receipt.

I am using ctest version 3.9.4. To be sure, can you provide some log files from the failing tests? It's hard to tell right now.

Found it, my mistake, please close the issue.
FYI, the problem was that when I updated my compiler, I didn't point at the right libraries.
Thanks,
-don-

From: Niels Lohmann<EMAIL_ADDRESS>Sent: Monday, October 16, 2017 11:05:01 AM
To: nlohmann/json
Cc: Don Doerner; Author
Subject: Re: [nlohmann/json] All unit tests fail? (#787)
I am using ctest version 3.9.4. To be sure, can you provide some log files from the failing tests? It's hard to tell right now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnlohmann%2Fjson%2Fissues%2F787%23issuecomment-336975298&data=02|01|don.doerner%40quantum.com|a9fd8c3364ab40c48afe08d514c06c1f|322a135f14fb4d72aede122272134ae0|1|0|636437739038641460&sdata=tnx5Sf0B9UMVAQyfFARAaxPDbEM4cAPsvJE0PbJVpdM%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPcb3lmy7ZygwmXJnnkRPpEHSaauGqXlks5ss5rNgaJpZM4P6-KU&data=02|01|don.doerner%40quantum.com|a9fd8c3364ab40c48afe08d514c06c1f|322a135f14fb4d72aede122272134ae0|1|0|636437739038641460&sdata=GwzTea%2FHz5EfaJ%2FmUBHhL84pmoHnO%2B2g1d975ZoIIaY%3D&reserved=0.
The information contained in this transmission may be confidential. Any disclosure, copying, or further distribution of confidential information is not permitted unless such privilege is explicitly granted in writing by Quantum. Quantum reserves the right to have electronic communications, including email and attachments, sent across its networks filtered through security software programs and retain such messages in order to comply with applicable data security and retention requirements. Quantum is not responsible for the proper and complete transmission of the substance of this communication or for any delay in its receipt.


Add a Toggle b/w light and Dark mode

@V2dha @ssurbhi560 if you folks can work on this?
I am trying but facing some issues keeping in mind the deadline so just wanted to let you all know the progress.

I am taking this up!


Set SECRET_KEY_BASE length to 64 bytes

The doc mistakenly mentions the length of SECRET_KEY_BASE as 32 byte long. It should 64 byte long.

Thanks, @mdminhazulhaque ! Much appreciated


Update will throw exception for null id

#4617
Description
Throwing an exception when null is provided instead of id to update.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

If this is put in place, how would you be able to perform a global update across all rows? It's rare, but is something that's needed occasionally.

If this is put in place, how would you be able to perform a global update across all rows? It's rare, but is something that's needed occasionally.

I agree but if someone use a variable with a null value by mistake or forget to add id can mess up the whole table. I think we should be more defensive in this way.
If someone wants to update all rows they can pass put a condition like id > 0

I could imagibe some type of placeholder for triggering updated on all rows, e.g., "*". However, whatever placeholder would be chosen could as well be a valid database value for the 'where' clause.
I do not really see any option here without BC break right now.

How about a configuration option at the driver level? So if a developer knows she doesn't want sweeping updates and wants to activate that safeguard.

How about a configuration option at the driver level? So if a developer knows she doesn't want sweeping updates and wants to activate that safeguard.
This is not a solution, it is a crutch.

When done too convenient or versatile, it leads to stepping on a rake in some cases.
The behavior of the method when passed as a null ID is understandable. If the programmer does not check the value and then complains that it does not work as he expects, then this is not a problem of the framework, but of the programmer.

I agree with @iRedds here. Retrofitting the framework to what is expected by the programmer when it is otherwise is a bad idea. The method has been functioning that way since the first pre-release I believe and changing the behavior to what is "expected" appears to me as a complicit act to cover up for a programmer's lack of prudence in checking his own code.

What about delete? If we pass null or empty string it throws an exception Deletes are not allowed unless they contain a "where" or "like" clause..
Then it should delete all the rows to make it consistent?

We have tests in place that suggests global updates are allowed when passing a null id. This means this behavior is quite intended.

The method signature of Model::update is https://github.com/codeigniter4/CodeIgniter4/blob/8b2e7c29043977fac378c37690cc951a715c2bd5/system/Model.php#L686. As you can see, the first parameter id is nullable. The second parameter is the data itself to be updated.

If $params is the data to be updated, passing $model->update($params) is different from $model->update(null, $params). Why? In $model->update($params) you are not passing $params as your data BUT as your ID instead.
You cannot reach the second parameter without supplying something in the first parameter (well unless you are using PHP8 you can use named arguments like $model->update(data: $params)). If you really want to supply only the second parameter, then you have no choice but to write $model->update(null, $params). This is how PHP7 and below works.
If you'll dive into the code, it is clear that it allows global updates by checking for non-empty ID. If a non-empty ID is supplied, a WHERE clause is added to the query. So passing an empty ID intentionally or not, the framework will assume you want a global update because it is designed to do such.
If you do not want the framework's default behavior, then you should yourself add the necessary safeguards in your code.
if (! empty($id))
{
    $model->update($id, $params);
}

We have tests in place that suggests global updates are allowed when passing a null id. This means this behavior is quite intended.
The method signature of Model::update is https://github.com/codeigniter4/CodeIgniter4/blob/8b2e7c29043977fac378c37690cc951a715c2bd5/system/Model.php#L686
. As you can see, the first parameter id is nullable. The second parameter is the data itself to be updated.

If $params is the data to be updated, passing $model->update($params) is different from $model->update(null, $params). Why? In $model->update($params) you are not passing $params as your data BUT as your ID instead.
You cannot reach the second parameter without supplying something in the first parameter (well unless you are using PHP8 you can use named arguments like $model->update(data: $params)). If you really want to supply only the second parameter, then you have no choice but to write $model->update(null, $params). This is how PHP7 and below works.
If you'll dive into the code, it is clear that it allows global updates by checking for non-empty ID. If a non-empty ID is supplied, a WHERE clause is added to the query. So passing an empty ID intentionally or not, the framework will assume you want a global update because it is designed to do such.
If you do not want the framework's default behavior, then you should yourself add the necessary safeguards in your code.
if (! empty($id))
{
    $model->update($id, $params);
}

@paulbalandan this points totally makes sense. Thank you so much for such detailed answer.
I will close the PR :)


Update Gazelle extension to resolve to products

The current implementation attempts to pull in the targets by the modules that they provide. This is not sufficient for some packages. Some packages with clang and objc targets use the targets as shorthand for including headers and other definitions (e.g. the Firebase target in the firebase-ios-sdk) in other targets. This leads to targets that define a Swift module but may not be complete for compilation.
This situation leads to another problem. The list of modules available in a product cannot be determined by looking at the targets directly associated with the product. Luckily, SPM does provide product membership information for each target in its description JSON. Hence the modules provided by a product are the list of targets/modules that have a membership in the product.
To resolve dependencies when generating Swift rules from source files, we need to do the following:

Identify the modules used in the source files.
For each module, try to resolve the module to an internal target. If one is not found add it to a list of modules for external resolution.
For the list of external modules, identify the products that provide the modules. (Restrict the lookup to products provided by direct dependencies) The list of products then needs to be reduced to the smallest subset that will satisfy the list.
Generate the list of Bazel labels using the products. (Important part!)

Tasks

[x] Add product_memberships to swiftpkg.Target.
[x] Write the product memberships to the module index.
[x] When reading in the dependency index (includes products and modules), need to add lookup of module name to product.
[x] Add function to dependency index to perform the resolution discussed above.
[ ] #199

Accidentally closed.

Decided to track the Starlark work in a separate issue.


Feature/add functions

I have added functions for the following Control Sequence Introducers:

ESC [ <n> A Cursor Up
ESC [ <n> B Cursor Down
ESC [ <n> C Cursor Forward
ESC [ <n> D Cursor Back
ESC [ <n> E Cursor Next Line
ESC [ <n> F Cursor Previous Line
ESC [ <n> G Cursor Horizontal Absolute
ESC [ <n> d Cursor Vertical Absolute
ESC [ 75 m Select Graphic Rendition: Neither superscript nor subscript

Thanks For You Pull Request 😃

Thank you for your work on this repository! It is a very useful library and
I'm glad you shared it!
On Nov 21, 2021 7:10 PM, "Sri lakshmi kanthan P" @.***>
wrote:
Thanks For You Pull Request 😃
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/srilakshmikanthanp/ANSI/pull/2#issuecomment-974983507,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMY5FHX7IE33YX5AHH5LD73UNGKAXANCNFSM5IKVXJVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[GWS][modify] gws/readable_setting: select range options

Coverage increased (+4.9%) to 79.721% when pulling bdcc43ce1f5462cbaf55ab7390baac7657230b67 on tany:gws-permission into bebdb428b823d0b32f3eb101ce3904c21f52b6db on shirasagi:dev/gws.

Coverage increased (+4.9%) to 79.72% when pulling 72c46667955149d6d285cecd8dc6e55d0f6d837e on tany:gws-permission into bebdb428b823d0b32f3eb101ce3904c21f52b6db on shirasagi:dev/gws.

Coverage increased (+5.1%) to 79.954% when pulling 0e87ca18484525f849a0c8f70b4894e0c045364b on tany:gws-permission into bebdb428b823d0b32f3eb101ce3904c21f52b6db on shirasagi:dev/gws.

Coverage increased (+4.9%) to 79.741% when pulling 0e87ca18484525f849a0c8f70b4894e0c045364b on tany:gws-permission into bebdb428b823d0b32f3eb101ce3904c21f52b6db on shirasagi:dev/gws.


chore (Data.Multiset.Basic): avoid bundled ordered algebra for basic results on multisets

Data.Multiset.Basic is a fairly low-level file. Currently, it imports Algebra.Order.Monoid.Defs to establish that multisets on a type are an StrictOrderedAddCancelCommMonoid and uses that classes API in a dozen places. Unfortunately, this also adds, to this file and all that import it, the projections from the ordered monoids defined in Algebra.Order.Monoid.Defs as instances for Lean to try when synthesizing a CommMonoid impacting performance. This PR moves the ordered monoid instances to a new file Data.Multiset.OrderedMonoid and makes minor changes to Basic to avoid this import.

[x] depends on: #14531

!bench

!bench

The unfortunate side effect to postponing imports of bundled algebra classes is that their priority effectively increases in files they still exist resulting in this issue

!bench

The diff was a bit hard to parse, but with the help of the declarations and imports diffs, it was much easier. Thanks!
bors d+

bors merge

bors r-

sorry, I saw you updated the PR and because the page didn't reload it told me the checks were still passing.

bors merge


[tech design] RMDX

Feature technical design
RMDX (Remote MDX)
Summary
This feature describes the usage of remote mdx in a secure way that is not vulnerable to code injection and arbitrary code execution (ACE) attacks. This will supersede existing MDX processing and provide stricter parsing and rendering. This means less overall customization, but a significantly more secure implementation.
RMDX will be used in two places:

A microservice (called rmdx-processing) which can translate source MDX into a sanitized abstract syntax tree (AST), similar to that which would be retrieved from a CMS API such as Contentful.
A set of utility React components and functions that can be used to render a sanitized AST as a set of react components.

The set of components rendered via the RMDX utilities is not defined as part of this tech design, and is instead expected to be provided as a "map" to the utility (additional details below). Having the interface act as a mapping will allow any arbitrary set of components to be used during translation.
The goal is to have the RMDX utilities generate an AST that is as close to the Contentful data model as possible. This will make migration between the two as easy as possible.
The maximum input size of MDX will be 1 MB. Output size may end up larger than this, but will remain under the RabbitMQ message threshold of 128 MB.
Research

[x] Approved?

https://app.mural.co/t/ibm14/m/ibm14/1667230506318/3c007d2b56bfc0b1c820e15d7d946285da5ae4a2?sender=jdharvey8136
https://github.com/contentful/rich-text/tree/master/packages/rich-text-types
#1073
Unanswered questions
None
New technologies
None
Proofs of concept

[x] Go from mdx -> mdast -> JSON -> react components

This works as expected (see mural for details)

UI/UX design

[x] Approved?

None
APIs

[x] Approved?

Programmatic APIs
New package: rmdx
This will export the utilities for converting to and working with the MDX-based AST.
process(srcMdx: string): AST - Returns an RMDX AST given an input string
<RmdxNode components={...} ast={...} /> - React component which takes an RMDX AST as input along with a components map, which maps AST node types to React components for rendering. The mapped components are given children to render as well as any relevant scalar props from the source MDX.
Data graph
There will eventually be an rmdx resolver for asset doc pages, however since there is not yet an asset resolver, this will probably be deferred until later.
Messages
query: rmdx A request/response based message to get a processed RMDX result, given an input string of raw MDX source
// query message
interface RmdxMessage {
  srcMdx: string // Max size = 1 MB
}

interface RmdxResponse {
  ast: Node<Data> // Either a unist tree or a custom AST similar to Contentful's model
  errors: Array<?> // List of errors encountered during processing
}

Future: Should eventually respond to an asset_discovered message by pre-caching processed RMDX in an LRU cache.
Security

[x] Approved?

MDX things that will not work under RMDX:

Inline JSX blocks (outside of components)
Imports/exports/variable assignments
Properties on JSX elements which are not a number, boolean, or string (i.e. no functions, arrays, or objects)

Error handling

[x] Approved?

Error handling should have feature parity with existing mdx processing.
TODO: Need to figure out the best approach for transmitting errors back to the caller. Tentative approach: Errors in the returned list of errors are numbered, and there are AST nodes in the returned RMDX which call out particular error numbers (and types), so knowing what to render is accomplished via a "lookup map".
example:
{
  "ast": [
    {
      "nodeType": "h1",
      "value": "this is a header"
    },
    {
      "nodeType": "Error",
      "errorIndex": 0
    }
  ],
  "errors": [
    {
      "exception": "ImportFoundException",
      "line": 123,
      "text": "import thing from 'thing'"
    }
  ]
}

const error = theErrorrmdx.errors[0]
Test strategy

[x] Approved?

How will the new feature be tested? (e.g. unit tests, manual verification, automated e2e testing,
etc.) What interesting edge cases should be considered and tested?

76+% unit test coverage of all new code.
Test existing known MDX exploits to ensure they can't be performed against RMDX
Logging

[x] Approved?

Log incoming requests to process MDX

Log processing failures

Warn log when encountering portions of MDX that need to be removed for security reasons

File and code layout

[x] Approved?

Rough file layout:

packages

api

rmdx-processing

RmdxMessage
RmdxResponse
query_rmdx

rmdx

process
RmdxNode

services

rmdx-processing

rmdx-controller
rmdx-service

Issue and work breakdown

[x] Approved?

Epics

#1491

Issues

#1492
#1493
#1494
#1495
#1496

Reviewed by @francinelucca and @andreancardona. Marking as complete.


feat: support --experimental-public in local mode

--experimental-public is an abstraction over Workers Sites, and we can leverage miniflare's inbuilt support for Sites to serve assets in local mode.

The test failure on windows is odd, it appears to be stripping out \, I'll debug this later

This needs some work done on it for tests to pass since https://github.com/cloudflare/wrangler2/pull/1241 landed (tho it'll still "work" otherwise.) Moving to wip.


EditorConfig does not report any file inconsistencies based on the configuration file

First of all thank you for your work.
I have two doubts, I still don't know if they are problems with the package or if it depends on my incorrect use.

If I create an .editorconfig file inside a project folder with files it already exists I know that changing the settings of the file these do not apply to existing files. But by opening these files should the system not at least notify me if there are inconsistencies with the .editorconfig file?
The second doubt is the following. I created an .editorconfig file, placed it inside a project folder, did some tests and I deleted the folder. Then I created a new folder and launched the "EditorConfig: Generate Config" command but the message "An .editorconfig file already exists in your project root." appears. Why does this error appear if I previously deleted the folder that contained it?

Thanks in advance for the help.
 Open Settings → Core and look for a field that looks like this:

The issue you're describing sounds like it might be an issue with Atom's ability to dispatch or respond to filesystem events (such as deleting or creating a file). Creating a new .editorconfig file should be all it takes to get the authored settings applied to project files. That is, this shouldn't be happening:

I know that changing the settings of the file these do not apply to existing files. But by opening these files should the system not at least notify me if there are inconsistencies with the .editorconfig file?

Hello
I have same/similar issue with an existing project
this is my editorconfig dot file
# https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties
root = true

[*]
indent_style = space
indent_size = 4
tab_width = 4
trim_trailing_whitespace = true
end_of_line = lf
charset = utf-8
insert_final_newline = true

[*.css]
block_comment_start = /*
block_comment = *
block_comment_end = */

[*.styl]
block_comment_start = //
max_line_length = 80

[*.md]
trim_trailing_whitespace = false
block_comment_start = <!--
block_comment_end = -->

If I change
indent_size = 2
tab_width = 2

And rerun editor config fix file or via eclint nothing happens and editor config happily reports nothing changed.

OS is Windows 10 2004 pro workstation
Atom 1.58.0  64 bit
Atom is using Native Operating system APi's se in core.

@Alhadis thoughts? on this. Im trying to avoid to create a whole new project to workaround this.

Closing as Atom is abandoned.


Extract validateAddress into XChainClient interface

Add validateAddress(address: Address): boolean to `XChainClient
Remove validateAddress from BitcoinClient, BinanceClient, CosmosClient, ThorchainClient
Implement validateAddress to asgardex-polkadot

Resolved by #149


Check in HMOS code changes

Please review the code

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


On logout redirect doesn't respect baseURL

According to README https://github.com/simplabs/ember-simple-auth#configuration baseURL can be set via config.
In the initializer, however, it is never respected if a rootURL is present. https://github.com/simplabs/ember-simple-auth/blob/master/app/initializers/ember-simple-auth.js#L11
Should this be removed from README if it's not to be used?

Yes, actually the whole "Configuration" section should be dropped. A PR would be awesome!

OK, done that.
Any tip for having a different 'redirect' URL that rootURL ?  My initial thought is to just override the initializer, but that worries me for future updates.

I think the base way to support that would be to introduce a new baseURL property on the ApplicationRouteMixin that defaults to Configuration.baseURL (similar to AuthenticatedRouteMixin's authenticationRoute property).
Alternatively you can just override the ApplicationRouteMixin's sessionInvalidated method.


build: fix app name in mix.exs

:tada: This PR is included in version 1.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[bug] $Diff type not treated as object in object spread

Not only that this doesnt work, but also a reported error is quite vague
Simpler reproduced case - thanks to @asolove
Original problematic (simplified) code

So, I don't know why that doesn't work. It seems to me like it should.
But, you can actually make your life easier and just let Flow figure out the argument type itself instead of explicitly defining the $Diff type that sendMessage needs to receive.

@asolove thanks for the answer, this is gonna be a public API of the SDK library, so I would prefer keeping this explicit, even if only for documentation purposes.
Still learning Flow, but in general I find myself wanting to type only types of input output of my public API and let flow figure out all in the middle. I find type casting like this in the middle of the function ugly ;p

Just FYI, though I added the type to parsed, that isn't actually necessary for this to work. I tried removing it, and the * still works fine. The other option, if you want to be explicit for documentation purposes, is to not use $Diff but instead just manually list out the object type that's required to be passed in, which I think is just {text: string}. That's probably more helpful for someone reading the API docs than sorting through what $Diff does.
Either way, I think we can close this issue.

The other option, if you want to be explicit for documentation purposes, is to not use $Diff but instead just manually list out the object type that's required to be passed in, which I think is just {text: string}.

Actually the code example I gave is overly simplified. I've tried to keep it minimal for clarity and brevity.

That's probably more helpful for someone reading the API docs than sorting through what $Diff does.

This is not much of a problem to me. At least yet. Those types wont be public for some time, documenting for our developers (which should know what $Diff does) is enough.

Either way, I think we can close this issue.
Quoting urself - "So, I don't know why that doesn't work. It seems to me like it should.". I think this this indicates that there might be some bug involved here, wouldnt close this prematurely until official confirmation why this is happening.

Oh, good point, thanks for reminding me!
To leave it open for that bug, it might help to make the title/description more specific for Flow maintainers combing through issues.
I rearranged a smaller reproducible example:
type A = {
  foo: number,
  bar: string
};

type B = {
  foo: number
};

let b: $Diff<A, B> = { bar: "thing" };
let a: A = {
  ...b,
  foo: 2
}

Which produces this error message:
11: let a: A = {               ^ object literal. Expected object instead of
12:   ...b,
         ^ A

And I think shows that the problem can be summarized as "$Diff type not treated as object in object spread".

fixed in flow 0.57


Colors sub menu no longer show up

I just upgraded Editorjs from 2.25.0 to 2.29.0
On 2.25.0 I have the issue where the "A" on the menu does not show up
I fixed it by changing the current css line.
#color-btn-text {\n  width: 18px;\n height: 15px;\n}\n\n #color-btn-text > svg {\n display: block; \n}\n\n
On 2.29.0 the colors submenu does not show up
I am using my PC, the latest google chrome version that updated today, and I also tried it on firefox. No errors in the console.
No matter what I select or how many times I click on the color square the submenu does not open, however the selected colors does apply to selected text.

I just upgraded Editorjs from 2.25.0 to 2.29.0 On 2.25.0 I have the issue where the "A" on the menu does not show up I fixed it by changing the current css line. #color-btn-text {\n width: 18px;\n height: 15px;\n}\n\n #color-btn-text > svg {\n display: block; \n}\n\n
On 2.29.0 the colors submenu does not show up I am using my PC, the latest google chrome version that updated today, and I also tried it on firefox. No errors in the console. No matter what I select or how many times I click on the color square the submenu does not open, however the selected colors does apply to selected text.

Same problem but the demo still works...

Hi,
just started integrating editorjs in my app.
From what I tried:
Your issue with the "A" not showing up was fixed in 2.26.0
The color submenu seems to fail in 2.29.0 indeed.
I downgraded to 2.25.0 and went all the way up to 2.29.0
The issue appeared with 2.29.0.
Works fine in 2.28.2

I downgraded to 2.28.2, no helps... Is there any other fixes?

Same problem here. No errors displayed in console. It only applies the default color, but you cannot change it...
Tested on MacOS / Chrome (latest versions)

I found the source of this problem.
The tryToShow function refactor https://github.com/codex-team/editor.js/compare/v2.28.2...v2.29.0#diff-e55ad4bb9846bb8d75e77413ab3e49c30e75f6bb8b58833d2b539cebb8186b10R141
When I tried to revert some of these changes, the problem disapeared.

I found the source of this problem.
The tryToShow function refactor<EMAIL_ADDRESS>When I tried to revert some of these changes, the problem disapeared.

And also this cod modification is needed: https://stackoverflow.com/a/70422489/1252528

The code should be reverted in editor.js is here https://github.com/codex-team/editor.js/compare/next...giiska:editor.js:patch-1

@giiska
If you believe that this is a bug in Editor.js, you need to open the issue here: https://github.com/codex-team/editor.js
Otherwise, if this is a bug of this plugin, you need to change only the code of this plugin and not the code of Editor.js.

This plugin indeed need to be improved by adding transform: scale(1); to color-section class which is described here  https://stackoverflow.com/a/70422489/1252528
For editorjs, I don't know if it is a bug yet. The changes in src/components/modules/toolbar/inline.ts maybe is intended.
Actually I was try to add a bug report there, but the bug report form was so complex... So instead I commented here to wait your response here.

@giiska
If you believe that this is a bug in Editor.js, you need to open the issue here: https://github.com/codex-team/editor.js
Otherwise, if this is a bug of this plugin, you need to change only the code of this plugin and not the code of Editor.js.

@giiska I am not a maintainer of this repo, my comment was just a suggestion. I am also hoping to see this issue fixed. I would like to use this plugin, but I am waiting due to this major bug.

This plugin indeed need to be improved by adding transform: scale(1); to color-section class which is described here https://stackoverflow.com/a/70422489/1252528

@flaming-cl Is there any change to see that small change merged to fix this issue?

As a temporary workaround, i managed to fix it by add transform: scale(1); to the .ce-inline-toolbar class.
version:
"editorjs-text-color-plugin": "1.13.1",
"@editorjs/editorjs": "^2.28.2"

I'm using 2.30, how do I fix this? I added a comment and found that clicking on the button reconstructs the component, and clicking on other inline components reinstantiates it. Is it restructured so that pop doesn't show up? Is there a solution?

我用的editor.js版本为最新版2.30.xx。我将源码的show方法阻止事件冒泡后可以解决组件被重构的问题，但是组件的位置不正确，需要重新设置组件的位置，父元素popover设置position:relative, 子元素popcon元素设置position:absolute;top:35px;left:220px; 这样组件就能正常显示了。具体问题原因还没有深究。

This plugin indeed need to be improved by adding transform: scale(1); to color-section class which is described here https://stackoverflow.com/a/70422489/1252528
For editorjs, I don't know if it is a bug yet. The changes in src/components/modules/toolbar/inline.ts maybe is intended.
Actually I was try to add a bug report there, but the bug report form was so complex... So instead I commented here to wait your response here.

@giiska
If you believe that this is a bug in Editor.js, you need to open the issue here: https://github.com/codex-team/editor.js
Otherwise, if this is a bug of this plugin, you need to change only the code of this plugin and not the code of Editor.js.

It's not a bug of the editorjs.
I think it maybe caused by misunderstanding of fixed position in shadow dom. Acutally the fixed position inside a shadow root will still respect to viewport not the parent element.
BUT NOT ALWAYS

But, it will NOT always be relative to the document. When any element has transform, filter or perspective property, it acts as a containing block for all its descendants, including the elements whose position is set to fixed.
Reference

So, when the developer developed the popover, the editorjs's inline toolbar happens to have transform: xxx styles applied.
But the newer one just dosn't have these styles anymore. So fixed position will respect to viewport again.
Simplest soultion:
Edit these lines:
https://github.com/flaming-cl/editorjs-text-color-plugin/blob/d47a953be6f3b6e4490e380243b908c3dc423ffc/src/picker/index.js#L75
From:
        xy-popover{
            display:block;
        }
        xy-popcon{
            position: fixed;
            min-width:100%;
        }

To:
        xy-popover{
            display:block;
            position: static;
        }
        xy-popcon{
            min-width:100%;
        }

I am also facing an issue with the color picker. The color picker popup closes immediately after opening. I get the following error when selecting text or clicking the color picker.
Error Message : Uncaught TypeError: Cannot read properties of undefined (reading 'colorCollections')
Color: {
class: ColorPlugin, // if load from CDN, please try: window.ColorPlugin
config: {
colorCollections: [
"#EC7878",
"#9C27B0",
"#673AB7",
"#3F51B5",
"#0070FF",
"#03A9F4",
"#00BCD4",
"#4CAF50",
"#8BC34A",
"#CDDC39",
"#FFF",
],
defaultColor: "#FF1300",
type: "text",
customPicker: true, // add a button to allow selecting any colour
},
},
Following dependencies, I am using.
"dependencies": {
"@editorjs/header": "^2.8.7",
"@editorjs/inline-code": "^1.5.0",
"@editorjs/list": "^1.9.0",
"@editorjs/paragraph": "^2.11.6",
"@editorjs/quote": "^2.6.0",
"@editorjs/simple-image": "^1.6.0",
"@editorjs/underline": "^1.1.0",
"@react-editor-js/core": "^2.1.0",
"editorjs-text-color-plugin": "^2.0.4",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-editor-js": "^2.1.0"
},

Surprisingly when text is unselected, the color picker opens without any error

Is this solve yet? I am having a similar problem.

Hi,
just started integrating editorjs in my app. From what I tried:
Your issue with the "A" not showing up was fixed in 2.26.0 The color submenu seems to fail in 2.29.0 indeed. I downgraded to 2.25.0 and went all the way up to 2.29.0
The issue appeared with 2.29.0. Works fine in 2.28.2

Tnx

this solution works for me with the latest version
https://github.com/dariox64/editorjs-text-color-plugin

this solution works for me with the latest version  https://github.com/dariox64/editorjs-text-color-plugin

Very nice fork of the plugin. I tried it and it worked! Firee!!!

Noticed something. The color boxes escape D:

@SisuKah, please check now (first remove node_modules and -lock.json)

This still happens with me. I installed all the packages again. @dariox64

this solution works for me with the latest version  https://github.com/dariox64/editorjs-text-color-plugin

It did not work for me as bundle.umd is broken. ColorPlugin is not defined at all


Fix #254 - Remove async from showMenu()

Removes Function("r", "regeneratorRuntime = r")(runtime);
Check https://www.diffchecker.com/UJc10qT1#left-6 to see what the changes are to bundle-esm.js
Local tests all seem to work with this change.

:tada: This PR is included in version 3.5.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

So much extra code in bundle and so many problems because of such a trifle in the code that was not needed at all 😄.
Sorry for the inconvenience and thanks for the fix!

I wonder why you need "prepare": "yarn build"? How does this help?

This was an accident, we used a fork inbetween and this was the only way we could get dist files. I forgot this PR was still running and didn't create another branch :/ If you would be so kind to remove that line :)


multiple-cucumber-html-reporter doesn't report variables in dataTables from Scenarios Outline Examples #5434

There is an issue parsing variable values from Examples in Scenario Outline to the Json Reporter in data tables
See the report:

And the feature:

The execution is ok, the problem happens when parsing the variable. See the json report block:
"cells": [
                                            "<name>",
                                            "<description>",
                                            "<accountPlan>",
                                            "<API>",
                                            "<environment>",
                                            ""
                                        ],

Which is taken in the html as html nodes because the '<>; symbols
My npm dependencies:
"devDependencies": {
"@babel/cli": "7.8.4",
"@babel/core": "7.9.0",
"@babel/preset-env": "^7.9.6",
"@babel/register": "^7.7.0",
"@wdio/cucumber-framework": "6.1.13",
"@wdio/local-runner": "5.23.0",
"@wdio/spec-reporter": "5.23.0",
"@wdio/sync": "5.23.0",
"chromedriver": "^83.0.0",
"expect": "24.3.0",
"expect-webdriverio": "0.2.0",
"fs-extra": "^9.0.0",
"geckodriver": "^1.19.1",
"multiple-cucumber-html-reporter": "^1.16.2",
"wdio-chromedriver-service": "5.0.2",
"wdio-cucumberjs-json-reporter": "^2.0.0",
"wdio-geckodriver-service": "^1.0.3",
"winston": "^3.2.1",
"yargs": "^15.3.1"

@JuanRodriguezAbarca
Please file it to the correct project, see my comment https://github.com/webdriverio/webdriverio/issues/5434#issuecomment-634046879 and please provide the json file


Get error on OIDC authentication on external IP on development and docker

I enabled OIDC configuration on prod_settings_template.py and it works fine on localhost but when I run with external_host on development and docker, I get an error ERR_INVALID_REDIRECT and on docker get a 500 error. How can I fix this problem?
The below link returns an internal server error:
https://<IP_ADDRESS>/login/oidc/?subdomain=&is_signup=0&multiuse_object_key=&next=%2F
prod_settings_template.py:
AUTHENTICATION_BACKENDS: Tuple[str, ...] = (
    "zproject.backends.EmailAuthBackend",  # Email and password; just requires SMTP setup
    # "zproject.backends.GoogleAuthBackend",  # Google auth, setup below
    # "zproject.backends.GitHubAuthBackend",  # GitHub auth, setup below
    # "zproject.backends.GitLabAuthBackend",  # GitLab auth, setup below
    # "zproject.backends.AzureADAuthBackend",  # Microsoft Azure Active Directory auth, setup below
    # "zproject.backends.AppleAuthBackend",  # Apple auth, setup below
    # "zproject.backends.SAMLAuthBackend",  # SAML, setup below
    # "zproject.backends.ZulipLDAPAuthBackend",  # LDAP, setup below
    # "zproject.backends.ZulipRemoteUserBackend",  # Local SSO, setup docs on readthedocs
    "zproject.backends.GenericOpenIdConnectBackend",  # Generic OIDC integration, setup below
)

SOCIAL_AUTH_OIDC_ENABLED_IDPS: Dict[str, Any] = {
    ## This field (example: "idp_name") may appear in URLs during
    ## authentication, but is otherwise not user-visible.
    "idp_name": {
        ## The base path to the provider's OIDC API. Zulip fetches the
        ## IdP's configuration from the discovery endpoint, which will be
        ## "{oidc_url}/.well-known/openid-configuration".
        "oidc_url": "http://<IP_ADDRESS>:8080/realms/sample",
        ## The display name, used for "Log in with <display name>" buttons.
        "display_name": "Key Cloak",
        ## Optional: URL of an icon to decorate "Log in with <display name>" buttons.
        "display_icon": None,
        ## The client_id and secret provided by your OIDC IdP. To keep
        ## settings.py free of secrets, the get_secret call below
        ## reads the secret with the specified name from zulip-secrets.conf.
        "client_id": "zulip",
        # "secret": get_secret("social_auth_oidc_secret"),
        "secret": "mysecretkey",
        ## Determines whether "Log in with OIDC" will automatically
        ## register a new account if one does not already exist. By
        ## default, Zulip asks the user whether they want to create an
        ## account or try to log in again using another method.
        "auto_signup": True,
    }
}

@zulipbot claim

I believe this can be closed, based on the #production help discussion


Error: "Timeout reached while waiting for Roblox Studio to come online"

When using run-in-roblox in a windows-latest GitHub Action I get the error Timeout reached while waiting for Roblox Studio to come online. This happens 100% of the time in the action but I am not able to reproduce it locally.
I am running run-in-roblox with a .rbxl file that is 17MB in size. The following is the relevent part of my workflow YML:
- name: Install Roblox Studio
  uses<EMAIL_ADDRESS>  with:
      cookie: ${{ secrets.ROBLOSECURITY }}
      token: ${{ secrets.GITHUB_TOKEN }}
  timeout-minutes: 2

- name: Run unit tests with run-in-roblox
  run: npm test

The npm test command is run-in-roblox --place game.rbxl --script ci-scripts/unit-testing.lua.

Agh, these issues are a pain to diagnose; I'm sorry you ran into this.
In the past, the culprits of these issues were things like:

The authentication cookie used in the installation is no longer valid. Testing it independently is a good idea if you haven't already.
Something about the Roblox Studio Bootstrapper changed. Maybe it's stuck on something! Maybe they've finally changed the way that credentials are stored. 😅

Sounds like multiple people might be running into this. @jeparlefrancais or @OrbitalOwen, have either of you run into this before? Any ideas?

I'm encountering this issue as well, but flaky (unlike OP who has 100% failure).

thread '' panicked at 'called Result::unwrap() on an Err value: Timeout reached while waiting for Roblox Studio to come online', src/main.rs:75:9

Sometimes it hits this error, sometimes it doesn't. I just rerun the workflow and hope to get lucky (and use up all of my Actions minutes).

If it helps, my workflow is a bit different than most people's. I install studio, then open with a blank .lua file to finalize the installation and make Studio create directories, then edit those files to make fflag changes, then open my actual test file and script.
jobs:
  Curriculum:
    strategy:
      fail-fast: false
    runs-on: windows-latest
    timeout-minutes: 13
    steps:
      # Get dependencies
      - name: Checkout repository
        uses: actions/checkout@v1
        with:
          submodules: recursive

      - name: Studio installation
        uses<EMAIL_ADDRESS>        with:
          cookie: ${{ secrets.ROBLOSECURITY }}
          token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}

      - name: Foreman installation
        uses: rojo-rbx/setup-foreman@v1
        with:
          token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}

        # Build .rbxlx file
      - name: Build test project
        run: rojo build default.project.json -o ./tests/test.rbxlx

        # Open Studio so it finalizes installation
      - name: Open Studio to finalize installation
        run: |
          New-Item ./noop.lua
          Set-Content ./noop.lua '--noop'
          run-in-roblox --place ./tests/test.rbxlx --script ./noop.lua

        # Edit fast flags
      - name: Edit FFlags
        run: |
          $flags = Get-Content -Path C:/Users/*/AppData/Local/Roblox/ClientSettings/StudioAppSettings.json -Raw | ConvertFrom-Json
          $flags.AnyCustomFlagsHere=$true
          New-Item -Path 'C:/Program Files (x86)/Roblox/Versions/version-*/' -Name "ClientSettings" -ItemType "directory"
          New-Item -Path 'C:/Program Files (x86)/Roblox/Versions/version-*/ClientSettings' -Name "ClientAppSettings.json"
          $flags | ConvertTo-Json -depth 32| set-content -Path 'C:/Program Files (x86)/Roblox/Versions/version-*/ClientSettings/ClientAppSettings.json'

      # Run tests with run-in-roblox
      - name: Run tests
        run: run-in-roblox --place ./tests/test.rbxlx --script ./tests/Curriculum.spec.lua

I tried a .rbxl vs .rbxlx and found no difference.
I did find one thing of note- it's possible for the action to work on the first time opening studio and then fail on the second, which suggests that setup/installation is not the issue here.

After a lot more testing, I've found that this seems to be tied to StudioUseNewLoginDataEndpoint.
A temporary workaround is to disable this feature flag before calling run-in-roblox:

      # Flip flag that causes issue
      - name: Create fflag ovverrides
        run: |
          $flags = @{StudioUseNewLoginDataEndpointHundredthPercent=0; StudioUseNewLoginDataEndpoint=$false}
          New-Item -Path 'C:/Program Files (x86)/Roblox/Versions/version-*/' -Name "ClientSettings" -ItemType "directory"
          New-Item -Path 'C:/Program Files (x86)/Roblox/Versions/version-*/ClientSettings' -Name "ClientAppSettings.json"
          $flags | ConvertTo-Json -depth 32| set-content -Path 'C:/Program Files (x86)/Roblox/Versions/version-*/ClientSettings/ClientAppSettings.json'

      # Run your tests with run-in-roblox
      - name: Run tests
        run: |
          run-in-roblox --place ./tests/test.rbxl --script ./tests/TestRunner.lua

Adding the following for me has resolved the issue (for now):
- name: Add RBXID to the Windows registry
  run: REG ADD HKCU\Software\RobloxStudioBrowser\roblox.com /t REG_SZ /v .RBXID /d "${{ secrets.RBXID }}"

I have been getting consistent test passes with this step. It also does not appear flipping flags is necessary anymore.
This is something that should be included in roblox-win-installer as it already adds the ROBLOSECURITY cookie to the registry. If someone could look into making this change it would be much appreciated

What are the odds, I also got the same issue and can't reproduce it locally

(I commented out the code because it doesn't work)

@vocksel what is secrets.RBXID and how do I get it?

@vocksel what is secrets.RBXID and how do I get it?

RBXID is a cookie required for authenticating with Studio. You can find it in the same place as your ROBLOSECURITY cookie.
I haven't had good luck recently getting this workflow to work, but I'm told that flipping FFlagStudioUseNewLoginDataEndpoint to false (like you're doing) should be enough right now (In conjunction with both ROBLOSECURITY and RBXID as secrets)
But I'm not confident that this solution will last forever

@vocksel Flipping the flag worked for a while, but the most recent CI runs I've had have failed. It's not future proof, and I think the future is now.

My runs have been failing and I can't get this to work.
I realized that Roblox made a change in which cookies are invalidated with IP changes.
How would I go about logging in and getting the cookies from the workflow? I'm not too familiar with these things.

Any updates on this? I am running into the same issue

I'm running into the same issue.

Anybody got anything working on CI?

Anybody got anything working on CI?

i'm pretty sure nobody has been working on this for a while now
try looking into Cloud API for Luau Tasks
https://devforum.roblox.com/t/beta-open-cloud-engine-api-for-executing-luau/3172185


ci: add bleeding linux

Pull Request Test Coverage Report for Build 3595
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.319%

Totals

Change from base Build 3580:
0.0%

Covered Lines:
4195

Relevant Lines:
5096

💛  - Coveralls


[INF-986] Lease renew error callback

@volodymyr-mykhailyk All comments resolved, please take a look.


ARROW-11227: [Python] Fix to_pandas with ExtensionArray tests for pandas 0.24

cc @kszucs this works locally (and could also reproduce the failure first)

cc @kszucs this works locally (and could also reproduce the failure first)

The appveyor failure is handled by #9188

The appveyor failure is handled by #9188


bug: gco and gcO emit a notification of V

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.0 release
Operating system/version
MacOS 14.3
Describe the bug
When performing gco or gcO in my tmux.conf file, a noice notification popped up with the content of V. This also happens in .lua files, assuming it happens in more.
Steps To Reproduce

Have a line of text in any file
press gco/gcO

Expected Behavior
A comment line is inserted in the correct place without the notification
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/LazyVim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

I don't see that happening, so must be something in your config.

Probably casued by this https://github.com/garymjr/nvim-snippets/issues/29#issuecomment-2135725993


Please make the code compatible with the Arduino IDE

Right now this code is not useable on the Arduino IDE which has several million users..
It would make it simpler for many people to contribute and port to other hardware.

Here is the pre-compiled firmware for the 101 board, if that helps anyone...
101.zip

Arduino IDE compat tree is @ https://github.com/google/science-journal-arduino/tree/arduino-ide


Feat: Implementation of a Function to Inflict Damage with Existing Weapons (Sword and Katana)

Implementation of a Function to Inflict Damage with Existing Weapons (Sword and Katana)

Description: Implement a function that uses existing weapon structures (Sword and Katana) to calculate and apply damage to an enemy during combat. The function should accept parameters for the weapon used and the target, calculate the inflicted damage, and update the enemy's health accordingly.
Requirements:

Model: Ensure existing weapon structures have relevant attributes such as base_damage.
System: Create a function inflict_damage that accepts the selected weapon and the enemy's current health, calculates damage, and updates the health.
Tests: Develop tests to verify correct damage calculation, health reduction, and validation logic (e.g., preventing negative health values).

Objective: Provide a simple yet effective combat function to handle damage application using existing weapons, contributing to core battle mechanics.

Could I take responsibility for this task?

Hello maintainers I am BRACR10 a contributor from Dojo Coding, I would like to take this issue as a way to improve my skills in cairo and I have the idea how to implement it, previously I participated in a blockchain development module where I together with a team implemented a similar game idea on Solidity where there were different characters and features that made the percentage of damage vary, despite being another language, it  follows the same logic and can easily adapt to this case!
Repo:https://github.com/OptimisticCRTeam/on_chain_game

I would like to work on this issue

Can i work on this?

Is it okay if I tackle this?

Hi, I am a Cairo developer with great experience contributing to lots of Cairo code base. Can I work on this?

May I pick this up?

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged:
software engineering background, backend & smart contract dev with contribution to similar tasks(https://app.onlydust.com/u/Josh-121) looking to make first contribution on this project
How I plan on tackling this issue
I understand the requirement to create the required function to use the existing weapon structure ,inflict damage based on weapon damage capcity and update players health accordingly. I have good experience working on gaming tasks like this and can implement this,work on feedback & recommendation ensuring contact. Can deliver within a day upon assignment

Yes sure @BraCR10

I'd love to give this a go.


Is there a way to execute an action when all tests are done?

I'd like to call some cleanup action when all tests are finished. What is the recommended way to do this?
E.g. something like:
setup();

test("Some test", function (t) { ... t.end(); });
test("Some other test", function (t) { ... t.end(); });

test.on("end", function () { cleanup(); });

I tried on('end') and on('done') but that didn't work. It seems to work on the return value from test(), so I guess a workaround would be to wrap all tests in another test, but I'd like to avoid another level.

If you put a test() at the end it can be used for cleanup:
test('setup', function (t) { t.end() })
test('test 1', function (t) { t.end() })
test('test 2', function (t) { t.end() })
test('teardown', function (t) { t.end() })


command modifiers should accept a range

Commands now accept modifiers. However, if there is a command that accepts a modifier but also a range, because command modifiers do not accept ranges, you cannot use a range on that command.
See neovim/neovim#4449

It should not, there is v:count and :execute. I would actually expect N vertical split to vertically split N’th window, not pass count somewhere.

@ZyX-I but :split accepts a count for the window size. however, :vertical split does not, which is the problem. if you think split should take a count to split the N'th window, then you just have to redefine how :split uses the count, :vertical should still pass it to :split.

@nhooyr :vertical 2split works. :2vertical 2split should split the second window, making it have width 2.

@nhooyr And it is not a problem, just instead of relying on {count}: results construct command using :execute and v:count.

The range goes on the command, thus after the modifier.

@brammool @ZyX-I but what about a mapping, neither v:count nor :execute help there. How about a way to tell vim which command takes the count?

@nhooyr Did you actually try?
nnoremap K :<C-u>execute 'vertical' (v:count ? v:count : '') 'Man'<CR>

Ah, ok, thanks!

@ZyX-I @nhooyr thank you, the nnoremap with v:count checking is a perfect solution.

@dumblob i just realized that all you had to actually do was
nnoremap <silent> K :<C-U>vertical Man<CR>
autocmd! FileType man nnoremap <silent> <buffer> K :<C-U>vertical Man<CR>

@nhooyr :Man checks v:count itself? Guess something required to process v:count when using &manprg.


Rename client certficate context names in kubectl gs with -clientcert suffix

This is important since otherwise the contexts created via oidc vs clientcerts will conflict

[x] test cases
[x] rename context when creating
[x] make sure to take care of existing cert data entries when creating new ones https://github.com/giantswarm/giantswarm/issues/21542
[x] add context naming pattern with -clientcert suffix and handle it differently from WC context

This was merged, however it will be released along with this https://github.com/giantswarm/roadmap/issues/1161


Named elements don't seem to work

See here, which is supposed to work according to this.

It shows a value of zero, it will not update without an event, but it seems to work fine.  Also from the docs
Inline tag definitions(in document body) must be properly indented, with all custom tags equally indented at the lowest indent level, mixing of tabs and spaces is discouraged. ie. your foo can not be at the same level as your script
updated

Aha, thanks!


Don't use .values to try to modify the values.

After about 10 hours of debugging, I finally located an severe issue regarding to the use of .values when make value assignment in the built-in Processor (precisely, Fillna).
It is very dangerous to use .values to modify the data in the DataFrame. So I suggest maybe it's better to convert back to the conventional df[col] = xxx way of value assignments, and do not sacrifice safety for speed.
Code:
df.values[nan_select] = self.fill_value

Ref:
https://stackoverflow.com/questions/55709890/why-does-value-assignment-silently-fail-or-do-the-wrong-thing-and-how-can-i-stop
🐛 Bug Description

To Reproduce
Steps to reproduce the behavior:

Expected Behavior

Screenshot

Environment
Note: User could run cd scripts && python collect_info.py all under project directory to get system information
and paste them here directly.

Qlib version:
Python version:
OS (Windows, Linux, MacOS):
Commit number (optional, please provide it if you are using the dev version):

Additional Notes

OK, thanks for the heads up, I think the .values in the reference is not working because of the data type issue. I don't understand where the danger of using .values as you describe comes from?

Same issue here! The df.values is not working in the Fillna processor!! It took me hours to find this reason. After revising the __call__function, the nan values disappear.


Redundant registry update when adding a dependency to several worksapace members

I have a workspace with two packages, one of which depends on regex="*". If I add regex="*" to the second member as well, I hit a registry update on the next rebuild. It is not necessary, because the existing regex dependency of the workspace will be reused.
I think the general property we  want is:

If after an update the lock file contains the subset of the packages before the update, then we have not hit the Internet.

May or may not be relevant, but updated field of the RegistrySource is never used.

I think this is a dupe of https://github.com/rust-lang/cargo/issues/2895, so closing in favor of that. Agreed a bug though!


fix saving checkpoint

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

这样改save checkpoint的时候确实不会报错，但是多机分布式训练，使用同一个共享存储比如gpfs，两台主机的worker0进程还是会同时写入同一个目录，要怎么解决呢？可以只让world0去保存吗？


Combining two Eithers

Hello, first sorry for not using the template.
This is a question and not a feature request or bug report, I couldn't find a better place to ask this, do you have a slack channel or something like that?
Also thank you for this awesome library ❤
I needed a function to combine two Eithers, so I wrote the following one
const combine = <L, R1, R2>(a: Either<L, R1>, b: Either<L, R2>): Either<L, [R1, R2]> => {
  if (a.isLeft()) {
    return left(a.value)
  }

  if (b.isLeft()) {
    return left(b.value)
  }

  return right<L, [R1, R2]>([a.value, b.value])
}

Do something like that exists in this library?

I think you can use sequenceT:
import { sequenceT } from 'fp-ts/lib/Apply';
import { either } from 'fp-ts/lib/Either';

declare const a: Either<string, number>
declare const b: Either<string, string>

sequenceT(either)(a, b) // Either<string, [number, string]>

@giogonzo OMG I'm astonished, that's nuts.
Do you have any indication on where I can learn more about these things?
You solved my issue, but I would like to know if we have something like an slack channel where I could ask those things before I close it.

I'm not sure either 😅
I think https://functionalprogramming.slack.com / #typescript channel could be a good place (and @gcanti is answering there 😉). Otherwise stackoverflow?

Nice, thank you.

@giogonzo How can I join the workspace? It seems I need an inventation?

@mlegenhausen sorry wrong link, this should be the correct one: https://fpchat-invite.herokuapp.com/

Adding a few more thoughts to this discussion re learning and questions/answers: I do think slack could be a cheap solution for quick Q&A, but at the same time I think it's a shame that it typically results on a lot of content that is quickly "lost": not easily indexable/searchable, free slack communities also have a limit in visible messages so after some time they just disappear.
I often find myself searching for specific terms among this repo's issues and most of the time my question (or a very similar one) has already been answered in the past, and it remains available here.
Not sure if you guys have other suggestions, or maybe @gcanti has some guidance on these topics

I do think slack could be a cheap solution for quick Q&A, but at the same time I think it's a shame that it typically results on a lot of content that is quickly "lost"

I agree.
Also it's fine for me if people want to use issues for questions, as long as are not trivial.
IMO there are been plenty of interesting discussions so far.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bsa-coder sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.