driverjs when called looks like it will start the tour but it stops immediately, what could be interfering with driverjs?

when I click the button to start the tour, the screen goes black like if it's going to start the tour but then all closes and it shows no errors.
this is the code:
$(document).on('click', '#getHelp',function(e){
    let steps2 = [
                {
                    element: ".nombreCurso",
                    popover: {
                    title: 'Title on Popover',
                    description: 'Body of the popover',
                    position: 'right'
                    }
                }
            ]
            driver.defineSteps(steps2)
            driver.start();
});

what could be interfering with driverjs?

You need to add e.stopPropagation()
$(document).on('click', '#getHelp',function(e){
  e.stopPropagation();

  let steps2 = [
    {
      element: ".nombreCurso",
      popover: {
        title: 'Title on Popover',
        description: 'Body of the popover',
        position: 'right'
      }
    }
  ];

  driver.defineSteps(steps2)
  driver.start();
});

Yes, works

Yes, works


Unique path_prefix

Possibly add a new style path_prefix_unique when the path prefix only matches a single file for a hint to hit tab.

Reminds of of #148, which was a similar idea for command words.

Should path_prefix_unique_pathseparator fall back to path_prefix_unique or path_prefix_pathseparator or something else?

I'd have voted for the latter, since that would maintain the distinction between a terminal separator and the characters before it, and those characters would be highlighted as path_prefix_unique anyway which would serve to convey the uniqueness...
...but I don't highlight path separators differently to other characters in pathnames.  Let's ask the authors of the pathseparators PR (#136 #260).
@blaenk @m0vie WDYT regarding @phy1729's question?

I'd have voted for the latter, since that would maintain the distinction between a terminal separator and the characters before it, and those characters would be highlighted as path_prefix_unique anyway which would serve to convey the uniqueness...

Thanks for the ping. IIUC, I do agree with this. It'd feel weird to have the path separators suddenly change/remove highlighting, reminiscent of the flickering that (used to?) happen.

those characters would be highlighted as path_prefix_unique anyway which would serve to convey the uniqueness...

Right, indeed the latter makes more sense. I'll open a PR after #512 since they'll conflict.

I'd have voted for the latter, since that would maintain the distinction between a terminal separator and the characters before it, and those characters would be highlighted as path_prefix_unique anyway which would serve to convey the uniqueness...

I also agree with this.

I think this is a great suggestion.  How can this be implemented?

There's a (( $#tmp > 0 )) && REPLY=path_prefix on line 978 in current HEAD (I can't permalink, sorry). Check if ! (( $+tmp[2] )). We may be able to optimize this further with glob qualifiers: for example, integer foo; f() { (( ++foo )) }; : *(N+f).

There's also *(Y2) but it's not available in all supported zsh versions.
Finally, I wonder if perchance there already exists a zsh plugin that provides this functionality.


Add customisable conflict resolution for catalog

Background
Currently, conflicting entities ingested by a provider are dropped by the default processing engine. Conflicting entities are new additions which share the same name and namespace as another entity.
This logic can lead to two different cases where the catalog does not represent the actual state of entities represented by yaml files in an SCM:

The first can be broadly defined as where an existing entity is orphaned and then deleted due to a change in file name, or removal/renaming of the entity. At the same time, immediately after the SCM update or just before, a new entity is ingested by a provider that has the same name and namespace as the existing/original entity.

Some real-world cases of this can be illustrated as follows:

Renaming a catalog-info file.
Creating a duplicate entity in another file and then deleting the old file in two separate PRs.
Switching two entities in two different files.
Swapping the names of two different entities of different kinds in the same file.

In all these cases, whether using autodiscovery or the new events based provider, the result is that the change is ignored and the original entity continues to point to the old file location, ceasing to be updated by any changes to the entity yaml. If a garbage collector is implemented, the entity risks disappearing completely from the catalog. If using autodiscovery, the catalog can self-heal by then rediscovering the entity and ingesting the up to date version from the new file location. However if using the events based provider or URL provider, the catalog cannot heal itself currently without manually re-importing the new entity via the url reader.

The second case is essentially the same root problem, but excludes the contributing factor of the delay in orphaning and garbage collecting an entity. It is not currently exposed but will be when deletes are added to the GithubEntityProvider Event sourcing code. In this case, a delete is handled immediately by the event provider. The pattern looks like so:

Event for file name change arrives with a payload of both removed and added file locations. If the implementation handles the addition first, the entity can conflict and be discarded. Then the delete is handled and the original entity is deleted. The resulting state is the same as 1 where the entity disappears altogether from the catalog.
Event for a new file comes in first as the user has duplicated the entity. It is discarded as a conflict. Then the user tries to clean up the old file and deletes the entity. The deletion is processed and entity is removed entirely from the catalog.

This PR
Passes a conflictHandler function through to the ProcessingDatabase.updateProcessedEntity interface, so that when conflicts are identified by trying to update an entity, the handler can implement custom behaviour, for instance overwriting the existing entity with the conflicting update.
NB: Deletion logic implemented by a custom garabage collector and/or future event based deletion will need to also make sure that the entity being deleted matches the location key of the current entity. This is because if the current entity has just been overriden by the update with a new file location for instance, the deletion should be invalid, otherwise we will face the same case as we currently do where we are left with no entity at all.
Alternatives

Instead of injecting the handler from the builder, we could create a more opinionated approach where a settings based toggle could switch between predefined conflict resolution strategies.
Sticking with the autodiscovery mechanism that offers eventual consistency but is not scaleable for larger organisations due to Github Rate limiting and also offers a worse user experience where updates can take a while to reconcile in the catalog, providing confusing intermediate states that may present a support/engineering burden on organisations running Backstage.

Risks
Allowing user defined conflict handling pushes the burden of understanding the complexities of the ingestion and processing pipelines to implementers and provides more chance of mistakes and difficulties in implementing a sane approach.
Example Usage
An basic example overwrite strategy that would suite event based ingestion via @backstage/plugin-events-backend would look something like this:
export default async function createPlugin(
  env: PluginEnvironment,
  providers?: Array<EntityProvider>,
): Promise<Router> {

  ...
  const conflictHandler = async (options: ConflictHandlerOptions) => {
    options.logger.info('Handling conflict with custom overwrite handler');

    const dbClient = await env.database.getClient();
    async function overwriteEntity(params: {
      db: Knex;
      entity: Entity;
      hash: string;
      originalLocationKey: string;
      newLocationKey: string;
    }): Promise<void> {
      const { db, entity, hash, originalLocationKey, newLocationKey } = params;

      const entityRef = stringifyEntityRef(entity);
      const serializedEntity = JSON.stringify(entity);
      const now = db.fn.now();

      await db('refresh_state')
        .update({
          unprocessed_entity: serializedEntity,
          unprocessed_hash: hash,
          location_key: newLocationKey,
          last_discovery_at: now,
          next_update_at: now,
        })
        .where('entity_ref', entityRef)
        .where('location_key', originalLocationKey);
    }

    return await overwriteEntity({
      db: dbClient,
      entity: options.entity,
      hash: options.hash,
      newLocationKey: options.newLocationKey,
      originalLocationKey: options.originalLocationKey,
    });
  };

  const { processingEngine, router } = await builder
    .setConflictHandler(conflictHandler)
    .build(conflictHandler);

  await processingEngine.start();
  ...

NB: this would not resolve cases when using autodiscovery where two conflicting entities remained in the SCM under two files or in a single file. In this case the entities would flip flop.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi Sam!
Thanks for bringing this up. There's is definitely a gap in catalog when it comes to renaming and moving entities that needs addressing. There's is really no good way of doing it currently and you have situations where the entity is temporary removed before re-appearing. I think we need to map out and decide how to handle those intentional situations when a user wants to rename files or move a file or rename a repository as we want to keep some notion of conflicts as it could otherwise have security implications with entity takeovers. Straight up adding a conflictHandler to me feels like we're asking the users to do work that the catalog should be able to handle in the first place.
Would be great to get additional input from @backstage/catalog-core on this matter and if this is something that should be brought up in the Catalog SIG and/or drafted in an RFC fashion beforehand.

Hi @jhaals
Thanks for taking a look!

Straight up adding a conflictHandler to me feels like we're asking the users to do work that the catalog should be able to handle in the first place.
Agree on this. Injecting an optional conflictHandler seemed to me the least intrusive and lowest effort approach to start allowing users to handle cases that they are coming up against. I mentioned in the section on Alternatives:
Instead of injecting the handler from the builder, we could create a more opinionated approach where a settings based toggle could switch between predefined conflict resolution strategies.
For now I'd think this would look something like using the injectable overwrite example by default for when event-based ingestion is enabled and a conflict is detected. I can look at making that change if you prefer the opinionated approach and we can discuss it next week.

if this is something that should be brought up in the Catalog SIG and/or drafted in an RFC fashion beforehand.
Yes definitely happy to talk this through at next weeks Catalog SIG. I followed the RFC format in the PR and have attempted to map out most of the intentional situations when a user wants to rename files, move a file, move an entity or rename a repository which seem to me to all have the same issue (conflict handling) and same fix for event based ingestion (overwriting). I simplified this in the PR background for ease of consumption as the suggested change was not opinionated, but I can elaborate on each of the individual cases.

we want to keep some notion of conflicts as it could otherwise have security implications with entity takeovers
Yes for sure - I think users should be able to choose how they want to handle conflicts. I don't think there is any persisted notion of conflicts in the current backend state. I'm not currently proposing we stop handling conflicts in a specific way for all ingestion scenarios. But allowing customisable handling could allow for instance writing conflicts to an error in the refresh_state table that could be acted on by a separate processor, or just the overwrite strategy I'm proposing for event based ingestion.

For the sake of my understanding ... what code would you put in the resolver? What is your need and your intended solution to that need? Sorry if you've already described it, in that case I missed it.

For the sake of my understanding ... what code would you put in the resolver? What is your need and your intended solution to that need? Sorry if you've already described it, in that case I missed it.

Just the overwrite strategy given in the example and then make sure deletes only happen if the location_key of the entity being deleted matches that in the refresh_state table, as otherwise there can be a state where a delete intended as a clean-up removes the updated entity and you are left with nothing in the catalog.

Were there any updates on this discussion? We are also looking for.a way to resolve conflicts in a custom way but ideally dont want to have to fork this whole code to do that.


Remove insets from scroll view

Description

Before: see https://github.com/CodeEditApp/CodeEdit/issues/1700
After:
https://github.com/CodeEditApp/CodeEditTextView/assets/65467530/a6ce46fa-6576-4c23-8e72-0af64861d168
Related Issues

Closes https://github.com/CodeEditApp/CodeEdit/issues/1700
Closes #7

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots

Oh shoot, just realized the line numbers are now bleeding over the edge...will see what I can about that 😓

@austincondiff sorry I'm really new to Swift and am probably missing a really easy way to fix this issue; any pointers? I think the issue stems from the fact that gutterView is added via addFloatingSubview, which causes it to display over the horizontal scrollbar, but I can't figure out how to get it to display under.

It looks like the line numbers are fine. The text and selection don't come down far enough though.
@thecoolwinter any thoughts on this?

By the way, should we potentially hide the horizontal scrollbar if there's nothing to scroll horizontally/if word wrapping is turned on?

Oh, I see. The line numbers are overlapping the horizontal scrollbar. Two things need to happen here:

Line numbers should stop at the horizontal scrollbar if it is displayed.
If there is not horizontal overflow, horizontal scrollbar should be hidden.


Identity and EF (Startup.cs, DbSetInitializer, and EnsureCreateAsync)

I've combed Identity and EntityFramework repositories for answers and found some test and sample code but the don't do a good job of showcasing the functionality from Startup.cs point of view.
So, what's the purpose of the DbSetInitializer if its never called? What is the correct way to ensure my database is created calling SqlServerDatabase.EnsureCreateAsync() and ensuring my custom DbSetInitializer is executed?
DbSetInitializer has seed data that allows my application to function.

DbSetInitializer is for initializing the DbSet<T> properties on a DbContext, it has nothing to do with database initialization.
In EF7 we've done away with the concept of database initializers. We would encourage you to use migrations to create and maintain the database (you can see that workflow in action here). Alternatively, you can use DbContext.Database.EnsureCreated() but there is no way to upgrade the created database if you make model changes (aside from dropping and recreating it). DbContext.Database.EnsureCreated() is really only intended for use in tests etc.
BTW SqlServerDatabase isn't a type you would typically code against. It's an underlying type that EF will delegate to when you are targeting SQL Server.

Thanks for providing the clarity and I already reviewed the workflow in action before posting. I did remove the DbSetInitializer and found a solutions to my problem using a similar approached found in the Identity repository's sample application.
Final question, is Identity and forms authentication the preferred method for development an authorization/authentication scheme with external login providers of course?

Sounds like the sample in the Identity repo is probably just out of date. When you create a new application in Visual Studio that uses Identity it now scaffolds an initial migration to add the identity tables and you can then continue on adding migrations if you change/extend the model at all.

That's fine. I currently developing without an IDE using only what is provided via github.com/aspnet. This means I only have K Runtime (kvm or dotnetsdk), K Package Manager (kpm), notepad++ and ILSpy. There's no scaffolding to generate any migration code etc.
My understanding is EF 7 will attempt to generate the database the first if it doesn't existing. I have logging information in my project that outputs information when OnModelCreating method is executed,
Here's what I get

PS F:\apps\pcsc\GreenShelter\src\mvc> k web
[INFO:Green Shelter] Startup => Startup
[INFORMATION:Green Shelter] Startup => Startup
[INFO:Green Shelter] Startup =>         Configure Services
[INFORMATION:Green Shelter] Startup =>  Configure Services
[INFO:Green Shelter] Startup =>         Configure Development
[INFORMATION:Green Shelter] Startup =>  Configure Development
[INFO:Green Shelter] Startup =>         Configure
[INFORMATION:Green Shelter] Startup =>  Configure
[INFO:Green Shelter] Startup =>         Configure Authenticiation
[INFORMATION:Green Shelter] Startup =>  Configure Authenticiation
Started
[INFO:Green Shelter] SpaController => StartPage
[INFORMATION:Green Shelter] SpaController => StartPage
[INFO:Green Shelter] SpaController => StartPage
[INFORMATION:Green Shelter] SpaController => StartPage
[INFO:Green Shelter] ClientController => /api/v1/client/authtypes
[INFORMATION:Green Shelter] ClientController => /api/v1/client/authtypes
[INFO:Green Shelter] /api/v1/client/login [POST] UserName<EMAIL_ADDRESS>[INFORMATION:Green Shelter] /api/v1/client/login [POST] UserName<EMAIL_ADDRESS>[INFO:Green Shelter] GreenShelterDbContext => Configuring DbContext
[INFORMATION:Green Shelter] GreenShelterDbContext => Configuring DbContext
[INFO:Green Shelter] GreenShelterDbContext => Creating Model for DbContext
[INFORMATION:Green Shelter] GreenShelterDbContext => Creating Model for DbContext
[ERROR:Green Shelter] Login was unsuccessful
System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or more errors occurred. ---
> System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or more errors occurred. -
--> System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or more errors occurred.
 ---> System.Data.SqlClient.SqlException: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.TaskExtensions.CultureAwaiter`1.GetResult()
   at Microsoft.Data.Entity.Query.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Query.EntityQueryExecutor.AsyncEnumerableExceptionInterceptor`1.AsyncEnumeratorExceptionInte
rceptor.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNet.Identity.SignInManager`1.<PasswordSignInAsync>d__30.MoveNext()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at PCSC.GreenShelter.Controllers.Api.V1.ClientController.Login(Login login) in F:\apps\pcsc\GreenShelter\src\mvc\Cont
rollers\Api\v1\ClientController.cs:line 67
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or
 more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.AggregateException: One
or more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.Data.SqlClient.SqlExce
ption: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.TaskExtensions.CultureAwaiter`1.GetResult()
   at Microsoft.Data.Entity.Query.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Query.EntityQueryExecutor.AsyncEnumerableExceptionInterceptor`1.AsyncEnumeratorExceptionInte
rceptor.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNet.Identity.SignInManager`1.<PasswordSignInAsync>d__30.MoveNext()
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or
 more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.AggregateException: One
or more errors occurred. ---> System.Data.SqlClient.SqlException: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.TaskExtensions.CultureAwaiter`1.GetResult()
   at Microsoft.Data.Entity.Query.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Query.EntityQueryExecutor.AsyncEnumerableExceptionInterceptor`1.AsyncEnumeratorExceptionInte
rceptor.<MoveNext>d__6.MoveNext()
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or
 more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.Data.SqlClient.SqlExcept
ion: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.TaskExtensions.CultureAwaiter`1.GetResult()
   at Microsoft.Data.Entity.Query.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or
 more errors occurred. ---> System.Data.SqlClient.SqlException: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.Data.SqlClient.SqlExceptio
n: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.Data.SqlClient.SqlException (0x80131904): Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
ClientConnectionId:c907e5ce-6765-4aee-83e7-124956886636<---
<---
<---
<---
<---
<---

[ERROR:Green Shelter] Login was unsuccessful
System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or more errors occurred. ---
> System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or more errors occurred. -
--> System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or more errors occurred.
 ---> System.Data.SqlClient.SqlException: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.TaskExtensions.CultureAwaiter`1.GetResult()
   at Microsoft.Data.Entity.Query.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Query.EntityQueryExecutor.AsyncEnumerableExceptionInterceptor`1.AsyncEnumeratorExceptionInte
rceptor.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNet.Identity.SignInManager`1.<PasswordSignInAsync>d__30.MoveNext()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at PCSC.GreenShelter.Controllers.Api.V1.ClientController.Login(Login login) in F:\apps\pcsc\GreenShelter\src\mvc\Cont
rollers\Api\v1\ClientController.cs:line 67
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or
 more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.AggregateException: One
or more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.Data.SqlClient.SqlExce
ption: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.TaskExtensions.CultureAwaiter`1.GetResult()
   at Microsoft.Data.Entity.Query.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Query.EntityQueryExecutor.AsyncEnumerableExceptionInterceptor`1.AsyncEnumeratorExceptionInte
rceptor.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNet.Identity.SignInManager`1.<PasswordSignInAsync>d__30.MoveNext()
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or
 more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.AggregateException: One
or more errors occurred. ---> System.Data.SqlClient.SqlException: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.TaskExtensions.CultureAwaiter`1.GetResult()
   at Microsoft.Data.Entity.Query.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Query.EntityQueryExecutor.AsyncEnumerableExceptionInterceptor`1.AsyncEnumeratorExceptionInte
rceptor.<MoveNext>d__6.MoveNext()
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or
 more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.Data.SqlClient.SqlExcept
ion: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.TaskExtensions.CultureAwaiter`1.GetResult()
   at Microsoft.Data.Entity.Query.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or
 more errors occurred. ---> System.Data.SqlClient.SqlException: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.Data.SqlClient.SqlExceptio
n: Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.Data.SqlClient.SqlException (0x80131904): Invalid object name 'AspNetUsers'.
   at System.Data.SqlClient.SqlCommand.<ExecuteDbDataReaderAsync>b__24(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<InitializeAndReadAsync>d__7.Move
Next()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Data.Entity.Relational.Query.AsyncQueryingEnumerable`1.AsyncEnumerator.<MoveNext>d__6.MoveNext()
ClientConnectionId:c907e5ce-6765-4aee-83e7-124956886636<---
<---
<---
<---
<---
<---

And here's my DbContext class
using System;
using System.Data;
using System.Linq;
using System.Collections.Generic;
using System.Security.Claims;
using System.Threading.Tasks;

using Microsoft.Framework.DependencyInjection;
using Microsoft.Framework.OptionsModel;

using Microsoft.AspNet.Identity;
using Microsoft.AspNet.Identity.EntityFramework;

using Microsoft.Data.Entity;
using Microsoft.Data.Entity.Infrastructure;
using Microsoft.Data.Entity.Metadata;
using Microsoft.Data.Entity.SqlServer;

using PCSC.GreenShelter;
using PCSC.GreenShelter.Extensions;

namespace PCSC.GreenShelter.Models {
	/// <summary>
	/// Provides the the data access for the Green Shelter Application
	/// </summary>
	public class GreenShelterDbContext: IdentityDbContext<ApplicationUser, ApplicationRole, string>, IGreenShelterApplication {
		/// <summary>
		/// Describe name for the class implementing <cref="IGreenShelterApplication"/> interface
		/// </summary>
		public string TagName { get { return "GreenShelterDbContext"; } }

		public DbSet<Address> Addresses { get; set; }
		public DbSet<Organization> Organizations { get; set; }

		protected override void OnModelCreating(ModelBuilder builder) {
			this.WriteInformation("Creating Model for DbContext");

			base.OnModelCreating(builder);

			builder.Entity<Address>().Key(a => a.AddressId);
			builder.Entity<Organization>().Key(a => a.OrganizationId);

			//builder.Entity<ApplicationUser>().ForRelational(u => u.Addresses);
			//builder.Entity<ApplicationUser>().OneToMany(u => u.Organizations);
		}

		protected override void OnConfiguring(DbContextOptions options) {
			this.WriteInformation("Configuring DbContext");

			var sqlOptions = options.UseSqlServer();
		}
	} // end class
} // end namespace

Here's the code the causes the model configuration
[HttpPost("login")]
		[AllowAnonymous]
		public JsonResult Login([FromBody] Login login) {
			this.WriteInformation("/api/v1/client/login [POST] UserName: {0}", login.UserName);

			var response = new ApiResponse();

			try {
				response.Code = 200;
				response.Description = "Login was successful";

				// Use the following link for explaination of authenticationmethod
				// https://msdn.microsoft.com/en-us/library/microsoft.identitymodel.claims.authenticationmethods_members.aspx
				SignInManager.PasswordSignInAsync(login.UserName, login.Password, false, false).Wait();
			} catch(Exception ex) {
				response.Code = 401;
				response.Description = "Login was unsuccessful";

				this.WriteError(response.Description, ex);
			}

			return  new JsonResult(response);
		}

Any idea what could be wrong?

EF7 won't automatically create a database for you (this would occur in EF6.x and earlier release but time has shown that this was too much magic and causes more confusion that help).
The best way to create a database is to use migrations. Make sure you have the EntityFramework.Commands package installed and the following in your project.json:
...
    "commands": {
        "ef":  "EntityFramework.Commands"
    },
...

You can then use k ef migration add <migration name> and k ef migration apply at the command line to create a migration and apply the changes to the database.

I continue to be impressed. I was aware the commands section could be used for executing test, web application or applications but missed the fact, it also handles migration for EF. Thanks for your help.

Closing this one but feel free to reopen if you have further issues


provide name override field for flowlog definition

closes: #126
Little bit of a shotgun approach.. could just change the iam role but the resources are logically grouped so i figured this was more clear
$ go test -run  TestExamplesPublicPrivateCWLogs -timeout 45m
...

TestExamplesPublicPrivateCWLogs 2023-08-11T13:40:43-04:00 logger.go:66:
PASS
ok      github.com/aws-ia/terraform-aws-vpc     235.733s

If merged should be 4.3.0

This topic is being discussed at the provider level as well. some resources have VERY strict restrictions on name_prefixes: https://github.com/hashicorp/terraform-provider-aws/issues/32838

@andrew-glenn any chance this can get merged and released?


How to know if a control is being shown in the visible area on a ScrollViewer

Hello,
I have a ScrollViewer that contains a Grid. This Grid has many UserControl that are aggregated dinamically.  I would like to know if it´s possible to know if one of this UserControl is shown on screen or if is not visible.
Thanks.

Thanks for taking the time to let us know about this. Unfortunately, the scope of our feedback channel here on GitHub covers specific documentation fixes, but I can help redirect you to the right support channel to get an answer to your question. The community of experts and Microsoft Engineers over at Microsoft Q&A offer timely answers to a multitude of technical questions surrounding windows-uwp. Hope you can get an answer there!

Thanks for taking the time to let us know about this. Unfortunately, the scope of our feedback channel here on GitHub covers specific documentation fixes, but I can help redirect you to the right support channel to get an answer to your question. The community of experts and Microsoft Engineers over at Microsoft Q&A offer timely answers to a multitude of technical questions surrounding windows-uwp. Hope you can get an answer there!


Update EntrustUserTrait.php

Parent method returns true or false. We need to return that result too.
Signed-off-by: Petronel Malutan<EMAIL_ADDRESS>

[x] Created a fix for the trait used in the user model which is not returning called parent method response.

anybody seen this ?

I support this pull request strongly. My code broke on the lack of the return values. Should be updated as soon as possible.

@Tredde if you need these changes immediately the best you can do is fork this repo and require it in your composer.json

@malutanpetronel your approach is well. But you forget to add in EntrustRoleTrait.php file?

The only problem I was noticing in the project I am working for, was when I saved a user. It could be that saving roles will fail too :)


Increase timeout for tabular explainer e2e test

This should hopefully reduce the number of timeout failures during CI.
Closes: #1594
/cc @yuzisun

/lgtm
/approve


[Site] Features: Incompatibility with dark mode

Description
The https://meshery.io/features page has a dark mode compatibility issue. See screenshot.
Screenshots

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hi @leecalcote, I have set up Meshery.io and am eager to contribute. Could you please assign me this issue

Thank you for confirming that you have a working development environment for this project. That's very helpful, @Gauravjadhav22. Sure, you bet.

Hi @leecalcote I didn't find the Figma file for the Meshery.io/features page. Can you please confirm if it has been fixed?
https://github.com/meshery/meshery.io/assets/75011596/fc751456-54a3-4212-bc7a-6d0bb8e4d1ca

I don't know if there is a Figma page for this. There might be. Be sure to look in both "Meshery UI" and "Layer5 Designs" design files.

Hi @leecalcote
I couldn't find the Figma for this component, but I've fixed the background color to be compatible with the website's theme. Shall I proceed to raise the pull request?
https://github.com/meshery/meshery.io/assets/75011596/51e094da-677c-4aa3-9144-e18432aab919

@Gauravjadhav22  thank you. Yes, please.


actualize README

[ ] add the Research section: https://github.com/Aalto-LeTech/intellij-plugin/issues/445
[x] add sonar's LOCs badge
[x] add new authors to the corresponding section
[x] add @StanislavFranko to contributors
[x] consider if we're adding a video's (links to panopto or something)
[ ] install plugin it's javascript, so no

updated and checked all the links


Version bump

Major version bump

Should probably land after #187

Can some dependencies be updated before the version is bumped? More specifically updating gl/gl_generator and the macOS dependencies like cocoa would help towards deduping these in Servo.

@atouchet care to submit a PR? I don't want to delay this too much, since it's a blocker on landing webxr layer management.

OK, doing an experiment to see how easy updating deps would be: https://travis-ci.com/github/asajeffrey/surfman/builds/173035469
It looks like updating gl_generator is straightforward, but updating the mac dependencies causes build errors: https://travis-ci.com/github/asajeffrey/surfman/jobs/353617288
I propose to update gl_generator, but leave the Mac dependencies as-is for right now.

@asajeffrey sounds good. winit is blocking getting rid of most of the macOS dependency dupes for now anyways.

Filed #190.

Also, we should hold off on this version bump until I address https://github.com/servo/surfman/pull/187#discussion_r445658500

Filed #191, when that merges hopefully we can do the version bump.

@bors-servo r=jdm

:pushpin: Commit a2a4d15 has been approved by jdm

:hourglass: Testing commit a2a4d15d4eef5e5c29d3fdda4eb515584dc3971f with merge 7c78d0c4cc6b4c4b9221a214dba2a12c72f299a1...

:sunny: Test successful - checks-travis
Approved by: jdm
Pushing 7c78d0c4cc6b4c4b9221a214dba2a12c72f299a1 to master...


setup builds for various platform and support cargo binstall

personally, i just need to curl this into a container, but if we are doing builds may as well try to support cargo-binstall (which likely has some good ci templates)

ended up following cargo-watch's approach (sans older signing approaches) in https://github.com/clux/yq/pull/4 then pulling out failing deb + rpm stuff for now.
there are at least installables, but binstall doesn't seem to like them..


I can upvote upto n times!

When I click downvote and upvote again the value is incrementing by one again and again!

It works fine for me. Please provide more info

I will record and send it to you soon!


set-nuget-private-source 1.0.1

@viktorbenei Looks great to me!
@jsinh Thanks for the contribution! :)

Awesome, thanks @jsinh for the contribution! 😉


AUR Package

Hi, thanks for building this.
Just thought I'd let you know that I've added an AUR package for chars to make it easy to install on Arch Linux with the system packaging tools.
Might be worth including a link to the package in installation section of the README.

Thanks so much for packaging this! I updated the README to point to the AUR page (:

Great, thank you :-)


Feat 7714 adding semaphore messaging adapter

What does this PR do?
This PR adds Semaphore SMS adapter.
Test Plan

I verified the response structure of this adapter to match with the response structure of the exisiting SMS adapters.
I verified that the new adapter is handling both sucess and failure responses. I have added the sample responses in the new adapter file for your reference

Related PRs and Issues
This PR is an attempt to solve this issue
Have you read the Contributing Guidelines on issues?
Yes, I have read the contributing guidelines. Starting from naming of the branch to writing tests to linting, I have double checked if I am complying with the contributing guidelines.

Dear reviewer, I am attaching the images that prove the working and the lint success of this adapter for your reference.
Success response

Failure response

Lint success

I hope someone will review this PR

Any update for this PR?


ci: force no_unwrap in clippy

This change is

Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.17%. Comparing base (9e36a57) to head (1815a99).

Files
Patch %
Lines

crates/gateway/src/gateway.rs
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   41.17%   41.17%
=======================================
  Files           3        3
  Lines          34       34
  Branches       34       34
=======================================
  Hits           14       14
  Misses         20       20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


shortcut for 24.1 release notes (/r/v24.1)

@mschatz Is this intended as a link to the 24.1 release announcement (on the galaxy hub), or a link to the 24.1 release notes? If it's the latter, the correct link should be https://docs.galaxyproject.org/en/master/releases/24.1_announce.html for the full release notes, or https://docs.galaxyproject.org/en/master/releases/24.1_announce_user.html for user-facing release notes.

good catch. lets do the user-facing notes


Not able to find APIs to Create IndexTemplate and Dynamic Template

Hi All,
I'm using ElasticSearch 2.3.4 and NEST sdk for my .Net Application. I'm trying to define below Index Template and Dynamic Template using Nest Client but not able to identify appropriate APIs for the same,
{
"template": "",
"settings":{
"index":{
"analysis":{
"analyzer":{
"analyzer_keyword":{
"tokenizer":"keyword",
"filter":"lowercase"
}
}
}
},
"number_of_shards" : 5,
"number_of_replicas" : 0
},
"mappings": {
"default": {
"numeric_detection": true,
"dynamic_templates": [
{
"string_analyzer": {
"match_mapping_type": "string",
"match": "",
"mapping": {
"type": "string",
"analyzer":"analyzer_keyword"
}
}
}
]
}
}
}
Any help is appreciated.
Thanks,
Sreeram

You can use client.PutIndexTemplate(), let me know if you need more details going forward.

@sreefubs This kind of question would be best asked on discuss or stackoverflow; we try to reserve github issues for bugs and issues related to the client.

@Mpdreamz Thanks for your quick response. Since I've to load template from a json file I did it as below,
StreamReader r = new StreamReader(Environment.CurrentDirectory + @"\TemplateCreator_template.json");
string json = r.ReadToEnd();
var response = EsClient.LowLevel.IndicesPutTemplateForAll("custom_template", json);


Validation and spec

Model validation and data confirmation
In this milestone, I did the following:

[ ] added the validation
[ ] Add the spec test
[ ] Passed the test

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑
Hi @V0pe,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
Kindly remove all section descriptions e.g. the muted text, "Describe 1 - 3 features you will add to the project." in the Future Features section should be removed, and other descriptions like that in other sections.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Simulate fees more granularly based on each exchange

Currently, we are using fix percentages to simulate fees. However, we have enough data to be much more precise. This applies to backtesting and paper trading.

Using CCXT to get fees for each individual market. The results are not always consistent so more systematic testing is required. I'll create a unit tests which does a check for all exchanges.

In Release 0.4.0.


wellness section UI : use cards with different styles

please assign it to me under JWOC'2024.

@vishal2005025 kindly elaborate on what all changes you would like to make

I would love to work on the UI design of the website. Please assign me this task under JWOC
The changes I will like to make

I would love to change the UI of wellness section. Please assign me this task under JWOC'2024
Changes i would like to make

I would like to use cards in grid with different styles and hovers with content

@vishal2005025 go ahead

@vishal2005025 updates ?

I have completed half of the work and I will created pr till tomorrow..

Mam, I have completed this issue and created pull request.
please check..

Name : Vishal malyan
Mam, I have created new pr after all the changes.
please check


chore: issue-540 - Documentation changes for custom query row validation

Closes #540

/gcbrun

/gcbrun

/gcbrun

LGTM. I updated your description with the 'closes' keyword so it automatically closes the issue when this PR is merged.


neovim freezes when writing an opening curly brace

Describe the Bug
Basically, I'm using Neovim to write Astro and when writing an opening curly brace at a very specific position in the file, then Neovim freezes and I have no other choice but to force quit.
Here is an example of when the freeze happens in a file named "SomeComponent.astro":
---
// If I write an opening curly brace in here, it's totally fine:

const name = { name: "Thomas" };
---

Hello {name.name}

I disabled the astro_language_server (the LSP) from Mason and it didn't change anything. My assumption is that the problem is caused by the Tree sitter specifically in an .astro file. Probably an infinite loop in the parsing process. Unfortunately I do not know how to give you more information.
Steps to Reproduce

Create an empty Astro project and open it with Neovim while having the treesitter plugin.
Open a file ending with .astro and go to the first line after the --- part:

---

---

Hello

Try writing an opening curly brace where it is said "Here" in the above example, without the comment. For me, it freezes neovim.
Notes:

I'm using the latest version of neovim
I ran :TSUpdate and it says I'm using the latest versions
I do not know if this problem was caused due to an action I did because it's my first day using Astro.
I'm using macOS (version Monterey) with the default shortcut (for an AZERTY French layout at least) which is Alt (
I'm using iterm2 but the problem doesn't come from there since it also happens in the default Terminal of macOS.
I do not have any conflicting shortcut and this problem only happens in .astro files, nowhere else.

Here is some of my Neovim plugins that may be relevant (with Packer):
vim.cmd [[packadd packer.nvim]]

return require('packer').startup(function(use)
    use 'wbthomason/packer.nvim'
    use {
        'nvim-telescope/telescope.nvim', tag = '0.1.6',
        requires = { { 'nvim-lua/plenary.nvim' } }
    }

    use('nvim-treesitter/nvim-treesitter', { run = ':TSUpdate' })
    use('nvim-treesitter/playground')

    use {
        'VonHeikemen/lsp-zero.nvim',
        branch = 'v3.x',
        requires = {
            { 'williamboman/mason.nvim' },
            { 'williamboman/mason-lspconfig.nvim' },

            -- LSP Support
            { 'neovim/nvim-lspconfig' },
            -- Autocompletion
            { 'hrsh7th/nvim-cmp' },
            { 'hrsh7th/cmp-buffer' },
            { 'hrsh7th/cmp-path' },
            { 'saadparwaiz1/cmp_luasnip' },
            { 'hrsh7th/cmp-nvim-lsp' },
            { 'hrsh7th/cmp-nvim-lua' },

            -- Snippets
            { 'rafamadriz/friendly-snippets' },
            { 'L3MON4D3/LuaSnip' },
        }
    }

    use('jose-elias-alvarez/null-ls.nvim')
    use('MunifTanjim/prettier.nvim')

    use('nvim-lua/plenary.nvim')
end)

I can't reproduce the issue. However, this sounds very similar to an issue I have already fixed in commit https://github.com/virchau13/tree-sitter-astro/commit/1da287da32e6a433e952793e4b91786165257e94.
Maybe your nvim-treesitter plugin is out of date? Try running :PackerUpdate and then run :TSUpdate.

Well strangely enough I've just tried on an other computer and I cannot reproduce the issue either. I guess I must have messed up somewhere in the configuration of my previous computer. If someday I get the problem again I will tell you so but as of now I fear there is nothing more to be said on this subject. I'm sorry for the inconvenience.

No problem. Fixing bugs by doing nothing is always nice :)


fix: nested object models are not split

Description
This PR fixes a bug where nested models (i.e. first encountered model is not an object model but the nested one is) are not split.

Pull Request Test Coverage Report for Build 922259923

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 93.997%

Totals

Change from base Build 921772376:
0.02%

Covered Lines:
1192

Relevant Lines:
1222

💛  - Coveralls


ws connection timeout

Is there a timeout when ws connection fails? Can we set it? (I couldn't find it on documentation or on forum)

Hey @selimanac, this feature has been added into defold-websocket by @britzl last month (https://github.com/britzl/defold-websocket/commit/8ca46799ce51784b9cfa85bd7d3ef67efe741181)
I've just exposed this option this way on colyseus-defold:
local ColyseusConnection = require "colyseus.connection"
ColyseusConnection.config = { connect_timeout = 10 }

Hope this helps! Cheers!


Dash not working on Mac

Dash isn't working on the Mac anymore.
This may have started happening long ago, possibly when we started incorporating the Dash libraries in VR2G-nativeLibraries (because I cannot imagine that I didn't test them). But maybe I didn't test and the problem started earlier.
Problem is that some dynamic libraries are missing:

[vrt_create_ext] failure: can't load '/Users/jack/src/VRTogether/VR2Gather/Assets/ExternalAssets/VR2G-nativeLibraries/VRTNativeLibraries/Plugins/mac//GPACMuxMP4.smd' (dlopen(/Users/jack/src/VRTogether/VR2Gather/Assets/ExternalAssets/VR2G-nativeLibraries/VRTNativeLibraries/Plugins/mac//GPACMuxMP4.smd, 0x0082): Library not loaded: /opt/msprod/sysroot/osx//lib/libgpac.dylib
  Referenced from: <AFF98D41-F2E1-30CB-B96B-9A8103E985CE> /Users/jack/src/VRTogether/VR2Gather/Assets/ExternalAssets/VR2G-nativeLibraries/VRTNativeLibraries/Plugins/mac/GPACMuxMP4.smd
  Reason: tried: '/opt/msprod/sysroot/osx//lib/libgpac.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/msprod/sysroot/osx//lib/libgpac.dylib' (no such file), '/opt/msprod/sysroot/osx//lib/libgpac.dylib' (no such file), '/usr/local/lib/libgpac.dylib' (no such file), '/usr/lib/libgpac.dylib' (no such file, not in dyld cache))
AsyncB2DWriter#0(http://<IP_ADDRESS>:8082/4ae6bcc1-7aaf-4b63-aec4-16583bda6c6f/206e7ac1-c635-4f5e-a27c-8e65f58481d9/pcc/) Exception:AsyncB2DWriter#0: vrt_create: failed to create uploader http://<IP_ADDRESS>:8082/4ae6bcc1-7aaf-4b63-aec4-16583bda6c6f/206e7ac1-c635-4f5e-a27c-8e65f58481d9/pcc/pointcloud.mpd
UnityEngine.StackTraceUtility:ExtractStackTrace () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/StackTrace.cs:37)
UnityEngine.DebugLogHandler:LogFormat (UnityEngine.LogType,UnityEngine.Object,string,object[])
UnityEngine.Logger:Log (UnityEngine.LogType,object)
UnityEngine.Debug:Log (object)
VRT.Transport.Dash.AsyncB2DWriter:.ctor (string,string,string,int,int,Cwipc.StreamSupport/OutgoingStreamDescription[]) (at Assets/Transport/Dash/Bin2Dash/Workers/Writers/AsyncB2DWriter.cs:84)
VRT.UserRepresentation.PointCloud.PointCloudPipelineSelf:_InitForSelfUser (VRT.Core.VRTConfig/_User/_PCSelfConfig,bool) (at Assets/UserRepresentation/PointClouds/Scripts/PointCloudPipelineSelf.cs:226)
VRT.UserRepresentation.PointCloud.PointCloudPipelineSelf:Init (bool,object,VRT.Core.VRTConfig/_User,bool) (at Assets/UserRepresentation/PointClouds/Scripts/PointCloudPipelineSelf.cs:76)
VRT.Pilots.Common.PlayerControllerBase:SetRepresentation (VRT.Core.UserRepresentationType,bool,bool) (at Assets/Pilots/Common/Players/PlayerControllerBase.cs:181)
VRT.Pilots.Common.PlayerControllerBase:_SetupCommon (VRT.Orchestrator.Wrapping.User) (at Assets/Pilots/Common/Players/PlayerControllerBase.cs:97)
VRT.Pilots.Common.PlayerControllerSelf:SetUpPlayerController (bool,VRT.Orchestrator.Wrapping.User) (at Assets/Pilots/Common/Players/PlayerControllerSelf.cs:29)
VRT.Pilots.Common.SessionPlayersManager:InstantiatePlayers () (at Assets/Pilots/Common/Players/SessionPlayersManager.cs:166)
VRT.Pilots.Common.SessionPlayersManager/<InstantiatePlayersAfterDelay>d__21:MoveNext () (at Assets/Pilots/Common/Players/SessionPlayersManager.cs:118)
UnityEngine.SetupCoroutine:InvokeMoveNext (System.Collections.IEnumerator,intptr) (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/Coroutines.cs:17)

I think the needed files are in src/VRTogether/MotionSpell/msprod/sysroot/osx/lib. Need to find out which ones are actually needed.
Also need to check there isn't a problem on Windows (I think not) and Linux (unsure).


qsynth broken in 19.03

@magnetophon
hydra seems to be trying to compile the older version so I'm guessing your recent 0.5.5 update wasn't merged/back-ported to stable properly/yet?
https://hydra.nixos.org/job/nixos/release-19.03/nixpkgs.qsynth.x86_64-linux
btw, 0.5.6 was released a few days ago too.
p.s. to clarify, unstable is fine.

@SmilingHorse Thanks for the heads up!
@worldofpeace Thanks for the solution!

Closing the issues in advance.
Thanks everyone.


Why can't extract change and blur handler?

Hi, thanks for creating this library.
I noticed there is a common pattern like:
                   onChange=(
                     event =>
                       event
                       |> Formality.Dom.toValueOnChange
                       |> form.change(SignUpForm.Email)
                   )
                   onBlur=(
                     event =>
                       event
                       |> Formality.Dom.toValueOnBlur
                       |> form.blur(SignUpForm.Email)
                   )

So I tried to extract two functions to handle this:
             let handleChange = (field, event) =>
               event |> Formality.Dom.toValueOnChange |> form.change(field);
             let handleBlur = (field, event) =>
               event |> Formality.Dom.toValueOnBlur |> form.change(field);

            /* Usage */
             onChange=(handleChange(SignUpForm.Email))
             onBlur=(handleBlur(SignUpForm.Email))

Then it doesn't validate any more, why?

@hulufei I can't say from these snippets where these helpers are defined and my question is: should you pass form record to the helper as well? E.g.:
let handleChange = (form, field, event) =>
  event |> Formality.Dom.toValueOnChange |> form.change(field);
let handleBlur = (form, field, event) =>
  event |> Formality.Dom.toValueOnBlur |> form.change(field);

/* Usage */
onChange=(handleChange(form, SignUpForm.Email))
onBlur=(handleBlur(form, SignUpForm.Email))

Hmm, that's odd. I need to get married now but I will look into this soon.

@alexfedoseev Congratulations! take your time:)

@hulufei I tested all possible ways to extract handlers with changes in #37 and it worked for me. Will release soon. Feedback on those changes are also appreciated.

@hulufei I'm closing this, feel free to re-open if it's still an issue for you.


⚠ Processors has degraded performance

In 0128501, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 44 ms

Resolved: Processors performance has improved in c1e0768.


Badge (alert counter) Possible?

Thank you for the awesome plugin. Is it possible to implement a  badge atop an inactive icon to indicate number of alerts/notifications?
Alternatively, maybe an optional text box below an inactive icon where we can alert the user to new messages or alerts for a given tab.
Thank you!

Good Morning,
I have the same doubt.
Is it possible to use badges in icons?
Thanks.
Cristian Regazzo

same ?

same ?


Cleaned up man page

Some of the changes:

Removed % Author metadata header because there is already AUTHOR section in man page.
Escaped some special characters
Use : line for pandoc's special indenting.
Always use 4 spaces for code.
Fix and example where is said 0 = 1 and not 0 = 0

According to the pacdoc man page, the : line feature is actually called "Definition lists" and come from "PHP Markdown Extra". These just happen to be useful when writing man pages.

Thanks. Most of the changes are fine, though some of them are gratuitous (e.g using _ instead of *). I have included the subset which I think are appropriate. In the future please create a separate commit if you are going to reformat paragraphs as it adds a lot of noise to the diff.

Some of these changes were from automatically formatted.
Also rejecting some of these changes is fine, but I think it's better if you suggest changes and I make the changes myself. There are some changes I wanted merged but are not there in the final version and it's hard to follow the git diffs. I will need to make a second pull request for that.
Also I will make separate commits to make all changes clear from now on.

Also rejecting some of these changes is fine, but I think it's better if you suggest changes and I make the changes myself.

Fair enough.

Also I will make separate commits to make all changes clear from now on.

Thanks. It's only necessary if you auto format a large chunk of text in addition to your changes. You should avoid doing this anyway without good reason, but if you do a separate commit makes it easier to distinguish from the other changes.


Update GrootCI fix #64

Updated GrootCI workflow
Co-Authored-By: Shay Avraham<EMAIL_ADDRESS>

@tomerguttman Next time move the "fix #x" from the title to the initial comment, It'll automatically link the issue to the pr. :)


Consider h5spark for HDF5 on Spark

I came across this library from NERSC for reading HDF5 from Spark: https://github.com/valiantljk/h5spark

Issue moved to broadinstitute/gatk #2873 via ZenHub


Refactor

Coverage decreased (-1.3%) to 55.649% when pulling 878d4cb353251d864ff8e392b5fa4b015f668c15 on refactor into 11b7f312faeda1e10bdbc7b42de992d4e5306acf on master.

Coverage decreased (-1.6%) to 55.383% when pulling e503980dbbef376d5e3b95dc048069a66dd3a336 on refactor into 11b7f312faeda1e10bdbc7b42de992d4e5306acf on master.


What is the minimum version of the Ktor framework supported by the plugin?

I wanted to understand the compatibility between this plugin and the Ktor framework. To clarify, could you please provide information on the minimum version of Ktor that the plugin requires to operate effectively? Thank you.

@SMILEY4  Will you be able to answer this?

Hi, i haven't done any extensive compatibility testing, so i cannot tell you exactly. It should be compatible with all ktor 2.x versions.


Bigint support

Bigint is now supported by chrome and node.  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
This library is not compatible with these numbers.  isNumber(7n) reports false.

According to the documentation that you linked, it is not recommended to coerce variables between Number and BigInt. It also states that native Math methods do not work with BigInt.
Because of these restrictions, I don't think is-number should return true for BigInt.


Support categorization in running the AppHost

Say you intend to run some or the projects (but not all) in some configuration and have it named. e.g. Backend. Which may contain databases, cache and Apis.
This would make it easier to work with some certain testing (and later possibly deployment scenareos), where you do not want to spin up new services, but have certain services remain running which you test some behaviours. An example would be I may not wany to spin up a new DB and Background service just cause I need to preserve the data I used before.
So effectively its

A feature that would allow for run configurations.
Deployment configurations. e.g Deploy "Backend to Region 1 gradually/immediate"
Run "Integration Tests" configuration

Related to https://github.com/dotnet/aspire/issues/303

Moving to preview 5 for now needs to be more top down on how the UX works.

Moving to backlog.


Only add -fno-omit-frame-pointer if using debug profile.

When using a Cargo.toml such containing:
debug = true

cc-rs will automatically add -fno-omit-frame-pointer which affects code generation,
in my opinion there should be a way to enable debug info, without affecting the resulting code generation.
This patch attempts to do so, by only adding -fno-omit-frame-pointer if the target profile is debug
rather than if debuginfo is enabled.  I imagine it's somewhat debatable the right way to make this possible.

I've personally used this before because frame pointers assist in profiling by making stack traces easier for some tools (like perf). It's true that it's unfortunate that it affects runtime performance as well, but I think that we'd probably want an explicit option for this rather than inference based on existing settings.

I was actually comparing a rust program in perf, to the equivalent system executable.  On some systems frame pointers are required, but others can be done with just dwarf and the .eh_frame section.
After sending the request I noticed rustc now has: -C force-frame-pointers=yes|no
Would it be better to rework this based upon the rustc flags/RUSTFLAGS environment variable,
leaving the current behavior unless force-frame-pointers=no?

Yeah if we could infer from RUSTFLAGS that would be great, although I'm not sure how to best do that myself

I did have a bit of a look at this, the only thing that would inhibit this from being straight forward argument parsing is the unstable feature Implement argsfile, depending on the compiler version we may have to chase the options around the filesystem.
In many ways, it seems like an ugly hack of using serde in the compiler to serialize some struct containing all of the options, and setting that in an environment variable would be really nice.
But i'm not certain if that is a viable option due to adding depending on serde in rustc.

Failing auto-inference of an option, having a separate config for this crate seems reasonable. Not a great UI, but gets the job done.

Looks great to me, no need to worry about the CI errors, thanks!


Upgrade Web app to React 17

Summary
This PR addresses the React 17 upgrade, by fixing as many peer dependency errors as possible, however some libraries we use are at their latest version. We potentially need to add the --force flag to our install commands until we can replace them. Which is going to be owned by Web platform.
Ticket Link
MM-34187
Release Note
Upgraded Mattermost web app to React 17

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/265790

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/265929

https://mattermost-cypress-report.s3.amazonaws.com/265929-3f0691a-onprem-ent-webapp-pr-11558-mm-ee-test:3f0691a/mochawesome.html test report

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

/update-branch

Thanks @nevyangelova
There is an issue on the test server with rhs keeping the draft of the message that just posted
https://user-images.githubusercontent.com/52937121/204034328-c2f23922-114b-49d1-998f-6ff4b4a7c7d5.mov
E2E report has few failures that differ from master, but are not reproducing manually. I am disregarding draw plugin ones as unrelated, but DM category test may need refactoring.

@jgilliam17 this bug appears on master too. Unrelated to this PR. This PR just updates some libraries and is not introducing new behaviour

@jgilliam17 this bug appears on master too. Unrelated to this PR. This PR just updates some libraries and is not introducing new behaviour

ah, you're right Now I remember seeing this ticket filed
Do you think that the e2es I mentioned are ok, maybe just flaky?

i think so but we can run again @jgilliam17 just to make sure. New features keep coming in from master and introducing new bugs :/

I'll rerun e2es, @nevyangelova can you please fix the checks? They are not all green

all green now :)

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/266791

@nevyangelova there's an issue with cypress pipeline right now, cycle I triggered is failing to start.

/e2e-tests

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/266901

/update-branch

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/266969

/cherry-pick cloud

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
 * [new branch]            MM-48661   -> upstream/MM-48661
 * [new branch]            chore/master/update-notice-txt-2022-11-28 -> upstream/chore/master/update-notice-txt-2022-11-28
   84422cb0f5..51eb50590e  cloud      -> upstream/cloud
   6f459e895f..7ef4ee0b5a  hh_use-circleci-workspace -> upstream/hh_use-circleci-workspace
   33d602b3e5..616ce7d052  master     -> upstream/master
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#11558-upstream-cloud-1669652873
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#11558-upstream-cloud-1669652873'
Branch 'automated-cherry-pick-of-mattermost-webapp-#11558-upstream-cloud-1669652873' set up to track remote branch 'cloud' from 'upstream'.

+++ About to attempt cherry pick of PR #11558 with merge commit 94f0d29fcdfcc63c78cf16059f930f777847ea17.

error: could not apply 94f0d29fcd... Upgrade Web app to React 17 (#11558)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU package-lock.json
UU package.json
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

/cherry-pick release-7.6

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   93b09746e4..54511dcd70  Cloud_tests           -> upstream/Cloud_tests
   b60d8cafe0..7373858174  MM-43162              -> upstream/MM-43162
 * [new branch]            MM-44347_order-group-members -> upstream/MM-44347_order-group-members
   ec595eb86d..b4b6d511f1  MM-45494-edit-message-history -> upstream/MM-45494-edit-message-history
 * [new branch]            MM-48474              -> upstream/MM-48474
 + 160e109ce9...e9458d0d46 MM-48572_remove-center-channel-text-css-variable-usage -> upstream/MM-48572_remove-center-channel-text-css-variable-usage  (forced update)
 * [new branch]            MM-48609              -> upstream/MM-48609
 * [new branch]            MM-48727_restore_license_check_sso_for_selfhosted -> upstream/MM-48727_restore_license_check_sso_for_selfhosted
   ca9036ebc3..c3e9d4d88a  cloud                 -> upstream/cloud
   84a0f5878a..a3a4c84ab7  e2e-test-only         -> upstream/e2e-test-only
   c45435ea4d..924e5761a6  feature/compass-ui    -> upstream/feature/compass-ui
   f34e4885d3..0beca414b7  mm-47648-check-license-expandable -> upstream/mm-47648-check-license-expandable
   a62124cc86..b754f449bc  mm-47860-air-gapped-upgrade-modal -> upstream/mm-47860-air-gapped-upgrade-modal
   a1b72cb3df..681f7dd836  persist-notifications -> upstream/persist-notifications
 * [new branch]            post-comp-e2e         -> upstream/post-comp-e2e
 * [new branch]            release-7.6           -> upstream/release-7.6
   d4992a7bea..032ea4f0fb  self-hosted-accounts  -> upstream/self-hosted-accounts
 * [new branch]            self-hosted-accounts-cherry-pick-air-gapped-modal -> upstream/self-hosted-accounts-cherry-pick-air-gapped-modal
 * [new branch]            use-asset-re          -> upstream/use-asset-re
 * [new tag]               cloud-2022-12-01-1    -> cloud-2022-12-01-1
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#11558-upstream-release-7.6-1669900557
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#11558-upstream-release-7.6-1669900557'
Branch 'automated-cherry-pick-of-mattermost-webapp-#11558-upstream-release-7.6-1669900557' set up to track remote branch 'release-7.6' from 'upstream'.

+++ About to attempt cherry pick of PR #11558 with merge commit 94f0d29fcdfcc63c78cf16059f930f777847ea17.

error: could not apply 94f0d29fcd... Upgrade Web app to React 17 (#11558)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU package-lock.json
UU package.json
UU packages/mattermost-redux/src/actions/drafts.ts
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.


Add a few tests

Adds a few more tests

Codecov Report

Merging #733 into master will increase coverage by 2.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   61.65%   64.58%   +2.93%
==========================================
  Files           5        5
  Lines        1090     1090
==========================================
+ Hits          672      704      +32
+ Misses        418      386      -32

Impacted Files
Coverage Δ

datahandling.py
46.34% <0%> (+0.91%)
:arrow_up:

chatcommunicate.py
71.81% <0%> (+19.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663afc3...af44fed. Read the comment docs.