Plans/roadmap of .NET Core 2 Support?

Kicking the .NET Core 2 tires and noticed this library requires Microsoft.AspNetCore.Mvc.Core < 2.0.0.
Are there plans for 2.0.0+ support?

There is. There was a request for support during the preview, which is officially published to NuGet (as prerelease package). Looks like 2.0.0 was officially released on Friday. I'll carve out some time to get the official support out this week. Thanks for the heads up.

I look forward to it. This is the only dependency that needs to go RTM before we can switch to .NET Core 2.0 completely.

@commonsensesoftware That's great to hear! Any updates? 😃

Sorry guys, I was out of town this last weekend. Despite the celestial event yesterday, I wasn't in the path of totality and the stars only reached 85% alignment. =P
I ran into a few tooling issues with the update to VS2017 15.3 and .NET SDK 2.0. The build is working, but the test coverage is incomplete. I'm things will probably work, but I'd rather not blindly publish an official release without 100% verification.
I expect this should only take another day or two. I'll post back to this thread once the package has been published. I know everyone is excited to move to 2.0. Thanks for your patience.

👂

I'm anxious for the new version too! Any updates?

Looking forward to .Net Core 2 support. Keep up the good work.

I know many of you have been champing at the bit.  Hold your breath ... wait for it ...  There were a number of landmines to navigate that were more tooling changes due to .NET Standard 2.0 and Visual Studio than ASP.NET Core. I'm happy to report that I've resolved the last of the issues and everything builds and passes the tests the way that it should. :)
The new packages will be published today! I'm preparing the packages and release notes as we speak.
You can expect to see things in about an hour or so. I'll post back here one final time before I close it out to let you know that the packages are available.

v2.0 is officially out.

Release notes
API Versioning package
API Explorer package

@commonsensesoftware Thank you so much!


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #5.
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Curious if there's anything that needs to be done here to get py38 packages?

Long shot, but if @chrisburr is still interested...?

Did you mean to ping me or someone else?

Curious if there's anything that needs to be done here to get py38 packages?

This is a noarch: python package so there is no need for a dedicated build for Python 3.8.

Hi, actually meant to ping you since I thought you opened this issue. Thanks for letting me know!


upgrade glow to 0.12

would be nice to have a new version of three-d published with glow 0.12

egui is also still on glow 0.11 which makes it a tiny bit difficult to update.

I'll publish a new egui_glow in the next few days (maybe even today)

https://github.com/asny/three-d/pull/326

can we get a new crates.io release with the new glow version?

three-d version 0.15.0 has been released 💪


Fix a broken link

Description
Changes proposed in this pull request:

Fix the link to the Issues with APIRules and Service Connection doc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Apply NodeTool at start of Job

Describe the solution you'd like
When setting the Node Environment via the build options. The NodeTool is only run before NPM dependencies are installed.
This means the node environment in scripts like appcenter-post-clone.sh will have access to the latest node and npm versions.
Following https://docs.microsoft.com/en-us/appcenter/build/custom/scripts/#post-clone managing dependencies yourself is recommended (and necessary for support with some monorepo frameworks). However the node environment is not as correct at this point.
Please can we move the NodeTool to the start of the Job, so the scripts can use the correct node & npm versions

From another perspective, this could be seen as a bug


Support https://github.com/Azure/go-amqp stable version

Hi 😄,
Currently v2 amqp protocol is making use of Azure/go-amqp version 0.17.0. The package is already in version 1.0.5.
This is causing constraints in upgrading the cloudevents package on our side since we can only do it when cloudevents upgrades it.
Thanks

Hi, sure! I am currently working on this with another member and will provide a pull request.
We are in the testing phase to make sure compatibility on the functionalities!
Thanks for the quick response!


Shortcut for Copy Node Path sets clipboard to incorrect values

Godot version
3.5 RC6
System information
Windows 10
Issue description
Manually copying a node's path by right-clicking it in the editor and selecting "Copy Node Path" will correctly copy the node's relative path to the clipboard. However, using the shortcut Ctrl + Shift + C will set the clipboard to a property path ("display/window/stretch/aspect", in my case). It appears to be the last modified property, or the last focused property.
Steps to reproduce

Modify a project settings property.
Close the project settings.
Use Ctrl + Shift + C on a node within a scene's tree.
OS Clipboard will contain the property path, rather than the node's path.

Minimal reproduction project
No response

Duplicate of https://github.com/godotengine/godot/issues/62866.


Update README.md

@ousnik @sukkritsharmaofficial
Added a badge and connected the License.

I have fixed some minor bugs in home page #20
Performed AndroidX integration #10
Created the Bottom Navigation Bar #21

I have added About Us screen for the issue: #24

@himanshusharma89 Aren't those issues assigned to someone else, why are you adding them in this PR? I don't think it's a good idea to hog on others' issues mate.

@rabeehrz Well someone is getting offended, If this is the case then I'll remove the Bottom Navigation Bar.

@smaranjitghose can you merge this PR and give me the points.


Generated copyWith method not accepting properties of a base class

Hi there,
great package.
I've gone through the polymoph_copyWith example, and, although you shouldn't conduct tests on live animals, that example is easy to understand and everything seems to be generated as expected.
The reason I'm writing to you is that in my case the properties are not available in the generated copyWith method and I'm not sure why.
Here are some nice images with lines of code that depict how I have it set up.
Base class:

A subclass:

Generated copyWith parameters:

Example for "the other end of the rope", the component's copyWith should have access to all these properties:

More info can be provided and any help would be appreciated.

I got it right after I posted the issue: the copyWith method will have all the fields common to all subclasses and, after that dawned on me, I added many properties found in the Component class to the UnsupportedComponent class so that the constructor now looks more like the TextFieldComponent constructor and copyWith now accepts more properties.
Thank you!


Support Reflection

Supporting reflection would allow service developers to test and experiment using tools like grpcurl. Other SDKs contain the the ability to register the reflection service ... is there a timeline for this or is anyone actively working on it?

Hi @autodidaddict
We have no plan for this now, but this is a cool suggestion.
Can you give us some ideas about what needs to do if we support this feature?

Reflection is supported in the Go and .NET SDKs for gRPC, I'm not sure about the other SDKs since I don't use them. But it's fairly straightforward - they provide an implementation of the reflection service PROTO and then provide some way for developers to host this reflection service alongside their actual service on the same port. With this in place, we can use tools like grpcurl to query, identify, and obtain metadata on our services. Having this reflection ability makes our services far more tooling-friendly, which in turn lowers the barrier to resistance of gRPC over something like REST.
The reflection service is basically just this:
service ServerReflection {
  rpc ServerReflectionInfo(stream ServerReflectionRequest)
      returns (stream ServerReflectionResponse);
}

If you look at the other SDK implementations, you'll see that they basically just do a switch on the request type and return the appropriate data. In the .NET implementation, there is a descriptor generated into the gRPC C# file which provides access to metadata and the original proto IDL, and these descriptors are then passed to the reflection service implementation that comes with the SDK.
Here is a link to the .NET service implementation of Reflection.
Here is where the Go SDK implements reflection.

Here's a list of the operations that a client can request of a reflection service (you'll see this as an enum in the Reflection proto):

Ask for a proto file by filename
Find a proto file that contains the supplied fully-qualified symbol name
Find a proto file that defines an extension that extends the given message type with the given field number
Find the tag numbers used by all known extensions of a message type
List the names of registered services

Some SDKs return StatusCode::NOTIMPLEMENTED for some of these (.NET doesn't implement "file containing extension" and "all extensions" request types)

TL;DR - if the service implementation has access to a map of filename->proto IDL, then it can support the bare minimum reflection functionality


Argument $variable is missing from the Docblock of method

I am getting an argument missing error for the first argument of every method with arguments. Here is a copy of my doc block and method.
/**
* Sets configuration flags.
*
* @param String $flag The name of the flag to set.
* @param Boolean $value The value of the flag.
* @param Boolean $auto_run Whether to execute Config::run() after setting the flag.
*/
public static function setFlag($flag, $value, $auto_run = false) {
$value = !!$value;
    if ($auto_run && $value == self::varDefault(self::$flags[$flag])) $auto_run = false;

    self::$flags[$flag] = !!$value;
    if ($auto_run) self::run();
}

Anyone to pick this?

There is currently no branch for version 2.8.x to do a pull request against it, right?

All changes that need to be deployed as part of 2.* can be PRed to Master; develop is used for the work on version 3

Thanks @sascha-egerer for helping us out! I have just merged the PR that fixes this issue and it will be included in the next 2.8.* release

Actually I am using 2.8.1 version. I am having following issues. I am new for phpDocumentor
Error :Argument $ni is missing from the Docblock of investment()
this is the function I have
/**
 * set investment
 * @param string $ni
 * @param string $pd
 */

public function investment($ni = null, $pd = null){
......
}
When run in command I am getting the files with error report. I searched so many times I cant find the solutions. Any body please help me out.

I just upgraded to 2.8.2 which definitely has the PR applied. Ist seemed to work at first, but after deleting the cache all those messages appeared again :-(

The problem still exists with 2.8.2


Add Japanese translations

For more info on this PR please check blockchain-certificates/wallet-iOS#60
Feel free to let me know if there's anything I can improve!

Thanks @akodate! We have someone on our team that knows a bit of Japanese, might if we wait until tuesday for him to spot check?

Sure no problem @AnthonyRonning
Tuesday's not that far away

Hey @AnthonyRonning I was just wondering if your teammate was able to take a look?


anchor-has-content issue

Something as simple as This is a piece of text is giving me the Anchors must have content and the content must be accessible by a screen reader. error. It works if the children is a node rather than text.
Currently using<EMAIL_ADDRESS>and the latest version of this plugin.

Since eslint 5 is not yet released, it's highly likely that any plugin might not work with it yet.
When it's released, we'll address it. Thanks for the report!

I'm seeing this on eslint v4 as well. I think this is related to #440.

@openjck thanks; in that case, this is a dupe of that :-)


Update pyqir dependecy to support macOS with M1 processors

qiskit-qir version: 0.2.0 (and today's main)
Python version: 3.8
Operating System: macOS with an ARM processor (M1)

Description
Following https://github.com/qir-alliance/pyqir/issues/101#issuecomment-1343254900 and pyqir v0.7.0 release, qiskit-qir can support macOS with M1 processors.
To achieve this, the fixed requirement on pyqir has to be updated or relaxed:
https://github.com/microsoft/qiskit-qir/blob/f997d88f8f18dcecbedcb9cb4364961a36d0a9dc/setup.cfg#L33

Also, it's probably desirable to replace pyqir-generator with pyqir:

pyqir-generator has been replaced by pyqir
Please install the pyqir package instead, which provides the same functionality.
Read the upgrade guide for help with upgrading from pyqir-generator 0.6.

https://pypi.org/project/pyqir-generator/

@jond01 - #32 should address what you've outlined. We're moving to PyQIR 0.8

@jond01 Can you please try 0.3.1 which is now available on pypi? The API has change to to_qir_module allowing you to work with the module, get its bitcode, or IR as you wish.

Great, thanks! The main thing left is propagating this update further to the azure-quantum package: https://github.com/microsoft/qdk-python/issues/410.


Archiving fails silently on unknown suffix

We silently fail to create the archive if we pass in an unknown extension such as .tar.gz.   or .blah the code in collector.go:archiveDiagDirectory is not dealing with the unknown extension and silently fails.
We should clean up any suffix spaces and also inform the user if they try to use an unrecognised suffix, perhaps defaulting to .zip

This can also cause cleanup of the temp files giving the user the impression that we did not copy any files

we have standardized on using tar.gz for everything, will remove the other options


How to manage the server(asking prior installation)

First just surfing the web and found this project.All looks attractive to me and thanks for continuous commiting on the project.
However although I saw readmes and configuration files that allows installation of the server,I didn't see guides for administrative actions.
I'd appreciate it if you can point out how to achieve the following actions:

[ ] How to claim server admin role after spinning up the server
[ ] How to do server management actions.Is it a special command or some interface?
And finally,just to satisfy my curiosity,is the supported plugins in the readme already installed or where should I go to get these plugins and how to install them?

For server admin you can simply use the elixir console and invoke the respective functions, such as Channel.make_admin, Channel.grant, etc. Once permissions have been granted, some server administration can also be performed through the Lichat protocol using the shirakumo-server-management extension among others.
The extensions list is the list of specified protocol extensions that the server supports out of the box. There's no plugin mechanism at all at the moment.


Update metabase-app to <IP_ADDRESS>

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as ddf375c4e464ce11b9124b94ecafc6e6221cba8c. Your contribution is still credited to you.


RIO-39 feat(really-core) Push Operator Info in Updates

Can one of the admins verify this patch?

ok to test

Refer to this link for build results (access rights to CI server needed):
http://ci.really.io//job/really-pr-validator/68/
Test FAILed.

ok to test

Refer to this link for build results (access rights to CI server needed):
http://ci.really.io//job/really-pr-validator/69/
Test PASSed.


cleanup && typos

Describe the PR

fix some typos
small formatting fixes

Relation issue
NONE.
Additional context
NONE.


this.container.singleton is not a function

throwing error on running node ace queue:job SendWelcomeEmail

hi, what could be a temporary fix this? thanks


radix.cpp

I hope this time it is okey. If it seems okey to you then please merge it.

Good !!!!! keep it up


ECCV16 and SIGGRAPH17

Hello. I am new to image processing and this is very interesting. I used the algorithm obtaining very different results with each colorizer. I wanted to know what is the difference between them. Thank you!

Please refer to the papers and accompanying materials. Thanks!


Enable ability to zoom on images (both forecast and observations)

Today if you try to zoom in by two finger touch or double tap (common way all other apps to this) nothing happens. Images are smaller size on the screen so it is hard to at times to make out details (crowns/etc) without zooming in.

Done in #228


KFF_US_STATE_MITIGATIONS.BAR_RESTAURANT_LIMITS data went NULL

Describe the bug
KFF_US_STATE_MITIGATIONS.BAR_RESTAURANT_LIMITS data went NULL
To Reproduce
SELECT BAR_RESTAURANT_LIMITS FROM KFF_US_STATE_MITIGATIONS;
Expected behavior
Data should match source... https://www.kff.org/other/state-indicator/state-actions-to-mitigate-the-spread-of-covid-19/?currentTimeframe=0&selectedDistributions=restaurant-limits&sortModel={"colId":"Location","sort":"asc"}
... and is there a QA tasks to prevent clearing out entire columns?

I believe this might be due to a change of column names in KFF.  Today, they have named this column Restaurant Limits, notice the elimination of 'Bar'

Would really appreciate it if this column could be remapped ASAP. Retaining the current column name BAR_RESTAURANT_LIMITS would also help.  Many thanks!

Thank you @piglerp !!

Should be fixed by now via #244


May 2019 Git Stats (fun media push)

Ryan,
As mentioned before, lets start the creation of a fun summary of what went down for May via git issues with focus on individual Contributors.
Wording: lets work on it after we see design- added a pic with the stats to be used as the baseline.

Google Forum Members: 1134

Who is involved, 3 months Git stats

May 2019 Commits (163 commits)

March, April, & May Individual Contributors summarized by the collection of the 8 pictures from the stats added as 1 JPG pic

@rstjames ticket is updated with May stats. Please follow up with design using pic and pull me in once that is ready for quick efficient description of the tweet. thanks!

@rstjames can you create the media tweet so that we can close this May activity ticket?

this initiative seems to have not traction, closing ticket.


No test result output of running test after upgrading to 1.3.0 and newer

I've used karma-mocha-reporter-1.1.5 for a long time. During an update of my system, I've upgraded also to the latest version. Since than I don't see any test results during running the tests.
I've played around with several reporter versions and it seem the "issue" was introduces with 1.3.0. Older versions are working, newer not. You have changed the behaviour of printout in 1.3.0 if multiple browsers are running the tests in parallel. I've only one browser which I connect manually to karma to run the tests. Seems there is something broken. Or do you have introduced a setting which may prevent the output?

The change in v1.3.0 was that the reporter waits that all browser have run a test before printing an output for the test. (https://github.com/litixsoft/karma-mocha-reporter/commit/3342eb8008c620c5b6146c899b45ef5d9559abbb)
Maybe you have an example of your test so that I can reproduce the problem.

not sure how to give an example. Try to strip down the test suite.
What I do, I start karma on my developer machine and connect from another system with a chrome browser to the running karma instance. In my opinion nothing special :)

Not sure whether I should open a new issue for this, but.. I also see no output with the latest version of this reporter (2.0.3) and Karma 0.13.20. However, If I downgrade Karma to 0.13.19 (or lower, I tried a few) then it works again.
Seems like some of their latest changes introduced a bug, or changed some internal behaviour.

Thanks for information @tatablack. I will check the problem with different karma versions.

I tested with some versions of karma below 0.13.20. But i still cannot reproduce the problem. Maybe you can send me a karma.conf.js file and the corresponding spec file. @renegart @tatablack

Sorry, maybe I wasn't clear.. with versions of Karma below 0.13.20 it works. With 0.13.20 or 0.13.22, for example, it doesn't. Let me know if you still cannot reproduce, I'll see if I can put something together.

I still cannot find an issue. It also works fine in travis (https://travis-ci.org/litixsoft/karma-mocha-reporter/jobs/128496141)
Maybe you can just clone this project locally and run npm install and then npm test. Just to see if this problem specific to your computer or project.

Hey @tatablack,
do you still have the problem?

Sorry, for not answering. I've overloaded with tasks at work at the moment. When I find some minutes next week, I'll send you a config file.

I've written a very small reproducer.
It contains a test file, a karma config and a text file which contains the expected output and the output which I get with<EMAIL_ADDRESS>You'll see the test result are not printed, you see just the summary.
Steps to reproduce:

start karma on 'developer system'
start browser on 'test machine'
connect running karma server with 'http://:9876

mocka_reporter.zip

Thank @renegart for your investigations. I was able to reproduce the problem with your files. Fix released as v2.0.4


mention import in spawning process docs

Thanks! Will go out next release which should be in a few days


NOISSUE - Add RUL Turbofan example

The RUL (Remaining Useful Life) Turbofan AI algorithm is a predictive maintenance tool designed to estimate the remaining operational lifespan of a turbofan engine. By analyzing historical and real-time data from engine sensors, the algorithm predicts when the engine is likely to fail or require maintenance. This helps in optimizing maintenance schedules, reducing downtime, and preventing unexpected failures, ultimately improving operational efficiency and safety.

Please remove datasets from the PR - it should contain only model, prediction, tools, etc. Datasets should be public and downloadable from Kaggle or similar. Explain in the README how to download datasets and where to put them.


fix(request): duplicate line prevented display of debug message

Can you add a new changeset with pnpm auri add?
https://lucia-auth.com/contributing/#changesets

Done

Thanks!


Make OAuth follow-up pluggable

At the moment, the code used to receive an OAuth provider response and to turn it into a set of roles is a hard-coded set of supported services. This should come in via a plugin architecture instead.

@stefanw this can now be done via plugins, let me know if you want to sit down some time and set up such a thing.


Remove space between encoded words

https://tools.ietf.org/html/rfc2047#section-2

An 'encoded-word' may not be more than 75 characters long, including 'charset', 'encoding', 'encoded-text', and delimiters.  If it is desirable to encode more text than will fit in an 'encoded-word' of 75 characters, multiple 'encoded-word's (separated by CRLF SPACE) may be used.

Fixed with AST and Evaluator in v0.1.1.


convert-mris: SyntaxError: from future imports must occur at the beginning of the file

> mirtk convert-mris
  File "/Users/as12312/Software/MIRTK/Maintenance/Xcode/lib/tools/Release/convert-mris", line 40
    from __future__ import absolute_import, print_function, unicode_literals
SyntaxError: from __future__ imports must occur at the beginning of the file
Error: convert-mris command returned non-zero exit status 1

This error is caused by Python code added by BASIS during the build of the script file. This had been taken care of by BASIS to ensure that these import statements are coming first, but it seems this doesn't work any longer... see cmake-basis/BASIS#217 though no reference to the specific commit is given. There is a test in BASIS which is supposed to ensure that it is still working.

This issue is due to the following CMake regular expression used by BASIS to extract all code until the last future statement:
^(.*from[ \t]+__future__[ \t]+import[ \t]+[a-z_]+([ \t]+as[ \t]+[a-zA-Z_]+)?[ \t]*\n)(.*)$

which does not consider a statement with comma-separated future modules. The following simplified and less restrictive regular expression works:
^(.*from[ \t]+__future__[ \t]+import[ \t]+[a-z_]+[^\n]*\n)(.*)$

Fix introduced another bug...

...which has now been fixed.


onValueMouseOver event in LineMarkSeries component cannot be triggered after adding Highlight component

After adding Highlight component, there is a "rv-mouse-target" div created by Highlight component, all events from LineMarkSeries cannot be triggered. If I change its "pointer-events" css to None, LineMarkSeries back to working, but Highlight stops working

I have the same issue. When I try to use both either one is working at a time. Along with this onValueMouseOver has one more issue like when I have LineMarkSeries implemented, onValueMouseOver callback is not getting triggered for few LineMarkSeries. Don't know in what basis it is happening.

@renhax did you try flipping the rendering order, i.e. render <Highlight /> before all the <LineMarkSeries />s ?
@nehruji , check out my PR: https://github.com/uber/react-vis/pull/1152
If you want the fix without using the forked package, just add:
lineStyle: {
  pointerEvents: 'none'
}

to each of your LineMarkSeries props.

This seems to happen with other situations too, if I order the  in front of  or , it blocks access to pointer events.  If I order  to draw behind LineMarkSeries / MarkSeries with pointer events, it is hard to get the ability to draw the Highlight.  Additionally, if I simply put pointerEvents: 'none' -- it is helpful, but if you were to draw your Highlight square, and run the mouse into an pointer event of a LineMarkSeries/MarkSeries, it causes the Highlight square to pre-maturely stop drawing.


Framework-diagram

Why was this created??

@cnakalembe Are there any actions associated with this issue? Can it be closed if not?


Bunch of my old issues just got marked stale, what should I do?

Most of them are just things which petered out, but (AFAICT) are still actual issues. Should I make a bump comment, or something?

Any activity on them clears the stale label, but preferably don't make bump comments. It's much better to check if the issue is still valid and inform maintainers about it, provide a self-contained example which reproduces the issue, or make sure the existing example still shows the bug.


grabbed human position fix

When a human is grabbed by a titan, human position wasn't being updated locally, it was being updated remotely, which caused it to look like this

So Here is the fixed version.

@AutumnThyme Done


fix(package.json): Fixing typo

:tada: This PR is included in version 2.2.7 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Switch retrofit2-clients from using gson to jackson.

@uschi2000, did you intentionally pick Gson over Jackson? Think we should've taken Jackson.

I don't actually remember who made the first retrofit client. If it was me, then it was not intentional.

Thomas, which Jackson version does this bring in?

In related news, I really need to change to nebula for dependencies so we have some accountability around library versions.

This brings in Jackson 2.7.2. Seems that we explicitly specify 2.6.1 so I can force this version

No, that's fine. Thanks Thomas.
On Tue, Jul 19, 2016 at 8:44 AM iamthomaspowell<EMAIL_ADDRESS>wrote:

This brings in Jackson 2.7.2. Seems that we explicitly specify 2.6.1 so I
can force this version
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/palantir/http-remoting/pull/169#issuecomment-233674841,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGOdwbzZDRNd8-fHscngskrMVT69Fj7eks5qXPCqgaJpZM4JPsJZ
.


Could you publish the NuGet package

This project looks good, can it be released as nuget package?

It is, as a prerelease while I run it through more testing.  You should be able to find it here if you are interested.


feat: create heading components

These are already styled from typography.ts

where's my heading stories


Use sbt-conductr 2.0.1

Bumping the sbt-conductr version to 2.0.1. The new version includes the sandbox so it isn't necessary anymore to add the sbt-conductr-sandbox plugin additionally.
This version also simplifies the build.sbt quite significantly.

Nice! Will merge as soon as the PR is green

Wonderful!


raidboss: Delay Diamond Weapon callouts

As pointed out in a reddit thread, the east/west callouts in Diamond Weapon happen before the visual cue, which wasn't intended and isn't really fair. Update them to coincide with the visual callouts.

Hmm.  I'm not sure I want to get into a policy of trying to line up abilities with what people perceive to be the beginning of the visual clue.  I think these are extremely bread and butter starts using triggers that anybody could write with even an act custom trigger.  I'm inclined to leave this as-is.

I bring this up not just because of the reddit thread, but also because of the previous conversation on #2329

I think what's primarily over the line about #2329 is that it's not something that anybody could call out given the information on screen.  I think secondarily, it's also a complicated trigger that is not "just" a startsUsing trigger on something in a log line that anybody with basic trigger writing knowledge could write.
I think when writing triggers, I would rather have people think about what the best time to call something out is to be helpful (e.g. not conflicting with other triggers, not so soon it's forgotten, or not so late that it's a scramble to address) rather than trying to evaluate and police on a per trigger basis what is "fair".  My inclination here is to say no to including triggers by default that are over that line, and leave everything else in the grey area as-is.

Tbh i am happy about the early callout.  If u use cactbot then the time for "non cheating play" is already gone. So from my view, this does not matter at all anymore.
Beside that i changed the callouts to red and blue because E and W just confuse me xD


Video stop playing in ios

Bug
Platform
Which player are you experiencing the problem on:

iOS

Environment info

Library version: 5.2.1
Device: all ios devices
Steps To Reproduce
When set uri to player it works ok in android but in ios it play for 2 second and then stop playing. On click of video i added this code videoRef.current.seek(0); and by using this code it start playing from starting and then it works in repeated mode without any issue for that same video. But again if i play any other video it stop after 2 second and on click it works without any issue.  The same thing wok on on ios simulator
<Video
ref={videoRef}
source={videoUri}
style={getVideoViewStyles()}
controls={false}
resizeMode={'contain'}
onLoad={onLoadEnd}
onProgress={onProgress}
onEnd={onEnd}
ignoreSilentSwitch={'ignore'}
paused={paused}
// repeat={true}
/>
Expected behaviour
Video should play without stopping

Can anyone have any solution for this?

can you reproduce on 6.0.0-alpha.8 ?
You should have a look to system trace to get more informations and also catch onError message, it can bring interesting informations

I did't get any solution from the library but now i fix it by adding timeout in screen to load video. I am loading video controller after one second and video is playing without any issue.

Thank you, so we can close this issue ?

Yes, You can. thanks

Yes Sure, Thanks


Error messages from Java logging printed to the console when running Ballerina programs

When a wrong configuration value is given in the <BALLERINA_HOME>/bre/conf/logging.properties file, an error message from the Java logging framework gets printed to the console. To reproduce this issue, change the log level of the logging.properties file to the following:
java.util.logging.FileHandler.level = WARN
Then, try to log a message using a simple Ballerina program such as the following:
import ballerina.lang.system;

function main(string[] args) {
	system:log(3, "test log 1");
	system:log(4, "test log 2");
}

The following error is printed to the console when running the above program:
Bad level value for property: java.util.logging.FileHandler.level
Can't set level for java.util.logging.FileHandler

Closing this issue since this irrelevant now with the new log API introduced in PR #2748


chore: Add snaps for Table Widget

Summary by CodeRabbit

New Features

Introduced a disableScroll property to the table widget, allowing users to disable scrolling for tables.

Bug Fixes

Adjusted table column width calculations to account for border width, ensuring consistent table layouts.

Tests

Added test cases for the Anvil Table Widget in various modes (Canvas, Preview, Deploy) to ensure consistent behavior.

Style

Updated table widget styling to support the new disableScroll property and adjusted border styling for table rows.

Merged here.


DisplayPicture: Add individual commands to add and delete displayPic

It might be a hassle to some people to use add and edit the displayPic.
Will add separate commands to add/edit and delete the displayPic.

Added in #102


Finished Initial Version of Home Page

This Refactored home page pull request  is a reference to this issue:
https://github.com/OregonStateUniversity/osu-fsf/issues/96
Changes Made:
Created a card format for each of the events that the signed-in user is signed up for. These cards are shown in a vertical list format, with each card showing the event name, event banner, the team score, and the top two participants with the highest score for that event.
Something left to Implement:
If the card is clicked, then it should redirect the user to that respective event. Should be simple to implement.

For anyone reviewing this I don't think it's ready for a merge.  He is still working on it.


bpf: clean up CB_NAT

CB_NAT is no longer used. Instead just define a generic CB_3 placeholder.

/test


Need to open dialog in a new tab and chrome browser

Hi,
Code working fine and great !!!!!!!!
Actually dialog box opens inside the tab but we need dialog box should open in a new tab. In IE it works opening in a new tab.
Could you please help on this issue

Any comments please

How can i open same dialog outside frame or frameset ..? Could you please help

You can just use window.open() in such case.


deepin.deepin-kwin: 5.25.11 -> 5.25.12

Description of changes
https://github.com/linuxdeepin/deepin-kwin/compare/5.25.11...5.25.12

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test deepin

https://github.com/NixOS/nixpkgs/pull/272406


Updated to Swift 4.2

I added Swift 4.2 support to Slope. It didn't require any code changes so I just updated the podspec, README, and CHANGELOG.
Thanks for the library, its made my app look much nicer!

Thanks for the kind words. I checked out the updates and will merge it in.
Thanks again!


Suppress individual warning messages [Feature Request]

I would like a way to suppress individual warning messages, those that I've seen before, and for whatever reason, were not/will not be addressed.  Why? Because each time I see that message again, it takes some time to mentally process it and remember that was something that can be dismissed "Oh, I've seen that one before - never mind."
How to do it? Not sure, but here are two possibilities

Put a "ignore" tag in the source SHR file (this is what I'm doing now, just to remind myself that I've looked at an issue previously)
Have a filtering file where ignorable messages can be stored (can we hash code each message to uniquely identify it???)

We've discussed that each type of possible error message should have a unique identifier or key.  If we had that, then I think we could easily create a file that indicates warnings to suppress.  For example, one line might looking something like:
shr.core.Duration: PARENT_MAPPING_MISMATCH

Putting comments in the source itself is also a valid approach, although I wonder if that would start to look cluttered.

This is being worked by Gary, and well on its way to completion. Closing this feature request.


Formsy TextArea

Do we have formsy textarea components?

The FormsyText component has a "multiline=true" attribute you can use.

Formsy handles form logic. The material-ui component library is its own thing. This project bridges those two projects so that they work together smoothly.
The thing you're asking about is the material-ui component library: Those docs are here: http://www.material-ui.com/#/components/text-field.


Split simple partial test classes

This splits all our "simple" tests, which are currently in a single class (split across files via partial), into separate classes.
Still TODO: set up the Northwind database exactly once for all suites. xunit supports "shared context" via the concept of test collections, but this also has an impact on parallelism. I've posted a question on stackoverflow, @AndriySvyryd @maumar any ideas on this?

Based on benchmarking I did a while ago, there is not much need to run them in parallel time-wise though it would be good to have.
Given we already have different test classes using NorthwindFixture which are running in parallel, according to @AndriySvyryd infra should already be capable of running them in parallel without anything specific to be done.


Generation not working on version 1.2.0

Generates this only as the output when using the model tinyllama-2-1b-miniguanaco.Q3_K_L

Link to the model here: HF link

Ok #339 should fix this. Still getting some artifacting but at-least you can have an output now

Still having the same issue.

Still having the same issue.

Any change in the output at all?

Still having the same issue.

Any change in the output at all?

No change.

Got the same problem but with remote Ollama.

Generates this only as the output when using the model tinyllama-2-1b-miniguanaco.Q3_K_L
That model is super weird, i dont get any output even on desktop even when other models work fine

Generates this only as the output when using the model tinyllama-2-1b-miniguanaco.Q3_K_L

That model is super weird, i dont get any output even on desktop even when other models work fine

This model was able to output stuff in the previous versions though.

Generates this only as the output when using the model tinyllama-2-1b-miniguanaco.Q3_K_L

That model is super weird, i dont get any output even on desktop even when other models work fine

This model was able to output stuff in the previous versions though.

Ok well this is an issue with llama_cpp_dart so ill close it here and move it over there

Transferred https://github.com/netdur/llama_cpp_dart/issues/26

Not sure if generation is very slow or it simply isn't working but the loading indicator is shown for a long amount of time when tried with tinyllama-1.1b-1t-openorca.Q4_0. Maybe I should start a new issue?

@RookieIndieDev ok give https://github.com/Mobile-Artificial-Intelligence/maid/actions/runs/8127833802 a go and tell me how you go.
Its a new implementation so its not ready for a release yet and i still need to work on removing the user prompt from the output but you should be able to gauge the performance

@RookieIndieDev ok give https://github.com/Mobile-Artificial-Intelligence/maid/actions/runs/8127833802 a go and tell me how you go.
Its a new implementation so its not ready for a release yet and i still need to work on removing the user prompt from the output but you should be able to gauge the performance

Says the APK build failed?

ahh yeah sorry gimme a sec

@RookieIndieDev ok try this one
https://github.com/Mobile-Artificial-Intelligence/maid/actions/runs/8128111631

Tried both on Windows and Android. Android crashes immediately after pressing the send button, ON Windows it does nothing, just stays there with the loading button without any CPU usage or more memory being allocated when viewed in the task manager

Tried both on Windows and Android. Android crashes immediately after pressing the send button, On Windows it does nothing, just stays there with the loading button without any CPU usage or more memory being allocated when viewed in the task manager

Ok ive only tested on linux so ill text windows and android later this week

on Android , when generating text, it always crashes

Updated to 1.2.2 release (setting says 1.2.1 though), tried generating with the TheBloke/TinyLlama-1.1B-Chat-v0.3-GGUF, had it open for more than 10 mins now, it still shows the loading indicator and no output so far.

Updated to 1.2.2 release (setting says 1.2.1 though), tried generating with the TheBloke/TinyLlama-1.1B-Chat-v0.3-GGUF, had it open for more than 10 mins now, it still shows the loading indicator and no output so far.

I republished, windows should work now

Haven't tried on Windows yet but on android it's still the case.

Crashes on Windows immediately after clicking the arrow button. Tried both TinyLlama and capybarahermes-2.5-mistral-7b.Q4_K_M. Found this in the Event Viewer log:
Faulting application name: maid.exe, version: <IP_ADDRESS>, time stamp: 0x65f38908 Faulting module name: llama.dll, version: <IP_ADDRESS>, time stamp: 0x65f388c3 Exception code: 0xc0000005 Fault offset: 0x0000000000078bae Faulting process id: 0xef8 Faulting application start time: 0x01da76e8657afd7d Faulting application path: \maid-windows\maid.exe Faulting module path: \maid-windows\llama.dll Report Id: 27a306e9-3c4b-431c-9d36-afc1f890b396 Faulting package full name:  Faulting package-relative application ID:
on Windows 10


[FEAT]: Extend the GoLLM documentaper-to-equation extractor to include LaTeX equation styling

Is your feature request related to a problem? Please describe.
The document-to-equation extractor currently returns LaTeX code that adheres to the style of the input document. The equation-to-model converter is finicky when it comes to what LaTeX code it can successfully convert to a model. It becomes tedious for the user to (1) guess what styles are permissible and (2) implement the style by editing the LaTeX code.
Describe the solution you'd like
We should add a LaTeX equation styling step before presenting the LaTeX equations to the user.
Here's a guideline:
https://docs.google.com/document/d/14quVXKFewerwkJh_gTODLoqket6pLKCggNKXuXgR96I/edit

@pascaleproulx
This guideline for the LLM to restyle the equations will make the equations look different from what's in the paper.
For example, it would replace sigma notation to explicit summation:

Is the current Create model from equations sufficient to smooth over any confusion about the inconsistency between what's visible on the left input panel (the document), the center panel (the amended equations that the user edits), the right output panel (the generated model that may or may not fully adhere to the equations in the middle)?


Vim plugin: weird path behavior

Hi, There is a feature in Ctrl-P where it finds the git root if the current file is in a git directory. I tried to emulate this behavior using this function:
function FuzzyFind()
  " Contains a null-byte that is stripped.
  let gitparent=system('git rev-parse --show-toplevel')[:-2]
  if empty(matchstr(gitparent, '^fatal:.*'))
    silent execute ':FZF ' . gitparent
  else
    silent execute ':FZF .'
  endif
endfunction

nnoremap <silent> <LocalLeader>fz :call FuzzyFind()<CR>

While this correctly brings up the finder, selecting a file opens a new file (in the current directory) instead of in it's own directory.
Am I understanding FZF wrong? Is the vim function doing something wrong (I have limited knowledge of vimscript). Can someone please explain the problem? I am happy to submit a patch if I understand what's going on.
Thanks.

For me, the code you posted seems to work as expected. I have no problem opening a file inside a git repo regardless of where I am. Maybe some other config or plugins in your .vimrc are getting in the way?

@akhilsbehl What's the value of
:set autochdir?

@Junegunn: Let me try to provide a replicable example of provide some
pictures to explain the problem.
@Justin: autpchdir is set.
--
ASB (akhilsbehl.github.io)
'Personally, I am always ready to learn, although I do not always like
being taught...', Churchill.
On Tue, Jul 28, 2015 at 8:20 PM, Justin M. Keyes<EMAIL_ADDRESS>wrote:

@akhilsbehl https://github.com/akhilsbehl What's the value of
:set autochdir?
—
Reply to this email directly or view it on GitHub
https://github.com/junegunn/fzf/issues/306#issuecomment-125635737.

Hi, I can confirm that this is not a problem with FZF. Just tried this behavior with a clean vimrc with only FZF installed and it works fine. So, will close this issue.
But does anyone have a clue what may be interfering so I can get correct behavior?
Thanks.

Just realized, this problem only happens if vim is running inside tmux.

So it's basically a configuration issue, but we can take this as a chance to make fzf more robust.

But does anyone have a clue what may be interfering so I can get correct behavior?

Well, there's no easy way. You may need start with only a small part of your vimrc (with finish), and incrementally extend the region until the problem is reproducible.

For now I can get the correct behavior if I use :FZF! instead of :FZF since that avoids tmux splits. I do however get this warning everytime in vim:
W13: Warning: File "..." has been created after editing started
[O]K, (L)oad File:

Does anyone else see this?
I will try to debug this (since I will really like this working, but that will take some time). Thanks for all help.

The warning with :FZF! has something to do with buftype being emtpy. Not sure why it is being set empty even though there is content in the buffer.

Hey, sorry, turns out this is an FZF problem. The problem was not solved because of the clean vimrc but because I had added 'cd'. gitdir to the FuzzyFind() function.
I have a question: does the plugin work by opening a buffer and pasting the contents of the actual file into that buffer? Because if so, I think that is the part where the problem lies.
Also, I think the fact that tmux can't seem to find the file and the W13 above are related to each other. I am not going to reopen this since I can not give you a reproducible example. But it will probably help if you can give a high-level overview of how the vim plugin works.
Thanks.

I have a question: does the plugin work by opening a buffer and pasting the contents of the actual file into that buffer? Because if so, I think that is the part where the problem lies.

Nope.
As @justinmk mentioned, I think autochdir can be the culprit. Can you try again with the option unset and see if the problem still persists?
I actually found an issue with autochdir when selecting multiple files. When multiple files are selected, fzf#run() will open files one by one, but the directory is changed after the first file is open, so the rest of the files are not properly open.

Busy with something just now. Will get back to you after testing.
Thanks.

I pushed the fix to the problem I mentioned above. It will temporarily disable &autochdir when opening multiple files. The fix only applies to :FZF command, not fzf#run().

I can confirm that this solved my problem too. :) Any reason we should not do this for fzf#run too?

Because fzf#run does not know the context of the call and to disable the setting is beyond the scope of its responsibility. I mean, we cannot assume that the caller is using fzf#run for opening files. Something like :call fzf#run({'source': range(100), 'sink': 'echom'}) is totally valid. I know that most users will be using fzf#run for opening files and it probably wouldn't hurt to apply the fix to fzf#run as well, but in principle, it's not pertinent to what fzf#run is supposed to do.

:GitFIles will fail to get the correct pwd for opening file when set autochdir

@maple-leaf I can't reproduce the problem. Please create a new issue on fzf.vim project (not here) if you still have the issues with the latest versions of fzf and fzf.vim.


Kube-inject ignoring ignore annotation

Maybe I'm too tired: but I ran 'istioctl kube-inject -f ... ' on the 'app t' from the
integration tests ( converted to proper yaml ), as well as fortio-noistio - and I still
get it injected.
Did the annotation change ? I tested against master - but if 0.6 is affected it would be a
blocker.
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
 name: t
spec:
 replicas: 1
 template:
   metadata:
     labels:
       app: t
       version: unversioned
     annotations:
       sidecar.istio.io/inject: "false"
   spec:

The policy override annotation (sidecar.istio.io/inject) doesn't apply to manual injection. That expectation was that if a user doesn't want a sidecar injected, they won't run kube-inject over their deployment. This is tested in the e2e pilot test here.

Are you sure it didn't work before ?
The use case is for yaml files with multiple deployments and services, like
those generated
by 'helm template' ( i.e. mix of deployments).
If we confirm it's not a regression - I guess we can move this to a P2, but
for helm or
other cases where a mix of files is used, some without istio, we will
probably need to document
some workaround. Maybe a good option would better document the 2 additional
containers, for
full customization.
On Mon, Feb 26, 2018 at 5:18 PM, Jason Young<EMAIL_ADDRESS>wrote:

The policy override annotation (sidecar.istio.io/inject) doesn't apply to
manual injection. That expectation was that if a user doesn't want a
sidecar injected, they won't run kube-inject over their deployment. This
is tested in the e2e pilot test here
https://github.com/istio/istio/blob/b831fad7ac13c40b3949b9475e797f03382c8ce7/tests/e2e/tests/pilot/util/environment.go#L403
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/3774#issuecomment-368711864, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6sHWxGkjoHqn-UWGnFlnys66KXm2ks5tY1fXgaJpZM4SSrk3
.

I changed the default behavior in https://github.com/istio/istio/pull/2830. The assumption was that users simplify wouldn't run the injection command on deployments they didn't want injected. The annotation overrides the mesh injection policy (via configmap) which makes less sense if there is no mesh policy to refer to. The previous code referred to an internal hardcoded policy which may have been out of sync with the mesh anyway.

+@rkpagadala
Since the change is expected, we can just document the behavior and workaround in release notes for 0.6.0.
I am going to remove the release blocking label if there is no disagreement.

Moved this to 0.7, and changed to P1.
I think there are important reasons to do it (may be ok to push it to 0.8, but before 1.0):

consistency
use with 'helm template' or other tools (ci-cd, etc) where all yamls are pushed trough a filter
that does kube-inject
it makes it hard to install applications - the developer writing the yaml is different from the
admin applying them. If they use kube-inject - the admin would need to know which can be injected and which not ( by reading docs ? Or looking for the annotation ?). Easy to make mistakes.


Add option to start backdoor with boot

Run update-rc.d to add commands to startup

would be an awesome module

Add it to bashrc as well?

Would also be great!


[Desktop] Clicking on desktop notification causes active chat window to stop updating.

You no longer see new replies or messages you type and send until you click out of that conversation and back into it. Works fine if you open the window from the taskbar instead.

I also have this issue
Nothing I do gets the message list on the left to update.
If I miss a message coming in via notification I can't go find it in the BlueBubbles App?

I'm also having this issue, exact behavior as described previously in this thread.

If one of you could install the beta version from https://github.com/BlueBubblesApp/bluebubbles-app/releases/tag/v1.13.0%2B63 and let me know if the issue is still present, that would be great.

If one of you could install the beta version from https://github.com/BlueBubblesApp/bluebubbles-app/releases/tag/v1.13.0%2B63 and let me know if the issue is still present, that would be great.
Isnt this an old version

If one of you could install the beta version from https://github.com/BlueBubblesApp/bluebubbles-app/releases/tag/v1.13.0%2B63 and let me know if the issue is still present, that would be great.

Isnt this an old version

Nah, that's hot off the press

If one of you could install the beta version from https://github.com/BlueBubblesApp/bluebubbles-app/releases/tag/v1.13.0%2B63 and let me know if the issue is still present, that would be great.

Isnt this an old version

Nah, that's hot off the press

hm ok

HI @cameronaaron I installed the beta 1.13.0 for windows desktop it and it's still an issue.
My server is running 1.9.6 if that makes any difference...

an updates on this issue? looks like the window store still hasn't updated past 12.7 so i'm not sure if it's been corrected.

This seems to be fixed for me. I haven't updated the app since the beta 1.13.0, but a few other things have changed:

Installed some windows updates
Changed theme from iOS to Material
Manually Adjusted the time on my work computer - the time server used by IT staff was a couple minutes slow. I suspect that this is the most likely cause of the chat window not updating.


Release updates

Docs Build status updates of commit 14339f2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/downloadcampaignsbyaccountids.md
:white_check_mark:Succeeded
View (=bingads-13)

Advertising/bingads-13/bulk-service/downloadcampaignsbycampaignids.md
:white_check_mark:Succeeded
View (=bingads-13)

Advertising/bingads-13/campaign-management-service/getimportentityidsmapping.md
:white_check_mark:Succeeded
View (=bingads-13)

Advertising/bingads-13/campaign-management-service/importentitytype.md
:white_check_mark:Succeeded
View (=bingads-13)

Advertising/bingads-13/guides/release-notes.md
:white_check_mark:Succeeded
View (=bingads-13)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


host report: Add a link to netbox

For each server add a link to Netbox. I think the PDFs dont allow links, or might need to update the latex settings.
But add a link that we can copy to take you directly to Netbox for this server.

Added to first block - http://sdp-services.sdp.kat.ac.za/servers/lab1/lab1.pdf

Added to first block - http://sdp-services.sdp.kat.ac.za/servers/lab1/lab1.pdf


No detaching threads

Hi,
First of all , thank you for such a library. I'm trying to use it in one of my applications and have come to an issue when its called from different posix or native threads in an Android application C++ layer.  A call "tosafejni::callStatic(JAVA_STATIC_CLASS, "getfun") "  will call AttachcurrentThread() . Now after its use , it doesnt call detach thread. This can lock and crash the thread, hence crashing the VM . It would be great if you could have a look at this issue.

I have correct the thread unsafe issues modify from this project, you call try it.


Switch job location_name with locations_attributes

 (5) Add support for multiple locations on jobs

@jordondornbos looks good


Remove logic apps language and links to logic apps documentation

@masisley : Thanks for your contribution! The author(s) have been notified to review your proposed change. @msftman


[Fix #9593] Fix an error when processing a directory is named {}

Fixes #9593.
This PR fixes the following error when processing a directory is named {}.
% mkdir {}
% rubocop
(snip)

File name too long - /tmp//////////////////////////////////////////////...

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

That's one issue I would have never anticipated! 😆 Thanks for fixing it!


regions: add missing write-barrier plus refactoring

add the missing write_barrier when initializing fields of a deserialized region (see Region::init_region)
as suggested by Luc, use RTS implemented alloc_region, init_region and field access functions to avoid duplication of logic in rts and compile.ml
render region implementation abstract to compile.ml

@luc-blaeser is this ok to merge?


Event log may contain sensitive service parameters

When I look at event logs for actee_type=service_instance  I notice service parameters passed in at service creation being logged.  These parameters can container sensitive information.  I'm not sure how locked down access to events are in the CC but in my org we send all events out to an audit log that has a different security profile than CC.  We're now redacting the parameters when sent to our audit log but other CF users might not be aware these parameters are getting logged.  You may want to consider redacting parameters in event logs.

Hi @youngm,
What sort of service takes sensitive information as parameters? The Services API - Provisioning doesn't indicate that parameters should be used to pass credentials or secrets. Credentials for a service should be passed back from the broker bind response.
Could you provide an example?
Thanks,
Nick

@SocalNick  Though the spec doesn't say people should pass sensitive data as a service param the vast majority of our custom services do pass sensitive data to brokers using service params.
Most use cases involve the concept of an "Existing" service plan that sits along side "Provisioned" plans.  If an application being deployed has an existing set of credentials, which may be required for any number of reasons over a provisioned service, we allow these users to provide credentials to access this existing service.  These Existing service instances are behaviorally indistinguishable from a provisioned service instance.  This is important since many of our service have functionality beyond simply providing credentials, though getting credentials in a consistent format is also nice.  For example, we have automated validation/testing and monitoring of these services as well as automated update of application dependencies in ServiceNow.
Another occasional use case involves a need for the broker to know who the user is that is creating the service.  This can be necessary to, for example, validate that the current users is authorized to perform some action on an external system.  In these cases the user provides an oauth token so the broker can validate that the creator is who they say they are.
Do those examples help?

@youngm is not alone on this. It is a very common use case for parameters to used for credentials or other sensitive data.
The generic use case of "binding services to services" is accomplished by passing credentials in parameters.

Thanks for the input @shalako. Let's make sure we use PRIVATE_DATA_HIDDEN for all audit events written for the following endpoints:
PUT /v2/service_instances/:service_instance_guid/routes/:route_guid
POST /v2/service_instances/
PUT /v2/service_instances/:guid
POST /v2/service_bindings
POST /v2/service_keys

Hi @youngm ,
We addressed your issue in this commit, and it will likely make its way into the next cf-release. If you have any additional concerns please let us know, otherwise feel free to close this issue.
Thanks,
@petergtz and @wendorf, Cloud Foundry CAPI team

@petergtz Thanks!


Transformer training error with evaluation/test dataset newstest2014.de

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes (only changed batch/filter size on modelparams.py)
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: n/a
TensorFlow installed from (source or binary): https://hub.docker.com/r/tensorflow/tensorflow nightly-gpu-py3
TensorFlow version (use command below): 1.15
Python version: 3.6
Bazel version (if compiling from source): n/a
GCC/Compiler version (if compiling from source): n/a
CUDA/cuDNN version: 10.1
GPU model and memory: NVIDIA RTX 8000 x2 (wNVLINK)

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
When following the transformer walkthrough There seems to be an issue with the newstest2014.de 'Download and preprocess datasets' step the newstest2014.de doesn't appear to be in valid text format. When its unpacked it cannot be opened as a text file (looks like another archive file) as the newstest2014.en can and was in previous versions.
For example: when I run the following command (after completing the rest of the requisite steps):
python3 transformer_main.py --data_dir=$DATA_DIR --model_dir=$MODEL_DIR --vocab_file=$VOCAB_FILE --param_set=$PARAM_SET --bleu_source=$DATA_DIR/newstest2014.en --bleu_ref=$DATA_DIR/newstest2014.de --train_steps=250000 --steps_between_evals=10000 --export_dir=$EXPORT_DIR
I get the error ( see attached/below for traceback) UnicodeDecodeError: 'utf8' codec can't decode byte 0x8b in position 1: invalid start byte
Describe the expected behavior
compute_bleu.py should work, but does not (only when i replace newstest2014.de with an older version (text format)
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Follow the example walkthrough, you'll get invalid newstest2014.de (as of  7/8/19)
Other info / logs see attached for traceback as well
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
As it currently stands, training only worked when i replaced the invalid newstest2014.de file with the older version, therefore i think thats the error.
I0708 18:55:13.764734<PHONE_NUMBER>69088 translate.py:133] Writing to file /tmp/tmpie7053oh
Traceback (most recent call last):
File "transformer_main.py", line 670, in
absl_app.run(main)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 300, in run
_run_main(main, args)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 251, in _run_main
sys.exit(main(argv))
File "transformer_main.py", line 664, in main
run_transformer(flags.FLAGS)
File "transformer_main.py", line 644, in run_transformer
vocab_file=flags_obj.vocab_file)
File "transformer_main.py", line 361, in run_loop
estimator, bleu_source, bleu_ref, vocab_file)
File "transformer_main.py", line 238, in evaluate_and_log_bleu
estimator, subtokenizer, bleu_source, bleu_ref)
File "transformer_main.py", line 222, in translate_and_compute_bleu
uncased_score = compute_bleu.bleu_wrapper(bleu_ref, tmp_filename, False)
File "/datasets/datasets/models/official/transformer/compute_bleu.py", line 91, in bleu_wrapper
tf.io.gfile.GFile(ref_filename).read()).strip().splitlines()
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/lib/io/file_io.py", line 128, in read
pywrap_tensorflow.ReadFromStream(self._read_buf, length))
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/lib/io/file_io.py", line 98, in _prepare_value
return compat.as_str_any(val)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/util/compat.py", line 117, in as_str_any
return as_str(value)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/util/compat.py", line 87, in as_text
return bytes_or_text.decode(encoding)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte
traceback1.txt

moved to tensorflow/models issues, should be there, closing.


Qt resets locale when loading images

Open a project (I used test scenes/bsdf/metalbrdf/01 - metalbrdf.appleseed)
Choose File>Save Project As...
Try to reload or open the project which was just created
Reloading or loading fails with error message

2017-06-02T14:08:08.702521Z <020>   333 MB error   | invalid vector format.
2017-06-02T14:08:08.702554Z <020>   333 MB error   | while defining <matrix> element: expected 16 scalar coefficients, got 0.
...

Confirmed to be a locale problem: while the locale is properly set to C in main(), it ends up being
LC_CTYPE=en_US.UTF-8;LC_NUMERIC=de_DE.UTF-8;LC_TIME=de_DE.UTF-8;LC_COLLATE=en_US.UTF-8;LC_MONETARY=de_DE.UTF-8;LC_MESSAGES=en_US.UTF-8;LC_PAPER=de_DE.UTF-8;LC_NAME=de_DE.UTF-8;LC_ADDRESS=de_DE.UTF-8;LC_TELEPHONE=de_DE.UTF-8;LC_MEASUREMENT=de_DE.UTF-8;LC_IDENTIFICATION=de_DE.UTF-8

by the time we reach ProjectFileWriter::write_plain_project_file().

QT changes locale when loading image from disk for the very first time. The problem was tracked in both QImage and QPixmap classes. Both classes in their load() function call QImageReader.read()  which results in change of the locale back to system settings.
A dirty fix is to load any image at the very beginning of the main and reset the locale right after, thus preventing the QImageReader.read() to change it again (as it happens only on the very first read).
In appleseed.studio code the locale change occurs in miscellaneous.cpp,load_icons(), line 170.

By grepping for std::setlocale() though Qt 4.8.7, zlib and libpng source code, none of them appears to permanently set the C standard library locale.
Unless you can pinpoint exactly where in Qt is the locale changed, we're unlikely to be able to fix this bug.

A better workaround would be to simply save then restore the locale in appleseed::studio::load_icons() since this is the only place where we actually load images with Qt.

The problem was tracked in both QImage and QPixmap classes

@gospodnetic How did you track this, and where do we use QImage to load images?

We use QPixmap which internally uses QImage and QImageReader

Right, just found out :) Thanks.

Closing this as a (somewhat hacky, admittedly) solution has been found


fix: remove collection id form NFT minting

Summary
Please summarize your changes, describing what they are and why they were made.
Changelog
Please write an accurate and concise changelog for your changes.

Relevant Issues
Please list any related issues (e.g. bug, task).
Type of Change
Please select any type below that is applicable to your changes, and delete those that are not.

[ ] Breaking - any change that would cause existing functionality to not work as expected
[ ] Chore - refactoring, build scripts or anything else that isn't user-facing
[ ] Docs - changes to the documentation
[ ] Fix - a change which fixes an issue
[ ] New - a change which implements a new feature
[ ] Update - a change which updates existing functionality

Testing
Platforms
Please select any platforms where your changes have been tested.

Desktop

[ ] MacOS
[ ] Linux
[ ] Windows

Mobile

[ ] iOS
[ ] Android

Instructions
Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.
Checklist
Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or modified tests that prove my changes work as intended
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have verified that my latest changes pass CI workflows for testing and linting
[ ] I have made corresponding changes to the documentation

Looks good to me. There are a few references collectionId in the en.json file. We might want to remove them to reduce bloat.

@kraftjs the collections will still have an Id so they will be used eventually

Looks good to me. There are a few references collectionId in the en.json file. We might want to remove them to reduce bloat.

@kraftjs the collections will still have an Id so they will be used eventually

Okay great, wasn't sure if that might be the case so I approved it instead of suggesting a change.


Convert to Parcel

Fixes #24

Sorry, @milesfrain, somehow I wasn't watching this repository. I am now, and thanks for submitting this.

This should be good to go now, but let me know if I missed anything.

If you notice any ways to improve this further in your experience writing documentation and working with folks learning PureScript I hope you consider helping improve this over time!

Thanks for working on this!


Should error on uv run pip?

Hi there,
It took me some time to realize I was running uv run pip instead of uv pip.
I don't really know the difference, but when running uv run after what I did with uv run pip was removed from the .venv.

isn't that intended? i believe the later invocation of uv pip / pip is expected to write over the current state of the virtual environment, e.g.
$ uv pip install pandas
Resolved 6 packages in 13ms
Installed 6 packages in 48ms
 + numpy==2.1.1
 + pandas==2.2.2
 + python-dateutil==2.9.0.post0
 + pytz==2024.2
 + six==1.16.0
 + tzdata==2024.1

followed by
$ uv pip install numpy~=1.0
Resolved 1 package in 10ms
Uninstalled 1 package in 41ms
Installed 1 package in 14ms
 - numpy==2.1.1
 + numpy==1.26.4

overrides the numpy version.
also given that uv run is designed to (someone correct me if i'm wrong here) support any arbitrary command that follows, erring on a particular command (i.e. pip) feels like a hack.
in fact, i think there may be some use cases (albeit not ideal) where one wants to combine the use of pip and uv pip (e.g. if pip and uv pip behave differently in some configuration).


fixing the TOC video link

There were two links on the page, last fix updated the one in ## Assets, this commit fixes the TOC video link

Great. Thank you @kknight-valorem


[AutoPR mariadb/resource-manager] Add Vnet resource for Microsoft.DBforMariaDB

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4337

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3699


How to get REDSTONE DUST

So once I obtain Raw Redstone, how do I cook it

Regarding to recipets it should be work by milling

But its not working by for me .. the Mill will accept the Item but will not something with it.

It seems to work fine with Crushing Wheels .. there no recipets shown for .. but i tested it and its working for me

Duplicate of #74


First 3 Porjects completed

Nice finishing off!
One question separate from the individual line comments:
One of the extension requirements was "Don't let the same image URL be uploaded twice" - what do you think the rationale behind this is? I can see that you've currently implemented this as a uniqueness constraint on the URL field in the database... What's this achieving? If two users try to upload the same image with different titles or different alt texts, why are we preventing them from doing so? Are there cases where we may want to allow this? What do you think users are likely to do if they hit this?

So I went with a uniqueness constraint as I wanted to try something different.. I think. Normally you can query the database and check if there's a record with the same URL and inform the user, but I thought this adds an additional read operation that can be avoided with a constraint.
They both achieve the same result, but database constraint is slightly more difficult to change in the future and also it prevents us from adding different business logic, i.e. if the user should be promped to confirm they want to upload a new image even though url exists.  If two different users can upload the same URL twice, then the database constraint would have to be updated so userID+URL is unique, but this again raises the complexity as you will have to apply migrations instead of just releasing new code.

Nice finishing off!
One question separate from the individual line comments:
One of the extension requirements was "Don't let the same image URL be uploaded twice" - what do you think the rationale behind this is? I can see that you've currently implemented this as a uniqueness constraint on the URL field in the database... What's this achieving? If two users try to upload the same image with different titles or different alt texts, why are we preventing them from doing so? Are there cases where we may want to allow this? What do you think users are likely to do if they hit this?

So I went with a uniqueness constraint as I wanted to try something different.. I think. Normally you can query the database and check if there's a record with the same URL and inform the user, but I thought this adds an additional read operation that can be avoided with a constraint.
They both achieve the same result, but database constraint is slightly more difficult to change in the future and also it prevents us from adding different business logic, i.e. if the user should be promped to confirm they want to upload a new image even though url exists. If two different users can upload the same URL twice, then the database constraint would have to be updated so userID+URL is unique, but this again raises the complexity as you will have to apply migrations instead of just releasing new code.

Makes sense - good reasoning!


fix(v2): update SearchPage styling, fix appearance in dark mode

Motivation
Currently SearchPage styling feels a bit plain and in addition to that inputs and separator lines do not change appearance between the modes.
This PR updates the SearchPage component and introduces the following changes:

more CSS variable used from Infima and Docsearch itself
inputs borrows few styling properties the search input style from the modal
chevron sign (breadcrumbs splitter) received it's own class to make customizing the style (or even changing it via content)  possible through CSS

Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
The changes have been tested using Docusaurus V2 website locally.
Preview

Mobile

Related PRs

#3834

This is how full focus/active style looks  when it was fully based on the Docsearch CSS variables, but I personally don't liked the background color of unselected element. In the other hand implementing border color change (on previous mentions interactions) might be a good idea, but this behavior will differ from the search input in modal, which is stylized as always focused.

inputs borrows few styling properties the search input style from the modal

I don't like this, it feels like inputs are always in focus/hover state. Typically, similar styling is used for outline property (which I actually plan to do in Infima, CSS outline based on the primary color). Moreover, resetting an outline is very bad practice.

I don't like this, it feels like inputs are always in focus/hover state. Typically, similar styling is used for outline property (which I actually plan to do in Infima, CSS outline based on the primary color). Moreover, resetting an outline is very bad practice.

This was exactly my concern which I had stated in the comment above, you should explain why it's a bad approach and why you don't like this to Algolia devs, not me. 😉
So I'm going to push the alternative interaction styling, in from which I have proposed above, since you have not recommended other alternatives.

I got you, but Algolia search is a third-party project, although the search page uses the Algolia API, this is our feature, so we style it according to our styles (i.e. those defined in Infima), and not follow Algolia design guidelines.
I suggest simply leaving the default styling for inputs (from Infima), this is the most appropriate option, in my opinion.

I suggest simply leaving the default styling for inputs (from Infima), this is the most appropriate option, in my opinion.

But there is currently almost no styling (in/from Infima), and as stated before, inputs are looking incorrect in dark mode.

Updated preview
With borders (inset shadow) transition and no background altering.

I suggest simply leaving the default styling for inputs (from Infima)

Can you elaborate more on the Infima default inputs styling, what do you have in mind? I'm was not able to find any mention about input styles in the Infima docs:

https://facebookincubator.github.io/infima/docs/components/alert

Only traces about that some styling exist in Infima are variables like:

--ifm-navbar-search-input-color
--ifm-navbar-search-input-background-color
But they are not general variables, they were created specifically for the Navbar search input.

I understand what you want to do, but it's better to add dark mode support for input in Infima itself, rather in search page component. Especially now box-shadow is almost useless, because it is overlapped by the outline.
It seems that next week Infima will be opensourced so you can suggest appropriate changes.

@Simek thank you!

Especially now box-shadow is almost useless, because it is overlapped by the outline.

@lex111 That was the reason why I have disabled the outline in the initial version, but I have put it back as you suggested that is a bad practice. I also don't like the appearance of box-shadow and outline used at the same time. Maybe you will have a better idea how to improve this within incorporation of Infima styling.
Also I have got one more question, what is the reason behind using italic style for the result item summary? AFAIK there are no other italic styled text in theme-classic components.

Maybe you will have a better idea how to improve this within incorporation of Infima styling.

The solution is really simple - just use border instead of box-shadow, which can be removed on focus/hover state. This is best done in Infima, as it might come in handy for other inputs.

Also I have got one more question, what is the reason behind using italic style for the result item summary? AFAIK there are no other italic styled text in theme-classic components.

I don’t remember exactly why I did this, maybe I was inspired by some other search page. So maybe we should remove this, but I'm not sure about that.


bump build-number, adjust libffi

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_6fusn7qd3a/clone/recipe/meta.yaml:0: missing_version_or_name: The recipe is missing name and/or version
ERROR: /tmp/abs_6fusn7qd3a/clone/recipe/meta.yaml:43: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: MPL-2.0
WARNING: /tmp/abs_6fusn7qd3a/clone/recipe/meta.yaml:52: missing_license_url: The recipe is missing a license_url
WARNING: /tmp/abs_6fusn7qd3a/clone/recipe/meta.yaml:52: http_url: http://pandoc.org/ is not https
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_8975ordnf4/clone/recipe/meta.yaml:0: missing_version_or_name: The recipe is missing name and/or version
ERROR: /tmp/abs_8975ordnf4/clone/recipe/meta.yaml:43: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: ZPL-2.0
WARNING: /tmp/abs_8975ordnf4/clone/recipe/meta.yaml:52: http_url: http://pandoc.org/ is not https
WARNING: /tmp/abs_8975ordnf4/clone/recipe/meta.yaml:52: missing_license_url: The recipe is missing a license_url
Errors were found


Request: avoid caching of dates

I've noticed that before the view is used, an AsyncTask is executed that saves all dates in the range:
    @Override
    protected Void doInBackground(Void... params) {
        //ArrayList of dates is set with all the dates between
        //start and end date
        GregorianCalendar calendar = new GregorianCalendar();

        calendar.setTime(dateStartCalendar);
        calendar.add(Calendar.DATE, -(numberOfDatesOnScreen / 2));
        Date dateStartBefore = calendar.getTime();
        calendar.setTime(dateEndCalendar);
        calendar.add(Calendar.DATE, numberOfDatesOnScreen / 2);
        Date dateEndAfter = calendar.getTime();

        Date date = dateStartBefore;
        while (!date.after(dateEndAfter)) {
            mListDays.add(date);
            calendar.setTime(date);
            calendar.add(Calendar.DATE, 1);
            date = calendar.getTime();
        }

        return null;
    }

This is a bad thing:

It takes time till the view is ready, for a view that simply needs to show dates.
It can take a huge amount of Date items. In my case, that I wanted to show a large range, it takes at least 60K of Date objects.
All of this in memory.

Instead of this, the view should immediately go to the correct date.
The calculation can be done on the UI thread, in the onBindViewHolder callback, by comparing the current item position to the pivot date (the date you started from, or the start date).

Here's a possible way to avoid the caching:
    @JvmStatic private val MS_IN_24_HOURS = (1000 * 60 * 60 * 24).toLong()

    @JvmStatic
    fun getWhole24DayDifference(time1: Long, time2: Long): Long {
        val diff = Math.abs(time1 - time2)
        return diff / MS_IN_24_HOURS
    }

    val startDate=...
    val endDate=...
    val numberOfDateItems = getWhole24DayDifference(endDate.time, startDate.time)

In the adapter:
            val cal = Calendar.getInstance()

            override fun getItemCount(): Int {
                return numberOfDateItems.toInt()
            }

            fun getItem(pos: Int): Date {
                cal.time = startDate
                cal.add(Calendar.DATE, pos)
                return cal.time
            }

Again this library was not intended to display large range of dates, therefore performance was not the focus rather simplicity.
It is true that storing a large number of dates is not optimal, but what you are suggesting requires a lot of changes in the structure of the library.
If you would like to contribute and get this enhancement fast, please feel free to open a pull-request, otherwise it will take me sometime to do it, as I have some other bugs to fix.
Regards.

But why was it important to save all the dates? It's very fast to calculate the date to show, per each item...
I hope I will have time to check it out at home. Do you mind that I remove unused functions, though?

I've put a full solution to this issue here:
https://github.com/Mulham-Raee/Horizontal-Calendar/issues/46#issuecomment-339133571
There is no caching of dates whatsoever. Everything is instant. There is no huge list of dates.
Please check it out.

@AndroidDeveloperLB
Implemented, thank for your contribution!


Consider retry on failed uploads

Uploads are occasionally failing in a consistent way, and trying to retry sends once or twice may be a reasonable fix.
File "/home/runner/work/_actions/biglocalnews/upload-files/v2/upload.py", line 55, in main()
File "/home/runner/work/_actions/biglocalnews/upload-files/v2/upload.py", line 37, in main client.upload_files(project_id, file_list)
bln.exceptions.APIException: Service Unavailable

@palewire suggests looking at using retry for really simple functionality:
https://pypi.org/project/retry/

Should be closed with https://github.com/biglocalnews/bln-python-client/compare/2.3.2...2.3.3


docs: fix wrong resource in comment

Purpose

Fix wrong comment on resourc eimport example

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

Test the code via automated test

go test ./...

What to Check
Verify that the following are valid:

Automated tests are executed successfully
Documentation for import of directory_entitlement is correct

Other Information

n/a
Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

[X] The PR is assigned to the Terraform project and a status is set (typically "in review").
[X] The PR has the matching labels assigned to it.
[X] The PR has a milestone assigned to it.
[X] If the PR closes an issue, the issue is referenced.
[X] Possible follow-up items are created and linked.

Due to docu change and dependency to exporter => bypassing review requirement


Make yarn and yarn jest react-native-codegen works on Windows with git

Summary
A few fixings to make yarn jest react-native-doegen works on Windows:

Add a .gitignore file to tell git not to track generated/temporary files.
There is no rm on Windows, change it to rimraf.

I have been using it in the last 3 months and it works perfectly on Windows, otherwise I could not even build the code in my laptop.
Changelog
[General] [Changed] - Make yarn and yarn jest react-native-codegen works on Windows with git
Test Plan
yarn jest react-native-codegen passed

I am a bit concerned if this works also on unix-based system. But probably yes, given that it is a node module.

Yeah, rimraf is cross-platform

From @robhogan

What's this about? Does react-native-codegen write into its own directory?
If this doesn't need to be in the published package then it should probably be in the root .gitignore for consistency. If it does need to be in the published package, that's a bit worrying - it should probably be using something under os.tmpdir() if it needs to write to the filesystem.

Also, we have a linting error:

Files must end in a newline.
for the .gitignore

@cipolleschi

it should probably be using something under os.tmpdir() if it needs to write to the filesystem.

I remember they look like generated C++ files from the unit test, I don't know why these files are not checked in or something.
The rimraf is a different thing, it removes lib which are build result.

I remember they look like generated C++ files from the unit test, I don't know why these files are not checked in or something.

This looks like something that only happens in Windows... Could you try again, by removing that tmp folder and see whether there are those tmp files? Perhaps it was some failed execution that left some dirt behind and we don't need to commit the .gitignore.
Also, if we need that, a better approach would be to update the .gitignore in the root folder

@cipolleschi Hi, looks like this commit added the tmp folder to the root .gitignore so I think I don't need to submit this file now.


Make previewOptions more like -C option

We should consider something like the --context option (https://github.com/BurntSushi/ripgrep/blob/master/GUIDE.md#common-options) instead of the current preview options. They currently don't allow to show a multi line context around a match and make implementing a textual representation of search results very hard...

I would add
export interface TextSearchPreviewOptions {
    contextLines?: number;
}

Yeah, that would be nice but might also be problematic. When having context: boolean the search engine can decide, e.g. show 5 lines (two above & below) for normal matches but only show parts of a line for monster lines

Sometimes it's up to the user how much context should be shown. In Atom I can change leading and trailing context via the UI independently.
If you are showing results as text with context, is it annoying that multiple results on one line are given as multiple result objects, possibly with overlapping previews? Should the API keep the one-result-per-line model instead?
One difficulty here is when you have a long line with one match at the beginning and one at the end.

Should the API keep the one-result-per-line model instead?

That means to show more context (line above/below) the file needs to opened and I don't that feasible...

I'm referring to something else, not context lines. When you have two matches on the same line, the API will send two result objects. For your extension, it might be better if you can get a single result object that indicates the two matches. That's what I mean by one result per line.
Kai had the suggestion of just using exactly ripgrep's format: https://burntsushi.net/stuff/libripgrep/doc/grep_printer/struct.JSON.html

Please verify by calling the findTextInFiles API from an extension with the context options, check that you get something reasonable.


p11-kit: 0.23.12 -> 0.23.13

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/p11-kit/versions.
meta.description for p11-kit is: '""'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.23.13 with grep in /nix/store/d1aadk8ngksx7r74nm6pd97m4i59x9af-p11-kit-0.23.13

directory tree listing: https://gist.github.com/5ef6c8daf082f5e336f01d0b47ed47fc

du listing: https://gist.github.com/16616c97f3f6483a2b71f2019a6cadae

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 86a6c4218e7fd23d2ce249c4ad8f11f6f87a1e94 && nix-shell --pure -I nixpkgs=. -p p11-kit

cc @wkennington for testing.

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)
Attempted: p11-kit
Partial log (click to expand)
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
Warning: Transient problem: HTTP error Will retry in 4 seconds. 1 retries
Warning: left.
100   125    0   125    0     0   1373      0 --:--:-- --:--:-- --:--:--  1388
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 502 Bad Gateway
error: cannot download source from any mirror
builder for '/nix/store/3k9y1w5r6q2bjd3ljfjjcfk6dnzlia5z-source.drv' failed with exit code 1
cannot build derivation '/nix/store/d19hcxxfkvxhb74cawn0liljn7qznv6v-p11-kit-0.23.13.drv': 1 dependencies couldn't be built
error: build of '/nix/store/d19hcxxfkvxhb74cawn0liljn7qznv6v-p11-kit-0.23.13.drv' failed

Success on x86_64-linux (full log)
Attempted: p11-kit
Partial log (click to expand)
patching script interpreter paths in /nix/store/d1aadk8ngksx7r74nm6pd97m4i59x9af-p11-kit-0.23.13
/nix/store/d1aadk8ngksx7r74nm6pd97m4i59x9af-p11-kit-0.23.13/libexec/p11-kit/trust-extract-compat: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/d1aadk8ngksx7r74nm6pd97m4i59x9af-p11-kit-0.23.13...
shrinking RPATHs of ELF executables and libraries in /nix/store/zdwpxl8p13m5ahyi4h612giwllsjbfj7-p11-kit-0.23.13-dev
shrinking /nix/store/zdwpxl8p13m5ahyi4h612giwllsjbfj7-p11-kit-0.23.13-dev/bin/p11-kit
shrinking /nix/store/zdwpxl8p13m5ahyi4h612giwllsjbfj7-p11-kit-0.23.13-dev/bin/trust
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zdwpxl8p13m5ahyi4h612giwllsjbfj7-p11-kit-0.23.13-dev/lib  /nix/store/zdwpxl8p13m5ahyi4h612giwllsjbfj7-p11-kit-0.23.13-dev/bin
patching script interpreter paths in /nix/store/zdwpxl8p13m5ahyi4h612giwllsjbfj7-p11-kit-0.23.13-dev
checking for references to /build in /nix/store/zdwpxl8p13m5ahyi4h612giwllsjbfj7-p11-kit-0.23.13-dev...

Success on x86_64-darwin (full log)
Attempted: p11-kit
Partial log (click to expand)
post-installation fixup
Patching '/nix/store/9fcpv6khgqdvdgf75rd8qzqiakn01w71-p11-kit-0.23.13-dev/lib/pkgconfig/p11-kit-1.pc' includedir to output /nix/store/9fcpv6khgqdvdgf75rd8qzqiakn01w71-p11-kit-0.23.13-dev
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/h7jnlppy26zlbirgc1ibfzhnnzqh9ayd-p11-kit-0.23.13/lib  /nix/store/h7jnlppy26zlbirgc1ibfzhnnzqh9ayd-p11-kit-0.23.13/libexec
patching script interpreter paths in /nix/store/h7jnlppy26zlbirgc1ibfzhnnzqh9ayd-p11-kit-0.23.13
/nix/store/h7jnlppy26zlbirgc1ibfzhnnzqh9ayd-p11-kit-0.23.13/libexec/p11-kit/trust-extract-compat: interpreter directive changed from "/bin/sh" to "/nix/store/hp9yq2m1i066irvasv20zr2lmj54fk9h-bash-4.4-p23/bin/sh"
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/9fcpv6khgqdvdgf75rd8qzqiakn01w71-p11-kit-0.23.13-dev/lib  /nix/store/9fcpv6khgqdvdgf75rd8qzqiakn01w71-p11-kit-0.23.13-dev/bin
patching script interpreter paths in /nix/store/9fcpv6khgqdvdgf75rd8qzqiakn01w71-p11-kit-0.23.13-dev
/nix/store/h7jnlppy26zlbirgc1ibfzhnnzqh9ayd-p11-kit-0.23.13

Success on x86_64-linux (full log)
Attempted: p11-kit
Partial log (click to expand)
  /nix/store/5grvnrb8g8kh1gzlwrp1ckh68gfhrwh1-p11-kit-0.23.13
  /nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23
  /nix/store/g6pwfq3wfmhi5mqgxiki8idfiz1v1a3w-libffi-3.2.1
  /nix/store/hx54ggnr64g1g0wggdfvgdm42r2bs1kv-glibc-2.27
copying path '/nix/store/hx54ggnr64g1g0wggdfvgdm42r2bs1kv-glibc-2.27' from 'https://cache.nixos.org'...
copying path '/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23' from 'https://cache.nixos.org'...
copying path '/nix/store/g6pwfq3wfmhi5mqgxiki8idfiz1v1a3w-libffi-3.2.1' from 'https://cache.nixos.org'...
copying path '/nix/store/2gn1cgyxrjfxm6kyv3lfh10jas8fg584-libtasn1-4.13' from 'https://cache.nixos.org'...
copying path '/nix/store/5grvnrb8g8kh1gzlwrp1ckh68gfhrwh1-p11-kit-0.23.13' from 'https://cache.nixos.org'...
/nix/store/5grvnrb8g8kh1gzlwrp1ckh68gfhrwh1-p11-kit-0.23.13

Success on aarch64-linux (full log)
Attempted: p11-kit
Partial log (click to expand)
/nix/store/yzciiglwnjdq0zwj1xarxmprhqdldwai-p11-kit-0.23.13/libexec/p11-kit/trust-extract-compat: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/yzciiglwnjdq0zwj1xarxmprhqdldwai-p11-kit-0.23.13...
shrinking RPATHs of ELF executables and libraries in /nix/store/kjnmw68mdxbvwxb3nr82q9ki65p02qnn-p11-kit-0.23.13-dev
shrinking /nix/store/kjnmw68mdxbvwxb3nr82q9ki65p02qnn-p11-kit-0.23.13-dev/bin/trust
shrinking /nix/store/kjnmw68mdxbvwxb3nr82q9ki65p02qnn-p11-kit-0.23.13-dev/bin/p11-kit
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
stripping (with command /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip and flags -S) in /nix/store/kjnmw68mdxbvwxb3nr82q9ki65p02qnn-p11-kit-0.23.13-dev/lib  /nix/store/kjnmw68mdxbvwxb3nr82q9ki65p02qnn-p11-kit-0.23.13-dev/bin
patching script interpreter paths in /nix/store/kjnmw68mdxbvwxb3nr82q9ki65p02qnn-p11-kit-0.23.13-dev
checking for references to /build in /nix/store/kjnmw68mdxbvwxb3nr82q9ki65p02qnn-p11-kit-0.23.13-dev...
/nix/store/yzciiglwnjdq0zwj1xarxmprhqdldwai-p11-kit-0.23.13

Timed out, unknown build status on x86_64-darwin (full log)
Attempted: p11-kit
Partial log (click to expand)
cannot build derivation '/nix/store/kccgd4wn7yiz53fi2glxk54xy36z1zi3-autoconf-2.69.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/v5y964mbkqw4y8i1nzvld57nr611w789-perl5.28.0-gettext-1.07.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/y8vwgb0rdzigxpklqpccr9iv6639j9s1-texinfo-6.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/44np4p68fci5ygnkqlbyc9qs4xhh3w5s-automake-1.16.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/9cr2bgzc5racyircbgil54xbqnxqdrlx-help2man-1.47.6.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/vfmj40wrpkq3fj7p90h01jbq76ss0f32-libtasn1-4.13.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/782sz3jb3xrmvk06gzv4sfa46kkvsaxl-libtool-2.4.6.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/9vxgp614vfihmhjzv5iqcqy0xkwh4133-hook.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/3ibrzvf9plvvmb5hcx53ysb3hrqcya7w-p11-kit-0.23.13.drv': 5 dependencies couldn't be built
error: build of '/nix/store/3ibrzvf9plvvmb5hcx53ysb3hrqcya7w-p11-kit-0.23.13.drv' failed