remove atlas, cluster, europa, saltern

basically, these maps have had issues on and off since their inception. be it design, layout, lack of updates, etc. we are moving in a direction where we are working on refining what we have and trimming off things we don't need. ill list reasons for each's removal below. thank you to everyone who maintained these maps over the years.
atlas: inspired by goons atlas, created by emisse in 14. maintained by deltanedas for the last year or so. this map is fundamentally flawed and needs a complete rework to survive. it has a future in ultra low pop servers if redesigned for current year from the ground up.
cluster: created by scribbles. maintained on and off by many people. a cute little low pop with a ring like design, does not hold up current year and basically same issues as atlas.
europa: created by ubaser. a test bed for planetary stations, not seen by many but it worked well for what it was.
saltern: created by PJB. maintained by emisse and then nairod. the first map ever made for ss14. you can tell. needs a reimagining.
🆑

remove: Atlas, Cluster, Europa, & Saltern removed from the game.

"these maps had slight issues before so we need to remove half of the map pool"

reading comprehension

Just deleting them seems excessive, could they not just be removed from rotation until someone goes in and fixes their issues?

waste of space and maintenance burden

tragedia
o7

remove packed pls....

Damn, low-pop map purge

finally

not to worry chat i’m gonna fix cluster

Damn, that's a lot of low pop maps gone.
RIP Saltern

atlas rest in piss

This is a bit frustrating because, as someone who wants to get into mapping for SS14, the "issues" listed do not explain anything other than some vague elusion to bad design. It was the same when Gemini was removed, the only answer I could get was "it was designed in an old way".

cluster: does not hold up current year and basically same issues as atlas.

Okay but what are the issues? Is it that it is lacking space in some departments? Is the maints pathing too free, or too restrictive? The distribution of departments relative to each other?
I'm not arguing against removing the maps (no matter how much I love Cluster) and if you say they needed to go I believe you. But, concretely, what are the issues?

if youre interested feel free to ask me in discord whenever

Emisse on Cluster, from Discord:

every firelocked area needs to be redone to current standards (1 escape strategy per area), central area should be redone to allow more space/more privacy, medical layout is bad (just big and empty and open cryo and surgery should be closer), maint detailing needs redoing (too visually cluttered by mismatched tiles and firelocks and catwalks), firelocked areas in maints need redoing, cameras will need complete redo when AI is out in a week, security is "ok" but warden really needs to be able to see cells from his office so it should be rearranged, EVA is too far from everything, needs to be a pretty simple path from HoP (preferably), engineering way too cramped, atmos needs expansion, they need room for another engine, cargo bay needs expansion too small, substation 1x1 rooms are old fashioned and need killing, arrivals should probably be protected since it is completely exposed 180 degrees at this point and every arrivals has at least 90 degrees of protection to full, atmos and air alarms and fire alarms need complete redoing due to the age

According to this image by Boaz, this would leave 2 maps for population between 10 and 30, and no maps at all between 7 and 10.

Nah, that's crazy.
Emisse destroying the game

if youre interested feel free to ask me in discord whenever

Why wouldn't you just create an Issue for it on github so that everyone can easily see what is wrong with the maps.

 I FUCKING LOVE WHEN PEOPLE IN POWER DIRECTLY GO AGAINST THE WILLS OF THE PEOPLE FOR THEIR OWN CHANGES.

"will of the people" larpers when you ask them to exert a fragment of that will to update and maintain maps instead of leaving one person to work on 10+

The real focus here should be improving mapping as a whole. If maintaining these is such a burden, why has the system yet to be improved?
We (MWG) will be looking at this over the next few weeks. If something can be made to aid in creating/editing maps sensibly, maybe the 'burden' will be reduced or eliminated. It might even open up the possibility of more contributors on the mapping side.
Regardless, I think removing the maps alone is the wrong call. This is treating a symptom, not the main issue.

"will of the people" larpers when you ask them to exert a fragment of that will to update and maintain maps instead of leaving one person to work on 10+

Maybe if the people complaining actually opened issues for the map something could be done.

I am willing to say that I am willing to maintain saltern.
Me actually doing it is another matter entierly.

"will of the people" larpers when you ask them to exert a fragment of that will to update and maintain maps instead of leaving one person to work on 10+

Cluster had no opened issues when it was removed from the game

if youre interested feel free to ask me in discord whenever

Reading comprehension.


Remove unused CI files

Resolves #36 cc @vsoch

These were ideal when the docs content was being rendered as a site so it could be previewed. If that's not the case anymore (which it is not) then these are safe to remove. I've also reproduced the content (I spent quite a bit of time on it!) on a site that currently is deployed so it's not lost in GitHub markdown forever :laughing: https://rse-ops.github.io/knowledge/docs/containers/docker/

wtf is this? https://github.com/dnabookofficiall/Soheil-DamanAfshan/issues/1


[ FR ] Support of Mobile

Do you have any plans to support the mobile app?

I didn't know mobile support required anything different, I'll check it out!

I tested the plugin in the Android app and seems to be working fine, did you encounter any issue?

I have it installed, but I cannot enable it. There might be some flag to activate the mobile support.

do you have other plugins working on the mobile app? which platform and version of the app are you using? I could not reproduce the issue on Android at least

I am on iOS and iPadOS and have the latest insider build [ with canvas ].
Obsidian fails to load the plugin.

Closing this as I tested on iOS 16.4.1 and it's working without any issue, but I removed in version 1.2.0 the look behind in regular expressions that was causing the issue.

Closing this as I tested on iOS 16.4.1 and it's working without any issue, but I removed in version 1.2.0 the look behind in regular expressions that was causing the issue.

Thank you, it works!


Input in reverse order on Android 5.0.2

Looking at the demo page on mobile (Android 5.0.2) when I choose e.g. US phone number and I enter 123456 I get (654) 321 instead of the expected (123) 456.

I tried it on Samsung Galaxy Nexus emulator which has Android 5.1 (Lollipop) and I don't have that issue (as you can see on this page #215) .
Could there be an issue in 5.0 that got fixed in 5.1?

@karel1980 I'll close this for now, but please send an update if you find more information. Thanks!

Oops. Forgot to reply. Not sure if it is a bug with my Android version. Maybe with my keyboard implementation (phone is a Galaxy A3 and I am using stock android keyboard).
Otoh this is the first time I get this effect with this keyboard/phone.

There it is... just tried with the keyboard from keepass2android and that works as expected.
Googling for similar reports with samsungs keyboard implementations now...

Here is a very similar report: https://github.com/digitalBush/jquery.maskedinput/issues/280
No solution there either. I'll add a link back to here as well.

No need to add backlink.Github does this automatically

Just posting this in case someone come here searching for a fix,
The problem actually happens with the samsung keyboard and his autocomplete function so to reproduce this issue you need to use the samsung keyboard with the autocorrect enabled, the cursor will always go to the begining after you insert any character so you'll literally type anything backwards 123 turns into 321.
You can fix this setting autocomplete="off" since it will disable the autocorrect, this doesn't work on all samsung devices because some still keep the autocorrect but will fix most of them.

Adding more info, it looks like this can be fixed by changing how the caret position is adjusted, i'm not familiar with the package so i'm not sure when i'll be able to have a spare time and fix this,
Theres a PR that fixes this exactly same issue on a jQuery mask: igorescobar/jQuery-Mask-Plugin#464, maybe checking their solution could help a bit...

@fernandobandeira It looks like they're opting for an old technique for caret positioning, that is supported by old IE browsers? The PR is removing the logic that chooses between which of the two caret positioning techniques should be used, and always uses the IE one.

@msafi Yes, this solves their problem since setSelectionRange is causing the issue, the function does exists on the browser but it's not reliable, so they fixed it this way.
I've recorded a video showing the issue on the website, check it:
https://drive.google.com/file/d/0B5j7CzpTIt5BVTJGRWRmUTV1dFU/view?usp=sharing

In case if somebody is still experiencing the Android 4.4 problem, you can check out my workaround: https://github.com/ignovak/text-mask/commit/a3851ed, mb it will be useful. It's a bit dirty but seems working: http://inovak.neocities.org/text_mask.html.

@ignovak could you open a pr with this? it's dirty but it'll open a space for discussing the implementation...

Folks, I don't think we need to open a PR for this. I'm glad these workarounds exist, but it will be hard to integrate such a fix in a clean way. And the affected platform is quite old. That's why I don't think this issue is a priority.

@fernandobandeira Hi, I've tested the workaround again and found out that it doesn't always work...
Instead, I've made sure that in the most cases the reason is the autocomplete feature for android keyboards.
The details are described well enough on http://stackoverflow.com/questions/34774684/masked-input-working-ok-on-desktop-and-working-ok-for-some-masks-on-mobile/34887682#34887682.

When a word is marked for a suggestion, the selectionStart and selectionEnd are not reflecting the caret position but they wrap the whole word, even though the caret is somewhere in between and the actual selection is collapsed.

For example, if you run such code
  document.querySelector('input').addEventListener('input', function(e) {
  console.log(e.target.value, e.target.selectionStart)
});

and type some text (e.g. "qw er df"), you'll see the next output in a normal browser:
q 1
qw 2
qw  3
qw a 4
qw as 5
qw as  6
qw as z 7
qw as zx 8

On android with enabled autocompletion, instead, you'll see
q 0
qw 0
qw 2
qw  3
qw a 3
qw as 3
qw as 5
qw as  6
qw as z 6
qw as zx 6
qw as zx 8

So the selectionStart property returns the wrong result which brakes the entire logic of the library.
I've opened #304 where I force autocomplete="off" on android devices. Tested on 5.0 and 6.0 (see http://inovak.neocities.org/text_mask.html).
There is still a problem on 7.0, but I'm going to investigate it separately.
Also, if you don't need alphabet characters, you can always specify type="tel", which works without bugs.

@msafi Regarding the quite old platform: according to https://developer.android.com/about/dashboards/index.html, 40% of users have old devices with Android < 5.0, mostly without chances to upgrade. So even if the bug affects only old browsers it's still a huge part of the users...

@ignovak Ok. Your PR #304 is much simpler than the other solution proposed, so I think we maybe able to merge that. I've left a comment there. Let's see if we can make it mergeable.

This work for me https://github.com/text-mask/text-mask/issues/300#issuecomment-273241094


Compiler bug - I thought a non-nullable-unwrapped variant for a lambda set was impossible: how could such a lambda set be created without a base case?

There's probably an element of PEBKAC here but the traceback does say please file an issue so here we go
app "hello"
    packages { pf: "https://github.com/roc-lang/basic-cli/releases/download/0.7.1/Icc3xJoIixF3hCcfXrDwLCu4wQHtNdPyoJkEbkgIElA.tar.br" }
    imports [
        pf.Stdout,
        pf.Task.{ Task },
        pf.Tcp,
    ]
    provides [main] to pf

consume = \stream, acc ->
    xx <- Tcp.readLine stream |> Task.await
    if Str.endsWith xx "\r\n" then
        Task.ok acc
    else
        yy <- consume stream (Str.concat acc xx) |> Task.await
        Task.ok yy

hello = \stream ->
    {} <- Tcp.writeUtf8 "HELLO 3\r\n" stream |> Task.await
    bits <- consume stream "" |> Task.await
    Task.ok {}

errHandler : [TcpConnectErr Tcp.ConnectErr]* -> Task.Task {} *
errHandler = \e ->
    errStr =
        when e is
            TcpConnectErr e2 -> Tcp.connectErrToStr e2
            _ -> "some unexpected error"
    Stdout.line "error: $(errStr)"

main : Task {} *
main =
    _ <- Tcp.withConnect "localhost" 6379 hello |> Task.onErr errHandler |> Task.await
    Stdout.line "done"

Runing the above outputs
> RUST_BACKTRACE=full ./roc dev
An internal compiler expectation was broken.
This is definitely a compiler bug.
Please file an issue here: https://github.com/roc-lang/roc/issues/new/choose
thread '<unnamed>' panicked at 'I thought a non-nullable-unwrapped variant for a lambda set was impossible: how could such a lambda set be created without a base case?', crates/compiler/mono/src/layout.rs:1713:61
stack backtrace:
   0:        0x1035a0890 - __mh_execute_header
   1:        0x102b2c928 - __mh_execute_header
   2:        0x10359c43c - __mh_execute_header
   3:        0x1035a06a8 - __mh_execute_header
   4:        0x1035a41a0 - __mh_execute_header
   5:        0x1035a3f54 - __mh_execute_header
   6:        0x1035a475c - __mh_execute_header
   7:        0x1035a4544 - __mh_execute_header
   8:        0x1035a3220 - __mh_execute_header
   9:        0x1035a4310 - __mh_execute_header
  10:        0x105fb80e8 - __ZN4llvm15SmallVectorBaseIyE8grow_podEPvmm
  11:        0x103219394 - __mh_execute_header
  12:        0x1031e0a5c - __mh_execute_header
  13:        0x1031d0234 - __mh_execute_header
  14:        0x1031e545c - __mh_execute_header
  15:        0x1031e4c40 - __mh_execute_header
  16:        0x1031f8c00 - __mh_execute_header
  17:        0x1031fc0a0 - __mh_execute_header
  18:        0x1031f80f8 - __mh_execute_header
  19:        0x1031e0908 - __mh_execute_header
  20:        0x1031db690 - __mh_execute_header
  21:        0x1031d98e8 - __mh_execute_header
  22:        0x10311b6c0 - __mh_execute_header
  23:        0x1030b587c - __mh_execute_header
  24:        0x1030b1ac8 - __mh_execute_header
  25:        0x1030b4be4 - __mh_execute_header
  26:        0x1035a944c - __mh_execute_header
  27:        0x183f43034 - __pthread_joiner_wake
^C

Looks like it may be a dupe of https://github.com/roc-lang/roc/issues/6252
The line I added to cause this is
        yy <- consume stream (Str.concat acc xx) |> Task.await
        Task.ok yy

and 6252 has the same pattern
f = \list ->
    _ <- f list |> Task.await
    Task.ok {}

#6252 has a shorter and simpler reproduction, so I'm going to close this one.


Update Spack environment for Archer2

Ref https://github.com/ukri-excalibur/excalibur-tests/pull/185#issuecomment-1634458867

Didn't go through all the updates, but the ones I looked at look good! I assume you had a look at https://github.com/EPCCed/epcc-spack/commit/543a2b68bf48e42d0ad25dbca6916c5c7b841129?

I didn't see that commit, thanks for pointing it out!  I compared the changes here to those there, we should be very similar.


howdy test segment violation

On excute howdy test fail with output
Opening a window with a test feed

Press ctrl+C in this terminal to quit
Click on the image to enable or disable slow mode

QObject::moveToThread: Current thread (0x8fc4420) is not the object's thread (0x91c03a0).
Cannot move to target thread (0x8fc4420)

Violación de segmento

Kubuntu 18.04:
Howdy 2.3.0:
Python 3.6.5.

Thanks for the answer, This exceed my knowledge since the problem is the opencv library directly,  I'll try to investigate how to patch this issue with the namespace on Qt platform

Hi, I have the same issue on Linux Mint 19.3 (Ubuntu 18.04).
Any solution yet?


Payment gateway

The Payment Gateway requires a monetary subscription to be paid in order to avail the service. So, this feature has been dropped for now


Adopt icon font in outline/breadcrumbs/suggest widget

Related #78889 and fixes #78761
This adopts the icon font in the outline/breadcrumbs/suggest widget:

This also introduces color tokens for all of the symbol icons:

outlineDefaultSymbol.foreground
outlineMethodSymbol.foreground
outlineClassSymbol.foreground
outlineEnumeratorSymbol.foreground
outlineEnumeratorMemberSymbol.foreground
outlineEventSymbol.foreground
outlineFieldSymbol.foreground
outlineInterfaceSymbol.foreground
outlineVariableSymbol.foreground

And when configured, can look like this:

cc @aeschli for color token names

What does that blank-ish square in set/settimeout mean? Personally I don't find it that meaningful

Snippet. https://code.visualstudio.com/docs/editor/intellisense#_types-of-completions

@jrieken updated the pr with a minor change. The icons needed to be wrapped into their own container/element as the parent container with the .codicon class was affecting all child font properties, including the label. If you could take another quick look that'd be great.

@misolori I'd suggest the names
symbolIcon.methodForeground, symbolIcon.classForeground ...
I wouldn't define a color for symbolIcon.defaultForeground, but just use the default foreground color for it.

Forgot to update the main description, there is no default and each symbol kind has a color token. I also updated the naming convention based on your suggestions.

@jrieken ping 😄


Update readme with variant disc

Adding link to -v discussion... and giving myself some kudos damnit ;) (and fixing some links)

Your work is much appreciated!


Vue3 migration

There is a bug with the facets tag not being displayed on startup => open the demo => click on multiple facets => no tag will be displayed.
This is due to tagsChangedCallback is only called during a cascader event.  I will suggest calling the tagsChangedCallback in setCascader instead and get that function to work with the filterFacets array instead.


Update zh translation in basic-stateful-set.md

Update zh translation in basic-stateful-set.md

This has been inactive for about 2 months. Pls feel free to reopen.
/close


ScanQuery supports multi column orderBy queries

Fixes #12958.

Description

Scanquery supports multi column orderby queries to meet the requirements of sorting detailed data
MultiColumnSorter add more tests and tips

Key changed/added classes in this PR

OrderByLimitQueryRunner
OrderByLimitSequence
MultiColumnSorter
ScanQuery
ScanQueryLimitRowIterator
ScanQueryOrderByLimitRowIterator
ScanQueryQueryToolChest
ScanQueryRunnerFactory
MultiColumnSorterTests
ScanQueryResultOrderingTest
ScanQueryTest
DruidQuery

This PR has:

[x] been self-reviewed.

[x] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] added or updated version, license, or notice information in licenses.yaml
[x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[x] added integration tests.
[x] been tested in a test Druid cluster.

599166320, thanks for your contribution! The native query engines are quite complex. See the comments for a few things to think about.
As it turns out, we have been discussing the idea of using an operator approach to native queries. There is an issue with the discussion, and a now-closed PR with a first approach. Adding this sort operation would be so much simpler using that operator approach. That PR actually converted the scan query to use operators.
So, an alternative to this approach is to get that operator-based version of scan query committed, then add a sort operator. The merge operators that exist can be reused for the merge part of the sort/merge operation.
Finally, it is worth noting that if the user asks to sort by a single dimension, and Druid has already sorted that dimension, perhaps we can reuse that sort order to avoid the need to sort again. If the key is compound (multiple keys), then we would need to sort. This is the kind of "optimization" decision that the operator approach makes easier.

Thank you for your wonderful introduction to operator-based and Volcano (# 12641). This scheme is very helpful to the optimization of query engines. I also see that Druid is moving in this direction.
To get back to the point, if the user arranges the order in advance, it really does not need to be sorted again. At present, this PR temporarily solves the orderby problem of Druid ordinary columns. If it contains sorted columns, such as__ime , and the sorting algorithm mentioned in this PR will not be executed.
The logic of this judgment is mainly encapsulated in ScanQuery.scanOrderByNonTime.

@599166320, I had time to take another look at this PR and noticed you closed it. I wonder why? Working on a better version to appear in a later commit? Else, it would be great to get your work into Druid.

I'm making some improvements. I'll reopen this pr later


Doesn't run in Git for Windows Bash shell

Seems to be a problem with the stdin

C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\node_modules\terminal-menu\index.js:61
    process.stdin.setRawMode(true);
                  ^

TypeError: process.stdin.setRawMode is not a function
    at new Menu (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\node_modules\terminal-menu\index.js:61:19)
    at module.exports (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\node_modules\terminal-menu\index.js:8:12)
    at showMenu (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\menu.js:14:18)
    at Workshopper.printMenu (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\workshopper.js:311:14)
    at new Workshopper (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\workshopper.js:158:8)
    at Workshopper (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\workshopper.js:20:12)
    at Object. (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\runners.js:13:1)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)

Also running "winpty Seneca-in-practice" to get better terminal emulation returns

Error @2 starting Seneca-in-practice

What version of node are you trying to run this on? This issue seems to be related to https://github.com/substack/terminal-menu/issues/25

I tried both 0.10.40 (x32) and then 4.1.0 (x64) as I suspected a node version issue given the error
I'm using nvm-windows to switch but that is most unlikely to cause this issue.

Well it seems it should work. The following in a node 4.1.0 REPL in GfW Bash:

process.stdin.isTTY
true
process.stdin.setRawMode
[Function]

So perhaps the workshopper module is doing something weird?

Well, the error is from terminal-menu. It seems something related  with this: https://github.com/nodejs/node/issues/2333
Can you try other workshopper (e.g. learnyounode) with the same node /os set to confirm that?

Have you tried to run it in powershell?

Have you tried to run it in powershell?

Yes it's fine, and also in cmd shell.
I can use it, just not in the Bash shell I sit in all day. Fee free to close this as "won't fix". :)

Just for curiosity...which shell are you using? This one? http://win-bash.sourceforge.net/

No. It's the one that comes with Git for Windows. I'm not sure what exactly it is but it certainly appears that it's parentage is MinGW/MSYS. GitHub for windows also uses a version but I found that has been left behind Git for Windows.

Ah yes, they appear to be pulling upstream from CVS.


New Crowdin Translations

New Crowdin translations by Crowdin GH Action

:tada: This PR is included in version 1.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature: Configure IoT Edge device types on the portal

Is your feature request related to a problem? Please describe.
When using the portal, We can only add LoRa WAN network servers IoT Edge devices.
Describe the solution you'd like
Consider a way to add more device types.
Additional context
Each device types should also generate a Device Enrollment group in the DPS that would add the required tags to the device once it connect to the platform.

Added in US #531


Unable to access the New aws region India(ap-south-1)

When i tried to access the ec2 resources in aws India(ap-south-1) region, it is showing the error "unknown region".

ERROR:`  ArgumentError: Unknown region: "ap-south-1"

@Rijuvv,
I found that with knife-ec2 released version, the fog-aws gem version which was installed was 0.8.1 for me and it did not support the India region.
After upgrading the fog-aws gem to 0.9.4, the ec2 resources were accessible for India region.
gem install fog-aws -v 0.9.4


Portfolio walkthrough

Completed portfolio walkthrough. However, added more than one responsibility in a single PR because I was unaware of the inability to cherry pick commits to add to a PR. Will enforce smaller and more frequent PRs from now on.

Completed portfolio walkthrough. However, added more than one responsibility in a single PR because I was unaware of the inability to cherry pick commits to add to a PR. Will enforce smaller and more frequent PRs from now on.

Trying to have PRs contain a single responsibility is a nice goal, but don't worry too much about it, especially for the starter projects. I think this PR is totally fine.

Completed portfolio walkthrough. However, added more than one responsibility in a single PR because I was unaware of the inability to cherry pick commits to add to a PR. Will enforce smaller and more frequent PRs from now on.

Trying to have PRs contain a single responsibility is a nice goal, but don't worry too much about it, especially for the starter projects. I think this PR is totally fine.

Thanks for the feedback Gui, I'll continue with similar PRs for the starter projects.

Completed portfolio walkthrough. However, added more than one responsibility in a single PR because I was unaware of the inability to cherry pick commits to add to a PR. Will enforce smaller and more frequent PRs from now on.

Trying to have PRs contain a single responsibility is a nice goal, but don't worry too much about it, especially for the starter projects. I think this PR is totally fine.

Thanks for the feedback Gui, I'll continue with similar PRs for the starter projects.

I think the size of this PR was OK. README change could have gone in a separate PR, but it doesn't practically matter.
Another option is to squash your commits when creating a pull request, so they don't show up as individual entries on the 'master' branch: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-merges#squash-and-merge-your-pull-request-commits


How to use captcha implementation

I see that you have quickly implemented captcha support in WS, i am trying to catch up with it :-) thanks for quick implementation
So, when docker is starting up, it tries to login and generates captcha request event so client can send the captcha. In home assistant case, docker is always running in background and integration is connected to it later on.
Please help me to find answers for these;

are you sending captcha required events to clients who had connected after event is generated or client should connect before captcha event?
if client required to be connected before captcha event is generated, can i restart the sequence with a command by client, so client can get captcha event after sending a restart/reconnect request?

are you sending captcha required events to clients who had connected after event is generated or client should connect before captcha event?

The client should already be connected. I don't cache the events, because in the example of the captcha, the captcha is only valid for certain seconds and this would have to be managed.

if client required to be connected before captcha event is generated, can i restart the sequence with a command by client, so client can get captcha event after sending a restart/reconnect request?

Yes, if the client is not yet connected, you can send the command driver.connect and initiate a reconnection.

thanks


[docs] Update issues, questions and contributing

Moved stackoverflow questions to the 'community' section
Updated links for bug reports and feature requests
Updated the contributing descrtiption, added a 'thank you note' for contributors. Now we can just add a list to the end of this section.
Moved the 'badge' section to the end.

@testcafe-build-bot \retest

Also, we have a strange link in the Documentation section:
http://devexpress.github.io/testcafe/documentation/using-testcafe/
Is it deliberately Using TestCafe even though the default help topic is Getting Started?
https://devexpress.github.io/testcafe/documentation/getting-started/
(and it's not HTTPS by the way)


CLI Prettier logging (colors and formatting)

Would like some colors in my Horizon logs! I'd like to also potentially add some emojis too (only if you guys are cool with it).
Please let me know if you're interested. Would love to contribute

We now have a very pretty cli with emoji etc


Quality Changes

Now much faster at seeing what is already downloaded and skipping it.
Replaces most special characters that could cause issues.

@SpencerXZX Instead of uploading the new files, you could have made the changes in the scripts. Anyways, thanks for making this pull request :)


Replace build_bins.sh with a cookbook

Replace build_bins.sh with an invocation of chef-client local mode
Add the bach_repository cookbook to idempotently create the local repo
Install only ChefDK using shell scripts
Use S3 mirrors for Chef tools instead of packages.chef.io
Move spark_package step to bach_repository
First steps towards Chef 12.x client support

Why move the Spark package code out of bach_spark::spark_package into an uber cookbook? (Doesn't this defeat the goals of Chef-BACH #89 trying to split into smaller cookbooks that are self-contained per Apache project?

The repository of weird local packages is maintained by bach_repository.    In my opinion, bach_spark shouldn't rely on having separate recipes executed on an unknown package host to support clients.   That makes the cookbook totally, completely non-reusable, because it injects every bcpc-ism into it.

But the only bcpc-ism is the build_bin.sh step right? If we can do away with that, it should stand on its own? I'm concerned that we already build the equivs package for spark to be spark- but further, we will get into more Spark-specific wonkiness as we have to support both Spark 1.6.X and Spark 2.X for HDP 2.5.

The sloppy spark packages built with FPM already account for side by side installation.   The bach_spark cookbook assumes your packages are named after the version, as is the norm on Debian.
The bcpc-isms injected by adding a package creation recipe are considerable.  The recipe is only run on the bootstrap, only early in the build process, and requires in-depth knowledge of the repository structure.  This is what the bach_repository cookbook exists to do.


Problem with conkeyref resolution

This was discovered on OT 2.3.1 and exists still in 2.3.2.
If a bookmap contains a  element that contains an  element with a relative path in the @href attribute, all keyref file resolutions prepend the file resolutions with the relative path. That is, if the image @href contains something like ../../, that is prepended to all resolved file references for conkeyrefs.

So basically you have references to resources outside of the folder where the main DITA Map is located, right?
As far as I know such problems have always been around, even in DITA OT 1.8, if you are using Oxygen there is a parameter which you can set to avoid them:
https://www.oxygenxml.com/doc/versions/18.0/ug-editor/topics/dita-ot-external-refs.html

An oxygen solution won't work for the production environment which just
uses the ot.
sent from Android
On Sep 16, 2016 7:17 AM, "Radu Coravu"<EMAIL_ADDRESS>wrote:

So basically you have references to resources outside of the folder where
the main DITA Map is located, right?
As far as I know such problems have always been around, even in DITA OT
1.8, if you are using Oxygen there is a parameter which you can set to
avoid them:
https://www.oxygenxml.com/doc/versions/18.0/ug-editor/
topics/dita-ot-external-refs.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dita-ot/dita-ot/issues/2483#issuecomment-247576455,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG-ZidNVmv1QDJnjzzBCZYnsTR-IFNycks5qqnq7gaJpZM4J-0ld
.


Harvest problem

GlimmermanFX4:
I was seriously loving this mod and the idea of the agricraft farming station until i started trying to actually farm the capacitor seeds.  I have made sure they are set up exactly as you have described and on their mouse over tool tip it even says they are fertile and can grow.  The issue is when they are leveled up (all 10/10/10) they only give 1 crop ever and then never produce after that.  I have had a farming station with these active for days now along with an autonomous activator and watering can to make them grow and have never gotten more than what the initial planting yielded.  Is this by design or is this a bug? I'm seriously hoping this is some kind of bug or programming over site because if this is indeed by design it would most likely make this mod unplayable in my case at least. Everything in this latest update seems to depend solely on those plants and the harvesting of them.
TsumiHokiro:
I'm having the same problem as Glimmerman. I have planted the Capacitor seeds and have upgraded them till 10/10/10. While I was doing it, the first crop or first few ones I was able to harvest the crop, but as it went on, the harvest was diminishing to the point that, when I got to the perfect seeds, I wasn't able to harvest anything anymore. At first I thought that maybe it wasn't 100% sure that whenever you harvest it it yields fruits even though it accused being mature, however after several tries, and after planting several others, none of them, neither the original nor the other ones, were giving me fruits. As Glimmerman said, I wonder if this is a bug or something?.
If it helps, I'm running the game on a local server, and once I've restarted the server it does happens to give fruits, on the first few times it, but as I attempt to harvest it further on, it does not give anything at all, from none of the plants that I have planted (3 in total).
GlimmermanFX4:
Basically the same issue as TsumiHokiro explained below.  I may get one or two crops off the plants but after that they completely stop producing.  I'll dig them up and replant them and still they won't produce.
GlimmermanFX4:
They do grow and wailia shows them as mature when i mouse over then and so does the graphic of the plant but when harvested they will not drop anything and simply disappear as normal and start to grow again.

Can you try with this version:
EnderIOAddons-1.7.10-<IP_ADDRESS>1_beta-<IP_ADDRESS>_beta.jar
And report me what it writes to the (server) logfile when a plant is harvested? It should look like this:
[08:21:52] [Server thread/INFO] [enderioaddons]: Starting harvest for a capacitor plant with gain 6
[08:21:52] [Server thread/INFO] [enderioaddons]: Adding low level fruit: 1xitem.itemMachineParts@23
[08:21:52] [Server thread/INFO] [enderioaddons]: Adding low level fruit: 1xitem.itemMachineParts@23
[08:21:52] [Server thread/INFO] [enderioaddons]: Adding high level fruit: 1xitem.itemMachineParts@24
[08:21:52] [Server thread/INFO] [enderioaddons]: Harvest finished with 3 fruits: [1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23, 1xitem.itemMachineParts@24]

Hi I am the server owner for the server that GlimmermanFX4 plays on we ran the test that you asked us to. This version seems to be working correctly! This is the log:
[03:55:33] [Server thread/DEBUG] [FML/]: Gathering id map for writing to world save MEGAWorld
[03:55:37] [Server thread/INFO] [enderioaddons/]: Starting harvest for a capacitor plant with gain 10
[03:55:37] [Server thread/INFO] [enderioaddons/]: Adding low level fruit: 1xitem.itemMachineParts@23
[03:55:37] [Server thread/INFO] [enderioaddons/]: Adding low level fruit: 1xitem.itemMachineParts@23
[03:55:37] [Server thread/INFO] [enderioaddons/]: Adding high level fruit: 1xitem.itemMachineParts@23
[03:55:37] [Server thread/INFO] [enderioaddons/]: Adding high level fruit: 1xitem.itemMachineParts@23
[03:55:37] [Server thread/INFO] [enderioaddons/]: Harvest finished with 4 fruits: [1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23]
[03:55:39] [Server thread/INFO] [enderioaddons/]: Starting harvest for a capacitor plant with gain 10
[03:55:39] [Server thread/INFO] [enderioaddons/]: Adding low level fruit: 1xitem.itemMachineParts@23
[03:55:39] [Server thread/INFO] [enderioaddons/]: Adding low level fruit: 1xitem.itemMachineParts@23
[03:55:39] [Server thread/INFO] [enderioaddons/]: Adding high level fruit: 1xitem.itemMachineParts@23
[03:55:39] [Server thread/INFO] [enderioaddons/]: Adding high level fruit: 1xitem.itemMachineParts@23
[03:55:39] [Server thread/INFO] [enderioaddons/]: Harvest finished with 4 fruits: [1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23]
[03:55:40] [Server thread/INFO] [enderioaddons/]: Starting harvest for a capacitor plant with gain 10
[03:55:40] [Server thread/INFO] [enderioaddons/]: Adding low level fruit: 1xitem.itemMachineParts@23
[03:55:40] [Server thread/INFO] [enderioaddons/]: Adding low level fruit: 1xitem.itemMachineParts@23
[03:55:40] [Server thread/INFO] [enderioaddons/]: Adding high level fruit: 1xitem.itemMachineParts@23
[03:55:40] [Server thread/INFO] [enderioaddons/]: Adding high level fruit: 1xitem.itemMachineParts@23
[03:55:40] [Server thread/INFO] [enderioaddons/]: Harvest finished with 4 fruits: [1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23, 1xitem.itemMachineParts@23]

Also the version my server was running that had the problem was: EnderIOAddons-1.7.10-<IP_ADDRESS>0_beta-<IP_ADDRESS>_beta
The server will be updating to the EnderIOAddons-1.7.10-<IP_ADDRESS>1_beta-<IP_ADDRESS>_beta version once curse pushes my modpack update.

Ok, as the only difference between the latest release and the version I gave you is the debug output, I'll assume whatever the cause was, it is fixed in the latest release.


sway-gaps dispatches invalid command if called according to the docstring in the sway-gaps function

Hi, I think there is a bug in the sway-gaps function. I installed guile-swayer using the GNU Guix package, the package definition for which can be found here:
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/guile-xyz.scm#n1032
I'm running version 0.3.0.
I wrote this code to set the inner gaps of all workspaces to 10px, but it gives an error when run from the Guile REPL and does not set the gaps when placed in my guile swayer config file:
(sway-gaps SWAY-GAPS-OPTION-INNER SWAY-GAPS-WORKSPACE-ALL 10)

Here is the full output of the Guile REPL:
GNU Guile 3.0.9
Copyright (C) 1995-2023 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> (use-modules (oop goops)
             (srfi srfi-18)
             (modules workspace-groups)
             (modules workspace-grid)
             (modules general)
             (ice-9 pretty-print)
             (swayipc))

(sway-connect-sockets!)
$1 = #t
scheme@(guile-user)> (sway-gaps SWAY-GAPS-OPTION-INNER SWAY-GAPS-WORKSPACE-ALL 10)
dispatching: gaps inner all 10
$2 = (#<<sway-tick> success: #f parse-error: #t error: "Expected 'gaps inner|outer|horizontal|vertical|top|right|bottom|left current|all set|plus|minus|toggle <px>' or 'gaps inner|outer|horizontal|vertical|top|right|bottom|left <px>'">)

According to the docstring and declaration of the sway-gaps function, I called it correctly to do what I want it to do:
(define* (sway-gaps option workspace amount #:key (exec #t))
  "Changes the inner or outer gaps for either all workspaces or the current workspace.
  parameters:
    - option: `SWAY-GAPS-OPTION-INNER`, `SWAY-GAPS-OPTION-OUTER`, `SWAY-GAPS-OPTION-HORIZONTAL`,
              `SWAY-GAPS-OPTION-VERTICAL`, `SWAY-GAPS-OPTION-TOP`, `SWAY-GAPS-OPTION-RIGHT`,
              `SWAY-GAPS-OPTION-BOTTOM`, `SWAY-GAPS-OPTION-LEFT`
    - workspace: `SWAY-GAPS-WORKSPACE-ALL`, `SWAY-GAPS-WORKSPACE-CURRENT`, `SWAY-GAPS-WORKSPACE-SET`,
                 `SWAY-GAPS-WORKSPACE-PLUS`, `SWAY-GAPS-WORKSPACE-MINUS`, `SWAY-GAPS-WORKSPACE-TOGGLE`
    - amount: amount of gap (number)

I called the function with the correct parameters, but it didn't do what I expected.
Judging by the error message, it seems like this can be fixed by adding another parameter to the function that matches with the set | plus | minus | toggle option expected by sway. Then you could just add that parameter into the call to format. I haven't tested this idea yet but I will update when I do it and if it works.
I don't think this is an issue with my setup, since all other code in my guile-swayer config works as expected.

Thanks for testing the project and taking the time to analyze and report this bug!
It seems like the format is invalid as you mentioned, I will work on fixing that, there are 2 formats for gaps in sway. guile-swayer implements those as sway-gaps and sway-default-gaps
sway-default-gaps will change default gaps of new workspaces
sway-gaps will change gaps on selected workspaces
It seems like only sway-gaps needs fixing, I will push an update and let you know

Thanks for responding so quickly! I really appreciate that. Thanks for taking a look. I really love this project, great job!

I just pushed a commit c09e4b16d9fcfad79937bdccff4808ef039b451a, it should fix the sway-gaps function now, a new parameter is introduced sway-gaps-type. Happy hacking!
(sway-gaps SWAY-GAPS-OPTION-INNER SWAY-GAPS-WORKSPACE-ALL SWAY-GAPS-TYPE-SET 10)

Amazing! I'll contact the maintainer of the guix package about this commit so they can update the package if need be. Happy hacking to you too!

The definition in guix is pointing now at v0.3.0
You can see this here
             (commit (string-append "v" version))))

If I am not mistaken, guix also accepts a commit, for example
             (commit "c09e4b16d9fcfad79937bdccff4808ef039b451a")))

Note: the sha256 signature will also have to be updated.
In case needed, I can release v0.3.1 if the commit solved your problem

I am closing this since it should be fixed by https://github.com/ebeem/guile-swayer/commit/c09e4b16d9fcfad79937bdccff4808ef039b451a, please reopen in case your still facing the problem
Thanks


[WIP] build(deps): update RxJs to 5.0.0-rc.4 (restored)

Restored the reversed PR #2905
Was committed in Angular by https://github.com/angular/angular/commit/2d6a003dba165436d8e09a2eca3e01d5a545d4e3 on Nov 29

Superseded.


geekbench5: add compute benchmark support

Motivation for this change
I want to use the compute benchmark.
Fixes https://github.com/NixOS/nixpkgs/issues/87990
Devices are detected now:
OpenCL
0 0 AMD Radeon (TM) RX 480 Graphics (POLARIS10, DRM 3.36.0, 5.6.13, LLVM 9.0.1)
Vulkan
0 0 AMD RADV POLARIS10 (LLVM 9.0.1)

OpenCL benchmark fails, but Vulkan works.
cc maintainer @michalrus
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size: Closure size difference is 328.81 MB (189.28%).
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Still works after the update in https://github.com/NixOS/nixpkgs/pull/94418.

/marvin opt-in
/status needs_reviewer

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/199


add: ankushtripathii

Description
[Include a brief description of the changes you've made]
Related Issues
[Include any related issues or pull requests that this PR addresses or is related to. Use GitHub's shorthand syntax to link to them, like #1234.]
Changes Proposed
[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]
Checklist

[ ] I have read and followed the Contribution Guidelines.
[ ] All new and existing tests passed.
[ ] I have updated the documentation to reflect the changes I've made.
[ ] My code follows the code style of this project.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@ankushtripathii Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


"Allow unsafe code in this project" does nothing on Linux

Environment

Linux Mint 64 bits (Bionic) with Cinnamon
VS Code 1.41.1
.NET Core 3.1
Official C# extension installed: ms-vscode.csharp 1.21.9

Repro steps

Created a C# project using "dotnet new console".
In Program.cs, I added an "unsafe" method.
VS Code adds the red squiggly line on my new method. I click on the lightbulb and the popup menu says "Allow unsafe code in this project".

Expected
The .csproj file will be modified, and the <AllowUnsafeBlocks>true</AllowUnsafeBlocks> line will be added
-or-
The build .json file will have the "/unsafe" argument automatically added.
Either way, I was expecting VS Code to be able to automatically remove that error. I don't really mind if the problem is fixed instantly or the next time I build.
Actual
Nothing happens - the .csproj and the .json file are unmodified. If I try to build, I get a build error that unsafe code is not allowed unless I add "/unsafe".
Partial workaround
I had to add <AllowUnsafeBlocks>true</AllowUnsafeBlocks> manually to my .csproj, and the project can now build successfully, but the red squiggly line is still under my unsafe method.
Edit:
This issue from Oct 2019 seems to be related, but only talks about the squiggly line not going away: https://github.com/OmniSharp/omnisharp-vscode/issues/3349
@filipw asked for the code that reproes it, here's mine (the squiggly red line shows up on top of Test):
namespace Test
{
    class Program
    {
        unsafe void Test()
        {
        }

        static void Main()
        {
        }
    }
}

@filipw. Yes, the code fix (right clicking on the lightbulb suggestion) does not do the expected automatic change in the csproj, and manually updating the csproj file fixes the issue but VSCode keeps reporting a problem.
Apologies for the late reply, @filipw. I went on vacation and missed this notification somehow.

@filipw did you get a chance to look into this? Is there a chance this is an issue on VS Code and not in OmniSharp?

I can confirm this
I am under kubuntu 20.10 and clicking on the lightblub and allow unsafe doesn't get rid of the errors

This also happens to me on Windows 10:
Version: 1.63.2 (user setup)
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:40:02.816Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

VSCode version: 1.63.2
C# Extension: 1.23.17
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   6.0.100
 Commit:    9e8b04bbff
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19043
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\6.0.100\
Host (useful for support):
Version: 6.0.0
Commit:  4822e3c3aa
.NET SDKs installed:
5.0.403 [C:\Program Files\dotnet\sdk]
6.0.100 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

csharp
ms-dotnettools
1.23.17

This looks to be an issue with O#. If you are still running into this problem, please open a new issue at https://github.com/dotnet/csharp-tmLanguage/issues


readme: update

Since Unvanquished's readme mention building the engine is only needed to run the game and link to this repository shipping readme, add some basic instructions about how to run a game or a server.

@DolceTriade
Maybe link to dist/server.cfg for config options and our wiki page https://wiki.unvanquished.net/wiki/Server/Running

I added a link to the Unvanquished readme explaining that (no need to duplicate the Unvanquished readme).
Changes since the last review:

I added more links to Unvanquished.
Some minor wording changes.
I tried to add some ℹ and 💡 emojis to mark some “ℹ  Notable info” and some “💡 Clever trick”. What do you think about it?


encode_and_sign without hooks?

It would be nice from a testing perspective to be able to generate a throwaway token for testing, especially when using GuardianDB.
If I've missed this utility somewhere I apologize. If not, I'd definitely be up for submitting a PR.

You can apply your hooks in prod, staging and dev if you want and leave it out of test. Would that work for you?

I think there's value in being able to use hooks in testing to create a valid user. This might be specialized purely towards guardiandb, but having access to both in testing allows a user like myself to make the assertion that all is well and the "user" must have a valid JWT issued by my application.
I don't see a way to do this, though if it's inbuilt I apologize and would ask for reference.

You can use a combination of setup and on_exit to remove the hooks.
setup_all do
  hooks = Application.get_env(:guardian, :hooks)
  Application.put_env(:guardian, :hooks, nil)
  on_exit(make_ref, fn -> Application.put_env(:guardian, :hooks, hooks) end)
  {:ok, []}
end

I think something like that would do what you're looking for.

Yep, that worked perfectly, thanks!


Keyboard Manager - groups of selective key remapping

Description of the new feature / enhancement
Could you add an option to de/activate multiple key remap at once after setting them up (and maybe even add popular presets).
Otherwise
Scenario when this would be used?
For example for keyboards that don't have the numpad, could add an option to group all keys you'd like to convert (e.g 0-9) to numpad keys 0-9 and deactivate when you don't need it, without turning off keyboard manager in case that you still need to remap different keys.
Supporting information
Right now it seems like you'd have to go through the hassle of removing/adding keys to remap back and forth in such a scenario

/dup https://github.com/microsoft/PowerToys/issues/6573


KPP: some cleanup and regularisation

What changes does this PR introduce?
Add new code features and options and minor bug fixes
What is the current behaviour?
these options were not available before
What is the new behaviour

add CPP-flags to turn off diffusivity matching at bottom of boundary layer
add CPP-flag to turn on taper shear mixing in the case of very small shear
add FLAG to turn on smooth regularisation of divisions by small numbers: 1/(var+eps) instead of 1/MAX(var,eps)
fix KPP_ESTIMATE_UREF code also for high resolution: introduce vertical averaging if zRef>drF(ksurf)
fix a small masking error
fix some unfortunate loop ordering and spurious recomputations
fix some comments
add new diagnostics KPPshsq, KPPdVsq

Does this PR introduce a breaking change?
No, reference results are reproduced and since all of the new flags are undefined by default, they don't do anything.
Other information:
already merged with PR #340 so that if this PR is merged PR #340 can be closed.
Suggested addition to tag-index
Add new code features and options and minor bug fixes:

add CPP-flags to turn off diffusivity matching at bottom of boundary layer
add CPP-flag to turn on taper shear mixing in the case of very small shear
add FLAG to turn on smooth regularisation of divisions by small numbers: 1/(var+eps) instead of 1/MAX(var,eps)
fix a small masking error
fix some unfortunate loop ordering and spurious recomputations
fix some comments
add new diagnostics KPPshsq, KPPdVsq

@mjlosch Have a question regarding how this PR (#346) relates to PR #340 and how we should
review and proceed towards merge-in:
Seems that it does include PR #340 (instead of relying on this other PR). Am I right ?
@jahn and @edoddridge what does it means in terms of review and path towards merging ?

That's correct, I have merged the branch 'kpp_fix_uref', which is the content of PR #340, into this branch.
PR #340 includes only quick fixes related to KPP_ESTIMATE_UREF so that the code compiles and so that log does not have negative arguments. In this PR #346 I added extra code to KPP_ESTIMATE_UREF to account for very high vertical resolution by vertical averaging the horizontal velocities vertically over 0.1*MLD. This is experimental, and may not be useful (because 0.1*MLD > drF(1) is really rare), but since @mmazloff said, he would want to use this code, I thought, I'd contribute this suggestion.
If you would like to go ahead with this PR, we can close PR #340 after this is merged. If you don't want the stuff in this PR, then I suggest to merge PR #340 instead, so that the compilation problem is solved.

Thank you very much @mjlosch !

Hi Martin, why "vertical averaging the horizontal velocities vertically over 0.1*MLD". At least the initial intention of KPP_ESTIMATE_UREF was to avoid vertical averaging and to estimate the actual surface current better.   But I can imagine that definition of surface current might be a little fuzzy in presence of surface gravity waves.  Perhaps a minimum depth in m, e.g., 1 or 2 m, might be better choice?
Dimitris Menemenlis

On May 8, 2020, at 1:18 AM, Martin Losch<EMAIL_ADDRESS>wrote:
That's correct, I have merged the branch 'kpp_fix_uref', which is the content of PR #340, into this branch.
PR #340 includes only quick fixes related to KPP_ESTIMATE_UREF so that the code compiles and so that log does not have negative arguments. In this PR #346 I added extra code to KPP_ESTIMATE_UREF to account for very high vertical resolution by vertical averaging the horizontal velocities vertically over 0.1MLD. This is experimental, and may not be useful (because 0.1MLD > drF(1) is really rare), but since @mmazloff said, he would want to use this code, I thought, I'd contribute this suggestion.
If you would like to go ahead with this PR, we can close PR #340 after this is merged. If you don't want the stuff in this PR, then I suggest to merge PR #340 instead, so that the compilation problem is solved.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@menemenlis there are two cases. In one case, drF(1) is large and the ocean velocities at level k=1 may be a bad approximation for the surface velocities; this is the case that you had in mind, I guess (and it is still in the code with IF ( zRef .LT. drF(1) ). The other case is very high vertical resolution (e.g. drF(1) < 1m). The KPP code is sprinkled with comments like this one:
c     when using a very fine vertical grid, these values should be
c     computed as the vertical average of velocity and buoyancy from
c     the surface down to epsilon*zgrid(kl).

and this is what I have tried to implement (you find these statements also in Large et al. 1994, e.g. on page 372, end of first paragraph). In fact, one could/should also add code to estimate a reference density for the computation of bulk density gradients (and bulk Richardson numbers), but that does not fit into this part of the code.
I think/hope that my new code also covers the case zref==drF(1), when uRef is just uVel at k=1.

Thank you Martin.  It’s great that you managed to keep the KPP_ESTIMATE_UREF stub alive.
Maybe one day someone will find it useful.  I guess for this (an other obscure stubs in MITgcm)
to become useful, one would have to evaluate and adjust empirical parameters vs observations.
Cheers, Dimitris

On May 11, 2020, at 12:17 AM, Martin Losch<EMAIL_ADDRESS>wrote:
@menemenlis https://github.com/menemenlis there are two cases. In one case, drF(1) is large and the ocean velocities at level k=1 may be a bad approximation for the surface velocities; this is the case that you had in mind, I guess (and it is still in the code with IF ( zRef .LT. drF(1) ). The other case is very high vertical resolution (e.g. drF(1) < 1m). The KPP code is sprinkled with comments like this one:
c     when using a very fine vertical grid, these values should be
c     computed as the vertical average of velocity and buoyancy from
c     the surface down to epsilon*zgrid(kl).
and this is what I have tried to implement (you find these statements also in Large et al. 1994, e.g. on page 372, end of first paragraph). In fact, one could/should also add code to estimate a reference density for the computation of bulk density gradients (and bulk Richardson numbers), but that does not fit into this part of the code.
I think/hope that my new code also covers the case zref==drF(1), when uRef is just uVel at k=1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/MITgcm/MITgcm/pull/346#issuecomment-626517927, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABH7CSO2QEMXYG4AL72W2YDRQ6RA3ANCNFSM4MVLLAXA.

@jm-c I think that this is now ready for review

@jm-c thank you for taking a look. This is now so long ago, that I need to get back into this myself. The comment "No, reference results are reproduced ..." was obviously put there for code without KPP_ESTIMATE_UREF. And I just just confirmed that if you undef this flag in "vermix", the numbers are good again. In e35d5fd I defined this flag for "vermix", so that we actually test this code. If you agree with this change, I will add the description above and for tag-index, and then ask you to update the result on the reference. The comment is still correct: as long as you don't define KPP_ESTIMATE_UREF, nothing changes ...

I agree with these changes and just updated vermix output.txt file.

Thanks @jm-c
I modified the doc-suggestion. Would it be useful to also define the other new cpp flags KPP_SMOOTH_REGULARISATION and KPP_SCALE_SHEARMIXING in vermix? Maybe not in this PR.
Other than that, I think this is ready.

@mjlosch This sounds good, going to merge this PR later today. And just to clarify, KPP_ESTIMATE_UREF is defined
in current vermix experiment (was turned on in PR #340), so probably better not to add anything else in this PR and if
we want to switch other option it would be better in an other PR.


Improve readme.md (closes #1)

As announced here: https://github.com/Android-Boot-Manager/droidboot_device_volla_yggdrasil/issues/1#issuecomment-663950786
Note: This PR contains 3 commits (no separate feature branch, no rebase or merge squash into one commit since the PR target uses only one branch)

About How does the config file looks like? Which steps are required to add a new operating system? - you just use the Android(/VollaOS) App to do all that.

And there are merge conflicts

The merge conflicts are due to this commit after forking:
https://github.com/Android-Boot-Manager/droidboot_device_volla_yggdrasil/commit/486e4c47c8fcddb28d729c929876a87d87aa9aa8
I can integrate these changes into my PR, but to solve the merge conflict you have to keep my changes as one ("take theirs") I guess.
Just a minute...

About How does the config file looks like? Which steps are required to add a new operating system? - you just use the Android(/VollaOS) App to do all that.

What exactly do you mean with "use the Android App"? Which App? I am aware of the menu you get when you switch off the phone to select entries like "switch off", "reboot", "reboot into recovery"...

About How does the config file looks like? Which steps are required to add a new operating system? - you just use the Android(/VollaOS) App to do all that.

What exactly do you mean with "use the Android App"? Which App? I am aware of the menu you get when you switch off the phone to select entries like "switch off", "reboot", "reboot into recovery"...

https://github.com/Android-Boot-Manager/App

The App README has mostly dead links tho

We didn't write docs yet ^^

We also have an Telegram group, https://t.me/andbootmgr - check it out to know more about the project

OK, I have integrated the upstream changes to fix the merge conflict. I hope it is OK now...


Adding "idle-timeout-seconds" terraform variable in for vertex_workbench_notebook pipeline

TL;DR
Hello,
We wuld like to add new terraform variable (idle-timeout-seconds) to control idle vertex ai notebooks for vertex_workbench_notebook. Probably needs to be added into "vertex.tf"
Could you please help us ?
Thanks,
İmran
Terraform Resources
https://cloud.google.com/vertex-ai/docs/workbench/instances/idle-shutdown
https://github.com/terraform-google-modules/terraform-docs-samples/blob/HEAD/vertex_ai/workbench_idle_shutdown/main.tf

Detailed design
No response
Additional information
No response

As of 5.17.0, google_notebook_instance is deprecated, and the docs suggest using google_workbench_instance instead. As you linked, this resource already includes the idle-timeout option you are after.


Http server support

add http server && add TSV,TSVWithNames format

Codecov Report

Merging #5 into master will decrease coverage by 1.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   82.67%   81.62%   -1.05%
==========================================
  Files          64       65       +1
  Lines        1437     1453      +16
==========================================
- Hits         1188     1186       -2
- Misses        153      171      +18
  Partials       96       96

Impacted Files
Coverage Δ

src/executors/execute_query.go
0% <0%> (ø)

src/processors/mock.go
93.75% <0%> (-6.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0b485...6b2e996. Read the comment docs.

This works.  But there are lots of things to do in the future.
➜  ~ curl -XPOST http://<IP_ADDRESS>:8123 -d "select * from range(1,10)"
1
2
3
4
5
6
7
8
9

LGTM


add nft_token_metadata implementation (necessary for NFT to appear in wallet)

I was following this NFT tutorial and no matter what I do I could not get the NFTs that i was minting to show up in any of the wallets.
I traced the NEAR wallet code and found this line
which is calling nft_token_metadata function and that was causing a wasm execution failed with error: MethodResolveError(MethodNotFound).
I implemented this function on my contract and the NFT appeared on the wallet.

this has been stalled for almost a year, please re-open if necessary


SLL handshake error?

If I start mycroft pointed at the local server, I get a TLS error:
./start-mycroft.sh debug
Already up to date.
Starting all mycroft-core services
Initializing...
Starting cli
12:27:59.603 - mycroft.api:is_paired:514 - WARNING - Could not get device info: SSLError(MaxRetryError('HTTPSConnectionPool(host=\'<IP_ADDRESS>\', port=6712): Max retries exceeded with url: /v0.1/device/ (Caused by SSLError(SSLError("bad handshake: Error([(\'SSL routines\', \'tls_process_server_certificate\', \'certificate verify failed\')])")))'))

It seems Mycroft doesn't like self-signed certificates? How can that be changed?

You have to add the self signed cert to your local python keystore, then you can make this work.
There's also let's encrypt, though you have to renew pretty regularly.

during testing i disabling verification to simply ignore this error, in the requests library this means simply adding verify=False (in mycroft-core api code)
self signed certificates are not safe, i think this error should be there, it will go away if you do what el-tocino said, if we just silence the error we are giving a false sense of security and you will be vulnerable to man in the middle attacks
we def need documentation on setting up proper lets encrypt certificates however

How do I add it to my local keystore? By adding a path?

in the requests library this means simply adding verify=False (in mycroft-core api code)

How do I do that?

Google adding self-signed to the python keystore, lots of documentation on that, same with the requests library.

I did, but the solution I found (adding a path) didn't work?

No idea what "adding a path" means.
https://stackoverflow.com/questions/30405867/how-to-get-python-requests-to-trust-a-self-signed-ssl-certificate
https://stackoverflow.com/questions/39356413/how-to-add-a-custom-ca-root-certificate-to-the-ca-store-used-by-pip-in-windows
Python isn't usually compiled, it's interpreted, so making changes usually just requires a restart of things.

if you are running on the same device you do not need to use ssl, i also recommend using <IP_ADDRESS> as host instead of <IP_ADDRESS>

Alright, I now have tried this:
~/mycroft-core/mycroft/configuration/mycroft.conf
  // Address of the REMOTE server
  "server": {
    "url": "http://<IP_ADDRESS>:6712",
    "version": "v0.1",
    "update": true,
    "metrics": true,
    "ssl": false
  },

  // The mycroft-core messagebus websocket
  "websocket": {
    "host": "<IP_ADDRESS>",
    "port": 8181,
    "route": "/core",
    "ssl": false
  },

  // The GUI messagebus websocket.  Once port is created per connected GUI
  "gui_websocket": {
        "host": "<IP_ADDRESS>",
        "base_port": 18181,
        "route": "/gui",
        "ssl": false
  },

~/.mycroft/personal_backend
{
"backend_port": 6712,
"website_port": 5000,
"ssl": false,
"ssl_key": "/home/pi/.mycroft/personal_backend/certs/MycroftPersonalServer.key",
"ssl_cert": "/home/pi/.mycroft/personal_backend/certs/MycroftPersonalServer.crt$
"mail_port": 465,
"mail_server": "smtp.blablabla.com",
"mail_user"<EMAIL_ADDRESS>"mail_password": "xxx",
"secret_key": "MY_PRECIOUS_SECRET_KEY",
"salt": "MY_TABLE_SALT"
}

I've modified the code to avoid the requirement to verify an email address.
By the way, I noticed the certificate generation python script uses SHA1 instead of SHA256. I notived this because Chrome gave a warning/error about the certificate being too unsafe.


[Http Connector] Client Connector undefined error comes when used the . operator to invoke action

Build id: 402
Sample Code
package scenario1;

import ballerina.net.http;

@http:BasePath {value:"/http"}
service contentBasedRouting {

@http:GET {}
@http:Path {value:"/call/{code}"}
resource httpResource (message m, @http:PathParam {value:"code"} string codeValue) {
string connection = "http://localhost:9793/BalRestService/rest/restService";
string resourcePath = "/codes/";
resourcePath = resourcePath + codeValue;
message request = {};
message response = {};
http:ClientConnector httpCheck = create http:ClientConnector(connection);
response = httpCheck.get(resourcePath, request);
reply response;

}

}

Console output
scenario1/IntegratorService.bal:18: undefined connector 'ClientConnector'
Relevant code line
response = httpCheck.get(resourcePath, request);

pull merged hence closing


Manual PoW integration test

Upload and set the system calls in the PoW in koinos/koinos-system-contracts and verify the block producing can successfully submit blocks in PoW mode.

Manual testing was successful. Mining on multiple machines ran for over 12 hours. We ran in to a problem unrelated to the PoW work during this test. (koinos/koinos-chain#402)


Add color input by hex and hsl.

hex, rgb, hsl are all supported inputs as the start color. In the app itself at the moment it's just hsv, rgb and hex.


More clearly identify cases for non-trivial transfers

[Enter feedback here]
Understanding that

manually moving resources can be disruptive/complex/prohibitive (i.e. as per https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/move-support-resources); and
changing the service tenant can be disruptive/complex/prohibitive (i.e. as per https://docs.microsoft.com/en-us/azure/role-based-access-control/transfer-subscription if this is the case)

Is it possible for this article to to give absolute clarity for each product transfer, to say if it

does or does not require manually moving resources, and under what circumstances
does or does not require changing the service tenant, and under what circumstances

And could the article provide clear supporting examples, to illustrate cases where the transfer will not be trivial? Meaning, the transfer will require engineering effort within affected subscriptions

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39e27055-9b5c-3fb6-2a01-912ebbc302dc
Version Independent ID: 13e129d7-0973-3a10-4b1b-5a8da7f0a03d
Content: Azure subscription and reservation transfer hub
Content Source: articles/cost-management-billing/manage/subscription-transfer.md
Service: cost-management-billing
Sub-service: billing
GitHub Login: @bandersmsft
Microsoft Alias: banders

@mikewo-dc
Thanks for your feedback! We will investigate and update as appropriate.

@mikewo-dc Hi there. There are many Azure transfer scenarios and the focus of this article is to cover those that are supported. As such, this page has only generic guidelines. You can ask any transfer-specific questions to the Azure support team with a support request.
#please-close


Remove invertible package flags

Remove the flag settings for invertible. These are now set to manual in <IP_ADDRESS>, with arrows and piso disabled by default. My understading is stackage should still be able to pull in HList and TypeCompose, so trying that out here. Maybe related to #2305.

Apparently this does not work. @bergmark in dylex/invertible#2 thought it would. I'm disinclined to make -HList the default in the package itself, so I'm not sure how else to disable this flag for stackage.

After further consideration I'm going to remove the hlist bits, at least by default, and then will resubmit this.


feat: add mkMultipleMappingOption

same as mkMappingOption but allows for multiple keybinds

turns out I can't inherit defaults because there's no defaults in mkOption
should I just change the name to default or default = defaults;?


mirrors.py has problem

superthin@myubuntu:~/github/apt-select$ ./apt-select.py -c -t 3 -m one-week-behind
Getting list of mirrors ... done.
Testing 3 mirror(s) [3/3] 100%
Looking up status(es) [0/3] 0%Traceback (most recent call last):
File "./apt-select.py", line 226, in
flag_status
File "/home/superthin/github/apt-select/mirrors.py", line 108, in getInfo
if "unknown" in status:
TypeError: argument of type 'NoneType' is not iterable
My Ubuntu version/ edition is Ubuntu 14.04 LTS.

It seems the Launchpad page for the third mirror was unable to be parsed for status.  I've added a fix in commit 160fd40 to check first for a NoneType before comparing to a string or list of statuses.  Also, commit 7cc3a3e will provide the Launchpad url for the mirror of which the status was unable to be parsed.
After updating your program with the recent changes (git pull), a report back with the mirror url that is unable to be parsed would be appreciated.  Then, I'll be able to better understand why the regex did not match.


Wrong account balance. Can't send and receive sats- X unknown error

Hi there. I am a subscriber in Mutiny wallet. Yesterday I received a big zap in a nostr client. When I checked my Mutiny balance the zaps where not there.
People also told me in nostr that they can't zap me.

If you restore from seed, it'll scan through the zaps again. A known issue we'll hopefully fix soon.

right. Restore and everything is there 👍


Stretch aspect keep & keep_width rendering issue on Android

Godot version:

3.0 stable official
OS/device including version:

Google Nexus 4, Android 5.1.1
Issue description:

Please see screenshots attached from Nexus 4.
I noticed rendering issues while testing project on Google Nexus 4 when screen stretching aspect is set either to keep or keep_width(it doesn't matter whether the mode is 2d or viewport). When screen stretching aspect is set to expand, keep_height or ignore, everything seems to be working(at least rendering looks normal).

Steps to reproduce:
Set screen stretching aspect to either "keep" or "keep_width"
Minimal reproduction project:

Can confirm
Godot version:
3.0.2 stable official
OS/device including version:
Oneplus X (E1003), Android 5.1.1
Screenshot 1: viewport/keep

Screenshot 2: viewport/expand

Is there a work-around for this, such as setting the aspect ratio option to something else?

I am having the same issue on my OnePlus One but the exported apk works fine on Nexus 7 (2013).
Don't know what is the difference between these two devices other than the obvious difference of OS.
This is how it looks..

Project having problem
Test1.zip
Edit -
Godot Version

Export Template

Nexus 7 (2013) Android Version 6.0.1
OnePlus One Android Version Cyanogen Android Version 6.0.1
I found out more details now as follows -
The issue happens even when I don't have any node in my scene.
On Nexus 7 (2013), issue happens when the stretch settings are as follows:

On OnePlus One the issue happens when the stretch settings are as follows:

Please help..

@ravisharma1987 are you able to easily test against Godot 3.1 to see if this is fixed there?

Hello,
I tested with 3.1 Beta 9, and I can see the problem still existing. I tried also on Linux build and Windows build and the problem is existing still.
Please let me know if you need any more details about my environment.
Thanks.

tested with c00429c33 on Kubuntu 19.04 / gtx 1070ti

@volzhs Sorry for not being clear. My screenshot is on the device Nexus 7 (2013) but in the editor everything looks perfectly fine.

oh i misunderstood by the linux and windows part that you mentioned. sorry.

Is this still reproducible in the latest 3.2 builds?

No answer, so closing. Please comment if you can still reproduce the issue.


Waypoints implementation with slash command to test /setwaypoint

Relates to #519
Additions/modifications proposed in this pull request:

SendWaypoints event
/setwaypoint to test. NOTE: client will only set waypoint if the idx is equal to the client-side idx. This creates a small issue where you cannot simply set a waypoint without one having been set already. In the future, we'll be able to do with with Tasks or Contacts. Right now, the only mechanism for doing so with in the UI (clicking on the map)
Cleaned up a couple of small bugs in slashcommands
Moved SetDestination to Waypoints.h for organization

Another interesting thing here: if you don't close the client between sessions, the idx will continue to be iterated on the client side. :man_shrugging:


sktime v0.12.1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Related:

https://github.com/alan-turing-institute/sktime/issues/2921
https://github.com/conda-forge/sktime-feedstock/issues/44

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The build section contained an unexpected subsection name. numpy is not a valid subsection name.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender


dsl?

What is dsl?
It provides rich DSL to setup GraphQL schema ...

Hi @larsespen9, DSL is abbreviation for Domain Specific Language, please see: https://en.wikipedia.org/wiki/Domain-specific_language, or more Kotlin-specific source: https://kotlinlang.org/docs/reference/type-safe-builders.html


SAMZA-1951: Make JMX enabled/disabled using configs for Samza containers

merged and submitted. Thanks @Sanil15 for the contribution and @shanthoosh for reviews!


Add Solutions for Internal Series 2

Think it happened because my commit was for an older version of the website. Is there a way for you to reject the pull request? I'll ask Meta to add the solutions on Firebase.


Feature/wllmwu/1073272314 task form

Administrative Info
Monday Board ID: 851212620
Make sure your branch name conforms to: <feature/staging/hotfix/...>/[username]/[Monday Item ID]-[3-4 word description separated by dashes]. Otherwise, please rename your branch and create a new PR.
Changes
What changes did you make?

Add TaskForm

Currently displayed over blank Agency page at the new route /agency/<whatever id>
Submission/cancellation will be implemented with the Agency page

Add AgencyTask schema, add tasks field to Agency schema (expects an array of AgencyTasks)

Update validators

Move AgencyProfileForm stuff to /frontend/src/components/, separate reusable form components from those specific to AgencyProfileForm
Change CreateAgencyBtn to use an svg instead of text for its icon

Testing
How did you confirm your changes worked?

Looked 👀 at the task form and entered some input
Checked that AgencyProfileForm submits properly and handles invalid input correctly again
Looked 👀 at CreateAgencyBtn
Tests pass

Confirmation of Change
Upload a screenshot, if possible. Otherwise, please provide instructions on how to see the change.

Thanks Sara! We're not exactly sure how that will go yet--I'm having some difficulty figuring out exactly how mongoose handles updates for mongo. I believe we will have AgencyProfile pass in the entire agency object to TaskForm, so TaskForm can update the appropriate task and send the POST request itself. If the request is invalid, TaskForm will notify the user; otherwise I think it should probably return the new agency object to AgencyProfile.
I didn't implement that in TaskForm yet because I wanted to make sure everyone working on AgencyProfile agreed and so it could be done alongside, but I could just add it into this PR if that would be better. Let me know if there's anything else that should change!

Thanks Sara! We're not exactly sure how that will go yet--I'm having some difficulty figuring out exactly how mongoose handles updates for mongo. I believe we will have AgencyProfile pass in the entire agency object to TaskForm, so TaskForm can update the appropriate task and send the POST request itself. If the request is invalid, TaskForm will notify the user; otherwise I think it should probably return the new agency object to AgencyProfile.
I didn't implement that in TaskForm yet because I wanted to make sure everyone working on AgencyProfile agreed and so it could be done alongside, but I could just add it into this PR if that would be better. Let me know if there's anything else that should change!

That sounds good! No need to implement it for this PR, I was just wanting to hear your plans for future integration.


fix: Focusing emoji search input on mWeb

Details

This PR fixes emoji search input autofocus on mWeb
Fixed Issues

$ https://github.com/Expensify/App/issues/35720
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Open a report
Press emoji picker menu icon
Verify emoji picker has opened
Search input should be autofocused on: Web, desktop
Search input should not be autofocused on: Android, Android mWeb, iOS, iOS mWeb

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

Open a report
Press emoji picker menu icon
Verify emoji picker has opened
Search input should be autofocused on: Web, desktop
Search input should not be autofocused on: Android, Android mWeb, iOS, iOS mWeb

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/13985840/a08cacff-7fcf-4060-9a83-9e9897dc6e7f

Android: mWeb Chrome

https://github.com/Expensify/App/assets/13985840/9ea723e4-1d8e-4448-838c-f9cb6338d6c9

iOS: Native

https://github.com/Expensify/App/assets/13985840/626aeab7-ff3f-45f4-bdc8-33ead8661a81

iOS: mWeb Safari

https://github.com/Expensify/App/assets/13985840/9cea809e-8f67-4770-821e-ed120a9e83f9

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/13985840/ebb39f29-5aa1-4fa4-a79e-aa2c7cd0687f

MacOS: Desktop

https://github.com/Expensify/App/assets/13985840/c6b2d196-e894-48e2-8db7-71146f116145

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

LGTM, going to approve and merge since this was a regression from another PR I reviewed.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Nice, thanks for fixing it!

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Error CSR when fleet_telemetry_config create

Hi, i have a problem with my CSR when creating the fleet-telemetry config. However, my CSR has been validated because with this third-party token I can use the API in the usual way, like ‘vehicle_data’ for example.
I've followed all the previous steps to get fleet-telemetry on my server, but I get this error. Thanks in advance
I've noticed that it's only related to my bearer, because I can put anything in the body, it won't change anything.
Here's my "URL" : bib-data.fr

For example, here I have access to the classic API, my CSR has been accepted and I've already received an email about it.

Thanks in advance.

To add some information for the request: "{{FLEET_API_URL}}/api/1/vehicles/{{vehicle_tag}}/fleet_telemetry_config"  got a synced but to "true" (see the screen)
Thank you for your help

@themarch you first setup your account in NA region, but then set up in EU. I've applied the signed certificate to your account in EU so you should now be able to setup fleet-telemetry.

@Martucci98 you are passing a third-party token to the fleet_telemetry_errors endpoint. It requires a partner token. Please see the Authentication section of the docs to learn the differences between these tokens.

Thanks a lot @patrickdemers6, it's done for this part.
Just one very strange thing. I got this when I wanted to add the public key to the vehicle. However, I do have access to this vehicle, and I can make API calls on it etc. And I've already done the ‘third_party’ and ‘authorization_code’ parts.
Maybe it's another zone problem?

Thanks a lot @patrickdemers6, it's done for this part.
Just one very strange thing. I got this when I wanted to add the public key to the vehicle. However, I do have access to this vehicle, and I can make API calls on it etc. And I've already done the ‘third_party’ and ‘authorization_code’ parts.
Maybe it's another zone problem? (for the translation of the pictures it's : The vehicle cannot be shared.
Adding a virtual key for ‘bib-data.fr’ is prohibited because you have not granted ‘bib-data.fr’ access to your account.)


Can not set FACTORIO_RCON_PORT & FACTORIO_RCON_PASSWORD

It seems that setting FACTORIO_RCON_PORT & FACTORIO_RCON_PASSWORD actually causes the RCON options to not be passed to the server at all. I think this is due to a logic error which this PR addresses.

Ah yes, thanks @gtaylor. That should be fixed now.

Just fixed another error with this


The Java file is having some errors

It seems like the file is unable to run. Please help it.

Please assign this issue to me. I am new to Open Source.

Hey, @NiharPhansalkar please assign this issue to me

hey please assign issue to me