STM32WL LoRa increased the current in "suspend_to_idle" state

Describe the bug
When enabled the LoRa in STM32WL SoC, it draws more current than 70uA
To Reproduce

add the following configs to samples/boards/stm32/power_mgmt/blinky

CONFIG_SPI=y
CONFIG_LORA=y
CONFIG_LORA_SX12XX=y

build and flash to nucleo_wl55jc board
monitor the current at JP1 on the Nucleo-WL55 board

Expected behavior
It should not draw more current than old configs when SoC is in suspend state.
That is, when LED is off, the current should be about 4uA at test point(JP1).
Monitored result(LED off)

When disabled LoRa, it draws about 4uA
When enabled LoRa, it draws about 75uA in average, but there are triangle waves with 7.5ms cycle. At peak, it's about 420uA as following:

Environment (please complete the following information):

OS: Linux
Toolchain: 0.12.4
Zephyr v2.6.99

[UPDATED]

Zephyr commit SHA-1:  57690f5

@honestech74    Zephyr v2.6.99 does not exist yet ?? could it be then 1.6.99 which is very very old ...
Can you confirm that you have the power.c for the ./soc/arm/st_stm32/stm32wl
--> the PR   https://github.com/zephyrproject-rtos/zephyr/pull/36574 has introduced the power management for the stm32wl soc serie.

https://github.com/zephyrproject-rtos/zephyr/issues/37352#issuecomment-891067961

I have tested LoRa with HAL STOP2 mode(not using CONFIG_PM), it shows the same wave in the current measurement.
It seems like there are some enabled clocks or somethings even if the radio is sleeping and MCU is stopped.

@honestech74    Zephyr v2.6.99 does not exist yet ?? could it be then 1.6.99 which is very very old ...
Can you confirm that you have the power.c for the ./soc/arm/st_stm32/stm32wl
--> the PR   https://github.com/zephyrproject-rtos/zephyr/pull/36574 has introduced the power management for the stm32wl soc serie.

@Mani-Sadhasivam  can you please take a look.

@honestech74 LoRa module (an IP incase of STM32WL) is put into sleep mode when it is not used for Tx/Rx. That means, only the current drawn by the Radio antenna and the module itself will be minimal. But for STM32WL, there are peripherals feeding the LoRa module like clock, SPI etc... If we could identify the power consuming sources, then we can try to put them to sleep by using CONFIG_PM in lora standalone driver for STM32WL.
That also requires CONFIG_PM support in relevant drivers also I believe. Maybe @erwango can provide more info.

Moved isue from bug to feature request as power management is not fully available yet on all stm32 series nor devices

@aurel32, @fabiobaltieri I know you had a look at low power on WL recently.
Is that part of the issues you've seen ?

Yes, it seems to be similar to the issue I encountered, which is fixed with PR #38758.

Yes, it seems to be similar to the issue I encountered, which is fixed with PR #38758.

Thanks @aurel32.
@honestech74, would you mind checking a recent main branch which includes #38758

@erwango I've double checked it, but unfortunately, it has not been reduced. I am seeing the same situation before update zephyr to latest.
@aurel32 @fabiobaltieri If you are getting another current when following the reproduce, let me show your result.

I am getting an average current of about 3µA, but this is not on this board, but instead on a Seeed Lora E5 module, so there might be some differences. Just looking quickly at the config difference between this board and what I have, have you tried modifying the configuration to include:
CONFIG_PM=y
CONFIG_SERIAL=n
CONFIG_CONSOLE=n
CONFIG_UART_CONSOLE=n

After removed CONFIG_SPI=y, I am getting 11uA. I am not sure now if LoRa would work without it or not, but will check later. @aurel32 @fabiobaltieri Thank you for the work.
Unfortunately CONFIG_SPI=y is needed to communicate with the LORA module.

Hey I did some measurement on my setup but unfortunately I have some other stuff on my board (also Seeed based) that are making a bit of noise and can't quite isolate the WL. That said I wasn't able to reproduce the problem and get a spike at that frequency. A quick thought, could it be that something is running and restarting on the second core?
About CONFIG_SPI raising the sleep current: not sure if it's the same for this one, but the SX1272 was coming out of reset in standby, so it needed an SPI command to go to sleep. May be the case here as well.

Oh, CONFIG_SPI=y, I am still getting about 77uA and peaks. I think it's related to this config.
@aurel32 Are you sure if you're getting low current(3uA) with LoRa working?

Oh, CONFIG_SPI=y, I am still getting about 77uA and peaks. I think it's related to this config. @aurel32 Are you sure if you're getting low current(3uA) with LoRa working?

Sorry just to clarify, you are getting those spikes just with the plain samples/boards/stm32/power_mgmt/blinky + CONFIG_SPI=y and no LORA options?

|Sorry just to clarify, you are getting those spikes just with the plain samples/boards/stm32/power_mgmt/blinky + CONFIG_SPI=y and no LORA options?

Sorry just to clarify, you are getting those spikes just with the plain samples/boards/stm32/power_mgmt/blinky + CONFIG_SPI=y and no LORA options?
Here are my prj.conf for samples/boards/stm32/power_mgmt/blinky without any changes.

CONFIG_PM=y
CONFIG_PM_DEVICE=y
CONFIG_PM_DEVICE_RUNTIME=y
CONFIG_SPI=y
CONFIG_LORA=y
CONFIG_LORA_SX12XX=y
CONFIG_SERIAL=n
CONFIG_CONSOLE=n
CONFIG_UART_CONSOLE=n

@aurel32 @fabiobaltieri For sure, can you get low power with the samples/drivers/lora/send with CONFIG_PM=y? If yes, let me show the scope like PPK.

First of all, just to make things clear, I do not have a Nucleo-WL55 board. I use a SeeedStudio LoRa E5 module without board, soldered with wires to the JTAG connector:

This module has a STM32WLE5JC SoC which only has a single Cortex-M4 core. The Nucleo-WL55 board has a STM32WL55JC SoC, with a Cortex-M4 coupled with a Cortex-M0. This might makes a difference.
I also do not have a way to measure the power consumption with high time resolution, I only get an average over a few seconds. Therefore I don't know if there are spikes or not, but given I am confident that the 3µA average is accurate to +/1µA and includes spikes if any (I have cross-checked multiple methods).

@aurel32 @fabiobaltieri For sure, can you get low power with the samples/drivers/lora/send with CONFIG_PM=y? If yes, let me show the scope like PPK.

I have tested that with two modifications: 1) sending data every 15 seconds instead of 1 second and 2) use of my own "board" definition. I can confirm the power consumption goes to 3µA in between two LoRa transmission. All that said I only reach this value when I power cycle the device after programming it (maybe reset is enough). It seems that once the ARM SWD interface has been enabled, it consumes some power.

use of my own "board" definition

I have compared quickly the two DTS trees. I have found that the nucleo_wl55jc board definition default to a HSI clock with a PLL. On my side I am using the MSI running at 48MHz and without PLL.
When using the PLL instead, I see an increase of the power consumption to ~14µA, but that's far from your measurements. I guess it's due to the time for the PLL to start and stabilize each time the MCU wakes up. Anyway if you want to try that change, here are the relevant parts from my DTS file:
&clk_msi {
        status = "okay";
        msi-range = <11>;
};

&rcc {
        clocks = <&clk_msi>;
        clock-frequency = <DT_FREQ_M(48)>;
        cpu1-prescaler = <1>;
        ahb3-prescaler = <1>;
        apb1-prescaler = <1>;
        apb2-prescaler = <1>;
};

@aurel32 Thank you for the double checking.
I can definitely say that it doesn't work for nucleo_wl55jc board anyway. So there might be an issue on STM32WL55 SoC or something like HAL.
@fabiobaltieri I think that zephyr doesn't support Cortex-M0+ of STM32WL55, so there isn't any clock for it.

Tried to take some more measurement on my board (I have the Seed-E5 module, an nRF52832 a MAX17055, a LiPo charger and a mediocre LDO to deal with here...), I don't know how but while fiddling with wiring the PPK in, I managed to get my unit in a similar state as well, only difference being that the pulses were at ~5.6ms, but otherwise similar shape (and higher base consumption but that's prob the rest of my board). Would send you a screenshot but I can't get there anymore, I suspect that the supply bounced and the CPU crashed.
Can you try to take some measurement around the board trying to correlate the pulses? Specifically on the DCDC inductor (L13 on the Nucleo board): wondering if that pulse is the DCDC kicking in for some reason. If you could probe it on VLXSMPS or something... That may explain why it happens when the Radio get initialized.
About the other core: yeah Zephyr does not support it yet, was thinking it maybe it was starting up anyway and either crashing executing random opcodes or maybe running something that has been programmed with the Cube IDE. I don't know how the core starts either, but on the H7 there's an option to have the second core start automatically so I've figured let's make sure that's not the case here.

Can you share your solution please?

I could get 6uA with tx-enable-gpios and rx-enable-gpios disconnected when the radio is sleeping. For this, I've added simple gpio stuff to samples/drivers/lora/send with CONFIG_PM.

@honestech74 Can you share your solution please?

@thiagohd You can use the Pin Control from zephyr v3.1.0.
In the past, I set the gpios to GPIO_DISCONNECTED like tx-enable-gpios and rx-enable-gpios on nucleo_wl55jc board. Like this:
gpio_pin_set(tx_enable_gpio, GPIO_DISCONNECTED);

You might need the additional GPIOs due to your board and can add the low power stuff to your PM. Please take a look at zephyr/soc/arm/st_stm32/stm32wl/power.c


splits are not in a deletable state

I found some errors in quickwit-indexer recently:
message: quickwit_actors::spawn_builder: actor-failure cause=Failed to publish splits.

Caused by:
Splits `["01HAN8GBZ3F0NQFE7GBKWAC4R6"]` are not in a deletable state. exit_status=Failure(Failed to publish splits.

Caused by:
Splits `["01HAN8GBZ3F0NQFE7GBKWAC4R6"]` are not in a deletable state.)

After some days of logging (more logs on merge pipeline's splits tracing), I'm almost certain it's caused by:

merge-pipeline:publisher finished its works, passed some splits to planner's mailbox
merge-pipeline crashed with some reason (upload-to-object-store-fail in my scene)
merge-pipeline respawn the whole pipeline after a period
merge-pipeline:planner created, pull all the splits from metastore (includes the splits from step-1)
merge-pipeline:planner planned to merge splits from step-4, passed it to downstream
merge-pipeline:planner received the NewSplits message from step-1, then planned to merge

step-5/step-6 started two task contains the same splits(not all the same)

Temporary fix: clear the planner's inbox before respawn merge-pipeline
Futher question: how to avoid similar message problems in actor model
quickwit version: v0.6.2

@fulmicoton Is there a better plan to fix these problems (dead actor's messages)?

@dojiong First congratulations on understanding our indexing/merge pipeline in depth.
This bug is most likely a duplicate of #3627. Are you working with @geek-frio by any chance?
While investigating with the logs I had access to, I came down to the same conclusion as you, and then ruled out that possible cause due to some guard in the code, and due to the absence of merge pipeline error in the log... but maybe I overlook something.
The temporary fix you suggest is definitely not a good idea.
Let me reprioritize this. This bug is important.

I read that issue, it was also caused by duplicate plans.
According to my dig on the merge-planner's code, the most possible reason is the NewSplits message and merge-planner-init contains the same split (I also checked related actor's lifetime, it's not the reason in my scene).
This is my temprary fix: @geek-frio
diff --git a/quickwit/quickwit-actors/src/mailbox.rs b/quickwit/quickwit-actors/src/mailbox.rs
index e1571682..e23fd94d 100644
--- a/quickwit/quickwit-actors/src/mailbox.rs
+++ b/quickwit/quickwit-actors/src/mailbox.rs
@@ -369,7 +369,7 @@ impl<A: Actor> Inbox<A> {
         self.rx.recv_high_priority().await
     }

-    pub(crate) fn try_recv(&self) -> Result<Envelope<A>, RecvError> {
+    pub fn try_recv(&self) -> Result<Envelope<A>, RecvError> {
         self.rx.try_recv()
     }

diff --git a/quickwit/quickwit-indexing/src/actors/merge_pipeline.rs b/quickwit/quickwit-indexing/src/actors/merge_pipeline.rs
index 8fc978fb..395385c2 100644
--- a/quickwit/quickwit-indexing/src/actors/merge_pipeline.rs
+++ b/quickwit/quickwit-indexing/src/actors/merge_pipeline.rs
@@ -233,6 +233,9 @@ impl MergePipeline {
         self.statistics.num_spawn_attempts += 1;
         self.kill_switch = ctx.kill_switch().child();

+        // clear dirty messages
+        while self.merge_planner_inbox.try_recv().is_ok() {}

Anyway, not in a deletable state no longer appears after this fix.

I got another not in a deletable state error right now. It's the same mailbox/init duplicate problem, but another message order:

Upstream actor send SplitsUpdate message to merge-publisher
merge-pipeline crashed
merge-pipeline respawn
merge-publisher process publish tasks, publish splits, then send NewSplits to merge-planner
merge-planner created, get all the splits from metastore (includes splits from step-5), then planned
merge-planner received the NewSplits message from step-5, process it, failed

step-6/step-7 started two task contains the same splits(not all the same)

The temporary fix above reduced the probability of the problem, not solved it.
I think merge-planner should not call send_merge_ops on actor::initialize, just driven by messages. @fulmicoton

The deletable problem does not appear after two days (with the patch of clear-planner-inbox).
I reanalyze the case above, found something is impossible.
timeline:

mege-uploader-task(merge-splits replated task) failed, trigger kill-switch
merge-uploader-task(splits-publish related task) finished, send SplitsUpdate to publisher
merge-uploader been killed
merge-pipeline failed
merge-pipeline respawn, get all the splits from metastore
merge-publisher started, received SplitsUpdate(I compare the splits with step-2, it's the same)
merge-publisher published, send NewSplits to planner
merge-planner started with splits which contains splits from step-2

my problem is:

merge-publisher's mailbox is recreated on merge-pipeline spawn, why merge-publisher can receive (step-6) the message from previous epoch (step-2)?
why splits fetched at step-5 contains splits from step-2? It should not be published-state until step-7

@fulmicoton

I may not get more deletable logs after the temporary fix, could we move forward base on the known problem:
merge-planner start from all the splits and the mailboxes of previous epoch contains the same splits.

@dojiong thanks for the detailed reports.

why merge-publisher can receive (step-6) the message from previous epoch (step-2)?
It should not be possible indeed.

why splits fetched at step-5 contains splits from step-2? It should not be published-state until step-7
Agreed. I don't know how this can happen.

Can you share the logs? I can try to create a test that reproduces the steps and check what's happening.

@fmassot The last log of deletable problem has been automatically cleaned(that problem only occurred once after the temporary fix I posted above)

#3854 does not fix the problem. I got another deletable problem  after that patch.
I got the full timeline with more logs:

merge-publisher send a NewSplits to merge-planner, successed
merge-publisher send another NewSplits to merge-planner, outof capacity, await on mailbox
merge-pipeline crashed
merge-pipeline respawned, get all splits from metastore(includes splits from step-1/2)
merge-planner received NewSplits from step-1, planned, send splits to downstream(includes splits from step-2)
merge-planner received NewSplits from step-2, planned, duplicated with step-5

@fulmicoton  we should clean the planner's mailbox when spawning the merge-pipeline finally? (the temporary fix I used fist only use try_recv, it only missed some async message in rare)

You are suggesting draining the mailbox before getting the state from the metastore right?
This is a good idea but we could technically still be at risk of a similar bug, coming from the indexing pipeline this time.
The race condition I am thinking of is very unlikely but would look like

indexing publisher publishes to metastore successfully
indexing publisher sends new_split message.
merge pipeline fails and restart.
indexing pipeline drain the mailbox.
indexing pipeline fetchs list of splits from metastore
merge pipeline gets respawned
send new split somehow worked out here.

I have a more defensive fix in mind. Can I create a PR and add you as reviewer?

I have a more defensive fix in mind. Can I create a PR and add you as reviewer?

always oncall

draft PR here #3891


VS 2022 (17.4.4) don't support the Task List feature for NET 6/7 project, but work for Framework projects

I used the "Task List" feature for my WPF NET Framework projects. Now I created a new WPF NET 6/7 projects and the Task List feature is not working.
The "Task List" window is empty and the (Entire Solution/Current Project/Current Document/Open Documents) drop-down in the left-upper corner is empty.

Hi, @DrCQ. If you want to ask questions to our products instead of providing feedback to articles in this repository, you can go to   forums or contact Microsoft Support for help. I will close the issue at this time. If you have questions or further feedback to our articles, feel free to create a new Issue/PR. Thanks!


Validation executes in the wrong order. FieldValidationInfo does not contain expected data

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
This code should raise a field validation error on line 17. However, it raises a KeyError on line 24 where the reference is made to the context field which IS required and provided:
_ = context.data["data_type"]
KeyError: 'data_type'

Printing the context shows that this field does not exist in data:
FieldValidationInfo(config={'title': 'Column'}, context=None, data={'name': 'bbbbbbb'}, field_name='date_format')
Example Code
from typing import Optional

from pydantic import BaseModel, field_validator
from pydantic_core.core_schema import FieldValidationInfo

ALLOWED_TYPES = ["char"]

class Column(BaseModel):
    name: str
    data_type: str
    date_format: Optional[str] = None

    @field_validator("data_type")
    def _validate_data_type(cls, data_type: str, context: FieldValidationInfo):
        if data_type not in ALLOWED_TYPES:
            raise ValueError(f"Unknown data type for column {context.data['name']}: {data_type}")

        return data_type

    @field_validator("date_format")
    def _validate_date_format(cls, date_format: str, context: FieldValidationInfo):
        print(context)
        _ = context.data["data_type"]
        return date_format

cols = Column(name="bbbbbbb", data_type="string", date_format=None)

Python, Pydantic & OS Version
pydantic version: 2.1.1
        pydantic-core version: 2.4.0
          pydantic-core build: profile=release pgo=false mimalloc=true
                 install path: /home/coder/.cache/pypoetry/virtualenvs/apex-de-ingestion--Q1J_zSC-py3.9/lib/python3.9/site-packages/pydantic
               python version: 3.9.16 (main, May  4 2023, 02:16:04)  [GCC 10.2.1 20210110]
                     platform: Linux-5.15.108-aarch64-with-glibc2.35
     optional deps. installed: ['typing-extensions']

Selected Assignee: @hramezani

Thanks @snovik75 for reporting this 🙏
I can reproduce the problem.
Better to use @model_validator in case of validation on multiple field as we mentioned in docs:
However, in most cases where you want to perform validation using multiple field values, it is better to use @model_validator
 which is discussed in the section below.

Hello. When I upgraded to v2 I encountered a similar problem.
I 'm use:

Python == 3.11.6
pydantic_core == 2.10.1
pydantic-extra-types  == 2.1.0
pydantic-settings == 2.0.3
pydantic ==2.4.2

Consider the following models:
import json
from datetime import datetime
from pydantic import BaseModel, ValidationInfo, field_validator, v1

class DTO_V2(BaseModel):
    created_at: datetime
    updated_at: datetime

    @field_validator('updated_at')
    @classmethod
    def check_updated_at(cls, v: datetime, info: ValidationInfo):
        created_at = info.data['created_at']
        print("created_at is", created_at)
        return v

class DTO_V1(v1.BaseModel):
    created_at: datetime
    updated_at: datetime

    @v1.validator('updated_at')
    @classmethod
    def check_updated_at(cls, v: datetime, values):
        created_at = values['created_at']
        print("created_at is", created_at)
        return v

If the data is valid, then everything goes well.
valid_data = json.loads("""
{
    "created_at": "2023-10-31T15:33:00.000000+10:00",
    "updated_at": "2023-07-31T15:33:00.000000+10:00"
}
""")
DTO_V1.parse_obj(valid_data)
DTO_V2.model_validate(valid_data)

But if we have an invalid created_at, then we fail in v2.
invalid_data = json.loads("""
{
    "created_at": "2023-10-31T15:33:00.000000+10",
    "updated_at": "2023-07-31T15:33:00.000000+10:00"
}
""")
DTO_V1.parse_obj(invalid_data)
DTO_V2.model_validate(invalid_data)

Is this expected behavior?
In my opinion, the example shown in the documentation, which talks about using model_validator, does not fully explain the reasons for the problem.
Moreover, there are situations when you need to check several fields based on other fields. I did not find in the documentation how to implement such functionality using model_validator

I stumbled upon the same issue, after investigating a bit, I think that it happens because pydantic tries to run all the validators before showing all the errors.
The problem is that as the validator of data_type raises an error, the value is not put in info.data.
Then when validating date_format, the validator raise a KeyError which is not caught by pydantic, thus we get this error and not the one of the first validator.

Closing this for now - as @hramezani suggested, you should use model_validator for best results in this case.


Differences when reproducing example

Hello! I tried to reproduce the example using synthetic data in the documentation and the result I obtained was different (and actually incorrect, because it associated picks to additional, non existent events). A copy-paste of the code produced the same incorrect result. Any ideas on what could be causing this difference? Maybe using a different version of any of the dependencies?

True events:
loc=400.000	t0=33.333	mag=2.000
loc=1600.000	t0=93.333	mag=2.352
loc=880.000	t0=153.333	mag=2.169
loc=1360.000	t0=213.333	mag=2.551
loc=1120.000	t0=273.333	mag=2.766
loc=640.000	t0=333.333	mag=3.000
GMMA time = 0.5283012390136719
Associated events:
loc=400.0	t0=33.3	mag=2.0	sigma11=0.495
loc=1517.6	t0=77.4	mag=4.2	sigma11=0.358
loc=1600.0	t0=93.3	mag=2.4	sigma11=0.185
loc=880.0	t0=153.3	mag=2.2	sigma11=0.161
loc=1360.0	t0=213.3	mag=3.1	sigma11=0.088
loc=1120.0	t0=273.3	mag=2.8	sigma11=0.098
loc=498.1	t0=292.0	mag=3.3	sigma11=0.600
loc=877.6	t0=372.9	mag=2.2	sigma11=1.197
Cheers!

Hi, I may have broken this test during updates. It works for me now. Can you try again?


Fix ProjectedSonarImage comments about frame

Hi @CaptKrasno! As mentioned in email, @amarburg noticed that the comments in ProjectedSonarImage were inconsistent with the very excellent README.
This merge request fixes that.

I plan to merge this merge request on Monday, before we start the release process.

While we're at fixing the comments in this message type, can we make the comment about the header timestamp the same as in RawSonarImage.msg?

Good catch @rolker! I've updated that.


Can I create a UI to update en.json using ngx-translate

I'm using ngx-translate to support multi-language in angular. I've a very specific need that an admin can update the translations (i.e. can update en.json, fr.json, ur.json, etc... using a UI made in angular). What's the recommended way to allow admin to add, update and delete translations?

I don't think there's any standard way to do this. You can create a UI of your own choice - I think it would be a nice OS project on its own.
You have to keep in mind to reload the language after editing, taking into account that you're doing this into the same page/application.


Adding disableStreamCache=true on every http call

GitHub Issue: Part of the fix for https://github.com/Islandora/documentation/issues/1278
What does this Pull Request do?
Disables stream caching so payloads are streamed around and not read into memory.
How should this be tested?
See https://github.com/Islandora/documentation/issues/1278
Interested parties
@Islandora/8-x-committers @kayakr @antbrown

@dannylamb I'm sorry I didn't catch you sooner, but couldn't we set this as an option in the blueprint.XML so you don't have to do this?
https://github.com/Islandora/Alpaca/blob/dev/islandora-indexing-fcrepo/src/main/resources/OSGI-INF/blueprint/blueprint.xml#L26

@whikloj Depends on the type of parameter IIRC.  Some can be set on the http component and some are done on a per endpoint basis.  I'll look that up because if we can do it once in the blueprint, we should.

Bit of a wormhole but.... I think we already have the groundwork laid for this.  I can make an HttpClientConfigurer and add it as a bean here.  Then it should be exported out and affect all http components used in Karaf.
Also... sneaky claw reference!!!

This works for us, I haven't noticed any regressions after upgrading, and the ability to pass huge files around the place is really cool.
Thank you!

checkstyle fail for long lines

Hi all,
Any updates for this patch?
We're having the same problem in loading large video file in Islandora 8 (version 2.2.1) without this patch. It's ok to load and generate small video files (<100 MB), but it will retry the generating service file process several times for large video files and get frozen. The service files are not generated for them ofc.
Simon.

@simonhm , I believe this patch was superseded and incorporated into https://github.com/Islandora/Alpaca/commit/7bf983de06b70a102514732323f8cb88680a1a6d (available as part of the latest release).
@whikloj or @dannylamb , can either of you confirm and close this comment?

We've been testing Islandora 8 using the Ansible Playbook. The Alpaca version on our testing sites is 1.x that was installed in the initial set up. We've been updating PHP modules and Drupal but everything else in the stack is what was initially installed.
I think it's better if the Alpaca version in Ansible Playbook or Docker is 2.x instead of 1.x. Thanks!
Simon.

Hi @simonhm,
The islandora-playbook now installs the new Alpaca all-in-one jar, however before trying to update you might want to wait for https://github.com/Islandora-Devops/islandora-playbook/pull/210


Remove references to Pretender

Now that we use mirage, we don't need to reach into the pretender server. These references can likely be removed as implied, or in some cases refactored to proper high-level mirage DSL.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Related to https://github.com/elwayman02/ember-data-github/issues/144


Add a timestamp and Git commit to the dartdoc home page

Fixes https://github.com/flutter/flutter/issues/7974

Thanks!


feat(pgbouncer): support pgbouncer 1.23.0 in the metrics collector

The latest version of pgBouncer added a new metric in this PR https://github.com/pgbouncer/pgbouncer/pull/727
this patch adds that metric to the list of exported ones generated by SHOW STATS while retaining the backward compatibility
Closes #5043

/test limit=local ft=observability

@sxd what about pgbouncer < 1.23? Will this change break those installations? I would have expected a conditional build of the SHOW STATS query.

I have conservatively tagged this as "do not merge" waiting for the above clarification.

I tested manually with 1.22.1 and 1.23.0 and everything looks fine. I just fixed the warnings raised by the linter.

Started an E2e run: https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9856345151

E2e tests are all green! I'm merging it.

/ok-to-merge


docs: Document installing Quilt as root

I didn't add the note in the README (https://github.com/quilt/quilt/blob/master/README.md#install) because it links to the GettingStarted page.
I also updated documentation here, so they should be reviewed by the same person:

https://github.com/quilt/install/pull/6
https://github.com/quilt/demos/pull/6

@luise can you review the other PRs as well? (linked in the description)


Add public api

Make sure you familiarize yourself with our contributing guidelines.
Describe the PR
Add a public api for user info and billet info
Closes
Closes #408
Notes
Any other notes go here.
https://localhost:5001/api/userinfo?user=11345 results in:
{
    "nickName": "Del",
    "birthNumber": 11345,
    "lastPromotion": "2022-10-10T00:00:00",
    "lastBilletChange": "2022-10-17T00:00:00",
    "slot": "Avalanche 3-3",
    "role": "Squad Leader",
    "rank": "Sergeant",
    "qualifications": [
        "Zeus Permit",
        "RTO Qualified",
        "Marksman",
        "Grenadier",
        "Medic",
        "Jumpmaster",
        "Close Quarters Specalist"
    ],
    "tig": 14,
    "tib": 7
}

https://localhost:5001/api/billetinfo?enum=AvalancheThreeThree results in:
[
    {
        "displayName": "CS Del",
        "birthNumber": 11345
    },
    {
        "displayName": "CP Crebar",
        "birthNumber": 70303
    },
    {
        "displayName": "CP Klinger",
        "birthNumber": 54077
    },
    {
        "displayName": "CT Knight",
        "birthNumber": 56273
    },
    {
        "displayName": "CT Chimera",
        "birthNumber": 30253
    },
    {
        "displayName": "CM Deytow",
        "birthNumber": 23996
    },
    {
        "displayName": "CT Clover",
        "birthNumber": 14577
    },
    {
        "displayName": "CT Negeta",
        "birthNumber": 42361
    },
    {
        "displayName": "CM-C Bones",
        "birthNumber": 87071
    },
    {
        "displayName": "CI-C Soyvolon",
        "birthNumber": 42127
    },
    {
        "displayName": "CT Tal",
        "birthNumber": 17077
    }
]

https://localhost:5001/api/billetinfo?enum=AvalancheThreeThree&role=Trooper results in:
[
    {
        "displayName": "CT Clover",
        "birthNumber": 14577
    },
    {
        "displayName": "CT Negeta",
        "birthNumber": 42361
    },
    {
        "displayName": "CT Knight",
        "birthNumber": 56273
    },
    {
        "displayName": "CT Chimera",
        "birthNumber": 30253
    }
]

pog

Also! Please enable Swagger Gen. You may need an NuGet package for this, but here is an example config:
https://github.com/Soyvolon/VirtualPDrive/blob/bba4dc9b2bdc344e2991bec8c2ffbadfe3e67a8b/VirtualPDrive.API/Startup.cs#L27-L43


Don't merge! Trying to trigger a build

Don't merge this to dev! I'm only creating the pull request in hopes of triggering a build.

I'll cancel this pull request as soon as I get a build out of it.

/home/public/RND/loads/pubsubplus-go-client/EBP-86_poll/1.7.0-EBP-86_poll.2f864c6


Event Filtering broken without Websockets

We've been working on an app that tries to query some events and the event filtering seems to be a bit broken. We're using "https://rpc.public.zkevm-test.net" as our RPC provider.
If we initialize the Web3Client without a socket connector, the event filtering fails with
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: RPCError: got code -32000 with msg "filter not found".
#0      JsonRPC.call (package:web3dart/json_rpc.dart:64:7)
<asynchronous suspension>
#1      _FilterEngine._refreshFilters (package:web3dart/src/core/filters.dart:359:13)
<asynchronous suspension>

If we initialize the Web3client with a bogus websocket connection like:
String ws = "ws://asdf.com";
client = Web3Client(rpc, Client(), socketConnector:  () {
      return IOWebSocketChannel.connect(ws).cast<String>();
    });

The filtering correctly returns the events
flutter: Found Open event for channel with ID [178, 59, 204, 204, 67, 15, 125, 110, 24, 162, 242, 162, 229, 159, 11, 31, 0, 146, 230, 20, 72, 103, 21, 232, 32, 21, 170, 218, 39, 14, 28, 107]

but the websocket connection errors (as expected)
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: WebSocketException: Connection to 'http://asdf.com:0#' was not upgraded to websocket
#0      _WebSocketImpl.connect (dart:_http/websocket_impl.dart:1011:41)
#1      WebSocket.connect (dart:_http/websocket.dart:320:22)

I think the issue is that get_Logs is only called when a socketConnector is available (even though it can be used on a regular http connection).
It works flawlessly if I modify the code to do this:
Stream<FilterEvent> events(FilterOptions options) {
    if (socketConnector != null) {
      // The real-time rpc nodes don't support listening to old data, so handle
      // that here.
      return Stream.fromFuture(getLogs(options))
          .expand((e) => e)
          .followedBy(_filters.addFilter(_EventFilter(options)));
    }
    return Stream.fromFuture(getLogs(options))
          .expand((e) => e);
    //return _filters.addFilter(_EventFilter(options));
  }

I've decided now to locally update our generated bindings to use getLogs instead of events, but it might be good either way to fix this


fixed ascending with new tab now added for powerball thing

The new powerball thing breaks ascending because more tabs.  Heres a fix

This has conflicts with master so it can't be merged.  I'm guessing you just need to remove the .bak file.  Are you able to do that then I can merge it?

its updated

Done, thanks


chore: bdd-spring-1573155289 to 0.0.1

chore: Promote bdd-spring-1573155289 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


bump to v4.0

@gabemontero ptal, not sure i hit everywhere that needs to be touched.
the v3.11 branch has been created.

The Dockerfile (both centos and rhel) have version specific env vars

thanks, updated.

/lgtm


Create routes for specific profile details

Updated userModel

Renamed workTitle to tagLine
Added property location for user
Updated maxlength for few properties

Updated userRoutes

Made several GET routes public including /api/users/profile
Added new routes for basicinformation, skills, languages, education, experience, certification, awardsandachievements, projects

Updated user controller

Made get, update and delete( for few properties) for the routes mentioned earlier
For get methods user_id was taken using query params instead of request user object, thus enabling it to be a public route

Files are modified as per the request, check them now.


[Xiaomi Mi Plug] Poll failed 4 times in a row! Stopping polling and trying to reconnect! Reason: Error: Resp invalid json.

Describe the bug
My Xiaomi Mi Plugs are always show error messages in logs.
Expected behavior
Please fix it. It's made my orangepi slowly
Your config.json
{
"type": "MiPlugBase",
"ip": "<IP_ADDRESS>",
"token": "###",
"outletName": "Floor Fan",
"outletDisable": false,
"temperatureDisable": true,
"switchLEDDisable": true
}
Debug log
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] Splitting properties into chunks. Number of chunks: 1. Chunk size: 14
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] Chunks:  [
[
"switch:on",
"switch:temperature",
"indicator-light:on"
]
]
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] (Protocol) Call <IP_ADDRESS>: get_properties - [{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}] - {}
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] (Protocol) Start handshake <IP_ADDRESS>
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- (2) {"method":"get_properties","params":[{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}],"id":4}
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- !1�4
�ͽr                                                                                @I�NzL�:҇,��
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> -> Data: {"id":4,"error":{"code":-30001,"message":"Resp invalid json."}}
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> -> Message: {"id":4,"error":{"code":-30001,"message":"Resp invalid json."}}
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- Error during send! (-30001) Resp invalid json. | Request: {"method":"get_properties","params":[{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}],"id":4}
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] Poll failed 2 times!
[9/8/2022, 9:09:07 AM] [homebridge-miot] [Floor Fan] Poll failed! Error: Error: Resp invalid json.
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] Splitting properties into chunks. Number of chunks: 1. Chunk size: 14
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] Chunks:  [
[
"switch:on",
"switch:temperature",
"indicator-light:on"
]
]
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] (Protocol) Call <IP_ADDRESS>: get_properties - [{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}] - {}
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] (Protocol) Start handshake <IP_ADDRESS>
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- (2) {"method":"get_properties","params":[{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}],"id":5}
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- !1�4
@I��.��U���
�h��;
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> -> Data: {"id":5,"error":{"code":-30001,"message":"Resp invalid json."}}
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> -> Message: {"id":5,"error":{"code":-30001,"message":"Resp invalid json."}}
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- Error during send! (-30001) Resp invalid json. | Request: {"method":"get_properties","params":[{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}],"id":5}
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] Poll failed 3 times!
[9/8/2022, 9:09:22 AM] [homebridge-miot] [Floor Fan] Poll failed! Error: Error: Resp invalid json.
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] Splitting properties into chunks. Number of chunks: 1. Chunk size: 14
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] Chunks:  [
[
"switch:on",
"switch:temperature",
"indicator-light:on"
]
]
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] (Protocol) Call <IP_ADDRESS>: get_properties - [{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}] - {}
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] (Protocol) Start handshake <IP_ADDRESS>
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- (2) {"method":"get_properties","params":[{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}],"id":6}
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- !1�4
@I�r�Q���/�&��k��
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> -> Data: {"id":6,"error":{"code":-30001,"message":"Resp invalid json."}}
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> -> Message: {"id":6,"error":{"code":-30001,"message":"Resp invalid json."}}
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] (Protocol) <IP_ADDRESS> <- Error during send! (-30001) Resp invalid json. | Request: {"method":"get_properties","params":[{"did":"120851520","siid":2,"piid":1},{"did":"120851520","siid":2,"piid":2},{"did":"120851520","siid":3,"piid":1}],"id":6}
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] Poll failed 4 times!
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] Poll failed 4 times in a row! Stopping polling and trying to reconnect! Reason: Error: Resp invalid json.
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] Device diconnected!
[9/8/2022, 9:09:37 AM] [homebridge-miot] [Floor Fan] Trying to reconnect in 60 seconds...

You would need to specify what device do you have. I would need the unique device model.

Ya, sorry about that.
This is a device information
Name	Model	                        Device Id	Local Ip	                Country
Fan	       chuangmi.plug.m3	        120851520	<IP_ADDRESS>	cn

Hmmm it might be because of the temperature property...
Are you able to locally modify the JavaScript file with the device implementation and comment out the line with temperature? Can you try  that and see if the error continues?

I've just tried to comment 3 lines (36, 41, 42) in the file "homebridge-miot/lib/modules/outlet/devices/chuangmi.plug.m3.js".
It looks good now.
Thanks for your suggestion !


Merge updates from master into feature/new_quickstarts

Also DCO seems to be failing, please sign off the commit. Thanks


tracking: GHASH

Implement GHASH as specified in section 6.4 of the NIST spec

[ ] #25
[ ] #26
[ ] #43
[ ] #42

Known unknown:
circom does not allow for arbitrary length inputs. How should we handle this?
We might need to make a circom template for each size that we use.

Still need to debug why GFMUL produces values 256 * what is expected, and test new polynomial, intermediate merge in PR #36.

@0xJepsen why did you close this?

Still need to debug why GFMUL produces values 256 * what is expected, and test new polynomial, intermediate merge in PR #36.

Shall we make a new issue for it


 There is also a windown.onbeforeunload event that checks for when the user is trying to leave and shows a message if upload state is true.
Side effects
If the upload progress function runs and the uploading is not actually happening this confirmation will always appear. As long as things are working properly with dropzone this should not be an issue.
I checked for multiple files upload together and uploading one file after the other.

I added uploadInProgress to treebeard options. Each fangorn instance will have a different one and all hooks have reach to this this variable this way.


Add support for logging into Unifi Captive Portal

A lot of WiFis (and even wired networks) use captive portals. This is normally served from http://captive.apple.com.
When you're logged in, you would normally get this:
$ curl http://captive.apple.com
<TITLE>Success</TITLE>Success

In the first phase, let's use JavaScript to log into a basic page (to be provided).

Here's an example of a captive portal that we can use to model this around:
captive-portal.tgz


Check project name is a mandatory field while creating a project.

Removing project name in project registration page and clicking on next should give the error message "Project Name Required". Instead it is giving the error message " A project with this name and year already exists".
Please refer the attached screenshot for detailed instructions to recreate the issue.
checkProjectmandatory.docx

out of scope for SP23 capstone batch due to time constraint
still leaving the issue open for later fix


bootstrap.css interfering with Google Maps InfoWindow

Something in bootstrap.css (v2.0.1) is interfering with Google Maps info window's display. When you click on a map point, the information bubble display is altered. For example: http://311servic.es/treetrim/ Click on any dot on the map to see what I mean. when I remove the bootstrap CSS file, Google Maps information bubbles looks correct.
Other than that, I'm loving Bootstrap.

I'm seeing the exact same behaviour here.

We don't have time yet to track this one down, and I'm not familiar with Google Maps at all on this level. Can you try to isolate the problem?

I'll see what I can do. I'm no CSS expert, but can fumble through it, generally. However, I will be working on a project soon with a CSS ninja and we're using Bootstrap with Google Maps in a similar fashion to what is already described. We'll definitely have to find a way around this bug then. I'll keep you posted.

work with t'is
#map_canvas img {
max-width: none;
}
Where your id map name #map_canvas

gfpl001's works. Fixed this issue right up. I added:
#theMap img {
    max-width: none;
}

Magic. Not sure why one has to set 'max-width'. But it works and its not a Twitter Boostrap bug. Seems more related to how Google is styling its info windows.  Saw this after more internet digging: http://stackoverflow.com/questions/1554893/google-maps-api-v3-infowindow-not-sizing-correctly.
Thanks for the hint. This saved me untold hours.


Rename timeout field to shardTimeout and update assoicated setter/get…

Rename timeout field to shardTimeout

Rename timeout's getters and setters from getTimeout and setTimeout to getShardTimeout and setShardTimeout

Update test cases to use new getters/setters

As I understand the issue, it desires renaming the timeout parameter.  Are you sure this is just the field and not a param in the REST API?

Thanks @jaygradon, you're right. I have now also changed the param from timeout to shard_timeout and have updated the docs accordingly

LGTM 👍 if its passing all tests

Thanks @jaygradon for reminding me to run tests, I actually missed a few spots where I had to change the param which I found after running the tests. The tests all pass now


cannot start td-agent.service  for type elasticsearch

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.

fluentd or td-agent version.
Environment information, e.g. OS.
Your configuration
Your problem explanation. If you have an error logs, write it together.

following td-agent.conf configuration.
cannot start td-agent.service
Starting td-agent (via systemctl):  Job for td-agent.service failed because the control process exited with error code. See "systemctl status td-agent.service" and "journalctl -xe" for details.
//rpm
td-agent-3.2.0-0.el7.x86_64
//td-agent.conf
<filter redis.*>
@type record_transformer
enable_ruby

hostname "#{Socket.gethostname}"

<match .>
@type copy

@type elasticsearch
host <IP_ADDRESS>
port 9200
user elastic
password password
type_name redis_2000
logstash_format true
logstash_dateformat %Y%m%d
logstash_prefix redis_slowlog

flush_interval 10s

  @type redis_slowlog
  host localhost
  port 2000
  password password
  logsize 128
  interval 3
  tag redis.slowlog

    insecure false

//log
2018-07-06 10:42:02 +0900 [info]: parsing config file is succeeded path="/etc/td-agent/td-agent.conf"
2018-07-06 10:42:02 +0900 [info]: Connection opened to Elasticsearch cluster => {:host=>"<IP_ADDRESS>", :port=>9200, :scheme=>"http", :user=>"elastic", :password=>"obfuscated"}
2018-07-06 10:42:02 +0900 [info]: Detected ES 6.x: ES 7.x will only accept _doc in type_name.
2018-07-06 10:42:02 +0900 [warn]: Detected ES 6.x or above and enabled insecure security:
You might have to specify ssl_version TLSv1_2 in configuration.

https://github.com/uken/fluent-plugin-elasticsearch/issues/439


added more details to the instruction

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/7898

Dear @JohanFreelancer9,
kindly do the copy editor review for this PR.
Dear @e0i, for your information
Thank you

Thank you for your contribution, Marat, it looks good.
One comment - we are updating the main documentation page (e.g. https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-atp/mac-jamfpro-policies#step-4-configure-notifications-settings for JAMF) to have consistent instructions.) If you feel that your clarifications make sense there too - please feel free to add them there too.


Get all process ids

Codecov Report

Merging #13 into master will increase coverage by 0.92%.
The diff coverage is 88.05%.

@@            Coverage Diff            @@
##           master     #13      +/-   ##
=========================================
+ Coverage   80.68%   81.6%   +0.92%
=========================================
  Files          32      32
  Lines         849     870      +21
  Branches       44      43       -1
=========================================
+ Hits          685     710      +25
+ Misses        164     160       -4

Impacted Files
Coverage Δ

.../com/ing/baker/actor/LocalBakerActorProvider.scala
100% <100%> (ø)
:arrow_up:

...src/main/scala/com/ing/baker/java_api/JBaker.scala
75.86% <66.66%> (-2.71%)
:arrow_down:

core/src/main/scala/com/ing/baker/core/Baker.scala
78.87% <85.71%> (ø)
:arrow_up:

...rc/main/scala/com/ing/baker/actor/ActorIndex.scala
82.85% <86.95%> (+16.19%)
:arrow_up:

...ala/com/ing/baker/actor/ShardedActorProvider.scala
96.15% <94.44%> (-3.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb4b32...b263a1b. Read the comment docs.


MP4 tagging doesn't work

I am using the latest version of aves and the MP4 tagging doesn't seem to work. I always get the "failed" message. I am using android 9 if that makes any difference
I am really hyped about this feature

v1.7.2 had an issue and MP4 editing was failing every time. v1.7.3 seems to work fine for me. If you're actually experiencing the issue with v1.7.3, could you please follow the instructions in About > Bug Report and paste here the system info and logs? And a sample video could be useful too.

the file is actually somehow corrupted after the failed tag assignment... in my file manager it shows up as having 0kB. tried it with a few test videos. I wanted to upload one here, but I can't because github is telling me to upload a nonempty file. the video I appended is untouched yet.
Aves version: 1.7.3-play (Build 83)
Flutter version: 3.3.8 (Channel stable)
Android version: 9 (SDK 28)
Android build: PPR1.180610.011.N950FXXUGDVG5
Device: samsung SM-N950F
Geocoder: ready
Mobile services: ready
System locales: en_AT, de_AT
Aves locale: en -> en
Installer: com.android.vending
aves-logs-20221111_193635.txt
https://user-images.githubusercontent.com/78076361/201409892-a406fe6e-69c1-43c7-b8d4-4fb6851a46b0.mp4

Damn, I can't reproduce on Android 12 but I do reproduce on Android 9. I need to check which platforms are impacted :/

Thanks again for the quick report. I'll push the fix to a new release as soon as possible.

@Ingegneus the update is in production on the Play Store. Please try and let me know if you still encounter issues.

seems to be working. I will give it some further testing later

@IzzySoft sorry to bother you but today i released several buggy versions of Aves (v1.7.2 v1.7.3) and finally a good one (v1.7.4). It seems IzzyOnDroid picked up v1.7.3, but not the latest one. I'm telling you this because users of Android 9 and below may corrupt their videos with Aves v1.7.3. Is it possible for you to manually update your system to pick up Aves v1.7.4 instead of waiting 24 hours?

Ermergency sequence initiated. 1.7.4 will be up in a few minutes (update checker only runs once a day, starting around 6:30 UTC – that would be a bit late for this I feel). Wow, do you really have different screenshots for all those languages? :scream: OK, all here. Now I'll run publish, and for the F-Droid clients the new index will be there within 5 minutes or so. WebIf will update a bit later.

Up now. And say what, I've triggered the importer on the webserver as well, so it should be visible now.

@IzzySoft Thank you!

do you really have different screenshots for all those languages?

I automated this so it's not painful to keep consistent and up-to-date. I run this scenario to cycle through the languages and take the screenshots, and then I run this script to resize/overlay/frame them for the different stores.

:astonished: Wonderful! I first was afraid of "everything duplicated" (had that misunderstanding with several projects where the authors weren't aware of the fall-back to en-US for missing elements). So I've checked myself before publishing my comment – which then was more a :astonished: :bow: :bow: (kudos). You amaze me more every day :smile:


[FEATURE] Support more options in create index statement

Is your feature request related to a problem?
Currently Flint streaming job uses Foreach Batch sink which creates temporary checkpoint folder by default. The checkpoint will be lost after restart.
What solution would you like?
Add another option in create statement to allow user configure where they want to store the checkpoint data. Without the location provided, we can assume user doesn't concern about this and stick with temporary checkpoint as before.
For example:
CREATE SKIPPING INDEX ON alb_logs
(
  client_ip VALUE_SET
)
WITH (
  auto_refresh = true,
  checkpoint_location = 's3://...'
)

What alternatives have you considered?
Use some default location of current database. For example, because we map data source concept to SparkSQL catalog, we may use the root folder of a S3 data source. But this needs user awareness and write permission.
Do you have any additional context?
N/A

Similarly, we want to support other options such as refresh interval, index setting etc.
CREATE SKIPPING/INDEX/MV ...
WITH (
  auto_refresh = [true | false],
  auto_start = [true | false],
  refresh_interval = '1s',
  checkpoint_location = 's3://...',
  index_settings = '{ "key": value ... }'
);

auto_start is low priority and will be tracked separately.


test-branch/execute-job/quoted-authorization/8747fafd-1170-4ee9-884f-cf01974f5c19

PR for testing 80d66b69d9e9edd3494c567988ab371dc11bc67f

/canonical/self-hosted-runners/run-workflows 80d66b69d9e9edd3494c567988ab371dc11bc67f


have trouble to generate semantic tokens using the demo code

I am wondering if anyone is able to successfully run the following code in the demo without making a change?  I mean the demo for generating semantic tokens given text information, here is the link.

run sample = trainer.generate(text = ['sound of rain drops on the rooftops'], batch_size = 1, max_length = 2)

I can run the training part before the above line succesfully, but not inference as the above line.
I would like to verify several parts:
1. line 1423 of ./audiolm_pytorch/audiolm_pytorch.py

for ind in tqdm(range(start_length, max_length), desc = 'generating semantic')

Does "ind" in the above line indicate each new estimated semantic token?
2. line 456 - line 463  of ./audiolm_pytorch/audiolm_pytorch.py

    if exists(kv_cache):
        cache_len = kv_cache.shape[-2]
        kv_cache = iter(kv_cache)
    else:
        cache_len = 0
        kv_cache = iter([])

    x = x[:, cache_len:]

When I running the code, I printed the shape of kv_cache and x, as below:

kv_cache shape when exists:  torch.Size([6, 2, 1, 18, 64])
x shape after grad_shrink:  torch.Size([1, 2, 1024])

You can see that  kv_cache.shape[-2] = 18 is much larger than x.shape[1]. So I am wondering how is it possible to use kv_cache.shape[-2] as the index for x in the 2nd dimension.
3, line 122 of ./audiolm_pytorch/attend.py

sim = sim + attn_bias

With original code, the datasize of sim and attn_bias always mismatches after ind > 0. Therefore, I had to add a step to pad attn_bias and mask after each iteration of ind (from start_length to max_length). I am wondering if my logic is correct or not.
Looking forward to any insights regarding these problems.
Thanks!

Thank you so much! It works now.


moving standardized jellium Hamiltonian; associated changes

Fixes #316

I don't really like the name I've given it, feedback on that appreciated! I want to highlight that it does all the lifting normally associated with jellium_model or dual_basis_jellium_model for you, but don't have good ideas for what to call it.

Like @babbush , I'm not sure I agree with the premise of this function. It seems more appropriate as a function you'd define in your own code for your own convenience.
I actually think that ideally, the "boilerplate" you're trying to avoid with this function go into a Jupyter notebook example on generating model Hamiltonians. That would be very helpful for explaining what is going on here and it would be more transparent than hiding the inner workings in a convenience function.

I guess I am okay with this. I'd ask @kevinsung to take a closer look and approve though. He seemed to have some comment about deleting tests that I didn't understand.

It was more that I forgot to delete some tests while transferring code :P
This function straddles the boundary for a convenience function IMO - it's
fairly simple, but still possible to make small surprising mistakes with
it. I don't think demo code should be code that we intend to have users
basically copy-paste for their own use, but there are good examples we
could give with this function together with say the Fourier transform code
(perhaps better explaining Grid, the Wigner-Seitz radius, etc).
On Thu, Apr 26, 2018, 11:41 Ryan Babbush<EMAIL_ADDRESS>wrote:

I guess I am okay with this. I'd ask @kevinsung
https://github.com/kevinsung to take a closer look and approve though.
He seemed to have some comment about deleting tests that I didn't
understand.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quantumlib/OpenFermion/pull/320#issuecomment-384688895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKRqncIlOCtw8l6AxXAWzSxaCYJlyaD5ks5tseqOgaJpZM4TkjTP
.

Is it ready to be merged or do you still need to address that test issue?

I've addressed it, but I'm still not totally happy with the function name.
If nobody has a better one it's good to merge though.
On Thu, Apr 26, 2018, 12:30 Ryan Babbush<EMAIL_ADDRESS>wrote:

Is it ready to be merged or do you still need to address that test issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quantumlib/OpenFermion/pull/320#issuecomment-384705762,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKRqnT7ATOYtaV5WKmfY-XoLT97RxWnnks5tsfYvgaJpZM4TkjTP
.

I think we should definitely change the name. This function seems to be about setting the proper length scale given an electron density, so I think the name should reflect that. Furthermore, I think it should not normal order and compress the Hamiltonian before returning.

I think it's better to have this function have one purpose, and it seems that that purpose is to help the user set the proper length scale. It should do that, and in all other respects be similar to the other Hamiltonian generation routines. I think that would be a better separation of function responsibility.


update release cadence

Proposed Changes

change release cadence

Release Note
Documented release cadence changed from weekly to bi-weekly.

/lgtm


Mode identifiers refer to a mode's requirements

Long story short, it is possible to use the name n of a mode above the current one to refer to the predicate "mode n is active", i.e. all its requirements are true.
Note that the following cause parse errors:

self/forward reference: "Undeclared identifier", see regression test here and here
shadowing of an identifier in scope: "mode identifier id is shadowing another identifier", see regression test here

For an actual example see the very last section of this PR, after Motivation and Details.
Motivation
Init mode
A very simple example is when we have an init mode. It's useful to have one when in the first states the
system is doing things which are hard to describe and we don't really care about. If we have a duration node that counts for how long some boolean has been true, we can write
@mode init (
  @require duration(true) < init_steps
) ;
@mode nominal(
  @require not init
  ...
) ;
...

This is a more natural, less error-prone way of requiring duration(true) >= init_steps in the modes different from init.
Obviously this is not interesting enough to motivate this pull request, but the next example is.
Mode / numeric separation in the model
The following is a (brutal) simplification of my experience of specifying the TCM.
Consider a node which inputs are sensor readings and outputs are actuator commands along with two bools left and right. Say the node only calls two nodes: mode_logic and numeric_stuff.

mode_logic is given the sensor readings and returns left and right;
numeric_stuff outputs actuator commands based on sensor readings, left and right.

We write the contract, and say whether left or right is true is not simple and we want to make the most of multi-property.
So we have several modes the ensures of which is left, and the same for right.
@mode left_1 (
  @require <something> ;
  @require <complex> ;
  @ensure left ;
) ;
@mode left_2 (
  @require <something> ;
  @require <else> ;
  @ensure left ;
) ;
...

Now we write contracts about what the actuator commands should be, and that depends on whether left or right is active. It does not depend on which mode left_i --or right_i-- is active, just that left is true.
Obviously we don't want to require left in the numeric specification as left is an output.
We don't want to write the numeric specification of what happens when left in each of the left_i either as it's redundant, and the numeric specification itself might consist of several modes. We get way too many modes, its super messy/unmaintainable/error-prone.
So with this new feature we just do
@mode num_left_1 (
  @require left_1 or left_2 or ... or left_n ;
  @require <something>
  @require <complex> ;
  @ensure we_tell_actuators_to_go_left ;
) ;
@mode num_left_2 (
  @require left_1 or left_2 or ... or left_n ;
  @require <something> ;
  @require <else> ;
  @ensure we_tell_actuators_to_go_left_differently_maybe ;
) ;
...

Details
When the expressions corresponding to the statements inside a node are constructed, the context is augmented with an identifier/expression substitution for each mode m previously constructed in the
current contract.
The substitution is id -> and(req_1, ..., req_n) where id is the identifier (name) of m, and req_1 ... req_n are its requirements.
Since it's a substitution at context level, the identifier is replaced with the conjunction of requirements when creating the expression: it is not a let-binding, and no state variable for the mode identifier is created.
Example
Regression test, mode always_true requires that mode false_so_far is not active:
node abs (in: int) returns (out: int) ;
let
  out = if in < 0 then -in else in ;
  (*%PROPERTY out >= 0 ; *)
  /*!PROPERTY : if in < 0 then (out = -in) else (out = in) ; */
tel

node has_been_true(in: bool) returns (out: bool) ;

/*@contract

  @mode false_so_far (
    @require not (in or (false -> pre out)) ;
    @ensure not out ;
  ) ;

  @mode in_true (
    @require in ;
    @ensure out ;
  ) ;

  @mode always_true (
    @require not false_so_far ;
    @require in -> pre out ;
    @ensure out ;
  ) ;
*/
let
  out = in or (false -> pre out) ;
tel

node my_node (in: int) returns (out: int) ;

(*@contract

  const bound = 10 ;
  var in_bounded = abs(in) < bound ;

  @require in_bounded ;
  @ensure out >= - bound ;

  @mode in_neg (
    @require in < 0 ;
    @ensure out = in ;
  ) ;

  @mode in_pos (
    @require in >= 0 ;
    @ensure out >= 0 ;
    @ensure true -> (
      (pre has_been_true(in > 0)) => out > in
    ) ;
  ) ;
*)
var mem: int ;
let
  mem = abs(in) + (0 -> pre mem) ;
  out = if in < 0 then in else mem ;

  (* Old style still works. *)
  --%PROPERTY out - in >= 0 ;

  (* Doing the same thing using different annotations. *)
  (*!MAIN: true ; *)
  (*%MAIN ; *)
  --%MAIN ;
  --!MAIN: true ;
tel

Looks good.


Fix incorrect check for false values

closes #29

Can you think of other falsy values that should be included in the here?

Your code already handles null and undefined, that leaves:
0n
NaN
"" (empty string)

I'm pretty sure NaN will evaluate as expected (to an empty string?), as will 0n. I think it might be useful to include those in a test.

Yep, we should definitively test this as well.

Adding them.

Ok - added!

Looks like it didn't like 0n in the node 6/8 test runs, so I removed the check - it's only applicable to BigInt (node 10+ support) which when I test locally runs as expected.

Node 6 and 8 are actually pretty old... so we should consider moving to 10+, but that can be done later....


Use concrete phase types

This should help with allocations, since we make closures over these types, which are Unionall right now, this PR makes them concrete.

bors r+

bors r-

bors r+

bors r+


ty.gl (Trendyol Shopping Company) & adj.st (Adjust Ads)

Link
https://ty.gl/010524_wp_saat
Version
Manifest-v3
What browser(s) are you using?
Firefox browsers, Chrome browsers (includes brave, edge, opera, etc)
What platform are you using?
Computer (Windows, Linux, MacOS)
(Optional) Anything else?
This link is generally used for influencer ad tracking. And it was created to earn commission for the link owner. When the link is entered, it shows the page with the relevant product or product list. He includes this in the link he directs. The adjust_redirect parameter value contains the link to be navigated.

https://codeberg.org/Amm0ni4/bypass-all-shortlinks-debloated
use this

I couldn't see adj.st here. Maybe it needs to be added with contribution. @detyso

If it’s an faucet site he doesn’t do those only content sharing where u got that link

What is this repo for? @detyso

The link provided redirects me to a random shopping website:
https://www.trendyol.com/sr?wc=34&qt=kol+saati&st=kol+saati&prc=0-350&os=1&sst=MOST_FAVOURITE&adjust_t=h9ybh70_d50mvs0&adjust_adgroup=story&adjust_campaign=instagram&adjust_creative=010524_wp_saat&adjust_tracker_limit=999999999

You have a virus on ur pc then the link I share is open and you can also google it just by searching codeberg bypass shortlink

Yes, a structure that cleans the affiliate links and directs them as a clean link is required here. @driedpampas


Some changes to the style

Title and Issue number

Close #<issue_no>

Checklist:

[] I have mentioned the issue number in my Pull Request.
[] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md

What is the PR template??

raise an issue first and get it assigned

Opened now


Cannot delete "default" node pool on Kubernetes

I created a Kubernetes cluster using Pulumi a while back and so made a default node pool with 2 VMs which were of medium size. I now want to increase both the size and number of VMs I'm using.
var defaultNodePool = new KubernetesClusterDefaultNodePoolArgs
            {
                Name = "aksagentpool",
                NodeCount = 2,
                VmSize = "Standard_F2s_v2",
                OsDiskSizeGb = 100,
                VnetSubnetId = builderWithNetwork.Network.ServiceSubnet.Id,
                EnableNodePublicIp = false,
                OrchestratorVersion = "1.17.9",
                Type = "VirtualMachineScaleSets",
                MaxPods = 30,
            };

var cluster = new KubernetesCluster($"{context.StackName}-aks", new KubernetesClusterArgs
            {
                DefaultNodePool = defaultNodePool,
...

To do this, I've created an extra node pool and referenced the cluster like below:
var extraNodeSet = new KubernetesClusterNodePool("aks-nodepool", new KubernetesClusterNodePoolArgs()
                {
                    Name = "aksnodepool",
                    NodeCount = 3,
                    AvailabilityZones = new []{"1", "2", "3"},
                    VmSize = "Standard_F8s_v2",
                    OsDiskSizeGb = 100,
                    VnetSubnetId = builderWithNetwork.Network.ServiceSubnet.Id,
                    EnableNodePublicIp = false,
                    OrchestratorVersion = "1.17.9",
                    MaxPods = 30,
                    OsType = "Linux",
                    KubernetesClusterId = cluster.Id,
                });

However. I now want to get rid of my initial "default" node pool. It doesn't seem like I can change the default node pool at all, this leads to a "replace" operation on the cluster which I definitely don't want.
I did think I could delete the original node pool in the Azure portal and do a refresh to see what happened but this felt pretty overkill.

@lbargery sadly it appears to be a limitation as implemented in terraform - see https://github.com/terraform-providers/terraform-provider-azurerm/issues/7093.
That said, the following should work:

create a new system (Mode: "System") nodepool in Pulumi with the desired size
delete the default nodepool from the Azure console
pulumi refresh

Note that subsequent refreshes will construe the new nodepool's configurations as the default nodepool. I will have to check if that is expected behavior. However, the desired nodepool shape and size can be achieved using the above hack.
Apologies for the inconvenience.

Got it - thanks. Have made this work for now.

Thanks for the update @lbargery. I will close this for now but please reopen if you run into issues.


Cart icon doesn't show count

I'm not sure if this is a localhost only issue or not, but here's how to reproduce:

hugo new site demo
cd demo/themes
git clone git@github.com:themefisher/hargo.git
Copy everything inside demo/themes/hargo/exampleSite to demo directory
hugo server -D
Go to http://localhost:1313/

The site looks perfect, but upon loading these JS errors were in the console:

When I added a product to the cart, it's added to the cart, but the cart icon doesn't show the count. I'm not sure if this is related to the errors above.

UPDATED: I fixed all the JS errors and will submit a PR soon. It was caused by two issues:

languageCode should be "en" not "en-us"
Snipcart v2 integration method was used, but linking to v3 snippet

Hey @thdoan
I have fixed that issue, please download the latest code, and enjoy...


fix: 'comleted' -> 'completed'

Issue #492
Description
This PR addresses the typo in the notification of a new member screening being completed. Completed was misspelled as comleted.
Testing steps
Explain how to test your PR manually

Complete a new member screening
View slack notification that had previously shown the incorrect spelling of completed, is now spelled correctly.
Profit 💸

❤


split Send and Request

Depends on https://github.com/keybase/client/pull/14219

Phew. Finally! Hopefully no more conflicts. @buoyad ready for another look thanks!


Multi threading

Hi,
I'm newbie in multi threading and I want to achieve the behavior of the parallel channels processing in one class (with common fields). But when I use the common BtfxWss in different threads I get the following:
File "c:\python35\Lib\multiprocessing\process.py", line 105, in start
self._popen = self._Popen(self)
File "c:\python35\Lib\multiprocessing\context.py", line 212, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
File "c:\python35\Lib\multiprocessing\context.py", line 313, in _Popen
return Popen(process_obj)
File "c:\python35\Lib\multiprocessing\popen_spawn_win32.py", line 66, in init
reduction.dump(process_obj, to_child)
File "c:\python35\Lib\multiprocessing\reduction.py", line 59, in dump
ForkingPickler(file, protocol).dump(obj)
TypeError: can't pickle _thread.lock objects
So, sorry for so stupid question, but is this correct to use the same BtfxWss object in different processes or should I create new instance for each process?
Most likely I do not fully understand how multithreading works, but let me start with this question

Let's see if I understand you correctly:
You'd like to process the data that arrives in the btfxwss class in a parallel way, meaning simultaneously, correct?
In that case you'll only need a single btfxwss class. Then,  start a Process (from the multiprocessing module) and give it a function that pulls data from the btfxwss properties and processes it.

Yes, you are right, that is exactly what i want.
I've tried the following:
import time
from multiprocessing import Process
from btfxwss import BtfxWss
key = 'abc'
secret = 'abc'
pair = 'BCHUSD'
def process_order_book(raw_books):
while True:
raw_orders = raw_books.get()
print(raw_orders)
if name == 'main':
wss = BtfxWss(key=key, secret=secret, log_level='DEBUG')
wss.start()
time.sleep(2)
wss.authenticate()
time.sleep(2)
wss.subscribe_to_raw_order_book(pair=pair, prec='R0', len='100')
time.sleep(2)
raw_books = wss.raw_books(pair=pair)

p1 = Process(target=process_order_book, kwargs={'raw_books': raw_books})
p1.start()
p1.join()

As you can see, I just print the raw books in new process. It works, but it prints only few first orders (messages from queue) and then it stucks on raw_books.get(). What am I doing wrong?

UPD:
Ok, I got it.
After using multithreading, but NOT multiprocessing all works fine.
I think it's because of that the BtfxWss (and its properties) are not so easy serialazable and Python can not share objects between processes. But threads have the same memory space, that's why threads work:
import time
import threading
from btfxwss import BtfxWss

key = 'abs',
secret = 'abs'
pair = 'BCHUSD'

def process_order_book(raw_books):

    while True:
        raw_orders = raw_books.get()
        print(raw_orders)

threads = []
if __name__ == '__main__':

    wss = BtfxWss(key=key, secret=secret, log_level='DEBUG')
    wss.start()
    time.sleep(2)
    wss.authenticate()
    time.sleep(2)
    wss.subscribe_to_raw_order_book(pair=pair, prec='R0', len='100')
    time.sleep(2)

    raw_books = wss.raw_books(pair=pair)

    t = threading.Thread(target=process_order_book, args=(raw_books,))
    threads.append(t)
    t.start()

Well, the issue with using the threading module is that it doesn't actually process data in a parallel manner.
I could make use of multiprocessing.Queue instead of queue.Queue in a future release, that way you can pass the Queue object accessed via the properties to truly parallel processes. Otherwise, I'm not convinced you'd gain much from using threading in this context.
But do let me know your findings!

I've spent some time yesterday to understand the difference between processes and threads and yes, you are right, it'll be not so much odds using a threads.
And I think, multiprocessing queues will be a really great feature =)


publish to pyPI / conda-forge

https://github.com/xarray-contrib/cf-xarray/blob/main/.github/workflows/pypi.yaml

Not automated yet, but nbscuid is now on pyPI! https://pypi.org/project/nbscuid/ 🎉


Namespace and password config for shard

Also use go mod instead of dep

Codecov Report

Merging #33 into master will increase coverage by <1%.
The diff coverage is 67%.

@@          Coverage Diff           @@
##           master    #33    +/-   ##
======================================
+ Coverage      78%    78%   +<1%
======================================
  Files          42     42
  Lines        3832   3827     -5
======================================
  Hits         2995   2995
+ Misses        611    610     -1
+ Partials      226    222     -4

Flag
Coverage Δ

#unittests
78% <67%> (-1%)
:arrow_down:

Impacted Files
Coverage Δ

client/config.go
82% <ø> (ø)
:arrow_up:

client/datastor/cluster.go
72% <ø> (ø)
:arrow_up:

client/datastor/pipeline/async_splitter.go
89% <0%> (ø)
:arrow_up:

client/datastor/zerodb/shard.go
25% <0%> (-75%)
:arrow_down:

client/datastor/zerodb/client.go
74% <66%> (ø)
:arrow_up:

client/datastor/zerodb/cluster.go
87% <94%> (+3%)
:arrow_up:

daemon/api/grpc/daemon.go
32% <0%> (-2%)
:arrow_down:

client/metastor/db/etcd/etcd.go
81% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61799d9...7f23018. Read the comment docs.


fix(driver): fix pt_regs missing definition

Signed-off-by: Lorenzo Susini<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-udig

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
This PR fixes build on amazon-linux 4.14
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Hi @loresuso. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: loresuso
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks!
/ok-to-test

Hi @loresuso thanks for this, I absolutely agree with you we need to clean it after the release :eye:

LGTM label has been added.  Git tree hash: 9b3f02e450ddf2b0d40308a0a90c7e9d7145e1ef

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, loresuso
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fix: support formdata correctly on ky client

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#178
#177  👈
#176
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pevisscher and the rest of your teammates on  Graphite

Merge activity

Nov 5, 10:15 AM GMT+1: A user started a stack merge that includes this pull request via Graphite.


RCON connection failing

This is my docker-compose.yml file:
version: '3.8'
services:
minecraft:
container_name: mc1
image: itzg/minecraft-server
ports:
- "25565:25565"
volumes:
- "/mnt/mc/mc1/data:/data"
environment:
#OPS:
#OVERRIDE_SERVER_PROPERTIES: "true"
DIFFICULTY: "normal"
MOTD: "Testing This Server For My Children!"
EULA: "TRUE"
MAX_MEMORY: 1G
MAX_BUILD_HEIGHT: 256
VIEW_DISTANCE: 15
LEVEL_TYPE: LARGEBIOMES
MAX_PLAYERS: 20
CONSOLE: "false"
RCON_PASSWORD: "minecraft"
restart: always
 rcon:
container_name: mc1-rcon
image: itzg/rcon
ports:
  - "4326:4326"
  - "4327:4327"
volumes:
  - "/mnt/mc/mc1/rcon:/opt/rcon-web-admin/db"
environment:
  RWA_ENV: "TRUE"
  RWA_SERVER_NAME: "mc1"
  RWA_WEB_RCON: "true"
  RWA_PASSWORD: "kidsareapain"
  RWA_RCON_HOST: "mc1"
  RWA_RCON_PASSWORD: "minecraft"

This is more than likely on me. I have something misconfigured or don't have something in at all when i should. Anyone point me in the right direction?
when i type: docker logs mc1-rcon
I get: RconServer [mc1:25575]: Connection failed
I can bash in to mc1 and ping (once i install iputils-ping) mc1-rcon
I can bash in to mc1-rcon and ping mc1
Port numbers match
What am i missing?

On mc1 container. I DO see: RCON running on <IP_ADDRESS>:25575


Relax atol/rol of chainerx.erf float16 test

Fix #7701.

CIs, test this please.

Jenkins CI test (for commit e900b79042a1642c4920ad10736140ebba8d3e53, target branch master) succeeded!

@mergify[bot] This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@mergify[bot] This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

I'll check. 😆

chainerx.erf is v7-only because it was added in #7404.


Build not failing on detekt error

Hi, thanks for this project.
I have the following settings in my config:
fail_on_error: true
reviewdog_level: error
But even tho detekt is failing reviewdog still shows a pass:
https://github.com/hbmartin/protobuf_java_to_protobufjs/runs/2255365060?check_suite_focus=true
Am I doing something wrong configuring this?

I face the same issue, did you figure it out?

This should be solvable using a new public release of reviewdog... soon... when they make it.
We've created our own fork, with a prerelease reviewdog, which at https://github.com/snappautomotive/Detekt-Action so folk can see what's involved. I'm not submitting a PR for this repo because it relies on a custom created version of reviewdog, and it'd be better to wait for the full release, but if you really need to use that functionality feel free to use our fork until the feature has been upstreamed.


Add benchmark project and action to alert performance issues

@OptimumCode CI is green! How about we remove the check if we're inside a PR, and see if the report gets uploaded to another repo + plant a performance regression to see what happens?

@krzema12 sure, let's do it. But I think after that it would be better to remove the published data from the repository

Regarding performance regression: you can see here what it would look like

@krzema12 Results were pushed. https://krzema12.github.io/snakeyaml-engine-kmp-benchmarks/dev/bench/

Works: https://krzema12.github.io/snakeyaml-engine-kmp-benchmarks/dev/bench/
Let me remove this data.

@OptimumCode approved, thanks for this 🙇 🚀


emoji_support contains bad content where there is a literal string

So when you set emoji_support to true, adding a test case to the unicode_test.go:
		{
			name: "literal string",
			yamlStr: `a: |
  hello 😄\n`,
			expectedStr: `a: |
  hello 😄\n`,
		},

Which results:
parsed string does not match:
        expected: a: |
          hello 😄\n
        got: a: "hello 😄n"

I suppose the literal string turns one line due to the go-yaml library. However, the tail n is unacceptable.

I notice you've closed it now, but here's what I've got about the issues with the output just to keep track.
Of the 3 issues with the output:

Double quotes around the result

This is from the yaml library. I haven't yet thought of a context free way to get rid of these due to the way they are added into the formatted output, but I'm experimenting with solutions.

Outputting to a single line

This is also from the library, and this one I'm not sure why it does that. It's possible the yaml.Node serialization doesn't retain the | multiline literal syntax information.

The trailing n

This was a bug with emoji_support in 0.5.0 that I fixed in #55 and will be in version 0.6.0

Haha I also found the issue it should advanced one byte to check 'U'.
Besides I figure it out why it always format to a single since it consider emoji is not printable, so the text contains special characters and always output to escaped one line.


Formatting Types with (... ,) removes the commma

Example:
warp::filters::BoxedFilter<(std::boxed::Box<dyn warp::Reply + 'a>,)>, // this
warp::filters::BoxedFilter<(std::boxed::Box<dyn warp::Reply + 'a>)>,  // to this, causes compiler error

Thank warp's weird and wacky types :D

Right... per https://doc.rust-lang.org/stable/reference/expressions/tuple-expr.html this appears to be the one place in the language where a trailing comma is significant.  Might have to completely duplicate the formatting logic here but I guess that's how it goes.

fn main() {
    x((7,));
}

syn isn't parsing this for me, but it works fine in the rust playground. Need to investigate more.

Looks good! Cheers for fixing this, classic edge case!


Plunker not working

Hi!  Sample plunker example not working now.
https://www.npmjs.com/package/ng2-img-cropper
https://embed.plnkr.co/V91mKCNkBQZB5QO2MUP4/

Please try again today - plnkr was returning lots of 404 and 502s yesterday

Thanks! )


CURLOPT_POST not respected in some circumstances

Appears to be undocumented issue with curl. Will use CURLOPT_CUSTOMREQUEST instead

Please add an example... Reproduction of the bug... Something

Wasn't able to reproduce it. I believe it was because it checks if $post_data is falsey instead of NULL like it should. Changed in newest version.


Add support for zone transfers and wildcard domains

With the new DNS feature we currently blindly brute force the DNS names in the word list to see what resolves. This is a pointless exercise when:

Wildcard records are in use.
Zone transfers are possible.

We should cater for both of these prior to running the brute force, and exit early if needs be. This is effectively what fierce does.

I forked this morning to write this, and then discovered that I know a lot less about Go than I hoped. :( https://github.com/invisiblethreat/offensive-security/blob/master/wildcard_domain.py
import uuid
import socket
import sys

prefix = uuid.uuid4()
domain = sys.argv[1]

try:
  result = socket.gethostbyname(str(prefix) + "." + domain)
  print "%s has a wildcard DNS entry" % sys.argv[1]

except:
  print "%s does not have a wildcard DNS entry" % sys.argv[1]

For wildcard entries, detecting them is at least the first step. If a wildcard entry is found I think the sensible thing to do is bail out.
Zone transfers shouldn't be too bad though :)

The wildcard stuff has been done in https://github.com/OJ/gobuster/pull/10

Wildcard stuff updated in https://github.com/OJ/gobuster/commit/0d43d75890008d7f9eaa2b30f98b2acf7504eed9


named filter chains

It would be good from a stats perspective to have names for the filter chains so that users can easily see how many connections matched on a specific filter chain match [say by SNI or ips]. From a FCDS perspective, adding names is also helpful as we can now tender filterchain resources as named objects, spit out informative errors for specific filter chains, etc.
cc @silentdai ..

I think this has some relation to #7867 in that we need several objects in the API to be named. Even if we dont use the names immediately now, its still useful to ship with one so that we can start taking advantage of it over time.

cc @envoyproxy/api-shepherds

I think this has some relation to #7867 in that we need several objects in the API to be named. Even if we dont use the names immediately now, its still useful to ship with one so that we can start taking advantage of it over time.

Yes this is top of mind for v3. We need to figure out a way to do this so that simple configs don't get bogged down but we give advanced configs flexibility. cc @htuch

is it possible to add this to existing filterChains as it currently has no name field.

My 2 cents: we can add the name in current filter chain.
Soon the FCDS need the filter chain name anyway. By then the name uniqueness will be required.


Fix number_of_replicas resetting to 1 when inc/dec number_of_shards

In MetadataCreateIndexService which is also called when resizing the shards of a table (simple or partitioned) was not checking if the request is a resize or a create, therefore it set the number_of_replicas and auto_expand_replicas, as there were not found on the request (which only changes the number_of_shards). As a result the copySettings logic was finding those settings (reset to default values) and didn't copy them from the existing index settings during the index settings update.
Reproduction example:
cr> CREATE TABLE tbl (x int, p int) CLUSTERED INTO 1 SHARDS WITH (number_of_routing_shards = 32, number_of_replicas = 0);
CREATE OK, 1 row affected (0.014 sec)
cr> INSERT INTO tbl(x, p) SELECT g, 1 FROM generate_series(1, 4, 1) AS g;
INSERT OK, 4 rows affected (0.004 sec)
cr> refresh table tbl;
REFRESH OK, 1 row affected (0.002 sec)
cr> select count(*), primary from sys.shards where table_name='tbl' group by primary;
+----------+---------+
| count(*) | primary |
+----------+---------+
|        1 | TRUE    |
+----------+---------+
SELECT 1 row in set (0.002 sec)
cr> ALTER TABLE tbl SET ("blocks.write" = false);
ALTER OK, -1 rows affected (0.006 sec)
cr> ALTER TABLE tbl SET ("blocks.write" = true);
ALTER OK, -1 rows affected (0.007 sec)
cr> ALTER TABLE tbl SET (number_of_shards = 2);
ALTER OK, 0 rows affected (0.023 sec)
cr> ALTER TABLE tbl SET ("blocks.write" = false);
ALTER OK, -1 rows affected (0.007 sec)
cr> select count(*), primary from sys.shards where table_name='tbl' group by primary;
+----------+---------+
| count(*) | primary |
+----------+---------+
|        2 | FALSE   |
|        2 | TRUE    |
+----------+---------+
SELECT 2 rows in set (0.002 sec)

retest this please

retest this please (LR failure)


Pytorch Version

To make this project useful to more people, we should add a pytorch implementation. This can live in this repository under its own subdirectory that will be exported to a separate pip package, e.g., gloro-torch.

Hello! Is this pytorch version available now? Thank you very much!

Hello! Is this pytorch version available now? Thank you very much!

Unfortunately I haven't gotten to making a nicely packaged pytorch version of this repo. If you're interested in using GloRo for certified robust training in pytorch, you can take a look at this research code https://github.com/hukkai/liresnet which implements some of our latest work (in pytorch). Hopefully at some point I'll find the time to port this work into this project to make it more accessible.
Hope this helps!

Thank you very much!


ci: invalid coverage

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[x] Build or CI related changes
[ ] Documentation content changes

What is the current behavior?
Closes https://github.com/Tinkoff/taiga-ui/issues/4352

@nsbarsukov @vladimirpotekhin hello, please review me


Color sensor

changed colorSensorEquals to compare the h value from hsb instead of the r g and b values

The expectation is that the new intake will not need color sensor for logic and control.


Adding auto-reset points to visibility record

This change:

Introduces binary checksums into ElasticSearch by saving them in the mutableStateBuilder into the search attributes and adding a corresponding transfer task to upsert search attributes.
Adds BinaryChecksums as a new indexed field in the elasticsearch.
Whitelists this new property on the client side.

Coverage decreased (-0.08%) to 67.08% when pulling 988fc82ef7fe8eae8eb9306138dc630aaa3ddfd9 on vitarb:binary-checksums into d553f551eeb6f5aedfcdcc19f2ca6a4d82d214ce on uber:master.


:bug: Issue Credential v1 send-request with auto_remove does not override system default

Holders can request a v1 credential on the following endpoint: "/issue-credential/records/{cred_ex_id}/send-request"
As implemented in PR #2352, this endpoint takes a V10CredentialExchangeAutoRemoveRequest request body, which just contains an auto_remove field. This field has description: "Whether to remove the credential exchange record on completion (overrides --preserve-exchange-records configuration setting)"
I have tested this endpoint with both ACAPY_PRESERVE_EXCHANGE_RECORDS=false and =true, and in both cases, requesting a credential with either auto_remove=True or False has no impact on overriding the default configuration setting.
(Edit: this is for holder cred ex records. I can confirm that cred ex records for the issuer are indeed preserved/deleted when auto_remove is specified on the v1 issue_credential_automated method (not sure about other issuer methods). But this bug report is specific to holder cred ex records, when auto_remove is specified in send-request.)
It works as expected using the v2 protocol. So, I presume there is a missing implementation in the v1 CredentialManager. I can take a look to implement this functionality soon^TM, but just wanted to log the bug so long.
Edit: ACA-Py version 0.11.0

This was addressed in PR #2664 - both v1 and v2 are consistent now.; this PR included a bug fix on v1 issuance not respecting the auto_remove flag.

@usingtechnology Thanks!


Issue 34 generate work shifts dynamically

Fixes #34
What was changed?
GetHelp API does not provide time slots for volunteer shifts per shelter. Therefore, the user will will be able to pick the start and end time of their shift. To assist the user in picking the start and ent time of a shift on a given day, the server generates information about number of workers signed up for different time intervals within that day.
Added a new endpoint:
/counts/
This endpoint requires two parameters:
filter_start_after
filter_end_before.
This endpoint will return a list of JSON objects specifying number of volunteers signed up for different time intervals throughout the given time period. The JSON object format is {start_time, end_time, count}.
Why was it changed?
To help volunteers make a decision on when to sign up
How was it changed?
WIP: Server-side changes for now
Screenshots that show the changes (if applicable):
Example request to this endpoint:
http://<IP_ADDRESS>:5000/counts/7343?filter_start_after=1696352400000&filter_end_before=1696366800000
Example response to this endpoint:
[
    {
        "start_time":<PHONE_NUMBER>000,
        "end_time":<PHONE_NUMBER>000,
        "count": 1
    },
    {
        "start_time":<PHONE_NUMBER>000,
        "end_time":<PHONE_NUMBER>000,
        "count": 2
    }
]

@loganwyas @AbhilashKotha I just requested your review on this. In particular, let me know if you can think of any other test cases I should add to tests/use_cases/test_count_volunteers.py

I have tested the API manually and it works as expected and you have got good test cases. On top of that, I think test cases can be added for edge cases like when there are no shifts

Good idea, I'll add those test cases.


What is point of calling serviceCollection.AddDapperGraphQL?

Hi, what is the point of calling serviceCollection.AddDapperGraphQL?  Looking at the test project, it does not look like any of the added instances are ever retrieved via serviceProvider.GetRequiredService calls.  I've also seen an example work without using AddDapperGraphQL.
Please explain and/or add an example to the readme file explaining why one would use AddDapperGraphGL.
Thanks

It appears that AddDapperGraphQL is there to help you add your own DI types so that they can be DI'd correctly.   It does this via the DapperGraphQLOptions class.