Container::call() does not instantiate object

I'm trying to understand the logic of Container::call() method. I found nothing in the documentation about it, it is not used internally as well.
I hoped this method will allow me to call any method using autowiring. Something like this:
class A
{

}

class B {
    public function someMethod(A $a)
    {
        var_dump($a);
    }
}

$container = new \League\Container\Container;
$container->delegate(new \League\Container\ReflectionContainer);

$container->call('B::someMethod');

But it does not work.
Here: https://github.com/thephpleague/container/blob/master/src/ReflectionContainer.php#L60
you explode string into two strings; later the first string (the class name) goes into invokeArgs() as a first parameter: https://github.com/thephpleague/container/blob/master/src/ReflectionContainer.php#L70
But this is a string, not an object.
It looks like this variant:
$container->call([new B, 'someMethod']);

works, but I do not want to instantiate B manually. I would like the container to create it (it can be shared, its constructor can have other dependencies, etc.).

Hello, I've also encountered this issue before. I solved it by adding
if (is_string($callable[0])) {
    $callable[0] = $this->getContainer()->get($callable[0]);
}

after https://github.com/thephpleague/container/blob/master/src/ReflectionContainer.php#L64.
This is probably a bad way to solve but seems like the only way too.

Can confirm that this is a reproducible bug. @ImEmil has the correct solution at first glance, I just need to confirm that it bubbles out correctly.

Thank you! 🎉


chore: add release-please

This PR adds a github action to create a pull request whenever we've created a new release candidate (as determined by release-please)

@bcoe you're in my github, releasing my packages


Jenkins fails to build v24.0.1 on Linux

The Jenkins build of v24.0.1 fails with a tolerance error on the FGP_TV CPU vs GPU 3d test.
======================================================================
FAIL: test_FGP_TV_CPU_vs_GPU (test_3d_cpu_vs_gpu.TestRegularisers.test_FGP_TV_CPU_vs_GPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/conda-bld/ccpi-regulariser_1727078562276/test_tmp/test/test_3d_cpu_vs_gpu.py", line 171, in test_FGP_TV_CPU_vs_GPU
    self.assertLessEqual(diff_im.sum(), 1)
AssertionError: 1.10373 not less than or equal to 1

----------------------------------------------------------------------

Now, the failure is quite surprising as the test is the one below:
https://github.com/TomographicImaging/CCPi-Regularisation-Toolkit/blob/2b99d0fd810767376fa66625efcb42040104aac2/test/test_3d_cpu_vs_gpu.py#L166-L171
diff_im, the difference between fgp_cpu and fgp_gpu will contain as many ones as many values outside the tolerance. The test is done checking that the diff_im.sum() remains 0. In case of some discrepancy diff_im.sum() should be the number of elements outside the tolerance, not a real number like 1.10373 above.

This seems to have been a glitch: by rerunning it worked (??)


⚠ T:Riza Roblox Proxy has degraded performance

In 68031f9, T:Riza Roblox Proxy (https://rprxy.triza.dev) experienced degraded performance:

HTTP code: 404
Response time: 7856 ms

Resolved: T:Riza Roblox Proxy performance has improved in c73db00.


Pynndescent in t-SNE with k=15 seems a lot slower than in UMAP

I've just noticed that UMAP 0.4.6 with pynndescent 0.5 can be quite a bit faster to construct the kNN graph compared to openTSNE with uniform kernel and k=15. This does not make sense to me. I added verbose=1 to the pynndescent call within openTSNE and here is what I see:
UMAP - 34 sec:
UMAP(angular_rp_forest=True, metric='cosine', verbose=1)
Construct fuzzy simplicial set
Mon Oct 19 13:54:22 2020 Finding Nearest Neighbors
Mon Oct 19 13:54:22 2020 Building RP forest with 21 trees
Mon Oct 19 13:54:32 2020 metric NN descent for 17 iterations
	 1  /  17
	 2  /  17
	 3  /  17
	 4  /  17
	 5  /  17
	 6  /  17
	Stopping threshold met -- exiting after 6 iterations
Mon Oct 19 13:54:58 2020 Finished Nearest Neighbor Search

tSNE -- 61 sec
===> Finding 15 nearest neighbors using NN descent approximate search using cosine distance...
Mon Oct 19 14:03:15 2020 Building RP forest with 21 trees
Mon Oct 19 14:03:33 2020 metric NN descent for 17 iterations
	 1  /  17
	 2  /  17
	 3  /  17
	 4  /  17
	 5  /  17
	 6  /  17
	Stopping threshold met -- exiting after 6 iterations
   --> Time elapsed: 61.53 seconds

I ran both snippets twice to make sure all numba code was pre-compiled.
I don't know why this happens. The pynndescent call in UMAP looks identical to the one in t-SNE. https://github.com/lmcinnes/umap/blob/master/umap/umap_.py#L290

I see the function calls differ slightly, but it's not obvious from the code. UMAP calls pynndescent with low_memory=False, while we here don't set it at all, so we use the default, which is low_memory=True. Could this be the culprit?

Good catch, but it does not look like it's the culprit.
n_trees = 5 + int(round((data.shape[0]) ** 0.5 / 20))
n_iters = max(5, int(round(np.log2(data.shape[0]))))

%time pynndescent.NNDescent(data, n_neighbors=16, metric='cosine', verbose=1, max_candidates=60, n_trees=n_trees, n_iters=n_iters, low_memory=False)

%time pynndescent.NNDescent(data, n_neighbors=16, metric='cosine', verbose=1, max_candidates=60, n_trees=n_trees, n_iters=n_iters, low_memory=True)

%time affinity.Uniform(data, k_neighbors=15, metric='cosine', verbose=1)

I get ~35 sec with both pynndescent calls but 60 sec with affinity.Uniform call, even though all time is spent on pynndescent.NNDescent call from within.
Hmm it's weird. Maybe it's something strange with my machine here.

The plot thickens!
I looked at the system monitor and noticed that when I run pynndescent.NNDescent as written above, I have all cores active, but from within openTSNE only 1 core is active. Not a surprise because we call pynndescent with n_jobs=1 when the input is sparse (because it did not use to work otherwise).
The default is n_jobs=None which I thought is the same as n_jobs=1 but apparently it is actually the same as n_jobs=-1.
Anyway - the solution for this is to remove the ugly workaround at https://github.com/pavlin-policar/openTSNE/blob/master/openTSNE/nearest_neighbors.py#L384 and use self.n_jobs. I tried, and it works beautifully!

Oh, that's great! Thanks for tracking this down! I guess this is another thing to remove before the next release.


Add a Gitter chat badge to README.md

kentcdodds/all-contributors now has a Chat Room on Gitter
@jfmengels has just created a chat room. You can visit it here: https://gitter.im/kentcdodds/all-contributors.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Anyone opposed to using this one instead?

@kentcdodds Yes, the Gitter green distinguishes it from the continuous integration services.

True, how about this then:

I just love the flat square :-)

I like that flat square with the Gitter green @kentcdodds

I tend to prefer the default one as it integrates nicely with GitHub's aesthetic. But I don't feel that strongly either way.

They all look good :+1:

Don't really care, do what you want :)

Now... the biggest question is...
Is gitter-badger now a contributor and should he be added to the contributors' list? :D

Is gitter-badger now a contributor and should he be added to the contributors' list? :D

Haha! +1

I say, if he answers and wants to, let's add him! @gitter-badger, do you want to be marked as a contributor? :D


[bug]:  fix  breadcrumbs

Fixes Issue
Closes  #2248

Changes proposed
When we have category name of two words or more. It has - in the breadcrumbs which should be removed

Screenshots

Note to reviewers

@rupali-codes
Need deployment autorization.

Hello @rupali-codes thank for notice this issue , kindly verify once

@aftabrehan, it is your turn.

Excellent PR, @sanjeevkumar321 🚀
Could you please double-check? The following Regex isn't working as expected.
The sidebar title and the breadcrumbs title should be the same. Feel free to reach out if you need any help. Thank you!

Hello @aftabrehan thanks for this issue kindly verify it.

@sanjeevkumar321
The problem is: you may need to change the logic a little.
Because the category descriptions depend on the previous logic. I've attached screenshots for your reference.
Yours	Original (linkshub.dev)

Hi @Anmol-Baranwal  kindly verify ones
Thanks ,

@Anmol-Baranwal, @CBID2, please help review and merge this PR. Thank you!

@rupali-codes
Deploy this please :)

hi @Anmol-Baranwal  why Merging is blocked can you please check it ?

Hi @sanjeevkumar321
I noticed that I've requested changes and didn't approve the pr.
I'm outside and will review it till tomorrow. If everything is all right, then we will merge it.

@rupali-codes
Please check your suggested changes.

@rupali-codes @aftabrehan
Review this asap. Don't delay it any longer.

Found some merge conflicts that need fixing @sanjeevkumar321.

Closing the PR due to being inactive.


Incorrect Namespace Reference

Crafting Containers by Hand
Namespaces

"Enter namespaces. Namespaces allow you to hide processes from other processes. If we give each chroot'd environment different sets of namespaces, now Alice, Bob, and Eve can't see each others' processes (they even get different process PIDs, or process IDs, so they can't guess what the others have) and you can't steal or hijack what you can't see!
There's a lot more depth to namespaces beyond what I've outlined here. The above is describing just the UTS (or UNIX Timesharing) namespace. There are more namespaces as well and this will help these containers stay isloated from each other."

The documentation incorrectly refers to the UTS (UNIX Timesharing) namespace when it should be referring to the PID namespace. Specifically, the text states:

"The above is describing just the UTS (or UNIX Timesharing) namespace,"

but it is actually describing the PID namespace.

@wondersavant Thank you for all your help catching the errors in the documentation! We'll be releasing the edited, full-featured course this week so I'm working through these updates and will have the site patched today.
I won't blow up your inbox with messages for each issue unless I need clarification. Thanks again for your help!

I am glad I could help. I wanted to let you know that I didn't submit issues for the typos and grammar corrections because I am not a native English speaker and there were quite a few. I plan to review the course again once I finish it and will submit those issues then. In the meantime, you might consider using tools like Grammarly or ChatGPT for those corrections.
Thank you! :)


feat(docker): official Docker image

By popular demand, an official Docker image to run @scalar/api-reference
This is for people who interact more with Docker/Kubernetes than with HTML/JS/Node. Easily added to any existing Docker stack, just requires an OpenAPI URL.
Docker
docker run -p 1234:80 \
  -e<EMAIL_ADDRESS>\
  -e API_REFERENCE_CONFIG='{"theme":"purple"}' \
  scalarapi/api-reference:latest

Docker Compose
version: '3.8'

services:
 web:
   image: scalarapi/api-reference:latest
   ports:
     - '1234:80'
   environment:
     -<EMAIL_ADDRESS>     - API_REFERENCE_CONFIG={"theme":"purple"}

@coderabbit review

@coderabbitai review

@CodeRabbit review

@coderabbitai review


Add for each block

Today is not possible to get a response from a webrequest and make multiple replies.
Add a way to reply with text/media from an array.
As an example: https://www.youtube.com/watch?v=HFqGAjiNoCY

Hi Robert, thank you for your feedback. I added your request to our Feedback Board: https://tiledesk.sleekplan.app/feedback/108107
You should see it soon on our Public Roadmap too! ;-)


TextInput: Inner controls rendering strangely on Firefox

Maybe a grid/flex problem?

Confirmed. It's a display: flex.
Adding min-width: 0 to the inner input resolves this.
As for way this works, I have no idea. It's a display: flex thing I ran into many years ago


Update .gitignore

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Device-specific hvac modes do not work anymore

Home Assistant release with the issue: 0.96.1

Last working Home Assistant release (if known): 0.95.4
Operating environment (Hass.io/Docker/Windows/etc.): Docker

Component/platform: Z-Wave / Climate (https://www.home-assistant.io/components/zwave/)

Description of problem:
After upgrading to the new version all device specific hvac modes are not working anymore. I use Eurotronic Spirit Z devices, that have some special hvac modes.
https://eurotronic.org/produkte/z-wave-heizkoerperthermostat/spirit-z-wave-plus/

These special modes (e.g. Heat Eco) do not work anymore. Neither can they be seen in lovelace ui:

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
No relevant entries

Traceback (if applicable):
2019-07-19 23:24:13 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection.140051300553936] value is not allowed for dictionary value @ data['hvac_mode']
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/websocket_api/commands.py", line 121, in handle_call_service
    connection.context(msg))
  File "/usr/src/app/homeassistant/core.py", line 1130, in async_call
    processed_data = handler.schema(service_data)
  File "/usr/local/lib/python3.7/site-packages/voluptuous/schema_builder.py", line 267, in __call__
    return self._compiled([], data)
  File "/usr/local/lib/python3.7/site-packages/voluptuous/schema_builder.py", line 589, in validate_dict
    return base_validate(path, iteritems(data), out)
  File "/usr/local/lib/python3.7/site-packages/voluptuous/schema_builder.py", line 427, in validate_mapping
    raise er.MultipleInvalid(errors)
voluptuous.error.MultipleInvalid: value is not allowed for dictionary value @ data['hvac_mode']

Additional information:

I am having the same issue with a Honeywell Z-wave thermostat.   My "Heat Econ" and "Cool Econ" modes no longer show up or function in the hvac_mode list (there are just blank spots where these modes used to be.  This started when upgrading from 0.95.4. to 0.96.1.
Device: Honeywell Z-wave Thermostat TH6320ZW2003
<Item label="Off" value="0" />
<Item label="Heat" value="1" />
<Item label="Cool" value="2" />
<Item label="Heat Econ" value="11" />
<Item label="Cool Econ" value="12" />

Ive been digging around and it appears something similar was happening with a different zwave thermostat. It appears that something similar was found by @olbjan. https://github.com/home-assistant/home-assistant/pull/25274

#25287 This seems similar, too

Below is a list of all the thermostat modes known to openzwave.  Currently the climate component is not parsing all of them.
static char const* c_modeName[] = 			{ "Off", "Heat", "Cool", "Auto", "Aux Heat", "Resume", "Fan Only", "Furnace", "Dry Air", "Moist Air", "Auto Changeover", "Heat Econ", "Cool Econ", "Away", "Unknown", "Full Power", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", "Manufacturer Specific" };
My basic understanding of how the code is currently working is that it parses the list of modes presented by the thermostat and simplifies the mode to off, heat, cool, or heat_cool to make the integration consistent for use with Alexa/Google Assistant.   These simplified mode names appear in the drop down list in the UI.
My linear thermostat with HA 0.96.2 is currently showing the following modes available.
hvac_modes: cool,heat,heat_cool,off,Aux Heat
However Aux Heat does not show up in the drop down list and the space in the list where it presumably would be is blank.   Selecting that will generate a "value not allowed for dictionary value" error.   Manually calling climate.set_hvac_mode with "Aux Heat" as the target generates the same dictionary value error.  Somehow "Aux Heat" is showing up in the list of valid modes but for the purposes of setting the mode it is not.   My thermostat has both "Heat" and "Aux Heat" modes.  Both of these will be simplified to appear as "heat" in the mode selection.  Is having two modes under the same key of "heat" is causing one of them to be dropped from the list in the UI because there is a limitation to a single "heat" mode.

Looks like this pull request may solve this problem...
https://github.com/home-assistant/home-assistant/pull/25347

Only standard modes are supported by HA. Special modes need to make use of presets.

Only standard modes are supported by HA. Special modes need to make use of presets.

That looks like a downgrade to me.
Can you please explain how to use presets?

It's just a separate attribute/setting from hvac_mode. I have no idea if the integration you mention support it.

Obviously the integration doesn't support preset modes:
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/websocket_api/commands.py", line 121, in handle_call_service
    connection.context(msg))
  File "/usr/src/app/homeassistant/core.py", line 1150, in async_call
    self._execute_service(handler, service_call))
  File "/usr/src/app/homeassistant/core.py", line 1172, in _execute_service
    await handler.func(service_call)
  File "/usr/src/app/homeassistant/helpers/entity_component.py", line 194, in handle_service
    required_features
  File "/usr/src/app/homeassistant/helpers/service.py", line 316, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/app/homeassistant/helpers/service.py", line 337, in _handle_service_platform_call
    await getattr(entity, func)(**data)
  File "/usr/src/app/homeassistant/components/climate/__init__.py", line 399, in async_set_preset_mode
    self.set_preset_mode, preset_mode)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/climate/__init__.py", line 394, in set_preset_mode
    raise NotImplementedError()
NotImplementedError

Unfortunately the documentation is also not very helpful:
https://www.home-assistant.io/components/climate/

@DaveCo1701 is your problem solved? Mine is not.
I'm glad it's summer and I don't need my heaters.
Can someone please take a look at this problem?

Just downloaded the the 0.96.3 docker container. It did not resolve the issue.

Seems that the Zwave Climate Integration needs to translate the values to the Home Assistant Standard.

@ronytomen, do you know of any examples I could take a look at from other climate integrations? I don’t mind taking a whack at it, but I’m not a programmer...

I think #25393 has the same problem.
@ronytomen I would be interested, too. I have some python skills, but no experience with homeassistant

@DaveCo1701 No, my bugfix was for something completly different. Some devices don't have modes at all and that made issues in the Ui.

@pvizeli As you created the pull request for the climate-1.0 feature, can you please take a look at this issue? It feels like we are walking in the wrong direction. Is this issue a bug or are we misunderstanding the new preset modes? Thank you for your time.
TL,DR: Some special modes like Heat Eco, Full Power or Manufacturer Mode are unusable since the release of 0.96.0. There are blank fields in the ui. When we try to set the modes manually by calling set_preset_mode() an error occurs. The integration has an attribute, that lists all available hvac_modes. This attribute is still working.

It looks like nobody currently supports the zwave integration, because the openzwave-python library is no longer supported, either. I'll take a look at the zwave integration and try to restore its functionality with the latest version of openzwave-python. Let's hope someone updates openzwave-python soon.

@schmic I guess you're more experienced than me with zwave climate integration. Do you think my approach is going in the right direction? Have I missed anything in particular? Please give me a hint, if you can.

@Santobert Sorry, can't help you with that.

No worries, I'll try it myself. At the moment I'm just hesitating to rip my zwave network apart to use the devices for testing purposes. I will do it next week.....


Convert checkpoints without usage of FSDP

Currently, during the conversion of our checkpoints into HF format, the initial model checkpoint is loaded using FSDP. We should remove this overhead, since FSDP loads the model checkpoint on (memory limited) GPUs, which is not required for the conversion.

@rrutmann we have a checkpoint loading component now that only uses pytorch (without FDSP) see PR #102
https://github.com/Modalities/modalities/pull/102/files#diff-d6ecdc61a672a0ed7797db6606dbf337c5958244a2c6fad479a0394ede2e266aR14
Does this fix this issue completely already, @rrutmann?

@rrutmann, can we close this issue?


KeyError: 'images'

After successfully getting the b2sd addon installed, when I click on render I get this KeyError: 'images'
Python: Traceback (most recent call last):
File "C:\Users\Administrator\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\b2sd.py", line 121, in execute
butils.doit(isanim              = b2sd.isRenAnim,
File "C:\Users\Administrator\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\b2sd.py", line 384, in doit
run_sd([currentImgPath],
File "C:\Users\Administrator\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\b2sd.py", line 317, in run_sd
img = Image.open(io.BytesIO(base64.b64decode(res["images"][0])))
KeyError: 'images'

can you show me you current UI of the b2sd tool?

btw, you can join this channel for easy communication
https://discord.gg/MebZKdyGmh

Works now, issue was that I was missing the open pose model called
control_openpose-fp16


feat: allow select size through selectSize attribute

📑 Description
Allow the size attribute of select using the selectSize attribute.

All your PR is failing at Vercel. You need to pull the latest and push it again please.


Update license copyright date to 2018

I think that line should be Copyright (C) 2011-2017 WP-CLI Development Group (https://github.com/wp-cli/language-command/contributors) anyway. See https://github.com/wp-cli/i18n-command/blob/master/LICENSE for comparison.

Yes, we should standardize on always referring to all contributors:
Copyright (C) 2011-2018 WP-CLI Development Group (https://github.com/wp-cli/language-command/contributors)


Mollaret meningitis

Hello,
I received a message from a patient affected with this condition and I noticed it is not listed in MONDO or Orphanet. It is in GARD. https://rarediseases.info.nih.gov/diseases/10868/mollaret-meningitis
Definition: Mollaret’s meningitis, also known as recurrent benign lymphocytic meningitis, is a rare clinical disorder characterized by at least three recurrent episodes of meningitis associated with spontaneous recovery with or without antiviral therapy. Herpes simplex virus type 2 has frequently been implicated in the setting of this illness. RBLM is rare with prevalence rates estimated at 2 per 100,000 persons.
References:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC9586678/
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2744243/
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC8233175/
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC10239340/
Thank you, Gioconda Alyea

Dear @galyea123,
Thank you for reaching out to the Mondo Disease Ontology, part of the Monarch Initiative!
We have received your ticket and will review it as soon as possible.
If you have any additional information or updates relevant to your inquiry, please add them in a comment on this ticket. Your input is valuable in helping us understand and resolve the issue effectively.
Thank you for your patience and for your contributions to Mondo!
Sincerely,
The Mondo Team


Remove xarray isel_points for xarray 0.13.0

Version 0.13.0 of xarray came out yesterday.
I saw in that version the indexing method isel_points has been removed.
So with xarray 0.13.0 installed with current version of holoviews caused the following line to fail
https://github.com/pyviz/holoviews/blob/a010cfc1f4608bfdc4bafb3d1b43e4974b7d8085/holoviews/core/data/xarray.py#L394
The advice by xarray is to use vectorised indexing

Thanks @DancingQuanta. This is very high priority. I'll try to fix it tomorrow morning and follow up with a release shortly after.


Relax float16 forward tolerance of F.cast test

Fixes #7892

Jenkins & flexCI, test this please.

Jenkins CI test (for commit 5e9a94d21957a3242fae9e80faa6f033eeffa86c, target branch master) succeeded!

#7034 is only in v7.


Sdk auto/21729/azure security confidentialledgerbugbash

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-security-confidentialledgerbugbash


Parameter suggest popup has extra empty space

function foo(a, b) {

}

foo()

Trigger the parameter helper window, see empty space where doc comment would go:

Going to work on this.

@ramya-rao-a
1 in this code both signature.documentation and activeParameter.documentation have value of empty string. Isn't this a bug with the language server for not making them null? That is the reason this check doesn't prevent the bug. Null value also makes more sense if there is no documentation.

Currently we are only checking if the main documentation is truthy Shouldn't we check for the documentation of the active parameter as well? I mean:
		dom.toggleClass(this.signature, 'has-docs', !!signature.documentation && !!activeParameter.documentation);

Thank you very much.


feature Allow setting additional HTTP headers, see issue #64

As I followed the comments and suggested implementation in issue #64 ,
this is my proposal for adding the feature incl. a test.
Any feedback is welcome.

Oops ... it seems I broke integration tests.
Found my mistake and being on it to fix it.


eventDrop not always keeping moved items when switching months (no refresh)

Sometimes the events that have been moved, reset after changing months and then going back.
Is there anything special I need to do to make sure they update and not reset?
eventDrop: (event, delta, revertFunc) => {
    console.log(event.title + " was dropped on " + event.start.format());

    self.$refs.calendar.$emit('event-drop', event, delta, revertFunc);
},

How are you passing events through to your calendar?

eventSources within data()
eventSources: [
    {
        events(start, end, timezone, callback) {
            if (! self.site) {
                callback([])
                return
            }

            axios.get(`/api/events/${self.site}`).then(response => {
                callback(response.data.data)
            })
        },
    },
],

So everytime you change your view it will be running that events method.
Unless you are persisting the new event drop to your API you will lose your changes every time you move away from the current view.
...unless I am missing the point?

Okay makes sense. Sometimes it doesn't do a request though. I haven't implemented the saving of the new date but was just testing before I did it.
Seems to be when switching to agendaWeek and listYear and back to month.

I am guessing if it wouldn't need to make additional requests if the new view is a subset of the data it has already loaded, but I am pretty certain it makes a new request everytime you expand or move the current date window.
Glad it is working for you now, though.
Cheers
Brock


Rewrite of the Windows implementation

The Windows implementation hasn't been receiving the attention it needs to be a first class citizen. Even though it passes all the tests on the CI there are a number of issues with it, e.g. #633, #721, #735, #776, #921 and #919. The implementation basically needs a rewrite.
For this we're looking for help as we don't have too many maintainer working on Windows. If you can help please let us know!

See #1034.


Adding animated gif and making the snap shot animated

Nice idea... @AdaRoseEdwards has this feature in Game Girl Selfies:
https://github.com/AdaRoseEdwards/gamegirl-selfies
https://ada.is/gamegirl-selfies/


Language selection

While I appreciate everyones effort in translating Riot l, please please give us a language selection option on Android, just like it is on web.

Got implemented in #1451

I love you! Thanks so much, keep up the great work and spread the love! :-)


GOSS benchmarking

@guolinke Is GOSS finalized enough to start some larger benchmarking on it?
Bosch dataset, 63 leaves, 40 threads, reported 500 iterations for timing:

Format
0 = NA
Booster
AUC
Best Iter
Time

Sparse
FALSE
GBT
0.7095987
140
135683.676

Sparse
FALSE
GOSS
0.7125379
110
96754.299

Sparse
TRUE
GBT
0.7097566
118
132794.350

Sparse
TRUE
GOSS
0.7103012
136
98313.085

So far it seems to provide promising results (both in speed and performance), not sure how it will behave with different parameters.

@Laurae2
The bottleneck of GOSS is it needs to prediction on full dataset on every iteration.
We are working on the speed-up of prediction.

@guolinke Is it at prediction time or during training?
Also, looking at GOSS C++ code, I think the following about it:

On noisy datasets (like Bosch), GOSS will improve the metric performance
On synthetic datasets (like Higgs), GOSS will behave poorly and decrease the metric performance

Do you think this is right? I am starting benchmarks on LightGBM to check whether this is right or not.

@Laurae2 it is in training.
on synthetic datasets, most data have similar weights (gradients), so using GOSS may have loss. However, you can adjust top_rate and other_rate to let GOSS working in synthetic datasets as well.

@guolinke I'm seeing how slow GOSS is on my custom URL reputation dataset (the 2.25M xx 20K massive dataset).
BTW, it spends most of the time predicting in singlethread?

@Laurae2 yeah, it is slow due to prediction, especially when #feature is large. Actually, the prediction is done by multi-thread, But it has many branching (if-else), which causes the low usage per thread.
However, another possible reason is you are using valid data(with metrics) during training .

@guolinke yes I am using a validation data during training. However I did not see it that slow with Bosch and Higgs even with validation data, it was 100% CPU usage.

I see, so it will have two prediction costs, and both slow(due to large #feature).
And if you are using auc metric, it could be even slower since auc is also run by single thread.
BTW, you can build LightGBM with "TIMETAG" flag, and it will output some timing statistics (with verbose=2).
It will be better if you can provide the timing statistics, Thanks.

@guolinke How to build LightGBM with TIMETAG flag in R?
I am using fast AUC computation in R (https://github.com/Laurae2/R_benchmarking#area-under-the-curve-roc-benchmarks).

Add it into cmake, like this https://github.com/Microsoft/LightGBM/blob/master/CMakeLists.txt#L33

It does not output timing statistics.
I added TIMETAG here: https://github.com/Laurae2/LightGBM/blob/test/CMakeLists.txt#L15
I also used verbose = 2 but it prints nothing.
lgb.unloader(wipe = TRUE)
library(lightgbm)
data(agaricus.train, package = "lightgbm")
train <- agaricus.train
dtrain <- lgb.Dataset(train$data, label = train$label)
params <- list(objective = "regression", metric = "l2", boosting = "goss")
model <- lgb.train(params,
                   dtrain,
                   100,
                   verbose = 2)

OK, I got them to appear but they appear only at the end.
10 trees
E:/build/LightGBM/Release/lightgbm.exe data=E:/benchmark_lot/data/reput_train_lgb.data verbose=9999 num_threads=8 learning_rate=0.25 max_depth=3 num_leaves=7 num_trees=10 metric=binary_logloss test=E:/benchmark_lot/data/reput_test_lgb.data app=binary boosting=goss

[LightGBM] [Info] GOSS::subset costs 31.101434
[LightGBM] [Info] GOSS::re_init_tree costs 60.731287
[LightGBM] [Info] GBDT::boosting costs 0.059216
[LightGBM] [Info] GBDT::train_score costs 0.080117
[LightGBM] [Info] GBDT::out_of_bag_score costs 0.000002
[LightGBM] [Info] GBDT::valid_score costs 0.006799
[LightGBM] [Info] GBDT::metric costs 0.006231
[LightGBM] [Info] GBDT::bagging costs 91.993470
[LightGBM] [Info] GBDT::sub_gradient costs 0.007929
[LightGBM] [Info] GBDT::tree costs 17.832810
[LightGBM] [Info] SerialTreeLearner::init_train costs 2.729572
[LightGBM] [Info] SerialTreeLearner::init_split costs 4.766684
[LightGBM] [Info] SerialTreeLearner::hist_build costs 9.566627
[LightGBM] [Info] SerialTreeLearner::find_split costs 0.603679
[LightGBM] [Info] SerialTreeLearner::split costs 0.136154
[LightGBM] [Info] SerialTreeLearner::ordered_bin costs 7.479034

You can compare with 3 trees, because at 5th tree it slows down considerably:
[LightGBM] [Info] GOSS::subset costs 0.000000
[LightGBM] [Info] GOSS::re_init_tree costs 0.000000
[LightGBM] [Info] GBDT::boosting costs 0.014698
[LightGBM] [Info] GBDT::train_score costs 0.023364
[LightGBM] [Info] GBDT::out_of_bag_score costs 0.000000
[LightGBM] [Info] GBDT::valid_score costs 0.001500
[LightGBM] [Info] GBDT::metric costs 0.001815
[LightGBM] [Info] GBDT::bagging costs 0.000002
[LightGBM] [Info] GBDT::sub_gradient costs 0.000000
[LightGBM] [Info] GBDT::tree costs 9.838733
[LightGBM] [Info] SerialTreeLearner::init_train costs 1.318383
[LightGBM] [Info] SerialTreeLearner::init_split costs 2.230926
[LightGBM] [Info] SerialTreeLearner::hist_build costs 6.098757
[LightGBM] [Info] SerialTreeLearner::find_split costs 0.173302
[LightGBM] [Info] SerialTreeLearner::split costs 0.015924
[LightGBM] [Info] SerialTreeLearner::ordered_bin costs 3.545788


Make auction errors human-readable.

I have not added a map from Metaplex errors to printable status info yet, but I have reconfigured how errors are passed around such that we should now be able to retrieve all the relevant information.
I also added a copyable Solscan link to the error page to make referring errors to #tech-support easier.

After some tweaks, the error page now looks like this:


Add barrier

The test-suite depends on  tasty 0.10.* (0.11 is out) . You can close and re-open the pull request for travis to rebuild once that is fixed.

Waiting for https://github.com/philopon/barrier/pull/2

Suceeded by #920


Unexpected back behavior in search

Pressing back on the search results closes the app, instead of bringer the user back to the previous view.

Probably a small variation of the described issue:

open some photo and swipe it up to see details (info + tags)
tap on some tag - a new search is created with this tag applied. So far so good
press android "back" button

Expected behavior: it should return me back to seeing that view with photo details
Current behavior: a tooltip appears "tap back again to exit"


Create pt and update pt-br translations

Creating a new translation pt.
Updated pt-br translation by translating untranslated texts.

Made one more change, "carateres" replaced by "caracteres".


Update qos_ecn_config_test.go

cisco-1.3-uprev

Pull Request Functional Test Report for #1685 / 5d6d0bce8dc2070cb348b5e6a09baca0efc7f2c7
Virtual Devices

Device
Test
Test Documentation
Job

Arista cEOS

DP-1.3: QoS ECN feature config

Cisco 8000E

DP-1.3: QoS ECN feature config

Cisco XRd

DP-1.3: QoS ECN feature config

Juniper cPTX

DP-1.3: QoS ECN feature config

Nokia SR Linux

DP-1.3: QoS ECN feature config

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.948%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1320

Relevant Lines:
2753

💛  - Coveralls

b/285614685 has the internal test results.


Alexa Issue : ID conflict between HA  Bridge an Hue Bridge

Hi,
I'm running the latest HA-Bridge 5.2.2 and since yesterday I'm experiencing something I can't explain : when using Alexa to turn on / off some devices handled by HA Bridge : some work fine, and some doesn't work any more.
All my devices were working properly for month now , so I don't know what is going on.
So if I'm using the HA Bridge Web Interface, devices are working properly (all devices are Domoticz devices) but when I use Alexa (either a physical device like a Dot, or the Alexa App) then some devices work and some don't.
I can't find any pattern that would explain why some works and other doesn't.
What debug info should I enabled to pinpoint the point of failure (I already looked in the logs but can't see any errors, neither I can spot a difference when using a working or non working device)
Does anybody have encountered an issue like this ?

I would do a discover devices again on the alexa

I have done it : I removed one of the device that wasn't working, performed the discovery, Alexa found the deleted device just right. Trying to power on / off = nothing. And I can't see a difference in the logs between a working and non working device...

So after a few attempts for recovering everything, this is what I have discovered : there is something very wrong with Alexa when using both HA Bridge and a real Hue Bridge at the same time and this is a new thing, as nothing has changed in my configuration (except automatic updates for Alexa and the Hue Bridge).
I removed all HA Bridge devices from Alexa, and detected them all again => same behavior those that work continue to work, those that doesn't continue to not working. I removed them all again, and unplugged all Echo devices except one Dot V2 and unplugged the Hue Bridge, all devices came back and they are all working as they should.
BUT : now some of my Hue devices stopped working in Alexa and even worse, when turning on a real hue device in Alexa, it doesn't turn on, instead it's a HA Bridge device that turns on...
So I removed the affected Hue Devices, stopped HA Bridge, detected devices again, Alexa found the removed one, and now I'm back to some HA Bridge devices not working again...
From what I understand : Alexa is sending request to turn on/off devices to the wrong bridge and it's the discovery process that mess everything up (and it doesn't matter if I turn off HA Bridge / Hue Bridge when detecting devices)
Any ideas ? Should I change IDs in HA Bridge (thouhg I can't seem to  be able to change the Hue ID)  ?

Indeed it has something to do with IDs : I have exactly  20 hue lightn devices (and remote and sensors). The  HA Bridge devices that doesn't work do have IDs (second column on the Bridge Devices web page in HA Bridge) less than 20... those with IDs greater than 20 are working....
Moreover If ask to Alexa to turn on the HA Bridge device with ID 17, it does turn on a Hue device that is on row 17 in the Hue Devices page in HA Bridge...

Amazon has changed something there.
I had the same problem last night.
Alexa, turn on the Lights -> truns on the TV (same ID)
(Problem exists with and without hue and harmony skill activated)
My Workaround was to maually edit the device.db.
I change all IDs from 1,2,3,... to 100,101,102,...
After a new discover devices everything works fine.
So if this should be a feature and not a bug from Amazon,
a option to chose the start ID no. can be the trick.

Yup I  changed the ID manually as well to recover.
Though @SelmaUrban I don't understand what you mean with  "problem exists with and without hue and harmony" ? For me : when I unplugged my hue bridge, removed all HA Bridge devices, started discovery : HA Bridges were working fine, as soon as the hue was plugged back, problem appeared again (and was aggravated by a new discovery)
I agreed a custom seed number for the IDs for renumbering could be handy, or maybe there is a smarter way to do it : HA Bridge is able to connect to the Hue Bridge and can ensure IDs are not in conflict with Hue...

@StephaneM60 only for information that the problem exists with and without activated alexa smart home skill for those two.
"What about people with 2 or more hue bridge" is the big question away from ha bridge.

Same issue here. Will try to change IDs

I will have the numbering start higher than 100

So , the new version will have an ID seed you can control in the bridge settings screen and it will renumber from that value.

Fantastic!


Task "assembly" fails with "[error] (assembly) java.nio.file.InvalidPathException: Trailing char < > at index 121"

Executing the task "assembly" fails with "[error] (assembly) java.nio.file.InvalidPathException: Trailing char < > at index 121: C:\Users\IdeaProjects\GlobalConfigEditor\target\scala-2.13\GlobalConfigEditor-SettingKey(This \ This \ This".
build.sbt
name := "GlobalConfigEditor"

version := "0.3"

scalaVersion := "2.13.1"

mainClass in assembly := Some("globalconfig.ConfigEditorApplication")
assemblyJarName in assembly := s"GlobalConfigEditor-$version.jar"

assemblyMergeStrategy in assembly := {
  case PathList("META-INF", xs@_*) => MergeStrategy.discard
  case PathList("reference.conf") => MergeStrategy.concat
  case x => MergeStrategy.first
}

libraryDependencies += "org.apache.commons" % "commons-lang3" % "3.9"
libraryDependencies += "commons-io" % "commons-io" % "2.6"
libraryDependencies += "ch.qos.logback" % "logback-classic" % "1.2.3"
libraryDependencies += "com.typesafe.scala-logging" % "scala-logging_2.13" % "3.9.2"
libraryDependencies += "com.typesafe.akka" %% "akka-actor-typed" % "2.6.3"
libraryDependencies += "org.fxmisc.richtext" % "richtextfx" % "0.10.4"

libraryDependencies += "org.scalatest" %% "scalatest" % "3.1.1" % "test"
libraryDependencies += "org.scalamock" %% "scalamock" % "4.4.0" % Test
libraryDependencies += "org.mockito" % "mockito-scala_2.13" % "1.11.3"
libraryDependencies += "org.mockito" % "mockito-scala-scalatest_2.13" % "

plugins.sbt
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.10")

build.properties
sbt.version=1.3.8

I found the solution to my problem through StackOverflow:


Bug: currently viewing file can also be imported to the copilot chatting panel

as shown in the image, though already viewing webpack.common.js, it can be imported again.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.96.2
OS Version: Windows 11 Pro 24H2

Steps to Reproduce:

drag and drop currently viewing file to the panel

It is the latest version.

It is the latest version, typo issue.

Duplicate https://github.com/microsoft/vscode/issues/233040


Radio button stops been checked on click in IE when tap.js loaded

When there's tap.js loaded on a page then radio buttons stop been checked on click.
IE9, 10, 11
all under Windows 7
http://codepen.io/konclave/pen/vOqYBp

Gonna check


Size must be specified in styles

I thought this package wasn't working until I realised that I need to specify the size both in the props and in the styles. This seems unexpected to me. Maybe the docs should mention this if it is expected behaviour.

From readme:
"Icon style must set a width and height, or the icon will not be visible"

We should probably add a check warning to the code since this comes up quite a bit
On Mon, Nov 30, 2015 at 10:49 AM, Jacob Patenaude
<EMAIL_ADDRESS>wrote:

From readme:
"Icon style must set a width and height, or the icon will not be visible"
Reply to this email directly or view it on GitHub:
https://github.com/corymsmith/react-native-icons/issues/143#issuecomment-160704358

Could you add a default value instead of a warning/docs?
Anyone who needs to is going to actually see the size needs changing and work out how to change it themselves.

Closing this as support for this library is being discontinued, I highly recommend using https://github.com/oblador/react-native-vector-icons instead as its more fully featured, I've added a warning to the Readme about this as well.


feat(bundler): bundle additional gstreamer files, closes #4092

A couple of things:

i know it's weird to have a new appimage config like this, a more obvious choice would be to have a new "parent" linux config for both appimage and deb (especially for consistency between OSes). I'm happy with changing it, i just didn't want to start this PR with a breaking change.
idk how to call the flag, so i just went with gstreamer for now.
It currently should fail to build on non ubuntu-like systems because i didn't modify the gstreamer plugin yet, but since this is not bound to tauri's release pipeline i thought it be better to at least get the PR out asap.
The fix that worked ~3 weeks ago doesn't really work anymore. It still fixes app crashes but it doesn't play videos on youtube and twitch (some other pages like https://camendesign.com/code/video_for_everybody/test.html work fine tho), it could very well be my system's fault because it's acting up generally right now. I'll do some VM testing when i make changes to the plugin (tomorrow)
As of now the plugin re-introduces the patchelf dependency and i'm not 100% sure if we will/can get rid of it (didn't really look at it).

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] Not yet, see 1)

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

I don't think it's weird to have an AppImage config tbh.
the flag could name could be bundleMediaFramework or something like that, gstreamer doesn't seem that bad too - i also hate naming things

1 Yeah i'm happy with an appimage config too, it's just that i keep comparing it to windows > wix in my head. And then i think about potential rpm and flatpak props too. Well we can worry about that for v2 i guess 🤷
2 i like bundleMediaFramework, should be clearer for non-linux people etc. Unless we want to keep it synced with the env var because i'd prefer that to still be called something with gstreamer

Yeah let's worry about reorganizing the config options in v2. And we don't need to sync with the env var, makes more sense to keep using gstreamer since the bundler is also used by non-tauri users.

This PR won't get changed anymore, only the plugin itself to make it work on more distros (and hopefully fix the youtube&twitch issue again)


Please Halp

I believe os and csv are part of python's standard library. Remove them from the requirements.txt document and try running pip3 install -r requirements.txt again

please git pull once script has been updated

@Vause
Thanks, that worked perfectly.


Add Developers Institute to Jetbrains list

Contributing an NZ accredited tertiary institution: See www.developers.ac.nz

@fiq Pull request merged. Thank you!


Vulkan: Selecting 8× MSAA on Apple M1 GPU crashes the editor

Related to https://github.com/godotengine/godot/issues/53940.
Godot version
4.0.dev (489f11ee0)
System information
Apple Mac mini 2020 (M1), macOS Monterey 12.1
Issue description
The M1 GPU only supports 4× MSAA at most, yet Godot's Vulkan renderer allows setting it to 8× even on GPUs that don't support it. Instead, the MSAA value should be clamped to the highest value supported by the hardware.
Additionally, the MSAA property hint in the project settings could be automatically modified to denote that specific values are unsupported on the user's machine.
I haven't checked whether this occurs in 3.x's GLES3 and GLES2 renderers yet.
Steps to reproduce

Create a new project. Add a MeshInstance3D node with a BoxMesh resource.
Open the Project Settings and enable the Advanced toggle.
Set MSAA to 8×.

Minimal reproduction project
N/A

I haven't checked whether this occurs in 3.x's GLES3 and GLES2 renderers yet.

My M1 does not crash using MSAA 8x/16x on either GLES2 and GLES3, so this only applies to Vulkan.

System info: M1 MacBook Air 2020, also running MacOS Monterey 12.1
Godot version: v3.4.stable.official

My M1 does not crash using MSAA 8x/16x on either GLES2 and GLES3, so this only applies to Vulkan.

Can you spot a visible difference between 4× MSAA and 8× MSAA (or 16×) in either GLES2 or GLES3? You can take screenshots with each mode and use https://github.com/kornelski/dssim to generate a visual diff of the image if you can't spot the difference with your own eyes.


latest git ( rev g840792f) allows firefox 52 without alsa support to use sound on Arch Linux, when is next release ?

Mozilla decided to deprecate alsa support from firefox 52.
I used arch linux aur apulse-git[1] package,  and tested with firefox-52.0-1 .
[2] was used to test things, and apulse-git succesfully made firefox believe pulseaudio was present.
Every test succeeded.
I intend to install apulse on several other AL systems i help maintain, but convincing the owners would be easier with a recent stable release.
Thank you for this program.
[1] https://aur.archlinux.org/packages/apulse-git/
[2] https://hpr.dogphilosophy.net/test/

Audio output works, but there are issues with volume control. It's absent. When Firefox detects PulseAudio it asks it to control sound volume. At the moment apulse have no volume control at all, and therefore volume controls on audio players in Firefox don't work.
I want to address that issue before declaring another release.

I hope it's not a big deal to change volume by ALSA and implement PA API. Am I right?

I hope it's not a big deal to change volume by ALSA and implement PA API. Am I right?

Well, yes and no.
I did a web search, but found no way of controlling volume of a single pcm context. There is a softvol plugin, but I can't figure out how to use it in software. Its entry points are exposed by libasound.so.2, but there are no function prototypes in headers, so that's internal fragile interface. Also there are conceptual difficulties with controls. As far as I understand, user must create and destroy controls. So, I'm confused.
On the other hand, volume changing could be done manually by multiplying each sample value by a number. That's tedious, error-prone, slow. But clear, at least. :-)
And one more thing. Last time I tried to implement volume-related API part, Skype turned volume to almost zero, and effectively stopped capturing any sound.

check how alsamixer works :)

check how alsamixer works :)

It's required to have per-context, or at least per-process volume control. Say, there are two applications running, using PulseAudio API. One says "I want my volume set to 100%", other says: "I want my volume set to 15%". Can ALSA mixers do that? Last time I checked, there were no per-process volume control in alsamixer.
Am I missing something? Could you elaborate on that, please?

Implemented volume scaling in software, per-context. Far from optimal, but should work.
Also just made a release: https://github.com/i-rinat/apulse/releases/tag/v0.1.8

@i-rinat Thank you so much for this release! I just tested it here (GoboLinux, Firefox 52 32-bit, apulse 0.1.8, no PulseAudio installed) and testing a YouTube video, Firefox plays the audio perfectly, but the video becomes choppy (like <10fps) and a little jittery. The CPU consumption doesn't seem to be a lot higher (the four virtual cores in my dual-core hyperthreaded i7-4500U laptop stabilize at about 20% each, with or without apulse).
Let me know if you need more information, and if I should open a separate issue. Thanks!

Let me know if you need more information, and if I should open a separate issue.

I've just tested it, and also see the issue. Created #45 to track it.

I've always been taught that you should use some sort of logarithmic function instead of multiplying by constant when dealing with audio volume. Of course, if the values are already logarithmic (based on decibels, for instance) that wouldn't matter.
But, if using a constant produces less fine volume control, maybe looking up some logarithmic functions for audio amplitude would be appropriate.

@trlkly,
as far as I understand, PulseAudio volumes are linear inside, despite documentation says they are logarithmic. But there are special functions available in API, that translate slider position from [0, 1] to internal volume, and backwards, from internal volume values to slider position. And surprisingly, functions used are not logarithm or exponent. It's cube and cubic root.
PulseAudio does this after http://www.robotplanet.dk/audio/audio_gui_design/, so I decided to use similar formulas.
There are could be errors in implementation, since I'm not an expert in audio processing. I did some experiments though, and think that current formulas are fine. Better than just using linear mapping.

There were couple of bugs, so here is another bugfix release: https://github.com/i-rinat/apulse/releases/tag/v0.1.9


[cranelift] Fix block and value names in IR documentation

The paragraph describing how a C loop compiled to Cranelift IR seems to have gone out-of-sync with the code. This PR updates the block- and value-names to fix this.

I think the test issue is not related to this PR, so going ahead and merging.


Bump backtrace-rs

0.3.59 is the first version of backtrace-rs that doesn't use gimli-symbolize: https://github.com/rust-lang/backtrace-rs/commit/5fc4f79674206c2041b9ffeec6e3891c73510147
While the feature is still there, it is unused and later on removed in https://github.com/rust-lang/backtrace-rs/commit/4cbe6b69eaccf23297b51f9584dd8a7d5e12ea95. Original PR #615
Closes https://github.com/eyre-rs/eyre/issues/174

@ten3roberts anything I can do to push this forward?


Delete unix sockets on daemon shutdown

Summary:
The daemon used to clean up its unix sockets after #6962 got merged, but there was a regression in #7317 and now it's not the case anymore.
Proposed solution:
Implement removeUnixSockets as a method on Daemon and call it during daemon shutdown.

Sockets where moved out of Daemon in this commit:
https://github.com/docker/docker/commit/1d10c55aec891df609d36c90ee6c30adb24c16c4
shouldn't the removeUnixSockets be implemented somwhere else?


tpm2_certify - improper serialization of data to disk

This code does not consider structure padding, and type endianess. This is a good canidate file for placing a header on or at least serializing properly.
    rc = saveDataToFile(ctx->sigFilePath, (UINT8 *) &signature,             sizeof(signature));     if (rc) {         return false;     }

Some of this was fixed, some of it remains with TODO's marking them.

#367
In lib/files.h:
https://github.com/01org/tpm2.0-tools/commit/785d443396a8afdeb9b62f4f3d76545d22a7aa0c#diff-a57b2583fc6eb5f9c21e109490bf17d7
bool files_save_tpm_context_to_file(TSS2_SYS_CONTEXT *sapi_context, TPM_HANDLE handle, const char *path);
bool file_load_tpm_context_from_file(TSS2_SYS_CONTEXT *sapi_context, TPM_HANDLE *handle, const char *path);
The second API function was incorrectly re-named with prefix "file_", which should be "files_"


EventHubs Comparison

The new queues should be added to the comparison matrices here (Event Hubs and Event Grid). I can't find a single location that compares all of the options (but the information is available across multiple pages, e.g. https://docs.microsoft.com/en-us/azure/event-grid/compare-messaging-services).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: afed582b-fb3f-30b3-b119-6c4a9218bf34
Version Independent ID: d4cf3473-21c1-2409-e7ac-9ad93fbc5895
Content: Azure Storage queues and Service Bus queues compared and contrasted
Content Source: articles/service-bus-messaging/service-bus-azure-and-service-bus-queues-compared-contrasted.md
Service: service-bus-messaging
GitHub Login: @spelluru
Microsoft Alias: spelluru

@jcdickinson Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

I have added a link to the queue comparison article from the "Compare messaging services" article.
https://docs.microsoft.com/en-us/azure/event-grid/compare-messaging-services#next-steps
#please-close


[FRONTEND][TENSORFLOW] Enhancements.

* Generalize the shape with explicite argument.
* Supported entire range of mobilenet_v2 models.
* Cast op updated to latest tensorflow.
* Documentation updates.
* CheckNumerics op handling without exception.
* API to fetch test data from tensorflow official releases.

Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

cc @masahi @sgrechanik-h @Huyuwei @FrozenGene welcome to review

@sgrechanik-h  please have a look.
I have tested all models (MobilenetV1/V2, Resnet, Inception, VGG) from research/slim.

@tqchen
I have made some utils and documentation related to generating model protobuf files from tensorflow official checkpoints at https://github.com/srkreddy1238/dmlc_data/tree/master/work/tf/samples.
Do you think we could accommodate them in TVM as docs & utils?
Or
Make them as test cases but deactivate?

In the interest of minimum codebase, let us keep it as a separate thing, but we can generate the proto and download them in the testcase. Thanks @srkreddy1238

@tqchen
I am not talking about adding the protobuf files into TVM.
Also tensorflow research/slim models are nearly 40, adding all of them into test cases delays the CI time.
Some of them need building few utils from tensorflow source too (Resnet, Vgg) to prepare protobuf from checkpoint.
My interest here is about sharing the steps(tutorials) from tensorflow release to NNVM frontend import.
What do you suggest ?

Maybe we can build up another set of test that runs nightly, and the normal fast test jobs to make sure general coverage

Another possible approach is to provide the conversion dry run, which converts the model but does not run them. This can considerably reduce the test time and can be placed in the CI

+1 for nightly build.
Conversion dry run is not a straight forward as checkpoint to protobuf conversion need https://github.com/tensorflow/models (to generate initial protobuf) and freeze_graph built from tensorflow source to embed checkpoint into it.
I may revisit into simplifying/automating this later for nightly build. For now I will leave a doc @ docs/frontend/tensorflow.md.

@nishi-t  welcome to review.

cc @nishi-t have another look pls.

Thanks! this is now merged.


add notes about claiming plex server to documentation

Is your feature request related to a problem? Please describe.
When I enabled the plex docker image, for a long time I was mystified why my server was invisible to plex clients, even when connecting to the server on port 32400
Turns out you need to issue some commands to register your server with plex itself. This is summarized here https://forums.plex.tv/t/plex-cant-find-my-server-help/274370/7 and someone provided a script to do this.
For me the sequence of commands (run inside the plex container using Portainer) worked and now my plex server is working beautifully:
# download the script
curl -L -o plex-claim-server.sh https://github.com/uglymagoo/plex-claim-server/raw/master/plex-claim-server.sh
# make the script executable
chmod +x plex-claim-server.sh
# go to https://www.plex.tv/claim/ in your browser and get the claim token and replace PLEX_CLAIM with this token in the next command, please use use the double quotes around your claim token
./plex-claim-server.sh "PLEX_CLAIM"

Describe the solution you'd like
Some kind of note in the documentation that this needs to be done else the plex server won't be functional.
Describe alternatives you've considered
None so far, but I'm a plex newbie.

I believe it's possible to claim the plex server just by logging in to it with your plex account.


[Feature]: Edit and post link to Enarx code walkthrough

Is there an existing issue for this?

[X] I have searched the existing issues

Description
It would be helpful to edit and post @npmccallum's Enarx project code walkthrough video and make it easily consumable.
Acceptance Criteria

[ ]  Break apart into sub-videos
[ ] Remove crosstalk/digressions/non-enarx related discussions
[ ] Add sub-video topic splash graphic containing enarx logo & section title.
[ ] Add opening and closing enarx project splash graphic (to first video and the last)
[ ] Create draft blog post providing overview to video series along with private youtube playlist for review
[ ] Approval/signoff by @npmccallum and/or @MikeCamel
[ ] Publish playlist & document/TOC in blog and/or post  for full walkthrough

Suggestions for a technical implementation
No response

I believe we can break the video down by these categories:

Main crates: enarx and sallyport
Secondary crates: key for enarx
Helper crates: auxiliary
Lab machines & workflow
Documentation & outreach

I would have to record any missing video, but coverage is excellent.
Main crates:

[ ] enarx:

[X] src: code that runs in the host side. backends
[X] internal: wasmldr, shin-sev, shin-sgx
[X] examples: tcp_server
[ ] tests
[ ] helper

[X] sallyport: communication channel between untrusted host and guest: mostly syscalls.

Secondary crates:

[X] ctr0stack: read write stack from Linux kernel for things like environment variables.
[X] vsdo: used by sgx to enter an enclave
[X] rct1: load binary from disk (static or dynamic)
[X] xsave: save x86 cpu state
[X] flagset: handle flags
[X] sgx: set of data structures related to sgx
[X] mmarinus: rust nmap (network mapper) wrapper
[X] iocuddle: rust ioctl (input/output control) wrapper (runtime-safe)
[X] noted: macro to generate notes (define size of enclave, etc)

Helper crates

[X] lset: types for measuring linear sets
[X] nbytes: define constants
[X] uabs: calculates the absolute value of input and returns unsigned integer
[X] signrel: maps relationships between integers that only differ by signedness

Lab machines & workflow

[ ] gitlab.com/enarx: lab machines
[X] linux: used by the lab machines (sgx and sev)
[X] .github: templates for issues
[X] spdx: github action to find OSI license

Documentation & outreach

[ ] enarx.github.io: website: documentation, resources, and community.
[ ] outreach: outreach work
[ ] outreachy: outreachy interns


Signature of metainfo2 is not correct

Hi, I tried the toolbox with my audi harman MIB2 High Firmware 0875, and when i choose the SD-Card at the update menu, i get the error: "the signature of metainfo2.txt is not correct"
Is there something i can do? Thank you!

That's interesting, because the metainfo has no sigmature :-) I'll look into this, but it seems this specific firmware is not accepting any metainfo without signature.

tt8824a I think you have the same problem here is the picture I have MIB1 VW I install firmware 0388 it give me this problem neither SD card nor Map nothing that works

Hello again, do you have an idea, if there is a way for me to solve the problem?
Thank you very much!

MHI2 ER AUG22 S2116 MU333 unit display metainfo2 is not correct. Someone have some idea ?

@jilleb hi! any updates on this? I also got the error on an Audi TT. I had to update the firmware to MHI2_ER_AU43x_P5098, MU software 1339 to have the CarPlay compatibility

No updates. It's nearly impossible for me to troubleshoot this when I cannot reproduce the error on my own devices.

OK. Thanks

hello. I try it that code, but not read metainfo.txt. Maybe my FW very old.
My Mib2 FW 0814. How can update newer version? Thanks

I cannot reproduce the issue and therefore cannot fix it.
About updating:
Get new firmware
Install it by holding Menu button and go to update.

Hello, I have problem with instalation new version and when I want to update i get the error: "the signature of metainfo2.txt is not correct". Anyone can help?


Environment variables from (builtin?) extensions that update are not cleared

Version: 1.45.0-insider (user setup)
Commit: ece7aaee861d7261a728d52ce436c667030ce17d
Date: 2020-05-01T09:46:47.589Z
Electron: 7.2.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

I noticed this morning that I received this error when running a script:
Error: Cannot find module 'c:/Users/Connor/.vscode-insiders/extensions/ms-vscode.js-debug-nightly-2020.4.3017/src/bootloader.js'

I currently have version 2020.5.217. It looks like variables for the old version weren't cleared on update. If I recall correctly the intention was that they would be. If not, a workaround I can do is to store a copy of the bootloader script in the extension's workspace storage directory. Let me know what the preferred solution would be 🙂

The design is not to clear on extension updates, only uninstall/disable (based on the IExtensionService.onDidChangeExtensions event).


Suggestion: Add april fools joke

"YOU MUST CONSTRUCT ADDITIONAL PYLONS!"
Any time you break a pylon and it doesn't drop, that is signaled in the chat.

Thanks for the suggestion but I don't do april fools jokes.


Adding complete Espressif IDF compatibility

I removed the hard coded dependency to all Arduino libraries, especially the PubSubClient.
It is now possible to pass the IMQTT_Client as a interface implementation instead and that implementation will be used to send the data instead of directly using the PubSubClient.
This modularity with the previously created IUpdater interface, allows to use even Espressif components to initalize and use the library.
It has been tested with the ESP32 and compiles with both PlatformIO and the ESP-IDF extension, for the latter CmakeLists.txt files have been added that configure which files to compile and which not to compile.
Additionally even some of the Configurations are settable via the ESP-IDF menuconfig.
Furthermore both sending and receiving data works flawlessly, even fully getting an OTA udpate over MQTT worked when using Espressif IDF.
For sending telemetry data and processing OTA examples have been added to the library, for the other features it is simply possible to copy the needed code section from the Arduino examples.
Fixes #146, fixes #149

Additionally as long as the libraries exist, even Arduino framworks users profit from the change, because some internal components can now directly use Espressif instead of having to rely on Arduino middleware which simply wraps the calls.
Thanks to that it was possible to improve for example the Callback_Watchdog for ESP32 users, where the memory allocations and de-allocations have been drastically reduced.
Furthermore it is also possible to use the Espressif_Updater implementation, instead of Arduino_ESP32_Updater implementation, this has been adjusted in the examples and is highly recommended, because the underlying Arduino library used by Arduino_ESP32_Updater  has some fatal memory leaks and undefined behaviour.
Meaning those issues have now been resolved as well and will make the library even more stable and efficient, when using OTA.
The documentation has also been updated to reflect the possible usage with Espressif IDF. The same has been done for the internal documentation additionally making the description of some types more detailed or adding documentation where there was previously none.
I also changed the way the vectors are initialised when using the callback helper classes, especially the shared attribute update and update request callback wrappers. Those now simply forward multiple passed arguments to the std::vector constructor or assign method instead. Which allows to create the vector in more ways then previously were only the copying from the given start to the given end iterator was possible.

@imbeacon Would be nice if this could be merged as v0.12.0 and if possible it would be nice if you could release this library as a component on the ESP IDF component registry as thingsboard/ThingsBoard.
This would allow users to very easily install the library when using Espressif IDF and make ThingsBoard easily accessible to an even wider userbase.
Additionally it would be nice if you could change the description of the GitHub repository to Library to easily connect and communicate with the ThingsBoard IoT Platform, to remove the reference to Arduino because that is not required anymore.

Hi @MathewHDYT,
I think in this case it won't match the repository name, when we remove Arduino support it will be some kind of thingsboard-esp-idf-sdk. I will discuss this point with team and maybe we will create a separated repository, or rename this.

I additionally added more GitHub Actions that will compile the created examples on esp-idf to ensure any Pull Request or Commit does not break the internal examples folder.
@imbeacon Any progress on the merge, because you can still compile for Arduino. Therefore I would prefer simply calling the library thingsboard-sdk.

Hi @MathewHDYT,
Yes, we will update the name of the repository to thingsboard-cpp-sdk, because we already have some sdk repositories and it won't be clear for users what kind of sdk. Also, now I'm updating documentations with new examples and check links to the repository. Also, after renaming I will update the Arduino libraries repo.

Hi @MathewHDYT, great contribution! We have renamed the project and briefly changed the description. @imbeacon  will review and merge your PR. We will also update the necessary repositories like Arduino Libraries, Platformio, etc.

Hi @MathewHDYT, great contribution! We have renamed the project and briefly changed the description. @imbeacon will review and merge your PR. We will also update the necessary repositories like Arduino Libraries, Platformio, etc.

Thanks a lot the project is in a pretty good state right now feature wise and there currently is no library that allows to easily connect and send data to ThingsBoard when using espressif. As far as I know most people simply use the esp_mqtt client directly and hardcode the calls to ThingsBoard by hand.
So making this library solve both will definitely help a lot of people.

Thanks a lot for the merge would be nice if you could update the PlattformIO and Arduino registry if possible as well.
Additionally it would be highly appreciated if you could add the project as thingsboard/thingsboard, so the same name as in PlattformIO and Arduino registry to the EspressifIDF registry. This would make using the project with Espressif IDF build tools much easier.

@imbeacon The project has not been yet registered on the EspressifIDF registry as thingsboard/thingsboard. Would be nice if that could be done as well so that the library can be included in projects using the Espressif IDF toolchain more easily.

Hi @MathewHDYT ,
I have written to Espressif and wait for response to create a ThingsBoard namespace. Then I will be able to push the component to this namespace.

Hey guys, jumping to v0.12.0 I have a question about using my SimCom7000 with ESP32-S2 to be used as a client for Thingsboard. Here is the code I had working with v0.11.1:
#define TINY_GSM_MODEM_SIM7000
TinyGsm        modem(SerialAT)
TinyGsmClient client(modem);
ThingsBoard tb(client);
With v.0.12, I saw the example Espressif_MQTT_Client.cpp and tried that but still doesn't compile:
// Initalize the Mqtt client instance
Espressif_MQTT_Client mqttClient;
// Initialize ThingsBoard instance with the maximum needed buffer size
ThingsBoard tb(mqttClient, MAX_MESSAGE_SIZE);
Error i get: no known conversion for argument 1 from 'TinyGsmClient' {aka 'TinyGsmSim7000::GsmClientSim7000'} to 'const Espressif_MQTT_Client&'
However, if I use the Arduino_MQTT_Client it seems to work ok:
Arduino_MQTT_Client mqttClient(client);
ThingsBoard tb(mqttClient);
Can you suggest what is the best to do here? Is this how it is supposed to be? I feel like v0.11.1 was cleaner.
Thanks for clarifying

@spirosbond Sorry for the confusion, the examples in the library all contain a README.md file, which explains which boards and Frameworks they support. In your case the second code option is most likely what you need to use, because the Espressif_MQTT_Client is only meant for users which use the Espressif Toolchain and the Espressif base and are not using Arduino.

Below you can find a more detailed description of why we changed the internals of the library:
v0.11.1 was easier to use because we always expected a Client interface to be passed to the ThingsBoard and then passed that Client to the PubSubClient. Which was then used to send and receive MQTT data.
This makes using the library with anything besides platforms and boards that support the PubSubClient impossible tough.
Therefore this hard dependency has been removed, instead the ThingsBoard construct expects a IMQTT_Client implementation, which simply has to follow the interface but allows using basically anything as the intermediate connection class.
This of course slightly increased the complexity on the user side, but in my opinion it is 100% worth it. Because currently there is no ThingsBoard library that acts as an intermediate when using the Espressif IDF Toolchain and the support for other MQTT clients like the base client from Arduino can now be easily integrated by an end-user as well which is a nice bonus.
Because of that increased flexibility I wrote some default implementation to make the library still easy to use, that's the reason why there is a Arduino_MQTT_Client, which is as the name implies meant for Arduino boards and then the Espressif_MQTT_Client, which is as the name again implies meant for the Espressif IDF toolchain.


Find appropriate base class for UnpythonicGetterSetterViolation

Should UnpythonicGetterSetterViolation inherit from ASTViolation or TokenizeViolation? Related to issue #3.

All current OOP violations are ASTViolation based.


Why does decision node holds 16 routing probabilities when there are 15 split nodes in a tree which depth is 4?

" w_d_ensemble.append(init_prob_weights([625, N_LEAF], -1, 1))" in your code, why not " w_d_ensemble.append(init_prob_weights([625, N_LEAF-1], -1, 1))" for 15 decision nodes?

Making this change gave me the following traceback (Mac 10.14.1, python 3.6.2):
Roachs-MacBook-Air:DNDF roach$ python3 model.py
.....
2018-11-21 21:22:56.537935: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,1] = 3847 is not in [0, 3840)
2018-11-21 21:22:56.537931: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,1] = 3847 is not in [0, 3840)
2018-11-21 21:22:56.537927: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,2] = 3843 is not in [0, 3840)
2018-11-21 21:22:56.537935: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,1] = 3847 is not in [0, 3840)
2018-11-21 21:22:56.538731: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,4] = 3841 is not in [0, 3840)
2018-11-21 21:22:56.538734: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,2] = 3843 is not in [0, 3840)
2018-11-21 21:22:56.538823: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,2] = 3843 is not in [0, 3840)
2018-11-21 21:22:56.538879: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,8] = 3840 is not in [0, 3840)
2018-11-21 21:22:56.538878: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,4] = 3841 is not in [0, 3840)
2018-11-21 21:22:56.538934: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,4] = 3841 is not in [0, 3840)
2018-11-21 21:22:56.538999: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,1] = 3847 is not in [0, 3840)
2018-11-21 21:22:56.539004: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,8] = 3840 is not in [0, 3840)
2018-11-21 21:22:56.539088: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,8] = 3840 is not in [0, 3840)
2018-11-21 21:22:56.539176: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,8] = 3840 is not in [0, 3840)
2018-11-21 21:22:56.539565: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,2] = 3843 is not in [0, 3840)
2018-11-21 21:22:56.539185: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,4] = 3841 is not in [0, 3840)
2018-11-21 21:22:56.544609: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,1] = 3847 is not in [0, 3840)
2018-11-21 21:22:56.544609: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,8] = 3840 is not in [0, 3840)
2018-11-21 21:22:56.544623: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,4] = 3841 is not in [0, 3840)
2018-11-21 21:22:56.544623: W tensorflow/core/framework/op_kernel.cc:1290] CtxFailure at gather_op.cc:117: Invalid argument: indices[112,2] = 3843 is not in [0, 3840)
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1322, in _do_call
return fn(*args)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1307, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1409, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.InvalidArgumentError: indices[112,1] = 3847 is not in [0, 3840)
[[Node: GatherV2_18 = GatherV2[Taxis=DT_INT32, Tindices=DT_INT32, Tparams=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:CPU:0"](Reshape_4, Add_18, gradients/concat_6/axis)]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "model.py", line 224, in
p_keep_conv: 0.8, p_keep_hidden: 0.5})
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 900, in run
run_metadata_ptr)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1135, in _run
feed_dict_tensor, options, run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1316, in _do_run
run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1335, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: indices[112,1] = 3847 is not in [0, 3840)
[[Node: GatherV2_18 = GatherV2[Taxis=DT_INT32, Tindices=DT_INT32, Tparams=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:CPU:0"](Reshape_4, Add_18, gradients/concat_6/axis)]]
Caused by op 'GatherV2_18', defined at:
File "model.py", line 187, in
tf.add(batch_indices, batch_complement_indices)))
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/ops/array_ops.py", line 2666, in gather
return gen_array_ops.gather_v2(params, indices, axis, name=name)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/ops/gen_array_ops.py", line 3141, in gather_v2
"GatherV2", params=params, indices=indices, axis=axis, name=name)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3417, in create_op
op_def=op_def)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1743, in init
self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access
InvalidArgumentError (see above for traceback): indices[112,1] = 3847 is not in [0, 3840)
[[Node: GatherV2_18 = GatherV2[Taxis=DT_INT32, Tindices=DT_INT32, Tparams=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:CPU:0"](Reshape_4, Add_18, gradients/concat_6/axis)]]


Ensure libbcc cannot be used by a non-privileged user

What does this PR do?
Ensure libbcc cannot be used by a non-privileged user
Motivation
libbcc is used to compile and load eBPF programs.
It will be used by system-probe with #4619.
This change ensures that an attacker who hasn’t gain root privileges cannot use it.
Additional Notes

Who owns these files? If it's ddagentuser we might want to remove rwx to the owner user also (root will be able to use them anyway). If it's owned by root (and probably they should?), then we are good with this change.

I checked inside a old docker image that I built before the libbcc inclusion was commented out and the files were properly owned by root ultimately:
$ docker run -ti --rm datadog/agent-dev:lenaic-add-tcp-queue-length-tracer-py3 /bin/bash
root@977a93b1410e:/# ls -l /opt/datadog-agent/embedded/lib/libbcc*
lrwxrwxrwx 1 root root       11 Jan 31 06:46 /opt/datadog-agent/embedded/lib/libbcc.so -> libbcc.so.0
lrwxrwxrwx 1 root root       22 Jan 31 06:46 /opt/datadog-agent/embedded/lib/libbcc.so.0 -> libbcc.so.128-NOTFOUND
-rw-r--r-- 1 root root 55448096 Jan 31 06:46 /opt/datadog-agent/embedded/lib/libbcc.so.128-NOTFOUND
lrwxrwxrwx 1 root root       15 Jan 31 06:46 /opt/datadog-agent/embedded/lib/libbcc_bpf.so -> libbcc_bpf.so.0
lrwxrwxrwx 1 root root       26 Jan 31 06:46 /opt/datadog-agent/embedded/lib/libbcc_bpf.so.0 -> libbcc_bpf.so.128-NOTFOUND
-rw-r--r-- 1 root root   194192 Jan 31 06:46 /opt/datadog-agent/embedded/lib/libbcc_bpf.so.128-NOTFOUND

Indeed, I agree with you that binaries and libraries must absolutely not be owned by the runtime user. Otherwise, whoever manages to compromise a process can then persist its access by altering the binary files.


Upgrade electron dependency to ^2.0.0 to avoid the following security issues:

Add repository field to package.json

Upgrade electron dependency to ^2.0.0 to avoid the following security issues:
critical        Remote Code Execution
Package         electron
More info       https://nodesecurity.io/advisories/563
high            Chromium Remote Code Execution
Package         electron
More info       https://nodesecurity.io/advisories/539
high            Code Execution by Re-enabling Node.js integration
Package         electron
More info       https://nodesecurity.io/advisories/574

I really thank you for the contribution! Quite impressive 👍
I'll look at this PR!
by the way, do you have a mind to join Hain project as a collaborator? @dannya

Thanks @appetizermonster, I'd like to join as a collaborator, I have some more PR's I'll be raising very shortly!

Okay, good!
I'll add you as a collaborator very soon.
and PR looks good (for Windows), but it has some problems in macOS
so I'll merge it and make some fixes soon
Thank you

@dannya I've just added strict prettier and eslint options, so you need to check linting errors before push the commits (by using npm test or npm run lint).
and you can fix formatting errors easily by eslint's autofix.


Amplify push is failing when testing the new feature/@key branch

I followed the steps specified in testing-custom-indexes.md, did amplify add api, got an error here:
What attributes are required for signing up? (Press <space> to select, <a> to toggle all, <i> to invert selection)Email Error: ENOENT: no such file or directory, open '/home/stefan/Coding/Tests/vido/testing-key/amplify/backend/auth/testingkeya59f6fdb/parameters.json'
Continued with amplify push and got:
CREATE_FAILED               apitestingAPI                         AWS::CloudFormation::Stack Thu May 23 2019 11:43:51 GMT+0200 (EET) Parameters: [S3DeploymentBucket, S3DeploymentRootKey] must have values

Hmm I am not seeing this locally but I have just rebased the repo off of master and fixed a few things that were upsetting circle CI. Can you pull and try again?

I've tested again and it seems to be working now, thanks.

Great!


etcd related dashboards in Plutono are not populated with metrics as expected

How to categorize this issue?
/area monitoring
/area ops-productivity
/kind bug
What happened:
The etcd dashboards for shoots are not being populated with data in Plutono.
What you expected to happen:
The dashboards should be populated with data so operators can use the dashboards for diagnosis.
How to reproduce it (as minimally and precisely as possible):

Checkout Gardener at 210b15aa5018d06959416ac3e0b606d0ba95f3d4 and deploy a local setup.
Create a shoot and observe the dashboards and the metrics.
Checkout Gardener at 9f3b25415f3cd5ba9f44d5d0cf6c6b752af6f37f and redeploy. This is the commit in #9848.
The metrics would stop being populated in the dashboard once the upgrade finishes, and the shoot is reconciled.

Anything else we need to know?:
I could see that the metrics exposed by the Etcd are all being relabelled by the ServiceMonitors that are newly deployed due to the changes in #9848; and the role label for these metrics is relabelled to the value of the instance label of the client service for the etcd, which would be etcd-main and etcd-events.
This is a change from what previously was the label for role, which were main and events respectively - and this is what the etcd-backup-dashboard.json expects.
The PR brought a change to the values role takes and this was not reflected in the etcd-backup-dashboard.json.
Environment:

Gardener version: All versions which include 9f3b25415f3cd5ba9f44d5d0cf6c6b752af6f37f

Plutono Dashboard before 9848

Running a Prometheus Query on Plutono before 9848

Service Monitors, Services before 9848

Plutono Dashboard after 9848

Running the same Prometheus Query on Plutono after 9848

Service Monitors, Services after 9848

/close since resolved by https://github.com/gardener/gardener/pull/10243


feat: use object instead of array for sending headers

Update sendResponse to use an object to add support for libraries such as express while maintaining node:http and node:https compatibility.

Thanks, @jacob-ebey !


Azure EventHub - EventData.body_as_json returns a dict

EventData.body_as_json in Azure EventHub code currently returns a dictionary. This is not expected based on the name, as what is expected (in Python) is a string representing a json object.
Since there is already body_as_str method, I would suggest that this method gets renamed as body_as_dict.
In the interim, it could be kept for backwards compatibility, but it is not intuitive for new users of this module.
In Python, JSON != dict, at least not as a type. That is why we use json.loads to move JSON into a dict.

Thanks for the feedback @ivandigiusto . We will investigate and get back to you asap.

Hi @ivandigiusto, thank you for the issue and sorry for taking so long to get back to you on this. You are right that there is some confusion, and we can improve things by enhancing the description of the method & adding a code snippet showing how to get the actual string, while leaving the method intact given that it has been in GA for a number of years now.
Defining json object as a type in python has quite the interesting read here so a dict[str, any] can be a json type just as a str.
Thank you 🙂


feat: add vela ql doc

#3519
This pr is to supplement the tutorial on using velaql in the command line, which involves the introduction to the use of velaql, the introduction to the use of vela ql commands, etc.
language uead： EN and CN
now, undone

thanks for your contributions, it's already in the docs! closing.


EmbedShortcodeProvider cache key is too broad - cannot embed the same video more than once

Affected Version
4.8.0
Description
EmbedShortcodeProvider caches rendered shortcode embed html based only on the embed URL - arguments are ignored. This means if you embed a video on one page, then embed the same video on a different page (or the same page) with different parameters (e.g. add a caption, or change alignment), both pages will display identical markup. Whichever is rendered first will be cached and returned for both embeds.
So if you had a caption on one embed but not the other for example, you would end up with either a caption on both videos, or a caption on neither of them.
Steps to Reproduce
Embed a video on one page, then embed the same video on a different page with different parameters (e.g. add a caption, or change alignment).

Thanks Jono, will close this one as a duplicate of https://github.com/silverstripe/silverstripe-admin/issues/1199. Great timing, a pull request to fix it has just arrived 😄 https://github.com/silverstripe/silverstripe-framework/pull/9998

That is great timing! 😄 Thanks for catching the dupe.


Fixed npm2 compatibility (#131)

#131

@sapegin could you make an npm release with this fix?

Done :-)

thanks!


myvideo.de download broken

Hi,
it seems that the myvideo.de download function is broken.
# youtube-dl http://www.myvideo.de/watch/8328930/Nickelback_When_We_Stand_Together_Official_Video
[myvideo] 8328930: Downloading webpage
[myvideo] 8328930: Extracting information
ERROR: Unable to download video

# youtube-dl http://www.myvideo.de/watch/8357965/Maria_Mena_Homeless
[myvideo] 8357965: Downloading webpage
[myvideo] 8357965: Extracting information
ERROR: Unable to download video

I can reproduce this and will look into it. As always, patches are welcome.

Hi,
looks like myvideo.de is using rtmp streams for some of their videos (mostly music-videos and complete movies).
Do you plan to add rtmp support for the myvideo.de module?

This video is simply "not available in my country" on the web page.
http://www.myvideo.de/watch/8418541/Deichkind_Leider_geil works.

You may also try this method to download video from myvideo at http://www.allavsoft.com/how-to/myvideo-downloader.html


Mat-Checkboxes in CDK-Table rendering differently in various browsers

Bug, feature request, or proposal
Think this might be a bug
What is the current behavior?
Have a cdk-table with mat-checkboxes as a select colum, that is rendering differently in the various browsers (see linked StackBlitz).
EDGE and IE are ok when using this workaround
.mat-checkbox{
display: inline-flex;
}

In Firefox 61.0.1 (64-Bit) the checkbox is missaligned vertically (i.e. a bit lower on line that it should be).

In Chrome Version 68.0.3440.84 it is missaligned and also displaces verticaly when clicked. The latter seems to be associated with this css
cdk-header-cell, cdk-cell {
flex: 1;
overflow: hidden;
word-wrap: break-word;
}
This workaround, which I found here does not solve the issue in chrome, altought it does solve a slighter displacement issue in EDGE.
.mat-checkbox{
display: inline-flex;
}

What are the steps to reproduce?
https://stackblitz.com/edit/angular-8g96hx?file=app%2Fcdk-table-basic-example.css
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
material 6.4.2
angular 6.1.1

Seems putting the checkboxes in a div (class = sel) and using this css sort of makes it a bit better.
.sel{
display: flex;
justify-content: center;
}
.mat-checkbox{
display: inline-flex;
margin: 1px;
}

I've noticed strange step of bottom line on mat-table doc page.

Chrome devtools show that td with checkbox is a bit higher than without one:

Seems this is a CSS issue that can be resolved. I dont foresee us being able to make any changes to the cells to accommodate this case.
W.R.T. to the checkbox causing weird height issues, Im not currently seeing that but if it remains an issue on your side, please open an issue so we can look into it


DEVOPS-728 Add autobuild on "publish release"

Updates :octocat: Actions to use the following process:
Pt 1: Feature > Develop

Create feature branch for new release.
Once changes are complete, create a PR to merge feature > develop.
GHA will automatically build an image called sample_service-develop with the tag of :pr-#.
If all checks pass, test image in ci environment.
Once confirmed in ci, merge the PR.
After merge,  the image will be tagged as sample_service-develop:latest.

Pt 2: Develop > Master

Once ready to start a release, submit a PR from develop > master.
GHA will automatically build an image called sample_service with the tag of :pr-#.
Optionally test the sample_service:pr-# image in ci.
If all checks pass, merge the PR to master.

Pt 3: Release

Create a new Release and enter a new semantic version.
Optionally, use the "Auto-generate release notes" feature to pull in all related PRs notes etc.
Publish release.
An image is automatically built, called sample_service with a both the semantic version tag, as well as latest.
Test this image in next
If everything looks good, deploy to production.
...
Profit!

Did you create the develop branch? The developers are not using one and don't plan to use one.
Does releasing images this way mean that you can release arbitrary releases and they will be tagged with those names, instead of semantic versioning? I think we should only be building images on tags from master using semantic versioning. Also it seems to me that you can release "1.2.3" but then in the tag put "1.0.4" and the docker image won't match up with the tag in github. So should the trigger be on the release or the tag?

Did you create the develop branch? The developers are not using one and don't plan to use one.

Yes I created the branch, as this is a best practice we're trying to promote across the org.
More importantly, it's what makes it easy to have a ghcr.io/kbase/sample_service-develop:latest that can be used for testing in CI before any changes to master.
This branch is also critical to the proposed full continuous delivery to CI we'd talked earlier today.

Does releasing images this way mean that you can release arbitrary releases and they will be tagged with those names, instead of semantic versioning? I think we should only be building images on tags from master using semantic versioning.

Nope. The SemVer checks I built out today fix this, and are now in this PR.

Also it seems to me that you can release "1.2.3" but then in the tag put "1.0.4" and the docker image won't match up with the tag in github. So should the trigger be on the release or the tag?

After going over the release process today, I think we confirmed this isn't an issue, given the way release is tied to a specific tag.
Note: For all automation to work without any loopholes/edge cases, we'll want to:

Set develop as the default branch.
Add branch restrictions to both develop & master.
Ensure the following options are enabled in the branch rules:


Fix GeoDistance serialization

Fixes issue where unintended value separator is added. Example:
"sort":[{"_geo_distance":{,"some.coordinate":[{"lat":1.0,"lon":1.0}]
The "," is incorrectly added causing deserialization issues on the server.

Thanks for the PR, @rmja. Would you be able to sign the Contributor License Agreement so that we may pull the change in?

It should be signed now

@rmja I'm going to make the changes and merge this in for the 7.4.0 release, if that's OK?

@russcam absolutely 😀

ported to 7.x


Trim headers fixes #24

Hey,
this PR adds trimming headers. There should be probably be an option to enable/disable it, but I'm not sure what the default should be
Best,
Finn

+1

shouldn't it then trim values as well for consistency?

It's expensive to do that, right? it's hard to know if its good to trim the values, whereas for headers its mostly desired

mapHeaders can do that:
csv({mapHeaders: function (header) return header.trim() )

Going to pass on this PR, citing the use of mapHeaders. @finnp thank you for all of your work on this PR.