[BUG] Provisioning log config map is empty

Rancher Server Setup

Rancher version: v2.7-head a352c87
Installation option (Docker install/Helm Chart): Helm

Information about the Cluster

Kubernetes version: v1.24.8
Cluster Type (Local/Downstream): local

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

If custom, define the set of permissions: admin

Describe the bug

When provisioning an rke2 cluster, the provisioning log was empty but the rancher logs were there. The provisioning log for configmap is empty.
To Reproduce

Provision Rancher with 1.24.8 k8s version
Create rke2 aws node driver cluster
Verify provisioning log is empty
Check provisioning log config map

Result
provisioning log config map is empty
Expected Result

Config map should not be empty and show data to show rancher logs

By editing the configmap, the expected data fields (last and `log) were added via the controller reconciling the configmap. This is due to a race condition within the controller exiting reconciliation prematurely and never re-enqueueing itself. @snasovich Is this something we want to get in the upcoming 2.6 and 2.7 releases?

/backport v2.6.11

Test Environment:
Rancher version: v2.7-head
Rancher cluster type: HA
Docker version: 20.10
Downstream cluster type: rke2

Testing:
Tested this issue with the following steps:

Provision Rancher with 1.24.8 k8s version
Create rke2 aws node driver cluster
Check provisioning log config map

Result
Provisioning log config map is no longer empty and provisioning log now shows information while cluster is provisioning.


Mitogen broken by distro 1.7.0

From https://bugs.debian.org/1006330:
Something like issue #590 (see: #610, #622) seems to be back with distro 1.7.0. Presumably because of the change of module layout in https://github.com/python-distro/distro/pull/315
With the Debian packaged ansible 2.10.8, mitogen 0.3.1, on Python 3.9.8. Upgrading from distro 1.6.0 to 1.7.0 on the target broke mitogen:
[mux  685121] 14:38:50.354759 D mitogen: PkgutilMethod(): loading 'ansible.module_utils.distro' using <_frozen_importlib_external.SourceFileLoader object at 0x7fa6329f7700> failed: loader for distro cannot handle ansible.module_utils.distro
[mux  685121] 14:38:50.354915 D mitogen: _get_module_via_sys_modules('ansible.module_utils.distro') -> <module 'distro' from '/usr/lib/python3/dist-packages/distro/__init__.py'>
[mux  685121] 14:38:50.355021 D mitogen: sys.modules['ansible.module_utils.distro'].__name__ is incorrect, assuming this is a hacky module alias and ignoring it. Got 'distro', module object: <module 'distro' from '/usr/lib/python3/dist-packages/distro/__init__.py'>
[mux  685121] 14:38:50.355142 D mitogen: ParentEnumerationMethod(): 'ansible.module_utils.distro' is PKG_DIRECTORY: '/usr/lib/python3/dist-packages/ansible/module_utils/distro/__init__.py'
...
[mux  685121] 14:38:51.209954 D mitogen: SysModulesMethod(): sys.modules['ansible.module_utils.distro._distro'] absent or not a regular module
[mux  685121] 14:38:51.210217 D mitogen: ParentEnumerationMethod(): imp.find_module('_distro', [['/usr/lib/python3/dist-packages/distro']]) -> No module named '_distro'
[mux  685121] 14:38:51.210346 D mitogen: get_module_source('ansible.module_utils.distro._distro'): cannot find source
[mux  685121] 14:38:51.210449 D mitogen.responder: could not find source for 'ansible.module_utils.distro._distro'
[mux  685121] 14:38:51.210566 D mitogen.responder: sending ansible.module_utils.distro._distro (0.05 KiB) to ssh.proxy.glacom.eu
[mux  685121] 14:38:51.224181 D mitogen.importer.[ssh.proxy.glacom.eu]: received ansible.module_utils.distro._distro
...
[mux  685121] 14:38:51.232206 D mitogen: MitogenProtocol(unix_client.685155): disconnecting
The full traceback is:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/ansible/executor/task_executor.py", line 158, in run
    res = self._execute()
  File "/usr/lib/python3/dist-packages/ansible/executor/task_executor.py", line 663, in _execute
    result = self._handler.run(task_vars=variables)
  File "/usr/lib/python3/dist-packages/ansible_mitogen/mixins.py", line 144, in run
    return super(ActionModuleMixin, self).run(tmp, task_vars)
  File "/usr/lib/python3/dist-packages/ansible/plugins/action/normal.py", line 47, in run
    result = merge_hash(result, self._execute_module(task_vars=task_vars, wrap_async=wrap_async))
  File "/usr/lib/python3/dist-packages/ansible_mitogen/mixins.py", line 374, in _execute_module
    self._set_temp_file_args(module_args, wrap_async)
  File "/usr/lib/python3/dist-packages/ansible_mitogen/mixins.py", line 353, in _set_temp_file_args
    self._connection.get_good_temp_dir()
  File "/usr/lib/python3/dist-packages/ansible_mitogen/connection.py", line 817, in get_good_temp_dir
    self._connect()
  File "/usr/lib/python3/dist-packages/ansible_mitogen/connection.py", line 839, in _connect
    self._connect_stack(stack)
  File "/usr/lib/python3/dist-packages/ansible_mitogen/connection.py", line 786, in _connect_stack
    dct = mitogen.service.call(
  File "/usr/lib/python3/dist-packages/mitogen/service.py", line 126, in call
    return call_context.call_service(service_name, method_name, **kwargs)
  File "/usr/lib/python3/dist-packages/mitogen/core.py", line 2284, in call_service
    return recv.get().unpickle()
  File "/usr/lib/python3/dist-packages/mitogen/core.py", line 963, in unpickle
    raise obj
mitogen.core.CallError: builtins.ModuleNotFoundError: The Mitogen master process was unable to serve 'ansible.module_utils.distro._distro'. It may be a native Python extension, or it may be missing entirely. Check the importer debug logs on the master for more information.
  File "<stdin>", line 3669, in _dispatch_one
  File "<stdin>", line 3656, in _parse_request
  File "<stdin>", line 668, in import_module
  File "<stdin>", line 1516, in load_module
  File "master:/usr/lib/python3/dist-packages/ansible_mitogen/target.py", line 85, in <module>
    import ansible_mitogen.runner
  File "<stdin>", line 1516, in load_module
  File "master:/usr/lib/python3/dist-packages/ansible_mitogen/runner.py", line 85, in <module>
    import ansible.module_utils.basic
  File "<stdin>", line 1516, in load_module
  File "master:/usr/lib/python3/dist-packages/ansible/module_utils/basic.py", line 152, in <module>
    from ansible.module_utils.common.sys_info import (
  File "<stdin>", line 1516, in load_module
  File "master:/usr/lib/python3/dist-packages/ansible/module_utils/common/sys_info.py", line 10, in <module>
    from ansible.module_utils import distro
  File "<stdin>", line 1516, in load_module
  File "master:/usr/lib/python3/dist-packages/ansible/module_utils/distro/__init__.py", line 45, in <module>
    from ansible.module_utils.distro import _distro as distro
  File "<stdin>", line 1491, in load_module

arch linux, ansible v2.12.2, python v3.10.2 - same issue

With the Debian packaged ansible 2.10.8, mitogen 0.3.1, on Python 3.9.8. Upgrading from distro 1.6.0 to 1.7.0 on the target broke mitogen

While that's how the bug was described to me, from my own experimentation, I'd describe it as: Upgrading distro from 1.6.0 to 1.7.0 on the controller broke the use-case when the target doesn't have distro installed.

Based on @stefanor's branch I think I've prototyped a more general fix https://github.com/willmerae/mitogen/commit/754a94ba74a063ce4f86c023e280e4d32c04502a. Would anyone be willing to try it? I'll create a PR once I've teased out some refactoring from the messy investigation branch https://github.com/willmerae/mitogen/tree/issue-906.

Oh, yeah, that definitely looks cleaner.


Writing PLTE chunk for indexed color files

It appears there's currently no support for writing a PLTE (palette) chunk to a new PNG image file.
e.g., the following code will write out a new image successfully:
    let file = File::create(PATH).unwrap();
    let ref mut w = BufWriter::new(file);

    let mut encoder = png::Encoder::new(w, WIDTH, HEIGHT);
    encoder.set(png::ColorType::Indexed).set(png::BitDepth::Eight);
    // Set color palette?
    let mut writer = encoder.write_header().unwrap();

    writer.write_image_data(&IMAGE_DATA).unwrap();

... but the resulting file is unusable because there is no palette to map the image data to colors. Opening the new file in any other program will fail because the PLTE chunk is missing.
Ideally, there should be a way to provide a palette to the encoder, and attempting to write an indexed color file without first setting a palette should fail.

Looks like PLTE encoding is in, but tRNS is still needed.

It would be great if this library also checked that the palette has the expected size. I happen to get the broken PNG saved when accidentally providing a size that is not expected - https://github.com/image-rs/image-png/issues/97#issuecomment-665429159


Balance different between balances tab and send screen if tokens locked

Caught this today while making a transfer in v2.12.0 from an account that's pooling STX.
On the balances screen, I see my unlocked balance:

On the Send screen, I see the total balance:

The send Max button does nothing when I click on it, but the real kicker is that after I enter 5 STX into the field, I get an error after clicking preview:

I tried this by following the same process without clicking max, switching accounts, and after logging out and back in with my secret key.
One thing I noticed, the negative balance might point to a math issue? The available balance shown is similar to (total - available) - available

error -65.609031 STX
available: 134.723 STX
total: 335.054851 STX

Nothing to report in the console.

Test passed,wasnt able to reproduce the issue from a pooling address

@whoabuddy are you still seeing this problem?

@whoabuddy are you still seeing this problem?

The PR fix for this has not been merged yet.


Cannot specify multiple to/cc/bcc email addresses

Is there a way to send to multiple email addresses? My company is currently sending about 50k email messages/month through this Node and we would like to be able to specify multiple email addresses on the to/cc or bcc line.

I have tried

msg.to = "user1<EMAIL_ADDRESS>// comma separated
and
msg.to = "user1<EMAIL_ADDRESS>// semi-colon separated

@seandafts Thank you for your feedback. From the commit for v0.1.1, https://github.com/zuhito/node-red-contrib-sendgrid/commit/2117db359621e55fb923a78b5a8b7e6f7174ab90, multiple addresses in to, cc and bcc are supported. Could you check the new node?


Can we change the host address for human handoff?

Actually, I am looking for a way to have human handoff in this chatbot interface.
Assume, Currently, it is hosting on localhost:5005, but I want it to change to localhost:3000 when a custom action   action_human_handoff is triggered. I am using socket programming.
i want a user human handoff in this rasa-webchat

Hi there, I'm trying the same thing actually. @MatthieuJnon any ideas here?
For now, I am just removing and reloading the script, passing a new URL. But this has as a result for the chat window to restart/reload, as well. Do you know if there's a way to do that without reloading the script/etc?

ping

bump


ExternalSystemException: String index out of range: -115

When I try to run the program on android studio 2.0, it always gives this issue.
Any idesa?

Could you provide me with more details?
Do you mean you are trying to build app using AndroidStudio, it will have an error at the compile time?

It was at compile time. The problem solved with
lintOptions {
checkReleaseBuilds false
}
at gradle
Thanks


cross hangs when building the curl-sys crate

for these targets

mips-unknown-linux-gnu
mips64-unknown-linux-gnuabi64
powerpc64-unknown-linux-gnu

I have no idea why. This doesn't even involve QEMU.
cc @alexcrichton. Any tip on how to debug a build scripts that hangs/blocks? There's no output file so I can't inspect the stdout/stderr of the build script.

By manually placing some panic! calls in the build script, at least I know that the build script hangs when it shells out to sh configure ....

I've found gdb helpful for attaching to live processes or you can also just kill the build script itself and then take a look at the logs to see how far it go

OK, so apparently this a bug in curl-sys build script. cc @alexcrichton
In a nutshell, the configure line I linked before should be:
$ configure --build=$HOST --host=$TARGET --target=TARGET (..)

Source

Explanation:
Right now, curl-sys' build script calls configure like this:
$ configure --host=$HOST --target=TARGET (..)

which causes the configure script to sometimes "probe the environment" like this:
# where conftest.c changes for each "test"
$ $TARGET-gcc conftest.c
$ ./conftest

which is wrong because this is running a binary e.g. for MIPS on e.g. a
x86_64 system and as a result, on most systems, this "test" will always fail.
On those systems, this is not too bad because most tests don't involve calling
conftest .
However, this is particularly bad for this project because I'm cross building
curl-sys on a system that has transparent QEMU emulation enabled so
./conftest is actually being executed and sometimes hangs (possibly due to
QEMU).

If I actually change the build script to call configure like this:
$ configure --build=$HOST --host=$TARGET --target=TARGET (..)

Then configure never calls ./conftest to probe environment (but it still
calls $TARGET-gcc conftest.c). With that change curl-sys cross compiles fine
for mips-unknown-linux-gnu


Autocomplete in registered accessors

At present if you use register_dataset_accessor() or register_dataarray_accessor(), ipython can not autocomplete to function within that accessor. For example:
MCVE Code Sample

import xarray as xr

@xr.register_dataset_accessor('geo')
class GeoAccessor:
    def __init__(self, xarray_obj):
        self._obj = xarray_obj

    @property
    def center(self):
        # return the geographic center point of this dataset
        lon = self._obj.latitude
        lat = self._obj.longitude
        return (float(lon.mean()), float(lat.mean()))

    def plot(self):
        # plot this array's data on a map, e.g., using Cartopy
        pass

Expected Output
It would be good if in ipython when pressing TAB data.geo.c  would autocomplete to data.geo.center().
 I guess it might be worth having a look at jedi and see if this could be easily fixed.

This already works for me in a IPython shell (jedi 0.15.1, ipython 7.9.0):
In [1]: import xarray as xr
   ...: import numpy as np

In [2]: @xr.register_dataset_accessor("geo")
   ...: class GeoAccessor:
   ...:     def __init__(self, xarray_obj):
   ...:         self._obj = xarray_obj
   ...:
   ...:     @property
   ...:     def center(self):
   ...:         # return the geographic center point of this dataset
   ...:         lon = self._obj.latitude
   ...:         lat = self._obj.longitude
   ...:         return (float(lon.mean()), float(lat.mean()))
   ...:
   ...:     def plot(self):
   ...:         # plot this array's data on a map, e.g., using Cartopy
   ...:         pass
   ...:

In [3]: ds = xr.Dataset(
   ...:     data_vars={"a": (("latitude", "longitude"), np.linspace(0, 1, 5 * 10).reshape(5, 10))},
   ...:     coords={"latitude": np.arange(5), "longitude": np.arange(10)},
   ...: )

In [4]: # ds.geo.c<TAB>:
   ...: ds.geo.center
Out[4]: (2.0, 4.5)

Am I missing something?

I can reproduce your first code perfect fine in ipython, with autocomplete. However, we're defining an accessor in ipython. It seems if an accessor is used in a module and that module imported to ipython the autocomplete doesn't work. It's like ipython can't "see" the functions in the accessor's class until runtime.

that works for me, too. I moved the accessor code into a file, then imported it:
In [1]: import xarray as xr
   ...: import numpy as np
   ...: import custom_accessor

In [2]: ds = xr.Dataset(
   ...:     {"a": (("latitude", "longitude"), np.linspace(0, 1, 5 * 10).reshape(5, 10))},
   ...:     coords={"latitude": np.arange(5), "longitude": np.arange(10)},
   ...: )

In [3]: # ds.geo.c<TAB>
   ...: ds.geo.center
Out[3]: (2.0, 4.5)

It also works with the builtin str, dt and plot DataArray accessors (just not if I'm trying to access the DataArrays from a Dataset as described above).

You are right. The autocomplete does work. I had a problem in my script.

Autocomplete indeed works in ipython, but it doesn't seem to work for accessors in my emacs configuration (lsp-mode / lsp-python-ms / python-language-server). I haven't checked in VSCode / LSP. I'll investigate this later, it's likely an issue external to xarray.


fix: TypeScript declaration for lib/core/s3; add retry option

Brief description of the changes

Adds TypeScript declaration for lib/core/s3.
Adds retry option to FineUploaderBasic.

Resolves #1988.
Extra package.json files have been added to commonJs to associate types with nested modules, this follows the pattern used by date-fns.
What browsers and operating systems have you tested these changes on?
n/a
Have you written unit tests? If not, explain why.
fine-uploader.test.ts has been extended.

@SinghSukhdeep can you take a peek at this?

@rnicholus Sure I'll take a look

We should also update the azure module similarly as that is also missing the core module declaration

@bradleyayers Just wanted to check your thoughts on possibility of 'fine-uploader/lib/all' in TS. This is missing and I can't think of a way to have this since we don't have the qq namespace here

@SinghSukhdeep I've pushed up a couple of commits attempting to add lib/all and lib/core/all. To be honest I'm not exactly sure what exists in those distributions, so if you can double check I got it right that would be great. It's times like these I hope having an ES module distribution would remove the need for these separate distributions. I'd really like to have the whole code base migrated to TS to make these things easier.

@SinghSukhdeep let me know if you're aware of any other issues, else I think this is good to go.

Hey sorry I was away for couple days. I think it all looks great except for one line I mentioned above

@rnicholus this should be good to go.

Everything looks fine here, but I'm not sure I understand the documentation changes. You shouldn't have to explicitly reference an index.js file when importing a module, unless I'm missing something. If that is the case here, then this would be a very significant breaking change, and we'll have to figure out how to update the code to prevent that.

Fair call, this might be better suited for release/6.0.0?

Is it really necessary to reference index.js directly? I’ve never had to do that myself.

So, does this there are no breaking changes then?

So, does this there are no breaking changes then?

"Breaking change" is a subjective term, so I think this boils down to being a judgment call. I'm happy to call this not a breaking change, even though if people are relying on exact file locations for custom build configurations they'll need to make some changes when upgrading. If you'd rather err on the side of calling that a breaking change, then I can target this to release/6.0.0.
Without an unambiguous definition for breaking change this decision just needs to be a judgement call made by a maintainer.

If any user needs to adjust their code to upgrade, then the version contains breaking changes, and that must always be avoided in minor or patch releases, per semver spec. I’ll take a closer look at these changes soon to better determine if the documentation changes are necessary and if any breaking changes are present or necessary.

Just to weigh in, we only need to specify file extensions for module loaders like SystemJS (not sure about Webpack) and module bundlers like Rollup (again not sure about Webpack).
As far as normal import export is concerned, having or specifying index.js in the docs doesn't matter.
So only a slight modification is required in the bundler/loader configs.
And in our package.json
"main": "lib/traditional.js" would also needs to be changed to "main": "lib/traditional/index.js"

@SinghSukhdeep does pkg.main support having the file extension omitted?

I think i'm ok with this provided the documentation changes are reverted. But I do want to do a bit of manual testing myself first. Thanks both of you for all of your hard work.

Reverting the documentation changes would also require reverting the code changes that move lib/traditional.js to lib/traditional/index.js, else the docs won't match up with the file structure.

I’m personally fine with just leaving the docs as-is (before any changes). It’s common to use the index.js pattern (I’m using it in several closed and open source projects) and I’ve never seen docs explicitly reference the index file.

I’m fairly certain everything will just work without making any code changes in webpack environments. I’ll have to confirm though. But if indeed this does break for users of rollup, then without reverting the breaking code changes, this will have to sit and wait to go out with 6.0

To ensure we don't break backwards compatibility, can't we just keep the traditional.js, s3.js, etc files?

Yeah I considered that, but I wasn't sure if the module resolution spec includes whether to try directory or file first when resolving. It seemed like a risky approach that could be broken in the future. It's probably worth checking though.

Well, if both /traditional/traditional.js and traditional/index.js point to the same location, there shouldn't be an issue, unless I'm missing something. We could eliminate traditional.js in 6.0, but this allows us to ensure there are no breaks in 5.x.

Hi @bradleyayers are you still pursuing this PR. We did a lot of work on this and it would be great if we could merge this.

@SinghSukhdeep I'm not actively working on it, but I am still using my FineUploader fork in production (it includes this change + using native promises), so I'm still invested in seeing this succeed.

Awesome!
I will look into this again and see what is missing and hopefully we can get this through


Compatibility with Symfony 2.8 ?

Hi,
thanks for this package, it work well.
Should it works the same on 2.8 ?
Because I've change to 2.8 the Symfony version on composer.json, but get some error on the page.
Thanks

Hi,
I've updated symfony to 2.8.* and it works fine on my end. You can checkout the 2.8 branch https://github.com/ernestre/Symfony-FOSUserBundle-HWIOAuthBundle/tree/symfony_2.8
Tell me if you still have issues. :)

Thanks Ernest.
Work good on 2.8
last question : I cannot  retrieve the email using $response->getEmail()
It’s a null value. I’ve well specified scope : "email » in config.yml.
any idea ?
$username = $response->getUsername();
$email = $response->getEmail();
    $user = $this->userManager->findUserBy(array($this->getProperty($response) => $username));
    //when the user is registrating
    if (null === $user) {
        $service = $response->getResourceOwner()->getName();
        $setter = 'set'.ucfirst($service);
        $setter_id = $setter.'Id';
        $setter_token = $setter.'AccessToken';
        // create new user here
        $user = $this->userManager->createUser();
        $user->$setter_id($username);
        $user->$setter_token($response->getAccessToken());
        //I have set all requested data with the user's username
        //modify here with relevant data
        $user->setUsername($username);
        $user->setEmail($email);
        $user->setPassword($username);
        $user->setEnabled(true);
        $this->userManager->updateUser($user);
        return $user;
    }

Thanks

Le 20 mai 2016 à 23:20, Ernest<EMAIL_ADDRESS>a écrit :
Hi,
I've updated symfony to 2.8.* and it works fine on my end. You can checkout the 2.8 branch https://github.com/ernestre/Symfony-FOSUserBundle-HWIOAuthBundle/tree/symfony_2.8 https://github.com/ernestre/Symfony-FOSUserBundle-HWIOAuthBundle/tree/symfony_2.8
Tell me if you still have issues. :)
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/ernestre/Symfony-FOSUserBundle-HWIOAuthBundle/issues/1#issuecomment-220721272

You need to add
infos_url:           "https://graph.facebook.com/me?fields=<your required fields>"
in the config.yml at the resource_owners.
It should look something like this:
resource_owners:
        facebook:
            type:                facebook
            client_id:           "%facebook_client_id%"
            client_secret:       "%facebook_client_secret%"
            scope:               "email"
            infos_url:           "https://graph.facebook.com/me?fields=id,last_name,first_name,email,picture.type(square)"

Using this url, response object  will have the user's facebook id, name, last name, email and profile picture. To generate your own infos_url, see this for reference : https://developers.facebook.com/tools/explorer/

Perfect thanks

Le 21 mai 2016 à 19:18, Ernest<EMAIL_ADDRESS>a écrit :
scope:               "email"
infos_url:           "https://graph.facebook.com/me?fields=id,last_name,first_name,email,picture.type(square) https://graph.facebook.com/me?fields=id,last_name,first_name,email,picture.type(square)"


[BUG] Can't decompile altered version of Yo-Kai Watch Puni Puni

Information

Apktool Version (apktool -version) - 2.8,1
Operating System (Mac, Linux, Windows) - Windows
APK From? (Playstore, ROM, Other) - Other
Java Version (java --version) - 8 I think

Stacktrace/Logcat
I: Using Apktool 2.8.1 on mod.apk
I: Loading resource table...
W: Skipping unknown chunk data of size 264
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: C:\Users\yehon\AppData\Local\apktool\framework\1.apk
W: Could not decode attr value, using undecoded value instead: ns=, name=, value=0x1000000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1000000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1000000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1000000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=, value=0x00000000
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=, value=0x00000000
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
I: Regular manifest package...
[Fatal Error] :2:52: Attribute name "n1:http:" associated with an element type "manifest" must be followed by the ' = ' character.
I: Decoding file-resources...
I: Decoding values / XMLs...
I: Baksmaling classes.dex...
I: Baksmaling classes2.dex...
I: Baksmaling classes3.dex...
Exception in thread "main" com.android.tools.smali.dexlib2.dexbacked.DexBackedDexFile$NotADexFile: Not a valid dex magic value: 00 00 00 00 00 00 00 00
at com.android.tools.smali.dexlib2.util.DexUtil.verifyDexHeader(DexUtil.java:92)
at com.android.tools.smali.dexlib2.dexbacked.DexBackedDexFile.getVersion(DexBackedDexFile.java:172)
at com.android.tools.smali.dexlib2.dexbacked.DexBackedDexFile.(DexBackedDexFile.java:96)
at com.android.tools.smali.dexlib2.dexbacked.DexBackedDexFile.(DexBackedDexFile.java:199)
at com.android.tools.smali.dexlib2.dexbacked.ZipDexContainer$1.getDexFile(ZipDexContainer.java:180)
at brut.androlib.src.SmaliDecoder.decode(SmaliDecoder.java:89)
at brut.androlib.src.SmaliDecoder.decode(SmaliDecoder.java:37)
at brut.androlib.ApkDecoder.decodeSourcesSmali(ApkDecoder.java:211)
at brut.androlib.ApkDecoder.decode(ApkDecoder.java:121)
at brut.apktool.Main.cmdDecode(Main.java:190)
at brut.apktool.Main.main(Main.java:93)
Steps to Reproduce

apktool d [apk]

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
https://apkadmin.com/w2wvplaekgdf/com.Level5.YWP_4.99.1_signed_mod_YasKashije_platinmods.com.apk.html
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? yes
If you are trying to install a modified apk, did you resign it? yes
Are you using the latest apktool version? yes

Most of these are already fixed in upcoming 2.8.2 release.
➜  3251 apktool d 3251.apk -s -f
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true
I: Using Apktool v2.8.1-53-2274ed39-SNAPSHOT on 3251.apk
I: Loading resource table...
W: Skipping unknown chunk data of size 264
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Loading resource table from file: /home/ibotpeaches/.local/share/apktool/framework/1.apk
I: Decoding AndroidManifest.xml with resources...
W: Could not decode attr value, using undecoded value instead: ns=, name=, value=0x1000000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1000000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1000000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1000000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=, value=0x00000000
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=, value=0x00000000
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x0100000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
W: Could not decode attr value, using undecoded value instead: ns=, name=http://schemas.android.com/apk/res/android, value=0x1200000c
I: Regular manifest package...
[Fatal Error] :2:52: Attribute name "n1:http:" associated with an element type "manifest" must be followed by the ' = ' character.
I: Copying raw classes.dex file...
I: Copying raw classes2.dex file...
I: Copying raw classes3.dex file...
I: Copying raw classes1.dex file...
I: Copying raw assets/audience_network.dex file...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
I: Copying META-INF/services directory
➜  3251

The warnings come from putting the literal value (undecoded numeric) of a failed resource. This is either going to be resolved with some form of unknown resources or properly looking up multiple package applications.

https://github.com/iBotPeaches/Apktool/issues/2514
https://github.com/iBotPeaches/Apktool/issues/2960

So good news that the original issues that plagued this application from decoding are already resolved, so I'm closing this as the other remaining issues are tracked elsewhere.

hi，2.9.0 still get this problem
https://drive.google.com/file/d/1ZPVk3wRgXS__uYE0iAxoaUQQ_yb0dsl0/view?usp=sharing


Exception throw when loading GLB, missing aabb

An exception is thrown when loading certain GLB files (same file loads on any other viewer).  When parsing the gltf it is expecting all meshes to have local aabb but some primitives do not.  I believe this is a valid outcome but the code later on doesn't check for this.
This is an absolute blocker for us, I'm going to need to monkey patch a local copy to get past it so I'd appreciate your time.
in short

getAccessorBoundBox inside of createMesh can return null
later on it is assumed to always exist
condition needs to check for the existence of the aabb when copying over to the localAabb.

Showing the mesh accessor that missing the min/max properties, cause the function to return null

Showing the code later on that checks for the mesh but assumes aabb is always present when it is not

Steps to Reproduce

load a glb via loadFromUrl
instantiate it as a render Entity

Unfortunately I am unable to share the model but its the kind of bug you'd usually expect to be picked up by using tooling such as typescript.  If you're not using it, I recommend it!
Hope this helps and thanks for all your hard work, pc is great

Just looking at the specification here: https://www.khronos.org/registry/glTF/specs/2.0/glTF-2.0.html#accessors-bounds
and it states the min and max for position MUST be defined:
Animation input and vertex position attribute accessors MUST have accessor.min and accessor.max defined. For all other accessors, these properties are optional.

so it seems like the glb file you have is not valid?

Can you check the GLB against the validator please? https://github.khronos.org/glTF-Validator/
If it is valid, would you be open to sending us the model via<EMAIL_ADDRESS>to look at please?

You're correct, the validation is complaining about the missing min/max but the glb has no issue being loaded elsewhere.  The asset isn't something I can share as its private to the company but I can try asking if that helps

It's easy to reproduce by just hacking some small gltf file, which I've done - so there's no need for a repro case.
Fixing is bit more tricky, as we'd need to evaluate aabb (or turn off culling), and positional data can be in various formats, including quantised formats, and so it wont be done immediately unless somebody creates a PR.

Is it not a safe assumption to use the else condition here (where its just setting localAabb to 0,0,0)?

ie.
if (this.mesh?.aabb) {
afterall we know getAccessorBoundingBox can return null so theres no guarantee it exists

Well that would fix the crash, but the aabb that is set is what is used for culling .. so you get mesh culled out when the aabb (point in that case) if off the screen.

Is there a technical reason for the GLB not to have those accessors?

you could try https://gltf.report/
I loaded gltf+bin with missing min and max, exported as binary glb, and min and max was added. Perhaps you can fix your glb files?

If the bbox for positions is missing, just calculate it. 😄

If the bbox for positions is missing, just calculate it. 😄 I mean, all the data's there, right?

For float positional data that should be easy, but less easy for the other data types.

But aren't the positions the only one we need the bbox for?

yes, but those are not always float format. Could be any supported format, including quantised. Could also be interleaved in the buffer.

I didn't actually realise the spec only supports floating point positional data, but the quantised extension changes that https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_mesh_quantization.

We should probably calculate mesh bounds if they are missing and vertex positions are float.

you could try https://gltf.report/
I loaded gltf+bin with missing min and max, exported as binary glb, and min and max was added. Perhaps you can fix your glb files?

thats a nice idea but that would strip out the custom extensions from the file and my usecase depends on users uploading their own glbs so unfortunately we can't depend on the quality of the gltf.


tools/c7n_mailer | Add support for CC in notify block for mailer.

Adding in-line support for a CC block in Custodian notifications, following the below convention:
- type: notify
  template: default.html
  subject: "CC Test"
  from<EMAIL_ADDRESS>  cc:
    -<EMAIL_ADDRESS>  to:
    -<EMAIL_ADDRESS>  transport:
    type: sqs
    queue: foobar-queue

I'm going to close this PR for the time being since a larger refactor will likely be needed to implement this properly.


Time picker improvements

Hey guys. Everything is awesome but time pickers need some improvements:

Really small issue: time picker's minutes label at 5 minutes should be "05" and not "5", it looks weird
Small improvement: There should be a fade animation when switching from hours>minutes or minutes>hours
The selection circle (on the end of the clock's hand) should be bigger (both when selecting a number and when floating between numbers) as it is in the Google apps on the phone.
In the 24h format the inner numbers need to be smaller and in gray as shown in the picture above

An example is not really needed.

Closing for #4796


Olny "Insert" menu can use Single-character_shortcuts

"Single-character_ shortcuts customization (like Pencil or Vector)"
Olny "Insert" menu can use Single-character_shortcuts, I can't set "Z" to "command+Z" or "C" to "control+C".

@ymzuiku: Hello and thanks for the feedback.
Unfortunately, Sketch itself is only allowed to set single-character shortcuts for specific items under insert menu. That's why Keys can only customize these shortcuts.
Just added this case to FAQ.
Thanks again.


Add Italian translation

After @Magicianred comment on #12 would be great to have an Italian translation of the README.md and for the license texts.
The changes that would be needed are:

[ ] Add a new it folder containing a README.md file which should be a translation from the English README.md.
[ ] Add the Italian version of the license texts.
[ ] Add a badge on the main README.md pointing to the Italian translation folder.
[ ] Add a badge on it/README.md pointing to the main README.md (see the other translations).

You don't need to translate the licenses texts, they can be downloaded from Creative Commons website. The last time I checked, only the English version of the license texts could be downloaded as a .txt file, so we used to have to reformat the HTML files as .txt files. After https://github.com/creativecommons/cc-licenses/pull/56 has been merged, we should be able to download the txt files from CC, but I don't know if that code has been deployed yet. I'll ask and comment here if I hear some news.

Great :)


feat(block-producer): batch builder

This PR implements a batch builder for the block-producer rework.
The new implementation largely follows the existing one, with the exception of different transaction and input notes types.
This PR also adds state tracking. The mempool implementation should now largely be complete but will require another pass. I'm planning on doing this pass as part of writing the test suite.
Witnessed input notes
A new input notes structure is added that differentiates between unauthenticated and witnessed notes. Witnessed notes are unauthenticated notes which have been upgrade by attaching an inclusion proof ("witness") to them.
Unauthenticated notes can be upgraded any time we reach out to the store for inclusion proofs. In this PR this is done with the transaction inputs just prior to submitting the transaction to the mempool. In the future this would also occur if the batch builder requires inputs from the store, and finally in the block builder after which there should be zero unauthenticated notes - all should be proven/witnessed.
VerifiedTransaction
Effectively equivalent to the usual ProvenTransaction except using the new input notes.
Batches
I've added a builder for TransactionBatch which I think has cleaned things up nicely.
Originally I had a completely new type ProvenBatch but I now think this isn't necessary. There is some awkwardness and extra mappings/recollections that shouldn't be necessary but we can clean those up after the rework.
Block
I've simply re-used the existing default block builder.

I think with hindsight I could/should have split this work into at least two separate ideas.

Make input note / transaction type changes either in miden-base or as new types here. Introduce them to the existing block-producer. This could be merged into next without much fear.
Create mempool.

We could still attempt doing it the above way but it will probably just take longer.

One issue that @polydez has made me aware of is that notes must be ordered by transaction order. See here.
I have some refactoring to do to support this properly.

One issue that @polydez has made me aware of is that notes must be ordered by transaction order. See here.

Yes, this is how I'm currently thinking about it. But one thing we should do to confirm this is sketch out batch kernel - or at least what we think it'll take as public inputs and what public outputs it'll produce. For example:

Public inputs could be a commitment to a list of transaction IDs (+ some additional data needed to verify transaction proofs) for the transactions included in the batch. All detailed transaction could be provided via the advice provider.
Public outputs could be a commitment to a list of updated account IDs, a root of the batch note tree, and a commitment to list of created nullifiers.

If anyone can think of a design so that we only have a single graph type; that would be great. They're always a pain to test and maintain so having just single variant would be much better.

I've addressed the review comments; I'll merge this PR into next-block-producer and continue with smaller, more revieawable PRs.


Cannot read property 'classList' of null within onReset()

Bug report

Current behavior:
We're getting errors Cannot read property 'classList' of null via our Sentry and it traces down to
/node_modules/pulltorefreshjs/dist/index.umd.js in onReset at line 72:24
Expected behavior:
Should check if element exist before proceeding with the function's process

JSFiddle URL for demo with bug:
Browsers affected:

Got it, which version you're using?

@johnysusanto all fields are required, especially the JSFiddle URL so we can debug it. Feel free to open another issue and be sure to complete every piece of data required.

Got it, which version you're using?

It's the latest one.

@johnysusanto all fields are required, especially the JSFiddle URL so we can debug it. Feel free to open another issue and be sure to complete every piece of data required.

It happens randomly so it's quite hard for us to replicate this. But looking at the Sentry log, I think the fix location should be quite obvious
Thank you

Yeah, may be there is a race condition in your code but according our tests those are covered. If something happens at implementation level is hard to actually understand without enough context.
Having a minimal reproducible example that demonstrate the issue is the right way to begin.


Sometimes the tool crashes when the account still has CPU, but the tool reports that the CPU is overloaded on Wax. Forever loop

Sometimes the tool crashes when the account still has CPU, but the tool reports that the CPU is overloaded on Wax. Forever loop. Can you check on it ?

What is the error message?
if the error message is

estimated CPU time (0 us) is not less than the maximum billable CPU time for the transaction (0 us)

it means you have been blocked by wax rpc node, because you submitted too many wrong transactions.
you can see:
https://forums.eoscommunity.org/t/error-estimated-cpu-time-0-us-is-not-less-than-the-maximum-billable-cpu-time-for-the-transaction-0-us/5780
change wax node rpc host or wait 24 hours

I no longer have that case. Thank you. But there is also another problem that the tool seems to be stopped and not running regularly. For example, I have a mining command at 10:00:00 but the tool only stops at 10:00:00 without continuing. Or do I have to configure something?

check log files in 'logs' folder, if it stop without any error,  it may be caused by cmd.exe's quick edit mode.
you can use cmder (https://github.com/cmderdev/cmder)  to run python code instead of cmd.exe


ui.bootstrap.typeahead fails with ng-csp directive

As best I understand, the ng-csp should be called at the html element (or can be?), but doing so causes the ui.bootstrap.typeahead module to fail in some/most cases. And as best I can tell, when applied to the body element instead, it doesn't (but I'm not convinced ng-csp actually is doing anything anyway).
So the problem in my opinion is more probably the ng-csp stuff in Angular, but I can't verify that (can't isolate a plnkr for ng-csp without hours and hours of work). And as stated before, it doesn't seem like anyone uses ns-csp anyway, so maybe the answer is to dump it.
Here is the plnkr which demonstrates this in my browser:
http://plnkr.co/edit/02c0Cf3Tmu4ckUs4QGBV?p=preview
Version 43.0.2357.130 Built on Ubuntu 14.10, running on Ubuntu 15.04
I noticed the problem when using these versions:
Angular: v1.5.3  ...but see version in plnkr also
UIBS: v1.2.5
Bootstrap: v3.3.6
Now oddly enough the test plnkr fails for all cases except the last one (Custom popup templates for typeahead's dropdown), This still works. But when I use my version of Angular (derived from v1.5.3) which uses ng-csp code as the default, the only case that fails is the last one (the Custom popup). And it fails for the right reason I think. It disallows the inline style: style="display: block;" in the custom popup template, so the html is there but not viewable (which is probably correct for what the ng-csp code is intended to do as best I understand). My testing also used ngSanitize. When adding ngSanitize to the required modules in the plnkr, the last case (Custom popup) stops working too.

When using ng-csp, one needs to include the stylesheet part - see here.
Closing as a usage issue.

Yeah, I found that out too...too late. Sorry about that. My version worked because I had included it earlier, and forgot.
Here is the css that makes the plunker work correctly, for anyone else missing this important detail:
[uib-typeahead-popup].dropdown-menu {
display: block;
}

The problem with the csp css "solution" is that when the object has been selected or is empty/null, there's a small white box showing up with no content, under the input. It's the ul .dropdown-menu, but empty. It's visible in the plunker that @wesleycho posted: http://plnkr.co/edit/yxI5usIjWX9icnFu43oB?p=preview
Is there a workaround for this?
It looks pretty bad. I think it would go away if the ul used ng-if instead of ng-show, but not sure if that would cause some other problems or is a valid solution.

@HugCoder can you open a separate issue with that - it looks like a bug, but I need to spend some time thinking about it as to what a good solution is.

OK, thanks, new issue here #6220.


feat: support terraform resource import

What type of PR is this?

/kind feature
What this PR does / why we need it:
This PR implements the import interface for terraform runtime, and supports importing the existing TF resources with Kusion.
Which issue(s) this PR fixes:

Fixes #286
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

12 of 93 (12.9%)  changed or added relevant lines in 3 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 54.051%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/engine/operation/graph/resource_node.go
0
4
0.0%

pkg/engine/runtime/terraform/terraform_runtime.go
10
37
27.03%

pkg/engine/runtime/terraform/tfops/workspace.go
2
52
3.85%

Files with Coverage Reduction
New Missed Lines
%

pkg/cmd/destroy/destroy.go
7
49.82%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
9127

Relevant Lines:
16886

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

12 of 93 (12.9%)  changed or added relevant lines in 3 files are covered.
261 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.3%) to 53.952%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/engine/operation/graph/resource_node.go
0
4
0.0%

pkg/engine/runtime/terraform/terraform_runtime.go
10
37
27.03%

pkg/engine/runtime/terraform/tfops/workspace.go
2
52
3.85%

Files with Coverage Reduction
New Missed Lines
%

pkg/config/validation.go
10
75.65%

pkg/apis/api.kusion.io/v1/types.go
14
0.0%

pkg/cmd/preview/preview.go
52
39.57%

pkg/cmd/apply/apply.go
185
50.3%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
9146

Relevant Lines:
16952

💛  - Coveralls


Test: New Shapes for FindTextInFiles and FindFiles

Refs https://github.com/microsoft/vscode/issues/59924, https://github.com/microsoft/vscode/issues/48674

[ ] macOS @paulacamargo25
[ ] windows @Tyriar
[x] windows @alexr00

Complexity: 4
Roles: Developer, Engineering Manager
Create Issue

Intro / History
There has been a lot of work going into finalizing 4 search APIs. Here is a little table that sorta explains how they're related, plus the main function calls from each. Essentially, for file and text search, we have to finalize APIs for

Leveraging whatever providers (ie: ripgrep) that vscode has access to in order to find text and files (finders).
Given that a user is using API or the UI to find text or files, being able to provide results (ie: if someone had a virtual file system, this helps with giving accurate results) (consumers)

findFiles2 is meant to replace the existing finalized API workspace.findFiles. So it will be renamed to findFiles then.
EDIT: it will be added as an overload of the current findFiles call, where the old call signature will be deprecated (but still supported).
Right now, we are focusing on the APIs on the first row, as their API shapes are quite stable for the most part.
Since this is gonna be a huge change for any first-party extensions that are using these proposed APIs, I've split out the new shape in new files that end in New. For example, the new shape for findTextInFiles is in findTextInFilesNew.
Set up
⚠  Get the latest insiders! ⚠
Create an extension that can use the following proposed APIs:

findFiles2New
findTextInFilesNew
TextSearchProviderNew (needed for some of the types that findTextInFiles uses).

Testing
Now, try the APIs out!

https://github.com/microsoft/vscode/blob/main/src/vscode-dts/vscode.proposed.findTextInFilesNew.d.ts
https://github.com/microsoft/vscode/blob/main/src/vscode-dts/vscode.proposed.findFiles2New.d.ts

Check:

That basic functionality works, considering the known bugs listed below.
That the API shape makes sense to you and that the documentation makes sense.
That there isn't anything missing from the API that you think is critical.
Any suggestions for API shape to make it clearer

Known bugs that I plan to fix!

Listing any more than 1 GlobPattern in the following will not work. This is because there was no previous support for this, and I sort of scrapped together the connection for these two APIs in one day so that people could test. 😅

The filePattern arg for findFiles2New.
The excludes field in FindFiles2OptionsNew
The includes field in FindTextInFilesOptionsNew
The excludes field in FindTextInFilesOptionsNew

If you set a baseUri for the following GlobPatterns, it will not be recognized. This is for a similar reason- this was a bug carried from the previous implementation.

The excludes field in FindTextInFilesOptionsNew
The excludes field in FindFiles2OptionsNew

Thanks for testing!! ❤ Please message me if you have any questions about the API!
PS: This TPI was made rather last-minute... I really hope I don't regret this... 😬

@andreamah this felt like a big complexity 5 TPI to me. I tested for a couple hours but definitely didn't test this exhaustively. I would suggest that for testing this in the future that you break it into 2 smaller TPIs, one for each main API!

findFiles2 is meant to replace the existing finalized API workspace.findFiles. So it will be renamed to findFiles then.

It won't replace as that would be breaking would it? Is it going to be a just add an extra overload, similar to createTerminal which has several?

@andreamah this felt like a big complexity 5 TPI to me. I tested for a couple hours but definitely didn't test this exhaustively. I would suggest that for testing this in the future that you break it into 2 smaller TPIs, one for each main API!

oops, thanks for the feedback! I meant for this to be an opportunity to take a first look at the APIs, but I def underestimated the time that it'd take to get used to the shapes as someone looking at it for the first time.

findFiles2 is meant to replace the existing finalized API workspace.findFiles. So it will be renamed to findFiles then.

It won't replace as that would be breaking would it? Is it going to be a just add an extra overload, similar to createTerminal which has several?

it'd be an added overload, where the old call type would be deprecated.

@andreamah why would the old call be deprecated? Wouldn't it just stay there and remain supported?

The new way would be the advised way of using it. We could also leave it, although it has confusing exclude configurations

@andreamah we have a pretty strict non breaking API policy, I think the only time we broke API was to get multi-root workspaces working properly and that involved emailing extension authors. We should be able to update the description and maybe even the parameter name without breaking though which could help clarify and say what the old one is an alias for in the new one.

Invalid test plan item. See errors below and the test plan item spec for more information. This comment will go away when the issues are resolved.
Error: Test plan item has invalid assignments - [ ] ~linux~ windows @Tyriar

Invalid test plan item. See errors below and the test plan item spec for more information. This comment will go away when the issues are resolved.
Error: Test plan item has invalid assignments - [ ] ~linux~ windows @Tyriar

yeah, we can just support the new overload as just an alternative way of calling then. It would be nice if we could 'recommend' the new one though


v3 breaks Webpack / UglifyJS bundling process

I've been using the stringify-object package for quite some time in both my Node projects and Web projects. Recently, I upgraded from v2.4.0 to v3.1.0 and that broke my Webpack build process as follows:
ERROR in app.22a5f0a6.js from UglifyJs
SyntaxError: Unexpected token: operator (>) [../~/stringify-object/index.js:6,0]

Seems like this line is the culprit.
If I change that line to regular function syntax notation (instead of ES6 arrow syntax), it seems to fix the problem.
Any ideas why Uglify would complain there?
I use stringify-object heavily for debugging purposes throughout my projects, so I'd love to get this fixed.

Uglify doesn't support ES2015. It's up to you to transpile with Babel or stay at the older version.
Explanation: https://github.com/sindresorhus/file-type/issues/70#issuecomment-268853935


Issues with Angular-Fullstack generator

I've been trying to properly scaffold out a MEAN app using yo and the angular-fullstack generator but I've ran into nothing but issues. I learnt the hard that NPM 3 broke dependency management in yo and now I've switched to Node 4.2.2 and NPM 2.14.7 but I'm still getting the below error. Head's spinning with all  this stuff by this stage - If there's something I'm missing please offer some guidance.
npm ERR! Windows_NT 10.0.10240
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\syfer\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v4.2.2
npm ERR! npm  v3.4.0
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the v8-debug package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get their info via:
npm ERR!     npm owner ls v8-debug
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\syfer\Desktop\New folder\npm-debug.log

Then open an issue on angular-fullstack repository.


What is "params"?

I dont understad the variable params.  The code snippets posted in the readme do not work in vscode because:
params implicitly has any type.
See screenshot.

It does work on my end, you must be doing something fancy with TypeScript (which is not supported)?
params is a generic object, whose properties are according to the method, in your case is Network.requestWillBeSent.

This is likely because of the build-in TS/JS linting in vscode. You can disable TS validation in the (user/workspace) settings (this should be enough for this issue) or disable all the built-in linting and use plugins like ESLint in JS workspaces or TSLint is TS workspaces. Unfortunately it's a mess and I can't check my editor settings right now, maybe you find some helpful answers in

https://stackoverflow.com/questions/42632215/how-to-disable-typescript-warnings-in-vscode
https://stackoverflow.com/questions/50823743/disable-tslint-in-vscode.

Not too precise, I kbow, hope it helps a bit though.

@matjaeck thanks for chiming in, I'm no a vscode user but how come TypeScript errors pop up in a pure JavasScript code?
FWIW opening the README example in a vanilla vscode setup works as expected.

@cyrus-and I can neither reproduce the specific error, but the ts(7006) label shows that it comes from the built-in vscode.typescript-language-features extension (one can find it in the extension tab when searching for @builtin TypeScript and JavaScript Language Features).

The TypeScript extension powers our javascript intellisense which is why you see [TS] in your js file. That only indicates what extension is providing that error

Microsoft/vscode/#54691
Users have also reported a while ago that they see random errors (Microsoft/vscode/#54261). I don't know if those reports have ever been or are still valid, but I can reproduce a similar warning, although having typescript validation disabled in user (topright window) and workspace setting (bottom right, no overrides).

The only way I know to fix these warnings and potentially errors too is to set "javascript.validate.enable": false and setup own tooling with for example ESLint. It's not nessecary on my system because I see only these unobtrusive mouse-over-suggestions.

Thank you @matjaeck, this was the issue.  However, I was able to use "noImplicitAny": false to fix this.

You can now use unofficial typings here: https://www.npmjs.com/package/@types/chrome-remote-interface
Related: https://github.com/cyrus-and/chrome-remote-interface/issues/112


Support arguments

[x] Following CODE_OF_CONDUCT.md.
[x] Checked for duplicate pull requests
[x] Title is a summary of the change, in present tense, ideally < 50 characters
[x] Pulling from a branch (right side), not master.
[x] Pulling into master branch (left side).
[x] Fixing a bug? An open bug report exists.
[x] Breaking API changes? Migration notes attached.

:sparkles: Enhancement
Closes #52.

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: update tab styling to match design system

Coverage remained the same at 90.071% when pulling 9a0d39a3a75dd0d53a79bca007e824c37cefb2f5 on abutterworth/tabs into fd6f583c30e128e16e4618e006639407d72ea732 on master.

:tada: This PR is included in version 14.12.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add freeicons.io ?

Thanks for this big library ! Maybe adding freeicons.io would be a good candidate ?

That's a website with many small icon sets, not an icon set.
For an icon set to be added to Iconify, it needs to:

Have open source license.
Be available at GitHub or NPM (or something similar, where icons can be automatically downloaded from to keep them up to date).

All icon sets on that website do not match those requirements.


Updating tray to Tray because of typo

"tray" is not a module, but "Tray" is.

:+1: please merge 💃

sorry for the late response.
will do in the weekend.
Thanks


feat: simplify apisix client

This Pull Request simplified the apisix client (pkg/apisix), all redundant data structures were removed and data structures in pkg/types/apisix are tweaked so they can be used by the apisix client seamlessly.
All change can be classified as:

Remove FullName field, it's duplicated with Name, so just keeping Name.
Remove routeReqBody, routeItem, UpstreamReqBody, UpstreamItem, just using Route, Upstream in pkg/types/apisix.

@tokers E2E failed.

where to view this result?

where to view this result?

Weird, we really upload the codecov report.


Updated darkmode feature

Closes #503
Description:

I have updated dark mode feature.Now it is looking good and text is clearly visible in darkmode too.

Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[x ] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[ x] I followed the prescribed PR title template. (Check this if you're adding a resource)

fill the bracket with x. Something like this [x]

I sent pull request.kindly check it


Unit test: profiler_unittest.sh fails when glibc-debuginfo packages are installed.

Hi,

When compiling gperftools-2.6.1 using

  configure:5271: gcc --version >&5
  gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
  Copyright (C) 2015 Free Software Foundation, Inc.
  This is free software; see the source for copying conditions.  There is NO
  warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

on
  mea@dhws009> cat /etc/redhat-release
  cat /etc/redhat-release
  Red Hat Enterprise Linux Server release 7.4 (Maipo)

  mea@dhws009> uname -a
  uname -a
  Linux dhws009 3.10.0-693.5.2.el7.x86_64 #1 SMP Fri Oct 13 10:46:25 EDT 2017 x86_64 x86_64 x86_64 GNU/Linux

we have 1 unit test failing:

    ============================================================================
    Testsuite summary for gperftools 2.6.1
    ============================================================================
    # TOTAL: 48
    # PASS:  47
    # SKIP:  0
    # XFAIL: 0
    # FAIL:  1
    # XPASS: 0
    # ERROR: 0
    ============================================================================
    See ./test-suite.log
    Please report to<EMAIL_ADDRESS>    ============================================================================

Test: profiler_unittest.sh fails. When looking at the differences I assume it has to do with the fact we have debug symbols package for glibc installed.

  >>> profile doesn't match, args: /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler1_unittest /tmp/profile_info/p12 vs.  /tmp/profile_info/p13
  >>> Diff:
  5c5
  <        1   4.5%  95.5%        1   4.5% ?? /usr/src/debug////////glibc-2.17-c758a686/string/../sysdeps/x86_64/strchrnul.S:59
  ---
  >        1   4.5%  95.5%        1   4.5% ?? ?

debug packages installed:

    mea@dhws009> rpm -qa | grep glibc
    rpm -qa | grep glibc
    glibc-devel-2.17-196.el7.x86_64
    glibc-2.17-196.el7.i686
    glibc-2.17-196.el7.x86_64
    glibc-devel-2.17-196.el7.i686
    glibc-utils-2.17-196.el7.x86_64
    glibc-debuginfo-common-2.17-196.el7.x86_64
    glibc-debuginfo-2.17-196.el7.x86_64
    glibc-headers-2.17-196.el7.x86_64
    glibc-common-2.17-196.el7.x86_64
    glibc-static-2.17-196.el7.x86_64

I'm able to trace it back to:

    ./profiler3_unittest 30 2 p14
    ./src/pprof --test_stride=128 ./.libs/profiler3_unittest p14 -raw >p15 2>/dev/null
    ./src/pprof --test_stride=128 p15 >out1

    ./src/pprof --test_stride=128 ./.libs/profiler3_unittest p14 >out2

    diff out1 out2

    mea@dhws009> diff out1 out2
    diff out1 out2
    9,10c9,10
    <        1   2.9%  88.2%        1   2.9% ?? ?
    <        1   2.9%  91.2%        1   2.9% ?? ?
    ---
    >        1   2.9%  88.2%        1   2.9% ?? /usr/src/debug////////glibc-2.17-c758a686/string/../sysdeps/x86_64/strchrnul.S:39
    >        1   2.9%  91.2%        1   2.9% ?? /usr/src/debug////////glibc-2.17-c758a686/string/../sysdeps/x86_64/strchrnul.S:59
    14c14
    <        0   0.0% 100.0%       17  50.0% ?? ?
    ---
    >        0   0.0% 100.0%       17  50.0% ?? /usr/src/debug////////glibc-2.17-c758a686/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:113
    mea@dhws009>

The problem I have is: may perl knowledge is limited ....

The option --debug of pprof doesn't help me much:

  mea@dhws009> ./src/pprof --debug --test_stride=128 ./.libs/profiler3_unittest p14 >out2
  ./src/pprof --debug --test_stride=128 ./.libs/profiler3_unittest p14 >out2
  Using local file ./.libs/profiler3_unittest.
  Using 'nm' for 'nm'.
  Using 'c++filt' for 'c++filt'.
  Using 'addr2line' for 'addr2line'.
  Using 'objdump' for 'objdump'.
  Using local file p14.

  mea@dhws009> ./src/pprof --debug --test_stride=128 p15 >out1
  ./src/pprof --debug --test_stride=128 p15 >out1
  Using local file p15.
  Using local file p15.
  mea@dhws009>

Are there ways to have a more verbose pprof? (eg: an output with lots of tracing, like 'sh -x <script>) for shell scripts?

Is it normal to have some test failing when debug packages are installed?

------
mea@dhws009> cat test-suite.log
cat test-suite.log
========================================
   gperftools 2.6.1: ./test-suite.log
========================================

# TOTAL: 48
# PASS:  47
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: profiler_unittest.sh
==========================

>>> WARNING <<<
This test looks at timing information to determine correctness.
If your system is loaded, the test may spuriously fail.
If the test does fail with an 'Actual times' error, try running again.

PROFILE: interrupts/evictions/bytes = 22/0/1000
PROFILE: interrupts/evictions/bytes = 34/0/1040
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler1_unittest.
Using local file /tmp/profile_info/p1.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler1_unittest.
Using local file /tmp/profile_info/p2.
PROFILE: interrupts/evictions/bytes = 22/0/896
PROFILE: interrupts/evictions/bytes = 34/0/1304
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler2_unittest.
Using local file /tmp/profile_info/p3.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler2_unittest.
Using local file /tmp/profile_info/p4.
PROFILE: interrupts/evictions/bytes = 22/0/1072
PROFILE: interrupts/evictions/bytes = 34/0/648
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler2_unittest.
Using local file /tmp/profile_info/p5.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler2_unittest.
Using local file /tmp/profile_info/p6.
PROFILE: interrupts/evictions/bytes = 25/0/1584
PROFILE: interrupts/evictions/bytes = 35/0/1576
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler3_unittest.
Using local file /tmp/profile_info/p5b.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler3_unittest.
Using local file /tmp/profile_info/p5c.
PROFILE: interrupts/evictions/bytes = 34/0/1848
PROFILE: interrupts/evictions/bytes = 48/0/1672
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler3_unittest.
Using local file /tmp/profile_info/p7.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler3_unittest.
Using local file /tmp/profile_info/p8.
PROFILE: interrupts/evictions/bytes = 35/0/1640
PROFILE: interrupts/evictions/bytes = 48/0/1976
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler4_unittest.
Using local file /tmp/profile_info/p9.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler4_unittest.
Using local file /tmp/profile_info/p10.
PROFILE: interrupts/evictions/bytes = 41/0/2536
PROFILE: interrupts/evictions/bytes = 56/0/2208
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler4_unittest.
Using local file /tmp/profile_info/p9.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler4_unittest.
Using local file /tmp/profile_info/p10.
PROFILE: interrupts/evictions/bytes = 40/0/2160
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler4_unittest.
Using local file /tmp/profile_info/p11.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler4_unittest.
Using local file /tmp/profile_info/p11.
PROFILE: interrupts/evictions/bytes = 22/0/1160
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler1_unittest.
Using local file /tmp/profile_info/p12.
Using local file /tmp/profile_info/p13.
Using local file /tmp/profile_info/p13.

>>> profile doesn't match, args: /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler1_unittest /tmp/profile_info/p12 vs.  /tmp/profile_info/p13
>>> Diff:
5c5
<        1   4.5%  95.5%        1   4.5% ?? /usr/src/debug////////glibc-2.17-c758a686/string/../sysdeps/x86_64/strchrnul.S:59
---
>        1   4.5%  95.5%        1   4.5% ?? ?

PROFILE: interrupts/evictions/bytes = 34/0/1808
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler3_unittest.
Using local file /tmp/profile_info/p14.
Using local file /tmp/profile_info/p15.
Using local file /tmp/profile_info/p15.

>>> profile doesn't match, args: /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler3_unittest /tmp/profile_info/p14 vs.  /tmp/profile_info/p15
>>> Diff:
7,8c7,8
<        1   2.9%  91.2%        1   2.9% ?? ??:0
<        1   2.9%  94.1%        1   2.9% ?? /usr/src/debug////////glibc-2.17-c758a686/string/../sysdeps/x86_64/strchrnul.S:27
---
>        1   2.9%  91.2%        1   2.9% ?? ?
>        1   2.9%  94.1%        1   2.9% ?? ?
11c11
<        0   0.0% 100.0%       17  50.0% ?? /usr/src/debug////////glibc-2.17-c758a686/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:113
---
>        0   0.0% 100.0%       17  50.0% ?? ?

PROFILE: interrupts/evictions/bytes = 34/0/1008
PROFILE: interrupts/evictions/bytes = 48/0/880
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler3_unittest.
Using local file /tmp/profile_info/p16.
Using local file /auto/local_build/dhws009/disk1/contrib/builds/gperftools-2.6.1/work/gperftools-2.6.1/.libs/lt-profiler3_unittest.
Using local file /tmp/profile_info/p17.
PROFILE: interrupts/evictions/bytes = 8/0/632
PROFILE: interrupts/evictions/bytes = 8/0/672
PROFILE: interrupts/evictions/bytes = 8/0/592
Tests finished with 2 failures
FAIL profiler_unittest.sh (exit status: 2)

mea@dhws009>

--
Koen Meersman                          Eurocontrol - CFMU room 20.122
<EMAIL_ADDRESS>        Raketstraat 96
Tel: +32 2 729 97 36                   B-1130 BRUSSELS
Fax: +32 2 729 90 22                   Belgium

we don't support our perl pprof version anymore. In progress of getting rid of it (but how to deal with tests that inspect pprof output remains to be decided).
In any case for actual production use go get github.com/google/pprof which is actually supported and much more awesome. If it still causes bogus symbolization then file bug there.


Added the option for having fixed label to the directive

If possible please merge it to 5.4.3 as we have started using that version of yours.
Please kindly approve

Current coverage is 100% (diff: 100%)

Merging #405 into master will not change coverage

@@           master   #405   diff @@
====================================
  Files           1      1
  Lines         852    854     +2
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
+ Hits          852    854     +2
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update b0c190b...bebd4af

Please describe the purpose of this PR and provide a demo.

This PR is to configure the directive so the limit labels don't hide when we reach a particular limit towards floor or ceil value.
Demo

Hi Valentin,
How long do you think it may take to  merge the pull request?
Thanks in advance

I'm sorry, I'm currently on holidays so I don't have access to my computer and won't be able to release it anyway...
Here are a few remarks:

I would prefer to replace the showLimitLabels by something like autoHideLabels: true by default so its purpose is more obvious.
other comments are on the lines directly...

Done!

The dist file is still incorrect, you should run grunt before commiting...

Done!

Merged and release under 5.5.0. I have just rename the new option to autoHideLimitLabels since it makes more sense.


Formatting cleanup

Fixes trivial (but noisy) formatting changes; caused by running unstable cargo fmt features from rustfmt.toml.

Can you either re-run this on main or resolve merge conflicts?

Fixing this will be more work than redoing it. Opening a new PR quick.


Actions that make the system appear to "hang"

•	I tried to update the MLA schema and it flagged me and let me know that I had to put in an order for reference. It did not flag me that author was also required so when I pressed submit it just “hanged”
•	If you try to delete a character or state and don’t include enough information it just hangs after you hit submit instead of indicating missing information in red.

I believe that this has been addressed by the changes described in https://github.com/paleobot/pbot-client/issues/22


Changing a DbSet<> property name can create incorrect TPH foreign keys in model

Changing a DbSet<> property name can result in incorrect TPH foreign keys in the model.
Just run the example code below with the following instructions.
The referencing foreign keys are captured at the first line of OnModelCreating (set a breakpoint), before any custom model configuration is done.
When running the code with the DbSet<Packs> named as Packs" everything runs fine. OnModelCreating succeeds and the resulting referencing foreign keys on PetOwner are (as expected):
modelBuilder.Entity<PetOwner>().Metadata.GetReferencingForeignKeys()
Count = 3
    [0]: {ForeignKey: Cat {'PetOwnerId'} -> PetOwner {'Id'} ToDependent: Cats ToPrincipal: PetOwner}
    [1]: {ForeignKey: Dog {'PetOwnerId'} -> PetOwner {'Id'} ToDependent: Dogs ToPrincipal: PetOwner}
    [2]: {ForeignKey: Pack {'PetOwnerId'} -> PetOwner {'Id'} ToPrincipal: PetOwner}

Now if we rename Packs to APacks, the referencing foreign keys on PetOwner are:
modelBuilder.Entity<PetOwner>().Metadata.GetReferencingForeignKeys()
Count = 4
    [0]: {ForeignKey: Pack {'PetOwnerId'} -> PetOwner {'Id'} ToPrincipal: PetOwner}
    [1]: {ForeignKey: Pet {'PetOwnerId'} -> PetOwner {'Id'} ToPrincipal: PetOwner}
    [2]: {ForeignKey: Cat {'PetOwnerId1'} -> PetOwner {'Id'} ToDependent: Cats}
    [3]: {ForeignKey: Dog {'PetOwnerId1'} -> PetOwner {'Id'} ToDependent: Dogs}

This is incorrect, foreign key [1] should not have been created. Furthermore, OnModelCreating now fails with the exception below.
Exception message:
The navigation property 'Dogs' cannot be added to the entity type 'PetOwner' because its CLR type 'List<Dog>' does not match the expected CLR type 'Pet'.

Stack trace:
   at Microsoft.EntityFrameworkCore.Metadata.Internal.Navigation.IsCompatible(MemberInfo navigationProperty, Type sourceClrType, Type targetClrType, Nullable`1 shouldBeCollection, Boolean shouldThrow)
   at Microsoft.EntityFrameworkCore.Metadata.Internal.InternalRelationshipBuilder.IsCompatible(MemberInfo navigationProperty, Boolean pointsToPrincipal, Type dependentType, Type principalType, Boolean shouldThrow, Nullable`1& shouldBeUnique)
   at Microsoft.EntityFrameworkCore.Metadata.Internal.InternalRelationshipBuilder.CanSetNavigations(Nullable`1 navigationToPrincipal, Nullable`1 navigationToDependent, EntityType principalEntityType, EntityType dependentEntityType, Nullable`1 configurationSource, Boolean shouldThrow, Boolean overrideSameSource, Nullable`1& shouldInvert, Nullable`1& shouldBeUnique, Boolean& removeOppositeNavigation, Boolean& removeConflictingNavigations)
   at Microsoft.EntityFrameworkCore.Metadata.Internal.InternalRelationshipBuilder.HasNavigations(Nullable`1 navigationToPrincipal, Nullable`1 navigationToDependent, EntityType principalEntityType, EntityType dependentEntityType, ConfigurationSource configurationSource)
   at Microsoft.EntityFrameworkCore.Metadata.Internal.InternalRelationshipBuilder.HasNavigations(Nullable`1 navigationToPrincipal, Nullable`1 navigationToDependent, ConfigurationSource configurationSource)
   at Microsoft.EntityFrameworkCore.Metadata.Internal.InternalRelationshipBuilder.HasNavigation(MemberInfo property, Boolean pointsToPrincipal, ConfigurationSource configurationSource)
   at Microsoft.EntityFrameworkCore.Metadata.Builders.ReferenceNavigationBuilder.WithManyBuilder(MemberIdentity collection)
   at Microsoft.EntityFrameworkCore.Metadata.Builders.ReferenceNavigationBuilder.WithManyBuilder(MemberInfo navigationMemberInfo)
   at Microsoft.EntityFrameworkCore.Metadata.Builders.ReferenceNavigationBuilder`2.WithMany(Expression`1 navigationExpression)
   at EFCoreBugExample1.ExampleContext.OnModelCreating(ModelBuilder modelBuilder) in C:\TestProjects\EFCoreBugExample1\EFCoreBugExample1\Program.cs:line 49
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelCustomizer.Customize(ModelBuilder modelBuilder, DbContext context)
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSource.CreateModel(DbContext context, IConventionSetBuilder conventionSetBuilder)
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSource.<>c__DisplayClass5_0.<GetModel>b__1()
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)

Steps to reproduce
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Design;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;
using System.ComponentModel.DataAnnotations.Schema;
using System.Threading.Tasks;

namespace EFCoreBugExample1
{
    class Program
    {
        public static string ConnectionString = "Server=.\\SQLEXPRESS;Database=ExampleDb;MultipleActiveResultSets=true";

        static async Task Main(string[] args)
        {
            var options = new DbContextOptionsBuilder()
                .UseSqlServer(ConnectionString)
                .Options;

            var db = new ExampleContext(options);
            db.ChangeTracker.Entries();
        }
    }

    public class ExampleDesignTimeDbContextFactory : IDesignTimeDbContextFactory<ExampleContext>
    {
        public ExampleContext CreateDbContext(string[] args) => new ExampleContext(
            new DbContextOptionsBuilder()
            .UseSqlServer(Program.ConnectionString)
            .Options);
    }

    public class ExampleContext : DbContext
    {
        public DbSet<Pack> APacks { get; set; }
        public DbSet<Pet> CountryLists { get; set; }
        public DbSet<PetOwner> PetOwners { get; set; }

        public ExampleContext(DbContextOptions options) : base(options) { }
        protected ExampleContext() { }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            modelBuilder.Entity<Pet>()
                .HasDiscriminator(x => x.Discriminator);

            modelBuilder
                .Entity<Dog>()
                .HasOne(x => x.PetOwner)
                .WithMany(x => x.Dogs);

            modelBuilder
                .Entity<Cat>()
                .HasOne(x => x.PetOwner)
                .WithMany(x => x.Cats);

            base.OnModelCreating(modelBuilder);
        }
    }

    public class PetOwner
    {

        [Key]
        public long Id { get; set; }

        [Timestamp]
        public byte[] RowVersion { get; set; }

        public List<Dog> Dogs { get; set; }

        public List<Cat> Cats { get; set; }
    }

    public class Pet
    {
        [Key]
        public long Id { get; set; }

        public string Discriminator { get; set; }

        [Timestamp]
        public byte[] RowVersion { get; set; }

        [ForeignKey(nameof(PetOwner))]
        public long PetOwnerId { get; set; }

        public PetOwner PetOwner { get; set; }
    }

    public class Cat : Pet
    {
        public int RemainingLives { get; set; }
    }

    public class Dog : Pet
    {
        [ForeignKey(nameof(Pack))]
        public long PackId { get; set; }

        public Pack Pack { get; set; }
    }

    public class Pack
    {
        [Key]
        public long Id { get; set; }

        [Timestamp]
        public byte[] RowVersion { get; set; }

        [ForeignKey(nameof(PetOwner))]
        public long PetOwnerId { get; set; }

        public PetOwner PetOwner { get; set; }

        public List<Dog> Dogs { get; set; }
    }
}

Further technical details
EF Core version: 3.0.0-preview7.19362.6
Database Provider:Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10 1903
IDE: Visual Studio 2019 16.3.0 Preview 1

@LeroyK Does this also fail for you on 2.2.6?
@AndriySvyryd Repros for me on currently nightlies, but I'm not entirely sure what the expectation is in this case.

My thoughts: 2nd one is correct. Pet.PetOwner navigation is defined on base class which is part of model. And inverse navigations (Dogs/Cats) points to derived type. We cannot pair those up. Derived types cannot have same navigation as base type unless it is ignored on base type and added in derived type. Without paired up navigations, you would get what is in configuration 2.
Error is also valid bit difficult to understand. Trying to configure PetOwner navigation in derived type will get you navigation from base type and the inverse navigation is incompatible.
Does it work if you ignore the navigation in base class and then configure in derived types?

@LeroyK Does this also fail for you on 2.2.6?
No, this started happening after switching to 3.0. It worked fine in 2.2.6.

My thoughts: 2nd one is correct. Pet.PetOwner navigation is defined on base class which is part of model. And inverse navigations (Dogs/Cats) points to derived type. We cannot pair those up. Derived types cannot have same navigation as base type unless it is ignored on base type and added in derived type. Without paired up navigations, you would get what is in configuration 2.

I would say the first one is correct for the provider model, but not for the entity model. In OnModelCreating I am defining the navigations for Cat & Dog explicitely, not for Pet. When using Sql Server it should result in just one FK constraint. In 2.2.6 it currently created two, but that could be overcome by naming them the same using HasConstraintName("FK_Name").

Does it work if you ignore the navigation in base class and then configure in derived types?
I actually got it to work by creating a bit of a hack:

Removing RelationshipDiscoveryConvention from ConventionSet.NavigationRemovedConventions, because this kept adding back the foreign keys.
Manually removing the foreign keys to PetOwner (from Pet, Cat & Dog).
Creating the navigations in OnModelCreating,


Add video in header of 1.2.0 post

@LucyGwilliamAdmin @AnnCorp Here are a couple of options for showing the video: 1) as a header, or 2) embedded below the title.
Here's the header approach:

And here's the embedded-below-title approach:

@brockfanning I think below header is better


Fetch: Client response type

I use 7.0.0 with fetch client and it was amazing
But there is a question
Fetch client return response with data and status fields and it is not what we want
Can i change response type that it return my response type exactly?
Example
Generated code
/**
 * @summary Get user blogger info
 */
export type getUserBloggerInfoResponse = {
  data: GetUserBloggerInfoResponse;
  status: number;
};

What we need
/**
 * @summary Get user blogger info
 */
export type getUserBloggerInfoResponse = GetUserBloggerInfoResponse;

thanks for made issue. Currently it's not supported, but I'll consider it.

@EgorPopovPP
I wanna understand your having problem, so could you tell me your use case ?

@EgorPopovPP I had the same issue with this API, as you can see here: https://github.com/orval-labs/orval/discussions/1535. For now I guess the workaround is to use select function (see the discussion link).
@soartec-lab I do not think anyone would need to check the status. Most of the time you just want the data, and if something is not right, then you take the error ref. Maybe you could provide another ref, which would contain response information like status code and text. But I don't think it should be part of the data ref, because there you want to have pure response data properly typed.

@pbrzosko
thank you. Although status is not used, does that mean it won't interfere even if it is present? Or is it complicated to have to write a select ?

I not like to write bloggerInfo.data.data. You suggest writing a select every time, which doesn't seem like a good solution to me.

Okay, so you want to access the data only through bloggerInfo.data, not bloggerInfo.data.data right?

Okay, so you want to access the data only through bloggerInfo.data, not bloggerInfo.data.data right?

Yes, it is

Okay, so you want to access the data only through bloggerInfo.data, not bloggerInfo.data.data right?

@soartec-lab
Yes, that's my problem as well.  The extra data is a pain point.

I agree with the above.

I see, I understand. This issue is caused by the tanstack query client's dependency on 'orval/fetch'.
orval/fetch makes it easier for applications to handle http status, so the response must include the http status.
And since the tanstack query client relies on orval/fetch, its response type is inherited.
So i plan to add new configuration properties. That allows orval to change the return type to a single type like Pet or Pets.

Hey everyone. I fixed this issue by i added new config option. Please try this 🙌
https://orval.dev/guides/fetch-client#return-original-defined-return-type


docs: fix broken Expr links

@jbj
The Sphinx link checker now gives the topic a clean bill of health: https://gist.github.com/jf205/13874dc74da3d78662d32530fe19459a

@zlaski-semmle FYI