starlark: require go1.23 for new iterators

The correct type for new iterators is iter.Seq, which depends on a go1.23-only package, so we must limit the new functions to new toolchains.
In principle this is (yet another) breaking change, but I suspect only users of (pre-)go1.23 will notice, and they are living on the bleeding edge by choice. (Even then, if the iterators are used only as range operands, they will be fine.)
Also, fix a couple of doc links.

Thanks for reminding me to git add the new file! ;-)


[Remote] attribute is Client side Only?

It doesn't seem to emphasize enough that out of all built-in attributes, that [Remote] attribute is client side Only?
also for purpose like checking duplicate (emails), [Remote] only verify when unfocused,
and does not verify when form submit , which can easily be invalid.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0156ffc3-47ac-d5da-fbc2-9ff5018b071b
Version Independent ID: 615db388-a244-41f7-21b5-a4085d9ed479
Content: Model validation in ASP.NET Core MVC
Content Source: aspnetcore/mvc/models/validation.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

It's pretty clear
The [Remote] attribute implements client-side validation


Add build caching

This is not working because the build is done with the root user in docker and some of the files are not readable by the workflow user

I like. This sounds very promising.


Deb packages don't work on WLS

I'm trying out the Window's Linux Subsystem in Windows 10. I installed ponyc 0.8.0 via our bintray as per instructions in the README. It installs fine but does nothing. You can run ponyc without errors but it doesn't do anything.
ponyc --version prints nothing nor does anything else. its like it starts and ends without doing anything.
I'm opening an issue for this as we should look into eventually.

Can you try running it in a debugger to see if it gives any information?

What sort of information? It doesn't crash or anything of the sort. It just does, nothing.

If you put a breakpoint on main in the debugger, does the program stops on it? If it does, what is the assembly code for main?

@kulibali do you have a machine with WLS you could test to see if this is still an issue?

I'll test this on Monday.

Ponyc on Ubuntu on Windows 10 works fine for me.


v1.12 Backports 2023-10-06

[ ] #26956 (@julianwiedmann)

:warning: small conflict for bpf/bpf_lxc.c as high ipcache block is not available

[ ] #28358 (@gandro)
[ ] #28258 (@pchaigno)
[ ] #28392 (@giorio94)
[ ] #28403 (@raphink)

Once this PR is merged, a GitHub action will update the labels of these PRs:
 26956 28358 28258 28392 28403

/test-backport-1.12

Most of the reviews are in, CI is green, so let's merge it in.


Notice of Copyright Violation

his is an official notice of Copyright violation against the PIVX developers in which this project has been forked from. The MIT copyright license, and subsequent copyright headers in source files have been modified to explicitly exclude the PIVX developers from all copyrights.
You are hereby notified of an intention to pursue further action if this issue is not acknowledged and formally addressed with a resolution time frame commitment wherein. Failure to acknowledge and correct the violation will result in a formal DMCA take-down notice filed with GitHub Proper after no less than five business days from the date of this notice.
Explicit acknowledgement and referencing progress to maintain compliance MUST be noted in this issue's comments or referred to in any subsequent pull requests to this repository.
File in question:
  CondominiumCore/LICENSE

@Iconoclasta Happy with this pull request? https://github.com/condominium/CondominiumCore/pull/7
Btw im not the original dev, just trying to help :-) Thats all you want changed?

We apologize for the delay and have missed the important thing

Everything seems in order. Thanks for the collaboration.


Assert object

JerryScript-DCO-1.0-Signed-off-by: Virag Orkenyi<EMAIL_ADDRESS>

Please add more description to the commit message.

What's the intention of assert object？


feat: AP-7 Update / upgrade responsibility principle

This writing up as a pattern, not a principle.

Merging this PR to reserve the id.


Error in thermal.dispersion IO

I just noticed that there seems to be a typo in the IO for the disperssion variables in the Flame integrator: note that the input for all variables is thermal.disperssion1 but is getting stored in value.thermal.disperssion1-3.
https://github.com/solidsgroup/alamo/blob/6c86148c2557c02c9b3e75d22e8a5008667f6195/src/Integrator/Flame.cpp#L99-L101
@meierms1 can you confirm?

For reference, the variables are defined here with default values.
https://github.com/solidsgroup/alamo/blob/6c86148c2557c02c9b3e75d22e8a5008667f6195/src/Integrator/Flame.H#L142-L144
I don't think that they are used in any of the tests or inputs AFAIK, but this will cause false behavior if a user tries to put in those values as they will override the existing defaults. (These should be replaced with query_default anyway...).

fixed


window.location.pathname in links in browser HTML reporter

A link starting with window.location.pathname (which is used in the grep links in the HTML reporter) is treated oddly in some browsers, at least when the page is run without a server (straight from the filesystem). For example, Internet Explorer on Windows gets "/C:/path/to/page.html" for window.location.pathname, which causes it to try to go to "C:/C:/path/to/page.html?grep=..." when the grep links are clicked. (I am not sure if this issue affects any other browsers. I'm also not sure whether this is strictly a problem for browsing the page straight off the filesystem, although I wouldn't be surprised if it is.) We should find out if simply removing pathname and using just "?grep=..." for the links works in all browsers, or if there's any other fix.
Looks like test/browser/ui.html tests this, but I don't know whether we can get all the same behavior in automated testing for it or not (or even whether the approach used by test/browser/ui.html works for automated testing).

Given that IE is out of support, closing this as aged away.


Document the precedence of image selectors

Currently, there are a few options to configure which image should be cached:

ignoredNamespaces
ignoredImages
acceptedImages
objectSelector

Their combination is not clear, e.g. does the object selector apply on the top of accepted image or parallel? Having a clear order would help new users to configure kuik better.

:tada: This issue has been resolved in version 1.12.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Delete button not rendered properly

Challenge http://freecodecamp.com/challenges/waypoint-style-text-inputs-as-form-controls has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

Submit

I hope this is well understood? If there is any other way I can help please let me know.

@sravin Does that fix your issue?


Adding aria-label to accessiblility

Giving the ability to set the aria-label attribute for screen readers when working with accessibility

Adding an hint property to the AccessibleTarget
Setting aria-label attribute on div in AccessibilityManager
Only setting default title if both accessibleTitle and accessibleHint are not set

Nice work sir! :+1:


feat (admin-ui): add switch to  make service user as platform user

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 9.42%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
9560

Relevant Lines:
101484

💛  - Coveralls


Support for UIWebView

Hello!
I'm facing problems when trying to add a UIWebView into the stackview. There's no way to see it, even if I add it before of loading the HTML, or after.
Does ORStackView support UIWebView?
Which steps should I do in order to make it work?
Thanks!

It should support a UIWebView just fine to my knowledge, it would have no intrinsic height/width, so you would need to set those yourself. I don't think we have any code that does this though, so I could be wrong.

Ok, managed to solve it by subclassing UIWebView and setting the intrinsic content size after the UIWebview loads its content.
Thanks for the hint. You can close this if you want.


interesting features

Is your request related to a problem? Please describe.
A clear and concise description of what the problem is.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

#68 really hope it will be a good project.  Where is the project with the innovated developer for this project.  Let's build a good and strong community so that this token will be even better.
My address : 0x7f9A4f74D33629C2835Fb407416c870cD2D8F77b

@jalmowidodo Thank you for your testing and we hope to continue delivering high quality features and improvements!


RELATED: RAIL-2924 - Add 'X-Requested-With' header to dev proxy

The code coverage is the same after your change 🤟
This is a good thing if you are not sure ;)
Report (compared to build #178)
Covered lines: 26.8%, change: 0%
Covered branches: 25.93%, change: 0%
Coverage report
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/179/artifact/ci/results/coverage/lcov-report/index.html

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/179/ : SUCCESS in 36s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-oss-check/148/ : SUCCESS in 7s

The code coverage is the same after your change 🤟
This is a good thing if you are not sure ;)
Report (compared to build #178)
Covered lines: 26.8%, change: 0%
Covered branches: 25.93%, change: 0%
Coverage report
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/180/artifact/ci/results/coverage/lcov-report/index.html

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/180/ : SUCCESS in 18s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-oss-check/149/ : SUCCESS in 6s

The code coverage is the same after your change 🤟
This is a good thing if you are not sure ;)
Report (compared to build #178)
Covered lines: 26.8%, change: 0%
Covered branches: 25.93%, change: 0%
Coverage report
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/181/artifact/ci/results/coverage/lcov-report/index.html

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-merge-compliance-check/65/ : SUCCESS in 17s
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/181/ : SUCCESS in 17s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-fossa-scanning-zuul-el7/30/ : SUCCESS in 17s (non-voting)


Confirmation before deleting any problem and contests

Currently the problems localhost/admin and contest localhost/admin/my-contests gets deleted directly after clicking on the Delete button. It should ask the confirmation using the admin logged in user password before deleting.

I want to work on this.


Allow no squashing

.... I forget what I intended to do here. Better have a better description in future. Close it now.


EXCLUDE_PATTERN regex doesn't work.

It looks like EXCLUDE_PATTERN doesn't seem to work properly.
EXCLUDE_PATTERN: ".*.\/(node_modules|dist|bin|files|themes)\/.*"

This is a valid regex that should match any exactly named directory.

However - it doesn't seem to filter anything out - you still get issues logged for files such as:
./files/somefile.txt
./themes/some/thing.txt
./themes/mytheme/node_modules/something.js

etc...
Somewhat related - would it also be better to accept a list/array of files/patterns to match on?, e.g:
exclude:
  - "./node_modules/*"
  - ".*/files/somefile"
  - ".*/**/bacon.yu*"

or if it has to be a string:
exclude: |
  "./node_modules/*"
  ".*/files/somefile"
  ".*/**/bacon.yu*"

Hi
Thank you for reporting this issue. To make it work, please remove ./ (current directory) from your desired match string.
The underlying library tdg supports an array of exclude patterns already here. So the remaining part would be only to have it in .yml if you would like to work on this.

Oh that's very helpful, thank you so much - I think that's done it!


Release Google.Cloud.ArtifactRegistry.V1 version 2.7.0

Changes in this release:
New features

Add IServiceCollection extension methods for client registration where an IServiceProvider is required. (commit 022fab2)

Created release for Google.Cloud.ArtifactRegistry.V1-2.7.0


Issue with k8s.io/docs/tutorials/kubernetes-basics/deploy-app/deploy-interactive/

Hi this interactive tutorial did not work for me - I could not connect to localhost:8001

$ curl http://localhost:8001/version
curl: (7) Failed to connect to localhost port 8001: Connection refused

/triage support
This is likely because you did not start the proxy in another terminal
/close


Log: Adding caller and line as a default function LOG_STACK_TRACE

Do we still want to use travis???

No travis! :)

Not quite there:
package main

import "github.com/timehop/golog/log"

func main() {
	log.Info("Package", "foo", "a", "b")
	log.New(log.Config{ID: "Instance"}).Info("foo", "a", "b")
	log.DefaultLogger.Info("foo", "a", "b")
}

Outputs:
2017/10/17 15:40:40  | INFO | Package | foo | a='b' file='/Users/kevincantwell/depth.go' line='6'
2017/10/17 15:40:40  | INFO | Instance | foo | a='b' file='/Users/kevincantwell/depth.go' line='7'
2017/10/17 15:40:40  | INFO | foo | a='b' file='/usr/local/Cellar/go/1.9.1/libexec/src/runtime/proc.go' line='185'

@marcsantiago Take a look at this: https://github.com/timehop/golog/commit/578d0bf0fb3dd3daba7c6ec3efb49af2f1247cba

@kevin-cantwell https://github.com/timehop/golog/commit/578d0bf0fb3dd3daba7c6ec3efb49af2f1247cba
looks complete


Add DelayingReconciler to delay 403 requeues

xref: https://issues.redhat.com/browse/HIVE-1895

/assign @abutcher

witnessed inside the controller pod logs:
time="2022-08-08T23:17:31.89Z" level=info msg="Encountered permissions error. Requeueing request with delay." controller=machinepool error="could not generate machinesets: compute pool not providing list of zones and failed to fetch list of zones: AuthFailure: AWS was not able to validate the provided access credentials\n\tstatus code: 401, request id: e7257ac2-49fc-498f-80cf-7c6064d3457e" requeueAfter=2m0s

hive controller pod crashed with "leader lost" :cold_sweat:

hive controller pod crashed with "leader lost" cold_sweat

This will happen any time you redeploy hive or edit hiveconfig. There are also certain secrets that hive-operator watches that will cause it to redeploy the controllers. This should mean that another hive-controllers pod came up in its place.

time="2022-08-11T18:49:37.36Z" level=info msg="Encountered permissions error. Requeueing request with delay." controller=hibernation error="AuthFailure: AWS was not able to validate the provided access credentials\n\tstatus code: 401, request id: 9f5f4586-ef38-455f-9041-06d218366ddc" requeueAfter=1m0s
time="2022-08-11T18:50:39.617Z" level=info msg="Encountered permissions error. Requeueing request with delay." controller=hibernation error="AuthFailure: AWS was not able to validate the provided access credentials\n\tstatus code: 401, request id: b1415ce5-c4b0-4bc9-92ff-58178206c491" requeueAfter=1m0s
time="2022-08-11T18:50:39.666Z" level=info msg="Encountered permissions error. Requeueing request with delay." controller=hibernation error="AuthFailure: AWS was not able to validate the provided access credentials\n\tstatus code: 401, request id: d1caa8b8-1d31-4bc8-aaa9-371e3759e3aa" requeueAfter=1m0s


update(pkg/kernelrelease): update kernelrelease regex to match more kernels

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
Expands kernel release pattern to match weird kernels like  5.4.119-19.0009.28 (see https://github.com/falcosecurity/falco/issues/3172)
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[API Proposal] SqlClientOptions

SqlClientOptions is a proposed mechanism to provide strongly-typed runtime configuration of the SqlClient library prior to use. It doesn't add any new functionality, but I think it's needed before proceeding with some broader modernisation efforts. It also provides a coherent way to address situations where we want to be able to control library-wide defaults, but then to override them on some connections.
Three of the scenarios requiring this are:

SqlClient isn't trim-safe, and the current configuration APIs currently block any progress towards this: the authentication providers and the SqlAuthenticationInitializer are both instantiated using Type.GetType from a string in a configuration file. A strongly-typed equivalent would remove that obstacle.
We currently always load configuration from an app.config file. This isn't a problem for .NET Framework, but newer .NET code uses a different approach - usually DI, although those details aren't particularly relevant. By loosening the coupling between the runtime configuration and its startup source, we open a route for future libraries to integrate with SqlClient, loading their configuration from appsettings.json, Azure App Configuration or similar.
There have been comments in the past about having a DbDataSource implementation, and SqlClientX has SqlDataSource. This is currently built from SqlConnectionStringBuilder, but this implies that any pay-for-play feature enablement such as Azure authentication currently needs to be visible from the connection string. I don't think that needs to be the case - Npgsql has an NpgsqlDataSourceBuilder class with a UseUserCertificateValidationCallback method, which can't cleanly be expressed as part of a connection string. It also has a NpgsqlSlimDataSourceBuilder class which includes methods like EnableIntegratedSecurity and EnableExtraConversions, for use in NativeAOT. SqlClient will likely need a strongly-typed "system options" class of some kind for SqlDataSource, and SqlClientOptions provides a base for that.

The same API surface would also be useful for future development, such as making Azure.Identity optional, custom AlwaysEncrypted enclave providers, custom lists of transient error codes, and possibly cross-platform support for SQL aliases. It effectively provides a platform for providing library-specific configuration where we might want to set global defaults, but have individual overrides of those settings on SqlConnection (and eventually, on SqlDataSource.)
I've based the initial API shape on the three types which load their configuration using System.Configuration:

SqlAuthenticationProviderManager. This loads the authentication providers and the SqlAuthenticationInitializer, as well as miscellaneous configuration (the application's OAuth client ID.)
LocalDBAPI in .NET Framework. If .NET Framework tries to connect to a LocalDB instance which doesn't exist, it'll create the instance based on this.
SqlConfigurableRetryLogicManager, which also uses reflection to locate a SqlRetryLogicBaseProvider derivative.

The API proposal also includes an AppContext switch. Any future trimming support would tell the trimmer to treat the switch as a feature switch and stub away all of the now-centralised references to System.Configuration.
API proposal
namespace Microsoft.Data.SqlClient.Configuration;

public sealed class SqlClientOptions
{
    // Upon first access, if this property hasn't already been set and the relevant AppContext switch is enabled,
    // this will populate an instance from the existing configuration file.
    public static SqlClientOptions Instance { get; set; }

    // Replaces relevant components of LocalDBAPI.
    // Keyed by LocalDB instance name, case-insensitive comparer.
    public Dictionary<string, LocalDBInstanceOptions> LocalDBInstanceOptions { get; set; }

    // Integrates with SqlAuthenticationProviderManager.
    // Maps authentication methods to authentication providers.
    public Dictionary<SqlAuthenticationMethod, SqlAuthenticationProvider> AuthenticationProviders { get; set; }

    // SqlAuthenticationInitializer doesn't have a direct parallel - it's invoked by the constructor.

    // Replaces SqlConfigurableRetryLogicManager
    public ResilienceOptions CommandResilienceOptions { get; set; }

    public ResilienceOptions ConnectionResilienceOptions { get; set; }

    public SqlClientOptions() { }

    // Implements support for SqlAuthenticationInitializer replacement.
    public SqlClientOptions(Action onAuthenticationProvidersInitializing) : this() { }

    public SqlClientOptions Clone();
}

public sealed class ActiveDirectoryAuthenticationProvider : SqlAuthenticationProvider
{
    // OAuth client ID - default to ActiveDirectoryAuthentication.AdoClientId.
    public string ApplicationClientId { get; set; }
}

public sealed class LocalDBInstanceOptions
{
    public string Name { get; }

    public Version Version { get; }
}

// Deliberately not sealed to allow a place for third-party resiliency libraries such as Polly to integrate
// in the future, if required.
public class ResilienceOptions
{
    public SqlRetryLogicOption RetryLogicOptions { get; set; }

    public SqlRetryLogicBaseProvider RetryLogicProvider { get; set; }

    public virtual ResilienceOptions Clone() { }
}

public class SqlConnection
{
    // Existing constructor
    public SqlConnection()
        : this(SqlClientOptions.Instance) { }
    public SqlConnection(string connectionString)
        : this(connectionString, SqlClientOptions.Instance) { }
    public SqlConnection(string connectionString, SqlCredential credential)
        : this(connectionString, credential, SqlClientOptions.Instance) { }

    // Performs a defensive clone of the SqlClientOptions parameter. This is to avoid the behavioural
    // configuration changing underneath an active SqlConnection.
    public SqlConnection(SqlClientOptions libraryConfiguration) { }
    public SqlConnection(string connectionString, SqlClientOptions libraryConfiguration) { }
    public SqlConnection(string connectionString, SqlCredential credential,
        SqlClientOptions libraryConfiguration) { }

    // Returns another defensive clone of the SqlClientOptions, for the same reason as the constructor.
    public SqlClientOptions Configuration { get; }
}

internal static class LocalAppContextSwitches
{
    // Controlled by the AppContext switch "Switch.Microsoft.Data.SqlClient.LoadSqlClientOptionsFromFile".
    // If this is false, the first access to SqlClientOptions.Instance will not use System.Configuration APIs.
    public static bool LoadSqlClientOptionsFromFile { get; } = true;
}

cc @roji

Great to see this @edwardneal.
I'm a bit curious about the need to add support for this to SqlConnection... The new overload would require code changes from users, including passing around the proposed SqlClientOptions instance. At that point, isn't it the same effort for users to just pass around the SqlDataSource instead, and to get the connection from it?
Similarly, once SqlDataSourceBuild supports your config options, I wonder whether it's necessary to introduce an additional "global" mechanism as well. Unlike the SqlConnection overload above, this one makes more sense to me as it allows existing users to just add some lines at program startup and not any other code; but it may make sense to introduce a global mechanism based on user demand rather than up-front, just to see if it's really necessary (see my comments below as well).
Related to the previous point, one thing that isn't clear is whether SqlClientOptions would contain a connection string (above there's an overload of SqlConnection that accepts only a SqlClientOptions, and another that accepts both SqlClientOptions and a connection string). It's important to note that connection options are generally specific to a database, and therefore are strongly tied to a particular connection string - so I think having a SqlClientOptions without a connection isn't likely to be very successful. All this is important especially if you have a global SqlClientOptions - would it close over a connection string (and effectively represent a global, default data source), or just be a bundle of extra config that's applied by default to all connections that get opened regardless of their connection strings (where again, I can see trouble and confusion down the road).
Overall, in Npgsql we've generally gone in the direction of "data source is the right new way to get connections", and have been deprecating/phasing out other ways. For example, there are various configuration options which are only available via NpgsqlDataSourceBuilder; people have been transitioning as they need those features. I get that SqlClient has a different set of users/needs though, so that path may not be appropriate.

Thanks @JRahnama and @roji.
Using the new overload would naturally need code changes, but I expect that the original overloads would remain untouched, behaving is though libraryConfiguration is SqlClientOptions.Instance. I've aimed to preserve the existing behaviour by default, so being able to set per-connection connection resilience options or authentication providers is pay-for-play.
I'm not strongly attached to having the extra constructors on SqlConnection - just having a strongly-typed set of client options which can be reconfigured at runtime unblocks most of the scenarios I'm thinking of: it removes a roadblock for splitting the Azure dependency into a separate package, and removes one of the larger dependencies on System.Configuration (for NativeAOT/trimming support). Those extra constructors are going to be necessary at some stage anyway though: when implemented, SqlDataSource will need to be able to pass its SqlClientOptions instance down to the connections it builds. Making those constructors public rather than internal is just a simple way to let people manually override those settings for a single connection.
To look at your broader point around the data which should be held in SqlClientOptions, the very rough rule of thumb I've used is essentially: this is the existing set of library-wide configuration, collected into one place and with extra functionality to allow per-connection overrides. If SqlClientOptions were ever to contain a connection string, something's gone very badly wrong during the API design.
I don't know where the transition points between connection string key, default value of a SqlConnection property and library-wide default configuration lie though. I actually went around that loop a few times during the initial design - I was originally thinking about including an extra piece of API surface. There's been quite a bit of organic development which blurs these transitions, so I've left the question alone and ported the existing set of configuration as-is.
One particularly strict demarcation might be that the connection string should have all of the information needed to connect securely to a database server under ideal circumstances, and that SqlClientOptions should be considered part of the environment - it should know where the circumstances aren't ideal, and implement a resilience pipeline. That perspective falls apart though: a connection string can contain "Connect Retry Count" and "Connect Retry Interval" keys. I'm not sure what happens if we configure both the SqlClientOptions and the connection string.
Another approach might be that a connection string should result in roughly identical connection processes wherever it's applied. This doesn't quite work either though: Entra authentication relies upon an OAuth client ID which has a sensible default, but can be overridden via an app.config file. Looking more widely, Windows authentication and impersonation can also lead to this failing in ways that a connection string wouldn't necessarily expect.
SqlConnection is also in a similar vein: it has an AccessToken property, which isn't reflected in the connection string. We might think this is because it's got security implications, but that same connection string can contain a SQL login's password (although Persist Security Info does change this slightly.)

I'm not strongly attached to having the extra constructors on SqlConnection - just having a strongly-typed set of client options which can be reconfigured at runtime unblocks most of the scenarios I'm thinking of: it removes a roadblock for splitting the Azure dependency into a separate package, and removes one of the larger dependencies on System.Configuration (for NativeAOT/trimming support).

OK. Just to tease things apart a bit... If/when you split out the Azure dependency into a separate package, users will have to add some gesture to add it back in. IMHO the recommended way there is for users to switch to SqlDataSourceBuilder, where there will presumably be some extension API allowing the Azure plugin to be added.
However, requiring a switch to SqlDataSource in order to use Azure may be a bit much, since it requires a bit of an invasive code change. But here's the thing: if that's indeed true, then the change to use a new SqlConnection overload that accepts an SqlClientOptions is just as invasive; users would have to pass around SqlClientOptions to any place where an SqlConnection is created.
So if the goal is to allow users to e.g. use Azure after it's split away, but without invasive code changes, some sort of static API would be needed, allowing users to drop a line at the program startup that wires things together, and done. This is why I'm not sure about the point of adding a SqlConnection overload accepting SqlClientOptions: I'm not sure which user scenario it actually helps, and has the disadvantages of SqlDataSource (invasive code changes required) but without the advantages.
I'll also point out that the intersection of a SqlConnection constructor accepting SqlClientOptions and pooling is likely to be difficult... When you instantiate a SqlConnection and call Open(), the driver needs to look up the correct pool internally. I'm assuming that at least some of the options on SqlClientOptions would require a different pool to be used; if that's the case, the internal lookup code would have to include the SqlClientOptions (or a subset thereof) in the cache key for the pools. This will make Open() even slower, rather than just using the string. All this goes away with the data source design - no lookups are necessary since the user directly creates the pool (as a data source) and manages it as they want.

Those extra constructors are going to be necessary at some stage anyway though: when implemented, SqlDataSource will need to be able to pass its SqlClientOptions instance down to the connections it builds.

Npgsql indeed has an NpgsqlDataSourceConfiguration, which is probably loosely similar to SqlClientOptions; but it's an internal implementation detail (and one could imagine simply using NpgsqlDataSourceBuilder itself as the container type for the config).

Regarding the demarcation between the connection string and something like SqlClientOptions - I don't think one exists that would make sense and wouldn't be arbitrary. Both are simply mechanisms for specifying options/configuration for a database connection, and the reason we're discussing something beyond connection strings (SqlClientOptions, data source...) is that connection strings are simply insufficient, because they're simple strings.

If SqlClientOptions were ever to contain a connection string, something's gone very badly wrong during the API design.

I think that a SqlClientOptions that's "detached" from a connection string (i.e. doesn't contain it) would end up not working in the general case. The SqlClientOptions needs to be contain config that's specific to a host/database; for example, different databases may require different authentication providers, as well as various other varying configuration - but the host/database is part of the connection string. So IMHO the idea of e.g. a general "config" that's detached from any specific database, and is used with several connection strings, won't end up working/being useful.
I do fully agree that there needs to be one, single type that captures the entire options/configuration for a connection - host, port, logging, authentication, encryption, type mapping tweaks/plugins, everything. This was indeed one of the major ideas behind the DbDataSource concept, which also couples this concept to an actual factory for connections (as well as a connection pool).
One last thing... Taking an even wider view, I think connection strings can basically be considered a legacy concept from the past, and if I were designing .NET's data access story today, I probably wouldn't have them at all (thanks to @NinoFloris for suggesting this direction). In today's world there are good ways to represent configuration/options that are typed, hierarchical and arbitrary; there's something a bit ridiculous about having an appsettings.json with rich configuration, and then sticking a structured old connection string in it as a single JSON property - stuff like the host, database, port, etc. should simply be decomposed into the JSON just like any other configuration. In fact, with the .NET Options pattern, that configuration could even be changed and reloaded at runtime, with the application switching over to another database. I've summarized this direction in https://github.com/npgsql/npgsql/issues/5067.
Of course, I'm not suggesting anyone do away with connection strings :) But I'm definitely interested in thinking about a future where people simply configure everything on NpgsqlDataSourceBuilder (no connection string!), and that can be loaded directly from JSON config.

If/when you split out the Azure dependency into a separate package, users will have to add some gesture to add it back in. IMHO the recommended way there is for users to switch to SqlDataSourceBuilder, where there will presumably be some extension API allowing the Azure plugin to be added.
However, requiring a switch to SqlDataSource in order to use Azure may be a bit much, since it requires a bit of an invasive code change. But here's the thing: if that's indeed true, then the change to use a new SqlConnection overload that accepts an SqlClientOptions is just as invasive; users would have to pass around SqlClientOptions to any place where an SqlConnection is created.
So if the goal is to allow users to e.g. use Azure after it's split away, but without invasive code changes, some sort of static API would be needed, allowing users to drop a line at the program startup that wires things together, and done. This is why I'm not sure about the point of adding a SqlConnection overload accepting SqlClientOptions: I'm not sure which user scenario it actually helps, and has the disadvantages of SqlDataSource (invasive code changes required) but without the advantages.

That's a fair point. SqlDataSourceBuilder will need to be able to pass these options down to the SqlConnection, and my goal was essentially to expose that constructor so that developers can vary from the default library-wide options, even in the absence of the SqlDataSourceBuilder API surface. That'd be a new capability though, and it might make more sense to link it exclusively to SqlDataSourceBuilder.
Just for information around the Azure enablement: once it's split apart, the current plan is to try to use reflection to find the Azure authentication provider, so in a non-trimmed environment the only gesture a developer needs to make to re-enable Azure authentication is to add a reference the additional Azure authentication package. While I wouldn't normally want to introduce cross-package reflection with a greenfield API contract such as SqlDataSourceBuilder or a trimmed environment, I'm more supportive of it here; I think that minimising the breakage of that part of the API contract is more important, given how core Azure authentication is to the use of Azure SQL and how long it's been part of SqlClient.

I think that a SqlClientOptions that's "detached" from a connection string (i.e. doesn't contain it) would end up not working in the general case.

The functionality of SqlClientOptions already exists, it's just scattered and only sometimes accessible via config file. The plumbing of authentication methods to the authentication providers is already available via SqlAuthenticationProvider.SetProvider; authentication providers, LocalDB instances and the retry logic providers are already configured from an app.config file. SqlClientOptions simply brings these together, allowing them to be configured at runtime and decoupling the configuration from its source.
I agree that a lot of these configuration options should be exposed via SqlDataSource; they should override the library-level environmental defaults though. I don't think we should tether them solely to a specific connection string, because the net effect would be that we'd only be able to configure retry logic/etc. in .NET Core by using SqlDataSource or by specifying a .NET Framework-style app.config file. One of the goals of SqlClientOptions is to allow the newer appsettings.json (/etc.) file to be used, if required.

One last thing... Taking an even wider view, I think connection strings can basically be considered a legacy concept from the past, and if I were designing .NET's data access story today, I probably wouldn't have them at all (thanks to NinoFloris for suggesting this direction).

Yes - completely agree here. There are already gaps in the current string-based object model when we start to think about retry logic and server certificate validation, and using SqlDataSource as a strongly-typed model for data source configuration makes sense to me as a step in that direction.
It feels to me that most of the moving DI parts we'd need for that exist. IConfigureNamedOptions could obtain the correct setting values, and then the resultant DbDataSources could be passed through as keyed services.

Just for information around the Azure enablement: once it's split apart, the https://github.com/dotnet/SqlClient/issues/1108#issuecomment-2318156952 is to try to use reflection to find the Azure authentication provider, so in a non-trimmed environment the only gesture a developer needs to make to re-enable Azure authentication is to add a reference the additional Azure authentication package.

I see... I can certainly see the logic here, with the breaking change that would affect lots of people otherwise. I'm unsure on the details of using reflection in this way on a referenced assembly that otherwise isn't used in static code - hopefully it'll work :)

I agree that a lot of these configuration options should be exposed via SqlDataSource; they should override the library-level environmental defaults though. I don't think we should tether them solely to a specific connection string, because the net effect would be that we'd only be able to configure retry logic/etc. in .NET Core by using SqlDataSource or by specifying a .NET Framework-style app.config file.

I don't think there's anything preventing introducing SqlDataSource in .NET Framework - it simply wouldn't extend DbDataSource from System.Data (since it's absent there). This is the current state of affairs in Npgsql 8.0 - there's a DbDataSource.cs shim in the project, which is only compiled in on older .NET. This allows the main NpgsqlDataSource implementation to be always available no matter which .NET version you're using.
Since SqlClient seems to plan to support .NET Framework for the foreseeable future, and in addition is working towards a convergence of the .NET Framework/Core versions as much as possible, I'd recommend going in this direction. At that point I'm not sure why any sort of global usage of SqlClientOptions is needed - can you provide a bit more context on that?

One of the goals of SqlClientOptions is to allow the newer appsettings.json (/etc.) file to be used, if required.

Can you provide a bit more info on what you have in mind here? The application is free to pick up settings from appsettings.json and set them on SqlDataSourceBuilder as it wants; are you thinking of something more automatic where a SqlClientOptions would be able to read directly from appsettings.json, and then used to initialize a data source or connection? If so, that's indeed a scenario we've been thinking about in Npgsql (see #5067 again), but I'm not sure if a separate SqlClientOptions type here is needed as opposed to just initializing SqlDataSourceBuilder itself directly. Basically SqlDataSourceBuilder itself already needs to represent everything you could possibly configure on a connection, so it seems natural to load/initialize that etc.

(BTW feel free to ping me if you'd like to have a chat about this offline!)

Slightly delayed reply here, sorry. Thanks for the offer of an offline chat though - I think we're on nearly the same wavelength, there's just some background context unique to this part of SqlClient.

Since SqlClient seems to plan to support .NET Framework for the foreseeable future, and in addition is working towards a convergence of the .NET Framework/Core versions as much as possible, I'd recommend going in this direction.

I agree, that's definitely the right way to go. There's already a degree of prior art even within SqlClient, in the form of SqlBatchCommand.

At that point I'm not sure why any sort of global usage of SqlClientOptions is needed - can you provide a bit more context on that?

Sure. At present, there are already global options:

Authentication providers are loaded from app.config and programmatically into a singleton SqlAuthenticationProviderManager instance. When a SqlConnection needs to authenticate, it looks up the authentication method to retrieve an authentication provider.
The default retry logic provider for SqlConnections and SqlCommands is lazy-loaded from app.config into SqlConfigurableRetryLogicManager via its static constructor.
Under .NET Framework, SqlClient will create a LocalDB instance if it doesn't exist. To do this, it needs to know the version of the LocalDB instance to create, and this name/version mapping is lazy-loaded from app.config into the internal LocalDBAPI instance.

I'd tentatively also include the registry keys used by SqlClient and ODBC to map from an alias to a SQL Server server name and port, although I've not yet tracked the alias processing end-to-end.
The design for SqlClientOptions isn't to introduce global options, but to gather the existing global options. It maintains compatibility with current app.config files by loading these options from them by default, but also exposes itself publicly via SqlClientOptions.Instance - so we can use the options pattern to set its properties from appsettings.json or another configuration source programmatically.
Separately, we build on this to enable trimming support. Because it's possible to programmatically modify SqlClientOptions.Instance, developers no longer rely exclusively upon app.config files - so we can safely trim away System.Configuration, knowing that we're not eliminating the only way to set the default retry logic provider for a SqlConnection or a SqlCommand, etc.
Building further on enabling programmatic modification of the default retry logic provider: I think that then opens up the potential for a third-party library to build a shim between SqlClient's SqlRetryLogicBaseProvider class and a Polly resilience pipeline.
When we come to implement SqlDataSource, my initial idea is to allow users to pass a SqlClientOptions instance to it to enable specific features, but if we want to use something else (or take a different approach) for SqlDataSource then I think there's still value in the original point (ability to eliminate System.Configuration references via trimming, and to support programmatic modification of the options which are currently only modifiable via app.config.)

SqlDataSourceBuilder itself already needs to represent everything you could possibly configure on a connection, so it seems natural to load/initialize that etc.

I agree with what @roji commented above too. We would be introducing SqlDataSourceBuilder in future that should meet goals for global configuration of the SqlClient library. Adding more options only opens doors to more confusions for customers and leaves us with multiple entry points to deal with.

The design for SqlClientOptions isn't to introduce global options, but to gather the existing global options. It maintains compatibility with current app.config files by loading these options from them by default, but also exposes itself publicly via SqlClientOptions.Instance - so we can use the options pattern to set its properties from appsettings.json or another configuration source programmatically.

The challenge comes down to who takes precedence over the other, when there are multiple entry points to control global options and singletons. One can still modify the instance options to their preference, in a running application. I know we can define precedence flows, document it, but it also opens a new channel of confusions for customers. And if things don't work as users expect or prefer, we cannot take back designs.

Separately, we build on this to enable trimming support. Because it's possible to programmatically modify SqlClientOptions.Instance, developers no longer rely exclusively upon app.config files - so we can safely trim away System.Configuration, knowing that we're not eliminating the only way to set the default retry logic provider for a SqlConnection or a SqlCommand, etc.

AFAIK there are application builders out there who want app.config for various reasons, mainly to abstract configurations from source code. Just want to clarify, for us, app.config is a supported scenario for a .NET application developer to configure various settings and there are no plans to make them obsolete or trim them down.

Thanks @cheenamalhotra.
Your point about the lifecycle of the global options are fair, and I roughly agree. If SqlClient was designed from scratch, we probably wouldn't have those options! I had the simplest case of configuring SqlClientOptions in mind: the global options are configured once at application startup. The lifecycle there is pretty simple. The other case you've mentioned (modifying those options partway through an application's runtime) is where that complexity lies. A developer who does that would get the complexity they asked for, but I agree that it'd be a bad idea for the library to enable that.
Looking at this more broadly, someone enabling IL trimming can't expect perfect backwards compatibility, so it's a question of the best API for that situation going forwards (rather than trying to let people use the existing SqlConnection model with a minor code change.) The DbDataSource pattern seems to be the best way to neatly handle the current global options, so it makes sense to pick up with yours and @roji's point and fold the SqlClientOptions functionality into the SqlDataSource(/SqlDataSourceBuilder?) implementation.
Once SqlDataSource is implemented, the AppContext switch will remain necessary though. Currently, we take a direct dependency on System.Configuration.ConfigurationManager when we use an app.config file. S.C.ConfigurationManager isn't compatible with IL trimming, so making SqlClient trim-compatible means that we need to be able to safely disable this functionality via an AppContext switch. This means that SqlClient will continue to support app.config under normal circumstances, only disabling that support when the user explicitly opts in to IL trimming (or a feature which requires it, such as NativeAOT.)
Where is SqlDataSource on the roadmap? I can see original issue 2119, but is it waiting for an API shape or do the team already have one in mind? I'm happy enough to work on it in a 6.x release, unless someone else is already planning to pick it up?

Good conversation on all aspects. Just to summarize some of my thoughts here:

One thing I'm not sure here is about the need for a public user-facing SqlClientOptions in addition to SqlDataSourceBuilder (i.e. isn't the latter enough).

We did have some interesting thoughts about integrating with Microsoft.Extensions.Options, and there might be a possible angle for that there, but I'm not sure yet.
Basically my recommendation would be to avoid introducing a separate (public-facing) SqlClientOptions unless it solves something important that SqlDataSourceBuilder doesn't address (I'd be interested in hearing about it)
I'd definitely avoid allowing users to initialize connections with SqlClientOptions directly, without having a data source involved. Options are just options, whereas the data source is much more - it e.g. represents the connection pool; since IMHO the right way to create/get connections is via DbDataSource, any API that doesn't do that is (IMHO) legacy...

I don't think either SqlDataSourceBuilder or SqlClientOptions would make a lot of sense for solving the "global configuration" problem (i.e. people not using SqlDataSourceBuilder). I think it's OK to have global/static methods for e.g. registering authentication providers and other things; ideally users would be made to understand that these aren't the recommended way to do things, and would be guided towards SqlDataSourceBuilder instead (anything static/global is a bad approach here IMHO!). In Npgsql we've even obsoleted the global configuration knobs which we had (also from before the data source days) - of course SqlClient doesn't need to go so far.
I'm not sure I see a place for global options which are separate or complement options for connecting to a specific database... In my mind there's a single "closure" of everything that's needed to establish and operate a connection (host, port, SSL/TLS callbacks, all auth stuff, possible type mapping config...).

On the other hand, registration of additional extensible capabilities (e.g. auth plugins) may make sense outside of that closure (e.g. globally). But if a user still needs to select which auth method to use for a given connection, that's just part of the per-connection closure and probably shouldn't exist as a global default that can be overridden for specific connections, etc.

As of now we don't intend to introduce a new API for global options setting, so I will close this API proposal. We want to limit new API introductions to only required and unavoidable APIs at the moment to limit API maintenance surface area.
SqlDataSourceBuilder will be worked upon in future as it comes from ADO.NET (System.Data) stack, based on when it falls in our priorities. Our priorities are reshuffling at the moment to bring back focus on changes/bugs that have been long running and delayed addressing.


  Lotus is one example.  Take a look and see if this is doable and worth it.
https://github.com/filecoin-project/lotus/blob/master/cmd/lotus-shed/proofs.go
https://github.com/filecoin-project/filecoin-ffi

I've received confirmation that merging these changes into Kubo is a goal, so we sill stick with all Go code.


Include all contents of wpt folder in sdist

It looks like the file wptScript.js is not included in the version of bikeshed available in PyPI, which results in the following error:
File "/home/jerivas/.virtualenvs/bike2/lib/python3.9/site-packages/bikeshed/wpt/wptElement.py", line 447, in getWptScript
    with open(config.scriptPath("wpt", "wptScript.js"), "r", encoding="utf-8") as fh:
FileNotFoundError: [Errno 2] No such file or directory: '/home/jerivas/.virtualenvs/bike2/lib/python3.9/site-packages/bikeshed/wpt/wptScript.js'

Steps to reproduce
I found this problem when trying to process a CSS working group spec:
pip install bikeshed==3.3.1
curl https://raw.githubusercontent.com/w3c/csswg-drafts/main/cssom-1/Overview.bs
bikeshed

Ahhhh, indeed, sorry about that. thanks!

I'll cut a new version this afternoon.


articleBody Property missing from NewsArticle

The NewsArticle Class, is missing the articleBody property.
Using it doesn't work.
See the specification here: http://jsonld.com/news-article/

Just merged in the the pull request. Thanks


"No Oxygen" when standing in partial blocks.

Version of Advanced Rocketry
1.10.2-1.2.5a
Have you verified this is an issue in the latest unstable build
N
Version of LibVulpes
1.10.2-0.2.6
Version of Minecraft
1.10.2
Description of the problem
I have a space station, that is completely pressurized. However, whenever I step on/in partial blocks like conduits from EnderIO or open doors from MalisisDoors, it tells me I have "No Oxygen" when clearly I do. This is really annoying since I'm wearing draconic armour which makes an obnoxiously loud noise whenever I take damage.
Please let me know if you need anymore information.

I am also having this problem. I've been using the Malisis Hi-Tech Doors for my station, only to discover that standing in the middle of them registers as having no Oxygen.
I found an old support thread of the exact issue. Judging by it, it seems this issue is well known and difficult to fix.
https://github.com/zmaster587/AdvancedRocketry/issues/625
It would be nice to get an update from zmaster587 on if there's any fixes in the works for this. It's really quite a bothersome issue, but I do understand the complexity behind implementing a fix.

I tried to use an door of theese and the oxygen always leaked through it (even if closed)

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.

To my knowledge this issue was never resolved.


modify NMT::call() input args

NMT::call() method should have same input args signature with build() method (default: 1) so that the entire model can be saved and loaded.

modify input dataset to harness tf model's fit() method.


Usage Docs would be good

Any idea how to use this library?   Maybe some code examples?

Here's a very basic start: https://github.com/hellodigit/node-intuit/pull/6


What does "strong problem" mean on the home page?

SVG icons issue?
If icons do not load:

"check if you did not have strong problem;"

Ah ah, that's a typo... Idk what I've got in mind when I write that ^^'

This will be fixed in the 2.8.0 docs refactor: https://github.com/Alex-D/Trumbowyg/pull/613
(I did not push all modifications ATM)


enables CORS image & makes cropped-image optional

Fix for #18. I only now saw that there were already another fix for this issue, #16 .
It also makes cropped-image optional, as in some cases you just wanna send the crop coordinates and let the backend take care of it.

Awesome thanks!


Latest version ( v0.6.1) does not load content or admin controls on direct navigation to hidden articles

I have just updated to  v0.6.1 and it prompty broke my blog pages.
Expected behavior:

admin sees content
admin sees article settings to change visibility, title, image,

Actual behavior:

admin sees light gray loading bars, no content
hard refresh does not change it
direct navigation does not hcnage it

Going to blog homepage then article loads it, but without the 'article settings' button.
Steps to recreate:

visit any active blog page
from article settings, choose 'hide article'
Only gray content will show.
Settings menu disapears

Workaeround

disable blog extension
restore article (now a discussion)
Reenable blog extension

Thanks for reporting! Issue has been fixed in next release :)


It seems doesn't works on my mbp 2018.

I got Karabiner qq wechat siri and spotlight to hide, but it just showed these icons and did nothing.
It doesn't work when I try too click the arrow icon and auto hiding is also doesn't work.
DEVICE: OSX 10.15(19A583) MBP 15-inch, 2018
VERSION: 1.3(1)

I'm sorry, I put the arrow icon to left side.


Difference responses for a given endpoint?

For example, I have an application that polls for changes. Is it possible to give a set of responses for it to return in sequence?

This is not possible. What is your objective with this? It sounds to me like your trying to test several things at once?

@Crevil the objective its to test a polling service which would only stop polling when the status reaches success or failure. What suggestions do you have for testing a polling service?

I would test the polling action in one test and see that it requests the same endpoint several times. Next up I would make sure it stopped polling on a specific response. This success scenario does not need to test the polling mechanism again, as you already tested this.
Otherwise you could hack something with the dynamics mock APIs, something along returning one mock. After some delay push in a new response. But this relies on the time aspect of execution, which I don't like.

Further more, I expect you to be e2e testing your application. This is, to me, more of a unit test, no?

@Crevil Fair point, and solid advice. Yes, I am also running an e2e test for it.


Wekan.sh enable email invitations and other issues

Hi, i just want to share something that i've discovered using that app with docker,  when creating the systemd unit you could ask the user to set a smtp server to send email, and then add that strings to the unit:
Environment=MAIL_URL=smtp://user:password@smtpserverport:port/                                                                               Environment=MAIL_FROM=emailaddress
The other thing is the update script that i don't fully understand because:
at line 3:  [ $1 = update ] && { systemctl stop wekan; rm -rf /home/wekan/bundle; }
but at line 35 mv bundle Wekan
so when $1=update you are trying to delete /home/wekan/bundle which doesn't exist anymore, because at line 35 you've renamed bundle to Wekan.
Thank you for creating all of this set of scripts, you saved me  a lot of time!

Thanks you too! You're right, I've done some changes. Now it will just be /home/wekan/*, the bundle content will be directly extracted to the current directory /home/wekan.
Anyway, DPlatform / systemd aren't designed for Docker, even if it works. Docker shouldn't need systemd because it run an app with parameters set in the Dockerfile when the container is launched. I plan to create a DPlatform Docker project.

The two environment variables are indipendent from docker, they belong to wekan, some time ago i've compiled wekan from source, and following their guide you need to export some variables https://github.com/wekan/wekan/wiki/Install-and-Update#manual-installation-steps.
So in my raspbian, i went to /etc/systemd/system/wekan.service and added the two lines above (with my credentials) and email starts working. The drawback is that the password will be stored in plain text inside the unit.

Fixed. I haven't added the email environment variables asked with a message box, because it doesn't appears to be needed to have a working Wekan, finally that most people research.


On-boarding tutorial

Fixes #216
Text setup in rich menu to trigger tutorial should be:
📖 tutorial (en)
📖 教學 (zh-tw)

Pull Request Test Coverage Report for Build 1177

40 of 87 (45.98%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.7%) to 81.315%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/webhook/handleInput.js
1
4
25.0%

src/webhook/handlers/tutorial.js
23
67
34.33%

Totals

Change from base Build 1170:
-3.7%

Covered Lines:
741

Relevant Lines:
904

💛  - Coveralls


Update coverage.py

yaml.round_trip_dump(... was found deprecated.
Not sure if this change is relevant to every one. Even if it is not merged, let's keep it hanging here for those who find issues in generating test using rvvatg.

OK I see that it's because your ruamel.yaml version (maybe 0.17) is higher than mine. My version is 0.12 and the original file works fine.
I will merge it since to adapt the more widely used version of yaml.


Added example usage of the 'update' function.

I was unable to find a usage example of the update function. After trying a few different things, I came up with the following usage. Please let me know if you have any other examples of usage.
This would address issue #4

This is good, thanks! Can you add type signatures too please? It would make it even clearer. :-)

Yeah.  Type signatures added.

Thanks very much for this. Sorry the merge is so long overdue! :-(


prev_pred_embds

Thanks for the implementation.
Is this correct? Specifically using the next_thoughts with the delayed_prev_word_embeddings and the prev_thoughts with the delayed_next_word_embeddings?
I was looking at a TF implementation and didn't see this approach implemented. If it's correct can you explain why?
Thanks,

I do think it's correct. But I agree it might seem confusing at first. I'll try to explain.
Let's say we are trying to generate the next sentence word by word. We do this conditioned on the Thought vector of previous sentence. Also we want to guide the generation process by teacher forcing. In teacher forcing you feed the RNN the word by word ground truth of the sentence that you are actually predicting which in our case is the next sentence. But you give the word by word ground truth after a delay of one word.
Similar argument can be made for the prediction of previous sentence.
Hope this helps!

I think I understand what your suggesting and why given the way you handle the training data it's setup in this manner.
If I follow, thoughts would be represented by t_0 and you need to step backwards and forwards to predict both t_-1 and t_1.
t_-1 = prev_thoughts
t_0 = thoughts
t_1 = next_thoughts

It would seem to me that if you randomly selected t_0 for a given batch size, and maybe implement bucketing so the texts are of approximately equal length, then you could retrieve and encode the corresponding t_-1 and t_0 for each t_0 in the batch and then prev_pred_embds and next_pred_embds would be conditioned on the t_0 values in the batch, correct?
Cheers,

Just one correction
t_0 = prev_thoughts
t_1 = next_thoughts

The thoughts of each t_0 predict sentence of the corresponding t_1 and thoughts of each t_1 predict the sentence of the corresponding t_0.  There is no t_-1 as they do in the original paper. Sorry for the confusion :/
Best,

ah. that's helpful.
thanks

No problem :)


Relation between fulfilment and leg within a through fare

A fulfilment has a relation to one or more bookingParts and a bookingPart is for a trip with one or more legs. There is however no relation between a fulfilment and leg
In cases where a bookingPart covers multiple legs, for instance a through fare, and each leg has its own fulfilment it is not possible to link that directly to a leg.
Example:
- trips[]
  - id: 1
  - legs[]
    - timedLeg: A > B
    - timedLeg: B > C

- bookedOffer
  - admission
    - id: abc
    - tripCoverage
       - coveredTripId: 1

- fulfillments[]
  - fulfilment
    - id: 1
    - bookingParts[abc]
   - fulfilment
    - id: 2
    - bookingParts[abc]

How can we link that fulfilment 1 is for leg A > B and fulfilment 2 is for B > C?
Especially with through fares of different operators this can be confusion or even cause settlement issues.

Problem: the same through fare links to multiple fulfillments (e.g. one per leg) as multiple operators are giving out their own fulfillments. They each have individual control numbers and operator codes.
This means that multiple fulfillments point to the same BookedOfferPart, but the model doesn't have a way to distinguish them.

Suggest one of these to model this link. Most simply, add a string-array to the fulfillment element detailing which legs, as provided in the trip element of the booking, are affected by the fulfillment.

Alternately, to more closely mirror the way the booking parts are handled, same principle but using a LegReference element to detail the affected leg. This would allow for extending the amount of information provided without breaking the schema later:

Finally, to create a more robust link between the trip and the fulfillment, a TripCoverage element as previously defined could be added to the fulfillment outright.

TODO patch for next meeting --> Roland

https://github.com/UnionInternationalCheminsdeFer/OSDM/tree/feature/489

@rolandkla Could you also create the merge request? If I create one, I can't approve it being creator of the MR.

Unfortunately DB cannot support multiple fulfillments per Admission.

Examples for the cases are needed by DB

Through-fare with the same operator on both (all) legs will give one admission but one fulfillment per leg. (SJ)


Better Parse errors

Sometimes the parser spits out some awful parse errors

Closed because it's too general.


Compilation error master branch

./waf configure build
Setting top to                           : /mnt/repos/cquery
Setting out to                           : /mnt/repos/cquery/build
Checking for 'clang++' (C++ compiler)    : not found
Checking for 'g++' (C++ compiler)        : /usr/bin/g++
Checking for header stdio.h              : yes
Checking for clang
Found extracted at build/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04
Checking for library clang               : yes
Clang includes                           : ['/mnt/repos/cquery/build/release/lib/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04/include']
Clang library dir                        : ['/mnt/repos/cquery/build/release/lib/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04/lib']
'configure' finished successfully (0.303s)
Waf: Entering directory `/mnt/repos/cquery/build/release'
[88/88] Linking build/release/bin/cquery
src/lsp.cc.1.o: In function `lsDocumentUri::SetPath(AbsolutePath const&)':
/mnt/repos/cquery/build/release/../../src/lsp.cc:259: undefined reference to `AbsolutePath::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >() const'
src/lsp.cc.1.o: In function `GetPath':
/mnt/repos/cquery/build/release/../../src/lsp.cc:44: undefined reference to `AbsolutePath::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >() const'
src/project.cc.1.o: In function `Project::ForAllFilteredFiles(std::function<void (int, Project::Entry const&)>)':
/mnt/repos/cquery/build/release/../../src/project.cc:767: undefined reference to `AbsolutePath::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >() const'
src/project.cc.1.o: In function `Project::FindCompilationEntryForFile(AbsolutePath const&)':
/mnt/repos/cquery/build/release/../../src/project.cc:731: undefined reference to `AbsolutePath::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >() const'
/mnt/repos/cquery/build/release/../../src/project.cc:731: undefined reference to `AbsolutePath::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >() const'
src/project.cc.1.o:/mnt/repos/cquery/build/release/../../src/project.cc:749: more undefined references to `AbsolutePath::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >() const' follow
collect2: error: ld returned 1 exit status

Waf: Leaving directory `/mnt/repos/cquery/build/release'
Build failed
 -> task in 'bin/cquery' failed with exit status 1 (run with -v to display more information)

I also experience problems building the master branch on Linux:
-*- mode: compilation; default-directory: "~/.emacs.d/src/cquery/" -*-
Compilation started at Thu May 17 08:52:53

./waf configure build
Setting top to                           : /home/micke/.emacs.d/src/cquery
Setting out to                           : /home/micke/.emacs.d/src/cquery/build
Checking for 'clang++' (C++ compiler)    : /usr/bin/clang++
Checking for header stdio.h              : yes
Checking for clang
Found extracted at build/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04
Checking for library clang               : yes
Clang includes                           : ['/home/micke/.emacs.d/src/cquery/build/release/lib/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04/include']
Clang library dir                        : ['/home/micke/.emacs.d/src/cquery/build/release/lib/clang+llvm-6.0.0-x86_64-linux-gnu-ubuntu-14.04/lib']
'configure' finished successfully (0.398s)
Waf: Entering directory `/home/micke/.emacs.d/src/cquery/build/release'
[ 1/89] Compiling src/messages/workspace_symbol.cc
[ 2/89] Compiling src/messages/cquery_file_info.cc
[ 3/89] Compiling src/file_contents.cc
[ 4/89] Compiling src/clang_system_include_extractor.cc
[ 5/89] Compiling src/clang_cursor.cc
[ 6/89] Compiling src/cache_manager.cc
[ 7/89] Compiling src/messages/text_document_definition.cc
[ 8/89] Compiling src/code_complete_cache.cc
[10/89] Compiling src/working_files.cc
[11/89] Compiling src/messages/text_document_code_lens.cc
[12/89] Compiling src/utils.cc
[13/89] Compiling src/import_pipeline.cc
[14/89] Compiling src/timestamp_manager.cc
[15/89] Compiling src/messages/shutdown.cc
[16/89] Compiling src/third_party_impl.cc
[17/89] Compiling src/clang_format.cc
../../src/utils.cc:416:12: error: no viable conversion from returned value of type 'std::string' (aka 'basic_string<char>') to function return type 'optional<AbsolutePath>'
    return result;
           ^~~~~~
../../third_party/optional.hpp:403:13: note: candidate constructor not viable: no known conversion from 'std::string' (aka 'basic_string<char>') to 'std::experimental::nullopt_t' for 1st argument
  constexpr optional(nullopt_t) noexcept : OptionalBase<T>() {};
            ^
../../third_party/optional.hpp:405:3: note: candidate constructor not viable: no known conversion from 'std::string' (aka 'basic_string<char>') to 'const std::experimental::optional<AbsolutePath> &' for 1st argument
  optional(const optional& rhs)
  ^
../../third_party/optional.hpp:414:3: note: candidate constructor not viable: no known conversion from 'std::string' (aka 'basic_string<char>') to 'std::experimental::optional<AbsolutePath> &&' for 1st argument
  optional(optional&& rhs) noexcept(is_nothrow_move_constructible<T>::value)
  ^
../../third_party/optional.hpp:423:13: note: candidate constructor not viable: no known conversion from 'std::string' (aka 'basic_string<char>') to 'const AbsolutePath &' for 1st argument
  constexpr optional(const T& v) : OptionalBase<T>(v) {}
            ^
../../third_party/optional.hpp:425:13: note: candidate constructor not viable: no known conversion from 'std::string' (aka 'basic_string<char>') to 'AbsolutePath &&' for 1st argument
  constexpr optional(T&& v) : OptionalBase<T>(constexpr_move(v)) {}
            ^
1 error generated.

Waf: Leaving directory `/home/micke/.emacs.d/src/cquery/build/release'
Build failed
 -> task in 'bin/cquery' failed with exit status 1 (run with -v to display more information)

Compilation exited abnormally with code 1 at Thu May 17 08:53:04

Fixed in https://github.com/cquery-project/cquery/commit/e8d44f707843aaac6150638bc3834e36925d524e, sorry about that.


[Hexagon] Enable broken tests

We have updated HDK boards firmware and they are passing these tests now. Fixes https://github.com/apache/tvm/issues/11957
Thanks to @supersat!
cc @csullivan

cc @cconvey


Possibility to use own Loading Indicator

Hi @brianegan
It not so hard - to add one more param - Widget loadingIndicator - to use own loading indicator.
If you have no time, let me do that.
Thanks

any update on this ?

It's been 6 years and still no update on such basic functionality :(


Keep getting TOKEN_FETCH_ERROR, where do I put the .p8?

I keep getting TOKEN_FETCH_ERROR:
TOKEN_FETCH_ERROR
public static final TokenError TOKEN_FETCH_ERROR
indicates error in fetching music token, say due to developer token invalid/exipred.
I have the token.xml changed but have no idea where to put the p8 key.

Hi, @marc-lassiter I am trying to integrate apple music into my android application. I am also facing a similar issue and unable to find any solution. If you found a solution for this could you please help me to resolve this error?

Hi, @marc-lassiter I am trying to integrate apple music into my android application. I am also facing a similar issue and unable to find any solution. If you found a solution for this could you please help me to resolve this error?

I hope this help
Install https://www.npmjs.com/package/apple-music-token-node
Use cli mode
input the apple team id
input the music key id
drag the .p8 to the terminal
Then copas the ouput developer token to tokens.xml (or create tokens.xml first)
This app is working 100%.


Foot Terminal dracula dark theme

A theme for foot: A fast, lightweight and minimalistic Wayland terminal emulator
Theme did not exist that is why I made it.
https://github.com/syrofoam/dracula-foot/tree/master

Great @syrofoam! I just sent you an invite to join the organization.
Once you accept it, you'll be able to transfer the repo and I'll take care of adding it to the site.
Thanks for building this! 🎉

Hi, I went ahead and created it under the 'application' name and finished setting it up.
Let me know if anything is missing or something.
No problem, I hope everything is smooth looking for those who want to try it out!

@syrofoam looks like you accepted the invitation to join the org, but still haven't transferred the repository.
Here are some instructions: https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository#transferring-a-repository-owned-by-your-user-account

Could I just delete the 'mirror' repo on my personal github and only use the repo on dracula?. They both seem to be 'forks' of the template and are 'ahead' of the template. And if I want to just move it I have to delete the repo witch exist for it has the name already. github.com/dracula/foot
You think that's okey solution? I'm not that skilled with git so thanks for the link.

@syrofoam I made some changes to the installation instructions, can you take a look? https://github.com/dracula/foot/commit/f3bb85d3b8bf0bc4038511cd4061a00feb4e2aca
Feel free to delete the https://github.com/syrofoam/dracula-foot/tree/master repo now.

It's finally live! https://draculatheme.com/foot-terminal
Thanks @syrofoam ;)


NeumorphButton Wont Draw properly

Version used: latest
Devices/Android versions reproduced on: Galaxy 10+, Pixel 3, Pixel 3+
I'm trying to do a NeumorphButton on a RelativeLayout that is in another RelativeLayout but it does not draw it correctly at all...
<soup.neumorphism.NeumorphButton
            android:id="@+id/button_login_or_register_alert"
            android:layout_width="200sp"
            android:layout_height="100sp"
            android:text="@string/login_or_register"
            android:textColor="@color/neu_text_color"
            android:layout_centerInParent="true"
            android:textAllCaps="false" />

HI @LidorPrototype, I could be wrong, but first, try not to use "sp" for layout_width and height, instead use "dp" which is recommended in most cases, sp use just for text...
second, try to apply these two lines to your code...
1- style
2- neumorph_shapetype

Hey, sadly still the same problem is happening...


Make proxy runnable in standalone mode

Actually review the existing standalone mode and make it work to run the proxy in standalone mode.

Can be closed as to be implemented at here: https://github.com/website-magyar/mitmJavaProxy/issues/5

See also wiki page about it here.


flicker on overlaps in parking layer

We've got a building https://www.openstreetmap.org/way/365404293 and a parking lot https://www.openstreetmap.org/way/26393442 fighting for z-order. I'll look into scraping layer for parking lots. But also, maybe building=roof should be filtered out...

Note that flicker is present also in other cases where building=roof filtering will not help, see


Coveralls tests should be correctly configured, nothing is tested as of now

Even if it's actually quite convenient, coveralls tests should be fixed to actually do some code coverage tests...

This can be fixed by using the right name of the package instead of cloud_info

This may only impact people using the pip module, and we don't expect to have any production deployment of it, so it's probably quite safe, no?

You mean this?
https://pypi.org/project/cloud-bdii-provider/
Because that's just so outdated...
The impact would be anyone using this module externally, which I highly doubt.

Should I submit a PR to the big merge for this?

No in fact using with pip install . and they would have multiple cloud
info
On Thu, Sep 13, 2018, 10:49 Enol Fernández<EMAIL_ADDRESS>wrote:

You mean this?
https://pypi.org/project/cloud-bdii-provider/
Because that's just so outdated...
The impact would be anyone using this module externally, which I highly
doubt.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EGI-Foundation/cloud-info-provider/issues/101#issuecomment-420932534,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbjWSGlGEHfWcFZczjdD_f7wd-4cQsCks5uahwigaJpZM4WUyn5
.

--
Baptiste Grenier
EGI Foundation - Operations Officer
Phone:              +31 627 860 852
Skype:         baptiste.grenier.egi

No in fact using with pip install . and they would have multiple cloud info

I would consider that a "development environment" and assume the developer knows what is doing.

Closing as it was merged to the big GLUE 2.1 rebase PR: #99


wkhtmltopdf 0.12.6

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

/azp run

Messed up the commit.


GitXL shows "junk" after regular diff on XLA file and freezes SourceTree

I am using GitXL with SourceTree and after the fix due to Microsoft's last changes to the VBA project structure we were glad to receive the updated GitXL version 0.5.1. But now in our history we see lots of "junk" code when viewing our XLA add-in. When switching back to GitXL 0.5.0 everything is fine, but then we need to use very old Office version to safe the files in a readable format.
There was the suggestion to change from XLA to XLAM because this our other add-in and this doesn't show such behavior, but the history is already checked in and can't be changed. We may think about changing the file type in the future, but also rely on several internal and external factors.
I can't tell if this is a bug or just something that needs to be adjusted on my side. I already installed several versions of SourceTree and also Git. My colleague who works in a different country doesn't have this issue and I already installed and tested on a VM and face the same behavior. We even compared our settings. Only difference are the language settings of Windows, but I also already tried switching from German to English without success.
It results in heavy slow-down and partial freezes of the whole program making it almost unusable. So I would need help to find out what could cause this and how to solve it.
Here is a screenshot that shows the huge load of "junk" code (I guess it's reading the complete file structure?). See the scrollbar is rather much at the upper part, even though we had many code changes (even though some were only automatically changed case sensitives...). Starting with the red /dev/null line the things become unusual.

Can you attach a sample XLA file to reproduce the issue? This kind of looks like a log dump to me from https://github.com/decalage2/oletools not sure why that would be triggered. Conversion to xlam is definitely recommended.

I am not allowed share my own project's XLA file externally. But if I find some time next week, I'll try to create an example, even though this will be much smaller.
As already written, we can't convert our check-in history and also in our work we have several factors that are against converting our current state right now.

I tried a little bit with a fresh dummy XLA file but it didn't seem to work. Now I've tried to delete all specific sheets, values and code from my project's XLA file. Then renamed it and erased all project information from the document properties, changed the VBA project name, kicked out even more code modules to make it easier for you to read the file. When all looked clean in Excel and the VBA editor, I saved the state and uploaded on my gitlab playground. Then just changed one bit in a general function and the junk still shows up. Now with the heavily reduced file content, it comes to an almost acceptable performance in SourceTree but this won't help me for my project as loading the whole file structure kills everything. I wonder what could cause this. It's still there even after deleting so much (> 99 %). I attach the two XLA files with only 1 code line diff here. Just make sure to push one in SourceTree and then rename the other file to have the same name and you can already see it in the commit screen. There are 7 rather small modules left, but in general there is no real automatic functionality left. Just some dummy code to make the situation visible.
VBAtest.zip

Looks like the file is corrupt. When I open it on macOS, I get:
Compile error in hidden module: 'mdlGUID'. This error commonly occurs when code is incompatible with the version, platform, or architecture of this application.

I am working on Windows, never got anything else. But the code works on Windows clients with Office 32 bit.

gotcha, didn't expect the file to be password protected, so I couldn't see it's Windows-only. I still don't have a better answer though other that there's something going on with the file (even though Excel can cope with it).

Sent the PW via mail to you in case it helps. The code could be compiled on my 2 clients without issues, as these are leftovers of our main project which many people are using. I can't imagine that the error is on the file, as the users of the original project would have gotten this error too then. Also there is not much left anymore in the test file. Is GitXL somehow working differently? Spreadsheet Compare from Microsoft also shows only the changed code line and no junk.

@fzumstein Are the any news from your side? Could you find out why the junk appears?

No, but I would start a new xla from scratch (or xlam for that matter) and copy/paste all the code. Something is off with the file.

Thanks for your reply. It's simply too much to carry over to a new file.
I already placed the suggestion in my dev team to switch from old file types (XLS, XLA) to modern file types (XLSX, XLAM), which would definitely have less effort on our side. Some years ago when we started a derivative add-in based off our main add-in we directly converted to XLAM without any issues on our and user side. Just need to change few XLS file mentions in my VBA code to XLSX and rewrite our Inno setup script also to remove old XLA/XLS files from the app folder when installing the add-in, should be no big deal. I just had to wait for a good time in my project to convince my project manager. ;)
Just hoping the type conversion removes the junk. I will install the current GitXL version to verify. But it may take some time as we need to bundle this with our feature development. We only check in final states.
I've so far only seen some annoying case sensitive findings, but Spreadsheet Compare also shows them, e. g. Worksheets.count VS Worksheets.Count. Even though I didn't touch the code there. Maybe MS screws up some things again. Or because my colleague and I have different region settings as he is located in another country where German is not the default. I prefer to have only real diffs shown because with more diff lines the performance becomes so bad when you want to scroll through in Source Tree. Not sure which of the tools is responsible for the performance.

I did a quick test and converted the add-in to XLAM and it looks fine for future check-ins.
Unfortunately our history with checked-in XLA files still have the whole junk so I deeply hope, that this will still be fixed. Our history goes back some years and the junk causes the whole app to freeze when you want to look up on previous changes.


error when selector does not match anything

If I run helmfile -l name=bob sync and we have no release named bob I would expect helmfile to exit with an error.  Currently it exists with a code of 0.

Good catch! Thats should be fixed.

I just encountered the opposite of this. If I have nothing that matches the selector, I would expect an error but I would also like to silence this or have a seperate error to the normal error.
Mainly I use helmfile in this way:
helmfile -f ./path/to/helmfile --selector state!=active delete
helmfile -f ./path/to/helmfile --selector state=active sync

This allows me to delete from code rather than manually. The problem is when there is nothing to delete, helmfile errors out. This should be a different error to when something is failing to delete.

@lswith Good point!
Would an exit code of 2 suffice your need?

@lswith Anyway, opened #219 for that.

I'm closing this as the original issue has been resolved via #165


RecordRF not working

I have a Broadlink RM Pro+ that I'm trying to get working. I send "recordrf" to the MQTT channel and broadlink enters recording mode but never manages to capture the command. I am able to record RF with other applications (broadlink-mqtt-bridge and e-control), so I know broadlink and the RF device work. Is this feature working? Thanks.
[2019-08-08 06:29:11,414] DEBUG Recording RF command to file /opt/broadlink-mqtt/commands/rollershutter/2/up
[2019-08-08 06:29:11,414] DEBUG Learning RF Frequency, press and hold the button to learn...
[2019-08-08 06:29:32,773] WARNING RF Frequency not found```

Hi, this is an experimental feature and I have no appropriate device to check if it is working
If you do not mind you can be my tester for it :)
I can add some code and ask you to recheck, OK?

Sure, happy to test it...

Rechecked the code - it looks OK
Do you follow the instructions? You need to press and hold the button during the first message (Learning RF Frequency...) and single press when second (To complete learning...) message is print

Yes, I did the same thing I do with broadlink-mqtt-bridge, which seems to work. It doesn't find the frequency with a press and hold. broadlink-mqtt-bridge waits for 30 seconds, and sometimes it might take 10 seconds or so.

Can you please try to record a signal using broadlink_cli utility from python-broadlink project?

Same thing with broadlink_cli. It enters learning mode, but can't find the frequency.
I'm assuming after it finds the frequency it should tell me to do the short press to learn the code?
RF Frequency not found```

I checked instructions from https://github.com/mjg59/python-broadlink/issues/87 and found that tests were done using:
python3
pycrypto python package

python3 and pycrypto are already installed...

And do you run mqtt.py or broadlink_cli using python3?

Good point! :)
I just ran broadlink_cli with python3 and got a bit further. 1/4 attempts crashed, 3/4 attempts found the freqency but couldn't find the RF code.
Attempt 1:
Learning RF Frequency, press and hold the button to learn...
Found RF Frequency - 1 of 2!
You can now let go of the button
Press enter to continue...
To complete learning, single press the button you want to learn
No data received...

Attempt 2:
Learning RF Frequency, press and hold the button to learn...
Traceback (most recent call last):
  File "./broadlink_cli", line 195, in <module>
    while (not dev.check_frequency()) and (timeout > 0):
  File "/usr/local/lib/python3.6/dist-packages/broadlink/__init__.py", line 565, in check_frequency
    response = self.send_packet(0x6a, packet)
  File "/usr/local/lib/python3.6/dist-packages/broadlink/__init__.py", line 298, in send_packet
    response = self.cs.recvfrom(2048)
socket.timeout: timed out

Attempt 3:
Learning RF Frequency, press and hold the button to learn...
Found RF Frequency - 1 of 2!
You can now let go of the button
Press enter to continue...
To complete learning, single press the button you want to learn
No data received...

Attempt 4:
Learning RF Frequency, press and hold the button to learn...
Found RF Frequency - 1 of 2!
You can now let go of the button
Press enter to continue...
 I got:
File "mqtt.py", line 67
    except Exception, e:
                    ^
SyntaxError: invalid syntax

guys how do you run mqtt.py with python3? I got:

Committed the fix to support python3


Gather information for endgame screen

Were they spotlit?
Were they hanging?
Did they get harmony?
Did they trap?
Did they get coopertition?


remove timestamps from api layer

introducing inserted_at and updated_at fields into the api change breaks omg-js, so removing them for now.
yolo

3 more test fixes and we're good 🎉 🎉 🎉

Yeah, saw that, thanks. Was just letting circle do the work in this case to save time. 😒 That never works, does it.
Those tests should now pass. 🤞

Coverage decreased (-10.8%) to 75.415% when pulling dc6dfa3784fe9b9ee6fdc8f35af7c7df08121d0a on jacob/remove-api-timestamp-columns into f195f597c093177b887342980dd0301c47adb7ee on master.

no longer removing timestamps that was causing omg-js issues. omg-js has been relaxed to accept new keys in the PR https://github.com/omisego/omg-js/pull/252


Improve Logging in Data Science Pipelines pods

Every time we need to enable debug logging in DSP components (API Server, persistence agent, scheduled workflow), it is a pain to make it work. We need to enable logging through manifest parameters and inject through env var in all pods to enable debugging.

The initial scope of the task was around just making manifest changes to our midstream repo. On further investigation, we figured that we would need to make changes to the code base as well (main.go for ever component), irrespective on whether we choose to use logrus or glog/klog packages for setting logging levels.
For example, Persistence Agent doesn't have the glog package imported: https://github.com/opendatahub-io/data-science-pipelines/blob/master/backend/src/agent/persistence/main.go#L26
We would need to import the package, and also add some code the way we've added in this PR, to make sure we have a log-level cli parameter, through which we could pass a value and set the variable for the desired log level.
Similarly, we would need to update the code base for APIServer and Scheduled Workflow components as well. Hence, this change needs to go into the upstream kfp-tekton repo first.

Closing this task since this change needs to go into upstream first. Created #158 to address this for v2.


NaN values in K3 of MBTR when using "angles" as the geometry function

Package versions:

ase 3.17.0
dscribe 0.2.6
Python 3.7.1

Download the XYZ file : https://users.aalto.fi/~ghoshk1/data.xyz
from dscribe.descriptors import MBTR

def make_mbtr_desc(atomic_numbers, max_atomic_number, min_atomic_number,
                 min_distance, decay_factor):
    mbtr_desc = MBTR(
        species=atomic_numbers,
        periodic=False,
        k1={
            "geometry": {
                "function": "atomic_number"
            },
            "grid": {
                "min": min_atomic_number,
                "max": max_atomic_number,
                "sigma": 0.2,
                "n": 200
            }
        },
        k2={
            "geometry": {
                "function": "inverse_distance"
            },
            "grid": {
                "min": 0,
                "max": 1 / min_distance,
                "sigma": 0.02,
                "n": 200,
            },
            "weighting": {
                "function": "exponential",
                "scale": decay_factor,
                "cutoff": 1e-3
            },
        },
        k3={
            "geometry": {
                "function": "angle"
            },
            "grid": {
                "min": -1.0,
                "max": 1.0,
                "sigma": 0.09,
                "n": 200,
            },
            "weighting": {
                "function": "exponential",
                "scale": decay_factor,
                "cutoff": 1e-3
            },
        },
        # flatten = False
    )

    return mbtr_desc

The respective variables in the MBTR definition above were obtained as follows:
import ase.io
from dscribe.utils.stats import system_stats

xyz_file = "./data.xyz"
ase_atoms = list(ase.io.iread(xyz_file, format="xyz"))

# Load in statistics from the dataset
stats = system_stats(ase_atoms)
atomic_numbers = stats["atomic_numbers"]
max_atomic_number = stats["max_atomic_number"]
min_atomic_number = stats["min_atomic_number"]
min_distance = stats["min_distance"]

decay_factor = 0.5

mbtr_desc = make_mbtr_desc(atomic_numbers, max_atomic_number,
                           min_atomic_number, min_distance, decay_factor)

Now create the MBTR for the 26th atom and check for Nan
m = mbtr_desc.create(ase_atoms[25])
np.isnan(m).any()

However, if the K3 in MBTR is definition to use cosine function instead of angle then Nans don't show up

Hi @kunalghosh,
Thank you for reporting the issue! The problem is now fixed in the git master branch, and the fix will be included in the next release (>= 0.2.8).
The problem was that sometimes, due to floating point imprecision, the cosine values were ever so slightly outside the range [-1, 1]. This caused NaNs when the inverse cosine was called to get the angle.


wrap / nowrap on overflow #2

On overflow, if the word gets larger than row width and larger than window width, it doesn't get wrapped.

Maybe word-wrap attribute can solve it?


Error recovery

Right now an unhandled exception ends the server for good. It would be nice to catch and log it or to automatically restart the server.

Duplicate of #94. I'm closing this one.


Syncing with upstream minimal-slp-wallet

:tada: This PR is included in version 1.1.5 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Create codeql-analysis.yml

Add security scanning to repo.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #45 (05d9c6c) into main (961a226) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   94.04%   94.04%
=======================================
  Files          38       38
  Lines         940      940
  Branches      132      132
=======================================
  Hits          884      884
  Misses         38       38
  Partials       18       18

Flag
Coverage Δ

unittests
94.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961a226...05d9c6c. Read the comment docs.


Not able to get products (empty product array) on xCode 12.3. But working successfully on xCode 11.3 & 12.1

Version of react-native-iap
"react-native-iap": "^5.1.1"
Version of react-native
"react": "16.13.1",
"react-native": "0.63.2",
Platforms you faced the error (IOS or Android or both?)
IOS
Expected behavior
Should Load products which are defined in apple console on xCode 12.3
Actual behavior
Getting empty array of products when calling RNIap.getProducts(itemSkus);
It is successfully working on xCode 11.3 & 12.1 but not getting products on 12.3
Tested environment (Emulator? Real Device?)
Both Real device and Simulator
Steps to reproduce the behavior

Building project on xCode 12.3
try to load products using RNIap.getProducts(itemSkus);
Getting empty list of products

Any luck on this?

Any luck on this?

i think you should try with storekit configuration

i think you should try with storekit configuration

@RahulRijhwani Just set up the storekit configuration file and enabled it in my scheme, but still returning undefined.

@RahulRijhwani Just set up the storekit configuration file and enabled it in my scheme, but still returning undefined.

I am getting undefined , any update on this?

I am getting undefined , any update on this?

you need to add your products and subscriptions on Storekit configuration.

you need to add your products and subscriptions on Storekit configuration.

@RahulRijhwani I am new to the Apple products, no idea how to set

@RahulRijhwani I am new to the Apple products, no idea how to set

I have a real device, all made in App Store Connect, because the array
it's empty? I don't want to configure Storekit because the app crashes when entered

Looks related to this. Currently, I am also using StoreKit. https://stackoverflow.com/questions/58020258/requesting-an-in-app-purchase-in-ios-13-fails/58065711#58065711.
Still wondering how I can avoid this.

I dealt with this issue a lot in iOS, and I found there could be a lot of causes for an empty result, all depending on the environment and setup. I went ahead and wrote a checklist in #723
@hyochan Would it be feasible to throw an error when passing an empty array to getProducts in the iOS wrapper? Since the getItems module won't throw an error when an empty array is passed, I can imagine that could be one contributor to the empty getProducts result.

Where do I get this storekitConfig file?

This was reported long ago and with a very old version of the library. Please reopen/ create a new issue if this is still happening on 8.x.x

Where do I get this storekitConfig file?

Try this: https://developer.apple.com/documentation/xcode/setting-up-storekit-testing-in-xcode

For reference we have included one in the example app: https://github.com/dooboolab/react-native-iap/blob/main/IapExample/ios/Configuration.storekit

Trying storekit now, hope it works...but also curious: is Storekit a must?