[BUG] TS0501 Fan Controller changes behaviour once paired

Describe the bug
I have installed 7x Mercator Ikuu TS0501 Fan Controllers in my home. Before they are paired, the physical "fan speed" button on the controller will cycle the fan between low, medium and high speeds. Once paired to ZHA, the physical "fan speed" button on the controller will only cycle between low and high speeds, skipping the medium speed. If I unpair the controller, the default behaviour returns. On Home Assistant itself, once paired I can change the fan speed between high, medium and low. The incorrect behaviour only occurs on the physical button.
The fix is likely to be to set fan_mode_sequence to FanModeSequence.Low_Med_High in a quirk.
This was previously raised here, and was fixed in Z2M here.
Expected behavior
I expect the physical button to cycle through the 3 speeds.
Screenshots
If applicable, add screenshots to help explain your problem.

Device signature
{
  "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.Router: 1>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress|RxOnWhenIdle|MainsPowered|FullFunctionDevice: 142>, manufacturer_code=4098, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=False, *is_full_function_device=True, *is_mains_powered=True, *is_receiver_on_when_idle=True, *is_router=True, *is_security_capable=False)",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x0100",
      "in_clusters": [
        "0x0000",
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0006",
        "0x0202",
        "0xef00"
      ],
      "out_clusters": [
        "0x000a",
        "0x0019"
      ]
    }
  },
  "manufacturer": "_TZ3210_lzqq3u4r",
  "model": "TS0501",
  "class": "zigpy.device.Device"
}

Diagnostic information
{
  "home_assistant": {
    "installation_type": "Home Assistant OS",
    "version": "2023.3.1",
    "dev": false,
    "hassio": true,
    "virtualenv": false,
    "python_version": "3.10.10",
    "docker": true,
    "arch": "aarch64",
    "timezone": "Australia/Brisbane",
    "os_name": "Linux",
    "os_version": "5.15.90",
    "supervisor": "2023.03.1",
    "host_os": "Home Assistant OS 9.5",
    "docker_version": "20.10.22",
    "chassis": "embedded",
    "run_as_root": true
  },
  "custom_components": {
    "automate": {
      "version": "0.9.9",
      "requirements": [
        "aiopulse2==0.8.0"
      ]
    },
    "hacs": {
      "version": "1.30.1",
      "requirements": [
        "aiogithubapi>=22.10.1"
      ]
    },
    "localtuya": {
      "version": "5.0.0",
      "requirements": []
    },
    "browser_mod": {
      "version": "1.5.2",
      "requirements": []
    },
    "ui_lovelace_minimalist": {
      "version": "v0.0.8",
      "requirements": []
    }
  },
  "integration_manifest": {
    "domain": "zha",
    "name": "Zigbee Home Automation",
    "after_dependencies": [
      "onboarding",
      "usb"
    ],
    "codeowners": [
      "@dmulcahey",
      "@adminiuga",
      "@puddly"
    ],
    "config_flow": true,
    "dependencies": [
      "file_upload"
    ],
    "documentation": "https://www.home-assistant.io/integrations/zha",
    "iot_class": "local_polling",
    "loggers": [
      "aiosqlite",
      "bellows",
      "crccheck",
      "pure_pcapy3",
      "zhaquirks",
      "zigpy",
      "zigpy_deconz",
      "zigpy_xbee",
      "zigpy_zigate",
      "zigpy_znp"
    ],
    "requirements": [
      "bellows==0.34.9",
      "pyserial==3.5",
      "pyserial-asyncio==0.6",
      "zha-quirks==0.0.93",
      "zigpy-deconz==0.19.2",
      "zigpy==0.53.2",
      "zigpy-xbee==0.16.2",
      "zigpy-zigate==0.10.3",
      "zigpy-znp==0.9.3"
    ],
    "usb": [
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*2652*",
        "known_devices": [
          "slae.sh cc2652rb stick"
        ]
      },
      {
        "vid": "1A86",
        "pid": "55D4",
        "description": "*sonoff*plus*",
        "known_devices": [
          "sonoff zigbee dongle plus v2"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*sonoff*plus*",
        "known_devices": [
          "sonoff zigbee dongle plus"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*tubeszb*",
        "known_devices": [
          "TubesZB Coordinator"
        ]
      },
      {
        "vid": "1A86",
        "pid": "7523",
        "description": "*tubeszb*",
        "known_devices": [
          "TubesZB Coordinator"
        ]
      },
      {
        "vid": "1A86",
        "pid": "7523",
        "description": "*zigstar*",
        "known_devices": [
          "ZigStar Coordinators"
        ]
      },
      {
        "vid": "1CF1",
        "pid": "0030",
        "description": "*conbee*",
        "known_devices": [
          "Conbee II"
        ]
      },
      {
        "vid": "10C4",
        "pid": "8A2A",
        "description": "*zigbee*",
        "known_devices": [
          "Nortek HUSBZB-1"
        ]
      },
      {
        "vid": "0403",
        "pid": "6015",
        "description": "*zigate*",
        "known_devices": [
          "ZiGate+"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*zigate*",
        "known_devices": [
          "ZiGate"
        ]
      },
      {
        "vid": "10C4",
        "pid": "8B34",
        "description": "*bv 2010/10*",
        "known_devices": [
          "Bitron Video AV2010/10"
        ]
      }
    ],
    "zeroconf": [
      {
        "type": "_esphomelib._tcp.local.",
        "name": "tube*"
      },
      {
        "type": "_zigate-zigbee-gateway._tcp.local.",
        "name": "*zigate*"
      },
      {
        "type": "_zigstar_gw._tcp.local.",
        "name": "*zigstar*"
      },
      {
        "type": "_slzb-06._tcp.local.",
        "name": "slzb-06*"
      }
    ],
    "is_built_in": true
  },
  "data": {
    "ieee": "**REDACTED**",
    "nwk": 28219,
    "manufacturer": "_TZ3210_lzqq3u4r",
    "model": "TS0501",
    "name": "_TZ3210_lzqq3u4r TS0501",
    "quirk_applied": false,
    "quirk_class": "zigpy.device.Device",
    "manufacturer_code": 4098,
    "power_source": "Mains",
    "lqi": 127,
    "rssi": null,
    "last_seen": "2023-03-09T10:14:25",
    "available": true,
    "device_type": "Router",
    "signature": {
      "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.Router: 1>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress|RxOnWhenIdle|MainsPowered|FullFunctionDevice: 142>, manufacturer_code=4098, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=False, *is_full_function_device=True, *is_mains_powered=True, *is_receiver_on_when_idle=True, *is_router=True, *is_security_capable=False)",
      "endpoints": {
        "1": {
          "profile_id": 260,
          "device_type": "0x0100",
          "in_clusters": [
            "0x0000",
            "0x0003",
            "0x0004",
            "0x0005",
            "0x0006",
            "0x0202",
            "0xef00"
          ],
          "out_clusters": [
            "0x000a",
            "0x0019"
          ]
        }
      }
    },
    "active_coordinator": false,
    "entities": [
      {
        "entity_id": "button.tz3210_lzqq3u4r_ts0501_351908fe_identify",
        "name": "_TZ3210_lzqq3u4r TS0501"
      },
      {
        "entity_id": "fan.tz3210_lzqq3u4r_ts0501_351908fe_fan",
        "name": "_TZ3210_lzqq3u4r TS0501"
      },
      {
        "entity_id": "light.tz3210_lzqq3u4r_ts0501_351908fe_on_off",
        "name": "_TZ3210_lzqq3u4r TS0501"
      }
    ],
    "neighbors": [
      {
        "device_type": "Coordinator",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x0000",
        "permit_joining": "Unknown",
        "depth": "0",
        "lqi": "144"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x27A5",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "106"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x2917",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "119"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x6E1E",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "142"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x70E4",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "71"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x740E",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "100"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x8153",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "39"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x8B2E",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "92"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x92E5",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "155"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x9880",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "151"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x98E9",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "98"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xAA24",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "255"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xB0FD",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "128"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xBE9F",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "37"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xC9D9",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "54"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xCB1C",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "138"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xD430",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "170"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xE369",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "137"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xE97F",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "105"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xEB53",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "100"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xEDFF",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "179"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xF1EE",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "91"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xF339",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "145"
      },
      {
        "device_type": "Router",
        "rx_on_when_idle": "On",
        "relationship": "Sibling",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xF4E7",
        "permit_joining": "Unknown",
        "depth": "15",
        "lqi": "153"
      },
      {
        "device_type": "EndDevice",
        "rx_on_when_idle": "Off",
        "relationship": "Child",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0xAC2F",
        "permit_joining": "NotAccepting",
        "depth": "2",
        "lqi": "168"
      },
      {
        "device_type": "EndDevice",
        "rx_on_when_idle": "Off",
        "relationship": "Child",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x0D4C",
        "permit_joining": "NotAccepting",
        "depth": "2",
        "lqi": "192"
      },
      {
        "device_type": "EndDevice",
        "rx_on_when_idle": "Off",
        "relationship": "Child",
        "extended_pan_id": "**REDACTED**",
        "ieee": "**REDACTED**",
        "nwk": "0x3BC4",
        "permit_joining": "NotAccepting",
        "depth": "2",
        "lqi": "220"
      }
    ],
    "routes": [
      {
        "dest_nwk": "0x0000",
        "route_status": "Active",
        "memory_constrained": false,
        "many_to_one": true,
        "route_record_required": false,
        "next_hop": "0x92E5"
      },
      {
        "dest_nwk": "0xF1EE",
        "route_status": "Active",
        "memory_constrained": false,
        "many_to_one": false,
        "route_record_required": false,
        "next_hop": "0xF1EE"
      }
    ],
    "endpoint_names": [
      {
        "name": "ON_OFF_LIGHT"
      }
    ],
    "user_given_name": "Fan Controller Office",
    "device_reg_id": "a39dabc9fcdd3691fae440554a0d51f4",
    "area_id": "b813b8c610604395ab5e589f9f8be62e",
    "cluster_details": {
      "1": {
        "device_type": {
          "name": "ON_OFF_LIGHT",
          "id": 256
        },
        "profile_id": 260,
        "in_clusters": {
          "0x0000": {
            "endpoint_attribute": "basic",
            "attributes": {
              "0x0004": {
                "attribute_name": "manufacturer",
                "value": "_TZ3210_lzqq3u4r"
              },
              "0x0005": {
                "attribute_name": "model",
                "value": "TS0501"
              }
            },
            "unsupported_attributes": {}
          },
          "0x0004": {
            "endpoint_attribute": "groups",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0005": {
            "endpoint_attribute": "scenes",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0006": {
            "endpoint_attribute": "on_off",
            "attributes": {
              "0x0000": {
                "attribute_name": "on_off",
                "value": 1
              }
            },
            "unsupported_attributes": {
              "0x4003": {
                "attribute_name": "start_up_on_off"
              }
            }
          },
          "0x0003": {
            "endpoint_attribute": "identify",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0202": {
            "endpoint_attribute": "fan",
            "attributes": {
              "0x0000": {
                "attribute_name": "fan_mode",
                "value": 3
              },
              "0x0001": {
                "attribute_name": "fan_mode_sequence",
                "value": 1
              }
            },
            "unsupported_attributes": {}
          },
          "0xef00": {
            "endpoint_attribute": null,
            "attributes": {},
            "unsupported_attributes": {}
          }
        },
        "out_clusters": {
          "0x0019": {
            "endpoint_attribute": "ota",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x000a": {
            "endpoint_attribute": "time",
            "attributes": {},
            "unsupported_attributes": {}
          }
        }
      }
    }
  }
}

Additional logs
Paste any additional debug logs here.
Don't remove the extra line breaks outside the ``` marks.

Additional context
Add any other context about the problem here.

Yes, performing those steps fixes the issue.

Can you try this custom quirk: https://raw.githubusercontent.com/TheJulianJES/zha-device-handlers/tjj/tuya_fan_override_modes_on_bind/zhaquirks/tuya/ts0501_fan_switch.py
Instructions for installing: https://github.com/zigpy/zha-device-handlers/discussions/693#discussioncomment-857274
When re-pairing (or using the "reconfigure" option in the UI), this should write the attribute appropriately now. Can you please check that it works, so we can merge it into zha-quirks?

Thanks. Unfortunately, that has not fixed the issue. It's still reporting as Low_High

Did you re-configure the device through the UI (or re-pair it completely) with the quirk in place?
Is the quirk loaded? (Can be seen at the bottom of the device signature)

Yes, I re-configured, which didn't work, so I re-paired it completely.
It is showing as Quirk: ts0501_fan_switch.TS0501FanController

Ah, duh. Can you re-download the file and try again? (And make sure it says FanCluster in the replacement part -- should appear two times in that file)

Ok, that has fixed it!

@Brazen00 You should be able to remove the custom quirk when updating to HA Core 2022.3.4 or later (which will be available for download in the next hour or so).

@Brazen00 sorry to dredge up an old bug that has been closed. But I've just had 4 of these installed. While the integration with home-assistant works flawlessly, the controllers themselves are very disappointing at present. If I use the physical touch buttons to control the fan speed or lights the whole controller will often flash white and do what looks like a reset. This turns the fan and the light off and fails to update home-assistant of the change in state.
Did you have this problem at all? I don't believe its a ZHA problem, as the controllers do it even when not paired with anything.


Add a demo app for the side navigation

Side Navigation Demo App

Thank you

Hi @LadwigDev,
Just a quick heads-up: I noticed that the ABAP file z2ui5_cl_demo_app_258.class.abap is currently in the root directory of the repository. It needs to be moved to the /src directory where all the XML and ABAP files are located.

Could you please move it to the correct directory when you get a chance?
Thanks!
Best regards,
Francisco.

Hi @francisco-milan,
I have changed the file location and also removed another bug. Hope I did everything right this time.
Best regards
Jan


Metadata mode for torchaudio.dataset

🚀 The feature
Hello,
Thanks for the handy tools for parsing the database!
I am wondering if it is possible to let the torchaudio.dataset classes have two modes:

Return the actual waveform
Return the waveform path

Others metadata like transcriptions and speaker labels can just remain the same.
Motivation, pitch
Since usually we would like to organize a corpus into some standardized data format (like the kaldi's data directory), before loading the actual waveform. So we can have more flexibility on how many training data points we want to use, or some preprocessing steps which might be hard to do in __getitem__ and collate_fn. For example, In SUPERB ASV, if an utterance in VoxCeleb1 is not longer than 2 seconds after VAD, it is discarded and won't be used for training (There is no utterance in this case for the testing set). In the current dataset class implementation, I not yet come out a feasible way to realize this kind of logic since the __len__ is fixed.
Furthermore, by switching to waveform path mode, it becomes really fast to iterate over the entire dataset. Then, I can re-use the dataset classes as the corpus directory parsing helper, easily obtain all the transcription in LibriSpeech and train tokenizers, or easily obtain all the speakers in VoxCeleb1 to make a Categorical encoder. In the current implementation which returns the actual waveforms, it can become too slow to iterator over the entire dataset and is not tolerable for just preprocessing steps.
Alternatives
No
Additional context
No response

I think the proposal makes sense. Decoupling dataset traversal and audio decoding makes it flexible.
For the second part, I think that the most flexible approach is to have explicit table representation of dataset internally, and apply operations like "drop rows that do not meet this criteria" and "split the dataset into batches with similar length" on it. I get the feeling that this will also give user code opportunity to improve the overall throughput.
The existing TorchAudio datasets started as simple adaptation of classic torch.utils.Dataset, which was not designed for advanced usage like these. I think it's good time for us to move away from it.

Cool!

Hi @leo19941227, we can add the metadata feature under prototype. One potential solution is adding fetch_metadata method for each dataset. The returned item is mostly identical, only the waveform is replaced by the absolute path of the audio. Does that suit your need?

Hello @nateanl ,
Cool! I think this is nice.

Hi @carolineechen,
Thanks, it looks good to me!

If a new Dataset abstraction is implemented into torchaudio, please consider known problems of storing data/strings as native python objects: https://github.com/speechbrain/speechbrain/issues/872


Nested grouped not work

Hi all.
See the example.
Whene I drag an foo item the item going to drop in bar list too.
This not correct behavior.
Thanks.

I think this issue is the same as #1153, so could be fixed with PR #1154

Solved in 1.8.0-rc1.


There is no license file in this project.

There should be a license in this project so that anyone can see what we can do with this code.

this has been fixed


Migrate HTTP router to Chi

Description
This is a follow-up PR form #6248 including the next step in migrating Dapr away from fasthttp.
This PR includes:

Migrates the router from fasthttprouter to Chi (based on net/http). Migrating the router is necessary to be able to write handlers that are based on net/http, and thus leverage things like streaming (although we do have adapters that convert handlers from net/http to fasthttp, during the conversion we lose the ability to do streaming, and it adds overhead)
Implements a UniversalHTTPHandler which adapts Universal APIs into net/http handlers

Migrates some (not all) universal APIs from UniversalFastHTTPHandler to UniversalHTTPHandler

In the current master branch, this is the stack:

After this PR, the stack changes to:

Separate PRs will follow-up to convert the remaining universal handlers to net/http, and to convert existing fasthttp handlers into either net/http or universal ones (this last conversion is a longer-term project and is not strictly required for handlers that do not need streaming or other similar features; however, eliminating the fasthttp adapter will improve performance)
Some additional notes:

The router's behavior remains the same, with one exception only:

Take for example the route v1.0/state/{storeName}/{key}. Before, passing an empty {storeName}, such as v1.0/state//somekey would have still invoked the handler, which would have received an empty "storeName" (and likely returned 400 - bad request). Because the router now normalizes paths and removes double slashes (see #6324), the path is converted to v1.0/state/somekey, so it now returns a 404 because it can't match any route.

The invoke method continues to work as before, but now also supports external endpoints that are URL-encoded, such as v1.0/invoke/http:%2F%2Fexample.com/method/foo (which are not working in Dapr 1.11)

Issue reference

Related to #4979 (addresses some of the follow-ups, but not all)
Necessary (but not quite sufficient) to fix also:

#5392
#6246
#6364
microsoft/azure-container-apps#760

/ok-to-test

/test-sdk-all

/ok-to-test

/test-sdk-all

/ok-to-test

/ok-to-perf

/test-sdk-all

/ok-to-test

/test-sdk-all

/ok-to-perf

/ok-to-perf

/ok-to-perf

/ok-to-perf

/ok-to-perf

/ok-to-perf

While there is a slight performance hit in regards to per-call latency and increase in memory consumption under load, it's not significant and we can merge this PR. When end-to-end streaming is supported it might offset any penalties introduced here.

Thanks for merging @yaron2 !
I agree that the next work is very likely to offset some of the hit we are seeing here, to start thanks to the removal of the fasthttp conversion layer:

Will have the work done in the next days

use https://github.com/cloudwego/hertz instead? net/http http2 is too much slower


Annex nothing cases

Fixes #212

Codecov Report

Merging #213 into dev will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##              dev     #213   +/-   ##
=======================================
  Coverage   55.74%   55.74%
=======================================
  Files          51       51
  Lines        3812     3812
=======================================
  Hits         2125     2125
  Misses       1687     1687

Impacted Files
Coverage Δ

src/base.jl
95.52% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e60c3...9732824. Read the comment docs.

This reveals the fact that we don't have any tests for this condition.  Would you mind adding invocations of ConcreteSystem() to all constructions of System in test/powersystemconstructors?

This reveals the fact that we don't have any tests for this condition. Would you mind adding invocations of ConcreteSystem() to all constructions of System in test/powersystemconstructors?

Ok

Also, I was working on fixing this before you pushed.  I noticed that you can't run the powersystemconstructors test by itself.  It needs to have an <include("../data/data_5bus_pu.jl")> at the top.  Otherwise, nodes5 is undefined.  Might want to make that change also.

Codecov Report

Merging #213 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev     #213      +/-   ##
==========================================
- Coverage   55.74%   55.73%   -0.02%
==========================================
  Files          51       51
  Lines        3812     3811       -1
==========================================
- Hits         2125     2124       -1
  Misses       1687     1687

Impacted Files
Coverage Δ

src/models/branches/dc_lines.jl
100% <ø> (ø)
:arrow_up:

src/base.jl
95.45% <100%> (-0.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e60c3...88f4d78. Read the comment docs.

This reveals the fact that we don't have any tests for this condition. Would you mind adding invocations of ConcreteSystem() to all constructions of System in test/powersystemconstructors?

I just added the missing tests.

Everything looks good except for my comment about <include("../data/data_5bus_pu.jl")> in the test.

Why don't I see an "approve" button?


KAFKA-14226: feat(connect:transform): Introduce FieldPath abstraction

Part of KIP-821 implementation.
Follow up from https://github.com/apache/kafka/pull/12637
Sets foundations to support nested fields on SMTs.
Includes the following changes:

Introduces a new modules inside o.a.k.connect.transforms: fields
FieldPath interface and 2 implementations: SingleFieldPath and MultiFieldPaths
Utils to hold and update Map, Struct and Schema values.

SMTs will be updated in following PRs to complete the scope of KIP-821.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

cc @C0urante @yashmayya @mimaison

@jeqo This is difficult to review without seeing how this code is actually used. Maybe we could move incrementally and introduce a commit that only touches on 1-3 SMTs, and only introduces the internal changes (i.e., methods in the SingleFieldPath and MultiFieldPaths classes) necessary in order to touch on those SMTs?

I'm also wondering if it's necessary to have the SingleFieldPath class at all. Would it be significantly more expensive to just use the MultiFieldPaths class for everything for now? It'd reduce the complexity of the implementation and probably make review easier.

Thanks @C0urante! I've applied most suggestions, PTAL


055 - Migrated to node.js test runner

Can u pls check my code im new to testing

oh thanks so should i change it or u will change it :)

@ThotakuraHarish2003 You need to do it :)


Reland "Native assets support for Linux"

Reland of #134031. (Reverted in #135069.) Contains the fix for b/301051367 together with cl/567233346.
Support for FFI calls with @Native external functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.
For more info see:

https://github.com/flutter/flutter/issues/129757

Implementation details for Linux.
Mainly follows the design of https://github.com/flutter/flutter/pull/130494.
Some differences are:

Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
Linux has no add2app.

The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.
Tests
This PR adds new tests to cover the various use cases.

packages/flutter_tools/test/general.shard/linux/native_assets_test.dart

Unit tests the Linux-specific part of building native assets.

It also extends various existing tests:

packages/flutter_tools/test/integration.shard/native_assets_test.dart

Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

The first commit is the revert of the revert.
The third commit reverts the second commit (which was a workaround), and contains the fix for b/301051367 together with cl/567233346.

Somehow, the 100something CI checks aren't triggering?

@dcharkes Is it intended to merge into main versus the current default master?

@dcharkes Is it intended to merge into main versus the current default master? Asking since the initial PR was being merged into master.

Aren't these aliases of each other?

@dcharkes Is it intended to merge into main versus the current default master? Asking since the initial PR was being merged into master.

Aren't these aliases of each other?

I don't fully understand the specifics on how the targets are generated yet, but it seems that the logic in our backend that determines which targets to run handles PRs merging to the "default" branch (master in this case) to PRs merging to other branches.

@dcharkes Is it intended to merge into main versus the current default master? Asking since the initial PR was being merged into master.

Aren't these aliases of each other?

I don't fully understand the specifics on how the targets are generated yet, but it seems that the logic in our backend that determines which targets to run handles PRs merging to the "default" branch (master in this case) to PRs merging to other branches.

Nice find, it looks like the CI is now running :)
Should I be using master instead of main  in my local checkout? to branch out of?

@dcharkes Is it intended to merge into main versus the current default master? Asking since the initial PR was being merged into master.

Aren't these aliases of each other?

I don't fully understand the specifics on how the targets are generated yet, but it seems that the logic in our backend that determines which targets to run handles PRs merging to the "default" branch (master in this case) to PRs merging to other branches.

Nice find, it looks like the CI is now running :)
Should I be using master instead of main  in my local checkout? to branch out of?

Yeah I think that would prevent this from occurring. I believe there are some github issues created to completely get rid of master that would make it even simpler in the future.

Should I be using master instead of main  in my local checkout? to branch out of?

I exclusively branch from main locally; it shouldn't affect PR targets.

Friendly ping to review this PR @chingjun @stuartmorgan.
(Apparently, all my PRs end up having merge conflicts with g3, and get "deleted" roll CLs. I've verified the fix for this PR in g3 cl/566871401. So it should be safe to set g3 to green. Though, other stuff might have landed in the meantime, invalidating the old CL.)


ImportError: cannot import name 'get_fqn_to_example_inputs' from 'torch.ao.quantization.utils' (/usr/local/lib/python3.7/dist-packages/torch/ao/quantization/utils.py)

Instructions To Reproduce the 🐛 Bug:

Full runnable code or full changes you made:

If making changes to the project itself, please use output of the following command:
git rev-parse HEAD; git diff

<put code or diff here>

What exact command you run:
Full logs or other relevant observations:

<put logs here>

please simplify the steps as much as possible so they do not require additional resources to run, such as a private dataset.

Expected behavior:
If there are no obvious error in "what you observed" provided above,
please tell us the expected behavior.

Are you still getting this error after re-installing pytorch-nightly?
Same error: #360 https://github.com/facebookresearch/d2go/issues/360

@bryantwilliam I solved the problem after I re-install the pytorch-nightly.

Find the install command at pytorch.org .
Run the install command.
Check the version of torch and torchvision are the latest and compatiable in torch-torchvision matrix.


move eraftpb out of kvproto

This pr move eraftpb from kvproto into this crate. So that we can drop the dependency of kvproto and grpc.
/cc #1

LGTM

PTAL @Hoverbear

ping @overvenus

Ping

LGTM


Copy edits to README

Sundry copy edits, inserting new links, fixing broken links, and ensuring things mirror the now official docs.

By passing the failed chart linting CI check because… this PR doesn't touch the actual chart! and no new versions are required.


mksh: added 'lksh' as part of 'mksh'

Description of package
lksh purpose is to run legacy sh scripts and POSIX sh scripts (see Building lksh and lksh.1)
In addition to lksh itself, also added:

enable parallel compiling if processor is multi-core
hooks to add mksh to /etc/shells
symlink /bin/sh -> lksh

Installed manifest of package
/var/db/kiss/installed/mksh/version
/var/db/kiss/installed/mksh/sources
/var/db/kiss/installed/mksh/pre-remove
/var/db/kiss/installed/mksh/post-install
/var/db/kiss/installed/mksh/manifest
/var/db/kiss/installed/mksh/checksums
/var/db/kiss/installed/mksh/build
/var/db/kiss/installed/mksh/
/var/db/kiss/installed/
/var/db/kiss/choices/mksh>usr>bin>sh
/var/db/kiss/choices/
/var/db/kiss/
/var/db/
/var/
/usr/share/man/man1/mksh.1
/usr/share/man/man1/lksh.1
/usr/share/man/man1/
/usr/share/man/
/usr/share/
/usr/bin/mksh
/usr/bin/lksh
/usr/bin/
/usr/

Existing package
Maintainer: @a-schaefers

You must contact the maintainer as the maintainer is the only person able to make changes to a package.

Hey @dm9pZCAq if you want to do this, you can adopt and maintain the package from me, then @dylanaraps can review it and merge it in. I'm too busy to give this a fair look. So if you want to do this, just submit a PR with a space ' ' at the end of the version file and it is all yours. Thanks.


Gracefully handle Tweets being over 140 characters.

Currently if Twitter rejects a tweet for being over 140 characters, you get the following ugly traceback every time pt.sh runs:
Traceback (most recent call last):
  File "./pt.py", line 18, in <module>
    pumptweet.pull_and_push()
  File "/home/alex/pumptweet/pumptweet/PumpTweet.py", line 162, in pull_and_push
    self.post_tweets(tweets)
  File "/home/alex/pumptweet/pumptweet/PumpTweet.py", line 137, in post_tweets
    self.twitter_api.PostUpdate(tweet)
  File "/home/alex/pumptweet/local/lib/python2.7/site-packages/twitter/api.py", line 887, in PostUpdate
    data = self._ParseAndCheckTwitter(json.content)
  File "/home/alex/pumptweet/local/lib/python2.7/site-packages/twitter/api.py", line 3530, in _ParseAndCheckTwitter
    self._CheckForTwitterError(data)
  File "/home/alex/pumptweet/local/lib/python2.7/site-packages/twitter/api.py", line 3557, in _CheckForTwitterError
    raise TwitterError(data['errors'])
twitter.error.TwitterError: [{u'message': u'Status is over 140 characters.', u'code': 186}]

Now, it'd be nice if this never happened, but as we all know, software has bugs. So: PumpTweet should output an error to the console once (perhaps suggesting that the user file a bug), so that the user gets mail about the error, and then shut up.

I added some better error handling in https://github.com/dper/pumptweet/commit/0c72d83ef8ab57b7d0d7ece95e458ab4c66ee867.
In general, what is the desired behavior if Twitter rejects a tweet?  Right now, PumpTweet hangs on that single message and won't advance. That makes it easy for us to debug.
On the other hand, a regular user might want to see the error message just once and then move on with life. But that would make debugging hard, so maybe an optional command line parameter is desirable so that when debugging we could say "halt on error".
This also impacts https://github.com/dper/pumptweet/issues/28.

Errors are now gracefully handled. It's not an ideal solution, but it's better than it was.


AR Reminder Template

Just a heads up that we will be reviewing the feedback from users after each iteration so there may be some minor updates to the AR Reminder notice.


WIP: Use the base class

This makes libp2p bundles so simple!

ref: https://github.com/libp2p/js-libp2p/pull/43

It works \o/ So happy about this refactoring, makes things so much nicer and understandable
@dignifiedquire Not sure if I should consider your comment as a positive CR, but I believe it is safe to assume that if you found an issue, you would comment right away :) Will merge once CI is green

@diasdavid I didn't do any real CR yet will do tomorrow

thank you :)

while you are at it :) https://github.com/ipfs/js-libp2p-ipfs-browser/pull/126


fix smartcash curve

You totally ignored my comments from the older pull request. Will you
address them?

@prusnak did a wrong pull request, now is updated, sorry about that. The right parameters are .hasher_base58 = HASHER_SHA3K  .hasher_sign = HASHER_SHA2, and .hasher_pubkey = HASHER_SHA2_RIPEMD already tested and worked at Smartcash mainet, using Electrum. As not all the hash algo are SHA3 i preferred to keep the curve name as secp256k1-smart, but if you prefer to change to secp256k1-sha3 no problem about that

Thanks! Merged as https://github.com/trezor/trezor-crypto/commit/1863045da447103e1aa56eb1df9f03dd1c4a9eee


Reimplement crosshairs adding snapping, decoration and events #207

Couple of minor comments but it looks really good to me, the tests are great too - I'd be happy to see this merged :+1:
I also noticed, in the first test, that sometimes I'd hover over one bar, but the crosshairs would snap to the adjacent bar. Turning off hideWeekends seemed to fix this, so I expect it's caused by scale, rather than the component but something to bear in mind.


Fix --no-icu tests and add CI for it

Fixes #4734

Is it reasonable to make it only for PRs? I don't expect enough churn in --no-icu situations that it requires daily builds or OS X builds.

The rolling build isn't very expensive either, and this will be part of our green matrix that we want to keep green, right? When branches automatically merge it's nice to make sure nothing breaks. It's difficult to display a badge for PR builds, so better to have a badge for the rolling build instead. Daily, OSX, etc are not necessary.

:shipit:

@dotnet-bot test ci please

@dilijev I think I have set it up now so there are rolling and PR tasks on all relevant branches. If the wiki is to be believed, assuming test ci please passes, I have to merge this and just hope it worked correctly this weekend to test it?

@dotnet-bot test ci please

CI from master-ci: https://ci2.dot.net/job/Microsoft_ChakraCore/job/master-ci/job/GenPRTest/job/_no_icu_static_ubuntu_linux_debug_prtest/2/

I have to merge this and just hope it worked correctly this weekend to test it?

Not really, that's what the master-ci branch is for. Merge your changes to that branch, then create a PR with these changes against that branch, and if that CI passes, then your checks worked and pass.  Then you can merge this change to master.

Did that according to @MSLaguana's offline suggestion and it seemed to pass, so I will merge this today.

I also updated the wiki page about adding CI jobs to mention that. https://github.com/Microsoft/ChakraCore/wiki/Jenkins-CI-Checks/_compare/485011af1a4b185031c1e52ed60a4fb67299d1ba...747743df39efca9aa8f16fa7a93a76f979222ee1


feat(validator): query supports array params

This PR enables the validator to handle array params with query, not using queries.
For example, before this PR, we could not validate multiple params like tag using query:
http://localhost/search?page=123&tag=a&tag=b

Or we have to use queries but if we do so, they all will be array.
With this PR, the values we could get from query will be Record<string, string | string[]>. So we can write the followings:
const app = new Hono()

const schema = z.object({
  q: z.string(),
  tag: z.array(z.string()),
})

const route = app.get('/post', zValidator('query', schema), (c) => {
  const { q, tag } = c.req.valid('query')
  return c.jsonT({
    queryString: q,
    tags: tag,
  })
})

This issue is mentioned by @equt in our Discord. Thanks.

Thank you for reviewing. If you have any further suggestions, please let us know anytime!


Build on debian failure or not?

Hi,
i have running the build script on debian, i dont no all is fine, i have seen many warnings comes from hyperions code but i think thats ok.
One error i have seen and i dont understand.
on the attached hyperion-buildall-make-check.log in line 300:
>>>>> line 83616: Informational message mismatch.
                  Want: HHC17006W MAINSIZE decreased to 2G architectural maximum
                  Got:  HHC02204I ARCHLVL        set to S/370
Test "mainsize check storage size":  25 OK compares.  One failure.
....
Did 324 tests.  1 failed; 323 OK.

hyperion-buildall-make-check:
hyperion-buildall-make-check.log
Here is the full log:
hyperion-buildall.log
And can you tell me how i can start hercules?
if i type hercules in the shell the system returns "command not found"
if i compile hercules manual from the source without all extpcks and rexx,
i can start hercules only by typing "hercules" or with the config file syntax  "-f" on the shell, or is my build failed?
thanks for help!

I will answer the "how to start Hercules" question separately.
The "mainsize" test failure is a known issue.  You can read about the cause here:
https://github.com/SDL-Hercules-390/hyperion/issues/330
You can (most likely) ignore that test failure.
Bill

With the most recent commit 443c8ae, the hyperion-buildall.sh will now create
a shell script after the installation completess, that can be used to set the required PATH
and LD_LIBRARY_PATH environment variables.
You can run   source hercules-setvars.sh    to set up the env vars.
Then your new Hercules will be in the search path.
Bill


Add Prerna Sony to contributor list

@prernasony, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

@Roshanjossey , Hey,Firstly thank you so much for this tutorial. It is very nicely explained . I am the beginner and learning things. So just followed all the steps mentioned in this project and they all worked successfully.

@prernasony, We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


Find elements inside map function

Then I execute this code
element
    .all(by.repeater('field in app.category.fields'))
    .map(function(element) {
        return element.element(by.css('[ng-switch-when]'));
        // element.$('[ng-switch-when]');
    });

protractor not goes after it and browser waits....
How I can fix it?

This looks like a duplicate of #2427 please consider closing this issue and commenting there.

@NickTomlin , thanks for comment.


Implement Supported Geospatial CASTs

Description

This commit contains Tests and Fixes for Supported and Unsupported CASTs for Geospatial Data Types.

Added Casts which need to be supported for Geospatial Data Types.

Disabled Casts which were being supported but weren't meant to be supported.

Added proper CASTing Tests for JDBC driver in TestSpatialPoint-vu-* test files (for both IMPLICIT and EXPLICIT CASTs)

Updated PostGIS and Proj versions according to gitfarm to remove any differences b/w github and gitfarm

Task: BABEL- 4501
Authored-by: Anikait Agrawal<EMAIL_ADDRESS>Signed-off-by: Anikait Agrawal<EMAIL_ADDRESS>Test Scenarios Covered

Use case based -   TestSpatialPoint-vu-*

Boundary conditions -

Arbitrary inputs -

Negative test cases - TestSpatialPoint-vu-* (unsupported casts)

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Approved, but let's also keep aware of anything that might need addressing once the changes hit GitFarm, since the build process will be different - files, dependencies will be different.


Leaflet crash when drawing polyline

Repro-Repo: https://github.com/gluebi/vue-leaflet-marker-polyline-repro
When opening the popup of a marker the polyline should be drawn.
The line is drawn but the popup doesn't open because of the crash.
Uncaught (in promise) TypeError: Cannot use 'in' operator to search for '_leaflet_id' in undefined
    at stamp (Util.js:55:8)
    at NewClass.removeLayer (Layer.js:180:12)
    at RefImpl.removeLayer (vue-leaflet.es.js:1324:29)
    at t (vue-leaflet.es.js:55:22)
    at vue-leaflet.es.js:305:5
    at runtime-core.esm-bundler.js:2675:88
    at callWithErrorHandling (runtime-core.esm-bundler.js:158:18)
    at callWithAsyncErrorHandling (runtime-core.esm-bundler.js:166:17)
    at hook.__weh.hook.__weh (runtime-core.esm-bundler.js:2655:19)
    at invokeArrayFns (shared.esm-bundler.js:77:10)

The same works as long as the markers are not inside of the marker cluster.
I am not a 100% certain if the problem lies in vue-leaflet-markercluster or in vue-leaflet.
Let me know if I should open an issue in their repo instead.
Thanks!

Hi, thanks for creating a repo to reproduce the big. I'll have a look into it later this week and will get back to you asap.

Okay just checked your code. Not sure if it is a requirement of leaflet itself, but as far I found out for vue-leaflet you need to wrap the polyline in a feature group:
<l-feature-group>
      <l-polyline
          v-if="isVehiclePopupOpen"
          :lat-lngs="[
            { lat: 55, lng: 10 },
            { lat: 56, lng: 11 },
          ]"
          color="red"
      />
</l-feature-group>

This will fix your error. So the error definitely isn't related to  vue-leaflet-markercluster. Might be an error or an requirement of vue-leaflet.

Thank you for the quick solution. Very much appreciated! Closing the issue then.


feat: Docker build

SUMMARY

Adding docker build/push to workflow

Codecov Report

Merging #11686 (e368604) into master (24ba530) will increase coverage by 2.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11686      +/-   ##
==========================================
+ Coverage   62.26%   64.63%   +2.37%
==========================================
  Files         873      887      +14
  Lines       42256    46093    +3837
  Branches     3961     3961
==========================================
+ Hits        26310    29794    +3484
- Misses      15766    16119     +353
  Partials      180      180

Flag
Coverage Δ

javascript
62.83% <ø> (ø)

python
65.59% <ø> (+3.67%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/utils/dashboard_import_export.py
55.73% <0.00%> (-4.98%)
:arrow_down:

superset/models/slice.py
86.32% <0.00%> (-0.49%)
:arrow_down:

superset/utils/core.py
88.35% <0.00%> (-0.32%)
:arrow_down:

superset/charts/api.py
77.55% <0.00%> (-0.27%)
:arrow_down:

superset/models/dashboard.py
80.62% <0.00%> (-0.02%)
:arrow_down:

superset/queries/api.py
100.00% <0.00%> (ø)

superset/charts/schemas.py
100.00% <0.00%> (ø)

superset/databases/schemas.py
100.00% <0.00%> (ø)

superset/reports/commands/bulk_delete.py
88.46% <0.00%> (ø)

superset/reports/commands/create.py
87.27% <0.00%> (ø)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ba530...e368604. Read the comment docs.


treewide: remove unused with statements from maintainer lists

$ find -type f -name '*.nix' -print0 | xargs -P "$(nproc)" -0 sed -i \
  -e 's!with lib.maintainers; \[ *\];![ ];!' \
  -e 's!with maintainers; \[ *\];![ ];!'

nixf-tidy complaints now about empty maintainers set.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks! Btw there's a : after your commit message, and better to use treewide instead of tree-wide in case someone is writing a script to filter commit history or something

Thanks! Btw there's a : after your commit message, and better to use treewide instead of tree-wide in case someone is writing a script to filter commit history or something

Done

I'll revisit after 1 hour

What's the value of removing these besides "shush the linter"? Given that we want packages ideally to have maintainers anyways, I'd argue that keeping these around might be worthwhile? They probably also don't hurt performance, or at the very least could easily be optimized away to have no performance impact.
I'd argue that the linter is wrong to complain about cases like these, and should distinguish from other cases I'd consider as valid, like unused with lib; for example. (Specifically, I'd draw the line at "an unused with is fine if it's scoped only to an empty list")


update readme

This README file was removed. Updated version of the resolver.md is at: https://github.com/blockstack/blockstack-core/blob/api/docs/resolver.md
Thanks for the earlier PR!


ADFS and IIS - IIS Not Used Since 2012

[Enter feedback here]
ADFS does not use IIS anymore. So, the page should be updated to reflect that.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e6cade2-3121-73ed-9504-856bd88551e1
Version Independent ID: a5b16a13-0aac-ec1c-a640-5562ee344413
Content: A federated user is prompted unexpectedly to enter their work or school account credentials - Active Directory
Content Source: support/azure/active-directory/federated-user-prompt-enter-credentials.md
Service: active-directory
Sub-service: authentication
GitHub Login: @genlin
Microsoft Alias: genli

@matziq, Thanks for the feedback. We will review and update the article.


Add defaulting tests for API v1beta2 and v1beta3

This commit also add more tests in v1beta1/defaults_test.go

cc @bgrant0607

Tests LGTM


Stuck on 1.2.5 JAR mod PlayerAPI

Tried running multiple times, consistently gets stuck on this one JAR.
PlayerAPI.zip
Oddly enough this doesn't happen if I scan just that file or even just that directory.
JStack output if it helps:
log.log
I ran with 32T but it also happens on 8T and even 1T, so I don't think it's a race condition.

What is your Operating System and how do we reproduce this?

Arch Linux

Not sure what fixed it but the latest pre-release (1.1) works without issues now.


First-class support for lazy named tag evaluation?

If there's a mailing list or other avenue you prefer for this enhancement discussion, please let me know.
We have a need for lazy evaluation of named tags whose values are discovered during the execution of the block. We can work around this or patch for our specific needs, but I wanted to see if this has been discussion before or anyone else has this need.
A contrived example:
require 'semantic_logger'
SemanticLogger.add_appender(io: $stdout, level: :debug, formatter: :json)
LOGGER = SemanticLogger['Contrived']
LOGGER.level = :debug

Thread.current[:execution_context] = {}

class Scope1
  def execute
    Thread.current[:execution_context][:discovered_tag] = "value"
  end
end

class Scope2
  def execute
    LOGGER.debug('some.event')
  end
end

LOGGER.tagged(Thread.current[:execution_context]) do
  Scope1.new.execute
  Scope2.new.execute
end

Clearly some.event will be logged without the discovered_tag, since we didn't know about it when calling tagged.
{
	"host": "local",
	"application": "Semantic Logger",
	"timestamp": "2018-09-10T20:26:47.833371Z",
	"level": "debug",
	"level_index": 1,
	"pid": 23155,
	"thread": "70338952296820",
	"name": "Contrived",
	"message": "some.event"
}

I assume the recommended way to do this is using push_named_tags and ensuring they are later popped appropriately.
require 'semantic_logger'
SemanticLogger.add_appender(io: $stdout, level: :debug, formatter: :json)
LOGGER = SemanticLogger['Contrived']
LOGGER.level = :debug
Thread.current[:contrived_extra_tags] = 0

class Scope1
  def execute
    SemanticLogger.push_named_tags({some_tag: "discovered"})
    Thread.current[:contrived_extra_tags] += 1
  end
end

class Scope2
  def execute
    LOGGER.debug('some.event')
  end
end

LOGGER.tagged do
  Scope1.new.execute
  Scope2.new.execute
end
SemanticLogger.pop_named_tags(Thread.current[:contrived_extra_tags])

Any thoughts regarding adding interface that would allow for lazy evaluation of certain named tags, and/or the ability to add a tag that only lives for the scope of the current execution (tagged block)?

Not sure I understand the requirement for lazy evaluation of named tags. If you want named tags within one thread to be automatically copied to a spawned thread within that same block, then checkout: http://reidmorrison.github.io/parallel_minion/
Parallel Minion was created as a thin wrapper on top of Thread. It adds logging around thread calls and copies logging named tags.

@reidmorrison thanks for the parallel minion info.
Since creation of this PR I've realized that what we were searching for architecturally was not having to use the closure style of tagged. Hopefully what I mean by that is clear in the above example(s).
Once we recognized that, we realized the implications were not ideal and we prefer the simplicity / safety of the closure. We've rearchitected our implementation to work with the tagged architecture.


chore: fix this.rootSpan undefined bug in PageLoadInstrumentation

Description
Fix this context in the enable method
this.rootSpan is undefined in the fn this.addDeviceAttributes
The issue occurs because this.rootSpan is undefined when the enable method is called. This PR resolves the issue by converting the enable method to an arrow function, ensuring that the this value is preserved from its lexical scope.
Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10960896859
Commit: d40ebc114f47e6ee1748748f3ec18a3dcc7e685f
Workflow: PR Automation test suite
Tags: @tag.Sanity
Spec: ``
Fri, 20 Sep 2024 14:15:43 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true


Verify postgreSQL as a k3s backend

What kind of request is this (question/bug/enhancement/feature request):
enhancement/feature request
Details:
Currently k3s does not support postgresql on the Rancher Support Matrix, we need to perform Validation Steps to achieve this
ref - https://github.com/k3s-io/k3s/issues/2828
@cjellick
gz#14360

@rancher-max can you post test results / information in this issue?

@rancher-max can you post test results / information in this issue?

Validated per our db certification matrix:

Fresh Installation and run Sonobuoy Conformance tests
Run functional test (all automated regression tests) on imported k3s cluster on Rancher
Validate a longhorn deployment

k3s version: v1.19.5+k3s2
postgres version 11.5 (on AWS RDS)

Validated per our db certification matrix:

Fresh Installation and run Sonobuoy Conformance tests
Run functional test (all automated regression tests) on imported k3s cluster on Rancher
Validate a longhorn deployment

k3s version: v1.19.5+k3s2
postgres version 11.5 (on AWS RDS)

@rancher-max If we haven't yet we should also check: 1.17, 1.18, 1.20 K3s. Even if this is minimally a smoke test becuase we need to add it to the support matrix page for each of those versions soon.

@rancher-max If we haven't yet we should also check: 1.17, 1.18, 1.20 K3s. Even if this is minimally a smoke test becuase we need to add it to the support matrix page for each of those versions soon.

The same as above has been validated now using the following versions: v1.17.17+k3s1, v1.18.15+k3s1, and v1.20.2+k3s1.
Note this was all done using Rancher v2.5.5.

The same as above has been validated now using the following versions: v1.17.17+k3s1, v1.18.15+k3s1, and v1.20.2+k3s1.
Note this was all done using Rancher v2.5.5.

The plan is to get this added to the upcoming Rancher v2.5.6 support matrix.

The plan is to get this added to the upcoming Rancher v2.5.6 support matrix.

@davidnuzik would we be able to validate 12.5 as well as 11.5?

@leflambeur is there a deal at stake or anything I should be aware of? Feel free to enter a new GH issue to request this and notify me. Perhaps for March k3s patches we can do this (next Rancher v2.5.7).


Updating licensing information for 3/22/2021

Docs Build status updates of commit 7d3d0f4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

licensing-information.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


⚠ Bofrost.at has degraded performance

In f5fa973, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1715 ms

Resolved: Bofrost.at performance has improved in 9188375.


Linux based NCM device shows up "UsbNcm Host Device", ignoring iManufacturer and iProduct

I have a linux based NCM device. On Mac and Linux it shows up with the correct manufacturer and name. On Windows it shows up as "UsbNcm Host Device". Am I doing something wrong or is it a limitation of the driver?

because the driver inf file is microsoft default one, not you custom


Extra converting in coo_matrix.multiply() when multiplying vector

coo_matrix.multiply() method is inherited from spmatrix, which convert self to csr format before calculating.
# in base.py
class spmatrix(object):
    # ...
    def multiply(self, other):
        return self.tocsr().multiply(other)

However, in csr_matrix.multiply(), when multiplying a dense vector, it's done by converting to coo_matrix first. It's inherited from _cs_matrix.
# in compressed.py
class _cs_matrix(_data_matrix, _minmax_mixin, IndexMixin):
    # ...
    def multiply(self, other):
        # ...
        ret = self.tocoo()
        # ...
        # Sparse matrix times dense row vector.
        elif other.shape[0] == 1 and self.shape[1] == other.shape[1]:
            data = np.multiply(ret.data, other[:, ret.col].ravel())
        # Sparse matrix times dense column vector.
        elif other.shape[1] == 1 and self.shape[0] == other.shape[0]:
            data = np.multiply(ret.data, other[ret.row].ravel())
        # ...

That is to say, coo_matrix.multiply() should be overwritten to avoid these two time-consuming and meaningless converting.
Scipy/Numpy/Python version information:
scipy:1.2.1
numpy:1.16.2
python:3.6.7

Sorry, there is one thing I ignored previously. When there are duplicate elements, the behavior will be different. Converting to csr will first sum them, but directly multiplying will keep them.


Create conversation protocol

Create conversation protocol (always start with login message, then continue as normal)

silly-msg-binary-conversation.md is created to describe SMBP conversation protocol

silly-msg-binary-conversation.md is created to describe SMBP conversation protocol


Update DG deletedebt diagrams

Codecov Report
Base: 69.93% // Head: 69.93% // No change to project coverage :thumbsup:

Coverage data is based on head (9b55f7c) compared to base (9c79152).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #310   +/-   ##
=========================================
  Coverage     69.93%   69.93%
  Complexity      717      717
=========================================
  Files           106      106
  Lines          2428     2428
  Branches        322      322
=========================================
  Hits           1698     1698
  Misses          609      609
  Partials        121      121

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Please add wildchar in global config

In global config json. I have to add all include json manually, could you support wildchar mode, like *_req.json?

Good suggestion. I can add this to Moco todo list.


Update SnapshotHelper.js

Critical change of SnapshotHelper.js methods signature
Added Snapshot.language() method

Could you provide information about why you want this change and what it fixes/improves?

Why is it critical

Sorry for confusion. I would better say that it's breaking change.
I have changed the signature of the SnapshotHelper.js methods so now you should call them with Snapshot prefix, e.g. Snapshot.captureLocalizedScreenshot(name).

Closing in favor of https://github.com/KrauseFx/snapshot/releases/tag/1.0.0


Unbreak the example project

Summary
Current example project doesn't build (due to the double {{ around Platform.OS), so I fixed it. Also, I noticed that it always shows (iOS) even though I run it on Android. Fixed that as well.

Test Plan

What's required for testing (prerequisites)?
$ yarn
$ npx react-native run-android

What are the steps to reproduce (after prerequisites)?
See above
Compatibility

OS
Implemented

iOS
✅

Android
✅

Checklist

[x] I have tested this on a device and a simulator
[-] I added the documentation in README.md
[-] I mentioned this change in CHANGELOG.md
[-] I updated the typed files (TS and Flow)
[-] I added a sample use of the API in the example project (example/App.js)

Can you take a look, @grabbou?


Fixing publish workflow

Seems like https://github.com/facebook/akd/pull/406 needed to also specify the rust toolchain in the workflow

Seems like #406 needed to also specify the rust toolchain in the workflow


Issues with storyboards

Hi,
there is an issue with storyboards when designing views are not always we updated even without changes to the demo. Sometimes a change to any view make others invisible and changing again make them appear but it's really buggy.
Using Xcode 8 and branch swift 3 and 2.3 (I'm only interested by the 3 but same thing appear on 2.3)
I think it's a ib designable bug because code is perfectly working at run time.
Tho great lib, saved my day while porting my app to iOS 8

I think it's an Xcode bug. Sometimes the frame in the size inspector is correct, but the view in IB doesn't appear to be in the correct size.


Read bag files only once from the recorded file.

I am trying to get the frame_id and timestamps of the recorded video. I am using examples from python which are in autoplay mode, and therefore, timestamps and frame_id are repetitive. How can I solve this issue?

Hi @ankith001, the RealSense SDK build-in tool rs-rosbag-inspector provides frame number and timestamps in a GUI interface. Please take a look

Can we close this ticket if issue is resolved.


Add Sync bound to ProgressTracker

Fixes #467, alternative to #468.
@rctlmk does this fix your original issue?

Yep, looks good.


Get --analysisOnly to CLI that will only check for the type errors without building

As said, should work like awesome --transpileOnly but instead of only transpiling it should do only type error checks and exit with 0 or 1 as before.
Should be relatively easy I guess since normal program run will do both: static checks and build. We just need to do the latter.
Maybe I can make a PR, but I'd like to get some feedback first.
 Works great!


Notebook cell times out on firefox

This appears to be a regression between 0.19.1 and 0.20.0

From: https://developer.mozilla.org/en-US/docs/Web/URI/Schemes/data
Firefox version 97 and newer supports data URLs of up to 32MB (before 97 the limit was close to 256MB)
Incidentally: 0.19.1 had a size of 24MB, and with the 33% overhead of base64 encoding came in at 31.9MB
0.20.0 ballooned to 27MB (36MB encoded).


Make "our setup" branch

As discussed in chat. Nice-to-have.

I can't remember what this is

A branch that just contains the build system setup with explanations and stuff

Yes so that people can looks at the branch if they want to start similar setup.

rollup & plugins
post CSS
preact
travis size check
etc.

basically scaffolding of project without content (minus maybe index.ejs and "hello world" preact with post CSS) & some commentary of what it does.


Update to version of Agenda that uses promises when available

The scheduler module needs to be decoupled from the bot module when this is done as otherwise it limits reuse of that module for other bots/platforms in the future.


update ord version & lock pnpm version in ci

Summary
Documentation for ord and env is currently not compatible with the latest version

Closes #issue

Vercel – rooch-portal-v1-geek — Deployment has failed
remove it, next pr add


Revert 46 minute threshold

This partially reverts commit 57ccf259e39e1e6d33ebc140814166820abb4c6f (https://github.com/docker/go-units/pull/22).
Using 46 minutes as a threshold proved to be confusing (see https://github.com/moby/moby/issues/38807), given that the human-duration does not use "15 minute" precision anywhere.
Before this patch, 47 minutes was shown as "About an hour". With this change, it's shown as "47 minutes".
Addresses https://github.com/moby/moby/issues/38807

@vdemeester @AkihiroSuda PTAL (happy to get your input on this one)

Thinking of pushing a new tag after this one (and my other PR https://github.com/docker/go-units/pull/33) is merged; WDYT; should that be v0.3.4 or v0.4.0 ?

I would vote for 0.4.0


JSON FileProvider does not mention new method .ConfigureAppConfiguration() on the WebHostBuilder.

When trying to add my own custom JSON file to the configuration using ASP .NETCore 2.1 I had to use .ConfigureAppConfiguration() instead of  .AddJsonFile() as the latter wouldn't add the configuration to the provider list.  Couldn't find that documented here

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @PhilPeters304 ... You didn't mean to say "instead of," did you? Did you mean to say you had to use AddJsonFile inside of ConfigureAppConfiguration?
It's covered a little earlier in the Providers section ...
https://docs.microsoft.com/aspnet/core/fundamentals/configuration#providers
Yes, I see an update that will help resurface it in the provider sections ...
Just prior to each mention of UseConfiguration, the sections should add that to configure the app to use ConfigureAppConfiguration and link back up to the Providers section.
Thanks for opening this. We just did a major overhaul of the topic a couple of weeks ago, and your feedback will help improve it.

Sorry yes! I did mean that exactly!  I read too far down! Thanks


Policy overview different to edit view...

Then in the overview of authentication policies, the view is this:

However, then you edit the policy, it looks like this:

Fixed in Release 2.6.9


Merge dev branch of v2.6.1 to the master branch

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a582081). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #182   +/-   ##
=========================================
  Coverage          ?   17.12%
  Complexity        ?      662
=========================================
  Files             ?      413
  Lines             ?    12406
  Branches          ?     1441
=========================================
  Hits              ?     2125
  Misses            ?    10046
  Partials          ?      235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a582081...616c61d. Read the comment docs.


Fix exception causes all over the codebase

This is a continuation of #2189 .

@jaraco Looks like I forgot to mark this as "ready for review", I did that now.

@jaraco Nudge

Fixed.


Renamed deprecated property device_state_attributes

With https://github.com/home-assistant/core/pull/47304 the deprecated property device_state_attributes has been renamed to extra_state_attributes.
It was set to deprecatey by December 2021. Apparently since 2022.04 the support for device_state_attributes has been removed.
After changing the attributes are back again.

I have asked @eavanvalkenburg  to review this code change. Maybe we have to rewrite the code to not cintain depricated methods.

Looks good to me!


Update upload endpoints and API

What does this PR do?
Make the plugin compatible with API v2 and US5 region

Codecov Report

Merging #51 (9c13ee6) into main (b34e475) will decrease coverage by 0.29%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main      #51      +/-   ##
============================================
- Coverage     87.93%   87.64%   -0.29%
- Complexity      120      122       +2
============================================
  Files            19       19
  Lines           348      348
  Branches         42       42
============================================
- Hits            306      305       -1
  Misses           25       25
- Partials         17       18       +1

Impacted Files
Coverage Δ

...in/kotlin/com/datadog/gradle/plugin/DatadogSite.kt
57.14% <57.14%> (ø)

...m/datadog/gradle/plugin/DdMappingFileUploadTask.kt
98.25% <100.00%> (-0.03%)
:arrow_down:

...m/datadog/gradle/plugin/internal/OkHttpUploader.kt
87.72% <100.00%> (+0.68%)
:arrow_up:


[BUG] Invalid resource type Microsoft.Storage/storageAccounts/blobServices/containers

Library name and version
Azure.ResourceManager.Storage 1.1.1
Describe the bug
We try to fetch a GenericResource for the type BlobContainerResource and provide a proper ResourceIdentifier by using BlobContainerResource.CreateResourceIdentifier. However, when we call Azure.ResourceManager.ArmClient.GetGenericResources().Exists(resourceIdentifier) if throws an InvalidOperationException with the error message: Invalid resource type Microsoft.Storage/storageAccounts/blobServices/containers
Expected behavior
A proper GenericResource is returned
Actual behavior
throws InvalidOperationException with the error message: Invalid resource type Microsoft.Storage/storageAccounts/blobServices/containers
Reproduction Steps
Create a Storage Account and a Blob Container. Try to fetch the GenericResource with a ResourceIdentifier created from BlobContainerResource.CreateResourceIdentifier.
Environment
No response

@ArthurMa1978
The error looks is from SDK code, and is on a common API Azure.ResourceManager.ArmClient.GetGenericResources().Exists(resourceIdentifier), do you have any idea?

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @jeromekol
GenericReource is from Azure.ResourceManager.Resources for operating all resources based on JSON data, here is some GenericReource usage sample from our internal test code.
And if you want to operate BlobContainr, we suggest using BlobContainerCollection, here are some samples hope this helps:
Sample2_ManagingBlobContainers.md


Contribution to "Prototype Pollution in minimist"

Updates

Affected products

Duplicate of #140. Duplicate of #139. Duplicate of #138. Duplicate of #137. Duplicate of #136.


Disk size not detected on ZFS mirror

It would appear that YABS has troubles detecting disk size on ZFS Mirror created by Proxmox.
Steps to reproduce:

Install Proxmox 7.1, during installation choose ZFS (RAID1)
Run YABS.

zpool status:
config:

        NAME                                 STATE     READ WRITE CKSUM
        rpool                                ONLINE       0     0     0
          mirror-0                           ONLINE       0     0     0
            nvme-eui.6479a74f705011bf-part3  ONLINE       0     0     0
            nvme-eui.6479a74f705011ea-part3  ONLINE       0     0     0

YABS (notice the empty Disk):
# ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## #
#              Yet-Another-Bench-Script              #
#                     v2022-02-18                    #
# https://github.com/masonr/yet-another-bench-script #
# ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## #

Fri 01 Apr 2022 08:46:49 PM CEST

Basic System Information:
---------------------------------
Processor  : AMD Ryzen 5 3600 6-Core Processor
CPU cores  : 12 @ 3600.000 MHz
AES-NI     : ✔ Enabled
VM-x/AMD-V : ✔ Enabled
RAM        : 62.8 GiB
Swap       : 0.0 KiB
Disk       :

fio Disk Speed Tests (Mixed R/W 50/50):
---------------------------------
Block Size | 4k            (IOPS) | 64k           (IOPS)
  ------   | ---            ----  | ----           ----
Read       | 311.06 MB/s  (77.7k) | 1.64 GB/s    (25.6k)
Write      | 311.88 MB/s  (77.9k) | 1.65 GB/s    (25.8k)
Total      | 622.94 MB/s (155.7k) | 3.29 GB/s    (51.5k)
           |                      |
Block Size | 512k          (IOPS) | 1m            (IOPS)
  ------   | ---            ----  | ----           ----
Read       | 2.91 GB/s     (5.6k) | 3.53 GB/s     (3.4k)
Write      | 3.06 GB/s     (5.9k) | 3.77 GB/s     (3.6k)
Total      | 5.97 GB/s    (11.6k) | 7.30 GB/s     (7.1k)

iperf3 Network Speed Tests (IPv4):
---------------------------------
Provider        | Location (Link)           | Send Speed      | Recv Speed
                |                           |                 |
Clouvider       | London, UK (10G)          | 837 Mbits/sec   | 719 Mbits/sec
Online.net      | Paris, FR (10G)           | 926 Mbits/sec   | 783 Mbits/sec
WorldStream     | The Netherlands (10G)     | 925 Mbits/sec   | 780 Mbits/sec
WebHorizon      | Singapore (400M)          | 785 Mbits/sec   | 403 Mbits/sec
Clouvider       | NYC, NY, US (10G)         | 336 Mbits/sec   | 476 Mbits/sec
Velocity Online | Tallahassee, FL, US (10G) | 845 Mbits/sec   | 258 Mbits/sec
Clouvider       | Los Angeles, CA, US (10G) | busy            | 12.0 Mbits/sec
Iveloz Telecom  | Sao Paulo, BR (2G)        | 694 Mbits/sec   | 126 Mbits/sec

Geekbench 5 Benchmark Test:
---------------------------------
Test            | Value
                |
Single Core     | 1320
Multi Core      | 7772
Full Test       | https://browser.geekbench.com/v5/cpu/14017622

This was a conscious decision because adding zfs to the types of disks to add to the total was throwing things off quite a bit. Something about how Linux and df handles zfs partitions.
This is the command that calculates the total space available: df -t simfs -t ext2 -t ext3 -t ext4 -t btrfs -t xfs -t vfat -t ntfs -t swap --total -h. As an experiment, try adding "-t zfs" in the command above and see if the last line (total) has what you expect and let me know what you see.

The total is indeed far off as subvolumes have the same available space as the parent yet they are still counted as separate entities by df. Perhaps it would be the best to just print out the result of zpool list -H -o name,size if ZFS is detected?

Tabling this for now until I have more time to work in a better solution (and have a test machine handy) for ZFS-based systems.

Some information here on what we are seeing on our zfs backed LXD containers - inside a container running the command from @masonr gives us:
# df -t simfs -t ext2 -t ext3 -t ext4 -t btrfs -t xfs -t vfat -t ntfs -t swap --total -h
Filesystem                         Size  Used Avail Use% Mounted on
/dev/mapper/ubuntu--vg-ubuntu--lv   99G   18G   76G  20% /dev/ppp
total                               99G   18G   76G  20% -

We recently exposed the /dev/ppp device to containers in order to help some users set up VPN applications, and for some reason which I am not savvy enough to know about this maps to the LVM volume on the host, giving an incorrect disk reading of 99G
including -t zfs gives us the zfs volume, but also includes the /dev/ppp device:
# df -t simfs -t ext2 -t ext3 -t ext4 -t btrfs -t xfs -t vfat -t ntfs -t swap -t zfs --total -h
Filesystem                         Size  Used Avail Use% Mounted on
lxd/containers/checklore            94G  4.3G   89G   5% /
/dev/mapper/ubuntu--vg-ubuntu--lv   99G   18G   76G  20% /dev/ppp
total                              192G   23G  165G  12% -

Giving us even more skewed numbers in this case.
@masonr let me know and I can give you access to an LXD VPS with this behavior if you want to test some things. Seems to me a better approach is needed here but I don't have any concrete suggestions at this point - maybe look for "mounted on /" and only use that entry?.

@webdock-io -- just curious, what is the "type" for the /dev/ppp volume? df -T

@masonr Sorry for the slow turnaround here - the type is ext4:
root@checkleeloo:~# df -T
Filesystem                        Type          1K-blocks     Used Available Use% Mounted on
lxd/containers/checkleeloo        zfs            24414080  4654848  19759232  20% /
none                              tmpfs               492        4       488   1% /dev
udev                              devtmpfs      198033540        0 198033540   0% /dev/tty
/dev/mapper/ubuntu--vg-ubuntu--lv ext4          112245028 13961632  92535480  14% /dev/ppp
...


Bump version to 3.0.0-beta.11

really testing the compressed size action, but this might be needed soon anyway :)

Looks like the package-lock needs a rebase


Unexpected black frame around the instatus button in the footer

It's beacause the embedded iframe's (https://denostatus.com/embed-status/light-sm) html automatically has color-scheme: dark (instatus follows the system dark mode). I think it's configurable in the instatus dashboard.


ActivityIndicator remains on screen after being removed

I put an ActivityIndicator on screen, which should be removed after some time (i.e. when the data arrives). But the problem is that it still remains on screen even after it is removed (or not outputted) in the render function. In addition, the backgroundColor of the View above disappears, too.
I also found out that doing one of the following things fixes the problem, but I don't know why:

Unset the zIndex for the View above (having zIndex here has no reason what so ever, but I needed this in the project I was working on)
Set a backgroundColor for the View element containing this ActivityIndicator.

Public repository with runnable example
Inline code:
export default class TestReport extends Component {
    state = {
        showIndicator: true,
    };

    componentDidMount() {
        setTimeout(() => this.setState({showIndicator: false}), 3000);
    }

    render() {
        return (
            <View style={styles.container}>
                <View style={styles.firstHalf}>
                </View>
                <View style={styles.secondHalf}>
                    {this.state.showIndicator
                        ? (<ActivityIndicator size="large"/>)
                        : (<Text>hello</Text>)}
                </View>
            </View>
        );
    }
}

const styles = StyleSheet.create({
    container: {
        flex: 1,
    },
    firstHalf: {
        zIndex: 1,
        flex: 1,
        backgroundColor: "#2f2",
    },
    secondHalf: {
        flex: 1,
    },
});

Here's a screen recording of what happens:

What should happen: the indicator should be removed after 3 seconds and the message hello should appear.
What happens: the indicator remains after the 3 seconds, and the message hello appears. In addition, the backgroundColor of the View above disappears.

Versions:

react-native: 0.41.2
react: 15.4.2
react-native-cli: 2.0.1
devices:

Nexus 5 - Android version: 7.1
LG G2 mini - Android version: 5.0.2

Have you tried setting animating property on the <ActivityIndicator> instead of using a conditional? https://facebook.github.io/react-native/docs/activityindicator.html

If I do it this way, it works, but it still occupies space:
<ActivityIndicator size="large" animating={this.state.showIndicator}/>
{this.state.showIndicator ? null : (<Text>hello</Text>)}

I can hide it like this, which is not pretty:
<ActivityIndicator size="large" animating={this.state.showIndicator}
    style={this.state.showIndicator : null ? {height: 0}/>
{this.state.showIndicator ? null : (<Text>hello</Text>)}

But if I do it this way, it doesn't change anything:
{this.state.showIndicator
    ? (<ActivityIndicator size="large" animating={this.state.showIndicator}/>)
    : (<Text>hello</Text>)}

I'm not really interested in getting this piece of code to work. I'm just asking, am I doing something wrong or is this not the expected behavior?

Looks like a bug with zIndex and view collapsing, the current implementation of zIndex is pretty buggy because it reorders views instead of just changing the drawing order.
As a workaround you could either

Remove the zIndex, if possible
Add collapsable={false} to your view that wraps the activity indicator

Thanks

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


server_events_dispatch: Remove body fade out on changing theme.

This causes the app to scroll to top and causes slow paint.
discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/changing.20theme

Whoa, this feels much nicer!
Can you add the "integration review" label once it passes CI?

Ok, I will try.

Opened https://github.com/zulip/zulip/pull/25792 to track that follow-up; given the other things on the agenda, I think that's not a release goal.


Support PHPUnit 9.2.6 (via copypasta)

Same tragedy as https://github.com/wizaplace/phpunit-slicer/pull/8 but tried to separate the absolute minimum changes to phpunit sources and kept the original library files as much as possible
Couldn't resist to use github actions, apologies. It's so much more convenient.
This is the commit showing the minimal changes to the official files => https://github.com/wizaplace/phpunit-slicer/pull/9/commits/27ad279d3e5430b39c33bfb0462feabf5adb2b43
diff --git a/src/Vendor/PHPUnit/TextUI/Command.php b/src/Vendor/PHPUnit/TextUI/Command.php
index 9e5fb7d..b6bf800 100644
--- a/src/Vendor/PHPUnit/TextUI/Command.php
+++ b/src/Vendor/PHPUnit/TextUI/Command.php
@@ -7,7 +7,7 @@
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
-namespace PHPUnit\TextUI;
+namespace Wizaplace\PHPUnit\Slicer\Vendor\PHPUnit\TextUI;

 use PharIo\Manifest\ApplicationName;
 use PharIo\Manifest\Exception as ManifestException;
@@ -26,6 +26,7 @@
 use PHPUnit\TextUI\Configuration\PhpHandler;
 use PHPUnit\TextUI\Configuration\Registry;
 use PHPUnit\TextUI\Configuration\TestSuiteMapper;
+use PHPUnit\TextUI\Help;
 use PHPUnit\Util\FileLoader;
 use PHPUnit\Util\Filesystem;
 use PHPUnit\Util\Printer;
@@ -127,7 +128,7 @@ public function run(array $argv, bool $exit = true): int
     /**
      * Create a TestRunner, override in subclasses.
      */
-    protected function createRunner(): TestRunner
+    protected function createRunner()
     {
         return new TestRunner($this->arguments['loader']);
     }
diff --git a/src/Vendor/PHPUnit/TextUI/TestRunner.php b/src/Vendor/PHPUnit/TextUI/TestRunner.php
index 8db607e..8c7d8ea 100644
--- a/src/Vendor/PHPUnit/TextUI/TestRunner.php
+++ b/src/Vendor/PHPUnit/TextUI/TestRunner.php
@@ -7,7 +7,7 @@
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
-namespace PHPUnit\TextUI;
+namespace Wizaplace\PHPUnit\Slicer\Vendor\PHPUnit\TextUI;

 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestResult;
@@ -33,6 +33,8 @@
 use PHPUnit\TextUI\Configuration\ExtensionHandler;
 use PHPUnit\TextUI\Configuration\PhpHandler;
 use PHPUnit\TextUI\Configuration\Registry;
+use PHPUnit\TextUI\DefaultResultPrinter;
+use PHPUnit\TextUI\ResultPrinter;
 use PHPUnit\Util\Filesystem;
 use PHPUnit\Util\Log\JUnit;
 use PHPUnit\Util\Log\TeamCity;
@@ -59,7 +61,7 @@
 /**
  * @internal This class is not covered by the backward compatibility promise for PHPUnit
  */
-final class TestRunner extends BaseTestRunner
+class TestRunner extends BaseTestRunner
 {
     public const SUCCESS_EXIT = 0;

@@ -853,7 +855,7 @@ private function write(string $buffer): void
     /**
      * @throws Exception
      */
-    private function handleConfiguration(array &$arguments): void
+    protected function handleConfiguration(array &$arguments): void
     {
         if (isset($arguments['configuration']) &&
             !$arguments['configuration'] instanceof Configuration) {

See my repo for successful GHA run => https://github.com/mfn/phpunit-slicer/actions

Closing as it's unlikely this gets merged, doesn't make much sense.
On top of that, in PHPUnit the classes changed again.
The diffs as outlined in the PR description did not really change, the high level changes are still the same:

copy PHPUnit/TextUI/Command.php
copy PHPUnit/TextUI/TestRunner.php
adjust namespace
add missing imports
apply the patches
done

I just did it in a private codebase for PHPUnit 9.3 all over again (too 5mins, still 😢 )


some Blockly icons are missing

There is a problem with the blockly icons on the bottom-right part of the code screen. (zoom and trash)

I will reupload the missing file in the "about window" pull request.


docker

Any plans for a docker container?
This would be great running on unraid.

Already here my friend. https://github.com/madMAx43v3r/chia-plotter/pull/102


Replace Darragh Grealish with JBD

Signed-off-by: Richard Hartmann<EMAIL_ADDRESS>

:+1:

👍

Yeah the link and into in the schedule still needs updating
On Thu, Aug 9, 2018, 3:24 PM Matthias Rampke<EMAIL_ADDRESS>wrote:

@matthiasr commented on this pull request.
Are these pages linked anywhere, or does that get generated automatically?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/promcon/website/pull/88#pullrequestreview-144833303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAg1mDc7mWoXo4SWZIc9ZxQn4IkB5PEaks5uPDgLgaJpZM4V1qYM
.

:+1:


[22.11] Backport llvmPackages_16

Description of changes
This is a backport of #223282 with some additional (trivial) commits to make it compatible with NixOS 22.11.
It only adds new packages and shouldn't change any existing packages.
We require LLVM 16 for building Chromium (where we need the most recent version (M113) for important security fixes).

On nixos-unstable the builds look fine so far: https://hydra.nixos.org/eval/1794582?filter=llvmPackages_16&compare=1794561&full=
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build llvmPackages_16
I only tested the evaluation so far:
$ nix-instantiate -A llvmPackages_16
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/86fpv6nb4zjpcvjp5xpy25qd6awqhsa5-llvm-binutils-wrapper-16.0.1.drv
/nix/store/28677s50j95vdwa2dmrlbm4rr0n8b0cx-llvm-binutils-16.0.1.drv
/nix/store/dpc8xzf4jgw55jrjz4ssp2smzzidq3wh-llvm-binutils-wrapper-16.0.1.drv
/nix/store/7vhmnsb7lcf986n173x8nya24h435xp8-clang-wrapper-16.0.1.drv
/nix/store/vgagxq7v2ldf37kc7z9kghxajvwkgpzv-clang-manpages-16.0.1.drv
/nix/store/s3ag3ha9miiz8if229azi22zfn9vknk3-clang-16.0.1.drv
/nix/store/pyap0hdcxnknwac3qw4dr37l2wn9mnhr-clang-wrapper-16.0.1.drv
/nix/store/hkaqai3n1r3bygr1jxs8flrxym4qyx57-clang-wrapper-16.0.1.drv
/nix/store/m0s7q6c45wzw427ya4ca2lwqlq5n9niz-clang-wrapper-16.0.1.drv
/nix/store/18a3yhq3y8k7pka2d1jwy6h74bf9dax4-clang-wrapper-16.0.1.drv
/nix/store/3dnhvlc5hir6y7cxs3jsni4nhi7prv75-clang-wrapper-16.0.1.drv
/nix/store/ljrqb9ni31pd348979b6g86srsfiqg0h-compiler-rt-libc-16.0.1.drv
/nix/store/ljrqb9ni31pd348979b6g86srsfiqg0h-compiler-rt-libc-16.0.1.drv
/nix/store/03dikf4i5c9q0kjfakym365kznvf9mha-libcxx-16.0.1.drv
/nix/store/5iiq413szhrvx6zsblrq2m81cdw8cas2-clang-wrapper-16.0.1.drv
/nix/store/ba4snx03y5vqs8fq1j3x5ynfpflw9dm1-stdenv-linux.drv
/nix/store/qjx68q7w3s534k81vf4bw7nrw5fbwvsd-libcxxabi-16.0.1.drv
/nix/store/m3dl5s6j3532r9faxnkqyx13zh5l8pgh-llvm-16.0.1.drv
/nix/store/3mpc941xxrg5z2bv67b21b697p95gg1z-libunwind-16.0.1.drv
/nix/store/5s8v4kjbxni7ijp9njwlbyqkm74rwfpp-lld-16.0.1.drv
/nix/store/0nigf0sca85x6sah7hrg1xx5f7z4i51c-lldb-16.0.1.drv
/nix/store/3fvsx6373npk6r7fzms9iacgf4bbrn25-lldb-manpages-16.0.1.drv
/nix/store/dm8cwh1ivr7dw126lcr2yc4fy4jqx2hi-llvm-manpages-16.0.1.drv
/nix/store/6a9mrlsxv9aqjg2zb3yd3q96zhfcqkl1-openmp-16.0.1.drv
/nix/store/p4phsczxvkddhbf9dyc4hcnhq6ny774g-stdenv-linux.drv

CI seems fine so let's give this a try :)
There should be no regressions as this should only add new packages.


[Docs] update slack url

The Slack url has expired, we need to update it.

/approve
Thx for update


Update launch.json 'program' description

With the .NET CLI shared framework changes, 'program' should now be set to the built application dll in most cases. This updates the template and description.

@caslan please review

LGTM


RAND: Fix code style

Just a few remaining style nit's in rand code.
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Ping @mspncp

@levitte I can merge it (and cherry-pick it to 1.1.1) this evening but feel free to do it yourself if you prefer.

Merged.
master:
c2e33a05b1eb9dda988aebdeaa529973d7c22142 crypto/rand: fix some style nit's
1.1.1:
7f0e220f4d842a7694ed0f8ff9675745977ce9a0 crypto/rand: fix some style nit's

@levitte  I found a indent program in my centos distribution, and i looked up its man page. in the section 'BREAKING LONG LINE S', GNU indent breaks long lines before the boolean operators &&
and || by combining option '-nbbo',  '-hnl' and '--line-length60', which is relevant with the extra indent in your context. Hopefully, this would help you.