raft membership: fix promotion/demotion workflow

Fixes #1090
Simply rolls back the role on node demote if this fails. There is opportunity for a refactoring here as we can add a check upstream and only selectively update node Spec fields, but not sure if really necessary.
/cc @aaronlehmann @tonistiigi
Signed-off-by: Alexandre Beslic<EMAIL_ADDRESS>

LGTM

[Current coverage][cc-pull] is 54.15%

Merging [#1091][cc-pull] into [master][cc-base-branch] will increase coverage by 0.08%

@@             master      #1091   diff @@
==========================================
  Files            75         75
  Lines         11717      11724     +7
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6335       6349    +14
+ Misses         4472       4470     -2
+ Partials        910        905     -5

[][cc-pull]

Powered by Codecov. Last updated by [114f9b5...e2b97e6][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/114f9b5f972c96b5686c56d6b9c3cc2a4d1a293c...e2b97e66d49df600c1aa34132629861b10c77471
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1091?src=pr

Isn't there a race in here depending how much time it takes for the restore to run. Also the Node directly  picks up spec changes so they will still get a change to worker and try to renew certificate. Not sure if it will cause a conflict atm. with demotion but it does leak invalid role.

You're right, we should probably add the check on demote upstream to the Spec changes so that it does not trigger the cert renewal. I'll rework on the PR to move the CanRemoveMember check followed by the Removal. This way this shouldn't trigger the cert renewal and this shouldn't race.
I just wonder what should we do in this case to remain consistent with the Spec update? Should we update everything but the role or nothing on the Spec depending on the demote failure?
/cc @aluzzardi ^^^

@aaronlehmann @tonistiigi PTAL, I refactored UpdateNode and also fixed the scaling down to one manager in the process. I exported Cluster management from raft to separate raw Remove from Remove with quorum failure checks and updated the tests to reflect the demotion to one manager.
@tonistiigi I'm going to give it a try myself, but would be awesome if you can check the behavior on the engine.

Thanks, I'll take care of the comments. Just found a remaining issue where you try to demote yourself as a member, the node would be listed as UNKNOWN and removed but still with the Manager role. Have to fix that and add a few more test cases for UpdateNode.

@abronan I also have some problems with demoting leader. I get a context canceled error and the promoting same node doesn't seem to work(at least for the first time).
root@5e0ac9a640fc:/go/src/github.com/docker/docker# docker swarm init
Swarm initialized: current node (3w2gvjjuczre2e7gvaxeqa77p) is now a manager.
root@5e0ac9a640fc:/go/src/github.com/docker/docker# docker -H <IP_ADDRESS>:4010 swarm join --listen-addr <IP_ADDRESS>:2378 <IP_ADDRESS>:2377
This node joined a Swarm as a worker.
root@5e0ac9a640fc:/go/src/github.com/docker/docker# docker node ls
ID                           HOSTNAME      MEMBERSHIP  STATUS  AVAILABILITY  MANAGER STATUS
3w2gvjjuczre2e7gvaxeqa77p *  5e0ac9a640fc  Accepted    Ready   Active        Leader
dy5kefi0a5ne9xlc0p5s8wuex    5e0ac9a640fc  Accepted    Ready   Active
root@5e0ac9a640fc:/go/src/github.com/docker/docker# docker node promote dy5kefi0a5ne9xlc0p5s8wuex
Node dy5kefi0a5ne9xlc0p5s8wuex promoted to a manager in the swarm.
root@5e0ac9a640fc:/go/src/github.com/docker/docker# docker -H <IP_ADDRESS>:4010 node demote 3w2gvjjuczre2e7gvaxeqa77p
Error response from daemon: rpc error: code = 1 desc = context canceled
root@5e0ac9a640fc:/go/src/github.com/docker/docker# docker -H <IP_ADDRESS>:4010  node ls
ID                           HOSTNAME      MEMBERSHIP  STATUS  AVAILABILITY  MANAGER STATUS
3w2gvjjuczre2e7gvaxeqa77p    5e0ac9a640fc  Accepted    Ready   Active
dy5kefi0a5ne9xlc0p5s8wuex *  5e0ac9a640fc  Accepted    Ready   Active        Leader
root@5e0ac9a640fc:/go/src/github.com/docker/docker# docker -H <IP_ADDRESS>:4010  node promote 3w2gvjjuczre2e7gvaxeqa77p
Node 3w2gvjjuczre2e7gvaxeqa77p promoted to a manager in the swarm.
root@5e0ac9a640fc:/go/src/github.com/docker/docker# docker -H <IP_ADDRESS>:4010  node ls
ID                           HOSTNAME      MEMBERSHIP  STATUS  AVAILABILITY  MANAGER STATUS
3w2gvjjuczre2e7gvaxeqa77p    5e0ac9a640fc  Accepted    Ready   Active
dy5kefi0a5ne9xlc0p5s8wuex *  5e0ac9a640fc  Accepted    Ready   Active        Leader

@aaronlehmann @tonistiigi I was actually wondering if this makes any sense to demote yourself as the Leader. My argument was that it's like shooting yourself in the foot as the node will demote itself and then the clusterapi would be unavailable until it elects a new Leader (it can be 5s but the ElectionTick is configurable and can be high for some users in high-latency networks).
I understand the argument for flexibility to allow users to demote whatever the node they want but anything that results in cluster downtime from direct user action should be avoided imho. And this risks to cause a lot of confusion too.
This does not feel unreasonable to me to disallow demoting the Leader as we can support scaling down to one node and we can't demote the last node anyway (which in this case, will be the Leader).
/cc @aluzzardi

IMHO we should allow demoting the leader. The impact is only a few seconds of time where you can't change the cluster state while you wait for a new election. For many lab/dev setups this is a non-event, and it's a legitimate use case where you want to change the manager topology. I think if we don't allow this, people will complain - and the risk of allowing it is pretty small.

@abronan I think not allowing to demote yourself is fine(currently it ends with "connection is closing" message), but demoting a leader should be allowed. In the example above I use another node to demote the leader.

@tonistiigi I fixed the "connection is closing" so you can now even demote yourself (from Leader or Follower) and this works fine. Currently double checking some other things but should push an update soon.
Still not convinced with allowing to demote the Leader as I think it encourages bad actions on the cluster but I'll lean to the majority and leave it possible to do it. If we consider it dangerous in the future, it's just a simple check to add so I'm fine with allowing it for now.

@abronan cool! do you want to run me integration tests?

integration tests are passed

@aaronlehmann @LK4D4 @tonistiigi PTAL took care of most comments, added a simple test case in controlapi for the scaling down to one Manager that should be complementary to the integration tests.

LGTM
Let's merge this (it's only the uncontroversial parts) and open a separate issue/PR about handling failed demotion more gracefully.

Yeah, let's merge it.
ping @stevvooe

#1090 is tracking the next steps. Let's keep it opened for now.


Fix broken solana pages

Fixes https://linear.app/thirdweb/issue/FTD-1822/solana-not-loading-properly-on-the-overview-page

📝 Changed routes:

/solana/[...paths]

(view full size)

Commit 3e69eb3158ebe749caac234c275ae30e9dd0e8ed (https://thirdweb-ezcb2vcbs.thirdweb-preview.com).


Refactor createPaymentRequestHandler to use switch statement

Description
Reggie pointed out in a PR awhile back that it would be cleaner to use a switch in CreatePaymentRequestHandler and it bothers me every time I look at it that I didn't refactor, so finally just did it.  This puts the possible error types into a switch statement.
Setup
Tests should still pass:
go test ./pkg/handlers/primeapi
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

No Jira story for this change- this is a rogue fix.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 6a218b29cfcd57ade89c6273ee50f5c5ef5f5bf3


Flow colours on day numbers

I recently started trying out this app over Drip as it has not been updated in a while (and lacks a dark mode, lol). But I like how the day number backgrounds were coloured according to the flow that day.
Could you make the flow symptoms more built-in and have the colour display on the day number? Maybe a toggle for a symptom being a flow setting if people want to add custom ones (e.g. spotting)?
This is what I mean:

Welcome! This is absolutely something we can look closer at!


Compute tumor volume from binary mask and list of centroids

Description
This method computes the volume of connected components placed at the specified centroids, via connected component analysis using scipy.ndimage.label.
Reference to official issue
Calculate tumor volume from pixel masks #13
How Has This Been Tested?
The unit test for predict has been added  to test for the volume calculation over the different mask cases.
CLA

[x] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

The Travis CI build failed due to LFS issues #69.

I've refreshed the pull request #78 and made it clearer.


Fluence Validation

Clayton reported working on this: "only simple validation involving interpolating observations to model energy bins and finding the error between obs and model."

@claya71

What I originally thought would be an easy task to clean up prior code has turned out to be harder than expected. Katie has concerns about ensuring that observed differential (integral) fluence spectra are compared to predicted differential (integral) spectra properly. There is also the concern of converting integral channels to 'differential' channels and that needs some caution - take time to ensure conversion is done properly.


Configure horizontal pod autoscaling for the services.

Configure auto-scaling, min 3 instances.

Addressed by https://github.com/bcgov/dts-endorser-service/pull/11


Add Laravel 11 Support

This will be merged when Filament Core has Laravel 11 Support.
https://github.com/filamentphp/filament/pull/10972


Add example how to send all data Simpit provides

Added in commit 7135bf3 in a slightly modified shape (same content, some cosmetic change). Thanks 👍


Remove diagram stuff

Looks good. Could replace it with an image generated by "cargo-dot" https://github.com/maxsnew/cargo-dot

We'll need some kind of architecture overview anyway. I don't mind removing this one, but just curious - what is the motivation?

The old diagram was hand created, if I remember correctly.
Merging.

Yeah, it was out of date, and hard to keep up to date.


Allow Grouping to be used in more places

Allow a) nodes to be sorted by grouped columns and b) grouped columns to be aliased
This also alleviates some of the push in rails to use Arel nodes everywhere instead of using Arel helper methods.
This list of modules is from Attribute since Grouping can be used any place that an Attribute node can be used. Let me know if you want a different list.
This is along the lines of #433 giving a little more flexibility to nodes so people perform logic without having to create new Arel nodes everywhere. This also fixes rails/rails#24631
Thanks
/cc @matthewd this gives rails more lenient sorting

I don't think that the majority of the methods you've mixed in are valid in any context other than when the group contains a single element, or when referring to tuples on PG. If the goal is just to be flexible with tuples on PG, I think we should explicitly separate it out from generic grouping.

when the group contains a single element

huh? :confused:
When does a Grouping ever contain something other than a single value?

(a, b, c)?

When does it ever reasonably contain a single value? It's used for IN statements and grouping multiple boolean expressions

I can't find anywhere it holds an array; everywhere I look it contains a single Node (e.g. Addition, BitwiseShiftLeft, Or), and its only role is to throw parentheses around it.
(Which I incidentally consider pretty semantically questionable -- the visitor should really be working out when parens are needed based on actual operator precedence, not an a priori guess during AST construction. But that's a separate, "one day..", thought.)

@matthewd that's definitely not a visitor concern. A grouping (the parens) is part of the AST, and the visitor should not be responsible for trying to infer intent.

@sgrif Also, when did I lose commit access?

I agree with Ernie's statement, and that's also my concern with adding
these methods here. The AST shouldn't communicate intent but the query
builder should.
On Tue, May 31, 2016, 8:22 AM Ernie Miller<EMAIL_ADDRESS>wrote:

@matthewd https://github.com/matthewd that's definitely not a visitor
concern. A grouping (the parens) is part of the AST, and the visitor should
not be responsible for trying to infer intent.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rails/arel/pull/435#issuecomment-222672571, or mute
the thread
https://github.com/notifications/unsubscribe/ABdWKy4XU62K3df4kM1600wYxGfVsKxJks5qHCgZgaJpZM4IlnSk
.

@ernie Unsure. Wasn't my doing

@sgrif My goal is to build an Arel query, and for it to work in other areas of the code (rails in particular) that are using Arel.
Unfortunately, code depends upon these helper functions and they are inconsistently available.
e.g. select(arel_table[:name]) works but select(arel_table[:name].lower) does not.
Or arel_table[:name].asc works but arel_table[:name].lower.asc does not.
So I though, just slap a Grouping around it and everything will be fine. I agree, adding in parens should not be necessary, but this will not be the first time that liberal use of parenthesis are used to group sql together to ensure no unintended side effects.

I don't think that the majority of the methods you've mixed in are valid in any context other than when the group contains a single element, or when referring to tuples on PG.

Sometimes I want to create a sub query that requires an alias or some other advanced sql.

If the goal is just to be flexible with tuples on PG, I think we should explicitly separate it out from generic grouping.

Did you just say to mix these into Node instead?

@ernie the AST doesn't need a Grouping to know that Mult(Add(1, 2), 3) = (1+2)*3, and not 1+2*3 -- it's intrinsic to the AST structure. It's the SQL output that requires the parens to maintain that knowledge, and it's the visitor's job to convert the AST to SQL.

@matthewd Just because there are situations in which it might be possible to infer the necessity of parens does not mean the visitor must be the one making these inferences. In some cases it makes sense, sure -- but Grouping allows us to delegate that responsibility to objects and methods that know what they're creating and what they want to express.
In any case, I'll let @sgrif respond if there's further discussion to be had.

When do we actually need a grouping node?  The SQL visitor can (and already does) infer when it needs to add parenthesis for most stuff.  I don't think we really need that node unless we want to maintain parens from SQL that's been parsed (but I don't think that's a use-case).

Alright, given the context in which a Grouping node can actually be created in the code base today, I'm going to move forward with this.

@tenderlove don't you think there's value in using the grouping nodes to allow the visitor to be -- dumber, for lack of a better term?

don't you think there's value in using the grouping nodes to allow the visitor to be -- dumber, for lack of a better term?

Not particularly.  Every node already needs to know how many children it can have, which is defined by the node type that it is (e.g. Binary, Unary, etc).  They already have the knowledge about whether or not they need parens.  Adding a child "grouping" node essentially duplicates that knowledge.

@tenderlove Hrm. Allrighty then. :)

@tenderlove If you don't like grouping, can we throw some of these modules directly into Node?
Is there a reason we are so determined to make basic arel helper methods not work when I try and use them? (Or work when I use them, but not work when someone passes me something different)
Alternatively, I can put in a bunch of PRs into Rails to get away from the helper nodes and manually create the Arel nodes.

@kbrock let's introduce an ExprNode (or similar), as a common ancestor for all the.. [scalar] expression nodes. I think that's the set of things you (quite reasonably) want to all behave the same, and should exclude the weirdnesses of "what happens if I call #+ on a FROM clause?" (which is why they're not currently on Node... it's not only because we want to make your life difficult :wink:)

Closed in favor of #449
Thanks for all the comments and suggestions

let's introduce an ExprNode (or similar), as a common ancestor

Did anyone interested get a look at #449 ? It introduces an ExprNode to provide the grouping without allowing everything to have a + on it.


Enable gosimple golangci-lint linter

Description
Enables gosimple linter
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

It appears gosimple has been deprecated. However, these edits are useful and will be caught anyway when we enable staticcheck.


Test installer upgrade path for 0.5.19

We need to check that the upgrade path from 0.5.19 to 0.5.20 works ok.
As noone is using 0.5.19 yet we can simply create a '0.5.20' installer and put the upgrades.xml on the multibit.org server to check it works

I have created installers of the current develop code that point to the multibit updates-test.xml on the multibit.org server and uploaded them to:
https://www.multibit.org/releases/multibit-classic/multibit-0.0.0/
You can test the auto-update path is working by installing any of these - their version is set to 0.5.19 internally. The updates-test.xml points to 0.5.20 and so you get a "There is an update' message at start up.
There are no 0.5.20 binaries on multibit.org (as it will confuse people) so there is no new installer to actually download but other than that it exercises the while update path.
I have tested the Mac one only IRL.
Awaiting review and closing

Verified working.
Closing.


Update Composer dependencies (2024-07-29-00-17)

Visual regression test passed!
View the visual regression test report


Ollama-rs KeepAlive

Nodes may continue to store the LLM in their memory, otherwise memory will be freed by Ollama-rs after 5 minutes of inactivity.

Turns out ollama serve itself accepts an OLLAMA_KEEP_ALIVE variable, defaulting to 5m which means 5 minutes. We should also take this from env.

Closed as if the node is active enough, this will not be a problem; if the model is active with multiple models we have to remove the model nevertheless.


No clear option for link queries

As stated in title (already exists for Node status queries, but not for regular link queries).

Adds clear options for all relevant select fields for release with v0.3.4.


DW Dashboard tab never loads

Insiders/RC1

Install Azure SQL Data Warehouse Insights extension
Open server dashboard

The SQL DW Dashboard tab is in the loading state forever. No obvious errors in the console logs

@aasimkhan30 @kisantia another thing to consider for ask mode

Approved - this fix that @aasimkhan30 looks low risk enough to take and since it was a regression from last release

Confirmed this is now fixed in the latest RC build


Part 2 of the assignment

Using findings from the DFD-based threat analysis from part 1 of this assignment:

Review your OSS project for design-related issues.
Summarize your observations, in particular, highlight the gaps.

Added observations to our main document related to the security controls around file read\write access.

Edited the observations and added the "Investigating" list.

No more suggestions being made. Closing to submit the assignment.


Closing the connector

Calling connector.stop(); doesnt kill the subscribed threads which is throwing errors for me as they are attempting to write to a closed com port.

Hello, thanks for the feedback.
I will fix it as soon as possible and update the library.


docs: Say that certbot wildcard has been released.

Testing plan:
GIFs or screenshots:

Merged, thanks @rht!

Merged, thanks @rht!


Async process progress indicator

Hello,
I would like to display a progress indicator running a command.
However, the run() function is sync and I don't how to switch it in async.
I try with wait_for but without any success as isTerminated isser will be updating after run process.
Any idea ?
If I create a PR, do you think it would be a better idea to add a runningIndicatorMessage to run() function or to add a parameter to make run async ?
Thank you for your help

You could use a fiber for that, we use it to allow parallel running, something like this should work :
$fiber = new \Fiber(fn () => run(...))
$fiber->start();

while (!$fiber->isTerminated()) {
    if ($fiber->isSuspended()) {
        echo 'Still running'; // Here do you own progress indicator
        $fiber->resume();
    }
}

Thank you @joelwurtz !!


Chore support save error log file to s3

Proposed changes
Users may not be able to directly access BE's IP in cloud mode, supporting save the error log to S3 for convenient user access.

run buildall

run buildall

run buildall

run p0

run buildall


Create Postgres DB in Heroku with table for organizations

Bradley created a database with the LA Open Data data and I added the data from the csv files. John copied the data into the temporary DB for the cleanup.


SET foreign_key_checks = 0;

I found and solved an issue.
I have a db ordersmanager with two tables: orders and suppliers.
orders has a column, supplierId, wich is a foreign key to the table suppliers. supplierId is indeed the suppliers' primary key.
Now, if I put a supplier with { supplierId: "AAA", name: "Bob" } and then a order { orderId: "OOO", supplierId: "AAA" } it works, but if I put first the order { orderId: "OOO", supplierId: "AAA" }  and then the supplier  { supplierId: "AAA", name: "Bob" }, it outputs an error, because when I put the order, there is no supplier with id AAA yet.
mysqldump does not take care of this, indeed, in my db .sql backup, it first insert the orders and after the suppliers, resulting in an error.
I have modified the module, now there is the option disableForeignKeyChecks, the default value is false but if it is setted to true then SET foreign_key_checks = 0; is added as the first line of the generated .sql backup file. I tested it and it works. I suggest you, if you want to merge this feature, to modify the readme.md too.

Can you tell me a thing, please? Now that you have pulled my first request, the one with .toLowerCase(), is the modify updated on npm, too? If I install it, can I see that it is updated?


Publish to Hex.pm

poolgirl already exists, unfortunately. We'd probably have to pick a different name 😢.

Perhaps we can name the package mc_poolgirl (while keeping the application name as is.)

Alternatively, we may also pick poolgurl if we want to get sassy.


review & proofreading

sorry for my editor stripping trailing whitespace. I hope it doesn't mess up the formatting of the final HTML document.
I tried to divide this into fairly atomic commits so you more easily reject particular changes

Thank you! This definitely makes things more clear!


CB-5896: Add CDP_FREEIPA_HA entitlement check.

Check the CDP_FREEIPA_HA entitlement when creating FreeIPA HA
clusters.
Fixed the readme for the running the mock-caas.
Closes #CB-5896

@lacikaaa You had given a approval to the PR for master (https://github.com/hortonworks/cloudbreak/pull/7452). I moved the PR master to rc-2.19. Can you please recheck it.


Waiting for asynchronous event listeners?

is there any method/options that i can use to deal with async loading data?
i used casperJS before, the "wait" methods are very useful.
http://docs.casperjs.org/en/latest/modules/casper.html#wait
plz advise, thx.

Actually, crawler will not load async scripts or ajax, you have to do by yourself, that is , queue the ajax url.


tsbd: open blocks in parallel.

It helps to decrease starting time in the case of many big blocks.
Time for blocks to open decreased from 4 min to 18 sec in our case.

The CPU usage in that part of the code is super low, <1%. It's mostly just the serial aspect of opening each blocks that is taking a long time (mmap syscall + read IO).
We noticed it while trying to understand why on some of our clusters prometheus was taking 20min+ to startup. Part of it was the snapshot loading + WAL replay, but there was also 10min+ between these two logs:
ts=2024-10-17T10:16:07.849Z caller=db.go:1020 level=info component=tsdb msg="Found and deleted tmp block dir" dir=/prom-data/chunk_snapshot.853467.0099483648.tmp

ts=2024-10-17T10:28:32.426Z caller=head.go:626 level=info component=tsdb msg="Replaying on-disk memory mappable chunks if any"

And that's how we ended up adding more logs and finding that this function was the reason for our slow startup.

Thanks for the details. I assume most of the segments in the .../chunks directories are 512 MB. I'm currently working on this part of the code and will run some tests on my end. I'll get back to you soon.

Yes 512MB. I didn't include the chunks output because it was too many lines, but I could get the count in each folder if you want.

I gave this a try, but unfortunately, I couldn't reproduce the 10min+ delay or something with a similar order of magnitude.
I'm not trying to doubt your debugging, but the following steps will help me see better: Could you compile Prometheus with https://github.com/machine424/prometheus/commit/c29c5f95123257509504f653a077d8852a222b69, run it, and share the startup logs with me?
I suspect the slowness comes from the major page faults caused by the numerous accesses to the mmapped index during its processing here: https://github.com/prometheus/prometheus/blob/92fdf651876a8fad171c1c8fe7162dd8787e70b9/tsdb/index/index.go#L1165)
If that's the case, concurrency may need to be implemented with caution (as I suggested earlier, perhaps enabling it only during startup and limiting the number of goroutines) to avoid impacting non-open-block-related goroutines. See https://valyala.medium.com/mmap-in-go-considered-harmful-d92a25cb161d.
Also, could you share more about your setup? OS, disk type, available memory, etc.
Does the startup become faster after the first attempt? I'm trying to see if file system caching has something to do with this.


add {virtual}memory limits, defaulting to 10GiB

not tested yet

@Dieterbe can you also add a request-timeout setting.   I have noticed that when the memory usage gets out of control request latency often goes above 1minute (which is shouldnt as the request will be cancelled after 60s by the tsdb-gw)
i think a default value of 65 seconds would be ideal.

tested in qa, seems to work fine.


ff-other-file-name is removed in emacs 28

Instead of ff-other-file-name ->  ff-find-the-other-file should be used.

Note: I will fix, that issue is for me to track the issue.

Thanks!


Linux support

Should this pull and build JSC? Or link against existing libs that are packaged?

I believe it should use existing libraries shipped with a distribution or provided by the user. Both approaches have problems, but I believe having to maintain a reliable, cross distribution fetch-and-build mechanism is the greater evil.

Works on Linux for now. Maybe make changes when doing Windows and supporting building JSC ourselves.


Use xs:normalizedString instead of xs:string where needed

Because it removes line feeds, carriage returns, and tab characters when parsed by the XML processor.
https://www.w3schools.com/xml/schema_dtypes_string.asp
Even xs:token might be meaningful in some places (also collapses multiple whitespaces and removes leading/trailing ws).

Where exactly do you want to use normalized strings instead of normal strings? Are there any use cases where it is necessary to prohibit  etc.? In some cases, string enumerations are used (e.g. for Switches). I think, these have to remain as strings.

This was just a measure to make CPACS documents safer. Especially for enum values we wouldn't want newlines, tabs or other invisible characters contained.
However, this link explains that the xsd:normalizedString and xsd:token only show the intent, and are currently not validated even by official XSD parsers.
So the situation is that we don't get an actual benefit unless our tools help enforce the stricter definition of these types (I could do that in my tools, if needed).
Nevertheless in many cases I would prefer a restriction to xsd:token over xsd:string as it corresponds with what programs would do with these strings anyway (strip non-printable characters, and probably leading and trailing white spaces as well).

I could imagine that such a restriction can be useful in some cases (e.g. links to UIDs, probably <name> nodes, ...). Maybe for <description> nodes we should stay with a string in order to Permit some text formatting. Regarding enumerations I first thought they would be restricted to string types, but I now guess, they can be used in Tokens and normalizedStrings, as well. Is that correct? Anyway, I thought enumerations would not permit additional whitespaces etc. either.

As far as I understand xsd:token (based on xsd:normalizedString) is not a restriction, i.e. validation is successful even though spaces and tabs are used. I tried with Eclipse and lxml. The XML processor just strips the string before passing it to the validator. The actual benefits of this are not yet quite clear to me, but under these conditions, the element may currently have little significance for our way of working with CPACS.
I will keep the possibility in mind and close the issue for now, as it is not acute at the moment. If it is needed in a suitable place, we can think again about the introduction and reopen the issue.


SiGLA

I'm wondering about these inclusions: https://github.com/TRaSH-/Guides/blob/9f995c58e314be08f3dfbecd85a87a6c1222ad31/docs/json/sonarr/cf/bad-dual-groups.json#L134
https://github.com/TRaSH-/Guides/blob/9f995c58e314be08f3dfbecd85a87a6c1222ad31/docs/json/radarr/cf/bad-dual-groups.json#L134
I had not heard of them before but they recently released Solar.Opposites.S03.1080p.DSNP.WEB-DL.DDP5.1.H.264-SiGLA which trumped the NTb release on e.g. HDB/BHD.

They take existing releases and remux them to make a foreign audio the primary track


Not an issue but a question

[Is it possible][/[Does someone tryed] to compile and port a Windows Forms application?
Are there a working example of WinForms app?
Thank you all.
Davide Urbani

what do we use now for XNA, as it is no longer officially supported and i have no idea how to install it on VS2015

As I remember, community repack of XNA works with VS 2015.


2023.12 Broke Pop-Up Card

When I tap my navigate button it no longer pops up the vertical stack. starting happening after upgrading to HA 2023.12

Did some more testing, and it's actually the "tap action" on the tile card that doesn't seem to work for anything anymore. If i put the navigation action on the icon tap it'll still open up the pop-up. so i think this is on Home Assistants side


compile_commands.json is not complete (IDFGH-7955)

Is your feature request related to a problem? Please describe.
I'm using clangd in vscode to parse the code, seems the generated compile_commands.json in build folder is not complete, e.g., the ledc.c and tasks.c of freerots will not be recorded in compile_commands.json. This causes some error during code parsing.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
Update the compile scripts to generate a right compile_commands.json
A clear and concise description of what you want to happen.
Describe alternatives you've considered
none
A clear and concise description of any alternative solutions or features you've considered.
Please give as many details as you can. Include suggestions for useful APIs or interfaces if relevant.
Additional context

vscode with clangd extension
idf 4.4.1
windows 10
Add any other context or screenshots about the feature request here.

@ldmik could you please attach the generated compile_commands.json file where you observe this issue? Does this issue occur also with the default IDF examples, such as hello_world?

compile_commands.zip
hello_world_main.zip
Hi @igrr , here's my compile_commands.json file which generated by a modified hello world project based on example of the master branch.
I see there are ledc.c and tasks.c file in compile_commands.json file, but when I using clangd to goto the definition, always it can't go to the expected source code but to the declaration position.

If the compile_commands.json is generated correctly, perhaps the issue is with clangd extension?
Please have a look also at https://github.com/espressif/esp-idf/issues/6721 where other users have had some limited success in using clangd.

I'm going to close this issue since compile_commands.json was generated correctly, and there was no further response.


Core dumped when running mnist_nlp example

I cannot run the MNIST NLP example on Ubuntu 16.4. I run it like this:
(.venv2) gamer@gamer:~/neon$ python examples/mnist_mlp.py
RuntimeError: module compiled against API version 0xb but this version of numpy is 0xa
terminate called after throwing an instance of 'std::runtime_error'
  what():  numpy failed to initialize
Aborted (core dumped)

My nvcc version is 8
(.venv2) gamer@gamer:~/neon$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2016 NVIDIA Corporation
Built on Tue_Jan_10_13:22:03_CST_2017
Cuda compilation tools, release 8.0, V8.0.61

When running check_gpu, I have
(.venv2) gamer@gamer:~/neon$ nvcc neon/backends/util/check_gpu.c && ./a.out; echo $?
nvcc warning : The 'compute_20', 'sm_20', and 'sm_21' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).
255

Can you upgrade to Neon2.2 or 2.3? It sounds a numpy version conflict.

Hi,
Your issues might be different but from this thread https://github.com/NervanaSystems/neon/issues/398#issuecomment-340120280
the following was tried to fix the numpy 0xb vs. 0xa error:
"
I just rebuilt neon and tried
pip install --upgrade numpy --no-cache-dir
to fix that error
"

I installed the latest version of Neon. Also, I did upgrade numpy, but this time the error is "backend must be one of ('cpu')

which platform are you running? Can you specify the backend as "-b mkl" or "-b cpu"?

Ubuntu 16.4. "-b mkl" -> invalid choice: 'mkl' (choose from 'cpu'),  "-b cpu" seems to work (10 epoch-training and the misclassification error 2.6%). Looks like, for some reason, GPU is really not supported, even though this is GFX 1070 (included in the CUDA-capable device list)

I just tested the example and it supports three backends - gpu, mkl and cpu. I am using the latest version v2.3.0 (we just released the newest version last Friday).
You may try to download the new version and build again, and pay attention if there is any error during the build.

You are right. Re-installed and now works smoothly with all backends.


[993] deserialize session info

Context
Changes introduced by frontend
Changes proposed in this pull request
Accommodating the frontend changes
Guidance to review
Introduction of  deserializable_resource :session
Notable context
"no params"
"invalid resource type"

@defong I think this is ready to be brought out of draft now.

 Create new user sessions in API backend


how can Bot read an Azure sql database for querying a question

hi
I have a bot , that has to answer questions from a big database , the on premise database is in MySql .

I have to connect or load data from Mysql to Azure Database / Blob
Now I need my bot should answer questions from that Azure Database .

Can you please help me in that.

Hi Gourav! Closing this as the bot framework support team prefers "How-To" questions be asked on stackoverflow. For your questions, you'll find Database Migration helpful as well as How to get my Bot to send back database info.


Google sign in (backend functionality)

🎄🎄🎄 Merry Christmas! 🎄🎄🎄
Note: This changes authentication! All current entries in the Users table in mongodb will be invalidated after this is merged. The Users collection can be safely deleted (replaced by UserCreds and UserData, as explained below).
Overview
Replaces username/password authentication with Google Sign-In via OAuth2.
User Flow with this change

(Frontend) User clicks Sign in with Google button. Button is setup to redirect browser to /auth/google via href.
(Backend) auth/google will automatically redirect browser to Google's authorization web endpoint (passing along the required info via query parameters).
(Google) Google's authorization web endpoint prompts user to sign in and authorize application.
(Google) When user accepts or denies, Google redirects browser to /auth/google/callback on the backend (passing along the authorization result via query params).
(Backend) When browser hits auth/google/callback, the backend will redirect the browser to one of 3 places based on the result of the query and the state of the user in our application:

User Denies Authorization: Browser is redirected to /loginRedirect?userId=error. Frontend is expected to redirect browser back to the /login page and flash an error message.
User Allows Authorization, is new to the system: Browser is redirected to /loginRedirect?userId=null. Frontend is expected to force the user to fill out the user profile, preventing the user from accessing any other part of the application. Once the user profile is filled out, frontend must POST to /api/users with the profile. This will associate the logged-in user with the user profile, allowing them to use the rest of the app.
User Allows Authorization, already has user details in the system: Browser is redirected to /loginRedirect?userId=<USER_ID_HERE>. Frontend is expected to make another API call to GET /api/users/<USER_ID_HERE, getting the user object. This will allow the frontend to use the rest of the app like normal.

(Frontend) User uses the app as normal
(Frontend) When user wants to logout, clicks logout button. This makes an API call to GET /auth/logout
(Backend) User's cookie is cleared and browser is redirected to /
(Frontend) User is now on home page and no longer logged in.

Implementation Details

Removed username/password authentication, added Google OAuth2
Separated User model into UserCreds and UserData models. A UserCreds document stores authentication-specific data and is linked to a single UserData document. This means only passportjs modifies UserCreds and the rest of the backend functions off of UserData, increase security.
Added routes /auth/google, /auth/google/callback, and /auth/logout
Refactored routes and authentication into separate files
Fixed error handling and protected routes (explicit express middleware)
General readability improvements via promises and comments

Notes

Secrets are in slack!
This implementation uses OAuth2 instead of OpenID. This decision was made because passportjs supports Google OAuth2 authentication + authorization out of the box via passport-google-oauth. Support for OpenID is not as popular via passportjs. While I don't fully support using OAuth2 for authentication, it works well for this situation.
Due to the way OpenID or OAuth2 rely on browser redirects, propagating information from the backend to the frontend is difficult during the login process. This explains why the frontend has to make multiple API calls during authentication (via the /loginRedirect route with query parameters).

Can you update backend/.env.example with the new env variables that are necessary with this PR.

Check out the code quality review here from Codacy and try to fix the issues that are highlighted

All good on my end now! Will wait for your review

For Documentation Purposes
Note that this feature requires extra configuration with Google via the Google API Console. This configuration was done using my personal account (tejunareddy@gmail.com). This can be changed to a bitsofgood Google account if needed, just contact me and I can help with the transition.
Google API Console implicitly adds the following restrictions. If these seem too restrictive, I can modify the settings in the console.

Locally, app must be run on port 3000 or 3001
Publicly, the app must be run on drawchange.herokuapp.com with HTTPS
Authentication URLs in the backend cannot be modified
Limit of 100 users for our application


Unable to create the fibula line using the "mandible-Surgical-Guide-feature" branch

This is the error I get:

BoneReconstructionPlanner.py", line 774, in addFibulaLine
fibulaCentroid = np.array([float(fibulaCentroidX),float(fibulaCentroidY),float(fibulaCentroidZ)])
ValueError: could not convert string to float:

Am I missing some module?

I figured it out. I had to click to create the models from segmentations before I could add the fibula line.


diffrent colour for each container ingraphs

please allot random colour to containers in graphs

thank you

Hi! Thanks for the issue! Yep, you're right!


Add a Feature to Remove Duplicates to 'Text Analyzer and Utilities'

What improvement do you think would an existing feature or tool in DevToys?
DevToys can remove any duplicates
Solution/Idea
Add a "Remove duplicates" feature similar to "Convert line break", "Convert case" and "Sort lines".
Comments
No response.
I am using a translation tool, so I apologize if the content is incorrect.

Hi,
I wonder if the Duplicate Detector extension for DevToys, made by @Poilaupat, would help.
https://www.nuget.org/packages/DuplicateDetectorExtension

Thank you, veler!
This is exactly the feature I was looking for.
I hope this functionality will not only remain an extension but also be officially adopted.
Since the feature I wanted now exists, I will close this issue. Thank you!


The system cannot find the file specified

reported here
https://old.reddit.com/r/SteamDeck/comments/vpr5a8/why_must_so_many_games_keep_syncing_their_graphic/ilby9y1/
docs https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/controlled-folders?view=o365-worldwide#windows-system-folders-are-protected-by-default

It is not because of protected folders, but comes from the string variable not parsed as path.
https://stackoverflow.com/a/28115851/8575792


feat: Added inaugural blog post!

This blog post introduces the new site and prompts folks to get involved in the project.

Needs an author added.


replace default export with named export CleanWebpackPlugin

Please hold off on merging this as it is a breaking change.

https://github.com/johnagan/clean-webpack-plugin/issues/114#issuecomment-473204185
Oh, this lib is written in TS, I thought it just had a d.ts file. Then I would not change anything and just document the fact that consumers needs to add .default if their IDE/typechecker is yelling at them. The interop with CJS will always be a bit painful/ugly I think.
Jest will move to ES module exports in the next major and ditch export =.
One thing you can do is have a named export in addition to the default one, so people can do const CleanPlugin = require('clean-webpack-plugin').plugin; or something. Not much of a difference, but looks better than default, at least to my eyes

This PR removes the default export and replaces it with a named export CleanWebpackPlugin. It will work better with editors, improved es module/common js interoperability, and removes the (barely maintained) plugin babel-plugin-add-module-exports.
To upgrade users will need to update how they require/import the plugin.
// es modules
import { CleanWebpackPlugin } from 'clean-webpack-plugin';

// common js
const { CleanWebpackPlugin } = require('clean-webpack-plugin');

This will also fix https://github.com/johnagan/clean-webpack-plugin/issues/114.
I personally think this is a good/future proof change. Thoughts?

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   98.71%   98.71%
=======================================
  Files           1        1
  Lines          78       78
  Branches       27       27
=======================================
  Hits           77       77
  Misses          1        1

Impacted Files
Coverage Δ

src/clean-webpack-plugin.ts
98.71% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336dbcb...0c5cf79. Read the comment docs.


Fixed #26521 - CreateModel allows duplicate field names

I did this as part of the sprint tonight at Django NYC cc/ @charettes
https://code.djangoproject.com/ticket/26521

Looks pretty good to me, so long as it passes all of the required conventions and such.

Buildbot, add to whitelist.

If we're already doing this, can we check for manager names and uniqueness of bases, too. please.

@MarkusH no problem :)
While adding checks for uniqueness of bases I discovered that some of the tests optimizer tests were not passing in iterables. Since there are numerous places in the CreateModel code that iterate over self.bases I assumed this was an oversight and added the missing commas.
Still, I wanted to mention it - I could be wrong!

@charettes I think/hope I've addressed all your comments

Thanks for everything @jiaaro.
Do you think you could squash all your commits into a single one and give it a message reflecting all the changes it represents?

@charettes good?

Just merged it, thanks!


Not possible to listen upon hidden changes on hideable column in datagrid

Describe the bug
Using *clrDgHideableColumn directive in a datagrid column, I can't detect changes with (clrDgHiddenChange).
How to reproduce
https://stackblitz.com/edit/clarity-light-theme-v2-ztzjys
Additional notes
How can I properly detect changes upon show/hide columns? I know there is nothing in the Docs, but in the source code I could find the emitter: https://github.com/vmware/clarity/blob/master/src/clr-angular/data/datagrid/datagrid-hideable-column.ts#L78
Is there no official way to listen upon hidden changes?

I am using latest version (3.1.2) of clarity. and facing the same issue
(clrDgHiddenChange)="columnHiddenChange()" is not getting trigger if we change the column display.
Can anyone please guide me exactly how to use it ?
Note: we need to use hide/show column property in this way *clrDgHideableColumn and not in [clrDgHideableColumn]. Otherwise hide/show is not working.
My HTML code:

<ng-container
*clrDgHideableColumn="{hidden: false}"
(clrDgHiddenChange)="clrDgHiddenChange($event)">
Name

Actually, the (clrDgHiddenChange) is being triggered if used correctly:
<clr-dg-column>
    <ng-template
            [clrDgHideableColumn]="{hidden: false}"
            (clrDgHiddenChange)="columnHiddenChange()">
          Column title
    </ng-template>
</clr-dg-column>

Therefore I wouldn't say it's a duplicate of #2117.

I cannot get your code snippet working. Can you reproduce this in a code sandbox - maybe stackblitz?


[T3A2] [W15-A4] Verbena Ong

Modified CommandResult.java

Encapsulates feedbackToUser String from public to private
Creates a getFeedbackToUser() method to access the private string (feedbackToUser)

Modified TextUi.java

Changed the call of feedbackToUser to getFeedbackToUser()

Ready for review

:+1:


docs: fix scrollbar ascii illustrations and calendar doc paths

This PR fixes scrollbar's documentation, which tried to showcase its elements. This requires for the text to be rendered exactly how it was written, which isn't the case for the cargo and other tools. Thus, it requires to be wrapped inside text blocks, which preserves text as is.
Secondly, there were problems with doc paths in calendar's documentation.
Finally, recently merged changes in block.rs were not formatted properly

Thanks for catching that! Is it possible to have a doc preview on each PR?

I'm not aware of any way to do that. Personally, I just use cargo-watch when creating PR and/or editing documentation. But when reviewing, you'd have to download the PR and run it locally.

Sorry, I had to sign the commits for this to be merged. It would be nice to include that information in the CONTRIBUTING.md


Always dismiss first responder on sloppy swipe

If it turns out we don’t want this in some cases, we can add a prop to have this behavior conditionally

@pozdena merge it!


cf api should provide the command to login with --sso if available

Command
cf api

What occurred
We are invited to login :
Not logged in. Use 'cf login' to log in.

What you expected to occur
Not logged in. Use 'cf login' to log in with an internal user.
You can also use 'cf login --sso' to log in with your Federation system.

That would be the same behavior than the web-ui. The web-ui provides a link to login with SSO, when it is available.
CLI Version
cf version 6.37.0+a40009753.2018-05-25
CC API Endpoint Version
api version:    2.98.0

@jedjebari thanks for creating this. As mentioned we are currently refactoring the login command and we have a set of other priorities which means we will not be able to work on this in the near term.
However, I'd like to scope the proposed message for when we are able to review this request. Since "Federation" is not intuitive for all our users, would the following update be sufficient for your users?
Not logged in. Use 'cf login' or 'cf login --sso'  to log in.

The text is ok for me. Thanks

Thanks @jedjebari we hope to be able to include this update in a future release. The work is scheduled, thanks again for your feedback.

Hi @jedjebari thanks for creating this request. We've implemented this enhancement and expect to include it in our next release. I'm closing this issue as done but please do not hesitate to reopen if you want to provide further feedback.


Support --bip and --mtu on Ubuntu

This wasn't included in https://github.com/garethr/garethr-docker/commit/9e0ffcc12982dfef23724c196e70965e25a1962d

@benlangfeld thanks for catching. Appreciated.


Update role-based-access-control.md

Describe your changes
Updated the definition of Role-Based Access Control (RBAC) to be more precise and easier to understand.
Related issue number or link (ex: resolves #issue-number)
#2436
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@juliafmorgado Thank you for your work, but please keep semantic line breaks. It will make review & localization processes easier.


Document Activemq libs to copied when using as a JMS broker

Created https://github.com/ballerinalang/connector-jms/issues/14 in jms-connector repo


loosen tensorflow requirement

Fixes #56
Fixes #58
Fixes #61
Fixes #65

@yoeo
@larshp
please merge and release on pypi

<- wrong user..

@yoeo - any update on when this will be available on pypi?
Thanks!

https://pypi.org/project/guesslang-experimental

If the project remains abandoned for over 12 months, you may be able to report it to the PYPA and request a takeover. As long as you can prove that you have tried to contact the original authors without response.

Hi @jossef, for me this workaround is not working. It seems that there are a problem with tensorflow dependency:
Traceback (most recent call last):
  File "/home/julian/workspace/.../src/main.py", line 7, in <module>
    from core.technology_detection.detect_technologies import detect_technologies
  File "/home/julian/workspace/.../src/core/technology_detection/detect_technologies.py", line 2, in <module>
    from guesslang import Guess
  File "/home/julian/workspace/.../.venv/lib/python3.10/site-packages/guesslang/__init__.py", line 16, in <module>
    from guesslang.guess import Guess, GuesslangError  # noqa: F401
  File "/home/julian/workspace/.../.venv/lib/python3.10/site-packages/guesslang/guess.py", line 10, in <module>
    from guesslang import model
  File "/home/julian/workspace/.../.venv/lib/python3.10/site-packages/guesslang/model.py", line 13, in <module>
    from tensorflow.python.training.tracking.tracking import AutoTrackable
ModuleNotFoundError: No module named 'tensorflow.python.training.tracking'

Could you help me?
Regards!

@syn-4ck It's been a while, but I just capped the version before a breaking change I encountered.
You could try installing this PR with pip, with a requirement:
guesslang @ git+https://github.com/andydecleyre/guesslang@tensorflow-looser

@jossef, I have been using guess-lang-experimental (alternative to guess-lang). Is there support for tensorflow versions after 2.15.0?


Allow 0-Duration Tweens

Godot version:
3.1 (Steam Live Version)
OS/device including version:
Windows, should be OS agnostic
Issue description:
When executing a tween with a 0 duration, an error is thrown and the tween is not executed. This means that you cannot ever pass a 0 into the duration of a tween to get an 'instant' tween. This is useful when programatically setting up Tweens and the case of 0 is sent.
The current workaround is to detect a duration of 0, and instead either set the property manually (which is extra, unneccesary code) or to instead send a very short duration, for example 0.001 (obtuse workaround...). Not implementing a workaround means that you don't get correct callback handling, values are not applied, and there is not even an obvious message stating why things are not happening.
Instead, sending a 0 duration to a tween should behave as an instantaneous tween.
Steps to reproduce:
Create a tween node and add it to the tree. Call interpolate_property on the node, and give it a duration of 0. Start the tween, and nothing will happen. Call interpolate_property with 0.001 and it will happen 'nearly instantly'.
Minimal reproduction project:
InstantTween.zip
This project has three buttons which rotate a sprite. The 0 duration button fails to rotate the sprite. The 0.01 button rotates the sprite as expected. The 1.0 button rotates the sprite across 1 second. All three buttons should work but the first does not.
Thanks,
-Devin

Hi,
As far as I can tell, this is simply a one-line change for a value check.
Please review the change here:
https://github.com/godotengine/godot/pull/29568
As stated in the request, I confirmed this worked on my build. However, I'm unable to figure out how to run/add unit tests.
Thanks,
-Devin

New PR Here:
https://github.com/godotengine/godot/pull/29621


add using macro

resolves #185

Coverage decreased (-0.2%) to 96.203% when pulling b96bf2eb3b94fcc4f2793382a7823e91433d1482 on using-macro into 50f6e172e871f84c1b3db32e8693b04a3ec0ba85 on main.


chore: update some SHAs

Some Mathlib 4 lemmas were backported to Mathlib 3 in leanprover-community/mathlib#18502, sync SHAs

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Thanks :tada:
bors merge


x86 instruction encoding

I've been working on a library for encoding x86 instructions which should be useful for this project.
Only a few opcodes are implemented at the moment, but the framework is mostly complete.  Now it's just a matter of crawling through the Intel datasheets and adding the instructions to a lookup table.
Although it's far from complete I'm mentioning it now to save people from duplicating work.

I've got basically all the non-SIMD opcodes implemented now.  Here's an example of building and executing code from RAM.
Something to keep in mind when writing the x86 assembler is variable sized relative jumps. In 64 bit you can use JMP rel8 (2 bytes) and JMP re32 (5 bytes) and optimally you want to use the smaller jump when possible. This makes things slightly tricky because if you have a forward jump to a label you haven't calculated yet, then you won't know what size jump to use.  However, to calculate the address of the label you need to know the size of the relative jumps leading up to it. So you have to guess which size to use and then fix-up any that turn out to be wrong.

Wow, nice work!
Thanks for the tip about JMP too.
I'll start incorporating this into zasm. I bet we're not so far away from self-hosted "hello world" without LLVM :)


Issue 1129 implement drop tenant

See fhir-persistence-schema/docs/DropTenant.md for background and usage.

Yes, it's a little frustrating that we have to disable RI during the drop. In theory this shouldn't be necessary, because all the data for a tenant is local to a single partition, and all the FK constraints are prefixed with the MT_ID, which is also part of the partition key. Db2 should be able to work out that it can safely detach the partitions (in child-first order, of course).
You are correct that it's a customer choice. Spinning up a quick sandboxes is different than an enterprise looking for high availability.


ntl: 11.4.3 -> 11.4.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ntl/versions.
meta.description for ntl is: "A Library for doing Number Theory"
meta.homepage for ntl is: "http://www.shoup.net/ntl/"
meta.changelog for ntl is: "https://www.shoup.net/ntl/doc/tour-changes.html"
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 11.4.4 with grep in /nix/store/3nq4qhm0bnbgcq655dxjiynjcyf9pzi5-ntl-11.4.4

directory tree listing: https://gist.github.com/5ff0fa0c6225f02c63b1080a382ec21e

du listing: https://gist.github.com/39c8421950b74b662a5ede2ac036b6d5

Rebuild report (if merged into master) (click to expand)

47 total rebuild path(s)

14 package rebuild(s)

14 x86_64-linux rebuild(s)
11 i686-linux rebuild(s)
10 x86_64-darwin rebuild(s)
12 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
arb
eclib
flint
giac
giac-with-xcas
ntl
polymake
pynac
python38Packages.symengine
python39Packages.symengine
sage
sageWithDoc
singular
symengine

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3nq4qhm0bnbgcq655dxjiynjcyf9pzi5-ntl-11.4.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ntl https://github.com/r-ryantm/nixpkgs/archive/9eaf54c66902b8b62eaaba20afe1ad2e71e105b3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3nq4qhm0bnbgcq655dxjiynjcyf9pzi5-ntl-11.4.4
ls -la /nix/store/3nq4qhm0bnbgcq655dxjiynjcyf9pzi5-ntl-11.4.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @timokau @omasanori @7c6f434c for testing.

Result of nixpkgs-review pr 116024 at 9eaf54c6 run on x86_64-linux 1

7 packages skipped due to time constraints:

arb
eclib
giac
giac-with-xcas
polymake
sage
sageWithDoc

7 packages built successfully:

flint
ntl
pynac
python38Packages.symengine
python39Packages.symengine
singular
symengine

@ofborg build sage

Result of nixpkgs-review pr 116024 run on x86_64-linux 1

14 packages built:

arb
eclib
flint
giac
giac-with-xcas
ntl
polymake
pynac
python38Packages.symengine
python39Packages.symengine
sage
sageWithDoc
singular
symengine


Compressed assets no longer in report

We use this plugin to compare asset size in a PR against the main branch, which has been great for some time.
Currently we are in the process of upgrading from Webpack 4 to 5 for our application. We use compression-webpack-plugin to generate gzip and brotli versions of each asset, and when comparing asset size, we reference the brotli assets as that's what most of our users receive. The issue is that after upgrading Webpack and all relevant packages, we no longer see the compressed assets in the bundle-stats output, only the uncompressed .css and .js versions of the files. However the compressed assets are still being created during Webpack build.
Any idea what may have changed?
This is just a guess, but I noticed this change. Could be related?
https://webpack.js.org/blog/2020-10-10-webpack-5-release/#stats

Stats differentiate between files and auxiliaryFiles now.

webpack: 5.48.0
bundle-stats-webpack-plugin: 3.2.0
compression-webpack-plugin: 9.0.0

Hi @TREFZ, thanks for the info!
I will try the replicate the setup in the following days, let me know if you have one or if you can provide one.
We had similar issues in the past with other plugins not using the webpack 5 stage property, but in this case the stage properties are looking ok. The changed assets should be available to bundle-stats-webpack-plugin:

compression-webpack-plugin: PROCESS_ASSETS_STAGE_OPTIMIZE_TRANSFER
bundle-stats-webpack-plugin: PROCESS_ASSETS_STAGE_REPORT

Also, a helpful test will be to output the webpack stats directly from webpack (webpack --json > webpack-stats.json - recommended stats config) and see if the compressed assets are available on assets[]. You can even run bundle-stats cli(npx bundle-stats webpack-stats.json) to check if you get the same results as the plugin.

Thanks @vio
Good question about the assets json. We actually use a plugin for that, assets-webpack-plugin and I can confirm the compressed files aren't in the output, so this likely has nothing to do with bundle-stats. And I didn't realize webpack had its own stats output 🤦  Will try that out!

Unfortunately it looks like the webpack stats json doesn't include references to the compressed files. I'll keep investigating, and thanks again!

Thanks for checking @TREFZ! Feel free to reopen if you think there is a way for bundle-stats to include the compressed sizes.


Error: Cannot assign to read only property 'headers' of object '[object Request]'

What version of OpenTelemetry are you using?
0.9.0
What version of Node are you using?
12.7.0
What did you do?
fetch(new Request('/api'))

What did you expect to see?
Fetch request to be sent and auto-instrumented by opentelemetry-plugin-fetch.
What did you see instead?
An error:
Error: Cannot assign to read only property 'headers' of object '[object Request]

Additional context
opentelemetry-plugn-fetch is trying to change the headers attribute on a given fetch constructor parameter (see https://github.com/open-telemetry/opentelemetry-js/blob/0d939d2a0e9025ab7569d2521633db7eca124143/packages/opentelemetry-plugin-fetch/src/fetch.ts#L112 ).
It fails, because the fetch constructor accepts an object or an instance of Request and the headers of a Request has no setter.

PTAL at #1274 as a fix


Move MediaPlayer call out of InsultWidget

Expensive operations block further event processing and can lead to ANRs
Solution must make sure app process doesn't get killed and sound is aborted

https://developer.android.com/reference/android/content/BroadcastReceiver#onReceive(android.content.Context, android.content.Intent)


Multi-language Markdown files

The goal is to make sure that the Markdown files are localized, too. Based on the current locale, different Markdown files should be displayed.

Done


chore: add github PR template

Added PR template for github. Copied from the Angular repo with little modification. Any suggestions/discussion is appreciated.
Signed-off-by: Cory Rylan<EMAIL_ADDRESS>

I could refer this for my Development and Contribution guides ;)


fix webhook validation

allow cnb bindings and notary to be added to v1alpha2 images if they are created by the kpack controller

Codecov Report

Merging #839 (f65f5d3) into main (1d12aa0) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
- Coverage   68.74%   68.69%   -0.05%
==========================================
  Files         114      114
  Lines        5062     5054       -8
==========================================
- Hits         3480     3472       -8
  Misses       1210     1210
  Partials      372      372

Impacted Files
Coverage Δ

pkg/apis/build/v1alpha2/build_validation.go
88.57% <100.00%> (-1.18%)
:arrow_down:

pkg/apis/build/v1alpha2/image_validation.go
98.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d12aa0...f65f5d3. Read the comment docs.


Unable to rename Environment (Windows 10)

I encountered an issue attempting to rename any environment in the Environment Manager dialog. In windows 10, a double tap of a touchpad does not enable editing of the name. If you double click it does work properly but double tap and double click are two separate events for windows 10.

Hi @chrisjasp I'm going to go ahead and close this one, but feel free to reopen this issue and share more details on your mouse pad (e.g. model, brand, specs) if you are still facing this issue.


itchat.send_msg returns -1.

The application seems broken and returns -1 without any error message upon an attempt to send a message.
itchat.send_msg('Hellouser', toUserName='user')
<ItchatReturnValue: {'BaseResponse': {'Ret': -1, 'ErrMsg': '', 'RawMsg': ''}, 'MsgID': '', 'LocalID': ''}>

Real user. I will retry using the library to make sure it was not my error.

Had you ever been login with this account? If your account was registerd after 2017, then it can't use this web mode.


Add function for getting the name of a variant as static string

This might be useful for not displaying the variant immediately, but for using cheap what fields in errors.

Fixed in 91afa4f02d90dec710f253a1c9a158f622007a8d


Roll Flutter Engine from a9ebed54c451 to bf753599823b (1 revision)

https://github.com/flutter/engine/compare/a9ebed54c451...bf753599823b
2023-09-01<EMAIL_ADDRESS>[Impeller] use correct blend mode for performance overlay (flutter/engine#45365)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Cannot resolve configuration property

Cannot resolve configuration property 'zuul.host.connect-timeout-millis' and so on, with spring cloud Finchley.M7, i saw the package of the class 'ZuulProperties' is org.springframework.cloud.netflix.zuul.filters, other such as eureka, the package org.springframework.cloud.netflix.eureka. I use development tool :intellij Idea 2018.1 release candidate.

Duplicates #2782


agent-client-go: test cases and mock agent

This is the second part of the agent-client (there are three in total).
It contains mainly two things :

a mock for the agent and its http server (I had to add an extra dependency to gorilla/mux for the router, because the one we are using in storehttp does not support the agent's routes)
the testing package layout for the agent-client, It lives in its own sub-package because I felt it could be somehow shared with the agent tests but I did not figure out how exactly (I'm open to suggestions here)

Next PR will be actual implementation !

This change is

Reviewed 18 of 18 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

agent/process.go, line 30 at r1 (raw file):

func (p Processes) FindProcess(name string) *Process {
	for _, process := range p {
		if process.Name == name {

nit: maybe we'll want to be case-insensitive here? I don't know if we're case-sensitive in the SDK

agent/agenttestcases/agenttestcases.go, line 36 at r1 (raw file):

	f.Client, _ = f.NewClient(agentURL)

	t.Run("TestCreateMap", f.TestCreateMap)

I would recommend putting all the CreateMap tests in a single test function (fixture) that will do multiple t.Run()
Have a look at what I did in the SDK store tests recently, it helps speed up the tests and organize them.
Same for the other test groups below.

agent/client/client_test.go, line 23 at r1 (raw file):

	seed := int64(time.Now().Nanosecond())
	fmt.Printf("using seed %d\n", seed)
	rand.Seed(seed)

Why do we need that? What random things are we doing that make it important to generate and output the seed?

agent/client/utils_test.go, line 38 at r1 (raw file):

	bytes, err := json.Marshal(errorData)
	if err != nil {
		w.WriteHeader(500)

nit; we should use http status codes from the net package

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

agent/process.go, line 30 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
nit: maybe we'll want to be case-insensitive here? I don't know if we're case-sensitive in the SDK

That's a valid point, but we're currently using case-sensitive comparisons in the SDK.

agent/agenttestcases/agenttestcases.go, line 36 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
I would recommend putting all the CreateMap tests in a single test function (fixture) that will do multiple t.Run()
Have a look at what I did in the SDK store tests recently, it helps speed up the tests and organize them.
Same for the other test groups below.

Thanks I'll do that :)

agent/client/client_test.go, line 23 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
Why do we need that? What random things are we doing that make it important to generate and output the seed?

Actually you're right, we don't need tests to generate truely random hashes.

agent/client/utils_test.go, line 38 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
nit; we should use http status codes from the net package

good point !

Comments from Reviewable

Review status: 7 of 18 files reviewed at latest revision, 3 unresolved discussions.

agent/agenttestcases/agenttestcases.go, line 36 at r1 (raw file):
Previously, simonvadee wrote…
Thanks I'll do that :)

Done.

agent/client/client_test.go, line 23 at r1 (raw file):
Previously, simonvadee wrote…
Actually you're right, we don't need tests to generate truely random hashes.

Done.

agent/client/utils_test.go, line 38 at r1 (raw file):
Previously, simonvadee wrote…
good point !

Done.

Comments from Reviewable

agent/client/client_test.go, line 20 at r2 (raw file):

func TestMain(m *testing.M) {
	seed := int64(time.Now().Nanosecond())

Where is this used ?

Comments from Reviewable

Reviewed 4 of 18 files at r1, 9 of 11 files at r2.
Review status: 16 of 18 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

Review status: 16 of 18 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

agent/client/client_test.go, line 20 at r2 (raw file):
Previously, bejito (Mourad BEJI) wrote…
Where is this used ?

right, it's no longer used

Comments from Reviewable

Reviewed 7 of 18 files at r1, 9 of 11 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

agent/agenttestcases/agenttestcases.go, line 15 at r3 (raw file):

// Factory wraps functions to mock an HTTP server for an agent and run
// the  for the agent and its client

typo?

Comments from Reviewable

Review status: 17 of 18 files reviewed at latest revision, 1 unresolved discussion.

agent/agenttestcases/agenttestcases.go, line 15 at r3 (raw file):
Previously, such (Adrien Montfort) wrote…
typo?

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Greaseweazle V4

Trying to write commodore 1541 format with real disks and d64 file, have tried both HD and non HD disks and with 35 track disk setting and 40 tracks. Have also tried multiple different disk brands.
Can not use format disk option, every time it gives "error: unimplemented operation"
It almost seemed to have worked once (the first time I tried), every time since has failed "Error: fatal error on write".
Have tried different cables just in case but still the same error.

  D64: reading image with 39 tracks, 1 heads

Measuring rotational speed... 166.3ms (360.8rpm)
Measuring rotational speed... 166.3ms (360.8rpm)
0.0: writing 166 ms in 55005 bytes
1.0: erased
0.0: 199 ms in 65472 bytes
1.0: 199 ms in 72128 bytes
48 raw records, 20 raw sectors; 2.70us clock (370kHz)
sectors: 0.0.0? 0.0.1? 0.0.2! 0.0.3? 0.0.4! 0.0.5! 0.0.6! 0.0.7! 0.0.8! 0.0.9! 0.0.10! 0.0.11 0.0.12 0.0.13! 0.0.14! 0.0.15! 0.0.16? 0.0.17? 0.0.18! 0.0.19! 0.0.20!
4096 bytes decoded
bad read
retrying; 5 retries remaining
0.0: writing 166 ms in 55005 bytes
1.0: erased
0.0: 199 ms in 65512 bytes
1.0: 199 ms in 72216 bytes
52 raw records, 23 raw sectors; 2.70us clock (370kHz)
sectors: 0.0.0? 0.0.1! 0.0.2! 0.0.3? 0.0.4! 0.0.5! 0.0.6! 0.0.7! 0.0.8! 0.0.9 0.0.10! 0.0.11! 0.0.12! 0.0.13! 0.0.14! 0.0.15! 0.0.16! 0.0.17? 0.0.18! 0.0.19! 0.0.20!
4608 bytes decoded
bad read
retrying; 4 retries remaining
0.0: writing 166 ms in 55005 bytes
1.0: erased
0.0: 199 ms in 65470 bytes
1.0: 199 ms in 71556 bytes
49 raw records, 18 raw sectors; 2.70us clock (370kHz)
sectors: 0.0.0! 0.0.1! 0.0.2! 0.0.3! 0.0.4! 0.0.5? 0.0.6! 0.0.7? 0.0.8! 0.0.9! 0.0.10! 0.0.11! 0.0.12! 0.0.13! 0.0.14? 0.0.15! 0.0.16? 0.0.17! 0.0.18! 0.0.19! 0.0.20!
4352 bytes decoded
bad read
retrying; 3 retries remaining
0.0: writing 166 ms in 55005 bytes
1.0: erased
0.0: 199 ms in 65434 bytes
1.0: 199 ms in 71661 bytes
49 raw records, 21 raw sectors; 2.57us clock (388kHz)
sectors: 0.0.0? 0.0.1? 0.0.2? 0.0.3? 0.0.4? 0.0.5? 0.0.6? 0.0.7 0.0.8? 0.0.9? 0.0.10? 0.0.11 0.0.12? 0.0.13? 0.0.14? 0.0.15? 0.0.16? 0.0.17? 0.0.18? 0.0.19? 0.0.20?
512 bytes decoded
bad read
retrying; 2 retries remaining
0.0: writing 166 ms in 55005 bytes
1.0: erased
0.0: 199 ms in 65393 bytes
1.0: 199 ms in 71495 bytes
50 raw records, 17 raw sectors; 2.70us clock (370kHz)
sectors: 0.0.0! 0.0.1? 0.0.2? 0.0.3? 0.0.4! 0.0.5! 0.0.6! 0.0.7! 0.0.8? 0.0.9! 0.0.10! 0.0.11! 0.0.12! 0.0.13? 0.0.14? 0.0.15! 0.0.16! 0.0.17? 0.0.18! 0.0.19! 0.0.20!
3584 bytes decoded
bad read
retrying; 1 retries remaining
0.0: writing 166 ms in 55005 bytes
1.0: erased
0.0: 199 ms in 65798 bytes
1.0: 199 ms in 71528 bytes
50 raw records, 18 raw sectors; 2.70us clock (370kHz)
sectors: 0.0.0? 0.0.1? 0.0.2? 0.0.3? 0.0.4! 0.0.5! 0.0.6! 0.0.7! 0.0.8? 0.0.9 0.0.10? 0.0.11? 0.0.12? 0.0.13? 0.0.14? 0.0.15? 0.0.16? 0.0.17? 0.0.18? 0.0.19? 0.0.20?
1280 bytes decoded
bad read

1541 filesystem support is currently read only. But you should be able to write D64 files; it works for me, although as I don't have a C64 I can't test them. What command are you using?  (The wrong setting will cause writes to fail.)
Also, I'll note that that 39 track .d64 file looks really weird --- they should be 35 or 40, surely?

I am going to blame the disks after more attempts. I had 1 box of labeled/branded Sony MD2DA and it worked without any issues using the GUI on the first try. I then used the next 9 disks and filled them up with games, again all with no errors.
I am going to assume the bulk box of 500 floppies I bought are in fact not DD but HD which won't work on the C64 :( Sad thing is I only have 10 of those Sony disks and now 500 paperweights.

Ouch, yeah. You can get away with using HD 3.5" floppies in DD drives but not with 5.25" floppies.
If you're in the US and your disks are NIB you might want to talk to the people at floppydisk.com --- you may be able to do an exchange.

Awesome, thanks for the idea. I will shoot him off an email and cross my fingers :)


Add listenable TransportRequestHandler in TransportNodesAction

Description
Add listenable TransportRequestHandler in TransportNodesAction.
Use case:
In ml-commons, a scenario is to deploy model to the cluster, this action needs to read the model metadata from index first and then do time-consuming operation for locally running model and non time-consuming operations for remote running model.
The thing is the current TransportNodesAction limited the API that developers have to return a response when performing nodeOperation, so we have to workaround this by forwarding the deploy result to a listener to update the model status, the workflow looks like below:

This works fine for the time-consuming models(run locally) but not for remote models because deploying remote models is lightweight which only needs create several object in memory after metadata read. Once we enhanced this API to support listenableTransportRequestHandler, then we can pass the listener to the noOperation and return actual model status instead of deploying.
Also recently we found an issue of model deployment which is caused by the forwarding deploy result to listener part, simply put, if a node crash during the model deploy, then the listener will not able to receive all responses and not updating the model status, please refer: https://github.com/opensearch-project/ml-commons/issues/2970.
So enhancing this class offering a straightforward solution to this scenario and I believe it can benefit other similar cases which accept a listener during the nodeOperation.
Related Issues
https://github.com/opensearch-project/OpenSearch/issues/15165
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied @gaobinlong @dblock Can you help review this PR?

@zane-neo Could you give some use cases about this change to help understanding the intention, thanks!

@gaobinlong Thanks, Binlong. I'll add more cases in the description and the issue.

@rajiv-kv @shwetathareja could you also help to take a look at this PR, thanks!


[Diagnostics.AspNetCore3]: Documentation is missing snippet code.

See https://googleapis.dev/dotnet/Google.Cloud.Diagnostics.AspNetCore3/4.0.0-beta01/index.html
This is possibly because we are using the same Snippet project for both Diagnostics.AspNetCore* packages.

I thought we'd separated out the snippets into a copy of the projects? The code that finds the snippets does expect it to be in a fixed location.

I'll look into this today.

Fixed in #5663 and #5665


UMP45 Reload Bug

When I try using the 30rnd mag, the UMP45 doesn't reload.

which 30 round mag

We have a format setup for a reason. Please use it.


Regarding Groundtruth

Hello!
When i try to use predict_disparity  and Groundtruth to calculate MSE , i have a problem about how to transform predict_disparity to predict_depth.Should i use (min_disp = 1 / max_depth, max_disp = 1 / min_depth, scaled_disp = min_disp + (max_disp - min_disp) * disp)
to transform predict_disparity?Could you offer Groundtruth's max_depth/min_depth and the max/min pixel of the Grountruth picture.
Looking forward to your reply.Thanks.

Check out the last section "Disparity to Depth" here: https://dsec.ifi.uzh.ch/data-format/


Remove krshapedlogic tag, this is the default now

Remove krshapedlogic tag, this is the default now
Also update-deps && update-codegen

Based on https://github.com/knative/pkg/pull/1430

/assign

/lgtm

/approve


Lamdera: 1.1.0 -> 1.2.0

Description of changes
Update lamdera to version 1.2.0.
Release notes: https://dashboard.lamdera.app/releases/v1-2-0
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Pinging @Zimmi48 as the person who merged the last update

@Zimmi48 does it make sense to backport this?

If I understand the backporting rules correctly, this shouldn't be necessary, as the former version should keep working, and upgrading might require steps (such as deleting caches, at least, this is what I had to do) that people on stable versions might not want to undertake.

I would be surprised if people don't want to upgrade though

Yes, me too. I just don't have a good story of why people would pull their development deps from a stable channel anyway, unless they do like lagging behind (like those using Debian stable for their development deps).
That being said, you asked for my opinion and I gave it, but I wouldn't be opposed to backporting if you have a different feeling.

I would vote for backporting, personally, as I can't see a reason to use the old version. It is also true that just grabbing lamdera from unstable is not particularly hard :shrug:

OK. If you do the backport, I can click the merge button.


Hidden TOC sections shown in Metadata editor

Looked like this was fixed but when I open empty article, then add a new author, they show up again and make an ugly look of the TOC.

Fixed via ba0a827.
Note: we are doing display none thing now, it's not very elegant, but since MetaSectionTOCEntry is Model Component that's the easiest way, otherwise we would need to make a toc renderer more robust and toc entries more dumpy.


Add LegacyERC20ETH contract addresses to Base contracts

What changed? Why?
Add LegacyERC20ETH contract address for Base Mainnet and Base Testnet (Sepolia) in the documentation.
Notes to reviewers
This address is in the Optimism docs, but was missing from Base documentation
How has it been tested?
Does this PR add a new token to the bridge?

[x] No, this PR does not add a new token to the bridge
[ ] I've confirmed this token doesn't use a bridge override
[ ] I've confirmed this token is an OptimismMintableERC20

Please include evidence of both confirmations above for your reviewers.

@0xArdy
Thanks for taking the time to open this PR! We've added this to our backlog, pending to be reviewed.

@0xArdy Thanks for adding these!


Update checkout action so it runs after May 18th

Checkout v2 runs on Node v12.  This leads to warnings now, but it will stop running after May 18th.

Thank you!


feat: witnesses 52/54

Current dependencies on/for this PR:

main

PR #78   👈

This stack of pull requests is managed by Graphite.


Huginn uses half of CPU after upgrading from Ubuntu 18 to Ubuntu 20

I'm not sure what happened with Huginn after upgrading my VPS to Ubuntu 20.04.3 LTS. It seems it affected some setups of Huginn because when accessing Huginn via my browser, I get a '502 bad gateway' error.
However, the worst part is that even if I stop the Huginn service the process keep running no matter what (user huginn, command ruby) and it is always taking up 50 % of my CPU as I'm in a shared server I'm afraid that not being able to solve it will make my server to be shut down by the provider.
I'm getting errors like this in my Unicorn.log
2021/11/29 10:01:06 [crit] 51722#51722: *53 connect() to unix:/home/huginn/huginn/tmp/sockets/unicorn.socket failed (13: Permission denied) while connecting to upstream, client: *hidden IP*, server: your_server_fqdn, request: "GET / HTTP/1.1", upstream: "http://unix:/home/huginn/huginn/tmp/sockets/unicorn.socket:/502.html", host: "*hidden host*"
Production.log shows this kind of error that look related to MySQL but I'm unable to fix it

I, [2021-11-28T19:34:44.743324 #451]  INFO -- : 2021-11-28T19:34:44-0800: [Worker(host:*hidden hostname* pid:451)] Error while reserving job: Mysql2::Error::ConnectionError: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2): SELECT  `delayed_jobs`.* FROM `delayed_jobs` WHERE ((run_at <= '2021-11-29 03:34:44.741305' AND (locked_at IS NULL OR locked_at < '2021-11-29 03:32:44.741356') OR locked_by = 'host:*hidden hostname* pid:451') AND failed_at IS NULL) ORDER BY priority ASC, run_at ASC LIMIT 5
I, [2021-11-28T19:34:49.405917 #451]  INFO -- : 2021-11-28T19:34:49-0800: [Worker(host:*hidden hostname* pid:451)] Starting job worker
I, [2021-11-28T19:34:49.407193 #451]  INFO -- : 2021-11-28T19:34:49-0800: [Worker(host:*hidden hostname* pid:451)] Error while reserving job: Can't connect to local MySQL server through socket

Any help to solve this or at least stop Ruby taking so much CPU resources would be great.
Thank you.

I was able to stop it after reinstalling Ruby and other packages. However, now I am getting this error that I can't resolve:
I, [2021-11-30T11:30:38.889100 #88485]  INFO -- : Refreshing Gem list
/usr/local/lib/ruby/gems/2.6.0/gems/bundler-1.17.3/lib/bundler/rubygems_integration.rb:200: warning: constant Gem::ConfigMap is deprecated
bundler: failed to load command: unicorn (/home/huginn/huginn/vendor/bundle/ruby/2.6.0/bin/unicorn)
NoMethodError: private method `allowed_tags' called for #<Rails::Html::SafeListSanitizer:0x00005579bf8a5ed8>
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/actionview-<IP_ADDRESS>/lib/action_view/helpers/sanitize_helper.rb:132:in `sanitized_allowed_tags'
  /home/huginn/huginn/config/initializers/sanitizer.rb:1:in `<main>'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/bootsnap-1.4.5/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:54:in `load'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:318:in `block in load'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `load_dependency'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:318:in `load'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:666:in `block in load_config_initializer'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:182:in `instrument'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:665:in `load_config_initializer'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:625:in `block (2 levels) in <class:Engine>'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:624:in `each'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:624:in `block in <class:Engine>'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `instance_exec'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `run'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:61:in `block in run_initializers'
  /usr/local/lib/ruby/2.6.0/tsort.rb:228:in `block in tsort_each'
  /usr/local/lib/ruby/2.6.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
  /usr/local/lib/ruby/2.6.0/tsort.rb:422:in `block (2 levels) in each_strongly_connected_component_from'
  /usr/local/lib/ruby/2.6.0/tsort.rb:431:in `each_strongly_connected_component_from'
  /usr/local/lib/ruby/2.6.0/tsort.rb:421:in `block in each_strongly_connected_component_from'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:50:in `each'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:50:in `tsort_each_child'
  /usr/local/lib/ruby/2.6.0/tsort.rb:415:in `call'
  /usr/local/lib/ruby/2.6.0/tsort.rb:415:in `each_strongly_connected_component_from'
  /usr/local/lib/ruby/2.6.0/tsort.rb:349:in `block in each_strongly_connected_component'
  /usr/local/lib/ruby/2.6.0/tsort.rb:347:in `each'
  /usr/local/lib/ruby/2.6.0/tsort.rb:347:in `call'
  /usr/local/lib/ruby/2.6.0/tsort.rb:347:in `each_strongly_connected_component'
  /usr/local/lib/ruby/2.6.0/tsort.rb:226:in `tsort_each'
  /usr/local/lib/ruby/2.6.0/tsort.rb:205:in `tsort_each'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:60:in `run_initializers'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:363:in `initialize!'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/railtie.rb:190:in `public_send'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/railties-<IP_ADDRESS>/lib/rails/railtie.rb:190:in `method_missing'
  /home/huginn/huginn/config/environment.rb:5:in `<top (required)>'
  config.ru:4:in `require_relative'
  config.ru:4:in `block in <main>'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/rack-2.2.2/lib/rack/builder.rb:125:in `instance_eval'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/rack-2.2.2/lib/rack/builder.rb:125:in `initialize'
  config.ru:1:in `new'
  config.ru:1:in `<main>'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/unicorn-5.1.0/lib/unicorn.rb:56:in `eval'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/unicorn-5.1.0/lib/unicorn.rb:56:in `block in builder'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:752:in `build_app!'
  /home/huginn/huginn/vendor/bundle/ruby/2.6.0/gems/unicorn-5.1.0/lib/unicorn/http_server


Update README file consistent with other TSTool repos.

All of the TSTool repository README files are being updated to have some consistent information to tie them together.

Updated the README file.  Close the issue.


[GSSoc'23] Movie Recommender System Project | Machine Learning Project

I will add a new machine learning project [ML based Movie Recommender system], It is a content based movie recommender system using python , ml , cosine similarity and deploy the model using streamlit .
Please assign me this new project!

please assign me this project @avinashkranjan sir

please assign me this @avinashkranjan @Yashbhadiyadra @1e9abhi1e10


feat: Allow proxying of OTLP/gRPC metrics requests

Which problem is this PR solving?
Enables proxying of OTLP metric requests over gRPC. This is useful when users want to control egress.
Note: OTLP metrics requests over HTTP are already proxied using a generic handler.
This is an updated version of the following PR:

#609

Short description of the changes

add simple OTLP metrics server implementation
register server during app start up and create proxy connection
dispose of connection during app shutdown

The change looks good to me. Do you know how we can test this locally to make sure the metrics are forwarded as expected?

Yeah, I will work on adding some tests 👍🏻

We're gonna park this until we get more feedback we need it.


explore page: use common numeraire

references https://github.com/penumbra-zone/dex-explorer/issues/188

It seems that the /api/stats and /api/summaries endpoints from pindexer may be returning incorrect information, impacting metrics like "total trading volume (24h)" and the largest "trading pair (24h volume)" for the USDC/USDY pair. Previous discussions suggest that this might not just be a denom-related issue.


SAKIII-4863 fix searching in mycontacts

https://jira.sakaiproject.org/browse/SAKIII-4863

Squashed and merged


Docs: Sync pipeline-api.md

Changes
This commit syncs the pipeline-api.md for the current repo status to avoid the repetitive "manual" fixes
after running ./hack/update-codegen.sh.
fixes: https://github.com/tektoncd/pipeline/pull/5937#discussion_r1060914200
/kind misc

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[n/a] Has Docs included if any changes are user facing
[n/a] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

cc @lbernick @Yongxuanzhang PTAL

/test check-pr-has-kind-label

/lgtm thanks! @JeromeJu

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-integration-tests


Arduino Library Update to 69e75d95cb83d1006e07f9d42107647da721d0cd

Automated update of the Arduino library package
Please review changes.

Repeated PR for v1.0.0 release. Closing as it is already merged.


⚠ ZV800.com has degraded performance

In 9d97734, ZV800.com (https://www.zv800.com//) experienced degraded performance:

HTTP code: 200
Response time: 1216 ms

Resolved: ZV800.com performance has improved in 9c869d9 after 13 minutes.


Lv Coordinator according to updated concept

Resolves #90

I additionally adapted the documentation according to current implementation.

Take care of #153 before merging.


No module named 'pcdet.version'

Hi, when I do bash scripts/dist_train.sh 1 --cfg_file cfgs/nuscenes_models/cbgs_voxel0075_voxelnext.yaml, some question appear, If you can help me, very appreciate!

NGPUS=1

PY_ARGS='--cfg_file cfgs/nuscenes_models/cbgs_voxel0075_voxelnext.yaml'

true

PORT=13654
++ nc -z <IP_ADDRESS> 13654
++ echo 127

status=127

'[' 127 '!=' 0 ']'

break

echo 13654
13654

python -m torch.distributed.launch --nproc_per_node=1 train.py --launcher pytorch --cfg_file cfgs/nuscenes_models/cbgs_voxel0075_voxelnext.yaml
/root/miniconda3/lib/python3.8/site-packages/torch/distributed/launch.py:178: FutureWarning: The module torch.distributed.launch is deprecated
and will be removed in future. Use torchrun.
Note that --use_env is set by default in torchrun.
If your script expects --local_rank argument to be set, please
change it to read from os.environ['LOCAL_RANK'] instead. See
https://pytorch.org/docs/stable/distributed.html#launch-utility for
further instructions
warnings.warn(
Traceback (most recent call last):
File "train.py", line 7, in
from test import repeat_eval_ckpt
File "/root/VoxelNeXt/tools/test.py", line 14, in
from eval_utils import eval_utils
File "/root/VoxelNeXt/tools/eval_utils/eval_utils.py", line 8, in
from pcdet.models import load_data_to_gpu
File "/root/VoxelNeXt/tools/../pcdet/init.py", line 4, in
from .version import version
ModuleNotFoundError: No module named 'pcdet.version'
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 31174) of binary: /root/miniconda3/bin/python
Traceback (most recent call last):
File "/root/miniconda3/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/root/miniconda3/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/root/miniconda3/lib/python3.8/site-packages/torch/distributed/launch.py", line 193, in
main()
File "/root/miniconda3/lib/python3.8/site-packages/torch/distributed/launch.py", line 189, in main
launch(args)
File "/root/miniconda3/lib/python3.8/site-packages/torch/distributed/launch.py", line 174, in launch
run(args)
File "/root/miniconda3/lib/python3.8/site-packages/torch/distributed/run.py", line 710, in run
elastic_launch(
File "/root/miniconda3/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 131, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/root/miniconda3/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 259, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
============================================================
train.py FAILED

Hello, how did you solve this problem？
I would like to reproduce voxelnext also encountered the same problem.
Thanks!

Hello, how did you solve this problem？ I would like to reproduce voxelnext also encountered the same problem. Thanks!

Yes, it's settled. git clone openpcdet in the VoxelNext directory

hello，I want to reproduce voxelnext also, but I don't know how to verify that the configuration is successful, and where to put the datasets, whether mini nuscenes can be used for testing, etc., please help, thanks!

python setup.py develop