[suggest] Eloquent - hide sensitive information for json

Currently if one using eager loading, Eloquent will have something like
App\User {
     id: 1,
     name: "Bob",
     email<EMAIL_ADDRESS>     deleted_at: null,
     created_at: "2016-03-09 16:43:11",
     updated_at: "2016-03-09 16:43:11",
     posts: Illuminate\Database\Eloquent\Collection {
       all: [
         App\Post {
           id: 1,
           user_id: 1,
           title: "Some title",
           body: "Some body text, suppose to be long",
           private: 0,
           deleted_at: null,
           created_at: "2016-03-09 16:44:41",
           updated_at: "2016-03-09 16:44:41",
         },
       ],
     },
   }

It is all good except when I throw all of that to json, it will throw up some of id, user_id that I don't want (since it eager loading, I can't use select() to get rid of id and user_id ), could there be a way I define what I don't wanna show in model and call hide(), like
protected $hide ['id']                      //User model
protected $hide = ['id', 'user_id']         //Post model

User::whereId(1)->hide()->with('posts')->hide(['id', 'user_id'])->get()

Right now, when get the return value from Eloquent, I'm check instanceof and unset manually, would be a trouble if it a big collection.

https://laravel.com/docs/5.2/eloquent-serialization#hiding-attributes-from-json

thx a ton @browner12 :D


Parameterized .count() queries

Essentially, this comment: https://github.com/prisma/photonjs/issues/202#issuecomment-529818807
Also note that after and skip params should also be accounted for.
This issue is relevant for https://github.com/prisma/studio/issues/119
Creating this issue for documentation, feel free to move wherever.

These are things Studio needs w.r.t. the new designs:

It needs to be able to account for after & skip parameters, since these two params will directly affect the total number of records that are fetched. Studio allows you to manually specify these values for saved / detached queries in the databrowser. Since .count() does not take any parameters yet, the count on the databrowser might be wrong if the user changes them. Accounting for skip is simple enough by subtraction, but after might not always be possible.

It needs to be able to count the number of relations. The idea is to use these counts to populate the relation counts in the results table rather than include the full relation as a field to be returned (as it is done right now).

Internal note: dropping from this sprint because Jan did not want to read this long message during the meeting.

Internal Note: (Meeting was over time already - we will look into this again next sprint as it will "keep" the candidate label.)

Dropping this for now in favor of other query engine work.

Dropping this for now in favor of other query engine work like query batching, needed for dataloader.

That sounds really exciting.

Just wanted to note in general that this is not required to pagination and is not necessarily related to that. It can be used in addition to pagination, i.e. showing the total count of a table, but usually is not used for e.g. relay pagination (since it's not performant on huge tables anyway).

@steebchen It required if you are doing filtered pagination. Right now it is not possible to go findMany({ where: { ...}).count() and many times you want paginate over it for example, if you want to display a search result.

Internal Note: Dropping from current sprint, and picking up later.

Just wanted to note in general that this is not required to pagination and is not necessarily related to that. It can be used in addition to pagination, i.e. showing the total count of a table, but usually is not used for e.g. relay pagination (since it's not performant on huge tables anyway).

I get what you are trying to say but a lot of datatable libraries do require the total number of items in order to handle pagination properly.
Some features simply can't function without it:

displaying the number of pages
letting the user go the last page (doesn't concern all libraries though)
adapting the number of items to show per page (if there are only 10 results, there is no point to let the user select 50 items per page)

@pierreyves-lebrun Agreed! I'm just saying for the very core feature of pagination this is not required, as this assumption has popped up a few times.
Of course, if the user wants advanced pagination, we also want to build this feature.
However, that should be up to the user, as often count queries can easily get slow with big tables, while the core of pagination will always be fast regardless of the table size.

FYI; someone in the Slack mentioned this and we've built a workaround for this which I posted there, I'll post it here for some other people that might not be in the prisma-2 Slack :)
We've implemented a query that returns the count of items with a provide where clause; this way we can get the count of a filtered list
In the frontend it looks like this
 query fetchDepartmentList($where: DepartmentWhereInput!, $skip: Int, $first: Int) {
    departments(
      where: $where,
      skip: $skip,
      first: $first
    ) {
      id
      name
      address {
        street
        number
        bus
        zip
        city
      }
      email
    }
    departmentCount(where: $where)
  }
`;

Not the most efficiënt way to do things, but it's a temporary solution and only a single query extra while fetching the data :slightly_smiling_face:

The engine now supports regular filtering / pagination on count queries.

@dpetrick great, is there any documentation around this?

This is implemented in the Query Engine, but not the client that exposes this functionality yet. You will have to wait a bit for that - this issue will be closed then.

Thanks a lot for reporting 🙏
This issue is fixed in the latest alpha version of @prisma/cli.
You can try it out with npm i -g @prisma/cli@alpha.
In case it’s not fixed for you - please let us know and we’ll reopen this issue!

@timsuchanek, is there a doc on this? Thanks.

Thank you, here is a link to the docs: https://www.prisma.io/docs/reference/tools-and-interfaces/prisma-client/crud#count
You can use it like following:
prisma.user.count({ where: { name: 'Bob' }})

count has exactly the same params as findMany.

Awesome. Thanks @divyenduz


Accessing state of siren

I'd like to be able to see detect the siren is currently off, on or on with the sound going. I've been looking at the documentation but haven't been able to find anything remotely close.
If the option is not already there, I'd like to contribute so a few pointers in the direct direction and I might be lucky to figure it out! :)

Hi, you can do this using the Electrics sensor. For a connected vehicle veh, the following code should help you to access the data you need:
from beamngpy.sensors import Electrics

veh.sensors.attach(Electrics()) # attach the sensor

veh.sensors.poll() # poll new sensor values
veh.sensors['electrics']['lightbar'] # 0.0 = sirens off, 1.0 = sirens on, 2.0 = sirens on with sound

Amazing! That's exactly what I need. Thank you! :)


[lib.dom.d.ts] hashchange in WindowEventHandlersEventMap maybe wrong?

lib Update Request

Configuration Check

My compilation target is ES2015 and my lib is the default.
Missing / Incorrect Definition

interface WindowEventHandlersEventMap {
    "afterprint": Event;
    "beforeprint": Event;
    "beforeunload": BeforeUnloadEvent;
    "gamepadconnected": Event;
    "gamepaddisconnected": Event;

    // HERE
    "hashchange": Event;

    "languagechange": Event;
    "message": MessageEvent;
    "messageerror": MessageEvent;
    "offline": Event;
    "online": Event;
    "pagehide": PageTransitionEvent;
    "pageshow": PageTransitionEvent;
    "popstate": PopStateEvent;
    "rejectionhandled": PromiseRejectionEvent;
    "storage": StorageEvent;
    "unhandledrejection": PromiseRejectionEvent;
    "unload": Event;
}

Sample Code
export function addUrlChangeListen(
  hashChangeListener: (ev: HashChangeEvent) => void,
  stateChangeListener?: (ev?: PopStateEvent) => void,
): () => void {

  // the type here is HashChangeEvent in previous version. but now it is Event
  window.addEventListener('hashchange', hashChangeListener);
}

HashChangeEvent !== Event. and in my opinion, it should be HashChangeEvent
Documentation Link

relate PR: https://github.com/microsoft/TypeScript/blame/main/lib/lib.dom.d.ts#L17315

See also: https://github.com/microsoft/TypeScript-DOM-lib-generator/


Migrate TextInputWithBadgesTypeahedStoryHelper from a class to a function component

Description
This issue is related to refactoring the  TextInputWithBadgesTypeahedStoryHelper.tsx file. (wow that's a doozy of a filename!)
Acceptance Criteria
Refactor the component from a class component to a function component.
Feel free to contribute other improvements to the component while refactoring if you notice any.
Refer to other components to keep formatting consistent. For example, reference the Badge, BadgeButton, or Tabs components.
How to Contribute
Please review the contributing documentation beforehand.
Steps to Contribute:

Fork the repository.
Clone it to your local system.
Create a new branch.
Make your changes. Make sure that tests are still passing. To update snapshot tests, run npm run test -- -u and include the updated tests in your commit.
Commit your changes.  When committing be sure to prefix with the appropriate conventional commit type. For example, refactor: buttonbase component.
Push up your changes. In GitHub, click the compare & pull request button to begin drafting your pull request.
Fill out the pull request form and attach the "ready to review" label when complete.

Hi @nataliepina, I'd love to take on this issue!

I've assigned you, thanks @derekhassan!


iPhone XR - No Text showing

Same status bar message showing in iPhone X but not showing in XR.

Any Update on this. As compare to another model, this is not compatible with XR.

Issue with iPhone XR and iPhone 11. Not show all content.

iOS 13 does not support drawing over the status bar anymore.


Shopify Web Scraper

Description
Shopify Web Scraper
Type of issue

NOTE: These boxes can be checked using [X]

[X] Feature (New Script)

[ ] Bug

[ ] Documentation

Checklist:

[X] I have read the project guidelines.
[X] I have checked all the existing projects, before submitting a new project issue.
[X] I have checked previous issues to avoid duplicates.
[X] This issue will be meaningful for the project.

I wanted to be assigned to this, may I?

I wanted to be assigned to this, may I?

sure @xcodz-dot

thanks

@xcodz-dot are u working on this??

Sorry, I will not be able to work cause my school examinations are going on and i have to pay attention to ht codeathon

Sorry, I will not be able to work cause my school examinations are going on and i have to pay attention to ht codeathon
@AdityaJ7

OK no problem @xcodz-dot Good luck with the exams and codeathon

Hey, can I work on this? @AdityaJ7

Hey, can I work on this? @AdityaJ7

sure @Meghana-12

Hey, could you confirm if this is legal? https://www.shopify.in/robots.txt most of the stuff is disallowed.

Hey, could you confirm if this is legal? https://www.shopify.in/robots.txt most of the stuff is disallowed. @AdityaJ7

I guess it's not but I am not sure as @xcodz-dot opened this issue

noop it is not illegal. it is web scraper and it does not interfere with server data nor does it upload any data to server. it simply downloads and parses the data.

ok this is not stale

this is noot stale


Add Protocols and CipherSuites constants

Motivation:
Protocols and Cipher suites constants to prevent typos in protocol and cipher suites names and ease of use.
Modification:
Added Protocols and Cipher suites as constants in their respective classes.
Result:
Fixes #11393

/cc @normanmaurer @NiteshKant @danielbaniel

Yeah actually. Also, migrating from SslUtils to SslProtocols. I will commit changes in ~10 mins.

:| screwed up :(

I will open a new PR. This one is completely messed up,


Variables are not inherited from custom class

Godot version
4.0.1
System information
Windows 7 64-bit, GTX 750 Ti GPU
Issue description
So I have this class that is an extension of Control:

This class has two variables that are needed:

So I extended this class, to use for different data types

I attempt to create on in the main scene with the following code:
	if create_picker:
		var sphere : MeshInstance3D = get_node("Sphere")

		var picker : PropertyPicker = PropertyPicker.create(sphere,"global_position","Vector3")
		self.add_child(picker)

Using this code returns the following error:

So I added a testing var that essentially comments this out:

I then manually added an instance of the picker in godot, and disabled the creation

Running the scene, it appears as it should..

But upon going to Remote, it shows that the variables are completely missing

Maybe it has nothing to do with the inheritance of classes? I thought, so I did this:

But upon running, these intended variables are there, but only on the base class.

Steps to reproduce

Create a class, and give this class variables
Extend the class
Instance a node from the extension
Variables from the original class are not there.

Minimal reproduction project
bad_class.zip

It looks like it is about recursive dependencies in resources/scenes:
The problem here is that PropertyPicker preloads a scene with a script (PropertyPickerVector3) which extends PropertyPicker, and while recursive dependencies are supposed to be supported for gdscript, that support is not yet extended to resources/scenes.
As an evidence for that the error says on base : 'Control ()', so the script is not loaded properly, and if preload('....tscn') is replaced with preload('....gd') (and new instead of instantiate) then the error is gone.

Editor only. Does not affect scripts running in normal game mode.
Versions: 4.0.2, 4.0.1, 4.0, 4.0 RC series?, 4.0-beta17?
Apparently the dependency info is cached, so the breakage only becomes apparent if you edit your subclass script or delete your .godot cache dir.
According to my notes/commits, I was using beta 16 the last time I edited an inherited class used in my editor tools, which suggests that the regression occured in beta 17 or one of the RCs.

Followup note for anyone else experiencing this issue in the editor - make sure you have "@tool" at the top of all class scripts you use (or inherit from) in editor scripts. That fixed it for me.
Apparently in 4.0-beta releases, script dependencies were automatically loaded in the editor, but that was either unreliable or unintended.
Sure would be nice to have more useful error messages...


Updated dependencies

This updates both the back and the front dependencies.

When testing the app with the new dependencies, I see this error in the browser console:

This is what I see in the HTML source code of the page:

Which is the same as in the entrypoints.json file:

Closing in favor of #1151 and #1152.


feature requests: use query->indexBy for dataProvider->key

Hi
I have a question that could be a feature:
when I use $query->indexby(anotherField),  it is better $dataProvider using 'anotherField' as key and then $dataProvider->getKeys() returns indexed keys.
At now I use this code for covering this issue:
$dataProvider->key = $dataProvider->query->indexBy;
and then:
var_dump($dataProvider->getKeys());
Thanks for great Framework

My understanding,
If the provided ActiveQuery has an indexBy set the ActiveDataProvider should set its ->key property to the same indexBy.


Removed view/Dependencies from asmtools URL

Fixes #546
cc
@llxia
@smlambert

I've added the 'closes' remark and will merge. Thanks @IamLRBA !

Thank you for the opportunity @smlambert, I will be on the lookout for other "good first issue" issues to help me contribute more to the community.

I will be on the lookout for other "good first issue" issues to help me contribute more to the community.

That will be wonderful @IamLRBA ... if you like to do more, we can pick out a few slightly bigger tasks to involve you in.  For example, it would be good to address this one, https://github.com/adoptium/TKG/issues/363


fix java 8 issue with new interface declaration

Fixes interface declaration and lambda in aeron response test.

Refer to this link for build results (access rights to CI server needed):
/job/nd4j_PR/208/Failed Tests: 7nd4j_PR/org.nd4j:nd4j-aeron: 5org.nd4j.aeron.ipc.response.AeronNDArrayResponseTest.testResponseorg.nd4j.aeron.ipc.AeronNDArraySerdeTest.testToAndFromorg.nd4j.aeron.ipc.AeronNDArraySerdeTest.testToAndFromCompressedorg.nd4j.aeron.ipc.AeronNDArraySerdeTest.timeOldVsNeworg.nd4j.aeron.ipc.NdArrayIpcTest.testIpcnd4j_PR/org.nd4j:nd4j-kryo_2.10: 1org.nd4j.TestNd4jKryoSerialization.testSerializationnd4j_PR/org.nd4j:nd4j-parameter-server-client: 1org.nd4j.parameterserver.client.ParameterServerClientTest.testServer

Refer to this link for build results (access rights to CI server needed):
/job/nd4j_PR/209/


encoding/csv: allow for interpretation of empty lines

Empty lines are ignored by default, this change introduces a switch that
changes this behaviour - empty line is then interpreted as a single empty
field. This is especially important when dealing with single-column CSVs,
where an empty line is actually data (an empty field).
Fixes #39119.

@googlebot I signed it!

Is this PR still active? I'm running into this issue currently in a project where I need to map the csv line number to the actual line number in a file. This PR looks like it would resolve my issue as is.
I have multiple columns, but simply need the csv decode to retain an empty field for the empty row.

See: https://github.com/golang/go/pull/45228
@kokes If you are still available to work on this PR and would like to take it over the finish line please feel free to message me and I will close the new PR.

@kdumontnu it's not really an issue of my availability - I submitted a PR that solves the issue as I see it and retains the current behaviour as default, but it was rejected by Ian from the Go team, so there's not much I can do about that - see the issue I opened originally.

We've pretty much decided that we are not going to add additional knobs to encoding/csv. There are just too many variations in CSV files out there. Trying to handle all of them would lead to a massive proliferation of knobs and an unusable package API.

I haven't reviewed your PR fully, but from the look of it, it will not pass either.
I solved it for myself by forking encoding/csv, not much else I can do about this.

Ah, I see - thanks for the reply. That's frustrating... You are correct - my PR is just a continuation of yours with an updated comment.


Device polling could be implemented in a common class

Currently the LEDIcon class is used in a few places in conjunction with a QTimer that polls the device and flashes the LED. We could encapsulate this in a class which just takes a poll interval and pubsub topic name as parameters.

This issue is a bit ill-defined so I'll close it for now. If we do want to refactor LEDIcon at some point, we can write a better issue for it.


Clarify use of #[tokio::main]

This is also an issue in hyperium/hyper#2028.
Basically, the #[tokio::main] macro is used for examples but the dependency is not explicitly mentioned in readme or docs. Could be pretty confusing. I haven't seen an issue with reqwest yet, so this is preemptive, but I've seen people have issues with hyper and warp.
Also, the dep should look something like:
tokio = { version = "0.2.3", features = ["macros"] }

Yes, I'm running into a similar issue trying to follow the github examples. Essentially I'm getting
--> src/main.rs:4:3   | 4 | #[tokio::main]   |   ^^^^^ use of undeclared type or moduletokio
But I can't find any documentation about how to properly use this anywhere.

@anthonyjchriste note that when using the non-alpha version of tokio, you'll have to use the feature "macros", see original comment.
This is because tokio split its features.

I've opened #745 to add a note to the examples.

@hwchen Thank you! That is very useful information. I'm fairly new to async/await and am finding the ecosystem a bit daunting. I'm writing a web scraper as a pet project and figured that would be a great chance to get into the async/await ecosystem.
What you explained makes perfect sense and I was able to find more information in Tokio's blog post: https://tokio.rs/blog/2019-11-tokio-0-2/


docs(project): adding project specific files

Changes:

This PR adds project specific files to guide contributors
List of the files is as below:

.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature-request.md
.github/pull_request_template.md
CONTRIBUTING.md
GOVERNANCE.md
RELEASE.md
code-standard.md
developer-setup.md

Signed-off-by: mayank<EMAIL_ADDRESS>

@kmova I've address the review comment. PTAL.


export csv: coin values as floats (big currency)

it is not obvious that coin values are exported as satoshis, not btc.

I would not export values as floats as default since its a lossy process.

Ok, after discussions. Might be ok to do since easier for the users. Longer term; provide both options

Now the export provides both, the base satoshi, wei values as well as converted to the base currency (btc, eth) as floats.  In that turn i also changed that timesamps are exported as dates not as ints.

Fixed in 4c0e18702fe414c8bf19eb7e2e7fd49e3ad184b2


Check on association bug possiblity

E.g.,:
Correct: a & b | b & c -> Or(And(a,b), And(b,c)
Incorrect:  a & b | b & c  -> And(Or(And(a,b),b),c)

checked in python shell, works "correctly" (not sure why but it does, I would have implemented it to do the latter)


[ParamountPlus] Show extractor doesn't fetch all episodes...

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
United States
Description
...apparently the maximum length of episode list is exceeded
Example show: Link to show
As already mentioned in still closed #602, yt-dlp only returns 50 episodes for the above show example, but show has 112 episodes as properly returned by the json info, my fix below (patch for paramountplus.py) works and I encourage any of the maintainers to apply my fix.
But... any other solution (e.g. a more elegant one) would also be appreciated as well...
   def _entries(self, show_name):
        show_json = self._download_json(self._API_URL.format(show_name, 0), video_id=show_name)
        if show_json.get('success'):
            total = show_json['result']['total']
            episodes = show_json['result']['data']
            x, y = divmod(total, 50)
            if y != 0:
                x += 1 # x is the amount of times (total amount; we already have done it once at this point) we need to fetch the API url with additional pages
            if x > 1: # only if x is larger than one (=the fetch already done above), we will need additional fetches
                for i in range(1,x):
                    show_json = self._download_json(self._API_URL.format(show_name, i), video_id=show_name)
                    if show_json.get('success'):
                        episodes.extend(show_json['result']['data'])
            for episode in episodes:
                yield self.url_result(
                    'https://www.paramountplus.com%s' % episode['url'],
                    ie=ParamountPlusIE.ie_key(), video_id=episode['content_id'])

Verbose log
DOES NOT APPLY (the problem is described above)
Essentially, I can't providing missing output for the missing episodes, for this reason:
It's missing.

DOES NOT APPLY (the problem is described above)
Essentially, I can't providing missing output for the missing episodes, for this reason:
It's missing.

It DOES APPLY! You should have put the log of yt-dlp -vU URL (you could also add --flat-playlist/--simulate to speed it up) to demonstrate that not all episodes are being downloaded
But I understand what is happening here even without the log, so I'll let this pass

We seem to be collecting episodes from all seasons (season 0) with
https://www.paramountplus.com/shows/{show_name}/xhr/episodes/page/{page}/size/50/xs/0/season/0
Doesn't iterating on page fetch all the episodes in chunks of 50?
(404 in UK)

Yes, but... to "iterate" over page you have to know how many pages exist
(Unless of course you're ok with requesting either a certain number of pages maximum (e.g. via range) or in a while-loop... untill finally some page returns empty results)
The code example I provided above does it with calculation of needed pages.
Heres a simplified flow chart of what happens
Fetch first page —> Calculate how many additional pages are necessary, if any —>  Fetch additional pages
if AmountOfEpisodes<51: don't fetch anything else
(always at the end) —> transfer info of fetched episodes
PS: All of this is still largly flawed for lack of method to download individual seasons...

...until finally some page returns empty results

I believe that's what happens now, quitting when the JSON doesn't give success (also crashing if the URL gives 404, etc):
    def _entries(self, show_name):
        for page in itertools.count():
            show_json = self._download_json(
                f'https://www.paramountplus.com/shows/{show_name}/xhr/episodes/page/{page}/size/50/xs/0/season/0', show_name)
            if not show_json.get('success'):
                return
            for episode in show_json['result']['data']:
                yield self.url_result(
                    'https://www.paramountplus.com%s' % episode['url'],
                    ie=ParamountPlusIE.ie_key(), video_id=episode['content_id'])

Apparently, to get by season, use .../season/{season_num} instead.
Maybe 50 isn't the ideal chunking size, as it just fails to get a year of weekly shows.

I reported this while unaware that the issue I was reporting was probably already fixed to some extent.
I had not been aware of ec47c12 (which is a commit that has been made since the time of the last release).
I still think my above mentioned approach is somewhat better:
It causes considerably less empty page requests on the endpoint of the service.
@dirkf I think I know what you mean. -
Is this an example where it doesn't work or could you give me one example where that is the case?

Can you clarify whether https://github.com/yt-dlp/yt-dlp/commit/ec47c12f69857f09a79787a7346c957f5b3d4e16 fetches all the pages?
Since you were making code suggestions, I assumed you are on the git master. I really should have forced you to show the log 😔
If it does, your solution is not more "elegant".
x, y = divmod(total, 50)

making this assumption only makes the code more likely to break in the future. And the number of API requests made are the same using either method.

I'm sorry about rhe confusion with what version of YouTube DL I was using.
I thought that it was clear when I put the version number that I was in rhat release.
And not the latest git. I will now know this for the future and I will further clarify when I find it necessary.
However, your statement about the existing code not making more requests is wrong.
The function currently has a return statement to be executed on API failure. ("when not success")
This happens on a non-existing page.
That ist not a good solution when it is possible to do it one better.
Sure things can break, I don't see how this one is more subject to breaking than the other solution


Changes snippets to 4 space indentation

Also small improvements to record and record type snippets. Fix for issue #120

Thanks.


Document how to run the sample app

Since there can be some confusion on how to run the sample, we should add documentation on how to run the sample app.

I apologize I forgot about #45, going to close this duplicate


Feature request: per-project presets

Usually our flow when working on project looks like:

open terminal, run command 1,
open new terminal tab, run command 2,
open new terminal tab, cd to the project, run command 3
open new terminal tab and git status
I also like to rename each tab, to fit my needs

real life example:
brunch.io for compiling sources, express for file serving, mongod for database, and deployd for backend
It would be cool, if I could save the preset, that each time I get same tabs.

There is an options in Settings > Startup to autosave/restore opened tabs.

If that isn't what you want, you can create your own task in setting and give it all the tabs you want and then start that task and in Startup options set that task as the startup.


readme: direct link to Prometheus docker image

There are quite a few repositories already, so we don't have to make people search.

Updated

lgtm


Why can I specify only two categories in the prompt?

Have you tried to specify more categories? I want to generate images and annotations with more categories, how can I do ?

I have the same question. Have you resolved it?  Looking forward to your reply.


fixes JDBC_PING.readAll() executing ResultSet.deleteRow() on readonly ResultSet

After updating JGroups the JDBC_PING constantly printed the failed removing row; please delete it manually error message. The cause was my program not exiting cleanly before updating, leaving rows in the cluster table. After the update, the PingData of the previous version failed deserialization and JGroups attempted deleting the offending row. Since the PreparedStatement was created readonly using the default parameters of Connection.prepareStatement(), the call resulted in an error causing the message printout.
The fix creates the statement as updatable so that the row can be deleted.

Thanks Thomas!


Compatibility certification request for EI of JXWS 3.0.0

[x] Organization Name ("Organization") and, if applicable, URL:
Eclipse Foundation
[x] Product Name, Version and download URL (if applicable):
Eclipse Implementation of Jakarta XML Web Services 3.0.0
[x] Specification Name, Version and download URL:
Jakarta XML Web Services 3.0
[x] TCK Version, digital SHA-256 fingerprint and download URL:
Jakarta XML Web Services TCK 3.0.0, SHA-256: 7562e880b86893adff0e846fc265ee5feaf9ffea5ba32a151153755a376ad628
[x] Public URL of TCK Results Summary:
TCK results summary
[x] Any Additional Specification Certification Requirements:
None
[x] Java runtime used to run the implementation:
Oracle JDK 1.8.0_202
[x] Summary of the information for the certification environment, operating system, cloud, ...:
Linux
[x] By checking this box I acknowledge that the Organization I represent accepts the terms of the EFTL.
[x] By checking this box I attest that all TCK requirements have been met, including any compatibility rules.

accepted by lazy consensus


chore: remove Jcenter deadline for old SDK versions

Jcenter removed the deadline for old SDK versions.

Pull Request Test Coverage Report for Build 1935

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.735%

Totals

Change from base Build 1926:
0.0%

Covered Lines:
4867

Relevant Lines:
5364

💛  - Coveralls


ng generate component not working properly

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 7.0.3
Node: 8.11.1
OS: darwin x64
Angular: 6.0.9
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        7.0.3
@angular/cli                      7.0.3
@ngtools/webpack                  6.0.8
@schematics/angular               7.0.3
@schematics/update                0.10.3
rxjs                              6.3.3
typescript                        2.7.2
webpack                           4.8.3

Repro steps

ng generate component example --module app

The log given by the failure

CREATE src/app/example/example.component.ts (259 bytes)
UPDATE src/app/app.module.ts (1341 bytes)

Desired functionality

It creates only the .ts file and all the others component files are missing
Mention any other details that might be useful

link to the minimal repro here:
https://github.com/emiliogambone/sampleAngular

Duplicate of https://github.com/angular/angular-cli/issues/12747

Hi, this is correct, as you are specifying that the files should be inlined. https://github.com/emiliogambone/sampleAngular/blob/a039259da3dfc8d338a048f0a2dc7f9e88f4d02a/angular-site-template-v1.0/angular.json#L132-L137

Hi, this is correct, as you are specifying that the template and styles for components should be inlined and not to create spec files. https://github.com/emiliogambone/sampleAngular/blob/a039259da3dfc8d338a048f0a2dc7f9e88f4d02a/angular-site-template-v1.0/angular.json#L132-L137

thank, i understand now


Speedment shall inhibit logging of thrown SQLExceptions

Exceptions caused by SQLExceptions shall not be logged by Speement if they are thrown to the user.
For cases of retry, there shall be a LogType.SQL_RETRY such that an application built with withLogging(SQL_RETRY) will log SQL-related exceptions that cause retry. The default behavior is to suppress exceptions from intermittent problems that are later overcome by retrying.

This involves changes in AbstractDbmsOperationHandler::executeNotInTransaction and AbstractDbmsOperationHandler::executeInTransaction to supress retrying exception printout and adding a new enum value in ApplicationBuilder.LogType as per comment above.


chore: update ignore, ESLint, Stylelint configs

:tada: This PR is included in version 6.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Year change from 2017 to 2019

Thanks but we do not merge PRs into master and we already fixed this issue in develop https://github.com/dashpay/dash/blob/develop/COPYING#L4. Closing.


Effect manager

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

152 of 152 (100.0%)  changed or added relevant lines in 14 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.7%) to 99.337%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/Game.class.st
4
96.23%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
599

Relevant Lines:
603

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

152 of 152 (100.0%)  changed or added relevant lines in 14 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.7%) to 99.337%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/Game.class.st
4
96.23%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
599

Relevant Lines:
603

💛  - Coveralls


[5.7] Allow models to be created with an API resource

I work in projects where all models have resources and this is a bit convenient - I imagine it would be useful to some people too.
Not a big or interesting change, just something I thought would be nice.

I feel like models already have a lot of flags so not wanting to add many more :|


Cannot run open_soma() from Europe server

Dear Authors,
Thank you so much for developing this tool. I tried to open_soma() from Europe servers, but I kept getting the following error. If I run open_soma() from US servers, I do not have the following error. Could you please share some insights? I need to have it run on Europe servers.
File "tiledb/libtiledb.pyx", line 3706, in tiledb.libtiledb.object_type
File "tiledb/libtiledb.pyx", line 348, in tiledb.libtiledb.check_error
File "tiledb/libtiledb.pyx", line 342, in tiledb.libtiledb._raise_ctx_err
File "tiledb/libtiledb.pyx", line 327, in tiledb.libtiledb._raise_tiledb_error
tiledb.cc.TileDBError: [TileDB::S3] Error: Error while listing with prefix 's3://cellxgene-census-public-us-west-2/cell-census/2023-12-15/soma/__schema/' and delimiter '/'[Error Type: 99] [HTTP Response Code: -1] : curlCode: 28, Timeout was reached

I just tried to replicate this on an AWS instance running on eu-north-1, but did not see this error. Here's what I did:
mamba create -yn cellxgene-census "python=3.11"
conda activate cellxgene-census
pip install ipython cellxgene-census
ipython

import cellxgene_census
census = cellxgene_census.open_soma()
census

The "stable" release is currently 2023-12-15. Specify 'census_version="2023-12-15"' in future calls to open_soma() to ensure data consistency.

<Collection 's3://cellxgene-census-public-us-west-2/cell-census/2023-12-15/soma/' (open for 'r') (2 items)
    'census_info': 's3://cellxgene-census-public-us-west-2/cell-census/2023-12-15/soma/census_info' (unopened)
    'census_data': 's3://cellxgene-census-public-us-west-2/cell-census/2023-12-15/soma/census_data' (unopened)>

@Alex2975, is this roughly similar to what you did? And is it intermittent? I was able to at least connect to this back when I was in Germany, but that was on an institutional connection.
It would also be great if you could report some library versions here? You can do this by running:
import cellxgene_census, session_info
session_info.show(html=False, dependencies=True)

And paste the output here like:

-----
IPython             8.25.0
cellxgene_census    1.14.0
session_info        1.0.0
-----
aiobotocore         2.13.0
aiohttp             3.9.5
aioitertools        0.11.0
aiosignal           1.3.1
anndata             0.10.7
asttokens           NA
attr                23.2.0
attrs               23.2.0
botocore            1.34.106
certifi             2024.06.02
charset_normalizer  3.3.2
cython_runtime      NA
dateutil            2.9.0.post0
decorator           5.1.1
executing           2.0.1
frozenlist          1.4.1
fsspec              2024.5.0
h5py                3.11.0
idna                3.7
jedi                0.19.1
jmespath            1.0.1
llvmlite            0.42.0
multidict           6.0.5
natsort             8.4.0
numba               0.59.1
numpy               1.26.4
packaging           24.0
pandas              2.2.2
parso               0.8.4
prompt_toolkit      3.0.45
pure_eval           0.2.2
pyarrow             16.1.0
pyarrow_hotfix      NA
pygments            2.18.0
pytz                2024.1
requests            2.32.3
s3fs                2024.5.0
scipy               1.13.1
six                 1.16.0
somacore            1.0.11
stack_data          0.6.3
tiledb              0.29.0
tiledbsoma          1.11.3
traitlets           5.14.3
typing_extensions   NA
urllib3             2.2.1
wcwidth             0.2.13
wrapt               1.16.0
yarl                1.9.4
-----
Python 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:36:13) [GCC 12.3.0]
Linux-6.8.0-1008-aws-x86_64-with-glibc2.39
-----
Session information updated at 2024-06-03 17:34

Thank you for getting back to me so quickly, @ivirshup .
I followed your instructions, and still got the same timeout error.
File "tiledb/libtiledb.pyx", line 3706, in tiledb.libtiledb.object_type
File "tiledb/libtiledb.pyx", line 348, in tiledb.libtiledb.check_error
File "tiledb/libtiledb.pyx", line 342, in tiledb.libtiledb._raise_ctx_err
File "tiledb/libtiledb.pyx", line 327, in tiledb.libtiledb._raise_tiledb_error
tiledb.cc.TileDBError: [TileDB::S3] Error: Error while listing with prefix 's3://cellxgene-census-public-us-west-2/cell-census/2023-12-15/soma/__schema/' and delimiter '/'[Error Type: 99] [HTTP Response Code: -1] : curlCode: 28, Timeout was reached
Here is the session info:

session_info.show(html=False, dependencies=True)

cellxgene_census    1.14.0
session_info        1.0.0
aiobotocore         2.13.0
aiohttp             3.9.5
aioitertools        0.11.0
aiosignal           1.3.1
anndata             0.10.7
attr                23.2.0
attrs               23.2.0
botocore            1.34.106
certifi             2024.06.02
charset_normalizer  3.3.2
cython_runtime      NA
dateutil            2.9.0.post0
frozenlist          1.4.1
fsspec              2024.5.0
h5py                3.11.0
idna                3.7
jmespath            1.0.1
llvmlite            0.42.0
multidict           6.0.5
natsort             8.4.0
numba               0.59.1
numpy               1.26.4
packaging           24.0
pandas              2.2.2
pyarrow             16.1.0
pyarrow_hotfix      NA
pytz                2024.1
requests            2.32.3
s3fs                2024.5.0
scipy               1.13.1
six                 1.16.0
somacore            1.0.11
tiledb              0.29.0
tiledbsoma          1.11.3
typing_extensions   NA
urllib3             2.2.1
wrapt               1.16.0
yarl                1.9.4
Python 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:36:13) [GCC 12.3.0]
Linux-3.10.0-1160.108.1.el7.x86_64-x86_64-with-glibc2.17

I also tried: census = cellxgene_census.open_soma(mirror='s3-eu-north-1')
But I got this error:
.../python3.11/site-packages/cellxgene_census/_open.py", line 224, in open_soma
raise ValueError("Mirror not found.")
ValueError: Mirror not found.

Ah yeah, there aren't actually any mirrors up yet.
For the continued failures, is it possible there's a firewall on your end?

Yes, there is a firewall on the servers. Do you think that potentially cause the error? Could that be a time out or access error? If it is time out, how can I increase the waiting time?

That would definitely cause the error. It may just always block the connection, but it just looks like a the connection takes a while for you.
Could you try:
import s3fs

fs = s3fs.S3FileSystem()
fs.ls("s3://cellxgene-census-public-us-west-2")

If this also doesn't work, you would probably need to ask your IT team about this.
Could also confirm by trying this on a different network without the firewall?

Thank you, @ivirshup . When I ran the fs.ls, as you described, without firewall, I got the error:
PermissionError: Access Denied.

When I ran aws s with no sign request, I did get certain results back (with or without firewall, I got the same answer):
aws s3 ls --no-sign-request s3://cellxgene-census-public-us-west-2/cell-census/
                       PRE 2023-05-15/
                       PRE 2023-07-25/
                       PRE 2023-10-30/
                       PRE 2023-12-04/
                       PRE 2023-12-06/
                       PRE 2023-12-15/
                       PRE 2024-04-29/
                       PRE 2024-05-06/
                       PRE 2024-05-13/
                       PRE 2024-05-20/
                       PRE 2024-05-27/

2023-12-13 10:28:59        190 mirrors.json
2024-05-28 07:11:43       3642 release.json

Hm. That's odd. And you're definitely not passing any other arguments here, and consistently get a timeout? I may ping a couple more people to see if there's something they recognize here.
And cellxgene_census.open_soma() still doesn't work without the firewall?

@Alex2975 seems like you are able to access Census now, is that correct?
see #1195

@ivirshup  and @pablo-gar , thank you so much for helping me. I still cannot access open_soma() from Europe cluster that I use. But I am currently access it from USA cluster. We are internally investigating the network proxy connections to see if anything is blocked from inside.

@pablo-gar , may I ask you a question regarding geneformer. Would you please share if possible, what are the differences between the datasets for training geneformer and the datasets listed in cellxgene_census? Are the geneformer training datasets all included in cellxgene_census, or only partially overlapping? Thank you so much.
Also, @pablo-gar , would you please comment on when the new LTS data release will happen? The current LTS is from 12-15-2023, you mentioned a new version will be released and the "normalized" X_name="normalized" expression data will be released in the new release. Will that be released soon? Thank you very much for the help.

@Alex2975
If you are referring to pre-trained Geneformer mode it pre-trained with Genecorpus. I understand there is some non-significant level of overlap between Census and Genecorpus, but I recommend you reach out directly to the Geneformer developers for more details.
The new LTS was published this week, you can access it via census_version = "stable" or census_version = "2024-07-01"

I'm closing this ticket since the original issue doesn't seem to be a problem with our API

Thank you very much, @pablo-gar .


Install script style improvements

Hey, this popped up on my feed and I just had a quick read through the setup.sh script - I don't want to clutter up your repo with a million tiny style improvements so I'll just collect a few minor comments here:

/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/dewhurstwill/tfvm/main/setup.sh)"

Explicitly specifying the bash path is more brittle than trusting it to be in $PATH, you can also just pipe the output from curl into bash:
curl -fsSL https://raw.githubusercontent.com/dewhurstwill/tfvm/main/setup.sh | bash

From https://github.com/dewhurstwill/tfvm/blob/main/setup.sh#L60-L75

# Adding Alias
string_to_check='alias tfvm'
if grep -q "$string_to_check" ~/.bashrc ; then
echo "Already in .bashrc, Skipping..." 2>&1 >> ~/.tfvm/logs/install.log ;
else
echo "Adding alias to bashrc" 2>&1 >> ~/.tfvm/logs/install.log ;
echo "alias tfvm='python3 ${new_dir}/main.py'" >> ~/.bashrc ;
fi
if grep -q "$string_to_check" ~/.bash_profile ; then
echo "Already in .bash_profile, Skipping..." 2>&1 >> ~/.tfvm/logs/install.log ;
else
echo "Adding alias to bash_profile" 2>&1 >> ~/.tfvm/logs/install.log ;
echo "alias tfvm='python3 ${new_dir}/main.py'" >> ~/.bash_profile ;
fi

A few comments here:

You shouldn't need this alias, just use a shebang in main.py and symlink it into your $PATH
There's a good chance that the user might be using zsh, fish etc instead of bash in which case adding to bashrc won't be effective. echo $SHELL first to check.
Small thing: If you are going to write something to bashrc or similar, I'd probably check first if they want you to, or just output the lines they should add, more polite :)

From: https://github.com/dewhurstwill/tfvm/blob/main/setup.sh#L25-L35

# Creating Log Location
echo Creating log location
mkdir ~/.tfvm
mkdir ~/.tfvm/logs
touch ~/.tfvm/logs/install.log
# Creating Install Location
echo Creating install location
sudo mkdir $new_dir 2>&1 >> ~/.tfvm/logs/install.log
cd $new_dir 2>&1 >> ~/.tfvm/logs/install.log

I'm not sure you need logs for the install script TBH. Logs are great when things are happening without the user being there or when the output might be especially complex or verbose. But given that the commands you're redirecting to log files (mkdir, cd, curl etc) succeed silently (use -s for curl), you're not going to expose the user to any more noise by running them without redirection and have the added advantage that if there is something to see in stderr they will not need to work out where the log files are/cat them etc just to correct what will likely be a simple mistake
Also, if you are going to have log files for other reasons I'd suggest maybe putting them somewhere in $XDG_CACHE_HOME (falling back to ~/.cache) instead. I personally find it a bit annoying when scripts dump a load of dotfiles in my home directory and it's not XDG compatible either.

sudo ln -s ~/.terraform.versions/terraform /usr/local/bin/terraform 2>&1 >> ~/.tfvm/logs/install.log

Again, in the interest of keeping ~ tidy and being XDG friendly, I'd recommend sticking all your terraform versions somewhere like $XDG_DATA_HOME/tfvm/terraform-versions (fallback to ~/.local/share/ if $XDG_DATA_HOME isn't set. You can stick most of your files inside this tfvm folder then just symlink them where they need to be.

Hope the above is useful, haven't read through the python stuff but seems like a cool idea

Hi @ceuk
This is my initial build of tfvm and any feedback is greatly appreciated.
I will have a read of your comments and make changes where I see fit
Many Thanks,
Will

@ceuk Feel free to check out the latest changes
Thanks again,
Will


tests: functional test refactoring

Much of the code in the functional tests was copy and pasted around. This commit tries to reduce that a bit by providing functions for the common tasks of spawning, waiting, checking expected values, etc.
There is much more room for improvement, but this is a start.

Needs a rebase.

Mostly nitpicks, otherwise LFAD.

@krnowak thanks for the thorough feedback. I'v all the changes you've pointed out except the boolean value parameter. I like your suggestion, but I'd like to get that in a later commit with some other changes regarding the expected return statuses.

nice! love all the red. LGTM aside from one unused function..?

I've now made use of the previously unused function. The fetch tests were simply doing a 'child.Wait' after the regex check and not checking the output, so I've changed the function to do the same.
IMHO, we should probably check the output of those a little more robustly; a TODO.

I'm done for now. :)

I've rebased  after the "--net" change. Also made a small change, moving the waitOrFail into a defer where it was at the end of a function.

LGTM


/dev/null: operation not permitted error

Hi! Trying this on M1 Mac, docker desktop 4.12.0
Sample vagrant file
  config.vm.hostname = "ubuntu"

  config.vm.provider :docker do |docker, override|
    override.vm.box = nil
    docker.image = "rofrano/vagrant-provider:ubuntu"
    docker.remains_running = true
    docker.has_ssh = true
    docker.privileged = true
    docker.volumes = ["/sys/fs/cgroup:/sys/fs/cgroup:rw"]
    docker.create_args = ["--cgroupns=host"]
  end

  config.vm.provision :docker do |d|
    d.pull_images "redis:6-alpine"
    d.run "redis:6-alpine",
      args: "-d --name redis -p 6379:6379 -v redis:/data"
  end
end

vagrant up -provider docker leads to
docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error reopening /dev/null inside container: open /dev/null: operation not permitted: unknown.

I can vagrant ssh into the box just fine.

@kakoni I was able to reproduce this problem on my M1 Mac mini and I'm looking into it. I couldn't even run docker hello-world and I got the same error. So something broke with the Docker installation. :(

Got the same issue with Docker Desktop 4.15.0.
@kakoni Have you already opened an issue anywhere else? I just found this (old) one: https://github.com/docker/for-mac/issues/5527


Create Hero

Here's what you will be building:

Please refer to the design, and make sure you read the project plan.
If you have any questions, don't hesitate to ask 😄

I want to contribute. Please assign me to this. Thanks!

Hey @engrleir, thank you for expressing your interest in contributing to this project, feel free to work on this issue.

Hi @rcode321, are you still working on this issue?

Hi sir is this issue still open? Can I try to help and contribute? Thanks

yes bro, sorry diko na nafollow up medyo busy kasi
On Wed, Nov 6, 2019, 10:03 AM Rodrigo Bonzerr S. Lopez <
<EMAIL_ADDRESS>wrote:

Hi sir is this issue still open? Can I try to help and contribute? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fccManila/fccmanila.github.io/issues/2?email_source=notifications&email_token=AG6BX3B5MH7LSLU43SJVH3TQSIQXXA5CNFSM4I5FHTYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDE7VVI#issuecomment-550107861,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG6BX3CJYPDRFGXVUS7PAMTQSIQXXANCNFSM4I5FHTYA
.

Still working on how I can make the wave css effect, looking for ways on how to use either SVG and Clip-path for the design

Hey @rodprogramdev, thank you for expressing your interest in contributing to this project, feel free to work on this issue. Looking good on the hero section, I think using SVG is much easier to use especially for responsive design.

Thanks sir, currently working on it as of now.

Hi sir I'm still working on the wave svg file and tried GIMP for making SVG, there was actually no supported format. Went to using INKSCAPE for the wave design. Still working on the size and still experimenting with how to use svg. Need to work on responsiveness when I get to learn how to apply the proper position.

Hi sir, this is actually my first time to contribute and still working on understanding the workflow. I've tried installing the NODEjs and Yarn into my machine and did some reading. Also made the repository for you to be able to view the progress. I'm not yet that familiar with building branches so I'll be working on it in my repository first. Thank you

https://rodprogramdev.github.io/fccManilaCreateHero/

No responsiveness yet, still working on the wave effect sir thanks

Hi sir here is the updated version still working on the break points

https://rodprogramdev.github.io/fccManilaCreateHero/

I just have a question sir, I'm still not familiar with the process of git in a collaborative environment. Still learning how to push the files to this repository. Can I ask for instructions on how to do it thank you.

Hey @rodprogramdev, I hope you are safe at these times. I know it's been a long time since I update regarding this issue but I would like to know if you're still interested in working on this issue? We can work on this issue so we can finish the project.

Thank you sir @jromest, doing fine still stuck in lockdown right now and continuing my studies in coding. I'm still interested to help out in building the project. What can I do to help out in the project?

I've reviewed your previous PR #34 regarding this issue, there's a lot of changes in styles. You can open a new PR for this issue and start from the start, I could provide you the SVG for the background. Also, make sure you pull the updates from the repo.

Copy sir, I just want to verify, I'm still not familiar that much with doing it correctly. I will be forking the repo, then try to create another Pull Request, then start installing yarn, then create a new createHero branch from where i can try to update and work on the createHero section. I'm working on doing this right now. Just need to familiarize myself on how to do pull request and push to the original branch.

Hi rod, i create a new PR, to create a Hero section @ fcc website. you can add additional features if you want. but i need a approval from @jromest if the branch/section i made is correct. 🙏 😄

I have already cloned the repo and then I'm triying to create a pull request right now sir. I'm wondering on whether I should do it from the fork repo or from the original repository the pull request? Thank you

Hi sir heres the update on the work that I'm trying to do right now.

Still working on the alignment for now of the images and need to adjust the wave effect based from the desired design.

Sir did you see the push for changes that I've done? Thanks

Copy sir, I just want to verify, I'm still not familiar that much with doing it correctly. I will be forking the repo, then try to create another Pull Request, then start installing yarn, then create a new createHero branch from where i can try to update and work on the createHero section. I'm working on doing this right now. Just need to familiarize myself on how to do pull request and push to the original branch.

What process of github or pull request you're having difficulty with?

@jromest Sir did you see the push for changes that I've done? I'm going to work on the responsiveness. Do we have any desired layout for the mobile and other devices that I can use as a reference? Thanks

With regards to your PR #38, please check the Files changed, there are no changes made.
As for now, we are only building for the desktop version, no mobile version or responsive design for now. Also, please refrain from using animations.
@rodprogramdev

@jromest Hi sir thanks, I've tried performing the pull request and created #40 and I removed the animation from the header. Should I also remove the animation from the button. I'm going to work on it right now.

Anyone still working on this?
I would like to contribute to this community project as well.
Can I? Thanks!

@genesisgabiola @rodprogramdev @jromest Hi guys! I just made a PR #46 about this issue and hoping to be merge.

The hero section is done via #46, closing this now.


@web3-onboard/walletconnect above 2.4.6 doesn't work

Current Behavior
Config:
   "next": "13.5.5",
    "@web3-onboard/coinbase": "^2.2.5",
    "@web3-onboard/core": "^2.21.1",
    "@web3-onboard/gnosis": "^2.2.0",
    "@web3-onboard/injected-wallets": "^2.10.6",
    "@web3-onboard/ledger": "^2.5.2",
    "@web3-onboard/react": "^2.8.12",
    "@web3-onboard/trezor": "^2.4.3",
    "@web3-onboard/walletconnect": "2.5.3",
    "@web3-onboard/web3auth": "^2.2.3",

const walletConnect = walletConnectModule({
  projectId: 'ourProjectId', // it's failing even with hardcoded string
  version: 2,
  dappUrl: 'ourUrl',
})

When running app locally everything works as expected. Once deployed to staging / prod environment projectId is missing in query as in example below and therefore it's impossible to connect a wallet.
https://explorer-api.walletconnect.com/w3m/v1/getDesktopListings?projectId=&sdkType=wcm&sdkVersion=js-2.6.2&page=1&entries=9&version=2

If we downgrade walletconnect package version to 2.4.6 everything works as expected.
Weirdly enough a request before request mentioned above contains project id and returns 200.
https://verify.walletconnect.org/ourProjectId
Expected Behavior
Wallet connection working on package version above 2.4.6
Steps To Reproduce
Use Next.js app. Prep config in the way described above. Deploy it somewhere and try to use wallet connect modal.
What package is effected by this issue?
@web3-onboard/walletconnect": "2.5.3
Is this a build or a runtime issue?
Runtime
Package Version
2.5.3
Node Version
18
What browsers are you seeing the problem on?
Chrome
Relevant log output
{"error":"Missing projectId query parameter"}

Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

@piekczyk can you provide a repo I can use/test with?


Update Triple-T/gradle-play-publisher

What
We should update gradle-play-publisher to version 3
Why
This will provide compatibility with the Android Gradle Build Tools 4.1. See #4088

Currently blocked by #4090


Rename sw-cli or split?

@addyosmani @jeffposnick
Given the number of conversations that have come up, do you think it would be worth seperating out the build of sw and file manifest from the sw-cli?

Makes it more natural to use const swBuild = require('sw-build') in build process
Breaks things up into smaller modules like the rest of sw-helpers
Means sw-cli can be freed up to do more (which generally I think is the direction everyone wants it to go in).

Thoughts?

We have spent a lot of time focused on the sw-cli use case, and I think you're right in suggesting that focusing on the smaller bits first would be a good approach forward.
If the smaller bits (primarily manifest generation) were cleanly exposed in a standalone fashion, I'd pair it with a bundling process and hopefully end up with a recipe for a complete build solution that I'm happy with. And then I'd probably be less concerned about how sw-cli scaffolding things out.

E.g. here's a hypothetical build process that seems reasonable to provide as a "recipe", and that I might use myself:
service-worker.js:
import manifest from './build/manifest'; // This will be generated as part of the rollup build
import SWLib from 'sw-lib'; // This gets pulled in from node_modules

SWLib.cacheRevisionedAssets(manifest);

// Other SWLib methods to configure runtime caching, etc.

rollup.config.js:
import resolve from 'rollup-plugin-node-resolve';
import swBuild from 'sw-build'; // Or whatever it's called.

swBuild({
  dest: './build/manifest.js',
  // other configuration options, similar to what's
  // supported in sw-precache today.
});

export default {
  entry: 'service-worker.js',
  dest: 'build/service-worker.js',
  format: 'iife',
  plugins: [resolve()]
};

It might make more sense to have that swBuild() step wrapped in a Rollup plugin, actually, rather than as code that runs as a "side-effect".
I think the Webpack usage would look similar, although in that case it might be a good idea to steer people towards creating a specific named entry for their service-worker.js, and then using a... loader(?) to make sure that the manifest was regenerated with the appropriate configuration? (My ignorance about Webpack best practices is showing.)

Sounds like you are on board, will add it to my todo-list for the CLI.

I think the Webpack usage would look similar, although in that case it might be a good idea to steer people towards creating a specific named entry for their service-worker.js, and then using a... loader(?) to make sure that the manifest was regenerated with the appropriate configuration? (My ignorance about Webpack best practices is showing.)

I've been noodling on how useful it would be for us to start fleshing out the Webpack plugin to accompany the new work. Given there are open questions about the regeneration and loading flow here, is this something we think is valuable to get done sooner rather than later to identify gaps or should it come after the beta milestone?

I think we are there in terms of something minimal that can be used for this.
The node-module can be used to build working SW and build manifest. The CLI can still generate the SW but needs the manifest being added in.
Please please please try out the node module when you get a chance.
Going to close this for now - please open new issues if there are more specific conerns, issues or . . . . anything else I've messed up in this process.


Gallery with mixed types, abstract version

hey,
I checked all issued that were somehow related with the mixed types, but none of the solution really worked for me.
I have gallery, where I want to put images or iframes. problem is when I open the popup gallery on the iframe I cant get to the next images, where are images, it acts like its frozen.
When I open the images and try to load the iframe, javascript tries for a while and then says it cannot load the image.
I am trying to reckognize the types based on the data attribute value I sent there from server, if the data-type="photo"  then type should be image, if data-type="iframe" then type should be iframe.
Code is below, any tips please?
function initGalleryPopup(parent){
if(typeof parent === 'undefined') parent = $('body');

parent.find('.zoom-gallery').each(function(){

	$(this).magnificPopup({
		delegate: 'a',
		type: 'image',
		closeOnContentClick: false,
		closeBtnInside: false,
		mainClass: 'mfp-with-zoom mfp-img-mobile',
		image: {
			verticalFit: true,
			titleSrc: function(item) {
				return item.el.find('img').attr('alt');
			}
		},
		gallery: {
			enabled: true
		},
		zoom: {
			enabled: true,
			duration: 300, // don't foget to change the duration also in CSS
			opener: function(element) {
				return element.find('img');
			}
		},
		callbacks: {

			elementParse: function(item) {

				if(item.type === 'iframe') {
					item.type = 'iframe';
				}
				else{
					item.type = 'image';
				}

			}
		}

	});

});

Hi, I'm having the same problem. @Bidrman did you solved it?

I've solved with a small change on your code. Instead of:
if(item.type === 'iframe') {

I've put:
if(item.el.data("type") === 'iframe') {

And it works fine.
Here is my full working code:
$(this).magnificPopup({
  delegate: 'a',
  mainClass: 'mfp-fade',
  gallery:{
    enabled: true,
  },
  callbacks: {
    elementParse: function(item) {
      if(item.el.data("type") === 'iframe') {
        item.type = 'iframe';
      }
      else{
        item.type = 'image';
      }
    }
  }
});


New datasets used for videochat2_mistral

Very happy to hear that you have updated the model with mistral LLM. Is there any place to find the newly added datasets? Thanks!

Good question! In the current version, only the smit is added. And we have updated the instruction data here.

Thanks for your reply! I noticed that some datasets like image caption -- coco has been reduced to a smaller size (100k). I'm curious about the reason and whether it is because the length of captions are relatively short? Thanks

OK, it's great to train faster with the same performance :)


Add tests for ParametrizedCurve

I added tests for the new ParametrizedCurve in Meshes.jl. I used a curve defined in Cartesian and one in Polar coordinates to test if different crs work as expected. I also added it to the support matrix and bumped the minimum compat version for Meshes.jl in the tests accordingly. Since I defined the curve to describe a 2D sphere for simplicity, this is also used as an analytical solution for the 2D Sphere (see #67).

Hm, downgrade complains because the tests need Meshes.jl v0.51.20 because this is the first version containing ParametrizedCurve, but the compat for Meshes.jl in MeshIntegrals.jl itself is 0.50, 0.51, thus allowing 0.50. But we don't need to bump the lower compat for Meshes.jl in MeshIntegrals.jl because ParametrizedCurve is never used in the source. I'm not sure how to deal with this problem.

Is it possible to make this test item on a separate environment with a specified minimum version?

Or maybe some kind of conditional statement on the installed version?

What we could is to define an environment variable in the CI setup, which is, e.g. equal to "part1" or "part2" and split up the tests into two parts. Let's say the new test item is in part2. Then we could run the Downgrade action only for part1 and all the other CI actions run on both "part1" and "part2".

This way we would also reduce the CI run time.

Or maybe some kind of conditional statement on the installed version?

This could maybe also work.

What we could is to define an environment variable in the CI setup, which is, e.g. equal to "part1" or "part2" and split up the tests into two parts. Let's say the new test item is in part2. Then we could run the Downgrade action only for part1 and all the other CI actions run on both "part1" and "part2".

Meshes.jl does something similar for Float32 and Float64 tests.

Or maybe some kind of conditional statement on the installed version?

This could maybe also work.

There is  pkgversion for that. This seems like a simple solution. Let's see if tests pass now.


Recursive flows

Is your feature request related to a problem? Please describe.
Inability to have recursion in flows.
Describe the solution you'd like
Ability to have a loop within the flow
Describe alternatives you've considered
Build recursion into a python node and complete all logic in that.
Additional context
Especially with the introduction of tool calling, and more "agent like" uses of OpenAI, it would be handy to be able to (based on logic), repeat a section of the flow.
e.g. Customer asks a question, search query is generated, request is made to docs, docs are reviewed, new search query is generated based off learning from the docs, docs are reviewed, then response is given to the customer (if AI is now happy with answer).

Hi @iceman3000 , we don't have plan to introduce recursion/loops in DAG flow since it's not easy to write it in YAML. But we'll introduce a flexible way to execute code script with prompt flow, where your can define orchestration logic with python code. Will that meet your need?

Hi @LastRemote , in my understanding, in we model above process as a flow, it can be implemented with flex mode:
def entry():
    while need_more_information(question, result):
        auto_selection_result = auto_select(question)
        exp_selection_result = explain_select(question)
        result = retrive(auto_selection_result, exp_selection_result)

Will this meet your requirements?

Hi @LastRemote , in my understanding, in we model above process as a flow, it can be implemented with flex mode:
def entry():
    while need_more_information(question, result):
        auto_selection_result = auto_select(question)
        exp_selection_result = explain_select(question)
        result = retrive(auto_selection_result, exp_selection_result)

Will this meet your requirements?

Could we please see a complete example of this - also a description of 'flex mode'?

Hi @LastRemote , in my understanding, in we model above process as a flow, it can be implemented with flex mode:
def entry():
    while need_more_information(question, result):
        auto_selection_result = auto_select(question)
        exp_selection_result = explain_select(question)
        result = retrive(auto_selection_result, exp_selection_result)

Will this meet your requirements?

Could we please see a complete example of this - also a description of 'flex mode'?

Hi @ElliotWood , flex mode is a mode we're working on to directly execute code script with prompt flow with tracing ability. The code script will be provided by user so user can run complex orchestration logic in it. (e.g. the while loop in above example). Since it's still working in progress, we currently don't have examples/docs about it. I'll update here when it's publicly available.


responsivness: design for mobile

@bioshrimp suggests:

having pictures seperately under text and crop it to a smaller size
then the texts don't need to have the white frame
texts and profile pictures should be centered
somehow the app doesn't yet adapt to the current screen size

check out: smaller spacing of text, smaller pictures (text should fit into picture)

examples:

http://hem.com/de/
https://www.airbnb.de/
http://www.fitbit.com/de/home

The navbar isn't scrollable in the mobile version.

@bioshrimp can we work with you on that? Maybe just with the Marie Curie picture and delete the other?

@tyranja sorry, didn't see this til now. sure!
I am not sure I understand correctly what you are asking though, are you at the monstas tomorrow? :)

@bioshrimp I think we wanted to have a more sophisticated solution for the pictures and the overlaying headlines in the mobile version. You added the examples above as models. Right now in the mobile version only a cutting of the picture is shown. I think you mentioned (somwhere in the past) to have a smaller picture and display the headline below the picture.

Looks like this is done with getting back to bootstrap


[feat] Configuring request header before specifying the method

Configuring request header before specifying the method, or creating agent instances that keep memory of what we configured him with.
How I would like Superagent to be:
const superagent = require('superagent')

const agent = superagent(app).createAgent()

agent.set({
    accessToken: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c',
    refreshToken: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c'
})

agent.get('/currentUser')

Checklist

[X] I have searched through GitHub issues for similar issues.
[X] I have completely read through the README and documentation.

i belive you can do something like this:
const superagent = require('superagent')

const request = superagent
  .agent(app)
  .set({ Accept: 'applicaion/json', 'x-custom': 'custom' });

const response = await request.get('/my/url');


Conflict with Laravel Nova

I'm using SSR for a SPA with React and Laravel for backend. I'm using a default layout for all pages that I added in createInertiaApp in app.jsx and ssr.jsx. I'm using Laravel Nova for content management, the problem is SSR is giving me an error everytime I enter in Laravel Nova. I know Laravel Nova uses Inertia as well, but it shouldn't conflict with my project. The error that is giving me:
TypeError: Cannot read properties of undefined (reading 'default')
    at resolve (file:///var/www/html/bootstrap/ssr/ssr.mjs:3077:13)
    at f (file:///var/www/html/node_modules/@inertiajs/react/dist/index.esm.js:1:1512)
    at U (file:///var/www/html/node_modules/@inertiajs/react/dist/index.esm.js:1:1553)
    at file:///var/www/html/bootstrap/ssr/ssr.mjs:3047:13
    at /render (file:///var/www/html/node_modules/@inertiajs/core/dist/server.esm.js:1:295)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Server.<anonymous> (file:///var/www/html/node_modules/@inertiajs/core/dist/server.esm.js:1:527)

This line is where I have
page.default.layout =
                    page.default.layout ||
                    ((page) => <Layout children={page} />);

Have this happened to someone? I don't know why Laravel Nova is using my createInertiaApp.

This is because Nova is essentially a different app, they have different build files etc. So instead of using Inertia to navigate to it you'd just use a normal anchor tag

The error is in the SSR daemon, running with php artisan inertia:start-ssr. It occurs every time someone goes to the backoffice, I don't have any link from the website to Laravel Nova.

i'm having the same problem

The error is in the SSR daemon, running with php artisan inertia:start-ssr. It occurs every time someone goes to the backoffice, I don't have any link from the website to Laravel Nova.

Temporarily I'm checking if the page exists, and if not, I added an empty page.
let page = pages[`./Pages/${name}.jsx`];
if (!page) {
   page = pages[`./Pages/Empty.jsx`];
}

We have solved it like this, just add a reference to this middleware right before HandleInertiaRequests::class in nova.php's middleware.web section
<?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Http\Request;

/**
 * The purpose of this middleware is to disable Inertia SSR for Nova, while keeping it enabled for the rest of the app
 * The middleware needs to be registered in config/nova.php for Nova web routes
 */
class DisableInertiaSSRForNovaMiddleware
{
    public function handle(Request $request, Closure $next)
    {
        config()->set('inertia.ssr.enabled', false);

        return $next($request);
    }
}

Hey folks! Yup this is a known issue with Nova. Since Nova is built with Inertia.js, when you're running the Inertia SSR server and hit a Nova endpoint, the SSR server tries to render that page but fails, since Nova isn't setup for SSR (and it doesn't make any sense for it to be).
The way I have handled this in a project of mine that uses Inertia.js and Nova is by adding the following snippet to my AppServerProvider:
if (Request::is('nova/*')) {
    Config::set('inertia.ssr.enabled', false);
}

This will disable SSR just for the Nova endpoints and prevent this issue.
I've been meaning to ask the fine Nova folks to add this to Nova directly, and this is a good reminder to do that. (Pinging @jessarcher for help on this 😄 )
Going to close this issue in the meantime since it's not something that we're even able to fix in this library.
Hope that helps! 🤙


add support for 'packages.conda' section hotfixing

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thank you for the PR! I think I know a way to improve the diff. I'm nervous to merge now since it is hard to verify.

OK @msarahan. That diff is a lot better!
Can you double check I didn't mess anything up?

great idea on reducing the diff. A good way to test this is to ask Anaconda to convert a few files that you know will undergo some kind of patching if things here work correctly. Once they convert any files, the packages.conda section should show up the next time they run conda index. Perhaps also throw in a few other packages that don't need patching, just for reference.
Once you have conda-forge's repodata.json with at least a few entries in packages.conda, you should be able to simply build this package and verify that the patch files contained within have the expected patch instructions.

It turns out our show_diff.py script is calling the right indexing functions from conda build locally. Thus I have enables that test after fixing the script. It passed locally and so we should be good to merge.
I am going to wait until Monday to merge to ensure that if anything fails upstream, someone is around to help fix it.


2x Batch Size Unet

nsmith/unet_test_perf2_groups
The above branch is just a work in progress, but the goal is to construct the same unet model with 2x the channels throughout the whole model.  This should give us an upperbound on what the potential speedup would be if we implemented these as grouped convs.
Things to try:

Pre-allocating the output tensor for the first conv layer to avoid fragmentation
Spilling the skip connects to DRAM (potential slow-down) to make room for more batch

This has been done and is in main as of 34cdda58b2f6d678ecae62a5986862998c83c4e2


NZBGetPostProcess.py - Calling wrong Directory

The NZBGetPostProcess.py script doesn't work as provided. The following four substitutions must be made if you want to direct the output anywhere except inside the scripts folder:
On line 62:
REPLACE: NZBPO_MP4_FOLDER
WITH THIS: NZBPO_OUTPUT_DIR
On lines 63, 64, 65:
REPLACE: MP4folder
WITH THIS: output_dir
The resulting block of code from line 58 to line 68 should look like this:
output_dir = None
if 'NZBPO_OUTPUT_DIR' in os.environ:
    output_dir = os.environ['NZBPO_OUTPUT_DIR'].strip()
    if len(output_dir) > 0:
        output_dir = os.environ['NZBPO_OUTPUT_DIR'].strip()
        output_dir = output_dir.replace('"', '')
        output_dir = output_dir.replace("'", "")
        output_dir = output_dir.replace("\\", "/")
        if not(output_dir.endswith("/")):
            output_dir += "/"
        #DEBUG#print Overriding output directory
Please update as appropriate... and thanks for your efforts!

Good catch! Fixed this, thanks


⚠ Bofrost.de has degraded performance

In 212f015, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1440 ms

Resolved: Bofrost.de performance has improved in 58aa4ca after 51 minutes.


[Staking] Add fields for tracking node info ownership

Context
Definition of Done
Tests Required

Context
Definition of Done
Tests Required


JQuery errors

Regardless of how I install it (release or git repo), it throws this error immediately on login
Uncaught TypeError: Cannot read properties of undefined (reading 'Constructor')
    at machine.min.js:1:11276

And when I try to add a "provider" since I need it for the "machine", I get a bunch of these erroors
Uncaught ReferenceError: url is not defined
    at HTMLDocument.<anonymous> (machine.min.js:1:11065)
    at e (jquery.min.js:2:27028)
    at t (jquery.min.js:2:27330)

Looks like a bug
Installed on PHP 8.2x

@seikan Can you help me here please?

@seikan Can you help me here please?

I tried running on a different machine and this time it is working fine, therefore it is no longer an issue for me


Remove pydantic_reset_parent_namespace=False in create_model

Change Summary
Checking if this passes in CI since it passes locally.
Related issue number
Closes https://github.com/pydantic/pydantic/issues/7953 (maybe)
Checklist

[ ] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@alexmojaki, did you mean to leave this in draft state?

Yes, this was an experiment which was meant to lead to further discussion, perhaps on the issue. I don't know why this line was there and what the other consequences of removing it might be.

Closing in favor of https://github.com/pydantic/pydantic/pull/8378 👍


[stable/kiam] Add pre-deprecation notice

What this PR does / why we need it:
Pre-deprecation notice for the kiam chart.
See https://github.com/helm/charts/issues/16664.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
~[ ] Variables are documented in the README.md~
[x] Title of the PR starts with chart name (e.g. [stable/chart])

@davidkarlsen @lachie83 Any chance of getting this reviewed?
Thanks.

/ok-to-test

/lgtm


workaround travis CI docker version issue

The pypi docker package was recently updated to 4.3.  This version
uses docker api version 1.39.  The docker daemon used by travis
CI uses docker api version 1.38.  We have to use a version of the
pypi docker package less than 4.3 with travis CI currently.
The .travis/runtox script is used to run tox in the travis CI
environment.  Change this script to look for the docker server api
version and set LSR_MOLECULE_DOCKER_VERSION appropriately so that
tox.ini will install the correct version of the pypi docker package.

LGTM


Add auto-acceptance to present-proof protocol

Basically the same as #60 and #116 but for proofs.
Checklist:

add option to enable / disable auto-accept of proofs

[ ] in agent config
[ ]  to credential record
[ ]  to credential service methods
[ ]  to credential module methods

@blu3beri

Yes, will pick this up!


Value of baseURL in CMIP6_grids.json needs updating/removing

The value of
"baseURL": "http://cmip-pcmdi.llnl.gov/CMIP6/dataLocation",

Found here
Points to a non-existent URL, when the URL remapping is finalised on the 20th March 2017 it would be worthwhile changing this, or removing the spurious entry
@taylor13 @dnadeau4 @sashakames we need to discuss this

That is old metadata from cmor2.  I removed it in all other tables and we decided that having a broken link in every file was not worth it.  As you can see CMIP6_grids.json is a hack from CMIP5 tables. :smirk:

@dnadeau4 well time that it also gets scrubbed from the CMIP6_grids.json then too?

Done!  Will be in the next version of the tables...

@dnadeau4 wanna link this to the PR that solves the issue and then close?

PR: https://github.com/PCMDI/cmip6-cmor-tables/pull/51


More refined enhancements for Apple campaign

Remove the 1001x300 size for the leaderboard slot since that's not what we're targeting.  Also making the MPU ad on the side rail have the same bgcolor as the body so that when it is set to 1x1, it's not obtrusive by having a different background color.

Looks good.


Fixed IQAE bug mentioned in issue 9280

Summary
Reopening a PR due to account conflicts present in PR #9289.
Details and comments
Fixed the bug mentioned in issue #9280, and added more tests to increase robustness for phase estimation algorithms.

Hi @woodsp-ibm, I reopened a new PR with the same changes here since there were some issues in the history of PR #9289 that seemed challenging to resolve.

LGTM but @jlapeyre could you also have a look? 🙂

@shifubear Thanks for sticking with this through the administrative difficulty.
It looks fine to me. You may want to consider doing this instead
        qubits = [unitary.num_qubits]
        qubits.extend(range(0, unitary.num_qubits))
        qc = qc.compose(unitary_power, qubits)

This is a significantly faster way to construct the list. In general, I advocate using an idiomatic best way to write something. In part because the code serves as a model for further development. Which way to write it is best?

extend is faster in this case
The increase in performance won't matter in this function, because surrounding code is much slower. But it's good to habitually use the best choice. But it's not clear this is the best choice because...
+ is more readable and easily understandable in this case.

Unfortunately, extend returns None rather than the list. If it did return the list, then you could write
qc = qc.compose(unitary_power, [unitary.num_qubits].extend(range(0, unitary.num_qubits)))

and you'd have something that is both faster and no less readable. But alas this is not the case.
On balance, I favor the code as you have written in, with +, because the readability outweighs the performance. Do you have an opinion @Cryoris ?

@jlapeyre Of course! Wanted to contribute so I'm glad there was a workaround.
I prefer optimizing for readability in this instance, especially since the surrounding code is much slower as you mentioned. Also, my intuition is that the length of the qubits list will not be long enough for there to be a significant performance difference in the near future.
With that said though, I was unaware of the extend method so I will keep note of that for future PRs!

I don't think there is a conceivable scenario where the performance of this line would matter in this method.

Hi @jlapeyre, I added the suggested changes on the release notes!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
118 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.05%) to 85.351%

Files with Coverage Reduction
New Missed Lines
%

qiskit/primitives/backend_estimator.py
1
95.37%

qiskit/primitives/backend_sampler.py
1
97.73%

qiskit/pulse/utils.py
2
94.29%

qiskit/transpiler/preset_passmanagers/level3.py
5
92.5%

qiskit/circuit/library/standard_gates/multi_control_rotation_gates.py
10
93.38%

qiskit/circuit/quantumcircuitdata.py
12
88.18%

qiskit/transpiler/passmanager.py
12
93.68%

qiskit/test/base.py
18
84.03%

qiskit/circuit/quantumcircuit.py
57
94.17%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
67114

Relevant Lines:
78633

💛  - Coveralls


Week 1 and week 2 updated

Project
Beckn Mobility Platform
Changes
Updated week 1 and week 2 updates

@Shruti3004 please can you review my pr


Can't get the results in the paper or the results of the pre-trained model provided

I configured two different environments according to environment.yml and requirements.txt. Even if the seed is fixed, the training results in these two environments are inconsistent. why is that? And I still can't get the results in the paper or the results of the pre-trained model provided. Is this normal?

First, the environments installed from the environment.yml and the requirements.txt are different. It's to help everyone run our model on different machines. For example, the pytorch versions are different. Version differences would affect the processed dataset and inference performance slightly.
Second, I need to see your results to check if it's acceptable.


i18n(ko-KR): update testing.mdx

Description (required)

update testing.mdx
#8369

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
guides/testing.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Python required version minimum

Since the main use of this library is for HA and that runs Python 3.12 as of this week, are we able to reduce the Python required version minimum? If we move up to 3.10 or 3.11 we can take advantage of some of the newer features, and I don't know if there would be any downside to it.
@abmantis Thoughts? I'm not sure if there are more users or use cases that I'm not aware of for this library

Yep, we can move up! If HA is now on 3.12, we can bump to 3.12.


lodash: added _.gt(), _.gte(), _.lt() and _.lte() methods

https://lodash.com/docs#gt
https://lodash.com/docs#gte
https://lodash.com/docs#lt
https://lodash.com/docs#lte

@chrootsu thanks mate!


scss_formatter_compressed doesn't strip CSS comments

When you use the scss_formatter_compressed flag, scss comments are stripped (the // type), but regular CSS comments ( /**/ style) are left in the CSS.
From what I understand this is expected SASS behavior. But when you compress the CSS output, shouldn't it be as small as possible?

Thanks


value-based equality should cover non-enumerable and symbol properties

The current value-based equality check done by Ramda (across the board) interacts badly with one of those "best practices" of OO in JS, which is to make private properties non-enumerable, or, in es6 environment, be set as symbols.
non-enumerable property problem demo: http://bit.ly/1UR0Bhc
symbol property problem demo: http://bit.ly/1Oqc6wd
I really do like value-based equality, and I also acknowledge that supporting OOP code in general is not the main focus of Ramda. I also acknowledge that there are probably some cases involving js closures (and/or WeakMaps tricks) which are simply unfixable, and also that the common implementations of deepEqual are affected by the very same issue.
However, I believe this issue is going to surprise a lot of people, esp. when dealing with 3rd party objects - e.g. running uniq on  an array of C objects (see demos) is always going to returns just the first element. If you're dealing with your own library and know ramda quite well, the option of dispatching is a fine workaround, but when dealing with third party libraries, more often than not you're out of luck. Given ES6 classes syntax (implement in current chromium nightlies and soon in Fx) along with upcoming ES7 decorators, symbols/non-enumerable properties as "privatizing" mechanism is going to spread out a lot, rendering this issue quite severe. Given all that, my hunch would be that the deep equality check should also take non-enumerable properties and symbol properties into account (I'd not do that for isEmpty though...). Indeed, there's a trade-of here, because it'd break the current equality check in some cases (moment.js for example... I don't remember the details).

Something I've been considering for a while is checking a.constructor === b.constructor (or a.constructor.name === b.constructor.name) when comparing a and b. A Foo instance with no enumerable properties is not equivalent to a Bar instance with no enumerable properties.

Indeed, but note that's a different use case. Here the constructor is the same.
BTW, Function.name is still missing from IE, so it's better to use getPrototypeOf for that.

BTW, toString is also affected by this issue. I'd not care about that if memoize wasn't relying on it.

The current value-based equality check done by Ramda (across the board) interacts badly with one of those "best practices" of OO in JS, which is to make private properties non-enumerable, or, in es6 environment, be set as symbols. [...] I really do like value-based equality, and I also acknowledge that supporting OOP code in general is not the main focus of Ramda. I also acknowledge that there are probably some cases involving js closures (and/or WeakMaps tricks) which are simply unfixable...

It's the latter that worries me.  OO is done in JS in so many ways.  Perhaps ES6 will eventually bring about some consistency, but I'm not particularly hopeful.  Here's a simple case that I don't think we could ever solve:
function Rectangle(w, h, s) {
  var scale = arguments.length > 2 ? s : 1;
  this.width = w;
  this.height = h;
  this.area = function() {return this.width * this.height * scale;}
}

var r1 = new Rectangle(5, 3, 1.0);
var r2 = new Rectangle(5, 3, 1.1);
R.equals(r1, r2);  // true
R.equals(r1.area(), r2.area()); // false

If we can't solve some of the fundamental forms of OO, I'm suspicious of the project of trying to capture other ones.  I think we'll end up ever chasing an elusive, and finally impossible, goal.
I like the dispatching approach, which allows the user to determine how equals applies to her class of objects.
So, while I'm curious to hear further discussion, my first thought is negative.

I'm not suggesting to solve all those cases. As I said, I'm worried about "best practices" being broken. non-enumerable property is the closest thing to a private member property, and many good libraries use it this way. Symbols are first-class citizens in ES6 that Ramda simply ignores (even though there's a way to get them). With babel.js and typescript rapidly popularizing ES6 classes and decorators, very self-descriptive code that doesn't look hackish like the above at all is now broken. I think that a complete solution here involves updating the documentation of equals to make its limitations clear and to promote the dispatching workaround there (And also note that you don't really want to dispatch to equals without also overriding toString because then funny things happen).
I think it's possible to draw a border line between the cases we want to solve and the cases we don't. Getters vs. methods is an easy one, imo: your example is basically a non-getter getter, which, without AI, ramda cannot distinguish from normal methods. However, t should always be fine for ramda to invoke getters, so you'd have caught that if area was defined as a getter. If someone breaks the getter "contract" (foo.initialized;  // initialize the object) then there's nothing we can do.

Just to make it clear, I'm not actually opposed to updating equals to take into account non-enumerable properties and symbols.  While not 100% certain, my first impression is that it would be a good idea.
What I'm worried about it trying to chase down the OO technique of the month.  What you're calling "best practices", a second developer might find horrible, and might never even occur to a third one.  Yes, the new syntax from ES6 may in time help settle this debate, but at the moment it's far from clear that it's true.  My example was not about the area function; it was about the actual piece of data that distinguishes the two values, the scale closure property.  This is not at all an unusual way to deal with concerns for privacy in OO code, and nothing we do can overcome that.  But the developer of the OO system might well be able to do so, which is why my answer to OO-specific questions for such functions is delegation.
But to the main point, expanding equals to include non-enumerable properties and symbols, my vote is a tentative yes.

OK, I updated the summary to reflect the part we can agree on. I think this is good enough.
But regarding the area function, I think I made my point poorly. Let's view it from a different POV. Given the follow class:

class Foo {
   constructor()
   {
       this.publicFieldFromCtor = null;
   }
   get getterA() {
     ...
   }

   get getterB()
   {

   }

   publicES7Field = 3;

   functionThatIsActuallyAGetter()
   {
      ....
   }
}

JS internals and prototype-OO quirks aside, I think that it's very intuitive for a default equals implementation, esp. one that is done "from the outside" (the way ramda does) to compare getterA, getterB and marginally less the the two public fields. Intuitive as it is, it's very hard to implement because the two getters are not set as properties of instances of this class, while the "fields" are. The getters are always at least one level up in the prototype chain. Even worse, in ES6 classes the are marked as non-enumerable. So while the "contract" parts of the class (i.e. the getters) is, at least to me, the most obvious candidate for an equality check, they are the hardest to get right without getting a lot of noise and hurting performance quite a bit (by walking the prototype chain). functionThatIsActuallyAGetter (the analogy to area) is an interesting problem, but there's nothing we can do about it, so let's leave it out of this discussion.
So what Ramda assumes (with or without the suggested fix), in par with may other deep equality implementations, in its equals implementation, is that if it covers an object's own properties, it'll, most of the time also cover what matters. Given all considerations, I think this is approach is fine, but it does mean you've to take private-ish fields into account. Otherwise you're very likely to miss the public getters much more often.

I do think that we'll have to think very carefully before deciding to tread here.  I worry about the number of crazy edge cases there are to consider.

BTW, I'm not sure what R.clone does exactly, but it seems that it gets what I described in my previous comment quite nicely (symbols aside)... it flattens the getters from the prototype chain.
The equality check that returned true (wrongly) returns false for clones
http://bit.ly/1iM224w
Interesting and terrible at the same time :)

I would like to point out that many Ramda functions use equals. If we make equals slower many other functions will be slower as well.

Indeed, but see #1386. I think most, if not all, all of the not-O(n) cases could be addressed this way.


Fixed some spacing issues with paragraphs and headings

Some naming conventions were changed so @rnetro and I went through some of the CSS to normalize names and spacings and other good shtuff ( ° ͜ʖ °)

closing in favor of #137