Add secured etcd support

Related to #21.

@kvaps Is this one OK ?

Yeah, totally fine, I'm going to test and merge it soon

I had to add helm annotations to db tls secret.
My goal is to build kube-linstor component for Lokomotive. If I try to reinstall, I have this message : "rendered manifests contain a resource that already exists. Unable to continue with install: Secret "linstor-db-tls" in namespace "linstor" exists and cannot be imported into the current release: invalid ownership metadata"

Wouldn't simple delete of resource solve that?

Wouldn't simple delete of resource solve that?

Not automatically but it is not a real issue.

Oups it seems there is no commit for this....

@jbanety it seems you pushed changes from https://github.com/kvaps/kube-linstor/pull/25 into your master branch and broke this PR by this fact. Could you use git reflog to find correct hash and prepare the new one?

Yop. It was on the master branch which was a bad choice !


envoy: Bump envoy to 1.23.4

Description
This is as part of BAU activitity to upgrade envoy version, so that we don't rush into any potential EOL. Not to mention that some of useful envoy features (e.g. internal listener) are only available in later versions.
Testing
Testing was done locally for Gateway API and L7 policies via connectivity test.

/test

/test-1.16-4.9

/ci-verifier

/test

/test

/test

/test

/test

/test-1.16-4.19

test-runtime hits https://github.com/cilium/cilium/issues/22373

/test-runtime

Reviews from required teams are in, all CI jobs are successfully run. ci-verifier is not required due to the changes here.
Mark this ready to merge.


JSX breaks highlighting

JSX is supported by Vue https://vuejs.org/v2/guide/render-function.html

Please take a look at the section about JSX in the README


Waterbirds update

updated localities

Updated so that:
localities_centroid_coordinates.csv

File names remain the same
Delimiter remains the same (,)
Column names remain the same (removing isStandardizedLocationWV, RegioWVNaam, WKT)
1200 vs 1077 lines
The main difference are less decimals in the centroid coordinates

localities.geojson

File name remains the same
Columns names rename the same
1200 vs 1077 lines
Reducing the precision of the shape coordinates from 16 to the original 6 decimals, which reduces file size.


Is the project still maintained?

Hello,
Just wanted to ask @drymek @rkostrzewski @adamrapala @Lukasz-pluszczewski @adam-golab @szymonbrainhub @damian-szulc @matthew-the-equine if the project is still maintained, as it does not seem there is a lot of activity from August 2020...
Also it seems that most repos @brainhubeu looks inactive from around that moment.
Thank you!!

Hi, sorry for the delay, we have a really busy time.
Yes, we will look into issues and PRs as soon as possible. Sorry once again for inconvenience.


Include config fields for memory use calculation

Added GetSize methods to the various config classes related to the derived asset/assetversion objects.
Added GetSize method to derived asset/assetversion class to account for previous missed members.
Updated memory use calculation to utilize new GetSize methods.
Updated existing GetSize methods to account for padding.

I want to do a more thorough review, but on a first pass the code seems reasonable. I have a couple of general thoughts:

There's no obvious difference between the names GetSize and GetObjectSize. To make things worse, one of them calls sizeof(*this) and the other doesn't. I think the code would be clearer if you renamed one or both of them to make the difference clear. So maybe GetSize stays the same and GetObjectSize becomes GetHeapUsage to indicate that it only counts what's dynamically allocated (i.e., on the heap). Also, if there are cases where GetObjectSize includes sizeof(*this) and cases where it doesn't, that's extra confusing and we need to clean that up, maybe with a third function name.
Along the same lines, it bugs me that in some cases you have to call object.GetSize() and in other cases you call GetObjectSize(object) to get the size of the object. I'd like to be able to call the same function for everything.
I know this is a bit late, but I think in the AssetGen*.pl files (or maybe khidl.pl, I don't remember which) you have access to a list of member variables defined in the config file and their types. You could use that information to auto-generate the GetSize functions, which could save you from modifying every one of these files. Since you've already made the changes I'm not sure that helps, but it may be worth looking into because it could make future development easier.

Except for the one missed initialization in khCache I'm ready to approve. Everything looks solid.
Keep in mind that I didn't run any tests. We still need to make sure that the reported cache size is reasonable compared to the actual memory usage and it would be a good idea to characterize the performance cost of calculating cache sizes.

Oh, and as usual, I forgot that we should include a note in the release notes about how the cache size calculation was improved.


Fix logout

Check what is happening at the backend for the /logout endpoint and implement a fix

Here is what I'm sending from the front end:
{
    token: "WyJrcmlzdG84MDhAZ21haWwuY29tIiwiM2RiOTIyNTUzZjYxZjY1YjIzYjUyNzRjYjM4ZjMzN2UiXQ.Da66gQ.uxCa1X2_x8f_WmRJIk5geDuuS-A",
}


Not compatible with Node 8

Prerequisites

Node 8.5.0
Don't use transpiler like Babel

Description
I am building a frontend boilerplate project where the main frameworks are mocha and webpack using Node8. Webpack 4 is working fine with Node 8 without any intervention of transpiler tools like babel. However, Mocha does not.
Steps to Reproduce

Switch to Node 8

nvm install 8.5.0 && nvm use 8.5.0

Write a unit-test case compatible with Node 8 (includes import keyword) :

import Component from './App.component.js';

describe('App component', () => {
  it('is named App', () => {
    expect(Component.component).toEqual('app')
  })
})

Run unit-tests using mocha

mocha --watch $(find  src -name '*.spec.js')

Actual Seeing a message in the STDERR:
(function (exports, require, module, __filename, __dirname) { import Component from './App.component.js';
                                                              ^^^^^^

SyntaxError: Unexpected token import
    at new Script (vm.js:51:7)
    at createScript (vm.js:138:10)
    at Object.runInThisContext (vm.js:199:10)
    at Module._compile (module.js:624:28)
    at Object.Module._extensions..js (module.js:671:10)
    at Module.load (module.js:573:32)
    at tryModuleLoad (module.js:513:12)
    at Function.Module._load (module.js:505:3)
    at Module.require (module.js:604:17)
    at require (internal/module.js:11:18)

Versions

The output of mocha --version and node node_modules/.bin/mocha --version:  5.0.5
The output of node --version:  v8.5.0
The version and architecture of your operating system: Darwin MacBook-Pro.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64
Your shell (bash, zsh, PowerShell, cmd, etc.): zsh
Your browser and version (if running browser tests):
Any other third party Mocha related modules (with versions):
The code transpiler being used: No and we require to not use it, but rather leverage Node 8 features ( import, export, async, await and so on)

Additional Information
No additional info.

The answer as of this writing is to use node --experimental-modules path/to/_mocha <whatever>


[tests-only] Bump core commit id for API tests

To run TUS tests for uploading to share, see https://github.com/owncloud/core/pull/38150

Note: this is a later core commit than the one in #1344
If this PR passes, then I will close #1344


Empty app build fails on ios

On android it works.
It fails on ios with blank screen and with this message:
test[68142:1449022] Resetting plugins due to page load.
I then debugged js with this in script tag:
      <script type="text/javascript">
      window.onerror = function (errorMsg, url, lineNumber) {
           alert('Error: ' + errorMsg + ' Script: ' + url + ' Line: ' + lineNumber);
      }
        @@appManifest
        quasar.boot(function() {
          quasar.start.app();
        });
      </script>

and got this alert:
Error: Error: Cannot load page. Script: undefined Line: 26

Looking into it on Mondays.

Can you tell me pls:

Xcode version are you using
Mac OS version
Phone OS version
Cordova version

Thanks!

Here it is:

Xcode - 7.2
Mac OS - Yosemite 10.10.5
Phone OS - 9.2 from simulator
Cordova - 6.2.0

Huh, the build is using cordova 4.1.1, this is log form xcode - Apache Cordova native platform version 4.1.1 is starting
cordova -v outputs 6.2.0, it was installed via npm.

Delete the wrapper folder and quasar wrap it again.
It may be that you were using Cordova 4.1.1 when making the wrapper then you've upgraded Cordova to 6.2.0. Common issue when using Cordova. Are you in that situation as well?
Tell me if making wrapper again with the new version solves the issue. It may not, because I saw the same error reported for Cordova on Stackoverflow in many cases. Anyways, I'll get to the bottom of it.

I removed cordova from the system via npm, wrap command complained with this which is ok:
You need Cordova globally installed (npm install -g cordova).
Then I installed it, 6.2.0 was downloaded but 'quasar wrap platform add ios' is somehow still using 4.1.1:
Adding ios project...
iOS project created with<EMAIL_ADDRESS>Installing "cordova-plugin-crosswalk-webview" for ios
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project
Fetching plugin "cordova-plugin-whitelist@1" via npm
Installing "cordova-plugin-whitelist" for ios
How to resolve this?
Thank you.

quasar wrap issues amongst other things cordova create <folder> command (in this case the folder is wrapper).
Try to create a Cordova project outside of your Quasar App folder (cordova create test-folder) and see if it installs cordova-ios 4.1.1. I would expect this to be the case, although latest cordova-ios version is 4.2.0. Trying to make sure Quasar CLI is not at fault here. Then we'll see what to do next.

I am sorry, I misread the name<EMAIL_ADDRESS>is not same as cordova 6.2.0 :)
Yes, the result is the same when using cordova without quasar CLI:
Adding ios project...
iOS project created with<EMAIL_ADDRESS>Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project
Fetching plugin "cordova-plugin-whitelist@1" via npm
Installing "cordova-plugin-whitelist" for ios

Currently installing OS X El Capitan on a virtualbox so I can dug in deeper. Can you tell me if running the default Cordova App (so the folder created earlier outside of Quasar folder) issues the same error when run in the simulator? Thanks!

Default cordova app works.

Reproduced the issue. Investigating and fixing.

Fix will be available in v0.4.1

Released v0.4.1 containing the fix.


Update add-password-reset-policy.md

Change "Password rest flow" to "Password reset flow"

@rbrayb : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks for the fix. Merging in the repo is paused; this PR is in the queue to merge when merging resumes. Thanks.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Resolved merge conflict


 Specifically, it:

Turns on Go Modules and removes support for dep.
Creates new shell scripts for handling code and manifest generation to workaround Go Modules with Kubernetes code generation tools. See: https://github.com/heptio/contour/pull/1010 for inspiration.
Introduces tools.go to represent binary tool dependencies with Go Modules and bind them to a semver. This is behind a build flag so that they are never compiled in. See: https://github.com/go-modules-by-example/index/blob/ac9bf72/010_tools/README.md for this method. (this addresses @runyontr's concern about tool versioning)
Updates README.md and CONTRIBUTING_GUIDELINES.md with this new information.
Make staticcheck happy by removing some unused test bootstrapping functions.
Adds module and binary caching to CircleCI. On a ~2-4 minute build, this reduces build times to ~1 assuming no dependencies have changed.
Streamlines the Makefile and removes explicit calls to generate and manifest during test, install, and run. This code should only change when APIs are changed, and are now covered in the Contributing Guidelines.
Kicks vendor/ to the curb by putting it in .gitignore.
Breaks your browser on reviewing files changed.

There's a few other static analysis tools I'd like to add around spelling, ineffectual assignments, etc., but we can separate that into another PR.
After this branch is merged, we should go through and delete all old, unused branches (except dynamic-crds as that is being re-written). There's no chance that code can reasonably merge being so far from master anyway. Additionally, this probably causes some merge conflicts with #166 - sorry @fabianbaier. Probably never a good time to rip this particular bandaid off.
There wasn't really a smaller way to make this PR happen. There's enough infrastructure changes that my additional little changes around the Makefile are incidental. They're also really helpful with speed given how we need to generate code now. Generating on every make task was slow already and IMO hinders a smooth development cycle.
BTW - if you have problems testing this, kill your existing package cache (rm -rf $GOPATH/pkg/) and try again. There seems to be a caching issue when having the same dependencies pulled by dep and modules. Not sure what the issue was there, but could not reproduce after removing that package cache. On a fresh clone with other projects in my $GOPATH this doesn't seem to be an issue.

there is an issue with having make test as part of the CI.
If rate limits are going to cause tests to fail... I don't want them to stop a PR build... however I would really rather have tests in CI :)

We should have tests in CI for sure. We need to really talk about removing our reliance on the Github API for day-to-day use anyway.
I'll hold it out for now, let's talk about this all live tomorrow to figure out a resolution.

@fabianbaier Go Modules does not use vendor/ and using GOPROXY is the encouraged form of module caching going forward.

oh, I'll update that in Slack.


fix format error

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):
docs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

fix docs format
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

I have read the CLA Document and I hereby sign the CLA

recheck

@zwpaper Hi there! Thank you for your contribution! LGTM!


Decrease knowhere threads scheduling priority

Force threads used by knowhere thread pool to be scheduled using FIFO and lowest priority, so that knowhere won't consume all cpu cycles and stall other threads.
Note that these changes will be effective only if ran by root. Running codes in this PR with non-root privilege will silently fail and will not crash the program.

/kind improvement


feature: Make only the latest 5 repos removed from the cart show under the add again section(currently not limited to five).

On the fence if this a useful addition. Our new soft limit is "3" repos per page. Sharing a screenshot for reference, but would like more context on this before we work on this. I have not gotten this feedback from any users.

This is so specific for an opensauced engineer, that I don't it is needed. If this comes up again from a user then we can re-opened.


Fix example build error: added missing header

memcpy requires #incude <cstring>

Thanks for fix it! Merged.


abort

Switched remaining std::terminate calls to abort - more exhaustive testing with Clang still runs into issues in some dev environments.

Why did you change from std::terminate() -> abort(), is the later more diagnosable?

No, terminate just calls abort. The latter has better support from the clang tool chain.


Call for any bugs, inconsistencies, formatting, anything!

Hello lovely folks,
With the active participation of so many contributors and awesome breakthroughs in our codebase such as flake8 compliance, improved documentation, interactive conversations support and hotword detection, I feel that now it is time for us to release the first version 0.1 as a public beta. The due date is the 5th of November, 2016.
Before going through with this, I invite everyone to rigorously test the software for any bugs, inconsistencies, formatting errors, anything and be a part of the first release of Melissa. Please follow the contribution guidelines though ;)
Thank you all for your support!
With Warm Regards,
Tanay Pant

cc @aniketmaithani @danielkoster @vedmathai @anurag-ks @neilnelson @aniketk21 @CBickel87 @lakshmanaram @anantprsd5 @Pratik151

@tanay1337 I would also like to propose that since you are very particular about GIT GUIDELINES let's have the same for commit message too. I've seen that sometimes the commit message doesn't really implies what fix, feature or documentation changes have been made in the subsequent commit and it makes it hard for the outsider to contribute easily. You thoughts?

Agreed @aniketmaithani! Will draft up something on this soon.

Thanks and congratulations everyone for all the PRs and issues! It was a great Hacktoberfest :D


(Question) How to gracefully close a publisher service?

Given a process that is just publishing to RabbitMQ, how to close it gracefully, in order that all the messages send to be published to be sent instead of lost?
To better explain it, here is a minimal version of the .mjs file that I'm using to test latency and found out the issue (The original is at the end of the post):
import rascal from 'rascal';
const Broker = rascal.BrokerAsPromised;

const RABBIT_MQ_URL = process.env.RMQ_URI
console.log(`RMB_URL:`, RABBIT_MQ_URL);

const rascal_confs = {
  vhosts: {
    "/": {
      connection: {url: conf.RABBIT_MQ.URL},
      exchanges: { 'rmq.stress.test': {type: 'topic'}, },
      queues: { 'RMQ_Stress_Test': {}, },
      bindings: {
        'external_bind': {
          source: 'rmq.stress.test',
          destination: 'RMQ_Stress_Test',
          bindingKey: 'sender',
          destinationType: 'queue',
        }
      },
    }
  },
  publications: {
    test : {
      vhost: "/",
      exchange: "rmq.stress.test",
      routingKey: "sender",
    },
  }
}

let broker;

async function rabbitmqSetup() {
  console.log(`Setting up RabbitMQ:`, rascal_confs.vhosts['/'].connection);
  broker = await Broker.create(rascal_confs);
  broker.on('error', ()=> {console.error; process.exit(-1)});
  console.log(`Setup done`);
}

await rabbitmqSetup();

async function rabbitmqSend(msg) {
  const ret = await broker.publish('test', msg);
  ret.on('error', console.error);
  console.log(ret)
}

for(var i=0; i<100; i++)
{
  await rabbitmqSend(`Test ${i}`);
  console.log(`${i}`, lat)
}

await broker.shutdown();

If I run this code, it will close with no error, but just one or sometimes none of the published messages will get to the RabbitMQ.
If I remove the last line with the await broker.shutdown(), it will send all the messages to RabbitMQ but it will be kept running forever without exiting the process.
I was looking for something like await broker.finishSendingEverything() thing, but I couldn't find anything alike (I tried looking in the documentation, Google, code in the repository, StackOverflow, etc).
The main problem is that when the process has to be restarted, it cannot lose anything. Another thing I was looking for is a way to instead of waiting to send everything that is remaining, read and save them in another place and try to send it after I restart.
I tried to investigate the source code for that, but because of the encapsulation using closure for the broker in the BrokerAsPromised, I can't do anything practically.
So how to handle process closing without losing data?
Basic info

node: v14.18.1
rascal: 13.1.0

Original file used to test (with latency measurements)
import { hrtime } from 'process';

import rascal from 'rascal';
const Broker = rascal.BrokerAsPromised;

const RABBIT_MQ_URL = process.env.RMQ_URI
console.log(`RMB_URL:`, RABBIT_MQ_URL);

const rascal_confs = {
  vhosts: {
    "/": {
      connection: {url: RABBIT_MQ_URL},
      exchanges: { 'rmq.stress.test': {type: 'topic'}, },
      queues: { 'RMQ_Stress_Test': {}, },
      bindings: {
        'external_bind': {
          source: 'rmq.stress.test',
          destination: 'RMQ_Stress_Test',
          bindingKey: 'sender',
          destinationType: 'queue',
        }
      },
    }
  },
  publications: {
    test : {
      vhost: "/",
      exchange: "rmq.stress.test",
      routingKey: "sender",
    },
  }
}

let broker;

async function rabbitmqSetup() {
  console.log(`Setting up RabbitMQ:`, rascal_confs.vhosts['/'].connection);
  broker = await Broker.create(rascal_confs);
  broker.on('error', ()=> {console.error; process.exit(-1)});
  console.log(`Setup done`);
}

await rabbitmqSetup();

async function rabbitmqSend(msg) {
  const ret = await broker.publish('test', msg);
  ret.on('error', console.error);
  console.log(ret)
}

var total = 0;
var lat_sum = 0;
var lat_max = 0;
var lat_min =<PHONE_NUMBER>999;

for(var i=0; i<100; i++)
{
  const start = hrtime.bigint();
  await rabbitmqSend(`Test ${i}`);
  const end = hrtime.bigint();

  const lat = Number(end - start)/1000000;
  total += 1;
  lat_sum += lat;
  if (lat < lat_min) lat_min = lat;
  if (lat > lat_max) lat_max = lat;

  console.log(`${i}`, lat)
}

console.log(`\n[${i}]:\t$avg: ${lat_sum/total}\tmax: ${lat_max}\tmin: ${lat_min}\r`);

await broker.shutdown()

Hi @AllanDaemon,

Given a process that is just publishing to RabbitMQ, how to close it gracefully, in order that all the messages send to be published to be sent instead of lost?

You need to have some mechanism for monitoring inflight messages, and preventing shutdown until all have been successfully published by the success event and absence of a return event..
broker.publish('p1', 'some message', (err, publication) => {
  if (err) throw err; // publication didn't exist
  publication
    .on('success', (messageId) => {
      console.log('Message id was: ', messageId);
    })
    .on('error', (err, messageId) => {
      console.error('Error was: ', err.message);
    })
    .on('return', (message) => {
      console.warn('Message was returned: ', message.properties.messageId);
    });
});

'return' events should be emitted first, but because 'success' indicates that the message was successfully delivered to the broker, you will still get a 'success' event even when a message is unroutable.
However, this does not necessarily guarantee that you will never lose messages.  You cannot resolve through RabbitMQ alone - you need a detection and recovery mechanism built into your wider systems architecture.

To give a little more context as to why Rascal shouldn't keep track of outstanding messages when publishing, imagine the following scenario...

start workflow (either through an HTTP request or incoming message)
publish message 1
write to a database
publish message 2
finish workflow (e.g. send an HTTP response or ack the incoming message)

If Rascal refused to shutdown while there are outstanding messages, it could stop half way through the workflow during step 3, therefore you need to rely on monitoring the outstanding work independently of Rascal.
With this in mind are you OK to close?


IP_DONTFRAG broken on Apple xcode 12.2

Recently libunbound started failing for me on macos with:
[1605563093] libunbound[25390:0] error: setsockopt(..., IP_DONTFRAG, ...) failed: Protocol not available

I tracked this down to the latest version of xcode (12.2) installing and switching to MacOSX 11.0 ("Big Sur") headers, where this macro is apparently now defined:
$ grep IP_DONTFRAG /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/usr/include -r
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/usr/include/netinet/in.h:#define IP_DONTFRAG             28   /* don't fragment packet */

however it doesn't actually work (at least on my macos 10.15 build system) as the setsockopt fails with the error shown above.
I worked around it by patching services/listen_dnsport.c with:
-#  elif defined(IP_DONTFRAG)
+#  elif defined(IP_DONTFRAG) && !defined(__APPLE__)

which fixes my libunbound use case built with this cursed new version of xcode, but I'm not sure whether that is a proper fix for this issue or not.

Thanks for the test on the latest OSX version and the fixup!


VMware plugin only works with supported Storage Infrastructure

The VAAI (VMware Array API Integration) effectively allows instant cloning, as the disk cloning is passed over to the storage device through the API. On unsupported Infra, a new instance won't reflect in InfraKit until the entire disk has been duplicated (upwards of 1-2 mins) which will result in multiple instances until instance count eventually resolve.

Fixed and tested with #759


Backend Mock

Currently, frontend development requires running the backend. It would be great if we could mock backend responses to some degree. This allows us to test frontend features in isolation.
Originally proposed by @xcodebuild in https://github.com/OpenDevin/OpenDevin/pull/128

Hi, Can I work on this
Thanks

Resolved in #214, maybe can be closed.


Updated Origami download URL

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download origami is error-free.
[x] brew cask style --fix origami left no offenses.

Why the URL change?

Needs a # was verified as official when first introduced to the cask comment above this line (example; reasoning).

The old one didn't work for me earlier today and the one I submitted in my commit is the one that's now found on the [http://facebook.github.io/origami/download/](project page).
Oh, and I just noticed that I messed up the URL anyway, the new one contains the version number twice and I forgot to replace the first occurrence of it.

Fixed in https://github.com/caskroom/homebrew-cask/pull/20545


lookup (without spaces) should be case-insensitive

Please select the area your bug applies to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[x] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Describe the bug
Unless I use a space (which triggers a different modality), lookup is case-sensitive. I.e., if I don't match the file's casing, the note isn't included in the result.
To Reproduce

Look up any note (without using a space) where the query doesn't match the note's case.

Expected behavior
Lookup should be case-insensitive, or at least have the option of being case-insensitive.

Hello @djradon, thanks for reporting the issue. I can repro this one.
Pinging @nickolay-kondratyev for lookup related fix.

This should be fixed in v0.87 of Dendron. Feel free to comment here if not the same.


Connecting To Azure App Configuration From Different Tenant

Hello Team,
I'm from internal team in commerce and we are trying to push app config through pipeline. Our pipeline resides on MSFT tenant while our App Config is on the other one due to production requirements. But we noticed that using App Configuration requires a service connection connecting the two tenants which I have problem building. So could you help me with whether is this kind of connection supported, and if it is how should I set it up? Thank you! My apologies if this is not the best place to ask and it would be good if you can point me to the right poc. BTW we can share more details if there is an internal office hour I can join if available, thanks again!
Best,
Sheeran

Hello Sheeran,
I'd like this is a very common issue by using a crossing tenant service connection and Azure pipeline. Currently, we don't have a plan to support ConnectionString, as Service Connection is the behavior that keep consistency with other Azure pipeline tasks.
To config a Azure pipeline in different tenant, I think you need to know the tenant id that your App Config located. I tried the Service connection from the Azure pipeline portal by using Azure Resource Manager as the type, it asks me the tenant id, and service principal details.
Let me know if that answered your questions.
Thanks,
Yiming

Hey Yiming, thank you for the instructions and it worked pretty well! I've created a service principle and use the manual resource manager set up instead of the automatic option listed here. So just my free bit of advice, it would be good to include manual setup as shown here in this document. Thanks again for the quick response and App Config is indeed handy to use. 👍


Convert projects to new format and add support to netstandard

With this pull request the project can be used on .NET core projects.
It wolud be cool if you publish the project on nuget.

That's great. Thank you so much!
I just published this project to NuGet.
https://www.nuget.org/packages/Nyamikan.Asn1PKCS/


Restore features broken my Edge Removal

If possible, implement @Aveyo's "OpenWebSearch" which will restore some functionality that is broken when Edge is removed by redirecting that functionality to the default browser

If you want to use that script, run it as a custom script, probably in the Scripts to run in the system context, before user accounts are created section.
I have no intention to include that script (which would easily double the size of a typical autounattend.xml file) in my code, sorry.


@PranayWankhede, the issue being discussed in #3683 was resolved in 2.12.2. As stated in that issue, Requests has no intent to support URIs with underscores in hostnames because those are expressly prohibited in the URI RFC.

If you’re still experiencing this issue prior to 2.12, it’s likely another issue because we did not use idna to validate hostnames at that point. We’d need a concrete example to do anymore debugging here. I’m going to close this for now since this seems like a usage inquiry for unsupported behavior. If you have a use case that’s causing this with a URI that conforms to spec, please feel free to reopen. Thanks!
Originally posted by @nateprewitt in https://github.com/requests/requests/issues/4904#issuecomment-445982947

@nateprewitt i don't have underscore in the hostname but in the path "https://hostname/note_p" is this a valid url as per the requests library? It gives me raise InvalidURL('URL has an invalid label.'). Although it was working fine two weeks back. Thanks!


memory issue

Hi all,
I'm currently use the lora-gateway-bridge on a production environment with around 7500 uplink /  750 downlink per days.
Sometimes (3 times in 3 months) the available memory suddently decrease on the gateway.
I have restarted the lora-gateway-bridge component and the memory was released

before :
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root     29286  2.7 86.7<PHONE_NUMBER>44 ?       Sl   Jun20  87:22 /opt/lora-gateway-bridge/bin/lora-gateway-bridge --log-level 4
after:
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root      5405 11.6  1.5 794984  3900 pts/0    Sl   11:56   0:00 /opt/lora-gateway-bridge/bin/lora-gateway-bridge --log-level 4
On the logs I haven't find something wrong.
I'm using the following mlinux version on the multitech :
root@mtgateway0036:/etc# more mlinux-version
mLinux 3.3.9
Built from branch: (detachedfrom0947d21)
Revision: 0947d212fc4c10871c66b4d83c97c5634dc1b8c7
Have you an idea about how the root cause can be found ?

Hi @gillespilloudwyres that is odd. I have never seen this. When there would be a memory leak in LoRa Gateway Bridge, I would expect that the usage would increase over time, not suddenly.
One thing that probably will be provided in the near future is Prometheus integration for the LoRa Server components. This will make it possible to monitor the health of each LoRa Server service (instance) and will also expose information about the Go runtime. I think this would be beneficial to help you debugging your issue.
Do you think that would help you?

Hello @brocaar , thanks for your reply. That is odd, I can confirm.
In parallel of the prometheus integration, could theses statistics be available by a mqtt subscription to be independant. In my production platform I want to integer all of my metrics to my zabbix server.
Regards,

Yes and no ;)
Prometheus exposes a HTTP endpoint where one could fetch all the metrics. E.g. on an interval of 10, 20, 30, ... seconds, so LoRa Gateway Bridge will not send this over MQTT.
However, it is really easy to make a service sitting next to LoRa Gateway Bridge doing a periodical GET, format the metrics in a format usable by your Zabbix server and push this over MQTT :-)

As I have observed today, the TX is stopped by the gateway as soon as the memory decrease. Sometimes, the consequence of the lake of memory seems to be a reboot of the gateway or a process kill.
I think install a watchdog to restart the process when the problem occur, now 2 times per day.

Thanks for the feedback. In the meanwhile, I did spend some time on Prometheus integration. I will see if I can add this asap to LoRa Gateway Bridge so we have a bit more information about what could be the issue (e.g. it will expose information about the memory usage, number of go-routines + I can add my own counters, timers etc. too).

As I can continue to observe, is when the network is down and back, the gateway-bridge has difficulties to restore the communication with the mosquitto server.

I'm now running a test server which is processing ~ 90k uplinks per day. This dashboard is just an example, it is tracking more metrics:

So far things are pretty stable

I will also do some more testing to see what happens when the MQTT connection becomes unavailable for a longer time.

I will also do some more testing to see what happens when the MQTT connection becomes unavailable for a longer time.

Yes , when the mqtt connection shutdown.
I think than the memory issue start around this logs, and a full restart of the gateway bridge is necessary to have the messages back :
time="2018-07-13T11:14:06+02:00" level=error msg="backend: mqtt connection error: write tcp a.b.c.d:34609->e.f.g.h:1883: write: connection reset by peer" time="2018-07-13T11:14:07+02:00" level=info msg="backend: connected to mqtt broker" time="2018-07-13T11:14:07+02:00" level=info msg="backend: re-registering to gateway topics" topic_count=1

Quite recently a deadlock related fix has been added to the MQTT library I'm using which would cause a (MQTT) token to never return meaning the call would hang forever (multiplied with the number of received UDP messages this could increase the memory usage). Maybe this solves your issue? I have updated the vendors in the latest commit in the master branch. Could you re-test with that version?
If needed I could provide pre-compiled binaries. In case you compile yourself, don't forget to run a dep ensure after the git pull (to update the vendor directory).

wow ! Thanks a lot for this update ! this problem seems related. have you the possibility to easily build it for a multitech target ?
Thanks

@gillespilloudwyres I've generated these pre-compiled binaries for you: https://www.dropbox.com/sh/izdjggor4doytqd/AADMdKVctil54cpX7CCK4LILa?dl=0.

deployed on the impacted environment. Is a specific log attended when the mqtt deadlock occured ? or the root cause is normally solved by this version ? I will update this ticket tomorrow after 24 hours of work and around 350 000 rx/2000 tx.

The root cause of the deadlock should be resolved by this version (as it
uses the updated mqtt client). There won't be anything in the logs that
will indicate this.
On Tue, Jul 24, 2018 at 3:04 PM Gilles PILLOUD<EMAIL_ADDRESS>wrote:

deployed on the impacted environment. Is a specific log attended when the
mqtt deadlock occured ? or the root cause is normally solved by this
version ? I will update this ticket tomorrow after 24 hours of work and
around 350 000 rx/2000 tx.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/brocaar/lora-gateway-bridge/issues/86#issuecomment-407399024,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKGecxDC2bBnN2Gcwbwhc9bDwPEqhSNks5uJxtqgaJpZM4Uzte8
.

@gillespilloudwyres did this solve your issue?

hello,
I have doubts about that. To have a functionnal solution, A functionnal check has been developped to verify if a message come to the loraserver from a specific gateway. In case of no messages, a reboot of the gateway bridge is sent.
How should I integer the prometeus checks to verify the number of go routines?
Regards,

@gillespilloudwyres I'm not sure if I understand your comment. Does this version still have the memory issue that you have before?

Hi Orne,
I still have memory glitch, but I have putted watchdog to handle them. In my case the network of my client has strange reaction (at the ICMP level, for example, ping packets are retained for 30 seconds sometimes...).
I prefer close this issue and work with my client to improve his network stability.
thanks


32 trigger new build

Description
trigger new build
References

#32

@seblapela , I don't assume we need this anymore.


[SPARK-44350][BUILD] Upgrade sbt to 1.9.2

What changes were proposed in this pull request?
The pr aims to upgrade sbt from 1.9.1 to 1.9.2.
Why are the changes needed?
1.The new version brings bug fixed:

Let ++ fall back to a bincompat Scala version by @eed3si9n in https://github.com/sbt/sbt/pull/7328

2.v1.9.1 VS v1.9.2
https://github.com/sbt/sbt/compare/v1.9.1...v1.9.2
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.

Merged to master


Mrcjkb/bar_chart_y_tick_bugfix

This PR fixes a bug in the calculation of Y ticks for bar charts.
The bug
If all Y values in the chart are > 0, then the minValue of the Y axis is set to the min value of the data, and not zero (and vice versa for bar charts with only negative values). This makes sense for a line chart, but not for a bar chart. You can reproduce the bug by running the "BarChart01" demo.
The fix
Under the following conditions, set the Y axis min value to 0:

The axis direction is Y
The styler is a CategoryStyler
The min value is > 0

Under the following conditions, set the Y axis max value to 0:

The axis direction is Y
The styler is a CategoryStyler
the max value is < 0

I also added in some null checks to the streams in Axis#getAxisTickCalculator from my last PR.

@MrcJkb There's a report of a bug in the Y-Axis calculation in the recent release.
https://github.com/knowm/XChart/issues/530
I also ran the XChart demo and noticed that BarChart03, which is also a "stacked" bar chart has a rendering error.

Would you be willing to look into this issue and possibly submit a fix?

FYI here's what it looked like at the 3.6.5 release.

Sure :)

Thanks, it works now!


[Bug - Vertical] timeline brackets disappear when collapsing the most nested item in a time range

when collapsing the most nested item, other timeline brackets disappear and other time range indicators (the oval bit) turn into circles
expanded:

collapsed:

Fixed in release 2.2.7 via #84


Arrow Icon in Collapsible  Cards on Service Fabric Explorer Page is Misleading

Is your feature request related to a problem? Please describe.
It is not related to a problem but an enhancement of UX
Describe the solution you'd like
The collapsible information cards in Service Fabric Explorer have a down-arrow when they are collapsed and an up-arrow when expanded. Many websites and UI frameworks show a down-arrow when an accordion menu or card is expanded and a right-arrow when collapsed. If the SF Explorer can follow the same approach, It will be easier for users to adopt it.
Additional context

@musaugurlu can you link to where you commonly see that? Bootstrap follows the same design pattern https://getbootstrap.com/docs/5.0/components/accordion/ and material does aswell
https://material.angular.io/components/expansion/overview


Bump JDK from 11 to 17

It would be nice to be able to take advantage of some of the language features that have been added since JDK 11.

The sort of PR where builds must fail :-)

The sort of PR where builds must fail :-)

Heh. Works on my machine.
Meant to be the sort of PR that engenders discussion.

Does it mean we can refactor some code, especially replacing the old switch case with an enhanced switch case?

@dsgrieve I'm talking about this: https://docs.oracle.com/en/java/javase/11/docs/specs/jar/jar.html#multi-release-jar-files
It allows us to only revert to an older version on specific .java files, not an entire project.

I'm really on the fence on this one. I'm personally working in JDK 16 and will likely move to 17 very shortly. So, part of me is saying, let us run the tests in JDK 17 and if it's all green, let's do it. Then, I'm also thinking about some of the developers I know who expressed interest that are stuck using their corporate supplied laptops that have just been allowed to move up to JDK 11... so, working in JDK 17... where does it leave them. Then the other part of my brain says, do we even have any of these developers in our audience. The answer to that question... I don't know and if they are not here now, would moving to JDK 17 cause them to be excluded in the future... I simply don't know. We need a @brunoborges surgery :-)

I'm really on the fence on this one. I'm personally working in JDK 16 and will likely move to 17 very shortly. So, part of me is saying, let us run the tests in JDK 17 and if it's all green, let's do it. Then, I'm also thinking about some of the developers I know who expressed interest that are stuck using their corporate supplied laptops that have just been allowed to move up to JDK 11... so, working in JDK 17... where does it leave them. Then the other part of my brain says, do we even have any of these developers in our audience. The answer to that question... I don't know and if they are not here now, would moving to JDK 17 cause them to be excluded in the future... I simply don't know. We need a @brunoborges surgery :-)

This point is very valid, we may well have corporate folks (or others) who can't develop on 17.  Let's keep this open and see what folks say.  @brunoborges Twitter poll?
As a side note - this is what a mailing list would be useful for? I'm not sure how we can broadcast this sort of thing.

Moving forward with this could potentially create two code streams where any fix in one would have to be applied to the other.


React app event/sign

Description
What did you do in this PR?
Tests

Steps to reproduce :

...

Expected results :

...

Screenshots

That's just a test


Add Redis

Hey, I added the Redis to docker-compose. I hope to be useful for you as it's for me.

This was resolved with: https://github.com/aschmelyun/docker-compose-laravel/commit/9a6b731cb6a59ca1ccff2a9f452b563c504a75eb

This was resolved with: https://github.com/aschmelyun/docker-compose-laravel/commit/9a6b731cb6a59ca1ccff2a9f452b563c504a75eb


Improved code to make search and filters section sticky on all find pages(#24b11cp)

https://user-images.githubusercontent.com/82817616/160068690-5dba91ad-3310-4d37-8b29-1bf9b16fdeee.mp4

Will pick this later since right now we don't know how this will fit into our UX


CLA Cleanup

Address work-in-progress type comments and content.
Fixes zaproxy/zaproxy#8599

I've set DCO to pass and have signed the CLA:
https://github.com/zaproxy/cla/blob/530c2dd37d2f461586f0e7a84181ae2696446d44/signatures/version1/cla.json#L11-L18

Tweaked.
This PR was done with github.dev so please squash and merge.

Thank you!


Safeguard against path traversal for ZipConverter

fix: prevent path traversal vulnerabilities in ZipConverter
Added a secure check for path traversal vulnerabilities in the ZipConverter class. Now validates extracted file paths using os.path.commonprefix to ensure all files remain within the intended extraction directory. Raises a ValueError if a path traversal attempt is detected.

Normalized file paths using os.path.normpath.
Added specific exception handling for zipfile.BadZipFile and traversal errors.
Ensured cleanup of extracted files after processing when cleanup_extracted is enabled.

@microsoft-github-policy-service agree [company="{ThreatSTOP}"]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree company="ThreatSTOP"

@Josh-XT FYI

@Josh-XT FYI, can you please take a look?

Looks like a good improvement to me!

Zip this issue is what keeps me up at night re: zip files. (The problem is worse with tar files, which we do not support).
PR, looks reasonable to me, but I want to get another few opinions. We might even consider not excluding zip support by default -- making it optional.

Thinking on this more, I believe it is possible to open a byte stream for a file in the Zip, without requiring that we decompress the whole archive. We could in theory enumerate supported files, and one by one write them to a tmp file on disk (with a safe name and permissions), and convert the, and clean them up.
In any case, I'll merge this PR now (as it is strictly better), and we can revisit in a future PR.


[JOBS-12224] Update API test template with page tokens

Changes
Update API test template with page tokens added in https://github.com/databricks/universe/pull/320579
Tests

[x] make test passing
[x] make fmt applied
[x] relevant integration tests applied

Codecov Report
Patch and project coverage have no change.

Comparison is base (38fb330) 19.00% compared to head (c1caeb9) 19.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   19.00%   19.00%
=======================================
  Files          82       82
  Lines        8761     8761
=======================================
  Hits         1665     1665
  Misses       6950     6950
  Partials      146      146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Rust player

Description
My attempt at coding up the first bit of logic from the game in Rust with tests.
Testing
It builds, and the tests pass. Hopefully, it also works in CI.

I'm rather sure much of this rust code is naive. I haven't written much rust before.

Idk what's going on here with the approvals so merging


GPU utilization

I wanted to test the search with the test search script. Since GPUs 0 and 1 are being used for another process, I ran this command:
CUDA_VISIBLE_DEVICES=2,3 bash scripts/test_search.sh
Even though the following log status shows in the resssources requested 1.96/2 GPUs which makes perfect sense and every model is taking 2 CPUs and 0.49 GPU
== Status ==
PopulationBasedTraining: 0 checkpoints, 0 perturbs
Resources requested: 8.0/20 CPUs, 1.96/2 GPUs
Memory usage on this node: 91.1/269.9 GB
Result logdir: /home/sgharbi/pba/results/test_search
Number of trials: 4 ({'RUNNING': 4})
RUNNING trials:

RayModel_0:  RUNNING, [2.0 CPUs, 0.49 GPUs], [pid=425228], 87 s, 1 iter
RayModel_1:  RUNNING, [2.0 CPUs, 0.49 GPUs], [pid=425227], 87 s, 1 iter
RayModel_2:  RUNNING, [2.0 CPUs, 0.49 GPUs], [pid=425241], 87 s, 1 iter
RayModel_3:  RUNNING, [2.0 CPUs, 0.49 GPUs], [pid=425233], 173 s, 2 iter

But when i look with nvidia-smi there no usage of GPUs 2 and 3!
Am I doing something wrong here please? If so, how to make it really utilize the GPUs, thank you so much!

@arcelien Can you look into my issue please? Thank you!


Update xy-grid.md

Changing the example mixins for xy-cell to use $gutters: 0 instead of $gutters: none because none breaks gulp build

Description

...

Closes

Types of changes

[x] Documentation
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (anything that would change an existing functionality)
[ ] Maintenance (refactor, code cleaning, development tools...)

Checklist

[ ] I have read and follow the CONTRIBUTING.md document.
[ ] The pull request title and template are correctly filled.
[ ] The pull request targets the right branch (develop or develop-v...).
[ ] My commits are correctly titled and contain all relevant information.
[ ] I have updated the documentation accordingly to my changes (if relevant).
[ ] I have added tests to cover my changes (if relevant).

Hi @siwood,
Can you clarify that and provide a reproducible testcase where we can see that it fails? gulp an gulp build work for me.

Hi @siwood,
Can you clarify that and provide a reproducible testcase where we can see that it fails?
Also please follow our commit lint rules (see contributing.md).

Sure, sorry about that. I'll go back and re-format this. I didn't correctly follow the contribution guidelines.

I'm closing this. I'm sorry i submitted this so quickly without doing more due diligence. I think this is an issue with the documentation being out of sync with the version of foundation the Drupal theme uses by default... Which I'll work on fixing from the Drupal side of things.

Tahnks for the details (Drupal Foundation Theme).
If there is anything that we can do, please let us know.


Dedupe entries when inserting

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Warning

:warning:
Big PR: 626 lines of code changed

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #599 into master will increase coverage by 0.14%.
The diff coverage is 88.88%.

@@            Coverage Diff            @@
##           master    #599      +/-   ##
=========================================
+ Coverage   70.55%   70.7%   +0.14%
=========================================
  Files         227     230       +3
  Lines       12868   12864       -4
=========================================
+ Hits         9079    9095      +16
+ Misses       3159    3137      -22
- Partials      630     632       +2

Impacted Files
Coverage Δ

util/sqlgen/rowdef.go
100% <100%> (ø)

util/sqlgen/field.go
73.33% <73.33%> (ø)

ext/storage/postgresstatemanager_write.go
65.59% <81.69%> (-3.38%)
:arrow_down:

util/sqlgen/fieldset.go
97.43% <97.43%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4394627...9c1c46c. Read the comment docs.

made a comment on the equals method for rows, rest of the code mainly looks like refactoring to the sqlgen package.


Daily update

Automated changes by create-pull-request GitHub action

Build failed because of:
No cached entry, and PANTHEON.tech s.r.o has issues with logo: pantheontech_sro.svg, SVG file embeds a png. Please use a pure svg file
No cached entry, and Sollers College has issues with twitter: https://twitter.com/SollersEdu, Request failed with status code 400
No cached entry, and Italian Linux Society has issues with twitter: https://twitter.com/ItaLinuxSociety, Request failed with status code 400
No cached entry, and Open Sourcing Mental Illness, LTD has issues with twitter: https://twitter.com/osmihelp, Request failed with status code 400
No cached entry, and Optum/UnitedHealth Group has issues with twitter: https://twitter.com/Optum, Request failed with status code 400
No cached entry, and JVC KENWOOD Corporation has issues with twitter: https://twitter.com/JVCKENWOOD_SR, Request failed with status code 400
Item PANTHEON.tech s.r.o has no image_data


Pier 13, Port of Baltimore

text: Loquipments are considered both a location and an equipment at the time of paying their cost
link: https://groups.google.com/g/rec.games.trading-cards.jyhad/c/XpZ6F53jK-c/m/EQWCLO72MbsJ

Duplicate


pbit related quality fix for BC7 texture encoding

When I call DirectX::D3DXEncodeBC7() with DirectX::BC_FLAGS_USE_3SUBSETS, the overall output error increases across the kodim test corpus. This is incorrect: the overall error should decrease. Other BC7 encoders don't behave in this way, so I investigated further. I modified D3DX_BC7::Refine() to call D3DXDecodeBC7() on the encoded block, computed the actual error, and compared that vs. the error computed by Refine(). They differed, which is incorrect.
The bug is caused by D3DX_BC7::Refine() not correctly computing the block error in a way that factors in the actual coded pbits. It computes the error using the endpoints before the LSB's are slammed to the pbits, causing the encoder to choose blocks that actually increase error. This will wreck quality in pbit modes.
The fix introduces a new helper function D3DX_BC7::FixEndpointPBits(), which Refine() calls after it computes new endpoints. It could be easily improved further for more gains (it doesn't round the component values correctly factoring in the pbits), but it's a massive improvement.
With this fix applied the encoding quality across my test corpus increased from 44.25 to 46.02 with 3 subsets enabled, and 45.64 with 3 subsets disabled. Tested with opaque and transparent textures.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: richgel999 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks. I'm working on a validator test to get better regression coverage when taking BC changes. Once I'm able to run a baseline I can try your change and verify it works as advertised.

Yes, independent validation is really necessary and I'll wait on submitting any more improvements until you have this going.
I have another set of simple changes that introduces a new flag (BC_FLAGS_FASTER_BC7) that improves encoding speed by ~10x. Quality (without 3 subsets enabled) across my corpus is reduced by 1 dB (from 45.64 to 44.65), but it's still stronger than the original encoder with the pbit bug (which was 44.4 dB). Without the flag the encoder works as before, and it's combinable with the other flags (3 subsets and quick). The changes are very simple because they just leverage the existing encoder and add several heuristics used by other encoders.
The first fix disables mode 7 on completely opaque blocks. Mode 7 isn't useful because the other modes are just as strong for opaque cases. There's no quality loss from this change, but it's noticeably faster (12429 vs. 9756 secs).
The other improvements: Only refine a single partition for each mode, use bounding box approximation vs. full PCA in OptimizeRGB/OptimizeRGBA when estimating partitions, use mode 1's estimated partition for mode 3, and disable the deeper exhaustive refinement.
									CPU Time	 RGB PSNR

No flags:
Orig/unmodified:							12505.338093 45.638377
After my changes, remark out m7 for opaque       12429.388720 45.638377
After my changes, skip m7 for opaque:  	         9755.917509  45.638270
BC_FLAGS_FASTER_BC7:
Only refine a single partition:  			 	3358.698415  45.360886
Estimated partition selection:   			 	2884.865429  45.037020
Disable less useful modes for opaque:   	  	2821.762252  45.017103
Same partition for 1,3, less refinement:	 	        1189.376734  44.648705
BC_FLAGS_FORCE_BC7_MODE6:
BC_FLAGS_FORCE_BC7_MODE6					   	471.434405   41.863792
BC_FLAGS_FORCE_BC7_MODE6|BC_FLAGS_FASTER_BC7   	188.634432   41.070086

I've checked in the code for the new flag:
https://github.com/Microsoft/DirectXTex/pull/93/commits/d3f1d3c8f230ac2d2c321930c5bcf12d3750cc2f
I've tested with both opaque and complex transparent textures.

Should probably fix the indentation formatting.  The existing code uses spaces, but these changes use hard tabs.

Ok - I'll fix this within a day or two.

Sorry I thought this was the pull request for that issue. If not, please submit it as a distinct PR. Thanks!

BTW - ImageMagick can compare images and output PSNR:
http://www.imagemagick.org/Usage/compare/#compare
I like using tools like this because it's a good independent comparison point. My PSNR's are compatible with this tool.

I appreciate the contribution, but this pull request seems to merge a lot of distinct optimizations into one big change so I'm having trouble validating each part of it...
I'm going to try to tease apart the different fixes here, in particular the mode 7/opaque skip case and the original fix for this issue which I want to try out independent of your new suggestion "FASTER" flag...

I've taken the fix with FixEndpointPBits in this commit, so this PR now fails due to conflicts...

I've taken the fix to skip mode 7 for opaque blocks in this commit.
If you'd like to clean up the conflicts and update the PR for just the 'faster' mode, I can look at taking those changes.
Thanks again!

Thanks Chuck. I've been busy on our universal format, but once I go back to BC7 I can fix up the changelist for faster mode.

Any update?

Hi - Sorry, we had to ship our universal codec. It looks like you've already merged all of the key bug fixes. The p-bit thing was the most important.
Best regards,
-Rich


Update to literal word Remove to replace with x icon

### Task
Currenty, to remove a project from the list, you have to click on the word Remove.

[ ] Change the Remove to x icon

I would like to work on this. If you could assign it to me.


For 2.0 Servicing we need to generate debuginfo for Linux

Port the fix for https://github.com/dotnet/source-build/issues/267

Not needed for 2.0


box-cutter/ubuntu1610 cannot be retrieved

Hi,
I tried to do vagrant up today or manually add the box and I could do it.
I get the menu to choose the provider, but I cannot download the box.
So vagrantfile is no working.

What's the error output from vagrant?
What provider are you using? Is it listed here? https://app.vagrantup.com/box-cutter/boxes/ubuntu1610

It is listed. But there is no file at that link.
[image: Inline images 1]
On 27 November 2017 at 16:21, Wes Higbee<EMAIL_ADDRESS>wrote:

What's the error output from vagrant?
What provider are you using? Is it listed here?
https://app.vagrantup.com/box-cutter/boxes/ubuntu1610
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/g0t4/docker-swarm-mode-getting-started/issues/3#issuecomment-347235030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApIHIePx26TqCAUXG6udB9xHLgwiSHbks5s6uFwgaJpZM4QroXM
.

I'd inquire with box-cutter
On Mon, Nov 27, 2017 at 12:16 PM, mladenuzelac<EMAIL_ADDRESS>wrote:

It is listed. But there is no file at that link.
[image: Inline images 1]
On 27 November 2017 at 16:21, Wes Higbee<EMAIL_ADDRESS>wrote:

What's the error output from vagrant?
What provider are you using? Is it listed here?
https://app.vagrantup.com/box-cutter/boxes/ubuntu1610
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/g0t4/docker-swarm-mode-getting-
started/issues/3#issuecomment-347235030>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AApIHIePx26TqCAUXG6udB9xHLgwiSHbks5s6uFwgaJpZM4QroXM>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/g0t4/docker-swarm-mode-getting-started/issues/3#issuecomment-347254420,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK_3fwNuT7jpcoseKN_J3Cs8119sSrcks5s6u5xgaJpZM4QroXM
.

It seems that they don't host preloaded images
https://github.com/boxcutter/ubuntu
Current Boxes
We no longer provide pre-built binaries for these templates.
And there is no 1610 box to build. It seems that your repo needs to be
updated.
Regards, Mladen.
On 27 November 2017 at 22:29, Wes Higbee<EMAIL_ADDRESS>wrote:

I'd inquire with box-cutter
On Mon, Nov 27, 2017 at 12:16 PM, mladenuzelac<EMAIL_ADDRESS>wrote:

It is listed. But there is no file at that link.
[image: Inline images 1]
On 27 November 2017 at 16:21, Wes Higbee<EMAIL_ADDRESS>wrote:

What's the error output from vagrant?
What provider are you using? Is it listed here?
https://app.vagrantup.com/box-cutter/boxes/ubuntu1610
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/g0t4/docker-swarm-mode-getting-
started/issues/3#issuecomment-347235030>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AApIHIePx26TqCAUXG6udB9xHLgwiSHbks5s6uFwgaJpZM4QroXM>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/g0t4/docker-swarm-mode-getting-
started/issues/3#issuecomment-347254420>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAK_3fwNuT7jpcoseKN_
J3Cs8119sSrcks5s6u5xgaJpZM4QroXM>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/g0t4/docker-swarm-mode-getting-started/issues/3#issuecomment-347350519,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApIHNlDfV3p1YWnKZeEu8ajIk-eLpJ0ks5s6zfjgaJpZM4QroXM
.

Is that for boxcutter or box-cutter?

On Thu, Nov 30, 2017 at 05:45, mladenuzelac<EMAIL_ADDRESS>wrote:
It seems that they don't host preloaded images
https://github.com/boxcutter/ubuntu
Current Boxes
We no longer provide pre-built binaries for these templates.
And there is no 1610 box to build. It seems that your repo needs to be
updated.
Regards, Mladen.
On 27 November 2017 at 22:29, Wes Higbee<EMAIL_ADDRESS>wrote:

I'd inquire with box-cutter
On Mon, Nov 27, 2017 at 12:16 PM, mladenuzelac<EMAIL_ADDRESS>wrote:

It is listed. But there is no file at that link.
[image: Inline images 1]
On 27 November 2017 at 16:21, Wes Higbee<EMAIL_ADDRESS>wrote:

What's the error output from vagrant?
What provider are you using? Is it listed here?
https://app.vagrantup.com/box-cutter/boxes/ubuntu1610
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/g0t4/docker-swarm-mode-getting-
started/issues/3#issuecomment-347235030>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AApIHIePx26TqCAUXG6udB9xHLgwiSHbks5s6uFwgaJpZM4QroXM>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/g0t4/docker-swarm-mode-getting-
started/issues/3#issuecomment-347254420>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAK_3fwNuT7jpcoseKN_
J3Cs8119sSrcks5s6u5xgaJpZM4QroXM>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/g0t4/docker-swarm-mode-getting-started/issues/3#issuecomment-347350519
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AApIHNlDfV3p1YWnKZeEu8ajIk-eLpJ0ks5s6zfjgaJpZM4QroXM
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/g0t4/docker-swarm-mode-getting-started/issues/3#issuecomment-348151896,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK_3dCLzEeZuLVDH_xgihnveSP_nEvxks5s7odmgaJpZM4QroXM
.

Tried changing to 1604, getting the same...

Tried changing to 1604, getting the same...
`
C:\Projects\docker-swarm-mode-getting-started>vagrant up
Bringing machine 'm1' up with 'virtualbox' provider...
Bringing machine 'm2' up with 'virtualbox' provider...
Bringing machine 'm3' up with 'virtualbox' provider...
Bringing machine 'w1' up with 'virtualbox' provider...
Bringing machine 'w2' up with 'virtualbox' provider...
Bringing machine 'w3' up with 'virtualbox' provider...
Bringing machine 'w4' up with 'virtualbox' provider...
==> m1: Box 'box-cutter/ubuntu1604' could not be found. Attempting to find and install...
m1: Box Provider: virtualbox
m1: Box Version: >= 0
==> m1: Loading metadata for box 'box-cutter/ubuntu1604'
m1: URL: https://vagrantcloud.com/box-cutter/ubuntu1604
==> m1: Adding box 'box-cutter/ubuntu1604' (v2.0.26) for provider: virtualbox
m1: Downloading: https://vagrantcloud.com/box-cutter/boxes/ubuntu1604/versions/2.0.26/providers/virtualbox.box
m1:
An error occurred while downloading the remote file. The error
message, if any, is reproduced below. Please fix this error and try
again.
The requested URL returned error: 404 Not Found
`

Tried instead generic/ubuntu1610. The box got downloaded fine (altho, very slow), but then the provisioning failed on docker installation script:

it's boxcutter, they moved from box-cutter to boxcutter on github.  Either way, they no longer provide the binaries so the box doesn't work and cannot be downloaded.  This a show stopper for me just now as I go through the course.  Does anyone know where I can find an alternate box to download, or can explain what needs to be done to a generic Ubuntu box to make this work?  Is it just a case of installing virtualbox (or your desired provider) onto it?

I'll post this on vagrant cloud under my own account.

ndn-jenkins/ubuntu1604-amd64
This one might do the trick instead!

Tried ndn-jenkins/ubuntu1604-amd64 but got the following error:
m1: Download redirected to host: vagrantcloud-files-production.s3.amazonaws.com
An error occurred while downloading the remote file. The error
message, if any, is reproduced below. Please fix this error and try
again.
OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 54
Using Ecodev/ubuntu-server-1604 worked for me

Hello!
So, it looks like we still have this issue?!??
Would it be possible to update the vagrant file with an image that are downloadable and and the provisioning script works with?
I have tried changing images to download, "generic/ubuntu1610" and so on. no luck so far..
Cheers,
Fred

Still experiencing this problem.


Introduce rebalance metrics & track effectiveness

This is a prerequisite for a rework of hydra rebalancing, hopefully coming soon.

Consider moving some of the static helper methods getUsedDiskPercent and getAvailableDiskBytes which take a single HostState as parameter to HostState class

Sure, great ideas, but maybe when I actually try to make the code good instead of when I just want some metrics so I can have a baseline before fixing code.

I made the changes I feel are important to make now. Let me know if anything else needs looking at.

Copying my comments made separately:
the makeGuage method will make a gauge that return the constant initial value which is 0. Need to use a lambda. You might as well put calls to Metrics.newGauge in the makeGauge method too.

I think we're good now.

Gauge creation looks good to me.

It's spawn town.
On Apr 20, 2017, 11:37 PM -0400, Ian Barfield<EMAIL_ADDRESS>wrote:

@tea-dragon commented on this pull request.
In hydra-main/src/main/java/com/addthis/hydra/job/spawn/balancer/SpawnBalancer.java (https://github.com/addthis/hydra/pull/232#discussion_r112603378):

} + // update average metrics + int numScores = cachedHostScores.size(); + long avgDiskFree = sumDiskFree / (long) numScores; + double avgTaskPercent = sumTaskPercent / (double) numScores; + long sumDiskFreeDiff = 0; + double sumTaskPercentDiff = 0; + for (HostScore score : cachedHostScores.values()) { + long diskDiff = Math.abs(avgDiskFree - score.getFreeDiskBytes()); + sumDiskFreeDiff += diskDiff; + sumTaskPercentDiff += Math.abs(avgTaskPercent - score.getScoreValue(false)); + } + avgDiskFreeDiff = sumDiskFreeDiff / (long) numScores; + avgTaskPercentDiff = sumTaskPercentDiff / (double) numScores; + minDiskFreeDiff = avgDiskFree - minDiskFree; + maxDiskFreeDiff = maxDiskFree - avgDiskFree;

@yuesong (https://github.com/yuesong) - better now, thanks.
@tedpearson (https://github.com/tedpearson) - I tried to think of some relevant advice, but there is just too much. So... good luck.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (https://github.com/addthis/hydra/pull/232#discussion_r112603378), or mute the thread (https://github.com/notifications/unsubscribe-auth/ABaLDj_DnsJalgd-1HhmB7v1Ajm4jER9ks5ryCR2gaJpZM4M1KR7).

gltm


Memory Manager and Update Memory Actions/APIs

Description
Add more actions in the memory layer for update Memories with 100% coverage. Memory Manager for Agents is also included.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

apply spotlessApply

let's not amend the commit. It's hard to track which is being updated in this commit.

let's not amend the commit. It's hard to track which is being updated in this commit.

The recent ones are all related to comments updates. Nothing really changed.


err msg map

from blockchain: assertion failed:
unexpected selected boxes, expected

typically means too many input boxes selected
recommentation?


cannot find module youtube-videos-uploader

when i run node up.js i get module youtube-videos-upload not found error. what i did was clone repo then npm install then npm run buid then npm run format.

anyone ... to support

That's very likely an issue related to your project rather than this package.
make sure you indeed run the npm install, make sure the npm install worked and that you can see the module in your node_modules folder, and then make sure your import your module correctly, you may need to use the import keyword or the require one depending on how you set up your package.json.

There are lots of modules in node_modules folder. I use following format
import { upload } from 'youtube-videos-uploader' //Typescript
//OR
const { upload } = require('youtube-videos-uploader'); //vanilla javascript

// recoveryemail is optional, only required to bypass login with recovery email if prompted for confirmation
const credentials = { email: 'Your Email', pass: 'Your Password', recoveryemail: 'Your Recovery Email' }

// minimum required options to upload video
const video1 = { path: 'video1.mp4', title: 'title 1', description: 'description 1' }

const onVideoUploadSuccess = (videoUrl) => {
    // ..do something..
}
// Extra options like tags, thumbnail, language, playlist etc
const video2 = { path: 'video2.mp4', title: 'title 2', description: 'description 2', thumbnail:'thumbnail.png', language: 'english', tags: ['video', 'github'], playlist: 'playlist name', channelName: 'Channel Name', onSuccess:onVideoUploadSuccess, skipProcessingWait: true, onProgress: (progress) => { console.log('progress', progress) } }

// Returns uploaded video links in array
upload (credentials, [video1, video2]).then(console.log)

// OR
// This package uses Puppeteer, you can also pass Puppeteer launch configuration
upload (credentials, [video1, video2], {headless:false}).then(console.log)

// Refer Puppeteer documentation for more launch configurations like proxy etc
// https://pptr.dev/#?product=Puppeteer&version=main&show=api-puppeteerlaunchoptions

fixed with npm install --save youtube-videos-uploader


linkerd-viz assumes marathon master runs on localhost

In prometheus-mesos-marathon.yml line 11:
marathon_sd_configs:
  - servers:
    - 'http://localhost:8080'

should be changed to:
marathon_sd_configs:
  - servers:
    - 'http://marathon.mesos:8080'

To reflect other linkerd mesos-marathon examples.
You can also modify the linkerd-viz.json under mesos-marathon to use add-host parameter if that dns entry will not resolve:
{
  "id": "linkerd-viz",
  "instances": 1,
  "cpus": 1.0,
  "mem": 512.0,
  "acceptedResourceRoles": ["*", "slave_public"],
  "maintainer"<EMAIL_ADDRESS>  "container": {
    "type": "DOCKER",
    "docker": {
      "image": "buoyantio/linkerd-viz:latest",
      "parameters": [
        {
          "key": "add-host",
          "value": "marathon.mesos:<IP_ADDRESS>"
        }
      ],
      "forcePullImage": true,
      "network": "HOST",
      "privileged": true
    }
  },
  "args": ["mesos-marathon"],
  ...

See PR #28

Thanks, @smparekh !

There should also be a documentation update on the examples to indicate the change if the mesos master and marathon slave node are on different instances. I just used a random IP but that should be pointed out as a configurable value.

Hi @smparekh ! We've just released linkerd-viz 0.1.4, which now supports a MARATHON_HOST environment variable. We think this addresses your use case. Let us know if you have any additional questions or comments. Thanks again for filing the issue!


Refactor ChangePassword

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/211242
Tests

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

Log into an account on NewDot
Go to Profile > Security > Change Password
Enter a wrong password and a new password
Make sure you see the error displayed and that the api response contains the onyxData

{"onyxData":[{"onyxMethod":"merge","key":"account","value":{"error":"Your password changes could not be saved because the old password entered is incorrect."}}],"jsonCode":200,"requestID":"mV4I24"}

Enter the correct password and a new password and everything should work.

[x] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

PR is ready for review, should be reviewed and tested alongside: https://github.com/Expensify/Web-Expensify/pull/33885
pulling in @iwiznia since you said you had time for refactor reviews 😄

Refactored to use the new command. Here is the video:
https://user-images.githubusercontent.com/7016692/172562142-c38e644d-9a35-4508-b860-073845ce9b3d.mov

Also While testing this, I observed something interesting(not sure if it is a bug) but once I changed the password (and got a confirmation) I clicked on the back arrow and tried changing the password again and it shows Session expired error and this is nowhere visible on the UI just in the response data and spinner is in running state. But I didn't have to log in again I refreshed the page and everything worked fine.

Hmmm, that's interesting, although I don't think it's related to this PR.

While testing something on NewDot observed something which I think this PR is missing. Once when we are done with changing the password when we try changing the password again it does give us Session expired error but then it makes a subsequent call to Authenticate command and then recalls the ChangePassword command which is not the same for this PR as it keeps calling ChangePassword which returns Session expired error.(All this is done on main branch)

Hmm the only explanation I can think of is b/c we're using API.write() instead of the deprecated API.

Either way, I'm waiting on the web PR to be complete then I'll test this again and try to figure it out.

One idea is to just force all requests in the write queue to have a shouldRetry true if they are called via API.write()
https://github.com/Expensify/App/blob/07fabcf6c2b033faedb5215e2c9ddcc195fe98fc/src/libs/Network/index.js#L38-L39
Looks like these params are no longer included, but the reauthentication middleware still looks at them.

Alright, updated and retested, everything should be fine now

https://user-images.githubusercontent.com/32969087/174670367-41401540-ee36-4d38-b629-cf0bef9f2435.mp4

Yeah @marcaaron what you posted is the expected behavior.
The first call to UpdatePassword returns 407 (unauthenticated) so it authenticates, then calls UpdatePassword again.
Same as prod.

Yep, that is expected behaviour.

Ok I was confused but I think what happens is....

Call UpdatePassword once (returns 200 but your authToken gets invalidated)
Call UpdatePassword a second time and you will have to first reauthenticate and then call UpdatePassword again

Linked Web-E PR is on production so gonna merge this one 🚀

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @marcaaron in version: 1.1.79-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add document IsPinned state to both DocumentSnapshot and OpenDocumentOptions

When getting GetOpenDocumentsAsync we can't tell if the document is pinned or not.
Same thing, when calling OpenDocumentAsync we also can't specify if it should be pinned or not.
Please add Pin states (IsPinned) to DocumentSnapshot so we can know if it's pinned or not, and also when opening a document to specify whether it should be pinned as well (probably inside OpenDocumentOptions)

Thank you for your feedback! We've created a suggestion ticket for this issue so folks can upvote it: https://developercommunity.visualstudio.com/t/VisualStudioExtensibility-Add-documen/10696442. Closing this issue on GitHub


Measurables() query should accept a a measuredByAgentId

If a measuredByAgentId is entered, then it only returns measurables that have gotten measurements by a specific agent.

This replaces this previous issue:
https://github.com/OAGr/foretold/issues/114


Test suite: Fix versionbits.

This fixes all the failures in test_versionbits.  There are also some more changes to reflect that Susucoin is 1950/2000 and not 1916/2016 like Bitcoin.  These seem to have no effects on testing so they're included in the pull request.

Solid. Thanks!


Request: implement InputTake and InputLength on proc_macro2::TokenStream

Prerequisites

Rust version : rustc 1.37.0-nightly (8ebd67e4e 2019-06-27)
nom version : 5
nom compilation features used: None

Request
Hello! I was wondering, would it be possible to implement InputTake and InputLength on a proc_macro2 TokenStream?
I am not sure what issues there are with using nom directly with procedural macros, but TBH I would like to be able to take advantage of the features that TokenStreams give us: spans, automatic parsing into groups, etc.
Thank you!

for cases like this, it's better to have a newtype in your crate (ie, struct MyTokenStream(proc_macro2::TokenStream)) on which you would implement the trait


Update unit-tests-for-generic-methods.md

move to code

@noctwolf : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@gewarren : Thanks for your contribution! The author(s) have been notified to review your proposed change.


400 Bad Request

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
When I use mailgun action, my Fastfile content is following:

 after_all do |lane|
    # This block is called, only if the executed lane was successful

      mailgun(
          postmaster: "sandboxxxx.mailgun.org",
          apikey: "key-xxx",
          to<EMAIL_ADDRESS>          from: "xxx",
          reply_to<EMAIL_ADDRESS>          success: true,
          message: "Mail Body",
          app_link: "http://www.myapplink.com",
          ci_build_link: "http://www.mycibuildlink.com",
        )
    end

  error do |lane, exception|
     puts "Failed Deployed!"
  end

  But something wrong with the error : 400 Bad Request.

 my resolutions:
 1. i can send through Curl, but not in fastlane

  curl -s --user 'api:key-xx' https://api.mailgun.net/v3/sandboxxx.mailgun.org/messages -F from='Mailgun Sandbox<EMAIL_ADDRESS>-F to='xiawei<EMAIL_ADDRESS>-F subject='Hello yinglong.zhang' -F text='Congratulations yinglong.zhang, you just sent an email with Mailgun!  You are truly awesome!'
{
  "id"<EMAIL_ADDRESS>  "message": "Queued. Thank you."
}%

2. try below settings in mailgun

Security Settings For Outgoing Mail
Certificate Verification Not Required

it not works for me

@xwgit2971 Created a fix for this ^


confgenerator: Add default_self_log_file_collection setting.

Description
Implement configuration to allow user to enable or disable sending fluent-bit self logs to Cloud Logging. The default value is true.
global:
  default_self_log_file_collection: true|false

Details :

Fluent-bit logs are still being stored locally.
Sampling of fluent-bit self logs to be sent to Error Reporting cannot be disabled.
Adds a default_self_log_file_collection feature to feature_tracking.
Created three unit tests to verify generated self log fluent-bit configuration.

Related issue
b/307322933
How has this been tested?

Checklist:

Unit tests

[ ] Unit tests do not apply.
[x] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[x] Integration tests have been added/modified and passed for this PR.

Documentation

[ ] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

Discussed offline with @avilevy18 and @braydonk about changes and integration tests. Decided to keep integration tests to verify the functionality of feature.

The current test failures in SLES 15 and RockyLinux9 are unrelated to this PR. Merging PR.


Run 'guix describe' by default.

It is easy to miss the channel information in the installation log.
Adding a guix describe step is useful to access the exact channel information for a given artifact, in case it needs to be reproduced in the future.

Errh, derp.  I did not understand why the CI did not print anything until I saw b476f0abb9a62a45c2719fcf5a2e3e5e5a8425a6. And tried some hacks to make the test use the current branch...
Anyway, you can see it in action here: https://github.com/mbakke/mreg/runs/2494580212?check_suite_focus=true
It's not pretty, but it's useful because it shows the exact commits and not just the branch.

Yeah, I fell into the same pitfall many times… Do we have to use the full path when calling guix here? I was hoping setting the path above is enough?

It works without the absolute name indeed, fixed.
Currently the output gets interleaved with the locale warning.  It would be good to fix that eventually, but I don't mind for now.

Merged, thanks!


MySQL Error: connect ECONNREFUSED <IP_ADDRESS>:3306

I'm getting this error and my server stopped working.
{ Error: connect ECONNREFUSED <IP_ADDRESS>:3306
at Object._errnoException (util.js:992:11)
at _exceptionWithHostPort (util.js:1014:20)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1186:14)
at Protocol._enqueue (node_modules/mysql/lib/protocol/Protocol.js:145:48)
at Protocol.handshake (node_modules/mysql/lib/protocol/Protocol.js:52:23)
at Connection.connect (/node_modules/mysql/lib/Connection.js:130:18)
at Object.<anonymous> (//config.js:15:12)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
code: 'ECONNREFUSED',
errno: 'ECONNREFUSED',
syscall: 'connect',
address: '<IP_ADDRESS>',
port: 3306,
fatal: true }

Hi @Nandhan-augment , the error you are getting there is from Node.js's network implementation. You can find more information about errors from Node.js at https://nodejs.org/dist/latest-v14.x/docs/api/errors.html#errors_common_system_errors

ECONNREFUSED (Connection refused): No connection could be made because the target machine actively refused it. This usually results from trying to connect to a service that is inactive on the foreign host.


polymer build LitElement project

Description

No JS is bundled, only one file, called index.html is put in the build output folder.
Versions & Environment

Polymer CLI: 1.9.3
node: 11.4
Operating System: Win/OSX

Steps to Reproduce
polymer init
1
polymer build

Expected Results
Polymer should bundle the element project to publish.
Actual Results
A index.html is placed in the build folder, seriously, why a HTML file? haha

See supported node versions here: https://polymer-library.polymer-project.org/3.0/docs/tools/node-support
Currently, LTS node 8.x and 10.x are supported

Uhmm, okay, by this:

We support all "Current" and "Active LTS" releases of Node.js

I thought 11.5 would be supported, as it is the "Current".
I'll downgrade to 10.x to see if this works.

Stills same result.
Also, I noticed that when running polymer init from CMD I got an error:

I installed polymer-cli through gitbash on Windows 10, could this be something related with that?


Added Kaalam Extension

Description
Added a new extension called Kaalam, which means Time.
This shows the current time in available date formats.
Type of change

New extension

Screencast
The extension has only one command which is Show Time

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing

Hi @pernielsentikaer ,
This extension can be used by designers and developers to copy the current time in any of the available formats. Which will give them an easy advantage.

Hi @heertheeswaran 👋
Thanks for the clarification 👍 , the code looks fine 🔥, I do have suggestions for you 🚚 :

Add PasteAction so it's possible to paste directly
When it's added, then you could add a preference to set the “default” action, let me know if you need example 😄

Request a new review when you are ready, feel free to contact me here or at Slack if you have any questions.

Hi @pernielsentikaer ,
Can you share me a example.

Sure! Take a look at #593

Hi @heertheeswaran 🔥
Do you need any help?

@pernielsentikaer Can you publish this? I will add those as an update to the extension later


How to get access to properties when using the onChange() function.

@boep1963 what properties you want to access? you can only access until value using the onChange function

HI,
Thanks for the reply. I want indeed access the until property (check the remaining time to send out a warning). This is how I implemented it
<CountDown
until={this.state.SB.Inspeeltijd}
size={this.state.SB.InspeelCompBreedte || 48}
onFinish={() => this.EindeInspeeltijd()}
onChange={() => this.changeColor()}
changeColor() {
??? How to access the value until
}
Regards,
met vriendelijke groet,
Pierre
---- Op za, 05 okt 2019 14:04:57 +0200 Talal Majali<EMAIL_ADDRESS>schreef ----
https://github.com/boep1963 what properties you want to access? you can only access until value using the onChange function
—
You are receiving this because you were mentioned.
Reply to this email directly, https://github.com/talalmajali/react-native-countdown-component/issues/60?email_source=notifications&email_token=AG44UKZ4YZOFKQCHPCT5633QNB7GTA5CNFSM4I4G7AD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANQ4YA#issuecomment-538644064, or https://github.com/notifications/unsubscribe-auth/AG44UK2APS7U3GZPZ4RZ3HTQNB7GTANCNFSM4I4G7ADQ.

@boep1963 onChange={until => this.changeColor(until)}


Install ec2-instance-connect

Issue #, if available:
Description of changes: this is to enable the new ec2 instance connect feature by default.
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-connect-set-up.html
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is awesome. What's the release cadence for the EKS AMIs?