Overworked library toward 3.0.0 release

fixed typos
updated README
updated Catch

Pull request checklist

[ ]  Changes are described in the pull request, or an existing issue is referenced.
[ ]  The test suite compiles and runs without error.
[ ]  Code coverage is 100%. Test cases can be added by editing the test suite.

I noticed that you were cleaning up spaces around the < and > in templates, but there are still a few left.  587, 592, 621, 885, 1000, 1614, 9909

@gregmarr This is due to Artistic Style which sometimes seems to interpret < and > as comparisons... :-(

Oh, it's an auto formatter?

Yes, see http://astyle.sourceforge.net. I am using it for some years now and have not found an equivalent Clang-format style. "My" style is implemented in the make pretty target.

Coverage remained the same at 100.0% when pulling fb8482db767bf46c65c56a984238ed8564e829de on feature/spelling into f7ae143a93a035cb25cedc79f3113b4f5701d1ad on develop.

Coverage remained the same at 100.0% when pulling fb8482db767bf46c65c56a984238ed8564e829de on feature/spelling into f7ae143a93a035cb25cedc79f3113b4f5701d1ad on develop.

Coverage remained the same at 100.0% when pulling 9a70c60fa5edc8d4a28cc1ee57e6679cade3bef6 on feature/spelling into f7ae143a93a035cb25cedc79f3113b4f5701d1ad on develop.


Displaying statistics for Index command

Context / purpose
The indexing needed some enhancements
Description

Added changes to display statistics
Added command report and how a user can search his index

How was this PR tested?
I Ran the command quickwit-cli index --index-uri 's3://quickwit-dev/evance/van2' --input-path ./wiki-articles-10000.json
Checklist
Remove or complete this list if required.

[x] tested locally

@fulmicoton  I have updated the branch.
I recall you mentioned we could use a task at the top level for cli commands to display info in the console. But I just stuck with the task at the indexing. you can best design that abstraction if we need it.
I used tokio::sync:watch to listen to task completion since I am using a loop for displaying the statistic. It required a king of single-producer-multi-consumer channel.

@fulmicoton from your comments, this is what we will end up with in index_data_cli?
   let (task_completed_sender, task_completed_receiver) = watch::channel::<bool>(false);
    let indexing_future = task::spawn(async move {
        index_data(metastore_uri, index_id, params).await?;
        task_completed_sender.send(true)?;
    });
    let reporting_future = start_statistics_reporting(task_completed_receiver);

    try_join!(indexing_future, reporting_future)?;

Regarding the Arc<Statistics>,  should we create it here and pass it down to the index_data ?
Also, are you planning of making it fully optional Option<Arc<Statistics>> ?

@evanxg852000 Exactly!

Also, are you planning of making it fully optional Option<Arc>

Let's force the user to submit one.
In the future, we can try to make the interface a tad user friendly... Probably by introducing a listener interface.


Issue migrating to v5 for existing endpoints from v3.

Hi!
Me and my team are having some difficulties using the v5 API. We are migrating from v3 and are missing a few critical metrics that don't seem to be in v5. The metrics we're noticing missing include.

User follower_count (v3/users/me/)

Pin summary metrics like engagements although the documentation mentions them in the response samples. (/v5/pins/id/analytics)

We want to migrate to the new version at the same time to move scopes to the new v5.

Could you help us with these? Thanks
Matt

Thanks for your questions about the v5 API, Matt. I'll see what our API product & marketing folks have to say and get back to you.

Thank you! We assumed the pins /analytics and user /analytics endpoints would be consistent so it's caused some confusion.

Sorry for the delay in responding! I'll ping our product & marketing folks again...

Hello @mattnwa! Sorry for the delay in my response. Here's what our product team says...

The issue with Pin summary metrics sounds like a bug. We would appreciate it if you would file a ticket in our Help Center: https://help.pinterest.com/en/contact (I just looked at this page and think that Pinterest API and Developer Tools / API Technical Support / Pinterest API v5 will get you to the right place.)
We're still working internally to figure out follower_count. I'll try to remember to post to this issue again if I see progress internally.


Is Renpy 7.x supported?

Trying to set the path for D:\Program Files (x86)\renpy-7.6.0-sdk but getting an error saying Path is not RenPy SDK. Is Renpy 7.x supported?

It should be supported. Can you send me a screenshot of the folder in question?

Does lib/py3-windows-x86_64/python.exe exist here? This is what the extension looks at to determine if it's a valid SDK or not

No. Sort of makes sense as python 3 was added in the 8.X version.

Should be a pretty simple fix then, just need to look in both of these directories. Thanks for reporting this bug!

Combing over the code, supporting Python 2 would be a pretty significant maintenance burden. I'm not sure how many people are still on Ren'Py 7, so it might be valuable to support this

I can understand that. Thank you for looking into it.

Unfortunately it looks like Ren'Py 7 and below does not have a websockets client installed, so implementing the app as it currently exists is impossible

More half formed thoughts. An earlier implementation of this program used IPC to do communication. Though I ended up nixing that so that launched programs didn't use pipes. Going that routes makes async/await a bit more wacky, and you might need an intermediate process that won't quit with Visual Studio Code. Neither option I like very much for Renpy 7, which is on its way out with the next release.
I'm working on a minimal update to support launching and quitting on Renpy 7, but it will not support any of the RPE features. I'll see where it goes from there.

I went ahead and updated to 8.3.0. Expected many errors as I tried doing it once before and couldn't load a single save, but surprisingly it works very well now. I managed to resolve all or most issues in about 2 hours work.
Tested the extension and it works flawlessly too. As you said, difficult to say how many people are still using it but it may be quicker for them to simply update it.
Thank you for the hard work.


Can't export CSV getting errror "i.split is not a function" when series name is an array

Description
Steps to Reproduce

Open sandbox
click toolbox
click Download CSV

Expected Behavior
Downloads CSV
Actual Behavior
Error in console: "i.split is not a function"
Screenshots

Reproduction Link
https://codesandbox.io/s/bitter-browser-5z3qc8

I'm having the same error with this:
https://codepen.io/andreabrioschi/pen/PoRNXKr

@ordago Why are you setting the name of the series to an array? It should be a string. The series name is not expecting an array.
@AndreFra96 the name is expecting a string, not a number.

@brianlagunas  I remember seeing in the docs somewhere. Using an array for series whose name were too long would place the second item on the array in a new line.

@ordago I was unable to find any code that handled the name as an array. If you can find that doc, I would appreciate it. It's possible is was a feature that wasn't implemented fully.

hey @brianlagunas, maybe I mixed series names with categories
https://apexcharts.com/docs/multiline-text-and-line-breaks-in-axes-labels/

@ordago yeah, it looks like it. Glad we figured it out.


interferes with other modules, do NOT use this module unless it's fixed

this module interferes with other node modules, like "later" (@breejs/later)
please don't do stuff like:
Date.prototype.s = function (a, b) { return b instanceof Date && this.valueOf() === b.valueOf()
this makes the whole module unusable

Hello @nitramreffehcs,
I don't know if this was you intended but you come off as aggressive and not particularly helpful. While your concern is understandable you could at least remain courteous and try offering a solution.
Now related to your issue:

This date prototype override issue is indeed a bad practice but is unfortunately not of my own design. Rather the blame lies with the way Clojurescript compiles (or used to compile, this code is quite old now) the Clojure files to JavaScript. Maybe it's fixable but I don't have a computer able to upgrade to newest java/clojure etc. without risking messing up something. If you are so enclined, you can try installing lein on your end and run the build.sh script using a recent clojure/clojurescript combo and see whether it fixes this particular problem. If you do find it does, I would appreciate a PR with the fixed JS files so I can draft a release on npm.
This library is deprecated for JavaScript, as can be read on its documentation here for instance. You should really use Talisman instead. I have updated the README to reflect this and deprecated the package on npm so no doubt persists.

I wish you a good day,


question about change the rotation to get the novel view in image custome

Maybe this issue is relevant to yours:
#16
Best,
Felix


Ubuntu setup needs short update

The current tutorial on Ubuntu has fallen behind on reality. Problem is, that the repository version of Flatpak on Ubuntu is not kept well up to date. As such, the guide here needs updating:
https://flatpak.org/setup/Ubuntu/
Proposed change
Drop the first bit that tells users on 18.10+ to install using the main repository.
The PPA from Alexander Larsson is the most reliable way for end users to get Flatpak updates.
It's almost as if Ubuntu has a competing platform

Sorry for the late answer but this issue should be filled here: https://github.com/flatpak/flatpak.github.io
I think @ahayzen maintains the flatpak in Ubuntu and he might know the best configuration


FoundationEssentials: correct the template path for Windows

We need to use the FSR for the template path to ensure that we are giving the underlying system a valid path. This was causing a spurious failure with the MSVC runtime due to the errant leading /.

I think that a different change allows this to work - going to close this off for now.


Create SA for the operator

ref: #189

@camilocot can you get the conflict fixed up? @spahl @hasbro17 any chance we can push this one up, we have code that does this but could be removed if we pull this in ;)

@CSdread conflicts fixed.

do we know what the side effects are for folks not yet using SA and RBAC would the functionality be the same?

@camilocot so a few things, first if you would read the contributor document in the repo root, the format for naming commits and PRs, can we get you to fix that part?

@CSdread Sorry I've been busy with other reviews and the controller-runtime refactoring work. Will try to prioritize this in this week.
/cc @AlexNPavel we need to consider how this affects the test-framework.

The comment on line 58 of commands/operator-sdk/cmd/test.go should be updated: https://github.com/operator-framework/operator-sdk/blob/c84b1a90fcd918ddcdbe2c56ae78b6a15285a86f/commands/operator-sdk/cmd/test.go#L58

The user guide (doc/user-guide.md) needs to be updated as well

lgtm

lgtm as well

@hasbro17 this is ready for merge we believe

LGTM


Clean the rails log directory in the kickstart post

Some things that are done during the build process have the potential to print to the logs.
None of this should be present when the machine is deployed for the first time.
https://bugzilla.redhat.com/show_bug.cgi?id=1286793

@miq-bot add_label darga/yes, bug

👍 LGTM


Downgrade @github/combobox-nav

The v2.3.0 update caused to always scroll to the suggestion menu, where it previously wouldn't work at all or only scroll when it wasn't in the viewport.
Ref: https://github.com/github/text-expander-element/issues/50
Ref: https://github.com/github/combobox-nav/pull/75
Resolves https://codeberg.org/forgejo/forgejo/issues/1990

(cherry picked from commit 27145be211ff782afe0910adbe200f126961f150)

Did someone look into providing a reproduction to upstream?

For reference: this PR is closed because upstream has a correct fix, so no need to downgrade.


Chore: logging

Coverage increased (+0.7%) to 98.881% when pulling e6d8fb630abb5fa2e8aea0e4a2317feb7660b7df on chore/logging into 75d957cdded93c4ec2327fbcabb3a80b65c52024 on master.

Regression in performance.


Trying to load view for ValueConverter if there is more than one export from file

I'm submitting a bug report

Library Version:
1.1.4

Language:
all

Current behavior:
The following value converter declared in upper-value-converter.js works:
export class UpperValueConverter {
  toView(sth) {
    return sth.toUpperCase();
  }
}

However, if you add another export from this file, aurelia tries to load upper-value-converter.html which breaks the application:
export class UpperValueConverter {
  toView(sth) {
    return sth.toUpperCase();
  }
}
export class ConvertedValue {}

Making the first export default does not help. Adding the upper-value-converter.html helps, but it is not used.
Expected/desired behavior:
It should be possible to define and export other classes in the same file where the value converter is.
Rationale: I would like to define input & output values as classes and it seems reasonable to put them in the same file.

When a module is imported using <require from="./upper-value-converter"></require>, the ModuleAnalyzer classifies each of the exports as a custom element, custom attribute, value converter, etc. Basically everything is assumed to be a custom element unless it fits one of the naming conventions or has an explicit resource type defined via a decorator (eg @customAttribute('foo')).
Will need @EisenbergEffect to confirm but from what I know of the system I don't think it's possible to mix resource exports (custom elements, attributes, converters, etc) with plain old class exports unless some sort of @notAResource decorator is introduced.
One thing you could do is skip exporting the ConvertedValue class but I doubt that will be helpful for you. If you're using typescript you could use an interface instead (export interface ConvertedValue) because they are transpiled away.

Yes, you don't want to export non-UI items from a UI-related module. When you use require, it will try to interpret those exports in terms of the templating engine.

Ok, I supposed it is forbidden because of technical stuff.
But have you seen that it breaks also when you mark the export as default (i.e. export default class UpperValueConverter)?

That sounds like a case that we should handle. The problem with marking something as default is that that changes the export name. I'm not sure if we can support it with naming conventions or not. Can you create a separate feature request to support default exports?


Will the class Encryptor add two methods contains table and column?

Our company use the encrypt for field's encryption and decryption, and we cannot use different aes-token because the class: AESShardingEncryptor uses only one key: aes.key.value , so we cannot know the aes-token and table's or column's mapping like this:

table
column
token

tb1
col_1
k1

tb1
col_2
k2

tb2
col_1
k3

because the class AESShardingEncryptor is this:
public final class AESShardingEncryptor implements ShardingEncryptor {
    // ignore other methods
    private byte[] createSecretKey() {
        Preconditions.checkArgument(null != properties.get(AES_KEY), String.format("%s can not be null.", AES_KEY));
        return Arrays.copyOf(DigestUtils.sha1(properties.get(AES_KEY).toString()), 16);
    }
}

So I expect the Encryptor class like this class
public interface Encryptor {
    void init();
    String decrypt(String cipherText);
    Object decrypt(String cipherText);
    // add the follow methods
    String decrypt(String table, String column, String cipherText);
    Object decrypt(String table, String column, String cipherText);
}

And replaced all the internal method call with it.
Current dependency is :
<dependency>
    <groupId>org.apache.shardingsphere</groupId>
    <artifactId>sharding-jdbc-spring-namespace</artifactId>
    <version>4.0.0</version>
</dependency>

Or Can you give me another Solution to solve this question?

@xiaoma20082008
Hi, what you expected is to use different AESShardingEncryptors for different columns of the same table?

@xiaoma20082008
Hi, what you expected is to use different AESShardingEncryptors for different columns of the same table?
The AESShardingEncryptor interface's methods about encrypt and decrypt should transfer tableName and columnName  just like my code above !

Hi @xiaoma20082008
The responsibility of Encryptor is only to encrypt(xxx) and decrypt(xxx), and there is no need for Encryptor to understand what the column and table are. Notice, it is just a encryptor.
If you wish to use different encryptor with different property aes.key.value, you can make good use of configuration, e.g,
encryptRule:
  encryptors:
    encryptor_aes1:
      type: aes
      props:
        aes.key.value: 123
    encryptor_aes2:
      type: aes
      props:
        aes.key.value: abc
  tables:
    t_encrypt:
      columns:
        user_id:
          plainColumn: user_plain
          cipherColumn: user_cipher
          encryptor: encryptor_aes1
        order_id:
          cipherColumn: order_cipher
          encryptor: encryptor_aes2

Thank you,I'll try it @tristaZero


delete-branch-schema

There should be a command delete-branch-schema from hive-ms if i don't want to use the branch and have deleted it from lakefs

we will be running dbt commands. if the command fails we will delete the branch in lakefs. in this case we also need to delete all the tables that were create in hive


Can I display multiple google calendars?

Thank you very much for your useful calendar!
Currently, I am using multiple google calendars in one google account such as "Private schedule" and "Working schedule". Can I display multiple google calendars onto your calendar?

Yes, you can. Are your both calendars enabled? Ensure to enable the both calendars on your web interface.

I found that I was not able to get my google calendar data even though I set google access token...
However I think this issue is affected by proxy environment.
I am sorry to bother you. I will re-check my settings.

Fine.


[Issue] Combinational Generation with Dynamic Prompts

Current Behavior
When PPP is active, Combinational Generations in the Dynamic prompts tab does not function, and will only generate a single image.
Does not seem to put an error in console.
Expected Behavior
When Combinational Generations is checked, every combination of prompts from both wildcards and dynamic prompts({prompta|promptb}) is found and is used to generate images.
Steps to Reproduce
Please provide detailed steps for reproducing the issue.

Enable PPP
Create prompt with wildcards or dynamic prompts with multiple choices.
Attempt to use Combinational Generations under Dynamic prompt tabs.

Webui Forge version: [f0.0.17v1.8.0rc-latest-278-gbfee03d8]

The only thing that could be happening is that if PPP it is loaded before Dynamic Prompts and the "Process wildcards" option is enabled, it will process the wildcards/choices before Dynamic Prompts gets the prompt, so when it gets the prompt there are no more choices to do the combinatorial.
Try disabling that setting, and if it works you can try to load the extensions in the correct order you need. They load in alphabetical order, just rename one of the folders.
Note that PPP can now replace DP except for some specific things like the combinatorial mode.

Update fixed the issues I was having. Thanks for your help, and thanks for making this useful extension!


PCL installation - Error: Building package pcl:x86-windows failed with: BUILD_FAILED

CMake Error at scripts/cmake/vcpkg_build_cmake.cmake:202 (message):
Command failed: F:/YK/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe;--build;.;--config;Release;--target;install;--;-v
Working Directory: F:/YK/vcpkg/buildtrees/pcl/x86-windows-rel
See logs for more information:
F:\YK\vcpkg\buildtrees\pcl\install-x86-windows-rel-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
ports/pcl/portfile.cmake:70 (vcpkg_install_cmake)
scripts/ports.cmake:71 (include)
Error: Building package pcl:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: pcl:x86-windows
Vcpkg version: 2018.11.23-nohash
Additionally, attach any relevant sections from the log files above.

See logs for more information:
F:\YK\vcpkg\buildtrees\pcl\install-x86-windows-rel-out.log

Please attach logs.

install-x86-windows-rel-out.log

I found this in your build log, is your device storage full?

F:\YK\vcpkg\buildtrees\pcl\src\pcl-1.9.1-80abf3ea0d\surface\src\surfel_smoothing.cpp : fatal error C1085: Cannot write compiler generated file: 'F:\YK\vcpkg\buildtrees\pcl\x86-windows-rel\surface\CMakeFiles\pcl_surface.dir\src\surfel_smoothing.cpp.obj': No space left on device

oh,maybe, that‘s it. The remaining space is really insufficient.Thanks, i will try.


Revert fe9862b3941(accidentally pushed to master)

I accidentally committed fe9862b3941 before review. I tested that it works, but it skips our review process and it should be followed by one more commit to close #3318. Can you revert it for now? Ping @whit537 @Changaco @rohitpaulk

I had already merged #3364 before seeing this, so instead of force-pushing fe9862b3941e795ae8f16c2deb9e29733d3eade5 off of master, I reverted it in 461588a644c14333ac5719525525e2f4637705a6. Please be more careful in the future.

@techtonik P.S. Changaco is no longer part of the Gratipay team, so please let's not ping him any more.

That's sad news. I wish I could be available to discuss the issue and propose an alternative. No time for sustainability. Redirected him a $2 pension from my take.
As for Git, it occasionally happens. Can we add a hook script that prevents commit to trunk unless some keyword it present?


CI fails in retrieval

had this in CI with "instant-chunk-rapair" branch for mac-build
=== RUN   TestDelivery
##[error]    retrieval_test.go:133: unexpected balance on server. want 10 got 0
--- FAIL: TestDelivery (0.00s)

duplicate of https://github.com/ethersphere/bee/issues/721


added support for LITA_CRED

Just sharing back - I needed to share credentials for some of my scripts. This will take credentials stored in redis and share them with the script in a LITA_CRED environment variable. I generally will set this to the username:password, base 64 encoded, but it's up to the specific script to define a format it would want for a credential.
I generally add the credentials to the lita redis DB out-of-band for security considerations. An alternative might be a script that takes credentials via some sort of DM.

Hello and thanks for the PR!
First, looks like this adds support for ignoring files like described in #15. Two birds in one PR?
Second, looks like this LITA_CRED variable is useful. Especially for the more security conscious among us. I've made some in-line comments to discuss this further.

LOL - I'm sorry, the ignore files pull support was included inadvertently, and is not well tested. But they seem to work for me, feel free to include or reject them. (I was scratching an itch)
And yes - initially, I just set the userdata (I used a base-64 encoded blob of login:password) via redis cli, but I also have done so via a http route, and am playing with a command (that I have not figured out how to add to lita-cmd directly). Here's what I have in my lita_config.rb right now (Eek is the bot name):
`module Lita
module Handlers
class Eek < Handler
http.get "/cred/:group/:username/:cred", :cred
route(/^addcred\s+(.+)/) do |response|
group, cred = response.matches.flatten.first.split(' ', 2)
Lita::User.create(response.user.id, {"cred-#{group}" => cred})
response.reply("Saved")
end
  def cred(request, response)
     group = request.env["router.params"][:group]
     username = request.env["router.params"][:username]
     cred = request.env["router.params"][:cred]
     user = Lita::User.find_by_mention_name(username)
     Lita::User.create(user.id, { "cred-#{group}" => cred })
     response.write("Saved")
  end

  Lita.register_handler(Eek)
end

end
end`
That lets someone on localhost use curl to add arbitrary group/name/creds for anyone, or a user to add their own creds via chat (they choose the group, but the name is from their login). I am a bit leery about adding the creds via chat, but it's all about tradeoffs between security and usability. I do note I am using a password-protected redis, on a secure server in a secure environment; it would be nice to do something really secure, but most of the stuff I want to wrap up does login/password auth, so it's not really an option.
This would be far better integrated into lita-cmd proper, but I was unable to figure out how quickly and had to move forward with the stuff I wanted to use lita-cmd for :-)
The actual data is stored in the user profile, alongside mention_name and so on. Here's my data (redacted, of course):
`localhost:16379> hgetall "lita:users:id:UXXXXXXP"

"mention_name"
"tombortels"
"name"
"Tom Bortels"
"cred-ad"
"[base64-encoded-credentials-for-ad-group-commands]"
"cred-vm"
"[base64-encoded-credentials-for-vm-group-commands]"
"cred-test"
"waldo"
"cred-dns"
"[base64-encoded-credentials-for-dns-group-commands]"`

Okay, good background info. I agree that there is need to have some sort of credentials to use with these scripts. What I do personally is have a dir structure that looks like this:
lita/
├── scripts
│   └── my-script.sh
└── scripts-data
    └── my-script.env

And I'll just source the .env files or use the dotenv gem if I'm using Ruby.
However this assuming that my Lita instance is secure (which it is secure enough in my office). It seems that in your case you don't trust the Lita VM as much as I do.
I'll need to mull this one over for a day or so. I like the feature, I'd like to generalize it a bit. And I don't think that I'd like to include Redis k/v management as a part of this plugin. So if people can add in keys to Redis out-of-band, I think that would make the most sense.

My use of redis to store state is just that when running under docker, local files may or may not persist, or even be writable - the only place I know I can store data to is redis. Putting all of the state in one place makes sense, especially considering that one place is already a hard-requirement for lita to begin with. But yes - I agree, adding credentials via the redis-client is the most "secure", in that someone with that access owns the whole thing anyway. As for trusting the lita vm - I frankly don't trust anything. That way, no disappointment :-) (the only reason I do it at all is defense in depth. Hopefully with isolated vm and password protected redis and the environment it runs in, there are sufficient barriers for a bad guy to get stopped on the way...)

I didn't want to patch this PR just yet, but I've implemented these changes on a branch: pr/16. Take a look and let me know what you think. Specifically the extract_creds method.
With this I expect that you can set a key, say, cred-devops-aws_secret_access_key. And it will present itself to the desired script as the env var AWS_SECRET_ACCESS_KEY. This way you'll be able to set an arbitrary number of creds.

So - breaking it out into N credentials rather than one blob of them, and shenanigans so that it's presented as environment variables the scripts traditionally expect, like AWS_SECRET_ACCESS_KEY? Excellent idea! Anything that streamlines dropping in existing scripts is good in my book.

👍 Glad you like it.
I unfortunately don't have automated tests yet (really should look at https://github.com/litaio/development-environment and some RSpec...), so I'll need to do some manual verification. Then document the feature.
Just as an FYI, I wouldn't expect it merged until next week. But a release should follow after that.

Closed in favor of #18.
Thanks for the idea and the PR!


Issue/readd composer features

Description
Add back reverted features/improvements regarding smart composer
closes Add ticket reference here
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[x] Changelog entry
[ ] Code is clear and sufficiently documented
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

I will merge it next week, as I want to add labels on hover functionality

Processing this pull request

Merged into branches iso7, master in f62ec19af1565b601dfe1a744cea8ce3067fcc1d


Add Predefined Commands Feature

I would be useful for the user to save predefined commands that they can just click to execute on the remote system.

First iteration: https://github.com/mmckinn6/JETSSH/commit/17f350adeeb798a3c6be84f0dff8229fd688a0a5


Canes + Cane Blade for Syndicate Librarians

About the PR

Added canes to the CuraDrobe. I also added a cane that can be unsheathed to reveal a blade for syndicate librarians. Un Gurde! Have at thee!
Why / Balance

More syndicate melee weapons are nice, also something for librarians. Maybe someone in the future can make a old trait where if your character is too-old they need a cane? Or just something to be the stations pimp.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame
Changelog

:cl:

add: Added Canes to the CuraDrobe and Cane Blades for Syndicate Librarians

shooting cane for mime?

shooting cane for mime?

No but I'm thinking on making a shotgun umbrella and umbrellas being a thing.

is there a normal cane for normal librarians?

oh my god, yeah, more secular stuff.

is there a normal cane for normal librarians?

 Up damage to 20 per slash\or give it more reflection, let it apply as hell more bleeding or some special ability blocking etc. I can give my 5 tc to assistant to get my free 6 tc stanbaton AK boxer gloves.
 Up damage to 20 per slash\or give it more reflection, let it apply as hell more bleeding or some special ability blocking etc. I can give my 5 tc to assistant to get my free 6 tc stanbaton AK boxer gloves.

 Up damage to 20 per slash\or give it more reflection, let it apply as hell more bleeding or some special ability blocking etc. I can give my 5 tc to assistant to get my free 6 tc stanbaton AK boxer gloves.

I think there is a point that the stats are kinda underwhelming right now. Compare the damage to other stealth/improvised weapons in the uplink:

Cybersun Pen: 15 damage, very silent, 1 TC
Syndie Toolbox: 20 damage, bonk, 2 TC
Surgical bag: Multiple tools like the saw, 15 damage, 4 TC

My suggestion would be to bump it down in TC and bring it in line with the other options damage-wise. Maybe 17 slash, since it is on par with the pen for concealability but can't edit stamped documents? If you want to make it have some combat flair, you can decrease the damage but give it a faster swing speed to keep the DPS high.
All that being said, cool weapon!

I added changes to it's stats. Removed the reflect and buffed the damage 12->14 and attack rate 1.2->1.5. If there's need for more stat changes, I can do so.


WebSocket support ?

I'm happy with APIFlask for most endpoints.
In my project, we do have a few WebSockets endpoints, and there I do not know how to use APIFlask:

how do i register WebSocket endpoints? Also with @app.route() ?
how can i validate the websocket messages? If not possible to validate the messages, is it possible to define their structure with @app.input(Schema)? This needs to be applied to the messages, and not to the connection.

Hi ! @sylvain-ri
Like Flask, APIFlask does not have direct Websocket support yet.
You can try with these flask extension:

Flask-Sock — Flask-Sock documentation
Flask-SocketIO — Flask-SocketIO documentation

And the  validate the websocket messages， not supported yet.


Api to discover keyboard shortcut strings

Originally posted by @charris-msft in https://github.com/microsoft/vscode-jupyter/discussions/9761#discussioncomment-2650690

Ahhh! I should have looked there!
I do still think it would be beneficial to move the buttons, because the screen is much more discoverable than the keyboard shortcut menu. But I would also love to see the tool tips show the keyboard shortcuts (where available) too.

Because users can adjust keyboard shortcuts, in order for a webview to show tooltips for shortcuts and those shortcuts are OS dependent, we're looking for a way to obtain a string we can show for a tooltip when the user hovers over a button or whatever.

Should this build on @daviddossett's UI toolkit? I believe it would be best to have <code-button id="myCommandId" /> and let us do the rendering. IMO Extensions shouldn't be bothered with retrieving, rendering, and listening of keybindings.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Fix some nits with nodejs

When I ran make it would always fail in the clean rule.

This is because there's a circular dependency.
I need to run yarn install to run yarn node-gyp clean.
Just remove that part since it's causing issues.

Remove node_modules in clean rule.
Update .gitignore with json trusted setup.

Every time I ran make it would reformat this file & show up in the status.

Reformat json trusted setup that nodejs wants done.

Build error I mentioned:
$ make
yarn node-gyp clean
yarn run v1.22.19
error Command "node-gyp" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [clean] Error 1

lgtm!


Fix exclude-path arguments on link checker action

I can't see why https://twitter.com/ is timing out, but if it is then we should probably add it to the .lycheeignore to prevent it from becoming a problem again in the future.
Does it make sense to exclude the whole path or is it sufficient to exclude the link?

Great idea @CarlosHSF99 🙌

Fixed .lycheeignore to use regex and added https://twitter.com (https:\/\/twitter\.com) to it.


Field properties changes

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP: changing LGTM is restricted to collaborators

In response to this:

Left a couple if comments, but it LGTM!

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mstemm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-minimal
3926485d452ceb763e5bd4333336e84361b9d723
link
true
/test build-libs-minimal

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mstemm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-minimal
3926485d452ceb763e5bd4333336e84361b9d723
link
true
/test build-libs-minimal

build-libs-bundled-deps
3926485d452ceb763e5bd4333336e84361b9d723
link
true
/test build-libs-bundled-deps

build-libs
3926485d452ceb763e5bd4333336e84361b9d723
link
true
/test build-libs

build-libs-with-chisels
3926485d452ceb763e5bd4333336e84361b9d723
link
true
/test build-libs-with-chisels

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 792ebfbac5fa34ef0ab8b4069b2a3183b27f96f5

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Simplify docker-compose syntax

Remove shell-style defaults (see below) from docker-compose files

Shell-style defaults allow overrides via .env and portal.env (env files)
Now only overrideable via portal.env

Still necessary for some settings that cannot be set from portal.env

eg volumes, ports

Shell-style defaults:
${FOO:-default value of FOO if not set}

@pbugni

Does this mean variable w/o the shell override syntax, defined in .env will be ignored?
Correct, "shell-style variables" (eg ${FOO}) are required if you want to change values in docker-compose.yaml with environment variables specified in the .env file

Do our docs need any updates?
No, we shouldn't need to. I've never had to override any of those defaults, and I can't easily think of a reason to


Mouse Input coordinates are wrong in fullscreen when hiDPI mode is enabled

Godot version
v3.5.stable.official [991bb6ac7]
System information
macOS 12.5.1 (21G83), Apple M1 Max MacBook Pro
Issue description
I was attempting to implement a simple dragging mechanic and noticed it worked fine in windowed mode but the mouse input coordinates went all wrong after making the game window fullscreen. Here's a video showing what happens on my machine when I run the attached sample project:
https://user-images.githubusercontent.com/453721/185809093-d823fbaf-c6f6-4f0a-8c3d-72d5e186005f.mov
Steps to reproduce
Run the attached project on macOS (no idea if this also happens on Windows) and then click and drag from the Godot icon. It should drag out a smaller godot icon that follows the mouse around and disappears when you let go of the button.
If I disable the "Allow hiDPI" project setting, then it appears to work fine in fullscreen.
Minimal reproduction project
Godot HighDPI Input Bug.zip

The project uses the 2d stretch mode, so you likely need to multiply/divide mouse coordinates by the automatically scale factor.

You likely need to multiply/divide mouse coordinates by the automatically scale factor

I appreciate the workaround, but why in the world should game code have to do this? Isn't handling this kind of stuff exactly what using an engine is for?

Duplicate of #34805.
The project uses the 2d stretch mode, so you likely need to multiply/divide mouse coordinates by the automatically determined scale factor.

I appreciate the workaround, but why in the world should game code have to do this? Isn't handling this kind of stuff exactly what using an engine is for?

I appreciate the workaround, but why in the world should game code have to do this? Isn't handling this kind of stuff exactly what using an engine is for?

There are likely some cases where having the unscaled mouse coordinates is useful, but I don't know which ones exactly. Scaling mouse coordinates automatically would also break all projects that rely on the current coordinate system, so this can only be considered for 4.0.


How do I use the huggingface assistant?

I dived into it immediately asking questions interactively to participate in the course, but the response was quite astray. I thought, it was focused RAG on this repo and the course.
What should I do, if I am not doing it right?
https://hf.co/chat/r/WfgeYo-

It's a little tricky because the course is too long to be passed into the context window, so the model has to somehow find the relevant part to answer your question. In this example, it couldn't retrieve the URL but I don't think this is a question about the course. Did it fail to answer questions about the course itself?

I thought, it will have context of the introduction and github of the course and it will give the URL. I will keep asking specific question. I wanted the model to lead me with this course.


License of the code / repository

I'm evaluating options for a new are we X yet site. While most of the generators use zola, every one seems to have its own structure.
arewewebyet has a CC license. Does this project have a license? Otherwise it would be hard to fork / reuse it.

I believe it's CC-BY: https://github.com/rust-gamedev/arewegameyet/blob/HEAD/templates/master.html#L90

Closing, but feel free to reopen if needed

Closing, but feel free to reopen if needed

It might be worth adding a LICENSE file to the repo, just so it shows up in Github's UI as well as the site itself.

It might be worth adding a LICENSE file to the repo, just so it shows up in Github's UI as well as the site itself.


Add tag option for task

Tags are exclusive for tasks or it will be a polymorphic resource?

for now its only task exclusive

Alright and one more thing does user requires any kind of special permission to add or delete a tag from a task or a user who has viewing permission for a task can add or delete tags?

anyone who has editing permission on that project/team/office can add or delete tag on a task even if it's not created by that user


[native filter] native filter on different datasets can take effect on the dataset not in configuration when 'apply to all panel' is selected.

native filter on different data sets can take take effect on the dataset not in configuration when 'apply to all panel' is selected
For example, i have 2 charts in a dashboard:
time gain filter control chart from dataset: cleaned_sales_data
How to reproduce the bug
1, create Time column filter test:
a. use 'FCC survey 2018' data set, edit dataset, select is temporal for 'time_end'
b, create time series chart using time column 'time end', metric 'MAX(month_job_search)User create time series chart using time column 'time end', metric 'MAX(month_job_search) add to dashboard
c. create time column native filter in dashboard and set dataset to be 'FCC survey 2018', apply to all panel
2, create Time grain filter test:
a, use 'cleaned_sales_data' and create time-series chart on sum (sales)
b, create time grain native filter on 'cleaned_sales_data' dataset and apply to all panel
3, apply time column filter and time grain filter to observe change
Expected results
time column filter only take effect on the 'FCC survey 2018' time series chart and time grain filter only take effect on 'clean_sales_data' time series chart
Actual results
time column filter and time grain filter take effect on both chart
Screenshots

https://user-images.githubusercontent.com/81597121/121756866-73d0bc80-cad0-11eb-8571-67e7bc8acfc3.mov
Environment
superset master
Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

question for the team:

time range filter doesn't need to specify dataset and temporal column, what about time grain?
also, when charts on a dashboard are powered by multiple datasets, one/some of the charts are powered by a dataset that have multiple time columns -> time column filter, what should other charts behave? should we restrict on the scoping side? if not, should we show errors on charts that can't be overwriten?
@villebro @zhaoyongjie

@jinghua-qa  2nd is quite an extreme case and possibly lead to scope creep) getting # 1 figured out is good enough

@junlincc I'll take a look this issue
About 2. I don't think that we need restrict it on scoping side, because of 2 reasons:
a. We apply scoping per chart and not per data in chart, so if in explore some chart will be changed it will not affect saved metadata in other filters
b. It more similar to rejected columns, so we need copy this behavior I think

Also we have such notification for some cases

Checked on the latest master, the current behavior is : on the scope tab, filter only apply to the chart with the dataset selected in filter configuration by default, but i still be able to change to ‘apply all’ and then i will be able to repro this issue. My question is : should we disable 'Apply all' or give warning when select 'Apply all' if filter A is configured to dataset A and filter B is configured to dataset B?

Checked with the latest master, do see filters configured to different dataset is apply to specific panels and also saw the warning sign. Thank you for the fix.


ComboBox on AppWindow Freezes application in WinUI 2

Describe the bug
On versions of WinUI 2 after version 2.6.0-prerelease.210430001, using a ComboBox on an AppWindow will result in the application hanging.
Steps to reproduce the bug
I've created a repro solution here: https://github.com/ZodmanPerth/WinUI2ComboBoxFreezeBug.  The readme in that repro has replication steps specific to replication on that solution.
For generic reproduction:

Create a new UWP app
Install WinUI 2 (any version after 2.6.0-prerelease.210430001 replicates the issue)
From the main window, spawn a new AppWindow containing a ComboBox with several items
Run the app
Spawn the AppWindow
Open the ComboBox
Move your mouse across the open ComboBox, ensuring the mouse goes outside the airspace of the open ComboBox
Observe the app hangs

An easy way to observe it hangs is that the ComboBoxItem hover state stops working
Expected behavior
The app should not hang, the UI should remain responsive.
Screenshots

NuGet package version
Microsoft.UI.Xaml 2.8.0-prerelease.220601001
Windows app type

[x] UWP
[ ] Win32

Device form factor
Desktop
Windows version
Windows 11 (21H2): Build 22000
Additional context
It seems that changes to the style of the ComboBox after 2.6.0-prerelease.210430001 have caused the issue.

This is possibly related to https://github.com/microsoft/microsoft-ui-xaml/issues/802

More info: I found that when the app has hung with the open ComboBox, if I switch to another Winodws virtual desktops and back again using the keyboard shortcuts CTRL + WIN + ARROW LEFT and CTRL + WIN + ARROW RIGHT, then the open ComboBox becomes responsive again for a time.  However when the mouse leaves the airspace of the open ComboBox the app freezes again.

In attempting to find a workaround, I added a branch to the repo cs/fiddling-with-styles where I replace the ComboBox, ComboBoxItem, and ItemContainerStyle styles with older styles but the problem persists.  I also tried switching to a different ItemPanel but that also doesn't prevent the issue either.

Hi @ZodmanPerth.
Just a fellow developer here.
Could you try applying the workaround I mentioned here and let me know if this still repros?

@lukeblevins I can confirm that workaround does indeed prevent the issue from happening.
I haven't played with it beyond setting ThemeShadowIsUsingDropShadows to False at the root level as you suggested, but this on it's own does indeed prevent the freeze from occurring.
Here's the App.xaml from my repro project for those playing along at home:
<Application
    x:Class="WinUI2ComboBoxFreezeBug.App"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
>

	<Application.Resources>

		<ResourceDictionary>

			<ResourceDictionary.MergedDictionaries>

				<!--External -->
				<XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls" />

			</ResourceDictionary.MergedDictionaries>

			<x:Boolean x:Key="ThemeShadowIsUsingDropShadows">False</x:Boolean>

		</ResourceDictionary>

	</Application.Resources>

</Application>

@ZodmanPerth, thank you for reporting this. Unfortunately we are not currently investigating WinUI2 issues that are not business or security critical (more on the policy here). If this issue also reproes in WinUI3, please comment here and we will investigate.


Error when combining rotate and sequentialRead

ERROR	VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
key:largeExif.jpg
What are the steps to reproduce?
await image
.rotate()
.sequentialRead
.tiff({ pyramid: true, tile: true, tileWidth: 512, tileHeight: 512 })
.toBuffer()
What is the expected behaviour?
normal buffer
Are you able to provide a sample image that helps explain the problem?
https://s3.cn-northwest-1.amazonaws.com.cn/iiif.etu.wiki/largeExif.jpg

Hi, this should work if you remove the use of sequentialRead().
Adding the rotate operation to the list of exceptions where we know sequentialRead could fail will also prevent this. You'll notice trim, normalise and some of the crop strategies already follow this pattern:
https://github.com/lovell/sharp/blob/755a0caf3d495b57529221504bece16930766b7e/src/pipeline.cc#L1417-L1422
Happy to accept a PR if you're able.


(BKR-916) Use dns_name for ec2 hostnames

Prior to this change, provisioning in ec2 would set each host's hostname
to the name attribute of the host. This change removes that behavior
and sets each host's hostname to be the public facing dns_name
provided by ec2 to allow traffic from outside ec2 to route correctly to
that host.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2871/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2872/

@puppetlabs-jenkins retest this please

Is there a way to override this behavior? Classification for scale testing is almost always set by hostname/certname, which I need to be able to make unique for each role.

@doug-rosser I am a little confused on your requirement to

make (hostname/certname) unique for each role.

This change doesn't alter that aspect; all machines will still have unique certnames, but they will differ as the certnames will be based on their externally available names instead of internally available names.
For instance, before this change, after beaker provisioned the host, it would have a hostname like aws2.us-west-2.compute.internal, where aws2 is the name of the host from your beaker host configuration. With this change, the hostname would be something like ec2-52-43-22-235.us-west-2.compute.amazonaws.com.
I'm unclear how that change breaks your requirements; can you elaborate?

Ah, in that case 👍 ! I was thinking this would set the hostnames to the garbage ec2 auto-assigned.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2885/


Fix Apache Drill sample URL

The current sample URL for Apache Drill has port after schema.
According to http://drill.apache.org/docs/using-the-jdbc-driver/,
port is part of the zookeeper host name.

Thanks!


Convergence Check

Dear SEEKR2 team,
I recently ran some SEEKR2 simulations of a protein looking at Ca binding to different EF hands. I came across a few issues when it comes to analyzing the results. They are described below and your help will be very much appreciated.

For one of the EF hand simulations, after running converge.py,  koff did not converge well, meaning it fluctuates across several orders of magnitude. Meanwhile, it did not return any output for the kon statictics. Running analyze.py returned this error "All post-simulation checks passed.
Printing results from MMVT SEEKR calculation
k_off (1/s): (5.8 ± 23.0) * 10^-22
k_ons :
k_on (1/s * 1/M) to state 0 : (0.0 ± 0.0) * 10^+00
Traceback (most recent call last):
File "/home/xfang2/Apps/seekr2/seekr2/analyze.py", line 763, in
analysis.print_results()
File "/home/xfang2/Apps/seekr2/seekr2/analyze.py", line 602, in print_results
delta_G_err = diss_constant_err*common_analyze.GAS_CONSTANT
TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'
"
For another EF hand simulations, after running convergy.py, koff did not converge well either. Meanwhile kon showed nice convergence.
For the SMD simulations, it seems that it did not provide directional bias. Therefore, one thing I noticed is that while Ca was pulled away from the binding site, Ca actually moved closer to other parts of the protein.

So I was wondering:

For the koff convergence issue, does it suggest longer simulation of the MD stage is needed?
For the kon issue, what would be an appropriate way to fix it?
After running analyze.py, several images were generated. For 'pi_alpha.png', 'p_i.png', and images under dirs 'N_ij' and 'R_i', I tried to look for descriptions on the website and the paper but no luck on that. Could you provide some explanations or sources to read up on them?
Regarding the SMD simulations, would it matter if the ligand is interacting with other parts of the protein even though it is away from the binding site? If so, is there a way to perform more sophisticated SMD simulations to a certain direction?

Thanks!
Xuan

Hi Xuan,
Your points are addressed below.

Yeah, these results look problematic. The error you got is probably a bug, but it's likely caused by insufficient statistics, probably not enough encounters in the BD stage. Would you please run converge.py on your system and paste the output here?

Your k-off looks very wrong: a k-off on the order of 10^-22 1/s is way too small. Probably the output of converge.py will tell us why this happened.

Would you attach the k-off convergence plot here, just so that I can see it?

Yes, this is a weakness of the SMD. I'd suggest either a) placing the center of the site deeper in the protein so that the Ca is more likely to exit through the correct path, or b) use a different method such as RAMD or Ratchet. Unfortunately, the latter two methods are relatively new so I don't have tutorials or instructions for how to use them. Why don't you try RAMD for at least one of your systems:

Here is an example command to run RAMD. You can find an explanation of the arguments by running HIDR with the "-h" argument:
python ~/seekrtools/seekrtools/hidr/hidr.py any /path/to/model.xml -M RAMD -p /path/to/bound_state.pdb -K 10.0 -c 0

You might consider changing the "-K" argument (RAMD force magnitude) to a smaller value since Ca is such a small ligand.
For the second list of questions:

The output of converge.py should tell us what is going wrong - although based on what you said about the SMD, it's likely that SMD is forcing the system out the wrong part of the protein - not the channel.
Let's see what converge.py tells us.
Thanks for the suggestion - I should indeed do this soon.
See the point above about RAMD or Ratchet.

Oh and based on the line numbers, I think you may be using an old version of SEEKR2. I'd suggest pulling and reinstalling the latest versions of SEEKR2 and SeekrTools

Hi Lane,
Thanks for the response. Please see below for the convere.py outputs and results.

converge.y outputs:

Warning: importing 'simtk.openmm' is deprecated.  Import 'openmm' instead.
All available options for --k_on_state include: [0]
No BD milestone has been provided for k_on_state. The BD milestone 0 has been chosen by default.
Processing interval 0 of 100
Processing interval 10 of 100
Processing interval 20 of 100
Processing interval 30 of 100
Processing interval 40 of 100
Processing interval 50 of 100
Processing interval 60 of 100
Processing interval 70 of 100
Processing interval 80 of 100
Processing interval 90 of 100
All plots have been saved to: /data/xfang2/seekrCalculation/cam_v2_1/site4/test/images_and_plots/
Molecular dynamics results:

Anchor 0:
Milestone transitions: 0->0 : 3636,
Milestone avg. transition time (ps): (0, 0) : 54.819,
Convergence value: 2.8969e-02.
Converged? True
Anchor 1:
Milestone transitions: 0->1 : 4, 1->0 : 4,
Milestone avg. transition time (ps): 0 : 12418.071, 1 : 0.461,
Convergence value: 1.4640e-01.
Converged? False
Anchor 2:
Milestone transitions: 1->2 : 13919, 2->1 : 13919,
Milestone avg. transition time (ps): 1 : 10.468, 2 : 3.865,
Convergence value: 6.8371e-02.
Converged? True
Anchor 3:
Milestone transitions: 2->3 : 22558, 3->2 : 22558,
Milestone avg. transition time (ps): 2 : 6.258, 3 : 2.607,
Convergence value: 1.7059e-02.
Converged? True
Anchor 4:
Milestone transitions: 3->4 : 7716, 4->3 : 7716,
Milestone avg. transition time (ps): 3 : 22.932, 4 : 2.682,
Convergence value: 1.3517e-01.
Converged? False
Anchor 5:
Milestone transitions: 4->5 : 1234, 5->4 : 1234,
Milestone avg. transition time (ps): 4 : 159.807, 5 : 0.843,
Convergence value: 6.8265e-02.
Converged? True
Anchor 6:
Milestone transitions: 6->5 : 5649, 5->6 : 5648,
Milestone avg. transition time (ps): 6 : 1.509, 5 : 33.884,
Convergence value: 2.5109e-02.
Converged? True
Anchor 7:
Milestone transitions: 6->7 : 43, 7->6 : 43,
Milestone avg. transition time (ps): 6 : 4594.567, 7 : 0.767,
Convergence value: 1.1278e-01.
Converged? False
Anchor 8:
Milestone transitions: 8->7 : 22806, 7->8 : 22805,
Milestone avg. transition time (ps): 8 : 2.603, 7 : 6.166,
Convergence value: 2.0970e-02.
Converged? True
Anchor 9:
Milestone transitions: 8->9 : 17334, 9->8 : 17333,
Milestone avg. transition time (ps): 8 : 7.740, 9 : 3.798,
Convergence value: 3.2512e-02.
Converged? True
Anchor 10:
Milestone transitions: 10->9 : 9049, 9->10 : 9048,
Milestone avg. transition time (ps): 10 : 2.188, 9 : 19.913,
Convergence value: 3.6040e-02.
Converged? True
Anchor 11:
Milestone transitions: 10->11 : 2379, 11->10 : 2379,
Milestone avg. transition time (ps): 10 : 77.589, 11 : 1.964,
Convergence value: 7.1653e-02.
Converged? True
Anchor 12:
Milestone transitions: 11->12 : 415, 12->11 : 415,
Milestone avg. transition time (ps): 11 : 478.883, 12 : 1.275,
Convergence value: 8.2918e-02.
Converged? True
Anchor 13:
Milestone transitions: 12->13 : 15909, 13->12 : 15909,
Milestone avg. transition time (ps): 12 : 10.410, 13 : 2.162,
Convergence value: 1.7960e-01.
Converged? False
Anchor 14:
Milestone transitions: 14->13 : 40515, 13->14 : 40515,
Milestone avg. transition time (ps): 14 : 2.973, 13 : 1.964,
Convergence value: 1.0404e-02.
Converged? True
Anchor 15:
Milestone transitions: 15->14 : 38759, 14->15 : 38759,
Milestone avg. transition time (ps): 15 : 2.527, 14 : 2.633,
Convergence value: 1.6810e-02.
Converged? True
Anchor 16:
Milestone transitions: 15->16 : 33253, 16->15 : 33253,
Milestone avg. transition time (ps): 15 : 2.176, 16 : 3.839,
Convergence value: 9.1745e-02.
Converged? True
Anchor 17:
Milestone transitions: 16->17 : 47955, 17->16 : 47954,
Milestone avg. transition time (ps): 16 : 2.178, 17 : 1.992,
Convergence value: 5.9184e-03.
Converged? True
Anchor 18:
Milestone transitions: 18->17 : 39352, 17->18 : 39351,
Milestone avg. transition time (ps): 18 : 2.378, 17 : 2.702,
Convergence value: 1.3767e-02.
Converged? True
Anchor 19:
Milestone transitions: 19->18 : 40341, 18->19 : 40341,
Milestone avg. transition time (ps): 19 : 1.729, 18 : 3.229,
Convergence value: 1.0695e-02.
Converged? True
Anchor 20:
Milestone transitions: 20->19 : 31339, 19->20 : 31338,
Milestone avg. transition time (ps): 20 : 1.501, 19 : 4.881,
Convergence value: 3.0448e-02.
Converged? True
Anchor 21:
Milestone transitions: 20->21 : 20184, 21->20 : 20184,
Milestone avg. transition time (ps): 20 : 7.977, 21 : 1.932,
Convergence value: 2.7945e-02.
Converged? True
Anchor 22:
Milestone transitions: 21->22 : 37559, 22->21 : 37559,
Milestone avg. transition time (ps): 21 : 3.785, 22 : 1.540,
Convergence value: 1.3984e-02.
Converged? True
Anchor 23:
Milestone transitions: 22->23 : 32920, 23->22 : 32920,
Milestone avg. transition time (ps): 22 : 4.769, 23 : 1.306,
Convergence value: 2.7415e-02.
Converged? True
Anchor 24:
Milestone transitions: 23->24 : 39640, 24->23 : 39640,
Milestone avg. transition time (ps): 23 : 3.862, 24 : 1.184,
Convergence value: 2.3995e-02.
Converged? True
Anchor 25:
Milestone transitions: 25->24 : 29430, 24->25 : 29429,
Milestone avg. transition time (ps): 25 : 0.972, 24 : 5.824,
Convergence value: 3.8471e-02.
Converged? True
Anchor 26:
Milestone transitions: 25->26 : 45786, 26->25 : 45785,
Milestone avg. transition time (ps): 25 : 2.360, 26 : 2.008,
Convergence value: 6.1604e-03.
Converged? True
Anchor 27:
Milestone transitions: 26->27 : 45866, 27->26 : 45866,
Milestone avg. transition time (ps): 26 : 2.238, 27 : 2.123,
Convergence value: 4.0497e-03.
Converged? True
Anchor 28:
Milestone transitions: 27->28 : 34388, 28->27 : 34387,
Milestone avg. transition time (ps): 27 : 4.642, 28 : 1.174,
Convergence value: 2.1748e-02.
Converged? True
Anchor 29:
Milestone transitions: 28->29 : 36459, 29->28 : 36458,
Milestone avg. transition time (ps): 28 : 4.266, 29 : 1.220,
Convergence value: 1.0262e-02.
Converged? True
Anchor 30:
Milestone transitions: 30->29 : 26596, 29->30 : 26595,
Milestone avg. transition time (ps): 30 : 0.962, 29 : 6.558,
Convergence value: 2.3943e-02.
Converged? True
Anchor 31:
Milestone transitions: 31->30 : 38088, 30->31 : 38088,
Milestone avg. transition time (ps): 31 : 1.249, 30 : 4.002,
Convergence value: 1.9600e-02.
Converged? True
Brownian dynamics results:
b-surface reaction counts:
to milestone 32: 3140
to milestone 31: 3005
to escaped: 6995
to stuck: 0
to milestone 30: 0
BD milestone 0 reaction counts:
to milestone 30: 0
to escaped: 3005

k_off convergence plot:

I think that some of these problems will be solved by using the most updated version of the SEEKR2 software. As for the convergence results, I see that there are relatively few transitions in anchor_1.
Based on the analyze.py output, the converge.py output, and the plot you sent, I'll bet that the SMD is forcing the ligand out the wrong way. I've encountered this problem before also.
Let me know how RAMD performs, or if you have any trouble getting it to work.

Hi @xfang216, did this error ultimately get resolved?

Hi @lvotapka, thanks for checking. Unfortunately our cluster administrator is still in the process of updating the package so I haven't been able to test it out. Will keep you updated once I get the results.

Hi Lane,
I was testing RAMD yet ran into the following issue:
Warning: importing 'simtk.openmm' is deprecated.  Import 'openmm' instead.
Assigning pdb file x.pdb to anchor 0
The following procedure will be executed:
RAMD force constant is 3.0 kcal/(A mol)
RAMD from anchor 0 to anchor [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
Estimated total simulation time: 20.000 ns
running RAMD from anchor 0 to anchor [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
Traceback (most recent call last):
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekrtools/seekrtools/hidr/hidr.py", line 366, in
hidr(model, destination, pdb_files, dry_run, equilibration_steps,
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekrtools/seekrtools/hidr/hidr.py", line 208, in hidr
ns_per_day = hidr_simulation.run_RAMD_simulation(
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/seekrtools-0+untagged.65.g549ac37-py3.8.egg/seekrtools/hidr/hidr_simulation.py", line 639, in run_RAMD_simulation
assert not found_anchor, "Found system in two different "
AssertionError: Found system in two different anchors in the same step.
Could you enlighten me on what might be causing this?
Thank you!

Yeah this is a bug that should now be fixed in the dev branch of seekrtools (not seekr2). So go ahead and pull from the dev branch and reinstall seekrtools, and let me know how it goes.

Is there a good way to do a clean uninstallation of seekrtools and then reinstall it?

You shouldn't need to do that, you should be able to just run "python setup.py install" right in the seekrtools/ directory.
But if you need a clean install, I suppose you could do "conda remove seekrtools" first.

Hi Lane,
It seems that when our cluster administrator tried to pull the dev branch, it showed only the master branch. Could you provide some instructions on how it should be done?
Thank you!

The dev branch is definitely there. Did he forget to make his own dev branch and do a checkout?
git branch dev
git checkout dev
git pull origin dev

Hi Lane,
Thanks for your suggestion, that worked. Now I ran into another issue when using prepare.py.
Warning: importing 'simtk.openmm' is deprecated.  Import 'openmm' instead.
NOsh:  Bad dime[0]  = 81 (3 nlev)!
NOsh:  Reset dime[0] to 65 and (nlev = 4).
NOsh:  Bad dime[1]  = 81 (3 nlev)!
NOsh:  Reset dime[1] to 65 and (nlev = 4).
NOsh:  Bad dime[2]  = 81 (3 nlev)!
NOsh:  Reset dime[2] to 65 and (nlev = 4).
Vpmg_ctor2:
Warning: External energies are not used in BCFL_MAP calculations!
Vpmg_ctor2:
Warning: External energies are not used in BCFL_MAP calculations!
Vpmg_ctor2:
Warning: External energies are not used in BCFL_MAP calculations!
Traceback (most recent call last):
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekr2/seekr2/prepare.py", line 75, in
model, xml_path = prepare(model_input, force_overwrite)
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekr2/seekr2/prepare.py", line 44, in prepare
base.save_model(model, xml_path)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/seekr2-0+untagged.239.gcaa21a8-py3.8.egg/seekr2/modules/common_base.py", line 1004, in save_model
model.serialize(model_file, xml_header=dont_modify_warning)
TypeError: serialize() got an unexpected keyword argument 'xml_header'
How can this be fixed? Thanks!

You probably need to upgrade Abserdes:
pip install --upgrade abserdes

Thanks Lane, that fixed it. I then ran run.py but got the following error:
Warning: importing 'simtk.openmm' is deprecated.  Import 'openmm' instead.
Assigning pdb file x.pdb to anchor 0
The following procedure will be executed:
RAMD force constant is 3.0 kcal/(A mol)
RAMD from anchor 0 to anchor [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
Estimated total simulation time: 20.000 ns
running RAMD from anchor 0 to anchor [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
Traceback (most recent call last):
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekrtools/seekrtools/hidr/hidr.py", line 434, in
hidr(model, destination, pdb_files, toy_coordinates, dry_run,
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekrtools/seekrtools/hidr/hidr.py", line 226, in hidr
ns_per_day = hidr_simulation.run_RAMD_simulation(
TypeError: run_RAMD_simulation() got an unexpected keyword argument 'steps_per_RAMD_update'
The seekrtools has been pulled from the dev branch and updated. Is this issue related to another package?

Did you run
python setup.py install

Within the seekrtools/ directory after pulling from the dev branch?

You're right. It wasn't run. It is run now. But there's another issue
Warning: importing 'simtk.openmm' is deprecated.  Import 'openmm' instead.
Assigning pdb file x.pdb to anchor 0
The following procedure will be executed:
RAMD force constant is 3.0 kcal/(A mol)
RAMD from anchor 0 to anchor [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
Estimated total simulation time: 20.000 ns
running RAMD from anchor 0 to anchor [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
Traceback (most recent call last):
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekrtools/seekrtools/hidr/hidr.py", line 434, in
hidr(model, destination, pdb_files, toy_coordinates, dry_run,
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekrtools/seekrtools/hidr/hidr.py", line 226, in hidr
ns_per_day = hidr_simulation.run_RAMD_simulation(
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/seekrtools-0+untagged.93.gd779cf7-py3.8.egg/seekrtools/hidr/hidr_simulation.py", line 600, in run_RAMD_simulation
simulation = openmm_ramd.RAMDSimulation(
TypeError: init() got an unexpected keyword argument 'ramdSteps'

Ah you should pull and install the latest version of openmm_ramd from the dev branch there too.

I see. But it looks like there's just the master branch there. Is this the right repo (https://github.com/seekrcentral/openmm_ramd)?

Oh sorry about that - yes you want the master branch.

Hi Lane,
Our administrator did the following but the issue remains:
git clone https://github.com/seekrcentral/openmm_ramd.git
cd openmm_ramd
python setup.py install
Looking at the openmm_ramd.py under openmm_ramd/openmm_ramd though, it looks like the init function does not contain the 'ramdSteps' argument. Could this be the reason?

I might not have pushed those latest changes. Yry to pull and reinstall one more time...

That did the trick. Thanks Lane. I can play around with ramd now.

Hi Lane,
I played around with the RAMD but ran into a few issues.

When running prepare.py, I got these warnings:
NOsh:  Bad dime[0]  = 81 (3 nlev)!
NOsh:  Reset dime[0] to 65 and (nlev = 4).
NOsh:  Bad dime[1]  = 81 (3 nlev)!
NOsh:  Reset dime[1] to 65 and (nlev = 4).
NOsh:  Bad dime[2]  = 81 (3 nlev)!
NOsh:  Reset dime[2] to 65 and (nlev = 4).

When running hidr.py, I got the following errors:
Warning: importing 'simtk.openmm' is deprecated.  Import 'openmm' instead.
Assigning pdb file x.pdb to anchor 0
The following procedure will be executed:
RAMD force constant is 1.0 kcal/(A mol)
RAMD from anchor 0 to anchor [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
Estimated total simulation time: 20.000 ns
running RAMD from anchor 0 to anchor [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
recomputing force!
Traceback (most recent call last):
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekrtools/seekrtools/hidr/hidr.py", line 434, in
hidr(model, destination, pdb_files, toy_coordinates, dry_run,
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekrtools/seekrtools/hidr/hidr.py", line 226, in hidr
ns_per_day = hidr_simulation.run_RAMD_simulation(
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/seekrtools-0+untagged.93.gd779cf7-py3.8.egg/seekrtools/hidr/hidr_simulation.py", line 640, in run_RAMD_simulation
simulation.RAMD_step(steps_per_RAMD_update)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/openmm_ramd-0+untagged.10.g7f01e3c-py3.8.egg/openmm_ramd/openmm_ramd.py", line 200, in RAMD_step
self.step(numSteps)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/openmm/app/simulation.py", line 134, in step
self._simulate(endStep=self.currentStep+steps)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/openmm/app/simulation.py", line 236, in _simulate
self._generate_reports(wrapped, True)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/openmm/app/simulation.py", line 258, in _generate_reports
reporter.report(self, state)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/openmm/app/pdbreporter.py", line 98, in report
PDBFile.writeModel(simulation.topology, state.getPositions(), self._out, self._nextModel)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/openmm/app/pdbfile.py", line 335, in writeModel
raise ValueError('Particle position is NaN')
ValueError: Particle position is NaN

My system is a Ca2+-binding protein and I'm assigning one single Ca2+ as the ligand. The regular SMD.py and seekr simulatiosn worked fine for this system though. Also, I ran the toy system and all seemed fine so I don't think there's a problem with the packages. So do you think having one single atom as the ligand might be why the issues and do you have any suggestions on how to debug/fix this?
Thanks.

Hi Lane,
It indeed was an issue with the starting structure. I then ran minimization and equilibration of the structure and used the equilibrated structure for RAMD. That worked. However, I ran into a new issue. During the simulation, the ligand kept bouncing between anchor_0 and anchor_1. It wouldn't move into anchor_2. If I simulate only anchor_2, it keeps saying 'recomputing force!'. At the end of the log file, it says:
Warning: anchor 2 has no starting PDB structures.
Warning: anchor 3 has no starting PDB structures.
Warning: anchor 4 has no starting PDB structures.
Warning: anchor 5 has no starting PDB structures.
Warning: anchor 6 has no starting PDB structures.
Warning: anchor 7 has no starting PDB structures.
Warning: anchor 8 has no starting PDB structures.
Warning: anchor 9 has no starting PDB structures.
Warning: anchor 10 has no starting PDB structures.
Warning: anchor 11 has no starting PDB structures.
Warning: anchor 12 has no starting PDB structures.
Warning: anchor 13 has no starting PDB structures.
Warning: anchor 14 has no starting PDB structures.
Warning: anchor 15 has no starting PDB structures.
Warning: anchor 16 has no starting PDB structures.
Benchmark: 18.735888896878826 ps ns/day
Renaming model.xml to model_pre_hidr_1.xml
Saving new model.xml
Assigning pdb file x.pdb to anchor 0
I tried this with different force constants from 0.1 to 10 but they behaved the same. Do you have any insights into what might be causing this and how to debug?
Thanks!

Hi Lane,
I managed to generate some more reasonable starting structures for seekr sims. However when I ran run.py, I encountered the following error:
anchor 0 has not run the minimum number of steps 0 of 100000000 in swarm index None
running anchor_index: 0 restart: False total_simulation_length: 100000000 num_transitions: 0 swarm index: None
Traceback (most recent call last):
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekr2/seekr2/run.py", line 853, in
run(model, instruction, min_total_simulation_length,
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekr2/seekr2/run.py", line 615, in run
run_openmm(model, anchor_index, restart,
File "/cm/shared/apps/anaconda3/envs/SEEKR/seekr2/seekr2/run.py", line 487, in run_openmm
runner.run(sim_openmm_obj, restart, load_state_file, restart_index)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/seekr2-0+untagged.239.gcaa21a8-py3.8.egg/seekr2/modules/runner_openmm.py", line 451, in run
self.run_mmvt(traj_filename)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/seekr2-0+untagged.239.gcaa21a8-py3.8.egg/seekr2/modules/runner_openmm.py", line 529, in run_mmvt
saveCheckpoint(self.sim_openmm, self.restart_checkpoint_filename)
File "/cm/shared/apps/anaconda3/envs/SEEKR/lib/python3.8/site-packages/seekr2-0+untagged.239.gcaa21a8-py3.8.egg/seekr2/modules/runner_openmm.py", line 229, in saveCheckpoint
sim_time = sim_openmm.simulation.context.getTime().value_in_unit(
AttributeError: 'Context' object has no attribute 'getTime'
Is this an update issue?
Thanks!

It sounds like you are using a version of OpenMM that is too old. What version of OpenMM are you using?

It should be 7.6

That should be a usable version. Did you install from source or conda-force?
In the correct conda environment, open up Python and type:
import openmm
print(openmm.__version__)

And paste the result here.

Hi Lane, below is the result. I did not personally install it but I think our administrator installed it following the instructions on https://seekr2.readthedocs.io/en/latest/installation.html using conda.
(SEEKR) xfang2@Faust:~/SCRATCH/seekrCalculation$ python
Python 3.8.12 (default, Oct 12 2021, 13:49:34)
[GCC 7.5.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.

import openmm
print(openmm.version)
7.6

That's strange, maybe it doesn't work with 7.6.0. Any chance you could get your admin to upgrade you to OpenMM 7.7.0? I'm using that version and SEEKR2 works fine.

I see. I will ask him to do that and keep you posted. Thank you!

Hi Lane, that's great news. I will let our administrator know. Thanks!


Unable to build SDK

Hi, I'm following the BUILDING.md file and am unable to build the SDK.
(Windows 64-bit, VS 2017)
cmake -G "Visual Studio 15 Win64" ....
-- Could NOT find VulkanHeaders (missing: VulkanHeaders_INCLUDE_DIR)
-- Could NOT find VulkanRegistry (missing: VulkanRegistry_DIR)
-- Could NOT find Vulkan (missing: Vulkan_LIBRARY Vulkan_INCLUDE_DIR)
-- Could NOT find glslc, using precompiled .spv files
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.

I believe it should be buildable now without Vulkan, if you update your source. Re-open if you still have trouble.


Add frame modifier for UseItemPacketState

Updated version of https://github.com/SpongePowered/SpongeCommon/pull/1548
Fix https://github.com/SpongePowered/SpongeCommon/issues/1532

Closing as this is already superseeded by https://github.com/SpongePowered/SpongeCommon/pull/2163


Fix Inject-Test Events Dependency

It seems currently that inject-tests has a hard dependency on events. This PR fixes that by not generating the meta-inf service data for inject-test.

It seems

We can be explicit here, that helps anyone who hits this issue and is trying to understand it.
Currently, when inject-test is built, it is has a META-INF/services/InjectExtension with an entry for io.avaje.inject.events.spi.ObserverManagerPlugin. This means that it has this implicit dependency on inject-events.
The fix for this issue is to NOT generate that META-INF/services/InjectExtension at all when inject-test is built.


Add Hacktoberfest logo to README.md

Description
Add the Hacktoberfest logo to the very start of the README file and add the link to the Contributing_Guidelines.md file and the Issues tab in the repository. The links should read :

'CLICK HERE TO START CONTRIBUTING' --> Link to the Issues tab.

'READ THE CONTRIBUTING GUIDELINES' --> Link to the Contributing_Guidelines.md file

Acceptance Criteria

[ ] README must be properly formatted.
[ ] All instructions provided in the Description must be strictly followed.

Definition of Done

[ ] All of the required items are completed.
[ ] Approval by 1 mentor.

Time Estimation
10 minutes.

Hi, is it okay if I work on this?

Hi, is it okay if I work on this?

Hi @martinoywa please consider issues from #3  onwards. The first two have been resolved by me.
#3 and #4  are also beginner level issues.

Ahh, okay thanks. I'll delete the new PR then.


Keep track of number of wins

The circuit can only track once who has won, design a circuit to keep track of the number of times a player has won and a button to register the inputs to display the result and also a reset button for the scores to be 0.
(Hint: Use a 7-segment display)

hey can I work on this

Can I get assigned to this ?

@Alley2717 Yes. The time limit is 1 hour. If not, others can ask to be assigned.

please assign

hey can i get assigned to this

hey can I be assigned to this?

Can I get assigned?

please assign to others, i have been assigned to two

@PandaTGOS  Yes. The time limit is 1 hour. If not, others can ask to be assigned.

can i get assigned?

can i get assigned

@AdiXgit Yes. The time limit is 1 hour. If not, others can ask to be assigned.

can i get assigned

is this still open?

can you assign this to me

@AdiXgit i will be reassigning it because time is out.

@KunalMaverick Yes. The time limit is 1 hour. If not, others can ask to be assigned.

can I pls get assigned for this?

can you assign me for this issue ??

@sadhana235 Yes. The time limit is 1 hour. If not, others can ask to be assigned.

Can I be assigned this?

Can I be assigned this?

can i be assigned to this

can i be assigned to this

can i be assigned

can i get assigned if this is still open?

@sadhana235 i am reassigning it because time is up.

@Python-is-better-than-Java Yes. The time limit is 1 hour. If not, others can ask to be assigned.

Give me access pls

Hey can i work on this issue

@karun1763 you have a time limit of 1 hr

assign me

can i be assigned this?


Smgr: cache n_blocks info for relations and avoid spamming pageserver with corresponding requests.

Done in https://github.com/zenithdb/zenith/pull/485


Error in readme.

# parsing random integers in the range [0,1)
volume = 2.09808 MB
netlib                                  :   294.33 MB/s (+/- 2.4 %)    14.03 Mint/s

The word integers is a mistake, should be replaced to floats.
The name of Mints/s metric is also bogus.

You are correct. Thank you for the comment. I fixed it via a commit.


How to change this c# code to work with cognito-local?

I have a sample c# code which works with real AWS Cognito.
How should I change the code to run it with the Cognito emulator?
        public UserRepository(IOptions<AppConfig> appConfig, UserContextManager userManager, IHttpContextAccessor httpContextAccessor)
        {
            _cloudConfig = appConfig.Value;

            var ep = RegionEndpoint.GetBySystemName(_cloudConfig.Region);
            _provider = new AmazonCognitoIdentityProviderClient(
                _cloudConfig.AccessKeyId, _cloudConfig.AccessSecretKey, ep);

            _userPool = new CognitoUserPool(_cloudConfig.UserPoolId, _cloudConfig.AppClientId, _provider);

            _userManager = userManager;
            _httpContext = httpContextAccessor.HttpContext;
        }

and the appsetting.json
  "AppConfig": {
    "Region": "us-west-2",
    "UserPoolId": "us-west-2_aBcDeFgHiJ",
    "AppClientId": "Ab12Cd34Ef56Gh78ij90",
    "AccessKeyId": "AKIA1234567890",
    "AccessSecretKey": "abcdEfghalfheqncoryedofhuehhrh"
  }

Thanx

I tried to use
 var ep = RegionEndpoint.GetBySystemName(_cloudConfig.Region);
            //ep = "http://localhost:9229/";
            _provider = new AmazonCognitoIdentityProviderClient( _cloudConfig.AccessKeyId, _cloudConfig.AccessSecretKey, "http://localhost:9229/");

but:
Amazon.Runtime.AmazonClientException: 'No RegionEndpoint or ServiceURL configured'

Also:
SocketException: No such host is known.
System.Net.Sockets.Socket+AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)

HttpRequestException: No such host is known. (cognito-idp.http:443)

Unfortunately I don't know anything about using the AWS C# SDKs, so I can't help you here.
At a guess:

The region for cognito-local should be local, not an actual AWS region
I don't include the / at the end of the endpoint URL, but I don't know if that would make any difference.

answer is pretty simple (just in case someone else is looking):
new AmazonCognitoIdentityProviderConfig { ServiceURL = "http://localhost:9229" }


Roll Flutter Engine from<PHONE_NUMBER>11 to 449df252a2f1 (3 revisions)

https://github.com/flutter/engine/compare/205484009711...449df252a2f1
2024-10-04<EMAIL_ADDRESS>iOS: Migrate FlutterEngine to ARC (flutter/engine#55590)
2024-10-04<EMAIL_ADDRESS>Roll Skia from 0dfa080b5d71 to e8e0a8c46345 (1 revision) (flutter/engine#55652)
2024-10-04<EMAIL_ADDRESS>Roll Dart SDK from 750b6e44b765 to ecba03620fc8 (1 revision) (flutter/engine#55650)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add Phantom SPH code

I’m working on adding Phantom (https://phantomsph.bitbucket.io/) to AMUSE. This is a tracker issue for work in progress / bug reporting / etc.

Currently, the following should work:

pip install amuse-phantom
run Phantom with gas particles
adding sink particles to a Phantom simulation
letting sink particles accrete gas (handled by Phantom)

Not (yet) working:

dm and other particle types
get gravity / potential at point
other things


Demo maxes out CPU usage in Chrome for me

Chrome tends to do so when loading a new page anyway, but here it seems stuck. I recorded my desktop to show:
https://youtu.be/SPKh7dlDvI8
I wouldn't be surprised if it actually is a Chrome bug, but it's still annoying that it causes my laptop to freeze and ignore half of the input (including making it hard to close the tab). I don't have this issue with Firefox.
Running Ubuntu 16.04

Interesting, thanks for the video!
If you modify index.jsx to take out the emoji picker, does it still go wrong?

This will localize the problem to Elm things or the somewhat crazy emoji picker I got off the shelf.
Anyway, let me know the results of those two questions!

Writing this during breakfast; will try your suggestions later during a break at work.
It seems it is no longer stuck... what does happen, trying this gain, is that in any browser, CPU usage is maximised for a while. Could there be some poorly coded webworker thing going on? Because it's rare that a website maxes out all of my cores, and my first guess would be that yesterday it got stuck waiting for an emoji to download.

Nothing like that in any Elm code. I suspect that browsers can spin up worker threads for downloads, and since the React component is triggering literally hundreds of simultaneous image downloads, I can see something like this happening.

I'll try your suggestions from earlier and if it's the emoji picker we can safely close this (and open an issue on the Emoji Picker page about using sprite sheets or something). However, there's a small issue:
job@job-ThinkPad-T440s-Ubuntu ~/D/e/react-elm-components> npm install
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
 job@job-ThinkPad-T440s-Ubuntu ~/D/e/react-elm-components> npm run serve
npm ERR! Linux 4.4.0-28-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "serve"
npm ERR! node v4.4.7
npm ERR! npm  v3.10.4

npm ERR! missing script: serve
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /home/job/Dev/elm/react-elm-components/npm-debug.log

Can you work through this with someone on the Elm slack? It seems like some npm issue where it's not installing things right, and someone on slack can help work through it better than me.

Not sure how to resolve this without further information. Please reopen if you can pin the problem to something Elm related.

Yeah, my apologies, haven't gotten around to figuring out how to consistently reproduce it. Will re-open if that ever happens.


Should the bot work in threads?

When trying to invoke an oracle or a dice roll in a thread, the bot times out.

I have not modified the bot's permissions in the server at all. I have added it to the role for the channel in which we intend to play, though it was working in the channel before that just fine.
Are threads not supported?

I think the bot needs a new permission to post messages in threads. I can experiment some, and probably generate a new bot invite link for people going forward.

I've tested the bot with the standard permissions link (the one here on github), and it seems to be working with forums.

Can you try it again, maybe the bot was just down at that point in time? If you still can't use forum messages with the bot I can take a look and see if there's something in the bots logs that might point me in the right direction.

To be clear, I'm using threads, not forums.
Oracle prompt success in a channel, outside a thread:

Dice success in a channel, outside a thread:

Oracle prompt failure in a thread:

Dice failure in a thread:


Fix insecure links

Fixed insecure links owned by Microsoft.
Refer to https://dev.azure.com/ceapex/Engineering/_boards/board/t/Content Updating/Stories/?workitem=170748.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: KarenYin01 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@KarenYin01  thanks!


Application not working

When I enter the application, the CMD tab opens and after 1 second it closes again. I tried it on 2 different operating systems, I ran it as administrator.

It is a command line app, you can't simply double click on it. You have to run it from command line or drag&drop a .par file over the executable to extract it.

It is a command line app, you can't simply double click on it. You have to run it from command line or drag&drop a .par file over the executable to extract it.

Thanks.


No links to the required PS module?

The 2 links in this doc and this doc itself does not indicate which module contains Grant-CsTeamsMessagingPolicy. There is a link to the Azure Powershell modules which are not related to Teams.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5dfe01e2-b14d-226d-de27-40cb2733a65d
Version Independent ID: 09477e15-46e1-1a9a-def6-93ef73f24e24
Content: PowerShell script sample - Create and assign a messaging policy - Microsoft Teams
Content Source: Teams/scripts/powershell-script-teams-messaging-policy-edu.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@norman-v  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@norman-v Thank you for your feedback. I'm currently investigating this.

@scanum I believe this issue can be closed as I just added the requested info to the article.

Not really. The command you are featuring in the sample (Grant-CsTeamsMessagingPolicy) is currently not in the module you are referring to. You should import it to see. I have previously seen this module but did not see the cmdlet then. Also your "more info" links (in 1 hop) to another PS module called LyncOnlineConnector which may be an old version of the SkypeOnlineConnector (Is it one or the other?). I hope you see that it is very hard for us to understand the automation story for Teams. And, unfortunately, the Teams admin portal does not support assigning messaging policies in bulk. It currently doesn't even tell you which groups/users are assigned to a policy.

@LanaChin Could you please assist

The module to use is Skype: https://docs.microsoft.com/en-us/office365/enterprise/powershell/manage-skype-for-business-online-policies-with-office-365-powershell
The Grant-CsTeamsMessagingPolicy is in the skype module: https://docs.microsoft.com/en-us/powershell/module/skype/?view=skype-ps
I have tested this and it worked, however this document should be updated

@norman-v, @bamslib. Thanks so much for your feedback and helping to improve our docs. The article has been updated to provide more clarity around the cmdlet and the PowerShell module that's needed.  Thank you.


Can't compile debug template on latest master

Godot version
v4.0.beta.custom_build [43e9ca40f]
System information
Manjaro Linux
Issue description
Fails to compile with:
scene/debugger/scene_debugger.cpp: In static member function 'static void SceneDebugger::_save_node(ObjectID, const String&)': scene/debugger/scene_debugger.cpp:224:28: error: 'class Node' has no member named 'duplicate_from_editor'   224 |         Node *copy = node->duplicate_from_editor(duplimap);       |                            ^~~~~~~~~~~~~~~~~~~~~
Steps to reproduce
just compile with  scons target=template_debug arch=x86_64 -j "$(nproc)"
Minimal reproduction project
Not needed

Regression from #65228, should be fixed by #69658.


feat(fees): customizable gas limit and JSON flag

Added gas limit flag
JSON to be able to use the command in CI integration tests

@andresaiello please, review.


[incubator/vault] Upgrade to 0.11.0.

Signed-off-by: Jonathan Davies<EMAIL_ADDRESS>What this PR does / why we need it: New version.

/ok-to-test
/assign

/label  Contribution Allowed

/lgtm


Zdog rendering in Gcanvas is different from the web

Hi @flyskywhy ! Been doing more testing with the library and following the Zdog instructions will the polyfill.
While the cake example works perfectly, when I copied the code for the below, the rendering was different:
https://codepen.io/desandro/pen/qxjmKM
https://codepen.io/desandro/pen/aqYXoa
The fidelity of the rendering in the Kirby is not nearly as high and you can see the lines. Not sure if this is because of the polyfill or because of Gcanvas.
For Mario, the eyes are partially rendered.
If I load the same codepen in a webview, it renders perfectly (as expected).
The reason why I am asking is because I prefer a native implementation through Gcanvas for performance reasons but don't want to hit rendering issues mid development. Any thoughts?!
Thanks in advance!

@flyskywhy just checking to see if you might know why the distorations are happening?

Ok, I'll try it in days.

v2.3.25 fix the issue 😄

Wow! Awsome - thanks so much. I see, it looks like a scaling issue


Assert probability not null before instantiating ProbabilityBasedSampler.

(surfaced when looking into #1482)
Bringing in the trace starter without any configuration results in an unintuitive NPE when Sleuth's ProbabilityBasedSampler tries to autobox a null probability*.
A null check is needed before instantiation in spring-cloud-gcp, and ideally ProbabilityBasedSampler constructor should check, too.
* now I want to write a scifi short story named "Null Probability".

Added check to ProbabilityBasedSampler in spring-cloud/spring-cloud-sleuth#1401.
Per @meltsufin 's suggestion, will fall back to a RateLimitingSampler in autoconfiguration for consistency with spring-cloud-sleuth autoconfiguration behavior.

This approach is complicated by RateLimitingSampler not being public (asked question in spring-cloud/spring-cloud-sleuth#1409).

@marcingrzejszczak fixed this in #1774 (importing functionality, rendering logic duplication unnecessary).