Cannot access, nor test, the protected variable $this->select in Insert.php

In ./src/Sql/Insert.php there is a protected variable $select (line 46).  However, this variable is not able to be retrieved directly because

The magic getter (line 275) only retrieves values from $this->columns
->getRawState (line 158) only retrieves $this->table and $this->columns (keys, values)

As such, it is not possible to access $this->select as it is hidden from the calling-code, thereby making it impossible to test the Select object stored in $this->select.  The only workaround at this time is to use ->getSqlString() and use string comparison on the actual SQL string (eew).
Can we provide (read-only) access to $this->select in order to facilitate testing?

I do not think it is that eew in this case. Usage of $select is implementation choice. Technically, that component does not have to use it and is subject to change that implementation. What is important is the end result, not how you got to the end result, for your unit test. You need to verify that the output SQL statement is created correctly and will not cause errors on your database engine. Looking at state of Select object does not accomplish that, but getSqlString() actually does.
Since it is implementation detail, opening up API for it would be misleading, IMO.
But if you want to still test against protected variable, do not let me stop you. You can use reflection to convert protected property to public.  That is something I have seen done here now and again so not completely crazy thing to do.  During your verification stage make a utility function that will through reflection allow $insertInstance->select usage accomplishing what you want.

@alextech... hmmm, you've got me finding assumptions I didn't know I had (always good!).
I get that we approach unit testing a bit differently (we don't test the SQL string output / getSqlString()), so perhaps there are some bits of understanding that I'm not grasping.  With that in mind...
Based on what I think you're saying, I'm not sure why any of the getters would be necessary?  For me, I'm thinking $this->select should be treated the same way as$this->table, no?  Is there a reason why table would be available via getRawState(), for example, but not select?  Simply because table is required and select is not (if I'm reading what you wrote correctly)?

_ Is there a reason why table would be available via getRawState()....because table is required_
Yes. Raw state supplies data directly relevant and absolutely needed to perfrom INSERT database operation. Cannot insert without knowing table name to insert into, and probably should not insert data into any random column of that table. Pretty useful to get those right.
Everything else is convenience to achieve that goal that can be done any which way up to discretion of whoever submits a PR (as long as maintainable enough). I think there is a PR that fundamentally changes how SQL is generated using Builder Design Pattern that separates SQL code from Zend DB API, as an example.
Then, there is self-documentation issue.  In API design what is helpful writing code like "well written prose".
$customerInsertion = new Insert();
$customerInsertion->setTable('customers');
$customerTable = $customerInsertion->getRawState()['table']

reads fine.
$customerSelect = $customerInsertion->getSelect()
what?? As your hypothetical coworker I will wonder "What could he be possibly trying to do here? There is no such thing in SQL as select statement generated from insert operation! Maybe he means select last inserted record to get latest ID or something?" and we go down the wonderful path of confusion.
Want to reflect real world of SQL methodology of database engine as much as possible not deviating too much from it. We know SELECT is possible to go inside of INSERT statement, so there is a setter for it.  But there is no such thing in PostgreSQL, MySQL, MSSQL, to have a SELECT statement appear after running INSERT so adding it to API as if it is possible is misleading. You could argue, "I want to get SELECT for the sake of inspection of how INSERT used it" to which I will reply that you would already have a reference for it when you passed it in line 147. You could pass a mock object with method expectation definitions if you are writing a test that verifies it was called correctly if needed, or a stub and inspect state of stub after Insert finishes its thing, instead of fishing it out from a protected property.

@alextech - thank you for explaining yourself more, I do appreciate it.
But I also feel like I'm just not getting what you're saying.  So if I may provide a few differences between what you're writing and what I'm thinking so that perhaps (a) I can identify what I'm not understanding in your comments thus far and (b) I can better explain what I'm thinking as I am wondering if I'm miscommunicating.
First, I'm not sure why you are stating that "Raw state supplies data directly relevant and absolutely needed to perfrom INSERT database operation." (emphasis added by me)  This seems counter to how the Select getRawState() (here) performs, no?  In the code of that link, getRawState() offers numerous items that are not "absolutely needed", no?  Is there something different about Insert (compared to Select)?
Second, I was not really suggesting adding a new method as you have in your last comment.  I fully agree that what you wrote reads poorly ($customerInsertion->getSelect()).  I was thinking something more along the lines of the last line of your '"well written prose"' section... something like this (based on your example above):
$addressSelect = new Select();
$addressSelect->from('addresses')->columns(... ;

$customerInsertion = new Insert();
$cusomterInsertion->setTable('customers');
$customerInsertion->select($addressSelect);

$customerTable = $customerInsertion->getRawState()['table'];
$addressQuery = $customerInsertion->getRawState()['select'];

If $insertObject->select() is never used, then the value of $insertObject->getRawState()['select'] would be  null - just like what happens with the Select class when a property is not set.
Does this approach "read" differently than the example you gave regarding $customerTable?  If so, can you please help me understand?
Again, thank you for your demeanor in this dialog.  I really like learning from others, especially when they actually dialog (vs. just making statements without explanation nor taking into account the nuance of what I'm asking).

You are welcome. I also appreciate conversation about different use cases. Can only have so much experience, unless talk to others.
I really like your example. That does make me think I could not be entirely correct. I did not consider possibility of expanding raw state. I was too fixated on idea of setter, for some reason.
About whether INSERT vs SELECT having items absolutely needed.  What I mean is, each class is a wrapper to SQL for convenience.  SQL query syntax has sections. It is useful to programmatically categorize them into states instead of awkwardly concatinating strings. Maybe I abused definition of word "absolutely" (not my first language, still struggle in that department).  Perhaps "eclusively" is better? That is, I did not want to see unrelated syntax managed by a class. SELECT has everything select related, INSERT has everything insert related and no more.  But your example, which I just ran in my debugger to see a usecase, does indeed show a flaw in design.
(1) Even if we assume that SELECT query state does not belong to INSERT state, (of which I am not so confident anymore) it is no good that return of getRawState() does not return list of columns that will be affected.  SELECT setter should fill those in. I or you can do a PR for that for sure, and see if it will be accepted.
(2) values key being empty is also misleading. It probably should not even exist with INSERT/ SELECT combo.
(3) So the conclusion is that when SELECT is present, its own getRawState should indeed be present, because yes, it does contribute to INSERT's state the way you have it written.  Plus, have column list duplicated with end result
[
'table'=>'customers',
'columns'=> ['street', 'house'],
'select' => [] // output of $this->select->getRawState
]

I think I will take back some things I said, pretty good fix.  I can make a PR for it, or would you like to give it a try yourself (with full tests etc.)?

or no, take idea of duplication into 'columns' out, since SELECT could be more complex, those keys should just not exist.

First, your English is great - the nuance of the word "absolutely" can be difficult for native English speakers, too!
I'm going to poke around at some ideas this morning and make a PR.  But I'll be sure to connect here on what I find, what I'm thinking, etc.  That is, if still love some feedback even on the PR.
I'm learning a lot from this dialog - glad you're willing to explain your thoughts!

@alextech - if you have time, I'd love for you to review, comment, etc. on the PR that is now 'attached' to this Issue (https://github.com/zendframework/zend-db/pull/177)!

In case the PR comments did not make too much practical sense, consider this set of queries:
create table anime (
  id SERIAL PRIMARY KEY,
  name TEXT
)

insert into users(name) values('Rin');
insert into users(name) values('Tomoyo');

create table animeSource (
  id SERIAL PRIMARY KEY,
  name TEXT
)

insert into animeSource(name) values('Fai');

insert into anime
select * from animeSource

will crash with
ERROR:  duplicate key value violates unique constraint "anime_pkey"
DETAIL:  Key (id)=(1) already exists.


Show / hide desktop icons

Hi,
I have a dozens of program icons on my main desktop. Unfortunately they show up on every virtual desktop.
It would be an awesome feature if I could select, which icons are shown on each virtual desktop.
I could create a new virtual desktop with only 2 or 3 program icons or even a totally empty virtual desktop.
How do you thinks about this? Do you see a chance to add such a feature?
Thanks aand regards
Pete

A different WIN+R shell:desktop for each vdesktop... interesting. At first I was thinking it's too much outside the scope of what this project seems to target. That may still be true..

Cause I'd be hesitant to change  a very much fundamental part windows. The current features seems to enhance the core windows functionality rather than change it

Thanks for your answer.
I have no idea, how complicated it is to program such a kind of feature.
I played around with a small program which does similar desktop enhancements as yours - it´s called Dexpot. Dexpot claimes to have this icon hide feature - unfortunately Dexpot does not work reliable in Windows10.
Regards Pete

Hi. Thanks for the suggestion.
I can think of one way of implementing this, but I really don't like it (moving the contents of your desktop between the desktop folder and other folders during runtime). There might be other ways to do it, though, I'll need to investigate.

Ya cause stuff like cmd>cd %UserProfile%\Desktop would not be reliable anymore, potentially breaking expected behavior from other apps, services, etc. I don't know of a better way to do it myself

Any way of working this in?
`; Hide desktop icons
#Z::
ControlGet, HWND, Hwnd,, SysListView321, ahk_class Progman
If HWND =
ControlGet, HWND, Hwnd,, SysListView321, ahk_class WorkerW
If DllCall("IsWindowVisible", UInt, HWND)
WinHide, ahk_id %HWND%
Else
WinShow, ahk_id %HWND%
Return
`


Consider sharing D drive between applications

@tomsci was thinking this might be a nice, user-friendly way to get files out of apps and share them between apps.

Seems like this isn't really a v1 feature.


Fix shopify theme dev issue to avoid previewing the live theme instead of the development one

WHY are these changes introduced?
Fixes https://github.com/Shopify/cli/issues/3466
WHAT is this pull request doing?
It seems like the caching policy at SFR has changed, so we're implementing this temporary solution to clean it and mitigate the issue.
How to test your changes?

Delete your current development theme with shopify-dev theme delete -t <development_theme_id>
Run shopify theme dev
Notice that the localhost no longer loads the live theme; and the theme in localhost matches with the preview theme

Before

After

Post-release steps
None.
Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[x] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes
[x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Additional instructions are needed. I followed the instructions and can only confirm that the localhost link works in an incognito window. Does not work on standard window. I also attempted to clear local storage, cache, and cookies in standard window but still the same result.
CLI localhost is serving published theme not local files on "shopify theme dev" cli command.

Posting my comment here as well since #3466 has been closed and I fear that no one will look at it.

I'm working on a theme app extension and am facing a lot of issues where any change that I'm making in the code is not reflecting on the development store preview page that I'm adding the app block to (product pages). The changes are showing up only if I reload the product page several minutes after I made the code change. This is making the development effort extremely infuriating (sorry). I'm wondering if my problem is also related to this issue. Any fix or suggestion on this front will be greatly appreciated. Thanks.
What I've tried so far (unsuccessfully):

Reloading the dev store product page on which I'm rendering the data using the theme app extension
Disabling the cache for this page and reloading (initially assuming this to be a browser caching issue)
Deploying the extension again using npm run deploy and then previewing again using npm run dev. A support forum thread suggested that this might work.
Upgrading the @shopify/cli package to 3.56.3 after seeing the latest release, but it has sadly not helped.

More info:

Shopify CLI v3.56.2 (npm package)
MacOS Ventura 13.6.3
Node v18.18.2


allow consuming code to make local dev less painful

We want rails apps that use this to produce kafka messages to not require every contributor to have a running kafka on their machine. This method, called in an iniitializer, will allow branching based on connectivity, so that in local dev, a mock producer can be attached if necessary.

KafkaSession defaults to using a mock producer?

Yup, that's the default.

That feels off to me, like using a mock should be intentional and trying to use it without configuring a producer should be an error.

I can see that. Do you want that addressed now, or can we address it when I blow up this project & pull it into industrious core?

That's fine.


Fix wording for package uninstall

First log line of package uninstalling references the package to be installed instead of the one being uninstalled. Just referencing the correct package with this change

Which Traffic Control components are affected by this PR?

Traffic Control Cache Config (T3C, formerly ORT)

What is the best way to verify this PR?

Run a badass without the change that updates a package version, notice that the first uninstalling line references the new package instead of old. Update t3c, rerun, should see the correct uninstalling named package
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist

[ ] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@rob05c


support for DBAAS

support for DBAAS

Think we're missing quite a few endpoints...
    post :create, "/v#{ENV["CIVO_API_VERSION"] || "2"}/databases", requires: [:name, :size, :region]
    put :tags, "/v2/databases/:id/tags"
    put :update, "/v2/databases/:id"
    delete :remove, "/v#{ENV["CIVO_API_VERSION"] || "2"}/databases/:id", requires: [:id], send_delete_body: true
    put :upgrade, "/v#{ENV["CIVO_API_VERSION"] || "2"}/databases/:id/resize", requires: [:size, :id]

Also as we'll be supporting restoring back to a previous automated snapshot of the database, I guess there should be:
get :snapshots, "/v2/databases/:id/snapshots"
put :restore, "/v2/databases/:id/restore", requires: [:snapshot_id]

Also as we'll be supporting restoring back to a previous automated snapshot of the database, I guess there should be:
get :snapshots, "/v2/databases/:id/snapshots"
put :restore, "/v2/databases/:id/restore", requires: [:snapshot_id]

Do we need create snapshots?

Do we need create snapshots?

Unsure to be honest, I think we may just go with automatic snapshots at first (and we may not even launch with those, depending on how well they work and how much space they take).

Do we need start, stop, status endpoint?

I don't think we need start/stop, not planning on allowing that. Status I think would just be part of the DBAAS object itself, connect likewise, just part of the DatabaseSerializer. Stats let's not worry about for now, I don't know what stats we can provide and we're looking at a v1 release, so let's not go crazy.

Released to Rubygems.


Theme resetting at app launch

UPDATE:
Just tried it on my real android device and there it works perfectly.
Not sure why it doesn't work in the simulator.
Describe the bug
I have implemented the solution almost identical to the docs, but on a hot restart, the builder method runs twice, where on the first run has the correct theme which is set in the initial prop, but on the second run it's the light theme.
On a hot restart I can actually see the colors changing from dark to light in a split second.
Here is the first part of my root build method:
I'm using the GetX package, hence the GetMaterialApp method.
@override
  Widget build(BuildContext context) {
    return AdaptiveTheme(
        light: lightTheme,
        dark: darkTheme,
        initial: AdaptiveThemeMode.dark,
        builder: (light, dark) {
          print('light: ${light.scaffoldBackgroundColor}');
          print('dark: ${dark.scaffoldBackgroundColor}');
          return GetMaterialApp(
            navigatorKey: navigatorKey,
            locale: const Locale('sv', 'SE'),
            theme: light,
            darkTheme: dark,

Here is the output from my debug console:
flutter: light: MaterialColor(primary value: Color(0xff4caf50))
flutter: dark: MaterialColor(primary value: Color(0xff4caf50))
[GETX] Instance "GetMaterialController" has been created
[GETX] Instance "GetMaterialController" has been initialized
[GETX] Redirect to null
[GETX] GOING TO ROUTE /home
[GETX] Instance "HomeController" has been created
[GETX] Instance "HomeController" has been initialized
flutter: light: MaterialColor(primary value: Color(0xff673ab7))
flutter: dark: MaterialColor(primary value: Color(0xff673ab7))

As you can see the print in the build method runs twice with different values, where the first values represent the color in the dark mode, and the second time it's the values in the light mode.
Expected behavior
I expect the theme set in the initial prop to be the theme in use.
Smartphone (please complete the following information):

Device: iOS Simulator
OS: iOS 15.0
Version iPhone 13 Pro

UPDATE:
Just tried it on my real android device and there it works perfectly.
Not sure why it doesn't work in the simulator

If you have changed the theme to light at any point then it remembers the choice and persists that across the app lifecycle. You need to retrieve that persisted choice in runApp and pass it as initial value to avoid flashing like that. Because if you don't then it will render UI using that theme meanwhile it is retrieving last changed mode from storage and then applies that mode.
Checkout this section of the docs on how to do that: Get ThemeMode at App Start
If this is not the case for you then do let me know. I'll try to check this out as soon as I can. Thanks.

@BirjuVachhani Okay, I think I understand.
So the first time I run the app with adaptive_theme, the theme set in initial is saved in storage. After that it doesn't matter what I put in initial, because it overrides from storage?
I thought the await AdaptiveTheme.getThemeMode(); code did all of that, but now I see what it does.
Thanks for clarifying, and thanks for a great package!

@timmyrosen Yeah, that's why it is called initial so we only use it once.
AdaptiveTheme.getThemeMode(); only retrieves saved state from storage. It is not used automatically as it would require some static state which is not a good idea generally.
Thank you. I'm glad I could help. 🙌🏻


Indexing Ran Into Fatal Error Unexpectedly

I was trying to port a project to MLX from PyTorch when I noticed this behavior:

I am on main branch.

What do you expect to happen here?  This is a programming error where you are using more dimensions than the array has.

Sorry that was dumb of me, what I actually meant to show was:

Numpy equivalent:

But now that I think about it again, I should've probably done:


Add MantisHub support

How long does it take from the time this PR is accepted till it is updated for users of the add-on via the Chrome store?

@IndrekV just checking if you have noticed this pull request.  Thanks.

Sorry for not giving any feedback. I have noticed it. We have plans to change our permissions logic and that's why I can't simply merge and release this pull request. Currently every tool addition would need new permissions and the extension will be disabled until the user grants permissions.
The permission logic change would make it possible for users to enable permission to only the domains that they actually use so the update won't disable the extension. We usually do a release every other week or so.

Thanks @IndrekV for the clarification.
I'm wondering if the planned changes will change the way our integration is implemented.  Any reason why not to get this in and treat it like the N other integrations you already have in terms of evolving to the new approach?
Anyway, happy to help in whatever way to get this integrated.

@IndrekV Happy new year.  I've noticed that I got a new update of the toggl plugin.  Unfortunately, this PR wasn't integrated yet following new or old model.  Any updates on next steps?

I've started reviewing this pull request. In what view should the Start button appear. I haven't managed to see it yet. Could you please share screenshot and description.

The integration was quite incomplete. The selectors of the start timer button location were broken. I fixed the selectors and improved the styling.
Thank you for your contribution.


floorp: 11.19.0 -> 11.19.1

https://github.com/Floorp-Projects/Floorp/releases/tag/v11.19.1
Fixes https://www.mozilla.org/en-US/security/advisories/mfsa2024-51/#CVE-2024-9680
CVE-2024-9680
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

why would we add "security" label here? cannot found any clue in issues.

why would we add "security" label here? cannot found any clue in issues.

I have linked to the relevant CVE in my PR desciption. This bump fixes a critical RCE of the underlying Firefox codebase

why would we add "security" label here? cannot found any clue in issues.

I have linked to the relevant CVE in my PR desciption. This bump fixes a critical RCE of the underlying Firefox codebase

yep, sorry for this missunderstood, i've found links, thx.
i'll build locally as soon as i could.

Result of nixpkgs-review pr 347677 run on x86_64-linux 1

3 packages built:

floorp
floorp-unwrapped
floorp-unwrapped.debug

Hand-picked backport for 24.05: https://github.com/NixOS/nixpkgs/pull/347716
Currently building locally.


[DDC] Don't use CFE constructor tearoff lowering and instead use the same lowering as static method tearoffs

Currently, the CFE lowers tearoffs for constructors as static methods on the relevant class. DDC then forwards a call to this static method in order to fetch the tearoff. While this is useful, this means extra code size for every constructor e.g.
    static ['_#fact#tearOff']() {
      return library_name.ClassName.fact();
    }

and the calling code:
    get C0() {
      return C[0] = dart.fn(library_name.ClassName['_#fact#tearOff'], T$.VoidToClassName());
    },

C0 here is already a tear-off, so we should just leverage that instead of this dual indirection. We already do that with static methods:
    get C3() {
      return C[3] = dart.fn(library_name.ClassName.staticMethod, T$.VoidToString());
    },

So, instead of using the synthetic static methods for constructor tear-offs, we can just return a reference to the constructor instead e.g.
return C[0] = dart.fn(library_name.ClassName.fact, T.VoidToClassName());

cc @nshahan


Facebook messenger ignores users darkmode

Describe the bug
Facebook should be in darkmode if the users has dark mode set in facebook native or darkmode is set in franz. I believe upgrading to 5.6 caused this issue as it was not a problem previously.
To Reproduce
Steps to reproduce the behavior:
Go to facebook messenger and view that you are not in dark mode.
Expected behavior
Facebook should be in dark mode.
Screenshots

Desktop (please complete the following information):

OS: Linux Mint 20.1
Chrome, I assume
5.6.1

This is actually a Facebook issue and not a Franz issue.
I believe 5.6 started using https://messenger.com, while before this, it used https://www.facebook.com/messages/
If you go in your browser to https://messenger.com, you will see that it doesn't care about your Dark Mode setting from Facebook.com, and it will display a "Light" theme regardless.
And Messenger.com simply doesn't allow you to toggle dark/light theme at all.
If you add __fb-dark-mode to the <body>, you can actually get it in Dark Mode: https://i.imgur.com/Gkj0vWt.png

Thank you Znuff!! Most frustrating this is!! I cannot think its worth inspecting and changing the classes with each load tbh lol but I may well give it a whirl!!

%appdata%\Roaming\Franz\recipes\messenger\webview.js
open it up, add:
document.body.classList.add('__fb-dark-mode');
document.styleSheets[0].cssRules[1].style.setProperty("--header-height", "0px");

after "use strict";
reload service

Oh nice, I didn't realise they exposed the JS like that. I'm on linux but I
can work that out easy enough!! Nice one!
Thanks
Jamie
On Tue, 4 May 2021 at 21:05, Bogdan Ilisei @.***> wrote:

%appdata%\Roaming\Franz\recipes\messenger\webview.js
open it up, add:
document.body.classList.add('__fb-dark-mode');
document.styleSheets[0].cssRules[1].style.setProperty("--header-height", "0px");
after "use strict";
reload service
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/meetfranz/franz/issues/1974#issuecomment-832208639,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKILARZWR4PT4ADXIGUK6DTMBHRZANCNFSM4WQ3YAZA
.

You also might want to add this in the service.css:
._9dls {
  overflow-y: hidden !important;
}

::-webkit-scrollbar-track {
    background: hsla(0,0%,100%,.1);
}

::-webkit-scrollbar-thumb {
    background-color: rgba(0,0,0,.2);
}

::-webkit-scrollbar {
    width: 6px!important;
    height: 6px!important;
}

Follow-up on this, you may want:
.oo9gr5id {
    color: var(--always-white);
}

This fixes the black on dark-grey text in conversations.

Today's updates:
#pagelet_bluebar {
  display: none !important;
}

:root, __fb-dark-mode:root  {
  --header-height: 0px !important;
}

[role="banner"] {
  display: none;
}

.l3ldwz01 {
	display: none;
}

._9dls {
  overflow-y: hidden !important;
}

/* reduced scrollbar size */
::-webkit-scrollbar-track {
    background: hsla(0,0%,100%,.1);
}

::-webkit-scrollbar-thumb {
    background-color: rgba(0,0,0,.2);
}

::-webkit-scrollbar {
    width: 6px!important;
    height: 6px!important;
}

.oo9gr5id {
	color: var(--always-white) !important;
}

.cwj9ozl2 {
	background-color: #242526 !important;
}

/* fix background for dark mode */
.nred35xi {
    background-color: inherit !important;
}

/* fix chat bubble wash */
.e409flbk .j83agx80.k4urcfbm .qv66sw1b.odn2s2vf.tkr6xdv7 {
    background-color: #3E4042 !important;
}

/* fix edit box */
.hedjyaoh {
    transform: translateX(128px);
}

.qbubdy2e svg {
    display: none !important;
}

.msuhji6j {
    border: 0 !important;
}

/* hide install messenger button */
a[aria-label="Install Messenger app"] {
    display: none !important;
}

JS remains the same.

Hi @Znuff , I know that some time has passed since your last response but do you know how to change the response message also?
Anyway, I want to thank you for this tip, your response resolved pretty much everything that I needed so thanks for your work

Uh, this is actually an older revision of Messenger that this CSS fits, I haven't updated the post in a bit, so I'm not seeing the exact result you are showing me in the screenshot.
But I believe it should be:
.ll8tlv6m .cxgpxx05.qttc61fc {
    border: 1px solid red;
}

Unfortunately, this only changed border color, changing it to background-color/fill doesn't affect it and the problem still stays if the message comes from my site.
But you said about new CSS for messenger, maybe it's time for me to change it to a newer one if you can share it

...the border color was an example.
I don't know what other color it should be, just change the property.

Yuh I know, but that's what  I've said, changing background-color doesn't do anything here
.ll8tlv6m .l3s49flk .cxgpxx05 {
  background-color: red;
}

With this nothing changed in the app :)

If someone is still looking for answer this worked for me

/*Color of highlighted message someone is replying to*/
.ll8tlv6m .l3s49flk .cxgpxx05 {
  background-color: #1e1e1e !important;
}

/* Color of highlighted message you're replying to*/
.ns4p8fja.j83agx80.cbu4d94t.a6sixzi8.bkfpd7mw.d2edcug0.buofh1pr.nred35xi.akiltmtj.l3s49flk
  .d2edcug0
  .cxgpxx05 {
  background-color: #1e1e1e !important;
}

Update 25-February:
Use darkmode.css found here:
https://github.com/ducfilan/Dark-mode-Franz-Ferdi


RuntimeError: Expected object of type torch.FloatTensor but found type torch.LongTensor for argument #2 'exponent'

I want to train ade20k on pspnet
i use your train_cnn, but it appears like this one
File "/home/victor/catkin_ws/src/semantic_slam/semantic_cloud/include/ptsemseg/loss.py", line 74, in multi_scale_cross_entropy2d
scale_weight = torch.pow(scale * torch.ones(n_inp), torch.arange(n_inp))
RuntimeError: Expected object of type torch.FloatTensor but found type torch.LongTensor for argument #2 'exponent'
can anybody help me?

Hi, @victor123499 .
Change 'exponent' tensor type to float:
scale_weight = torch.pow(scale * torch.ones(n_inp), torch.arange(n_inp).float())

and it still have the problem like this
RuntimeError: cuda runtime error (59) : device-side assert triggered at /pytorch/aten/src/THC/generated/../THCReduceAll.cuh:317

Maybe you can check whether your target labels are in the range [0, n_classes-1].

@adam9500370  i figure out this problem.
Is my labels problem. Thank you.


RSA-PSS signature verification

Also tested against a signature from the BSI dataset (to be added with #6).


Migrate to ZWave JS v7

Points of interest.

Nodes will no longer be re-interviewed on driver restart. 🎉
We can now remove that (hacky) check on restart
Notification event changes.

@hufftheweevil,
I’m am prepping 2.1 for v7 of ZWJS.
The change log notes that the Meter CC, will have some values removed - which I believe you worked around.
https://github.com/zwave-js/node-zwave-js/releases
Will your work around, now cause an exception?

Well how bout that. I guess I'm just ahead of my time.
It won't cause any issues. But I can remove the tooltip on the next update. No hurry.


Msys2

https://chocolatey.org/packages/msys2
Description
Embedded, made automatic package, and modernized. Documented relation with ruby installer.
How Has this Been Tested?
Locally
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Migrated package (a package have been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this mean usually the notes in the description of a package).
[x] I have updated the documentation accordingly (this mean usually the notes in the description of a package).
[x] All files is up to date with the latest Contributing Guidelines
[x] The added/modified package passed install/uninstall in the chocolatey test environment.
[ ] The changes only affect a single package (not including meta package).

Original Location

Original Repository
Open Issues
[ ] Include the link to the opened PR that removes the package from the original location
[x] The migration guidelines have been followed

/cc @userzimmermann @petemounce

Do we need to create a PR to remove from upstream repository?  Or are we saying that this isn't needed since it isn't an automated repository i.e. AU/ketarin?

I don't PR non automatic packages because there is no damage, links to package source on older versions work and maintenance is already a lot of work.

Understood, just wanted to check.


Add nchs-mortality raw data backups and backup export utility

Description
Add nchs-mortality raw data backups and backup export utility
Changelog

add create_backup_csv fn in delphi_utils/export.py
use the utility in nchs_mortality's pull_nchs_mortality_data fn

Associated Issue(s)
Context and writeup

I guess the test is failing (on linting, with delphi_nchs_mortality/pull.py:11:0: E0611: No name 'create_backup_csv' in module 'delphi_utils' (no-name-in-module)) because the new fn is being added to delphi_utils at the same time.

Thanks for your quick feedback @minhkhul!

Add some logging to note on which indicator stashing is done

Agreed. Related to this, @korlaxxalrok suggested including metadata in each day's backup data or unique IDs we can use to track provenance of downstream data. Designing that will likely be too complex and thus take too long for getting V1 of data backups out, but could be very useful in the future.

Adjust the params.json.template in nchs_mortality as well.

I don't have strong feelings about this, but given the default the custom_run param takes in the code means we don't necessarily need to add it to params.json.

suggestion: When I wrote and run the script to stash nssp source similar to this on one, the small vm ran out of disk space at one point. To save disk space, apart from adding zipping, I also added a feature to check if there has been changes at all to the dataset in comparison to the latest past csv.gz on disk, and only save the latest new version of the dataset after confirming there's a difference. It's helpful on a weekly signal like nssp. I think it'd be nice to add that but not needed.

Hm, so we've found that saving data like this causes storage issues. Since you refer to a "vm", I wonder if the limit you hit was that of the VM (O(1 GB)) rather than with the host machine (O(100 GB)). How big is that entire collection of backups?
RE "only sav[ing] the latest new version of the dataset after confirming there's a difference" with the last backup, do we think this is safe/robust enough to do? One initial concern is that this is starting to sound like "archive differ V2". Of course, it's simpler than the current one, but any extra code increases the risk of bugs. To know how to balance the risk, we'd want an estimate of how big the data backups would be.

Yep I very much agree with the potential for an archive differ v2 problem. Let's scratch that for now.

Also, been running this daily this since yesterday and keep the backup file, so we can take our time w this PR.


request for addition and spelling typo

hi! very useful package :)
I was scratching my head trying to find "Hong Kong" in the listing, and for some reason it's missing. I'm quite positive that it deserves to be in the top 10k :)
also, minor detail, but I thought I'd mention: Colombia is spelled as "Colombi" in this listing, I don't think that matches any particular spelling.
out of curiosity, what is the source for the data?

Thanks. I just fixed the dataset.
Sorry. But I don't remember exactly where the data came from.


ANC Subs Visit - Maternal Mental Health Activity Infrastructure [2h]

Issue
We are adding a new activity to the ANC Subsequent Visit at the Health Center - Maternal Mental Health. This activity should appear before the Photo activity in the tray. This activity should appear starting at 28 weeks EGA. It only needs to be done once during pregnancy, so once it is completed once it should not appear again.
Icon SVG can be found in Figma - Components - Icons

Related Issues:

#290
#291

Video overview can be found in issue #290

To Do:

Create the infrastructure for the Maternal Mental Health activity

https://nutrition-ihangane.pantheonsite.io/
QA Review
Checked and approved:

Maternal mental health icon displays before the Photo icon, if EGA is greater than 28 weeks.

After 28 week EGA
Before 28 week EGA

@balagan73
This part needs verification as well: It only needs to be done once during pregnancy, so once it is completed once it should not appear again.

@balagan73 were you able to verify the above ^^

@adamhstewart  Yes, point 2 deals with that part of the issue..


Bugfix/internal state transitions fix

Minor bugfix so no python error during d2 rendering if a state transitions to itself
Explicitly specify rendering engine as default renderer has issues when a parent state machine has a transition to itself
Add feature: if an action function is specified for a given transition, it will be shown on the graph

closing pull request - need to update for pytest

Looks good.  Thanks for fixing.  Ready to merge.


Segmentation map is different after conversion

Hi!
I'm trying to convert BiSeNet from PyTorch to TFLite (PyTorch -> ONNX -> OpenVino -> TF). I followed steps from your article, except conversion to ONNX. For PyTorch -> ONNX conversion I used
torch_out = torch.onnx._export(net, dummy_nhwc, "bisenet.onnx", export_params=True,
                               input_names=['input'],  output_names=['output'], opset_version=11)

When I use pytorch_to_onnx.py from openvino, I get following error:
UserWarning: ONNX export failed on upsample_bilinear2d because align_corners == True not supported
RuntimeError: ONNX export failed: Couldn't export operator aten::upsample_bilinear2d

After conversion to tflite output segmentation map differs from output of pytorch and onnx model.
Output of onnx:

Output of tflite:

I tried to convert model with --output_edgetpu True and False (to resize with tf.compat.v1.image.resize_* and with tf.image.resize), but both tflite models produce same results. Any help would be appriciated!
Environment:
tf-nightly                    2.5.0.dev20210128
openvino2tensorflow           1.5.8

I would like to verify this.

Is it possible to share the URL of the repository you used, or the PyTorch repository? If you have created your own model, it would be great if you could also provide me with the code for testing.
By the way, the model committed in the following URL is the face segmentation model of BiSeNetV2, does the problem still occur when using this model?

BiSeNetV2 (celebamaskhq)
https://github.com/PINTO0309/PINTO_model_zoo/tree/main/057_BiSeNetV2/02_celebamaskhq

I would like to verify this.

Is it possible to share the URL of the repository you used, or the PyTorch repository? If you have created your own model, it would be great if you could also provide me with the code for testing.
By the way, the model committed in the following URL is the face segmentation model of BiSeNetV2, does the problem still occur when using this model?

BiSeNetV2 (celebamaskhq)
https://github.com/PINTO0309/PINTO_model_zoo/tree/main/057_BiSeNetV2/02_celebamaskhq

Thank you for reply,

I use model from https://github.com/zllrunning/face-parsing.PyTorch
Yes,
https://drive.google.com/file/d/1-84uVDUKEEcGdRFeorB7SMM_3J_jRO48/view?usp=sharing -- this is version before onnx simplifier,
https://drive.google.com/file/d/1aCFmd4fyGt2OKnBWnX9pS9cS8ZEIPmBC/view?usp=sharing -- after.
I also tried to skip onnx simplifier step to check if it affects final result, but nothing changed.
I tried to convert float32/saved_model_448x448/saved_model.pb to tflite, and problem didn't occur. Result is the same as after saved_model_448x448/model_float32.onnx. But I want to modify this pytorch model, so I need the way to convert pytorch models to tflite. I tried onnx-tensorflow before, but I need to convert model from NCHW to NHWC, and get rid of extra transposes.

I also tried to convert model from 07_openvino (FP32 256x256 and 448x448) to tflite, and convert model from float32 to openvino and then to tflite, and in all cases got following error:
Traceback (most recent call last):
  File "/usr/local/bin/openvino2tensorflow", line 2201, in <module>
    main()
  File "/usr/local/bin/openvino2tensorflow", line 2197, in main
    yolact, debug, debug_layer_number)
  File "/usr/local/bin/openvino2tensorflow", line 577, in convert
    x_outputs = [conv(x_split) for x_split, conv in zip(x_splits, convs)]
  File "/usr/local/bin/openvino2tensorflow", line 577, in <listcomp>
    x_outputs = [conv(x_split) for x_split, conv in zip(x_splits, convs)]
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 972, in __call__
    input_list)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 1111, in _functional_construction_call
    inputs, input_masks, args, kwargs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 841, in _keras_tensor_symbolic_call
    return self._infer_output_signature(inputs, args, kwargs, input_masks)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 881, in _infer_output_signature
    self._maybe_build(inputs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 2722, in _maybe_build
    self.build(input_shapes)  # pylint:disable=not-callable
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/layers/convolutional.py", line 205, in build
    dtype=self.dtype)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 655, in add_weight
    caching_device=caching_device)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/training/tracking/base.py", line 810, in _add_variable_with_custom_getter
    **kwargs_for_getter)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer_utils.py", line 142, in make_variable
    shape=variable_shape if variable_shape else None)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variables.py", line 260, in __call__
    return cls._variable_v1_call(*args, **kwargs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variables.py", line 221, in _variable_v1_call
    shape=shape)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variables.py", line 199, in <lambda>
    previous_getter = lambda **kwargs: default_variable_creator(None, **kwargs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variable_scope.py", line 2624, in default_variable_creator
    shape=shape)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variables.py", line 264, in __call__
    return super(VariableMetaclass, cls).__call__(*args, **kwargs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/resource_variable_ops.py", line 1586, in __init__
    distribute_strategy=distribute_strategy)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/resource_variable_ops.py", line 1713, in _init_from_args
    initial_value = initial_value()
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/initializers/initializers_v2.py", line 237, in __call__
    self.value, dtype=_get_dtype(dtype), shape=shape)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/framework/constant_op.py", line 265, in constant
    allow_broadcast=True)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/framework/constant_op.py", line 276, in _constant_impl
    return _constant_eager_impl(ctx, value, dtype, shape, verify_shape)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/framework/constant_op.py", line 325, in _constant_eager_impl
    (num_t, shape, shape.num_elements()))
TypeError: Eager execution of tf.constant with unsupported shape (value has 54 elements, shape is (3, 3, 1, 1) with 9 elements).

Thank you for reply,

I use model from https://github.com/zllrunning/face-parsing.PyTorch
Yes,
https://drive.google.com/file/d/1-84uVDUKEEcGdRFeorB7SMM_3J_jRO48/view?usp=sharing -- this is version before onnx simplifier,
https://drive.google.com/file/d/1aCFmd4fyGt2OKnBWnX9pS9cS8ZEIPmBC/view?usp=sharing -- after.
I also tried to skip onnx simplifier step to check if it affects final result, but nothing changed.
I tried to convert float32/saved_model_448x448/saved_model.pb to tflite, and problem didn't occur. Result is the same as after saved_model_448x448/model_float32.onnx. But I want to modify this pytorch model, so I need the way to convert pytorch models to tflite. I tried onnx-tensorflow before, but I need to convert model from NCHW to NHWC, and get rid of extra transposes.

I also tried to convert model from 07_openvino (FP32 256x256 and 448x448) to tflite, and convert model from float32 to openvino and then to tflite, and in all cases got following error:
Traceback (most recent call last):
  File "/usr/local/bin/openvino2tensorflow", line 2201, in <module>
    main()
  File "/usr/local/bin/openvino2tensorflow", line 2197, in main
    yolact, debug, debug_layer_number)
  File "/usr/local/bin/openvino2tensorflow", line 577, in convert
    x_outputs = [conv(x_split) for x_split, conv in zip(x_splits, convs)]
  File "/usr/local/bin/openvino2tensorflow", line 577, in <listcomp>
    x_outputs = [conv(x_split) for x_split, conv in zip(x_splits, convs)]
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 972, in __call__
    input_list)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 1111, in _functional_construction_call
    inputs, input_masks, args, kwargs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 841, in _keras_tensor_symbolic_call
    return self._infer_output_signature(inputs, args, kwargs, input_masks)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 881, in _infer_output_signature
    self._maybe_build(inputs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 2722, in _maybe_build
    self.build(input_shapes)  # pylint:disable=not-callable
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/layers/convolutional.py", line 205, in build
    dtype=self.dtype)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 655, in add_weight
    caching_device=caching_device)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/training/tracking/base.py", line 810, in _add_variable_with_custom_getter
    **kwargs_for_getter)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer_utils.py", line 142, in make_variable
    shape=variable_shape if variable_shape else None)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variables.py", line 260, in __call__
    return cls._variable_v1_call(*args, **kwargs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variables.py", line 221, in _variable_v1_call
    shape=shape)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variables.py", line 199, in <lambda>
    previous_getter = lambda **kwargs: default_variable_creator(None, **kwargs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variable_scope.py", line 2624, in default_variable_creator
    shape=shape)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/variables.py", line 264, in __call__
    return super(VariableMetaclass, cls).__call__(*args, **kwargs)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/resource_variable_ops.py", line 1586, in __init__
    distribute_strategy=distribute_strategy)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/ops/resource_variable_ops.py", line 1713, in _init_from_args
    initial_value = initial_value()
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/keras/initializers/initializers_v2.py", line 237, in __call__
    self.value, dtype=_get_dtype(dtype), shape=shape)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/framework/constant_op.py", line 265, in constant
    allow_broadcast=True)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/framework/constant_op.py", line 276, in _constant_impl
    return _constant_eager_impl(ctx, value, dtype, shape, verify_shape)
  File "/home/masha/.local/lib/python3.6/site-packages/tensorflow/python/framework/constant_op.py", line 325, in _constant_eager_impl
    (num_t, shape, shape.num_elements()))
TypeError: Eager execution of tf.constant with unsupported shape (value has 54 elements, shape is (3, 3, 1, 1) with 9 elements).

Thanks for the detailed explanation.
OK, I understand your intentions. Please give me some time to investigate.

Thanks for the detailed explanation.
OK, I understand your intentions. Please give me some time to investigate.

Hi! I found out that this problem is caused by padding in Conv2D layer. I inserted ZeroPadding2D before Conv2D here and used mode='valid' in Conv2D if data.attrib['pads_begin'] contains nonzero values (otherwise didn't change anything), and it solved my problem.

I am not sure if it is the same as the fix you gave me, but it looks like the figure below. I still feel a little out of alignment. GroupConvolution (DepthwiseConv2D) seems to have the same problem.


[CODE IMPROVEMENT] Follow up on classification problem type

🔧 Proposed code refactoring
Some features we can add for text classification:

Remove generation parameters from Prediction Config, as not needed
Disable Chat Window
Remove answer int from tokenized insights
Extract a separate dataset class for classification

Motivation

Better UX
More disentangled codebase

I'm not sure about the implementation complexity, but I'd like to propose the following improvements (if they are not by design so):

Automatically infer the number of classes from the target column, rather than requiring the user to set it manually.
Ensure only appropriate loss functions are selectable. For instance, for multi-class classification, the selected one by default is BinaryCrossEntropyLoss, which obviously won't work.

Closing this issue, implemented by #481 and #499.
@a-ghorbani Currently, we don't plan to automatically infer/encode number of classes.


Allow video formats other than MP4 in CLI

I'm trying to batch process multiple videos to append together. The GUI interface lets you export to other formats (e.g. MKV) by selecting "All files (*)" in the filetype dropdown; however, there doesn't seem to be a way to set the output format via the CLI interface. As someone that wants to take advantage of the maximum possible audio/video quality, I am disappointed at this and hope that this can be implemented sometime.

Sorry for that. https://github.com/corrscope/corrscope/blob/f45c92fc1a97cb03fa97add5a5d82eedeb80a7ee/corrscope/cli.py#L225
Maybe when I get back to development, I'll change --write and --render to take filenames.


Bloxstrap desktop bug

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
Everytime i open the Play Roblox, it doesn't open the roblox desktop app but opens a roblox tab on my browser. Does someone know how to fix this?

You have the desktop app disabled. You chose to disable it in the Bloxstrap Menu.

You have the desktop app disabled. You chose to disable it in the Bloxstrap Menu.

How can i enable it?

Open the Bloxstrap Menu, go to the Mods section. The option is there.


help w/ modernizing QIIME 2?

Hello,
Will QIIME 2 use Python 3.5?  If so, are there some tasks I could help with?  Best, AJP

QIIME 2 is compatible with Python 3.5. Are there any tasks in particular you'd like to help with?

I'm going to close this issue. @ajpowel, if there are specific tasks you'd be interested in helping with, we can communicate on specific issues.

Hi there,
I would like to get a feel for qiime2 before I identify areas where I could
contribute.  Many thanks for your response.
Best,
AJP
On 17 April 2017 at 11:54, Greg Caporaso<EMAIL_ADDRESS>wrote:

I'm going to close this issue. @ajpowel https://github.com/ajpowel, if
there are specific tasks you'd be interested in helping with, we can
communicate on specific issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/qiime2/qiime2/issues/247#issuecomment-294541947, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APG2vGppn2dLC24NDJJwfWyV_Evrdtndks5rw6dJgaJpZM4M5GdZ
.

--
Regards, AJP


Error

A:\Documents\arbitrage-moments-master>python3 start.py
Traceback (most recent call last):
File "start.py", line 25, in
if market['percent_volume'] >= MINIMUM_PERCENT_VOL and market['is_updated'] and (trades_into in ACCEPTABLE_TRADING_PAIRS or ALL_PAIRS):
KeyError: 'is_updated'
not to sure what's causing this error

oh crap I modified that package myself. Can you modify your pymarketcap


Cannot load ACP after upgrading NodeBB version

Looks like ns-custom-fields is causing some issues after upgrading: https://github.com/NodeBB/NodeBB/issues/5756#issuecomment-309311112

The plugin prevents a minification process for ACP scripts.

Ok. After some investigation, I have discovered that there is an issue with plugin's acp.js script.
When I have excluded script from minification, NodeBB ACP builds correctly...


Use Dockcross manylinux2014-aarch64 cross-compiling toolchains

Current error log: https://github.com/agriyakhetarpal/hugo-python-distributions/actions/runs/7917068310/job/21612357102
Note to self: looks like this is coming from an improperly configured stdlib – cannot understand the error message fully so far

Possible error: Dockcross GCC is too old to support the C++11 standard! (-D_GLIBCXX_USE_CXX11_ABI=0 may or may not work).
Maybe manylinux_2_28 Docker images can help (and therefore resolve #15 too)

dockcross/manylinux_2_28-aarch64 is not available yet...

Superseded by #66, owing to the reasons provided in the comments at #16.

Superseded by #66, owing to the reasons provided in the comments at #16.


[WARNING] I am not supposed to do this. I think you have a security issue.

This PR is a simple test about creating a PR inside a repository I don't own permissions to operate, although I can create PRs into.
Apparently you can do this in any repo and I've reported this already to Support but they didn't found the source of the issue. I think I found it.
I think that opening PRs inside a repository by any other user should be allowed only from their personal forks into the main forked repository. If that's not the case, I lost the point where Github started to allow this.
Would you be able to consider ironing this part and fixing it instead please?
Thank you in advance,
Julian

https://github.com/github/docs/commit/854238357105a6da2bdc1f32e14a343ff0352a98

8542383


Sitemap index: split sitemap for large projects

Just discovered this, after successfully implementing this library (which is great and works as expected), search engines like Google state the following about sitemaps:
A sitemap file can't contain more than 50,000 URLs and must be no larger than 10 MB uncompressed.
(Source)
The sitemap library used in this project, supports building a sitemap index, which refers to multiple sitemaps, which is acceptable to Google.
I believe this library could be updated to use/support this functionality.
I suggest the following approach:

Split sitemap at 49,999 urls -> new sitemap
Always generate a sitemap index referring to one or multiple sitemaps
To prevent breaking changes, save splitted sitemaps as chosen filename string-replacing .xml with
-[:sitemapIndex].xml.

@kuflash Are you willing to accept a PR implementing this?

To clarify: I'm working on a project which easily generates 100.000+ urls

@Matzu89 if you can implement this feature, then I will gladly accept PR.

Great, will push something later this week


Bug 2067076: show message when there are more than 1 host in sno clusters

Related to https://github.com/openshift-assisted/assisted-ui-lib/pull/1270

Included in https://github.com/stolostron/console/pull/1468


chore: replace usage of deprecated otel-collector methods

Otel collector pdata methods working with primitive slices are going to be migrated to immutable data types. This is the first step in the backward compatible change spanning across multiple version.s

@dmitryax  please amend commit message and PR title, then we should be good.

@jacobmarble thanks. Updated

@jacobmarble somehow at one point (starting with one golintci version) staticcheck stopped detecting these changes...


Addded and marked my location on hacktobermap

Thanks for contributing! But you have made the pull request to your own repository. Go to https://github.com/abhijitparida/hacktobermap and then make a pull request.


docs(scully): add brunoelo blog to showcase

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/main/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Other... Please describe:

Added BrunoElo Blog to Scully showcase.
What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Query

Is there a way to use sql query instead of query builder?
$builder = $db->query("select * from users")
return DataTable::of($builder) ...

can't do for now. query string can't converted to Builder object.


Implement a health check API to track the status of Greenlight for better error handling.

We are currently using Breez-SDK in our app, which includes a health check API to track the status of the Breez server. However, it doesn't include a Greenlight health check. It would be great to add a health check API for tracking the Greenlight status so that we can implement better error handling in our app.
@cdecker: https://discord.com/channels/899980449231814676/900323634512551946/1193584731900612789

Thanks for reporting this issue, giving it a place to be discussed. This has been requested by several users, and we'd love to provide a status API, however it is not that easy to boil the system status down to a single red or green bubble. Take for example the scalability dimension we chose: nodes. If a single node is having issues, does the system as a whole count as (partially) unavailable, or is it operating as expected? I'd argue it is still within normal operations, but the user whose node is having issues (e.g., missing a signer, failing a payment, failing to reconnect to a peer), the system looks unavailable and unstable.
We will of course add statuses for the core services such as the tower and the scheduler, but those have 99.9+% uptime as we speak, and mostly it's the fleet of user nodes encountering issues individually, which we then fix up asap, but declaring the entire system unavailable because a small subset of users is having a sub-optimal time doesn't help others, as the experiences are rather subjective due to the separation between tenants on our system.
TL;DR: we need to define the semantics of available / unavailable for the nodes before we can provide a useful status indication for GL as a whole.


AdGuard does not decrypt insecure HTTPS webpage if visitor proceed

Summary
If TLS certificate of a webpage is invalid and a visitor proceeds to visit by accepting the risks, AdGuard does not decrypt the insecure HTTPS webpage.
Related issue: https://github.com/AdguardTeam/AdguardFilters/issues/170155
Environment

AdGuard for Windows 7.16.0
AdGuard for Android 4.3.1

How to reproduce

Add the following rule into your user rule:badssl.com##html #content

Reproduce the issue by visiting invalid one and valid one at https://badssl.com.

Works as expected, there is no way for us to know if the user accepted the certificate or not in the browser


Text colouring garbled

Issue Type: Bug
When working on my files, of which some are maybe long like 8 Megabtyes (just mentioning). The colouring is garbled in the sense that within a it starts with the correct colour, but somewhere in the word it changes to another colour and maybe back again to the correct colour. But anything can happen.
The text seems to be coloured correctly when loading after a fresh start of Visual Studio Code.
BTW the interpretation of the code gets very slow with these file sizes.
Mind you I am using files that are a fraction of the memory available (32 Gigabytes).
Thanks!
 Also, can you paste a screenshot?

OK, it is an intermittent problem but regularly comes back. I believe it depends on the amount of editing I do.
It is my first post here, and the form from within Visual Code did not have any image upload capability.
To put in words: It looks very 'festive' and random. The extension doing the colouring of the text based on the language I am using. I am not sure if that is IntelliSense or another module.
I am coding in C/C++, filename is main.cpp (I guess it adapts to the .cpp to select the language for colouring). I will post a screenshot when it happens again, which I expect in the comming days.

If you capture a screen region onto your clipboard you should be able to paste it into the GitHub textarea field when you add a comment. Or drag a gif file and drop it onto that field.


not able to merge anything .

not able to merge anything . I have no rights to do this and no functions for this .


Status Page Sort

Hey there @moonrailgun! Great work with this repo, the aesthetics choices are well done and the API is lightning quick too.
I have a suggestion for the status page:

Currently, I might want to see different views over the page, such as:

Currently Down pages first
Highest latency first
etc.

I'm thinking this could be a selector on the page. This will help a user to to view at a glance if their system is healthy.

If you think this is a good idea, I can work with you to get this implemented. Thanks!

i think its a good idea!
did you wanna submit a PR about it?
i am current refactor status page which can support more complex feature and display way. maybe you can waiting next version if you wanna create a feature about it.

sure, I'll wait then. If you can fit this feature inside your refactor,
that would be much appreciated too 👍
On Mon, 16 Sept 2024, 1:29 am moonrailgun, @.***> wrote:

i think its a good idea!
did you wanna submit a PR about it?
i am current refactor status page which can support more complex feature
and display way. maybe you can waiting next version if you wanna create a
feature about it.
—
Reply to this email directly, view it on GitHub
https://github.com/msgbyte/tianji/issues/98#issuecomment-2351689557, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANKA5L3XKBKX3GQ5XWLFNLLZWW7ZHAVCNFSM6AAAAABOH2LE22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGY4DSNJVG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I took a stab at this yesterday, the state for each monitor is all the way down in each MonitorListItem while we would probably want to put the sort component in ServiceStatusPage or MonitorListPage. Not sure how to tackle this.
Also, I think more comprehensive documentation for contributors on the README would help future developers - currently, the only docs are on the website, about db migration. I could also take a quick stab at that sometime later if you want.

i finish monitor status page refactor recently, now we can publish ordered monitor list, and group monitors.
feel free to check it in v1.15.x

Is there documentation about creating an ordered monitor list?

Is there documentation about creating an ordered monitor list?

just simple drag it.


Music only available on P0

Could an advanced block be exposed to change the Pin for music?

I am not sure blocks are the right place. Typescript API needs this for sure.

You can control the music output via an advanced block pins.analogSetPitchPin.

https://github.com/Microsoft/pxt-microbit/pull/309


pythonPackages.py3buddy: init at unstable-2019-09-29

Motivation for this change
Add python code to work with MSN iBuddy. Ideal for CI and Hydra notifications.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build pythonPackages.py3buddy

@GrahamcOfBorg build python3Packages.py3buddy

apparently i forgot to hit submit like.. 2 hours ago. lol

@jonringer addressed in https://github.com/NixOS/nixpkgs/pull/72106


Add ImageProxy & FileProxy

Pull Request Etiquette

[X] I have checked the PRs for upcoming features/bug fixes.
[X] I have read the contributing guidelines.

Changes

[X] Internal code
[X] Library interface (affecting end-user code)
[X] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
This PR adds ImageProxy, AttachmentProxy and FileProxy to allow easier image and file downloading. This also adds convenience methods where URLs are found

Is this PR ready for review?

Was just waiting to see if changes needed to be done:
Do we completely remove getters such as #getXUrl and #getXId respectively in favor of FileProxy#getUrl and ImageProxy#getId ?
I'm also not a big fan of abbreviations not being uppercase, following #getJDA casing I think it would be better to have #getID and #getURL

@freya022 could you address the review comments on this?


TypeError: customConfig.configure is not a function

I'm probably just not understanding how to get aurelia-knockout set up. Others have seen a similar error (https://github.com/aurelia/bootstrapper-webpack/issues/2). Here's what I did:
After creating a new app with au new, I cp -r .../aurelia-knockout/dist/es2015 into .../src/aurelia-knockout in my new app. Then (with au run --watch) I get Error: ENOENT: no such file or directory, open .../src/knockout.js. So then I put a copy of knockout.min.js in .../src, and then au run doesn't complain anymore, but the browser console gives me the vendor-bundle.js:3394 TypeError: customConfig.configure is not a function error.

It looks like that first error is the problem. Do you have knockout configured in your project? If you're using Aurelia CLI, make sure that you have it listed in the deps sections, or somewhere where it's defined. Most times when you see an error saying that you can't find a module in the src directory and the module it's looking for is just a name (like knockout), it's because in your code you tried to import "knockout", but since it's not defined in any config, it just assumes you're trying to load the file called "knockout" in the base directory.

I can't reproduce this error directly. I agree with @AStoker that situations where you want to copy files to other directories are often caused by missing path configuration in your app.
What I've done (this worked for me):

Created a new app with "au new"
Installed aurelia-knockout with npm
Configured aurelia-knockout as plugin in the main.js
Added the following items to the "dependencies"section in "aurelia.json" under "aurelia_projects" folder:

{
  "name": "aurelia-knockout",
  "path": "../node_modules/aurelia-knockout/dist/amd",
  "main": "aurelia-knockout"
},
"knockout"

In my test I also added "aurelia-history-browser" because the app does not find the module...
Then I was able to start the app with "au run" and use knockout binding syntax in html. I only got one error in my browser console: "Uncaught ReferenceError: exports is not defined". This happend in my "aurelia-knockout" module but I don't know why. I compared this file with the corresponding file from "aurelia-templating-resources" and found no important differences. So I don't know why this is handled in another way.... Maybe someone else knows.

@code-chris, specifically what line was causing the error? It sounds like something else might be hosed, because exports is essentially the object that we're exporting for AMD (it's the way ES6 gets transpiled to AMD). Also, wouldn't you want "knockout" defined before your "aurelia-knockout" dependency? I'm pretty sure that the dependencies are loaded in order, but it might not cause a problem if it's all modular anyway.

@AStoker Thanks for your note with the dependency order ;) The error happend on line 4 in the amd compiled "aurelia-knockout.js" file from my package:
Object.defineProperty(exports, "__esModule", {

I've seen that this code block is not surrounded with the define block in the bundle. So no exports variable is available there...

@code-chris, so you're saying that when it's in the bundled code, you don't have that module wrapped in a define block like this?
define(['exports', './aurelia-knockout-custom-attribute', './knockout-composition', './knockout-bindable'], function (exports, _aureliaKnockoutCustomAttribute, _knockoutComposition, _knockoutBindable) {
  'use strict';

  Object.defineProperty(exports, "__esModule", {
    value: true
  });
  exports.configure = exports.KnockoutBindable = exports.KnockoutCustomAttribute = undefined;

  function configure(frameworkConfig) {
    frameworkConfig.globalResources('./aurelia-knockout-custom-attribute');

    frameworkConfig.container.get(_knockoutComposition.KnockoutComposition).register();

    _aureliaKnockoutCustomAttribute.KnockoutCustomAttribute.register();
  }

  exports.KnockoutCustomAttribute = _aureliaKnockoutCustomAttribute.KnockoutCustomAttribute;
  exports.KnockoutBindable = _knockoutBindable.KnockoutBindable;
  exports.configure = configure;
});

Yes. It looks like this:
'use strict';

Object.defineProperty(exports, "__esModule", {
  value: true
});
exports.configure = exports.KnockoutBindable = exports.KnockoutCustomAttribute = undefined;

var _aureliaKnockoutCustomAttribute = require('./aurelia-knockout-custom-attribute');

var _knockoutComposition = require('./knockout-composition');

var _knockoutBindable = require('./knockout-bindable');

function configure(frameworkConfig) {
  frameworkConfig.globalResources('./aurelia-knockout-custom-attribute');

  frameworkConfig.container.get(_knockoutComposition.KnockoutComposition).register();

  _aureliaKnockoutCustomAttribute.KnockoutCustomAttribute.register();
}

exports.KnockoutCustomAttribute = _aureliaKnockoutCustomAttribute.KnockoutCustomAttribute;
exports.KnockoutBindable = _knockoutBindable.KnockoutBindable;
exports.configure = configure;

The modules below and above of this are surrounded as expected.

Hm, this snippet is equal with the commonjs distro... But I've defined the amd version in aurelia.json

But the other modules like "aurelia-knockout/aurelia-knockout-custom-attribute" are included as amd...

I just followed @code-chris's instructions from 11:44am edt (except for 'added "aurelia-history-browser"', which I didn't know how to do), and I'm getting no errors so far. I was just going about it all wrong. But I have still to try to get some knockout stuff running, so I may be back...  Thanks for the help!

ok. Closed, for now.

@Sigfried @code-chris, I am not able to reproduce any of the errors mentioned on a clean CLI installation. @Sigfried, based off your comments from the other error, I think you're probably messing a few things up by just copying files. If you're using the CLI do these steps.

Run npm install knockout aurelia-knockout --save

Go to the aurelia.json file located in the aurelia_project folder and add these configurations to the end of the dependencies list under build > bundles > vendor bundle:

"knockout",
{
   "name": "aurelia-knockout",
   "path": "../node_modules/aurelia-knockout/dist/amd",
   "main": "aurelia-knockout"
},

Configure the plugin by opening up your main.js and add the line .plugin('aurelia-knockout') to the aurelia.use line. It should look like this:

aurelia.use
    .standardConfiguration()
    .feature('resources')
    .plugin('aurelia-knockout');

Add the attribute knockout to a tag (not the <template> tag) and use knockout like you normally would:

<template>

${message}

</template>

Your view model can remain the same if you want.
export class App {
  constructor() {
    this.message = 'Hello World!';
    this.subMessage = 'Hello Knockout!';
  }
}

I hope this helps you get your setup @Sigfried. And perhaps @code-chris that would help documentation for installing with the CLI. The CLI is still in alpha and can be a bit complicated to figure out at first how to get things to work (especially if you're coming from JSPM/SystemJS), so it helps to have some brief docs explaining the initial setup (which thankfully isn't much).

P.S. When Github doesn't notify that the issue has been closed and you type up a response... Yah, that stinks. 😛

Thanks, @AStoker! I think your instructions are pretty much the same as @code-chris's earlier. I got it working with a super-simple knockout data-binding (just 'text', but that should be enough to prove it works).
So now where I'm flummoxed is that I have this whole, huge knockout app with modules managed by require.js. I'm not sure how much plumbing I'm going to have to retrofit or if there's some way to get the ES6 (or whatever) and the require.js parts to work nicely together. I'd like to start by just making a big '...' in app.html and stuff basically my whole index.html from the knockout app into it. In the Aurelia app's index.html I blindly shoved my aurelia data-main and my require.js data-main together. I'm sure this isn't the way to do it, but I'm not having any great ideas so far.

Any advice? Thanks so much again.

We have a similar situation @Sigfried, we have an application that was knockout based with Durandal. We are about to start moving it over to our Aurelia application, and have had some success with it. What we've done is use a tool called Amd-to-ES6 (https://github.com/jonbretman/amd-to-as6) to automagically make all our view models (in AMD Require syntax) into ES6 modules/classes. We did have to go through each view that we were using knockout in (which is many) and add the knockout attribute to the div, but that's just legwork and isn't too bad.
BTW, the code snippet you had is no bueno. The vendor-bundle.js contains requirejs in it, so you don't want to pull it in again. The aurelia-bootstrapper will go and get your main.js file by convention, so you shouldn't need that second script tag.

Look at this migration article. There are some topics you have to do: https://github.com/code-chris/aurelia-knockout/wiki

Thanks!
Another thing, in case it matters. We weren't using Durandal. But are the issues basically the same?

So, is your current architecture based on another single-page framework? Or did you just use knockout for data-binding?

Awesome job on the Wiki!

Yeah, awesome job on the wiki!
It is a single-page app written with knockout. You can see it here: https://github.com/OHDSI/Atlas

@AStoker, looks like I'm not going to be able to use amd-to-es6, at least not easily. The way our routing was written (https://github.com/OHDSI/Atlas/blob/master/js/app.js#L24) makes it choke on multiple module definitions.
@code-chris, I haven't quite figured out what needs to be done with amd modules based on the Wiki... I'm about to try following directions here https://github.com/code-chris/aurelia-knockout/wiki#requirejs-and-npm to see if I can keep the existing requirejs stuff for now...

Ok, I tried that, but I'm getting this error at aurelia-loader-default.js:54:
Uncaught TypeError: Cannot read property '__useDefault' of undefined
    ensureOriginOnExports @ aurelia-loader-default.js:54
    (anonymous function) @ aurelia-loader-default.js:162
    execCb @ require.js:29
    check @ require.js:18
    ....

Actually, I seem to be getting pretty close. I'm still getting that error, but the app seems to be working like the original knockout app.

Sorry to be annoying...
The point I'm getting stuck now is: https://github.com/code-chris/aurelia-knockout/wiki#app-startup. When I put es6 syntax in main.js, I get main.js:1 Uncaught SyntaxError: Unexpected token export.
Presumably the problem is just that I don't have transpiling in place. Following the wiki instructions (https://github.com/code-chris/aurelia-knockout/wiki#requirejs-and-npm) I installed the 'minimal required Aurelia modules' instead of doing au new, which means that au run won't work, so I'm using live-server as my web server, but that leaves out transpiling...

Spent last three hours trying to get my require config either ported to or cooperating with the webpack config from the Aurelia webpack skeleton. Giving up on that now.

If you use webpack with aurelia you don't need another module loader like requirejs. This is handled by the aurelia-loader-webpack implementation. Where are your problems with the configuration? I recommend not to use easy-webpack like in the skeletons, because you lost flexibility at some point...

Right. The reason I tried the webpack from the skeleton is that I was looking for the right way to get the es6 stuff working. It's going to be hard for me to get rid of requirejs (except gradually) because it's used so extensively in the base project.
As I mentioned before attempting to use the webpack skeleton, my app now seems fully functional though I'm calling it through  and require(["aurelia-bootstrapper"]), but main.js is just my original main.js from the knockout app (a require module). I'm not able follow the wiki's app startup instructions (https://github.com/code-chris/aurelia-knockout/wiki#app-startup):
export function configure(aurelia) => {
    aurelia.use
        .standardConfiguration()...

because I don't have a build process or included libraries (as far as I know) that will do the transpiling. Also, although the base knockout app is working ok, I'm still getting this error in the console: Cannot read property '__useDefault' of undefined.

You can transpile es6 code with the babel-loader from webpack. See the README from this package: https://github.com/babel/babel-loader
Webpack creates bundles where your app and (hopefully) all dependencies are included. There is one "entry" bundle-js-file which you can use as start point. Add this script file with a


Plugin does nothing if exclude_tags is not defined

Hi @chrieke,
In your most recent version 0.3.0 the absence of exclude_tags in the configuration file makes the plugin unuseable as it doesn't exclude anything. I think there is a mistake in the boolean expression at https://github.com/chrieke/mkdocs-exclude-search/blob/main/mkdocs_exclude_search/plugin.py#L49 as it should be an "and" expression.

I noticed the latest version of plugin does not work. Will roll back to 0.2.1

@seppi91 @krastg Thanks for reporting! Fixed in v.0.3.1, also see the new changelog. Finally added some first tests and cleaned up the messy code a bit.
Please let me know if you encounter any problems.


(security): update webpack & webpack-dev-server

Description
This addresses 11 CVEs associated with webpack-dev-server v3. There is still 1 associated CVE with webpack 4 that requires upgrade to webpack 5, but I'm leaving that out of scope for this change.

CVE
Vulnerable Library

CVE-2024-37890
ws-6.2.2

CVE-2024-43796
express-4.19.2

CVE-2024-45590
body-parser-1.20.2

CVE-2024-21536
http-proxy-middleware-0.19.1

CVE-2024-47764
cookie-0.6.0

CVE-2024-29415
ip-1.1.9

CVE-2024-29180
webpack-dev-middleware-3.7.2

CVE-2024-52798
path-to-regexp-0.1.7

CVE-2024-45296
path-to-regexp-0.1.7

CVE-2024-43800
serve-static-1.15.0

CVE-2024-43799
send-0.18.0

Issues Resolved
fixes #389
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[x] All tests pass

[x] yarn lint
[x] yarn test-unit

[x] Update CHANGELOG.md
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

How have we tested the impact of this change? Can we validate it doesn't have impact on generated artifacts?

I've done cursory testing with the integration tests and by running the dev server. I'm planning on also doing the following

update webpack-cli since I realize it's mismatched with webpack itself. One breaking change I know I'll have to address is the deprecation of the --output-library-target override we use to compile the charts to commonjs.
diff the dist folder with a build with and without this change.

@virajsanghvi Let me know if this doesn't properly address your comment.

I've updated with the webpack-cli update and I've added the verification process in the PR description.


Request sending in member page

update database
disable join button when the table is full/ request is sent/ request is confirmed
allow password input when the table is password-protected and check password

closed because #88 is merged to master successfully 💯


implement  unwrap non zero

Codecov Report

Merging #239 (d26adf0) into main (9ee8221) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   81.06%   80.90%   -0.17%
==========================================
  Files          91       92       +1
  Lines       10617    10638      +21
==========================================
  Hits         8607     8607
- Misses       2010     2031      +21

Impacted Files
Coverage Δ

src/libfuncs.rs
69.16% <0.00%> (-0.56%)
:arrow_down:

src/libfuncs/unwrap_non_zero.rs
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix: update link to docs

@thofma ,
Sorry to hijack this PR, but I'm glad you raised it. I completely forgot to update the links after the repo was migrated

I suspected there were more places, so I am happy with the friendly takeover.


Use cftime instead of netcdftime

This is pending a new cf_units release.

:+1: Nice one, thanks @ocefpaf ... I'll wait for travis-ci to do it's thing before merging.

I'll wait for travis-ci to do it's thing before merging.

I would wait for the next cf_units first. (Also, we are working on a stable release for cftime that should be out soon.)

Only two failures remain:
======================================================================
FAIL: test_period_of_interest (iris.tests.test_nimrod.TestLoad)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/scitools_iris-2.1.0.dev0-py3.6.egg/iris/tests/test_nimrod.py", line 107, in test_period_of_interest
    self.assertCML(cube, ("nimrod", "period_of_interest.cml"))
  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/scitools_iris-2.1.0.dev0-py3.6.egg/iris/tests/__init__.py", line 406, in assertCML
    self._check_same(xml, reference_path)
  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/scitools_iris-2.1.0.dev0-py3.6.egg/iris/tests/__init__.py", line 496, in _check_same
    type_comparison_name)
  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/scitools_iris-2.1.0.dev0-py3.6.egg/iris/tests/__init__.py", line 235, in _assert_str_same
    self.fail("%s do not match: %s\n%s" % (type_comparison_name, reference_filename, diff))
AssertionError: CML do not match: /home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/scitools_iris-2.1.0.dev0-py3.6.egg/iris/tests/results/nimrod/period_of_interest.cml
--- Reference
+++ Test result
@@ -6 +6 @@
-        <dimCoord bounds="[[379973.0, 379974.0]]" id="cb784457" points="[379974.0]" shape="(1,)" standard_name="time" units="Unit('hours since 1970-01-01 00:00:00', calendar='standard')" value_type="float64"/>
+        <dimCoord bounds="[[379973.0, 379974.0]]" id="cb784457" points="[379974.0]" shape="(1,)" standard_name="time" units="Unit('hours since 1970-01-01 00:00:00', calendar='gregorian')" value_type="float64"/>
======================================================================
FAIL: test_repr_pass_1 (iris.tests.test_unit.TestStringify)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/scitools_iris-2.1.0.dev0-py3.6.egg/iris/tests/test_unit.py", line 502, in test_repr_pass_1
    self.assertEqual(repr(u), "Unit('hours since 2007-01-15 12:06:00', calendar='standard')")
AssertionError: "Unit('hours since 2007-01-15 12:06:00', calendar='gregorian')" != "Unit('hours since 2007-01-15 12:06:00', calendar='standard')"
- Unit('hours since 2007-01-15 12:06:00', calendar='gregorian')
?                                                   ^^^^^^^
+ Unit('hours since 2007-01-15 12:06:00', calendar='standard')
?                                                   ^^  ++++

Should I updated those 'standard' calendars to 'gregorian'?

Could we add a what's new to give users a heads up about the change? I've done a similar thing in https://github.com/SciTools/iris/pull/3023/files#diff-4edce611793e498bf2483d76b404e733.

@ocefpaf - let's try to separate the cf_units from the cftime updates. #3023 relates for cf_units.

@ocefpaf - let's try to separate the cf_units from the cftime updates. #3023 relates for cf_units.

I'll work on this later today. (I'll be in meeting all morning :unamused:)

No worries. Would you mind rebasing when you're out of that meeting? 😄

@pelson everything should pass with the latest nc-time-axis.

Needs https://github.com/SciTools/nc-time-axis/pull/34

Should now be unblocked.

Should now be unblocked.

I hope I did not messed up the rebase :grimacing:

Bingo!
Awesome, thanks @ocefpaf :+1:


[Bug]fix the calculation of the "_start_trash_sweep" run interval.

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X] I have created an issue on (Fix #6166) and described the bug/feature there in detail
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

tranlate those comment into English

done.

you should create an ISSUE to describe this bug


TwitchAuth.getAppToken should accept scopes

Feature Request
According to the client credentials documentation, the endpoint accepts an optional set of scopes, just like in user access tokens.
I was trying to use TwitchAuth.getAppToken to supply a scope (such as channel:read:subscriptions) to this endpoint, but one is not accepted.
Is this something that could be updated?

IIRC this is a Twitch documentation error. What do you think would be achieved by this?
Scopes enable you to get the data of the associated user of a token.
App access token have no directly associated user.
So this couldn't possibly give you any value.

OK, so there must be other errors in Twitch's documentation as well because I was looking at the EventSub documentation which says:

You must include an app access token in all API requests. You do not need to include a user access token, even for subscriptions that require user authorization.

but also that the channel.subscribe event docs says you need a channel:read:subscription token. If this my misinterpretation, then my mistake. By the way, I am aware you are working on an EventSub package but just picked that as a private project to do to test my skills. 😄

Scopes are handled differently in EventSub. They are checked globally, that means the scope is available if there was ever a user authorization to your application with the mentioned scope (that wasn't revoked).
From the EventSub docs, right after the part you quoted:

This is because Twitch checks authorization throughout the lifetime of your subscription by calling Twitch’s internal authorization systems directly.

By the way, I am aware you are working on an EventSub package but just picked that as a private project to do to test my skills. 😄

You're welcome to contribute code or improvement possibilities to the structure and interface of the code! To discuss the latter, Discord is the place to go.


"CLOSED" font is not Avante Garde

Looked like helvetica to me on the most recent deploy.

still true on the clock

Probably because those labels have fonts defined in IB and not code, and the font files are no longer in the main app's bundle. Fix should be easy.

There are a few more of these than we first thought – I'm going to go through the storyboards and do an audit.


Findbugs cleanup; no functional changes

Note: this doesn't fix all FindBugs warnings; not even close.
I was doing some other unrelated cleanup and I thought that our codebase was Findbugs-clean, so I fixed the ones I saw. Then I ran ./gradlew findbugsTest findbugsMain and realized how many violations there were. So here's just a nudge in the right direction.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand:

[ ] What the pull request does
[ ] Why it does it
[ ] How it does it
[ ] Why this approach

[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Java PreCommit

Run Java PreCommit

Rebased and squashed.


net instrumentation can cause "stack level too deep" with 3rd party gems

please consider replacing monkey-patching Net::HTTP using class reopening and "alias_method_chain" by prepend
more details in the issue I submitted to airbrake

@MathieuDerelle Thank you for this report and linking to airbrake issue as well.  This is a great example highlighting the need to move away from method chaining to a prepend approach to instrumenting.  I am placing this issue in our "review bucket" as a reminder to prioritize refactoring all instrumentation hooks that are not already using the prepend approach.

also affected by this issue. sadly, the suggested workaround of moving the newrelic_rpm line in the Gemfile ahead of airbrake doesn't seem to fix it here.

@gsar the order in the Gemfile does NOT matter
it is the order of the requires that matters
take a look at your config/application.rb and look for a Bundler.require(*Rails.groups) or require 'airbrake' and put a Bundler.require(:newrelic) before it

@MathieuDerelle thanks for the tip. i tried your suggestion but it doesn't seem to make a difference, i still see the stack level too deep error with the stack showing airbrake and newrelic httpclient interceptors.
the issue occurs within a rake task but the main app itself appears to be fine. My Rakefile contains just this:
require File.expand_path('config/application', __dir__)

Rails.application.load_tasks
Rails.application.config.autoflush_log = true
Doorkeeper::Rake.load_tasks

This issue is included in the bug smash that we are working on.


⚠ Bofrost.be has degraded performance

In 2305ed9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1269 ms

Resolved: Bofrost.be performance has improved in cf8bd4e after 6 minutes.