Remove usages of localhost in client code

What version of Kubernetes (kubectl  version) are you using?
1.6
What version of etcd (etcdctl --version) are you using?
v3
What version of ReShifter are you using (for rcli: rcli version otherwise at the bottom of the app)?
0.3.19
According to the documentation:

Note: the above YAML file defines both a Deployment as well as a Service object for ReShifter. It does, however, not expose the ReShifter service to the outside world. If you want to access the app from outside the cluster, you'll have to use Ingress or adapt the YAML file yourself.

I was able to install the UI on my cluster. I could access it both using kubectl proxy as well as by adding an ingress resource. In each case though, I couldn't actually run a backup as it seems the client-side code in ui/coreui/js/app.js is explicitly set to use localhost:8080.
I was able to get around this by using http-proxy. Does app.js need to have these explicit usages of localhost:8080 for the url? Could it be changed to always use the host of whatever url the page was served from as the host for subsequent requests in app.js?

Thanks @debben for reporting this and for using ReShifter! Hmmm, does it have to be localhost:8080? Well the reason really was that the Web UI is packaged along with the HTTP API in the container image, so guaranteed to be accessible from localhost. Maybe I'm missing something and looking at #3 (which I believe is related if not the same issue) I think we should change this, yes. I'm super open to it, so let me know if you plan to send in a PR or I should take care of it, please?

@debben can you let me know please how you want to proceed?

Sorry for the delay. I'll submit a PR soon.

Thank you @debben!

Could you please update the image file in the below link from version 3.19 to 3.21 ?
https://raw.githubusercontent.com/mhausenblas/reshifter/master/deployments/reshifter-app.yaml

@kvmprashanth done. Thanks for spotting this!


EID-419: Add trust anchor healthcheck

We need to ensure that the MSA is able to resolve the trust anchor and
in turn that each of the MetadataResolvers it provides is validating
the metadata they read.
The EidasTrustAnchorHealthCheck from saml-metadata-bindings should
fulfil both of these requirements.
Author: @vixus0

Will we need a test???

I don't think we really need a test as it's just something that'll be available on the admin endpoint for informational purposes.  Also, the same info that you'd see in the healthcheck should be available in the MSA logs.

This could be used by an MSA in Docker via HEALTHCHECK


Doesn't work with node v0.10.40

Hi. Sorry i'm not sure if it is related to the node version (or what else might be wrong), but I tried the demo code on the ReadMe and got the following "Pie" chart. Not quite what I expected.

Canvas is<EMAIL_ADDRESS>and I installed Cairo (on Ubuntu) as suggested in the node-canvas readme.

Fortunately, I was able to get a line chart to work, from the docs at http://www.chartjs.org/docs/.


Precompiler(Proposal)

I created this project. https://github.com/mizchi/react-jade-precompiler
It's just dump of this.
tmpl = jade.compileFile(fpath)
tmplStr = argv.header + tmpl.toString()

I know, it loses all local context and may fail trivial case but It's no problem in my use case.
If it can, I think this feature should be provided by react-jade project.  How about this?

We have an API intended for doing just this called jade.compileFileClient.  We could consider adding a simple CLI, but it should probably be a separate project (perhaps still under the jade organisation though).


Dialogues not centering with the "AboveCharacterText" node

Bug description
When using the above character dialog style, these lines of code change nothing:

This is because for some reason you can't use push_color AND the [center] and [right] tags, and removing the push_color call that goes before fixes the issue.
Steps to reproduce
Steps to reproduce the behavior:

Make a character talk

Expected vs observed behavior
Expected:

Observed:

You can see that only in the second one the color shows up.
Environment information (please complete):

OS type and version:  Pop!_OS 22.04 LTS
Godot version: Godot v4.3.stable
Plugin version or branch: v2.0.0-beta3

Pretty easy fix tbf

Hi @BenjaTK, thank for reporting the fix.
I'm not sure about this, but my guess is that's more of a Godot bug than a Popochiu one.
Can you share the offending script in your screenshot so I can check if there is something we can do to make it work?
Did you try to push_color and push_center on the text, instead of using push_color on a text that already contains bbcode? I see no reason why this would result in errors but it's worth trying.
Thanks

@mapedorr I would close this for inactivity. What do you think?


Android Error Handling

The app can currently end up on the enable covid alert button screen when the users device isn't supported or other error codes are thrown.  We need to add more granular error handling to inform the user appropriately.
i.e.
We can see in the logs this device isn't supported
10-07 13:34:17.192 11076 11119 I ExposureNotification: isDeviceSupported=false, isBluetoothSupported=true, BluetoothAdapter.isMultipleAdvertisementSupported=true [CONTEXT service_id=236 ]
Handle additional error code cases
The app should handle:
FAILED_NOT_SUPPORTED
FAILED_SERVICE_DISABLED
https://developers.google.com/android/exposure-notifications/exposure-notifications-api#error-handling
private void handleStatus(int errorCode) {
  switch (errorCode) {
    case ExposureNotificationStatusCodes.FAILED_RATE_LIMITED:
      // The client has been rate-limited for access to this API.
      break;
    case ExposureNotificationStatusCodes.FAILED_UNAUTHORIZED:
      // The client is unauthorized to access the APIs.
      break;
    case ExposureNotificationStatusCodes.FAILED_SERVICE_DISABLED:
      // The functionality was disabled by the user or the phone.
      break;
    case ExposureNotificationStatusCodes.FAILED_NOT_SUPPORTED:
      // The hardware capability of the device is not supported.
      break;
    case ExposureNotificationStatusCodes.FAILED_BLUETOOTH_DISABLED:
      // Bluetooth is disabled.
      break;
    default:
      // more status codes in ExposureNotificationStatusCodes class.
      break;
  }
}

@jeberhardt
I did a quick test running the app under the "personal" profile + the "work" profile
"personal" profile
isDeviceSupported=true
2020-10-21 12:17:21.053 3812-4379/? I/ExposureNotification: isDeviceSupported=true, isBluetoothSupported=true, BluetoothAdapter.isMultipleAdvertisementSupported=true [CONTEXT service_id=236 ]
"work" profile
isDeviceSupported=false
2020-10-21 12:08:48.822 4000-4117/? I/ExposureNotification: isDeviceSupported=false, isBluetoothSupported=true, BluetoothAdapter.isMultipleAdvertisementSupported=true [CONTEXT service_id=236 ]
=========
So adding the Device supported check should take care of issues with Huawei devices + WorkPlace profile issues i.e. don't show the enable You did not enable screen with the "Enable Covid Alert" button.

@jeberhardt is testing looks like for Work Profiles we'll get back API_NOT_CONNECTED
- The API previously failed to connect with a resolvable error, but the user declined the resolution.
- The device does not support GmsCore.
- The specific API cannot connect on this device.

https://developers.google.com/android/reference/com/google/android/gms/common/api/CommonStatusCodes#API_NOT_CONNECTED
@katewilhelm looks like we'll end up with 2 cases

Device not supported
API won't connect.

Noting
SwissCovid -  PR
https://github.com/DP-3T/dp3t-app-android-ch/pull/155/files


fix(snap): Copy UoM file if not exist during upgrade

This PR fixes the missing Unit of Measure config file during an upgrade.
When we upgrade from a channel that has a larger revision number than 3900, the current post-refresh assumed we are upgrading from a new version that already has the UOM file, so that it doesn't add UoM file during an upgrade, that leads to the missing UoM file error.
Signed-off-by: Mengyi Wang<EMAIL_ADDRESS>

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[x] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

$ SERVICE_CHANNEL=latest/edge/pr-4168 go test -p 1 ./test/suites/edgexfoundry -v --run=TestCommon/refresh
2022/09/27 11:33:02 [CLEAN]
2022/09/27 11:33:02 [exec] sudo snap remove --purge edgexfoundry
2022/09/27 11:33:02 [stderr] snap "edgexfoundry" is not installed
2022/09/27 11:33:02 [SETUP]
2022/09/27 11:33:02 [exec] sudo snap install edgexfoundry --channel=latest/edge
2022/09/27 11:34:42 [stdout] edgexfoundry (edge) 2.3.0-dev.72 from Canonical** installed
2022/09/27 11:34:42 Retry 1/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command), 8200 (vault), 8500 (consul), 8000 (kong), 5432 (kong-database), 6379 (redis)
2022/09/27 11:34:43 Retry 2/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command)
2022/09/27 11:34:44 Retry 3/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command)
2022/09/27 11:34:45 Retry 4/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command)
2022/09/27 11:34:45 [exec] sudo snap start edgexfoundry.support-scheduler
2022/09/27 11:34:46 [stdout] Started.
2022/09/27 11:34:46 Retry 1/60: Waiting for ports: 59861 (support-scheduler)
2022/09/27 11:34:47 Retry 2/60: Waiting for ports: 59861 (support-scheduler)
=== RUN   TestCommon
=== RUN   TestCommon/refresh
    exec.go:19: [exec] sudo snap remove --purge edgexfoundry
    exec.go:93: [stdout] 2022-09-27T11:34:48+02:00 INFO Waiting for "snap.edgexfoundry.core-data.service" to stop.
    exec.go:93: [stdout] 2022-09-27T11:34:52+02:00 INFO Waiting for "snap.edgexfoundry.support-scheduler.service" to stop.
    exec.go:93: [stdout] 2022-09-27T11:34:54+02:00 INFO Waiting for "snap.edgexfoundry.core-metadata.service" to stop.
    exec.go:93: [stdout] edgexfoundry removed
    exec.go:19: [exec] sudo snap install edgexfoundry --channel=latest/stable
    exec.go:93: [stdout] edgexfoundry 2.2.0+2 from Canonical** installed
    exec.go:19: [exec] snap info edgexfoundry | grep installed | awk '{print $2}'
    exec.go:93: [stdout] 2.2.0+2
    exec.go:19: [exec] snap list edgexfoundry | awk 'NR==2 {print $3}'
    exec.go:93: [stdout] 3968
=== RUN   TestCommon/refresh/check_services
    exec.go:19: [exec] sudo snap refresh edgexfoundry --channel=latest/edge/pr-4168 --amend
    exec.go:93: [stdout] 2022-09-27T11:36:30+02:00 INFO Waiting for "snap.edgexfoundry.core-metadata.service" to stop.
    exec.go:93: [stdout] edgexfoundry (edge/pr-4168) 2.0.1-dev.71 from Canonical** refreshed
    exec.go:19: [exec] snap info edgexfoundry | grep installed | awk '{print $2}'
    exec.go:93: [stdout] 2.0.1-dev.71
    exec.go:19: [exec] snap list edgexfoundry | awk 'NR==2 {print $3}'
    exec.go:93: [stdout] 4013
    net.go:140: Retry 1/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command), 8200 (vault), 8500 (consul), 8000 (kong), 5432 (kong-database), 6379 (redis)
    net.go:140: Retry 2/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command)
    refresh.go:45: Successfully upgraded from 2.2.0+2 (3968) to 2.0.1-dev.71 (4013)
=== RUN   TestCommon/refresh/check_config_paths
    refresh.go:54: Looking for files containing previous snap revision 3968
    exec.go:19: [exec] sudo grep -RnI 'edgexfoundry/3968' /var/snap/edgexfoundry/current || true
=== CONT  TestCommon/refresh
    exec.go:19: [exec] sudo snap remove --purge edgexfoundry
    exec.go:93: [stdout] 2022-09-27T11:36:57+02:00 INFO Waiting for "snap.edgexfoundry.core-data.service" to stop.
    exec.go:93: [stdout] 2022-09-27T11:37:04+02:00 INFO Waiting for "snap.edgexfoundry.core-metadata.service" to stop.
    exec.go:93: [stdout] edgexfoundry removed
    exec.go:19: [exec] sudo snap install edgexfoundry --channel=latest/edge/pr-4168
    exec.go:93: [stdout] edgexfoundry (edge/pr-4168) 2.0.1-dev.71 from Canonical** installed
    net.go:140: Retry 1/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command), 8200 (vault), 8500 (consul), 8000 (kong), 5432 (kong-database), 6379 (redis)
    net.go:140: Retry 2/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command)
    net.go:140: Retry 3/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command)
    net.go:140: Retry 4/180: Waiting for ports: 59880 (core-data), 59881 (core-metadata), 59882 (core-command)
--- PASS: TestCommon (198.86s)
    --- PASS: TestCommon/refresh (198.86s)
        --- PASS: TestCommon/refresh/check_services (32.27s)
        --- PASS: TestCommon/refresh/check_config_paths (0.02s)
PASS
2022/09/27 11:38:06 [TEARDOWN]
2022/09/27 11:38:06 [exec] (sudo journalctl --since "2022-09-27 11:33:02" --no-pager | grep "edgexfoundry"|| true) > edgexfoundry.log
Wrote snap logs to /home/mengyi/Desktop/edgex531/edgex-snap-testing/test/suites/edgexfoundry/edgexfoundry.log
2022/09/27 11:38:06 [exec] sudo snap remove --purge edgexfoundry
2022/09/27 11:38:08 [stdout] 2022-09-27T11:38:08+02:00 INFO Waiting for "snap.edgexfoundry.core-metadata.service" to stop.
2022/09/27 11:38:20 [stdout] edgexfoundry removed
ok      edgex-snap-testing/test/suites/edgexfoundry     318.805s

@farshidtz Could you please review it?


expose fonts and spacing in initialiser

Personally, I think it's good to have the choice to edit the font and the hstack spacing, if I wanted to, so, in this pull request, I am exposing the UIFont for both title and subtitle, along with the spacing between image and text.

All good !  Thank you for your PR 😊


Adds startSpan tests to tracer.

This PR improves the coverage.
Ping @eligijusvitkauskas-home24

Imagine the case when doing something like so on receiving end:
$span = $tracer->getActiveSpan();
if ($span !== null) {
    $tracer->inject($span->getContext(), Formats\TEXT_MAP, $headers);
}

When you get NoopSpan from getActiveSpan() inject() will lead to the exception due current inject() implementation. But because you have reworked NoopSpan I think you can also accept it on inject() method. Or am I wrong?

Yeah, this refactored in the noop span makes sure the inject won't fail. I should have done this tests before but did not have much time.

@eligijusvitkauskas-home24 remember that even if it is a noop span you can still inject the context into a carrier.


I am getting ApiVersionUnspecified in response

Chris -  can you help. Not sure why its not working. I have uploaded the startup and the api controller file. I am trying to hit the api --> http://localhost:16460/api/v1/tfmemployee but i get an error
{
"error": {
"code": "ApiVersionUnspecified",
"message": "An API version is required, but was not specified."
}
}
Startup.txt
TfmemployeeController.txt

I got that resolved by change [RoutePrefix()] to [Route()]. But now when i create an V2 version , i can only invoke V1, v2 gives me the following message. See attached file. What am i missing ?
TfmEmployeeControllerV2.txt
{
"error": {
"code": "UnsupportedApiVersion",
"message": "The HTTP resource that matches the request URI 'http://localhost:16460/api/v2/tfmemployee' does not support the API version '2'.",
"innerError": {
"message": "No route providing a controller name with API version '2' was found to match request URI 'http://localhost:16460/api/v2/tfmemployee'."
}
}
}

Ok ... I almost thought you hit a bug because I was running into the same problem trying to create a repo. It turns out that we hit one of the wonderful issues with the routing infrastructure in Web API.  Web API uses the convention [Name]Controller to match route segments to controller types. The entire issue was with how you named the controller class.  >_< Silly I know.
This will work:
[ApiVersion( "1.0" )]
[RoutePrefix( "api/v{version:apiVersion}/tfmemployee" )]
public class TfmEmployeeController : ApiController
{
    [Route]
    public IHttpActionResult Get() => Ok( "Success" );
}
[ApiVersion( "2.0" )]
[RoutePrefix( "api/v{version:apiVersion}/tfmemployee" )]
public class TfmEmployee2Controller : ApiController
{
    [Route]
    public IHttpActionResult Get() => Ok( "Success from V2" );
}

Notice how the "V2" is moved before the "Controller" suffix.  Just to illustrate that this is not related to API versioning, you can disable or comment it out in Startup.cs.  Then define your controllers this way:
[RoutePrefix( "api/v1/tfmemployee" )]
public class TfmEmployeeController : ApiController
{
    [Route]
    public IHttpActionResult Get() => Ok( "Success" );
}
[RoutePrefix( "api/v2/tfmemployee" )]
public class TfmEmployeeControllerV2 : ApiController
{
    [Route]
    public IHttpActionResult Get() => Ok( "Success from V2" );
}

Now we have two different controllers with completely different routes and API versioning is not involved or enabled.  You'll see that a request to ~/api/v2/tfmemployee will return 404. If you move the "V2" before "Controller", then it will start working. I'm sorry you hit this landmine. I wish there was something I could do about it. The only highlight is that routing was completely rewritten in ASP.NET Core to remove wonkiness like this!
Let me know if you continue to be stuck.

Thank you ! That helped and its working fine. One last thing, can you eyeball this startup file to see if i have the versioning setup correctly. I would like every api under this project to have a version in the request URL.

Based on what I saw, it looks correct. Once you enable API versioning by calling AddApiVersioning all services will now have versioning enforced (error on the safe side). This is true even if a controller does not declare a version via the [ApiVersion] attribute (this is so that services can be easily grandfathered in without changing). The API version used in these cases is the value defined in the ApiVersioningOptions.DefaultApiVersion. It's default value is version 1.0.
I recommend always explicitly defining your API versions so that it's obvious in the code, but if you want to experiment with the behavior all you have to do is comment out [ApiVersion("1.0")] on your first controller implementation. You'll see that it still works when you can for ~/api/v1/*.  The value comes from that default setting.
Any controller (e.g. service) that does not want this behavior must either explicitly declare their API versions or opt-out of API versioning all together using [ApiVersionNeutral]. API version-neutral controllers will accept any API version.
I hope that helps.

Super ! thanks will share my feedback on how it goes. Thank you !

It appears you got what you needed on this topic. Feel free to re-open this issue or start a new discussion as needed.

Hi
I had to remove Microsoft.AspNetCore.Mvc.Versioning" Version="1.2.1" from Core API project and rollback to version 1.0.3  after I was unable to work with inconsistency.
I was simply trying to standard redirect extension methods in as shown below which is not firing with version 1.2.0 on wards.
app.UseStatusCodePagesWithReExecute("/error/{0}");
app.UseExceptionHandler("/error/500");
The suggestion in this article worked but with inconsistency so not using it.
I am definitely downgrading to 1.0.3 for now.
regards
Si Zi

Things are likely more consistent than you think. Prior to 1.1, there was and still is a different issue where a route might not be discovered. This is because the IActionSelector can be visited multiple times by the ASP.NET infrastructure. The only way to guarantee that the correct decision is made is by visiting all possible candidates. In order to make that happen, the IActionSelector has to continue to report success, even when it doesn't know whether the final result will be successful or not. The final decision is made by the IApiVersionRoutePolicy. Of course, if every possibility had to be enumerated each time, that would be highly inefficient. After a route has traversed all possibilities at least once, the policy can be enforced much earlier in the pipeline.
Unfortunately, this behavior doesn't always play nice with other middleware. The initial API versioning policy will be enforced at the end of the pipeline, which will not trigger other middleware that might have performed a redirect, etc from a failed request (e.g. 400, 404, or 405). A second pass will likely yield the correct behavior because the decision can be made before the end of the pipeline.
This was a similar issue in #146, but was resolved. I make every reasonable effort to have API versioning play nice with other middleware and behaviors. If you can explain exactly what you're hoping to achieve, I can try to help. If you have the world's simplest repro, that would go a long way and accelerate my investigation.


Roll Flutter Engine from 28e8fe2765e5 to 51d14176b6da (1 revision)

https://github.com/flutter/engine/compare/28e8fe2765e5...51d14176b6da
2022-08-30<EMAIL_ADDRESS>Roll Dart SDK from f2f392026c6b to 1ea86a3ccb57 (1 revision) (flutter/engine#35795)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Unused files in docs directory

The following files in the docs directory should be removed: pitch.txt, poster.pptx, and vision.txt. The files aren't used to build the documentation and aren't part of the documentation itself. They appear to be notes or templates that were committed to the repository by accident.

This was resolved in a recent pull request.


Simple system message system to master

This PR adds a simple way to display system messages (like scheduled downtime) for a set period of time.
I've targetted master as develop contains some code that isn't ready yet, and I prefer to have this online today if possible, for the downtime next weekend

Yes it does!
It's part of the modeltranslation library, which dynamically adds extra fields to the model and the admin to provide localized values.


added db dump for v7

Please check carefully, I'm relatively inexperienced with this.

Processing this pull request

Merged into branches iso3 in<PHONE_NUMBER>f25829a21033260021d2cb496e82b5


Use Github Actions for CI and Deploy to PyPi on Release.

Switch to python 3.9
Use Github Action to run test suite on pull request
Publish to PyPi on release
Use Github release tag as version number in setup.py
Expects secrets PYPI_REPOSITORY, PYPI_USERNAME, PYPI_TOKEN

Resolves #38

The codacy-coverage-reporter Github Action is failing due to the fact that Github Secrets are not available within pull requests from forks.
This link describes the issue and provides a possible workaround. Github Actions itself provides no way to share secrets across forks.

I initially setup the PyPi Publish action to use a Github secret for both the username and the password (PYPI_USERNAME, PYPI_TOKEN).
Looking further into it you can use "token" as the username and the PyPi security token as the password instead.
Not sure if we should hard code __token__ within deploy_to_pypi.yml or just set the PYPI_USERNAME secret to "token"


Support data transformer in CLI commands

add new arg type

Suggestion: --inputs="arg1=123 arg2=321"

In the past, I remember we were talking about following syntaxes: -- --arg1 123 --arg2 321 or +arg1 123 +arg2 123


start/stop.sh

It may be easier for most people who don't know about bash scripting to include #!/bin/bash on the first line.

Demo site is now up.
Thank you, will add shebang to those files

Also I guess it should be
#!/bin/sh
?

Fixed by 6cd69077a3603ec2109757a5952cc4a9a1d0c62c


Add HTML5 PLEASE to web site

Look up HTML5, CSS3, etc features, know if they are ready for use, and if so find out how you should use them – with polyfills, fallbacks or as they are.

Excellent resource! Thanks


STP-3076: Dell management network topics

Summary and Scope
No major content changes. These edits are aligned with what was done for the top-level topics and Aruba topics. Here is a general list of changes:

Organization of content
Several procedures are currently formatted as topics without steps
Grammar and formatting
Unclear steps/instructions

Issues and Related PRs

Resolves STP-3076
Change will also be needed in release/1.2

Testing
N/A
Tested on:
N/A
Test description:
N/A
Risks and Mitigations
None.

This needs to be rebased. Also, note that it is now targeted for the main branch. This is appropriate -- just be sure to backport or cherry-pick it into all appropriate release branches.

/backport release/1.2

/backport release/1.2

The backport for this ticket was merged prematurely. Opening up a new PR for release/1.2.

/backport release/1.2

/backport release/1.2


[SPARK-24737][SQL] Type coercion between StructTypes.

What changes were proposed in this pull request?
We can support type coercion between StructTypes where all the internal types are compatible.
How was this patch tested?
Added tests.

cc @gatorsmile @cloud-fan

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/668/
Test PASSed.

Test build #92604 has started for PR 21713 at commit 5b9b901.

Test build #92604 has finished for PR 21713 at commit 5b9b901.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92604/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Test build #92606 has finished for PR 21713 at commit 5b9b901.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92606/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/696/
Test PASSed.

Test build #92636 has started for PR 21713 at commit bed6849.

LGTM

Test build #92636 has finished for PR 21713 at commit bed6849.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92636/
Test FAILed.

Jenkins, retest this please.

Test build #92638 has started for PR 21713 at commit bed6849.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/698/
Test PASSed.

LGTM

Test build #92638 has finished for PR 21713 at commit bed6849.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92638/
Test PASSed.

Test build #92643 has started for PR 21713 at commit d1e5a78.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/704/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/707/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92648 has started for PR 21713 at commit 1397e53.

Test build #92643 has finished for PR 21713 at commit d1e5a78.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92643/
Test FAILed.

Test build #92648 has finished for PR 21713 at commit 1397e53.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92648/
Test PASSed.

Merged to master


Add ability to append given path to the uri #5

Hey,
Based on the reply in #5 propsal I've added the ability to append the path to existing uri path.
There can be a mistake in my english (not a native speaker).
What I have noticed

Linting: I can recommend this tool https://github.com/symplify/easy-coding-standard plus https://getrector.org (i use this style at this moment (ecs config + rector config)
Also I was missing composer test script. It is handy to add them to composer.json (with lint and etc)
Current version of phpunit does not run on PHP 8.1.

I can make the changes if you want.
Have a great day and thanks!

Hi @JustSteveKing any chance of merging?


Problems downloading *.CSV

Hey Guys,
first of all thanks for your work ! Unfortunately I got a problem using imapX.dll with Powershell while downloading attachements.
When using "file.save (Downloadpath);" an attached csv is discovered with charset "US-ASCII" instead of its "UTF8" - no problem when using same csv as a txt for testing, but normal email contains csv. Is there a hint?
br
Sascha

Have you tried DownladRawMessage() method?


added edit mode to add user form and added the form to the accordion in edit mode

Short Description
added edit mode to add user form and added the form to the accordion (in edit mode).
Rationale/purpose of the feature
Enable's the use of the same form for both adding and editing a student
Link to relevant User Story
Create form to edit users.
Optional: Screenshot(s) of intended state of feature, wire-frame(s), flowchart
https://imgur.com/a/rBYRDAc
Checklist for author and reviewers

[ ] Commits are well named and descriptive
[ ] PR is focused on a single problem, is small enough and easy to review
[ ] PR requests were sent to multiple reviewers
[ ] PR is reviewed by more than one team member
[ ] Code is consistently formatted
[ ] Code is suitably commented on
[ ] There is no duplicate code
[ ] Code tries to follow best practices
[ ] Decide with reviewers if this PR should have tests before merging

Good use of ternaries.
'layoutStyles' is good--more readable.
Ready to merge.

Thank you! We are making some good progress now. :)


auto_wrap_policy for PEFT with FSDP

What does this PR do?
While doing finetuning with a PEFT model and FSDP I noticed excessive memory usage caused by the parameter use_orig_params which leads to additional memory usage for frozen parameters. When trying to disable use_orig_params the following error was thrown by FSDP

ValueError: Must flatten tensors with uniform requires_grad when use_orig_params=False

The reason for this is documented in the torch library.

FSDP has some constraints on freezing parameters (i.e. setting param.requires_grad=False). For use_orig_params=False, each FSDP instance must manage parameters that are all frozen or all non-frozen. For use_orig_params=True, FSDP supports mixing frozen and non-frozen, but we recommend not doing so since then the gradient memory usage will be higher than expected (namely, equivalent to not freezing those parameters). This means that ideally, frozen parameters should be isolated into their own nn.Module s and wrapped separately with FSDP.

I implemented a check in the auto_wrap_policy function of the FullyShardedDataParallelPlugin and wrapped the unfrozen parameters individually if necessary.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[x] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[x] Did you write any new necessary tests?
I wrote an additional test called test_auto_wrap_policy_peftwhich tests if FSDP fails when using PEFT and use_orig_params=False.

Who can review?
@pacman100
@muellerzr

I also added a test called test_auto_wrap_policy_peftin the fsdp tests

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Thanks a lot for improving the interop of accelerate with PEFT in an FSDP setting. I have a few small comments, please check.
Regarding the change in general, I have a question. I don't have experience with FSDP, so maybe it's obvious, but what is the special thing about PEFT that requires this extra policy? Is it just that PEFT results in a mixture of params with and without requires_grad or is there something else that's special for PEFT?

Yes the reason is a mixture of params with and without grad. And PEFT does not make sense with use_orig_params=True configuration. That's why this is necessary.

@BenjaminBossan Implemented your suggestions.

Yes the reason is a mixture of params with and without grad. And PEFT does not make sense with use_orig_params=True configuration. That's why this is necessary.

Thanks for explaining. I wonder if this could be detached from PEFT, WDYT? This would also allow to avoid the PeftModel import, which needs to be guarded otherwise, as PEFT is not a strict dependency of accelerate.

Yes the reason is a mixture of params with and without grad. And PEFT does not make sense with use_orig_params=True configuration. That's why this is necessary.

Thanks for explaining. I wonder if this could be detached from PEFT, WDYT? This would also allow to avoid the PeftModel import, which needs to be guarded otherwise, as PEFT is not a strict dependency of accelerate.

What we could do is check if there exist parameters with requires_grad=False in the model and if so run the wrapping. I don't know if there exist cases where you do not want the extra wrapping (using use_orig_params=True). @pacman100 what do you think?


Cannot decode Java 8 instant

Hello,
Thanks for this great project. I am having trouble decoding a JsObject that contains a Java 8 Instant. I'm using jwt-play-json, and following the example here
http://pauldijou.fr/jwt-scala/samples/jwt-play-json/
Here is code that reproduces the error:
scala> val claim = Json.obj(
     |         "userID" -> userDetails.userID.toString,
     |         "iat" -> time)
claim: play.api.libs.json.JsObject = {"userID":"00000000-0000-0000-0000-000000000201","iat":"2016-12-30T18:14:15Z"}

scala> val token = JwtJson.encode(claim, key, algo); JwtJson.decodeJson(token, key, Seq(JwtAlgorithm.HS256))
token: String = eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VySUQiOiIwMDAwMDAwMC0wMDAwLTAwMDAtMDAwMC0wMDAwMDAwMDAyMDEiLCJpYXQiOiIyMDE2LTEyLTMwVDE4OjE0OjE1WiJ9.0fiF9XcabbmE_jgu48fOIqn5v2sjvfyZdyUog2N1uZ8
res18: scala.util.Try[play.api.libs.json.JsObject] = Failure(java.util.NoSuchElementException: JsError.get)

time is a Java 8 instant:
scala> time
res20: java.time.Instant = 2016-12-30T18:14:15Z

Am I doing something wrong here?
Thanks,

I found the problem - it is the key "iat". I should choose a different key name.

Yeah, the iat property is defined by JWT spec as a number representing the timestamp in seconds. Either use it that way or pick another name.


Wallet Balance is missing

The chrome extension fails to get the balance through the API according the following error:
Failed to load resource: net::ERR_CONNECTION_REFUSED classicetherwallet.com:8081/api
For this reason the wallet is unable to show the balance (only showing ETC with no amount). Could anyone look into this please?

if still an issue, open again


Avoid using cri-api v1alpha2

As of v1.26.0 kubernetes removed support for api cri-api v1alpha2
See

https://github.com/kubernetes/kubernetes/pull/110618

This brings to errors like:
E0131 00:13:56.492610       1 pod.go:348] failed to get pod(openshift-monitoring/prometheus-adapter-7b6bb56874-k52ht) network namespace: cannot get containerStatus: rpc error: code = Unimplemented desc = unknown service runtime.v1alpha2.RuntimeService

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 53.319%

Files with Coverage Reduction
New Missed Lines
%

pkg/server/server.go
2
6.19%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1004

Relevant Lines:
1883

💛  - Coveralls

@zeeke thank you for the PR, good catch! LGTM, merged.


Mangled name from @FromFile displayed in docs

I am posting this here since I am encountering the same issue myself. Here are the issues in FromFile.jl and Documenter.jl
https://github.com/Roger-luo/FromFile.jl/issues/41
https://github.com/JuliaDocs/Documenter.jl/issues/1781

e.g. https://astroautomata.com/SymbolicRegression.jl/stable/types/

Thanks for posting this issue! I will follow the Documenter.jl thread.

This is fixed now. I ported the package to a manual module {Name} ... end system which is functionally equivalent to FromFile, but without the macro. So the docs are no longer mangled now.


add examples package-locks

:tada: This PR is included in version 0.2.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


4.7.x-build-82674322-job-82674323

This is the commit that the tag 0.0.20-beta is being used in the hpcs cli plugin build for 4.x support


Add check for invalid date range on storage load

Codecov Report

Merging #335 (48b63f5) into master (3e63bdf) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
- Coverage     68.44%   68.40%   -0.04%
  Complexity     1119     1119
============================================
  Files           136      136
  Lines          3834     3836       +2
  Branches        521      522       +1
============================================
  Hits           2624     2624
- Misses          982      983       +1
- Partials        228      229       +1

Impacted Files
Coverage Δ

.../java/seedu/address/storage/JsonAdaptedLesson.java
82.75% <0.00%> (-1.95%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e63bdf...48b63f5. Read the comment docs.


Gauge.writeMessage texts are not displayed in HTML Report after Gauge update.

Expected behavior
Messages should be printed for corresponding scenarios in html-report while using Gauge.writeMessage API.
Actual behavior
After components update only scenario heading is displayed, detailed message of execution are not displayed.
Existing Components:

Gauge: v0.9.5
Gauge-Java: v0.6.4
Gauge-Html-Report: v0.4.3

Updated Components:

Gauge: v0.9.7
Gauge-Java: v0.6.6
Gauge-Html-Report: v0.4.3

Steps to reproduce

Run any spec with older Gauge components as mentioned above.
Collect the reports.
Update the respective components.
Now run any spec and view report the detailed messages are not displayed.
Reverting back to older components does not resolve this behavior.

Refer screenshot of reports.
Expected Report:

Actual Report:

valid issue, able to replicate. investingating.

@nataraj93 Can you please provide some more information?
Where exactly are you adding the messages? (for eg. In @Step or @BeforeSuite methods). A code snippet or a sample project to replicate the issue would be helpful.

@nehashri Sure,
A scenario which has Gauge.writeMessage() in @Step would recreate this behaviour. For e.g.
@Step("Print Version Details ")
public void printVersionDetails(){
    Gauge.writeMessage("Env1 Version: " + getEnv1Version());
    Gauge.writeMessage("Env2 Version: " + getEnv2Version());
}
When this step is executed versions of Env1, Env2 should be printed under details of “Print Version Details” scenario.

@nataraj93 Can you executegauge version on the command line and paste the contents here. It would help us debug the issue further.

@nehashri Yes, the issue occurred after updating Gauge.
BEFORE UPDATE:
C:\Users\xyz>gauge version
Gauge version: 0.9.5
Commit Hash: 51cfe8d
Plugins
html-report (4.0.2)
java (0.6.6)
json-report (0.2.1)
screenshot (0.0.1)
xml-report (0.2.0)
AFTER UPDATE:
C:\Users\xyz>gauge version
Gauge version: 0.9.7
Commit Hash: bc9784c
Plugins
html-report (4.0.3)
java (0.6.6)
json-report (0.2.1)
screenshot (0.0.1)
xml-report (0.2.0)

@nataraj93 Unfortunately I am not able to reproduce this issue. There may some version mismatch or something on your machine.
Are you using any custom theme path from html-report (GAUGE_HTML_REPORT_THEME_PATH env variable)?
If not can you try uninstalling gauge and its plugins and try to install again?

@nehashri  No, I am not using any custom theme path but we do use gauge_reports_dir to generate report on a custom location. Let me reinstall all components and get back.

I am experiencing this as well.
Gauge 0.9.7
csharp 0.10.1
html-report 4.0.3
Was also experiencing with Gauge 0.9.5

@nehashri I tried reinstalling on different systems with same version as mentioned above and the detailed view in report is not displayed. On a clean system (i.e.) where gauge is installed for 1st time with version 0.9.7 and reverted back to version 0.9.5 then test ran on Gauge 0.9.5 the issue was reproducible.

@nataraj93, @evanwoah can you try using the latest gauge nightly: https://bintray.com/gauge/Gauge/Nightly/_latestVersion and see if you still face this issue?

@nataraj93, @evanwoah can you try using the latest gauge nightly: https://bintray.com/gauge/Gauge/Nightly/_latestVersion and see if you still face this issue?

@nataraj93, @evanwoah can you try using the latest gauge nightly: https://bintray.com/gauge/Gauge/Nightly/_latestVersion and see if you still face this issue?

@sriv yes nightly works, WriteMessage() outputs to the HTML report! Thank you.

@natraj93 Kindly confirm if using the latest gauge nightly solves this issue.

@sguptatw yes, issue is not reproducible with nightly build.


[evolution] sfpegPlanningCmp - Add time period display range property

The current time period display range is automatically computed by the component based on the minimal StartDate and maximal EndDate of the provided data rows.
For some use cases, it would be nive to be able to limit the displayed range independently from this min/max calculation : e.g. when focusing on the current month and displaying all records active during this period (i.e. created during, closing during, created before and closing after).

Implemented in commit 8f8e48e
Date Range Start/End properties now available.


Bug 2144067: core: Remove unnecessary env vars from pod specs

Description of your changes:
The fsid, username, and user secrets were from legacy and no longer needed on the osd daemon or mon pods. This removes the unnecessary env vars from the pod specs.
Which issue is resolved by this Pull Request:
Resolves #https://bugzilla.redhat.com/show_bug.cgi?id=2144067
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
[ ] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

/cherry-pick release-4.10

/cherry-pick release-4.11


Inpainting error: TypeError: unsupported operand type(s) for -: 'list' and 'int'

For some reason, I keep getting this bizarre error that occurs whenever I try to inpaint. I'm not trying to use any scripts, although it doesn't matter if I specify a script or not - something is expecting an integer and getting a list, and I suspect it is because script_index is an incorrect value: self.selectable_scripts[script_index-1].
Error completing request
Arguments: ('', 4, 'asdf', 'asdf', 'None', <PIL.PngImagePlugin.PngImageFile image mode=RGBA size=512x512 at 0x2951AEBA9E0>, None, None, None, None, <PIL.PngImagePlugin.PngImageFile image mode=RGBA size=512x512 at 0x2951AEBA9E0>, <PIL.Image.Image image mode=L size=512x512 at 0x2951AEBAE60>, 150, 17, 0, None, 1, False, False, 1, 1, 5.0, 0, 0.75, -1, -1, 0.0, 0, 0, False, 512, 512, 1, False, 0, False, '', '', '', [], 0) {}
Traceback (most recent call last):
  File "A:\Programs\stable-diffusion-webui\modules\call_queue.py", line 56, in f
    res = list(func(*args, **kwargs))
  File "A:\Programs\stable-diffusion-webui\modules\call_queue.py", line 37, in f
    res = func(*args, **kwargs)
  File "A:\Programs\stable-diffusion-webui\modules\img2img.py", line 166, in img2img
    processed = modules.scripts.scripts_img2img.run(p, *args)
  File "A:\Programs\stable-diffusion-webui\modules\scripts.py", line 370, in run
    script = self.selectable_scripts[script_index-1]
TypeError: unsupported operand type(s) for -: 'list' and 'int'

The effect is that the selected layer has its visibility toggled off, and nothing else happens.

It appears reverting to commit 2358931f57f1faee4196d87dd5323473948890dc fixes it.

Hm seems like maybe upstream allows selecting multiple scripts at once now. Well, I will worry about that next weekend.

I do have the same problem :(

Hm seems like maybe upstream allows selecting multiple scripts at once now. Well, I will worry about that next weekend.

When I wrote this, why did I not link the specific webUI commit that changed this

thanks for this krita extension. text2img works fine but img2img and inpainting don't work at all.
script = self.selectable_scripts[script_index-1]

TypeError: unsupported operand type(s) for -: 'str' and 'int'

I hope this problem gets solved so that I can use this plugin again. (┬┬﹏┬┬)


Alacritty doesn't close unless it's active

(As suggested here by @kchibisov, I open this separate issue.)
OS: macOS 10.11
Alacritty: a75e949 (the latest master)
To reproduce: Run "sleep 3 && exit" and then switch to another application. Alacritty won't close itself after 3 seconds, like it should, until the cursor moves back to it.
https://i.imgur.com/dKx5XP5.gif
Notes: as pointed out by @kchibisov, this doesn't happen with 0.3.3 release (cc3e4d3), so it must be some sort of regression.

likely related to https://github.com/rust-windowing/winit/issues/1117.

Could you test #2910?

Seems to work OK, thanks!
You / me are closing this?


Update enzyme-to-json to support React 16.2

enzyme-to-json was updated to 3.3.0 to support fragments (https://github.com/adriantoine/enzyme-to-json/pull/90) when serializing components. Since jest-enzyme uses it, we need to update that dependency.

@blainekasten let me know how this looks

This looks great but I don't think it actually makes a difference because of the ^. Am I wrong?

The package.json change was not necessary. The real change is in the lock files that needed to be updated @blainekasten

Thanks!


Next-themes not working

Currently using next js 13 and the theme toggle feature with next-themes doesn't work. Any pointers?

Without any code or repro it's hard to tell. Create a repro with codesandbox or stackblitz and share the link.

In case if you used the example from shadcn's documentation, and it won't change the Theme on toggle, then try moving the ThemeProvider ouside of the body, instead inside as it's shown in the docs.
Here is my Layout:
`

 // Move Provider outside of body element

              {children}

`
Everything else is just as shown here:
https://ui.shadcn.com/docs/dark-mode/next
I just had the same issue, where the toggle would not update the theme on a new Next project. Next Version: 13.5.4 & Next-Themes Version: 0.2.1.
Hope this helped

Yes it did , thanks! , i should've provided some code samples. Everything works fine

Hi, I am facing an issue in next-themes.
I am trying to create a toggle for mode change. But my local storage theme is not updating on hitting the refresh button.
Due to which, if i set my theme as light and then hit the refresh button, my toggle switches to dark but my theme is still light on-screen and in local storage.
I have set my toggle on condition that if theme is light then get on sun icon else on moon icon. So if i am on light theme, on hit of refresh icon, probably my theme is set as undefined or whatever so my toggle switches to moon, but my local storage still shows theme as light.

In case if you used the example from shadcn's documentation, and it won't change the Theme on toggle, then try moving the ThemeProvider ouside of the body, instead inside as it's shown in the docs.
Here is my Layout: `
// Move Provider outside of body element {children} `
Everything else is just as shown here: https://ui.shadcn.com/docs/dark-mode/next
I just had the same issue, where the toggle would not update the theme on a new Next project. Next Version: 13.5.4 & Next-Themes Version: 0.2.1.
Hope this helped

I did it like this but there comes another problem so ThemeProvider goes at the top which renders the script of next-theme outside body ta which gives hydration issue


error inside of class LaravelExcelController method setValueOfCell

[BUG]
Package version, Laravel version
2.1
Expected behaviour
If you have a number without 0 on the left you have to threat it like a number. So I'm sending the pDataType according if it's a decimal or a integer with 0 on the left.
Actual behaviour
If you have a number with or without 0 on the left it's treating like a string
Proposal of code to change method setValueOfCell inside of class LaravelExcelController
    public function setValueOfCell($cellValue, $currentColumn, $startRow)
    {
        $pDataType = ((substr($cellValue, 0, 1) != 0 or (substr($cellValue, 0, 1) == 0 and !is_integer($cellValue))) ? 'n' : 's');
        is_string($cellValue) && is_numeric($cellValue) && !is_integer($cellValue)
            ? $this->getCell($currentColumn . $startRow)->setValueExplicit($cellValue, $pDataType)
            : $this->getCell($currentColumn . $startRow)->setValue($cellValue);
    }

Please make a PR with a unit test for code changes.


MaxLengthError for pre-training

Describe the bug
What the bug is, and how to reproduce, better with screenshots(描述bug以及复现过程，最好有截图)
when doing pre-training, each row can be very long, and it seems that it directly drops the row instead of doing some samples packing. Streaming yields time out since the network is not stable in my env.
Map (num_proc=128):   0%|                                       | 5000/5489000 [00:06<1:34:21, 968.70 examples/s]
Traceback (most recent call last):
File "swift/llm/dataset/preprocessor/core.py", line 155, in batched_preprocess
row = self.preprocess(row)
File "swift/llm/dataset/utils.py", line 202, in preprocess
return self.template.encode(row)
File "swift/llm/template/base.py", line 205, in encode
encoded = self._encode(inputs)
File "swift/llm/template/base.py", line 628, in _encode
raise MaxLengthError(f'Current length of row({len(input_ids)}) is larger'
swift.llm.template.base.MaxLengthError: Current length of row(5762) is larger than the max_length(2048).
[ERROR:swift] 👆👆👆There are errors in the dataset, the data will be deleted
Your hardware and system info
Write your system info like CUDA version/system/GPU/torch version here(在这里给出硬件信息和系统信息，如CUDA版本，系统，GPU型号和torch版本等)
Additional context
Add any other context about the problem here(在这里补充其他信息)

You can control it through --max_length xxx.

Thanks for quick response! Another quick question: what is the typical max_length value for the pre-training dataest, and also can I use the --packing true to pack the examples?

Yes, you can use --packing true for packing examples. The value of max_length depends on the GPU memory situation.


image can not show in the org files

hi,
how can I do if I want to show the image files in the org mode?
there is nothing happened when I use the iimage-mode in my org files.
Thank you in advance.
my system is windows 10, emacs is 25.3

Not sure, sorry, but it's possible that your Emacs isn't built with image support.


Version 0.17.0

Added

Add field description to Create/Edit templates by @ngaranko in https://github.com/aminalaee/sqladmin/pull/722
Add edit_form_query method by @lukeclimen in https://github.com/aminalaee/sqladmin/pull/745
Validate page and pageSize query parameters by @BhuwanPandey in https://github.com/aminalaee/sqladmin/pull/752

Fixed

Hide save and add another button from edit.html if can_create is False by @MaximZemskov in https://github.com/aminalaee/sqladmin/pull/742
Fix list page sort symbol by @aminalaee in https://github.com/aminalaee/sqladmin/pull/744
Move template files from templates to templates/sqladmin by @hasansezertasan in https://github.com/aminalaee/sqladmin/pull/748
Fix form_args default by @aminalaee in https://github.com/aminalaee/sqladmin/pull/756
Fix getting column python type by @aminalaee in https://github.com/aminalaee/sqladmin/pull/757
Fix File and Image fields checkbox and input by @aminalaee in https://github.com/aminalaee/sqladmin/pull/761
Switch relationship loading to selectionload by @aminalaee in https://github.com/aminalaee/sqladmin/pull/758
Fix DELETE call query params by @aminalaee in https://github.com/aminalaee/sqladmin/pull/763

New Contributors

@ngaranko made their first contribution in https://github.com/aminalaee/sqladmin/pull/722
@MaximZemskov made their first contribution in https://github.com/aminalaee/sqladmin/pull/742
@hasansezertasan made their first contribution in https://github.com/aminalaee/sqladmin/pull/748
@lukeclimen made their first contribution in https://github.com/aminalaee/sqladmin/pull/745
@BhuwanPandey made their first contribution in https://github.com/aminalaee/sqladmin/pull/752

Full Changelog: https://github.com/aminalaee/sqladmin/compare/0.16.1...0.17.0

I started to use this project when it was 0.8.X and it grows quite well.
Thanks everyone 🙏.


Add formset:added and formset:removed events

trigger formset:added and formset:removed events

@OskarPersson any chances to get that merged one day? It's really annoying that the django-nested-inline doesn't work well with any other plugin depending on formset:added and formset:removed events

not the only one that added (and depends) on this apparently:
https://github.com/Dmitri-Sintsov/django-nested-inline/commit/b0553beb82a2a46d1204e8849f188587d3e72083

I know it's been a while since this PR was created (it was created before I became a maintainer of this repo!) but which tool did you use to minify the code? It's good to know going forward with other potential changes

Good question. It's been a while, but most likely prettier. I can try to re-generate it to compare

Thanks!


Runtime assertion fail with CUDA NOT ENABLED, on shared dlib

I've created a shared lib, with cuda.
-- Looking for cuDNN install...
-- Configuring done
-- Generating done
-- Build files have been written to: /home/indy/dev/vision/dlib-19.4/dlib/build
indy@dev-dev2:~/dev/vision/dlib-19.4/dlib/build$ make clean;make
[  0%] Building NVCC (Device) object CMakeFiles/dlib.dir/dnn/dlib_generated_cuda_dlib.cu.o
[  1%] Building CXX object CMakeFiles/dlib.dir/base64/base64_kernel_1.cpp.o

Still at runtime, program crashes with
**************************** FATAL ERROR DETECTED ****************************

Error detected at line 120.
Error detected in file ./dlib-19.4/dlib/dnn/gpu_data.h.
Error detected in function float* dlib::gpu_data::device().

Failing expression was false.
CUDA NOT ENABLED

Which means the gpu_data.cc was compiled without DLIB_USE_CUDA compiler flag.
Is this something that you have specify when building dlib as shared lib ?
If so how ?
Any ideas?
Thanks

Obviously you didn't compile with DLIB_USE_CUDA.  Look at where that error
message comes from, it's right inside an #ifndef DLIB_USE_CUDA block.
Anyway, do the example programs that use the DNN compile (when you haven't
modified any code in dlib)?  They will use cuda.

Thanks! I was wondering why DLIB_USE_CUDA has to be manually specified when compiling shared dlib lib. It looks like without this flag, dlib gpu based bits can't be used at runtime. Trying to understand the rationale.

You don't need to do anything with it.  CMake will automatically set it if you have cuda, unless you overwrite it via cmake's config options.  You will never need to say anything about DLIB_USE_CUDA.

So this was compiled with CMake as is, without overwriting anything. I do have Cuda 8.0 and CuDnn 5.1

You haven't told me what you did yet.  You only posted partial snippets of some output and not even the commands you ran, other than make.

apologies, will post the steps I took properly.

complete build steps
on Ubuntu 16.04
indy@indy-dev2:~/dev/vision/dlib-19.4/dlib$ mkdir build;cd build;cmake ..;make
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- C++11 activated.
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib/x86_64-linux-gnu/libX11.so
-- Looking for png_create_read_struct
-- Looking for png_create_read_struct - found
-- Looking for jpeg_read_header
-- Looking for jpeg_read_header - found
-- Searching for BLAS and LAPACK
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for module 'cblas'
--   No package 'cblas' found
-- Checking for module 'lapack'
--   Found lapack, version 3.10.2
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of void*
-- Check size of void* - done
-- Found LAPACK library
-- Found ATLAS BLAS library
-- Looking for cblas_ddot
-- Looking for cblas_ddot - found
-- Found CUDA: /usr/local/cuda (found suitable version "8.0", minimum required is "7.5")
-- Looking for cuDNN install...
-- Building a CUDA test project to see if your compiler is compatible with CUDA...
-- Checking if you have the right version of cuDNN installed.
  And then how do you get the error?  If you compile the example programs do you get the error?
Also, you don't need to install dlib.

Example, dnn_face_recognition_ex runs fine after compiling using cmake as per instructions on http://dlib.net/compile.html
But I'm unsure if that was using the shared lib I created
My prog was compiled with
CXX = g++
CXXFLAGS += -std=c++11
LDFLAGS += -L/usr/local/lib `pkg-config --libs grpc++ opencv`            \
           -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed \
           -lprotobuf -lpthread -ldl \

frecog: module_comms.pb.o module_comms.grpc.pb.o protocols.pb.o frecog.o
	$(CXX) $^ $(LDFLAGS) $(CXXFLAGS) -DDLIB_USE_CUDA -ldlib -O3 -o $@

This compiles fine. Only crashes when it hits
std::vector<dlib::matrix<float,0,1>> face_descriptors = net(dlib_faces);

The example cmake file doesn't use your shared library.  You don't need to say DLIB_USE_CUDA on the command line.  All the flags are set by /usr/local/include/dlib/config.h which should already have it in there.

Yes, I haven't modified anything. Just find it baffling that the shared lib that was created with CUDA to not have CUDA enabled. Is there any occasion that cmake silently disable CUDA incase CUDA installation has some problems (I've checked and installations seem fine though)

No.  It won't silently disable it.
What is in /usr/local/include/dlib/config.h?

// If you are compiling dlib as a shared library and installing it somewhere on your system
// then it is important that any programs that use dlib agree on the state of the
// DLIB_ASSERT statements (i.e. they are either always on or always off).  Therefore,
// uncomment one of the following lines to force all DLIB_ASSERTs to either always on or
// always off.  If you don't define one of these two macros then DLIB_ASSERT will toggle
// automatically depending on the state of certain other macros, which is not what you want
// when creating a shared library.
/* #undef ENABLE_ASSERTS */
#define DLIB_DISABLE_ASSERTS // asserts always disabled

/* #undef DLIB_ISO_CPP_ONLY */
/* #undef DLIB_NO_GUI_SUPPORT */
/* #undef DLIB_ENABLE_STACK_TRACE */

// You should also consider telling dlib to link against libjpeg, libpng, libgif, fftw, CUDA,
// and a BLAS and LAPACK library.  To do this you need to uncomment the following #defines.
#define DLIB_JPEG_SUPPORT
#define DLIB_PNG_SUPPORT
/* #undef DLIB_GIF_SUPPORT */
/* #undef DLIB_USE_FFTW */
#define DLIB_USE_BLAS
#define DLIB_USE_LAPACK
#define DLIB_USE_CUDA
/* #undef DLIB_USE_MKL_FFT */

Well, that file includes #define DLIB_USE_CUDA.  So you are apparently not using the copy of dlib in /usr/local/include since if you were DLIB_USE_CUDA would be defined.  So there is your problem.  You aren't compiling the code you think you are.

Thanks for helping out to track this down. I guess having dlib extracted as a subfolder of your project is not a good idea when wanting to use as a shared lib.

This applies to all code in every programming language.  When you import/include something you have to put the right files on your computer in a place the compiler finds.  You put the wrong files there you get the wrong result.

@Indy9000: Hi.
I am also facing the same issue. What did you do to resolve this ?
Thank you.


editors not showing up

Describe your bug here.
ive recently decided to try to make an fnf mod, and in the tutorial im using to makoe a sprite i need to use psych engine so of course i downloaded it and you gotta go to story mode because the editors will apparently be there but its just all the weeks from 1 to 7 and ive tried everything yet nothing worked
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
nope i think

You're supposed to press 7 on the MAIN MENU, not Story Mode.


Bump puppetlabs/apt dependency

According to the Puppet Style Guide https://docs.puppet.com/puppet/latest/style_guide.html#dependencies , epel and apt are soft dependencies and should be treated as such.
Warning: Module 'puppetlabs-apt' (v4.0.0) fails to meet some dependencies:
  'elastic-elasticsearch' (v5.1.0) requires 'puppetlabs-apt' (>= 2.0.0 < 3.0.0)

Hey @den-is, I read that documentation page and it cites the rabbitmq module as an example, which declares the apt  module dependency in the same way this module does. Is there some documentation around or some official modules that illustrate apt is a soft dependency?

Hello,
I get that you copied from rabbitmq, but what's the rational in having a limit on the maximum version ? I get the minimum one, but the max...
Oh, BTW, rabbitmq module has updated its dependencies:
https://github.com/puppetlabs/puppetlabs-rabbitmq/blob/master/metadata.json

@alaunay maximum allowed version numbers are included in the metadata.json file because 1) it's safer (i.e., any breaking changes with a major version change have to be tested first), and 2) because the forge actively penalizes any module that includes dependencies without one (for the aforementioned reason).

Ok, thanks for the explanation, I get it.
That being said, I just tested with the latest puppetlabs-apt 4.x (and some debian behind), it works just well. Maybe modifying the dep like the rabbitmq module, with a < 5.0.0 as a max  for now ?

Sure - I can update the tests to test against 4.x and if everything passes, I'll go ahead and update the metadata file.

Updated in #858, will go out in the next release.


Where are the service description files from?

It seems that a lot of bindings source the json description files from botocore. Where does botocore get them from?

We generate these files based on our internal knowledge of AWS services.


Clean pandas usage in frame.agg

I came across the frame.agg when i read through code base, and based on the inline comment, I think the manipulation using pandas could be simplified a bit IIUC.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3e263df). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #821   +/-   ##
=========================================
  Coverage          ?   92.08%
=========================================
  Files             ?       32
  Lines             ?     5853
  Branches          ?        0
=========================================
  Hits              ?     5390
  Misses            ?      463
  Partials          ?        0

Impacted Files
Coverage Δ

databricks/koalas/frame.py
95.23% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e263df...03be943. Read the comment docs.

Thanks! merging.

Nice! Thanks!


ImportError: cannot import name 'ColumnDT'

I am getting the error ImportError: cannot import name 'ColumnDT' when deployed to Heroku. However, it runs normally in my local machine.
I figured the reason was that I also had the package datatables installed so I removed that one. Unfortunately, I am now getting the error in my local machine also. Am I supposed to have datatables also installed in the venv?

Actually, I re-installed the sqlalchemy-datatables on my venv and it's working locally now. However, I am still getting the problem ImportError: cannot import name 'ColumnDT' on Heroku.

Just an update: fixed it already by specifying my run time to match my local Python version. (3.6.6)


[🐞] ERROR in<EMAIL_ADDRESS>12:55-64 export 'default' (imported as 'workerUrl') was not found in './worker.js?worker&url' (module has no exports)

Which component is affected?
Qwik Runtime
Describe the bug
Quick Worker
ERROR in<EMAIL_ADDRESS>12:55-64
export 'default' (imported as 'workerUrl') was not found in './worker.js?worker&url' (module has no exports)
ERROR in<EMAIL_ADDRESS>151:49-56
Module not found: Error: Can't resolve 'process/browser' in<EMAIL_ADDRESS>Reproduction
https://stackblitz.com/edit/qwik-starter-yccqus?file=src%2Fcomponents%2Fstarter%2Fcounter%2Fcounter.tsx
Steps to reproduce
import { worker$ } from<EMAIL_ADDRESS>and use it in a JSX component function
System Info
System:
    OS: macOS 13.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 67.47 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.14.0 - /usr/local/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 9.4.0 - /opt/homebrew/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 114.0.5735.133
    Safari: 16.2
  npmPackages:
    @builder.io/qwik-worker: ^0.0.1 => 0.0.1

Additional Information
No response

I've looked at the reproduction, seems like it's trying to export a worker as a component.
The idea of worker$ is to move computation or function execution to a web worker, not the rendering...


[Memorystore] Redis 6.x support

Currently, there is no support in cache.gcp.crossplane.io/v1beta1 for Redis 6.
It's the latest Redis version available for provisioning in GCP. Would be great to have it on board.
Thank you in advance!

I've find out that actually Redis 6 is supported if redisVersion: REDIS_6_X is supplied (instead of redisVersion: REDIS_6_0)
Would appreciate if documentation will be updated as well!


bugfix restoreDevonfwIde: added batch mode

run failes because of the cobigen Tutorial, so it can't be merged.


Pulled in workbench-libs, removed ErrorReport copypasta

Note: requires https://github.com/broadinstitute/workbench-libs/pull/7 to be merged and our dependency on it updated before we can proceed.

[ ] Submitter: Include the JIRA issue number in the PR description
[ ] Submitter: Make sure Swagger is updated if API changes
[ ] Submitter: If updating admin endpoints, also update firecloud-admin-cli
[ ] Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
[ ] Submitter: JIRA ticket checks:

Acceptance criteria exists and is met
Note any changes to implementation from the description
To Demo flag is set
Release Summary is filled out, if applicable
Add notes on how to QA

[ ] Submitter: Update RC_XXX release ticket with any config or environment changes necessary
[ ] Submitter: Update FISMA documentation if changes to:

Authentication
Authorization
Encryption
Audit trails

[ ] Tell the tech lead (TL) that the PR exists if they wants to look at it
[ ] Anoint a lead reviewer (LR). Assign PR to LR

Review cycle:

LR reviews
Rest of team may comment on PR at will
LR assigns to submitter for feedback fixes
Submitter rebases to develop again if necessary
Submitter makes further commits. DO NOT SQUASH
Submitter updates documentation as needed
Submitter reassigns to LR for further feedback

[ ] TL sign off
[ ] LR sign off
[ ] Product Owner sign off
[ ] Assign to submitter to finalize
[ ] Submitter: Verify all tests go green, including CI tests
[ ] Submitter: Squash commits and merge to develop
[ ] Submitter: Delete branch after merge
[ ] Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
[ ] Submitter: Verify swagger UI on dev environment still works after deployment
[ ] Submitter: Inform other teams of any API changes via Slack and/or email
[ ] Submitter: Mark JIRA issue as resolved once this checklist is completed

Coverage increased (+13.0%) to 39.655% when pulling 8ddd742b8a90d1977fac2fcd5350c45d24c4b41b on workbench_libs into 030a2dcd4d256c7e522ed5b66ac82e4d2182e394 on develop.

Coverage increased (+13.0%) to 39.655% when pulling e8dc3de6223d49f8d0f853d0c3400966a2509501 on workbench_libs into 030a2dcd4d256c7e522ed5b66ac82e4d2182e394 on develop.

@ansingh7115 this is likely going to break your copypasta in your branch, so i'd recommend you rebase. the good news is you can get rid of some of the copypasta now!

Coverage increased (+13.0%) to 39.655% when pulling dfc351b64474dc5b153864a9037a3195bb58836f on workbench_libs into 030a2dcd4d256c7e522ed5b66ac82e4d2182e394 on develop.

Coverage increased (+13.0%) to 39.655% when pulling a1d23077c935bd5380f40c9ae57e6c583fc85b53 on workbench_libs into 030a2dcd4d256c7e522ed5b66ac82e4d2182e394 on develop.


How can I truncate filenames in projectile-find-file and counsel-projectile-find-file

My projects often have a lot of depth, and some paths longer than the width of the emacs window. Is it possible to truncate long filepaths so that I can still see the filename?

See SPC h f ivy-set-display-transformer for defining transformers for ivy/counsel commands. You can define one to shorten the file names however you wish.

As this is not a bug or an actionable ticket (our issue tracker will no longer be for how-to questions once our Discourse is up), I will close this, but feel free to follow up here.

See SPC h f ivy-set-display-transformer for defining transformers for ivy/counsel commands. You can define one to shorten the file names however you wish.

I had tried this before commenting but with little luck, taking a more thorough look at the readme for ivy-rich shows that for counsel-projectile-* and other extended ivy/counsel commands ivy-rich needs to be loaded after counsel-projectile, which doom isn't.
After enabling and disabling ivy-rich mode somethig simple like this works fine:
(after! ivy-rich
  (plist-put! ivy-rich-display-transformers-list
              'counsel-projectile-find-file (lambda (x) (shrink-path-dirs x))))

Is this worth raising a bug over?

Try
(after! counsel-projectile
  (ivy-set-display-transformer #'counsel-projectile-find-file #'name-of-your-private-transformer-function))

ivy-rich needs to be loaded after counsel-projectile, which doom isn't.

ivy-rich does not target counsel-projectile-find-file, so ivy-rich isn't relevant to this issue. It's more likely you are seeing the effect of this line, hence my suggestion above.

Is this worth raising a bug over?

No. Haven't ruled out that this is a configuration issue, rather than a bug.

(after! counsel-projectile
  (ivy-set-display-transformer
              #'counsel-projectile-find-file (lambda (x) (shrink-path-dirs x))))

Does not work on startup, or after disabling and reenabling ivy-rich.


Remove the support for hidden_envoy_deprecated_per_filter_config

Update the constructor of PerFilterConfigs
Remove the deprecated tests that are using per_filter_config field.

Signed-off-by: Tianyu Xia<EMAIL_ADDRESS>
Risk Level: LOW
Testing: CI

/assign @htuch
PTAL. Thanks!


Change for getmypid() error on shared hosting

Q
A

Bug fix?
yes/no

New feature?
yes/no

Doc update?
yes/no

BC breaks?
yes/no

Deprecations?
yes/no

Fixed tickets
#...

License
MIT

Thanks for the pull request. I'm going to close it as this issue has been fixed in #983 for master and 5.x is not maintained anymore.


activating beta features

yes thanks

Why:

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

thanks for your guidance

thanks for your guidance

thanks for your guidance

thanks for your guidance


implement link icons

see #209 for specifics
cleaned up urls in the templates to work better with the icons (moved punctuation inside the links)

@rlskoeser the pdf link style looks and functions well on FF, GC, and Safari.
the icon is slightly smaller than it is on Figma. We decided on keeping the icon at 16px for both desktop and mobile and you are going to change the dimensions from ems to rems, so hopefully it will display a bit larger based on the 16px dimension.


better auth configuration and validation; cleanup

@timcharper PTAL; I ran into some problems during integration testing because I fat-fingered the ConfigMap init. Decided to implement some better config map handling / validation.

Huh, it did work for me. Curious in which scenario it failed?
I'm glad to see there are tests. I'm struggling to see the purpose of the factory registration. It seems like excessive generality to me. The problem could simply be solved if records.InitMesosAuthentication returned a Doer func. Putting the state in a general map rather than just embedding it in the struct implementing the Doer interface creates more possibilities for failure. I think this is perhaps manifested by an increase in the number of panic statements; it's panicking in areas where the type system could be providing compile-time proof, which I tend to prefer.
I don't mean to be critical. I'm super happy you're spending the time to get this right, I just wonder if the complexity brought by the factory actually buys anything. Maybe it does and I just can't see it. I'm not unhappy with the factory pattern. If it works and it makes you happy, I say merge it. :) It's not a huge deal to me.

agreed, could be further simplified. trying to balance my time across multiple efforts and so this is where I landed here. i'm also not happy with the panics. there's certainly room for another round or two of refactoring. if we want this to land for dc/os 1.8 that refactoring may have to wait.

@timcharper I should also say "thanks!" for your patience w/ this process. if this works for you please merge this PR into yours.

I'm happy with it is. Could polish it forever but it's concerns are nice and separated, it has tests, and it works! What more could you want? Thank you for collaborating on the change and helping to get it merged, @jdef!
I'll compile it really quick and just check thrice that it works. I'll report the success on the original pull.

@jdef it has tests, it works, it's modular... I'm happy with it as is. Thank you for collaborating on it and helping to get it merged!


[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@karthikku-2020, could you take a look at the lint error?  Is this a valid path  providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost'?   Usually, we need to add  'providers' before Microsoft.Consumption.

@karthikku-2020, could you take a look at the lint error?  Is this a valid path  providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost'?   Usually, we need to add  'providers' before Microsoft.Consumption.

@karthikku-2020, could you take a look at the lint error? Is this a valid path providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost'? Usually, we need to add 'providers' before Microsoft.Consumption.

Thanks for the review @lirenhe. Yes, the above is a valid path. Please refer the public documentation here. The only update was to have correct camel casing and nothing else has been changed.

@karthikku-2020, could you take a look at the lint error? Is this a valid path providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost'? Usually, we need to add 'providers' before Microsoft.Consumption.

Thanks for the review @lirenhe. Yes, the above is a valid path. Please refer the public documentation here. The only update was to have correct camel casing and nothing else has been changed.

if not refresh sdk this time, do you have any plan to release a new SDK/CLI in near future. @karlkuhnhausen

if not refresh sdk this time, do you have any plan to release a new SDK/CLI in near future. @karlkuhnhausen

if not refresh sdk this time, do you have any plan to release a new SDK/CLI in near future. @karthikku-2020

@akning-ms - Not really. After talking to my team there is no plan to release a new SDK/CLI in the near future.

if not refresh sdk this time, do you have any plan to release a new SDK/CLI in near future. @karthikku-2020

@akning-ms - Not really. After talking to my team there is no plan to release a new SDK/CLI in the near future.

if not refresh sdk this time, do you have any plan to release a new SDK/CLI in near future. @karthikku-2020

@akning-ms - Not really. After talking to my team there is no plan to release a new SDK/CLI in the near future.

ideally, we should have a related SDK/CLI release for this change. otherwise, it is no value to fix those swagger issue. right? anyway, I will merge it first.

if not refresh sdk this time, do you have any plan to release a new SDK/CLI in near future. @karthikku-2020

@akning-ms - Not really. After talking to my team there is no plan to release a new SDK/CLI in the near future.

ideally, we should have a related SDK/CLI release for this change. otherwise, it is no value to fix those swagger issue. right? anyway, I will merge it first.


Agora Event Handler not found

I am creating a WebGL application in unity using the Agora SDK and when Join the channel in the build the Render Texture isn't made and in the console there is a warning which says AgoraEventHandler not found and socket closed before establishing connection Any idea about this?

Running the build from a local server using Node in Google Chrome

@Shady9595 please refer to the programming guide on the Wiki page

Hey @icywind I need just some help regarding screen sharing. Is there any tutorial i can follow to make screen share work?


VTOL thrust during backtransition

While performing a transition from FW to MC in airspeed less mode, the thrust of the MC should linearly ramp up, starting when the transition is started. Instead, there is some little peak of MC throttle, then about 1s nothing, then a jump to about 30%:

sfuhrer - outstanding.  I was just running into this exact issue last week.

@dlwalter do you still experience this issue? As far as I can say (don't have a lot of airspeed less flights) we don't with recent code.

I haven't seen it in actual flight - I only saw this on the bench and that was months ago.

I haven't seen it in actual flight - I only saw this on the bench and that was months ago.

Okay, same for me actually (at least the plot above was from a bench setup). I think it was related to the land detector detecting landing (which is fair, given that the vehicle is on the ground^^).
Closing this then.


chore: update dev and system test images

Proposed changes

Update dependencies (dev container and system test image):

update to Debian 12 (bookworm)
install mosquitto >= 2.0.18 as it fixes some bugs with the bridge that thin-edge.io is reliant on
bump robotframework-devicelibrary version (for system tests)

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

@albinsuresh I tested out the dev container definition in this image and it built without any errors.


Quick Notes AI

** Please describe which feature you have a question about? **
I am unable to deploy the react app based on the sample provided by AWS, Quick Notes AI cannot be deployed.
** Provide additional details**

@admissionguidance what error are you getting?

This has been resolved, please let us know if you continue to experience any issues.
Please see this for reference: https://github.com/aws-samples/aws-amplify-quick-notes/issues/3


skipDuplicate: true blocked scanning

With SkipDuplicate option i see that scanned url remain blocked and onDrain not called.
If i set to false all work well, where am I wrong?
Thanks,
Jacopo

Hi guy, what do you mean by remain blocked? Maybe there is bug in skipDuplicate option, I'll check it.

There is.
var crawler = require('crawler');

var c = new crawler({
	maxConnections: 5,
	callback: function (err, res, $) {
		$('a').each(function (index, a) {
			var url = $(a).attr('href');

			c.queue(url);
		});
	},
	onDrain: function () {
		console.log(arguments);
	},
	skipDuplicates: true
});

c.queue('https://google.com');

➜  ~  node crawl.js
/Users/Marketing/node_modules/crawler/node_modules/generic-pool/lib/generic-pool.js:341
    var objWithTimeout = { obj: obj, timeout: (new Date().getTime() + idleTimeoutMillis) };
    ^

RangeError: Maximum call stack size exceeded
    at Object.me.release (/Users/Marketing/node_modules/crawler/node_modules/generic-pool/lib/generic-pool.js:341:5)
    at Crawler._release (/Users/Marketing/node_modules/crawler/lib/crawler.js:125:19)
    at Crawler.<anonymous> (/Users/Marketing/node_modules/crawler/lib/crawler.js:110:14)
    at emitOne (events.js:77:13)
    at Crawler.emit (events.js:169:7)
    at Crawler._onContent (/Users/Marketing/node_modules/crawler/lib/crawler.js:382:21)
    at Request._callback (/Users/Marketing/node_modules/crawler/lib/crawler.js:327:25)
    at self.callback (/Users/Marketing/node_modules/crawler/node_modules/request/request.js:236:22)
    at emitOne (events.js:77:13)
    at Request.emit (events.js:169:7)

Nevermind. My issue was related to the handling of links that start with // instead of http:// or https://

@brandonros Okay. It's better to use seenreq to skip duplicate. And as to the crawler, please just use my node-webcrawler instead, because the current author won't maintain crawler any more and didn't transfer the repo to any others, I have fixed several critical bugs and will continue to maintain it. I'll continue to make it the best crawler in nodejs world.

Close due to inactive.


Let users comment on songs

As an admin, I often see users trying to add comments to songs via the "add lyrics/tags" functionality.
I have to reject those submissions, of course, but the it shows an organic need for our users. I think it would help build community around Chavah as well.

This is now implemented.


Fix typo

a -> an

@changeworld : Thanks for your contribution! The author, @PatAltimore, has been notified to review your proposed change.

@changeworld Thanks for the fix. Looks good.
Pat
#sign-off


Error : SQLITE_CURRUPT

i created a multiple address wallet on my mac book
and the application crashed when it were syncing (i selected a full version wallet)
now, it shows this dialog every time i open it

the application works fine on my mobile phone.
but i can't transfer any bytes with my mobile phone. (it's a 2/2 multiple sig wallet)
how can i fix this?
sorry for my poor english
and I will appreciate your help with this situation.

The message says that your database is corrupt.  You have to revert to a backup.

but it's the first time sync


Bugfix: Slash Menu Not Functioning in Alpha Editor

Context
After merging PR #1068, the slash menu in the alpha editor stopped functioning. The issue appears to have originated from changes introduced in that PR.
Expected Behavior
When a user presses the "/" key, the slash menu options should be displayed on the screen. This functionality worked correctly prior to PR #1068.
Pull a commit prior to this PR to see how it should work.
Current Behavior
Currently, pressing the "/" key does not seem to trigger any action, and the slash menu does not appear.
Screenshots
Slash menu :

Hii @John-Paul-Larkin.I would like to work on this issue.Can u assign me this issue?

Thanks @PAVAN507-STAR
I assigned you.

hi @PAVAN507-STAR
How are you getting on with this issue?

I’ve tried to reset the commit and see what happens but it seems multiple folders were deleted in the mentioned pr and some other pr’s too. So rn im trying to see if i can implement the feature without the deleted folders somehow ,btw do u have  any idea what are the folders that got deleted but are required to implement the feature?

@PAVAN507-STAR
Unfortunately I do not. If you roll back to an older commit you will be able to see the implementation. Thanks.

This one might be fixed in the design updates PR that is open. I haven't tested it but I saw from the code it looked promising.


[Bug]: Punycode warning

Opencommit Version
3.0.15
Node Version
21.7.3
NPM Version
10.5.0
What OS are you seeing the problem on?
Mac
What happened?
Seeing this warning when running any oco commends:
(node:39887) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Expected Behavior
No warning
Current Behavior
Is a warning
Possible Solution
No response
Steps to Reproduce
No response
Relevant log output
No response

hi @zain thanks for the report, do you want to take a look at it an submit a PR making world a better place together?

I'm happy to fix this as I'm encountering the same issue. Is there a contribution guide, or any instructions on how to set this up properly?

yes, please look into .github/CONTRIBUTION.md

The deprecation warning comes from @anthropaic-ai/sdk and openai having dependencies on older node-fetch versions. Unfortunately updating those packages and especially the openai package requires rewriting the API logic.

@btglr hi there 👋 could you please share what exactly needs to be rewritten? i will manage, it finally started to annoy me

should be fixed with a new version. please update and follow up @zain

@di-sukharev Got again in new version at 3.1.1 node version is 22.7.0
(node:66000) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

thanks @minarc, will investigate and reopen the issue if we get more people here

still happen in my end using node `v22.9.0` and oco `3.2.2`


Cannot select "Leistung Heim" and "Leistung PV" in home assistants native section for "Energie"

Checklist

[X] I have installed the latest release (or BETA) version of the integration and home assistant.
[X] I have prepared DEBUG log output (for technical issues) | In most of the cases of a technical error/issue I would have the need to ask for DEBUG log output of the integration. There is a short tutorial/guide 'How to provide DEBUG log' here
[X] I confirm it's really an issue | In the case that you want to understand the functionality of a certain feature/sensor Please be so kind and make use if the discussion feature of this repo (and do not create an issue) - TIA

Add a description
Hi.
GRIDPOWER, HOMEPOWER and PVPOWER have unit_of_measuremen= UnitOfPower.WATT.
I would like to use these sensors to power the native Energy functions of Home Assistant, which means I want to select these sensors under Energie -> Netzverbrauch and Engerie -> Netzeinspeisung in the Home Assistant UI.
But that's not possible as home assistant excepts the unit_of_measuremen to be an energy measurement, not a power measurement, for example UnitOfPower.WATTHOURS.
And idea on what I need to do to make these values available to be consumed by the Energy-area of home assistant?

Add your DEBUG log output
No response

well - you can't change the world of Physics - Energy is Power per Time...
-> you can use the Riemann Sum Integal Platform to reach your goal... you can check out this as reference how to do it... -> https://github.com/marq24/ha-senec-v3/issues/4


Changed Struct Variables names and Added two endpoints of "add & remo…

…ve Service "

@rushikesh-kulkarni make the changes & push the code ASAP


Persistency not working or db not connecting/replicating

Hi Guys,
I've been trying to use orbit-db without success (angular 5 project), not sure why, but persistency is not working and db is not triggering replicateX events.
Here is my code:
import * as IPFS from 'ipfs';
import * as OrbitDB from 'orbit-db';
...

const ipfsOptions = {
start: true,
repo: './test',
EXPERIMENTAL: {
pubsub: true
},
config: {
Addresses: {
  Swarm: [
    '/dns4/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star',
  ]
},
}
};
...
this.ipfs = new IPFS(ipfsOptions);
this.ipfs.on('error', (e) => console.error('IPFS - error', e) );
this.ipfs.on('ready', async () => {
  this.orbitdb = new OrbitDB(this.ipfs, './test');
  // console.log('orbit - public key', this.orbitdb.key.getPublic('hex') );

  const dbConfig = {
    replicate: true,
    create: true,
    sync: true,
    localOnly: false,
    // type: 'keyvalue',
    // Give write access to ourselves
    // admin: [this.orbitdb.key.getPublic('hex')],
    write: ['*'],
  };
  this.db = await this.orbitdb.keyvalue('test.user', dbConfig);
/* /////////////////////////////////////////////////// */

  // Listen for updates from peers
  this.db.events.on('ready', (res) => {
    console.log('db ready', res);
    console.log('orbitdb - keyvalue', this.db.address.toString(), this.db.get('user'), this.db.get('state') );
    this.orbitObserver.next( { dbLoaded: true } );
  });
  this.db.events.on('synced', (res) => {
    console.log('db synced', res);
  });
  this.db.events.on('load.progress', (address, hash, entry, progress, total) => {
    console.log('db - load.progress', progress, total);
  });
  this.db.events.on('replicated', (address) => {
    console.log( 'db - replicated - state', this.db.get('state'), address );
  });
  this.db.events.on('replicate', (address) => console.log('db - replicate', address ) );
  this.db.events.on('replicate.progress', (address) => console.log('db - replicate progress', address) );
  this.db.events.on('write', (res) => {
    const userValue = this.db.get('user');
    const tmpValue = this.db.get('state');
    console.log('db write', res, userValue, tmpValue);
  });
  await this.db.load();
});

The events triggering are ready and write, but the db is always empty after reload the page.
Any help, please?
Thanks, E

I'll still check browser examples but here's a repo with a repro of the problem –  although I think I might be doing something wrong.
https://github.com/thiagodelgado111/orbitdb-persistency-reproduce

Looking at the browser example, using docstore
If you create a db and let it write an entry, after a reload, when you open that db, it lists no entries

Thank you everyone for looking into this! ❤I found the bug 👍😄
It is indeed the case in the browsers that the persisted db doesn't load. This was due to an early return in the local cache module (due to API differences between browser leveldb and nodejs leveldb). The good news is, the db does get persisted (as expected), it just wasn't loaded correctly.
This will be fixed with https://github.com/orbitdb/orbit-db/pull/316 and once it's in, I'll publish a new version to npm. Will post here when it's published.

Published to npm as 0.19.4.
Let us know, and re-open the issue, if you're still experiencing problems!