[BUG] Model runs after passing verification checks

Is there an existing issue for this?

[X] I have searched the existing issues

Description
After generation of the report, the model keeps running but will not run to completion. While this has been reported previously, as there are logs, I suspect it is a separate problem.
Current Behavior
After I request for generation of the report, the model keeps running but will not run to completion, hence am unable to get the report as a product. See below for what I am experiencing.

Expected Behavior
I expect the platform to generate the report at a suitable timeframe.
Steps To Reproduce
Standard report generation steps were utilized, nothing out of the ordinary. Of note, this is a regression model.
Environment
- Operating System and Version: Windoews 11
- AI Verify Version: AI Verify 0.9
- Any other relevant information (e.g. version of related package dependencies installed):

Did you build using source code or from docker file? If from source code, please provide the below information: This was built from docker file.
- Python Version:
- Node Version:
- Redis Version:
- Mongo Version:
- Screen Resolution:

Screenshots/ Code snippets
This is the logs that were displayed on the report generation page:
SHAP Toolkit
shap_log.txt
Robustness Toolkit
robustness_log.txt
Fairness Toolkit
fairness_metrics.txt
Additional Context
No response
Possible Solution (Optional)
No response

Hey @yschan-ntu we just released v0.9.2 which includes a bug fix for #135 , which we suspect might be caused by the same task processing issue backend. Please try it out and let us know if this bug still persists, thank you!

Confirming that v0.92 solved this particular issue, now things are running. Will mark as resolved and closed.


feat(plots): Funnel plots

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix default list

These changes try to address the issue with using vim.fn.bufnr() for loading buffers (see #503), and uses absolute paths instead of relative ones, for internal operations.

Closing, due to diversion.


react-components: robot panel

What's new
Robot Panel component based off from Task Panel

will be removing the refresh button

Self-checks

[x] I'm familiar with and follow this Typescript guideline
[x] I added unit-tests for new components
[ ] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

I'm still not sure how to use the api_server's implementation of task progress in react-components because what react-components use is technically just dummy data. should this be taken as a prop and only implemented in the dashboard?

~2. The original idea was to also have 'Est End Time' be a clock value in 12hour format, and likewise, I'm not sure how this can be done. using rosTimeToJs in lib/utils.ts?~

from the other pr:

oh okay!
other than the current tasks, is it possible to retrieve all assigned and active tasks? (completed/failed tasks are not needed). because there is an 'assigned tasks' section in the robot-info.tsx

oh I see, the information in robot state is not enough, I think disregard the above guide. Just use the task query api the find the list of assigned tasks for a robot. The new additions allow you to query by multiple robot/fleet/states so you should be able to get the required data.

I realised the robots endpoints will need more work to get the required info, so I think I will revert the api-server changes and work on it on another branch.

updated branch: dashboard/robot-page


Loading problem with API-BANK dataset on huggingface dataset -- ValueError: Couldn't cast

My solution is written below, but this can not load the level-3 test dataset , I hope the author put forward a better method.
https://huggingface.co/datasets/liminghao1630/API-Bank/discussions/1

In fact, we only use huggingface to host the datasets, and do not support the use of the datasets library to load.

@Octobrist How did you load the remaining training and test dataset (excluding level-3 test) from Huggingface?
@liminghao1630 If huggingface isn't supported, then could you share the code to load training and test data from local files?


Fail to import MastodonClient

Hello everyone,
I work with Android Studio. I inserted maven {url "https://s01.oss.sonatype.org/content/repositories/snapshots/" } in settings.gradle/repositories, I see that the classes were added at the external libraries level, but the class MastodonClient (and others) is not recognized in my java code. And import social.bigbone.MastodonClient; gives an error. Of course I inserted implementation "social.bigbone:bigbone:2.0.0-SNAPSHOT" and implementation "social.bigbone:bigbone-rx:2.0.0-SNAPSHOT" in build.gradle (:app). Using dependencies is usually not a problem in my applications, but this time is a real headache. Do you have any clue that can solve this problem?
Thanks a lot for your help.

Hi Paul,
I'm working with Android Studio as well. My configuration is as follows.
In settings.gradle:
dependencyResolutionManagement {
    repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
    repositories {
        // ...
        maven {
            url "https://s01.oss.sonatype.org/content/repositories/snapshots/"
        }
    }
}

In build.gradle (:app):
dependencies {
    // ...
    implementation 'social.bigbone:bigbone:2.0.0-SNAPSHOT'
}

With this, I can access MastodonClient in both Java and Kotlin code as expected.

Hi bocops,
Thanks for answering. I did the same thing as you. "Sync Project with Gradle Files" works fine. I also see this library in the "External Libraries" section. But impossible to declare a mastodonClient in my MainActivity class. The class name remains in red. Also impossible to insert the import social.bigbone.MastodonClient statement. MastodonClient could not be found.
I've been working with Android Studio for several years, and this is the first time I've had so much difficulty using an imported class. I program in Java. Is there a problem with the fact that the classes in this library seem to be in Kotlin?
Thank you very much for trying to help me.

Hello Paul,
I am not really familiar with Android Studio, but what happens when you run a './gradlew build --refresh-dependencies' from your terminal in Android Studio? Does this help?

Is there a problem with the fact that the classes in this library seem to be in Kotlin?

My project using the library is in Kotlin, but I tested this by creating a Java class that imports and uses MastodonClient just fine.
If anything, I found Android Studio to be somewhat stubborn when dealing with SNAPSHOT dependencies like this one currently is. Refreshing your dependencies as @andregasser suggested would be my next step as well.

Hi André and bocops,
the 'gradlew build --refresh-dependencies' command worked fine:
BUILD SUCCESSFUL in 1m 45s
82 actionable tasks: 53 executed, 29 up-to-date
But the MastodonClient class is still in red, like all the other classes (Status, Range) used in the Get Home Timeline example described in the USAGE.md file.
I am a computer science teacher. I teach the development of Android applications with Android Studio, in which I integrate sending tweets and reading the Timeline of an authenticated user, with Twitter. I have been using Twitter for several years but with Mr. Musk's new rules, I can no longer, and I no longer want to, use it. I was introduced to Mastodon and I am very interested in integrating it into my course.
I'm trying as best I can to resolve this problem, but I don't see any logic in Android Studio not recognizing these classes. For example: error: cannot find symbol MastodonClient client;
Additionally, I activated auto import.
If you have other suggestions, I will gladly take them.
A huge thank you.

Hello Paul,
Sorry to hear that you're still having issues.  In parallel, I will have a look in Android Studio as well.
Thanks!

Hi André,
Here's a little project made with Android Studio Dolphin 2021.3.1.
MastodonTest.zip
Thank you very very much.

Hey Paul,
this is really weird. I'm seeing exactly what you describe after opening your example project. All BigBone classes show up with a "Cannot resolve symbol" in your MainActivity.java, with no way to import a class via Alt+Enter.
However, if I create a new class in your project and try to use MastodonClient there, everythings works as expected. In fact, if I just hit enter anywhere in your MainActivity.java, auto-import suggestions start popping up there as well. I have no idea what might cause this, but it seems to be an Android Studio problem rather than anything else(?).

Here's a little project made with Android Studio Dolphin 2021.3.1.

@PaulTrembla With Android Studio Giraffe 🦒 on macOS, I’m not facing issues with your project. 🤔 I checked out the project, opened MainActivity.java in your project, and could import all BigBone classes with ⌥+Enter

Good evening to all of you,
Something new on my side.
Following PattaFeuFeu's message, I installed Android Studio Giraffe and all the classes used from the BigBone library are now recognized. The imports are automatically inserted. Everything compiles perfectly.
You were right bocops, the problem seems to come from Android Studio.
I am now working on another problem. Executing the statement 'client = new MastodonClient.Builder(instanceHostname).accessToken(accessToken).build();' generates the following Exception:
'java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.mastodontest/com.example.mastodontest.MainActivity}: social.bigbone.api.exception.BigBoneRequestException: Unable to fetch instance version' .
The access token is the one I received when configuring my application on Mastodon, and my mastodon instance is botsin.space (the one used for my first contact with Mastodon).
As I'm new to Mastodon, I must surely be making a beginner's mistake. If you have a clue, I'll gladly take it.
Thank you to all of you.

Hello all,
As a first step, I have collected the nodeinfo information from botsin.space and the one from mastodon.social as a reference for comparison. When the BigBone client instance is built, we try to retrieve the instance version via nodeinfo first. If that fails, we fall back to a simple REST call to GET https://botsin.space/api/v2/instance and if that fails too, we fall back to GET https://botsin.space/api/v1/instance.
First, I have collected the published nodeinfo information from botsin.space. Here are the results:
Result from curl https://botsin.space/.well-known/nodeinfo:
{"links":[{"rel":"http://nodeinfo.diaspora.software/ns/schema/2.0","href":"https://botsin.space/nodeinfo/2.0"}]}

Result from curl https://botsin.space/nodeinfo/2.0:
{"version":"2.0","software":{"name":"mastodon","version":"4.1.9"},"protocols":["activitypub"],"services":{"outbound":[],"inbound":[]},"usage":{"users":{"total":8422,"activeMonth":2505,"activeHalfyear":3589},"localPosts":23654836},"openRegistrations":true,"metadata":{}}

I have also collected the same info for another instance, mastodon.social, as a reference / for comparison:
Result from curl https://mastodon.social/.well-known/nodeinfo:
{"links":[{"rel":"http://nodeinfo.diaspora.software/ns/schema/2.0","href":"https://mastodon.social/nodeinfo/2.0"}]}

Result from curl https://mastodon.social/nodeinfo/2.0:
{"version":"2.0","software":{"name":"mastodon","version":"4.2.1"},"protocols":["activitypub"],"services":{"outbound":[],"inbound":[]},"usage":{"users":{"total":1631518,"activeMonth":288540,"activeHalfyear":835788},"localPosts":70715030},"openRegistrations":true,"metadata":{}}

The error message that @PaulTrembla mentions, happens in the fallback code, where we try to retrieve the instance version via REST calls.
Here's the partial results of the REST API calls of instance botsin.space:
Result of GET https://botsin.space/api/v2/instance:
{"domain":"botsin.space","title":"botsin.space","version":"4.1.9", ...

Result of GET https://botsin.space/api/v1/instance:
{"uri":"botsin.space","title":"botsin.space","short_description":"A Mastodon instance for bots and bot allies.","description":"This instance is for bots and bot allies. Anyone can sign up to be a user here or run your bot here. Users agree to the Code of Conduct listed on the \u003ca href=\"/about/more\"\u003einformation page\u003c/a\u003e. You should also review the \u003ca href=\"/terms\"\u003eterms of service\u003c/a\u003e.\r\n\r\n","email":"colin@muffinlabs.com","version":"4.1.9", ...

Without digging deeper atm, I'd say that the version info published by the instance is correct. IMHO, the BigBone client builder should have parsed the nodeinfo correctly and not throw such an exception described by Paul at all (as the nodeinfo data is provided by the instance).
I just want to explicitly highlight here, that we need a working internet connection while we build the client instance, as we need to retrieve the instance version info.
I will have a closer look at this this evening if the issue should still be open by then.

Hello Paul,
Do you face the same issue when you run the following sample from our Java sample module?
sample-java/src/main/java/social/bigbone/sample/GetInstanceInfo.java
I ran it against botsin.space and did not get an expection but a proper Instance object printed on the terminal:
{
  "uri":"botsin.space",
  "title":"botsin.space",
  "short_description":"A Mastodon instance for bots and bot allies.",
  "description":"This instance is for bots and bot allies. Anyone can sign up to be a user here or run your bot here. Users agree to the Code of Conduct listed on the \u003ca href\u003d\"/about/more\"\u003einformation page\u003c/a\u003e. You should also review the \u003ca href\u003d\"/terms\"\u003eterms of service\u003c/a\u003e.\r\n\r\n",
<EMAIL_ADDRESS>  "version":"4.1.9",
  ...
}

I just tested by adapting one of our samples like so:
package social.bigbone.sample;

import social.bigbone.MastodonClient;
import social.bigbone.api.exception.BigBoneRequestException;

public class GetServerVersion {
    public static void main(final String[] args) throws BigBoneRequestException {
        final String instance = args[0];

        // Instantiate client
        final MastodonClient client = new MastodonClient.Builder(instance)
                .build();

        System.out.println(client.getInstanceVersion());
    }
}

This does return valid version information for botsin.space as well as for multiple other instances I tested. However, after shutting down internet connection, I get exactly the error pointed out by Paul, so @andregasser your suspicion about connectivity was right. :)
The stack trace points to the last line of MastodonClient.getInstanceVersion(), where the exception is thrown. I'm not sure if we should (or even can) check for connectivity ourselves, because that depends on the platform that the code happens to run on.

Thanks @bocops for reproducing this. 👍

The stack trace points to the last line of MastodonClient.getInstanceVersion(), where the exception is thrown. I'm not sure if we should (or even can) check for connectivity ourselves, because that depends on the platform that the code happens to run on.

Hm, honestly, I think checking for Internet connectivity is not the job of our library, but more the responsibility of the enclosing application. Just imaging what would happen if an app uses 10-15 libraries, each checking for Internet connectivity on its own.
What about this pragmatic "fix": We change the exception message for this case to something like this: Unable to fetch instance version. Please check internet connectivity.
@bocops As you are also working on an Android app (Altamira), what do you do in this case?
@PaulTrembla Can you confirm your code works, once Internet connectivity is available for your app?

As you are also working on an Android app (Altamira), what do you do in this case?

In my app, most of the work happens in background tasks that are simply restarted at a later time if they fail for any reason. For unrelated reasons, they are typically only started if the deviced detects an unmetered connection, which of course rules out most of those connectivity failure cases in the first place.
On top of that, all MastodonClient functionality is wrapped in try/catch blocks to either fall back to previously cached data where possible, or alert the user if necessary.

Hello all,
I tried getInstanceInfo.java as asked by André. The same Exception is always when instantiating the client.
I always work with a virtual device for my tests. I never have a problem with it, and its Internet access is ok.
I'm going to do some more testing later because I have to go to work. I live in Quebec, Canada where it is currently 7:30 am.
Thank you very much for your help.

Hi Paul,
Could you share a full stack trace of your app when the exception is thrown?
Are other apps that require Internet connectivity running fine in your emulator on that same machine?
Thx for checking!

I was just able to reproduce the described issue with just the code in the MainActivity and additional try-catch to get around Java’s complaining.
I ran it on an emulated API level 30 device:
FATAL EXCEPTION: main
Process: com.example.mastodontest, PID: 23583
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.mastodontest/com.example.mastodontest.MainActivity}: social.bigbone.api.exception.BigBoneRequestException: Unable to fetch instance version
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3449)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601)
	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7656)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: social.bigbone.api.exception.BigBoneRequestException: Unable to fetch instance version
	at social.bigbone.MastodonClient$Builder.getInstanceVersion(MastodonClient.kt:634)
	at social.bigbone.MastodonClient$Builder.build(MastodonClient.kt:705)
	at com.example.mastodontest.MainActivity.onCreate(MainActivity.java:22)
	at android.app.Activity.performCreate(Activity.java:8000)
	at android.app.Activity.performCreate(Activity.java:7984)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3422)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601)
	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7656)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

I’ll try to investigate what’s happening here now.

Found the issue: The sample project @PaulTrembla posted doesn’t take care of moving the network activity to the background thread so we get an android.os.NetworkOnMainThreadException exception.
BigBone unfortunately currently is very bad when it comes to exception handling: The chain is broken in many places and we do not propagate a caught exception so debugging was necessary to find out the root cause.
I will create an issue to ensure that we add caught exceptions to the new BigBone*Exceptions we throw.
For your problem @PaulTrembla:
You need to run the BigBone calls on a background thread. This can be done with RxJava (see bigbone-rx), in Kotlin with Coroutines, or basic Thread handling.
Here is a very simple example:
package com.example.mastodontest;

import android.os.Bundle;
import android.util.Log;

import androidx.appcompat.app.AppCompatActivity;

import social.bigbone.MastodonClient;
import social.bigbone.api.Pageable;
import social.bigbone.api.Range;
import social.bigbone.api.entity.Status;
import social.bigbone.api.exception.BigBoneRequestException;

public class MainActivity extends AppCompatActivity {
    String accessToken = "***myToken***";
    String instanceHostname = "botsin.space";

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        new Thread(() -> {
            try {
                MastodonClient client = new MastodonClient.Builder(instanceHostname).accessToken(accessToken).build();
                Pageable<Status> timeline = client.timelines().getHomeTimeline(new Range(null, null, 5)).execute();
                timeline.getPart().forEach(status -> {
                    System.out.println(status.getContent());
                });
            } catch (BigBoneRequestException e) {
                Log.d(MainActivity.class.getSimpleName(), "Could not get home timeline", e);
            }
        }).start();

    }
}

Hello everyone,
PattaFeuFeu is right. Since Android 3.0/Honeycomb/API 11, potentially long-running tasks, such as network access, must be handled in a separate thread (background thread).
This is what I teach my students, and we use it in the application that we build together. I didn't think about this possibility this time, because I didn't see the 'android.os.NetworkOnMainThreadException' at runtime.
I ran the application created with my students which allows, among other things, a user to authenticate with Twitter, and everything works as expected. To answer André's request, another application requiring Internet connectivity is indeed running normally in my emulator on the same machine.
I copied the entire PattaFeuFeu code, inserting my access token. Running the code in a Thread significantly reduced the stack trace. Included is the full stack trace generated during the last execution of the application.
But the problem still seems to be focused on:
'MastodonClient client = new MastodonClient.Builder(instanceHostname).accessToken(accessToken).build();' (line 25).
This project was also tested on a computer at work, with a colleague. Same Android Studio (Giraffe), same device with API 33, same result.
For information :
Android Gradle Plugin Version: 7.4.2
Gradle Version: 7.5
Thanks again for helping me.

@PaulTrembla For future issues, please try to paste code or stacktraces as text, not as screenshots as it makes reading, copying, and searching among other tasks way harder if it’s a photo. 😊
Learning to use the debugger and breakpoints is probably a good task to teach your students how to find issues in code written in languages that support a debugger.
I placed a breakpoint in line 654 of MastodonClient, so right here in the catch block:
https://github.com/andregasser/bigbone/blob/2e8392944f238a407286873c69bacf40fcc8c59a/bigbone/src/main/kotlin/social/bigbone/MastodonClient.kt#L653-L655
This yielded a security exception java.lang.SecurityException: Permission denied (missing INTERNET permission?) as you didn’t specify the INTERNET permission in AndroidManifest.xml.
Please add it to the Manifest so that the start of the file looks as follows:
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools">

    <uses-permission android:name="android.permission.INTERNET" />

    <application
     ...

I don’t have an access token on hand right now so I cannot test it all the way, but that gets me over the initial hurdle to even setup the MastodonClient.

In the application that I built with my students, it was not necessary to specify INTERNET permission because this permission was already specified in a library that I was using.
Again, it didn't occur to me to check this. Even if this permission is of the normal type (not dangerous), it must obviously still be specified.
Everything works perfectly now. I feel like it will be a pleasure to work with Mastodon and BigBone.
Thank you very much for your help, and especially for the time you spent.
You are experienced people and I have learned a lot from you.
Thank you also for your many advice. They are much appreciated.
Be well and take care of yourself.

Hello everyone involved,
Excellent troubleshooting job. Thanks to you all. I just want to quickly mention to @PaulTrembla , that I usually post news on Mastodon under the BigBone hashtag. so if you want to stay up-to-date on this project, I'd suggest that you follow this one. Also feel free to connect with us on Mastodon. We are all there:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Feel free to reach out to us again, when you run into trouble. The library is still under active development, so hickups may occur (especially now, as we're still working on a snapshot). Of course, we also like positive feedback in general :-) Have a great day!


FCNPC_OnTakeDamage dispatching 9 parameters.

When using sampgdk's OnPublicCall function, you will see that the parameter count equals 9 for the OnTakeDamage event instead of 5.
	if(name == "FCNPC_OnTakeDamage")
	{
		int count = params[0] / sizeof(cell);
		for (int i = 0; i < count; i++)
		{
			auto value = params[i + 1];
			sampgdk_logprintf("FCNPC_OnTakeDamage #%i value: %i", i, value);
		}
	}

output:
FCNPC_OnTakeDamage #0 value: 499                //NPC ID
FCNPC_OnTakeDamage #1 value: 0                    //IssuerID
FCNPC_OnTakeDamage #2 value: 29                  //WeaponID
FCNPC_OnTakeDamage #3 value: 9                    //Bodypart
FCNPC_OnTakeDamage #4 value:<PHONE_NUMBER>  //Health_loss Float Address
FCNPC_OnTakeDamage #5 value: 499
FCNPC_OnTakeDamage #6 value:<PHONE_NUMBER>
FCNPC_OnTakeDamage #7 value: 29
FCNPC_OnTakeDamage #8 value: 9

I can't reproduse this (FCNPC_OnTakeDamage is not called for me). Can you show more code?

There is no more code, you just have to shoot an NPC to dispatch this event, and apparently it has some kind of problem with the parameters. This is the only callback which has this strange behavior.


Add SDL_GetModState

This allows users to check if a lock key is locked - there is no way of telling from keyboard events alone
Potentially this could also be expanded to allow every modifier key to be checked, and to provide only a small wrapper around GetModState, if this isn't acceptable

Exposing SDL_GetModState is a good addition. I'm less sure about adding Veldrid.LockKey and Sdl2Window.IsKeyLocked. The latter two seem useful, but aren't logically tied to a window. They are global state queries. I'd rather leave those additions out and just have users call SDL_GetModState directly (or wrap it in something like NeoDemo's InputManager class).

Yeah that's a fair point - I was a bit iffy about it myself. I've removed that stuff from the MR, and left just the SDL_GetModState addition

LGTM. Thanks for the update.


Is this .NET only?

Hi Tim,
Cool project you got here - I'm interested, but our project is not using .NET. We're using a Node.js server with Apollo GraphQL on top. This approach currently only works on .NET correct?
Also - did you make any updates for this to be compatible with Github actions?
Thanks!

The tool needs dotnet to run, but it should work against against any graphql server. It compares SDL.


Tag new versions

Hi,
There are some Git tags for versions up to 0.3. Would it be possible to add also git tags for versions 0.4 and 0.5?
I tend to think this is clearer than branches to show where a particular version stopped, but more important I think it is really useful to have a single way to pinpoint versions (either tags or branches, but not a mix, as it confuses people).
Thanks!

oh, I'm not receiving subscriptions on new issues here - so sorry for the delay.
I've fixed this.

Thanks!


Help: Failed to load a static resource

Describe the issue / bug.
Followed the instructions and placed CSS theme files in the static assets directory. However upon build these files can't be found. Unclear how to proceed.
Path inside semantic.css
  url(themes/default/assets/fonts/icons.woff2) format('woff2'),
  url(themes/default/assets/fonts/icons.woff) format('woff'),
  url(themes/default/assets/fonts/icons.ttf) format('truetype'),

If visual, provide a screenshot.

Tell me about your development environment.

Node version: v6.9.1
NPM version: 3.10.8
vue-cli version: (if necessary)
Operating System: OSX

Is there any specific reason why aren't using npm for semantic.css? I'm guessing maybe you are using a specific theme so that would make sense. If not, then it would be better to use from npm and import through webpack.
The main reason the icons files are missing is because anything with the icons in the file path will be ignored. This is initially done so app/icons is ignored. For a quick fix, you can edit your config.js and remove icons from the building.ignore value. I'll be patching this up in a later release.

Ah I see, missed that ignore bit when I was modifying that file. I ended up using inline svgs for now. But i'll make the adjustment going fwd. Thanks.


should we avoid executing programs with errors?

While implementing #217 I found that dada run executes even if there are errors, which causes this program to enter an infinite loop:
async fn main() {
    i = 0
    while i < 1 {
        print(i).await
        $ # invalid syntax
        i += 1
    }
}

I think we should avoid running if we encounter any diagnostic with Severity::Error.
That can also happen for dada test and maybe on web playground?

Actually, it's my intent that we always run programs, even with errors. Part of the goal of the compiler is to be able to always generate something a user can run.

However, if we encounter invalid syntax, or other super painful errors, we could have the program abort when it reaches that point in execution.


Add support for proof by computation

For more details see  source/docs/manual/proof_by_computation.md

I'd rather we didn't introduce synchronization when it's not strictly necessary. https://github.com/secure-foundations/verus/pull/276 replaces the Mutex and RwLock with Send alternatives.

I'd appreciate if you squashed the commits; it makes keeping track of the review changes easier.

I'd appreciate if you squashed the commits; it makes keeping track of the review changes easier.

Ah, I was talking about your commits (before the review). But it's probably fine. Please squash when merging, though.


change the way the lcz_band is choosen

This is addressing #45

This update changes the way the LCZ BAND that is used from the tif is chosen:

it automatically checks whether it is a LCZ Generator map -> LCZ_BAND = 1
if no argument is provided, LCZ_BAND = 0 (Default)
else it is LCZ_BAND = args integer
if an inappropriate LCZ_BAND is set, the system exits, with error message:

I have tested these changes with LCZ maps from different sources (LCZ Generator, WUDAPT, user). All seem to work.
In addition, I also:

update the JOSS paper to reflect this
added a color for WARNING prints
change the main lines of prints to terminal to bold, to make the different sections more clear.

Output in terminal now looks like this.

if all is fine with the above, I guess we can ship a new version and release it on pypi as well?

@theendlessriver13 is the logic clear what I want to do here? If so, do you feel like addressing the sections you commented on?

Sure I can try to finish this up!

Thanks for improving my changes @theendlessriver13. I think this is ready to be merged now?


[core] add query kwarg for HttpRequest

putting on the backburner, will address elsewhere

have addressed in azure.core.rest, not tagging as azure.core to avoid confusion with GA azure.core


Publish 7.2-20210729011708+0000

Publish 7.2-20210729011708+0000

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Fixes a typo

Welcome to the community and congratulations on your first PR merged! Keep them coming friend! This is great work.


Put back React Native

Probably in /screens dir
Rethink (again) universal UI library. Common base components I have, or reactxp, or react-native-web? I don't know yet. What is the most pragmatic? Update: react-native-web.

https://github.com/zeit/next.js/issues/3018

Hmm, it seems we can not have one shared / unversal package.json anymore. React Native Flow settings etc. So, it seems, we have to have two separated projects.

Hmm, also React Native seems to be unable to import file outside of /native directory.

So I don't know how to share code across Next.js and React Native without two package.json files and some symlinks. One package.json file would be ideal, but it seems to be impossible as well.

How ReactXP solves it? Hmm https://github.com/Microsoft/reactxp/tree/master/samples/TodoList

How about a lerna mono repo? Separate package.json files might sometimes be useful e.g, if independent parts of native/web need different version of the same package. Or if someone only works on parts of the project etc.

React Native should be able to import external components. I had a working proof-of-concept based on the old Este and RNWeb in may last year: https://github.com/msand/este/commit/9ad28699233f1ab48a0d4e448a9a5db6603a2619

I just remembered, I used a universal project with Next.js and React Native to compare and fix svg spec conformance of react-native-svg. I just updated the versions and made sure it still starts: https://github.com/msand/newproject

@msand Thank you. But it's without .flowconfig.

Ah yeah, that's probably true, didn't test that.

I fixed it. Thank you for your help.

Great! Looking forward to the Next (pun intended) version 😄


help me plz..

I forked this rp.. and, renamed "myname.github.io"
but this error was occurred " Your site is having problems building: Page build failed. For more information, see https://help.github.com/articles/troubleshooting-github-pages-builds/."
..plz...

Hi,
thanks for reporting,
Yeah somehow github pages configuration got lost when I switched to Gitlab.
I can't looking into this right in these days, but as soon as I can I will, in the meanwhile you could try it on gitlab, just forking it there,
Best

I found error reason..
because of Facebook api  and comment << so I resolved this error and I applied your best theme at my GitHub IO page
thank you very much ~!!

Oh very nice, could you please key me know where is the error? What made it works? So I can fix it. Thanks for helping out to make it better!

um..
I want to apply Facebook comment, but if I apply Facebook publish_id at config_yml, GitHub page occur this error( "Liquid Exception: no implicit conversion of Array into String in /_layouts/post.html
Fatal: TypeError
no implicit conversion of Array into String")
but <IP_ADDRESS> does not occurred this error ; so I do not know why this error was occurred
do you know this error ?..

In your code:
publisher_id: [160960154506650]
Should be:
publisher_id:<PHONE_NUMBER>06650
This only won't enable the comments, there's cleaning of the voice needed here eheh my mistake.
To enable the comments, the FB SDK must be loaded at the beginning and currently (wrongly) this is done so only specifying the app_id (have a look at _layouts/default.html)
The app_id is the id of the Facebook application (you must create one), but for the comments only it is not needed, so you can remove it from the SDK loading querystring in _layout/default.html , and you can remove the conditional as well.
The line:
js.src = "//connect.facebook.net/{{ page-lang-country }}/sdk.js#xfbml=1&version=v2.10&appId={{ site.facebook.app_id }}";
Becomes:
  js.src = "//connect.facebook.net/{{ page-lang-country }}/sdk.js#xfbml=1&version=v2.10";

For more info about fb comments plugin: https://developers.facebook.com/docs/plugins/comments
Let me know if it works!

Thank you for your help
I visited Facebook developer comments plugin and I got my app code.
and I changed my code, published_id : [19~~] -> published_id : myappcode ,
but this error was occurred !!! ㅠㅠ.. however  I resolved this error.

I changed your app code to my app code
I changed js src and div tag (Facebook comments)
I excepted published_id and enabled app_id
facebook comments.html (include) -> {% if site.facebook.published_id %} ->  {% if site.facebook.app_id %}

thank you~~~

I see it is now working :) I amglad you made it!
If you also want the Like/Share button to appear, modify also the conditional in the file _includes/facebook-like-post.html in the same way: {% if site.facebook.published_id %} -> {% if site.facebook.app_id %}

thank you very much !!!!!
you are very very kind..


Weak bandaid to stop noteskin changes from crashing in music select

Pull request made for the purpose of code review; not likely final.
All this does is stop the crashing you get if you change noteskins with an existing (visible or not) notefield. This will not change your noteskin unless you deliberately force the notefield to regenerate.

at this point its better to fix the source of the issue (hacky implementation of the feature) than bandaid all the peripheral issues it causes


Pan/Tild Cam support?

Hey there ;-)
do you think it would be possible to add a SwitchBot Pan/Tild Cam support? Of course i´m willing to debug again ;-)
greets

Hey @BangerTech just closing the issue for now. Can be reopened if more info is provided and/or if someone can confirm cameras support some BLE functions


<IP_ADDRESS> not published on NuGet?

It appears that <IP_ADDRESS> has not actually been published on NuGet despite a link to it on the release notes?

Was wonderring the same.

Trying something new here and tagging the build and then releasing the tag. Doing some last minute testing. Hope to get it out today. You folks are too fast for me 😄

Just pushed this up to nuget.org! Just needs a few minutes to propagate around the globe... Or if you are a flat-earther... to reach the Ice Wall that all the governments are hiding from us!


add osrm-backend

osrm-backend, which uses vtzero, serves Mapbox Vector tiles.

Tile - Generates Mapbox Vector Tiles with internal routing metadata

🚀🚀🚀


Move the plugin action execution to a bounded elastic thread pool

This is to ensure that any plugin written in the future doesn't cause the Appsmith platform to block. Currently, each plugin has to ensure that it's non-blocking and make appropriate adjustments.
We can simplify this flow for plugin developers by moving the action execution call in the Appsmith platform to a separate thread pool and ensure that the main platform is not blocked.

Unassigning myself since we had decided not to pursue this approach due to performance reasons. We'll take a look at this again if we see degradation in performance for plugins.


Add requirements to sandbox/ list --

directly executable script names should be all lowercase (no CamelCase), and use '-' instead of '_'.

See http://khmer.readthedocs.org/en/latest/dev/scripts-and-sandbox.html for current; source file is in doc/dev/scripts-and-sandbox.txt.

@ctb does it mean "only" renaming the scripts in sandbox/ to be all in lowercase?

I think they are all in lowercase, but they should use '-' instead of '_' as well in the filename.

working on this

@mr-c could it be that this can be closed?  All sandbox-scripts are in lowercase and use '-' and sandbox/README.rst also looks OK and up to date.  Is there anything else to do?

@ahaerpfer Good catch, thanks!


Live reload

The grunt config has livereload set to True, but when I open previews.html and make a change this does not reload the templates.
is there extra configuration needed?

Thanks for the heads up @viperfx. I just pushed up a fix. previews.html should now reload each time you make a change to a template. You might need to wait a few seconds before the page reloads because grunt needs to finish compiling the templates though.
I also updated livereload's default port to 3000. If you want to change the port you'll need to update the grunt task and the script tag in previews.html.


Refactored FileReader and supporting classes to enable direct reading of mixed-binary files.

New Features

Added support for mixed-binary files to FileReader class, using existing MixedLogReader helper class

This provides efficient read support without the need to extract FusionEngine data to a separate file when the input file also contains non-FusionEngine content

Added rewind support to MixedLogReader class
Added str() and == operators to TimeRange class
Added arithmetic operators to Timestamp class
Added ExtendedBooleanAction class, with similar argument support to TriStateBooleanAction, but enforcing True/False
Added optional $ suffix for log search patterns (e.g., p1_display.py 1234$ matches 1234/ but not 1234abcd/)

Changes

Changed TimeRange end value to exclusive, consistent with Python slice() syntax
Redefined TimeRange to consider only P1 times when checking time boundaries

Messages that do not contain P1 time will be considered in-range only when other P1-containing messages have been tested

Don't extract FusionEngine content from mixed-binary files by default in locate_log() helper function (no longer necessary)
Renamed MixedLogReader.filter_in_place() function (previously filter_inplace())
Allow MixedLogReader index generation enable/disable to be controlled after construction
Continue reading where we left off if the MixedLogReader filter criteria is changed part-way into a file read
Improved unit testing for TimeRange, MixedLogReader, and FileReader

Fixes

Fixed MixedLogReader message type filtering if no previous types were specified
Fixed FileIndex P1 time t0 value if the log does not contain any P1-timestamped messages
Fixed FileIndex attribute query if the index is empty
Fixed line numbers in trace-level debug prints
Fixed incorrect bool test in find_first() helper function causing element 0 to fail unexpectedly
Fixed missing data copies in FileIndex time slicing

Regarding C++, we could maybe do something with cython or ctypes to optimize stuff somewhat or possibly link the C++ library in, rather than doing stuff in pure Python. That would definitely need to be an optional feature though. I don't think want to make compiling and linking in C++ code, or even having a C++ compiler present, a strict requirement on these tools.
I do think we could probably simplify the FileReader class as you suggest even without introducing C++, however. Right now, some of the complexity comes from trying to generate the index in the same pass as the first data read, and also supporting reading without an index. We could make indexing a prereq, even if we still generate the index with Python MixedLogReader code instead of C++. Then, FileReader could assume there is an index and some of the max_messages support logic could go away since it would always be done inside MixedLogReader, vs right now where that is true only if the index exists. The only negative to that is it would require generating the index during the FileReader constructor and open(), so that would be quite slow to return. Either that or we delay populating the t0 members until the first read. That would require changes in p1_display, etc. though.
Even without more changes though, switching FileReader to use MixedLogReader under the hood in this PR does at least simplify stuff greatly. The max_messages stuff is only complicated now because of the possibility of not having an index, and the complication isn't too terrible anymore, at least not as bad as it was before.
Side note: I think we should maybe rename FileReader to disambiguate with MixedLogReader. I'm thinking:

Rename FileReader to DataLoader or something? Suggestions?
Rename file_reader.py too, but maybe leave file_reader.py and have an alias class FileReader for backwards compatibility? Not sure if that's necessary in practice. Maybe not advisable.
Move file_index.py into parsers/ along with MixedLogReader.

What do you think?

My C++ suggestion was mostly to try to address the reason (the possibly increased processing time) that we don't always want to just run the indexing first as a separate operation.
I think long term I would suggest the following changes:

Always use/generate an index.
The index has a metadata file with: start/stop times and possibly a file checksum. If those are changed, then the index is regenerated.
The whole reader FileReader and all the processing that cares about the content of the messages is done using the index. This lets it process the data with random access, and not needing to constantly check start/end times.

Ideally, we could focus on making the index generation as efficient as possible, but that's a separate task.
As for your 1-3 points at the end:

Yeah DataLoader seems reasonable.
I'm not a fan of aliasing like this unless there's a strong immediate reason, so I would just rename and move.
Sounds good.


🐞 [Bug]: Orchestrators page cards are not responsive

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
k8s and caprover cars are not responsive
Steps To Reproduce
No response
which network/s did you face the problem on?
Dev
version
2.5
Twin ID/s
No response
Node ID/s
No response
Farm ID/s
No response
Contract ID/s
No response
Relevant screenshots/screen records

Relevant log output
.

Verified, Dev
version: 6f39878
https://github.com/threefoldtech/tfgrid-sdk-ts/assets/32517137/1cd06b67-b4c7-4586-91ae-2502c8f8395b

verified on devnet
version: db2daf4
orchestros cards are now responsive and the text is displayed fine.


WebRTC server

This is really a feature-request/suggestion of something I'm in the process of completion. I am going to be realeasing a separate project which allows to talk to the online2-tcp-nnet3-decode-faster directly from the browser using WebRTC. Kinda like what you can do with Google Speech in Chrome, but for Kaldi.
Now, I'll do my project anyway (as a demo for people that wish to integrate Kaldi into their projects without using Python), but seeing that my WebRTC server is written in Python, using the excellent aiortc library, I think it would make a lot of sense to integrate it directly with pykaldi.
I'd be glad to do a PR, but I wanted to ask here, how would you prefer to do this? Would you like to see it in an already existing directory (eg. examples) or would you prefer a new one? Or maybe you'd like to have a completely separate repo for that?
Also, do you plan to do online recognition from the microphone using some other Python GUI? Did you consider adding some kind of scripts that would download pre-trained models from the Kaldi website, to show off the project?

Hey @danijel3. This sounds like an awesome project! We would be happy to support it as part of pykaldi or as a separate project, however you see fit!

I'd be glad to do a PR, but I wanted to ask here, how would you prefer to do this? Would you like to see it in an already existing directory (eg. examples) or would you prefer a new one? Or maybe you'd like to have a completely separate repo for that?

If we are going to add it to pykaldi repository, putting it inside the examples directory would be best. I am guessing your webrtc server will have additional package dependencies. We prefer to put such things inside the examples directory to avoid introducing new dependencies for pykaldi. I think it would make more sense to have this project as a separate repository especially if there is a good amount of code in it. It is your call really. If you would like to have it in a separate repository, we can also put it under pykaldi organization on github, such as https://github.com/pykaldi/webrtc-server.

Also, do you plan to do online recognition from the microphone using some other Python GUI?

I would like to do this but I have limited amount of time to work on pykaldi so I don't know if I will get to doing this any time soon. If you would like to do something like that, I would be more than happy to help though.

Did you consider adding some kind of scripts that would download pre-trained models from the Kaldi website, to show off the project?

I did consider this but left it for later due to time constraints. I recently updated the example code we have in the README, which should be more or less drop in for pre-trained aspire chain models. Again, if you would like to work on this, I would be more than happy to help.

Cool. It'd be my pleasure to contribute here. A separate repo is not needed. The extra requirements are not that terrible and storing it in the example dir will be perfect.
I suggest we leave this issue open for now until I make a PR. and then we can link it there.

If you have a project that you would like to get featured on the main README page, then please get in touch!


Develop

Coverage decreased (-1.02%) to 98.98% when pulling dc1199b3fdfda86cd88f75ea73593260e9630088 on develop into 821955d1fa00025a564cb4e2b7d369cd90c32a2f on master.


:tada: Initial restructuring and refactoring

Hi!
First of all, thanks for making this repository available. Very useful.
I'm not sure you really want this PR, since it's pretty big and quite opiniated. My goal with this is to incorporate the functionality in https://github.com/xecrets/xecrets-cli, and then into a GUI frontend called Xecrets Ez (see https://www.axantum.com/). I've restructured and refactored quite a lot, and added some functionality as well as documentation. Your core code is essentially the same though, although there are lots of minor refactoring edits there too.
This is an initial effort to expose the functionality that I think I need in a way I think will be easy to consume. I've also prepared for publishing as a nuget package, and there's a sample command line app available both to illustrate how to use the code, but it may also be useful in it's own right.
Since I've really changed quite a lot, I understand if you don't want to maintain this code instead of the original, but I thought I'd at least check with you.
As the focus has been on my needs, although I've tried not to specialize away any functionality, I fully understand if this does not align with your vision of the future of your code.
I'm available via mail or any number of messaging services if you'd like to discuss ways forward in more detail.
Regards,
Svante

Hi Svante, thanks for sharing this with me!
There’s so much great work in this PR from the CLI—features I’d love to use, along with more organized unit tests, corrections, comments, and more. However, the goal of this repo is to provide a reference implementation that allows other developers to adapt solutions in their own style and according to their specific needs.
To be honest, I think I may have unconsciously designed it with my own requirements in mind. As I develop a Bitcoin wallet, I try to limit third-party dependencies (no NuGet packages except for Microsoft’s, Avalonia, and NBitcoin).
I think are many how could be interested in using your code/package, in fact I would like to use parts of in once I start implementing slip39 in Wasabi Wallet. But I want to have a tiny project with 2 .cs files in this repository.
I hope you understand my reasoning and motivation. So please continue improving the library in your https://github.com/xecrets/xecrets-slip39 repo. Also, I am pretty sure SatoshiLab (ping @andrewkozlik) could be interested in your work too and list it among the implementations available.

Hi!
I fully understand, and as I wrote, I wasn't sure you'd want to pull this ;-) It sort of got away from myself, my original goal was to just use your code pretty much as is, but then I started fixing one minor issue, then another, and suddenly it was in the state you see it now... I'm pretty happy with it though, as I said it's quite opinionated according to how I personally think this type of library should be organized and built for public consumption as a general purpose library - but that's just me!
Concerning nuget-packages... I did add DefaultDocumentation to the library project, but it does not add any code, it is only a build-time dependency that creates markdown documentation from XML documentation in the source. Just to be clear on that point.
Since the implementations differ so greatly that it's really hard to see where my version of the code is coming from in your code, maybe I should detach the fork and have it as a stand-alone repository in it's own right? I might also in the future rename the project, among other things to distinguish it on nuget.org, add some other things such as not-so-freely keeping secrets in memory unprotected etc., thus drifting even further from your code.
Obviously license and attributions will remain even if the fork is detached.
What are your thoughts on this?

What are your thoughts on this?

Yes, I think you are right in all your points.

FYI and also @andrewkozlik I've now released a detached fork of this repo at https://github.com/xecrets/xecrets-slip39 . There's also a nuget package available at https://www.nuget.org/packages/Xecrets.Slip39 and finally a fully-featured command line utility exposing all functionality of the library at https://github.com/xecrets/xecrets-cli . The detached repo contains all in this PR as well as some other improvements and fixes. It would be nice if it got listed as an implementation generally available for .NET.

GitHub link added to SLIP-39, see https://github.com/satoshilabs/slips/blob/master/slip-0039.md#other-implementations.


[Question] Roadmap/When does this mod leave alpha

Checks

[X] I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting.
[X] I confirm that I noted that if I don't follow the instructions, the issue may be closed directly.

Description
I've used the mod and it seems feature-complete, so why is it still in alpha? Is there a roadmap or list of planned features somewhere?
Thank you for making the mod.

Hello, thank you for supporting MCDC.
The current alpha state of MCDC is the alpha state of MCDC v2. MCDC v2 has rewritten all the code of the stable v1, which generated many bugs, and they are being fixed gradually. MCDC v1 is no longer maintained, so it is unstable and no longer available.
The current MCDC v2 has almost no bugs. It should be relatively stable now and has transformed into a functional update, which can be seen from the decrease in the amount of bug report issues now.
You can find the changelog of those older versions on the GitHub Releases page.
After resolving those enhancement issues listed here that have been in the TODO list since the beginning of v2 alpha, MCDC v2 will end the alpha state. Subsequently, the release interval will become very long.

Noted that others have no way of knowing my specific thoughts, so these issues will not accept PR.


fix(torii): avoid panic on fetch token URI fail

In some occasions, the token URI may not be fetched correctly. Since it's mostly use for metadata, a default metadata is used in this scenario.

Summary by CodeRabbit

Bug Fixes

Improved error handling for fetching token URIs, allowing the process to continue even if the token URI retrieval fails.
Enhanced logging to provide contextual information when errors occur, improving transparency for users.

Improvements

Adjusted logic to handle empty token URIs more gracefully, ensuring a smoother user experience when metadata is not available.

will wait feedback from @ponderingdemocritus on preview--c148789 before going ahead and merge.


Apply MUI theming to "Versions" and "Details" Screens

Description

Applies MUI theming to "Versions" and "Details" Screens
Model Versions List View - Before:

Model Versions List View - After:

Model Details Description Input - Before:

Model Details Description Input - After:

Model Details Properties Table - Before:

Model Details Properties Table - After:

How Has This Been Tested?

What's been changed:

Model Versions List View

"Register Version" Button - applied MUI hover color
Page container - updated to apply MUI border radius and drop shadow
Tabs - Fixed padding bug to center text within tab correctly
Search input - replaced existing search filter component with new FormFieldset component to apply MUI theming

Model Details View

Action buttons (i.e. "Edit", "Add Property") - applied MUI link styling to darken underline of link button when hovered
"Description" field - replaced with new FormFieldset component to apply MUI theming
Properties table - replaced Key / Value inputs with FormFieldset components to apply MUI theming
Action buttons: Updated border radius on hover to apply MUI theming

Merge criteria:

All the commits have been signed-off  (To pass the DCO check)

[x] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work.
[x] Code changes follow the kubeflow contribution guidelines.

If you have UI changes

[x] The developer has added tests or explained why testing cannot be added.
[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Verify that UI/UX changes conform the UX guidelines for Kubeflow.

/lgtm


[STATION] fix default qslmsg empty when duplicate station

hello,
fix copy eqsl_default_qslmsg when duplicate station
tested :

duplicate station with empty default qslmsg = ok
duplicate station with value on default qslmsg = ok
duplicate station with value on default qslmsg and change with new value = ok

Thank you, @abarrau - your Fix is working.
But we need that within the station_model, since it belongs to the station_profile.
I am already trying it to implement there.

But we need that within the station_model, since it belongs to the station_profile.
I am already trying it to implement there.

this function is used by js call on qso page for refresh qslmsg texteara, so this function is used

Tested :

create, update, copy station profil
update msgqsl from qso page

But we need that within the station_model, since it belongs to the station_profile.

@int2001, can i help about something ?
you prefered i put the get_options() on station model ?

i show you when finished. it's a little tricky and to complex to describe.

you're right. whoever putted that into autoload (tbh: I am not a friend of autoload). Thanks for the finding, will fix

close this (reported on 175)


Create Candidates page

Route: GET /candidates
Requirements:

Should display all approved applications sorted by position
Should allow admin user to approve or reject an application
When an application is rejected the admin will be given a text field to explain why the application was rejected and an email will be sent to the applicant informing them that they can re-submit their application if they fix the noted issue

Completed in<PHONE_NUMBER>50cb869f94ef33176c88598d9b709d


Added Extra Long Factorial

Description
Program for Extra Long Factorials like 60!, 100!etc.
Fixes #353
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] I have read the contribution guidelines before making this PR.
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented in my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (Language folder or any other readme instructed to)
[x] My changes generates no new warnings
[x] I have added tests that prove my fix is effective or that my feature works

@kaustubhgupta Please review this PR.

@kaustubhgupta  Sorry! It might get deleted by mistake. I have updated readme with these entries.

@kaustubhgupta seems like some merge conflicts have occurred !


updated boinc (7.6.22)

Thank you for the contribution. It was merged directly as a050b498f832f732f771158f9463d373890256b1 to keep commit history cleaner. Your contribution is still credited to you.


Fix makefile-install.include naming schema

At some point we changed to registry/vendor_platform:version naming scheme.
makefile-install.include wasn't updated to reflect this, which broke xrv9k (and maybe other platforms) which depend on this file for the install process as of current.
This PR simply changes the naming scheme (and variable names) in makefile-install.include to match the new naming scheme.
Tested with XRv9k to confirm it works.

thanks @kaelemc
good catch, I did change it originally, but not consistently =(


Mounting pole

Need to determine how to mount the sensor array, particularly as the pole will connect to the ground facing module at the base of the array and thus potentially affect sensors in that area.
Common poles seem to be about 3.3cm or 1.25" outer diameter. Weather stations are usually affixed to the main pole via a smaller pole.

Needs to potentially handle different mounting scenarios for terrestrial and ship use.
See also: #44

For land-based mounts:

Maximum pole diameter is 2"
Common pole diameter is 1.25"
Minimum pole diameter is 0.5"

For ships:

Maximum pole diameter: ?
Common diameter: ?
Minimum diameter: 1"

Also need to consider mobile tripod mounting (like you would mount a camera).

Mounting guide
Installation / placement guide
Another installation guide

source

INSTALL AWAY FROM HEAT & HUMIDITY SOURCES
DO NOT Place the sensor near localized heat sources like heaters, air conditioners, chimneys and exhaust vents. Install the sensor away from asphalt or concrete as these surfaces radiate heat from the sun. Also avoid installing the sensor near pools, spas, or other bodies of water as these water sources may affect the accuracy of the humidity.
INSTALL AWAY FROM SPRINKLER HEADS
DO NOT install the sensor where it will be directly sprayed by a sprinkler system, this will affect the rainfall measurement accuracy and may force water into the housing.
WIND & RAIN OBSTRUCTIONS
DO NOT mount the sensor with obstructions above it, as this will ensure proper rainfall measurement. Also consider a mounting location that has very little structures around the sensor, to ensure proper wind speed and direction measurements.
5 FT INSTALLATION HEIGHT
DO mount the sensor at least 5 feet off the ground (higher is better for accurate wind measurements) in an open area NO FURTHER than 330 feet (100 meters) from the display console. A typical installation would involve mounting the bracket to a secured length of 2 x 4 or 4 x 4 wood, 3/4" pole, etc. (not included)
LEVEL INSTALLATION
DO install the sensor as level as possible to ensure accurate rain and wind measurements. Use the bubble level on the top to ensure a level installation.
SOLAR CELL ORIENTATION
DO install the sensor onto the mounting bracket with the solar cell facing SOUTH.* This is important to ensure that the cell receives as much sun as possible, and also orients the wind direction properly. Install the sensor with the solar cell facing south* to properly orient the wind direction vane.
*In the Southern Hemisphere, solar cell should be facing NORTH.


Attempt to make font loading tests more stable

lso changes things to use setInterval() instead of setTimeout().
This should fix the checkFont() test that sometimes fails in Edge (see https://github.com/openlayers/openlayers/issues/7437#issue-272294985).

I ran the tests 5 times now, and the test in question did not fail a single time in Edge.


[SPARK-6633][SQL] Should be "Contains" instead of "EndsWith" when constructing sources.StringContains

Test build #29486 has started for   PR 5299 at commit c1ece4c.

Test build #29486 has finished for   PR 5299 at commit c1ece4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29486/
Test PASSed.

Thanks for catching this -- this means the unit test wasn't catching what it's supposed to. Do you mind take a look at the unit test to change that as well?

I'm going to merge this first, but it would be great if you can take a look at the unit tests. Thanks.

okay. i would check it later. thanks.


Unable to open URL due to DS_store files

I am getting following errors in my apache logs and on page gives 500 Internal Server error. Why is it creating DS_stores files?
    [Sun Apr 17 13:12:37 2016] [error] [client ::1] client denied by server configuration: /Applications/MAMP/htdocs/.DS_Store
    [Sun Apr 17 13:12:46 2016] [error] [client ::1] client denied by server configuration: /Applications/MAMP/htdocs/products/.DS_Store, referer: http://localhost/
    [Sun Apr 17 13:29:37 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/.DS_Store
    [Sun Apr 17 13:29:37 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/.DS_Store
    [Sun Apr 17 13:29:51 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/products/.DS_Store, referer: https://gdntrdlhyv.localtunnel.me/
    [Sun Apr 17 14:46:17 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/.DS_Store
    [Sun Apr 17 14:46:38 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/products/.DS_Store, referer: https://epvztmlgwo.localtunnel.me/
    [Sun Apr 17 14:48:48 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/.DS_Store
    [Sun Apr 17 14:48:48 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/.DS_Store
    [Sun Apr 17 14:48:56 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/products/.DS_Store, referer: https://grosjejjos.localtunnel.me/
    [Sun Apr 17 14:57:43 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/.DS_Store
    [Sun Apr 17 14:57:50 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/products/.DS_Store, referer: https://gpyzbdhwqk.localtunnel.me/
    [Sun Apr 17 15:13:49 2016] [error] [client <IP_ADDRESS>] client denied by server configuration: /Applications/MAMP/htdocs/.DS_Store

It isn't.


datagrid that is conditionally shown has labels set to 'undefined'

context:
for a datagrid within a panel, setting it to be conditionally displayed on a checkbox will display te label as "undefined" when it appears
expected behaviour: should show the proper label (correct behaviour exhibited by  ng-formio )

Will you please provide a JSON url of the form so that I can easily reproduce?

hi, the behaviour is exhibited on this form when rendered with ng2-formio
https://auicqnmuwlxvnoh.form.io/form1
(look for the 'undefined' fields when you click on the checkboxes)

@travist (is the above good enough for reproduction?)

Yep. Perfect. I am on it now and should have an update within the next day or so.

Should be fixed in RC15.


Navigation enhancement

Other links that are hidden in the navbar and footer need to be shown. Also, make the navbar responsive.

Fixed


Extraction issue on PEM certificates (Ubuntu 18.04)

Hello,
When I try to extract certificates from files, binwalk doesn't extract them.
I tried using binwalk with the python API (python2 and python3).
On my own computer, the extraction works with the python3 API and CLI command (installed via apt install -y binwalk) but not with the python2 API.
On a Ubuntu 18.04 docker, it does not work with python2, nor with python3.
I think this issue could be related to the issue #313.
Steps to reproduce
Go into an Ubuntu 18.04 docker :
sudo docker run -ti ubuntu:18.04 /bin/bash

Install binwalk :
apt update
apt install -y python wget unzip
wget https://github.com/ReFirmLabs/binwalk/archive/master.zip
unzip master.zip
cd binwalk-master && python setup.py install

Try to extract PEM certificate from a file containing certificates, for example /etc/ssl/cert/ca-certificates.crt :
binwalk -e /etc/ssl/cert/ca-certificates.crt

Thanks for your help.

Hello,
When I try to extract certificates from files, binwalk doesn't extract them.
I tried using binwalk with the python API (python2 and python3).
On my own computer, the extraction works with the python3 API and CLI command (installed via apt install -y binwalk) but not with the python2 API.
On a Ubuntu 18.04 docker, it does not work with python2, nor with python3.
I think this issue could be related to the issue #313.
Steps to reproduce
Go into an Ubuntu 18.04 docker :
sudo docker run -ti ubuntu:18.04 /bin/bash

Install binwalk :
apt update
apt install -y python wget unzip
wget https://github.com/ReFirmLabs/binwalk/archive/master.zip
unzip master.zip
cd binwalk-master && python setup.py install

Try to extract PEM certificate from a file containing certificates, for example /etc/ssl/cert/ca-certificates.crt :
binwalk -e /etc/ssl/cert/ca-certificates.crt

Thanks for your help.

Package manager provides old version of binwalk it's better to install it from sources
You should build it from sources with below commands.
# git clone https://github.com/ReFirmLabs/binwalk
# cd binwalk
# ./deps.sh
# if [ -e `which python` ]; then \
sudo python setup.py install; \
elif [ -e `which python3` ]; then \
sudo python3 setup.py install; \
fi

Binwalk supports identification of certificates and PEM files, but does not support extraction of those files. Generally speaking, binwalk doesn't support extraction of any files or data that are already reduced to their standard format (e.g., PEM files, ELF files, raw code, etc).
What you want to do is data carving, which binwalk can do, but that is not its primary purpose and there are better tools available for data carving. There was a fairly lengthy discussion on the subject of data carving vs extraction in issue #376.

Just updating this to point to the correct issue where carving was discussed: #367


Add CLI metrics and update notifications

Adds two somewhat unrelated features but they touch the same code so a single PR is easier[citation needed].
Metrics
We ask for permission the first time tracking would be done, so only when using a tool or when uploading for the first time. You can do --version and --help and that sort of stuff without being bothered.
Right now, the only reported metrics are

which tool was used, including whether --visualize-only or --collect-only were used, and which version was used
that a public upload was started.

insight doesn't have a facility to override the optOut value, so for running tests I've added a NO_INSIGHT=1 env variable that will make sure that metrics are not reported.
Questions:

[ ] Is there anything else we'd like to keep track of?
[ ] Need to get a GA tracking code from somewhere, this uses a stub.

Updates
This simply calls update-notifier, it supports a NO_UPDATE_NOTIFIER=1 env var out of the box for tests. Worth noting the defer: false option, which will log the update message when the tool starts, rather than when it ends. This seems like the better experience to me, because you might want to copy a file path or clinic upload command or something from the last few lines of the tool output.

Since these modules interact with third party services and only run in a CLI app, I'm not so sure how to go about testing them. We can't just easily mock them out and check that they were called because they run in a subprocess. Instead I've added some istanbul ignore comments here to get coverage checks to pass.

I think this is a good first start. I’ll relase asap.


Do not rely on object.offsetParent when the map is fixed to the top.

Fixes #639.
In some circumstances, the map can be fixed to the top but the page might have some scroll that we need to take into account. In these cases it's better not to use the object.offsetParent approach.
@xavijam what do you think?

As a bonus, I discovered an fixed this other bug.

@xavijam do you think we should fix this here too? Thanks!

Retest this please

retest this please

retest this please

@alonsogarciapablo, yes, we should fix there too.
About the PR en general, I love the idea (and the fix) but probably we should take care of GMaps too, shouldn't we?

Also, could we create a test trying this with a fixed or a relative map div?

@xavijam Thanks for your feedback! I've fixed it for GMaps and also uploaded a basic example that reproduces the issue.

yay, have you tested for old browsers (IE7-9)? Just to keep legacy compatibility :S.


Grafana can't send mail

Grafana needs additional setup in order to be able to send mail. Invitations don't go out.

fixed by https://github.com/mcci-catena/docker-ttn-dashboard/commit/c496789b3e316deb73b52c5c46e8b3ffa4000519


PDF text not being positioned when converted to HTML

I'm having trouble converting pdf's into html. Everything seems to work fine except the text is not positioned correctly on the page. It seems like all the text is being bunched together into a few span tags.
I've tried the following to no avail:

Tried converting different pdf's
Tried using using various versions of pdfminer.six (tried all three taged versions listed on github as well as the current pypi version)
Tried playing with the LAParams settings

I also received some encoding errors which i was able to get by by using switching from "from io import StringsIO" to "from Six import BytesIO".
Has anyone had any success in converting pdf's to html? If so would you mind sharing your configuration? I've attached a sample config code and html output file for reference:
`
from pdfminer.pdfinterp import PDFResourceManager, PDFPageInterpreter
from pdfminer.converter import HTMLConverter
from pdfminer.layout import LAParams
from pdfminer.pdfpage import PDFPage
from six import BytesIO
def convert_pdf_to_html(pdf_path, html_path):
"""Converts PDF to HTML file
ARGS:
pdf_path: full path of pdf file to convert to html
html_path: full path of html file containing extracted pdf data
"""
rsrcmgr = PDFResourceManager()
retstr = BytesIO()
codec = 'UTF-8'
laparams = LAParams()
device = HTMLConverter(rsrcmgr, retstr, codec=codec)

fp = open(pdf_path, 'rb')
interpreter = PDFPageInterpreter(rsrcmgr, device)
password = ""
maxpages = 0
caching = True
pagenos = set()
fstr = ''
for page in PDFPage.get_pages(fp, pagenos, maxpages=maxpages, password=password,
                              caching=caching, check_extractable=True):
    interpreter.process_page(page)
fstr = retstr.getvalue()

fp.close()
device.close()
retstr.close()

fstr = fstr.replace(b'\n', b"")
html_file = open(html_path, 'wb')
html_file.write(fstr)`

ice_dom.zip

I'm going to close this issue since I was able to use the subprocess module to call the command like so:
cmd = 'python -m pdf2txt -t html -o "{output}" "{input}"'.format(
    output=html_path,
    input=pdf_path
)

subprocess.run(cmd)


Added async_command to typer.Typer

From my comment in:
tiangolo#88
Allows command to be used with async.
Let me know if using *args, **kwargs is ok or if it needs to be typed. *args, **kwargs will be more maintainable. Further we could just make @app.command DETECT if it's attached to an async function, but that might be more challenging.

But shouldn't we allow other async runtimes other than asyncio? Not sure how that would work, though. Maybe adding anyio as an optional dependency.

@cauebs Certainly, I'm somewhat new to async runtimes so I just assumed that asyncio was the bultin and thus "only" one. We can use anyio.
For some reason when I do the method injection as I do in the issue it works. But this PR when I test it with the following test function gives me the following:
import typer
from asyncio import sleep

app=typer.Typer()

# The command we want to be accessible by both
# the async library and the CLI
@app.async_command()
async def foo():
    """Foo bar"""
    return await sleep(5)

if __name__=="__main__":
    app()

Traceback (most recent call last):
  File "/Users/ryanpeach/Documents/Workspace/typer/test.py", line 14, in <module>
    app()
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/main.py", line 241, in __call__
    return get_command(self)(*args, **kwargs)
  File "/Users/ryanpeach/Documents/Workspace/OnScale_Cloud_Manager_CLI/.venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/ryanpeach/Documents/Workspace/OnScale_Cloud_Manager_CLI/.venv/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/ryanpeach/Documents/Workspace/OnScale_Cloud_Manager_CLI/.venv/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/ryanpeach/Documents/Workspace/OnScale_Cloud_Manager_CLI/.venv/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/main.py", line 527, in wrapper
    return callback(**use_params)  # type: ignore
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/main.py", line 183, in sync_func
    return run(async_func(*_args, **_kwargs))
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/main.py", line 891, in run
    app()
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/main.py", line 241, in __call__
    return get_command(self)(*args, **kwargs)
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/main.py", line 266, in get_command
    click_command = get_command_from_info(typer_instance.registered_commands[0])
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/main.py", line 452, in get_command_from_info
    ) = get_params_convertors_ctx_param_name_from_function(command_info.callback)
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/main.py", line 428, in get_params_convertors_ctx_param_name_from_function
    parameters = get_params_from_function(callback)
  File "/Users/ryanpeach/Documents/Workspace/typer/typer/utils.py", line 10, in get_params_from_function
    signature = inspect.signature(func)
  File<EMAIL_ADDRESS>line 3111, in signature
    return Signature.from_callable(obj, follow_wrapped=follow_wrapped)
  File<EMAIL_ADDRESS>line 2860, in from_callable
    return _signature_from_callable(obj, sigcls=cls,
  File<EMAIL_ADDRESS>line 2259, in _signature_from_callable
    raise TypeError('{!r} is not a callable object'.format(obj))
TypeError: <coroutine object foo at 0x10e4e7240> is not a callable object
sys:1: RuntimeWarning: coroutine 'foo' was never awaited

Actually now that error isn't reproducing. My current version seems to work.

I don't think it is needed to extend the API with another function async_command. The original function command might be extended to detect whether a decorated function is async or not and change the strategy how to run it.


The GPU version will loop forever...

Is there any problem with the GPU version...?

What is the problem specifically? Give us more details about it.

It was tested on server GPU P100/Titan V. Newer generation gpu was not tested.


Remove or update is_safe_url?

This package currently has a copy of Django's is_safe_url in elevate.utils because older versions of Django have vulnerabilities. Upstream didn't record which versions of Django are vulnerable or which version of Django they took is_safe_url from, so we need to do the following:

Work out which version of Django is_safe_url was taken from
Find out which versions of Django are affected and if there are additional vulnerabilities with the current version
Either remove or update is_safe_url depending on what's what

So the version we have in this package is from Django 1.9, this fix was also backported to 1.7 and 1.8. Therefore we can remove django-elevent's copy of that is_safe_url without making applications unsafe.
This copy of is_safe_url is also out of sync with upstream: a fix for CVE-2017-7233 has been applied to all versions of Django that we currently support except 1.7. Therefore, I think this is a good time to remove Django 1.7 support too.

Nice sleuthing, Matt. I agree that this is a good time to remove Django 1.7 support and is_safe_url.


Make querybuilder thread safe

Hi,
At thetradedesk we have been using a fork of this project for over a year now, and one of the foundational changes we made was to introduce thread safety to the query builders in the API client. We found that this was the only part of the code base that wasn't compatible with concurrent callers of the same client.
There are 2 new object allocations per request (a new NameValueCollection, and the wrapping Query object). This change makes the singleton querybuilders thread safe, as each request gets it own query object.
Please let me know any thoughts. Since the development of this library has picked up in the past 12 months, we hope to slowly contribute out changes back upstream, for the benefit of all, and so that we do not need to maintain our own fork.

Codecov Report

Merging #142 into master will increase coverage by 0.01%.
The diff coverage is 78.91%.

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   71.59%   71.60%   +0.01%
==========================================
  Files         162      162
  Lines        2299     2300       +1
==========================================
+ Hits         1646     1647       +1
  Misses        653      653

Impacted Files
Coverage Δ

...abApiClient/Internal/Queries/BranchQueryBuilder.cs
0.00% <0.00%> (ø)

...itLabApiClient/Internal/Queries/JobQueryBuilder.cs
0.00% <0.00%> (ø)

...l/Queries/ProjectMergeRequestsNotesQueryBuilder.cs
0.00% <0.00%> (ø)

...bApiClient/Internal/Queries/ReleaseQueryBuilder.cs
100.00% <ø> (ø)

...itLabApiClient/Internal/Queries/TagQueryBuilder.cs
0.00% <0.00%> (ø)

src/GitLabApiClient/PipelineClient.cs
24.00% <ø> (ø)

...abApiClient/Internal/Queries/CommitQueryBuilder.cs
62.50% <14.28%> (ø)

...ent/Internal/Queries/CommitStatusesQueryBuilder.cs
70.00% <25.00%> (ø)

...ent/Internal/Queries/GroupsProjectsQueryBuilder.cs
67.27% <53.33%> (ø)

...ternal/Queries/ProjectMergeRequestsQueryBuilder.cs
62.50% <66.66%> (ø)

... and 13 more

Removed changes to src/GitLabApiClient/Internal/Http/GitlabApiRequestor.cs- those were to enable some DI based trace logging, which is for another day.

Any thoughts on the changes?

Haven't had a chance to review 😅


Fresh start and new build chain

Pulled the clean slate and build chain changes out of the prerelease-v3.0.0 branch for easier comparison.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a5d215d). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             master   #91   +/-   ##
======================================
  Coverage          ?    0%
======================================
  Files             ?     1
  Lines             ?   203
  Branches          ?    36
======================================
  Hits              ?     0
  Misses            ?   167
  Partials          ?    36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d215d...cfd4ae9. Read the comment docs.


BetterTransformer.transform fails for OPT variants of BLIP2

System Info
Package version: optimum 1.11.0
System: Google Colab (Linux-5.15.109+-x86_64-with-glibc2.35)
Python version:  3.10.12

transformers-cli env info:

- `transformers` version: 4.31.0
- Platform: Linux-5.15.109+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.2
- Accelerate version: 0.21.0
- Accelerate config: 	not found
- PyTorch version (GPU?): 2.0.1+cu118 (False)
- Tensorflow version (GPU?): 2.12.0 (False)
- Flax version (CPU?/GPU?/TPU?): 0.7.1 (cpu)
- Jax version: 0.4.14
- JaxLib version: 0.4.14
- Using GPU in script?: No
- Using distributed or parallel set-up in script?: No

### Who can help?

@younesbelkada

### Information

- [ ] The official example scripts
- [ ] My own modified scripts

### Tasks

- [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)

### Reproduction

BLIP2 conversion seems to fail for OPT based checkpoints.

1. Load Transformers model

from transformers import Blip2ForConditionalGeneration
model_hf = Blip2ForConditionalGeneration.from_pretrained("Salesforce/blip2-opt-2.7b")

2. Attempt to convert using BetterTransformer `transform` method.

from optimum.bettertransformer import BetterTransformer
model = BetterTransformer.transform(model_hf)

Raises the following exception:

Exception                                 Traceback (most recent call last)
 in <cell line: 3>()
1 from optimum.bettertransformer import BetterTransformer
2
----> 3 model = BetterTransformer.transform(model_hf)
2 frames
/usr/lib/python3.10/contextlib.py in inner(*args, **kwds)
77         def inner(*args, **kwds):
78             with self._recreate_cm():
---> 79                 return func(*args, **kwds)
80         return inner
81
/usr/local/lib/python3.10/dist-packages/optimum/bettertransformer/transformation.py in transform(model, keep_original_model, max_memory, offload_dir, **kwargs)
264
265         if BetterTransformerManager.requires_nested_tensor(model_fast.config.model_type):
--> 266             set_last_layer(model_fast)
267
268         # Add a class arguments, we might need to identify whether the model
/usr/local/lib/python3.10/dist-packages/optimum/bettertransformer/transformation.py in set_last_layer(model)
164                 return
165
--> 166     raise Exception(
167         f"The transformation of the model {model.class.name} to BetterTransformer failed while it should not. Please fill"
168         " a bug report or open a PR to support this model at https://github.com/huggingface/optimum/"
Exception: The transformation of the model Blip2ForConditionalGeneration to BetterTransformer failed while it should not. Please fill a bug report or open a PR to support this model at https://github.com/huggingface/optimum/

### Expected behavior

I am unsure if all variants of BLIP2 are supposed to be supported. It is included in the list of supported models [here](https://huggingface.co/docs/optimum/bettertransformer/overview#supported-models) but possibly this is only intended to cover FLAN.

I haven't looked into the Optimum source code super closely, but it seems that BLIP2 assumes FLAN in the model mapping [here](https://github.com/huggingface/optimum/blob/94bf76698638e8a5ef48392e5951375d09e72183/optimum/bettertransformer/models/__init__.py#L62C12-L62C12).

Thank you for the report @davanstrien, I can have a look! cc @baskrahmer as I think you added it.

This script should reproduce the error:

This script should reproduce the error:
from transformers import Blip2ForConditionalGeneration
from optimum.bettertransformer import BetterTransformer

model_hf = Blip2ForConditionalGeneration.from_pretrained("Salesforce/blip2-opt-2.7b")
model = BetterTransformer.transform(model_hf)

I have no hardware available right now to run a model this large, but based on the code I think @davanstrien is right that my implementation only covers the FlanT5 backend. If a Blip2 model with the OPT backend could be added to hf-internal-testing, then I can try to support it.
Code-wise you probably need to add {"OPTAttention": OPTAttentionLayerBetterTransformer} to this dict entry.

Got the same issue, after added {"OPTAttention": OPTAttentionLayerBetterTransformer} to the dict as specified by @baskrahmer still got the same error...
The transformation of the model Blip2ForConditionalGeneration to BetterTransformer failed while it should not. Please fill a bug report or open a PR to support this model at https://github.com/huggingface/optimum/

Part of the code I was using for loading & performing mdel transform:
model = Blip2ForConditionalGeneration.from_pretrained(
                local_model_path,
                torch_dtype=torch.float16 if cpu_only is False else torch.float32,
            )
if cpu_only is True:
                model = BetterTransformer.transform(model, keep_original_model=True)

@fengzhyuan see https://github.com/huggingface/optimum/pull/1488 for a working fix.


⚠ St. Lawrence Global Observatory CKAN has degraded performance

In e97ad42, St. Lawrence Global Observatory CKAN (https://catalogue.ogsl.ca/en/) experienced degraded performance:

HTTP code: 200
Response time: 5056 ms

Resolved: St. Lawrence Global Observatory CKAN performance has improved in 6f2de0f after 8 minutes.


Fixed SF Regigigas Lv X 100

Energies should no longer attempt to be attached to a KO'ed self.

 REGIGIGAS_LV_X_100

Personally I'd prefer links to rulings rather than just a text comment with no reference. Unless the code is doing something that needs to be explained to grok it easier, it's best that you don't leave a comment that could leave someone asking "Okay, but why?" (although the older compendium pages do make it more difficult, in this case you'd use https://compendium.pokegym.net/compendium-lvx.html#314 )
But, this is just a nitpick.


SPIKE: Investigate AWS Quotas

Describe the issue
Look into any AWS quotas that we are likely to hit in the near term and identify alerts that could be created.
Which Sprint Priority is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonomously with 'Sprint'.

The 'Milestone' overview/description (created in ZenHub) should clearly list Sprint Priorities/Goals. This section should indicate which of the priorities/goals this issue is related to.
Additional context

timeboxed to 1 story point.
Several load balancer quotas will likely be an issue

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-limits.html

Definition of done

Ticket created documenting quotas that should be changed and what they should be changed to.
Ticket created documenting alerts that should be created.

No longer relevant


1F Open Area name shows up in json as Lockers/CCTV

Describe the bug
1st floor Open Area site name on Bank is detected as Lockers/CCTV (only played once, so I don't know if it is a one off)
It seems like just the name is but I am not sure. All other sites are fine
To Reproduce
Steps to reproduce the behavior:
Play a round on Open area
Expected behavior
A clear and concise description of what you expected to happen.
Open area would be detected as 1F Staff Room, 1F Open Area
Additional context
This was in a custom game if that makes any difference

Can you send the log with the debug flag (-d)? I will see if I can replicate it

i think sites have since been fixed. if you find another case, please send a replay file


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://github.com/ValdikSS/GoodbyeDPI/releases
Publisher: ValdikSS
Package Name: GoodbyeDPI
Description: Deep Packet Inspection circumvention utility
Package Version: 0.2.2
Installer URL: https://github.com/ValdikSS/GoodbyeDPI/releases/download/0.2.2/goodbyedpi-0.2.2.zip

The package is only available by manually double-clicking the symbolic link in %LOCALAPPDATA%\Microsoft\WinGet\Links\goodbyedpi.exe.
This may fail in the Validation Pipeline ...

The package is only available by manually double-clicking the symbolic link in %LOCALAPPDATA%\Microsoft\WinGet\Links\goodbyedpi.exe.
This may fail in the Validation Pipeline ...

This might be okay. Usually, the issue is that it only works from the \DefaultSource or similar folder, and that the symlink in \Links fails to find the DLLs or other required files that are still in \DefaultSource or similar.


ctf.key is missing from the juice-shop-2.24.0_node6_windows_x64.zip download

All ZIP archives since introduction of ctf.key file do not work (regardless of OS or Node version they were packed for) because that file is not packed into the ZIP when grunt package is executed.


Chrome Android and OSX device emulation mode register touches as deep/force press

Steps to reproduce:
Open pressurejs.com in Chrome on OSX and in DevTools turn on device emulation and set it to iPhone 6. Scroll to bottom and tap on test 5 and the pop up that should only trigger with a force touch displays.
Same results on Chrome Android using a Samsung Galaxy S4 and Nexus 5. On Nexus 5 all the tests get triggered.

@kylehalleman thanks for this, I can confirm that this does happen in the device emulator in Chrome. Ill have to dig into this!

@kylehalleman I appreciate all of the feedback and testing you have done so far with Pressure! Are you planning on using Pressure for an upcoming project? Just curious about your interest in Pressure :smiley:

@yamartino I've been interested in adding 3D touch to a web app I'm working on at my day job, just playing around with some ideas. I tried using variations of this code but it never seemed to work right, so I gave up. That's where I first ran into this Chrome bug.
But then I heard about this project on 5 Minutes of JavaScript podcast, so I've been playing around with it.
If I can find a solution to the Chrome bug I'll send a pull request, but in the past when using that other code, I found nothing online about the problem.
Keep up the good work.

@kylehalleman thanks for the feedback! I can confirm that all of the devices you mentioned trigger false results when using the Chrome emulator. However for example running Chrome on my actual iPhone 6, it does not trigger those results. It seems like that specifically is only a emulator issue.
Also the chrome emulator running Samsung Galaxy S4 and Nexus 5 do get the same false results. However are you getting those false results in the Chrome emulator on OSX or is that happening on the physical Android devices themselves?

@yamartino They're actual devices. I only had deep press set, and pretty much every tap (or swipe even) triggered the deep press.

@yamartino I found this repo that seems to mention the odd Chrome behavior. Check out this section of the code and also here.

@kylehalleman I think I fixed the bug in the "dev-v0.0.4" branch. Here is the commit that fixed it: https://github.com/yamartino/pressure/commit/05c290856b6902feab4d6651256d4cc5663b0109
I would love if you could try the development version and see if that fixes it! Thanks for all of the help @kylehalleman
If it works for you I will close the issue :smile:


RDBES: RS_SelectionMethod changes and new codes

Please see attached spreadsheet for changes to the RS_SelectionMethod.
2021 06 01 RDBES RS_SelectionMethod changes and new codes.xlsx

CodeType will be renamed SelectionMethod

implemented 9/6-21

There was missing a code from the list, please add right away so we can transfer the code to the RDBES before the opening of the RDBES system deadline 23 Aug.
Code                 Description
OutOfFrame      Used in cases where not all sampling units are included in sample selection
You can also see the last line in the attached spreadsheet with all codes.
2021 06 01 RDBES RS_SelectionMethod changes and new codes 105.xlsx

Implemeted 19/08-21


Remove duplicate yaml files

Did we want to get rid of the symlinks?  I think its nice to have a symlink to the underlying yaml in the relevant part of the codebase for reference

@Averylamp -- I dont think we are removing any symbolic links in this PR?
I believe the symbolic links were removed by @ravi-mosaicml because they were breaking for the pip package, somehow leading to infinite recursions (e.g. pointing to itself). If there's a fix for that, agreed that we should have symbolic files to /composer/models/resnet50/resnet50.yaml as that's where users expect them.


chore: replace ydh with sft branding

closes #665

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
479

Relevant Lines:
479

💛  - Coveralls