shift function documentation

Would it be ok to add a comment in the documentation which argument of the shift functions is the number and which is the amount of bits to shift? The original docs of the underlying javascript function describe it a bit clearer https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Left_shift

Sure! Wanna create a PR?

Done #13 , thx @flip111


Missing Plobby Chat Button in PKW Dojo

Describe the bug
The clickable button to switch to plobby chat is missing when playing PKW dojo while in a plobby
To Reproduce

Join a plobby
Join PKW Dojo
Open chat
Observe the missing button

Expected behaviour
The Plobby button to be visible
Screenshots & Logs

System & Version Information

Java Version: Java 17
Minecraft Version: 1.20.4
IslandUtils Version: 1.6.4
OS: Windows
CPU: Ryzen 5 3600X

Could be related to #115 ?

I've talked to Aso earlier regarding another instance where the plobby button wasn't showing, and I think it's the same case that it only checks for plobby on the sidebar

Could be related to #115 ?

nope, plobby features don't rely on Noxesium


Hotfix, change maximum temp file size

Merge since many pools has this issue and are crashing.

from 34GB to about 72GB

it will be fixed by #319
it is just a hotfix


resizable overlay

This issue title is not descriptive enough for us to make any meaningful change to address it. Please take care in describing your feature request thoroughly so we can understand what you would like changed and why.


Support arm and arm64 binaries for v2.6.2

Updates the update.sh script to support cross compiling binaries. Uses an updated 2.6 commit in upstream distribution with support for GOARCH as a build arg.
Each architecture creates a directory based on the GOARCH value and copies the Dockerfile, binary, config, and entrypoint to keep the docker build self contained to the directory for a given architecture.

I would highly recommend setting an explicit GOARM value for GOARCH=arm -- 7 if targeting Debian, 6 if targeting Alpine (which I believe this is, right?)
See also https://github.com/golang/go/wiki/GoArm, especially:

In cross compilation situations, it is recommended that you always set an appropriate GOARM value along with GOARCH.

Updated to include GOARM and registry default set to GOARM=6 for the alpine based Dockerfile used to build the binary

Did anyone actually test this?  Not sure I understand how it could have worked.
alpine:3.4 is not a suitable base for AArch64 since support wasn't added until alpine:3.6.

When changing to a suitable base, I also get:
$ docker run -ti --rm 29a18114e28f
<exit with no output>

Strange.
$ docker run -ti --rm 29a18114e28f sh
/ # registry
Segmentation fault (core dumped)

@lag-linaro the binaries were checked, not with that alpine version. Just verified with alpine 3.8. I am going to make an updated PR, do you might testing that as well after I open it?


Please add 10 and 15 minutes to Large Step Amount

In PF2e I need to use 5 and 10 minutes as periods (5 for moments of talk between the party or simple activities, and 10 for the short rest equivalent in the system). Currently, Large Step starts at 20 minutes.

Set your Small Step to 5 minutes — you can Shift-click the buttons to double the amount to 10 when needed.

Thanks that's very useful thing to remember.
On Fri, 27 May 2022, 19:12 John Weston, @.***> wrote:

Set your Small Step to 5 minutes — you can Shift-click the buttons to
double the amount to 10 when needed.
—
Reply to this email directly, view it on GitHub
https://github.com/unsoluble/smalltime/issues/131#issuecomment-1139759483,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7FAZCA5CKH5EBARSKMEYTVMDX53ANCNFSM5XEUFUMQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Guidelines for contributing to Blaze/commit message style

Looking through the log messages, blaze team seems to follow the style consistent with pandas for committing code:
https://github.com/pydata/pandas/blob/master/CONTRIBUTING.md#contributing-your-changes-to-pandas
Not sure if this is a default standard for github so wanted to ask if we have a similar document for blaze? I'm following this for commit messages since it seems consistent with log messages I see in blaze, but figured I'd also just ask.

I am normally working on scientific python packages so the python/numpy style commit messages are a standard for me. I don't personally have a preference though.

Related: we could add issue and pr templates. I don't really think that we have had a problem with this so far but it is sort of realted to this issue.


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

?

sorry wrong button.


TriangleMesher misidentifies partial holes

If polygon 1 has an interior, partially filled by polygon 2:

Then the representative point may well be found inside of polygon 1, and the hole will be discarded.
Instead, we should identify the true hole (the bit above polygon 2).
A unary union of all the polygons would do the trick but seems a bit costly. An alternative scheme is get the interiors, identify any polygon that's inside through the use of representative points (much cheaper), then diff the interior with the polygon. The result should be the true hole. Then we provide triangle with the representative point of the true hole.

Resolved in:
4a6aa1969b6968e9c24c33136b498bfcf0dfc5ba
And if the hole is split in multiple parts, the geometry has to be exploded, since a multi-geometry still has a single representative point:
bb764c0a1e6c4d750e52eb188d7313e88007ca38


Added compress flag and updated version number

Only merge once https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/164 is ready and published to npm (this is causing the failed build).

@lilleyse code looks good to me, you can merge this yourself when gltf-pipeline is ready.

@lilleyse code looks good to me, you can merge this yourself when gltf-pipeline is ready.

Sure.


testing custom resources is broken with chef 13

I've build a simple cookbook with an example resource and example chefspec step_into to demonstrate the problem.
See the Readme file for chef12 and chef13 log output/scripts:
https://github.com/rmoriz/chefspec_problem#readme
Looks like the 'step_into' functionality isn't working anymore

When will this be released?


Update lombok to 1.18.20

Lombok 1.18.12 fails to compile in Java 16 with the error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project Nedit: Fatal error compiling: java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor (in unnamed module @0x68a305eb) cannot access class com.sun.tools.javac.processing.JavacProcessingEnvironment (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.processing to unnamed module @0x68a305eb -> [Help 1]

Updating it to 1.18.20 fixes this

I'm actually working on a few changes today, including removing the dependency on lombok altogether. Should be out in a few hours, but thanks for the PR.

Should be fixed as of v2.0.0


V2

Tries to be slightly more clever by using a cache with some different STM actions, namely "initializing" a throttle so that it's not created on multiple threads. Haven't benchmarked or investigated space issues.
@ystael @mossprescott

Hey I was drafting something to you a bit earlier but I am definitely interested in reviewing and merging improvements that fix the issues at hand. Give me the evening to test and review, but it's on my radar and will follow-up tomorrow.

side-note: haven't been using this middleware much over the last year or so but starting to integrate it again into a few services with load.
I think it's a good thing to merge into this repo, if possible, even if it's mostly a rewrite because this middleware already has visibility and name.
Thanks!

Mostly looks good. What's the idea behind the "V2" module? What do you want to do on this?
I imagine you have some emperical evidence that the new module works better in your applications (either memory/cleanup or speed). Can you shed light on that? Maybe we can get a bench or test which validates certain properties and move ahead?

Thanks for all your help! Did not explain fully in original description.
Essentially I was nervous about making too big of a change so the v2 is
there in case anyone wants to iterate on the old API. If not, also fine, I
can overwrite. Still haven't had time to test this for memory leaks or
speed, but will do so next week. The motivation behind using a cache was
that I think at least part of the memory problem is down to stale buckets.
The motivation for synchrony with respect to cache initialization was that
it's possible multiple threads could have been mutating the cell before
leading to dangling references in the map. Anyway I'm hoping to corroborate
these claims early next week by benchmarking and load testing it and I'll
update when I do.
Dan
On Sat, Sep 29, 2018, 13:36 Christopher Reichert<EMAIL_ADDRESS>wrote:

Mostly looks good. What's the idea behind the "V2" module? What do you
want to do on this?
I imagine you have some emperical evidence that the new module works
better in your applications (either memory/cleanup or speed). Can you shed
light on that? Maybe we can get a bench or test which validates certain
properties and move ahead?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/creichert/wai-middleware-throttle/pull/18#issuecomment-425662452,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIBQ6GJR06tknlYQuqbgP8IekI9gyRBJks5uf6-IgaJpZM4W7MYd
.

Benchmarking results look fine. Looks like a lot of jargon but there was essentially no performance difference between V1 and V2. Looking into space leaks now.
bench.txt

Okay, so as I alluded to in another comment, I don't have a problem with
merging this even if it changes a significant (or all) of the code.
My problem with the code in it's current state is the organization of
the "V2" module. Based on that, I think we should commit to a course of
action:

Move V2 -> Network.Wai.Throttle and bump major version
This changes the public interface, so I'd like to export as little
as possible and see what symbols we used in V1 that we can maintain
compatibility with.

Move V2 -> Network.Wai.Throttle.Internal
Expanding on the previous suggestion. It might be possible to move
"V2" to an "Internal" module, and attempt to re-export the new
functionality through the primary exported module. This is a little
more effort, though.
Using this method, I think we could mostly maintain compatibility w/
the original API. Of course, we should exported stuff we don't want,
or is not ideal. We are bumping the major version anyways.

Split V2 into a new package.
I don't have a preference on this. It's up to you to consider whether
the effort is worth it. One benefit of this package having visibility
is that it's likely to encourage more future contribution if it
becomes a more stable & scalable middleware.

I'm finishing my changes for circleci now, which i'll merge back into
this branch to help w/ integration. Let me know if you have any other
ideas for integrating this code.
One minor thought, the rts option configuration for the benchmarks may
not lead to consistent benchmark results. Is using the -N appropriate?
I'm not 100% sure.
Thanks again!

Memory leaks addressed:
Original version throttle-simple-server.pdf
New version
throttle-simple-server-v2.pdf

Hm okay, yeah I definitely considered option (3) but the reasoning behind wanting to keep a recognizable name was why I decided to try to get it incorporated here.
I think my favorite of those three options is (1), but I am interested in testing some of the internal functions, so I will try to maintain a similar interface with some functions in Internal.hs

Alright I think I'm done for now, let me know what you think. Thanks for your patience. Happy that memory leak worked out in the end.

@dfithian 	perfect, I just need to take another day or two to completely test and run through a few of the workflows.
I really want to get the CI build on this one. Do you happen to know how to fix this error. Once I can get that and merge those changes here, I'll be happy: https://circleci.com/gh/creichert/wai-middleware-throttle/27?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Then, we'll cut a new major version. So far, I only have nitpicks on a few naming conventions but other than that, nice.

@creichert all good except for the comment about --no-terminal/$STACK_ARGS

Oh man bummer the stack images aren't prebuilt with libraries in the snapshot, though I suppose wai-middleware-throttle is already in that stack image so it would be tricky...

Let me know what you think. I think I did a really bad job of tagging the last release actually, by which I mean I didn't realize at the time that I needed to do it. If you want I can try to take care of it but I'll wait for your confirmation either way.

Okay, so far so good. I'm planning to merge this and cut a release tonight. I just need to run a few more tests locally and I want to deploy it on one of my servers.
This is a fantastic contribution.

Thank you for such a fantastic contribution. Merging and uploading to Hackage.

@dfithian done! :clap:

https://hackage.haskell.org/package/wai-middleware-throttle
https://github.com/creichert/wai-middleware-throttle/releases/tag/v<IP_ADDRESS>

Thank you! Awesome 👏
On Wed, Oct 17, 2018, 22:30 Christopher Reichert<EMAIL_ADDRESS>wrote:

@dfithian https://github.com/dfithian done! 👏

https://hackage.haskell.org/package/wai-middleware-throttle

https://github.com/creichert/wai-middleware-throttle/releases/tag/v<IP_ADDRESS>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/creichert/wai-middleware-throttle/pull/18#issuecomment-430853876,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIBQ6BSM9bVkCFF4Aiao-wYhSFS0DPhGks5ul-eogaJpZM4W7MYd
.


Hunting for memory leaks

We regularly have a few Out Of Memory, which are very difficult to track down.
We have found 2 probable causes.
It's not much, but in a high-traffic context, small streams make big rivers.
Take a look at our PR to see the little fixes we've made.
But the hunt is not finish... 😃

@ggnaegi  and @RaynaldM
Any ideas on how to monitor such cases and memory management?
Seems we need definitely to design some lite memory controller/monitor...

@ggnaegi  and @RaynaldM
Any ideas on how to monitor such cases and memory management?
Seems we need definitely to design some lite memory controller/monitor...

Metrics?

Does our lovely Bla-bla gateway have some metrics/indicators or monitoring features?
We could start from general metrics for memory consumption, but I'm afraid that will be not easy... Seems it requires a refactoring of all Ocelot core... 🤔
I believe for the first time we can read consumed memory on app domain level... That should be enough...
More precise metrics/indicators require big refactoring road/milestone...

As you can see, memory consumption varies greatly from pod to pod, due to the diversity of operations to be carried out.

As you can see, memory consumption varies greatly from pod to pod, due to the diversity of operations to be carried out.
It varies from 150 MB to 1.2 GB.

@RaynaldM Intresting, how you are measuring these graphs? Is it something on Production with azure/aws, which tool it is?
What about just finding through visual studio profilers, is it effective enough?
Just gone through statement and trying to understand, what approach you are following.

Here we can see from 50s to 1:40min we got 2 times allocations, one before GC and after GC.
We can through VS revisit our codes where it makes more allocations?

.Net 8 have new feature for realtime GC monitoring, .Net Aspire.
https://learn.microsoft.com/en-us/dotnet/aspire/get-started/aspire-overview
https://www.youtube.com/watch?v=DORZA_S7f9w
https://github.com/dotnet/eShop
Can we give user option to integrate?

But the hunt is not finish... 😃

@RaynaldM @ggnaegi  Do we need to hunt more?

@raman-m @RaynaldM We should try to improve the overall application performance, but the last changes had a big impact on OOMs. I think this issue isn't specific enough, maybe we should convert it to a conversation?


Create a switch to allow / disallow grid feeding?

Is it possible to create a switch with param 1127 of XT1 to allow and disallow grid feeding (injection)?
I correctly import the expert param in the configuration, but when I click my switch in HA, nothing happens...

Hi, functionality for a switch should be there, but I haven't done much testing with it yet.
So you might very well have runinto a bug...
Any messages visible in the Log (Settings -> System -> Logs and then press 'show full logs') when you click on the switch?

Hi, thank you for your prompt reply!
No error message about the switch in the HA logs.
The action probably needs to be customised for it to work, like sending 0 or 1. I don't know exactly what the default toggle action produces in this case...

Don't see anything wrong in the integration code for a Switch entity.
Cannot test with Xtender param 1127 myself as I am not connected to the grid. So tested with 1521 (one of the Aux2 params) instead. Datapoint definitions of those two params are identical (apart from parent number and name), so behavior in code will also be identical:
    {   "fam": "xt",   "lvl": "Expert",  "pnr": 1522,   "nr": 1127,   "name": "  Grid feeding allowed",   "unit": "",   "def": 0,   "min": 0,   "max": 1,   "fmt": "BOOL",   "inc": 1 },
    {   "fam": "xt",   "lvl": "Expert",  "pnr": 1456,   "nr": 1521,   "name": "    No overtemperature (AUX 2)",   "unit": "",   "def": 0,   "min": 0,   "max": 1,   "fmt": "BOOL",   "inc": 1 },

When switching 1521 on and off I can clearly hear the relay for Aux2 clicking on and off and the connected hot water heater also switches on and off.
From the logs:
2024-12-03 10:58:36.103 INFO (MainThread) [custom_components.studer_xcom.switch] Set switch.studer_4001_xt1_1521 to ON (1)
2024-12-03 10:58:36.145 INFO (MainThread) [custom_components.studer_xcom.coordinator] Successfully updated XT1 1521 to value 1
2024-12-03 10:58:41.157 INFO (MainThread) [custom_components.studer_xcom.switch] Set switch.studer_4001_xt1_1521 to OFF (0)
2024-12-03 10:58:41.200 INFO (MainThread) [custom_components.studer_xcom.coordinator] Successfully updated XT1 1521 to value 0

So am not able to reproduce the problem :-(

Can you elaborate with what you mean by 'when I click my switch in HA, nothing happens...'

I am sorry, I don't know how to set this action correctly on the switch I created...

Should I create a script and attach it to the button?

The yaml code should look like:
    action: switch.turn_on
    target:
      entity_id: switch.studer_4001_xt1_1521

or
    action: switch.turn_off
    target:
      entity_id: switch.studer_4001_xt1_1521

or
    action: switch.toggle
    target:
      entity_id: switch.studer_4001_xt1_1521

Here is my switches.yaml code, no error but nothing happens on my XTM :
- platform: template
  switches:
    studer_injection:
      value_template: "{{ is_state('switch.studer_4001_xt1_1127', 'on') }}"
      turn_on:
        action: switch.turn_on
        target:
          entity_id: switch.studer_4001_xt1_1127
      turn_off:
        action: switch.turn_off
        target:
          entity_id: switch.studer_4001_xt1_1127
    studer_aux2:
      value_template: "{{ is_state('switch.studer_4001_xt1_1521', 'on') }}"
      turn_on:
        action: switch.turn_on
        target:
          entity_id: switch.studer_4001_xt1_1521
      turn_off:
        action: switch.turn_off
        target:
          entity_id: switch.studer_4001_xt1_1521

Just a check to be sure, I assume your configuration.yaml contains a line
switch: !include switches.yaml

And you may need to restart Home Assistant after adding that line to configuraton.yaml

Also note that instead of making a new/copy template definition for the switches, you can also just rename the original switches in the integration. Choosing a new name, icon or entity_id is allowed, it will not affect updates as internally an object_id is used that will always remain the same value.
So rename from switch.studer_4001_xt1_1127 into switch.studer_injection
and from switch.studer_4001_xt1_1521 into switch.studer_aux2

Thank you for your comments.

I do include switches.yaml in configuration.yaml
I tried to create a template because initially I was using the switch integration directly without success
I reload the configuration after each modification

To further analyse this issue, could you please perform the following steps:

Go to HA Settings->Integrations->Studer-Innotec->Devices->Studer XT1 and click two times on the switch for 1127
Then go back to the Studer-Innotec integration screen, press the '...' and choose 'download diagnostics'
Attach the resulting file to your answer below.

The diagnostics file contains a section that logs success and fail of request and update commands send to the Studer devices. I would expect it to contain a fail count for your system and hope the 'errors' structure will indicate why:
            "UpdateValue XT1 EXPERT": {
              "counters": {
                "success": 2,
                "fail_write": 0,
                "fail_read": 0,
                "fail_timout": 0,
                "fail_error": 0,
                "fail_unpack": 0,
                "fail_other": 0
              },
              "errors": {}
            }

Thanks a lot for the help, I really appreciate it.
Here the section of the diagnostic (but there are no errors):
"UpdateValue XT1 EXPERT": {
          "counters": {
            "success": 2,
            "fail_write": 0,
            "fail_read": 0,
            "fail_timout": 0,
            "fail_error": 0,
            "fail_unpack": 0,
            "fail_other": 0
          },
          "errors": {}

I suspect an authorisation problem on the Moxa side...

No, I don't think it is an authorisation problem. The "success": 2 indicates that the Studer Xcom device confirmed that it has sucessfully updated value. Otherwise the fail_error would have increased. Or one of the other fail_ values if the Xcom device could not be reached.
Are you absolutely sure that no other setting is blocking what you think should happen?
What behavior do you expect to see?

In addition to the previous comments above, could you please check that your user level is set to at least 'Expert' since you try to change a param of Expert level:

Go to your RCC screen,
Press the down button until you reach 'RCC params', then press 'set'
Press the down button until you reach 5012 'User Level'.
Check the value for that param in the bottom right of that screen.

Alternatively, you can do the same via the online Studer portal (https://portal.studer-innotec.com/) in the 'Remote Control' page

In the right top of that page it states the 'current user level'.
Or, in the right bottom, request the value for Parameter Id 5012
Or in the remote connected screen follow the steps as described above on a physical RCC

Alternatively, update to the latest version of the integration (v2024.12.1), press 'Reconfigure' on the Studer-Innotec integration page and add param RCC 5012. After that, press 'devices' and choose 'RCC'. The User Level is now visible as a diagnostics sensor in the integration.

The user level is EXPERT.
When I activate the switch in HA, everything happens normally but when I look at the RCC, the parameter is not modified and after the polling interval, the initial state (unmodified) is returned to HA.
To sum up, the switch in HA does not modify the studer system.

It is correct that you will not see your change when you inspect your param via the RCC. This is explained in the ReadMe of the Studer-Innotec integration:
Entity writes to device
When the value of a Studer param is changed via this integration (via a Number, Select or Switch entity), these are written via Xcom to the affected device.
Changes are stored in the device's RAM memory, not in its flash memory as you can only write to flash a limited number of times over its lifetime.
However, reading back the value from the entity will always be from flash. As a result, the change to the entity value is not visible in the RCC or remote console. You can only tell from the behavior of the PV system that the Studer param was indeed changed.
After a restart/reboot of the PV system the system will revert to the value from Flash. So you may want to periodically repeat the write of changed param values via an automation.

However, one other line in your response makes me wonder if there still is a bug in my code:
"and after the polling interval, the initial state (unmodified) is returned to HA"
So you turn the switch On (or Off), it displays in HA as On (or Off) and then after 30 seconds it suddenly reverts to display as Off (or On) again?
To make things appear more logical in the HA integration despite the weird RAM/Flash behavior of the Studer hardware, I cache/remember modified values in the integration to keep displaying them as modified. So a Switch turned On will modify the RAM memory state of the Studer Device into On. The device will behave accordingt to the RAM value. However, the Flash value will still return the Off value. I ignore that and keep displaying the On value for the switch in HA. This modified value is persisted in a file, so that the integration will keep remembering the change even after a restart of HA.
You can see this cache when you download the diagnostics for the integration (see above for steps). The following section should be in it (but for you for param 1127 instead of 1521):
        "cache": {
          "ModifiedParams": {
            "ts": "2024-08-29T20:43:23.895947",
            "studer_4001_xt1_1521": 0
          },
          "ModifiedParamsTs": "2024-12-09T11:13:25.602811"
        },

Could you please check the modified param is indeed stored in cache?

Your explanations (RAM / Flash) make sense, that's probably what's happening. I'd have to find a parameter to change that is visible in the behaviour of my system to check.
Concerning the integration cache system, there does seem to be a bug because the contents of the cache parameter are always empty in my successive tests.
"cache": {},

Another strange behavior of the integration: I updated the version from 2024.11.4 to 2024.12.1 today but it still displays 2024.11.4.
I confirm the new version is use because I could import the param 5012 now and couldn't before...

The version number was my mistake, forgot to update it in the code before I published the new release.
OK, so somehow something is going wrong with the caching of modified param values on your system. I created a new release v2024.12.2 (now with version internally correct) that also will log warnings if unexpected behavior around the cache is detected.
Could you please give that a try?
Also, would it be possible for you to check if you have a file /homeassistant/.storage/studer_xcom.coordinator (note the dot in .storage) using ftp or ssh; it is not visible via the file editor inside HA. And place the contents in a comment here. Should look similar to what the 'cache' section of the diagnostics download looks like.

"cache": {
      "ModifiedParams": {
        "studer_4001_xt1_1127": 0,
        "studer_4001_xt1_1521": 0
      },
      "ModifiedParamsTs": "2024-12-09T09:50:59.369888"
    },

And good news, the switch now stay on (or off) in HA!

in coordinator:
{
"version": 1,
"minor_version": 0,
"key": "studer_xcom.coordinator",
"data": {
"4001": {
"cache": {
"ModifiedParams": {
"studer_4001_xt1_1127": 1,
"studer_4001_xt1_1521": 0
},
"ModifiedParamsTs": "2024-12-09T09:54:13.995180"
}
}
}
}

Yes, those structures look as expected now.
This new version had mostly tracing changes in it, but simplified one part of cache handling too. That may just have done the trick to solve this.
Could you please keep an eye on whether the switch keeps its value after a HA restart?

Yes, the switch also keeps its value after restart.
Thank a lot for this integration and for solving this problem quickly!

There may be another point to correct:
When you click "reconfigure" the integration, the BMS parameters you added manually disappear. For example, I have to re-add parameter 7003 each time.

I will create a new Bug Report for the disappearing params wile doing a reconfigure. Hadn't noticed that behavior for params on other devices, so may be a bug specific to BMS


[SPARK-36087][SQL][WIP] An Impl of skew key detection and data inflation optimization

What changes were proposed in this pull request?
1, introduce ShuffleExecAccumulator in ShuffleExchangeExec to support arbitrary statistics;
2, impl a key sampling ShuffleExecAccumulator to detect skew keys and show debug info on SparkUI;
3, in OptimizeSkewedJoin, estimate the joined size of each partition based on the sampled keys, and split a partition if it is not split yet and its estimated joined size is too larger.
Why are the changes needed?
1, make it easy to add a new statistics which can be used in AQE rules;
2, showing skew info on sparkUI is usefully;
3, spliting partitions based on joined size can resolve data inflation;
Does this PR introduce any user-facing change?
Yes, new features are added
How was this patch tested?
added testsuites

Test build #140910 has started for PR 33298 at commit a9888ba.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45422/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45422/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45422/

Test build #140910 has finished for PR 33298 at commit a9888ba.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait ShuffleExecAccumulator extends AccumulatorV2[InternalRow, String]

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140910/


NotImplementedError: Format "num-dot-decimal" not implemented (namespace "ixt")

Hi,
this is really a great package. I tried to parse some iXBLR myself, but seeing all your work it becomes clear that this is quite some work. So thanks for the package!
I have an issue. I try to parse some iXBLR annual report from "Gleif": https://www.gleif.org/content/1-about/10-governance/11-annual-report/gleif-annual-report-2019.zip
When I try to parse it, I get the error below. I tried to dig into the source files, but I could not locate the actual problem or find out how to solve the error.
Would be glad to hear back from you, Cheers!
File "...\python\gleif_try.py", line 8, in
x = IXBRL(a)
File "C:\Python3\lib\site-packages\ixbrlparse\core.py", line 16, in init
self.get_numeric()
File "C:\Python3\lib\site-packages\ixbrlparse\core.py", line 97, in get_numeric
ixbrlNumeric(element)
File "C:\Python3\lib\site-packages\ixbrlparse\components\numeric.py", line 34, in init
self.format = get_format(format['format'])(**format_)
File "C:\Python3\lib\site-packages\ixbrlparse\components\transform.py", line 92, in get_format
namespace,
NotImplementedError: Format "num-dot-decimal" not implemented (namespace "ixt")

Hi @Bixi81  - thanks for reporting the issue.
I think I've solved this one in 2ba2cecefcddd3c5f7c5c3bd2ea2d8a6d57179fd - it should now remove any dashes when checking the format to use (so num-dot-decimal should become numdotdecimal). I've added a test for this here: https://github.com/drkane/ixbrl-parse/blob/2ba2cecefcddd3c5f7c5c3bd2ea2d8a6d57179fd/tests/test_classes.py#L126
If you upgrade the pip package to 1.1.2 it should be fixed.

Hi @drkane: Thanks for the reply, great you could fix this... As per docs (https://www.xbrl.org/Specification/inlineXBRL-transformationRegistry/REC-2015-02-26/inlineXBRL-transformationRegistry-REC-2015-02-26.html#sec-ixt-24) there should be no dash but some reports seem to use a dash in the format definition.


Request Directional Mic

Hey @cgreening thought I would ask as still being a noob not exactly sure where to start, so thought I would ask you again. :)
Looking at https://invensense.tdk.com/wp-content/uploads/2015/02/Microphone-Array-Beamforming.pdf and a stereo pair of INMP441 mems the board is 14mm so closest we can get is a 14mm mic spacing with those boards.
That gives a null frequency of 12Khz with a  2-sample delay @ 48Khz.
Not great as prob would like maybe make that 16Khz null but a 11m spacing is a bit hard but it will do just for a test.
My noobness has me wondering how in the code do where the first mic is summed with an inverted and delayed signal from the
rear microphone.
void I2SSampler::processI2SData(uint8_t *i2sData, size_t bytes_read)
{
    int32_t *samples = (int32_t *)i2sData;
    for (int i = 0; i < bytes_read / 4; i++)
    {
        // you may need to vary the >> 11 to fit your volume - ideally we'd have some kind of AGC here
        addSample(samples[i] >> 11);
    }
}

Its just 2 samples @ 14mm but guess in stereo the I2S data comes L/R...L/R but rather than L/R think of them as F/R until we get a Rear delay1 & delay2 = zero
Rear delay2 is inverted and added to front1 and would you store this in a new raw stream?
Rear_delay1 is moved to Rear_delay2 and current Rear is moved to Rear_delay1
I have been looking at the ADF and its still greek to me but in the pipeline then all is needed is to use the EQ to flatten the response as in  Figure 12. Frequency Response of an Endfire Beamformer at Different Incident Angles.
I might have you in a unique position to offer boards with maybe 2/3 mics on a 11mm spacing :)
But just checking with 2x @ 14mm and at the downsampling to 16Khz cuts out after the null notch?
Apols for hounding you about this but just really interested how much load this would entail and could you run it in conjunction with the KWS part of your Alexa project on different cores?

Hey Stuart, I'll have to read and digest the PDF. If it's simply a case of subtracting the right from the left channel then that shouldn't add much load at all.
The code change would be fairly trivial - you'd need to change the setup of I2S to have both left and right channels and there might be a bit of work to handle under and overflow when doing the maths - maybe do the calculations in 64 bits and then clip if needed.
void I2SSampler::processI2SData(uint8_t *i2sData, size_t bytes_read)
{
    int32_t *samples = (int32_t *)i2sData;
    for (int i = 0; i < bytes_read / 4; i+=2)
    {
        int32_t difference = samples[i] - samples[i+1]
        // you may need to vary the >> 11 to fit your volume - ideally we'd have some kind of AGC here
        addSample(difference >> 11);
    }
}

Yeah I thought maybe keep it at 1st 24bit as that has loads of headroom.
I thought it might make another great project idea sperate from this and also it wasn't a joke about boards as directional mems could be quite popular maybe.
Its invert one so -rear_delay2 + current_front that will give a directional mic but the eq does need to be flattened by 6db per octave as you go down from the null frequency.
I guess you could run the EQ pipeline before or after and its just which is easier? So there is the EQ load, dunno!? how much that adds but at least its already done in the ADF.
There is also the resample pipeline where after 48khz can be dropped to 16khz and I mention as that would need to be after EQ as 16k is not a supported EQ rate.
I was always confused by addSample(difference >> 11); as my noob C seems to make me think that is 11bit rotate so we lose 5 LSBs.
Which is no problem but just wondered why not addSample(difference >> 16); as with the originally 24bit source that is an extremely heaving 'compander' style effect even 16 loses 8 LSB's.
The 'compander' effect might be a bonus but been wondering is the resample pipeline should be used?
But please do have a read of https://invensense.tdk.com/wp-content/uploads/2015/02/Microphone-Array-Beamforming.pdf as a simple 2/3 mic beamformer could make a really interesting project that could be of much interest.

I was having a browser around - have you come across these boards?
https://www.espressif.com/sites/default/files/documentation/esp32_hardware_design_guidelines_en.pdf
5.1.2 ESP32-LyraTD-MSC Audio Development Board

Yeah but expensive (£45) and large as say compare to a wrover 8mb for £6 as even the sd card reader is essentially bloat even if cool to have.
(on the wrover with the sd)
The chip that its based on is real interesting though https://www.microchipdirect.com/product/ZL38063LDG1 as @ £4 its relatively cheap.
It can work with 2/3 mics and you can parallel to another for 4/6 mic configs the ESP32-LyraTD-MSC Audio has gone all in with 6 mics and its questionable as the 2/3 config probably is a better fit.
We should be able to make a relatively cheap board and load up the firmware from a esp32 and that SD card might come in handy.
Also for Pi users as Microchip have a dev board and linux drivers and that has surprised me as the Pi has a screaming need for a Mic/Dac beamformer.
That you could have a Hat with 2/3 and a daughter card addon to make that 4/6 that isn't vastly more expensive than a Pi3A+ in terms of AI proliferation it has a big market.
Its surprised me Pi hasn't done something themselves but they are quite canny that way and doggedly stick to just Pi.
I have a feeling its the devkit costs of the ZL38063 and that it requires a custom kernel which will cause a whole load of S***.
I have mixed emotions about those all-in-one devkits as from mic placement, form factor, connectors and choice the designer is totally constricted.
I have no idea why an all-in-one is provided and why the didn't do a 2/3 mic audio board with I2S SPI/I2C that has the mics on snap-offs  if you so choose.
The ZL38063 look really interesting but after trying some commercial beamformers that work exceptionally well in industrial distributed noise fields in domestic scenarios with singular predominant noise especially TV voice but music media can completely bamboozle.
I think you can the cost of multiple distributed KWS directional mics is comparative and in domestic situations as it partitions the high end dsp by simple using the nearest and best KW hit stream.
I am a big fan of opensource and been screaming crazily for quite a while now that we should stop trying to copy the impossible of commercial style product but process local in single all in units whilst we can do something better with a system akin to pro conference distributed mic arrays that then feed the advantages of a singular HAL style central ASR intent processor.

PS Chris are you asking about the ESP32-LyraTD-MSC because it states it is supported?
Like usual defined code of the HAL to make things easier often confuses or makes thing more diffficult.
Its possible to define a custom HaL as basically you are just creating a template of I2S pins & SPL/I2C control parameters.

But this might make more sense to you as you can override the defined ADF templates and create custom ones.
https://esp32.com/viewtopic.php?t=13698
I will also have a look for an 3rd party equalizer as it would be far better to run @ 16Khz mono after the beamforming has taken place.


Seg fault when trying to render TOC

I was doing some benchmarks and I keep getting segfaulted when doing HTML_TOC rendering
Here's my benchmark code:
require 'benchmark/ips'
require 'redcarpet.so'

TESTMD = File.read("./markdown_test_data.md") # from https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet

# Warmups
Redcarpet::Markdown.new(Redcarpet::Render::HTML.new).render(TESTMD)
Redcarpet::Markdown.new(Redcarpet::Render::HTML_TOC.new).render(TESTMD)

Benchmark.ips do |x|
  x.report 'standard-redcarpet' do
    Redcarpet::Markdown.new(Redcarpet::Render::HTML.new).render(TESTMD)
  end

  x.report 'standard-redcarpet-toc' do
    Redcarpet::Markdown.new(Redcarpet::Render::HTML_TOC.new).render(TESTMD)
  end
end

Output on Windows
D:\benchmarks $ ruby markdown_benchmark.rb
Calculating -------------------------------------
  standard-redcarpet   468.000  i/100ms
standard-redcarpet-toc
                       630.000  i/100ms
-------------------------------------------------
  standard-redcarpetC:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips.rb:90: [BUG] Segmentation fault
ruby 2.2.1p85 (2015-02-26 revision 49769) [i386-mingw32]

-- Control frame information -----------------------------------------------
c:0009 p:---- s:0054 e:000053 CFUNC  :%
c:0008 p:0135 s:0050 e:000049 METHOD C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips.rb:90
c:0007 p:0114 s:0044 e:000042 METHOD C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/report.rb:81
c:0006 p:0328 s:0038 e:000035 BLOCK  C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/job.rb:308 [FINISH]
c:0005 p:---- s:0020 e:000019 CFUNC  :each
c:0004 p:0009 s:0017 e:000016 METHOD C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/job.rb:258
c:0003 p:0229 s:0014 e:000013 METHOD C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips.rb:53
c:0002 p:0116 s:0004 E:001bbc EVAL   markdown_benchmark.rb:10 [FINISH]
c:0001 p:0000 s:0002 E:0020ec TOP    [FINISH]

-- Ruby level backtrace information ----------------------------------------
markdown_benchmark.rb:10:in `'
C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips.rb:53:in `ips'
C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/job.rb:258:in `run'
C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/job.rb:258:in `each'
C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/job.rb:308:in `block in run'
C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/report.rb:81:in `body'
C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips.rb:90:in `scale'
C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips.rb:90:in `%'

-- C level backtrace information -------------------------------------------
C:\WINDOWS\SYSTEM32\ntdll.dll(NtWaitForSingleObject+0xc) [0x77E6512C]
C:\WINDOWS\SYSTEM32\KERNELBASE.dll(WaitForSingleObject+0x12) [0x754C1802]
C:\Rubies\Ruby22\bin\msvcrt-ruby220.dll(rb_vm_bugreport+0xa7) [0x640D4307]
C:\Rubies\Ruby22\bin\msvcrt-ruby220.dll(rb_bug_context+0x42) [0x63F86A22]
C:\Rubies\Ruby22\bin\msvcrt-ruby220.dll(rb_check_safe_obj+0x394) [0x6404F4A4]
 [0x00401866]
C:\WINDOWS\SYSTEM32\ntdll.dll(WinSqmEventWrite+0x1c795) [0x77E96805]

-- Other runtime information -----------------------------------------------

* Loaded script: markdown_benchmark.rb

* Loaded features:

    0 enumerator.so
    1 rational.so
    2 complex.so
    3 C:/Rubies/Ruby22/lib/ruby/2.2.0/i386-mingw32/enc/encdb.so
    4 C:/Rubies/Ruby22/lib/ruby/2.2.0/i386-mingw32/enc/trans/transdb.so
    5 C:/Rubies/Ruby22/lib/ruby/2.2.0/i386-mingw32/enc/iso_8859_1.so
    6 C:/Rubies/Ruby22/lib/ruby/2.2.0/unicode_normalize.rb
    7 C:/Rubies/Ruby22/lib/ruby/2.2.0/i386-mingw32/rbconfig.rb
    8 thread.rb
    9 C:/Rubies/Ruby22/lib/ruby/2.2.0/i386-mingw32/thread.so
   10 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/compatibility.rb
   11 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/defaults.rb
   12 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/deprecate.rb
   13 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/errors.rb
   14 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/version.rb
   15 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/requirement.rb
   16 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/platform.rb
   17 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/basic_specification.rb
   18 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/stub_specification.rb
   19 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/util/stringio.rb
   20 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb
   21 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/exceptions.rb
   22 C:/Rubies/Ruby22/lib/ruby/2.2.0/rubygems/defaults/operating_system.rb
   23 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_gem.rb
   24 C:/Rubies/Ruby22/lib/ruby/2.2.0/monitor.rb
   25 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb
   26 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems.rb
   27 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/path_support.rb
   28 C:/Rubies/Ruby22/lib/ruby/site_ruby/2.2.0/rubygems/dependency.rb
   29 C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/timing.rb
   30 C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/compare.rb
   31 C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/report.rb
   32 C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips/job.rb
   33 C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/benchmark-ips-2.2.0/lib/benchmark/ips.rb
   34 C:/Rubies/Ruby22/lib/ruby/gems/2.2.0/gems/redcarpet-3.3.1/lib/redcarpet.so

[NOTE]
You may have encountered a bug in the Ruby interpreter or extension libraries.
Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

D:\benchmarks $

Output on Linux:
[sapslaj@boxxy benchmarks ]$ ruby markdown_benchmark.rb
Calculating -------------------------------------
  standard-redcarpet*** Error in `ruby': free(): invalid pointer: 0x08d6ded8 ***
[1]    3966 abort (core dumped)  ruby markdown_benchmark.rb
[sapslaj@boxxy benchmarks ]$ ruby -v
ruby 2.1.1p76 (2014-02-24 revision 45161) [i686-linux]

Same here:

broken (on 3.3, also tried 3.3.1): https://travis-ci.org/scala/scala/builds/65747400
fixed (pin to 3.2.3): https://travis-ci.org/scala/scala/builds/67595824

as a postscript to @adriaanm's comment, we aren't actually sure this is really the "same" crash as @sapslaj's. if it would be helpful for me to attempt to minimize the input that makes it fail, let me know. I wasn't able to reproduce the crash locally on OS X, but it happened every time running on Travis-CI under Ubuntu.

Update: I did a bit more testing and you will never believe this.
I made a script that runs Redcarpet::Markdown.new(Redcarpet::Render::HTML_TOC.new).render(TESTMD) 10,000 times.
On Linux, the bit that is making it crash is this:

## Code and Syntax Highlighting

$ ruby markdown_benchmark_before_newline.rb

2*** Error in `ruby': free(): invalid next size (fast): 0x09eb7f00 ***
[1]    19214 abort (core dumped)  ruby markdown_benchmark.rb

Now the really funny bit. Add a space between those two lines in the markdown:

## Code and Syntax Highlighting

Completely different crash:
$ ruby markdown_benchmark_after_newline.rb

97ruby: malloc.c:2372: sysmalloc: Assertion `(old_top == (((mbinptr) (((char *) &((av)->bins[((1) - 1) * 2])) - __builtin_offsetof (struct malloc_chunk, fd)))) && old_size == 0) || ((unsigned long) (old_size) >= (unsigned long)((((__builtin_offsetof (struct malloc_chunk, fd_nextsize))+((2 *(sizeof(size_t))) - 1)) & ~((2 *(sizeof(size_t))) - 1))) && ((old_top)->size & 0x1) && ((unsigned long) old_end & pagemask) == 0)' failed.
[1]    19222 abort (core dumped)  ruby markdown_benchmark.rb

The really funny bit: Both of these tests work flawlessly on Windows.
D:\benchmarks $ ruby markdown_benchmark_before_newline.rb

9999
D:\benchmarks $ ruby markdown_benchmark_after_newline.rb

9999
D:\benchmarks $

I should note that the normal HTML renderer does not crash when running these tests.
So I said screw it. Let's throw the whole test data in and see what happens. Now for the even funnier bit.
On Linux, crashes like normal. On Windows, however, it goes through a seemingly random number of iterations before crashing.
D:\benchmarks $ ruby markdown_benchmark.rb

3001markdown_benchmark.rb:7: [BUG] Segmentation fault
ruby 2.2.1p85 (2015-02-26 revision 49769) [i386-mingw32]
...

And to top it off, sometimes when it crashes it will get stuck on writing the C backtrace, and if I kill one of the two (only has two processes sometimes?) Ruby interpreter in Task Manager, sometimes it will continue going, but most of the time it spits out the backtrace and exits.
This is very erratic behavior and it only seems to happen to the HTML_TOC renderer. I suppose since it's derived from the HTML renderer it could be a bug in either. I'll try to do some more testing with OS X later tonight or tomorrow and I'll keep you updated. But as for now,

Hi there!
This looks like

Yep. Tests are passing now. Looks like 3.3.2 fixed the issue.

Awesome! Thanks for confirming and sorry for the late answer! :heart:


BUG EmailTest non-warnings are preventing tests running

Non-warnings (that appear as warnings) from the following method are failing due to the below exception
if ($callOriginalConstructor === false && $callOriginalMethods === true) {
    throw new PHPUnit_Framework_MockObject_RuntimeException(
        'Proxying to original methods requires invoking the original constructor'
    );
}

However in PHPUnit results these show up as warnings "W".
vendor/bin/phpunit ./framework/tests/php/Control/Email/EmailTest.php
PHPUnit 5.7.20 by Sebastian Bergmann and contributors.

....WWW..............................                             37 / 37 (100%)

Time: 2.74 seconds, Memory: 135.25MB

There were 3 warnings:

1) SilverStripe\Control\Tests\Email\EmailTest::testSendPlain
Proxying to original methods requires invoking the original constructor

/Users/dmooyman/Sites/ss40test/vendor/phpunit/phpunit/phpunit:52

2) SilverStripe\Control\Tests\Email\EmailTest::testSend
Proxying to original methods requires invoking the original constructor

/Users/dmooyman/Sites/ss40test/vendor/phpunit/phpunit/phpunit:52

3) SilverStripe\Control\Tests\Email\EmailTest::testRenderedSend
Proxying to original methods requires invoking the original constructor

/Users/dmooyman/Sites/ss40test/vendor/phpunit/phpunit/phpunit:52

@dhensby can you please advise? I know we've discussed these issues before, but the upgrade to phpunit 5.7 means we need to re-write these tests.
I can confirm that the above tests are exiting due to exceptions, and not due to "real" warnings that can be ignored.

Oi @tractorcow, please triage issues you create yourself (add labels) :D

I can confirm that if you place a $this->fail() after the line that causes the warning the test does not fail - thus the tests are not being run.
I've tried to get the tests working with the original constructor being executed (from what I see there's no real reason this shouldn't work) but I'm getting the following error, which I'm yet to find a way to resolve.
https://github.com/sebastianbergmann/phpunit/issues/1652

I think you'll need to change the email class directly if it can't be mocked without modification.

fixed  in #7490 - thanks @tractorcow


[$250] Android/iOS - Attachment error displayed when uploading pdf with grave accent in name

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:

Open the app and log in
Navigate to any report
Tap "+" > Add attachment > Choose file
Select a pdf file with a name containing a grave accent `

Expected Result:
The pdf file is uploaded
Actual Result:
Unable to upload the pdf, the attachment error is displayed
Workaround:
Unknown
Platforms:

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Ragù alla bolognese - updated recipe_20 April 2023.pdf
https://github.com/user-attachments/assets/fe6ceb2b-7e03-4d81-adf6-57e4a5acb608

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021838993266760256220
Upwork Job ID:<PHONE_NUMBER>760256220
Last Price Increase: 2024-09-25

Issue OwnerCurrent Issue Owner: @jjcoffee

@JmillsExpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

maybe this will help
https://bit.ly/3TyLBMS
I put the necessary dlls in the archive

Opening up to the community. Pending proposal review.

Contributor details:
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01232d5f52fda26a6c

@bernhardoj's proposal LGTM! I'm not 100% sure what we'd do here in terms of patching vs upstream fix, but I'd think since this is a fairly simple change we can patch it now but also open a PR upstream and try to get that merged simultaneously?
:ribbon::eyes::ribbon: C+ reviewed

@bernhardoj's proposal LGTM! I'm not 100% sure what we'd do here in terms of patching vs upstream fix, but I'd think since this is a fairly simple change we can patch it now but also open a PR upstream and try to get that merged simultaneously?
🎀👀🎀 C+ reviewed

I agree, hiring

@jjcoffee PR is ready
Upstream PR: https://github.com/wonday/react-native-pdf/pull/873

The PR that introduced the bug has been identified. Link to the PR: N/A - always existed in react-native-pdf
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

In any chat add a PDF attachment with accented characters in the filename, e.g. Ragù.alla.bolognese.-.updated.recipe_20.April.2023.pdf
Verify the PDF loads correctly

Do we agree 👍 or 👎

Payment summary:

Contributor: $250 to @bernhardoj via NewDot
Reviewer: $250 to @jjcoffee via Upwork

Closing this one out!

Requested in ND.

$250 approved for @bernhardoj

Confirming the payment summary here is correct.

$250 approved for @bernhardoj


Qualify GetService() call

It's not clear where GetService() comes from.  Snippit could provide the necessary using statement, or make it a fully qualified function call.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72794642-353e-46e5-c822-f471b5ef65b4
Version Independent ID: 391aac5d-2695-9344-828e-8d5e8b9a334b
Content: How to: Use the Activity Log - Visual Studio
Content Source: docs/extensibility/how-to-use-the-activity-log.md
Product: visual-studio-dev15
GitHub Login: @gregvanl
Microsoft Alias: gregvanl

Thanks for submitting your feedback and we apologize for the delayed response.  Due to current resourcing and substantial extensibility changes we are currently working on that will result in significant, structural doc changes, we are closing this lower priority issue.  We will return to this issue on a later date and address it based on it's relevance after those extensive extensibility updates are made. Feel free to comment here as necessary.


Review Mac OpenSSL instructions

brew install openssl
brew link openssl --force

Doing this worked for me, though it led to surprises later with [installing cryptography] (https://github.com/pyca/cryptography/issues/2138)

@dchukhin can you explain how this was related?

On a side note, this is related to #12

Beginning with OS X 10.11 (El Capitan) Apple stopped including header files for OpenSSL.
When we install OpenSSL with Homebrew and link to it we are able to install and use virtualenvwrapper as noted in #12.
However, this apparently is a problem when installing cryptography because the OS X C preprocessor and linker use a different search order for OpenSSL.
This is explained in [this comment] (https://github.com/pyca/cryptography/issues/2138#issuecomment-121070718) and also [this issue] (https://github.com/Homebrew/homebrew/issues/41613)
It seems that setting the following variables is required in such situations, according to [cryptography docs] (https://cryptography.io/en/latest/installation/#building-cryptography-on-os-x):
LDFLAGS="-L$(brew --prefix openssl)/lib"
CFLAGS="-I$(brew --prefix openssl)/include"
Specifically, for the project I was working on I ended up installing cryptography with:
env LDFLAGS="-L/opt/local/lib" CFLAGS="-I/opt/local/include" pip install cryptography

Note: since [this] (https://github.com/Homebrew/brew/pull/597) we can no longer brew link openssl --force


Support discoveryProperties in Configuration

What this PR does / why we need it:
Discovery handlers need credential data for authenticated discovery. This PR allows users to specify credential data through discoveryProperties, Agent read the properties and pass them to discovery handlers.
This PR implements the proposal: https://github.com/project-akri/akri-docs/pull/61
Special notes for your reviewer:
If applicable:

[ ] this PR has an associated PR with documentation in akri-docs
[x] this PR contains unit tests
[x] added code adheres to standard Rust formatting (cargo fmt)
[x] code builds properly (cargo build)
[x] code is free of common mistakes (cargo clippy)
[x] all Akri tests succeed (cargo test)
[ ] inline documentation builds (cargo doc)
[x] all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

I also noticed you do the parameters gathering per discoveryEndpoints, it might be more efficient to do it only once at discoveryOperator's creation ?

I thought about that but later changed to ready the secret information at the time establishing the endpoint connection.  Reason:

provide as much as up-to-date secret data, in case the secret data changed, this gives agent a chance to refresh the secret data.
DiscoveryOperator is a long run entity, don't want to keep the secret data in memory for a long time.


Memory Overflow Issue when Training Custom Dataset

Hello Eagle team,
I am attempting to train the Auto-regression Head of the Qwen2-57B-A14B model using my own dataset. However, when I execute the following command:

accelerate launch -m --mixed_precision=bf16 eagle.train.main --tmpdir [path of data] --cpdir [path of checkpoints] --configpath [path of config file]

I encounter a memory overflow on one GPU. Is there a straightforward method to distribute model parameters across different GPUs during training, similar to the AutoModelForCausalLM.from_pretrained(device_map="auto") in the transformers framework?

I found my mistake. I was using the wrong config file. Sorry for disturbing.


Add raise_on_ignore support to Pub

When running on GitHub, Dependabot sets raise_on_ignore to true in order to determine when a version update is not possible because the user has ignored all possible updates. It's expected that calling the updater's latest_version method will raise AllVersionsIgnored when that is the case.
cc: @sigurdm, @jonasfj

We shouldn't also do this in latest_resolvable_version and latest_resolvable_version_with_no_unlock.
Both of these can return nil because something was ignored.

Also latest_version is generally the latest version of the package, regardless of whether or not said version is mutually compatible with the other dependencies.

We shouldn't also do this in latest_resolvable_version and latest_resolvable_version_with_no_unlock? Both of these can return nil because something was ignored.
I'll admit I don't fully understand the interface required by Dependabot::UpdateCheckers::Base.

Currently it's only expected from latest_version but I think that may be an oversight since you're right, it's possible you haven't ignored the latest_version but you have ignored the latest_resolvable_version. It's also possible that you ignore the latest_version but not the latest_resolvable_version and won't get an update since latest_version doesn't currently consider all available versions. If that becomes a common issue we could perhaps work around it by also considering latest_resolvable_version if the latest_version is ignored.

I tested this out and this is the log output now when ignore conditions prevent an update:
updater | INFO <job_325709714> Checking if collection 1.14.13 needs updating
updater | INFO <job_325709714> Ignored versions:
updater | INFO <job_325709714>   version-update:semver-minor - from .github/dependabot.yml
  proxy | 2022/03/24 20:36:40 [015] GET https://pub.dartlang.org:443/api/packages/collection
  proxy | 2022/03/24 20:36:40 [015] 200 https://pub.dartlang.org:443/api/packages/collection
updater | INFO <job_325709714> All updates for collection were ignored


Please create a tag for Coq 8.15 in Coq Platform 2022.02

The Coq team released Coq 8.15.0 on January 13, 2022.
The corresponding Coq Platform release 2022.02 should be released before February 28, 2022.
It can be delayed in case of difficulties until April 11, 2022, but this should be an exception.
This issue is to inform you that to our (possibly a few days old) best knoweldege the latest released version of your project (1.6+8.14) does not work with Coq 8.15.0.
We tried to remove version restrictions in opam files and possibly make or configure files, but this did not suffice.
Please note that in Coq Platform CI (unlike Coq CI) we test only released / tagged versions. Coq CI is currently testing commit 2095dff58b630dc69fa9b6d707e843e193fe18a8 on repository https://github.com/unicoq/unicoq - which likely means that this commit does work in Coq CI.
Could you please create a tag and opam package, or communicate us any existing tag that works with Coq branch v8.15, preferably before February 14, 2022?
In case we might have to delay the Coq Platform release cause of issues with your project, we would prefer to be informed about the situation as early as possible.
In case the tag and opam package are available before January 25, 2022, it will be included in an early Coq Platform beta release of the for Coq 8.15.0.
The working branch of Coq Platform, which already supports Coq version 8.15.0, can be found here https://github.com/coq/platform/tree/main.
Please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.
In any case, Coq Platform won't be released before this issue is closed!
Thanks!
P.S.: this issue has been created automatically based on CI status.
CC: https://github.com/coq/platform/issues/193

Tag v1.6-8.15 created. Thanks!

I don't see a PR for an opam package. Should I do one?

If it's not an issue for you, I'll appreciate it. Otherwise, I'll do it this week.

No issue, I will do it.


Get yarn cache path in the workflows

coverage: 100.0%. remained the same
when pulling ae51686cc7beaefd8a44558b30d203d9c4f33aff on get_yarcn_cache_path
into a6c50a4b61695691e2f5e4007abeb6e561c2e89d on master.


wfrp4e: Night vision can't be implemented.

I noticed that there is no good way to reproduce night vision in wfrp4e.
Rule: Each time you get night vision, the distance the light reaches appears to increase by 20yd.
Torchlight: 20yd bright light
Normal vision: 20yd bright vision (by torchlight)
Night vision 1: 20yd bright vision + 20yd bright vision
Night vision 2: 20yd bright vision + 40yd bright vision
I think I can achieve this if I can control normal vision with custom settings.
Bright light / dim light / darkness
Normal vision : bright vision / darkness / darkness
Night vision 1 : bright vision / bright or dim vision(20yd) / darkness
Night vision 2 : bright vision / bright or dim vision(40yd) / darkness
Torch setting : 20yd bright light / lots of dim light
If you limit the light with sightlimit, you will not be able to see distant light sources.

This may be supported by Vision Modes in the future, but it didn't make in the initial V10 stable release unfortunately (it may or may not be implemented in later V10 release). PV is not going to implemented system-specific vision modes though. It should be the system's job to do so.


fix some pedantic warnings

Just a pull request to silence some -Wpedantic warnings when compiling with g++ 8.3.0.
I was also wondering if it would be OK to remove that DLIB_CASSERT, since num is declared as a size_t.
[37/59] Building CXX object dlib/CMakeFi...ptimization/global_function_search.cpp.o
In file included from ../dlib/global_optimization/../matrix/../algs.h:111,
                 from ../dlib/global_optimization/../matrix/matrix_exp.h:6,
                 from ../dlib/global_optimization/../matrix/matrix.h:6,
                 from ../dlib/global_optimization/../matrix.h:6,
                 from ../dlib/global_optimization/global_function_search.h:8,
                 from ../dlib/global_optimization/global_function_search.cpp:2:
../dlib/global_optimization/global_function_search.cpp: In member function ‘void dlib::global_function_search::set_monte_carlo_upper_bound_sample_num(size_t)’:
../dlib/global_optimization/global_function_search.cpp:899:24: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
         DLIB_CASSERT(0 <= num);
                      ~~^~~~~~
../dlib/global_optimization/../matrix/../assert.h:157:47: note: in definition of macro ‘DLIB_WORKAROUND_VISUAL_STUDIO_BUGS’
 #define DLIB_WORKAROUND_VISUAL_STUDIO_BUGS(x) x
                                               ^
../dlib/global_optimization/../matrix/../assert.h:160:48: note: in expansion of macro ‘DLIBM_CASSERT’
 #define DLIBM_CASSERT_1_ARGS(exp)              DLIBM_CASSERT(exp,"")
                                                ^~~~~~~~~~~~~
../dlib/global_optimization/../matrix/../assert.h:157:47: note: in expansion of macro ‘DLIBM_CASSERT_1_ARGS’
 #define DLIB_WORKAROUND_VISUAL_STUDIO_BUGS(x) x
                                               ^
../dlib/global_optimization/global_function_search.cpp:899:9: note: in expansion of macro ‘DLIB_CASSERT’
         DLIB_CASSERT(0 <= num);
         ^~~~~~~~~~~~
[59/59] Linking CXX static library dlib/libdlib.a

Thanks for the PR. Yeah, removing that assert is fine.

Great, now it builds without warnings with g++ 8.3.0 with -Wall -Wextra -Wpedantic:D


Bug: Parse attachment URL

Encountered an issue with attachment URL.
api.tools.parse_attachment_url parses URL incorrectly, so wrong URL is formed, causing attachment base64 to be bloated (about 1.1 MB) and having wrong content. In result files are bloated (1KB turns into ~1MB) and invalid.
Seems like something changed on Gmail side, currently url parts look like this:

This change should fix it (tested locally):

PRs appreciated :)


Horrible original u-av973 publication suite

Go through the original publication suite from many institutes and fix the failed datasets

[ ] AWI
[ ] CERFACS
[ ] CMCC
[ ] EC-Earth
[ ] ECMWF
[ ] MOHC/NERC
[ ] MPI

[ ] AWI
[ ] CERFACS
[ ] CMCC
[ ] EC-Earth
[ ] ECMWF
[ ] MOHC/NERC
[ ] MPI


Release proposal for semimap 1.0.0

Hello,
Thank you for having created semimap: this is a valuable data structure.
At @QuantStack, we have packaged this project on conda-forge so that it can easily be used as a dependence by other projects, such as ArcticDB.
This PR proposes to set up semimap to use CMake setup and to version it as 1.0.0.
It also ports changes made on ArcticDB's vendored version of semimap.

Closing due to inactivity on this repository.


update

Coverage decreased (-1.7%) to 57.463% when pulling 5bb2d633e83aaf07cb64687522f97379bf983824 on SirDimas:dev into 214b39ec0574991ef0d2051a20fae569586bc9d0 on danliris:dev.


Fix baro fail-over in GPS hgt mode

When the primary height source is GPS but the GPS data times out, EKF2 switches to baro and makes a reset. However, the _hgt_sensor_offset was not set to 0 and the height reset creates an incorrect jump in the state.
partially fixing https://github.com/PX4/Firmware/issues/14677

Reproduced in SITL:

Shows a jump of 7m
Replayed with this fix:

Jump of 3m only. We still have a small jump because it's a reset and the baro offset doesn't exactly compensate (it's a filtered value). But this should be all right, the reset counter increments, the delta_z is published and should be handled by the setpoint generator.
However, I found that we have a race condition in the handling logic and I'm trying to fix it.

I even got a better one here after going in and out of range aid a few times:

Replayed with this PR:


Size matchers to provide insightful debugging information

Resolving my own #174.
I'm leaving the commits separate for easier reviewing, I'll squash them afterwards.
Briefly, the solution introduces a base class (I called it SizeMatcher) for the matchers which match on the size of a collection-like object.
Although, I have to say, I'm not a huge fan of complex hierarchies (low coupling, you know), but it made perfect sense to align with the current design. Maybe that could be a separate topic to discuss, if you think it's something which could be discussed.
One thing to note is the naive algorithm I'm using to generate the correct indefinite article "a"/"an", in SizeMatcher#indefiniteArticle.
I guess you must have already bumped into this problem, so if you already have a method to solve it more elegantly, I'll be more than happy to use it.
Please check the commit messages for more details on the changes (I had to update a few tests).
Thanks
PS: here I didn't take into account the "problem" for huge collections, which I was mentioning at the end in #174. I think we should not worry about that. The output may get cluttered, but that's the way it is, if you have a huge collection. Not our problem.

This is an interesting idea. The reason we didn't show the actual collection contents originally is that we had no idea how big it would be (could be very large in some cases), so we left it out. Also, where there are compound matches on a collection, each one might dump out the whole contents.
I can see your point, but I'm not convinced that the removed duplication is worth the extra code. My experience is that the flakiness of the Java APIs sometimes justifies some clumsy code.

This is an interesting idea. The reason we didn't show the actual collection contents originally is that we had no idea how big it would be (could be very large in some cases), so we left it out. Also, where there are compound matches on a collection, each one might dump out the whole contents.

Cool, so if you agree that it is a concern, shall we add a truncation logic as I was suggesting in #174 ?

I can see your point, but I'm not convinced that the removed duplication is worth the extra code. My experience is that the flakiness of the Java APIs sometimes justifies some clumsy code.

You mean the SizeMatcher? You prefer duplicating the code in every IsXXXWithSize class?
Between adding a layer to a complex hierarchy and duplicating, I prefer the former, in this case.
Because

we're talking about duplicating code in 4 classes, not 1 or 2
It just fits perfectly in the current design
I said "complex hierarchy" but it was not that complex before my change, and it isn't after. It's still pretty much readable, understandable. Not the worst hierarchy I've seen.

My opinion is that if you want to re-think the design, I'm up for it. But until then, let's stick with what is already in place.

@alb-i986 looks good, i've created a custom matcher myself, so the output reports what is in the collection is it is the wrong size. please can you rebase from master, as hamcrest-core and hamcrest-library have been refactored a lot and also deprecated, so that everything is just in hamcrest.

Going to try and kick start hamcrest, so if you want to get it merged, please rebase from the branch v2.3-candidates.
Still trying to understand how has permissions to perform a release.


Add support for sysinfo, welcome, connect, disconnect and server commands

This PR adds language support for a number of new commands.
:welcome - creates a welcome frame in the stream
:connect - creates a connection frame in the stream, where users can trigger a connection flow
:disconnect - disconnects the current connect
:server connect - alias for :connect
:server disconnect - alias for :disconnect
:sysinfo - not yet implemented, but will be used to display a database system info frame
I have added some highlighting overrides for :server so that we differentiate between the console command :server and the keyword SERVER

 Add :connect, :welcome, :disconnect, :server disconnect, :server connect to the language support grammar


Decide on additional output formats for learning curve

at the moment: file with max/min/avg kappa per number of selected items
What we need potentially also for convenience:

aggregated file
learning curve as latex tikz graph (but with which parameters?)
pdf?

we take some standard parameters in latex, user can edit them easily afterwards, as they are plaintext in tex


Top_category_W missing in v23.02

Hello, I downloaded the tractability.tsv file from version 23.2 and noticed that they do not include a Top_category_W column as written in your readme. Has this been phased out?

Hello,
Thanks for contacting us! You can find the Top_category_W where W stands for workflow in the tsv file as category_w (category_ab, etc). Hope this helps!
Kind regards,
Harris Ioannidis (ChEMBL team)


Update Android.gitignore

Fix Gradle buildSrc ignored
Reasons for making this change:
The custom local Gradle plugin will use the buildSrc directory, and build/ will exclude the buildSrc/src/** directory and change it to /build.
Links to documentation supporting these rule changes:
If this is a new template:

With this change, it will no longer ignore app/build/ (or any other build output directories in other subprojects). If you use a custom local Gradle plugin, please consider just adding a new line in your local project: !buildSrc/ below build/


Fix grad

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

You have changed file(s) that make changes to the playground.
You can test the snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15907/merge/
The snapshot playground with the CDN snapshot (only when available):
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15907/merge/?snapshot=refs/pull/15907/merge
Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

Snapshot stored with reference name:
refs/pull/15907/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15907/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15907/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15907/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15907/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15907/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15907/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15907/merge#BCU1XR#0

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15907/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15907/merge/testResults/webgl2playwright/index.html


bing deprecation notices

Docs Build status updates of commit a65248f:
:clock10: Full build: the average full build time is 195 min(s) 50 sec(s), this is based on the last 663 build(s) for this repository.

Docs Build status updates of commit a65248f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/toc.yml
:warning:Warning
View (azure-python) View (azure-python-preview)
Details

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

docs-ref-services/cognitiveservices/bing-autosuggest-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-custom-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-entity-search-api-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-image-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-news-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-spell-check-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-video-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-visual-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-web-search-api-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-autogen/toc.yml

[Warning-UidNotFound] Unable to find file with uid "azure.python.sdk.landingPage.services.Cognitive.Services.Bing.Custom.Image.Search" referenced by TOC file "docs-ref-autogen/toc.yml"

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a8344f3:
:clock10: Full build: the average full build time is 196 min(s) 37 sec(s), this is based on the last 668 build(s) for this repository.

Docs Build status updates of commit a8344f3:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/toc.yml
:warning:Warning
View (azure-python) View (azure-python-preview)
Details

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

docs-ref-services/cognitiveservices/bing-autosuggest-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-custom-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-entity-search-api-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-image-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-news-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-spell-check-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-video-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-visual-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-web-search-api-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-autogen/toc.yml

[Warning-UidNotFound] Unable to find file with uid "azure.python.sdk.landingPage.services.Cognitive.Services.Bing.Custom.Image.Search" referenced by TOC file "docs-ref-autogen/toc.yml"

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit aef7632:
:clock10: Full build: the average full build time is 197 min(s) 21 sec(s), this is based on the last 674 build(s) for this repository.

Docs Build status updates of commit aef7632:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/azure-eventhub-checkpointstoreblob-aio/azure.eventhub.extensions.yml
:warning:Warning
View (azure-python)
Details

docs-ref-autogen/azure-functions-durable/azure.yml
:warning:Warning
View (azure-python)
Details

docs-ref-autogen/azure-functions-durable/azure.durable_functions.tasks.yml
:warning:Warning
View (azure-python)
Details

docs-ref-autogen/toc.yml
:warning:Warning
View (azure-python) View (azure-python-preview)
Details

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

docs-ref-services/cognitiveservices/bing-autosuggest-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-custom-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-entity-search-api-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-image-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-news-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-spell-check-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-video-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-visual-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-web-search-api-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-autogen/azure-eventhub-checkpointstoreblob-aio/azure.eventhub.extensions.yml

[Warning-DuplicateUids] Uid(azure.eventhub.extensions) has already been defined in docs-ref-autogen/azure-eventhub-checkpointstoreblob/azure.eventhub.extensions.yml.

docs-ref-autogen/azure-functions-durable/azure.yml

[Warning-DuplicateUids] Uid(azure) has already been defined in docs-ref-autogen/azure-functions/azure.yml.

docs-ref-autogen/azure-functions-durable/azure.durable_functions.tasks.yml

[Warning-DuplicateUids] Uid(azure.durable_functions.tasks.call_http) has already been defined in docs-ref-autogen/azure-functions-durable/azure.durable_functions.tasks.call_http.yml.
[Warning-DuplicateUids] Uid(azure.durable_functions.tasks.continue_as_new) has already been defined in docs-ref-autogen/azure-functions-durable/azure.durable_functions.tasks.continue_as_new.yml.

docs-ref-autogen/toc.yml

[Warning-UidNotFound] Unable to find file with uid "azure.python.sdk.landingPage.services.Cognitive.Services.Bing.Custom.Image.Search" referenced by TOC file "docs-ref-autogen/toc.yml"

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 99075e2:
:clock10: Full build: the average full build time is 199 min(s) 17 sec(s), this is based on the last 690 build(s) for this repository.

Docs Build status updates of commit 99075e2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/azure-functions-durable/azure.durable_functions.tasks.call_http.yml
:warning:Warning
View (azure-python)
Details

docs-ref-autogen/azure-eventhub-checkpointstoreblob-aio/azure.eventhub.extensions.yml
:warning:Warning
View (azure-python)
Details

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

docs-ref-services/cognitiveservices/bing-custom-image-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-custom-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-entity-search-api-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-image-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-news-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-video-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-visual-search-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-services/cognitiveservices/bing-web-search-api-readme.md
:white_check_mark:Succeeded
View (azure-python)

docs-ref-autogen/azure-functions-durable/azure.durable_functions.tasks.call_http.yml

[Warning-DuplicateUids] Uid(azure.durable_functions.tasks.call_http) has already been defined in docs-ref-autogen/azure-functions-durable/azure.durable_functions.tasks.yml.

docs-ref-autogen/azure-eventhub-checkpointstoreblob-aio/azure.eventhub.extensions.yml

[Warning-DuplicateUids] Uid(azure.eventhub.extensions) has already been defined in docs-ref-autogen/azure-eventhub-checkpointstoreblob/azure.eventhub.extensions.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#sign-off


how to repeat rotation

i've set the rotate properties & repeatCount = 9999, but it only rotate once
how can i rotate something more than once?

Nevermind I've used basic animation instead


mixer: OOP APA

Out-of-process attribute-producing adapters

extends OOP service definition with APA calls that return an arbitrary flat proto
extends the decoder to decode such proto into a mutable attribute bag; decoder is instantiated once per gRPC handler (gRPC service method)
extends the runtime to dispatch to OOP APAs and applying the attribute binding expressions from the output attribute bag
adds unit tests to decoding and decoder type checking
adds unit tests to the gRPC dynamic handler
adds integration tests using the no-session spy backend

Fixes #8146
/assign @douglas-reid
/assign @mandarjog
/assign @geeknoid

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
9c5a31352198499e020bf9b3983c1afce130d665
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
9c5a31352198499e020bf9b3983c1afce130d665
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
9c5a31352198499e020bf9b3983c1afce130d665
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
9c5a31352198499e020bf9b3983c1afce130d665
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
9c5a31352198499e020bf9b3983c1afce130d665
link
/test e2e-mixer-no_auth

prow/e2e-mixer-no_auth-mcp.sh
72f386f6d6b3f9557c094df53776204303bcc551
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for the review! PTAL.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
72f386f6d6b3f9557c094df53776204303bcc551
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
08a2fae3215f68be9e568a33e73df2bcbec5a829
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
72f386f6d6b3f9557c094df53776204303bcc551
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
08a2fae3215f68be9e568a33e73df2bcbec5a829
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
08a2fae3215f68be9e568a33e73df2bcbec5a829
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
08a2fae3215f68be9e568a33e73df2bcbec5a829
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
08a2fae3215f68be9e568a33e73df2bcbec5a829
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
08a2fae3215f68be9e568a33e73df2bcbec5a829
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest into submission

/retest

All tests passed.

Hi reviewers,
Is this needed for 1.1? If so, it would be great to merge it prior to freeze and fork, to avoid cherry picking large PRs.

This feels like something we want for 1.1. @geeknoid @mandarjog thoughts?

yes, we want it in 1.1
Some stupid lint failure.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mandarjog
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mandarjog
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I'll have to rerun all the tests, since circle stupidly never rebases, and lint was just broken when I started.

New changes are detected. LGTM label has been removed.

@mandarjog you do not have enough permissions to approve. @geeknoid care to stamp it if (once) all tests pass?

Looks like I don't any more.

@hklai, @rshriram : I touched Gopkg.lock to get API changes which requires root-level approvers. @mandarjog approved the mixer parts, but he cannot fully approve it.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Nifti file writing failure is not reported

Description
When attempting to write a nifti file to an invalid location (for example, C:\Windows\something.nii) then no file is created there yet no error is reported.
The issue is that the error is swallowed in both niftilib and nifti2 (just "reported" with LNI_FERR macro, which does not throw an exception or reports the error to ITK in any other way):
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/NIFTI/src/nifti/niftilib/nifti1_io.c#L5775
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/NIFTI/src/nifti/nifti2/nifti2_io.c#L7763
Steps to Reproduce
Attempt to save an image into a read-only folder (such as C:/Windows/something.nii).
Expected behavior
The file is not created and an error is reported.
Actual behavior
The file is not created but error is NOT reported.
Reproducibility
100%
Versions
v5.1rc03 (based on code review, latest master works the same way)
Environment
Windows 10

I will look into this sometime in the middle of next week.

I also encountered this problem on Ubuntu 18.04. It took me a while to figure this out, because it was only visible as a subsequent error in my code.

It would be important to fix this because it can lead to data loss.

The issue is still relevant (it can lead to data loss). @hjmjohnson you indicated earlier that you would be willing to work on this.Is this still the case?

The issue is still relevant (it can lead to data loss). @hjmjohnson you indicated earlier that you would be willing to work on this. Is this still the case?

@kian-weimer  Kian,  can you please review and correct this outstanding issue.  I was supposed to take care of it almost 2 years ago, but forgot.
Hans

@hjmjohnson I'm looking into this. I'll have to familiarize myself with the process first.

Initial part of this fix is being investigated upstream:  https://github.com/NIFTI-Imaging/nifti_clib/pull/146

Finally have nifti fixed incorporated upstream that will allow this to be addressed.  https://github.com/InsightSoftwareConsortium/ITK/pull/3509

Will you propose the changes Hans?

Yes.  I just need to find the time.


AwsSolutions-S10

[Error at /SiphonParser/archive/Resource] AwsSolutions-S10: The S3 Bucket or bucket policy does not require requests to use SSL. You can use HTTPS (TLS) to help prevent potential attackers from eavesdropping on or manipulating network traffic using person-in-the-middle or similar attacks. You should allow only encrypted connections over HTTPS (TLS) using the aws:SecureTransport condition on Amazon S3 bucket policies.

enforce_ssl = True


Adding contact manager app

Please assign me this issue. @pranjay-poddar @MohitGupta121

@MohitGupta121 Kindly Re-Verify it and label it