Add private Link Scope for Azure Arc

Add private Link Scope for Azure Arc
Before selecting the "Create pull request" button:

Enter a meaningful title above^, using a prefix if necessary and keywords "New" or "Update" indicating the nature of changes.

Describe the summary, scope, and intent of this PR:
Add private Link Scope for Azure Arc

Insert links(s) to any related work item(s) or supporting detail:
](https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/privatelinkscopes?pivots=deployment-language-bicep)

AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.
These are common guidelines for contributions across the repos managed by the Cloud Architecture Content Team (CACT). Some repositories may have additional specific requirements that are not listed here.
Guidance for all contributors

Topic
Guidance

Draft PR
If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.

ms.date metadata
Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.

Placement and linking
If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).

PR build
After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.

Publishing
Following a successful merge, most repos publish to the live site at least once per (business) day, usually around 10am Pacific.

Additional resources
Learn.Microsoft.Com contributor guide

Additional guidance for private repos and internal contributors

Topic
Guidance

PR size
If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/Contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.

PR title prefix
Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:[Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)[LinkFix] - recurring/adhoc PRs to correct link URLs[Pipeline] - new/updated contributor success pipeline content[WIP] - a work-in-progress draft requiring several days/weeks

PR preview
Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.

PR sign-off (public repo)
If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.

PR sign-off (private repo)
After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.Your PR may be selected for initial review by the CACT. Following CACT review, you may receive questions or requests for additional changes. You should have initial feedback from CACT review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers in your PR and someone will get back to you. After CACT review is complete, a CACT #sign-off will be added.Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).

Additional resources
Learn.Microsoft.Com internal contributor guideAuthoring templates: architecture-center-pr, well-architected-prTo contact the CACT use e-mail, or @mention our GitHub team in your PR comments using: @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers

@stephen-sumner
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Also, is this a duplicate of #1319?

Seeing as the feedback hasn't been addressed yet, I'm going to go ahead and close this PR.  If you'd like to still contribute, please reopen and address the feedback.  Thanks!
#please-close

No this PR is not a Duplicate of https://github.com/MicrosoftDocs/cloud-adoption-framework/pull/1319 as in 1319 it's about Azure Monitor Private Link Scope in my PR i'ts about Azure Arc Private Link Scope.


Updating lucid version imported in a notebook

Pull Request Test Coverage Report for Build 509

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.631%

Totals

Change from base Build 505:
0.0%

Covered Lines:
1645

Relevant Lines:
2119

💛  - Coveralls

@googlebot I signed it already!


Camera calibration for the image set?

Hi hi!
Is the camera calibration generated by this process available for these images?

@cdw I can update the repo this week with that information. It's important to note that the data will be specific to the device that took the photos (every device has different values) and cannot be generalized across devices.
Speak soon!

@cdw Here is the calibration data- does this work for what you are trying to do?

Name
Value

Camera offset X
50

Camera offset Y
100

Origin location
Top right

Pixel coordinate scale
0.555

Camera rotation
83.23

Thanks @RickCarlino! This is certainly useful! What I thought might be present was a camera calibration matrix of the kind described here. These contain camera focal length and distortion measurements. Typically you calculate them from a set of images of a calibration image like the one on FarmBot's calibration card or a checkerboard card.
If that isn't part of the current calibration process, we could generate them from, say, 7-10 images of the calibration card in a couple of different orientations and tilts. Here is an example of a set of images. This let's you get better or more accurate 3d reconstruction with the traditional photogrammetry approach. Want to try to capture them?

Sure, I can do a circle around the calibration card and snap some photos if you would like. Doing tilts would be tricky since the camera is bolted to the tool mount. I will post them in the next few days. Speak soon.

@cdw Quick update:
I went out to the garden this morning to take a circle of photos around the calibration card. Unfortunately, it was too sunny. I am going to take the photos again at night (FarmBot has an LED strip).
I forgot to ask: do you need X/Y/ground distance labels for this data set?

@RickCarlino Excellent! I don't need X/Y/ground distance labels. But what would be great is if you can do it with the card propped up in a few orientations. Maybe with a rock under a couple of corners? That will simulate the tilting and let me do the calibration. I tested out the OpenCV workflow with some images from a cheap borescope camera I have locally and it seems to work.
Absolutely no hurry on any of this btw :-) It can totally wait a week or what have you.

How do these look, @cdw ? Unfortunately, it's not a very wide angle lens:

Whoops- Just realized I had a setting enabled that added some cropping to the images. Let me take another set of images without that setting enabled.

Hi @RickCarlino! I set up everything to work with this camera and this card over here. It works, but that likely isn't a good calibration because there isn't much change in the plane of the calibration card and it doesn't cover enough of the image sensor. What you ideally want is thorough coverage of the field of view (as visualized by the detected point plot in the gist) and in/out of plane variation to capture different distortions.
All that said, this doesn't look to have too much distortion! We can try out various approaches assuming zero distortion and shoo for a fully calibrated system later.


Password strength gauge stimulus

This builds on #3219 addressing #3197 and #3223
More importantly includes a refactor of the password gauge functionality to Stimulus.
There's a few decisions I made around the ability to compose components using JS "mixins" which I'm not sure it's "idiomatic Stimulus" if there is such a thing. Here's three captures of the end results in three areas:

Reset password:

Register:

Update password:

Hopefully it makes sense and we can move forwards with Stimulus using this pattern.

Also, thank you for tackling this!

I've updated this to a much simpler approach of adding multiple controllers to the form.
I feel like some lines are getting a big too wide to read comfortably. I'd be in favor of something like:
{{ form.password_confirm(
    placeholder="Confirm password",
    required="required",
    class_="form-group__input",
    data_target="password.password password-match.passwordMatch",
    data_action="keyup->password-match#checkPasswordsMatch") }}

Would we consider disabling the template linting rule around single line echo statements to allow that?

@yeraydiazdiaz I think that'd be fine.

Seems it's not something we can disable in the html_lint command line 😞


Make it possible to log to a custom file with the LogSender

Reporter
Jaco de Groot
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Make it possible to log to a custom file with the LogSender. Currently the LogSender always writes the info to the default Frank! logfile. But in case you need to do "heartbeat logging" from your adapter you don't want to pollute the default logfile. You would like te specify a diffent logfile like frank2example-myheartbeat.log. It would also be nice to be able to specify some log4j properties like the pattern layout, file rotation and file size.
Describe alternatives you've considered

Have the Frank! developer write a custom log4j4ibis.xml but this will lead to problems in the future when changes are done on this file on framework level and the Frank! developer doesn't update his custom log4j4ibis.xml.

Use the FileSender. But this needs too much configuration for a simple job, for example (doing only a poor mans file rotation):
 	<pipe className="nl.nn.adapterframework.pipes.PutSystemDateInSession" dateFormat="yyyy-MM-dd HH:mm:ss" name="GlobalDateTime" sessionKey="dateTimeStamp">
 		<forward name="success" path="renameOrAddTofile"/>
 	</pipe>

 	<pipe className="nl.nn.adapterframework.pipes.XmlSwitch" getInputFromFixedValue="<dummy/>" name="renameOrAddTofile" serviceSelectionStylesheetFilename="ExceptionLogCount/xsl/checkTime.xsl">
 		<param name="dateTimeStamp" sessionKey="dateTimeStamp"/>

 		<forward name="rename" path="renameFile"/>
 		<forward name="write" path="writeFile"/>
 	</pipe>

 	<pipe className="nl.nn.adapterframework.pipes.MoveFilePipe" filename="${log.dir}/ija_tibet2-exceptionlogcount.log" getInputFromSessionKey="formatQuery" move2dir="${log.dir}" move2file="ija_tibet2-exceptionlogcount.log.1" name="renameFile" numberOfBackups="0" overwrite="yes">

 		<forward name="success" path="writeFile"/>
 	</pipe>

 	<pipe className="nl.nn.adapterframework.pipes.GenericMessageSendingPipe" getInputFromSessionKey="formatQuery" name="writeFile">
 		<sender actions="write_append" className="nl.nn.adapterframework.senders.FileSender" fileName="${query.log}"/>

 		<forward name="success" path="EXIT"/>
 	</pipe>

Additional context
-

You can use the LocalFileSystemPipe (or Sender) which has rotateDays and RotateSize attributes so you can keep appending to a file.

Ah, nice! That is enough for my situation, I now use the following:
		<LocalFileSystemPipe
			name="AppendToFile"
			root="${log.dir}"
			filename="${instance.name.lc}-errorstorecount.log"
			action="append"
			rotateSize="1048576"
			numberOfBackups="9"
			>
			<Forward name="success" path="EXIT"/>
		</LocalFileSystemPipe>


Sticky bandages issue

On the 1.20.1 fabric version, sticky bandages seem to have the same usage time as regular bandages. Tested without any additional mods other than the requirements. The 1.21.1 fabric version doesn't have this issue.

Fixed. Thanks for pointing it out.


moveit_robots: 1.0.7-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository moveit_robots to 1.0.7-0:

upstream repository: https://github.com/ros-planning/moveit_robots.git
release repository: https://github.com/tork-a/moveit_robots-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.23
previous version for package: 1.0.6-0

atlas_moveit_config

No changes

atlas_v3_moveit_config

No changes

baxter_ikfast_left_arm_plugin
* [fix] Added missing dependency on lapack and blas
* Contributors: Dave Coleman

baxter_ikfast_right_arm_plugin
* [fix] Added missing dependency on lapack and blas
* Contributors: Dave Coleman

baxter_moveit_config
* [enahancement] Add option not to launch db in baxter_moveit_config
* Contributors: Kentaro Wada

clam_moveit_config

No changes

iri_wam_moveit_config
* [fix] iri_wam: remove broken python install directives
* [capability] Adding Gazebo robot controller iri_wam_trajectory_controller
* [enhancement] updating configuration files and allowing trajectory execution (#36 <https://github.com/ros-planning/moveit_robots/issues/36>)
* Contributors: Michael Goerner, Sergi

moveit_robots

No changes

r2_moveit_generated

No changes

The branch names of the doc and source entries are not valid anymore.

Thanks for merging.
Minor note: I added a comment in the additional commit https://github.com/ros/rosdistro/pull/13220/commits/b52aa0450aa0042041f69a46edb7ef2c8dd3d52b that this PR could be squash-merged, but apparently that comment didn't come visible enough. I should've added a comment on this PR board instead. Sorry for the mess.

No worry, the history in this repo is not that relevant. Also the branch names were already wrong before your PR because the upstream repo was changed without changing these entries in the first place. So this PR didn't even create a temporary inconsistency.


Add markdown-tools extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi 👋
Could you please look into the CI errors and let me know if you need any help resolving them?

Is this ready for another review?

yes it is, please go through it. All checks passing


Update home page to only show high absences in current school year

Who is this PR for?
educators
What problem does this PR fix?
The home page suggests students with absences because they missed several days or withdrew from summer school.  This seems like it could be surprising on the first day of school for staff before students have started.
What does this PR do?
Caps the query for high absences if looking back 45 days would cross the school year boundary.  Doesn't update the UI code to reflect this (so it still looks like it's querying back 45 days).
Taking advantage of https://github.com/studentinsights/studentinsights/pull/2011.

selfie


Default duration of the new anim objs becomes zero.

Default duration of the new anim objs is set to 1 sec in anim-panel.js, but it is not correctly working in the current version.

Fixed.


Test no-std compatibility in CI

#2 added support for no-std environments. Wondering what's the best way to test this going forward to avoid regressions. Is this doable in CI?

I've read about the world of conditional compilation and no-std support / testing. Learnings / conclusions so far:

no_std is a special attribute. The current code adds #![cfg_attr(not(feature = "std"), no_std)] to the top of lib.rs. This means "if the feature std is not used, add the no_std attribute.
We define std as a default feature in Cargo.toml, which means in normal operations, std is set and the no_std attribute is not set.
This means bad news: an accidental use of println! in the current code wouldn't be caught until someone tried to use bls_on_arkworks in a no-std environment
To test no_std support I found a dedicated tool called cargo-nono: https://github.com/hobofan/cargo-nono
the more mature way to test no_std support is to target a platform with no access to standard library. See here for an example
This post advises to build an entirely separate crate to test no-std integration. This feels like the most correct and strict approach to me intuitively.
There is a lightweight way to test bls_on_arkworks builds with no_std: cargo build --no-default-features. This will remove the std feature, and trigger compilation. If compilation succeeds, we're good!

Experimenting with cargo-nono I found that it's not good enough to detect accidental insertions of std imports or macros. Specifically: cargo nono check --no-default-features succeeds even with a blatant println!("STD WAS HERE") in lib.rs.
On the other hand, cargo build --no-default-features caught this:
$ cargo build --no-default-features
   Compiling bls_on_arkworks v0.2.1 (/Users/arnaud/git/bls_on_arkworks)
error: cannot find macro `println` in this scope
  --> src/lib.rs:95:5
   |
95 |     println!("STD WAS HERE");
   |     ^^^^^^^

error: could not compile `bls_on_arkworks` due to previous error

I'm going with the simpler cargo build --no-default-features approach. It's not perfect because it doesn't actually test the code in a true no-std environment, but it'll certainly be enough to catch the mistakes I'm worried about. bls_on_arkworks doesn't have complex conditional compilation paths yet.


Resize Calendar View without redrawing/resetting/reloading data.

I'm the same project as previously closed issue 627.
Is there a way I can resize the calendarView, without changing the size of any of the underlying collection view cells, without the entire calendarView redrawing and resetting?
I have my calendar view in a split view next to a task list and from time to time the user will want to shrink or collapse the task list to get a better view of the calendar.  It will be more user friendly if I can "freeze" the calendar view in place during resize operation.  Make sense?

Ok, will check it out some more over the weekend.
I got a busy recently.

ok finally have a chance to get a good look at the question.
so when you shrink the calendar's frame, I understand that you do not want the calendar's cells to resize.
So can you explain how do you want the calendar to respond?
When the calendar's frame shrinks, you want the cells width/height to stay the same? This is the part i am unclear on.

I'll show screen shots it might be easier.
So I have the JTAppleCalendar in a container view, and I use it to schedule assignments for an education app by dragging and dropping from a tableview.  Problem is that when i resize the container view it always redraws the calendar which is an imperfect experience.
All I want to do is NOT redraw the calendar when i resize the container view.  This would be possible in a regular collection view as long as the contentSize is larger than the screen size.  I'm guessing it might have something to do with ViewWillLayoutSubviews being called on the superview resize but I'm not 100% sure. Make sense?
Before resize:
(Content Offset 600px / One month)

After resize:
(Content Offset 0px) but should be 600px
Calendar redrew and scrolled up to contentOffset = 0 when I want it to stay at 600px

hmm. a long time ago, i propably thought about this feature.
calendarView.allowsDateCellStretching = false
but since no one asked for it, I do not think i finished implementing it.
I can take a look to try. But this wont be completed soon as I am on other projects for a short while.
What you can do as a workaround is something like what this guy did with his JTAppleCalendar -> https://github.com/patchthecode/WLAppleCalendar
In his gif image you can see the calendar "resizing" and the cells are not redrawn.
How did he do it?
The bottom tableView is Above the calendar view. It has a NSLayoutConstraint set to the top of the viewController. Then he adjusts the size of that constraint to hide bottom portions of the calendar when needed. Can this technique word for you?
Its because of techniques like these that i think calendarView.allowsDateCellStretching = false might be unneeded. Let me know if this works for you.

Ill try that. Itll take some hit test rejiggering but it might work. I'll let you know how it turns out.

awesome. cool

it worked. Just had to rejigger some hit tests and constraints. Thanks.


Idea - Saving Schedules

This is just an idea for future additions, but the best thing in my opinion about the old (pre-CSearch) scheduler was the ability to star/save entire schedule layouts and to switch between them. Its good to figure out individual classes with your starring and ordering system, but it can take a long time if you are switching between two very different schedules based on a difficult-to-get class. Could you offer a way to save the state of the class order, stars, and disables to quickly switch between them?

Sure, this is not something I'm opposed to. At the moment, Hyperschedule is not really designed for the "schedule micromanagement" use case, but more rather for people who are fine with registering for any combination of their favorite classes. I don't see why in future it can't support both use cases.
Would only saving starred courses, rather than also selected courses, be sufficient?

Note that you can achieve this functionality by copying the JSON from the import/export modal to and from external files.

Implemented in the new version


Change round in Rabi to avoid numpy int64 data type

Summary
Change np.round(amp, decimals=6) to round(amp, ndigits=6) to avoid an error that occurs when scanning duration in Rabi.
Details and comments
The default usage of Rabi is to scan the amplitude. However, the Rabi experiment can also be done by giving integer durations as amplitudes and a schedule with parameterised duration. Currently, we get the error Object of type int64 is not JSON serializable when doing so, because np.round(amp, decimals=6) changes the duration from a type 'int' to type numpy.int64. The PR avoids this error by changing this line of code to round(amp, ndigits=6).
The Rabi experiment can later be improved to include the flexibility to scan duration instead of amplitude. In this case, the Rabi oscillation will be observed with time on the x axis. After this PR, this can be done by modifying the documentation and analysis class.
Closes #1125

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tenzan Araki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing since the problem does not appear after syncing with the main branch now.


setPageMargin() does not work

The margins set on setPageMargin() method are ignored and overrided by MultiViewPager

Correct; MultiViewPager adjusts the margin itself for the mechanism through
which it centers pages. I would suggest specifying the margin through the
page's layout padding instead.
On Thu, Aug 10, 2017, 18:28 Mario Velasco Casquero<EMAIL_ADDRESS>wrote:

The margins set on setPageMargin() method are ignored and overrided by
MultiViewPager
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Pixplicity/MultiViewPager/issues/22, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AARdY4Bv2yhzVTAX1ko7ci5Bowbg3OLvks5sWy-UgaJpZM4OzrEY
.

Putting margin to the view is a trick to "solve" it, but that is no the correct way for two reasons:

The method setPageMargin() doesn't work
The margins will be animated together with the image. For example scaling the page x2 will create a double space between elements.

Those are good points. However, I don't plan on updating this library as I instead recommend moving forward with LinearSnapHelper in conjunction with RecyclerViews.

Thanks for the point out. Could I have animations with it?

The circle view pager indicator behind the view pager is another thing that I miss from recyclerview with SnapHelper.

In the Readme there is a receference to LinearSnapHelper but I think it is not a good recplacement if you need any of the following requisites:

Animation when turning pages.
Bullet points. An indicator to show on which page you are.
Pages are turned one by one without acceleration.
Auto-scroll, pages are turned automatically.

Maybe it not a good idea to point out to LinearSnapHelper from the Readme file without taking this into account


⚠ ClamAV has degraded performance

In 82ed472, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 200 ms

Resolved: ClamAV performance has improved in 1f221b8 after 5 minutes.


feedbackLoops test is not passed

run result :
Intel Inc., Intel(R) UHD Graphics 630, 4.1 INTEL-16.2.16, 4.10
OS version: 0
Level Level : 180x90
Level : 90x45
Computed hash is 0x405970a1, Expected 0xe93a4a07

That would indicate a problem with this GPU. @prideout  what do you think?

Yes I'd say this is a driver bug, and it indicates that some of our post-processing effects might not work properly with this GPU.


[MATLAB] Reduce MATLAB CI Build Time by using ccache

As part of ARROW-13202, we investigated approaches for reducing the build time of MATLAB Interface CI jobs.
When doing clean builds of the MATLAB Interface locally, using ccache substantially reduced overall build time.
We can follow the general approach used by other language bindings to enable the use of ccache in the MATLAB Interface GitHub Actions workflow.
For example: .github/workflows/cpp.yml
Reporter: Kevin Gurney / @kevingurney
Note: This issue was originally created as ARROW-13658. Please see the migration documentation for further details.

Marking this as resolved.
ccache support for building the MATLAB interface using GitHub Actions on Windows, macOS, and Linux was added by @leihou6116 in #35792.


update discussion of how OS is installed

Signed-off-by: Doug Hellmann<EMAIL_ADDRESS>

Looks good!

Looks good!


Bug 2280202: csi: add a new flag to disable csi driver

added a new flag ROOK_CSI_DISABLE_DRIVER
to disable csi controller.
(cherry picked from commit a72e02945978a2a115207d6ea40e14223d8af4a6)

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

pylint failure is being addressed in https://github.com/rook/rook/pull/14243

/cc @subhamkrai @sp98

@rewantsoni This PR has changes not related to the original commit.

@rewantsoni This PR has changes not related to the original commit.

@sp98 Added other commits in the description, they were added because of ci failures


fix error while using '\n' in base64 string

In the original file, it could cause an error while trying to replace all '\n' in base64 string, I use regular expression instead.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


bash used but not installed?

https://github.com/netdisco/netdisco-docker/blob/42ff452a1ee2398a0705607ca3cced138aa3cd0c/netdisco-base/wait_to_start.sh#L1
came about this file while fooling around with our containers. now, this file is found in our container images like netdisco-backend & -web, but those systems are lean and include ash, not bash, so this script will never run on the container images.
now, i have no idea where this file is used, i'm guessing somewhere in the container image build process, so this might not even be relevant.
bottom line: this seems to be a simple script, perhaps bash can be change to #!/bin/sh instead?

doesn't look like it's used anywhere, but it is a slick little script that I would hate to see go. Unless we have a need to save this 1KB, can we decide just to leave it?

yeah, but if it doesn't need bash specific things can't we just use #!/bin/sh ?

But if it's not even in use... does it matter?

it's mentioned here: https://github.com/netdisco/netdisco-docker/blob/9538ffbf18869e05b21af54e41322d903a90c976/netdisco-base/Dockerfile#L76
but i guess that's used during some kind of container build process?
and does it matter, i guess not really, but being a zsh guy it's a bummer to think bash it the only shell 🙂 . the rest of the dockerfile above uses ash for as shell btw.

yea that's just copying the file into the container


fix: parse ggml model types

I'm kind of surprised this didn't come up earlier, noticed this while importing a less common ggml model type. Model parsing was returning nil for uncommon types which results in a nil pointer dereference. Fix this by moving model parsing up a level and try to decode as a llama model in the default case.

The nil model is intentional though the nil pointer isn't. If it's not recognized, it shouldn't make any assumptions about the contents so it's best to just ignore the file.

I dont think it is intentional, the previous behavior was to use the llama model:
https://github.com/jmorganca/ollama/commit/09dd2aeff9a9c43971d5a28815acaca9a3d60dd3

The original implementation was to always use llama but that was just a stand in. This was fine because at the time, the vast majority of model were llama-based so it was a safe assumption. That's no longer the case. Decoding something that's not llama with the llama decoder is likely not going to give you very good results.
Do you have an example file that's triggering the nil pointer dereference?

Could not reproduce this and it will no longer be a problem after gguf updates.


Implement rlpInspect

Not fully sure it should be part of helpeth. Maybe better adding this to the very basic command line tool of rlp?

hmm yeah i'm not forsure... we already have a basic CLI tool in rlp... so it could be added to that

@wanderer as you said it probably makes more sense having this in rlp, meanwhile I've added the more appropriate parseTx


Add tests for ImfCRgbaFile.cpp

Add tests to the test suite for the functions in src/lib/OpenEXR/ImfCRgbaFile.cpp.
These functions are C wrappers around the C++ API, so tests can follow the pattern of the other basic file I/O routines.
The tests should go in src/test/OpenEXRTest and follow the established pattern.

I'm planning to work on this for dev days this week.

Great! Ping this ticket or the slack channel if you have questions

Two follow up questions :

Should the tests for this use  C style file handling, exercise the functions in src/lib/OpenEXR/ImfCRgbaFile.h, and follow what's being done in src/test/OpenEXRTest/testRgba.cpp?
Are there any existing examples of tests written for other C wrappers?

I think so. I don't think there are any tests for this api, but I think testRgba.cpp should be a good model. But keep it simple for now. Just try to replicate the writeReadRGBA() function and skip the "Incomplete" and "Layer" stuff.
The api here is a wrapper around the usual api that testRgba.cpp uses, so you'll need to replace the class objects with equivalent calls to functions in ImfCRgbaFile.h. So you can probably just duplicate testRgba.cpp, delete the "incomplete" and "layer" stuff, then rewrite the other calls.
Thanks!


add dev docs for settings service

I filled in more details for the settings concept.
Some things I would like to highlight and get input for:

We'll need a role hierarchy when e.g. site admins should be able to overrule user-settings or provide default from a higher role.
I personally prefer querying for values and permissions by descriptive identifiers instead of ids. This is especially important since there are not only technical contexts speaking with the settings service. If we'd work with uids we'd need to hardcode them anyway in the code for querying values from the settings service. I made a proposition for referencing permissions and settings in the PR, basically <service>:<settings-bundle>:<settings>:<permission>.
We want to avoid a configuration mess where an admin booting up a new service has to assign permissions to the existing roles manually. It could be a good idea to define role archetypes and use them in settings.

Thoughts? @refs @felixboehm @butonic
Might be a good idea to start next sprint with a short meeting to align on this.

Of course this is built upon https://github.com/owncloud/ocis/pull/165

I'd like to get around having a role hiernarchy. Can you create a concrete example why we cannot do without it. I, too, would like to do the roles and permissions concept properly, but isn't there something we can copy? The ms graph api should have a well thought out permissions concept: https://docs.microsoft.com/de-de/graph/permissions-reference There is also a list of all the available permissions, where maybe the files permissions are most interesting, bit certainly others as well.
+1 for descriptive identifiers, but they must be immutable ... we cannot rename them from eg write to update
AFAICT we will have a set of default roles to mimic the oc10 permissions of admins, users and anonymous users.

something to re-schedule ?

bitrottet. reva started introducing scopes for roles and some tastks of the settings service are covered by the reva appprovider, which does not leave much ... needs a new ADR.