Connection header "close" hangs

Request hangs when doing an HTTP GET request that has a "Connection" header of "close".
If the request is made with "Connection" header "keep-alive" all works well.
This issue came up because we are using an apache HTTP client library that automatically adds the Connection Header "close" when making non connection pool based requests.

Dupe https://github.com/aspnet/KestrelHttpServer/issues/1041 ? Looks fixed in 1.1.0

I am not sure this is a duplicate, the close is sent on the request header where 1041 possibly looks like it deals with the response headers.     Easy enough to test though, any GET request with Connection "close" in the request headers hangs.

@jdslavin What version of Kestrel are you using?

1.0.0

@benaadams I agree that this looks like it could be a dupe of #1041, but even before the fix Kestrel would always close the connection given a "Connection: close" request header which you would think would prevent most clients from hanging. The issue was not setting the right/best response headers.
@jdslavin To be sure, can you provide us with a sample app? If this happens with any app or with our static file handler, you can just say so.
As far as the client goes, are you using the Apache's Java HttpClient? Can you reproduce the issue with Fiddler/Postman or something like that?
If you want to see if this has been fixed yourself, you can try using the 1.1.0-* preview bits from our nightly myget feed

One issue I've seen with "Connection: close" requests is that some clients won't send a FIN until a response has been received. This makes it impossible to ever complete a call to Request.Body.ReadAsync(...) for such a request.
In #406, which was fixed in rc2, we stopped trying to consume the entire body in Kestrel itself for these types of request, but it could be that the app is doing it.

I reproduced this same issue via Advanced Rest Client by just adding the "Connection: close"  request header.    I will try the preview bits to see what happens.

@jodavis Is the app reading the request body? Do you have an app it repros with? Or does it repro with the static file middleware (with no other middleware set up)?

I narrowed this down much further, I tried this under 1.1.0-alpha1-22131 with the same results BUT it turns out this is not a general problem because I can get static files and hit MVC endpoints just fine with that header.   Where I run into the problem is I am hosting an OWIN based server (IdentityServer3) using the OWIN pipeline.       I am trying to hit an endpoint based within the IdentityServer3 dll and that is where my error occurs.
In this case I'm hitting the openid connect well known endpoint and see this behavior:  http://localhost:5001/core/.well-known/openid-configuration
To insert the IdentityServer3 I wrote a small extension to insert it via the aspnet owin component.  See attached screenshot.

I am not sure at this point if its Kestrel, OWIN or the IdentityServer3 component that is causing this behavior.   I have worked around the issue personally so its not blocking me and we can close the issue with Kestrel.

Can you try using IdentityServer4?
IdentityServer3 is likely trying to read from the request body and hanging since the client is sending the Connection: close header and the client is closing the connection until a response is received. Unfortunately the response won't be sent until the body is read, leading to a deadlock of sorts between the client and the server. Each waiting on the other.
After testing the behavior of IHttpHandlers and IIS, I am now convinced this is still a Kestrel bug. Request.GetBufferlessInputStream().Read(...) will return 0 for Connection: close GET requests without a content-length or chunked encoding. A POST request with the same headers will result in the handler not being run and IIS automatically returning a 411 Length Required HTTP status.
I think Kestrel should return a 411 in this case for POST/PUT/PATH/(anything else). And for all other HTTP methods (e.g. GET/HEAD/OPTIONS/...), Kestrel should assume the content length is zero if no Content-Length or Transfer-Encoding headers. The latter is already done for keep-alive connections.
@benaadams @cesarbs Do either you have a good list of HTTP methods that should require a content length?

We'll also have to be careful not to mess up Connection: Upgrade requests when making this fix.

I will give a shot at trying a simple IdentityServer4 tomorrow and see how that goes.  I will keep you posted.

I think its more nuanced http://tools.ietf.org/html/rfc7230#section-3.3.2

A user agent SHOULD send a Content-Length in a request message when no Transfer-Encoding is sent and the request method defines a meaning for an enclosed payload body.

So that isn't a rejection; however http://tools.ietf.org/html/rfc7230#section-3.3.2

A server MAY reject a request that contains a message body but not a Content-Length by responding with 411 (Length Required).

So I'd interpret that as assume content-length 0; when none - else there is any body data; in which case reject? But that might be tricky to implement?
Otherwise

No-body requests: GET, HEAD, DELETE, TRACE
Optional body request: OPTIONS (Naturally :stuck_out_tongue: )
Body requests: POST, PUT, CONNECT, PATCH

Only issue with the assume 0 when it has data is if the body cannot be detected upfront, it will 400 the next request.
However I don't know if the body being empty can be checked without confirming the following data is a new request?

Bleh

A user agent SHOULD NOT send a Content-Length header field when the request message does not contain a payload body and the method semantics do not anticipate such a body.

There is a discussion over here that is relevant Apache Traffic Server
Might even be something to invoke @blowdart on :unamused:

I tried this with the IdentityServer4 sample project and it works fine with the Connection "close" header.   https://github.com/IdentityServer/IdentityServer4.Samples

Should != MUST. So Kestrel ought to work both when the request does the right thing and when it doesn't.

My take on this:

Enforce Transfer-Encoding/Content-Length on body requests. Reject with 411 if absent.
Assume 0 for non-body requests. It's fine to 400 the next request since this is a client error (it shouldn't have sent a body, so that's bogus data in the pipes).
Enforcing Transfer-Encoding/Content-Length where expected should be configurable but enabled by default. If an app chooses to disable it, it's up to it to determine what to do with such requests.

Right now for keep-alive requests, we always assume the content length is zero if the is no Content-Length or Transfer-Encoding header. First, we should change Kestrel to have the same behavior for Connection: close requests. For non-keep-alive requests, it's even safer since we won't try to process subsequent request over the same connection.
If we decide to require content length or chunking for POST, PUT, CONNECT, PATCH, we could do that for both keep-alive and non-keep-alive requests in a separate PR.

Sounds good. I'll take care of this.


[Sema] printConstExprValue should consider negative signal when print number literals

Method that print number literal(integer and floating point literals) as string value should consider negative numbers as well, otherwise string representation of expression value is incorrect.

Resolves https://github.com/apple/swift/issues/62117

@swift-ci Please test

Thank you!

@swift-ci Please test MacOS Platform

@swift-ci Please test MacOS Platform


🎮 Game Request
Frogger is a simple yet challenging arcade game in which the player controls a frog that must cross a busy road and a river to reach its home. The game is played on a grid, and the frog can move left, right, up, and down. The player must avoid cars, trucks, and logs on the road. The player can earn points by crossing the road and river without being killed. The game ends when the player has successfully crossed the river.
Point down the features

the frog can move in any direction by avoiding all obstacles.
The player can earn points by crossing the road and river without being killed.

 Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


How would I go about implementing layout functionality?

I've been tinkering with liquid-node, and I was wondering what the best way is to go about implementing "layout" functionality.
I'm thinking of the common CMS pattern where something like a blog post specifies a layout of 'defaultPost' and defaultPost looks like...
I'm the header
{% include "content???" %} <- this is where whatever specified this as their template gets their content inserted
I'm the footer

I figure I can somehow leverage the new include tag.  The problem comes from the fact that it's the child that is specifying it's parent layout.  The best I've come up with is to render the layout (not the child), supplying a model that is the original child model (whatever data it needs), plus a new property called "content", that is assigned the template/markup of the child.
engine.parseAndRender("layout", { <originalChildModelProperties>, content: childTemplate })

I haven't had a chance to try this yet, but it doesn't feel right to be manually building the model like that.  I'll definitely comment more once I've had a chance to try this out.
Is there a better approach to implement the concept of layouts before I get started?

Take a look at jinja2's Block Assignments.
Or Jade Extends http://jade-lang.com/reference/extends/

Something similar has been done in assemble-liquid. The include-tag by itself is an inspiration for that but not the right tool. But you can copy a lot of code from there.


ControlNet Model (diff Advanced)

it error asking for "timestep_keyframe"
but is no point link for   "timestep_keyframe" in ControlNet Model (diff Advanced) node
it can only link for  ControlNet Weights but if you do that it will give   'control_net_weights' error
i'm too dump this i miss some point?

Can you post a screenshot of the area of your workflow you're talking about and the error? It will help me a ton to reproduce/see what your mean.

this is workflow  i test with IPAdapter it work but not coherent

this error cap screen

Thanks, I'll take a look and get back to you shortly!

I don't get the error on my end, but also that node I don't think I updated properly before. Also, why are you using the (diff Advanced) node instead of the Load ControlNet Model (Advanced) node that does not have model input?

Is there a reason you need to use diff specifically? This one should work

Ah, I found the issue, in my copy of the workflow after removing some stuff my CN got disconnected, but I can replicate your problem now. I will push a fix shortly 👍

Great,your node is the best.

Alrighty, the fix has been pushed to ComfyUI-Advanced-ControlNet repository - you will need to update it, and then replace your node in your workflow with a new one and then it should work. Btw, if the controlnet you are loading does not require diff, the non-diff node will also work

It work perfectly now thank you for your hard work, I really love your node keep it up.


Sync Command Vs. File Execution

Would a command be executed faster in an synchronous command or in a file?

There would be no noticeable performance difference between
<RunSynchronousCommand wcm:action="add">
  <Order>...</Order>
  <Path>C:\Foo.exe</Path>
</RunSynchronousCommand>

and
<RunSynchronousCommand wcm:action="add">
  <Order>...</Order>
  <Path>cmd.exe /c "C:\Windows\Setup\Scripts\unattend-01.cmd >>"C:\Windows\Setup\Scripts\unattend-01.log" 2>&1"</Path>
</RunSynchronousCommand>

<File path="C:\Windows\Setup\Scripts\unattend-01.cmd">
C:\Foo.exe
</File>

which both effectively call the C:\Foo.exe file. Custom scripts are stored in <File> elements not for performance reasons, but to make escaping and editing easier and to support longer commands.


Error in [native code]:0

Error in mSupply Mobile
Error in [native code]:0
Property 'otherPartyName' does not exist on object type 'Transaction'
View on Bugsnag
Stacktrace
[native code]:0 - sorted

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
Error in [native code]:0

An error linked to this issue has been marked as fixed in Bugsnag
Error in [native code]:0

An error linked to this issue has been reopened in Bugsnag
Error in [native code]:0

An error linked to this issue has been marked as fixed in Bugsnag
Error in [native code]:0

An error linked to this issue has been reopened in Bugsnag
Error in [native code]:0


asRunLog in snapshot

This PR adds the asRunLog into RundownPlaylistSnapshots, to help with future troubleshooting.
I specifically DONT restore the asRunLog when restoring, since that is a log of what the system has done, so it should not be polluted by restoring snapshots.

Other information:

Status

[x] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Codecov Report

Merging #330 into release25 will decrease coverage by 0.32%.
The diff coverage is 62.50%.

@@              Coverage Diff              @@
##           release25     #330      +/-   ##
=============================================
- Coverage      68.15%   67.82%   -0.33%
=============================================
  Files            186      190       +4
  Lines          12506    12782     +276
  Branches        2920     2824      -96
=============================================
+ Hits            8523     8669     +146
- Misses          3916     4045     +129
- Partials          67       68       +1

Impacted Files
Coverage Δ

meteor/lib/Rundown.ts
52.17% <0.00%> (ø)

meteor/lib/collections/Parts.ts
50.00% <0.00%> (-0.91%)
:arrow_down:

meteor/lib/collections/PieceInstances.ts
90.90% <ø> (ø)

meteor/lib/collections/RundownLayouts.ts
100.00% <ø> (ø)

meteor/lib/collections/RundownPlaylists.ts
53.28% <0.00%> (-0.79%)
:arrow_down:

meteor/lib/rundown/pieces.ts
75.86% <0.00%> (ø)

meteor/server/api/ingest/genericDevice/actions.ts
20.00% <0.00%> (ø)

meteor/server/api/playout/adlib.ts
44.48% <ø> (ø)

meteor/server/api/playout/api.ts
60.52% <0.00%> (-1.64%)
:arrow_down:

meteor/server/api/playout/lookahead.ts
9.57% <0.00%> (+0.05%)
:arrow_up:

... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71d9a5...efea1ad. Read the comment docs.


Fixes #514

Used RFC 5322 in isEmail, an email address regex that 99.99% works.
Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
Executed 487 tests, with 0 failures (0 unexpected) in 3.114 (3.579) seconds

:book:
Executed 457 tests, with 0 failures (0 unexpected) in 2.046 (2.442) seconds

:book:
Executed 331 tests, with 0 failures (0 unexpected) in 1.310 (1.656) seconds

  Generated by :no_entry_sign: Danger

cc @SD10 ☝


[Snyk] Security upgrade org.apache.jena:jena-rdfpatch from 4.9.0-SNAPSHOT to 5.0.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

apache-jena-libs/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

619/1000  Why? Has a fix available, CVSS 8.1
Infinite loop SNYK-JAVA-ORGAPACHECOMMONS-6254296
org.apache.jena:jena-rdfpatch:  4.9.0-SNAPSHOT -> 5.0.0
No
No Known Exploit

429/1000  Why? Has a fix available, CVSS 4.3
Allocation of Resources Without Limits or Throttling SNYK-JAVA-ORGAPACHECOMMONS-6254297
org.apache.jena:jena-rdfpatch:  4.9.0-SNAPSHOT -> 5.0.0
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling

Checkmarx One – Scan Summary & Details – c475f00d-5d5d-4490-a92e-85342ef9b581
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2022-46337
Maven-org.apache.derby:derby-<IP_ADDRESS>
Vulnerable Package

CVE-2023-36478
Maven-org.eclipse.jetty:jetty-http-10.0.15
Vulnerable Package

CVE-2023-43646
Npm-get-func-name-2.0.0
Vulnerable Package

CVE-2023-45133
<EMAIL_ADDRESS>Vulnerable Package

CVE-2024-23331
Npm-vite-4.0.4
Vulnerable Package

Cxab55612e-3a56
Npm-braces-3.0.2
Vulnerable Package

Cxca84a1c2-1f12
Npm-micromatch-4.0.5
Vulnerable Package

CVE-2023-26159
Npm-follow-redirects-1.15.2
Vulnerable Package

CVE-2023-36479
Maven-org.eclipse.jetty:jetty-servlets-10.0.15
Vulnerable Package

CVE-2023-40167
Maven-org.eclipse.jetty:jetty-http-10.0.15
Vulnerable Package

CVE-2023-42503
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2023-44270
Npm-postcss-8.4.21
Vulnerable Package

CVE-2023-45857
Npm-axios-0.27.2
Vulnerable Package

CVE-2023-46749
Maven-org.apache.shiro:shiro-web-1.11.0
Vulnerable Package

CVE-2023-46750
Maven-org.apache.shiro:shiro-web-1.11.0
Vulnerable Package

CVE-2024-25710
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2024-26308
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2024-28849
Npm-follow-redirects-1.15.2
Vulnerable Package

Improper_Restriction_of_Stored_XXE_Ref
/jena-iri/src/test/java/org/apache/jena/iri/TestMoreExamples.java: 239
Attack Vector

Improper_Restriction_of_Stored_XXE_Ref
/jena-iri/src/test/java/org/apache/jena/iri/TestCreator.java: 81
Attack Vector


[BUG] Fix potential memory leak when encountering disk unhealthy

What changes were proposed in this pull request?
Fix potential memory leak when encountering disk unhealthy
Why are the changes needed?
When encountering disk unhealthy and exceed the timeout of pendingDataShuffleFlushEvent, it will release memory. But in current codebase, it wont release the data reference and cause the memory leak.
Does this PR introduce any user-facing change?
No
How was this patch tested?

@xianjingfeng @jerqi PTAL . Does this is a critical bug? I found the shuffle-server is always oom when encountering disk unhealthy(like reaching the highwatermark).

Could you explain why this cause memory leak?

Codecov Report

Merging #370 (86f8320) into master (ad51341) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #370   +/-   ##
=========================================
  Coverage     58.01%   58.02%
- Complexity     1361     1362    +1
=========================================
  Files           171      171
  Lines          9006     9008    +2
  Branches        787      787
=========================================
+ Hits           5225     5227    +2
  Misses         3449     3449
  Partials        332      332

Impacted Files
Coverage Δ

...org/apache/uniffle/server/ShuffleFlushManager.java
79.14% <100.00%> (+0.22%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Could you explain why this cause memory leak?

It releases memory but not release the data reference. Right?

Could you explain why this cause memory leak?

It releases memory but not release the data reference. Right?

It seems yes.  I think it is the reason of #164

Maybe this PR should be applied to release-0.6.0-RC2.

Maybe this PR should be cherry-picked to release-0.6.0-RC2.

You can cherry-pick this pr to branch-0.6. And reply the mail to the release manager in the<EMAIL_ADDRESS>

Maybe this PR should be cherry-picked to release-0.6.0-RC2.

Thanks @zuston for the fix. Yes I think this is an important fix, I'll backport this into branch-0.6 and start a v0.6.0-rc3 release.


Importing useRef

Hello, installed the package with Plug and everything seems to be OK, but I'm getting the fallback message when trying to import a simple useRef hook from React.
No tag found for word "useRef". Falling back to prompt.
Path to file or package name:

Is there a way that I've got to specify pulling from outside dependencies when the module is not in the current folder, or is that not possible? This also happens when I'm trying to import other modules, like moment.js
Thanks for your work on the plugin!

Hi,
only things that are part of the tags file can be imported automatically. No javascript is being read or parsed.
Importing react would work because it's defined in package.json as dependency, but things that are exported from inside of dependency are not generated in tags file, thus not automatically importable.
For these situations you can just type in react, and after it prompts for full or partial, select partial, and you should get what you need.


iPhone X safe area overlay

I noticed a problem on the iPhone X where your toolbar and close/delete buttons overlay with the safe area, meaning interfering with the status bar and the home bar indicator. Below is a screenshot

Any quick fix suggestions till we get the next pods release?

So I just created PR #239 which fixes this. If you just have top buttons and no toolbar you can actually use the closeAndDeleteButtonPadding property to adjust the padding.
If you need an immediate fix and don't like adjusting the values yourself you can use the following in your pod file to update temporarily:
pod 'SKPhotoBrowser', :git => 'https://github.com/timroesner/SKPhotoBrowser', :commit => 'bd169f9'
Here is a screenshot of the fix:

Thanks for helping out 😊. Another minor UI issue, the caption text (page number) and side arrows are off-center w.r.t to the swipe up bar. #240


Add Custom Image Building Functionality

Rather than using a daemonset to replace the kernel, build, upload and use a custom Ubuntu image with the kernel in place.

We will have to do something similar with EKS from what I recall : https://github.com/awslabs/amazon-eks-ami

It looks like this isn't possible for GKE? Within the cluster creation "portal" UI there is no option to select an image. Additionally, the node images documentation does not mention usage of custom images.
From what I've seen online, DaemonSet for GKE might be the best approach to make node modifications.


Dodo emoji

The Dodo is one of the best known animal to have gone extinct few centuries ago. It was a flightless bird with characteristic beak and stature.
Proposals

L2/17-161 = N4794 has recommendations by the Irish and British NSBs to encode additional extinct animals besides select dinosaurs #99.

The ISO/IEC working group WG2 who jointly develop the single characters set with Unicode, agreed to add several pictographs intended for emoji usage:

U+1F93F BILLIARD GAMES
U+1F97B TROLL
U+1F9A1 MAMMOTH
U+1F9A2 DODO
U+1F9A3 BADGER
U+1F9A4 SQUIRREL
U+1F9A5 SWAN

Sources

N4870
L2/17-350 = N4566
L2/17-329 = N4888


Add default bonds first time actor runs the class wizard - [closed]

In GitLab by @jsavko on Nov 2, 2021, 18:00
Merges jsavko-master-patch-08997 -> master

In GitLab by @jsavko on Nov 2, 2021, 18:00
approved this merge request


Fix ShaderResource::size value for 8 bit types

Description
The use of 7 looks like a simple typo that would easily go undetected until someone actually tried to use a double or other 64 bit type in a shader.
Checklist:
I'm not spending my whole day on this.

@wasimabbas-arm @ZandroFargnoli fixed copyright


Bring .Values.image.registry setting to upstream cilium

See https://github.com/giantswarm/cilium-upstream/commit/171e0b54b599313e8c03f1174b40bdea1c1a3e8f
We have issues with adding this to new images. It generates conflicts and we are never sure we applied it to all images. It would be good to have it accepted upstream.

This PR https://github.com/giantswarm/cilium-upstream/pull/11 goes towards this direction. Maybe something similar could be accepted upstream.
I don't think they would like $.image.registry because $.image is for cilium-agent image settings, but we can live with any other setting like $.imageRegistry, as this can be easily translated in cluster charts.

We should try to pick up on upstream issue https://github.com/cilium/cilium/issues/17203
Someone provided a PR to introduce global.imageRegistry but it wasn't merged because of problems with integration tests.
IMO we should try to contribute our image.registry solution because thats the easiest for us.


Add current version to deps

Coverage remained the same at 89.796% when pulling 85aa066bc1ce7e1be427784a4d57605ff62b905c on StevenNunez:patch-1 into 8f65d55ca81504dd18f81b9da39c64656196e35f on antipax:master.

Thanks! 💚


⚠ ClamAV has degraded performance

In b5bfc85, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 48 ms

Resolved: ClamAV performance has improved in 6ab0a5e after 5 minutes.


Update Block Explorer README

Motivation
This README was just showing how to build the Block Explorer code
Proposal
Include also instructions on how to serve the web application and open it in your browser
Test Plan
Went through the steps myself
Release Plan

Nothing to do / These changes follow the usual release cycle.

#2733  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on  Graphite

Merge activity

Oct 28, 9:23 PM EDT: A user started a stack merge that includes this pull request via Graphite.


Remove Ga.X(), which is a worse spelling of Ga.coord_vec

xref #333

Probably should have squashed this one, but not a big deal.


start kube-scheduler check implementation

What does this PR do?
Introduce a new check: kube_scheduler
Motivation
Improves the Kubernetes core components integration
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] PR title must be written as a CHANGELOG entry (see why)
[x] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[x] Feature or bugfix must have tests
[x] Git history must be clean
[x] If PR adds a configuration option, it must be added to the configuration file.

nice PR from a doc perspective :) I left some comments.

thanks @l0k0ms for the review.
I updated the PR with all your comments.

@xvello PR updated following your comments

@xvello, it should be good now :)

@xvello after a discussion with @CharlyF, I removed the apiserver metrics from this check and will see later if it worth to add it back.

thanks @ofek for the review. PR updated with your suggestions.


check all methods on PrimVal for undef correctness

Checking anything on the value of the primval must be fallible, because we do not want to expose whether it is undef to the evaluated code.

The only infallible operations currently seem to be the from_* and is_*, which seems fine, doesn't it?

The is_* checks could be abused. E.g. if is_null were infallible, we might expose the Undef. I just opened the issue so I wouldn't forget about it.

I went through them. The usages of is_ptr and is_bytes are fine, since immediately after to_ptr and to_bytes are called. We just need to be careful around them.


CTD on 1.4 beta branch

as of 11-5-2020 on beta branch, clicking the clan icon crashes the game to desktop, worked before 1.4 beta ninja patch on 11-5-2020
Edit. to replicate, just create a fresh campaign on e<IP_ADDRESS>869 skip the tutorials, and click the clan icon.

I was lucky enough that my steam hadn't updated yet.
With CP loaded:
Pre ninja patch: no crash
post ninja patch: crashes
If no mods enabled no crash either way.
When debugger attached in a debug build, exception trace:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.MissingMethodException: Method not found: 'System.Collections.Generic.IReadOnlyList`1<TaleWorlds.CampaignSystem.Town> TaleWorlds.CampaignSystem.Town.get_All()'.
  at at CommunityPatch.Patches.Perks.Intelligence.Steward.RulerPatch.CompanionLimitPatched(Clan __instance, Int32& __result)
  at at DMD<DMD<get_CompanionLimit_Patch2>?16294837::get_CompanionLimit_Patch2>(Clan this)
  at at TaleWorlds.CampaignSystem.ViewModelCollection.ClanManagement.Categories.ClanMembersVM.RefreshMembersList()
  at at TaleWorlds.CampaignSystem.ViewModelCollection.ClanManagement.Categories.ClanMembersVM..ctor(Action onRefresh)
  at at TaleWorlds.CampaignSystem.ViewModelCollection.ClanManagement.ClanVM..ctor(Action onClose, Action`1 openPartyAsManage, Action openBannerEditor)
  at at SandBox.GauntletUI.GauntletClanScreen.TaleWorlds.Core.IGameStateListener.OnActivate()
  at at TaleWorlds.Core.GameState.HandleActivate()
  at at TaleWorlds.Core.GameStateManager.OnPushState(GameState gameState)
  at at TaleWorlds.Core.GameStateManager.DoGameStateJobs()
  at at TaleWorlds.Core.GameStateManager.PushState(GameState gameState, Int32 level)
  at at SandBox.View.Map.MapNavigationHandler.OpenClanScreenAction()
  at at SandBox.View.Map.MapNavigationHandler.TaleWorlds.CampaignSystem.INavigationHandler.OpenClan()
  at at TaleWorlds.CampaignSystem.ViewModelCollection.Map.MapNavigationVM.ExecuteOpenClan()
  --- End of inner exception stack trace ---
  at at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
  at at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
  at at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  at at TaleWorlds.Library.Common.InvokeWithLog(MethodInfo methodInfo, Object obj, Object[] args)
  at at TaleWorlds.GauntletUI.Data.GauntletView.OnCommand(String command, Object[] args)
  at at System.Action`3.Invoke(T1 arg1, T2 arg2, T3 arg3)
  at at TaleWorlds.GauntletUI.Widget.EventFired(String eventName, Object[] args)
  at at TaleWorlds.GauntletUI.ButtonWidget.HandleClick()
  at at TaleWorlds.GauntletUI.ButtonWidget.OnMouseReleased()
  at at TaleWorlds.GauntletUI.EventManager.MouseUp()
  at at TaleWorlds.GauntletUI.UIContext.UpdateInput(InputType handleInputs)
  at at TaleWorlds.Engine.GauntletUI.GauntletLayer.ProcessEvents()
  at at TaleWorlds.Engine.Screens.ScreenManager.Update()
  at at TaleWorlds.Engine.Screens.ScreenManager.Tick(Single dt)
  at at ManagedCallbacks.EngineCallbacksGenerated.ScreenManager_Tick(Single dt)

As the stacktrace says, it does indeed appear that the getter for property TaleWorlds.CampaignSystem.Town.All has now been removed. Rider gives a compilation error.
I love TW but I think they just removed a public method in a stealth ninja patch 🤣 Oh the humanity

Confirmed. After ninja 1.4 Beta patch today CTD when opening a "Clan" screen.
Source: CommunityPatch
Method not found: 'System.Collections.Generic.IReadOnlyList`1 TaleWorlds.CampaignSystem.Town.get_All()'.

at CommunityPatch.Patches.Perks.Intelligence.Steward.RulerPatch.CompanionLimitPatched(Clan __instance, Int32& __result)
   at DMD?10603613::get_CompanionLimit_Patch2>(Clan this)
   at TaleWorlds.CampaignSystem.ViewModelCollection.ClanManagement.Categories.ClanMembersVM.RefreshMembersList()
   at TaleWorlds.CampaignSystem.ViewModelCollection.ClanManagement.Categories.ClanMembersVM..ctor(Action onRefresh)
   at TaleWorlds.CampaignSystem.ViewModelCollection.ClanManagement.ClanVM..ctor(Action onClose, Action`1 openPartyAsManage, Action openBannerEditor)
   at SandBox.GauntletUI.GauntletClanScreen.TaleWorlds.Core.IGameStateListener.OnActivate()
   at TaleWorlds.Core.GameState.HandleActivate()
   at TaleWorlds.Core.GameStateManager.OnPushState(GameState gameState)
   at TaleWorlds.Core.GameStateManager.DoGameStateJobs()
   at SandBox.View.Map.MapScreen.OpenClanScreen()
   at SandBox.View.Map.MapScreen.TaleWorlds.CampaignSystem.IMapStateHandler.AfterWaitTick(Single dt)
   at TaleWorlds.CampaignSystem.MapState.OnMapModeTick(Single dt)
   at TaleWorlds.Core.GameStateManager.OnTick(Single dt)
   at TaleWorlds.Core.Game.OnTick(Single dt)
   at TaleWorlds.Core.GameManagerBase.OnTick(Single dt)
   at DMD?66083951::OnApplicationTick_Patch1>(Module this, Single dt)

As the stacktrace says, it does indeed appear that the getter for property TaleWorlds.CampaignSystem.Town.All has now been removed. Rider gives a compilation error.
I love TW but I think they just removed a public method in a stealth ninja patch 🤣 Oh the humanity

i just love that after several weeks, an update for community patch comes out, and seconds later TW destroys it with 1 quick ninja patch :)

As the stacktrace says, it does indeed appear that the getter for property TaleWorlds.CampaignSystem.Town.All has now been removed. Rider gives a compilation error.
I love TW but I think they just removed a public method in a stealth ninja patch 🤣 Oh the humanity

i just love that after several weeks, an update for community patch comes out, and seconds later TW destroys it with 1 quick ninja patch :)

Exactly. It's a pretty bad time for a rc5 release on Nexus.
Who woulda thunk?

Town.All is also checked in the Ruler patch.

It looks like this code first showed up in commit a24e0dc8942c9c32ca0e296d7890f70a13de5bd1 which first appeared in version 0.0.2 a long time ago.

Hey I was wondering if you implemented the fix anywhere yet? I know it has been literally only 30 minutes, but I have no idea how to build your github version or anything, feel free to tell me to just wait :P

@PackOfDingoes we had some people around to fix it immediately ;)
the fix is on dev branch, you can build it using the instructions on the main page.

@PackOfDingoes the fix is in 0.1.0-rc4, you can install manually in vortex

tyvm, I was thinking "oh no, time to actually follow instructions instead of just copy/pasting", but you've come to my rescue lol.


Concurrency issue fetching historic fees

It appears checkFees is not very concurrent as it's getting called several times after every chunk finishes which in turn will start firing several requests.

Implemented a RXJS based solution in f09d3c5e238acbd7d6a7d1170fe0c24d14ccf0fc @H34D check it out.

[ ] Use only one concurrent requests when fetching fee history
[ ] Sort by liquidity depth

but it should be sorted by liq depth already. no?
https://github.com/bancorprotocol/webapp/blob/staging/src/store/modules/swap/ethBancor.ts#L6529-L6539

Only within this function which is only handling around 30 at a time, which means high priority pools could be pushed back to the 3rd batch and take forever to get loaded.
My recent changes have introduced a smart buffering system which allows you to add as many converterAndAnchor sets to the observable and it will sort the queue each request.


Histogram - ability to take NaNs into account in norm

When using Histogram on a df with NaNs, it seems that norm does not take into account the NaNs in the percentage.
In the following image you can see that the bin 40.75-41.05 is  2.403315%.
If we took the NaNs into account we would have it at 1.74%

hi @ItamarShDev,
this is indeed not a nice behaviour. The question is how one should design a solution. One could simply:

raise and exception if NaNs are contained in the dataframe because the data is ill-defined for such an analysis
just ignore the NaNs in the analysis

What do you think about this?

We have a 3rd case where NaNs are part of the dataset, and thus needs to be taken into account.
So if we have [0,0,NaN,1,1,2] in the data, the normalized histogram would show:

Value
0
1
2

Percentage
1/3
1/3
1/6

where now it is completely ignores the NaNs and show:

Value
0
1
2

Percentage
2/5
2/5
1/5

Why this is a real life case for me:
We show data histogram and shade it with another histogram by condition, where everything that computes to False in the condition is NaN
Example:
Data:  [0,0,NaN,1,1,2]
Rule: x > 0
Data histogram

Value
0
1
2

Percentage
1/3
1/3
1/6

Rule shading histogram

Value
0
1
2

Percentage
0/6
1/3
1/5

If i go with current implementation i will get:
Data histogram

Value
0
1
2

Percentage
2/5
2/5
1/5

Rule shading histogram

Value
0
1
2

Percentage
0/3
2/3
1/3

As you can see, the proportion are change which creates the false impression that ignoring data  improved the result....


Adding Persian Translation

I's like to add Persian translation. Please add it to Crowdin.

Here you go! https://crowdin.com/project/excalidraw/fa#


Can't choose the new filename without pointing out the extension

I wanted to pass the output_file argument to pythran.compile_pythranfile, but I want to make my code compile both on Linux and Windows, so I don't know beforehand the extension of the file. It would be nice to have an option where the extension is set to automatic, and one can change only the module's name.

What about a magic format like -o my_filename.%{ext_suffix} ?

More likely -o my_filename%{ext} btw

That would be nice! And would be nice also if available at the pythran.compile_pythranfile function. My problem is that the user is in charge of compiling the modules beforehand. Therefore, if he doesn't compile, since the .pyd/.so and the .py files have the same name and are in the same directory, he still loads the .py module. I would like to prevent that by having the compiled module have a different name, but maintaining the .cp37... .pyd extension. Do you suggest a better and more clever way of doing this with the current version of the package? I have already tried putting a logging.warning on the .py, but that is misinterpreted by Pythran, even though it doesn't affect the # pythran export function.

Hi @rfiischer, transonic could be use for that. it emits a warning it the file is not compiled. it works out of the box on Linux and Windows.


[FEAT] Generate interfaces based on intersection of mappers and typescript-resolvers

I'd be great if we could have an 'interface only' mode that just augments the interfaces from typescript-resolvers to mark the required fields as required based on what's in the mapped types (equivalent to current minimal mode) and leaves all others optional. That, run in merged mode, would give me a perfect minimal setup as far as I can tell.
Thanks!

Hi @matt-potter , could you help me understand this feature request by providing a small example please? 🙏

Sure, here's a repo with a basic example using your package in disabled mode for resolver generation.
Essentially, I want to ensure the creation of resolvers where they are required, but I don't want to codegen the actual functions - i just want a set of interfaces to implement
What I'm hoping for is just to augment the existing interfaces generated by typescript-resolvers, making only the missing properties required and leaving the rest as optional - something like this.
import type { AuthorResolvers } from "./../graphql/generated/types.generated.js";

export interface RequiredAuthorResolvers extends AuthorResolvers {
	books: NonNullable<AuthorResolvers["books"]>;
}

const resolvers: RequiredAuthorResolvers = {
	books: async (_parent, _arg, _ctx) => {
		/* Author.books resolver is required because Author.books exists but AuthorMapper.books does not */
	},
};

The only other options currently (afaik) are to specify avoidOptionals to true and implement all fields, or to false and potentially miss resolvers

for what it's worth, what I'm describing is how Golang's gqlgen operates. Putting in the same schema and mapping equivalent structs generates these interfaces to implement - you only need to implement what's required, but still have the option to override existing properties.
type AuthorResolver interface {
	Books(ctx context.Context, obj *model.Author) ([]*model.Book, error)
}
type BookResolver interface {
	Author(ctx context.Context, obj *model.Book) (*model.Author, error)
}
type QueryResolver interface {
	Books(ctx context.Context) ([]*model.Book, error)
	Book(ctx context.Context, id string) (*model.Book, error)
	Authors(ctx context.Context) ([]*model.Author, error)
	Author(ctx context.Context, id string) (*model.Author, error)
}

Ah, understood 👍 Thanks for the detailed examples.
I think it's doable and can be implemented in the future. However, it will require some work, both in the base codegen plugin (to have non-optional config at the granular field level ) and in the preset (improved static analysis logic).


Pass --no-version-check to xtrabackup commands

Without this option, there will be some unneeded, redundant messages:
2017-11-01 10:38:47 DEBUG    The following backup command will be executed /home/shahriyar.rzaev/XB_TEST/server_dir/target/percona-xtrabackup-2.3.x-debug/bin/xtrabackup --defaults-file= --user=root --password=''  --target-dir=/home/shahriyar.rzaev/XB_TEST/backup_dir/ps_5_6_x_2_3/cycle1/full/2017-11-01_10-38-47 --backup --socket=/home/shahriyar.rzaev/XB_TEST/server_dir/PS231017-percona-server-5.6.37-82.2-linux-x86_64-debug/socket.sock
2017-11-01 10:38:47 DEBUG    Starting /home/shahriyar.rzaev/XB_TEST/server_dir/target/percona-xtrabackup-2.3.x-debug/bin/xtrabackup
2017-11-01 10:39:43 DEBUG    171101 10:38:48  version_check Connecting to MySQL server with DSN 'dbi:mysql:;mysql_read_default_group=xtrabackup;mysql_socket=/home/shahriyar.rzaev/XB_TEST/server_dir/PS231017-percona-server-5.6.37-82.2-linux-x86_64-debug/socket.sock' as 'root'  (using password: NO).
171101 10:38:48  version_check Connected to MySQL server
171101 10:38:48  version_check Executing a version check against the server...
*******************************************************************
 Using the default of SSL_verify_mode of SSL_VERIFY_NONE for client
 is deprecated! Please set SSL_verify_mode to SSL_VERIFY_PEER
 together with SSL_ca_file|SSL_ca_path for verification.
 If you really don't want to verify the certificate and keep the
 connection open to Man-In-The-Middle attacks please set
 SSL_verify_mode explicitly to SSL_VERIFY_NONE in your application.
*******************************************************************
  at - line 237.
*******************************************************************
 Using the default of SSL_verify_mode of SSL_VERIFY_NONE for client
 is deprecated! Please set SSL_verify_mode to SSL_VERIFY_PEER
 together with SSL_ca_file|SSL_ca_path for verification.
 If you really don't want to verify the certificate and keep the
 connection open to Man-In-The-Middle attacks please set
 SSL_verify_mode explicitly to SSL_VERIFY_NONE in your application.
*******************************************************************
  at - line 237.

# A software update is available:

This can be achieved by passing --no-version-check as xtra_options from config, which is going to be passed to backup/prepare commands.

So it is passed:
2017-11-02 14:09:57 DEBUG    The following backup command will be executed /home/shahriyar.rzaev/XB_TEST/server_dir/target/percona-xtrabackup-2.4.x-debug/bin/xtrabackup --defaults-file= --user=root --password=''  --target-dir=/home/shahriyar.rzaev/XB_TEST/backup_dir/ps_5_7_x_2_4/cycle1/full/2017-11-02_14-09-57 --backup --socket=/home/shahriyar.rzaev/XB_TEST/server_dir/PS231017-percona-server-5.7.19-17-linux-x86_64-debug/socket.sock --compress=quicklz --compress-chunk-size=65536 --compress-threads=4 --encrypt=AES256 --encrypt-key=VVTBwgM4UhwkTTV98fhuj+D1zyWoA89K --encrypt-threads=4 --encrypt-chunk-size=65536 --no-version-check --stream="xbstream" > /home/shahriyar.rzaev/XB_TEST/backup_dir/ps_5_7_x_2_4/cycle1/full/2017-11-02_14-09-57/full_backup.stream

Merging.


vscode unresponsive using remote-ssh editing c++ win10 to ubuntu

Issue Type: Performance Issue
Not sure if this is the same as issue #92229, but since the most recent update I am seeing regular cases of the windows-side vscode becoming unresponsive and consuming high CPU.
There seems to be no specific trigger :-(
A prompt will appear sooner or later suggesting to re-open the app (or wait), waiting does not seem to help.
I am working using remote ssh on an Ubuntu Linux server (that is sat next to me on the same LAN)
running top on the server-side shows no CPU usage for the code instance and there is no apparent network issue as XWindows processes such as Gitkraken are operating quite happily throughout.
I have only seen this since the update to 1.43 so I am wary of saying this is the same problem as the issue noted above but it seems to be manifesting in the same way.
Neil
VS Code version: Code 1.43.0 (78a4c91400152c0f27ba4d363eb56d2835f9903a, 2020-03-09T19:47:57.235Z)
OS version: Windows_NT x64 10.0.18363
Remote OS version: Linux x64 4.15.0-88-generic
Remote OS version: Linux x64 4.15.0-88-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz (8 x 4000)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (17.48GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: babbage

OS
Linux x64 4.15.0-88-generic

CPUs
Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 x 800)

Memory (System)
31.28GB (20.78GB free)

VM
0%

Item
Value

Remote
SSH: babbage

OS
Linux x64 4.15.0-88-generic

CPUs
Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 x 800)

Memory (System)
31.28GB (20.78GB free)

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	    79	 13808	code main
    0	   134	  3288	   gpu-process
    0	    12	  4180	   electron-crash-reporter
    0	    25	 11348	   utility
    0	    73	 12576	   shared-process
    0	   180	 15232	   window (pcapMatch.cpp - stac-ts-framework [SSH: babbage] - Visual Studio Code)
    0	    35	 17872	     extensionHost
    0	    68	 36396	   window (Issue Reporter)
    0	   231	 37108	   window (fixfactory.cpp - order-router (Workspace) [SSH: babbage] - Visual Studio Code)
    0	    74	 38656	     extensionHost

Remote: SSH: babbage
CPU %	Mem MB	   PID	Process
    0	     0	  5562	remote agent
    0	     0	  5767	   extensionHost
    0	     0	  5873	     clangd --clang-tidy --completion-parse=always --completion-style=bundled --header-insertion=iwyu --header-insertion-decorators -j=4 --suggest-missing-includes --clang-tidy-checks=*,-fuchsia-*,-modernize-use-trailing-return-type, -google-global-names-in-headers, -modernize-use-trailing-return-type --compile-commands-dir=${workspaceFolder} --log=verbose
    0	     0	  5905	     /home/neil/.vscode-server/extensions/ms-vscode.cpptools-0.27.0-insiders2/bin/cpptools
    0	     0	 13183	       /home/neil/.vscode-server/extensions/ms-vscode.cpptools-0.27.0-insiders2/bin/cpptools-srv 5905 26
    0	     0	  6135	     /home/neil/.vscode-server/bin/78a4c91400152c0f27ba4d363eb56d2835f9903a/node /home/neil/.vscode-server/bin/78a4c91400152c0f27ba4d363eb56d2835f9903a/extensions/json-language-features/server/dist/jsonServerMain --node-ipc --clientProcessId=5767
    0	     0	  6996	     /home/neil/.vscode-server/extensions/ms-python.python-2020.2.64397/languageServer.0.5.31/Microsoft.Python.LanguageServer
    0	     0	  5788	   watcherService
    0	     0	 32622	   watcherService

Remote: SSH: babbage
CPU %	Mem MB	   PID	Process
    0	     0	  5562	remote agent
    0	     0	  5767	   extensionHost
    0	     0	  5873	     clangd --clang-tidy --completion-parse=always --completion-style=bundled --header-insertion=iwyu --header-insertion-decorators -j=4 --suggest-missing-includes --clang-tidy-checks=*,-fuchsia-*,-modernize-use-trailing-return-type, -google-global-names-in-headers, -modernize-use-trailing-return-type --compile-commands-dir=${workspaceFolder} --log=verbose
    0	     0	  5905	     /home/neil/.vscode-server/extensions/ms-vscode.cpptools-0.27.0-insiders2/bin/cpptools
    0	     0	 13183	       /home/neil/.vscode-server/extensions/ms-vscode.cpptools-0.27.0-insiders2/bin/cpptools-srv 5905 26
    0	     0	  6135	     /home/neil/.vscode-server/bin/78a4c91400152c0f27ba4d363eb56d2835f9903a/node /home/neil/.vscode-server/bin/78a4c91400152c0f27ba4d363eb56d2835f9903a/extensions/json-language-features/server/dist/jsonServerMain --node-ipc --clientProcessId=5767
    0	     0	  6996	     /home/neil/.vscode-server/extensions/ms-python.python-2020.2.64397/languageServer.0.5.31/Microsoft.Python.LanguageServer
    0	     0	  5788	   watcherService
    0	     0	 32622	   watcherService

Workspace Info

|  Remote: SSH: babbage
|  Remote: SSH: babbage|    Folder (stac-ts-framework): 1201 files|      File types: cmake(104) make(88) idx(78) tex(70) txt(60) py(56) json(49)
|                  h(40) o(38) cpp(29)
|      Conf files: cmake(104) makefile(24) launch.json(1) settings.json(1)
|      Launch Configs: cppdbg;

Extensions (32)

Extension
Author (truncated)
Version

include-autocomplete
ajs
0.0.4

sourcetrail
ast
0.0.2

doxdocgen
csc
0.5.2

gitlens
eam
10.2.1

cmake-test-adapter
fre
0.5.0

todo-tree
Gru
0.0.169

vscode-test-explorer
hbe
2.17.0

vscode-gist
ken
3.0.3

vscode-clangd
llv
0.0.21

vscode-catch2-test-adapter
mat
2.8.8

vscode-docker
ms-
1.0.0

vscode-language-pack-en-GB
MS-
1.43.6

python
ms-
2020.2.64397

cmake-tools
ms-
1.3.1

cpptools
ms-
0.27.0-insiders2

cmake
twx
0.0.17

better-comments
aar
2.0.5

blender-python-code-templates
ble
0.9.6

lsl-fp
Dal
1.2.1

vsc-material-theme
Equ
32.5.0

vsc-material-theme-icons
equ
1.1.4

better-cpp-syntax
jef
1.14.24

vscode-docker
ms-
1.0.0

vscode-language-pack-en-GB
MS-
1.43.6

remote-containers
ms-
0.106.0

remote-ssh
ms-
0.50.0

remote-ssh-edit
ms-
0.50.0

remote-wsl
ms-
0.42.3

vscode-remote-extensionpack
ms-
0.19.0

material-icon-theme
PKi
4.0.1

code-settings-sync
Sha
3.4.3

discord-js-boilerplate
sir
0.0.2

(2 theme extensions excluded)

I think it is using high CPU, I think it is masked by the 8 cores and shows as less overall. I'll dig deeper on that next time I see it.
I have not been using any local windows, but I have a windows c++ project I can work on over the next few days so that will perhaps help. I'll update when I have something useful to add. Thanks and have a great weekend

At least in the details in the original post, all processes are showing 0% CPU, but you can run code --status when the issue happens again to collect the info again.

Do you think the report #92369 matches what I was seeing? It sounds plausible. I've updated to 1.43.1 If I don't update this again I think it is safe to assume it was the same/similar root cause.

It's possible! Let me know if you see it again.


Task/50 bounding volumes falling demo

One should think twice before pushing "load Bunny.hpp diff"...


Lesson Instructions unclear

After using the various other Waypoint formats, running into this created confusion. It made me believe I somehow had to use .text() in the solution. Perhaps some rearrangement of the paragraphs or a clarification of what the solution asks for will help.

Can you be most specific on which Waypoint instructions are unclear or at what point did the confusion start?

Closing since no details have been provided. Please provide more details if you are still experiencing issues.


Unbalance quote

Fixes #86

Removed the quote (and period at the end) and simply replace it with a colon right after "Use"


Rebase 08/04/2023

/assign @jakobmoellerdev

/lgtm no obvious issues here, everything should be backwards compatible


Add query for branch coordinates

Codecov Report
Base: 91.44% // Head: 91.59% // Increases project coverage by +0.15% :tada:

Coverage data is based on head (df4bd37) compared to base (4838e75).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   91.44%   91.59%   +0.15%
==========================================
  Files           8        8
  Lines         713      726      +13
  Branches       44       44
==========================================
+ Hits          652      665      +13
  Misses         54       54
  Partials        7        7

Impacted Files
Coverage Δ

cimsparql/data_models.py
100.00% <100.00%> (ø)

cimsparql/model.py
81.74% <100.00%> (+0.46%)
:arrow_up:

cimsparql/templates.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update RESULTS_GUIDELINES.md

Proposing addition to results guidelines to cover guidelines for MLPerf power submissions.

apologies for delay -- this wording looks good to me and I much appreciate the expanded examples!

Ping?

@tjablin looks ready for merge to me -- I don't have write access to this repo

I suggest we clarify by changing "Submitters are prohibited from making comparisons..." to "Submitters are prohibited from making any public comparisons..."
This restricts the PR to what's enforceable.

@DilipSequeira : Made the change.

Inference WG approve this PG


TextAlignment broken on TextInput in Fuse 1.1.0

Reported on community.
Tested on Windows 10 and macOS.
Fuse 1.1.0 build 13808.
Affected: local preview and dotnet build, Android preview and build.
Not affected: iOS preview and build.
Repro:
<App>
    <TextInput Alignment="VerticalCenter" TextAlignment="Center" PlaceholderText="This Should be centered." Margin="8" />
</App>

On local preview, the caret is aligned to the very left edge of the TextInput, when it should be aligned to the left edge of the PlaceholderText value (it does that on iOS). When you start typing, caret moves to the expected place and the content you enter appears correctly centered. When you release focus, the content stays centered too which is as expected.
On Android, the PlaceholderText is aligned to the left (should be in center), then when you focus the TextInput it becomes centered and looks exactly like it would on iOS which is as expected, and it's fine while you're typing; no problems with caret position either. Then when you release focus, the content aligns to the left again.

The forum thread Textinput not respecting textalignment properly posted by<EMAIL_ADDRESS>was linked to this issue.

Not broken in release-1.0. git bisect incoming


Refactoring batch normalization

@fchollet
Sorry to open new pull request, since there was an issue to modify my forked repository.
I updated the code as your advice.
Furthermore, I'd love to contribute to more impactful project also. so, if you let me know, I think I could try that.
Thank you.


Matrix equality: Implement M == None, raise exception for unknown types

The following statements now no longer give a cryptic error message:
>>> import mpmath, numpy
>>> mpmath.eye(2) == None
False
>>> mpmath.eye(2) == numpy.eye(2)
...
NotImplementedError: Unsupported type for testing equality: mpmath.matrix == <type 'numpy.ndarray'>

Isn't the recommended way to handle unsupported comparisons to return NotImplemented?

My intention was to keep behavior backwards-compatible and fail loudly instead of silently, especially for the case of numpy matrices. If the working precision is not too large, mpmath and numpy matrices can be semantically equal, so I think it should not be that mpmath.matrix(list) == np.array(list) is False. Unfortunately, as far as I understand, Python will return False for the comparison of two objects that each return NotImplemented in __eq__.

I now pushed a new version that uses NotImplemented. The semantics are now more consistent with the Python standard, and - surprisingly - comparison with numpy works. However, some results are counterintuitive:
>>> import numpy
>>> import mpmath
>>> A=numpy.array([42])
>>> B=mpmath.matrix([42])
>>> A == B
array([ True], dtype=bool)
>>> A == 42
array([ True], dtype=bool)
>>> B == 42
False
>>> any(B==42)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'bool' object is not iterable
>>> A == [42]
array([ True], dtype=bool)
>>> B == [42]
False
>>> any(A==42)
True

See that [42] == A and A == B but not [42] == B.

Please fix merge conflicts an reopen, if you wish

rebased, please reopen (I don't see a button for reopening) :-)

Hmm, "Reopen and comment" button looks as gray for me...  Feel free to open a new pr, if this seems relevant to you.

continued in https://github.com/mpmath/mpmath/pull/686


Use cargo_hakari to maintain workspace_hack module

https://docs.rs/cargo-hakari is the modern way to maintain workspace_hack crates. Alternatively, investigate if workspack_hack is worthwhile for us, or if we should just remove it.

Implemented in #1416


Fix typos

Hi @kianmeng,
Thanks for providing this PR. If you don't mind, please update the change to exclude any changes from the priv/static path. While it's true that you caught some spelling issues there, those files are generated from the official Playwright node.js repo, and it wouldn't make sense to fix the spelling here.
I'm definitely happy to have your contributions. Thanks!

@coreyti Sure. Please check.

Looks good, @kianmeng; merged. Thanks for your contribution!

:tada: :tada: :tada: :tada: :tada:


new aegir always gives scary error

Can this be improved? //cc @vmx

It happens in modules that have no browser.js file.

Are you scared about the Module not found warning, or the webpack summary?

ahah I'm not "scared" :P, but it does print a ton of stuff for just not finding a browser.js (all of those lines are printed just because one file is not found).


Feature/router

Added matched route name to RouteMatch object
Modified Url view helper to work with the RouteMatch object

Reviewed, merged, and pushed to master.


Adding http logger to the requests

I tried to add http_logger package to my project and it asked to add http_middleware package.
https://pub.dev/packages/http_logger
https://pub.dev/packages/http_middleware
I got this error
Because graphql 3.1.0 depends on http ^0.12.0+4 and no versions of graphql match >3.1.0 <4.0.0, graphql ^3.1.0 requires http ^0.12.0+4.
And because http_middleware >=1.0.0 depends on http ^0.11.3+16, http_middleware >=1.0.0 is incompatible with graphql ^3.1.0.
And because graphql_flutter 3.1.0 depends on graphql ^3.1.0 and no versions of graphql_flutter match >3.1.0 <4.0.0, http_middleware >=1.0.0 is incompatible with graphql_flutter ^3.1.0.
So, because mmd_ecommerce_fl_lib depends on both graphql_flutter ^3.1.0 and http_middleware ^1.0.0, version solving failed.
pub get failed (1; So, because mmd_ecommerce_fl_lib depends on both graphql_flutter ^3.1.0 and http_middleware ^1.0.0, version solving failed.)
I need a way to use the http_logger or if the library uses another way to log request kindly let me know

Use dependency overrides
https://dart.dev/tools/pub/dependencies#dependency-overrides

I had already tried that but it fails because
the flutter pub get can not find a convenient version between
the  graphql_flutter and http_middleware packages.
the first one requires http ^0.12.0+4
second one requires http ^0.11.3+16
if you try to use dependency_overrides like this
dependency_overrides:
http: ^0.11.3+16
or this
dependency_overrides:
http: ^0.12.0+4
you will get the following error in both cases
no versions of graphql match >3.1.0 <4.0.0, graphql ^3.1.0 requires http ^0.12.0+4.
because http_middleware >=1.0.0 depends on http ^0.11.3+16
and finally version solving failed.
this is my pubspec.yaml --> if you want to have a look on it and all repo
https://github.com/BeshoyMelika/mmd-ecommerce-fl-lib/blob/master/pubspec.yaml

Here is your fix
example/pubspec - https://tppr.me/9NjqD
pubspec - https://tppr.me/2bpVT

I really appreciate your effort with me -- but still not working .. kindly check the screenshot you will find all dependency together and the error with them.

There are two files required to be modified.
in project root and in example root

Really I am grateful for your help --> thank you very much
I did not notice that I must update both files of pubspec.yaml.
it is new info for me. so, thanks and thanks and thanks
Unfortunately, the http_logger will not fit with my project so
I decided to make the logger by my self, and I used this library as a reference
https://github.com/azamat-murzagalin/http_ui_logger
Again and again, thank you very much.


Fix environment variables

Renamed environment variables. Still needs a workaround for this possible Travis CI bug, which is already present in the repository .travis.yml.
There should be no new release before that issue is not fixed.

Fixed with 247f84a3fa47df716f38955751f1a845ad735caa.


[csharp] Initial Commit

Added new module and linked respective build files
DotNetAstGen successfully downloaded during compilation
Test fixtures and initial test skeletons created

@DavidBakerEffendi I think you need to add similar script for csharp - https://github.com/joernio/joern/blob/master/joern-cli/frontends/gosrc2cpg/gosrc2cpg.sh


Add Long Divide Spark function #9595

support Spark IntegralDivide function.
div
expr1 div expr2 - Divide expr1 by expr2. It returns NULL if an operand is NULL or expr2 is 0. The result is casted to long.
Examples:
SELECT 3 div 2;
1

Please update the PR title


fix(liquidity): Remove input label

GH Issue
Liquidity can be added ore removed, the text "You Give" is incorrect

What does this PR do?
Removes Input Label  for liquidity
Steps to test

go to liquidity page
no input label should be showing

We need a label, not only for consistency and accesibility but also because the input placeholder

@murillojorge Hows this?


fix #651

looks like all the temp stuff is not needed here.
UnitTests running without error over Shrink

@schulz3000 thansk, but to fix #651 need pass tempDisk as parameter 8077c4e


Update CODE_OF_CONDUCT.md

update code-of-conduct-md

"electron-alternatives" to "awesome-electron-alternatives"

Thank you @karlaxwell


sparkline title/subtitle margin not changing

I am trying to change the margin on the title attribute for my sparkline charts. It appears that no vertical margin is being set. I have my title text size set to 40px and my subtitle size set to 14px. When the charts are created the title over laps the subtitle no matter what the margin is set to. Does anyone know why?

Sorry for the late response.
Fixed the issue, will be working fine in the next release.
You can also try setting title.offset / subtitle.offsetY to get some spacing in between.


Start to add very generic plotting controlled through YAML

Description
This is a start to controlling figure generation 100% through YAML. Would like some initial comments on design.
The tests/config/testDummy.yaml creates a figure like so:

@kevindougherty-noaa the idea is that the first part of the YAML would specify what data would be collected and stored in a dataframe to then be plotted by the second part of the yaml, see https://github.com/danholdaway/eva/blob/feature/plot_schema/src/eva/tests/config/ObsCorrelationScatterDriver.yaml for Dan and I's brainstorming doc (the first part)

@CoryMartin-NOAA I see, that makes sense. There would be a script within this repository that handles grabbing that input and returning the appropriate data?

yeah the dummy.py Dummy class handles that for now, but a more comprehensive class might be IodaObsSpace or GsiDiag or FV3ModelState for example.

Looks good to me @CoryMartin-NOAA. I like the design of splitting the creator in base into the data then graphics. It makes a lot of sense. I agree @kevindougherty-noaa that we will need careful documentation. Perhaps we should have a bit of a think about how to document the default Yamls. Probably we need to put lots of info in the docs but making sure we have a system in place to ensure docs updated might be tricky. Once we have this new structure finalized we should do some kind of documentation sprint

@danholdaway yeah one approach is to have comments for each entry in the default YAML, but is that the best approach? For example, default might not be 'all options'. So it would be good to have a place where all options are listed (and what the defaults are)

@danholdaway marked ready to review to PR into the develop-reorg branch so that any further changes I make can be minor (and allow you to more easily add the data I/O stuff)


Texscreen does not match screen if game window is resized at runtime.

Operating system or device - Godot version:
Windows 8 - Bleeding Edge Version (57c67fb0)
Issue description (what happened, and what was expected):
Shaders using 'texscreen' property get messed up if the game window is resized during runtime. The texscreen sample seems to get dealigned with everything. Starting a game up with any resolution does not seem to cause similar problems, only resizing at runtime.
Steps to reproduce:
Can be see easily in the texscreen demo by resizing the game window while the game is running. Other undiscernable visual glitches also seem to be present here.
Link to minimal example project (optional but very welcome):
Visible in texscreen demo (https://github.com/godotengine/godot-demo-projects)

there are many bugs with this, and the way Godot does texscreen copying seems to break on many platforms, will wait for 3.0 to rewrite it in a different way

this is fixed in 3.0 already


New Lawyer Suits

Redesigns and expands on the existing selection of Lawyer Suits,and updates the LawDrobe to dispense them.
Changes include:
-Added pinstriped versions of the Blue and Black Lawyer Suits
-Added a Brown Suit and Green Suit
-Replaced Purple Suit with a design more consistent with the other preexisting jumpsuits
-Added a Lawyer Badged variant of the preexisting Journalist jumpsuit
-Redid Lawyer Jumpskirt skirts so that they no longer go over the suit's jacket in an unrealistic way
-Added Office/Serious skirt variations of Jumpskirt sets

(As Visual Studio was being annoying, I am currently unable to provide non-sprite preview images. The following picture was taken by PursuitInAshes before the latest fix.)

Special thanks to the Cosmatic Drift discord, for design feedback and teaching assistance.

can i get some showcases

the old purple design looked better imo

They look good to me! I actually like the purple one a lot. I would love a video or something so I can get a better look at them in game.

I also prefer the old purple suit

It's ready to go now!

I think these look great, amazing job

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Updated the conflicting lawdrobe content file to include the changes made in the other conflicting pull. No longer conflicts

bloat

If you have a concern @Izk228, please state it in full

If you have a concern @Izk228, please state it in full

most of maintainers are against bloating the game with a lot of same sprites but just only with different color

I have gone over jumpskirts.yml and fixed the merge conflict- But to be honest about it, all I did was remove the conflict markers as no entries had been removed.

Thank you for your contribution, but I'll be closing this PR for a few reasons:

We really need guidelines on clothing. Normally this isn't a huge problem but, with something that adds this much, I can't just merge this in good faith.
All of these are basic recolors and should probably just be a part of some new set of color suits / these need to be at least greyscaled.
The review I gave this PR earlier in discord probably still mostly applies. These are building on sprites that need to be replaced.

Thank you for your contribution, but I'll be closing this PR for a few reasons:

We really need guidelines on clothing. Normally this isn't a huge problem but, with something that adds this much, I can't just merge this in good faith.
All of these are basic recolors and should probably just be a part of some new set of color suits / these need to be at least greyscaled.
The review I gave this PR earlier in discord probably still mostly applies. These are building on sprites that need to be replaced.

Your 2nd contention has several problems;
A grayscaling of a single suit template not only nullifies all possible built-in tie color combinations (likely why the originals were not grayscaled), but also eliminates the possibility of patterns, as exemplified by the 2 pinstriped designs,
And to blanket state that "all of these are basic recolors" not only ignores the above facts, but also forgets that the new suitskirt designs both repair a glaring design problem previously missed by the original,
and introduce an additional, new skirt design not previously implemented (which was chosen to be the best out of 6 alternatives by the people surveyed). The reason provided completely ignores this.
And as also conveyed in discord, most current end users were fine and used to the sprites to begin with, making them adequate to be built upon (as evidenced by their not having been replaced by a theoretically perfect version earlier). With all due respect, the problems carried in your opinion are dwarfed by much worse offenders- It's not like they're completely unshaded and outlined in black!

you can just have a template with multiple layers to color if you want differently colored ties

At a minimum, it's a fix and some new variations, grayscaled or not


Style/Alias doesn't allow any use of alias

According to comments in bbatsov/ruby-style-guide#377 alias is not strictly forbidden by the style guide and in fact can be more appropriate than alias_method in some cases—usually those involving lexical scope and a clear indirection to methods within the same scope. The Style/Alias cop needs refactoring to allow the use of alias in cases such as the following.
class Westerner
  def first_name
    @names.first
  end

  alias given_name first_name
end

I see the PR is merged, but in 0.35.1 I'm still getting that annoying Style/Alias: Use alias_method instead of alias. (https://github.com/bbatsov/ruby-style-guide#alias-method) even though https://github.com/bbatsov/ruby-style-guide#alias-method-lexically it should be permitted.  And the only option is Enabled.  I don't really understand cop internals, so I can't tell what it's doing.

@marxarelli disappeared and I didn't have time to work on this myself. Someone else will have to drive the work here to completion.
Basically, now the cop reflects an older version of the style guide.

I'm happy to help with some guidance.. I understand the ruby and the parser, but would need some help getting that into a tested coo
B mobile phone

On Dec 9, 2015, at 4:00 AM, Bozhidar Batsov<EMAIL_ADDRESS>wrote:
@marxarelli disappeared and I didn't have time to work on this myself. Someone else will have to drive the work here to completion.
Basically, now the cop reflects an older version of the style guide.
—
Reply to this email directly or view it on GitHub.

Sure. You can start work on this and we'll lend you all the help you need.

@alexdowad Yay! :rainbow: :heart: :sparkles: :100:

Sorry about being a total flake on this one. I'm glad it got done by @alexdowad !

I think the default should be prefer_alias_method. That was the behaviour before and upgrading a minor release should not break that expectation.

See https://github.com/bbatsov/rubocop#installation


Add support for file imports >2 GiB

Adding workaround recommended by requests maintainers for POSTing files >2GiB (Ref)
Tests have been updated.

@andrewdoss-bit need to add requests-toolbelt to test-requirements.txt

Also, should not matter since we're posting bytes but validated manually against bit.io with csv, xlsx, and sqlite files to be safe.


Use flutterw to manage a defined flutter version with this project

There is a project on GitHub https://github.com/passsy/flutter_wrapper which creates a script managing the flutter version as a submodule in the repository.
This has been proposed (or more required) in the context of deploying to F-Droid (see #190), but it is generally a good idea, as the repository will now come with the matching version of flutter.
The details on how to configure the local environment, please have a look at the project's readme: https://github.com/passsy/flutter_wrapper/blob/master/README.md
For now there is no support for Windows, so we still have the old build mechanism for that target. There is already an issue at https://github.com/passsy/flutter_wrapper/issues/13.
Generally it might be a good idea to run
git config --global submodule.recurse true

Code Review Checklist

[ ] Description accurately reflects what changes are being made.
[ ] Description explains why the changes are being made (or references an issue containing one).
[ ] The PR appropriately sized.
[ ] New code has enough tests.
[ ] New code has enough documentation to answer "how do I use it?" and "what does it do?".
[ ] Existing documentation is up-to-date, if impacted.

We will not need to do that for the F-Droid release. Better wait until there is flutter wrapper support for Windows as well to have a streamlined solution.

git config --global submodule.recurse true

Lets add to readme for preparation. The same thing actual for Winden too

The usual git advice is "don't use submodules" so is that a possibility? I.e. why are we using a submodule at all, and could we do it a different way instead?

The usual git advice is "don't use submodules" so is that a possibility? I.e. why are we using a submodule at all, and could we do it a different way instead?

There are use cases to rely on Git submodules and this is one of them. This repository already uses a submodule including the Dart wrapper for wormhole-william.
Flutter does so far not allow to pin it's version in the repository to achieve a reproducible build. This is the way which is currently recommended for F-Droid and it is a good idea in general, as you always use the matching version of flutter.

This repository already uses a submodule including the Dart wrapper for wormhole-william.

I think @ewanas had idea how to make our dart plugin more generic and use as any other flutter plugin, but we need to make through whole chain of it destiny->dart_plugin->c bindings->wormhole-william.
Anyway this is separate issue, which we should have and proceed discussion there.


books-keeper

🛠 Issue (Number)

Closes #
Description
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have made this from my own
[ ] I have taken help from some online resourses
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] The title of my pull request is a short description of the requested changes.

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

If applicable, add screenshots/deploying link.

Fix the documentation part


Add group level server properties for plugins belonging to a robot group

Is your feature request related to a problem? Please describe.
Currently, all robot plugins have a dedicated property file, for instance, ev3lejosv1.properties. There are robot plugins that belong to a robot group, for instance, ev3. These individual robot plugins also contain common properties that are applicable for that robot group. This could be refactored in a way that all common properties pertaining to the robot group are extracted to the robot group's property file, for instance, ev3-group.properties.
Describe the solution you'd like
The common robot properties could be extracted to a group level robot property file. More specifically, this issue deals with:

identifying robot plugins that belong to a group:

Arduino
Calliope
Ev3
...

identifying common properties that could be extracted for the robot group:

robot.sim
robot.multisim
robot.nn
...

updating server side code to accommodate these changes.

Describe alternatives you've considered
The branch feature/nn-for-all explicitly defines properties robot.nn and robot.nn.activations for each robot plugin in a robot group. This issue is an improvement on that idea, in that robot group level properties are being proposed, instead of robot plugin level properties.

fixed


Night mode update

Change some colors to make it look better :)

It's nearly impossible to read chart titles on the network page with dark mode enabled:

Could the colors be tweaked a bit?

Changed text colors for title and legend

Looking good!
One last remark before I shut my mouth :) Using dark blue for the wires that point at the text is not very easy to see on the dark background:

@Fornax96 i will check, probably used same(same config/unsplitable) color for background and line.

@Fornax96 done black/white

Perfect! Looks super professional now :D


Allow discord client to function without a gateway connection

I am somewhat confused as to what the nature of this issue is -- can you please elaborate? I do not believe that Concord would be very effective without a Discord gateway connection! Are you possibly talking about using Concord with other (not-Discord) Discord-compatible gateway emulations (e.g. Fosscord)?

Okay, that definitely makes sense. Yeah, there's definitely room for improvement there.


sql: expected 0 arguments, got 1

sql: expected 0 arguments, got 1
give you this error when you have a problem with the connection to the bd and then come back

Please provide a code sample, or the ticket will be closed.


Remove "unnecessary" imports.

Description
In each library where an import is removed, the library uses some elements
provided by the import, BUT there is another import which provides all of the
same elements, and at least one more which the library uses.
In this change, we remove the imports which can be simply removed in favor of
the other already present imports.
See https://github.com/dart-lang/sdk/issues/44569 for more information.
Related Issues
Tests
I added no following tests.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

🙌

🙌


Closes #5134.
What's being changed:
I included two new images, according to what is presented today when transferring a repository. Are they:

Note that in this image, I replaced the real name of the repository with the phrase "the name of the repository":

Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

@lucalves Thanks so much for opening a PR with the new images! I'll get this triaged for review 🎉

#5311

Someone to review this PR?

I just got a chance to review this @lucalves and it looks great 🎉 I'll update the branch and get this merged ✨ Thanks again for taking the time to update these screenshots!


GABRio

Update locale info.

Can you add your own logo and edit the information about your event on the index.md file?

Done! Thank you.


Port SAMOA  to Gearpump

Sub steps:

[x] . study SAMOA of its usage
[x] run SAMOA over Storm, and prepare an actual example
[x] Port SAMOA to Gearpump, and prepare a demo.
[ ] final delivery: PR, experiment module.

This depends on

Dag with loop
task emit Direct

PR is ready at https://github.com/apache/incubator-samoa/pull/54

migrated to https://issues.apache.org/jira/browse/GEARPUMP-60


Dashboard unauthorized

Hi I have received the error message as below:
Any idea how to fix it? many thanks
error fetching dashboard yf8ixI0iz: error obtaining dashboard from http://localhost:3000/api/dashboards/uid/yf8ixI0iz. Got Status 401 Unauthorized, message: {"message":"Unauthorized"}

Hi. The answer is in topic https://github.com/IzakMarais/reporter/issues/49

Opppsss, my bad. I haven't checked the previous answer carefully. Many thanks

@PiotrekOpole Thanks for answering.


drivers: dma: emul driver

Is your feature request related to a problem? Please describe.
Many Zephyr drivers incorporate what we call an emul driver. Since DMA is so critical to so many types of IP, it would be great to be able to have a software implementation of it to "hook up" or "stitch together" other emulated device drivers.
Covered to some extent by @sjg20 's and @cfriedt's talks at ZDS 2022
Overall, emul drivers provide a number of benefits

prototypical model for Driver API for the specific class of driver

physical drivers must mimic this behaviour

driver-specific DT bindings to allow for customization on a per-instance basis
drop-in replacement via DT phandle for emulated app regression testing
Fast, Functional Testing for application code (regression testing, prototyping, ..)

also includes fast functional sample applications

private API extensions

customizable backend functionality (e.g. "wiring" for gpio_emul)
test and cover very specific corner cases
such corner cases can be very difficult to reproduce in reality
coverage in safety-critical and high-reliability systems can be extremely important (think Automotive, Avionics, Infrastructure, ...)

Can be instantiated on any board, regardless of architecture (native_posix, qemu*, actual physical boards)
Can be used for more than just testing (e.g. gpio_emul_sdl.c)

Describe the solution you'd like

Probably an RFC to start off with

Outline DT bindings, testsuite integration, strategies
Buy-in from DMA subsystem maintainer @teburd
Suggestions / feedback from other emul driver authors

Describe alternatives you've considered
Not having a DMA emul driver (which is the case today). Not that anything is wrong with the DMA subsystem today, but we want Fast Functional Testing!
Additional context
May coincide with existing activities by @jgl-meta

Which dma are you looking to emulate? They all behave differently

Which dma are you looking to emulate? They all behave differently

All of them :-)

Which dma are you looking to emulate? They all behave differently

All of them :-)

I'm fine with adding emulators to DMA generally. So if you are suggesting emulating specific DMA controllers no objections from me.

I've got a branch going. Will make some additional progress on it shortly.


Auth updates

draft PR for auth logic (work in progress)
removed the previous client-side Auth0 library logic, cleaned up some details
adding some redux actions for login / logout (following recent discussions about auth flow: authentication and getting a token doesn't mean you have a user in our db yet, so probably need 2 separate actions / API requests for that)
I'm thinking we need at least 3 types of routes: LoggedIn / LoggedOut / regular Route
And redirection logic will depend on the state (authenticated, email confirmed, profile created ...)
Suggestions & feedback welcome

@mannykary @barathvk  @Naraujo13  @joaofnds would probably have good feedback also.


”Plopșoru”, ”Broșteni”, "Broștenii de Sus", "Ceplea", "Cursaru", "Deleni", "Izvoarele", "Olari", "Piscuri", "Sărdănești", "Văleni" are listed in the drop-down menu

Description:
”Plopșoru”, ”Broșteni”, "Broștenii de Sus", "Ceplea", "Cursaru", "Deleni", "Izvoarele", "Olari", "Piscuri", "Sărdănești", "Văleni" are listed in the drop-down menu alongside their corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Plopșoru"

Expected results
The location appears in the drop-down menu as "Sat Plopșoru, GORJ (Plopșoru)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Broșteni"

Expected results
The location appears in the drop-down menu as "Sat Broșteni, GORJ (Plopșoru)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Broștenii de Sus"

Expected results
The location appears in the drop-down menu as "Sat Broștenii de Sus, GORJ (Plopșoru)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Cursaru"

Expected results
The location appears in the drop-down menu as "Sat Cursaru, GORJ (Plopșoru)".

Step 10
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 11
Write in the search bar "Deleni"

Expected results
The location appears in the drop-down menu as "Sat Deleni, GORJ (Plopșoru)".

Step 13
Write in the search bar "Izvoarele"

Expected results
The location appears in the drop-down menu as "Sat Izvoarele, GORJ (Plopșoru)".

Step 14
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 15
Write in the search bar "Olari"

Expected results
The location appears in the drop-down menu as "Sat Olari, GORJ (Plopșoru)".

Step 16
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 17
Write in the search bar "Piscuri"

Expected results
The location appears in the drop-down menu as "Sat Piscuri, GORJ (Plopșoru)".

Step 18
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 19
Write in the search bar "Sărdănești"

Expected results
The location appears in the drop-down menu as "Sat Sărdănești, GORJ (Plopșoru)".

Step 20
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 21
Write in the search bar "Văleni"

Expected results
The location appears in the drop-down menu as "Sat Văleni, GORJ (Plopșoru)".


fix: handle BOM prefix in package.json

Hi there.
Caught an exception while parsing paralleljs package.json. It contains BOM prefix, so it just needs to be removed.
Similar issue: https://github.com/bazelbuild/rules_nodejs/issues/1448
Unexpected token  in JSON at position 0

Coverage remained the same at 100.0% when pulling 280d21df7577cbaba312256da6b526723dc7b022 on antongolub:fix_bom into a81a0443d5b70d01ef1ed8831065ef0d189aa235 on imsnif:master.


docs: fix typos

Just a few typo fixes. :wave: :fr:

Hi @algobot are you open source? :)

Algobot is just an account that puts the comments from Netlify actually :)

Hi @algobot are you open source? :)

@zeke As @Haroenv said, you can get this for you just by:

having a docs build command
linking your GitHub projects to a Netlify account
Creating a GitHub user that will be the user posting comments from Netlify (the one having the token)

That's it!

Thanks @vvo 👍


Bumping to latest imgui-rs version

Just bumping the two imgui crates to latest published versions
Thanks for the library :partying_face:

Thanks, I pushed some more updates, hope this works for you!


when using invenbin api, apps should default to invenbin app

when a user logs in, this method is used to get their tabs
getAppSettingsBySite
so this work item goal should already be true.
it doesn't seem so right now, so I'll leave this open for now.
if the domain is prasso, it's fine to rely on the user setting the active app to know what tabs to return.
but if the domain is not ( of the api) like if the domain is Invenbin - the default app should be the application that has been setup for that domain.

the app will build tabs based on what api site is target now