ERROR Operation timed out when attempting keybase device add

Hello, I've been trying to install the new keybase client on my Mac. When the client loads, I select 'Log In' under 'Already on Keybase?'. Then I enter my username, select the device I want to connect with (my laptop was in the list), and the client asked that I enter the following in a shell:

keybase device add

When I do this, I get the following response after a few seconds:

ERROR Operation timed out

I tried completely uninstalling and reinstalling.
Log ID is e1efac052d66d233e9465f1c
Thank you!

Did you run keybase device add on your other device or was it on the same device?

Same device. I never installed keybase on any other device.

yeah, that's the problem, but you're not the first person to have made this mistake (the instructions say to run that command on your other device)
Cc: @malgorithms  on this

Wait, what other device? I've only ever had keybase on this laptop.

I see now it says Run keybase device add on your other device and then type this code in here.
I missed that part about the other device; nevertheless, I'm not sure what that is referring to. Does this mean run the comment on a completely different instance, e.g. linux running in a VM?

@nealevans you have one physical device currently registered, a computer you named 'wopr':
https://keybase.io/nealevans/devices
Are you trying to run keybase on that computer, or on a different computer?

I'm a bit confused by this conversation.
@nealevans  - typically you're only ever asked to do that command when installing keybase on a 2nd device.
Example:

I install keybase on "imac" and login with my username and password.
Later, I decide I want to install keybase on a different machine, "macbook". When I enter my username, Keybase knows that I've already provisioned a device called "imac"; at this point, the only way to add a computer is to have the old one sign it in.
So, device 2 (macbook) asks me to run something on device 1 (imac).

This is the first time I've seen this confusion.
Perhaps, you did something like this:

installed on your mac (wopr as patrick said)
uninstalled keybase on your mac, or factory reset it, losing your keybase device key?
then installed again on the same mac? (It doesn't know it's the same mac, so it's asking you to go to it and type something on wopr to prove you're you)

Thanks for your help on this...would like to get to the bottom of it!

Ah, I think I see what is going on, perhaps. This machine is wopr:
➜  ~ uname -n
wopr.local
One thing that has happened since I installed keypads back on Sep 6 is that did an 'in situ' downgrade from a beta of macOS to the current 10.12.n. It wasn't a wipe and reinstall, but I installed 'over' the beta macOS (thereby keeping my apps and docs). That must have confused keybase somehow.
What is the typical output of 'keybase paperkey'? I'm trying to figure out where I might have saved off that key.
If I can't find that paperkey, do I have any other recovery options?

if you've lost your paper key (perhaps it's in a drawer/wallet/purse? it's 13 words long, I believe) and the device key somehow got lost in this OS version downgrade, then there's nothing we can do on our end...since your 2 keys are never on our servers.
In that case the only thing to do would be an account reset (accessible somewhere in that login menu), although to be clear, you would lose any data you have in KBFS or chat, and you would need to repost your twitter/whatever proofs.
So if you have that paper key written down somewhere, that's the best option.
I don't know anything about a macOS version downgrade or how that would affect Keybase's key store. If you do have data you're afraid to lose, then perhaps @gabriel might have an idea on whether your local key is recoverable. But that might be a pain, so if you don't have data in there, and you can't find your paper key, I would just advise the account reset.

@nealevans what do you see in ~/Library/Application Support/Keybase?  Is there a config.json file in there and a secretkeys.nealevans.mpack file?

@patrickxb, ~/Library/Application Support/Keybase doesn't exist.
@malgorithms, thanks for feedback. I haven't used kbfs or chat, so I don't have any data I have to worry about losing. Sounds like account reset and re-proofing is best best. I remember creating that paper key, but I didn't save it out (didn't follow my SOPs).
Good learning experience. Thanks guys!

Reset and restart working.
One little bug perhaps: even after reset and restart, I couldn't re-add device 'wopr'. I said it already existed. When I went in web UI to try to delete it, no device were listed.
To workaround, I just added 'wopr-2'.


HDFS-16011. Support ViewFs nested mount

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 57s

trunk passed

+1 :green_heart:
compile
21m 39s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 26s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
3m 48s

trunk passed

+1 :green_heart:
mvnsite
3m 13s

trunk passed

+1 :green_heart:
javadoc
2m 10s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 22s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
5m 48s

trunk passed

+1 :green_heart:
shadedclient
17m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 51s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
3m  7s
/patch-compile-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
3m  7s
/patch-compile-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
2m 42s
/patch-compile-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
javac
2m 42s
/patch-compile-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 24s
/results-checkstyle-root.txt
root: The patch generated 15 new + 189 unchanged - 3 fixed = 204 total (was 192)

-1 :x:
mvnsite
0m 54s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 44s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 52s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
5m 26s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 38s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

-1 :x:
unit
0m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

159m 25s

Reason
Tests

Failed junit tests
hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem

hadoop.fs.viewfs.TestFcCreateMkdirLocalFs

hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem

hadoop.fs.viewfs.TestViewFsConfig

hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs

hadoop.fs.viewfs.TestFcMainOperationsLocalFs

hadoop.fs.viewfs.TestViewFsLocalFs

hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2987/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2987

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 270aae149143 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c4a6a39c6bdda784e207c6ce199acb09b42c5630

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2987/2/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2987/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  4s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 16s

trunk passed

+1 :green_heart:
compile
20m 43s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m  5s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
3m 47s

trunk passed

+1 :green_heart:
mvnsite
3m 10s

trunk passed

+1 :green_heart:
javadoc
2m 12s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 16s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
5m 34s

trunk passed

+1 :green_heart:
shadedclient
16m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s

the patch passed

+1 :green_heart:
compile
20m 11s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
20m 11s
/results-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1992 unchanged - 0 fixed = 1993 total (was 1992)

+1 :green_heart:
compile
18m  5s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
18m  5s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1891 unchanged - 0 fixed = 1892 total (was 1891)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 48s
/results-checkstyle-root.txt
root: The patch generated 14 new + 189 unchanged - 3 fixed = 203 total (was 192)

+1 :green_heart:
mvnsite
3m  8s

the patch passed

+1 :green_heart:
javadoc
2m 12s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 19s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
5m 59s

the patch passed

+1 :green_heart:
shadedclient
16m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 17s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

-1 :x:
unit
387m 39s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

592m 23s

Reason
Tests

Failed junit tests
hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs

hadoop.fs.viewfs.TestFcCreateMkdirLocalFs

hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem

hadoop.fs.viewfs.TestViewFsConfig

hadoop.fs.viewfs.TestViewFsLocalFs

hadoop.fs.viewfs.TestFcMainOperationsLocalFs

hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem

hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.TestViewDistributedFileSystemContract

hadoop.fs.viewfs.TestViewFileSystemLinkFallback

hadoop.hdfs.TestDFSShell

hadoop.fs.viewfs.TestViewFileSystemLinkMergeSlash

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.TestViewDistributedFileSystemWithMountLinks

hadoop.hdfs.security.TestDelegationTokenForProxyUser

hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.fs.viewfs.TestViewFileSystemLinkRegex

hadoop.fs.viewfs.TestViewFileSystemHdfs

hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2987/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2987

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 5f09d5a7c667 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0b33b7b8b5f2e5bbb14d8453f2af37c500e0c4a8

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2987/3/testReport/

Max. process+thread count
3056 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2987/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Fix permissions for the canary code commit initialisation script.

During initialisation when terraform local-exec's the script to bootstrap
the code commit repo the script itself hasn't assumed the appropriate role
(as terraform has). So, an explicit assume role needs to happen.
Solo: @blairboy362

This all looks about right. Two questions just to make sure I fully understand the problem:

Did a particular story/commit introduce this bug? I wasn't aware the canary was broken and don't think this is related to kiam as it happens on a local machine?
Which role will be used for us as developers when deploying this and also for concourse? Is there a corresponding change to come for gsp-teams to allow the passing of the variable?

kiam broke this. If you're seeing a similar error locally, when running in the correct context (e.g. aws-vault), that's a different problem (have you deleted the code-commit cached credentials in your keychain?)
Yes, gsp-teams needs to be changed to pass the ARN down. The ARN is set in a concourse secret, which is working for the rest of the terraform so the same value just needs passing down.

To clarify, following a discussion with @idavidmcdonald, kiam isn't what broke this. The codecommit initialisation would never have worked from the context of the TechOps concourse (if my hypothesis of environment variable propagation proves to be correct).

Tested using my cluster...
From the context of gsp-teams:

aws-vault into my gds-users profile (so not assuming the run-sandbox admin role)
Configured the terraform backend to use local state (as it would have failed to write to s3 without the admin role creds)
Explicitly configured the (terraform) aws provider to assume the admin role
terraform apply failed with a 403 when running the init codecommit script
Switched to this branch
terraform apply succeeded


[Feature Request] Ultra-Wide Support (21:9 and 32:9)

Please add support for 21:9 and 32:9 aspect ratios

I do not control the game itself. The launcher is only a wrapper for the main project (snesrev's project) to create a simpler interface.


Consider Removing "Steps" from the Personalized Action Plan

We weren’t sure if having the PAP label things as “Steps” is accurate or helpful, or if numbers are helpful.
Issue submitted by Stacey Marz (AK)

@KellyeDC -  this is a design change.  We can save this one for governance board.

@KellyeDC  Agreed.


dispose method for instances

via @mjanssen https://github.com/processing/p5.js/issues/1118 :

When calling .remove() on a sketch, the remove function tries to dispose and stop files from other sketches (like it's global). It only happens with sound files. Other elements are removed properly.

It seems that, to make this work, we'll need to change the way that objects are created in p5.sound. They're currently instantiated like this:
new p5.AudioIn()
As a result, they only have a reference to the p5 class, not to the specific instance that created the object. So when they are created, they don't know which instance's soundArray to add themselves to (so that they can be disposed of later).
But if we change instantiation to something like this by extending the p5.prototype rather than p5 itself...
createAudioIn()
...then, they'd be global when p5 is global, otherwise pegged to an instance like this:
myP5.createAudioIn()
This would allow each instance to have its own soundArray.

In this issue, @toolness recommends a way that the current syntax (new p5.AudioIn()) can reference the p5 instance using Object.defineProperty()
https://github.com/processing/p5.js/issues/1263
This seems like the way to go!

hmm, so now that I think about it, this might be a bit tricky, because we're actually doing slightly differently in https://github.com/molleindustria/p5.play/pull/22. This is because p5.play's constructors are all attached to p5.prototype (rather than p5), which allows our defineLazyP5Property helper to latch onto the correct this value for the sketch.
Let me think about this a bit more and get back to you!


Apply command to...

I've been generating big runs of data in directories with UUIDs, and a lookup file that contains the UUID to parameters-what-were-used-to-generate-those-files. This has been pretty handy because all the files are uniquely identifiable and don't feature parameters that become unhelpful, or deprecated, etc. later.
Because of this hierarchy, I've found myself just applying operations to lists of UUID-named directories, so why not make this a part of chitin? We could just provide a script (or series of commands) and a bunch of UUIDs.

Bonus points if we submit the UUIDs and chitin knows they are on a remote server so I don't have to go and faff with them manually :3

this is basically snakemake like


Angular 6.0.0 Compatability

I get the following error when trying to build an Angular 6 project which contains the delivery sdk.
ERROR in ./node_modules/kentico-cloud-delivery/node_modules/parse5/lib/parser/parser_stream.js
Module not found: Error: Can't resolve 'stream' in '/Users/martya/…/node_modules/parse5/lib/parser'
ERROR in ./node_modules/kentico-cloud-delivery/node_modules/parse5/lib/sax/index.js
Module not found: Error: Can't resolve 'stream' in '/Users/martya/…/node_modules/kentico-cloud-delivery/node_modules/parse5/lib/sax'
ERROR in ./node_modules/kentico-cloud-delivery/node_modules/parse5/lib/sax/dev_null_stream.js
Module not found: Error: Can't resolve 'stream' in '/Users/martya/…/node_modules/kentico-cloud-delivery/node_modules/parse5/lib/sax'
ERROR in ./node_modules/kentico-cloud-delivery/node_modules/parse5/lib/serializer/serializer_stream.js
Module not found: Error: Can't resolve 'stream' in '/Users/martya/…/node_modules/kentico-cloud-delivery/node_modules/parse5/lib/serializer'

In my research into the issue I noticed that @Enngage has lodged a ticket about this on the official angular project. It seems like it's an underlying issue with Angular, however it's worth lodging an issue here so other's can see what's going on.
The only workaround which I've found is to install the stream package separately via npm npm install stream. This solves the issue for now but it would good if there's a better way.

Hi, have you seen our sample Angular 6 app ? It's currently running on Angular 6. There is an issue with Angular CLI which ignores dynamic require expressions which essentially means that it tries to include node specific, which of course, fails.
The workaround is to tell your app to use 'Browser' specific package which you can do in the ts.config.json. I have described this process in the main readme of the angular app above.
Additionally, you can see the code also here https://github.com/Enngage/KenticoCloudSampleAngularApp/blob/master/tsconfig.json#L16
Let me know how that works!

That worked perfectly, thanks!
Also in my case I'm running Angular Universal which runs seperate tsconfigs for server (nodejs) and browser, so I set the path as the non browser bundle on the server and it seems to work perfectly.

Awesome, glad to hear it! Thanks for the note, I've yet to use Angular Universal so I might incorporate that into the Angular example :-)

I was finally able to update to parse5 which strips the dependency out of Node so this should no longer be an issue. Though, the parse5 is relatively large library so I would recommend using browser specific package if possible anyway. (200KB vs 370KB)

@r3plica Have you seen the sample Angular application? You can see how tsconfig.json looks like right there: https://github.com/Enngage/KenticoCloudSampleAngularApp#angular-6-support

Yeah and I used it to build my application, but as martin has done, I am trying to create a Universal application. I think I understand what he has done (just testing now). Instead of using:
https://github.com/Enngage/KenticoCloudSampleAngularApp/blob/master/tsconfig.json#L17
I changed it to:
"node_modules/kentico-cloud-delivery/_bundles/kentico-cloud-delivery-sdk.umd.min.js"
But that also does not work. I get an error stating:
ERROR in src/app/core/models/scanario.ts(18,26): error TS2694: Namespace '"C:/Users/JaymieJeffrey/Documents/GitHub/pickyourbest/node_modules/kentico-cloud-delivery/_commonjs/fields/field-types".Fields' has no exported member 'UrlSlug'. src/app/core/models/scanario.ts(19,27): error TS2694: Namespace '"C:/Users/JaymieJeffrey/Documents/GitHub/pickyourbest/node_modules/kentico-cloud-delivery/_commonjs/fields/field-types".Fields' has no exported member 'UrlSlug'. src/app/core/models/tech-made-simple.ts(5,30): error TS2694: Namespace '"C:/Users/JaymieJeffrey/Documents/GitHub/pickyourbest/node_modules/kentico-cloud-delivery/_commonjs/fields/field-types".Fields' has no exported member 'RichText'. src/app/core/models/tech-made-simple.ts(7,32): error TS2694: Namespace '"C:/Users/JaymieJeffrey/Documents/GitHub/pickyourbest/node_modules/kentico-cloud-delivery/_commonjs/fields/field-types".Fields' has no exported member 'RichText'. src/app/home/home.component.ts(6,26): error TS2305: Module '"C:/Users/JaymieJeffrey/Documents/GitHub/pickyourbest/node_modules/kentico-cloud-delivery/_commonjs/index"' has no exported member 'CloudError'. src/app/buying-guide/pillar.component.ts(7,26): error TS2305: Module '"C:/Users/JaymieJeffrey/Documents/GitHub/pickyourbest/node_modules/kentico-cloud-delivery/_commonjs/index"' has no exported member 'CloudError'. src/app/buying-guide/pillar.component.ts(69,68): error TS2339: Property 'taxonomyTerms' does not exist on type 'TextField'. src/app/buying-guide/pillar.component.ts(71,94): error TS2339: Property 'taxonomyTerms' does not exist on type 'TextField'. src/app/buying-guide/pillar.component.ts(77,99): error TS2339: Property 'taxonomyTerms' does not exist on type 'TextField'. src/app/buying-guide/cluster.component.ts(7,26): error TS2305: Module '"C:/Users/JaymieJeffrey/Documents/GitHub/pickyourbest/node_modules/kentico-cloud-delivery/_commonjs/index"' has no exported member 'CloudError'.

Okey, so for Angular universal take a look at this sample application: https://github.com/Enngage/kentico-cloud-js-angular-universal-starter
It's pretty much the default starter provided by Angular team and only modified to load some data from Kentico Cloud. Can you try using that application on your end? You may notice that in order to fully leverage Angular universal, you need to use Angular's HttpClient for we provided a specific service.
Take a look at https://github.com/Enngage/kentico-cloud-js-angular-universal-starter/blob/master/src/app/home/home.component.ts#L21
Also, you need to use beta version of this library as you can see here: https://github.com/Enngage/kentico-cloud-js-angular-universal-starter/blob/master/package.json#L37
And finally, no extra configuration in tsconfig seems to be necessary here. The original issue in this thread was caused by Angular cli not properly building an application, but that seems to be fixed now.

Thanks for this, just a quick question. I created a factory to provide the delivery client. It looks like this:
`
import { DeliveryClient, TypeResolver } from 'kentico-cloud-delivery';
import { Attribute } from '../models/attribute';
import { Pillar } from '../models/pillar';
import { Scenario } from '../models/scanario';
import { TechMadeSimple } from '../models/tech-made-simple';
export const KenticoClientService = {
provide: DeliveryClient,
useFactory: KenticoServiceFactory,
deps: []
};
export function KenticoServiceFactory() {
return new DeliveryClient({
projectId: 'my-project-id',
typeResolvers: [
new TypeResolver('attribute', () => new Attribute()),
new TypeResolver('pillar', () => new Pillar()),
new TypeResolver('scenario', () => new Scenario()),
new TypeResolver('tech_made_simple', () => new TechMadeSimple()),
]
});
}
`
Any idea how to add the angularHttpService to that?

So, in this case you need to provide the angularHttpService as a dependency through your deps in factory and then add this as a parameter to your KenticoServiceFactory function. Some information about this is in Angular docs here: https://angular.io/guide/dependency-injection-in-action#defining-providers
Hope that helps.

When you say angularHttpService, do you mean HttpClient?

I have changed my service to:
import { Injectable } from '@angular/core';
import { IDeliveryClient, DeliveryClient, TypeResolver } from 'kentico-cloud-delivery';
import { AngularHttpService } from 'kentico-cloud-angular-http-service';
import { Attribute } from '../models/attribute';
import { Pillar } from '../models/pillar';
import { Scenario } from '../models/scanario';
import { TechMadeSimple } from '../models/tech-made-simple';
import { WhatToLookFor } from '../models/what-to-look-for';
import { Blog } from '../models/blog';
import { QuickThree } from '../models/quick-three';
@Injectable({ providedIn: 'root' })
export class KenticoClientService {
deliveryClient: IDeliveryClient
constructor(angularHttpService: AngularHttpService) {
this.deliveryClient = new DeliveryClient({
projectId: 'da5abe9f-fdad-4168-97cd-b3464be2ccb9',
httpService: angularHttpService,
typeResolvers: [
new TypeResolver('attribute', () => new Attribute()),
new TypeResolver('pillar', () => new Pillar()),
new TypeResolver('scenario', () => new Scenario()),
new TypeResolver('tech_made_simple', () => new TechMadeSimple()),
new TypeResolver('what_to_look_for', () => new WhatToLookFor()),
new TypeResolver('blog', () => new Blog()),
new TypeResolver('quick_three', () => new QuickThree()),
]
});
}
}
does that look right to you?

Using that service, it does work.

Yes, that is the correct use of the service.


Make pip-installable on Windows

Installation on Windows-Systems (pip install or make install-for-dev) is currently not working.
The first issue is support of rq-win, which is not on Pypi but needs to be installed from GitHub (see their Readme).
There might be some other dependencies not working. This ticket should see if those can be sorted out.
Developers on Windows can still work with FlexMeasures today if they use Docker. Docker Desktop should be an easy installation, then this documentation explaines it further.

Have you tried make install-for-dev on the latest main, which includes #670 ?

I installed rq and rq-win by using git+repo_link method as you have you mentioned for rq-win. With this method I got a new issue, see the image. I fixed it by ignoring the links that starts with git in the requirements list install_requires in setup.py
    with open("requirements/%s.in" % use_case, "r") as f:
        reqs = [
            req
            for req in f.read().splitlines()
            if not req.strip() == ""
            and not req.strip().startswith("#")
            and not req.strip().startswith("-c")
            and not req.strip().startswith("--find-links")
            and not req.strip().startswith("git")
        ]
    return reqs

After these changes, flexmeasures at least runs on windows. I will do extensive testing using toy-tutorial and also will try to install coinor-cbc [https://github.com/coin-or/Cbc]
)Let me know, if it's a good idea or we must install these modules by some other method.

Good analysis. At the very least, we could let developers install locally. If I have an idea about pip I'll let you know.

I installed rq and rq-win by using git+repo_link

Just out of interest: why did you do that for rq, as well?

It seems that pip doesn't let us print a warning - only errors will make it to the user.
I don't think an error is nice, as you can install it right? @Ahmad-Wahid have you run tests (without or with installing rq-win manually?)
In any case, I propose we add a note on https://flexmeasures.readthedocs.io/en/latest/dev/introduction.html:
If you are on Windows, then running & developing FlexMeasures will not work 100%. For instance, the queueing only works if you install rq-win (link) manually and the make tooling is difficult to get to work as well.
We recommend to use the Windows Sub-system for Linux (https://learn.microsoft.com/en-us/windows/wsl/install) or work via Docker-compose (https://flexmeasures.readthedocs.io/en/latest/dev/docker-compose.html).

yes, I tested with rq-win manual installation but that doesn't work too. Anyways, I will create a PR to update the doc with this note.


cli: Restore cilium cleanup behaviour

when no flags(--all-state|--bpf-state) are specified fallback to
--all-state to keep the previous cilium cleanup behaviour
Fixes: 6145cb56c89086 ("k8s: Merge initContainer cleanup with cilium cleanup")

This change is

Coverage increased (+0.008%) to 41.769% when pulling f5feac4b173705335b77d2b781eb98e14df636c3 on restore_cleanup into 6667938d9377c06fcaace360b0ea7e9a64f217fd on master.

test-me-please

Hi @nirmoy init-container.sh currently relies on the command being a no-op if no flags/env-vars are set (we didn't think the behavior change will be disruptive at the time :P) and could mean that only restoring the previous behavior will clear state everytime on cilium pod startup.
In which case it might be needed to e.g add back detecting environment variables to the script to avoid calling cilium cleanup unless needed.

@nirmoy can you describe how you're relying on the previous behaviour?
As-is, it looks like this PR will break upgrades as all information about endpoints will always be lost during upgrade. Why isn't this showing up in CI? I suspect because the contrib/packaging/docker/Dockerfile.init docker image is not being rebuilt against these changes, and the new version isn't added to the examples/kubernetes/Makefile, nor are new k8s YAMLs being generated to depend on the new init container image. So the code changes here unfortunately affect the init container, but are not automatically tested in the CI without additional developer input.

@iffyio @joestringer Okay I understand the problems with this PR now :). There was no disruption and the use case is personal.  cilium cleanup doing nothing still looks sneaky to me.  I updated the PR to take care of  init-container.sh. Let me know WDYT,  I don't mind closing this PR as it is mostly because of my personal use of cilium cleanup

The new version seems fine to me. IMO we should also integrate the descriptions from the docs into the CLI tool, so that users who stumble across this tool can understand the repercussions of running it: http://docs.cilium.io/en/latest/kubernetes/configuration/#configmap-options
We should also make sure to go through the process of creating the new init images from this PR so that we can actually test these changes in the CI. The process should be similar as for cilium-builder / cilium-runtime images: http://docs.cilium.io/en/latest/contributing/#update-cilium-builder-and-cilium-runtime-images . Feel free to ask in #development on Slack if you have any questions about this process.
@iffyio, are you happy with the new version of this patch?

Yes I'm happy with the change! Agree that it can be unintuitive to e.g run cilium cleanup -f and have it do nothing.
One suggestion is to instead detect the CILIUM_ALL_STATE and CILIUM_BPF_STATE environment variables, that deprecate CLEAN_CILIUM_STATE and CLEAN_CILIUM_BPF_STATE, in the script - The former are currently being set for the init container while @aanm  suggested to keep the latter around for a while for backwards compatibility.

@iffyio review again. I am keeping both env vars for backward compatibility.

Thanks @nirmoy I think this looks good!

I'm not sure I follow, what's the difference between the old env variable names and the new ones?

@iffyio can you clarify if we still need old env file in the script.

The new env variables were only introduced to be consistent with how env variables were created in cilium e.g using the CILIUM_ prefix. I think we might need to reference the old ones in the init script if it's possible that there are yaml files that set the old variables but use a newer image and want to be backwards compatible with them? Since otherwise e.g CLEAN_CILIUM_STATE would be set but the script won't invoke the tool.
yeah in any case, it would be simpler to invoke cilium cleanup -f if any of the flags are set to avoid duplicating some logic of which state to cleanup in the script.


metrics: SendSumOfHistograms to support native histograms

To facilitate aggregating native histogram metric over some labels, typically "user" / "tenant" in Mimir.
This is necessary as some Prometheus metrics start to support native histograms, Mimir wants to emit them per container (i.e. pod) and not per tenant of which there could be 100s, 1000s.
For example:
prometheus_tsdb_compaction_duration_seconds of Prometheus is generated for every tenant inside Mimir ingester, but exposed via DSKIT metrics function as a sum of those in cortex_ingester_tsdb_compaction_duration_seconds .
Recently prometheus_tsdb_compaction_duration_seconds has acquired a native histogram version. See PR: https://github.com/prometheus/prometheus/pull/13681
To be able to expose the aggregated native histogram dskit/metrics needs to support it.
Adding up native histograms is not as easy as the code for classic histograms. This is because native histograms can have different buckets, different resolution and/or zero threshold.
Task:  implement accumulating native histograms information , that is implement adding up native histograms.
Scope: it is enough to consider integer native histograms where count, zero count are integers and only positive and negative deltas as utilized in the dto.
Suggested implementation: port the relevant code from prometheus to dskit, adopted to the data types used in dskit and restricted to integer values.
Note: the current code does not have protection against integer overflow , so this can be out of scope as first step. Later we might consider switching to storing the output in a float histogram - by default or as needed.
Part of the work in https://github.com/grafana/mimir/issues/5020

Beorn pointed out that this doesn't work due to counter resets happening in the input.


Merge test utils to @hpke/common.

Codecov Report
Attention: Patch coverage is 46.87500% with 51 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (844f50b) to head (804b57a).

Files with missing lines
Patch %
Lines

packages/common/src/utils/misc.ts
40.00%
51 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   92.04%   90.93%   -1.12%
==========================================
  Files          54       54
  Lines        3811     3906      +95
  Branches      352      360       +8
==========================================
+ Hits         3508     3552      +44
- Misses        302      353      +51
  Partials        1        1

Flag
Coverage Δ

unittests
90.93% <46.87%> (-1.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feature/onetouch

A small bug in one touch server, the debug panel is reversed and need to change the rudder mapping to
TeleopView Line 157
double rudder = -2.0f * (finger[0].x / mWidth) + 1.0f;

Closing, as this was addressed in #12.


Histogram tooltip issue

Wave SDK Version, OS
h2o_wave 0.22.0
Actual behavior
The low - high value is the two number concatenated together which seems strange

Expected behavior
Steps To Reproduce
from h2o_wave import main, app, Q, ui, data

@app('/')
async def serve(q: Q):
    q.page['example'] = ui.plot_card(
        box='1 1 7 5',
        title='Interval',
        data=data('price low high', 8, rows=[
            (4, 50, 100),
            (6, 100, 150),
            (8, 150, 200),
            (16, 350, 400),
            (18, 400, 450),
            (10, 200, 250),
            (12, 250, 300),
            (14, 300, 350),
        ]),
        plot=ui.plot([ui.mark(
            type='interval',
            y='=price', y_min=0,
            x1='=low', x2='=high',
        )])
    )

    await q.page.save()

Thanks for reporting @mtanco! It must be the bug introduced by #1330. I've just created a PR with the fix.


[Potential bug] - Fail to deprovision the provisioned asset (HttpData-PULL)

Discussed in https://github.com/eclipse-edc/Connector/discussions/4613

Originally posted by xdxxxdx November 10, 2024
Hello EDC team,
I'm working with a connector configured using the HTTP Provision extension (link). The asset and its associated contract are published and accessible:
{
  "@context": {
    "@vocab": "https://w3id.org/edc/v0.0.1/ns/"
  },
  "@id": "asset-pro",
  "properties": {
    "name": "provision product description",
    "contenttype": "application/json"
  },
  "dataAddress": {
    "name": "Test asset",
    "type": "HttpProvision",
    "baseUrl": "https://jsonplaceholder.typicode.com/users"
  }
}

The connector is configured with:
provisioner.http.entries.default.data.address.type=HttpProvision

Steps to reproduce:

When the consumer connector initiates the transfer with the following request:
{
  "@context": {
    "@vocab": "https://w3id.org/edc/v0.0.1/ns/"
  },
  "@type": "TransferRequest",
  "connectorId": "did:web:localhost%3A7093",
  "counterPartyAddress": "http://localhost:19194/protocol",
  "contractId": "c772dd07-d05b-4a63-a542-4b06f44ff8ec",
  "assetId": "asset-pro",
  "protocol": "dataspace-protocol-http",
  "transferType": "HttpData-PULL"
}

The connector successfully calls the external provisioner to provision the asset. The provisioner responds with:
{
    "edctype": "dataspaceconnector:provisioner-callback-request",
    "resourceDefinitionId": "626d96ea-9955-4524-b5a1-2a37cf2efa7e",
    "assetId": "asset-pro-3",
    "resourceName": "ProvisionedResource",
    "contentDataAddress": {
      "properties": {
        "https://w3id.org/edc/v0.0.1/ns/type": "HttpData",
        "https://w3id.org/edc/v0.0.1/ns/baseUrl": "https://jsonplaceholder.typicode.com/users"
      }
    },
    "apiKeyJwt": "unused",
    "hasToken": "false"
}

I attempt to terminate the transfer process with:

curl --location 'http://localhost:19193/management/v3/transferprocesses/e382b099-82b9-43d3-a965-23ae640555e4/terminate' \
--header 'Content-Type: application/json' \
--data-raw '{
  "@context": {
    "@vocab": "https://w3id.org/edc/v0.0.1/ns/"
  },
  "@type": "https://w3id.org/edc/v0.0.1/ns/TerminateTransfer",
  "reason": "a reason to terminate"
}'

This operation results in an error:
SEVERE 2024-11-10T14:36:45.708589406 Error deprovisioning resource 30f2fc2d-cb66-4598-b0a5-3aaffdfea5e0 for process e382b099-82b9-43d3-a965-23ae640555e4: Unknown provision type org.eclipse.edc.connector.controlplane.provision.http.impl.HttpProvisionedContentResource

My questions:

Is it possible for the provisioning control plane to work with the HTTP data plane?
If so, what would be the correct approach to deprovision the asset?

Thank you so much !

Thanks for the fix @ndr-brt !!


Transition functions do not return the selected elements on completion

All transition functions should return the selected elements on completion.

Fixed.


Add separate text outline property

For #225.  As discussed there, adds a separate property textOutlineWidth.  Also as mentioned in the issue, I haven't added a separate test for this change because I'm not familiar with how the tests work -- might be nice to have something there before merging.

Waiting for this PR in master. Will be it merged soon?

@spatialillusions  do you have time to cut a new NPM release that includes these changes?  I'm currently using a github: URN but it'd be nice to have a versioned package instead.


Implement Serialization and Deserialization for Verbosity

This commit adds serialization and deserialization support for the
Verbosity type. The verbosity is serialized as an optional log level
that represents the equivalent log level given the number of verbose and
quiet flags. When deserializing, the log level is converted into a
number of verbose and quiet flags, which keeps one of the flags at 0 and
the other at the difference between the log level and the default log
level.
The internal representation in calculations has been changed from i8 to
i16 to prevent overflows when performing calculations using u8 values.
Fixes: https://github.com/clap-rs/clap-verbosity-flag/issues/88

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 27 (0.0%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-9.2%) to 6.061%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/lib.rs
0
8
0.0%

src/serde.rs
0
19
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
4
8.51%

Totals

Change from base Build<PHONE_NUMBER>1:
-9.2%

Covered Lines:
4

Relevant Lines:
66

💛  - Coveralls

In eb58de2d699758a72b437a83059d01c9179aa407, I rewrote this based on the 3.0 release. Notably this uses the VerbosityFilter to de/serialize instead of log::LogLevelFilter which means that it only handles Title case deserialization. I've also simplified the style and quantity of tests significantly.


[Chore] Remove AppSignal

:clipboard: fixes https://github.com/omisego/elixir-omg/issues/767, replaces https://github.com/omisego/elixir-omg/pull/820
Overview
We've merged https://github.com/omisego/elixir-omg/pull/775, https://github.com/omisego/elixir-omg/pull/812, and are bringing APM to life in https://github.com/omisego/elixir-omg/pull/851.
This PR removes the last bits of AppSignal.

This is now all in https://github.com/omisego/elixir-omg/pull/851, closing.


makes extension work on www.nzz.ch

This makes the extension run on www.nzz.ch
styling is not really nice for now though but feel free to merge, it does not break the layout at least.

Awesome, thank you Beni

:+1:


Missing changelog

Hi,
Changelog in 0.9 and master are outdated, no entry about 0.9.5 / 0.9.6.
Please http://keepachangelog.com/

My bad! I've not really paid much attention to 0.9 and I've just been lazy with 1.0. If anyone wants to chip in and put something down, please feel free, otherwise I'll get around to it at some point.


[Governance] Mobile behaviour

Feature [Governance] – Browsing governance on mobile or tablet

As a an end-user,
I want to explore the governance of a Data space on a mobile / tablet
So that I read the terms and conditions of its section, subsections, articles and paragraphs

Acceptance criteria
Scenario 1: Default display (Mobile & Tablet)
Given that I am a user of the web portal (unauthenticated or authenticated)
And I'm on a Data Space governance page after clicking on Access governance on data space page,
Then I should land on the first section and first subsection available
And the field has

Drop-down menu with title of the section and down chevron
Text area with section title
Text area with description of the section (only if available)
Text area with sub-section title
Text area with description of the sub-section (only if available)
A container
-- Text area with article title
-- Text area with article description
Paragraph card (if available)
-- Paragraph icon
-- Paragraph title
-- Paragraph description

Note that every section has at least a sub-section with at least an article (paragraph is not mandatory, if paragraph available then automatically it has a description)
see mockup 1 (with and without descriptions)
Scenario 2 : Container behaviour - subsection w/ 1 article
Given that I am a user on a data space governance page
When I select a section with the selected subsection having only one article
Then the container is by default open
And the container has the article title on top
And the container has the description of the article as a subtitle (only if available)
and a card representing each paragraph
see mock-up 1
Scenario 3 : Container behaviour - subsection w/ 2+ articles
Given that I am a user on a data space governance page
When I select a section with the selected subsection having 2 or more articles
Then the first container of the first article is by default open
And the other containers of the following articles are closed
See mock-up 2
Scenario 4 : Container Open - subsection w/ 2+ articles
Given that I am a user on a data space governance page
When I select a section with the selected subsection having 2 or more articles
Then the open container displays

On the left : the title of the article and as a subtitle the description of the article if available
On the right :

a square with the number of paragraphs in the article (starting from 1)

chevron up icon
Mock-up 3

Scenario 5: Container closed - subsection w/ 2+ articles
Given that I am a user on a data space governance page
And I am using a desktop device,
When I select a section with the selected subsection having 2 or more articles
Then the closed container displays

On the left : the title of the article
On the right :

a square with the number of paragraphs in the article (starting from 1)

chevron down icon

Scenario 6: opening & closing a container
Given that I am a user on a data space governance page
And I select a section with the a subsection having 2 or more articles
When I click on the top part of the container
the click must be available on the whole top part (title, empty area, number, chevron)
Then  it closes if it's open (or opens if it's closed)
Scenario 7: Paragraph card
Given that I am a user on a data space governance page
And I am using a desktop device,
When I select a section with a selected subsection
And the container of one of its articles is open
Then each paragraph is displayed on a card in the following order

icon
Paragraph title
Paragraph description (displayed max in 4 rows)
See more button (displayed if 5 or more rows are available in the description)
For now the see more button is disabled because its behaviour is TBD

Mock-up 4
Scenario 8: Paragraph card - Description with DID
Given that I am a user on a data space governance page
And I am using a desktop device,
When I select a section with a selected subsection
And the container of one of its articles is open
And a paragraph contains DIDs
Then each DID is displayed on a separate row with

... in the middle for the short cut
Copy icon button
i - the copy function will be in V2
Mock-up 4

Scenario 9 : Section drop-down menu behaviour (Mobile & Tablet)
Given that I am a user of the web portal (unauthenticated or authenticated)
And I'm on a Data Space governance page
And I click on the drop down menu
(click must be available on the whole the component not only the text or the chevron)
Then the displayed menu contains :

titles of section available in this data space

The title must be kept in one line, if it's too long then an ellipse is added at the end

right arrow on the right of sections with two or more subsections
no right arrow for sections with only one subsection

When I select a section with multiple subsection
then a second page of the drop-down menu is displayed and it contains :

<- Back button allowing to go back to the first page of the menu
titles of the subsections of the selected section

The title must be kept in one line, if it's too long then an ellipse is added at the end
mock-up 5

Scenario 10 : Change section to a section with one subsection (Mobile & Tablet)
Given that I am a user of the web portal (unauthenticated or authenticated)
And I'm on a Data Space governance page
And I click on the drop down menu
And I select a section with no subsection (no right arrow)
Then the drop-down menu closes
And the title of section is now visible on the drop-down menu
And I land on the section description following the default display
mock-up 5
Scenario 11 : Change section to a section with  multiple subsection (Mobile & Tablet)
Given that I am a user of the web portal (unauthenticated or authenticated)
And I'm on a Data Space governance page
And I click on the drop down menu
And I select a section with subsections (right arrow)
And I am redirected to the second page of the menu
And I select a subsection
Then the drop-down menu closes
And the title of section is now visible on the drop-down menu
Note that it's not the title of the subsection that is displayed on the of the drop-down menu
And I land on the section description following the default display
mock-up 5
Scenario 12 : Scrolling sections / subsection
Given that I am a user of the web portal (unauthenticated or authenticated)
And I'm on a Data Space governance page
And I click on the drop down menu
And the list of sections or subsections is too long to show all
Then I should be able to scroll down and up the menu
No scroll bar is available, it's only visual as the last section or subsection is cropped showing the user that they can scroll
mock-up 5
Scenario 13 : Internalisation
ENG
See more
Back
FR
Voir plus
Retour
DE
Mehr sehen
Zurück
Resources
Mockups
Mockup 1

mockup 2

mock up 3

mock-up 4

mock-up 5

mock-up - 6
Light mode

Environment

staging URL: https://app.staging.okp4.network/

Additional informations
None.

Definition of Ready

[ ] title, description, and value statement
[ ] acceptance criteria (scenarios)
[ ] mockups (all devices and themes)
[ ] labels added
[ ] US presented to DEV team (refinement)
[ ] attached to an epic
[ ] estimation (planning poker)
[ ] external dependencies if applicable

To go from one page to another in this dropdown menu, the first page slides from the right to the left
I'll provide an animation
Note that this is explained in design system for all cascade menus

Hey team! Please add your planning poker estimate with Zenhub @lolottetheclash @ErikssonJoakim @0xLodz @AnjaMis

Regarding the animation for sliding the menu pages, lisa couldn't design it, however here is a link to a video showing design idea
https://www.google.com/search?q=animation+dropdown+cascade&oq=animation+dropdown+cascade&aqs=chrome..69i57j33i160l4.4968j0j7&sourceid=chrome&ie=UTF-8#fpstate=ive&vld=cid:6858b6d1,vid:IF6k0uZuypA

@SpicySalm0n when an article has a description, do we want to display the number of paragraph and the chevron at the title level, or as it is displayed in this screenshot (which represents the current state of the feature implementation)? cc @ErikssonJoakim

@0xLodz they should be aligned to the title!

test 12/06
Scenario 1: Default display (Mobile & Tablet) ✅
Scenario 2 : Container behaviour - subsection w/ 1 article ✅
Scenario 3 : Container behaviour - subsection w/ 2 or more articles ❓ -> Not the case in the Rhizome governance.
Scenario 4 : Container Open - subsection w/ 2+ articles ❓ -> Not the case in the Rhizome governance.
Scenario 5: Container closed - subsection w/ 2+ articles ❓ -> Not the case in the Rhizome governance.
Scenario 6: opening & closing a container ❓ -> Not the case in the Rhizome governance.
Scenario 7: Paragraph card ✅
Scenario 8: Paragraph card - Description with DID => will be in V2
Scenario 9 : Section drop-down menu behaviour (Mobile & Tablet) ✅
Scenario 10 : Change section to a section with one subsection (Mobile & Tablet) ✅
Scenario 11 : Change section to a section with multiple subsection (Mobile & Tablet) ✅
Scenario 12 : Scrolling sections / subsection ✅
Scenario 13 : Internalisation ✅
@ErikssonJoakim how can I test the scenarii 3, 4, 5 and 6 ?

test 13/06
Scenario 3 : Container behaviour - subsection w/ 2 or more articles ✅
Scenario 4 : Container Open - subsection w/ 2+ articles ✅
Scenario 5: Container closed - subsection w/ 2+ articles ✅
Scenario 6: opening & closing a container ✅


QC solutions By Sergio Martinez-Losa

Ex1
Name: Sergio Martinez-Losa
Score: 72
Ex2
Name: Sergio Martinez-Losa
Score: 35
Ex3
Name: Sergio Martinez-Losa
Score: 266
Ex5
Name: Sergio Martinez-Losa
Score: 3
Chemical Accuracy: 2.358815 mHa
No. of parameters: 16

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Sorry for the delay. Thank you very much for your submission!


Parsing issue - Antlr update

Antlr update 4.7.2->4.8 causes generating observables from string to parse incorrectly.

Here is a python MWE:
import xacc
geom = '''
H  0.000000   0.0      0.0
H   0.0        0.0  .7474
'''
H = xacc.getObservable('pyscf', {'basis': 'sto-3g', 'geometry': geom})
print(H.toString()) # causes xacc to throw [XACC Error] Invalid Fermion Operator source: line 1:1153 extraneous input '-' expecting {REAL, INT}
newH = xacc.getObservable('fermion', H.toString())
print(newH.toString()) # no errors, but only prints one-particle operators

This has been fixed in latest from master.


Add "return 0" in DebugCommand.php

I added "return 0" to fix this error message:
$ vendor/bin/behat --debug

behat version 3.7.0

--- configuration
    environment variable (BEHAT_PARAMS): none
    configuration file: /home/jawira/PhpstormProjects/xxxxxxxx/behat.yml

--- extensions
    extensions loaded: api_extension

PHP Fatal error:  Uncaught TypeError: Return value of "Behat\Testwork\Cli\DebugCommand::execute()" must be of the type int, NULL returned. in /home/jawira/PhpstormProjects/xxxxxxxx/vendor/symfony/console/Command/Command.php:258
Stack trace:
#0 /home/jawira/PhpstormProjects/xxxxxxxx/vendor/symfony/console/Application.php(912): Symfony\Component\Console\Command\Command->run()
#1 /home/jawira/PhpstormProjects/xxxxxxxx/vendor/symfony/console/Application.php(264): Symfony\Component\Console\Application->doRunCommand()
#2 /home/jawira/PhpstormProjects/xxxxxxxx/vendor/behat/behat/src/Behat/Testwork/Cli/Application.php(124): Symfony\Component\Console\Application->doRun()
#3 /home/jawira/PhpstormProjects/xxxxxxxx/vendor/symfony/console/Application.php(140): Behat\Testwork\Cli\Application->doRun()
#4 /home/jawira/PhpstormProjects/xxxxxxxx/vendor/behat/behat/bin/behat(34): Symfony\Component\Console\Application->run()
#5 {main}
  thrown in /home/jawira/PhpstormProjects/xxxxxxxx/vendor/symfony/console/Command/Command.php on line 258

is it the only command having this bug ?

Yes, other commands are ok :)

Makes me think this isn't covered by a test?

@pamil So I created debug.feature, I'm open to any comments.

Thanks, @jawira! :1st_place_medal:


fix missing ipaddr require

The IPAddr class is used but the ipaddr library is never required. If no other plugins does a require "ipaddr" then the udp input will crash on startup with:
[WARN ][logstash.inputs.udp ] UDP listener died {:exception=>#<NameError: uninitialized constant LogStash::Inputs::Udp::IPAddr>, :backtrace=>["org/jruby/RubyModule.java:2746:in const_missing'", "/usr/share/logstash/vendor/bundle/jruby/1.9/gems/logstash-input-udp-3.3.1/lib/logstash/inputs/udp.rb:87:inudp_listener'", "/usr/share/logstash/vendor/bundle/jruby/1.9/gems/logstash-input-udp-3.3.1/lib/logstash/inputs/udp.rb:57:in run'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:470:ininputworker'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:463:in `start_input'"]}

This fix is simply to require that library.

merged and published as v3.3.2.


withDefaultPersistenceXml should use deployment time config

withDefaultPersistenceXml is called in the deployment phase (to build the test application archive) so it should use the deployment time config.
Without this, the TCK expects the porting package and all its dependencies to be present on the test classpath, rather than just on the server. This made it much harder for me to run ContainerEventTest on my workstation since the porting package depends on server internals (and I don't think this test needs the porting package anyway).
Although I think this is a bug, it's been present in previous releases so everyone who has passed the older TCKs has clearly managed to work around it so we don't need to rush it in for 4.0.

I suppose you mean org.jboss.cdi.tck.tests.lookup.injection.non.contextual.ContainerEventTest (there are 4 ContainerEventTest ATM).
Frankly speaking I have no idea how is this config supposed to work and I am unable to currently verify this against WFLY due to other issues so I cannot really provide a review.

@Ladicek actually, this is somewhat related to what was brought up in https://github.com/eclipse-ee4j/cdi-tck/issues/222
It is a usage of Shrinkwrap Descriptors, a project that wasn't updated in a while and the files it generates can be fairly outdated (the version of them at least).
I recall back then I was thinking if we shouldn't replace these usages with some other APIs of our own or update the project (which might be costly for just us). Or just plain replace them by XML files in project that could at least be updated by us.

... and I am unable to currently verify this against WFLY due to other issues so I cannot really provide a review.

BTW, I went through some loops to get an ad-hod working WFLY for this and I see no difference with and without this change.
I guess this can also be attributed to some differences in Arq. adapters?


This pull requests makes chdir work

Hello good sirs. I am a humble contributor from Canada. I've noticed a slight issue I'd like to rectify.
Currently chdir has no effect since in run:
this.cwd = process.cwd();

is done when run is called.

Thanks @mikkoh


[Installation]: habana_main branch installation fails on 1.17 driver and firmware.

Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Suggest the README_GAUDI installation instructions be updated to below:
$ git clone https://github.com/HabanaAI/vllm-fork.git
$ cd vllm-fork
$ git checkout v0.5.3.post1-Gaudi-1.17.0
$ pip install -e .

Fixed in release notes. Add update to release procedure


[5.2] Cache based sessions don't need to take part in the GC lottery

Cache based session handlers, CacheBasedSessionHandler in particular, don't support the garbage collection used by the StartSession middleware.
So there's actually no need for them to take part in the GC lottery or to call the the gc method which doesn't have any effect.

They might in the future and it doesn't hurt to call them just in case.

They might in the future and it doesn't hurt to call them just in case.

Well they currently don't and if they do in the future then why not introduce a method then to indicate if a session handler needs garbage collection or not? There's no need to trigger gc or play the gc lottery if the session handler doesn't support or need it.


Request for Pretrained Code

Hi there,
I hope you are doing well. I came across your project and found it very interesting. I noticed that you have provided pre-trained checkpoints for the model, but I couldn't find the code used for pretraining.
Having the pretraining code would be immensely helpful for understanding the model architecture, training procedure, and adapting it to my specific use case.
Thank you for your time and consideration. Looking forward to your response.

Hi, thank you for your interest of our project.
The pre-training is conducted on 4 machines with 8 V100 GPUs each. The multinode logic is implemented specifically for our own cluster.
It is difficult for us to find 32 GPUs other than our cluster so as to verify the correctness of the pre-training code. So currently we don't have plans to release them.
convenient replace the pooling with our proposed LoDA, reproduce the same result.

Thank you for your excellent article! How do I use public CLIP repo and then replace the pooling layer with LoDA? Looking forward to your reply and wishing you all the best!


fixes 10764 -Inserting a new InlinePanel focus goes to wrong place

Fixes #10764: When inserting a new InlinePanel, focus goes to the wrong place
What i did?
-> Added tabindex -1 in newly created inline form and removing tabindex attr from old forms, then scroll to first node of form
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[ ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

hey @lb- i have made the changes as you have requested

thanks for suggestion @lb-
apologies for unnecessary comments

Just rebased/squashed, will merge in after a few CI checks run.
Thanks for making your first contribution to Wagtail @faishal882 !

@faishal882 no problems. Thanks for following through with it all.
If you're keen on another, there is an issue that is a nice enhancement and it will be need a code change in pretty much the same area of code.
https://github.com/wagtail/wagtail/issues/9105
This enhancement will make it easier for JS customisations to hook into the events of InlinePanel.

Thanks @lb-  i will look into the issue


Can media play with audio?

Video or Audio plays but sound dose not come
Whenever any page have audio or video it shows, but no sound comes like it's muted.
Even video plays but like it's muted.

Opened a pull request that can play audio #25


Cellular fixes

Looking a bit into the new cellular stuff I realized more of the samples can't build with the different boards.
So little is needed to make it work, so worth it I think

For pinnacle_100_dvk and mg100 to work with the cellular modem sample, board overlays are needed in the sample.

Yes - I guess you are right. My misunderstanding.
This was purely based on my build result. Unfortunately my only modem is on a (yet) unsupported board, so haven't had a change to verify it.
I'll retract this PR

For pinnacle_100_dvk and mg100 to work with the cellular modem sample, board overlays are needed in the sample.

That's one way to solve the lack of the modem alias. Still though you'll get a linker conflict with multiple definitions of  __devices_dts_ord_xx (defined in both modem_cellular.c.obj and the hl8700 driver)

For pinnacle_100_dvk and mg100 to work with the cellular modem sample, board overlays are needed in the sample.

That's one way to solve the lack of the modem alias. Still though you'll get a linker conflict with multiple definitions of __devices_dts_ord_xx (defined in both modem_cellular.c.obj and the hl8700 driver)

You need a kconfig overlay to disable the HL7800 driver.


Migrate fails when trying to create second job queue

Hello,
Thank you for the library, I needed to create something similar myself, so it saved me some time.
Here's the reproduction steps, running on a fresh database:
*SpotCheck> conn <- connectPostgreSQL "dbname='test' user='niteria'"
*SpotCheck> Queue.migrate "queue1" conn
NOTICE:  trigger "payloads_modified" for relation "payloads" does not exist, skipping
*SpotCheck> Queue.migrate "queue2" conn
*** Exception: SqlError {sqlState = "42704", sqlExecStatus = FatalError, sqlErrorMsg = "type \"state_t\" does not exist", sqlErrorDetail = "", sqlErrorHint = ""}

I'm running a version from Hackage, postgresql-simple-queue-1.0.1 to be precise.
I'm not an expert on PostgreSQL, so I googled a bit and found this: https://stackoverflow.com/a/56647928
It seems to suggest that the types are scoped to the schema and this part of the migration statement SELECT 1 FROM pg_type WHERE typname = 'state_t' ignores the scope. The correct query seems to be SELECT 1 FROM pg_type typ INNER JOIN pg_namespace nsp ON nsp.oid = typ.typnamespace WHERE nsp.nspname = current_schema() AND typ.typname = 'state_t' as per the StackOverflow answer.

I copied over the module Database.PostgreSQL.Simple.Queue.Migrate to my project and applied the fix and it worked.
I'd send a pull request, but master seems to be substantially different from Hackage.

Thanks for the bug report. I am working a new postgres based queue using hasql instead of postgresql-simple but I will try to get a maintenance release out on this at some point.


Vertical padding in custom icon size

Describe the bug

When updating the version to 64, there is no large icon function in the settings, and the customized icon size leaves too large vertical gaps between the files, which is very inconvenient.
Expected Behavior

Return the `Big Icons' icon
Environment

Windows, PyCharm 2022.1 (Professional Edition), Plugin version 64.0.0

Custom Size is the extension of Large Icons, so by setting the size to 20 you'd be able to reproduce the previous behavior.
Can you elaborate about the issues you mentioned?

Unfortunately, I can't make the same size as before. The vertical gaps between the files are too large, and they cannot be changed in any way. The more I increase the size of the icons, the larger the gaps, if the size of the icons is reduced, then the gaps are still relatively large

But the gaps were made to prevent icons "crushing" onto one another...
Can you show a screenshot of what do you mean "too large"?
I could add a setting to control that padding but I want to make sure that it's something that makes sense

Folder color does not change after opening file

current -  63.00

after - 64.00

everywhere, these huge gaps

when there are a lot of files, in total these gaps take up too much space

Fixed on latest version


xcode resource :install_gem action on Mojave marks all CLI tools for update

Using the :install_gem action on Mojave (10.14) marks all available CLI tools updates for update in Software Update.
Using latest 2.5.0 cookbook:
xcode '10.0' do
  action :install_gem
end

Leads to:

Thanks for catching this! This is likely due to the CommandLineTools class not deleting the sentinel file, something that happened in the 2.5.0 refactor. I will update it to do so in our Mojave release, which we are wrapping up.

Resolved by #147


App crashes when HA instance is unavailable

The app crashes on start-up if the HA instance is currently unavailable. The reason doesn't matter: happens in case of an IP ban (403 forbidden), HA outage, misconfigured Nginx, anything else, it's all the same.

Duplicate of #79


adds documentation on CSV loading

This resolves #64 by adding a new documentation page that outlines the CSV format required for loading packets.
I'm open to any suggestions to improve clarity.

Thanks for submitting @jmbhughes ! I'll take a look at this over the weekend.

These changes all look good to me. I'll make them ASAP.

@ddasilva I updated with the suggested changes, so it's good to go.

Merged. Thanks @jmbhughes !


HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID

Details see: HBASE-28443
Before this PR:
hbase:014:0> scan 't01', {CONSISTENCY => "TIMELINE", REGION_REPLICA_ID => 2}
ROW                                     COLUMN+CELL

ERROR: No location for t01, row='', locateType=CURRENT, replicaId=2

For usage try 'help "scan"'

Took 8.2960 seconds

Apply this PR:
hbase:009:0> scan 't01', {CONSISTENCY => "TIMELINE", REGION_REPLICA_ID => 2}
ROW                                     COLUMN+CELL

ERROR: The specified region replica id 2 does not exist, the REGION_REPLICATION of this table t01 is 2, this means that the maximum region replica id you can specify is 1.

For usage try 'help "scan"'

Took 0.0280 seconds

The old PR #5764 always run deleted test case, so i closed it, and reopen a new PR

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
compile
1m 30s
master passed

+1 :green_heart:
shadedjars
7m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 13s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
5m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 34s
hbase-client in the patch passed.

-1 :x:
unit
225m 29s
hbase-server in the patch failed.

256m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cfb12f6842c1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0763a74096

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/1/testReport/

Max. process+thread count
4996 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 16s
master passed

+1 :green_heart:
compile
1m  7s
master passed

+1 :green_heart:
shadedjars
6m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 11s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
6m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 41s
hbase-client in the patch passed.

-1 :x:
unit
277m 16s
hbase-server in the patch failed.

307m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 26be0bb61d7b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0763a74096

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/1/testReport/

Max. process+thread count
4541 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Mind explaining more on why locating is so slow when the replica id does not exist?

Mind explaining more on why locating is so slow when the replica id does not exist?

Busying with other things, Sorry for the late reply.
In a short, hbase would retry 8 times (by default) if the location of specified region is not obtained, and this stage take a long time.
A detailed analysis for this situation against master branch
We will get RegionOfflineException if region replica id does not exist. Code is in here
// AsyncRegionLocator.getRegionLocation

// loc == null because region replica id does not exist
HRegionLocation loc = locs.getRegionLocation(replicaId);
if (loc == null) {
    future.completeExceptionally(
    new RegionOfflineException("No location for " + tableName + ", row='"
        + Bytes.toStringBinary(row) + "', locateType=" + type + ", replicaId=" + replicaId));
}

HBase would retry it over and over util the maxAttempts is reached when getting RegionOfflineException because this exception is not DoNotRetryIOException, Code is in here.
// AsyncRpcRetryingCaller.onError

if (error instanceof DoNotRetryIOException && !(error instanceof ScannerResetException)) {
    future.completeExceptionally(error);
    return;
}
...
tryScheduleRetry(error);

We are sure that the region does not exist in this situation, so no need to retry maybe is better.
So we can throw DoNotRetryIOException to avoid retrying in this situation

I think we should try to check the replica id when we hit the RegionOfflineException, like what we have done in AsyncRpcRetryingCaller.

I think we should try to check the replica id when we hit the RegionOfflineException, like what we have done in AsyncRpcRetryingCaller.

Thanks for your good suggestion， the change has been made.
Additionally, I have rewritten the test cases

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
compile
3m 43s
master passed

+1 :green_heart:
checkstyle
0m 57s
master passed

+1 :green_heart:
spotless
0m 47s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 29s
master passed

-0 :warning:
patch
1m 52s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
3m 28s
the patch passed

+1 :green_heart:
javac
3m 28s
the patch passed

+1 :green_heart:
checkstyle
0m 54s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
5m 47s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 56s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
3m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

39m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 9c33c3d44bce 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / feef7446f2

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  0s
master passed

+1 :green_heart:
compile
1m 12s
master passed

+1 :green_heart:
shadedjars
5m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

-0 :warning:
patch
6m 22s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
5m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 34s
hbase-client in the patch passed.

-1 :x:
unit
260m 52s
hbase-server in the patch failed.

288m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cbb2e5a8648c 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / feef7446f2

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/testReport/

Max. process+thread count
5059 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  6s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
6m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 33s
hbase-client in the patch passed.

-1 :x:
unit
279m 49s
hbase-server in the patch failed.

310m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dcb56b7983e7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / feef7446f2

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/testReport/

Max. process+thread count
4412 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 57s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
6m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 43s
hbase-client in the patch passed.

-1 :x:
unit
317m 42s
hbase-server in the patch failed.

347m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5da8d34b6c40 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / feef7446f2

Default Java
Eclipse Adoptium-17.0.10+7

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/testReport/

Max. process+thread count
4820 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 15s
master passed

+1 :green_heart:
compile
3m 26s
master passed

+1 :green_heart:
checkstyle
0m 50s
master passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 12s
master passed

-0 :warning:
patch
1m 40s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s
the patch passed

+1 :green_heart:
compile
3m 24s
the patch passed

+1 :green_heart:
javac
3m 24s
the patch passed

+1 :green_heart:
checkstyle
0m 50s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
5m 34s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

36m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux fb86a3206f8e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2130e5410f

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 11s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 31s
hbase-client in the patch passed.

-1 :x:
unit
232m 54s
hbase-server in the patch failed.

263m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fc7b1048ae27 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2130e5410f

Default Java
Eclipse Adoptium-17.0.10+7

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/testReport/

Max. process+thread count
4911 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 13s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 40s
master passed

+1 :green_heart:
compile
0m 59s
master passed

+1 :green_heart:
shadedjars
5m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

-0 :warning:
patch
6m 31s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

+1 :green_heart:
shadedjars
6m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 40s
hbase-client in the patch passed.

-1 :x:
unit
242m 14s
hbase-server in the patch failed.

272m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8efd816669b0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2130e5410f

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/testReport/

Max. process+thread count
5459 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 32s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 18s
master passed

+1 :green_heart:
compile
1m  7s
master passed

+1 :green_heart:
shadedjars
5m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

-0 :warning:
patch
6m 50s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 57s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
5m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 39s
hbase-client in the patch passed.

-1 :x:
unit
259m  2s
hbase-server in the patch failed.

289m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5767

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c4a2daccac36 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2130e5410f

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/testReport/

Max. process+thread count
4490 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5767/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


making tuto files working for terraform v0.15 (1-dev_vpc)

hello! im working thru your tutorials on Pluralsight.  I learn a lot thanks!
but tuto files doesnt work with current terraform v0.15
my fixes make it work
I suggest minimal changes to main.tf

bump required VPC module required to at least 2.58.0 (in order to make it work under Terraform v0.15)
adopt Terraform suggested provider blocks

Required_providers : where you can specifiy version
Providers : where you dont specify version anymore (because deprecated)

https://registry.terraform.io/providers/hashicorp/aws/latest/docs

I just pushed an update that resolves the issues with versions and modules.