Add munin (or some other monitoring dashboard)

It'd be nice to have a HUD of the entire cluster's activity. Munin is lightweight, easy to get going, and can maybe run on one of the three webservers, or on the caching server maybe...

So... munin-html takes 100% CPU for about 20 seconds, then munin-graph takes over and spikes to 100% for about 3 minutes. A little longer, and the graphing cycle will basically be continuous!
Configuring Munin to use FastCGI with Nginx is not the most complicated affair (mostly involves maybe 4-6 more tasks in a playbook on the balancer... plus a bit more config in the Nginx .conf file...). This might be a deal-breaker, though, on the poor Pis.
I think we have four routes:

Leave it, let one Pi core remain at basically 100% CPU almost forever. Doesn't have a huge impact on the balancer's ability to balance/cache requests, since CPU is not the bottleneck.
Switch to CGI html/graphing strategy. This will make for slower individual graph loading, but the Pi will not be spiking in usage forever.
See if I can disable the majority of 'nonessential' graphs that I don't care about (I care mostly about CPU, load, memory, disk IO, and network IO).
Don't use munin to monitor the cluster's health. (Sad panda). Look for an alternative maybe.

Another option worth exploring... Munin doesn't have a magic enabled var in munin.conf (sadly), but I could add a munin_enabled variable to the munin role, or a dramble_munin_enabled role specific to this configuration that removes the cron job. See: https://github.com/geerlingguy/ansible-role-munin/issues/2

Done! Munin can now be toggled at-will by setting munin_cron_job to present or absent.


Gui roadmap

just splitting this from https://github.com/OpenVoiceOS/ovos-core/issues/274 to keep discussion contained
GUI independence:

[ ] #1

qt 6 migration:

[x] https://github.com/MycroftAI/mycroft-gui/pull/124
[ ] https://github.com/OpenVoiceOS/ovos-shell/issues/29
[ ] https://github.com/OpenVoiceOS/OVOS-workshop/pull/50

As Plasma and Upstream master branches have now moved to Qt6, the following is planned:
Planning the following:

Mycroft-GUI will see a final QT5 version release and master branches will be moved to QT6

OVOS-shell will see a final QT5 version release and master branches will be moved to QT6

Any fixes that are needed to go in Mycroft-GUI and OVOS-shell QT5 versions will be made in a backports branch that will then see minor releases.

The skills that have already been ported will get a UI / UI5 folder

Any images should use the released versions and not master to package GUI once this is done if they are on older base images shipping qt5.

Skills that are not updated just won't work, on qt6 images, basic ones under ovos should.

Will be offering help to both Neon, MycroftAI to port any GUI skill needed to Qt6

Anyone else who has QT5 skills ill get to those in the coming week.

Manjaro image building will be disabled until above is completed, a message will be added to the docs to not run "sudo pacman -Syu"

[ ] Move all GUI resources from core

Mycroft-GUI master now on QT6
Mycroft-GUI QT5 stable branch release at: https://github.com/MycroftAI/mycroft-gui/releases/tag/stable-qt5


Support Fish shell, or don't try to install into Fish with ZSH syntax

Hi! My corporate ~spyware~ MDM software has forced this tool onto my system. This would be fine, except that you install shell support into Fish using ZSH syntax.
This is in my ~/.config/fish/config.fish:
# Generated by Hermit; START; DO NOT EDIT.
HERMIT_ROOT_BIN="${HERMIT_ROOT_BIN:-"$HOME/bin/hermit"}"
eval "$(test -x $HERMIT_ROOT_BIN && $HERMIT_ROOT_BIN shell-hooks --print --zsh)"
# Generated by Hermit; END; DO NOT EDIT.
######

This causes Fish to produce this error:
~/.config/fish/config.fish (line 8): Unsupported use of '='. In fish, please use 'set HERMIT_ROOT_BIN "${HERMIT_ROOT_BIN:-"$HOME/bin/hermit"}"'.
HERMIT_ROOT_BIN="${HERMIT_ROOT_BIN:-"$HOME/bin/hermit"}"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file ~/.config/fish/config.fish
source: Error while reading file '/Users/jw/.config/fish/config.fish'

I checked for --fish, but it doesn't exist:
~/bin/hermit shell-hooks --print --fish
Usage: hermit shell-hooks (install-hooks)

Manage Hermit auto-activation hooks of a shell.

Flags:
  -h, --help                 Show context-sensitive help.
      --version              Show version.
  -d, --debug                Enable debug logging.
  -t, --trace                Enable trace logging.
  -q, --quiet                Disable logging and progress UI, except fatal errors ($HERMIT_QUIET).
      --level=auto           Set minimum log level (auto,trace,debug,info,warn,error,fatal) ($HERMIT_LOG).
      --lock-timeout=30s     Timeout for waiting on the lock ($HERMIT_LOCK_TIMEOUT)
      --env=KEY=VALUE;...    Extra environment variables to apply to environments.

Command flags:
  --zsh     Update Zsh hooks.
  --bash    Update Bash hooks.

hermit: error: unknown flag --fish, did you mean one of "--zsh", "--bash"?

Please either:

Add --fish output for shell hooks, or
Do not install into Fish until shell hooks are supported for Fish.

I don't believe it is Hermit doing this, it doesn't know about ~/.config/fish/config.fish at all. IIUC this is something done explicitly by the internal tooling :(

Ah, that's good to know. Thanks! I'm chasing them down for other invalid syntax they put into that file, so I'll be sure to mention this, too.
You can strikethrough like 90% of the original issue and keep it solely as a simple feature request for --fish if you want.


Forwarder not handling error response from ZBD correctly

Issue is two-fold:

[x] We're not handling error response from ZBD correctly, which crashes application
[x] On error, the forward record is left in a state where in_flight is true but we have no ext payment id to check against

Error updating forward table on handleCompletedForward: Error: Undefined binding(s) detected when compiling UPDATE. Undefined column(s): [external_payment_id] query: update "forward" set "in_flight" = ?, "is_settled" = ?, "updated_at" = CURRENT_TIMESTAMP, "attempt_count" = "attempt_count" + ? where "external_payment_id" = ?

https://github.com/wavlake/catalog/pull/381


fix: SWA top navigation bar height jumps

Description
This fixes the SWA top navigation bar height jumps by fixing the height of the text above the progress bar.
Jumping top navigation 🔴
https://github.com/artsy/eigen/assets/4691889/1a09691e-34fa-4f12-adfb-7f3668ae5c3f
Top navigation with fixed height 🟢

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Fix SWA top navigation bar height jumps (behind ff) - ole

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against f432ae62f9a6cd9850ccf832feae353005477e9f

You can check my changes here https://github.com/artsy/eigen/pull/10336/commits/fc4399000a67e762253a9ea825bfb7c9cdea8d23 - I figured out it's time to have everything defined all together instead of the old way which made LayoutAnimation confused

You can check my changes here https://github.com/artsy/eigen/commit/fc4399000a67e762253a9ea825bfb7c9cdea8d23 - I figured out it's time to have everything defined all together instead of the old way which made LayoutAnimation confused

Will this fix the jumping progress bar? Could you create a PR? Then we can close this one and merge your fixes.

Yes, this should fix it. The commit is part of this PR https://github.com/artsy/eigen/pull/10336


Addition of Dark mode

A toggle button that can change between dark and light modes

@vinitshahdeo Hey, can I work on this? It would be a nice feature addition for this project

Hello there, I would like to work on the addition of dark mode to this project. @vinitshahdeo Would it be fine if I work on this feature?

Hey, could i work on this issue

hello , can i work on this I already have a implemented version


Move the game map to sub-domain map.minecraft.of.by

ensure it works via https

Resolved, available here - https://map.minecraft.of.by


Windows prerequisutes

You should add to the windows prerequisites that the build tools need to be installed as well. I know zero about Windows development so there might be a better way. What I did was.
Install VS Community 2015
rapidgame
create a new game
Error message saying something like "Write the path to the lib.exe into file..."
Couldn't find lib.exe. So I opened the solution rapidgame created and VS started downloading lots of stuff for WinXP targets, other things and the build tools. After that lib.exe was present in the bin folder of VS.
Now it is prebuilding, but prebuild fails. Need to invesitgate further. Will submit new issues for what I find

Thanks, I've added a bullet point to the Windows Notes.


Apple Silicon support  is missing

compiling on a Mac OS running the new Apple M1 computers fails due to:
Could not find protoc-gen-kroto-plus-0.6.1-osx-aarch_64.exe (com.github.marcoferrer.krotoplus:protoc-gen-kroto-plus:0.6.1).

I'm compiling the project with an Intel X64 JDK to workaround this issue. It works but it isn't optimal for performance.

This can be built natively but you need to bump up the protoc version to one with an aarch_64 release. Not sure what the minimum is but the latest 3.x release (currently 3.21.5) has native binaries


Eagerly resolve local blobs

Issue #, if available:
Fixes #931
Description of changes:
For local snapshots, we previously encountered a bug where the size of a layer was resported as zero in its descriptor. This caused the Fetch function to attempt to resolve it as a manifest, which would then cause the local snapshot to defer to container runtime, causing containerd to fetch all remaining layers ahead of time. This change resolves the local blob earlier to populate the size field, avoiding this issue.
Testing performed:
Followed steps in #931 and ensured local snapshots were successfully prepared.
After setting up containerd/crictl configs I ran the following script:
# Empty content store beforehand

TOKEN=$(aws ecr get-authorization-token --region us-west-2 | jq -r '.authorizationData[0].authorizationToken' | base64 -d)
sudo crictl \
  --runtime-endpoint "unix:///var/run/containerd/containerd.sock" \
  --image-endpoint "unix:///var/run/containerd/containerd.sock" \
  run \
  --creds $TOKEN \
  container-config.json \
  pod-config.json

Output
{"level":"info","msg":"starting soci-snapshotter-grpc","revision":"5217c3718d46a675fb964ff06c2399540b03794e","time":"2024-01-09T21:56:31.727674500Z","version":"5217c37"}
{"emitMetricPeriod":10000000000,"fetchPeriod":500000000,"level":"info","maxQueueSize":100,"msg":"constructing background fetcher","silencePeriod":30000000000,"time":"2024-01-09T21:56:31.763298289Z"}
{"address":"/run/soci-snapshotter-grpc/soci-snapshotter-grpc.sock","level":"info","msg":"soci-snapshotter-grpc successfully started","time":"2024-01-09T21:56:31.767434398Z"}
{"key":"k8s.io/1/extract-544072554-KtoC sha256:e3e5579ddd43c08e4b5c74dc12941a4ef656fab070b1087a1fd5a8a836b71e7d","level":"info","msg":"preparing filesystem mount at mountpoint=/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/1/fs","parent":"","time":"2024-01-09T21:56:32.550227833Z"}
{"key":"k8s.io/1/extract-544072554-KtoC sha256:e3e5579ddd43c08e4b5c74dc12941a4ef656fab070b1087a1fd5a8a836b71e7d","level":"info","mountpoint":"/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/1/fs","msg":"index digest not provided, making a Referrers API call to fetch list of indices","parent":"","time":"2024-01-09T21:56:32.550317570Z"}
{"error":"unable to fetch SOCI artifacts: cannot fetch list of referrers: unable to fetch referrers: GET \"https://accounts.google.com/v3/signin/identifier?continue=https%3A%2F%2Fconsole.cloud.google.com%2Fartifacts%2Ftags%2Fv2%2Fus-west1%2Fk8s-artifacts-prod%2Fimages%252Fpause%252Freferrers%252Fsha256%2F8d4106c88ec0bd28001e34c975d65175d994072d65341f62a8ab0754b0fafe10\u0026followup=https%3A%2F%2Fconsole.cloud.google.com%2Fartifacts%2Ftags%2Fv2%2Fus-west1%2Fk8s-artifacts-prod%2Fimages%252Fpause%252Freferrers%252Fsha256%2F8d4106c88ec0bd28001e34c975d65175d994072d65341f62a8ab0754b0fafe10\u0026ifkv=ASKXGp2557sFr8K0acu6KQXE9y8yxDkTNaD4RnM82YUOVq6iCWSnQMBGS4ZPj_NXyXuExnKCWQ10Sw\u0026osid=1\u0026passive=1209600\u0026service=cloudconsole\u0026flowName=WebLiteSignIn\u0026flowEntry=ServiceLogin\u0026dsh=S111108%3A1704837392875678\": failed to decode response: invalid character '\u003c' looking for beginning of value","key":"k8s.io/1/extract-544072554-KtoC sha256:e3e5579ddd43c08e4b5c74dc12941a4ef656fab070b1087a1fd5a8a836b71e7d","level":"warning","msg":"failed to prepare remote snapshot","parent":"","remote-snapshot-prepared":"false","time":"2024-01-09T21:56:33.057822171Z"}
{"layerDigest":"sha256:61fec91190a0bab34406027bbec43d562218df6e80d22d4735029756f23c7007","level":"info","msg":"preparing snapshot as local snapshot","time":"2024-01-09T21:56:33.057880065Z"}
{"key":"k8s.io/1/extract-544072554-KtoC sha256:e3e5579ddd43c08e4b5c74dc12941a4ef656fab070b1087a1fd5a8a836b71e7d","level":"info","msg":"preparing local filesystem at mountpoint=/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/1/fs","parent":"","time":"2024-01-09T21:56:33.057905931Z"}
{"digest":"sha256:61fec91190a0bab34406027bbec43d562218df6e80d22d4735029756f23c7007","key":"k8s.io/1/extract-544072554-KtoC sha256:e3e5579ddd43c08e4b5c74dc12941a4ef656fab070b1087a1fd5a8a836b71e7d","level":"info","msg":"fetching artifact from remote","parent":"","time":"2024-01-09T21:56:33.115622050Z"}
{"key":"k8s.io/1/extract-544072554-KtoC sha256:e3e5579ddd43c08e4b5c74dc12941a4ef656fab070b1087a1fd5a8a836b71e7d","level":"info","msg":"local snapshot successfully prepared","parent":"","time":"2024-01-09T21:56:33.170098068Z"}
{"key":"k8s.io/3/extract-634603292-LAsg sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","level":"info","msg":"preparing filesystem mount at mountpoint=/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/3/fs","parent":"","time":"2024-01-09T21:56:33.637428598Z"}
{"key":"k8s.io/3/extract-634603292-LAsg sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","level":"info","mountpoint":"/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/3/fs","msg":"index digest not provided, making a Referrers API call to fetch list of indices","parent":"","time":"2024-01-09T21:56:33.637517943Z"}
{"key":"k8s.io/3/extract-634603292-LAsg sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","level":"info","mountpoint":"/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/3/fs","msg":"Received status code: 401 Unauthorized. Authorizing...","parent":"","time":"2024-01-09T21:56:33.655293258Z"}
{"digest":"sha256:bed193e8a077047e03e0775f8827fca3d9bd5c555e429b95c797ed2ffbb87fbf","key":"k8s.io/3/extract-634603292-LAsg sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","level":"info","mountpoint":"/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/3/fs","msg":"fetching SOCI artifacts using index descriptor","parent":"","time":"2024-01-09T21:56:33.785765708Z"}
{"digest":"sha256:bed193e8a077047e03e0775f8827fca3d9bd5c555e429b95c797ed2ffbb87fbf","level":"info","msg":"fetching SOCI index from remote registry","time":"2024-01-09T21:56:33.785797153Z"}
{"digest":"sha256:bed193e8a077047e03e0775f8827fca3d9bd5c555e429b95c797ed2ffbb87fbf","level":"info","msg":"fetching artifact from remote","time":"2024-01-09T21:56:33.785832098Z"}
{"digest":"sha256:5f931294fa10c999223fb7c19ff241ecb3cdfcb0b61d9289da8d7562d51c7778","level":"info","msg":"fetching artifact from remote","time":"2024-01-09T21:56:33.870896973Z"}
{"digest":"sha256:3baf6beca7e66fd9f202a0e80d22a446927f7f3b8e0bab208758c4ca1258aee9","level":"info","msg":"fetching artifact from remote","time":"2024-01-09T21:56:33.870904590Z"}
{"key":"k8s.io/3/extract-634603292-LAsg sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","level":"info","mountpoint":"/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/3/fs","msg":"Verification forcefully skipped","parent":"","time":"2024-01-09T21:56:34.495312457Z"}
{"key":"k8s.io/3/extract-634603292-LAsg sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","level":"info","msg":"remote snapshot successfully prepared.","parent":"","remote-snapshot-prepared":"true","time":"2024-01-09T21:56:34.499215012Z"}
{"key":"k8s.io/4/extract-504004840-sQgj sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","level":"info","msg":"preparing filesystem mount at mountpoint=/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/4/fs","parent":"sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","time":"2024-01-09T21:56:34.507123341Z"}
{"key":"k8s.io/4/extract-504004840-sQgj sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","level":"info","mountpoint":"/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/4/fs","msg":"Verification forcefully skipped","parent":"sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","time":"2024-01-09T21:56:34.787930976Z"}
{"key":"k8s.io/4/extract-504004840-sQgj sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","level":"info","msg":"remote snapshot successfully prepared.","parent":"sha256:8075d045345a93dbac9815a69cdee7f0d10ba82e83f364c794683b31f3a82c86","remote-snapshot-prepared":"true","time":"2024-01-09T21:56:34.792532731Z"}
{"key":"k8s.io/5/extract-795965430-Z2XQ sha256:ed65b89030c460f72fc00e77fbd1a49514d7db99128cd3f8dd692bad4cd65eaa","level":"info","msg":"preparing filesystem mount at mountpoint=/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/5/fs","parent":"sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","time":"2024-01-09T21:56:34.799303025Z"}
{"image":"425784566319.dkr.ecr.us-west-2.amazonaws.com/testing:nginx-demo","key":"k8s.io/5/extract-795965430-Z2XQ sha256:ed65b89030c460f72fc00e77fbd1a49514d7db99128cd3f8dd692bad4cd65eaa","layerDigest":"sha256:e95787efecdd4b6afe3e32d9d6ddb1ad8605754b4c73c1a4637135c63c684247","level":"info","mountpoint":"/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/5/fs","msg":"skipping mounting layer as FUSE mount: no ztoc for layer","parent":"sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","time":"2024-01-09T21:56:34.799375369Z"}
{"error":"skipping mounting layer sha256:e95787efecdd4b6afe3e32d9d6ddb1ad8605754b4c73c1a4637135c63c684247 as FUSE mount: no ztoc for layer","key":"k8s.io/5/extract-795965430-Z2XQ sha256:ed65b89030c460f72fc00e77fbd1a49514d7db99128cd3f8dd692bad4cd65eaa","level":"warning","msg":"failed to prepare remote snapshot","parent":"sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","remote-snapshot-prepared":"false","time":"2024-01-09T21:56:34.799414383Z"}
{"layerDigest":"sha256:e95787efecdd4b6afe3e32d9d6ddb1ad8605754b4c73c1a4637135c63c684247","level":"info","msg":"preparing snapshot as local snapshot","time":"2024-01-09T21:56:34.799481264Z"}
{"key":"k8s.io/5/extract-795965430-Z2XQ sha256:ed65b89030c460f72fc00e77fbd1a49514d7db99128cd3f8dd692bad4cd65eaa","level":"info","msg":"preparing local filesystem at mountpoint=/var/lib/soci-snapshotter-grpc/snapshotter/snapshots/5/fs","parent":"sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","time":"2024-01-09T21:56:34.799499214Z"}
{"digest":"sha256:e95787efecdd4b6afe3e32d9d6ddb1ad8605754b4c73c1a4637135c63c684247","key":"k8s.io/5/extract-795965430-Z2XQ sha256:ed65b89030c460f72fc00e77fbd1a49514d7db99128cd3f8dd692bad4cd65eaa","level":"info","msg":"fetching artifact from remote","parent":"sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","time":"2024-01-09T21:56:34.848547041Z"}
{"key":"k8s.io/5/extract-795965430-Z2XQ sha256:ed65b89030c460f72fc00e77fbd1a49514d7db99128cd3f8dd692bad4cd65eaa","level":"info","msg":"local snapshot successfully prepared","parent":"sha256:fb0172ff7e95acb9f733f1974fde617f9f4194d6ba3e4f9486791fe35553e1b8","time":"2024-01-09T21:56:34.922153837Z"}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM, pending nits.


Lock ringio with a mutex

This PR adds a mutex around the Read & Write operations, which allows users to read from/write to it in multiple goroutines.

bors r+


Chaining several commands?

Hi, excuse me if this is somewhere in the docs, but I couldn't find an example to help with this.
Is there any way to chain several commands together, without nesting several callback functions?
For example, I would like to automate a deployment process that involves the command sequence:

git checkout deploy-dev
git merge master
git push origin deploy-dev
git checkout master

Right now I'm doing this like so:
git.checkout('deploy-dev', function() {
  git.merge('master', function() {
    git.push('origin', 'deploy-dev', function() {
      git.checkout('master');
    });
  });
});

But obviously this is not preferable.
I've also tried by starting with gulp.src('./*') then pipe-ing through the sequence of gulp commands, but I get the error:
TypeError: Cannot read property 'on' of undefined

Thanks in advance for your help and nice work on this package.

Certain functions are through streams, allowing the gulp.src to pass files through.
The rest are normal callback functions.
add, checkoutFiles, commit, and rm are streams that take a gulp src.

So I suppose they could be wrapped in promises to avoid making the nested callbacks. I'll try that and post back.

I know it is pretty old issue. But posting a simpler solution for others benefit.
const util = require('util');
const git = require('gulp-git');

const methods = [
  'addRemote', 'removeRemote', 'addSubmodule', 'updateSubmodule',
  'push', 'pull', 'fetch', 'clone', 'tag', 'branch', 'checkout', 'merge',
  'reset', 'clean', 'exec'
];

methods.forEach(function (method) {
  var func = git[method];
  git[method] = util.promisify(func);
});

Then you can define an async task as described here: https://gulpjs.com/docs/en/getting-started/async-completion#using-async-await.


Define detailed release procedures

more info has been flashed out (but still wip) here https://docs.google.com/document/d/1t-08b970i9PMBy-TSM64x0RUH46pzwnIhEi-LVeL0lg/edit?usp=sharing


Added open source at microsoft post

Adds the post for the Microsoft talk

@OSUOSC/website-team

Was the first paragraph written by you or the presenter? We might want to avoid highlighting Microsoft's past* out of courtesy to the recruiter.

Yes I'm aware they were really shitty to Linux and still kind of are with Android lawsuits

@oslerw, it was written by Sherwin and given to me by Nikit. I just added meeting time/place and the laptop not

Oh, that's fine then. Thanks!


dddd always returns dow after using updateLocale

Hey,
There's something pretty weird with updateLocale and setting week: { dow: 6 }.
moment.updateLocale('en', { week: { dow: 6 } });
moment.locale('en');
moment('Sunday', 'dddd').weekday(); // 6
moment('Friday', 'dddd').weekday(); // 6
moment('Monday', 'dddd').weekday(); // 6

I found a workaround, this just works fine:
moment().day('Saturday').weekday(); // 0
moment().day('Sunday').weekday(); // 1

Yep, that's not right.
See below:
moment.updateLocale('en', { week: { dow: 6 } });
moment.locale('en');
moment('Tuesday', 'dddd').format()
"2016-01-01T00:00:00-06:00" //this is a friday

Things start to work if I specify the week.doy property as well. Before updateLocale this was a known issue. I thought that after updateLocale it should have been fixed. Will investigate.

@mdibaiee this is related to the fact that updateLocale('en', ...) doesn't work like updateLocale for all other locales. This is also reported in #3137, and fixed in #3235.
For now just specify both dow and doy and it should work.

Closing this in favor of #3137 and #3235, I just ran this example with the PR and it produces (correctly):
>  moment.updateLocale('en', { week: { dow: 6 } })
...
> moment.locale('en');
'en'
> moment('Sunday', 'dddd').weekday();
1
> moment('Friday', 'dddd').weekday();
6
> moment('Monday', 'dddd').weekday();
2

@ichernev alright, thank you!


nuclei: 2.7.4 -> 2.7.5

Description of changes
https://github.com/projectdiscovery/nuclei/releases/tag/v2.7.5

Things done

Built on platform(s)

[ x x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 183013 run on x86_64-linux 1

1 package built:

nuclei


HostAliases in values.yaml

I have question regarding hostAliases in the kong chart. Is it available on this chart? Because I don't see the documentation mentioning it and seems unavailable in this repo's values.yaml.
Am I missing something?

I'm not sure what you mean by hostAliases here. Could you please elaborate?
A quick grep reveals nothing of that sorts in this repo.

The hostAliases I meant is this one:
https://kubernetes.io/docs/concepts/services-networking/add-entries-to-pod-etc-hosts-with-host-aliases/
When I write a kubernetes deployment file, I provide it in deployment.spec.template.spec.hostAliases.

Ah, I was not aware of such a feature in PodSpec.
We do not support it in this chart, but we will be happy to add it in if you can send a PR.
Out of curiosity, what is your use case for this?

Ohh I see, thank you for the information.
My case of this usage is my need to alias some private dns using private ips.

Okay, please send us a PR if you would like to add this feature.


Task#536167:[Refresh link]Replace bookmarks in repo

Docs Build status updates of commit e99d71a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/authenticate-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-configuration.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-extensions-overview.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/create-an-azure-service-principal-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/get-started-with-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/manage-azure-subscriptions-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/reference-types-and-status.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/use-cli-effectively.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d6355eb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/authenticate-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-configuration.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-extensions-overview.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/create-an-azure-service-principal-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/get-started-with-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/manage-azure-subscriptions-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/reference-types-and-status.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/use-cli-effectively.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

hi @chasewilson , could you help review this pr?

@yunair, LGTM.


ci: Fix conditions for building and publishing

Based ont he github documentation:
github.events.ref: Is the ref of a release that has been created github.ref: If the branch that is being used (depending on the action)

create a release:      It will be refs/tags/<tag_name>
create a pull request: It will be refs/pull/<pr_number>/merge
push to a branch:      It will be refs/heads/<branch_name>

For publishing to pypi, we are targeting the "create a release" event. In which case:

github.events.ref will be refs/tags/<tag_name>
github.ref will also be refs/tags/<tag_name>

So, it looks like our IF condition was incorrect.
Ref: https://docs.github.com/en/actions/learn-github-actions/environment-variables

@AbdealiJK  this seems very strange.

Building and publishing our latest version, should happen on the master branch, regardless if a tag is specified or not.
If a tag is specified that starts with "v" and we are on a master branch, we should do a release to pypi.

From what I can see from your suggested changes, this does not seem to be the case anymore?

I don't think github actions has a way of detecting a tag is specified that starts with "v" and we are on a master branch (atleast not with the variables we are using right now.
From what I read in the documentation ...
The variables we are using are:
github.ref doc

The fully-formed ref of the branch or tag that triggered the workflow run. For workflows triggered by push, this is the branch or tag ref that was pushed. For workflows triggered by pull_request, this is the pull request merge branch. For workflows triggered by release, this is the release tag created. For other triggers, this is the branch or tag ref that triggered the workflow run. This is only set if a branch or tag is available for the event type. The ref given is fully-formed, meaning that for branches the format is refs/heads/<branch_name>, for pull requests it is refs/pull/<pr_number>/merge, and for tags it is refs/tags/<tag_name>. For example, refs/heads/feature-branch-1.

github.event doc

The full event webhook payload. You can access individual properties of the event using this context. This object is identical to the webhook payload of the event that triggered the workflow run, and is different for each event. The webhooks for each GitHub Actions event is linked in "Events that trigger workflows." For example, for a workflow run triggered by the push event, this object contains the contents of the push webhook payload.

and the 2 events we enabled in the yaml file are:

push
pull_request

Leaving pull request aside for now ...
Push can have 2 cases:

Push a tag
Push a branch

When I am reading through the documentation again, I am realizing that github.ref and github.event.ref will always be the same for the push event.
So, tweaking your logic:

Building and publishing our latest version, should happen on any push to the master branch, regardless if a tag is specified or not.
If a tag is specified that starts with "v" and pushed, we should do a release to pypi.

yes I guess that's the best we can do.
It's just strange, cause the current logic did work on v1.9 🤔

I believe the issue was introduced in where the IF conditions for both PR and Publish cases were being written
https://github.com/JessicaTegner/pypandoc/commit/ad520d1bca40f6bf1ad3d77f357068c326e8c45c#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR73
In v1.9 from what I see, there were 2 separate yaml files being used each with their own on: criteria - which was merged in https://github.com/JessicaTegner/pypandoc/commit/7ccd216e0949e230fa8e69c65ed42c143185d6a3

Do you think the current implementation you've written here, will work?

I believe so
But I am not an expert at GitHub actions. So the only way to know is to try it out :)

well here we go: https://github.com/JessicaTegner/pypandoc/actions/runs/3347112634


Make Service Type variable

Currently the used service type is oneshot. This is a good choice for most.
However, I came across an issue that I need systemd to restart the service on failure. This sadly is not possible with oneshot, but it is with simple.
Anyhow, I would be happy if you could merge this and create a new tag. Thanks!

@joe-ERhz5pn0 you need to add the type variable to the epp() call in manifests/init.pp
You can run the tests locally with pdk test unit. I will re-add automatic testing when I have some time for it

@joe-ERhz5pn0 you need to add the type variable to the epp() call in manifests/init.pp
You can run the tests locally with pdk test unit. I will re-add automatic testing when I have some time for it

Apologies, added.


Syntax for http response style JSON

I'm not sure how the syntax should be for this case:
Input:
{
  "success": true,
  "data": [
    { id: 1, value: "Hello", created: "2019-10-02 14:30:00" },
    { id: 2, value: "There", created: "2019-10-02 14:30:00" },
    { id: 3, value: "General", created: "2019-10-02 14:30:00" }
  ]
}

Assert:
expect(res.body).excludingEvery('created').to.eql({
  "success": true,
  "data": [
    { id: 1, value: "Hello" },
    { id: 2, value: "There" },
    { id: 3, value: "General" }
  ]
});

I ended up separating the top level, but I was wondering if there is a way to exclude in a single assert? Perhaps something like .excludingEvery('data.created')?
Separated:
expect(res.body.success).to.eql(true);
expect(res.body.data).excludingEvery('created').to.eql([
    { id: 1, value: "Hello" },
    { id: 2, value: "There" },
    { id: 3, value: "General" }
]);

Perhaps something like .excludingEvery('data.created')?

@Torniojaws There's no way to do this currently. From what I see, you are doing it correctly by separating the assertions.

Also, @Torniojaws you can keep the created key in your result and chai-exclude will still ignore the key from comparison.
expect(res.body.data).excludingEvery('created').to.eql([
    { id: 1, value: "Hello", created: "2019-10-02 14:30:00" },
    { id: 2, value: "There", created: "2019-10-02 14:30:00" },
    { id: 3, value: "General", created: "2019-10-02 14:30:00" }
]);

Closing this issue @Torniojaws, I hope I have answered your question. If there are any updates in the future I'll reply back in this thread.


Issues when inserting records to Oracble DB

Hi sir,
I'm using your library to connect to Oracle server to insert a record to database there. However when executing it, it throws this error: The SELECT permission was denied on the object 'Users', database 'XXX', schema 'dbo'
Because the Oracle prevents from selecting data from the Users table. I wonder why your code has to select data from the table while inserting a record to the database?
My client set security that not allow selecting data from the table. I can't change it. Do you have any suggestions to solve this issue? inserting data without selecting?
Thanks!

knex.js along with the oracle node driver are responsible for connecting to the db and building the SQL. Objection simply uses knex as the query builder. You should try to run the same query first using knex and then using the plain driver itself and then open the issue in the appropriate project's github.
I'm quessing though that this is more of a user error and it would be better to ask this question in stack overflow or any of the mentioned projects' chat's .


fix for hip build: fpic error

When building RAJA+hip with spack, I got the error below. The issue appears to be the snippet, --shared -Xcompiler '-fPIC' -g -O2 , with extra quotes around -fPIC . This fix should resolve the issue.
 121    /opt/rocm/hip/bin/hipcc -M /var/tmp/taller1/spack-stage/spack-stage-raja-develop-b4qt3dtl6mlnht4fte73dtv3r2bzkz2i/spack-src/src/MemUtil
        s_CUDA.cpp -o /tmp/taller1/spack-stage/spack-stage-raja-develop-b4qt3dtl6mlnht4fte73dtv3r2bzkz2i/spack-build-b4qt3dt/CMakeFiles/RAJA.di
        r/src/RAJA_generated_MemUtils_CUDA.cpp.o.depend.pre --amdgpu-target=gfx900 --shared -Xcompiler '-fPIC' -g -O2 -I/var/tmp/taller1/spack-
        stage/spack-stage-raja-develop-b4qt3dtl6mlnht4fte73dtv3r2bzkz2i/spack-src/include -I/tmp/taller1/spack-stage/spack-stage-raja-develop-b
        4qt3dtl6mlnht4fte73dtv3r2bzkz2i/spack-build-b4qt3dt/include -I/var/tmp/taller1/spack-stage/spack-stage-raja-develop-b4qt3dtl6mlnht4fte7
        3dtv3r2bzkz2i/spack-src/tpl/cub -I/var/tmp/taller1/spack-stage/spack-stage-raja-develop-b4qt3dtl6mlnht4fte73dtv3r2bzkz2i/spack-src/tpl/
        rocPRIM/rocprim/include -I/var/tmp/taller1/spack-stage/spack-stage-raja-develop-b4qt3dtl6mlnht4fte73dtv3r2bzkz2i/spack-src/tpl/camp/inc
        lude

122    clang-11: error: no such file or directory: ''-fPIC''
123    CMake Error at RAJA_generated_AlignedRangeIndexSetBuilders.cpp.o.cmake:143 (message):

Do you know why it's using HIP_NVCC_FLAGS?

Do you know why it's using HIP_NVCC_FLAGS?

I do not know. The while issue was very strange. I was not able to replicate it on when building by hand. It only came up when I built through spack, even if I was in theory using the same version of blt and flags. I might also ask Greg Becker, but I am a bit mystified.

HIP relies on some environment variables to determine the target it’s compiling for – so perhaps it’s an issue there.

HIP relies on some environment variables to determine the target it’s compiling for – so perhaps it’s an issue there.

Looking through the build log, I do see the hip platform listed as hcc . This means that we are NOT  HIP_PLATFORM_NVCC . I will investigate more
-- Git Version: 2.29.1
-- MPI Support is OFF
-- OpenMP Support is OFF
-- CUDA Support is OFF
-- HIP Support is ON
-- Found HIP: /opt/rocm/hip (found version "3.8.20371-d1886b0b")
-- Performing Test HIP_CLANG_SUPPORTS_PARALLEL_JOBS
-- Performing Test HIP_CLANG_SUPPORTS_PARALLEL_JOBS - Success
-- HIP version:      3.8.20371-d1886b0b
-- HIP platform:     hcc

HIP relies on some environment variables to determine the target it’s compiling for – so perhaps it’s an issue there.

Hi @davidbeckingsale . Right above the section of code that I altered, there is a comment
If we are building a shared library, add extra flags to HIP_HIPCC_FLAGS
However, HIP_HIPCC_FLAGS was not previously set. This is the preferred flag that should be set
I think the right thing to do is set set either HIP_HIPCC_FLAGS or HIP_NVCC_FLAGS based on the hip platform we are on, so that there is no confusion.
Also, there was an issue with spack where the raja project did not have a depends_on for camp (missing dependency), which also caused problems since this logic is for shared libraries in particular. I added a fix in https://github.com/spack/spack/pull/20070 .

Do you know why it's using HIP_NVCC_FLAGS?

I do not know. The whole issue was very strange. I was not able to replicate it on when building by hand. It only came up when I built through spack, and only the develop version of blt (not previous release) even if I was in theory using the same version of blt and flags for both spack build and by hand build. I might also ask Greg Becker, but I am a bit mystified.

Hi @davidbeckingsale . I found out why this only occurs on spack builds but not our local by hand builds. HIP_NVCC_FLAGS does get appended to our flags in both cases. However, the difference is that the local build uses camp as a submodule in which case HIP_NVCC_FLAGS is an empty string (fPIC is not added) whereas spack uses it as a shared library so this fPIC string is added.
I added the following code to BLT. Note the messages:
# If we are building a shared library, add extra flags to HIP_HIPCC_FLAGS
**message(STATUS "shared libs: ${_hip_build_shared_libs}")**
if(_hip_build_shared_libs)
    list(APPEND HIP_HCC_FLAGS "-fPIC")
    list(APPEND HIP_CLANG_FLAGS "-fPIC")
    if("x${HIP_PLATFORM}" STREQUAL "xnvcc") # hip using nvcc cuda underneath
        **message(STATUS "shared libs: nvcc platform")**
        list(APPEND HIP_NVCC_FLAGS "--shared -Xcompiler '-fPIC'")
    else() # platform is hcc
        **message(STATUS "shared libs: hcc platform")**
        list(APPEND HIP_HIPCC_FLAGS "-fPIC")
    endif()
endif()

When building with spack, we get:
corona211{taller1}52: spack install -v raja@develop%clang@amd~openmp+hip amdgpu_target=gfx900                                           ==> Warning: Missing a source id for blt@develop
==> Warning: Missing a source id for<EMAIL_ADDRESS>==> Warning: Missing a source id for raja@develop
[+] /usr/tce (external cmake-3.14.5-fleamlqxvqbmofmwcjegqaqsgi6nn7wf)
[+] /opt/rocm/hip (external hip-3.8.20371-d1886b0b-yop5tikgvj7qs5quvi2kjbrjqsbdmeep)
[+] /opt/rocm (external hsa-rocr-dev-3.9.0-mqsluumpiigv3p4urrinvkswegcncig2)
[+] /opt/rocm/llvm (external llvm-amdgpu-3.9.0-t7rhs6lyfipbgogev5mr2zb2q7ddo7xb)
[+] /g/g17/taller1/CARE_SPACK/spack/opt/spack/linux-rhel7-zen2/clang-amd/blt-develop-hvmcsla62l5upqr4qqe4ectaitmz3aex
[+] /g/g17/taller1/CARE_SPACK/spack/opt/spack/linux-rhel7-zen2/clang-amd/camp-0.1.0-kqmbszjmf7x63lyqg2pp6adjgclxip23
==> Installing raja-develop-qael4dobyfrkbhmjmbfdohzc54jity3q
...
...
-- Using installed CAMP from:  /g/g17/taller1/CARE_SPACK/spack/opt/spack/linux-rhel7-zen2/clang-amd/camp-0.1.0-kqmbszjmf7x63lyqg2pp6adjgclxip23
-- shared libs: TRUE
-- shared libs: hcc platform
So we go through the shared library logic where fPIC is added to the list of flags.
When we build locally, we have,
corona211{taller1}67: cmake .. -DENABLE_HIP=ON -DHIP_ROOT_DIR=/opt/rocm/hip -DHIP_CLANG_PATH=/opt/rocm/llvm/bin/  -DCMAKE_C_COMPILER=/opt/rocm/llvm/bin/clang -DCMAKE_CXX_COMPILER=/opt/rocm/llvm/bin/clang++ -DCMAKE_BUILD_TYPE=Debug -DENABLE_GTEST_DEATH_TESTS=1 -DENABLE_BENCHMARKS=OFF -DBLT_SOURCE_DIR=/g/g17/taller1/CARE_SPACK/spack/opt/spack/linux-rhel7-zen2/clang-amd/blt-develop-hvmcsla62l5upqr4qqe4ectaitmz3aex
-- The CXX compiler identification is Clang 11.0.0
...
...
-- Using RAJA CAMP submodule.
-- shared libs: FALSE
So we do not exercise this logic at all for the local build

After discussions with David, David Beckinsale recommended an alternate fix for the issue I discovered. Thanks David!

Made fix so both hcc and amd will be accepted for HIP_PLATFORM, along with a comment explaining why this is needed. The comment comes from correspondence between David and the vendor. Thanks!

Thanks for getting this working @dtaller !

Interesting, I wasn't aware that 4.0 had been released since 3.10 was just released (I think) yesterday

It isn't, but these CMake files came from the "develop" rocm iirc.

Interesting, I wasn't aware that 4.0 had been released since 3.10 was just released (I think) yesterday

It isn't, but these CMake files came from the "develop" rocm iirc.

When it releases maybe we could make this check a little more precise with `${HIP_VERSION_MAJOR}" which FindHIP defines for us.


size of JAR generated by mvn

I checked out latest head and noticed it's no longer possible to compile closure using ant. I created a settings.xml as README.md advises and called mvn  -DskipTests -pl externs/pom.xml,pom-main.xml,pom-main-shaded.xml. I ended up with plenty files in target folder. closure-compiler-1.0-SNAPSHOT.jar is about 9 MB size, closure-compiler-1.0-SNAPSHOT-shaded.jar also.  When I download the compiler package from the github wiki the compiler.jar is about 6 MB.
In my folder there's closure-compiler-unshaded-1.0-SNAPSHOT.jar that's 6 MB and also original-closure-compiler-1.0-SNAPSHOT.jar
What is the JAR included in your binary release? What is the difference?

I'd have to double check but I think the one you get from dl.google.com is the shaded jar. When we made the switch we did notice that Maven was producing a bigger jar, and we weren't sure of all the reasons for that. But we managed to shrink it down a little bit (e.g. 66f6fa7964cd09c905e2a273a62adf5b40965a78) although it may be possible to shrink it even further.


Sidearm

These are relatively small changes to allow sources to be http within hybrik. I noticed that some of these files don't have tests written. Like preset mapping. Im used to the pytest way of like file_test and just assume if that _test doesn't exist then that file has no tests written. Not sure how to check code cov  on some of this stuff to see how to better update the coverage. Anyhow, was gonna write a small test and create preset_mapping_test to test out the small update i made.
Will also like to open this up to discuss this linting stuff that im seeing with the redis flag. Not sure how to proceed do I just need to update the linter? I know @zsiec said maybe just remove it. but i dont think we commited to anything when first discussed.

Thanks for extending this @krystalmejia24! When we picked up this code, the Hybrik provider had no testing, so we've been adding them as we go in to make changes. In order to get the most value for our tests, we've started testing at a high level, adding cases that exercise the low level implementations in meaningful ways. We've focused on testing our external interfaces found in hybrik.go (and functions close to them) to cover as much as code as we can while building out new functionality. Over time, I'm confident we can reach a comfortable coverage level, today we're a little over 70% for all the functional Hybrik code. I can help show you how to check coverage in your IDE, it's pretty straight forward!
I've opened this issue to continue our conversation about linting, in the PR, I've disabled the problematic filter https://github.com/cbsinteractive/mediahub/issues/96


Api path incorrect

[ ] both Signet and Testnet has the same api.testnet.hiro.so

For both Bitcoin Testnet and Bitcoin Signet, we use Stacks testnet (as no Stacks signet exists). That's why the URLs are the same.
Suggest this becomes a task to display the Bitcoin URL too, as to avoid confusion.


Don't hash executable filenames on apple platforms.

Due to some recent changes to the backtrace crate, backtraces on apple platforms haven't been working (they are missing line/filename information). The reason is that previously libbacktrace would hunt through the directory for any matching file in the .dSYM directory. The new implementation expects a file matching the executable name exactly (which no longer includes the hash because Cargo renames it).
The solution here is to not include a hash in the executable filename. This matches the behavior on Windows which does it for a similar reason (paths are embedded in pdb files).
The downside is that switching between different settings (like different features) causes Cargo to rebuild the binary each time.  I don't think this is a particularly common use case, at least I've not heard any complaints about this behavior on Windows.
Fixes https://github.com/rust-lang/rust/issues/72550

If we believe this is not a common use case, could we do this everywhere, rather than adding one more case to the list of cases?
Alternatively, is there some way we can emit a .dSYM file whose name includes the hash, so that it matches that way?

@bors: r+
Since this is fixing a regression in rust-lang/rust I'm going to go ahead and approve so we can land this in. I think @joshtriplett is right thought that if 2/3 major platforms don't do this then we should back it out for all platforms. I also agree with you @ehuss that we should ideally not look at the target string at all in Cargo...

:pushpin: Commit f975c2e5889c4a6b16568e9b68ec9ec85ec8f795 has been approved by alexcrichton

:hourglass: Testing commit f975c2e5889c4a6b16568e9b68ec9ec85ec8f795 with merge e9d7af4696b7ce76cefdfad9d16ca6a8162cf231...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing e9d7af4696b7ce76cefdfad9d16ca6a8162cf231 to master...

Filed #8332 and #8333 for the issues raised here.


Can't disable IPv6

Environment
Windows build number: Win32NT             10.0.19041.0 Microsoft Windows NT 10.0.19041.0
Your Distribution version: debian 10
Whether the issue is on WSL 2 and/or WSL 1: wsl2

Steps to reproduce
My ISP doesn't support IPv6, so in windows I disable ipv6 using this article: https://support.microsoft.com/en-us/help/929852/guidance-for-configuring-ipv6-in-windows-for-advanced-users
I also set Google DNS on my router using <IP_ADDRESS>/<IP_ADDRESS> and disable ipv6 dns option
This is how /etc/resolv.conf looks like:
# This file was automatically generated by WSL. To stop automatic generation of this file, add the following entry to /etc/wsl.conf:
# [network]
# generateResolvConf = false
nameserver <IP_ADDRESS>

This is ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: bond0: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 62:b7:99:e0:4d:a4 brd ff:ff:ff:ff:ff:ff
3: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 4a:2c:37:0e:91:bd brd ff:ff:ff:ff:ff:ff
4: sit0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/sit <IP_ADDRESS> brd <IP_ADDRESS>
5: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 00:15:5d:fb:9d:18 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/20 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::215:5dff:fefb:9d18/64 scope link
       valid_lft forever preferred_lft forever

this is inet6 address I can't disable, and then when I use curl or software using curl for networking (line PHP), it can't connect every 3-4 time it sends request, looks like this
curl -v https://getcomposer.org/versions
...
* Expire in 149999 ms for 3 (transfer 0x564b37971a90)
* Immediate connect fail for 2001:41d0:302:1100::8:104f: Network is unreachable
*   Trying 2600:9000:5305:f300::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x564b37971a90)
* Immediate connect fail for 2600:9000:5305:f300::1: Network is unreachable
*   Trying 2600:9000:5306:8300::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x564b37971a90)
* Immediate connect fail for 2600:9000:5306:8300::1: Network is unreachable
*   Trying 2600:9000:5300:fa00::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x564b37971a90)
* Immediate connect fail for 2600:9000:5300:fa00::1: Network is unreachable
*   Trying 2600:9000:5303:dd00::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x564b37971a90)
* Immediate connect fail for 2600:9000:5303:dd00::1: Network is unreachable
*   Trying 2600:9000:5305:f300::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x564b37971a90)
* Immediate connect fail for 2600:9000:5305:f300::1: Network is unreachable
*   Trying 2600:9000:5306:8300::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x564b37971a90)
* Immediate connect fail for 2600:9000:5306:8300::1: Network is unreachable
*   Trying 2600:9000:5300:fa00::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x564b37971a90)
* Immediate connect fail for 2600:9000:5300:fa00::1: Network is unreachable

Failing indefinitely, mostly I got connection timeout after 60 sec or so.
I tried disabling ipv6 on wsl virtual adapter but it auto enable back after reboot.
Expected behavior
Please, help disable ipv6 dns and requests inside wsl

If your ISP doesn't support it, why do you disable it? That will give you no advantage. Maybe it could even solve your problem. Habe you tried enabling IPv6 in Windows?

If your ISP doesn't support it, why do you disable it? That will give you no advantage. Maybe it could even solve your problem. Habe you tried enabling IPv6 in Windows?

i disabled ipv6 trying to resolve dns problem (it was enabled before). unfortunately, it did not affect issue anyhow.

Run sudo sysctl -w net.ipv6.conf.all.disable_ipv6=1 at every wsl starts.

Run sudo sysctl -w net.ipv6.conf.all.disable_ipv6=1 at every wsl starts.

Tried it before, just got different error
* Expire in 149999 ms for 3 (transfer 0x55e506633a90)
* Immediate connect fail for 2600:9000:5304:c900::1: Cannot assign requested address
*   Trying 2600:9000:5307:bb00::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x55e506633a90)
* Immediate connect fail for 2600:9000:5307:bb00::1: Cannot assign requested address
*   Trying 2600:9000:5300:3800::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x55e506633a90)
* Immediate connect fail for 2600:9000:5300:3800::1: Cannot assign requested address
*   Trying 2600:9000:5303:700::1...
* TCP_NODELAY set
* Expire in 149999 ms for 3 (transfer 0x55e506633a90)
* Immediate connect fail for 2600:9000:5303:700::1: Cannot assign requested address

ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
2: bond0: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether ae:92:e7:14:31:b6 brd ff:ff:ff:ff:ff:ff
3: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 2e:9a:5c:33:f9:ba brd ff:ff:ff:ff:ff:ff
4: sit0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/sit <IP_ADDRESS> brd <IP_ADDRESS>
5: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 00:15:5d:f2:33:2e brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/20 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever

Doesnt help =(

Does curl -4 -v https://getcomposer.org/versions work?

Can you ping -4 www.google.com or ping <IP_ADDRESS>?

Sure,
# ping -4 www.google.com
PING www.google.com (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from lg-in-f103.1e100.net (<IP_ADDRESS>): icmp_seq=1 ttl=106 time=47.2 ms
64 bytes from lg-in-f103.1e100.net (<IP_ADDRESS>): icmp_seq=2 ttl=106 time=45.4 ms
^C
--- www.google.com ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 3ms
rtt min/avg/max/mdev = 45.380/46.291/47.202/0.911 ms
# ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=107 time=53.1 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=107 time=52.7 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=107 time=53.6 ms
64 bytes from <IP_ADDRESS>: icmp_seq=4 ttl=107 time=52.6 ms
^C
--- <IP_ADDRESS> ping statistics ---
4 packets transmitted, 4 received, 0% packet loss, time 8ms
rtt min/avg/max/mdev = 52.567/52.987/53.579/0.490 ms
# ping google.com
PING google.com (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from li-in-f139.1e100.net (<IP_ADDRESS>): icmp_seq=1 ttl=106 time=44.6 ms
64 bytes from li-in-f139.1e100.net (<IP_ADDRESS>): icmp_seq=2 ttl=106 time=45.5 ms
64 bytes from li-in-f139.1e100.net (<IP_ADDRESS>): icmp_seq=3 ttl=106 time=45.3 ms
^C
--- google.com ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 6ms
rtt min/avg/max/mdev = 44.594/45.121/45.482/0.418 ms

all software including PHP composer works perfectly on windows host, experience problems only with requests inside wsl2. strange, but it connects to ipv6 only in about 25% of all requests.

composer selfupdate

  [Composer\Downloader\TransportException]
  The "https://getcomposer.org/versions" file could not be downloaded: failed to open stream: Connection timed out

and repeat it just after failed
composer selfupdate
You are already using composer version 1.10.8 (stable channel).

Installed ubuntu-20.04 just to check, got same result.
Disabled /etc/resolv.conf autogeneration, set <IP_ADDRESS> and <IP_ADDRESS> fixed ipv6 problem.
But new problem, now my corporate VPN not work )

Can you connect to your corporate VPN? Maybe they force IPv6?

@treysis awesome! looks like it really related. when i disconnect from vpn i have no issues with dns and vice versa!
created request for our admins about this, thanks for idea.

Interesting. I actually didn't really believe there were IPv6-enforcing company VPN out there! May I ask which company is so forward thinking?

@treysis it's more likely VPN DNS works like round robin (giving ipv6 address for host every 1/4 request or so), btw admins can't disable this behavior used by other teams for testing I guess. but they provide different VPN group with different dns settings, solved problem for me. company is plesk.
thanks all and especially @treysis for problem solving.


Debugger stops at logpoint

VS Code version: 1.30.2 (user setup)
Extension version: 2019.1.0
OS and version: Windows 10 (1809) - OS Build 17763.292)
Python version: 3.7.1
Type of virtual environment used: none

Expected behaviour
**Debugger should run program without stopping**

Actual behaviour
**Stops at a logpoint**

Steps to reproduce:
1. Create a logpoint at any line of code
2. Add a message to be printed in the output tab
3. Hit F5 or choose from the menu Debug -> Start Debugging

Logs
Nothing printed

Output from Console under the `Developer Tools:
nothing printed

Upstream issue https://github.com/Microsoft/ptvsd/issues/1142

Closed as fixed in latest release.

@DonJayamanne  is this already released ?

Yes


nix: allow static compilation

Continuation of https://github.com/NixOS/nixpkgs/pull/56281
Nix compiles statically, but not everything is included:
$ nix-store -qR /nix/store/51sl3macs7bjrx8lfck8pmlcnq01hpyd-nix-2.3-x86_64-unknown-linux-musl
/nix/store/6yaj6n8l925xxfbcd65gzqx3dz7idrnn-glibc-2.27
/nix/store/kn9w6k46qmzrv3hgzs1csrrs3dcad7h6-attr-2.4.48
/nix/store/08al8hwj0hvqahb0yibslsmsvj50b1qz-acl-2.2.53
/nix/store/11kmi14g34nfb54d2bnv7q8mg17vn98h-nix-2.3-x86_64-unknown-linux-musl-man
/nix/store/5dn03xfw3wimm78nfpg67p1zj1025sbc-bzip2-<IP_ADDRESS>.1
/nix/store/440vkrx6mf7v4j4z88vjcp6pavk05lig-bzip2-<IP_ADDRESS>.1-bin
/nix/store/a66s8hzy6w34dlh6ahgfdwaiglpcny65-gnutar-1.32
/nix/store/yk8lp0x7sml42gaf9gfkr6cwx99glz7b-xz-5.2.4
/nix/store/jryr8hdk55jrmmicyz5j9shyvzqydfk8-xz-5.2.4-bin
/nix/store/kq5axl0hwrnxm1ri3dc7dgmnx7pwn9xc-busybox-1.30.1-x86_64-unknown-linux-musl
/nix/store/kx56d14p0qm2awn0qrqrv4rb8xdhvhpi-coreutils-8.31
/nix/store/l6h4ya0wzb4b8mr0y58k2gh2nhfql4sn-bash-4.4-p23
/nix/store/sgganmpm2bbnqmgz35hrgp4d0cvml6ir-gzip-1.10
/nix/store/k99c3nzlhg3znrjj5h3s03ckbb898rn0-musl-1.1.22-x86_64-unknown-linux-musl
/nix/store/xrkb0djwxjqciyk7ikgk2fxrk1dj0226-openssl-1.0.2t-x86_64-unknown-linux-musl
/nix/store/51sl3macs7bjrx8lfck8pmlcnq01hpyd-nix-2.3-x86_64-unknown-linux-musl

[ ] openssl builds also shared libs and those are linked instead of static
[ ] nix config depends on some binaries (gnutar, ...)
[ ] support https based stores

Unfortunately, without https://github.com/NixOS/nix/pull/2698, you can’t use https-based stores.

Just a commnet: static nix by @matthewbauer has been very helpful. Having this built by nixpkgs would be great.

Patch size has shrunk a bit. This builds and was useful to me, doing evaluation-only on terraform cloud (no root, no namespaces). https://github.com/NixOS/nixpkgs/compare/master...roberth:static-nix-2020-03-04?expand=1

https://github.com/NixOS/nixpkgs/compare/master...roberth:static-nix-2020-03-04?expand=1

That said, this should be supported through in the Nix release itself and not tacked on later. A patch like this helps: https://github.com/NixOS/nix/pull/2698.
I don't know exactly why the NIX_LDFLAGS override is necessary, but it seems like something that should be handled in the Nix build files instead.

NIX_LDFLAGS shouldn't be necessary with https://github.com/NixOS/nix/pull/3194

IIRC Nix master also now compiles rust, which doesn't compile statically. Maybe that was fixed since I looked.

IIRC Nix master also now compiles rust, which doesn't compile statically. Maybe that was fixed since I looked.

It certainly possible to compile static rust binaries, not sure if we can make ours do so.

I think probably the first step would be to add static compilation to github actions on nix repo.

Are there actions for this? Current nixUnstable does not even build with pkgsMusl, let alone pkgsStatic

The upstream flake defines a nix-static package https://github.com/NixOS/nix/blob/02a1facbdc89c5041ba55387645484ad785cba7a/flake.nix#L455

I guess I'm blind! Thanks Rob.

It's not obvious at all. It just so happened that I've seen it there and I was subscribed to this thread.


Run task in independent environment

Do you mean something like airflow operators?

Not clear what to do with middlewares


spec: key updated

this pull request is obsolete as we have moved it to publickeystore, to avoid name conflict with keyvaluestore


Update seo.html for meta description

Adding standard meta description immediately after sex_description has been defined.

Can you submit this against develop branch instead of master? It helps with merging and deploying new releases.

submitted for the develop branch.  Closing this PR.


github actions macos-14 build

#80 makes our macos CI pass by pinning to the macos-13 image. Ideally we'd work on macos-14 too.

https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md and https://github.com/actions/runner-images/blob/main/images/macos/macos-13-arm64-Readme.md do not differ that much with regards to SSL/TLS.


[Docs] Replace Icon Font with SVG Icons

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Update the next docs site to use SVG Icons so that it works offline (independently of the MD Icon Font).

Still some components to fix

Bah, thanks - thought I got them all.
Not sure what's going on with Tabs - an Icon should be an Icon. I'll take a look.

Okay, I'd updated the docs site components and examples, but missed the obvious fact that some components use icons internally, so when I removed the Icon Font, those broke.
Tabs is fixed, with a resulting small change to vertical spacing.
I've updated the regression test baseline image, but should probably add regression tests for both icon types.
@oliviertassinari Please could you take a look at the failing tests?

@oliviertassinari Please could you take a look at the failing tests?

Eslint is complaining. Do you have access to the circle logs?

Eslint is complaining.

Bah, yes, I need to ad lint to git as a pre-push hook! 😄
But I actually meant the unit tests that I mentioned in chat.

Do you have access to the circle logs?

Yes.

@oliviertassinari I had a crack at fixing the BottomNav layout, but let me know if there's a better way. Otherwise, just those pesky test failures when you get a chance to take a look.

@oliviertassinari I had a crack at fixing the BottomNav layout, but let me know if there's a better way. Otherwise, just those pesky test failures when you get a chance to take a look.

My only concern would be with the convention we use for the svg-icons' filenames.

What's the concern?
Could you have a look at the failing unit tests please when you get a chance? (Sorry to keep asking).

What's the concern?

It regarding the naming convention of the file. For instance, why using src/svg-icons/star.js over src/svgIcons/Star.js?

Could you have a look at the failing unit tests please when you get a chance? (Sorry to keep asking).

I'm not sure what's counter intuitive from the failing error. Basically, he can't find wrapper.find('span.material-icons');
The PR now needs to be rebased 😬 .


Switch video

Hi,
Is there a way to switch the video src with the plugin? I know in the Youtube Iframe API it's possible with an api call like this player.loadVideoByUrl(URL) of player.loadVideoById(ID)
Any ideas on how to implement that feature?
Kind regards,

Hi,
I'm looking for the same thing. If someone can help us thx


Colour rendering backgrounds, text or drawn objects with LilyGo supplied TFT_eSPI library is not correct

OK, I have a strange issue and am wondering if anyone can point me in the right direction please.
I am using the LilyGo T-Embed ESP32S3 device which is working almost as I wish, however when using the supplied TFT_eSPI library (the version of which which LilyGo advise MUST be used), the colors displayed and rendered either as backgrounds, text or drawn objects are all incorrect.
For example, the code:
tft.fillScreen(TFT_RED);
actually fills the screen with blue!! and this code...
tft.setTextColor(TFT_YELLOW, TFT_BLACK);
tft.drawString("testing yellow", 10, 100, 4);

... renders teal coloured text and NOT yellow!!
Now, as both the T-Display and Touch versions each use RGB565 for colours which render fine, does the T-Embed board use a different colour format?

Fixed, please update the TFT in the lib directory again_ ESPI Library


perf(artifacts): get download URLs in batches

Fixes WB-13972
Description
Before:

32 threads downloading files 1 at a time; we query gorilla which does a bunch of MySQL queries, generates a download URL and redirects to it (code).

After:

1 thread getting download URLs for files in 5k batches; waiting for download threads to catch up (at most 5k files in download queue) before fetching the next batch
64 threads downloading files 1 at a time using the URL fetched above, falling back to getting the URL using the old method

Benchmark: downloading a 1 million file artifact went down from 5h 38min to 1h 11min (thread).
Depends on server-side change: https://github.com/wandb/core/pull/15374
Corresponding yea-wandb change: https://github.com/wandb/yea-wandb/pull/115
Test plan
Downloaded a 1 million file artifact with and without the server side change.

Nice, one thing @shawnlewis noticed when profiling was each thread starts a new session I think there might be something else fancy that can be done but glad we're using a session.

/fix-title


feat: Support Azure OpenAI endpoints with API key

Add support for Azure OpenAI endpoints by including the API key in request headers.

Fixed by mainteiner in Issue https://github.com/sourcegit-scm/sourcegit/issues/69


[Feature Request] Support for Gas Conduit

Compact Machines version: compactmachines3-1.12.2-3.0.15-b249
Forge version: 1.12.2
Adding support for EnderIO Gas Conduit addon

Nope.


Single project MSIX VSIX doesn't get automatically installed on VS 2019

Describe the bug
Internal bug (for MS employees): https://microsoft.visualstudio.com/OS/_workitems/edit/36926828
What is the product/business impact?
(This works fine on VS 2022). Users that download the Windows App SDK VSIXs for VS2019 will not automatically get the single-project MSIX packaging VSIX. As far as I know, there won't be a prompt telling them to download the VSIX, they'll just get errors when building or deploying a non-WAP app.
What is the issue?
Dev16 VSIXs built manifest is missing the extension pack reference to the single-project MSIX packaging VSIX.
Conditional logic was added that would keep the MSIX packaging VSIX in Dev17 standalone builds destined for the marketplace, but excluded if from the component builds destined for Visual Studio integration. Unfortunately, that logic also made it into the Dev16 VSIX builds, where the conditional was handled differently, so the MSIX packaging VSIX ended up being unconditionally excluded from Dev16.
What is the fix and most likely regression?
The fix is to revert the Dev16 VSIX back to including the MSIX packaging VSIX unconditionally.
This is a change that only affects how the VSIX is built and installed, so that installing the Windows App SDK Dev16 VSIXs will install also install the MSIX packaging VSIX. This is how the Dev17 VSIXs are already configured, and so we're simply restoring parity between Dev16 and Dev17.
No product regressions are expected. We have had difficulties in past releases with the VS Marketplace backend not handling the VS extension pack properly, but they have assured us the issue is fixed, and will rapidly resolve any future problems of this sort. To reiterate, this functionality already exists in the Dev17 VSIXs, so restoring this functionality to the Dev16 VSIXs does not introduce any new risk.
Steps to reproduce the bug

Install VS 2019
Attempt to install the WinAppSDK VSIX
Notice it gives an error about not being able to install Single Project MSIX VSIX

Expected behavior
No response
Screenshots
No response
IDE
Visual Studio 2019
NuGet package version
Microsoft.WindowsAppSDK 1.0.0-preview3

This is fixed in main and release/1.0-stable


Got es-abstract 404 Not Found error when trying to create nuxt project

command:
yarn create next-app demo

error:
error An unexpected error occurred: "https://registry.yarnpkg.com/es-abstract/-/es-abstract-1.14.0.tgz: Request failed \"404 Not Found\"".

Environment: with both node versions v16.9.1 and v14.17.6, yarn version is 1.22.11
Screenshot:

@adminoid This is likely an npm registry error - and not an issue with create-nuxt-app. It will likely be resolved eventually if you retry.

Ok, I've got it. But this error is stable. No that doesn't help either retrying or removing global node_modules with lock files and reinstall


sky_snapshot should work with absolute paths

Instead of appending the first path component, we should use it to initialize
result. That makes this code work with absolute paths.

TBR @eseidelGoogle

Thank you.


How to create Data Asset using Datastore connecting to SQL Server

Hello,
How do we create a data asset of Tabular type which could store data retrieved from a Azure SQL Database Query used in a Datastore using Azure SDK V2.
I see we could create such dataset using SDK V1 -- https://learn.microsoft.com/en-us/python/api/azureml-core/azureml.data.dataset_factory.tabulardatasetfactory?view=azure-ml-py
Is there any Class implemented on SDK V2?
BR,
Sourav.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5a80f64c-a8f3-c2fe-b219-6c40c527f570
Version Independent ID: 0b8f8f06-1669-5103-75fb-5544a72988b3
Content: Import data (preview) - Azure Machine Learning
Content Source: articles/machine-learning/how-to-import-data-assets.md
Service: machine-learning
Sub-service: mldata
GitHub Login: @AmarBadal
Microsoft Alias: ambadal

@SouravMalliK
Thanks for your feedback! We will investigate and update as appropriate.

Hi @SouravMalliK
To create a data asset of Tabular type which could store data retrieved from an Azure SQL Database Query used in a Datastore using Azure SDK V2, you can use the TabularDatasetFactory class from the azureml.core.dataset_factory module. Here is an example code snippet:
from azureml.core import Workspace, Dataset
from azureml.core.authentication import InteractiveLoginAuthentication
from azureml.data.dataset_factory import TabularDatasetFactory

# Authenticate with Azure
interactive_auth = InteractiveLoginAuthentication(tenant_id="<your-tenant-id>")
ws = Workspace(subscription_id="<your-subscription-id>",
               resource_group="<your-resource-group>",
               workspace_name="<your-workspace-name>",
               auth=interactive_auth)

# Define SQL query and datastore
sql_query = "SELECT * FROM <your-table-name>"
datastore_name = "<your-datastore-name>"

# Create TabularDatasetFactory object
tabular_dataset = TabularDatasetFactory.from_sql_query(
    datastore=ws.datastores[datastore_name],
    query=sql_query,
    validate=True
)

# Register the dataset
tabular_dataset.register(workspace=ws, name="<your-dataset-name>", create_new_version=True)

In this example, we first authenticate with Azure using the InteractiveLoginAuthentication class. Then, we define the SQL query and the name of the datastore where the data resides. We create a TabularDatasetFactory object using the from_sql_query method, passing in the datastore and the SQL query. Finally, we register the dataset with the workspace using the register method.
I hope this helps! If there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

Hi @Naveenommi-MSFT,
Thank you for the reply, but I was looking for something in SDK V2 (the feedback I created was on the SDK v2 documentation). I'm familiar with the snippet you shared, in-fact I already mentioned the same in my comment.
I'm consuming data from different data sources - like from flat files (mostly parquet) & Azure SQL Server and storing them as  Data assets in AML workspace using azure.ai.ml.entities.Data class.  I'm able to access these data as MLTables hence would like to stick to azure.ai.ml libraries for consuming data from Azure SQL server too.
I found a ARM template which creates a tabular dataset from SQL query.
{
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
"contentVersion": "<IP_ADDRESS>",
"resources": [
{
"type": "Microsoft.MachineLearningServices/workspaces/datasets",
"name": "[concat(parameters('workspaceName'), '/', parameters('datasetName'))]",
"apiVersion": "2020-05-01-preview",
"location": "[parameters('location')]",
"properties": {
"SkipValidation": "[parameters('skipValidation')]",
"DatasetType": "tabular",
"Parameters": {
	"Query": {
		"Query": "[parameters('sqlQuery')]",
		"DatastoreName": "[parameters('datastoreName')]"
	},
	"SourceType": "sql_query"
},
"Registration": {
	"Description": "[parameters('datasetDescription')]",
	"Tags": "[parameters('tags')]"
},
"TimeSeries": {
	"FineGrainTimestamp": "[parameters('fineGrainTimestamp')]",
	"CoarseGrainTimestamp": "[parameters('coarseGrainTimestamp')]"
}}]}

I'm looking for a similar option in Python SDK v2 which would help me to create a Dataset using SQL query and then consume the dataset using a MLTable, like this --
import mltable
from azure.ai.ml import MLClient
from azure.identity import DefaultAzureCredential

ml_client = MLClient.from_config(credential=DefaultAzureCredential())
data_asset = ml_client.data.get("dataset-name", version="1")

tbl = mltable.load(f'azureml:/{data_asset.id}')

df = tbl.to_pandas_dataframe()

@SouravMalliK
Thank you for bringing this to our attention.
I've delegated this to content author @AmarBadal, who will review it and offer their insightful opinions.


[Feature] Ability to pass styles to the rendered

I've run into an issue where I wanted to render this click handler using the styled-components library. Unfortunately, because neither className nor style are passed through to the  created by the handler, there isn't a lot that you can do in order to style this.
Is there any plan to add something like this? If not, I'll open a PR shortly with a potential addition.

Please see PR #9

This is not permitted by design - see https://brigade.engineering/don-t-pass-css-classes-between-components-e9f7ab192785
Duplicate of #2.

This is not permitted by design - see https://brigade.engineering/don-t-pass-css-classes-between-components-e9f7ab192785
Duplicate of #2.

For those who came here in 2024, and figured out that https://brigade.engineering domain is for sale:
https://medium.com/@JanPaul123/don-t-pass-css-classes-between-components-e9f7ab192785


authorization.k8s.io access review methods don't work

Reference: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.10/#subjectaccessreview-v1-authorization
The entity methods are generated from the the API discovery, but they don't work because these endpoints are weird: they're POST operations that require a JSON object to be passed, but do not operate on a named (or persistent) entity object and the URL only exists in the plural form (e.g. apis/authorization.k8s.io/v1/subjectaccessreviews).
I'm currently patching authorization.k8s.io client instances in my code as a workaround:
%w[self_subject_access_review subject_access_review self_subject_rules_review local_subject_access_review].each do |sar|
  authorization_client.define_singleton_method(sar.to_sym) do |review_hash|
    begin
      response = self.rest_client[sar.delete('_') + 's'].
        post({spec: review_hash}.to_json, self.headers.merge("Content-Type": 'application/json'))
      Kubeclient::Resource.new(JSON.parse(response.body))
    rescue RestClient::ExceptionWithResponse => e
      raise Kubeclient::HttpError.new(e.response.code, e.message, e.response)
    end
  end
end
# example
authorization_client.self_subject_rules_review(namespace: 'default')

Closing per https://github.com/abonas/kubeclient/issues/314#issuecomment-378556841 (the crucial trick was that POST == create_... in kubeclient).
Extracted looking at verbs idea to #330.


feat: --provider flag #139

Resolves #139

It's good to merge, but failing due to the generator traceInstall error (fixed, but not released yet as I see)


Numpy version, rever to 1.4

I believe the following addition would be needed in the setup file, regardless of version
+import numpy
 import os
 import sys
 import warnings
@@ -99,5 +100,6 @@ setup(
     ],
     install_requires=["cython", "numpy", "scipy"],
     #requires=["cython", "numpy", "scipy"],
+    include_dirs=[numpy.get_include()],
     **params
 )

I also had to revert to version 1.0.4, for python-hutrans to work with this.

It appears that it does
(venv) ✘-1 ~/proj/venv/python-hutrans [master|✚ 1…1]
17:20 $ pip list
DEPRECATION: The default format will switch to columns in the future. You
can use --format=(legacy|columns) (or define a format=(legacy|columns) in
your pip.conf under the [list] section) to disable this warning.
appnope (0.1.0)
backports-abc (0.5)
backports.functools-lru-cache (1.5)
backports.shutil-get-terminal-size (1.0.0)
bleach (2.1.3)
configparser (3.5.0)
cycler (0.10.0)
Cython (0.28.1)
decorator (4.2.1)
entrypoints (0.2.3)
enum34 (1.1.6)
functools32 (3.2.3.post2)
futures (3.2.0)
html5lib (1.0.1)
hutrans (1.0)
ipykernel (4.8.2)
ipython (5.6.0)
ipython-genutils (0.2.0)
ipywidgets (7.2.0)
Jinja2 (2.10)
jsonschema (2.6.0)
jupyter (1.0.0)
jupyter-client (5.2.3)
jupyter-console (5.2.0)
jupyter-core (4.4.0)
kiwisolver (1.0.1)
MarkupSafe (1.0)
matplotlib (2.2.2)
mistune (0.8.3)
mpmath (1.0.0)
nbconvert (5.3.1)
nbformat (4.4.0)
nose (1.3.7)
notebook (5.4.1)
numpy (1.14.2)
pandas (0.22.0)
pandocfilters (1.4.2)
pathlib2 (2.3.0)
pbr (4.0.2)
pexpect (4.4.0)
pickleshare (0.7.4)
pip (9.0.3)
prompt-toolkit (1.0.15)
ptyprocess (0.5.2)
Pygments (2.2.0)
pyparsing (2.2.0)
python-dateutil (2.7.2)
pytz (2018.4)
pyzmq (17.0.0)
qtconsole (4.3.1)
scandir (1.7)
scipy (1.0.1)
Send2Trash (1.5.0)
setuptools (39.0.1)
simplegeneric (0.8.1)
singledispatch (<IP_ADDRESS>)
six (1.11.0)
subprocess32 (3.2.7)
sympy (1.1.1)
terminado (0.8.1)
testpath (0.3.1)
tornado (5.0.2)
traitlets (4.3.2)
wcwidth (0.1.7)
webencodings (0.5.1)
wheel (0.31.0)
widgetsnbextension (3.2.0)
wxconv (1.2.3)
Perhaps it should be removed from the dependencies?
On Wed, Apr 11, 2018 at 11:17 PM, Irshad Ahmad<EMAIL_ADDRESS>wrote:

What is this issue about. indic-wx-converter has no numpy dpepndency.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ltrc/indic-wx-converter/issues/4#issuecomment-380691227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMAa_GB16CHRoszks4Jgj_zizSUcsYybks5tnvGGgaJpZM4TQ9vn
.

--
Gonzalo Diaz
Developer
512.621.2274

You are talking about python-hutrans and have raised an issue for indic-wx-converter repo.  python-hutrans and indic-wx-converter are two different repositories. If there is an issue with python-hutrans, you should raise an issue there, not in this repo. indic-wx-converter is completely independent of numpy and python-hutrans.

Closing the issue.


Multiple values and Implementation

On 01.08.2020, at 01:25, Koen Van Impe<EMAIL_ADDRESS>wrote:
@cudeso commented on this pull request.
In Documentation/howtogetstarted.md:

Check the latest version of the taxonomy, both in human readable format and in machine readable

Update the usage page if you use it
-4. Push changes if you see fit
+4. Push changes if you see fit or open an issue if you have questions or comments

+## Multiple values
Hi @aaronkaplan ... my PR was based on the mail from Rossella
All agree for the multiple values that 1st one is intent (time dependent) and the rest are the transport mechanisms. > All agree to update the doc accordingly before next meeting. Please edit this https://github.com/enisaeu/Reference-Security-Incident-Taxonomy-Task-Force/blob/master/Documentation/howtogetstarted.md
Happy to update the proposal though ...

No problem. I was just trying to recall what the summary was. So yeah.. cool! Thanks :)


[cPP Correction] Incomplete SSH authentication algorithm specification

Provide the location of the issue
Section <IP_ADDRESS>, Application Note 9
Section B.4.1.2, Application Note 112
Possibly others
What is the correction request for the cPP? Please describe.
The cPP explicitly lists SSH host/public key algorithms; however, as of the SSH_PKG_v1.0, the list is out dated (and likely to be difficult to keep in sync). The SSH_PKG_v1.0 includes rsa-sha2-256 and rsa-sha2-512, which do not use X.509 certificates.
Describe the solution you'd like
Change these to something more generic like (based on Application Note 9): “When key generation is used for device authentication, other than non-X.509 SSH authentication algorithm, the public key is expected to be associated with an X.509v3 certificate.

Recommendations...
In application note 9…
Change from: "When key generation is used for device authentication, other than ssh-rsa (RFC 4253), ecdsa-sha2-nistp256 (RFC 5656), ecdsa-sha2-nistp384 (RFC 5656) and ecdsa-sha2-nistp521 (RFC 5656), the public key is expected to be associated with an X.509v3 certificate."
Change to: "When key generation is used for device authentication, other than non-X.509 SSH authentication algorithm, the public key is expected to be associated with an X.509v3 certificate."
In application note 112...
Change from: "The ST author must include FIA_X509_EXT.2 in all instances except when only SSH is selected within FTP_ITC.1 or FPT_ITT.1 and ssh-rsa, ecdsa-sha2-nistp256, ecdsa-sha2-nistp384, and/or ecdsa-sha2-nistp521 authentication is also selected. Additionally, FIA_X509_EXT.2 must also be included if FPT_TUD_EXT.2 is included in the ST."
Change to: "The ST author must include FIA_X509_EXT.2 in all instances except when only SSH is selected (e.g. within FTP_ITC.1, FPT_ITT.1, or FTP_TRP.1/Admin) and only non-X.509 SSH authentication algorithms are used for SSH. Additionally, FIA_X509_EXT.2 must also be included if FPT_TUD_EXT.2 is included in the ST."

Either recommendation addresses the issue.
I have a slight preference for @KSinitski's suggestion. I think it makes the PP cleaner if we remove things that we can't define a clear reason for including.
@dundiddat's recommendation is safer. I don't think there is a reason SSH and X.509 need to be mentioned in this Application Note, but it appears this text has been in the PP for a while.

I accept @dundiddat's suggestion for Application Notes 9 and 112. It's safer than removing the SSH and X.509 references in Note 9.


Fix on non clickable parent due to icon

Summary of proposed changes
When I set a custom iconUrl then the "Settings" button becomes non clickable if clicked on top of the icon. This does not happen when the default iconUrl (https://cdn.plyr.io/2.0.10/plyr.svg) is set. I had to set a "pointer-events: none;" on less and sass in order for the event to properly work.
Task list

[x] Tested on supported browsers
[x] Gulp build completed

Manually merged to develop


PushResponse does not return the message ID

Per the Expo notifications docs, the message id allows more granular debugging of notifications and notification states. It would be very easy to add the message id to the return of PushResponse. Two changes are needed:
line 136:  'push_message', 'status', 'message', 'details', 'id'])):

and
line 296: id=receipt.get('id', '')))

Here is the corresponding PR: https://github.com/expo/expo-server-sdk-python/pulls

This is handled in #31


Custom Application subclass singletons not scanned

I originally posted a question on the Google Group and was directed here.
I am creating bundles for an OSGi platform. One of the bundles contains some REST endpoints, using JAX-RS and CXF. I am using Swagger 1.3.12 with Scala 2.10. I am not using any .xml for configuration, but instead am using beanConfig and a custom Application subclass. The issue comes from my endpoints needing to be added to the custom Application subclass as singletons, instead of classes.
Here is my startup method for the REST Endpoint component.
public void startup() throws Exception
    {
        patientEndpoint = new PatientEndpointImpl(patientDataProvider, encounterDataProvider);
        encounterEndpoint = new EncounterEndpointImpl(encounterDataProvider);

        ObjectMapper mapper = new ObjectMapper();
        mapper.getSerializationConfig().setDateFormat(new SimpleDateFormat("MM/dd/yyyy"));
        JAXRSApplication app = new JAXRSApplication();

        app.addClass(ApiListingResource.class);
        app.addClass(ApiDeclarationProvider.class);
        app.addClass(ApiListingResourceJSON.class);
        app.addClass(ResourceListingProvider.class);
        //app.addClass(PatientEndpoint.class);
        //app.addClass(EncounterEndpoint.class);
        app.addSingletons(patientEndpoint, encounterEndpoint);
        app.addSingleton(new JacksonJsonProvider(mapper));
        app.addSingleton(new AccessControlResponseFilter(true));
        service.registerApplication(ALIAS, app);

        BeanConfig beanConfig = new BeanConfig();
        beanConfig.setVersion("0.0.1");
        beanConfig.setBasePath(ALIAS);
        beanConfig.setResourcePackage("com.lexmark.healthcare.lhcdb.endpoint.rs");
        beanConfig.setDescription("Healthcare Database resources");
        beanConfig.setTitle("Healthcare Database REST API");
        beanConfig.setScan(true);

        ScannerFactory.setScanner(new DefaultJaxrsScanner());
        //ScannerFactory.setScanner(new ReflectiveJaxrsScanner());
        ClassReaders.setReader(new DefaultJaxrsApiReader());

        logger.info("PatientLookup has successfully started");
    }

JAXRSApplication is the custom Application subclass.
This is the configuration that I would expect to work. Unfortunately, when I add my patientEndpoint and encounterEndpoint to the JAXRSApplication as singletons, my resources do not seem to be scanned. The resulting JSON that I get from my api-docs endpoint does not contain my APIs.
However, if I un-comment out the lines:
        app.addClass(PatientEndpoint.class);
        app.addClass(EncounterEndpoint.class);

and comment out the line app.addSingletons(patientEndpoint, encounterEndpoint);
then my api-docs endpoint will contain my APIs. But my endpoints are then broken, because they need to be initialized with a provided service.
Also of note, my endpoints contain an interface (e.g. PatientEndpoint) and an implementation class (e.g. PatientEndpointImpl). My interface contains the Swagger Annotations.
The REST component class is kept in the package ending in endpoint.rs', the interfaces are in endpoint.rs.apiand the implementations are inendpoint.rs.impl`.
The DefaultJaxrsScanner class looks like it should be grabbing the list of singletons fro the Application subclass, and getting the respective classes, but it doesn't seem to be working for me.
Are singletons supported currently?
Thanks for any help you may be able to provide.

Just curious, what does the P2 tag mean?

Means we're looking into the issue but if it can't be addressed for the release, it can be bumped to the next one

@cprokopiak - did you ever test it with the 1.5 version?

Please reopen if still an issue.

@webron - I am currently trying to test it with the 1.5 release. However, I have been unable to get swagger to actually scan my resources, either using Singletons or Classes.
Below is how I am currently trying to test my configuration and initialization.
                application = new JAXRSApplication();

		application.addSingleton(enterprisePatientEndpoint);

		application.addSingleton(new JacksonJsonProvider());
		if (corsFilter != null) {
			application.addSingleton(corsFilter);
		}
		application.addSingleton(authentication);

		application.addClass(ApiListingResource.class);
		application.addClass(SwaggerSerializers.class);

		service.registerApplication(ALIAS, application);

		BeanConfig beanConfig = new BeanConfig();
		beanConfig.setVersion("0.0.1");
		beanConfig.setSchemes(new String[]{"http"});
		beanConfig.setHost("localhost:80");
		beanConfig.setBasePath("/rs" + ALIAS);
		beanConfig.setDescription("Healthcare Database Resources");
		beanConfig.setTitle("Healthcare Database REST API");
		beanConfig.setResourcePackage("phcdb.endpoint.rs");
		beanConfig.setScan(true);
		beanConfig.setPrettyPrint(true);

		logger.info("REST endpoints registered successfully");

This generates the following in my swagger.json file:
{
  "swagger" : "2.0",
  "info" : {
    "description" : "Healthcare Database Resources",
    "version" : "0.0.1",
    "title" : "Healthcare Database REST API"
  },
  "host" : "localhost:80",
  "basePath" : "/rs/phcdb",
  "schemes" : [ "http" ]
}

One thing I am unclear on so far, do I need to specify a scanner or reader like I had back in the 1.3.x version? I had tried setting the scanner to DefaultJaxrsScanner, but that seemed to conflict with my BeanConfig, resulting in a swagger.json that looked like this:
{ "swagger" : "2.0" }

I've turned up the logging to the highest level in the platform, as well as tried to set a logback.xml file just for io.swagger, but I haven't seen any debug logging from swagger itself. I'm not sure if I don't have something configured properly for logging, or if nothing in swagger that has log statements is actually running.

Do you use CXF or Restlet? Can't find reference to JAXRSApplication anywhere but in Restlet.

I am using CXF as part of an in-house framework. The framework provides JAXRSApplication:
public class JAXRSApplication extends Application {
    private final Set<Class<?>> classes = new HashSet<Class<?>>();
    private final Set<Object> singletons = new HashSet<Object>();

    public JAXRSApplication() {
    }

    @Override
    public Set<Class<?>> getClasses() {
        return classes;
    }

    @Override
    public Set<Object> getSingletons() {
        return singletons;
    }

    public void addClass(Class<?> clazz) {
        classes.add(clazz);
    }

    public void addClasses(Class<?>... types) {
        addClasses(Arrays.asList(types));
    }

    public void addClasses(Collection<Class<?>> types) {
        for (Class<?> clazz : types) {
            addClass(clazz);
        }
    }

    public void addSingleton(Object singleton) {
        singletons.add(singleton);
    }

    public void addSingletons(Object... objects) {
        addSingletons(Arrays.asList(objects));
    }

    public void addSingletons(Collection<Object> objects) {
        for (Object obj : objects) {
            addSingleton(obj);
        }
    }
}

To be sure, you're using 1.5.0 (with the io.swagger package), right?
Looking at the original post and the new one, it looks like you're mentioning two different packages. Are your resources find directly under the phcdb.endpoint.rs package (it's a bit of an odd, yet valid, package name)?

Yes, I am now testing with the io.swagger 1.5.0 packages.
We are currently in the process of renaming some of our packages.
Under phcdb.endpoint.rs is the file containing the configuration and initialization of my JAXRSApplication. phcdb.endpoint.rs.api contains the interfaces for the API, and this is where I've applied my swagger annotations. phcdb.endpoint.rs.impl contains the implementations of the API.
I've tried setting the setResourcePackage option to all three packages mentioned, but it didn't seem to make a difference. Which package should I be setting for the resources?

The original question mentioned that this seems to be an issue when adding the singletons to the Application class. After migrating to the latest version of swagger-core, is this still the case? That is, if you comment the addition of the singletons, do you get the proper output or does the problem persist?

With the latest version, I have not been able to get the proper output using either singletons or classes.

Okay, this is odd. The next steps I can think of is trying to turn up the logging (of swagger-core) or trying to create a small test case project to reproduce it so we can further investigate. I realize this may be difficult since you have your internal set up.
By the way, which version of CXF do you use?

The framework is using CXF 2.7.4.
How do I go about turning up the logging for swagger-core? Using a logback.xml file with a setting for io.swagger?
It will be a week or two before I can get to try and create a small test case, if I can at all. With this running on an in-house framework, it may be difficult to generate a test case that I can provide.

I realize this is not necessarily simple for production code, but can you try upgrading to CXF 2.7.15 and run it?

@cprokopiak - any update?

@webron Sorry, no updates yet. Haven't had a chance to come back to the issue. Hopefully later this week work will slow down a bit and give me an opportunity.

Closing due to inactivity


Get clusters creates a control plane and also returns wrong error

This is a two part bug report.
Part 1
When you run get clusters with an existing control plane but where a cluster doesn't exist, you get a confusing error back in that it reports that a Control plane isn't found when in fact it's the cluster that's missing:
For example, the image-build control plane does exist but the cluster doesn't.
eckctl get cluster --name eck-240108-c5bfe4d7-testing --controlplane image-build

2024/01/08 12:06:21 Error getting clusters: Control plane not found, 404

Part 2
Another issue with this is if you provide a control plane that actually doesn't exist, it just goes and creates it anyway! (This could be a unikorn bug and not eckctl fwiw)
In this example, the some-random-name control plane doesn't exist but it just errors out and then creates it anyway.
eckctl get cluster --name eck-240108-c5bfe4d7-testing --controlplane some-random-name
2024/01/08 12:13:33 Error getting clusters: Control plane not found, 404

Part 2: This is actually unikorn-server, whenever a control plane is implictly referenced, it will bring it to life in order to facilitate the (presumed) creation of a cluster.  To do otherwise would mean propagating intent all over the place and cause complexity/bugs.


Glv

I think this should be ready to merge now.
This implements gadgets for GLV, windowed scalar multiplication and fixed base multiplication. These methods are combined in the ECDSA verification circuit.


Looking for the il8n folder in src??

First install of this.
I placed the il8n folder in the app folder, and added my en.default.js file.
When: tns run android
Get: 'c:\demo4\src\i18n' doesn't exists: nothing to localize.
What am I missing?
On Nativescript 6.0 and Angular 8

Helps if I name the folder correctly.
i18n not il8n
I'll leave this here for posterity sake, and to hopefully help someone else.


Update or add link to our Spectrum Forum

🚀 Feature
Is your feature request related to a problem? Please describe.
Point to our spectrum forum
Describe the solution you'd like
Update existing links (that are pointing to our GitHub repo) to point to our Spectrum Forum. Add links where it fits.

Closed: Implemented in the PR #348


Revert "feat(icon): add test harness (#20072)"

This reverts commit 092b1515f3843a043884ee09b459c55ec3166213.
This change adds an import to icon-harness-filters.ts which breaks
the internal target which uses this file because it does not have
cdk/testing in it's deps.

Which import is this referring to? All imports to icon-harness-filters.ts are inside the icon/testing entry point itself.

It sounds like the internal test target just would need to be updated to include cdk/testing in the deps for icon/testing.

Yep, so this change needs to be added like a regular PR so it can be submitted by itself and fixed as part of the same submission. It can't be grouped in with the merge safe PRs or this error will show up for each PR we try to merge after it until the fix is made

@andrewseguin Is there another way to do this where we wouldn't have to revert this PR?

Change of plans, I'll leave this as is and patch a fix for each of the presubmits :+1:


Fix help text when there are no password validators

This avoids having an empty list which is invalid HTML 4.
http://www.w3.org/TR/html4/struct/lists.html#h-10.2

Could you add a regression test?

@timgraham sure. Here you go.

buildbot, add to whitelist.

merged in 53ccffdb8c8e47a4d4304df453d8c79a9be295ab, thanks!