Compatibility matrix for provider-family-aws with provider-aws-*

Hello team,
Is there any prescribed compatibility matrix for determining the compatibility between the provider-family-aws with other aws providers such as provider-aws-s3 and provider-aws-dynamodb?
For example, how do we evaluate if the following installations of providers is valid and work fine?
NAME                          INSTALLED   HEALTHY   PACKAGE                                                 AGE
upbound-provider-family-aws   True        True      xpkg.upbound.io/upbound/provider-family-aws:v0.37.0     72m
provider-aws-dynamodb         True        True      xpkg.upbound.io/upbound/provider-aws-dynamodb:v0.37.0   72m
provider-aws-s3               True        True      xpkg.upbound.io/upbound/provider-aws-s3:v0.43.0         72m

This would help the community to determine the upgrade path for each of these providers.

Hey, Any luck figuring this out,

@devops-inthe-east while you should be able to rely on semver versioning where all minor/patch releases are compatible with each other, our recommendation is to keep your versions in sync as a good practice to adhere to.

@jeanduplessis Unfortunately, it is not that easy to keep the versions aligned unless you manually install the family provider. And if you do this in a cluster with the providers already installed, a bug prevents a clean cluster, at least as far as I know.

I found a way to align the versions of the various AWS family providers.
The instructions are split between two threads:

https://github.com/crossplane-contrib/provider-upjet-aws/issues/1088
https://github.com/crossplane-contrib/provider-upjet-aws/issues/1452

To understand what Upbound recommends from a compatibility pov and what we support our customers on see this section in our docs: https://docs.upbound.io/providers/policies/#compatibility


Decorators

I'm submitting a ...

[x] feature request

Decorators.

Resolved in https://github.com/RommelTJ/LearningTypeScript/pull/23


Flash of unstyled content

I’ve found that when the React tree is rendered there is a flash of unstyled content with just the React HTML and without the glamor styles. Is there a suggestion on how to fix this?
Great library by the way! I think this approach makes use of the best of all other CSS-in-JS approaches.

Thanks, very nice of you to say!
It shouldn't do the flash... do you have a sample to reproduce this?

I seem to have lost the speedy toggle in the refactor. I'll get that back in; it'll speed up rule insertion a lot and should make this less of an issue. Another ugly workaround is to compile with NODE_ENV=production to trigger speedy.
Lemme know if you have a sample though, cheers.

Yep, I can confirm that when NODE_ENV=production there is no flash :+1:. Unfortunately though I don’t have enough time to put together a sample 😖. Especially since there’s no development build I could import into a codepen.
Thanks though, it seems like you know what’s going on :+1:

The next release will bring back the speedy flag. I'll bring a dev build for npmcdn too. Will close this once that's done. Thanks for the feedback, and do let me know if the issue pops up again.

do you have any feedback you'd like to share? anything I could make better? what is your usecase? please and thanks :)

Thanks for asking, I always have opinions 😊
So I really like the approach. I remember when I first heard about this library it was in Twitter code screenshots that had been retweeted a couple of times and I was intrigued, then when I actually wanted to learn more about the library, I couldn't find it 😖, luckily I dogged through my Twitter feed and arrived here.
Recently I started building a React project with aphrodite and I was running into some limitations. When I hovered over a button element I wanted to change the color of a child icon. Simple, right? In aphrodite, not so much. It was still early in the project and partly inspired by @ryanflorence's recent video on actual inline styles I switched the code base to glamor to take advantage of the select function. I was also using style-loader/css-loader, in the future I now want to replace them with insertRule from glamor. So the reasons I enjoy the switch are as follows:

No class names. I think this is an undersold benefit of this approach, I'd definitely recommend throwing that benefit in the README. "Forget about naming styles!". Not having to give every div a name is awesome! And it takes so long to write className…
Closeness to CSS. This one is definitely glamor specific. There's definitely a big move to try and make style interfaces common across all platforms. This approach intentionally shortcuts some of the power of CSS. I might be in the minority, but I still believe CSS has a very elegant design although I would never use it directly in a large app. So the escape hatches are critical.
The code just looks good. It really does 😊. Note I'm using the {...style()} syntax, I think the other styles just aren't as good. I've also barely looked at the tools outside of index.js, so I haven't touched react.js.
All the reasons @ryanflorence gave for liking inline styles, he was right…(although I think the jsxstyle approach leaves much to be desired. It's much harder to build in the CSS escape hatches, or to write semantic HTML).

I haven't been using it for long (about a week now) so I can't comment on any severe architectural limitations, but there are some gotchas I've found. Specificity issues with pseudo-classes is one. So :active must always be more specific then :hover and so they must be ordered appropriately in the style sheet. Also there was some wierdness with auto-prefixing when I tried writing something like: top: ['50%', 'calc(50% - 10px)'] (because I wanted a fallback for browsers that didn't support calc. It's nothing an !important won't fix though.
One thing a will note which probably should be warned about is animations. I haven't tested this, but I assume if you want 60fps you shouldn't be updating your style object super frequently, correct? At that point I tend to fallback to the native style attribute. As a side not I'm using @chenglou's react-motion.
I also want to say, bravo on the implementation! It's really pretty neat how the software works. I saw you had a TODO item for static optimizations, it would be sweet to see a Babel transform or something 😊

Now it's your turn, why did you make this framework, what use cases of yours does it solve, what's your vision for its future?

This is greeeeeat feedback, thank you much!

the :active / :hover issue; this is something glamor should be able to help with (and perhaps automatically fix?), opened #36 for the same
can you give me a small input/expected/actual testcase for the fallback value problem? I want fallbacks to work in glamor, maybe I got my implementation wrong :|
and yes, you don't want to use this for animations. I did some earlier work to see if it's possible, but came to the same conclusion as you; directly targeting style prop makes more sense/is faster/better. glamor for the rest!

I recommend you try out the /react shim. specifically the css prop via the createElement patch is a lot of fun/ saves typing.

it accepts raw styles, so this is valid :

it accepts arrays, so this is valid

So I've recently started building my own thing, and wasn't happy with 1-2 things with every library. aphrodite came closest, but the lack of escape hatches/ async behavior made it hard to use. really wanted a library with no compromises, so I went ahead and built it :) That's all really, no crazy grand vision.
It's pretty close to "feature complete", I plan on getting some enhancements in and then polishing it as time goes on. Happy to hear ideas :)

@calebmer @threepointone OMG I wish we were seeing more dialogs like this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/threepointone/glamor/issues/33#event-825111227, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGHaPED2HWPmdtkH5CnQrTJIO8lavXIks5q0iyhgaJpZM4JuzTV
.


[WIP] fix(#5658): handle edge cases for tag filtering detection

What this PR does / why we need it:

This PR makes detecting if tags filtering is enabled more robust. If the admin API is unreachable, the controller will fail fast rather then disabling tags (which can have undesired consequences, e.g removing objects not managed by the controller).
Which issue this PR fixes:

fixes #5658
Special notes for your reviewer:

I'm not sure how to add e2e tests for this change since it requires simulating a connection failure during initialization both when the admin api supports tags and does not.
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I think we can probably do this simpler by just removing the tag support check altogether.
The original introduction of that check is quite old, from an era where there were (maybe? even that long ago I don't think we really supported anything prior to gateway 1.0) gateway versions without tag support in the wild.
3.x releases of KIC cut off support for all gateway releases prior to 3.4, so everything we currently support in the controller supports tags. I'll double check to see if there's any other reason to keep this, but I suspect we can just discard it and always enable tag filtering.

Thanks for looking into it @rainest 🙏 , whilst you double check if the tag check can be completely removed, I'll deploy this test build in our cluster to see if the issue with consumers getting deleted.

Small update, the patch deployment made the issue disappear from the Kong Ingress Controller in our Kubernetes cluster. I've also taken the liberty to remove code related to checking tags as you suggested


[BUG] YAML oneOf with reference failing with keyerror excepton

Checklist
Yes
Describe the bug
open API with one of reference unable to parse failed with Keyeroor, I have pasted a concise version of how they key located in the below
test:
    properties:
        content:
            oneof:
                - ref: "#/test1contents"
                - ref: "#/test2contents"
test1Contents:
    type: object
    ..

test2Contents:
    type: object

To Reproduce
Steps to reproduce the behavior:

Run this command '...'
See an error

If possible, please post a minimal version of your API schema that cause this behaviour:
schemathesis  run --checks all --store-network-log test.log --code-sample-style=python --workers 2 --base-url https://<IP_ADDRESS>:5443/api/v1/ ./bip.yaml
Warning: Option `--store-network-log` is deprecated and will be removed in Schemathesis 4.0. Use `--cassette-path` instead.
=========================================================================== Schemathesis test session starts ===========================================================================
platform Linux -- Python 3.8.10, schemathesis-3.14.2, hypothesis-6.45.0, hypothesis_jsonschema-0.22.0, jsonschema-4.4.0
rootdir: /home/kosuri/gitswarm/bip/core/openapi
Hypothesis: deadline=timedelta(milliseconds=15000), database=DirectoryBasedExampleDatabase('/home/kosuri/gitswarm/bip/core/openapi/.hypothesis/examples')
Schema location: file:///home/kosuri/gitswarm/bip/core/openapi/mbip.yaml
Base URL: https://<IP_ADDRESS>:5443/api/v1
Specification version: Open API 3.0.2
Workers: 2
Collected API operations: 191

Expected behavior
Testscases should execute
Environment (please complete the following information):

OS: Ubuntu 20 LTS
Python version: 3.8
Schemathesis version: 3.14.2
Spec version: 3.0.2

Additional context
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
Exception in thread schemathesis_1:
Traceback (most recent call last):
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 870, in resolve_fragment
    self.run()
  File "/usr/lib/python3.8/threading.py", line 870, in run
    document = document[part]
KeyError: 'keyCertificatePEMContents'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/runner/impl/threadpool.py", line 109, in thread_task
    self.run()
  File "/usr/lib/python3.8/threading.py", line 870, in run
    _run_task(
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/runner/impl/threadpool.py", line 68, in _run_task
    self._target(*self._args, **self._kwargs)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/runner/impl/threadpool.py", line 109, in thread_task
    test_function = create_test(
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 57, in create_test
    _run_task(
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/runner/impl/threadpool.py", line 68, in _run_task
    test_function = create_test(
    wrapped_test = add_examples(wrapped_test, operation, hook_dispatcher=hook_dispatcher)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 57, in create_test
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 83, in add_examples
    examples: List[Case] = [get_single_example(strategy) for strategy in operation.get_strategies_from_examples()]
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 83, in <listcomp>
    wrapped_test = add_examples(wrapped_test, operation, hook_dispatcher=hook_dispatcher)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 83, in add_examples
    examples: List[Case] = [get_single_example(strategy) for strategy in operation.get_strategies_from_examples()]
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 118, in get_single_example
    examples: List[Case] = [get_single_example(strategy) for strategy in operation.get_strategies_from_examples()]
    example_generating_inner_function()
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 83, in <listcomp>
    examples: List[Case] = [get_single_example(strategy) for strategy in operation.get_strategies_from_examples()]
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 118, in get_single_example
    example_generating_inner_function()
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 106, in example_generating_inner_function
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/_hypothesis.py", line 106, in example_generating_inner_function
    @hypothesis.settings(  # type: ignore
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/core.py", line 1239, in wrapped_test
    @hypothesis.settings(  # type: ignore
    raise the_error_hypothesis_found
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/core.py", line 1239, in wrapped_test
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/specs/openapi/_hypothesis.py", line 149, in get_case_strategy
    raise the_error_hypothesis_found
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/specs/openapi/_hypothesis.py", line 149, in get_case_strategy
    body = draw(strategy)
    body = draw(strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/lazy.py", line 156, in do_draw
    return data.draw(self.wrapped_strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/core.py", line 794, in do_draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/lazy.py", line 156, in do_draw
    return self.target(
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_from_schema.py", line 104, in error_raiser
    raise error
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/core.py", line 722, in _execute_once_for_engine
    return data.draw(self.wrapped_strategy)
    result = self.execute_once(data)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/core.py", line 661, in execute_once
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/core.py", line 794, in do_draw
    result = self.test_runner(data, run)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/executors.py", line 47, in default_new_style_executor
    return self.target(
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_from_schema.py", line 104, in error_raiser
    return function(data)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/core.py", line 619, in run
    raise error
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/core.py", line 722, in _execute_once_for_engine
    args, kwargs = data.draw(self.search_strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 878, in draw
    result = self.execute_once(data)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/core.py", line 661, in execute_once
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/collections.py", line 58, in do_draw
    return tuple(data.draw(e) for e in self.element_strategies)
    result = self.test_runner(data, run)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/collections.py", line 58, in <genexpr>
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/executors.py", line 47, in default_new_style_executor
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return function(data)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/core.py", line 619, in run
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/strategies.py", line 823, in do_draw
    args, kwargs = data.draw(self.search_strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 878, in draw
    result = self.pack(data.draw(self.mapped_strategy))
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/collections.py", line 58, in do_draw
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/lazy.py", line 156, in do_draw
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/collections.py", line 58, in <genexpr>
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return data.draw(self.wrapped_strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/strategies.py", line 823, in do_draw
    return strategy.do_draw(self)
    result = self.pack(data.draw(self.mapped_strategy))
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/strategies.py", line 823, in do_draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/lazy.py", line 156, in do_draw
    result = self.pack(data.draw(self.mapped_strategy))
    return data.draw(self.wrapped_strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/collections.py", line 58, in do_draw
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/collections.py", line 58, in <genexpr>
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/strategies.py", line 823, in do_draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/strategies.py", line 823, in do_draw
    result = self.pack(data.draw(self.mapped_strategy))
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    result = self.pack(data.draw(self.mapped_strategy))
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/lazy.py", line 156, in do_draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/collections.py", line 58, in do_draw
    return data.draw(self.wrapped_strategy)
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/collections.py", line 58, in <genexpr>
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return tuple(data.draw(e) for e in self.element_strategies)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/core.py", line 1450, in do_draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/strategies.py", line 823, in do_draw
    return self.definition(data.draw, *self.args, **self.kwargs)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/specs/openapi/_hypothesis.py", line 149, in get_case_strategy
    result = self.pack(data.draw(self.mapped_strategy))
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    body = draw(strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/lazy.py", line 156, in do_draw
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/lazy.py", line 156, in do_draw
    return data.draw(self.wrapped_strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return data.draw(self.wrapped_strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return strategy.do_draw(self)
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/core.py", line 1450, in do_draw
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/core.py", line 794, in do_draw
    return self.target(
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_from_schema.py", line 104, in error_raiser
    return self.definition(data.draw, *self.args, **self.kwargs)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/schemathesis/specs/openapi/_hypothesis.py", line 149, in get_case_strategy
    raise error
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_from_schema.py", line 99, in from_schema
    body = draw(strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    return __from_schema(schema, custom_formats=custom_formats)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_from_schema.py", line 135, in __from_schema
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/lazy.py", line 156, in do_draw
    schema = resolve_all_refs(schema)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 73, in resolve_all_refs
    return data.draw(self.wrapped_strategy)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/internal/conjecture/data.py", line 874, in draw
    schema[key] = [
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 74, in <listcomp>
    return strategy.do_draw(self)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis/strategies/_internal/core.py", line 794, in do_draw
    resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    return self.target(
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_from_schema.py", line 104, in error_raiser
    raise error
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_from_schema.py", line 99, in from_schema
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    return __from_schema(schema, custom_formats=custom_formats)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_from_schema.py", line 135, in __from_schema
    schema = resolve_all_refs(schema)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 73, in resolve_all_refs
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    schema[key] = [
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 74, in <listcomp>
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 73, in resolve_all_refs
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    schema[key] = [
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 74, in <listcomp>
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 73, in resolve_all_refs
    resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    schema[key] = [
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 74, in <listcomp>
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 78, in resolve_all_refs
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    schema[key] = resolve_all_refs(val, resolver=resolver)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 78, in resolve_all_refs
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    schema[key] = resolve_all_refs(val, resolver=resolver)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 85, in resolve_all_refs
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
    schema[key] = {
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 73, in resolve_all_refs
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 86, in <dictcomp>
    k: resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 73, in resolve_all_refs
    schema[key] = [
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 74, in <listcomp>
    schema[key] = [
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 74, in <listcomp>
    resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 61, in resolve_all_refs
    resolve_all_refs(v, resolver=resolver) if isinstance(v, dict) else v
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/hypothesis_jsonschema/_resolve.py", line 61, in resolve_all_refs
    with resolver.resolving(ref) as got:
  File "/usr/lib/python3.8/contextlib.py", line 113, in __enter__
    with resolver.resolving(ref) as got:
  File "/usr/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 760, in resolving
    return next(self.gen)
    url, resolved = self.resolve(ref)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 805, in resolve
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 760, in resolving
    return url, self._remote_cache(url)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 820, in resolve_from_url
    return self.resolve_fragment(document, fragment)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 872, in resolve_fragment
    raise exceptions.RefResolutionError(
    url, resolved = self.resolve(ref)
jsonschema.exceptions.RefResolutionError: Unresolvable JSON pointer: 'keyCertificatePEMContents'
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 805, in resolve
    return url, self._remote_cache(url)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 820, in resolve_from_url
    return self.resolve_fragment(document, fragment)
  File "/home/kosuri/gitswarm/api-venv/lib/python3.8/site-packages/jsonschema/validators.py", line 872, in resolve_fragment
    raise exceptions.RefResolutionError(
jsonschema.exceptions.RefResolutionError: Unresolvable JSON pointer: 'keyCertificatePEMContents'

The error in the output states:
jsonschema.exceptions.RefResolutionError: Unresolvable JSON pointer: 'keyCertificatePEMContents'

But, your example doesn't correspond to the output as it has no such a pointer at all.  Otherwise, it looks like the error is in the schema as the resolver can't resolve that reference.
However, the current Schemathesis output is not much helpful in this regard :(

Thanks @Stranger6667, give me some time, I will come back

From my assessment, it looks like the issue is with the input schema. We can improve error reporting for missing references, so the problem is clear from the output.


Shiori 1.5.3

Description of changes
https://github.com/go-shiori/shiori/releases/tag/v1.5.3
As said in the last commit message, Shiori segfaults when name resolution is not available, so I had to change the test, and I'll report the issue. Since it should be a rare case, I think it's fine to go ahead with the update.
Migrations are also now a thing, so they are run automatically.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test shiori

Rebased and changed so that it just includes the test fix.


Post-tutorial: Clean up docs

There are a few places where the docs have become too tutorial-specific.

In the intro, we have them test mrxl in addition to the core tests.
Also in the intro, we ask them to catch our attention in case the tests fail.
The MrXL one-pager could use a little love to catch up to the improvements we've made in MrXL. These changes have been documented in tutorial/frontend_tut.md, but not in frontends/mrxl.md.

Let's clean the docs up after the tutorial is done.

#1571 changed the tag in intro.md to be tutorial-specific. Change it back to latest


Move thumbnails from 'links' to 'assets'

There was discussion at the ft. collins sprint on moving thumbnails to be an 'asset' instead of a 'link'. It feels more like an asset - it can be downloaded and used, and as participants remembered it was just in links because that's where it started.
So it should move to the 'assets' field.

[x] Update the spec fields and narrative in json-spec/
[x] Update the JSON Schema #57
[x] Update the OpenAPI doc #55
[x] Update examples + samples (in openapi doc, json-spec and static examples)

#75 updated the samples, so I believe this should be all up to date in dev.


Authentication issues in ASP.NET 5 projects

Hi guys,
We have hosted the NuGetGallery V2 with basic authentication in a public feed. Our authentication however does not work in ASP.NET 5 projects. It seems that we receive some requests with UserAgent "Microsoft_.NET_Development_Utility/1.0.0-rc1-16202(Windows6.3)" without Authorization header even though we response with WWW-Authenticate header. Is this a known issue?
Regards,
Veselin Ivanov
Telerik Team

This issue was moved to NuGet/Home#2194


Welcome tab changes font size

Describe the bug
If I close the last tab, then the welcome tab has a huge font-size:

Steps to reproduce

Open a new tab
Close it
Observe huge font-size in welcome tab

Expected behavior
Font size stays consistent.
Environment

OS: Linux
Camunda Modeler Version: v5.28.0
Execution Platform: any
Installed plug-ins: none

Additional context
No response

Potentially related to https://github.com/camunda/camunda-modeler/issues/4550.

Closed by https://github.com/camunda/camunda-modeler/pull/4599


New Error to update books into Gitbook Website

I encounter a error today,which says
Error:Cannot call method 'apply' of undefined
when I use the button Publish As
How solve this problem?
Thank you!
PS:
Is this editor dead?
Can someone succeed the role of maintaining it? Because this is really useful especially when you dislike to write a lot in your web browser.

We are working on fixing this error. A fix will be live soon.
This editor is no longer supported but we are working on a new editor, you'll be notified to update in your current editor, in the mid-time you can still use this editor.

It should be fixed now :)

Thank you!This is wonderful!


Add external_config parameter to bigquery_create_table

Summary
Adds external_config keyword argument to bigquery_create_table task so users can provide a google.cloud.bigquery.ExternalConfig for creating a BigQuery External Table.
Relevant Issue(s)
Closes #52
Checklist

[x] Summarized PR's changes in CHANGELOG.md

Running pre-commit install and pre-commit run --all` should fix static analysis.
For tests, running pytest shows you the errors; primarily it's caused by the schema kwarg re-ordered in the test_bigquery_create_table so I think all you need to do is re-order it or explicitly set keys, e.g. schema=schema

    def test_bigquery_create_table(gcp_credentials):
        @flow
        def test_flow():
            schema = [
                SchemaField("number", field_type="INTEGER", mode="REQUIRED"),
                SchemaField("text", field_type="STRING", mode="REQUIRED"),
                SchemaField("bool", field_type="BOOLEAN"),
            ]
            table = bigquery_create_table(
                "dataset",
                "table",
                schema,
                gcp_credentials,
                clustering_fields=["text"],
            )
            return table

>       assert test_flow() == "table"

Had to disable some pip.conf stuff I had set up for work to make the pre-commit environment happy, but it should be good this time. Sorry again 😭

Just one more suggestion! No need to be sorry; I really appreciate your contribution!!

Thanks so much for your patience and guidance! Excited to start using this soon.


NPE on Android 6.0+

In Android 6.0+ the foreground drawable is set when the view is instantiated (see lines 4278-4282). The ForegroundDelegate is null here, causing a NullPointerException to be thrown when the view is inflated.

Thanks for finding and fixing this! 2.0.3 has the fix

Your welcome. A better approach might be to call the super methods on Android 6.0+.

Thanks for the suggestion, I went ahead and updated 2.1.0 to work this way :smile:


Exclude SQLite database temporary files

Exclude compresed files

These are binary files, temporary. They should not go into the GIT repository

Not stale, just no free time right now.

Build problem resolved in other PR: old rsync

merged in dev


feat: UI to copy component names

According to #1555 , I added UI button so that it can copy the component name, which is referred to the state data operation like this:

Thank you for your code review. The style could be optimized. And also I noticed the issue #1351  mentioned that we would like to add UI to filter out components. That can be added below the button list I think.

Thank you for your PR! However, I implemented a different solution here: 5d84a8b96f1f7763e0fa41ad4bd42a33d75f3d60


Small feature request for 'poetry shell' to accept something besides $SHELL

[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] I have searched the documentation and believe that my question is not covered.

Feature Request
Small setback
If poetry shell is run from a script, then $SHELL is going to be set to what that script was executed in. Example scenario:

I am using zsh
I write scripts to help teammates work with Poetry (they are coming from other tools), for example a .env which gets sourced by autoenv etc, and then does poetry shell at the end. I make these scripts have a bash shebang because that's the sane default for most at the company
I still want to be using zsh when poetry shell is called in one of these contexts

Easy fix

Option: support for $POETRY_SHELL variable that will be checked before $SHELL variable

This option seems sensible to me

Option: support for something like poetry shell --precedence /bin/zsh /bin/bash etc
Option: support for something like that, but at poetry config level

I will submit a PR once we agree on how it should work!

(It would also be reasonable for run to respect the same, though it makes no difference for my use case)

Closing as redundant of #571  / #497 /  #951


Fixes to spacing on 50-50 and 25-75 text-image molecules

Fixes #1235 by removing the spacing from the molecule to have it handled by .block and fixing the spacing on the header for the 50-50 molecule.

Review

@jimmynotjim
@anselmbradford
@sebworks

Can I get a review: @anselmbradford, @sebworks and @jimmynotjim?

There is some overlap on mobile:

@sebworks thanks for the catch. Can you take a look now?

:+1:

:+1:


Fix missing await statement in AsyncDatabase

In replit/database/database.py, line 80
From:
        self.sess.close()

To:
        await self.sess.close()

Should fix #118

Thanks!


optimizeCodeSmellInSpark

Why is this PR needed?
There are some code smells in spark module
What changes were proposed in this PR?
optimzie the some code smell
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

LGTM


Attempting to unbreak things, some minor improvements

Also fixed some important elements of #7

Seems gamer to me.


Adjusted after LabelFilter.h cleanup

Related to DigitalGlobe/DeepCore-Dev#540

Can one of the admins verify this patch?


Sponsor page Layout

User Story
As a website visitor, I want to be able to view information about the sponsors of CSSA on the Sponsor page so that I can learn about their contributions and support.
Acceptance Criteria

The Sponsor page might include a hero image/banner upon entry to indicate the purpose of the page.
The Sponsor page includes a section for a list of current sponsors and their logos or images.
The Sponsor page includes a section that highlights the benefits of sponsoring the school club.

Priority
High
Story Points
5

Designed


Fail gracefully when disconnected from manager

When the client loses connection to the manager, have something on the client tell the user.

As far as I'm aware, the "Lost connection to Labrad. Manager connection closed. Attempting to reconnect." dialog window has fulfilled this issue. If you meant something else, please clarify and reopen the issue.


Cleanup for some tests

Removing duplication between pre-V1 and V1 tests.

✅ No public API change.

✅ No public API change.

✅ No public API change.


[$250] Pay someone - Unapprove option is available for "Pay someone" expense, which gives error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.5-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to any DM.
Go to + > Pay someone.
Enter amount and pay them.
Click on the expense preview.
Click on the report header..
Click Unapprove.

Expected Result:
Unapprove option should not be available for "Pay someone" expense.
Actual Result:
Unapprove option is available for "Pay someone" expense, which results in error.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/eea20d0a-ed5e-4f37-8ed3-fac430aecbe7

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010702f689c6b7150e
Upwork Job ID:<PHONE_NUMBER>231832841
Last Price Increase: 2024-08-22

Issue OwnerCurrent Issue Owner: @Pujan92

@johnmlee101 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to  #vip-vsb

@rushatgabhane looks like we gotta fix this!

PR up soon

Fix merged & CPing

There's 3 app PRs listed in that PR, we only need to handle payment in 1 of those - so I was thinking we'll do that in a different one, not this one

Aah yep looks like @ishpaul777 hasn't been paid for reviewing https://github.com/Expensify/App/pull/45049 🙏  @MitchExpensify can you please help with that? 🙏

asked for payment help internally

ah.. shit, sorry @Pujan92 , forgot to assign @ishpaul777 BEFORE adding External.
@ishpaul777 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~010702f689c6b7150e

Contributor+: @ishpaul777 paid $250 via Upwork.
@ishpaul777 we want a regression test for this, right? Assuming so, can you fill out the checklist? Thx
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@] Determine if we should create a regression test for this bug.
[ ] [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@BZ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Thanks @ishpaul777 test case GH created

https://github.com/Expensify/Expensify/issues/423317


Code release

Hi authors, thank you very much for your great work! It is pretty appealing for me. When will you release your code?

I'd also love to try this out! Hopefully 🤞 sometime today as promised in the readme?

Good luck on your submission!

Looking forward to trying this out! Hope your submission went well!
Even just the approach of corrupting a single image to make a TI more robust is going to be useful for other applications - disentangling object from style and orientation more effectively!

Thanks! There was a bit more code refactoring than I expected, so it will be out on Monday. I think it's done now, but I have to re-test it now that I've refactored it.

Thanks! There was a bit more code refactoring than I expected, so it will be out on Monday. I think it's done now, but I have to re-test it now that I've refactored it.

Looking forward to trying this work. Hopefully, it is released as soon as possible!

@tares003 give him time to heal and recover ;)

I'm also looking forward to the code release !!!

Is there an update on the code release :) ?

I hope to be released soon, I'm also looking forward to trying this work :D

any update?

@/

This is a great work. Do you have any plans to make the code public shortly? @lukemelas

Done!
My apologies for the delay. It was due to a bunch of unexpected things (unrelated to this project) which prevented me from working on this for multiple weeks. Thank you to everyone who followed up on this!


Keep useful utilities in the npm package

This reverts most of #1449, with the opinion that while the files relating exclusively to development, contribution and deployment aren't relevant to the NPM package, a lot of the other stuff can be useful and should stay.
The pros on keeping the NPM package extra trim:

As @tivac says in #1449, getting rid of cruft
Smaller npm downloads

On the other hand:

Mithril is far from needing to compete aggressively on those features compared to any other given package. If a given user suffers from the clutter or weight of their npm installs, Mithril will almost certainly be at the bottom of the list of offenders - which makes the effort to prune back kind of pyrrhic.
The clutter argument is irrelevant for people who configure their IDEs / text editors to ignore the contents of ./node_modules/ - a common standard and baked-in default to the latest generation of Javascript-focussed IDEs.
Being able to read documentation and run tests for installed dependencies without using the internet is great if you do use it. It's probably true that not many people do this, but being able to open & search the documentation specific to the installed version in your local text editor is a feature, not a bug.

The biggest issue for me is that Mithril's zero-deps philosophy (not a popular quality metric, but a very neat one) is kind of hypocritical if you don't allow adopters the full benefit of being able to follow that lead and be just as robust and self-complete with Mithril as their sole dependency. You might argue it's kind of wilfully eccentric for Mithril to use and incorporate its own test harness, mocks and bundler when there are adequate alternatives out there with more dedicated maintenance - the counter-argument is that it's delightful & genuinely useful to have a self-contained package - and the irony is that adopters are cut off from the full benefits of this achievement when they can no longer use Mithril as a single dependency themselves.
By way of example, Mithril Route Components (defunct) is able to follow Mithril's practice by example, with a test suite & continuous integration using OSPEC and the browser mock, and it only depends on Mithril. In contrast, I'm faced with the dilemma of wondering what package I should pick to learn for mocking the DOM to test Mithril Islands. It's an obnoxious problem to have, because this otherwise lightweight plugin repo will need to get an extra dependency which may not make the same assumptions as Mithril's internals.

Wrong branch... Otherwise :+1:

Wow that just took me 2 clicks — thanks @pygy ;)

Wow indeed, I didn't know you could edit the target branch of a PR...

Ok, I'm gonna merge this for now and we can iterate on it if need be


move babel-core to dev deps

This addresses #18 by moving babel-core into the devDependencies of this package.
It doesn't appear like this module needs to be a plain dependency, but a security
vulnerability in the v5 line of babel is appearing upstream as a result.

Coverage remained the same at 100.0% when pulling ec138dc21982716469f510a3102b288441c1d829 on dominicbarnes:babel-devdep into 037feb94be997790452de86a323a60e84f9609dd on mhelvens:master.

Just checking in to see what you think of this change, it'd be great if it could land.

I'm so sorry. It's been busy and this completely slipped my mind. I'll look at your change (and probably accept it) shortly.

No worries, I totally understand that life is busy. Thanks for taking the time. :)

Since it's not a code change for the package itself, would it be possible to get an patch version published to npm?

I guess your comment predates this, but FYI: I did publish a patch version 1.20.12.


Collection editing

I have a list of SerializableInterface<>.
Editing the value of one element in the list changes the value of all elements with the same type in that list.
public class CombineStringsValue : MonoBehaviour, IProvideValue<string>
{
    [SerializeField] private List<SerializableInterface<IProvideValue<string>>> m_Providers;

    public string Value => m_Providers.Aggregate("", (current, provider) => current + provider.Value.Value);
}

:tada: This issue has been resolved in version 1.7.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


concatenate Cookie HPACK headers for the HTTP request

fixes #338

für, same thing in the stdlib: https://github.com/golang/net/blob/541150ac4f433e755f5663eba5d888c2fa347343/http2/server.go#L1753


Avoid log msg interleaving, fixes #84

See #84 for details.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 8 (37.5%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 89.202%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/support/MPILogger.cpp
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/support/MPILogger.cpp
7
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
2916

Relevant Lines:
3269

💛  - Coveralls


Allow custom discovery location?

What happened?
First of all, really awesome work making oauth4webapi and node-openid-client.
I'm not sure whether to label this a feature request or bug.
I'm running into an issue when sending a discovery request to the url:
https://developer.api.intuit.com/.well-known/openid_sandbox_configuration
You'll notice that oauth4webapi is appending its own ...well-known... url portion, so it appears in duplicate:

It looks like you may have solved this in node-openid-client in this commit: https://github.com/panva/node-openid-client/commit/0c8a8f242effe2e444db36271de68b4b71ea8489
I realize that is a different repo, but these projects do solve a lot of the same problems and I was wondering if you'd be willing to apply the same/similar fix to this repo?
Thanks,
Mike
Version
v2.2.1
Runtime
Deno
Runtime Details
deno:v1.32.4
Code to reproduce
import { discoveryRequest } from<EMAIL_ADDRESS>

const url = new URL('https://developer.api.intuit.com/.well-known/openid_sandbox_configuration')

const response = await discoveryRequest(url)

console.log(response)

### Required

- [X] I have searched the issues tracker and discussions for similar topics and couldn't find anything related.
- [X] I agree to follow this project's [Code of Conduct](https://github.com/panva/oauth4webapi/blob/main/CODE_OF_CONDUCT.md)

You should just perform your own fetch request to obtain a Response and pass that to processDiscoveryResponse if you want to work with arbitrary discovery URLs.

Can do. Thank you.


Resource pack hat layer for armour not accounted for

The helmet itself resizes, but the hat layer for the armour does not. This is with the regular scaling, not the new pekhui scaling.

attached image is not displayed

https://imgur.com/3PCLXfY
Hopefully that link should be better


Horizontally Squeezed Rendering in split screen

Bevy version
Bevy Main (7989cb2650cb84b67eba7c0343b48e8e3b318ba1)
[Optional] Relevant system information
M1 MacBook Pro (macOS 12.6):
AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }

What you did
I am working on split screen game with 1-4 players. I'm seeing weird squeezed rendering in 2 player mode (where the screen is split vertically in the middle into higher than wider blocks) but not in 4 player mode (where the screen is split into wider than higher blocks in the exact same size of the window). Here's a screenshot of what the weird rendering looks like:

Similarly, here's the same screen with 4 players

As soon as I re-size the 2-player window, the artefact disappears and everything looks correct.
I tried to re-implement the gist of what I'm doing in a minimal project, but I can't replicate the issue there. I will share this minimal-working-version nonetheless to give an overview of what my code does.
I tried a variety of things, including manually setting the camera sizes, resetting cameras, changing the order of systems etc, to no avail. One difference between my minimal project and the actual project is that the actual project:

Initially installs another camera in a menu screen (and then removes it)
Loads meshes from the assets
Caches some meshes.

My gut feeling is that somehow the initial camera (that is the size of the window) caches some attributes and then the new split screen cameras (that are of a different size) have some wrong attributes cached until I resize the window and the cache is reset. But I can't replicate this behaviour and don't know enough about bevy to understand where to look.
Would love some help. Maybe I need to reset something somewhere that I don't know about? Thanks in advance!
The Minimal (but working) code:
use bevy::core_pipeline::clear_color::ClearColorConfig;
use bevy::ecs::schedule::ShouldRun;
use bevy::render::camera::Viewport;
use bevy::window::{close_on_esc, WindowId, WindowResized};
use bevy::{log::LogSettings, prelude::*};

const SIZE: f32 = 0.25;
const PLAYER_Y: f32 = 4.5;

#[derive(Component)]
struct PlayerCamera(usize);

#[derive(PartialEq, Eq, Clone, Copy, Debug, Hash)]
enum GameState {
    Loading,
    Running,
}

impl GameState {
    fn is_running(state: Res<State<GameState>>) -> ShouldRun {
        (state.current() == &GameState::Running).into()
    }
}

fn main() {
    App::new()
        .insert_resource(LogSettings {
            filter: "info,wgpu_core=warn,wgpu_hal=warn,pacbomber=debug".into(),
            level: bevy::log::Level::DEBUG,
        })
        .insert_resource(ClearColor(Color::rgb(20. / 255., 20. / 255., 20. / 255.)))
        .insert_resource(WindowDescriptor {
            title: "Test".to_string(),
            width: 900.,
            height: 660.,
            resizable: true,
            ..default()
        })
        .add_plugins(DefaultPlugins)
        // .add_plugin(LogDiagnosticsPlugin::default())
        // .add_plugin(FrameTimeDiagnosticsPlugin::default())
        .add_system_set(SystemSet::on_enter(GameState::Loading).with_system(build_level_system))
        .add_system_set(SystemSet::on_enter(GameState::Running).with_system(set_camera_viewports))
        .add_system_set(
            SystemSet::new()
                .with_run_criteria(GameState::is_running)
                .with_system(keyboard_system)
                .with_system(move_camera_system)
                .with_system(close_on_esc)
                .with_system(detect_resize_events),
        )
        .add_state(GameState::Loading)
        .run();
}

#[derive(Component)]
struct Player;

fn build_level_system(
    mut commands: Commands,
    mut meshes: ResMut<Assets<Mesh>>,
    mut materials: ResMut<Assets<StandardMaterial>>,
    mut state: ResMut<State<GameState>>,
) {
    info!("build level");
    // 4 players
    for player in 0..=1 {
        let clear_color = if player == 0 {
            ClearColorConfig::Default
        } else {
            ClearColorConfig::None
        };
        commands
            .spawn(Camera3dBundle {
                transform: Transform::from_xyz(0.0, PLAYER_Y, 3.0).looking_at(Vec3::ZERO, Vec3::Y),
                camera: Camera {
                    // Renders the right camera after the left camera, which has a default priority of 0
                    priority: (player as isize),
                    ..default()
                },
                camera_3d: Camera3d {
                    clear_color,
                    ..Default::default()
                },
                ..default()
            })
            .insert(PlayerCamera(player));
    }

    let player = meshes.add(Mesh::from(shape::Cube { size: SIZE }));
    let player_material = materials.add(StandardMaterial {
        base_color: Color::YELLOW,
        metallic: 0.5,
        reflectance: 0.15,
        ..Default::default()
    });

    commands
        .spawn(PbrBundle {
            mesh: player,
            material: player_material,
            transform: Transform::from_xyz(10. * SIZE, 0.5, 10. * SIZE),
            ..Default::default()
        })
        .insert(Player);

    let floor = meshes.add(Mesh::from(shape::Plane { size: SIZE - 0.01 }));
    let floor_material = materials.add(StandardMaterial {
        base_color: Color::RED,
        metallic: 0.5,
        reflectance: 0.15,
        perceptual_roughness: 0.5,
        ..Default::default()
    });

    let offset = SIZE * -10.;
    let (mut x, mut z) = (offset, offset);
    for zc in 0..=128 {
        z += SIZE;
        for xc in 0..=128 {
            x += SIZE;
            commands.spawn(PbrBundle {
                mesh: floor.clone(),
                material: floor_material.clone(),
                transform: Transform::from_xyz(x, -0.1, z),
                ..Default::default()
            });
            // every corner a light
            match (zc, xc) {
                (1, 1) => spawn_light(&mut commands, x, z),
                (1, 127) => spawn_light(&mut commands, x, z),
                (127, 127) => spawn_light(&mut commands, x, z),
                (127, 1) => spawn_light(&mut commands, x, z),
                (64, 64) => spawn_light(&mut commands, x, z),
                (64, 1) => spawn_light(&mut commands, x, z),
                (1, 64) => spawn_light(&mut commands, x, z),
                _ => (),
            }
        }
        x = offset;
    }
    state.overwrite_replace(GameState::Running).unwrap();
}

fn spawn_light(commands: &mut Commands, x: f32, z: f32) {
    commands.spawn(PointLightBundle {
        point_light: PointLight {
            intensity: 350.0,
            shadows_enabled: true,
            ..default()
        },
        transform: Transform::from_xyz(x, 1.0, z),
        ..default()
    });
}

fn keyboard_system(
    keyboard_input: Res<Input<KeyCode>>,
    mut player: Query<&mut Transform, With<Player>>,
) {
    let speed = 0.15;
    for (code, (d_x, d_z)) in [
        (KeyCode::Left, (-1, 0)),
        (KeyCode::Right, (1, 0)),
        (KeyCode::Up, (0, -1)),
        (KeyCode::Down, (0, 1)),
    ] {
        if keyboard_input.pressed(code) || keyboard_input.just_pressed(code) {
            let (x, z) = ((d_x as f32) * speed, (d_z as f32) * speed);
            for mut transform in player.iter_mut() {
                transform.translation.x += x;
                transform.translation.z += z;
            }
        }
    }
}

fn move_camera_system(
    player_query: Query<&Transform, (With<Player>, Without<PlayerCamera>)>,
    mut camera_query: Query<(&Camera, &mut Transform), With<PlayerCamera>>,
) {
    for transform in player_query.iter() {
        let player_pos = transform.translation;
        for (_, mut transform) in camera_query.iter_mut() {
            *transform =
                Transform::from_xyz(player_pos.x, PLAYER_Y - player_pos.y, player_pos.z + 3.0)
                    .looking_at(player_pos, Vec3::Y);
        }
    }
}

fn detect_resize_events(
    windows: Res<Windows>,
    mut resize_events: EventReader<WindowResized>,
    camera_query: Query<(&mut Camera, &PlayerCamera)>,
) {
    for resize_event in resize_events.iter() {
        if resize_event.id == WindowId::primary() {
            info!("resize event");
            set_camera_viewports(windows, camera_query);
            break;
        }
    }
}

fn set_camera_viewports(
    windows: Res<Windows>,
    mut camera_query: Query<(&mut Camera, &PlayerCamera)>,
) {
    info!("set viewport");
    let window = windows.primary();
    let (w, h) = (window.physical_width(), window.physical_height());

    fn pad(x: u32, y: u32, w: u32, h: u32) -> (u32, u32, u32, u32) {
        let padding = 4;
        (x + padding, y + padding, w - padding * 2, h - padding * 2)
    }

    let stupid_map: &[&[(u32, u32, u32, u32)]] = &[
        // Easy mode: One player
        &[pad(0, 0, w, h)],
        // Two Players
        &[pad(0, 0, w / 2, h), pad(w / 2, 0, w / 2, h)],
        // Three players
        &[
            pad(0, 0, w / 2, h / 2),
            pad(w / 2, 0, w / 2, h / 2),
            pad(0, h / 2, w / 2, h / 2),
        ],
        // Four players
        &[
            pad(0, 0, w / 2, h / 2),
            pad(w / 2, 0, w / 2, h / 2),
            pad(0, h / 2, w / 2, h / 2),
            pad(w / 2, h / 2, w / 2, h / 2),
        ],
    ];

    let total = camera_query.iter().count();
    for (mut camera, player_camera) in camera_query.iter_mut() {
        let (x, y, w, h) = stupid_map[total - 1][player_camera.0];
        camera.viewport = Some(Viewport {
            physical_position: UVec2::new(x, y),
            physical_size: UVec2::new(w, h),
            ..default()
        });
    }
}

I just found a solution. If I already set the viewport during camera initialisation, then the bug doesn't appear:
camera: Camera {
                    priority: (index as isize),
                    viewport: calculate_viewport(index),
                    ..default()
                },

So it seems the bug is that creating a camera without a viewport and then setting the viewport at a later time (e.g. a couple of frames after) is not applied correctly.

I think this may be a duplicate of #5944 and a fix just worked its way through CI. Could you test with the latest commit?

@terhechte gentle ping to test this with the latest main. #5944 has been closed.

Oh yeah, sorry, I forgot about this issue. This is working fine now. Thanks for reminding me!


Installation failure caused by conda confliction

HI,
First thanks for developing such an awesome tool. I want to apply it on my WGS data to call somatic CNA. However, when I tried this step:
conda env create -n ACEseqWorkflow -f $PATH_TO_PLUGIN_DIRECTORY/resources/analysisTools/copyNumberEstimationWorkflow/environments/conda.yml
It seems a lot of conda packages, especially their versions are conflicted. And some package version couldn't be found in current conda as well. Do you heve some recommendations on how to solve this problem?
Many thanks!
Yang

Hi Yang.
One problem with Conda is that it can be hard to reconstitute old environments. In principle it could be conflicts of packages of the newer Conda installation and requirements of the packages in the old environment. Or even the old packages have been removed from the channels. At least for bioconda packages you may include the bioconda-legacy channel. That might work.
I am currently also looking into collecting some information on the available Docker containers. The docs seem outdated here (sorry).

Hi @YangShi-PKU
Here is another option, that may spare you a lot of hassle with the installation and setup. @suhrig has prepared a number of Docker containers of the workflow plus an archive with the required reference data. You can retrieve the data from https://ppcg.dkfz.de/pipelines/. The archives contain the following Roddy-based workflows

ACEseq 1.2.10
SNV 1.2.166-1
Indel 1.2.177-2

This means for the ACEseq Workflow this is not the newest version, but one that is pretty close to what we currently use in our production systems (1.2.8). The archives have been prepared for a data analysis in the context of a manuscript that is currently in preparation.
I hope this helps!

Thanks, I'll try that!
Best
Yang

Hi @YangShi-PKU
Here is another option, that may spare you a lot of hassle with the installation and setup. @suhrig has prepared a number of Docker containers of the workflow plus an archive with the required reference data. You can retrieve the data from https://ppcg.dkfz.de/pipelines/. The archives contain the following Roddy-based workflows

ACEseq 1.2.10
SNV 1.2.166-1
Indel 1.2.177-2

This means for the ACEseq Workflow this is not the newest version, but one that is pretty close to what we currently use in our production systems (1.2.8). The archives have been prepared for a data analysis in the context of a manuscript that is currently in preparation.
I hope this helps!

Hi,
Thanks for sharing the docker as I am also working on running your tool and getting conda conflicts.
I am wondering if the pipeline in the docker can run with the hg38?
Thank you very much.
Best wishes,
Yuyao

Hi Yuyao,
The prebuilt containers are not compatible with hg38, unfortunately.
Regards,
Sebastian

Hi Yuyao,
The prebuilt containers are not compatible with hg38, unfortunately.
Regards,
Sebastian

Hi Sebastian,
Thanks for the reply. Would it be possible to update the conda environment configure file of the ACEseq workflow (hg38)? If the .yml of a working version is exported freshly, I assume that the packages will be compatible.
Many thanks.
Best wishes,
Yuyao

There is a hg38 branch in this repository. I think @NagaComBio is more qualified than me to answer what the status of this branch is and whether it is usable.

Sorry, @YY-SONG0718 for the delayed response. @vinjana is trying to solve the hg19 conda issue, we will get back to the hg38 conda env issue ASAP.
We usually use our local cluster environment for the development and production, so we have paid little attention to the conda env files.

Hi @NagaComBio @suhrig. No problem, Thanks for being supportive :)

O.k., now after some testing we managed to get the Conda environment to work again with the newest hg38-enabled development version of the workflow (credits go to @NagaComBio!), but still I don't think this will be a good solution, because of some general problems with the Conda-based solution.
There are some old packages, which are lost in the used Conda channels. This means that it's not possible to reinstall a working environment just with conda env create -n ACEseq -f conda.yaml.
The only option that I see would be distributing a conda pack package. Unfortunately, at least for us this was not sufficient, because

some packages needed manual reinstallation ( conda install --force-reinstall bioconductor-genomeinfodbdata bedtools==2.16.2), and
(and worse) there is a bug in R that may cause problems if you run the workflow in parallel.

The only possible solution that I see in the moment to cope with these issues would be to containerize. I could also provide you with the conda pack, but will probably require some more time investment from your side.


Clean up batching/chunking (naming and tests)

Naming
Currently our chunking logic (that splits a huge query with too many prepared statement placeholders) into multiple queries is called "batching" internally (and in the env var QUERY_BATCH_SIZE).

Rename code and test cases to use chunk(ing) instead batch(ing)
Add new, public variant of env var PRISMA_... that uses CHUNK instead of BATCH

Internal discussion about naming: https://prisma-company.slack.com/archives/C02FNFLDUS3/p1663580103340319
Tests
Right now our tests use an unrealistic low "chunk size" for all our tests: https://github.com/prisma/prisma-engines/blob/fb56bfedb3a66723ec5d908bc5cb4a411ec97c47/.envrc#L14 (See explanation why in the "Internal Discussion" link below - all made sense at the time)
We should remove this, and instead:

Test the default settings per provider across our complete test suite (as that is much closer to our user's queries instead of a special case)
Have new tests that test the actual chunking behavior (with the default value per provider) (as that is the actual real world chunking behavior that needs to work)
Have an additional new tests that only tests this env var and its ability to override the chunk size

Internal Discussion: https://prisma-company.slack.com/archives/C4GCG53BP/p1663605710286069

Further internal discussion what happens when the current always set env var is removed for the tests: https://prisma-company.slack.com/archives/C4GCG53BP/p1663667317631509?thread_ts=1663605710.286069&cid=C4GCG53BP (Nothing bad, just the tests that actually test the chunking are failing because it is not triggered any more with the default values)

Temporary PR that shows what happens when the tests currently are run without QUERY_BATCH_SIZE=10: https://github.com/prisma/prisma-engines/pull/3204


alignment

i can't see the "alignment" in Option , version 0.8.1

@navid-sharifi The alignment parameter in the SimpleToastOptions struct is still available: https://github.com/sanzaru/SimpleToast/blob/8dbc2e7c33cda25c0b2efafd59716cb9820c83eb/Sources/SimpleToast/SimpleToastOptions.swift#L14
Can you provide a snippet of code where you implemented the options?

@navid-sharifi The alignment parameter in the SimpleToastOptions struct is still available:
https://github.com/sanzaru/SimpleToast/blob/8dbc2e7c33cda25c0b2efafd59716cb9820c83eb/Sources/SimpleToast/SimpleToastOptions.swift#L14
Can you provide a snippet of code where you implemented the options?

it work as well  , thank you
but the Alignment must be first.
private let toastOptions = SimpleToastOptions(
alignment : .center,
hideAfter: 3 ,
animation: .smooth,
modifierType: .scale
)


removed min,max,current functions, all combined into one

Function returns a 2d array core. 1st array is core, 2nd array is temp type of that core (current,min,max)

Looks good to me


Include txCode in the OpenID4VCIClient

When parsing the uri, it would help to get the information from txCode to inform the user he needs to provide some values.
@nklomp I think it was included here: https://github.com/Sphereon-Opensource/OID4VCI/blob/40ad1ded998168e2703daeddc3a3afc78c9b19a1/packages/client/lib/CredentialOfferClient.ts#L76
Any reasons to not include it again? :)

It seems to be available via client.credentialOffer.credential_offer.grants?.[             GrantTypes.PRE_AUTHORIZED_CODE           ]?.tx_code,
But with the outcomment txCode the CredentialOfferRequestWithBaseUrl can lead to confusion because there the txCode is marked as optional, but it's value is never set

Fixed in v0.14.0

@nklomp I think it is not fixed :( When I am printing our the credental_offer and the request I get this:
{
  grants: {
    'urn:ietf:params:oauth:grant-type:pre-authorized_code': {
      'pre-authorized_code': '2e08465f-d04a-4d64-a75c-f8d8c6cfc154',
      tx_code: [Object]
    }
  },
  credential_configuration_ids: [ 'Identity' ],
  credential_issuer: 'http://localhost:3001'
}
{
  user_pin: '155195',
  grant_type: 'urn:ietf:params:oauth:grant-type:pre-authorized_code',
  'pre-authorized_code': '2e08465f-d04a-4d64-a75c-f8d8c6cfc154'
}

I am confused why now the user_pin is set since this was not before in the version when using v13

It seems the request is build incorrect, see: https://github.com/Sphereon-Opensource/OID4VC/blob/develop/packages/client/lib/AccessTokenClient.ts#L107
Any reason to set it to user_pin or was it maybe a merge conflict? :)

It seems that in the sessionsManager the value is still set as userPin, while the interface is designed to use txCode:
    const session: CredentialOfferSession = {
      preAuthorizedCode,
      issuerState,
      createdAt,
      lastUpdatedAt,
      status,
      notification_id: v4(),
      ...(userPin && { userPin }),
      ...(opts.credentialDataSupplierInput && { credentialDataSupplierInput: opts.credentialDataSupplierInput }),
      credentialOffer,
    }

I don't feel good to use userPin and txCode in the code, I suggest it should be refactored to only use txCode.
The small fix would be to update the check to:
if (request.tx_code !== credentialOfferSession.userPin) {

when we want to treat the object still as userPin for internal management

No we cannot change to only use txCode in this version. That will be part of the next refactor, where we drop support for everything older. This would break any wallet interacting with older issuers
Met vriendelijke groet,
Niels Klomp
CTO
[cid:bc2925bb-1e2e-423b-91ca-431f31493eba]
J.M. Keynesplein 10
1066 EP Amsterdam
+31 (0)852 736513
Op woensdagmiddag niet aanwezig
@.?anonymous&ep=signature>             Maak een afspraak voor een gesprek met @.?anonymous&ep=signature>

Van: Mirko Mollik @.>
Verzonden: dinsdag 16 juli 2024 11:50
Aan: Sphereon-Opensource/OID4VC @.>
CC: Niels Klomp @.>; Mention @.>
Onderwerp: Re: [Sphereon-Opensource/OID4VC] Include txCode in the OpenID4VCIClient (Issue #117)
It seems that in the sessionsManager the value is still set as userPin, while the interface is designed to use txCode:
const session: CredentialOfferSession = {
  preAuthorizedCode,
  issuerState,
  createdAt,
  lastUpdatedAt,
  status,
  notification_id: v4(),
  ...(userPin && { userPin }),
  ...(opts.credentialDataSupplierInput && { credentialDataSupplierInput: opts.credentialDataSupplierInput }),
  credentialOffer,
}

I don't feel good to use userPin and txCode in the code, I suggest it should be refactored to only use txCode.
The small fix would be to update the check to:
if (request.tx_code !== credentialOfferSession.userPin) {
when we want to treat the object still as userPin for internal management
—
Reply to this email directly, view it on GitHubhttps://github.com/Sphereon-Opensource/OID4VC/issues/117#issuecomment-2230480434, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADH4BSE72ZBFIERNN3FJIL3ZMTUEXAVCNFSM6AAAAABJ4TUWZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGQ4DANBTGQ.
You are receiving this because you were mentioned.Message ID: @.***>

Okay, can we at least then patch the comparison line? Right now the function will fail all the time. I can open a PR for this (it will not break the old approaches)

Sue, but it will need another set of eyes, to see whether we didn't miss other areas


Unable to run query for newly added source in yml

Expected behavior
When I add a new source table to a project .yml file, I'd like to query it directly with dbt Power User.
Actual behavior
I receive an error message:
Sql_Operation 'sql_operation.xxx.t_2cbf0bd27e1b4e17b63ec4ca11dce2ab' (from remote system.sql) depends on a source named 'xxx.yyy' which was not found
Steps To Reproduce

Create .yml file in models directory (e.g. schema.yml)
Add entry under sources node:

version: 2

sources:
  - name: bronze
    description: my test
    database: db_name
    schema: dbo

    tables:
      - name: my_test_table

Create new model file (.sql) and reference the newly created source

select * from {{ source('bronze', 'my_test_table') }}

Press CTRL+Enter to run a query for the newly created model

Log output/Screenshots
Compilation Error
Sql_Operation 'sql_operation.xxx.t_2cbf0bd27e1b4e17b63ec4ca11dce2ab' (from remote system.sql) depends on a source named 'bronze.my_test_table' which was not found
Operating System
Debian GNU/Linux 11 (bullseye)
dbt version
1.8.3
dbt Adapter
fabric (1.8.7)
dbt Power User version
v0.41.1
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Closing as no way to repro


How to setup RTMPS without stunnel

I would like to setup rtmps on production server
I don't wanna use stunnel on my server
Is there any other way to setup rtmps ?
I was thinking about nginx but if I use it
I can do rtmp setting directly on there to be fast
but I would like to do it on node instead of creating an nginx server
Anyone has any Idea?

I found this:
https://www.iiwnz.com/compile-ffmpeg-with-rtmps-for-facebook/

To add on to @rrfaria's comment, if you'd rather not go through the process of compiling ffmpeg, I've been using a static binary (4.2.2) from here - https://ffmpeg.zeranoe.com/builds - for over a month now with Facebook live rtmps. I've had had no issues. (I can only vouch for version 4.2.2)

The simplest way I have found to do this is to use the [ffmpeg-static](https://github.com/eugeneware/ffmpeg-static) builds in my project. This makes it incredibly simple to download the ffmpeg right next to my node.js project and use that. I also have tested it with the Instagram and Facebook RTMPS server urls and it worked flawlessly.

You can use this Dockerfile.

RUN npm i

COPY . .

EXPOSE 1935 8000

CMD ["node","app.js"]

This feels way more complicated than to just use the ffmpeg-static build though? Is there any particular reason to build your own ffmpeg version like that?

Is there any particular reason to build your own ffmpeg version like that?

you get the proper version with open SSL that why @chrisspiegl


Documentation: Not possible to restore initial implementation when mocking?

💥 Regression Report
Jest documentation for restoreMocks claims to remove fake implementations and restore initial implementations, but the underlying functionality here appears to have changed to no longer remove fake implementations (and doesn't seem to restore pre-mocked functionality even when called manually after jest.resetAllMocks in an afterEach block).
afterEach(() => {
  jest.resetAllMocks();
  jest.restoreAllMocks();
});

resetMocks does remove fake implementations, but does not restore initial implementations.
The differences between these methods are not clearly explained (#5969, #5143, #4828), and it's unclear if it's even possible to restore pre-mocked functionality.
Neither resetModules nor clearMocks seem to have this functionality either.
To Reproduce
jest.mock("fs");

const fs = require("fs");

it("mocks fs.readFileSync", () => {
  fs.readFileSync.mockReturnValue("foo");
  const file = fs.readFileSync("foo.txt", "utf8");
  expect(file).toEqual("foo");
});

it("restores mock and reads file", () => {
  const file = fs.readFileSync("foo.txt", "utf8");
  expect(file).toEqual("bar");
  // fails with `undefined` when run with --resetMocks
  // fails with `foo` when run with --restoreMocks
});

foo.txt
bar

Expected behavior
The Jest documentation accurately describes the behavior of mock reset/restore functionality and what is or is not possible when mocking.
Link to repl or repo (highly encouraged)
https://github.com/mikemorris/jest-restore-mocks
Run npx envinfo --preset jest
  System:
    OS: macOS High Sierra 10.13.6
    CPU: x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
  Binaries:
    Node: 8.9.3 - ~/.asdf/shims/node
    npm: 6.4.1 - ~/.asdf/shims/npm
  npmPackages:
    jest: ^23.6.0 => 23.6.0

Restore is not working, I tried:
mySpy.mockRestore();
jest.restoreAllMocks();
jest.clearAllMocks();
and none of them works.

This works:
class Bla {
	foo() {
		return true;
	}
}

const bla = new Bla();

describe("Bla", () => {
	it("should return mock value", () => {
		jest.spyOn(bla, "foo").mockImplementationOnce(() => false);
		const result = bla.foo();
		expect(result).toBe(false);
	});

	it("should return real value", () => {
		const result = bla.foo();
		expect(result).toBe(true);
	});
});


[legisqa] Improve RAG answers by interactively adding context via documents and document chunks

Is your feature request related to a problem? Please describe.
Sometimes we want to be specific when using hyperlegis about documents or pieces of documents that will provide a more helpful answer. For example, when asking: "What would a libertarian think about the Workforce Democracy and Fairness Act?", we already know what document we want to query, and "zooming in" to pieces of scope in that document might provide a better answer.
Describe the solution you'd like
We should be able to select whole documents or document pieces to add. Documents should be exposed in the GUI via Dataset > Record > Chunk hierarchy (e.g. congress > HR 118-S-2438 > chunk 2)
Describe alternatives you've considered
Adding chat would also help solve the fundamental problem, but is probably out of scope for a single issue.

@FMurray is your question fundamentally around the prompt or around retrieval? My proposed solution is specific to retrieval but I think prompt alterations are potentially smart as you mentioned as well. @galtay thoughts?

#19 adds in a specific bill filter. lets talk more about other solutions on discord or in person


How to test your pretrained model with different input image?

@yuanliangzhe How did you run the pretrained Unflow model on a new set of images?
Thanks!

Hi @sahityamantravadi , we hacked into the code and replace the dataloader with our own. One quickest way to test with your own images would be naming your images as the dataset naming format, say KITTI's, and place them into the corresponding folders.
Good luck!


System.Span struct code example of Arrays part does not match

Type of issue
Other (describe below)
Description
In Arrays part, description say double value of middle five elements of a 10-element integer array,but below code is whole array's sum
Page URL
https://learn.microsoft.com/en-us/dotnet/fundamentals/runtime-libraries/system-span{t}#arrays
Content source URL
https://github.com/dotnet/docs/blob/main/docs/fundamentals/runtime-libraries/system-span{t}.md
Document Version Independent Id
003de901-5f1a-7c88-faa1-c18c3553c091
Article author
@gewarren
Metadata

ID: 7e0a1b3e-6c99-b144-cca0-e71dff3f1be5
Service: dotnet-fundamentals

@prime167 Great catch! I really appreciate you opening the issue and adding the code to fix it.


Further compress the in-memory representation of address maps

This commit reduces the size of InstructionAddressMap from 24 bytes to
8 bytes by dropping the code_len field and reducing code_offset to
u32 instead of usize. The intention is to primarily make the
in-memory version take up less space, and the hunch is that the
code_len is largely not necessary since most entries in this map are
always adjacent to one another. The code_len field is now implied by
the code_offset field of the next entry in the map.
This isn't as big of an improvement to serialized module size as #2321
or #2322, primarily because of the switch to variable-length encoding.
Despite this though it shaves about 10MB off the encoded size of the
module from #2318

@peterhuene would you be able to take a look at this?


Collapsible header overflow issue

I am using slightly long headers for my collapsible implementation . I am using the collapsible for a FAQ section of my site, where the collapsible header is the question, with the body holding the answer.
When I resize the screen to a smaller window, the header of the collapsible overflows into the next section below. I have tried several css properties to fix it without any success.  Any ideas how to fix this?
Try the example on the site with a slightly longer header and resize your screen.

I just found this has been resolved through an update. so closing it now. however, the solution is not 100% perfect. it doesn't wrap cleanly


Add run_as_user to service resource to work on Chef 14

On Chef 14 windows_service resource defaults to LocalSystem as a user account. So explicitly set user parameter to bypass user mismatch as WinRM uses NetworkService account.
Signed-off-by: Anton Kvashenkin<EMAIL_ADDRESS>Closes #14

[x] Tested on Chef 13.10.4

[x] Tested on Chef 14.5.33

@Annih Can you review please.

Many thanks for your PR @jugatsu I'll release ASAP

@Annih Could you release new version please? Or should I make PR with version bump and CHANGELOG?

@Annih Any updates

Hello @jugatsu I'll do my best, but as you said the run_as_user has been introduced in version 12.6 and this cookbook was still supporting Chef 12.0, I'm trying to decide whether to just drop the support or not.
Anyway, I'll do a release before wednesday, is it OK?

@Annih Yes, it's ok.
Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:
chef_version     '>= 12.1' if respond_to?(:chef_version)

@Annih Yes, it's ok.
Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:
chef_version     '>= 12.1' if respond_to?(:chef_version)

@Annih Yes, it's ok.
Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:
chef_version     '>= 12.1' if respond_to?(:chef_version)

@Annih Yes, it's ok.
Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:
chef_version     '>= 12.1' if respond_to?(:chef_version)

@Annih Yes, it's ok.
Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:
chef_version     '>= 12.1' if respond_to?(:chef_version)

@Annih Yes, it's ok.
Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:
chef_version     '>= 12.1' if respond_to?(:chef_version)

@Annih Yes, it's ok.
Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:
ruby
chef_version     '>= 12.1' if respond_to?(:chef_version)

@Annih Yes, it's ok.

@Annih Yes, it's ok.

Github comments is going crazy :)

@jugatsu I just released the new version. We still have other incompatibilities with Chef 13+ but I'll fix them in another release. Many thanks for your great contribution!


Deploying with Heroku

Hello,
I'm using the free heroku plan to deploy a fork of this repo without any issues so far with automatic deployement triggers. Lemme know if you need help moving away from pythonanywhere
https://covid19clusters.herokuapp.com/
https://github.com/vcidst/coronaIndia-old/tree/fastapi

Can you please raise a PR with the fastapi?  Would like to port to fastAPI from flask is possible.
cc @meghanabhange as the author+maintainer

Just created a PR with fastapi #13
I've currently kept the script structure as it is (instead of decoupling)


django_fsm.TransitionNotAllowed

Why do I get the error below when I tried to do the transition?  Is this a bug? Thanks
>>> t = Task.objects.first()
>>> t.state
"(0, 'Open')"
>>> t.to_in_progress()
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/Users/dingli/projects/personal/django_history_fsm_guardian/lib/python3.11/site-packages/django_fsm/__init__.py", line 573, in _change_state
    return fsm_meta.field.change_state(instance, func, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/dingli/projects/personal/django_history_fsm_guardian/lib/python3.11/site-packages/django_fsm/__init__.py", line 339, in change_state
    raise TransitionNotAllowed(
django_fsm.TransitionNotAllowed: Can't switch from state '(0, 'Open')' using method 'to_in_progress'

Here is the model.
STATES = ('Open', 'In Progress', 'Resolved', 'Re Opened', 'Closed')
STATES = list(enumerate(STATES))

class Task(models.Model):
    title = models.CharField(max_length=100, null=False)
    description = models.TextField()
    state = FSMField(default=STATES[0], choices=STATES)

    def __str__(self):
        return f'{self.title}: {self.description}'

    @transition(field=state, source=['Open', 'Re Opened'], target='In Progress')
    def to_in_progress(self):
        pass

    @transition(field=state, source='In Progress', target='Resolved')
    def to_resolved(self):
        pass

Seems like caused by you database content
Looks like somehow you saved wrong value inside state field


Maximum payment limits are not consistent in QueryRoutes

In theory a payment shard can now be larger than the "bootstrapping" limitation that prevented invoice creation larger than 0.04294967295 on the Bitcoin network
Practically, this limitation is still surfaced in some areas
In rpcserver.go:

maxBtcPaymentMSat = lnwire.MilliSatoshi(math.MaxUint32)

And enforced in QueryRoutes:

// Currently, within the bootstrap phase of the network, we limit the
// largest payment size allotted to (2^32) - 1 mSAT or 4.29 million
// satoshis.

This check is also enforced when un-marshaling a route:

  if routeHop.AmtToForward > r.MaxPaymentMSat {
  	return nil, fmt.Errorf("payment of %v is too large, "+
  		"max payment allowed is %v",
  		routeHop.AmtToForward,
  		r.MaxPaymentMSat.ToSatoshis())

To make a payment or check for a payment route using QueryRoutes for a larger payment, the limitation enforced there would need to be relaxed to a larger amount

@Roasbeef rc3?


Add tests for client

I managed to merge #40 without realizing it was broken. There should be some tests for the client to avoid this situations.

What was the issue/error with #40? It looks like all commits pass CI.

@rohanrk so the issue was that in that PR I removed the Multiproof type from the state module and began using Imp. There are three distinct crates in this repo, the EE, composer library, and client binary. I use Multiproof in all of them, but only replaced it with Imp in the EE and composer. You'll see in #42 how I fixed that issue. The reason I didn't catch it is because the client has no tests, so that is the goal for this issue.


Fix text clipping in front page rows

Text in the front page item rows could overflow and be clipped. Fix this by allowing the text to grow to normal line height, but reduce the padding instead to retain the previous amount of air (ish).

Før:

Etter:


Update getting-started.md

The docs don't work for v1, which is currently what pip installs by default

Duplicate #970