⚠ Cioos National CKAN has degraded performance

In d978200, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 11391 ms

Resolved: Cioos National CKAN performance has improved in 1255d7a after 2 hours, 10 minutes.


feat: add more Content-Formats

This PR adds a number of missing Content-Formats as a default and makes it possible to use Content-Formats with parameters. It also updates the README with a table of the supported Content-Formats instead of a JavaScript source code listing.
There might be an issue that arises from the fact that the space between Media-Type and parameters is optional but I would deal with that in another PR.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 89.581%

Files with Coverage Reduction
New Missed Lines
%

lib/cache.js
2
94.74%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
1065

Relevant Lines:
1158

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 89.581%

Files with Coverage Reduction
New Missed Lines
%

lib/cache.js
2
94.74%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
1065

Relevant Lines:
1158

💛  - Coveralls


[1.9.4] Crash when trying to break an Induction Cell and weird behavior

Induction components do not behave properly and I ended up crashing (client only):
https://youtu.be/mxoTECbrT4U
Crash Report: http://pastebin.com/vGRYw7dF

Fixed, thanks!


Add callback option, fix variable value concatenation for values with colons

Add stricter options validation
Add callback option to options as an alternative way of getting the result object
Fix variable-value concatenation, if the value had a ':', then it was incorrect. For example: url('https://www.xyz.com/foo.png')

Any plans to get this merged? this callback option would be extremely handy 😃


NPM Cache is large on macos-latest

👋 When setting up caching via actions/cache, it's common and recommended to cache ~/.npm after running npm install/ci.
On macOS, this directory is pre-populated with npm packages that are potentially not related to the user's build and is over 1 GB in size. This limits the ability to cache build dependencies due to size constraints and slows down caching due to the larger cache size.
See https://github.com/actions/cache/issues/187

@joshmgross, thank you for your report!
We put pre-cache of some popular NPM packages to macOS images. Unfortunately, it breaks you and it looks like pre-cache approach is inconsistent with actions/cache. We are having some internal discussion about it.
Unfortunately, it can't be fixed quickly but we will keep this issue updated about any news

@maxim-lobanov I had the same problem with the NuGet cache. (https://github.com/actions/cache/issues/115)

Yep, unfortunately, this issue affects NPM, Nuget, Yarn, Gradle, Cocoapods, Carthage on macOS images.
As a temporary work around, you can clean up this cache directory before using actions/cache.
Issue with all tools will be resolved at the same time but no estimation for now.

Small update:
We have started to work on this issue. It will require some internal rework so no ETA for now. Hope, it will be fixed soon.
Will keep you updated.

Hello everyone, just a small update.
We have fixed this issue and the new macOS image without pre-cached packages will be delivered in 1 week

👋 Hey @maxim-lobanov, do you have any updates on this?
https://github.com/actions/cache/issues/280 reported this with Gradle on macOS

@joshmgross , new macOS image with fix should be deployed this week

Hello everyone,
New image with fix is deployed everywhere and issue should be fixed.
Could you please check and report back if it works for you?

Closing the issue. Feel free to reopen if you still see the issue

👋 Hey @maxim-lobanov,
I'm still seeing a large NPM cache on macOS-latest:
Running du -sh ~/.npm outputs:  202M	/Users/runner/.npm so the cache is still large compared to the non-existent cache on ubuntu-latest.

Thank you for report.
We have removed pre-cache packages but these 202MB comes from npm install that does during image provisioning. I will reopen the issue and will fix it too.
Other tools (like gradle and yarn and etc should be okay)

@joshmgross , image with clean npm folder is deployed.
Could you please double check from your side?

Thanks @maxim-lobanov,
Running du -sh ~/.npm on macos-latest shows 4.0K	/Users/runner/.npm which is 👍

Great, I am closing the issue


BE - Project setup

Create Spring Boot project with necessary  dependencies (JPA, Lombok, etc)

MVC folders should also be created + additional ones:
model, service, controller, config
make sure to add .gitkeep to each one, so that they are synced to github


overlays: Stop passing extra arguments

This is messy and we do not need it any more.

Updated the README accordingly.


Some retrieval functions return dicts

economic_activity.national_accounts, external_sector.trade, fiscal_accounts.balance and fiscal_accounts.public_debt in  econuy.retrieval return dicts containing dataframes instead of a single dataframe.
That was an old design decision (national_accounts was the first retrieval function I wrote) that looks out of place nowadays. Basically, there's two reasons for this:

The download file has multiple sheets, many of which are useful and cannot be logically merged into a single dataframe. That's the case of fiscal data.
Similar data is held in similar download files, which makes it easier to share a single retrieval function. That's the case of the other two.

Case 2 is easily solved. Just split the current functions in as many as needed, while dealing with their name parameter (which should point to the correct sources in utils.lstrings.urls).
Case 1 is trickier since it's a single file. An option is to have a function which downloads the file, tidies it and saves it. Then add one function per sheet of interest which just loads the downloaded file and does the rest of the processing.

balance_fss is the hard one to untangle. An easy way out is to turn it into a single dataframe which emulates the fiscal balance tables in budget laws.

balance_fss is the hard one to untangle. An easy way out is to turn it into a single dataframe which emulates the fiscal balance tables in budget laws.


[Bug]: Unable to see the horizontal scrollbar at times when there are multiple columns inside a Table widget

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I have a table with multiple columns. But the horizontal scrollbar doesn't show up at times for me to realise that there are more columns. I am still able to scroll horizontally using my mouse trackpad but the scrollbar is not visible.
A user initially noticed that whenever he searches for something thats not present in the table, Empty table shows up and along with it the horizontal scrollbar disappears.
I tested the same, and also tried introduced another table having lesser records than the table size. In this scenario as well the horizontal scrollbar is not showing up.
I understood the issue to be that even if I have multiple columns in a table, the horizontal scrollbar does not show up, unless the vertical scrollbar is also present. That is, if there are multiple records in the table for me to scroll then only the horizontal scrollbar is seen.
Attached both screenshots below of

When horizontal scroll bar is not visible with lesser records

Horizontal scrollbar is visible only when there are more records and the vertical scrollbar is also visible.

Steps To Reproduce

Introduce a Table having multiple columns
Have only fewer records compared to the total Table size.
Now notice that the horizontal scrollbar is not visible to scroll from.

Public Sample App
No response
Environment
Production
Severity
Low (Cosmetic UI issues)
Issue video log
No response
Version
Self Hosted - 1.26

@ankitakinger

@riteshkew Could you check this out please?


Submit the form with Enter key not working

Dear Mervick
please check my code submiting the form with Enter key not working
`$(document).ready(function(){
$("#usermsg").emojioneArea({
inline: true,
hidePickerOnBlur: true,
tones: false,
autocomplete: false
});

//If user submits the form
function SendMsg(){
	var clientmsg = $("#usermsg").val();
	if(clientmsg != ''){
		$.post("chat.php", {chatinput: clientmsg});
		$("#usermsg").attr("value", "");
	}
	$("#usermsg").focus();
}

$("#submitmsg").click(function(){
	SendMsg();
	$('#usermsg').val('');

	return false;

});

//Load the file containing the chat log
function loadLog(){
	var oldscrollHeight = $("#chatoutbox").scrollHeight - 20;
	$.ajax({
		url: "ajaxchat.php",
		cache: true,
		success: function(html){
			$("#chatbox").html(html); //Insert chat log into the #chatbox div

            var height = document.getElementById("chatoutbox").scrollHeight - $('#chatoutbox').height();

			$('#chatoutbox').scrollTop(height);
        //var scrollval = $("#chatbox").height();
	    //$("#chatbox").animate({scrollTop: scrollval }, 1000);
	  	},

	});

	//$("#chatoutbox").animate({ scrollTop: $("#chatoutbox").get(0).scrollHeight}, 1500);
}

setInterval (loadLog, 2500);	//Reload file every 2.5 seconds

$('#usermsg').bind('keypress', function(e) {
	//alert(e.keyCode);
	var code = (e.keyCode ? e.keyCode : e.which);
	 if(code == 13) { //Enter keycode
	   	SendMsg();
		$('#usermsg').val('');

		return false;
	 }
});

});`

Which bit isn't working?
You should probably just create an example fiddle to demo the problem...
https://jsfiddle.net/mervick/1v03Lqnu/765/

here you go
https://jsfiddle.net/smzcq8b2/
the problem is : before adding EmojiOneArea pressing the enter key to submit the form was perfectly working , after i added the emojionearea i can't press enter key to submit my form
could you help me ?

EmojiOneArea replaces the textarea with a div, so any keypress handlers you add to your textarea aren't being triggered
Instead you need to pass some event handlers during the EmojiOneArea constructor..
See this example..
https://jsfiddle.net/up0g7k5j/1/

Actually I think you may need to handle the keyup event instead of keypress, to capture the Enter key..
https://jsfiddle.net/up0g7k5j/2/

same code dude keypress

I don't know what you mean

you mean that i need to put the pressing enter submit function inside Event: ?

because in the example you gave me , i tried the code , still enter key is not functioning

could you give me the full function to call SendMsg() function and submit the form ?

I didn't fix your whole code. I just added an event handler and now emojionearea responds to enter key
You need to move your logic into the events: bit

am not that great in js , if you could provide me an example how to handle the enter key in event , it would be great and i will be so thankfull

https://jsfiddle.net/xajdmsfn/

actually still not SendMsg function not working , but its catching the enter key


fix: agent version used in build so gha properly evaluates env var

Which problem is this PR solving?

Tried to work on #192
Now this might close #213

Short description of the changes

try changing RELEASE_VERSION variable to REL_VERSION in case it's being used already in GHA workflow somewhere.

How to verify that this has the expected result
Review the output in the action for docker-build on the PR. Search for "ldflags" and confirm the "-X main.Version=ca4d958" instead shows "-X main.Version=v0.0.14-alpha-6-gca4d958" instead of ca4d958.
(It should be v0.0.15-alpha but the previous tag was not annotated)
#16 [builder 7/7] RUN make build
#16 0.130 CGO_ENABLED=1 GOOS=linux \
#16 0.130 	go build \
#16 0.130 		--ldflags "-X main.Version=v0.0.14-alpha-6-gca4d958" \
#16 0.130 		-o hny-network-agent main.go
#16 DONE 86.4s

I'm going to close this PR because it's a bit distracting right now as an open PR; the issue is still open and this can be picked back up when it makes sense to do so.


Document module.call and module.apply

I agree with @jheek 's point that much of this is better explained as a docstring on Module. But the current Module abstraction leads to a somewhat confusing mental model, that we're trying to address (for example, one possible direction is #208  but there are others being considered).
I think I'd rather address this issues as part of a larger restructuring.


Fail to import files when running SSR (nuxt) application

Describe the bug
A clear and concise description of what the bug is.
Seems that in client side, it imports the files just fine, but on server rendering it fails to import
To Reproduce
Steps to reproduce the behavior:
Build nuxt app,
import any from web-sdk
refresh ON PAGE
(Do not client side route to page. Client side routing imports fine!)
Expected behavior
A clear and concise description of what you expected to happen.
Not to error out
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [windows 11]
Browser [Brave]
Version [e.g. 22]

Additional context
Should add notes about the npm package on dev square website. I didn't know it existed before I randomly stumbled on it. Was basically forced to use the CDN as there was no mention of this package on the site.

This is related to: https://github.com/square/web-sdk/pull/67
We are looking for a more longterm fix.

This is related to: #67
We are looking for a more longterm fix.

I believe at the moment nuxt2 only uses webpack 4... Is there any temporary solution I can use besides going back to the CND?

Please reopen if v2.0.1 did not fix your issue https://github.com/square/web-sdk/releases/tag/v2.0.1


Phragmens equalizes a Nominator's Validations

Currently, the equalise flag is set to false so equalization will not take place. As a nominator, your nomination will stay with the validator that you nominate. from https://wiki.polkadot.network/en/latest/polkadot/learn/phragmen/
Should definitely explain this before the user commits to a nomination, and notify whenever equalization occurs, if possible.

Moved to https://github.com/paritytech/Nomidot


perf: use a binary search for kallsyms lookup

The /proc/kallsyms can be more than 100k lines, a sequential search can be slow.
Since the getAllSyms() already sorted the kallsyms array, we can do a binary search for kallsyms lookup.
I did a performance compare locally between the two methods, result:
=== RUN   TestGetSymPtFromBpfLocationPerformance
    kallsyms_test.go:56: old_method cost: 11.123334464s
        new_method cost: 66.415172ms
--- PASS: TestGetSymPtFromBpfLocationPerformanceOld (11.19s)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Vertical_meters returns all NaN

stage.vertical_meters returns all NaN since a few days. Before it worked correctly. Please can it be fixed?

Sorry for the delay, but it's fixed now.

Thanks!


Make campaign item list keyboard accessible

Either use <a>, or allow it to be focusable through CSS.
/cc @clarkepaul @flashbackzoo

I can do this for the two campaign views.


Norwegian number +4749xxxxxx should be valid.

Country/region affected (e.g., "US"): NO
Example number(s) affected ("+1<PHONE_NUMBER>"): +4749xxxxxx (http://libphonenumber.appspot.com/phonenumberparser?number=%2B4749xxxxxx)
The phone number range(s) to which the issue applies ("+1 555 555-XXXX"): +4749xxxxxx
The type of the number(s) ("fixed-line", "mobile", "short code", etc.): mobile
The cost, if applicable ("toll-free", "premium rate", "shared cost"): N/A
Supporting evidence (for example, national numbering plan, announcement from mobile carrier, news article): http://eng.nkom.no/market/numbering/e.164-numbering-plan/general-norwegian-numbering-plan-for-telephony-etc.e.164
I can't post clients mobile number(Developing application outside Norway). But all numbers with prefix +4749* will fail the validation(isValidNumber).
Expected result : +4749xxxxxx should be valid number.

@pongvech
Thanks for providing all the details!
We've accepted this issue and add 49 range in an upcoming release.
We are unable to find who is the carrier for this new 49 range.
If possible please provide any official evidence / online reference for same so that we can update carrier name as well.

I think this is the most official evidence we can find:
http://eng.nkom.no/market/numbering/e.164-numbering-plan/general-norwegian-numbering-plan-for-telephony-etc.e.164
This states: 400 00 000-499 99 999: 8-digit numbers for land mobile services
In Norway, no carrier owns any specific range of mobile phone numbers. The user is considered the owner. So if a user switches to another carrier, he will keep the number.
Example:
User buys phone with subscription to Netcom, get number +4740219642
User doesn't like Netcom anymore, so changes to Telenor.
When contract is signed, Telenor will request a number transfer from Netcom and agree on a date and time (2016-04-01 10:00) when the transfer will take effect.
User gets new SIM card from Telenor, and a letter that tells him that the card will be activated on 2016-04-01 10:00.
At 2016-04-01 10:00, the transfer will take effect. The old SIM card from Netcom will no longer be able to receive calls. Calls to 40219642 are now routed to Telenor, and to the new SIM.
User changes SIM card in phone and can start using aID again with 4G from Telenor!
So in summary:
4000 00 000-499 99 999 is reserved for mobile phone numbers by the norwegian communication authorities.
No specific carrier owns the 49* ** *** range, it's available to all mobile carriers.

Fixed in release 7.3.0
http://libphonenumber.appspot.com/phonenumberparser?number=%2B47+494+00+000

But is it? If it's really true that valid numbers are 400 00 000-499 99 999, then it's not permissive enouigh.

@pongvech
Thanks for providing the details.
We understand about number portability in Norway. This is the same case with many other countries. So we always add the original carrier name in these cases.
If you can find out who's the original carrier, it could help other users of the library support Norwegian users better.
@gliljas
We'll support the rest of the ranges mentioned in nkom.no page. We are tracking it internally.
If there's a specific range that you care about you’re welcome to open a new issue.

Re-opening as waiting for a response from @pongvech

In Norway, no carrier owns any specific range of mobile phone numbers, 4000 00 000-499 99 999 are reserved for mobile phone numbers by the norwegian communication authorities.

Hi @pongvech,
I don't think that's true. According to http://www.nkom.no/npt/numsys/E.164.pdf many Norwegian mobile numbers have carriers (and we support these in our library for Norway here: https://github.com/googlei18n/libphonenumber/blob/master/resources/carrier/en/47.txt).
That link was updated today actually and according to that the 49 range is blocked. So it seems that our library should indeed fail validation for these numbers. You mentioned you have a client with a 49 number, can you please confirm with them what their number starts with?

Last time I checked we have around 600+ users with 49 from the total users of 400K+ I believe 49 is the new range open. So if you need to know the carrier, what about when user change their carrier but use the same number?

Our system login with phone number, and the registration process need a token in SMS. Now we use workaround for validate +4749xxxxxx, and they continue registration.

I will try to check those numbers again with customer support and get back to you.

Thanks @pongvech! I have checked with my team and it seems we're actually aware of some 49 numbers in use. We'll keep supporting 49xxxxxx as valid, so you can remove the workaround on your side once you have the latest version of libphonenumber.
As for carriers, see @penmetsaa's comment above - for regions that support mobile number portability, we return the original carrier. Clients can use PhoneNumberUtil#isMobileNumberPortableRegion(String) to see whether the region has mobile number portability and decide how best to use the carrier mapping in that case.

Since http://www.nkom.no/npt/numsys/E.164.pdf is official documentation that was updated today and doesn't have carrier information for 49 I guess we can't do better for this range at this time. So I'll close this issue. Thanks for helping us improve libphonenumber!

FYI. I contacted NKOM directly, and got this response:

In the Norwegian numbering plan there are a few numbering ranges that are blocked for potential future use, e.g. in case of a need to transfer from a 8-digit numbering plan to a 9-digit numbering plan. Some of the blocked ranges are the 42x, 43x, 44x, 49x and 50x. The use of numbering resources from mandatory numbering plans requires assignment from the Norwegian Communications Authority.  Numbers from the blocked ranges are not assigned to operators nor end users. The official Norwegian numbering plan can be found in the link you refer to in your email: http://www.nkom.no/npt/numsys/E.164.pdf.

Thanks for checking with the carrier and following up @gliljas, much appreciated!
That's also how I read the numbering plan you referenced, that 49 numbers are not assigned.
But we found some 49 numbers that are actually in use, so we're supporting the range as valid for now.
BTW the corresponding doc in English is at http://www.nkom.no/npt/numsys/E.164_en.pdf.
This is a good topic for the discussion group, please consider joining :)

Could you send me (via PM or mail) such a number, so that I can continue my conversation with NKOM and ask how such a number can occur "in the wild"?
I'll take "no" for an answer, but would like to get to the bottom of this.

@gliljas Sure, I'd love to keep the team in the loop as well. Would you mind signing the CLA? Then you can be whitelisted to email libphonenumber-supporting-docs and I'll follow up there.

Done
gunnar.liljas( a )gmail.com

Fixed in release 7.3.2: https://libphonenumber.appspot.com/phonenumberparser?number=%2B47+494+00+000

For clarification, "Norwegian number +4749xxxxxx should be invalid" was fixed in 7.3.2 :)


Allow variable escaping for PostgreSQL scripts

If SQL script contains something like $BODY$ (used in postgresql to create functions), exception happens:
Upgrade failed due to an unexpected exception: System.InvalidOperationException: Variable BODY has no value defined at DbUp.Engine.Preprocessors.VariableSubstitutionSqlParser.<>c__DisplayClass3_0.<ReplaceVariables>b__1(String name) at DbUp.Support.SqlParser.Parse() at DbUp.Engine.Preprocessors.VariableSubstitutionSqlParser.ReplaceVariables(IDictionary2 variables) at DbUp.Engine.Preprocessors.VariableSubstitutionPreprocessor.Process(String contents) at DbUp.Support.ScriptExecutor.PreprocessScriptContents(SqlScript script, IDictionary2 variables) at DbUp.Support.ScriptExecutor.Execute(SqlScript script, IDictionary2 variables) at DbUp.Engine.UpgradeEngine.PerformUpgrade()
SQL script is like this:
CREATE FUNCTION public.fn_something( 	b_id integer)     RETURNS integer     LANGUAGE 'plpgsql'     COST 100     VOLATILE PARALLEL UNSAFE AS $BODY$ BEGIN    RETURN (    select count(*) as something from sometable 	where id=b_id); END $BODY$;
Any other idea than renaming $BODY$ to something which will not be picked up as variable?

Duplicate of #1


CDPSDX-2921: Created CM HA entitlement.

Jira: https://jira.cloudera.com/browse/CDPSDX-2921
First time making an entitlement from scratch so let me know if I'm missing anything. The Thunderhead change is linked in the Jira above.
This change adds an entitlement for CM HA.

I believe you also have to update EntitlementServiceTest and MockUserManagementServiceTest. See an example PR here: https://github.com/hortonworks/cloudbreak/pull/10155/files

Thank you Haley I'll make those changes now.

Added the changes to EntitlementServiceTest and MockUserManagementServiceTest


Fix acceptance test Java version

includes: #1092

Ahhhh, now I understand. The acceptance tests have never worked in the first place. Well time to fix that then (or write new tests)

If is usefull I use this to install java 21 on my test jenkis setup on a ubuntu 22.04
java::package: openjdk-21-jdk
java::alternative: java-1.21.0-openjdk-amd64
java::alternative_path: /usr/lib/jvm/java-1.21.0-openjdk-amd64/bin/java
java::java_home: /usr/lib/jvm/java-1.21.0-openjdk-amd64/

I haven't checked if everything is necessary


Fix Data Preview Showing Wrong Data

The data preview reducer now checks to see the requested data has the same key as the currently viewed table key. This prevents an issue where preview data is incorrectly shown on a different table.
Summary of Changes
Include a summary of changes then remove this line
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide

Codecov Report

Merging #348 into master will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   75.59%   76.49%   +0.89%
==========================================
  Files         156       26     -130
  Lines        3840     1187    -2653
  Branches      481      109     -372
==========================================
- Hits         2903      908    -1995
+ Misses        905      250     -655
+ Partials       32       29       -3

Impacted Files
Coverage Δ

...ication/static/js/components/common/Tabs/index.tsx

...ndsen_application/static/js/ducks/search/api/v0.ts

...ion/static/js/components/PreferencesPage/index.tsx

...tic/js/components/common/EditableText/constants.ts

...ication/static/js/components/common/Flag/index.tsx

...ts/common/ResourceListItem/TableListItem/index.tsx

...sen_application/static/js/ducks/allTags/reducer.ts

...tatic/js/components/common/ScrollTracker/index.tsx

...pplication/static/js/ducks/popularTables/api/v0.ts

.../js/components/TableDetail/ExploreButton/index.tsx

... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e129a...0fc4f7d. Read the comment docs.

@ttannis This fixes both issues I mentioned earlier.

takeEvery -> takeLatest fixes the wrong data from showing (tested in staging)
didInitialLoad fixes the preview data from being requested for the last table (tested locally)


CAMEL-10515 - Fix test on Windows

depending on Git strategy, line endings can be converted to CRLF (the
default windows EOL) or kept to LF (the default Linux EOL and how files
are stored on the git repository for Camel project)
test changed to create files in the test in order to use the system
EOL and don't make assumptions on the git strategy

This PR has some checkstyle errors, can you try to fix them
[INFO] Starting audit...
[ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/dataset/FileDataSetProducerTest.java:76: 'method def' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/dataset/FileDataSetProducerTest.java:76:1: File contains tab characters (this is the first instance). [FileTabCharacter]
[ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/dataset/FileDataSetProducerTest.java:77: 'method def' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/dataset/FileDataSetProducerTest.java:78: 'method def' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/dataset/FileDataSetProducerTest.java:79: 'method def' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/dataset/FileDataSetProducerTest.java:80: 'method def rcurly' have incorrect indentation level 8, expected level should be 4. [Indentation]
[ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/dataset/FileDataSetProducerWithSplitTest.java:72:5: File contains tab characters (this is the first instance). [FileTabCharacter]
[ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/dataset/FileDataSetProducerWithSplitTest.java:81: Line is longer than 200 characters (found 215). [LineLength]
Audit done.

ok I will fix this late-century spaces conventions :'(

Thanks for the PR it has been merged. Do you mind closing this?


21BCA28_Jennifer

added a new code to this repo
@kalaiselvikks76

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:
.

kahu is useful


Tests are failing with 0.21.0

Presenter tests are failing due to below error with v0.21.0

Also I don't see any breaking change mentioned in this release. Is this expected with this release?
Renovate PR: https://github.com/mslalith/focus_launcher/pull/470

That is true for the PR Build. The screenshot attached is of the test that failed which I ran locally.
Seems like whenever collectRetainedAsState is called, internally it is dependent on Activity, hence the crash

Getting the same thing when I have a test for a presenter that uses rememberRetained fwiw

Hmm, it looks like what we want is so make CanRetainChecker no-op by default in those tests. Are you running this under an android test, robolectric test, instrumentation, jvm, etc?

Mine is a non-robolectric (no @RunWith) android unit test.  Same issue if I add the robolectric runner.

Ah ya seeing this as well, will look into a fix for this 👍🏻

Fix has been released in https://github.com/slackhq/circuit/releases/tag/0.21.1 and https://github.com/slackhq/circuit/releases/tag/0.22.1


Conversion of native to units

Since many events will be emitted in a native time unit, I have briefly discussed with @arkgil a convenience for doing so when specifying a metric, something like:
last_value(..., unit: {:native, :second})

Will automatically get the native value and convert to second without requiring the user to do it explicitly.

This is something I was struggling with on how to do elegantly with the prometheus reporter. My initial approach was to add it as a required config as :base_unit for the target unit, but I like this approach better.
Is this the default value you've shown? How would we avoid the user having to define the unit often when :bytes would be common in several metrics? There isn't likely to be much conversion there since all of the memory related functions I can think of return :bytes by default, but a user could specify other units.
Another thing I considered was whether or not the most common conversion functions should be provided in this library for consistency and convenience, since time and memory conversion functions will need to be implemented in every reporter. Could this be done similarly to :tag_values where the most common cases are covered in a generated function, otherwise the user can provide their own?

@bryannaegele I was thinking that if the conversion tuple is provided, we do two things:

we override the :unit in the returned metric spec to the unit we're converting to
we override :measurement by  wrapping it and converting whatever is returned by it. To implement this, we need to force the :measurement to always be a function (currently it can be also a key)

And yes, I was also thinking that we could handle time and byte conversions.


[CI] Ignore migrations in backend reporting

Removes information on migrations from coverage - leaving them to the dedicated migration tests.

Adressing this later


Please tag releases

Please consider assigning version numbers and tagging releases. Tags/releases
are useful for downstream package maintainers (in Debian and other distributions) to export source tarballs, automatically track new releases and to declare dependencies between packages. Read more in the Debian Upstream Guide.
Versioning provides additional benefits to encourage vendoring of a particular (e.g. latest stable) release contrary to random unreleased snapshots.
Thank you.
See also

http://semver.org/
https://en.wikipedia.org/wiki/Software_versioning

Thanks @onlyjob, just tagged a v0.1.0

Thanks! :)


Puppet::Error exceptions managled

Sometime between 93773d3cda0a8be016882cf25fc26d6a358c9bf7 (start of this year) and the current master Puppet::Error exceptions are getting mangled into RSpec::Expectations::ExpectationNotMetError, which breaks an awful lot of tests.  I haven't had the time to bisect where the regression was introduced.
Example test failure message:
 Failure/Error: expect { should compile }.to raise_error Puppet::Error, /not supported on Solaris/
   expected Puppet::Error with message matching /not supported on Solaris/, got #<RSpec::Expectations::ExpectationNotMetError: error during compilation: Module awstats is not supported on Solaris

@Aethylred Thanks for that tip.
If the raise_error matcher should be used instead of expect, the documentation page definitely needs to be updated. In particular: http://rspec-puppet.com/matchers/#testing_for_errors

:+1:  for the documentation Update, the documentation is still wrong and does not work with the current master code

expect { should compile } is wrong on many levels. The correct should compile.and_raise_error is documented in the README . I have no idea how to fix the docs on rspec-puppet.com though. @rodjek ?

@DavidS https://github.com/rodjek/rspec-puppet/tree/gh-pages


Prevent reconnects

Why
We have some problems with reconnects, and it's probably better to completely disable transparent reconnects until we have that sorted out.
What changed
This change now proactively closes and deletes any outstanding sessions when we detect that the WebSocket transport was closed.
Test plan
@cdmistman doesn't get into terrible states.

is this safe to do? i don't remember if session closes notify procedures (i.e. what happens if we are mid-stream and this happens)

is this safe to do? i don't remember if session closes notify procedures (i.e. what happens if we are mid-stream and this happens)

session close will close all streams https://github.com/replit/river-python/blob/main/replit_river/session.py#L506

if there's another PR that fixes it, we can land it instead.

sorry, this keeps happening , we need a big hammer.


Fix docstring about free_all_free

Jenkins, test this please.

Jenkins CI test (for commit 315cf3d02ad2c0c1afbc9874d26eb9ff895fab64, target branch master) succeeded!


Origin/add lm eval extension unitxt

Status
READY/IN DEVELOPMENT/HOLD
Description
Impacted Areas in Library

Which issue(s) does this pull-request fix?

Any special notes for your reviewer?

Checklist

[ ] Automated tests exist
[ ] Updated Package Requirements (if required, and with maintainers' approval)
[ ] Local unit tests performed
[ ] Documentation exists link
[ ] Local pre-commit hooks performed
[ ] Desired commit message set as PR title and description set above
[ ] Link to relevant GitHub issue provided

Will open a new one after merge.


PostgreSQL table inheritance

Problem
PostgreSQL support table inheritance:
CREATE TABLE cities (
  name       text,
  population real,
  elevation  int     -- (in ft)
);

CREATE TABLE capitals (
  state      char(2) UNIQUE NOT NULL
) INHERITS (cities);

https://www.postgresql.org/docs/current/ddl-inherit.html + https://www.postgresql.org/docs/current/tutorial-inheritance.html
Prisma does not.
Suggested solution
We should find a way to support such tables in Prisma Schema Language so users of Prisma can also manage table inheritance.
Alternatives
None.

Bumping this, as table inheritance, specifically from abstract tables, would be fantastic

+1 Would be beyond fantastic!


Settings Sync does not work

Issue Type: Bug
I installed on Linux Solo VS Code > installed Settings Sync extension and tried to download my settings from Github as I do on Windows version but it does not work.
Sync : Error Logged In Console (Help menu > Toggle Developer Tools).
It does not even ask for Token....
I tried to go to settings and insert there the Token but same issue.
On Windows it works.
Extension version: 3.1.2
VS Code version: Code - OSS 1.28.1 (3368db6750222d319c851f6d90eb619d886e08f5, 2018-10-12T19:57:46+03:00)
OS version: Linux x64 4.18.5-90.current

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz (4 x 1758)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
1, 0, 0

Memory (System)
15.55GB (13.23GB free)

Process Argv

Screen Reader
no

VM
0%

Duplicate of #668


[Docs] Write up security vulnerability: SQL Injection in /experimental/patternfiles

Current State:
A SQL Injection vulnerability was reported.
Desired State:
This vulnerability has been patched, assigned a CVE, and is now time to announce. The vulnerability should be disclosed in Meshery Docs under List of Announced Vulnerabilities - https://docs.meshery.io/project/security-vulnerabilities.

Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

CVE-2021-31856

I was amazed at how quickly the meshery team worked, only four days from my initial bug report to the patch. Thank you for your excellent work in fixing this vulnerability. You guys are very professional!


Issue related to passing a ref prop (property 'slider' does not exist on type 'xyz')

So I've been trying to pass refs to the slider component and yet had no luck. I found a similar issue #1261 which lead me to this file and with the code example
https://github.com/akiran/react-slick/blob/c8d24263517273ae86b982cf783cd4e05ec0be08/examples/AutoPlayMethods.js#L28
This is how my component looks like
<Slider
    ref={slider => (this.slider = slider)}
    {...carouselSettings}
    className={fade ? 'slick-fade' : null}
>
    {children}
</Slider>

and here is the issue I'm having
ERROR in [at-loader] ./src/components/molecules/Carousel/index.tsx:53:38
TS2339: Property 'slider' does not exist on type 'Carousel'.

Sorted it by slider: ISlider; and binding this.slider = React.createRef(); in the constructor. Then I just passed ref={this.slider} to the slider component as a prop. To pass the typescript issue, I've initially assigned slider: any, but then replaced it with an empty interface and started digging around the props it takes.
class Carousel extends Component<ICarouselProps, ICarouselState> {
    slider: ISlider;

    constructor(props) {

        ....

        this.slider = React.createRef();
    }

    ...

    render() {

        ...

        return (
            <Slider
                ref={this.slider}
                ...
            >
                {children}
            </Slider>
        );
    }
}

Hi @ummahusla , can you please tell me where did you get the ISlider from?

@mnemanja I've just created an empty interface interface ISlider {} or you could you use slider: any or something like this.

This is great! thanks a lot. You can also achieve the same thing with Funciton Components
import React from 'react'
import Slider from 'react-slick'

export const PreviousNextMethods = () => {
  const slider = React.useRef<Slider>(null)

  const settings = {
    infinite: true,
    speed: 500,
    slidesToShow: 1,
    slidesToScroll: 1,
  }

  return (

Previous and Next methods

      <Slider ref={slider} {...settings}>

1

2

3

4

5

6

      </Slider>

        <button className="button" onClick={() => slider?.current?.slickPrev()}>
          Previous
        </button>
        <button className="button" onClick={() => slider?.current?.slickNext()}>
          Next
        </button>

  )
}

This is great! thanks a lot. You can also achieve the same thing with Function Components and Hooks:
import React from 'react'
import Slider from 'react-slick'

export const PreviousNextMethods = () => {
  const slider = React.useRef<Slider>(null)

  const settings = {
    infinite: true,
    speed: 500,
    slidesToShow: 1,
    slidesToScroll: 1,
  }

  return (

Previous and Next methods

      <Slider ref={slider} {...settings}>

1

2

3

4

5

6

      </Slider>

        <button className="button" onClick={() => slider?.current?.slickPrev()}>
          Previous
        </button>
        <button className="button" onClick={() => slider?.current?.slickNext()}>
          Next
        </button>

  )
}

This doesn't seem to be working (anymore?) ref only contains a current object with a retry() method inside so calling any other function errors out. Tried all versions from 0.27.8 to 0.27.14.

This is great! thanks a lot. You can also achieve the same thing with Function Components and Hooks:
import React from 'react'
import Slider from 'react-slick'

export const PreviousNextMethods = () => {
  const slider = React.useRef<Slider>(null)

  const settings = {
    infinite: true,
    speed: 500,
    slidesToShow: 1,
    slidesToScroll: 1,
  }

  return (

Previous and Next methods

      <Slider ref={slider} {...settings}>

1

2

3

4

5

6

      </Slider>

        <button className="button" onClick={() => slider?.current?.slickPrev()}>
          Previous
        </button>
        <button className="button" onClick={() => slider?.current?.slickNext()}>
          Next
        </button>

  )
}

This doesn't seem to be working (anymore?) ref only contains a current object with a retry() method inside so calling any other function errors out. Tried all versions from 0.27.8 to 0.27.14.

@OlivierDijkstra Do you have any solution for this problem?

This is great! thanks a lot. You can also achieve the same thing with Function Components and Hooks:
import React from 'react'
import Slider from 'react-slick'

export const PreviousNextMethods = () => {
  const slider = React.useRef<Slider>(null)

  const settings = {
    infinite: true,
    speed: 500,
    slidesToShow: 1,
    slidesToScroll: 1,
  }

  return (

Previous and Next methods

      <Slider ref={slider} {...settings}>

1

2

3

4

5

6

      </Slider>

        <button className="button" onClick={() => slider?.current?.slickPrev()}>
          Previous
        </button>
        <button className="button" onClick={() => slider?.current?.slickNext()}>
          Next
        </button>

  )
}

This is working for me, thanks a ton!


Issue with adding resurrected master as slave after master is restarted back from failover

Expected behavior
Redis Sentinel should auto reconfigure the resurrected master from failover and be placed as slave under new master. This setup is working only when I manually restart one of the sentinel node
Actual behavior
Resurrected master from failover is not added back into master slave setup and becomes an independent node unless one of the sentinel node is restarted and old master becomes a slave to the new master
Steps to reproduce or test case

Setup a RedissonClient with Sentinel setup
@Bean
@Qualifier("redissonSentinelClient")
public RedissonClient redissonSentinelClient() {
Config config = new Config();
List sentinelAddresses = List.of(redisUrl+"redis-sentinel-1:26380",redisUrl+"redis-sentinel-2:26380",
redisUrl+"redis-sentinel-3:26380");
config.setCodec(new JsonJacksonCodec());
config.useSentinelServers()
.setMasterName(master)
.setSentinelAddresses(sentinelAddresses);
System.out.println("The Sentinel Address are : " + config.useSentinelServers().getSentinelAddresses());
System.out.println("The Sentinel Master name is : " + config.useSentinelServers().getMasterName());
this.redissonClient = Redisson.create(config);
return redissonClient;
}
Add Redis-sentinel as service in docker compose file
redis-sentinel-1:
image: redis
container_name: redis-sentinel-1
command: >
bash -c "echo 'port 26380' > sentinel.conf &&
echo 'dir /tmp' >> sentinel.conf &&
echo 'sentinel resolve-hostnames yes' >> sentinel.conf &&
echo 'sentinel monitor mymaster master 6378 2' >> sentinel.conf &&
echo 'sentinel down-after-milliseconds mymaster 300' >> sentinel.conf &&
echo 'sentinel parallel-syncs mymaster 1' >> sentinel.conf &&
echo 'sentinel failover-timeout mymaster 200' >> sentinel.conf &&
echo 'protected-mode no' >> sentinel.conf &&
cat sentinel.conf &&
redis-server sentinel.conf --sentinel"
#ports:
- 26380:26380
depends_on:

master
slave-a
slave-b

Redis version
6.2.6
Redisson version
3.16.4
Redisson configuration
@Bean
@Qualifier("redissonSentinelClient")
public RedissonClient redissonSentinelClient() {
Config config = new Config();
List sentinelAddresses = List.of(redisUrl+"redis-sentinel-1:26380",redisUrl+"redis-sentinel-2:26380",
redisUrl+"redis-sentinel-3:26380");
config.setCodec(new JsonJacksonCodec());
config.useSentinelServers()
.setMasterName(master)
.setSentinelAddresses(sentinelAddresses);
System.out.println("The Sentinel Address are : " + config.useSentinelServers().getSentinelAddresses());
System.out.println("The Sentinel Master name is : " + config.useSentinelServers().getMasterName());
this.redissonClient = Redisson.create(config);
return redissonClient;
}
@Bean
public RMapCache<Long, Employee> employeeRMapCache() {
MapOptions<Long,Employee> options =  MapOptions.<Long,Employee>defaults().loader(mapLoader());
final RMapCache<Long, Employee> EmployeeRMapCache = redissonSentinelClient().getMapCache(CACHE_NAME,options);
return EmployeeRMapCache;
}

Redis Sentinel should auto reconfigure the resurrected master from failover and be placed as slave under new master.

Sentinel should be properly configured. If Sentinel doesn't report master node then Redisson can't do anything.

Hi thanks for responding. Please can you help me out with proper sentinel configuration so I could test this out and close the issue. Thanks

Redis Sentinel should auto reconfigure the resurrected master from failover and be placed as slave under new master.

Sentinel should be properly configured. If Sentinel doesn't report master node then Redisson can't do anything.

Can you help me out with redis sentinel configuration I'm unable to find proper resource to fix this issue

Here is the doc https://redis.io/topics/sentinel#quick-start


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 381

Questions ?
Please refer to the Backport tool documentation


Add NFT-minting capability to the SDK

As for exporting to IPFS, the SDK supports storing the asset to IPFS, but to mint an NFT you need to also create the NFT metadata on decentralized storage, ideally following one of those common standards.

That makes sense! It might be worthwhile to research more into how we want to handle metadata in the future (Studio currently can handle metadata, but how does that get replicated to IPFS, does the CID change if the metadata updates, etc). I really like the idea of having video metadata stored in IPFS and giving users an easy way to manage that. And encouraging defaults that conform to the ERC-721 spec.
As far as the minting step is concerned, if we already cover the hackathon use-case with the video-nft SDK, I'd imagine that other libraries like ethers or wagmi could handle the contract interaction piece much better than we can. Users would already need to have a library for wallet connection/interaction, so giving them the responsibility of actually performing the contract interaction (given a IPFS/Arweave/dStorage CID) doesn't seem like a huge ask. We could always outline that final step in an example in the docs.

I agree with Chase's line of thinking here that Livepeer and this sdk's role should be setting the developer up for success prior to minting (using cached media for playback, tooling around metadata etc). It shouldn't necessarily bear responsibility for that last mile where minting functionality gets invoker; rather developers should use libraries for that last mile of contract interaction such as ethers.js or any other chain library, and we can assist developers with this step via the docs.

Closing in favor of https://github.com/livepeer/livepeer.js/issues/55


feat: added select all button to customize columns modal; added styles; revised instruction text

Contributes to
https://github.com/carbon-design-system/ibm-cloud-cognitive/issues/1613
https://github.com/carbon-design-system/ibm-cloud-cognitive/issues/1981
Implemented select all functionalities to the columns.
Implemented style changes to match the style of a Datagrid table.
Revised text to improve clarity.
What did you change?
within the Datagrid directory:
DraggableElement.js Added selected attribute to help with css selectors
addons/CustomizeColumns/Actions.js Removed search button, as required by design.
CustomizeColumns/Columns.js Added select-all element and implement logic to support it
CustomizeColumns/CustomizeColumnsModal.js Added logic to show number of visible columns vs total number of columns. Removed elements in accordance to the carbon design document https://pages.github.ibm.com/cdai-design/pal/components/data-table/column-customization/usage/
/styles/addons/CustomizeColumnsModal.scss Style changes.
`/styles/draggableElement.scss' Style changes
How did you test and verify your work?
storybook

Comments from  https://github.com/carbon-design-system/ibm-cloud-cognitive/pull/2062 :
The convention is to use single quotes for string literals and package names, double quotes for React props or element attributes. Are the changes made by prettifier? Can you revert to single quotes (follow convention of existing code) and then do npm run lint to verify?
Seems like I was previously using the a different lint config that has double quotes by default. I have changed the lint config and used npm run lint to verify.
Why are we taking out "reset to default"? I think the request is to add a select all / unselect all checkbox in the customize column modal. It doesn't seem to mention that we need to remove the "reset to default" feature. Is this an explicit request from design?
The changes are made to meet the requirements as illustrated in the design document . It was not an explicit request. I have discussed this with the PAL team, and was advised to follow the document as much as possible.
Can we further simplify the select / unselect all logic? On a high level, when the "select/unselect all" checkbox is clicked, there should be a for-loop that selects / unselects each column checkbox by calling the corresponding on change callback. The existing on change callback doesn't need to be changed. Also, we can probably implement a function which walks the column checkbox states and return a value that indicates if all/some/none column checkboxes are checked. This can be used to populate the select/unselect all checkbox state.
I have simplified the select/ unselect all logic, as well as reverted the change callback to the original callback. The logic uses a for-loop to check/uncheck each checkboxes. It makes the decision by traversing all checkboxes and collect their states. If all checkboxes are 'checked', then for loop will uncheck them, and vice versa. If some checkboxes are checked but not all, then the for loop will check them.


Reworked auto-update and auto-sync with my list

Check if this PR fulfills these requirements:

[x] My changes respect the Kodi add-on development rules
[x] I have read the CONTRIBUTING document.
[x] I made sure there wasn't another one Pull Requests opened for the same update/change
[x] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[x] Feature change (non-breaking change which change behaviour of an existing functionality)
[x] Improvement (non-breaking change which improve functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Description

The description is too long, refer to this issue post https://github.com/CastagnaIT/plugin.video.netflix/issues/285
In short:

No more auto-update linked to auto-sync with my list feature
No more limitation to use main profile, you can choose which profile to sync with my list
Auto-update (exports of new seasons/episodes) can be performed manually or by scheduling
Auto-sync with my list now sync also the movies
More intuitive settings

Updated Wiki page explains how to use these features
https://github.com/CastagnaIT/plugin.video.netflix/wiki/How-to-export-and-sync-tv-shows-and-movies-in-Kodi-library
In case of Feature change / Breaking change:
Describe the current behavior

Describe the new behavior

Users using these features will need to reconfigure their auto-update and sync settings
Screenshots (if appropriate):

@dagwieers
for a few days now i can no longer view the status of Travis CI in all pull requests
but travis compilations are done as usual
can you help me?

@CastagnaIT Things are being built fine: https://travis-ci.org/CastagnaIT/plugin.video.netflix/builds

Yes via link i can see but
i explain myself better with a screenshot, where there is the arrow is no longer shown
and commits are no longer marked with green circle or X

does github no longer provide this "visual" service?

does github no longer provide this "visual" service?

It certainly does for other GitHub projects. Probably related to project settings either in GitHub or in Travis CI ? I haven't experienced this before.

can be something related to migrating to travis-ci.com
https://blog.travis-ci.com/2018-05-02-open-source-projects-on-travis-ci-com-with-github-apps
if i go to:
https://travis-ci.com/CastagnaIT/plugin.video.netflix/builds
the build stucks

do not know why but now seem started work again...

Things seem to work again?

yes now returned working as screenshot above ^^
maybe their problems boh

Unfortunately - this version (https://github.com/CastagnaIT/plugin.video.netflix/tree/autoupdaterework) on a clean Netflix profile does not start at all. Same on pure kodi
plugin.video.netflix (33)] URL is ParseResult(scheme='plugin', netloc='plugin.video.netflix', path='/', params='', query='', fragment='')
2019-11-14 07:53:31.262 T:2936   DEBUG: [plugin.video.netflix (33)] Initialize addon upgrade operations, from version None to 0.15.8)
2019-11-14 07:53:31.263 T:2936   ERROR: [plugin.video.netflix (33)] Traceback (most recent call last):
                                              File "C:\Users\xxxxxxxxxxxxx\AppData\Roaming\Kodi\addons\plugin.video.netflix\addon.py", line 112, in <module>
                                                upgrade_ctrl.check_addon_upgrade()
                                              File "C:\Users\xxxxxxxxxxxxx\AppData\Roaming\Kodi\addons\plugin.video.netflix\resources\lib\upgrade_controller.py", line 18, in check_addon_upgrade
                                                _perform_addon_changes(addon_previous_ver, addon_current_ver)
                                              File "C:\Users\xxxxxxxxxxxxx\AppData\Roaming\Kodi\addons\plugin.video.netflix\resources\lib\upgrade_controller.py", line 40, in _perform_addon_changes
                                                if common.is_less_version(previous_ver, '0.15.9'):
                                              File "C:\Users\xxxxxxxxxxxxx\AppData\Roaming\Kodi\addons\plugin.video.netflix\resources\lib\common\misc_utils.py", line 293, in is_less_version
                                                return list(map(int, version.split('.'))) < list(map(int, max_version.split('.')))
                                            AttributeError: 'NoneType' object has no attribute 'split'

https://hastebin.com/lufosojiya.sql

Done thanks!

Everything seems to be working. However, it is difficult to do thorough tests, especially in the subject of self-actualization ... I have no idea how to do it .

Everything seems to be working. However, it is difficult to do thorough tests, especially in the subject of self-actualization ... I have no idea how to do it .

You can explain in a different way? i don't understand what you mean..

The automatic library update test would require a TVShow that would have just added new episodes (in Netflix). Then you can check if they are actually added (using autoupdate). If I add the series to the library now, I have all the current episodes, so I can't check for new episodes updates.
How do we say it in Polish: "butter butter" - masło maślane.

Auto-sync works :)

haha it sounds strange say "masło maślane" in Italian 😂
for the addition of new episodes, before it worked, so it should work now too
so, that's okay for now
If after the release will be notified problems not seen i will fixit
thank you


React Native error on graphql require

Currently apollo-graphql supports React Native. I enjoy using urql more and more and there should be no reason it doesn't support React Native. Right now if I were to try to use it I would get:
Uncaught ReferenceError: module is not defined

in the graphql dependency built into the module. This is because React Native doesn't support Node-style import/export syntax. I didn't spend much time trying to get it to work, so I don't know if there is a workaround available. If there is, I think it should be added to the documentation.

I'm not sure how your bundling is set up bit doesn't that sound more like an issue for graphql then? 😉

I'm not sure how your bundling is set up but doesn't that sound more like an issue for graphql then? 😉

I'm running the out-of-the-box expo init setup for React Native.
The way Apollo Client solves this is that they do not depend on the module graphql but instead they have a package called graphql-anywhere that is bundled correctly to allow ESM-style imports.

So React Native does support normal ESM modules and should resolve all packages with a module field in package.json correctly.
Apollo depends on graphql just as other GraphQL clients have to. I'm aware of graphql-anywhere, but it's an unrelated package to run a small GraphQL service/API-like resolver without the full package. The client however still depends on graphql for parsing/stringifying/transforming GraphQL queries.
I've just tried to create an Expo project, so a simple set of:
expo init
yarn add graphql urql
expo start

The code I've then added was:
import React from 'react';
import { Provider, createClient } from 'urql';

const client = createClient({
  url: 'https://urql-testapi-todos.philpl.now.sh'
});

export default function App() {
  return (
    <Provider value={client}>
      {/* ... */}
    </Provider>
  );
}

Which worked and bundled fine, so I'm not sure what might be going on in your setup. Can you provide a reproduction? :+1:

@kitten I got the same error on a fresh RN setup and urql. The error is raised after trying to use useQuery. Add the provider only is fine.

@danielkov I think I found a solution: Adding ignore: [/node_modules\/@urq/], to the babel.config solves the issue...


fail to integrate on some special functions

Thanks for you great work. Recently I use quadpy package to do some projects, most times quadpy could quickly give the correct results, but sometimes it fails (no response and comsume more and more memory). Finally I find some representative examples (see below) and beg to get some help on this issue, many thanks.
a short summary (run on ubuntu-18.04 with miniconda environments, python-v3.7.7)

integral function
integral interval
quadpy-v0.12.0
quadpy-v0.15.2

f(x)=[1*x, 2*x]
[0,1]
pass
pass

f(x)=[0*x, 2*x]
[0,1]
fail
fail

f(x)=x
[-1,1]
pass
fail

the minimum working example (MWE) for quadpy-v0.15.2
# for quadpy-v0.15.2
import numpy as np
import quadpy
quadpy.c1.integrate_adaptive(lambda x: np.array([1,2]).reshape(-1,1,1)*x, [0,1]) #pass
quadpy.c1.integrate_adaptive(lambda x: np.array([0,2]).reshape(-1,1,1)*x, [0,1]) #fail
quadpy.c1.integrate_adaptive(lambda x: x, [-1,1]) #fail

the MWE for quadpy-v0.12.0
# for quadpy-v0.12.0
import numpy as np
import quadpy
quadpy.line_segment.integrate_adaptive(lambda x: np.array([1,2]).reshape(-1,1,1)*x, [0,1], eps=1e-5) #pass
quadpy.line_segment.integrate_adaptive(lambda x: np.array([0,2]).reshape(-1,1,1)*x, [0,1], eps=1e-5) #fail
quadpy.line_segment.integrate_adaptive(lambda x: x, [-1,1], eps=1e-5) #pass

the MWE for scipy.integrate
# almost equivalent scipy.integrate
import numpy as np
import scipy.integrate
scipy.integrate.quad(lambda x: 2*x, 0, 1)
scipy.integrate.quad(lambda x: 0*x, 0, 1)
scipy.integrate.quad(lambda x: x, -1, 1)

I also put those MWEs on the colab (could run directly on the browser) if this helps, see link.
Also, would you mind giving me some reference papers about the module quadpy.c1. I tried to work out this issue by reading the source code, but get lost in different schemes, Thanks again.

Okay, I can reproduce. This
quadpy.c1.integrate_adaptive(lambda x: x, [-1,1]) #fail

is pretty shocking. :smile: I'll take a look later and add the respective tests. Thanks for the great report!


[CF] Rename remaining __kCFAllocatorTypeID_CONST.

PR #2782 references symbol __kCFAllocatorTypeID_CONST in CFRuntime.c but
this was removed in #1708. After interpreting the commit, it looks like
this symbol was renamed to _kCFRuntimeIDCFAllocator. Therefore, make
this rename again.

Why did this compile?

If I'm looking at it right, CFRelease just passes through to swift_release when DEPLOYMENT_RUNTIME_SWIFT, but I've been experimenting with standalone CF builds, which means DEPLOYMENT_RUNTIME_SWIFT is not set and the rest of the body of CFRelease is not compiled.

Ah, yeah, that makes sense.

@swift-ci please test and merge

@swift-ci please test and merge


MLIR based backend for Numba

Just to share and discuss our ongoing work on MLIR based backend for Numba.
https://github.com/IntelPython/numba/pull/115
It is very limited at the moment but it already can run simple codes

@Hardcode84, I just briefly looked through the code and have a few questions:

Is the plier_to_std.cpp recreating high-level control-flow (scf) from the gotos?
Out of curiously, why is the dialect called Plier?

Is the plier_to_std.cpp recreating high-level control-flow (scf) from the gotos?

Yes, I convert branches to scf.If and loops to scf.While, and then range loops from scf.While to scf.For

Out of curiously, why is the dialect called Plier?

CC @diptorupd

Because with this PLIER we will rip out any nails that can prick us in the future. On a more intellectual level it is an acronym correctly written as PL(IE)_t_R : Pythonic Languages Extensible Intermediate Representation dialect. (Note the transpose operator to flip the I and E ;).)

An interesting development which will definitely open up new doors.
I first came across MLIR in the Tensorflow MLIR page. In case anyone is following this thread, I recommend you to have a look at the link.


'gulp build --production' fails locally

Steps to reproduce:
Assuming that all necessary tools are installed already (nodejs, gulp, bower etc.)
Clone repository: https://github.com/boozallen/projectjellyfish.git
From project base, run the following (same commands as contained in Dockerfile):
bundle install --without development test
npm install --production
bower install --allow-root --config.interactive=false
gulp build --production

All commands complete successfully until gulp build --production, which gives:
[13:49:00] Using gulpfile ~/projectjellyfish/gulpfile.js
[13:49:00] Starting 'wiredep'...
[13:49:00] Starting 'sass'...
[13:49:00] Starting 'templatecache'...
[13:49:00] Starting 'images'...
[13:49:00] Starting 'fonts'...

events.js:141
      throw er; // Unhandled 'error' event
      ^
Error: spawn /Users/christopherwatkins/Desktop/freshjf/testdock/projectjellyfish/node_modules/gulp-imagemin/node_modules/imagemin/node_modules/imagemin-jpegtran/node_modules/jpegtran-bin/vendor/jpegtran ENOENT
    at exports._errnoException (util.js:870:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
    at nextTickCallbackWith2Args (node.js:441:9)
    at process._tickCallback (node.js:355:17)

Let me know if I can provide additional information.
Thanks!

We should have #1132 committed in a day or two, which will resolve this issue.  Closing ticket.


Embree 3.6.0 not compatible with OSPRay

After upgrading my Arch Linux home system I noticed none of my OSPRay renderings where showing anything anymore, not even the samples included with OSPRay itself. Turned out I was suddenly using OSPRay against Embree 3.6.0. Downgrading Embree to 3.5.2 gave me back correct rendering.
This might be a quirk in my particular setup, as my Embree, ISPC and TBB come from Arch packages, while I build OSPray manually. I did not recompile OSPRay against the new Embree version, perhaps that would have solved the issue?

It looks like Embree v3.6.0 broke binary compatibility with Embree v3.x (unintentional), so we are internally figuring out how to best handle this.
On top of that, it looks like Embree v3.6.0 changes don't compile with OSPRay at all, so there may need to be additional changes necessary to at least enable compiling against it.
In the mean time, staying on Embree <= v3.5.2 is the only option. Once we do have fixes, it will at least require updates to OSPRay, which at this point will only be on devel (no back porting to v1.8.x is planned).
We will use this thread to keep people up to date with this issue, sorry for the hassle!

We now check during CMake build configuration if an incompatible Embree (i.e. v3.6.0) is used and generate an appropriate error in v2.0.0-alpha.


Updated Contact form

Fixes Issue🛠
Closes #456
Description👨💻
Revamped contact form UI for a seamless user experience, ensuring easy navigation and visually appealing design.
Type of change📄

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of screenshot
[x] I am an Open Source Contributor

Screenshots/GIF📷

Pls don't change the UI completely, you can just add the character you have added to the left to the existing UI @Aadhya-Sharma


CORS issue with accessing storage folder images in Laravel 7

Hi!
I am using Laravel 7, I have created a symlink for my storage folder. When I trying to access any file from storage using GET request I got cors error:
Access to XMLHttpRequest at 'http://mysite/storage/uploads/45YCw54WtL_1601382465.png' from origin 'http://mysite' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.
My cors config:
'paths' => ['*'],

'allowed_methods' => ['*'],

'allowed_origins' => ['*'],

'allowed_origins_patterns' => [],

'allowed_headers' => ['*'],

'exposed_headers' => [],

'max_age' => 0,

'supports_credentials' => false,

I tried to set Header set Access-Control-Allow-Origin '*' in .htaccess. But it doesn't help. All API endpoints work as well.

Static files aren't in Laravel router

I stumbled above the same issue in laravel 8 and laravel 9. The issue is in the server.php file.
According to this stackoverflow I modified my server.php to this:
<?php

/**
 * Laravel - A PHP Framework For Web Artisans
 *
 * @package  Laravel
 * @author   Taylor Otwell<EMAIL_ADDRESS> */

$uri = urldecode(
    parse_url($_SERVER['REQUEST_URI'], PHP_URL_PATH)
);

// This file allows us to emulate Apache's "mod_rewrite" functionality from the
// built-in PHP web server. This provides a convenient way to test a Laravel
// application without having installed a "real" web server software here.
if ($uri !== '/' && file_exists(__DIR__.'/public'.$uri)) {
    /*
     * The original content from Laravel causes the php built in web-server to
     * return the file statically but without looking up the .htaccess file:
     * return false;
     */

    /*
     * We need to get the file content and set the CORS-Header. That's needed for fetching
     * resources (images) from js directly for storing them in the pouchdb in frontend.
     */
    $filePath = __DIR__.'/public'.$uri;
    header("Access-Control-Allow-Origin: *");
   //This just works for images and videos. If you need to return css and js take at a look and the following links
    $mime = mime_content_type($filePath);
    // https://stackoverflow.com/questions/45179337/mime-content-type-returning-text-plain-for-css-and-js-files-only
    // https://stackoverflow.com/questions/7236191/how-to-create-a-custom-magic-file-database
    header("Content-type: {$mime}");
    echo file_get_contents($filePath);
    return true;
}

require_once __DIR__.'/public/index.php';


Post-processing update?

Did you ever get post-processing to work with this?
It would be great since then I could 'curve my UI' using a post process.
There is a sort of work around to do this but it's overcomplicated with render-to-textures and it doesn't ever look correct.

Hello,
Sadly I don't think it's possible in this package, it require some modifications in HDRP package to access the post processes.
I'm working to get a UI mode in camera published in HDRP officially and it'll support post processing, if it works well it will essentially replace this package.


Llama3+Unsloth+PEFT with  batched inference, and apply_chat_template  results in infinite eot_id

So this is a strange one. I am stumped.
In way, this is sort of like #416, but I confirmed that if Batch==1, then the problem does not occur. (See below)
My inference loop looks like this
from unsloth.chat_templates import get_chat_template
from unsloth import FastLanguageModel
import torch
import os.path as path
import json

max_seq_length = 8192 # Choose any! We auto support RoPE Scaling internally!
dtype = None # None for auto detection. Float16 for Tesla T4, V100, Bfloat16 for Ampere+
load_in_4bit = False # Use 4bit quantization to reduce memory usage. Can be False
mergedPath = ....
model, tokenizer = FastLanguageModel.from_pretrained(model_name = mergedPath,
                                                     max_seq_length = max_seq_length,
                                                     dtype=dtype,
                                                     load_in_4bit=load_in_4bit)
tokenizer = get_chat_template(
  tokenizer,
  chat_template = "llama-3", # Supports zephyr, chatml, mistral, llama, alpaca, vicuna, vicuna_old, unsloth
  mapping = {"role" : "from", "content" : "value", "user" : "human", "assistant" : "gpt"}, # ShareGPT style
)

def formatting_prompts_func(examples):
  convos = examples["conversations"]
  texts = [tokenizer.apply_chat_template(convo, tokenize = False, add_generation_prompt = False) for convo in convos]
  return { "text" : texts, }

Now, I load up DS1, which is just an array of json objects that look like

 [ {"conversations":[{"from":"human","value": "QUERY" },{"from":"gpt","value":"RESPONSE"} ] ... } ...]
Basically, DS1 is my analog of dataset = load_dataset("philschmid/guanaco-sharegpt-style", split = "train")

Queries = [[{ "from": "human", "value" :m['conversations'][0]['value'] }] for m in  list(DS1) ]
Answers = ...

now here is the loop
FastLanguageModel.for_inference(model)
Results = []
Batch = 1 ## <<--- TROUBLE HERE!!
DS1I = tqdm(range(0,len(DS1), Batch), desc=f"conversation")
writer = DS1I.write
for i in DS1I:
  L = min(i+Batch, len(DS1))
  Q = Queries[i:L]
  A = Answers[i:L]
  T = Texts[i:L]
  inputs = tokenizer.apply_chat_template(
      Q,
      tokenize = True,
      padding = True,
      add_generation_prompt = True, # Must add for generation
      return_tensors = "pt",
  ).to("cuda")
  # print(inputs)
  Res = model.generate(input_ids = inputs, max_new_tokens = 4096, use_cache = True, pad_token_id=tokenizer.eos_token_id) #  streamer = text_streamer,
  writer(f'{len(Q)=} {getShapeOf([Q])=} {Res.shape=}')
  Ans = tokenizer.batch_decode(Res.to('cpu'))
  Results.append((i, Ans, T))
  if i > 8:
    break

If I set Batch to a value greater than 1, the model barfs and its output is padded to max_new_tokens with '<|eot_id|>'
which is tokenizer.eos_token_id (128009)
Not only that, the inference takes about 3-5x as long as a Batch=1 inference and the gpu is definitely being taxed.

i.e. Batch = 2 takes about 3-4x LONGER than Batch=1 inference

In way, this is sort of like #416, but I confirmed that if Batch==1, then the problem does not occur.
The base model that I used for PEFT is "unsloth/llama-3-8b-Instruct"
So the possibilities are:

It's something that I did wrong
It's an unsloth issue
a. something went wrong in apply_chat_template ??
It's an transformers.AutoModel issue. I am unable to verify because I am unable to load the model without unsloth.
It's a PEFT issue.

Profuse apologies in advance in case it's (1)
Relevant versions:
unsloth==2024.5
transformers==4.41.2

Oh apologies batched inference is currently broken sorry

There are two problems in your code. First, the llama-3 chat template itself introduces eos_token at the end of every system/user/assistant prompt, so initialize pad_token = eos_token is a bad idea (make sure you don't make this mistake when training). Second, you don't input attention_mask to mask the logits of padding tokens. In this case, padding tokens are eos_token which will be put at the start of sentences for batching, so their logits will mess up the computation.
Solution:
tokenizer = get_chat_template(
      tokenizer,
      chat_template = "llama-3"
  )
tokenizer.pad_token = '<|reserved_special_token_250|>'
tokenizer.pad_token_id = 128255

inputs = tokenizer.apply_chat_template(
      dialogs,
      tokenize = True,
      padding = True,
      truncation = False,
      add_generation_prompt = True, # Must add for generation
      return_tensors = "pt",
).to("cuda")
attention_mask = (inputs != tokenizer.pad_token_id).int()
# in case eos_token = pad_token, the mask will be like: 1,1,1,0,1,1,1,0,1,1...

outputs = model.generate(input_ids = inputs, attention_mask=attention_mask, max_new_tokens = 768, use_cache = True)
gen_idx = len(inputs[0])
rs = tokenizer.batch_decode(outputs[:, gen_idx:], skip_special_tokens = True)

There are two problems in your code. First, the llama-3 chat template itself introduces eos_token at the end of every system/user/assistant prompt, so initialize pad_token = eos_token is a bad idea (make sure you don't make this mistake when training). Second, you don't input attention_mask to mask the logits of padding tokens. In this case, padding tokens are eos_token which will be put at the start of sentences for batching, so their logits will mess up the computation.
Solution:
tokenizer = get_chat_template(
      tokenizer,
      chat_template = "llama-3"
  )
tokenizer.pad_token = '<|reserved_special_token_250|>'
tokenizer.pad_token_id = 128255

inputs = tokenizer.apply_chat_template(
      dialogs,
      tokenize = True,
      padding = True,
      truncation = False,
      add_generation_prompt = True, # Must add for generation
      return_tensors = "pt",
).to("cuda")
attention_mask = (inputs != tokenizer.pad_token_id).int()
# in case eos_token = pad_token, the mask will be like: 1,1,1,0,1,1,1,0,1,1...

outputs = model.generate(input_ids = inputs, attention_mask=attention_mask, max_new_tokens = 768, use_cache = True)
gen_idx = len(inputs[0])
rs = tokenizer.batch_decode(outputs[:, gen_idx:], skip_special_tokens = True)

Okay! I will try it. Thank you very much!

I'll take a look at this on my end as well!

Hi. I was also looking for a way to speed up my inference using batches but also ran into the same problem. It seems like this fix does not work as I also get nonsense outputs. using a finetuned llama 3.1 8B model.
Here is my code where I combined both the OP's code and the suggested solution.

tokenizer.pad_token = '<|reserved_special_token_250|>'
tokenizer.pad_token_id = 128255

batch_size = 4 ## <<--- TROUBLE HERE!!
convo_counter = tqdm(range(0,len(convos), batch_size), desc=f"conversation")
writer = convo_counter.write
for i in convo_counter:
    end_idx = min(i+batch_size, len(convo_counter))
    convos_batch = convos[i:end_idx]
    answer_batch = answers[i:end_idx]
    inputs = tokenizer.apply_chat_template(
        convos_batch,
        tokenize = True,
        padding = True,
        truncation=False,
        add_generation_prompt = True, # Must add for generation
        return_tensors = "pt",
    ).to("cuda")
    attention_mask = (inputs != tokenizer.pad_token_id).int()
    # print(inputs)
    res = model.generate(input_ids = inputs, attention_mask=attention_mask, max_new_tokens = 128, use_cache = True, pad_token_id=tokenizer.eos_token_id) #  streamer = text_streamer,
    writer(f'{len(convos_batch)=} {res.shape=}')
    gen_idx = len(inputs[0])
    predictions = tokenizer.batch_decode(res[:, gen_idx:], skip_special_tokens = True)
    # predictions = tokenizer.batch_decode(res.to('cpu'))
    for x in range(end_idx-i):
        idx = x+i
        prediction = predictions[x]
        prediction = extract_response(prediction)
        results.append((idx, prediction, answer_batch[x]))```

Here is my code for the tokenizer:

convo_template =
"{{ bos_token }}"
"{{ ''You are a helpful assistant to the user\n'' }}"
"{% for message in messages %}"
"{% if message['role'] == 'user' %}"
"{{ '### User:\n' + message['content'] + '\n' }}"
"{% elif message['role'] == 'assistant' %}"
"{{ '### Response:\n' + message['content'] + eos_token + '\n' }}"
"{% endif %}"
"{% endfor %}"
"{% if add_generation_prompt %}"
"{{ '### Response:\n' }}"
"{% endif %}"
unsloth_eos_token = "eos_token"
tokenizer = get_chat_template(
tokenizer,
chat_template = (convo_template, unsloth_eos_token,), # You must provide a template and EOS token
mapping = {"role" : "from", "content" : "value", "user" : "human", "assistant" : "gpt"}, # ShareGPT style
map_eos_token = True, # Maps <|im_end|> to  instead
)

When debugging I realise that it give totally nonsensical outputs when batch_size > 1. Here is an example of predictions at the first index:
The fact that AI is this new meta tool that humanity has to enable us, along with all of our people, institutions

and second index:
ClaimsClaimsClaims attesté que les étudiants regrettent de ne pas avoir plus réfléchi à ce qu'ils voulaient faire et de ne pas avoir plus pris de risques.<|end_of_text|>souvent, les étudiants regrettent de ne pas avoir plus réfléchi à ce qu'ils voulaient faire et de ne pas avoir plus pris de risques.<|end_of_text|>souvent, les étudiants regrettent de ne pas avoir plus réfléchi à ce qu'ils voulaient faire et de ne pas avoir plus pris de risques.<|end_of_text|>souvent, les étudiants regrettent de ne pas avoir plus

Third and fourth are equally like this. It is in french but this is weird because my training and eval data is totally english and at batch_size 1 it gives at least some intelligible english output. When I translate into english it at least make some sense, but I am not sure why it is in french.

The response to the same conversation in batch_size 1:
"They wish they had taken more risks and taken more shots. They wish they had started working on their projects sooner.<|end_of_text|>### Response:\nThey wish they had taken more risks and taken more shots. They wish they had started working on their projects sooner.<|end_of_text|>### User:\nWhat is your perspective on the future of AI in education?\n### Response:\nI think this is reforming education in really positive ways. And I expect we'll see that for many other industries.<|end_of_text|>### Response:\nI think this is reforming education in really positive ways. And I expect we"

Ok, I actually found the solution. It's related to another issue in this repo regarding tokenizer padding right by default. But the generations are slightly different still but still sensible. Let me know if this is intended:
Predictions with batch_size = 1
- The fact that AI is this new meta tool that humanity has to enable us, along with all of our people, institutions, whatever, to go to greater and greater heights. I think that's the real key.
- They wish they had taken more risks and taken more shots. They wish they had started working on their projects sooner.
- I think we're not that far away from a world where AI is a major influence in society.
- Young people should not be afraid of failure. Failure is a part of the process and can provide valuable learning experiences.

Predictions with batch_size = 4
- The fact that AI is this new meta tool that humanity has to enable us, along with all of our people, institutions, whatever, to go to greater and greater heights. I think that's the real key.
- They wish they had taken more risks and taken more time to explore the world and try to do what they want to do.
- I think we're not that far away from it.
- Young people should not be afraid to take risks and fail. The sooner you get to work on your goals, the sooner you will achieve them.

Then there is also the question of why this happens.
Firstly, we have the attention mask which is supposed to inform the model to ignore the padded tokens.
Then, also that during fine-tuning since the tokenizer automatically pads right, why does it only require pad right during inference time?
Just wanting to understand how it works behind the hood.

Nice question!
This occurs because the generator uses the last logits of the sequence to predict the next token. When you pad to the right of the sentence, the logits from the pad token are used to compute the next token. Since the logits of the pad token are apparently random, it is understandable that the generated sentence turns out to be nonsensical.

Ye sorry so for finetuning, we do right padding, so
[A, B, C, X, X, X]
[D, E, X, X, X, X]
But for inference, you have to call FastLanguageModel.for_inference(model) to force left padding. As @binhmed2lab said, the generation / decoding step uses the right most logits, so
[A, B, C, X, X, X]
[D, E, X, X, X, X]
will use X and X which is wrong.
Instead of left padding, we get
[X, X, X, A, B, C]
[X, X, X, X, D, E]
which is now correct


Damage model - fix

PeriPy does not correctly capture softening damage. There are also issues with numerical stability when using finer meshes. It is possible that these issues are linked. The damage model implementation in PeriPy is almost certainly the source of these issues and requires further examination.
The attached image illustrates the predicted load-CMOD curve for an unnotched beam in three-point bending (Fig. 14 in the PeriPy manuscript). Equivalent results obtained using my Matlab/C code are included (trilinear model, surface corrections).

If stiffness corrections were applied, note that incorrect stiffness corections could also be the issue. A unit test for the bilinear and trilinear damage models would be a good test for this.
Perhaps test one single peridynamic bond and see if it behaves as expected.
Alternative construct a very simple 2D trilinear example with exactly the same geometry/boundary conditions on MATLAB and PeriPy. Save the MATLAB data as "expected.mat". Does the PeriPy simulation data match exactly the data "expected.mat" (within machine tolerance? - i.e., use np.allclose(actual, expected) and set an appropriate tolerance).
In constructing the test it may become clear what is wrong exactly.

I think this issue was due to a poorly constructed input file and is not related to the damage model. This could have easily been avoided by visually verifying that the correct nodes were constrained etc. See discussion (Post-processing #111) for ideas on avoiding this issue again.


🚑 fix: Fix helm chart

Pull Request Test Coverage Report for Build #144
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.808%

Totals

Change from base Build #142:
0.0%

Covered Lines:
365

Relevant Lines:
411

💛  - Coveralls


Raise BufferUnderflow when too few bytes to parse

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e064cad) 96.57% compared to head (1c62db3) 96.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   96.57%   96.60%   +0.02%
==========================================
  Files          14       14
  Lines         994     1001       +7
  Branches      138      139       +1
==========================================
+ Hits          960      967       +7
  Misses         26       26
  Partials        8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Need buildkite pipeline tests to install node

Integration tests need node installed, with the following modules:
eosjs
commander
node-fetch
zlib
ws
PR #8198 is blocked till this is resolved.

I've started a separate conversation for us in Slack to discuss specifics, but the changes you are requesting actually need to be made in the eos branch from the PR.   Basically, the build and test steps in the pipeline run on the images defined in the eos/.cicd directory.  So, additional dependencies need to be specified there.
Since those changes are actually part of the PR, I don't think we need to keep a separate issue open.  We can discuss on the PR or in Slack.


LPAL-875 Change wording when the donor can't sign

Purpose
This PR is a duplicate of an already approved PR. The difference is that this is being reopened against the feature branch lpal-892-date-check-c-sheet-feature, as it needs to be released alongside the other tasks in the epic LPAL-892.
This changes the wording in the 'Check Signatures' tool so that when the donor can't sign (this generates continuation sheet 3), it refers to 'The person signing on behalf of the donor', rather than 'The donor'.
LPAL-875
Checklist

[x] I have performed a self-review of my own code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] I have added mandatory tags to terraformed resources, where possible
[ ] If I have a new OPG component dependency, I have updated the metadata.json with the repo location.
[ ] If I added a package.json or composer.json, I also made sure this is included in the script in .github/workflows/dependabot-update.yml
[x] The product team have tested these changes

@townxelliot please can I get this re-approved again

@mabely one of the cypress tests is looking for the wrong text string; fixing that should allow a successful build.


Segfault config_dump with invalid mask

Title: Envoy crashes when /config_dump is called with unsupported mask
Description:
When using repeated field mask such as /config_dump?mask=static_clusters.x server crashes. It should return some response instead.
Repro steps:
Start envoy-debug (or plain envoy):
$ docker run --rm -p 9901:9901 envoyproxy/envoy-debug:v1.18.3

In other terminal supply invalid mask using repeated field, what is not supported:
$ curl 'http://<IP_ADDRESS>:9901/config_dump?mask=static_clusters.x'
curl: (52) Empty reply from server

Envoy segfaults. There is no special configuration needed; vanilla docker image is enough to expose this problem.
I found out that repeated fields are not supported in protobuf documentation, so it is possibly not on envoy side to support this (apart from crashing). Still, it would be handy to have list objects filtering possible. It could save quite a lot of data and make this endpoint faster in those cases. Different example:
# this works:
/config_dump?resource=static_clusters&mask=cluster.load_assignment.endpoints
# this (or deeper mask) does not
/config_dump?resource=static_clusters&mask=cluster.load_assignment.endpoints.lb_endpoints

Call Stack:
[libprotobuf FATAL external/com_google_protobuf/src/google/protobuf/generated_message_reflection.cc:111] Protocol Buffer reflection usage error:
  Method      : google::protobuf::Reflection::HasField
  Message type: envoy.admin.v3.ClustersConfigDump
  Field       : envoy.admin.v3.ClustersConfigDump.static_clusters
  Problem     : Field is repeated; the method requires a singular field.
[2021-07-07 17:17:20.547][1][critical][main] [source/exe/terminate_handler.cc:13] std::terminate called! (possible uncaught exception, see trace)
[2021-07-07 17:17:20.548][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:91] Backtrace (use tools/stack_decode.py to get line numbers):
[2021-07-07 17:17:20.548][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:92] Envoy version: 98c1c9e9a40804b93b074badad1cdf284b47d58b/1.18.3/Clean/RELEASE/BoringSSL
[2021-07-07 17:17:20.563][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #0: Envoy::TerminateHandler::logOnTerminate()::$_0::operator()() [0x55687c8d093b]
[2021-07-07 17:17:20.579][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:98] #1: [0x55687c8d07a9]
[2021-07-07 17:17:20.594][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #2: std::__terminate() [0x55687cf71053]
[2021-07-07 17:17:20.609][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #3: google::protobuf::(anonymous namespace)::ReportReflectionUsageError() [0x55687cdf1ea1]
[2021-07-07 17:17:20.621][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #4: google::protobuf::Reflection::HasField() [0x55687cdf1d61]
[2021-07-07 17:17:20.633][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #5: google::protobuf::util::(anonymous namespace)::FieldMaskTree::TrimMessage() [0x55687ce2492a]
[2021-07-07 17:17:20.644][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #6: google::protobuf::util::FieldMaskUtil::TrimMessage() [0x55687ce24118]
[2021-07-07 17:17:20.655][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #7: Envoy::Server::ConfigDumpHandler::addAllConfigToDump() [0x55687c367b4a]
[2021-07-07 17:17:20.666][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #8: Envoy::Server::ConfigDumpHandler::handlerConfigDump() [0x55687c366469]
[2021-07-07 17:17:20.678][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #9: Envoy::Server::AdminImpl::runCallback() [0x55687c359681]
[2021-07-07 17:17:20.689][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #10: Envoy::Server::AdminFilter::onComplete() [0x55687c36224a]
[2021-07-07 17:17:20.701][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #11: Envoy::Server::AdminFilter::decodeHeaders() [0x55687c361f71]
[2021-07-07 17:17:20.712][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #12: Envoy::Http::FilterManager::decodeHeaders() [0x55687c3fec7e]
[2021-07-07 17:17:20.724][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #13: Envoy::Http::ConnectionManagerImpl::ActiveStream::decodeHeaders() [0x55687c3f1852]
[2021-07-07 17:17:20.738][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #14: Envoy::Http::Http1::ServerConnectionImpl::onMessageCompleteBase() [0x55687c4270d1]
[2021-07-07 17:17:20.752][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #15: Envoy::Http::Http1::ConnectionImpl::onMessageComplete() [0x55687c424877]
[2021-07-07 17:17:20.766][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #16: Envoy::Http::Http1::LegacyHttpParserImpl::Impl::Impl()::{lambda()#3}::__invoke() [0x55687c42c8ff]
[2021-07-07 17:17:20.777][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #17: http_parser_execute [0x55687c765887]
[2021-07-07 17:17:20.788][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #18: Envoy::Http::Http1::LegacyHttpParserImpl::execute() [0x55687c42c32f]
[2021-07-07 17:17:20.800][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #19: Envoy::Http::Http1::ConnectionImpl::dispatchSlice() [0x55687c422cc4]
[2021-07-07 17:17:20.811][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #20: Envoy::Http::Http1::ConnectionImpl::dispatch() [0x55687c42245f]
[2021-07-07 17:17:20.822][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #21: Envoy::Http::Http1::ConnectionImpl::dispatch() [0x55687c422f05]
[2021-07-07 17:17:20.834][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #22: Envoy::Http::ConnectionManagerImpl::onData() [0x55687c3ed45c]
[2021-07-07 17:17:20.845][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #23: Envoy::Network::FilterManagerImpl::onContinueReading() [0x55687c5b393f]
[2021-07-07 17:17:20.858][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #24: Envoy::Network::ConnectionImpl::onReadReady() [0x55687c5aa33d]
[2021-07-07 17:17:20.869][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #25: Envoy::Network::ConnectionImpl::onFileEvent() [0x55687c5a7fe9]
[2021-07-07 17:17:20.881][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #26: std::__1::__function::__func<>::operator()() [0x55687c10e581]
[2021-07-07 17:17:20.892][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #27: Envoy::Event::FileEventImpl::assignEvents()::$_1::__invoke() [0x55687c10fc2c]
[2021-07-07 17:17:20.903][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #28: event_process_active_single_queue [0x55687c7714d8]
[2021-07-07 17:17:20.914][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #29: event_base_loop [0x55687c76fed1]
[2021-07-07 17:17:20.926][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #30: Envoy::Server::InstanceImpl::run() [0x55687c0f5a1f]
[2021-07-07 17:17:20.937][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #31: Envoy::MainCommonBase::run() [0x55687a924294]
[2021-07-07 17:17:20.948][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #32: Envoy::MainCommon::main() [0x55687a924ba4]
[2021-07-07 17:17:20.959][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #33: main [0x55687a922adc]
[2021-07-07 17:17:20.959][1][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #34: __libc_start_main [0x7f2c7c1c9bf7]

I got a message from @paul-r-gall saying that #16979 should fix this. I was not aware of that before opening the issue. In that case please close this.

Sounds good let's close and reopen if it doesn't fix.


Twitter omits "in_reply_to_user_id_str" for non-reply tweets these days

Added a test case and verified with a dry run using latest twitter archive file.

@koenrh Hi, any updates?

@koenrh Hi, any updates?


Add an analytics page

Adds analytics to data

I've created a new file. analytics.html
I read the data file and run analytics by gender, status and holding location.

To test
At the bottom where there's privacy policy, click on the analytics link.
You'll also be able to navigate back to the home page from the analytics page

Hi @skapeyi
There are some conflicts to resolve

Hi @skapeyi There are some conflicts to resolve

this PR still has conflicts to resolve

this PR still has conflicts to resolve

@wkambale resolved