fix: Small static analysis findings

Context
Hi! Saw you recently added Sonar and wanted to reduce the number of findings; figured I'd see if I could help with a few automated fixes; hope it's appreciated.
I chose to run only a select few recipes, as these had a manageable changeset and hopefully desirable outcomes. Here's a log of what changes were made where.
Changes have been made to plugins/jdks-maven-plugin/build/mavenPlugin/helpMojo/org/jreleaser/jdks/maven/plugin/help/HelpMojo.java by:
    org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to sdks/jreleaser-codeberg-java-sdk/src/main/java/org/jreleaser/sdk/codeberg/CodebergReleaser.java by:
    org.openrewrite.java.cleanup.EqualsAvoidsNull
Changes have been made to core/jreleaser-engine/src/main/java/org/jreleaser/assemblers/JpackageAssemblerProcessor.java by:
    org.openrewrite.java.cleanup.EqualsAvoidsNull
Changes have been made to sdks/jreleaser-git-java-sdk/src/main/java/org/jreleaser/sdk/git/ChangelogGenerator.java by:
    org.openrewrite.java.cleanup.EqualsAvoidsNull
Changes have been made to sdks/jreleaser-gitea-java-sdk/src/main/java/org/jreleaser/sdk/gitea/GiteaReleaser.java by:
    org.openrewrite.java.cleanup.EqualsAvoidsNull
Changes have been made to sdks/jreleaser-gitlab-java-sdk/src/main/java/org/jreleaser/sdk/gitlab/GitlabReleaser.java by:
    org.openrewrite.java.cleanup.EqualsAvoidsNull
Changes have been made to plugins/jreleaser-gradle-plugin/src/main/groovy/org/jreleaser/gradle/plugin/internal/KordampJReleaserAdapter.groovy by:
    org.openrewrite.java.cleanup.IsEmptyCallOnCollections
Changes have been made to api/jreleaser-logger-api/src/main/java/org/jreleaser/logging/AbstractJReleaserLogger.java by:
    org.openrewrite.java.cleanup.EqualsAvoidsNull
Changes have been made to plugins/jreleaser-maven-plugin/build/mavenPlugin/helpMojo/org/jreleaser/maven/plugin/help/HelpMojo.java by:
    org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to api/jreleaser-model-api/src/main/java/org/jreleaser/version/SemanticVersion.java by:
    org.openrewrite.java.cleanup.EqualsAvoidsNull
Changes have been made to api/jreleaser-utils/src/main/java/org/jreleaser/util/CollectionUtils.java by:
    org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to api/jreleaser-utils/src/test/java/org/jreleaser/util/CollectionUtilsTest.java by:
    org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to sdks/jreleaser-webhooks-java-sdk/src/main/java/org/jreleaser/sdk/webhooks/WebhooksAnnouncer.java by:
    org.openrewrite.java.cleanup.EqualsAvoidsNull

If needed I can recreate these changes excluding for instance the EqualsAvoidsNull if that does not fit the desired code style.
As these changes were mostly automated I'm not particularly attached to them, so if you feel it does not improve the project feel free to not accept the contribution; no harmed feelings. :)
Checklist

[x] Review Contribution Guidelines.
[x] Make sure all contributed code can be distributed under the terms of the
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Update documentation when applicable.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks! 😄

Happy to help & hope to see you at some events again this summer. :)

Released in v1.5.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.5.0


"undefined is not a function" upon calling cell.save

Upon calling cell.save() in the Basic Usage example, I get "undefined is not a function" from google-spreadsheet/index.js:629:7.  Should the call to cell.save() pass an argument to the save function?  Thanks.

Yes it takes a callback. See: https://github.com/theoephraim/node-google-spreadsheet#spreadsheetcellsavecallback
The basic usage example is just a quick overview. But I should probably change it to make it more clear!
Thanks


How to install

A simple sentence "You can install Project Manager via Package Control." is not enough on how to install.

A little Google search should lead you to https://packagecontrol.io

Not the point. Install instructions should explain how to install not just say it is installable.

Well,...I may wrongly assume that Package Control is installed for all Sublime Text users.


Disabled debuggers should not enable breakpoints for their languages

Testing https://github.com/microsoft/vscode/issues/133146

Disable a debugger for a language via its when clause
You can still set breakpoints in the UI in files associated with that debugger

Should this be disallowed/removed?

Good point but duplicate of https://github.com/microsoft/vscode/issues/133585


Separate chats are left in LHN after completing task until login/logout

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to NewDot
Create Task
Mark as complete
Repeat steps 2 and 3 several times
Observe task chats are displayed in the bottom of LHN
Logout
Login

Expected Result:
I assume that chats should not be created after step 2 like it is displayed on PR demo video.
But if chats creation is valid then they should disappear after completed. And if they should stay on LHN, then they should not disappear after logout / login
Actual Result:
Chat appear in LHN after task creation. After marking it completed, they move down in LHN. After logout/login chat disappear from LHN
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

Version Number: v1.3.15-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43995119/8a2d5f26-57d7-47ea-b501-bb55a7f868d0
Found When executing PR #18806
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

OOO reassigning!

I can reproduce this and I do think something odd is happening - either tasks need to not show once completed in the LHN or they need to always show.
Found related GH - https://github.com/Expensify/App/issues/18510
cc @thienlnam do you think this is something related to the ^ job?

Yeah this is expected - we should be showing tasks in the LHN now! We have another issue to fix fetching the tasks in the LHN though


Lazy mode in SearchChange

Is there a way add "laziness" on @search-change ?
With Async Select an ajax request is made on every new key input. I'd like to have it when user stops writing. Is it possible ?
Thanks !

Use debounce e.g. https://github.com/kaorun343/vue-property-decorator/pull/134#issuecomment-423424397

Any idea how to implement it with vue-multiselect ? There's no doc.

Answer with Lodash : https://github.com/shentao/vue-multiselect/issues/955


Occasionally the first note plays again right at the end

Very minor bug

Presumably fixed in 1.2.0


fix(HACBS-1385): change prefix for propagated PaC labels & annotations

Signed-off-by: Alex Misstear<EMAIL_ADDRESS>

I'm not sure where it would be best to put, but is it possible to put the label value in some file as a constant so then others can just import and use it? Definitely a nice to have and not required, but it would make for a lot less code change if the value changes again (and remove the requirement for us to all be aligned on this string)


Dynamic Root Elements

I would like to see... 🙋♀🙋♂
Based on our discussion @ijlee2, it might be a useful feature to see the possibility of customizing the root element of the container.
Why and how 💬
How: It looks like this is possible now and is considered stable based on ember-element-helper. The compatibility might be limited to Ember 3.11 and up if the modifier needs to be attached to the element.
Why: Keeping markup semantic and for cases where the markup element is important (possibly for css selectors)

Thanks for writing up the issue, @chadian. I agree that it's important to allow a dynamic tag instead of <div> to facilitate accessibility and semantic HTML.
Because I limited the addon support to Ember 3.16+ (and conjectured that the addon may work for 3.12-3.15), we should be okay with using ember-element-helper to solve the problem.
Potential problem
Today, I read the README and RFC #389 to understand the ramifications of allowing a dynamic tag. The RFC has a section called How we teach this. It suggests that a developer should follow the WAI-ARIA specification (e.g. assign the right role) when changing the tag.
I'm okay with allowing ...attributes to be used to help a developer follow the WAI-ARIA spec, in addition to its original, sole purpose of helping the developer pass class or local-class.
I think, in this addon's README, we will need to add a warning that changing the tag and passing more things (possibly in the right order) to ...attributes should be done with care.
Action items
If you'd like, let's start working on this next week (whenever you are free).
As I don't have much experience with accessibility, I think it'd be good to reach out to the Ember A11y team on Discord (at #topic-a11y channel). I'd like to know:

Can a developer use any tag, or are there tags that we should disallow, in the context of container queries (an element resize)?
Is using ...attributes to allow a developer to pass things to meet WAI-ARIA spec the right Ember Octane way? Or is there an alternative approach that better separates the boundary between the <ContainerQuery> component and the consuming component?

Please let me know what you think and questions that you may have. Thanks again for your help!

Reference(s), mainly for myself so that I don't slack ☺

June 18. Asked questions listed in Action items on #topic-a11y channel.

Thanks for taking the lead on figuring out the accessibility piece to having dynamic root elements. I don't currently have the time to jump in on implementation for at least 3 more weeks but will be watching this issue and will contribute where I can. I am very much looking forward to seeing this land though so I will circle back.

@chadian I think I can work on trying out ember-element-helper next week. Trying to take things easy and not code too much during the covid outbreak. (Trying but failing 🙂)
After merging the PR for this issue, we'll probably want to look at how we can bring a solution back to ember-fill-up.


G

@isaac0731
Thanks for your feedback! We will investigate and update as appropriate.
Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team

@isaac0731
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


[Hybrid script] Backend support

In general, two major things are going in this PR:

A hybrid script text format is supported.
1.1 It has better naming support than the default IRPrinter.
1.2 When designing hybrid script it is for Phase 0 IR, so this dumper cannot be a standalone dumper. You can only use it to dump Phase 0 IR.
Anyone can tell me how to write test cases for this functionality?
A hybrid module will be supported:
1.1 Stores hybrid script as source code.
1.2 Can be used the same as a hybrid script function (both sw emu & hw run).

Minor things:

Hybrid code module refactor:
1.1 util.py & calls.py mainly is in charge of compilation time, and intrinsic.py is renamed to runtime.py to be in charge of hybrid script runtime.
1.2 Redundant api.py is merged to __init.py.
AssertStmt is supported; type cast is supported as it is required by #2420.

@tqchen @xqdan @junrushao1994 @merrymercy @kevinthesun
I think this PR is mature enough.

@Laurawly @vinx13 Anyone can take a look?

@were please consider: 1) support dump for each pass; 2) reload dump as input for any pass

@xqdan

Hmmm. I cannot do arbitrary dumping yet. This is because of HalideIR's design. After flattening, Call/Provide/Realize/Prefetch will be lowered to Load/Store/Allocate/Intrinsic. In term of "text format", they are the same. This is far beyond the scope of this PR.
Dumping all the passes is probably not what you want to do. I want to later figure out a way to specify a specific pass to dump.

A good set of changes. Note that we do not need to make hybrid dump optional. The reason that random and NNPack are optional is that they are linked into the runtime library and have additional dependencies.
Hybrid dump is a compiler feature, that you should add to COMPILER_SRCS by default

@Laurawly please moderate this pr as per https://docs.tvm.ai/contribute/committer_guide.html

@tqchen Done.

change build rule as per my comment

Done.

Thanks @were @junrushao1994 @xqdan, this is now merged


Line comment in parol v2

I'm tring to modify regexs for migrating to parol v2.
Now the regex of line comment is //.*(\r\n|\r|\n|$), but scnr doesn't support $.
How can I handle the line comment without line break at the end of file?

Hi dalance,
I already had the same issue.
My working solution is as follows
//.*(\r\n|\r|\n)?
Also I used your project to test a possible migration to version 2 of parol already.
I could update it and provide you this work as a starting point.
When I've done this I will inform you.

I've updated my fork to latest master version and merged this onto my migration branch.
So this should be in line with the master branch.
You can find the branch in my fork here.
Most tests succeed except tests::diagnostics.
I hope this is nonetheless helpful in any way.

@dalance
I changed the crates/languageserver/src/tests.rs to fit the zero base offsets, i.e. from 16-17 to 15-16.
Now more tests are running and a view more are failing.
I get strange syntax errors, e.g. in  crates/std/veryl/src/async_fifo/async_fifo.veryl
I will analyze these further and fill you in if I have more information.

Modifiying the CommentsTerm this way solves the syntax errors:
((//.*(\r\n|\r|\n)?|/\*([^*]|\*[^/])*\*/)\s*)+
The reason for the errors which ocurred was the fact that multiple comments should be handled by a single terminal. To achieve this also whitespaces after line comments has to be matched. In the cases here whitespaces after the first and before the next comment caused the regex to stop matching.
All tests are succeeding now except the following ones
emitter::test_47_embed
emitter::test_67_cocotb
formatter::test_47_embed
formatter::test_67_cocotb
of which I beleave that the reason is somehow related to the way comments are handled differently now.
I hope the parsing speed is sufficient.
Next I will focus more on increasing the performance of the analysis phase which
Thanks for reporting and good luck!

Thank you for your support! I'll try it.


Find a way to save log files from servers

We often use Terratest to:

Spin up one or more EC2 Instances by running terraform apply.
Wait for those Instances to boot and do something (e.g., form a cluster), usually by executing some sort of code as part of User Data.
Test that the Instances are working correctly.
Tear down the servers.

If the process of spinning up the EC2 Instances fails (step 1), we get an error from Terraform that makes it clear what went wrong. But if step 2 fails, then from the console where we ran terraform apply, we cannot see what wrong. That's because the error happened in the EC2 Instances, and Terraform has no visibility into what's happening with those. This makes it tougher to diagnose a test that failed in CI, as the error log you need is on an EC2 Instance that was already torn down per step 4.
Our best workaround so far is to use the AWS syslog APIs to fetch the most recent data from syslog. However, not all apps write to syslog, and the APIs only give us the last X KB, so important data is often missing.
This issue is to explore the question of, what's the simplest solution we could build to be able to retrieve the log data from EC2 Instances and display it in stdout of the test so the user can diagnose it without having to SSH to the EC2 Instances?

My dream is to have some UI layer that Terratest can stream logs to. Maybe there's even an API where the streams are directed so that logs are persisted and viewable for future builds. But this definitely isn't a simple approach so perhaps this is best as a commercial feature.
A simpler solution for this problem could be to stream logs into a buffer that periodically writes them to S3. One issue is that this needs to be a go routine because if Terratest panics, the logs immediately stop collecting.

My dream is to have some UI layer that Terratest can stream logs to. Maybe there's even an API where the streams are directed so that logs are persisted and viewable for future builds. But this definitely isn't a simple approach so perhaps this is best as a commercial feature.

A UI would be nice. But the key question is, what's the simplest way to get logs off an EC2 Instance? Do we have to update every example to install the CloudWatch log aggregation scripts? Is there something simpler we could run on the EC2 Instances just for testing?

A simpler solution for this problem could be to stream logs into a buffer that periodically writes them to S3. One issue is that this needs to be a go routine because if Terratest panics, the logs immediately stop collecting.

It makes sense to stream logs form the EC2 Instance to S3, but what does Terratest and goroutines have to do with that?

It makes sense to stream logs form the EC2 Instance to S3, but what does Terratest and goroutines have to do with that?

I suppose another approach is to install an agent on your EC2 Instances, but my thought with Terratest is that we write a function that SSH's into the box, tails the desired log files, streams the output to a buffer, and periodically flushes the buffer to S3. Since there would be many logs being streamed at once, each log would be a go routine.

@brikis98 If you want to get the user data off the instance you can use the AWS API.
aws ec2 get-console-output -> documentation
The following is a trick I use to get the logs in a nicer format:
get-logs() {
  aws ec2 get-console-output --instance-id $1 | \
  jq -r '.Output' | \
  awk '{gsub(/\\n/,"\n")}1' | \
  awk '{gsub(/\\r/,"\r")}1'
}

@davidneudorfer Thanks for the pointer, but as mentioned in the bug description, we already have support for console output in the  AWS syslog APIs. Unfortunately, those are limited to 64kb, most of which is noise from the Linux boot sequence. As a result, it misses a lot of the important log info you need.

This was resolved via methods such as FetchContentsOfFileFromInstance.


Refactor edit text widget to fix integer issue

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1718
Description
This PR does the following:

rename "partial" answer to "draft" answer which is a more accurate name
save out-of-range integers as a draft answer and therefore avoid deleting them
remove function displayValidationError as it is no longer suitable for all widgets with draft answers

Alternative(s) considered
NA
Type
Bug fix
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

thanks omar!


Modal-gallery In a Modal

Is it possible to use Modal-gallery in a Modal?
I'm using the BsModalService to generate the modal.
https://valor-software.com/ngx-bootstrap/#/modals
my result as below ->

my expected result is the gallery can cover the full screen,
any suggestions?

This is a good question. I never thought about this scenario.
I'll schedule this for version 4.0.0 or greater.

Thanks for your prompt reply. 👍
I'm looking forward to version 4.0.0.  :)

@daylenlim Hi, can I ask you a small thing?
Do you have a working example of a Modal dialog on https://plnkr.co/ with the latest beta version of ngx-bootstrap 2?
I started to work on this feature, but I need small help, because it is quite difficult.

It could be a good idea to test both ngx-bootstrap 2 and ng-bootstrap (latest releases, also if still beta versions)
If someone want to help me, please provide me two plunkr's examples with these libraries to show modal dialogs. Also, If you want to add angular-modal-gallery inside the dialogs to these examples, it will be really appreciated.
This feature might be quite difficult to implement, so I need help. Otherwise, it will be probably released in future minor versions of angular-modal-gallery 5.x.x and not with 5.0.0.
I'll add every testers and contributors to the official readme of 5.0.0, when released.

I had this issue (an image gallery running from within a modal)
Adding the below to my styles fixed it for me:
.modal.show .modal-dialog { transform:none; }

Interesting  @SeanBreathnach  I'll try it.

Adding the below to my styles

Did you add that css to angular's global style? Or inside the component with the modal gallery?

Interesting I'll try this weekend

Hi @SeanBreathnach which library are you using to create modal dialog?

Fully implemented (branch 800) thanks to angular/cdk and scheduled for 8.0.0-beta.1 that is coming soon.
I close this issue because already done and It will be available in a beta release in some days.


automatically advance the slides every 5 seconds

i think i need to use setTimeout() or something like that?

this is fixed in b7300b73b37a5f6bed3037c9343a42e52ea96d2e


Remove unused function: get_task_id

Description
What is the current behavior?

get_task_id isn't used anywhere apart from tests

Does this introduce a breaking change?
No
Checklist

[x] Created tests which fail without the change (if possible)
[x] Extended the README / documentation, if necessary

@astronomer/dag-authoring-team could one of you please review this


C# _Draw, incorect position on screen!?

Godot version:
3.0 Mono Stable
OS/device including version:
Windows 10 64-bit
NVIDIA Gtx 760
Issue description:
When you draw a circle at certain position (checked the position, and its right) when game starts
the position is not the same!
Steps to reproduce:
create a Navigation2D Node and attach the following
public class NavigationSystem : Navigation2D
{

    private KinematicBody2D owner, target;
    private Vector2[] thePath;

    public override void _Ready()
    {
        try
        {
            owner = GetNode("/root/Main/YSort/Player2") as KinematicBody2D;
            target = GetNode("/root/Main/YSort/Player") as KinematicBody2D;
            thePath = GetSimplePath(owner.GetPosition(), target.GetPosition());
            GD.Print(owner.GetPosition(), thePath);
        }
        catch
        {
            throw new Exception("At NavigationSystem -> Something is null");
        }

    }

    public override void _Draw()
    {
        foreach(Vector2 path in thePath)
        {
            DrawCircle(path, 5f, new Color(255, 0, 0));

        }
    }

Note that _Draw will draw things relative to the node. If the navigation path is in world space (which I assume it is), you should also make sure your Navigation2D is centered at the origin of the world. Or, use SetDrawTransformMatrix to undo local space and draw in global space.

Everything is correctly centered at scene.

Your navigation (and even your whole scene) are not centered at their origin:

This means your drawings have several degrees of bias.
It looks like pathfinding points are in the same space as the Navigation2D node, so your points become aligned if you do this:
DrawCircle(path - Position, 3f, new Color(255, 0, 0));

In theory, there is another way, by writing this at the beginning of _Draw:
            DrawSetTransformMatrix(Transform.AffineInverse());

But I'm surprised that not only doesn't work, but it has the same effect as doing the opposite:
            DrawSetTransformMatrix(Transform);

Me confused.

None of the two options worked

@alexbosquin well they worked for me, if not for you... then send again the project with your changes?

I've tested on another personal project, maybe I need tolearn better how canvas or even draw works!!


Select all in codeblock and delete will show errors

@pftom Hi, this issue is now perfectly resolved in 0.1.x version:

The editure used in tuture has not been updated to latest. Wait for my PR!

@mRcfps Great news, I'm looking forward it


fix: stageAll based on resource group

This PR fixes #96640
The current behavior for stage all + option of CHANGES or Merge CHANGES groups is that it stages all the files in all the groups.
This PR enables the group-wide staging of the files by clicking the group-wide + Stage All Changes option.
Steps to test:
Group-wide stage all.

Create a merge conflict using rebase or merge.
Make changes to any number of files
Should have at least one file each in the groups of source control tab namely CHANGES and 'MERGE CHANGES'.
By clicking on the +  group's stage all option all files in a particular group should be staged.

Repo wide stage all.

Follow the above steps till the 3rd step
Click on horizontal three dots on the source control tab.
By clicking on the Stage All Changes option all files in the repo should be staged irrespective of the resource group.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: swapnilmisal sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Went with https://github.com/microsoft/vscode/pull/97384 instead, thanks anyway!


Create Yasman22 yahaya

ABCD 1234

Yes I yasman i request for it

Yes I yasman i  request for it

How about something like this?
On Sat, Dec 24, 2022, 11:03 PM Yasman @.***> wrote:

Yes I yasman i request for it
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/65#issuecomment-1364588645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A42HG3M3BJIPO3Y2CQUGSXDWO5XLFANCNFSM6AAAAAATIUQ7DE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Make console debug messages be disabled by default

Hi! There are some debug logging in a console. Can it be disabled by default?
The logging might be enabled by passing an option to OAuthModule.forRoot().

What logging messages are you referring to specifically?

For example, there is "refresh tokenResponse..." message with a dump of JWT token and any other console.debug outputs.

the next version of this lib will only show such debug messages when setting the property showDebugInformation to true.


why i can't input command？

why i can't input command？

I observed same issue, with ssh mode. See proper ssh login, but can't input anything.

Interesting project, wait for the new version.

+1

@sorgloomer
Any update here?
Still cannot input any command on the SSH terminal...


Command to create, list, show, update, delete, suspend, and resume applications

Lower level command for application management

useful for testing services.


training on higher res

Can you advise how to change params in order to train on 512?

Thank you for your attention. If you would like to train in latent space, maybe you need to train a 512 VQGAN, or you can just train in pixel space, then you can just modify  configs/Template-BBDM and replace image_size .

thank you for details, I will procees with pixel space, I guess. Have you tried any experiments with higher resolution yourselves?

Actually, we haven't tried with highter resolution due to the computational cost. So, I am curious about the experiment results.

quick update, probably not gonna go with higher resolution for now. Tried 256 for img2img, too much identity change to my taste (e.g.  as compared to pix2pix)

Can you advise how to change params in order to train on 512?

you can donwload such VQGAN ckpt from here. https://ommer-lab.com/files/latent-diffusion/semantic_synthesis.zip
This expects (batchsize, 512,512,3) images and encodes into (batchsize, 3,128,128) size.

Actually, we haven't tried with highter resolution due to the computational cost. So, I am curious about the experiment results.

I'm doing some experiments with 512 x 512 images.
I'll let you know the results. : )

Hi, I'm experimenting with the BBDM model in pixel space using 512x512x1 images for an image enhancement task.
I managed to find a configuration that would let me train the model using 22GB of VRAM. After 1 day of training the results are in the right direction in terms of contrast improvement, but images are very blurry. My understanding is that this is due to the reduced number of filters in the network and the attention heads.
I have a couple of questions also related to issues #46 #27 #8:

The saved models and optimizer are very small (44 and 86 MB), did you know why the memory requirement gets so high?
Did you manage to find a better configuration to work in pixel space or do you know any diffusion-based alternatives for image-to-image translation?

My config:
Brownian Bridge Diffusion Model Template(Pixel Space)
runner: "BBDMRunner"
training:
  n_epochs: 200
  n_steps: 400000
  save_interval: 20
  sample_interval: 2
  validation_interval: 20
  accumulate_grad_batches: 1

testing:
  clip_denoised: True
  sample_num: 1

data:
  dataset_name: ''
  dataset_type: 'custom_aligned'
  dataset_config:
    dataset_path: ''
    image_size: 512
    channels: 1
    to_normal: True
    flip: False
  train:
    batch_size: 1
    shuffle: True
  val:
    batch_size: 1
    shuffle: True
  test:
    batch_size: 1
    # shuffle: False

model:
  model_name: "BrownianBridge" # part of result path
  model_type: "BBDM" # specify a module
  latent_before_quant_conv: False
  normalize_latent: False
  only_load_latent_mean_std: False
  # model_load_path:  # model checkpoint path
  # optim_sche_load_path:  # optimizer scheduler checkpoint path

  EMA:
    use_ema: False
    ema_decay: 0.995
    update_ema_interval: 8 # step
    start_ema_step: 30000

  CondStageParams:
    n_stages: 2
    in_channels: 1
    out_channels: 1

  BB:
    optimizer:
      weight_decay: 0.000
      optimizer: 'Adam'
      lr: 1.e-4
      beta1: 0.9

    lr_scheduler:
      factor: 0.5
      patience: 3000
      threshold: 0.0001
      cooldown: 3000
      min_lr: 5.e-7

    params:
      mt_type: 'linear' # options {'linear', 'sin'}
      objective: 'grad' # options {'grad', 'noise', 'ysubx'}
      loss_type: 'l1' # options {'l1', 'l2'}

      skip_sample: True
      sample_type: 'linear' # options {"linear", "sin"}
      sample_step: 200

      num_timesteps: 1000 # timesteps
      eta: 1.0 # DDIM reverse process eta
      max_var: 1.0 # maximum variance

      UNetParams:
        image_size: 512
        in_channels: 1
        model_channels: 32
        out_channels: 1
        num_res_blocks: 1
        attention_resolutions: !!python/tuple
          - 32
          - 16
          - 8
        channel_mult: !!python/tuple
          - 1
          - 4
          - 8
        conv_resample: True
        dims: 2
        num_heads: 8
        num_head_channels: 64
        use_scale_shift_norm: True
        resblock_updown: True
        use_spatial_transformer: False
        context_dim:
        condition_key: "nocond" # options {"SpatialRescaler", "first_stage", "nocond"}

@frmrz Hi, I'm experimenting with the BBDM model in pixel space using 2562563 images，how can I change params？I hope you can give me some help，thank u


Install chef via knife bootstrap

Chef-server users are accustomed to setting up their machines with knife bootstrap. It would be annoying for veewee to install it differently in its default templates, and only slightly less annoying to have to keep monitoring https://github.com/opscode/chef/blob/master/chef/lib/chef/knife/bootstrap/ for changes.
Unfortunately, knife bootstrap seriously wants to create /etc/chef/validation.pem, /etc/chef/client.rb, and /etc/chef/first-boot.json which aren't useful to baseboxen. So, anyone want to hack knife to separate their templates? Or shall we fake out chef-client with naive credentials and empty run-list and remove them later?
see also: https://github.com/mitchellh/vagrant/issues/#issue/248

Seemed like this might be relevant here?
create a knife plugin for holding alternate bootstrap templates
http://tickets.opscode.com/browse/CHEF-2348


Order of goal icons

Should be:

Social
Environment
Economy

@Vanuatu-National-Statistics-Office/nsdp-platform-team This is resolved now on the homepage.
I have some questions about the "Goals" page: https://vanuatu-national-statistics-office.github.io/vnso-nsdp-platform/goals/

Do you find this page useful? Should we keep it?
If we keep it, do you want this page to use the three vertical pillars (like it is now) or should it use the five-across grid like the homepage?

Team has decided to remove this page.


removes data when cloning data into params.

If params are passed on the first call, once it resends the request
both data and params exists.  Then, both data and params exist. I've added a delete for the data attribute.

Thanks @luislobo!

@mikermcneil No problem! You are welcome


project name noted in instructions differ from the code which is cloned.

the instructions state:
This will be refered as YOUR_PROJECT_NAME throughout the rest of this tutorial. For the instructions on this tutorial, we use the project name: vaccine-solution
KAFKA_NS to the name of the project where you will deploy Strimzi and the solution (vaccine-solution)
YOUR_PROJECT_NAME to the name of the project (vaccine-solution).
However the project name in the cloned repo all refers to jb-sandbox.

I think this one is fixed with vaccine-solution in script too


update with new paligemma2 notebooks

you know some people say they don't believe
google, they have a bobsled t- i mean, a new version of their VLM

I'm gonna go ahead and merge this as all the checks pass now and the model has just been released.


Switch tracing span values to serde_json::Value

Switch tracing span values to serde_json::Value, currently they are all String

Actually it makes more sense to just use a separate collection for each type.


Implement configurable bot activity with 'Message.Style' as default

Thanks for the contribution! While this certainly works it would be better to use viper for this. Viper is used for all configurations in the Go server and both supports env variables as well as config files.

Doesn't work for me

You can now set it with the EMBEDG_DISCORD__ACTIVITY_NAME env var.


Remove vestigial derives

These derives seem to be leftover vestiges of the old renderer.
At least removing them doesn't seem to harm anything.
edit: thanks @forbjok on discord for pointing this out.

bors r+


Followup on https://github.com/dotnet/fsharp/issues/12078

@dsyme I don't know if you meant follow-up like this. If not sorry.
I've tried updating in the test project I described, and it doesn't appear to make any difference, unfortunately.
I'm going to investigate the newer versions, but there's quite a big solution behind this and I'm not sure all of it is going to play nicely with newer .NET versions.
Thanks.

@Benjol I've reopened the issue, let's follow-up there


updated fix/wrap/unwrap

as discussed in team meeting, I have updated the kind synthesis judgement figure to remove tyrec and change the type of tyfix, and have updated the type synthesis judgement figure, changing the wrap and unwrap rules.

I'd have preferred this to have a review from @psygnisfive before merging.


Formatting date time in item template

I have an item template similar to the below

{{Start Time}}

The Start Time data comes from a SharePoint list Date Time field and therefore displays the date according to the ISO 8601 standard i.e. 2011-08-12T20:17:46.384Z.
How do I format this data from within the item template so that it appears as just the time portion, i.e. 20:17?
The formatting part is straightforward if I could use Power App formatting functions, however, I do not seem to be able to use those in the context of the item template and the handlebar notation.
Thanks for the help!

Hi @markpeacock, Did you manage to get this working?

Hi @scottdurow, hi everyone,
I was facing the same issue and got it working using an additional column with the proper formatting. The same approach was used when I was adding user initials to the template, just like in your YouTube tutorials.
However, I was wondering if Handlebars helpers couldn't also be a solution to these formatting issues. I wasn't able to register or implement helpers (by using Handlebars.registerHelper) using the template, though. Any thoughts on this idea?
Thank you very much for your help and also for this amazing component!


K8SPXC-294 HAProxy pods should be restarted on config change

if user edits cr.Spec.HAProxy.Configuration Operator should catch
changes and fix annotations to trigger HAProxy pods restart

Test name
Status

storage
passed

scaling
passed

recreate
passed

big-data
failed

init-deploy
failed

limits
passed

self-healing
failed

scaling-proxysql
passed

restore-to-encrypted-cluster
failed

upgrade
passed

monitoring
passed

demand-backup
failed

self-healing-advanced
failed

upgrade-consistency
passed

security-context
passed

scheduled-backup
failed

operator-self-healing
passed

monitoring-2-0
passed

affinity
passed

demand-backup-encrypted-with-tls
passed

one-pod
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed


Release 0.14.15

Major changes:

New endpoints

GET /v1/files/{file_id}: Retrieve information of a specific file by id
GET /v1/files/{file_id}/content: Retrieve the content of a specific file by id
GET /v1/files/download/{file_id}: Download a specific file by id

llama-core crate

New APIs: remove_file, list_files, retrieve_file, retrieve_file_content, and download_file
(BREAKING) Refactor create_speech API: return the bytes of the generated audio

endpoints crate

Improve the implementation of From<&str> trait for SamplingMethod to support lowercase and uppercase string.

Hello, I am a code review agent on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


bump github.com/DataDog/go-libddwaf/v2 to v3

What does this PR do?
https://github.com/DataDog/datadog-agent/pull/27150 bumped dd-trace-go to the latest version which is using go-libddwaf/v3. To not have to depend on v2 and v3 at the same time in the agent, this PR converts the serverless ASM usage to go-libddwaf/v3.
Motivation
Simplify dependencies.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

The issue mentioned in the github action comment in this PR is a build of libddwaf that can be found here of 2MB. This library is essentially to ASM on serverless.

/merge


Cannot download from RTVE

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar issues including closed ones

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE

Please stop doing whatever youre doing. Also, please provide example URL.

It is my first time. I use Seamonkey and Palemoon.
It seem github does not support those browsers and now I'm using Friefox ESR .

This is the original URL https://www.rtve.es/play/videos/somos-documentales/espana-la-primera-globalizacion-el-camino-espanol/6375606/

First of all, regarding SM/PM you need this: https://github.com/JustOff/github-wc-polyfill

The problem URL at www.rtve.es is a new format not handled by the RTVE extractors. Looking at the page the video won't play and it seems to be DRM-protected.
The DASH manifest confirms that:
<ContentProtection schemeIdUri="urn:mpeg:dash:mp4protection:2011" value="cenc" cenc:default_KID="6A870B94-65AE-454F-AD1B-511AAEE0C878">

The extractor tests aren't all failing, so this isn't being applied retrospectively, or not yet.

The problem URL at www.rtve.es is a new format not handled by the RTVE extractors. Looking at the page the video won't play and it seems to be DRM-protected.
The DASH manifest confirms that:
<ContentProtection schemeIdUri="urn:mpeg:dash:mp4protection:2011" value="cenc" cenc:default_KID="6A870B94-65AE-454F-AD1B-511AAEE0C878">

The extractor tests aren't all failing, so this isn't being applied retrospectively, or not yet.

Thank you.
I will test in the future the website every time youtube-dl is updated-


Unexpected behaviour for fleet adapter template

Required information:
Operating system and version: Ubuntu 20.04
OpenRMF installation type: From source, following install in https://github.com/open-rmf/rmf for galactic
OpenRMF version or commit hash: latest commit, 92972bffbdb3c4e8e4bfb8b1238047d876c07f38
ROS distribution and version: galactic
ROS installation type: from binary
Package or library, if applicable: N/A

Description of the bug:
When the robot starts near a "passthrough point: true", the fleet adapter sends the robot to this point as its holding point. When the robot reaches this point, the fleet adapter node dies.
Furthermore, when you send the robot to the middle of a five way junction, the fleet adapter will also die.
Just some interesting behavior that I noted when testing with @youliangtan, current way to resolve this is to do neither of those things when deploying. Don't have 5 or more way junctions and do not start your robot near passthrough points

Is the junction waypoint also a passthrough waypoint?
The issue has been documented in this ticket. https://github.com/open-rmf/rmf/discussions/173#discussioncomment-3294477
It is a configuration issue as the planner is asked to park (wait) the robot at a passthrough waypoint which does not yield a feasible solution.

The junction is not a passthrough waypoint. Its just a regular waypoint, no additional features.

Are you able to share your building.yaml file with me?


every time ini file creating while doing client run each time which leads to reboot multiple times.

Cookbook version
[Version of the cookbook where you are encountering the issue]
Chef-client version
[Version of chef-client in your environment]
Platform Details
[Operating system distribution and release version. Cloud provider if running in the cloud]
Scenario:
[What you are trying to achieve and you can't?]
Steps to Reproduce:
[If you are filing an issue what are the things we need to do in order to repro your problem? How are you using this cookbook or any resources it includes?]
Expected Result:
[What are you expecting to happen as the consequence of above reproduction steps?]
Actual Result:
[What actually happens after the reproduction steps? Include the error output or a link to a gist if possible.]

I added package_name  option in sql install resource. It is working fine now.


Add support for Conan 2.x

First step towards Conan 2.x support, but need to keep retro-compatibility with 1.x, just in case.

[ ] TODO: Check Conan version and execute supported conan command only.

closes #44

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


caller() doesn't return the proper package name

caller() doesn't return the proper package name

Fixed in v1.023


Please provide guidance on how to handle situations where the reduction in the total number of code steps causes an inability to meet jacoco coverage requirements.

In this PR, I moved a part of the code in AuthZpeClient.java to another library.
As a result, I am no longer able to meet the min code coverage requirement specified by jacoco.
[WARNING] Rule violated for bundle athenz-zpe-java-client: lines covered ratio is 0.8702, but expected minimum is 0.8711

I'm considering adjusting code.coverage.min to an appropriate value to address this issue, but I don't know how to calculate the suitable value.
Could you please explain the calculation method?
This PR is just an example, and I'm struggling with how to handle similar cases in the future.
If you have any other recommended approaches, could you please let me know?

The calculation method is based on what Jacoco reports. So if we removed code and that decreased the percentage, then it reports the value as 0.8702 so that's the value that needs to be used in the pom.xml

alternatively, I usually take this opportunity to add other test cases to increase the code coverage and not decrease it. So I'll take a look at jococo output and see what functions haven't been covered and add test cases for those (even if not part of my PR) and thus increase the code coverage more.

Thank you for your response.

then it reports the value as 0.8702 so that's the value that needs to be used in the pom.xml

We will proceed with the solution you suggested.
Regarding this issue, upon further investigation, we found that the ValidateRokeToken code in AuthZpeClient.java sometimes goes through certain steps and sometimes does not.

We suspect that this is due to conditional branching dependent on the cache state, and we believe that the cache cleanup may be affecting it, although we have not been able to pinpoint the exact cause.
// -Dyahoo.zpeclient.updater.monitor_timeout_secs=1
// -Dyahoo.zpeclient.updater.cleanup_tokens_secs=1

Let's keep this issue open. I actually fixed similar case with another module where we had cache timeouts/cleanup affecting test cases (in that case the test case would actually fail). The correct fix is to provide an interface/api to disable/stop that behavior after the test is complete so it doesn't affect other test cases.


Update instantaneous zenith angle computation

Purpose

[ ] I have read and checked the items on the review checklist.

Replaced by PR https://github.com/CliMA/ClimaAtmos.jl/pull/2358


ng-repeat not working

Hi,
ng-repeat doesn´t work with slick carousel :
https://jsfiddle.net/freddy79/tkmtp5ds/44/
What do i have to do to get it working?
Thx

Looks like you're new to Angular. Use timeout for initiating slick. https://jsfiddle.net/tkmtp5ds/45/


separator/divider

From @gjenner on March 21, 2017 15:23
is it possible to add a divider (or separator) in code rather than HTML?
Copied from original issue: isaacplmann/angular2-contextmenu#58

Kind of, I updated the linked comment to show how to use a dynamic data in code to update the html template.  I think that html should stay in templates.

From @gjenner on March 24, 2017 14:24
Thank you, I have been able to populate in code-behind, but the example of divider does not seem to work.  It allocates the space, but does not show the divider, and is selectable.
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 10:15 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Kind of https://github.com/isaacplmann/angular2-contextmenu/issues/15#issuecomment-252943752 , I updated the linked comment to show how to use a dynamic data in code to update the html template. I think that html should stay in templates.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289033841 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHQfSZpJh-S0dq5N-rXdDHKrpQnotks5ro8_fgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHbVqK5kMC_kQ3z4LHycius9_YShBks5ro8_fgaJpZM4Mj-Fg.gif

I guess I’ll have to actually test my code sample before sharing it.  I’ll having a working example for you soon.

On Mar 24, 2017, at 10:24 AM, gjenner<EMAIL_ADDRESS>wrote:
Thank you, I have been able to populate in code-behind, but the example of divider does not seem to work. It allocates the space, but does not show the divider, and is selectable.
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 10:15 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Kind of https://github.com/isaacplmann/angular2-contextmenu/issues/15#issuecomment-252943752 , I updated the linked comment to show how to use a dynamic data in code to update the html template. I think that html should stay in templates.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289033841 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHQfSZpJh-S0dq5N-rXdDHKrpQnotks5ro8_fgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHbVqK5kMC_kQ3z4LHycius9_YShBks5ro8_fgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289036542, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQOy7GLpbOGmHAc5RIqQPoBfxXGZSks5ro9IggaJpZM4Mj-Fg.

From @gjenner on March 24, 2017 14:38
Thank you so much
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 10:32 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
I guess I’ll have to actually test my code sample before sharing it. I’ll having a working example for you soon.

On Mar 24, 2017, at 10:24 AM, gjenner<EMAIL_ADDRESS>wrote:
Thank you, I have been able to populate in code-behind, but the example of divider does not seem to work. It allocates the space, but does not show the divider, and is selectable.
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 10:15 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Kind of https://github.com/isaacplmann/angular2-contextmenu/issues/15#issuecomment-252943752 , I updated the linked comment to show how to use a dynamic data in code to update the html template. I think that html should stay in templates.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289033841 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHQfSZpJh-S0dq5N-rXdDHKrpQnotks5ro8_fgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHbVqK5kMC_kQ3z4LHycius9_YShBks5ro8_fgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289036542, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQOy7GLpbOGmHAc5RIqQPoBfxXGZSks5ro9IggaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289038551 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHZAC9X2se8VV-RWdw9WTlf1PLF2gks5ro9PEgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHdgBpkna6gQ645OsOm761ktzj5sbks5ro9PEgaJpZM4Mj-Fg.gif

I just updated the demo code in the repo to create a divider like in the linked comment.  It's working in the demo.  What version of bootstrap are you using?  Can you show me what the rendered html looks like when the divider doesn't show correctly?  Did you add [divider]="action.divider" to the contextMenuItem?

From @gjenner on March 24, 2017 14:51
OK, a couple of challenges

  My HTML is just <context-menu></context-menu>, as I push everything in code-behind (I am old school that way)

  When I do add an empty <template [divider]=”action.divider”></template>, I get ‘divider’ is not a known property of ‘template’

Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 10:41 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
I just updated the demo code in the repo to create a divider like in the linked comment. It's working in the demo. What version of bootstrap are you using? Can you show me what the rendered html looks like when the divider doesn't show correctly? Did you add [divider]="action.divider" to the contextMenuItem?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289041291 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHSgNgyCShnHXqcQ1ZSZClU7S0de0ks5ro9XugaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHRIGvmJbVg1fmFVaV8xeSahnV0uPks5ro9XugaJpZM4Mj-Fg.gif

You need to add the contextMenuItem directive to the template element.
<template contextMenuItem [divider]=”action.divider”></template>

That means that action is undefined.  You could statically set [divider]="true" or use all the example code:

Right Click: {{item.name}}

<context-menu>
  <template *ngFor="let action of contextMenuActions" contextMenuItem let-item
    [visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
    (execute)="action.execute($event.item)">
    {{ action.html(item) }}
  </template>
</context-menu>

@Component({
  ...
})
export class MyContextMenuClass {
  public items = [
      { name: 'John', otherProperty: 'Foo' },
      { name: 'Joe', otherProperty: 'Bar' }
  };
  @ViewChild(ContextMenuComponent) public contextMenu: ContextMenuComponent;
  public contextMenuActions = [
        {
          html: (item) => `Say hi!`,
          click: (item) => alert('Hi, ' + item.name)
          enabled: (item) => true,
          visible: (item) => item.type === 'type1',
        },
        {
          divider: true,
          visible: true,
        },
        {
          html: (item) => `Something else`,
          click: (item) => alert('Or not...'),
          enabled: (item) => false,
          visible: (item) => item.type === 'type1',
        },
      ];
}

From @gjenner on March 24, 2017 14:58
Thank you for your patience.  Cannot read property ‘divider’ pf undefined
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 10:53 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
You need to add the contextMenuItem directive to the template element.
<template contextMenuItem [divider]=”action.divider”>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289044770 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHQwdVBSdTp3sYjDo19hm4tfA55Lgks5ro9jAgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHQh3dIfbipP8_wwu84dFm19PE3-kks5ro9jAgaJpZM4Mj-Fg.gif

From @gjenner on March 24, 2017 15:15
Just so close.  I just find all of the data logic in HTML difficult to debug.  I added the [divider]=”true”, [visible]=”true” [enabled]=”true”
My items are now not visible
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:01 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
That means that action is undefined. You could statically set [divider]="true" or use all the example code:

Right Click: {{item.name}}

@Component({
  ...
})
export class MyContextMenuClass {
  public items = [
      { name: 'John', otherProperty: 'Foo' },
      { name: 'Joe', otherProperty: 'Bar' }
  };
  @ViewChild(ContextMenuComponent) public contextMenu: ContextMenuComponent;
  public contextMenuActions = [
        {
          html: (item) => `Say hi!`,
          click: (item) => alert('Hi, ' + item.name)
          enabled: (item) => true,
          visible: (item) => item.type === 'type1',
        },
        {
          divider: true,
          visible: true,
        },
        {
          html: (item) => `Something else`,
          click: (item) => alert('Or not...'),
          enabled: (item) => false,
          visible: (item) => item.type === 'type1',
        },
      ];
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289047401 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHYmiXtzk2AirgrdM_ByOqxE4G72uks5ro9rJgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHa5SVmqslYncK6-YIV9zqvjLzB7Nks5ro9rJgaJpZM4Mj-Fg.gif

Can you post your entire html snippet?

From @gjenner on March 24, 2017 15:30
Made item [visible]=>true, fixed that, but still no visible divider and it is selectable, sorry
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:01 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
That means that action is undefined. You could statically set [divider]="true" or use all the example code:

Right Click: {{item.name}}

@Component({
  ...
})
export class MyContextMenuClass {
  public items = [
      { name: 'John', otherProperty: 'Foo' },
      { name: 'Joe', otherProperty: 'Bar' }
  };
  @ViewChild(ContextMenuComponent) public contextMenu: ContextMenuComponent;
  public contextMenuActions = [
        {
          html: (item) => `Say hi!`,
          click: (item) => alert('Hi, ' + item.name)
          enabled: (item) => true,
          visible: (item) => item.type === 'type1',
        },
        {
          divider: true,
          visible: true,
        },
        {
          html: (item) => `Something else`,
          click: (item) => alert('Or not...'),
          enabled: (item) => false,
          visible: (item) => item.type === 'type1',
        },
      ];
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289047401 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHYmiXtzk2AirgrdM_ByOqxE4G72uks5ro9rJgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHa5SVmqslYncK6-YIV9zqvjLzB7Nks5ro9rJgaJpZM4Mj-Fg.gif

Don't apologize, you're helping me make the library more robust.  But I do need more of your code to help diagnose the problem.

From @gjenner on March 24, 2017 15:50
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:39 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Don't apologize, you're helping me make the library more robust. But I do need more of your code to help diagnose the problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289058413 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHQDTsvlLI9lWmEr1scSPMFYjFlKtks5ro-ObgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHXNvdQeR9IQt1tzrkguJmKzGliEnks5ro-ObgaJpZM4Mj-Fg.gif

.angular2-contextmenu .dropdown-menu {
border: solid 1px #aaa;
// background-color: #fff;
background-color: #fff;
padding: 0;
}
.angular2-contextmenu li {
display: block; // border-top: solid 1px #bbb;
text-align: left;
height: 28px;
}
.angular2-contextmenu li:first-child {
border-top: none;
}
.angular2-contextmenu a {
color: #000;
display: block;
padding: 0.5em 1em;
}
.angular2-contextmenu a:hover {
color: #000;
background-color: #ddd;
}
ul.dropdown-menu {
position: fixed;
display: block;
left: 0px;
top: 0px;
}
.dropdown-menu .divider {
height: 1px;
margin: 9px 0;
overflow: no;
background-color: #eee;
}
if (this.objAppointmentSelectedResult.AppointmentDetailID !== 0) {
for (let i = 0; i < this.objApptStatuses.length; i++) {
//ToDo need to include ID
let cd: CodeDescription = new CodeDescription;
cd.Code = eventData.colDef.field;
cd.Description = this.objApptStatuses[i].Description;
cd.IDENTITY = this.objApptStatuses[i].AppointmentStatusTypeID;
let cmMenuItem: any = {};
cmMenuItem = {
html: () => cd.Description,
visible: () => true,
click: () => {
// console.log(cd, $event);
// alert(cd.Description);
this.ContextMenuItemSelected(eventData.colDef.field, cd);
}
};
this.cmMenuItems.push(cmMenuItem);
if (i == 3) {
let cmDivider: any = { divider: () => true, visible: () => true, enabled: () =>true };
this.cmMenuItems.push(cmDivider);
let cmDivider2: any = { divider: () => true, visible: () => true, enabled: () =>true };
this.cmMenuItems.push(cmDivider2);
};
};
};

Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor.  Like this:
<context-menu #cmNew>
  <template *ngFor="let action of cmMenuItems" contextMenuItem let-item
    [visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
    (execute)="action.execute($event.item)">
    {{ action.html(item) }}
  </template>
</context-menu>

From @gjenner on March 24, 2017 16:20
This was working great, except the divider, now back to “cannot read property ‘divider’ of undefined
And since it is in HTML, cannot debug easily.  Not a fan of HTML, my last program was Silverlight, loved it
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:57 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor. Like this:
<context-menu #cmNew>
<template *ngFor="let action of cmMenuItems" contextMenuItem let-item
[visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
(execute)="action.execute($event.item)">
{{ action.html(item) }}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289063706 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHW_Lm0-UMiP726itXLH5-eRFypH4ks5ro-fTgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHV1i_HxXvSUPwU8y34QVfejoDdA-ks5ro-fTgaJpZM4Mj-Fg.gif

From @gjenner on March 24, 2017 16:30
Each object is
click: ()
divider: ()
enabled: ()
html: ()
visible: ()
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 12:23 PM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Do a console.log of your cmMenuItems and check if there’s an item in the array that is null.

On Mar 24, 2017, at 12:20 PM, gjenner<EMAIL_ADDRESS>wrote:
This was working great, except the divider, now back to “cannot read property ‘divider’ of undefined
And since it is in HTML, cannot debug easily. Not a fan of HTML, my last program was Silverlight, loved it
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:57 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor. Like this:
<context-menu #cmNew>
<template *ngFor="let action of cmMenuItems" contextMenuItem let-item
[visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
(execute)="action.execute($event.item)">
{{ action.html(item) }}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289063706 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHW_Lm0-UMiP726itXLH5-eRFypH4ks5ro-fTgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHV1i_HxXvSUPwU8y34QVfejoDdA-ks5ro-fTgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070423, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQMansUbaJ-jSIFE8ao1bIEHIfoCOks5ro-1pgaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070867 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHcmhMTopUfj-Ag-9qjGT1hkmmyGNks5ro-3OgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHcAJREhPXA-Zr_umoNcMQle2iu3Aks5ro-3OgaJpZM4Mj-Fg.gif

Do a console.log of your cmMenuItems and check if there’s an item in the array that is null.

On Mar 24, 2017, at 12:20 PM, gjenner<EMAIL_ADDRESS>wrote:
This was working great, except the divider, now back to “cannot read property ‘divider’ of undefined
And since it is in HTML, cannot debug easily. Not a fan of HTML, my last program was Silverlight, loved it
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:57 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor. Like this:
<context-menu #cmNew>
<template *ngFor="let action of cmMenuItems" contextMenuItem let-item
[visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
(execute)="action.execute($event.item)">
{{ action.html(item) }}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289063706 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHW_Lm0-UMiP726itXLH5-eRFypH4ks5ro-fTgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHV1i_HxXvSUPwU8y34QVfejoDdA-ks5ro-fTgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070423, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQMansUbaJ-jSIFE8ao1bIEHIfoCOks5ro-1pgaJpZM4Mj-Fg.

From @gjenner on March 24, 2017 16:39
Missed part of my previous code behind
if (this.cmMenuItems.length !== 0) {
  this.contextMenuService.show.next({

    // Optional - if unspecified, all context menu components will open

    contextMenu: this.cmNew,

    actions: this.cmMenuItems,

    event: me,

    item: this.objAppointmentSelectedResult,

  });

Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 12:23 PM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Do a console.log of your cmMenuItems and check if there’s an item in the array that is null.

On Mar 24, 2017, at 12:20 PM, gjenner<EMAIL_ADDRESS>wrote:
This was working great, except the divider, now back to “cannot read property ‘divider’ of undefined
And since it is in HTML, cannot debug easily. Not a fan of HTML, my last program was Silverlight, loved it
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:57 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor. Like this:
<context-menu #cmNew>
<template *ngFor="let action of cmMenuItems" contextMenuItem let-item
[visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
(execute)="action.execute($event.item)">
{{ action.html(item) }}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289063706 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHW_Lm0-UMiP726itXLH5-eRFypH4ks5ro-fTgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHV1i_HxXvSUPwU8y34QVfejoDdA-ks5ro-fTgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070423, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQMansUbaJ-jSIFE8ao1bIEHIfoCOks5ro-1pgaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070867 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHcmhMTopUfj-Ag-9qjGT1hkmmyGNks5ro-3OgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHcAJREhPXA-Zr_umoNcMQle2iu3Aks5ro-3OgaJpZM4Mj-Fg.gif

Just remove the actions property of the this.contextMenuService.show call.  You’re already specifying the actions in the html template.
this.contextMenuService.show.next({
// Optional - if unspecified, all context menu components will open
contextMenu: this.cmNew,
event: me,
item: this.objAppointmentSelectedResult,
});

On Mar 24, 2017, at 12:39 PM, gjenner<EMAIL_ADDRESS>wrote:
This all worked well, except for the divider
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 12:23 PM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Do a console.log of your cmMenuItems and check if there’s an item in the array that is null.

On Mar 24, 2017, at 12:20 PM, gjenner<EMAIL_ADDRESS>wrote:
This was working great, except the divider, now back to “cannot read property ‘divider’ of undefined
And since it is in HTML, cannot debug easily. Not a fan of HTML, my last program was Silverlight, loved it
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:57 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor. Like this:
<context-menu #cmNew>
<template *ngFor="let action of cmMenuItems" contextMenuItem let-item
[visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
(execute)="action.execute($event.item)">
{{ action.html(item) }}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289063706 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHW_Lm0-UMiP726itXLH5-eRFypH4ks5ro-fTgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHV1i_HxXvSUPwU8y34QVfejoDdA-ks5ro-fTgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070423, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQMansUbaJ-jSIFE8ao1bIEHIfoCOks5ro-1pgaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070867 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHcmhMTopUfj-Ag-9qjGT1hkmmyGNks5ro-3OgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHcAJREhPXA-Zr_umoNcMQle2iu3Aks5ro-3OgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289075548, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQDi2Gmovsm1yloJung-1SSy_7II7ks5ro_HXgaJpZM4Mj-Fg.

From @gjenner on March 24, 2017 16:39
This all worked well, except for the divider
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 12:23 PM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Do a console.log of your cmMenuItems and check if there’s an item in the array that is null.

On Mar 24, 2017, at 12:20 PM, gjenner<EMAIL_ADDRESS>wrote:
This was working great, except the divider, now back to “cannot read property ‘divider’ of undefined
And since it is in HTML, cannot debug easily. Not a fan of HTML, my last program was Silverlight, loved it
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:57 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor. Like this:
<context-menu #cmNew>
<template *ngFor="let action of cmMenuItems" contextMenuItem let-item
[visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
(execute)="action.execute($event.item)">
{{ action.html(item) }}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289063706 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHW_Lm0-UMiP726itXLH5-eRFypH4ks5ro-fTgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHV1i_HxXvSUPwU8y34QVfejoDdA-ks5ro-fTgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070423, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQMansUbaJ-jSIFE8ao1bIEHIfoCOks5ro-1pgaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070867 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHcmhMTopUfj-Ag-9qjGT1hkmmyGNks5ro-3OgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHcAJREhPXA-Zr_umoNcMQle2iu3Aks5ro-3OgaJpZM4Mj-Fg.gif

From @gjenner on March 24, 2017 17:45
It would not even display when I did that
I do appreciate your valuable time, but I am going to revert to where I was this morning and revisit it another day, but again, thank you
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 1:32 PM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Just remove the actions property of the this.contextMenuService.show call. You’re already specifying the actions in the html template.
this.contextMenuService.show.next({
// Optional - if unspecified, all context menu components will open
contextMenu: this.cmNew,
event: me,
item: this.objAppointmentSelectedResult,
});

On Mar 24, 2017, at 12:39 PM, gjenner<EMAIL_ADDRESS>wrote:
This all worked well, except for the divider
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 12:23 PM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Do a console.log of your cmMenuItems and check if there’s an item in the array that is null.

On Mar 24, 2017, at 12:20 PM, gjenner<EMAIL_ADDRESS>wrote:
This was working great, except the divider, now back to “cannot read property ‘divider’ of undefined
And since it is in HTML, cannot debug easily. Not a fan of HTML, my last program was Silverlight, loved it
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:57 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor. Like this:
<context-menu #cmNew>
<template *ngFor="let action of cmMenuItems" contextMenuItem let-item
[visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
(execute)="action.execute($event.item)">
{{ action.html(item) }}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289063706 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHW_Lm0-UMiP726itXLH5-eRFypH4ks5ro-fTgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHV1i_HxXvSUPwU8y34QVfejoDdA-ks5ro-fTgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070423, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQMansUbaJ-jSIFE8ao1bIEHIfoCOks5ro-1pgaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070867 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHcmhMTopUfj-Ag-9qjGT1hkmmyGNks5ro-3OgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHcAJREhPXA-Zr_umoNcMQle2iu3Aks5ro-3OgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289075548, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQDi2Gmovsm1yloJung-1SSy_7II7ks5ro_HXgaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289090267 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHRVSi9NunUapoW8hVtALtS79H13vks5ro_4qgaJpZM4Mj-Fg .  https://github.com/notifications/beacon/AYwRHbh-OqxpH8o_JnYzFXt6mGC2JxPIks5ro_4qgaJpZM4Mj-Fg.gif

From @symbyte on March 27, 2017 0:28
I feel like I'm experiencing something similar. Using I'm trying to use the following markup to place a divider in an already existing and functioning context menu:
    <template contextMenuItem divider="true"> </template>

At first, I was trying to use the attribute binding syntax ([divider]="true"), but was being given the angular template compiler error that divider isn't a known property of template. I then removed the brackets and am getting an empty, unstyled, anchor tag placed in the menu.
The rendered output of the divider:

and it looks like:

Any Idea whats going on here?

Ok.  You’re welcome. Let me know if you want to give it a try again.

On Mar 24, 2017, at 1:46 PM, gjenner<EMAIL_ADDRESS>wrote:
It would not even display when I did that
I do appreciate your valuable time, but I am going to revert to where I was this morning and revisit it another day, but again, thank you
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 1:32 PM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Just remove the actions property of the this.contextMenuService.show call. You’re already specifying the actions in the html template.
this.contextMenuService.show.next({
// Optional - if unspecified, all context menu components will open
contextMenu: this.cmNew,
event: me,
item: this.objAppointmentSelectedResult,
});

On Mar 24, 2017, at 12:39 PM, gjenner<EMAIL_ADDRESS>wrote:
This all worked well, except for the divider
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 12:23 PM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Do a console.log of your cmMenuItems and check if there’s an item in the array that is null.

On Mar 24, 2017, at 12:20 PM, gjenner<EMAIL_ADDRESS>wrote:
This was working great, except the divider, now back to “cannot read property ‘divider’ of undefined
And since it is in HTML, cannot debug easily. Not a fan of HTML, my last program was Silverlight, loved it
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Friday, March 24, 2017 11:57 AM
To: isaacplmann/angular2-contextmenu
Cc: gjenner; Author
Subject: Re: [isaacplmann/angular2-contextmenu] separator/divider (#58)
Your html template should create a contextMenuItem for each item in the cmMenuItems array using *ngFor. Like this:
<context-menu #cmNew>
<template *ngFor="let action of cmMenuItems" contextMenuItem let-item
[visible]="action.visible" [enabled]="action.enabled" [divider]="action.divider"
(execute)="action.execute($event.item)">
{{ action.html(item) }}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289063706 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHW_Lm0-UMiP726itXLH5-eRFypH4ks5ro-fTgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHV1i_HxXvSUPwU8y34QVfejoDdA-ks5ro-fTgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070423, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQMansUbaJ-jSIFE8ao1bIEHIfoCOks5ro-1pgaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289070867 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHcmhMTopUfj-Ag-9qjGT1hkmmyGNks5ro-3OgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHcAJREhPXA-Zr_umoNcMQle2iu3Aks5ro-3OgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289075548, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQDi2Gmovsm1yloJung-1SSy_7II7ks5ro_HXgaJpZM4Mj-Fg.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289090267 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHRVSi9NunUapoW8hVtALtS79H13vks5ro_4qgaJpZM4Mj-Fg . https://github.com/notifications/beacon/AYwRHbh-OqxpH8o_JnYzFXt6mGC2JxPIks5ro_4qgaJpZM4Mj-Fg.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/58#issuecomment-289094646, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQKlBa-pBQXhU-zycI1ISvRvF2v-qks5rpAFXgaJpZM4Mj-Fg.

@symbyte using divider="true" will set the divider property to the string "true".  Using [divider]="true" is correct.  You'll get that template compiler error if you forget to include the contextMenuItem directive on the <template> element.
It should look like this:
<template contextMenuItem [divider]="true"></template>

Does that work?

From @symbyte on March 28, 2017 13:9
As noted above, I did include the contextMenuItem directive on the template element. Here's the error message that angular produces:
zone.js:420 Unhandled Promise rejection: Template parse errors:
Can't bind to 'divider' since it isn't a known property of 'template'. ("
    </template>

    <template contextMenuItem [ERROR ->][divider]="true"></template>

    <template

I have, as far as I know, imported the module correctly because everything else works as expected.
Here is my full context menu section of the template for reference:

  <context-menu #contextMenu>
    <template
        contextMenuItem
        let-item
        (execute)="moveToTop($event)"
      >
      Send {{item?.label}} To Top
    </template>

    <template
        contextMenuItem
        let-item
        (execute)="moveToBottom($event)"
      >
      Send {{item?.label}} To Bottom

    </template>

    <template contextMenuItem [divider]="true"></template>

    <template
        contextMenuItem
        (execute)="showAll($event)"
      >
      Show All
    </template>

    <template
        contextMenuItem
        (execute)="hideAll($event)"
      >
      Hide All
    </template>

  </context-menu>

Can you double check that you’re using a version of angular2-contextmenu that is greater than 0.6.0?  Sometimes the node_modules folder is out of sync with the package.json and you have to either delete and reinstall or manually check the node_modules/angular2-contextmenu/package.json to see what version number it says.
Your code looks just like the demo code in the repo, so it should work...

On Mar 28, 2017, at 9:09 AM, Steven Chambers<EMAIL_ADDRESS>wrote:
As noted above, I did include the contextMenuItem directive on the template element. the error message that angular produces:
zone.js:420 Unhandled Promise rejection: Template parse errors:
Can't bind to 'divider' since it isn't a known property of 'template'. ("

<template contextMenuItem [ERROR ->][divider]="true"></template>

<template

I have, as far as I know, imported the module correctly because everything else works as expected.
Here is my full context menu section of the template for reference:
<context-menu #contextMenu>
<template
contextMenuItem
let-item
(execute)="moveToTop($event)"
>
Send {{item?.label}} To Top

<template
    contextMenuItem
    let-item
    (execute)="moveToBottom($event)"
  >
  Send {{item?.label}} To Bottom

</template>

<template contextMenuItem [divider]="true"></template>

<template
    contextMenuItem
    (execute)="showAll($event)"
  >
  Show All
</template>

<template
    contextMenuItem
    (execute)="hideAll($event)"
  >
  Hide All
</template>

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub , or mute the thread .

From @symbyte on March 29, 2017 17:56
Ah yes. We have the library version locked to 0.5.3 because we were getting some strange behavior with where the menu would appear relative to the location of the click.
It seems that the same behavior is still present in the most recent release, so I'll open an issue on it in the next few days.

@symbyte The positioning problems should be fixed with the move to 1.x.  Let me know if it works for you.

Closing.

It appears your Demo at github is not working, just an FYI
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Tuesday, April 11, 2017 10:56 AM
To: isaacplmann/ngx-contextmenu
Cc: gjenner; Mention
Subject: Re: [isaacplmann/ngx-contextmenu] separator/divider (#2)
Closing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/ngx-contextmenu/issues/2#issuecomment-293289867 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHbL-ix-Hhyw0jfNaKjgO-oKpILXTks5ru5RsgaJpZM4MxgPP .  https://github.com/notifications/beacon/AYwRHa8CO1ZNGPKXqM9FVcuFEKoEaocUks5ru5RsgaJpZM4MxgPP.gif

Greetings, hoping all is well
So I am upgrading to angular 4, upgraded to ngx-contextmenu
If I use your example with the <ng-template… the menu appears correctly.  If I use the <li *ngFor…, the list appears somewhere else on the page.  Do you feel I am doing something obviously wrong?
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Tuesday, April 11, 2017 10:56 AM
To: isaacplmann/ngx-contextmenu
Cc: gjenner; Mention
Subject: Re: [isaacplmann/ngx-contextmenu] separator/divider (#2)
Closing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/ngx-contextmenu/issues/2#issuecomment-293289867 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHbL-ix-Hhyw0jfNaKjgO-oKpILXTks5ru5RsgaJpZM4MxgPP .  https://github.com/notifications/beacon/AYwRHa8CO1ZNGPKXqM9FVcuFEKoEaocUks5ru5RsgaJpZM4MxgPP.gif

I'll need more information to diagnose your issue.  Can you show me more of your template?

{{item?.name}}

<context-menu #cmNew>
<ng-template contextMenuItem (execute)="showMessage('Hi, ' + $event.item.name)">

  Say hi!

</ng-template>

Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Thursday, April 13, 2017 10:20 AM
To: isaacplmann/ngx-contextmenu
Cc: gjenner; Mention
Subject: Re: [isaacplmann/ngx-contextmenu] separator/divider (#2)
I'll need more information to diagnose your issue. Can you show me more of your template?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/ngx-contextmenu/issues/2#issuecomment-293909127 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHZwZ8waN2h31KFlzVYII6HfwOzdFks5rvi8PgaJpZM4MxgPP .  https://github.com/notifications/beacon/AYwRHRTNjvJrDbqtHAmBxXFmpFpKRCfIks5rvi8PgaJpZM4MxgPP.gif

Where does the context menu appear in the DOM (Elements tab in Chrome Dev tools) when it's open?  It should be attached to the root app node.

OK, in my code I have the HTML menu with the code behind , so both appear on the screen, but show up in different locations, see attached
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Thursday, April 13, 2017 10:28 AM
To: isaacplmann/ngx-contextmenu
Cc: gjenner; Mention
Subject: Re: [isaacplmann/ngx-contextmenu] separator/divider (#2)
Where does the context menu appear in the DOM (Elements tab in Chrome Dev tools) when it's open? It should be attached to the root app node.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/ngx-contextmenu/issues/2#issuecomment-293911298 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHVQNdkuE8Ol2wHPHVAOrl_8k46aaks5rvjDUgaJpZM4MxgPP .  https://github.com/notifications/beacon/AYwRHW3oKwbKzdNlddEV_uGLVOEbUf8vks5rvjDUgaJpZM4MxgPP.gif

I don't think email attachments make it through to the github issue.  You'll either need to paste in the code or drag and drop the files into your reply from the github web ui.

uploaded
Thank you in advance,
Geordie Jenner
Net Connect Healthcare Systems
www.ncpractice.com
From: isaacplmann<EMAIL_ADDRESS>Sent: Thursday, April 13, 2017 11:00 AM
To: isaacplmann/ngx-contextmenu
Cc: gjenner; Mention
Subject: Re: [isaacplmann/ngx-contextmenu] separator/divider (#2)
I don't think email attachments make it through to the github issue. You'll either need to paste in the code or drag and drop the files into your reply from the github web ui.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/ngx-contextmenu/issues/2#issuecomment-293920576 , or mute the thread https://github.com/notifications/unsubscribe-auth/AYwRHXGGRqfDE39YyGNIgpAdeo7TzdiWks5rvjhcgaJpZM4MxgPP .  https://github.com/notifications/beacon/AYwRHbNI4gNEawxQmfXHy947kD_ydZ6Hks5rvjhcgaJpZM4MxgPP.gif


Collapse imports

VSCode Version: 1.4.0
OS Version: OS X

When a file has many import statements on top, user should be able to collapse them.

Right now folding is purely indentation based. What you are asking is language aware folding.
That's #3422


Add tests for MPHYS module

Issue Type

[ ] Bug
[X] Enhancement

Description
Integration tests should be added for mphys wrapper to ensure functionality is maintained.
Example
N/A
Environment
N/A

Addressed by #104


DRAFT - Organize Code Examples

Description of change
First draft to reorganize code examples.
Links to any relevant issues
resolves https://github.com/iotaledger/guild-devx/issues/42
Type of change

Documentation Fix

How the change has been tested
Wiki was built locally
Change checklist

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

@Thoralf-M , yes, it's one big conflict by this stage.


⚠ SceneTime has degraded performance

In af9f126, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1332 ms

Resolved: SceneTime performance has improved in 9cde1e6 after 6 minutes.


Simplify Defs parsing

closes #6656
It's not allowed to have a statement as the last def. In particular, statements with the await bang shouldn't be considered as empty return because they always desugar into expressions. So I removed EmptyDefsFinal which led to noticeable parsing simplification.

[x] fix the issue
[ ] split changes into meaningful commits for easier reviewing
[ ] add a new test for the specific case
[ ] thoroughly check all snapshots. they all are failed, but it looks like mostly due to changes in regions (probably there's an issue with the regions)

Zulip thread


error in CUHK03

please help me solve this problem：
File "main.py", line 460, in
validation_steps=1)
File "/home/omnisky/anaconda3/envs/zhaoyin_env/lib/python3.6/site-packages/tensorflow/python/keras/engine/training.py", line 1509, in fit
validation_split=validation_split)
File "/home/omnisky/anaconda3/envs/zhaoyin_env/lib/python3.6/site-packages/tensorflow/python/keras/engine/training.py", line 953, in _standardize_user_data
K.get_session().run(x.initializer)
File "/home/omnisky/anaconda3/envs/zhaoyin_env/lib/python3.6/site-packages/tensorflow/python/keras/backend.py", line 461, in get_session
_SESSION = session_module.Session(config=config)
File "/home/omnisky/anaconda3/envs/zhaoyin_env/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1511, in init
super(Session, self).init(target, graph, config=config)
File "/home/omnisky/anaconda3/envs/zhaoyin_env/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 634, in init
self._session = tf_session.TF_NewSessionRef(self._graph._c_graph, opts)
tensorflow.python.framework.errors_impl.InternalError: cudaGetDevice() failed. Status: CUDA driver version is insufficient for CUDA runtime version

From the last line, I can see the issue is with cuda version which as can be seen is old version .. make sure you have compatible cuda for your tensor , you may refer to authors setting
I saw this :-
Test Environment:
Ubuntu 18.04
Python 3.6.6
TensorFlow 1.11
Keras 2.1.6-tf
CUDA 9.0
cudnn 7.3.1
NVIDIA GTX 1080Ti

From the last line, I can see the issue is with cuda version which as can be seen is old version .. make sure you have compatible cuda for your tensor , you may refer to authors setting
I saw this :-
Test Environment:
Ubuntu 18.04
Python 3.6.6
TensorFlow 1.11
Keras 2.1.6-tf
CUDA 9.0
cudnn 7.3.1
NVIDIA GTX 1080Ti

but my cuda version is already 9.0


Meeting docs

documents that I did not make a PR for yet

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.077%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
259

Relevant Lines:
419

💛  - Coveralls