HDDS-1674 Make ScmBlockLocationProtocol message type based

This PR is a first attempt at refactoring the ScmBlockLocationProtocol using a single message type as is used in the OzoneManagerProtocol. In this change, the new message wraps the existing messages and the translator classes simply wrap or unwrap it.
Only TraceID has been moved to the wrapper message - Moving error handling and error codes to the wrapper will be done in a separate change.
Before this can be merged we still need to determine if the clientId should be present in the  ScmBlockLocationProtocol. It is in OzoneManagerProtocol and has been replicated here for now, but it can be removed if needed.

/label ozone

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
549
trunk passed

+1
compile
291
trunk passed

+1
checkstyle
85
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
969
branch has no errors when building and testing our client artifacts.

+1
javadoc
171
trunk passed

0
spotbugs
346
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
539
trunk passed

_ Patch Compile Tests _

+1
mvninstall
477
the patch passed

+1
compile
299
the patch passed

+1
cc
299
the patch passed

+1
javac
299
the patch passed

-0
checkstyle
41
hadoop-hdds: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedclient
761
patch has no errors when building and testing our client artifacts.

+1
javadoc
179
the patch passed

+1
findbugs
605
the patch passed

_ Other Tests _

-1
unit
210
hadoop-hdds in the patch failed.

-1
unit
2104
hadoop-ozone in the patch failed.

+1
asflicense
51
The patch does not generate ASF License warnings.

7591

Reason
Tests

Failed junit tests
hadoop.ozone.container.common.impl.TestHddsDispatcher

hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerCommandHandler

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion

hadoop.ozone.client.rpc.TestBCSID

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-984/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/984

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc

uname
Linux c27ba5a6a7b7 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 335c1c9

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/1/artifact/out/diff-checkstyle-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/1/testReport/

Max. process+thread count
4887 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common U: hadoop-hdds/common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
659
trunk passed

+1
compile
361
trunk passed

+1
checkstyle
93
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1052
branch has no errors when building and testing our client artifacts.

+1
javadoc
214
trunk passed

0
spotbugs
418
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
660
trunk passed

_ Patch Compile Tests _

+1
mvninstall
654
the patch passed

+1
compile
396
the patch passed

+1
cc
396
the patch passed

+1
javac
396
the patch passed

-0
checkstyle
51
hadoop-hdds: The patch generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
758
patch has no errors when building and testing our client artifacts.

+1
javadoc
171
the patch passed

+1
findbugs
576
the patch passed

_ Other Tests _

-1
unit
193
hadoop-hdds in the patch failed.

-1
unit
1812
hadoop-ozone in the patch failed.

+1
asflicense
62
The patch does not generate ASF License warnings.

8027

Reason
Tests

Failed junit tests
hadoop.ozone.container.common.impl.TestHddsDispatcher

hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerCommandHandler

hadoop.ozone.web.client.TestKeysRatis

hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.web.client.TestVolume

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-984/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/984

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc

uname
Linux 4e5a8f056dc9 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 335c1c9

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/2/artifact/out/diff-checkstyle-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/2/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/2/testReport/

Max. process+thread count
2491 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common U: hadoop-hdds/common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
520
trunk passed

+1
compile
289
trunk passed

+1
checkstyle
83
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
958
branch has no errors when building and testing our client artifacts.

+1
javadoc
172
trunk passed

0
spotbugs
344
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
536
trunk passed

_ Patch Compile Tests _

+1
mvninstall
473
the patch passed

+1
compile
294
the patch passed

+1
cc
294
the patch passed

+1
javac
294
the patch passed

+1
checkstyle
86
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
749
patch has no errors when building and testing our client artifacts.

+1
javadoc
169
the patch passed

+1
findbugs
552
the patch passed

_ Other Tests _

-1
unit
184
hadoop-hdds in the patch failed.

-1
unit
1427
hadoop-ozone in the patch failed.

+1
asflicense
54
The patch does not generate ASF License warnings.

6757

Reason
Tests

Failed junit tests
hadoop.ozone.container.common.impl.TestHddsDispatcher

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.scm.node.TestQueryNode

hadoop.ozone.client.rpc.TestBCSID

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-984/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/984

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc

uname
Linux 7aea99f99eaf 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 81ec909

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/3/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/3/testReport/

Max. process+thread count
5406 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common U: hadoop-hdds/common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-984/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

The 3 failed tests pass locally, so I don't believe they are failing due to this change.

/retest

Unit test failures seems to be independent.
Executed the basic smoketest and worked well.
Started a cluster from compose/ozonetrace and the tracing works well (propagated to the OM).
Merging it right now. Thanks the contribution @sodonnel


Column merge when converting from PDF to CSV

Pls help me check why some of column merge into one column and data merge into different column also ?
Thanks!

supply the pdf by uploading it, nobody can help you with this vague description.

MonthlyResets_201708_20170902001010.pdf
Pls help me check!

try to use --columns option putting the left coordinates of each column (remeber inches*72)

Is there any other option without providing left coordinates of each column?

If the columns are not detected correctly, there is no other option, I think.


Engine API: decouple shanghai spec

In anticipation of changes proposed in https://github.com/ethereum/execution-apis/issues/321 this PR decouples Shanghai spec from Paris.
I would also suggest we clean up the transition code in a separate PR. Currently, newPayloadV2 and forkchoiceUpdatedV2 specs are based on the corresponding V1 versions. To get rid of transition logic we would need the new spec to redefine the following parts:

Payload validation routine
forkchoicUpdatedV2 method

cc @ralexstokes

Maybe we could resolve that by having a better index of all the methods and that would be the best of both worlds. It would be nice to consider a different approach though where methods are grouped more by functionality instead and the hardfork-relevant information is noted within the method's specification.

The proposal https://github.com/ethereum/execution-apis/issues/321 suggests to use a reference table of all methods, we may add a Description column to this table describing the origins of this or that method to make navigation easy. I can see how functionality approach is more practical in some ways, the HF-base approach has natural points of solidifying a portion of spec, and discerning solidified part from yet experimental one. Let's debate on this, I am fully open to any solution which would be convenient for spec writers, devs and observers.

Updated this PR with decoupling Paris spec from the main spec document. So, Engine API spec employs the following structure:
execution-apis/src/engine
├─ common.md
├─ paris.md
├─ shanghai.md
├─ blob-extension.md

cc @djrtwo

I have added src/engine/experimental/ and placed blob-extension.md into this folder, cc @protolambda


perf(activation): add fast, memory efficient mish

There is already an autograd.fn mish in https://github.com/rwightman/gen-efficientnet-pytorch/blob/master/geffnet/activations/activations_me.py

One is efficient, the other recomputes everything in the backward pass. Hence the perf label.


How to reset?

On the README it mentions

Reset History Stack - The new reset Action for clearing the history stack and eliminates the navbar back button.

Exactly what I am looking for, but I dont know how to use the new reset action.  I couldnt find any info in the documentation or examples.  Can someone help?

Your best bet is to use type="reset" when defining scenes or when using Actions.scene() instead do Actions.scene({type: "reset"}).
I had a branch where I created a Actions.reset() but it felt like overkill vs. passing in the type.

@cridenour that worked great, thank you!


Error when running i3d_tf_to_pt.py

tensorflow.python.framework.errors_impl.NotFoundError: Restoring from checkpoint failed. This is most likely due to a Variable name or other graph key that is missing from the checkpoint. Please ensure that you have not altered the graph expected based on the checkpoint. Original error:
Key RGB/inception_i3d/Conv3d_1a_7x7/batch_norm/beta not found in checkpoint

When I convert the pre-trained i3d on Kinetics 600, the error occurs as follows:
Key RGB/inception_i3d/Conv3d_1a_7x7/batch_norm/beta not found in checkpoint
         [[node save/RestoreV2 (defined at i3d_tf_to_pt.py:66)  = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]


Email notification support added

user will be able to be notify in case of a bug in the application by setting in rails_exception_handler initializer
config.storage_strategies = [:email => {:recipients => "email1,email2"}]
User should then create a mailer (ErrorMailer) with the following method
def send_error_mail_to_admin(info,email)
@info = JSON.parse(info)
mail(to: email, subject: 'An error occured on your application')
end
He will also need to create views/error_mailer/send_error_mail_to_admin.html
Hi boss,
an error occured at <%= @info["created_at"] %>
TARGET URL
<%= @info["target_url"] %>
<% unless @info["referer_url"].blank? %>
REFERER URL
<%= @info["referer_url"] %>
<%end%>
PARAMETERS
<%= @info["params"] %>
USER AGENT
<%= @info["user_agent"] %>
USER INFORMATION
<%= @info["user_info"] %>
CLASS NAME
<%= @info["class_name"] %>
<% unless @info["message"].blank? %>
MESSAGE
<%= @info["message"] %>
<%end%>
TRACE
<%= @info["trace"] %>
<% unless @info["doc_root"].blank? %>
DOC ROOT
<%= @info["doc_root"] %>
<%end%>

Nice, I like this implementation :)
Is there a reason why we cant include RailsExceptionHandler::ErrorMailer and views/error_mailer/send_error_mail_to_admin ?
The user can still override those files on a per application basis if they want a custom version

hey,
good idea :)

done

I've pushed some breaking changes, most notably ErrorMailer have been namespaced as RailsExceptionHandler::ErrorMailer to avoid potential conflicts.
I also updated the mailer views to account for the fact that error info gathering is dynamic so the email is slightly different.
Could you test if it still works for you before I release a new gem to rubygems.com?
You can test the master branch by fetching the gem directly from github:
  gem "rails_exception_handler", git: 'git@github.com:Sharagoz/rails_exception_handler.git'

Hello, I will do that in 1 hour
On mar. 29 août 2017 à 17:08 Bjørn Trondsen<EMAIL_ADDRESS>wrote:

I've pushed some breaking changes, most notably ErrorMailer have been
namespaced as RailsExceptionHandler::ErrorMailer to avoid potential
conflicts.
I also updated the mailer views to account for the fact that error info
gathering is dynamic so the email is slightly different.
Could you test if it still works for you before I release a new gem to
rubygems.com?
You can test the master branch by fetching the gem directly from github:
gem "rails_exception_handler", git: 'git@github.com:Sharagoz/rails_exception_handler.git'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Sharagoz/rails_exception_handler/pull/18#issuecomment-325694531,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF7gVMCx2qNe7xOzMX6SdkibCLeVAvwnks5sdClZgaJpZM4PE4Gl
.

when i do git clone "git@github.com:Sharagoz/rails_exception_handler.git
i have
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights

Try git clone https://github.com/Sharagoz/rails_exception_handler.git instead

it works for me :)

v.2.4.0 was just released to rubygems with this feature. Thank you for your contribution :)

anytime! thanks for your work


"Close tabs to the right" is shown even when there is only one tab opened

Describe the bug
"Close tabs to the right" is shown even when there is only one tab opened
To reproduce
Just open a tab and right click on it
Screenshots

System Information
Edition	Windows 10 Pro
Version	20H2
Installed on	6/19/2020
OS build	19042.867
Experience	Windows Feature Experience Pack 120.2212.551.0
App: <IP_ADDRESS>

It seems DataContext occasionally can be null on the first context menu item (opening and closing some tabs usually make it work again). Somehow fixing this and maybe a value check (if (MainPage.AppInstances.Count == 1 || MainPage.AppInstances.IndexOf(tabItem) ...) could solve this.

@R3voA3 was your On startup setting set to "Open a specific page or pages"? I managed to reproduce the null DataContext issue in that case (so far).

It was set to continue where I left off. One tab was open.

@R3voA3 This issue should be resolved with #4198.


allow partial profiles being based on selectable profile

Partial profiles are a great feature that makes handling profiles much easier.
However, the properties of a profile that are not local to the profile are always based on the default profile.
It would be great at this point to be able to select a profile from which the partial profile inherits its non-local properties.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


fix combo box typing

https://github.com/stolostron/backlog/issues/25063
Signed-off-by: John Swanke<EMAIL_ADDRESS>

/lgtm


Unknown plugin "transform-flow-strip-types" specified in "base" at 0, attempted to resolve relative to "/Users/zgx/Desktop/react-native/local-cli"

11111:react-native zgx$ npm start

<EMAIL_ADDRESS>start /Users/zgx/Desktop/react-native
/usr/bin/env bash -c './packager/packager.sh "$@" || true' --

/Users/zgx/Desktop/react-native/node_modules/babel-register/node_modules/babel-core/lib/transformation/file/options/option-manager.js:204
throw new ReferenceError(messages.get("pluginUnknown", plugin, loc, i, dirname));
^
ReferenceError: Unknown plugin "transform-flow-strip-types" specified in "base" at 0, attempted to resolve relative to "/Users/zgx/Desktop/react-native/local-cli"
at /Users/zgx/Desktop/react-native/node_modules/babel-register/node_modules/babel-core/lib/transformation/file/options/option-manager.js:204:17
at Array.map (native)
at Function.normalisePlugins (/Users/zgx/Desktop/react-native/node_modules/babel-register/node_modules/babel-core/lib/transformation/file/options/option-manager.js:180:20)
at OptionManager.mergeOptions (/Users/zgx/Desktop/react-native/node_modules/babel-register/node_modules/babel-core/lib/transformation/file/options/option-manager.js:300:36)
at OptionManager.init (/Users/zgx/Desktop/react-native/node_modules/babel-register/node_modules/babel-core/lib/transformation/file/options/option-manager.js:488:10)
at compile (/Users/zgx/Desktop/react-native/node_modules/babel-register/lib/node.js:112:69)
at loader (/Users/zgx/Desktop/react-native/node_modules/babel-register/lib/node.js:158:14)
at Object.require.extensions.(anonymous function) [as .js] (/Users/zgx/Desktop/react-native/node_modules/babel-register/lib/node.js:168:7)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)

help

i just run npm start, but err....

@facebook-github-bot stack-overflow

Hey @zgxzgxzg and thanks for posting this! @damusnet tells me this issue looks like a question that would be best asked on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only. Will close this as this is really a question that should be asked on SO.

OK. I SEE, thinks...


onMove called more than one time?

This is my reduced test case:
http://codepen.io/FezVrasta/pen/qbPRKW
When you drag an element, and you keep it between two cells, the onMove event is fired several times.
Can you help me understand why does it happens?
Thanks.

same question.
move multi list, onUpdate not any event


Feature: Adding products to cart from the main page

Motivation
Buying should be easy.

The problem is that now you have to go to PDP (1 click) and click Add to Cart (2nd click). Lets make it easier and allow users to add products to cart wherever they want.

All products are unique in our shop. If you put it in the cart, the button should be disabled.

Solution
Mobile: Buy button in the bottom right corner on the product image
Desktop: Buy button in the center of the image while hovering
Also, I fixed the grid, so it filled unevenly with products - Pinterest style.

Looks like the product page links are broken in the cart - when I click on product title in the cart I get error 500.

Nice catch! Thanks! fixed)


[User management] Fix user manager bug and backward compatability

change return result "userName" field to "username"
change admin field from boolean to string.
delete pai-user namespace when delete rest-server ds.

Coverage decreased (-0.04%) to 51.687% when pulling ab8cb5a0bdee9d01a9e49be8e1a62636a178ed83 on canwan/fix-user-manager-bug into 2aab9a0c1fc4dc761b321cefba04fcca5c550d3e on master.

Coverage decreased (-0.04%) to 51.687% when pulling ab8cb5a0bdee9d01a9e49be8e1a62636a178ed83 on canwan/fix-user-manager-bug into 2aab9a0c1fc4dc761b321cefba04fcca5c550d3e on master.

Coverage decreased (-0.04%) to 51.687% when pulling ab8cb5a0bdee9d01a9e49be8e1a62636a178ed83 on canwan/fix-user-manager-bug into 2aab9a0c1fc4dc761b321cefba04fcca5c550d3e on master.

Coverage decreased (-0.04%) to 51.687% when pulling ab8cb5a0bdee9d01a9e49be8e1a62636a178ed83 on canwan/fix-user-manager-bug into 2aab9a0c1fc4dc761b321cefba04fcca5c550d3e on master.


Error when add Summary

Report cannot be processed with big amount of files.
Possible solution:
add option to disable File Coverage section in comment.

Hi @sfer23, thank you for reporting this!
Hm, indeed, that's a problem I didn't think of yet. Having that option would be great - do you mind submitting a PR for this?
Mid-Term, this could also be solved (or at least worked around to some degree) by having the coverage-split feature suggested in #160 to only show the file coverage for the files changed in the PR.

I just went ahead and put this in myself. I will have to do a final test tomorrow, but will release it then. 🙂

Nice solution, I'll also try to provide some variant PR, and also will check #160, nice idea also.

Also will test my version and describe the results

@sfer23: I just released the new version 2.0.0 with our changes and the new file-coverage-mode-setting. So this should be fixed now!
Thank you again for the contribution! 🥳


[FEATURE] Document the OpenSearch Software Foundation governing board (GB)

Is your feature request related to a problem?
Coming from opensearch-project/.github#220, we have formed an OpenSearch Foundation Governing Board (GB).
What solution would you like?
The GB, its charter, members, and processes, need to be documented in this repo.

looking into creating a 'governing-board' repo - similar to how we are setting up the 'technical-steering' repo

Let's not call that "governing-board", maybe "governance" :)


Support extend layers for Java binding

[ ] Define Accessor and LayeredAccessor interface and wrap {Blocking}Operator into this abstraction
[ ] Implement a demo layer

Recently, I've been considering the concept of layers in bindings. I previously believed that all bindings should have their own unique layer abstractions and implementations. However, I discovered that it's illogical for each binding to implement the same layer individually. This contradicts our OpenDAL's VISON.
Looking back at the Java binding, perhaps the main issue lies in how we've designed the API to expose Rust layers in Java. We could consider exposing them as org.apache.opendal.layers.RetryLayer, and construct a similar API like op.layer(new RetryLayer()).

@Xuanwo the layer implemented in Java API should include a way to export Rust's layers, while it's not conflict with making a pure Java layer to leverage Java ecosystem. The first challenge I meet is how to pipeline the accessor and adapt operator class into this absraction :D

The first challenge I meet is how to pipeline the accessor and adapt operator class into this absraction :D

I strongly oppose exposing Accessor to the bindings realm. It's OpenDAL's raw API, which users should never interact with. Technically, it's challenging for Java to access generic types in Rust through FFI.


No title extracted when colon are present in title

See issue https://github.com/grangier/python-goose/issues/137

Closed by commit #ad82ba17ed

Closed with https://github.com/tanzaho/python-goose/commit/ad82ba17ed0cb4505c18de62da289af98bb4521e


Brazilian Portuguese Translation Added

The translation into Portuguese was done considering the terms used in Brazil, not being the literal translation of the terms, facilitating the use of Brazilian users.

Thank you!  I will either manually merge it when I do a release or you can submit the PR to the 6.02 branch (current dev branch).
I would like to send you a theme pack for your effort.  Just email me<EMAIL_ADDRESS>your email and which one you would like (see https://respondcms.com/marketplace).

Great! just sent the email. About the PR, I will close it and submit to the 6.02 branch.

PR submitted to 6.02 branch -


Inspect linkages

Updating an old feedstock

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Bump normalize-url from 4.5.0 to 4.5.1

Bumps normalize-url from 4.5.0 to 4.5.1.

Release notes
Commits

updated-dependencies:

dependency-name: normalize-url
dependency-type: indirect
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

IBM Cloud toolchain: Delivery Pipeline deployed simple-toolchain-20211012205531737 to dev, including commit 31fe3d2f93d8e097b6395dca494d2bcb9b979cdc


Undefined variable $p_bugnote_id

I still get the  last message ('Undefined variable $p_bugnote_id') if I add a picture by just pasting it into the note. Still the note is added

Could you provide details? (line number, stack information)
I am sure that this problem has been solved in version 1.1.0

You are right, think I got the update from the wrong location.
I downloaded again the plugin and it works without error message now.
Thanks a lot.
Issue can be closed.
Cas
From: pysiek634 @.>
Sent: Thursday, 2 May 2024 19:08
To: mantisbt-plugins/VEditor @.>
Cc: Cas Nuy @.>; Author @.>
Subject: Re: [mantisbt-plugins/VEditor] Undefined variable $p_bugnote_id (Issue #1)
Could you provide details? (line number, stack information)
I am sure that this problem has been solved in version 1.1.0
—
Reply to this email directly, view it on GitHubhttps://github.com/mantisbt-plugins/VEditor/issues/1#issuecomment-2091087506, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABYLFFHZ3XDR2X3SUQEFXNTZAJXIJAVCNFSM6AAAAABG52F4BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRGA4DONJQGY.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Rebaseline a tiny 0.8% regression

@bot-gradle test and merge

OK, I've already triggered a build for you.


[SQL Index and Data Source Cache] The web UI cannot show cache size when using Plasma and q68.sql will be suspended to wait for cache free.

I run 9 IO-intensive queries of TPCDS for 3 rounds and use Plasma Service for data source cache. The data scale is 3TB and PEME is enough for cache. There are two issues were found:

When running queries for the 2nd round, q68.sql will be suspended and wait for cache free which causes the test fail:

The web UI cannot accuratly display the cache size:

cc @jikunshang

The first issue can be resolved by increasing spark.sql.oap.dcpmm.free.wait.threshold configuration, it's maximum cache size one executor could get.


Multiple helm charts in the same repo.

We have a repository which contains multiple Helm charts. I expected to be able to be able to update my release-please-config.json to something like:
"release-type": "helm",
"packages": {
    "path/to/package/A": {
        "package-name": "package-A"
    },
    "path/to/package/B": {
        "package-name": "package-B"
    }
}

However, our CI fails saying release-please failed to find Chart.yaml.
Once we added a chart to the root of the repository release-please successfully discovers the file.
I'd like for the helm release-type to honor the information in the packages object. If not it should be stated in the docs that only a single root level chart is supported.

After playing around with release-please locally we've determined that it does actually work as expected with the release-please CLI, the culprit in our case is the release-please action.
Closing.


Fix traversable laws

See #128
Opening the PR to get this moving.

Rewrote Compose via .prototype and checked that it works in Ramda repl: http://goo.gl/ExPdoo
Also GitHub for some reason hided previous comments on other parts of the diff, although I didn't touch those parts:

These comments still need attention.

@rpominov 👍  on the prototype stuff.

This looks great!  Thanks.

While we're in here fixing this. Can we change the requirement to traverse rather than sequence? With traverse you can derive map and reduce for free. But you can't do that with sequence.

Oh, actually. I guess we don't even have the requirement that Traversable implement Foldable as well. Better add that while fixing this as well.

While we're in here fixing this. Can we change the requirement to traverse rather than sequence?

We could, but that would be a braking change, do we really want that?

With traverse you can derive map and reduce for free. But you can't do that with sequence.

We can derive traverse using sequence and map, and then we can derive reduce. So we only missing possibility of deriving map, reduce still can be derived.
On other hand using traverse will be consistent with Monad that uses chain and not join.
Should we add instructions how reduce can be derived? It's kind of tricky and requires two helper types Const and Endo from what I understood from https://github.com/fantasyland/fantasy-land/pull/68#issuecomment-44789091 . Do we want that in the spec?
I'm very curious what @DrBoolean thinks about all this, since he originally brought Traversable and Foldable to the spec.

Love that you got rid of Id! I was thinking since Id was the example in the spec, it'd be okay to reference, but no one, including myself, wanted to mix in implementation. I guess there still is implementation there with Compose,  but it's better inline.
A traversable is a foldable functor, yes, but I don't see the reason to enforce foldable. I think it should just be known that one can derive it. (https://github.com/fantasyland/fantasy-land/pull/68#issuecomment-44789091)
I'm cool with switching to traverse, I originally wrote (ported) it that way, but found it to be more complex and only defined that way for edge case performance reasons. That said, i hardly ever use sequence and reach for traverse myself.

Love that you got rid of Id! I was thinking since Id was the example in the spec, it'd be okay to reference, but no one, including myself, wanted to mix in implementation.

Great, we wasn't sure if we can replace Id with any Applicative in #128

A traversable is a foldable functor, yes, but I don't see the reason to enforce foldable.

Seems like in other places in the spec when we can derive one algebra from another that algebra is enforced.

I'm cool with switching to traverse

+1 from me, and I can add this to PR, but still not sure if everybody want this.

As far as any applicative goes. It'd be interesting to search for a counter example. Perhaps Const will break it

Perhaps Const will break it

No, it works with Const. u.map(Const.of).sequence(Const.of) will create a bunch of Const(empty()) which then will be concatenated (using ap) to a single Const(empty()); and Const.of(u) also will give us Const(empty()).

word!

As far as "breaking change", its since traverse and sequence can be defined in terms of each other, I don't see it as much of an issue. Especially if we provide derived sequence: traverse(F.of, id)

Made Traversable to depend on Foldable, and added derived reduce() (checked that it works here http://goo.gl/nW1bkB)

I disagree that we should say it must implement the foldable spec. Even though something is definitely foldable if it's traversable, we don't depend on reduce and it confuses the work involved to make a type traversable. One absolutely must have map, but not fold or reduce
I feel providing a derivable version is enough to show it's foldable.

I don't have a strong opinion on this, but I think we should try to keep spec consistent. As I understand, before Traversable and Foldable were added, the one of rules to decide where a dependency must be introduced was: if algebra B can be derived from algebra A, then A must depend on B. An example of such case is Chain depending on Apply.
This seems relevant to #134 and #132

Maybe it would be better to replace sequence with traverse in another PR, so it wouldn't block other changes from this PR? I can open PR for traverse right after this is merged.
If that ok, the open questions left here:

Should we add the requirement that Traversable implement Foldable? (currently added)
Is the derived reduce() I wrote fine?

I'm good with this. The derived traverse does seem out of place now that we've talked it all out, but i suppose that is a separate PR.
I have to say, amazing job on derived reduce and the naturality law!
I think this is a terrific clarification of the spec. Thanks for all your work on this.
Everyone else cool to update this?

Looks good to me.
On Sat, 16 Apr 2016, 16:49 Brian Lonsdorf<EMAIL_ADDRESS>wrote:

I'm good with this. The derived traverse does seem out of place now that
we've talked it all out, but i suppose that is a separate PR.
I have to say, amazing job on derived reduce and the naturality law!
I think this is a terrific clarification of the spec. Thanks for all your
work on this.
Everyone else cool to update this?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/fantasyland/fantasy-land/pull/131#issuecomment-210843298

Great! The PR that replaces sequence with traverse is coming soon.

:sparkles:


Connection to Impala with LDAP Authentication

It is possible to connect to Impala with LDAP Authentication rather than Kerberos Auth???
Principal is a parameter of "connect" function but i cant set a user and password instead. It should look like this:
"jdbc:hive2://:/;user=;password="
Is it possible??
Thank you!

Hi - Nagarajjayakumar,
Can you provide an example how to connect to a secured cloudera cluster that is using LDAP?
Thanks

Hi
R Impala connector code is a Jdbc based.
Modified the connector code to connect to LDAP authentication enabled
Impala server.
Deploy the jar and modify rimpala Python script to use new library
Please let me know if u need more info
On Saturday, December 5, 2015, opanito<EMAIL_ADDRESS>wrote:

Hi - Nagarajjayakumar,
Can you provide an example how to connect to a secured cloudera cluster
that is using LDAP?
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/Mu-Sigma/RImpala/issues/2#issuecomment-162269143.

Thanks for the quick response.
I am not too familiar on how this work.  I am assuming that i can open one of the downloaded custom Jars for cloudera R impala and change the connection there, then call rimpala.connect() and that should work?

On Dec 6, 2015, at 8:07 AM, nagarajjayakumar<EMAIL_ADDRESS>wrote:
Hi
R Impala connector code is a Jdbc based.
Modified the connector code to connect to LDAP authentication enabled
Impala server.
Deploy the jar and modify rimpala Python script to use new library
Please let me know if u need more info
On Saturday, December 5, 2015, opanito<EMAIL_ADDRESS>wrote:

Hi - Nagarajjayakumar,
Can you provide an example how to connect to a secured cloudera cluster
that is using LDAP?
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/Mu-Sigma/RImpala/issues/2#issuecomment-162269143.

—
Reply to this email directly or view it on GitHub.

You can use the source code in github....it is a simple Jdbc Java code...
You need to modify r Impala py script to use ur new jar
On Sunday, December 6, 2015, opanito<EMAIL_ADDRESS>wrote:

Thanks for the quick response.
I am not too familiar on how this work. I am assuming that i can open one
of the downloaded custom Jars for cloudera R impala and change the
connection there, then call rimpala.connect() and that should work?

On Dec 6, 2015, at 8:07 AM, nagarajjayakumar<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:
Hi
R Impala connector code is a Jdbc based.
Modified the connector code to connect to LDAP authentication enabled
Impala server.
Deploy the jar and modify rimpala Python script to use new library
Please let me know if u need more info
On Saturday, December 5, 2015, opanito<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

Hi - Nagarajjayakumar,
Can you provide an example how to connect to a secured cloudera cluster
that is using LDAP?
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/Mu-Sigma/RImpala/issues/2#issuecomment-162269143.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
https://github.com/Mu-Sigma/RImpala/issues/2#issuecomment-162336502.

I found this source code: https://github.com/Mu-Sigma/RImpala/tree/master/src/R
line 74-75 shows this:
rimpala.connect <- function(IP="localhost",port="21050",principal="noSasl"){
impalaObj = .jnew("com.musigma.ird.bigdata.RImpala")
You think replacing this with this line would work:
function('jdbc:hive2://ip.localhost.local:21050/<EMAIL_ADDRESS>password="" ')
then recompiling?
If not, are you available to show me?
Thanks.

You need to modify the Java code om.musigma.ird.bigdata.RImpala and build
the jar ,,,
Then you need to repoint the R script to new jar
On Monday, December 7, 2015, opanito<EMAIL_ADDRESS>wrote:

I found this source code:
https://github.com/Mu-Sigma/RImpala/tree/master/src/R
line 74-75 shows this:
rimpala.connect <-
function(IP="localhost",port="21050",principal="noSasl"){
impalaObj = .jnew("com.musigma.ird.bigdata.RImpala")
You think replacing this with this line would work:
function('jdbc:hive2://ip.localhost.local:21050/<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','user1@localhost.local');>; password="" ')
then recompiling?
If not, are you available to show me?
Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/Mu-Sigma/RImpala/issues/2#issuecomment-162413435.

This is what i found:
public static boolean connect(String IP, String port, String principal) {
	CONNECTION_URL = "jdbc:hive2://" + IP + ':' + port + "/;" + principal;

	try {
		Class.forName(JDBC_DRIVER_NAME);
		con = DriverManager.getConnection(CONNECTION_URL);
		con.setAutoCommit(false);
		return true;

which line do I need to change to What?
sorry i am new to java.

Amarita noted: "jdbc:hive2://:/;user=;password="
I am wondering if this worked.

Here are my changes:
public static boolean connect(String IP, String port, String user, String password) {
	CONNECTION_URL = "jdbc:hive2://" + IP + ':' + port + "/;" + user + "/;" + password;

HI, I was able to connect to the secured cluster using a 32-bit version of Cloudera ODBC connector and R 32 bit.  My next step is to try the option of compiling the Java code.
Thanks for your help!


Introduce a "Spatial" typeclass

There is a boring problem at the moment that you can't do something like:
def doWork[T <: RenderNode](node: T): T =
  node.moveTo(Point(10, 10))

To solve this currently, you have to match on every possible concrete type you support - yuk.
It would be nice to introduce a typeclass to allow something like this:
def doWork[T : Spatial](node: T): T =
  node.moveTo(Point(10, 10))

So, is this basically turning https://github.com/PurpleKingdomGames/indigo/blob/master/indigo/indigo/src/main/scala/indigo/shared/scenegraph/SpatialModifiers.scala into a typeclass, and give instances for every class extending from it? :thinking: Seems like a sensible approach, many (if not all) the implementations are there, it's a matter of moving them a proper place (companion object, instances object for all of them?) and fix the affected signatures by this change.

That's pretty much the idea yes. That trait is literally only there to make sure I don't forget any implementations! The only thing to be aware of follow recent work, is the SceneNode splits into RenderNode, EntityNode and DependentNode (CompositeNode is gone) and they have some slight differences.
I also wondered if there is another typeclass that allows you to also affect the attributes common the SceneNode's and Clone classes.

@bilki made a valiant attempt at this but we decided in the end that it created as many problems as it solved, and thought it best to leave it as is for now.


Add support for Material 3

I use this library for a project that uses Material 3. To achieve the correct theming behaviour, I have to set the sheet background to Transparent and then make my own sheet shape and color.

There is already official M3 ModalBottomSheet available.
I would recommend to use that one if possible, or optionally stick with that theming workaround.
What do you think?

Yeah, I've migrated to M3 sheet completely. I hoe they iron all all the bugs soon or I'll have to migrate back :D Closing this for now


SASL Enabled Memcached LIST_MECH return empty supported mechanisms

I am implementing my own implementation of a memcachedClient within which I want to add authentication. I just started with PLAIN auth but failed. In short, the LIST_MECH command always returns an empty result, if I go ahead and issue and PLAIN AUTH command, it says,
mech:  ``PLAIN'' with 34 bytes of data
SASL (severity 2): Couldn't find mech PLAIN

Below is my configuration:

I  am on memcache 1.5.12

My memcached.conf

% cat memcached.conf
mech_list: plain
log_level: 5
sasldb_path: /tmp/memcached-sasl-db

My /tmp/memcached-sasl-db

% cat memcached-sasl-db
myname:mypass

My exports:

export MEMCACHED_SASL_PWDB=/tmp/memcached-sasl-db
export SASL_CONF_PATH=`pwd`/memcached.conf

I've tried exporting  SASL_CONF_PATH with both specific conf file and only to the folder.
I've also built with --enable-sasl-pwdb

Upon launching: I suppose it is picking up the correct conf file
./memcached -m 32 -S -B binary -vvvv
Reading configuration from: </MemcachedBuildDirection/build/bin/memcached.conf>
Initialized SASL.

The LIST_MECH is showing:
<29 Read binary protocol data:
<29    0x80 0x20 0x00 0x00
<29    0x00 0x00 0x00 0x00
<29    0x00 0x00 0x00 0x00
<29    0x00 0x00 0x00 0x01
<29    0x00 0x00 0x00 0x00
<29    0x00 0x00 0x00 0x00
authenticated() in cmd 0x20 is true
>29 Writing bin response:
>29   0x81 0x20 0x00 0x00
>29   0x00 0x00 0x00 0x00
>29   0x00 0x00 0x00 0x00
>29   0x00 0x00 0x00 0x01
>29   0x00 0x00 0x00 0x00
>29   0x00 0x00 0x00 0x00

It shows that the response has a total length of zero. Thus I am reading an empty list from the output.
And the AUTH command:
<29 Read binary protocol data:
<29    0x80 0x21 0x00 0x05
<29    0x00 0x00 0x00 0x00
<29    0x00 0x00 0x00 0x27
<29    0x00 0x00 0x00 0x01
<29    0x00 0x00 0x00 0x00
<29    0x00 0x00 0x00 0x00
authenticated() in cmd 0x21 is true
29: going from conn_parse_cmd to conn_nread
mech:  ``PLAIN'' with 34 bytes of data
SASL (severity 2): Couldn't find mech PLAIN
sasl result code:  -4
Unknown sasl response:  -4
>29 Writing an error: Auth failure.
>29 Writing bin response:
>29   0x81 0x21 0x00 0x00
>29   0x00 0x00 0x00 0x20
>29   0x00 0x00 0x00 0x0d
>29   0x00 0x00 0x00 0x01
>29   0x00 0x00 0x00 0x00
>29   0x00 0x00 0x00 0x00

I expected there will be a list of supported auth mechs being returned by LIST_MECH.
Can anyone point me at some direction that could make it work?

I went through all this sasl stuff last year and seem to have forgotten about all of it.
Do your tests pass? (make test)

Thanks for getting back to me! The answer is no.
If I run make test it fails with
...
Thread stats cumulative		6320
./testapp
1..52
ok 1 - cache_create
ok 2 - cache_constructor
ok 3 - cache_constructor_fail
ok 4 - cache_destructor
ok 5 - cache_reuse
ok 6 - cache_redzone
ok 7 - issue_161
ok 8 - strtol
ok 9 - strtoll
ok 10 - strtoul
ok 11 - strtoull
ok 12 - issue_44
ok 13 - vperror
testapp: testapp.c:427: start_server: Assertion `execv(argv[0], argv) != -1' failed.

and then stucks there forever.
if I run make and then make test it fails with
...
ok 46 - binary_prepend
ok 47 - binary_prependq
ok 48 - binary_stat
ok 49 - binary_illegal
ok 50 - binary_pipeline_hickup
Signal handled: Interrupt.
ok 51 - shutdown
ok 52 - stop_server
/bin/sh: line 3: prove: command not found
make: *** [test] Error 127

You need to run make before make test as you noted. you also need to install perl test modules.. you'll have to google how to do that for your particular OS. Your tests should generally pass, but the sasl tests are what I'm interested in.

That makes sense. After yum install per test modules my make test failed on sasl tests as below:
% RUN_SASL_TESTS="1" prove t/binary-sasl.t
t/binary-sasl.t .. ERROR: You cannot allow the ASCII protocol while using SASL.
t/binary-sasl.t .. 1/34 ERROR: You cannot allow the ASCII protocol while using SASL.
t/binary-sasl.t .. 2/34 ERROR: You cannot allow the ASCII protocol while using SASL.
t/binary-sasl.t .. 3/34
#   Failed test 'list_mechs '
#   at t/binary-sasl.t line 146.
#          got: ''
#     expected: 'CRAM-MD5 PLAIN'

#   Failed test 'authenticated'
#   at t/binary-sasl.t line 208.
#          got: '32'
#     expected: '0'

#   Failed test at t/binary-sasl.t line 212.

#   Failed test ' = somevalue'
#   at t/binary-sasl.t line 107.
#          got: ''
#     expected: 'somevalue'
send: Cannot determine peer address at t/binary-sasl.t line 370
# Looks like you planned 34 tests but ran 19.
# Looks like you failed 4 tests of 19 run.
# Looks like your test exited with 107 just after 19.
t/binary-sasl.t .. Dubious, test returned 107 (wstat 27392, 0x6b00)
Failed 19/34 subtests

Test Summary Report
-------------------
t/binary-sasl.t (Wstat: 27392 Tests: 19 Failed: 4)
  Failed tests:  6, 17-19
  Non-zero exit status: 107
  Parse errors: Bad plan.  You planned 34 tests but ran 19.
Files=1, Tests=19,  3 wallclock secs ( 0.02 usr  0.00 sys +  0.03 cusr  0.01 csys =  0.06 CPU)
Result: FAIL

Looks like this is directly related to problem I am running into as the list_mechs returned nothing rather than the ones defined in the config file.
I ran the above tests on memcached-1.5.13

What's your OS and how did you install the sasl libs? Can you include the output from ./configure from 1.5.13? Looks like your sasl libs are installed weird/wrong.

I am using AWS EC2 Linux.
% sudo uname -a
Linux MY_EC2_HOSTNAME 4.9.137-0.1.ac.218.74.329.metal1.x86_64 #1 SMP Wed Dec 5 15:11:05 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Commands i ran before ./configure --enable-sasl:
sudo yum install cyrus-sasl-devel
sudo yum install libevent-devel
sudo yum install perl-Test-Harness
sudo yum install perl-Test-Simple

Please find the output of ./configure below
% ./configure
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for icc in use... no
checking for clang in use... no
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking whether __SUNPRO_C is declared... no
checking for gcc option to accept ISO C99... -std=gnu99
checking sasl/sasl.h usability... yes
checking sasl/sasl.h presence... yes
checking for sasl/sasl.h... yes
checking for gcov... /usr/bin/gcov
checking for main in -lgcov... yes
checking for library containing clock_gettime... -lrt
checking for library containing socket... none required
checking for library containing gethostbyname... none required
checking for libevent directory... (system)
checking for library containing umem_cache_create... no
checking for library containing gethugepagesizes... -lhugetlbfs
checking for stdbool.h that conforms to C99... yes
checking for _Bool... yes
checking for inttypes.h... (cached) yes
checking for sasl_callback_ft... no
checking for print macros for integers (C99 section 7.8.1)... yes
checking for an ANSI C-conforming const... yes
checking for socklen_t... yes
checking for endianness... little
checking for htonll... no
checking for library containing pthread_create... none required
checking for mlockall... yes
checking for getpagesizes... yes
checking for memcntl... no
checking for sigignore... yes
checking for clock_gettime... yes
checking for accept4... yes
checking for getopt_long... yes
checking for alignment... none
checking for GCC atomics... yes
checking for GCC 64bit atomics... yes
checking for setppriv... no
checking for pledge... no
checking umem.h usability... no
checking umem.h presence... no
checking for umem.h... no
checking for xml2rfc... no
checking for xsltproc... /apollo/env/envImprovement/bin/xsltproc
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating doc/Makefile
config.status: creating config.h
config.status: executing depfiles commands

can you rebuild with make clean && ./configure --enable-sasl && make then re-run the tests?

or if that's what you did in the first place, please give the output of ./configure --enable-sasl - sorry, I wasn't explicit.

No worries, below is the output of ./configure --enable-sasl
% ./configure --enable-sasl
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for icc in use... no
checking for clang in use... no
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking whether __SUNPRO_C is declared... no
checking for gcc option to accept ISO C99... -std=gnu99
checking sasl/sasl.h usability... yes
checking sasl/sasl.h presence... yes
checking for sasl/sasl.h... yes
checking for SASL_CB_GETCONF... no
checking for SASL_CB_GETCONFPATH... yes
checking for library containing sasl_server_init... -lsasl2
checking for gcov... /usr/bin/gcov
checking for main in -lgcov... yes
checking for library containing clock_gettime... -lrt
checking for library containing socket... none required
checking for library containing gethostbyname... none required
checking for libevent directory... (system)
checking for library containing umem_cache_create... no
checking for library containing gethugepagesizes... -lhugetlbfs
checking for stdbool.h that conforms to C99... yes
checking for _Bool... yes
checking for inttypes.h... (cached) yes
checking for sasl_callback_ft... no
checking for print macros for integers (C99 section 7.8.1)... yes
checking for an ANSI C-conforming const... yes
checking for socklen_t... yes
checking for endianness... little
checking for htonll... no
checking for library containing pthread_create... none required
checking for mlockall... yes
checking for getpagesizes... yes
checking for memcntl... no
checking for sigignore... yes
checking for clock_gettime... yes
checking for accept4... yes
checking for getopt_long... yes
checking for alignment... none
checking for GCC atomics... yes
checking for GCC 64bit atomics... yes
checking for setppriv... no
checking for pledge... no
checking umem.h usability... no
checking umem.h presence... no
checking for umem.h... no
checking for xml2rfc... no
checking for xsltproc... /apollo/env/envImprovement/bin/xsltproc
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating doc/Makefile
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands

And now my test output looks more reasonable, but still faile
% RUN_SASL_TESTS="1" prove t/binary-sasl.t
t/binary-sasl.t .. ERROR: You cannot allow the ASCII protocol while using SASL.
t/binary-sasl.t .. 1/34 ERROR: You cannot allow the ASCII protocol while using SASL.
t/binary-sasl.t .. 2/34 ERROR: You cannot allow the ASCII protocol while using SASL.
t/binary-sasl.t .. 3/34
#   Failed test 'list_mechs PLAIN'
#   at t/binary-sasl.t line 146.
#          got: 'PLAIN'
#     expected: 'CRAM-MD5 PLAIN'
# Looks like you failed 1 test of 34.
t/binary-sasl.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/34 subtests

Test Summary Report
-------------------
t/binary-sasl.t (Wstat: 256 Tests: 34 Failed: 1)
  Failed test:  6
  Non-zero exit status: 1
Files=1, Tests=34,  3 wallclock secs ( 0.02 usr  0.00 sys +  0.05 cusr  0.00 csys =  0.07 CPU)
Result: FAIL

So I'm not familiar with AWS's distro but you're probably missing a cyrus-sasl related library to give you CRAM-MD5. Take a look for it?

how'd it go?

Thanks for checking in! I guess the problem is not related to memcached itself, it's how I imported SASL related package into my system.  The reason being the native code works properly on my EC2 instance, but when I import memcached into my working related dependency management system the SASL is not imported/linked/path-found correctly. I am now diving deep into how to get an equivalent importing as sudo yum install cyrus-sasl-devel and how the ./configure process is looking for the correct Cyrus-SASL package. I am now doing a PoC for PALIN auth only, so I will set aside the MD5 problem for now.

Sounds good. I'm debating if there's a follow-up to this... the tests are pretty explicit if the SASL libs aren't found or compiled in, but it looks like you missed or walked past all those checks.
Guess I can double check on if there's an error the mech command should be returning instead of an empty list...

Thanks dormando, I have been exploring different ways to import Cyrus-SASL into my system. For better dependency management I do not want to do yum install every time in my Prod environment.
Now I am seeing these WARNINGS when configure memcached. Do you have any insight on these?
...
checking sasl/sasl.h usability... yes
checking sasl/sasl.h presence... no
configure: WARNING: sasl/sasl.h: accepted by the compiler, rejected by the preprocessor!
configure: WARNING: sasl/sasl.h: proceeding with the compiler's result
checking for sasl/sasl.h... yes
...

I don't really know what you're doing, but that's beyond the scope of this project. There are lots of standard ways of building cloud images/vms with pre-baked package installs. Sorry! :(

Thank you! I think we can close this issue now, as the root cause of LIST_MECH returning empty mech list is that the SASL package/dependencies were not installed/linked correctly.
I really appreciate your timely response.


Project Management page

Introduction
Modify contents on the page where users can manage the project(s) they are working on

[ ] Add feature to remove a project
[ ] Add feature to validate a project (before publishing)
[ ] Add feature to consult a project from an other user

Some notes:

A validated project is automatically published for now.
Only project with all steps completed can be validated, they must reach the overview page
A validated project can still be modified by its author
Other users have access to validated projects, but cannot modify them. The inputs can still be changed, but nothing is saved.

[ ] Add a validation button to the overview page
[ ] Publishing validated projects shouldn't be automatic

Turns out publishing validated project should be automatic, since they are mandated by public authorities believing on open data.
See MVP2 for a followup on UX/UI questions


Protecting Keys

I stored the key to azure blob storage. The key is used for protecting cookies for authentication right? Then I also need to protect the key?

How do I use the ProtectKeysWithDpapiNG? I really have no idea what this documentation does https://docs.microsoft.com/en-us/windows/desktop/SecCNG/protection-descriptors
also what are those values WEBCREDENTIALS, SID, CERTIFICATE and so on and where do I get or create them?

If I didn't protect the keys at rest, what are my risks?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c24ccb9-b297-f942-ebf1-c994d672f183
Version Independent ID: 5d6eb72e-b1b5-1507-6162-16a9a4a01aa0
Content: Key encryption At rest in ASP.NET Core
Content Source: aspnetcore/security/data-protection/implementation/key-encryption-at-rest.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

The Data Protection system provides a simple API to encrypt and decrypt data using a key. Ths risk is that anyone who has access to this key can also encrypt and decrypt that data so keeping it safe is critical for security.
Normally the DP-API will automatically create keys (which are XML files with certificates and metadata inside) and save them locally, while also encrypting the contents by using other APIs from the operating system. If you change the settings to store the keys somewhere else, then the normal key encryption is also turned off so you'll need to configure that separately if you want it. The easiest option is using Azure Key Vault (since you're already storing the keys in Azure Blob Storage).
DPAPI and DPAPI-NG (a newer version) only work on Windows. The first only works on a single machine so it's not a good option. The second requires an ActiveDirectory domain so it's only useful for enterprise Windows deployments. Again, if you don't have experience with this, I highly recommend using the Azure Key Vault option as it just takes a few clicks to create it in the portal.
If the Azure Blob Container you're using is very locked down and only being used to store these keys, then that might be good enough for simpler apps since nothing else can access that storage account to get the keys in the first place.

@blowdart 	should I add this info to the article?

Thank you very much for the prompt response. That clarifies that encrypting the keys at rest is optional with key vault assuming no one can else can access the blob container. but scaling the app later you might need to do it also.

@Rick-Anderson it's in there already; https://docs.microsoft.com/en-us/aspnet/core/security/data-protection/configuration/overview?view=aspnetcore-2.2


[sync] 1011 sync code

add algorithm lagcl
add english docs
fix setup.py
modify spark conf
optimize merit, pagnn training speed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


error when inlining page with bootstrap

hi,
when inlining a page which references bootstrap i always get this error:
λ inliner -v inliner.html
0/1
loading inliner.html
1/1
1/2
processing external css D:\tmp\test\css\bootstrap.css
loading D:\tmp\test\css\bootstrap.css
2/2
compress css
2/8
get image D:\tmp\test\fonts\glyphicons-halflings-regular.eot
loading D:\tmp\test\fonts\glyphicons-halflings-regular.eot
get image D:\tmp\test\fonts\glyphicons-halflings-regular.eot?
loading D:\tmp\test\fonts\glyphicons-halflings-regular.eot?
get image D:\tmp\test\fonts\glyphicons-halflings-regular.woff2
loading D:\tmp\test\fonts\glyphicons-halflings-regular.woff2
get image D:\tmp\test\fonts\glyphicons-halflings-regular.woff
loading D:\tmp\test\fonts\glyphicons-halflings-regular.woff
get image D:\tmp\test\fonts\glyphicons-halflings-regular.ttf
loading D:\tmp\test\fonts\glyphicons-halflings-regular.ttf
get image D:\tmp\test\fonts\glyphicons-halflings-regular.svg
loading D:\tmp\test\fonts\glyphicons-halflings-regular.svg
ENOENT: no such file or directory, open 'D:\tmp\test\fonts\glyphicons-halflings-regular.eot?'

it seems like somehow the ? becomes part of the path.
the used html:
<!DOCTYPE html>
<html>
  <head>
    <title>inliner error</title>
    <link rel="stylesheet" type="text/css" href="bootstrap.css">
  </head>
  <body>
  </body>
</html>

bootstrap is v3.3.5.
if you can point me where to have a look i can propose a pr. or if it is in another lib (eg. cheerio) i can create an issue there.
thanks for your help.

So, I think the issue is that the base location is a file, and it's seeing a query string on the font (for cache busting perhaps), but the file read fails because of it: ENOENT: no such file or directory, open 'D:\tmp\test\fonts\glyphicons-halflings-regular.eot?'
I reckon this line just needs to make sure to strip the ? and everything after. You up for the PR? Make sure to read the contributing docs too.


Prevent docker load.

This logic will be added back later at a point where docker installation is done by salt.

#6465
@zmerlynn

@dchen1107

cc/ @derekwaynecarr
Sorry for breaking vagrant again. Derek, @ArtfulCoder  did try to test the vagrant setup for etcd in pod, but failed even without his change by following kubernetes/docs/getting-started-guides/vagrant.md. We are going to definitely include vagrant into our test metrics, but need to clean up startup guide first. Can we have your help on this? Thanks!

@dchen1107: If you're looking for some Google-side help, @fabioy recently came back from vacation, and has setup Vagrant previously. He might be able to help.

@dchen1107 - i will test vagrant again now that this merged.  i know it worked when i left on thurs, and was broken when i came back today, so something could have happened in interim aside from this.

@dchen1107 - so i tested after this PR merged and was able to bring up a k8s cluster on vagrant using a master and single minion.  i will keep an eye out if there are any intermittent failures through week to see if there is something i can fix on my end.
@ArtfulCoder - thanks for the quick fix on this issue ;-)

@derekwaynecarr If this model works fine for you, I am fine with it. My concern is that we are keeping breaking vagrant setup, which we tried hard to avoid. The problem we couldn't avoid is lacking of automate system bringing a vagrant cluster for us to validate our changes. Thanks for quick validate the issues for us.


Technical User Details - quotation marks are vizualised

Detected in version: v.1.8.0 RC3
*probably already since RC1 existing
Summary
Quotation marks displayed in the UI - this is not needed
Page: /techuserdetails/{technicaluserID}

PR link: https://github.com/eclipse-tractusx/portal-frontend/pull/512

@lavanya-bmw  UI looks good, but when using the copy icon I still get the information copied into my clipboard with quotation marks. As soon as the IdP "Decline" and "Deactivation" is done, please check this one once again


Propaganistas/Laravel-Intl is abandoned

Hello,
Your Package is dependent on Propaganistas/Laravel-Intl (see packages/Webkul/Core/composer.json) which is abandoned.
I decided to take over the maintenance because I use this package myself in many projects. The migration process will take you less than 5 minutes.
https://github.com/marvinrabe/laravel-intl
If you have any issues, feature request or you need help integrating my package, feel free to create an issue. I will help you in any way possible.
Best,
– Marvin

Hi @marvinrabe
We have removed this dependency from our project, right now we are using php (intl).


Iterate sdks when pkgName is empty

The following pipelines have been queued for testing:java - templatejs - templatenet - templatepython - template You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Enter/Exit Full Screen Programmatically

Browser: Safari (iOS 10)
OS: iOS 10
Clappr Version: 0.2.25
General question - is it possible to enter and exit full screen programmatically? For instance, is there a function I could run to close out of full screen or vise versa?
Something like player.container.exitFullscreen() - I know that isn't a function, but I'm trying to see if the functionality exists.
Thanks!

@Craytor on mobile device, enter fullscreen of video must be initialized with a user action, meaning a tap or click.
The mediaControl component has a toggleFullscreen method. You can experiment it at demo page using the following code example :
var playerElement = document.getElementById("player-wrapper");

var player = new Clappr.Player({
  source: 'http://clappr.io/highline.mp4',
  poster: 'http://clappr.io/poster.png',
  mute: true,
  height: 360,
  width: 640
});

player.attachTo(playerElement);

$('#player-wrapper').append(
  $('<button />')
    .text('Toggle fullscreen')
    .on('click', function(){
      player.core.mediaControl.toggleFullscreen();
    })
);

@kslimani Perfect, thank you - exactly what I was looking for. This should be better documented IMO.


Use Puppet::PUPPETVERSION to get version string

Previously, git describe was being used to get the puppet version,
however this breaks the Jenkins builds. Puppet::PUPPETVERSION is
the better choice here (though we lose the 'rc' tags at the end).

So, I don't think this change is the right way to fix this.  I think git describe is the right way to get the version, but always populating variables that are only used when running specific tasks is the wrong way to go.  The @variable declarations should probably go in a "setup" task that the others depend on.

Spoke with Jacob and I agree with his logic.  Refactoring now and will push when I'm done.

Please don't merge this until I can review
On Dec 8, 2011, at 19:25, Gary<EMAIL_ADDRESS>wrote:

Previously, git describe was being used to get the puppet version,
however this breaks the Jenkins builds. Puppet::PUPPETVERSION is
the better choice here (though we lose the 'rc' tags at the end).
You can merge this Pull Request by running:
git pull https://github.com/glarizza/puppet-1 feature/2.7.x/Rakefile_DMG
Or you can view, comment on it, or merge it online at:
https://github.com/puppetlabs/puppet/pull/263
-- Commit Summary --

Build a Rake task for building Apple Packages

-- File Changes --
M tasks/rake/apple.rake (4)
-- Patch Links --
https://github.com/puppetlabs/puppet/pull/263.patch
https://github.com/puppetlabs/puppet/pull/263.diff

Reply to this email directly or view it on GitHub:
https://github.com/puppetlabs/puppet/pull/263

I reverted the original commit, until this can be properly reviewed and merged.  Before this can be merged in my revert will need to be reverted (0022f4712748907f9cbac8ed6e0082b41014628a).

git should be in the PATH for the jenkins nodes, because we already have a test spec/integration/parser/compiler_spec.rb that executes git rev-parse HEAD


Fix substring/2

Signed-off-by: kuba--<EMAIL_ADDRESS>Closes: https://github.com/src-d/go-mysql-server/issues/418

@kuba-- Could you add some more tests to parse_test.go? You could also check the FROM/TO syntax if its supported by vitess, e.g. SELECT SUBSTRING('Sakila' FROM -4 FOR 2);

@kuba-- could you check @smola 's comment please?

@smola, @ajnavarro - I've added a test with negative index, but neither substring with fixed literal (non column) nor FROM/FOR is not supported by vitess.
Shall we send another PR to vitess?

@kuba-- Ok. I don't think it's very important, but wanted to verify if it worked correctly with the currently supported syntax. If it's a low hanging fruit, it makes sense to file a PR to vitess.


click listeners do not work

The click events are never fired. If I put a transparent view in front of my youtube view, the click event is fired for that transparent view, but then that transparent view steals the click event from the youtube seekbar, play, fullscreen button etc.
Any suggestions?
youTubePlayerView.setOnTouchListener(new View.OnTouchListener() {
            @Override
            public boolean onTouch(View v, MotionEvent event) {
                log.debug( "youTubePlayerView:MOTIONEVENT");
                // Get motion event type
                switch (event.getAction()) {
                    // This event is when user clicks down
                    case MotionEvent.ACTION_DOWN:
                        log.debug( "youTubePlayerView:ACTION_DOWN");
                        EventBus.getDefault().post(new VideoUIControlEvent("EXPAND_VIDEO"));
                        break;
                }
                return true;
            }

        });

      youTubePlayerView.setOnClickListener(new View.OnClickListener() {
           @Override
           public void onClick(View v) {
               log.debug( "youTubePlayerView:setOnClickListener");
           }
       });

Hi, I m going to be traveling for the next couple of days. I ll get back to you when I m home this Sunday :)

That's a problem related to Android, not to the library, if I understand correctly.
Just do a search on Google and learn how to prevent views from intercepting click/touch events.

Could you provide a callback when you capture the click ? That way you would not need to remove the click listeners from the UI controller.

Yeah that would require adding some "non standard" click listener. I'll think about it.
Feel free to send a pull request with your idea.

Hi, @PierfrancescoSoffritti  is it possible if I override dispatchTouchEvent method in SixteenByNineFrameLayout class. will it be helpful to get touch listener I think so.

@PierfrancescoSoffritti I have implemented click listener and sent you a pull request please have look.
#463

The click events are never fired. If I put a transparent view in front of my youtube view, the click event is fired for that transparent view, but then that transparent view steals the click event from the youtube seekbar, play, fullscreen button etc.
Any suggestions?
youTubePlayerView.setOnTouchListener(new View.OnTouchListener() {
            @Override
            public boolean onTouch(View v, MotionEvent event) {
                log.debug( "youTubePlayerView:MOTIONEVENT");
                // Get motion event type
                switch (event.getAction()) {
                    // This event is when user clicks down
                    case MotionEvent.ACTION_DOWN:
                        log.debug( "youTubePlayerView:ACTION_DOWN");
                        EventBus.getDefault().post(new VideoUIControlEvent("EXPAND_VIDEO"));
                        break;
                }
                return true;
            }

        });

      youTubePlayerView.setOnClickListener(new View.OnClickListener() {
           @Override
           public void onClick(View v) {
               log.debug( "youTubePlayerView:setOnClickListener");
           }
       });

Seems like this was never added, how do I add a transparent view tho?

You can add a custom UI and do what you want with it. The default UI doesn't support this yet.


Define studio services

How do we want to identity Studio support for a particular chain
Questions

[ ] Are there multiple "studio" integration by various service providers?
[ ] Can different service provider offer studio services to different chains?
[ ] How to display Studio support when multiple service providers offer Studio support?
[ ] How does a service provider define their studio support per chain?
[ ] What is the URL schema for studio support?

duplicate


ci(owners): setting team as owners

:tada: This PR is included in version 1.63.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[sqlitecpp[sqlcipher]] build failure

Host Environment

OS: Windows 10 Pro 21H2
Compiler: Visual Studio 2019 16.11.9
vcpkg version: Vcpkg package management program version 2021-12-09-724cea8b33cbf06c645f5095fa29773697da9761

To Reproduce
PS C:\dev\vcpkg> vcpkg install sqlitecpp[sqlcipher]
Computing installation plan...
The following packages will be built and installed:
  * sqlcipher[core]:x64-windows -> 4.5.0#1
    sqlitecpp[core,sqlcipher,sqlite]:x64-windows -> 3.1.1#1
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows...
Restored 1 packages from C:\Users\aea_t\AppData\Local\vcpkg\archives in 106.6 ms. Use --debug to see more details.
Starting package 1/2: sqlcipher:x64-windows
Installing package sqlcipher[core]:x64-windows...
Elapsed time for package sqlcipher:x64-windows: 162 ms
Starting package 2/2: sqlitecpp:x64-windows
Building package sqlitecpp[core,sqlcipher,sqlite]:x64-windows...
-- Note: sqlitecpp only supports static library linkage. Building static library.
-- Using cached SRombauts-SQLiteCpp-3.1.1.tar.gz.
-- Cleaning sources at C:/dev/vcpkg/buildtrees/sqlitecpp/src/3.1.1-5e011f3304.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/dev/vcpkg/downloads/SRombauts-SQLiteCpp-3.1.1.tar.gz
-- Applying patch 0001-unofficial-sqlite3-and-sqlcipher.patch
-- Applying patch fix_dependency.patch
-- Using source at C:/dev/vcpkg/buildtrees/sqlitecpp/src/3.1.1-5e011f3304.clean
-- Found external ninja('1.10.2').
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: ninja -v
    Working Directory: C:/dev/vcpkg/buildtrees/sqlitecpp/x64-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      C:\dev\vcpkg\buildtrees\sqlitecpp\config-x64-windows-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:345 (vcpkg_execute_required_process)
  ports/sqlitecpp/portfile.cmake:18 (vcpkg_configure_cmake)
  scripts/ports.cmake:142 (include)

Error: Building package sqlitecpp:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `git pull` and `.\vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+sqlitecpp
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[sqlitecpp]+Build+error
including:
  package: sqlitecpp[core,sqlcipher,sqlite]:x64-windows -> 3.1.1#1
    vcpkg-tool version: 2021-12-09-724cea8b33cbf06c645f5095fa29773697da9761
    vcpkg-scripts version: 2e34a79a8 2022-01-25 (5 hours ago)

Additionally, attach any relevant sections from the log files above.

Failure logs
[1/2] cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "C:/dev/vcpkg/buildtrees/sqlitecpp/src/3.1.1-5e011f3304.clean" "-DSQLITE_HAS_CODEC=ON" "-DSQLITECPP_RUN_CPPLINT=OFF" "-DSQLITECPP_RUN_CPPCHECK=OFF" "-DSQLITECPP_INTERNAL_SQLITE=OFF" "-DSQLITE_ENABLE_COLUMN_METADATA=OFF" "-DSQLITECPP_INTERNAL_SQLITE=OFF" "-DCMAKE_MAKE_PROGRAM=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-DZ_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/dev/vcpkg/packages/sqlitecpp_x64-windows""
FAILED: ../CMakeCache.txt
cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "C:/dev/vcpkg/buildtrees/sqlitecpp/src/3.1.1-5e011f3304.clean" "-DSQLITE_HAS_CODEC=ON" "-DSQLITECPP_RUN_CPPLINT=OFF" "-DSQLITECPP_RUN_CPPCHECK=OFF" "-DSQLITECPP_INTERNAL_SQLITE=OFF" "-DSQLITE_ENABLE_COLUMN_METADATA=OFF" "-DSQLITECPP_INTERNAL_SQLITE=OFF" "-DCMAKE_MAKE_PROGRAM=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-DZ_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/dev/vcpkg/packages/sqlitecpp_x64-windows""
-- The C compiler identification is MSVC 19.29.30139.0
-- The CXX compiler identification is MSVC 19.29.30139.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Using c++ standard c++11
-- CMake version: 3.22.2
-- Project version: 3.1.1
-- CMAKE_CXX_COMPILER 'C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe' 'MSVC' '19.29.30139.0'
-- CMAKE_CXX_FLAGS                ' /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP '
-- CMAKE_CXX_FLAGS_DEBUG          '/D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 '
-- CMAKE_CXX_FLAGS_RELEASE        '/MD /O2 /Oi /Gy /DNDEBUG /Z7 '
-- CMAKE_CXX_FLAGS_RELWITHDEBINFO '/MD /Zi /O2 /Ob1 /DNDEBUG'
-- CMAKE_CXX_FLAGS_MINSIZEREL     '/MD /O1 /Ob1 /DNDEBUG'
-- Checking for module 'sqlcipher'
--   Package 'sqlcipher', required by 'virtual:world', not found
CMake Error at C:/Program Files/CMake/share/cmake-3.22/Modules/FindPkgConfig.cmake:603 (message):
  A required package was not found
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.22/Modules/FindPkgConfig.cmake:825 (_pkg_check_modules_internal)
  CMakeLists.txt:257 (pkg_check_modules)

-- Configuring incomplete, errors occurred!
See also "C:/dev/vcpkg/buildtrees/sqlitecpp/x64-windows-rel/CMakeFiles/CMakeOutput.log".
[2/2] cmd /c "cd ../../x64-windows-dbg && "C:/Program Files/CMake/bin/cmake.exe" "C:/dev/vcpkg/buildtrees/sqlitecpp/src/3.1.1-5e011f3304.clean" "-DSQLITE_HAS_CODEC=ON" "-DSQLITECPP_RUN_CPPLINT=OFF" "-DSQLITECPP_RUN_CPPCHECK=OFF" "-DSQLITECPP_INTERNAL_SQLITE=OFF" "-DSQLITE_ENABLE_COLUMN_METADATA=OFF" "-DSQLITECPP_INTERNAL_SQLITE=OFF" "-DCMAKE_MAKE_PROGRAM=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-DZ_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/dev/vcpkg/packages/sqlitecpp_x64-windows/debug""
FAILED: ../../x64-windows-dbg/CMakeCache.txt
cmd /c "cd ../../x64-windows-dbg && "C:/Program Files/CMake/bin/cmake.exe" "C:/dev/vcpkg/buildtrees/sqlitecpp/src/3.1.1-5e011f3304.clean" "-DSQLITE_HAS_CODEC=ON" "-DSQLITECPP_RUN_CPPLINT=OFF" "-DSQLITECPP_RUN_CPPCHECK=OFF" "-DSQLITECPP_INTERNAL_SQLITE=OFF" "-DSQLITE_ENABLE_COLUMN_METADATA=OFF" "-DSQLITECPP_INTERNAL_SQLITE=OFF" "-DCMAKE_MAKE_PROGRAM=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-DZ_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/dev/vcpkg/packages/sqlitecpp_x64-windows/debug""
-- The C compiler identification is MSVC 19.29.30139.0
-- The CXX compiler identification is MSVC 19.29.30139.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Using c++ standard c++11
-- CMake version: 3.22.2
-- Project version: 3.1.1
-- CMAKE_CXX_COMPILER 'C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe' 'MSVC' '19.29.30139.0'
-- CMAKE_CXX_FLAGS                ' /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP '
-- CMAKE_CXX_FLAGS_DEBUG          '/D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 '
-- CMAKE_CXX_FLAGS_RELEASE        '/MD /O2 /Oi /Gy /DNDEBUG /Z7 '
-- CMAKE_CXX_FLAGS_RELWITHDEBINFO '/MD /Zi /O2 /Ob1 /DNDEBUG'
-- CMAKE_CXX_FLAGS_MINSIZEREL     '/MD /O1 /Ob1 /DNDEBUG'
-- Checking for module 'sqlcipher'
--   Package 'sqlcipher', required by 'virtual:world', not found
CMake Error at C:/Program Files/CMake/share/cmake-3.22/Modules/FindPkgConfig.cmake:603 (message):
  A required package was not found
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.22/Modules/FindPkgConfig.cmake:825 (_pkg_check_modules_internal)
  CMakeLists.txt:257 (pkg_check_modules)

-- Configuring incomplete, errors occurred!
See also "C:/dev/vcpkg/buildtrees/sqlitecpp/x64-windows-dbg/CMakeFiles/CMakeOutput.log".
ninja: build stopped: subcommand failed.

Additional context
vcpkg has been updated and bootstrapped before the attempt to build.
It has worked before on this machine and started to fail after an upgrade.

I can't reproduce this issue with the same test environment.
Could you please remove the following ports and then reinstall sqlitecpp[sqlcipher]:x64-windows again?
sqlcipher:x64-windows
tcl:x64-windows
openssl:x64-windows

No luck, still fails with module sqlcipher not found. I removed the packages, buildtree, downloads and local archives :(

Ok, I completely removed vcpkg and reinstalled it. This fixed the problem and everythings builds again.


feat(docs): docs customer showcase

in a mergable state! nicely done. only open question is around where in the IA we want to put this page.


fix: normalize attribute defaultValue

... to ignore defaults like CURRENT_TIMESTAMP

Codecov Report

Merging #285 (4341ec4) into master (6c8c347) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   97.55%   97.59%   +0.03%
==========================================
  Files          44       44
  Lines        3236     3240       +4
==========================================
+ Hits         3157     3162       +5
+ Misses         79       78       -1

Impacted Files
Coverage Δ

src/bone.js
98.16% <ø> (ø)

src/drivers/abstract/attribute.js
95.91% <100.00%> (+0.36%)
:arrow_up:

src/drivers/sqlite/schema.js
99.00% <0.00%> (+1.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8c347...4341ec4. Read the comment docs.


Added Domain validation

Updated README too

Coverage remained the same at 100.0% when pulling 5a028f09ae76ef83417f9d8a3edcf0e5d69ad7f8 on meydjer:master into 01aa4006968de992604ecc68ec2527d85d98f09e on go-ozzo:master.

Great job. Thanks!


Create Styles at a Global Scale

Currently, styles are all declared at the component level, which is repetitive throughout the Viewer. For consistency purposes, we would like styles to be moved to the global level where the majority/all styles can be referenced from, such as in a file called: “theme.js”

Originally raised by @Bronstrom


Add Bits.extract(), deprecate .U.apply() and .S.apply() for literal bit extracts

Fixes #2413: It is currently possible to pass an integer to the literal .U/.S syntax as a way of immediately bit extracting on a literal value, but this poses confusion and ambiguity as users usually intend to pass a Width.
Contributor Checklist

[ ] Did you add Scaladoc to every public function/method?
[ ] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[ ] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix
new feature/API

API Impact

Aliases all forms of Bits.apply() which perform a bit extract to Bits.extract() for clarity.
Deprecates .U.apply(Int) and .S.apply(Int) as a way of bit extracting on a literal value in favor of .U.extract()
Backend Code Generation Impact
No impact
Desired Merge Strategy
Squash and merge
Release Notes
Deprecate literal bit extracts, e.g. 1.U(8), to prevent users from accidentally passing an integer instead of a Width.
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

Please consider that UInt.extract conflicts with a rocket-chip PML version of same: https://github.com/chipsalliance/rocket-chip/blob/1f05ea88754b421684face06e52260848d27520f/src/main/scala/util/package.scala#L151
I know we rocket-chip folks don’t get to govern Chisel API decisions unilaterally, but if you can find a way to sidestep this collision, please do. One option is just having users explicitly invoke the apply method.

Please consider that UInt.extract conflicts with a rocket-chip PML version of same: https://github.com/chipsalliance/rocket-chip/blob/1f05ea88754b421684face06e52260848d27520f/src/main/scala/util/package.scala#L151
I know we rocket-chip folks don’t get to govern Chisel API decisions unilaterally, but if you can find a way to sidestep this collision, please do. One option is just having users explicitly invoke the apply method.

I wonder if we could just change the behavior of apply(hi, lo) in chisel to match the one of the extract method in rocket chip and then remove the extract from rocket chip? Is there a reason the current behavior of apply(hi, lo) is better?

I wonder if we could just change the behavior of apply(hi, lo) in chisel to match the one of the extract method in rocket chip and then remove the extract from rocket chip? Is there a reason the current behavior of apply(hi, lo) is better?

The Chisel version errors where the Rocket-Chip returns 0.U, when hi == lo-1. I think it's reasonable to have the rocket-chip behavior; however it would be much better if we could return a true zero-width wire rather than a 1-bit zero. This is perhaps in the realm of "reserving the right to have that behavior" but we really need true zero-width wire support.

A reasonable plan here is to just tell users to use .apply and not take the name extract. Some day when we have zero-width wire support we can adopt the rocket-chip behavior and add extract as an alias for apply.
Given the addition of extract in this PR is just to slightly increase user understandability, I think avoiding the PML collision is a fine reason to just not do it [yet] and just tell users to call .apply.

Given the addition of extract in this PR is just to slightly increase user understandability, I think avoiding the PML collision is a fine reason to just not do it [yet] and just tell users to call .apply.

Is this particularly for the 2-argument hi, lo case or are you suggesting getting rid of the .extract() option and suggestion for even the single argument case?

@jared-barocsi can you change the PR title and release notes to reflect this final version, as there is no longer an .extract

Given the addition of extract in this PR is just to slightly increase user understandability, I think avoiding the PML collision is a fine reason to just not do it [yet] and just tell users to call .apply.

Is this particularly for the 2-argument hi, lo case or are you suggesting getting rid of the .extract() option and suggestion for even the single argument case?

For consistency reasons, I think we should only add extract if we're adding it for both versions.