Weaver doesn't run

Followed the instructions in Readme section, but when processing stops on line 10 "Frame frame" and adds the remarque:
You may need to add "import java.awt.Frame;" to the top of your sketch.
To make sketches more portable, imports that are not part of the Processing API were removed in Processing 2.
See the changes page for more information: https://github.com/processing/processing/wiki/Changes
Cannot find a class or type named “Frame”
Where do I have to put the subject (picture), "P" and "L"?

@gibrie, thanks for letting me know about the imports. I'll look into it!
Right now the project is organised in such a way that you may try different examples easily. So to change the image or the number of lines, you will first have to change Weave.pde to set a particular example (by default it uses example03). And then in example.pde, you can modify the variables such as image, the thread color, number of lines, etc.


ToDictMixin

Too often I would prefer to just see the dictionary of the object to quickly glance through all nested objects and I find myself running json.loads(obj.to_json()).
I created the ToDictMixin which gives all objects the method .to_dict() which returns a dictionary of that object.
Right now it uses the ToJsonMixin to hack around it. If you guys have any suggestions on a better approach, happy to dive into that.

Coverage increased (+0.004%) to 97.3% when pulling c07c78bc1253950efdf940f5c713e2321a472897 on Tesorio:to-dict into 027bd46b79d387d98b3099abad436993fa05438e on sidecars:master.

Hey @FabioFleitas, in order to avoid dumping the dict to a str then re-loading it back to a dict, it might be a better idea to have the ToDictMixin return a dict and the ToJsonMixin use the dict mixin to dump to a str.

Coverage decreased (-0.3%) to 96.955% when pulling f7196e8fb7b517bca72a689deb2351cde58344b3 on Tesorio:to-dict into 027bd46b79d387d98b3099abad436993fa05438e on sidecars:master.

Coverage decreased (-0.3%) to 97.013% when pulling e276a45b73f0f042f90748cbe9f017d0cbdfc6de on Tesorio:to-dict into 027bd46b79d387d98b3099abad436993fa05438e on sidecars:master.

@grantmcconnaughey ToDictMixin now no longer relies on ToJsonMixin and uses a recursive function to generate the resulting dictionary. I did not change the ToJsonMixin to utilize the ToDictMixin because I wasn't sure if the resulting object would be exactly the same.
Let me know your thoughts.

@ej2 Let me know your thoughts on this PR and if there's anything else I need to do to get it merged.


Wrong link to https://review.docs.microsoft.com/en-us/powershell/business-central/overview

The links for Dynamics NAV Development Shell currently points to
https://review.docs.microsoft.com/en-us/powershell/business-central/overview - this page is "forbidden".
I guess that the correct should have been: https://docs.microsoft.com/en-us/powershell/business-central/overview

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8bbfc9d0-f60a-30b3-8377-e1f56b67a17f
Version Independent ID: e72a85e4-8fda-9ae0-73f2-015402c04ba5
Content: Product Architecture - Business Central
Content Source: dev-itpro/deployment/product-and-architecture-overview.md
Service: dynamics365-business-central
GitHub Login: @jswymer
Microsoft Alias: solsen

Thanks for catching this - and you're right, the correct URL is https://docs.microsoft.com/en-us/powershell/business-central/overview. The topic will be updated with the next refresh. Thanks.


wrong span for error

If compile and run code bellow with syn 1.0.11 it prints:

err expected : span LineColumn { line: 1, column: 0 } LineColumn { line: 1, column: 0 }

But error location is near String it is not 'line 1, column: 0'.
If fix syntax: _: String, and print spans of arguments of function b all spans are correct.
So something wrong with error span calculation.
fn main() {
    let code = r#"
impl Foo {
   fn b(a: i32, String) {}
}
"#;
    let ast = match syn::parse_file(code) {
        Ok(x) => x,
        Err(err) => {
            println!(
                "err {} span {:?} {:?}",
                err,
                err.span().start(),
                err.span().end()
            );
            return;
        }
    };
}

Thanks! Fixed in 1.0.12.


Update to 18.04 and PX4 v1.9

This is an attempt to use this docker image for the Dronecode SDK integration tests.

I can't actually merge this, it's up to you!

Oh sorry :sweat_smile:


OnePlus Android 11 fails to open ChainLaunchAppListActivity

Hi, I tried the library on my One Plus 7 Pro with Android 11 (Oxygen OS <IP_ADDRESS>GM21BA) installed.
The isAutoStartPermissionAvailable() succeeds but when I call  getAutoStartPermission() I get the following stacktrace.
    android.content.ActivityNotFoundException: Unable to find explicit activity class {com.oneplus.security/com.oneplus.security.chainlaunch.view.ChainLaunchAppListActivity}; have you declared this activity in your AndroidManifest.xml?
        at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:2256)
        at android.app.Instrumentation.execStartActivity(Instrumentation.java:1914)
        at android.app.Activity.startActivityForResult(Activity.java:5326)
        at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:574)
        at android.app.Activity.startActivityForResult(Activity.java:5284)
        at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:560)
        at android.app.Activity.startActivity(Activity.java:5670)
        at android.app.Activity.startActivity(Activity.java:5623)
        at com.judemanutd.autostarter.AutoStartPermissionHelper.startIntent(AutoStartPermissionHelper.kt:325)
        at com.judemanutd.autostarter.AutoStartPermissionHelper.autoStartOnePlus(AutoStartPermissionHelper.kt:308)
        at com.judemanutd.autostarter.AutoStartPermissionHelper.getAutoStartPermission(AutoStartPermissionHelper.kt:118)

I already tried to add the package to the query element in the AndroidManifest
<queries>
        <package android:name="com.oneplus.security.chainlaunch.view.ChainLaunchAppListActivity" />
</queries>

and even tried the prohibited "query all packages permission"
<uses-permission android:name="android.permission.QUERY_ALL_PACKAGES"/>
But both results in the same stacktrace. Any ideas on this?
Edit: I think there is just the overall battery optimization settings on this specific phone and no option for auto-start settings; but it's confusing that the isAutoStartPermissionAvailable() returns true

This should be resolved by https://github.com/judemanutd/AutoStarter/pull/69 but feel free to open this issue back up in case it does not

This should be resolved by https://github.com/judemanutd/AutoStarter/pull/69 but feel free to open this issue back up in case it does not


Class based instead of id based

How hard would it be to fork the code and change it to be class based instead of ID based?

It's element based. Given the following html, you can add the containers to dragula by passing in the elements.

    ...

    ...

Vanilla
var containers = document.getElementsByClassName('container');
dragula(conatiners);

jQuery
var containers = $('.container').toArray();
dragula(conatiners);


Add config to reserve GPU memory

This adds a new plugin config to specify a fixed amount of GPU memory that will be reserved for CUDA driver/runtime usage (e.g.: thread stacks, JIT-compiled kernels, etc.).
This also adds a workaround for https://github.com/rapidsai/rmm/issues/527 so that the user can specify RMM init pool size == max pool size successfully.

build


1.0.0 release of nf-core/rnasplice pipeline

Requesting core pipeline review for 1.0.0 release, as required in the documentation.
PR checklist

[x] This comment contains a description of changes (with reason).
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[x] Make sure your code lints (nf-core lint).
[x] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[x] Usage Documentation in docs/usage.md is updated.
[x] Output Documentation in docs/output.md is updated.
[x] CHANGELOG.md is updated.
[x] README.md is updated (including new tool citations and authors/contributors).

Nice work! I have made a few comments, my main issue is that there are a lot of local modules/subworkflows - can you replace these with nf-core versions or would it be useful to the community to add them as new modules?

Great work! My comment still stands about potentially moving some of your modules into nf-core at some point, but I don't think this needs to hold up release.


Issue with border. .border-{side}-2

Looks like a bug to me.
I'll attach photo and code.
I want to make a left border of DIV to be size of 2 pixels.
In documentation says .border-{side}-2.
So in my code:
<div class="bg-gray-100 border-l-2 border-red-500 w-full">
However, it does not reflects on a page. There is no border at all.
Here is a screenshot:
https://www.dropbox.com/s/67mfnf8gjwqr6le/Screenshot 2019-09-07 11.22.56.png?dl=0
However, when i make only border-l, it works:
https://www.dropbox.com/s/qan8e9hgfwgvnpz/Screenshot 2019-09-07 11.24.27.png?dl=0
I am not sure if this is a bug, or i am doing something wrong.
I am on Mac, Mojave 10.14.6
Latest chrome Google Chrome is up to date
Version 76.0.3809.132 (Official Build) (64-bit)
Please advise.

Hm, after several yarn runs and recompiling, suddenly i got the border as in documentation. Strange. Sorry, i ll close this.


SOLR-12813 followup -- preserve user Principal in alternate codepath in EmbeddedSolrServer

https://issues.apache.org/jira/browse/SOLR-12813
Description
This is a followup to a previous PR that fixed SOLR-12813.
This current change is intended as proactive code cleanup and is not needed for resolving the issue described in SOLR-12813, which was fully resolved by the previous PR.
EmbeddedSolrServer#request() has two separate places where the _parser.buildRequestFrom() utility method is called.
The first codepath is active when the coreContainer.getRequestHandler(path) returns non-null, which is to say that we're able to retrieve the designated SolrRequestHandler by looking it up on the available CoreContainer.
The second codepath is active when coreContainer.getRequestHandler(path) return null and instead we need to retrieve the SolrCore from the CoreContainer and get the SolrRequestHandler from that SolrCore. This second codepath is the one that's used in subquery execution. It was updated in the initial fix for SOLR-12813 so that the call to _parser.buildRequestFrom() would now include the user Principal.
However, the first codepath was left alone because it was not found to be involved in subquery execution. In the present PR, the first codepath is being updated as well, in the interest of keeping the logic as consistent as possible across the two codepaths in EmbeddedSolrServer.request()
Solution
N/A
Tests
I am looking for advice on how to create a test for this change. I believe this change is non-intrusive and safe: when we pass the Principal, it will either be null, in which case the code will act the same as before -- or it will be non-null, in which case we should be passing it. However, it appears that none of the existing unit tests "care" about this change, so it would be good to create a test that targets it. I found some tests which invoke the codepath in EmbededSolrServer.request that we're modifying here, for example TestEmbeddedSolrServerAdminHandler, but they are local SolrTestCaseJ4 instances and I believe we need a SolrCloudTestCase to be able to set up security.json in zookeeper to create a meaningful test... or maybe there's an easier way? If anyone has insight on when/why one codepath would be active instead of the other -- that's to way, why a request handler would be found on the CoreContainer versus only on the SolrCore, I'm interested to know the background.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Tagging @epugh and @dsmiley


build docs on pull requests

This will ensure we don't merge website PRs which
break our documentation deployment.

Merging this manually due to broken CI


Minify javascript source files

xx.js
xx.min.js

not a priority right now + javascript for LUI is so small, it wont really help anything (:


[BUG] UpdateAsync sends whole business partner instead of changed field only causing XML errors [xfer of #18]

Is there an existing issue for this?

[X] I have searched the existing issues

Type of issue
bug
Describe the bug
var businessPartner = await bps.GetAsync("0100000001");
businessPartner.Address.Building = "16 Brook";
await bps.UpdateAsync(businessPartner);
translates to:
Expected Behavior
{ "Address" : { "City" : "Berlin", "PostalCode" : "13467", "Street" : "Calvinstra\u00DFe", "Building" : "16 Brook", "Country" : "DE", "AddressType" : "02", "__metadata" : { "type" : "GWSAMPLE_BASIC.CT_Address" } }, "BusinessPartnerID" : "0100000001", "CompanyName" : "Becker Berlin", "WebAddress" : "http://www.beckerberlin.de", "EmailAddress"<EMAIL_ADDRESS>"PhoneNumber" : "1373", "FaxNumber" : "3088004", "LegalForm" : "GmbH", "CurrencyCode" : "EUR", "BusinessPartnerRole" : "02", "CreatedAt" : "/Date(1658152863000)/", "ChangedAt" : "/Date(1671638524230)/", "ToSalesOrders" : { "__deferred" : { "uri" : "https://demo-sap-apim.azure-api.net:443/sap/opu/odata/iwbep/GWSAMPLE_BASIC/BusinessPartnerSet(\u00270100000001\u0027)/ToSalesOrders" } }, "ToContacts" : { "__deferred" : { "uri" : "https://demo-sap-apim.azure-api.net:443/sap/opu/odata/iwbep/GWSAMPLE_BASIC/BusinessPartnerSet(\u00270100000001\u0027)/ToContacts" } }, "ToProducts" : { "__deferred" : { "uri" : "https://demo-sap-apim.azure-api.net:443/sap/opu/odata/iwbep/GWSAMPLE_BASIC/BusinessPartnerSet(\u00270100000001\u0027)/ToProducts" } }, "__metadata" : { "id" : "https://demo-sap-apim.azure-api.net:443/sap/opu/odata/iwbep/GWSAMPLE_BASIC/BusinessPartnerSet(\u00270100000001\u0027)", "uri" : "https://demo-sap-apim.azure-api.net:443/sap/opu/odata/iwbep/GWSAMPLE_BASIC/BusinessPartnerSet(\u00270100000001\u0027)", "type" : "GWSAMPLE_BASIC.BusinessPartner" } }
instead of:
{ "Address": { "Building":"16" } }
SAP Gateway throws HTTP 500: Method 'IF_SXML_READER~GET_ATTRIBUTE_VALUE' cannot be called at this position in the XML stream
Steps To Reproduce
var businessPartner = await bps.GetAsync("0100000001");
businessPartner.Address.Building = "16 Brook";
await bps.UpdateAsync(businessPartner);
Add screenshots to help explain your problem
No response
Additional context
No response

Triaged. We should
A) Efficiency -> Implement the unit of work pattern to track / compare the last loaded context data and only send back changed data.
B) Diagnostics on why this doesn't work with a full payload from the SAP Side.

B) First, then A) As an Enhancement later.

B) errors with an SAP-Side data error. I've again added a test function that updates and renders this object and it clearly throws.
Proceeding with A)

OK, we can go old-school with an INotifyPropertyChanged type implementation here ?
Something like the below should give us what we need for the change tracking for PATCH operations.
    public List<string> ChangeLog {get; set;} = new List<string>();
    public event PropertyChangedEventHandler PropertyChanged;
    private void NotifyPropertyChanged([CallerMemberName] String propertyName = "")
    {
        PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
    }

    public void AddToChangeLog(string PropertyName, object Value)
    {
        ChangeLog.Add(PropertyName);
    }

    public void ClearChangeLog()
    {
        ChangeLog.Clear();
    }
    public Dictionary<string, object> GetChangeLog()
    {
        return ChangeLog.ToDictionary(x => x, x => this.GetType().GetProperty(x).GetValue(this, null));
    }

    public string GetChangeLogAsJSON()
    {
        // Render the ChangeLog AS JSON
        return JsonSerializer.Serialize(GetChangeLog());
    }

We can formally implement INotifyPropertyChanged here too
This would also mean the objects in the SDK would be bindable in a number of other ways in desktop and web apps, which is probably not a bad thing
So
public abstract class BaseDTOWithIDAndETag : IBaseDTOWithIDAndETag, INotifyPropertyChanged

@MartinPankraz this approach will not recognise row tracking (if you add a update a property on a child collection object - you'd have to call the update method on the child object. We might be able to address that with batching support later.

How should we handle complex nested types (the CT_ pocos) in change tracking ? Should we send those as if they are part of the parent class?

INotifyPropertyChanged, and IWorkTracking interfaces added to be able to track the state of the object, and accept or revert changes from the list.
Interface looks like this
public interface IWorkTracking : INotifyPropertyChanged
{
bool IsChanged {get;}
void RevertChanges();
void AcceptChanges();
void UndoLastChange();
void UndoLastChange(string PropertyName);
Dictionary<string, object> GetChangeLog();
string GetChangeLogAsJSON();

}

now object UndoLastChange and object UndoLastChange(string PropertyName) to get the values reverted

You can also subscribe to this event that we now raise to track changes
PropertyChangedWithValuesEventArgs : PropertyChangedEventArgs


Initial Tech Debt

Before adding any significant new capabilities there is a bunch of work needed to get the existing codebase working well with minimal tech debt.
Tasks

[ ] #114
[x] #123
[x] #143
[x] #115
[x] #145
[x] #146
[x] #3
[x] #50
[x] #116
[ ] #117
[x] #68
[ ] #20
[x] #118
[x] #119
[ ] #120
[ ] #121
[x] #45
[x] #29
[x] #122
[ ] #21
[ ] #124
[ ] #4

Tech debt is an ongoing effort so doesn't make alot of sense to group it all under one never dying batch. Closing out this batch and will track tech debt as separate tasks going forward (with the tech debt label)


[Bug] word level timestamps with zero duration

Hi, I just played with the recently released https://github.com/xenova/transformers.js/issues/68#issuecomment-1627851308 return_timestamps: 'word'. Mostly it produces solid transcription, however, in some instances returned words timestamps have 0 duration, meaning start=end
Here is an example:
27.4 -> 27.4  You
27.4 -> 27.54  have
27.54 -> 27.66  your
27.66 -> 28.02  robotics
...
39.56 -> 39.56  I
39.56 -> 39.56 'm
39.56 -> 39.68  having
39.68 -> 39.9  nightmares
...
42.88 -> 42.88  Oh,
42.88 -> 42.88  what
42.88 -> 42.88  in
42.88 -> 43  our

I am using following script:
import { env, pipeline } from "https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>
env.allowLocalModels = false;

const file = "tos.pcm";
const model = "Xenova/whisper-base.en";
const revision = "output_attentions";
const buffer = new Float32Array(await (await fetch(file)).arrayBuffer());
const pipe = await pipeline("automatic-speech-recognition", model, {revision});

const t0 = performance.now();
const result = await pipe(buffer, {
	chunk_length_s: 30,
	stride_length_s: 5,
	return_timestamps: "word"});

for(let {text, timestamp} of result.chunks)
	console.log(`${timestamp[0]} -> ${timestamp[1]} ${text}`);

console.log(performance.now() - t0);

I wonder if this is related to pipe configuration params or something else potentially fixable on transformers.js level or to be reported elsewhere?

Could you try the unquantized model? Also, since whisper wasn't actually designed for token-level timestamps, it's very possible that the approach which we implemented (dynamic time warping) might make a few mistakes here and there. If you try with the python library, you should get the same output. If you don't, then I'll look into it :)

Here's the original PR: https://github.com/huggingface/transformers/pull/23205#issuecomment-1561371887 (with a colab notebook on how to run it).

I tried the notebook modified one step following https://gist.github.com/hollance/42e32852f24243b748ae6bc1f985b13a
pipe = pipeline(model="openai/whisper-base.en")

alignment_heads = [[3, 3], [4, 7], [5, 1], [5, 5], [5, 7]]
pipe.model.generation_config.alignment_heads = alignment_heads

Using the same source (.mp3 instead of .pcm) tos.zip
it produces:
  {'text': ' You', 'timestamp': (27.42, 27.42)},
  {'text': ' have', 'timestamp': (27.42, 27.54)},
  {'text': ' your', 'timestamp': (27.54, 27.66)},
  {'text': ' robotics', 'timestamp': (27.66, 28.0)},
...
{'text': " I'm", 'timestamp': (39.48, 39.54)},
  {'text': ' having', 'timestamp': (39.54, 39.64)},
  {'text': ' nightmares', 'timestamp': (39.64, 39.9)},
...
{'text': ' Oh', 'timestamp': (43.04, 43.04)},
  {'text': ' wait,', 'timestamp': (43.04, 43.04)},
  {'text': " we're", 'timestamp': (43.04, 43.04)},
  {'text': ' done!', 'timestamp': (43.04, 43.58)},

Interesting findings:

timestamps are better in 2/3 cases, yet not perfect
using same model and params (afaik) it produces better text like "I'm" comes as a single word unlike in .js where its two
accuracy is also better

.mp3 instead of .pcm

This might cause some minor differences, but not a big deal.

timestamps are better in 2/3 cases, yet not perfect

👍

"I'm" comes as a single word unlike in .js where its two

Will look into that - it should be merged :)

Fixed the punctuation issue here. This should actually fix many of the zero-duration timestamps (since they are merged into one now).
As for the others (and as you've seen when running the python version), those are just limitations of the algorithm. In future, it might be worth improving the python version, and when that is done, I could bring those changes here too.

Hi @xenova , should "punctuation issue" be joining I'm together as a single? Using 2.5.2 , I am still seeing it as two.

Yes that will be fixed in 2.5.3 (which I still need to release)! 🤗

Released! 🥳<EMAIL_ADDRESS>


pep8-naming: configuring classmethod-decorators

Issue
Currently ruff (0.0.270) does not seem to respect the classmethod-decorators option for pep8-naming. However, in the past this setting was respected. The regression seems to have been introduced in the 0.0.220 -> 0.0.221 release.
Reproducing  example
With the following snippet (see below for pyproject), ruff 0.0.220 correctly identifies an error only on the "bad" method, whereas current ruff identifies both methods as incorrect:
def extra_classmethod(method):
    return classmethod(method)

class Foo:
    @extra_classmethod
    def good(cls):  # should be ok
        ...

    def bad(cls):  # should be flagged
        ...

Here's the pyproject.toml (options taken from docs at https://beta.ruff.rs/docs/settings/#classmethod-decorators):
[tool.ruff]
select = ['N']
[tool.ruff.pep8-naming]
classmethod-decorators = ['extra_classmethod']

We don't support decorators that are defined in the same file right now, because classmethod-decorators takes a list of fully-qualified symbols, not a list of string names or regular expressions.
That's why, e.g., you need to use pydantic.validator, so that we respect:
import pydantic as foo

class Foo:
    @foo.validator
    def good(cls):
        ...

If you move your decorator out to a separate file, and then use the fully-qualified path instead of the string name, it should work. Ideally we'd let you use the fully-qualified path for symbols in the module they're defined (e.g., if your file above is foo.py, you would specify ["foo.extra_classmethod"]), but I'd still want to use fully-qualified paths rather than string names.

OK, I understand - yeah it works if I move out to another file.
It would be nice if we could write foo.extra_classmethod, but I guess it's quite a small edge case with the in-file method

I'm going to close for now since the same-file thing is a little bit of a bigger issue than this specific question.


Wrong indentation of brackets in comments

Brackets in commnets
function fetch_site(url, i) {
    var xmlhttp = new XMLHttpRequest();

    /*
    // Milliseconds a request can take before automatically being terminated - async only
    xmlhttp.timeout = 500;
    xmlhttp.ontimeout = function () {
    content[i] = "none";
    console.log("ontimeout: content[" + i + "] is now set to " + content[i] );
}; // <-- Guess this should not be like it is currently
*/

// On error
xmlhttp.onerror = function () {
    content[i] = "none";
    console.log("onerror: content[" + i + "] is now set to " + content[i] );
};

The bracket of the fetch_site function does not close at the marked (<--) line. The closing bracket is not even near this line.

My package is just using the "Editor: Indent" (it's basically doing "cmd+a cmd+i").
If there's an issue with the indentation you should create an issue on atom's repo.


Update Duplication Request Modal to support new RAC fee model

Fixes #680
Fixes #682

Adds new language to quickly orient researchers to the associated fee and request limit, and provides accurate links for them to find more detailed information.
Removes select menu to choose a format, since the user does not actually choose the format.
Updates associated translations
Also tweaks the datepicker styles to fix issue of times not being fully visible in UI.

Note: Once merged, we'll need to update related analytics events in Matomo Analytics.
Screenshot of updated UI (note that captcha doesn't load in local build):

I see the Travis fail, working to update the tests now...

This looks good! Can you connect with Patrick on the translation question?

@p-galligan this is ready for translation updates.

@helrond are we good to merge this?


how to train Fully Supervised Object Detection using my own dataset? What is the specific process of training？

Hello, great job! Could you please tell me how to train Fully Supervised Object Detection using my own dataset? What is the specific process of training?

@ReusJeffery Fully-supervised training is simply the default training of Detectron2, which uses labels of all categories. Please refer to Detectron2 for training on your own dataset. The only major difference is to initialize the model with our pre-trained RegionCLIP.


Add support for templates

As of 7.01 it would be great to support the new templates for smart home plans.

+1 for this


have an option REFUSED_FILE_TYPES or similar to refuse certain file types to be commited to repository.

Feature Description
Implement an option, for example REFUSED_FILE_TYPES to specify a list of files that are NOT allowed to be pushed to the repository (eg. exe, zip).
No file of the specified type could be added/pushed/uploaded to the repository/ies
Screenshots
No response

A protected file pattern can be applied to a specified branch. Can it serve the goal?

@lng2020 if one cannot push the files with those extensions, then yes.

@lng2020 if one cannot push the files with those extensions, then yes. I meant this more for the repository than the branch.

Surely it can

This rule covers all branches in the repo

@lng2020 looks fine, this would do.


stat/running: Implement package for computing stats of a stream of data

Please take a look.
Fixes #1037

Sorry, this was branched from the wrong place.


Add FactoryInfo wrapper to provide the access to the FactoryId

Related to #333

User may create its own custom FactoryInfo wrapper as following https://dotnetfiddle.net/s5NpP4

Added the custom implementation to the docs here: https://github.com/dadhi/DryIoc/blob/master/docs/DryIoc.Docs/Decorators.md#reusing-the-scoped-service-from-the-parent-scope


Improvement Improve count distinct distribute keys

Proposed changes
Note: this is only BE part.
Improve count distinct(distrbute key).
I test on Clickbench:

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


feat: Added SwButton

@AddieCohen Closing this as the button will be re-written so it's not going to be relevant anymore :( Sorry


Mark robot#respondPattern as Public method.

Marks robot#respondPattern as public. See comments in https://github.com/github/hubot/pull/975 for details.

Sorry it took a bit to get back to this. I just found a use for this (a receive middleware as part of https://github.com/github/hubot/pull/1019), so motivated to merge this now.  Thanks!


Do not identify files multiple times

We have a rather big multi-project build.
There are several sub-projects with the actual business logic and a few aggregator projects that produce the final artifacts (an ear, two wars, and a zip).
If I just apply the plugin and use the aggregate task, it runs for half an hour.
If I restrict the projects to the aggregator projects, the whole build needs about 2 minutes and finds almost the same issues. The differences are only in compileOnly dependencies, so not really relevant.
It is not the actual analyzers that consume the time, but it is the collecting of the artifacts to analyze in the Gradle plugin that needs most of the time.
I'd like to suggest to there have some facility that for example remembers by file path, or checksum or whatever, that the file is already analyzed and identified.
I'd prefer to just analyze all projects to not accidentally forget something that for example gets added later, but not for 1500% time penalty.

I'm betting a lot of this time was during checksum calculation. Enahancements have been made to 5.3.1 (which should be released soon) that made a huge improvement in scan time for larger projects that might have duplicates.

I believe this is fixed.


Refactor code for readability

The current implementation of the code is very unreadable for several reasons:

There are no line breaks between sections of code, so for example a function like multiplotbokeh (https://github.com/SIMPLE-AstroDB/SIMPLE-web/blob/main/simple_app/plots.py#L218) is nearly 200 lines all back to back with no extra context. These should be split for more easily parsing what is going on, which can help us identify sections of code that could be improved in the future.
Comments are being placed at the end of the line rather than at the beginning of logical sections. This is in tandem with the change above. A comment at the end of a line like "x-axis" doesn't really add any value, whereas one describing what's going to happen over the next 5 lines is far more useful.

I also noticed some variable names (in utils.py) which were not very readable and were missing underscores between words.


Nodes can't communicate over the internet

I'm trying to deploy a Copycat cluster on Azure and getting issues if the nodes aren't on the same private network.
If I try to start a server with the public IP of the machine, it fails:
[copycat-server-/<publicIp>:10101-copycat] netty.NettyServer.listen - Binding to /<publicIp>:10101
[copycat-server-/<publicIp>:10101-copycat] server.CopycatServer.lambda$start$30 - Failed to start server!

which makes sense, since it's not on any of the interfaces.
If I try to bind it to <IP_ADDRESS>, it works, but then <IP_ADDRESS>:X gets advertised as the server (member) address in requests and nodes can't send back any responses.

Just want to follow up on this – are there any plans to support cross-network deployments?


APP-411: Profiling and grouping demo - description mistakes

http://jira.kaaproject.org/browse/APP-411

@tonyshkurenko review please.

@kaa-leeroy test this fully please


Add File Iteration Option

Hi there,
I would like to propose a feature request for a file iteration option.
Use case
I have a use case with roughly 35'000 XML source files that I want to convert to RDF.
Approaches Taken With CARML JAR
So far, I have taken two approaches:

Call the CARML Jar for each input file: this means calling the JAR > 35'000 times. With each call, there is a constant loss of time regardless of the size / complexity of the XML file I want to map. Therefore, this is not an efficient way to do it.
Generate a virtual XML file with a virtual root element that can be used in the mapping's iterators. Example: (echo "<projects>"; cat cordis/project-rcn-*.xml ; echo "</projects>") |  java -jar carml-jar-1.0.0-SNAPSHOT-0.4.4.jar map -m rml-cordis_mapping.ttl -of ttl -p schema=http://schema.org/. This approach is quite performant but it requires a change in the mapping's rml:iterators (/projects) and this virtual root element does not exist in the actual XML source. Also debugging is hard in case an error occurs. Another issue is validation which is quite straight forward if it can be applied to multiple single RDF outputs (instead of one huge output graph).

Feature Request
I would be convenient if CARML JAR would accept an input directory option -id and iterate over the files contained in this directory.
This feature would also work for JSON input files but would probably not make sense for CSV files.
I think it would also be convenient if this could be achieved using carml:Stream in the mapping itself. This way CARML JAR would completely control the handling of the input.
Ideally, there would be a corresponding output directory option -od where the results would be written to (as single files). So there would be a one-to-one relation between input XML/JSON and output RDF files.
I would find this convenient because invalid graphs (as individual files) could be looked at separately and would not block the whole process.
Example of usage:  java -jar carml-jar-1.0.0-SNAPSHOT-0.4.4.jar map -m rml-cordis-mapping.ttl -of ttl -p schema=http://schema.org/ -id cordis -od out
Mapping:
<#LogicalSourceProject> a rml:BaseSource ;
    rml:source [
        a carml:Stream
    ] ;
    rml:referenceFormulation ql:XPath ;
    rml:iterator "/project" .

If an error occurs, the name of the input XML/JSON file should be indicated too.
Then these files could be removed from the input directory and looked at separately.
Let me know if this description is clear and where I could help.

@tobiasschweizer thanks for this. The description is clear. I have to think a bit on how to best approach this. Will get back to you on that.

@tobiasschweizer just FYI we processed 50 million XML files using our https://github.com/zazuko/carml-service/. It is very fast that way and we then have pipelines that simply process mapping & data and send it to the service. Let me know when you need some boilerplate, you still have some hours in a contract with us :)

@ktk that's pretty cool!

@ktk nice to hear from you, it has been a while :-)
I am aware of the existence of https://github.com/zazuko/carml-service/. We talked about this back in July together with Bart. 50 million XML files is an impressive number. I am still an RML dwarf.
This is why I haven't used https://github.com/zazuko/carml-service/ so far:

no automatic update of the carml-service when a new version of CARML is available. Currently, it uses CARML 0.4.1 (https://github.com/zazuko/carml-service/commit/d0842fb27694563019802e2706d1ebf29e303e4f). I think ideally there should be an automated process that makes a new release once a new CARML version is available.
effort of setting up and maintaining a tomcat server to run the WAR

If we could find a solution for 1. I will happy to try 2. :-)
In any case, I would be happy if someone could review our current pipeline.


fix: multiline yaml strings in swagger.yaml

The Wallet API swagger.yaml contained invalid multiline strings (descriptions). This PR fixes it.

bors merge

bors r+


Organization of the YouTube-VOS dataset in the ‘myData’ folder for LAFC Net training?

Hi, I have organized the YouTube-VOS dataset in the 'myData' folder, as shown below, for LAFC Network training
$ cd LAFC
$ python train.py
FGT/myData
|- youtubevos_frames
|- bmx-bumps
|- <00000>.jpg
|- <00001>.jpg
|- youtubevos_flows
|- backward_flo
|- bmx-bumps
|- <00000>.flo
|- <00001>.flo
|- forward_flo
|- bmx-bumps
|- <00000>.flo
|- <00001>.flo
But the problem I'm having is that there is no such file or directory: '/myData/youtubevos_flows'. The logs are shown below.
using GPU 4-4 for training
using GPU 3-3 for training
using GPU 1-1 for training
self.opt[datasetName_train] train_dataset_edge
self.opt[datasetName_train] train_dataset_edge
self.opt[datasetName_train] train_dataset_edge
self.opt[datasetName_train] train_dataset_edge
self.opt[datasetName_train] train_dataset_edge
Traceback (most recent call last):
File "train.py", line 70, in
main(args_obj)
File "train.py", line 59, in main
mp.spawn(main_worker, nprocs=opt['world_size'], args=(opt,))
File "/raid2/hwpeng/miniconda3/envs/FGT_ENV/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 230, in spawn
return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
File "/raid2/hwpeng/miniconda3/envs/FGT_ENV/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 188, in start_processes
while not context.join():
File "/raid2/hwpeng/miniconda3/envs/FGT_ENV/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 150, in join
raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:
-- Process 2 terminated with the following error:
Traceback (most recent call last):
File "/raid2/hwpeng/miniconda3/envs/FGT_ENV/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 59, in _wrap
fn(i, *args)
File "/raid2/hwpeng/Project_Coding/FGT/LAFC/train.py", line 30, in main_worker
trainer = pkg.Network(opt, rank)
File "/raid2/hwpeng/Project_Coding/FGT/LAFC/trainer.py", line 24, in init
self.dataInfo, self.valInfo, self.trainSet, self.trainSize, self.totalIterations, self.totalEpochs, self.trainLoader, self.trainSampler = self.prepareDataset()
File "/raid2/hwpeng/Project_Coding/FGT/LAFC/trainer.py", line 129, in prepareDataset
train_set = create_dataset(dataset, dataInfo, phase, self.opt['datasetName_train'])
File "/raid2/hwpeng/Project_Coding/FGT/LAFC/data/init.py", line 38, in create_dataset
dataset = dataset_package.VideoBasedDataset(dataset_opt, dataInfo)
File "/raid2/hwpeng/Project_Coding/FGT/LAFC/data/train_dataset_edge.py", line 29, in init
self.train_list = os.listdir(self.data_path)
FileNotFoundError: [Errno 2] No such file or directory: '/myData/youtubevos_flows'

I have organized the YouTube-VOS dataset in the 'myData' folder, as shown below, for LAFC Network training
FGT/myData
|- youtubevos_frames
|-|- bmx-bumps
|-|-|- <00000>.jpg
|-|-|- <00001>.jpg
|- youtubevos_flows
|-|- backward_flo
|-|-|- bmx-bumps
|-|-|-|- <00000>.flo
|-|-|-|- <00001>.flo
|-|- forward_flo
|-|-|- bmx-bumps
|-|-|-|- <00000>.flo
|-|-|-|- <00001>.flo

**The code now works successfully, organising the data as above.
I used 6 GPUs (Tesla V100 16GB) to train the FGT model and found that it took me 10 hours but only ran for 5 epochs and 3232 iterations. The training details are as shown as following:**
22-11-30 09:06:13.689 - INFO: [epoch:  5, iter:   3200, lr:(1.000e-04, 1.000e-04, )] mean_loss: 2.8053e-01 mean_psnr: 27.30707745212495 mean_ssim: 0.9329263906482018 mean_l1: 13.470138085133744 mean_l2: 0.005076394467977023
22-11-30 09:09:12.083 - INFO: [epoch:  5, iter:   3216, lr:(1.000e-04, 1.000e-04, )] mean_loss: 2.7653e-01 mean_psnr: 27.714950755848747 mean_ssim: 0.9371985766617273 mean_l1: 12.699865040580704 mean_l2: 0.004905342148719834
22-11-30 09:10:52.628 - INFO: [epoch:  5, iter:   3232, lr:(1.000e-04, 1.000e-04, )] mean_loss: 2.9692e-01 mean_psnr: 27.26850985644835 mean_ssim: 0.9348241097911801 mean_l1: 12.600507330246913 mean_l2: 0.00498391306565287
Your published paper states that the number of training iterations for FGT is 500K on Youtube-VOS. I would like to know your training devices and training days for the FGT model.
Thank you for your amazing work!

Thanks for your interest in our work. According to the training log, the convergence is normal but the speed is much slower than mine. The final version of FGT model takes about 9 days to train, and I used 4 Tesla V100 GPUs (16G) to train the 500K model. Maybe you can try some acceleration strategies to ameliorate the training speed, e.g. load the data to cache to improve the IO.

This is my training log, may it can become a reference.

Maybe this is caused by your CPU usage. Since the CPU is blocked by IO and diffusion of the optical flows (the preprocessing we used in the flow completion stage), the GPU cannot be fully exploited.

Nowadays, we are also exploring the strategy to accelerate the training process (because I think 9 days is also somewhat long for practical usage). A practical solution is that you can adopt spynet as the flow extractor during training (just as E2FGVI does), and replace it with the completed optical flows from LAFC during inference, because in such manner, you do not have to read extra optical flows during training, which may accelerate training.

Thanks for the advice on model training acceleration. Also, I look forward to your further strategies in accelerating the training process and it would be terrific if the training time could be further reduced.

I would like to know if the 9-day training includes 2-stage of training, i.e., LAFC network and FGT network, or only the FGT network requires 9 days of training.
Moreover, it seems that optical flows are extracted in advance by the LAFC network, and the dataset is arranged as follow before training the FGT network.
FGT/myData
|- youtubevos_frames
|-|- bmx-bumps
|-|-|- <00000>.jpg
|-|-|- <00001>.jpg
|- youtubevos_flows
|-|- backward_flo
|-|-|- bmx-bumps
|-|-|-|- <00000>.flo
|-|-|-|- <00001>.flo
|-|- forward_flo
|-|-|- bmx-bumps
|-|-|-|- <00000>.flo
|-|-|-|- <00001>.flo
So, I don't understand the meaning "A practical solution is that you can adopt spynet as the flow extractor during training (just as E2FGVI does), and replace it with the completed optical flows from LAFC during inference, because in such manner, you do not have to read extra optical flows during training, which may accelerate training". Because in my understanding there is no need for optical flow extraction during the second stage of the FGT network training.

9-days training is only for training of FGT, not the whole training time. However, the first stage is fast, only takes about two days.
Our flow completion process consists of two parts, the first part is the Laplacian filling, and the second part is the LAFC network. The Laplacian filling process requires to solve a Laplacian equation, which needs a powerful CPU. What's more, reading optical flows at full resolution may give more pressure to the IO, which may also lower the training speed (just as your training log). Therefore, if you adopt spynet as the flow completion (just as E2FGVI does) operator, you can avoid the LAFC during training (for more details please refer to the E2FGVI paper). But the flows completed by spynet are low quality compared to our completion results, and the performance may degrade. Therefore, during inference, you can adopt the optical flows completed from LAFC for a better performance.

Thanks so much for sharing the details, I now have a better understanding of your model. You have done a fantastic research work！

You are welcome. I will close this issue. If you have any further questions, please feel free to ask. Thanks for your interest in our work.


crystal: unbreak on 20.09 [WIP]

Motivation for this change
Crystal was broken on 20.09 so backport the fixes from unstable that makes things work again.
Doing a test deployment right with this.
Cc @NixOS/crystal-lang
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build crystal_0_34 crystal_0_31 crystal_0_35

@GrahamcOfBorg build crystal_0_34 crystal_0_31 crystal_0_35


Rain water problem

There is a famous rain water trapped between buildings . This is a geeksforgeeks problem .
There are 2 methods possible to solve this problem . And this is asked in faang companies too.
Programming language

[ ] C
[ ] C++
[ ] Java
[ ] Python

Please assign me this task for C++ language .

Please assign me this, I have already solved this in Java language. @Amit366 @ravikr126 @Ayush7614

assign me this , i want to solve it in cpp

assign me this under java language.

please check my PR #2038 @ravikr126

assign me this under java language.

@Amit366 @ravikr126 @Ayush7614

@ravikr126  can you please tell how to delete binary file it is still showing and no delete option is coming


la-go-live

Docs Build status updates of commit bb0c190:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Three_Tiers.png
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/application-certification.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
:white_check_mark:Succeeded
View

msteams-platform/graph-api/import-messages/import-external-messages-to-teams.md
:white_check_mark:Succeeded
View

msteams-platform/graph-api/proactive-bots-and-messages/graph-proactive-bots-and-messages.md
:white_check_mark:Succeeded
View

msteams-platform/graph-api/rsc/resource-specific-consent.md
:white_check_mark:Succeeded
View

msteams-platform/resources/dev-preview/developer-preview-features.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/visual-studio-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Ctrl+f does not open firefox search bar, but works as "open link"

I have the "open link" key set to f. When I press f, it shows blue letters on white background for all the links.
When Ctrl+f is pressed, I expect firefox to open the search bar. This works fine when Saka Key is disabled. But when Saka Key is enabled, Ctrl+f shows the same behaviour as just pressing f, i.e. it shows letters for the links.
Firefox 59.0.1
Saka Key 1.25.2

Just a wild guess, but perhaps you have swapped the position of the Ctrl key with something else. E.g. I have Ctrl and CapsLock swapped. In such a case you must make sure that the Sata option "Bind to physical keys (en-US QWERTY) not characters" is turned off (it is on by default).


Fix shadow delta callback handler

Fixes a bug where shadow client will not call the configured delta callback handler. It instead calls Update callback.
Description of changes:
Actual:

Application registers shadow request callback handlers (with Shadow::AddShadowSubscription api) as follows:

Update callback handler => U
Delta callback handler => D

On update (accepted or rejected), U is called.
On delta, U is called (instead of D).

Expectation:

Application registers shadow request callback handlers (with Shadow::AddShadowSubscription api) as follows:

Update callback handler => U
Delta callback handler => D

On update (accepted or rejected), U is called.
On delta, D is called.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Any update on this?


Support RAM start/end positions (update rectangular region)

On branch feature/window, includes 2 functional demos. Needs testing before merge request.


align the hash that rubocop made wonky

/cc @segiddins

@homu r+

:pushpin: Commit 000a8f4 has been approved by segiddins

:hourglass: Testing commit 000a8f4 with merge e6c4b30...

:sunny: Test successful - status


Error: Workspace command kernel-install add 6.5.0 /lib/modules/6.5.0/vmlinuz returned non-zero exit code 1.

Hello
Running run_qemu with [1] failed at [2], could anyone help check it?
And could you help provide the workable environment, so I can try with them.
[1]
DISTRO: Fedora release 39 (Thirty Nine) with 6.5.0-0.rc7.20230821gitf7757129e3de.50.fc39.x86_64
Linux: latest linux tree: https://github.com/torvalds/linux.git
mkosi: mkosi-14-5.fc39.noarch

[2]
#run_qemu.sh --cxl
--snip--
‣      Unmounting API VFS…
‣    Unmounting Package Cache
‣    Setting root password
‣    Setting up autologin…
‣    Removing random seed
‣   Unmounting image…
‣  Detaching /dev/loop0
‣  Installing cache copy…
‣  Installed cache copy root.img.cache-pre-inst
‣  Changing ownership of output file /root/git/linux/qbuild/root.img.cache-pre-inst to user root…
‣  Changed ownership of /root/git/linux/qbuild/root.img.cache-pre-inst
‣ Running second (final) stage…
‣  Basing off cached image /root/git/linux/qbuild/root.img.cache-pre-inst
‣  Copied cached image as /root/git/linux/qbuild/.mkosi-i88mczn7
‣  Refreshing partition table…
Partition #1 contains a vfat signature.
Partition #2 contains a ext4 signature.
‣  Refreshed partition table.
‣  Attaching /root/git/linux/qbuild/.mkosi-i88mczn7 as loopback…
‣   Refreshing file system /dev/loop0p2…
tune2fs 1.47.0 (5-Feb-2023)
‣   Mounting image…
‣    Copying in extra file trees…
‣    Generating initramfs images…
/usr/bin/dracut: line 1056: /sys/module/firmware_class/parameters/path: No such file or directory
dracut: No '/dev/log' or 'logger' included for syslog logging
/usr/bin/dracut: line 1056: /sys/module/firmware_class/parameters/path: No such file or directory
dracut: No '/dev/log' or 'logger' included for syslog logging
cp: error writing '/efi/99d5c5d911e74e8192390fba2a07d2a2/6.5.0/initrd': No space left on device
dracut: Creation of /efi/99d5c5d911e74e8192390fba2a07d2a2/6.5.0/initrd failed
‣ Error: Workspace command kernel-install add 6.5.0 /lib/modules/6.5.0/vmlinuz returned non-zero exit code 1.

@yizhanglinux Looks like you just ran out of space on the guest image. This can happen if you add a few different kernel builds worth of lib/modules/* - in that case you can try nuking the image and starting from scratch with a '-r wipe'.
If the image size does need to grow (i.e. if this is a fresh build), that can be done using the rootfssize variable near the top of the run_qemu.sh script. It is currently set to 10G, you can try making it 12G or so.

Unless you're going to copy/backup the image with a hole-ignorant tool, making the size drastically larger (40G? 100G?) costs nothing as the file will be sparse on the disk.
If discard is enabled, the image file will also require less storage upon guest file deletion, as qemu will translate discard requests into unmapping parts of the image file, thus restoring sparseness.

Please:

upgrade to the latest run_qemu
upgrade Fedora because v39 is not supported anymore
apply @stellarhopper's suggestions
re-open if you can still reproduce


Iframes auth redirect

This PR in conjunction with #939 provides an option for applications living out of an iframe to handle interactive requests using "redirect".
Problem description:
Some identity flows cannot be completed in an iframe. In particular:

Credential Entry
Consent

Clickjacking  is an attack whereby a malicious site iframes a trusted site and displays it to the user while simultaneously providing a transparent iframe on top of the trusted site. This transparent iframe is invisible to the user, but is able to record keystrokes (e.g. the password). Alternatively, a malicious site can move the trusted iframes it shows, permitting them to always move the "Consent" button to directly under the users mouse. Without going into detail, the only mitigation here is to forbid iframes on these flows. Identity permits services to use iframes only in combination with prompt=none, which ensures that these flows are not hit.
These limitations placed by Identity Service block any user interaction in an iframe app. This effectively requires all applications to be able to use a top-frame (either the current frame or a pop-up frame) to solve user interaction required prompts.
To mitigate this and have applications perform authentication in iframes, we are adding the below changes for different flows:

[x] #939 helps with silent and popup calls where additional logic is added to monitor the popup/iframe opened by the MSAL JS to process the token as soon as the service redirects the request. APIs that are supported in iframed applications with this change are:

loginPopup()

acquireTokenPopup()

acquireTokenSilent()

[x] #975 (this PR) supports the "redirect" APIs by establishing a trusted relationship with the parent application (the top frame). As expanded above, the iframed application is prohibited from any interaction by microsoft identity service and hence this can be supported only with a trusted relationship with the parent application (which is a full window and hence can render interactive screens)

Detailed documentation on the protocol applied here will be published with the release of both these PRs.

@pkanher617 @jasonnutter Addressed all the comments. Please review. I have retained some open issues on naming/type checks, will address them separately post release.


Bug: passing dynamic parameters does not work when using and([]) in guard

XState version
XState version 5
Description
Hi, awesome library, thank you so much for your work!
I want to combine defenders in my event, for example like this:
example: {
      on: {
        EVENT_NAME: {
          guard: and([
            'someGuard',
            {
              type: 'someGuard2',
              params: ({ event }) => ({ some: event.some }),
            },
          ]),
        },
      },

I decided to try this because I saw such a case study in your test files, but didn't check their execution
But in a case like this I run into two problems:

Typing doesn't work (suppose you don't accept such a case, then it's logical)
Guard is not called at all

If this case is not admissible, could you then highlight how I can solve my problem?
Expected result
I expect the syntax I'm using will work with the new fix version
Actual result
not work
Reproduction
--
Additional context
No response

Sorry, it's my mistake, I tried your tests, tried my code and everything is ok.
The only problem is with types, this syntax breaks typing, are there any plans for this?


Drag freezes when originally dragged element is removed from DOM

I observe this in iOS safari, as every other browser I support has native Drag & Drop.
This is how this works in desktop and chrome for android.

In safari I can use drag and drop to sort within the same list (drop-area) but if fails if I trans to drag from one area to another one.

If I inspect the logs, when the drag freezes I can see in the console some messages looping for ever. They don't stop, no matter what I do or where I click:
[Log] dnd-poly: d'n'd iteration ended. current drag operation: move (vendor.js, line 51807)
[Log] dnd-poly: dispatching drag (vendor.js, line 51514)
[Log] dnd-poly: new immediate user selection is: [object HTMLLIElement] (vendor.js, line 51761)
[Log] dnd-poly: dispatching dragover (vendor.js, line 51514)
[Log] dnd-poly: dragover prevented. (vendor.js, line 51803)
[Log] dnd-poly: d'n'd iteration ended. current drag operation: move (vendor.js, line 51807)
[Log] dnd-poly: dispatching drag (vendor.js, line 51514)
[Log] dnd-poly: new immediate user selection is: [object HTMLLIElement] (vendor.js, line 51761)
[Log] dnd-poly: dispatching dragover (vendor.js, line 51514)
[Log] dnd-poly: dragover prevented. (vendor.js, line 51803)
[Log] dnd-poly: d'n'd iteration ended. current drag operation: move (vendor.js, line 51807)
...

Hi and sorry for the long delay. Can you provide me a git repo or stackblitz/plunkr which reproduces the problem so I can take a look and play with it?

Is there any solution for this one ? I'm also experiencing it.

Hey @rappners I've created a simple demo where you can reproduce this issue. Steps to reproduce:

Open https://stackblitz.com/edit/angular-jxj2v4 from the mobile safari.
Start dragging some element named 'Initial_...' and enter the top div named '3ENTER HERE WITH ELEMENT WHO IS BEING DRAGGED'.

Expected behaviour : The elements are updated and the drag and drop can be used again.
Actual behaviour: The elements are updated but the dragged element 'freezes' and the drag and drop is disabled, If you try to drag and drop again, it won't work.
You can see the codebase here: https://stackblitz.com/edit/angular-jxj2v4
Would be great and helpful for the community if this one gets some solution.
Thanks in advance. !
At all , when the view/data is being updated while dragging some element the element itself freezes and the drag in drop is being disabled.

Thanks for providing a reproduction, I'll try to track down the root cause.

I'm a bit uncertain on how to workaround this if even possible.
See

https://docs.google.com/document/d/12-HPlSIF7-ISY8TQHtuQ3IqDi-isZVI0Yzv5zwl90VU/edit#heading=h.q2zqz8v0mja7
https://github.com/facebook/react/issues/1355

Hey @reppners I found a workaround which fits my case. Instead of updating the existing elements (destroying the element that is being dragged), I've created 2 components with the same elements and just toggling the visibility with [hidden] attribute. This way the dragged element is not being destroyed but instead hidden and everything works perfectly. Not the brightest solution but it works perfectly :)

Closing as non-actionable on the library level but workarounds can be made at application level 👍


Provide a built docker image

Would be nice if one could just use an existing official docker image instead of having to build it.

we are nice people
https://hub.docker.com/r/codiumai/pr-agent/tags
https://pr-agent-docs.codium.ai/installation/locally/#using-docker-image

wow.. guess i did not look close enough :sweat_smile:
Could it be that i actually still need to to this tho? The documentation suggests that i need to build my own if i want to use this with gitlab.

There is a gitlab dcoker
docker pull codiumai/pr-agent:gitlab_webhook
If you are not using pr-agent-pro, you do need to host it yourself, and that's the focus of the instructions there

I think i need to cause we are using self hosted GitLab.
And according to the docs i also need to build the image then. It would be nice if one could just set everything as environment variable..

This is what we provide currently.
you are welcome to try pr-agent-pro, where you wouldn't need anything
all the best

yea no worries. just trying to confirm that i do in fact need to build it...


Role Assignments fail with normally-permissioned Terraform SP

The role assignments fail when using a normally-permissioned (Contributor on Subscription) service principal for Terraform. As we would like to deploy as much as from CI/CD, we would need to find a workaround.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20f12c89-40e2-076e-6135-64773551e673
Version Independent ID: c2d6ac4a-fad9-dbc1-d125-b267bcd2a566
Content: Create a Kubernetes cluster with Application Gateway as ingress controller with Azure Kubernetes Service (AKS)
Content Source: articles/terraform/terraform-create-k8s-cluster-with-aks-applicationgateway-ingress.md
Service: azure
GitHub Login: @TomArcher
Microsoft Alias: tarcher

Thanks for the feedback! We are currently investigating and will update you shortly.

@amandadebler Can you please elaborate on your scenario and share the step in the doc where you are seeing issue? This will help us reproduce the issue and assist you better.

@amandadebler Did you get a chance to take a look at the reply, it would be helpful if you can provide us more context.

We will now close this issue. Please share the details when you ready. I will reopen it and we will gladly continue the discussion. :)


MongoDB in docker-compose

I have a question
why is the MongoDB not being referenced in the docker-compose file?

closing due to #688


minor fix for wordnet lemmatization pos param documentation

Encountered extra parameter in the documentation of wordnet lemmatization.
The minor issue is that pos declared twice as param instead of declaring its type.
Followed contribution instructions to apply a minor fix to solve that.

Thank you! Well spotted.


Introduce new module and setup testcontainers-based Kudu service for testing

Why are the changes needed?

Sub task of https://github.com/apache/incubator-kyuubi/issues/2577
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #2607 (3336678) into master (867e0be) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3336678 differs from pull request most recent head b1a845c. Consider uploading reports for the commit b1a845c to get more accurate results

@@            Coverage Diff            @@
##             master    #2607   +/-   ##
=========================================
  Coverage     64.02%   64.02%
  Complexity       73       73
=========================================
  Files           380      380
  Lines         18319    18319
  Branches       2469     2469
=========================================
  Hits          11728    11728
  Misses         5481     5481
  Partials       1110     1110

Impacted Files
Coverage Δ

.../engine/spark/session/SparkSQLSessionManager.scala
79.76% <0.00%> (-1.20%)
:arrow_down:

...ache/kyuubi/engine/spark/SparkProcessBuilder.scala
85.24% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867e0be...b1a845c. Read the comment docs.

Thanks, merging to master


docs: more resources

Not sure whether this is wanted in the documentation, however, when I set up Vitest with React Testing Library, I didn't find any resources about it.
Context: The Road to React is using Vite/Vitest instead of CRA/Jest now 🎆 Hence I needed to come up with a short guide which helps readers to install React Testing Library in Vitest.

Thank you. But I think the docs are not the right place for introducing community resources. Maybe we could have an awesome-vitest at some point in a separate repo or so.


[Doc] add explanations for setting bookie rack name

Add docs for https://github.com/apache/pulsar/pull/13683

@hangc0276 I'll add this content in a separate PR. Could you please review this PR firstly? Thanks


Remote library doesn't support BDD prefixes and @keyword decorator

It would be nice to be able to use the same decorator.
The RemoteLibrary server server could return the func.robot_tags string.
Workaround: Use given_ when_ then_ and_ but_ as prefix.
This makes it a bit confusing when to use a space or tab before and argument.

Fair enough.
What about the handling of the prefixes, given_ when_ then_ and_ but_.
For normal libraries these prefixes are ignored, but for remote libraries these result in existing keywords not to be found.

Prefix handling is implemented in the core and thus should work out-of-the-box. If your remote library implements keyword like Something is done, you should be able to use it like Given something is done or When something is done.


Importing issues

Any CDN?

Hi @MattiasBaldi ,
Just added the CDN options to use. Check the package information for mote details.


Make a common value for layout size

Idea Description
There are values duplicated like timeTableColumnWidth = 192.dp and TimeTable.kt as roomHeaderWidth = 192.dp.
Can we make an object like this and make a common value?
Say, TimetableDefaults
https://github.com/android/nowinandroid/blob/900450eb059ce20d233ee611b4fd7fbaa0aa040e/core-designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/ToggleButton.kt#L102
Reference images and links

🙋♂

@wildstarzw
Thanks! Assigned 👍


scope on extension resources is too restrictive and cannot be overridden with any()

Bicep version
Bicep CLI version 0.24.24 (5646341b0c)
Describe the bug
When creating extension resources with a scope property, it doesn't seem possible to provide a value that I know is a valid resource ID, but that I can't statically prove is an existing resource. This is being used in a helper module that takes a set of resources/identities/roles and generates the necessary roleAssignment resources.
It isn't possible to override the type system with any(), and reference() complains that it's not known at the start of deployment.
I can't find any way to turn a string I know is a valid resource ID (but of arbitrary resource type!) into a resource type that scope will accept - I've provided a minimal example below of a "known" resource ID coming in via a parameter to simplify things down (the actual template takes an array of objects, but the resource IDs are similarly known to be valid)
To work around this, I've had to compile the bicep template to ARM, then manually add the scope property with the necessary expression to the JSON, then reference the ARM JSON directly rather than the bicep template. Needless to say, this is ugly and I've had to put in a lot of explanatory comments, when it could be avoided if I could set scope to what I need to set it to. The deployment runs just fine with the ARM equivalent.
To Reproduce
param resourceId string

resource scopedAcl 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
    name: guid(resourceId)
    scope: resourceId // The property "scope" expected a value of type "resource | tenant" but the provided value is of type "string".bicep(BCP036)
    properties: {
        ...
    }
}

resource scopedAcl2 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
    name: guid(resourceId)
    scope: any(resourceId) // Values of the "any" type are not allowed here.bicep(BCP176)
    properties: {
        ...
    }
}

resource scopedAcl3 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
    name: guid(resourceId)
    scope: reference(resourceId).id
    // The property "scope" expected a value of type "resource | tenant" but the provided value is of type "object".bicep(BCP036)
    // This expression is being used in an assignment to the "scope" property of the "Microsoft.Authorization/roleAssignments" type, which requires a value that can be calculated at the start of the deployment.bicep(BCP120)
    properties: {
        ...
    }
}

Thoughts on solutions

Allow any() to override the type system here, as the documentation says it should be able to
Introduce a general resource or resourceId type that can be used in parameters/UDTs to represent a reference to/id of an arbitrary resource of any type that scope can then accept

Closing as this will be resolved with #2245/#2246

@alex-frankel - I'm not sure that that proposal as it stands introduces a generic resource type does it? i.e. it will allow using specific resource+version as a type, but there's no "any resource" type currently being proposed?
In this specific scenario, I won't have any idea what resource types will be handled, but I know that I have a valid resource ID - the resource typing proposals don't account for that afaict.
I'd also note that those proposals have been under way for the better part of 3 years at this point - I'd rather not wait on them interminably!
Rather than focus on the resource typing aspect of this bug, can we instead look at the use of any()? According to the docs:

Bicep supports a function called any() to resolve type errors in the Bicep type system. You use this function when the format of the value you provide doesn't match what the type system expects. For example, if the property requires a number but you need to provide it as a string, like '0.5'. Use the any() function to suppress the error reported by the type system.

It would therefore seem any() is not behaving as documented here - i.e. it is not overriding the type system's complaint that I don't have the correct type of value (resource/tenant). Based on the docs, I would expect any() to bypass this problem and let bicep use the value as-is (as ARM does!)
This seems like a separate and much smaller/more manageable problem to solve that would still be the case even if the resource type proposals go through eventually?


feat(UXW-1015): Extend brand tokens

Extend the usage of branded tokens on the main menu to allow more customized styles

Hi @soslayando & @tripu , could you please take a look at this feature? THANKS!

OK for me


l2geth: generate witness file

Generates the witness file by setting the required env var. https://github.com/ethereum-optimism/optimism-legacy/blob/efea631cf19d57d3a64374cb81ce545f958bd38f/l2geth/statedumper/dumper.go#L20 Useful for people who want to run the migration

Added upstream


Can't get release train info via spaceship

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools -- more specifically, the spaceship docs...over and over again.
[x] I searched for existing GitHub issues

Issue Description

Originally reported in https://github.com/fastlane/fastlane/issues/14666, which looks remarkably similar, but was requested to create a new ticket:
Using fastlane 2.125.2, the three methods (I know of) to get to a build train or the builds within one are all failing. From the spaceship playground:
[4] pry(#<Spaceship::Playground>)> app = Spaceship::Tunes::Application.find("my.bundle.id")
=> <Spaceship::Tunes::Application
	apple_id="xxxxx",
	name="mycompany",
	vendor_id="CGAPP-001",
	bundle_id="my.bundle.id",
	last_modified=1560273211000,
	issues_count=0,
	app_icon_preview_url="https://url-to-our-icon-image.png",
	version_sets=[<Spaceship::Tunes::VersionSet
		type="APP",
		application=<Spaceship::Tunes::Application
		#<Object ...>>,
		platform="ios">]>

[5] pry(#<Spaceship::Playground>)> versions = app.all_build_train_numbers
NoMethodError: undefined method `[]' for #<Spaceship::ConnectAPI::Response:0x007fd86f49c768>
from /Users/lbrownell/.rvm/gems/ruby-2.3.3/gems/fastlane-2.125.2/spaceship/lib/spaceship/test_flight/build_trains.rb:24:in `block in all'

[6] pry(#<Spaceship::Playground>)> train = app.build_trains["6.0"]
NoMethodError: undefined method `[]' for #<Spaceship::ConnectAPI::Response:0x007fd81d3664b8>
from /Users/lbrownell/.rvm/gems/ruby-2.3.3/gems/fastlane-2.125.2/spaceship/lib/spaceship/test_flight/build_trains.rb:24:in `block in all'

[7] pry(#<Spaceship::Playground>)> app.all_processing_builds
NoMethodError: undefined method `[]' for #<Spaceship::ConnectAPI::Response:0x007fd878031760>
from /Users/lbrownell/.rvm/gems/ruby-2.3.3/gems/fastlane-2.125.2/spaceship/lib/spaceship/test_flight/build_trains.rb

Command executed

See above
Complete output when running fastlane, including the stack trace and command used

See above
Environment

 ✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.5

Ruby
2.3.3

Bundler?
false

Git
git version 2.20.1 (Apple Git-117)

Installation Source
~/.rvm/gems/ruby-2.3.3/bin/fastlane

Host
Mac OS X 10.14.5 (18F203)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.3.3/lib

OpenSSL Version
OpenSSL 1.0.2k  26 Jan 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode10.2.app/Contents/Developer/

Xcode Version
10.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.125.2
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.0

executable-hooks
1.3.2

bundler-unload
1.0.2

rubygems-bundler
1.4.4

bundler
2.0.1

io-console
0.4.5

slack-notifier
2.3.2

atomos
0.1.3

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.9.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

terminal-table
1.8.0

addressable
2.5.2

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

tty-spinner
0.8.0

babosa
1.0.2

colored
1.2

commander-fastlane
4.4.6

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.3

security
0.1.3

faraday_middleware
0.12.2

naturally
2.2.0

simctl
1.6.5

jwt
2.1.0

uber
0.1.0

declarative-option
0.1.0

representable
3.0.4

signet
0.9.1

httpclient
2.8.3

google-api-client
0.23.7

google-cloud-env
1.1.0

google-cloud-core
1.3.0

digest-crc
0.4.1

google-cloud-storage
1.16.0

emoji_regex
0.1.1

tty-cursor
0.6.0

tty-screen
0.6.5

faraday
0.15.2

json
2.1.0

highline
1.7.10

excon
0.62.0

CFPropertyList
3.0.0

plist
3.4.0

memoist
0.16.0

googleauth
0.6.6

unf
0.1.4

domain_name
0.5.20180417

fastimage
2.1.3

unicode-display_width
1.4.0

multi_json
1.13.1

os
1.0.0

psych
2.1.0

retriable
3.1.2

mime-types
3.2.2

mime-types-data
3.2018.0812

declarative
0.0.10

Another report in the original issue of the 410 gone focused issue: https://github.com/fastlane/fastlane/issues/14666#issuecomment-498227886

This is a duplicate of #14884

@cooksimo And so it is!  And your ticket was a duplicate of what I reported in https://github.com/fastlane/fastlane/issues/14666 before you posted your ticket.
@janpio I assume this would should be closed in favor of https://github.com/fastlane/fastlane/issues/14884, since there is action on it?

Sounds reasonable @lbrownell-gpsw. I wasn't aware of that other issue as well, with the spaceship testflight changes stuff is a bit new and confusing for now.
Let's move over to #14884 then :)


[WFLY-9300] Add test for ejb security propagation using PLAIN

https://issues.jboss.org/browse/WFLY-9300

I think I have all of the log.infos out.  There are actually 2 users with different roles.  ejbUser has ejbRole, webUser has ejb and web role.  I started some more changes to validate the roles further.

retest this please

@bmaxwell I meant 2 web users + 2 ejb users to be sure first web/ejb authenticated user is not sharing permissions with second web/ejb user. In any case thanks for increasing the coverage!

@bmaxwell Closing due to inactivity on fixing this

@kabir I've rebased on behalf of @bmaxwell who appears to have not has the time to do it. I've setup a new PR that thus superseeds this PR11527 .


Masking not done correctly in VQ?

https://github.com/collabora/WhisperSpeech/blob/b6fc87c9e1ffd28b0fef71bc25896ce323a76fa8/whisperspeech/vq_stoks.py#L88
Shouldn't this mask the actual padding area, which includes a random part of both the left and right part of the audio?

Yes, you're right. In the code you pointed out we assume padding is always from the right and the rest of the code allows for randomized padding. I think it did not cause issues in practice because I never enabled the random shift option here:
https://github.com/collabora/WhisperSpeech/blob/b6fc87c9e1ffd28b0fef71bc25896ce323a76fa8/whisperspeech/wh_transcribe.py#L93


Add FULL support for Ollama AI models

Implement a native client (OllamaApi) to leverage chat/streaming and embedding endpoints.
Add a OllamaChatClient implementing the ChatClinet and StreamingChatClinet interfaces.
Add a OllamaEmbedding clinent that impl. the EmbeddingClinet interface.
Add AutoConfiguraitons with properties for the chat and the embedding clients.
Add unit and ITs for the OllamaApi, OllamaChatClient, OllamaEmbeddingClient, and related auto-configuraitons.
Remove the old ollama impl. classes and tests.
minor fixes to the bedrock test methods names.

reviewed and merged.  Some follow up issues to discuss.
9ab857a8aba931a34f24c12683fe877e8cd270cb


hyperparameter search with optuna

Hi,
I am trying to do hyper parameter search with optuna starting from this code https://github.com/allegroai/trains/blob/master/examples/optimization/hyper-parameter-optimization/hyper_parameter_optimizer.py.
However, when playing with the learning rate for example, regardless if I use lr or --lr, it shows under general, not args and is not parsed by the command line arguments, i.e. not used. How can I integrate the most easily to have the hyperparameter search integrated with argparse with minimal code changes? What I assumed that it would happen is that the value for the lr parameter in args is going to be changed and the python method called.

Hi @mhashas

In the base experiment (the one we will be trying to optimize), can you see any of your arguments?
Notice, if your code uses argparse, all the arguments will appear under the "Args" section.
If you connected parameters manually (i.e. with a call to task.connect(my_dict)) they will appear under the "General" section
In the HPO example, the name of the argument to optimize should match what you have in the UI
(notice it is case sensitive, and there is no need to add extra -- , it should be exactly as you see in the UI).
If I understand your example, it should be something like:

an_optimizer = HyperParameterOptimizer(
    base_task_id=args['template_task_id'],
    hyper_parameters=[
        DiscreteParameterRange('Args/lr', values=[1e-05, 1e-04, 1e-03]),
    ],
    ...

Hi @bmartinn,
Thanks so much for your response. Indeed number 2 is what I was looking for and it works as expected.

Hi @bmartinn,
I have a follow-up question. I am trying to change the samplers and pruners used by Optuna
``
an_optimizer = HyperParameterOptimizer(
    base_task_id=task_args['template_task_id'],
    hyper_parameters=hyper_parameters],
    objective_metric_title='linear_kappa_kl',
    objective_metric_series='val',
    objective_metric_sign='max',
    optimizer_class=OptimizerOptuna,
    max_number_of_concurrent_tasks=config.max_number_of_concurrent_tasks,
    time_limit_per_job=config.time_limit_per_job,
    pool_period_min=5,
    total_max_jobs=config.total_max_jobs,
    min_iteration_per_job=50,
    max_iteration_per_job=150,
    optuna_sampler=TPESampler(),
    optuna_pruner=HyperbandPruner())

``
However I get the error
ValueError: Only builtin types (str, int, str, float, list, tuple, dict, NoneType) are allowed for values (got General/opt/optimizer_kwargs/optuna_sampler=>TPESampler, General/opt/optimizer_kwargs/optuna_pruner=>HyperbandPruner)
I debugged through the source code a bit and if I disable auto_connect_task the HPO is instantiated. I don't fully understand what does auto_connect_task do and if I should disable it?

Hi @mhashas,
I think you are correct, this is a bug (of a sort), kudos on the workaround!
The HPO object connects its own configuration with the Task (i.e. serializing its internal configuration dictionary).
The idea is that later you could clone the HPO Task, edit the HPO configuration and launch the HPO on the trains-agent services queue. Basically allowing you to automate the automation, i.e. the HPO process.
The bug is that the HPO object assumes the internal representation dictionary is json serializable, unfortunately the Optuna parameter you are passing is an object (not a basic type).
I think the solution here is not to serialize the optimizer specific object (e.g. optuna_sampler), this should solve the issue and still allow you to configure the HPO from the UI.
What do you think?

Hi,
Sounds good. For us, I don't think it's so important to automate the automation so I will use the work around till the fix is done. Thanks for the quick response (again).
Not sure if I should close the ticket or not, if you are tracking the issue feel free to close it.

Hi @mhashas
RC is out with a fix, feel free to test it.
pip install trains==0.16.4rc0


fix(deisctl): avoid stdout issues in tests

Some unit tests will fail with GOMAXPROCS > 1, so this change allows make test-unit to pass until there is a proper fix.

How is stdout related to GOMAXPROCS?

I haven't actually dug into this one, but in the other similar # TODO: cases I think we were reading stdout from a goroutine with improper channel handling or...mumble... I know empirically in these cases it's GOMAXPROCS and therefore a concurrency issue.

Code LGTM.

Code LGTM


[WIP] Make enumerate_instance_version an Entry function

enumerate_instance_version is a function meant to be called before instance creation. This pull request moves its function pointer to Entry.
Also adds the EntryV1_1 trait. I have not added any other functions to the trait yet, so as per this comment it is not currently possible to create a 1.1 instance safely.
Note: do we want this function to be marked as unsafe? It seems pretty safe to me.
Fixes #103.

This change is

This function should be safe.


Get integration tests working again

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.39%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4079

Relevant Lines:
6144

💛  - Coveralls


Can we write this in C ?

C is clearly a superior language to other languages people could propose.
This python example shows this clearly:
languages = ["C", "Rust"]
languages.sort()
print(languages[0])

Oh I didn't read the description of the project properly, I didn't get this wasn't posix. I'll just write another posix shell.

This is going to be written in C, no worries. Rust is not ready yet for a project of this magnitude

Also the shell relies on Undefined Behavior (it's in the name), and the craby language does not have undefined behavior, therefore it is unfit for ubsh

Are we sure we want this to be not POSIX ? We might as well write a computer virus (which is already happening considering the BSD3 license).

Are we sure we want this to be not POSIX ?

I kind of agree with this. Maybe we don't need here-documents an some other useless stuff but POSIX is great (and make people use your shell). If we want another syntax we could just make an option later on but at least it will be POSIX

(which is already happening considering the BSD3 license)

So true

I am personally not against it but we need to decide what to remove from the POSIX spec. I agree that heredocs should not have a place here. I'm also against string expansion as it is usually done in a POSIX shell

I'm also against string expansion as it is usually done in a POSIX shell

So no variables?

No, what I mean is that z=$(($z+3)) is not a good way to represent arithmetic expansion and that  ${stringZ%%b*c} isn't really the clearest way to perform substitution. And we should change that

So we keep basic extensions?

What basic extensions do you have in mind?

What basic extensions do you have in mind?

expansions sorry
Variable, environment variables. There might be others but I don't remember well :sweat_smile:


Transfer string into a translation file & add Ukrainian (uk_ua) translations

At the start I wanted to add Ukrainian translations, but noticed some strings were hard-coded in & some translation keys weren't even used, so I also decided to "fix it up a bit :tm: "
This PR:

Uses unused, but localized strings like text.autoconfig.islandutils.category.music & text.autoconfig.islandutils.category.cosmetics, instead of hard-coded literals
Adds new translation keys like islandutils.message.core.updateAvailable or islandutils.message.friends.thisLobby, that gives an ability to localize more than just the config screen.
Adds Ukrainian (uk_ua) translations of the strings (including the ones I added)

Open to feedback! Thank you!

hello, pls can you resolve your merge conflicts, because i don't think i can push to your main branch
(in future, please don't open pull requests against your main branch)

Done! Thank you for the advice!

heya, sorry it's been a while lol
since there's been a ton of changes made to IslandUtils since this PR opening, could you resolve the new conflicts created from 1.7.0, then i'll be able to merge this and #149 in :P

hi! i'm  done with bumping stuff to 1.7.0.
could you, please, add a "text.autoconfig.islandutils.option.showFishingUpgradeIcon.@Tooltip translation for English, so I can translate it based on that. i haven't played mcci for a while, so it would be better if you added the string so I could base my translation on yours, so not to guess how the setting actually works.
after that the pr is ready to be merged

Just to comment on this, while working on backporting to 1.21, I added the tool tip with the string "Shows an upgrade icon next to upgradable Fishing Perks". If there needs to be consistency across versions once aso sets up a branch for me to do a PR to


 Probably

Can you try with the latest commit? npm i github:alensaito1/wa-sticker-formatter

Can you try with the latest commit? npm i github:alensaito1/wa-sticker-formatter

Still not resolved

I also experienced the same thing when Creating Animated Stickers,  oversize

Was this issue ever solved?


Changed splitting thresholds.

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What is the problem / what does the code in this PR do
As discussed in this note we are setting the splitting thresholds to some initial reasonable values.

Hi Daniel, thanks for the PR. Can you tell me which plots in your wiki directly indicate that min_split_nv of 0.063  and min_split_ratio_nv of 0.75 are the best values for this tuning?


fix: allow array of strings for output.library.root

What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
If relevant, link to documentation update:
N/A
Summary

Closes #7176
Does this PR introduce a breaking change?
No

I assume tests will be needed for this one

Isn't needed a change in the source code?

@montogeek quite possible. Need to add a test case first and will see, probably tom

Added a test case. Seems it compiles without errors

I checked with the issue author and he confirmed it works as expected. Is there anything else pending to get this one merged?

Thanks


Mission randomly rejected

Log: https://review.px4.io/plot_app?log=6f9fa451-d3a6-42dd-b1c7-87261310b139
Situation:
Vehicle sat outside with good gps and telemetry lock
Armed via RC
Switched from Manual to Mission (jumping over ALTCTL)
Warning issued: REJECT AUTO MISSION
Then disarm and arm again and it works.
This happens very often but not consistently.

I also meet this issue in 1.6.5 of Fixedwing

If you're able to reproduce getting a log with with mission_result, offboard_mission, and vehicle_status_flags added to logger would be helpful.

The home_position as well.

is that caused by  excessive vibration levels ? It was happened in gas engine but we haven't see in electrical

@sanderux Does this persist with master?

Yes,
However, my switch does pass through ALTCTL quickly before mission is activated.
@dagar throught it might be related.

https://logs.px4.io/plot_app?log=5746a789-a331-4bd3-90c8-24d99c5a6520

The mission didn't update until after the attempted switch to mission mode.

Must be a bug, there was no mission update at that time

@dagar should we move this to 1.8?

the same issue with log
https://logs.px4.io/plot_app?log=da1efbe4-9940-4b3e-a287-6b0aa8fb8af9

Thanks for the logs, please keep posting and include any context.
Side note - @jinchengde you have estimator issues https://logs.px4.io/plot_app?log=da1efbe4-9940-4b3e-a287-6b0aa8fb8af9#Nav-Estimator-Watchdog

@dagar
This is based on the firmware version of 1.6.5, and we always get this issue. then we rollback to 1.6.4, the problem is disappear, so I supposed it maybe caused by EKF ?
and could you tell me where you see the estimator issues in log.Thanks!

@jinchengde I'm not sure, but there have been many robustness improvements for FW in EKF2 over the last few months. Give master a try (nearly v1.7.0) and open an issue or ping me if you're still seeing anything in the estimator watchdog.

Latest insights is that it has something to do with the fact that my switch (from manual to mission) travels over another flightmode (ALTCTL). If is switch slowly from manual - altctl - mission the problem is gone.

Ok, I think it's just the timing of the mission_result publication. Need to think about it overall, but we need to handle that differently.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)


Fix UW mapping's dataProvider and parse OAI header setSpec properly

UW: Add missing label to dataProvider.
Use OAI setSpec element properly (DLG, ESDN, NCDHC, UW). This implements the changes fixed by dpla/KriKri#176.

:+1:
I've tested this mapping. I also opened an issue for the general case on the DSL Resource merge here: https://issues.dp.la/issues/7894


ungoogled-chromium fails to start when using wayland

Describe the bug
Ungoogled Chromium from Flathub doesn't start and throws errors when launched in wayland with wayland specific start options. However, vanilla chromium from the arch official repositories works fine with the wayland options used below.
To Reproduce
Steps to reproduce the behavior:

Download ungoogled-chromium from flathub using flatpak install --user com.github.Eloston.UngoogledChromium
Start ungoogled-chromium using com.github.Eloston.UngoogledChromium --incognito --enable-features=UseOzonePlatform --ozone-platform=wayland
The application doesn't start, throws errors in the terminal, and the CPU usage spikes to 100% after a few minutes. Meanwhile, the terminal keeps on throwing errors.

Expected behavior
ungoogled-chromium should start without errors as a wayland native application
Environment (please complete the following information):

OS/Platform and version: Arch Linux on Ryzen 3500U with Flatpak version 1.10.2
ungoogled-chromium version: 89.0.4389.114

Logs
~ ➜ com.github.Eloston.UngoogledChromium --incognito --enable-features=UseOzonePlatform --ozone-platform=wayland
[2:2:0423/112223.100040:ERROR:wayland_surface.cc(59)] Server doesn't support zwp_linux_explicit_synchronization_v1.
[42:42:0423/112223.163715:ERROR:sandbox_linux.cc(382)] InitializeSandbox() called with multiple threads in process gpu-process.
Modifiers specified, but DRI is too old
[42:42:0423/112223.414728:ERROR:gbm_pixmap_wayland.cc(58)] Cannot create bo with format= RGBA_8888 and usage SCANOUT
[42:42:0423/112223.414841:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(250)] Failed to create pixmap 2530x2840, RGBA_8888, usage SCANOUT
Modifiers specified, but DRI is too old
[42:42:0423/112223.414924:ERROR:gbm_pixmap_wayland.cc(58)] Cannot create bo with format= RGBA_8888 and usage GPU_READ
[42:42:0423/112223.415008:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(250)] Failed to create pixmap 2530x2840, RGBA_8888, usage GPU_READ
[42:42:0423/112223.415088:ERROR:shared_image_backing_gl_texture.cc(536)] CreateSharedImage: Failed to create bindable image
[42:42:0423/112223.415161:ERROR:shared_image_factory.cc(553)] CreateSharedImage: could not create backing.
[42:42:0423/112223.415318:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.415446:ERROR:shared_image_stub.cc(452)] SharedImageStub: context already lost
[42:42:0423/112223.416953:ERROR:shared_image_stub.cc(452)] SharedImageStub: context already lost
[42:42:0423/112223.418986:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.419133:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.419213:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.419309:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.419595:ERROR:raster_decoder.cc(1061)]   RasterDecoderImpl: Context lost during MakeCurrent.
[42:42:0423/112223.422606:ERROR:shared_image_stub.cc(452)] SharedImageStub: context already lost
Modifiers specified, but DRI is too old
[42:42:0423/112223.496595:ERROR:gbm_pixmap_wayland.cc(58)] Cannot create bo with format= RGBA_8888 and usage SCANOUT
[42:42:0423/112223.496774:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(250)] Failed to create pixmap 2530x2840, RGBA_8888, usage SCANOUT
Modifiers specified, but DRI is too old
[42:42:0423/112223.496889:ERROR:gbm_pixmap_wayland.cc(58)] Cannot create bo with format= RGBA_8888 and usage GPU_READ
[42:42:0423/112223.496985:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(250)] Failed to create pixmap 2530x2840, RGBA_8888, usage GPU_READ
[42:42:0423/112223.497080:ERROR:shared_image_backing_gl_texture.cc(536)] CreateSharedImage: Failed to create bindable image
[42:42:0423/112223.497173:ERROR:shared_image_factory.cc(553)] CreateSharedImage: could not create backing.
[42:42:0423/112223.497365:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.497534:ERROR:shared_image_stub.cc(452)] SharedImageStub: context already lost
[42:42:0423/112223.498848:ERROR:shared_image_stub.cc(452)] SharedImageStub: context already lost
[42:42:0423/112223.501021:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.501178:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.501264:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.501371:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.504909:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.505347:ERROR:raster_decoder.cc(1061)]   RasterDecoderImpl: Context lost during MakeCurrent.
Modifiers specified, but DRI is too old
[42:42:0423/112223.559062:ERROR:gbm_pixmap_wayland.cc(58)] Cannot create bo with format= RGBA_8888 and usage SCANOUT
[42:42:0423/112223.559167:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(250)] Failed to create pixmap 2530x2840, RGBA_8888, usage SCANOUT
Modifiers specified, but DRI is too old
[42:42:0423/112223.559241:ERROR:gbm_pixmap_wayland.cc(58)] Cannot create bo with format= RGBA_8888 and usage GPU_READ
[42:42:0423/112223.559290:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(250)] Failed to create pixmap 2530x2840, RGBA_8888, usage GPU_READ
[42:42:0423/112223.559342:ERROR:shared_image_backing_gl_texture.cc(536)] CreateSharedImage: Failed to create bindable image
[42:42:0423/112223.559385:ERROR:shared_image_factory.cc(553)] CreateSharedImage: could not create backing.
[42:42:0423/112223.559503:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.559837:ERROR:shared_image_stub.cc(452)] SharedImageStub: context already lost
[42:42:0423/112223.560702:ERROR:shared_image_stub.cc(452)] SharedImageStub: context already lost
[42:42:0423/112223.562447:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[2:2:0423/112223.562600:ERROR:command_buffer_proxy_impl.cc(122)] ContextResult::kTransientFailure: Failed to send GpuChannelMsg_CreateCommandBuffer.
[42:42:0423/112223.562581:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.562676:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.565798:ERROR:shared_image_stub.cc(452)] SharedImageStub: context already lost
[105:24:0423/112223.568407:ERROR:command_buffer_proxy_impl.cc(122)] ContextResult::kTransientFailure: Failed to send GpuChannelMsg_CreateCommandBuffer.
Modifiers specified, but DRI is too old
[42:42:0423/112223.674660:ERROR:gbm_pixmap_wayland.cc(58)] Cannot create bo with format= RGBA_8888 and usage SCANOUT
[42:42:0423/112223.674839:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(250)] Failed to create pixmap 2530x2840, RGBA_8888, usage SCANOUT
Modifiers specified, but DRI is too old
[42:42:0423/112223.674951:ERROR:gbm_pixmap_wayland.cc(58)] Cannot create bo with format= RGBA_8888 and usage GPU_READ
[42:42:0423/112223.675059:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(250)] Failed to create pixmap 2530x2840, RGBA_8888, usage GPU_READ
[42:42:0423/112223.675153:ERROR:shared_image_backing_gl_texture.cc(536)] CreateSharedImage: Failed to create bindable image
[42:42:0423/112223.675240:ERROR:shared_image_factory.cc(553)] CreateSharedImage: could not create backing.
[42:42:0423/112223.675449:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.675862:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.676033:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
[42:42:0423/112223.676201:ERROR:skia_output_surface_impl_on_gpu.cc(1367)] Failed to make current.
^C⏎[2:32:0423/112223.680944:FATAL:bus.cc(1220)] D-Bus connection was disconnected. Aborting.

The same issue is present on version 90.0.4430.85. The error logs don't keep on printing endlessly though.

@ayushnix and
does this 'works'   with  a more exotic configuration  (as running the flatpak with --no-sandbox
Its inspired by brave (it used to give similar dramas)
https://www.reddit.com/r/brave_browser/comments/bieupq/brave_has_sandbox_disabled_on_arch_linux_is_this/

@Area51Kacz no, it doesn't. I'm getting the same error with the latest version.

Flatpak has its own userspace libraries that seem to be causing problems with Wayland's rendering stack. Please create a new issue on the Flatpak repo instead (so those devs can see it): https://github.com/flathub/com.github.Eloston.UngoogledChromium/issues

never mind, I've switched back to Xorg i3 for now after struggling to use Wayland for more than 6 months. ungoogled-chromium works as expected on it.
Thanks for the suggestion though.


Update q_and_a.md

Fixed the incorrect file paths.

@SanskarTanwarShorthillsAI , Please resolve the conflicts

Done.