check-openapi: Disallow siblings of $ref

The specification says “any sibling elements of a $ref are ignored”, so their presence, although not invalid, indicates a mistake.  yamole incorrectly merges these siblings into the referenced object, but we should not rely on this nonstandard behavior.
https://swagger.io/docs/specification/using-ref/#sibling
Testing Plan: This test currently fails. We need to fix zulip.yaml before merging.
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/get_stream_id","get","parameters",0]: {
openapi   |   "$ref": "#/components/parameters/Stream",
openapi   |   "required": true
openapi   | }
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/mark_stream_as_read","post","parameters",0]: {
openapi   |   "$ref": "#/components/parameters/StreamIdInQuery",
openapi   |   "required": true
openapi   | }
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/mark_topic_as_read","post","parameters",0]: {
openapi   |   "$ref": "#/components/parameters/StreamIdInQuery",
openapi   |   "required": true
openapi   | }
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/messages/{message_id}/reactions","post","parameters",1]: {
openapi   |   "$ref": "#/components/parameters/EmojiName",
openapi   |   "required": true
openapi   | }
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/messages/{message_id}/reactions","delete","parameters",1]: {
openapi   |   "$ref": "#/components/parameters/EmojiName",
openapi   |   "required": false
openapi   | }
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/users/{user_id}/subscriptions/{stream_id}","get","parameters",0]: {
openapi   |   "$ref": "#/components/parameters/UserId",
openapi   |   "example": 7
openapi   | }
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/users/{user_id}/subscriptions/{stream_id}","get","parameters",1]: {
openapi   |   "$ref": "#/components/parameters/StreamIdInPath",
openapi   |   "example": 1
openapi   | }
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/users/me/subscriptions/muted_topics","patch","parameters",0]: {
openapi   |   "$ref": "#/components/parameters/Stream",
openapi   |   "required": false
openapi   | }
openapi   | zerver/openapi/zulip.yaml: Siblings of $ref have no effect at ["paths","/users/me/subscriptions/muted_topics","patch","parameters",1]: {
openapi   |   "$ref": "#/components/parameters/StreamIdInQuery",
openapi   |   "required": false
openapi   | }

Cc @orientor @YagoGG

@orientor are you up for cleaning up this batch of errors?

I had discovered this issue sometime ago and planned to remove it by using allOf.But since the meaning of allOf is completely different than what it was initially assumed to be, how should this issue be solved?  @andersk

There are only 9 of these so we can probably just inline them all, unless you have a better idea. I guess for the 2 with example we can just delete the example since the referenced definitions already have one.

Updated zulip.yml by inlining some $refs and deleting some redundant examples to make this test pass.

This doesn’t pass test-api because it successfully makes the example request that deactivates the example user 12, before trying to make other example requests involving the example user 12.
I really feel like somebody should have thought this design through.

Okay, this kludge makes it pass.

Merged, thanks @andersk!  I think the preferred way for the deactivated user test issue in 7c17bdb9c524a3ba0d36843879cca0e5dfb229a1 to be resolved would be to add a @openapi_param_value_generator function that creates an extra user for us to deactivate in the tests.
I opened https://github.com/zulip/zulip/issues/16340 to track that follow-up work; @orientor @akashaviator FYI.


Need One time logo set facility in pytest metrics

Proposed Enhancement:
The current implementation of the pytest metrics facilitates the user to provide the URL/Path of the logo as a parameter while executing the tests.
This is an redundant activity considering that users would always love to have their own branding instead of manually specifying each time.
If we could have some global facility / location where user could one time update the image or image url then it would be a big effort saver.

This can be achieved by simple work around as follows
Step 1: Edit plugin.py Can be found under following location
C:\Users\<user-name>\AppData\Local\Programs\Python\Python37\Lib\site-packages\pytest_metrics\plugin.py
Step 2: Modify --mlogo default value (line no 50)
default="https://my-company-logo.png"
Step 3: Save changes
Note: This change applicable in local machine

Thanks. This is working. We can close this issue.


[help needed] Problems running the app locally

Hello!
I tried to run the app locally but couldn't due to the following errors:
⠇ Building the app.......Failed to construct transformer:  Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:69:19)
    at Object.createHash (node:crypto:133:10)
    at stableHash (/Users/sergio/dev/skolplattformen/node_modules/metro-cache/src/stableHash.js:19:8)
    at Object.getCacheKey (/Users/sergio/dev/skolplattformen/node_modules/metro-transform-worker/src/index.js:593:7)
    at getTransformCacheKey (/Users/sergio/dev/skolplattformen/node_modules/metro/src/DeltaBundler/getTransformCacheKey.js:24:19)
    at new Transformer (/Users/sergio/dev/skolplattformen/node_modules/metro/src/DeltaBundler/Transformer.js:48:9)
    at /Users/sergio/dev/skolplattformen/node_modules/metro/src/Bundler.js:22:29
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'

...

** BUILD FAILED **

The following build commands failed:
	CompileC /Users/sergio/Library/Developer/Xcode/DerivedData/app-fzhernkxeiuybtcnzuuzrfpckcgv/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Yoga.build/Objects-normal/arm64/Yoga.o /Users/sergio/dev/skolplattformen/node_modules/react-native/ReactCommon/yoga/yoga/Yoga.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'Yoga' from project 'Pods')
(1 failure)

I looked up for this error online and found this suggestion, but after applying it, I got the following error:
> yarn run ios
yarn run v1.22.19
$ nx run-ios

>  NX   ERROR  Initiated Worker with invalid NODE_OPTIONS env variable: --openssl-legacy-provider is not allowed in NODE_OPTIONS

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I'm running on this platform
macOS: 14.1 (23B74)
Xcode: 15.0.1
Node: 18.18.2
Yarn: 1.22.19

Btw, after it fails the first time, I get this other error if I try to run the command yarn run ios again
➜  skolplattformen git:(main) ✗ yarn run ios
yarn run v1.22.19
$ nx run-ios

> nx run skolplattformen-app:run-ios
ENOTDIR: not a directory, rmdir '/Users/sergio/dev/skolplattformen/apps/skolplattformen-app/node_modules'

———————————————————————————————————————————————

>  NX   ERROR  Running target "skolplattformen-app:run-ios" failed

  Failed tasks:

  - skolplattformen-app:run-ios

  Hint: run the command with --verbose for more details.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Is there another command I should be running?

Hi, I'm not very good at all the differences with the tooling, but we are building with Node 16.19.1 and xCode 14.1.
I guess the problem may be there.

@kajetan-kazimierczak Thanks for the reply! Are you running macOS? And if so, have you updated to Sonoma? I'm asking because I tried to downgrade to Xcode 14.3.1 but the new operating system won't allow me to execute it due to incompatibilities

I finally managed to get it up and running.
For anyone looking for answer (or my future self suffering from amnesia), these are the steps I followed:

Downgraded to Node 16 as previously suggested using NVM.
Followed the setup instructions on README.md : yarn && yarn run ios
The first error I encountered related to Yoga.cpp was fixed by following this suggestion
For the second error, related to unary_function I followed this tip

After that, I managed to successfully build the app but it wouldn't open the simulator after executing yarn run ios due to this other error:
success Successfully built the app
2023-11-03 13:50:54.337 xcodebuild[22691:2760548] Requested but did not find extension point with identifier Xcode.InterfaceBuilderBuildSupport.PlatformDefinition
info Installing "/Users/sergio/Library/Developer/Xcode/DerivedData/app-fzhernkxeiuybtcnzuuzrfpckcgv/Build/Products/Debug-iphonesimulator/app.app"
An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=405):

To open the simulator

I went to XCode (v15.0.1 btw)
opened the file skolplattformen/apps/skolplattformen-app/ios/app.xcworkspace (btw, this is the first time I'm using XCode or even attempting to develop a mobile app)
and, chose from the XCode's menu  Product > Destination > iPhone SE (or whichever is available)

I noticed the script running in the terminal listened to the changes coming from XCode and also from the Visual Code editor. So I confirmed everything was working by updating a string in the app and seeing the change reflected in the simulator

Thanks for the info.


Ensure Address Checksum in Deployments lookup

Summary
This PR checksums the address from StakingApi before the lookup in StakingRepository. Some staking providers like Kiln might not ensure the addresses being checksummed, and therefore the deployment associated with a checksummed address might not be found.
Changes

Checksums the Deployment.address coming from StakingApi before searching by address value.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 46.332%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/domain/staking/staking.repository.ts
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>2:
0.005%

Covered Lines:
4812

Relevant Lines:
8364

💛  - Coveralls


WIP Use rhel9 image for aee

The current image is a base fedora image that installs packages using pip and prone to be broken with latest changes in packages.

Not sure if we can create an image based on ee-minimal-rhel9 and push it to quay.

we can use ansible-builder:
https://ansible.readthedocs.io/projects/builder/en/latest/index.html#choosing-a-base-image
this is how the current base image is built:
https://github.com/ansible/ansible-dev-tools/blob/main/execution-environment.yml

I think OSPRH-11080 was covered by this PR

I think OSPRH-11080 was covered by this PR

I think the intent of that jira is to write an execution-environment.yml  that can be used with ansible-builder.  ansible-builder generates a Containerfile from execution-environment.yml (which we're now doing manually) and runs podman build with it. If we want to just maintain an execution-environment.yml  , we can try that as well, but I had found ansible-builder to be buggy in some of my tests (sometimes the build command returns without generating the image).


[Suggestion] GUI elements in 3D world

There is an example with Godot (GUI in 3d)  that shows using a standard set of GUI controls, by hacking in some event injection you can make it work with a captured mouse, I implemented in my own experiment a door that needs you to enter a 4 digit password to open the a door (alas only just discovered this project or would have hacked it into this!), the number keys and clear buttons are all just the standard Godot button controls, but they are rendered into a viewport texture. Taking the world position of a raycast hit you can then do an affine transform to get the position you need to inject the mouse event into 2d gui.

Yeah this would be a nice addition, I've seen something similar implemented here: Immersive Sim Interaction System in Godot
Specifically at around 1:40.

I need to.do some more tidying with my own code base, but would I be wasting my time implementing this idea and making a PR for this project not just my own?

I've seen something similar implemented here

Yup, that one is pretty cool. Someone already pointed it out and asked the same question before.

would I be wasting my time implementing this idea and making a PR for this project not just my own?

As it stands right now, I'm not planning to work on a feature like this myself.
If you can make an Object/Component that works with Cogito, feel free to make a PR, and I'd love to merge it in.
It would not replace the current Cogito Keypad, as this one has some other features that wouldn't work with a diegetic interface, and since it also works as an example of a "minigame interface" in general.

to be honest I've only started looking at Godot again since 3.0 days, I'm not fully up to speed with GDScript its missing some features like Interfaces I'd expect from an OO language, and I'm not 100% sure I'm holding it right at the moment !
So maybe better I wait till I've got a little more comfortable with the language, but in the mean time...
You can see it running here: https://www.youtube.com/watch?v=VsiehuPLULE I can give you the whole project to play with if you like... Just contact me via my website... (see github profile)


Sweep: Github action fails

Github Action for code testing fails due to:
GitHub Actions
/ .github/workflows/test.yml
Invalid workflow file
You have an error in your yaml syntax on line 8

Hey, I'm one of the developers of Sweep, we're taking a look.

sweep: Retry

sweep: Retry

sweep: Retry


ReactNative

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description of site
Please provide a clear and concise description of what the bug is. Include screenshots if needed.
Please test using the latest React Native release to make sure your issue has not already been fixed: https://reactnative.dev/docs/upgrading.html
React Native version:
Run "react-native info" in your terminal and copy the results here.
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Expected Results
Describe what you expected to happen.
Snack, code example, screenshot, or link to a repository:
Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
You may provide a screenshot of the applications if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

findingBugs

This is an empty issue! can be closed.

This is an empty issue! can be closed.

👍


[Proposal] Add pydocstyle to pre-commit

Pre-commit is missing pydocstyle check which is helpful for ensuring high quality documented code

Yes, Please, it would help me, with developing MaMuJoCo

@pseudo-rnd-thoughts or @rodrigodelazcano close


Sysdig integration sto 6981

Topic preview: Sysdig scanner reference

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65e739151c7a24253971665d--harness-developer.netlify.app


[MSIX] MSIX build script should rebuild as well

Looking at the MSIX generation script, i feel we should we should be able to do a full compile via the command line.
https://github.com/microsoft/PowerToys/blob/master/installer/README.md
Why:
There are plenty of times were we'll be flipping between branches for testing and knowing if we generate a new MSIX, that it is up-to-date with that branch is critical.

we'll reopen once MSIX is back up as a tracking item


Location Picker Not Opening Sometimes

Google Places Location Picker activity is not opening sometimes.  It happens after few times sending location per launch.
I also checked and debugged the code startChooseLocationActivity method in LocationSelector is executing without any error or exception when Location picker not showing up.
I also setup the Google API keys correctly in Manifest file and Configuration builder, it cannot be the problem because after every launch of the app it woks for few time after that only Picker not showing up.
I checked with all my of testing devices, this happens in all devices.  Below are the details of my application
minSdkVersion 23 targetSdkVersion 27 multiDexEnabled true
I initiated ChatSDK in onCreate method of Application class
`
// Create a new configuration
Configuration.Builder builder = new Configuration.Builder(context);
    // Perform any configuration steps (optional)
    builder.firebaseRootPath(getString(R.string.firebase_root_path));

    builder.firebaseStorageURL(getString(R.string.firebase_storage_url));
    builder.googleMaps(getString(R.string.google_places_api_key));

    // Initialize the Chat SDK
    ChatSDK.initialize(builder.build());
    UserInterfaceModule.activate(context);

    // Activate the Firebase module
    FirebaseModule.activate();

    FirebasePushModule.activateForFirebase();
    builder.firebase(getString(R.string.firebase_root_path), getString(R.string.firebase_cloud_messaging_server_key));

    // File storage is needed for profile image upload and image messages
    FirebaseFileStorageModule.activate();

`
And to open the chat SDK screen
AppBackgroundMonitor.shared().setEnabled(true);         InterfaceManager.shared().a.startMainActivity(this);

This happens when the Google Places API hasn't been enabled from the Google Places dashboard.


Add support for paddle 2.5.0+

TrustAI hasn't been updated for a long time, and it's no longer compatible with paddle 2.5 and above that discard the paddle.fluid API. With this in mind, I used the official paddle migration tool to update paddle.fluid to a new version of the code that paddle can support.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


New notebook editor messing with old notebooks

Environment data

VS Code version: 1.60.0
Jupyter Extension version (available under the Extensions sidebar):
v2021.8.2041215044
Python Extension version (available under the Extensions sidebar): v2021.9.1230869389
OS (Windows | Mac | Linux distro) and version: Windows 10

Before the new editor, I had a notebook with a cell like this:
results_path = "results.json"

with open(results_path) as json_file:
    loaded_results = json.load(json_file)

loaded_results["results"]["Airports"].keys()

After opening it in the new editor, saving and reopen in the old editor (because the new one has some bugs), I got this:
results_path = "results.json"

with open(results_path) as json_file:
    loaded_results = json.load(json_le)fi

loaded_results["results"]["Airports"].keyse)

The new editor totally screwed up the last two lines. And this is only a sample. Every single cell in my notebook is now broken (and since I'm not using version control, I lost hours of work...)

@ubalklen How were you opening up the files in the old editor? Were you using an old version of the extension to do that? That behavior that you are seeing is more likely caused by the reopen on the old editor versus the new editor. Moving forward the new editor is going to be the only option so hopefully we can help resolve those issues that are blocking you (please file issues on the things that are blocking your workflow).

They were already open. I also noticed that I had been able to open notebooks in the old editor by double-clicking on them, but I cant' reproduce that anymore. The only way to open the notebooks in the new editor was by right-clicking and selecting "Open in notebook editor".

Sounds like that might have been with an older version of the extension. Moving forward the old editor won't be an available option anymore.

@ubalklen, I agree, this was a bad bug and we're sorry that it occurred. Note that we did have similar, but extremely hard to repro, bugs reported just using the old editor over the past year or so, so I'm not convinced that the issue related to the combination of the new and old editor. Since the old editor has been completely deprecated and removed and the new editor implements persistence differently, it's unlikely this will happen again.


results: Add more sm8350 results

This device runs at a much lower CPU voltage, but this does not show up in efficiency, which is very interesting.

There does seem to be a small difference at higher frequencies:

In your case, it's likely that the open loop voltages reported by OSM vary from the actual voltages by different amounts (since the CPU's voltage is constantly being adjusted at runtime) between the two devices.


RFC: default active class for ui-sref

My templates are getting littered with repetitions of the ui-sref-active directive; if I ever want to change the active-tab CSS class name, I'll have to change it in many places.  Is it possible to create a configuration setting that can be used to assign an active-state CSS class for every element that has ui-sref directive?

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb

I still think this is a needed RFC.

You could always do this as a 3rd party plugin but I don't think it should be in core since a lot of links aren't going to need the active class

@pixelnix Then please see #1473, which is where this is being discussed.


increase maxDebtShareValueD18 for all networks

Increase the maxDebtShareValueD18 setting, which will increase the credit capacity of the perps markets.

all goerli are deprecated

Because 3.3.15 was released from #128 branch any fork tests based off main branch will fail now (for base sepolia). When we finalise the release and merge the branch - things will stabilise.
Alternatively you can set base for the PR to add-interest-rate branch instead of main and wait until it is merged.


Don't let the full package list appear on the path unless activated.

Closes #58

Thoughts on this @jendrikseipp & @guicho271828


Ghost 3 support

When I run
/var/lib/ghost# ghost-purge-images display --content-key=<myContentKey> --admin-key=<myAdminKey>

in Ghost 3.3.0 I get this error: Error: API Pages - Not valid response
Can someone confirm Ghost 3 is not supported at the moment?
cc @dburgos

hey @markjackson02 ,
Previously were using Ghost Content API v2, some minutes ago<EMAIL_ADDRESS>was released to support v3
Please let me know any issue you may find to help you, thanks

Thanks!! I will give it a try and open another ticket if I have any issues.


Preprocessor for LESS

Add LESS preprocessor for Vita

Vite already supports CSS preprocessor with HRM module, just needs to be installed, in our case with pnpm

created style.less, color.less


Issue with autoscale

I assume it's an issue with autoscale...
I would expect that the area is automatically scaling to the width of the chart, but it leaves some space on the left side

https://jsfiddle.net/bvjgp5z7/
I'm still trying it out, that's why the code is a bit messy. Sorry about that.

I usually use chart.timeScale().fitContent(); to make the chart fit with its container
More detail: https://github.com/tradingview/lightweight-charts/blob/master/docs/time-scale.md

Auto scale is only working for price scales and I think it works fine. The thing you want to achieve might be done by using fitContent as mentioned @thanhlmm in https://github.com/tradingview/lightweight-charts/issues/811#issuecomment-893289560. Also, you can use fixLeftEdge/fixRightEdge options to disallow scroll outside of the data, so you won't see any space from both sides.


[TASK] Specify OS dependent gold files

Issue Description
Is your feature request related to a problem? Please describe.
Some calculations (ARMA for example) give slightly different results when run on Windows, Mac, or Linux. It would be nice if we can specify gold files for each OS in the tests files.
Describe the solution you'd like
Specify the gold file you would like to use for the test based on the OS. For example:
[./testBasic]
  type = 'RavenFramework'
  input = 'test_basic.xml'
  UnorderedCsv = 'basic.csv'
  windows_gold = 'winBasic.csv'
  mac_gold = 'macBasic.csv'
  linux_gold = 'linuxBasic.csv'
[./]

Describe alternatives you've considered
Writing separate tests for each OS and using the "skip_if_OS" parameter.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Issue closure checklist is good.


Intellij 12.1.5 on windows does not recognize variable 'log' when class annotated with Lombok's @Slf4j

Migrated from Google Code (issue 582)

This seems to be not relevant anymore: lots of newer versions have been released and reported as working.


feat(ui): show CLIP Vision models in model manager UI

Summary
Not sure why they were hidden but it makes it hard to delete them if they are borked for some reason (have to go thru API docs page or do DB surgery).
Related Issues / Discussions

discord

QA Instructions
Should be able to see and delete CLIP vision models in the MM tab
Merge Plan
n/a
Checklist

[x] The PR has a short but descriptive title, suitable for a changelog
[ ] Tests added / updated (if applicable)
[ ] Documentation added / updated (if applicable)

We may want to rationalize these at some point so people can differentiate and better organize the models, but does make sense to show all models even if they’re “support” in nature.


When there's a duplicate named import, the formatter removes all existing named imports

Environment information
CLI:
  Version:                      1.6.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           unset
  JS_RUNTIME_NAME:              unset
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

open a project code base which has multiple files in visual studio code
import duplicated named import a file then organize imports with biome

Expected result
It removes all existing named imports
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

Please provide a reproduction or detailed instructions to reproduce the issue.

I have duplicate import as below;

I organize imports with biome

It removes all existing named imports

I have an Nx project where I use ESLint and Biome together, and I encountered this issue there. When I created a new project and used only Biome, I couldn't reproduce the issue.
package.json
nx.json

Sorry @aliarasea but we require a minimal reproduction that we can download and play with. Maybe a codesandbox or a repository.

This was happening to me if I had both source.organizeImports.biome and source.organizeImports enabled, can you double check that @aliarasea.
@ematipico maybe we can add a warning related to this in the docs, if not already

If that's a bug, it should be fixed. However, no reproduction is provided, so we can't help.


feat: create idcbrowser:// protocol to interact with slicer

This was a project born during PW 40 when @pieper once mentioned the idea of using Slicer just the way we use zoom. This post showed that it was indeed possible, and the current implementation is inspired from it, and the slicerio package.
See here for more discussion:
https://projectweek.na-mic.org/PW40_2024_GranCanaria/Projects/Launch3DslicerViaClickableUrlsForViewingIdcDataViaSliceridcbrowserAndIdcIndex/
https://discord.com/channels/843934857620357130/1197786173637132368
While the progress made during that PW was good, there was room for improvement as the previous approach was launching a new slicer instance with every URL request.
This PR aims to address some of the deficiencies. It is now possible to reuse the slicer instance. The key component to achieving this was using a web server. Significant progress was made during the next project week (PW41 at MIT) even though there was no official continuation of the project on the PW41 page. Once the webserver was able to handle localhost requests, the idcbrowser:// custom protocol was designed to launch a Python script (using PythonSlicer binary) that will parse the URL and send the requests to the slicer webserver.
It's been tested on all three major OSs Ubuntu, Windows, and MacOS. On Ubuntu, only the Firefox browser works. On Windows and MacOS any browser can handle idcbrowser:// requests. However, localhost:2042/idc requests work seamlessly on any browser/OS and are also clickable. idcbrowser:// is not recognized as a URL in markdown due to security reasons. However, in MS Excel, hyperlinks were recognized as URLs.
Pending tasks are:

[ ] Designing the expected behavior when a user has multiple slicer apps installed
[ ] Load segmentation files properly

It took a village (huge thanks to @pieper, @lassoan, @jcfr, @fedorov, @deepakri201, and @ccosmin97) to get to this phase but this was a very cool project, and hope others can take it to further heights in the future.

Sure @pieper I may or may not be able to join today's weekly as I have a dentist appointment. If I can join, I will show the demo today itself.
As for the resolver script, it simply parses the idcbrowser:// URL entered by the user, and then passes along the request to the slicer webserver. We can definitely discuss more when we can meet.

@pieper @vkt1414 would it make sense, to be safe, to have the installation of this feature to be disabled by default, so that it can be toggled/enabled by the user? I am a bit worried of using the production extension in the nightly for testing.

feature to be disabled by default

Yes, in the ideal world this should also include an uninstaller that resets everything.  Then you could have a UI option to install and uninstall the feature, with the default being off in the testing phase.

Another suggestion: in the resolver.py script there should be some error checking and also to try launching Slicer if the server is not responding.   We should think about how best to communicate to the user about what is going on (i.e. if there are any error message or other feedback to display).

Thanks @pieper for the review. I'll make suggested changes and test them.

feature to be disabled by default

Yes, in the ideal world this should also include an uninstaller that resets everything. Then you could have a UI option to install and uninstall the feature, with the default being off in the testing phase.

I wish I knew qt to implement this..as I believe all we need is fetch and execute a script upon clicking a button in slicer extension UI.

Another suggestion: in the resolver.py script there should be some error checking and also to try launching Slicer if the server is not responding. We should think about how best to communicate to the user about what is going on (i.e. if there are any error message or other feedback to display).

We can certainly invoke slicer if it is not running yet. I'll try to add that. Currently I do display a message when a series is downloaded and loaded into slicer. We can show something like if there is no instance of slicer web server running.
https://github.com/ImagingDataCommons/SlicerIDCBrowser/blob/d60704191527805875fe3ce05510b1f9269bb560/IDCBrowser/IDCHandlerModule.py#L105

@pieper @vkt1414 would it make sense, to be safe, to initially have the installation of this feature to be disabled by default, so that it can be toggled/enabled by the user? I am a bit worried of using the production extension in the nightly for testing.

May I know the safety concerns? This feature does impact a regular user who just wants to browse

May I know the safety concerns? This feature does impact a regular user who just wants to browse

IMHO, anything that modifies Registry on Windows has at least a potential for causing problems. To ease the rollout and reduce the risks, to me it would make sense to make this feature available for testing for those who want to enable it knowingly. We can enable it by default in a subsequent update. It does not need to be done by GUI - this could be a setting flag initialized in the Slicer config.

modifies Registry on Windows has at least a potential for causing problems.

You'd surprised that even though editing registry is locked on MGB official PCs, there were no issues modifying with code! I do not disagree with other points. And I have no idea about slicer config

install and uninstall the feature, with the default being off in the testing phase.

I wish I knew qt to implement this

My thought would just to be the opposite of registering the custom protocol - just delete all the files and registry keys you create in the registration step.

This is really nice! The only think I would change is to get user consent before permanently changing any computer configuration. Instead of silently calling self.registerCustomProtocol() on every startup, a popup could be displayed where the user could approve the configuration change, reject it, or choose to decide later.

This is really nice! The only think I would change is to get user consent before permanently changing any computer configuration. Instead of silently calling self.registerCustomProtocol() on every startup, a popup could be displayed where the user could approve the configuration change, reject it, or choose to decide later.

Thanks @lassoan ! I really like this suggestion.

@vkt1414 are you still working on this, do you plan to address the suggestion in https://github.com/ImagingDataCommons/SlicerIDCBrowser/pull/43#issuecomment-2287142653 and suggestions from Steve?

@vkt1414 are you still working on this, do you plan to address the suggestion in #43 (comment) and suggestions from Steve?

I would not be able to work on the Qt component anytime soon. It would be great if someone with qt expertise can take over that part. @LennyN95 suggestion to solve this was to create a file to record the state of the user's preference for two things, like a database.

Interested in the custom protocol or not
Whether to stop showing the pop up the message again

Both of these will require qt components that I'm not familiar and will require significant time to able to implement

Thanks for the update @vkt1414.  We'll try to get someone with Slicer Qt development experience to work on this.

It'd be also great if the user could specify the port the server is running on. Although conflicts are unlikely, giving the user a) feedback which port is occupied and b) the option to manually update this will provide transparency and allow to resolve any potential conflicts.

@vkt1414 sounds good, thank you for the update!
@pieper I think for the Qt part, this could be as simple as adding two buttons to a section of the existing module interface - to register and to un-register the custom protocol.

We tested this branch with @ccosmin97 and @deepakri201 on mac. It worked for Deepa. When trying to open this URL idcbrowser://series/1.2.840.1136<IP_ADDRESS>809705591242159075253605419469935510 I was prompted to open the app, but nothing happened in Slicer. I see the messages below in the python console, but nothing happens. Another note is that Slicer app does not become modal.
SlicerStartupCompleted emitted
IDC Request Handler has been registered and server started.
Slicer URL protocol is already registered.

Testing on Linux JetStream, I am getting this runtime error on startup, which makes sense, since idc-index won't be installed - the main module asks for the user confirmation to install it on the first start. So this needs to be fixed.

After installing idc-index it worked in linux!

@LennyN95 had some good ideas/questions as follow up to this, so maybe we should meet to discuss @pieper, since I do not have answers for Leo!

These all sounds fixable, just a matter of investing some time in it.  I'm happy to meet and discuss.
We can use Slicer's Qt environment to give feedback to the user if something fails.
The one piece of the process that needs to be implemented that's not a slicer-specific coding task is the functions to undo all the installation steps on each platform (i.e. removing any files and registry keys.  If someone else takes on this task I could do the Slicer/Qt parts.

undo all the installation steps on each platform (i.e. removing any files and registry keys. If someone else takes on this task

I can help with undoing the changes, but will not be able to test until the weekend after the upcoming holiday weekend.
But if someone would like to go ahead..we will need a function like this to remove the folder/files
import os
import platform
import winreg as reg
import logging

# Configure logging
logging.basicConfig(level=logging.WARNING)
logger = logging.getLogger(__name__)

def remove_protocols():
    system = platform.system()

    if system == "Windows":
        try:
            key = reg.OpenKey(reg.HKEY_CURRENT_USER, r"Software\Classes", 0, reg.KEY_ALL_ACCESS)
            reg.DeleteKey(key, "idcbrowser")
            reg.CloseKey(key)
            logger.info("Registry key 'idcbrowser' removed successfully.")
        except FileNotFoundError:
            logger.warning("Registry key 'idcbrowser' not found.")

    elif system == "Linux":
        path = os.path.expanduser("~/.local/share/applications/idcbrowser.desktop")
        try:
            os.remove(path)
            logger.info(f"File '{path}' removed successfully.")
        except FileNotFoundError:
            logger.warning(f"File '{path}' not found.")

    elif system == "Darwin":  # macOS
        path = os.path.expanduser("~/Applications/slicer-app.app/")
        try:
            os.rmdir(path)
            logger.info(f"Directory '{path}' removed successfully.")
        except FileNotFoundError:
            logger.warning(f"Directory '{path}' not found.")
    else:
        logger.warning("Unsupported operating system.")

These all sounds fixable, just a matter of investing some time in it. I'm happy to meet and discuss.

@pieper I agree most should be easy to address, with the exception of the one where it just did not work for me on my mac as I described in the issue. I am not sure what is going on there.
I will also test on Windows a bit later.

These all sounds fixable, just a matter of investing some time in it. I'm happy to meet and discuss.

@pieper I agree most should be easy to address, with the exception of the one where it just did not work for me on my mac as I described in the issue. I am not sure what is going on there.
I will also test on Windows a bit later.

From what you mentioned, slicer-app.app is already present on your system. Could you remove it and try again? as I currently do not overwrite if one is already present
also is localhost:2042/idc/collections  working? if so, slicer webserver is working as expected, it the cutom protocol that is not working properly, which pin points to slicer-app.app


Code Coverage measurements

Include a code coverage report in our build

Is there any interest still in implementing this?
I've locally quickly POC'd test coverage reporting via Cobertura (which I've used in the past) together with a gradle plugin (https://github.com/stevesaliman/gradle-cobertura-plugin) which still looks somewhat active.
Here are a couple sample screenshots (it generates web reports):

I think (but have yet to prove) that we can integrate this with travis and github checks to automate the reporting.

I think we should do it.

most definitely
On Thu, Feb 4, 2016 at 4:34 PM, akerekes<EMAIL_ADDRESS>wrote:

I think we should do it.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/issues/152#issuecomment-180061982
.


Fine Tuning The Model

I am trying to fine-tune the HDN model on the POT dataset. I have preprocessed the POT dataset as instructed. However, the training loss seems jumpy as it fluctuates from 1 to 600. I tried to debug the training flow and found that it happens when we feed the supervised training samples to the model. Also, the loss for the HMNET model comes out to be nan. Even after training the model for 1 epoch, the model performance decreases too much. Is there a bug in the training pipeline? Please assist.

I'm sorry I haven't seen the issue for some reason, did you solve the problem now?
Could you answer the following questions?

If the COCO14 and GOT-10K trained well in your experiment?
Have you visualized the input patches to ensure the augmentation or the format is ok?
Is the Similarity branch ok?
We did try to fine-tune the Similarity branch on POT long ago, and the performance became better, there may be some potential bugs in HMNET, but I think the loss is nan probably due to some settings being set wrongly, you can actually try to localize the which loss and check the if the label is set correctly (You can supervise the corner offsets to be zeros and see if the loss still fluctuates).

I also encountered the situation where the loss is NaN. It happened because I only provided supervised data to the model without any unsupervised data, so when calculating, division by zero occurred, resulting in an error. In your case of fine-tuning based on the POT dataset, there should be no unsupervised data available, which might be the reason for this issue. Moreover, during training, these NaN losses do not have any practical impact.

Do you have any experience with training from scratch or training based on the improved model provided by the author? I have tried training from scratch and training based on pre-trained models using COCO14 and GOT-10K data, but I couldn't achieve the same accuracy as the improved model mentioned by the author. Do you have any tips or experiences to share?


Add one-click PR approval on Conversation tab

Description
Re-proposing:

https://github.com/refined-github/refined-github/issues/883

We had initially rejected this feature because "you shouldn't approve without looking at the diff" but there are many cases where that is fine:

you already did and now you're back on the conversation tab
dependabot PRs

Also related:

https://github.com/refined-github/refined-github/issues/2702

Screenshot
I wonder if we can just add it here:

Example URLs
https://github.com/refined-github/sandbox/pull/4

I am scared of random people just clicking the button. Maybe only if a review is requested?

I'd probably still ask for confirmation to avoid mistakes

If we can detect it, only show it to maintainers

We do have a "canEditSidebar" that we can use for this purpose. I'm not sure if it necessarily produces a green check, but any moderator has been pre-approved by the repo-owner so they're unlikely to spam.

It would be great to have this.
I understand the fact that "you shouldn't approve without looking at the diff", but a lot of time, I already did review the PR files, but comme back to the discussion to read the descriptions, or the discussions again.
We might either check that the files page is in history, if possible, or add a warning to tell the user that one should review the PR first ?

This is highly desirable use case for PRs that have gone through many iterations. For instance, I review the code, but then I need to see if it actually works locally for our application. Then I checkout the PR and try it and everything is expected, go back to the PR and want to just approve! or add some comment that ok, you have changed this/that behaviour. But I need to navigate to the files changed, and for PRs with lots of files changed you can guess how slow would that page be to load!

I understand the fact that "you shouldn't approve without looking at the diff", but a lot of time, I already did review the PR files, but comme back to the discussion to read the descriptions, or the discussions again.

This exactly happen to me at least 5 times a day maintaining couple of repos

You're free to send a PR to add the feature. It has already been approved.


Autocomplete shows multiple of the same item

VSCode Version: Code - Insiders 1.18.0-insider (dcee2202709a4f223185514b9275aa4229841aa7, 2017-11-08T08:15:14.690Z)
OS Version: Darwin x64 17.2.0
Extensions: Extensions are disabled

Steps to Reproduce:

Start typing code. Autocomplete popup shows up.
Popup shows multiple items of the same thing - up to 8 to 10

Reproduces without extensions: Yes

A little more info... this seems to happen when VC Code is set to use it's own version of Typescript (2.6.1). When I switch to the version in the project (2.4.2), I see the correct popup items.

@jtsom If you scroll through these suggestions, do they all have identical descriptions?
TS 2.6 brought support for automatic imports. If there are multiple MatSnackBarConfig defined in your project, we will show an entry for each unique one. Selecting one should add the import from the corresponding file

Yes, each one has the same description. It definitely looks like it's just duplicating the entries. Again when I switched to using the project's Typescript, the popup was much shorter.

Can you please collect the typescript server trace of this to help us investigate. To do this:

Set "typescript.tsserver.trace": "verbose" in vscode

Trigger the incorrect suggestion again

Open the output view and go to the typescript section

Share the output from there

Thanks

Sure. Here you go. With a screenshot of what I did that generated the output:

typescripttrace.txt

FWIW, here's a screenshot with Typescript set to the project's (2.4.2):

Thanks for the additional info! I confirmed the bug and have opened https://github.com/Microsoft/TypeScript/issues/19922 to track this against TypeScript
Closing as upstream

Any idea when this is going to be filtered back to VS Code? I see the latest insiders has an insiders version of Typescript, but doesn't seem to fix the problem.

This should be fixed in TypeScript@next (Typescript 2.7). You can use this version in current versions of VS Code by following these instructions: https://code.visualstudio.com/Docs/languages/typescript#_using-newer-typescript-versions

Sorry to say, this problem still exists with Typescript 2.7.
Here's screenshot from 2.6.2:

And here's one from the latest 2.7dev version - it's actually worse!


MDX Remote: Further Support For Github Integration

Work in progress implementation of #479
TODO:

[ ] DEV WORKFLOW: WebSocket
[ ] Documentation

Production Workflow
GitHub Webhook + revalidatePath + revalidate (ex. 3600)
Development Workflow
WebSocket + disk cache (initial load) + in-memory cache (until process.exit) + file watcher

Btw since Next.js fetch also has its own cache, make sure to add force-cache to cache the request (on Next.js 15, this is required to enable fetch caching).

Note that we only need to fetch the file content for a specific page when the user opens it. (In [[...slugs]]/page.tsx).
In my opinion, this part can be done by only fetch (with Next.js cache) and fs.readFile (on development mode).
To build page tree, we just need the frontmatter of MDX page and JSON files (meta.json), you might not need to cache the entire file.

I came up with a diagram, it will be clear enought.

So I've made the GitHub API part for fetching Github file content, and maybe I can work on Hot reload later.
My idea is to run a Websocket on client and we notify the client to re-fetch page content (RSC payload) when a change is detected. I wrote a similar implementation for my fuma-content package so it's just copy-and-paste.

Sure, also feel free to modify the MDX remote example app in the examples folder to test it out!

Sounds good to me! Thanks for your help on this

@fuma-nama  No problem, its been fun to implement. When implementing the webook, use cache.load({ lazy: true }) and cache.fs().loadFile(getFileFromGithub(...)). Also, will the Github cache API need to be documented?

For production I'm still unsure what exactly is the best course of action, I'll wait for the websocket to be implemented so I can have a better idea of how it will be expected to work during dev.

I just realized that this cache can be beyond just the Github integration, for example, the localCache instance is unrelated to the Github API (although it makes git trees from files, other than that everything is just about caching files). I'm not 100% confident if this cache functionality can be expanded to more things beyond this integration, just a possibility I thought of.
A strong example of its use is in apps/docs; you can see it takes a significant amount of time to load all the files at first, but with this cache it can just do that once (across multiple processes), then only make minor changes from there.

I think Turbopack will fix this problem too

For production I'm still unsure what exactly is the best course of action for revalidation

GitHub WebHook will be a good choice, we only need to implement a route handler to receive notifications from GitHub. Or we can set the revalidation route segment config to an hour and let Next.js cache handles the rest

GitHub webhook + unstable_cache with revalidateTag?

@fuma-nama Most (if not all) functionality has been setup, except for the dev workflow. I will try to add more tests if possible.

Thanks! I'm working on OpenAPI integration these days, will work on the websocket tonight (if possible)

Ok, no worries! Sorry if I feel like I'm rushing you!

Do you have any ideas for how to persist updates that are made to the cache during production. I'm trying to apply changes to cache then revalidateTag. But I think since the cache is loaded in the same file as getPageTree etc. it keeps using the cache file (doesn't update). I'll try researching some ways to fix this.

I don't know if localCache (and the base implementation) fits in the mdx-remote package, because one half actually relies on remote files remoteCache while the other half is just a cache for local files during development.

I will probably write a loader (turbopack compatible) which automatically switches between local and remote, probably at an empty file like @fumadocs/mdx-remote/github/source. This because in order for cache to work in prod you need "use server" directive and to re-export everything as an async function, which easily gets messy.

Just write your cache to .next folder, and read it with fs

I'm working on the watcher, might change some other code as well, don't change things right now to avoid merge conflicts

dev environment:
A compiler with watch mode support, most code copied from my fuma-content library. We might considering replacing it with fuma-content package later, but let's leave it first.

If you look at the example now, I think it removed most of the boilerplate and migrated to the similar loader API that is exported from fumadocs-core/server

Sorry, I just saw the "dont merge" message. I was experimenting a fix for prod workflow all day, my bad.

I can try to resolve the merge conflicts if there are any.

Once your add your commits I'll try to fit it in to what I have locally that I reverted

Not a lot but added concurrently and WS server, now we can integrate WS server to Webpack/Turbopack

Wait me for a day, coming up with some more changes

Ok sounds good

@fuma-nama
I need githubCacheStore to be used when creating a new instance, because during during production it won't persist if its not saved,
I also added a loader store locally because in order for the changes to actually change (in production) I found that within getPageTree, getPages, getPage, etc. (async functions from loader) you need to recall loadFiles (basically do the redo the work within each function) within the each function, so to avoid redoing the same work I just made a store to the git tree's hash.
NOTE: I used a loader that changed .../github/source to export this function, wrapping the results in async functions with calls to loader(...) in each function, I found this easier because you just have to setup the wrapper with cache options around the nextConfig, then just import loader
I know that doing it this is kind of odd, but I tried other ways and this is the only way it worked in production (along with needing "use server")

I have these changes locally, so need to add the yourself, I'm just waiting for you to finish up. Just wanted to make sure you knew the changes I would be making.

This system may not be ideal fir implementing the dev server, I might do some breaking changes to current code. Will give you a short summary later

The system technically stays the same, because the loader can be production only, which means that abstraction not added in dev. I can easily make that change.

I also plan to use the loader as a way to abstract them having to invoke create cache themselves. I see the cache more as something that can be "hidden" because in reality they just pass repo and local options, but really that info is given to that cache.

I noticed the problem of cache, Next.js apps hosted on serverless environments like Vercel are not able to persist the cache. After being inactive for a while, the cache will be cleared. To persist it, we can use vercel data cache. As mentioned in the docs, it must be used in conjunction with Next.js cache (unstable cache or fetch cache).
I am already working on a fix

I found GithubCacheStore or just a class with map to work. I already have a working production workflow, the only thing I was missing was a dev workflow

The code is in the latest "redo prod workflow..." commit

I tried using unstable_cache and I think it's less granular than revalidatePath combined with "use server"

I'm trying to use unstable_cache or the fetch cache directly, and removed the custom in-memory cache implementation.
Also merged to the normal loader function of Source API, so that we can remove duplicated code

The dev workflow now works, with a problem of cache persistence. We cannot persist the cache unless we host a websocket server that runs outside of Next.js runtime. Because all variables in the Next.js runtime cannot be persisted during fast refresh.

I actually have an idea in mind tho, gonna implement that tomorrow

Finished the GitHub integration.
The docs of MDX Remote and demo site are not finished

And I want to deploy it to test our GitHub webhook integration, it would be pretty cool

Since we have to merge this PR to continue deploying the demo site, I'm merging it now.


Update strings.xml

Hi, just a quick heads up: remote is already translated, so I opened a PR to rename those translations (see #365).

Hi, sorry, but a previous PR changed these strings (dba7504e76747d5f2d5623d2a03c128b9159b959). Could you please check the new ones.


Weird style of Accordion when setting color to gray

Environment
The reproduction is conducted on the official document website.
Version
v2.14.0
Reproduction
https://ui.nuxt.com/components/accordion#style
Description
Set color to gray, variant to outline or soft, and enable dark mode.
For outline variant, the background color of hovered accordion item seems to be too bright. For soft variant, its normal style has the same issue. I don't know if it's intentional, but it looks not good for me.

Additional context
No response
Logs
No response

This is because the gray color has no outline variant, you can check all the possible combinations on the Button docs: https://ui.nuxt.com/components/button#style


Error with translations

Hi guys @michaelbromley  I'm using this example as a basis to create my plugin, but I'm having an error related to translations, when I have a translation tag I get the error below, if I remove the tag I don't have it anymore, do you know what it could be?
I have all the packages in the latest versions.

Thanks!

Hi,
I just took a look at I think it is because the SharedModule exported by @vendure/admin-ui/core does not import the TranslateModule and therefore the providers are unknown to your module.
One thing you can try is, in your ui extension NgModule, add:
import { TranslateModule } from '@ngx-translate/core';

// ...
imports: [
  TranslateModule.forChild(),
],

Let me know if that resolves it.

Hi Michael, I tried your solution but it doesn't work for a simple reason, I made a big mistake :D
I updated @ngx-translate/core to latest version in my plugin, but Vendure Admin UI uses version 13.x.x, different versions, different instances.
Thanks for the help :D


[Doc] Thread Pool documentation for opensearch

@Vineet-Sharma29 commented on Fri Apr 22 2022
Is your feature request related to a problem? Please describe.
I was looking through response of _cat/thread_pool API and couldn't find documentation for threadpools. I am unable to get clarity of which threadpool is meant for what purpose.
Describe the solution you'd like
Separate documentation for threadpools in opensearch
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Particularly in my case, I am working with async search and unable to get clarity on opensearch_asynchronous_search_generic threadpool.

@Poojita-Raj: Looks like a similar issue was raised in issue #520 . Could you provide some additional context regarding on the API call you used?


Azure Kubernetes Services 1.28 & 1.29 EOL dates are not correct

Product Page: https://endoflife.date/azure-kubernetes-service
endoflife.date for AKS 1.28: 2024-Nov-30
Product documentation for AKS 1.28: 15 Jan 2025
endoflife.date for AKS 1.29: 2025-Jan-31
Product documentation for AKS 1.29: 31 Mar 2025
Source website: https://learn.microsoft.com/en-us/azure/aks/supported-kubernetes-versions?tabs=azure-cli#aks-kubernetes-release-calendar
Additional context
This is a great resource, thank you for maintaining it.

Filed a PR for this. Can you review https://deploy-preview-6230--endoflife-date.netlify.app/azure-kubernetes-service and confirm it looks good? I've made slight changes to the content as well, explaining Platform Support.
Small PRs for changes like these are very much appreciated.


ENH Exclude a list of tables for checking and rapairs

Issue #10495

should this be defining explicit table names?
Why not use DataObject class names and infer the table names from that?
Why not define an upper limit of records, and any table with more than that number of records gets skipped?

should this new configuration be based on defining explicit table names? Why not use DataObject class names and infer the table names from that? Why not define an upper limit of records, and any table with more than that number of records gets skipped?

should this new configuration be based on defining explicit table names?
Why not use DataObject class names and infer the table names from that? Great idea will update the PR.

Why not define an upper limit of records, and any table with more than that number of records gets skipped? - My goal is to lessen the amount of queries to be executed.


.env.example more common than .env.sample

.env.example seems to be a much more common filename than .env.sample in both Ruby and Node land. Perhaps consider using it as the default?
EDIT: Also this module is genius.

Thanks! I just merged #2 for this.

@devinus @motdotla 2.0.0 has been released.

Amazing!


8.1 RC3: Dependencies not available when 'org.gradle.configuration-cache.problems=warn'

It seems dependencies are not available for tasks that set notCompatibleWithConfigurationCache() when org.gradle.configuration-cache.problems=warn.
Expected Behavior
Dependencies are printed when running the allConfigurationDependencies task having org.gradle.configuration-cache.problems=warn set in gradle.properties.
Current Behavior
Dependencies are not printed.
They are printed if org.gradle.configuration-cache.problems=warn is commented out in gradle.properties.
Context
It prevents the Gradle Versions Plugin from working when org.gradle.configuration-cache=true and org.gradle.configuration-cache.problems=warn: https://github.com/ben-manes/gradle-versions-plugin/issues/666#issuecomment-1488938639.
Related: #24411.
Steps to Reproduce
Reproducer: https://github.com/ianbrandt/gradle-configuration-cache.
Credit for the minimal reproducer task to @ben-manes.
Your Environment
Build scan URL: https://scans.gradle.com/s/wdrhio333pxey.

This is the intended behavior of notCompatibleWithConfigurationCache, though it might be a bit counter-intuitive. With problems=fail, errors coming from an annotated task do not fail the build but the cache entry is always discarded, so the build never runs from cache when such a task is in the work graph. With problems=warn, the entry is stored, and Gradle attempts to reuse it.
Before Gradle 8.0, it was only noticeable when you have a configuration cache hit, because a miss build was using a previously configured work graph. Since 8.0, the configured graph is first saved to the configuration cache, and then the new instance of the graph is loaded from the cache to be executed, to benefit from the parallel execution. Gradle falls back to the old behavior of using the configured graph if the entry is discarded due to errors. With problems=warn, it is expected that your build might run incorrectly if there are problems detected.
@ianbrandt, do you have a use case which requires you to keep using problems=warn for anything but seeing more configuration cache problems in one go?

@mlopatkin: Oh, well, I suppose I don't (that I know of).
I enabled it as a part of the troubleshooting that led to the now fixed #24411, and was naively assuming the Gradle Versions Plugin should work regardless of whether it was set to warn or fail.
Having it set to warn seems to also break the Dependency Analysis Plugin, as I just filed here: https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/issues/885.
As of RC3, both plugins seem to work with org.gradle.configuration-cache=true and nothing set for org.gradle.configuration-cache.problems. That's my use case at present, though given how the User Guide explains the option:

By default, Gradle will fail the build if any configuration cache problems are encountered. When gradually improving your plugin or build logic to support the configuration cache it can be useful to temporarily turn problems into warnings.

...I wouldn't tend to think warn would itself lead to any breakage. Quite the opposite, really. If you all intend to keep it as is for 8.1, maybe a warning added to the manual would help avert future bug filings.


Add project source dir as a module

It would be very useful to be able to address components via a relative path starting at the project root. A way to do this is to consider the project root as a special project, as if it was inside of node_modules as far as resolution is concerned.
Such a design greatly reinforces the 'app as a library' idea, and plays nice with most module loading scheme.
A proposed name is @app but configurable via angular-cli.json, where app is the project prefix specified in ng new --prefix app (this exists already and defaults to app).
Example:
// instead of
import { something } from '../../../../../../../shared/something';
// we could do
import { something } from '@app/shared/something';

This would also work for CSS preprocessors.
Such implementation would address https://github.com/angular/angular-cli/issues/865 and also greatly reduce the need for https://github.com/angular/angular-cli/issues/900.

Have seen similar thing in ng-bootstrap. The demo project inside refers to the main project using @ng-bootstrap and it is using webpack

In terms of webpack implementation would we be taking this @app property and mapping them to the webpack alias for module resolution @filipesilva

There are also tsconfig's  baseUrl and paths options.  This would only apply to typescript files but allows editors (e.g., vscode) to process and follow the mapping.
    "baseUrl": ".",
    "paths": {
      "@app/*": ["app/*"]
    }

Can't wait on this one :) Also struggling with FontAwesome Fonts implementation. Did a CDN for now...

Another thing to be aware of with aliases is tests. Just because webpack knows @app as an Ali's doesn't mean mocha or karma etc. will know how to resolve it

I've tried this, the TypeScript compiles, but I get bundle errors from webpack. I.e. I've added this to tsconfig.json:
"baseUrl": ".",
    "paths": {
      "@app/*": ["app/*"]
    },

I feel like I have to update webpack configuration somewhere?

The above additions to tsconfig and the inclusion of the TsConfigPathsPlugin in the CLI's web pack config work well so far. It definitely simplifies and improves readability of typescript imports.

@clydin How did you include TsConfigPathsPlugin, as the webpack configuration is blackboxed? And I had a look, and it's not in there?

I have basically @rolandoldengarm's issue, but there's a case that might be worth testing for someone: npm link.
When I attempted anything using symbolic links it seemed that webpack would resolve the real path instead of the alias. Combined with 'tsconfig:paths' not working yet, I cannot fathom solution to 'develop using modules' that's supportable long term.
Mostly want to call this out because at the moment this is listed as 'nice to have', and I really can't imagine being able to use the tool in this state long term.
I tried npm link, obviously. But also a few direct symbolic links - the craziest failure was when I symbolically linked a module that depends on another. Consider B depends on A: With both A and B npm install'd, everything works fine. However, removing the install of B and instead creating a symbolic link so that it looks like the source is under the 'app' directory, (and modifying the app.module.ts accordingly) fails, because it can't find module A.
On the chance this might be of interest to someone here I added some scripts to my repos to help demo it. If not interested, no worries.
The repositories I'm working on are https://github.com/ggranum/revector and https://github.com/ggranum/revector-demo
Specifically, if you clone both of those into the same parent and run
npm install
ng serve

Everything should work. Now stop the server and run:
 ./symlink-email-module.sh
ng serve

and you should reproduce the errors I'm seeing [though note that the sed command in the bash scripts may break on non-macs] :
ERROR in ../revector/src/lib/email-password-top-nav-login/top-nav-login.component.ts
Module not found: Error: Can't resolve '@revector/auth-service' in '/Users/ggranum/github/ggranum/revector/src/lib/email-password-top-nav-login'
 @ ../revector/src/lib/email-password-top-nav-login/top-nav-login.component.ts 12:0-68
 @ ../revector/src/lib/email-password-top-nav-login/email-password-top-nav-login.module.ts
 @ ../revector/src/lib/email-password-top-nav-login/index.ts
 @ ./src/app/app.module.ts
 @ ./src/app/index.ts
 @ ./src/main.ts
 @ multi main

There's a bash script to create npm links as well (but run the uninstall-revector.sh script first).
If nothing else, hopefully this post serves to point out how hard it will be to write modular code in external projects without this feature.
Thanks much

We're using symlink (Windows) and it's working fine with system-config. Have not tested npm link yet.
And I agree priority should be increased. Previously our code was quite a mess with all the ../../../.. and ../../.., etc., and requiring changing all the imports when moving stuff around.
Now  it is super clean with "import {..} from 'app/domain"

@rolandoldengarm I am now deeply curious: what do you mean when you referenced system-config? Are you using system-config in combination with the webpack version of the CLI? If so, I'd love to hear more...
As for symlinks... this is unquestionably a design failure of Node. I have a few horrible, evil ideas about how to make the ' --preserve-symlinks' flag propagate through Node's call chain, but nothing I'd be proud of. And certainly nothing that would 'just work' when I clone my repository onto another machine, for example.  It might be possible that there is something relatively simple the CLI team could do to enable symlink'd directories to work properly with node/webpack... but a) I doubt it and b) why bother?  Leveraging tsconfig:paths just makes so much more sense.

@ggranum no sorry, I'm still on the "old" Angular CLI that uses system-config and systemJS. We've got a symlink called "app" in our node_modules folder, pointing to the app folder.
Then, we can do "import {} from 'app/domain'" to point to src/app/domain/index.ts,
instead of ugly relative paths like
"import {} from '../../domain'"
This works OK in the "old" CLI, but not with webpack. And, as the webpack angular-cli does not support this feature using baseUrl in TS2.0 yet, we're stuck at the old CLI. Very disappointing.

Just curious, is there any solution for us in the Webpack CLI at this stage? As said, right now we add a symlink to node_modules (Windows) pointing to the app folder.
That works on systemJS, Webpack throws errors.
This is our only blocker for switching to Angular CLI webpack. Maybe there is an alternative??

This should definitely be bumped in the priority. With the old CLI using systemjs I got it to work by myself (without symlinks in node_modules), but since index.ts files don't work well with webpack I dropped that and made all imports relative, which looks like a total mess. This is absolutely unmaintainable for medium to large sized projects

index.ts does not work well with webpack either??
We've got a pretty big project, and created separate files for our domain objects; about 50 of them.
Some services import 20, which right now is
import { DTO1, DTO2, ... DTO20 } from 'app/domain'

so we would be back to
import {DTO1} from '../../domain/dto1
import {DTO2} from '../../domain/dto2
import {DTO3} from '../../domain/dto3

Unacceptable for us.
How come not many people see this as priority??

The not-working barrels is another issue, I can understand that imports relative to project root are more like syntactic sugar, but it would be really, really, really nice to have, not just "p3: (nice to have)"

Relative imports are just a configuration change, but as that is blackboxed we cannot change it... But technically it would be a minor change.

@ggranum I don't know about index.ts not working, that's what @christiandreher said.
I just don't want relative paths. That's so ugly. It's just a simple configuration change in Webpack, but apparently nobody here thinks it's important enough to bother.

At least they didn't work for me, like described here: https://github.com/angular/angular-cli/issues/1585.

This two steps allowed the proposed @app thing works

I just submited a pull request about it: https://github.com/angular/angular-cli/pull/2210

changed the tsconfig.json, adding:

"baseUrl": ".",
 "paths": {
      "@app/*": [
        "app/*"
      ],
      "app/*": [
        "app/*"
      ]
    }

and then changed the resolve on webpack-build-common.js
var aliasConfig = {
    'app': path.join(appRoot, 'app')
  };
  aliasConfig['@' + appConfig.prefix] = path.join(appRoot, 'app');

....
resolve: {
            extensions: ['', '.ts', '.js'],
            root: appRoot,
             alias: aliasConfig,
        },

For full tsconfig.json paths support change the resolve object located at https://github.com/angular/angular-cli/blob/master/packages/angular-cli/models/webpack-build-common.ts#L38 to:
    resolve: {
      extensions: ['', '.ts', '.js'],
      root: appRoot,
      plugins: [
        new atl.TsConfigPathsPlugin({
          tsconfig: path.resolve(appRoot, appConfig.tsconfig)
        })
      ]
    },

Note the  addition of the atl.TsConfigPathsPlugin.
Also, depending on the future implementation of the ngc integration, this may become unnecessary and/or incompatible in the future.

@clydin Thanks for that, and @abner for triggering the additional attention.
I am running @clydin's changes locally and it works exactly as advertised for ng serve. For ng test I had to add:
// insert at line 5
const atl = require('awesome-typescript-loader');
// ...
// replace near line 14
resolve: {
      extensions: ['', '.ts', '.js'],
      root: appRoot,
      plugins: [
        new atl.TsConfigPathsPlugin({
          tsconfig: path.resolve(appRoot, appConfig.tsconfig)
        })
      ]
    },

To https://github.com/angular/angular-cli/blob/master/packages/angular-cli/models/webpack-build-test.js. Works so far. I leave it up to those who know about the interplay between the various affected systems to say if this is a good idea or not :~)

Great! I just updated the PR #2210 to use the TsConfigPathsPlugin as sugested.

Also, depending on the future implementation of the ngc integration, this may become unnecessary and/or incompatible in the future.

@clydin Why, unnecessary? Are ngc already support tsconfig's path?

awesome-typescript-loader is not compatable with becoming ngc update.
The best approach, that I see is using webpack config's resolve {alias: ...}

read tsconfig.json and get path
read agular-cli.json and get css path (for sass imports)
join these paths and add to webpack config's resolve {alias: ...}

Fixed by https://github.com/angular/angular-cli/pull/2470. We're not looking at also doing the CSS preprocessors right now, but will look at it later.

can some one consolidate guide on how to config and use this?

I'm still running into this using the latest release of the cli. The path resolves using tsc, but not ng.
❯ tsc --traceResolution | grep @app
======== Resolving module<EMAIL_ADDRESS>from '/path/to/my/project/src/app/components/library/element-list/element-list.component.ts'. ========
'baseUrl' option is set to '/Users/wayne/src/github.com/overhq/over-cms', using this value to resolve non-relative module name<EMAIL_ADDRESS>'paths' option is specified, looking for a pattern to match module name<EMAIL_ADDRESS>Module name<EMAIL_ADDRESS>matched pattern '@app/*'.
======== Module name<EMAIL_ADDRESS>was successfully resolved to '/path/to/my/project/src/app/types/element.type.ts'. ========

❯ ng build
Hash: 3c4a820798b36084d24b
Time: 12929ms
chunk    {0} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 231 kB {4} [initial] [rendered]
chunk    {1} main.bundle.js, main.bundle.js.map (main) 260 kB {3} [initial] [rendered]
chunk    {2} styles.bundle.js, styles.bundle.js.map (styles) 15.2 kB {4} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 4.51 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]

ERROR in /path/to/my/project/src/app/components/library/element-list/element-list.component.ts (2,23): Cannot find module<EMAIL_ADDRESS>
Here are my versions:
{
  "dependencies": {
    "@angular/common": "2.4.9",
    "@angular/compiler": "2.4.9",
    "@angular/core": "2.4.9",
    "@angular/forms": "2.4.9",
    "@angular/http": "2.4.9",
    "@angular/platform-browser": "2.4.9",
    "@angular/platform-browser-dynamic": "2.4.9",
    "@angular/router": "3.4.9",
    "@types/moment-timezone": "^0.2.34",
    "angular2-notifications": "0.4.53",
    "core-js": "2.4.1",
    "ie-shim": "0.1.0",
    "ionicons": "3.0.0",
    "less": "2.7.2",
    "lodash": "^4.17.4",
    "moment": "2.17.1",
    "moment-timezone": "^0.5.11",
    "ng2-bs3-modal": "0.10.4",
    "ng2-select": "1.2.0",
    "pace-progress": "1.0.2",
    "rxjs": "5.2.0",
    "zone.js": "0.7.8"
  },
  "devDependencies": {
    "@angular/cli": "1.0.0-rc.1",
    "@angular/compiler-cli": "2.4.9",
    "@types/jasmine": "2.5.38",
    "@types/node": "7.0.8",
    "codelyzer": "2.0.1",
    "jasmine-core": "2.5.2",
    "jasmine-spec-reporter": "3.2.0",
    "karma": "1.4.1",
    "karma-chrome-launcher": "2.0.0",
    "karma-cli": "1.0.1",
    "karma-coverage-istanbul-reporter": "^0.2.0",
    "karma-jasmine": "1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "5.1.0",
    "ts-node": "2.1.0",
    "tslint": "4.5.1",
    "typescript": "2.2.1"
  }
}

Does anyone know how to resolve this issue? Property paths in tsconfig doesn't help at all. Actually, it helps on .ts compilation phase, but it fails in WebPack then.

@antonberezan I actually found using the default cli setup, this kinda works out of the box now. You can import {ElementService} from 'app/services/element.service'; automagically.

@antonberezan I actually found using the default cli setup, this kinda works out of the box now. You can import {ElementService} from 'app/services/element.service'; automagically.

To  me is giving me cannot find module.

@ekaitzht I summarized some of the issues I had getting named paths to work here. The project I link in there is a working example - not claiming it's a quality working example, but it uses named paths and it loads, runs tests and the libraries it emits don't break AoT for consuming projects.

Just moving the project from dev mode to prod. Had to split up the app.module in to features modules, lazy loading, etc, it is quite time consuming to change the paths basically you had to do it twice in components and in spec files - nightmare.

To make the current version of vscode pick up the settings, you'll need to add a workspace settings file
@clydin Is there a similar solution for WebStorm/PHPStorm?

After struggling by searching over internet n trying to understand what exactly problem and trying different troubleshooting option, I came to know baseUrl and Path how works together
Note: This solution  is for Angular Cli 1.x . Not sure about other tool,
If you use baseUrl:"." like below it works in VScode but not while compiling
{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "baseUrl": ".",
    "paths": {
      "@myproject/*": ["src/app/*"]
    }
}

As far my understanding and my working app and checked in angular aio code,  I suggest use as baseUrl:""src like below
{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "baseUrl": "src",
    "paths": {
      "@myproject/*": ["app/*"],
      "testing/*": ["testing/*"]
    }
}

By having base URL as source(src directory), compiler properly resolves modules.
I hope this helps to people resolve this kind of issue.

I don't get how something so simple can be so hard to achieve.

"baseUrl": ".",
"paths": {
    "app": [
        "src/app/*"
    ]
},
"include": ["src/**/*"],
"exclude": []

... and it should be all good.

Here's how I handled it:
in tsconfig.json
"compilerOptions": {
    "baseUrl": "src",
    "paths": {
      "@directives/*": ["app/shared/directives/*"],
      "@services/*": ["app/shared/services/*"],
      "@models/*": ["app/shared/models/*"],
      "@assets/*": ["assets*"],
      "@components/*": ["app/components/*"]
    },
...

Example:
import { ShoppingItem } from<EMAIL_ADDRESS>

They remove the above mentioned solution with awesome-typescript-loader and they're now using AotPlugin: https://github.com/angular/angular-cli/commit/f9a7c01602546dea6c92adb165a5c437689c41b4#diff-3c07f218821da114292666210f358440
If use something like import { AppComponent } from 'app/app.component'; in app.module.ts then tooling doesn't work and editor complains about TS2307: Cannot find module 'app/app.component'.
If I put
    "baseUrl": ".",
    "paths": {
      "app/*": ["./src/app/*"]
    },

into tsconfig.json
then the editor reports an error inside app.component.ts: Angular: Component 'AppComponent' is not included in a module and will not be available inside a template. Consider adding it to an NgModule declaration.

@abner @filipesilva does the new AotPlugin solution work for you?
Is it possible to reopen this issue?
I also tried to exject the config and use Webpack's alias but it didn't work either.

Inside app.component.ts the editor still reports:
Angular: Component 'AppComponent' is not included in a module and will not be available inside a template. Consider adding it to an NgModule declaration.

For me this worked fine (tsconfig.json, not tsconfig.app.json):
    "baseUrl": "./",
    "paths": {
      "~/*": [ "*" ],
      "@app/*": [ "src/app/*" ],
      "@core/*": [ "src/app/core/*" ],
      "@shared/*": [ "src/app/shared/*" ],
      "@feature/*": [ "src/app/feature/*" ]
    }

the critical part that I was missing at the beginning was * at the end of both keys and relative paths.
VIsual Studio recognized the aliases after I restarted it.

Here is my solution

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "src",
    "paths": {
      "@models": [
        "./app/models/index.ts"
      ],
      "@environment": [
        "./environments/environment.ts"
      ],
      "@services/*": [
        "./app/services/*"
      ]
    }
  }
}

Be aware that you must restart the CLI each time you make any changes in the tsconfig.json, so that they can take effect, also be aware that although the routes will work,  you probably wont have any autocomplete for them.

@Xapuu worked for me too. thanks

@clydin / @filipesilva How do you think we should handle this in a CLI v6 project using libraries ? Especially when following https://github.com/angular/devkit/issues/730#issuecomment-382379686.

For a library type project, how to have these paths mappings seen by a client application ?


Fix longstep initialization

What changes does this PR introduce?
Bug fix
What is the current behaviour?
LS_fwFlux is not initialized.
What is the new behaviour
It is initialized.
Does this PR introduce a breaking change?
No
Other information:
Logging of longstep package parameters is moved to a new s/r longstep_check, called from packages_check, so that it appears in the right place in the model output.

Hi @jahn, looks good to me.
I would have called the longstep_check from within the #ifdef ALLOW_PTRACER, but it's probably cleaner this way.

I think you are right.  If others agree, I'll change it.

@jahn from my side, it's fine to have this new S/R call just within ifdef ALLOW_LONGSTEP (like longstep_readparms call and longstep_init_fixed call).
Now just a side comment: there is one check + stop in longstep_init_fixed.F that we may want to move also into this new S/R, just after printing the summary. I think it would be more natural there. But the setting of LS_usePmEpR could stay in longstep_init_fixed.F (or move to the end of longstep_readparms.F ?).

I've followed these suggestions.

@jahn I've just added few #ifdef ALLOW_PTRACERS in longstep_forcing_surf.F and checked that it compiles without pkg/ptracers. Please take a look and check that I did not messed-up this.
Otherwise, everything looks good to me.

Looks good.

I would like to merge this PR later today (unless someone disagree); and if everything goes well  will do a tag tomorrow.


does not download all images from max range of images

does not view all images by artist or make possible to download
i loaded up one of my favorites (tooo) on gelbooru
it said there were 181 images but it downloaded only 109 total
i dont have any blacklisted tags to filter out images
windows 7 professional 64 bit

nvm nvm please disregard i figured it out
i had the wrong source website and it was filtering tags
thank you so much for making this program its so awesome

Ok I'll close the issue in that case!

thank you so much for making this program its so awesome

You're welcome!  :ok_hand:


Sam/pgroonga deps

What kind of change does this PR introduce?
a comment on a PR https://github.com/supabase/postgres/pull/462#issuecomment-2270662752 reported that in our 15.6 release, TokenMecab was no longer working on the pgroonga extension.
This PR restores that Tokenizer capability to the proonga extension, and adds the following test below, which will run on every PR going forward.
-- File: 0005-test_pgroonga_revised.sql

begin;
    -- Plan for 3 tests: extension, table, and index
    select plan(3);

    -- Create the PGroonga extension
    create extension if not exists pgroonga;

    -- -- Test 1: Check if PGroonga extension exists
    select has_extension('pgroonga', 'The pgroonga extension should exist.');

    -- Create the table
    create table notes(
        id integer primary key,
        content text
    );

    -- Test 2: Check if the table was created
    SELECT has_table('public', 'notes', 'The notes table should exist.');
    -- Create the PGroonga index
    CREATE INDEX pgroonga_content_index
            ON notes
         USING pgroonga (content)
          WITH (tokenizer='TokenMecab');

    -- -- Test 3: Check if the index was created
    SELECT has_index('public', 'notes', 'pgroonga_content_index', 'The pgroonga_content_index should exist.');

    -- -- Cleanup (this won't affect the test results as they've already been checked)
    DROP INDEX IF EXISTS pgroonga_content_index;
    DROP TABLE IF EXISTS notes;

    -- Finish the test plan
    select * from finish();
rollback;

@samrose lgtm, feel free to merge once the conflicts are resolved


allow baseUrl, paths, rootDirs in tsconfig files

Re: #833, Add the above as valid tsconfig.json properties.
Note: this change does not necessarily make these properties functional, it
simply allows them to be passed to the transpiler.
baseUrl and paths seem to work. rootDirs has not been verified and
might not be functioning (at least on cur. typescript@next).
TODO: this does not yet deeply validate the paths and rootDirs properties.
I plan to mark this as closing the issue if I can figure out what's up with rootDirs as time permits, but this might be merge-able now as a starting point.

+1

@laurelnaiad I've added you as an owner. Please do whatever you want with this package. Merge then publish https://github.com/TypeStrong/atom-typescript/blob/master/CONTRIBUTING.md#publishing then write notes at https://github.com/TypeStrong/atom-typescript/releases :rose:
Feel free to @ mention me if you need any help.

@basarat !?  :(
Yikes. I'll do what I can.... does this mean that you're really backing off on atom-typescript? I can't carry your load.... more hands, sharper tacks needed..... I will have questions for you when I have some breathing room from project work.

I can't carry your load

Don't worry you are just one of the many people. Just means that I trust your code explicitly and don't feel the need to review it :rose:

does this mean that you're really backing off on atom-typescript?

I'm trying to limit my OSS work, sticking to StackOverflow + alm.tools + typescript book. Focus for this year is revising Algorithms and Data Structures :rose:

Ok... I'll look at the rootDirs situation tomorrow and see if I can finish this off with the accoutrements that an owner would provide.... :)

I'm developing a theory that this PR leaves behind an issue relating to LanguageServiceHost(2) losing track of files. I'm wondering whether it's receiving partial paths where it clearly wants absolute ones.
All I know for sure so far is that my instances of "The file '/Users/dmaddox/.../somewhere/suchAndSuch.ts' is not included in the Typescript compilation context. If this is not intended..." have gone way up. Hopefully I'll have some time soon to dig into this.

I locally had implemented this same concept slightly differently than in your PR, and I saw the same problem. If I have time on Monday, I'll try to dig into resolving those issues with you.
--
Michael Owens
<EMAIL_ADDRESS>https://mowens.com
@mko

On Feb 26, 2016, at 10:55 AM, Daphne Maddox<EMAIL_ADDRESS>wrote:
I'm developing a theory that this PR leaves behind an issue relating to LanguageServiceHost(2) losing track of files. I'm wondering whether it's receiving partial paths where it clearly wants absolute ones.
All I know for sure so far is that my instances of "The file '/Users/dmaddox/.../somewhere/suchAndSuch.ts' is not included in the Typescript compilation context. If this is not intended..." have gone way up. Hopefully I'll have some time soon to dig into this.
—
Reply to this email directly or view it on GitHub.

Strong circumstantial evidence that non-rooted paths are sneaking their way into places they shouldn't be:
This is an exerpt from having done the following logging in the source:
app/routes/layout/layout.ts
app/routes/root/root.ts
/Users/dmaddox/Documents/_ws/myproj/src/browser/app/ng1Providers.ts
/Users/dmaddox/Documents/_ws/myproj/src/browser/node_modules/rxjs/add/observable/zip.d.ts
/Users/dmaddox/Documents/_ws/myproj/src/browser/app/app.ts
/Users/dmaddox/Documents/_ws/myproj/src/browser/app/appState.d.ts

from project.ts
    /** all files except lib.d.ts  */
    public getProjectSourceFiles(): ts.SourceFile[] {
        var libFile = languageServiceHost.getDefaultLibFilePath(this.projectFile.project.compilerOptions);
        var files
            = this.languageService.getProgram().getSourceFiles().filter(
              x => {

                console.error(x.fileName) // laurelnaiad's addition
                return x.fileName !== libFile
              }
        );
        return files;
    }

Those non-rooted paths just happen to be some of the ones that are being reported as "not in a compilation context".

I find it slightly odd, I guess, that in the presence of tsconfig files that have files arrays, that we'd be asking tsc for a list of files in the project... but I guess there are reasons. In any case, I guess the fix is to resolve to rooted-paths... whereever that lands is probably also a reasonable place/time to address rootDirs, I suppose.

:+1: Can't wait for this one! ;)

Me, too! :) I tried hacking at the getProjectSourceFiles function to see if teaching it how to resolve the paths would help, but apparently that function is also used in place where finding the files leads to confusion in tsc itself (assertion errors that we're looking for a file that doesn't exist)... so apparently I messed with the wrong function...
I am going to try to carve out a little time this weekend to find an alternative function to hack. :)

I just added the support to http://alm.tools : https://github.com/alm-tools/alm/issues/73 :rose:
The only thing missing from this PR I think is that baseUrl isn't being make absolute as soon as its read from the the tsconfig.json file (see other examples like outFile in the same code here https://github.com/TypeStrong/atom-typescript/blob/de5aca96840dfc8723652f115d17341bf217320d/lib/main/tsconfig/tsconfig.ts).

rootDirs would just work too if the path resolution is done up front. See https://github.com/alm-tools/alm/issues/74 for commit :rose:

Hello guys, any news when this will come out?

+1

Superceeded by (now merged) https://github.com/TypeStrong/atom-typescript/pull/996 :rose:


README - rewrite the README

Make it actually attractive and informative.
Tell people how to build the project, how to install it and use it (as well as how to run the tests). (This may need some additional scaffolding to be able to install the binary we produce etc).
Split the dev notes out into a separate file.
Generally make this into an open source project that looks like something that someone might be able to use, rather than a random lump of code.

I plan to integrate this project into mlua to provide a high level unified API.
For now I'll remove most of the details in README as the current state is WIP and not ready for anybody use or announcements.


Check and remediate Bastillion's control of c3awx

Despite the profiles looking correct for the infraadmin group, the authorization to log in to c3awx seems to only have the default users on it. This needs to be fixed so other members of the admin team can access the server for maintenance purposes.

Effectively a dup of https://github.com/adoptium/infrastructure/issues/3021 - closing


CN General Fixes

Have made some general fixes to my code. This includes making the pages more mobile friendly, removing unnecessary code, adding error handling. There may be some redirect errors due to routing, but I have fixed what I could find. Let me know if you spot any more redirect errors. Check commits for full list of fixes

If you're wondering what the merge conflicts are, take a look here: https://github.com/Jforjo/CSD/commit/7581880d518b1d41bb20d8ce1bea3de812b8049a

Just delete the 2 files that are causing the merge conflicts. I've already copy and pasted the code from them directly to sudo-main.

Did you still want me to delete the files causing the merge conflict?

This was all because of the ending of a PHP tag "?>" had an extra tab of spacing before it...

Yeah I noticed that and fixed it in the web editor, strange how that could cause a merge conflict though


js files in "dist" is empty.

Thank! I fix it. Remove plugin from bower components, run bower cache clean and install again


To add Greedy Algorithm

Is your feature request related to a problem? Please describe.
Yes , Greedy algorithm is used to solve problems to find anything in minimum attempt.
Describe the solution you'd like
I would like to add proper description and solution of greedy algorithm with a solve example of it
Describe alternatives you've considered
I can do it for all three languages java ,c++ and python.
Additional context
@Kumar-laxmi  Please assign me this issue I'm a SSOC contributor

@ayan-joshi Greedy algorithm is a vast concept, kindly raise issue pertaining to specific algorithm


CLI not using latest api version

Summary
When no version is specified (because optional), CLI is supposed to retrieve by itself the latest version available.
This doesn't seems to work. I have seen it broken in docker container which is really hard to debug.
Steps To Reproduce
I don't really know how to reproduce as navigating through the CLI code didn't help me understand why it doesn't get latest version nor where are located some of the warning message I am getting.
Expected result
If no version is specified always use the latest version available.
Actual result
Sometimes using a previous version probably taken from some cache which never gets refreshed.
Additional information
The CLI is running inside a docker container. No config has been done to cache the .sfdx/[username].json file (which stores the instanceApiVersion cached property).
I can even see a Removing .sf/ and Removing .sfdx/ in the log of the CI which should remove these. Which means maybe there is some sort of env variable cached?
My project & CLI installation has none of the mentioned method to setup version done: https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_apiversion.htm
Here are the some tests and error message I got:

Without specifying anything

Warning: Deprecated config name: apiVersion. Please use org-api-version instead.
"warnings": ["API version not found or not supported, using '60' instead"]

Specifying an env variable SF_ORG_API_VERSION to 61.0

WARNING: apiVersion configuration overridden at "61.0"
Warning: Deprecated config name: apiVersion. Please use org-api-version instead.
"warnings": ["API version not found or not supported, using '60' instead"]

Specifying a sourceApiVersion in sfdx-project.json to 61.0

Warning: Deprecated config name: apiVersion. Please use org-api-version instead.
Found out that it did use the given 61.0 and my deployment worked

Looking at the CLI sourcecode:

CLI seems to put the retrieve version in cache
CLI seems to never refresh its cache, storing a instanceApiVersionLastRetrieved but never considering it expires

System Information
Docker container triggered by Gitlab pipeline (equivalent to Github actions or CI).
  It can also be helpful to run the command with --dev-debug which has some output around discovering API versions.  The doctor command can also handle that for you with: sf doctor --command "the command you are running".  Which command are you running by the way?

Because my issue is in a docker container, it is really hard to get this kind of information.
I think I find out from where the 60.0 comes from. In fact my job is generating an XML file which is then used with sf project deploy validate command to deploy it to the org. This XML file contains <version>60.0</version>.
This file is generated from sfdx-git-delta plugins. I believe they are handling the get max api version a bit differently than you. I will check with them 😃

Yes the version from a manifest will be used in that case.  Here is a doc that will hopefully make this less confusing (because it is confusing): https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_apiversion.htm