identity: cache: close channel in writing party

As part of the shutdown procedure involving IPCache and the identity allocation components, it was possible to hit a 'write on closed channel' panic, caused by writes of the localIdentityCache to the events channel, which is closed as part of the shutdown of the identity allocator.
Instead of directly closing the channel, call into the localIdentityCache (the only writer) to do so, with proper mutual exclusion guaranteed by the mutex.
The offending writes happened in lookupOrCreate as well as release, both of which take the mutex, and hence are correctly synchronised with the new close() method.
Fixes: #25235
Since this affects the shutdown procedure, I believe this not to impact actual cilium deployments, merely our integration tests; hence release-note/misc.

CI triage:

Travis CI hit https://github.com/cilium/cilium/issues/25272
ConformanceGatewayAPI / gateway-api-conformance-test failed with something new seemingly

=== RUN   TestConformance/TLSRouteSimpleSameNamespace
    suite.go:258: Applying tests/tlsroute-simple-same-namespace.yaml
    apply.go:211: Creating gateway-conformance-infra-test TLSRoute
    apply.go:211: Creating gateway-tlsroute Gateway
    helpers.go:290: Gateway expected observedGeneration to be updated for all conditions, only 0/1 were updated. stale conditions are: Accepted
    helpers.go:441: Accepted condition set to Status False with Reason InvalidTLSRoute, expected Status True
    helpers.go:441: Accepted was not in conditions list [[{Accepted False 1 2023-05-10 12:36:01 +0000 UTC InvalidTLSRoute Gateway.gateway.networking.k8s.io "gateway-tlsroute" not found}]]
    helpers.go:441: Accepted condition set to Status False with Reason InvalidTLSRoute, expected Status True
    helpers.go:441: Accepted was not in conditions list [[{Accepted False 1 2023-05-10 12:36:01 +0000 UTC InvalidTLSRoute Gateway.gateway.networking.k8s.io "gateway-tlsroute" not found}]]
    helpers.go:441: Accepted condition set to Status False with Reason InvalidTLSRoute, expected Status True
    [SNIP, lots of repetition]
    helpers.go:441: Accepted was not in conditions list [[{Accepted False 1 2023-05-10 12:36:01 +0000 UTC InvalidTLSRoute Gateway.gateway.networking.k8s.io "gateway-tlsroute" not found}]]
    helpers.go:441: Accepted condition set to Status False with Reason InvalidTLSRoute, expected Status True
    helpers.go:441: Accepted was not in conditions list [[{Accepted False 1 2023-05-10 12:36:01 +0000 UTC InvalidTLSRoute Gateway.gateway.networking.k8s.io "gateway-tlsroute" not found}]]
    tlsroute-simple-same-namespace.go:51:
        	Error Trace:	/home/runner/work/cilium/cilium/vendor/sigs.k8s.io/gateway-api/conformance/utils/kubernetes/helpers.go:445
        	            				/home/runner/work/cilium/cilium/vendor/sigs.k8s.io/gateway-api/conformance/utils/kubernetes/helpers.go:606
        	            				/home/runner/work/cilium/cilium/vendor/sigs.k8s.io/gateway-api/conformance/tests/tlsroute-simple-same-namespace.go:51
        	            				/home/runner/work/cilium/cilium/vendor/sigs.k8s.io/gateway-api/conformance/utils/suite/suite.go:262
        	            				/home/runner/work/cilium/cilium/vendor/sigs.k8s.io/gateway-api/conformance/utils/suite/suite.go:220
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestConformance/TLSRouteSimpleSameNamespace
        	Messages:   	error waiting for TLSRoute to have parents matching expectations
    apply.go:219: Deleting gateway-tlsroute Gateway
    apply.go:219: Deleting gateway-conformance-infra-test TLSRoute

     --- FAIL: TestConformance/TLSRouteSimpleSameNamespace (61.07s)
FAIL
FAIL	github.com/cilium/cilium/operator/pkg/gateway-api	117.095s
FAIL

rerunning to see if it's flaky or just broken by me

I've redone the PR somewhat, to try to implement Sebastian's suggestion of encoding who writes/reads from the channel in the type system. It's a bit messy, however, since the caching identity allocator needs to pass it's channel on to the actual allocator, hence needs to maintain both a recv/send variant of the same channel (or a bidirectional reference, hence losing the type safety). I'm on the fence in terms of which variant is better, feedback welcome.

/test

CI triage

ci-multicluster

Errors: 1 pods of DaemonSet cilium are not ready
Warnings:         cilium             cilium-tq5q9    pod is pending

Error: Unable to install Cilium: timeout while waiting for status to become successful: context deadline exceeded

Didn't really find anything interesting; in the k8s events there's some references to the node not being ready. No logs, cilium's init containers didn't even run.

/ci-multicluster


Monorepo README

Summary
This PR replaces the Web5 JS root README file with content relevant for its current state as a monorepo.
Context
The Web5 JS Repo has gone through significant changes since its inception over 14 months and the root README had not been updated to reflect the transformation from a single NPM package to a monorepo housing 10 packages.
closes #270
closes #455

Codecov Report

Merging #475 (d22d996) into main (3e79652) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   90.54%   90.53%   -0.02%
==========================================
  Files         112      112
  Lines       29085    29085
  Branches     2077     2077
==========================================
- Hits        26335    26332       -3
- Misses       2715     2718       +3
  Partials       35       35

Components
Coverage Δ

agent
78.83% <ø> (ø)

api
97.73% <ø> (-0.16%)
:arrow_down:

common
98.68% <ø> (ø)

credentials
94.95% <ø> (ø)

crypto
93.81% <ø> (ø)

dids
97.65% <ø> (ø)

identity-agent
96.70% <ø> (ø)

crypto-aws-kms
100.00% <ø> (ø)

proxy-agent
96.70% <ø> (ø)

user-agent
96.70% <ø> (ø)


EtherCIS Events need hooking up by Rob Tweed

@robtweed - please could you provide an update on this, cheers.

Talked to Ian on Friday who will be discussing in more detail with Tony, as it's still not clear how this will need to work, in particular with respect to the current use of Appointments for triggering the WebRTC telemedicine - and it should be noted that those Appointment postings only currently work against Marand

Have spoken to @freshehr  who is getting on with fairly simple solution to this. should be ready to go asap

Heading
Events
Version:
1.0.0
1.0.1
added event Time to AQL and composition sample
05-Jun-2017
TemplateID:
IDCR - Service tracker.v0
Summary AQL /query:
To populate the list of items when the heading is selected.
select
    a/uid/value as uid,
    a/composer/name as author,
    a/context/start_time/value as date_created,
    b_a/description[at0001]/items[at0011]/value/value as eventName,
    b_a/description[at0001]/items[at0014]/value/value as eventType,
    b_a/description[at0001]/items[at0013]/value/value as eventDescription,
    b_a/time as eventTime
from EHR e
contains COMPOSITION a[openEHR-EHR-COMPOSITION.service_tracker.v0]
contains ACTION b_a[openEHR-EHR-ACTION.service.v0]
where a/name/value='Service tracker'

Detail AQL /query:
To populate the detailed view / edit when a single record within the heading is selected.
As above

Sample Composition(FLAT JSON) for POST/PUT /composition:
To create or update a composition for a single item via the /composition Ehrscape API call.
{
    "ctx/language": "en",
    "ctx/territory": "GB",
    "ctx/composer_name": "Dr Rory Best",
    "ctx/time": "2017-06-05T10:50:20.958Z",
    "ctx/id_namespace": "Ripple",
    "ctx/id_scheme": "Ripple",
    "ctx/health_care_facility|name": "Ripple General",
    "ctx/health_care_facility|id": "9091",
    "service_tracker/service:0/ism_transition/current_state|code": "526",
    "service_tracker/service:0/ism_transition/current_state|value": "planned",
    "service_tracker/service:0/service_name": "Event_name",
    "service_tracker/service:0/service_type": "Event_type",
    "service_tracker/service:0/description": "Notes",
    "service_tracker/service:0/time":"2017-06-05T10:50:20.958Z"
}

Notes:
{
    //Boilerplate
    "ctx/language": "en",
    //Boilerplate
    "ctx/territory": "GB",
    //author name
    "ctx/composer_name": "Dr Rory Best",
    //document commit time
    "ctx/time": "2017-06-05T10:50:20.958Z",
    //Boilerplate
    "ctx/id_namespace": "Ripple",
    //Boilerplate
    "ctx/id_scheme": "Ripple",
    //Boilerplate
    "ctx/health_care_facility|name": "Ripple General",
    //Boilerplate
    "ctx/health_care_facility|id": "9091",
    //Boilerplate
    "service_tracker/service:0/ism_transition/current_state|code": "526",
    //Boilerplate
    "service_tracker/service:0/ism_transition/current_state|value": "planned",
    //Event name
    "service_tracker/service:0/service_name": "Event_name",
    //Event type
    "service_tracker/service:0/service_type": "Event_type",
    //Notes
    "service_tracker/service:0/description": "Notes",
    //Event time
    "service_tracker/service:0/time":"2017-06-05T10:50:20.958Z"
}

thanks @freshehr
Again just keen to ensure these work before closing them off
@robtweed can you update here when this is working please?
thanks

As far as I know this is working and can be closed off


Update branding to 3.1.16

@NTaylorMullen the Building_Project test in consistently failing on Linux - could you take a look? We need to get this in as soon as possible so the branches can open

@wtgodbe looks like the tests are in the SDK variants of the tests. I unfortunately wouldn't be a lot of help because of that 😢. @pranavkm or @captainsafia may have a better idea though!

ping @pranavkm @captainsafia

Sorry I missed this. What was the issue here?

Sorry I missed this. What was the issue here?

There wasn't one. Just timeouts when communicating with the Razor compiler server in the tests. Rekicking the tests a bit did the trick.


Version added, mod not found.

So, very new to solder and I spent a while learning the file structure. I'm 90% sure I've got everything right. So I go add a version for Ars Magica 2 just to test it out, and it works great up until the point of me testing the download link. I get "Mod not found" yet a file size is shown and a hash is generated. I'm assuming the download link is generated wrong? I've also tested with another mod and it does not work for that one either. https://gyazo.com/ae7617537e4ec21044bd54f113cc21e4
https://gyazo.com/b8886163b63367ef3aa68025b9322190

Did you set the repo_location and mirror_url properly in the app/config/solder.php file? If yes, please try to set the right permissions with: chmod -R 777 /var/www/html/TechnicSolder (or your path). Maybe this helps!


DRILL-6094: Created tests for decimal type enhancements

<EMAIL_ADDRESS>could you review the PR from Denys?

Also, pre-commit automation run failed:
Execution Failures:
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CaseIfEmptyStrThenNull.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CastLiteralsAsDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CaseIfEmptyStrThenNullAsDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/binaryDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_avro/other_types.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CastStringToDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/roundDecimals.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_avro/decimal_9_0_fixed.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_avro/decimal_9_0_bytes.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/drill3938.q
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CaseEmptyStringCastStringAsDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols3.q
Data Verification Failures:
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/modify_types1.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols2.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols5.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols6.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols4.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols1.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/modify_types2.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/seq_modify_types1.q
Timeouts:
/root/drillAutomation/framework-custom/framework/resources/Functional/flatten_operators/general/jira1679.q
/root/drillAutomation/framework-custom/framework/resources/Functional/json/json_kvgenflatten/combo/kvgenflattenbug_DRILL-1766.q

ITERATION SUMMARY
Total Tests                  : 10107
Passing Tests                : 10085
Failing Tests                : 22

Execution Failures         : 12
Data Verification Failures : 8
Plan Verification Failures : 0
Timeout Failures           : 2

Iteration 1 (of 1) duration: 50.54 min

@cchang738 Test plan was reviewed by developers and QA. I created different task to add some test cases dealing with larger dataset and it will be another PR.
Could you please review this PR now? I renamed titles in JSON files and removed tests that changing system params.

@denysord88 Thanks for making the change. But I still see many test failures. Have you addressed these failures? Many seem related to decimal.
Execution Failures:
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_avro/decimal_9_0_fixed.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CaseIfEmptyStrThenNullAsDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CastStringToDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/drill3938.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols3.q
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CastLiteralsAsDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/roundDecimals.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_avro/decimal_9_0_bytes.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/binaryDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CaseEmptyStringCastStringAsDecimal.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_parquet/CaseIfEmptyStrThenNull.sql
/root/drillAutomation/framework-custom/framework/resources/Functional/decimal_avro/other_types.sql
Data Verification Failures:
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols4.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/seq_modify_types1.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/modify_types1.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols1.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols5.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/modify_types2.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols2.q
/root/drillAutomation/framework-custom/framework/resources/Functional/hive/hive_storage/change_metadata/par_add_cols6.q
Plan Verification Failures:
/root/drillAutomation/framework-custom/framework/resources/Functional/ctas/ctas_auto_partition/general/plan/drill4449.q
Timeouts:
/root/drillAutomation/framework-custom/framework/resources/Functional/json/json_kvgenflatten/combo/kvgenflattenbug_DRILL-1766.q
/root/drillAutomation/framework-custom/framework/resources/Functional/flatten_operators/general/jira1679.q

I removed ALTER SYSTEM SET command from ddl file.
Also I replaced in queries internal casting empty strings as NULL to the CASE statement.
Test fails in folder Functional/hive/hive_storage/change_metadata/ are failing now at the master of drill-test-framework and will be fixed in another jira.
@cchang738 Could you review this PR with my updated commit please?

@denysord88 Thanks for making the changes. We have a policy that no PR can be merged with failures. So we need to have a clear run for this PR. Are the failed tests in anyway related to your PR?

@cchang738 If you have failed tests only in folder "Functional/hive/hive_storage/change_metadata/", then this PR is correct. That hive tests are failing because they don't support Hive 2.1 and they don't relates to my PR with Decimals.

Trying to run all Functional tests on test cluster to find conflicts of decimal tests with others.

I updated last commit, added secure drill URL with password to gen script framework/resources/Datasources/ctas/decimal/create_decimals_test_data.sh
@cchang738 could you please review this pull request?

@denysord88 Were you able to run pre-commit functional automation? Please provide your test result for review. Thanks.

@cchang738 CV QA test cluster is not fully configured yet. So I can't run pre-commit functional automation tests. I run only tests on my suite and they passed.  I used folder "/drill/testdata/ctas/parquet" in hadoop fs, but in another script "Datasources/ctas/create_tables.sh" this folder deleting and then creating again. That script delets all my csv files.
I changed folder of my CSV files for CTAS.
@cchang738 Could you please run again pre-commit functional tests? On our CV Test cluster we don't get errors with decimals now.

Pre-commit test runs now. There are some test failures, but does not look like related to this PR.
+1


leaderelection: make election client verbose

This makes the leader election client-go client super verbose (printing DNS timing, connection errors, etc.).
In practical life, the leader election client ought to be the first client to indicate a networking problem in the cluster (it is unable to get the config map), so having extra debugging information in logs to investigate the client error is helpful.

proof: https://github.com/openshift/cluster-kube-controller-manager-operator/pull/696


GEODE-10354: Convert enum like classes to enum.

For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

this PR appears to be abandoned, can it be closed?

I did a quick test, and it looks like this is a breaking change to the serialization format of this class. I think that's why we haven't made this conversion up to this point:
Caused by: java.io.InvalidClassException: cannot bind non-enum descriptor to an enum class
	at java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:687)
	at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1885)
	at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1751)
	at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2042)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1573)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431)
	at org.apache.geode.internal.InternalDataSerializer.readSerializable(InternalDataSerializer.java:2720)

Which test?

@pivotal-jbarrett - Here's a test you can play with, based on this PR - https://github.com/upthewaterspout/geode/pull/new/feature/test-compatibility-of-enum-DataPolicy

@upthewaterspout, this brings up an excellent question. Does the use of the Serializable interface outside of the direct API, which does not utilize it, constitute part of the binary compatibility contract for a public class. Our API or internals do not transmit the classes in question as serializables but the test framework does. As a result of having the Serializable interface on the class are we stuck making sure that external use of this class maintains serialization compatibility?
If the answer to this is yes, then it will likely put a damper on future mutation of types that either directly or indirectly, like enum, implement Serializable. There are many issues with versioning Serializable classes that may force us to consider @Deprecated annotations on these sorts of types and making new types to replace them anytime we want to mutate them.
If the answer is no, then how should we communicate this to users? We could define a @NotSerializable annotation and Javadoc tag to hopefully inform the user not to use it in serialization. We could implement the write/readObject methods and throw exceptions to prevent it at runtime.

Closing this out until the open questions are resolved.


[gui] Change PyQt preference order

This PR tries to load PyQt5 first, then PyQt4, PySide and PySide2.
Doc is updated accordingly to acknowledge pitfalls with IPython.
sx module is also updated to perform imports as %pylab but to avoid the initialization of Qt by IPython.

closes #1035

LGTM


Please add Wonderboom Nature Reserve

Please add Wonderboom Nature Reserve hiking trail in Gauteng.

You can go ahead, assigning it to you. Thanks!

Awesome thank you @runningdeveloper


Developing docs for developing/contributing to sphinx using sphinx-stack

Adding a contribution to sphinx docs will need to update a bit more to make it a bit more clearer
I'm using this issue to help make this doc
https://github.com/stakwork/sphinx-stack/issues/24

Going to merge since its just readme files


Implement intrusive ptr

Previously the PR is hosted on dmlc-core.  Let's merge it here for XGBoost first so we can get better perf for next release with JSON now being the default serialization format.
@hcho3

Codecov Report

Merging #6129 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6129   +/-   ##
=======================================
  Coverage   78.52%   78.52%
=======================================
  Files          12       12
  Lines        3069     3069
=======================================
  Hits         2410     2410
  Misses        659      659

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e955fb...095b517. Read the comment docs.

@trivialfis Do you have some benchmark results?

The model is trained with covtype dataset, generated 21000 trees in total with
max_depth set to 6.  The size of saved JSON file is about 96.1MB.

Load
Save

Before adding categorical data support
4.2141406536102295
3.429635524749756

Master
4.652015209197998
3.8093554973602295

With new categorical split format
4.365228891372681
3.491779327392578

With intrusive ptr
2.460336446762085
2.5140161514282227


Safari and IOS fix for reply.css

before these changes, there was a bug for Safari and IOS that you cannot see the reply bubble.
Simply commenting animation duration and opacity properties solved to problem.
Looking forward to finding a more convenient solution.

I've been battling this bug for a while, seems to be Safari-only issue. Does your solution affect the actual animation? If everything works as before and bubbles do not disappear I'd love to merge it (sorry, didn't have the time to test it yet).

I am trying a test with other devices. When I am finished I will let you know with some gifs


Do not allow users to edit other registered users.

We do not want to allow a user to edit another registered user.  Editing of non-registered Person nodes is allowed.

This is in 0685347f6541156cec07300d506552f5bfa48e2c


[firebase_auth] firebase_auth should be supported on Flutter for Web

We should implement firebase_auth for the web

I'm waiting phone auth with flutter web!


Add Links to Repo/Homepage to Cargo.toml

I saw https://crates.io/crates/rustless but it tool me a while to find this repo.
I set the homepage to the repo URL as well, since http://rustless.org/ does not work for me right now.

There were the following issues with your Pull Request

Commit: 2c98d664d9879e9d12df7508095f1ef4d6a1563b
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/rustless/rustless/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

(fixed commit message)

Thanks!


[FEATURE] Add support for other dtypes to Image in schema

🚨🚨 Feature Request

[x] A new implementation (Improvement, Extension)

Is your feature request related to a problem?
Currently, users are only able to use Image in schema with dtypes "uint8" and "uint16". Using other integer and float types raises an error.
If your feature will improve HUB
More freedom for users to use different dtypes in Image.
Description of the possible solution
Modify hub.schema.Image to permit other integer and float dtypes.
Also, add a check that ensures that in case the compressor is "png" and dtype other than "uint8" and "uint16" is specified, raise an error. Similarly, if the compressor is "jpeg" and a dtype other than "uint8" is specified, raise an error. The errors should be raised during the constructor call i.e. when _init_ is called.
Teachability, Documentation, Adoption, Migration Strategy
After the fix, this code should work:-
schema_1 = {
    "image" : hub.schema.Image((500, 500, 3), "float64")
}

while this should raise an error
schema_2 = {
    "image" : hub.schema.Image((500, 500, 3), "float32", compressor="png")
}

For those interested, here is the relevant loc.

Hi,
I would like to know about all the expected tdypes to be included  and any other checks needed for any other format other than the two checks mentioned (for png and jpeg)

Hey @madhucharan! All variations of int and float need to be supported. Only the 2 checks for png and jpeg need to be considered for now. Let me know if you're starting on this and I'll assign it to you 🙂

Yeah, I am interested in working on this and one more question - the checks are to be added as tests in the test file or as new functions within the same image class.

Great! Assigning you now. The checks will be in the same file and need to be called on the initialization of this class. Separate unit tests would need to be created to test out whether the class is working as intended.

Ok, Got it. will update accordingly.

@madhucharan as mentioned by @AbhinavTuli, focus on updating the function first.
I will write the unit tests, which your updated function will need to pass - even I know you just had 10 days of exams ;)

Closing due to inactivity.


mount/xfs detect duplicate uuid case and warn about it

If we create an xfs filesystem with an uuid that exists on the host system, the subsequent mount will fail in the org.osbuild.mount.xfs mount, but with the very generic and not helpful message:
mount: wrong fs type, bad option, bad superblock on /dev/<dev>,
       missing codepage or helper program, or other error

We could check if the uuid of the filesystem we are trying to mount exists on the host and if so, warn about this.

The file to work on is called org.osbuild.xfs now.


Introduce LinterSettings and ResolverSettings

Summary

Test Plan

Current dependencies on/for this PR:

main

PR #7532

PR #7542

PR #7543   👈

PR #7536

This comment was auto-generated by Graphite.


Update Project Name in the actual project

Since we are using the name Atlas here, i wanted it to be consistent across the project so there wasn't any confusion. I've done the following:

Updated any reference from EfYou to Atlas
Removed the archive file. We are going whole hog on this one, and as such we need to be lean and mean.

Whoops, GitHub directed me wrong here, so let's ignore this.


Enable flake8 linter in gates

Signed-off-by: gaugup<EMAIL_ADDRESS>

Thank you for fixing the flake8 tests @gaugup
I still see some more errors in the flake8 run above, that we'll need to work on.

Thank you for fixing the flake8 tests @gaugup
I still see some more errors in the flake8 run above, that we'll need to work on.

I will take a couple of more days to finish the remaining errors. I hope no PRs are merged in this time.

Thank you for fixing the flake8 tests @gaugup
I still see some more errors in the flake8 run above, that we'll need to work on.

I will take a couple of more days to finish the remaining errors. I hope no PRs are merged in this time.

@amit-sharma, I created a milestone https://github.com/interpretml/DiCE/milestone/1 so that we can reduce the cyclometric complexity (https://www.geeksforgeeks.org/cyclomatic-complexity/) of certain methods within DiCE library. This can be done by refactoring certain code in these methods and the work for this milestone is outside the scope of this PR. For now I will set --max-complexity as 30 to avoid the cyclometric complexity to fail the flake8 gate.


updated sogouinput (<IP_ADDRESS>9)

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

Would you mind rebasing and changing version to ':latest' and shasum to ':no_check'

The developer of the app, invited by me, has submitted a PR and merged. They made a special download url for cask. So this can be closed.


Fix tenant Id design for Azure accounts

This PR shall fix #20701 #20517 and many more similar issues where tenant IDs are not respected.
Current implementation contained a logic to fetch home tenant, which would look into all tenants and find the first 'Home' tenant. It is entirely possible that an Azure account contains multiple 'Home' tenants (as it is in my account), so this implementation was incorrect.
Consequences and what changed:

Wrong tenant identified can lead to different account Id being fetched when refreshing token. This is why when reopening ADS, we would see multiple account entries in Azure Tree for same Corp account generally observed by users also have a personal AD. https://github.com/microsoft/azuredatastudio/issues/20701#issuecomment-1301483198

Fixing the implementation to fetch the tenant Id from token claims that owns the AD account seems to fix the issue, as an Azure Account will always belong to this tenant.

#20517 is also seemingly fixed when testing, we're able to see when clicking the 'Connect' icon near server/db names, correct tenant shows up relative to where Server/DB belongs to (mainly impacts multi-tenant user accounts), this was always defaulting to the same first Home tenant as saved previously.,

I'm still trying to gather valid reasoning to explain how it gets fixed but would like to open PR for getting feedback from others and if they can help validate the changes too.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 41.968%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/account-provider/auths/azureAuth.ts
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
28918

Relevant Lines:
64019

💛  - Coveralls


Updates git describe towork with Github Actions

Signed-off-by: Michal Karm Babacek<EMAIL_ADDRESS>

Test results are expected until we fix API for spec selection.
@Emily-Jiang  @rdebusscher
I am merging this last GitHub Actions fix.   From now on, we have a clear test on each PR and no PR shall be merged if it contains unexpected/unexplained failures.  (Note that Liberty is not in the list, because it is disabled altogether).
Circle CI will be used  for releases to test-start.microprofile.io/ as it contains secrets for accessing the AWS machine.
Pull requests are to be tested with GitHub Actions...
:partying_face: :fireworks:  :champagne:


Concentrated Liquidity: fix computeSwapStep and add test case with two positions

Closes: #3196
What is the purpose of the change
This PR is the attempt to fix computeSwapStep to use correct method of calculation, and add a test for a case with two positions.
Currently the tests are failing (inclduing the calcOutAmtGivenIn for a single position that was existing before) investigateing into this

Her, I think the rebase of the base branch messed up the diffs between concentrated-liquidity-main branch and this branch. Would create a new PR instead tmrw


Should Referent Subclasses Be Equal To Their Original Class?

We've encountered a situation where we're using an object's class as a WeakHashMap key. Further down the line, this object's class is changed when a weak reference is created. This means that we cannot look up the original object by the new class, as it has changed.
Would it be sensible to create an IOSClass's isEquals method to return true in this case?
        Object object = new Object();
        // Object's class in objc is now NSObject

        new WeakReference(object);
        // Object's class in objc is now changed to NSObject_ReferentSubclass

        assert object.getClass().equals(Object.class); // Fails - should this succeed?

Yes, your isEquals suggestion seems best.

Fixed in 0.9.6.


feat: expose gitops operator metrics to openshift-monitoring stack

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Note: this PR has a dependency on https://github.com/redhat-developer/gitops-operator/pull/556
This PR contains all the changes required to make gitops-operator metrics accessible through the openshift-monitoring stack and viewable within the Openshift console. The included changes are as follows:

Change gitops-operator's default namespace to openshift-gitops-operator and enable cluster monitoring out of the box
Add kube-rbac-proxy container to the operator deployment to protect the operator's /metrics endpoint
Add the following manifests to the bundle to allow openshift-monitoring stack to pick up the metrics:

metrics service
service monitor
role and rolebinding to allow openshift-monitoring to access operator's metrics endpoint

Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

Build an operator containing these manifest changes
install the operator on a cluster
go the admin > observe > metrics tab of the console
confirm you are able to query active_argocd_instances_total and see the graph for it

/lgtm
/approve

/retest

/retest

/retest


Remove obsolete options APIs

From @natemcmaster on Monday, July 3, 2017 11:56:58 AM
Follow-up to https://github.com/aspnet/Antiforgery/pull/148
Remove the following obsoleted APIs
AntiforgeryOptions
  .CookieName
  .CookieDomain
  .CookiePath
  .RequireSsl

Copied from original issue: aspnet/Antiforgery#149

IMPORTANT: there are many other places where options are exposed which essentially need to be also removed.

Fixed as part of https://github.com/aspnet/AspNetCore/pull/7459


Add optional_subdirs variable support

When building a subset of a source tree, some of the subdirectories
mentioned in the subdirs variable may be missing.  Add support for an
optional_subdirs variable, which won't error out if the requested
directory is missing.

LGTM


GH-439 Make HttpMethod#all static

#439

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oh, that's quite funny, because it looks like HttpMethod stores everything that have been requested:
    @Test
    void weirdVerbs() {
        Unirest.request("CHEESE", MockServer.CHEESE)
                .asObject(RequestCapture.class)
                .getBody()
                .assertMethod(HttpMethod.valueOf("CHEESE"))
                .assertBody("");
    }

Results later in:
Error:
HttpMethodTest.shouldReturnAllMethods:51
expected: <[PATCH, GET, OPTIONS, DELETE, POST, PUT, TRACE, HEAD]>
  but was: <[PATCH, CHEESE, GET, OPTIONS, DELETE, POST, PUT, TRACE, HEAD]>

It looks like custom methods are considered as a feature, so what do you think about extending HttpMethod with a property canonic/standard, so we can differ those methods? Or we can just remove this test if the registry it meant to keep non-standard values for the whole jvm instance.

I'd just change the test to:
assertEquals(HttpMethod.GET.all(), HttpMethod.all());


Replace Support lib with AndroidX

Summary
Breaking change, upgrades the package to use AndroidX instead of the Support library.
Not sure if this is that important at the moment, as it's easy enough to use jetifier to make the same change, but seeing as this has been newly extracted and deprecated for RN 0.60.0 it seems likely that most users of this package would be on RN 0.60.0 or above, so don't need android support library compatibility.
Test Plan
Install package in a new RN 0.60.0 app (without jetify set up)
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
✅

Android
✅

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Hi, @mjmasn
Thanks for your PR, I would love to merge your PR, but before that, could you please fix the CI problem for me?  😄

@nicholaslee119 I had a quick look but I think made it worse 😱 I will be able to have a proper look later in the week 👍

@mjmasn Any updates? Currently stuck on this

@jordykoppen what are you stuck on? The existing release should work fine with RN 60+ (we're using it in production) because Jetifier will work its magic. Maybe you don't have Jetifier working for some reason?

@mjmasn Possibly but this is the only lib it fails on... Can you maybe take a look at this repo and see if there's anything out of the ordinary with jettifier? Not super familiar with it.

@jordykoppen it should just run automatically via react-native cli, when you run react-native run-android do you get something like this?
info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
Jetifier found 2652 file(s) to forward-jetify. Using 8 workers...
info JS server already running.
info Installing the app...
If you're still having trouble, best thing to do would be creating a fresh RN app, adding this package, then checking if it works. If even that doesn't work, stick that new app on Github and submit a new issue here with the reproduction steps.
Unfortunately I don't really have time at the moment to look at the AndroidX migration, so if anyone else wants to take it on please feel free.

https://github.com/react-native-community/react-native-checkbox/pull/36#issuecomment-569559224
this PR was merged in above PR and release in 0.3.0


movies.json, MovieModel.cs and MovieAccess.cs implemented

With the "templates" from Account files.

OK.


Chef::Config[:file_cache_path] mixed path style

Description
When accessing the variable class Chef::Config[:file_cache_path] on windows the path returned is not completely windows like. This could be tricky when passing paths to legacy commands.
I would like to have an uniform path style that for windows is the legacy one.
Chef Version
12.9.41
Platform Version
tested on windows 8.1, same for others.
Replication Case
open chef-shell  and in recipe_mode  write Chef::Config[:file_cache_path]
Client Output
"C:/Users/myuser\\.chef\\cache"

Repro'd on Windows 10 and Chef 14.3.42
repro.rb
log Chef::Config[:file_cache_path]

C:\projects\chef\chef [master ≡]> bundle exec chef-client -z repro.rb
[2018-07-13T23:01:08+01:00] WARN: No config file found or specified on command line, using command line options.
[2018-07-13T23:01:08+01:00] WARN: No cookbooks directory found at or above current directory.  Assuming C:/projects/chef/chef.
[2018-07-13T23:01:08+01:00] WARN: No cookbooks directory found at or above current directory.  Assuming C:/projects/chef/chef.
Starting Chef Client, version 14.3.42
resolving cookbooks for run list: []
Synchronizing Cookbooks:
Installing Cookbook Gems:
Compiling Cookbooks...
Converging 1 resources
Recipe: @recipe_files::C:/projects/chef/chef/repro.rb
  * log[C:/Users/spreston\.chef\local-mode-cache\cache] action write


Add documentation about how the image stabilization and prediction time stamp work

Added in wiki:
https://github.com/3DStreamingToolkit/3DStreamingToolkit/wiki/DirectX-HoloLens-Client

Where is the wiki?

Where is the wiki?

I am guessing it moved here: https://3dstreamingtoolkit.github.io/docs-3dstk/Clients/directx-hololens-client.html


[Bug] the selected card on load functionality does not always have a card selected by default

Description

When you run the project, a card is selected by default. There is a usecase where no card is selected when the page loads.
This is caused by the fact that the card is randomly selected on load. The functionality for generating the randomly selected card uses the length of the engines to get a number as shown below:
engine = engines[Math.floor(Math.random() * engines.length)];
Since js arrays are zero indexed, the number generated from the function above will be in the range [0 - 10] which is 11 search engines instead of [0 - 9] which is 10 search engines.This will provide a usecase where no card is selected on page load because the randomly generated numer is 10 but there are only 0 - 9 search engines
Reproduction

Run the project locally
Reload the project till you find a usecase with no selected card
See error.

Expectation

On every reload, a card should always be selected.
Screenshots

Here is the usecase with no card selected.

Resolution

[ ] I would be interested in resolving this bug.

I think this is working now, I have tried it and it selects a card

@adetyaz it still does not always select a card. I can still find the usecase where no card is selected.
I have also pulled from upstream to make sure I have the updated code but I still see the bug.
Since the numbers are randomly generated, try reloading multiple times

I'll do that and get back to you on it. @JennySimen

Yes its true, I just experienced it now @JennySimen, after reloading about 5 times.
Can I take a stab at it?

@adetyaz currently, the ticket still has to be evaluated. If the status changes to ready for work, you can ask @possumbilities to assign the ticket to you

Alright thank you.

@possumbilities please I need help, any changes I make to the search.js file doesn't reflect. I have also tried a console.log and alert yet no indication that there has been any changes on the file.

@adetyaz  Hi! I'm sorry you're having trouble, when working locally it is likely that your local cache is not clearing when you change the file. You'll have to clear your browser cache after changing the file to make sure the changes are reflected correctly.

Alright, I'll do that  and get back on it. thanks @possumbilities.
Side note: when I make changes to text on the interface it changes

@possumbilities, I still experience the same thing, after clearing the cache and using a new browser

@adetyaz Then, I'd suggest you try the CC Community Slack and ask there, to see if anyone else has had a similar issue, and how they resolved it.

Alright thank you

@adetyaz do you have any errors on your console?
You can tag me on slack so as well so we debug together

@JennySimen yes I have a couple of them

@JennySimen yes I have a couple of them

Get to me on to get more insight

@JennySimen yes I have a couple of them

Get to me on to get more insight

@ImaJin14 we already solved found the source of the bugs and fixed it. You can check the conversation  on slack

@adetyaz The PR of #150 fixes this as well.
Just a heads up

oh okies, seen it. thanks

@possumbilities since there has been no fix for this issue yet can i go on to provide a fix for this or #108 fixes this as well.


Respect user defined bounds if defined

Requested by @subtleGradient:
Regardless of transparency,
crop assets based on the following…
it = The Layer whose Bounds you're trying to figure out.
If it is a layerSet (group) and has a child whose name is "@bounds", determine the bounds based on the "@bounds" layer instead.
If it has a vector mask, use those bounds, regardless of transparency.
If it has a bitmap mask, trim away all 100% transparent mask pixels, ignoring all other channels.
If it is a layerSet (group) and has no masks, combine the bounds of all visible descendant shape layers (regardless of the transparency of their rasterized pixels) plus all visible pixels.

+1 for @bounds layer. It would be very useful for all kind of exports (png, jpg, svg)


Added Scribus (dev version) 1.5.7

Relates to https://github.com/ScoopInstaller/Extras/issues/7496

If this is a development release, raise this PR in Versions bucket. Otherwise if it's stable, modify the existing scribus.json manifest.

@rashil2000 Done!


Some language_2 tests doesn't reflect the Dart 2 semantics for noSuchMethod forwarders

The tests in question are the following:

language_2/super_operator_index6_test
language_2/super_operator_index7_test
language_2/super_operator_index8_test

They should be rewritten under the assumptions that abstract classes don't get noSuchMethod forwarders and that noSuchMethod forwarders aren't mixed in from the mixins.

Thanks for noticing.

@lrhn I think there's one more, but I'm not completely sure about this one:

language_2/super_no_such_method4_test

Marking it with this issue number in the status files for now.

The test language_2/super_no_such_method4_test.dart gets complaints about a superinvocation (that there is no super.foo) and that's correct (given that nSM forwarders are not provided by with A). So the most informative fix might be to make that test a multi-test and mark line as foo() => super.foo(); //# 0: compile-time error.
The spec has (section 'Super Invocation'):
Let $S_{static}$ be the superclass of the immediately enclosing class.
It is a static type warning if $S_{static}$ does not have an accessible (\ref{privacy})
instance member named $m$.

In the context of Dart 2, 'static type warning' has consistently been considered to mean 'compile-time error'. It is currently marked as a hint by the analyzer, so we may need to worry about breakage, but following the spec the way we otherwise read it now, it should be an error.

Agree on super_no_such_method4_test.
Both super_operator_index7_test and super_operator_index8_test are failing because the super-interface doesn't declare the operators, so that's a plain strong-mode error unrelated to noSuchMethod.
They should work if I add the operator signatures.


high-level: do not make assumption about array-element-type result

Code did assume, that array-element-type will return one particular
form of the data type. There is no guarantee in the spec, that this
will be the case, so instead of calling equal on results we compare
them by means of subtypep (and etypecase).

With this pull request magicl succesfully builds and passes tests with ECL (from feature-float-complex branch).
(#<test-run of MAGICL-TESTS: 7 tests, 268 assertions, 0 failures in 6.13 sec>)
That being said build process is very long due to cffi-lapack and requires ~16GB RAM with declaimed optimization settings (GCC is fed with 1.5MLOC of transpiled code). If debug is clamped to 0, speed to 3 and safety to 1 build is little faster and requires ~8GB RAM. I'm thinking about more direct approach (cffi adds a lot of intermediate clutter from ECL perspective). There is also ASDF issue (it always decides, that magicl needs to be recompiled for some reason instead of taking fasl from the cache). I'm going to work on a fix soon.

@dkochmanski I would be absolutely open to discussions about how we might be able to refactor the generation of the code, even if it's ECL-specific. All of that logic is here. I think we ought to also break apart the compilation units. Even for SBCL/CCL, it takes forever to compile. It might be worth breaking these things up and limiting the number of forms produced per file.
Quick fixes are welcome in this PR, but maybe this ought to be thought about more deeply in another issue/PR.

I'll leave it here for now, because I didn't start working out details yet (I'll use example code):
This
(CFFI:DEFCFUN ("cladiv_" %%CLADIV :LIBRARY MAGICL.FOREIGN-LIBRARIES:LIBLAPACK)
    MAGICL.CFFI-TYPES:COMPLEX-SINGLE-FLOAT
  (X :POINTER)
  (Y :POINTER))

(COMMON-LISP:DEFUN %CLADIV (X Y)
  (COMMON-LISP:DECLARE (COMMON-LISP:INLINE %%CLADIV)
                       (COMMON-LISP:TYPE
                        (COMMON-LISP:COMPLEX COMMON-LISP:SINGLE-FLOAT) X)
                       (COMMON-LISP:TYPE
                        (COMMON-LISP:COMPLEX COMMON-LISP:SINGLE-FLOAT) Y))
  (CFFI:WITH-FOREIGN-OBJECTS ((X-REF3898
                               'MAGICL.CFFI-TYPES:COMPLEX-SINGLE-FLOAT)
                              (Y-REF3899
                               'MAGICL.CFFI-TYPES:COMPLEX-SINGLE-FLOAT))
    (CFFI:WITH-FOREIGN-SLOTS ((COMMON-LISP:REAL MAGICL.CFFI-TYPES::IMAG)
                              X-REF3898 MAGICL.CFFI-TYPES:COMPLEX-SINGLE-FLOAT)
      (COMMON-LISP:SETF COMMON-LISP:REAL (COMMON-LISP:REALPART X)
                        MAGICL.CFFI-TYPES::IMAG (COMMON-LISP:IMAGPART X)))
    (CFFI:WITH-FOREIGN-SLOTS ((COMMON-LISP:REAL MAGICL.CFFI-TYPES::IMAG)
                              Y-REF3899 MAGICL.CFFI-TYPES:COMPLEX-SINGLE-FLOAT)
      (COMMON-LISP:SETF COMMON-LISP:REAL (COMMON-LISP:REALPART Y)
                        MAGICL.CFFI-TYPES::IMAG (COMMON-LISP:IMAGPART Y)))
    (MAGICL.CFFI-TYPES:WITH-ARRAY-POINTERS COMMON-LISP:NIL
      (%%CLADIV X-REF3898 Y-REF3899))))

could be written as this (mind my remarks about safety settings from the email a few weeks back):
  (ffi:clines "extern _Complex float cladiv_(_Complex float*, _Complex float*);")
  (defun %%cladiv (cs1 cs2)
    (declare (type (complex single-float) cs1 cs2)
             (optimize (safety 0) (debug 0) (speed 3)))
    (ffi:c-inline (cs1 cs2) (:csfloat :csfloat) :csfloat
                  "cladiv_(&(#0), &(#1))"
                  :one-liner t
                  :side-effects nil))

what when disassembled yields the following code for the function:
/*      function definition for %%CLADIV                              */
/*      optimize speed 3, debug 0, space 0, safety 0                  */
static cl_object L1__cladiv(cl_object v1cs1, cl_object v2cs2)
{
 cl_object env0 = ECL_NIL;
 const cl_env_ptr cl_env_copy = ecl_process_env();
 cl_object value0;
 _Complex float v3cs1;
 _Complex float v4cs2;
 v3cs1 = ecl_csfloat(v1cs1);
 v4cs2 = ecl_csfloat(v2cs2);
TTL:
 value0 = ecl_make_csfloat(cladiv_(&(v3cs1), &(v4cs2)));
 cl_env_copy->nvalues = 1;
 return value0;
}

and with safety being 1 we have necessary type checks generated:
/*      function definition for %%CLADIV                              */
/*      optimize speed 0, debug 0, space 0, safety 1                  */
static cl_object L1__cladiv(cl_object v1cs1, cl_object v2cs2)
{
 cl_object T0;
 cl_object env0 = ECL_NIL;
 const cl_env_ptr cl_env_copy = ecl_process_env();
 cl_object value0;
 {
TTL:
  T0 = ecl_function_dispatch(cl_env_copy,VV[5])(1, v1cs1) /*  COMPLEX-SINGLE-FLOAT-P */;
  if (ecl_unlikely(!((T0)!=ECL_NIL)))
         FEwrong_type_argument(ECL_SYM("COMPLEX-SINGLE-FLOAT",1856),v1cs1);
  value0 = ECL_NIL;
  cl_env_copy->nvalues = 0;
  T0 = ecl_function_dispatch(cl_env_copy,VV[5])(1, v2cs2) /*  COMPLEX-SINGLE-FLOAT-P */;
  if (ecl_unlikely(!((T0)!=ECL_NIL)))
         FEwrong_type_argument(ECL_SYM("COMPLEX-SINGLE-FLOAT",1856),v2cs2);
  value0 = ECL_NIL;
  cl_env_copy->nvalues = 0;
  {
   _Complex float v3cs1;
   _Complex float v4cs2;
   v3cs1 = ecl_csfloat(v1cs1);
   v4cs2 = ecl_csfloat(v2cs2);
   value0 = ecl_make_csfloat(cladiv_(&(v3cs1), &(v4cs2)));
   cl_env_copy->nvalues = 1;
   return value0;
  }
 }
}

That's great!


Network Webcam Capability

There is a request to use the motion detection camera as a network webcam. It's possible to use another app for that now, but it would conflict with motion detection

Feature implemented for 0.6 in https://github.com/WallPanel-Project/wallpanel-android/commit/edb128a2fe45b107f5a9fc26bbecd6397888953d


Some examples with native file dialogs will not build on cross-compile Linux -> x86_64-pc-windows-gnu

Describe the bug

cargo build --target x86_64-pc-windows-gnu
   Compiling file_dialog v0.1.0 (/home/john/projects/egui/examples/file_dialog)
   Compiling save_plot v0.1.0 (/home/john/projects/egui/examples/save_plot)
error: linking with `x86_64-w64-mingw32-gcc` failed: exit status: 1

Full details:
egui_bad_linking.txt
This seems to be associated only with examples that use native file dialogs. The main egui library will work cross-compiled. This is just a problem with the build setup for some of the examples. So it's not critical once that's figured out.
To Reproduce
Steps to reproduce the behavior:

Run on Linux machine.
Set up Rust with target x86_64-pc-windows-gnu
Load egui crate from github
cargo build --target x86_64-pc-windows-gnu

Expected behavior

Successful build and link.
Desktop (please complete the following information):

OS:
Browser
Version

Smartphone (please complete the following information):

Device: x86-64
OS: Linux 22.04 LTS

Additional context

Discussion on Rust forums here: https://users.rust-lang.org/t/cross-compiling-crate-egui-linux-win-cant-find-core/105427/1

The native file dialogs is using rfd - have you tried cross-compiling the rfd examples? Perhaps the issue belongs in that repository?


switch to standard-json

Made standard-json today from some of the snazzy guts in order to make standard-tap
This PR replaces said guts with standard-json instead.

This is great! Released as 2.0.0.


Dependencies "rviz" on the package.xml

Hello everyone,
Why does the package.xml have 'rviz' listed as a dependency instead of 'rviz2' for the leuze_description?
https://github.com/thesensorpeople/leuze_rsl_ros2_drivers/blob/fa73630f31c5c445f7cb4a726ba7aafb864c0a96/leuze_description/package.xml#L32C1-L32C34
This applies to both exec_depend and test_depend
I asking because i get an Error:
the following packages/stacks could not have their rosdep keys resolved to system dependencies:
leuze_description: Cannor locate rosde definition for [rviz]
Regards,
Markus Joos

Hello Markus,
thank you for the issue description. I've managed to reproduce the problem on a fresh Ubuntu/ROS2 installation. The error appeared when running the "rosdep install --from-paths ...." command. It did not appear in my previous installation where I ended up having both rviz and rviz2 dependencies in one installation, because of some experiments I had been performing.
The bugfix is now available in the main branch (you have probably already fixed this locally by using rviz2 instead of rviz in the package.xml file).
Thanks a lot for finding this!
Kind regards
Milan


Feat/endpoints

Once @jsanchez254 fixes this warning, by either commenting the imports or removing them completely make sure to terminate #56

Close #56


Use appropriate digest algorithm during signature creation

Pass the public key instead of the marshalled public key to
digestAlgorithmForPublicKey in SignedData.AddSignerInfo.
Previously, the marshalled public key was passed instead of the actual
public key. The result is that always SHA256 was being selected, even
for ECDSA where the hash algorithm should be selected based on the curve.

Hi @lgarron
What can I do to move this forward?

I'm not qualified to review this, but @vcsjones may be!

I see:
https://github.com/github/smimesign/blob/e650daf6eaadf85c763fa06dcfb0e4d794d293dc/ietf-cms/protocol/protocol.go#L755-L766
Since we're passing in something that is not an ecdsa.PublicKey, none of the if checks match and it defaults to SHA256.
I think this change looks good, but it would be great to get some test coverage that indeed the right digest algorithm is used for the curve. Would you be able to add some test coverage for this, @oncilla?

@vcsjones sure. I will have look tomorrow


[Bug]: A PGVector store using a default retriever will not return nodes for large indices

Bug Description
Not sure if it's a bug as such, but a finding:

Database:

Postgres Vectorstore with PGVector (llama-index-vector-stores-postgres v0.3.2)
MongoDB for Docstore and Document Management (llama-index-storage-docstore-mongodb v0.3.0)

Model: gpt-4o-mini running on Azure
Embedding:  text-embedding-ada-002

Retriever:     retriever = vector_store_index.as_retriever(         similarity_top_k=config.node_limit, // Default is 5         filters=filters // Metadata filter, filters by ID     )
ChatEngine: CondensePlusContextChatEngine.from_defaults(...)
The Index contains about 360.000 entries, filtering occurs via metadata-filter and works on per-id basis (about 5 different ids right now).
Embeddings are created from markdown text, which is run through an ingestion pipeline.
Issue
During retrieval no nodes are found and LLM returns 'Empty Response'. This happens unless there is a very specific question asked, at which point the retrieval works as expected. Using the sql-query provided in llama-index but removing the limit of 5 solves the issue, but performance tanks because there is no limitation.
Solution
Our current implementation changes the config of PGVector by adding
SET hnsw.iterative_scan = strict_order;
This allows for iterative index scans, which allows the retriever to keep scanning the index until nodes are found or no nodes are left, and solves the issue of 'Empty response'.
I am unsure wether this is a bug, a misunderstanding on our part, or bad practice. If anyone else ran into this issue, any feedback is greatly appreciated :)
Also thanks for your constant work, team at Lllamaindex!
Version
0.12.3
Steps to Reproduce

Create Llamaindex implementation using Document Managent via MongoDB, and PGVector / Postgres for embeddings
Create a large set of embeddings using gpt-4o-mini and embedding  text-embedding-ada-002
Use top-k retriever
Create CondensePlusContextChatEngine
Query chatengine with general question about the dataset

This should result in EmptyResponses given, unless a more specific question is asked of the ChatEngine.
Relevant Logs/Tracbacks
No response

@dosu Our solutions seems to be not scalable. What approach would be more viable, assuming the index will grow to millions of entries?

@dosu as a first step, wouldn't it make more sense to split up the indices, so that all id's refer to their own, separate indices? The data will currently have no overlap.

@dosu How would you implement such a split of indices?

@dosu Assume we want to create an index for every customerId. The Document Management uses  postgres as vectorstore and mongodb as docstore.

@dosu How would you do it assuming an ingestion pipeline is used


API Reference docs have broken header links on crossplane.io

The auto-generated links to section headers in the API Reference docs use capitalization, which breaks when the markdown is converted to HTML. For instance, https://crossplane.io/docs/v0.7/api/crossplaneio/stack-gcp/database-gcp-crossplane-io-v1beta1.html#cloudsqlinstancespec works but https://crossplane.io/docs/v0.7/api/crossplaneio/stack-gcp/database-gcp-crossplane-io-v1beta1.html#CloudSQLInstanceSpec does not. We should either correct how the mardown translation happens in https://github.com/crossplaneio/crossplaneio.github.io or generate lowercase markdown links in https://github.com/negz/crossdocs

It's also really hard to browse even if the links worked. I wonder if we can have something like https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/

We no longer use generated docs so I am going to go ahead and close this :+1:


add gopher filter

This needs two functions as well:

A wrapper for datasets.map
A streaming dataset to jsonl

Regarding the word counts, I have added an issue to DaCy on adding DAGW word counts (pr. section and pos tag).


Missing correct return types on some CRMScript methods

Example of class missing correct return type: WeekSchedule.

Correct return type in this instance is TimeSpan
Others with similar issue can be found using same structure in files.

Closing this issue since it will be resolved by #9 (YAML format)


Start

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@Munasco  This failed to build, so it can't be pushed. Check the reason it failed fix it and commit those changes


ziti-edge-tunnel run ignores --verbose=N

Expected: only log messages at level INFO or lower
Observed: log messages from levels: ERROR, WARN, INFO, DEBUG, VERBOSE, TRACE
/opt/openziti/bin/ziti-edge-tunnel run --verbose=2 --dns-ip-range=<IP_ADDRESS>/12 --identity-dir=/opt/openziti/etc/identities

❯ apt show ziti-edge-tunnel
Package: ziti-edge-tunnel
Version: 0.20.5
Priority: optional
Section: devel
Maintainer<EMAIL_ADDRESS>Installed-Size: 5,707 kB
Depends: iproute2, sed, systemd, libatomic1, openssl
Download-Size: 2,385 kB
APT-Manual-Installed: yes
APT-Sources: https://packages.openziti.org/zitipax-openziti-deb-stable jammy/main amd64 Packages
Description: ziti-tunnel-sdk-c built using CMake

I found the list of log levels by parsing the output from ziti-edge-tunnel run from the systemd journal.
❯ journalctl -u ziti-edge-tunnel.service | awk '{print $8;}' | sort -u | grep -E '^[A-Z0-9]+$'
DEBUG
ERROR
INFO
TRACE
VERBOSE
WARN

you need to specify --verbose N

@scareything I get the same log levels when I replace the =-separated params with spaces. I get the same result with --verbose 4 as --verbose 2.
❯ sudo /opt/openziti/bin/ziti-edge-tunnel run --verbose 2 --dns-ip-range <IP_ADDRESS>/12 --identity-dir /opt/openziti/etc/identities 2>&1 | head -999 | awk '{print $3;}' | sort -u | grep -E '^[A-Z0-9]+$'
DEBUG
INFO
TRACE
VERBOSE
^C

Now I think I'm simply seeing a continuation of the same problem described in https://github.com/openziti/ziti-tunnel-sdk-c/issues/385 i.e. the precedence of the config.json file is higher than command line opt --verbose N. This means the tunneler always logs at whatever log level was specified the first time it ran when the config.json file was created.

I probably also ran into this issue and noted related behavior in the discussion here:
https://openziti.discourse.group/t/misc-notes-after-a-few-days-of-working-with-ziti/826/1

My new preferred workaround for the unexpected problem of the config file having a higher precedence than the command-line option and environment variables is to set the log level with an IPC command.
ziti-edge-tunnel set_log_level --loglevel TRACE


Redirection to a local host is not working properly

Are you requesting a feature or reporting a bug?
Bug
What is the current behavior?
After redirect to login page localhost an error is appeared
What is the expected behavior?
Acces a login page locallly
How would you reproduce the current behavior (if this is a bug)?
Actual Testcafe is configured "Control panel port: 1337 | Service port 1: 1338" and my application is allocated localhost too but in 3000 port (http://localhost:3000/login).
When I try to record some action via testcafe control panel, directing to my application, this error is shown:
Error: [$rootScope:inprog] $digest already in progress
http://error.angularjs.org/1.6.6/$rootScope/inprog?p0=%24digest
Error
columnNumber: 405
fileName: "http://localhost:1338/scripts/vendor.js?7929ba6d39aa4465=http%3A|localhost%3A3000|96b907a6-7776-4057-97fe-4fc8c34bf2b4|r|script"
lineNumber: 123
message: "[$rootScope:inprog] $digest already in progress\nhttp://errors.angularjs.org/1.6.6/$rootScope/inprog?p0=%24digest"
stack: "u/<@http://localhost:1338/scripts/vendor.js?7929ba6d39aa4465=http%3A|localhost%3A3000|96b907a6-7776-4057-97fe-4fc8c34bf2b4|r|script:123:405\nm@http://localhost:1338/scripts/vendor.js?7929ba6d39aa4465=http%3A|localhost%3A3000|96b907a6-7776-4057-97fe-4fc8c34bf2b4|r|script:171:70121\n$apply@http://localhost:1338/scripts/vendor.js?7929ba6d39aa4465=http%3A|localhost%3A3000|96b907a6-7776-4057-97fe-4fc8c34bf2b4|r|script:171:74412\ni/m<@http://localhost:1338/scripts/vendor.js?7929ba6d39aa4465=http%3A|localhost%3A3000|96b907a6-7776-4057-97fe-4fc8c34bf2b4|r|script:171:81858\nr@http://localhost:1338/scripts/vendor.js?7929ba6d39aa4465=http%3A|localhost%3A3000|96b907a6-7776-4057-97fe-4fc8c34bf2b4|r|script:171:19584\nvt/d.defer/n<@http://localhost:1338/scripts/vendor.js?7929ba6d39aa4465=http%3A|localhost%3A3000|96b907a6-7776-4057-97fe-4fc8c34bf2b4|r|script:171:21050\n"
I don't know if this error is because proxy or if is without some especific configuration on angular.
Provide the test code and the tested page URL (if applicable)
Tested page URL: http://localhost:3000/login

Specify your

operating system: Linux Ubuntu 5.4.0

testcafe version: v. 15.1.3

node.js version: v7.10.1

Hello,
We process all issues for TestCafe v15.1.3 via our Support Center. Please submit a ticket there, so that our support team will help you:
https://www.devexpress.com/Support/Center/Question/Create

Hello,
I opened a ticket via support center, follow ticket: https://www.devexpress.com/Support/Center/Question/Details/T588146/angular-application-in-testcafe-control-panel
Take a look @darlanmendonca


reverse connect feature

i love rclone and can't find older discussion when i'm create read-only http support.
May be i'm wrong... So as i remember you try to create some feature that allows one backend to export as another.
My use case - i want to export local fs like s3 endpoint.

i love rclone and can't find older discussion when i'm create read-only http support.
May be i'm wrong... So as i remember you try to create some feature that allows one backend to export as another.
My use case - i want to export local fs like s3 endpoint.

You can use rclone serve to export backends,
These are the most general purpose ones
ftp         Serve remote:path over FTP.
http        Serve the remote over HTTP.
webdav      Serve remote:path over webdav.
And those all have backends which can read them.

And If i want to programming way to serve local file dir via s3 api?
May be with custom hooks for auth and permissions?

Rclone doesn't serve s3 API yet :-(
You could use minio to serve a local directory with S3

i want something not like minio provides, i need to go library to represent each api like interface, so i can provide interface implementation by own code...
Do you think about something like that?

i want something not like minio provides, i need to go library to represent each api like interface, so i can provide interface implementation by own code...
Do you think about something like that?

So you would like to use rclone as a library?
It is possible to do this.  Here is a simple example
package main

import (
	"fmt"
	"log"

	_ "github.com/ncw/rclone/backend/drive"
	"github.com/ncw/rclone/fs"
)

func main() {
	f, err := fs.NewFs("drive:")
	if err != nil {
		log.Fatal(err)
	}
	entries, err := f.List("")
	if err != nil {
		log.Fatal(err)
	}
	fmt.Println(entries)
}

i want to use rclone as library, but not like client to some storage, but as like proxy for it. to external world rclone will provide for example s3 api, and internally for rclone and for each request to rclone external s3 api , my implementation of s3 rclone interface called.

i want to use rclone as library, but not like client to some storage, but as like proxy for it. to external world rclone will provide for example s3 api, and internally for rclone and for each request to rclone external s3 api , my implementation of s3 rclone interface called.

You can use rclone serve for this to serve an rclone backend in various standard forms - see rclone serve -h
You can also use rclone api.  Using rclone rcd --rc-serve runs a remote control server which gives access to all the remotes (docs for --rc-serve).
You can do pretty much anything rclone can do using the rc API.  It is a simple JSON based HTTP API.

ah ok, so i need to write for rclone serve s3 and swift protocols to able to do that i need.

Looks to be answered. Closing out.


List of Blocks from Sample Repositories shows blocks that are already deployed

If a community block is already deployed as an extension. It should be removed or disabled form the list.
This is to prevent deploying a block twice.

This requires to match two kind of metadata information:

blocks loaded in the streaming analytics engine
blocks retrieved from github repositories

The metadata for blocks from 1. are in the form:
{
    "consumesInput": true,
    "id": "apama.analyticsbuilder.blocks.PositionInput",
    "inputs": [],
    "parameters": [
        {
            "semanticType": "c8y_deviceOrGroupId",
            "id": "deviceId",
            "name": "Input Source",
            "type": "any",
            "description": "Defines the device or group of devices from which the position is received.",
            "extendedDescription": "This can be a single device, or an object that references or contains a group of devices."
        },
  ]
}

The metadata for blocks from 2. are in the form:
{
    "name": "CreateEvent.mon",
    "path": "samples/blocks/CreateEvent.mon",
    "sha": "8b5c00f296baffbafb03a70d3444b47e85ddf133",
    "size": 6139,
    "url": "https://api.github.com/repos/SoftwareAG/apama-analytics-builder-block-sdk/contents/samples/blocks/CreateEvent.mon?ref=rel/10.18.0.x",
    "html_url": "https://github.com/SoftwareAG/apama-analytics-builder-block-sdk/blob/rel/10.18.0.x/samples/blocks/CreateEvent.mon",
    "git_url": "https://api.github.com/repos/SoftwareAG/apama-analytics-builder-block-sdk/git/blobs/8b5c00f296baffbafb03a70d3444b47e85ddf133",
    "download_url": "https://raw.githubusercontent.com/SoftwareAG/apama-analytics-builder-block-sdk/rel/10.18.0.x/samples/blocks/CreateEvent.mon",
    "type": "file",
    "_links": {
      "self": "https://api.github.com/repos/SoftwareAG/apama-analytics-builder-block-sdk/contents/samples/blocks/CreateEvent.mon?ref=rel/10.18.0.x",
      "git": "https://api.github.com/repos/SoftwareAG/apama-analytics-builder-block-sdk/git/blobs/8b5c00f296baffbafb03a70d3444b47e85ddf133",
      "html": "https://github.com/SoftwareAG/apama-analytics-builder-block-sdk/blob/rel/10.18.0.x/samples/blocks/CreateEvent.mon"
    }
}

In order to get the complete block name (monitor) one has to parse the content of the EPL from github.

This feature is added to the latest release.


feat(structured-list): Add new structured list component

Related Ticket(s)
closes #8388
Description
Adds structured list element to carbon-for-ibm-dotcom.
Changelog
New

dds-structured-list

Remaining Tasks

[ ] Match styles to functional specs
[ ] Port WC to React

@kennylam

I think extending the existing structured-list would be simpler?

I was deliberately avoiding the upstream structured list for two reasons:

The upstream structured list has a lot of selection/input logic. It seems like this component was at one point used like a form element?

The upstream component essentially mimics the HTML table markup, which is great, but it requires a lot of markup to achieve the result. The approach I'm taking here should be significantly simpler to achieve the same result.

Thoughts moving forward?

@andy-blum The problem is that this introduces a duplicate component (and css) to maintain when there is already an existing one to leverage. While the streamlined, simplified markup is great, it comes at the expense of a whole lot of duplicated code. Also, I think the event handlers and input logic will still be used with the expanding rows and checks-on-click. Unless I'm missing something in the updated designs, I don't see why we can't extend the carbon-web-components version?
cc: @oliviaflory @emyarod

@kennylam I have a second branch opened up locally where I'm extending the carbon-web-components. I'm going to leave this PR up for now in case I need to copy anything over from it.

Thanks @andy-blum!


For discussion: Make the labels for checkboxes and radios full-width

I noticed recently, when filling out one of the various covid-related services on my phone (in a hurry, and slightly distracted) that I instinctively went to tap the whitespace to the right one of the labels for a checkbox, which didn't work.
A recent change to the GOV.UK homepage made the tap touch targets there larger (including whitespace and the text below a link).
The accordion component also allows you to the tap the whitespace to the right of the label, as does the regular labels for text inputs.
Should we do the same for radio and checkbox labels? The benefit would be especially felt where the label is very short (eg "Wales" in a list of countries.
One possible reason not to do it might be that some users may select the option accidentally, and not realise. However this risk may be small as the checkbox and radios themselves are quite large, and mobile devices are fairly good at distinguishing between scroll gestures and tap gestures. It's a consideration though.

Worth noting that this was a conscious change originally made in https://github.com/alphagov/govuk-frontend/pull/634, which also aligned it with the behaviour from GOV.UK Elements, so this would effectively be reverting that.
There's more context on the thinking at the time in that PR and associated issue.

@36degrees ha, interesting, thanks! We wondered (on the cross-gov Design Systems chat) whether there was any history behind this, or the NHS version... 🤔

As a suggestion, what if we only reactivated the full width on smaller screen sizes? It feels like at smaller sizes it would have the most benefit and at larger sizes create the most risk with the likelihood of larger space and the difference in interaction with a mouse vs fingers.

As a suggestion, what if we only reactivated the full width on smaller screen sizes? It feels like at smaller sizes it would have the most benefit and at larger sizes create the most risk with the likelihood of larger space and the difference in interaction with a mouse vs fingers.

@owenatgov interesting idea. I worry slightly that the inconsistency between mobile and desktop might be confusing (and what about tablets)?
The risk of mis-clicking could possibly be mitigated by recommending that checkboxes and radios should usually appear in columns no wider than a 2/3rds grid column? Alternatively we could look at applying a subtle hover state, like the accordion and the gov.uk homepage uses, which might help make the bigger click area more discoverable too.
It's hard to evaluate how big the risk of mis-clicking (and the user not noticing) is though. The NHS design system still has full width labels for checkboxes (but not radios) - we could reach out to them to see if it's ever come up in research?

The NHS design system still has full width labels for checkboxes (but not radios) - we could reach out to them to see if it's ever come up in research?

From looking at their code, I am pretty confident that this is unintentional and based entirely on the order that components are imported and defined in the CSS.
In both GOV.UK Frontend and NHS Frontend, the label elements for checkboxes and radios have both the __label modifier class for the component and the label class.
The __label modifier class has display: inline-block:
https://github.com/alphagov/govuk-frontend/blob/3f264256fa01c8d5b5d4e8121756e50d866eda7d/src/govuk/components/checkboxes/_index.scss#L66-L73
The label class has display: block:
https://github.com/alphagov/govuk-frontend/blob/3f264256fa01c8d5b5d4e8121756e50d866eda7d/src/govuk/components/label/_index.scss#L2-L9
Both classes have the same specificity, and so whichever appears in the CSS last 'wins'.
Components in GOV.UK Frontend that rely on other components import them at the top of the file. For example, the checkboxes component relies on the label component, and so imports it:
https://github.com/alphagov/govuk-frontend/blob/3f264256fa01c8d5b5d4e8121756e50d866eda7d/src/govuk/components/checkboxes/_index.scss#L1-L6
This means that the CSS for labels will appear before the CSS for checkboxes and radios in GOV.UK Frontend.
For whatever reason, NHS Frontend doesn't do this. Therefore the components appear in the CSS in the order they're imported, which is alphabetical.
This means the label component comes after the checkboxes, overriding the display property, but radios comes after label and so radios still get display: inline-block as intended.

(Raised at https://github.com/nhsuk/nhsuk-frontend/issues/842)

@36degrees amazing detective work! 🙌

The labels are distinct from the other examples given in that they are 'open'. They are visually presented as plain text, with no keylines, borders or hover states indicating that there is an activation area or interaction that will take place—unlike GOV.UK's homepage cards, accordion's headers, or our own compact checkboxes.
Previous research has found that users don't tend to grok that labels are clickable in the first place, so I don't think there is value in amending the visuals or adding a hover state to make this interaction clearer either.
I'm struggling to see any value in making the labels full-width, as experienced users are more liable to click the label text than the empty space next to it, and having whitespace perform a function of any sort when clicked feels both unexpected and unintentional.

@querkmachine good points! I'm also not sure whether this is a good idea or not.  As I see it, the main benefit would be having a bigger click area, particularly for short labels, which may aid some users with mobility impairments, and be a marginal speed improvement for everyone else (eg when using a mobile phone one handed). This would have to be to weighed against the possible downside of unexpected behaviour or unintentional clicks.  Both are pretty hard to quantify!
The question of whether an active area ought to have a visible or at least implied border is an interesting one! I don't know the answer to that.
Interestingly, the ONS Design system checkboxes uses a fixed-width for the labels to increase the click area, but also renders a border around both the checkbox and the label:

Thanks to @36degrees, the NHS Design system has recently switched to making the labels non-full-width (which was unintentional), although the change doesn't seem to have hit their checkbox guidance page yet.
If we have a consensus to avoid making any changes just yet, I'd be happy to close this pull request, and we can reference this debate on the Checkbox backlog issue thread instead, in case it comes up in future?

Hi @frankieroberto,
We discussed this again earlier today and have decided that we're going to close this PR without merging.
We would want more research into how this change would affect the usability of these components before making this change. I've tried looking at some of the design systems you linked earlier to see if there was any prior user research supporting the change, but couldn't find any on a quick glance.
I've opened an issue to that effect: #3072, though this is admittedly unlikely to be tackled in the near term.
Thanks for your contribution regardless, and the discussions (and NHS DS bugfix!) that it spawned.

@querkmachine thanks. I wasn’t sure if this was necessarily a good idea, but the discussion has been interesting (and helped the NHS Design System!).


Include NOTICE for Apache-2.0

Describe the bug
https://www.apache.org/licenses/LICENSE-2.0.html#redistribution says:

If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file ...

This is the first three lines of https://github.com/josdejong/mathjs/blob/develop/NOTICE
Another example https://github.com/nodejs/import-in-the-middle/blob/main/NOTICE
How are you using generate-license-file?
Library
What version of generate-license-file are you using?
3.5.1
To Reproduce
Run this tool on a project depending on https://www.npmjs.com/package/mathjs
Expected behavior
The NOTICE file should be included, or at least the lines of the NOTICE file that are unique to each project.
Screenshots
Desktop (please complete the following information):
Additional context

Hey @jayvdb,
In the past we've worked on the assumption that a consumer of a package would only want/need a single file - either a LICENSE.md or a NOTICE.md. However we've now drawn the conclusion that, yeah, it can often be important to include both. In PR #543 we've made notice files a first-class feature of our ILicense interface. We'll be releasing this feature shortly.

Hey @jayvdb,
This has gone out in version 3.6.0!
I'm going to close this for now - let us know here or open a new issue if you have any issues.
Thanks

Thank you @tobysmith568 , we are now utilising this new feature.  Much appreciated.


[ISSUE #2250]Reliance on default encoding [RedirectClientByPathHandlerTest]

Fixes #2250
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Please describe PR detail using template.


v1.33.0 disabled extension appears to be running

Issue Type: Bug
I can reliably reproduce this problem. It started happening today, following today's VS Code update (March 2019, 1.33.0). It is closely related to #21930.
I have formatOnSave=false but I am suddenly seeing my React JS files being modified upon save (the JSX is being mangled). I have the vscode-js-css-html-formatter extension installed, but disabled. Somehow, it appears to be functional (and also abusing formatOnSave=false).
The symptoms seem to suggest that the disabled extension is not actually disabled. If I uninstall the extension there is no indication that I need to reload VS Code to complete the uninstallation yet the save-on-format behavior is still present, post-uninstall.
If I uninstall the extension and actually reload VS Code, then the format-on-save behavior has gone and everything is good.
Any chance that v1.33.0 introduced a bug allowing disabled extensions, and uninstalled extension but VS-Code-not-yet-reloaded, to continue to run? Or is this extension somehow escaping whatever sandbox you have for disabled extensions?
This problem does not repro on v1.32.3.
VS Code version: Code 1.33.0 (0dd516dd412d42323fc3464531b1c715d51c4c1a, 2019-04-04T15:11:32.076Z)
OS version: Darwin x64 16.7.0

Just noticed this bug raised against the extension: Formatter must unregister when being disabled

@john-aws I see reload action when I uninstall/disable the extension (vscode-JS-CSS-HTML-formatter). Can you please check if the extension is shown when you run the command Show Running Extensions before you disbaled/uninstalled it?

The symptoms seem to suggest that the disabled extension is not actually disabled.

How did you disable it? In the sense of disabling the extension or disabling it with its setting?

Ran across this issue as well. I have a bug report with system info at #71769.
@sandy081 The disabled-but-not-really-disabled extension doesn't show up under Show Running Extensions.
@jrieken I am alleviating this issue temporarily by just uninstalling the extensions I don't need. I guess if you have some extensions activated for only certain workspaces, you could be in a tough spot.

@sandy081 confirmed that the extension does not show up under Show Running Extensions after disabling but before uninstalling. In this state it does still appear to be reformatting my JSX.
@jrieken to disable the extension, I used the native VS Code Extension Manager, clicked the settings cog, and chose Disable (not Disable (Workspace)).

If it is not shown under running extensions, the extension should not be running unless there is a bug in it.
@alexandrudima any insights on this?

Is it's technically possible for a disabled extension to run (I don't know for sure if it is, but it seems to be), shouldn't VS Code exert more control? A clear preference from the user to disable an extension would ideally take the decision out of the hands of the extension writer.

@john-aws It should not happen. When a user disables an extension and reload the window, it should not run. Can you please provide the steps for me to reproduce, also the set up (extensions you have) would be helpful too?

@sandy081 my #71752 has a specific repro steps.
(sorry if you were already aware -- just making sure!)

There is a bug indeed.
I'm using this feature heavily (disabling of extensions globally/per workspace). For example clangd extension appears to be still running (partially at least) while being disabled globally. There are several indications for that:

At least some LSP providers are acting (definition/formatting/references).
Process Explorer shows LSP executable under Extension host.
There is "Clang language server" output panel.

However the extension is not listed in Show running extensions. Also I found the following lines in Log (Extension Host) output panel:
[2019-04-15 13:48:56.421] [exthost] [info] ExtensionService#_doActivateExtension llvm-vs-code-extensions.vscode-clangd {"startup":false,"activationEvent":"onLanguage:c"}
[2019-04-15 13:48:56.421] [exthost] [info] ExtensionService#loadCommonJSModule /home/sergei/.vscode/extensions/llvm-vs-code-extensions.vscode-clangd-0.0.12/out/src/extension

Don't know what they mean though.

@alexandrudima
Today @jrieken has seen similar issue and we debugged it together. Outcome is that we are starting the extension host with all scanned extensions and not filtering the disabled extensions. See following code
https://github.com/Microsoft/vscode/blob/f7b33b613ed05e3649da8fb93cec88dac7d85856/src/vs/workbench/services/extensions/electron-browser/extensionService.ts#L433-L440
Not sure why are we not filtering out disabled extensions if it is initial start?

Reverted the fix. I digged deep and above fix is not correct as the bug is not on renderer side. Root cause is in extension host.

We create extension host with all extensions
We start it after with only enabled extensions
We are not holding those activation events those come between ext host is created and ext host is started. This is causing disabled extensions to activate.

Will come up with the accurate fix.

Verified by disabling the vscode-js-css-html-formatter, relaod and save a js file. No formatting happens.


When Twitter Emoji is toggled on emoji render as distorted in Minimal theme

I thought you might want to be aware of this conflict with the Minimal theme:
"…a quick update and the solution to my emoji-rendering problem: You were right, the problem was caused by the plugin “Emoji Toolbar” (I should have investigated this obvious connection earlier haha). The Plugin Option “Twitter Emoji” must be turned off to fix this."
https://forum.obsidian.md/t/minimal-theme/3659/262

Thanks @autonomygaps for bringing to my attention. I'll take a look and see what's causing the conflict.

Hi @autonomygaps - I believe Kepano has now addressed this and there is no longer a compatibility issue.


Lens crashed while viewing pod logs; now always crashes for this single cluster only

Describe the bug
Lens now always crashes when attempting to connect to one of my clusters. The cluster is fully reachable. The issue begn when fetching a pod log. Lens crashed (info below) and then immediately crashes after connecting to this cluster (and only this single cluster). This behavior persists after restarting. The connection seems to be successful; the crash seems to actually occur
when attempting to display the cluster.
To Reproduce
Steps to reproduce the behavior:
Simply connect to the cluster in question. Lens crashes immediately. I cannot reproduce this behavior with any other cluster, unfortunately
Expected behavior
Lens would connect to the cluster and display the cluster screen
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Lens Version: 5.3.2-latest.20211201.1
OS:  OSX
Installation method: This version was the last upgrade taken

Logs:
Startup is fine. Only this cluster seems to crash. The error is as follows
App crash at /
Component stack:

    at wrappedComponent (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:10557:16)
    at div
    at Logs (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/chunks/5.js:7285:9)
    at div
    at div
    at Dock (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/chunks/5.js:7717:9)
    at div
    at div
    at MainLayout (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:286596:9)
    at ErrorBoundary (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:237949:9)
    at Router (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:79054:30)
    at ClusterFrame (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/chunks/5.js:7946:9)
    at ThemeProvider (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:609860:24)

Error stack:

TypeError: Cannot create a KubeObject from undefined
    at new KubeObject (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:32750:19)
    at new WorkloadKubeObject (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:124953:1)
    at new Pod (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:154508:9)
    at http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/chunks/5.js:7217:17
    at http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:10557:49
    at http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:10521:25
    at trackDerivedFunction (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:3120:18)
    at Reaction.track (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:3649:18)
    at useObserver (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:10519:14)
    at wrappedComponent (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:10557:16)
    at Ch (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:556346:137)
    at li (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:556369:154)
    at ki (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:556367:169)
    at ii (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:556366:178)
    at ck (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:556463:126)
    at bk (http://3863dbca4b80df474930e0cfc76321c5.localhost:58504/build/Lens.js:556439:347)

Kubeconfig:
All other clusters in this file seem ok. I should note that I tried deleting this cluster from Lens; the delete attempt fails -- but with no error. Indeed, the problematic cluster was fine until the crash. I feel like if I could delete it and re-add it it would be fine
your kubeconfig here

Additional context
Add any other context about the problem here.

Interestingly, making a copy of the existing kube-config and resyncing from that does actually seem to fix the issue -- at least for now

Thanks for reporting this. We're working on the fix https://github.com/lensapp/lens/pull/4376

Closing as this has been fixed in master.


Nesting not working with interpolated strings

Consider the following bit of Sass:
.element {
  #{".one, .two"} {
    property: value;
  }
}

This is supposed to compile to:
.element .one, .element .two {
  property: value;
}

But instead compiles to the following using scssphp:
.element .one, .two {
  property: value;
}

Any idea what might be wrong?

Fixed in 1409169


feat: new storage implementation

:tada: This PR is included in version 0.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


openai.Completion.retrieve()

Describe the bug
EngineAPIResource.init() takes from 1 to 2 positional arguments but 3 were given
To Reproduce
does this only happen to me when using 'retrieve' in openai.
i got this error :  "EngineAPIResource.init() takes from 1 to 2 positional arguments but 3 are given"
Code snippets
key = "my_api_key"
openai.api_key=key
id_chat = "my_completion_id"
try:
    result = openai.Completion.retrieve(id_chat)
    print(result['choices'][0]['text'])
except Exception as a:
    print(a)

OS
arch linux
Python version
Python 3.10.9
Library version
openai-python v0.26.5

openai currently does not support retrieving past completions, you should save and manage completion responses client-side.

^ is correct. There is no way to retrieve past completions with the API


Prepare webpack-based template for a project using lumina in a browser

https://github.com/eigerco/lumina-nextjs-template/


Update business-unit.yaml

New field fiscalBusinessUnitID:

Business unit can be assigned special identifier for fiscal purposes.


<IP_ADDRESS> no more available

<IP_ADDRESS>/ipk/webos4x-6x.expertmode.downgrade_1.0.0_all.ipk is no more available. Has anyone still this IPK files stored

может у кого то есть файл ipk для GETS TV

Does anyone have an ipk file for GETS TV?


Call hs_core.hydroshare.hs_bagit.create_bag_files() after the resourc…

Addresses #656

@hyi Please review when you can.  This is needed for the next test of migration.

@selimnairb I added a review comment for your consideration. Let me know if you have questions.


DB Sync

The note about doing database synchronization needs to be moved further down in the text, after the SQL script is executed and the database is renamed.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7c5e8701-e1d4-25f8-d76a-ee7870b915e1
Version Independent ID: 624211c7-2eb4-7154-d38f-236dc6f8f7a9
Content: Export a copy of the standard user acceptance testing (UAT) database - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/database/dbmovement-scenario-exportuat.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @laneswenka
Microsoft Alias: laswenka

Bug 834819 has been logged to address this issue.

Thanks for your feedback. We have passed this feedback onto the product team for consideration.


Add amount borrowed field for customer to show on UI

Pull Request Test Coverage Report for Build 359

6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 73.967%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/storage/HtmlWriter.java
6
8
75.0%

Totals

Change from base Build 356:
0.002%

Covered Lines:
1952

Relevant Lines:
2639

💛  - Coveralls