HBASE-22870 reflection fails to access a private nested class

HMaster crashes at org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
A private static nested class can not be instantiated via reflection.
code snippet
      try {
        abortTimeoutTask =
            Class.forName(conf.get(ABORT_TIMEOUT_TASK, SystemExitWhenAbortTimeout.class.getName()))
                .asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
      } catch (Exception e) {
        LOG.warn("Initialize abort timeout task failed", e);
      }

log in product environtment
2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout task failed
java.lang.IllegalAccessException: Class org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of class org.apache.hadoop.hbase.regionss
     erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
   at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
   at java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
   at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
   at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
   at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
   at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598)

Did you raise a related JIRA ticket? If not, please raise one first, it is easy for history tracking.

Did you raise a related JIRA ticket? If not, please raise one first, it is easy for history tracking.

hbase-2.1.5 will be deployed in our product environment, now, interface compablity,  integration test and fault exercises are being performed, so more and more bugs will be exposed. I want to contribute bugfix, how can I do? It there a guide doc for new comer?

HBASE-22870, is it yours? Please update the description in JIRA too.

HBASE-22870, is it yours? Please update the description in JIRA too.

@Reidddddd
Yes, jira just created by me a few minutes ago, I have add description detail to the ticket, and now both commit and merge request is assocated with HBASE-22870

Let's wait some time to see if any other comment. I'll will commit it tomorrow if no further comment.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
347
master passed

+1
compile
51
master passed

+1
checkstyle
82
master passed

+1
shadedjars
277
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
36
master passed

0
spotbugs
249
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
246
master passed

_ Patch Compile Tests _

+1
mvninstall
297
the patch passed

+1
compile
51
the patch passed

+1
javac
51
the patch passed

+1
checkstyle
74
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
273
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
939
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
33
the patch passed

+1
findbugs
247
the patch passed

_ Other Tests _

-1
unit
16199
hbase-server in the patch failed.

+1
asflicense
41
The patch does not generate ASF License warnings.

19655

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

hadoop.hbase.tool.TestSecureBulkLoadHFiles

hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.tool.TestBulkLoadHFiles

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/503

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux a70f7ca1fc49 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh

git revision
master / 3eb602c7f7

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/1/testReport/

Max. process+thread count
5069 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
376
master passed

+1
compile
60
master passed

+1
checkstyle
81
master passed

+1
shadedjars
304
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
40
master passed

0
spotbugs
263
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
261
master passed

_ Patch Compile Tests _

+1
mvninstall
349
the patch passed

+1
compile
61
the patch passed

+1
javac
60
the patch passed

+1
checkstyle
82
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
296
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
981
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
265
the patch passed

_ Other Tests _

+1
unit
8192
hbase-server in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

11850

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/503

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e77166e3bead 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh

git revision
master / 43a0ec80fa

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/3/testReport/

Max. process+thread count
4973 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
66
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
346
master passed

+1
compile
54
master passed

+1
checkstyle
83
master passed

+1
shadedjars
307
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
master passed

0
spotbugs
269
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
267
master passed

_ Patch Compile Tests _

+1
mvninstall
303
the patch passed

+1
compile
56
the patch passed

+1
javac
56
the patch passed

+1
checkstyle
73
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
302
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
966
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
35
the patch passed

+1
findbugs
276
the patch passed

_ Other Tests _

-1
unit
17832
hbase-server in the patch failed.

+1
asflicense
41
The patch does not generate ASF License warnings.

21405

Reason
Tests

Failed junit tests
hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.replication.TestReplicationSmallTests

hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

hadoop.hbase.client.TestAsyncRegionAdminApi2

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/503

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b33b33569020 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh

git revision
master / 43a0ec80fa

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/2/testReport/

Max. process+thread count
4796 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
359
master passed

+1
compile
65
master passed

+1
checkstyle
90
master passed

+1
shadedjars
291
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
40
master passed

0
spotbugs
273
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
270
master passed

_ Patch Compile Tests _

+1
mvninstall
311
the patch passed

+1
compile
53
the patch passed

+1
javac
53
the patch passed

+1
checkstyle
77
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
294
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1013
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
32
the patch passed

+1
findbugs
280
the patch passed

_ Other Tests _

+1
unit
8303
hbase-server in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

11951

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/503

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ae0ab4e24096 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh

git revision
master / 43a0ec80fa

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/4/testReport/

Max. process+thread count
4821 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
309
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
364
master passed

+1
compile
63
master passed

+1
checkstyle
81
master passed

+1
shadedjars
326
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
36
master passed

0
spotbugs
286
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
284
master passed

_ Patch Compile Tests _

+1
mvninstall
321
the patch passed

+1
compile
56
the patch passed

+1
javac
56
the patch passed

+1
checkstyle
76
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
278
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1070
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
35
the patch passed

+1
findbugs
267
the patch passed

_ Other Tests _

-1
unit
19329
hbase-server in the patch failed.

+1
asflicense
109
The patch does not generate ASF License warnings.

23442

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.replication.TestReplicationSmallTests

hadoop.hbase.replication.TestReplicationSmallTestsSync

hadoop.hbase.replication.TestMasterReplication

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.tool.TestSecureBulkLoadHFiles

hadoop.hbase.tool.TestBulkLoadHFiles

hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

hadoop.hbase.client.TestCloneSnapshotFromClientNormal

hadoop.hbase.client.TestAsyncTableAdminApi

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/503

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 0c60b7ca88bc 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh

git revision
master / 7903f55c18

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/5/testReport/

Max. process+thread count
4602 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

commit

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
67
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
318
master passed

+1
compile
53
master passed

+1
checkstyle
72
master passed

+1
shadedjars
266
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
34
master passed

0
spotbugs
260
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
257
master passed

_ Patch Compile Tests _

+1
mvninstall
306
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

+1
checkstyle
75
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
267
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
900
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
34
the patch passed

+1
findbugs
273
the patch passed

_ Other Tests _

-1
unit
18654
hbase-server in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

22040

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote

hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.tool.TestSecureBulkLoadHFiles

hadoop.hbase.client.TestAsyncTableAdminApi

hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.replication.TestReplicationSmallTests

hadoop.hbase.tool.TestBulkLoadHFiles

hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.replication.TestReplicationDisableInactivePeer

hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/503

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b525c8d8ef6b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh

git revision
master / 8cb531f207

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/6/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/6/testReport/

Max. process+thread count
5067 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
331
master passed

+1
compile
56
master passed

+1
checkstyle
76
master passed

+1
shadedjars
313
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
36
master passed

0
spotbugs
289
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
286
master passed

_ Patch Compile Tests _

+1
mvninstall
314
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

+1
checkstyle
78
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
325
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1008
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
53
the patch passed

+1
findbugs
280
the patch passed

_ Other Tests _

-1
unit
19217
hbase-server in the patch failed.

+1
asflicense
147
The patch does not generate ASF License warnings.

23212

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestReplicationDisableInactivePeer

hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.replication.TestReplicationSmallTestsSync

hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.tool.TestSecureBulkLoadHFiles

hadoop.hbase.tool.TestBulkLoadHFiles

hadoop.hbase.client.TestRestoreSnapshotFromClientClone

hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.client.TestCloneSnapshotFromClientNormal

hadoop.hbase.client.TestAsyncTableAdminApi

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/503

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 50e298ed5712 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh

git revision
master / 836f26976e

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/7/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/7/testReport/

Max. process+thread count
4701 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


File "build.py", line 111, in build_extensions     customize_compiler_for_nvcc(self.compiler)   File "build.py", line 83, in customize_compiler_for_nvcc     default_compiler_so = self.compiler_so AttributeError: 'MSVCCompiler' object has no attribute 'compiler_so'

when i run make.sh,the git bash show that. python=3.7.16,cuda=v12.2

replace from utils.nms_wrapper import nms with from utils.nms.py_cpu_nms import py_cpu_nms, and keep = nms(dets, args.nms_threshold, force_cpu=args.cpu) with keep = py_cpu_nms(dets, args.nms_threshold). and don‘t need to run make.sh!!


Project flags, for global config defaults + behavior change migrations

resolves #4366
resolves #4709
resolves #4787
What are you changing in this pull request and why?

Reframe "global configs" → "flags"
Settable in dbt_project.yml instead of profiles.yml
Subcategory of flags for legacy behaviors / behavior change migrations

Previews

New content or significant edits:

website/docs/reference/global-configs/about-global-configs.md
website/docs/reference/global-configs/json-artifacts.md
website/docs/reference/global-configs/legacy-behaviors.md
website/docs/reference/global-configs/logs.md
website/docs/reference/global-configs/parsing.md
website/docs/reference/global-configs/project-flags.md
website/docs/reference/global-configs/record-timing-info.md
website/docs/reference/global-configs/version-compatibility.md
website/sidebars.js
website/vercel.json

Edited links:

website/docs/docs/dbt-cloud-apis/sl-manifest.md
website/docs/docs/dbt-versions/core-upgrade/08-upgrading-to-v1.2.md
website/docs/docs/dbt-versions/core-upgrade/10-upgrading-to-v1.0.md
website/docs/reference/artifacts/dbt-artifacts.md
website/docs/reference/dbt_project.yml.md
website/docs/reference/events-logging.md
website/docs/reference/parsing.md
website/docs/reference/project-configs/clean-targets.md
website/docs/reference/resource-configs/severity.md

Deleted:

website/docs/reference/global-cli-flags.md
website/docs/reference/global-configs/yaml-configurations.md
website/docs/reference/project-configs/log-path.md
website/docs/reference/project-configs/target-path.md

Minor edits (moved and re-titled):

website/docs/reference/global-configs/command-line-options.md

Other:

.github/pull_request_template.md

Checklist
Adding or removing pages (delete if not applicable):

[x] Add/remove page in website/sidebars.js
[x] Provide a unique filename for new pages
[x] Add an entry for deleted pages in website/vercel.json
[x] Run link testing locally with npm run build to update the links that point to deleted pages

@jtcohen6 I'm trying to translate the changes in this PR over to my PR on indirect_selection, and am looking at the Configs properties, what are they? page. Should we be making any updates to that page to align with the global configs are now being called flags change?

Should we be making any updates to that page to align with the global configs are now being called flags change?

No - those are resource-level configs, which modify the definition and behavior of specific resources in the project (~nodes in the DAG), e.g. "This model is a table, and it has tag pii.")
We should keep calling them that, and avoid as much confusion as possible with flags (aka / fka "global" configs), which affect how dbt runs, e.g. "In CI environments, stop on the first error."

Should we move the global configs captured here in the profiles.yml over to the project file?

Yes! Starting in v1.8, we are deprecating support for these being defined in profiles.yml.


Allow claiming a "too-similar" package name

What's the problem this feature will solve?
Sometimes names are intentionally similar. For instance, I have an "asyncdbus" package, which obviously affects async access to dbus. Now I want to post a package "asyncmodbus" which does the same thing for modbus, which has nothing to do with dbus. However both modbus and dbus are established buses.
Describe the solution you'd like
Add an issue form for claiming a "too-similar" name.
Also, if the packages' maintainer is the same person, let's please presume that they know what they are doing.

We do have a process for this, you can file an issue here.
In this case, the issue is that asyncmodbus is too similar to https://pypi.org/project/async-modbus/, not asyncdbus


Kafka emit to Datadog is broken under ruby 3

Version of Ruby: 3.0
Version of Kafka: not relevant (there are several)
Version of ruby-kafka: 1.5.0

I'm not sure how to set up an isolated example - in order to create the issue you need to have ruby-kafka and dogstatsd-ruby installed, and attempt to emit an event to the latter from the former under ruby 3.
This code attempts to invoke the dogstatsd increment method (and various others) with an options hash and a single tags keyword argument, but the method it's forwarding to in dogstatsd-ruby expects a hash argument and zero keyword arguments. Under ruby3 that produces an exception like
ArgumentError: wrong number of arguments (given 3, expected 1..2)
/usr/src/app/vendor/bundle/ruby/3.0.0/gems/dogstatsd-ruby-5.5.0/lib/datadog/statsd.rb:159:in `increment'
/usr/src/app/vendor/bundle/ruby/3.0.0/gems/ruby-kafka-1.5.0/lib/kafka/datadog.rb:107:in `emit'
/usr/src/app/vendor/bundle/ruby/3.0.0/gems/ruby-kafka-1.5.0/lib/kafka/datadog.rb:100:in `block (2 levels) in <class:StatsdSubscriber>'

I could put up a PR that would produce identical behavior in ruby2, but probably it should be accompanied by an addition to your circle config that will execute your test suite against ruby 3, and I don't think I can get that correct from outside.
The monkey-patch I'm using to get past the error currently in our ruby3 branch looks like this:
unless Kafka::VERSION == "1.5.0"
  fail("Kafka 1.5.0 is monkey-patched in config/initializers/monkey_patch_ruby_kafka.rb")
end

module Kafka
  module Datadog
    class StatsdSubscriber < ActiveSupport::Subscriber
      private

      # Original implementation in ruby-kafka 1.5.0, in lib/kafka/datadog.rb, at
      # https://github.com/zendesk/ruby-kafka/blob/v1.5.0/lib/kafka/datadog.rb#L104-L108
      #
      # def emit(type, *args, tags: {})
      #   tags = tags.map {|k, v| "#{k}:#{v}" }.to_a
      #
      #   Kafka::Datadog.statsd.send(type, *args, tags: tags)
      # end
      #
      # But the datadog methods it's actually sending to do not accept keyword arguments,
      # so in ruby3 this fails. We need to implement the 'collapsing' behavior the ruby 2
      # uses for merging keyword arguments onto an options hash.

      def emit(type, *args, tags: {})
        tags = tags.map { |k, v| "#{k}:#{v}" }.to_a

        if args.last.is_a?(Hash)
          args.last[:tags] = tags
        else
          args << {tags: tags}
        end

        Kafka::Datadog.statsd.send(type, *args)
      end
    end
  end
end

Problem still seems to be present, but it doesn't look like anyone has investigated.


Add eth2eth test

Add ethereum to ethereum test case

@toshihiko-okubo could you add a link to this test case in README?


Use publishing-api for tagged content

Use publishing-api endpoint for linked items. Publisher apps should never use the content-store, because it's not synchronous and could cause confusion for users. In this case, taggings would not immediately show up because publishing-api sends the tags to the content-store via a Sidekiq worker.
This commit replaces the call to content-store with a call to the publishing-api, so we only have one dependency.
Also does some other cleanup. See commits for details.

👍


Copy function stop working during connection

I have read the FAQ.
I have searched in existing issues.

Environment

OS: Windows
scrcpy version: 2.1.1
installation method: Windows release
device model: LineageOS 20
Android version: 13

Describe the bug
I switched to LineageOS recently. Now, once scrcpy is connected, I can not copy any text in Android, the text is not in neither Android IME nor Windows . No errors in Android or scrcpy. I can paste text from scrcpy into Android.
.\scrcpy.exe -d
For example, In Chrome for Android, for a link, Copy the link address and Copy the link text does not work.
Stop scrcpy will resolve this immediately.

Either a bug or a security restriction in the ROM (LineageOS).


[dev-env] rename clientCode to appCode

Description
To make naming easier (and consistent) we renamed clientCode/siteCode to appCode.
Steps to Test
 npm run build && ./dist/bin/vip-dev-env-create.js --slug test --app-code demo

@yolih should we add a usage example with --app-code demo as well? If yes please let me know the command and the description you would like me to add.


We found a potential security vulnerability in one of your dependencies.

it was found by github alerts:

I think we just use jQuery in GitHub pages, so we can upgrade it.

Who are willing to take a stab at it? And also Master branch should have been pushed to NPM. But @fkleuver seems to be out of radio range or switched off atm :)

I'm willing to, but not atm. maybe the following 2~3 days.


Restrictive versions in dependencies (and Python 3.11 conflict)

The README states the following dependencies:
pandas >= 1.3
numpy >= 1.19
numba >= 0.56
river >=0.14

Hoever in the pyproject.toml the following specifers are used:
[tool.poetry.dependencies]
python = "^3.8"
pandas = "^1.3"
numpy = "^1.19"
numba = "^0.56"
river = "^0.14"
optuna = "^3.1.1"

The ^ specifier means that only SemVer compatible updates are allowed. Which for 0.x series like numba and river, means only patch releases. This is quite restrictive in general for a library.
And right now it causes incompatibility with Python 3.11. Because Py 3.11 support is only in requires numba 0.57.0, whereas streamchange has the dependency numba<0.57,>=0.56 when ^0.56 is resolved by pip.

Maybe consider to change dependencies in general to ">=". This would allow more version updates on the assumption that they mostly will work. And that consumers of the library can always lock/restrict the version further (by specifying in their own requirements.txt/pyproject.toml), if they identify a problem.


Shortcut ignored east to Shilo Village

As the title mentions, this shortcut seems to be ignored.
It does suggest the lvl 1 Log Balance up to the north, but not these lvl 30 Stepping Stones. I have 59 agility and isn't drained. I also enabled "Use agility shortcuts".
Happy to provide more information if necessary.

This was added in version 1.13


Clarify behavior of "order": []

Nitpick: On http://datatables.net/reference/option/order, perhaps instead of "No initial order", this page should document "No initial ordering applied by DataTables. The rows are shown in the order they are listed in the HTML source."

Sounds good - I've changed the wording slightly, but it is improved now. I'll deploy to the site soon.


fetch-networking: fix parsing of HTTP headers

Currently, I have only seen this bug in older versions of Dillo, but it's possible that other HTTP clients have it too.
Test-case: boot from https://distro.ibiblio.org/damnsmall/current/current.iso with enabled fetch networking and then try to open any page in Dillo, you get in the browser console:
TypeError: Headers.set: accept-encoding:gzip is an invalid header name.

A raw HTTP request from Dillo looks like this:
GET / HTTP/1.0
Host: copy.sh
User-Agent: Dillo/0.8.5-i18n-misc
Accept-Language: en-us, ja
Accept-Encoding:gzip
Accept-Charset:utf-8,ISO8859-1
Cookie2: $Version="1"

According to RFC 2616 (section 4.2), HTTP client/server can use any amount of whitespaces after separator, previous code expected only one space after the colon (separator).

Thanks for the suggestions, I think that it's better make a properly HTTP headers validation, so my apologies that I had remake this PR. Let me know if I need to create a new PR instead.
Changes:

added check on empty header key/value and forbidden chars
send Error 400 on failed check
added tests for each behaviour

Another concern I see with this HTTP request parser: Only the first fragment of the request body is taken into account, that is as many bytes that fit into the last TCP headers packet right after the end of headers, up until the end of packet. If the originating client sends a request with a longer body this will break.
After (or while) reading the headers it should be checked whether there is a Content-Length field, and if there is then as many bytes should be read from the originating client before continuing to process the request. For the sake of completeness (the originating client should be free to do whatever is allowed), also chunked body encoding should be considered when reading this reuest body.

After (or while) reading the headers it should be checked whether there is a Content-Length field, and if there is then as many bytes should be read from the originating client before continuing to process the request.

Agreed, it might be worth adding a check if Content-Length: 0 but the client sends data.
If I correctly understand, HTTP/1.1 client also can send chunked data: https://everything.curl.dev/http/post/chunked.html, and I'm not sure that even without Transfer-Encoding: chunked can send any amount of data before the connection is closed, as in this case with the server response: https://github.com/copy/v86/pull/1178#issuecomment-2470997329

Let me rephrase what I mean, forgive me if that was already clear to you.
Think of a longer request from the originating client (by that I mean something like HTGET.EXE from mTCP). I mean "long" in relation to the TCP frame size.
For simplicitly let's say we have a TCP max. payload size of 1500 bytes, and a HTTP request of 500 bytes header data (plus separator) and a body of another 2000 bytes, so a request of 2500 bytes total. The client's TCP stack splits this HTTP request into two TCP frames:
0      500    1000   1500   2000   2500
:      :      :      :      :      :
+------+---------------------------+
|Header|           Body            |
+------+---------------------------+
+--------------------+-------------+
|    TCP frame 1     | TCP frame 2 |
+--------------------+-------------+

TCPConnection.on_data_http() gets called for each TCP frame received from the originating client. The condition that checks if we have received all headers becomes true with the first TCP frame. When TCPConnection.on_data_http() gets called again later with the second frame, what part of the code handles that? Note that the fetch() transaction has already started at this point.

Thank you for your clarification, probably checking Content-Length is worth it, I will investigate that in my free time.

@SuperMaxusa It's good to merge from my point of view, any objections?

It's good to merge from my point of view, any objections?

Ok, I have no objections.
@chschnell Do you have any suggestions? How about an idea to create an issue from your comment about HTTP request on multiple TCP frames?

Merci!

It's good to merge from my point of view, any objections?

Ok, I have no objections. @chschnell Do you have any suggestions? How about an idea to create an issue from your comment about HTTP request on multiple TCP frames?

It's fine, it can wait.

@copy I am very sorry but I just noticed that I broke the cors_proxy member in FetchNetworkAdapter, I'd need to fix a single line in fetch_network.js. What should I do, is a quick PR ok?


EnrollmentRequestApproval schema

@mangelajo LGTM, except it would have been nice to have had a separate PR for adding the labels… and then doing so as part of the Resource struct and making the labels available to the other resource kinds, too.
Was there a specific reason you didn’t put it into the Resource struct?

@mangelajo LGTM, except it would have been nice to have had a separate PR for adding the labels… and then doing so as part of the Resource struct and making the labels available to the other resource kinds, too.
Was there a specific reason you didn’t put it into the Resource struct?

As we talked in slack, making the indexing of the different resources generic enough was taking me too much thinking. I will handle in follow up.

fixed a missing change in the cmdline https://github.com/flightctl/flightctl/compare/74184aa..0a8a7c7084a0ae656ee2fd6449318a1f534b24e9
Merging as per slack conversation


Investigate bionic reference in Ubuntu apt sources

roles/common/templates/ubuntu.j2 specifies bionic on line 16. We should investigate if that should be templated to the current OS version, or needs to be pinned.

As the git blame-ee for this, I feel I should accept responsibility. This was added in 0a6b59c7/#176. I am pretty sure it should use {{ ubuntu_release }} like the other entries do. I believe hard-coding to bionic was an oversight.


[FIX] compatibility pos_order_cancel with pos_orderline_absolute_discount

@GabbasovDinar there are some lint errors to be fixed

@ilmir-k DONE


Qubes TemplateVM stops at login

On starting up a patched TemplateVM, it stays in the starting-up state forever, and applications started from dom0 will not appear. Examining the logs shows that it requires a log in:
...
[.[32m  OK  .[0m] Started Qubes misc post-boot actions.
[.[32m  OK  .[0m] Reached target Multi-User System.
         Starting Update UTMP about System Runlevel Changes...
[.[32m  OK  .[0m] Started Update UTMP about System Runlevel Changes.
[    2.990432] grsec: denied priority change of process (rtkit-daemon:783) by /usr/lib/rtkit/rtkit-daemon[rtkit-daemon:783] uid/euid:113/113 gid/egid:123/123, parent /lib/systemd/systemd[systemd:1] uid/euid:0/0 gid/egid:0/0

Debian GNU/Linux 8 debian-8-coldkernel hvc0

debian-8-coldkernel login:

The instructions for a Qubes TemplateVM should probably be adapted to skip this, since it becomes unusable after the shutdown (one can still enter the VM console by using sudo xl console [vmname]).
PS: This is not an April Fool. ^^

The same here: tried several times in the Qubes-supplied Debian 8 template, and also when upgraded to Debian 9.
This issue happens with the kernels newer than 4.8.17.
The 4.8.17 version builds, installs and works seemingly OK.
Every time it happens, there is a preceding error message during the kernel installation process. Specifically, during "sudo make install-deb", while  "setting" of the image operation.
The two "Issue #52" lines added to the coldkernel.config file before building, although it doesn't affect the outcome of this issue.
On a side note, the "Fix sources.list" portion in the kernel build instructions should be corrected:
The
deb http://httpredir.debian.org/debian jessie main contrib non-free
deb-src http://httpredir.debian.org/debian jessie main contrib non-free
doesn't fetch right and could be replaced with:
deb http://deb.debian.org/debian stretch main contrib non-free
deb-src http://http.debian.net/debian stretch main contrib non-free

P.S. Sorry I typed "stretch" in the suggested repositories above. Meant "jessie". :-)

A workaround is in https://github.com/coldhakca/coldkernel/issues/55 but an updated qubes-vm-kernel-support package with an updated u2mfn.c file for kernels 4.9 and higher has finally been pushed out and you'll need to install it on every template VM that you'll want to run the coldkernel on. Right now, it can be found in the current-testing repository so you'll need to temporarily enable it in order to access it. Otherwise, it should be pushed into the stable repository in a week or so (I hope, anyways).


Update capture-image-resource.md

Sysprep requires to disable encryption, and disabling bitlocker from Guest OS causes more issues. The encryption should be disabled from Azure end. The higher level commands not only unencrypt the disk from within the VM, but outside of the VM they also update important platform level encryption settings and extension settings associated with the VM.

@chakra146 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off Thank you!


Fix coefficients in expm helper function

According to Higham 2005, the leading term of the backward error function of the [m/m] Padé approximant of the exponential function is x^{2m+1}. Its corresponding coefficient is C_{2m+1} = (m!)^2 / ( (2m)! * (2m+1)!), cf. Equations (2.2) and (2.6) in said reference.
So far, the code didn't compute C_{2m+1}, but replaced m <- 2m + 1, which is probably due to the literature's somewhat surprising notation (cf. the index i = 2m + 1 in Equation (2.6)).
Al-Mohy and Higham 2009 actually have a Matlab reference implementation available, where they hard-code the cofficients, which are reproduced verbatim below. Using m instead of m <- 2m + 1, as is currently done, exactly reproduces these coefficients:
% Coefficients of leading terms in the backward error functions h_{2m+1}.
Coeff = [1/100800, 1/10059033600, 1/4487938430976000,...
         1/5914384781877411840000, 1/113250775606021113483283660800000000];

Any way to move this forward? I am cannot assess how bad this incorrect factor is, but given that a probably non-trivial number of people is using matrix exponents in scipy, I would love to get this fixed (or assess the severity of this issue, if somebody has that ability).

Re the unit tests:
As I wrote, I cannot assess the severity of this error. I can only state that a) scipy's expm claims to be an implementation of Al-Mohy and Higham 2009, and b) that it is an incorrect implementation according to their paper and the ones cited. Given the approximate nature of this algorithm we would need to establish an error bound that is not fulfilled by the current implementation but should be fulfilled by the reference implementation. I do not have the sufficient understanding of what's going on here to provide this expertise myself.
Right now, the unit tests available for scipy's expm itself are only testing trivial cases. Furthermore, I do not see how unit tests are useful here. If you want, I can write unit tests with the mathematically correct values, but that seems to be circular.
Re licensing:
I do not quite understand your point. In how far is their code used to fix scipy's code? Scipy implements the actual equations in the cited papers, with my fix calculating the same numbers that the matlab script hardcodes. There is no sharing of code, no reimplementation, not even a derivation of work. The calculation of the correct terms in the error function of the Padé approximants I did a) by hand and b) by implementing them in a script. I have crosschecked the correctness of my factors by comparing them with the matlab code above. The matlab code itself was published alongside their paper, see the preprint server of Manchester University: http://eprints.maths.manchester.ac.uk/1442/
Steps forward:
The code is mathematically incorrect. You can follow the derivation of the coefficients in the papers cited. Gautschi 2012 is also useful to read here.
Scipy should either not mention that they implement Al-Mohy and Higham 2009, or alternatively specify that the implementation is probably not correct and warn people from using it.

If you want, I can write unit tests with the mathematically correct values, but that seems to be circular.

agreed

There is no sharing of code, no reimplementation, not even a derivation of work. .....  I have crosschecked the correctness of my factors by comparing them with the matlab code above. The matlab code itself was published alongside their paper

this is all fine, thanks for clarifying

The code is mathematically incorrect.

yes, this PR should be okay as is. While this is a bugfix and we can therefore change the code, we should put a note in the 1.3.0 release notes when this PR is merged. Other than that, this just needs review. Unfortunately the expm expert we had went MIA. This should not be too hard to review though, since it's only a couple of line of code.
I'll mark it for the next release; if no one has reviewed in 1-2 weeks I'll get to it at some point (no time now, sorry).

we would need to establish an error bound that is not fulfilled by the current implementation but should be fulfilled by the reference implementation

I don't get how this wouldn't be useful. Maybe it is hard to do, and maybe the PR is fine as is, but certainly not ideal to not have a regression guard for something that is mathematically incorrect.

we would need to establish an error bound that is not fulfilled by the current implementation but should be fulfilled by the reference implementation

I don't get how this wouldn't be useful. Maybe it is hard to do, and maybe the PR is fine as is, but certainly not ideal to not have a regression guard for something that is mathematically incorrect.

Oh, better unit tests would definitely be useful! I just don't know how to approach this, because I would need a much deeper understanding of the methods involved.
Maybe you can open an issue separate from this PR and share your thoughts on how to approach this? It would definitely be nice to see a unit test on expm which is directly affected by the wrong calculation of the error Padé coefficients. I would be very interested in that!

Makes sense -- I'll think about this a bit!

@SuperFluffy Thanks! Can you add a release note to: https://github.com/scipy/scipy/pulls?q=is%3Aopen+is%3Apr+milestone%3A1.3.0

@tylerjereddy Awesome that this got merged, makes me very happy!
It looks like I cannot assign labels/milestons to issues. I guess I don't have the rights. :) Can you do that for me? Here is the associated issue: #10074

It looks like I cannot assign labels/milestons to issues. I guess I don't have the rights. :) Can you do that for me? Here is the associated issue: #10074

done

I hope that that's what you meant me to do.

No the link was wrong. Tyler's question was to add a note to https://github.com/scipy/scipy/wiki/Release-note-entries-for-SciPy-1.3.0#scipysparse-improvements. I'm not sure that this is relevant for users though, since it's not clear how this is relevant to an end user of expm in a practical sense. So I suggest to leave it.

I'm not sure that this is relevant for users though, since it's not clear how this is relevant to an end user of expm in a practical sense. So I suggest to leave it.

It would indeed be interesting to ask users who rely heavily on expm to check if they observe any differences in their calculations before and after the fix.

That's a good idea - more a question for the mailing list than the release notes though. If you would want to write a message to scipy-user, that would be helpful


Create VI Editor.md

Hello @rohang14
Thanks for your contribution.
Let's connect ->
GitHub -> @Suryansh1720001 (Follow)
LinkedIn -> https://www.linkedin.com/in/suryanshprajapati17
Also, Star the repo ⭐


Question about Bpytop . . .

It is possible to return the Bpytop package to your repository ?
Because now it seems that it has been deleted

邮件已收到，我会尽快回复

Sorry, I did not understand!
Can you please answer my question?

@kenzok8
Can you please answer my question?


#69 breaks configs with output.file

Error: You must set either "output.file" for a single-file build or "output.dir" when generating multiple chunks.

With what version of Rollup? Also, could you share what the output object actually looks like?
(Does this mean anything to you @ntkme?)

We can set output.dir only when user did not explicit set output.file or output.dir. I'm preparing a PR.


Possibility to add images to tables

Description
The goal would be to add images in a Taipy table. (This was asked by a user)
Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%.
[ ] Propagate any change on the demos and run all of them to ensure there is no breaking change.
[ ] Ensure any change is well documented.

Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

syntax is similar to button : the text value of the cell should be [img:<URL>](value)
value is used as alt text for image.


v1.3.0 failure mounting NFS volume

Hyperkube v1.2.4_coreos.1 is working great. After moving to v1.3.0_coreos.1 Kubelet fails whenever I deploy a RC that mounts a NFS volume. Message on Kubelet log:
Output: mount.nfs: rpc.statd is not running but is required for remote locking.

Old CoreOS image. Updated to 1081.3.0 (current beta) and the problem disappeared.


Update how-to-run-jupyter-notebooks.md

Since Azure ML notebooks support both python and R, it's not Python Notebook, it's Notebook

@eldarkt : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add mc-backup Sidecar

Add mc-backup sidecar for minecraft-server.
Ready for testing:

tar

Tested:

[x] tar method
[ ] rclone method
[ ] restic method

Not 100% complete...

TODO:

Restic environment variables
rclone config file

Solves #91

is there any interest in rclone or restic for the chart?

is there any interest in rclone or restic for the chart?

People use those methods, but can be included in a follow up PR.

is there any interest in rclone or restic for the chart?

People use those methods, but can be included in a follow up PR.

in theory restic is done, but i don't know how to test it.  rclone i need to add a config map for.

Please take a look at the build failure.

will do

@itzg I think this now adds restic, and rclone capabilities, i didn't test it tho.  tar still works, linting should pass.

3rd time the chart?

@merkinbob I will attempt to test rclone.

@merkinbob I am getting the following error on container startup:
time="2022-01-11T18:06:19Z" level=fatal msg="Failed to run sub-command" error="fork/exec /usr/bin/backup: operation not permitted"

I have RCON in the server. I am setting no other values for mcbackup other than enabled: true.
Do you perhaps know what could be causing it?

@merkinbob I am getting the following error on container startup:
time="2022-01-11T18:06:19Z" level=fatal msg="Failed to run sub-command" error="fork/exec /usr/bin/backup: operation not permitted"

I have RCON enabled in the server. I am setting no other values for mcbackup other than enabled: true.
Do you perhaps know what could be causing it?

my guess is it's not happy with empty dir for the backup volume.  let me check the deployment.yaml file a bit.
Below is all i have set in my values.yaml file for my argocd deployment.
mcbackup:
  enabled: true

  persistence:
    storageClass: "csi-cephfs-sc"
    backupDir:
      enabled: true
      Size: 500Gi

Final review looks great! Ready for a merge?

one concern I have about restic is the HOSTNAME note on your mc-backup docs.  Other than that, I think this is a good start.  I hope someone finds this useful.

Just discovered there's a --hostname. I wrote up https://github.com/itzg/docker-mc-backup/issues/55 , but I think the chart changes will be good even with that.


Remove global fetch prerendering override

Describe the problem
This code... https://github.com/sveltejs/kit/blob/779d57524e0734765c2399929c3b38397c3fdcf6/packages/kit/src/core/prerender/prerender.js#L105-L156 ...was added in https://github.com/sveltejs/kit/pull/5627 to make it possible for apps to fetch from themselves during prerendering.
Now that fetch is part of RequestEvent and can therefore be used in +server.js handlers and server-only load functions, I'm pretty sure we can get rid of it.
Describe the proposed solution
Delete the code
Alternatives considered
If we want to be really nice we could try and detect cases where people are doing fetch(event.url.origin + '/...') and tell them to use event.fetch('/...') instead
Importance
nice to have
Additional Information
No response

This would be a breaking change, right? (The global fetch wouldn't mark dependencies like this one would.) I do think we should do this, so we should get it in before 1.0. I think we should put in a warning about using event.fetch instead, but I think it can probably be removed for 1.0.

Playing devil's advocate here: What are the advantages of removing this from a user perspective? I can only think of "doesn't have to prepend the URL origin", so they trade one load argument for another. Are there others? Want to make sure we're not only doing that for our own good, but also the user's good.


[FEATURE REQ] Create a bonus guide for alternative hardware/OSes

What & why
As Raspberry Pis have become expensive, more and more users are looking into cheap alternative platforms to run their Bitcoin and Lightning nodes.
Also, some users might want better hardware to run a more performant routing node.
Although, the guide is mostly compatible with any Debian-based OSes, a few things have to be considered when setting up and running a node on an alternative hardware and OS.
A poll  on the TG group shows that such a guide would be welcomed by our community:

How
The bonus guide could have the following goals:

A list of suggested alternative hardware (e.g. refurbished ThinkPad)
A list of suggested OSes (e.g. Ubuntu Server, etc)
A list of guidelines on how to adapt the RaspiBolt guides to alternative hardware (e.g. check CPU architecture, select appropriate binary release etc)
Some tips on how to select the appropiate specs (CPU, RAM, SSD type, RAID) for one's own needs (budget? is it for a routing node? small or large node? is power consumption important? etc)

This Raspiblitz guide  is a great resource we could use for inspiration.

To add:

Need to create the "admin" user on some OSes (e.g. Ubuntu, see issue  here)

I'd like to cosign this idea as I had a similar thought. installing debian on a old laptop or desktop computer should be able to follow the same instructions.
But it's not clear in the guide that using other hardware is a viable option for end users. It would help if this were added as a note.

Hi! A have a personal adaptation called MiniBolt in a separate repo, check out this:
https://github.com/twofaktor/minibolt
https://twofaktor.github.io/minibolt
We could collaborate together with different new guides/features, in addition, to integrating both guides as bonus guides 🤝


added opencollective-postinstall

This will show after npm install preact or yarn add preact

Coverage remained the same at 97.695% when pulling 36b02704413a79eefc28be133c8acc02a50d77e6 on xdamman:opencollective into 6c7e70c734a91141e60a2dcb1711acba73731fcc on developit:master.

Awesome 💃
Is 40 the optimal height?

Yes, I tried a bunch, feel free to try different sizes / variants:
curl "https://opencollective.com/preact/logo.txt?height=40&variant=blocks&reverse=true"

See also docs on https://github.com/opencollective/opencollective-postinstall

Coverage remained the same at 97.695% when pulling 281b5728e4338d9d7df6da9ecc9df424e3243873 on xdamman:opencollective into 6c7e70c734a91141e60a2dcb1711acba73731fcc on developit:master.

FYI, I've added a  || exit 0 at the end of the scripts.postinstall in package.json to make sure it doesn't return an error on production where devDependencies are not installed (and therefore the scripts ./node_modules/.bin/opencollective-postinstall doesn't exist).
The other option would have been to move opencollective-postinstall to dependencies but I think it's less elegant than this solution.

Makes sense!

@developit any idea why travis-ci tests didn't pass? How can we restart it?
Here is the error:
/home/travis/build/developit/preact/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Bad response: 504 <!DOCTYPE html>

The command "./node_modules/coveralls/bin/coveralls.js < ./coverage/lcov.info" exited with 1.
cache.2
store build cache
0.01s
24.96schange detected (content changed, file is created, or file is deleted):
/home/travis/build/developit/preact/node_modules/external-editor/example_async.js
/home/travis/build/developit/preact/node_modules/external-editor/example_sync.js
/home/travis/build/developit/preact/node_modules/external-editor/LICENSE
/home/travis/build/developit/preact/node_modules/external-editor/main/errors/CreateFileError.js
/home/travis/build/developit/preact/node_modules/external-editor/main/errors/LaunchEditorError.js
/home/travis/build/developit/preact/node_modules/external-editor/main/errors/ReadFileError.js
/home/travis/build/developit/preact/node_modules/external-editor/main/errors/RemoveFileError.js
/home/travis/build/developit/preact/node_modules/external-editor/main/index.js
/home/travis/build/developit/preact/node_modules/external-editor/node_modules/tmp/lib/tmp.js
/home/travis/build/developit/preact/node_modules/external-editor/node_modules/tmp/LICENSE
/home/travis/build/developit/preact/node_modules/external-editor/node_modules/tmp/package.json
/home/travis/build/devel
...
changes detected, packing new archive
.
.
.
uploading archive
Done. Your build exited with 1.

Travis is having issues today.

Tests passed! 👍
What's the process from here?

Now... we merge ;)

Ran the curl command listed above & it killed my terminal. I'm in favor of this post-install message, but hoping that behavior isn't a part of the package.

@lukeed 🤔 what terminal are you using? On Windows? Mac? Linux?

@xdamman iTerm2 (3.0.12) on OSX, running oh-my-zsh

I made a bunch of changes to make this more reliable. We now have proper test coverage, including on Windows environment.
@developit should I do another PR?
Alternatively, we can also just add directly a line in the post install like we did for Bower:
"postinstall": "echo -e \"\nThanks for downloading Preact.\nPlease consider donating to our open collective\n=> https://opencollective.com/preact/donate\n\""

@xdamman the basic postinstall echo might make a good first test of this. Want to PR it?

Mmmm... it's actually not that pretty because npm shows the command and then executes it:

So the only way I see to make something more elegant is to add as a dependency a separate executable that will print that message. Either I add it directly to the repo or we add it as a dependency (then we are back to adding "opencollective-postinstall" and that would be your only dependency).

Or, we could add a DONATE.md and as a post install cat DONATE.md

Any other idea?

What about something like this?
"postinstall": "npm run -s donate"
"donate": "echo -e \"\nThanks for downloading Preact.\nPlease consider donating to our open collective\n=> https://opencollective.com/preact/donate\n\""

That's a great idea! PR here: https://github.com/developit/preact/pull/661


I get this error when I use this theme

Warning: React does not recognize the listIndex prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase listindex instead. If you accidentally passed it from a parent component, remove it from the DOM element.
in div (created by MinimalThemeTreeNodeRenderer)
in MinimalThemeTreeNodeRenderer (created by DropTarget(MinimalThemeTreeNodeRenderer))
in DropTarget(MinimalThemeTreeNodeRenderer) (created by Grid)
in div (created by Grid)
in div (created by Grid)
in Grid (created by List)
in List (created by Scrolling(List))
in Scrolling(List) (created by AutoSizer)
in div (created by AutoSizer)
in AutoSizer (created by ReactSortableTree)
in div (created by ReactSortableTree)
in ReactSortableTree (created by DragDropContext(ReactSortableTree))
Any way I can solve this?

@JithinKS97 I will take a look at it today and do a patch, thanks for the find!

@JithinKS97, the issue was in the older version of the react-sortable-tree and not the actual theme itself... I will do an upgrade to see if it fixes things but I would suggest using the latest react-sortable-tree and create a case in that project if it still persists

I git cloned this project and ran npm install, then npm start. This error is there too.
warning.js:33 Warning: React does not recognize the `listIndex` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `listindex` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in div (created by MinimalThemeTreeNodeRenderer)
    in MinimalThemeTreeNodeRenderer (created by DropTarget(MinimalThemeTreeNodeRenderer))
    in DropTarget(MinimalThemeTreeNodeRenderer)
    in div (created by Grid)
    in div (created by Grid)
    in Grid (created by List)
    in List (created by Scrolling(List))
    in Scrolling(List) (created by AutoSizer)
    in div (created by AutoSizer)
    in AutoSizer (created by ReactSortableTree)
    in div (created by ReactSortableTree)
    in ReactSortableTree (created by DragDropContext(ReactSortableTree))
    in DragDropContext(ReactSortableTree) (created by App)
    in div (created by App)
    in div (created by App)
    in App
    in AppContainer
printWarning @ warning.js:33
warning.js:33 Warning: React does not recognize the `treeId` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `treeid` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in div (created by MinimalThemeTreeNodeRenderer)
    in MinimalThemeTreeNodeRenderer (created by DropTarget(MinimalThemeTreeNodeRenderer))
    in DropTarget(MinimalThemeTreeNodeRenderer)
    in div (created by Grid)
    in div (created by Grid)
    in Grid (created by List)
    in List (created by Scrolling(List))
    in Scrolling(List) (created by AutoSizer)
    in div (created by AutoSizer)
    in AutoSizer (created by ReactSortableTree)
    in div (created by ReactSortableTree)
    in ReactSortableTree (created by DragDropContext(ReactSortableTree))
    in DragDropContext(ReactSortableTree) (created by App)
    in div (created by App)
    in div (created by App)
    in App
    in AppContainer

fixed

Looking forward to this being released

Following up @JithinKS97 , think we can merge this soon?

@monarchjhaveri, @JithinKS97 it should be fixed

I'll double-check this and make appropriate changes as well as check against the latest changes on the actual library


[Perf] Add support for int comparisons in StatefulExpression.EvalBool

Hi,
While adding the benchmarks to AlertNode (see #407 ), I found out the EvalPredicate is a tiny bottleneck,
so I dug into this, and found out that StatefulExpression dosen't support int comparison so I added it and it improved the perf a bit ;)
StatefulExpression EvalBool benchmarks:
benchmark                             old ns/op     new ns/op     delta
Benchmark_EvalBool_1ScopeItem-4       3069          3033          -1.17%
Benchmark_EvalBool_11_ScopeItem-4     3043          2708          -11.01%

benchmark                             old allocs     new allocs     delta
Benchmark_EvalBool_1ScopeItem-4       4              4              +0.00%
Benchmark_EvalBool_11_ScopeItem-4     4              4              +0.00%

benchmark                             old bytes     new bytes     delta
Benchmark_EvalBool_1ScopeItem-4       64            64            +0.00%
Benchmark_EvalBool_11_ScopeItem-4     64            64            +0.00%

Alert benchmark:
benchmark                            old ns/op       new ns/op       delta
Benchmark_T10_P500_AlertTask-4       145918779       143226340       -1.85%
Benchmark_T10_P50000_AlertTask-4<PHONE_NUMBER>6<PHONE_NUMBER>1     -4.69%
Benchmark_T1000_P500_AlertTask-4<PHONE_NUMBER>4<PHONE_NUMBER>0     -14.24%

benchmark                            old allocs     new allocs     delta
Benchmark_T10_P500_AlertTask-4       466191         466201         +0.00%
Benchmark_T10_P50000_AlertTask-4     47548950       47548763       -0.00%
Benchmark_T1000_P500_AlertTask-4     46101716       46098518       -0.01%

benchmark                            old bytes      new bytes      delta
Benchmark_T10_P500_AlertTask-4       32825881       32826965       +0.00%
Benchmark_T10_P50000_AlertTask-4<PHONE_NUMBER><PHONE_NUMBER>     -0.00%
Benchmark_T1000_P500_AlertTask-4<PHONE_NUMBER><PHONE_NUMBER>     -0.03%

Those benchmarks are compared to the master (the edge buffer size is the default value)

@yosiat I am a little confused:
Int comparisons worked before but were always casted to floats if one of the operands was a float. Is the PR to add new functionality or show that by not casting to float and doing direct integer comparisons things are faster?

@nathanielc It started by reading the code of evalBinary and found out there is cast to float64 even when both sides are int64, so I changed this for clarity, I found this very confusing.
And then I checked out the performance, and as we can see it improved.
The initial purpose was to improve performance.

The initial purpose was to improve performance.

Ok, makes sense.

@yosiat With the other work you are doing should we close out this PR since most of it will be replaced?

@nathanielc I think we should merge this PR, because we don't know when we will finish the "specialization" pr and this pr yields some nice perf improvement.

@nathanielc I am closing this PR, since I will do this improvement on the typed stack approach (I will submit for this today/tomorrow)

@nathanielc What is the status of this PR? I think we should merge it..

I think its ready, but first lets merge #458 since its now has tests for this change. Then a rebase to see we are green and this should be good to go.

@nathanielc I squashed :+1:
By the way, those are the results for this change on the new benchmarks that I am working on (https://github.com/yosiat/kapacitor/commit/50a94c906a93b984d2449e45646492acae3009d4):
name                                                                   old time/op    new time/op    delta
_EvalBool_OneOperator_NumberFloat64_NumberInt64-4                        1.85µs ± 0%    1.66µs ± 0%  -10.26%
_EvalBool_OneOperator_NumberInt64_NumberInt64-4                          1.64µs ± 0%    1.63µs ± 0%   -0.43%
_EvalBool_OneOperator_ReferenceNodeFloat64_NumberInt64-4                 2.00µs ± 0%    1.93µs ± 0%   -3.65%
_EvalBool_OneOperator_ReferenceNodeInt64_ReferenceNodeInt64-4            1.94µs ± 0%    2.02µs ± 0%   +4.34%
_EvalBool_OneOperatorWith11ScopeItem_ReferenceNodeInt64_NumberInt64-4    2.12µs ± 0%    2.20µs ± 0%   +3.78%

name                                                                   old alloc/op   new alloc/op   delta
_EvalBool_OneOperator_NumberFloat64_NumberInt64-4                         80.0B ± 0%     80.0B ± 0%   +0.00%
_EvalBool_OneOperator_NumberInt64_NumberInt64-4                           80.0B ± 0%     80.0B ± 0%   +0.00%
_EvalBool_OneOperator_ReferenceNodeFloat64_NumberInt64-4                  64.0B ± 0%     64.0B ± 0%   +0.00%
_EvalBool_OneOperator_ReferenceNodeInt64_ReferenceNodeInt64-4             64.0B ± 0%     64.0B ± 0%   +0.00%
_EvalBool_OneOperatorWith11ScopeItem_ReferenceNodeInt64_NumberInt64-4     64.0B ± 0%     64.0B ± 0%   +0.00%

name                                                                   old allocs/op  new allocs/op  delta
_EvalBool_OneOperator_NumberFloat64_NumberInt64-4                          5.00 ± 0%      5.00 ± 0%   +0.00%
_EvalBool_OneOperator_NumberInt64_NumberInt64-4                            5.00 ± 0%      5.00 ± 0%   +0.00%
_EvalBool_OneOperator_ReferenceNodeFloat64_NumberInt64-4                   4.00 ± 0%      4.00 ± 0%   +0.00%
_EvalBool_OneOperator_ReferenceNodeInt64_ReferenceNodeInt64-4              3.00 ± 0%      3.00 ± 0%   +0.00%
_EvalBool_OneOperatorWith11ScopeItem_ReferenceNodeInt64_NumberInt64-4      4.00 ± 0%      4.00 ± 0%   +0.00%

I compared using benchstat instead of benchcmp

I am closing this pull request because I am going to submit another pull request that improve performance vastly.
After the another pull request will get merged we can decide if we want this pull request.


chore: Fix OIDC connection with AWS using a fingerprint

Please provide the issue number

Issue number: #321
Summary
Certificate issues with OIDC connection with AWS using a fingerprint
github.blog/changelog/2023-06-27-github-actions-update-on-oidc-integration-with-aws
Changes

Please provide a summary of what's being changed

update fingerprint from e1e17a757e536f70e52b5a12b2e8d1d1c60e04ef to 6938fd4d98bab03faadb97b34396831e3780aea1
User experience

Please share what the user experience looks like before and after this change

Checklist
Please leave checklist items unchecked if they do not apply to your change.

[x] Meets tenets criteria
[x] I have performed a self-review of this change
[ ] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

This change is not needed. OIDC fixed on AWS side


Demo app text box fails to bring up iOS keyboard

Attempting to use demo app at
https://emilk.github.io/egui_template/
and edit the text box results in no virtual keyboard being displayed, even though text box has focus and cursor within the text.
Using iOS 14.3 on iPhone XR, but also verified same results on iPhone 12 with iOS 14.4

Thanks for the report!
This is a known shortcoming in egui_web but appearantly I haven't opened a ticket for it, so I did so now: https://github.com/emilk/egui/issues/147

Thanks for the report!
This is a known shortcoming in egui_web but appearantly I haven't opened a ticket for it, so I did so now: https://github.com/emilk/egui/issues/147


VP9 WebRTC

Includes link to demo to be hosted on https://github.com/GoogleChrome/samples (see https://github.com/GoogleChrome/samples/pull/292/files).
See issue https://github.com/google/WebFundamentals/issues/2467.
@PaulKinlan @jpmedley PTAL

@petele as FYI.

It has been reviewed.


Substrait: Add cast expression with bool, integers and decimal128 support

Which issue does this PR close?

Closes https://github.com/apache/arrow-datafusion/issues/5136
Rationale for this change
To add (partial) support for Expr::Cast in Substrait producer/consumer.

What changes are included in this PR?

Support for casting to:

Boolean
Int8, Int16, Int32, Int64
Decimal128

Tests

Casting decimal literal to integer
Casting decimal column to integer

Are these changes tested?
Yes. (decimal -> integer)

Are there any user-facing changes?
No

Marking this PR as draft while waiting on a response to @andygrove 's comments

Note: Forced push after rebasing


Infinite Load Times and REST API Self Link Mismatches Causing Frontend Sluggishness in DSpace

Describe the bug
When using DSpace as a logged-in administrator and particularly when navigating the "Edit Item" tab(s) (or even just clicking "Edit Item"), we experience persistent issues with infinite load times and sluggishness in the DSpace frontend. Often this will require the user (admin) to refresh more than once to get the frontend to work.
Back in August, I submitted issue #3252 (potential duplicate of #2924) which was about the DSpace frontend web browser hanging and crashing when viewing src/app/item-page/versions/item-versions.component.html. @alexandrevryghem implemented a solution in this PR here https://github.com/DSpace/dspace-angular/pull/3253 and I copied and pasted his changes into my item-versions.component. This solved the "hanging" issue but now I suspect that this fix is potentially playing some role in my current predicament. From the DevTools console, I can tell that numerous REST API request/response mismatches are occurring, particularly related to self links in the API responses:
The response for 'https://pedsdspaceprod.research.chop.edu/server/api/versioning/versionhistories/25/versions?page=0&size=10' has the self link 'https://pedsdspaceprod.research.chop.edu/server/api/versioning/versionhistories/25/versions?page=0&embed=item&embed=eperson&size=10'. These don't match. This could mean there's an issue with the REST endpoint

In addition, I am also gettin this error, though I don't necessarily think it's relevant:
cannot deserialize type systemwidealert
Can't cache incomplete systemwidealert: null, parsed from (partial) response: {"alertId":1,"message":"Please note that PEDSnet is currently under construction.","allowSessions":"all","countdownTo":null,"active":true,"type":"systemwidealert","_links":{"self":{"href":"https://pedsdspaceprod.research.chop.edu/server/api/system/systemwidealerts/1"}}}

Occasional Solr errors too, though these are more sporadic and might also not have to do with this problem.
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89) ~[httpclient-4.5.14.jar!/:4.5.14]
...
at org.dspace.qaevent.service.impl.QAEventServiceImpl.findSource(QAEventServiceImpl.java:528) ~[dspace-api-8.0.jar!/:8.0]
... 209 more

Environment:
DSpace Version: 8.0
Frontend Framework: dspace-angular (specific branch: https://github.com/alexandrevryghem/dspace-angular/commit/d09f5297a1f4e36071494bd89dc462b7538b3474)
Solr Version: 8.11.3
Web Browser: Google Chrome <IP_ADDRESS> on macOS
Additional Context: The issue appears to be related to self-referencing entities and REST API endpoint discrepancies. I have also made a number of changes to the DSpace frontend which are not accounted for here, but nothing pertaining to the API call-and-response. I also am not sure if this is more of a backend or frontend issue and I would be happy to migrate this ticket.
To Reproduce
Steps to reproduce the behavior:

Check out d09f5297a1f4e36071494bd89dc462b7538b3474 (again, maybe source of the issue, though I don't know)
Try editing items. It might not happen right away; it is occasional. But sometimes it is unrelenting and recurrent.

Expected behavior
The frontend does not hang when "Edit Item" is navigated.
Related work

d09f5297a1f4e36071494bd89dc462b7538b3474
#3252
https://github.com/DSpace/dspace-angular/pull/3253
#2924
https://github.com/DSpace/DSpace/issues/9879 (backend issue I opened before I had a better understanding of the issue)

Actually, now I'm starting to think it has to do more with this Solr exception.
2024-10-10 14:10:22,015 ERROR a4fd2fb0-7be3-4b69-bce3-7d91ef6d3211 be8bc100-a08f-4ade-a3e0-7b30c5900de8 org.dspace.app.rest.exception.DSpaceApiExceptionControllerAdvice @ An exception has occurred (status:500)
java.lang.RuntimeException: Server refused connection at: http://localhost:8983/solr/qaevent
        at org.dspace.qaevent.service.impl.QAEventServiceImpl.findSource(QAEventServiceImpl.java:541) ~[dspace-api-8.0.jar!/:8.0]
...

The Solr core qaevent is accessible and seems to be working fine when I port forward.

Moving this to DSpace backend here: https://github.com/DSpace/DSpace/issues/9884


Packwiz doesn't delete removed mods

When I delete the metafile for a mod from the mods dir, refresh packwiz, and run packwiz-bootstrap, it still downloads the newly added mods, but doesn't delete the removed mods.
I'm not sure what changed, since this was working just fine a few months ago. I also looked through the wiki to see if there was a change in how non-indexed mods were handled, but I couldn't find anything.

Did you delete the packwiz.json file? packwiz-installer needs this to remember which files were downloaded as part of the pack and should be removed if they are removed from the pack.

No, I haven't deleted any files.

I can't seem to replicate this issue.. could you send your pack, or another pack (before and after removing a file) that causes this behaviour?

I accidentally nuked my device, so I can't help with this anymore.
The next time this happens, I'll open a new issue with more information.
But I've taken a break from maintaining MC modpacks, since the people they were for have lost interest in playing MC, as such, I doubt I'd have any helpful information anytime soon.


Skip second argument in React.createElement()

Do you want to request a feature or report a bug?
A feature
What is the current behavior?
React.createElement(component, props, children), when props aren't needed, you still have to pass null or {} as a second argument.
What is the proposal?
Being allowed to omit the second argument, allowing this:
import React from 'react'
import Foo from './Foo'
import Bar from './Bar'

const o = React.createElement

const App = () =>
  o('div',
    o('h1', 'Hello'),
    o(Foo),
    'Ok!',
    o('p', 'How are you?'),
    o(Foo,
      o(Bar, { key: 'hi' },
        o('span', 'Heya!')
      )
    )
  )

Demo code?
I currently, very naively, use this:
function o () {
  var argumentsArray = Array.from(arguments)
  var x = argumentsArray[1]
  if (typeof x === 'string' || typeof x === 'number' || Array.isArray(x) || (typeof x === 'object' && Object.keys(x)[0] === '$$typeof')) {
    argumentsArray.splice(1, 0, {})
  }
  return React.createElement.apply(this, argumentsArray)
}

How can it possibly be a bug?
Here is user space solution:
const h = React.createElement;

React.createElement = (type, props, ...children) => {
  if (typeof props !== 'object') {
    children = [props, ...children];
    props = {};
  }

  return h(type, props, ...children);
};

@streamich Thank you for your code:

typeof == 'object' does not distinguish between arrays and objects (both are true)
children can be an object as well
my own user space solution checks if the first key in the object is $$typeof
this is still very crude, could you improve my code?

@dantman hyperscript needs the children to be in an array, createElement doesn't, so using it actually adds a bit more overhead, that's why I'm looking to use createElement itself, or is it easy to turn off arrays in hyperscript somehow?

@Superpencil Seems like a pretty small difference, but it does look like there is an issue on the topic and there is a branch in the repo linked that implements the behaviour you want.
I'd think it would be easier to convince the library to implement the behaviour you want than to get React to change how the API works for a use case that React.createElement isn't intended for.

@dantman you're right, it's a small difference, I'll pursue the issue there, thank you!
@j-f1 Thank you! I was sharing my code in the hope someone would be able to point out some security issue :)


ENH Added evaluation

This PR is actually a fragment of #26 as #26 is a bit overwhelming. I changed the API and put evaluation a part of the Card class not to bother user with extra attributes.
@BenjaminBossan @adrinjalali

@merveenoyan Did you ping us because we should already take a look or just to let us know?

@BenjaminBossan I pinged you to mainly look at UX of the evaluation and let me know if the direction is right.

Hmm, not so much I can say about this yet. It is very specific to HF, right? E.g. IIUC we assume that the metric used by sklearn is the same as defined on HF/metrics.

@BenjaminBossan having metrics in metadata is essentially for HF Hub, it also passes them to paperswithcode to associated task on associated dataset. (let's say you have text-classification, you'd like to evaluate it on GLUE) this is not the case usually for tabular models imo as people split their data on their own. I don't expect heavy usage for this for when you put your model for outside world, if someone else wants to benchmark their own models and programmatically access the best metrics, it would be good IMHO.

Overall I'd say it's in the right direction. I would change it a bit so that the method accepts the results of a scorer instead of trying to get the name and call it itself. It can be simplified by accepting a float value and a metric name. We probably also want to have it more like:
data description: ...
   metric 1: ...
   metric 2: ...

instead of a list of (data description, metric specs) as is right now.
But it seems like the eval results can't support that?

@adrinjalali with #71 I think we can let the user add EvalResults instead, no?

Yeah that would also make sense. I'm impartial on whether to construct EvalResult inside a method or accept one from the user. Note that #71 doesn't really make user ever create a CardData object themselves, the utility function does that.

I would tend towards not exposing modelcards internals to the user.

BTW evaluation metrics can be seen in this repository:
https://huggingface.co/merve/hf_hub_example-d4b188ba-be75-44ed-9c2b-d2cd0640c233

@adrinjalali I addressed your comments.

@BenjaminBossan can you review?


Doc update (xyz -> ai)

Change xyz to ai.(in readme and docs.spice.ai)

Resolved by https://github.com/spiceai/spice.js/pull/101


Add option to split samples within a group into multiple core gene phylogenies if diverse enough

This splitting could be done based on the families found in the sendsketch results.
It would require plotting multiple phylogenies in a single report, similar to how the vcf snp trees will need to be handled.
We could even combine the trees into a single tree, using taxonomic relationships for the root nodes and coloring those parts of the tree differently.

This would involved changing the R script called by SUBSET_CORE_GENES so that it outputs multiple tables, one for each cluster.

This is done


chore: pass scenario parameters to the pipeline

This makes sure that the parameters provided via the params field of IntegrationTestScenarioSpec are passed to the derived PipelineRun.

Why chore: thought? I would say it's more of a fix:.

Thanks for fixing this one!

Why chore: though? I would say it's more of a fix:.

I wasn't sure if that was a bug. Could change it, not sure if release notes are generated from commit messages...


SPI with led WS2812

can you tell me if the SPI of the DTS file works with the WS2812 led, I have run another version of the dts that can run the led with spidev with gpio10 but can't turn off the led, only full light. even though the code has full command off led

Excuse me, I am not able to test it. I have no IC's for testing. Just you can let us know ... Please could you send me mentioned DTS file?

Please look at the https://github.com/mamin27/H616-mangopi/issues/4. It could help you.

I will wait for customer feedback.


Update split_one_chevs balancemode v2

Context
I played a game with split_one_chevs on and noticed a few issues. The 1Chevs were not split. This was because Macwhite was recognised by Teiserver as a 2Chev whereas Chobby showed them as a 1Chev. This is likely because Chobby gets a player's rank on login and then never updates it so they get out of sync with TeiServer.

How to resolve?
To resolve this my algorithm will now group both 1 and 2Chevs into the "Noob" bucket. There's also going to be slight change on how we draft players who are in the "Noob" bucket detailed below.
Other Findings
When putting the replay
https://www.beyondallreason.info/replays?gameId=39096966518c40a66b2130b057864aa5

into https://openskill-test.web.app/ I noticed that the library expects Team 1 to win, despite that most humans would bet on Team 2.

Since the library expects Team 1 to win, if my team were to win I would gain a lot of OS i.e. +1. If my team were to lose, I only lose -0.37.
From this we can conclude that if you were to choose from the three "Noobs": CindersFire, Macwhite, Victorious_Dead you probably want to avoid the overrated players, which are likely the ones with highest uncertainty. If an overrated player is on the other team, you stand to win more and lose less, and since they're overrated, you're also more likely to win. Therefore, for those in the "Noobs" category, we probably want to pick those with low uncertainty as they are less likely to be overrated.
split_one_chevs Algorithm v2
Based on these findings, the algorithm will now draft players based on these criteria:

Always pick experienced (3Chev+) players over noobs (1-2Chevs).
Prefer higher OS for experienced players.
Prefer lower uncertainty for noobs.

This draft mimics how a human might draft players with the given visible information in a lobby. It's not super mathematical. Players generally look at chevron level to determine how overrated someone might be. Someone did complain in chat about the lobby balance in the game I played mentioned above. They were obviously eyeballing the chevron levels and assuming those two players were overrated.
Further enchancements

Previously, if the balancer was called it would check the result and if the deviation in ratings between teams was too high, it would rerun the balancer but split all parties into solo players. Now the balance result will have a new field: has_parties?. If this is false we do not need to rerun the balancer again.
Permissions have been reduced for fake users that are not admin. The purpose of this is if you want to test that the Balance tab doesn't appear to normal users, you need to reduce the permissions of fake users.
Anyone with Staff role e.g. Tester, Contributor, etc. can now see the balance tab. The balance tab now has a dropdown allowing you to switch to difference balance modes.
fuzz_multiplier (randomness added to match rating) is now only enabled for Teifion's algos. This makes it easier to debug issues.
If there are no noobs, an alternate balancer (loser_picks) will be called. This is the default algo and it supports parties.

Known Bugs
Teiserver doesn't know the rank shown to the user in Chobby. Chobby gets the rank on login and then never updates. Teiserver, therefore, may classify a user as 2Chev but they might be shown as 1Chev in Chobby.
Unit Tests
Run this to run multiple unit tests that relate to balance
  mix test --only balance_test

Local Dev Tests
See comment here for test steps.
Theoretical Testing on past replays
Go here: https://balance-algo-web.web.app/
And enter a past replay. Change algorithm to Split One Chevs v2

Have updated and now you can use the url to see various balances
http://localhost:4000/battle/4/balance/split_one_chevs

Have updated and now you can see dropdown to change the balancer. Also removed the admin pages (now redirects) to be consistent with the previous PR made by Perfi to remove them.

Sample video of testing balancer tab in Integration server:
https://www.youtube.com/watch?v=KUqzvU6GBug

Local Dev Tests
You must rerun the fake data task. This is because if you ran it previously, the fake users will have too high permissions. I modified the fakedata task so fake users will have normal permissions.
mix teiserver.fakedata
The create fake data task made by Teifion doesn't give fake users any playtime stats. So we need to add them:
mix teiserver.fake_playtime
Launch the website
mix phx.server
Now go to Admin > Matches > Select a Match > Balance Tab.
You will see the logs for the loser_picks algo.
There is a dropdown with the label "Balancer" near the top. Change this to split_one_chevs
You will now see the logs for split_one_chevs.
Testing permissions of normal users
Login as root admin and find a user. Copy their email which should be a guid. Relogin as that user. Check that they cannot see the balance tab.
Relogin as admin and then give that user a contributor/tester role. Relogin as the user and now they should have access.

Teiserver doesn't know the rank shown to the user in Chobby. Chobby gets the rank on login and then never updates. Teiserver, therefore, may classify a user as 2Chev but they might be shown as 1Chev in Chobby.

I thought rank was only calculated on login, when/where else does Teiserver calculate rank?

To be honest this bug really baffled me. I still have no idea why they are out of sync.

Teiserver doesn't know the rank shown to the user in Chobby. Chobby gets the rank on login and then never updates. Teiserver, therefore, may classify a user as 2Chev but they might be shown as 1Chev in Chobby.

I thought rank was only calculated on login, when/where else does Teiserver calculate rank?

To be honest this bug really baffled me. I still have no idea why they are out of sync. From my searching it only gets calculated on login.

That was my understanding as well. I checked again, not sure what we are missing...

Currently at least there is an issue for it: https://github.com/beyond-all-reason/teiserver/issues/332
So that the bug is at least recorded.

@L-e-x-o-n I have updated the PR now with the following changes:

fakedata task now also calls task to add playtime stats
balancer renamed to be more consistent with other usage


--stdout parameter for bicep build stopped working

Setup
Windows 11
Powershell 7.2.4
Azure CLI 2.37
Repro
az bicep build --file somefile.bicep --stdout

Expected
Result of the compilation should appear on standard output
Actual
Nothing gets printed to the output
Additional context
Seems to have been broken in Azure CLI 2.37. Reverting back to Azure CLI 2.36 restores the expected functionality.

The problem is not in bicep itself, but rather in the az bicep build implementation.  It was introduced, I think, with https://github.com/Azure/azure-cli/commit/215960c2a6f1da41f5e60df041b2a75c52ff2ed0.
Note that previously, when --stdout was set, we would print the result of calling run_bicep_command. When the restore feature was added, the extra if block that was introduced meant that we only printed the result when --no-restore was also set.

I opened https://github.com/Azure/azure-cli/issues/22621 since I suspect the fix has to come in the CLI itself.

Thanks for reporting it. I created a pull request to fix the regression: https://github.com/Azure/azure-cli/pull/22685.

The PR was merged.


Pass width/height to thumbnail images if available.

Address #15 and passes width/height to the size argument in the useGetImageResource hook.
Tested using https://digital.lib.utk.edu/assemble/manifest/rftaart/7.

Sorry @markpbaggett, I was hasty and thought I saw an approved -- not changes requested. I did remove the console.log.


Fix potential bug in docs examples

When I have my first Queue instance be using queueRef and my second Queue instance be using tasksRef (like it is in the docs), the second spec never runs. However, if both Queues are using queueRef, it works as expected.

Thanks for the fix


[ISSUE #113] Optimize Webhook doc and add updateWebHookConfig endpoint

Fixes #113.

Fixed Webhook Chinese doc not displayed

The reason for this problem is that the ordering of files in the English document directory and the Chinese document directory do not correspond. So I removed some duplicate files and added some missing files. The missing files need to be translated. I will translate them later.

Add updateWebHookConfig endpoint
Fixed misaligned title hierarchy.
Fixed failed line breaks.
Fixed typos and case.
Added space between Chinese and English.

Before
English version of Webhook doc will be displayed in Chinese site:

After

@xwm1992 PTAL~


Call Back Error

Hi bobby, i receive this error when trying to install addon
Callback EndlessHorizon_SocialShare_Listener2::front_controller_post_view is invalid (Invalid Class).

Should be caused by upload failure. Try to re-upload all the necessary files and overwrite any existing old files.


audit package.json(s)

and only keep packages that are used

[ ] backend
[ ] auth
[ ] token-introspection
[ ] mock-account-servicing-entity
[ ] local-http-signature
[ ] frontend


[DOC] SecurityAdmin uses port 9200 (http)

What do you want to do?

[ ] Request a change to existing documentation
[ ] Add new documentation
[x] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request.
The securityadmin.sh documentation contradicts itself in a few places on whether it uses 9200 or 9300 by default. Currently, it does use 9200 which is the HTTP endpoint by default.
*Version: List the OpenSearch version to which this issue applies, e.g. 2.14, 2.12--2.14, or all.
2.16.0 (likely more, I only tested with the currently released version)
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
Reproduce by trying to run securityadmin.sh with:

-p 9300 = Fail
-p 9200 = Success
(No port specified) = Success

I will submit a PR to change this momentarily.

Closed by #7989


<EMAIL_ADDRESS>hash check failed

I tried to install sysinternals,

$ scoop install sysinternals
Installing 'sysinternals' (February.18.2019) [64bit]
Downloading https://download.sysinternals.com/files/SysinternalsSuite.zip (24.2 MB)...
Checking hash of SysinternalsSuite.zip ... ERROR Hash check failed!
App:         extras/sysinternals
URL:         https://download.sysinternals.com/files/SysinternalsSuite.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    9b9d6bd0718a5680b2322398345271142783156dc8d6f3642bce72f80337850f
Actual:      aa9bf58a84c78503c1e5feae9f0dce8f6867ebdf9cea1956564d051f4bcd651c

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/lukesampson/scoop-extras/issues/new?title=sysinternals%40February.18.2019%3A+hash+check+failed

Checking out the Microsoft web site
https://docs.microsoft.com/en-us/sysinternals/downloads/sysinternals-suite
It appears the download site only keeps the latest version of the zip file available.
When I manually download the file, and unzipped it, I can see the zip file contains files dated after Feb 18, 2019.

$ ls -lt
total 88154
-rw-r--r-- 1 eric<PHONE_NUMBER>7414 Mar 19 20:22 SysinternalsSuite.zip
-rwxr-xr-x 1 eric 197121  3012656 Mar 16 14:41 Bginfo.exe*
-rwxr-xr-x 1 eric 197121  4228352 Mar 16 14:40 Bginfo64.exe*
-rwxr-xr-x 1 eric 197121  3309304 Mar 11 12:59 Sysmon.exe*
-rwxr-xr-x 1 eric 197121  1813552 Mar 11 12:55 Sysmon64.exe*
-rwxr-xr-x 1 eric 197121   444984 Mar  4 10:54 psloglist.exe*
-rwxr-xr-x 1 eric 197121   579128 Mar  4 10:52 psloglist64.exe*

A quick search for versions of sysinternalssuite shows that chocolatey thinks sysinternalssuite was updated on March 18, 2019, which is consistent with the dates I see in the zip file.

https://chocolatey.org/packages/sysinternals

A sha256sum of the SysInternalSuite.zip file I downloaded from
matches the value that scoop reports when it downloaded.

$ sha256sum SysinternalsSuite.zip
aa9bf58a84c78503c1e5feae9f0dce8f6867ebdf9cea1956564d051f4bcd651c *SysinternalsSuite.zip

Bottom line, I think the SysInternalsSuite has been updated and the scoop description is referencing an old version that is no longer available at the download site.
Please let me know if I can do anything to help out. I really appreciate all the effort that goes into scoop. It makes my life better. :-)

Fixed with https://github.com/lukesampson/scoop-extras/pull/1892