Fluent interfaces support

This is a basic implementation but it seems to work - really looking forward to a review, as I am not sure this is the correct way to go.
I have not measured the performance impact of the change!

I would be happy to merge this as soon as the code duplication with CompletionProvider is refactored :)

As we discussed in the comments - I do not consider this a duplication - the code pieces are very different:

one is a generator, the other one returns an array
one is looking for a single match of a method signature - the other for an array of class definitions

If you still believe code from CompletionProvider should be used I will refactor. As mentioned in the comments above - I will need some pointers as to how to achieve this:

... just let me know how to proceed with refactoring since the method in question is in another class?

I would also like to remind you of the other potential problem (again from the comments above):

... collecting the data using CompletionProvider::expandParentFqns() was a bit slow and caused high CPU usage

Please, advise on how to proceed?

Thank you for the pointers, I will refactor ASAP. I could add a generator to Definition, and materialize the generator in CompletionProvider so that method signatures remain the same.

I don't think you need to materialize it (alas iterator_to_array). If you look at https://sourcegraph.com/github.com/vakata/php-language-server@53534aff2d647b54f8ec79fbb281e92167af49b2/-/blob/src/CompletionProvider.php#L385:5$references, the result only is iterated over with foreach.

I will see what I can do - unfortunately I do not think the method is a good fit for Definition - both CompletionProvider and DefinitionResolver use an index in order to expand the parents, which Definition has no access to - the index could be passed in as a parameter, but I am not sure it is OK to add so much complexity to what currently is a simple value object. I will make the changes and leave the review up to you.

Please review the changes (I had to use iterator_to_array as the results were used by reference). Could you tell me how to test if there is a negative performance impact - are there any performance tests?

Please, do not forget about perf testing - how can I test the impact of these changes?

You can run https://github.com/felixfbecker/php-language-server/blob/master/Performance.php

Yes, run git submodule update --init --recursive then run the Performance.php script with and without your changes. Let me know how it goes and whether you get any useful results from it.

I ran the tests on master and on this branch. Here are the results:
MASTER:
drupal                   100.00% -  37.64
wordpress                100.00% -   2.72
php-language-server      100.00% -   0.59
tolerant-php-parser      100.00% -  81.62
math-php                 100.00% -   1.06
symfony                  100.00% -  18.05

PR:
drupal                   100.00% -  39.15
wordpress                100.00% -   2.46
php-language-server      100.00% -   0.54
tolerant-php-parser      100.00% -  80.84
math-php                 100.00% -   1.07
symfony                  100.00% -  18.14

I see no impact - there are minor differences, but they move up and down with each run. I will use this branch in my VS Code tomorrow to get a feel of the real world usage.

Just a quick update - I did not notice any change in responsiveness while using VS Code with the source from this branch, I also did not notice any change in resource usage.

Thanks a lot!

@vakata Just curious, the benchmarks you showed don't list "Codeignitor" and "cakephp" which are present in the frameworks list here. Why is that?

@ADmad odd, I probably missed something when copying, I will have a look - it was not intentional.

@vakata Thanks, as a CakePHP user I just want to ensure that tests/benchmarks are run for it too :smile:


detection_by_tracker and probabilistic_occupancy_grid_map export files with the same name (utils.hpp)

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
detection_by_tracker and probabilistic_occupancy_grid_map export files with the same name (utils.hpp) which makes it not possible to install Debian packages of both (see https://github.com/autowarefoundation/autoware-deb-packages/issues/55)
Expected behavior
Install both Debian packages should be possible
Actual behavior
Installing both packages results in the following error:
root@3a47107fc384:/# apt install -f
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Correcting dependencies... Done
The following additional packages will be installed:
  ros-humble-detection-by-tracker ros-humble-probabilistic-occupancy-grid-map
The following NEW packages will be installed:
  ros-humble-detection-by-tracker ros-humble-probabilistic-occupancy-grid-map
0 upgraded, 2 newly installed, 0 to remove and 1 not upgraded.
1128 not fully installed or removed.
Need to get 608 kB of archives.
After this operation, 3133 kB of additional disk space will be used.
Do you want to continue? [Y/n]
Get:1 https://github.com/autowarefoundation/autoware-deb-packages/raw/jammy-humble-main ./ ros-humble-detection-by-tracker 0-2<IP_ADDRESS>.03 [264 kB]
Get:2 https://github.com/autowarefoundation/autoware-deb-packages/raw/jammy-humble-main ./ ros-humble-probabilistic-occupancy-grid-map 0-2<IP_ADDRESS>.29 [345 kB]
Fetched 608 kB in 2s (352 kB/s)
debconf: delaying package configuration, since apt-utils is not installed
(Reading database ... 138706 files and directories currently installed.)
Preparing to unpack .../ros-humble-detection-by-tracker_0-2<IP_ADDRESS>.03_amd64.deb ...
Unpacking ros-humble-detection-by-tracker (0-2<IP_ADDRESS>.03) ...
dpkg: error processing archive /var/cache/apt/archives/ros-humble-detection-by-tracker_0-2<IP_ADDRESS>.03_amd64.deb (--unpack):
 trying to overwrite '/opt/ros/humble/include/utils/utils.hpp', which is also in package ros-humble-detected-object-validation 0-2<IP_ADDRESS>.31
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
Preparing to unpack .../ros-humble-probabilistic-occupancy-grid-map_0-2<IP_ADDRESS>.29_amd64.deb ...
Unpacking ros-humble-probabilistic-occupancy-grid-map (0-2<IP_ADDRESS>.29) ...
dpkg: error processing archive /var/cache/apt/archives/ros-humble-probabilistic-occupancy-grid-map_0-2<IP_ADDRESS>.29_amd64.deb (--unpack):
 trying to overwrite '/opt/ros/humble/include/utils/utils.hpp', which is also in package ros-humble-detected-object-validation 0-2<IP_ADDRESS>.31
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
Errors were encountered while processing:
 /var/cache/apt/archives/ros-humble-detection-by-tracker_0-2<IP_ADDRESS>.03_amd64.deb
 /var/cache/apt/archives/ros-humble-probabilistic-occupancy-grid-map_0-2<IP_ADDRESS>.29_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

Steps to reproduce
Follow instructions from https://github.com/autowarefoundation/autoware-deb-packages/blob/jammy-humble-main/README.md and install these packages via sudo apt install ros-humble-detection-by-tracker ros-humble-probabilistic-occupancy-grid-map
Versions
No response
Possible causes
No response
Additional context
No response

Closing. Both #5837 and #5839 are now merged, and the global issue is being tracked in https://github.com/autowarefoundation/autoware/issues/4070


Refactor and fix fusion paths more

When I suggested to use result_type, I indeed missed that we still need the "use min scalar" logic to some degree, since otherwise a linear loop search can't possibly work.
Not sure about the changes allowing weaks=None, but seems not too bad?
Fixing the use of in_types[i] rather than out_types[0] during the coercion step made some true-div tests fail, so I had to add additional loops unfortunately.

I have only run the cupy_tests/core_tests as of now, but these are the remaining failures:
FAILED tests/cupy_tests/core_tests/fusion_tests/test_misc.py::TestFusionComposition::test_composition - AssertionError: ndarrays of different dtypes are returned.
FAILED tests/cupy_tests/core_tests/fusion_tests/test_misc.py::TestFusionCompile::test_clear_cache - AssertionError: ndarrays of different dtypes are returned.
FAILED tests/cupy_tests/core_tests/fusion_tests/test_array.py::TestFusionArrayOperator_param_12_{func=<lambda>, left_value='array', name='sub', right_value='primitive'}::test_operator - AssertionError:

which seems like an improvement to what you reported in the cupy PR.

OK, comparing my local test results on these changes with the list you gave in the PR: I think the changes are good (it won't be the final change, but good next step if you like it).
I also see some float16 failures (and I haven't checked on all the failures, but they appear only in files where you also saw failures).  OTOH, I ran with -m "not slow".
I still think restoring NumPy 1.x might be nice (at least in parts), partially because it seems like it should be pretty simple.  But no need to do that in this step.

Thanks @seberg, this is definitely more sleek!


Mixed read/update proportions produce swinging latencies

When invoking ycsb run with either readproportion=1.0 or updateproportion=1.0, I get somewhat consistent average latencies.  But when invoking run with mixed readproportion=0.50 and updateproportion=0.50, I get results with latencies swinging all to one side either READ or UPDATE.  All using 1 thread.
Is there an explanation for this?
This behavior indicates a bug in YCSB.  I haven't had time to diagnose it.  Hope someone will.
% ycsb run workload.r00.w100
java -cp ycsb-memdb:/work/memdelay/ycsb/memdb-binding/conf:/work/memdelay/ycsb/conf:/work/memdelay/ycsb/lib/HdrHistogram-2.1.4.jar:/work/memdelay/ycsb/lib/core-0.12.0.jar:/work/memdelay/ycsb/lib/htrace-core4-4.1.0-incubating.jar:/work/memdelay/ycsb/lib/jackson-core-asl-1.9.4.jar:/work/memdelay/ycsb/lib/jackson-mapper-asl-1.9.4.jar com.yahoo.ycsb.Client -db MemDBClient -threads 1 -P workload.r0w100 -t
...
readproportion=0.00
updateproportion=1.0
...
[UPDATE], Operations, 100000.0
[UPDATE], AverageLatency(us), 47.87603
[UPDATE], MinLatency(us), 0.0
[UPDATE], MaxLatency(us), 4694015.0
[UPDATE], 95thPercentileLatency(us), 2.0
[UPDATE], 99thPercentileLatency(us), 12.0
[UPDATE], Return=OK, 100000
% ycsb run workload.r100.w00
java -cp ycsb-memdb:/work/memdelay/ycsb/memdb-binding/conf:/work/memdelay/ycsb/conf:/work/memdelay/ycsb/lib/HdrHistogram-2.1.4.jar:/work/memdelay/ycsb/lib/core-0.12.0.jar:/work/memdelay/ycsb/lib/htrace-core4-4.1.0-incubating.jar:/work/memdelay/ycsb/lib/jackson-core-asl-1.9.4.jar:/work/memdelay/ycsb/lib/jackson-mapper-asl-1.9.4.jar com.yahoo.ycsb.Client -db MemDBClient -threads 1 -P workload.r100w00 -t
...
readproportion=1.0
updateproportion=0.00
...
[READ], Operations, 100000.0
[READ], AverageLatency(us), 44.34925
[READ], MinLatency(us), 0.0
[READ], MaxLatency(us), 4419583.0
[READ], 95thPercentileLatency(us), 1.0
[READ], 99thPercentileLatency(us), 4.0
[READ], Return=OK, 100000
% ycsb run workload.r50.w50  #RESULTS SHOW LATENCIES SWING TO READ
java -cp ycsb-memdb:/work/memdelay/ycsb/memdb-binding/conf:/work/memdelay/ycsb/conf:/work/memdelay/ycsb/lib/HdrHistogram-2.1.4.jar:/work/memdelay/ycsb/lib/core-0.12.0.jar:/work/memdelay/ycsb/lib/htrace-core4-4.1.0-incubating.jar:/work/memdelay/ycsb/lib/jackson-core-asl-1.9.4.jar:/work/memdelay/ycsb/lib/jackson-mapper-asl-1.9.4.jar com.yahoo.ycsb.Client -db MemDBClient -threads 1 -P workload.r100w00 -t
...
readproportion=0.50
updateproportion=0.50
...
[READ], Operations, 50152.0
[READ], AverageLatency(us), 95.49270218535652
[READ], MinLatency(us), 0.0
[READ], MaxLatency(us), 4780031.0
[READ], 95thPercentileLatency(us), 1.0
[READ], 99thPercentileLatency(us), 2.0
[READ], Return=OK, 50152
[UPDATE], Operations, 49848.0
[UPDATE], AverageLatency(us), 1.7589471994864387
[UPDATE], MinLatency(us), 0.0
[UPDATE], MaxLatency(us), 492.0
[UPDATE], 95thPercentileLatency(us), 3.0
[UPDATE], 99thPercentileLatency(us), 11.0
[UPDATE], Return=OK, 49848
% ycsb run workload.r50.w50    #RESULTS SHOW LATENCIES SWING TO UPDATE
java -cp ycsb-memdb:/work/memdelay/ycsb/memdb-binding/conf:/work/memdelay/ycsb/conf:/work/memdelay/ycsb/lib/HdrHistogram-2.1.4.jar:/work/memdelay/ycsb/lib/core-0.12.0.jar:/work/memdelay/ycsb/lib/htrace-core4-4.1.0-incubating.jar:/work/memdelay/ycsb/lib/jackson-core-asl-1.9.4.jar:/work/memdelay/ycsb/lib/jackson-mapper-asl-1.9.4.jar com.yahoo.ycsb.Client -db MemDBClient -threads 1 -P workload.r100w00 -t
...
readproportion=0.50
updateproportion=0.50
...
[READ], Operations, 50019.0
[READ], AverageLatency(us), 0.16817609308462783
[READ], MinLatency(us), 0.0
[READ], MaxLatency(us), 58.0
[READ], 95thPercentileLatency(us), 1.0
[READ], 99thPercentileLatency(us), 3.0
[READ], Return=OK, 50019
[UPDATE], Operations, 49981.0
[UPDATE], AverageLatency(us), 93.02158820351734
[UPDATE], MinLatency(us), 0.0
[UPDATE], MaxLatency(us), 4579327.0
[UPDATE], 95thPercentileLatency(us), 3.0
[UPDATE], 99thPercentileLatency(us), 14.0
[UPDATE], Return=OK, 49981

@dhongMicron , you are likely to be running onto Coordinated Omission issue (see https://github.com/brianfrankcooper/YCSB/pull/214 )
TL;DR: always check what your maximum latencies are and dig deeper in case max latency exceeds average by a high margin.
MaxLatency(us), 4579327.0 seems like a 4.57 sec GC pause. Would you list full outputs, including TOTAL_GC sections?
Suppose it takes 1.8 us to perform an update on average.
You perform 50000 operations, so it takes 1.8*50000=90000 us = 90ms for ALL 50000 updates.
Consider a single update is interrupted with a GC pause of 4.5 seconds. Then "total time" for update operations become  4.5sec + 90ms = 4.59 sec.  4.59sec/50'000 ops == 91.8 us on average.


Some parts of friends and family are crashing.

One of the user is facing crash issue on FI app.
-He is using FI v1.3.2 on iphone 8.
-His app is crashing on "I am the keeper of"contact of F&F.

@cakesoft-swati  can you please test and assign this to Parsh if the issue is still there

@cakesoft-swati  can you please test and assign this to Parsh if the issue is still there

This seems to be what's also being described in #2541

This seems to be what's also being described in #2541

--Observed on UP Live app version 1.4.1(195)
-The screen is getting stuck for a while and we can not refresh it and cannot click anywhere(I have to kill the app).
-I have a contact in "I am the Keeper of", the app is crashing by clicking on it.

--Observed on UP Live app version 1.4.1(195)
-The screen is getting stuck for a while and we can not refresh it and cannot click anywhere(I have to kill the app).
-I have a contact in "I am the Keeper of", the app is crashing by clicking on it.

-It is happening only on production app.
-Unable to recreate it on dev app.

-It is happening only on production app.
-Unable to recreate it on dev app.

Lets test it on latest production after release. We will leave this open for now.

Lets test it on latest production after release. We will leave this open for now.


CIFuzz: Surface error logs and test case on failure

This change to CIFuzz will notify users when a bug was found in there pull request. It will also upload a directory containing the stack trace and test case that caused to bug. Hopefully will mitigate confusion in situations like https://github.com/google/syzkaller/pull/1590

This crash is concerning:
https://github.com/google/syzkaller/pull/1590#issuecomment-584244580
This is a bug in Go runtime, something a Go program should never trigger. And it does not look to be related to the PR in question. And it never surfaced in normal oss-fuzz runs:
https://bugs.chromium.org/p/oss-fuzz/issues/list?q=label:Proj-syzkaller
The question: is it related to CIFuzz functionality in some way? What is the Go version used to build fuzzers? Is it different from oss-fuzz? Will we get this error on every PR (won't be too useful)?

And it never surfaced in normal oss-fuzz runs:
https://bugs.chromium.org/p/oss-fuzz/issues/list?q=label:Proj-syzkaller

There are some other "unreproducible" crashes found on OSS-Fuzz: https://oss-fuzz.com/testcases?project=syzkaller&open=yes
They look differently, but we do hit some weird things occasionally.

The question: is it related to CIFuzz functionality in some way? What is the Go version used to build fuzzers? Is it different from oss-fuzz?

The image and toolchain are exactly the same as in OSS-Fuzz, which is the latest stable version available (https://github.com/google/oss-fuzz/blob/41ca13ba42871be1f9db94741c4956637402c937/infra/base-images/base-builder/Dockerfile#L28)
We do not expect any CIFuzz specific issues to occur (unless GitHub Action VMs are weird?).

Will we get this error on every PR (won't be too useful)?

There are two improvements planned in the pipeline:

if a crash was found, try reproducing it; do not report a failure if it's not reproducible with a single test case

build the fuzzers without PR and try reproducing with it; that should distinguish new regressions and known bugs

With that being addressed, we should not see any confusing results. Sorry for temporary inconvenience and thanks for dogfooding CIFuzz! :)


build: harden build by pre-fetching dependencies

Attempt to vendor the cargo deps for up to 25 times Supports linking the resulting derivation into a global location through env var CARGO_VENDOR_DIR, example:

CARGO_VENDOR_DIR=/tmp ./scripts/release.sh --image ""
/nix/store/2x03mh7l1q0jx4xfsd3nw4h4ks0pxxya-cargo-vendor-dir Cargo vendored dependencies pre-fetched into /tmp/$BRANCH/mayastor-controller after 1 attempt(s)

This can allow us to create a place holder in the jenkins nodes to keep the last dependencies for each main branch of each repo.

bors merge

bors merge


SDCard via SD/SDIO/MMC interfaces

Is your feature request related to a problem? Please describe.
Currently, an SD card is accessed via the SPI interface. Many controllers have a native SD/SDIO/MMC interface (STM32F4, STM32H7 and many more). This allows up to 4 times higher data rates when reading and writing to the SD card.
Describe the solution you'd like
Access to the SD card via the native interface of the controller and transfer the data from RAM via DMA to SD card.

@haipas There's already a subsys/disk/disk_access_stm32_sdmmc.c driver. Can you check if this could match your request ?

@haipas Please let us know if this answered your point and if the point could be closed.

@erwango thanks for the hint. #29480 is a PR which adds the sdmmc support for the nucleo h743zi


kontena.yml parsing explodes with tactical placement of ${subt}

    image: ${registry}/my-app:${tag}

causes
Psych::SyntaxError : Error while parsing ... : (<unknown>): mapping values are not allowed in this context at line 70 column 25

changing as follows fixes it
    image: ${registry}/my-app:{{tag}}

Not much else that can be done for this than to document the need for quoting when using the interpolation syntax... it looks like image: foo:bar is valid YAML but image: foo:$bar isn't.
The working syntax is image: "foo:$bar".

error messages could be improved - it is really hard to figure this out the first time when this happens

Hmm, where were you loading the stack YAML from?
Testing with kontena stack validate test/syntax.yaml, it error looks like:
 [error] Psych::SyntaxError : Error while parsing /home/kontena/kontena/kontena/cli/test/syntax.yaml : (/home/kontena/kontena/kontena/cli/test/syntax.yaml): mapping values are not allowed in this context at line 4 column 15
         See /home/kontena/.kontena/kontena.log or run the command again with environment DEBUG=true set to see the full exception

It should probably be an exit_with_error instead of an unhandled exception, but it includes the correct file path and line number for the syntax error.

Maybe we could detect this error and offer a generic documentation piece in-line or as a link to that? eg. Please use quotes around values or such

Psych::SyntaxError and mapping values are not allowed in this context don't really help the user to figure out what happened.


Restore model and Continue trainning

Background and Context
Could you add a feature which allow the model to be restored and trained based on previous training result ?
Description

Hi @Sissie1122
To follow up, would this requested feature be:

Given a model is going to take 10 hours to train you would like to pause and resume the training such that you could train for 5 hours, pause, resume for 2 hours, pause and then resume for 3 hours.

or would it be:

Given you have already trained a model on some data, you would like to use this previously trained model as an initial point to bootstrap learning on new data?

Actually, using previously trained result as initialization is enough to suit my needs. And I also hope the training loss could be printed or visualized in tensorboard, which will help the user to adjust parameter. Thank you! @chanlevan


Update python version

Used this code to install another version of python instead of the default that comes with ubuntu:
# Install requirements
sudo apt-get install -y \
    checkinstall\
    libreadline-gplv2-dev\
    liblzma-dev\
    libncursesw5-dev\
    libssl-dev\
    libsqlite3-dev\
    tk-dev\
    libgdbm-dev\
    libc6-dev\
    libbz2-dev\
    zlib1g-dev\
    openssl\
    libffi-dev\
    python3-dev\
    python3-setuptools\
    wget\
    zlib1g-dev

# install needed packages
sudo apt-get install -y cmake \
	git \
	libopencv-dev \
	htop \
	tmux \
	tree \
	p7zip-full

cd ~
mkdir tmp
cd tmp
wget https://www.python.org/ftp/python/3.7.9/Python-3.7.9.tgz
tar zxvf Python-3.7.9.tgz
cd Python-3.7.9
./configure --prefix=$HOME/opt/python-3.7.9
make
make install
cd ~
echo 'export PATH=$HOME/opt/python-3.7.9/bin:$PATH' >> .bash_profile
. ~/.bash_profile
cd ~

pip3 install -U pip
pip3 install --upgrade setuptools
#pip3 uninstall crcmod -y
pip3 install --no-cache-dir crcmod
pip3 install --upgrade pyasn1
cd necstlab-damage-segmentation && pip3 install -r requirements.txt

it gives a warning with the path, but then I think that is fixed with:
echo 'export PATH=$HOME/opt/python-3.7.9/bin:$PATH' >> .bash_profile

The right python version is used with python3 command

And all the workflow steps work
Ingest works

prepare dataset works

train works

train threshold works

test works

infer works

@Josh-Joseph this looks good to me as it works, but def something i think that you're more familiar with. thoughts? @CarolinaFurtado did a nice job documenting VM creation


snowplow configuration

I am new in snowplow and I want to configure javascript tracker in my web page i have some events on which i want to capture some information and sen it to backend for analysis.
some events like

button click
when hi search something in site.
please help me how should i do it with a  short example.

Hello @pawanpatil08. As I mentioned before - we use Github issues for bug-reports and feature-requests only. Please, direct support questions to our forums - this is the right place for asking for help.
Setup guide is available on our wiki with examples for each particular tracker.
Closing this.

Sure thanks ..
I have not seen this  last notification


feat: swap table component

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Tested on setting and timeline.

@raisedadead, when you have time force merge this PR, because we can't resolve the conversation, and it's stuck.


Crash on 2nd day. Food BK Party Consumption Model

On the 2nd day of playing BK (first daily tick), I get a crash about the party consumption model.
Crash report attached.
https://report.butr.link/692F17.html

Describe the bug
A clear and concise description of what the bug is.
Mod Version

Standard or CEK version
Numeric Version: 1.2.5.x

Evidence

[x] The mod is present in the callstack;
[X] The issue only happens with the mod activated;
[X] You tested it with the least amount of other mods as possible.

Crash Report
If the issue is a crash, not posting a report or callstack is wasting everyone's time.

Did you ever find how to resolve this issue??

@Sheikifang No, sorry I didn't. I was trying to play BK with a ton of mods, that didn't work at all, and then I trimmed way down on the number of mods and this particular crash did not occur again. I never took the time to isolate which mod caused this crash.


fix: support data urls

For now, only JavaScript via 'data:text/javascript;base64,... is supported.
Can add text/typescript or (text/ts? text/tsx?) support later if the use-case arises.

:tada: This PR is included in version 2.5.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove column data type analyzer/section

We're currently processing your upload.  This comment will be updated when the results are available.


add Korean language.

add Korean Language.
In this project, there is no singular, plural word.

I add one more thing!
There isn't property on QBImagePickerViewController
for not showing empty albums.
I add allowsShowingEmptyAlbum property, default value is YES.


feat: expose fetch context to allow custom configuration

Please ensure your pull request adheres to the following guidelines:

[x] make sure to link the related issues in this description
[x] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
#15

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


访问谷歌网页提示流量异常需要自动确认

Please read the instruction and answer the following questions before submitting your issue. Thank you.
Please answer all the questions with enough information. All issues not following this template will be closed immediately.
If you are not sure if your question is truely a bug in V2Ray, please discuss it here first.

What version of V2Ray are you using (If you deploy different version on server and client, please explicitly point out)?
v4.17.0

What's your scenario of using V2Ray? E.g., Watching YouTube videos in Chrome via Socks/VMess proxy.

What did you see? (Please describe in detail, such as timeout, fake TLS certificate etc)

What's your expectation?

Please attach your configuration file (Mask IP addresses before submit this issue).

Server configuration:
   {
  "inbounds": [{
    "port": 19591,
    "protocol": "vmess",
    "settings": {
      "clients": [
        {
          "id": "xxxx",
          "level": 1,
          "security": "auto",
          "alterId": 64
        }
      ],
      "streamSettings": {
        "network": "mkcp",
        "kcpSettings": {
          "uplinkCapacity": 20,
          "downlinkCapacity": 100,
          "congestion": true,
          "header": {
            "type": "none"
          }
        }
    }
  }
  }],
  "outbounds": [{
    "protocol": "freedom",
    "settings": {
      "domainStrategy": "UseIP"
    }
  },{
    "protocol": "blackhole",
    "settings": {},
    "tag": "blocked"
  }],
  "routing": {
    "rules": [
      {
        "type": "field",
        "ip": ["geoip:private"],
        "outboundTag": "blocked"
      }
    ]
  },
  "transport": {
    }
}

Client configuration:
    // Config file of V2Ray. This file follows standard JSON format, with comments support.
// Uncomment entries below to satisfy your needs. Also read our manual for more detail at
// https://www.v2ray.com/
{
  "log": {
    // By default, V2Ray writes access log to stdout.
    // "access": "/path/to/access/log/file",

    // By default, V2Ray write error log to stdout.
    // "error": "/path/to/error/log/file",

    // Log level, one of "debug", "info", "warning", "error", "none"
    "loglevel": "warning"
  },
  // List of inbound proxy configurations.
  "inbounds": [
    {
      // Port to listen on. You may need root access if the value is less than 1024.
      "port": 1080,

      // IP address to listen on. Change to "<IP_ADDRESS>" to listen on all network interfaces.
      "listen": "<IP_ADDRESS>",

      // Tag of the inbound proxy. May be used for routing.
      "tag": "socks-inbound",

      // Protocol name of inbound proxy.
      "protocol": "http",

      // Settings of the protocol. Varies based on protocol.
      "settings": {
        "auth": "noauth",
        "udp": false,
        "ip": "<IP_ADDRESS>"
      },

      // Enable sniffing on TCP connection.
      "sniffing": {
        "enabled": true,
        // Target domain will be overriden to the one carried by the connection, if the connection is HTTP or HTTPS.
        "destOverride": ["http", "tls"]
      }
    }
  ],
  // List of outbound proxy configurations.
  "outbounds": [
    {
      // Protocol name of the outbound proxy.
      "protocol": "vmess",

      // Settings of the protocol. Varies based on protocol.
      "settings": {
        "vnext": [
          {
            "address": "xxx", // 服务器地址，请修改为你自己的服务器 ip 或域名
            "port": 19591, // 服务器端口
            "users": [{ "id": "xxx","security": "auto" }]
          }
        ],
        "streamSettings": {
          "network": "mkcp", //此处的 mkcp 也可写成 kcp，两种写法是起同样的效果
          "kcpSettings": {
            "uplinkCapacity": 20,
            "downlinkCapacity": 100,
            "congestion": true,
            "header": {
              "type": "none"
            }
          }
      }
    },
      // Tag of the outbound. May be used for routing.
      "tag": "direct"
    },
    {
      "protocol": "blackhole",
      "settings": {},
      "tag": "blocked"
    }
  ],

  // Transport is for global transport settings. If you have multiple transports with same settings
  // (say mKCP), you may put it here, instead of in each individual inbound/outbounds.
  // "transport": {
  // },

  // Routing controls how traffic from inbounds are sent to outbounds.
  "routing": {
    "domainStrategy": "AsIs",
    "rules": []
  },

  // Dns settings for domain resolution.
  "dns": {
    // Static hosts, similar to hosts file.
    "hosts": {},
    "servers": [
      "<IP_ADDRESS>",
      {
        "address": "<IP_ADDRESS>",
        "port": 53,
        // List of domains that use this DNS first.
        "domains": ["geosite:cn"]
      },
      "<IP_ADDRESS>",
      "localhost"
    ]
  },

  // Policy controls some internal behavior of how V2Ray handles connections.
  // It may be on connection level by user levels in 'levels', or global settings in 'system.'
  "policy": {
    // Connection policys by user levels
    "levels": {
      "0": {
        "uplinkOnly": 0,
        "downlinkOnly": 0
      }
    },
    "system": {
      "statsInboundUplink": false,
      "statsInboundDownlink": false
    }
  },
  // Stats enables internal stats counter.
  // This setting can be used together with Policy and Api.
  //"stats":{},

  // Api enables gRPC APIs for external programs to communicate with V2Ray instance.
  //"api": {
  //"tag": "api",
  //"services": [
  //  "HandlerService",
  //  "LoggerService",
  //  "StatsService"
  //]
  //},

  // You may add other entries to the configuration, but they will not be recognized by V2Ray.
  "other": {}
}

Please attach error logs, especially the bottom lines if the file is large. Error log file is usually at /var/log/v2ray/error.log on Linux.

Server error log:
    // Please attach your server error log here.

Client error log:
    // Please attach your client error log here.

Please attach access log. Access log is usually at '/var/log/v2ray/access.log' on Linux.

    // Please attach your server access log here.

Other configurations (such as Nginx) and logs.

If V2Ray doesn't run, please attach output from --test.

The command is usually /usr/bin/v2ray/v2ray --test --config /etc/v2ray/config.json, but may vary according to your scenario.

If V2Ray service doesn't run, please attach journal log.

Usual command is journalctl -u v2ray.
Please review your issue before submitting.

不是机器流量太大,小站,搜搜google而已

https://support.google.com/websearch/answer/86640?hl=en

@kslr 对,相关的问题描述都看过了,问题是 每次都会出现,只要是新开一个浏览器窗口 无痕模式的 就会让你点击一下,之前用ss的时候没有出现这个问题

@Relsoul 这个问题有很多原因，比如同网段的机器打开了爬虫

@kslr 了解了，蟹蟹

用kcp，重复发包，导致google识别流量异常
On Mon, Mar 4, 2019 at 5:25 PM soul<EMAIL_ADDRESS>wrote:

@kslr https://github.com/kslr 了解了，蟹蟹
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/v2ray/v2ray-core/issues/1584#issuecomment-469179358,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATfMTL20-5aAIo0_-p4OJCXuCDJ8nYO2ks5vTOZ1gaJpZM4bbq_r
.

你们是怎么解决的？我是通过配置google走ipv4解决的，具体参考文章：使用v2ray访问谷歌提示异常流量；


Dump multiple paths

What does this PR change? What problem does it solve?
Before this change, dump accepted one path to dump, now multiple paths are accepted.
Was the change previously discussed in an issue or on the forum?
#4173
Checklist

[X] I have read the contribution guidelines.
[ ] I have enabled maintainer edits.
[ ] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[ ] I have run gofmt on the code in all commits.
[ ] All commit messages are formatted in the same style as the other commits in the repo.
[ ] I'm done! This pull request is ready for review.

The tests are not passing right now because the dumper does not need to allow passing an io.Writer anymore as this is not required, we could keep this around but idk, seems odd to me to pass a field as an argument.


X.Prelude: Compatibility with base-<IP_ADDRESS>

Will ship with GHC 9.8.
Fixes: https://github.com/xmonad/xmonad-contrib/issues/826
@geekosaur: Could you send me the warnings that are generated due to -Wx-partial? I'd like to fix at least some of them.
Checklist

[x] I've read CONTRIBUTING.md

[x] I've considered how to best test these changes (property, unit,
manually, ...) and concluded: That's what this PR is for :)

[n/a] I updated the CHANGES.md file

Interesting. We now have a bigger problem: I had been able to build setlocale for xmonad the first time I did this with an --allow-newer, but now it fails with
[1 of 1] Compiling System.Locale.SetLocale ( dist/build/System/Locale/SetLocale.hs, dist/build/System/Locale/SetLocale.o, dist/build/System/Locale/SetLocale.dyn_o )

System/Locale/SetLocale.hsc:27:5: error: [GHC-54721]
    ‘typeOf’ is not a (visible) method of class ‘Typeable’
   |
27 |     typeOf _ = mkTyConApp (mkTyCon "System.Locale.SetLocale.Category") []
   |     ^^^^^^

So we won't be able to support 9.8 anyway unless I can figure out how Typeable changed. (This is preventing me from even reaching xmonad-contrib, so it has to be something new within the past week.)

This looks more like a GHC or hsc2hs bug. There's just a deriving Typeable in that source file: https://gitlab.com/Kritzefitz/haskell-setlocale/-/blob/master/System/Locale/SetLocale.hsc?ref_type=heads#L25-32, and you shouldn't need the (..) in import Data.Typeable (Typeable(..)) to be able to have GHC derive that.
And anyway, that's a problem of https://gitlab.com/Kritzefitz/haskell-setlocale, not ours. :-)

Wait, I just remembered you can't instance type of all at all anymore so
that should have thrown a different error and it should have been throwing
it since some 7.x release.
On Sun, Sep 17, 2023, 16:47 Tomáš Janoušek @.***> wrote:

This looks more like a GHC or hsc2hs bug. There's just a deriving Typeable
in that source file:
https://gitlab.com/Kritzefitz/haskell-setlocale/-/blob/master/System/Locale/SetLocale.hsc?ref_type=heads#L25-32,
and you shouldn't need the (..) in import Data.Typeable (Typeable(..)) to
be able to have GHC derive that.
And anyway, that's a problem of
https://gitlab.com/Kritzefitz/haskell-setlocale, not ours. :-)
—
Reply to this email directly, view it on GitHub
https://github.com/xmonad/xmonad-contrib/pull/829#issuecomment-1722565310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPRFICYAODHPXYL7QDGOBLX25OXDANCNFSM6AAAAAA43QQPBI
.
You are receiving this because you were mentioned.Message ID:
@.***>

And it's the import because it doesn't expose the methods of Typeable. I
wonder if there's a ghc gotcha or even bug there.
On Sun, Sep 17, 2023 at 4:56 PM Brandon Allbery @.***> wrote:

Wait, I just remembered you can't instance type of all at all anymore so
that should have thrown a different error and it should have been throwing
it since some 7.x release.
On Sun, Sep 17, 2023, 16:47 Tomáš Janoušek @.***>
wrote:

This looks more like a GHC or hsc2hs bug. There's just a deriving
Typeable in that source file:
https://gitlab.com/Kritzefitz/haskell-setlocale/-/blob/master/System/Locale/SetLocale.hsc?ref_type=heads#L25-32,
and you shouldn't need the (..) in import Data.Typeable (Typeable(..))
to be able to have GHC derive that.
And anyway, that's a problem of
https://gitlab.com/Kritzefitz/haskell-setlocale, not ours. :-)
—
Reply to this email directly, view it on GitHub
https://github.com/xmonad/xmonad-contrib/pull/829#issuecomment-1722565310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPRFICYAODHPXYL7QDGOBLX25OXDANCNFSM6AAAAAA43QQPBI
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
brandon s allbery kf8nh
@.***

Import needed, (..) needed (or unqualified import), at least as of 9.8.
I'll sort it later with Ben or someone in #ghc. Still have no idea how I
got a successful build before though.
Also had to relax bounds on hsc2hs, need to ask Ben about that one too in
case it needs to be fixed upstream (it should ship with ghc, I think?)
On Sun, Sep 17, 2023 at 5:10 PM Brandon Allbery @.***> wrote:

And it's the import because it doesn't expose the methods of Typeable. I
wonder if there's a ghc gotcha or even bug there.
On Sun, Sep 17, 2023 at 4:56 PM Brandon Allbery @.***>
wrote:

Wait, I just remembered you can't instance type of all at all anymore so
that should have thrown a different error and it should have been throwing
it since some 7.x release.
On Sun, Sep 17, 2023, 16:47 Tomáš Janoušek @.***>
wrote:

This looks more like a GHC or hsc2hs bug. There's just a deriving
Typeable in that source file:
https://gitlab.com/Kritzefitz/haskell-setlocale/-/blob/master/System/Locale/SetLocale.hsc?ref_type=heads#L25-32,
and you shouldn't need the (..) in import Data.Typeable (Typeable(..))
to be able to have GHC derive that.
And anyway, that's a problem of
https://gitlab.com/Kritzefitz/haskell-setlocale, not ours. :-)
—
Reply to this email directly, view it on GitHub
https://github.com/xmonad/xmonad-contrib/pull/829#issuecomment-1722565310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPRFICYAODHPXYL7QDGOBLX25OXDANCNFSM6AAAAAA43QQPBI
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
brandon s allbery kf8nh
@.***

--
brandon s allbery kf8nh
@.***

Okay, I have a successful build, so I can review now. And can collect those partiality warnings (they're all over, I'm afraid).


Link to Blog post doesnt work

Hey , the link to blog post detailing everything doesnt work, It's just redirects to "https://angularindepth.com/" I was in the middle of it and your explanation and examples where top level and would really love to continue, do you have it posted anywhere else also maybe?
Many thanks

@eskruolis updated.


Extend estimator.evaluate() to support event handlers

Description
Motivated by the issue #16959, we find that we could use existing LoggingHandler and MetricHandler for validation purpose. We extend estimator.evaluate() to support default and customized handlers. Our contributions can be summarized below:

We extend estimator.evaluate() to support event_handlers
We replace the metrics in estimator constructor with train_metrics and val_metrics
We decouple the dependence of default event handlers on training or validation metrics
We add test script to verify the correctness of evaluate function

Fix #16959.

@leezu - do you also want this in 1.6? I'm cherry-picking the other stuff, might as well take this since it is merged.

@ptrendx, yes, that would be great


Query fails if more parameter provided than expected

For example:
var some = undefined; // Comes from user's form
db.run("SELECT * FROM table WHERE bob = $bob" + (some ? " AND alice = $some": ""), {$bob: 3, $some: some}, function(e,r)
{
    Assert(r.length > 0); // Fails here
});

// This works:
db.run("SELECT * FROM table WHERE bob = $bob" + (some ? " AND alice = $some": ""), {$bob: 3}, function(e,r)
{
    Assert(r.length > 0); // Works
});

The code that bind should not break on "unkwown" parameters because else the code is a real pain to make it generic.

Actually, it's not a bug in this code, although other implementation in other language behave differently.
To get the code working, one should write:
db.run("SELECT * FROM table WHERE bob = $bob AND ($some IS NULL OR alice = $some)", { $bob: 3, $some: some}, function(e, r) {})

The SQL text must always include all the passed object's property name (else SQLite errors with binding out of range), BUT node-sqlite3 maps "undefined" to "NULL" in SQL's termn although "null" would be more appropriate IMHO. Anyway, do like above and it works.


Proposal: add a hook to load custom functions from html/template.FuncMap

It would be nice to have the ability to inject custom go functions inside Hugo funcMap entrypoint.
An example:
Firstly somewhere alongside our hugo project dir we would have another dir containing a custom_func.so file.
Then inside this file we would have any func we need. Let's go with :
import (
    "fmt"
)

func HelloHugoVersion(version int) string {
     v := fmt.Sprintf("Hello, you' re running on hugo v%d", version)
     return v
}

Then instantly in our template :

{{ .HelloHugoVersion 0.57.2 }}
 outputs
Hello, you're running on hugo v0.57.2

Note : we could even introduce a custom namespace like .plugin.HelloHugoVersion
We may achieve this using go plugin system and the html.FuncMap function:
https://golang.org/pkg/html/template/#FuncMap
https://golang.org/pkg/plugin/
Add a hook inside Hugo source code to read from the plugin all functions and inject them inside the FuncMap at runtime.
I let you imagine the possibilities ! For example building souce plugins for almost any data source (the Gatsby way), custom js vm running alongside your template using https://github.com/robertkrimen/otto. And I'm just scratching the surface of go ecosystem.
Caveat:
Plugins are not supported for windows users.... Meaning it would instantly introduce some heterogeneity to Hugo ecosystem.

Hey,
Go plugins are for Linux only and was very much considered an experimental thing -- nobody has worked on that in Go for years, so I don't think we're going to use it.

Hey bep,
They are available for linux and OSX.
Got it I understand your concern, meanwhile I can still hook my own funcs and build from source for my own usage.
Have a nice day.
PS module feature is great. I can dynamically load my gohtml from gogs ! Thank you.

@tomVlt note that this is in itself a good idea, and it has been discussed before, but before we do this the benefits must somehow be greater than the technical aspects/work of it all.

@bep thank you to underline this. I completely understand your first answer on it, plugin binding is just not mature enough and no idea if it will be some day. I opened this proposal way to early, I didn't check go plugin pckg status....
There might be a workaround using "os/exec" but as you mention:

the benefits must somehow be greater than the technical aspects/work of it all.

Hope one day to see an out of the box feature like this one :)
Have a nice week.

On the other hand adding experimental support for plugins in Hugo might create an incentive for someone to continue the work on plugins in Golang.


filter displayed ideas/entities by distance and additional criteria like tags

Split this issue into two: Filtering by Tags will be handled here, filter ideas based on distance is moved to  #44


Proposal for new top-level documentation structure

Creating this issue as a place to discuss and reference a large restructure of both new and existing documentation content for the Devfile documentation site. This information is based on a proposed table of contents shared by @rkratky in https://github.com/devfile/docs/pull/54 (Restructure site for multiple sets of documentation).
Proposed structure:

Getting Started with Devfiles

What are devfiles?
How devfiles works?
Quick Start Guide
Devfile samples
Tools using Devfiles

Using Devfiles

Using existing devfiles
Building a devfile for your project
Contributing a devfile to the community

Using Devfile Registry

...

Using Devfile Library

...

@elsony also proposed the following (https://github.com/devfile/docs/pull/54#issuecomment-825081196):

Instead of dividing into using devfiles, using registry, using library, it will be nice if we present those under different persona instead of the technology area, e.g. application developer, architects (stack/sample providers), registry administrator, tools provider, etc., and then put the individual technology-specific info under each persona. If we organize that way, we can also talk about the problems, benefits, values, and use cases for each persona for them to understand how devfile can help them in each case.

The above is an excellent point that we should keep in mind as we discuss the desired structure and come to a consensus.

Looking at the proposed structure, I assume our current "overview" would go under what are devfiles? and/or how devfiles work. I'm thinking our current authoring stacks would go under quick start guide and/or devfile samples because the authoring stacks' purpose is to add features to devfiles and get up and going.
Thinking about our current migration guides, do we imagine that content going under, using existing devfiles and/or building devfiles for your project? The current migration docs is to update and upgrade devfiles, so maybe some of the content would be used in the proposed existing devfiles or building devfiles section.
I'm simply visualizing where we're imagining current content being housed in the future. If the proposed structure doesn't have a fit for our current docs, we can always add more sections accordingly. Thanks!

JIRA issue: https://issues.redhat.com/browse/RHDEVDOCS-2940

Here is a Gdoc I've made. I simply added headings for our developer and registry admin persona, then added where we can add more registry docs, taken from John's repo.
https://docs.google.com/document/d/1OamiXqtwvWtdHKJRpqJ8HOULUOLlUQV0-uvoZHyp3G8/edit


Issue

f073984a2a4f4cda971f9aefe6ad5fc8

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9f2fb27f-0ce1-9541-e617-7fe8148f8297
Version Independent ID: 6777fa19-93ad-1984-5fd8-a9adc3dc3a3a
Content: Chunker - Overview
Content Source: creator/Documents/ChunkerOverview.md
Product: gaming
GitHub Login: @neonerz
Microsoft Alias: v-jeffreykim

Could I get some more information about how I can help?

It has been fixed, thank you!!!

Great! I'll close this issue.


Return 404 on invalid uuid in url.

Rather than giving some other response, we want a malformed uuid passed in a url to return an http404 response.

Closing this. An alternative approach was implemented in 19bbf0c


evaluate Netty 4.2.0.Alpha1

Do Not Merge.
This is a Draft PR. I am evaluating Netty 4.2.0.Alpha1
https://netty.io/news/2024/06/12/4-2-0-Alpha1.html

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.96%. Comparing base (59551e4) to head (4ff3873).
Report is 612 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13377      +/-   ##
============================================
+ Coverage     61.75%   61.96%   +0.21%
+ Complexity      207      198       -9
============================================
  Files          2436     2550     +114
  Lines        133233   140257    +7024
  Branches      20636    21801    +1165
============================================
+ Hits          82274    86906    +4632
- Misses        44911    46745    +1834
- Partials       6048     6606     +558

Flag
Coverage Δ

custom-integration1
<0.01% <ø> (-0.01%)
:arrow_down:

integration
<0.01% <ø> (-0.01%)
:arrow_down:

integration1
<0.01% <ø> (-0.01%)
:arrow_down:

integration2
0.00% <ø> (ø)

java-11
61.95% <ø> (+0.24%)
:arrow_up:

java-21
27.67% <ø> (-33.96%)
:arrow_down:

skip-bytebuffers-false
61.95% <ø> (+0.21%)
:arrow_up:

skip-bytebuffers-true
27.66% <ø> (-0.06%)
:arrow_down:

temurin
61.96% <ø> (+0.21%)
:arrow_up:

unittests
61.95% <ø> (+0.21%)
:arrow_up:

unittests1
46.51% <ø> (-0.38%)
:arrow_down:

unittests2
27.66% <ø> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Replaced by https://github.com/apache/pinot/pull/13552


Move core libraries to the "piston" repo

See Gfx moving some libraries to a single repo https://github.com/gfx-rs/gfx/issues/768.
Currently the piston repo is just a tiny library reexporting "input", "event" and "window". I have received feedback from various people finding the decoupled structure of Piston to be confusing. One source of confusion seems to be the organization of repos. The Piston core have a similar history to the Gfx library except the problem was more experimenting in design and the need for working on separate libraries. Now the core is more stable we could move them together again, and this will have no consequences since we use crates.io dependencies internally.

This is specifically aimed at input, event, and window then?
Personally, I think that things such as *_window / *_graphics things should be moved into the base project at the very least (window and graphics respectively), and then be able to use #[cfg()] on them so you only compile in what's needed, as I believe that's part of the reason to have them separated, right?  It seems a bit unnecessary to have them split up when Rust's cfg flags could do it nicely without a hard split of the repos.
Just my thoughts.  Anyway yeah, I'd be in support of a bit of consolidation of the repos.  :+1:

The idea is to keep the same crate structure, but move input, event and window into the piston repo. The dependency graph will stay the same. We can improve it without changing the architecture.
It might be a good idea to keep the window back-ends and the core separate, as back-ends are more unstable. The 2D graphics libraries should stay decoupled from the core.
We do not have the same problem here as with Gfx, where changes happens frequently across the libraries. I don't think users have problem understanding back-ends, but what makes it confusing is that Piston has both back-ends and a modular core. The problem is users being confused by the organization, because the core is spread across multiple repos, so they mix it up with the back-ends. The core does not change frequently, but the other libraries do and sometimes simultaneously, so it is more to gain by keeping the stuff evolving in parallel from each other.

@bvssvni +1 :+1:


Update: stevencohn.OneMore version 3.11.2

Removing old versions to reduce clutter
Microsoft Reviewers: Open in CodeFlow

/azp run


Related to get_node_index

This is running properly ---> nodes = @neo.get_node_index("Customer","id","4")
But this is creating error---->nodes = @neo.batch [:get_node_index, "Customer" ,"id" ,"4"]
Can anyone suggest me why this is creating problem ???
Please suggest me a more better way to find the existing node

Hi Akanksha,
I'll take a look at this today.
Thanks,
Max

Thanks for your reply.
I have sort out the problem .
If we want to use get_node_index/get_relationship_index in a batch then we have to add 1 case for each in get_batch method at the file "neography-0.0.21/lib/neography/rest.rb"
#for node and relationship
when :get_node_index
{:method => "GET", :to => "/index/node/#{args[1]}/#{args[2]}/#{args[3]}"}
when :get_relationship_index
{:method => "GET", :to => "/index/relationship/#{args[1]}/#{args[2]}/#{args[3]}"}

I added these and tests for them.  Available in version 23.


This should fix Create channel

This fixes any bugs that it had and added a few more things :D

There's nothing wrong with this code other than it's too slow sometimes and the bot getting rate-limited sometimes doesn't help.
Ultimately this PR didn't change anything but adding a name check which was already there-ish and duplicate the channel check.


chore: update dependencies

https://github.com/kentcdodds/kcd-scripts/releases/tag/v10.0.0

Codecov Report

Merging #38 (61e3cc9) into master (d34268b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   14.70%   14.70%
=======================================
  Files           2        2
  Lines          34       34
  Branches       14       14
=======================================
  Hits            5        5
  Misses         19       19
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34268b...61e3cc9. Read the comment docs.

Merged the dependabot PR instead 🙂 we should be able to trust it with keeping things up-to-date

That was only updating kcd-scripts and I updated all dependencies to latest minor


[BUG] JSQLParser Version : 4.6 : net.sf.jsqlparser.parser.TokenMgrException when parsing columns containing the ° character

Failing SQL Feature:
Token exception when parsing columns containing the ° character.
SQL Example:
```sql
select column1 as column_1°_of_many
from table_name;
```

(This syntax is supported in Amazon Redshift.)
Link
http://jsqlformatter.manticore-projects.com/jsqlformatter/demo.html?args=-c M4UwNiDGAuAEkHswFcC2A7AjLAhseSa6A+pgA3EIBmxqO6AngFCyuxUBOCqs0OARhGLocqEAG4gA

Greetings!
Possible, but I consider it way too obscure and bad practice, sorry. I won't fix it but I would accept non-invasive patches, that can fix it (without disturbing anything else).


Authentication for post requests

When posting data to the backend we should add some form of authentication in case there could be some malicious user. Something simple like a key should be enough. Spring already offers something like that (they have a whole suite of libs with "security" in their names)

no longer relevant


Added useFBXLoader wrapper similar to useGLTFLoader.

Updated storybook
Updated README.md

I review and asked for some minor changes, let me know if you can't do them, I can take care of it later. Thank you so much for the contrib!

I review and asked for some minor changes, let me know if you can't do them, I can take care of it later. Thank you so much for the contrib!

One thing i did ponder was if to return the  by default, with perhaps Destructuring [primative, fbx] or something like that.


@guildedjs/guilded-api-typings timeline

REST:

Discover all endpoints
Document endpoints

WS:

[x] ChatMessageCreated
[x] ChatMessageUpdated
[x] ChatMessageReactionAdded

Common:

[x] API structures (document, leaf, nodes)

Typings progress completed enough to close this.


ERR connect | miio.device, next try in 2 minutes | Error: Could not connect to device, handshake timeout

Hi again,
I changed apps from Mi HOme to ROborock
When changed to Roborock the app said that i had an update to my S6
I  did that restarted and now i get the above error when trying to view in HOME
Can someone assist?It was ok with MiHome

Hi @Mikellas,
When switching between apps (or even resetting the wifi connection), a new token is reissued and the previous one is invalidated. You'll need to retrieve the token again.

HI Alejandro and thanks for replying
I just figured that out myself!On another note do you happen to know if its possible to extract token from Roborock app specificaly?
Thanks again

sorry, I use the Xiaomi Mi app. I was hoping someone would answer in the Roborock app issue if they find a way (personally, I haven't tried).

Since you mentioned you figured out. I'll close the issue. Feel free to reopen it if you think it should remain open.


MeganavEntityApiController throws exception when linked content is deleted

The API controller currently throws the following exception when a non-existent entity ID is requested (deleted from recycle bin), e.g. /umbraco/backoffice/Meganav/MeganavEntityApi/GetById?id=0: System.InvalidOperationException: A null value was returned where an instance of HttpResponseMessage was expected..
This could be fixed by changing the following line:
https://github.com/thecogworks/meganav/blob/efae678daa1c7898f67926234ac7419a69a494dc/src/Cogworks.Meganav/Web/Controllers/API/MeganavApiController.cs#L28
to
return this.NotFound();

The AngularJS controller could even be updated to report these items (like with unpublished items) or even automatically remove them...

@ronaldbarendse great finding! Can you submit a PR with this change?

Closing as this controller is now gone in V2 / V3 of Meganav.


Double awaits in a few places

Thanks @StephenCleary for bringing us this great library, really appreciate it!
I was wondering, could we omit the outer await and simply return the result of the inner one? Would that be identical and if so, emit simpler IL code?
https://github.com/StephenCleary/AsyncEx/blob/0361015459938f2eb8f3c1ad1021d19ee01c93a4/src/Nito.AsyncEx.Tasks/TaskExtensions.cs#L32-L36

I don't see how that would work. The inner await returns a task that may be complete, faulted, or canceled; and the outer await detects faults/cancellations and raises the appropriate exception.
Feel free to re-open if I've misunderstood something.

@StephenCleary You are absolutely right, thanks for the "clearyfication"! 😀

@StephenCleary You are absolutely right, thanks for the "clearyfication"! 😀

Hi @tvass83, I found your post very interesting and familiar. One of my devs used to code this way, however, it was very difficult to debug the code.
What helped us all was to review @StephenCleary cookbook and blogs. First, understanding the programming model around tasks and awaitables. We agreed to first declare Task variables and then await. not only improved the code readability, but it also improved our debugging and testing process.
What we found also very helpful in our organization, was to give some training to our devs on CPU-bound vs IO-bound operations. In summary, when the devs grokked the concepts, they thrilled on developing and delivering the project.
HTH.


Postgresql error context (where) information is missing, please consider including 'W' context error field.

Feature Flags
postgresql
Problem Description
Error reporting with diesel::result::Error::DatabaseError is missing context information for postgresql. This makes it harder to troubleshoot where database error happens.
What are you trying to accomplish?
E.g. I have a before delete trigger that calls a function that has more fields in INSERT INTO (fields...) than SELECT that follows.
Error presented by many clients when I try to delete the row that would trigger the trigger/function is:
SQL Error [42601]: ERROR: INSERT has more target columns than expressions
  Where: PL/pgSQL function fn_insert_point_log_on_deleted_collection() line 6 at SQL statement

What is the actual output?
Diesel most detailed presentation of the error is:
"error":"INSERT has more target columns than expressions, kind: __Unknown, details: None, hint: None, table: None, column: None, constraint: None"

Only message field is non-empty in this case via Diesel:
INSERT has more target columns than expressions

kind, details, hint, table, column, constraint name are all None.
What is the expected output?
One would expect diesel to provide that "where" bit of the information:
  PL/pgSQL function fn_insert_point_log_on_deleted_collection() line 6 at SQL statement

Per
enum ResultField {
    SqlState = 'C' as i32,
    MessagePrimary = 'M' as i32,
    MessageDetail = 'D' as i32,
    MessageHint = 'H' as i32,
    TableName = 't' as i32,
    ColumnName = 'c' as i32,
    ConstraintName = 'n' as i32,
}

And trait:
pub trait DatabaseErrorInformation {
fn message(&self) -> &str;
fn details(&self) -> Option<&str>;
fn hint(&self) -> Option<&str>;
fn table_name(&self) -> Option<&str>;
fn column_name(&self) -> Option<&str>;
fn constraint_name(&self) -> Option<&str>;
}

There is no way to convey that context/where information that is contained in https://github.com/postgres/postgres/blob/master/src/include/postgres_ext.h:
#define PG_DIAG_CONTEXT			'W'

It would be great if someone can decide if DatabaseErrorInformation deserves a new method like context() or if this context information can be added to the "details()" implementation of PgErrorInformation trait implementation:
impl DatabaseErrorInformation for PgErrorInformation {
    fn message(&self) -> &str {
        get_result_field(self.0.as_ptr(), ResultField::MessagePrimary)
            .unwrap_or_else(|| self.0.error_message())
    }

    fn details(&self) -> Option<&str> {
        get_result_field(self.0.as_ptr(), ResultField::MessageDetail)
    }

Adding this context information is something that would help the error logging in common, but I also think that it can improve situation with reporting migration errors? See #2378 - More verbose errors on diesel migrations?
I can help with implementation, but this is something that spans multiple database systems as pub trait DatabaseErrorInformation is generic and I'd need guidance on how to implement. I can imagine providing a PR with adding 'W' Context into ResultField and adding this to details of PgErrorInformation, but I'm not sure this would be the best approach.
Or I'm missing some easy way of getting this context information without extending anything?

In https://github.com/diesel-rs/diesel/pull/1572, wg tried to solve a similar problem. However, it isn't completed.

In #1572, wg tried to solve a similar problem. However, it has not completed yet.

Suggested 'P' returns a string with a decimal integer of error position in the SQL.
Actually for the kind of error that is described in this issue, it returns as None.
I commented on the issue you mentioned. Hopefully the fact that 'P' contains a string with a decimal integer value may help to move with the awaiting PR/merge.
Though I'd still believe that adding context() based on 'W' is quite beneficial for troubleshooting the errors.
May I prepare a PR with a context() method, similar to what was done in #1572 for 'P'?

Opening a PR would certainly make it easier to discuss the design. Otherwise this seems like a meaningful addition for me.

SqlState also would be helpful as a separate getter.
Many DBMS supports error codes beyond string message

SqlState also would be helpful as a separate getter.
Many DBMS supports error codes beyond string message

What about SqlState ? should it be addressed in another issue?

@Mart-Bogdan That's completely unrelated to this issue. Feel free to write a proposal adding such an API in our discussion forum, but be sure to answer the questions outlined in our contribution guidelines.


renamed specs files to add them in rake test

Description
All the spec file names should have suffix "_spec" to the filenames, which is missed for few files and those files are ignored during UTs execution. Changed the file names as required.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass ($ rake test).
[ ] New resources and/or actions have are included in the matchers.rb and matchers_spec.

[ ] New functionality has been documented in the README if applicable.

[ ] New functionality has been thoroughly documented in examples (please include helpful comments).

[ ] Changes documented in the CHANGELOG.

Please add below test case also under this PR:
https://github.com/HewlettPackard/oneview-chef/blob/master/spec/unit/resources/enclosure/import_certificate.rb

@soodpr I have added UTs for enclosure.


Snap isn't working on Wayland

I tried starting the Moonlight stable snap (1574) under Wayland on both Fedora 35 and Ubuntu 22.04 Beta.
In both cases, the result was an infinite stream of "Couldn't open plugin directory: No such file or directory" messages that required me to kill -9 moonlight.
00:00:00 - SDL Info (0): Compiled with SDL 2.0.21
00:00:00 - SDL Info (0): Running with SDL 2.0.21
00:00:00 - Qt Info: Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
00:00:00 - Qt Warning: QSocketNotifier: Can only be used with threads started with QThread
00:00:00 - Qt Debug: Using Wayland-EGL
00:00:00 - Qt Info: No translation available for  "en_US"
00:00:00 - SDL Info (0): Detected Wayland
00:00:00 - Qt Warning: qrc:/gui/main.qml:12:1: QML ApplicationWindow: ToolTip must be attached to an Item
00:00:00 - Qt Info: Found "gamecontrollerdb.txt" at ":/data/gamecontrollerdb.txt"
00:00:00 - SDL Info (0): Loaded 202 new gamepad mappings
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
Couldn't open plugin directory: No such file or directory
[...]

Manually forcing Qt to run using the X11 backend (passing -platform xcb) does work though, so it seems like maybe something is wrong with how the Qt Wayland plugin is being packaged in the Snap.

Thanks for the report! Turned out to be libdecor looking for plugins outside of the snap (with a weird looking logic). It's not reproducible in KDE Plasma, fwiw.
Just updated edge and candidate builds with the env var pointing to the correct plugin dir.

Thanks, I confirm that fixes the issue for me.

Promoted to stable now. Thanks.


Symbol of a documentation parameter comes as empty

Description:
The symbol of a markdown documentation parameter results in an empty Optional<Symbol>.
Steps to reproduce:
# Description
#
# + x - Field Description
public type Coord record {
    readonly int x;
    # + y - Field Description
    int y;
};

Get the symbol of x documentation parameter.
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

The documentation parameter x symbol can be retrieved with an implementation in the SymbolFinder.
Do we also need to get the markdownDocAttachment parameter symbol y which is of a record field symbol?


Missing transactionId in type GlassfyTransaction returned from Glassfy.purchaseSku(sku)

Hi,
Could you make the transactionId property available in type GlassfyTransaction returned by the purchase function Glassfy.purchaseSku(sku).
We need to be able to have a validation process between our front and back end. The id will be sent to our backend when unlocking feature x. Then the backend can verify if the transaction exists in the original_transaction_id property of the /subscriber API endpoint return object. This allows us to prevent users to unlock features by simply calling an endpoint without a third party validation from our backend. The transactionId will be associated to the feature unlock in our business logic.
Thank you.

Sorry at the moment we are not are not planning to support this type of backend verification .
Please have a look at glassfy webhooks to implement backend processing of the transaction.


Update Basic.md

failure to  call  absoluteString() in the document

Warnings

:warning:

Consider also updating the Chinese docs. For Chinese translations, request the modified file(s) to be added to the list here for someone else to translate, if you can't do so yourself.

Messages

:book:
macOS: 	 Executed 283 tests, with 0 failures (0 unexpected) in 16.227 (16.587) seconds

:book:
tvOS: 	 Executed 283 tests, with 0 failures (0 unexpected) in 13.183 (13.566) seconds

:book:
iOS: 	 Executed 283 tests, with 0 failures (0 unexpected) in 13.142 (13.514) seconds

Proselint report on docs_CN/Examples/Basic.md

Line
Message
Severity

180
Annotation left in text.
warning

  Generated by :no_entry_sign: Danger Swift against 517f65d69212051646900642cc02c7e04671b573

Hmm, nothing against this PR, but I find a bit misleading that the parameter name is url and its expected type is String. Makes sense to change the type to URL? 🤔

Hmm, nothing against this PR, but I find a bit misleading that the parameter name is url and its expected type is String. Makes sense to change the type to URL? 🤔

@jdisho I think it does make sense, but I don't know if maybe there is an overload(to simplify calls) and there another that takes an URL? Not sure, but if it is the only one, change to URL makes sense but that would be a breaking change...

@jdisho @LucianoPAlmeida I was actually surprised myself that we pass the String type, even though we still need to convert it to URL when passing to URLRequest afterwards. Not sure if there is anything against changing it the type to URL (besides the fact that people would need to update & need to release major version), but maybe we can try with a PR and see how it goes?

Codecov Report

Merging #2016 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2016   +/-   ##
=======================================
  Coverage   92.55%   92.55%
=======================================
  Files          26       26
  Lines         887      887
=======================================
  Hits          821      821
  Misses         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd0f9e...30872ab. Read the comment docs.

@jdisho @LucianoPAlmeida I was actually surprised myself that we pass the String type, even though we still need to convert it to URL when passing to URLRequest afterwards. Not sure if there is anything against changing it the type to URL (besides the fact that people would need to update & need to release major version), but maybe we can try with a PR and see how it goes?

@sunshinejr @jdisho Maybe to not be a breaking change, we can just add another overload with the same signature, just with URL type, without removing the string one, maybe just deprecate the string version... :)


openPath triggering closed event in Container

Hey,
More of a usability thing, and not sure if this was intended, but the closed event is triggered as soon as you call openPath on the Container. The reset() method dispatches it by default via _internalIOpen even if nothing has been opened before..
Cheers,
Jamie

This should be changed. Good catch.
As a workaround, you could use the Container's loaded property in your closed handler to check if it's a "real" closed event.

Changed for the next release.


Add support for pagination in connectors

The retrievePermissions() call and the associated /connectors/:connector_id/permissions endpoint should take optional pagination parameters.
GetConnectorPermissionsRes will add a totalResourcesCount with the total number of results.

Closing this one as it is likely that we will go to core instead of connectors in a close future and will implement pagination there.


credhub-cli: 2.9.3 -> 2.9.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cloudfoundry-incubator/credhub-cli/releases.
meta.description for credhub-cli is: "Provides a command line interface to interact with CredHub servers"
meta.homepage for credhub-cli is: "https://github.com/cloudfoundry-incubator/credhub-cli"
meta.changelog for credhub-cli is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.9.4 with grep in /nix/store/4wr6shrqqb26kx2r1nb40lw4hyq79dnc-credhub-cli-2.9.4
found 2.9.4 in filename of file in /nix/store/4wr6shrqqb26kx2r1nb40lw4hyq79dnc-credhub-cli-2.9.4

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
credhub-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4wr6shrqqb26kx2r1nb40lw4hyq79dnc-credhub-cli-2.9.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A credhub-cli https://github.com/r-ryantm/nixpkgs/archive/fba935efda5498032ed855ad81982130de7145df.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4wr6shrqqb26kx2r1nb40lw4hyq79dnc-credhub-cli-2.9.4
ls -la /nix/store/4wr6shrqqb26kx2r1nb40lw4hyq79dnc-credhub-cli-2.9.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

credhub-cli

Maintainer pings
cc @risicle for testing.

Result of nixpkgs-review pr 188646 run on x86_64-linux 1

1 package built:

credhub-cli


Bump version to 1.3.0

Thank you! I created commit https://github.com/SAP/python-pyodata/commit/e4c941f66aeac0a445518b2ea3d9ad0ab5ccca9b


Fix spurious proto: tag has too few fields warning

Fixes https://github.com/istio/istio/issues/22261.

@ostromart: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-security-k8s-tests_istio

unit-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-security-k8s-tests_istio

unit-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-security-k8s-tests_istio

unit-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-pilot-k8s-tests_istio

integ-conformance-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-security-k8s-tests_istio

unit-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-pilot-k8s-tests_istio

integ-conformance-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-conformance-k8s-tests_istio

integ-mixer-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
88c72c74f451cba725e8d91b11ca226f3e897a46
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
d10ea74dfe5ac24e6560c933a4b0ca6bfbb8b353
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ostromart: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
d10ea74dfe5ac24e6560c933a4b0ca6bfbb8b353
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #22320


Can sw supports Custom notification for performance alert, eg, email, wechat and so on.

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[*] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

If they are Apache 2.0 compatible license, we are open to accept PR, but today, no one is working on that.


Using recommended metrics in train_molnet.py

Now there are some problems in this PR.

we can't save models because this implementation use defined function in
AttributeError: Can't pickle local object 'main.<locals>.loss_fun'
https://github.com/mottodora/chainer-chemistry/blob/f35b10ad6e8bd19dba0cc1eb1d1338f51fefcdcf/examples/molnet/train_molnet.py#L179-L180

In some datasets, it seems Evaluator raises ValueError Because

Codecov Report

Merging #233 into master will decrease coverage by 0.23%.
The diff coverage is 31.34%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   81.89%   81.65%   -0.24%
==========================================
  Files         106      106
  Lines        5114     5162      +48
==========================================
+ Hits         4188     4215      +27
- Misses        926      947      +21

as written in the error message

AttributeError: Can't pickle local object 'main..loss_fun'

you can try defining function in global scope and try pickle again?

('Only one class present in y_true. ROC AUC score is not defined in that case.',)
It means that dataset contains only one of positive or negative label. This is caused by may be too imbalanced dataset, but is it really expected behavior??

could you resolve conflict?

Update.


Texture error with walls when using optifine

Didn't test this without optifine but here's a screenshot of the issue

I have been able to replicate the problem and i have found the culprit and I've updated the mod with the fix


docs-bug(mat-tab-nav): "selectedIndex" does not exist

Documentation Feedback
Affected documentation page: https://material.angular.io/components/tabs/api
Issue: mat-tab-nav-bar has a documented "selectedIndex" attribute, but it does not appear to exist.
I ran into the issue and then found a fix at https://stackoverflow.com/questions/50349155/selectedindex-is-not-working-for-mat-tab-nav-bar-angular-material-tabs

The docs are correct. Note that the selectedIndex isn't marked as an Input which means you can't bind to it.


Add tailwindcss to make the website look better

The website login page looks terrible, tailwindcss would help a lot! (or maybe bootstrap)

I added tailwindcss but it resulted in it stripping all css from the website. This makes it more difficult for me to add in the backend because I can't see what I'm doing. Also, I would have to add react to create components and that would be too much because it would require writing in jsx which might prevent flask from using jinja. Bootstrap might be the best option


add enable-preview to the dockerfile

Summary
Fixes https://github.com/slackhq/kaldb/issues/775
Dockerfile missing flag enable-preview causes runtime error. This allows the docker image to be run.
Requirements

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

Thanks for your first contribution @autata!
We're aware the current onboarding/documentation experience is pretty rough right now, and contributions are always welcome! We plan to be moving towards a first versioned release towards the middle of this year, and prior to that we'll be greatly investing into the documentation and onboarding.

Awesome, great to hear! I'm planning on contributing to the onboarding as well. As I go through the process myself.


Specify a page that will actually have user settings accessible in the top righthand corner

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token
What part(s) of the article would you like to see updated?
I saw data/reusables/user-settings/access_settings.md at https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token#creating-a-token.
That article said,

In the upper-right corner of any page, click your profile photo, then click Settings.

The page that article was on did not have a user icon in the top righthand corner.
The end result is that it should be easier for readers to access their user settings to create a personal access token, or PAT, by directly linking to a page that will actually have those settings readily accessible.
Additional information

👋 @hamirmahal Thanks for opening an issue! We use this reusable on many, many pages throughout the docs. Since your profile photo is visible in the top right hand corner of any page on GitHub, we're not going to add a link at this time.


Change \r\n to \n when reading source files

Before, running esformatter on OS X and Windows gave different results.
Changing the \r\n to \n fixes the inconsistent output.

I noticed that on my colleague's Windows machine, after running esformatter on the whole codebase, many files have their line endings changed. Is this a problem with my current patch, or should it be solved as another issue?

esformatter have an option to set which line end it should use for the output: https://github.com/millermedeiros/esformatter/blob/425fc93381565893c33520f4a5346aa97a3aebdb/lib/preset/default.json#L54-L55 - it defaults to \n
and our parser already treats different line breaks the same way, so this change should not be needed: https://github.com/millermedeiros/rocambole/blob/abbe4bcfc4274d7602b4adecbb19e0fd68c45ef4/rocambole.js#L321-L362

now that I looked at this again, maybe the file contained [\u2028\u2029].. and that is not being handled by rocambole. If that is the case we should probably update it to handle it.

If the Windows line endings are being handled by the library then I'm not
sure what was going on.
I have just recently upgraded our version of esformatter to use the current
upstream version that doesn't include the fix in this PR.
If the problem persists on my colleague's machine I will look into it
further to verify whether the culprit is the Windows new line endings or
\u2028 and \u2029.
On Wed, Feb 10, 2016 at 3:39 AM, Miller Medeiros<EMAIL_ADDRESS>wrote:

now that I looked at this again, maybe the file contained [\u2028\u2029]..
and that is not being handled by rocambole. If that is the case we should
probably update it to handle it.
—
Reply to this email directly or view it on GitHub
https://github.com/millermedeiros/esformatter/pull/379#issuecomment-182253302
.

still not sure if this was needed or not.. so I'm closing for now.