Saving frozen model to tflite error

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes, I write own model define, loss and training codes.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 14.04
TensorFlow installed from (source or binary): binary, pip install
TensorFlow version (use command below): 1.4.0
Python version:  2.7
Bazel version (if compiling from source): 0.10.0
GCC/Compiler version (if compiling from source): 4.9.4
CUDA/cuDNN version: 8.0
GPU model and memory: GeForce GTX 1060
Exact command to reproduce:

Describe the problem
I have train some customized model with tensorflow and trying to make it a tensorflow lite model for mobile apps. I success in freezing the model and viewing it in tensorboard. I get error when I trying to save it to a tensorflow lite file.
my model defins like:
`def P_Net(inputs,label=None,bbox_target=None,landmark_target=None,training=True):
    #define common param
    with slim.arg_scope([slim.conv2d],
                        activation_fn=prelu,
                        weights_initializer=slim.xavier_initializer(),
                        biases_initializer=tf.zeros_initializer(),
                        weights_regularizer=slim.l2_regularizer(0.0005),
                        padding='valid'):
        print inputs.get_shape()
        net = slim.conv2d(inputs, 28, 3, stride=1,scope='conv1')
......
        conv4_1 = slim.conv2d(net,num_outputs=2,kernel_size=[1,1],stride=1,scope='conv4_1',activation_fn=tf.nn.softmax)
        #conv4_1 = slim.conv2d(net,num_outputs=1,kernel_size=[1,1],stride=1,scope='conv4_1',activation_fn=tf.nn.sigmoid)

        print conv4_1.get_shape()
        #batch*H*W*4
        bbox_pred = slim.conv2d(net,num_outputs=4,kernel_size=[1,1],stride=1,scope='conv4_2',activation_fn=None)
        print bbox_pred.get_shape()`

where conv4_1 and conv4_2 is the output layer.
I freeze the model with:
freeze_graph.freeze_graph('out_put_model/model.pb', '', False, model_path, 'Squeeze,Squeeze_1', '', '', 'out_put_model/frozen_model.pb', '', '')
I use tensorboard to view the graph and even try to read them back and forward. it produces same result as reading from checkpoint.

Squeeze and Squeeze_1 is the output nodes. image_height, image_width, input_image is input nodes. all of the input nodes is not fixed shape, and resized in the graph.
code of input placeholder like:
with graph.as_default():
            #define tensor and op in graph(-1,1)
            self.image_op = tf.placeholder(tf.float32, name='input_image')
            self.width_op = tf.placeholder(tf.int32, name='image_width')
            self.height_op = tf.placeholder(tf.int32, name='image_height')
            image_reshape = tf.reshape(self.image_op, [1, self.height_op, self.width_op, 3])
            #self.cls_prob batch*2
            #self.bbox_pred batch*4
            #construct model here
            #self.cls_prob, self.bbox_pred = net_factory(image_reshape, training=False)
            #contains landmark
            self.cls_prob, self.bbox_pred, _ = net_factory(image_reshape, training=False)

I find the tensorflow 1.4.0 don't have tf lite module and checkout tensorflow master branch from github. and run bazel toco for a tflite model.
 bazel run --config=opt   //tensorflow/contrib/lite/toco:toco --   --input_file='/home/sen/mtcnn_cat/MTCNN-Tensorflow/test/out_put_model/frozen_model.pb'    --output_file='/home/sen/mtcnn_cat/MTCNN-Tensorflow/test/out_put_model/pnet.tflite'    --inference_type=FLOAT   --input_shape=None,None,None   --input_array=image_height,image_width,input_image   --output_array=Squeeze,Squeeze_1  --input_format=TENSORFLOW_GRAPHDEF --output_format=TFLITE --dump_graphviz=/tmp
but I got this error:
INFO: Analysed target //tensorflow/contrib/lite/toco:toco (0 packages loaded).
INFO: Found 1 target...
Target //tensorflow/contrib/lite/toco:toco up-to-date:
  bazel-bin/tensorflow/contrib/lite/toco/toco
INFO: Elapsed time: 0.288s, Critical Path: 0.00s
INFO: Build completed successfully, 1 total action

INFO: Running command line: bazel-bin/tensorflow/contrib/lite/toco/toco '--input_file=/home/sensetime/mtcnn_cat/MTCNN-Tensorflow/test/out_put_model/frozen_model.pb' '--output_file=/home/sensetime/mtcnn_cat/MTCNN-Tensorflow/test/out_put_model/pnet.tflite' '--inference_type=FLOAT' '--input_shape=None,None,None' '--input_array=image_height,image_width,input_image' '--output_array=Squeeze,Squeeze_1' '--input_format=TENSORFLOW_GRAPHDEF' '--output_format=TFLITE' '--dump_graphviz=/tmp'
ERROR: Non-zero return code '1' from command: Process exited with status 1

what's the problem? is the input_array, input_shape, output_array parameter right?
Thanks and any suggestion is welcome.

I suspect the problem is the input shape  --input_shape=None,None,None try an explicit value there.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 30 days with no activity and the awaiting response label was assigned. Is this still an issue?

@aselle But this is a fully conv operation, input image and size is not fixed. How to set the input-shape?

does this mean TF Lite only supports fixed input sizes?

Nagging Assignee @aselle: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

does this mean TF Lite only supports fixed input sizes?

No, it means that the conversion supports fixed sizes. You can resize inputs after you have converted. Of course, depending on your model, this may or may not work (this is true in tensorflow as well). You can often resize to accept different batch sizes, so if you make your input size 1,244,244,3 for an image input you can resize at runtime to 10,244,244,3 to allow a batch size fo 10.

Please let me know if using an explicit size fixed your problem. If so, please close the plug!

explicit size do fix this problem, I am encountering some operators not supported problem like:
 Some of the operators in the model are not supported by the standard TensorFlow Lite runtime. If you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.contrib.lite.toco_convert(). Here is a list of operators for which  you will need custom implementations: Abs.
I am closing this issue


Polling modbus TCP

HI; just a ticket for asking you a question.
I am currently working on a personal project requiring me to do a continuous polling loop on a modbus TCP server; see https://github.com/mhemeryck/modbridge for my project. The idea is to push any detected changes from the polling loop into an MQTT event. The use case I am looking at is having something PLC-like in a home automation setup.
For the modbus part, I heavily rely on your excellent modbus package. Some questions I have come across now:

polling coils separately or as groups: my implementation solely relies on polling the modbus coils (for now). Initially, I figured to do a continuous polling of all the different coils one-by-one (in a goroutine). This works, but it seems rather overkill, considering in practice most of the coil addresses are sequential in nature thus allowing for this range to be polled and then interpreting these results. However, initial results do not seem to indicate that much of a performance gain. Question: do you think it is better to poll the coils one-by-one or rather in a group?
TCP connections: if I am not mistaken, each of the calls would involve creating another TCP connection; do you think there could be a gain by keeping the same TCP connection open for continuous polling? Added to that, what would be the best way to implement something like that? (i.e. yet another implementation of the transporter interface?)
architecture-wise: coming from python, I still have a lot to learn switching to golang for this project. I currently pass in a modbus client instance to my polling functions; would it make more sense to have something like a pointer to a singleton? Any comments on the idiomatic way to handle this?

Thanks in advance, and thanks again on this great package!

From looking the code (e.g. https://github.com/goburrow/modbus/blob/606c02f4eef527a1d4cf7d8733d5fd7ba34f91d8/tcpclient.go), the connection only closes after a time-out of 60s, so I assume it's not really required to manage the TCP connection any other way for my purpose, right?

@mhemeryck You no need manage TCP connection. Connection closed when Close method called or after timeout when not have any activity by flag mb.lastActivity

Thanks for the quick feedback, this confirms what I found there :+1:
That's actually nice, since it means I don't need to do any management on the TCP connection level. I would only need to make sure I would re-use the same client -- which I am already doing. I could perhaps find some speed-up in having multiple clients each doing their own polling (but then the server would need to be able to keep with that as well).
For the rest I guess I will need to do a more proper time profiling in my own package to see how I can further increase the reaction time.

Just noticed this ticket was still open; my question was pretty much answered by now.
For my setup, I did end up having each of my groups of coils to be polled have their own client instance. I still think it's probably not that "pretty", but as the client manages the connection itself, it makes sense I suppose.


Selected or active todo row should be visually highlighted

Bug Report
IMPORTANT:
Please follow this template strictly when reporting bugs. Providing detailed and accurate information helps the development team to understand and address the issue effectively.
App Version: v2.0.2
Platform: Windows
Installation Method: App Store
Bug Description:
The interface of the task list has a minor and not-so-minor clarity problem: the items of the list don't get highlited by the pointer nor react on selecting them with right click. Nor is there a way to select many at once. But more importantly, if selected to delete a task a prompt appears saying "delete task?" but it doesn't indicate WHICH task is about to be deleted. If the user is interrupted they might not remember which item it was or the user might accidentally select another task.
Steps to Reproduce:

Right-click on a task and select to delete it.

Expected Behavior:
The list items give an indication of being about to be selected and selected. The delete modal indicates which task is about to be deleted on top of it being highlighted.
Actual Behavior:
No hover. No indication of which task is about to be deleted.
Additional Information:
Screenshots:

I second that request, I also miss the visual feedback to better see which todo is being deleted.


Clean-up step of migrating Jenkins shared libraries to opensearch-build-libraries repo

Description
This is one of the clean-up steps of moving Jenkins shared lib from opensearch-build to opensearch-build-libraries
#2646
Issues Resolved
In this PR:

Remove/Clean vars + adding lib session on a few of jobs that did not have it previously to prevent the 'lib@20211123 not found' issue from happening again.

Remove/Clean couple of test jobs that have been migrated to opensearch-build-libraries repo, here is the list:
(the following jobs had been moved to opensearch-build-libraries repo previously )
TestArchiveAssembleUpload.groovy
TestAssembleManifest.groovy
TestAssembleUpload.groovy
TestBuildArchive.groovy
TestBuildAssembleUpload.groovy
TestBuildDockerImage.groovy
TestBuildFailureMessage.groovy
TestBuildInfoYaml.groovy
TestBuildManifest.groovy
TestBuildUploadManifestSHA.groovy
TestBuildYumRepo.groovy
TestCopyContainer.groovy
TestCreateGithubIssue.groovy
TestCreateReleaseTag.groovy
TestCreateTestResultsMessage.groovy
TestDetectDockerImage.groovy
TestDetectTestDockerAgent.groovy
TestDownloadFromS3.groovy
TestGetManifestSHA.groovy
TestInputManifest.groovy
TestMessages.groovy
TestParallelMessages.groovy
TestPostCleanup.groovy
TestPrintArtifactDownloadUrlsForStaging.groovy
TestPromoteArtifacts.groovy
TestPromoteYumRepos.groovy
TestPublishNotification.groovy
TestRpmDashboardsDistValidation.groovy
TestRpmMetaValidation.groovy
TestRpmOpenSearchDistValidation.groovy
TestRunBwcTestScript.groovy
TestRunGradleCheck.groovy
TestRunIntegTestScript.groovy
TestRunPerfTestScript.groovy
TestScanDockerImage.groovy
TestSignArtifacts.groovy
TestUploadIndexFile.groovy
TestUploadMinSnapshotsToS3.groovy
TestUploadTestResults.groovy
TestUploadToS3.groovy
TestbuildManifestVar.groovy
(the following jobs are staying at opensearch-build repo)
TestCCRPerfTest.groovy
TestDataPrepperReleaseArtifacts.groovy
TestMavenSignReleaseJob.groovy
TestOpenSearchBwcTest.groovy
TestOpenSearchDashboardsBwcTest.groovy
TestOpenSearchDashboardsIntegTest.groovy
TestOpenSearchIntegTest.groovy
TestPromoteContainer.groovy
TestRunNonSecurityPerfTestScript.groovy
TestSignStandaloneArtifactsJob.groovy
TestReleaseTagJob.groovy ( this job is temporary removed and will be restored at later time)

Remove/Clean lib-testers + Merging some codes from lib-testers onto the remaining test jobs listed above

Remove/Clean src/jenkins + code refactoring

Change build.gradle from multithreads to single one in order to prevent possible future problems

Remove/Clean tests/jenkins/jobs as it had been migrated to opensearch-build-libraries repo previousely

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2679 (fcd1929) into main (9e80f02) will increase coverage by 5.75%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #2679      +/-   ##
===========================================
+ Coverage   94.24%   100.00%   +5.75%
===========================================
  Files         162         6     -156
  Lines        4313       105    -4208
  Branches       19        19
===========================================
- Hits         4065       105    -3960
+ Misses        248         0     -248

Impacted Files
Coverage Δ

...rkflow/integ_test/service_opensearch_dashboards.py

src/ci_workflow/ci_check_list_dist.py

src/system/zip_file.py

...w/bwc_test/bwc_test_start_properties_opensearch.py

.../release_notes_workflow/release_notes_component.py

...c/manifests_workflow/input_manifests_opensearch.py

...teg_test/integ_test_start_properties_opensearch.py

src/test_workflow/integ_test/distributions.py

src/sign_workflow/signer.py

src/manifests/bundle_manifest.py

... and 146 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Hey @jordarlu you can clean up some Jenkinsfiles in tests/jenkins/jobs/ folder, example AssembleUpload_Jenkinsfile, these Jenkinsfiles used to test methods.

Thanks for the comment @prudhvigodithi ,, I am hesitating on which of those can be removed/shall be staying ...   would it be possible letting me know? and I will run test at my local and then update in PR. Thanks!!

Hey @jordarlu yes the files that test the libraries example AssembleUpload_Jenkinsfile in tests/jenkins/jobs/ is not required, as it has been tested in opensearch-build-libraries repo.
file link https://github.com/opensearch-project/opensearch-build-libraries/blob/main/tests/jenkins/jobs/ArchiveAssembleUpload_Jenkinsfile

Thank you, @prudhvigodithi , let me remove that file as well

Thank you, @prudhvigodithi , let me remove that file as well

I mean it has many like them :)
But i'm ok to merge this to unblock the groovy tests.
Thank you

right, right .. we can clean more few others at alter ... trying to get the Jacoco to be happy again sooner ..  :)

Many of the files under /jobs needs to be removed as well. @jordarlu Can you compare and just delete them from here too? Should be straight forward. Thanks!

Thanks for the guidance, Sayali.. I compared /jobs/ between both repo, the build and build-lib, but found they are almost identical.
The build-lib repo has 2 files ( DockerCopy_Jenkinsfile and PerfTest_JenkinsFile) more than the build repo..
Does that mean we want to delete the entire /jobs/ at build repo?

Build Repo
Build-lib Repo

ArchiveAssembleUpload_Jenkinsfile
ArchiveAssembleUpload_Jenkinsfile

AssembleManifest_rpm_Jenkinsfile
AssembleManifest_rpm_Jenkinsfile

AssembleManifest_tar_Jenkinsfile
AssembleManifest_tar_Jenkinsfile

AssembleUpload_Jenkinsfile
AssembleUpload_Jenkinsfile

Build_OpenSearch_Dashboards_Jenkinsfile
Build_OpenSearch_Dashboards_Jenkinsfile

BuildArchive_Jenkinsfile
BuildArchive_Jenkinsfile

BuildAssembleUpload_Jenkinsfile
BuildAssembleUpload_Jenkinsfile

BuildDockerImage_Jenkinsfile
BuildDockerImage_Jenkinsfile

BuildDockerImage_Qualifier_Jenkinsfile
BuildDockerImage_Qualifier_Jenkinsfile

BuildFailureMessage_Jenkinsfile
BuildFailureMessage_Jenkinsfile

BuildInfoYaml_Jenkinsfile
BuildInfoYaml_Jenkinsfile

BuildManifest_Jenkinsfile
BuildManifest_Jenkinsfile

BuildManifest_Jenkinsfile_component_no_artifact
BuildManifest_Jenkinsfile_component_no_artifact

BuildShManifest_Jenkinsfile
BuildShManifest_Jenkinsfile

BuildUploadManifestSHA_Jenkinsfile
BuildUploadManifestSHA_Jenkinsfile

BuildYumRepo_Jenkinsfile
BuildYumRepo_Jenkinsfile

CreateGithubIssue_Jenkinsfile
CreateGithubIssue_Jenkinsfile

CreateGithubIssueExisting_Jenkinsfile
CreateGithubIssueExisting_Jenkinsfile

CreateReleaseTag_Jenkinsfile
CreateReleaseTag_Jenkinsfile

CreateTestResultsMessage_Jenkinsfile
CreateTestResultsMessage_Jenkinsfile

DetectDockerImage_Jenkinsfile
DetectDockerImage_Jenkinsfile

DetectTestDockerAgent_Jenkinsfile
DetectTestDockerAgent_Jenkinsfile

DockerCopy_Jenkinsfile

DownloadFromS3_Jenkinsfile
DownloadFromS3_Jenkinsfile

GetManifestSHA_Jenkinsfile
GetManifestSHA_Jenkinsfile

Hello_Jenkinsfile
Hello_Jenkinsfile

InputManifest_Jenkinsfile
InputManifest_Jenkinsfile

Messages_Jenkinsfile
Messages_Jenkinsfile

ParallelMessages_Jenkinsfile
ParallelMessages_Jenkinsfile

PerfTest_JenkinsFile

PostCleanup_Jenkinsfile
PostCleanup_Jenkinsfile

PrintArtifactDownloadUrlsForStaging_Jenkinsfile
PrintArtifactDownloadUrlsForStaging_Jenkinsfile

PromoteArtifacts_actions_Jenkinsfile
PromoteArtifacts_actions_Jenkinsfile

PromoteArtifacts_actions_OpenSearch_Dashboards_Jenkinsfile
PromoteArtifacts_actions_OpenSearch_Dashboards_Jenkinsfile

PromoteArtifacts_Jenkinsfile
PromoteArtifacts_Jenkinsfile

PromoteArtifacts_OpenSearch_Dashboards_Jenkinsfile
PromoteArtifacts_OpenSearch_Dashboards_Jenkinsfile

PromoteArtifactsQualifier_actions_Jenkinsfile
PromoteArtifactsQualifier_actions_Jenkinsfile

PromoteArtifactsQualifier_actions_OpenSearch_Dashboards_Jenkinsfile
PromoteArtifactsQualifier_actions_OpenSearch_Dashboards_Jenkinsfile

PromoteArtifactsQualifier_Jenkinsfile
PromoteArtifactsQualifier_Jenkinsfile

PromoteArtifactsQualifier_OpenSearch_Dashboards_Jenkinsfile
PromoteArtifactsQualifier_OpenSearch_Dashboards_Jenkinsfile

PromoteYumRepos_Jenkinsfile
PromoteYumRepos_Jenkinsfile

PublishNotification_Jenkinsfile
PublishNotification_Jenkinsfile

RpmDashboardsDistValidation_Jenkinsfile
RpmDashboardsDistValidation_Jenkinsfile

RpmMetaValidation_Jenkinsfile
RpmMetaValidation_Jenkinsfile

RpmOpenSearchDistValidation_Jenkinsfile
RpmOpenSearchDistValidation_Jenkinsfile

RunBwcTestScript_Jenkinsfile
RunBwcTestScript_Jenkinsfile

RunBwcTestScript_OpenSearch_Dashboards_Jenkinsfile
RunBwcTestScript_OpenSearch_Dashboards_Jenkinsfile

RunGradleCheck_Jenkinsfile
RunGradleCheck_Jenkinsfile

RunIntegTestScript_Jenkinsfile
RunIntegTestScript_Jenkinsfile

RunIntegTestScript_LocalPath_Jenkinsfile
RunIntegTestScript_LocalPath_Jenkinsfile

RunIntegTestScript_OpenSearch_Dashboards_Jenkinsfile
RunIntegTestScript_OpenSearch_Dashboards_Jenkinsfile

ScanDockerImage_Jenkinsfile
ScanDockerImage_Jenkinsfile

SignArtifacts_Jenkinsfile
SignArtifacts_Jenkinsfile

UploadIndexFile_Jenkinsfile
UploadIndexFile_Jenkinsfile

uploadMinSnapshotsToS3_Jenkinsfile
uploadMinSnapshotsToS3_Jenkinsfile

UploadTestResults_Jenkinsfile
UploadTestResults_Jenkinsfile

UploadToS3_Jenkinsfile
UploadToS3_Jenkinsfile

Yes I believe so. The /jobs contained all the jenkinsfile to call the libraries to be tested. Since the build-lib-repo has those I believe we can delete from here. Thanks!

Yes I believe so. The /jobs contained all the jenkinsfile to call the libraries to be tested. Since the build-lib-repo has those I believe we can delete from here. Thanks

Thanks again, @gaiksaya , I will remove /jobs as well..

LGTM, @peterzhuamazon @gaiksaya @zelinh can you please take a look?


[QUESTION] About Microsoft.Maui.Graphics

Microsoft.Maui.Graphics contains some functions similar to SkiaSharp. What is the relationship between the two products and can they replace each other?

Maui.Graphics is an abstraction of graphic APIs that support various backends to run on many platforms. For example CoreGraphics on Apple platforms or SharpDX on Windows. In addition to these native backends there is also a SkiaSharp backend on most platforms. So the idea is to have one API which you use to write your rendering code and run it on a variety of platforms either backed by SkiaSharp or the built-in engine of the platform.
Here you can find an overview of the abstractions
https://github.com/dotnet/Microsoft.Maui.Graphics#supported-platforms


Update index.md

fixed install error.

Had to change the kongmap icon in the hub per kong legal.


Add tests for sl-chart component #207

Hey @notmessenger had to nuke my other PR. I was accidentally pushing my develop branch instead of branching off the develop branch to issue branches. Sorry about this.

Many lines in tests/unit/components/sl-chart-test.js contain trailing whitespace.  Remove per https://github.com/softlayer/ember-style-guide/blob/master/javascript.md#whitespace
There may be a setting in your editor to automatically do this for you on save.  Which editor do you use?

@notmessenger I'm using sublime at the moment. I'll look into the settings change to do that, I inspected the lines but must have missed that.

Sublime Text supports this by adding the following line to your preferences file:
"trim_trailing_white_space_on_save": true
There is also a "trim_automatic_white_space": true property
This is also handy - http://stackoverflow.com/questions/10153998/sublime-text-2-view-whitespace-characters

I was able to comment on the use of const over let on those lines that showed up on the diff but hopefully it goes without saying that this should be applied in all scenarios, not just the ones I commented on.

@notmessenger fixed all let variable assignments to use const, added tests for the title property to be null. also in regards to your comment "Reconsider making this a computed property that observes options, as there is nothing watching the result returned from highchartsOptions() in order to react to any changes in the configuration data. Part of the consideration may be to implement such reactions."  I only created the computed property, "highchartsOptions" in order to test unit test it.

RE: comment https://github.com/softlayer/sl-ember-components/pull/406#issuecomment-121720901
The selection of the structure of data within a component to facilitate testing is not a pattern we want to follow.  The code in the component should be correct and then we figure out how to make it testable.  As such, the options can just be a plain object.  If they need to use this.get() to assign values, such as like https://github.com/softlayer/sl-ember-components/blob/develop/addon/components/sl-date-picker.js#L299, then the use of computed() is allowed, but we do not need to observe a specific property.

https://github.com/erangeles/sl-ember-components/blob/issue207/addon/components/sl-chart.js#L227 and https://github.com/erangeles/sl-ember-components/blob/issue207/addon/components/sl-chart.js#L228 should be const

@notmessenger fixed const assignment.

Please resolve the merge conflicts

@notmessenger merge conflict fixed.


Can't create EKS cluster node pools SignatureDoesNotMatch: Credential should be scoped to correct service: 'iam'.

Setup

Rancher version: v2.7-head (5a8b3bd)
Rancher UI Extensions:
Browser type & version: chrome

Describe the bug

when creating an EKS cluster, user is presented with error SignatureDoesNotMatch: Credential should be scoped to correct service: 'iam'. after selecting their credentials. User is able to select some options after this step, but can't create the cluster as nodepool options aren't available.
To Reproduce

create an EKS cluster through rancher

Result
user can't add node pools / node pool info to the cluster
Expected Result

no error should occur when creating an eks cluster
Screenshots

Additional context

same AWS user on rancher v2.7.3 does not hit this issue
I believe this is a dashboard issue since the error suggests this has to do with headers not matching the credential service
credential scope does not specify the same service as the host header
source: https://docs.aws.amazon.com/IAM/latest/UserGuide/signature-v4-troubleshooting.html#signature-v4-troubleshooting-credential-scope

Myself & @salasberryfin have investigated this and see the issue. I'll create a change today.

As @richardcase mentioned, we identified that the problem is caused by an update to the aws-sdk module.
We tested Rancher downgrading the aws-sdk version to v1.44.253 (current go.mod version is v1.44.266) and it works fine. Some version between 253 and 266 added a change that requires to specify the service name in the call to iam.amazonaws.com. As seen here, since IAM is a global service, this call is sent with an empty service. This used to work but no longer does and it is what causes the error.

There is a PR with a proposed fix ^^^^.  Also its worth calling out this comment in the PR:

If we felt this was too risky, then downgrading the AWS SDK would also fix the problem short term. Long term we don't want to be in a position where we can't upgrade the AWS SDK.

tested on v2.7-head (0bb5e50):

created new EKS cluster -- pass
updated existing EKS cluster -- pass


Integrate new UI, add new debug questionnaire

What
Survey Runner Skinned
New Debug survey created
How to test

run the server
Go to http://localhost:5000/questionnaire/3/ABCDEF/?debug=true
View the survey in all it's splendour

Who can test
Anyone except @weapdiv-david, but probably @LJBabbage

Is this in place of PR #24 ? Should both these PR's be merged?

@dhilton It's just this one. @LJBabbage was reviewing it but I think he had problems installing cassandra. It all looks good to me, I've tested it and it works too.

:+1:


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/PyroniaDE/iobrokerAdapter

[ ] [E002] No "ioBroker." found in the name of repository
[ ] [E004] No adapter name found in URL: https://raw.githubusercontent.com/PyroniaDE/iobrokerAdapter/master
[ ] [E007] Cannot find author repo in the URL
[ ] [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.". Now is "undefined"
[ ] [E021] "licenses" in package.json are depricated. Please use only "license": "NAME" field.
[ ] [E019] Invalid repository URL: https://github.com/ioBroker/ioBroker.cloud. Expected: git+https://github.com/PyroniaDE/iobrokerAdapter.git
[ ] [E103] common.name in io-package.json must be equal to "". Now is cloud
[ ] [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker."
[ ] [E300] Not found on travis. Please setup travis
[ ] [E502] "admin/img/info-big.png" not found, but selectID.js used in index_m.html
[ ] [E801] No repository about text found. Please go to "https://github.com/PyroniaDE/iobrokerAdapter", press the first "Edit" button you will find on the page and add the description.
[ ] [E802] No topics found in the repository. Please go to "https://github.com/PyroniaDE/iobrokerAdapter" and press "Manage topics"
[ ] [E604] No "## License" found in README.md
[ ] [E701] No actual year found in LICENSE. Please add "Copyright (c) 2016-2020 bluefox<EMAIL_ADDRESS>at the start of LICENSE
[ ] [E812] file test/ found in repository, but not found in .npmignore

I have also found warnings that may be fixed if possible.

[ ] [W400] Cannot find "" in latest repository

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Do you need help fixing the bugs?


Pass webhook with env var?

Is it possible to pass in the webhook URL with an env var like you can for the file target?
I tried:
webHookUrl="${environment:SLACK_WEBHOOK}"

but it throws exception for invalid URL.
Any workaround?

+1 Layout support would be very useful


Extends the 'aad approleassignment list' with --objectId option. Closes #1579

Extends the 'aad approleassignment list' with --objectId option. Closes #1579

Coverage remained the same at 100.0% when pulling 961865904b9b108bc47f01d7761cfaef6ce512d8 on VelinGeorgiev:extend-approleassigment-list into 6cab5d1880b21ff016143b5e35d0c1ccd8e92358 on pnp:dev.

Merged manually. Thanks! 👏


Add support for MLC

https://llm.mlc.ai/

MLC looks great! We'll need some kind of installation script tho, to figure out whether to install the CUDA or CPU versions

You can serve it and use the openapi option we have in -m to use it if I'm not wrong. They seem to use a similar endpoint
https://llm.mlc.ai/docs/deploy/rest.html#deploy-rest-api

Maybe we should start by having a working installation https://github.com/radareorg/radare2-pm/commit/b17240cb28f14c088433504195d2ea26b8e0eb9a do you want to give it a try?

simonw's implementation for his llm tool seems nice: https://github.com/simonw/llm-mlc/blob/main/llm_mlc.py


Prevent application submission if profile photos are deleted

An application can be marked as read-to-submit if all information and a profile photo have been provided.
If the profile photo is deleted, update the status of the application to show that a photo is requirement before submission can take place.

Forms cannot be submitted if they require profile photos or information.
Once those requirements are met and the form is submitted, https://github.com/BroadstairsFolkWeek/workforce-api/issues/2 will ensure profile information/photo references are stored with the form. This means the user can alter/remove their profile photos and information without affecting previously submitted forms.


Fix not fade controls in touchable other devices.

Touchable devices which have a mouse are not working fade out the controls

Sorry for the delay on this. I can't quite figure out what you've intended to chance since the change log is mostly showing tab changes.

@muzigee2000 I don't see any changes here that are not part of the package before. Can you verify this? If there are no changes please close this PR

@muzige2000 Thank you so much for work on this PR; however, we are closing this PR since there are still conflicts and no answer has been posted in more than 2 weeks. If it's your desire, fix the conflicts and reopen this PR. Thanks much!


Minor changes

Relatively minor edits:

Part 5 LUX per day segment calculation bug fixes, this is an extentions I have been working on for one specific client.
Part 4 number of awakenings is now also in the output per user request.
Vignette expanded with documentation on non-default variables in part 4 csv report This relates to sleep latency and sleep efficiency which are now only calculated when time in bed is estimated.

I will merge this issue myself, but making a PR to have a clear record of what I am changing.

Checklist before merging:

[x] Existing tests still work (check by running the test suite, e.g. from RStudio).
[x] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[x] Updated or expanded the documentation.
[x] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[x] Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

Codecov Report

Merging #461 (e9bac34) into master (c401b15) will increase coverage by 0.00%.
The diff coverage is 95.00%.

:exclamation: Current head e9bac34 differs from pull request most recent head 0fba552. Consider uploading reports for the commit 0fba552 to get more accurate results

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   74.53%   74.53%
=======================================
  Files          87       87
  Lines       10547    10552    +5
=======================================
+ Hits         7861     7865    +4
- Misses       2686     2687    +1

Impacted Files
Coverage Δ

R/g.part4.R
72.72% <0.00%> (ø)

R/g.part5.lux_persegment.R
93.93% <100.00%> (+0.09%)
:arrow_up:

R/g.report.part4.R
81.81% <100.00%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c401b15...0fba552. Read the comment docs.


[SPARK-30808][SQL] Enable Java 8 time API in Thrift server

What changes were proposed in this pull request?
Set spark.sql.datetime.java8API.enabled to true in hiveResultString(), and restore it back at the end of the call.
This is the cherry-pick of https://github.com/apache/spark/pull/27552 from which I reverted the changes in SparkExecuteStatementOperation.scala because @juliuszsompolski PR https://github.com/apache/spark/pull/28671 solves the issue of converting Java 8 types to strings.
Why are the changes needed?

Date and timestamp string literals are parsed by using Java 8 time API and Spark's session time zone. Before the changes, date/timestamp values were collected as legacy types java.sql.Date/java.sql.Timestamp, and the value of such types didn't respect the config spark.sql.session.timeZone. To have consistent view, users had to keep JVM time zone and Spark's session time zone in sync.
After the changes, formatting of date values doesn't depend on JVM time zone.
While returning dates/timestamps of Java 8 type, we can avoid dates/timestamps rebasing from Proleptic Gregorian calendar to the hybrid calendar (Julian + Gregorian), and the issues related to calendar switching.
Properly handle negative years (BCE).
Consistent conversion of date/timestamp strings to/from internal Catalyst types in both direction to and from Spark.
The changes make possible the optimisation made in https://github.com/apache/spark/pull/28687 because the date formatter becomes independent from JVM time zone settings.

Does this PR introduce any user-facing change?
Yes. Before:
spark-sql> select make_date(-44, 3, 15);
0045-03-15

After:
spark-sql> select make_date(-44, 3, 15);
-0044-03-15

How was this patch tested?
By running hive-thiftserver tests. In particular:
./build/sbt -Phadoop-2.7 -Phive-2.3 -Phive-thriftserver "hive-thriftserver/test:testOnly *SparkThriftServerProtocolVersionsSuite"

Test build #123428 has started for PR 28705 at commit 4ea85ad.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28045/
Test PASSed.

Test build #123428 has finished for PR 28705 at commit 4ea85ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123428/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28062/
Test PASSed.

Test build #123445 has started for PR 28705 at commit ee69a1b.

@cloud-fan @HyukjinKwon @juliuszsompolski Please, review this PR.

Could you make the PR title more precise by changing "in Thrift server" to "in Thriftserver SQL CLI"
This change actually affects only SQL CLI, not Thriftserver used as ODBC/JDBC server.

Test build #123445 has finished for PR 28705 at commit ee69a1b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123445/
Test PASSed.

@cloud-fan

Is it possible to always enable java 8 time API in the thrifter server?

We could, the cleanest way would be to add the set config to the session config in withLocalProperties in https://github.com/apache/spark/pull/28671.
But the session timezone issues there are resolved by that PR already anyway - the Timestamp object collected from the query gets converted to string using HiveResult.toHiveString anyway. No matter if it's a Timestamp, or an Instant, it will result in the same string, working correctly with the session timezone....

Test build #123500 has started for PR 28705 at commit 74dfe4d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28123/
Test PASSed.

Test build #123500 has finished for PR 28705 at commit 74dfe4d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CheckOverflowInSum(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123500/
Test PASSed.

Thanks for the explanations @MaxGekk . I agree it's a good fix to make it use the Java8 APIs all across the Thriftserver.
I would however do it in SparkSQLDriver like you did in https://github.com/apache/spark/commit/916838a3d43aeac59cdc799fed0de8d279b0ad66 instead of changing toHiveResult, and I would also add it to the withLocalProperties wrapper in SparkOperation, that will apply it to the Thriftserver JDBC/ODBC operations.
WDYT @cloud-fan ?

I agree. Both SQL CLI and thriftserver have their own protocols, and Spark won't leak datetime objects to end-users. Turning on java 8 time API is only for internal consistency.

Here is the PR https://github.com/apache/spark/pull/28729 where I enabled Java 8 time API as @juliuszsompolski proposed.

I am closing this PR because https://github.com/apache/spark/pull/28729 has enabled Java 8 time API in Thrift server already

how about the SQL CLI?

@cloud-fan The PR #28729 enabled Java 8 time API in CLI as well, see the test https://github.com/apache/spark/pull/28729/files#diff-f3b00321aca176ae6c1aa38ba034141eR555-R559

FYI, we run ThriftServerQueryTestSuite - SQL tests in sql/core/src/test/resources/sql-tests under Java 8 time API ON but SQLQueryTestSuite with Java 8 time API OFF. So, we run the same tests for both values of spark.sql.datetime.java8API.enabled.

FYI, we run ThriftServerQueryTestSuite - SQL tests in sql/core/src/test/resources/sql-tests under Java 8 time API ON but SQLQueryTestSuite with Java 8 time API OFF. So, we run the same tests for both values of spark.sql.datetime.java8API.enabled.

There is another difference in that SQLQueryTestSuite runs with Spark Dataframe API, so you collect the results directly using the Spark APIs, while ThriftServerQueryTestSuite runs it via JDBC connection and via Hive JDBC driver, so Date/Timestamps are being printed to string, and parsed back from String into java.sql.Date / java.sql.Timestamp by the Hive JDBC driver.
So there is more differences than one running with Java 8 API ON, and the other with OFF.


Added home handlebars and controllers

Added controllers and handlebar helpers and included them in server.js. Created structure of main and home handlebars

good!

good!

good!


Select2 Clear vs. Removing Single Element

I used $('#id_myfiled').val() to get the value of the field.
I'm using the Select2MultipleWidget on a form. If I add and remove items using the x on the single item, the empty field has value null. If I use the field-wide clear button, the resulting value is [""]. This leads to a form validation error.
I'm not sure if I have to file this against select2 or here.

Does it this package break if you use the option-x or the field-x?

I have the same problem but this causes a graphical bug :

@sebastien247 how so?

When handling graphics, this causes me a blank space, and then when I selected a new element empty choice is visible :

@sebastien247 the latter one I've seen too. Is there a good fix for that?

For this graphical bug :

Just remove this :
×
I search for the empty element

(Coming from the Select2 side)

this causes me a blank space, and then when I selected a new element empty choice is visible :

Usually this happens when a blank option is included for the placeholder, even though you are using a multiple select. The blank placeholder option is only needed for a single select.
Here's the part of the code where it is added: https://github.com/applegrew/django-select2/blob/0b3abb8f1f56ff94154ab50de4ea352184b5ef8e/django_select2/forms.py#L95

@kevin-brown does that help you? #275


Make IPLD plugin a package, not a sub-module

Closes: #291

So it seems like both go fmt and golangci-lint run were ignoring that code...

So it seems like both go fmt and golangci-lint run were ignoring that code...

Ouch, ouch. Can you fix those lints here too?

@liamsi, golangcilint opened an issue about not checking errors when we add nodes to Batch here. In my opinion, this could silently produce undefined behaviors, so I would fix this now, rather than debug myself to death when the unobvious bug appears, as an error was silently ignored. However, it is not obvious how to handle errors here. Options:

Extend VisitorFunc and tree.Root to return errors. In general, Visitors can do some funky stuff that can return errors, so adding optional erroring would enhance NMT API IMO.
Introduce another Visitor that would be called on Push, though that does not work for intermediate nodes.
Update NmtNodeAdder struct to have an error, similar to Batch and introduce Commit method that would wrap Batch.Commit, check for errors if any, and be used here.

Update NmtNodeAdder struct to have an error, similar to Batch and introduce Commit method that would wrap Batch.Commit, check for errors if any, and be used here.

I think that is the best approach.
Pros:

least invasive and only adds errors / error-handling where it's necessary; in other words very local change
follows an already well-established pattern of the used underlying data structure (Batch)

Cons:

not generalizable to other cases (no a biggie as I don't see us adding a bunch of erroring)

Codecov Report

Merging #294 (54ddec2) into master (93c88a1) will decrease coverage by 0.63%.
The diff coverage is 59.51%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   62.27%   61.64%   -0.64%
==========================================
  Files         260      270      +10
  Lines       23218    23890     +672
==========================================
+ Hits        14460    14726     +266
- Misses       7265     7621     +356
- Partials     1493     1543      +50

Impacted Files
Coverage Δ

cmd/tendermint/commands/light.go
16.66% <0.00%> (ø)

cmd/tendermint/commands/run_node.go
0.00% <ø> (ø)

config/config.go
77.74% <ø> (-0.15%)
:arrow_down:

config/toml.go
60.86% <ø> (ø)

consensus/replay_file.go
0.00% <0.00%> (ø)

consensus/state.go
67.71% <0.00%> (+0.46%)
:arrow_up:

crypto/merkle/proof_value.go
0.00% <0.00%> (ø)

crypto/random.go
50.00% <ø> (ø)

evidence/pool.go
65.35% <ø> (ø)

libs/db/memdb/batch.go
0.00% <0.00%> (ø)

... and 63 more

The e2e tests fail because of https://github.com/lazyledger/lazyledger-core/blob/874df76f139b4a3effcd2a74d6078c9d08b6d1ba/test/e2e/docker/Dockerfile#L16


mirror site support for PowerShellGallery

This issue is more about the gallery than the module.
Most repos like docker, pip, npm, maven, apt/yum, etc. allow mirror sites else in the world, and contents are sync'ed on regular basis (e.g. daily). This provides great benefits for developers in areas like China, or the speed for installing a module/package/dependency is going to be as slow as a running turtle.
Is there an option to mirror PowerShellGallery?

Thanks @tigerinus we are planning on implementing a local cache for the PowerShell Gallery which will help resolve this issue, we will leave this issue open though to track the request for mirroring the gallery

@SydneyhSmith I would even go further and would like to see a professional offering that has an SLA agreement similar we have to other hosted services, of course the option to mirror the complete Gallery would be a first step.
Linking the current outage thread to this comment
https://github.com/PowerShell/PowerShellGallery/issues/135

Any progress on this one ?
I would like to mirror packages from the gallery and filter by Author (for example only 'Microsoft Corporation' in one repo and others in another).
Currently not all systems are in DMZ and access to internet is restricted, so in corporate environments mirroring would be one of the best options.

It seems that there is a GetPSGalleryItemsForAuthor.ps1 script that can do that logic (to some extent) and supports author filtering:
.\GetPSGalleryItemsForAuthor.ps1 -AuthorName 'Microsoft Corporation' -LocalFolder C:\powershellgallery


Steering Committee Meeting August (Aug 17th) @5pm at the Genome Sciences Centre

@hackseq/steering_committee - do we still have an in person Steering Committee meeting scheduled for this evening (Aug 3rd) @6pm at the Genome Sciences Centre?

I'll be able to make it.

I have a really bad cold and won't be able to make it.
What's on the agenda today? I thought the plan was we would only meet if we need to debate the travel awards? @adrisua

I wont be able to make it today. @santina @sjackman @brunogrande Would you like to meet today and discuss the participant form and/or project-participant pairing? I am waiting to hear from the ASHG about the travel awards and will contact the participants that applied for the award.

Samantha Kohli (ASHG membership: 350078, points = 15)
Ritu Chavi (not a member but registered for the conference, points = 12)
Whitney Whitford (ASHG membership: 349628, points = 11)
or
Fotis Tsetsos (ASHG membership: 322817, points = 7)

I'm able to meet.

As for our next meeting, would August 24th work for everyone? @ttimbers @cloucks Items to discuss then would be the agenda for the event, awards, volunteers, logistics.

Personally I'm gone Aug 19 - 28

I'm available Aug 24.

@GalenWright and I can make the meeting this evening, but have a lab function on the evening of the 24th so won't be able to make that meeting.
From our last meeting items that need to be completed in the near future are:

Get confirmation that all participants are attending
Assign participants to teams
Get approval of teams from team leaders
Tell participants what teams they have been assigned to

Do you think we need to meet to discuss any of these items today? Alternatively @santina could send out emails to participants and get them to fill out the forms by next week and we could schedule another meeting then, if necessary?

Seeing as we don't have a unanimous decision and it looks like not many of us can make it today, maybe we should call it off and send out a doodle to decide on when the best time for our next meeting is. I can do this tomorrow if necessary

I'm available to meet on August 24th. I talked with Shaun and we agree that we don't really need a meeting tonight, as we were able to rank the participants for the travel awards.

OK perfect! @santina will you contact the participants in the meantime and get them to confirm that they are attending so that we can get started on assigning participants to teams? What are we doing about informing travel award applicants of the results of the travel awards? Will this be included in the confirmation of attendance email or will it be a separate email?

@hackseq/steering_committee I have created a doodle poll for the next meeting:
http://doodle.com/poll/eucqzx46ezen7q3k
Seeing as we didn't meet yesterday, I think we should try and meet sooner, rather than later this month. Please complete the poll by Sunday evening so that we can finalize the date/time. Thanks

Hi all, just getting back from vacation. Although I'm still away in Ontario for a wedding this weekend and will be back in Vancouver on Tuesday. Will complete the survey before Sunday and be able to better help with things when I am back in town.

I looked at the meeting poll and the best time/date for everyone is Wed Aug 17th @5pm. See you all then

Will drop in on hackpad for a few.
You guys are awesome!
Ben
On Mon, Aug 8, 2016 at 8:37 PM, Galen Wright<EMAIL_ADDRESS>wrote:

I looked at the meeting poll and the best time/date for everyone is Wed
Aug 17th @5pm https://github.com/5pm. See you all then
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hackseq/October_2016/issues/44#issuecomment-238420015,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFePtYWvVyuUPrfeM47uD2XKMg6yZdOtks5qd8vbgaJpZM4JcIv2
.

--
What have you done today to make the world a better place?

@ttimbers, could you set up the agenda for the meeting on Wednesday? Once you do, could you add the following items to the agenda? Thanks!

Discuss turning down Chipotle as a food sponsor (see discussion in hackseq/October_2016_private#20 for more details).

Brainstorm events that would have had food sponsors.

Will do!

@ttimbers Would you mind also adding the volunteer/mentor form to the agenda? Thank!

Hi, all. I'm back from Michigan. I've accepted a list minute invitation to go camping, so I'll miss the meeting this Wednesday. Sorry for the short notice. Now that we have the confirmed list of participants, I'll figure out the team assignments.

I'll be at the GSC, so we can still hold the meeting there.

@ttimbers Please add to the agenda the possibility of publishing the project reports to the F1000Research Hackathon channel. See https://github.com/hackseq/October_2016_private/issues/27

@hackseq/steering_committee this is a reminder that we have a meeting today at 5pm at the Genome Sciences Centre. I think we need to call Bruno, not Shaun to get in? Bruno, can you please put your contact number on the planning etherpad or send it to us all via email?
Meeting agenda has been drafted, and lives here: http://pad.software-carpentry.org/hackseq. Please feel free to add anything I missed.

I sent an email to everyone with my phone number. Text me when you arrive at the GSC.

Hi everyone, I had planned to make this meeting, but I am feeling overwhelmed with preparation for my thesis defence coming up at the end of the month and won't be able to make it.


user and password

since the last update (3.1.2), every 2-3 days I am asked to enter my tp-link user and password.
is this a problem with the integration?

same deal, with 1 more addition.  I have 2 Tapo devices, it logs both out.  I can log 1 back in, it resyncs for both, but leave the other error up (the one i didnt log into) and will not go away.

I have just updated and when it came back from a reboot it did the same wanted user and password, which I gave and was ok till later then wanted again think after the device was used

I have the same problem, except that even if i don't reconnect, data are still being reported correctly on HA.
Seems like it's just a display bug when the plug lose connection and reconnect/resync with HA.

I have the same issues with TP-Link Smart Home Integration in combination with P115 plugs
see: https://github.com/home-assistant/core/issues/116089
I don't have issues with the TP-Link Tapo (hacs) Integration

Seems like the plug just try to connect to both Tapo (hacs) and TP Link, so i personnally just reconnected to TP Link and disable both plug, since then only the Tapo (hacs) sensors works and everything works fine.


Add Reactive Oracle Client

@cescoffier @jponge please review

Thanks!

It fails because the Oracle client cannot be built with JDK8

MAke sense, I will update the CI

Thank you


[em] configuration abstraction validation

@cos please review

#1945

Since #1883 was fixed, I'll bring back the location information (line and column numbers only) as mentioned in #1984, in a separate PR.

@cos please merge if your questions are answered.


fira-code: don't use variable font

Motivation for this change
fixes https://github.com/NixOS/nixpkgs/issues/118891
Also, Arch Linux's ttf package installs the same files.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123220 at 856969f1 run on aarch64-linux 1

2 packages built successfully:

fira-code
fira-mono

It looks to me the real issue lies in luaotfload. luaotfload isn't properly matching the font family name, so it is falling back to finding the font by filename instead.
❯ luaotfload-tool --find 'Fira Code' --fuzzy
luaotfload | db : Reload initiated (formats: otf,ttf,ttc); reason: Font "Fira Code" not found.
luaotfload | resolve : sequence of 3 lookups yielded nothing appropriate.
luaotfload | resolve : Cannot find "Fira Code" in index.
luaotfload | resolve : Looking for close matches, this may take a while ...
luaotfload | query : Distance from "firacode": 5
    Fira Code Light
    file-icons

luaotfload is mistakenly thinking that "Fira Code Light" is the family name, so the following works:
\usepackage{fontspec}
\setmainfont{Fira Code Light}

I'd prefer keeping the variable font unless it causes more problems because it's more customizable while being smaller in size. The non-variable ttfs are 1.8 MB combined while the variable one is only 260 KB.

The non-variable ttfs are 1.8 MB combined while the variable one is only 260 KB.

That's a stark difference indeed.

It looks to me the real issue lies in luaotfload. luaotfload isn't properly matching the font family name, so it is falling back to finding the font by filename instead.

Do you have an idea how to fix that? As a workaround, can we maybe change the filename from FiraCode-VF.ttf to FiraCode.ttf?

For a complete fix, I believe this would have to be reported upstream at latex3/luaotfload. We could rename the file for Fira Code, but fixing it upstream would solve the problem for other fonts that may suffer from the same issue.
I'm not familiar with Lua but from a cursory look, it seems that luaotfload rolls its own parser for fonts files1 so any fixes would probably have to be made there.

I think installing FiraCode-VF.ttf as FiraCode.ttf sounds like a good idea.

What about the solution proposed by #196087, keeping them both? The fira-code variable font also makes xdvipdfmx fail when I use xelatex

Dear @dotlambda,
The original issue this PR has been created for is fixed. Is this PR still relevant?
If not, can you please close it?
Thanks!

I can confirm that the issue that I had is fixed on nixpkgs master.

Could you please fix the merge conflict ?

Note: I'm confirming that for my usecase, this PR was not needed.

Sorry for necrobumping the pull request, but I can reproduce the issue on master again.
\documentclass{article}
\usepackage{fontspec}\setmonofont{Fira Code}
\begin{document}
Let's test the “programming ligatres” \verb|hello <> === ok nein|.
\end{document}

nix shell 'nixpkgs/master#texlive.combined.scheme-full'
latexmk -pdf -xelatex test.tex

Fails with:
------------
Running 'xdvipdfmx -E -o "test.pdf"  "test.xdv"'
------------
test.xdv -> test.pdf
[1
xdvipdfmx:warning: Invalid TTC index (not TTC font): /nix/store/3nvjhw65a3vqf411g0w3nyyjmmwlxc75-fira-code-6.2/share/fonts/truetype/FiraCode-VF.ttf
xdvipdfmx:fatal: Invalid font: -1 (1)

No output PDF file written.
Latexmk: Errors, so I did not complete making targets
Collected error summary (may duplicate other messages):
  xdvipdfmx: Command for 'xdvipdfmx' gave return code 256


Use lofty-rs for metadata instead of audiotags

Replaces #17. Fixes #15

For now this uses my own lofty-rs fork, which is a bit more relaxed when parsing tags. Upstream lofty will just error if the tag is invalid. My patch allows it to return the valid tags.
A feature for lofty is planned to implement a Relaxed ReadingMode which would do the same thing. Then upstream lofty can be used. https://github.com/Serial-ATA/lofty-rs/issues/204#issuecomment-1573942708

LGTM and works fine too

metadata_god v0.5.0 is published to pub.dev
@FriederHannenheim Thanks a lot for this amazing contribution. You basically re-wrote entire lib :smile: :rocket:

@FriederHannenheim are bits missing to make metadata god read out ogg files?


Tests: Revise the unittests package

This patch revised the meson build script and Tizen's rpm spec file to include files which are required by the test daemon, machine-learning-agent-test.
Signed-off-by: Wook Song<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #329. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @wooksong, tests/daemon/unittest_gdbus_util.cc does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @wooksong, tests/daemon/unittest_gdbus_util.cc does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md


Add option to exclude methods for Style/DocumentationMethod cop

Is your feature request related to a problem? Please describe.
The Style/DocumentationMethod checks for all the public methods including initialize.
The constructor doesn't have to have a documentation comment.
Describe the solution you'd like
Add an option for the cop to exclude method names.  E.g.
Style/DocumentationMethod:
  Enabled: true
  Include:
    - 'app/policies/**/*.rb'
  ExcludedMethods:
  - 'initialize'
  - 'foo'
  - 'bar'

Describe alternatives you've considered
An alternative is to disable the cop by the rubocop:disable comment around wanted methods.

Looks reasonable to me. I've opened #11506.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_85pc6dn1bo/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_85pc6dn1bo/clone/recipe/meta.yaml:26: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_85pc6dn1bo/clone/recipe/meta.yaml:29: invalid_url: https://bitbucket.org/bayazee/pycalverter/overview : Not reachable: 404
ERROR: /tmp/abs_85pc6dn1bo/clone/recipe/meta.yaml:30: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: MPL-2.0
WARNING: /tmp/abs_85pc6dn1bo/clone/recipe/meta.yaml:33: missing_description: The recipe is missing a description
ERROR: /tmp/abs_85pc6dn1bo/clone/recipe/meta.yaml:33: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_85pc6dn1bo/clone/recipe/meta.yaml:33: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found


Added routing number validation

Details
Implemented the routing number validation algorithm that was confirmed here & used it to validate.
Fixed Issues

$ https://github.com/Expensify/App/issues/5762
Tests & QA Steps

Go to Workspace
Click Connect Bank Account
Choose Connect Manually
Enter Invalid routing numbers, eg (123456789)
On click on Save & continue
Will show invalid routing number on the same page itself.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots
Web

Mobile Web

Desktop

iOS

Android

Thanks @Santhosh-Sellavel . I went ahead and removed the label on the issue.

Code looking good, but I'll re-review once iOS tests pass (probably failing due to this)


partial results [android], firing ready to speech event [android]

@sepehrr I like it but it doesn't follow the spec. Check out:
https://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#speechreco-result
Basically we'd want to fire the partial results but set the final value to false. Once we get the final result then set final to true. That way we stay in line with the spec and only call the result event.
Would you be able to change the PR to match the spec?


Specify Maven artifact group in project.clj

I picked the same group Riak Java client uses.

I was actually thinking it might make sense to hold off on this since this is not (yet) an official Basho driver. I'm afraid it might confuse people.

@reiddraper feel free to revert it. Until first artifacts are released to Maven repos, I think nobody will really notice this change. It is possible to change the group at any time but my experience suggests that going from [project] to [group]/[project] results in some confusion, too. Some people do not notice that artifact name is now different and stick to older versions forever.
I understand what you are saying, though, and that this project is not under github.com/basho.

Reverted in 049c7f6132ddaf050e43514db721ea8b248078bf.


Merge BooleanLiteral and NullLiteral into Keyword

We can expect a performance enhancement due to simplification on the logic of scanIdentifier, which is the biggest bottleneck for lexer.

This would be a breaking change for downstream projects. Is it necessary?

@ikarienator Remember that the tokeniser is part of esprima's public interface.

Yeah, I don't think we can do this change.

Oh, I meant the Token.NullLiteral and Token.BooleanLiteral. They are used internally and not exposed. When we expose the types, we always use strings.

OHHHH, right, the props dangling off the token internally. :+1:

no, this is still breaking, because that type gets converted to a string at the end.

Well, I think I convert them in an BC way. :)

I don't think we're pursuing this. Let's bring it back whenever the opportunity present itself.


Independently set preferred sync engine depending on reference type

Hello! I've replaced the subsync-tool setting with individual settings for audio and subtitle tracks, making it possible to independently set the preferred sync engine for each reference type. This is useful if you for example know that you always want to use alass when syncing to subtitles, but would like to manually select an engine when syncing to audio (see #9).
If the user hasn't set the new configuration options in their config file, it will default to ask for both. Current behavior can be preserved by duplicating the old setting and renaming both as seen in the updated example. Feel free to rename the new config options if you can think of something more appropriate.

Thank you!


chore: test cases for MakeBytes and NewQrSegment

Codecov Report
Patch coverage has no change and project coverage change: +1.93 :tada:

Comparison is base (c5c92d5) 15.03% compared to head (5cd4c20) 16.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   15.03%   16.97%   +1.93%
==========================================
  Files           5        5
  Lines         878      878
==========================================
+ Hits          132      149      +17
+ Misses        744      726      -18
- Partials        2        3       +1

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Verify what's wrong with the blog feed in Django 1.8

Applied a quick workaround in a5cf64f3201fbfb8fa9285e61e1f32f5b06aed31

Unable to reproduce an error with Django 1.8. Perhaps FEED_SETTINGS were missing.


drop python 3 7

Chore(deps): bump pydantic from 1.10.9 to 2.6.2
Updated gitignore
Upgraded to Pydantic 2.x
Ensure Python 3.9 style

@coderavvitai review

@coderabbitai review


[Tiered caching] Integrating ehcache disk cache

Description
Integrating ehcache as a disk cache option which is needed as part of tiered caching.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sohami @Bukhtawar

@sgup432 Thanks for the contribution, please link related issues / designs to provide context for this pull request.

@peternied

@sgup432 Thanks for the contribution, please link related issues / designs to provide context for this pull request.

Yeah sure. Will do that.

Build still broken and please add changelog. Thanks!


Saturn template build fails "Cycle Detected"

C:\Users\Alan\projects\Saturn\src\Saturn\Saturn.fsproj : error NU1108: Cycle detected.
C:\Users\Alan\projects\Saturn\src\Saturn\Saturn.fsproj : error NU1108:   Saturn -> Saturn (>= 0.2.0).

Ah I had an older version of the .netcore sdk, I had gotten and used the template with the old version, got an update restarted tried to build and failed.
When I deleted the whole thing, got the template again with the new version, and was forced to specify the language. After this when I went to build it built correctly.


add basic install requirements

we should add further requiremts files e.g.

webserver (e.g. includes mod_wsgi)
linuxtesting (pyvirtualdisplay)
basics (all what we need in the meta.yaml)

We solved this differently for the docker setup

We solved this differently for the docker setup


How to enable Speech in BotFramework inside Android WebView

Hi,
I am loading a bot URL inside an android application WebView. I have recently added speak feature in my bot, I have tried and tested in Native Browser - it works perfectly.
But when I am trying to use the same feature in a WebView, the Microphone icon itself is not coming and nothing is spoken by the bot.
P.S., I am using .BrowserSpeechRecognizer() and .BrowserSpeechSynthesizer()

WebView may have limited supported on speech because they are not a full browser. Unfortunately, CanIUse.com don't list WebView, so it's difficult to tell which OS version support what APIs.
For WebRTC support, can you try if WebRTC is working properly in WebView? If yes, Cognitive Services will probably work in WebView.
For Web Speech API support, can you visit https://compulim.github.io/react-dictate-button/ and see if it works in WebView?

Hi @compulim , I was tracking this chromium bug thread which says that Support for Web Speech API in Android WebView is not present till date.
I will try some alternatives and update the thread if I get it working!
Thanks!!

@debnathSD  do you have any update to enable speech-text in an android web view through botframework V4 webchat?

Any updates on text to speech in web view


add docs to api

Detailed Description
It would be great to have docs for the fast api that has been made

hey @peterdudfield , i had added the docs in my prev merge, can we close this?

Added in #170 and #181


chore: bump Windows base images to 2024.9B

What type of PR is this?
/kind feature

What this PR does / why we need it:
bump Windows base images to 2024.9B
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.263%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
2589

Relevant Lines:
3633

💛  - Coveralls


initalize gnn network for CIM problem

Add a simple solution for the ECR problem:

We use GAT layers to learn the interactions between multi-agents.
We implement the synchronized A2C for multi-processing rollout.

Codecov Report

:exclamation: No coverage uploaded for pull request base (v0.1@fdaa133). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v0.1      #60   +/-   ##
=======================================
  Coverage        ?   72.36%
=======================================
  Files           ?       87
  Lines           ?     4089
  Branches        ?        0
=======================================
  Hits            ?     2959
  Misses          ?     1130
  Partials        ?        0

Flag
Coverage Δ

#unittests
72.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdaa133...686cd33. Read the comment docs.


[Event Request] table 36 "Sales Header" - procedure "SetTrackInfoForCancellation"

🕮 Describe the request
internal procedure SetTrackInfoForCancellation()
var
    CancelledDocument: Record "Cancelled Document";
    SalesInvoiceHeader: Record "Sales Invoice Header";
    SalesCreditMemoHeader: Record "Sales Cr.Memo Header";
begin
    if Rec."Applies-to Doc. Type" <> Rec."Applies-to Doc. Type"::Invoice then
        exit;
    SalesInvoiceHeader.SetLoadFields("No.");
    if not SalesInvoiceHeader.Get(Rec."Applies-to Doc. No.") then
        exit;
    SalesCreditMemoHeader.SetLoadFields("Pre-Assigned No.");
    SalesCreditMemoHeader.SetRange("Pre-Assigned No.", Rec."No.");
    if not SalesCreditMemoHeader.FindFirst() then
        exit;
    **//--> event request
    IsHandled := false;
    OnBeforeSetTrackInfoForCancellation(SalesCreditMemoHeader, IsHandled);
    if not IsHandled then
    **//<-- event request
      CancelledDocument.InsertSalesInvToCrMemoCancelledDocument(SalesInvoiceHeader."No.", SalesCreditMemoHeader."No.");
end;

**//--> event request
[IntegrationEvent(false, false)]
local procedure OnBeforeSetTrackInfoForCancellation(SalesCrMemoHeader: Record "Sales Cr.Memo Header"; var IsHandled: boolean)
begin
end;
**//<-- event request

Additional context
In Turkish localization, all Sales Cr. Memo documents are not accepted as cancellation documents.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11415.


add refresh token expires in login response

Signed-off-by: x893675<EMAIL_ADDRESS>
What type of PR is this?

/kind optimize
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #123
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

/cc @lixd

Codecov Report

Merging #128 (1fe6202) into master (6e3615b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   11.78%   11.79%
=======================================
  Files          98       98
  Lines       15108    15107    -1
=======================================
+ Hits         1781     1782    +1
+ Misses      13092    13090    -2
  Partials      235      235

Impacted Files
Coverage Δ

pkg/authentication/auth/token.go
61.60% <100.00%> (+0.30%)
:arrow_up:

pkg/apis/core/v1/utils.go
55.05% <0.00%> (+0.38%)
:arrow_up:

/cherrypick release-1.1


Added stopwatch app

Added a basic stopwatch app.

Nice, the only thing is that I think this would be much better suited in the new "clocks" category instead of "tools". Do you agree?

Yeah I agree. Moved it now.

Thank you!


parser: use built-in whitespace trimming

Our is_ws() implementation was the same since the earliest days of askama: https://github.com/djc/askama/commit/4805acc8eb03541cb00ec39b4f20da49c51c9317#diff-a9b78e3979c46af7f12ceef379a5a7a657fbe8d77900aa6b4e88b7519b415ca3R31-R34. It considers spaces  , horizontal tabs \t, carriage return \r, and end of line \n characters as white spaces characters. Rust's u8::is_ascii_whitespace() adds formfeed \f to the list.
This PR replaces is_ws() with the built-in char::is_ascii_whitespace().

I doubt that anyone is relying on the fact that the invisible character \f won't be stripped by whitespace control. If you absolutely need this character to be preserved, then you can always use {{ '\u{b}' }}.
Right now, trim_ascii_start() is manually implemented, because it is only stable since rust 1.80.

Thanks!


fix blend functions and add _label

Codecov Report

Merging #31 (dc442e4) into main (b562d74) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #31   +/-   ##
=====================================
  Coverage   8.33%   8.33%
=====================================
  Files         12      12
  Lines        240     240
=====================================
  Hits          20      20
  Misses       220     220

Flag
Coverage Δ

unittests
8.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/classify.jl
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b562d74...821602f. Read the comment docs.

This should be good to be reviewed. Try and check some of the choices I made e.g. in terms of giving the labels random numbers.
Here's how blend now works with a cluster
wave = rand(WaveSurface(0, 2), 200, 200)
sources = unique(rand(1:40000, 10))
clust = NeutralLandscapes.classify!(rand(DistanceGradient(sources), (200, 200)), [0.5, 1, 1, 0.5])
res = blend(clust, wave
plot(
       heatmap(wave),
       heatmap(clust),
       heatmap(res),
       size = (1400, 350), layout = (1,3)
)

And this is the label function in action itself
heatmap(label(clust)[1], fillcolor = :picasso)

I really struggled with debugging this one - fun challenge but pretty happy to have the PR made.  label(clust) in the example runs in 51 ms on my laptop.


Fragment

Honestly, where may I change the fragments' name? the tabs

Hello,
Within (resources/string/strings_fragments) three strings that specify the name:
<! - Sectios Tabs ->
      Fragment 1 </ string>
      Fragment 2 </ string>
      Fragment 3 </ string>
To change the name of the tabs, simply replace the value you want those strings!


activegraph and MacOS < 10.15 compatibility

I was trying to upgrade to Neo4j 4.0 and first tried to upgrade to activegraph. When starting the rails server I got an error saying that libseabolt is required.
I attempted to follow the instructions for installing the latest libseabolt release, but libseabolt requires openssl 1.0, which has been EOL'd in Homebrew and deleted.
So I tried to compile libseabolt from source using openssl 1.1.1, but libseabolt uses a function that's not available until MacOS 10.15.
As far as I can tell, the simplest solution is to build OpenSSL 1.0 from source. This seems like a lot of work to get a ruby gem to work, however.
Is there some other option I am missing?

@mstrofbass have you tried using the prebuilt package https://github.com/neo4j-drivers/seabolt/releases ?

@klobuczek yes, the pre-built packages are what require OpenSSL 1.0.

and this fails as well?
brew install michael-simons/homebrew-seabolt/seabolt

No, that works fine and appears to fix the issue. Thanks

I admit the documentation is far from perfect but it is there https://github.com/neo4jrb/neo4j-ruby-driver/blob/master/README.md

I think adding this to the upgrade guide on the read the docs site would be beneficial.


If a user is in posses of a gadget, he gets the chose before the next quiz whether he wants to use it or not

optional, won't do


pip-compile gives misleading error message if no internet

If there is no internet access, pip-compile will fail with a misleading message. This is with pip-compile 1.6.1, pip 8.1.1, and Python 3.5.1.
Steps to replicate

Create a requirements.in file with a single project name.
Disable internet access (e.g. by disabling wi-fi).
Run pip-compile --verbose requirements.in.

Expected result
The command should fail with an error message relating to the fact that there is no internet connection.
Actual result
Instead, the output looks something like this:
Using indexes:
  https://pypi.python.org/simple

                          ROUND 1
Current constraints:
  MyPackage

Finding the best candidates:
Could not find a version that matches MyPackage
Tried: (no version found at all)

Wow, that's pretty bad. Thanks for reporting, this obviously needs to be fixed.

Note that it's possible this is due in part to a similar bug / behavior in pip itself. If I run the following with no internet:
$ pip install --retries 0 MyPackage > temp.txt

then pip's stderr output looks like this--
  Could not find a version that satisfies the requirement MyPackage (from versions: )
No matching distribution found for MyPackage

Without the retries argument, you will at least see connection errors prior to this. As with this report, it would be better if pip's final error message says something about the inability to connect.

FYI, I filed the analogous issue for pip here: https://github.com/pypa/pip/issues/3642
It's possible that if pip fixes that issue the right way, then this bug will also go away (at least for the versions of pip where that issue is fixed).


Service has been removed. But the program is still running

hello:
I'm running into a problem. when I using winService to register the program as a service. it works !
after running .\winService -service uninstall  to remove service. the service has been removed. but the program combined with service has not stopped. it's still working.
What can I do to stop the program while uninstalling the service?


Price field is activated along side with 'is free' -field.

PT-734 The price field will be active when the free event checkbox is not marked. All the hard coded isFree -values are now fetched from actual data from database.

The API changes should be published before this PR can be used. The paymentInstruction field needs to be removed from API first. Since event.offers.description and event.offers.infoUrl can be used for same purpose, there is no need for paymentInstruction field and it will be removed as soon as possible.

Hinta and lisätiedot could use some more spacing between them :)

Hinta and lisätiedot could use some more spacing between them :)

On other fields the bottom space seems to come from a FormGroup -component. In my opinion, all those are the same group - they even depend on each other - so, I don't want to use that component. I need to add something special for it. :)

On other fields the bottom space seems to come from a FormGroup -component. In my opinion, all those are the same group - they even depend on each other - so, I don't want to use that component. I need to add something special for it. :)

Hinta and lisätiedot could use some more spacing between them :)

On other fields the bottom space seems to come from a FormGroup -component. In my opinion, all those are the same group - they even depend on each other - so, I don't want to use that component. I need to add something special for it. :)

Yeah FormGroup seems to not ake sense in many places, it could be renamed at some point or we could change the way we add spacing to inputs

API changes are already delivered City-of-Helsinki/palvelutarjotin#122

Codecov Report

Merging #144 (61337ff) into master (15831e3) will increase coverage by 0.21%.
The diff coverage is 91.80%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   80.99%   81.21%   +0.21%
==========================================
  Files         175      176       +1
  Lines        3083     3156      +73
  Branches      985     1020      +35
==========================================
+ Hits         2497     2563      +66
- Misses        564      570       +6
- Partials       22       23       +1

Impacted Files
Coverage Δ

src/domain/event/utils.ts
58.40% <ø> (ø)

src/domain/occurrence/CreateOccurrencePage.tsx
78.16% <ø> (ø)

...occurrence/eventOccurrenceForm/ValidationSchema.ts
91.30% <ø> (-0.70%)
:arrow_down:

src/domain/event/EditEventPage.tsx
83.15% <66.66%> (+0.36%)
:arrow_up:

.../event/eventCategorisation/EventCategorisation.tsx
84.61% <66.66%> (-15.39%)
:arrow_down:

src/domain/event/eventForm/EventForm.tsx
94.87% <100.00%> (ø)

src/domain/event/eventForm/ValidationSchema.ts
83.33% <100.00%> (+8.33%)
:arrow_up:

src/utils/CommonEventFormTests.ts
100.00% <100.00%> (ø)

src/utils/dateUtils.ts
100.00% <100.00%> (ø)

...rrence/occurrenceGroupInfo/OccurrenceGroupInfo.tsx
84.61% <0.00%> (-15.39%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a2aa2a...61337ff. Read the comment docs.


WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1007)".

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce

I created a MINIO docker instance (same server as CVAT is running)
docker run -p 9000:9000 -p 9090:9090 --name minio1 -v D:\minio\data:/data -e "MINIO_ROOT_USER=ROOTUSER" -e "MINIO_ROOT_PASSWORD=CHANGEME123" quay.io/minio/minio server /data --console-address ":9090"
I created a testbucket
I created an AWS S3 Cloud Storage Entry in CVAT and clicked submit

I get the following error:
Error: Request failed with status code 400. "SSL validation failed for https://<IP_ADDRESS>:9090/testbucket [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1007)".
Expected Behavior
New connected S3 compatible cloud storage
Environment
CVAT Version 2.7.2

I don't think that this is a question, @bsekachev . I clearly throws an error. I guess that is not the intended behaviour? ;)

@bsekachev, I understand that but it's about connecting to minIO. minIO is a self-hosted S3 bucket and is fully compatible with Amazon S3. But it's not working with CVAT because of the error above.
I guess connecting to a S3 bucket needs SSL too and doesn't work over an unencrypted HTTP connection.

please provide a full stack trace of the error from cvat_server container


On number parsing

This touches a bit on the discussion in #83, but covers more broadly the current options for parsing numbers in JavaScript, to try to inform which semantics we should expose, more so than just how we should type and organize the JS API.
Currently, I believe the only option for parsing numbers are parseInt/parseFloat. Either directly through Float.parseFloat and Float.parseInt, but also as the underlying API used in Float.fromString andInt.fromString. While there unfortunately aren't any good options, in my opinion parseInt and parseFloat is the worst of all the bad options. For the sake of easy comparison and to facilitate efficient discussion, I've outlined the pros and cons of the options i know of below.
Note that I've only covered the differences between the options.
They don't distinguish parse failure from the actual valid value of NaN.
They don't support group separators.
They don't provide locale-aware parsing.

parseInt/parseFloat
The core of the prom with these functions is described by the following quote from MDN:

parseFloat() picks the longest substring starting from the beginning that generates a valid number literal. If it encounters an invalid character, it returns the number represented up to that point, ignoring the invalid character and all characters following it.

While this may not seems like such a big issue, since it just ignores certain kinds of "mistakes", keep in mind that there isn't just one number format used across the world. These functions will only parse a very simple number format, close to but not entirely the same as JavaScript number literals. And iif it ecnounters anything that doesn't fit that, it will just ignore the rest. For example, if any kind of group separator is used, that and everything that follows will be silently ignored. The same goes for using a decimal separator other than ..
In short, these invocations will all return 15:
parseInt("15,123");
parseInt("15 123");
parseInt("15 * 3");
parseInt("15px");

Pros

Simple functions that are easy to bind to.
Zero-cost.
Accepts optional radix argument.

Cons

Will accept any string that starts with something that can be parsed as a number.

Number coercion
There are a number of ways to trigger number coercion, such as using any numeric operator on them. E.g. if value is a string, +value will return a number.
This improves on parseInt and parseFloat most notably by rejecting input that isn't wholly parsable, such as all the examples in the section above. It does come with a few extra cons though, but they are for the most part possible to work around.
Pros

Only accepts wholly parsable strings.

Cons

No explicit radix option, but does parse numbers correctly when prefixed with 0x etc.
No int-specific variant. And while it's easy to create a wrapper function to reject floats that are not whole numbers, it's not possible to reject string such as "123.0" without a pre-processing step.
Empty or whitespace-only strings are converted to 0. (can easily  be worked around with a wrapper function though).

Number constructor
This works very similar to number coercion, because that is the conversion mechanism actually used. But it's slightly slower. And when used as a constructor (with new) it will create a Number object rather than a primitive.
Pros

Same as number coercion
Easy to bind to, though doesn't transfer as naturally to ReScript

Cons

Same as number coercion
Slightly slower

The problem with coercion is that it doesn't give the same results as parseInt. And if the function is named parseInt users think it works like parseInt from JS.
I believe we should just return an option.

I'm not proposing that parseInt sand parseFloat hould be replaced with a similarly named function that does number coercion. I'm proposing that they're left as-is, precisely because users will expect it to work like in JS, but to actively discourage their use.
Then I'm also proposing that number coercion is used instead of parseInt and parseFloat in Int.fromString and Float.fromString specifically, since they don't have a JS equivalent and van therefore have better semantics.

Related bug report in rescript-compiler about this, that was just closed as stale: https://github.com/rescript-lang/rescript-compiler/issues/3732


[UIA] Dispatch a TextChanged event on new output

For some reason, Windows Terminal stops dispatching UIA TextChanged events sometimes. There isn't a reliable repro for this bug.
However, under NVDA's logger, it appears that when the bug does occur, we still dispatch UIA notifications (which may be ignored by NVDA in some configurations). A "quick fix" here is to dispatch a TextChanged event if we're going to dispatch a notification. Since we're just enabling a flag, we won't send two events at once.
Closes #10911

@msftbot merge this in 4 minutes


Error on docker build :  No such file or directory: '/src/doorman/static/libs/interact/dist/interact.js'

Hello,
I have the following error while trying to do a docker build, on latest CoreOS :
Linux hati 4.19.34-coreos #1 SMP Mon Apr 22 20:32:34 -00 2019 x86_64 Intel(R) Xeon(R) CPU E7- 2830 @ 2.13GHz GenuineIntel GNU/Linux
moment#2.24.0 doorman/static/libs/moment
Building bundle: public/css/common.css
Building bundle: public/js/common.js
Failed, error was: [Errno 2] No such file or directory: '/src/doorman/static/libs/interact/dist/interact.js'
The command '/bin/sh -c cd /src/   && bower install --allow-root   && python manage.py assets build   && mkdir /var/log/doorman/   && chown doorman:doorman -R .   && chown doorman:doorman /var/log/doorman/' returned a non-zero code: 2

Hello,
I have exactly the same issue
Any idea ?
Regards

in the bower.json file change the following line
    "interact": "^1.2.6"
to
    "interact": "1.2.6"

thanks !

I had the same issue and attempted to fix it in #150


Create node.js.yml

Multiple issues to address here:

The PR title is not descriptive nor useful, and the PR description is empty.
The workflows in node.js.yml are broken, as per the PR job statuses.
There are misleading copy-paste artifacts in publish.yml.
The mechanism of operation of publish.yml, vis-a-vis NPM_TOKEN, is unclear and undocumented. Is this intended to publish NPM releases on every merge to master? How will they be versioned?

Thanks @artob  .... I'll follow up on these comments. it is still WIP.

it is still WIP.

Please make sure to mark it as a Draft PR until it is ready for review


docs: add delete delay & clean cache example config

I will take over this pr, this section needs further improvement: https://juicefs.com/docs/csi/guide/resource-optimization/#delayed-mount-pod-deletion


Install resourcemgr header

This is needed by the tpm2_rc_decode utility for decoding errors from the resourcemgr: https://github.com/01org/tpm2.0-tools/issues/83

I'm killing this issue off. The resourcemgr will be removed as soon as I get the replacement through the Intel review process.

Do we ever plan on being able to decode RM error codes?
Referencing: 01org/tpm2.0-tools#83

Yeah but the more I think about it the more I think the RC decoder ring should be a library, not a tool. The tool should just call a library to do the decoding. Probably worth creating a milestone for the work. This is the right repo for that library.


Sculpt Comfort Mission Control doesn't start

I've followed the instructions on adding the SCMC Loader into /System/Library/ScriptingAdditions/,
as well as adding a plist into ~/Library/Preferences/ followed by killing the Dock, but opening Sculpt Comfort Mission Control does nothing. I've allowed it through the unidentified app prompt.

The app does not have a user interface. Try to use your mouse to see if the app works.

I'm not sure why but re-plugging the usb receiver helped. No se. I'll close the issue!


Fix formatting on single recipe page

The sidebar isn't all the way to the left, and there's the same kind of scaling issues with the sidebar as there is on the home page (#22)

Is this better?

Issue fixed by #29


chore: create github action to publish package

copied from https://github.com/paypal/paypal-js/blob/main/.github/workflows/publish.yml
once this merges I'll get the secrets added to this repo and I guess try to run a release?

There's one more thing we need to do with this change. Please change up the release script in the package.json. Let's use what paypal-js does for it: https://github.com/paypal/paypal-js/blob/main/package.json#L15-L17. That way we can delete some of the files in the scripts folder.


Fix code example in Controller docs

Fixes a typo on the code example. props isn't available as everything is destructured.

Thank you @msutkowski !


fix: update magic number lint issue

By creating some constants related to number parsing and formatting, I was able to knock out all of the linting errors caught by Review Dog. Totally open to other suggestions on fixing the issues - just figured it would be nice to start somewhere.

Overall, the feedback from me would be, I'm not a big fan of super generic constants. It tends to go against domain-driven design where you try and keep relative bits of information grouped together. That type of design philosophy rarely works out perfectly so you always have to make compromises but overall I think it's a very good rule of them when working on Go packages.
Creating super generic constants that can be imported anywhere literally introduces them imported anywhere which means now you're supporting compatibility requirements anywhere those constants are imported. Again, sometimes this isn't a big deal but creating more touchpoints in my view isn't always the most ideal solution for solving this particular linting issue.
My vote would be if we want to get rid of the linter errors we create local constants to each package or event think about just removing that linter type altogether. I'm personally not aware of how much value it's actually providing us at this point.

Overall, the feedback from me would be, I'm not a big fan of super generic constants. It tends to go against domain-driven design where you try and keep relative bits of information grouped together. That type of design philosophy rarely works out perfectly so you always have to make compromises but overall I think it's a very good rule of them when working on Go packages.
Creating super generic constants that can be imported anywhere literally introduces them imported anywhere which means now you're supporting compatibility requirements anywhere those constants are imported. Again, sometimes this isn't a big deal but creating more touchpoints in my view isn't always the most ideal solution for solving this particular linting issue.
My vote would be if we want to get rid of the linter errors we create local constants to each package or event think about just removing that linter type altogether. I'm personally not aware of how much value it's actually providing us at this point.

Thanks for the input! I will work on decentralizing the constants. Since the linter is only tripping on these couple functions, I think addressing them won't be too much of a headache.

Closing this PR to work on alternate solutions for linting errors


Roll Engine from f3847febb247 to 5d67ad105867 (2 revisions)

https://github.com/flutter/engine/compare/f3847febb247...5d67ad105867
2021-05-12<EMAIL_ADDRESS>Get licenses check deps from gclient rather than pub (flutter/engine#26077)
2021-05-12<EMAIL_ADDRESS>Roll Skia from c1b6b6c615a7 to d9a7c5953df3 (2 revisions) (flutter/engine#26089)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.