There should be a space between the letter and the number on Dutch highway shields

See also e.g. Wikipedia https://en.wikipedia.org/wiki/A10_motorway_(Netherlands)
In France they also put a space and it is showing up correctly.

The Americana renderer takes no stance on matters of local formatting and punctuation—the ref=* value is displayed verbatim, as it is tagged in the OSM database. So the Dutch OSM community would need to agree to retagging all the relations.
cc @Blijbol

@claysmalley Well, the official names are without a space, and when referring to highways in text we also don't use a space. So there is no chance this would garner any support from the Dutch OSM community.
However if your cartographic goal is to have accurate representations of highway shields (which I think is the case), you should use a space.

However if your cartographic goal is to have accurate representations of highway shields (which I think is the case), you should use a space.

Our goal with shields is not necessarily to have a perfect copy of what's on the ground, but to  stylize and simplify a little so that they look good on a digital map, and provide a data-driven renderer that displays shields for route=road relations, however the local community has tagged them. It's up to the local community to adopt a tagging scheme that matches shields, or not.
Near where I live, there is a highway called Interstate 540, or I-540 for short. The relation for I-540 is tagged ref=540, because that is the text present on signage, and we've chosen as a community to match ref=* to the text on signs. The "official name" isn't in the relation at all.

Based on the initial photograph of the overhead signage (not the vector graphic below it), I am not seeing a space between the letter and number, or if there is a space, it is very very tiny. If you compare the A50 in the photograph to the A59 in the vector graphic, the space between "A" and "59" is much larger than the space between the "A" and the "50". Just eyeballing things, I think the vector graphic is putting a bigger space in than the signs say in reality.
All this to say -- I am not convinced there should even be a space between the letter and number based on what I'm seeing here.

@ZeLonewolf Right. I don't think it is a space. I sent an inquiry to Rijkswaterstaat and asked for clarification.

I would also point out our style contributor's guide, which has this to say about shield design:

In general, this style is not trying to exactly replicate highway shields as seen on signage. Instead, we are trying to extract the key stylistic elements so that the graphics are recognizable as simplifications of their real-world counterparts.

Some number of years ago, @ke9tv developed a map with photo-realistic highway shields with extraordinary attention to detail. Unfortunately, images of this map seem to be lost to time.
His map even went to the level of detail of rendering shields where suffix letters were drawn in a smaller font than the main route number, as shown in the "5A" and "5B" examples here:

We have not, so far in this project, attempted to micro-style these differences, as shown in our on-map rendering of New York state route 5A:

The only exception I can think of where we have consensus for micro-styling of text in this project is #366, which proposes to handle cases where shields have two rows of text by rendering the / character which appears in the ref tag as a line break. However, in those cases, the contents of the ref tag alone provide the information needed for the renderer to produce the line break behavior in a general way.
I would consider this describe issue to be closer in nature to the New York case, which is one example of a class of text renderings that have minor stylistic adjustments on the real-world signs that we wouldn't produce a distinction for on the real-world map, if indeed there is a "less than a space" gap between characters.
There are other route networks where the space is explicit, both on signage and in the map:

If we find that in the Dutch case, spaces are being introduced in signage, this suggests that spaces should be inserted in the tagging as well. In the more recent photographs, it appears that the Dutch routes are following the text layout of European E-routes, which do place the space in the ref tag.
In summary, I agree with @claysmalley's assessment that this is a tagging issue to be sorted out with the Dutch mapping community rather than a styling requirement that the renderer should address.

According to the Nationale routenummering (Rijkswaterstaat, 1982), the correct way to write the numbers is without space (page 5):

Het verdient dan ook aanbeveling te spreken of te schrijven over bijvoorbeeld de A12, de N264, de s105 en eventueel over de E35.

The refs in the Netherlands are tagged as such (except s-roads nowadays use uppercase S, which was an actual change at some point in time).
However, for readability there has always been slight spacing on road signs, as you can see in figures 2.1 through 2.4 of the same document. The exact amount of spacing varies depending on when the road sign was designed and by whom (there have long been major differences between Rijkswaterstaat and ANWB). However, the spacing is always less than a full character and can't be considered a proper space character. Meanwhile milestone signs show no spacing at all.
So this is basically a stylistic choice for the renderer, not a tagging problem. Even though Americana has no policy of exactly replicating road signs, it might be interesting for Americana to consider modifying spacing for better international consistency, e.g. by inserting/modifying spaces in ref values via network-dependent regular expressions.

From my subjective experience, having been exposed to these shields all my life, I cannot say that I find the Dutch highway shields in Americana particularly recognizable.

If we find that in the Dutch case, spaces are being introduced in signage, this suggests that spaces should be inserted in the tagging as well.

Disagreed. The official references of these highways are without a space. Adding a space would be a case of Tagging for the Renderer.

From my subjective experience, having been exposed to these shields all my life, I cannot say that I find the Dutch highway shields in Americana particularly recognizable.

These are not recognizable?

This came up previously in https://github.com/osm-americana/openstreetmap-americana/issues/141#issuecomment-1122797418.
In general, this style’s artistic direction pays homage to a particular tradition from print cartography. One element of that is to apply a consistent typeface and color palette to every shield from every country, even if that sometimes requires a slight reinterpretation of the design. So it’s a question of whether we can “get away with” a departure of this magnitude.
There seems to be some precedent for more or less the current treatment, which is not to say that we must uncritically follow this particular example:

France & Benelux Countries (American ed.). 1:500,000. Cartography by Freytag & Berndt. American Automobile Association. 2009. Amsterdam inset.
This is far from the only situation where we’ve taken liberties with route shields. For one thing, we made a decision early on not to hew too closely to reassurance markers for state and provincial routes in North America, because they tended to be too busy for the purpose of marking a route on an already busy map. Rightly or wrongly, this informed many of the initial simplifications we made as we expanded coverage around the world.

Sign
Marker
Description

Québec Autoroute 5

MCTRA 249 Tollway

G1512 Ningbo–Jinhua Expressway

From a technical perspective, we want to gradually reduce the amount of custom string processing that the shield library does, not increase it, to improve the style’s portability in different environments, such as mobile platforms. One possible approach would be to port the custom JavaScript to MapLibre style expressions, but unfortunately the expression language lacks anything in the way of string processing operators. Don’t get me started on what it took just to be able to find and replace semicolons in #666 #670, let alone something that would seemingly require a regular expression. If anyone here is able to push through stuff like maplibre/maplibre-gl-js#2064 maplibre/maplibre-gl-js#2059, it would give us a lot more confidence about that direction. Instead, we’ve taken a different route, trying to make the shields more data-driven, for example working with OpenMapTiles to expose ref:colour=* tags so that we no longer need to hard-code a lookup table of colors for certain color-coded route networks: https://github.com/ZeLonewolf/openstreetmap-americana/issues/654#issuecomment-2008323861.
To the extent that these departures from the physical signs present difficulties in comprehension, hopefully the legend helps a bit as a workaround for now. And of course, just because OSM Americana prioritizes typographic consistency over pixel-perfect shield rendering, that doesn’t mean that it’s the One True Way™. There are several active forks of Americana that apply their own artistic direction. Try it out and maybe we’ll be really jealous of what you come up with and want to copy you. 😉

This way you can also work with special Unicode space characters of various widths.

One possible approach would be to port the custom JavaScript to MapLibre style expressions, but unfortunately the expression language lacks anything in the way of string processing operators.

On top of that, the expression operators are incorrectly implemented so that they’ll misbehave if we pass a non-ASCII space into them: maplibre/maplibre-style-spec#778 maplibre/maplibre-native#2730.


Close database reader faster to prevent deadlocks

Note: I did not compile and test this change.

:shipit:


Suggestion - not issue

On the CarouselView
It would be nice if ItemTemplate was not required. In my case I have my app's checkout steps are in a carousel, and each page is a different ContentView.
I had to create an ItemTemplate for the carousel for it not to throw an exception.
If your control had a default ItemTemplate of something like:
                    new DataTemplate(() =>
                    {
                        var view = new ContentView();
                        view.SetBinding(ContentView.ContentProperty, nameof(ContentView.Content));
                        return view;
                    })

Then it would just work by letting you set a list of views to the carousel, without having to define the template.
It took some time to figure out that the missing ItemTemplate was my issue, because the last carousel I used didn't require me to define it, I believe it was doing something similar to this.

Hm.. Why don't you want to use DataTemplateSelector?.. https://docs.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/templates/data-templates/selector
OR don't you want to use bindings at all ?
Because in this case, I think it would be right to use it..

If you have infinite count of your views, I suggest you to set IsViewCacheEnabled

@Nixon-Joseph if you want to contribute to this repo, firstly you should fork it, create new branch, then create PR from your repo to mine one =)
But, I can do it myself, as you want)

Oh okay. I'll give that a go. I've made one other change too that I think is important. Give me a moment, and I'll try to get the pr to work.

PRs are good)) I like PRs xD

Done! :)


Error Adding, Editing, and revealing Secret

I am getting the following error when I add a secret
undefined is not an object (evaluating '(await this.requestWithRenew(o,"POST",{options:{cas:n},data:t})).data')

This appears in the WebUI. The password does get added correctly though.
Same one when I edit a secret.
And when I try to reveal a secret, I get from list.tsx:27
Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'n.version')

This appears in the console. When I go to edit the password, and reveal the existing one (in the edit page) it works correctly.

How did you manage to get it to work?
I can't even make the plugin api authenticate with the vault for some reason
This is my configuration in netbox
PLUGINS = ["netbox_vault_secrets"]
PLUGINS_CONFIG = {
"netbox_vault_secrets": {
"api_url": "http://<IP_ADDRESS>:8200", # can be relative
"kv_mount_path": "/secret",  # optional
"secret_path_prefix": "/netbox",  # optional
"login_methods": ["token"], # optional, defaults to ["token"]
"token": {
"mount_path": "/auth/token", # optional
"roles": { # optional, will use default_role if missing
"netbox": "Netbox", # maps role name to display name
}
},
}
}
All I am getting from the plugin in netbox webui is
Secrets
Loading...


Typo in Anchor Link - Update bookindex.md

EDIT LINE - 8
EDIT MADE - typo in anchor link
CHANGE MADE - #include/curl to #includecurl
ADDITIONAL NOTE:
The ebook hosted on GitBook has the same typo for the anchor link, but the id element is "include-curl".
FUTURE CONTRIBUTION QUESTION:
The document does not have a glossary, and I'm making one anyway while learning curl. Basically copying and pasting terms(most) from the index links, but some terms are defined only in the context of curl; these I'm copying and pasting from other sources (including the source name and link to where definition was derived which will appear via JavaScript when moused over). There will probably be over 300 terms when finished. To save you (or whoever moderates pull requests) time is this something you would like added to the document?

@jhauga the file bookindex.md is generated by the mkindex.pl script so we need to fix that to generate more proper fragments in the links.
I tried to do that based on the changes in this PR => #297

From what I can tell on gitBooks:
`  is removed - backtick
:  is removed - colon
,  is removed - comma
? is removed
(  is removed
)  is removed
/ to "-" - forward slash
space to "-"
< to "less-than"
> to "greater-than"
+ remains "+"


Naga fails to translate certain correct SPIR-V

Some valid rust-gpu code - such as the idiomatic for i in 0..10 loop sytax, or reading from a depth texture - is not yet supported by naga, or is subject to naga-internal bugs, thus preventing it from being used with bevy.
This can be worked around in the interim by using SPIR-V passthrough, but this is not yet supported by bevy.
A PR exists at bevy/3996, but was closed by its author before being merged. This code still works, and was deemed desirable by the bevy team, so I'll look at adopting said PR and getting it merged.

Opened a new PR: bevy/8131


WiredInput and WiredSearchInput showing "undefined" when no props are passed.

The value and placeholder values should probably be defaulted to empty strings to avoid this.

Fixed in 0.1.4 Release.


Add adyen gateway

I want to merge this change because... it adds Adyen payment gateway.
Please test it on <IP_ADDRESS>:3000, as Adyen has client key configured for this particular address, not localhost:3000.

API branch to test with
adyen_integration
Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

Locally all tests passed. Staging tests did not pass due to bug on staging.

Task linked: CU-7grfen CVC Declined

Task linked: CU-7guf3e Unable to do a checkout on FF


Apply ruff rulse ANN flake8-annotations

https://beta.ruff.rs/docs/rules/#flake8-annotations-ann
make code compliant with rule set and then add to ruleset in .ruff.toml. If appropriate identify specific rules or parts of code to exclude.
2547 errors found for missing annotations.
This is a big one, happy to take contributions by module or individual script rather than addressing entire package in one go.

Closed by #128


Everlong: Idle liquidity parameterization

punting on this in favor of mvp implementation with no idle liquidity to speed up development


How to extract more info from django request?

The user data that's logged by default (with sending of PII enabled) looks something like
{'username': teeberg', 'ip_address': '<IP_ADDRESS>', 'email'<EMAIL_ADDRESS>
I'm trying to add some fields to this, but there doesn't seem to be an official documented way to do this.
Is there a cleaner way than monkey-patching sentry_sdk.integrations.django._set_user_info?
Maybe the request could be sent along as another hint to before_send handlers?

Hi, does this help? https://docs.sentry.io/learn/context/?platform=python#capturing-the-user
Which fields do you want to add?

That doc only explains how to set the user to a fixed string, but how do I get it from the current request? How do I access the current request in a with configure_scope() statement? I'd like to add various flags, such as:

replacing the IP with the actual IP, since sentry doesn't infer it correctly
the access level of the user
If somebody uses "View as" functionality, who the real user behind the request is, additionally to the assumed "actual" user
Which organization they belong to

I just realize that I was probably too tunnel-visioned. I guess I can just add a custom middleware or something that sets the user the second a request comes in... I was looking for a way to do it with the SDK for some reason. If that's the recommended way, please close :)

Yes, that's the way to do it, you always configure the scope for each request :) One thing to note:

replacing the IP with the actual IP, since sentry doesn't infer it correctly

you currently can't set the IP manually, the integration will later override it again. I opened #96 for this.
the fact that the SDK doesn't find the correct IP sounds like worth investigating. Do you know what causes this? Did this work in the old SDK?

@teeberg just re-read your message, what built-in hooks are you referring to?

what built-in hooks are you referring to?

With the old python raven library, I subclassed DjangoClient and overrode get_user_info and get_data_from_request. Don't remember if that was documented somewhere or how I get there, but I suspect the middleware didn't work for some reason. Looks like it got the user info directly from the request without providing a way to hook into and extend it. Anyway, that's what I did back then, I think I was still assuming that a middleware wouldn't work 🙄

the fact that the SDK doesn't find the correct IP sounds like worth investigating. Do you know what causes this? Did this work in the old SDK?

Sorry, this was actually me speaking from memory about what happened with the old library. I saw code in the new library to deal with reverse proxies, so maybe that'll be fixed now. I'll open a new issue if I still see it inferring the wrong IP.
On a somewhat related note, so far I'm really liking the efforts to make the different integrations agree on a common format/API! And also the API seems pretty well thought out, nice work on that 👍🏻


Smart-Soft Proxy SSO plugin

deps: msktutil, cyrus-sasl-gssapi.
MIT kerberos implementation.
When Web-proxy uses LDAP connectors for authentication, SSO plugin gets the first LDAP connector from proxy authentication settings and makes SSO available for that connector.
Use kerberos check-list tab for easy setup, resolve common configuration mistakes, generate/delete/show keytab and test SSO.

@fabianfrz all items is fixed.

https://github.com/opnsense/core/pull/1627 was merged with a tiny bit of changes...

Merged, thanks! Will fix up remaining issues post-merged.


Annotate HTML

Is there any way to use this to annotate a section of HTML that has tags, rather than just a plain text string? Thanks!

Sorry for the delay. Unfortunately, not currently - it's definitely a more complex problem - but happy to think through approaches.


feat: Support numpy 2.0

Feature or Bugfix

Feature

Detail

Support numpy 2.0
Besides upgrading numpy directly, I had to bump Modin to 0.31.0
I override the numpy version when building Lambda layers so that our layers still use 1.x, until we figure out why 2.0 isn't working in AWS Lambda Layers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 1fa63badd64b2913025bd8fe85c3e136dc690bc3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: d842fa62de743326563b993f6f2fb785e78aeddf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 1fa63badd64b2913025bd8fe85c3e136dc690bc3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: d842fa62de743326563b993f6f2fb785e78aeddf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 2f72d3aeeb08d4ed88114172ff0c40204d20c2ea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 2f72d3aeeb08d4ed88114172ff0c40204d20c2ea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Great, thank you @LeonLuttenberger & @jaidisido.
Can you release an updated pip package? Many thanks!


[FEATURE] Scalable Combat Markers

Hi, first of all: Thank you for this great module!
When using the Combat Marker feature I found, that the animations from JB2A are way too big. For me, this makes it hard to see anything else and it distracts my players. Please find an image as demonstration here:

If possible, making the animation scalable would fix this issue. It could for example be a writeable field (1 as standard) or a slider.
Thank you!

sure thing, I will look into adding this feature

sorry it took a bit, but this feature has been added

Works perfectly. Thank you very much from me and my players! :-)


Dynamic Item Classes

Dynamic item classes
Works with Studio's bracket matcher

I just realised I should not have merged this yet... but not going to create a revert PR now.


Possible Unhandled Promise Rejection (id: 0)

Summary
After logging into the Mattermost server, the iOS app displays at the bottom of the screen: "Possible Unhandled Promise Rejection (id: 0)"
Environment Information

Device Name: iPhone 12
OS Version: 14.4.1
Mattermost App Version:  master branch
Mattermost Server Version: 5.33.2 Linux

Steps to reproduce
Compile and launch app then login

cc @enahum @migbot

Yes, I still see the warning. I've attached the screenshot.


array environment has less vertical spacing than mathjax

left is mathjax right is katex, it is subtle, but I find the mathjax equation look a bit better, the extra vertical spacing makes it look less noisy

@kasperpeulen can you provide the TeX source?

@kasperpeulen can you provide the TeX source?

Duplicate of #531 ?

Duplicate of #531 ?

The cause of #531 is an \openup call which I found in the TeX sources of alined, but haven't reproduced on the KaTeX side yet. If one can find such an \openup call for array environments, then it would indeed be a duplicate. But I'd like to see that identified first, to make sure we are handling this correctly, not merely guessing.
I'd also like to see a texdiff for this, check that we are indeed doing things different from LaTeX, because in cases where LaTeX and MathJax differ we tend to emulate the former not the latter. So I second Kevin's request for TeX sources. I guess it might be a {rcl} aligned three-column array.

The cause of #531 is an \openup call which I found in the TeX sources of alined, but haven't reproduced on the KaTeX side yet. If one can find such an \openup call for array environments, then it would indeed be a duplicate. But I'd like to see that identified first, to make sure we are handling this correctly, not merely guessing.
I'd also like to see a texdiff for this, check that we are indeed doing things different from LaTeX, because in cases where LaTeX and MathJax differ we tend to emulate the former not the latter. So I second Kevin's request for TeX sources. I guess it might be a {rcl} aligned three-column array.

@kevinbarabash
Here is the source:
    \begin{array}{rclcl}
    2x + 5 &=& 4x -3 &&\\
    2x + 5 - 4x &=& 4x -3 - 4x &&\\
    -2x +5 &=& -3 &&\\
    -2x +5 -5&=& -3 -5&&\\
    -2x  &=& -8&&\\
     x  &=& 4&&
     \end{array}

I've adjusted this test case slightly to fit it into the 1024px width of our screenshot tests. The result indicates that our current behavior matches what LaTeX does:

KaTeX output in red, mostly due to thicker font. LaTeX output in green, indicating a slight difference in vertical placement of the = in relation to the rest. But most things are white or black, indicating that KaTeX and LaTeX agree. In particular there is no noticable drift where things would look more colored at some vertical positions but less at others. So I'd say KaTeX is doing things the LaTeX way. If MathJax decides to space things differently, that is their decision, but the reference for KaTeX is LaTeX, not MathJax.

@kasperpeulen in the future it might be nice to add \addtolength, but for now you can use \\[1em] to adjust the space between lines.


ContractModel: simplify starting contracts with parameters

This fixes the previous uncomfortable interface to starting contracts in ContractModel tests.

Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[ ] Reviewer requested

@sjoerdvisscher do you have time to have a look at this?


Create field without quotes

I'm looking for the easiest way to create a field without quotes in 0.33.
Like so:
path: path.join(__dirname, "/"),
I've tried to use addPropertySerializer and addTypeSerializer but there appears to be no documentation on the new version of these APIs, and I'm not successful thus far.

The addPropertySerializer and addTypeSerializer do not seem to function at all.  We are switching to some custom regex for the moment and looking at switching back to Jackson.

Switched to Jackson.


Jest not picking latest plugin from babel.config.js

I have my own babel plugin mentioned in babel.config.js and when I change the plugin, jest doesn't pick the updated plugin code and breaks tests. When I run
npx jest --no-cache, updated changes are picked up.
I do not want to run with --no-cache everytime I update the plugin.
I am curious to know how jest picks the latest babel plugins, when they are updated in npm artifactory?
I have mentioned my plugin in babel.config.js as:
module.exports = function (api) {
  api.cache(true);

  const presets = ["@babel/preset-env", "@babel/preset-react"];
  const plugins = [
    "@babel/plugin-syntax-dynamic-import",
    "@babel/plugin-proposal-class-properties",
    "@babel/plugin-transform-runtime",
    ["module:@babel-plugin-dynamic-import-override", {
      options: someOptions
    }]
  ];

  return {
    presets,
    plugins
  };
}

Also, what changes do I make to my jest.config.js to make it pick the latest plugins?

Please follow the template when opening issues.
As for why changes are not picked up - I'm not entirely sure. We use babel's own APIs to load the config. Probably the config babel returns doesn't check if the contents of each plugin has changed, only if the config itself has changed. Thus you get a cache hit even though the plugin has changed.
Config loading code: https://github.com/facebook/jest/blob/0935f7c2cd7780e47365511e35efc829ba359df4/packages/babel-jest/src/index.ts#L46-L64

Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Thanks @SimenB for answering. Ill put it at the required place.
Please NOTE: I am not facing such issue when bundling with webpack, webpack also uses the same babel.config.js and is able to pick the updated plugins, even when config remains the same.

By default caching is off for babel-loader - have you turned it on? Looking at their code, it's basically the same as ours (using loadPartialConfig and creating a hash based on that result). So if they don't have issues with their caching, maybe we can do something

Does Jest have something like cacheIdentifier as in babel-loader (https://webpack.js.org/loaders/babel-loader/#options) ? This can help me to burst cache and pick latest babel plugin whenever I update my plugin? Also, it will help to use cache for all the test runs and only burst the cache when required, probably using environment variable.

We don't, and we won't add it. It's not a common use case to change the implementation of babel plugins while running tests, and we already have a way too big API. If you want you can extend babel-jest and add some sort of env variable to the getCacheKey function.
import { createTransformer } from 'babel-jest';

const transformer = createTransformer();

export = {
  ...transformer,
  getCacheKey(...args) {
    const key = transformer.getCacheKey(...args);

    return key + process.env.THING_I_CARE_ABOUT;
  },
};

https://jestjs.io/docs/en/configuration#transform-object-string-pathtotransformer-pathtotransformer-object


Draft of Live Unit Testing document.

//cc @kempb @morrisjoe @manishjayaswal

@rpetrusha,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


more abstract location object; reformat variant location objects; gene genomic locations

@markquintontulloch @chris-grove @sierra-moxon I've tried to address the suggestion from today's DQM meeting (creating sibling curated and source variant location objects with different requirements), as well as issues raised in last week's variants working group meeting (making source_general_consequence a SlotAnnotation). Please have a look. Thanks!

@gildossantos  Yeah, more or less. Similar to our parallel constraint differences for "Curated" vs. "Source" location associations, it could satisfy the curators requirements if curators were able to (1) indicate a generic chromosome/scaffold/etc. object without specifying a specific chromosome or assembly or (2) provide the same with but with a specific chromosome and/or assembly, depending on the case.

As described above, would we use these Chromosome (child of AssemblyComponent) entities as objects in cytological or genetic location associations? That would be a simple solution, but that does not seem quite right to me conceptually. Is it just me?

@markquintontulloch - yes. Would it work to loosen the genome_assembly requirement, or, allow for a placeholder GenomeAssembly entity in that slot?

If we were to use a placeholder then I think that brings us back to the idea of 'unspecified' genomic objects and we wouldn't need to make Chromosome a child of GenomeAssembly.  I'm in favour of that as a simple(ish) solution, but what it does mean is that we have to create:
a) an unspecified assembly (possibly one for each MOD/species)
b) specific chromosome objects for each chromosome that belongs to that assembly so that you can refer to e.g. chromosome 2 of unspecified assembly
c) unspecified chromosome objects for each assembly as it seems to be a requirement that curators might want to place a genomic entity on a specific assembly but an unspecified chromosome
I'm not sure that poses too many problems, although it does raise the issue of how we would prevent those unspecified objects being used for curated locations yet allowed in source locations - maybe that just has to be some business logic in the code and not specified by the model.
Loosening the requirement for genome_assembly would essentially have the same result.  We would need chromosome objects that aren't linked to an assembly in order to be able to link genomic entities to them in the database.  I think I'd prefer the assembly to be required and go down the route of unspecified objects though as it reduces the likelihood of things being assigned to an unspecified assembly when the assembly is actually known.
If we do opt for unspecified assembly/chromosome objects then I don't know how you feel about keeping the Chromosome class as currently implemented.  I like the idea of having an association between AssemblyComponents and Chromosomes so that you could pull out all the features that are positioned on e.g. Chromosome 3 of any mouse assembly, including the unspecified mouse assembly.  Whether or not there is a valid use case for that though is probably a question for curators.
All of this seems like a lot of hoops to jump through in order to be able to store source locations where there isn't even enough information to place something on a chromosome at the point of curation.  I'd argue that we should just not create genomic locations for such things - if the reference is stored then the curator can just refer to that if they want to try and assign a curated location at a later date.  That doesn't seem to be a route the curators want to go down though.

@markquintontulloch - all good points. I did like the idea of associating assembly components across genome assemblies, but I don't think we have a use case for that. That's why I asked about what we would use as the object in genetic and cytological mapping data, because that was the main motivation in my original conception of Chromosome. If we want to use AssemblyComponent or some child of that as the object for genetic and cytological mapping associations (which I think is easiest but a slight mis-fit), then I think we have a way forward). Otherwise, I think we need to hold onto the Chromosome as I defined it (not make Chromosome a child of AssemblyComponent), but we make new AssemblyComponent objects having unspecified assembly for each of the chromosomes for each species, to be used for less specific genomic mapping requirements (as you've laid out).

@gildossantos I agree that using AssemblyComponent for genetic and cytological mapping data doesn't really fit right.  I like the idea of keeping the current Chromosome objects for the purpose of having mapping location classes where the object is Chromosome.

@gildossantos Is this ready to become a non-draft PR? We can merge it then

@chris-grove - Yes, I think so.


Autocomplete not working, generating error in dev console

I followed the instructions and ensured everything is in it's proper directory, but the autocompletes appear to not be turned on at all. I am receiving this error:
Cannot read properties of null (reading 'children') TypeError: Cannot read properties of null (reading 'children')     at updateOnBackgroundChange ((index):773:45)     at (index):910:5     at runCallback ((index):82:9)     at Array.forEach (<anonymous>)     at executeCallbacks ((index):88:11)     at MutationObserver.<anonymous> ((index):93:9) runCallback @ (index):84 executeCallbacks @ (index):88 (anonymous) @ (index):93
I'm 99% sure the error is related to the above. I made sure and disabled plugins as well to rule them out.
The plugin "iCloud Passwords", the Apple password manager, breaks this plugin, fyi.

The error above isn't related to this script, it's caused by the imageviewer.js file that's shipped with the webui. Happens for me as well while the script is working fine.
Just to make sure - tagAutocomplete.js has to go into the javascript folder, not in the scripts folder like most other scripts.
Like this:

Another idea:
Since you said the Apple password manager breaks it, are you using Safari? It might be that Safari doesn't support all the features the script uses.

*facepalm. I swear I read that 10 times! I'll give that a try.
The password manager situation is separate. I'm using Chrome for windows and the error here was:
Uncaught SyntaxError: Identifier 'WBSAutoFillFormTypeUndetermined' has already been declared
along with a line number. It's apparently a common issue with autofill scripts and went away when I disabled the Apple plugin.

It works now, you were right about the directory. Thanks!


FFI getch from ncurses returns -1 (Error) on a simple example

Expected result: window waits for a key input, then result is printed on screen
Actual result: window does not wait for a key input, getch instantly return -1, which is error.
use "lib:ncurses"

primitive Window

actor Main
  new create(env: Env) =>

    let window = @initscr[Pointer[Window]]()
    let char   = @getch[I32]()

    @endwin[I32]()

    env.out.print(char.string())

Code below is an equal C version. Works exactly as expected (described above).
#include <ncurses.h>
#include <stdio.h>

int main() {

    WINDOW *w = initscr();
    int     x = getch();

    endwin();

    printf("%d\n",x);

    return 0;
}

gcc -E gives the code below for C course above. I suspect that library relies on preprocessor for some work, like transforming getch() into wgetch(stdscr)
int main() {

    WINDOW *w = initscr();
    int x = wgetch(stdscr);

    endwin();

    printf("%d\n",x);

    return 0;
}

Nice catch!
Yes, Pony does not run the C preprocessor or examine C header files. This means you can't use C macros from Pony. Using -E with your C compiler of choice is an excellent way to figure out how to do whatever expansion is needed.

We should probably make note of that in the FFI docs


No default DRIVER registered for jdbc:mysql

I edit /exa/etc/EXAConf, and then add
# MYSQL driver configuration
[[MYSQL]]
    # BucketFS that contains the MYSQL driver
    BucketFS = bfsdefault
    # Bucket that contains the MYSQL driver
    Bucket = default
    # Directory within the bucket that contains the drivers
    Dir = drivers/mysql

settings.cfg is
DRIVERNAME=MYSQL
JAR=mysql-connector-java-8.0.23.jar
DRIVERMAIN=com.mysql.jdbc.Driver
PREFIX=jdbc:mysq:
FETCHSIZE=100000
INSERTSIZE=-1
then I put "mysql-connector-java-8.0.23.jar" & " settings.cfg" into both
/exa/etc/drivers/jdbc/
/exa/etc/drivers/mysql/
/exa/data/bucketfs/default/drivers/jdbc/
/exa/data/bucketfs/default/drivers/mysql/
when I run the sql
CREATE OR REPLACE CONNECTION JDBC_MYSQL
TO 'jdbc:mysql://<IP_ADDRESS>:13306/dbtest'
USER 'root'
IDENTIFIED BY '123456';
SELECT * FROM (
import from JDBC at JDBC_MYSQL
statement 'select''dbtype cmd cost''FROM exec'
);
SQL 错误 [ETL-1]: No default DRIVER registered for jdbc:mysql://<IP_ADDRESS>:3306/dbtest. Please specify DRIVER or add a default via EXAoperation (Session:<PHONE_NUMBER>001184256)

PREFIX=jdbc:mysq:
Ist there an l missing?
Otherwise, have a look here for the driver option:
https://docs.exasol.com/sql/import.htm?Highlight=import
Example (in your case, you would use DRIVER='MYSQL' as you defined that as your DRIVERNAME.
IMPORT INTO table_4 JDBC DRIVER='MSSQL'        AT 'jdbc:sqlserver://dbserver;databaseName=testdb'        USER 'agent_008' IDENTIFIED BY 'secret'        STATEMENT ' SELECT * FROM orders WHERE order_state=''OK'' ';

PREFIX=jdbc:mysq:
Ist there an l missing?
Otherwise, have a look here for the driver option:
https://docs.exasol.com/sql/import.htm?Highlight=import
Example (in your case, you would use DRIVER='MYSQL' as you defined that as your DRIVERNAME.
IMPORT INTO table_4 JDBC DRIVER='MSSQL' AT 'jdbc:sqlserver://dbserver;databaseName=testdb' USER 'agent_008' IDENTIFIED BY 'secret' STATEMENT ' SELECT * FROM orders WHERE order_state=''OK'' ';

Your might misunderstand.  According to the error log, I should find the place to put MySql Driver. But there is no useful information here or on the official website

PREFIX=jdbc:mysq:
Ist there an l missing?
Otherwise, have a look here for the driver option:
https://docs.exasol.com/sql/import.htm?Highlight=import
Example (in your case, you would use DRIVER='MYSQL' as you defined that as your DRIVERNAME.
IMPORT INTO table_4 JDBC DRIVER='MSSQL' AT 'jdbc:sqlserver://dbserver;databaseName=testdb' USER 'agent_008' IDENTIFIED BY 'secret' STATEMENT ' SELECT * FROM orders WHERE order_state=''OK'' ';

Your might misunderstand. According to the error log, I should find the place to put MySql Driver. But there is no useful information here or on the official website

Hi, the error log just tells that the db couldn't identify which driver to use. There are two things to consider:

the prefix. If you specify jdbc:mysq: where an l is missing, but use jdbc:mysql: later in the import - these are two different prefixes.
if you specify multiple drivers with the same prefix, you can use the DRIVER option to explicitely choose one of the drivers. But in your case, please fix the typo and try again.

Hello, I get the same error with my DB2 configuration.
The configuration in the EXAConf:
 # DB2 driver configuration     [[DB2]]         # BucketFS that contains the DB2 drivers         BucketFS = bfsdefault         # Bucket that contains the DB2 drivers         Bucket = default         # Directory within the bucket that contains the drivers         Dir = drivers/db2
My settings.cfg ist the following:
DRIVERNAME=DB2 JAR=db2jcc4-10.5.7.jar DRIVERMAIN=com.ibm.db2.jcc.DB2Driver PREFIX=jdbc:db2: FETCHSIZE=100000 INSERTSIZE=-1  (I put in the additional empty line)
I put my db2jcc4-10.5.7.jar and the settings.cfg into the following folders
/exa/etc/drivers/jdbc/
/exa/etc/drivers/db2/
/exa/data/bucketfs/default/drivers/jdbc/
/exa/data/bucketfs/default/drivers/db2/
I created a connection with the following sql:
CREATE OR REPLACE CONNECTION JDBC_DB2
TO 'jdbc:db2://:/'
USER ''
IDENTIFIED BY '';
If I run the following import test I get the error "No default DRIVER registered for jdbc:db2::/":
SELECT
*
FROM
( IMPORT
FROM
JDBC AT JDBC_DB2 STATEMENT 'select ''Connection works'' from SYSIBM.SYSDUMMY1' );
Is there something I am missing?

Hello @mrclth
I think for a DB2 driver you also need to disable a security manager. This is an additional line in the settings.cfg file:
NOSECURITY=YES. Please see an example here: https://github.com/exasol/db2-virtual-schema/blob/main/src/test/resources/settings.cfg
In the test I did with DB2 I uploaded the driver and the config to the "/buckets/bfsdefault/default/drivers/jdbc/".
Please, try uploading the files to the bucket via curl command. If you upload them via ssh, you probably use an admin user and the files are not detected in this case, permissions transferring is required. Example:
curl -v -X PUT -T file.jar http://w:<write password>@localhost:2580/default/drivers/jdbc/file.jar

I had to use the port 6583 but it works now.
Thank you @AnastasiiaSergienko


https://github.com/wso2-enterprise/wso2-apim-internal/issues

Description
When sending multipart/form-data requests to the backend via API Manager 4.0.0 the Content-Type has changed.
When calling the API (from client to gateway), the Content-Type is sent as Content-Type: text/plain; charset=UTF-8.
When passing the request to the backend (from gateway to backend) the content type has changed to Content-Type: text/plain; charset=US-ASCII.
Steps to Reproduce

Create a API with the POST resource.
Send a payload with the Content-Type is type=text/plain; charset=UTF-8 and a file.
Enable the wire logs and invoke the API.
When checking the headers you can observe this behavior.

Affected Component
APIM
Version
4.0.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Hi all,
Master fix has already been sent with https://github.com/wso2/wso2-axis2/pull/239
Thank you
Avishka


[Bug] v-model cannot be used in v-for

Bug Demo
The v-model depends on the lifecycle hooks of directives, but the implementation of lifecycle hooks for v-for is not perfect. The PR #123 will fix this issue. (The Demo in PR #123)

Fixed in #123


Windows agent

I am writing a SaltStack formula for Amon and am trying to include all platforms supported by it.
The Single binary collector agent link the main page of amon.cx points me to this repo, which appears to be for linux only. Windows is not covered in the installation instructions either. I see that there is a 'amonagent-windows' repo, but there has been no work on it since Sep 25, 2015.
Is this still the still the prefered repo/method of installing the agent on windows?

@beardedeagle The windows agent is in a little bit of a strange situation right now. I want to use amonagent for both Windows and Linux. Currently I can not do that, because Windows process monitoring does not work. On Linux, the agent relies on sysstat, but there is nothing similar on Windows.
And I have the Python agent, found in amonagent-windows which has no been updated for the latest Amon version. The monitoring part in that one works on 100%, but I have to change the reporting method from individual server keys to automatically generated machine-ids
Whenever I have the time, I am probably make the amonagent-windows compatible and then find a way to fix the official Golang agent.

@martinrusev Only thing I can think of is perf counters.

@beardedeagle I spent a considerable amount of time with Perf counters, but they require a little bit too much Windows specific expertise, especially calculating the CPU usage for individual process and separating processes/services.

Maybe there is someone who knows more about developing Windows tools and could provide some input?!
The windows agent is really usefull. A pitty that it does not work currently.


Question: The proper way to handle initiating a route change after an action completes?

Let's say I have a search form that the user fills out. They click submit, and an ActionCreator is fired to perform the search. When the search response has completed, I want to transition the user to a new route.
Is the best way to do this to simply have a search reducer that has a value that changes searchComplete to true, and then use a lifecycle hook like componentDidUpdate to check for that and then initiaite the transition?
I know that is the router was powered by Redux in the first place, the Action creator would just trigger another action to do the transition, but that is not the case here.
Or is it legitimate to pass a callback to the action creator that gets called when the data has finished being added to store? That doesn't seem very Fluxy.
Is componentDidUpdate the right place for this?

You can use componentWillReceiveProps in a way like you described.
You can use redux-router (ex redux-react-router) which lets you express transitions as regular Redux actions. You can use redux-thunk to combine a search async action with a router transition action.
You can have your async action return a Promise (via redux-thunk, redux-promise or something else), wait for it from your component, and then just call this.context.history.pushState(null, nextUrl).

Thanks @gaearon, these are great suggestions. I am using react-native, so for now redux-router is off the table. That said, I also created an issue (rackt/redux-router/issues/63#issuecomment-142774610) in that repo which offers some suggestion on how that project could move towards a react-native version.

I took a quick peek at the Alt project they mention and it seems that it is
just shimming the router? It does not seem like a lot of code…
On Thu, Sep 24, 2015, 19:32 Adam Duro<EMAIL_ADDRESS>wrote:

Thanks @gaearon https://github.com/gaearon, these are great
suggestions. I am using react-native, so for now redux-router is off the
table. That said, I also created an issue (rackt/redux-router#63
https://github.com/rackt/redux-router/issues/63#issuecomment-142774610)
in that repo which offers some suggestion on how that project could move
towards a react-native version.
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/redux/issues/791#issuecomment-142997552.

--
Wout.
(typed on mobile, excuse terseness)

My app was crashing when I put the routing logic inside of componentWillReceiveProps() lifecycle hook (I am using wix/react-native-navigation and had to use setTimeout of 1ms to overcome it)..
Then I realized that componentDidUpdate() seems to be a much better place for performing this operation because I believe when we use componentWillReceiveProps(), React is ready to render the component but triggering a route change, interrupts React's flow and it is not able to close the current flow properly. On the other hand componentDidUpdate() seems better because after the re-render, React is not waiting on anything and we are free to perform the navigation.
This is my basic understanding of the scenario. I am more than welcome to a better suggestion though.
Cheers


XML source window

The XML source window doesn't seem to behave that well. Depending on the size of the file, it can be a bit unresponsive when it loads and when the user scrolls. It also doesn't necessarily present the format in a readable manner, as it makes almost no changes to the layout, such as by adding indentations or line breaks, or remove superfluous whitespace, to improve readability. I also don't find the WebView- and JavaScript-based implementation very elegant and it looks like security precautions are needed against unwanted JavaScript injections (which begs the question why it should be done this way to begin with).
I'll ask bluntly: do we actually need this? For debugging purposes (parsing errors) it would suffice to just check out the file in the library. There is also the external validation option in the Get Info window that the user could use instead. Moreover, if we do add JSON support, then this window would have to be improved too with JSON-specific logic and another syntax highlighter.

I like being able to see what Vienna is operating on. I have a few times been able to identify an issue with a feed causing Vienna to not parse things properly by using the XML Source window. (I think at least once it was because there was an HTML5 video tag, without the tailing '/', in the source of the article, which therefore made it invalid XML.)
That being said, what I actually want is just to know what exactly Vienna thinks the current feed data is. I don't need the syntax highlighting, etc. I usually copy the data into a text browser to actually look at it.
I'm not sure what you mean by "check out the file in the library". Also the few times I've tried the "external validation", it hasn't been useful -- it doesn't tell me what Vienna thinks the data is, only what the validation service retrieves (and what it considers valid).

A copy of the XML file is stored in the user library at ~/Library/Application Support/Vienna/Sources. The XML window is basically just a viewer for this file, with some minor text replacements. For the most part it just prints the raw source as retrieved from the server and adds syntax highlighting.
Malformed or invalid XML should be spotted by the validator service, this isn't something the XML source window is particularly useful for, unless the syntax highlighter shows it. We could look for a substitute service if the current one is not working satisfactorily. From what I can see it doesn't look as though Vienna does anything else to the source when it retrieves and saves the copy. Perhaps we could substitute the source window with a "Show in Finder" button to show the location of the XML file instead. I am of course open to other suggestions too.
I wouldn't mind expanding the functionality of the source window, but I wonder if it were fruitful to spend time on this. Removing it would get rid of some code in AppController, which is a priority at the moment.

XML Source was added because when the parser was being written, the number of edge cases was huge and resolving them not only required users to send me the source but often I had to forward them to the site owner to fix the generation on their side. It doesn't really need to be on the popup menu though. A button on the Info page would be easier.

Steve

I think it would be fine to remove the XML Source window for now, and maybe just have a button on the info page as Steve suggested, but the button can "Show in Finder" the XML file in ~/Library/Application Support/Vienna/Sources.

The window has been removed. Instead, a button can now be found in the Info window where the user can open the file in their default XML handler (or TextEdit).
We should reconsider this in the future if we have some more time to spend on refactors/improvements.


Question about Table 3

Hello, thanks for sharing your great work! :)
I'd like to ask a question about Table 3.
When I run preprocess.py,
Attraction counts 150 instead of 135.
The results for the other domains are the same as in Table 3,
I'm wondering if there's something I missed or a typo.
Thank you

@yukyunglee Hi, thank you for pointing that out!
I think I made a typo in the paper. I will correct it in the revised version.


Fix delete issue

Signed-off-by: Maggie Chen<EMAIL_ADDRESS>

/hold
Will work on unit test

/unhold
/lgtm


Fixed ePerson link on edit group page

References

Fixes #2661
Related #2391

Description
Since the creation of the new separate ePerson pages the ePerson route includes the id of the ePerson. This PR now fixes this route in both the display ePerson tab & the search ePerson tab on the edit group page.
Instructions for Reviewers
List of changes in this PR:

Fixed the link on edit group for both the display ePerson tab & the search ePerson tab
Removed the now unused method EPersonDataService.getEPeoplePageRouterLink() since it's better to use getEPersonsRoute() directly

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

Thanks @alexandrevryghem! I noticed this bug today and thought it must be something with my setup.
I tested this patch on DSpace 7.6.1 and it fixes the problem.
@tdonohue this seems to be a pretty straightforward patch. Can this be 1 APPROVAL?

@alanorth : Yes, I agree this should be 1 Approval.  Looks like this was just overlooked.  Adding the label now.  Feel free to merge/backport if you find it's working well.


Spec and suite command line args as arrays

Proposed changes
This fixes #90 and implements suite and spec command line arguments as arrays.
Tests can now be ran like this:
./node_modules/.bin/wdio wdio.conf.js --spec ./test/foo.test.js ./test/bar.test.js
./node_modules/.bin/wdio wdio.conf.js --suite Foo Bar
In V4 they would have been ran like this:
./node_modules/.bin/wdio wdio.conf.js --spec ./test/foo.test.js,./test/bar.test.js
./node_modules/.bin/wdio wdio.conf.js --suite Foo,Bar
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Reviewers: @webdriverio/technical-committee

Codecov Report

Merging #91 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage    94.7%   94.72%   +0.01%
==========================================
  Files          86       86
  Lines        1758     1764       +6
  Branches      376      379       +3
==========================================
+ Hits         1665     1671       +6
  Misses         81       81
  Partials       12       12

Impacted Files
Coverage Δ

packages/wdio-config/src/lib/ConfigParser.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e562e...f1d075c. Read the comment docs.

It looks like the last CI failure is not related to this branch. Might need to increase the jasmine timeout somewhere?

rerunning


The 06_validate_datasetjson.sas program (potentially underlying code) appears to truncate the message to 250 characters

he 06_validate_datasetjson.sas program (or underlying code) appears to truncate the message to 250 characters:
'1' is not of type 'number' Failed validating 'type' in schema['properties']['clinicalData']['properties']['itemGroupData']['additionalProperties']['properties']['itemData']['items']['items'][0]: {'description': 'The first item in the data array need

This might be a limitation of SAS PROC FCMP. When you run the code in Python (see scripts/json_validate.py) it will dump the error message and the complete Dataset-JSON file. I will look into this. Also, when there are multiple issues, it would be nice to see them all.

Yes, I was going to report that separately as it appears it is an independent issue of just reporting the first issue it encounters on each file.

This is fixed. PROC FCMP can only return 255 characters on a line. Instead of dumping the whole exception heap, you will get in the results dataset: (as an example):

result_code = 1
result_character = "'1' is not of type 'number' (The first item in the data array needs to be a number (itemGroupDataSeq))"
result_path = "$.clinicalData.itemGroupData.IG.RELREC.itemData[0][0]"

I will open a seperate enhancement request to get all errors.

Tested the fix. Looks ok now.
Looking forward to test the enhancement #22 when implemented.


feat(locale): Add TH (Thai) Translation

Hi Everyone
I would like to contribute TH translation for Turnip Prophet, since I see a lot of Thai players using this app a lot.
Screenshot:

Any comment and suggestion are welcome! :)
PS. I will ask my friend to check typo and gramma for Thai word and will confirm here again!

@theRTC204 Okie, your comment and @kunpakorn2005 are addressed!
confirm with my friend that translation are all good, in the future if we can find more Thai friendly word for translation, I will open another PR

Thanks!


Conflict with Monk's Active Tile Triggers

When both Window Controls and Monk's Active Tile Triggers are active, any tiles that use an onClick or Double onClick function do not work. On Enter and other tiles seem to work fine, but if you use MATT for things like menus, DM buttons and such, they won't work while Windows Controls is active.
I'm not sure which mod, if not both, need to be tweaked for them not to conflict, but I'm reporting it for both modules just in case.

Can confirm. Considering the ubiquity of MATT, this is a fairly significant issue. It actually appears that the click triggers do work if the tile is large enough, but below 200x200, they behave unpredictably.


Fix casing of webpack

First of all, thanks for this package, really amazing!
Quick PR: webpack is written lowercase

Thanks for the review and merge!


feat(codemods): add @suspensive/codemods package

Overview
https://github.com/user-attachments/assets/4140416d-fcf7-437f-bb24-35f918afcd70
Roadmap

[x] setup package
[ ] tanstack-query-import

PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
Attention: Patch coverage is 42.50000% with 46 lines in your changes missing coverage. Please review.

Project coverage is 71.99%. Comparing base (7b9c6a1) to head (97bc810).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
- Coverage   76.69%   71.99%   -4.71%
==========================================
  Files          63       67       +4
  Lines         502      582      +80
  Branches      111      127      +16
==========================================
+ Hits          385      419      +34
- Misses        111      150      +39
- Partials        6       13       +7

Components
Coverage Δ

@suspensive/react
100.00% <ø> (ø)

@suspensive/react-dom
100.00% <ø> (ø)

@suspensive/react-native
100.00% <ø> (ø)

@suspensive/react-query
72.86% <ø> (ø)

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/jotai
0.00% <ø> (ø)


Changing drag handle icons?

Clear and concise description of the problem
First of all, wonderful library! It was super flexible for most of my needs, and I really appreciated it!
I managed to style most parts of the calendar except for the drag handles. Those seem a little out of place with respect to the rest of the UI. Is there a possibility to send my own icon or modify it via JS? I've been trying to find the icon on the source code, but I couldn't and the icon div also seems empty.

Suggested solution
It would be good to have a prop to accept drag handle icon.
Alternative
No response
Additional context
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

[ ] I'm willing to open a PR

Ok nevermind, I just had to add the below css:
.rbc-addons-dnd-resizable {
  position: relative;
}
.rbc-addons-dnd-resize-ew-anchor {
  top: 3px !important;
}
.rbc-addons-dnd-resize-ew-icon, .rbc-addons-dnd-resize-ns-icon {
  background-color: hsla(var(--primary) / 50%);
  border: none !important;
  border-radius: 4px;
}
.rbc-addons-dnd-resize-ew-icon {
  width: 3px;
  height: 12px !important;
}
.rbc-addons-dnd-resize-ns-icon {
  height: 3px;
  width: 12px !important;
}


Feature/addon 34284 ucc splunk UI migration components basic form

ADDON-34284 and ADDON-34286

Added basic Form View [WIP]
Added Custom Control and ControlWrapper
tested basic functionalities of form, Few warnings needs to be resolve

I have read the CLA Document and I hereby sign the CLA

:tada: This PR is included in version 5.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


agent_ctl.sh: nameserver resolution fails for servers at <IP_ADDRESS>[0-9]+

We couldn't get consul_agent starting on cf-release v231 because the nameserver was at <IP_ADDRESS>, but the nameservers variable in agent_ctl.sh didn't include it.

Closing this issue in favour of the PR you submitted.

For reference: https://github.com/cloudfoundry-incubator/consul-release/pull/15


focusworkspaceoncurrentmonitor does not exist

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit v0.34.0  ().
Date: 2024-01-01
Tag:

flags: (if any)

Bug or Regression?
Bug
Description
Hyprland complains that the focusworkspaceoncurrentmonitor dispatcher as documented on the wiki does not exist.
Config error at line 153 (/home/ethan/.config/hypr/hyprland.conf): Invalid dispatcher, requested "focusworkspaceoncurrentmonitor" does not exist

How to reproduce
Edit the default config, replace the workspace dispatcher with focusworkspaceoncurrentmonitor.
Crash reports, logs, images, videos
No response

you're using Release v0.34, but the git (not release) wiki
https://github.com/hyprwm/Hyprland/pull/4439 isn't on a release yet

Woops, my bad. Carry on 😅


Building from source with conda

In a conda environment, the current build scripts do not find the appropriate CUDA headers required to compile. Its somewhat difficult to debug since the build scripts are custom.

@alberthi and I are hitting this same issue -- and made some headway on reproducing/debugging it.
Here's some code to set up a vanilla conda env + try to build warp:
conda create -n warp-test python=3.10
conda install -c nvidia/label/cuda-12.2.2 cuda # install cuda toolkit
python build_lib.py # errors due to linking issues

We found if you run conda install -c conda-forge cxx-compiler it's able to find the headers (sometimes we had to run export CUDA_PATH=$CONDA_PREFIX).
However, we still are getting build errors -- specifically, during the clang/llvm portion, we get:
warp/_build/host-deps/llvm-project/release-x86_64/include/llvm/Object/SymbolicFile.h:48:30: error: expected ')' before 'PRIxPTR'
   48 |   OS << "(" << format("0x%08" PRIxPTR, D.p) << " (" << format("0x%08x", D.d.a)

So it still looks like some of the macros aren't getting linked properly. We can still build/use the library by passing --no_standalone to build_lib.py but aren't sure if this will cause issues down the line. Thanks!!

I think you're on the right track with conda install -c conda-forge cxx-compiler. Can you tell me what version of GCC this installs? You may also need a newer glibc version. Try installing a specific version like conda install -c conda-forge libstdcxx-ng=9.5.

In case anyone is interested in this, we have some patches and build scripts in https://github.com/conda-forge/warp-lang-feedstock/tree/main/recipe to build warp with conda-forge dependencies.


Solution for Find the K-th Largest Number #530 (Java )

Description
Fixes #530
Type of change
Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@shantamsultania remove the other files

Done @Amit366

@shantamsultania add the main function

hey @Amit366  i have added the main function also please take a look into that


MSID: 92737 Version: 1 DOI: 2<IP_ADDRESS>1003

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=92737)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/92737/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[ ] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1003)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/92737/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/92737)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/92737

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/92737

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/92737/v1/92737-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/92737)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Preprint was posted in October but the full text is not available. I've reached out to bioRxiv


AEM-14 remove

Removed AEM-14 rule.

Coverage decreased (-0.02%) to 95.432% when pulling 977cdba34e9c820cea0db8b90297d25e59a7f401 on issue-aem-14-remove into 121cd334028e933fb6fcce77683e8040757a68f4 on master.


Not compatible with Firefox Quantum

When visiting https://addons.mozilla.org/en-US/firefox/addon/blocksorg/, with Firefox Quantum 57.0 (64-bit) on Windows 7, I get the message "Not compatible with Firefox Quantum" and cannot add the add-on to Firefox.

Yeah, I’m not totally surprised. Not sure when I’ll get around to fixing the add-on, however.

Hope you get it fixed! Would love to use it

Created a bare bones web extension port that works in Firefox Quantum. #13

@mbostock Simply needs to have it signed and submit it to Firefox. In the meantime, you can clone the repo, cd to the chrome extension directory that contains manifest.json and run web-ext build. Then you can add the extension manually in Firefox Developer Edition. The regular Firefox will not allow it to be added because it is not signed.

Uploaded a V2 to Firefox and included credit to @mbostock  in the license: https://addons.mozilla.org/en-US/firefox/addon/bl-ocks-org/


nixos/xmonad: rename NIX_GHC env var to XMONAD_GHC

Upstream XMonad was using our xmonad patch file for their flake build to
support our nixos module. This would of course break the build upstream
if the version we patched and their master branch diverged. We
discussed that it'd make sense to upstream the environment var code.
In the process it seemed sensible to rename the NIX_GHC variable as
well, since it isn't really Nix-specific – it's just a way to set the
GHC binary to execute. This change has been implemented upstream in an
unreleased version of xmonad now – meaning we'll be able to drop the
xmonad patch soon!
This also clarifies the situation in nixpkgs a bit: NIX_GHC is easy to
confuse with the environment variable used in the ghcWithPackages
wrapper where it is used to set an alternative prefix for a GHC-wrapper
for applications trying to discover it via e.g. ghc-paths. It is an
implementation detail in this context, as it is in the case of the
xmonad module. Since they are different implementations doing different
things, different names also make sense.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg test xmonad

@ofborg test xmonad


gl2ps: init at 1.4.0

Motivation for this change
Library required by octave to close #38459. Picked @7c6f434c as maintainer as is the maintainer of octave. Hope this was okay.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I am OK with being listed as co-maintainer, but please also add yourself as a maintainer.

Should be good now (force pushed the addition of myself to maintainers and and co-maintainer on this package). Thanks!


Mark all messages as read does not work well

After an app restart, unread messages reappear. See https://matrix.to/#/!tDRGDwZwQnlkowsjsm:matrix.org/$1501761897882825jEYhS:matrix.org

I have an issue that may be related.
If I have a session with that uses (MXFileStore [self.session setStore:store ... ] ) when calling markAllAsRead on a mxroom/mxroomsummary does not seem to work. For instance, the other end of the room do not see the marker updated to the last message after the markAllAsRead call, and the unreadcounter is not 0.

@javierquevedo FYI I just fixed this issue

Nice, thanks for that. I was really looking forward for this fix :)


Getting files C++ compilable

Adding more pointer conversions and type renaming to get C files C++ compilable

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__2M_2_0.counters.old: 1

[microbenchmarks] Performance differences noted:
Benchmark                                                                                cpu_time
----------------------------------------------------------------------------------------  ----------
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/512/2/1  +4%

This PR does not make any logical changes to the code. No new issues were created here.


Add favicon

Favicon is needed favicon generated from https://realfavicongenerator.net/

ok to add a favicon.


fix(EMS-654): Generic combine validation rules function

This PR adds a generic validation function that can consume multiple validation rule function results, combine them, and return as a single object. This helps to be consistent and removes repeated code.
Issue

Validation functions were using for loops
Typings had any
Repeated validation looping code for any form that had multiple rules.

Changes

Create a generic function, combineValidationRules that accepts an array of validation rule function results and combines into a single object of all errors.
Changed to use forEach instead for all validation functions.
Added test coverage

Note
There is an exception where this function cannot currently be used - in the insurance companies house validation. This is because the form consumes validation errors from multiple places - UI validation, and API/companies house response. Maybe could be improved in the future, but not a blocker for this tech improvement.

@abhi-markan Any ideas why DB queries have started failing in the API unit tests? https://github.com/UK-Export-Finance/exip/actions/runs/3767113914/jobs/6404425035 This PR hasn't touched the API at all, purely UI changes. It looks like the DB is not able to be queried


Issue with k8s.io/docs/tasks/administer-cluster/kubeadm/adding-windows-nodes/

It looks like there are some formatting issues with the text after this "If you’re using a different interface rather than Ethernet (i.e. “Ethernet0 2”) on the Windows nodes, you have to modify the line:"
Then it becomes very unclear what are the commands needed to execute vs what is other text. Looks like some incorrect markup.

please watch https://github.com/kubernetes/website/issues/20130
/close
/triage duplicate
/sig windows cluster-lifecycle


feat(langchain): add embeddings support

Ref: #288

coverage: 95.125% (-1.3%) from 96.431%
when pulling 836ac41a70fb19768c91bc5e9bdb08c68b55a54c on 288-langchain-embeddings
into e120414cc0d35c170ea0a5b26efde026ed2db41f on main.


Fix warning "Received true for a non-boolean attribute"

Resolves https://github.com/garetmckinley/hedron/issues/101
What's been going on is essentially all boolean props (debug, fluid, fill, wrap) have been written directly to <div> itself, causing react to render it as e.g. <div fluid=true>. It is a know issue with styled components described here: https://www.styled-components.com/docs/faqs#why-am-i-getting-html-attribute-warnings
The workaround uses stripBoolean HoC function that manually takes away boolean props from the element passed as an argument.

@garetmckinley ping as reminder, hope you don't mind

Hey ! This should definitely be merged ! :)

Sorry for the delay, been on a bit of a sabbatical. I'll cut a new release shortly. Hopefully this hasn't been too big of an inconvenience


Fixed server starting logic to close issue #67

Changed the server starting logic so that it wraps to a different port is port 5000 is already in use.

This PR acts as a BugFix.


load_model checkpoint loading harcoded to cpu instead of device parameter

In the old load_model method, checkpoint map_location is hardcoded to cpu.
Maybe I'm missing something but this should be dynamic with the device parameter.
def load_model(model_config_path: str, model_checkpoint_path: str, device: str = "cuda"):
    args = SLConfig.fromfile(model_config_path)
    args.device = device
    model = build_model(args)
    checkpoint = torch.load(model_checkpoint_path, map_location="cpu")
    model.load_state_dict(clean_state_dict(checkpoint["model"]), strict=False)
    model.eval()
    return model

We were not able to use GPU when inferencing.
We got it working when we changed it back to the below:
def load_model(model_config_path: str, model_checkpoint_path: str, device: str = "cuda"):
    args = SLConfig.fromfile(model_config_path)
    args.device = device
    model = build_model(args)
    checkpoint = torch.load(model_checkpoint_path, map_location=device)
    model.load_state_dict(clean_state_dict(checkpoint["model"]), strict=False)
    model.eval()
    return model

I can raise a PR if this is right,

@SlongLiu What do you think about the above?


Cant start flutter project neither on android/ios

We got error:
Error (Xcode): ../../../../.pub-cache/hosted/pub.dev/fetch_api-1.0.3/lib/src/_js.dart:1:8: Error: Dart library 'dart:js' is not
available on this platform.
Could not build the application for the simulator.
Is it a well-known problem, or what could be the issue for it?
I tried to downgrade to 1.5 version before web support, but still got the issue.

I am working on fixing this. There'll be a fix rolling out in next 24hrs.

Update: I’m still ironing out the wrinkles to ensure a smooth experience across all platforms. It appears the dependency issue is a bit more complex than initially thought.
To ensure EventFlux remains robust everywhere else, I'm temporarily disabling web support. My apologies for the hiccup – I'm on it and plan to have web support to be rolled out again within a week.
Version 1.6.6 is out now. Tested and working fine on Android and iOS.


Updating Nodes IP Block size recommendation for PKS with NSX-T installs

@mjgutermuth This addresses an issue pointed out by EMC staff (by way of VMW TPM) who were installing PKS to support multiple Kubernetes clusters. Let me know if I've got it in the right spot, and if it makes sense. thanks

Thanks @lparis!


Conda environment manifest.

Hi! It might be useful for some to manage the dependencies via conda, as it supports non-python deps

Thanks a lot!


Create optional Socket().connect() parameter for timeout on that connection.

Allow modifying the socket timeout when attempting to connect to a server. If not specified, go with default timeout set for socket object.

Done.


Assorted issues

Description & motivation
Closes issue 382, issue 401, and issue 246.
Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please

update the base branch to next
add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
add links to the "New and changed documentation" section of the latest Migration Guide

[x] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

If you removed existing pages (delete if not applicable):

[X] The page has been removed from website/sidebars.js
[X] An entry has been added to _redirects

Welp! I think another rebase might be needed here — I'm not sure how Amy's commits got onto this branch. Let me know if you need a hand!

Oh and the magic term is:
Closes #382
Closes #401
Closes #246
That both hyperlinks the issue, and will make the issue as closed when we merge this PR

Besides incorporating PR comments, I cleaned up the language and restructured sentences to make a lot more sense overall (I hope). There were things in need of attention that I missed the first time around. Was a bit rusty, I must admit 😅


feat: remove jszip and compression utilities

Description
This PR removes the compression responsibility from the encryption package and the sdk overall to reduce the bundle size and delegate that responsibility to the consumers that need it
Changelog

removed the following functions from @lit-protocol/encryption package, and their tests

encryptZip
zipAndEncryptString
zipAndEncryptFiles
encryptFileAndZipWithMetadata
decryptToZip
decryptZipFileWithMetadata

removed jszip from bundle

Migration guide
If you are using any of these functions:

encryptZip
zipAndEncryptString
zipAndEncryptFiles
encryptFileAndZipWithMetadata
decryptToZip
decryptZipFileWithMetadata
You now have to handle compression yourself and encrypt before or after it

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Existing tests still pass

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Nice! if you have the time publishing a test build and reporting the bundle size of LitNodeClient and LitNodeClientNodejs would be awesome.

What I can quickly say using bundlephobia, is that removing jszip should release around these % of each package (based on current published version)
encryption ~4%
lit-node-client & lit-node-client ~2.8%

Here's the result from Bundlephobia
6.4.2

6.4.2-pr-621 (Published from this PR)


requirements upper bounds

I've been enjoying your library, it has some of the better implementations in an easy to implement way (ex. _methods)
One thing I've noticed is that you have specified that your requirements are all static (requests/urllib for example).
Because your implementation of those requirements are not really integrated into your library, would it not make more sense to create a major version upper limit?
my rec:
requests~=2.26
urllib3~=1.26

Im of course ready to be corrected on this.

thanks. I just looked into what this means exactly.
https://stackoverflow.com/questions/39590187/in-requirements-txt-what-does-tilde-equals-mean
I think it sounds like a great idea. if you want u can submit a pull request so it makes you a contributer. i assume that will also work in the setup.py file. I think it needs adding there as well for packaging.
do you know if install requires uses the same tilde?... i.e
  install_requires=[
      'requests==2.26.0', 'python-dateutil==2.8.2', 'urllib3==1.26.7', "elementpath==2.4.0"
  ],

"thanks so much. that's going to save me doing it in 2 places. also strange i never linted the setup.py file. good for spotting that one. I'm still in process of adopting the linting style as preference. I'll get it in the next release which will likely be within a week."

"thanks so much. that's going to save me doing it in 2 places. also strange i never linted the setup.py file. good for spotting that one. I'm still in process of adopting the linting style as preference. I'll get it in the next release which will likely be within a week."

Have you considered using poetry and then incorporating tox to catch things like project linting as well as a tests factory?
I'm a bit bored I'll create a poetry branch and link it in a new issue for you to investigate at your leisure.

Hi. sadly poetry didn't work on the PC i tested it on. I have an open ticket on the poetry repo. no response with about 10 users with the same issue. I don't mind the makefile. but I have considered it. I was massively put off by it not working on PC. for me that's the only reason i could think it useful as I test the python versions via the github workflows. I'd be keen to see the setup. but can't promise i'll merge it if they can't fix they bug.

Im not saying no. I want tox and poetry. I have for about a year. But it did appear for PC users easier to install make with chocolately that make poetry work?... i'm willing to try again with guidance. i.e. your help. but i lost 3 hours last time. i have a poetry branch that went to shit 6 months ago.

Sorry to hear that, I'll take a look at your poetry repo ticket and see as well. Poetry has been a godsend for projects I've worked, pyproject.toml might still be a good way forward as well though (in general!)
I feel your pain on wasting time on essentially dependency management and package deployment! (I wasted my time on pipenv for a while)

ye. i have 2 bugs at the moment. the pc/mac can't run separate tests which stops me generating the coverage report automatically. these thigns i think poetry will fix.

I'll hold off then for poetry (since why fix what isn't broken)

@ShoGinn the poetry bug i mentioned was here. https://github.com/python-poetry/poetry/issues/2746#issuecomment-955718400 but it's probably out of my depth to look into.

FYI, I was thinking @ShoGinn of using your poetry changes on https://github.com/byteface/htmlx/tree/master/htmlx and giving it another try. so thanks for making that version.


[#1211] Add Cache#computeIfPresent and use in CachingSagaStore for Association Values

This pull request does roughly two things:

Adjust the Cache interface by adding a computeIfPresent, and
use Cache#computeIfPresent on the CachingSagaStore to overcome potential concurrency issues.

The former provides a concurrency-safe means to find an entry and adjust it if present.
This is valuable for the CachingSagaStore, as it has several spots where it retrieves Association Values and right after it changes them.
Up to now, we've seen several scenarios where this caused predicaments at the end user.
As such, point two will make the CachingSagaStore thread-safe when it comes to adjusting the cached saga identifiers within the store.
As this PR adjusts the Cache API, it changes the NoCache, WeakReferenceCache, EhCacheAdapter, and JCacheAdapter.
Note that the adapters have a naive implementation of concurrency safety, by making the computeIfPresent method synchronized.
This will lock the entire adapter whenever computeIfPresent is used.
Further effort for improvements here are moved to #2422
Lastly, this pull request changes the CachingSagaStoreTest to an abstract class, with two implementations.
One for the WeakReferenceCache and another for the EhCacheAdapter.
I have omitted the JCacheAdapter test for sake of simplicity within this change (in favor of time).
Effort to rectify this will be performed in #2421.
With all that, this pull request resolves #1211.

I will move along and merge this pull request, as it's been reviewed a second time with some technical constraints (battery running out) just prior to clicking approve.


Ipv6 fixes

Coverage increased (+0.04%) to 72.437% when pulling e5d567ac769aeb2ef7c5f30955261830347af065 on EdDev:ipv6-fixes into 5f3e724190d12ddc20c5681ea4159069a302141b on nmstate:master.

ci test please

ci test please

@tyll , this should now work on both the container and VM (passed on mine).

@tyll this version is following your suggestion, raising test iface up.

ci test please


Upgrade to python-irodsclient v1.1.8

Latest version here. This will be needed for #1592.

The used version of cubi-tk is hardcoded to v1.1.3, meaning we'll first have to upgrade cubi-tk or do bihealth/cubi-tk#96 and switch dependency to that package.

cubi-tk depdendency is now history, but will still wait for v0.14.0 for this upgrade to avoid breaking anything in a minor release.

Done. Note that this breaks compatibility with the earlier version, so python-irodsclient==1.1.8 MUST be installed when switching to dev on this branch.


[Proposal] Add transitional probabilities to Taxi and Cliff Walking toy text environments

Proposal
Only Frozen Lake in the toy text grid world environments implements transitional probabilities.
Taxi is supposed to have it based on the previous documentation but has never been implemented, always returning 1.0.
At the same time cliff walking could also be set up to use transitional probabilities using the same approach.
Motivation
Adding transitional probabilities to taxi will close out a TODO that has been on the list for a long time. It will also bring the environment in line with the source paper, The Fickle Taxi Task - Section 7.1 of Hierarchical Reinforcement Learning with the MAXQ Value Function Decomposition (https://www.jair.org/index.php/jair/article/view/10266/24463).
For cliff walking, it presents and opportunity to add depth to the environment and since it uses the same approach would not add significantly more time or risk.
Pitch
Taxi
Add transitional probability into taxi toy text environment:

leverage approach from frozen_lake to supply a transitional probability of 0.8 direction intended, 0.1 left and 0.1 right of intended direction for movement actions.
the paper proposes that, once the taxi has picked up the passenger and moved one square away from the passenger's source location, the passenger changes their destination location with probability 0.3.
for taxi transition probabilities for pick up and drop off actions remain 1.0.
add arguments to enable/disable features:
- is_rainy = True | False to enable transitional probabilities on taxi movement, defaults to False.
- fickle_passenger = True | False to enable the passenger to change their destination once picked up, defaults to False.

Cliff walking
Add transitional probability into cliff walking toy text environment by leverage approach from frozen_lake to supply a transitional probability of 0.3 direction intended, 0.3 left and 0.3 right of intended direction for movement actions.

add arguments to enable/disable transitional probabilities.
- is_slippery = True | False to enable transitional probabilities on player movement, defaults to False.

For both:

Update unit tests.
Update documentation.
Increment versions in registry.

Alternatives

Do nothing. Misses an opportunity to make the toy_text environments consistent and more useful for beginner RL practitioners.

Remove transitional probability from taxi and/or cliff walking. In either case prob would be removed from the info returned. Removes the need to complete taxi work and will simplify any ongoing maintenance.

Additional context
No response
Checklist

[X] I have checked that there is no similar issue in the repo

I would like to do this one as it will help my understanding of the toy text environments.

Hey @axb2035 , are you still on it ? I need these stochastic environments for my project, so I can open a PR for this issue (if you're not on it of course :)). (cc @pseudo-rnd-thoughts )

@riiswa thank for the note. At this stage I am not actviely working on it, so please progress. :)

I see some members in #661 questioning whether it is really wanted from the maintainers. Could we get a statement here before someone puts the effort in? @RedTachyon  @pseudo-rnd-thoughts

@CloseChoice I might have closed #661 by accident, apologies to @riiswa if that was the case.
If we can add what @axb2035 as an optional feature that extends the current implementation then I think we should be able to add the features discussed.
From what @axb2035 wrote above, #661 seemed to be going in the correct direction, it was missing the probability of the action taken (info["prob"]) and a couple of other sections.
@CloseChoice or @riiswa if you wish to finish the work, go for it and I can review at the end

@CloseChoice I might have closed #661 by accident, apologies to @riiswa if that was the case.
If we can add what @axb2035 discussed in this issue as an optional feature that extends the current implementation then I think we should be able to add the features discussed. From what @axb2035 wrote above, #661 seemed to be going in the correct direction, it was missing the probability of the action taken (info["prob"]) and a couple of other sections. @CloseChoice or @riiswa if you wish to finish the work, go for it and I can review at the end

Thanks for the clarification. Then I'll go for the Cliff walking environment and give @riiswa some more time to finish up the work on Taxi