runtime.RuntimeMonitorTest With Sample Containers multiple monitors: doesn't contain subtring

Unrelated changes were made in #5591, hit this:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6551/testReport/junit/(root)/runtime/RuntimeMonitorTest_With_Sample_Containers_multiple_monitors/
00:43:51 • Failure [18.860 seconds]
00:43:51 RuntimeMonitorTest
00:43:51 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:344
00:43:51   With Sample Containers
00:43:51   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:344
00:43:51     multiple monitors [It]
00:43:51     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:376
00:43:51
00:43:51     Expected
00:43:51         <string>: Listening for events on 2 CPUs with 64x4096 of shared memory
00:43:51         Press Ctrl-C to quit
00:43:51         <- endpoint 12344 flow 0x7c719d69 identity 46874->0 state new ifindex 0: [unknown]
00:43:51         -> endpoint 47934 flow 0x7c719d69 identity 46874->29832 state established ifindex lxcd75f6: <IP_ADDRESS> -> <IP_ADDRESS> EchoRequest
00:43:51         <- endpoint 47934 flow 0x7c719d69 identity 29832->0 state new ifindex 0: [unknown]
00:43:51         -> endpoint 12344 flow 0x7c719d69 identity 29832->46874 state reply ifindex lxcc994f: <IP_ADDRESS> -> <IP_ADDRESS> EchoReply
00:43:51         <- endpoint 12344 flow 0x7c719d69 identity 46874->0 state new ifindex 0: [unknown]
00:43:51         -> endpoint 47934 flow 0x7c719d69 identity 46874->29832 state established ifindex lxcd75f6: <IP_ADDRESS> -> <IP_ADDRESS> EchoRequest
00:43:51         <- endpoint 47934 flow 0x7c719d69 identity 29832->0 state new ifindex 0: [unknown]
00:43:51         -> endpoint 12344 flow 0x7c719d69 identity 29832->46874 state reply ifindex lxcc994f: <IP_ADDRESS> -> <IP_ADDRESS> EchoReply
00:43:51         <- endpoint 12344 flow 0x7c719d69 identity 46874->0 state new ifindex 0: [unknown]
00:43:51         -> endpoint 47934 flow 0x7c719d69 identity 46874->29832 state established ifindex lxcd75f6: <IP_ADDRESS> -> <IP_ADDRESS> EchoRequest
00:43:51         <- endpoint 47934 flow 0x7c719d69 identity 29832->0 state new ifindex 0: [unknown]
00:43:51         -> endpoint 12344 flow 0x7c719d69 identity 29832->46874 state reply ifindex lxcc994f: <IP_ADDRESS> -> <IP_ADDRESS> EchoReply
00:43:51         <- endpoint 12344 flow 0x7c719d69 identity 46874->0 state new ifindex 0: [unknown]
00:43:51         -> endpoint 47934 flow 0x7c719d69 identity 46874->29832 state established ifindex lxcd75f6: <IP_ADDRESS> -> <IP_ADDRESS> EchoRequest
00:43:51         <- endpoint 47934 flow 0x7c719d69 identity 29832->0 state new ifindex 0: [unknown]
00:43:51         -> endpoint 12344 flow 0x7c719d69 identity 29832->46874 state reply ifindex lxcc994f: <IP_ADDRESS> -> <IP_ADDRESS> EchoReply
00:43:51
00:43:51     to contain substring
00:43:51         <string>: -> endpoint 12344 flow 0x7c719d69 identity 29832->46874 state reply ifindex lxcc994f: [unknown]

Not seen this since, may have been caused due to high load in CI environment previously, closing.


DOC: grammatical edits to Privacy Policy

To the project owner/maintainer,
First and foremost, thanks for creating sleek and releasing as open source. I just downloaded it, and the first thing I did is to read the privacy policy to decide whether I want to enable error and event logging. In doing so, I came across this file, and suggested some changes to correct some typographical errors, and made minor changes to improve readability.
Thanks again 🙏

@lacabra Thanks a lot :)


Cleanup

Hi! Sorry, I was bored and stumbled on this code which looked like it could use a clean up :-)

Cool, I completely forgot about it :-D


update for latest Optional spec

EIP-6475 was bumped to emit an additional 0x01 byte in the Some case of optionals to allow nesting Optional and Optional[List] and to provide compatibility with Union serialization. Note that the None case is still serialized as empty.
https://eips.ethereum.org/EIPS/eip-6475
https://github.com/ethereum/EIPs/pull/6945

Apropos https://github.com/status-im/nim-ssz-serialization/pull/46/commits/5d3eac5da27d7229348247cb8502051ecc11b456 see also https://github.com/status-im/nim-ssz-serialization/pull/45/commits/df1d03c96fc94b41caa61e854099a7a6e2edb9e5

And compare https://github.com/status-im/nim-ssz-serialization/pull/45/commits/ecf42b0a9b6d351e3f6287059d580743ed9640e5 and https://github.com/status-im/nim-ssz-serialization/pull/45/commits/ecf42b0a9b6d351e3f6287059d580743ed9640e5
At some some of these fixes should make it in, regardless of the PRs carrying them, at some point, so people stop having to rediscover/reinvent them

OK, I have cherry-picked the explanatory comments that you added there.

In hindsight, cleaner if we simply merge your PR first. @tersec

In hindsight, cleaner if we simply merge your PR first. @tersec

done

It is interesting if the macOS timeout is a related issue to the failure in the other platforms. Either points to something salient:

if it's a root-cause-same-issue, which is manifesting in a way which is a bit more unambiguously wrong (SIGSEGV can mean many things, but looping infinitely like that points to the possible underlying failure mode being within a smaller feasible set which does not include many usual causes of SIGSEGV; or

it's an entirely different issue and something in the relevant code here tickles Nim devel in a way that makes it behave just generally unpredictably, which means that this starts tipping into unknown/unknown territories of exposure to scope of Nim bugs.

I tried to build your minimal repro on macos to see if it exhibits the same behaviour, but I can't even build NIM_COMMIT=devel locally:
cmd: bin/nim c --noNimblePath --skipUserCfg --skipParentCfg --hints:off --warnings:off --hints:off koch
/Users/etan/Documents/Repos/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/system.nim(411, 17) template/generic instantiation from here
/Users/etan/Documents/Repos/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/system/inclrtl.nim(50, 21) Error: invalid pragma: sinkInference: on

Indeed, interesting, where the different behaviour for i386 Linux (works fine), macos C (timeout), and others (sigsegv) is coming from. 1-3 bugs (or possibly more).
As long as it is just devel that's failing, I'm not sure how much time we should invest into debugging this, as this seems to be a Nim issue for an untagged development version. The other possibility is an issue with faststreams (@zah). If we can rule out that one, your minimal repro shared on Discord is likely very useful for reporting (thanks again for creating that one).

Yeah, agree it's not worth that much more effort as long as it's devel only. One thing to watch for will be is if patches from devel are merged into version-2-0 which introduce whatever's happening in devel to 2.0. If that happens, it'll be worth looking at more closely.

On version-2-0, same issues as on devel, minus the oddities regarding i386 working and macos C timing out.
Locally, same build issue as on devel.
make update V=1 NIM_COMMIT=version-2-0

cmd: bin/nim c --noNimblePath --skipUserCfg --skipParentCfg --hints:off --warnings:off --hints:off koch
/Users/etan/Documents/Repos/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/system.nim(411, 17) template/generic instantiation from here
/Users/etan/Documents/Repos/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/system/inclrtl.nim(50, 21) Error: invalid pragma: sinkInference: on
make[2]: *** [build-nim] Error 1
make[1]: *** [vendor/nimbus-build-system/vendor/Nim/bin/nim] Error 2

Interesting, well, at least a build error is more dispositively correct or not.

Any idea why in the CI, it hadn't seemed as necessary to prevent version-2-0 from being tested on ORC on non-i386 platforms?

Back when the split into --gc:refc / --gc:orc builds was introduced in PR #41, the --gc:orc build was only enabled on devel, as version-2-0 was not yet being tested.
When PR #43 introduced version-2-0 testing, the --gc:orc build was still just testing against devel, so it was never run against version-2-0 until this PR where I noticed just before the absence of --gc:orc testing for version-2-0, and added this now with the latest checks.
Behaviour is also broken with ORC, but compared to devel, i386 also fails and macos C no longer times out

Note that the new logic in ci.yml was updated to be more resilient against such bitrot, by inverting the condition so that if a new version is added, both --mm:refc and mm:orc are tested.

i386 also fails and macos C no longer times out

Interesting that both changes are temporally correlated, but with opposite failure-valences.

Yeah, I guess that Nim's own CI has more time-granular results for what commits changed the behaviour in nim-ssz-serialization compilation. As they don't build using our ci.yml, they should have run into this issue sooner than we did.

I found that Nim commit 2dcfd732609a2cfa805e5a94cc105399a2f18632 defaults to refc, so if one runs its default mode, does not end in SIGSEGV on amd64 Linux, but if one uses --mm:orc does, so at least parts of this predate ORC being default.

CI is now green, with these caveats:

On version-2-0, tests fail with --mm:orc
On devel:

On i386 (32-bit Linux), tests succeed
On macOS, tests get stuck and time out when compiling with --mm:orc to C
On macOS, tests fail with --mm:orc when targeting CPP
On other platforms (64-bit Linux and Windows), tests fail with --mm:orc

These caveats have been enforced in ci.yml so that we see when Nim behaviour changes.


Setting for include_storage in invariant tests seems to leak into fuzz tests settings

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.2.0 (1a4960d 2024-03-20T00:19:54.542150000Z)
What command(s) is the bug in?
No response
Operating System
macOS (Apple Silicon)
Describe the bug
Our code in the UniStaker repo has unit tests that will fail if certain addresses are selected from storage by the fuzzer so we turned off include_storage in our foundry toml. This has worked fine for a long time. When we added invariant tests, we turned it on for those tests as the same restriction didn't exists. This worked fine across many thousands of fuzz runs locally and in CI.
Sometime recently, something seems to have changed. Now, we see CI failures where the fuzzer is clearly selecting values from storage for our unit tests.
Here's how you can reproduce.

Clone the UniStaker repo
Copy the .env.template to .env and put in a valid RPC URL (we can avoid actually hitting it by not running integration tests) and deployer private key (it can be the default anvil account)
Edit your foundry.toml, under the [profile.default] section add fuzz = { runs = 100000 }
Run locally forge test --mt testFuzz_CalculatesCorrectEarningsForFourUsersWhenTwoStakeMorePartiallyThroughTheDurationAndOneBeneficiary
You should see a test failures. It may take a bit to run. If you don't see failures, you got "lucky", run the command again

Using older values of Foundry this didn't occur.
Edit: Updated this to remove some comments about the settings in the invariant section impacting the fuzz runs. This seems not to be the case. It simply seems like we're getting values picked from storage now (despite the setting) when previously we weren't.

did you try setting include_push_bytes=false too?

I believe include_storage is still being respected, but the address is being added to the dictionary simply because it exists in the vm database (outside of contract storage), see here: https://github.com/foundry-rs/foundry/blob/e5acbcfe71d5d6687fcc649e91776454f5c3eb73/crates/evm/fuzz/src/strategies/state.rs#L95-L100
However, I don't think that has changed recently so I'm unsure why the behavior appears to have changed. cc @DaniPopes @klkvr

I was not able to reproduce this one anymore since https://github.com/foundry-rs/foundry/pull/7552 fix,  @apbendi would you mind retest? thanks

ping @apbendi, would be great if you could retest this if this still occurs

Hey @zerosnacks, we ended up working around this in the UniStaker codebase, but I just went back and checked out the commit before that fix was merged and ran 1,000,000 fuzz runs with version forge 0.2.0 (6822860 2024-07-29T00:23:34.055980000Z). All passed without issue. So it seems the specific issue we were encountering may be resolved. Always a little hard to say for sure because these things are non-deterministic. But as far as I can tell this problem is fixed for now.

Thanks for retesting @apbendi!
Optimistically marking this ticket as resolved, feel free to re-open if you do end up encountering it in the future


Upgrade pylint

No, I'm not sure what the level of changes is going to be. I started doing this because ecommerce was having issues w/ a checker that should be resolved in a later version of pylint-django, and then after that I realized that we probably need to update the list of checkers, since we're a) in python 3, and b) in a newer version of pylint that probably has useful checks. But, I think we're just going to need a trial run of upgrading edx-lint.

As far as rollout plan: I'm going to be using it as the basis for adding edx-lint to ecommerce, first. I expect edx-platform to pick up the new version w/ the automatic upgrade script, and we'll have to see if that bumps the numbers up too badly.
Slightly longer term, I want to use the repo health dashboard to make sure that we're rolling out edx-lint files across the org (and keeping up w/ version updates).


Tabbar example app

With this PR I added an example app that showcases the functionality of the Routing package together with a TabView.

So, I don't think it makes sense to have an entire example project within the package.
It goes against the idea of it being lightweight.
You could have a public example repo on your page & then we could link to it in the Routing README ?

That's a valid point. Will create a public Repo & inform you


Controls SVG discoverable by VoiceOver on iOS

Description
When using swipe gestures with VoiceOver & Safari on iOS, the controls SVG is discoverable and announced as, "image". This announcement may lead to a confusing user experience as there's no further information on why the image exists. Further, it creates an unexpected and unnecessary "tab-stop."
Adding focusable="false" and aria-hidden="true" directly onto the svg element removes this extra tab-stop from occurring.
<!-- controls-svg.js -->
<svg … focusable="false" aria-hidden="true">
  <!-- … -->
</svg>

Live Demo

Go to <model-viewer> with Safari for iOS
Load up VoiceOver screen reader
Swipe right with one finger until the "image" content is found

Browser Affected

[ ] Chrome
[ ] Edge
[ ] Firefox
[ ] Helios
[ ] IE
[x] Safari

OS

[ ] Android
[x] iOS
[ ] Linux
[ ] MacOS
[ ] Windows

Versions

model-viewer: v0.1.1

Great catch, thanks for filing!


Decoder Input

Hey guys, I really enjoyed reading the paper, and thanks for pushing the source code. I am working on Informer for a multivariate problem where I am having 94 features and one output target. I have a question about the model inference/prediction. In the _process_one_batch method, we are passing the decoder input where firstly, it is being initiated by zeros and it is being concatenated with batch_y. I am removing if conditions as I am working with padding==0. I am training for MS but I am not passing the target variable in the input by changing the read_data method so that seq_x will be having only the features.
# decoder input
dec_inp = torch.zeros([batch_y.shape[0], self.args.pred_len, batch_y.shape[-1]]).float()
dec_inp = torch.cat([batch_y[:,:self.args.label_len,:], dec_inp], dim=1).float().to(self.device)

My question is why are we concatenating batch_y values as in real-time, we will not be having batch_y values? I trained a model and the results look so promising with the above decoder input but if I don't use the batch_y concatenation part then the results aren't looking good.

I have been debugging the code to find out more insights and as I am using MS mode that's why I changed the input in such a way that the target shouldn't be in the input;
 if self.features=='M' or self.features=='MS':
        cols_data = df_raw.columns[1:-1]
        df_data - df_raw[cols_data]

As the last column is the target column so I am not passing that, now in training, I am doing the same and I have checked the complete code and it looks like the actual targets are not being used in training also.
   if self.scale:
        train_data = df_data[border1s[0]:border2s[0]]
        self.scaler.fit(train_data.values)
        data = self.scaler.transform(df_data.values)
    else:
        data = df_data.values

    df_stamp = df_raw[['date']][border1:border2]
    df_stamp['date'] = pd.to_datetime(df_stamp.date)
    data_stamp = time_features(df_stamp, timeenc=self.timeenc, freq=self.freq)

    self.data_x = data[border1:border2]
    if self.inverse:
        self.data_y = df_data.values[border1:border2]
    else:
        self.data_y = data[border1:border2]
    self.data_stamp = data_stamp

As it can be seen from the above code df_data is being used further to extract the x, and y features and in training for targets, there is zero padding being used but the strange thing is that the results look really really good. I am wondering if is there anything I am missing in the code where the targets are also being passed.


Command parser

delegate remote command parsing

should be rebased on #94
replace #54
@dawagner please review

Coverage increased (+0.02%) to 70.16% when pulling d0df2ce739d71a186adbf331d431d38ed0f5e270 on clero:command_parser into 4f6171c80ff3dfa11c8d0b87b5f48f52293c31c1 on 01org:next.


Terraform module to provision ec2 instance on AWS

Closing this PR since, https://github.com/qburst/DevOps-Automations/pull/41


Use client provided Google Maps API keys

Currently, we are using free tier Google Maps API keys. We should ensure that the 2.0 release makes use of client provided Google Maps API keys that are associated with a valid billing account.

Updating to note that we can create the keys and do not need to wait for the client to do so.

Changing the title to reflect the fact that we will be sticking with the keys we have already created and that we just need to set up billing for them.

Closing as we have billing set up for the keys already created.


Implement dask.array.broadcast_to

Seeing other people implement dask functions gives me a very warm feeling inside.


CIDR: Add upper limit on number CIDR matches

Enforce the upper max CIDR limit on the golang side with a clear error message in the logfile instead of a BPF compilation error.

I am not so familiar with CIDR, is the upper limit documented somewhere? If not what should it be?
Thanks.

@jrajahalme can provide the details

@tgraf to ping @scanf when policy spec docs are being merged


Exception in archive_methods.save_readability

When attempting to archive this link with Readability enabled, the following exception occurs.
From what I can tell so far, I think the exception occurs somewhere in here before cmd is instantiated here, which means that cmd doesn't exist after the exception is caught and control makes it down to here.
[√] [2020-08-26 21:10:43] "Big Brother is Watching - '17 WRX Limited and all '17 STI - Page 3 - NASIOC"
    https://forums.nasioc.com/forums/showthread.php?t=2803387&highlight=big+brother&page=3
    √ ./archive/1576899114
      > readability
    ! Failed to archive link: Exception: Exception in archive_methods.save_readability(Link(url=https://forums.nasioc.com/forums/showthread.php?t=2803387&highlight=big+brother&page=3))

Traceback (most recent call last):
  File "/app/archivebox/extractors/__init__.py", line 91, in archive_link
    result = method_function(link=link, out_dir=out_dir)
  File "/app/archivebox/util.py", line 111, in typechecked_function
    return func(*args, **kwargs)
  File "/app/archivebox/extractors/readability.py", line 109, in save_readability
    cmd=cmd,
UnboundLocalError: local variable 'cmd' referenced before assignment

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/bin/archivebox", line 33, in <module>
    sys.exit(load_entry_point('archivebox', 'console_scripts', 'archivebox')())
  File "/app/archivebox/cli/__init__.py", line 122, in main
    run_subcommand(
  File "/app/archivebox/cli/__init__.py", line 62, in run_subcommand
    module.main(args=subcommand_args, stdin=stdin, pwd=pwd)    # type: ignore
  File "/app/archivebox/cli/archivebox_add.py", line 78, in main
    add(
  File "/app/archivebox/util.py", line 111, in typechecked_function
    return func(*args, **kwargs)
  File "/app/archivebox/main.py", line 572, in add
    archive_links(all_links, overwrite=overwrite, out_dir=out_dir)
  File "/app/archivebox/util.py", line 111, in typechecked_function
    return func(*args, **kwargs)
  File "/app/archivebox/extractors/__init__.py", line 150, in archive_links
    archive_link(link, overwrite=overwrite, methods=methods, out_dir=link.link_dir)
  File "/app/archivebox/util.py", line 111, in typechecked_function
    return func(*args, **kwargs)
  File "/app/archivebox/extractors/__init__.py", line 101, in archive_link
    raise Exception('Exception in archive_methods.save_{}(Link(url={}))'.format(
Exception: Exception in archive_methods.save_readability(Link(url=https://forums.nasioc.com/forums/showthread.php?t=2803387&highlight=big+brother&page=3))

This is with Docker image nikisweeting/archivebox:0.4.21

Thanks for the report. I will check it.

@jrruethe I sent a PR. A new version with the fix should come out next week. You can try the fix by using that branch directly for now.

Thank you very much!

This should be fixed now on master. If you still encounter any issues comment back here and I'll reopen the ticket.
To use master immediately without waiting for the next release you can build it directly from Github:
docker build 'https://github.com/pirate/ArchiveBox.git#master' -t archivebox
docker run -v $PWD:/data archivebox update


billing for one metrics

@vijaykanthm28  Please close the comments before we merge.

@vijaykanthm28  Good job in hacking it so fast. !


Reworked config resource for hab 0.56 compatability

Description
Reworked config resource for hab 0.56 compatability
This breaks out the refactor from #115
Issues Resolved
This closes #106
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Rebased to pull in changes from master.

Fantastic thank you! Will get this reviewed.


Allow some PMCs to allocate a CVE name

Use the NEW button or replace with ALLOCATE CVE like our current security one.
Set the year, only allow one CVE, selection box for PMC

if not allowed perhaps it just sends the request to<EMAIL_ADDRESS>

Implemented and live.


IconDescription on Button is not displayed on MS Edge

IconDescription on Button is not displayed on MS Edge
IconDescription on Button is been displayed as tooltip on chrome and firefox but not on MS Edge
<Button
small
kind="ghost"
iconDescription={formatMessage(messages.downloadCsv)}
href={/ibm/iis/dq/da/rest/v1/workspaces/${workspaceId}/dataSets/${datasetId}/dataClasses/selected?format=csv}
icon="icon--download"
id="download.dataclasses.selected"
key="button_download.dataclasses.selected">

firefox:

MS Edge:

hi @wschue thanks for reporting this! I believe this is an unresolved issue with Edge, but do you have an example of the SVG <title> element properly working in Edge?


Replace viper with alternative in configvalidator package

We are using viper in configvalidator package for the deepsource config validate command to read the .deepsource.toml config which is to be validated.
Viper can be replaced here with other libraries which have a lower size footprint and are focused only on reading TOML files.
Files where viper is used:

https://github.com/deepsourcelabs/cli/blob/master/configvalidator/config_validator.go
https://github.com/deepsourcelabs/cli/blob/master/configvalidator/generic_config_validator.go

Can I work on this issue?
viper can be replaced with pelletier/go-toml. In fact, viper uses that internally for toml files. Open to discussing other alternatives as well.


Feature/advancedtests

Codecov Report

:exclamation: No coverage uploaded for pull request base (patch/quotamessage@66d4c2f). Click here to learn what that means.
The diff coverage is 100%.

@@                Coverage Diff                 @@
##             patch/quotamessage    #7   +/-   ##
==================================================
  Coverage                      ?   75%
==================================================
  Files                         ?     3
  Lines                         ?   140
  Branches                      ?    38
==================================================
  Hits                          ?   105
  Misses                        ?    35
  Partials                      ?     0

Impacted Files
Coverage Δ

src/components/Map.ts
72.44% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d4c2f...df21162. Read the comment docs.


rally Dockerfile does not take effect from committed change

Problem description: if a commit change anything in rally-ovs, the rally Dockerfile can not receive the new update. This is because rally Dockerfile clones the repo form upstream.
Then a following PR is needed to fix this issue, e.g., #53 .
One possible solution is to generate Dockerfile dynamically, using jinja2 tempate.

@huikang Is this still relevant now that #53 has merged?

@mestery Yes, this is because rally Dockerfile contains the link to this ovn-scale-test repo. We should fix this later.
But, lets keep this as an open issue so it will not get lost. Thanks.

Lets keep this issue open for some time to ensure it works for everyone


openXC7 - no Bels remaining of type 'BUFR'

When using openXC7 (place and route step) we get an error in BUFR module, 'u_csi_rx_top.u_phy_clk.u_bufr' to be specific.
The message we received is:
ERROR: Unable to place cell 'u_csi_rx_top.u_phy_clk.u_bufr', no Bels remaining of type 'BUFR' 2 warnings, 1 error make: *** [Makefile:53: top.fasm] Error 255
This error arises from attempting to resolve this issue. We have now replaced BUFMR with BUFR, and the design was successfully tested in Vivado. @hansfbaier, @MikeReznikov Are there any indications on how we can put an end to this problem?

Even if BUFMR and BUFR are internally the same component, they externally have different features, different look-and-feel, and are also treated separately in the corresponding vendor documentation.
We therefore want to track them as two separate, distinct issues.

@AdamLee7 send us the PR link or the branch link when you finish please :)

@AdamLee7 are there any news?

@kerimbavcic The primitives-fixes branch has the BUFR support by @AdamLee7 already integrated.
But we need to test this branch more before merging, especially the LUTRAM changes there.

@kerimbavcic The primitives-fixes branch has the BUFR support by @AdamLee7 already integrated, if I am not mistaken.
But we need to test this branch more before merging, especially the LUTRAM changes there.


Version size in specification wrong

binary format specification
shows a two byte version, but version is stored as four bytes.

Ups... sorry. Updated spec to avoid breaking changes. Now 4 bytes, as in binary writer.
Thank you for report.


[IMPROVEMENT] List of Longhorn Helm Chart Flags

Is your improvement request related to a feature? Please describe (👍 if you like this request)
Difficult to easily view a list of all possible helm chart flags. Of course, you are able to manually determine these using the helm chart values, but like other rancher products, there usually is a list of the flags within the docs or chart readme.
Describe the solution you'd like
Add the list of helm chart flags to the longhorn docs and helm chart readme.
Describe alternatives you've considered
Current alternative to this feature improvement request is to manually go through the helm chart values file to determine to helm install flags.
Additional context
I'd be will to submit a draft of these changes/additions. No other additional context to provide to this request!

Yes, the helm values. Most helm chart repos have the values represented in a table within the readme. You are correct, you're able to view the values.yaml, but having the values in documentation.
It would be nice to have it implemented for longhorn to match the rest of the rancher products (MCM, NV, RKE2, etc..)

Hey @innobead / @ChanYiLin, are we still on track to complete this in the Longhorn v1.6.0 release?

Hi @zackbradys
Yes, this feature request will be in Longhorn v1.6.0 which will be released in December.


Get the urls in the PrismJS formatted code to be clickable links

completed a while ago. Forgot to update this.


[CI:DOCS] Fix passing secret env. vars. into podman

Fix issue introduced in https://github.com/containers/automation_images/pull/171
At the time of this commit, the default github-action runners are using
an ancient version of podman.  This version does not support using the
-e ENVAR feature to slurp up env. var values from the environment.
They must be set on the command-line.

No way to test this other than from the 'main' branch :angry:

Manually triggered: https://github.com/containers/automation_images/actions/runs/2883934131


sccache integration not resulting in any cache hits

Running the latest rust/cargo and sccache, with RUSTC_WRAPPER  set correctly, sccache is invoked but does not seem to ever cache anything.
Originally being tracked here: https://github.com/rust-lang/cargo/issues/4307#issuecomment-323127428
sccache.txt

cc @luser and thank you

That log says it's running sccache 0.2.1, which is missing this fix: https://github.com/mozilla/sccache/commit/2d9bdc1e8fb1fa5a531da2930670bbfcb66f78a0 , which definitely was an issue on some platforms.
Is this just the build log from setting RUST_LOG=sccache=trace? To get the log output from the server you also need to set SCCACHE_ERROR_LOG=/path/to/log.

Is this fixed? Can this be closed?

Sounds good to me!


Update and kustomize csi-azuredisk addon

What this PR does / why we need it:
Seems like previous version had a bug that prevented it to read cloud-config from the configured secret, now with the update it's fixed.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?
/kind chore
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Update and kustomize csi-azuredisk addon

Documentation:

NONE

/test pull-kubeone-e2e-azure-default-install-containerd-external-v1.29.2

/cc @xmudrii


DEVGUIDE is stale

Not sure what else is old but just dir map at the top isn't right - we don't have a "deploy" dir at the top level.
Let's use this issue to walk thru the entire thing to make sure its all in-sync.
Marking this as MVP-2 since this will impact newbies coming in.

Fix coming for this.


Implement example test code

Support operating in test mode

Add test routines to the code for automated robot testing of the various mechanisms and commands.


Update nunjucks version

It's currently at 2.4.2, so we're a bit behind. I'll have a look at it in the near future if it's interesting :)

Seems like everything still works fine after updating to 2.4.2, ie. things run and the templates are being compiled.

Yeah, I'm planning to update the package and release this weekend, thanks for heads up.


Do not require @NoRefactor for hints that don't support refactoring

The goals are (1) document exactly which hints don't support refactoring, and (2) no longer require @NoRefactor for those hints (which is the vast majority of @NoRefactor); use @NoRefactor only for other issues like bugs.
If a test case has a hint where ideaRefactorings = [], the hint must be added to the list of hints that don't support refactorings, and no @NoRefactoring is required (I would also like to check the other direction, namely every hint in the list indeed has an empty ideaRefactoring, but this is currently not possible since some hints such as "Redundant return" sometimes support refactoring and sometimes don't).
This uncovers two previously unknown hlint refactoring bugs and one apply-refact bug.

I'm not a massive fan of centralising a list of all the names that don't support refactoring. We've been fairly lose with the names and not assigning them much identity thus-far, and that gives us a certain level of freedom we lose with this patch. Isn't null . ideaRefactoring enough of a hint that in this case the hint isn't supported by this hint?
Looking at the type, why is ideaRefactoring a list and not a Maybe? I wouldn't be averse to making it a type:
data Refactor = Refactor (Refactoring R.SrcSpan) | NoRefactor

And then if what you're looking to do is grep for no refactorings you could grep for NoRefactor?

I think the general goal of using @NoRefactor type annotations for bugs rather than not-yet-implemented is a good one.

Adding a NoRefactor constructor sounds good to me.

Looking at the type, why is ideaRefactoring a list and not a Maybe?

Some hints require more than one Refactorings, for example
import A (foo)
import A (bar)
import A (baz)

requires one Replace and two Deletes. In this particular case it may be possible to use a single Refactoring, but I imagine in some cases you may want to change both an expression and a type, and that definitely needs two Refactorings.

OK, cool, that makes a lot of sense why its a list.

@ndmitchell It occurred to me that we don't really have much freedom with hint names anyway, since hint names are needed in order to enable and disable hints, and so changing a name could break many people's .hlint.yaml.
Given that circumstance, it seems reasonable to put the names of all hints that don't support refactoring in one place, which is convenient as a quick reference. What do you think?

I'm reminded that a feature request comes my way every so often for the ability to "list all hints". Perhaps together with this  we might implement an option to generate a report detailing hints, enabled/disabled status, refactor capable and whatever else we can think of?

@shayne-fletcher very good point. I only recently became aware of the "Use module export list" hint (disabled by default). I had no idea before that it existed.
One option is to generate the list of hints when running tests, provided each hint has at least one test case. We can even include an example for each hint, which can be the first test case for that hint.

I tried generating a summary of builtin hints as a side effect of running the tests, which looks like
* Hint: Avoid lambda (Suggestion)
  Sample input:
    f = foo (\y -> g x . h $ y)
  Found:
    \ y -> g x . h $ y
  Perhaps:
    g x . h
  Support refactoring: Sometimes

* Hint: Avoid lambda (Warning)
  Sample input:
    f = foo (\x y -> fun x y)
  Found:
    \ x y -> fun x y
  Perhaps:
    fun
  Support refactoring: Sometimes

* Hint: Avoid lambda using `infix` (Suggestion)
  Sample input:
    foo x = bar (\ d -> search d table)
  Found:
    (\ d -> search d table)
  Perhaps:
    (`search` table)
  Support refactoring: Yes

* Hint: Avoid restricted function (Warning)
  Sample input:
    foo = unsafePerformIO
  Found:
    unsafePerformIO
  Perhaps:
  Support refactoring: No

* Hint: Collapse lambdas (Suggestion)
  Sample input:
    f = foo (\x -> \y -> x x y y)
  Found:
    \ x -> \ y -> x x y y
  Perhaps:
    \ x y -> x x y y
  Support refactoring: Yes

* Hint: Eta reduce (Warning)
  Sample input:
    fun x y z = f x y z
  Found:
    fun x y z = f x y z
  Perhaps:
    fun = f
  Support refactoring: No

...

To make sure this is up to date, we can fail the test if the output is different from the existing summary, and add a --fix-summary flag to overwrite it.

That's awesome @zliu41! How about generating in markup or html and then we could probably arrange for a link to it from the README? Perhaps generating an index for it along the way?

Awesome. I think that will be an easy way to get what everyone wants! My suggestion would be we add --generate-summary flag to hlint test and make it write to a file. We check that file into the repo, which means we can serve it up as a web page on GitHub. Given that GitHub doesn't like serving up HTML that much, it suggests a .md file might be the best choice.
If we check that file into the repo, and regenerate it during the test, then if the file changes it will fail CI anyway. That way we'll have a test.

Really looking forward to seeing this @zliu41 !

SGTM! Will open another PR.


"Problems using OpenRefine? Get help!" functionality

When interacting with other OpenRefine users, I repeatedly get into this process:

Confused OpenRefine user (not me) gets into trouble somewhere and has questions
OpenRefine user contacts me personally, or posts in a DM channel that I follow
In order to better understand the problem, I explain to the user the convoluted (and for end users burdensome) process of making their OpenRefine log visible (requires gymnastics with right-clicking and the Terminal for Mac users), copying the log, and posting the problem (including log) somewhere more visible so that more people can jump in and help (+ learn from the issue and potentially improve OpenRefine!). I usually also ask the confused OpenRefine user to attach the project they are working on (if OK re: privacy of the data), so that helpers can investigate the issue more closely.

Now that OpenRefine has a web-based forum, I want to introduce the suggestion to vastly streamline this process and make it more guided and friendly for the confused user.
My suggestion would be something along these lines:

Have a prominent link somewhere in OpenRefine's interface that is always visible and accessible (top bar on the right, next to permalink or left of Open / Export / Help buttons? Replacing Help button with something more prominent?). Link can say something like "Problems using OpenRefine? Get help!" - I'd go for something more prominent than a simple Help link or button.
Upon clicking link, user gets dialogs a bit like this clunky picture:

I can imagine the input would arrive in a dedicated subcategory on the forum, e.g. https://forum.openrefine.org/c/support/requests-from-the-application/ or similar.

Other option(s) considered:

Directing users immediately here to GitHub. IMO the forum is friendlier for non-technical users, and quite a few questions will not really correspond to GitHub issues per se.
Directing such requests to another platform (I recall @wetneb mentioned one that Gephi uses, a dedicated platform for this purpose, can't recall the name). I'm not super in favor of this: yet another platform to manage; requests on OpenRefine's forum will be more visible and actionable for more people; questions and answers will end up in the growing organic knowledge base of OpenRefine's forum and mailing list archives.

Having a clear way of reporting issues with a good set of minimal information would be good, but I don't know if there are barriers to what is specifically suggested here:

Slightly wary of hard coding a link into the application (if we change practice that could be a broken link in older versions of the software)
Is the suggestion this would include the log that is accessible via the terminal or is the "technical log" mentioned the operation history?
I don't think it is true that either the application log or the operation history is necessarily free from details of the data - some errors put data in the application log, and the operation history definitely includes information about the data in that it can contain column names, conditional tests, facet values, updated values etc. etc.

Thanks Owen, all these comments make a lot of sense.

Is the suggestion this would include the log that is accessible via the terminal or is the "technical log" mentioned the operation history?

I indeed meant the log that is accessible via the terminal (this is the one I ask users to retrieve and then paste as they report an issue), but if another type of log is (equally or more) helpful, that would make sense too.
I'm definitely not fully aware of all privacy and data exposure potential everywhere in OR, and I fully agree we need to be careful with that if such a feature would be implemented.

Thanks Sandra for this bold (in a good sense) and clear feature request!

It's first of all selfish! I'm occasionally showered by requests for help, and overwhelmed. That said, I hope this will benefit the OpenRefine community at large, by making requests for help more visible and allowing more people to participate in the project by helping others.
In general, I'm fine with either mechanism you choose. The most important things (tl;dr's) for me are:

Make it very discoverable in the application itself that the user can do this. (Until filing this issue, I had actually never clicked the 'Help' button in the interface, because I just never even noticed it! And it's vague.)
Make the process easy (as easy as possible) for any OR user.
Remove the hurdles for attaching the Terminal log and the project tarball, but also make it easy for the user to review if there's no sensitive info in there.
Make the request for help visible for, and actionable by many people. I still think it'd be great that the request ends up on the forum somewhere.


[BUG] S3 source csv codec parsing

Describe the bug
S3 source with csv codec is not paring the csv file accurately. It appends an additional space before the first key.
To Reproduce
Steps to reproduce the behavior:

create pipeline with S3 source and csv codec
ingest some csv data

Pipeline config:
log-pipeline:
  source:
    s3:
      notification_type: "sqs"
      compression: none
      codec:
        csv:
      sqs:
        queue_url: "https://sqs.us-east-1.amazonaws.com/<account-id>/<queue-name>"
      aws:
        region: "us-east-1"
        sts_role_arn: "arn:aws:iam::<account-id>:role/<role>"
      on_error: "retain_messages"

  processor:
    - date:
        from_time_received: true
        destination: "@timestamp"
   - delete_entries:
       with_keys: ["col1"]

  sink:
    - stdout:

Input:
col1,col2
a,101
b,102

Output:
{" col1":"a","col2":"101","s3":{"bucket":"bucket-name","key":"Book1.csv"},"@timestamp":"2023-04-10T14:48:53.411-05:00"}
{" col1":"b","col2":"102","s3":{"bucket":"bucket-name","key":"Book1.csv"},"@timestamp":"2023-04-10T14:48:53.580-05:00"}

Expected behavior

There shouldn't be a space before col1 in above output and delete_entries should delete the key.

Update: This failure is only occurring when CSV file is created using Excel and saved with UTF-8 encoded.


Why does this uses Locator from playwright, instead of using Locator from @playwright/test?

By using Locator from playwright instead of playwright/test, we cannot actually use the xPath call.

can you please explain better?

import { xPath } from "playwright-dompath";
import { test } from '@playwright/test';
test('xpath test', async ({ page }) => {
const statusHeader = page.locator('//table')
const statusXpath = await xPath(statusHeader)
})


Webpack@4 is not tree shaking a file exporting SVGs (font-awesome@5)

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
webpack@4 can't tree shaking the @fortawesome/fontawesome-free-solid, even when I change their<EMAIL_ADDRESS>adding the "sideEffects": false.
I have following this issue https://github.com/FortAwesome/react-fontawesome/issues/70 making several tests but we can't find a solution.
Maybe you can help to the FortAwesome's team to reach a solution.
If the current behavior is a bug, please provide the steps to reproduce.
You can check the bug yourself using this repo: https://github.com/navarroaxel/fa-bundle-bug

What is the expected behavior?
webpack should optimize the @fortawesome/fontawesome-free-solid library exporting only one icon.
If this is a feature request, what is motivation or use case for changing the behavior?
N/A
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
node@6 or node@8
webpack@3 or webpack@4
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>OS: Ubuntu 17.10

This is not a webpack bug. Packages must be designed with tree shaking in mind. If they have function calls with side effects then code must be retained in the event it is used.
I am not a fan of debugging commercial software, but if you look at<EMAIL_ADDRESS>this line of code prevents unused definitions from being dropped:
  define('fas', icons$1);

If it is commented out then the final bundle will be 300K smaller.

Thanks a lot for the solution @kzc !

The package @fortawesome/fontawesome-free-solid belongs to the Font Awesome 5.0.x line. It is known not to facilitate tree-shaking for the reason @kzc specified. In that version, you can, however, configure it for tree-shaking, but it requires configuring webpack to use shakable.es.js instead of index.es.js. See documentation here.
In Font Awesome 5.1 (in preview currently), the equivalent package is called @fortawesome/free-solid-svg-icons. It is designed with tree-shaking in mind, without any additional configuration. Documentation here.


Added Jefferson County High School

Requesting to add Jefferson County High School.

@johnrtipton I am sorry. There are many schools with the similar names.
Please provide us with:

the school official website URL
the school's street address (including country)
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@johnrtipton You might miss my previous comment. Please react.

Sorry for the delay.
Website URL: https://jchs.jc-tn.net/
Address: 115 West Dumplin Valley Road Dandridge, TN 37725
Proof of IT-Related courses
https://jeffcoschool.sharepoint.com/sites/jcspublic/Documents/Forms/AllItems.aspx?id=%2Fsites%2Fjcspublic%2FDocuments%2FJCS Public%2FSchool Specific%2FJefferson County High School%2F2019-2020_JCHS_Curriculum_Guide_2019_-_2020.pdf&parent=%2Fsites%2Fjcspublic%2FDocuments%2FJCS Public%2FSchool Specific%2FJefferson County High School&p=true&originalPath=aHR0cHM6Ly9qZWZmY29zY2hvb2wuc2hhcmVwb2ludC5jb20vOmI6L3MvamNzcHVibGljL0VlZF81czJfZTVSS3U2amlqd0d3NnpBQlh0MmR3TGs4UXhQdXk5Z012SENuR3c_cnRpbWU9Q0lNc21EUkYyRWc

6144 STEM I:  Foundations6145 STEM II:  Applications –or-3634 AP Computer Science Principles6146 STEM III:  STEM in Context –or-3634 AP Computer Science Principles6147 STEM IV:  STEM Practicum and/or 3127 AP Calculus AB, and/or 3128 AP Calculus BC, or 3635 AP Computer Science A, or 3117 AP Biology, or 3225 AP Chemistry, or 3238AP Physics 1, AP Physics II 3239, AP Physics C: 3234, or 3240 AP Physics*Industry Certification: Certified Solidworks Associate (CSWA)-Academic**Anticipated CertificationsPMI

Proof that the school recognizes the domain for studentes:
https://jeffcoschool.sharepoint.com/sites/jcspublic/Documents/Forms/AllItems.aspx?q=jcboe.net&originalPath=aHR0cHM6Ly9qZWZmY29zY2hvb2wuc2hhcmVwb2ludC5jb20vOmY6L3MvamNzcHVibGljL0VpM0NvNC1uZ250RWxYNXcwTlJmREVJQlR2UlVSa2c2SFlDN1piQkFjemdJM0E_cnRpbWU9XzlhMU9UUkYyRWc&id=%2Fsites%2Fjcspublic%2FDocuments%2FJCS Public%2FSchool Specific%2FJefferson County High School%2F2019-2020 Course Syllabi%2F9th World History and Geography 2019 -2020.pdf&parent=%2Fsites%2Fjcspublic%2FDocuments%2FJCS Public%2FSchool Specific%2FJefferson County High School%2F2019-2020 Course Syllabi&parentview=7


[HOLD for payment 2023-10-12] [$500] Payment for reporting bug

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Bug reported here https://github.com/Expensify/App/issues/28497#issuecomment-1743316807
Created this issue to track the payment
Action Performed:
Break down in numbered steps
Expected Result:
Describe what you think should've happened
Actual Result:
Describe what actually happened
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @Talha345
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0107325e5eda525931
Upwork Job ID:<PHONE_NUMBER>171786752
Last Price Increase: 2023-10-03

@zanyrenney Can you please help pay @Talha345 for reporting this bug

@zanyrenney Hi, this task was created to make the payment for a bug I reported! Can you kindly process it?

Sure thing, the payment was only due today, hence me waiting for the date of 12th October.

@Talha345 have invited you to the job on upwork, please reply :)

@Talha345 have invited you to the job on upwork, please reply :)

@zanyrenney proposal submitted to job!

brilliant, @Talha345 - offer sent!

still waiting on @Talha345

still waiting on @Talha345

@zanyrenney accepted offer!

summary of payments:
$50 to @Talha345


Add documentation for using Python packages

This PR has documentation for including Python packages with ROS2, including how to

add packages using rosdep
use a package manager
use a virtual environment

@mergifyio backport rolling foxy


etcd (ticdc): fix cdc cluster has two owner at the same time

What problem does this PR solve?

Issue Number: close #4051
What is changed and how it works?
Add a checking logic inside EtcdWorker, which will check the owner key of an owner Reactor before Tick it, if we found its owner key has gone, return the EtcdWorker loop and the capture would not exit and work as a processor.
Check List
Tests

Integration test
Manual test (add detailed scripts or steps below)
The reproduce steps was articulated in #4051

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Fix a bug that can cause one TiCDC cluster has two owner at the same time. (when we delete the owner key by etcdctl directly).

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

Codecov Report

Merging #7222 (2a05d02) into master (d8fff7a) will decrease coverage by 0.0320%.
The diff coverage is 67.8787%.

Additional details and impacted files

Flag
Coverage Δ

cdc
67.1517% <62.0370%> (-0.0638%)
:arrow_down:

dm
51.7997% <ø> (-0.0378%)
:arrow_down:

engine
60.9104% <70.7207%> (+0.0523%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #7222        +/-   ##
================================================
- Coverage   59.6043%   59.5723%   -0.0321%
================================================
  Files           790        790
  Lines         91089      91195       +106
================================================
+ Hits          54293      54327        +34
- Misses        32051      32110        +59
- Partials       4745       4758        +13

/merge

/merge

/merge

/run-all-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/merge

/run-all-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-all-tests

/run-integration-test

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

The merge_region integration test always fails, can't find the reason.


Question

Looke interesting, but i dont see any integration between front end to fastapi,are u planning to continue working on this ?

You can call the endpoints from FastAPI in the front end.
You can work separately on the frontend and the backend. When you are ready with the front end generate the dist folder and place it in the backend. You can let FastAPI to deliver the static files.
Now I'm working on a task queue alternative to redis RQ (checkout kerground). I'm planning to make this boilerplate production ready, but I didn't set a deadline.

Thanks @ClimenteA , i think such idea could be really good starting points for beginners , but i guess it required more information ,especially for "how to" start building a project with fastapi/Vue.


Make the LegendItems property of a legend public

Features Suggestion
Currently, if one wants to get the bitmap to a legend with e.g
var legend = FormsPlot.Plot.Legend();
var picture = legend.GetBitmap();

This call returns an error if no plot has a label.
However, there is no way to actually know the number of items in the legend as this property is private.
https://github.com/ScottPlot/ScottPlot/blob/a214b94102c107db3799197655b5255c464c7eda/src/ScottPlot/Renderable/Legend.cs#L166
One could think of two solutions :

Either not return an error in case the legend is empty but return a null or an equivalent
Or make the LegendItems list public so that one can check its length prior GetLegendBitmap()

Side note : Wouldn't it be relevant to switch from an LegendItem[] array to a List<LegendItem> as there is intrinsically variable amount of plots in a ScottPlot ?

This call returns an error if no plot has a label.

Technically it returns a descriptive exception...
System.InvalidOperationException : The legend is empty (there are no visible plot objects with a label)

...but I agree this may be overkill! Returning a null Bitmap may make more sense than a hard exception.

However, there is no way to actually know the number of items in the legend as this property is private.

Fair point! I'll expose LegendItems as you suggest

Wouldn't it be relevant to switch from an LegendItem[] array to a List

The reason I don't love the idea of List is because I don't want users to accidentally think they can get the list and .Add() to it on their own. Good line of thinking though!
In the case there are no items in the legend I'll set LegendItems to an empty array instead of null... and also add a Count field.
I'll make these changes in #1580 and check-in with you for your thoughts/input before I merge! 👍 🚀

[when requesting the legend bitmap if there are no legend items] returning a null Bitmap may make more sense than a hard exception.

Oof, that isn't good because peoples' next line is often bmp.Save() which then throws an exception
I could return a 1x1 transparent Bitmap if there are no plottables in the legend 🤷
None of these options feel great

I'll make these changes in #1580 and check-in with you for your thoughts/input before I merge! 👍 🚀

This is what I came up with. What do you think?
Bitmap bmp = plt.RenderLegend(); // never throws or returns null if legend is empty
bool has = plt.Legend().HasItems;
int cnt = plt.Legend().Count;
LegendItem[] = plt.Legend().GetItems();

Technically it returns a descriptive exception...
I'm not a big fan of putting everything into Try blocks so for me it is pretty much the same !

...but I agree this may be overkill! Returning a null Bitmap may make more sense than a hard exception.

Yes, If there is no label, the legend is empty, but that really should not return an exception.

The reason I don't love the idea of List is because I don't want users to accidentally think they can get the list and .Add() to it on their own. Good line of thinking though!

Isn't it possible to make it readonly ? So that once it is created one cannot modify the array ?

In the case there are no items in the legend I'll set LegendItems to an empty array instead of null... and also add a Count field.

That would be my line of thinking too 👍. Are you sure the Count field is required ? As the array already has a Length ?

@swharden A side note to this specific property, I feel like the GetDraggableUnderMouse could be great to have as public too, don't you think ? For instance it is crucial if you want to be able to remove a Vline with some user action.

Isn't it possible to make it readonly ? So that once it is created one cannot modify the array ?

I could return a ImmutableList<LegendItem> that would prevent the user from being able to add/clear it, but that's a bit of a weird data type and returning LegendItem[] achieves the same goal.

I feel like the GetDraggableUnderMouse could be great to have as public too

This is an interesting point. I could move it from the control backend to the Plot module and make it public. I'll try this, and if it looks good I'll merge this in tonight!

I feel like the GetDraggableUnderMouse could be great to have as public too

This now lives in the Plot module - thanks for the suggestion!
https://github.com/ScottPlot/ScottPlot/blob/6f56261a3837f6f925fdac7726c13a78e938eefe/src/ScottPlot/Plot/Plot.cs#L152-L179


trying to set a full VGG16 model to trainable = False

I'm trying to set a VGG16 model so that all of the layers cannot train... but when I do this

	@staticmethod
	def build_object_branch (inputs):

		base_model = VGG16(weights='imagenet', include_top=True, input_shape=(224, 224, 3))(inputs)

		for layer in base_model.layers:
			layer.trainable = False

		model = Model(inputs, base_model)

		return model

I get the error
   for layer in base_model.layers:
AttributeError: 'Tensor' object has no attribute 'layers'

I've copied the code from the Keras documentation, however, I wondered if this is due to 1) that I'm using the whole model and not just the top. Or 2) that the VGG16 model is part of a larger network.... but I'm unsure.
It runs fine if I let the model's layers stay on trainable, but produces this error when I try to change them to untrainable
Any help would be massively appreciated.

I fixed it, I was being dumb. this is what I think it should look like
		base_model = VGG16(weights='imagenet', include_top=True, input_shape=(224, 224, 3))

		for layer in base_model.layers:
			layer.trainable = False

		x = base_model (inputs)

		model = Model(inputs, x)

		return model

@georgeparry12
Moving this issue to closed status as there has been no activity, in case you still face the error please create a new issue.


Numeric pop

...I was convinced that you could pop multiple states, but that doesn't appear to currently be the case.
{match: 'foo', pop: 2}

Is this useful, or should I amend the documentation to make clear you can't?

I was initially going to allow this, but I couldn't think of any reasonable use cases.

Perhaps only disallow numbers that aren't 1? Some people like to use {flag: 1} in object literals because it's short and truthy.

Okay! 7641fd1


HDDS-1701. Move dockerbin script to libexec.

What changes were proposed in this pull request?
Relocate the docker scripts in dist.
(from bin/docker/ to libexec/)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-1701
How was this patch tested?
Ran test-all.sh under $OZONE_HOME/compose/ in distribution.

/retest

When test-all.sh is ran in distribution, it works well.
But when it called by acceptance.sh, it fails.
We are looking for the cause.

Seems to be working for me even with acceptance.sh. Let's try to retest.

/retest

No idea what's wrong here, but I am not brave enough to commit it without understanding the reason of the acceptance test failure.
Let me try to find the root cause...

No idea what's wrong here, but I am not brave enough to commit it without understanding the reason of the acceptance test failure.
Let me try to find the root cause...

Yes, thanks @elek for the review.
We're going to find the root cause.

Ok. I found the problem. The changed Dockerfile is used only to create images for k8s deployment.
To change the PATH in the ozone-runner image, a new PR should be created in hadoop-ozone-docker repository (ozone-runner branch):
https://github.com/apache/hadoop-docker-ozone/tree/runner-latest
Can you please create a new PR in that repository (with the same jira id) with adding the new path to this line:
https://github.com/apache/hadoop-docker-ozone/blob/7619b7b7d1cc27629292f959d082c01e23ae8870/Dockerfile#L39
I will commit it + tag it --> It will create a new apache/ozone-runner image which can be used by updating hadoop-ozone/dist/pom.xml  (docker.ozone-runner.version)

Wow, thanks @elek for the comment.
This comment help me a lot.
Fixed and send a PR in apache/hadoop-docker-ozone.

New ozone-runner is available: apache/ozone-runner:20191107-1  You can update the version in hadoop-ozone/dist/pom.xml
<docker.ozone-runner.version>20191106-1</docker.ozone-runner.version>

And (hopefully) the acceptance tests will be passed and ready to merge.

Thanks @elek for all the help and reviews.


modified: chapter_attention-mechanisms/attention-cues.md

Job d2l-zh/PR-641/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/

Job d2l-zh/PR-641/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/

Job d2l-zh/PR-641/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/

Job d2l-zh/PR-641/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/

Job d2l-zh/PR-641/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/

Job d2l-zh/PR-641/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/

Job d2l-zh/PR-641/4 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/

Job d2l-zh/PR-641/7 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/

Job d2l-zh/PR-641/8 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-641/


Fix problem discovered in #52.

Codecov Report

Merging #53 (5d2efeb) into master (9f280a2) will increase coverage by 0.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   81.88%   82.56%   +0.67%
==========================================
  Files          20       20
  Lines        3644     3785     +141
==========================================
+ Hits         2984     3125     +141
  Misses        660      660

Impacted Files
Coverage Δ

src/dirgraphsvg/graph.rs
87.11% <100.00%> (ø)

src/gsn/check.rs
100.00% <100.00%> (ø)

src/gsn/mod.rs
73.91% <100.00%> (+0.16%)
:arrow_up:

src/gsn/validation.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f280a2...5d2efeb. Read the comment docs.


Add high-level helpers for using Musig2 with Taproot

When using Musig2 for a taproot key path, we can provide simpler helper functions to collaboratively build a shared signature for the spending transaction. Those helper functions hide the low-level details of using an opaque key aggregation cache or signing session. This comes with a small performance penalty, as we recompute the key aggregation cache.
We also document the exposed APIs, import more tests from the official test vectors, and make APIs safe: they should never throw exceptions, except when invalid public keys are provided as inputs (which should be verified by the caller beforehand).
I removed the musig2 prototype as I don't see any valid reason to keep it: it doesn't even have the same API as the official implementation anymore so it's rather confusing, and can be found in the git history if necessary.
This is a PR targeting #107

I'm not convinced that it makes the code that uses musig2 simpler or more compact. For now, this code is encapsulated in specific swap-in protocol objects (for both lightning-kmp and eclair), this is where we can hide musig2 complexity from the rest of the codebase.

I really don't understand how you can't be convinced. We're now exposing an API that makes it trivial to spend any output that uses musig2 for its key path with any script tree, without having to know or care about low-level musig2 details (key aggregation cache and opaque session data). That's exactly the abstraction that every use-case of musig2 needs? So instead of duplicating this code in lightning-kmp and eclair, we now have a single abstraction in bitcoin-kmp that we can easily use for both swap-in-potentiam, taproot channels and PTLCs.
The musig2 complexity should be hidden in bitcoin-kmp as much as possible, otherwise we're not providing any useful abstraction and multiple users of bitcoin-kmp will have to write the same code many times.

Also, the really tricky part imho (same with singing regular transaction inputs) is how to properly set up a musig2 signing session and this requires users to pass the right transaction, index, nonces etc... and it can't really be made simpler.

I don't understand what you mean: a signer only has to generate his secret nonce, receive public nonces from other participants, and then the existing functions make it trivial to spend the utxos. I believe the swap-in-potentiam unit test showcases that pretty well?


FR: compact and better timer list

(This is a somewhat of a followup to https://github.com/BlackyHawky/Clock/issues/7)
Is your feature request related to a problem? Please describe.
It would be great if list of the Timers were more compact.
Describe the solution you'd like
I would imagine that a list of stopped/inactive timers could be done as just timer name + timer value without the circle.
Once the timer is started it would (optionally) switch to expanded view with the elapsed time circle.
Additional benefit would be better way to distinguish which timer is started and stopped.
Also, maybe started timers could be placed on the top of the list?

@woj-tek: Can you try the attached apk and give me your opinion please?
Please note:

only phones in portrait mode are affected;
started timers are not placed at the top of the list (maybe this will be done in another commit);

Clock_2.2-debug.zip

Looks awesome! <3

I'm glad you like it, especially since I like it too. 😉

Btw. would it be possible to make taping on the timer (the circle) pause/start the timer?

Please open another issue because I'm going to close this one and I'd rather have one enhancement or issue per topic.

Btw. would it be possible to make taping on the timer (the circle) pause/start the timer?

Done with commit 4d0219c8

@woj-tek
You were right to put your comment here because I won't accept your request.
Indeed, if you don't use the labels, it doesn't mean that nobody else does.

When you say "to be honest simple line with "duration + " would be more than enough" this means that people who use labels will no longer be able to benefit from this feature.
So what I wanted to say is that you need to think about all users before making a change like this.

I still have the feeling that you're only making this request because you don't use labels... 🤔
In German there are some very long words; I don't want these words to be truncated just because the reduced timer has to be on a single line.
Furthermore, to delete a timer item, I absolutely do not want to perform a long press.
Previously, this was the case for deleting a custom ringtone, and it was really annoying.
Put yourself in the shoes of someone who doesn't know the application; the first question he'll ask himself when he adds an item is "how do I delete it? ".
You can be sure that a new issue will be created to ask you to add a X button because it's there on the Google application.
FYI : In the next release, the word "Duration" is removed and the remaining timer text is bigger to highlight it.

...when selecting the timer how often do you look for particular label and not for particular duration?

In my personal case, every time for the timers I use frequently.
For the timers that I use at the moment, I delete them as soon as they are finished.

I just checked Fossify Clock...

I already tested Fossify Clock and their timer UI is very ugly. 😬
Furthermore, as said above, I don't understand the point of doing a long press to delete an item when a very small icon does the same thing.
Additionally, there is only one feature that uses long-press in this app: the one that starts the screensaver in Clock tab.
(BTW: maybe I'll add some text when there are no cities added to this view to notify the user that this feature is present.)
Remember: the application must remain consistent. Labels are used for alarms so it makes sense that they are used for timers. In addition, the time of the alarms is highlighted so it is logical that it be highlighted for the timers as shown in this screenshot:

(and to answer why stick with Clock and not switch to Fossify) - I do prefer Clock UI with circles :) )

Don't worry, I would never have told you to change to another application. I'm actually quite happy that you're using Clock.

I've just come up with a great idea that could avoid adding many lines of code: use the labels!! 😂
More seriously, maybe I'm very tired from my work week and I'm not thinking properly.
At this point, I don't think your request is a good idea for all users. In any case, feel free to open a new issue. Maybe other users will want to share their thoughts on this topic.

Time is important to you but maybe not to everyone. Maybe people want to know what their timers correspond to; I don't know, I'm not in their shoes.
What's more, if we're going to make this kind of change, why keep them for alarms?
What's the difference between alarms and timers? You create different alarms for different reasons that can/should be identified; you also create different timers for different reasons that can/should also be identified.
On the Google and LineageOS application, it is imperative to extend the alarms to edit the title. One more useless manipulation.
In any case, I'm not going to hide labels just because a single user tells me "I don't use them".
To conclude: if I put unused timers on a single line, this means that the text of the time to elapse cannot be bigger as requested in this comment.
So what should I do? Accept his request or yours? Unfortunately, I have to find compromises that may please some, displease others, but in the end please most.
No application satisfies 100% of people. This one will (unfortunately) be no exception.
As I said in my previous comment: feel free to open a new issue. I'm sure others will share their wish on this topic.

(another thing that I don't see much point of in ;) )

If a user doesn't have the "Always On Display" option on their device to display the time, this is still a quick and efficient way to access it. Again, this isn't useless for everyone.


Icon misalignment on mobile

The three icons do not look consistent on mobile

I can help on this issue

I can help today with this one


"New tab" button moved randomly

I installed Firepicker 1.4.1 with Firebug 1.9.1 on a Firefox 9.0.1 (Ubuntu 10.04.3 64bit) and now the button for opening new tabs is sometimes on the left and sometimes on the right side as if there are many open tabs. I will try to attach screenshots.
Btw: I tried it with a new profile and without other extensions

Screenshots: http://imageshack.us/g/545/bildschirmfotomozillafi.png/

And if you remove Firepicker the weirdness is gone? Can you also try Firefox 10?


Running error: Too many open files

Hello SchulzLab,
I wanna use ORNA to normalize my datasets and I tried it on an fastq file but failed. This fastq file is the RNAseq sample with 150bp read length and ~24 million reads.
My command is:
ORNA -kmer 25 -input ../00.fastq/PA1_female_1.clean.fq -nb-cores 30 -type fastq -output Normalized
Then the the following errors came out:

How can I resolve this problem?
Thank you!

Dear Xia Han,
this is a problem with DSK. I found an issue in their GitHub were this was fixed:
https://github.com/rundsk/dsk/issues/105
We will look into how to update this as part in ORNA.
Kind regards,
Marcel


Android 12 Samsung device doesn't get precise location

Describe the bug
A user of my app told me that he has started experiencing very imprecise locations within hundreds of metres from his location. It seems as if he is not receiving locations from GPS.
To Reproduce
A device with his specific configuration behaves this way. Other devices work flawlessly.
Expected behavior
It should work on every device supported by Google Play services as of now.
Screenshots
No screenshots.
Smartphone (please complete the following information):

Device: Samsung S22 Ultra
OS: Android 12 with One UI 4.1

Additional context
What's interesting is that his wife has an Android 12 Samsung phone with One UI 4.0 and it's working perfectly. I guided him through app uninstallation, switching GPS settings to the most precise distance filter, disabling a power saver for the app but nothing has worked so far.
My app targets Android 11. It doesn't have an ACCESS_COARSE_LOCATION permission. I tried that, it worked on my phone with Android 11 but when I uploaded the app to Google Play, it said that it wouldn't support any devices at all. So I removed it again, it was still working and I was able to successfully upload it to Google Play without any issues.
Do you have any ideas what the issue might be? Let me know if you need any more info.
Patrik

The official docs say that the ACCESS_COARSE_LOCATION permission is always required: https://developer.android.com/training/location/permissions. I wonder why Google Play is refusing it?

Did you find a solution?

Sorry for not replying sooner. I recently updated my phone to Android 12 as well, I have a completely different brand and it behaved exactly like that. I tried adding ACCESS_COARSE_LOCATION but that didn't solve the problem.
I observed that the problem is with precise location. All locations have accuracy around 2000 m. One of my users has found a workaround in android settings. Go to App settings -> Your app -> Location permissions. In Android 12, there is a new switch for precise location. The precise location was enabled but it didn't work. But when I turned it off and back on again, it started working as expected. That is, the issue is with the precise location permission.

I have a Samsung A52 which I recently upgraded to OneUI 4.0, and I have not been able to reproduce this problem. After upgrading to OneUI 4.1, I still can not reproduce it. The fact that turning precise locations off and on again fixed the problem for you indicates that there is a bug in the OS. If you can think of something this plugin can do to help, please let me know.

It seems that I have finally figured out what the real problem was. I was mixing the @capacitor/geolocation plugin with this plugin to get a quicker coarse location. Unfortunately, some Android 12 phones didn't play well with this. I stopped getting the first location through @capacitor/geolocation and everything seems to be working now.

Thanks for clearing that up.


in-order-to test-op missing

Currently calling asdf:test-system on phos does nothing, because the phos system is missing this line:
:in-order-to ((test-op (test-op "phos/test")))

That's perfect, thanks!


Basic XQuery FLWOR expression fusion for MarkLogic Planner

Implements basic fusion for FLWOR expressions in the MarkLogic planner and converts ShiftedRead plan from a function call to a FLWOR expression in order to benefit from fusion.
The fusion implemented relies on contextual information within the planner and isn't completely general, though it could be made so once we have a complete fixpoint AST for XQuery.
Fusion for ThetaJoin branches sharing a non-trivial common src isn't implemented here, but is tracked in #1690.
 Last update 72795db...dd4a12b

Any idea how this affects the performance problems caused by the unnecessary provenance? I think @alissapajer is close to a PR for that, anyway, but I wonder if this eliminates the performance aspect of it.

It has a moderate effect, but wasn't the panacea I hoped it would be. I suspect all the extra structure, especially capturing things like predicate results and then projecting them out in the filter, defeats the MarkLogic optimizer.
It seems like creating the structure itself is expensive, maybe the current implementation is suboptimal in that regard. Prior to using the StaticArray/StaticMap extractors the profiler said that just building and concatenating all the structure was taking 50% of the execution time, after those it is down to around 30%, but that still seems high.

Close to time to pull out the profiler...

@wemrysi LGTM - just a couple questions on things I was curious about.

Also when I was searching through the diff, I found it pretty much impossible to type "Flwor" and typed "Flower" every single time :)

@alissapajer Haha, yeah I kept typing flowr instead of flwor myself


Feat: Additional Output Formats

We should have some more output options to show some useful stuff.
Initial ideas:
--asm: output assembly, basically all the opcodes right before we turn them into bytes
--ast: output an AST, basically the object we get after calling `syntax->datum` in the compilation phases pipeline

In puff/puff.rkt we have a few functions that set up some compilation pipelines. To implement these alternative outputs, the easiest way would be to define new functions there, and then in main.rkt hook those functions up to the right cli flags.
Documentation for the cli flag stuff we're using can be found here

this part of the code is already pretty repetitive which isn't always great
it is however really clear and explicit exactly which stages of the compilation pipeline each function calls, and maybe that explicitness is worth the repetitiveness
its possible this gets rewritten in the future but it still would be useful to have this implemented


Record the time spent loading each DAG

See DATAHELP-2038 [1], in which one of the experimentation DAGs sometimes
disappears from the UI's DagBag. I suspect this is because it
occasionally takes too long to load. These metrics should give us more
visibility into the loading time per DAG.
Verified that the metrics are coming through in onebox [2]
gauges.airflow.collect_dags.long_running_test_dag.py|321.054000|1561752840
gauges.airflow.collect_dags.long_running_test_dag.py.sum|321.054000|1561752840
gauges.airflow.collect_dags.long_running_test_dag.py.mean|321.054000|1561752840
gauges.airflow.collect_dags.long_running_test_dag.py.min|321.054000|1561752840
gauges.airflow.collect_dags.long_running_test_dag.py.max|321.054000|1561752840

[1] https://jira.lyft.net/projects/DATAHELP/queues/custom/274/DATAHELP-2038
[2] https://docs.lyft.net/eng/etl/airflow/airflow-concepts.html#exposing-stats-information-in-devbox

cc @lyft/dp-tools-viz

I have a upstream pr(https://github.com/apache/airflow/pull/5350/files) which should do the same. Still waiting for @milton0825 for his pool instrumentation patches.

Oh, cool - what's the dependency on the pool instrumentation patches?

@astahlman lol, actually no...just try to push the instrumentation all at once instead of one by one. But we could add that now as well :)

Codecov Report

Merging #137 into data-platform-upgrade will decrease coverage by 0.21%.
The diff coverage is 100%.

@@                    Coverage Diff                    @@
##           data-platform-upgrade     #137      +/-   ##
=========================================================
- Coverage                  69.16%   68.94%   -0.22%
=========================================================
  Files                        142      142
  Lines                      11300    11304       +4
=========================================================
- Hits                        7816     7794      -22
- Misses                      3484     3510      +26

Impacted Files
Coverage Δ

airflow/models.py
86.14% <100%> (-0.07%)
:arrow_down:

airflow/utils/state.py
86.66% <0%> (-13.34%)
:arrow_down:

airflow/executors/__init__.py
64.51% <0%> (-3.23%)
:arrow_down:

airflow/settings.py
91.13% <0%> (-2.54%)
:arrow_down:

airflow/www/app.py
94.11% <0%> (-2.36%)
:arrow_down:

airflow/utils/dag_processing.py
85.77% <0%> (-0.82%)
:arrow_down:

airflow/jobs.py
73.51% <0%> (-0.58%)
:arrow_down:

airflow/configuration.py
83.91% <0%> (-0.51%)
:arrow_down:

airflow/utils/helpers.py
43.06% <0%> (-0.5%)
:arrow_down:

airflow/www/views.py
68.11% <0%> (-0.35%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a973aea...f9d0e3d. Read the comment docs.

Ok, I'll close this PR and create a new one to merge https://github.com/apache/airflow/pull/5350/files into data-platform-upgrade


Fix heartbeat monitor

Fixed setting parameters from mobile_session to heartbeat_monitor
Fixed ignoreHeartBeatAck
Removed redundant code for expectations
Close session will not fail test, only leave message
Related to APPLINK-31315

Please review @LuxoftAKutsan


EPIC: Implement debug endpoint

Problem
As a developer I'd like to be able to use debug endpoints.
Design issue
Solution
### Tasks
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/1479
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/1698
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/1477
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/1478
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/2431
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/2432
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/2433
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/1480
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/1481
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/1482
- [ ] https://github.com/hashgraph/hedera-json-rpc-relay/issues/1483

Alternatives
No response

On Hold, until needed functionality is implemented in the mirror-node.

Split additonal debug_ APIs out into an enhancement EPIC for the future


Daily cherry-pick from internal

Daily cherry-pick from internal

Failed on two test cases related to query to system table when optimizer is enabled. Fix in next PR


Remove database entries for decoding strategies we are not interested in

This has been done by creating new versions of he playlists which have fewer decoding strategies in them.

This has been done by creating new versions of he playlists which have fewer decoding strategies in them.


Improve type check messages for some functions

Partially addressed #4969.

connection/shift.py
evaluation/*.py
loss/*.py

jenkins, test this please.

LGTM!


Alpha

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/deepdivedevinc/aws-parameter-store?version=dev:862f2f639a53e65defba74a59fa6c304a11c4487

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/deepdivedevinc/aws-parameter-store?version=dev:1d67fb6ba8d51a0df8f1eb9a83e6f5a72fa60054

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/deepdivedevinc/aws-parameter-store?version=dev:1d67fb6ba8d51a0df8f1eb9a83e6f5a72fa60054


Week of January 18: Cut buildpack releases

Component buildpacks have been released - we will release the language family buildpack once all components have been autobumped into the language family buildpack.

https://github.com/paketo-buildpacks/python/releases/tag/v2.7.3


deflated_fem_poisson header files are missing descriptions

Both public and private headers for the deflated_fem_poisson updater have zero comments, making it hard for a newcomer to know how to use or modify these objects.
I'd be good to add these comments.

Addressed in PR #489


How do I reference ninja in vcpkg

vcpkg includes a binary download of ninja.exe for its vcpkg install, is it possible to reference this ninja.exe in a project which depend on vcpkg (cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=.../vcpkg.cmake), without hard-code the path of ninja.exe with version number?

@linquize search ninja executable looks slightly better than hard-code the path, but still doesn't looks like an idea solution. As vcpkg already downloads cmake and ninja, it will be great if there is a documented way to the projects using vcpkg to access them, like vcpkg export their path bases on some command line option. This could help CI build environment by saving the extra config of both tools.

We need to consider compatibility issues caused by different versions.


fix: TypeError in [DockerVersion] badge

Fixes https://github.com/badges/shields/issues/5535. This solution is similar to https://github.com/badges/shields/pull/4907. Still waiting for https://github.com/badges/shields/issues/4911 :-)

Warnings

:warning:
This PR modified service code for docker but not its test code. That's okay so long as it's refactoring existing code.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @platan!

  Generated by :no_entry_sign: dangerJS against 4e8278de62dfd1849de3857f447f938e2d7c53ad


UI-7672 - Enable linting and fix some issues

This PR enables back the linting of the project by:

fixing the configuration: it is impossible to extends the activeui config as it is not published publicly
Uses the same ruleset as admin-ui
fixes some easy issues
disables rules that need more work to fix

It's a shame that we don't have the same rule for trailing commas as in the monorepo, although I'm not sure where it comes from. I'm approving anyway, I'll let you decide whether you want to add it or not.

That's weird, it should be the same rule since prettier is run through activeui-sdk-scripts... any idea why it is not working?


Update Datathon Page for 2025 Datathon

Description

Relevant GitHub Issues that will be fixed are
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
[ ] This change requires a documentation update
[ ] Chore (anything else)

How Has This Been Tested?

[x] Responsiveness on various devices
Desktop Browser

[ ] Apple Safari
[ ] Google Chrome
[ ] Microsoft Edge
[ ] Mozilla FireFox

Mobile Browser

[ ] Apple Safari
[ ] Google Chrome
[ ] Microsoft Edge
[ ] Mozilla FireFox

Other Tests:

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

PR Closure

Use Squash And Merge to Close Pull Request
Delete any branch after merging

Spacing between components are inconsistent or too large.
The countdown timer should be bigger to occupy a bit more space on the sides.
The carousel images can also be a bit larger to occupy space.

Other than those, everything else looks great!


Fix #2. Send data according to spec.

Check the following url for more details https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events/Using_server-sent_events#Fields

LGTM! :+1:


SkyBox and enviroment map

The current SkyBox rendering logic is incorrect, and some maps are reversed. So in the previous example, when the same cubet exture is used as the scene background and pbr env_map, the rendering result is incorrect.
I made and added a standard cubemap ("examples/textures/cubemap.jpg") for testing.
In the env_map_test.py example, I compared the rendering results of the new SkyBox and the current SkyBox, The environment map of the ball uses the same cube texture as SkyBox. Observe the environment reflection of the ball and the text direction. The left one is correct, and the right one is the current wrong rendering.

In another example env_map_cube_camera_test.py, it is shown that using the cube map for the (correct) background SkyBox, and then using CubeCamera can generate the exact same cube map from the scene.

This PR is based off your other PR, making review a bit harder, especially when the other PR changes ... Could you make this PR only the new changes? E.g. by cherry picking the last few commits?  Let us know if you need some help with the Git commands!

This PR is based off your other PR, making review a bit harder, especially when the other PR changes ... Could you make this PR only the new changes? E.g. by cherry picking the last few commits? Let us know if you need some help with the Git commands!

Ah, mainly because I used CubeCamera to test in the env_map_cube_camera_test.py example to verify the correctness of the new SkyBox rendering,
I will modify this example temporarily and update it after CubeCamera merges.

In addition, If you agree, I plan to add two attributes "background" and "environment" to the "Scene".
By setting the "background" attribute, we can distinguish the background object from other ordinary wobjects in the scene, so that the background can be rendered before all other objects. In addition, we can also consider making the "background" parameter accept a "Color" or "Texture", so that we can automatically generate it internally without exposing the "Background" or "SkyBox" objects in API.
By setting the "environment" attribute (should be a cubemap), we can affect all PBR materials (those without "env_map" set separately) in the scene. This saves the code in common use cases that we need to set the same environment map to multiple PBR material objects in a scene.

In addition, If you agree, I plan to add two attributes "background" and "environment" to the "Scene".

That is interesting, but also a change in API. Let's discuss in #332!
My suggestion for now would be to create a new PR with just the skybox fix, so that we can merge that quickly.

You might want to consider making env_map_cube_camera_test.py an example that is executed on CI with screenshot verification.

I'm not sure if we will eventually keep these two examples. At present, this PR is not final. I just want to use these two examples to reveal the current problem of sky box rendering.
At least when the wrong sky box rendering logic is deleted, we won't have the first example for comparison testing. 😅

I updated this PR and corrected the rendering logic of Skybox.
The implementation of new logic mainly depends on the following changes:

Add "depth_write" and "depth_test" identifiers in "render_info", so that we can more flexibly control the "depth write" and "depth test" of the target.

In the render() method, handle the Background object separately to ensure that it is always rendered first.

Screenshot verification failed on "validate_volume".
It seems that it is due to other changes, which should not be caused by this PR, 😅

We intend to take the validation examples from this and merge them in a separate, new PR, and then close this PR.

Superseded by #466 and #507.


EGL example

Pull in EGL examples from waypp

resolved with https://github.com/jwinarske/drmpp/pull/19