Error: There are no atoms in the system (with  write("Data Atoms") command)

Dear Moltemplate users,
I have an issue about " There are no atoms in the system".
I build a force-field of PDMS. The force field include atoms I need inside. (The partial code is shown below:)
PForceField {
write_once("In Init") {
units           real
atom_style      full
bond_style      class2
angle_style     quartic
dihedral_style  opls
pair_style      buck
}
#There are 4 atom types: "C" "H" "Si" "O"
write_once("Data Masses") {
@atom:Si   28.085
@atom:C    12.01
@atom:H     1.007
@atom:O    15.999
And I import the force field to my monomer.lt script. (as shown below:)
_import "PForcefield.lt"   # contains force-field parameters
monomer inherits PForceField {
write("Data Atoms") {
#atomId molId   atomType   charge   x        y          z
$atom:Si $mol:... @atom:Si   0.0   -0.637886  0.553288  -0.183695
$atom:O  $mol:... @atom:O    0.0    0.248119 -0.271508  -1.283296
$atom:C1 $mol:... @atom:C    0.0   -0.600714  2.369272  -0.648393
$atom:H1 $mol:... @atom:H    0.0    0.439526  2.758433  -0.590174
$atom:H2 $mol:... @atom:H    0.0   -0.977302  2.505258  -1.68573
$atom:H3 $mol:... @atom:H    0.0   -1.241965  2.958313   0.0432318461
$atom:C2 $mol:... @atom:C    0.0   -2.392134 -0.107249  -0.223331
$atom:H4 $mol:... @atom:H    0.0   -2.823555  0.014571  -1.241173
$atom:H5 $mol:... @atom:H    0.0   -2.40159  -1.186807   0.0434449812
$atom:H6 $mol:... @atom:H    0.0   -3.0274    0.446758   0.502263
}
write("Data Bonds") {
#bond-id      bond-type        atom-id1  atom-id2
$bond:CH31    @bond:Sidechain1  $atom:C1  $atom:H1
$bond:CH32    @bond:Sidechain1  $atom:C1  $atom:H2
$bond:CH33    @bond:Sidechain1  $atom:C1  $atom:H3
$bond:CH34    @bond:Sidechain1  $atom:C2  $atom:H4
$bond:CH35    @bond:Sidechain1  $atom:C2  $atom:H5
$bond:CH36    @bond:Sidechain1  $atom:C2  $atom:H6
$bond:SiC1    @bond:Sidechain2  $atom:Si  $atom:C1
$bond:SiC2    @bond:Sidechain2  $atom:Si  $atom:C2
$bond:SiO     @bond:Backbone    $atom:Si  $atom:O
}
}_
However, the Error shows:
_Error: There are no atoms in your system. Suggestions:
   Your files must contain at least one
       write("Data Atoms")
   command.  These commands are typically located somewhere in
   one of the molecule object(s) you have defined._

I also try using "new" in my monomer.lt script:
_import "PForcefield.lt"   # contains force-field parameters
mon1 = new Si
mon2 = new C
mon3 = new O
mon4 = new H
monomer inherits PForceField {_
It shows:
Error(ttree.PtknsToNode()):
Class or variable "Si" not found
in this context: ".../Si"
Did I do something wrong with creating atoms?
Thank you so much for help and any suggestions in advance
monomer.txt
PForcefield.txt
.

I try to build an entire big system instead of build the single monomer. I don't know why, but it works now.

Hi Zoe
If you send me all of the moltemplate (.LT) files you are using I will have a look.  Please also tell me what command you were using to invoke moltemplate.sh.  For example:
moltemplate.sh monomer.txt

If this is how you were invoking moltemplate.sh, then it will not work because the "monomer.txt" file does not contain any "new" commands.  When you invoke moltemplate.sh, it should probably look like this instead:
moltemplate.sh system.lt

The "system.lt" file contains "new" commands to make copies of one or more PDMS polymers.
There is typically a file named "polymer.lt" (or "PDMS.lt", or something similar) which defines what a PDMS polymer is. It will contain "new" commands which make copies of the monomer you defined in "monomer.txt".
For examples of this approach, please see:

https://moltemplate.org/examples.html#butane
https://github.com/jewettaij/moltemplate/tree/master/examples/all_atom/force_field_COMPASS/butane#butane-example
https://moltemplate.org/doc/moltemplate_manual.pdf#section.6
(Chapter 6 is only 2 pages long.)

Anyway, if you send me files you are confused about, I will have a look.

Hi Dr. Jewett,
Thank you for the hint!
I thought the command write ("Data Atoms") is the one creates the items, so I can create monomer alone by run the monomer.lt files. But I now realize I should run the script that contain the "new" command, i.e., polymer.lt in my case.
Thank you for really kind suggestions!

I'm glad this helped!
If it's okay, I will close this issue now.


crud bindings implemented

implements: https://p2pvalidator.atlassian.net/jira/software/projects/LSC/boards/121?selectedIssue=LSC-78
The following methows are implemented:

UpdateInterchainQuery(query_data and update_period are updatable)
RemoveInterchainQuery

test with ./test_crud.sh
linked with https://github.com/neutron-org/neutron/pull/24

tested with ./test_crud.sh, everything seems to work fine


Why the train subset and val subset are exactly the same set folder?

Why the train subset and val subset are exactly the same set folder?
Will it decrease the reconstruction performance?

The training set and validation set shown in the code are just examples. In your experiment, you have to set them to your custom folders. In that case the training set and validation set should be different folders.

thanks for answer！
I set train and val subset different, train:val = 5:1, after 200k iterations, the landmark loss is still high as below, what's the issue?

Here the printed landmark loss are in pixel scale so that a value of 2 means 2-pixel distance to the ground truth, which is reasonable.

great answer！


Added new items for Gen2 VM and FSLogix exclusions

Thanks mate @bagwyth , I see now the flow is working, right?

Yep. Everything is working correctly. @erjosito helped me understand the process so should be OK to approve future changes.


Feature Request - Possible to group by a column?

Would be good to be able to group by a column.

How would this look like?

https://msdnshared.blob.core.windows.net/media/MSDNBlogsFS/prod.evol.blogs.msdn.com/CommunityServer.Components.PostAttachments/00/09/49/79/83/datagridgrouping.jpg
Maybe double clicking on a column makes it group by that column. Or having a groupby icon on each of the columns - only one column can be active for groupby


feat: Update default caching value. Keep the default case same as V1 driver and update caching for shared disks to None.

What type of PR is this?
Changes to keep the default caching consistent with V1 driver and update default caching for shared disks to None.

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.7%) to 42.721%

Files with Coverage Reduction
New Missed Lines
%

pkg/azdiskschedulerextender/azdiskschedulerextender.go
7
54.92%

Totals

Change from base Build<PHONE_NUMBER>:
-1.7%

Covered Lines:
179

Relevant Lines:
419

💛  - Coveralls


MEMOS upgrades to the latest version, the homepage error appears

Describe the bug
Failed to compose memo response。
Steps to reproduce
You can see on the homepage。
Screenshots or additional context

try to log in again?

Re-login with your admin account;
Go to setting page directly with url /setting;
Click the Vacuum button in the system setting section;

Re-login with your admin account;
Go to setting page directly with url /setting;
Click the Vacuum button in the system setting section;

I have tried it, there is no effect

Maybe fixed in https://github.com/usememos/memos/commit/b452d63fa6b2fbf7d4f74976ee12cf60d7a09f4c


Refactor: move workspace logic from repository to saved objects client wrapper

Description
Move workspace check conflict related logic to a saved objects client wrapper so that the logic can be turned off once workspace plugin is disabled, introducing as less as possible effect on OSD core.
Issues Resolved

Screenshot

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report
Attention: Patch coverage is 12.07430% with 284 lines in your changes are missing coverage. Please review.

Project coverage is 34.88%. Comparing base (dc240eb) to head (88ea904).
 Consider uploading reports for the commit e59ab71 to get more accurate results

Files
Patch %
Lines

...rces/datasource_selector/datasource_selectable.tsx
17.07%
34 Missing :warning:

...cross_compatibility/cross_compatibility_service.ts
0.00%
31 Missing :warning:

...d_objects/import/check_conflict_for_data_source.ts
0.00%
25 Missing :warning:

...erver/saved_objects/import/create_saved_objects.ts
0.00%
25 Missing :warning:

..._sources/datasource_services/datasource_service.ts
0.00%
19 Missing :warning:

...ins/data/public/data_sources/datasource/factory.ts
0.00%
11 Missing :warning:

...a_sources/default_datasource/default_datasource.ts
0.00%
10 Missing :warning:

src/core/server/security/security_service.ts
0.00%
9 Missing :warning:

src/core/server/server.ts
0.00%
9 Missing :warning:

...erver/saved_objects/import/import_saved_objects.ts
0.00%
8 Missing :warning:

... and 41 more

Additional details and impacted files
@@              Coverage Diff               @@
##           workspace     #248       +/-   ##
==============================================
- Coverage      66.24%   34.88%   -31.37%
==============================================
  Files           3438     1891     -1547
  Lines          66264    36687    -29577
  Branches       10694     6723     -3971
==============================================
- Hits           43899    12798    -31101
- Misses         19757    23037     +3280
+ Partials        2608      852     -1756

Flag
Coverage Δ

Linux_1
?

Linux_2
?

Linux_3
?

Linux_4
34.88% <12.07%> (+0.35%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


is it possible to insert your own icons for folders or files with a specific name

is it possible to insert your own icons for folders or files with a specific name

Yes read the doc.

sdf


remap right control to menu key.

I use the menu key so I'd like to map the right control key on my laptop to the menu key.
[ids]

*

[main]

rightcontrol = menu

capslock = overload(capslock, esc)

# The default shift layer (the layer activated when shift is pressed).
[shift]

capslock = layer(capslock_shift)

[capslock:C]

shift = layer(capslock_shift)
h = left
j = down
k = up
l = right

[capslock_shift]

h = C-left
j = C-down
k = C-up
l = C-right

Not sure why it doesn't work.

What do you mean by 'doesn't work'? What behaviour is exhibited and what had you expected?

I'm assuming the first output is what you get (ie menu, which doesn't do what you expected but looks correct) and the second output is what you'd like to get (ie compose). On my keyboard, the key with a little menu icon also emits compose and brings up a context menu by default. Perhaps you can achieve what you want by setting rightcontrol = compose instead?
See also https://github.com/rvaiya/keyd/issues/177#issuecomment-1092064707.

Let me try it. Thanks. Compose is certainly unexpected.

Thanks, that worked although it surprised me.

How about adding 102nd = compose as an example of overriding of this key

to a context menu action which is usually located here?

FYI: I wanted to make PrtSc (keyd monitor calls it sysrq) to the menu key on the buil-in Lenovo ThinkPad P15 Gen 1 built-in keyboard (note that there is no menu key on the keyboard). I tried using both sysrq = menu (which didn’t work), but sysrq = compose works as expected in Firefox, JetBrains WebStorm, GNOME Prompt, Insomnia, EletronMail (ProntonMail web client), Discord, ClickUp (AppImage), Slack, Todoist. It does not work in Warp (terminal) which might be expected as it is a new type of terminal and it is still in development.


Get nominated candidate pair and use in another application

I would need to establish a UDP connection between two clients in an application, but the aioice API seems to only support sending data between the nominated pair through send[to] and recv[from].
I was able to get the active pair by calling <Connection>._nominated.get(1) after reading the source, but _nominated is private so I don't think it's supposed to be used.
Is this something that's even supposed to be done using ICE or should I be using STUN directly?

Hi! I'm not sure I understand, why would you want to run an ICE negotiation and then use a non-nominated pair?

Hi! My use case is connecting two WireGuard endpoints when they may be behind NAT and a stateful firewall. The original problem was already mostly solved by switching to IPv6 because my mobile carrier doesn't (yet) have a CGNAT for it like they do for IPv4.

and then use a non-nominated pair

The goal was to get the nominated pair at that moment and then pass it to WireGuard, then retry in case the connection is lost. Wouldn't that be possible if the address/port were reused?

Ouch, but aioice doesn't open the sockets in a way that allows the sockets to be reused, so it sounds like quite a hack anyway.. you might as well use the private attributes as I don't think the official API will cater to your usecase.

I see, thanks for the advice :+1:


⚠ GitLab Server has degraded performance

In 3a48ac5, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 8782 ms

Resolved: GitLab Server performance has improved in 7794880.


How to completely remove a project?

I am the owner of PySawit project but I like to completely remove this project from the Warehouse. I am able to do this at the old PyPi site but I can't find any feature to do this on Warehouse, not even to hide or edit releases.
The reason for deleting my project is I was testing things around, as I am new to this Python installation packaging. Note that I have no users of this project, as it is actually incomplete, so I won't break anyone's code.
Why is there no feature to hide releases or delete the project?

You can delete the project on the legacy PyPI site. That functionality has not yet been added to Warehouse. See https://github.com/pypa/warehouse/issues/424 for where we are tracking this.

I have already successfully deleted my project at the Legacy PyPi site but my project still appears at Warehouse. I can even download the files from Warehouse. Is this some sort of sync delay issue? I really need my project at Warehouse to be removed.

The two share the same datastore, but Warehouse heavily caches itself in our CDN provider and legacy PyPI doesn't know how to purge the cache on Warehouse. It will fall out of the cache in up to 24 hours.

Great! Thank you for your help and quick response.

For posterity:  I used curl X PURGE. Problem solved.


Adding the protos for BLE device configuration

Just pulling these out to focus on the parameters and configuration variables we'll control
Did I forget anything? If you have answers to any of the comments I left, please answer them
I'm considering this as a sort of source of truth that we'll build the website around and hook into the code (that we'll probably have to refactor to be more configurable / safer to configure.
Once we're happy with this, I'll squash it into one commit and add it to the rest of the ble work (or we can put it in the main repo and build the ble work off it

I pushed a commit with fixes; once we're happy with it, I'll squash them together into one commit

Thank you! This is very thorough, lots of feature ideas that I hadn't thought of. I'm writing responses inline.
I'm worried about the 15 characteristic limit, here's my current count of the characteristics:
Config (2 characteristics per protobuf)
OTA (3 characteristics in the example code, maybe we could get this down to 2)
ESC Passthrough (2 characteristics)
Serial Debug (2 characteristics)
Music (2 characteristics, maybe we could get away with write-only)
With 3 protobufs we're at 15 characteristics total, which leaves us with no option to add any new features in the future.  And you can check the current size but I don't think we're close to the 512 byte limit? If those are the case then I don't see a reason to use more than 1 protobuf

I really like how well laid out these structures are! I can see you put a lot of thought into them
Some missing parameters, because I haven't written the code for them yet:
Select fire inputs - buttons which select various fire modes. Just an array of pin numbers, where the first one would select the first fire mode?
Potentiometer for flywheel rpm control or pusher rof control: pin number, rpm min, rpm max? Same thing for rof?
Is there anything else the user would want to configure on the fly?
User configured name for the blaster. Use this as the Bluetooth name
Password to keep other people from messing with your blaster settings?
Dettlaff hardware revision name

I'm worried about the 15 characteristic limit, here's my current count of the characteristics:
Config (2 characteristics per protobuf) OTA (3 characteristics in the example code, maybe we could get this down to 2) ESC Passthrough (2 characteristics) Serial Debug (2 characteristics) Music (2 characteristics, maybe we could get away with write-only)
With 3 protobufs we're at 15 characteristics total, which leaves us with no option to add any new features in the future.  And even if you send the whole thing with every small update, I don't think that makes a difference because I'm reading that the lowest bandwidth BLE mode is still 100kbps, so you could transmit a full packet in only 40ms. And you can check the current size but I don't think we're close to the 512 byte limit? If those are the case then I don't see a reason to use more than 1 protobuf

My current plan is to make a larger containing message and only send one protobuf packet through; the smaller divisions give us more granularity and logical separation; let me work on that now.
How often do we plan to program the escs? Perhaps we just make a special firmware whose whole job is to receive the firmware flash the escs, assuming that we don't expect users to do that very often, then roll back to the previous firmware.
Is music something that needs to be controlled by Detlaff? Or is it loaded ahead of time and triggered with a command?
If it's that second method, we could fold that into the esc config image.

Replies are inline
How confident are we that we can accurately calculate fps? Would it make more sense to change the flywheel rpms to fps?

I really like how well laid out these structures are! I can see you put a lot of thought into them
Thanks!
User configured name for the blaster.
Good idea
We can use this as the Bluetooth name Password to keep other people from messing with your blaster settings?
Yeah, we could look at that. Another fun website idea would be a tourney checker that confirms that all the settings are within tournament parameters, and provides a tourney lock

Or even partial tourney lock that keeps people under the pre-defined threshold, but still allows them to switch modes and rates of fire around

Dettlaff hardware revision name
Do we have some way to detect this? Or are we going to have to program that before they're all sent out?

Select fire inputs - buttons which select various fire modes. Just an array of pin numbers, where the first one would select the first fire mode? Potentiometer for flywheel rpm control or pusher rof control: pin number, rpm min, rpm max? Same thing for rof? Is there anything else the user would want to configure on the fly?
Edit: buttons with rof or fps presets? Do we want to support super easy fps adjustment? Doesn't seem very useful too me, I would just tune with my phone once and wouldn't want to accidentally bump my fps knob. And it might make it too easy to cheat. I think we want to move rof into the fire mode struct though, you could definitely want different rof in different modes.
Folding FPS into the ROF array sounds and moving that into the controls proto like a reasonable idea.

Maybe someone wants a low fps, high ROF mode for CQB, but a sniper button to turn up the fps with semi-auto?
I think potentiometers complicate things, particularly when people are asking for screens; maybe we push that out for a later update

Replies are inline

I don't see any replies to my comments inline in the code?

My current plan is to make a larger containing message and only send one protobuf packet through; the smaller divisions give us more granularity and logical separation; let me work on that now.

Do you mean one BLE characteristic that you can send different protobufs through? "More granularity and logical separation" doesn't sound to me like it's worth the added complexity of handling multiple protobufs, but it's up to you. If I were to separate the config variables into multiple protobufs I would probably put the things that can be updated on the fly in one and the things that require a Dettlaff reboot in another. Is this what you were talking about in the other issue about an Updateable proto?

How often do we plan to program the escs? Perhaps we just make a special firmware whose whole job is to receive the firmware flash the escs, assuming that we don't expect users to do that very often, then roll back to the previous firmware.

Yeah that's an option I considered, that would work but if we can fit it in the main firmware that would obviously be preferred.

Is music something that needs to be controlled by Detlaff? Or is it loaded ahead of time and triggered with a command?
If it's that second method, we could fold that into the esc config image.

I believe the ESCs support two types of music - a boot melody that is set via some GUI software over the ESC programming interface (blheli passthrough), and playing notes in real time over dshot, which would need to be stored on Dettlaff.

How confident are we that we can accurately calculate fps? Would it make more sense to change the flywheel rpms to fps?

I think it's probably doable but will be different for every wheel geometry and probably also crush level. We might want to add an fps parameter later, but I don't think rpm is going away.

Dettlaff hardware revision name
Do we have some way to detect this? Or are we going to have to program that before they're all sent out?

Nope I can't think of a way to detect this. Don't think it's worth making a hardware feature on future revisions to make it detect the revision, since I'm planning on preprogramming all future batches.

Maybe someone wants a low fps, high ROF mode for CQB, but a sniper button to turn up the fps with semi-auto?

Yeah that's definitely something we should make sure we can support.

I think potentiometers complicate things, particularly when people are asking for screens; maybe we push that out for a later update

Yeah fair, far more important to get this feature out than get it to support every possible option.

Another fun website idea would be a tourney checker that confirms that all the settings are within tournament parameters, and provides a tourney lock
Or even partial tourney lock that keeps people under the pre-defined threshold, but still allows them to switch modes and rates of fire around

Definitely good ideas! Don't think they're required for the first version though

I don't see any of your comments in the code. They may still be drafts: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request
Yeah, pretty much one characteristic to send the main protobuf through. The BLE stack isn't going to know or need to care about what is being sent, just how long it is.
Take it from me, handling different hardware versions in software gets messy. It will be a lot less headache if we just have one board to support. What do you anticipate that we'll need hardware revisions for?

Oh, and the times on the commits are probably wonky because I needed to rebase on Andrew's changes.
If you've notice, all the subsequent commits in this PR start with fixup! That's a signal to git to squash them all into one commit when it's time to submit.
They aren't distinct changes, but patches to fix bugs or add features that were needed

Ah yeah sorry the review was pending, I didn't know you couldn't see it!
That all sounds good. So if you send different types of protobufs over one stream, do the protobufs have an identifier built in so the protobuf library can know which kind of protobuf it is and parse it correctly? I didn't realize that, sorry for the misguided comments if that's the case.
The reason we need to track hardware versions is that I've already made pinout changes several times with different hardware revisions to be able to add new features or fix issues, and that might happen again. And the new pusher driver will require a totally different code path. You can see the boards_config file has the pinouts for all existing hardware versions, the plan is to store that table on the web app, so when the web app sees a certain hardware version it can set the correct pinout.

Comments


Add build guidance for mac users

Which issue does this PR close?
Closes #96
Rationale for this change

What changes are included in this PR?
I have scripted the prerequirements and tested on MacOS Monterey.

Are there any user-facing changes?

How does this change test

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@ShiKaiWi I have acceptted all your changes and committed again.


Tools package location

https://github.com/hcoona/Grpc.Tools.MsBuild.Unofficial/blob/73ab8f5963e4ae007e9c973153373f7aea2332ed/Grpc.Tools.MsBuild.Core/build/Grpc.Tools.MsBuild.Unofficial.props#L6
I think something more radical than ..\..\.. is needed to locate another package.
One option is to record tools location in .props file of the tools package, and use it in the .targets of the grpc package. Another is rid of separate tools package. In general, packages may end up under different directory trees, if nuget finds one cached but downloads the other.

I think the Grpc.Tools would provide such a .props file to public self path for further reference. In my unofficial package, I've no better solution to it. However, this could be improved after merge this package into Grpc repo.

Actually, this is the single problem that blocks me from using this package.  The packages folder on my system contains packages like packages/Grpc.Tools.1.6.1


Ensure subprocesses are run via Runtime()

Instead of directly calling subprocess, ensure we use Runtime
api methods for running various commands, most importantly
ansible commands.

Idea: we could forbid calling subprocess via pylint.

Idea: we could forbid calling subprocess via pylint.
We can do this in follow-up, I am trying to make this PR as small as possible.

@webknjaz @ganeshrn: I do not plan to merge this until I release 1.0.0 or ansible-compat, but the release of compat is waiting for the approval of this PR as I want to avoid having to patch it in case we miss something.
Please review it and let me know if I can release compat.


Request to make it work with myEdenred Romania

Hi!
First of all thanks for creating this custom component. I never thought about having the balance & other details available in Home Assistant. At first I thought that this works for the Romanian site, later I saw that it is for Portugal.
I though maybe I can hack my way through the code and just change the domains in consts.py to:
API_LOGIN_URL = "https://www.myedenred.ro/edenred-customer/api/authenticate/default"
API_LIST_URL = "https://www.myedenred.ro/edenred-customer/api/protected/card/list"
API_ACCOUNTMOVEMENT_URL = "https://www.myedenred.ro/edenred-customer/api/protected/card/{}/accountmovement"

Although the login seems to work fine, no errors, there is no sensor created. I would expect there to be one at least for the card. In HA logs I get the following message:
Cannot connect to host www.myedenred.ro:443 ssl:True [SSLCertVerificationError: (1, "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Hostname mismatch, certificate is not valid for 'www.myedenred.ro'. (_ssl.c:1129)")]
I am not sure where the certificate is used or how that is managed. Do you think it would be possible to make this work with the Romanian website as well?
Thanks!

Hi,
Thanks for your interest in my component 👍
First of all let me say that the API is not guaranteed to work just by changing the endpoints (it would be cool if it did).
I am available to update my integration to support Romania cards if you are interested in helping.
Looking at your error, the solution is very simple, just remove the www from the endpoints, like this:
API_LOGIN_URL = "https://myedenred.ro/edenred-customer/api/authenticate/default"
API_LIST_URL = "https://myedenred.ro/edenred-customer/api/protected/card/list"
API_ACCOUNTMOVEMENT_URL = "https://myedenred.ro/edenred-customer/api/protected/card/{}/accountmovement"

The certificates are managed by the same entity that manages the website, in this case they forgot to add the address with www, so it only works without. There is nothing that we can do on our side to overcome this.
Please, after testing this FIX, leave feedback (if it worked or not), if it worked I'll add it to the main branch
Thanks!

Hi,
I updated the links but that causes again the incorrect login credentials message. I left only the main login URL with www and then it does log in but there is no entity created. The log shows the same SSL error. Problem is that I am not sure these links exist on the Romanian webpage as if I try to access the PT ones it gives a no access error while the RO ones give a 404 error.
Thanks!

Hello @OddyAte
Can you share your email with me in a private message?
I need to talk to you in private regarding this

I am also interested in this.

intersted also

Can we get an update if you are still working on this? Thanks!

Hello @OddyAte
I contacted several local myEdenred branches to see how I can integrate with them.
The responses are not encouraging, and it seems that they are not interested in supporting this initiative, unfortunately.
Country integrations are happening with the support of users, only.

Thanks for trying at least, sad to hear this but it's somewhat expected. It's interesting they do not have the same infrastructure for each country.


Allow deleting elements from NamedTuple/Hash literals

Resolves #8849

This is good for another review.

This is good for another review.

@asterite Done.  Also rebased on master to fix that CI issue.

@asterite Done.  Also rebased on master to fix that CI issue.

This is good for another review.

Bump.

@oprypin Bump :)

Does https://github.com/crystal-lang/crystal/pull/7109#issuecomment-441625418 not apply here?

@HertzDevil I'm not sure.  IMO it makes sense to have this given you can construct a hash entirely within macro land, but then if you want to remove a key from it, you can't and would have rebuild the whole hash.
That's my usecase at least, copying the named arguments from an annotation, processing it (i.e. using the provided values to add/remove arguments), then double splat it into the constructor of a struct.

@Blacksmoke16 I'm not sure what you mean. Maybe it makes sense, but the argument against deleting from a Hash is exactly the same as about deleting from an Array (the linked comment)

@oprypin I don't see it that way.  The way I took it the linked comment's argument is against mutations because it makes tracking dependency order harder.  I.e. using the old mutable constant DSL pattern before annotations became more prevalent.
However after working a lot more with macros since that original issue; I don't think that argument is entirely correct mainly because there are use cases for mutating data structures other than as a means of "registering" things.  This is even more important if/when #8835 is ever implemented, as it's easy to see hashes/arrays being passed that you'd expect to be able to modify.
I also don't really see the benefit of removing mutating methods from these macro literals anyway.  It just seems like it's making them less useful for no reason.

Bump, ran into this again.
I have an annotation like @[ADI::Register(tags: [{name: "baz", value: 123, tag_type: CustomTag}])].  Each tag can have an optional tag_type that maps this tag to a specific struct. E.g:
struct CustomTag < ADI::AbstractTag
  getter value : Int32

  def initialize(@value : Int32, name : String, priority : Int32? = nil, *, tag_type = nil)
    super name, priority
  end
end

Of which I'm creating it via "#{tag[:tag_type]}.new(#{tag.double_splat})".id, but since I can't delete tag_type from the annotation's named args, I have to include tag_type in the initializer of the struct so that it doesn't error due to no matching overload.

IMO it makes more sense to have HashLiteral#select, which ArrayLiteral also has, and then we could write tag.select { |k, v| k != :tag_type }.double_splat, without introducing a new source of mutability.
(I would personally avoid this call and double_splat altogether, manually iterate over tag, and interpolate each element separately.)

@HertzDevil Not as elegant but that would work too I suppose.  Better than nothing.

manually iterate over tag, and interpolate each element separately.

That's a bit easier said than done I think because the instantiation of the struct is still in the macro context.  If it wasn't then you could easily use a for in loop to do it.


skbio.diversity._util._validate_counts_matrix error message is inaccurate in the empty case

Specifically, the error message reports that the table has three dimensions when it actually has zero.
> skbio.__version__
'0.5.1'
> mat
array([], shape=(0, 0), dtype=int64)
> alpha_diversity('shannon', mat)

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-120-3bddd908e080> in <module>()
      1 # metric, counts, ids, validate
----> 2 alpha_diversity('shannon', c._data.toarray().T.astype(int))

/Users/mcdonadt/miniconda3/envs/q2deblur_mvp_test/lib/python3.5/site-packages/skbio/diversity/_driver.py in alpha_diversity(metric, counts, ids, validate, **kwargs)
    163
    164     if validate:
--> 165         counts = _validate_counts_matrix(counts, ids=ids)
    166
    167     if metric == 'faith_pd':

/Users/mcdonadt/miniconda3/envs/q2deblur_mvp_test/lib/python3.5/site-packages/skbio/diversity/_util.py in _validate_counts_matrix(counts, ids, suppress_cast)
     46         raise ValueError("Only 1-D and 2-D array-like objects can be provided "
     47                          "as input. Provided object has %d dimensions." %
---> 48                          counts.ndim)
     49
     50     if ids is not None and len(counts) != len(ids):

ValueError: Only 1-D and 2-D array-like objects can be provided as input. Provided object has 3 dimensions.

How did you create mat? What is mat.ndim? .ndim is what the error message displays.

q2_feature_table.rarefy. It stemmed from a Table which was entirely filtered out. However, the following will reproduce the issue:
> from skbio.diversity import alpha_diversity
> import numpy as np
> mat = np.zeros((0, 0))
> print(mat.ndim)
2
> alpha_diversity('shannon', mat)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-30-72106afc3231> in <module>()
      3 mat = np.zeros((0, 0))
      4 print(mat.ndim)
----> 5 alpha_diversity('shannon', mat)

/Users/mcdonadt/miniconda3/envs/q2deblur_mvp_test/lib/python3.5/site-packages/skbio/diversity/_driver.py in alpha_diversity(metric, counts, ids, validate, **kwargs)
    163
    164     if validate:
--> 165         counts = _validate_counts_matrix(counts, ids=ids)
    166
    167     if metric == 'faith_pd':

/Users/mcdonadt/miniconda3/envs/q2deblur_mvp_test/lib/python3.5/site-packages/skbio/diversity/_util.py in _validate_counts_matrix(counts, ids, suppress_cast)
     46         raise ValueError("Only 1-D and 2-D array-like objects can be provided "
     47                          "as input. Provided object has %d dimensions." %
---> 48                          counts.ndim)
     49
     50     if ids is not None and len(counts) != len(ids):

ValueError: Only 1-D and 2-D array-like objects can be provided as input. Provided object has 3 dimensions.

Thanks for the MRE! Looks like these two lines are the culprit.


Multiple file uploads on a single request

I have a requirement where I need to be able to upload one or more files to the server and after all files have been uploaded, I need to enable 'next' button of my form wizard.
Is there a way in which i can send multiple files through single XHR using fileupload widget(in which case I can do this in 'done' callback function). The problem is that when I have multiple files, each goes to the server in a different XHR, thus each has a different  callback(So i may end up enabling the 'next' button too soon). Apparently, this was possible in version 4 of fileupload.
Or else, do I have any callback that I can invoke after all files have been uploaded?

Thanks a lot stop callback is exactly what I wanted. Thanks for coming up with this excellent widget.

Hi,
I want to upload all the files and data available in the form in a single request. It may have two or more file upload fields / file upload widgets with different parameters ( like one is multiple file upload and another one is single file upload ). Please tell me how can I achieve this as I'm stuck on this for a long time.
singleFileUploads option can work if there is only one file upload button. so this is not for me.


Parent argument for elements doesn't work properly for some cases

Example of html code:
https://61377283aa57c.htmlsave.net/
Case1:
In this case first input will be filled, but we selected second element by xpath:
`class Page(PageObject):
group_show_block = PageElement(By.XPATH, "//div[@class='modes-block'][2]")
topic_input = InputText(By.XPATH, "//input[contains(@class, 'mode-input')]", parent=group_show_block)
Page().topic_input.text = "Hello"`
Case2:
Parent argument doesn't work, you can write class that not exist in group_show_block and first input wil be filled,
`class GroupTicketShowModal(Group):
group_show_block = PageElement(By.XPATH, "//div[@class='modes-block'][2]")
topic_input = InputText(By.XPATH, "//input[contains(@class, 'mode-input')]", parent=group_show_block)
class Page(PageObject):
group_ticket_show_modal = GroupTicketShowModal(By.XPATH, "//div[contains(@class, 'modal-body')]")`
Page().group_ticket_show_modal.topic_input.text = "Hello"`

Hi @DuXspace , to access using XPATH to a subbelement inside a parent one, a relative path must be used, like .//input[contains(@Class, 'mode-input')] that searches from parent node, instead of an absolute one, like //input[contains(@Class, 'mode-input')] that searches from root node.
This is not about Toolium or Selenium, it is an XPATH design, as can be seen in this Selenium discussion: https://github.com/seleniumhq/selenium-google-code-issue-archive/issues/403

Hello @rgonalo , aahh, yes you're right, my mistake, sorry for disturbing, i forgot to add dot. As I understand it doesn't work for classes inherited from Group like in Case2, because parent will be that selector "//div[contains(@Class, 'modal-body')]", am i right?

Yes, you are right, now an element in a group can not have a custom parent.
But I think that could be a useful feature and it would just work with this PR #240.

@rgonalo thank you! waiting for review

The change is already merged and included in the new release 2.1.1: https://github.com/Telefonica/toolium/releases/tag/2.1.1


Bump pydantic-core to v2.23.1 and other minor v bumps

@sydney-runkle , @dmontagu
This bump results in an ERROR on pydantic-core upgrade:
pip install -U pydantic-core
Requirement already satisfied: pydantic-core in ***\.venv\lib\site-packages (2.20.1)
Collecting pydantic-core
  Using cached pydantic_core-2.23.1-cp312-none-win_amd64.whl.metadata (6.7 kB)
Requirement already satisfied: typing-extensions!=4.7.0,>=4.6.0 in ***\.venv\lib\site-packages (from pydantic-core) (4.12.2)
Using cached pydantic_core-2.23.1-cp312-none-win_amd64.whl (1.9 MB)
Installing collected packages: pydantic-core
  Attempting uninstall: pydantic-core
    Found existing installation: pydantic_core 2.20.1
    Uninstalling pydantic_core-2.20.1:
      Successfully uninstalled pydantic_core-2.20.1
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pydantic 2.8.2 requires pydantic-core==2.20.1, but you have pydantic-core 2.23.1 which is incompatible.
Successfully installed pydantic-core-2.23.1

I'm not sure what is intended/desired behaviour, maybe I shouldn't want to update pydantic-core separately, or there is something wrong in my personal development environment?
Otherwise, I think it would be desired that an upgrade of pydantic should be able to include the latest pydantic_core.


immutablility ==

These should be equal:
map1 = %{test: "map"}
map2 = %{test: "map"}
false = map1 == map2

Inlining the JavaScript's ==, but think ElixirScript is going to have to define it's own equals methods at least for map and probably tuple, list, and bitstring

Would this break matches on the elixirscript side?
def func(map1, map2) when map1 ==map2, do: :matched

Yes it would not work there either. It would not effect pattern matching but would effect guards

The task here would be to:

[ ] create an equals function in erlang.js that takes two parameters and export it
[ ] inside of equals add code to compare

[ ] maps
[ ] tuples
[ ] bitstrings
[ ] maps
[ ] pids
[ ] references
[ ] for everything else, fallback to javascript ==

[ ] Update compiler to translate == to the new erlang.equals function


ENH: Add structural rank to sparse.csgraph

This pull implements structural rank calculation for sparse matrices based on computing the maximum bipartite matching on the underlying graph.  I added the matching algorithm some time ago, so this is a fairly straightforward function to add.  The structural rank is likely to be of wider interest than the csgraph module implies, however since it is based on a graph reordering routine I have placed it here.
I also took the liberty of modifying the docstrings for the other reordering algorithms to make them render correctly in the docs.

Thanks @nonhermitian, looks like a useful enhancement. Please mention on the scipy-dev mailing list that you're proposing to add this function to csgraph.
ERROR: objects in scipy.sparse.csgraph.__all__ but not in refguide::

This is the only test error, you can fix it by adding structural_rank to the function listing in csgraph/__init__.py.

Please also rebase and squash the commits, we'd rather not get the merge commits.

Ok, I have switched to the Duff reference.  The second second reference is still nice, as it gives all of the relevant properties in one location.

Thanks, no objections on ML, so merging.


attr_accessible not applied to attributes= (SECURITY ISSUE)

Inaccessible attributes are being properly filtered through the constructor and update_attributes, but not through the attributes= method. It looks like the attributes= assigns without filtering inaccessible attributes. This behavior is inconsistent with ActiveRecord and could pose a security threat if developers assume that inaccessible attributes are being filtered. The workaround is to use assign instead of attributes=.
class Foo
  include MongoMapper::Document
  attr_accessible :name

  key :name, String
  key :special, String
end

describe Foo do
  # pass
  it "should not mass assign special in constructor" do
    Foo.new(:special => "value").special.should_not == "value"
  end

  # FAIL!
  it "should not mass assign special in attributes=" do
    foo = Foo.new
    foo.attributes = {:special => "value"}
    foo.special.should_not == "value"
  end

  # pass
  it "should not mass assign special in assign" do
    foo = Foo.new
    foo.assign(:special => "value")
    foo.special.should_not == "value"
  end

  # pass
  it "should not mass assign special in update_attributes" do
    foo = Foo.create!
    foo.update_attributes(:special => "value")
    foo.special.should_not == "value"
  end
end

For the security of those of us who are developing with MongoMapper but are familiar with ActiveRecord, I think this issue either needs to be fixed (preferible) or a warning should be posted in the docs for attr_accessible. Thanks.


[HOTFIX] Fixed Compatibilty Issue

Problem : EOF exception was being thrown in case of old store while reading the blocklet Info.
Solution : Added a fix by writing the number of rows per page in case of old store.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3338/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3539/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11605/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3399/

LGTM

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11666/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3602/


bundle exec rake should be able to find frontend and backend assets

Dependencies
This depends on https://github.com/solidusio-contrib/solidus_paypal_commerce_platform/pull/156.
Expected behavior
Given I have a local clone of the SolidusPaypalCommercePlatform repo
When I run bundle exec rake
Then I expect the specs to run and pass
Actual behavior
bundle exec rake encounters the following error:
An error occurred in a `before(:suite)` hook.
Failure/Error: //= link spree/backend/all.js

Sprockets::FileNotFound:
  couldn't find file 'spree/backend/all.js'
  Checked in these paths:
    /home/gsmendoza/repos/solidusio-contrib/solidus_paypal_commerce_platform/spec/dummy/app/assets/config
    /home/gsmendoza/repos/solidusio-contrib/solidus_paypal_commerce_platform/spec/dummy/app/assets/images
    /home/gsmendoza/repos/solidusio-contrib/solidus_paypal_commerce_platform/spec/dummy/app/assets/stylesheets
    /home/gsmendoza/repos/solidusio-contrib/solidus_paypal_commerce_platform/app/assets/javascripts
    /home/gsmendoza/repos/solidusio-contrib/solidus_paypal_commerce_platform/app/assets/stylesheets

Cause
bundle exec rake calls the tasks and methods below in the given order:

SolidusDevSupport::RakeTasks.install
SolidusDevSupport::RakeTasks.install_test_app_task
The extension:test_app rake task (this is automatically invoked while the
tasks are being installed!!!)
Solidus::InstallGenerator#setup_assets

The setup_assets method would only install the all.* frontend and backend
assets if either

Spree::Frontend and Spree::Backend are loaded, or
The Rails environment is test.

Currently, when we run bundle exec rake, neither condition is met:

Spree::Frontend and Spree::Backend are NOT loaded.
The Rails environment is development.

bundle exec rake in CI doesn't have this issue because its postgres and mysql
executors set the Rails environment to test.
bundle exec rspec also doesn't have this issue, since the spec_helper.rb
file sets the Rails environment to test before calling system 'bin/rake extension:test_app'.
Solution
Load the Spree::Frontend and Spree::Backend classes before calling
SolidusDevSupport::RakeTasks.install. Letting bundle exec rake change the
environment to test is not an option since that would affect other rake
tasks.

It seems there's the same problem in https://github.com/solidusio-contrib/solidus_gdpr
Thanks for looking into it!

Letting bundle exec rake change the
environment to test is not an option since that would affect other rake
tasks.

I haven't looked into it in detail, but, isn't it possible to only set the test environment when the executed talk is the default?

I haven't looked into it in detail, but, isn't it possible to only set the test environment when the executed talk is the default?

Hmmm.. I think it should be possible to update the extension so that only bundle exec rake would run in a test environment. I suppose the task would work in the same way that the db:test:prepare rake task only affects the test database.
That being said, I prefer the current solution of requiring the backend and frontend libraries because scope of this solution is narrower than setting the environment to test. Setting the environment to test may result in unexpected side-effects in the future.

I'm closing this because this has been resolved in https://github.com/solidusio/solidus/pull/4411.


Update RVK processing (#24)

The RVK URI prefix has been defined http://rvk.uni-regensburg.de/nt/
and underscore was chosen as replacement character for whitespace.
This commit adds native support of RVK processing and a new option to
set whitespace replacement character.

Codecov Report

Merging #48 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   79.67%   79.73%   +0.05%
==========================================
  Files           6        6
  Lines         743      745       +2
==========================================
+ Hits          592      594       +2
  Misses        151      151

Impacted Files
Coverage Δ

mc2skos/mc2skos.py
57.14% <ø> (ø)
:arrow_up:

mc2skos/record.py
88.34% <100%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d818b4...7d2b49a. Read the comment docs.


[BUG] api/users/reset-password endpoint fails.

Describe the bug
ENDPOINT POST: api/users/reset-password throws a 401, authentication error. Also refer to https://github.com/fullstackhero/dotnet-webapi-boilerplate/discussions/740
To Reproduce

Run project the project and visit localhost:5001/swagger
Try out the api/users/reset-password query
See the response is a 401.

Expected behaviour
The endpoint should respond with a 200 response and reset the password.
Screenshots
See discussion: https://github.com/fullstackhero/dotnet-webapi-boilerplate/discussions/740
Desktop (please complete the following information):

OS: macOS 12.4
Browser:  chrome
Version: 103.0.5060.114

Smartphone (please complete the following information):

N/A

@iammukeshm  I've resolved this issue on the blazor and API application. If you are happy, can I update the project with my solution?


github actions support

Where are those env variables documented?

https://help.github.com/en/articles/virtual-environments-for-github-actions#environment-variables

Did you check what the value of GITHUB_REPOSITORY is for pull requests?
I guess similar to the AZP logic, we need some form of
if pull_request then
   use GITHUB_BASE_REF

Codecov Report

Merging #29 into master will increase coverage by 0.05%.
The diff coverage is 88.88%.

@@           Coverage Diff           @@
##           master   #29      +/-   ##
=======================================
+ Coverage   97.95%   98%   +0.05%
=======================================
  Files           8     8
  Lines         196   201       +5
=======================================
+ Hits          192   197       +5
  Misses          4     4

Impacted Files
Coverage Δ

bincrafters/build_shared.py
97.5% <88.88%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee3fb3...29e4e04. Read the comment docs.

I just did a cross repo PR test here: https://github.com/bincrafters/conan-qt/pull/43/checks?check_run_id=257640481
as can be seen during "install" phase, we still have GITHUB_REPOSITORY=bincrafters/conan-qt

Sorry, I wrote GITHUB_REPOSITORY but I meant GITHUB_REF
Anyway, you patched in the way I meant it 👍

Nice! Cool feature!


[feature] separate font list to a JSON

This will allow font list to auto-update, regardless of UserScript version.

That's a good idea, and something I have also been already thinking of. You wanna take on the task and make a PR? :)


plop v 1.9.0 no longer works in Node 4

This commit in #87 adds a default parameter which isn't supported in Node 4. There may be others, but this is the error Node first hit when I tried to run plop in Node 4.
So I can think of two solutions:

We change the code to work in Node 4
We update the engines flag in package.json to be a higher version of Node (most likely >= 6)

(see node.green)
I can submit a PR for either approach, I just wanted to check in to see what was the preferred approach.

By the way, the library is awesome! 🎉

Hi @benmvp!
From my point of view − as I did this commit − I'd go for solution 1 and fix that so it still works in Node 4. That'd be easy, I just forgot about it when I used this syntax 😅

Cool. 😄  I'll submit a PR tomorrow!

agreed. Although, I will say that we'll be breaking compatibility with Node 4 soon anyway because inquirer has done so and we need to keep up to date with the latest version of our dependencies. I was planning to increment the major version at that point, so fixing this, for now, is probably the right thing to do 👍

I saw with 58e3eb810e4b4e1556fb4e534b4551400197f4ff that you bumped to 1.9.1, but I'm not seeing it in NPM. Did the release actually work? https://yarnpkg.com/en/package/plop

sorry, I got pull away and didn't actually publish it to NPM. should be out there now.

No worries! Just verified I could install it AND that it works in Node 4! 🎉
Thanks again!


Setting enableFacetedValues on a column with null values crashes the table with localCompare error

mantine-react-table version
2.0.0-beta.4
react & react-dom versions
18.2.0
Describe the bug and the steps to reproduce it
Create a table with enableFacetedValues: true,, enable multi-select filter on a column, and pass a null value to that column
Minimal, Reproducible Example - (Optional, but Recommended)
https://codesandbox.io/p/devbox/hopeful-hofstadter-nzjzpl?file=%2Fpackage.json%3A18%2C41&workspaceId=0fb7f49f-5f1b-4500-9a56-4441c688741b
Screenshots or Videos (Optional)

Do you intend to try to help solve this bug with your own PR?
Maybe, I'll investigate and start debugging
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Fixed on #347


Mull might need more mutation operators (get_sign example demonstration)

This is a test program:
int get_sign(int x) {
  if (x > 0) {
    return 1;
  }

  if (x < 0) {
    return -1;
  }

  return 0;
}

int main() {
  // exit code 0 -> test passes
  // exit code 1 -> test failed

  if (get_sign(1) != 1) {
  	return 1;
  }
  // if (get_sign(-1) != -1) {
  // 	return 1;
  // }
  if (get_sign(0) != 0) {
  	return 1;
  }

  return 0;
}

This is the Makefile:

default: compile
	/sandbox/build/build.mull.dir/tools/driver-cxx/mull-cxx \
		-test-framework=CustomTest \
		-compdb-path=fixed.comp.json \
		-mutators=all \
		-ide-reporter-show-killed \
		hello-world

compile:
	clang -fembed-bitcode -g main.cpp -MJ comp.json -o hello-world
	echo "[" > fixed.comp.json
	cat comp.json >> fixed.comp.json
	echo "]" >> fixed.comp.json

run: compile
	./hello-world

This is the execution result:
Running mutants (threads: 6): 6/6. Finished in 13ms.

Killed mutants (6/6):

/sandbox/mull-hello-world-example/step-4-second-mutation/main.cpp:2:9: warning: Killed: Replaced > with >=
  if (x > 0) {
        ^
/sandbox/mull-hello-world-example/step-4-second-mutation/main.cpp:2:9: warning: Killed: Replaced > with <=
  if (x > 0) {
        ^
/sandbox/mull-hello-world-example/step-4-second-mutation/main.cpp:6:9: warning: Killed: Replaced < with >=
  if (x < 0) {
        ^
/sandbox/mull-hello-world-example/step-4-second-mutation/main.cpp:6:9: warning: Killed: Replaced < with <=
  if (x < 0) {
        ^
/sandbox/mull-hello-world-example/step-4-second-mutation/main.cpp:2:9: warning: Killed: Replacing scalar with 0 or 42
  if (x > 0) {
        ^
/sandbox/mull-hello-world-example/step-4-second-mutation/main.cpp:6:9: warning: Killed: Replacing scalar with 0 or 42
  if (x < 0) {
        ^

Survived mutants (0/6):

Mutation score: 100%

Total execution time: 178ms

It can be seen that there is no survived mutation that would hint at the missing test case (the one that is commented out).
Would be nice to find out which mutation would reveal this missing test case.

One mutation that will work is "remove if block". And this leads us to a yet another bit of work of actually implementing that mutation operator.

A normal test coverage measurement (without mutations) would show that the -1 case is never executed. Mutation testing is primarily useful to discover situations where the normal test coverage shows that a line is covered but the actual results are not properly verified.


Refactored to catch up with latest spec.

Please fix merge conflicts

Please update tests

Please update tests

Fixed. Sorry I forgot to run the unit tests.
I commented out the problematical validation temporarily.
Currently the data structure is up to date to the spec but the logic is not yet.
The spec changes every day (it added the field justified_block_hash in AttestationSignedData since yesterday...) and never complete and there are mistakes. So it's really difficult to make the logic finalized for now.

No problem. That's why we have CI. Looks like one test is still failing: https://travis-ci.com/phoreproject/synapse/builds/93103025#L1041
If you run go test ../. in the main directory, it runs all the tests.

Fixed. There is no build and unit test error.
Travis still failed due to a coverage problem in the old code.

There's still an error I believe: https://travis-ci.com/phoreproject/synapse/builds/93105654#L1040

Fixed. Seems the previous coverage related problem was caused by build error too.


Unmatched/unbalanced parenthesis/brackets/etc

Would be nice if you could add highlight error for unmatched and unbalanced parenthesis/square brackets/curly braces/etc. For example, marking everything after (to the end of the file) an unclosed parenthesis in a function definition, to be highlighted with red background, or everything before (to the beginning of the file) an additional closing bracket without a corresponding starting bracket, or everything inside an opening parenthesis with closing bracket (unbalanced grouping stack).
That way, could be easier to identify balancing errors in big enclosed declarations, like that from big nested dicts declarations.
Thanks for the great work.

I don't think I like this idea. Because it means if you for example just entered open bracket in a new file the rest of the file will be all red and you lost all the other highlighting until you enter the corresponding closing bracket.
Moreover you can also use standard to Vim showmatch (see :help showmatch) option or pi_paren (see :help pi_paren) plugin.


bug(mat-bottom-sheet): custom form validation is executed multiple times

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
13.3.9
Description
For one single change inside a form with custom validation, the validate() method is triggered multiple times.
The parameter is, first time, the form control where the change is applied, then the parent form group, and finaly the abstracted control.
This behavior occurs only within a form inside mat-bottom-sheet and starting from the version 14.x.x.
Reproduction
Steps to reproduce:

(Please c.f. Stackblitz to reproduce the issue!! )
Type something in the Phone number field and check that one log is outputed with the abstracted control
Now, click Open bottom sheet and type something else. Note that multiple messages are outputed in the console for one single change

Expected Behavior
Expect validate() method to be executed one single time when a a single change is typed inside a mat-bottom-sheet.
Actual Behavior
validate() method is triggered multiple times.
Environment

Angular: 15.1.5
CDK/Material: <= 14.0.0
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

The bottom sheet doesn't do anything special that would cause the validation to execute multiple times. It's just a dynamically-rendered component that has specific CSS. If there's an issue, it's likely in the forms module.


Rates associated with shipper number are probably not sent correctly

Hello,
When I try rate or shipment request with CustomerClassification set to 00 (Rates associated with shipper number) I always receive null fees (itemized charges) in objects:
RateResponse.RatedShipment[].NegotiatedRateCharges.ItemizedCharges[]
RateResponse.RatedShipment[].RatedPackage[].NegotiatedCharges

  "RateResponse": {
    "RatedShipment": [
      {
        "NegotiatedRateCharges": {
          "ItemizedCharges": null,
          "TaxCharges": null,
          "TotalCharge": {
            "CurrencyCode": "USD",
            "MonetaryValue": 14.58
          },
          "TotalChargesWithTaxes": null
        },
        "RatedPackage": [
          {
            "NegotiatedCharges": null
          }
        ]
      }
    ]
  }
}

According to the documentation, itemized charges should be returned with contract-only shipments.
Could you provide me with more information when those fields are filled?

Hi, thank you for your comment. When making these requests, are you using the CIE or Onlinetools (production) environment?

It is the CIE environment.

Hi, the CIE environment uses mock information and is meant to test the interface. Please use the onlinetools (production) environment to see if this issue is resolved.

Hi, in this situation, please contact your UPS partner representative to aid in the process and have you certified.


Link to the project page is not displayed

I'm using a plugin in the ASP.Net Core 2 project (installed using bower). My problem is that link to GitHub not displayed in the description of the bower package.
I understand that this is a trifle, but it is not entirely convenient to look for a project on GitHub every time. Maybe it makes sense to adjust bower.json for support in Visual Studio?

Hi @XelaNimed
I had already noticed this problem and had forgotten to analyze, believing it to be because the description has more than 140 characters.
Thanks for letting me know.

I noticed that the plugin is now being displayed by intellisense in the bower.json file edition. However, I was unable to display it in the visual search tool.
Do you have any suggestions for correcting this?
Thank you


Add get_lamp_time and get_software_version

Tested with an NX5.
The docs give an example of returning "03-005" to mean version 03.005. However, my NX5 (on 3.52) returned "0352PV". So, get_software_version just returns whatever the projector returned, without any attempt to parse it into something nicer.
Fixes #21

Thanks guys! Does this also need to be added to the HA integration? I tried updating to the latest version in HACS but I don't see either of these attributes coming in from my NP5.

Can you post screenshot of the attributes page

HACS is saying 3.5.8. Manifest.json is pulling 3.6.1 from the library.
This is what I get just idling at the Panasonic Bluray home screen:

yep, thats my bad. I simplified the attributes returned and forgot to include some. Will fix today

3.6.2 released which adds the attributes. You can use send command to get the version I don't want to add more latency to updates


server: add creating raft cluster when become leader.

No check in getRaftCluster?

LGTM

PTAL @ngaut  @disksing

LGTM.


Better error message when failing to get AWS auth

Signed-off-by: Stephen J Day<EMAIL_ADDRESS>Closes #552.
cc @dmp42

LGTM


How can I do whatsapp like replies?

Hi does anyone know what the easiest way is to do whatsapp like replies?

what does that mean?

@mtangoo

I mean this kind of reply style

You mean quoting text?

I don't know how to do it exactly, but I believe you can do it with custom view holder for displaying. Am not sure what you can do for Text-editing.
There was similar issue with Signal. I don't use signal and so I cannot say much. You can download their app and test, if you find that one working, then go dig into their code to see how they did it.
All in all, yours is a common feature and would benefit everyone if you, after solving the problem, share the solution.
The issue am referring to is this one (though ending wasn't that happy):
https://github.com/signalapp/Signal-Android/issues/6017

@mtangoo I will take a look there thanks 👍

You are welcome!

BTW this might be of your interest:
https://github.com/sharish/WhatsappFormatter
https://github.com/egimaben/WhatsappCloneAndroid
https://github.com/Shahar2k5/whatsappClone
I have not checked any of them in practice, so am not sure if they'll add any value!

Signal seems to do quotes with this and some other msg type specific functions. (See: https://github.com/signalapp/Signal-Android/search?p=2&q=quote&unscoped_q=quote ) So seems like I can start from their code. As soon as I have some working code I will tell it in here.

did you manage to find a solution?

@mtangoo I did not yet have time to work on this. So not yet.

Oh, OK!

hi, did someone manage it to one library?

Nothing on the library. You can add your own VH with custom layout. Or you can modify sources and send PR


Master

Many general corrections
Updated to 2016 sigchi style
Externalized references section

I made several corrections to the document. I did these corrections using a pull request and am leaving this comment to emphasis that version is NOT for grading because it is being committed after the deadline.


v1.4 UG DG Updates

Things to do for UG

[ ] Update images in UG to include markup
[ ] Check for broken links
[ ] Clean up

Things to do for DG

[ ] Add venue implementation section
[ ] Check for broken links
[ ] Final clean up

Codecov Report

Merging #302 (fdf20d8) into master (ab1b750) will increase coverage by 0.71%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #302      +/-   ##
============================================
+ Coverage     69.97%   70.69%   +0.71%
- Complexity      909      955      +46
============================================
  Files           139      139
  Lines          2891     2941      +50
  Branches        299      320      +21
============================================
+ Hits           2023     2079      +56
+ Misses          761      752       -9
- Partials        107      110       +3

Impacted Files
Coverage Δ

src/main/java/seedu/rc4hdb/model/StringField.java
71.42% <0.00%> (-8.58%)
:arrow_down:

...rc4hdb/model/venues/booking/fields/HourPeriod.java
82.14% <0.00%> (-6.75%)
:arrow_down:

...seedu/rc4hdb/model/venues/booking/fields/Hour.java
94.11% <0.00%> (-5.89%)
:arrow_down:

.../logic/commands/venuecommands/VenueAddCommand.java
20.00% <0.00%> (-5.00%)
:arrow_down:

...gic/commands/venuecommands/VenueDeleteCommand.java
18.18% <0.00%> (-4.05%)
:arrow_down:

...ain/java/seedu/rc4hdb/model/resident/Resident.java
94.52% <0.00%> (-3.73%)
:arrow_down:

...ava/seedu/rc4hdb/model/venues/UniqueVenueList.java
94.23% <0.00%> (+1.92%)
:arrow_up:

src/main/java/seedu/rc4hdb/model/VenueBook.java
82.14% <0.00%> (+17.85%)
:arrow_up:

src/main/java/seedu/rc4hdb/model/ModelManager.java
89.77% <0.00%> (+18.18%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[PRM-1168] - Changed CYA page row for 'when did you become unable' question text

LSP - VAT trader/agent planned to submit and missed deadline

LSP - agent planned to submit, client missed deadline

LSP - agent flow, client planned to submit

LPP - trader

LPP - agent

test this please


can't change name of certificates

Rancher versions:
rancher/server or rancher/rancher:v2.0.4
rancher/agent or rancher/rancher-agent:v2.0.4
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable):
Docker version: (docker version,docker info preferred)
v17.03.2
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
ubuntu 16 lts
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
vSphere | vCenter
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
k8s
Steps to Reproduce:
add certs and then edit them to change their names, after refresh names remain the same.
Results:
sometimes when names doesn't match, then ingress won't force redirect.

k8s doesn't allow to update cert name. Rancher UI will not allow user to edit it. Thanks

Version - 2.0 master 7/26
Verified fixed

thanks a lot


Immutable objects detected as mutable when immutable.

master warns about freezing mutable Object's but does not detect the frozen-string-literal: true comment leading to an invalid warning:
lib/forwardable/extended/version.rb:7:15: C: Freeze mutable object assigned to constants
    VERSION = "2.0.0"
              ^^^^^^^

2 files inspected, 4 offenses detected
jordon ~/development (master *) % pry
[1] pry(main)> Forwardable::Extended::VERSION.frozen?
=> true

Wow, I was confused for a second.  Either way the error is still valid.

Now that the frozen string literal stuff is in master, I can try and tackle this.

Awesome, thanks!

FYI: this is still a problem unless you set TargetRubyVersion


Validate email addresses

As they are being inputted, validate the email addresses to make sure they're legitimate emails.

Really no reason to do this - only way to even check would be using confirmation emails, but that's not necessary because this is a form. Instead, account for incorrect email input  by the user by asking for double confirmation from canvasser.

We could use NeverBounce to verify emails.


Merge changes from 'staging' to 'main' (Update Image Tags for github-repository-dispatcher-service2)

Summary
Description, Jira Ticket Links and PR Links Fields are mandatory.
Description

Image Tag Update:- "github-repository-dispatcher-service2"

Jira Ticket Links
PR Links

PR Owner:- @ujala-singh, Microservice PR Link:- https://github.com/ujala-singh/github-repository-dispatcher-service2/pull/8

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code refactoring (restructing existing code without changing any functionality)
[ ] This change requires a documentation update

Testing Checklist
Changes tested on

[ ] staging (pre-prod)
[ ] MABL Tests Link (if any)
[ ] Successful Workflow Links (if any)

Error: The following fields are empty: Description, Jira Ticket Links
Hint: Pull Request description is too short. Please add relevant information about the changes.

A new commit has been added to the pull request, indicating an update to the image tag. Before proceeding, please ensure thorough testing of these changes in the staging (Pre-Prod) environment. Mark the testing checklist below accordingly:
Testing Checklist
Changes tested on

[ ] development
[ ] production
[ ] MABL Tests Link (if any)
[ ] Successful Workflow Links (if any)

Required Checks have failed for this PR. Please fix the issues before merging.

The required check 'check_fields' has failed.\nCheck URL: https://github.com/ujala-singh/github-repository-dispatch-receiver/actions/runs/9028932293/job/24810284504

The required check  has failed. Please fix the issues before approving the PR.
Check URL: https://github.com/ujala-singh/github-repository-dispatch-receiver/actions/runs/9028932293/job/24810284504

The required check 'check_fields' has failed. Please fix the issues before approving the PR.
Check URL: https://github.com/ujala-singh/github-repository-dispatch-receiver/actions/runs/9028932293/job/24810284504

The required check 'check_fields' has failed. Please fix the issues before approving the PR.
Check URL: https://github.com/ujala-singh/github-repository-dispatch-receiver/actions/runs/9028932293/job/24810284504

The required check 'check_fields' has failed. Please fix the issues before approving the PR.
Check URL: https://github.com/ujala-singh/github-repository-dispatch-receiver/actions/runs/9028932293/job/24810284504

Error: The following fields are empty: Description, Jira Ticket Links
Hint: Pull Request description is too short. Please add relevant information about the changes.

A new commit has been added to the pull request, indicating an update to the image tag. Before proceeding, please ensure thorough testing of these changes in the staging (Pre-Prod) environment. Mark the testing checklist below accordingly:
Testing Checklist
Changes tested on

[ ] development
[ ] production
[ ] MABL Tests Link (if any)
[ ] Successful Workflow Links (if any)

/rebase

A new commit has been added to the pull request, indicating an update to the image tag. Before proceeding, please ensure thorough testing of these changes in the staging (Pre-Prod) environment. Mark the testing checklist below accordingly:
Testing Checklist
Changes tested on

[ ] development
[ ] production
[ ] MABL Tests Link (if any)
[ ] Successful Workflow Links (if any)

A new commit has been added to the pull request, indicating an update to the image tag. Before proceeding, please ensure thorough testing of these changes in the staging (Pre-Prod) environment. Mark the testing checklist below accordingly:
Testing Checklist
Changes tested on

[ ] development
[ ] production
[ ] MABL Tests Link (if any)
[ ] Successful Workflow Links (if any)


StorageOverrideSystem for recursive item replacement, slime people spawn with nitrogen tanks

About the PR
Adds a system to recursively search through a container looking for items to replace. Intended to be paired with contextual information to determine what to do.
This system is used to conveniently allow slime people to spawn with the proper survival gear.
Why / Balance
Slime people starting with nitrogen tanks is difficult to do in pure yaml without rearranging the code for starting gear, or just plopping one on the ground in front of them.
We already have three separate definitions for backpacks/dufflebags/satchels, each with a paragraph of yaml for 32 different presets. More variables just means more duplication.
Instead of considering hierarchies of items prior to being spawned, this PR adds a system to recursively search a container and replace it's contents.
It may have further use as more species and round start variation is added.
Technical details
Typical Behavior

SharedStationSpawningSystem now raises an ApplyStorageOverrideEvent with an instance of StorageOverridePrototype along with contextual parameters.

StorageOverrideSystem compares the arguments against the prototype, looking for a match on all conditions required by the preset.

If all conditions are satisfied, the item and all of it's contents are ~compared against a dictionary of prototype ids~ checked for the presence of a StorageOverrideComponent.

If the component references the required preset, the component picks a single item to spawn and replace with.

The replaced item is then queued for deletion.

Optional Behavior

MaxReplacements: Maximum number of items to replace before halting
SearchReplaced: Whether to continue down into storage containers after they themselves are replaced
AllowDrop: If the new item is not going to fit, do we halt or allow it to drop on the floor?

Component Behavior
Generic Example
# Preset field is required
# Choose ONE of single, random or keyed
# Single is a string, random a list and keyed is a dictionary

- type: entity
  id: JustPlainItem
  parent: SuperBoringItem
  components:
  - type: StorageOverride
    preset: FoundInFunnyBox
    single: CoolItem
    random:
        - CoolerItem
        - CoolestItem
        - NotSoCoolItem
    keyed:
        musician: VerySeriousMusicalItem
        med: VerySeriousHealingItem
        sec: VerySeriousAndSecureItem

Slime Nitrogen Tank Example
# Resources\Prototypes\Catalog\Fills\Backpacks\StarterGear\overrides.yml
- type: storageOverride   # A recursive search through a storage container...
  id: StartingGear
  preset: StartingGear    # ...full of starting gear...
  species: SlimePerson    # ...that is found in a slime person's...
  slotName: back          # ...backpack.

# Resources\Prototypes\Catalog\Fills\Items\gas_tanks.yml
  - type: entity
  id: EmergencyOxygenTankFilled
  . . .
  components:
  - type: StorageOverride
    preset: StartingGear
    single: EmergencyNitrogenTankFilled

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
Changelog
:cl: Krunk

add: Slime people now spawn with emergency nitrogen tanks.

#21544
This could easily be used to give moths some unique 1x1 food item instead of tinned meat.

Still cooking on the comparison

Updated code and documentation. Compares using components that reference prototypes instead of raw prototype ids alone.
The prototype carries the preset, rules and behavior.
The component references what preset to react to.
The component decides what other items the entity may be replaced with.

Could you make the musician's two instruments randomised

Could you make the musician's two instruments randomised

Yes! I just tested this. Passing job data through SharedStationSpawningSystem is required, so I will add it in a future PR.
The yaml for it will look like this...
- type: storageOverride
  id: StartingGearMusicianBackpack
  allowDrop: true
  preset: StartingGearMusicianBackpack
  slotName: back

- type: entity
  noSpawn: true
  parent: ClothingBackpack
  id: ClothingBackpackMusicianFilled
  components:
    - type: StorageFill
      contents:
        - id: BoxSurvival
        - id: StartingGearRandomStringInstrument
        - id: StartingGearRandomWindInstrument

- type: entity
  parent: BaseHandheldInstrument
  id: StartingGearRandomStringInstrument
  components:
  - type: StorageOverride
    preset: StartingGearMusicianBackpack
    random:
      - ElectricGuitarInstrument
      - BassGuitarInstrument
      - RockGuitarInstrument
      - AcousticGuitarInstrument
      - GuitarlessFretsInstrument
      - BanjoInstrument
      - ViolinInstrument
      - ViolaInstrument
      - CelloInstrument

- type: entity
  parent: BaseHandheldInstrument
  id: StartingGearRandomWindInstrument
  components:
  - type: StorageOverride
    preset: StartingGearMusicianBackpack
    random:
      - SaxophoneInstrument
      - AccordionInstrument
      - HarmonicaInstrument
      - ClarinetInstrument
      - FluteInstrument
      - RecorderInstrument
      - PanFluteInstrument
      - OcarinaInstrument
      - BagpipeInstrument

Better solution coming soon.


Require all credentials options to be explicit

After this is resolved we'll have a code path where implicit credentials are used. This could be install config/credentials files on the machine or instance roles.
The idea would be to require the tap user to always explicitly define where the credentials are coming from so theres no chance of accidentally using the wrong ones.
My thoughts from slack https://meltano.slack.com/archives/C04TSH483DF/p1681752224881609?thread_ts=1681741163.334529&cid=C04TSH483DF

This was a temporary solution to an opinion that I had around requiring the tap user to explicitly configure how they want to authenticate. I described a bit in https://github.com/MeltanoLabs/tap-dynamodb/pull/3#issue-1662996922. I've had weird behavior in taps that pull credentials from my environment or aws config files on my machine so I was hoping to require explicit auth for every method the tap supports. For your use case it might make sense to have a instance_auth=True tap setting that allows a session to be created without parameters or maybe a generic installed_auth=True that means it could allows aws/config.json or aws/credentials files to be used as well. I would just want the user to tell the tap explicitly "use pre-installed configurations from my machine" vs inferring that.

Implicit credentials is useful when running Meltano inside an ECS Task, as AWS provides credentials for Boto3 automatically

The order is:

access key/secret/region
access key/secret/region + session token
profile name
raise error for now but would like to accept a flag to allow use_implicit_credentials where we dont verify anything and just let boto do its thing

Like previously mentioned if use_aws_env_vars is set then credentials are pulled from the env and not from the config keys. My opinion is that we should force one or the other and not a mix.

@danilofuchs check out my write up in https://github.com/MeltanoLabs/tap-dynamodb/pull/3#issue-1662996922 that describes my thoughts. I dont have an issue using implicit credentials but I'm suggesting that the user should be required to tell the tap where the credentials are coming from, in this case use_implicit_credentials would need to be provided. The source of truth for what credentials are to be used should be defined in the tap config.
This is a bit of a crazy scenario 😄  but imagine the case where youre running meltano inside an ECS task that has proper IAM roles to access the data but theres also credentials set as environment variables for something else the ECS task does and also the meltano config has credentials set. Each has different levels of access. Its hard for me to understand which one will be used by the tap.

The order is:

access key/secret/region
access key/secret/region + session token
profile name
raise error for now but would like to accept a flag to allow use_implicit_credentials where we dont verify anything and just let boto do its thing

Like previously mentioned if use_aws_env_vars is set then credentials are pulled from the env and not from the config keys. My opinion is that we should force one or the other and not a mix.

@danilofuchs check out my write up in https://github.com/MeltanoLabs/tap-dynamodb/pull/3#issue-1662996922 that describes my thoughts. I dont have an issue using implicit credentials but I'm suggesting that the user should be required to tell the tap where the credentials are coming from, in this case use_implicit_credentials would need to be provided. The source of truth for what credentials are to be used should be defined in the tap config.
This is a bit of a crazy scenario 😄  but imagine the case where youre running meltano inside an ECS task that has proper IAM roles to access the data but theres also credentials set as environment variables for something else the ECS task does and also the meltano config has credentials set. Each has different levels of access. Its hard for me to understand which one will be used by the tap.

Agreed! Makes sense to have this option explicit
When implementing the tap, I was confused if it was required to set env vars/config values.
So an explicit config for the credential source would make it better documented as well!


libretro.mupen64-plus: fix build under GCC 13

Description of changes

Fix issue https://github.com/NixOS/nixpkgs/issues/282111.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

CC @fmahnke for testing.


Lambda Runtime out of support support warnings

Is this feature request related to a new or existing Amplify category?
No response
Is this related to another service?
No response
Describe the feature you'd like to request
I'd like to propose a suite of features that will help relieve some of the risk associated with old environments running end-of-life runtimes (where a rollback becomes impossible without manual edits of the lambda in AWS).

All built in amplify lambda's (both generated and stock) should default to the most recent version of the lambda runtime when created. This should be obvious.
If the version of amplify is so old that we are creating lambdas that won't be able to be deployed we should warn...
All updates to lambda's that aren't on the most recent runtime should throw a warning recommending upgrading to the most recent version (and an automated way of doing that)
All push's where there is an existing lambda that is running an out of support runtime should throw a very big warning (regarding rollback) and ask to continue - recommending that the lambda be updated without other changes that may force a rollback
When switching to an environment, we should check all lambda's to ensure they are on latest version, and throw warnings

Describe the solution you'd like
Basically we need a way to check and validate that functions will deploy and fallback successfully before we actually do the deployment.
Describe alternatives you've considered
Nothing
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

Hey @GeorgeBellTMH :wave: thanks for raising this! I think these are all very valid points and a great step in the right direction. As such, I've marked this as a feature request for the team to evaluate further 🙂


Where is the training data in example.ipynb

I tried to run example.ipynb, but I got
FileNotFoundError: [Errno 2] File /n/scratch3/users/k/kh278/bindingdb/fold1/train.csv does not exist: '/n/scratch3/users/k/kh278/bindingdb/fold1/train.csv'
In addition, when I run python train.py --task ${task_name} to run the experiments, I only can choose the task as  'biosnap'. However, I got
Traceback (most recent call last):
File "train.py", line 206, in
model_max, loss_history = main()
File "train.py", line 156, in main
auc, auprc, f1, logits, loss = test(testing_generator, model_max)
File "train.py", line 64, in test
loss = loss_fct(logits, label)
File "/home/xzhang/miniconda3/envs/DeepPurpose/lib/python3.7/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/xzhang/miniconda3/envs/DeepPurpose/lib/python3.7/site-packages/torch/nn/modules/loss.py", line 530, in forward
return F.binary_cross_entropy(input, target, weight=self.weight, reduction=self.reduction)
File "/home/xzhang/miniconda3/envs/DeepPurpose/lib/python3.7/site-packages/torch/nn/functional.py", line 2519, in binary_cross_entropy
"Please ensure they have the same size.".format(target.size(), input.size()))
ValueError: Using a target size (torch.Size([32])) that is different to the input size (torch.Size([16])) is deprecated. Please ensure they have the same size.
Thanks

Hi, can you try now? I fixed the bugs.

Thank you! Now it works.
By the way, I want to modify DAVIS and KIBA datasets. Could you please tell me how to do it? Where is the original dataset? I want to have the drugs' name and proteins' name, not only have SMILES and sequence of the proteins.
In addition, what is ESPF?
Thank you for your hard work and happy holidays!

Hi there,
Actually, you can modify the dataset using Pandas directly. This means to manipulate the csv file directly.
And the original dataset is provided in https://zitniklab.hms.harvard.edu/TDC/multi_pred_tasks/dti/

Thank you very much. I will try it later.

@limberc
I am sorry to ask you again.
Where is the .csv files. I check the link that you gave to me, but I used
from tdc.multi_pred import DTI
data = DTI(name = 'DAVIS')
split = data.get_split()
I got data, but data is a DTI object, I can't apply Pandas to it.
Thanks

@limberc
I am sorry to ask you again.
Where is the .csv files. I check the link that you gave to me, but I used
from tdc.multi_pred import DTI
data = DTI(name = 'DAVIS')
split = data.get_split()
I got data, but data is a DTI object, I can't apply Pandas to it.
Thanks

Hi, you can use data.get_data() to get the pandas dataframe. Also, it is downloaded in the local folder with name data

Hi, you can use data.get_data() to get the pandas dataframe. Also, it is downloaded in the local folder with name data

Thank you so much. I got the data using data.get_data(), but I could not find the files that show Drug xxx's real drug's name (ex. cid) and  Taget xxx's real protein name (pid or uniprot)
Thank you very much

Thank you so much. I got the data using data.get_data(), but I could not find the files that show Drug xxx's real drug's name (ex. cid) and  Taget xxx's real protein name (pid or uniprot)
Thank you very much

The Davis Dataset can be found in http://staff.cs.utu.fi/~aatapa/data/DrugTarget/. There are CID files

The Davis Dataset can be found in http://staff.cs.utu.fi/~aatapa/data/DrugTarget/. There are CID files

Thank you!

Thank you!

I used data.get_data for KIBA dataset, I got the followings:
| Drug_ID | Drug | Target_ID | Target | Y
-- | -- | -- | -- | -- | --
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 219 | MTVKTEAAKGTLTYSRMRGMVAILIAFMKQRRMGLNDFIQKIANNS... | 0.000000
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 217 | MSWSPSLTTQTCGAWEMKERLGTGGFGNVIRWHNQETGEQIAIKQC... | 1.100000
I don't know how you sort your drugs and proteins and got Drug 1916, and Target 219, Target 217. I mean Drug 1916 corresponds to which chemical names (CID) and Target 219 corresponds to which protein.
By the way, how do you explain Y=0? I think it is not correct. I saw that people plotted figures of Y_pred vs. Y_true always starting from 8.0 or 9.0. Did they delete the data with Y<9 and then train their models or just plot from 9.0? What do you think? I think you included these smaller values and trained your models. Is it correct?

I used data.get_data for KIBA dataset, I got the followings:
| Drug_ID | Drug | Target_ID | Target | Y
-- | -- | -- | -- | -- | --
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 219 | MTVKTEAAKGTLTYSRMRGMVAILIAFMKQRRMGLNDFIQKIANNS... | 0.000000
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 217 | MSWSPSLTTQTCGAWEMKERLGTGGFGNVIRWHNQETGEQIAIKQC... | 1.100000
I don't know how you sort your drugs and proteins and got Drug 1916, and Target 219, Target 217. I mean Drug 1916 corresponds to which chemical names (CID) and Target 219 corresponds to which protein.
By the way, how do you explain Y=0? I think it is not correct. I saw that people plotted figures of Y_pred vs. Y_true always starting from 8.0 or 9.0. Did they delete the data with Y<9 and then train their models or just plot from 9.0? What do you think? I think you included these smaller values and trained your models. Is it correct?

The drug 1916 is just an index, not a cid.
I think y=0 is normal. Note that the KIBA score is not a affinity score, it is a combination score. So I don’t think it is comparable with what people normally plot the binding affinity score, which also should not remove the points below 8-9. What people normally do is sometime to plot the binding affinity in log scale, which could leads to all values from 0-10. But i haven’t found any plot making plots removing below 8.

The drug 1916 is just an index, not a cid.
I think y=0 is normal. Note that the KIBA score is not a affinity score, it is a combination score. So I don’t think it is comparable with what people normally plot the binding affinity score, which also should not remove the points below 8-9. What people normally do is sometime to plot the binding affinity in log scale, which could leads to all values from 0-10. But i haven’t found any plot making plots removing below 8.

Thank you for your fast response.
Maybe you didn't fully understand my question. I want to know how you made this index. When you output some results show a pair of drug 1916 +Target 219, I want to know which chemical, which protein. I think you have a lookup table about this, but I can't find it.

Thank you for your fast response.
Maybe you didn't fully understand my question. I want to know how you made this index. When you output some results show a pair of drug 1916 +Target 219, I want to know which chemical, which protein. I think you have a lookup table about this, but I can't find it.

This is resolved in the new TDC version, you can update and the ID is now Uniprot IDs

This is resolved in the new TDC version, you can update and the ID is now Uniprot IDs

Thank you so much. However, you didn't change KIBA dataset.

Thank you so much. However, you didn't change KIBA dataset.

It is also updated, with the chembl ids.

It is also updated, with the chembl ids.

I used the following lines:
from tdc.multi_pred import DTI
data = DTI(name = 'KIBA')
df = data.get_data(format='df')
df.head()
| Drug_ID | Drug | Target_ID | Target | Y
-- | -- | -- | -- | -- | --
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 219 | MTVKTEAAKGTLTYSRMRGMVAILIAFMKQRRMGLNDFIQKIANNS... | 11.1
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 217 | MSWSPSLTTQTCGAWEMKERLGTGGFGNVIRWHNQETGEQIAIKQC... | 11.1
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 85 | MERPPGLRPGAGGPWEMRERLGTGGFGNVCLYQHRELDLKIAIKSC... | 11.1
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 170 | MRPSGTAGAALLALLAALCPASRALEEKKVCQGTSNKLTQLGTFED... | 11.1
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 68 | MELAALCRWGLLLALLPPGAASTQVCTGTDMKLRLPASPETHLDML... | 11.1
however, I changed the dataset from KIBA to DAVIS
from tdc.multi_pred import DTI
data = DTI(name = 'DAVIS')
df = data.get_data(format='df')
df.head()
| Drug_ID | Drug | Target_ID | Target | Y
-- | -- | -- | -- | -- | --
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | AAK1 | MKKFFDSRREQGGSGLGSGSSGGGGSTSGLGSGYIGRVFGIGRQQV... | 43.0
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | ABL1p | PFWKILNPLLERGTYYYFMGQQPGKVLGDQRRPSLPALHFIKGAGK... | 10000.0
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | ABL2 | MVLGTVLLPPNSYGRDQDTSLCCLCTEASESALPDLTDHFASCVED... | 10000.0
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | ACVR1 | MVDGVMILPVLIMIALPSPSMEDEKPKVNPKLYMCVCEGLSCGNED... | 10000.0
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | ACVR1B | MAESAGASSFFPLVVLLLAGSGGSGPRGVQALLCACTSCLQANYTC... | 10000.0

I used the following lines:
from tdc.multi_pred import DTI
data = DTI(name = 'KIBA')
df = data.get_data(format='df')
df.head()
| Drug_ID | Drug | Target_ID | Target | Y
-- | -- | -- | -- | -- | --
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 219 | MTVKTEAAKGTLTYSRMRGMVAILIAFMKQRRMGLNDFIQKIANNS... | 11.1
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 217 | MSWSPSLTTQTCGAWEMKERLGTGGFGNVIRWHNQETGEQIAIKQC... | 11.1
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 85 | MERPPGLRPGAGGPWEMRERLGTGGFGNVCLYQHRELDLKIAIKSC... | 11.1
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 170 | MRPSGTAGAALLALLAALCPASRALEEKKVCQGTSNKLTQLGTFED... | 11.1
Drug 1916 | COC1=C(C=C2C(=C1)CCN=C2C3=CC(=C(C=C3)Cl)Cl)Cl | Target 68 | MELAALCRWGLLLALLPPGAASTQVCTGTDMKLRLPASPETHLDML... | 11.1
however, I changed the dataset from KIBA to DAVIS
from tdc.multi_pred import DTI
data = DTI(name = 'DAVIS')
df = data.get_data(format='df')
df.head()
| Drug_ID | Drug | Target_ID | Target | Y
-- | -- | -- | -- | -- | --
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | AAK1 | MKKFFDSRREQGGSGLGSGSSGGGGSTSGLGSGYIGRVFGIGRQQV... | 43.0
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | ABL1p | PFWKILNPLLERGTYYYFMGQQPGKVLGDQRRPSLPALHFIKGAGK... | 10000.0
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | ABL2 | MVLGTVLLPPNSYGRDQDTSLCCLCTEASESALPDLTDHFASCVED... | 10000.0
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | ACVR1 | MVDGVMILPVLIMIALPSPSMEDEKPKVNPKLYMCVCEGLSCGNED... | 10000.0
11314340 | Cc1[nH]nc2ccc(-c3cncc(OCC(N)Cc4ccccc4)c3)cc12 | ACVR1B | MAESAGASSFFPLVVLLLAGSGGSGPRGVQALLCACTSCLQANYTC... | 10000.0

I think it detects local KIBA file, so it didn't download the new version. Could you try remove the local file first, and do it again for KIBA?

I think it detects local KIBA file, so it didn't download the new version. Could you try remove the local file first, and do it again for KIBA?

It works now. Thanks a lot.

It works now. Thanks a lot.