Functional tests failing since last round of build infrastructure changes

These failures likely relate to KoreBuild changes rather than anything that has happened in this repo. Problematic tests are in Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest:

Existing_database_not_using_migrations_exception_passes_thru()
Error_page_displayed_no_migrations()
Error_page_displayed_pending_migrations()
Error_page_displayed_pending_model_changes()
Error_page_then_apply_migrations()
Customize_migrations_end_point()
Pass_thru_when_context_not_in_services()
Pass_thru_when_exception_in_logic()
Error_page_displayed_when_exception_wrapped()

One example failure
Failed   Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.Error_page_displayed_when_exception_wrapped
Error Message:
 System.Exception : I wrapped your exception
---- System.Data.SqlClient.SqlException : Cannot open database "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.FunctionalTests.Scratch_1" requested by the login. The login failed.
Login failed for user 'REDMOND\dougbu'.
Stack Trace:
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.WrappedExceptionMiddleware.Invoke(HttpContext context) in C:\dd\dnx\Universe\Diagnostics\test\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.FunctionalTests\DatabaseErrorPageMiddlewareTest.cs:line 404
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.MigrationsEndPointMiddleware.<Invoke>d__5.MoveNext() in C:\dd\dnx\Universe\Diagnostics\src\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore\MigrationsEndPointMiddleware.cs:line 89
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.<Invoke>d__6.MoveNext() in C:\dd\dnx\Universe\Diagnostics\src\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore\DatabaseErrorPageMiddleware.cs:line 78
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.<Invoke>d__6.MoveNext() in C:\dd\dnx\Universe\Diagnostics\src\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore\DatabaseErrorPageMiddleware.cs:line 138
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.RequestServicesContainerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.TestHost.ClientHandler.<>c__DisplayClass3_0.<<SendAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.TestHost.ClientHandler.<SendAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at System.Net.Http.HttpClient.<FinishSendAsync>d__58.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.<Error_page_displayed_when_exception_wrapped>d__19.MoveNext() in C:\dd\dnx\Universe\Diagnostics\test\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.FunctionalTests\DatabaseErrorPageMiddlewareTest.cs:line 380
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
----- Inner Stack Trace -----
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry)
   at System.Data.SqlClient.SqlConnection.Open()
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.Open()
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.BeginTransaction(IsolationLevel isolationLevel)
   at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.Execute(Tuple`2 parameters)
   at Microsoft.EntityFrameworkCore.Storage.Internal.SqlServerExecutionStrategy.Execute[TState,TResult](Func`2 operation, Func`2 verifySucceeded, TState state)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(IReadOnlyList`1 entriesToSave)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(Boolean acceptAllChangesOnSuccess)
   at Microsoft.EntityFrameworkCore.DbContext.SaveChanges(Boolean acceptAllChangesOnSuccess)
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.WrappedExceptionMiddleware.Invoke(HttpContext context) in C:\dd\dnx\Universe\Diagnostics\test\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.FunctionalTests\DatabaseErrorPageMiddlewareTest.cs:line 399

Another (less common) example:
Failed   Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.Error_page_displayed_pending_model_changes
Error Message:
 Microsoft.EntityFrameworkCore.DbUpdateException : An error occurred while updating the entries. See the inner exception for details.
---- System.Data.SqlClient.SqlException : Invalid object name 'Blogs'.
Stack Trace:
   at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.Execute(IRelationalConnection connection)
   at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.Execute(Tuple`2 parameters)
   at Microsoft.EntityFrameworkCore.Storage.Internal.SqlServerExecutionStrategy.Execute[TState,TResult](Func`2 operation, Func`2 verifySucceeded, TState state)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(IReadOnlyList`1 entriesToSave)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(Boolean acceptAllChangesOnSuccess)
   at Microsoft.EntityFrameworkCore.DbContext.SaveChanges(Boolean acceptAllChangesOnSuccess)
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.PendingModelChangesMiddleware.Invoke(HttpContext context) in C:\dd\dnx\Universe\Diagnostics\test\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.FunctionalTests\DatabaseErrorPageMiddlewareTest.cs:line 194
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.MigrationsEndPointMiddleware.<Invoke>d__5.MoveNext() in C:\dd\dnx\Universe\Diagnostics\src\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore\MigrationsEndPointMiddleware.cs:line 89
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.<Invoke>d__6.MoveNext() in C:\dd\dnx\Universe\Diagnostics\src\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore\DatabaseErrorPageMiddleware.cs:line 78
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.<Invoke>d__6.MoveNext() in C:\dd\dnx\Universe\Diagnostics\src\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore\DatabaseErrorPageMiddleware.cs:line 138
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.RequestServicesContainerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.TestHost.ClientHandler.<>c__DisplayClass3_0.<<SendAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.TestHost.ClientHandler.<SendAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at System.Net.Http.HttpClient.<FinishSendAsync>d__58.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.<Error_page_displayed_pending_model_changes>d__10.MoveNext() in C:\dd\dnx\Universe\Diagnostics\test\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.FunctionalTests\DatabaseErrorPageMiddlewareTest.cs:line 173
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
----- Inner Stack Trace -----
   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
   at System.Data.SqlClient.SqlDataReader.get_MetaData()
   at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)
   at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds)
   at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, String executeMethod, IReadOnlyDictionary`2 parameterValues, Boolean closeConnection)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteReader(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues)
   at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.Execute(IRelationalConnection connection)

@bricelam - do we still need to investigate these failures? I want to make sure we're not missing coverage for too long.

Yes. Ah, this is in a 2.0.0-preview1 milestone. My query is just for 2.0.0; no wonder if fell off my radar...


Distributed sampler shuffle bug

🐛 Bug
The initialization of the shuffle variable in the distributed shuffler is hard-coded to True.
https://github.com/facebookresearch/maskrcnn-benchmark/blob/master/maskrcnn_benchmark/data/samplers/distributed.py#L40
switch from:
self.shuffle = True
to
self.shuffle = shuffle

Great point!
Could you send a PR fixing it?

Fixed via https://github.com/facebookresearch/maskrcnn-benchmark/pull/438


Version 5.0.0-alpha

Description
Bump to version 5.0.0-alpha
Use an alpha version because it's quite the leap to start supporting async. However, there aren't any planned backwards incompatibilities.
Checklist:

[ ] I have added the relevant tests for this change.
[x] I have added an item to the Pending section of docs/changes.rst.

Marked as draft since we're waiting on #1991 and #1993


Waves destroy

While there are Waves.init() and Waves.attach() exists, there is no Waves.destroy() and Waves.detach().
At the same time there is set of addEventListener() calls, so Waves subscribes on control events some time, but never unsubscribes on this.
For example: https://github.com/fians/Waves/blob/master/src/js/waves.js#L442-L462
So it's quite possible to get memory leaks on large application because of using Waves. Could you please add destroy() and detach() methods the Waves API, or point how to workaround this issue?

Hi @sergeyzwezdin, nice idea. I will work on this. Thanks!

Added to v0.8.0


OpenColorIO has graduated

Signed-off-by: John Mertic<EMAIL_ADDRESS>

Does GB need to vote on this? Or is graduation strictly a TAC decision?

That vote is ongoing right now.
On Mon, Sep 16, 2019 at 12:20 AM Larry Gritz<EMAIL_ADDRESS>wrote:

Does GB need to vote on this? Or is graduation strictly a TAC decision?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/AcademySoftwareFoundation/tac/pull/83?email_source=notifications&email_token=AACIOIIBSPGRWFFRBUGXWI3QJ4CRNA5CNFSM4IW5EAIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6YCACA#issuecomment-531636232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACIOIJ7DURXQGNIWG37QNTQJ4CRNANCNFSM4IW5EAIA
.

--
Thank you,
John Mertic
Director of Program Management - Linux Foundation
ASWF, ODPi, and Open Mainframe Project
<EMAIL_ADDRESS>+1<PHONE_NUMBER>
Schedule time with me at https://calendly.com/jmertic


Create Hello.cpp

Adding a language

[ ] The code displays "Hello World"
[ ] I have updated the readme to include the new language
[ ] I have incremented the language count in the readme

Link to programming language:

C++ already exists.

Always check to see if a language exists or not before requesting one to be
added.
On Thu, 6 Jan 2022, 18:12 Nekoism, @.***> wrote:

Adding a language

The code displays "Hello World"
I have updated the readme to include the new language
I have incremented the language count in the readme

Link to programming language:
You can view, comment on, or merge this pull request online at:
https://github.com/leachim6/hello-world/pull/1206
Commit Summary

b374de3
https://github.com/leachim6/hello-world/pull/1206/commits/b374de3b4d0ca1813fc83e5f79adfe9fb1d789eb
Create Hello.cpp

File Changes
(1 file https://github.com/leachim6/hello-world/pull/1206/files)

A c/Hello.cpp
https://github.com/leachim6/hello-world/pull/1206/files#diff-34eaafa11e705f73e034d1dc9e5b7df3c74f1bef091f4f87a3cf194ff1b763aa
(6)

Patch Links:

https://github.com/leachim6/hello-world/pull/1206.patch
https://github.com/leachim6/hello-world/pull/1206.diff

—
Reply to this email directly, view it on GitHub
https://github.com/leachim6/hello-world/pull/1206, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASTP5C2NH4W2CFKNUB72WGTUUXLPXANCNFSM5LM46KFQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[coc.nvim] Error on activate extension coc-discord-rpc: Cannot read pro perties of null (reading 'write')

Help me please

https://github.com/LeonardSSH/coc-discord-rpc/issues/59#issuecomment-1050352993

Thanks


Fix 86 python package dependencies

Pip could not install Numpy on the Alpine image because of missing build dependencies.
Added the needed dependencies to the Dockerfiles of all Python Runtimes.

@eldadfux @Meldiron would either of you mind checking this over? Been running these versions of the python runtimes without issue since the request was opened!

Fix for issue #86

FYI, I tested this with python 3.10 and it increased the image size from 51MB to 243MB 👀


add this is our stop to transportation apps

https://github.com/denimandsteel/thisisourstop
http://thisisourstop.com
focused on vancouver, bc

actually maybe it doesn't exist anymore. closing for now.


Unable to scroll git branches

Instead of scrolling the git branches, the code in the background is being scrolled.
MacOS 12.3 beta, Lapce 0.10.0-dev

I think this is fixed, can you try new release ?

It appears to be fixed!


Update cl_ext.h

Adding macros for cl_intel_queue_no_sync_operations

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@bashbaug, can you please review?

Note: it would be best to have a non-Intel review approval before merging.


[nc-winnt-papcfunc.md] Fix parameter name

The parameter name is "Parameter", not "dwParam".

@xiaoyinl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for your contribution @xiaoyinl.  I've merged your changes and they should be live soon.


⚠ Bofrost.at has degraded performance

In 6bdd1a0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1174 ms

Resolved: Bofrost.at performance has improved in f3e42e6 after 7 minutes.


Broken sentences and extra MST parses due to OpenCog sentence-splitter problem

For Gutenberg Children, MST Parses (207132) are returning 2 extra parses, compared to input corpus and compared to LG parses (207130) - not the end of the world but something that we need to understand (need to provide a workaround and correct parses or wait of OpenCog GitHub issue fixed).
Depends on OpenCog issue: https://github.com/opencog/opencog/issues/3282
~/data/parses/English/Children/Gutenberg_Children_Books/MST_win6_omdist
cat Children-parses-win6-omdist.ull | uniq | sort | uniq -c | head -n 1
207132
cat Children-parses-win6-omdist.ull | uniq | grep -cvP '\S'
207132
~/data/parses/English/Children/Gutenberg_Children_Books/MST_win6_omdist/Children-parses-win6-omdist
cat * | uniq | sort | uniq -c | head -n 1
207132
cat * | uniq | grep -cvP '\S'
207132
~/data/parses/English/Children/Gutenberg_Children_Books/MST_win6_omdist/Children-win6-omdist_sameparses
cat * | uniq | sort | uniq -c | head -n 1
191021
cat * | uniq | grep -cvP '\S'
191021
It looks like ~/data/parses/English/Children/Gutenberg_Children_Books/MST_win6_omdist/Children-parses-win6-omdist have the same number of parses as ~/data/parses/English/Children/Gutenberg_Children_Books/MST_win6_omdist/Children-parses-win6-omdist.ull
Also, it looks like the ~/data/parses/English/Children/Gutenberg_Children_Books/MST_win6_omdist/Children-win6-omdist_sameparses is missing 16111 parses - what is the reason to consider the latter?
Here is what I see in cleaned corpus:
~/data/cleaned/English/Children/cleaned_Gutenberg_Children/capital$ cat * | awk 'NF' | wc -l
207130
Andres, I recall you was removing some files from ~/data/parses/English/Children/Gutenberg_Children_Books/MST_win6_omdist/Children-win6-omdist_sameparses entirely, so it explains the reason.
Now, looking into LG parses:
~/data/parses/English/Children/Gutenberg_Children_Books/LG/capital/parses
cat * | uniq | sort | uniq -c | head -n 1
207130
cat * | uniq | grep -cvP '\S'
207130
I see that MST Parses (207132) are returning 2 extra parses, compared to input corpus and compared to LG parses (207130) - not the end of the world but something that we need to understand.
@glicerico
Issue was raised about underscore not identified as sentence splitter: https://github.com/opencog/opencog/issues/3282
The pre-cleaning process calls sentence-splitter, which doesn't cut the sentence with underscore. Then pre-cleaner cleans underscore, then when calling sentence-splitter again, it cuts the sentence. Since LG-English doesn't call sentence splitter a second time, then it doesn't cut the sentence.
I just realized pre-cleaner should not escape backslashes and double quotes (as currently done in workaround), because LG-English doesn't recognized the escaped mark () and will parse differently

@glicerico - can removal of underscores as white spaces accordingly to pre-cleaner settings (making that as default) let the problem go away? We have this in spec https://docs.google.com/document/d/1xgO6CREtXzYG8k1_8-ixUNUEEnmOTsYX1tWp7gEscc0/edit# :
"6. Symbols splitting tokens (symbol appearing in token splits it): whitespaces (space, \t, \n, \r, long dash, underscore, asterisk)."

@akolonin
"can removal of underscores as white spaces accordingly to pre-cleaner settings (making that as default) let the problem go away?" ==> No, pre-cleaner works according to that specification already, and this way of handling underscores is actually part of the problem, because pre-cleaner removes the underscore, and when the MST-pipeline uses sentence-splitter again (now without underscore) then the sentence is split into two.

@glicerico , since @pennachin says "issue that should be handled with preprocessing", removal of white-spaces by pre-cleaner should be done before splitting the sentences, will this work?

@akolonin , removing token-splitter characters before sentence-splitting would add complication to the pipeline, since we would need to run a pre-pre-cleaner, then sentence splitter, then pre-cleaner.
What I'm thinking is that I can modify our local copy of the pre-cleaner (which is already modified to not escape double quotes and backslashes) and make it handle underscore breaking a sentence if it comes after a dot (just like other beginning of sentence markers like "¿" or "¡"  are handled).

This sentence-splitter problem was fixed in opencog/opencog#3282


Allow changing owner + set owner

Currently, it is not possible to remove the owner role for an owner. Need spec

@jonjaatun can you make a proposal in figma?


@Eventlog annotation outside of main class is not working

Eventlogs created in classes other than the main one does not work during runtime, however complies and deploys without any issue.
Usage of Context.logEvent works as expected. So not entirely sure where the problem arises.

Currently, only classes that can be reached from the Main class through inheritance relationships can have the '@EventLog' annotation.  This is the design spec, nothing else.
Personally, I don't see the need to support it for other utility classes not related to inheritance relationships with the Main class.


Set up jest unit testing for the backend code and mongoDB

Using this page as a jumping off point: https://jestjs.io/docs/en/mongodb
This would allow for a clean test database and probably is a bit safer than what we're doing now (i think just accessing the local db).

https://vitest.dev/
I'd recommend we consider vitest ecosystem for testing later, playwright for e2e is another nice option we can look at later


Can't access one drive folder

Hello - Great work - please open permissions on sharepoint for public sharing - getting an error message..

@ofirkris thank you! please try again now.

Thanks, I'm experimenting with dark image enhancements what method do you think works best?

😂 It is difficult for one method to perform well on all datasets and metrics, so I can't offer a definite reply for you. But you may find the answer on the following surveys.
[1] Benchmarking Low-Light Image Enhancement and Beyond
[2] Advancing image understanding in poor visibility environments: A collective benchmark study
[3] Low-light image and video enhancement using deep learning: a survey


WebGPU-based renderer for the editor

We're finally starting to look at implementing a WebGPU-based rendering in monaco, similar to what xterm.js uses. This issue is used to track all the work which is expected to take several months.
Project: https://github.com/orgs/microsoft/projects/1367/views/1
Related issues
Here are some historical links that might be useful:

Zero latency typing issue which investigated typing latency in monaco. This lead to some improvements but eventually came to the conclusion that the biggest win would be doing rendering manually using our own shaders https://github.com/microsoft/vscode/issues/27378
Old exploration issue https://github.com/microsoft/vscode/issues/162445
Internal issue describing my 2022 prototype which is based on xterm.js' webgl renderer https://github.com/microsoft/vscode-internalbacklog/issues/3157

The branch https://github.com/microsoft/vscode/tree/tyriar/webgl_monaco

Internal issue describing my 2024 prototype which is based on a game renderer I was experimenting with in my spare time  https://github.com/microsoft/vscode-internalbacklog/issues/4906

The branch https://github.com/microsoft/vscode/tree/tyriar/gpu_exploration

Below copied from https://github.com/microsoft/vscode-internalbacklog/issues/4906
GPU-based rendering
branch: tyriar/gpu_exploration
How GPU rendering works
It works by assembling array buffers which represent commands to run on the GPU, these are filled on the CPU with information like the texture to use (chracter, fg, bg), location, offset, etc. xterm.js for example allocates a cols x rows array buffer that represents the viewport only and updates it on every frame where the viewport changes.
There are 2 types of shaders:

Vertex shader - This is run for every vertex (4 vertices per quad) and is used to transform the vertices into screen space.
Fragment shader - This is run for every pixel in the quad and is used to determine the color of the pixel.

How the prototype works
The WebGPU prototype works by pre-allocating a buffer that represents up to 3000 lines in a file with a maximum column length of 200. The buffers* are lazily filled in based on what's the viewport. Meaning once a line is loaded, it doesn't need to be modified again. I think it updates more aggressively currently than needed due to my lack of knowledge around finding dirty lines in Monaco.
@vertex fn vs(
	vert: Vertex,
	@builtin(instance_index) instanceIndex: u32,
	@builtin(vertex_index) vertexIndex : u32
) -> VSOutput {
	let dynamicUnitInfo = dynamicUnitInfoStructs[instanceIndex];
	let spriteInfo = spriteInfo[u32(dynamicUnitInfo.textureIndex)];

	var vsOut: VSOutput;
	// Multiple vert.position by 2,-2 to get it into clipspace which ranged from -1 to 1
	vsOut.position = vec4f(
		(((vert.position * vec2f(2, -2)) / uniforms.canvasDimensions)) * spriteInfo.size + dynamicUnitInfo.position + ((spriteInfo.origin * vec2f(2, -2)) / uniforms.canvasDimensions) + ((scrollOffset.offset * 2) / uniforms.canvasDimensions),
		0.0,
		1.0
	);

	// Textures are flipped from natural direction on the y-axis, so flip it back
	vsOut.texcoord = vert.position;
	vsOut.texcoord = (
		// Sprite offset (0-1)
		(spriteInfo.position / textureInfoUniform.spriteSheetSize) +
		// Sprite coordinate (0-1)
		(vsOut.texcoord * (spriteInfo.size / textureInfoUniform.spriteSheetSize))
	);

	return vsOut;
}

@fragment fn fs(vsOut: VSOutput) -> @location(0) vec4f {
	return textureSample(ourTexture, ourSampler, vsOut.texcoord);
}

Texture atlas
Glyphs are rendered on the CPU using the browser's canvas 2d context to draw the characters into a texture atlas. The texture atlas can have multiple pages, this is an optimization problem as uploading images is relative expensive. xterm.js creates multiple small texture atlas pages, allocates using a shelf allocator and eventually merged them into larger immutable pages as they're more expensive to upload.
Currently the prototype uses a single large texture atlas page, but it warms it up in idle callbacks for the current font and all theme token colors in the background (using the TaskQueue xterm.js util).

Memory usage
text_data_buffer: [wgslX, wgslY, textureIndex, ...]

texture_atlas_buffer: [positionX, positionY, sizeX, sizeY, offsetX, offsetY, ...]

textureIndex in text_data_buffer maps to texture_atlas_buffer[textureIndex * 6]

In the above, each text_data_buffer cell is 12 bytes (3x 32-bit floats), so 3000x200 would be:
3000 * 200 * 12 = 7.2MB

This is pretty insignificant for a modern GPU.
* Double buffering is used as the GPU locks array buffers until it's done with it.
Scrolling
The prototype currently scrolls extremely smoothly as at most a viewport worth of data is filled but often no viewport data will change. Then we just need to update the scroll offset so the shadow knows which cells to render.
Input
So far, the above is highly optimized for readonly scrolling. For input/file changes there are a few cases we need to target. We essentially want to get these updates to take as little CPU time as possible, even if that means leaving stale and no-longer referenced data in the fixed buffers.
Adding new lines or deleting lines
This could be supported by uploading a map whose job is to map line numbers with the index in the fixed buffer:

That way we only need to update indexes, not the whole line data.
Inserting characters
Simple O(n) solution is to just update the entire line. We could do tricks to make this faster but it might not be worth the effort if line length is fixed.
Fixed buffers and long lines
My plan for how the characters will be send to the GPU is to have 1 or more fixed width buffers (eg. 80, 200?) with maps that point to indexes dynamically as described in the input section and then another more dynamic buffer which supports lines of arbitrary length. This dynamic buffer will be a little less optimized as it's the edge case when coding. The fixed buffers could also be dynamically allocated based on the file to save some memory.
Other things we could do

Sub-pixel glyphs for smoother flow - eg. render characters at 4x the width and support offsetting the character every 0.25px.
Proportional font support isn't in xterm.js but it's possible without too much effort, we will need to support this anyway if we want to render widths just like the DOM renderer. The main thing this requires is some way of getting the width of the glyphs and the offset of each character in a line. Again this is an optimization problem of getting and updating this width/offst data as fast as possible.
I believe SPAA is possible to do on the GPU using grayscale textures.
Custom glyphs are supported in the terminal which allows pixel perfect box drawing characters for example like ┌───┘. Whether this looks good in monaco is up to the font settings. Letter spacing and line height will always mess with these
Texture atlas glyphs could be first drawn to a very small page and then packed more efficiently into a longer-term page in an idle callback or worker.
Texture atlas pages could be cached to disk
Canvas sharing - To optimize notebooks in particular we could have a shared canvas for all editors and tell the renderer that it owns a certain bounding box

Test results
These were done on terminalInstance.ts. Particularly slow frames of the test are showed.
The tyriar/gpu_exploration tests disabled all dom rendering (lines, sticky scroll, etc.) to get an idea of how fast things could be without needed to perform layouts on each frame. It's safe to assume that rendering other components would be less than or equal to the time of the most complex component (minimap is similar, but could potentially share data as well).
Scroll to top command
M2 Pro Macbook main

M2 Pro Macbook tyriar/gpu_exploration (all dom rendering disabled)

Windows gaming PC main

Windows gaming PC tyriar/gpu_exploration (all dom rendering disabled)

Scrolling with small text on a huge viewport
fontSize 6, zoomLevel -4
M2 Pro Macbook main

M2 Pro Macbook tyriar/gpu_exploration (all dom rendering disabled)

Windows gaming PC main

Windows gaming PC tyriar/gpu_exploration (all dom rendering disabled)

Very long line
Long lines aren't supported in the gpu renderer currently
Shaders run in parallel to microtasks and layout
The sample below from the Windows scroll to top test above demonstrates how the shaders execute in parallel with layout, as opposed to all after layout.
Before:

After:

Harfbuzz shaping engine is used by lots of programs including Chromium to determine various things about text rendering. This might be needed for good RTL/ligature/grapheme rendering.

Would it be possible to re-upload images to this repo, as they aren't available for regular users now, or they are on a need-to-know basis?

@IllusionMH opps, doing it now 👍

Update on my end for last week. WIP branch https://github.com/microsoft/vscode/pull/225413
General

Rendering is fixed up when switching editors and resizing canvas
Correct background color is drawn (instead of black)

Bunch of general clean up and refactors. In particular improving of variable/constant names and simplifying of the main webgpu code
Set up a GPULifecycle namespace with helpers that return IDisposables
Sorted out some high level lifecycle/leak issues
The GlyphRasterizer is now owned by GpuViewLayerRenderer. The idea here is that the texture atlas is shared across all editors, but different editors could have different font sizes so it's owned by the editor so multiple font sizes can be rendered (WIP, sizes aren't tracked in atlas keys yet).

 There is no overflow logic yet, but glyphs are distributed whether they are alphabet chars in order to test multiple pages
Glyphs are uniquely identified and stored by their metadata instead of just their foreground color
https://github.com/microsoft/vscode/blob/3cfe905cb8035edf2b824efc865f9d0d0febca7e/src/vs/editor/browser/view/gpu/atlas/textureAtlasPage.ts#L81-L84
Texture atlas debug commands

Saving texture atlas pages:

Logging texture atlas page stats:

Some basic unit tests for atlas and allocators
Only the used portion of the atlas texture is uploaded, speeding up render time when there are new glyphs significantly, especially on initial render (~15ms -> ~2ms)

Explorations

Explored approach for rendering of view parts, starting with the ruler.

I first tried to do multiple passes with a separate shader but it's more complicated than I initially thought and requires juggling some textures. Additionally, order of render passes and having them all run every time would be required for this.
I think the right approach here at least for simple view parts is to allow parts to register shapes into some render pass/command encoder object. This would make the ruler component even simpler than the DOM-based one as they would basically just register some fixed rectangles/lines and then refresh it when the setting changes.

Explored the "scratch page" idea for the texture atlas.

This needed more logic in the shader than expected. Uploading only relevant parts of the page texture was a big win that makes this no longer needed.

Hope this become default soon.

@faheemstepsharp I suspect it's going to be a long road to be the default (6 months, 1 year+?). We did eventually switch the terminal to default to GPU rendering, it'll be really bad if we ship an editor that breaks text rendering though.

Update for @hediet and myself for last week. WIP PR #225413
Architecture
We came up with a better approach for where to stick the implementation. GPU parts are now regular "view parts" instead of being more tightly tied to the view.
https://github.com/microsoft/vscode/blob/bd21f3c8f268b741edac137fc109d75a555c0541/src/vs/editor/browser/view.ts#L161
A new ViewGpuContext contains all objects needed for managing rendering to the frame (canvas element, GpuContext, command encoder, etc.). This is owned by View and will be injected to every GPU-related view part, similar to ViewContext.
https://github.com/microsoft/vscode/blob/bd21f3c8f268b741edac137fc109d75a555c0541/src/vs/editor/browser/view.ts#L146-L148
❔ The term "context" is becoming a little overloaded (ViewContext, ViewGpuContext, GPUContext). Maybe there's a better name for ViewGpuContext?
Drawing shapes
Built out the ObjectCollectionBuffer data structure which allows creating type-safe objects that get encoded into a Float32Array which will be used to draw shapes via the ViewGpuContext interface. This will allows view parts to easily add, remove and change sections of the Float32Array in a fairly performant way without needing to deal with the actual buffer. Done right I think this should make the implementation of simple view parts like rulers to be even simpler than the DOM-based counterpart.
https://github.com/microsoft/vscode/blob/bd21f3c8f268b741edac137fc109d75a555c0541/src/vs/editor/test/browser/view/gpu/objectCollectionBuffer.test.ts#L42-L54
This object isn't hooked up yet, just the data structure and tests are mostly done.
General

Lots of cleaning up of interfaces, adding jsdoc, etc.

Removed chars/tokenFg from the allocator interface, to makes it more clear that all an allocator's job is to take a rasterized glyph, put it into an atlas and track the usage.

Fixed metadata key to properly remove metadata that doesn't affect the glyph's rendering.
Fixed "null cells" rendering random characters to the middle of the renderer. This was happening because zeroed out sections of the buffer were all pointing at the first glyph of the first atlas page.
The canvas is sized to fit .overflow-guard. This is probably the final size and position of the canvas.

Added viewport offset which now renders the characters in approximately the right position (when dpr=1 at least). The top and the bottom lines in this picture show the gpu rendering overlaid on top of the DOM rendering.

Added #regions and organized the webgpu init code a little better.

Added a hidden setting to enable the GPU renderer so we can merge the code with minimal impact on default rendering.

Texture atlas

Basic page overflow logic is done; when a page is filled it will start adding glyphs to a second page. Only 2 pages are currently supported in the shader though.
Handle edge cases around glyphs too large for slab or page.
Reduced search time for glyph's page to O(1) https://github.com/microsoft/vscode/pull/225413/commits/740ba1ce332ea24b51baef034c3ccfa926d3790f
More tests!

Debugging

New draw glyph command that will draw a single glyph.

Consolidated all gpu-related debug command into a single Developer: Debug Editor GPU Renderer command that brings up a picker. This will let us create many debug-related commands without spamming the regular command palette.

This may be a silly question but how do you draw glyphs on WebGPU? Are you drawing the glyph map with canvas or render the font manually?

@vincentdchan fonts are rasterized to a texture atlas using a 2d canvas context (mostly on CPU), then the texture atlas pages are uploaded and drawn by the shader where each cell is a texture mapped to 2 triangles. So we're leveraging the browser's font rendering stack and can avoid getting into that.

@Tyriar Great! I am implementing a canvas in WebGPU but AFAIK, 2D canvas doesn't provide API to detect font ligatures. One  approach I used is reading from the font file. Do you handle font ligatures?

@vincentdchan it does not, ligatures are still not supported in the terminal but they're close. The approach uses there is to parse out the ligatures from the font file and then draw the character sequences to the canvas together via a "character joiner" concept, such that they are rendered as ligatures: https://github.com/xtermjs/xterm.js/blob/f186475ec9375256d304fb4563160e2cd3fef291/addons/addon-ligatures/src/LigaturesAddon.ts#L35
There's also a set of "fallback" ligatures which makes it mostly work when font access isn't granted on the web.

New public GH project to track this work: https://github.com/orgs/microsoft/projects/1367

I didn't have too much time last week to work on this but here's what we got done:

Multiple font sizes and font families now work at the same time

Correct tab offset calculation based on editor.tabSize (see screenshot above)
Texture atlas is cleared when the client is zoomed in or out, so text no longer shows as wrong size
Implemented a simple version of canRender and respected that in the GPU renderer, so lines won't get double rendered anymore
Start WIP for the "rectangle renderer" which will be the backend for drawing cursors, current line height, rulers, etc. https://github.com/microsoft/vscode/pull/228632

I was busy experimenting with the new Copilot API this month, will start back up on this effort in November.

Update for the last 2 weeks:
The main goal was to start self-hosting and I've accomplished that as I started using it 100% of the time on Thursday since selection and mouse events are finally working! It's still rough around the edges but it's definitely usable especially starting from the upcoming Insiders release on Monday.
If you'd like to try it out the setting is currently "editor.experimentalGpuAcceleration": "on", it will fade and say it's unrecognized by design for now as I don't want users accidentally stumbling across it so early on. Note that the performance benefits probably won't show just yet, I expect a big bump in performance when line numbers  and bracket pair colorization is handled on the GPU side. Right now any decoration will fallback to DOM, so turning off editor.bracketPairColorization.enabled will likely make most lines render on the GPU (if the codebase is mostly ASCII).
These are the issues currently being tracked: https://github.com/microsoft/vscode/labels/editor-gpu, it might not be worth creating issues just yet as it doesn't take very long to run into issues so a lot of them are obvious and already tracked. Commenting here about any problems if you hit them would probably be best for now.
Major changes

Add an overlay to indicate GPU lines which shows all the time when the setting is on currently (temporary always on) https://github.com/microsoft/vscode/pull/233932

Get DOM-based selections working on GPU lines https://github.com/microsoft/vscode/pull/233769, https://github.com/microsoft/vscode/pull/233923

Get mouse events working on GPU lines https://github.com/microsoft/vscode/pull/229172

Performance

Add caching to the line data to avoid needing to send so much data to the GPU https://github.com/microsoft/vscode/pull/233947
Only update scroll GPU buffer on the scroll event https://github.com/microsoft/vscode/pull/233796

Bug fixes / misc

Re-render when a bunch of events happen https://github.com/microsoft/vscode/pull/232975, https://github.com/microsoft/vscode/pull/233674, https://github.com/microsoft/vscode/pull/233781, https://github.com/microsoft/vscode/pull/233837, https://github.com/microsoft/vscode/pull/233934
Log when uploading a 3rd+ texture atlas page to make it obvious why things don't look right https://github.com/microsoft/vscode/pull/232986
Fix the editor being blank sometimes when an editor is opened https://github.com/microsoft/vscode/pull/232998
Fix left boundary tab rendering https://github.com/microsoft/vscode/pull/233666

Adjust content after lines are deleted https://github.com/microsoft/vscode/pull/233680
Allow falling back to DOM for lines 3000+ (temporary) https://github.com/microsoft/vscode/pull/233696

Clear space and tab cells on enter and don't use the tab offset in the buffer https://github.com/microsoft/vscode/pull/233701/
Move WGSL coordinate calculation inside WGSL, meaning less CPU work and lines are more cacheable https://github.com/microsoft/vscode/pull/233789
Fix an issue where glyphs sometimes missed the last row and column of pixels https://github.com/microsoft/vscode/pull/233918
Fix an issue where negative zoom would break everything https://github.com/microsoft/vscode/pull/233918

Update for the week:

Inline decorations which were one of the big unknowns now have partial support and we have a way forward. Currently in main decorations that change color only like bracket pair colorization should work. See https://github.com/microsoft/vscode/pull/234127 for details. This too a lot of my time to prototype and then polish the large PR.

The GPU mark is now inverted, showing for DOM-rendered lines https://github.com/microsoft/vscode/pull/233995. Hovering it will show the reason(s) why it can't be rendered:

The line numbers region is now clipped so we should not be rendering lines underneath it when scrolled to the right https://github.com/microsoft/vscode/pull/234123. Also should not show underneath the scroll bar https://github.com/microsoft/vscode/pull/234125

Fixing up several problems around render data caching https://github.com/microsoft/vscode/pull/234104, https://github.com/microsoft/vscode/pull/234107, https://github.com/microsoft/vscode/pull/234264

@Tyriar, thanks for your work and updates! However, I believe most people won’t fully comprehend the intricacies of these works. If you could also provide a rough estimate of the progress (even a very rough one is sufficient), that would be fantastic! We eagerly anticipate the availability of this feature in the vscode-prerelease.

Last week was a short one due to holidays in the US. Mostly just fixing some of the bigger self hosting problems.

Improve rendering to the alphabetical baseline so lines don't jump around when switching between GPU and DOM lines (tested only on devicePixelRatio 1 and 2) https://github.com/microsoft/vscode/pull/234601
Fix various problems with handling view events https://github.com/microsoft/vscode/pull/234613, https://github.com/microsoft/vscode/pull/234618
Fix mid-line tabs https://github.com/microsoft/vscode/pull/234661
Fix text being wrong size after zooming https://github.com/microsoft/vscode/pull/234698
Decorations

Disable all non-regular inline decorations for now https://github.com/microsoft/vscode/pull/234579
Fix bracket pair colorization inline decorations not working sometimes https://github.com/microsoft/vscode/pull/234697

I added the config to enable GPU rendering but all lines that should have been rendered on the GPU disappear.
Is this expected? I'm not sure chromium on linux supports webgpu, but an error message or refusing to enable it would be nice to have.

Thanks for your work and looking forward to this.
Version: 1.96.0-insider
Commit: 9e67a1dad5d030b5e2d4a1bb70f12c82287135db
Date: 2024-12-09T16:08:03.105Z
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Linux x64 6.11.0-9-generic (Ubuntu 24.10)

you need to reload after doing changing the setting.

I did, the text disappears after that.

but it's likely related to Linux, especially if you're in a VM.

Not in a VM, so it probably is a Linux issue, seems like my hardware is on a chromium blocklist.
Developer: Show GPU Info shows this:

WebGPU has been disabled via blocklist or the command line

GPU config
value

2d_canvas
enabled

canvas_oop_rasterization
enabled_on

direct_rendering_display_compositor
disabled_off_ok

gpu_compositing
enabled

multiple_raster_threads
enabled_on

opengl
enabled_on

rasterization
enabled

raw_draw
disabled_off_ok

skia_graphite
disabled_off

video_decode
enabled

video_encode
disabled_software

vulkan
disabled_off

webgl
enabled

webgl2
enabled

webgpu
disabled_off

webnn
disabled_off

Thanks for taking your time to respond.

Same as MoonE :/

@KaeLL is MoonE a Linux distro? The info in that screenshot is handy, how did you get it?

@KaeLL the info in that screenshot is handy, how did you get it?

Same as MoonE
Ctrl + Shift + P -> Developer: Show GPU Info

@KaeLL well that's handy 😅

You can forcibly enable it by launching code with --enable-features=Vulkan --enable-unsafe-webgpu Chromium options.
Process Argv:     --enable-features=Vulkan --enable-unsafe-webgpu --crash-reporter-id 97fdaa1d-a108-4830-98a6-1d9208b3ecca
GPU Status:       2d_canvas:                              enabled
                  canvas_oop_rasterization:               enabled_on
                  direct_rendering_display_compositor:    disabled_off_ok
                  gpu_compositing:                        enabled
                  multiple_raster_threads:                enabled_on
                  opengl:                                 enabled_on
                  rasterization:                          enabled
                  raw_draw:                               disabled_off_ok
                  skia_graphite:                          disabled_off
                  video_decode:                           enabled
                  video_encode:                           disabled_software
                  vulkan:                                 enabled_on
                  webgl:                                  enabled
                  webgl2:                                 enabled
                  webgpu:                                 enabled
                  webnn:                                  disabled_off

I tested that on Chrome 131.0.6778.139 and it explicitly complains after every launch

which, if it serves as a reference to the likely older version of Chromium bundled with Electron, I guess it should be taken more seriously?!


DATAGO-71704: Add instance type in EKS worker node defintion

What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is to include instance_types details in EKS worker node definition. This is to make it backward compatible with existing clusters.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

Closing this PR as I made change in cluster upgrade framework (sc-k8s-clusters) to handle instance type being present in EKS node group launch template.


updated readme

Added sample to the readme

Looks good! Thanks for updating that for me!
:shipit:


Update Python.gitignore

Reasons for making this change:
This adds visual studio code generated folder .vscode to the python.gitignore, the comment can be removed to ignore the .vscode folder.
Links to documentation supporting these rule changes:
https://code.visualstudio.com/docs

Is there a need for it to be commented out?


Move image block data to top level (new Image component)

@davisagli  Leaving this here, ready to merge in case we actually move image_field and image_scales to top level.

Merging this manually and continuing in #3337


add user docs

[x] Add domain name (tamper.dev)
[ ] GH Pages landing page

[ ] 3 illustration summary
[x] video

[x] welcome experience

[x] filter + example request

[ ] FAQ
[x] ~install now button~ (not possible)

[ ] annotated screenshots

[ ] 5 features

Draft FAQ:

How to enable Tamper Dev?

Press Alt+T or click on the extension icon.

Can I change the keyboard shortcut?

Yes, go to chrome://extensions/shortcuts

Can I enable Tamper Dev on all windows created by a tab?

Not possible at the moment.

What filters are available?

method, domain, path, and query.

Draft tutorial:

Press Alt+T to open Tamper Dev
Interact with the page (eg, reload, click a button, etc)
Find the request of interest using the filters (eg, method:POST)
Click Intercept, and repeat the action in the UI
Edit the request, and send it.

Draft 3 illustrations summary:

Tamper with the requests sent by your browser, even if encrypted.
Observe how the server reacts to your modifications, interactively.
Modify the response that your browser receives from the server.

https://developer.chrome.com/docs/webstore/images/#promo has some details

Screenshots:

Filter HTTP requests
Edit request/response headers
Inspect/edit POST bodies
Inspect/edit HTTP responses (hex editor)
?

missing:

the logo or a promo image (ETA Tuesday)
the 3 illustrations for the triplet in the homepage (ETA Wednesday)
the link to the webstore (ETA EOW)


Search Bar Update

Visual Update for Search Bar in SearchComponent.tsx (incomplete)
Issues encountered:

Unable to style Results - causes unresponsiveness
Importing CommandItem from "@/components/ui/command" causes Results unresponsiveness

I approve to merge when the comment is resolved, great work @al3xen !

PR ready for review #8


Field set put an inaccurate message when loading data with nan values

When loading a netcdf file containing nan values, the code writes the following warning
/home/staff/delan007/sources/parcels/parcels/field.py:613: RuntimeWarning: invalid value encountered in greater
data = self.dataset[self.name][:, self.indsdepth, self.indslat, self.indslon]
It should say it found nan values, and in which field.

With the change to xarray in #311, this seems to have been fixed? However, we still get warnings  like
particleset.py:315: RuntimeWarning: invalid value encountered in multiply next_output = time + outputdt * np.sign(dt)

but this only happens in Python3 (not Python2)

This seems to have been fixed by one of the recent changes to Field reading


No 'Access-Control-Allow-Origin'

Access to XMLHttpRequest at 'https://randomuser.me/api/?results=1' from origin 'https://randomuser.me/api/?results=1' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

We were having some web server issues at the time. Some server upgrades will be coming in the near future after the v1.4 update comes out to help prevent the api from overloading.


Novelwriter: Add version 2.5.2

Add novelwriter version 2.5.2

Closes #11168

[X] I have read the Contributing Guide.

λ strings .\novelwriter-2.5.2-amd64-setup.exe | grep Inno
InnoSetupLdrWindow
Inno Setup Setup Data (6.3.0)

Please replace custom installer steps with innosetup ("innosetup": true).
See e.g. scoop-lemon/novelwriter for reference.

Changed to innosetup-based installer.

/verify

/verify


[HUDI-5049] HoodieCatalog supports the implementation of dropPartition

Change Logs
HoodieCatalog doesn't support the implementation of dropPartition at present, which is adaptive for the scenario that current partition backfills.
Impact
Supports the HoodieCatalog#dropPartition implementation.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[ ] CI passed

@danny0405, could you please help to review this pull request?

Thanks for the contribution, i have reviewed and applied a patch here:
5049.patch.zip
Can you also fix the HoodieHiveCatalog then ?

@danny0405, I have already applied the above patch and fixes the HoodieHiveCatalog. PTAL.

@danny0405, I have addressed above comments. PTAL.

@danny0405, I have addressed above comments. PTAL.

@danny0405, I have applied above patch and thanks for giving the patch.

@danny0405, I have applied the above patch and removed the unused import in the patch. PTAL.

The failed test case for TestHoodieLogFormat has no relationship with this change, and i test it locally, would just merge it soon ~


#0: Update LLama2/3 readme with demo details

Ticket
Link to Github Issue
Problem description
Provide context for the problem.
What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.
Checklist

[ ] Post commit CI passes
[ ] Model regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

Looks good to me. @caixunshiren please review


Add the ability to open resource paths found in output log

Allows you to open resource paths in the output log. Scripts will open in the Script Editor (has support for line:column as well), and paths to scenes will open the scene when clicked. Other files (such as images or .tres files) will select the file in the FileSystem dock when clicked.

Minimal Testing Project:
FilePathOutputLog.zip
Closes godotengine/godot-proposals#3880

Anything before "res://..." is dropped. Try print("what? res://new_script.gd").

Anything before "res://..." is dropped. Try print("what? res://new_script.gd").
I think word bounary should be considered. hires://new_script.gd should not create any link.
Paths like res://example.com/new_script.gd are not recognized.

Gotcha, I'll fix those issues asap!

Anything before "res://..." is dropped. Try print("what? res://new_script.gd").
I think word bounary should be considered. hires://new_script.gd should not create any link.
Paths like res://example.com/new_script.gd are not recognized.

Should be fixed, thanks!


Add set by path

So, here is a first draft. There are a few things which are probably up for debate and with which I might need your assistance.
It can replace existing values without issue, and the path and value are both type checked correctly.
However, if you wanted to set a property which does not exist, the path parameter will error.
Similarly, if you attempt to set a value within an optional object, this currently fails silently.
Please let me know what you think!
Closes #7

I believe it works correctly if the property does not exist in the object, as this is expected behavior in strong typing. However, for runtime errors related to optional properties, I suggest using the following algorithm:
  const segments = path.split('.') as TPath[];
  const lastKey = segments.pop();
  let target: T = obj;

  for (const key of segments) {
    if (!(key in target)) {
      target[key] = {} as PathValue<T, TPath>;
    }
    target = target[key];
  }

  if (lastKey) {
    target[lastKey] = value;
  }

  return obj;

Also I found it useful to return an object as the result.

Updated the set algorithm as requested. Final test changed to match.

looks good 👍


asyncio.exceptions.TimeoutError

I have the following issue when i use ThreadedWebsocketManager( ). i used VPN, it may related to this issue. Any solutions? thanks in advanced.

same. have you solved this?

Same. All of a sudden this error started showing up. No VPN...


Python runtime errors not reported to user

There appears to be no instance of:
onload="brython({debug:1})"
or equivalent, where the debug flag is explicitly set.

Repaired in https://github.com/BrythonServer/brython-server/commit/ab0fdda5377cd9e6124e4b0341f5598f2751dc26
Released as v.2.1.18


Fix eventStoreServiceEnabled property name

@ibabou : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Bugfix/TDI-38475 api mode refactoring

What is the current behavior? (You can also link to an open issue here)
Problem with ApiMode :
https://jira.talendforge.org/browse/TDI-38475
https://jira.talendforge.org/browse/TDI-38541
https://jira.talendforge.org/browse/TDI-38542
https://jira.talendforge.org/browse/TDI-38577
https://jira.talendforge.org/browse/TDI-38759
https://jira.talendforge.org/browse/TDI-38567
This also fix the following issues :
https://jira.talendforge.org/browse/TDI-38568	use connection doesn't work
https://jira.talendforge.org/browse/TDI-38843
https://jira.talendforge.org/browse/TDI-38856
https://jira.talendforge.org/browse/TDI-38491
https://jira.talendforge.org/browse/TDI-38755	tMarketoOutput field info cannot be output correctly when use dynamic
https://jira.talendforge.org/browse/TDI-38771	tMarketoInput/Output schema can't keep same when execute copy/paste for SOAP API
https://jira.talendforge.org/browse/TDI-38767
https://jira.talendforge.org/browse/TDI-38609 CustomObject compoundkey access
What is the new behavior?
According to https://jira.talendforge.org/browse/TCOMP-550, I refactored ApiMode to be included in the components instead of the connection. This should fix many issues..
Should experience some problems with tables...
I created an issue related to this : https://jira.talendforge.org/browse/TUP-17872
Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[x] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
I included a migration for ApiMode in the components, so there should not be some problems with jobs created before the refactoring.

Pull request test result: success :star:

@undx It would be better list the issues about this pull request, It would be help for review.
Should not only list the jirs link.

Pull request test result: success :star:

Pull request test result: failure :x:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:


Fix regexp to extract project information that fails on some cases.

For example, without the .git and the  (fetch) at the end:
origin<EMAIL_ADDRESS>(fetch)

Thanks for the approval.
I'm under the impression the reported warning was already there, I noticed it (ide warned me), but thought it was intentional.

Thanks for the approval. I'm under the impression the reported warning was already there, I noticed it (ide warned me), but thought it was intentional.

Your IDE must use some other tool than eslint. Just remove the unessecary backslash and we are good to go :smile:


Native bridge cleanup: CollectionView

Proposal for Tabris 2.0:
Events

requestinfo: -> requestInfo
createitem: -> createCell
populateitem: -> updateCell

Methods

update({reload: [index, count]}): -> refresh({index, count})
update({insert: [index, count]}): -> insert({index, count})
update({remove: [index, count]}): -> remove({index, count})
reload({items: itemCount}): -> reload()

Properties

Add property itemCount

A change of the itemCount property after the constructor call should NOT refresh the cells.

Update: The reload() remains, but without parameters.
After setting the itemCount property, the JS side will call reload.
The difference between refresh() and reload() is that refresh() only refreshes the content of the existing cells, i.e. only updateCell() will be called, while reload() reloads the items including requestInfo etc.

Another update: We agreed to rename reload() to load() an keep the itemCount parameter. We do not add itemCount as a property.
This should remove the confusion whether the itemCount property or the load() call is supposed to trigger an update.

Implemented on all platforms.


Allow string arguments to select, dfilter, arrange, group_by

For a lot of common use cases, column names could be passed as strings rather than properties of X:

selecting particular columns
filtering out missing or false values from single columns
arranging by particular columns
grouping by particular columns

This would slightly increase the interface complexity, but I think it would be easy (arguably easier) to read. It also is consistent with a clean (though verbose) style that uses mutate + group_by/arrange/filter rather than a "complex" group_by/arrange/filter that does an operation before grouping, arranging, or filtering.

I fully agree for all of these, except some slight intuitive hesitation for dfilter. I've found myself accidentally writing strings when doing a select or an arrange. Definitely makes sense for group_by as well. I think my slight hesitance with dfilter might be that it encourages users to use the string column name. In some cases this will be more implicit than explicit, against the zen of Python.
For example, if you have "num_points" as a column with how many points someone has, you could write this a few ways:
score_df >> dfilter(X.num_points != 0)
score_df >> dfilter(X.num_points)
score_df >> dfilter("num_points")

The first is less efficient but more explicit and easier to read. The later two are a bit harder to immediately parse, and it seems we encourage it a bit by allowing strings.
On the other hand, it would be weird to allow strings everyone else and not here. And I think we should definitely have strings in the other functions... so I think I'm for it.
Hmm I'm now also wondering if there's a better verb than dfilter out there... if we changed that it should be sooner rather than later so we can break everyone's code before too many people have had a chance to write a lot!

I think the second is perfectly Pythonic. In an ordinary conditional, if points is more idiomatic than if points != 0, isn't it?
I think dfilter should just be filter. This is a little weird but you could effectively "overload" the built-in: put in a check for whether it's called with an iterable as the second argument, and if so, forward it through to the built-in filter().
On a somewhat related note, maybe you should replace the wildcard import in the example with explicit imports from dplython import X, mutate, .... Wildcard imports are discouraged (and this also makes less clear what functions are included in dplython). See PEP 8.

When I explored creating a similar package, the implementation was string based. The strings are evaluated with the dataframe acting as the innermost namespace. This is also how ggplot does it internally with the column mappings in aes(). If you are not used to it, it may seem a bit weird an "magicky" at first. The key advantage is, such an implementation does away with the need of a global variable (X).

The eval option is definitely intriguing, assuming there aren't unavoidable performance or security implications. Maybe it could be an option, alongside functions/lambdas and Laters?
So a mutate could be done one of three ways:
    mutate(twoA=X.a*2)
    mutate(twoA="a*2")
    mutate(twoA=lambda x: x.a*2)

Column-name string arguments to arrange, filter, etc. would simply fall out of that for free (though they could also be optimized if necessary).

Thinking about this more, I'm worried about doing this. The main reason is that currently,
df >> mutate(twoA="a*2")

returns a dataframe with a column named twoA, filled with the string "a*2".
Being able to add strings into your DataFrame is clearly an important feature that we need to keep. What are ways to resolve this ambiguity? None of these sound good.

Put a function outside the string which tells dplython that the string should be evaluated, e.g. mutate(twoA=StrEval("a*2"))
Put some format inside the string that tells dplython what to do, e.g. mutate(twoA="EVAL: a*2")
Disallow the behavior of assigning strings to columns.

Okay, so that's just mutate. What about the other verbs? summarize has the same problem as mutate. arrange, dfilter, and group_by are more arguable. But now we're adding a behavior in a few functions that intuitively should work in all functions. A user can arrange by "carat" but can't mutate using "carat".
In summary, my main concerns are:

Adds complexity without a great benefit
Adds inconsistency-- users can refer to column names as strings in arrange but can't in mutate or summarize. This is what seems like the bigger problem.

If the solution is eval based then there are two options

Strings are strings so play with the quotes i.e mutate(newcol="'string'")
Define an identity function and make it a part of the execution environment so that mutate(newcol="I(string)").

    def I(value):
        return value

While the first option would work and would be unambiguous if all queries were strings that were eval'd, I think we would still want to support a non-eval option. So we need some way to distinguish between strings meaning "column with this string repeated" and strings meaning "column whose name matches this string"/"column with expression to be eval'd".
This is tricky. How common, though, is the use case of mutating to add a column with just a single string repeated? I don't think there'd be any other ambiguous cases. Why do you think summarize has the same problem?
Maybe just say that string arguments to mutate are interpreted as column names or expressions rather than vectorized strings, and force people who want to make a "foo" column filled with "bar" to wrap it using something like mutate(foo=repeat("bar")).

I don't know what the "right" style is, but in some of my dplyr code I definitely add columns that are one string. Sometimes I'll have a function output one DataFrame, generate a few DataFrames, add a str column to each one, and append them together.
My think has shifted to this: writing X.carat instead of "carat" is the same number of keystrokes-- same amount of effort. Sure, it looks a little strange and feels unusual at first. But dplython uses the Later everywhere, so if you're using dplython you should use Laters. I like there being One Way To Do Things, especially if supporting multiple ways of doing things means adding in more functions or more complexity.

Fair enough, although I'll note that the string evaluation method would save keystrokes on more complex expressions like mutate(cost="price / carat").

To fit with dplyr should be in the form select_, mutate_, group_by, etc. For example:
diamonds >> select(X.caret)

vs
diamonds >> select_("caret")


wkg oci push fails if the image ref contains any uppercase letters

https://github.com/WebAssembly/wasi-io/pull/94 was fun to debug - I'm not sure if this is a bug in wkg or a limitation of the OCI reference format?

I've run into this before 😕

I believe #40 was due to the remote, but this error was local to wkg?
At a minimum, a better error here from wkg would be helpful.

This is actually a requirement of the OCI Distribution spec, see the Pulling manifests section for full explanation. In short:

<name> refers to the namespace of the repository. ... Throughout this document, <name> MUST match the following regular expression:
[a-z0-9]+([._-][a-z0-9]+)*(/[a-z0-9]+([._-][a-z0-9]+)*)*

Yeah I think I agree with @joonas' comment on https://github.com/bytecodealliance/wkg-github-action/pull/5. We might be able to expose this as a flag, but not sure I'd just want to lowercase things automatically


Update curl dependency, remove M1 macOS build error note

Curl subversion 41 includes a workaround for the m1 macOS build error.
See https://github.com/rust-lang/rust/issues/90342#issuecomment-974698158

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

Thanks!
@bors r+

:pushpin: Commit 22ff7ac47c0e3a366637643c9cf38c61d649c10b has been approved by ehuss

:hourglass: Testing commit 22ff7ac47c0e3a366637643c9cf38c61d649c10b with merge 934bc6143eaab5d8cbffe93c74f60c833f7e85f3...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 934bc6143eaab5d8cbffe93c74f60c833f7e85f3 to master...


False variable not used alert when used inside promise chain

TypeScript Version:  3.7.5

Search Terms: variable not used promise
Code
let usedvar = 0
Promise.resolve()
.then(() => {
  usedvar++
})

Expected behavior:
No error detected
Actual behavior:
warn: 'usedvar' is declared but its value is never read
Playground Link: https://codesandbox.io/s/typescript-1uksf
The core code lies on line 23-26
Related Issues:

My bad. Right after openning this issue I found the link https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#write-only-references-are-unused
by removing the flags --noUnusedLocals and --noUnusedParameters the error is gone.


Support redis as an UFS of Alluxio

Is your feature request related to a problem? Please describe.
We use cloud native redis as a persist storage to store the date which produced by flink, and the data source of flink is a kafka topic.
Also, we develop an api service to provide the data which stored in the redis, and our user can get the data from the api service.
Describe the solution you'd like
Use Alluxio as a cache layer to enhance the locality.

Describe alternatives you've considered
Create a new module redis under the underfs module to support mount a redis ufs.
Urgency
Normal
Additional context
No

This is a pretty good proposal, and we have some concerns to consider:

Are Redis's key-value pairs updated frequently in your scenario? Will inconsistencies of metadata often occur in this case?
How much performance can be improved for caching Redis with Alluxio (as Redis is usually fast enough)?
Do you use the Redis key as the path of alluxio, and the value as the content of the file?

Will close it for now, feel free to reopen it and contact us if this is a strong request.


Add/manage compat entries

This PR

adds compat entries for some of our dependencies-- right now we're auto-updating to breaking versions. This should help us more easily manage upgrading deps.
Fixes cli flags for the long runs.

I used CompatDevTools to kick start the compat entries in examples/, and then applied synchronize_compats to the package directory.

bors r+


Cannot create an event without a workflow  in a random way

Sometimes the event editor cannot be closed when creating an event even if all required fields seem to be filled. The problem seems to be related under-the-hood to the hasWorkflow property, which is required in the schema. Indeed, when an event is created from a template without any workflow this field is hidden in the editor. It appears that this might cause the property not to be initialized to its default value (false) so that the validator complains.

Not reproduced for a while, possibly fixed in newer releases.


is it possible to disable hls.js support?

Hi Ron,
happy new year. :)
I still have the problem with mixed content on Android devices. If I have a hls streamed video and then a native mp4 file I have to click play again, because the mp4 video tag hasn't got a click event.
HLS seems to be supported natively on Android and IOS devices, so it is not needed to use the hls.js on this devices (my theory). So, is it possible, if I detect my site is running on an android devices, that I disable the hls.js support and use the plain player?
thanks in advance
Frank

This issue is already been solved; please download the latest version that takes care of detecting if browsers supports native HLS and let me know if it works for you

ah ok cool, I will check that.

Use the classPrefix: 'mejs-' in the configuration and use the mediaelementplayer-legacy.css style sheet. You should be fine with it

ok, I found the class prefix setting. Looks better now. :) Testing now the Android function.

I have still the same problem with the second click on the play button on Android devices.
You can test it here: http://toggo-elex2.beta.eoa.de/videos/eoa/videokategorie-neu-566.htm?v=d37e318da49e2a724b0130a31cd6e7f0&AdDevMode=1
First you see a short video clip "Werbung Anfang" (Start Ad) HLS Video, then the Ad mp4 and then "Werbung Ende" HLS Video.
After the first video clip I have to click on play again to start the mp4 file.
I checked out the version from the 3.x branch, I hope that was the correct branch.

The 2 tags is expected; we preserve the original node in the event we need to extract other info, like the original URL of the HLS source before it's been converted to BLOB by hls.js. Let me check the issue with the play button, but is the issue stated on this ticket resolved?

no it's not solved, sorry. I asked for nativ hls support on Android to use only 1 video tag on that device, to avoid the 2nd click problem.
On Android you can use the normal video tag with the video URL, the blob tag is not needed.
Then all videos run on the same video tag and you don't have to click on play again.

I see. Let me test one more time, because I tested on Safari (another browser that supports native HLS) and I didn't get the second video tag

I use a Huawei P8 with Android 6, a Nexus 9 with Android 7 and a Kindle Fire HDX 3rd Gen. with Android 4.4.2 -> all with Chrome as Browser.
A good way to test with Android devices is to connect your Galaxy via USB cable and open Chrome on your computer. Then you can do a remote debugging inside Chrome.

Perfect I appreciate your help. I'll check this and keep you posted

I just tested http://johndyer.github.io/mediaelement/ in my Android device and directly selected the HLS source. I see only a video tag

The website is using the latest version of 3.x-dev. I'm gonna try to use Browserstack to see if I can test your environment, but it shouldn't be different

I could test Nexus 9 with Android 5.1 and I see only a video tag

this source looks absolutely different, because it's 1 video tag with a seperate  and  tag.

It should you just need to use git checkout 3.x-dev inside the folder to change to that branch

tomorrow, I will check out the branch via git and test again. I had no idea that the zip file is not from the branch.
Thanks for you help so far. Tomorrow I will tell you the new result.

Sounds good; keep me posted

ok this morning I made a checkout of the 3.x-dev branch via GIT, but the code of the mediaelement-and-player.js is the same as yesterday. I used Winmerge to compare my files. Must be something other that is different.
I made only updates to the mediaelement-and-player.js file. Do I have to change something for the player initialization ?

the feature list looks fine so far:
cancelFullScreen:()
fullScreenEventName:"webkitfullscreenchange"
hasFirefoxPluginMovingProblem:false
hasMozNativeFullScreen:false
hasMsNativeFullScreen:false
hasMse:true
hasNativeFullscreen:false
hasTouch:true
hasTrueNativeFullScreen:true
hasWebkitNativeFullScreen:true
hasiOSFullScreen:false
isAndroid:true
isChrome:true
isFirefox:false
isFullScreen:()
isIE:false
isSafari:false
isStockAndroid:false
isiOS:false
isiPad:false
isiPhone:false
nativeFullScreenEnabled:true
requestFullScreen:(el)
supportsMediaTag:true
supportsNativeHLS:true
supportsPointerEvents:true
svg:true

oh is it possible, that my config is the problem?
var mediaPlayerConf = {
renderers: ['native_hls', 'flash_hls','html5'],
pluginPath: '../../rtli-video-player/mediaelement/3/',
enablePluginDebug: 0,
showPosterWhenEnded: true,
alwaysShowControls: true,
enableAutosize: true,
features: ['playpause','stop','progress','current','duration','volume','fullscreen'],
loop: false,
hls: {
debug: false,
autoStartLoad: false
},

oh found the problem. The renderers sorting is importing.
With this sort it works: renderers: ['html5','native_hls', 'flash_hls']

Glad you found the problem. So can you see the expected output in Android now?

yes, I have only one video tag now under Android. I have to check now all other browsers and iPhone again until I can put it to the live server. But the Android problem seems to be solved now. :-)

Sounds good. Let me know when you finish your tests so I can close this issue please

@ron666 I'm still in test phase, but I found out that the volume slide has a strange behavior on my website.
Can you see any reason for this?
Same testlink as before: http://toggo-elex2.beta.eoa.de/videos/eoa/videokategorie-neu-566.htm?v=d37e318da49e2a724b0130a31cd6e7f0&AdDevMode=1

Which browser are you testing so I can attempt to reproduce the issue?

I found the problem. I had to remove to top value in my css for .mejs-controls .mejs-volume-button .mejs-volume-slider .mejs-volume-handle
and for .mejs-controls .mejs-volume-button .mejs-volume-slider .mejs-volume-current

Oh I see what you are saying. So what you are seeing is if you slide up the bar goes down?

Gotcha. Any other issue?

hehe yes. It was a pilot like volume controller :-)
I think the testing procedure can take time until tuesday next week . I have to check the new version again with all possible browsers and that with Win10 and Win7 and Mac OSX.

After pressing on the play button the videoplayer removes the http:// from my original video soure entry. This is causing an error in my VideoPlaza SDK which need URL with http:// or https://

Ok let me check that

ah ok seems to be no problem in this case. The error come from something other in my Ad Player.

Can I see the issue in the same URL ?

Ah ok

Well keep me posted about any other issues and I'll wait for your final feedback

@ron666 Thanks, you can close the ticket. We double checked the player and it seems to work fine now on all our testsystems & browsers. :-)

You are welcome. Glad I could help you


Correct SVG definition in README

SVG is not "scalar vector graphic", it is "scalable vector graphic". 😉 (Reference)
Please correct README.md.

Thank you! Fixed in 105b6d566576f30021984161d8e60a29bfca5dbd


Italian translation missing

Hi I saw that Italian translation is missing, and to thank you for your amazing job I want to help you out in this. I've almost done the local one. One last check, and I'll make a pull request.
P.S. : I might need a little help cause I'm new in this

That'd be great! And yeah I can provide any assistance but its usually pretty straight forward to add a new translation, besides maybe a few minor things like updating the locale/language mapping

will close this out for now but excited for the PR :)

oh unless you wanted it open to close it with your PR

yeah I've followed a course about linking issue with a pr, that's will be great for me for learning. I'll update later

Oh ok great. yeah you can include "Closes #811" in the commit message and itll close it out when it gets merge and link the two -- kinda a neat feature


unable to connect from cloudera linux box

Hi ,
I am having trouble connecting from cloudera Linux box even after changing code to accept proxy host and proxy port in spark salesforce and salesforce wave api.
I wrote a another Simple Java code using below dependency which is connecting and getting data from sales force from cloudera Linux box.
not sure what else is going wrong ? can the author of the library help ?
  <dependency>
        <groupId>com.force.api</groupId>
        <artifactId>force-partner-api</artifactId>
        <version>22.0.0</version>
    </dependency>

Thanks
Sri

This issue seems to be related to your cluster configuration. Can you check whether you are using latest spark-salesforce package?

I had tried everything , I opted to test first with Java salesforce wave api it fails with connection refused error
Sent from my iPhone

On 12 Dec 2017, at 23:29, samuel-pt<EMAIL_ADDRESS>wrote:
This issue seems to be related to your cluster configuration. Can you check whether you are using latest spark-salesforce package?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.