feat(api): integrated wifi configurations with AMT profile

Codecov Report

Merging #318 (523b959) into master (7e92ebf) will decrease coverage by 0.37%.
 Consider uploading reports for the commit 2c6d807 to get more accurate results

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   44.67%   44.29%   -0.38%
==========================================
  Files          50       53       +3
  Lines        3040     3111      +71
  Branches      533      545      +12
==========================================
+ Hits         1358     1378      +20
- Misses       1505     1556      +51
  Partials      177      177

Impacted Files
Coverage Δ

src/RCS.Config.ts
100.00% <ø> (ø)

src/models/Rcs.ts
26.08% <ø> (ø)

src/repositories/mapToProfile.ts
33.33% <0.00%> (-16.67%)
:arrow_down:

src/repositories/profiles.ts
20.77% <11.53%> (-2.56%)
:arrow_down:

src/repositories/mapToProfileWifiConfigs.ts
33.33% <33.33%> (ø)

src/repositories/profileWifiConfigs.ts
33.33% <33.33%> (ø)

src/routes/admin/profiles/editProfile.ts
50.90% <33.33%> (-3.18%)
:arrow_down:

...ositories/factories/ProfileWifiConfigsDbFactory.ts
45.45% <45.45%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e92ebf...2c6d807. Read the comment docs.


added autoflow methods to compute the likelihood (and the prior)

As suggested by @pabloleon in #42

Current coverage is 98.30%

Merging #43 into master will increase coverage by +0.01% as of dd7a7ec

@@            master    #43   diff @@
=====================================
  Files           20     20
  Stmts         1057   1061     +4
  Branches         0      0
  Methods          0      0
=====================================
+ Hit           1039   1043     +4
  Partial          0      0
  Missed          18     18

Review entire Coverage Diff as of dd7a7ec

Powered by Codecov. Updated on successful CI builds.


ADD: Swap screen

In BEPSwap we can filter assets in dropdown

and I would suggest to do add same feature in ASGARDEX (we don't have currently).

In BEPSwap we can filter assets in dropdown

and I would suggest to do add same feature in ASGARDEX (we don't have currently).

nice idea! but lets create a separate task for filtering functionality for AssetSelect component?

nice idea! but lets create a separate task for filtering functionality for AssetSelect component?

Yep -> https://github.com/thorchain/asgardex-electron/issues/325


Utility to iterate over IPv4 space

One great feature of zmap is its ability to iterate (and then scan) the entire IPv4 space minus some blacklisted hosts without needing to keep track of what has or hasn't been scanned yet thanks to its internal cyclic generator.  Its ability to shard and break a huge set of random, discontiguous IPs into smaller shards/chunks for processing by distributed systems running zmap is very helpful from a scanning perspective.
It would be excellent to have this sharding-enabled, blacklist-aware cyclic generator exposed through zmap or as a separate utility that given a blacklist and an optional # number of shards, shard number and seed, will output the IPv4 addresses generated by this generator configured with this blacklist and shard information.  Such a utility could be useful for people doing studies related to the public IPv4 space, among other things.
zlist, ziterate or something similar sounds like a good name.

The documentation gives the command
zmap -p 443 -s 3 -n 10 --dryrun | grep daddr | awk -F'daddr: ' '{print $2}' | sed 's/ |.*//;'

which allows you to do exactly this. The IPs will be outputted to stdout which you can then pipe into a file or another program's stdin. You can use all the standard flags to set the black list, seed, number of shards, specific shard number, etc. You can also pass -c 0 to avoid having to wait for the cooldown.

Thanks @aaspring -- I had considered that route.  My primary concern with that being the solution is that there is so much more that is happening under the covers that this utility doesn't need -- building packets, calculating checksums, finding source IPs/ports to send from, etc.  I even wrote a new probe module specifically to work around this so that when run with --dryrun all it had to do was print out the source/destination IP and there was nothing at higher layers happening.

I have some WIP code that should do this.  Once I get it working or get to the point where I need help, whichever comes first, I'll throw up a PR.

I've got the guts of this done; I used the setup for zmap and zblacklist as my point of reference and modeled ziterate's building/usage/code after them.  My C is terribly rusty and this segfaults currently (see my comments in the code), but I feel like this is the right direction.
If anyone was interested in where this stands and/or could help with the segfault, see https://github.com/jhart-r7/zmap/tree/issue/333-ipv4-iterate-cyclic-zlist or
https://github.com/zmap/zmap/compare/master...jhart-r7:issue/333-ipv4-iterate-cyclic-zlist?expand=1


Shellcheck shebang

Check the first line of scripts to see if they have a shebang pointing at an interpreter supported by shellcheck. The file also needs to be executable.

Codecov Report

Merging #147 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   82.87%   82.94%   +0.06%
==========================================
  Files          34       34
  Lines        1647     1653       +6
==========================================
+ Hits         1365     1371       +6
  Misses        282      282

Impacted Files
Coverage Δ

lintreview/tools/shellcheck.py
55% <100%> (+7.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bad492...89b4803. Read the comment docs.


Reinitialize form fields

Codecov Report

Merging #19 (23cd1e3) into master (0a3ea90) will decrease coverage by 0.69%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   88.34%   87.65%   -0.70%
==========================================
  Files          11       11
  Lines         309      316       +7
==========================================
+ Hits          273      277       +4
- Misses         36       39       +3

Impacted Files
Coverage Δ

src/withForm.js
0.00% <0.00%> (ø)

src/formService.js
89.13% <50.00%> (-10.87%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3ea90...23cd1e3. Read the comment docs.


Restrict SpeciesList "Remove"

Displays "Remove" Observation buttons only to the SpeciesList creator (and in admin mode).
I noticed this morning that the show SpeciesList page has "Remove" Observation buttons visible to all users.
But they work only for the list owner. (Other users get "Permission denied" if they click the button.
This PR therefore displays the button only to the owner.

coverage: 94.41%. remained the same when pulling d1c9f0503d09afb895377ac8af760a830c07ac18 on jdc-list-remove-button into 16d8253162c883f21523aace2411c1a9b3eccc2e on main.


cmd/vet: -shadow false positive

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7.1 darwin/amd64

A sample code:
package main

import (
	"fmt"

	"github.com/pkg/errors"
)

func main() {
	var err error

	defer func() {
		// Rear the mistake here is just a local error in processing logic, does not belong to the end to unified handling errors
		if err := errors.New(""); err != nil {
			fmt.Println(err)
		}

		// Business logic mistakes need to deal with here
		fmt.Println(err)
	}()

	if err = errors.New(""); err != nil {
		return
	}

	if err = errors.New(""); err != nil {
		return
	}

}

Run the command go tool vet -shadow *.go to get :
sample.go:14: declaration of "err" shadows declaration at sample.go:10

I think there is no question of such code, in the main function in the defer if caused by using the local err statement.

Thanks for the report. The -shadow flag is known to have many false positives. That is why it is marked as experimental. I'm going to mark this as unplanned, meaning there are no concrete plans to fix it, but leave it open as a reference for any future efforts to reduce -shadow false positives.

Is it possible to somehow allow user to grant such false positives (such as the shellcheck disable directives)?

Any plans to fix this yet ?
It really seems unnecessary to me checking for error shadowing ...

Honestly I don't see why this is a false positive.  The inner err really does shadow the outer one.

It isn't a "false positive", and inner err indeed shadows the outer one,
it's just that it is very common to have code like from example above that isn't harmful in any way, and still one has to find out linter failing on it, and come up with another name for err to just satisfy the linter ...
have you seen any harmful shadowing with respect to error anywhere ?

I'm fine with coming up with some rule for when we should not report shadowing, but what should that rule be?  I don't think it should be "don't report shadowing if the variable is named err".

I agree with @ianlancetaylor , it is indeed a shadowing case. We can add a //nolint:govet to skip the checking.
In some other cases, like:
func() error {
  var err error
  {
      err := doSomething()  // Here maybe we want to use the error as the final returned error, if so, here is a bug
  }

  return err
}

Reporting shadowing err is useful, now I am using //nolint:govet to skip or use a different short name e instead of err.

@hitzhangjie This example do not build https://go.dev/play/p/KVsmDUICNui . It fails with ./prog.go:16:3: err declared but not used. Did you have a different example in mind?


Lumen support?

Would be nice.
Thanks.

+1

+1

+1

+1

+1

+1

how to install in lumen? thank you.

I've found a way to get it working in Lumen:

Install as usual (providers and aliases can be added to bootstrap/app.php)

Make sure your config/auth.php looks like this (model and table are required by Entrust):
'providers' => [
	'users' => [
		'driver' => 'eloquent',
		'model' => App\User::class,
		'table' => 'users',
	],
],

Configure as usual
If you get the error This cache store does not support tagging make sure you're not using the file cache provider. Instead set it to array in .env or config/cache.php.

Add models as usual

If you get errors like App\Role not found you need to create the Entrust config file. php artisan vendor:publish doesn't work in Lumen, so copy vendor/zizaco/entrust/src/config/config.php to config/entrust.php, modify it, and load it in bootstrap/app.php. This error occured because my models are in the App\Models namespace. Therefore I'm also using 'model' => App\Models\User::class in config/auth.php.
Hope it helps!

If anyone gets
[Symfony\Component\Console\Exception\CommandNotFoundException]

There are no commands defined in the "vendor" namespace.
Add:
composer require laravelista/lumen-vendor-publish
And then publish

Check this. It supports Lumen by default.

I trying to use this in my lumen. I follows all guides above.
but now i got error
Class 'Blade' not found

@ihsanberahim You've possibly skipped this part of step 2: https://github.com/mauvm/entrust/commit/394dbb71b997538e235fe711ab075d6f765a6736#diff-fd67755a24979e24a74dd15b4c30d112R62

thanks

@mauvm can you help with my issue here: https://github.com/Zizaco/entrust/issues/806 ?
thanks heaps.


Merge prTesting_201903121035 branch to master branch

OPS Build status updates of commit 7f2293f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Use sed's -E option to fix & simplify regular expression.

I ran into issues using the roslyn auto-install option. It appears to have been related to obtaining the version. I'm not entirely certain why this wasn't working, but using -E fixes the issue with the added bonus IMO of making the regular expression easier to read.
$ curl --silent "https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases/latest" | grep '"tag_name":' | sed 's/.*"\([^"]\+\)".*/\1/'
  "tag_name": "v1.32.18",
$ curl --silent "https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases/latest" | grep '"tag_name":' | sed 's/.*"\([^"]+\)".*/\1/'
  "tag_name": "v1.32.18",
$ curl --silent "https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/'
v1.32.18

How strange, both the variant with -E and without, work on my system.
[axvr@apollo ~]$ curl --silent "https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases/latest" | grep '"tag_name":' | sed 's/.*"\([^"]\+\)".*/\1/'
v1.32.18
[axvr@apollo ~]$ curl --silent "https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/'
v1.32.18

I wonder if this is caused by slightly different behaviour between sed variants or versions... I'm using GNU sed 4.5.
Nevertheless this change does work.

After some more testing I think the original sed command needed to be given the -e argument to work on macOS's BSD variant of sed.
curl --silent "https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases/latest" | grep '"tag_name":' | sed -e 's/.*"\([^"]\+\)".*/\1/'

However I don't have a mac so I am unable to confirm if this is the cause of the problem.

Since this line of code is being changed anyway we might as well change the cURL arguments from --silent to -Ss so that it still prints error messages and just suppresses the progress bar.

That's likely it. I'm on OS X, Mojave 10.14.4. The -e argument didn't seem to work for me:
$ curl --silent "https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases/latest" | grep '"tag_name":' | sed -e 's/.*"\([^"]\+\)".*/\1/'
  "tag_name": "v1.32.18",

Thanks for the contribution @kcboschert, and for testing it out @axvr


withdrawals outside the US, a.k.a. international payouts

Balanced will work for withdrawals to U.S. bank accounts, but not outside the U.S. What do we do here? Suggestions?
Current Status

MassPay—As a stop-gap while we await the chance to prioritize implementing a more robust solution, we are offering automatic weekly payouts via PayPal. This is risky because PayPal is likely to freeze our account once we get on their radar. If you'd like to participate, email<EMAIL_ADDRESS>with your Gittip username, PayPal email address, and the first eight digits of the API key from your Gittip profile page (to confirm your account). PayPal's fee is 2%, capped at $20.
Balanced—Our automated payments provider, Balanced, is working to implement international ACH transfers (IAT). Please see their roadmap and voice your interest on this ticket. Balanced is shutting down, see #3245.
Stripe—They've added payouts (à la Balanced), and are known to be working on expanding to the EU. See #3245.
Trans-Pay—The ball is in our court to improve our KYC practices (via #2449?) and circle back. See #417.
MangoPay—They're a European counter-part to Balanced. We would need a European legal entity and bank account. See #891.

Want to Help?
Give us a PR for multi-currency support. That's a pre-requisite no matter which direction we go.

So, are international SWIFT transfers supported currently or not?

+1 on https://gratipay.freshdesk.com/helpdesk/tickets/1709

We have upgraded PayPal from a stop-gap to a first-class payout method—in fact, it's now our only payout method (#3567). While not perfect, PayPal does provide more or less global coverage. Therefore, I'm going to take the opportunity to close this old and venerable ticket.
Looking at the other options in the description: the Stripe and MangoPay tickets got closed as part of the Balanced shutdown, because we ended up charting a roll-your-own course instead of using a prefab solution (see https://github.com/gratipay/gratipay.com/issues/3324#issuecomment-120163834 for discussion). Transpay is still on the table, to be revisited once we have a proper in-house anti-money laundering (AML) program. IAT and SWIFT are also options; those were in the works downstream of #3366, which fell through for (again) lack of AML.
Thanks, everyone! :-)

Second last link is broken. It should point to https://github.com/gratipay/inside.gratipay.com/issues/119.

(Thanks, fixed.)


Correcting a few broken links

Correcting a few broken links across a few pages

@modery : Thanks for your contribution! The author(s) have been notified to review your proposed change. @MSFTMAN, @MSFTMan, @msftman, @masisley

@modery : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MSFTMan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MSFTMan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MSFTMan : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Explicitly Handle RegExp

The first of these changes escapes regular expression special characters in given delimiter strings, so that they may be more intuitively taken literally (fixes #9).
The second change reintroduces the capability of using explicit RegExp delimiters for those users that still require that feature.

All of these three commits together obviously represent breaking API change, warranting appropriate versioning.
This final commit for this pull request, introduces the ability to specify HTML Safe custom delimiters (fixes #7). If only HTML Escaped custom delimiters are specified, or the HTML Safe custom delimiters are the same as the HTML Escaped custom delimiters, it defaults to outputting in HTML Safe mode (i.e. any HTML the custom delimited source outputs, is not HTML sanitized).


Update sdk to 8.2

Nuget for CRM SDKs
Refer Dynamics 365 SDKs

I could compile but I couldn't load the lpx. Could you do that?

I had to copy Microsoft.Xrm.Sdk 7.1.0 to the same folder as LinqPad. Does that work for you?

Is there any way to get rid of this dependency to Microsoft.Xrm.Client as there is no 8.0 version of it? I just want to use Microsoft.Xrm.Tooling, but I am unable to figure out a way to make CrmSvcUtil not depend on Microsoft.Xrm.Client.

I figured out a way to do this little differently using @daryllabar CrmSvcUtil extension. I will submit another PR soon for that, if you are OK with adding this assembly as a dependency.

@rajyraman not that I have any issues with you using the EBG extensions, feel free to do so, but I do question why you need to use them to not have a dependency on Microsoft.Xrm.Client.

I have to copy Microsoft.Xrm.Sdk.dll v7 to LINQPad executable folder to get this working without EBG
Using EBG gives me greater control on what to generate.
I can write queries like this

This is because I can generate the optionsets as well and use them right in my query, instead of fiddling around with formatted values.
The sad thing is I still need Microsoft.Xrm.Client.dll and Microsoft.Xrm.Client.CodeGeneration.dll during the code generation process, even though the generated code does not need it.

With the right settings, you could also do a.TypeEnum == workflow_type (without the casting)

The complied version I gave you shouldn't need those other dlls.

Got it. Much more convenient. Getting some error about duplicate enums when I try to generate for crm online. Will have to troubleshoot this.


readiness probe for kubernetes

Codecov Report

Merging #5 into master will decrease coverage by 1.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   71.42%   70.24%   -1.19%
==========================================
  Files           6        6
  Lines         119      121       +2
  Branches       14       14
==========================================
  Hits           85       85
- Misses         28       30       +2
  Partials        6        6

Impacted Files
Coverage Δ

index.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af67dd...46adcc1. Read the comment docs.


whats the difference with official mongoJS drivers?

they now have 2.1 + drivers that support promises etc. with so many differnet options it would help to know what the key points are.

The key point of mongojs is that it tries to follow the mongodb cli interface as much as possible :heavy_plus_sign: handling connection management for you.

There is code that overlaps some of the Mongo 2.1+ features.  For example, in cursor.js on like 52, we have
Cursor.prototype.toArray = function() ...
Is this intentional, or is it legacy code?  Would converting it to
Cursor.prototype.toArray = Cursor.prototype.toArray || function() ...
be a simple fix?
This should allow us to use the 2.1+ "Promise if no callback" feature without a lot of rewriting.  But I don't know if there would be cascade effect from making that change.

One notable difference is that the "promise-if-no-callback" feature is not supported.  (at least not for cursors)
Mongojs requires callbacks  for - near as I can tell - Cursor.prototype.*()

Although, the behavior of providing a promise when there's no callback is proposed in this PR
https://github.com/mafintosh/mongojs/pull/368


[bug] WindowBuilder is private struct, cannot create window

Describe the bug
follow the example described in WindowBuilder to create new window, it failed to start the application, due to the WindowBuilder is a private struct
https://docs.rs/tauri/2.0.0-rc.10/tauri/window/struct.WindowBuilder.html
let window = tauri::window::WindowBuilder::new(app, "editor")
|                                         ^^^^^^^^^^^^^ private struct
Reproduction

use the cli to create a new project
npm create tauri-app@latest -- --rc
follow the example described https://docs.rs/tauri/2.0.0-rc.10/tauri/window/struct.WindowBuilder.html add a setup
start the application using npm run tauri dev, build error will show up

Expected behavior
a new window will be created
Full tauri info output
[✔] Environment
    - OS: Mac OS 14.2.0 arm64 (X64)
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.80.1 (3f5fd8dd4 2024-08-06) (Homebrew)
    ✔ cargo: 1.80.1
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (default)
    - node: 20.16.0
    - yarn: 4.1.1
    - npm: 10.8.1
    - bun: 1.1.21

[-] Packages
    - tauri 🦀: 2.0.0-rc.10
    - tauri-build 🦀: 2.0.0-rc.9
    - wry 🦀: 0.43.1
    - tao 🦀: 0.30.0
    - tauri-cli 🦀: 1.6.1
    - @tauri-apps/api : 2.0.0-rc.4
    - @tauri-apps/cli : 2.0.0-rc.12

[-] Plugins
    - tauri-plugin-shell 🦀: 2.0.0-rc.3
    - @tauri-apps/plugin-shell : 2.0.0-rc.1

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: Vue.js
    - bundler: Vite

Stack trace
error[E0603]: struct `WindowBuilder` is private
   --> src/lib.rs:13:41
    |
13  |             let window = tauri::window::WindowBuilder::new(app, "label")
    |                                         ^^^^^^^^^^^^^ private struct
    |
note: the struct `WindowBuilder` is defined here
   --> /Users/jasonhao/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tauri-2.0.0-rc.10/src/window/mod.rs:113:1
    |
113 | / unstable_struct!(
114 | |   #[doc = "A builder for a window managed by Tauri."]
115 | |   struct WindowBuilder<'a, R: Runtime, M: Manager<R>> {
116 | |     manager: &'a M,
...   |
125 | |   }
126 | | );
    | |_^
    = note: this error originates in the macro `unstable_struct` (in Nightly builds, run with -Z macro-backtrace for more info)

Additional context
No response

If you want to use this API you need to add the unstable feature flag to the Tauri dependency in Cargo.toml
Are you perhaps looking for WebviewWindowBuilder instead? This is the "stable" API for usecases where you do not need multiwebview (in a single window) support.


#723: rename migration due to conflict

Issue Reference
This PR addresses the Issue : Fixes #
Summarize
Please, describe what the PR does, the changes you have made.

Also, mention the key points if any to look into while code reviews

Kindly ignore this PR.


Issue with stacking slides before react-slick is initialized…

https://github.com/akiran/react-slick/blob/master/src/inner-slider.jsx#L80
slick-initialized is hard coded and not set by any events.

How can you prevent stacking slides? Thoughts?
In kenwheeler/slick, slick-initialized is an event… so you can prevent FOUC.

Render slick slider only when you need.
slick-initialized won't be necessary in react

I need it immediately? or am I missing something?
I solved this the FOUC issue by…
componentDidUpdate() {
    this._slider_container.classList.add('initialized');
}

render() {
    return (

 (this._slider_container = c)}>...

    );
}

// styles

.slider-container
{
    display: none;

    .initialized &
    {
        display: block;
    }
}

You don't need to do that.  check this demo
https://jsfiddle.net/kirana/20bumb4g/
On Fri, Mar 4, 2016 at 10:54 AM, Carey Hinoki<EMAIL_ADDRESS>wrote:

I need it immediately? or am I missing something?
I solved this the FOUC issue by…
componentDidUpdate() {    this._slider_container.classList.add('initialized');
}
render() {    return (

 (this._slider_container = c)}>...
);
}
// styles
.slider-container
{
display: none;
.initialized &
{
    display: block;
}

}
—
Reply to this email directly or view it on GitHub
https://github.com/akiran/react-slick/issues/254#issuecomment-192110244.

I am thinking that it has to do with server side rendering. Since the DOM and images are already delivered.

I am not sure if slider can support server-side rendering well.
It does some math to compute dimensions of slides and slide-track based on container width, which is known only after rendering on browser

Not sure if this is related, but why is the first slide stacked in this example and is there a way to resolve it? :
https://jsfiddle.net/vddg2baj/2/

@chemoish I solve FOUC by using this technique:

on server side pass infinite: false and pass only 1 item to slick component
on client side pass  infinite: true and pass all the items to slick component

This way slick HTML received in the browser will have only 1 item to show and when slick component is initialized on the client side it will render all the items.

The issue has been fixed in previous releases. Please feel free to request reopen if disagree.


UI bug

When I create a post and submit it, the page does not refresh hence I cannot see my newly uploaded image immediately. When I try to refresh the page, it redirects me to the login page. When I try to debug it, it prints user name and first name both to be "null"

Hi Shweta,
In order to see the uploaded image you have to click on My Gallery to see the uploaded image. Auto refresh is not done for upload.
Thanks,
Uteerna

Hi Uteerna,
Yes clicking on the tabs works. However, it'd be nice to auto refresh it and avoid re-logging in on manual refresh.
However, I see that you've mentioned to add this in future so closing this issue.


Items don't correctly compact between breakpoints if there are gaps

Describe the bug
Responsive vertical compacting does not work correctly if there are gaps between items. See video below
https://user-images.githubusercontent.com/4933577/177338157-4cd075f5-b3ea-4175-8bcd-cb8e35a7a7ba.mov
However, if we fill up the gaps between with items, the items compact correctly
https://user-images.githubusercontent.com/4933577/177339310-d18c4f81-a387-4b2d-93df-f4aee47517c3.mov
I can verify that this is not just an issue that affects the example pages, but ResponsiveGridLayout in general, as I have faced similar issues in my own projects.
Your Example Website or App
https://react-grid-layout.github.io/react-grid-layout/examples/6-dynamic-add-remove.html
Steps to Reproduce the Bug or Issue

Go to https://react-grid-layout.github.io/react-grid-layout/examples/6-dynamic-add-remove.html (or any other page that uses responsive vertical compacting).

Follow a configuration like this (or similar, as long as there are gaps between grid items):

Transition between breakpoints and see how the grid items will not compact correctly, and will overflow the grid container.

Expected behavior
Even if there are gaps between grid items, the items should compact correctly between breakpoints and not overflow the grid container.
react-grid-layout library version
1.3.4
Operating System Version
macOS
Browser
Chrome
Additional context
No response
Screenshots or Videos
No response

reviving this issue because its still an ongoing bug

can confirm, i have the same problem in my project


feat(wallet): show node public address if set

Description:
Show the node public address if known to make it easier to share node
details with other users. Add the data in both the Node address text
field as well as the node address QR code.
Motivation and Context:
There is currently no way to see the public node address including the IP address and port.
How Has This Been Tested?

Start the internal node and verify that the node address shows ok
Connect to a custom node with external ip address set and verify that the ip address and port are included in the node address (text and QR code)

Screenshots (if appropriate):

Types of changes:
New feature
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage decreased (-0.01%) to 15.742% when pulling 2c194517eda95be8594532fbc065672e9e1a4978 on mrfelton:feat/node-public-address into fac45c9c96604982d5d3812082e927d9feff361b on LN-Zap:master.

Tested ACK 2c19451


[json-mapper] Support Type in JsonMapper

#1468

It's done, kinda dirty, but shows what this issue tries to address and how we could respond to it at some point


Select: Selecting items with arrow key does not work with multiple selects on one page

What happened?
If a page contains more than one select and the arrow down key is used to select an item, one of two things happen.
In case that the page contains two selects: The other select opens
In case that the page contains more than two selects: All selects open for a brief moment and directly close again.
This behaviour can be reproduced on the documentation page by copying the select component multiple times with the developer tools.
What type of frontend frameware are you seeing the problem on?
Angular
Which version of iX do you use?
2.0.1
Code to produce this issue.
// Happens on all select implementations.

Could you provide the code to reproduce this, on the latest version on the documentatio i cant reproduce it.

Cant be reproduced, if this still occurs, please create a new issue.


When tab is pressed buttons need to be highlighted when active

From @spherelot on March 19, 2015 11:46
This is a big issue when creating new ticket and tab is accidentally pressed. This results in that delete button is chosen and after that if space is pressed the ticket is deleted.
Copied from original issue: N4SJAMK/teamboard-feedback#81

This is because the dialog component does not wrap its content inside a form element. We can do something similar to components/dialog what we did with views/form.

I think this should be fixed by now?

Still problems with IE and Firefox Chrome working ok. More visibility around selected item also ? Now its blue...

Trello ticket created... new implementation...


cacheExpiration on the runtime cache - should we prevent?

At the moment this is valid:
workbox.routing.registerRoute(/\/images\//, workbox.strategies.cacheFirst({
  cacheExpiration: {
    maxEntries: 4
  }
}));

Reading this code for the first time you'd expect the rule to only apply to images, but that's not the case, it applies to all of the runtime cache. Should we require developers to specify a cache to enforce this behavior?

Yup, we should require that. If we didn't in v2 that was an oversight that we should fix in v3.


02.b-OAI-harvester.md

1. I have fixed the first table, but does it look like it's supposed to?
All but the GFZ example worked for me, for that I get:
GFZ Harvester
This harvest completed successfully. One or more records have been updated.
Time harvest began: Thu Dec 21 14:04:45 CET 2017. Harvest duration: 21 seconds.
Base URL: https://doidb.wdc-terra.org/oaip/oai
Request made for: All records.
This data provider: Supports date granularity by seconds; Has persistent support for deleted records.
Total number of records harvested: 0

The settings are like this:
**GFZ Harvester**
**Base URL:** https://doidb.wdc-terra.org/oaip/oai
**Harvested to:** /home/ubuntu/B2FIND-Training/oaidata/GFZ/SET_ALL
**Last harvest:** 0 files, Thu Dec 21 14:04:45 CET 2017
**Metadata format:**  oai_dc

I tried it both with  OAI subset = DOIDB.SEISNET and without

2. In order for the harvesting to working properly, I had to not only change the permissions for oaidata/fishproject-oai_dc/SET_1/xml, but also for all the parent directories, so basically, I had to do a chmod -R o+w oaidata/. Otherwise I could harvest once into the existing directory, but any attempt at harvesting again or updating was unsuccessful, and I'd get:
This harvest was not successful. Unable to delete harvest directory '/home/ubuntu/B2FIND-Training/oaidata/fishproject-oai_dc/SET_1/xml'

or
This harvest was not successful. Unable to create harvest directory '/home/ubuntu/B2FIND-Training/oaidata/fishproject-oai_dc/SET_1/xml'. No write permissions.

Is this just on my machine, or should we change the instructions?

3 I get this when I try to harvest with the command line, haven't played around with this one much, as I don't have an idea about what subset of the data I should specify.
ubuntu@b2find-test-vm:~/B2FIND-Training$ ./mdmanager.py --mode h -c fishproject --source  http://<IP_ADDRESS>:8181/oai/provider
|- Run mode:   	Harvesting
|- Start : 	2017-12-20 12:07:53

CRITICAL :   Option mdsubset is mandatory for harvesting

I think this part can be improved further. I'm just figuring out how each of these methods and functions works using trial and error, because the explanations are minimal. I think it's best if we provide the reader with a bit more details and direction. I will get back to it after I go through all modules once.

Harvesting GFZ with mdmanager.py:
ubuntu@b2find:~/B2FIND-Training$ ./mdmanager.py --mode h -c gfz --source https://doidb.wdc-terra.org/oaip/oai --mdprefix oai_dc --mdsubset DOIDB.SEISNET
|- Run mode:   	Harvesting
|- Start : 	2018-04-03 09:46:03

iterate through iterable does not work ?
	|- Iterate through records in 0 sec
CRITICAL :  [CRITICAL] Program is aborted because of a critical error! Description:
CRITICAL :  Traceback (most recent call last):
  File "./mdmanager.py", line 2018, in main
    process(options,pstat)
  File "./mdmanager.py", line 2083, in process
    process_harvest(HV,reqlist)
  File "./mdmanager.py", line 2124, in process_harvest
    results = HV.harvest(ir,request)
  File "./mdmanager.py", line 360, in harvest
    for record in records:
  File "/usr/local/lib/python2.7/dist-packages/sickle/iterator.py", line 146, in next
    mapped = self.mapper(item)
  File "/usr/local/lib/python2.7/dist-packages/sickle/models.py", line 141, in __init__
    ).getchildren()[0], strip_ns=self._strip_ns)
IndexError: list index out of range

Solution:
**Metadata format:**  oai_datacite

Then harvesting via web form works!


Version is not updated properly

Hello,
apparently, the version is not updated correctly.
The latest git tag present is: v21.03.0
Running the plugin today (we are in May), I expect the version to be v21.05.0
Instead, I get: v21.03.1
It seems that only the micro is bumped. The calendar part is ignored.
I would suggest refining the getIncrementedVersion function here.
I am using the latest versions:
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Here is the configuration of the .release-it.json file:
{
   "hooks": {
     "after: release": "echo ${version} > VERSION && echo ${latestVersion} > LATEST_VERSION"
   },
   "git": {
     "commit": false,
     "requireUpstream": false,
     "requireCleanWorkingDir": false,
     "tagName": "v${version}"
   },
   "npm": {
     "publish": false,
     "ignoreVersion": true,
     "skipChecks": true
   },
   "plugins": {
     "@csmith/release-it-calver-plugin": {
       "format": "YY.0M.MICRO"
     }
   },
   "verbose": 2
}

Please note that using the following versions, the plugin works properly:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Hey, thanks again for reporting. Please try 2021.5.7.
I'm basically trying to bump the calendar version first, and if it doesn't result in a new version. then micro is incremented.


chore: bump asset canister to 0.2.3 and ic-asset to 0.19.0 (🚧)

Description
updates dfx with the latest changes:

https://github.com/dfinity/agent-rs/pull/352
https://github.com/dfinity/agent-rs/pull/358
https://github.com/dfinity/certified-assets/pull/31 (0.2.2 release) + ic-wasm --output assetstorage.wasm assetstorage.wasm metadata --file assetstorage.did --visibility public candid:service
https://github.com/dfinity/certified-assets/pull/35 (0.2.3 release) + ic-wasm --output assetstorage.wasm assetstorage.wasm metadata --file assetstorage.did --visibility public candid:service

Closes https://dfinity.atlassian.net/browse/SDK-479.
Closes https://dfinity.atlassian.net/browse/SDK-473.
How Has This Been Tested?

created a new dfx project with assets, created .ic-assets.json file, deployed, fetched asset in the browser, and verified that the HTTP headers defined in config file are attached to HTTP response for the asset file

Checklist:

[x] run cargo build to update Cargo.lock (blocked by https://github.com/dfinity/agent-rs/pull/358)
[x] The title of this PR complies with Conventional Commits.
[x] I have edited the CHANGELOG accordingly.
[ ] I have made corresponding changes to the documentation. - please suggest a good place for that

@ericswanson-dfinity regarding e2e test: how would you advise testing the asset's headers? Should I construct some node script with agent-js to query the response headers for assets? e.g.
assert_command node get-asset-headers.js http://<IP_ADDRESS>:8000/?canisterId=ryjl3-tyaaa-aaaaa-aaaba-cai/logo.png
assert_match 'X-Allow-Origin: "*"'

Also, need help with fixing this:

source:

e2e: https://github.com/dfinity/sdk/blob/master/e2e/tests-dfx/deploy.bash#L47
code: https://github.com/dfinity/agent-rs/blob/6c8686fc5bd410451c2b660f31f947580208e792/ic-asset/src/sync.rs#L65

error - https://github.com/dfinity/sdk/runs/7237209576?check_suite_focus=true

@ericswanson-dfinity regarding e2e test: how would you advise testing the asset's headers?

Try curl -v.  There are other tests that use curl.

Also, need help with fixing this:

The canister is called hello_frontend now, not hello_assets

The canister is called hello_frontend now, not hello_assets
I think the e2e error is unrelated to canister name

Try curl -v. There are other tests that use curl.
I couldn't find any tests using curl: https://github.com/dfinity/sdk/search?q=curl
Also, I don't think it's currently possible to fetch the asset from the asset canister directly via HTTP (i.e. without agent-js) - tried it some time ago and didn't work, but maybe I was doing something wrong

wow, it is the worst

ah, I see, seems like the filename needs to go first in the url for this to work


Upgrade Datafusion to v37.1.0

NOTE: While each commit is a self-contained "logical" change, the project needs all the commits to compile.
Which issue does this PR close?
Closes #663. (hopefully)
This is a cleaned up version of #662.
Importantly, the final failing test is not commented out, so there is 1 failing test.
The error and test case are highlighted in this commit from previous PR: https://github.com/apache/datafusion-python/pull/662/commits/ecff35793e918a3dbdaf9220670d1ca5892b48d3
What changes are included in this PR?

Upgrades the dependencies
All minimal ports for the code to compile and all tests (modulo one failure) to pass
It does not answer the API questions highlighted in the #663. All choices were w/ the goal of "getting to passing tests".

Are there any user-facing changes?
Much of  src/functions.rs have been updated per the upstream epic: https://github.com/apache/datafusion/issues/9285

One follow-on that I'd like to do is parametrize  test_array_functions().
I didn't want to alter the test-cases unnecessarily while doing the upgrade.

Note this also closes #656 , #655,  #654, #652, #651, #650 and #649


Null safety

Please can you make it compatible with flutter null safety.
Thank you.

Hope it could be done too !
Great work by the way !

Sorry for the delay in answering this. I'll be reviewing everything in the next days.

I fixed the null safety issues.
Please use version 0.1.2.
Again, I'm sorry for the delay!


With fixes from master branch
7f3dd65e5dc79cc456ef58a052501ec256d5070b all tests are OK.


Shorten paths in stack traces

Update metalog to 2.2.0
Pass home argument to metalog

Closes: https://github.com/metarhia/impress/issues/1228

Landed in https://github.com/metarhia/impress/commit/db2e19daab9ae40b7b3d0aac466cde5c1cac7670


ddf.to_parquet(append=True) error when file not existing

When I try to save to parquet with append = True, in the first time (the file is absent), I get an error, I fixed it using this code
append = False
if os.path.exsists(file):
    append = True
ddf.to_parquet(append = append)

Is it a good idea to create a pool request with this code inside the to_parquet method?
Thanks.

Just want to chime in to say I do the same thing and would appreciate this change.


Latency

This is my config for Nexus 5 running Android 11, stock kernel 6.0.1

Hi! I appreciate this but it would be better to put in a separate fork, since it gives me a lot of notifications.

Hi, i'll did it. Thanks for advise
On Sunday, July 25, 2021, Tyler @.***> wrote:

Hi! I appreciate this but it would be better to put in a separate fork,
since it gives me a lot of notifications.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tytydraco/KTweak/pull/19#issuecomment-886204088, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQTREYVVL53DYPKDKPDGN33TZQIGZANCNFSM45HHHC3A
.


Restoring from GCS takes too long

Hello,
I'm trying to restore a postgres basebackup from Google Cloud Storage to Google Compute instance in the same zone.
I cannot figure out why, but pghoard_restore command needs ~106m to download and extract basebackup 18GB of size (48GB original size) while gsutil takes ~3 minutes only to download the same file.
During pghoard_restore avg network throughput is ~40MBit/s while gsutil turns it to 1.1GBit/s.
What am I doing wrong? How can I tune the restore process somehow?
Pghoard config:
{
    "backup_location": "./metadata",
    "backup_sites": {
        "postgres-01": {
            "active_backup_mode": "pg_receivexlog",
            "basebackup_hour": 5,
            "basebackup_interval_hours": 24,
            "basebackup_minute": 40,
            "pg_data_directory": "/var/lib/pgsql/9.5/data",
            "nodes": [
                {
                    "host": "postgres-01",
                    "user": "pghoard",
                    "password": "secret",
                    "port": 5432
                }
            ],
            "object_storage": {
                "storage_type": "google",
                "project_id": "postgres-dev",
                "bucket_name": "test-pghoard"
            }
        }
    }
}

Restore command:
pghoard_restore get-basebackup --config pghoard.json --recovery-target-time 2019-07-04T14:45:03+00:00 --restore-to-master --overwrite --target-dir /var/lib/pgsql/9.5/data/

Output:
Found 1 applicable basebackup

Basebackup                                Backup size    Orig size  Start time
----------------------------------------  -----------  -----------  --------------------
postgres-01/basebackup/2019-07-09_05-39_0     17687 MB     48779 MB  2019-07-09T05:41:38Z
    metadata: {'backup-decision-time': '2019-07-09T05:39:45.442175+00:00', 'backup-reason': 'scheduled', 'normalized-backup-time': '2019-07-08T05:40:00+00:00', 'start-wal-segment': '000000040000C1120000009E', 'pg-version': '90504', 'compression-algorithm': 'snappy', 'compression-level': '0', 'original-file-size': '51148804096', 'host': 'postgres-01'}

Selecting 'postgres-01/basebackup/2019-07-09_05-39_0' for restore
2019-07-09 16:08:09,4699ChunkFetcher7687Thread-1        INFO    Processing of 'postgres-01/basebackup/2019-07-09_05-39_0' completed successfully
Download progress: 100.00% (17687 / 17687 MiB)
Basebackup restoration complete.
You can start PostgreSQL by running pg_ctl -D /var/lib/pgsql/9.5/data/ start
On systemd based systems you can run systemctl start postgresql
On SYSV Init based systems you can run /etc/init.d/postgresql start

PGHoard uses single connection to download the entire file, while gsutil apparently fetches different parts of the file with separate connections. We will probably at some point be looking into utilizing multiple connections in PGHoard as well to speed up downloads of individual large files. If you're running PGHoard on the same host as the PostgreSQL server itself you could consider using the local-tar option for basebackup_mode, which creates multiple smaller files instead of single very large files. Those files are downloaded concurrently, resulting it much higher restore speed.

hi, any progress on this?
this issue is preventing me from using this awesome tool on production.
thanks

We have no plans to work on this since we recommend people to use local-tar backup mode in which case the parallelism already works as you'd expect.


Added a brief example of deploying contracts with linked libraries.

Added a documentation folder with a LinkingLibraries markdown file that has a brief example of deploying contracts with linked libraries.

Thanks @Alexangelj !

My first contribution that was merged, ever! When I have more time, I plan on adding some more docs since I've dealt with a lot of buidler-deploy stuff so far.


can this decode a bitmap?

Description of the problem:
Which library version are you using? E.g. 3.2.0.
Which phone/tablet are you using, and which Android version does it run? (e.g. Samsung Galaxy S5,
Android 5.0)
Does the same happen on other devices or an emulator?
Can you reproduce the issue in the sample project included with the library? If not, can you
provide your own sample project or sample code that produces this error?
In the case of an error do you have a stack trace or adb logs?

Hi, can this decode a bitmap directly? thanks

The majority of this library is around interfacing with the camera. If you just need to work with bitmaps, you can use zxing:core directly for the most part.


Support layout options

Allow layout options to be set using api.setOptions
goFullScreen
showLeftPanel
showDownPanel
showSearchBox
downPanelInRight

@arunoda can you check this one out?


Fix typo in scheduler-concept.adoc

An example used a comma instead of a /

Thank you for your contribution. Please complete the contributor's agreement as described at https://github.com/mulesoft/docs-connectors/blob/latest/README.adoc to register as a contributor so that we can accept your pull request.

Hey @george-hoffer  - I have read the agreement and agree with the terms, but it doesn't specify how to agree

closing and replacing with PR https://github.com/mulesoft/docs-mule-runtime/pull/830


Get UNIXCONFDIR from environment first, fallback to /etc fixes #149

fixes #149

Thanks. Can you please add a test for that?


Add support for mutransfer

We should add support for mutransfer: https://github.com/microsoft/mup
Appears non-trivial, but not as difficult as MoE. We'd have to modify the model itself. https://github.com/microsoft/mup/blob/main/examples/Transformer/model.py appears especially relevant. A good workflow would be:

[x] Run mutransfer transformer example to gain familiarity with how their codebase behaves.
[x] Make necessary changes in gpt-neox/megatron/model/ to use mup. Probably mostly in transformer.py
[x] Add muSGD and muAdam to gpt-neox/megatron/optimizers.py
[x] Update gpt-neox/megatron/training.py to allow previous features to be selected during training
[x] Add neox_args to choose the options in step 4
[ ] Test and add example config

nsarka/mup-support has my changes for this so far. I haven't tested it.
There's one more thing to add to this list. Mup can generate a plot that's helpful for checking the correctness of the implementation. https://github.com/microsoft/mup#checking-correctness-of-parametrization

[ ] Add args for saving coord check plot

nsarka/mup-support has my changes for this so far. I haven't tested it.
There's one more thing to add to this list. Mup can generate a plot that's helpful for checking the correctness of the implementation. https://github.com/microsoft/mup#checking-correctness-of-parametrization

[ ]  Add args for saving coord check plot

Great work! Thank you for this contribution ^_^
Don’t forget to add yourself as a library contributor in the readme as well 😉

Thanks Stella! I added myself as a contributor in the draft PR here https://github.com/EleutherAI/gpt-neox/pull/704 :)

Closed as completed by #704


read upper-case PORT environment variable

To the best of my knowledge environment variable names are, by convention, in upper-case.
In addition, in some environments, such as in Heroku (the popular PaaS), the aforementioned convention is followed.
I believe it would be better if this convention is followed.
The issue that arises though, should such a change be adopted, whether it is backward-compatible or not.
I suggest that it is backward-compatible.
Namely, this change would suffice:
diff --git a/src/app.js b/src/app.js
index 7d3193d..cbfeffc 100644
--- a/src/app.js
+++ b/src/app.js
@@ -11,7 +11,7 @@ import fs from 'fs';
 import Room from './room';

 const $CONFIG = {
-  port: process.env.port || 3000
+  port: process.env.port || process.env.PORT || 3000
 };

 const app = express();

Do you have any other considerations?
PS: I have a PR ready, but I thought it would be better if I opened an issue first.

Sure thing, send a PR over. I know AWS requires the same format.


'SigMeshOC/SDKLibCommand.h' file not found

I tried to import your lib into my Project.
But when i build for ios, i got a bug. Please check and support me if you can.
'SigMeshOC/SDKLibCommand.h' file not found

As README.md said:
Open SigMeshOC/SigMeshOC.xcodeproj by Xcode, in 'Signing & Capabilities' of Target 的 'SigMeshOC', choose Team to your Apple ID, then close Xcode and:
cd node_modules/react-native-btsig-telink/SigMeshOC/
./Script.sh

results:
SigMeshOC/Build/Products/SigMeshOC/Release-iphoneos/SigMeshOC.framework/


Backport "Add the -Wall option that enables all warnings (Plan B)" to LTS

Backports #20577 to the 3.3.5.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to backport-lts-3.3-21857.
Reference


Swift Package Manager Support

This PR adds minimal Package.swift file for SPM.

Should we also run swift package test on CI?

I didn't add any test target in Package.swift. Should I add test target?

Ok

Can you please merge this?


An asset, material and scene system

Make an asset, material system and a scene system. The asset system should contain pipelines, images, sound, loading files, compressing and decompressing of image, sound and etc. files. The Material system should take the assets and wrap around them for ease of use. The scene system will then take the binding commands send out by the materials, pass them through a quick sorting algorithm and send them to the renderer
Exact details are on a diagram on a poster hung over my PC
Pretty complicated stuff

long done


Fix panic() in isUUID()

value with value.Kind() == reflect.Slice does not have value.Type().Len()
#708 is incomplate fix. I'm sorry.

Thank you for your PR.


fix(build): enable tsProject parameter to allow integrated monorepos …

…support (nx)
Integrated monorepos such as NX use tsconfig files to separate projects (and jest) instead of package.json's.  This means that tamagui-build fails to find the correct the tsconfig file and you cannot specify it manually.
Adding this parameter --ts-project to the build tool allows you to use tamagui-build inside an nx monorepo but doing the following in the project.json:
"build": {
      "executor": "nx:run-commands",
      "options": {
        "command": "tamagui-build --ts-project ./tsconfig.lib.json ",
        "cwd": "libs/ui"
      }
    },
    "watch": {
      "executor": "nx:run-commands",
      "options": {
        "commands": [
          {
            "command": "tamagui-build --ts-project ./tsconfig.lib.json --watch",
            "cwd": "libs/ui"
          }
        ]
      }
    }

looks good, thank you

@jcbdev Do you have an example repository with nx and tamagui working well together ?
I struggle to setup it


[Tagging] Save_as dashboard is very slow because of tagged_object table updates

In airbnb we have around 9000 dashboards and over 100,000 slices.
Expected results
When user save_as a copy of a dashboard, the action should finish in a couple of seconds.
Actual results
It took 90 seconds to copy a dashboard with 90+ slices.
Screenshots
When calling /copy_dash API, I found following db operation is very slow:
SELECT tagged_object.id AS tagged_object_id  FROM tagged_object INNER JOIN tag ON tag.id = tagged_object.tag_id  WHERE tagged_object.object_type = 'chart' AND tagged_object.object_id = 150283 AND tag.type = 'owner'
How to reproduce the bug

Create a large dashboard
Click Save as button from dashboard header dropdown menu
Choose Save as

Environment
(please complete the following information):

superset version: lastest
python version: Python 3.6.1
node.js version: v10.15.3
npm version: 6.4.1

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
@betodealmeida

Adding an index on TaggedObject.object_id should really help.

@mistercrunch @betodealmeida we have the tags feature turned off but this query is still executing, if this feature is behind a feature flag it should ideally not be affecting us. It's timing out when saving large dashboards, so some users are unable to save dashboards.

This is happening because of the event listeners here right? I don't know the feature very well, can we put these behind the feature flag and create a script in cli to update the tags tables if someone wants to turn the feature on in the future? @betodealmeida

@michellethomas you're right. I'm working on a fix, sorry for the trouble.


.gltf & .dae & .fbx & .glb Disappear on phones without snapdragon chipset.

Godot version
4.1 & 4.1.1 * 4.2 dev3
System information
Windows 10, AMD Ryzen 7 5700X 8-Core Processor, 3070
Issue description
I have a wired problem in my game, any Chipset except Snapdragon have problems in rendering my character, the character disappears or glitch.
It happens when closing the game and starting it again, and cannot be fixed until deleting the game from the phone and installing it again.
This is the game, if you have a phone with a Mediatek chipset or Exynos you can try it and see the error by yourself: https://play.google.com/store/apps/details?id=org.godotengine.OnlyUpLite
I tried exporting it with Godot 4.1 & 4.1.1 & 4.2 dev3, and I tried all of the Godot renders backends, and even I tried changing some of the import settings of the model.
the entire game is fine only the player model has this issue, when I changed it with a box from the same engine it doesn't disappear, so it's only the imported model problem (it's an FBX model, and I tried also .gltf & .dae & .fbx & .glb)
the only format that worked it's .obj, but I want the ANIMATIONS !!
https://github.com/godotengine/godot/assets/96385910/38a472c2-e44c-45dd-ba38-b26c2b7c4b80

Steps to reproduce
1- import any .gltf & .dae & .fbx & .glb to Godot.
2- make a simple scene and put the imported model.
3- export it for android
Minimal reproduction project
the file is big so i upload it to wetransfer.
https://we.tl/t-rDOMe3R5sn

we.tl/t-JVtZUokNM

That link doesn't appear to work.

@Calinou updated the link

@Calinou I tried your way before and it didn't work, I tried it now, and also it didn't work :(

This sounds like an issue with the shader cache. I'm surprised it happens with both Mobile and Compatibility rendering methods though.

@sopdevv I'm very concerned by the unauthorized use of the org.godotengine prefix for your game.

@sopdevv I'm very concerned by the unauthorized use of the org.godotengine prefix for your game.

That's the default app id when users don't specify one, it's ok.

Could someone take a look on it? Looks like a real blocker for android apps which used skinned meshes (skeletons). Even box with one bone will be broken in case of more than one launch of application on device.

@sopdevv maybe caused by Shader Cache: https://github.com/godotengine/godot/issues/82419
I provisionally solved it like this (while the bug is not fixed): https://github.com/godotengine/godot/issues/82419#issuecomment-1736617963

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/82419, as this is due to the same cause.


Microphone button is disabled/greyed after sending the first message

Copied from ticket.

Version
What version of the Emulator are you using?

Not mentioned in the ticket.

Describe the bug
Customer has added speech functionality to Bot. When they test the Bot with Web Chat, they do not see any issue. But when testing the Bot with Emulator (v4), the customer sees that the microphone icon gets disabled (greyed out) after sending the first message to the Bot, irrespective of whether the message is sent as text by typing or using Voice.
To Reproduce

The customer's Bot code's speech functionality works as expected with Web Chat.

The microphone icon is getting grayed out when testing the Bot on Emulator.

Even if the first message to the Bot is sent in text, the microphone icon is getting grayed out.

Created a new Bot, integrated Direct Line Speech channel to the Bot and tested the Bot on emulator. Even for this new Bot, we were seeing the microphone icon getting grayed out.

Expected behavior
N/A
Additional context
The customer wants to know if this is by design for Bot Framework Emulator (v4). If this is an issue, he wants help in identifying the cause an fixing it.
[bug]

After doing some investigation, I'm able to reproduce this issue in the latest version of the Emulator.
I'm currently looking into the code to see if I can identify the bug on our end.

It looks like the call to the BingSpeech synthesis API errors out with a 401 in Emulator because the key we use is not compatible with the syntesis API. This means that Web Chat is stuck waiting for the synthesis step to complete -- which it never does -- and disables the microphone button in the process.


fix(tools): update cem deps

Updates dependencies

custom-elements-manifest.ts:4:32 - error TS7016: Could not find a declaration file for module 'cem-plugin-readonly'. '/Users/sps/Sites/_pattern-fly/pfe2/node_modules/cem-plugin-readonly/index.js' implicitly has an 'any' type.
Try npm i --save-dev @types/cem-plugin-readonly if it exists or add a new declaration (.d.ts) file containing declare module 'cem-plugin-readonly';
4 import { readonlyPlugin } from 'cem-plugin-readonly';
Found 1 error.

On npm ci

I think this is my fault in cem-plugin-readonly. taking a look...

@zeroedin can you try again please (i force-pushed)

@zeroedin can you try again please (i force-pushed)

npm ci now is functioning as expected.


Disable invariant assertions by default

Related to matrix-org/internal-config#1434

Codecov Report
Patch coverage has no change and project coverage change: +2.91 :tada:

Comparison is base (41955f0) 86.86% compared to head (d4f54eb) 89.77%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #685      +/-   ##
============================================
+ Coverage     86.86%   89.77%   +2.91%
============================================
  Files           143       78      -65
  Lines         16196    13495    -2701
  Branches        761        0     -761
============================================
- Hits          14068    12115    -1953
+ Misses         1940     1380     -560
+ Partials        188        0     -188

Flag
Coverage Δ

uitests
?

uitests-android
?

unittests
89.77% <ø> (+2.11%)
:arrow_up:

unittests-android
?

unittests-ios
?

unittests-rust
89.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 65 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


rspec-puppet-init

Hi @rodjek
Sorry to bug, but another question.
When running rspec-puppet-init from within a brand new module without the spec directory, I get:
  Unable to setup rspec-puppet automatically in a control repo
 /usr/share/ruby/fileutils.rb:1145:in `initialize': No such file or directory - spec/fixtures/manifests/site.pp (Errno::ENOENT)
        from /usr/share/ruby/fileutils.rb:1145:in `open'
        from /usr/share/ruby/fileutils.rb:1145:in `rescue in block in touch'
        from /usr/share/ruby/fileutils.rb:1141:in `block in touch'
        from /usr/share/ruby/fileutils.rb:1139:in `each'
        from /usr/share/ruby/fileutils.rb:1139:in `touch'
        from /home/sgerasenko/.bundle/ruby/gems/rspec-puppet-2.6.7/lib/rspec-puppet/setup.rb:124:in `safe_touch'
        from /home/sgerasenko/.bundle/ruby/gems/rspec-puppet-2.6.7/lib/rspec-puppet/setup.rb:16:in `run'
        from /home/sgerasenko/.bundle/ruby/gems/rspec-puppet-2.6.7/bin/rspec-puppet-init:20:in `<top (required)>'
        from /home/sgerasenko/bin/rspec-puppet-init:17:in `load'
        from /home/sgerasenko/bin/rspec-puppet-init:17:in `<main>'

Thank you!
I think that's because FileUtils.touch won't create intermediate directories when trying to make spec/fixtures/manifests/site.pp.
When I do create all the necessary directories, I get:
Unable to setup rspec-puppet automatically in a control repo
 + spec/fixtures/manifests/site.pp
 + spec/spec_helper.rb
 + Rakefile

What does that error about "control repo" mean?

Control repo refers to the common pattern of having a version controlled repository that is deployed to your puppet master. This is very different to a module repository and unique to each user/company, so rspec-puppet-init doesn't attempt to do an automatic setup.
rspec-puppet-init determines if the current working directory is a module or not by looking for a metadata.json file. Your new module didn't have one, so it assumed that it was running inside a control repo. I'll update the error message to make it more clear what's happening and prevent it from trying to create the files.


More privacy: prevent sending even df.head(1): only columns and dtypes

Problem
Current code sends df.head(1) to the LLM, which can be a 3rd party. This can be undesirable for certain use cases in which organizations or stakeholders don't want to risk compromising privacy of their data.
Solution
The relevant info that the LLM needs is more related with column names and column types than any specific instance of those. In my experience, the performance of the agent is not hurt by this change.

Problem
Current code sends df.head(1) to the LLM, which can be a 3rd party. This can be undesirable for certain use cases in which organizations or stakeholders don't want to risk compromising privacy of their data.
Solution
The relevant info that the LLM needs is more related with column names and column types than any specific instance of those. In my experience, the performance of the agent is not hurt by this change.

Thank you, nice contribution. I am going to merge it.
I have not touched the code for a while. I am going to update it to be compatible with OpenAI client library version >1.0.0, and your changes will be included in the new PR.

Nice to hear about the upcoming upgrade @pgalko !
I would encourage you to keep it up on this repo! Last week I researched what's out there on Pandas natural language APIs, and your project was definitely the best fit for me. Particularly good in the performance/lightness trade-off.


Fix StableID queue

Describe the pull request:

[X] Bug fix
[ ] Functional change
[ ] New feature
[ ] Code cleanup
[ ] Build system change
[ ] Documentation change
[ ] Language translation

Pull request long description:

StableIDs should be v1.stabelIDs not a subqueue fo v1.files,
Changes made:

Related issues:

Additional information:

Release note:

Documentation change:

Mentions:

@jonandernovella, it's the name of the queue, which is used by bindings, federations, shovels, etc.


Database WIP

Codecov Report

Merging #513 (568520c) into main (d3ac95e) will decrease coverage by 0.82%.
The diff coverage is 61.57%.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   70.73%   69.91%   -0.83%
==========================================
  Files          90      101      +11
  Lines        4935     5106     +171
  Branches      986     1013      +27
==========================================
+ Hits         3491     3570      +79
- Misses        765      852      +87
- Partials      679      684       +5

Impacted Files
Coverage Δ

...com/alexvanyo/composelife/database/UpsertHelper.kt
0.00% <0.00%> (ø)

...lexvanyo/composelife/database/di/DatabaseModule.kt
0.00% <0.00%> (ø)

...nyo/composelife/wear/GameOfLifeWatchFaceService.kt
0.00% <0.00%> (ø)

...xvanyo/composelife/model/CellStateSerialization.kt
55.98% <8.51%> (-11.71%)
:arrow_down:

...exvanyo/composelife/model/DeserializationResult.kt
50.00% <50.00%> (ø)

...com/alexvanyo/composelife/database/CellStateDao.kt
50.00% <50.00%> (ø)

...xvanyo/composelife/data/CellStateRepositoryImpl.kt
52.63% <52.63%> (ø)

...otlin/com/alexvanyo/composelife/model/CellState.kt
69.81% <60.00%> (ø)

...lin/com/alexvanyo/composelife/test/BaseHiltTest.kt
75.00% <66.66%> (-0.68%)
:arrow_down:

...lin/com/alexvanyo/composelife/ui/ComposeLifeApp.kt
79.78% <87.67%> (+18.02%)
:arrow_up:

... and 15 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


When a non-existent team or event is put into the URL, It should 404

Currently, if you change the event code or team number in the URL to something other than an existent one, the web app just displays an awkwardly empty page.  This should be set to a 404 error page not found or something of the like.

Done in latest code change.


Save weights of MultiLayerNetwork for importing in other models

Issue Description
Is there a way to just save the weights in a text file in the form of an array after training? I've imported a KerasModel and would like to save its weights in the form of a java equivalent NumPy array in a text file.
The context is I would like to prune my model for other hardware platforms like GPUs, ARM devices and FPGAs and retrain it a number of times before deploying
Version Information
Please indicate relevant versions, including, if relevant:

Deeplearning4j version - 1.0.0-beta7

@utri092 you can access the weights with model.params(). From there, you can use any of nd4j's methods. Please use https://community.konduit.ai for further questions of this nature.


Support escaped dollar for literal dollar sign

The MathJax configuration in this project has processEscapes set to
true. This means that in the text, \$ can be used to represent a
literal dollar sign. However, prior to this change, this project was not
parsing for these \$ tokens and treating them differently.
So something like \$ 1 + 1 = 2 $ could be considered to be a single
token to be kept intact for MathJax. With this fix, \$ would be
considered a single token to be kept intact for MathJax (which in turn
would treat it as a literal dollar sign) and  1 + 1 = 2 $ would be
considered Markdown text.

Pull Request Test Coverage Report for Build 44

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 40:
0.0%

Covered Lines:
103

Relevant Lines:
103

💛  - Coveralls

@susam I tested your branch and there's a seemingly undesired case when tokenizing input like:
'markdown text \$ markdown text'

It results in the \$ getting tokenized as TeX instead of the entire string being one Markdown token.
I believe we can fix this issue by introducing a small new layer of tokenization in the tokenize function:

Create a new mask for an escaped dollar sign, ESCAPED_DOLLAR.
At the beginning of tokenize mask all occurrences of \$ with ESCAPED_DOLLAR.
Tokenize as per normal.
At the end of tokenize, replace de-mask ESCAPED_DOLLAR in all tokens with $ (if Markdown token) or \$ (if TeX token).

I can work on this today if you think this is reasonable.

Hi @IgorBelyayev,
Escaped dollar, i.e., \$, being tokenized as a MathJax TeX token is intentional. The intention here is to present \begin{...}...\end{...}, \[...\], \(...\), etc. along with \$ tokens to MathJax intact.
If we write an HTML page containing \$ loading plain vanilla MathJax, for example,
<!DOCTYPE html>
<title>MathJax Demo</title>

text \$ text

we would see that MathJax interprets and renders \$ as a literal dollar. MathJax generates this HTML DOM out of the above input:

text $ text

Since MathJax recognizes and renders the \$ token even when \$ is part of regular text, we give priority to MathJax while deciding whether MathJax or CommonMark parser should see the token.

@susam I understand the rationale, but if we do want to use a dollar sign in Markdown, how should we do it?

@IgorBelyayev,
The answer to your question is the same as what we would do while writing a simple HTML page that loads MathJax.
In a simple HTML page, if we want to use a $-sign where it could be confused as a math delimiter, we escape it with backslash. For example,
I need \$5 and $10 bills.

We have to do the same thing if we want to use a $-sign in Markdown if it could be confused as a math delimiter.


asciimath stem doesn't render

Hey, this is probably an issue on my end but I have no idea what. I installed Asciidoctor Mathematical like the instructions said, I wrote :stem: at the top of my document and then I wrote stem:[sqrt(2)] at some point but when I run asciidoctor-pdf -r asciidoctor-mathematical -a mathematical-format=svg erg.adoc the pdf just has sqrt(2)
Any ideas on what I might be missing on doing wrong?
Update: I tried to write a stem block by doing this:
[stem]
++++
sqrt(2)
++++

And this worked just fine. So is it not possible to get inline stem or something like that?
Update 2:
Apparently explicitly writing asciimath:[sqrt(2)] works, but I can't get inline stem:[] to work even if I write :stem: asciimath at the top

The implicit value for the stem attribute when it is set is latexmath, not asciimath. So if you want to use the stem style or macro, you need to set the stem attribute accordingly.
:stem: asciimath

[stem]
++++
sqrt(2)
++++

That's not what the use manual says. https://asciidoctor.org/docs/user-manual/#activating-stem-support
So is this wrong?
And in any case, I did try to set it explicitly to asciimath but inline would still not work if I wrote stem:[]

My mistake. You are correct. The implicit value is, indeed, asciimath. However, it doesn't hurt to be explicit so that it's clear to the author of the document (perhaps yourself in the future).
That fact that inline stem is not working seems to be a bug in asciidoctor-mathematical (or the version of asciidoctor-mathematical is too old). The PDF converter does not do anything with stem other than to embed the image that asciidoctor-mathematical generates.

Wow, where is my brain today. Asciidoctor Mathematical does not support AsciiMath. It only processes LaTeX math. See https://github.com/asciidoctor/asciidoctor-mathematical/issues/87

Huh that's really weird though, because writing asciimath:[sqrt(2)] or
[asciimath]
++++
sqrt(2)
++++

Both work fine. Does that sound normal?

According to my tests, that does not work. It shows the original source in monospaced text.
However, there is hope. The AsciiMath gem can convert AsciiMath to LaTeX, which Asciidoctor Mathematical can then process. I commented on the referenced issue.

That's probably it, I have installed the asciimath gem so my guess is it does some magic behind the scenes and that's why it works for me?

It was me who was using an outdated version of asciidoctor-mathematical (from the Docker container). It turns out, AsciiMath integration was already implemented. So it does, in fact, support AsciiMath. The issue was just never closed.
However, it wasn't implemented correctly. So my first statement was accurate after all.  See https://github.com/asciidoctor/asciidoctor-mathematical/issues/87#issuecomment-731651350

Thank you! I doubt I could have traced this to its source on my own

Please follow that issue in Asciidoctor Mathematical to monitor when it gets fixed.


[CleanRepo]: Images for image hyperlinks flagged as orphans

Clean Repo seems to be flagging images incorrectly as orphaned for image hyperlinks. The image used to display for the image hyperlink is fine but in the case of an image hyperlink, the resulting image the hyperlink retrieves on a click is determined to be orphaned in the report.
Severity:
In the old aspnetdocs repo we had over 3000 image hyperlinks which Clean Repo flagged incorrectly as orphaned.  I don't think image hyperlinks are used as much like this in other repos however.
It used to be years ago, that two images were provided for screenshot image hyperlinks.  One larger and one smaller and the smaller one was used as the link itself.  Clicking on the screenshot or whatever the image was of, resulted in a larger version of the image being retrieved and displayed.
Recreating the issue:
Run the latest version of Clean Repo available today 8/20/24 in release mode.
Run the option for --orphaned-images:
CleanRepo.exe --orphaned-images
Provide the details for a local cloned copy of the aspnetdocs repo.
Specify to not delete the images to get the report of orphaned images that incorrectly includes images referred to by image hyperlinks.  (Also choosing to delete images results in incorrectly deleting images that should not be deleted.)
The list of images returned as orphaned will include the image from the image link used for the full image that is returned when the link is clicked.
For example for a link like the following, external-authentication-services/_static/image25.png would be determined to be orphaned:
[![Image displaying default Facebook home page](external-authentication-services/_static/image26.png "Click to Expand the Image")](external-authentication-services/_static/image25.png)
This example image link can be found in this .md article example here
It does not matter if tooltip text exists in the hyperlink or not.  Same incorrect results.
In case you were interested here is regex I could use to find examples of image hyperlinks with or without tooltip text in them:
Find image hyperlinks with tooltip text not in them:
[![.?](.?)](.*?)
Find image hyperlinks with tooltip text in them:
[![.?".?")](.*?)

@gewarren FYI


stories.add calls story function twice

Is there any reason why func in stories.add('name', func) is called twice?
I'm working on furthering the capabilities of storybook-addon-specifications and I'd like to guarantee the tests contained in func are not called more than once.
Is this the normal behavior and is there any way to guarantee its called only once?

UPDATE:
judging from the stack:
CALL 1:
at eval (webpack:///./storybook/facade.js?:141:7)
    at eval (webpack:///./~/@kadira/storybook/dist/client/preview/client_api.js?:96:22)
    at KnobManager.wrapStory (webpack:///./~/@kadira/storybook-addon-knobs/dist/KnobManager.js?:84:28)
    at withKnobs (webpack:///./~/@kadira/storybook-addon-knobs/dist/index.js?:93:18)
    at eval (webpack:///./~/@kadira/storybook/dist/client/preview/client_api.js?:95:20)
    at renderMain (webpack:///./~/@kadira/storybook/dist/client/preview/render.js?:108:17)
    at renderPreview (webpack:///./~/@kadira/storybook/dist/client/preview/render.js?:141:12)
    at Array.renderUI (webpack:///./~/@kadira/storybook/dist/client/preview/index.js?:89:26)
    at Object.dispatch (webpack:///./~/redux/lib/createStore.js?:186:19)
    at ConfigApi._renderMain (webpack:///./~/@kadira/storybook/dist/client/preview/config_api.js?:47:24)

CALL 2:
at eval (webpack:///./storybook/facade.js?:141:7)
    at eval (webpack:///./~/@kadira/storybook/dist/client/preview/client_api.js?:96:22)
    at KnobManager.wrapStory (webpack:///./~/@kadira/storybook-addon-knobs/dist/KnobManager.js?:84:28)
    at withKnobs (webpack:///./~/@kadira/storybook-addon-knobs/dist/index.js?:93:18)
    at eval (webpack:///./~/@kadira/storybook/dist/client/preview/client_api.js?:95:20)
    at renderMain (webpack:///./~/@kadira/storybook/dist/client/preview/render.js?:108:17)
    at renderPreview (webpack:///./~/@kadira/storybook/dist/client/preview/render.js?:141:12)
    at Array.renderUI (webpack:///./~/@kadira/storybook/dist/client/preview/index.js?:89:26)
    at Object.dispatch (webpack:///./~/redux/lib/createStore.js?:186:19)
    at ConfigApi._renderMain (webpack:///./~/@kadira/storybook/dist/client/preview/config_api.js?:48:24)

It's because the component is rendered twice due to multiple redux dispatches:
function _renderMain(loaders) {
      if (loaders) loaders();

      var stories = this._storyStore.dumpStoryBook();
      // send to the parent frame.
      this._channel.emit('setStories', { stories: stories });

      // clear the error if exists.
      this._reduxStore.dispatch((0, _actions.clearError)()); // CALL 1
      this._reduxStore.dispatch((0, _actions.setInitialStory)(stories)); // CALL 2
    }

But does the user's code really need to be re-rendered twice. Perhaps clearError() can be called before setStories is emitted or something like this. This can be problematic because imagine if on componentDidMount() the story is dispatching an action, and then in your tests your counting the number of actions dispatched. You will now have 2 instead of 1. And depending on your reducers or other code, the state may be different than what you expect.
I know React StoryBook wasn't initially for redux-usage, but it makes a damn good tool for working on your whole application--from tests to redux and more--if you know how to get the most use out of it. I don't see why it can't evolve into a tool that expects many users to be using Redux. In fact, it's a lot of throwaway work if this is just for designing components, and eventually you stop using the tool. Because the thing is as your app becomes real, half your components become connected redux containers. So if Storybook components aren't wrapped in a redux provider, you are left maintaining 2 codebases: your real app, and raw components, which expect a different set of props. It's way more efficient to be thinking in terms of the same set of connected container components. That way Storybook is more than just a designer's tool. Combine first-class redux support/usage with tests, and you have a way to bring up any focal point of your app and get down to business with ease. You basically can setup key areas you work on, and have a consistent state to expect once you get there--with passing/failing tests further informing you on what the "state" of the given area is.
Storybook lets you "bookmark" that state if you're using Redux. And not just the pretend raw component version of your app, but your real app. I don't see why anyone wouldn't want that.
So tests just make it even more important things are reliably rendering. But it's not just limited to tests. Of course a test should be able to re-run and not be dependent on how many times it ran, but because of the unique nature of Storybook and the Specifications plugin, it's useful to think of each describe block as one test where you setup your component once to be the return of stories.add AND to the basis for a bunch of consecutive tests, where in each those tests the component is not setup again. That means, re-renderings not triggered by the user could have negative effects on the results of tests, e.g. multiple actions dispatched, incorrect state.

In addition to double rendering your component, this._reduxStore.dispatch((0, _actions.clearError)()) will also cause the following issue:
<Provider> does not support changing `store` on the fly. It is most likely that you see this error because you updated to Redux 2.x and React Redux 2.x which no longer hot reload reducers automatically.

and possibly this one:
Warning: Exception thrown by hook while handling onSetChildren: Invariant Violation: Expected onBeforeMountComponent() parent and onSetChildren() to be consistent (22 has parents 21 and 19).
Invariant Violation: Expected onBeforeMountComponent() parent and onSetChildren() to be consistent (22 has parents 21 and 19).

This is specifically when you wrap your components in a provider without using addDecorator.
The reason I'm doing it outside of addDecorator is because I've taken the storybook-addon-specifications and mocked it in such a way that you can use Storybook with regular describe/it tests if you simply return a story component from your it blocks. So I have it working very nicely for tests like this:
describe('AnimatedTransitionGroup 1', () => {
  it('blue', () => {
    console.log('RENDER')
    const { story, store } = setupStory()

    store.dispatch({ type: 'CHANGE', payload: 'blue' })
    store.dispatch({ type: 'BLUR', payload: 'blue' })

    const { color } = store.getState()
    expect(color).toEqual('blue')

    const component = renderer.create(story)
    expect(component).toMatchSnapshot()

    return story // when run in Storybook, this will become the return of `stories.add()`
  })

  it('red', () => {
    const { story, store } = setupStory()

    store.dispatch({ type: 'CHANGE', payload: 'red' })
    store.dispatch({ type: 'BLUR', payload: 'red' })

    const { color } = store.getState()
    expect(color).toEqual('red')

    const component = renderer.create(story)
    expect(component).toMatchSnapshot()

    return story // when run in Storybook, this will become the return of `stories.add()`
  })

  it('just tests, no story returned', () => {
    expect(1).toEqual(1)
    expect(2).toEqual(2)
    expect(3).toEqual(3)
    expect(1).toEqual(1)

    // notice no story is returned
  })

  it('more equal tests', () => {
    expect(66).toEqual(66)
    expect(55).toEqual(55)

    // notice no story is returned
  })
})

What I got going is extremely slick.  Your tests are the same as before, with the very minor option of returning a story react component. I think this is a big win for the very important goal of mixing tests with Storybook.
It means your Storybook code is way more likely to stay maintained throughout the life of the project. For the importance of mixed snapshot testing, the real win is that you only need to setup components once and it is re-used between both Storybook and your tests. That is the win here. I got it working extremely nicely for me right now.
Give it a quick try to see what I'm talking about:
git clone git@github.com:faceyspacey/animated-transition-group.git
cd animated-transition-group
yarn
npm run test // just to see that the tests are working
npm run storybook

If you're using Wallaby, the tests will run very nicely there, and your snapshots will appear there, diffed when failing. Wallaby + Storybook are perfect companions.
The files worth looking at are:
THE TESTS:
https://github.com/faceyspacey/animated-transition-group/blob/master/stories/index.js
THE FACADE FOR STORYBOOK:
https://github.com/faceyspacey/animated-transition-group/blob/master/storybook/facade.js
THE FACADE FOR JEST:
https://github.com/faceyspacey/animated-transition-group/blob/master/storybook/__mocks__/facade.js
So anyway, just look at the above test code. It's clearly an elegant interface to just be able to return your story component from your it tests. And perhaps more importantly, it's all really greared for redux. Each sub-storybook/test is geared toward corresponding to one state for the same component. To make this sort of stuff work, there can't be that double-rendering. Currently it doesn't seem to break anything (because you're not actually trying to replace the store) when you see the above error messages, but it's not a good signal. Possibly it does, or at the very least it's bad for developer confidence.

...what it does break is hot reloading on the store. This is more related to the issue of using a redux Provider without using addDecorator. And that won't get fixed with the dispatching actions.clearError, as I've commented out the code. So that's another issue, and I assume one that is not easy to solve as you're obviously re-rendering the whole story. I'm hoping there is some real solution, as the only thing I can think of is hacking the standard describe/it interface to also allow you to add a decorator, but that non-standard Storybook-specific stuff is what I'm trying to get out of the tests.
The marketing idea here is big for Storybook. It's: Apply Storybook to your tests overnight. And boom Storybook is 10 times more useful. Any code that is already testing components, taking snapshots of them, etc, but not using Storybook can instantly make use of Storybook just by returning the story component from it calls. HOWEVER, any small amount of additional friction starts to greatly throw that opportunity out the window, as it scares people to mess with their tests, which are so crucial to their products.

Voicing desire for the same: this is a really good use-case and am keen to work on it as well, though not only through the lens of Redux.

This sounds amazing 😍 ! I'm hoping someone will be willing to experiment further and possible create a PR?

@adamellsworth @ndelangen here it is:
https://github.com/faceyspacey/jest-storybook-facade
Turn your tests into react storybooks in minutes by applying that and returning your components from tests. Let me know how it works out for you.

So I've also done some experimentation with jest & storybook & browsers and experienced it was just not feasible to run real jest in the browser or to rewrite jest for the browser. Jest has a pretty large API surface and is extendable. This will be used, and expected to work.
I love you're using storybook-addon-specifications! @mthuret which is what I've used as well, and things break when you're using more jest-feature other then describe, it etc.
But if we could find a reliable way, that'd be amazing!

check the code, I mocked a lot more of Jest. The API surface isn't that big. We can totally get it up to par. Here are my notes from the readme on further improving the mocks:
https://github.com/faceyspacey/jest-storybook-facade#help-us-improve-storybook-facadejs
here's the mock:
https://github.com/faceyspacey/jest-storybook-facade/blob/master/src/storybook-facade.js#L169
the most valuable thing is that expect looks like the Jest version.

Hey @faceyspacey think you could open a PR fixing this?

I've been meaning to get to this and invest serious time. I have quite a serious agenda in this area. But I'm a month off Id say.

HI guys, I face same issue here, is there any progress? or any workaround? thanks a lots!!

I had this error message too.  Apparently, I was missing my import statement in .storybook/preview.js. When I added it in, it resolved this entirely.
import 'storybook-chromatic';
https://www.learnstorybook.com/intro-to-storybook/angular/en/test/
I'm running React not Angular but the link above helped.


Create a flat include structure for iceoryx_hoofs

Brief feature description
Often headers are moved inside iceoryx_hoofs both in folder and namespaces. This burdens the user with unnecessary code changes, having to adapt the include path.
Detailed information
The idea would be such a structure
include
  |-iox
    |-vector
    |-string
    |-...

with e.g. vector containing
#include "iceoryx_hoofs/cxx/vector.hpp"

namesapce iox
{
    using cxx::vector;
}

On the user side it would look like
#include "iox/vector"

iox::vector<int, 42> foo;

Things to consider
From the developer meetup https://github.com/eclipse-iceoryx/iceoryx/wiki/2023-11-16-Eclipse-iceoryx-developer-meetup#minutes

Relax flat include structure

posix is flat include and flat ioxnamespace
concurrent is flat include and iox::concurrent namespace
units is flat include and iox::units namespace
non public API has a iox/detail/foo.hpp include and is in the iox::detail namespace
non public API of bigger modules, like cli can opt in for iox/detail/cli and iox::detail::cli
public API is in iox/header.hpp

From https://github.com/eclipse-iceoryx/iceoryx/pull/2142#discussion_r1439803183
We can do this also at a later point, it was just my personal taste.
My personal favorite would be:
iox::lock_free::{mpmc|spsc} - for all lockfree code
iox::concurrent for generic thread safe code

But I would suggest that we talk about it in a later meetup and go from there.
Tasks

[x] check which classes should be public
[x] determine how to proceed with namespaces

Sync with @elBoberido and @elfenpiff
How to proceeded further with the module structure?

Differentiation between user-view and iceoryx developer-view

First step: #1391 iceoryx developer-view aka new folder structure (possibly without CMake changes)
Second step: #1593 user-view to decouple the user from any future changes

Action items

Independently brainstorm for a iceoryx developer-wie module structure

Have a look at Folly and Abseil

@mossmaurice @elfenpiff what do you think about this
iceoryx_hoofs
|- concurrent
|- core
|- posix

Everything not concurrent or posix would be part of core and each of these three pillars would have a folder structure with container, memory, etc.?

@elBoberido It might be confusing for developers browsing the repository on the first sight and might seem verbose to some. No hard feelings here, though.
What do you think about?
iceoryx_hoofs
|- container
|- queues
|- etc.
|- concurrent
  |- container
  |- queues
  |- etc.
|- posix
  |- container
  |- queues
  |- etc.

Just to make sure to avoid misunderstanding, I'm only talking about the internal structure not the user-facing one.

@mossmaurice I think your structure goes in the right direction but is to fine grained. I would merge queues and containers. If both would contain more than 10 classes than this would be a meaningful distinction but for now it is not required and YAGNI tells us not to do it.
Otherwise it is a good structure!
In the first step I would not create the same structure in concurrent and posix. I would introduce them when we have circular dependencies. For concurrent they may make sense but here we would have only queues and other stuff and not a single posix construct would fit into that kind of structure.
The internal structure of those proposed modules could be:
module
|- include
  |- internal or details
|- src
|- tests

I suggest:
iceoryx_hoofs
|- concurrent
  |- leave it as it is
|- conversion
  |- convert in a refactored form (int -> string)
  |- From / Into
  |- Serialization
|- containers
  |- ?buffer? from lockfree_queue as uninitialized_array
  |- ?expected?
  |- list
  |- ?optional?
  |- ?scoped_static?
  |- stack
  |- ?static_storage?
  |- string
  |- ?variant?
  |- ?variant_queue?
  |- vector
|- design
  |- newtype
  |- builder
|- functional
  |- function_ref
  |- function
  |- ?scope_guard?
|- meta
  |- algorithm
  |- attributes
  |- parts of helplets
  |- functional_interface
  |- ?requires? when not replaced with error handler
  |- types
  |- type_traits
|- memory
  |- unique_ptr
  |- relocatable_ptr
  |- allocator (from shared_memory_object)
|- posix
  |- I would add here filesystem.hpp since user/group/other with the permission is defined by the posix standard
  |- rest leave it like it is
|- units
  |- duration

@elfenpiff a separate CMakeList.txt for each module would not work, at least not when it is more fine grained.
Example:

container/vector uses the logger
the logger uses the posix/posixCall
posix uses the vector

And now we have the circular dependency
if we would have something like
poxix
|- module with posixCall
|- module with shm?
|- maybe another module

Then it would again be possible to prevent circular dependencies

@mossmaurice I also thought about that and had a slight tendency to move everything into a common folder but your suggestion might make more sense. With my proposal we would walk the dependency tree like this hoofs/core/log -> hoofs/core -> hoofs -> hoofs/posix -> hoofs/posix -> hoofs/posix/foo (contains posixCall) with your suggestion there would be one layer less and it would feel better.

@elBoberido As this issue here is about the user-facing structure, let's move this discussion to #1391.

@elBoberido @mossmaurice @elfenpiff
Agreed on the following final structure:
./iceoryx_hoofs
./iceoryx_hoofs/legacy
./iceoryx_hoofs/legacy/include
./iceoryx_hoofs/legacy/include/iceoryx_hoofs
./iceoryx_hoofs/legacy/include/iceoryx_hoofs/cxx
./iceoryx_hoofs/legacy/include/iceoryx_hoofs/cxx/vector.hpp
./iceoryx_hoofs/container
./iceoryx_hoofs/container/source
./iceoryx_hoofs/container/source/vector.cpp
./iceoryx_hoofs/container/include
./iceoryx_hoofs/container/include/iox
./iceoryx_hoofs/container/include/iox/vector.hpp
./iceoryx_hoofs/container/include/iox/detail
./iceoryx_hoofs/container/include/iox/detail/vector.inl
./iceoryx_hoofs/container/unittests
./iceoryx_hoofs/integrationtests

the folder legacy is the migration path
in the first step we can leave the tests under iceoryx_hoofs/tests but in a final solution we will

use iceoryx_hoofs/container/unittests for all unit tests
use iceoryx_hoofs/integrationtests for all integration tests which tests the composition of multi-component structures

Modules for iceoryx_hoofs were created in:

#2143
#2142
#2061
#2133

Hence, closing this issues.

@mossmaurice while the work is done, we still need to add a few words to the release notes


Add LA scraper

Getting on the board in the home of the Big Easy while Chi-Town rests.
Steps to test
python -m warn.cli LA -l DEBUG

Closes #79

Currently places address information in the company name field as do the PDFs. Only way to reliably distinguish seems to be to rely on difference in text weight:

Looks like I may be able to do that by querying the page for characters within the bounding boxes of TableFinder.

That method works for all but 2020 and 2021:

So, need a fallback plan. Most contain a number somewhere on the first address line, usually at the beginning. A naive approach splits on that and then special cases the small handful of exceptions.

I wonder if I can use words in the bolded examples to learn how to classify the non-bolded examples.

Okay now uses the bolding to separate out the company name and address when it's available and a pattern-based heuristic when there is no bold text. Also separates out notes like "UPDATE" and "WARN RESCINDED." Also deals with one row that ran over on to a second page. Doesn't guarantee perfect tidiness, but uses what it has to give you something closer.

One potential enhancement here would be to better deal with these multi-line cells, usually containing multiple updates for the same business:

Thanks for your help here, @chriszs. You're in!


Automated Package Upgrade

:tada: This PR is included in version 4.0.37 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(react-context): expose clients

It exposes the clients map under the same contexts, which gives the possibility to interact with all clients under the same provider. Providing access to the clients allows to communicate with the iframe elements and pass messages.
This is the safest way to interact with clients and their iframes, as Sandpack context ensures access to all Preview that has been rendered under the same provider.

I only looked at the docs change, but that seems clear to me!


Should we maintain an official model in the toolbox?

Right now, we only distribute Fusion here on Github. With the recent announcement of the Open Cloud APIs, would it be worth setting up some kind of action to auto-publish a Fusion model to the Roblox toolbox?
This would help make Fusion much more immediately accessible for all developers, could make the installation process less intimidating for newer developers, and may even allow for require by asset ID.
With regards to require by asset ID, this would allow games to have their Fusion versions updated over the air automatically - we should consider this carefully. Since Fusion will use semver, this would probably result in one model per major version, with minor non-breaking updates being automatically patched in. If we do this, we need to guarantee to the best of our ability that these updates aren't breaking, though this is something we should do anyway.
I'd be interested to hear what your takes are on such a proposition!

I've decided against this for now - perhaps we could revisit this at a later date when Fusion comes out of early beta.


finalized nav, footer and homebody styling components. Started show c…

…omponents"

lmk how to resolve these conflicts if needed. I'm not sure what happened here.


fixed missing service worker copy

refering to this:  https://github.com/driftyco/ionic/issues/8256

Looks good. This change is dependent on driftyco/ionic2-app-base#84.

Thanks @pascalwhoop ! Much appreciated