workspace:* is updated to a specific version when working with pnpm workspace

Hi! I'm using release-please in a pnpm workspace based monorepo throuth release-please-action to publish packages to a private registry.
It worked well on v3. But once I updated it to v4 I got an error due to `workspace:*`` was updated to a specific version.
I found that release-please-action bump release-please from 15.3 to 16.3 on v4, and the releated PRs are https://github.com/googleapis/release-please/pull/2058 and https://github.com/googleapis/release-please/pull/2117.
According to pnpm's documentation, it dynamically replace any workspace: dependency. So we don't need to update version of deps manually. And it is what v3 did.
Of course, I can keep using v3, but I want to know if there is any other solution.
here is a repo to reproduce. https://github.com/YiCChi/front-monorepo

PR created by v3. https://github.com/YiCChi/front-monorepo/pull/32
PR created by v4. https://github.com/YiCChi/front-monorepo/pull/35

error log
 ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with packages/math/package.json

Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"

    Failure reason:
    specifiers in the lockfile ({"@yicchi/is-even":"workspace:*","@yicchi/is-odd":"workspace:*"}) don't match specs in package.json ({"@yicchi/is-odd":"workspace:*","@yicchi/is-even":"0.9.0"})

yes, it seems that previously lerna handled logic of "workspace:" versioning, now after moving to internal implementation of graph #2117 the only workspace handler left is that
      if (currentDepVer.startsWith('workspace:')) {
        depUpdates.push(`\n    * ${depName} bumped to ${newVersionString}`);
      } else if (newVersionString !== origDepVer) {
        depUpdates.push(
          `\n    * ${depName} bumped from ${origDepVer} to ${newVersionString}`
        );
        //handle case when "workspace:" version is used

Any updates on this issue?  We would like to migrate to v4 of release-please-action, which includes a couple fixes from release-please v16 that we've been waiting for, but our project makes use pnpm and workspace:*, so we are stuck in a holding pattern like the original submitter.

Is there any workaround？

Yarn workspaces are also affected. Release please keeps replacing workspace:^ with hardcoded version.

Submitted a PR with a fix.

Submitted a PR with a fix.

Could this please be released for release-please-action v4 as well? 🙏  It seems to still use 16.10.2


Carousel functionality in Cards

Is your feature request related to a problem? Please describe.
I would like to show some process flow in a carousel in the left panel.
Describe the solution you'd like
Need to have carousel card functionality and left/right panel availability in the Composer for rich visual experience so that one can scroll horizontally for the next steps.
Describe alternatives you've considered
As of now managing with hero card. Please let me know if there is any workaround for implementing this.
Additional context

Hi @prasadreddybv I guess you would like to show carousel cards in composer?
You could do something like this:
# Welcome-Message
[Activity
    Text = Welcome
    Attachments = @{json(Welcome-Card())} | @{json(Welcome-Card())} | @{json(Welcome-Card())}
    AttachmentLayout = carousel
]

# Welcome-Card
-```
{
  "type": "AdaptiveCard",
  "body": [
    {
        "type": "TextBlock",
        "text": "Adaptive Card"
    },
    {
      "type": "Image",
      "url": "https://adaptivecards.io/content/cats/1.png"
    }
  ],
  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
  "version": "1.0"
}
    ```

Result in Emulator:

@prasadreddybv Please reopen it if this does not fit your requirement.

@xieofxie - Thank you for your response . I will try it out and let you know.

@prasadreddybv Please reopen it if this does not fit your requirement.

@hibrenda - Sure i will do that.

is there any way to create a carousel just using images rather that adaptative cards?

no, I don't think so. One always needs to put images in some container (aka adaptive card).


Executing RenderingServer.create_local_rendering_device crashes Godot

Godot version
4.0.alpha.custom_build. 4b164b8e4
System information
Ubuntu 22.04 - Nvidia GTX 970, Gnome shell 42 X11
Issue description
When executing
	RenderingServer.create_local_rendering_device()

Godot crashes without backtrace(probably crash in graphic driver)
Thread 67 "[vkrt] Analysis" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffe64bea640 (LWP 94122)]
0x00007fffe02b8c0c in ?? ()
(gdb) backtrace
#0  0x00007fffe02b8c0c in ?? ()
#1  0x00007ffe64bea640 in ?? ()
#2  0x00007ffe64be9b30 in ?? ()
#3  0x00000000632f6342 in ?? ()
#4  0x000000002ee32c80 in ?? ()
#5  0x00000000632f6342 in ?? ()
#6  0x00000000000a7a30 in ?? ()
#7  0x00007fffffff89b0 in ?? ()
#8  0x000000001860f370 in ?? ()
#9  0x00007fffe02bae60 in ?? ()
#10 0x000000001860f4c0 in ?? ()
#11 0x0000000000000000 in ?? ()

This example was found by Godot fuzzer - Qarminer, so it is quite unlikelly that this code could be used in real project, but still this should be handled gracefully.
Steps to reproduce
Above
Minimal reproduction project
No response

https://github.com/godotengine/godot/blob/632dbab226356eb4395ee2c0aa202c5fcd912e7d/servers/rendering_server.cpp#L1477-L1479
get_singleton() here returns null.

Not sure if this is a problem here.
Usually asan/ubsan show clear error if null pointer was used, but this time I got only simple segmentation fault  message without debug symbols in backtrace which is quite common if external library crashes.

When running with --headless or with the opengl3 renderer, get_singleton() indeed returns null and is the source of the crash.
I cannot reproduce the issue with the vulkan renderer. That might be a driver issue that can't be fixed in Godot.

That's expected, the OpenGL3 driver doesn't implement RenderingDevicr (which is the abstraction for modern APIs like Vulkan/D3D12). So this method should just null when using OpenGL3 (which can be done by checking ifthe RD singleton exists I guess). Should be documented too.


Remove dummy Say theming

Some theming (s-root) from the dummy app imported a file that would override colors and fonts used in the dummy test application and the plugins. This would interfere with the styling of the plugins, and caused uncertainty about the lay-out of the plugin (for me at least). With this file removed, the plugin would be rendered as if it were in the final editor, to be able to properly fine tune the lay-out.

I've realised something. We could keep this PR open for a bit longer and pile up more cleanup of the Say theming code, because we are working on porting all the plugins to (Ember-)AppUniversum.
Or we could make a new PR for more of that later.

We lost the global appuniversum variables with removing the custom variables so added these back by using the grouped appuniversum settings file.
I do wonder if using the appuniversum styling is correct here. We used to approach the editor as a standalone product (by styling it similar to https://say-editor.com/) which was not related to the style of Vlaanderen. This PR removes this custom style. It sure is easier to maintain this way. I don't know who decides on this styling? Maybe @nvdk

As long as we document how the styles can be customized I think we can drop the custom style for now.


Add Setting Toggle for WiFi Direct

Allow users to choose to scan for WiFi Direct devices.

LGTM

lgtm


Error in requestSubscription (iOS)

Description
Trying to make a new request for subscription on IOS, but it returns the following error:
 LOG  [Error: Invalid product ID. Did you call getProducts/Subscriptions]
While before I call the requestSubscription({sku: 'Yearly_Subscription'}) method I'm getting a list of products:
[{"currency": "", "description": "APP monhtly", "localizedPrice": "$0.99", "platform": "ios", "price": "0.99", "productId": "Monthly_Subscription", "subscriptionPeriodNumberIOS": "undefined", "subscriptionPeriodUnitIOS": undefined, "title": "Monthly Subscription", "type": "subs"}, {"currency": "", "description": "App annual", "localizedPrice": "$9.99", "platform": "ios", "price": "9.99", "productId": "Yearly_Subscription", "subscriptionPeriodNumberIOS": "undefined", "subscriptionPeriodUnitIOS": undefined, "title": "Annual Subscription", "type": "subs"}]

Environment:

react-native-iap: 12.7.4
react-native: 0.70.6
Platforms (iOS, simulator):

Having the same issue/error today using Sk2.  Can confirm a valid sku is passed after retrieving from getSubscriptions, but always receive an error that it's an Invalid product ID.
Environment:

react-native-iap: 12.7.4
react-native: 0.70.4
Platforms (iOS, iPhone 6S, iPhone 13)

@igorjos Wow. You saved me! In my case, I had wrapped my app with an outer  layer that has all necessary IAP listeners configured. This is where I would initConnection and endConnection for the session (open/close of app). I would also fetch subscription products at this level and store them in context to be referenced later from the purchase screen.
I've now moved getSubscriptions to fire just before requestSubscription. The back to back calls have "fixed" this issue.
Cheers!

Is this the expected behaviour? getProduct once more before requestPurchase

{"error": [Error: Purchased failed for sku:fc_month_179: Unable to Complete Request], "success": false}
getting this error need help


[Feature] Add coords scaling and distance calculation directly to Register

Moves the register spacing as an argument to the Register itself.
Changes the spacing functionality: Instead of multiplying whatever coordinates are in the register with the value of the spacing, it rescales the coordinates so that the distance between the two closest qubits is equal to the spacing (consistent with the spacing argument in the Pulser register).
Rescaling coordinates from the register can still be done with the method reg.rescale_coords(scaling: float) which initializes a new register where all coordinates are multiplied by the scaling value.

BREAKING:

Some of the arguments from the Register methods have been changed so that they are all now spacing.
The default scaling of coordinates in the Pulser backend has been removed so that now a Qadence register passed to either the PyQ backend or Pulser backend gives the same results without needing to tune any other config.
The spacing is no longer a valid argument in the Pulser backend configuration.

backend any

Yes exactly, the results would be the same.

If the spacing is not part of the backend anymore but of the Register will it still be possible to run two circuits
run(reg, circ, backend="pyqtorch")
run(reg, circ, backend="pulser")

and get the same result? or would one have to change the register?

Yes exactly, the results would be the same

If the spacing is not part of the backend anymore but of the Register will it still be possible to run two circuits
run(reg, circ, backend="pyqtorch")
run(reg, circ, backend="pulser")

and get the same result? or would one have to change the register?

Yes exactly, the results would be the same

Coooool, so how is this handled?:) does the pyq backend ignore the spacing? sorry for the ignorant questions, just trying to figure out how its implemented:)

If the spacing is not part of the backend anymore but of the Register will it still be possible to run two circuits
run(reg, circ, backend="pyqtorch")
run(reg, circ, backend="pulser")

and get the same result? or would one have to change the register?

Yes exactly, the results would be the same

Coooool, so how is this handled?:) does the pyq backend ignore the spacing? sorry for the ignorant questions, just trying to figure out how its implemented:)

It's all just dependent on the coordinates of the qubits. By passing the scaling in the register the coordinates are automatically re-scaled, and then the pyq backend computes distances between the qubits dependent on the coordinates. When passing to the pulser backend the pulser register is created from the coordinates of the qadence register, so everything is consistent.

LGTM! Last question: what are the units of the coordinates now in pulser/pyq?

For pulser in general and analog blocks in pyq: micrometers, same as it was. But if a user just does some arbitrary HamEvo to run in PyQ that depends on some register coordinates, they are responsible for setting the units correctly. There is a warning about this in the register docs.


RA uses 2.4 GB RSS on docs.rs

Steps to replicate:

Install VSCode with the rust-analyzer extension
git clone https://github.com/rust-lang/docs.rs/
code docs.rs

Rust-analyzer uses 2.4g RSS, which kills most of the other programs I have running at the same time. I've started using vim instead.

I'm happy to help debug this if you have suggestions.

It is expected that rust-analyzer uses a lot of memory. If you want to see what it is used for, you can run the "Rust Analyzer: Memory Usage (Clears Database)" command. After a few seconds, a new editor pane should open with the memory usage info.

That gives a panic:
Panic context:
> request: textDocument/codeLens CodeLensParams {
    text_document: TextDocumentIdentifier {
        uri: Url {
            scheme: "file",
            host: None,
            port: None,
            path: "/home/joshua/src/rust/docs.rs/src/web/releases.rs",
            query: None,
            fragment: None,
        },
    },
    work_done_progress_params: WorkDoneProgressParams {
        work_done_token: None,
    },
    partial_result_params: PartialResultParams {
        partial_result_token: None,
    },
}

thread '<unnamed>' panicked at 'no value set for FileTextQuery(FileId(0))', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/salsa-0.16.0/src/input.rs:104:32
stack backtrace:
   0: rust_begin_unwind
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:483
   1: std::panicking::begin_panic_fmt
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:437
   2: <salsa::input::InputStorage<Q> as salsa::plumbing::QueryStorageOps<Q>>::try_fetch::{{closure}}
   3: <salsa::input::InputStorage<Q> as salsa::plumbing::QueryStorageOps<Q>>::try_fetch
   4: <DB as base_db::SourceDatabaseExt>::file_text::__shim
   5: salsa::runtime::Runtime::execute_query_implementation
   6: salsa::derived::slot::Slot<Q,MP>::read_upgrade
   7: salsa::derived::slot::Slot<Q,MP>::read
   8: <salsa::derived::DerivedStorage<Q,MP> as salsa::plumbing::QueryStorageOps<Q>>::try_fetch
   9: <DB as ide_db::LineIndexDatabase>::line_index::__shim
  10: ide::Analysis::file_line_index
  11: rust_analyzer::handlers::handle_code_lens
  12: <F as threadpool::FnBox>::call_box
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
 Is that expected?

Notice how there is a - at the start. It seems that something else was running while the memory usage was being reported. Memory usage is reported by clearing parts of the salsa database one by one and then determining the change in memory usage of the whole process. If another thread caused the salsa database to be filled again, that will cause a negative memory usage to be reported for certain items.

How can I get rust-analyzer to run in a single thread? Is there some way to get a more accurate report?

There is no way to run it in a single thread. The main lsp server loop runs on a different thread than the thread(s?) processing lsp requests.

Ok, is there some way to tell the RA process not to accept new requests while it's dropping memory?

If you wait until r-a has finished indexing the project and stops using CPU, and you don't use the editor while the memory usage command is running, it should work

rust-analyzer uses 1.3 GB on the docs.rs code base for me (while looking at src/lib.rs). Is there anything else I have to do to reproduce this?

Profile on my machine:
Per-query memory usage:
   461mb ItemTreeQuery
   110mb CrateDefMapQueryQuery
    81mb FileTextQuery (purge)
    55mb MacroArgTextQuery
    48mb InternEagerExpansionQuery
    37mb ImplDataQuery
    20mb GenericParamsQuery
    16mb MacroDefQuery
    13mb GenericParamsQuery (purge)
    12mb ParseQuery
    10mb ImplSelfTyQuery (purge)
     9mb AstIdMapQuery
...

@jonas-schievink I didn't do anything special, this is with src/web/mod.rs open. I used top for the measurements.
    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
1994657 joshua    20   0 2905536   2.4g  14596 S   0.0  32.2   0:43.63 rust-analyze+

I don't know why I have different (and negative) numbers :/ I waiting until rust-analyzer was using 0% CPU and disabled all other extensions, and still got the same result with -3367mb for FileTextQuery.

on my PC it's arount 1.2GB

I too get 1.3 GB total after scrolling around and triggering go to definition on various names in src/web/mod.rs.

FYI,  #7103 seem to fix the panic mention above..

FYI,  #7103 seem to fix the panic mention above..

I ran RA on docs.rs again today. I didn't see any panics but the memory usage is even higher, 2.7 GB now.

I ran RA on docs.rs again today. I didn't see any panics but the memory usage is even higher, 2.7 GB now.

I don't know why I have different (and negative) numbers

We found this is because mallinfo returns int for the number of bytes allocated, which is 32-bits even on x64 and overflows for anything larger than 2 GB :facepalm: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/running.20RA.20on.20docs.2Ers/near/223145339

I don't know why I have different (and negative) numbers

We found this is because mallinfo returns int for the number of bytes allocated, which is 32-bits even on x64 and overflows for anything larger than 2 GB :facepalm: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/running.20RA.20on.20docs.2Ers/near/223145339

and we also found why it uses more memory for me than for everyone else: It's not respected workspace.exclude, and docs.rs has a bunch of generated projects in .rustwide: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/running.20RA.20on.20docs.2Ers/near/223152497

and we also found why it uses more memory for me than for everyone else: It's not respected workspace.exclude, and docs.rs has a bunch of generated projects in .rustwide: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/running.20RA.20on.20docs.2Ers/near/223152497


Update create and update methods to read json-api format post params

:+1:
I'm not sure how ember-data is serializing the resource name, but we can't use the tableName on the model here, we need to use the typeName, as that matches up with how it appears in the URL and GET requests, so, in your example, leave-requests, not leave_request.

:anguished: Yeah, I think ember data (or at least the ActiveRecordAdapter) assumes everything's underscored and the key is the table_name. I'll change it.

:+1: thank you!


oh-my-posh: 21.17.2 -> 22.3.0

Description of changes
https://github.com/JanDeDobbeleer/oh-my-posh/releases/tag/v22.3.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Can update this to v23.4.0.


Option to truncate the number of chips displayed.

Feature request:
Option to truncate the number of chips displayed. And then display a "+x" text after the max number of chips is exhausted(similar to how Gmail does for email chips).
Currently, there is no limit on the number of selected items displayed, so it becomes a bit inconvenient for the user, because, the drop-down's height keeps on changing on each item select/unselect.
Having the option to truncate the max number of selected elements would be great!

hi @JairajJangleSLIOT ,
I'm working on it.

Hi @JairajJangleSLIOT ,
You can use props "minHeight" customize min height for list container and "maxHeight" customize max height for list container.
Example:
   <Dropdown
      {...}
      minHeight={200}
      maxHeight={200}
   />

Hi @hoaphantn7604, I will try this, but will this allow me to truncate the number of chips like in Gmail app?

@hoaphantn7604 setting the minHeight and maxHeight parameters as described does not truncate the number of chips, the chips keeps on adding and so the drop down keeps on shifting below as the number of selected chips grow.

hi @JairajJangleSLIOT ,
You can use Lazy load in this dropdown. Ex: https://github.com/hoaphantn7604/react-native-element-dropdown/blob/master/example/src/dropdown/DropdownLazyLoad.tsx


Install OK(ish), but fails when running with Electron

I get the feeling the problem is me having a serious case of _the dumb_, but I can't get the Electron starter app to run if I try to include RobotJS.
There's some warnings thrown when installing (with npm i --save-dev robotjs), but nothing that would halt the compilation:
><EMAIL_ADDRESS>install C:\projects\barky\node_modules\robotjs
> node-gyp rebuild

C:\projects\barky\node_modules\robotjs>if not defined npm_config_node_gyp (node "C:\Users\Klasu\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  robotjs.cc
c:\projects\barky\node_modules\robotjs\src\os.h(26): warning C4005: 'STRICT' : macro redefinition [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
          C:\Program Files (x86)\Windows Kits\8.1\Include\shared\minwindef.h(23) : see previous definition of 'STRICT'
c:\projects\barky\node_modules\nan\nan_new.h(208): warning C4244: 'argument' : conversion from 'size_t' to 'double', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
          ..\src\robotjs.cc(622) : see reference to function template instantiation 'v8::Local<v8::Number> Nan::New<v8::Number,size_t>(A0)' being compiled
          with
          [
              A0=size_t
          ]
  deadbeef_rand.c
  mouse.c
  keypress.c
  keycode.c
..\src\deadbeef_rand.c(26): warning C4267: 'return' : conversion from 'size_t' to 'uint32_t', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
  screen.c
  screengrab.c
..\src\mouse.c(277): warning C4244: '+=' : conversion from 'double' to 'size_t', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
..\src\mouse.c(278): warning C4244: '+=' : conversion from 'double' to 'size_t', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
  snprintf.c
  MMBitmap.c
  win_delay_load_hook.c
..\src\screengrab.c(127): warning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
..\src\screengrab.c(128): warning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
..\src\snprintf.c(911): warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
..\src\snprintf.c(939): warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
..\src\snprintf.c(956): warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
..\src\snprintf.c(965): warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
..\src\snprintf.c(976): warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
..\src\snprintf.c(988): warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [C:\projects\barky\node_modules\robotjs\build\robotjs.vcxproj]
     Creating library C:\projects\barky\node_modules\robotjs\build\Release\robotjs.lib and object C:\projects\barky\node_modules\robotjs\build\Release\robotjs.exp
  Generating code
  Finished generating code
  robotjs.vcxproj -> C:\projects\barky\node_modules\robotjs\build\Release\\robotjs.node
<EMAIL_ADDRESS>C:\projects\barky
└──<EMAIL_ADDRESS>
Whever I try to launch the app, I get this:

I have Visual Studio 2013 and Python 2.7.10 installed. Any ideas?

Hello!
Did you compile RobotJS for Electron? Native modules require some extra work.
https://github.com/atom/electron/blob/master/docs/tutorial/using-native-node-modules.md

Thanks for the prompt reply!
I honestly thought I had, but apparently I hadn't because the compilation failed due to another issue. So my initial hypothesis was spot-on.
This issue is resolved and was not related to RobotJS. Thanks!

No problem! Glad I was able to help.
Please let me know if you run into any other issues!

@schlaus @octalmage I'm so terribly sorry to tag you both here  on such an old issue but could any of you perhaps provide some assistance.
I have an electron app that needs to use robotjs. I've got it installed correctly but the pop-up message from the original report here continues to appear.
I have

ran electron-rebuild -w robotjs
tried rebuild-require
(╯°□°）╯︵ ┻━┻ ' ing a few times

I'm running on windows so that might be some of the problem. Not entirely sure though.
What would be the way that either of you managed to get this working with electron.

have you solve the problem？ I meet the same one


NULL:GetNWEntity causes error

[[ArcCW] B-Weapons 3] lua/entities/bw3_ent_mech_base.lua:1351: Tried to use a NULL entity!
1. GetNWEntity - [C]:-1
2. fn - lua/entities/bw3_ent_mech_base.lua:1351
3. unknown - lua/ulib/shared/hook.lua:109 (x68802)

Cannot reproduce.


cmd/go: document that filesystem-based replace directives require that the right hand side have a go.mod

What version of Go are you using (go version)?

$ go version
go version go1.12 darwin/amd64

Does this issue reproduce with the latest release?
I believe 1.12 is the latest release
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/grant.wu/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/grant.wu/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.12/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.12/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rm/k4qc6x917tdf1ms2f8t2jw1h0000gp/T/go-build926919438=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
At work we internally have a fork of a particular module - call it foo.  We have a fork of foo internally for some minor changes.  I had the fork checked out at my desired branch at ./grant_modules_hack/vendor/foo.  (I was attempting to work around a private repo problem at the time).
I added this replace directive:
replace github.com/someorg/foo => ./grant_modules_hack/vendor/foo

What did you expect to see?
I expected this to work, with, say, go build.
What did you see instead?
go: parsing grant_modules_hack/vendor/foo/go.mod: open /Users/grant.wu/petuum/file-api/src/file-api/grant_modules_hack/vendor/foo/go.mod: no such file or directory
go: error loading module requirements

@thepudds confirmed to me that filesystem-based replace directives do require that the right hand side have a go.mod.
This should definitely be documented somewhere:  I don't see this caveat listed anywhere here https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive

This is likely related to https://github.com/golang/go/issues/24110
@rsc states that this is "working as intended", but it doesn't seem obvious to me why the stated rationale applies - after all, go modules interop with non-go module adopting libraries fine normally.
In fact without the replace directive, if I want to use the public, non-forked version of said dependency, go modules seems to work with it fine...

A related comment from Bryan:

replace directives in the local filesystem require a go.mod file: otherwise we have no idea what import paths within that filesystem tree mean. (We need the module directive in the go.mod file in order to know which import paths are internal to the module.)
replace directives that point to other modules should not require a go.mod file, because we can use the module path from which the module was resolved to determine its import prefix.

FWIW, I think having a filesystem-based replace without a go.mod on the right-hand side is actually useful.
I was expecting to use that for the following case:
I have a large, curated existing GOPATH, made up of operating system packages for various Go libraries and to be used for builds of other OS packages (that's NetBSD pkgsrc, if you are wondering). Now I would like to replace a given module with its equivalent in the existing GOPATH.
Because we are early in the development of modules, most of these have no go.mod of their own. Running go mod init does not seem like a good option, as it will do more network accesses during the build, which I would like to avoid. Also, I see a danger that this will make other builds depending on the code in the GOPATH break, because now they might switch to module mode.
Or am I thinking about this the wrong way?

So,.... I've been bitten by #26366 for CGO-using module X, which is really annoying. I had hoped I could then just define a project local GOPATH= and have my main package in /src/main-package and have /src/X ... but no. GOPATH also stops working when GO111MODULE=on.
Then, I had hoped I could vendor module X outside of the go mod controlled vendor dir by using replace X => ../X in go.mod.   (here using git subtree)
Unfortunately this runs into this bug, since module X doesn't have a go.mod.
All I wanted here was for go build -mod=vendor to find module X in it's complete form. Can it really be true that we have to introduce yet-another-tool to make this work. I had hoped to just use git and go.

It's currently listed on https://go.dev/ref/mod#go-mod-file-replace:

If the path on the right side of the arrow is an absolute or relative path (beginning with ./ or ../), it is interpreted as the local file path to the replacement module root directory, which must contain a go.mod file. The replacement version must be omitted in this case.


Improved perf of .NET samples (Reduced sample ColorResolution to R720p)

Reduced ColorResolution of the WPF sample to R720p to get max 30fps performance instead of 10fps. The XAML MainWindow has much less height than 720p anyway, so the higher res color frames are just wasted computing.

Fixes
Description of the changes:

Before submitting a Pull Request:

[x] I reviewed CONTRIBUTING.md
[x] I built my changes locally
[ ] I ran the unit tests
[ ] I ran the functional tests with a device
[ ] I ran the performance tests with a device

I tested changes on:

[x] Windows
[ ] Linux

The problem of the frame rate is not the resolution of the image.
Actualy, in the WinForms example the performance of the depth image generation is too low and it drops the fps.
See the issue #683

The problem of the frame rate is not the resolution of the image.
Actualy, in the WinForms example the performance of the depth image generation is too low and it drops the fps.
See the issue #683

Surely the pixel copying should be improved and use the same pixel format so a simple mem block copy can be performed.
Reducing the resolution is just a quick fix/workaround as the window size is smaller anyway.

The problem of the frame rate is not the resolution of the image.
Actualy, in the WinForms example the performance of the depth image generation is too low and it drops the fps.
See the issue #683

Surely the pixel copying should be improved and use the same pixel format so a simple mem block copy can be performed.
Reducing the resolution is just a quick fix/workaround as the window size is smaller anyway.

Surely... But the correct fix i think that is fix the depth image generation. For example, in the WinForms example I can run with 30 fps only doing it.

If you want save the images for anything (to make a video for example), reduce the resolution may be a problem.

The problem of the frame rate is not the resolution of the image.
Actualy, in the WinForms example the performance of the depth image generation is too low and it drops the fps.
See the issue #683

Surely the pixel copying should be improved and use the same pixel format so a simple mem block copy can be performed.
Reducing the resolution is just a quick fix/workaround as the window size is smaller anyway.

Surely... But the correct fix i think that is fix the depth image generation. For example, in the WinForms example I can run with 30 fps only doing it.

If you want save the images for anything (to make a video for example), reduce the resolution may be a problem.

 It should be nicely fixed with the real API usage. I will update the PR. Thanks for the info! 🙌

The problem of the frame rate is not the resolution of the image.
Actualy, in the WinForms example the performance of the depth image generation is too low and it drops the fps.
See the issue #683

Surely the pixel copying should be improved and use the same pixel format so a simple mem block copy can be performed.
Reducing the resolution is just a quick fix/workaround as the window size is smaller anyway.

Surely... But the correct fix i think that is fix the depth image generation. For example, in the WinForms example I can run with 30 fps only doing it.

If you want save the images for anything (to make a video for example), reduce the resolution may be a problem.

 It should be nicely fixed with the real API usage. I will update the PR. Thanks for the info! 🙌

I have made a PR with the changes for winforms #686

Fixed wrong commit


[Bug]  can't start using java11

Bug Type (问题类型)
others (please edit later)
Before submit

[X] 我已经确认现有的 Issues 与 FAQ 中没有相同 / 重复问题

Environment (环境信息)
{"versions":{"version":"v1","core":"<IP_ADDRESS>","gremlin":"3.4.3","api":"<IP_ADDRESS>"}}
Expected & Actual behavior (期望与实际表现)
hugegraph-dist/src/assembly/static/bin/hugegraph-server.sh
if [[ $? -ne 0 || $JAVA_VERSION < $EXPECT_JDK_VERSION ]]; then
    echo "Please make sure that the JDK is installed and the version >= $EXPECT_JDK_VERSION" \
         >> ${OUTPUT}
    exit 1
fi

directly using < may cause problem。My default java 11 will exit at this. but java 11 is bigger than java 8.

https://github.com/apache/incubator-hugegraph/blob/5172f773a8e7ec6811423c67bd83105c3e73ae83/hugegraph-dist/src/assembly/static/bin/hugegraph-server.sh#L52
yep, seems we need update the config to 11 (would u mind to submit a PR to fix it?)

I have encountered this problem before. I must start the project with java 1.8

I have encountered this problem before. I must start the project with java 1.8

(As mentioned above) It's easy to fix this problem, would u like to submit a PR?

I'll fix this problem in first apache version


Updated OMS data plane C# namespace & output-folder

Per C# SDK PR feedback, I needed to update the namespace & output-folder in the README.md of the OMS data plane API spec.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[n/a] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

No modification for AutorestCI/azure-sdk-for-python

No modification for AutorestCI/azure-sdk-for-ruby

No modification for AutorestCI/azure-sdk-for-node


Does --golden-run resolves symbolic links?

Ragger has a capacity to update the currently used  snapshots with the --golden-run parameter.
It's very useful when the OS updates some fonts or slightly move elements: devs do not have to take all the new snapshots by hand or run the tests 1000x times to update their tests.
In the same time, it can happen that snapshots are not directly images but links to other images, to avoid duplication.
In this case, is Ragger able to correctly update the original images, rather than replacing the links?

It doesn't, when running in --golden-run, this part of the code is called:
https://github.com/LedgerHQ/ragger/blob/master/src/ragger/backend/speculos.py#L206-L208
Which call this:
https://github.com/LedgerHQ/ragger/blob/master/src/ragger/backend/speculos.py#L189-L192
Which will replace the link with the new snapshot.
We could probably add some logic on the _save_screen_snapshot() function to check if the existing file is a link, and if so replace the link target.

I've been using the --golden_run feature extensively for the MISC porting, it turns out that the link are correctly resolved and the pointed images correctly updated.
This must be directly resolved at a system level: if you cp a file on a link, it is the link destination which is updated.
I guess this issue is resolved then.


feat: add pool fee and pool fee rate

This PR adds

Pool fee rate: from the idl
Pool fee: takes cumulative token fee from the idl and token price from the api to calculate pool fee

How has this been tested?
Types of changes

[ ] Technical Debt (non-breaking change which removes unused code/assets)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] The related ClickUp task has been linked to this PR
[ ] The person creating the pull request is listed in "Assignees"
[ ] Change requires updated documentation

There is still room for improvement here. We should pre fetch the token prices to calculate the fee. Right now it is taking some time. I have left this to be picked up in speed enhancements since token list fetching is loosely related to this.


Godot stops drawing background after extended use

Operating system or device - Godot version
Godot Engine v3.1.2
Microsoft Windows Version 1809 (OS Build 17763.973)
(AMD Radeon(TM) Vega 3 Graphics)
Issue description
Godots editor will stop redrawing the background after about an 2-4 hours (sooner if there are particles or other similar things)
Steps to reproduce:
Oddly enough I haven't been able to reproduce this on other devices, but it happens consistently on the computer I am experiencing the bug on
Minimal reproduction project:
Any project will do this on my laptop. Even just a single sprite.

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

Closing as there are no other reports and no reproduction with a more current version. Lets hope this one is fixed!


How to load pre-trained adapters to tune on my downstream task ?

hi，thanks for your great work! I am new to Adapter-transformers. In my recent exp, I wanna load pre-trained adapters to continue to tune on my downstream task.  I look up the docs and don't find any solutions or related examples. Could you give me some suggestions? Thanks very much.
task_name = 'MRC'
config = AdapterConfig.load("pfeiffer")
self.bert.load_adapter("qa/squad1@ukp", config=config)
# self.bert.add_adapter(task_name) #, config=adapter_config)
self.bert.train_adapter(task_name)
self.bert.set_active_adapters(task_name)

there is my code with bug ValueError: Unable to resolve adapter without the name of a model. Please specify model_name.  just for reference.

Hey @SinclairCoder,
the resolving of pre-trained adapters within the load_adapter() method is dependent on the pre-trained base model (e.g. bert-base-uncased, roberta-base etc.). In many cases, adapter-transformers will be able to infer this name automatically (e.g. if you load a model using from_pretrained(). If this is not possible, the load_adapter() methods expects the name of a pre-trained model as a parameter.
So, in your case, if you would like to load an adapter trained for e.g. bert-base-uncased, please try to add model_name="bert-base-uncased" to the load_adapter() method call.
Hope this helps :)


Stops working if wifi disconnects and reconnects

Looks like the net_ctl callback needs to be improved.
Note: As a workaround I restart my vita when it happens, this button makes it convenient.

what about listening for ScePowerCallback to get close tear down the server when going to sleep and setting the connection up again when the device wakes up?

@gnuton If you fix, please do a pull request! 👍


Constants overhaul

This implements the ability to run look and find on power creeps, adds some power creep related constants, and adds other misc. constant updates.
This does add a PowerCreep type, but it doesn't add any implementation to it beyond it being a RoomObject. This should be enough to at least notice power creeps existing, but not really enough to do anything with one's own power creeps.

Rebased on master - going to add more constants though to see how close I can get to completion.

Rebased after #166 and did a lot more constant management.
Added some breaking changes which may or may not want to be part of this PR?

Thanks for the review! I have a lot to fix up and add comments for.

I'm concerned with the very uneven treatment of TryFrom implementations

With this, I think it should be fairly consistent in that everything implements TryFrom<Value>, but I agree that the "extra" impls are kind of scattered around... I left in the ones for ReturnCode and Exit mostly because I didn't want to touch more code outside of the constants file, but I'll go in and remove those now.

By uneven treatment, I mostly referred to the try_from implementations that panic! rather than return an error. I get that it should probably never happen, but it also sounds like the exact reason we're doing try_from rather than from.

Fix #58

Addresses some of #88

Re-rebased on master, and fixed up!
In addition to addressing the comments made here, it also includes some new find module improvements, and a small Density improvement.
As a note, I think there's something that this PR breaks, since I've been running my AI using it and it's been panicking on a find call somewhere. I'm not sure what exactly is broken, but once I find it I'll make a note of it here.

While I'm super excited for this, there is one problem: I assumed that #[derive(Deserialize)] in combination with serde-json and/or stdweb's Value deserializer implementation, enum variants could be deserialized from both integers and strings.
For these formats, when deserializing an enum, only string names for the variants are supported.

Required adding a bit more code, but decoding all the constants which are encoded as integers but are actually strings in game should work now.


Query is executed when executing a mutation

Describe the bug
I was trying out the latest version of react-query today with Suspense (no CM) and noticed that every time I was executing a mutation it would re-execute the query. Is this how it's supposed to work? I thought you would have to invalidate the query yourself in one of the mutation's event handlers!?
To Reproduce
Steps to reproduce the behavior:

Open the following Code Sandbox.
Click the 'Add' button.
Check the console: fetchTodos was called twice before executing the onMutate event handler. (The first call is the actual query of course)

Expected behavior
Query does not re-execute before the onMutate handler is called.
Desktop (please complete the following information):

OS: Linux
Browser: Chromium
Version: 87

Seems to be working like expected in the sandbox. Sure the double fetch is not because of refetchOnWindowFocus?

can confirm it's working, and it's very likely the refetchOnWindowFocus, as this also happens when you "come back" with focus from the browser devtools


Is this project dead?

Hi, this is very interesting and useful project, but is it dead or unmaintained?
Thanks!

Do you have a feature proposal or any issue to report?
I will come back to my TODO list some time, but I have no deadline for that.
In that sense I would say that the project is not dead or unmaintained.

As I heard nothing from you since your last message I will close this issue assuming you have no further questions.
Don't hesitate to open new issues otherwise.
You can check the new release with changes introducing a new example based on "synchronized" simulations with circuitjs.


Set application_name in DB connection string

It's good practice to do this and helps when debugging while looking at pg_stat_activity, we might even want to distinguish between readers and writers.

We should also include teh application version in the application name string.


Unable to build on latest version of Xcode | ContextContainer.h not found

Environment

react-native info output:

[Codegen] Done.
Analyzing dependencies
RNFBApp: Using overridden static_framework value of 'true'
RNFBMessaging: Using overridden static_framework value of 'true'
Downloading dependencies
Installing RnBugfender 2.2.1 (was 2.1.2)
Generating Pods project
Setting REACT_NATIVE build settings
Setting CLANG_CXX_LANGUAGE_STANDARD to c++17 on /Users/afazsmac/Projects/univiser/uni-buddy-mobile/ios/UniviserBuddyMobileV2.xcodeproj
Pod install took 10 [s] to run
Integrating client project
Pod installation complete! There are 64 dependencies from the Podfile and 77 total pods installed.
afazsmac@Afazss-MacBook-Air uni-buddy-mobile % npx react-native info
warn Package @ant-design/icons-react-native contains invalid configuration: "dependency.assets" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.
warn Package @ant-design/react-native contains invalid configuration: "dependency.assets" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.
info Fetching system and libraries information...
System:
  OS: macOS 13.5
  CPU: (8) arm64 Apple M1
  Memory: 80.66 MB / 8.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.16.0
    path: /usr/local/bin/node
  Yarn: Not Found
  npm:
    version: 9.5.1
    path: /usr/local/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.12.1
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK: Not Found
IDEs:
  Android Studio: Not Found
  Xcode:
    version: 14.3.1/14E300c
    path: /usr/bin/xcodebuild
Languages:
  Java: Not Found
  Ruby:
    version: 3.2.2
    path: /opt/homebrew/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.3
    wanted: 0.72.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

are you using the new architecture?

Yes

which version of react & react-native are you using?
"react": "18.2.0",
"react-native": "0.72.3",

Description
getting an error while building using the latest version of xcode

Reproducible Demo
I'm using it as a peer dependency with  AntDesign since I have included it on my project but I'm not using it

Hello @ismdcf, thank you for the detailed report 👍
I will take a look on that!

Hello again, @ismdcf!
From what I see in the package.json of AntDesign here, it is using super old version of Slider, v3.0.3.
This version doesn't have the new architecture support, so when you are trying to compile the RNCSliderComponent.mm for new arch, it will search for headers with declarations from React Native for new architecture, which won't be available for lower versions.
Also, I assume you did it, but just in case: please remember to clean the project (git clean -fxd ios and/or Cmd+Shift+K in XCode) and reinstall the pods for new architecture (RCT_NEW_ARCH_ENABLED=1 pod install) to make sure the new arch is used without old arch or stale deps.
I also did some googling around, and I found this problem having a workaround, described in details for example here, so please check it if maybe it will solve your issue.
If there's anything I missed or don't quite get it yet, please let me know or clarify, so I can further support you.

Hi @BartoszKlonowski
Thank you for the heads-up. I was able to build the ios app after adding the required to the podfile.
insidepost_install do |installer|block I added the following line
 installer.pods_project.targets.each do |target|
      if target.name == "react-native-slider"
        append_header_search_path(target, "${PODS_ROOT}/../../node_modules/react-native/ReactCommon")
      end
    end


Optimising Pod VM size and startup time

To make peer-pods approach a viable solution for serverless computing, startup times matter. Even otherwise the startup time should be comparable to using Kata with local hypervisor (qemu/clh).
This is a tracker issue to document findings and identify scope of improvement.

[ ] Identify bare minimal requirement for a pod VM image (kernel, minimal user-space)
[ ] Identify improvement areas to speed up container startup time

Do we have a baseline for what "startup time ... using Kata with local hypervisor" is?

@jtumber-ibm I'll get some baseline pod startup time data and update this issue.

@bpradipt @jtumber-ibm
Tested on AWS Openshift cluster
Following startup time was observed
For peer pod t3.small instance - 1 minute 41 second
Name:     hello-openshift
Namespace:  default
Priority:   0
Node:     ip-10-0-187-226.us-east-2.compute.internal/<IP_ADDRESS>
Start Time:  Wed, 08 Feb 2023 18:11:16 +0530
Labels:    app=hello-openshift
Annotations: [k8s.v1.cni.cncf.io/network-status](http://k8s.v1.cni.cncf.io/network-status):
        [{
          "name": "openshift-sdn",
          "interface": "eth0",
          "ips": [
            "<IP_ADDRESS>"
          ],
          "default": true,
          "dns": {}
        }]
       [k8s.v1.cni.cncf.io/networks-status](http://k8s.v1.cni.cncf.io/networks-status):
        [{
          "name": "openshift-sdn",
          "interface": "eth0",
          "ips": [
            "<IP_ADDRESS>"
          ],
          "default": true,
          "dns": {}
        }]
       [kata.peerpods.io/instance_type](http://kata.peerpods.io/instance_type): t2.small
Status:    Running
IP:      <IP_ADDRESS>
IPs:
 IP: <IP_ADDRESS>
Containers:
 hello-openshift:
  Container ID:  cri-o://07062a709864f4e32723adfe1fd9c9d51464d76e9ca938dc286373c1d5f5fb85
  Image:     [quay.io/openshift/origin-hello-openshift](http://quay.io/openshift/origin-hello-openshift)
  Image ID:    [quay.io/openshift/origin-hello-openshift@sha256:369c8324bea625fdb94c1e8cc992ae9d2b0fe780acace7b8c8080349792f3b96](http://quay.io/openshift/origin-hello-openshift@sha256:369c8324bea625fdb94c1e8cc992ae9d2b0fe780acace7b8c8080349792f3b96)
  Port:      8888/TCP
  Host Port:   0/TCP
  State:     Running
   Started:   Wed, 08 Feb 2023 18:12:47 +0530
  Ready:     True
  Restart Count: 0
  Limits:
   [kata.peerpods.io/vm](http://kata.peerpods.io/vm): 1
  Requests:
   [kata.peerpods.io/vm](http://kata.peerpods.io/vm): 1
  Environment:      <none>
  Mounts:
   /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-ntdth (ro)
Conditions:
 Type       Status
 Initialized    True
 Ready       True
 ContainersReady  True
 PodScheduled   True
Volumes:
 kube-api-access-ntdth:
  Type:          Projected (a volume that contains injected data from multiple sources)
  TokenExpirationSeconds: 3607
  ConfigMapName:      kube-root-ca.crt
  ConfigMapOptional:    <nil>
  DownwardAPI:       true
  ConfigMapName:      openshift-service-ca.crt
  ConfigMapOptional:    <nil>
QoS Class:          BestEffort
Node-Selectors:       <none>
Tolerations:         [node.kubernetes.io/not-ready:NoExecute](http://node.kubernetes.io/not-ready:NoExecute) op=Exists for 300s
               [node.kubernetes.io/unreachable:NoExecute](http://node.kubernetes.io/unreachable:NoExecute) op=Exists for 300s
Events:
 Type  Reason     Age  From   Message
 ----  ------     ---- ----   -------
 Normal AddedInterface 100s multus  Add eth0 [<IP_ADDRESS>/23] from openshift-sdn
 Normal Pulling     14s  kubelet Pulling image "[quay.io/openshift/origin-hello-openshift](http://quay.io/openshift/origin-hello-openshift)"
 Normal Pulled     14s  kubelet Successfully pulled image "[quay.io/openshift/origin-hello-openshift](http://quay.io/openshift/origin-hello-openshift)" in 609.587941ms
 Normal Created     11s  kubelet Created container hello-openshift
 Normal Started     11s  kubelet Started container hello-openshift

For peer pod c5.xlarge instance - 2 minute 45 second
Name:     hello-openshift
Namespace:  default
Priority:   0
Node:     ip-10-0-187-226.us-east-2.compute.internal/<IP_ADDRESS>
Start Time:  Wed, 08 Feb 2023 18:00:31 +0530
Labels:    app=hello-openshift
Annotations: [k8s.v1.cni.cncf.io/network-status](http://k8s.v1.cni.cncf.io/network-status):
        [{
          "name": "openshift-sdn",
          "interface": "eth0",
          "ips": [
            "<IP_ADDRESS>"
          ],
          "default": true,
          "dns": {}
        }]
       [k8s.v1.cni.cncf.io/networks-status](http://k8s.v1.cni.cncf.io/networks-status):
        [{
          "name": "openshift-sdn",
          "interface": "eth0",
          "ips": [
            "<IP_ADDRESS>"
          ],
          "default": true,
          "dns": {}
        }]
       [kata.peerpods.io/instance_type](http://kata.peerpods.io/instance_type): t2.small
Status:    Running
IP:      <IP_ADDRESS>
IPs:
 IP: <IP_ADDRESS>
Containers:
 hello-openshift:
  Container ID:  cri-o://cbd66cd5255be1d61a0fa4440b8480ffe8a9b89b71dc288a2fef561f81980b90
  Image:     [quay.io/openshift/origin-hello-openshift](http://quay.io/openshift/origin-hello-openshift)
  Image ID:    [quay.io/openshift/origin-hello-openshift@sha256:369c8324bea625fdb94c1e8cc992ae9d2b0fe780acace7b8c8080349792f3b96](http://quay.io/openshift/origin-hello-openshift@sha256:369c8324bea625fdb94c1e8cc992ae9d2b0fe780acace7b8c8080349792f3b96)
  Port:      8888/TCP
  Host Port:   0/TCP
  State:     Running
   Started:   Wed, 08 Feb 2023 18:01:56 +0530
  Ready:     True
  Restart Count: 0
  Limits:
   [kata.peerpods.io/vm](http://kata.peerpods.io/vm): 1
  Requests:
   [kata.peerpods.io/vm](http://kata.peerpods.io/vm): 1
  Environment:      <none>
  Mounts:
   /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-dwdsx (ro)
Conditions:
 Type       Status
 Initialized    True
 Ready       True
 ContainersReady  True
 PodScheduled   True
Volumes:
 kube-api-access-dwdsx:
  Type:          Projected (a volume that contains injected data from multiple sources)
  TokenExpirationSeconds: 3607
  ConfigMapName:      kube-root-ca.crt
  ConfigMapOptional:    <nil>
  DownwardAPI:       true
  ConfigMapName:      openshift-service-ca.crt
  ConfigMapOptional:    <nil>
QoS Class:          BestEffort
Node-Selectors:       <none>
Tolerations:         [node.kubernetes.io/not-ready:NoExecute](http://node.kubernetes.io/not-ready:NoExecute) op=Exists for 300s
               [node.kubernetes.io/unreachable:NoExecute](http://node.kubernetes.io/unreachable:NoExecute) op=Exists for 300s
Events:
 Type  Reason     Age  From   Message
 ----  ------     ----  ----   -------
 Normal AddedInterface 2m10s multus  Add eth0 [<IP_ADDRESS>/23] from openshift-sdn
 Normal Pulling     50s  kubelet Pulling image "[quay.io/openshift/origin-hello-openshift](http://quay.io/openshift/origin-hello-openshift)"
 Normal Pulled     49s  kubelet Successfully pulled image "[quay.io/openshift/origin-hello-openshift](http://quay.io/openshift/origin-hello-openshift)" in 549.836917ms
 Normal Created     47s  kubelet Created container hello-openshift
 Normal Started     47s  kubelet Started container hello-openshift

For runc pod (runtime default) - 7 seconds
Name:     nginx
Namespace:  default
Priority:   0
Node:     ip-10-0-219-218.us-east-2.compute.internal/<IP_ADDRESS>
Start Time:  Wed, 08 Feb 2023 17:47:28 +0530
Labels:    run=nginx
Annotations: [k8s.v1.cni.cncf.io/network-status](http://k8s.v1.cni.cncf.io/network-status):
        [{
          "name": "openshift-sdn",
          "interface": "eth0",
          "ips": [
            "<IP_ADDRESS>"
          ],
          "default": true,
          "dns": {}
        }]
       [k8s.v1.cni.cncf.io/networks-status](http://k8s.v1.cni.cncf.io/networks-status):
        [{
          "name": "openshift-sdn",
          "interface": "eth0",
          "ips": [
            "<IP_ADDRESS>"
          ],
          "default": true,
          "dns": {}
        }]
Status:    Running
IP:      <IP_ADDRESS>
IPs:
 IP: <IP_ADDRESS>
Containers:
 nginx:
  Container ID: cri-o://17418aed26b8c36b4aca40f3724c620ee4022440109593ef0dcf2449939f9994
  Image:     [quay.io/bpradipt/http-echo:nonroot](http://quay.io/bpradipt/http-echo:nonroot)
  Image ID:   [quay.io/bpradipt/http-echo@sha256:ec3c0642ff30050ea3f462c8f662ffa53036f6a3e089085714c7ff13501002dc](http://quay.io/bpradipt/http-echo@sha256:ec3c0642ff30050ea3f462c8f662ffa53036f6a3e089085714c7ff13501002dc)
  Port:     <none>
  Host Port:   <none>
  Args:
   -text
   Hello from Kata container
   -listen
   :8080
  State:     Running
   Started:   Wed, 08 Feb 2023 17:47:33 +0530
  Ready:     True
  Restart Count: 0
  Environment:  <none>
  Mounts:
   /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-77wkg (ro)
Conditions:
 Type       Status
 Initialized    True
 Ready       True
 ContainersReady  True
 PodScheduled   True
Volumes:
 kube-api-access-77wkg:
  Type:          Projected (a volume that contains injected data from multiple sources)
  TokenExpirationSeconds: 3607
  ConfigMapName:      kube-root-ca.crt
  ConfigMapOptional:    <nil>
  DownwardAPI:       true
  ConfigMapName:      openshift-service-ca.crt
  ConfigMapOptional:    <nil>
QoS Class:          BestEffort
Node-Selectors:       <none>
Tolerations:         [node.kubernetes.io/not-ready:NoExecute](http://node.kubernetes.io/not-ready:NoExecute) op=Exists for 300s
               [node.kubernetes.io/unreachable:NoExecute](http://node.kubernetes.io/unreachable:NoExecute) op=Exists for 300s
Events:
 Type  Reason     Age  From        Message
 ----  ------     ---- ----        -------
 Normal Scheduled    12s  default-scheduler Successfully assigned default/nginx to ip-10-0-219-218.us-east-2.compute.internal
 Normal AddedInterface 10s  multus       Add eth0 [<IP_ADDRESS>/23] from openshift-sdn
 Normal Pulling     9s  kubelet      Pulling image "[quay.io/bpradipt/http-echo:nonroot](http://quay.io/bpradipt/http-echo:nonroot)"
 Normal Pulled     7s  kubelet      Successfully pulled image "[quay.io/bpradipt/http-echo:nonroot](http://quay.io/bpradipt/http-echo:nonroot)" in 2.274906876s
 Normal Created     7s  kubelet      Created container nginx
 Normal Started     7s  kubelet      Started container nginx

Thanks a lot @abhbaner. Can you please confirm the pod VM image distro - CentOS, RHEL or Ubuntu ?

A rough sequence diagram of the Pod VM startup process

@jtumber-ibm @stevenhorsman @surajssd @yoheiueda @huoqifeng

I did the same experiments on my cluster in IBM Cloud VPC.
runc
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  4s    default-scheduler  Successfully assigned default/nginx to k8s-worker
  Normal  Pulling    4s    kubelet            Pulling image "nginx"
  Normal  Pulled     3s    kubelet            Successfully pulled image "nginx" in 1.173574561s
  Normal  Created    3s    kubelet            Created container nginx
  Normal  Started    3s    kubelet            Started container nginx

peer pod
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  44s   default-scheduler  Successfully assigned default/nginx to k8s-worker
  Normal  Pulling    7s    kubelet            Pulling image "nginx"
  Normal  Pulled     3s    kubelet            Successfully pulled image "nginx" in 4.218585385s
  Normal  Created    3s    kubelet            Created container nginx
  Normal  Started    1s    kubelet            Started container nginx

I calculated an elapsed time in each state transition as follows.  I think the container image is already cached in the case of runc.

State Transition
runc
peer-pod

Scheduled→Pulling
0s
37s

Pulling→Pulled
1s
4s

Pulled→Created
0s
0s

Created→Started
0s
2s

I suspect getting close to a baseline with local kata on kvm/qemu will be tough. I don't have concrete measurements at the moment, but time-to-pod on local kata was a matter of a few seconds (~3-10s), even for an SEV-SNP enabled guest, which has a bit of an init overhead.
Below is a measurement from a CAA test, it's not broken down by the individual CAA steps, but you can kind of extrapolate from the k8s logs:

The biggest chunk of time is the c(vm) provisioning. I think this will apply to most CSPs.
According to our tests, the size of the os-disk (we compared 5GB and 30GB) doesn't make a dent in the overall startup time. However, that depends on the CSP and a lot of other factors like provisioning method, storage class, etc...
The time it takes from a successful VM creation to pod startup can be broken down into boot (time it takes for agent-protocol-forwarder to be responsive and kata-agent's pod provisioning (pulling images, etc).
boot time should be deterministic and in a stripped down os-disks can be limited to a few seconds (~4s in our tests). Running systemd-analyze plot on a peer-pod vm can yield possible opportunities for improvement.
pod-provisoning depends on the workload (number of containers, size, image registry, etc.. For a simple nginx pod with sidecar this amounted to 2s per container, so ~4s). That number is most likely comparable to local kata, it's open how future image sharing/retrieval schemes will impact this number, since the "host" is remote in this case. Improvements could still be conceivable for peer pods (e.g. remote, block based lazy pulling)

kubectl get events -o custom-columns=Timestamp:.firstTimestamp,Message:.message --field-selector involvedObject.name=nginx-7df44f78b6-tgxnx
Timestamp              Message
2023-01-27T08:54:06Z   Successfully assigned default/nginx-7df44f78b6-tgxnx to k8s-ci
2023-01-27T08:54:51Z   Container image "nginx:1.14.2" already present on machine
2023-01-27T08:54:51Z   Created container nginx
2023-01-27T08:54:53Z   Started container nginx
2023-01-27T08:54:53Z   Container image "*" already present on machine
2023-01-27T08:54:53Z   Created container sidecar
2023-01-27T08:54:55Z   Started container sidecar

Some additional data purely from the pod VM image standpoint.
I used both CentOS Stream 8 and Ubuntu 20.04 cloud images for relative comparison.
CentOS Stream8 Cloud image
$ oc get pods
NAME                         READY   STATUS    RESTARTS   AGE
echo-kata-67ccb48d7b-wpwnq   1/1     Running   0          69s

[root@podvm-echo-kata-67ccb48d7b-wpwnq-6e216995 peerpod]# systemd-analyze time
Startup finished in 1.266s (kernel) + 3.378s (initrd) + 47.053s (userspace) = 51.698s
multi-user.target reached after 29.136s in userspace

[root@podvm-echo-kata-67ccb48d7b-wpwnq-6e216995 peerpod]# systemd-analyze blame
         24.677s cloud-init.service
         18.057s kdump.service
          3.278s NetworkManager-wait-online.service
          2.283s cloud-init-local.service
          1.062s initrd-switch-root.service
           773ms dracut-initqueue.service
[snip]

Disabling kdump.service from the pod VM image gave the following results:
[kcli@virtlab714 peerpods-files]$ oc get pods
NAME                         READY   STATUS    RESTARTS   AGE
echo-kata-67ccb48d7b-gt9nv   1/1     Running   0          59s

[peerpod@podvm-echo-kata-67ccb48d7b-gt9nv-4b58c292 peerpod]# systemd-analyze time
Startup finished in 1.237s (kernel) + 3.378s (initrd) + 30.510s (userspace) = 35.126s
multi-user.target reached after 29.231s in userspace
[root@podvm-echo-kata-67ccb48d7b-gt9nv-4b58c292 peerpod]# systemd-analyze blame
         24.898s cloud-init.service
          3.361s NetworkManager-wait-online.service
          2.264s cloud-init-local.service
          1.001s initrd-switch-root.service
           776ms dracut-initqueue.service

Ubuntu 20.04 cloud image
$ oc get pods
NAME                         READY   STATUS    RESTARTS   AGE
echo-kata-67ccb48d7b-r4bcb   1/1     Running   0          70s

root@podvm-echo-kata-67ccb48d7b-r4bcb-15a38e4a:/home/peerpod# systemd-analyze time
Startup finished in 4.150s (kernel) + 14.571s (userspace) = 18.721s
graphical.target reached after 13.728s in userspace
root@podvm-echo-kata-67ccb48d7b-r4bcb-15a38e4a:/home/peerpod# systemd-analyze blame
41.390s apt-daily.service
 3.082s snapd.service
 3.029s systemd-networkd-wait-online.service
 2.803s snap.lxd.activate.service
 2.624s cloud-init-local.service
 1.549s cloud-init.service
 1.414s cloud-config.service
 1.383s apt-daily-upgrade.service
 1.234s dev-sda1.device
 1.222s ua-timer.service

Disabling apt-daily.service gave the following results:
$ oc get pods
NAME                         READY   STATUS    RESTARTS   AGE
echo-kata-67ccb48d7b-q4q8r   1/1     Running   0          39s

root@podvm-echo-kata-67ccb48d7b-q4q8r-faf29ce7:/home/peerpod# systemd-analyze time
Startup finished in 4.162s (kernel) + 14.206s (userspace) = 18.369s
graphical.target reached after 13.457s in userspace
root@podvm-echo-kata-67ccb48d7b-q4q8r-faf29ce7:/home/peerpod# systemd-analyze blame
3.025s systemd-networkd-wait-online.service
2.683s snap.lxd.activate.service
2.363s cloud-init-local.service
2.269s snapd.service
1.848s cloud-init.service

@yoheiueda @mkulke

This can be closed as we now use a minimalistic image built via mkosi and only required systemd services


Gmail period and plus sign support

Steps to reproduce the problem:

Create a gmail email account. For example<EMAIL_ADDRESS>Create an github user with a verfied email of<EMAIL_ADDRESS>Use CLA Assistant in your repo.
Sign CLA.
Create PR.

What is the expected result?
CLA check should pass.
What happens instead?
CLA check fails. Only exact match will pass.
Notes
All the following email addresses work by default with Gmail with the registered<EMAIL_ADDRESS>email address:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

@Ecsy I wonder how does GitHub handle email addresses with period and plus sign? If I make a commit with<EMAIL_ADDRESS>and in my github account is<EMAIL_ADDRESS>stored. Would GitHub assign this commit to my user?


Api key is missing/wrong

When i click on get api key then i will get the error related to invalid url

I HAVE the same problem
you got the solution or what ?

You don't need an API Key since the project was open sourced.

update viro react to 2.17


styled the landing page

i have styled the landing page see if it is to your liking and please respond


Using std::hash::hash by mistake.

There's a line use std::hash::{Hasher, Hash, hash}; in util.rs that imports the hash function. This is unstable but wasn't flagged due to bug rust-lang/rust/issues/28075.
It's unused, so fix is simply to remove the import.

@seiflotfy can be closed as this was fixed in the meantime.


Preference label rendered incorrectly

The default activation duration preference is displaying its label text below the options and description text:

@redbassett that's in which version? This looks fine to me in 1.4.0 (140). Thx

Sorry! Missed that part. 1.4.0 (140) installed via brew. Persists after re-install (brew cask uninstall). Running on OS 10.10.5.

I booted up my OS X VMs to verify and you're right, this looks broken, but it's only happening on Yosemite. El Cap and newer are fine.

I'll have a look, but this bug won't make it to the top of my prio list, because Yosemite is already a couple of years old 😉

No problem. I'm stuck on Yosemite for some interesting reasons, but as long as it's not in newer versions, all is well.

I am guessing that this may be caused by the preferredMaxLayoutWidth property of the NSTextField. In Interface Builder, there are three options: ‘automatic’, ‘first runtime layout width’ and ‘explicit’. The first two seem to be unique to IB, because preferredMaxLayoutWidth only expects a float.
The first option (‘automatic’) is not available in Yosemite, but this is the one the project currently uses. For some reason, this is not reported as a warning, even though I have seen it many times before. I think that the fall-back value for Yosemite would be ‘first runtime layout width’, which causes the text field not to grow wider than the value it has in Interface Builder. At runtime, the text field will accordingly not behave as expected. I am suspecting that this will also be the case for translations, particularly those that result in a wider label than in English.
The solution would be to use an explicit value. You can use something large, such as 400px. The text field should still shrink to its smallest intrinsic width, but it will have ample space to widen if it needs the space.

I don't think I will fix this anytime soon. I plan to keep support for macOS Yosemite but treat this layout issue as a known issue. I hope many users have moved on to more recent versions of macOS.


Drag and Drop

I'm stumped on how to get the drag function introduced in iOS 11 to work with DKAssets. Below is what I have, but I get the error "Argument type 'DKAsset?' does not conform to expected type 'NSItemProviderWriting'". Any help is great appreciated.
func collectionView(_ collectionView: UICollectionView, itemsForBeginning session: UIDragSession, at indexPath: IndexPath) -> [UIDragItem] {
        let dragItem = self.dragItem(forPhotoAt: indexPath)
        return [dragItem]
    }
private func dragItem(forPhotoAt indexPath: IndexPath) -> UIDragItem {
        let image = self.assets?[indexPath.item]
        let dragItem = UIDragItem(itemProvider: NSItemProvider(object: image))
        dragItem.localObject = image
        return dragItem
    }

You can extend the DKAsset to make it adopt NSItemProviderWriting protocol like this:
extension DKAsset: NSItemProviderWriting {
    public static var writableTypeIdentifiersForItemProvider: [String] {
        // ...
    }

    public func loadData(withTypeIdentifier typeIdentifier: String, forItemProviderCompletionHandler completionHandler: @escaping (Data?, Error?) -> Void) -> Progress? {
        // ...
    }
}

Or make a class that contains a DKAsset instance:
class Provider: NSItemProviderWriting {
    var asset: DKAsset?

    ...
}

Great, thank you!

Closing this thread :)


Turn off parallel docs build and pin dependencies

Summary
The docs build is suddenly breaking with
  File "/home/runner/work/qiskit-experiments/qiskit-experiments/.tox/docs-parallel/lib/python3.8/site-packages/sphinx/util/parallel.py", line 126, in _join_one
    raise SphinxParallelError(*result)
sphinx.errors.SphinxParallelError: sphinx.errors.ExtensionError: Unable to find kernel (exception: No such kernel named python3)

Turning off the parallel flag didn't solve the problem, but pinning ipykernel and jupyter-client, both of which put out new releases yesterday, solved the problem. I'm keeping the parallel flag off since it tends to cause issues until this compatibility issue is resolved.

I wonder if there is something unique to our set up here? I set up a new environment today and found that I still had to roll these libraries back even seven months later, and I don't see anyone else complaining about Unable to find kernel on the jupyter-sphinx repo (except here but that one does not mention pinning jupyter-client and ipykernel, just installing ipykernel; I hit the error with the current latest ipykernel).


Can here fn.call be used? cause it seems hard to understand..

https://github.com/andregardi/use-global-hook/blob/355f1d8a83a0b2ff20081a25a3fb3e455c50ce41/index.js#L23

seems cannot. While I think there exist better way.

Yep,
fn.call would be more execute the function rather than bind the parameters.


Issue with Binding.ValidationRules wpf

This page has an example

<TextBox.Text>

<Binding.ValidationRules>
<src:FutureDateRule />
</Binding.ValidationRules>

</TextBox.Text>

But what does src:   namespace refer to ? When I use the name space of my application, where the validation rule class lives, app will not compile:
Severity	Code	Description	Project	File	Line	Suppression State
Error		The tag 'CashReportFoundByDateRule' does not exist in XML namespace 'clr-namespace:Restsys;assembly=RestsysWin'. Line 158 Position 46.	RestsysWin	C:\projects\Restsys\RestsysUI\MainWindow.xaml	158

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87567591-0d1a-a791-a609-fa7a3986d43c
Version Independent ID: 29542eb2-683e-0217-71aa-14671a6f193a
Content: Data binding overview - WPF
Content Source: docs/desktop-wpf/data/data-binding-overview.md
Product: dotnet-desktop
Technology: dotnet-wpf
GitHub Login: @adegeo
Microsoft Alias: adegeo

src would refer to the namespace that the AuctionItem type exists in.
If this doesn't answer your question please feel free to reopen it.


testing

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

All jobs on 75df93c : invalidated by @wangcj05

Job Precheck on 75df93c : invalidated by @wangcj05

Job Precheck on 75df93c : invalidated by @wangcj05

Job Precheck on 75df93c : invalidated by @wangcj05

All jobs on 75df93c : canceled by @wangcj05

This is an additional testing PR for testing gitlab plugin system with deploy key. This PR can be closed since the deploy key is working fine.


How to pass priority level during inference?

I am confused on how to pass the priority value when performing inference.
For example, if I set up the DynamicBatcher with two priority levels:
batcher = DynamicBatcher(
            max_queue_delay_microseconds=1000
            preserve_ordering=False
            priority_levels=2,
            default_priority_level=2,
        )

When using the client and calling infer_batch or infer_sample where is priority supposed to passed?  Looking at the docs I assumed that headers is where you would pass it, so I tried this:
client.infer_batch(..., headers={'priority': 1})

however that does not work.  I couldn't find any examples or more detailed docs anywhere on how priority is supposed to be used. Any help would be appreciated.

Thank you for your question.
It seems like you're trying to set the priority for inference requests when using a DynamicBatcher in Triton Inference Server. From the code you posted, I noticed that you are attempting to set the priority using the headers argument. The Triton client API doesn't use headers for setting priorities.
To properly utilize priority levels in Triton, we'd need to add this functionality into the API in a different way. One possible approach would be to extend the client by creating a subclass that handles priority specifically. Here's an example of how we could create a new class named PriorityModelClient that extends ModelClient:
I have written a code example for you to illustrate this idea. You can see it below:
from pytriton.client import ModelClient

class PriorityModelClient(ModelClient):
    def __init__(self, url, model_name, priority=None):
        super().__init__(url, model_name)
        self._priority = priority

    def _get_infer_extra_args(self):
        extra_args = super()._get_infer_extra_args()
        if self._priority is not None:
            extra_args["priority"] = self._priority
        return extra_args

This custom class introduces an internal variable to store the priority level and overrides the _get_infer_extra_args method to add the priority to the extra arguments sent with the inference request.
For usage, you'd instantiate the PriorityModelClient with the priority level and then use its infer_batch method as usual:
pcl = PriorityModelClient("grpc://localhost", "Test", priority=1)
pcl.infer_batch(np.char.encode([["test"]], "utf-8"))

Could you provide more detail on your user scenario and how you intend to use these priority levels? Understanding the context of your application and its requirements would allow us to suggest a more tailored solution.
Furthermore, in terms of API extension, we aim for a straightforward and unobtrusive integration of priority handling. If the current approach is inconvenient or insufficient for your use case, we'd love to gather feedback on desired features or improvements. This information is valuable and can guide us towards making enhancements that better support real-world scenarios.
I have also written a test code to start a server for this client example. You can see it below:
import numpy as np
from pytriton.decorators import batch

@batch
def _infer_fn(text):
    return {"text":text}

from pytriton.model_config import ModelConfig, Tensor, DynamicBatcher
from pytriton.triton import Triton, TritonConfig

batcher = DynamicBatcher(
            max_queue_delay_microseconds=1000,
            preserve_ordering=False,
            priority_levels=2,
            default_priority_level=2,
        )

triton = Triton()
triton.bind(
    model_name="Test",
    infer_func=_infer_fn,
    inputs=[
        Tensor(name="text", dtype=bytes, shape=(-1,)),
    ],
    outputs=[
        Tensor(name="text", dtype=bytes, shape=(-1,)),
    ],
    config=ModelConfig(decoupled=False, max_batch_size=2, batcher=batcher),
)

triton.run()

I hope this helps you to understand how to use the priority feature of the DynamicBatcher. If you have any further questions, please let me know.

Thanks for your response.  The solution above looks like it should work for my use case. I will try it and get back to you.
As a followup, Is there a reason why priority is not part of the constructor? To me, it feels like it's a similar type of parameter as inference_timeout_s which is part of the constructor.  Or alternatively have another parameter in the infer_* methods for supplying extra_args, similar to headers and parameters.

I will consider your request as feature proposal.


Will no longer be updated to the Raku ecosystem

Hello,
Thank you for the time and effort you have put in what is now the Raku Programming Language.  The language and its ecosystem are moving forward.
This means that this distribution will no longer be checked for updates by the Raku ecosystem.
This means that you will need to move your module to the zef ecosystem on the next update you make to these distributions.  Otherwise your update will simply not be seen by the ecosystem.
If you are no longer interested in maintaining this distribution, you can have this distribution moved to Raku Community Modules Adoption Center, where members of the Raku Community will take care of them.
This can be as easy as confirming that in a response to this issue.
Again, thank you for your time and efforts!
On behalf of the Raku Steering Council,
Elizabeth Mattijsen

I'm assuming this issue is automated, but for the record: this is a set of old incomplete bindings to an old toy graphics engine of mine that isn't maintained. I highly doubt anybody is using this. There's currently no reason for this module to exist.

Thanks for your reply.
It was semi-automated.  I've removed this distro from the ecosystem (although it is still installable through the Raku Ecosystem Archive).
Closing this issue now.  Feel free to archive this repo.


Implement patch between two StyleDiff

Almost had need for this during the highlight style implementation, but avoided it in the end since style remained Style instead of StyleDiff.
In any case, I figured implementing this acted as a good exercise for just what a specific StyleDiff should mean in regards to what it does when it's applied (especially in relation to what modifiers get applied, if a StyleDiff specifies all modifier, add_modifier and sub_modifier with various degrees of overlap).
The PR changes the existing semantics in this regard by making the order in which modifiers are defined important (modifier overrides existing add/remove details and add/remove build on top of the last modifier while avoiding overlap between each other).
Even if the patch functionality wasn't needed, I feel refining StyleDiff functionality now makes sense to avoid regrets once it can't be changed anymore due to backwards compatibility issues.
Implements #320 (which also has more background details on the actual changes).

I think that your patch implementation is more sensible than mine so I would happily take a PR to improve it. But I would rather keep this method only on Style for now until there is a real use case for it on StyleDiff.

I finally found a use case while working on #316 so merging this. Thanks !


Update prompt to add support for playlist voice commands

Adding additional info to the prompt to teach the LLM how to handle requests to play playlists.

@jozefKruszynski thoughts?

Looks pretty reasonable. I assume it's been tested by @nikito and works for him with no code changes.
We could probably also add another playlist slot to support the LLM flow also.

Looks pretty reasonable. I assume it's been tested by @nikito and works for him with no code changes. We could probably also add another playlist slot to support the LLM flow also.

Yes, tested with a few different playlists of mine. 🙂

Seems to be working fine with the suggested changes.


Fortunac/docs

Updated the site with installation instructions and the developer API, updated the tutorial and exercises with the new interface, and consolidated the flag documentation to the website,

On line 238 in wp.ml, we should have some error handling instead of always returning Ok (). If the Analysis returns an error, then the callback should return an Error variant, otherwise Ok ().

I'm going to create a ticket for this change since it is a bit out of scope for this PR. Otherwise, all the requested changes, have been pushed.

This is great! A couple minor suggestions, but you can make them a separate ticket and merge this now if you want.

Sounds good! These are small fixes, so I can add them to this PR.


Generate valid topics everywhere (support names with spaces)

This wraps up #239.
I went through the codebase and updated any topics and services I found to convert topics to valid ones if possible.
The spaces.sdf world has some entities with empty spaces, and wouldn't work correctly without this PR, mainly because of the spaces in the world name.
I also added the validTopic helper function which is handy to use when we have fallbacks for the topic. For example, when we accept a <topic> option from SDF, and fallback to a name-generated topic in case none is provided on SDF. Both these topics need to be validated, so the function helps with that.
We need to be mindful of this when adding new topics and plugins!

@osrf-jenkins run tests please

@osrf-jenkins run tests please

I'll wait for the ign-gui 4.1.1 release before merging this, otherwise spaces.sdf won't work well.

I'll wait for the ign-gui 4.1.1 release before merging this, otherwise spaces.sdf won't work well.


Fix query without any index capability

What:
There is a bug in Query that requires at least one index be created before any query can execute.
Why:
The desired behavior is to allow for querying of documents regardless of the existence of any indexes.
How:
Remove the logic that causes a query to fail when no indexes are found and replace it with logic that catches the condition and instead retrieves a full list of document ids from the main datastore for the post-hoc matcher to use when generating the query results.
This logic is found in the SQL translator and the query executor.  Additionally a new method to retrieve just a list of document ids needs to be added to the datastore API.
reviewer @mikerhodes
reviewer @gadamc
BugId: 45362

Logic seems the same as iOS. Looks okay to me. +1

+1


cannot import name 'BackTestStats' from 'finrl.trade.backtest'

When I run FinRL_ensemble_stock_trading_ICAIF_2020.ipynb, the cell reports import error. I think it may should be "backtest_stats" as in FinRL_portfolio_allocation_NeurIPS_2020.ipynb instead of "BackTestStats"

Sorry for the late reply. We updated the function name in the new version. For example, BackTestStats is replaced by backtest_stats. However, some notebooks are not updated then. They are fixed now. You may check finrl.plot.py for specific updates.


MudGrid support in resizable MudDialog

Is is possible to add MudGrid support in context of a MudDialog.  At present it seems a MudGrid within a MudDialog doesn't react to the dialog being resized.
When trying out the https://mudblazor.com/components/grid#grid-with-breakpoints example and also applying the resize ability (provided by this MudBlazor.Extensions library) the controls always stay in their original locations.  Only resizing of the main browser document does the MudGrid on the dialog react and subsequently re-layout its controls.
We haven't decided on whether to use the MudGrid or our own flex based solution but would prefer the former approach.  As always we will contribute to this issue should we find a solution ourselves.

You're totally right. This is currently not supported. I try to fix/change this behavior


[CI] Update performance benchmark: upgrade trt-llm to r24.07, and add SGLang

Update performance benchmark: upgrade trt-llm to r24.07, and add SGLang
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@zhyncs Is there a way to enable torch.compile for Llama 3 8B model? TensorRT-LLM r24.07 does not suport Llama 3.1 models so I am now letting all engines running Llama 3 instead of Llama 3.1.

@zhyncs Is there a way to enable torch.compile for Llama 3 8B model? TensorRT-LLM r24.07 does not suport Llama 3.1 models so I am now letting all engines running Llama 3 instead of Llama 3.1.

--enable-torch-compile works for Llama 3 too. We fix bugs in v0.3.0.

@KuntaiDu Hi you may join this channel https://join.slack.com/t/sgl-fru7574/shared_invite/zt-2ngly9muu-t37XiH87qvD~6rVBTkTEHw

Summary of changes:

Unified script for nightly benchmark: run-nightly-benchmarks.sh for running the benchmark, and launch-server.sh for launching the server.
Support ignore-eos flag.


feat: Add rename_profile() to ModLoaderUserProfile

closes #287
Hi, for this change I modified and reference myself to method create_profile as @KANAjetzt in https://github.com/GodotModding/godot-mod-loader/blob/development/addons/mod_loader/api/profile.gd :)

@KANAjetzt Thank you very much for your review, now I think I have corrected the changes the way you suggested. Question for "running modloader in godot" do I need to take the mod developer route to test it?

For starters, you can create an empty Godot Project and follow the steps on this page.
If you get this working, you can look into symlinking the addons directory into this project.
That will allow you to edit the code inside Godot, where you will get some syntax errors to fix.
If no compile errors show up anymore, you can look into the mod developer route and add the rename functionality to the example user profile UI mod.
This would be ideal, but it might be a bit overwhelming if you've never used Godot. So feel free to just edit your code inside Godot to get the syntax error messages, and I will review your code again.

Hi @KANAjetzt sorry that it took so long, i corrected some changes as I am able to get the syntax error now

Thank you again :) I'm sorry I don't have the chance yet to really dive deep into it..


Add badges to readme

Hi guys,
I added 3 badges to the README with this PR:

maven version number (and if you click on it, it takes you there)
build status
code coverage % using Jacobo

There are 2 GitHub Actions:

CodeQL: it performs static code analysis and you can view the results in the security tab of the repo
Build: it runs the tests, generates the report, uploads results, generates coverage badge

Once this is merged, every time someone creates a PR, you'll be able to see if the tests executed successfully as part of the PR.
This is what the README will look like (with 76.6% coverage):

Cheers,
Olga

Hi @matthewelwell
While switching to using version matrix the CI pipeline started throwing errors due to the latest docker image version. Therefore I have changed the version from latest to v2.6.0 so that I could test the GitHub Actions.
Having said that, I guess you have 2 options here:
a) keep a hardcoded API docker image version in the SDK and have to remember to upgrade it every time you make an API release. (current implementation in this PR), OR
b) Keep latest and add a schedule to maven.yml similarly to codeql.yml. This way the Java SDK will get regularly tested against your latest API and you will be automatically alerted if the integration broke.
I personally prefer solution (b) but I am not familiar with how you guys have setup your CI/CD pipelines internally.
What solution would you like to go for?
Cheers,
Olga

Hi @sw-tracker, I tend to agree with you that (b) is the best solution.
I'm a bit lost trying to see from that link, however, what the issue is using the latest tag. The only exceptions I can see are related to UnknownHostException which would be unrelated to the API docker image, right?
Could you point me to the exact action run that you're referring to please?

Hi @matthewelwell
I added latest again + a schedule.
Here is the new failed run: https://github.com/sw-tracker/flagsmith-java-client/runs/2459297542?check_suite_focus=true
This seems to be the first error:
[docker-java-stream--512430939] INFO flagsmith-db - STDERR: 2021-04-28 16:03:08.356 UTC [49] ERROR:  relation "organisations_organisation" does not exist at character 314
416
[docker-java-stream--512430939] INFO flagsmith-db - STDERR: 2021-04-28 16:03:08.356 UTC [49] STATEMENT:  SELECT COUNT(DISTINCT "organisations_organisation"."id") AS "organisations", COUNT(DISTINCT "projects_project"."id") AS "projects", COUNT(DISTINCT "environments_environment"."id") AS "environments", COUNT(DISTINCT "features_feature"."id") AS "features", COUNT(DISTINCT "segments_segment"."id") AS "segments" FROM "organisations_organisation" LEFT OUTER JOIN "projects_project" ON ("organisations_organisation"."id" = "projects_project"."organisation_id") LEFT OUTER JOIN "environments_environment" ON ("projects_project"."id" = "environments_environment"."project_id") LEFT OUTER JOIN "features_feature" ON ("projects_project"."id" = "features_feature"."project_id") LEFT OUTER JOIN "segments_segment" ON ("projects_project"."id" = "segments_segment"."project_id")

Please keep in mind that this pipeline works with API v2.6.0 and 2.5.3. It only seems to fail with the current latest image.

Thanks @sw-tracker, the latest image tag should be fixed now. Could you re-run your workflow and confirm for me please?

Hi @matthewelwell the build is now green :)
You can merge 👍

All done thanks - buttons look good!


Update paragon-extfs to 11

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] If the sha256 changed but the version didn’t,
provide public confirmation by the developer: {{link}}

https://github.com/caskroom/homebrew-cask/issues/35893#issuecomment-311066674

Damn fine work, @commitay.
Started looking into it but did not notice the product.zip. Well done!

🎉  Thanks, @vitorgalvao!
Paragon has removed the uninstall script we used previously.
quit: kind of works but KILL is needed for 2.
The menubar app doesn't disappear until after you click on it, even with KILL.

Thank you both for helping me out on updating this.  Keep it up.