Task ':app:compressDebugAssets' uses this output of task ':app:copyFlutterAssetsDebug' without declaring an explicit or implicit dependency

Steps to Reproduce

flutter create a simple app

Prepare it for testing as native Android tests with the integration_test package; follow the instructions in its README

Run tests on a connected physical or virtual android device:
$ ./gradlew app:connectedAndroidTest -Ptarget=`pwd`/../integration_test/foo_test.dart

Expected results:
I expect no warnings.
Actual results:
> Task :app:compressDebugAssets
Execution optimizations have been disabled for task ':app:compressDebugAssets' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/Users/bartek/dev/bartekpacia/my_awesome_app/mobile/build/app/intermediates/assets/debug/mergeDebugAssets'. Reason: Task ':app:compressDebugAssets' uses this output of task ':app:copyFlutterAssetsDebug' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.5.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.

> Task :app:connectedDebugAndroidTest
Starting 0 tests on Pixel_C_API_31(AVD) - 12

Test results saved as file <...>

(omitted the rest)

Code sample

Logs

$ flutter --version
Flutter 3.3.9 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b8f7f1f986 (3 weeks ago) • 2022-11-23 06:43:51 +0900
Engine • revision 8f2221fbef
Tools • Dart 2.18.5 • DevTools 2.15.0

$ flutter doctor --verbose
[✓] Flutter (Channel stable, 3.3.9, on macOS 13.0.1 22A400 darwin-arm, locale en-PL)
    • Flutter version 3.3.9 on channel stable at /Users/bartek/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (3 weeks ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/bartek/androidsdk
    • Platform android-33, build-tools 33.0.1
    • ANDROID_HOME = /Users/bartek/androidsdk
    • Java binary at: /Users/bartek/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/bartek/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.3)
    • IntelliJ at /Users/bartek/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 71.0.6
    • Dart plugin version 223.7571.203

[✓] IntelliJ IDEA Ultimate Edition (version 2022.3)
    • IntelliJ at /Users/bartek/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/223.7571.182/IntelliJ
      IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.54.0

[✓] Connected device (4 available)
    • Android SDK built for arm64 (mobile) • emulator-5554                        • android-arm64  • Android 12 (API
      31) (emulator)
    • iPhone 14 Pro Max (mobile)           • B7C94C97-BF6A-435B-A4C0-FD82D34851C6 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)                      • macos                                • darwin-arm64   • macOS 13.0.1
      22A400 darwin-arm
    • Chrome (web)                         • chrome                               • web-javascript • Google Chrome
      108.0.5359.98

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@bartekpacia Can you share the complete sample project (it will be great if you could push it into a Github repository) so that we may open and verify the issue?

@huycozy Sure, here you are: https://github.com/bartekpacia/flutter_integration_test_gradle_deps_bug

Connect physical or virtual Android device
flutter pub get
./gradlew app:connectedAndroidTest -Ptarget=pwd/../integration_test/foo_test.dart

Thanks for providing more information. This issue is reproducible when using gradle-7.5.1 (whilst https://github.com/flutter/flutter/issues/112858 is about gradle-8.0).

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.9, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.3.9 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (31 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.7.0-9.0.pre.11, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.7.0-9.0.pre.11 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dbc9306380 (4 hours ago), 2022-12-14 13:53:20 -0800
    • Engine revision 0a6a4a58f4
    • Dart version 3.0.0 (build 3.0.0-21.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.54.0

[✓] Connected device (4 available)
    • SM T225 (mobile) • R9JT3004VRJ                              • android-arm64  • Android 12 (API 31)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.2 19H218
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 108.0.5359.98
    ! Error: iPhone is busy: Fetching debug symbols for iPhone. Xcode will continue when iPhone is finished. (code -10)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

I'll just add some more context. This breaks Gradle's UP-TO-DATE checking:
This command, when run repeatedly (e.g 3 times in a row):
./gradlew assembleDebug --console plain | grep -v 'UP-TO-DATE' | grep -v 'NO-SOURCE'

says:
200 actionable tasks: 5 executed, 195 up-to-date

but it should say:
200 actionable tasks: 0 executed, 200 up-to-date

because we've changed no file between subsequent executions.
The problem seems to lie in this Gradle task from flutter.gradle.

This is an error (instead of a warning) when using Gradle 8.0. See also #112858 and #121970.

This was fixed in #121958, but my comment from above still applies – Flutter Gradle Plugin should be refactored.

@bartekpacia Would you file an issue for this? (I'd recommend copying your explanation from that previous comment, with just an updated intro sentence or two.) That'd be the best way to track it.
If you remember any details about the problem you ran into when you tried to fix it, those would be good to add as a comment on the issue, too.


Make Dockerfile more efficient for caching and add yarn

I've updated the Dockerfile to split up package installation and removal, as well as decreasing build times, by having npm install cached separately, then copied over. This Dockerfile allows docker-compose to work more efficiently as well. I installed yarn for increased speed and also to allow development work to take place if using docker run -it for example.

@noeljackson - I swapped yarn for npm's package-lock.json in a previous commit, because there were issues installing various binary packages that relied on NPM's post-install step (that, at least at the time, yarn didn't execute.)
Do you know if those legacy issues have been solved in yarn?

@leebenson Yes, these have been fixed over here: https://github.com/yarnpkg/yarn/pull/800 :)

In my personal tests, npm 5.x is actually faster and gives better results than yarn.

My perception was that it’s useful enough to a lot of people, that you
could easily include it on the Dockerfile to enable easy development with
npm or yarn.
If we need to rip it out, that’s fine.
The most important part of the Dockerfile is the separation of operations.
Caching is important.

Please re-commit without yarn. That keeps consistency with the project's 'package-lock.json'

@noeljackson - after inspecting this some more, one issue with your Dockerfile version is that the RUN apt-get remove --purge -y ${EPHIMERAL_PACKAGES} is moot-- by the time that command is run, the original image size has already been inflated by the packages already installed. That's why the default Dockerfile does the package bundling, installation and tear-down, as a single step.
So it solves caching, but the image is much bigger. So it's a toss-up between which is more important to your build environment.

I'll play about with the Dockerfile later and attempt to optimise for caching, whilst keeping the size pretty low.

@leebenson There are some other issues as well, when using the current and the proposed Dockerfile in production, though I've fixed those. I will tinker and see what's the best I can come up with. Cheers.

Thanks @noeljackson.


Reference a type of a module from JS

VSCode Version: 1.17.2
OS Version: macOS

It's possible to do in VS Code? https://stackoverflow.com/questions/41298262/vscode-reference-a-type-of-a-module-from-js
For .e.g I tried to do this with PhantomJS which is downloaded auto by ATA and it gives me IntelliSense if I do require('phantom')., but if I use:
/** @type {PhantomJS} */
let phantom;

I don't get any IntelliSense on phantom it says any...

I know how to make it work for phantom, you need to import instead of require. But why then it doesn't works with require?
Works
import phantom from 'phantom';
/** @type {phantom.PhantomJS} */
let session; // PhantomJS

Doesn't works
const phantom = require('phantom');
/** @type {phantom.PhantomJS} */
let session; // any

Posted response on SO: https://stackoverflow.com/a/46940116/306149


Align SessionItem to the line

The app

Design

🙋♀ I try

Thanks! Assigned 👍

OK?

I can see a little difference. Let me reopen this issue 🙏
current

design

Sorry,  I retry

What is the width of the line ?
dynamic or static ?

Thanks! The line is 1dp.
https://github.com/DroidKaigi/conference-app-2022/blob/b94d518a14008073a99d27af54f63da856e1e6d5/feature-sessions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/Timetable.kt#L614
Your screenshot seems there is space with it 👀

OK?

@takahirom please check

Looks great 👍 Thanks!


Summary Span: Add encoder/decoder for Server Stats.

Encoder/decoder for Server Stats as per the spec.

Codecov Report

Merging #1272 into master will increase coverage by 0.15%.
The diff coverage is 98.38%.

@@             Coverage Diff              @@
##             master    #1272      +/-   ##
============================================
+ Coverage     82.58%   82.74%   +0.15%
- Complexity     1277     1291      +14
============================================
  Files           194      197       +3
  Lines          6145     6207      +62
  Branches        568      574       +6
============================================
+ Hits           5075     5136      +61
  Misses          913      913
- Partials        157      158       +1

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/io/opencensus/common/ServerStats.java
100% <100%> (ø)
4 <4> (?)

...va/io/opencensus/common/ServerStatsFieldEnums.java
100% <100%> (ø)
4 <4> (?)

...java/io/opencensus/common/ServerStatsEncoding.java
96.42% <96.42%> (ø)
6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946858d...15aa9ea. Read the comment docs.


Copy / Paste image

Whilst there is a button to upload an image when sending a message, a useful feature i use many times is copy/paste an image into the chat window text field.
This feature can be found on many apps such as whatsapp, facebook messenger and telegram.
This would enhance the overall user experience.

Is this 'share sheet' integration? For example from another app (like your sceenshot) you can click the share button, and then select 'Databag'. You then get prompted for the topic within which to send the shared item.
I see it works from the mobile browser and the photo gallery, but testing now I see iMessage isn't sharing properly.

I just tested on iOS & whatsapp. From whatsapp, you can tap share on an image, then select databag, and it will paste into the selected topic. I'm not sure if this is the functionality you're looking for.

I also just testing on android. From whatsapp, you can tap share on an image, then select databag, and it will paste into the selected topic. Let me know if you where hoping for something else.

Hi there, thanks for the feedback. no the function im specifically looking for is this:
scenario 1: search for an image on google - from phone or computer select "copy image" and then paste it into a Databag chat window.

Hello, when you get a chance can you update the container and see if the browser functionality is what you expect. I haven't yet updated the mobile apps. Thanks for your help with this project!

Thanks for implementing this. works just as expected!

implemented and working


Docs meta tags

Add meta tags to documentation head with RST built-in feature.
List of tags:
description - short information
encoding - already present in index page head

Meta tags added head of the main index page, issue resolved


Deploy an integration test stack to CloudFormation on push

It'd be nice to automatically deploy to an AWS account to ensure things are working as intended.

Some thoughts on this:

We could run a workflow on each PR to deploy the current change to CFN.
This could be done via creating a CDK app in the tests directory and executing it via an npm script.
The dashboard created via this CFN stack can be made public as described here. Need to figure out how to enable public sharing via CFN which doesn't seem to be possible.
The problem with the above is should we deploy to a new stack for each PR v/s the same stack gets deployed.

If it is different per PR, then how do we clean it up?
If it is the same stack, how do we roll it back if the PR gets closed? Merged PR is not a problem because we would deploy again in release workflow

The dashboard created via this CFN stack can be made public as described here. Need to figure out how to enable public sharing via CFN which doesn't seem to be possible.

I think this could be made into an L3 construct in the CloudWatch CDK. Looking into the requests CW makes when setting this value in the AWS Console, it's creating a Cognito Identity pool with public access then configuring the Dashboard to use that. Need to dive deeper on how the dashboard is updated, or if it's just an account wide setting.

Possibly also add integ-runner  integration if and when it gets open sourced:
https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/integ-runner/README.md


Support RSS categories in channel

This small PR adds support for reading and writing the RSS <category> tag at the <channel> level, just like we had already for <item>s.
On my roadmap:

[x] Ensure parsers read empty fields as null
[x] Ensure writers don't write out empty fields/attributes (and trim values we do write)
[x] Add parsing/writing of RSS <categories> nodes in <channel>
[ ] Add support for podcast: namespace
[ ] Unify Atom and AtomBuilder podcast/episode versions since they're exactly the same
[ ] Add some end-to-end tests that read a bunch of real-life RSS feeds

Sorry for the long wait, I am still a bit preoccupied.
PR looks good and I'll merge right away.

Sorry for the long wait, I am still a bit preoccupied.
PR looks good and I'll merge right away.


Slack or discord channel for community support

This is such a great project and has a great community. It would be great to get easier community support going. ddev has recently moved to Discord, which is working out well and doesn't require yet another slack instance. But slack is OK too.
As mentioned elsewhere, some support is going on via DM in the "Rancher Users" slack. I imagine we could get them to create a lima channel.
So much discussion pertinent to lima shows up in the Rancher Desktop channel, but it would be good to get a more focused channel.

ddev has recently moved to Discord, which is working out well and doesn't require yet another slack instance. But slack is OK too.

I was about to say that I feel the same way about "yet another Discord" instance too, and that it overlaps with our Github discussions, but then I realized that I once more mixed up Discord and Discourse... 😄
I think I prefer Slack (my kids call it "Discord, but for old people").
I could ask about getting a #lima channel on the Rancher Users slack, which would be convenient for the overlap with the #rancher-desktop channel (about 600 members), so you cross-link messages. There are channels for #k3s and #longhorn CNCF projects too, but they still have strong ties to Rancher. So I don't know if we shouldn't create a vendor-neutral Slack instance instead?
@AkihiroSuda, what do you think?

I don't recommend creating a completely new slack, as slack makes it pretty painful to keep it free and when it's not free it's unsustainably expensive. Tried that with ddev.

I normally lurk around in the #crio and #minikube Kubernetes channels on https://kubernetes.slack.com/

I could ask about getting a #lima channel on the Rancher Users slack, which would be convenient for the overlap with the #rancher-desktop channel (about 600 members), so you can cross-link messages. There are channels for #k3s and #longhorn CNCF projects too, but they still have strong ties to Rancher. So I don't know if we shouldn't create a vendor-neutral Slack instance instead?

It might be better if we could have a channel on CNCF slack (cloud-native.slack.com), but I'm not sure whether it is acceptable.
So having a channel on Rancher slack SGTM.

So having a channel on Rancher slack SGTM.

We do have a #lima channel on http://rancher-users.slack.com now.

Thanks!

I'd like to point out that having a slack on rancher-users is at least 'somewhat' pointless.  They have it closed off so that just to sign up for access, you have to contact the workspace admin to get permission.  Otherwise, you have to have an address with either @suse.com or @rancher.com. What is the opposition to supporting a standard like Ibera, or Matrix or similar?

They have it closed off so that just to sign up for access, you have to contact the workspace admin to get permission. Otherwise, you have to have an address with either @suse.com or @rancher.com.

Doesn't seem true: https://slack.rancher.io/

FYI we have GitHub Discussions too: https://github.com/lima-vm/lima/discussions

Sorry, I deleted the comment when I wen't through the slack link comment posted above and noticed the sign-ups.  Hadn't realized it was 1 url for login and a completely separate one for registration.


Generic has No Serial Log

Current version 8-146 has NO serial log available:

This is already covered by #10, specifically point 3. I'll post details about it there.

Okay - it was working before - it was a regression, glad it is back

Sorry for closing this issue so quickly. Actually it was not supposed to work before: the serial log is disabled when the UNIQUE flag is not set. This means the log worked by accident.

No problem - glad it worked before or I would have complained more :)
Thanks for the fixes and changes!  I just pulled down 0.8.0-160 and I can name my devices now!


Treat an invalid charset identically to one a TextInputFormatter does not support

A Content-type header containing application/json;charset=garbage where the system had no configured Encoding for garbage is treated as if the Content-type header did not mention the charset at all. That is, the JsonInputFormatter attempted to deserialize the request body using its slight reconfiguration of Encoding.UTF8. Such cases should instead result in an HTTP/415, Unsupported Media Type response.

Found while investigating #5351 and fixed in original PR for that bug (#5415).

Fixed for good in f042865


Runtime errors on fa526 (arm4tl): res != DUK_TVAL_GET_NUMBER(tv) (duk_hobject_props.c:2628)

I was able to compile duktape to run on the fa526 (arm4tl) processor in a MOXA UC7101 device.
With debug logging and assertions enabled I see, that it is able to create the heap and run an gc.
To rule out my own application which runs fine under generic linux x86 and OS X hosts, I reproduced the error with the cmdline example: duk.
It boils down to:
PANIC 54: assertion failed: (duk_double_t) res == DUK_TVAL_GET_NUMBER(tv) (duk_hobject_props.c:2628) (calling abort)

Compiler defines:
http://pastebin.com/H7dKiLrM
duk execution log:
http://pastebin.com/rV7i9cYQ

If you didn't already have it defined, could you check what happens with -DDUK_OPT_SELF_TESTS enabled?

Another thing you could try (to help in diagnosis) is -DDUK_OPT_NO_PACKED_TVAL.

It seems the execution log is no different:
http://pastebin.com/hsNtZkPy
Compiled with:
-DDUK_OPT_DEBUG
-DDUK_OPT_DPRINT
-DDUK_OPT_ASSERTIONS
-DDUK_OPT_SELF_TESTS
-DDUK_OPT_NO_PACKED_TVAL
-DDUK_CMDLINE_ALLOC_LOGGING

Allocation log:
http://pastebin.com/MhZ0tZeW
Execution log without assertions:
http://pastebin.com/7L9p4KJv
duk_js_compiler.c:434 (duk__advance_helper): parse error: expect=52, got=55
Expect 52 = DUK_TOK_RCURLY, got 55 = DUK_TOK_LPAREN?

The target has an ancient uClibc (9.26), here is the uClibc_config.h
http://pastebin.com/TGtM5FSn
Unfortunately I can't upgrade the uClibc easily.
Maybe it is a problem with softfloat/hardfloat?

I'd also suspect the issue is related to IEEE double handling - but the known cases are caught by the self tests (e.g. clang/llvm union aliasing issue with -m32).
It might also be that Duktape ends up determining endianness incorrectly.  On that front:

Are you compiling with -std=c99?  If not, that's worth a try.
If the target is mixed endian (IEEE doubles), you could try -DDUK_OPT_FORCE_BYTEORDER=2 (1 for little endian)
Unlikely, but could try -DDUK_OPT_FORCE_ALIGN=8

The define dump has:
#define __ARCH_LITTLE_ENDIAN__ 1
#define __FLOAT_WORD_ORDER__ __ORDER_BIG_ENDIAN__
#define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__

With these Duktape should end up thinking the platform is mixed endian (little endian 64-bit integers but mixed endian IEEE doubles), i.e. same as -DDUK_OPT_FORCE_BYTEORDER=2.
Just to make sure, could you compile https://github.com/svaarala/duktape/blob/master/util/check_align.c and run the following:
./check_align uint64_t 0
./check_align double 0

check_align:
~ # ./check_align uint64_t 0
uint64_t offset 0, ptr 0xf17d00
88 77 66 55 44 33 22 11 = 0x1122334455667788
little endian
~ # ./check_align double 0
double offset 0, ptr 0xf17d00
bb eb 78 43 e1 d0 ee 95 =<PHONE_NUMBER>66778890.000000
mixed endian

-std=c99 or even -std=gnu99 was used.
-DDUK_OPT_FORCE_ALIGN=8 made no difference.
The compiler I use is a selfbuild arm-elf-gcc (GCC) 4.6.3.
With some fiddling (e.g. no __builtin_inf) I was able to compile duk with the original
compiler from the hardware vendor, which is an even more ancient gcc 2.95.3 (released on March 16, 2001!), this executable works as expected. sigh
Unfortunately we need c99 support and some other features and cannot this compiler for our application. check_align gives the same results when compiled with this compiler with only the pointer address being different.
The builtin defines are quite short, maybe that's a helpful clue?
# ~/moxa/arm-elf-gcc -dM -E - < /dev/null
#define __arm_elf 1
#define arm_elf 1
#define __arm__ 1
#define __arm 1
#define __arm_elf__ 1
#define __ARM_ARCH_4T__ 1
#define __GNUC_MINOR__ 95
#define arm 1
#define __CHAR_UNSIGNED__ 1
#define __APCS_32__ 1
#define __GNUC__ 2
#define __ELF__ 1

Quite an interesting situation, but I'm sure we can figure it out :-)
Did you try the -DDUK_OPT_FORCE_ALIGN option -- just to rule out that Duktape ends up detecting endianness incorrectly?
Also if you could dump the very verbose debug logs (-DDUK_OPT_DPRINT, -DDUK_OPT_DDPRINT, and -DDUK_OPT_DDDPRINT) that might give a clue as to what goes wrong.

-DDUK_OPT_FORCE_ALIGN=8 was configured.
Here is the really verbose 7.2MB log:
https://gist.githubusercontent.com/jbysewski/b4f2ca22ae33ff4d4e9f/raw/42f5ce5dcfa11e656a801d53d701183beadc5346/duk_assertion_fail_verbose.txt

Here is the execturion log from the ancient but working gcc-2.95.3 compiler:
https://gist.github.com/jbysewski/0b91e232deda65e3c2cc/raw/4579cc9dbbd8ef50c6a56c60f7efc0ddb95bc5f2/duk_original_compiler.txt
They don't match very well after the self-tests.

Also the bad one has lots of occurences of dragon4 (from duk_numconv.c) while the good one has not one.

That load debug is printed by:
        DUK_DDD(DUK_DDDPRINT("attempt to resize stringtable: %ld entries, %ld bytes, %ld used, %ld%% load -> %ld entries, %ld bytes, %ld used, %ld%% load",
                             (long) old_size, (long) (sizeof(duk_hstring *) * old_size), (long) old_used,
                             (long) (((double) old_used) / ((double) old_size) * 100.0),
                             (long) new_size, (long) (sizeof(duk_hstring *) * new_size), (long) duk__count_used_probe(heap),
                             (long) (((double) duk__count_used_probe(heap)) / ((double) new_size) * 100.0)));

There are other %ld formats that work correctly there so it's probably not formatting.  Unfortunately it seems it might either double arithmetic or double-to-integer casts.  I've encountered compiler setups with both issues so not sure which is more probable.

The Dragon4 difference is probable due to this double-to-string fast path check:
        if (((double) uval) == x &&  /* integer number in range */
            flags == 0) {            /* no special formatting */

I'm guessing the same cast issues cause this fast path to missed in the "bad" case, which results in Duktape going through the much more complicated (and verbose) slow path.

I think I've got it: the unsigned int to float conversion is broken in my compiler. The internal function __floatunsidf does not work as expected.
Here's a little test program:
#include <stdio.h>

double __floatunsidf (unsigned i)
{
  double r = (double)(int)i;
  if ((int)i < 0)
    r += 0x1p32f;
  return r;
}

int main()
{
  double  d = 1.0;
  unsigned int u = (unsigned int) d;
  double d2 = (double) u;

  printf("d: %f d2: %f u: %d equal: %d\n", d, d2, u, ((double)u) == d);
}

With the custom __floatunsidfit works as it should and outputs:
d: 1.000000 d2: 1.000000 u: 1 equal: 1

Without it the output is:
d: 1.000000 d2: 0.000000 u: 1 equal: 0

The failure might be associated with this gcc-bug, where I also got the __floatunsidf implementation from:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=24998
Thank you very much for your support!

Great :) Did you figure out how to fix it?
I'll add cast tests to the self test set, because there are now at least 3 cases where they have been broken. It's often fixable but it's hard to pin down so it'd be nice to self test for.

For our application I see the following options:

compile libduktape with the ancient non-c99 compiler, compile our app with the newer one (works)
use the __floatunsidf from above (kind of a hack, but seems to work)
try another compiler version (might work, but the uClibc is compiled with old linux ABI so nothing newer than 4.6 works)
go through all the hassle of upgrading the kernel and libc for these devices sigh
see if we can get away with not supporting this hardware (not likely as it's an reasonably cheap embedded linux device with industrial temperature range)

An self test is easy enough and seems like a good idea because this took lots of time to pin down, like you said.

Another approach: Duktape does a double-to-integer and integer-to-double cast in a reasonable amount of places so it'd also be possible to make those casts explicit through macros.  This would allow the casts used by Duktape to be reimplemented to avoid problems in the compiler environment.
Another dependency Duktape has is a sprintf() with working %d, %ld, %p at least. This is also needed in only a handful of places so it'd be possible to make it retargetable.

You've gone a long way with supporting a lot of different host/target configurations.
So yes, that seems like a nice solution, too.

One counterargument to fixing this by avoiding such casts in Duktape is that other code (such as existing Duktape/C binding code) might still break due to problematic casts.
But if one is writing all the C code from scratch and can deal with compiler deficiencies it certainly is feasible. I've had to work with closed toolchains with similar issues, e.g. one has working double-to-integer casts up to 32-bit range but beyond 32 bits the cast results start to go wrong. In that particular case it was possible to just avoid the offending casts.

@jbysewski Any updates on this issue re: compiler configuration? :)

It seems the compiler is a bit weird, but I had no time rebuilding the compiler suite and playing with the different soft/hard-float options gcc has available. Currently we're running with the __floatunsidf-hack which works without any further hassle.
Good to see you added a self test for this kind of misbehaviour as that might save the next poor guy some time. :)

Good to hear - I'll close this issue because there's no clear Duktape change (except the added self test).


adds moby_config to linuxkit images

Issue #, if available:
Description of changes:
When linuxkit builds their images upstream, most images have a build.yml file. The config section of these files are added to the docker image as the value of the org.mobyproject.config label.  When a linuxkit built image, in our case hook, runs these containers if the template, ex hook-template, does not include these config values such as capbilities in the template for that image, the linuxkit containerd runtime pulls this label from the final image and uses the config as the default.
Without these our hook will not actually work since it relies on these defaults.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Set proxy

I want to balance the number of requests made by each IP, setting a different proxy on each API call. Is it possible?

I haven't tried that. But I think it's possible. We can use https://github.com/gajus/puppeteer-proxy or https://github.com/Cuadrix/puppeteer-page-proxy on page basis or request basis.
Have you got rate limited so far?

Puppeteer-page-proxy's community appears to be more involved and trying to solve issues by themselves.
I haven't started using it yet. Launched on docker, and it appears to be working, but I have very large articles that I would like to translate. The character limit is 5000, and I'm assuming 1 request per second, it could take over a month to finish. Since I already have a few proxies available, maybe I could speed things up.

Puppeteer-page-proxy's community appears to be more involved and trying to solve issues by themselves.

However, considering this project is only for educational purposes (for some reason), I would not take time to implement proxy as a bypass for overloaded requests (I'm not sure how frequent it would be to trigger rate limitation to require a proxy). But a PR of an opt-in feature is welcome anyway!

I have very large articles that I would like to translate

I don't think what you need is proxy but "paralleled requests". See below.

The character limit is 5000

Yes. This project hasn't supported articles longer than 5000 chars yet. I think it's doable though but takes time. So far, you have to split your articles manually before requesting.

I'm assuming 1 request per second

You can send paralleled requests. The default maximum concurrent request limit, as said in the readme, is 5, which can be increased by setting env PAGE_COUNT to another bigger number. But also note that each page would take up some memory as it is a chromium tab internally. I haven't tried and calculated the accurate memory impact of each page. You have to test it yourself and set an appropriate value for your large requests.

Got it. Thanks!

Referencing this article https://pixeljets.com/blog/how-to-set-proxy-in-puppeteer/
So it'd be much simpler to set proxy by adding this args, I've tested and it worked perfectly
const browser = await puppeteer.launch({
headless: false,
args: [ '--proxy-server=http://your-proxy-host:3128' ]
});

@ringge
Yes, that is indeed the correct method for setting a proxy in Puppeteer. Could you please let me know what issue you are facing that necessitates the use of a proxy?

@ringge
Yes, that is indeed the correct method for setting a proxy in Puppeteer. Could you please let me know what issue you are facing that necessitates the use of a proxy?

Oh I'm not facing any issues with translateer, just kind of looking into proxy to use Puppeteer for other projects

@ringge
Yes, that is indeed the correct method for setting a proxy in Puppeteer. Could you please let me know what issue you are facing that necessitates the use of a proxy?

Just to add context, due to CGNAT, some residential IP range are flagged as bot/risky on Google. So, to make a simple search on Google, if I'm not logged into my account, it asks to first solve a captcha. While there's no captcha when using Translate, it appears that the responses are throttled. So I've been using a proxy to reduce such problems.
Also, I believe that they stop responding on Translate if you always send larger texts. If I send one to three short sentences per query, it works fine. If I keep sending around 1000+ characters, it stops responding after maybe 50 queries, even if there's a 2-second delay between the requests. Doesn't matter if I restart the container, it still won't answer. It does if I change the proxy IP. This has been so limiting that I'm looking into LLMs to keep translating. Llama 2 is cheap and does a decent job depending on the language, but I haven't found an uncensored version hosted. If it's not uncensored, it will refuse to translate texts that contain violence or that it finds even mildly aggressive.


Clarified Client Responsibility (#1382)

Clarified client responsibility regarding the Accept header per https://github.com/json-api/json-api/issues/1382

This rule has been removed and so this is no longer applicable. Thank you @TrevorHinesley and @ahx ! We sincerely appreciate your suggestions!


[Bug] Hubble image build fails after introduce front-end download proxy

Bug Type (问题类型)
None
Before submit

[X] I had searched in the issues and found no similar issues.

Environment (环境信息)

Server Version: v1.x.x
Toolchain Version: v1.x.x
Data Size:  xx vertices, xx edges

Expected & Actual behavior (期望与实际表现)
https://github.com/hugegraph/actions/actions/runs/8103879676
Vertex/Edge example (问题点 / 边数据举例)
No response
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
No response

related: https://github.com/yarnpkg/yarn/issues/4890

[INFO] --- frontend-maven-plugin:1.14.2:yarn (yarn install) @ hubble-dist ---
[INFO] Running 'yarn install --network-timeout 600000' in /home/runner/work/incubator-hugegraph-toolchain/incubator-hugegraph-toolchain/hugegraph-hubble/hubble-dist/../hubble-fe
[INFO] yarn install v1.22.21
[INFO] [1/4] Resolving packages...
[INFO] [2/4] Fetching packages...
[INFO] info There appears to be trouble with your network connection. Retrying...
[INFO] info There appears to be trouble with your network connection. Retrying...
[INFO] info There appears to be trouble with your network connection. Retrying...
[INFO] info There appears to be trouble with your network connection. Retrying...
[INFO] info There appears to be trouble with your network connection. Retrying...
[INFO] error Error: getaddrinfo ENOTFOUND registry.nlark.com
[INFO]     at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:109:26)
[INFO] error Error: getaddrinfo ENOTFOUND registry.nlark.cominfo Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
[INFO] info There appears to be trouble with your network connection. Retrying...
[INFO] info There appears to be trouble with your network connection. Retrying...
[INFO] info There appears to be trouble with your network connection. Retrying...
[INFO] info There appears to be trouble with your network connection. Retrying...

@dosu-bot  Please analyze the causes of the above problems and provide solutions


About 3DLoMatch and benchmark

hi,
Thanks for your amazing work!
I want to use the 3DLoMatch dataset for testing recently. And I followed the steps in the README to change the benchmark in configs/test/indoor.yaml to 3DLoMatch, but I got an error，
“IndexError：index is out of bounds for axis 0 with size 1623”
I found that the error was in writing estimated trajectories of the seventh scence (sun3d-mit_76_studyrrom-76-1studyromm2). I'm not sure what I'm overlooking to get this error?
looking forward to your reply.

Can you download the dataset again? I don't have such a problem.

Closed due to inactivity. Feel free to reopen if needed.


Async validation function for field required when creating the form definition

Issue
When using an async validator for a field, you have to have the function fully defined when you are writing out the form in the PPX. You are also not able to use any other fields inside of the form while executing the function. This is an issue when you require more data to finish the validation (say an OAuth token) since you can't use a partially applied function, nor reference a field in the form that would carry such data.
Solution 1
You can use module functors to get around this. You have a module functor that creates the form based on another module you pass in, which that form contains the function with all of the extra necessary data to complete the call. This gets out of hand fast though. You have to fully define the module types for both the input and the output which can be difficult, you have to store the created form module in something (like React.useState) so that you aren't creating a brand new form on each render, and you have to use first-class modules in order to be able to save the form.
This works right now and it does makes working with the form quite easy after a ton of upfront work using some things that are not well documented or known in the ReScript community. Not ideal IMO
Solution 2
Allow the PPX form to take in a function that is the of the same type as the function now (i.e. fieldOutput => Js.Promise.t(result(fieldOutput error)) via some custom named param when calling useForm.
e.g.
module Form = [%form
  type submissionError = Foo;

  type input = {
    email<EMAIL_ADDRESS>string
  };

  type output = {
    email: Email.t
  };

  let validators = {
    email: strategy: OnFirst

  let validators = {
    email: {
      strategy: OnFirstSuccessOrFirstBlur,
      validate: input => input.email->Email.validate,
      validateAsync: FormArgument
    }
  };
];

<EMAIL_ADDRESS>let make = (~validateEmailAsync) => {
  let _ = Form.useForm(~initialState={ email: "" }, ~onSubmit={(_,_) => ()}, ~validateEmailAsync);

  React.null;
};

Thoughts?

@johnhaley81 Will passing metadata to all (incl. async) validators help with this problem?

Yeah, that would work well I think!
On Thu, Nov 12, 2020, 1:51 AM Alex Fedoseev<EMAIL_ADDRESS>wrote:

@johnhaley81 https://github.com/johnhaley81 Will passing metadata
https://github.com/MinimaHQ/re-formality/issues/82 to all (incl. async)
validators help with this problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MinimaHQ/re-formality/issues/94#issuecomment-725936083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGT3RFWHXT4KA6UXRZTXDLSPOOXNANCNFSM4TROZXLQ
.

Closing since #95 merged.


Update angular monorepo

This PR contains the following updates:

Package
Type
Update
Change

@angular/animations
dependencies
minor
14.0.1 -> 14.2.9

@angular/common
dependencies
minor
14.0.1 -> 14.2.9

@angular/compiler
dependencies
minor
14.0.1 -> 14.2.9

@angular/compiler-cli (source)
devDependencies
minor
14.0.1 -> 14.2.9

@angular/core
dependencies
minor
14.0.1 -> 14.2.9

@angular/forms
dependencies
minor
14.0.1 -> 14.2.9

@angular/language-service
devDependencies
minor
14.0.1 -> 14.2.9

@angular/platform-browser
dependencies
minor
14.0.1 -> 14.2.9

@angular/platform-browser-dynamic
dependencies
minor
14.0.1 -> 14.2.9

@angular/router (source)
dependencies
minor
14.0.1 -> 14.2.9

zone.js (changelog)
dependencies
minor
~0.11.4 -> ~0.12.0

Release Notes

angular/angular (@angular/animations)
v14.2.9
Compare Source
platform-browser

Commit
Type
Description

92d28bdd99
perf
resolve memory leak when using animations with shadow DOM (#47903)

platform-server

Commit
Type
Description

d2d9bbf5ce
fix
call onSerialize when state is empty (#47888)

Special Thanks
Alan Agius, Kristiyan Kostadinov, Virginia Dooley and mgechev

v14.2.8
Compare Source
Special Thanks
Andrew Scott, Balaji, Paul Gschwendtner, WD Snoeijer, onrails and vyom1611

v14.2.7
Compare Source
Special Thanks
Bob Watson, Charles Barnes, Joey Perrott, Virginia Dooley, WD Snoeijer, abergquist and urugator

v14.2.6
Compare Source
compiler-cli

Commit
Type
Description

3fd176a905
fix
add missing period to error message (#47744)

c3821f5ab5
perf
minimize filesystem calls when generating shims (#47682)

Special Thanks
Alan Agius, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bob Watson, Charles Lyding, Joey Perrott, Joshua Morony, Mathew Berg, Paul Gschwendtner, Peter Dickten, Renan Ferro, Sri Ram, WD Snoeijer, markostanimirovic and Álvaro Martínez

v14.2.5
Compare Source
This release contains various API docs improvements.
Special Thanks
Alexander Wiebe, Ciprian Sauliuc, Dmytro Mezhenskyi, George Kalpakas, Joe Martin (Crowdstaffing), Jordan, Ole M, Paul Gschwendtner, Pawel Kozlowski and mgechev

v14.2.4
Compare Source
compiler-cli

Commit
Type
Description

a4b66fe1e5
perf
cache source file for reporting type-checking diagnostics (#47508)

core

Commit
Type
Description

2c46b5ab24
fix
correctly check for typeof of undefined in ngDevMode check (#47480)

Special Thanks
Alan Agius, Ashley Hunter, Doug Parker, Jessica Janiuk, JoostK, Kristiyan Kostadinov, Rokas Brazdžionis and Simona Cotin

v14.2.3
Compare Source
animations

Commit
Type
Description

bba2dae812
fix
make sure that the useAnimation function delay is applied (#47468)

Special Thanks
AleksanderBodurri, Andrew Kushnir, Andrew Scott, Bob Watson, George Kalpakas, Joey Perrott, Mauro Mattos, dario-piotrowicz, fabioemoutinho and famzila

v14.2.2
Compare Source
animations

Commit
Type
Description

937e6c5b3d
fix
make sure that the animation function delay is applied (#47285)

common

Commit
Type
Description

c9bdf9bab1
fix
rename rawSrc -> ngSrc in NgOptimizedImage directive (#47362) (#47396)

core

Commit
Type
Description

a3e1303f04
fix
imply @Optional flag when a default value is provided (#47242)

forms

Commit
Type
Description

80c66a1e57
fix
don't prevent default behavior for forms with method="dialog" (#47308)

Special Thanks
Abhishek Rawat, Andrew Kushnir, Benjamin Chanudet, Bob Watson, George Kalpakas, Ikko Ashimine, Kristiyan Kostadinov, Marc Wrobel, Mariia Subkov, Pawel Kozlowski, Sebastian, abergquist, dario-piotrowicz, onrails and vyom1611

v14.2.1
Compare Source
common

Commit
Type
Description

c0d7ac9ec2
fix
improve formatting of image warnings (#47299)

1875ce520a
fix
use DOCUMENT token to query for preconnect links (#47353)

compiler

Commit
Type
Description

0e35829580
fix
avoid errors for inputs with Object-builtin names (#47220)

service-worker

Commit
Type
Description

6091786696
fix
include headers in requests for assets (#47260)

28d33505fd
fix
only consider GET requests as navigation requests (#47263)

Special Thanks
Aristeidis Bampakos, Asaf M, Bingo's Code, Bob Watson, Daniel Ostrovsky, George Kalpakas, Giovanni Alberto Rivas, Jeremy Elbourn, Jobayer Hossain, Joe Martin (Crowdstaffing), Joey Perrott, JoostK, Kara Erickson, Kristiyan Kostadinov, Maina Wycliffe, Sabareesh Kappagantu, Simona Cotin, Sonu Sindhu, Yann Provoost, abergquist, jaybell and vyom1611

router

Commit
Type
Description

5163e3d876
feat
Add UrlTree constructor to public API (#47186)

Special Thanks
Alan Agius, Alex Rickabaugh, Andrew Scott, Joey Perrott, Kara Erickson, Kristiyan Kostadinov and Pawel Kozlowski

v14.2.0
Compare Source
animations

Commit
Type
Description

b96e571897
fix
fix stagger timing not handling params (#47208)

common

Commit
Type
Description

b380fdd59e
feat
add a density cap for image srcsets (#47082)

7ce497e5bc
feat
add built-in Imgix loader (#47082)

bff870db61
feat
add cloudflare loader (#47082)

86e77a5d55
feat
add Image directive skeleton (#45627) (#47082)

0566205a02
feat
Add image lazy loading and fetchpriority (#47082)

4e952ba216
feat
add loaders for cloudinary & imagekit (#47082)

e854a8cdde
feat
add loading attr to NgOptimizedImage (#47082)

8d3701cb4c
feat
add warnings re: image distortion (#47082)

d5f7da2120
feat
define public API surface for NgOptimizedImage directive (#47082)

d3c3426aa4
feat
detect LCP images in NgOptimizedImage and assert if priority is set (#47082)

451b85ca17
feat
explain why width/height is required (#47082)

586274fe65
feat
provide an ability to exclude origins from preconnect checks in NgOptimizedImage (#47082)

57f3386e5b
feat
support custom srcset attributes in NgOptimizedImage (#47082)

7baf9a46cd
feat
verify that priority images have preconnect links (#47082)

f81765b333
feat
warn if rendered size is much smaller than intrinsic (#47082)

e2ab99b95e
fix
allow null/undefined to be passed to ngClass input (#39280) (#46906)

bedf537951
fix
allow null/undefined to be passed to ngStyle input (#47069)

f9511bf6e8
fix
avoid interacting with a destroyed injector (#47243)

dc29e21b14
fix
consider density descriptors with multiple digits as valid (#47230)

801daf82d1
fix
detect data: and blob: inputs in NgOptimizedImage directive (#47082)

fff8056e7f
fix
fix formatting on oversized image error (#47188) (#47232)

1ca2ce19ab
fix
remove default for image width (#47082)

c5db867ddc
fix
remove duplicate deepForEach (#47189)

1cf43deb18
fix
sanitize rawSrc and rawSrcset values in NgOptimizedImage directive (#47082)

d71dfe931f
fix
set bound width and height onto host element (#47082)

32caa8b669
fix
support density descriptors with 2+ decimals (#47197) (#47232)

ae4405f0bf
fix
throw if srcset is used with rawSrc (#47082)

0c8eb8bc82
perf
monitor LCP only for images without priority attribute (#47082)

compiler-cli

Commit
Type
Description

ea89677c12
feat
support more recent version of tsickle (#47018)

core

Commit
Type
Description

d1e83e1b30
feat
add createComponent function (#46685)

10becab70e
feat
add reflectComponentType function (#46685)

4b377d3a6d
feat
introduce createApplication API (#46475)

31429eaccc
feat
support TypeScript 4.8 (#47038)

796840209c
fix
align TestBed interfaces and implementation (#46635)

forms

Commit
Type
Description

426af91a42
feat
add FormBuilder.record() method (#46485)

b302797de4
fix
Correctly infer FormBuilder types involving [value, validators] shorthand in more cases. (#47034)

language-service

Commit
Type
Description

598b72bd05
feat
support fix the component missing member (#46764)

platform-browser

Commit
Type
Description

07606e3181
feat
add isEmpty method to the TransferState class (#46915)

platform-server

Commit
Type
Description

2b4d7f6733
feat
support document reference in render functions (#47032)

router

Commit
Type
Description

0abb67af59
feat
allow guards and resolvers to be plain functions (#46684)

75df404467
feat
Create APIs for using Router without RouterModule (#47010)

10289f1f6e
feat
expose resolved route title (#46826)

8600732b09
feat
Expose the default matcher for Routes used by the Router (#46913)

422323cee0
feat
improve typings for RouterLink boolean inputs (#47101)

26ea97688c
feat
Make router directives standalone (#46758)

2a43beec15
fix
Fix route recognition behavior with some versions of rxjs (#47098)

service-worker

Commit
Type
Description

383090858c
feat
support sendRequest as a notificationclick action (#46912)

3f548610dd
fix
export NoNewVersionDetectedEvent (#47044)

482b6119c2
fix
update golden index.md (#47044)

Special Thanks
Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Bob Watson, Cédric Exbrayat, Dylan Hunn, Emmanuel Roux, FatalMerlin, George Kalpakas, Ilia Mirkin, Jan Kuehle, Jeremy Elbourn, Jessica Janiuk, JiaLiPassion, Kalbarczyk, Kara Erickson, Katie Hempenius, Kristiyan Kostadinov, Merlin, Paul Gschwendtner, Pawel Kozlowski, Tristan Sprößer, Victor Porof, angular-robot[bot], dario-piotrowicz, ivanwonder and vyom

v14.1.3
Compare Source
compiler

Commit
Type
Description

0583227708
fix
infinite loop in parser assignment expression with invalid left-hand expression (#47151)

Special Thanks
AlirezaEbrahimkhani, Alma Eyre, Andrew Scott, Bob Watson, George Kalpakas, Kalbarczyk, Kristiyan Kostadinov, Leosvel Pérez Espinosa, Roman Matusevich and Sonu Kapoor

v14.1.2
Compare Source
core

Commit
Type
Description

5ff715c549
fix
check if transplanted views are attached to change detector (#46974)

router

Commit
Type
Description

439d77e852
fix
Fix route recognition behavior with some versions of rxjs (#47098) (#47112)

Special Thanks
4javier, Andrew Kushnir, Andrew Scott, AntonioCardenas, Bob Watson, Bruno Barbosa, Eduardo Speroni, Edward, George Kalpakas, Jan Melcher, Kristiyan Kostadinov, Mladen Jakovljević, Paul Gschwendtner, Pawel Kozlowski, Roman Matusevich, Vovch, ashide2729, ileil and onrails

v14.1.1
Compare Source
core

Commit
Type
Description

3606917732
fix
improve the missing control flow directive message (#46903)

router

Commit
Type
Description

79825d3f10
fix
Do not call preload method when not necessary (#47007)

05f3f7445a
fix
Use correct return type for provideRoutes function (#46941)

Special Thanks
Alan Agius, Andrew Kushnir, Andrew Quinn, Andrew Scott, Aristeidis Bampakos, Asaf M, Bob Watson, Cédric Exbrayat, Durairaj Subramaniam, George Kalpakas, Ivaylo Kirov, J Rob Gant, Kristiyan Kostadinov, Marek Hám, Paul Gschwendtner, Roman Matusevich and Simona Cotin

v14.1.0
Compare Source
Deprecations
core

The createNgModuleRef is deprecated in favor of newly added createNgModule one.
The bit field signature of inject() has been deprecated, in favor of the
new options object. Correspondingly, InjectFlags is deprecated as well.

animations

Commit
Type
Description

55308f2df5
feat
add provideAnimations() and provideNoopAnimations() functions (#46793)

common

Commit
Type
Description

4a2e7335b1
feat
make the CommonModule pipes standalone (#46401)

a7597dd080
feat
make the CommonModule directives standalone (#46469)

compiler

Commit
Type
Description

33ce3883a5
feat
Add extended diagnostic to warn when missing let on ngForOf (#46683)

6f11a58040
feat
Add extended diagnostic to warn when text attributes are intended to be bindings (#46161)

9e836c232f
feat
warn when style suffixes are used with attribute bindings (#46651)

compiler-cli

Commit
Type
Description

93c65e7b14
feat
add extended diagnostic for non-nullable optional chains (#46686)

131d029da1
feat
detect missing control flow directive imports in standalone components (#46146)

6b8e60c06a
fix
improve the missingControlFlowDirective message (#46846)

core

Commit
Type
Description

e8e8e5f171
feat
add createComponent function

b5153814af
feat
add reflectComponentType function

96c6139c9a
feat
add ability to set inputs on ComponentRef (#46641)

a6d5fe202c
feat
alias createNgModuleRef as createNgModule (#46789)

71e606d3c3
feat
expose EnvironmentInjector on ApplicationRef (#46665)

19e6d9ccd3
feat
import AsyncStackTaggingZone if available (#46693)

a7a14df5f8
feat
introduce EnvironmentInjector.runInContext API (#46653)

fa52b6e906
feat
options object to supersede bit flags for inject() (#46649)

af20112222
feat
support the descendants option for ContentChild queries (#46638)

945a3ad359
fix
Fix runInContext for NgModuleRef injector (#46877)

bb7c80477b
fix
make parent injector argument required in createEnvironmentInjector (#46397)

http

Commit
Type
Description

82acbf919b
feat
improve error message for nullish header (#46059)

router

Commit
Type
Description

53ca936366
feat
Add ability to create UrlTree from any ActivatedRouteSnapshot (#45877)

de058bba99
feat
Add CanMatch guard to control whether a Route should match (#46021)

6c1357dd7d
feat
Add stable cancelation code to NavigationCancel event (#46675)

a4ce273e50
feat
Add the target RouterStateSnapshot to NavigationError (#46731)

abe3759e24
fix
allow to return UrlTree from CanMatchFn (#46455)

e8c7dd10e9
fix
Ensure APP_INITIALIZER of enabledBlocking option completes (#46026)

ce20ed067f
fix
Ensure Route injector is created before running CanMatch guards (#46394)

6a7b818d94
fix
Ensure target RouterStateSnapshot is defined in NavigationError (#46842)

f94c6f433d
fix
Expose CanMatchFn as public API (#46394)

e8ae0fe3e9
fix
Fix cancelation code for canLoad rejections (#46752)

upgrade

Commit
Type
Description

e9cb0454dc
feat
more closely align UpgradeModule#bootstrap() with angular.bootstrap() (#46214)

Special Thanks
AleksanderBodurri, Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Cédric Exbrayat, Dmitrij Kuba, Dylan Hunn, George Kalpakas, Jessica Janiuk, JiaLiPassion, Joey Perrott, John Vandenberg, JoostK, Keith Li, Or'el Ben-Ya'ir, Paul Gschwendtner, Pawel Kozlowski, SyedAhm3r, arturovt, mariu, markostanimirovic and mgechev

v14.0.7
Compare Source
animations

Commit
Type
Description

5bdbb6285b
fix
make sure falsy values are added to _globalTimelineStyles (#46863)

compiler

Commit
Type
Description

41253f9c46
fix
inputs/outputs incorrectly parsed in jit mode (#46813)

core

Commit
Type
Description

4e77c7fbf3
fix
do not invoke jasmine done callback multiple times with waitForAsync

Special Thanks
Andrew Kushnir, Andrew Scott, Bob Watson, Cédric Exbrayat, Doug Parker, George Kalpakas, Jessica Janiuk, Kristiyan Kostadinov, Paul Gschwendtner, acvi, dario-piotrowicz, jnizet and piyush132000

v14.0.6
Compare Source
compiler-cli

Commit
Type
Description

99697dae66
fix
only consider used pipes for inline type-check requirement (#46807)

forms

Commit
Type
Description

4f469cbef3
fix
expose ControlConfig in public API (#46594)

e8c8b695f2
fix
Move all remaining errors in Forms to use RuntimeErrorCode. (#46654)

localize

Commit
Type
Description

14863acb1a
fix
add --project option to ng-add schematic (#46664)

Special Thanks
Alan Agius, Andrew Scott, Bob Watson, Dylan Hunn, George Kalpakas, Ivaylo Kirov, Jessica Janiuk, JoostK, Joshua VanAllen, Lukas Matta, Marcin Wosinek, Nicolas Molina Monroy, Paul Gschwendtner, SoulsMark, Uday Sony, dario-piotrowicz, markostanimirovic and zhysky

v14.0.5
Compare Source
router

Commit
Type
Description

a3bd65e2b8
fix
Ensure APP_INITIALIZER of enabledBlocking option completes (#46634)

Special Thanks
Alan Agius, Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bob Watson, George Kalpakas, Paul Gschwendtner and Pawel Kozlowski

v14.0.4
Compare Source
animations

Commit
Type
Description

51be9bbe29
fix
cleanup DOM elements when the root view is removed (#45143)

999aca86c8
fix
enable shadowElements to leave when their parent does (#46459)

common

Commit
Type
Description

42aed6b13e
fix
handle CSS custom properties in NgStyle (#46451)

core

Commit
Type
Description

1e7f22f00a
fix
trigger ApplicationRef.destroy when Platform is destroyed (#46497)

8bde2dbc71
fix
Update ngfor error code to be negative (#46555)

57e8fc00eb
fix
Updates error to use RuntimeError code (#46526)

forms

Commit
Type
Description

74a26d870e
fix
Convert existing reactive errors to use RuntimeErrorCode. (#46560)

747872212d
fix
Update a Forms validator error to use RuntimeError (#46537)

router

Commit
Type
Description

d6fac9e914
fix
Ensure that new RouterOutlet instances work after old ones are destroyed (#46554)

Special Thanks
Alan Agius, Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Bezael, Chad Ramos, Chellappan, Cédric Exbrayat, Dylan Hunn, George Kalpakas, Jeremy Meiss, Jessica Janiuk, Joey Perrott, KMathy, Kristiyan Kostadinov, Paul Gschwendtner, Pawel Kozlowski, Ramesh Thiruchelvam, Vaibhav Kumar, arturovt, dario-piotrowicz and renovate[bot]

v14.0.3
Compare Source
animations

Commit
Type
Description

3dd7bb3f8f
fix
reset the start and done fns on player reset (#46364)

core

Commit
Type
Description

c086653655
fix
deduplicate imports of standalone components in JIT compiler (#46439)

5d3b97e1f8
fix
handle NgModules with standalone pipes in TestBed correctly (#46407)

platform-server

Commit
Type
Description

6ad7b40a6f
fix
invalid style attribute being generated for null values (#46433)

Special Thanks
4javier, Aakash, Alan Agius, Andrew Kushnir, Aristeidis Bampakos, Dany Paredes, Derek Cormier, JoostK, Kristiyan Kostadinov, Paul Gschwendtner, Ramesh Thiruchelvam, behrooz bozorg chami, dario-piotrowicz, markostanimirovic, renovate[bot] and web-dave

v14.0.2
Compare Source
common

Commit
Type
Description

ef5cba3df7
fix
allow null in ngComponentOutlet (#46280)

compiler-cli

Commit
Type
Description

8ecfd71fd7
fix
don't emit empty providers array (#46301)

b92c1a6ada
fix
use inline type-check blocks for components outside rootDir (#46096)

core

Commit
Type
Description

3fd8948b4a
fix
Resolve forwardRef declarations for jit (#46334)

Special Thanks
Alex Rickabaugh, Andrew Scott, Badawi7, Daniel Schmitz, Derek Cormier, JoostK, Kevin Davila, Kristiyan Kostadinov, Paul Draper, Paul Gschwendtner, Tom Eustace, Totati, Younes Jaaidi, alefra, dario-piotrowicz, markostanimirovic, mgechev, piyush132000, sten-bone and vivekkoya

angular/angular (zone.js)
v0.12.0
Compare Source
Bug Fixes

zone.js: cancel tasks only when they are scheduled or running (#46435) (b618b5a), closes #45711
zone.js: Fix ConsoleTask interface typo (#47090) (91954cf)

0.11.8 (2022-08-08)
Features

zone.js: Update to the simpler Async Stack Tagging v2 API (#46958) (f23232f)

0.11.7 (2022-07-20)
Bug Fixes

zone.js: do not invoke jasmine done callback multiple times with waitForAsync (4e77c7fbf38)

Features

zone.js: add AsyncStackTaggingZoneSpec implementation (#46693) (848a009)
zone.js: include jasmine describe block name when raising unexpected task error (de86285)
zone.js: include zone name when sync-test zone reports tasks (72c2567)

0.11.6 (2022-06-02)
Bug Fixes

zone.js: check if process is defined when patching the GlobalErrors.install (#45392) (c7bcc1b), closes #42260
zone.js: in TaskTrackingZoneSpec track a periodic task until it is cancelled (#45391) (f19b36f)
zone.js: read Symbol.species safely (#45369) (e2eaac3)
zone.js: should ignore multiple resolve call (#45283) (aebf165), closes #44913
zone.js: swallow the error when the element callback is not patchable (#45400) (4ea70e3), closes lwc/engine-core/src/framework/base-bridge-element.ts#L180-L186 #42546

BREAKING CHANGES

zone.js: in TaskTrackingZoneSpec track a periodic task until it is cancelled

The breaking change is scoped only to the plugin
zone.js/plugins/task-tracking. If you used TaskTrackingZoneSpec and
checked the pending macroTasks e.g. using (this.ngZone as any)._inner ._parent._properties.TaskTrackingZone.getTasksFor('macroTask'), then
its behavior slightly changed for periodic macrotasks. For example,
previously the setInterval macrotask was no longer tracked after its
callback was executed for the first time. Now it's tracked until
the task is explicitly cancelled, e.g with clearInterval(id).
0.11.5 (2022-03-03)
Bug Fixes

zone.js: async-test should only call done once (#45025) (dea7234)
zone.js: defineProperties should also set symbol props (#45098) (b437d12), closes #44095
zone.js: fix several test cases which trigger done() multiple times (#45025) (d5565cc)
zone.js: only one listener should also re-throw an error correctly (#41868) (299f92c), closes #41867 /github.com/angular/angular/pull/41562#issuecomment-822696973
zone.js: patch global instead of Mocha object (#45047) (8efbdb5), closes #42834
zone.js: should continue to executue listeners when throw error (#41562) (008eaf3), closes #41522
zone.js: update several flaky cases (#41526) (25a83eb), closes #41434

Features

zone.js: add Promise.any() implementation (#45064) (4d494d2), closes #44393
zone.js: update electron patch to support electron/remote 14 (#45073) (d65706a), closes #43346

0.11.4 (2021-02-10)
Bug Fixes

zone.js: fesm2015 bundle should also be strict module. (#40456) (f35f7c6), closes #40215 #40215
zone.js: fix typo in zone_externs (#40348) (8116edb)
zone.js: patch child method that overrides an already patched method (#39850) (82e3f54)
zone.js: setTimeout patch should clean tasksByHandleId cache. (#40586) (0652b29), closes #40387
zone.js: update build tooling for latest changes in rules_nodejs (#40710) (2827845)

Features

zone.js: monkey patches queueMicrotask() (#38904) (27358eb), closes #38863

0.11.3 (2020-10-27)
Bug Fixes

zone.js: remove global declaration (#37861) (90c0772), closes #37531

0.11.2 (2020-09-19)
Bug Fixes

zone.js: jest getRealSystemTime should return native time (#39127) (ffc3332)
zone.js: add missing types field in package.json (#38585) (27cc56b), closes #38584
zone.js: defineProperty patch should not swallow error (#37582) (45a73dd), closes #37432
zone.js: run tests in umd format (#37582) (40096be)
zone.js: should have better backward compatibilities (#38797) (a33d630), closes #38561 #38669
zone.js: should invoke xhr send task when no response error occurs (#38836) (d92a0dd), closes #38795
zone.js: zone.js toString patch should check typeof Promise is function (#38350) (18e474f), closes #38361

Features

zone.js: add jest fakeTimers support (#39016) (82d54fe), closes #38851

Refactor

zone.js: refactor(zone.js): rename several internal apis in fake async zone spec (#39127) (8a68669)

Build

zone.js: build(zone.js): zone.js should output esm format for fesm2015 bundles (#39203) (822b838)

BREAKING CHANGES

zone.js: ZoneJS no longer swallows errors produced by Object.defineProperty calls.

Prior to this change, ZoneJS monkey patched Object.defineProperty and if there is an error
(such as the property is not configurable or not writable) the patched logic swallowed it
and only console.log was produced. This behavior used to hide real errors,
so the logic is now updated to trigger original errors (if any). One exception
where the patch remains in place is document.registerElement
(to allow smooth transition for code/polyfills that rely on old behavior in legacy browsers).
If your code relies on the old behavior (where errors were not thrown before),
you may need to update the logic to handle the errors that are no longer masked by ZoneJS patch.
0.11.1 (2020-08-19)
Bug Fixes

zone.js: zone.js package.json should not include files/directories field (#38528) (6b662d1), closes #38526 #38516 #38513

v0.11.8
Compare Source
Features

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm notice
npm notice New minor version of npm available! 8.5.5 -> 8.19.3
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.3>
npm notice Run `npm install -g<EMAIL_ADDRESS>to update!
npm notice
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/zone.js
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@angular/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /var/folders/ht/fn9m52111xnb16zc1gcfmt5w0000gn/T/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR!


add DslMarker for test builders

Introduce a custom DslMarker for MapBuilder. This way nesting builders
won't see their parent implicit receiver and users cannot define
parent receiver's properties without an explicit receiver reference.

@hrach: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

I love this! Looks really cool 👍!
To be on the exhaustive side might want to add a test but TBH this is going to be hard to test because we need to test that something does not compile. It's doable but I don't think it's worth the trouble. @BoD any thoughts.

Agreed 😊 I was not familiar with the annotation so an example of what was possible before / not possible after would be cool but we can just try on the branch, I agree a test is not necessary.

@hrach can you run ./gradlew apiDump and commit the changed API files? This is needed so that we can track the public API

Before

After

👍

Hi guys, thanks for guidance for the API dump. I'll do this.
Testing: I was thinking about doing something, but "not compiling" requirement seemed rather very difficult to do for some trivial code. Thank you for trying out. :)

rebased


Add update instructions when compiling from source

a set of instructions would be nice to have in the wiki on how to update and maintain updates if compiling from source.

Thanks! I've added a note to the Wiki page on this, but it's as simple as doing a git pull to get the latest code changes from the master branch and then re-building Binwalk with cargo build --release.


Update Copyright statement on W3C boilerplate

The copyright statements have been updated by W3C from January 1, 2023 to https://www.w3.org/Consortium/Legal/2023/software-license.

Fixed with #42!


bazel: 0.15.2 -> 0.16.0

Motivation for this change
Upstream update
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

cc @mboes

LGTM

@GrahamcOfBorg build bazel

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: bazel
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-darwin (full log)
Attempted: bazel
Partial log (click to expand)
//examples/cpp:hello-success_test                                        PASSED in 0.1s
//examples/java-native/src/test/java/com/example/myproject:hello         PASSED in 0.3s

Executed 2 out of 2 tests: 2 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 20 total actions
installing
post-installation fixup
patching script interpreter paths in /nix/store/zb5hmpdx1hlpjlv7g33yia0f55bkv7pv-bazel-0.16.0
/nix/store/zb5hmpdx1hlpjlv7g33yia0f55bkv7pv-bazel-0.16.0

Success on x86_64-linux (full log)
Attempted: bazel
Partial log (click to expand)
//examples/java-native/src/test/java/com/example/myproject:hello         PASSED in 0.8s

Executed 2 out of 2 tests: 2 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 22 total actions
installing
post-installation fixup
patching script interpreter paths in /nix/store/f9w3vavmpq4f9gjrdxjcp13cdj84w6sb-bazel-0.16.0
checking for references to /tmp/.bazel-1000 in /nix/store/f9w3vavmpq4f9gjrdxjcp13cdj84w6sb-bazel-0.16.0...
/nix/store/f9w3vavmpq4f9gjrdxjcp13cdj84w6sb-bazel-0.16.0

Rebased on my recent changes, merging.


ref: Remove Hub.current is not None checks

By construction, Hub.current is never None, such that the expression
Hub.current is not None

always evaluates to True.
This commit simplifies all uses of Hub.current, and in particular
chooses to write return Hub.current.method(...) for every method, even
when the method returns None. The intent is to make it easier to keep
the static API matching the Hub behavior. Without this, if a method
returns anything other than None the static API would silently drop it,
leading to unnecessary debugging time spent trying to identify the
culprit.

Removed now unused import
from contextlib import contextmanager


Motd on join

So, when a player has the pjw.options.motd permission, the server motd will be displayed to the player on join. 2 things about this:

Why is that even in this plugin anyway? That would be a feature for an essentials plugin like nucleus, nexus or essentials imho. It looks really out of place for a world management plugin. Cause of that, I'd suggest removing it.

If you want to keep it, I would suggest adding a config entry to disable this globally. I for example use Pex and have a an operator group with all permissions and I don't want to remove that specific permission (or any permission for that matter) from that group just so I don't get that motd anymore.

I agree.
7111253d732dbab00ed6d9c888f2adff2bc4eedf


Add Ikea Tradfri wireless dimmer

Hi, please add TRADFRI wireless dimmer
{"brightness":255,"device":{"ieeeAddr":"0x000b57fffe29ee14","friendlyName":"0x000b57fffe29ee14","type":"EndDevice","nwkAddr":6252,"manufId":4476,"manufName":"IKEA of Sweden","powerSource":"Battery","modelId":"TRADFRI wireless dimmer","status":"online"}}

@MiloshCZ if I understand correctly this is read only device which means there is no ability to somehow change its state from domoticz?

Yes, it is only one way. And it send only "brightness".
Model is "ICTC-G-1" https://github.com/Koenkk/zigbee2mqtt/wiki/Supported-devices

What from domoticz devices do you think fit better for this wireless dimmer: Dimmer switch or custom sensor with brightness as value?

I think, that dimmer switch is ok

@MiloshCZ could you please check if is works properly in latest master

Hi, tested, everything is OK. Thank you very much


Add footer section

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

[ ] I am running the latest version
[ ] I checked the documentation and found no answer
[ ] I checked to make sure that this issue has not already been filed
[ ] I'm reporting the issue to the correct repository (for multi-repository projects)

Context
Expected Behavior
The website would contain a footer section mainly quoting name of the developer and also including some social platform links like github repo link for contribution.
Failure Information (for bugs)
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Sure, go ahead @Akanksha-Sen


Process srcdoc attributes

Injecting a content script when 'allFrames: true' only injects into frames that are specified with a 'src' attribute.  Therefore, 'srcdoc' attributes must be handled separately.  This is a large step towards making the extension idempotent.

Won't a srcdoc'ed iframe appear in the dom even though it is srcdoc'ed? And if it appears in the dom,
just recurse into it?

That's what I would think, but based on my observations and what I've tested out, it seems to ignore them.  I don't know where if anywhere this is specified, but I haven't been able to find anything.

If you try to run it on the HTML in this file, you can see that it doesn't inject the script the lower level frames.  I also tried it on pages with both src iframes and srcdoc iframes, and found that only the src iframes got scripts injected.
srcdocIframes.txt

I'm sure it doesn't. The problem with writing srcdoc down as an inline attribute is that the srcdoc
attribute may refer to external css, font, etc resources. In general you'll need to recurse into that document
and fetch its external resources.
But LGTM for this PR since this makes progress.


Iris: Add connector to Pyris

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Motivation and Context

Description
This PR replaces the IrisModels and the IrisModelService with the IrisConnectorService which connects the server of Artemis with an Iris implementation in Python called Pyris. Through Pyris, we can utilize Microsoft's Guidance library.
Steps for Testing
Testing is currently difficult since Pyris is not implemented yet.
Review Progress

Performance Review

[x] I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Class/File
Line Coverage
Confirmation (assert/expect)

IrisAuthorizationInterceptor.java
100%
✅

IrisConnectorService.java
77%
❌

IrisModel.java
100%
✅

CodeHintService.java
96%
✅

IrisMessageService.java
100%
✅

IrisSessionService.java
90%
✅

IrisSettingsService.java
88%
✅

IrisChatSessionService.java
84%
✅

IrisHestiaSessionService.java
90%
✅

IrisMessageResource.java
100%
✅

IrisSessionResource.java
100%
✅

Codecov Report

Merging #6714 (b310e8a) into feature/iris-settings (5b63c9c) will increase coverage by 4.21%.
The diff coverage is 68.42%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                     Coverage Diff                     @@
##             feature/iris-settings    #6714      +/-   ##
===========================================================
+ Coverage                    76.19%   80.41%   +4.21%
- Complexity                       0    14026   +14026
===========================================================
  Files                         1311     2500    +1189
  Lines                        48771    94084   +45313
  Branches                      8514    13154    +4640
===========================================================
+ Hits                         37161    75656   +38495
- Misses                        5894    10162    +4268
- Partials                      5716     8266    +2550

Impacted Files
Coverage Δ

...ervice/connectors/iris/IrisConnectorException.java
0.00% <0.00%> (ø)

...vice/connectors/iris/dto/IrisErrorResponseDTO.java
0.00% <0.00%> (ø)

...mis/service/connectors/iris/dto/IrisStatusDTO.java
0.00% <0.00%> (ø)

.../www1/artemis/service/iris/IrisMessageService.java
100.00% <ø> (ø)

.../www1/artemis/service/iris/IrisSessionService.java
84.61% <ø> (ø)

...ww1/artemis/web/rest/iris/IrisMessageResource.java
100.00% <ø> (ø)

...ww1/artemis/web/rest/iris/IrisSessionResource.java
96.15% <ø> (ø)

...ent-tab-bar/course-management-tab-bar.component.ts
88.40% <0.00%> (ø)

...s/service/connectors/iris/IrisHealthIndicator.java
23.07% <23.07%> (ø)

...www1/artemis/service/iris/IrisSettingsService.java
77.94% <41.66%> (ø)

... and 11 more

... and 1172 files with indirect coverage changes

Flag
Coverage Δ

client
76.19% <66.66%> (+<0.01%)
:arrow_up:

server
84.95% <68.46%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b63c9c...b310e8a. Read the comment docs.


[Bug]: High CPU when using vscode editor

Description
Observe High CPU with code suggestion.
threaddumps.zip
Steps to Reproduce
No response
Affected Version(s)
2201.2.3
OS, DB, other environment details and versions
Ubuntu 20.04
Kernel 5.14.0-1051-oem
Related area
-> Formatter
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Had a look at the thread dump. Seems like a thread is consuming lot of CPU time around parser's recovery logic:
"pool-1-thread-1" #13 prio=5 os_prio=0 cpu=117212.66ms elapsed=2038.02s tid=0x00007f9754cca800 nid=0x416a8 runnable  [0x00007f97265e1000]
   java.lang.Thread.State: RUNNABLE
	at io.ballerina.compiler.internal.parser.BallerinaParserErrorHandler.seekMatch(BallerinaParserErrorHandler.java:883)
	at io.ballerina.compiler.internal.parser.AbstractParserErrorHandler.seekMatchInSubTree(AbstractParserErrorHandler.java:279)
	at io.ballerina.compiler.internal.parser.AbstractParserErrorHandler.seekInAlternativesPaths(AbstractParserErrorHandler.java:373)
	at io.ballerina.compiler.internal.parser.BallerinaParserErrorHandler.seekMatchInAlternativePaths(BallerinaParserErrorHandler.java:2406)
	at io.ballerina.compiler.internal.parser.BallerinaParserErrorHandler.seekMatch(BallerinaParserErrorHandler.java:1219)
	at io.ballerina.compiler.internal.parser.AbstractParserErrorHandler.seekMatchInSubTree(AbstractParserErrorHandler.java:279)
	at io.ballerina.compiler.internal.parser.AbstractParserErrorHandler.seekInAlternativesPaths(AbstractParserErrorHandler.java:373)
	at io.ballerina.compiler.internal.parser.BallerinaParserErrorHandler.seekMatchInAlternativePaths(BallerinaParserErrorHandler.java:2406)
	at io.ballerina.compiler.internal.parser.BallerinaParserErrorHandler.seekMatch(BallerinaParserErrorHandler.java:1219)
	at io.ballerina.compiler.internal.parser.AbstractParserErrorHandler.seekMatchInSubTree(AbstractParserErrorHandler.java:279)
	at io.ballerina.compiler.internal.parser.AbstractParserErrorHandler.seekInAlternativesPaths(AbstractParserErrorHandler.java:373)
	at io.ballerina.compiler.internal.parser.BallerinaParserErrorHandler.seekMatchInAlternativePaths(BallerinaParserErrorHandler.java:2406)
	at io.ballerina.compiler.internal.parser.BallerinaParserErrorHandler.seekMatch(BallerinaParserErrorHandler.java:1219)

We have seen a similar behavior sometime back in code-server/choreo as well. This happens rarely and some combinations of incomplete code segments cause the parser to perform some intensive calculations to determine the best possible path to recover.
I assume @tharindu1st didn't experience a high memory usage (out of memory issue), only the CPU usage spike. @lochana-chathura @rdulmina what do you think?

ErrorHandler usually runs recursively to determine the best solution. If there is a reproducible sample we can have a look

I tried to reproduce this locally using the APK project. And I could reproduce https://github.com/ballerina-platform/ballerina-lang/issues/38775 which was caused by the ConstantValueResolver. A PR to fix this in 2201.2.x branch have been sent with https://github.com/ballerina-platform/ballerina-lang/pull/38790.

When an OOM occurs, CPU usages goes high due to thrashing (GC trying to cleanup memory, JVM not doing any effective work). It can be the cause for this issue. I will continue to test on 2201.3.0-rc3 (because testing in 2201.2.3 again will reproduce the OOM issue only).

The fix for the mentioned OOM issue is merged with https://github.com/ballerina-platform/ballerina-lang/pull/38790 and will be available in 2201.2.4.

@IMS94 we now testing with 2021.3.0 and will let you know if this fix works for us.
Thanks
Tharindu

@tharindu1st thanks! How did it go? Did you experience the same?

Closing this since the original issue is not no longer being reported. Please reopen or create a new issue if you encounter this again.


How to add your own data?

I really appreciate this work and package. I was trying to run the app, which worked but can I have the documentation on how to add your own data to the backend.
I really appreciate your help.
Thank you for your help.

The current version does not have a full support of using new datasets. You can only test your own data in the notebook.
We have updated the README and added an example to show the detail.


macOS build fails

Gives the error
from smart_open import open
ImportError: cannot import name 'open' from 'smart_open'

Happens only to the macOS version. From conda list I found that it had smart_open 1.8.0, the other OS versions have smart_open 2.1.0 instead.

Solved by PR #28


Add Persistence strategy at Workflow / Activity Level

This PR add the necessary UI to configure Persitence Strategy at Workflow and Activity Level
#118

is draft until some model are defined in Elsa.Api.Client.Resources.WorkflowDefinitions.Enums lib


Could not install Qiime configuration as i get this message on Anaconda: Unable to locally verify the issuer's authority. To connect to data.qiime2.org insecurely, use `--no-check-certificate

Have you had a chance to check out the docs?
https://docs.qiime2.org
There are many tutorials, walkthroughs, and guides available.
If you still need help, please visit:
https://forum.qiime2.org/c/user-support
Help requests filed here will not be answered.

please could you help me to install Qiime2 on my Windows10, i have a problem in installing the configuration step

Sorry, but what do you mean with that #631?
Sent from Hadeer Ismail
On Monday, August 1, 2022, 7:32 PM, Evan Bolyen @.***> wrote:
Closed #631 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I tried these bash
On Monday, August 1, 2022 at 09:02:15 PM GMT+2, Yahoo Action<EMAIL_ADDRESS>wrote:

Sorry, but what do you mean with that #631?
Sent from Hadeer Ismail
On Monday, August 1, 2022, 7:32 PM, Evan Bolyen @.***> wrote:
Closed #631 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Hadeer,
Sorry I assumed you would have seen my reply to your previous email first. We answer questions on the QIIME 2 Forum.

Thank you
Sent from Hadeer Ismail
On Monday, August 1, 2022, 9:46 PM, Evan Bolyen @.***> wrote:
Hi Hadeer,
Sorry I assumed you would have seen my reply to your previous email first. We answer questions on the QIIME 2 Forum.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


undefined method `on_numblock' for RuboCop::Cop::Commissioner

# .codeclimate.yml
version: "2"
checks:
  file-lines:
    enabled: false
  method-lines:
    enabled: false
plugins:
  brakeman:
    enabled: true
  bundler-audit:
    enabled: true
  duplication:
    enabled: true
    config:
      languages:
      - ruby:
      - javascript:
    exclude_patterns:
    - test/
  rubocop:
    enabled: true
    channel: rubocop-0-79
exclude_patterns:
- config/
- db/
- vendor/

Error on CodeClimate:

/usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:114:in `block in on_send': undefined method `on_numblock' for #<RuboCop::Cop::Commissioner:0x00005595af1db600> (NoMethodError)
Did you mean?  on_block
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:111:in `each'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:111:in `each_with_index'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:111:in `on_send'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/commissioner.rb:33:in `block (2 levels) in <class:Commissioner>'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:114:in `block in on_send'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:111:in `each'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:111:in `each_with_index'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:111:in `on_send'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/commissioner.rb:33:in `block (2 levels) in <class:Commissioner>'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:57:in `block in on_begin'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:57:in `each'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:57:in `on_begin'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/commissioner.rb:33:in `block (2 levels) in <class:Commissioner>'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:107:in `on_def'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/commissioner.rb:33:in `block (2 levels) in <class:Commissioner>'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:57:in `block in on_begin'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:57:in `each'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:57:in `on_begin'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/commissioner.rb:33:in `block (2 levels) in <class:Commissioner>'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:99:in `on_class'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/commissioner.rb:33:in `block (2 levels) in <class:Commissioner>'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/ast/traversal.rb:14:in `walk'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/commissioner.rb:44:in `investigate'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/team.rb:124:in `investigate'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/team.rb:112:in `offenses'
	from /usr/local/bundle/gems/rubocop-0.79.0/lib/rubocop/cop/team.rb:44:in `inspect_file'
	from /usr/src/app/lib/cc/engine/source_file.rb:14:in `inspect'
	from /usr/src/app/lib/cc/engine/rubocop.rb:35:in `block (2 levels) in run'
	from /usr/src/app/lib/cc/engine/rubocop.rb:29:in `each'
	from /usr/src/app/lib/cc/engine/rubocop.rb:29:in `block in run'
	from /usr/src/app/lib/cc/engine/rubocop.rb:28:in `chdir'
	from /usr/src/app/lib/cc/engine/rubocop.rb:28:in `run'
	from /usr/src/app/bin/codeclimate-rubocop:17:in `<main>'

This error has been resolved in RuboCop 0.80.
https://github.com/rubocop-hq/rubocop/issues/7647
This issue will be resolved the 0.80 channel is activated in Code Climate.
https://github.com/codeclimate/codeclimate-rubocop/issues/223

Hi @stefanahman and @koic ,
Thanks for the notification! Putting this into our review queue.
Emily, Code Climate Support

@efueger how's that queue going?

Hi @stefanahman. Can you update to the new Rubocop 0.80 channel, and let me know if that resolves the undefined method on_numblock'` error you're seeing?

Hi @stefanahman. Can you update to the new Rubocop 0.80 channel, and let me know if that resolves the undefined method on_numblock'` error you're seeing?

I think it resolves the error mentioned above, but it's still unfortunately unusable because of https://github.com/codeclimate/codeclimate-rubocop/issues/226. When are you patching to 0.80.1?
Regards

Hi @stefanahman ,
I temporary disable Style/HashTransformValues cop to prevent #226 .
I use 0.80.0 but I see no errors.

Hi @stefanahman ,
You can remove the workaround for #226 because #227 has been merged.