Please update help document on using a PAT for git

What article on docs.github.com is affected?
https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token#using-a-token-on-the-command-line
What part(s) of the article would you like to see updated?
Please see the ticket I raised about this:
https://support.github.com/ticket/personal/0/1033425
Additional information

👋 @plastikfan Thanks so much for opening an issue! Since folks in this open source repo don't have access to see your support ticket, could you describe what it is you'd like to see updated in the docs? Thank you!

Sorry I made the assumption that you could see the ticket, because I can. Ive copied the text for you to see the issue:
Please can you update this article for essential required information regarding use of a personal access token to authenticate to git over https Creating a personal access token.
Having created a new PAT, I had no idea what to do with it as this article doesnt explain. I found an equivalent article for using an ssh key and in that article you do say that to use the newly generated ssh key, you use ssh-add. We need equivalent information for PAT on https, for windows, linux and mac).

So to be clear, what is https/PAT equivalent of this page:
https://docs.github.com/en/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent
In that page there is a section that says how to add an ssh key to the ssh agent.
We need the same for https/PAT.
You also need to explain the Windows Credential manager (and equivalent on mac/linux). If the user is not currently being prompted for credentials, it because the credential manager has this already cached and the user needs to know what to do with the credntial manager in order to be re-prompted.

Thanks for the clarification @plastikfan! If you've got a suggestion that will work for all Windows users out of the box, you're welcome to open a pull request to make the fix. Thank you!

reply, I havent got the time to do a pull request. I searched for an official windows explanation of the windows credential manager, but the officiall link I found in MS documents was really quite deficient. I better explanation would be soemthime like:
https://www.digitalcitizen.life/credential-manager-where-windows-stores-passwords-other-login-details/


IntelliJ IDE setup: JDK config missing in docs

Is there an existing issue for this?

[X] I have searched the existing issues

Please describe the new behavior that that will improve Egeria
In the documentation of the developers dojo (https://egeria-project.org/education/egeria-dojo/developer/overview/#installing-intellij) a major step about configuring JDK 11 is missing; If you don't do this you won't get the "maven" tab on the right of your IDE (clicking the POM.xml context menu and saying "Add as maven project".
Cheers,
Ian
Alternatives
No response
Any Further Information?
No response
Would you be prepared to be assigned this issue to work on?

[ ] I can work on this

I just figured the the configuration mentioned is after the import of the project (https://egeria-project.org/education/egeria-dojo/developer/overview/#loading-egeria-into-intellij-idea) ... for me the maven build process would not kick-off as described unless the JDK is being configured. Maybe it would be beneficial to move this step up in the doc ...
Cheers,
Ian

I took a look at the docs,
The first step refers to downloading IntelliJ -- at this point you don't have a project, or egeria source. The direction given is to configure maven. If using a fairly current (last 1-2 years?) version of IntelliJ, and as long as maven wasn't deselected for install, no changes should be required here.
Did you see something different at this point
The later content gets into creating a project, and here does specifically mention setting up the SDK
This split seems reasonable?


Fix for creating VectorStoreFile

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.62%. Comparing base (ca22dad) to head (8ea68a5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #156      +/-   ##
============================================
+ Coverage     89.54%   89.62%   +0.08%
- Complexity      696      697       +1
============================================
  Files           101      101
  Lines          1463     1465       +2
  Branches         31       31
============================================
+ Hits           1310     1313       +3
+ Misses          108      107       -1
  Partials         45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update README.md

Home users not using SSL will experience errors from ESX and other scripts that have absolutely nothing to do with them. Adding ssl=none to the end of the convar fixes these errors.

Maybe you should add it as a seperate subsection in the readme, defaulting for everyone to not use SSL is a bad idea.

It's not defaulted for everyone. Nor does it suggest that. The instruction its self reads:

If you are home hosting with no ssl you need to append your convar to match the following:

Which is completely true. Without doing so you can throw errors that have nothing to do with the scripts they throw the errors too. Users who are home hosting with no ssl to their mysql servers aren't open to the internet by default. Which is why not having ssl in the first place is no issue. Adding this option does nothing but to hinder their security since they are already not using ssl.
I would hope anyone reading the above would know it only applies to home hosted users with no ssl already since that's what it literally says :)

oh yes.
I failed to read the diff properly after waking up i am sorry.
btw is that with xampp? because i saw many tutorials for using xampp, compared to using a mariadb/mysql installation, which supports ssl out of the box.

Glad you asked. This is using the latest edition of community server mysql. Full install rather than limited or custom.

I too have this issue :)

Home users not using SSL will experience errors from ESX and other scripts that have absolutely nothing to do with them. Adding ssl=none to the end of the convar fixes these errors.

Do you know if this causes an error in which ESX fails to pull identifiers from the database?

oh yes.
I failed to read the diff properly after waking up i am sorry.
btw is that with xampp? because i saw many tutorials for using xampp, compared to using a mariadb/mysql installation, which supports ssl out of the box.

No I use MySQL. Perhaps I missed a setting? Default full install did not provide ssl.

Glad you asked. This is using the latest edition of community server mysql. Full install rather than limited or custom.
I too have this issue :)

I think they were directing that to myself. The majority of errors are usually something a user has done wrong. Yes it can be the script too, but if you have an error print on server start, and you append the above to the convar, you will notice the error go away immediately at next start. This is the only reason I know this to work. I wouldn't just try this to 'solve an error'. You should take your issue to the proper page.
This is meant specifically for home hosted users with no SSL already. SSL is a very important feature especially if you open your db to the internet. Please do not mis-understand this PR.

Home users not using SSL will experience errors from ESX and other scripts that have absolutely nothing to do with them. Adding ssl=none to the end of the convar fixes these errors.

Do you know if this causes an error in which ESX fails to pull identifiers from the database?
@EmpireAssassin

That is not one of the errors I've had. Sound's more like something on your end or ESX maybe.


add hostNetwork

hostPort
integer	Number of port to expose on the host. If specified, this must be a valid port number, 0 < x < 65536. If HostNetwork is specified, this must match ContainerPort. Most containers do not need this.

If HostNetwork is not specified，Node not listen

Coverage increased (+0.02%) to 43.163% when pulling 61098bc1c33901293871b75d9168c827268fb0bc on im-vincent:dev-hostport into b7b6b9040e7d4f76c554120ee87606676e352dce on kubernetes:master.

I signed it!

Coverage remained the same at 43.147% when pulling 61098bc1c33901293871b75d9168c827268fb0bc on im-vincent:dev-hostport into b7b6b9040e7d4f76c554120ee87606676e352dce on kubernetes:master.

@im-vincent why are you changing this? Using hostNetwork is not a requirement of the ingress controller. Using this setting is optional.
Please check this comment in one of the examples about the principal reason why hostNetwork should be enabled, but only applies with a CNI provider


Add mods to beatmap.last_np

The last_np field is used for keeping context of what the player's last /np'ed.
We currently parse the mods out of the /np in regex:
https://github.com/osuAkatsuki/bancho.py/blob/a043f12e4a77f83faa180938214e02f79333872d/app/api/domains/cho.py#L74-L79
But we do not store this in the beatmap.last_np field after parsing from regex:

https://github.com/osuAkatsuki/bancho.py/blob/a043f12e4a77f83faa180938214e02f79333872d/app/api/domains/cho.py#L1226-L1230
https://github.com/osuAkatsuki/bancho.py/blob/a043f12e4a77f83faa180938214e02f79333872d/app/api/domains/cho.py#L402-L406

This data is useful so it can then later be used for e.g. pp calculation based on context.

If this is implemented it could directly be integrated into the !with command. Make sure to merge #356 first


refactor: Moved InternalsVisibleTo to .csproj.

@HavenDV is there an advantage to doing this in the csproj over the cs file? IIRC the csproj just generate a file on your behalf which to me doesn't really add any value and in fact causes more temp files to be created.

No big difference, except that we will get rid of this file and all project settings will be stored in one place
I see the benefit in that lately you almost never expect an AssemblyInfo file to be present in a project, because now it is almost always generated, and it is better to put it in the project file.
I don't think generation has even a small impact on build time, besides it is generated for other attributes anyway
Feel free to just decline this, it's just a suggestion

+1 for this PR, as it is the more modern approach.

Thanks for the contribution and I buy the argument that this file is getting generated for other attributes already so there isn't any real reason to not add this one. I made one suggestion which makes separates the public key into its own property.


Decoder code issue

https://github.com/patrickfav/base122-java/blob/master/src/main/java/at/favre/lib/encoding/Base122.java#L124
To loop through the UTF-8 encoded string, you should use:
char[] utf8Bytes = base122Data.toCharArray();
instead of:
byte[] utf8Bytes = base122Data.getBytes(StandardCharsets.UTF_8);
Because a byte can only represent a partial UTF-8 character and the range of a byte is -128 to 127, so in line 128, the if statement will always be false (a byte will never larger than 127).

Thanks, this solves the decoder failure for me. Otherwise this library is buggy.


Reference to an unrelated Azure service

Regarding

Once you've selected the advanced options you require, select OK in Power Query Desktop or Next in Power Query Online to connect to your Azure SQL database.

Azure SQL database is a different Azure service. Instead of "Azure SQL database" it should say "Azure Synapse Analytics", or perhaps reference the specific SQL pool technology (serverless or dedicated) within Azure Synapse Analytics.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7f15da4f-8f22-3f68-165c-1bb0c4edc887
Version Independent ID: 29d89981-6694-8b87-d5b6-614b8680cd90
Content: Power Query Azure Synapse Analytics (SQL DW) connector - Power Query
Content Source: powerquery-docs/Connectors/AzureSQLDataWarehouse.md
Service: powerquery
GitHub Login: @bezhan-msft
Microsoft Alias: bezhan

@VitalyMCT  you seem like you are really knowledgeable about these subjects. If you have any time, we'd appreciate some help to repair the text when you see issues. There's a pencil icon on the top of the docs, and you can propose the necessary edit, and we'll triage and discuss those proposals.
This is the link for the page you found the bug on if you want to give it a try.
https://github.com/MicrosoftDocs/powerquery-docs/blob/main/powerquery-docs/Connectors/AzureSQLDataWarehouse.md

Hi @VitalyMCT
Thanks for the feedback! The article has been updated and now refers to Azure Synapse Analytics.


Multiple environments get added an SSH key even though only 1 environment was chosen to add SSH key

Steps:

Create2-3 environments
Add SSH key from Tray to only 1 of them
Result:
Mutiple envionments get added SSH key
Extras:
This is happening on Windows 8.1
Tray version:

It is possible that you choose one Environment and get this result, when, for example, you unchecked already chosen an environment and checked the new one. I mean, if you have A as checked and B as unchecked, but if you are trying to uncheck A, check B and save changes, then it is OK for both of environments to go UNDER MODIFICATION since you change both of environments. BUT if both of A and B was unchecked, but you choose only one and saved the changes, it means it's bug.
Can you please give some details about your steps. I am testing it now, but couldn't reproduce it.

@SEFI2 sure
I have created like 5 environments then generated an SSH key, then added the SSH key to one environment, but before trying to add the SSH key, one of my environments had an SSH key inside already and it was checked- I did uncheck it, then checked another environment and then I went to Hub to see if any changes are being made, and there I saw 2 environments with UNDER_MODIFICATION statuses, though I checked only one environment and previously unchecked one environment too.

Tested - did not encounter this issue.


added logical data model image

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

You don't have to choose vendor table because it was already shown by Thomas in an example logical model, the other choices of tables and relationships are good.


Publisher SDK Usage readme is missing a step in the builder for MapBox configuration

Readme is missing a required configuration step for mapBox when initializing a publisher from factory. I’d add: .mapboxConfiguration(MapboxConfiguration(mapboxKey: ”MAPBOX_KEY”))
Currently there's only this code snippet in the readme:
publisher = try? PublisherFactory.publishers() // get a Publisher Builder
    .connection(ConnectionConfiguration(apiKey: ABLY_API_KEY, clientId: CLIENT_ID)) // provide Ably configuration with credentials
    .log(LogConfiguration()) // provide logging configuration
    .transportationMode(TransportationMode()) // provide mode of transportation for better location enhancements
    .delegate(self) // provide delegate to handle location updates locally if needed
    .start()

The corresponding Jira issue is https://ably.atlassian.net/browse/SDK-1954


map pings separeted into types

hi there!
I'm working on a psychological article, in which I would like to analyse the 2 map ping types (the one with the "!" sign and the other with the "x") used during a match in order to find out how do they infulence the activity and the performance of the players. For this it would be needed to separate the count of the two type of pings. Maybe later I would need deeper data, but right now I would like to know if it's possible. I haven't got any skill to do it myself so I would be very grateful for any kind of help :)
TODO:

[ ] have the Java parser extract the ping type
[ ] make sure it doesn't break the existing code that uses pings
[ ] look up the ping types

I think it's possible.
In this method I put a sample message:
https://github.com/yasp-dota/yasp/blob/master/java_parser/src/main/java/yasp/Main.java#L150
There is a "type" field, which indicates what kind of ping it is.  However, I don't know what types exist or what they correspond to.  That data is probably buried somewhere in here: https://github.com/SteamDatabase/GameTracking/tree/master/Protobufs/dota

Is this something that you still want added?

Sure, if you're interested in the data.

I suppose it could be stored like this:
"ping_types": {
"alert": 26
"caution": 12
}
I'm assuming the existing "pings" field needs to stay the same?

Typically we'd use the numeric value for the key.
Actually the existing data structure stored in the database is a JSON blob, like
{"0": 73}
We would probably just modify the API to return this blob rather than pulling out the "0" value.  That's an API change but probably makes the most sense.


fix(traverse): exit scope early if enter it late

#3493  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Update metadata query to return correct external_url

It's currently returning something like https://tableland.xyz/rigs/1185 which isn't valid. I guess we want to return the Garage URL for the rig? But that isn't currently possible because you can't view that without connecting your wallet. Maybe that's ok, or maybe we have plans to not require a wallet connection there? cc @datadanne

Looks like we just need to run the set base URI script. Could have sworn we already did that but looks like it's still hitting testnet.tableland.network as well as old external url

Just looked at the live contract... as I remembered, we did update all this as reflected in main, eg, https://tableland.network/query?extract=true&unwrap=true&s=select json_object('name'%2C'Rig %23'||rig_id%2C'external_url'%2C'https%3A%2F%2Fgarage.tableland.xyz%2Frigs%2F'||rig_id%2C'image'%2C'ipfs%3A%2F%2F'||renders_cid||'%2F'||rig_id||'%2F'||image_full_name%2C'image_alpha'%2C'ipfs%3A%2F%2F'||renders_cid||'%2F'||rig_id||'%2F'||image_full_alpha_name%2C'image_medium'%2C'ipfs%3A%2F%2F'||renders_cid||'%2F'||rig_id||'%2F'||image_medium_name%2C'image_medium_alpha'%2C'ipfs%3A%2F%2F'||renders_cid||'%2F'||rig_id||'%2F'||image_medium_alpha_name%2C'thumb'%2C'ipfs%3A%2F%2F'||renders_cid||'%2F'||rig_id||'%2F'||image_thumb_name%2C'thumb_alpha'%2C'ipfs%3A%2F%2F'||renders_cid||'%2F'||rig_id||'%2F'||image_thumb_alpha_name%2C'animation_url'%2Canimation_base_url||rig_id||'.html'%2C'attributes'%2Cjson_insert((select json_group_array(json_object('display_type'%2Cdisplay_type%2C'trait_type'%2Ctrait_type%2C'value'%2Cvalue))from%20rig_attributes_42161_15%20where%20rig_id%3D1%20group%20by%20rig_id)%2C%27%24%5B%23%5D%27%2Cjson_object(%27display_type%27%2C%27string%27%2C%27trait_type%27%2C%27Garage%20Status%27%2C%27value%27%2Ccoalesce((select%20coalesce(end_time%2C%20%27in-flight%27)%20from%20pilot_sessions_1_7%20where%20rig_id%3D1%20and%20end_time%20is%20null)%2C%27parked%27))))%20from%20rig_attributes_42161_15%20join%20lookups_42161_10%20where%20rig_id%3D1%20group%20by%20rig_id%3B
Some rigs on marketplaces are still being driven by the old setup (testnet.tableland.network and old external_url) because they cache metadata.

Ah ok. I swear I check that, but this is great news. Thanks for correcting me.


fix delete method

Issue #12
Resolved an issue in the get_permission_map method where the mapping for the 'delete' method was inconsistent with the actual method name used in the code. The discrepancy was identified in the delete method, which was implemented as 'destroy.' To address this, I've updated the get_permission_map function to correctly map to the 'destroy' method. This adjustment ensures that the mapping aligns with the actual method names, resolving the bug and improving code consistency.

Please merge ir ASAP.

Thank you it helped a lot.

Finally something that worked


MultiPart Request return Error: escapeshellarg(): Input string contains NULL bytes

I'm sending file with a multipart request and i got this error :
Error: escapeshellarg(): Input string contains NULL bytes

in /src/vendor/php-http/message/src/Formatter/CurlCommandFormatter.php line 42
i'm using PHP 7.1
the issue is only present in dev environment
here is my code but it is not very relevant.
$builder = new MultipartStreamBuilder($this->streamFactory);

$builder
    ->addResource('file', $data, ['headers' => ['Content-Type' => $file->getMimeType()], 'filename' => $file->getFilename()]);

$multipartStream = $builder->build();
$boundary = $builder->getBoundary();

$request = $request->withBody($multipartStream);
$request = $request->withHeader('Content-Type', 'multipart/form-data; boundary="'.$boundary.'"');

$response = $this->client->sendRequest($request);

wrong repository :(


Add option to install for specific user (10.11 only)

10.11 added the option to install a profile to a specific user by adding the -U option.
sudo profiles -I -F studentdock.mobileconfig -U student installs the profile to just the student account when logged in.
Would it be possible to add this functionality to make-profile-pkg?
./make-profile-pkg.py studentdock.mobileconfig -U student

Just added an untested option in d64c1f4defeaf429f8ad1eddf41d1a0b1ecd7449.


remove etcd secret creation from odh-deployer

Description
This PR, along with this and this are meant to be tested together. Together, they address RHODS-7487. etcd secret creation is moved from odh deployer to etcd initContainer.
How Has This Been Tested?
Created Livebuilder image with changes from all 3 PRs and tested the intended behavior
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[x] JIRA link(s):
[x] The Jira story is acked.
[x] Live build image:
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work.
[x] QE contact acknowledges that this has been tested and is approved for merge.

Testing Instructions

Install quay.io/vedantm/rhods-operator-live-catalog:1.24.0-etcd
Look at odh-deployer logs

search logs for secret/etcd-passwords and secret/model-serving-etcd created. result should be empty
in redhat-ods-applications look for the etcd pod
etcd Pod should have an initContainer with logs for 2 secrets created

tested and worked as expected

/lgtm


Fix googlebench regex on Windows

There is an issue with how CMake tests for regex engines on Windows.

@lawruble13 What do we want to do with this PR?  Seems like there's no action happening on the googlebenchmark side...I'm ok with implementing this as a workaround until googlebench properly fixes this.  Unless there are some other side effects with this PR


Jupyter Book pip3 instead of pip?

Azure Data Studio Version: 1.16.1

I am investigating Jupyter Books and using the python code provided in ADS to run the jupyter-book install. This works for a number of collections but
`import sys
#install jupyter-book
cmd = f'{sys.executable} -m pip show jupyter-book'
cmdOutput = !{cmd}
if len(cmdOutput) > 1 and '0.6.4' in cmdOutput[1]:
print('Jupyter-book required version is already installed!')
else:
!pip install jupyter-book`
I find that it works when I specify "!pip3 install jupyter-book" with no errors but I had trouble the code above.

@MaddyDev can you take a look?

Did you see any errors when using pip, if so can you share them. Thanks

Many of the components of jupyter-book seem to run e.g.
Collecting entrypoints>=0.2.2
  Downloading https://files.pythonhosted.org/packages/ac/c6/44694103f8c221443ee6b0041f69e2740d89a25641e62fb4f2ee568f2f9c/entrypoints-0.3-py2.py3-none-any.whl
Collecting defusedxml
  Downloading https://files.pythonhosted.org/packages/06/74/9b387472866358ebc08732de3da6dc48e44b0aacd2ddaa5cb85ab7e986a2/defusedxml-0.6.0-py2.py3-none-any.whl
Collecting decorator
  Downloading https://files.pythonhosted.org/packages/ed/1b/72a1821152d07cf1d8b6fce298aeb06a7eb90f4d6d41acec9861e7cc6df0/decorator-4.4.2-py2.py3-none-any.whl

until it gets to:
Collecting pywin32>=1.0; sys_platform == "win32"
  WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)",)': /packages/f7/76/29e8e24a4967eb40fdf2f525aae53a1fd6e606382d957aa403f3f12ea235/pywin32-227-cp36-cp36m-win_amd64.whl
  WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)",)': /packages/f7/76/29e8e24a4967eb40fdf2f525aae53a1fd6e606382d957aa403f3f12ea235/pywin32-227-cp36-cp36m-win_amd64.whl
  WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)",)': /packages/f7/76/29e8e24a4967eb40fdf2f525aae53a1fd6e606382d957aa403f3f12ea235/pywin32-227-cp36-cp36m-win_amd64.whl
  WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)",)': /packages/f7/76/29e8e24a4967eb40fdf2f525aae53a1fd6e606382d957aa403f3f12ea235/pywin32-227-cp36-cp36m-win_amd64.whl
  WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)",)': /packages/f7/76/29e8e24a4967eb40fdf2f525aae53a1fd6e606382d957aa403f3f12ea235/pywin32-227-cp36-cp36m-win_amd64.whl
ERROR: Could not install packages due to an EnvironmentError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/f7/76/29e8e24a4967eb40fdf2f525aae53a1fd6e606382d957aa403f3f12ea235/pywin32-227-cp36-cp36m-win_amd64.whl (Caused by ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)",))

WARNING: You are using pip version 19.3.1; however, version 20.0.2 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.

Thanks

Do you have multiple installations of python on your system?

Recently I couldn't see python packages and added the following file: %APPDATA%\pip\pip.ini
[global]
trusted-host = pypi.python.org
               pypi.org
               files.pythonhosted.org
that should allow you to install programs with pip

Would that achieve the same thing? I'm using Anaconda. Should I have multiple python folders?

%USERPROFILE%\azuredatastudio-python\0.0.1\Lib\site-packages\pip
%USERPROFILE%\appdata\roaming\python\python37\site-packages

When I opened ADS and it asks me to install Notebook dependencies
Notebook dependencies installation is in progress
    > "C:\Users\XXXXX\Anaconda3\Scripts\conda.exe" install -y --force-reinstall "sparkmagic>=0.12.9"
    stdout: Collecting package metadata (current_repodata.json): ...working...
    stdout: failed
    stdout:
    stderr:
    stderr: CondaHTTPError: HTTP 000 CONNECTION FAILED for url <https://repo.anaconda.com/pkgs/main/win-64/current_repodata.json>
    stderr: Elapsed: -
    stderr:
    stderr: An HTTP error occurred when trying to retrieve this URL.
    stderr: HTTP errors are often intermittent, and a simple retry will get you on your way.
    stderr:
    stderr: If your current network has https://www.anaconda.com blocked, please file
    stderr: a support request with your network engineering team.
    stderr:
    stderr: 'https://repo.anaconda.com/pkgs/main/win-64'
    stderr:
    stderr:
    stderr:
Installing Notebook dependencies failed with error: Process exited with  with error code: 1. StdErr Output:
CondaHTTPError: HTTP 000 CONNECTION FAILED for url <https://repo.anaconda.com/pkgs/main/win-64/current_repodata.json>
Elapsed: -

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.

If your current network has https://www.anaconda.com blocked, please file
a support request with your network engineering team.

'https://repo.anaconda.com/pkgs/main/win-64'

I'd appreciate any advice.

Are you able to ping those conda/python URLs?

In cmd prompt I can't even "ping google.com"! I can access the site via Chrome browser though.


Support for nodebb v0.8.2

Planning to upgrade my community site to v0.8.2. D'you think the plugin will support that? Not sure if it supports 0.7.0, so I thought I'd ask.
Thanks!

The latest merged pull request (#30) should make it compatible with both 0.8 and 0.9. The latest version on npm includes this PR.


Implement network handling [WIP]

In addition to basic network protocol handling, this branch will implement a basic network peer that will communicate changes across the bitcoin network.
Goals:

[X] Recieve addr messages
[X] Parse most network messages
[ ] Connect to peers from addr
[ ] Broadcast addrs out to peers as required
[ ] Broadcast various network announcements (blocks, transactions) that we receive

Thanks Chris!
I will take some time with review.


Make target generate_software_bom fails with python error

Hi guys,
running the make target generate_software_bom there is a python KeyError.
(seems like the mendix-logfilter in dependencies.yml is missing a version value)
Stacktrace:
Traceback (most recent call last):
  File "buildpack/util.py", line 890, in <module>
    cli()  # pylint: disable=no-value-for-parameter
  File "/usr/lib/python3/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "buildpack/util.py", line 857, in generate_software_bom
    "version": dependency["version"],
KeyError: 'version'
make: *** [Makefile:28: generate_software_bom] Error 1

Error Source:
https://github.com/mendix/cf-mendix-buildpack/blob/master/buildpack/util.py#L857
Dependency:
https://github.com/mendix/cf-mendix-buildpack/blob/master/dependencies.yml#L55
CF Buildpack version:
4.30.6

Looks like this was resolved here: https://github.com/mendix/cf-mendix-buildpack/commit/85c67f1beac6d787bd6a8d2b1a0a8f4fbc9d8044


MCL-JCV dataset

@ZhihaoHu Thanks for your sharing. Could you share the MCL-JCV dataset by baidu disk? Thank you very much!!

link: https://pan.baidu.com/s/1C6_7lsOwG-VzSLilkOnZvA
password: hksu


[WIP] Add live-dead syllable

What does this changes
Brief summary of the changes
What was wrong
Description of what was the root cause of the issue.
How this fixes it
Description of how the changes fix the issue.
Fixes #...
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ ] Passed code styles and structures
[ ] Passed code linting checks and unit test

Hello @wannaphong! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pythainlp/util/syllable.py:

Line 8:15: E225 missing whitespace around operator
Line 9:9: E231 missing whitespace after ':'
Line 10:9: E231 missing whitespace after ':'
Line 11:10: E231 missing whitespace after ':'
Line 12:11: E231 missing whitespace after ':'
Line 13:9: E231 missing whitespace after ':'
Line 14:9: E231 missing whitespace after ':'
Line 15:9: E231 missing whitespace after ':'
Line 16:9: E231 missing whitespace after ':'
Line 19:20: E225 missing whitespace around operator
Line 22:80: E501 line too long (82 > 79 characters)
Line 23:21: E225 missing whitespace around operator
Line 27:30: E231 missing whitespace after ','
Line 29:1: E302 expected 2 blank lines, found 1
Line 29:28: E231 missing whitespace after ':'
Line 30:3: E111 indentation is not a multiple of four
Line 30:13: E225 missing whitespace around operator
Line 31:3: E111 indentation is not a multiple of four
Line 32:3: E111 indentation is not a multiple of four
Line 32:19: E225 missing whitespace around operator
Line 34:3: E111 indentation is not a multiple of four
Line 34:80: E501 line too long (243 > 79 characters)
Line 34:146: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 34:199: E225 missing whitespace around operator
Line 34:236: E225 missing whitespace around operator
Line 36:3: E111 indentation is not a multiple of four
Line 36:53: E261 at least two spaces before inline comment
Line 38:7: E111 indentation is not a multiple of four
Line 39:80: E501 line too long (139 > 79 characters)
Line 40:7: E111 indentation is not a multiple of four
Line 41:80: E501 line too long (94 > 79 characters)
Line 42:7: E111 indentation is not a multiple of four
Line 43:80: E501 line too long (106 > 79 characters)
Line 43:83: E261 at least two spaces before inline comment
Line 44:7: E111 indentation is not a multiple of four
Line 46:3: E111 indentation is not a multiple of four
Line 48:3: E111 indentation is not a multiple of four
Line 50:3: E111 indentation is not a multiple of four
Line 50:80: E501 line too long (137 > 79 characters)
Line 51:80: E501 line too long (102 > 79 characters)
Line 51:100: E225 missing whitespace around operator
Line 52:7: E111 indentation is not a multiple of four
Line 54:3: E111 indentation is not a multiple of four
Line 56:3: E111 indentation is not a multiple of four
Line 57:18: W292 no newline at end of file

In the file tests/test_util.py:

Line 667:13: E225 missing whitespace around operator
Line 700:14: E231 missing whitespace after ','


Continuous compilation seemingly caused by source generation during BSP connection

steps
This is really only happening in the Metals code base and I can't seem to get a minimal reproduction. So it could be potentially something we are doing wrong in our definition, but it does happen to both me and @tgodzik, and only when using sbt via BSP.
Using sbt 1.4.1, during a BSP connection, we have a module that enables sbt-jmh, and when the initial BSP connection is made and compilation is happening, it gets stuck and goes into a continuous loop. The logs look like this:
2020.10.30 21:38:23 INFO  running org.openjdk.jmh.generators.bytecode.JmhBytecodeGenerator /Users/ckipp/Documents/scala-workspace/scalameta-org/metals/metals-bench/target/scala-2.12/classes /Users/ckipp/Documents/scala-workspace/scalameta-org/metals/metals-bench/target/scala-2.12/src_managed/jmh /Users/ckipp/Documents/scala-workspace/scalameta-org/metals/metals-bench/target/scala-2.12/resource_managed/jmh default
2020.10.30 21:38:23 INFO  compiling bench-jmh
2020.10.30 21:38:23 INFO  time: compiled bench-jmh in 11ms
2020.10.30 21:38:23 INFO  Processing
2020.10.30 21:38:23 INFO  Processing
2020.10.30 21:38:24 INFO  compiling interfaces
2020.10.30 21:38:24 INFO  compiling input
2020.10.30 21:38:24 INFO  time: compiled interfaces in 6ms
2020.10.30 21:38:24 INFO  time: compiled input in 23ms
2020.10.30 21:38:24 INFO  compiling mtags
2020.10.30 21:38:24 INFO  compiling input-test
2020.10.30 21:38:24 INFO  time: compiled input-test in 589μs
2020.10.30 21:38:24 INFO  time: compiled mtags in 0.17s
2020.10.30 21:38:24 INFO  compiling mtest
2020.10.30 21:38:24 INFO  compiling metals
2020.10.30 21:38:24 INFO  time: compiled mtest in 4ms
2020.10.30 21:38:24 INFO  time: compiled metals in 0.19s
2020.10.30 21:38:24 INFO  compiling unit
2020.10.30 21:38:24 INFO  time: compiled unit in 69ms
2020.10.30 21:38:24 INFO  compiling bench
2020.10.30 21:38:24 INFO  time: compiled bench in 13ms
2020.10.30 21:38:24 INFO  running org.openjdk.jmh.generators.bytecode.JmhBytecodeGenerator /Users/ckipp/Documents/scala-workspace/scalameta-org/metals/metals-bench/target/scala-2.12/classes /Users/ckipp/Documents/scala-workspace/scalameta-org/metals/metals-bench/target/scala-2.12/src_managed/jmh /Users/ckipp/Documents/scala-workspace/scalameta-org/metals/metals-bench/target/scala-2.12/resource_managed/jmh default

In a small repo, the same run seems to happen, but it only happens 2-3 times and then stops. However, when in Metals it just continues to go crazy:

We have the plugin enabled here:
https://github.com/scalameta/metals/blob/089ce4289266c206a868e14245fb851144057f81/build.sbt#L649-L665
Any idea as to what might be going on here causing this?

I haven't checked but I wonder if the loops looks as follows:

Metals connects with sbt's BSP server
Metals queries for bench-jmh target's sources
sbt tries to enumerate sources, and it generates BuildInfo.scala
Metals issues compile task
sbt compiles bench-jmh, which also triggers JmhBytecodeGenerator
Metals detects this as new resource being added, and goes to step 2

/cc @adpi2

As @eed3si9n puts it, I think the problem is that sbt-jmh generates new sources at each compilation.
What I see from the traces is:

Metals sends a compileRequest on bench-jmh
sbt replies that bench-jmh is compiled successfully
Metals sends a scalaMainClasses on bench-jmh
sbt runs discoveredMainClasses that generates new sources
sbt replies that bench-jmh contains no Main classes
Metals detects the new generated sources and goes to step 1

I don't think there is much we can do on sbt side. One solution would be to make sbt-jmh truly incremental if possible: avoid generating new sources at each compilation. Another solution is to deactivate BSP on bench-jmh:
lazy val bench = project
  .settings(
     Jmh / bspEnabled := false
  )

By doing so, the bench-jmh will not be discovered.

Jmh / bspEnabled := false does not deactivate BSP on the bench project, but only on the Jmh configuration of the bench project. In other words, Metals will not trigger the bench / Jmh / compile task, but it will trigger bench / Compile / compile and bench / Test / compile.

Jmh / bspEnabled := false does not deactivate BSP on the bench project, but only on the Jmh configuration of the bench project.

Alright, that makese sense and does indeed seem to fix the problem.

I don't think there is much we can do on sbt side. One solution would be to make sbt-jmh truly incremental if possible: avoid generating new sources at each compilation. Another solution is to deactivate BSP on bench-jmh:

I know this is probably guesswork, but how widespread among different plugins do you think this may be? I can see this behavior being really difficult to troubleshoot for Metals + sbt BSP users that don't really get what's going on.

The alternative as we discussed with @adpi2 is that because:
The buildTarget/sources response tells if a file is generated or not.
we could try to not run compilation on changes to those files.

The alternative as we discussed with @adpi2 is that because:

The buildTarget/sources response tells if a file is generated or not. we could try to not run compilation on changes to those files.

🤔 yea that could work. However, would there be any potential cases where after that generation we would want to run a compilation after those are generated?

I need to look closer at how the order of this happens, but basically my concern would be

Compile request sent
BuildInfo is being used, so the BuildInfo.scala comes back as a generated source
3, Since it was generated, we don't trigger another compilation on it, and then we potentially have broken code that is trying to access BuildInfo?

yea that could work. However, would there be any potential cases where after that generation we would want to run a compilation after those are generated?

Shouldn't sbt compile BuildInfo.scala when it first generates it? We never really explicitly call source generation, it's all compiled together, so there should be no need to recompile on changes to any generated files.

Shouldn't sbt compile BuildInfo.scala when it first generates it? We never really explicitly call source generation, it's all compiled together, so there should be no need to recompile on changes to any generated files.

Alright, just checking. I'll create an issue in the Metals repo outlining this all, and then close this here.


Code

Hello, thank you for your excellent work !
When will you give the code ?

Hi, your work is excellent. May I ask where I can find the Scribble datasets?
It would be great if you could reply to me. Thank you.

@xiaoting-hub The scribble dataset is available here: https://github.com/arnabgho/iSketchNFill#scribble-dataset

Hi @BenfenYU , thanks for your interest in this project!
The code will be released within the next few days.

Hi all, the codes have been uploaded. Happy holiday!


lax.conv_general_dilated will crash when padding has some negative

lax.conv_general_dilated will crash when padding has some negative
import jax
def fn(lhs, rhs):
    window_strides = [1, 1]
    padding = [[5, 16], [-5, 1]]
    return jax.lax.conv_general_dilated(lhs, rhs, window_strides, padding)

mykey = jax.random.PRNGKey(83725540)

lhs = jax.numpy.array([[[[-7.0950737, 20.612083, 53.864067], [-12.116554, -16.742317, -7.050851 ]]]])
rhs = jax.numpy.array([[[[29.074692, 40.518192], [21.685156, 41.867775]]]])

fn(lhs, rhs)

F external/org_tensorflow/tensorflow/compiler/xla/window_util.cc:250] Check failed: bound >= 0 (0 vs. -1)
[1]   abort (core dumped)

Besides, jax.lax.conv_general_dilated_patches and jax.lax.conv_with_general_padding also have such issue
import jax
def fn(lhs):
    filter_shape = [1, 1]
    window_strides = [1, 1]
    padding = [[-4, -2], [-3, -4]]
    return jax.lax.conv_general_dilated_patches(lhs=lhs, filter_shape=filter_shape, window_strides=window_strides, padding=padding)

mykey = jax.random.PRNGKey(19446744)
lhs = jax.random.uniform(mykey, [1, 2, 3, 4], jax.numpy.float32)
fn(lhs)

F external/org_tensorflow/tensorflow/compiler/xla/window_util.cc:250] Check failed: bound >= 0 (0 vs. -3)
[1]   abort (core dumped)

import jax
def fn(lhs, rhs):
    window_strides = [1, 1]
    padding = [[-5, 0], [-16, -2]]
    lhs_dilation = [1, 1]
    rhs_dilation = [1, 1]
    return jax.lax.conv_with_general_padding(lhs, rhs, window_strides=window_strides, padding=padding, lhs_dilation=lhs_dilation, rhs_dilation=rhs_dilation)

mykey = jax.random.PRNGKey(30297051)
lhs = jax.random.uniform(mykey, [3, 2, 3, 1], jax.numpy.float32)
mykey = jax.random.PRNGKey(34585797)
rhs = jax.random.uniform(mykey, [2, 2, 1, 2], jax.numpy.float32)

fn(lhs, rhs)

F external/org_tensorflow/tensorflow/compiler/xla/window_util.cc:250] Check failed: bound >= 0 (0 vs. -2)
[1]   abort (core dumped)

Hi @zhangqiaorjc, is this comment in a wrong place?
If so, I agree that a check in python is much better than core dumped in cpp!

https://github.com/google/jax/pull/11544 should fix the issue


[Runtime] swift_demangle: Update buffer size after copying

Previously this would update buffer size before copying if the given buffer size was smaller than the result size. This lead to writing past the given buffer rather than truncating like the comment states. Update it after copying so that we get truncation along with error indication.
cc: @jckarter @rjmccall

@Azoy, can you explain how we would write past the buffer?  strlcpy is used to explicitly avoid that situation.  We would be truncating properly previously.

Wow, that is subtle.  Would you mind adding a test case for this?

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - f79eb3b8d034a2ccd734cbd26e1c4cb6272501ad

Build failed
Swift Test OS X Platform
Git Sha - f79eb3b8d034a2ccd734cbd26e1c4cb6272501ad

@swift-ci Please test OS X


Make ChangeTracker not resolved directly from DI

ChangeTracker is a top-level API class and makes use of API patterns rather than just being a service contract. It is therefore best not resolved directly from DI.

:shipit:


Add "UnrevisedEntitiesQuery" and "SubjectsQuery"

Ping https://github.com/serlo/api.serlo.org/issues/464

@inyono Merge it so that I can deploy it on staging


[CONTINT-52] Add an application to test the admission controller

What does this PR do?
Add a fake application to test the admission controller.
Which scenarios this will impact?

aws/eks
aws/kind

Motivation
We need a workload annotated with admission.datadoghq.com/enabled: true to be able to test the admission controller.
Additional Notes
The corresponding tests are in DataDog/datadog-agent#21653.

/merge

/remove

/merge


Default Media Query Breakpoints

Right now if we run the build, the media query breakpoint classes are not generated, because the index.css file is missing defaults for these parameters.  It would be great if SUIT provided default best practice parameters...probably in a separate file suit-media-query-breakpoint-defaults that is imported in index.css.  If this is done the parameters can be removed from test/test.css.

Another related question is what the simplest workflow for using default parameters or changing them?  It would be nice if the documentation said something like...if you want to customize these parameters then...
Looking at the test there's an obvious answer and that is to include the parameter customizations in index.css.  But what if index.css contains 10 different modules?  One idea would be something like:
Source directory containing source css:
src/main/css/suitcss-utils-size.css
And inside suitcss-utils-size.css:
import  suitcss-utils-size-defaults
import suitcss-utils-size

or
@custom-media --sm-viewport (min-width:0px) and (max-width:40px);
@custom-media --md-viewport (min-width:40px) and (max-width:60px);
@custom-media --lg-viewport (min-width:60px);

import suitcss-utils-size

Hopefully the above customizations would rarely be necessary to hand code, because SUIT could provide or reference default packages containing parameters covering 99% of all use cases.  For example SUIT uses px breakpoints in the test, but @philipwalton uses em units in his flexbox article:
Flexbox Article.
Moving along compile src/main/css/suitcss-utils-size.cssto:
target/css/suitcss-utils-size.css
The css resource target/css/suitcss-utils-size.css would now contain either the customizations or the defaults.
In case the directory structure looks strange it comes from Maven Standard Directory Layout.  The general idea is to have a standard set of directories for source and a corresponding set for compiled individual sources, and then another for minified sources, etc.  This way resources can be inspected at each stage of the build.
Javascript would therefore go in:
src/main/javascript/
Coffeescript:
src/main/coffeescript
Html
src/main/html
And so on...

The idea is that these utils are used as part of your application that already defines these values. If you have a look at the SUIT theme you'll see those values (and any other custom property overrides) being declared - https://github.com/suitcss/theme/blob/master/lib/theme.css#L12-L14
Another example - https://github.com/simonsmith/simonsmith.io/blob/master/source/stylesheets/src/theme.css

It feels a little bit like "Media Query Breakpoint utilities, no batteries included".  I'm assuming that there there has to be a set of breakpoints that are used 99.99% of the time and that we can save users from having to manually specify the breakpoints in these instances?

Also suppose that these breakpoints are considered the defaults:
@custom-media --sm-viewport (min-width:320px) and (max-width:640px);
@custom-media --md-viewport (min-width:640px) and (max-width:960px);
@custom-media --lg-viewport (min-width:960px);

And therefore included as such in tests that perform testing of the utilities that are responsive.  If the breakpoint defaults are changed, then we should probably change them across the tests in order to stay consistent, but in order to do this each test / package has to be updated individually.

I'm assuming that there has to be a set of breakpoints that are used 99.99% of the time

Do you mean like device specific breakpoints? That seems like way too much of a moving target to me to include here.

Perhaps for the tests we could just include the stuff from https://github.com/suitcss/theme instead of sticking in the breakpoints. Easier to do across different repos that way too.

I'm assuming that there has to be a set of breakpoints that are used 99.99% of the time and that we can save users from having to manually specify the breakpoints in these instances

I use a different set in nearly every project, but if users need a set of defaults then installing SUIT via the theme is a viable route, as @timkelty says

@simonsmith can we keep these open until I have had a chance to respond?  I find organizations that encourage the person who originated the ticket to close it much more welcoming.

Fair enough yeah, I've jut been trying to sweep up the dozens of issues that are dotted around.

Cool - thanks for keeping it open.  What I like about SUIT is that each package is much smaller and more modular than other projects built with say LESS or SASS.  Usually the imports make sense and are easy to reason about.  So having a default set of breakpoints that all packages can rely still seems like it makes sense to me.
Also there may be one set of breakpoints that are used 90% of the time, and 4 others that covers the remaining 10%.  There has to be a limit to the sets that make sense, because of the nature of what breakpoints are for, or am I missing something?
Having a process that allows for simple a simple way to plug in packaged breakpoints that work well in described scenarios seems like it should make SUIT more attractive.

Also there may be one set of breakpoints that are used 90% of the time, and 4 others that covers the remaining 10%. There has to be a limit to the sets that make sense, because of the nature of what breakpoints are for, or am I missing something?

I'm not totally sure what you're looking for — Seems like we have the sensible defaults you're looking for already, here: https://github.com/suitcss/theme/blob/master/lib/theme.css#L12-L14
They roughly cover:

phones (sm)
tablets (portrait) (md)
desktop/tablets (landscape) and up

I do think it's a good idea to include the theme in all the tests, rather than duplicating those breakpoints in the test.
As for actual usage in a project, the idea (as I understand it) is you make your own theme (perhaps starting with and editing suitcss-theme). That way you have your breakpoints defined just as they would be in the tests, and you can customize from there.

The size utilities tend to work best with global structure like the grid. Then components are free to use their own break points for tweaking descendant layout.
The danger here is trying to make SUIT some super complicated and configurable framework when I don't think such a use case exists.
Be good to keep it simple.

I love simple!  Reading from the I probably over complicated this with the initial description.  I think we agree that the current set of defaults are sensible across most devices.
I think it should work like this:
Inside theme.css
@import suit-css-breakpoint-defaults
...

Inside utils-size.css:
@import suit-css-breakpoint-defaults
...

This seems like it makes more more sense, because a theme is orthagonal to the sizing utilities?

I'm not sure how this different from the current defaults in theme, you're just giving it a different name?
One thing is you don't need to use the suit theme, just define the break points wherever makes sense.
In my blog I do it like so https://github.com/simonsmith/simonsmith.io/blob/master/source/stylesheets/src/theme.css but this file could be called anything.
As long as the build tools can see it then it'll work.

I'm not sure how this different from the current defaults in theme, you're just giving it a different name?

I think we are very close on this.  I'm separating the defaults from the theme and naming them defaults.  In terms of a dependency structure though, it makes sense for the theme to depend on the defaults, because the theme uses them.  It also makes sense for utils-size to depend on the defaults.  Both packages use the defaults.  If the defaults change, then both packages, and any other packages that use the defaults, get the changes.  The utils-size package does not depend on the remaining content of the theme.css module, so that's the reason that separating the two makes sense.

One thing is you don't need to use the suit theme, just define the break points wherever makes sense.

True, but it's easier and DRYer to do:
@import suit-breakpoint-defaults

Than redefining the contents of suit-breakpoint-defaults everywhere, and having to update the contents of suit-breakpoint-defaults everywhere during refactoring.

In my blog I do it like so https://github.com/simonsmith/simonsmith.io/blob/master/source/stylesheets/src/theme.css but this file could be called anything.

BTW - I like your blog.  Need to read up on it some more.  Good stuff!
Back to the conversation.  So I think we are basically saying the same thing then.  We agree that the defaults should be in a a file and that that file should be used by targets where it makes sense.

We agree that the defaults should be in a a file and that that file should be used by targets where it makes sense.

Yep, but I think my point is that theme.css is already doing this right now. However, I realise that not everyone uses theme when they use SUIT, so where do they define their breakpoints?
It's likely that everyone will have some form of manifest to bring their app together, so that is where the defaults can live.
Example:
index.css
/**
 * SUIT
 */
@import "suitcss-components-grid";
@import "suitcss-utils-layout";
@import "suitcss-utils-size/lib/size-sm";
@import "suitcss-utils-size/lib/size-md";

/**
 * Components
 */
@import "./components/highlight";
@import "./components/icon";
@import "./components/container";
@import "./components/entry";
@import "./components/entry-list";
@import "./components/header";

/** Defaults **/
@custom-media --sm-viewport (min-width: 36.25em);
@custom-media --md-viewport (min-width: 49.375em);
@custom-media --lg-viewport (min-width: 72.1875em);

My point is, nothing in SUIT needs to change to accommodate this flexibility. I'm not sure how using a suit-breakpoints-defaults.css gives you any more help, it just means another layer of abstraction.

Suppose the designer has 15 index.css files that all have this snippet in them:
@custom-media --sm-viewport (min-width: 36.25em);
@custom-media --md-viewport (min-width: 49.375em);
@custom-media --lg-viewport (min-width: 72.1875em);

And suppose that the designer realizes that it should have been:
@custom-media --sm-viewport (min-width: 50em);
@custom-media --md-viewport (min-width: 70em);
@custom-media --lg-viewport (min-width: 100em);

If the breakpoints are defined in their own file, then the designer can just redefine them in one place and be done, instead of doing 15 updates.
As far as SUIT goes I think it's a pretty trivial change.  Any package that uses the defaults would just declare them as a dependency and @import them.

@oleersoy I don't see how separating to suit-breakpoints-defaults.css would solve your example's problem.
In that case you could create your own breakpoints.css with that in it, and @import breakpoints.css in each of your 15 index.css files.
...which is how suitcss-theme works.
Consider the previously mentioned file: https://github.com/simonsmith/simonsmith.io/blob/master/source/stylesheets/src/theme.css
Just include that at the top of each of your css files and you're good.

Creating my own each time is more work than simply declaring it as a dependency.  Also having other SUIT packages depend on a theme package creation ambiguity / indirection.

How does creating my own each time solve the problem?

@oleersoy Your example referred to someone changing the values, in which case you'd have to have them declared your self anyway.
Part of what I like about how it is structured now, is it encourages users to use the theme concept with every build. If your project css starts with "grab a copy of suitcss-theme, edit values as needed, continue on to project-specific css".
You could also achieve exactly what you're describing by doing:
@import suitcss-theme/lib/theme.css

Then you can either redefine any custom-media/props after the import, or scrap the import for your own version.

Yeah, the point of the theme.css is to be bespoke to your project, so the second you need to change it then the included breakpoint-defaults (if it existed) becomes pointless.

Lets assume there are 15 different index.css files in 15 different project repositories.

I feel like that's an extreme case that would never happen, but if it did you just create one global theme file at a top level and import it.

I feel like a guide on "how to use SUITCSS in a project" could mitigate a lot of this.
For example:

Step 1. create a theme for your project. Start with suitcss-theme and customize as needed.
Step 2. @import suit-base, your new theme, any utilities or components you want.
Step 3. profit?

And then of course this process could be built into a Yeoman generator for a quick start.

I like the profit part :+1: .  There's an easy way for us all to win here that does not preclude from any path of development.

Create a separate repository for media query breakpoint defaults / settings
Put the defaults in there

And we are all good.  Sound OK?

Create a separate repository for media query breakpoint defaults / settings

Yeah, I think you can store your project specific settings however you wish, import them and you're done.

Yes but I really would like it to be part of SUIT CSS such that it looks like a set of defaults that are "Best practice defaults".  If we do this and no one ever logs issues against the defaults, then this will have zero impact on your workflow in terms of additional effort or anything else.  The total cost will be a 5 minute setup of the repo.

A theme and breakpoints are two orthagonal concepts.  We do not need to have a theme to create responsive utilities for example.  So if we keep these separate we both get what we are asking for.  We can import the breakpoints into the theme, and we can import the breakpoints into the responsive utilities.

Let's just keep the theme file with the break points. It's doing exactly the same thing and this proposal is just to create another file for the sake of it.

@simonsmith do media query defaults evolve over time?

I think we've discussed this issue past being useful now. I think the general consensus here is that in every project the media query breakpoints used by the utils-size will differ from project to project and therefore adding a default-breakpoints.css would be redundant as the developer would need to change them straight away.
For the cases where people are happy to accept the defaults, well they can just @import "theme.css"
SUIT is designed to accompany your own components and theme files, rather than being the only thing you use. Therefore it is encouraged (and necessary) that users create their own and this makes it simple to setup any custom media defaults and any other overrides that need to be reused across the project.
Any other thoughts @timkelty @giuseppeg @necolas? Otherwise I think we can consider this closed.

So @simonsmith what you are saying is that all projects use different media query breakpoints for medium devices?  Could you please share some of the criteria that you use to select a breakpoint for a medium device?  What are the values you usually go with?

all projects use different media query breakpoints for medium devices?

Impossible to say all, but from experience none that I've worked on have got away with just using what Bootstrap or SUIT provides and just getting on with it. One of the complications of using the default SUIT media queries in theme.css is that they cover a range i.e:
@custom-media --md-viewport (min-width:640px) and (max-width:960px);

Whilst this can be a good starting point I've found sometimes I need to access the min and max separately, requiring me to write something like:
/**
 * Breakpoints
 */
@custom-media --xs-min-viewport (min-width: 400px);
@custom-media --xs-max-viewport (max-width: 599px);

@custom-media --sm-min-viewport (min-width: 600px);
@custom-media --sm-max-viewport (max-width: 769px);

@custom-media --md-min-viewport (min-width: 770px);
@custom-media --md-max-viewport (max-width: 1007px);

@custom-media --lg-min-viewport (min-width: 1008px);

The above sizes are from working on a BBC product where they have already determined the best breakpoints for their expected audience.
When picking sizes yourself I think it's best to stick to what suits the widths of your expected content, rather than picking a phone media query, a tablet media query etc. For example the widths used on my blog were determined by letting the content get as wide as possible before it started to look odd on that device size, then a media query is needed to step in and improve the layout. This divorces the choice from device size (which changes constantly) to content size (which tends to be more predictable).

Design the content to fit on a small screen size first, then expand the screen until a breakpoint becomes necessary. This allows you to optimize breakpoints based on content and maintain the fewest number of breakpoints possible.

https://developers.google.com/web/fundamentals/layouts/rwd-fundamentals/how-to-choose-breakpoints?hl=en
Perhaps the focus of this issue could be, are the SUIT default media queries (in theme.css) ideal, or could they be updated? Do we need more sizes (an xs for example)?

Perhaps the focus of this issue could be, are the SUIT default media queries (in theme.css) ideal, or could they be updated? Do we need more sizes (an xs for example)?

Yes!  Much better :+1: .  I think we're starting to get on the same page here :).  BTW - I'm assuming that they could be updated and that this is a continuous process.
I'm just going to reboot my the terminology.  When I'm referring to a 'default media query breakpoint', what I actually mean is Media Queries for Common Device Breakpoints, which is what @timkelty noted originally.
When looking for recommendations on how to set specify CSS based on device size, or Media Queries for Common Device Breakpoints, there's a lot of variation.  For example SUIT CSS testing and theme defaults look like this:
@custom-media --sm-viewport (min-width:320px) and (max-width:640px);
@custom-media --md-viewport (min-width:640px) and (max-width:960px);
@custom-media --lg-viewport (min-width:960px);

And there are more recommendations here:
media-queries-for-standard-devices and here Media Queries for Common Device Breakpoints.  Which is probably the tip of the mountain.  I've seen other variations with rem units, etc.
So suppose that all I'm interested in is a really simple design scenarios using utils-size responsive utilities to for example resize a grid, like the one in Html5Boilerplate, such that for small devices there's a single column, for medium devices there's 2 columns, and for large devices there's 3 columns in the first row, and one grid cell centered below them in the second row.
Which breakpoint values should I use to generate the utils-size responsive utilities?  So at this stage I might not need the rest of the content in theme.css.  When I think of creating a theme I think of jqueryui themes, and dojo themes, etc.  Things that are really heavy, and are utilized across the entire application / site.  In this case I just want to generate the utils-size responsive utilities using the most lighweight approach possible, while having confidence Media Queries for Common Device Breakpoints I have selected are going to do a good job.  Having:
/* Main colors */
:root {
  --color-blue:       #0071ac;
  --color-light-blue: #0d85c1;
  --color-pink:       #ac6cae;
}

/**
 * Fonts
 */
:root {
  --font-family: "Open Sans", "Helvetica Neue", Helvetica, Arial, sans-serif;
}

Also included, when all I need are a well tested set of device specific breakpoints, could introduce problems.  Again I understand that this could be a great starting point 80% of the time, but I think it would be nice if the 20% that we need something more lightweight SUIT provides the isolated set of breakpoints and minimizes the effort involved in the corresponding workflow for their utilization over the life cycle of the product.
Having a repository that contains peer / community Media Queries for Common Device Breakpoints would be a valuable resource when performing simple responsive designs.  If it adds other breakpoints that are commonly utilized in specific well defined scenarios that are a good fit for SUIT CSS components and utilities, even better.
WDYT?

I think the general consensus here is that in every project the media query breakpoints used by the utils-size will differ from project to project and therefore adding a default-breakpoints.css would be redundant as the developer would need to change them straight away.
I agree.
In general SUIT CSS is a methodology rather than a framework ala Bootstrap so in my opinion providing ready to use CSS packages is outside of the scope of this org.
Anybody is free to create and publish to npm a suitcss-"Media Queries for Common Device Breakpoints" package and we can mention it in the docs.
By the way suitcss/theme is just an example theme.

Which breakpoint values should I use to generate the utils-size responsive utilities?

I think this a good question but not for SUIT to answer. As @giuseppeg says, SUIT is more a methodology than framework. I think selecting the breakpoints should remain a decision of the developer, not SUIT.

Not to confuse the issue more, but — if we decide to use some sort of dynamic generation of classes (https://github.com/suitcss/utils-size/issues/28), the question of classes and breakpoints are included could be moot. Then you could add xs, xxs, xl, etc...at whatever breakpoints you wanted.
Furthermore, targeting specific devices with media queries is probably the wrong approach, and shouldn't be SUIT's job. Your breakpoints ideally are determined by where you content shifts naturally, as @simonsmith mentioned.
@oleersoy if you really did want to target a device, I'd simply suggest doing this, and importing this at the top of all your project's files:
@import 'suitcss-utils-size`;

// Galaxy S5
@custom-media --sm-viewport (only screen and (min-device-width: 360px) and (max-device-height: 640px) and (orientation : landscape) and (-webkit-device-pixel-ratio: 3));

Perhaps what is confusing is that utils/components have their custom-properties pre-defined in the project, but not their custom-media.
Presumably this is because if you don't have a particular custom-media defined, the whole block will get removed when processing.

I think just adding a note to the README about needing to define @custom-media somewhere is all that is required to close this issue.

@simonsmith issues usually close themselves naturally  once all the parties draw conclusions that's in the best interest of the project.  Allowing it to work itself out is what is going to achieve the best result.

In general SUIT CSS is a methodology rather than a framework ala Bootstrap so in my opinion providing ready to use CSS packages is outside of the scope of this org.

Anybody is free to create and publish to npm a suitcss-"Media Queries for Common Device Breakpoints" package and we can mention it in the docs.

That's basically all I'm asking for.  For the "Media Queries for Common Device Breakpoints" to be used as the test defaults and recommended defaults for common devices.  Also as I have noted this is different from Possibly the Wrong Approach.

Perhaps what is confusing is that utils/components have their custom-properties pre-defined in the project, but not their custom-media.

SUIT seems to be following a pattern of providing custom defaults when it makes sense.  I think developers like this.  If the project can make it simpler for them, we will get more love back.
There are scenarios where the developer knows that they do need device specific breakpoints, and this accommodates that scenario.  All this would do is allow the capture of instances where the breakpoints are not doing a good job of detecting the a device.
Since SUIT has already gone down the road of providing responsive utilities, it does not hurt to provide a solid standard starting point for those utilities.

Presumably this is because if you don't have a particular custom-media defined, the whole block will get removed when processing.

That's another thing that can be better explained.  If not breakpoints are provided, then a generic set of non responsive utilities are built.  Like @simonsmith says, we can add a note in the README explaining this better.
I think that if the README says something like:
==========================================
To generate a set of utilities targeting specific device sizes, do the following:
@import suit-device-specifc-media-query-breakpoints
@import utils-size

Note that rather than targeting devices specifically, it may be better to follow the approach advocated by Possibly the Wrong Approach.
===========================================
At least now both options are covered cleanly.

Not to confuse the issue more, but — if we decide to use some sort of dynamic generation of classes (#28), the question of classes and breakpoints are included could be moot. Then you could add xs, xxs, xl, etc...at whatever breakpoints you wanted.

I think this would be a really good thing.  We basically need it in order to generate the source-order flex box utilities anyways.  It would also provide a much more powerful device detection capabilities for those that need it.
@timkelty since SUIT enables the generation of responsive utilities, it would be great if it had a good set of defaults, and showed how to build using those defaults, in order to minimize the workflow for developers that do need to target specific devices.
At a minimum this makes SUIT more consistent across packages and allows it to provide a more comprehensive solution.  It would also hopefully encourage feedback in the event that some of the device specific breakpoints are off.

issues usually close themselves naturally once all the parties draw conclusions that's in the best interest of the project. Allowing it to work itself out is what is going to achieve the best result.

From what I can tell from reading this issue all the parties except yourself disagree with the idea of providing media query defaults in here, that feels like the issue is resolving itself. We can't just add every feature that one single person requires.
I'm still not convinced there is a use case for these additions beyond a note in the README. Having worked with SUIT amongst several developers not one has raised any issue with needing default breakpoints. It's trivial and encouraged to handle this yourself.
Why can't the README just say this?
@custom-media --sm-viewport (min-width:320px) and (max-width:640px);
@custom-media --md-viewport (min-width:640px) and (max-width:960px);
@custom-media --lg-viewport (min-width:960px);
@import utils-size

Identical outcome for no extra complexity.
I think we're all opposed to the idea of SUIT trying to be Bootstrap, and this feels like a feature that I don't see any need for other for your use @oleersoy.
Maybe if you're using it in a project where this is needed you could fork it, add it and see what the feedback is amongst the other developers you work with. Otherwise I think we can all agree this issue has been discussed beyond usefulness and is best closed as a wontfix

Certainly not trying to shut your issue down, @oleersoy but I'm on the same page as @simonsmith.
It sounds like you're asking the SUIT repo(s) to maintain a list of custom-media definitions for devices, along these lines.

It would also hopefully encourage feedback in the event that some of the device specific breakpoints are off.

I think that's precisely what we don't want to deal with; a canonical list of ever-changing device breakpoints.
While there are certainly some use-cases for targeting devices in such a way, it seems to be the consensus of others in this thread that SUIT isn't the right place to manage this.
That said, if it is something you're really looking for, why not just publish yourself a repo with those queries defined as custom-media definitions and import it into your files?
I think you're definitely right about README and startup examples needing to be better. I think as we migrate to a monorepo this will become easier.

OK Fair enough.  You are right that it could easily be managed outside of SUIT.  I do think that that SUITs unwillingness to provide end to end examples and content is one of the reasons it does not have much of a pulse ATM even though the underlying concepts are brilliant.  Anyways it sounds like we are ready to wrap this up, so I'll close the issue.  Thank you all for participating.

Yep - more examples and startup docs for sure.

BTW - @simonsmith  - thanks for mentioning Bootstrap.  I think this is precisely what I'm looking for:
Bootstrap Responsive Utilities


Game crashes if viewing a pickaxe with both fortune and silk touch and silk touch is turned off

As stated in the title, if silky touch is off and I view the pickaxe, the game crashes. Link to crash report: https://paste.ubuntu.com/p/DPGsrC9mGV/plain/. I don't have to many mods, they may be slightly clashing, and I am horrible at troubleshooting, and this is all I could find.

i install the mods and i see you have "no-enchant-cap-1.18.1-fabric-2.1.1" in the 1.19 version of minecraft fabric

thank you so much, I just updated the mod to the 1.19 version


Property and history cleanup merged with master

Add back missing STOP JVM functionality

Created another pull request since the branch this one was based on seemed problematic due additional commit "	f8c2bcf" which should not be there. Please see pull request #82


Make Chromatic action run on forked PR

Chromatic doesn't run on forked PR, e.g. https://github.com/jpmorganchase/uitk/pull/247. Chromatic doc suggests to move the token to project.

Maybe we can use something like this: https://github.com/chromaui/chromatic-cli/issues/196#issuecomment-1114337113


⚠ LPDM Handbook (hosted on Divio) has degraded performance

In 347d950, LPDM Handbook (hosted on Divio) (https://repohubdev.tk) experienced degraded performance:

HTTP code: 500
Response time: 6501 ms

Resolved: LPDM Handbook (hosted on Divio) performance has improved in c37d747.


Some values return null when exporting

Hello, I really like this package and was wondering if I am exporting correctly, because I keep getting null values on some properties. Am I supposed to add a parser before I export or is exporting using DynamicWidgetJsonExportor the best way? And also some properties are not being caught, such as decoration, which I need to provide a background in the container.
Widget:
Container(
                height: 200,
                margin: EdgeInsets.symmetric(horizontal: 15.0),
                decoration: BoxDecoration(
                  borderRadius: BorderRadius.all(Radius.circular(20.0)),
                  image: DecorationImage(
                    image: AssetImage('assets/weather/clear-day/bg.jpg'),
                    colorFilter: ColorFilter.mode(
                        Colors.black.withOpacity(0.75), BlendMode.dstATop),
                    fit: BoxFit.cover,
                  ),
                ),
                child: Stack(
                  children: [
                    Align(
                      alignment: Alignment.topLeft,
                      child: IconButton(
                        onPressed: () => debugPrint('testing'),
                        icon: Icon(Icons.ac_unit),
                      ),
                    ),
                    Align(
                      alignment: Alignment.topRight,
                      child: IconButton(
                        onPressed: () => debugPrint('testing2'),
                        icon: Icon(Icons.access_alarm),
                      ),
                    ),
                  ],
                ),)

exported Json from widget above:
{
    "type": "Container",
    "alignment": null,
    "padding": null,
    "color": null,
    "margin": "15.0,0.0,15.0,0.0",
    "constraints": {
        "minWidth": 0.0,
        "maxWidth":<PHONE_NUMBER>.0,
        "minHeight": 200.0,
        "maxHeight": 200.0
    },
    "child": {
        "type": "Stack",
        "alignment": "topStart",
        "textDirection": "ltr",
        "fit": "loose",
        "clipBehavior": "hardEdge",
        "children": [
            {
                "type": "Align",
                "alignment": "topLeft",
                "widthFactor": null,
                "heightFactor": null,
                "child": null
            },
            {
                "type": "Align",
                "alignment": "topRight",
                "widthFactor": null,
                "heightFactor": null,
                "child": null
            }
        ]
    }
}

As you can see, decoration is not being exported, and also my iconbuttons in the stack are all null. Any reason for this?

decoration property is not exported, and "null" is the default value for alignment


feat(parser): recover from const used as a BindingIdentifier

#6478  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on  Graphite


Any Erlang code using integer_to_binary/2 fails to link against a derived trait method in radix_fmt

Any Erlang code using integer_to_binary/2 fails to link against a derived trait method in radix_fmt:
Undefined symbols for architecture x86_64 _$LT$radix_fmt..Radix$LT$isize$GT$$u20$as$u20$core..fmt..Display$GT$::fmt::h9d7627ed4ffb494b

init.erl
-module(init).
-export([start/0]).
-import(erlang, [binary_to_integer/2, display/1, integer_to_binary/2]).

start() ->
  duals().

duals() ->
  duals(2, 36).

duals(MaxBase, MaxBase) ->
  dual(MaxBase);
duals(Base, MaxBase) ->
  dual(Base),
  duals(Base + 1, MaxBase).

dual(Base) ->
  display(36 == binary_to_integer(integer_to_binary(36, Base), Base)).

I'm not sure why it says _$LT$radix_fmt..Radix$LT$isize$GT$$u20$as$u20$core..fmt..Display$GT$::fmt::h9d7627ed4ffb494b because that's not a proper mangled Rust symbol name.  Mangled Rust symbol names start with _ZN<NumberOfCharacters>.  The proper format is __ZN68_$LT$radix_fmt..Radix$LT$isize$GT$$u20$as$u20$core..fmt..Display$GT$3fmt17h9d7627ed4ffb494bE, which demangles to _<radix_fmt::Radix<isize> as core::fmt::Display>::fmt

@2huBrulee

Closing this because it is almost certainly not an issue anymore, as much has changed since this was initially reported, but if it comes up again we can reopen


Cluster discovery using ECS/K8s

Environment

VerneMQ Version: docker-vernemq:latest
OS: Docker
Erlang/OTP version (if building from source): N/A
VerneMQ configuration (vernemq.conf) or the changes from the default:
Cluster size/standalone: Auto-scaling cluster with at least 2 nodes

Desired behavior
I am trying to set up an auto-scaling VerneMQ cluster with AWS ECS. I have created a single Task Definition (Similar to a K8s Pod) for setup of single VerneMQ Docker container with environment variables for right configuration).
I am trying to launch multiple replicas /copies of this Task and have them cluster up automatically.
However, I am having problems because the IP address of the Task container is not known beforehand and not fixed either. In order to overcome that problem I tried to use different ways of service discovery, but it seems to me that service discovery is more used for service-to-service communication instead of container-to-container-in-same-service communication.
I tried to figure out how this is described in the Kubernetes documentation of VerneMQ but I couldn't figure out how it its done. Sidenote: I prefer not to use K8s, but I see it as backup option in case ECS would not work out.
Basically the issue is similar to #51 and #150, but the posts are from ~4/5 years ago.
I would be curious to see what is the current status, and to know what I am currently missing.

Hello @MichelJansen91, Have you tried using rout53 service discovery in aws as per @dergraf  suggested in this here
What issues did you face in that?

Thank you for your reply.
Yes I have tried using the route53 service discovery, but the services were unable to find each other if I tried to fill in the local DNS address as DOCKER_VERNEMQ_DISCOVERY_NODE. I still have to investigate it a little more ( something seemed a bit off with security policies), but also I kind of realized that Kubernetes is quite inevitable for our current setup.
I will try to find some time to work on this

I am currently using the Kubernetes Helm Chart, and that one just works off the shelf. My feeling is that it could also be done with ECS Service as well, but will require a lot of manual configuration compared to the Helm chart. Since I am using Kubernetes now, I will not investigate the ECS issue any further so I am closing the issue.


question: number of streamlines in tckgen

Hi, thanks very much for providing this bids-app.
1)Is there a rationale regarding the rather specific definition of n streamlines:
num_streamlines = 500 * num_nodes * (num_nodes-1) (cf. line 2618 in mrtrix3_connectome.py)?
2)I remember the nice poster "Investigating the streamline count required for reproducible structural connectome construction across a range of brain parcellation resolutions" from Chun-Hung, demonstrating a minimum of ca. 20M streamlines for e.g. a 85 nodes parcellation to achieve reproducible structural connectomes and reduce variation. That number doesn't seem to be related here or did I miscalculate?
Best, Lucius

Is there a rationale regarding the rather specific definition of n streamlines:

Not massively. It results in the mean number of streamlines per connectome edge being 1000. There's some limited logic in the quadratic scaling of number of streamlines as a function of number of edges, but the magnitude is somewhat arbitrary.

Chun-Hung, demonstrating a minimum of ca. 20M streamlines for e.g. a 85 nodes parcellation

So there's two outstanding limitations here. Firstly, that work was interested specifically in the numbers required to achieve stability in individual edge weights, which is a specific experimental outcome for which the precision is assessed; if one is interested in alternative experimental outcomes (eg. graph metrics), the required numbers will likely vary. Secondly, there is a somewhat arbitrary thresholding necessary to place on the precision in order to draw a line at a fixed number of streamlines for a given parcellation; one can change that threshold and get a different number, and there's no obvious standout candidate.
Personally I prefer bigger numbers, but there's an additional concern in that if the default is too large (which is exacerbated by other parameters here resulting in the computational time per streamline being longer than usual) people may hit Ctrl-C and go use something else. You can of course always just override with the --streamlines option.
Cheers
Rob


Modal Behind Header

Environment
Expo SDK 37.0.0
Platforms
Expo both Android/iOS
Versions

Android: 10
iOS: 13.5
react-native-modal:11.5.5
react-native:0.62
react:16.9.0

Description
Modal is appearing over the header. I want modal to be behind the header. I am using native base I tried elevation & zIndex style properties on both modal and header but it is not working.
Is zIndex supported with modal. I just want it to appear behind of Header
Reproducible Demo

Same issue here,
it appears when "coverScreen" = false and an Animated View has zIndex or elevation

Please follow the issue template, thanks! :)

I have the same issue
if you reached to any solution , share it please


bug(engine): stack-overflow

I cannot run the last version of kics (v1.7.11)
The error is the following one:
fatal error: stack overflow

runtime stack:
runtime.throw({0x224a045?, 0x200000008?})
	/usr/local/go/src/runtime/panic.go:1077 +0x40 fp=0x4007895e00 sp=0x4007895dd0 pc=0x4a830
runtime.newstack()
	/usr/local/go/src/runtime/stack.go:1107 +0x458 fp=0x4007895fb0 sp=0x4007895e00 pc=0x65e38
runtime.morestack()
	/usr/local/go/src/runtime/asm_arm64.s:316 +0x70 fp=0x4007895fb0 sp=0x4007895fb0 pc=0x7d920

	...

Steps to Reproduce the Problem
Just download the new version and run as example:
docker run --rm -t -v "$PWD:/path" checkmarx/kics:latest scan -p /path -o /path --report-formats "json" --output-name ./kics-result
It happens the same if you try to build it by source instead of docker.
I am using a MAC. Go version: go1.21.4 darwin/arm64
logs_error.txt

Hi @tcosta-travelperk ,
Thanks for your inputs. We will check it and update you asap.

@tcosta-travelperk does the same issue occurs if you use checkmarx/kics:v1.7.10?

Hey @gabriel-cx thank you very much for your fast reply.  The issue just happens with the new update: checkmarx/kics:v1.7.11. I can run the previous checkmarx/kics:v1.7.10 without any problem.

Hey @tcosta-travelperk, I was checking this bug opened by you. Did you run exactly the same project (without any change) when you tested with version 1.7.10?

Hey @JoaoCxMartins , it was exactly on the same repo, yes.
I have just tested both versions and seems that now both are working and are not raising an error. My question now is if it is expected that the number of issues found with the new version has decreased a lot.
For example:
High issue: 166 in the new version, 619 in the previous version.
Thanks in advance

Hey @tcosta-travelperk.
I'm glad that now both versions are working.
About the results that you lost, these results were detected as Ansible?

Hey @JoaoCxMartins ,
I have just quickly compared both results. Seems that the missing results are related to common (secrets) and Cloudformation.
On this repo there is Ansible, so I could not check those.
Thanks :)

Hey @tcosta-travelperk
Sorry, but I need one last check :)
On version 1.7.10 the Ansible queries were trigged?
Let me explain why I asking this, from version 1.7.10 to version 1.7.11, we made an improvement in our detection of Ansible files, in older versions for default a Yaml file for us was Ansible (when not a GDM) but now we have improved our detection that make we discard files when these ones are not Ansible
You could check here, https://github.com/Checkmarx/kics/pull/6773
If you test with the previous version, let me now :)

Hey @JoaoCxMartins on version 1.7.10 the Ansible queries were triggered, whereas in the 1.7.11 didn't.

Or these files were really Ansible files?

Hey @JoaoCxMartins , I have not triaged all the vulnerabilities for this repo because there are a lot of them. I hope you can understand that this is the next step.
I am not sure if those are false positives or not. Although the scan for Ansible is not done on the newer version, on the previous one there were no findings related to this platform.
As said previously, the ones that have been deleted are related to a common platform, which are secrets.

Hey @tcosta-travelperk , from what you are saying, I have one conclusion, your project should have a bunch of Yaml files that the previous kics version was detecting as IAC (Ansible) files. The Ansible queries were running and returning zero results, but the common query is a bunch of regex detecting results, for me false positives because these files were signalized as IAS when they weren't.
What do you think? Is this clarification valid for your context?

Hey @JoaoCxMartins , that might be the case although I am not 100% sure. Anyway, we could close the issue here.
Initially, this was just for not being able to run properly kics. In case I find something interesting to share, I will open a new one.
Thank you very much for your support. I appreciate it!


How to set the global timeoutInterval with a single line of code? I think waiting for 60 seconds is too long for most people

As with URLSession, timeouts can be set in the URLSessionConfiguration you use pass to Session, or by setting the appropriate properties on the URLRequests you create.


Vulkan examples regression: descriptor indexing and oit

I have been working on updating macOS and iOS support and fixing a few defects that I found in Sascha Willems' Vulkan examples repository.  See https://github.com/SaschaWillems/Vulkan/pull/1117 and https://github.com/SaschaWillems/Vulkan/pull/1119.  During this work I observed two examples that expose what appear to regressions across MoltenVK releases:
• The descriptorindexing example runs well on Vulkan SDK <IP_ADDRESS>/MoltenVK 1.2.4, but fails on any later release with:
[mvk-error] SPIR-V to MSL conversion error: Argument buffer resource base type could not be determined. When padding argument buffer elements, all descriptor set resources must be supplied with a base type by the app.
[mvk-error] VK_ERROR_INVALID_SHADER_NV: Fragment shader function could not be compiled into pipeline. See previous logged error.
Fatal : VkResult is "ERROR_INVALID_SHADER_NV" in /Users/steve/XcodeProjects/Vulkan/examples/descriptorindexing/descriptorindexing.cpp at line 346
Assertion failed: (res == VK_SUCCESS), function preparePipelines, file descriptorindexing.cpp, line 346.

• The oit example runs well up to SDK 1.3.275.0/MoltenVK 1.2.7, but fails on the current release (1.3.280.0/1):
-[MTLTextureDescriptorInternal validateWithDevice:]:1344: failed assertion `Texture Descriptor Validation
MTLTextureUsage has unknown bits 0x20.

The first of these may be a duplicate of #2180, but I just wanted to report them here to make sure the MoltenVK team is aware.

After a bit of debugging, I believe the first one is a SPIRVCross defect.  I patched in the old SPIRVCross (from MoltenVK 1.2.4) at commit 12542fc6fc05000e04742daf93892a0b10edbe80 to the most recent head of MoltenVK 1.2.9.  I had to comment out a few newer msl options, but this did not seem to affect things for the descriptorindexing example.  I now have a working example with this mashup.
I have not done any research on the second issue above (oit example).

Issue one (descriptorindexing) reported with additional data at the existing https://github.com/KhronosGroup/SPIRV-Cross/issues/2198
Issue two (oit) still not understood.

The oit example runs well up to SDK 1.3.275.0/MoltenVK 1.2.7, but fails on the current release (1.3.280.0/1):
-[MTLTextureDescriptorInternal validateWithDevice:]:1344: failed assertion `Texture Descriptor Validation
MTLTextureUsage has unknown bits 0x20.

What OS?

OS is Ventura 13.6.6 (on x86) with Xcode 15.2.  GPU is AMD Radeon 6600 (Metal Tier 2).

OS is Ventura 13.6.6 (on x86) with Xcode 15.2. GPU is AMD Radeon 6600 (Metal Tier 2).

The bit 0x20 is MTLTextureUsageShaderAtomic, which wasn't introduced until Sonoma. We shouldn't be using that bit prior to Sonoma.

The descriptorindexing example runs well on Vulkan SDK <IP_ADDRESS>/MoltenVK 1.2.4, but fails on any later release... /clip/ ...The first of these may be a duplicate of https://github.com/KhronosGroup/MoltenVK/issues/2180, but I just wanted to report them here to make sure the MoltenVK team is aware.

Thanks for submitting this as an issue affecting a known sample app! It made it much easier to track down!
PR #2231 fixes this part of this issue.

OS is Ventura 13.6.6 (on x86) with Xcode 15.2. GPU is AMD Radeon 6600 (Metal Tier 2).

The bit 0x20 is MTLTextureUsageShaderAtomic, which wasn't introduced until Sonoma. We shouldn't be using that bit prior to Sonoma.

@SRSaunders Can you try changing:
https://github.com/KhronosGroup/MoltenVK/blob/1abae612ae940f69b82a5e67bec3a76a811f57a7/MoltenVK/MoltenVK/GPUObjects/MVKImage.mm#L1084
to include , _shouldSupportAtomics && getPhysicalDevice()->useNativeTextureAtomics()); (and maybe put a couple of line-returns as needed to make the line not so far off to the right), and then retest, please?

Fantastic!  Both issues are solved for me now.
For issue one (arg buffer padding), I checked out https://github.com/KhronosGroup/SPIRV-Cross/commit/e41d79fe8fae3b950253e4da6527c34bc93b13dd and rebuilt the External Dependencies project, followed by the MoltenVK project.  The descriptorindexing example is now working fine.
For issue two (MTLTextureUsageShaderAtomic), I added your additional code and rebuilt MoltenVK.  The oit example is now working again.
Thanks for jumping on these and solving so quickly.

For issue two (MTLTextureUsageShaderAtomic), I added your additional code and rebuilt MoltenVK. The oit example is now working again.

Wonderful! I'll make that simple change here and run CTS to see if it breaks anything, then I'll issue a PR.

For issue two (MTLTextureUsageShaderAtomic), I added your additional code and rebuilt MoltenVK. The oit example is now working again.

Wonderful! Thanks for testing.
I'll make that simple change here and run CTS to see if it breaks anything, then I'll issue a PR.

PR #2231 now also fixes this part of this issue.

I have now tested against the new merged PR and the Vulkan examples work well.  Thanks again.
Closing issue.