Task didn't work in h5

Hello:
i'm got 4 errors when i'm run the code
first error is ' Task is not yet completed '
and the others errors  is ' Task is already completed '
code here :
namespace System.Net.Http
{
    public class HttpClient
    {
        private static uint timeout = 100000;
        public static uint Timeout { get { return timeout; }
            set {
                if (value >= uint.MaxValue)
                {
                    timeout = uint.MaxValue ;
                }
                else
                {
                    timeout = value;
                }
            }
        }

        public static async Task<XMLHttpRequest> GetAsync(string requestUri)
        {
            var tcs = new TaskCompletionSource<XMLHttpRequest>();

             XMLHttpRequest xmlHttp = new XMLHttpRequest();
            xmlHttp.timeout = Timeout;
            xmlHttp.open("GET", requestUri);

            xmlHttp.onreadystatechange = async (e) =>
            {
                if(xmlHttp.status == 200)
                {
                    tcs.SetResult(xmlHttp);
                }
                else
                {
                    tcs.SetException(new Exception("Response status code does not indicate success: " + xmlHttp.statusText));
                }
            };
            xmlHttp.send();
            return await tcs.Task;

        }
    }
}

uint is not CLS-compliant, a check itself does not make any sense (if internal represnation of uint can be greater than uint it is problem of uint and not property of HttpClient), that API is not standard - HttpClient in .Net has Timeout instance (TimeSpan) property.
But as I said whole code looks strange. It does not look like correct async programming. Though I am not involved a lot into your code.
But if I need to return Task<XMLHttpRequest> then I can simply can do the following:
XMLHttpRequest request = new XMLHttpRequest();

return Task.FromResult(request);

or await Task.FromResult(...) if it is async method...
So, it is only my opinion, but H5 should not be a playing place or place for school labs.
To be better than original Bridge.NET implementation it needs robust professional code.

@theolivenbaum ok thanks i well try

@hardhub as i tell you before i'm I didn't focus on my code very well because the task didn't work so i change the code a lot like more than 5 times to make it work but it doesn't , this implementation It's not official yet and it's just a experimental for my self ...just from the first half an hour, problems began to appear......And you expect me to write clean code because I spent the whole day looking for a solution to the problem .... It is better for you not to focus on the unimportant aspects, it is better to focus on the main problem (Task).. You should not mock of the other person In directly or indirectly, and to judge a person just because of a simple mistake and start with empty talk because you do not know what is in his day and the problems in his life. So You should learn to say good or keep quiet.

No, I should not. When I expect the problems I must to say about my doubts (you can agree or not - it is another question).
Even more you should not tell me what I should do. As well as you are free to do what you want (and of course it does not mean that I will automatically agree with the result).

I have probably repeat what I mentioned... I did not pass any limits. I just said that your attempt to write bridge version of HttpClient looks as some playing with code. So yes like a lab... And it is what I personally do not like to see in repo. In the past Bridge was a victim of tons of bugs. So I mentioned only that nothing else. If anybody else try to introduce some code which in theory breaks cross-compilation my reaction will be the same (I have tons of #if BRIDGE directives in code and of course I do not like that). So never mind, nothing personal...

ok i will repeat my talk .....i told you before i well implement httpClint ...but this code just trying to write task ...nothing public or real implement...just few lines to test (i mean this code is for test Task if task work than i will do the standard in corert like timespan ....etc ). you can be helpful like theolivenbaum he know what i want and solve the problem ....i dont like to complete this message ....so i will leave this conversation don't reply ok👍


Better workflow for flaskr and other basic apps

adds from flaskr import app to top-level in flaskr module
effect is that export FLASK_APP=flaskr works over the more verbose
export FLASK_APP=flaskr.flask
see the readme for how to run
all tests are passing with py.test or python setup.py test (in
venv)

This change is

Thanks!

No problem.


Not working with php

This is exactly the type of solution I was looking for. Unfortunately it does not seem to be processing php. I created a simple test.html file in the user/minicodes folder with this content:
<html>
        <?php
        $output = "Hello World" ;
        echo "<pre>$output</pre>";
        ?>
</html>

And then added a {{ 'test.html' | minicode }} twig-tag to a page. I get the following output:

$output"; ?>

chellige, thanks for your report.
This plugin can Raw output from file only. Can not compile php code.
When you process the php in a php, security also has many problems, php that contains the error do not know what causes what.
It is assumed that such use in content.
ex)
Lorem Ipsum is simply dummy text  {{ 'test.html' | minicode }} Lorem Ipsum has been the industry's

In test.html
<span> This is AD </span>
After
Lorem Ipsum is simply dummy text <span> This is AD </span> Lorem Ipsum has been the industry's


Move from _core run.sh code specific to Docker

Take "docker related" code from run.sh. There's no code currently per say BUT there's a comment :)
We need to create a function named ... validateEnvVars() ? that validates the environment variables provided by the end user via Docker env vars.
Then add the generic product's function named productInit() and inside that function, the code needs to call validateEnvVars()
Fatal errors must use fatal and exit.
In _core there's code being added to source../libproduct.sh (if available).

Whenever possible, need to also move the following:
export HA_BACKEND_DISABLE=${HA_BACKEND_DISABLE:=false}

I think this is done, I will close


Question | How to attach a python debugger when developing colcon

I'd like work on extending colcon_package_selection package, but I can't figure out how to attach a python debugger to the breakpoint I'd like to inspect when working inside a colcon workspace in itself. So far I've bootstrapped a workspace as per:
https://colcon.readthedocs.io/en/released/developer/bootstrap.html
Then I open colcon-from-source/src/colcon_package_selection in VS Code with the python extension installed from the same terminal with the venv activated and install/local_setup.bash sourced, so that vscode pickup on the venv environment. Following this guid I set up the .vscode/launch.json for setting the debugger:
https://code.visualstudio.com/docs/python/debugging
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: colcon dev",
            "type": "python",
            "request": "launch",
            "cwd": "~/ws/navigation2/overlay_ws",
            "program": "${workspaceFolder}/../colcon-core/bin/colcon",
            "args": [
                "list",
                "--packages-select-build-failed"
            ],
        },
    ]
}

However, I can't get the rest of the extensions to load, like list for example:
$ cd ~/ws/navigation2/overlay_ws ; env PYTHONIOENCODING=UTF-8 PYTHONUNBUFFERED=1 /home/ubuntu/ws/colcon-venv/bin/python /home/ubuntu/.vscode/extensions/ms-python.python-2019.8.30787/pythonFiles/ptvsd_launcher.py --default --client --host localhost --port 35017 /home/ubuntu/ws/colcon-from-source/src/colcon-package-selection/../colcon-core/bin/colcon list --packages-select-build-failed
usage: /home/ubuntu/ws/colcon-from-source/src/colcon-package-selection/../colcon-core/bin/colcon
       [-h] [--log-base LOG_BASE] [--log-level LOG_LEVEL] {build,test} ...
/home/ubuntu/ws/colcon-from-source/src/colcon-package-selection/../colcon-core/bin/colcon: error: argument verb_name: invalid choice: 'list' (choose from 'build', 'test')

I tried changing the python executable to ensure that the workspace is sourced for ptvsd_launcher.py:
            "name": "Python: colcon dev",
+            "linux": {
+                "pythonPath": "/home/ubuntu/ws/colcon-from-source/ws_python"
+            },

#!/bin/bash
# ws_python

source ~/ws/colcon-venv/bin/activate
source ~/ws/colcon-from-source/install/local_setup.bash
python "$@"

But that didn't fix anything. If I try --symlink-installing and point to the install folder instead:
            "name": "Python: colcon dev",
-            "program": "${workspaceFolder}/../colcon-core/bin/colcon",
+            "program": "${workspaceFolder}/../../install/colcon-core/bin/colcon",

Then I still have some issues with the load_entry_point after list command prints to stdout:
Exception has occurred: SystemExit
  File "/home/ubuntu/ws/colcon-from-source/install/colcon-core/bin/colcon", line 11, in <module>
    load_entry_point('colcon-core', 'console_scripts', 'colcon')()

However, I can't get the rest of the extensions to load

If you only invoke the bootstrap script of colcon (colcon-core/bin/colcon) you will only get the extensions which are part of colcon-core.
After you have bootstrapped your colcon workspace you should source the environment as mentioned in the instructions:

. install/local_setup.bash

And from then on you should invoke the colcon executable which is on your PATH instead of the bootstrap script above.
If you want to invoke this in your development environment you have to make sure it has the same environment setup as after sourcing the setup file (either by manually configuring it or by opening your editor / IDE in a terminal which has the environment already setup.

Ok, so I got the debugger working by tweaking the .vscode/launch.json so the script to setup the environment is correctly used as the interpreter for running ptvsd_launcher.py via pythonPath:
{
    "version": "0.2.0",
    "configurations": [

        {
            "name": "Python: colcon2",
+            "linux": {
+                "pythonPath": "${workspaceFolder}/../../ws_python"
+            },
            "type": "python",
            "request": "launch",
            "cwd": "/home/ubuntu/ws/navigation2/overlay_ws",
            "program": "${workspaceFolder}/../../install/colcon-core/bin/colcon",
            "args": [
                "list",
                "--packages-select-build-failed",
            ],
        },
    ]
}

#!/bin/bash
# ws_python

source ~/ws/colcon-venv/bin/activate
source ~/ws/colcon-from-source/install/local_setup.bash
python "$@"

The debugger now expands to running this in new console:
$ /home/ubuntu/ws/colcon-from-source/src/colcon-package-selection/../../ws_python \
/home/ubuntu/.vscode-server/extensions/ms-python.python-2019.8.30787/pythonFiles/ptvsd_launcher.py \
  --default --client --host localhost --port 43859 \
  /home/ubuntu/ws/colcon-from-source/src/colcon-package-selection/../../install/colcon-core/bin/colcon \
    list \
      --packages-select-build-failed

Hey there, this is great info. Is there any way this could be folded into some documentation?


State data of connections with MQTT CleanSession flag set to 1 must not be reused

If a client connects with CleanSession set to 1, the session should not be stored after the client disconnects.
However, in EnMasse if the client connects again with CleanSession set to 0, it still receives all messages sent since the last disconnect.
According to the MQTT specification, this should not be the case (see section <IP_ADDRESS> of the MQTT specification).

@jsticha can you confirm the version of EnMasse that you are using?

Hi @k-wall, I am using version 0.21.0 of EnMasse in standard address space.
I noticed this behavior with a sharded topic (currently MQTT only supports sharded topics, as reported here: https://github.com/EnMasseProject/enmasse/issues/1221).

@jsticha - there is some work landed on master (https://github.com/EnMasseProject/enmasse/pull/1514)  that should resolve the issue that you report.
This change is a tactical fix to the POC MQTT implementation.  It won't work if the MQTT gateway is scaled beyond a single instance.  There needs to be a deeper rework of the MQTT layer.  This work will be planned at a later date.  Any feedback on your experiences or suitability for your use-cases will be appreciated.


What is the reason of having two tags for 2.2.0 version of a library?

When running composer update we've got an error related to conflict of knplabs/knp-menu and twig. But version constraints for these packages in composer haven't changed for a long time and it worked before.
I guess it's related to the fact that there is a new tag https://github.com/KnpLabs/KnpMenu/releases/tag/v2.2.0 tagged this on Sep 2.
However there also https://github.com/KnpLabs/KnpMenu/releases/tag/2.2.0 released this on Sep 22, 2016.
So probably before we used an old tag without error as composer.json hadn't defined the conflict with twig.
Could you explain is it an error or done intentionally and how should we work with that.
Thank you.

v2.2.0 was a mistake. Is deleted now

Looks like tag v2.2.0 still exists https://github.com/KnpLabs/KnpMenu/releases/tag/v2.2.0
and that mistaken version is distributed over packagist https://packagist.org/packages/knplabs/knp-menu#v2.2.0
But not 2.2.0, that suppose to be correct one https://github.com/KnpLabs/KnpMenu/releases/tag/2.2.0

That's weird.
Anyway, I re-deleted tag v2.2.0

The issue appeared again. Can you drop the extra tag one more time and review your release workflow to not do publish it again?
thank you!

Probably a maintainer still has the tag locally and pushes without specifying the branch? Then, git will automatically push any tag that is not yet known on the remote IIRC

Re-deleted tag. Tomorrow I'll check local tags on my computer

v2.2.0 tag added back again...
https://github.com/KnpLabs/KnpMenu/releases/tag/v2.2.0
Please remove the tag from the github, as it blocks the composer update for the projects, using this version of the library.

I deleted the tag again. But the hard part about that is that to prevent it from being pushed again, all maintainers have to make sure they also delete it locally (deleting tags fully is a pain, by design of tags)

And if they fetch from a fork which contains this broken tag, it will recreate it locally too


How to training by GPU

Hi,
I tried to used my GTX1080 for training, but when I run the code, it only used my CPU for training.
What should I do to train the dataset by using my GPU?
Thank you in advance.

Do you have the log output? Also, have you been able to train other models using Tensorflow on your GPU? Thanks!

Sorry my mistake. I want to train with multi GPUs (2 * GTX 1080 TI). How can I enable it?
Thanks!

Sorry, training on multiple GPUs is not supported yet.


Quantized TF Models

In the main table  I see the two int8 models for ONNX but not for TF/TF-Lite.
Can someone add the rows for the equivalent TF/TF-Lite models and their accuracy (as reported by MLPerf reference flow)?

@parvizp #310 partially addresses your comment: it's only for the quantized MobileNet TF model, and via CK. I will validate the quantized MobileNet TFLite model shortly.

Good news. I've also found accuracy results for the quantized finetuned SSD-MobileNet TF model provided by Habana.

When measuring via CK with OpenCV preprocessing, the Top 1 accuracy of the non-quantized TFLite model is the same as that of the non-quantized TF model (71.516%). Potentially it's the same when measured via the official code (71.68%).
The Top 1 accuracy of the quantized TFLite model, however, is higher than that of the quantized TF model (70.776% vs. 70.654%, or 61 more correctly classified images). Interestingly, the Top 5 accuracy is lower (89.198% vs. 89.514%, or 158 fewer correctly classified images).

Thanks for taking the time to run and update the README @psyhtest !
So is the mobilenet-v1 quantized accuracy of 70.776% "valid" with respect to the 99% of FP32 threshold? Even using the lower FP32 accuracy from TF-Lite of 71.516*0.99 = 70.800 > 70.776?
I wasn't aware of the finetuned SSD model from Habana, thanks for pointing that out. Just to be clear you ran it in TesnorFlow with the FakeQuant nodes rather than as a "true" quantized TF-Lite model to get your accuracy score?

So is the mobilenet-v1 quantized accuracy of 70.776% "valid" with respect to the 99% of FP32 threshold? Even using the lower FP32 accuracy from TF-Lite of 71.516*0.99 = 70.800 > 70.776?

Nope. See my comment here.

Just to be clear you ran it in TensorFlow with the FakeQuant nodes rather than as a "true" quantized TF-Lite model to get your accuracy score?

Yep. I think it could be converted to TFLite too using the kind of gymnastics required for the non-quantized model, but we haven't done this.


SSO is available on Pro and Enterprise plans

Update plans that have SSO available.
Verifications

aligns with pricing:

Thanks for bringing this to my attention @JuanitoFatas !
@clbarrell and @BrettJay confirmed that the 'Team' plan was decommissioned and the 'Business' plan was renamed 'Pro'.
@clbarrell mentioned he plans to scan through the rest of the docs for any remaining instances of these, which I'd be happy to take over.
In the meantime, I'll approve this PR and you can merge this in 👍


fischerExact algorithm improvements

I noted in https://github.com/rillki/humble-benchmarks/pull/4#discussion_r688917126 that there was a lot of work done that was then cancelled out.
So I did this: ~https://github.com/John-Colvin/humble-benchmarks/commit/0337184af227e35c2fc24d86dc978aea16f18d91~ https://github.com/John-Colvin/humble-benchmarks/commit/8b219afdc825ed34ee7ad3ed1ef0a5ac65e83d2a which really shows how little work actually depends on the loop variable i.
Which then leads us to https://github.com/rillki/humble-benchmarks/pull/4#discussion_r688915298. In combination with the commit above, I think it's quite clear that - for a given contingency table - there is a constant (fs[data[0] + data[1]] + fs[data[2] + data[3]] + fs[data[0] + data[2]] + fs[data[1] + data[3]] - fs[data[0] + data[1] + data[2] + data[3]]) that is added n + 1 times where n is the number of iterations, then a pair of indices that sweep down through factorials at a fixed offset to each other (data[2] - data[1]) and a pair that sweep up similarly (offset data[3] - data[0]).
From this it seems evident that there is a way to be found to calculate the a[n]s from https://github.com/rillki/humble-benchmarks/pull/4#discussion_r688915298 and avoid jumping around in factorials altogether.
I still don't know what fischerExact is 🤣, but I can read code 😄

this is nonsense, please ignore.


Murko: Investigate ways of storing image data in redis

As of https://github.com/DiamondLightSource/dodal/pull/809 we store image data as pickled jpeg bytes. However, there are some other options:

Remove the pickling and directly store as bytes
Use something better optimised for binary like https://redis.io/docs/latest/develop/data-types/bitfields/

We should evaluate based on minimising the storage requirements on the DB but without adding the need for any complex code for storing/retrieving (e.g. should still be possible in a couple of lines)
Acceptance Criteria

The above are tried on the database and evaluated

From a bit more of an indepth look it looks like bitfields are more optimized for scenarios where you want to bit-wise manipulation on data e.g. storing a large set of true/false values in a single byte string. This is not really what we want but if it does provide optimisation on the space then open to trying it


Suggestions on TODOs and comments/naming for TX History API

@matthew1001 - this is the promised PR review / TODO help from PR #51, covering my high level comments.
I'm afraid I didn't get to looking at the reason you're seeing out-of-order serialization on some paths.
The items I've tried to provide here are:

Simplifying config to one parameter

I believe only one array needs a limit, the others are limited by the list of different types

Passing config to the TX History API

I refactored it out to a separate txhistory.Manager instanced, and added that into what's passed to the Policy Engine
I called this new structure policyengine.ToolkitAPI which I think is in-line with the evolving architecture

Comments / code naming / removing fields

I've added code comments with my understanding of the intent of the different sections, both to validate my current understanding, and to aid future developers of policy engines.

Codecov Report

Merging #58 (39acd79) into main (952269d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%
==========================================
  Files          59       59
  Lines        3228     3221       -7
==========================================
- Hits         3227     3220       -7
  Misses          1        1

Impacted Files
Coverage Δ

internal/tmconfig/tmconfig.go
100.00% <ø> (ø)

pkg/fftm/manager.go
100.00% <100.00%> (ø)

pkg/fftm/policyloop.go
100.00% <100.00%> (ø)

pkg/fftm/send_tx.go
100.00% <100.00%> (ø)

pkg/policyengines/simple/simple_policy_engine.go
100.00% <100.00%> (ø)

pkg/txhistory/txhistory.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks for the updates/suggestions. To close the circle on discussions...

Re. config, yes simplifying down from 3 config parameters makes it's less cumbersome. I wondered with the new changes if mtx.HistorySummary and currentSubStatus.Actions can grow indefinitely if a policy engine kept adding new types of sub-status or action?
Yeah I'd preferred to go with the idea that you call sub-status functions on a transaction itself rather than call sub-status functions on another entity and pass in the transaction, but this did seem to make passing config through more tricky. I had pondered moving the sub-status functions into the manager but opted not to. Think your alternative approach is perfectly valid though and seems to solve the config issue.
Re comments etc. yes certainly needed to clarify functions/behaviours more than I had, thanks for adding.

if mtx.HistorySummary and currentSubStatus.Actions can grow indefinitely if a policy engine kept adding new types of sub-status or action?

I think this would be considered a code bug in the implementation of the policy engine though right? e.g. not following the spec/spirit of the API.

Agreed, I think my original approach of making each list configurable was overkill to protect against a mis-implementation of a policy engine but agree that we don't need it.


Incorrect file Paths in Stack

I'm not sure what is wrong in my configuration.
All files appearing in the stack have a wrong path. So it is impossible to debug.
I'm using XDebug on windows in local(not inside VM)
All file paths have twice the webroot directory.
For example:
C:\dir1\webroot\C:\dir1\webroot\dir2\dir3\filename.ext

On Windows the file:/// handler includes three slashes which should be replaced in the remotePathToLocal not just two, then it works fine. I don't know how it is for Linux though.

This bug is several months old so I'm going to go ahead and close this for now. If you need this reopened please do so, with a copy of your php-debug configuration from atom.


Can't I customize the style of the title and subtitle?

How can I erase the subtitle property completely? How does the API menthioned in the readme works?

Solved it :)


So, I wonder if there are any new training command for the latest training code.
Looking forward to your reply!

still waiting for your response :(
In the instruction_following.py, there are confused arguments like 'past_mimicit_path' and 'new_mimicit_path'.
When I try to set the arguments '--past*' to None and '--new*' to the dir of my DC files, it reports a size mismatch error.
accelerate launch --config_file=./pipeline/accelerate_configs/accelerate_config_fsdp.yaml \ pipeline/train/instruction_following.py \ --pretrained_model_name_or_path='/home/linhb/hf_models/OTTER-MPT7B-Init'  \ --new_mimicit_path="/home/linhb/dataset/MIMIC-IT/DC/DC_instructions.json" \ --new_images_path="/home/linhb/dataset/MIMIC-IT/DC/DC.json" \ --new_train_config_path="/home/linhb/dataset/MIMIC-IT/DC/DC_train.json" \ --batch_size=4 \ --num_epochs=9 \ --report_to_wandb \ --run_name=OTTER-MPT7B-densecaption \ --wandb_project=otter \ --workers=1 \ --lr_scheduler=cosine \ --learning_rate=1e-5 \ --warmup_steps_ratio=0.01
And the error is  stack expects each tensor to be equal size, but got [1, 92, 3, 224, 224] at entry 0 and [1, 117, 3, 224, 224] at entry 1

still waiting for your response :(
In the instruction_following.py, there are confused arguments like 'past_mimicit_path' and 'new_mimicit_path'. When I try to set the arguments '--past*' to None and '--new*' to the dir of my DC files, it reports a size mismatch error. accelerate launch --config_file=./pipeline/accelerate_configs/accelerate_config_fsdp.yaml \ pipeline/train/instruction_following.py \ --pretrained_model_name_or_path='/home/linhb/hf_models/OTTER-MPT7B-Init' \ --new_mimicit_path="/home/linhb/dataset/MIMIC-IT/DC/DC_instructions.json" \ --new_images_path="/home/linhb/dataset/MIMIC-IT/DC/DC.json" \ --new_train_config_path="/home/linhb/dataset/MIMIC-IT/DC/DC_train.json" \ --batch_size=4 \ --num_epochs=9 \ --report_to_wandb \ --run_name=OTTER-MPT7B-densecaption \ --wandb_project=otter \ --workers=1 \ --lr_scheduler=cosine \ --learning_rate=1e-5 \ --warmup_steps_ratio=0.01
And the error is  stack expects each tensor to be equal size, but got [1, 92, 3, 224, 224] at entry 0 and [1, 117, 3, 224, 224] at entry 1

The new_mimicit_path should be a naming issue. We will restore it to "mimicit_path" soon in a PR. If you do not have to put something back into current training, you can just ignore the past_mimicit_path and relevant args.

still waiting for your response :(
In the instruction_following.py, there are confused arguments like 'past_mimicit_path' and 'new_mimicit_path'. When I try to set the arguments '--past*' to None and '--new*' to the dir of my DC files, it reports a size mismatch error. accelerate launch --config_file=./pipeline/accelerate_configs/accelerate_config_fsdp.yaml \ pipeline/train/instruction_following.py \ --pretrained_model_name_or_path='/home/linhb/hf_models/OTTER-MPT7B-Init' \ --new_mimicit_path="/home/linhb/dataset/MIMIC-IT/DC/DC_instructions.json" \ --new_images_path="/home/linhb/dataset/MIMIC-IT/DC/DC.json" \ --new_train_config_path="/home/linhb/dataset/MIMIC-IT/DC/DC_train.json" \ --batch_size=4 \ --num_epochs=9 \ --report_to_wandb \ --run_name=OTTER-MPT7B-densecaption \ --wandb_project=otter \ --workers=1 \ --lr_scheduler=cosine \ --learning_rate=1e-5 \ --warmup_steps_ratio=0.01
And the error is  stack expects each tensor to be equal size, but got [1, 92, 3, 224, 224] at entry 0 and [1, 117, 3, 224, 224] at entry 1

Expectedly we will resample the frames into a fixed range, so that would enable batchwise training.
You can modify the relevant function into
    def process_dense_caption(self, instruction_id, instruction, answer, image_ids, in_context_example_ids, resample_frames=32):
        patch_images = torch.tensor([])
        all_texts = ""
        all_instruction_ids = in_context_example_ids + [instruction_id]
        random.shuffle(all_instruction_ids)
        for cur_instruction_id in all_instruction_ids[:]:
            cur_instruction = self.dataset[cur_instruction_id]["instruction"]
            cur_instruction = self.pre_question(cur_instruction, self.max_src_length)
            cur_answer = self.dataset[cur_instruction_id]["answer"]
            cur_answer = self.pre_answer(cur_answer, self.max_tgt_length)
            cur_text = f"User: {cur_instruction} GPT:<answer> {cur_answer}<|endofchunk|>"
            all_texts += cur_text

        all_texts = f"<image>{all_texts}"
        # <image>User: {cur_incontext_instruction} GPT:<answer> {cur_incontext_answer}<|endofchunk|>User: {instruction} GPT:<answer> {answer}<|endofchunk|>
        # <image>User: what does the image describe? GPT: XXX <|endofchunk|>User: Do you think this image is funny GPT:<answer> YYY <|endofchunk|>
        image_ids = self.resample_frames(image_ids, resample_frames)
        for cur_image_id in image_ids:
            cur_image = self.images[cur_image_id]
            cur_image = Image.open(BytesIO(base64.urlsafe_b64decode(cur_image))).convert("RGB")
            cur_patch_image = self.patch_resize_transform(cur_image).unsqueeze(0)
            if len(patch_images) == 0:
                patch_images = cur_patch_image
            else:
                patch_images = torch.cat((patch_images, cur_patch_image))

        patch_images = patch_images.unsqueeze(0)
        return patch_images, all_texts

The resample_frames is to uniformly extract fixed number of frames from different batch entries.

These all would be fixed in a next PR. You can update your current code manually or wait next PR and then pull them.

Thanks for your reply! Now I am succeed to run the training code of Otter.
If someone meet the same problem like me, you can also fix this issue by the following steps:

set the arguments '--past*' to None and '--new*' to the directory of your DC files
modify the function 'process_dense_caption' as @Luodian suggestions
It works for me.


[WFLY-13345] Ignore classloading failures when processing component i…

…nterceptor annotations
https://issues.redhat.com/browse/WFLY-13345
I'd like some thought on this one from someone besides myself.  I think the kinds of problems that this now ignores are conceptually in the same category as the ClassLoadingUtils.loadClass problems we were already ignoring so the same handling seems ok.  Basically MethodAnnotationAggregator/ClassReflectionIndex are doing deeper probing of the class than simple classloading does but the kinds of problems it might hit are of the same general category.

@chengfang Do you have any thoughts on this?


Zenodo doi

For the paper, we should create a Zenodo doi. For that purpose, we should also start with a citation file (example)
I think almost all authors are listed already in the linked citation file. @saifr68 do you already have an ORCID?
Do we include Thomas as author in the new version?

@TTitscher vielleicht kann Thomas kurz schreiben, ob er als Co-Author auf dem Paper erscheinen möchte, und wenn ja, mit welcher Email-Adressse.

Hi guys, nice to see that fenics-constitutive is being continued in fenicsx!
I think with 7b69162, you essentially created a new project with own ideas while reusing the name of the repository. And I like it! So it's perfectly fine for me, if you leave me out as coauthor! (both paper and code)
Good luck!

Thank you:)
Just to clarify: The paper that we are talking about is built upon the one you started with Vitaliy, but it goes into a more general direction of how to build constitutive models with fenicsx and the UMAT bindings is an example for that. We basically don't use any of the old code, but we were definitely inspired by what the two of you did. So you will probably get at least an acknowledgment in the paper;)


Failing tests

@jhoneill moved and commented out tests, only a few.
I'm thinking I need to work on feature branches and then do a PR to merge back to master. Might reduce the conflicts, maybe.
https://ci.appveyor.com/project/dfinke/importexcel/build/1.0.73
https://ci.appveyor.com/project/dfinke/importexcel/build/1.0.74
https://ci.appveyor.com/project/dfinke/importexcel/build/1.0.75

I can spot what those are
First one in .73 is there is no Excel on the server to start.
The others are basically a very short list of processes the tests are written to use 50 and get 31 when they ask for the first or last 50. The number of processes can be reduced ...


makeinfo (aka texinfo) script does not run when installed

makeinfo has the wrong line at the top of the shell (it has a jenkins path). When I change it to
#!/bin/env perl

it works.
This prevents m4 from being able to be built from 'git' because it uses makeinfo

@IgorTodorovskiIBM not sure if this is something that can be fixed through an update to the .env script post-install?

Fixed in https://github.com/ZOSOpenTools/makeinfoport/pull/4 since it was further along. I'll close this repo since its a dupe if you're ok with it. We can rename the other one after if needed

Ok


Fix Log4j property file parameter issue

Fix parameterization issues in the log4j property file.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Optimize resource valid check after set the headers

Resolves #1160
In case change_headers_on_each_request is disabled: this will improve and prevent no-tokens sent if the user is invalid.
In case change_headers_on_each_request is enabled: this will throw an error if the user is invalid even after loading from DB (password controller and other user's controllers needs to send errors to the fronted), if this happens, it means the user left the model in a valid state and it's a bug of the developer's application.

@dks17 do you approve this PR? need someone that reviews this

@dks17 It's ready, I had to move the test from the sessions controller to another one because it was failing only in travis for a random reason, and it was driving me crazy, the test makes sense in any controller that uses update_auth_header

@MaicolBen ok. It looks good.
I would like that exception message test be added, but it's optional.

@dks17 thank you! it spotted a bug! I was outputting the ruby class name (array)


SAK-48345: Inconsistent formatting numeric response questions in test and quizzes (samigo) for dark theme

JIRA: https://sakaiproject.atlassian.net/browse/SAK-48345
Reference: https://github.com/sakaiproject/sakai/pull/10472#discussion_r858870715

I'm not seeing any error loading bootstrap from the console logs, and we use the function includeWebjarLibrary("bootstrap"); so we don't have to update code all over the place when we do a version upgrade for a library.
In the logs it says
"Adding webjar library bootstrap, version 3.3.7"
Did this fix it for you? Maybe the fix is just removing this line entirely rather than replacing it. I don't know why it would need bootstrap in this module and it looks like including the default bootstrap styles (scaffolding.less) which has a color of #333 is what's messing this up?

I'm not seeing any error loading bootstrap from the console logs, and we use the function includeWebjarLibrary("bootstrap"); so we don't have to update code all over the place when we do a version upgrade for a library.
In the logs it says "Adding webjar library bootstrap, version 3.3.7"
Did this fix it for you? Maybe the fix is just removing this line entirely rather than replacing it. I don't know why it would need bootstrap in this module and it looks like including the default bootstrap styles (scaffolding.less) which has a color of #333 is what's messing this up?
It looks like qtip2 and bootstrap were included in the commit prior 0de533c in SAK-47188. I'd think that only qtip2 might be needed here.


2.x factories

Let's have a PR for Factories.

There was 1 error:

1) TestTimberUser::testIDDataType

Error: Call to protected Timber\User::__construct() from context 'TestTimberUser'

tests/test-timber-user.php:12

Coverage decreased (-2.3%) to 89.821% when pulling 440549c6ffac5fae12a761acc6a7a3a6e2830dd5 on 2.x-factories into d5053a7a3a44d7d421e3ce9e42c3e644b46f0750 on 2.x.

Codecov Report

Merging #2194 into 2.x will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #2194      +/-   ##
============================================
+ Coverage     91.76%   91.83%   +0.07%
- Complexity     1627     1637      +10
============================================
  Files            54       54
  Lines          4115     4200      +85
============================================
+ Hits           3776     3857      +81
- Misses          339      343       +4

Impacted Files
Coverage Δ
Complexity Δ

lib/Twig.php
95.16% <0.00%> (+0.06%)
55.00% <0.00%> (+10.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ec61d...03ec61d. Read the comment docs.

I think we're good here @acobster @gchtr ? Unless there's something I'm missing I think we could pull this in and proceed with THE PURGE #2323.
The only other PR to consider (at least that I saw) was #2293. Let me know if that needs to be resolved/merged first before we merge with #1617 or if it can come in after direct to 2.x

There are a few other things noted in the checklist in #2073 (#2292, #1863, #2333) but these are all improvements on top of what I think is a pretty strong foundation here. We should also do a final pass over all the tests that are currently skipped at some point. And just for completeness's sake, #2073 still needs to be merge in, but I think that should come after those improvements.
@szepeviktor where did you see that test failure? Travis seems happy...
Barring any objections from @gchtr, I say let's go for it.

@szepeviktor where did you see that test failure? Travis seems happy...

That was 8 months ago 🐈

That was 8 months ago :cat2:

lol, is it Friday yet?

@jarednova @acobster I’d say, let’s merge this in and then work on remaining tasks against the 2.x branch. If any pull request is still against 2.x-factories, it will be automatically updated to be pulled against 2.x.
From what I can tell, #2073 still gives a very up-to-date view over the remaining tasks. I think apart from THE PURGE (#2323), these are mostly the only remaining blocking tasks that we need to work on before we could release an alpha or a beta version, right?
While we can test the first version and resolve issues that might still surface there, we can also work on the other remaining tasks, like documentation, type declarations, etc.
I can check for merge conflicts with #2073 once this pull request is merged into 2.x.
@acobster I’ll leave it to you to do the merge.

Alright! Merging momentarily.

these are mostly the only remaining blocking tasks that we need to work on before we could release an alpha or a beta version, right?

Yeah, I've done my best to keep #2073 up to date with everything we need to tackle before 2.0.
And actually, IMO there's no reason we couldn't create an alpha release now. There will be one or two breaking changes thereafter (e.g. type declarations, PHP req), but that's what alpha releases are for :slightly_smiling_face:

🎉

Now that's a merge!


fix(sec): upgrade gopkg.in/yaml.v3 to 3.0.0

What happened？
There are 1 security vulnerabilities found in gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b

CVE-2022-28948

What did I do？
Upgrade gopkg.in/yaml.v3 from v3.0.0-20210107192922-496545a6307b to 3.0.0 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS

@realize096 I think it may be better using v3.0.1 of package gopkg.in/yaml.v3. I'll post a new pr to handle this.

@realize096 https://github.com/gogf/gf/pull/2783


when using other mods no controller is reckognized but with only controllable mod it works fine

Can you send your game log? This will let me see if there are any issues when the mods are installed.

I recommend checking out the documentation. It has guides for different methods of connecting controllers and troubleshooting.
https://mrcrayfish.gitbook.io/controllable-documentation/


Cannot create DynamoDB Lambda Triggers for non-Javascript lambda functions

Is this related to a new or existing Amplify category?
function, api
Is this related to another service?
DynamoDB, AppSync
Describe the feature you'd like to request
As described in the documentation, Amplify supports DynamoDB lambda triggers for tables auto-generated through the @model AppSync/GraphQL directive.
However these triggers cannot be attached to an existing lambda function -- they must be specified when the function is first created, by choosing the 'Lambda trigger' template during the function creation flow (this is all described in the documentation link referenced earlier).
The problem is that only Javascript lambda functions support the 'Lambda trigger' template -- all other runtimes only support the 'Hello World' template.
This means that you cannot use the Amplify CLI to configure DynamoDB triggers for a non-JS function.
 Not being able to use infrastructure you already have in place for your other lambda functions (Python infra, in my case) is pretty disruptive.
Describe the solution you'd like

Ideally: lambda triggers can be attached to existing lambda functions (using amplify function update), written in any language.
Good enough: add support for the Lambda Trigger template for non-JS lambda functions

Describe alternatives you've considered

Use a JS lambda and forego the existing infra already in place for 'standard' lambda function development
Reverse-engineer the CloudFormation configurations put in place by the Lambda Trigger JS template, and reproduce similar configurations for an existing non-JS lambda function created using the Hello World template.

Additional context
As mentioned in the issue description, DynamoDB lambda triggers are required for implementing basic real-world features such as like counts and comment counts.
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

This is an issue for us as well.
We are using the python Lambdas and the comprehensive boto3 library since that is where our skills lie.
Not only that it would be nice to be able to retro-fit triggers to existing functions but more for us the fact there is no trigger template for Python at all (there appears to be support for JS and C#/.Net now) so we are having to use the "reverse engineer" workaround or add them manually via the console which is fraught with user error.
This is also an issue on transformer v2 so could we update the tags, please.


README doc link broken, link to pursuit

Shouldn't this just link to generated-docs?

¯_(ツ)_/¯

Thanks! :)


Seems like 1tamilmv links are not being listed.

I see only tamilblasters links in the listings.

Any specific movie which you're not getting stream?
I can confirm that TamilMv scrapping is working fine.


Cant have custom port in url

I have a server but it's port is 19132 and the url does not have that port, only port 80 how can I fix this

The public localtunnel url will only ever expose public port 80 (http) or 443 (https) and traffic to those ports will be proxied to your local port (19132).


If possible reference proper document about options=sysAttrs.

This is options=sysAttrs - the modifiedAt is generated by the Context Broker for each attribute and for the entity as a whole. I think there could be a divergence if an entity has multiple attributes and only some are updated since the unmodified attributes would have an older modifiedAt timestamp.
Obviously this won't be an issue for a subscribing component since the notification will only be raised when an attribute changes.
Originally posted by @jason-fox in https://github.com/orchestracities/ngsi-timeseries-api/pull/496#discussion_r699073795

From the NGSI-LD ETSI Specification

6.3.11 Including system-generated attributes
For HTTP GET operations performed over the resources /entities/, /subscriptions/, /csourceRegistrations/,
/csourceSubscriptions/ and all of its sub-resources, implementations shall support the parameter specified in
the table below

options - a comma separated list of strings. When its value includes the keyword sysAttrs, a
representation of NGSI-LD Elements shall be provided so that the system-generated attributes createdAt,
modifiedAt are included in the response payload body.

From the NGSI-LD ETSI Specification

6.3.11 Including system-generated attributes
For HTTP GET operations performed over the resources /entities/, /subscriptions/, /csourceRegistrations/,
/csourceSubscriptions/ and all of its sub-resources, implementations shall support the parameter specified in
the table below

options - a comma separated list of strings. When its value includes the keyword sysAttrs, a
representation of NGSI-LD Elements shall be provided so that the system-generated attributes createdAt,
modifiedAt are included in the response payload body.

thanks!


fix: Add targeting key

Fixes #230

Not sure how to fix this test failure, the test harness looks incredibly involved TBH

Not sure how to fix this test failure, the test harness looks incredibly involved TBH

Ya. We have an issue to fix this. I think this is similar to https://github.com/open-feature/dotnet-sdk/pull/223#issuecomment-1927668079. I will try to fix this today.

I'll merge this Monday unless anyone objects!
Thanks a lot @roelofb !


add Linux option to pack_iso

This script wont work on linux with out such an option ;) Thanks.

LGTM

Sorry about that, it had looked good on my screen.  Fixed

Great thanks!


fix(graphcache): Fix onOnline data loss bug in offlineExchange

Summary
It's important that onOnline isn't established until after mutations are read from storage and processed by flushQueue. If the storage adapter's onOnline implementation calls flushQueue in the same task, then the storage will be wiped before it is read from, and all mutations that were in the metadata storage will be deleted before they can be read and processed.
Our team ran into this in our react-native project. The library we use for listening to network information state changes immediately invokes the event listener we install on it. Therefore, it's calling flushQueue before urql's offlineExchange even attempts to read from metadata storage.
Set of changes
@urql/exchange-graphcache:

Change how onOnline is set up in offlineExchange. Wait to install the onOnline callback on the StorageAdapter until after the mutations have been read from the StorageAdapter's metadata store.

It would appear that I have to fix the unit tests first before this is ready to review. Hang tight.


[PE-D][Tester D] Unable to add employee

While adding employee using following command provided in UG
add n/Bob Ye p/8928732<EMAIL_ADDRESS>a/Blk 11, Clementi Ave 1, #03-32 t/friends t/coreTeam r/requires follow up on pay raise role/employee dept/HR job/Manager pref/Likes to work from home tos/2 years skills/Java
It is expected to add the contact, however a message saying the following arises instead.

According to UG, Employees can have preferences and terms of services.

Moreover no product tag is given in the above command, yet the above message arises.
This could be problematic as such an employee, while following the constraints, cannot be added.

Labels: severity.High type.FunctionalityBug
original: maiyasaliha/ped#8

duplicate of #144


Add global sidebar

Add global sidebar in left-side of screen, that allows for navigating between top level concepts such as "Pages" or "Functions" ("Resources" in the future).
I don't really know how to make Material UI look that good aesthetically sometimes, so I'm open to feedback about how it looks visually too.
Uses a temporary global variable as a feature flag.
Issue in Notion: https://www.notion.so/mui-org/Build-functions-independent-of-pages-479aeb651ea14ede9210988777e0ce8b
Extracted from https://github.com/mui/mui-toolpad/pull/2690
https://github.com/mui/mui-toolpad/assets/10789765/c2ec036e-1507-4738-9369-21ad447fa38f

Looks good. I'd try to find better names for RouteShell and NavigationSidebar. Perhaps we need to find a name for this navigation surface? e.g. "App navigation", or "Toolpad navigation"?
Would it make sense to have this bar in a contrast color? cc @danilo-leal for a comment maybe?

Looks good. I'd try to find better names for RouteShell and NavigationSidebar. Perhaps we need to declare a name for this navigation surface in our glossary? e.g. "App navigation", or "Toolpad navigation"?
Would it make sense to have this bar in a contrast color? cc @danilo-leal for a comment maybe?

I've renamed NavigationSidebar to ToolpadNavigation, I think we can call the editor navigation like that and call the in-app navigation for Toolpad apps "App Navigation"?
In terms of a glossary I only see what we have in this page https://mui.com/toolpad/concepts/building-ui/, where it seems that we could just call this new sidebar "Navigation" if we wanted to... I'm not sure how much users need to name these sidebars in particular, it's something we could discuss and then update the docs accordingly.
As for RouteShell, I'm not really sure what else to call it, it's just the ToolpadShell with different props for different routes... Any particular ideas?

https://mui.com/toolpad/concepts/building-ui/

Does it make sense to call them GlobalNavigation and PageNavigation instead?
As for RouteShell, AppShell makes the most sense to me since it is connected directly with the appState

https://mui.com/toolpad/concepts/building-ui/

Does it make sense to call them GlobalNavigation and PageNavigation instead?
As for RouteShell, AppShell makes the most sense to me since it is connected directly with the appState

Not sure about GlobalNavigation, I guess it's fine since it's explicit. PageNavigation sounds good for Toolpad apps, and AppShell also sounds good!
I'll either decide from those or we can all decide quickly as a team in the next grooming meeting.

I'll either decide from those or we can all decide quickly as a team in the next grooming meeting.

Feel free to pick whatever you think is best of those options. Just some more background on why I thought the original names are less optimal:

NavigationSidebar: we have more than one sidebar that does navigation. This name doesn't really disambiguate.
RouteShell: This is naming by function, "the shell of the route", but any "shell" on the page is a shell of the route. To properly qualify it, it's more logical to name it after its content, "the shell of the toolpad editor".

Ok, I've considered all options and went with ToopadNavigation for the global sidebar, AppPagesNavigation for the in-app navigation sidebar, and EditorShell for the shell around the routes.
Let me know if you disagree with anything and it's fine to change them.


PartialEq for UseState/UseCoroutine

Add PartialEq-implementation for dioxus_hooks::Coroutine and dioxus_hooks::UseState.
Both are good candidates to pass as a prop. UseState already implements PartialEq.

Looks good! Thank you!


data: imnischaygowda

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I am closing this Pull Request as it appears to be a duplicate of: https://github.com/EddieHubCommunity/LinkFree/pull/4865
@imnischaygowda in future, if you no longer want a Pull Request open please make sure that you close this as this helps maintainers keep on top of the project.


Choose USB Device Option

Is there an option or way to choose which USB device is used?
I have two radios (two of the same USB Realtek RTL2838UHIDIR  ) one for acurite2mqtt and a new one for sdr2mqtt and both are using the same one.
::::::::Starting RTL_433 with parameters::::::::
[21:09:15] INFO: MQTT Host = xxxx
[21:09:15] INFO: MQTT port = 1883
[21:09:15] INFO: MQTT User = xxxx
[21:09:15] INFO: MQTT Password = xxxx
[21:09:15] INFO: MQTT Topic = RTL915
[21:09:15] INFO: MQTT Retain = true
[21:09:15] INFO: PROTOCOL =
[21:09:15] INFO: FREQUENCY = -f 915M -f 868M
[21:09:15] INFO: Whitelist Enabled = false
[21:09:15] INFO: Whitelist =
[21:09:15] INFO: Expire After = 0
[21:09:15] INFO: UNITS = customary
[21:09:15] INFO: DISCOVERY_PREFIX = homeassistant
[21:09:15] INFO: DISCOVERY_INTERVAL = 60
[21:09:15] INFO: AUTO_DISCOVERY = true
[21:09:15] INFO: DEBUG = false
::::::::rtl_433 running output::::::::
rtl_433 version v20240329-3246-gd74490c5667 branch master at<PHONE_NUMBER>27 inputs file rtl_tcp RTL-SDR with TLS
New defaults active, use "-Y classic -s 250k" if you need the old defaults
MQTT: Publishing MQTT data to xxxx port 1883
MQTT: Publishing device info to MQTT topic "RTL915[/model][/id][/channel:A]".
MQTT: Publishing events info to MQTT topic "RTL915/events".
MQTT: Publishing states info to MQTT topic "RTL915/states".
Use "-F log" if you want any messages, warnings, and errors in the console.
usb_claim_interface error -6
INFO:Started
Found Rafael Micro R820T tuner
Exact sample rate is: 1000000.026491 Hz
[R82XX] PLL not locked!

I assumed it would grab the one not in use but it just grabs the first one which is already in use.
Thank you

Found it and verified, can you add the -d {0-9} device option I have been testing it with RTL_433 from git on another machine.
$ sudo rtl_433 -d 1
Thank you


Add algorithm for inplace-mutation and dropping without reallocation

this was created from http://stackoverflow.com/questions/28318886/how-do-i-partially-fold-a-vec-in-place
name-bikeshedding welcome.
instead of implementing it for &mut [T] i could probably implement it for ExactSizeIterator not sure on that

Still wrapping my head around this. It's sort of a parallel to .batching(). Is this a practical API?

think of this PR as an RFC ;) I'm sure you could get a similar behavior for Iterators implementing RandomAccessIterator. But the ability to match on slices creates much more readable code. So maybe we need a SliceIterator that has O(1) operations to_slice and implement SliceExt for SliceIterator. Then you could use batching to step the iterator forward whenever you want, and otherwise match on slices.

I think we should stick to just iterator related functions in itertools for now. Feel free to open new PRs with wild ideas if you have :)


Update tutorial-tic-tac-toe.md added import statement for react

I encountered an error in my React application that said: "Line 2: 'React' must be in scope when using JSX."
To resolve this issue, I made sure to import React at the beginning of my JavaScript file, along with StrictMode.

When using the latest JSX runtime, you do not need to import React.
https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html
If you are only seeing the lint error but the code works otherwise, you can disable it: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/react-in-jsx-scope.md#when-not-to-use-it


Disable SSL Validation

Is it possible to add an attribute to disable SSL validation for testing? I'm currently using a self signed cert on my test server.

Absolutely, let me get this in today.

Complete, v1.2 posted on supermarket

Hi there, just tried the v1.2 but I'm still getting the SSL validation error. I've added the new attribute to the example POST block.
Sent from my iPhone

On 4 Mar 2015, at 17:37, Brian Stajkowski<EMAIL_ADDRESS>wrote:
Complete, v1.2 posted on supermarket
—
Reply to this email directly or view it on GitHub.

Doing more testing.  I was able to replicate, fixing.

Verified fixed in v0.1.25
Let me know if you have any more issues.

Hmm I'm still getting some issues here. i.e. 301 errors now. If I try a basic get in a browser it works OK.
Compiling Cookbooks...

Enable redirects by setting:
webhooks_request("Test Get HTTP Process") do
follow_redirect true
end

Sorry !
Same again:
[2015-03-04T20:17:07+00:00] FATAL: Error encountered: Received an unexpected HTTP Response code 301..

    ================================================================================
    Error executing action `get` on resource 'webhooks_request[Test Get HTTP Process]'
    ================================================================================

    SystemExit
    ----------
    exit

    Cookbook Trace:
    ---------------
    /Users/cbourne/.chef/local-mode-cache/cache/cookbooks/webhooks/providers/request.rb:178:in `exit'
    /Users/cbourne/.chef/local-mode-cache/cache/cookbooks/webhooks/providers/request.rb:178:in `rescue in execute_request'
    /Users/cbourne/.chef/local-mode-cache/cache/cookbooks/webhooks/providers/request.rb:98:in `execute_request'
    /Users/cbourne/.chef/local-mode-cache/cache/cookbooks/webhooks/providers/request.rb:12:in `block (2 levels) in class_from_file'
    /Users/cbourne/.chef/local-mode-cache/cache/cookbooks/webhooks/providers/request.rb:10:in `block in class_from_file'

    Resource Declaration:
    ---------------------
    # In /Users/cbourne/.chef/local-mode-cache/cache/cookbooks/webhooks/recipes/example.rb

     10: webhooks_request "Test Get HTTP Process" do
     11:   uri "<IP_ADDRESS>/vedsdk"
     12:   ssl_validation false
     13:   use_ssl true
     14:   follow_redirect true
     15:   expected_response_codes [ 200, 201 ]
     16:   action :get
     17: end
     18:

    Compiled Resource:
    ------------------
    # Declared in /Users/cbourne/.chef/local-mode-cache/cache/cookbooks/webhooks/recipes/example.rb:10:in `from_file'

What happens when you put this
expected_response_codes [ 200, 201, 301 ]

This is what I get now.
[2015-03-04T20:39:45+00:00] INFO: Webhooks Operation Successful: Test Get HTTP Process! Response Code 301.
[2015-03-04T20:39:45+00:00] INFO: Saving Response.
<title>Document Moved</title>

Object Moved
This document may be found <a HREF="https://<IP_ADDRESS>/vedsdk/">here
    - Completed GET of Test Get HTTP Process
[2015-03-04T20:39:45+00:00] WARN: Skipping final node save because override_runlist was given
[2015-03-04T20:39:45+00:00] INFO: Chef Run complete in 0.153402 seconds
[2015-03-04T20:39:45+00:00] INFO: Skipping removal of unused files from the cache

Ok change:
uri "<IP_ADDRESS>/vedsdk"
To:
uri "<IP_ADDRESS>/vedsdk/"

OK that worked. So I think the ssl_validation false attributes working now. I'll do some more testing and let you know the outcome. Thanks for your assistance on this. Owe you three beers now :)

No problem man.  3 7&7's preferably lol.


Added key vault configuration for azure devops, and updated tests

Pull Request Test Coverage Report for Build 763893571

52 of 62 (83.87%)  changed or added relevant lines in 5 files are covered.
26 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-1.2%) to 90.496%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/DevOpsMetrics.Service/Controllers/BuildsController.cs
8
10
80.0%

src/DevOpsMetrics.Service/Controllers/DeploymentFrequencyController.cs
8
10
80.0%

src/DevOpsMetrics.Service/Controllers/LeadTimeForChangesController.cs
8
10
80.0%

src/DevOpsMetrics.Service/Controllers/PullRequestsController.cs
16
20
80.0%

Files with Coverage Reduction
New Missed Lines
%

src/DevOpsMetrics.Service/Controllers/BuildsController.cs
2
51.72%

src/DevOpsMetrics.Service/Controllers/DeploymentFrequencyController.cs
2
52.38%

src/DevOpsMetrics.Service/Controllers/LeadTimeForChangesController.cs
2
53.85%

src/DevOpsMetrics.Service/Controllers/PullRequestsController.cs
4
50.44%

src/DevOpsMetrics.Core/DataAccess/TableStorage/AzureTableStorageDA.cs
16
89.82%

Totals

Change from base Build 761419653:
-1.2%

Covered Lines:
2593

Relevant Lines:
2840

💛  - Coveralls


Terms of use?

In the screenshot above the terms of use field states that it's only for Cloud Solution Provider sales. However in the Cloud Partner Portal this statement is not shown. Can you confirm whether CSP is required to use your own terms of use?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e6aba9e-03e6-9955-8f58-c3e32494d901
Version Independent ID: 458939b9-0a4b-ee23-afa8-0e5b299d498e
Content: Standard Contract
Content Source: articles/marketplace/standard-contract.md
Service: marketplace
GitHub Login: @qianw211
Microsoft Alias: ellacroi

@justimorries Here's the answer to your questions.  Thanks!
What the tooltip is intended to articulate is that the Standard Contract terms cannot be used for the CSP channel, so the publisher must upload terms and conditions for that channel even if they select the Standard Contract.
We are working on changing this so that the Standard Contract is supported in CSP, but the timing is not confirmed yet.

Thanks for clarifying. So to confirm, a non-CSP publisher can include their own procurement T&Cs?

@qianw211 can you confirm the above pls?

@justimorris Hi Justin, here's the answer to your question:

Channel
Standard Contract
Custom T&Cs

Customer Led (web stores)
Yes
Yes

Partner Led (csp)
No*
Yes

Field Led (quote center)*
N/A
N/A

*coming in the future


$trust.ClaimProviderName = "AzureCP" Exception setting "ClaimProviderName": "Claim provider with name AzureCP does not exist." At line:1 char:1

Not working. I have deactivate and reactivate the feature under Central Admin.
I have removed the solution and reinstalled it again but still the same error.

@upatel911, sorry for the late reply. Does cmdlet Get-SPClaimProvider return AzureCP?

Hello ,
The issue resolved when I deactivate and activate the farm feature.
Thank you so much for connecting and providing your prompt response.
Many Thanks
Uday Patel
Sent from my iPhone

On Jun 17, 2021, at 2:54 AM, Yvan Duhamel @.***> wrote:

@upatel911, sorry for the late reply. Does cmdlet Get-SPClaimProvider return AzureCP?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Dropping support under Django 1.7

As see Django's roadmap, we do not have to support under Django 1.7 at all. So I dropped it.

Codecov Report

Merging #250 into master will increase coverage by 0.88%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #250      +/-   ##
=========================================
+ Coverage   95.32%   96.2%   +0.88%
=========================================
  Files          11      11
  Lines         214     211       -3
=========================================
- Hits          204     203       -1
+ Misses         10       8       -2

Impacted Files
Coverage Δ

django_summernote/widgets.py
93.65% <100%> (+2.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e7d4f...a96ca33. Read the comment docs.

Great!

Thanks!


Task: Word-Level Alignment

Description
Update forced alignment to word-level, not just sentence level alignment.
Tasks

[ ] Add correctness test with labeled data
[ ] Update
[ ] Add additional tests

Freeform Notes
Related:
https://github.com/sensein/senselab/issues/14

Update 12/09:
Reviewed code and identified what needs to be changed. Still figuring out how exactly it should be changed.

Update 12/17:
The code works and returns an aligned ScriptLine for sentences, words, and characters. I am now fixing discrepancies with the previous tests. I also plan to add a correctness test for at least one labeled example.


Update 6.5/fix raft engine

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 6 committers have signed the CLA.:white_check_mark: ti-chi-bot:white_check_mark: lijie0123:white_check_mark: fengou1:white_check_mark: CalvinNeo:x: you06:x: tonyxuqqiYou have signed the CLA already but the status is still pending? Let us recheck it.


Enter key in "Add CMS plugin" pop-in breaks the text

If you use the enter key to submit the form (eg. when adding a link or a picture) instead of clicking on the save button, the CKEditor window closes as well and plugins seem to be added to the text but when you try to edit it again, all the text is gone.

closed in favour of #285


test/which.bats: do not export PATH

Otherwise sed might not be found later in bats/libexec/bats-exec-test,
in case /usr/bin gets removed.

Updated to not use env anymore - where run was not found then.

Each test is run in isolation (I think) as a separate process. But the change looks good anyway.


Update to packing tools and logic

This PR implements some changes discussed in #398:

[x] Moved to pyproject.toml. Removed setup.cfg

install optional test and mitgcm dependencies now with e.g. pip install .[test]
it seems that the test and doc dependencies are bundled together. I’ve left this for now, but in the future it might be tidier to split them

[x] Added versioneer support
[x] Update conda build to build from PyPI dist. I've modified the CD Github workflow so that the conda build only happens if the PyPI upload is successful.

In doing this, I discovered that the um driver requires imp, which has been deprecated. I’ve updated the driver to use the replacement importlib instead and the tests still pass, but I'm not sure the tests actually touch the modified code...
I've also removed the tools and bin directories (#396 and #397). This doesn't have to be done here, but it felt relevant since these are places where the hard-coded version was being used.
I couldn’t work out a easy/tidy way to have dependencies defined in only one location for the PyPI and conda builds, so dependencies are currently listed in both pyproject.toml and meta.yaml.
I’ve tested building the PyPI dist, uploading to TestPyPI and then doing the conda build locally from that. But the true test will be actually issuing a new release.
Closes #398, closes #401, closes #397, closes #396

Hello @dougiesquire! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file payu/_version.py:

Line 381:80: E501 line too long (84 > 79 characters)
Line 471:80: E501 line too long (80 > 79 characters)
Line 474:80: E501 line too long (84 > 79 characters)

The conda-build job that's been added to CI.yaml will need to be altered or removed. Is it necessary anymore?

coverage: 51.644% (-0.9%) from 52.591%
when pulling 0c672cd831aa0e2b18a41de2715ce0f878998f6c on dougiesquire:issue-398
into ca0c825aaa1b228f1350f32b2318f40f29760aef on payu-org:master.

Hey @dougiesquire! With regards to https://github.com/payu-org/payu/pull/403#issuecomment-1894921909
I think we'd need the equivalent check for PyPI, in this case. We used the conda build check to make sure we weren't putting anything broken onto vk83 (which had happened before). Is there a similar thing where you can attempt to build Payu using PyPI?

I've worked out a way to dynamically input the dependencies in meta.yaml from the pyproject.toml. However, it requires that the dependencies are listed in the pyproject.toml using the slightly more restricted syntax expected by conda (i.e. a space before version limits, but not after, e.g. package >=1.0). It also obviously will fail if the conda dependencies differ from the pip dependencies. @aidanheerdegen do we want to do this? I can add a comment to the pyproject.toml about the syntax.
Regarding the build tests in the CI, I see three options:

only build with PyPA's build package. Passing this isn't necessarily an indication that a release will be successful as the upload to PyPI or conda build from PyPI could have untested issues.
Build with PyPA's build package and conda build from local source. These can be independent jobs. This will require some jinja templating in the meta.yaml to enable the source to be switched dynamically (e.g. based on an env variable set in the Github workflow) since we will want to build from local source in CI and PyPI in CD.
Build with PyPA's build package, upload to TestPyPI and conda build from TestPyPI dist. These will be dependent jobs. Again jinja templating will be required to switch the PyPI url.

Curious on thoughts @CodeGat, @aidanheerdegen. 1 or 3 are probably my most preferred options.

I can't work out why the trusted publishing to TestPyPI is not working (it says here that it's supported). I'm going to stop working on this and give @aidanheerdegen and @CodeGat some time to respond to my questions above. And if anyone has ideas about why trusted publishing isn't working, please let me know!

I've worked out a way to dynamically input the dependencies in meta.yaml from the pyproject.toml. However, it requires that the dependencies are listed in the pyproject.toml using the slightly more restricted syntax expected by conda (i.e. a space before version limits, but not after, e.g. package >=1.0).

This looks like a great approach. Jinja templating is a standard feature of conda/meta.yaml so it isn't going to mysteriously stop working. The requirement to match the stricter syntax for conda version pinning is a feature IMO. We already had an issue with this when duplicating requirements from setup.py to meta.yaml. Being explicit and doing it one place is much better. Just need to make sure we test for correctness in the CI (by test deployment, or linting if that is an available option).

Regarding the build tests in the CI, I see three options

One clear goal is that the PyPI and conda distributions are the same/consistent/identical, and that there is minimal overhead in maintaining that.
One route to making the deployment identical is to deploy to PyPI and then deploy conda from PyPI which is what condo-forge does.
We’re running our CD for PyPI and conda from the same repo so we can orchestrate it to build the package locally and deploy to PyPI and then build conda from the same local version of the built package directly, rather than downloading it from PyPI. Right? That corresponds roughly to your option 2 I believe?
I can't see a lot of downside to that.

One route to making the deployment identical is to deploy to PyPI and then deploy conda from PyPI which is what condo-forge does.

This is what I've currently set up in CD.yml and it should work for releases. But we wanted to also add test builds to CI.yml to catch issues early. Obviously we don't want to upload to PyPI as part of this (because that would be a release), so I've tried to upload to TestPyPI. Unfortunately the trusted publishing is failing when trying to upload to TestPyPI. I don't understand why - others are doing this successfully, e.g. xarray.

I can't see a lot of downside to that.

Yeah, I don't think there's a downside. I liked the idea of also testing the upload using TestPyPI and got fixated on why it's not working. I'll try creating a new PyPI account and if that doesn't fix the issue I'll give up.

Okay, I gave up on trying to test the upload via TestPyPI. The conda build is now being done from local source, rather than from the PyPI build. So not that much has actually changed in the end. I'll edit the original description to be accurate about what's changed and then I think I'll leave it there.

Ugh sorry, did my OCD changing of the title dismiss your reviews @aidanheerdegen and @jo-basevi?

Looks like it eh?


add messaging for using in Sydney and IAM

Please at least add a message for how to use with IAM. To do so, two things are needed.

Update app.js to look for url and api-key instead of username/password

url: process.env.ASSISTANT_URL || '<url>',
 iam_apikey: process.env.ASSISTANT_IAM_APIKEY || '<iam_apikey>',

Update .env to give this info

# Environment variables
WORKSPACE_ID=<workspace-id>
ASSISTANT_URL=https://gateway-syd.watsonplatform.net/assistant/api
ASSISTANT_IAM_APIKEY=<api-key>

Eventually we need to update the app to just work for all regions/authentications, but that can come over time

@stevenpkg Can you look into this?

@mitchmason I can look into this, may be we can we can leave username and password, but if you fill out .env with URL and IAM_APIKEY it will use that?

Yes please do not break what is already working in the us and Germany. You can just add a note to the readme of what I said above.
Or if you can make it so it uses whatever you provide that would be great, but obviously more work on your guys side.
We should do this for all the sample apps as well for anyone in Sydney.

@michelle-miller From what I can see you do not need ASSISTANT_URL?
var watsonAssistant = new AssistantV1({
version: '{version}',
iam_apikey: '{iam_api_key}'
});

The url for Sydney is different so I’m pretty sure it currently assumes us south. For iam it’s in Sydney

This has just grown... us east also uses IAM, and we need instructions for using across all different regions and auth processes.

Until I add the extra IAM parameters in the .env and add the code to use it, no Assistant demos can use IAM API key. Once in, you should just need your IAM API-KEY and URL for the region.

This has been completed. See https://github.com/watson-developer-cloud/assistant-simple/pull/175

Thanks @stevenpkg. @mitchmason can you please confirm this is done and sample apps are good for RC/IAM?

At a glance it looks good. If I hear any negative feedback we can reopen

I will work on Car Dashboard next


Ability to create profiles

This will resolve #54

@Cesan Please look into most of it's changed code base, because this branch was a bit older. Just to make sure!


DevSite Import: Client Secrets

Notice: This DevSite page will soon be deleted per b/133171590. Please add this sample to GitHub if it is relevant still:
https://developers.google.com/api-client-library/python/guide/aaa_client_secrets

Client Secrets

    The Google APIs Client Library for Python uses the
    client_secrets.json file format for storing the
    client_id, client_secret, and other OAuth 2.0 parameters.

    The client_secrets.json
    file format is a JSON formatted file
    containing the client ID, client secret, and other OAuth 2.0 parameters.
    Here is an example client_secrets.json file for a web application:

{
  "web": {
    "client_id": "asdfjasdljfasdkjf",
    "client_secret": "1912308409123890",
    "redirect_uris": ["https://www.example.com/oauth2callback"],
    "auth_uri": "https://accounts.google.com/o/oauth2/auth",
    "token_uri": "https://accounts.google.com/o/oauth2/token"
  }
}

    Here is an example client_secrets.json file for an installed application:

{
  "installed": {
    "client_id": "837647042410-75ifg...usercontent.com",
    "client_secret":"asdlkfjaskd",
    "redirect_uris": ["http://localhost", "urn:ietf:wg:oauth:2.0:oob"],
    "auth_uri": "https://accounts.google.com/o/oauth2/auth",
    "token_uri": "https://accounts.google.com/o/oauth2/token"
  }
}

    The format defines one of two client ID types:

web: Web application.
installed: Installed application.

    The web and installed sub-objects have the following mandatory members:

client_id (string):
      The client ID.

client_secret (string):
      The client secret.

redirect_uris (list of strings):
      A list of valid redirection endpoint URIs.
      This list should match the list entered for the client ID on the
      API Access pane
      of the Google APIs Console.

auth_uri (string):
      The authorization server endpoint URI.

token_uri (string):
      The token server endpoint URI.

All of the above members are mandatory. The following optional parameters may appear:

 client_email (string) The service account email associated with the client.
 auth_provider_x509_cert_url (string) The URL of the public x509 certificate, used to verify the signature on JWTs, such as ID tokens, signed by the authentication provider.
 client_x509_cert_url (string) The URL of the public x509 certificate, used to verify JWTs signed by the client.

    The following examples show how use a client_secrets.json file
    to create a Flow object in either an installed application
    or a web application:

Installed appWeb server appMore

from google_auth_oauthlib.flow import InstalledAppFlow
...
flow = InstalledAppFlow.from_client_secrets_file(
    'path_to_directory/client_secret.json',
    scopes=['https://www.googleapis.com/auth/calendar'])

import google.oauth2.credentials
import google_auth_oauthlib.flow

flow = google_auth_oauthlib.flow.Flow.from_client_secrets_file(
    'path_to_directory/client_secret.json',
    scopes=['https://www.googleapis.com/auth/calendar'])

flow.redirect_uri = 'https://www.example.com/oauth2callback'

Motivation

  Traditionally providers of OAuth endpoints have relied upon cut-and-paste as
  the way users of their service move the client id and secret from a
  registration page into working code. That can be error prone, along with it
  being an incomplete picture of all the information that is needed to get OAuth
  2.0 working, which requires knowing all the endpoints and configuring a
  Redirect Endpoint. If service providers start providing a downloadable
  client_secrets.json file for client information and client libraries start
  consuming client_secrets.json then a large amount of friction in implementing
  OAuth 2.0 can be reduced.

The docs are now added to the docs/ folder.
Fixed with #706.

The docstrings in flow.py and helpers.py still link to https://developers.google.com/api-client-library/python/auth/aaa_client_secrets and need to be updated to point to docs/client-secrets.md


Updated the README file.

I've added :

About section
Getting started section
Contribution Guidelines section
Launch the app section
Screenshots

the following sections to the README file.
Related Issues

Closes #
Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

Hi, this is my first PR.


docsUpdate flink-doris-connector.md

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


It should be possible to refine DOM Node using nodeType

Current libdef for dom does not allow refinements of nodes via nodeType property which makes it really difficult to use flow for DOM intensive code. Here is [an example] also inlined below for convenience :
/* @flow */

const serialize = (node:Node):string => {
  switch (node.nodeType) {
    case Node.ELEMENT_NODE:
      return `<${node.localName}>`
    case Node.TEXT_NODE:
      return `#text ${JSON.stringify(node.data)}`
    default:
      return ''
  }
}

In reality it's a valid code but flow will fail to type check with following errors:
return `<${node.localName}>`
                         ^ property `localName`. Property not found in
6:       return `<${node.localName}>`
                    ^ Node
8:       return `#text ${JSON.stringify(node.data)}`
                                             ^ property `data`. Property not found in
8:       return `#text ${JSON.stringify(node.data)}`
                                        ^ Node

Problem is that DOM spec defines Node as this abstract interface that all node types implement, but then it also uses this abstract Node interface in many API as a type union for all the actual node types. There for I think libdef should have one abstract class definition for Node that Element, Text and others inherit from and a separate type Node that is union of Element, Text, ...etc with nodeType sentinel property.

Duplicate of https://github.com/facebook/flow/issues/1032


[plugin:vite:import-analysis] failed to parse source for import analysis because the content contains invalid js syntax.

[plugin:vite:import-analysis] failed to parse source for import analysis because the content contains invalid js syntax. if you are using jsx, make sure to name the file with the .jsx or .tsx extension.
I have a older project, have many js file。 when i use vite , there is some error

vite version: 2.0.5
Node version: 12.5

You need to use .jsx as the extension for JSX files.


[JS] createSession ignores custom sessionId

Describe the bug
Genkit.createSession() always generates a UUID and ignores sessionId option
To Reproduce
Steps to reproduce the behavior. Code samples.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Runtime (please complete the following information):

OS: [e.g. Linux, MacOS]
Version [e.g. 22]

** Node version

run node --version at paste here

Additional context
Add any other context about the problem here.

+1 notice the same behaviour in 0.9.12


S2 tabs

There are no designs for vertical tabs so everything is just a guess of how it might look like based on V3. We can choose to pull this out and not support it for right now until they release some designs for it.

Don't know if you saw this issue at all? https://github.com/adobe/react-spectrum/blob/main/packages/%40adobe/spectrum-css-temp/components/tabs/index.css#L83 I don't see it, but might need a bit of chasing down to remember what it was. Or see if removing it in v3 still causes it.

so i tried reproducing on safari and it doesn't seem to happen anymore? didn't notice any difference between having it and removing it so maybe it's been fixed in newer version of safari since this line was added 3 years ago.

I think focusRing has a bug, I think its outlineWidth and outlineOffset should both be [2px]

oh are you saying that rather than focus ring being outlineWidth: 2 is should be outlineWidth: '[2px]'

Happy to have anything else be followup, I think we can get started testing this

✅ (since I cannot approve)


Options not saving properly in state when creating or editing a component

Describe the bug
When creating or editing a component, if you try to change two options, the second option will reset all of the other options.
As far as I can tell this is an issue with the options reducer on line 18 It looks like it's trying to get the options from the state object:
const { selectedComponent } = state; const { options } = state;
Which is returning undefined, as the options exist on the selected component, not the state:
const { selectedComponent } = state; const { options } = selectedComponent;
To Reproduce
Steps to reproduce the behavior:

Run yarn
Run yarn build
Run yarn designer dev
Navigate to the designer in the browser and choose an existing form or create a new one
Add a text component or edit an existing component
Tick the "Hide title" box, then tick the "Make text field optional" box. You'll notice the "Hide title" box will become unticked

Expected behavior
When choosing one or more options, all options should remain chosen.
Repository

Designer

Desktop (please complete the following information):

OS: MacOS 11.2.1
Browser: Chrome
Version: 92

Hey @ziggy-98 - thanks! Happy for you to open a PR for this. Let me know if you need a hand 🌟 - I probably wont be able to work on this myself for a while.. got a few other things in my backlog!

Hey @jenbutongit - cool cool, I've fixed this locally so I'll push the change up and submit a PR at some point today 😄

thanks! you should have permissions, so it will be easier if you create a branch on this repo rather than open a PR from a fork

#645


Manipulate Meshless Entities (Cameras, Lights, etc.)

this is a simple implementation that creates a sphere for each of the cameras and lights within a scene such that they can be interacted with.
I placed these meshes only on the last render layer so the editor camera can see them, but for other cameras (which I assume are not using all the render layers) it is invisible.
This addresses #103

Is this ready to review?

I placed these meshes only on the last render layer so the editor camera can see them, but for other cameras (which I assume are not using all the render layers) it is invisible.

Only editor uses all render layers, so all good. But we have not finished organizing the layers yet.

Is this ready to review?

I placed these meshes only on the last render layer so the editor camera can see them, but for other cameras (which I assume are not using all the render layers) it is invisible.

Only editor uses all render layers, so all good. But we have not finished organizing the layers yet.

Yeah I think that this is good for review but also to gauge what the goals of this should be.
I believe that having blank white spheres for lights, cameras, etc. is fine but not perfect. In Unity AFAIK it uses a flat image for these things that can then be moved.
So what I want to get from this is to understand if this is good enough as is functionally or if there should be other changes that should occur to make this more finalized.

So what I want to get from this is to understand if this is good enough as is functionally or if there should be other changes that should occur to make this more finalized.

My opinion on this is:

This is a nice start
Unreal, Godot, Blender and Unity are standards, so having what one of them has is a good benchmark
I like how unreal uses wireframes to project light, this seems to be consistent with our camera wireframe.
wait for @rewin123 opinion as well

Thanks for the interesting pull request!
Overall, the PR looks functional for the most part. The proposed solution is elegant, I like it. Perhaps it is possible to dedicate a final render layer for all the utility information, as a further development.
However, to merge the PR with the main branch, the following changes are required to make the functionality meet the minimum requirements:

[ ] Do not add meshes to objects that do not contain a PrefabComponent (since there are always hidden editor service objects that should not be visualized normally).
[ ] Spheres are currently visualized on the Camera view tab, although they should not be.
[ ] Need to fix the errors mentioned in the review code (meshes are reattached every frame, and also the entity position is overwritten every frame, which can lead to the situation when it is impossible to change the entity position).
[ ] It seems to me that if make the material spheres unlit, it will be better seen
[ ] All utility entities and components of the editor should be cleared when the editor goes to the game state
[ ] We need to add the ability to register any components as markers that the meshless object manipulation logic should be applied to the object.

Finally had a bit of time to work on this and have been making progress slowly on a bunch of fronts.
There is definitely more to do, the first I want to work on is not rotating the 3d sprites that are being used but to actually billboard them. The rest of the requirements I have following that, with the registering of foreign types and entities coming next most likely as I have a bit of scaffolding for it as is.
As per usual, if you want to provide any other feedback please do as I am willing to grind away at this until it is right (or better at least).

@MickHarrigan thank you! If you need support in anything, please contact us

Now that #162 has been merged, one of the issues that I had (the light and camera icons appearing below the grid) is no longer an issue!

Now that #162 has been merged, one of the issues that I had (the light and camera icons appearing below the grid) is no longer an issue!

I'm quite excited to see this PR evolving. Congrats

Try to review on this week

Awesome work! I reviewed all and all looks good.
I will fix merge conflict recently and will accept this PR

Awesome work! I reviewed all and all looks good.
I will fix merge conflict recently and will accept this PR

before that happens, I just found out that something is a bit messed up in the examples that makes the scenes not load in correctly. My guess is that it has to do with the new loading state for bevy asset loading so I will look into that now.

After doing a small amount of digging I found that it seems to only affect the platformer example as the function configure_editor() sends a MenuLoadEvent that cannot be read in time as the editor is still in the loading state at the time that it is sent, then it is lost. The short term fix is to run the editor config only on entering the editor state, or maybe having it built into the menu load event itself to have it only read at the right time? Either way with this being merged in the coordination of the editor loading and running states may need to be figured out as well.

My recent commit addressed this in just setting the system to start on the editor state transition and not app startup.
Additionally I did merge upstream so this should be good to go!

LGTM

I tested this. Seems working.
Thanks for awesome PR!