Maintenance Release: Forces And Motion Basics 2.1.12-rc.1 phet-io

@samreid @kathy-phet @DianaTavares @jessegreenberg(responsible dev), FAMB is ready for a maintenance release.
This version is to support a study that begins this Friday, Sept 21st.
This republication only has one change. It removed the "close warning" that occurs when recording to metacog. To test these changes, QA will want to do all steps under the "Third" heading in the previous QA issues but instead use this updated recording link.  There is one main exception now, as there will not be a prompt before leaving the page, instead you will just go back/exit immediately. This is expected and desired.
Here is the link to use to record with:
https://phet-dev.colorado.edu/html/forces-and-motion-basics/2.1.12-rc.1/wrappers/iframe/iframe.html?url=../login/login.html?screens=2.3&wrapper=record&validationRule=validateDigits&encryption=encryptNumberV1&numberOfDigits=7&promptText=This is a test, have fun qa&publisher_id=5d4c8ae1&key_name=phet-study_2018_q4&widget_id=forces-and-motion-basics-qatest2&phet-io.emitInputEvents=true&phet-io.emitStates=true&phet-io.emitStatesInterval=60&launchLocalVersion&metacog
Here are the variables I would like to test on:

throttled recording speed (maybe 3? normal, slow, very very slow)
browsers
devices (no need for tablets)

Please make a few recordings to each, request them, and then use this playback wrapper (same as the previous one) to ensure that the recordings are entact.
A few notes:

@KatieWoe you can use the same application_id as last time, though let me know if you need it again.
I set a new recording id (widget_id) so you shouldn't get any sessions you recorded in the other link.

We are mainly interested to note that (a) the recordings are working well, and (b) on slower connections they are not being clipped off too early, i.e. there are too many events that haven't been sent when the browser tab is closed.
@ariel-phet please assign and prioritize.

Here is the link to this version's wrapper index: https://phet-dev.colorado.edu/html/forces-and-motion-basics/2.1.12-rc.1/wrappers/index/

[ ] Win 10 Chrome Fast

[ ] Win 10 Chrome Medium

[ ] Win 10 Chrome Slow

[ ] Win 10 Firefox Fast

[ ] Win 10 Firefox Medium

[ ] Win 10 Firefox Slow

[ ] Win 10 Edge Fast

[ ] Win 10 Edge Medium

[ ] Win 10 Edge Slow

[ ] Mac OS 10.13 Chrome Fast

[ ] Mac OS 10.13 Chrome Medium

[ ] Mac OS 10.13 Chrome Slow

[ ] Mac OS 10.13 Firefox Fast

[ ] Mac OS 10.13 Firefox Medium

[ ] Mac OS 10.13 Firefox Slow

[ ] Mac OS 10.13 Safari Fast

[ ] Mac OS 10.13 Safari Medium

[ ] Mac OS 10.13 Safari Slow

[ ] Chrome OS Fast

[ ] Chrome OS Medium

[ ] Chrome OS Slow

@zepumph any other combinations you want  us to test?

Yes that looks great. For each one, it would be best if right before stopping the recording, you recorded something very noticeable (like three checkboxes in a row). That way we know if definitively if events got clipped off (one of the checkbox clicks wasn't there).

@KatieWoe current top priotiy, especially given the time sensitive nature

QA is done.  Everything checked looks fine.
Amount of Time Lost for unchecked boxes (out of 4 minutes):
Medium Win 10 chrome = 3:45
Slow Win 10 chrome = 2:45
Medium Win 10 firefox = 2:55
Slow Win 10 firefox = 3:50
Medium Mac chrome = 1:40
Slow Mac chrome = 3:00
Medium Mac firefox = 3:00
Slow Mac firefox = 3:50
Medium Mac safari = 3:10
Slow Mac safari = 3:40
Fast Chrome OS = only 2 or 3 seconds
Medium Chrome OS = 1:45
Slow Chrome OS = 2:10
Note:  The dev tools or apps used to throttle varied for each platform, so differences may be due to amount individual dev tools throttled, rather than the platform itself.

@KatieWoe and I looked into what "slow/medium/fast" meant on a few platforms, and here are some speed tests we (mainly she) did.
Chrome for me:
throttle ping down up
normal: 67 80.71 9.16
fast 3g: 68 1.50 .54
slow 3g: 12 .39 (crashed speedtest)

For @KatieWoe:
chrome normal: ping 4ms Down 135 Mbps Up 162 Mbps
chrome medium: ping 2 ms Down 1.49 Mbps Up .54 Mbps
chrome slow: ping 2 ms Down .39 Mbps Up .28 Mbps

safari:
Medium Downlink: Bandwidth 780 kbps Delay 100 ms
Medium Uplink: Bandwidth 330 kpbs Delay 100 ms
Slow Downlink: Bandwidth 240 kbps Delay 400 ms
Slow Uplink: Bandwidth 200 kbps Delay 400 ms

Firefox normal Ping 3 ms D 154.31 Mbps U 152.2 Mbps
Firefox medium Ping 3 D 136.22 U .25
Firefox slow Speedtest gave me a latency test error

We have decided that there is too much data loss for us to publish this. Thanks QA for all your hard work! We will test another workaround (hiding the sim frame on closewarning) in #190. Closing.


Multiplier stays the same for all hashers on certain case

Hi,
We are debugging one incorrect result issue in hash aggregation, and found if we increase max distinct like below, the result became correct.

I see distinctOverflow_ will be set true if this value is reached, but do not know what is expected to happen after that. Would like to provide some more information?
Related code: VectorHasher.h.

cc @FelixYBW

@rui-mo Rui, would you provide a small test case that illustrates the problem?

The following assumption may no longer hold after the change you made.
  // NOTE: 'kMaxDistinct' is a small value so no need to check overflow for
  // reservation here.
  return std::min<int64_t>(
      VectorHasher::kMaxDistinct, numDistinct * (1 + (reservePct / 100.0)));

@rui-mo Rui, would you provide a small test case that illustrates the problem?

Thank you Masha. Will try that. I saw from below comment that if this value was reached would revert to regular hash, but did not find the related code. Could you show me the code on that? Thanks.
// Stop counting distinct values after this many and revert to regular hash.
  static constexpr int32_t kMaxDistinct = 100'000;

@rui-mo Rui, checkout HashTable<ignoreNullKeys>::decideHashMode method in velox/exec/HashTable.cpp

Hi @mbasmanova @oerling, we are debugging this issue these days, and below are some findings.
This aggregation is a final sum, with 7 string and 1 int columns as grouping keys and 1 double column for sum aggregation.
-- Aggregation[FINAL [n0_0, n0_1, n0_2, n0_3, n0_4, n0_5, n0_6, n0_7] n1_8 := sum(ROW["n0_8"])] -> n0_0:VARCHAR, n0_1:VARCHAR, n0_2:VARCHAR, n0_3:VARCHAR, n0_4:VARCHAR, n0_5:VARCHAR, n0_6:VARCHAR, n0_7:INTEGER, n1_8:DOUBLE

The input row vector has 14099 rows, and below is part of its input data.

When deciding hash mode, this case enters the last case at HashTable.cpp#L1297, and the values for deciding hash mode are as below, from which we could see only distinctsWithReserve is not kRangeTooLarge.
numNew: 14099, bestWithReserve:<PHONE_NUMBER>3709551615, distinctsWithReserve:<PHONE_NUMBER>3289322184, rangesWithReserve:<PHONE_NUMBER>3709551615

The hash mode is set as kNormalizedKey, but in this case, the function setHasherMode, which will update the multiplier_ for a vector hasher as HashTable.cpp#L1207-L1209, is not called. Therefore, the multiplier_ stays 1 for all the hashers of the grouping columns.
When computing ids at GroupingSet.cpp#L181, the id of a later grouping column will always overwrite the previous one at VectorHasher.cpp#L240 because hashers' multiplier_ are all 1. In above case, because the last grouping column has a constant value of 2002, the ids for the rows all become 1 and are treated as the same during probe at GroupingSet.cpp#L207. Therefore, we finally got a single-row output for this aggregation which was not correct.
We tried to call the setHasherMode function before setting it to be normalized key mode at HashTable.cpp#L1297 and found it worked for this case.

Do you have any advice for us? Glad to hear your opinions!
cc @FelixYBW

@rui-mo Rui, I was on vacation and just came back. It would be helpful if you could provide a reproducible test case. Perhaps, use VectorSaver to store the test data in a file: https://facebookincubator.github.io/velox/develop/debugging/vector-saver.html

CC: @xiaoxmeng

@rui-mo Rui, I was on vacation and just came back. It would be helpful if you could provide a reproducible test case. Perhaps, use VectorSaver to store the test data in a file: https://facebookincubator.github.io/velox/develop/debugging/vector-saver.html

Thank you Masha, I will try harder to reproduce. Could you help take a look if our fix is generally reasonable at code level? Thanks for your help.

@rui-mo Will take a look tomorrow.
CC: @oerling @xiaoxmeng @spershin

@rui-mo The change you propose looks good.

@mbasmanova Masha, thank you. With PR#3450, this issue can be reproduced by running below unit test. Would you like to take a look? Thanks.
TEST_F(NativeParquetTableScanTest, agg)

@rui-mo Thank you, Rui. Here is a fix: #3526

@rui-mo Thank you, Rui. Here is a fix: #3526

Thank you!


Question: Does anyone have config files for nginx or apache setups for hortusfox

I have the site working with the internal server but want to set this up alongside my grocy install on a vps and I am having trouble getting things to work with both nginx and apache2.
With nginx I have everything working (it seems anyway) except the admin page (well plant history isn't working but I am pretty sure that is just a db issue). When I click on the tabs the location bar shows the admin?tab= but the view stays on the Environment tab.
With apache2 I can bring up the main page but can't go to any other pages. All I get is page not found when selecting anything else.
If someone could point me to some documentation I can read I would appreciate it.
Thanks in advance,
Brian

I haven't worked with nginx yet, so I can't say anything. But I have worked with apache on Ubuntu. Can you post your VirtualHost config?

Thanks,
My apache2 config is just a very basic couple of lines from a simple example. I'll investigate the AllowOverride and work on getting the config right while waiting for the next release to come out. I can use the internal server while I am testing things so it isn't a big deal. I'll keep working at it.
With the self hosted web app grocy I worked on it 2 weeks with lighttpd before figuring out that it was lighttpd that was just to limited for it so switched to nginx. Now with nginx so dependant on external programs I may have to focus on apache.
I know this is configuration on my end and has nothing to do with hortusfox.
Thanks again,
Brian
(I've taken up way too much of your time, sorry for that)

Using the information you provided I still couldn't get it to work but it turns out I hadn't activated the rewrite mod. Once I did that, along with the changes from your information, it worked just fine.
sudo a2enmod rewrite
Thanks again for being patient with me and providing so much information.
Regards,
Brian


Base class for Integ test; add integ test for NeuralSparseSearchTool

Description
Base class for Integ test; add integ test for NeuralSparseSearchTool
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ready for review

@zhichao-aws Thanks for your effort. Since we are planning to use remote inference, can you add a function for registering connector?

@zhichao-aws Thanks for your effort. Since we are planning to use remote inference, can you add a function for registering connector?

Sure.


TreeView: Clicking on node does not collapse child nodes on first click

Hi,
In the TreeView component when I click on an opened node for the first time, the icon changes to collapse icon arrow but the child nodes do not collapse. When I click on the parent node second time it works as expected but the collapse arrow icon is not in sync.
https://metroui.org.ua/treeview.html

Thanks, fixed in 4.2.38

@olton  Looks like this issue have resurfaced again. Can you please check.

@mahichr where you find an error?

Node open/close when user double click on node name or click on toggle


Forcing format of an "empty" module

I'm bumping into a corner case that gives me a bit of headache: in Angular2 we've got a file that has only TypeScript interfaces export. Such file, when transpiled to ES6 comes out empty (rightly so). Now, the problem is that when such an empty file is bundled with other files (it gets bundled since there are references to interfaces from other files) systemjs/builder auto-detect the empty file as "global".
Is there is a way of letting systemjs/builder know that such file is really using "es6" format? I was trying to do:
var bundleConfig = {
  paths: {
    "*": "dist/js/prod/es6/*.js"
  },
  meta: {
    '*': {
      format: 'es6'
    }
};

but it doesn't seem to have much effect (that is - auto-detection still kicks in).
Any advice here?

Hmm, I can see that I can easily force format using exact module name:
meta: {
    'angular2/src/router/route_definition': {
        format: 'es6'
      }
    }

but this is rather fragile.
Is there any support for globs build in for meta settings? Or shell we list all the modules for which we want to force format?

Arbitrary use of wildcard * is supported in meta configuration - can that work for you here?

System.config({
  meta: {
    'angular2/src/*': { format: 'esm' }
  }
});

@guybedford thnx for coming back to me on this one. I've just tried and can't make wildcards to work. Maybe it is due to the fact that we are using older version of the builder (0.10.6)?
If you could point me to a place where meta-data are resolved / format decided for a given module, I could debug on my end.

Ah right, yes wildcards are only supported in builder 11+. You'll have to list the files manually then unfortunately.

It could also be possible to add a custom extension at build time to the loader -
var loaderLocate = builder.loader.locate;
builder.loader.locate = function(load) {
  if (load.name.indexOf(path.resolve('angular2/src/')) 1= -1)
    load.metadata.format = 'es6';
  return loaderLocate.call(this, load);
}

OK, we are going to migrate to a newer version of a builder then. AFAIK we need to do this for System.register performance.
Thnx for your super-fast and effective support @guybedford !

Sure! Just ping me if you need any help at all with the upgrade.


Update main.js

Sir I have added few data under free courses with certificate from Coursera. Please go through it .Thank you for your valuable time
Thank you😊

hey Akshra we are adding only free courses with certificates, find any free certificate to add

Good evening sir
The actually the courses are for free just we need to apply for financial
aid which is mentioned just beside the enroll button
Should I mention it by commenting on it??
Or should I change the whole content??
Thank you sir for reaching out me . I'm really greatfull
Thank you
On Fri, Oct 7, 2022, 17:46 Avinash Singh @.***> wrote:

Closed #180
https://github.com/avinash201199/Free-courses-with-Certificates/pull/180
.
—
Reply to this email directly, view it on GitHub
https://github.com/avinash201199/Free-courses-with-Certificates/pull/180#event-7543112692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATNB2XXAMUOLD55BCS3DB7LWCAIA5ANCNFSM6AAAAAAQ7MSPBA
.
You are receiving this because you authored the thread.Message ID:
<avinash201199/Free-courses-with-Certificates/pull/180/issue_event/7543112692
@github.com>


nothing happen after click the url in 1.18.0-insider

VSCode Version:1.18.0-insider
OS Version:win 10 1709

Steps to Reproduce:
1.Ctrl + click the url
Reproduces without extensions: Yes

Also not working in my environment:

VSCode Version: Code - Insiders 1.18.0-insider (c1e079b6ccfad9ead105c44a84e862ffc5250222, 2017-10-25T04:18:36.616Z)
OS Version: Windows_NT x64 6.1.7601

This got fixed with the next insider build.


SpringDelegatingLambdaContainerHandler should reuse AsyncInitializationWrapper

Lambda has max. 10 seconds for init which is handled in https://github.com/spring-cloud/spring-cloud-function/blob/14160f8201424d532c7e19e83853ac87ccc0f829/spring-cloud-function-adapters/spring-cloud-function-serverless-web/src/main/java/org/springframework/cloud/function/serverless/web/ServerlessMVC.java#L109. Currently if the init e.g. takes 15 seconds, the initial request fails while it works for the other older handlers.
Let's reuse AsyncInitializationWrapper and remove the thread from ServerlessMVC. I already introduced a minimal InitializableLambdaContainerHandler interface so it's easier to reuse it.

Looking

LGTM. That is what I was saying about the callback - SpringDelegatingInitHandler

Yes.


E2E test with a small UI5 application

There are some many possible combinations of options that it would be interesting to add to the test suite an E2E test with a real UI5 application (it might be training-ui5con-18).

Again for 3.3.2, see #64

Implemented JS and TS examples, covering legacy, legacy + remote, remote with or without coverage


updating parent pom to be reasy for java 9

This is only bumping the plugin versions which is fine but there are more things to change in order to achieve Java 9, also it would be good to verify that this is not breaking anything in our current projects

the important piece here is updating the maven compiler plugin, the changes to java 9 themselves will be done in the projects.


Cannot upload debug symbols for Android to crashlytics

[READ] For Firebase Unity SDK issues, please report to Firebase Unity open-source
Once you've read this section and determined that your issue is appropriate for this repository, please delete this section.
[REQUIRED] Please fill in the following fields:

Unity editor version: 2020.3.37f1
Firebase Unity SDK version: 9.4.0
Source you installed the SDK: unitypackage(.unitypackage or Unity Package Manager)
Problematic Firebase Component: firebase cli (Auth, Database, etc.)
Other Firebase Components in use: None (Auth, Database, etc.)
Additional SDKs you are using: none(Facebook, AdMob, etc.)
Platform you are using the Unity editor on: linux ci, windows dev(Mac, Windows, or Linux)
Platform you are targeting: Android(iOS, Android, and/or desktop)
Scripting Runtime: IL2CPP (Mono, and/or IL2CPP)

[REQUIRED] Please describe the issue here:
Cannot upload symbols with firebase cli. The original symbols file is 2.7GB. Following some advice on unity forums, I removed dbg.so files and re-zipped the symbols. The result is a symbols file slightly over 300MB.
This all is happening in a ruby image in docker. I don't see any java binary installed, but this probably is bundled with the firebase cli.
I tried to upload with the following command:
firebase crashlytics:symbols:upload --app=<app_id> --token='<firebase_token>' ./symbols.zip
I get the following error:
i  Generating symbols for ./Fantastic_Battles-1.0-v3873.symbols.zip
⚠  An unknown error occurred
Error: java command failed with args: -jar,/root/.cache/firebase/crashlytics/buildtools/crashlytics-buildtools-2.9.1.jar,-symbolGenerator,breakpad,-symbolFileCacheDir,/tmp/crashlytics-8bfa47d0-5ad7-4a44-940d-801203314456/nativeSymbols/1-768264781817-android-d20c4070873c6fabe38728/breakpad,-verbose,-generateNativeSymbols,-unstrippedLibrary,./.symbols.zip,-clientName,firebase-cli;crashlytics-buildtools
The error occurs with both the original 2.7GB symbols file as well as the 300MB version I created (maximum zip, no dbg.so files).
Steps to reproduce:
Not sure how you can reproduce on your side.
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
What's the issue repro rate? (eg 100%, 1/5 etc) 100%
What happened? How can we make the problem occur?
Not sure how you can reproduce on your side. Happy to send the symbols file in a private message.
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:
// TODO(you): code here to reproduce the problem

Hi @nioan,
This issue appears to be more related to the Firebase CLI rather than the SDK, but the cause of this behavior could be related to the command you're using. Take note that the command for uploading symbols is
firebase crashlytics:symbols:upload --app=<FIREBASE_APP_ID> <PATH/TO/SYMBOLS>
You may refer to our documentation for more information. If the issue persists after making changes to your command, you may raise this to the Firebase CLI GitHub repository. Feel free to include any relevant information such as CLI version and latest error logs.


Update title of dcom-hardening-change-effect.md

Updating the title to emphasize the purpose of the article + make the link look better

Docs Build status updates of commit 177edb9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

support/mem/configmgr/dcom-hardening-change-effect.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@Yupiter2005 This PR is merged. Thanks for your contribution.


Update glob in stable cicd action

Update that probably should have happened before merging #15 😨

@nutjob4life oops! you are definitely right. please review again.

@nutjob4life feel free to merger these when you review them. Especially on projects you are closely tied to. 😎

Okay, I will act with a bit more authority in the future @jordanpadams !

@nutjob4life 🚔


connection center thing

check on new connection whether it creates a cycle and if it does, create a temporary polygon and find its center to create a new root node

this has been dropped due to us requiring extensive knowledge of discrete maths and graph theory, none of which we possess.


Authentication Flaw

The admin panel can be accessed without any login credentials. [Sign out button will be invisible]
Proof:
Just visit: http://admin.ilaro.net/Admin

Thanks for catching that.


Update log to use log action

Problem:
Restricted users were not able to view logs due to the use of
docker.sock
Solution:
Move log calls to use the log action for the container
Issue: https://github.com/rancher/rancher/issues/8020

LGTM


How to prevent publishing SNI dll when using AppContext switch for managed networking?

I have a framework-dependent single-file executable project that I would like to publish without having to bundle native libraries. I found the AppContext switch to use managed networking, which eliminates the need for the native SNI dll. However, when publishing my application, the SNI dll is always placed next to the executable, even though it is not actually used at runtime.
How can I best prevent the SNI dll from being published alongside the executable? I would be happy to hardcode a workaround into my csproj file, but I have not found a way yet to do this in a good way. The only workaround that I currently know of is to add a post-publish target that deletes the SNI dll, but that is not a very elegant solution.
On another note, it would be great if there was a compile-time configuration to switch between managed networking and native SNI. That way, the dependency on the native SNI dll would be entirely eliminated if managed networking is enabled.

Maybe this is possible with https://github.com/0xced/Chisel and <ChiselPackage Include="Microsoft.Data.SqlClient.SNI.runtime" />

Thanks for the suggestion, that looks promising. It looks like Chisel doesn't (yet) work with class libraries, which means I'd have to set it up for all of my executable projects. I only mentioned a single project but in reality there are many projects that are all consuming the same EF Core project. I'm trying to set it up with a Directory.Build.props file now, will update here if it works out.

It appears I've found out how to do this. Adding the following block into my Directory.Build.props file defines Chisel as a dependency for all executable projects, omits the SNI dll from all of those projects while also enabling managed networking. Perhaps I can add another condition to only do this if the Microsoft.Data.SqlClient package is a (transient) dependency, but I don't know how to write a conditional basd on other dependencies yet.
An interesting point: apparently it is possible to set an AppContext switch by using RuntimeHostConfigurationOption in MSBuild. I haven't seen it documented anywhere officially, so proceed at your own risk, but it seems to be working for us so far.
<ItemGroup Condition="'$(OutputType)'=='Exe'">
  <PackageReference Include="Chisel" Version="1.0.0">
    <PrivateAssets>all</PrivateAssets>
    <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
  </PackageReference>
  <ChiselPackage Include="Microsoft.Data.SqlClient.SNI.runtime" />
  <RuntimeHostConfigurationOption
    Include="Switch.Microsoft.Data.SqlClient.UseManagedNetworkingOnWindows" Value="true" />
</ItemGroup>

@Ririshi It looks like you've been able to find a solution, but I will bring this to the team to see if an alternative option is available.

Thank you, much appreciated.
While my suggested solution does work, it is a bit roundabout and feels hacky, because Chisel does not support dependency removal directly on class libraries. Enabling Chisel on all executable projects works, but some don't use my EF Core class library. This causes Chisel to generate build warnings saying that those projects do not have the SNI.runtime package in their dependency graph. I've disabled this warning (CHISEL002) for now using NoWarn.
As I said before, the best alternative in my opinion would be to have an MSBuild option that switches managed networking for the project in which it is set, as well as any projects referencing it. Ideally, it would work both for projects that directly reference M.D.SqlClient as well as projects that reference it as a transitive dependency, e.g. through EF Core.
The same could be said for Azure support, which is what Chisel was made for in the first place. That part might be irrelevant / off-topic though, since I also read something about creating separate packages to support on-prem and Azure separately.

the SNI .targets file have a variable as $(CopySNIFiles), can you try with your msbuild command and add
-p:CopySNIFiles=false to see the outcome?


Remove must_gather_shell function, call call_actions direct - 60

[Auto generated]
Number: [#60]

must-gather-explorer[pull_request][538f30d0-b557-11ef-8c6b-51c6cdb6485e][PR 60]: Closing issue for PR: Remove must_gather_shell function, call call_actions direct.
PR was closed.


Update readme

Updating the README for how APISnoop works today.
At this point, the PR is more a conversation starter.  The README is complete in structure, but the details can be filled out as needed.
I removed quite a bit from the existing README, wherever it seemed the info was outdated or irrelevant.  I may not have the necessary context/skills to accurately judge this, though, and so put everything I cut into the file READNOMORE.md, so we can discuss these sections nd potentially add them back in a modified form.

@zachmandeville: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: zachmandeville
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [zachmandeville]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This PR has a deceptive amount of commits.  IT was built off the work in #197 and #201 .  The commits should be more reasonable when these PR's are merged.

LGTM label has been added.  Git tree hash: 3d551baabb5b6d37fd3c3b524dae9a15c322f751

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hh, zachmandeville
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [hh,zachmandeville]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@zachmandeville: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

apisnoop-process-audits
9a0633cd216cfba41af8a2bcab6d2af565d83d7c
link
/test apisnoop-process-audits

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LGTM label has been added.  Git tree hash: fa567eca3fc8793b03f0f0bf4495f7bd1f51f3c3

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hh, zachmandeville
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [hh,zachmandeville]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: devaii, hh, zachmandeville
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [devaii,hh,zachmandeville]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@zachmandeville: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

apisnoop-process-audits
3dc3892a899801c6c712c9e6e927ee2e5534e699
link
/test apisnoop-process-audits

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Running Kafka-manager with JAAS conf on different node than broker (SASL_SSL)

Hi!
I am able to run Kafka-manager on a broker node using the following startup command:
  kafka-manager -Djava.security.auth.login.config=<path to kafka_client_jaaas.conf>

It works fine but I would prefer to  install kafka-manager on another node. in this case, how can I setup JAAS config file ? I tried to copy this file to the kafka-manager node but with no success.
Thanks for help!
Michel.

HeIlo!
Issue is solved. The path to the jaas conf file must be absolute.

can you share the contents of the JAAS file? Also all the settings you did to make this work?


Update to Ember 1.11(.1!)

remove bind-attr all over the place
includes one hack for a bug in 1.11, hopefully fixed in 1.11.1

Ember 1.11 release notes: http://emberjs.com/blog/2015/03/27/ember-1-11-0-released.html
^ Pretty important read, particularly the bit on htmlSafe and XSS in script/style context.

Happy with this now. Hopefully the tests agree with me

derp, ember 1.11.1 is out already, wipping

Does that mean the hack is gone? :wink:

no more hack! Sorry, i updated the commit but not the pr message
On Apr 5, 2015 7:21 AM, "Hannah Wolfe"<EMAIL_ADDRESS>wrote:

Does that mean the hack is gone? [image: :wink:]
—
Reply to this email directly or view it on GitHub
https://github.com/TryGhost/Ghost/pull/5094#issuecomment-89769897.

Sorry, I updated my previous message and you wouldn't have seen the additional questions by email:

Second question, why the back ticks? I think this is something to do with ES6 but a short explanation/link to a resource would be lovely.

Finally, this will need rebasing because I merged #5098 ;)

I've taken this PR for a very quick spin and it all seemed ok.

The back ticks are string interpolation, es6 feature. I did them because...
// I needed to build the entire string, then wrap that expression with parenthesis so that i could call a method on the result....
return ('background-image: url(' + this.get('foo') + ')').htmlSafe();
// equivalent, but more succinct eh
return `background-image: url(${this.get('foo')})`.htmlSafe();

Updated

And sorry, meant to make a link out of string interpolation


Pixel Phone Check Correlation Bug

On a Google pixel, in the experiment pathway, when a user goes through the “check image correlation” steps, the ability to select PIV parameters goes away. If the user does not select “check image correlation”, the ability to select PIV parameters etc. remains.

I'm not able to replicate this on Pixel 3, 4 (emulators) or Galaxy. Correlation animation and PIV parameters popup should be completely independent of one another, but I'll check the code to make sure.

How odd. I think the calibration is more important, but this was definitely a problem that didn't happen on my phone or the V40, but did happen on the pixel phone.

The only thing I found was some bad logic that could have possibly caused a gui crash. I've corrected the logic, but I'll keep this open until we know that was the issue.

Just to add here: I tested this on my Google Pixel 4 and didn't run into any errors. The ability to select PIV parameters remained for me.

We haven't seen an issue. Someone can open back up if they notice anything.


Type '{ foo: T1 | T2}' is not assignable to type '{ foo: T1; } | { foo: T2; }'.

TypeScript Version:  3.9.5

Search Terms:
Code
let sth: { a: number | string };
let sth_else: { a: number } | { a: string };
sth = { a: 1 };
sth_else = sth;

Expected behavior:
It should pass.
Actual behavior:
Type '{ a: string | number; }' is not assignable to type '{ a: number; } | { a: string; }'.
Playground Link:
https://www.typescriptlang.org/play/index.html?ts=4.0.0-dev.20200615&ssl=1&ssc=1&pln=5&pc=1#code/DYUwLgBAzmAWBcEDeECGiB2BXAtgIxACcIAfaMQgSwwHMIBfAbgChRIZYB9EYKERFOgjZ8RBqWRpEMKrQYsOEALyShARnnMO3XiGXlYLIA
Related Issues:

Duplicate of #8289.

It is true that { a: number | string } is neither { a: number } nor { a: string }, however, for this perticular case, all possible values of { a: number | string } is either { a: number } or { a: string }.
Plus the compiler knows here that the current value in sth is actually { a: number }.

@rbuckton I was surprised the logic you added around this didn't kick in here. What's happening?

The logic I added was specific to discriminated unions. In the above example, I don't think a is considered a discriminant.


(#915) fixed sending of mails

By removing the manual references to MimeKit, MailKit, MimeTypesMap,
and Cake.Email.Common and replacing them by adding "loaddependencies=true"
to the Cake.Email reference.
fixes #915

@nils-a your changes have been merged, thanks for your contribution 👍


Fixes #215 - Broken links on XM-CDP integration

URLs that linked to the old Boxever documentation page where no longer working
Description
Changed all URLs old Boxever documentation to new CDP documentation on doc.sitecore.com
Motivation
Fixes #215
How Has This Been Tested?
Local testing and Vercel preview environment
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Documentation update (non-breaking change; modified files are limited to the /data directory or other markdown files)

Checklist:

[X] I have read the Contributing guide.
[X] My code/comments/docs fully adhere to the Code of Conduct.
[ ] My change is a code change.
[X] My change is a documentation change and there are NO other updates required.
[ ] My change is a documentation change and it requires an update to the navigation.
[ ] My change has new or updated images which are stored in the /public/images folder that need to be migrated to Sitecore DAM

Fixed the developer.boxever.com link

Side note: Based on the commit comparisons, it looks like more than the links were changed in this commit. There is a significant amount of text changed in the integration guide as well. Has this been validated with somebody that this new text is the correct version of text to go with these new links?

This text originates from the integration guide hosted on the [CDP Knowledge Hub](https://sitecore.cdpknowledgehub.com/docs/integrating-experience-manager-with-sitecore-cdp} which already has the updated links

I've added @robearlam on the review list here to finish off review. The links look good to me, but @robearlam should double-check that the new version of the text taken from the CDP KB version is indeed the correct version of the text.

I was unaware that the CDp Knowledge Hub had been updated, but it makes sense for us to keep them aligned 👍
(This should probably start a conversation about the content living in two places, should the developer portal be the true home, or the Knowledge hub?)

@robearlam can you set that chat up with @markvanaalst and whomever we need from the CDP side to decide on this? My impression was that CDP KB was temporary only until the portal was launched.


stop buffering formpost POST body

It's buffering the full form POST before processing, which is bad.
This was something I accidentally left in while debugging.

This seems like a good idea. 👍


Data quality issue with CVE-2019-1387

The CVE ID
CVE-2019-1387
Describe the data quality issue observed
Git 2.43 is not affected (affects 2.24 and earlier), yet passing the Git 2.43 commit sha as input yields CVE-2019-1387 as a vulnerability.
curl -d \
  '{"commit": "564d0252ca632e0264ed670534a51d18a689ef5d"}' \
  "https://api.osv.dev/v1/query"

This is the head commit for Git 2.43:
commit 564d0252ca632e0264ed670534a51d18a689ef5d (HEAD -> v2.43.0, tag: v2.43.0, origin/maint)
Author: Junio C Hamano<EMAIL_ADDRESS>Date:   Mon Nov 20 08:47:38 2023 +0900

    Git 2.43

    Signed-off-by: Junio C Hamano<EMAIL_ADDRESS>
Suggested changes to record
Should affect 2.24 and earlier.
Additional context
Add any other context about the problem here.

The root cause here is this is a CVE that is actually no longer being generated (because no viable fixed commits could be determined) and it should be deleted/withdrawn. I am going to work on https://github.com/google/osv.dev/issues/1467 which will take care of this and any other such records.


CIV-14117 WA for final order

JIRA link
https://tools.hmcts.net/jira/browse/CIV-14117
Change description
Test PR for final order welsh translation task
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

This was for testing purposes only.


added cisco python course

This PR resolves the Issue #107
@avinash201199 Please review it and add labels for easier and better contribution
I feel labels make it more visible and appealing to review faster than normal
Requesting to take a look on this feature.

please resolve branch conflict

@avinash201199  I didn't got it where is conflict what should be changed.


[Feature] Host Entity Support for KQL Module

Add host entity support for the KQL module, similar to the ipEntities and accountEntities we have today.

Added in 26902bf
Deploy from test Branch


rename urlencode to urlencode2 stop calling inbuild function.  Added …

urlencode conflict with inbuild function raise error for signature validatiaon.
Added two more method for publish on topic and target

Can we rename the urlencode function to snsUrlEncode instead?

or probably _urlEncode to make it more for a global use case?


Nitpicking: new node positions of heat

How about if we move the deficit nodes from here:

To here:

I'm not a big fan of the overlapping edges.

👍

I agree that it looks a lot better like that!
There is a lack of space below the water heater technologies. How about the change as shown below?

You can also move all the other nodes down a notch, but I guess that's a bit hard to do with the current interface. It would be great if you could select all nodes with a "square" selection tool (instead of Alt+Click) and drag them down some way.
That position is fine by me though, as long as it is consistent with the water heater.

I agree that it would be nicer to move the other nodes down a notch.

That position is fine by me though, as long as it is consistent with the water heater.

It is


Support token management in UI

Request details
.

Cosmetic updates/enhancements for 3.x UI are currently deprioritized, due to planned full 4.x rewrite.
Moved to #2005


Using the rust benchmark instead of nodejs benchmark

https://github.com/speedy-js/rspack/pull/477

closed as resolved in https://github.com/speedy-js/rspack-sources/pull/16

https://github.com/speedy-js/rspack-sources/commit/77d131e419ac4e5fccbf48aed15d150151374a32#comments
According to this commit. comment, I don't this benchmark action is preferable.


Fix overscope group replace

This is to fix
[下午3:11] Feng Zhou
directive:
  - where:
      group: datashare share
    set:
      group: datashare

This configuration will replace datashare share-subscription  into datashare-subscription
The PR is trying to fix this issue.


Support plugins

Support plugin system.

Implement a <CustomSeries> component that will use IChartApi::addCustomSeries api.
Implement a <ChartEx> component that will use createChartEx api.
Implement a <SeriesPrimitive> component that will use ISeriesApi::attachPrimitive api.

The work on <CustomSeries> is almost done.
https://github.com/trash-and-fire/svelte-lightweight-charts/assets/69399722/b3e12fe0-e130-4800-9aec-a1182b744833

I published<EMAIL_ADDRESS>with the support of the custom series.
The example of usage you can find here

I published<EMAIL_ADDRESS>with the support of the series primitives.
The example of usage you can find here

I'm still not sure about the final API of the new components. When implementing vertical lines, it seemed to me that we needed to add more convenience. Perhaps I will change the API in the final versions.

Thanks for that, VerticalLines are exactly what I needed today.

The feature looks amazing but somehow this example does not work for me.
It can't resolve the IReactiveSeriesPrimitive dep:
    Module '"svelte-lightweight-charts"' has no exported member 'IReactiveSeriesPrimitive'

    "lightweight-charts": "^4.1.1",
    "svelte-lightweight-charts": "^2.3.0-rc-1"

besides could new VertLine(time) not be an exported member instead to not have to duplicate?

@go-dockly thanks. For some reason, a file was published without exported types. I'll publish again today when I get to the computer.

besides could new VertLine(time) not be an exported member instead to not have to duplicate?

I'm not sure I understood this phrase correctly, can you explain?

I published<EMAIL_ADDRESS>with exported IReactiveSeriesPrimitive

I took the implementation of vertical lines from the repository with plugin examples: https://github.com/tradingview/lightweight-charts/tree/master/plugin-examples.
Maybe I'll make a subsection with exports of plugin components something like:
import {VerticalLine} from 'svelte-lightweight-charts/plugins/vertical-line';

super thankful for your work here, i was just about to attempt to implement it myself before checking here <3


Language of the configuration files

The configuration files are not in YAML format as the readme say. I think it's TOML.

The configuration files are not in YAML format as the readme say. I think it's TOML.

Good point, I was also working on a Symfony project, so I might have mixed up some stuff ;)

Fixed :)


refactor: more precise rule for private keys

Description:
The current regex didn't match PGP private keys anymore, since they start with BEGIN PGP PRIVATE KEY BLOCK and the BLOCK never matched for the existing regex. I've made that part optional so that all strings matching for the current regex will still match for the new regex.
Checklist:

[x] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[x] Have you lint your code locally prior to submission?

@very-doge-wow could you follow the contributing guidelines and update this PR? Thanks!

@zricethezav Hi, I've changed the PR so that the rule can be generated. Hope it's correct this time.

@zricethezav Did you take look?

@zricethezav Ping


WORD: HYPERTROPHY

ISO paper for this feature: PaperID
First implemented in: VS 20YY major.minor

G-POWER.3.docx


verify causal masking

Hi @zhuzilin, follow up from https://github.com/zhuzilin/ring-flash-attention/issues/15
I just wanted to verify the causal, and I simply use loop because I dont have multigpus, but it should be working, when I do causal using your ring logic, the argmax accuracy is super low, but when I do non causal, accuracy is almost perfect 100%, you can check the notebook at https://github.com/mesolitica/context-parallelism-xformers/blob/master/playground/flash-ring-attention-causal.ipynb
From what I understand, let say, I got 2 devices and seqlen of 100k, partitioned to 2, 100k // 2 = 50k 50k, so,
each 50k seq len,
device 0: 50k q0k0v0
device 1: 50k q1k1v1
So the blockwise attention calculation,
device 0: 50k q0k0v0 + 50k q0k1v1
device 1: 50k q1k0v0 + 50k q1k1v1
(+) denoted as blockwise attention.
For causal base, attention mask is necessary, so the attention mask originally is [100k, 100k] and attention mask we must chunk properly, to become mask0 = [50k, 100k] and mask1 = [50k, 100k], so the blockwise attention calculation,
device 0: 50k (q0k0 * mask0[:, 0:50k])v0 + 50k q0k1v1 * mask0[:, 50k:100k]
device 1: 50k (q1k0 * mask1[:, 0:50k])v0 + 50k q1k1v1 * mask1[:, 50k:100k]
You can see this slicing from original https://github.com/forhaoliu/ringattention/blob/main/ringattention/ringattention_pallas_tpu.py#L61
Correct me if im wrong here, thanks!

This is to replicate the original jax implementation, https://github.com/mesolitica/context-parallelism-xformers/blob/master/playground/blockwise-vanilla-attention-causal.ipynb
I just simply generate global multiplier mask (lazy to do addition),
temp_mask = torch.ones(L, S, dtype=torch.bool).tril(diagonal=0).cuda()
attn_bias_blocks = torch.chunk(temp_mask, chunk_size)
attn_bias_block = attn_bias_blocks[0]
seq_chunk = Q.shape[0] // chunk_size
attn_bias_b = attn_bias_block[:, no * seq_chunk: (no + 1) * seq_chunk]
scores = torch.matmul(Q_block, K_block.T) * attn_bias_b

While original jax generate addition mask during blockwise,
def _chunk_attention_bias(query_chunk_size, key_chunk_size,
            bias, segment_ids, deterministic, attn_dropout, attn_pdrop, causal,
            dtype, query_chunk_idx, key_chunk_idx):
    query_offset = query_chunk_idx * query_chunk_size
    key_offset = key_chunk_idx * key_chunk_size
    chunk_bias = jnp.zeros((1, 1, 1, 1), dtype=dtype)
    if bias is not None:
        chunk_bias = lax.dynamic_slice(
            bias,
            start_indices=(0, 0, 0, key_offset),
            slice_sizes=(*bias.shape[:2], min(bias.shape[-2], query_chunk_size), min(bias.shape[-1], key_chunk_size)),
        )

    if segment_ids is not None:
        q_segment_ids = lax.dynamic_slice(
            segment_ids,
            start_indices=(0, query_offset),
            slice_sizes=(segment_ids.shape[0], query_chunk_size)
        )
        k_segment_ids = lax.dynamic_slice(
            segment_ids,
            start_indices=(0, key_offset),
            slice_sizes=(segment_ids.shape[0], key_chunk_size)
        )
        segment_ids_mask = q_segment_ids[:, :, None] != k_segment_ids[:, None, :]
        segment_ids_mask = segment_ids_mask[:, None] # B1QK
        segment_ids_bias = segment_ids_mask * jnp.finfo(dtype).min
        chunk_bias += segment_ids_bias

    if causal:
        query_idx = lax.broadcasted_iota(dtype=jnp.int32, shape=(query_chunk_size, 1), dimension=0)
        key_idx = lax.broadcasted_iota(dtype=jnp.int32, shape=(1, key_chunk_size), dimension=1)
        offset = query_offset - key_offset
        query_idx += offset
        causal_mask_value = (query_idx < key_idx) * jnp.finfo(dtype).min
        chunk_bias += causal_mask_value.reshape(1, 1, *causal_mask_value.shape)

    if not deterministic and attn_pdrop > 0.0:
        attn_dropout_slice = lax.dynamic_slice(
            attn_dropout,
            start_indices=(0, 0, query_offset, key_offset),
            slice_sizes=(
                *attn_dropout.shape[:2],
                min(attn_dropout.shape[-2], query_chunk_size),
                min(attn_dropout.shape[-1], key_chunk_size),
            ),
        )
        chunk_bias += attn_dropout_slice * jnp.finfo(dtype).min
    return chunk_bias.astype(dtype)
_chunk_bias_fn = partial(
        _chunk_attention_bias,
        query_chunk_size, key_chunk_size, bias, segment_ids, deterministic,
        attn_dropout, attn_pdrop, causal, dtype)
bias_chunk = _chunk_bias_fn(q_chunk_idx_start + q_chunk_idx, k_chunk_idx_start + k_chunk_idx)

any comment @zhuzilin ?

hmm... I'm not sure what you are aiming at. If you just want to be sure that this implementation supports causal mask, you can try running the code in the test folder.
The code in the repo is not a step by step transfer from the origin jax implementation and I actually haven't read that before...

hmm... there will never be a rectangular mask as all the k and q chunks will have the same sequence length. And there will also not be a mask with all False, which actually means doing no calculation...


Rendering outside of Livebook?

Can vega_lite be used to render graphics/charts outside of Livebook?
Like can I add this to a regular Phoenix application and generate/render a chart?
Looking at the docs I didn't see a way to do that.

@brainlid yes but the wiring is up to your self. In this case you would export it to the json spec and pass the json spec to the VegaLite code in JS land.

@brainlid if you figure it out and you want to send a PR for the docs, it will be very appreciated :)

@brainlid just yesterday I put together an example of that in this repo, let me know if that's what you're looking for :)

@jonatanklosko I think that's exactly what I was looking for! :smile: Thanks! You're awesome! :100: :1st_place_medal:


Fix syntax highlighting configure-pod-configmap.md

configure-pod-configmap.md has a shell command and it's yaml output in the same code block which breaks syntax highlighting. Broke these out into two code blocks with their appropriate code decorators.

/assign @bradtopol

/lgtm
/approve


Attribute proc-macro follow up

Fixes #35.
I added a note in the README, but noticed that actually setting the path can produce some pretty unexpected behavior.
What do you think of adding an error if a derive_where::derive_where is found as not the first attribute? This isn't bulletproof of course because derive_where_export::derive_where could still remain undetected.

I just stumbled on an idea. We could leave a marker to signify that this item was already handled by a derive-where macro. We control the outputted item, so we could just add a comment: /* derive_where was here! */. If that comment was found by a follow up proc macro attribute it could error out.

Actually I couldn't find a way to mark the item. Comments aren't represented in the AST apparently, only doc comments, and I can't figure out how to make a "hidden" doc comment, so it doesn't show up in the documentation by the user.
The other idea I had while writing this was to introduce another attribute called derive_where_visited, but it actually hits the same problem, it won't work without proper qualifying it unless it's imported by the user. We also don't have $crate for proc macros, see rust-lang/rust#54363, which would solve that problem.
So I think the best would be to introduce a hidden doc comment or find some other attribute that can be no-op. If you come up with anything hit me.

To solve the problem with derive_where_visited we could also introduce a crate setting: #[derive_where_::derive_where(crate = "derive_where_", Clone; T)]?

Let's figure out #37 before we decide to merge this.

Alright, re-based and adjusted to the latest changes we did in #37.

Build failed because of some connection issue, would be nice if you re-start it @ModProg.


Are combo charts possible?

Is there a way to have a single chart with different types of series?
For instance, here is one I created manually in Excel:

Hi. It's definitely possible. There're examples at https://github.com/cxn03651/write_xlsx/blob/master/examples/chart_combined.rb


Fixup

Coverage decreased (-0.08%) to 64.182% when pulling 759dd0288a30adeafc30ab3e9ce74b4ae07d78b9 on sigsbee:fixup into 2b799a576b806a6b120918466bff1954041dd97e on vmware:master.


Improve sentence tokenizer

I have the following example with nltk 2.0.4:
import nltk
text = 'He said: "No!" He said: "No!" and walked away.\nHe said: “No!” and walked away.\n\nHe asked: "Really?" He asked: "Really?" and walked away.\nHe asked: „Really?” and walked away. He asked: „Really?” and walked away.'
paragraphs = nltk.LineTokenizer().tokenize(text)
print 'Total paragraphs:', len(paragraphs)
for paragraph in paragraphs:
    sentences = nltk.tokenize.sent_tokenize(paragraph)
    for sentence in sentences:
        print sentence

This is the output:
He said: "No!
" He said: "No!
" and walked away.
He said: “No!” and walked away.
He asked: "Really?
" He asked: "Really?
" and walked away.
He asked: „Really?” and walked away.
He asked: „Really?” and walked away.

As you can see !" and ?" are not processed well. Can this be improved or fixed or what would be a workaround that will split these sentences according to the following pseudocode regex examples:
split
...[?!]" [A-Z]...
into
...[?!]"
[A-Z]...
and not into
..[!?]
" [A-Z]...
as it is doing now
and to not split
...[?!]" [a-z]...
because now it splits into
..[!?]
" [a-z]...

Could this please be reopened?


jsc.minify.format.inlineScript support

Describe the feature
https://swc.rs/docs/configuration/minification#jscminifyformat

input:
 "<script></script>"

expected output:
 "<script><\\/script>"

Are you willing to work on this yourself?
yes
Babel plugin or link to the feature description
https://github.com/terser/terser/blob/aeddfabd04ace5a6565b2920b074ad7dc210bcac/lib/output.js#L367
Additional context
No response

FWIW, the Terser implementation isn't complete, so the linked code isn't sufficient to make it completely safe.
I've filed an issue with Terser: https://github.com/terser/terser/issues/1408

I'm implementing this with a simple lookup of the latest printed stuff before printing.
For example I'm going to check if the output stream ends with "--" before printing the ">" operator. If it does, I'll add a space.

It looks like #8252 tried to fix this, but it doesn't seem to actually work.  I haven't dug deep into why, but at least in my use case I'm using swc as the minifier in a webpack build, where pre-minification it's got a.innerHTML="<script>\x3c/script>" (which comes from react-dom, so I'd expect this to be a fairly common thing for people to encounter), so I'm wondering if maybe the issue is one of order of operations between converting \x3c to / and  escaping / to \/.


inference_llama.py推理结果出来之后，对于结果是如何评分的？

Describe the question

A clear and concise description of what the question is.

Environment (please complete the following information):

OS: [e.g. mac / window]
Python Version [e.g. 3.6]

请参考https://tianchi.aliyun.com/competition/entrance/532080/information，评估指标


Aggregate json4s, fix one style issue, and change rule on another

I just noticed that the new json4s wasn't being aggregated, which is the only reason it wasn't crashing Scalastyle. It seems reasonable to allow json4s as a package name, so I changed that rule. Also fixed a misspelled file name.

Thanks @travisbrown! Good catch!


Placeholder PR for KEP-4265

/sig node

Hello @sohankunkerkar  :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday, July 16th, 2024 18:00 PST. Thank you!

Hi @sohankunkerkar, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

I'm closing this PR as the docs for this feature are already up-to-date.


Added Responsive Header

Added Responsive Header

don't use anchor tag use <Link to ={"/about"}>About Us</Link>


Measuring tool

Proposal to add a new widget to brainreg segment which can be used to measure distances/angles between arbitrary points.
The way I envisioned it is to use a points layer to let the use select N points in the image and compute the length and angles (AP and ML) of each segment between two consecutive points.
The results could be saved to file with the coordinates and brain region of each segment's end points as well as the measured quantities.

Hi, I'd like to work on this feature as well, do you still want help for this one?

Hi @juanma9613, yes definitely!
The existing brainreg-segment widget is already doing quite a lot, so it might be better to have a simple, dedicated widget for this, what do you think @FedeClaudi? The downside is we'd have to make sure that any other data that's needed (e.g. atlas images) are available outside of the main widget.

That's great! In the meantime I'm exploring the tutorial and reading a little bit about Brainreg. Please let me know if you have any guidance about the design of the widget before starting.

I don't have any specific guidance at the moment, but feel free to open a draft PR and I can provide feedback. If you need any test data etc. let me know.
Thanks for taking a look at this!

Hey,
I see advantages for both having it as part of brainreg-segment and separate. I'm sure it's a tool that could be widely useful for anyone using napari, but at the same time within the scope of brainglobe it would realistically only be used to measure distances and angles between points in image/atlas space, so it would be handy to have it load the data like brainreg-segment.
I'm not familiar with plugins, can you have more than one 'active' at a given time? As in, can you use brainreg-segment to load the data and XXX to measure things? Or can you have a plugin use another plugin?
Finally, the way I was doing it while playing around with this idea was to use a points layer and accessing it's data attribute to get the points coordinates. You can then compute distance/angle for each consecutive pair of point. I guess ideally it'd generate an output in which you have for each pair of points their coordinates, brain region they are in, distance and angles.
Computing distance is trivial: np.linalg.norm(p1-p0), but it might be harder to deal with angles. I think ideally you'd compute the angle on the AP and ML planes separately as that's what normally used e.g. to guide surgeries, but perhaps there's better ways?

I'm not familiar with plugins, can you have more than one 'active' at a given time?

Yep, you can have >1 widget in the same plugin, and these can be added to napari independently.

As in, can you use brainreg-segment to load the data and XXX to measure things? Or can you have a plugin use another plugin?

To do this, I think we'd make sure that the new widget could just work on napari layers, which would be output by the original widget. We could add any arbitrary "extra" data or information needed as layer metadata.
I haven't put much thought into exactly what this plugin would calculate, but your ideas sound good @FedeClaudi

Hi,
During the weekend I was working on the first piece of code for this tool. At the moment it's just a small script with a demo of usage and two functions to get distances between all the points and the angles of the segments joining two consecutive
points. Docs and unit testing are still pending.
I've been reading the discussion but I don't know yet how to incorporate the functions I just created. Maybe I can start by creating it as a separate Napari plugin, following this, and then we can figure out how to plug it either to Brainglobe as a widget or to brainreg-segment directly, What do you think about this idea?
Although it's just preliminary work (mainly to get used to Napari inside python) please let me know if you have comments about the code below.
import math
from typing import List, Tuple

import napari
import numpy as np
from skimage.data import astronaut
from scipy.spatial import distance_matrix

# Defining the two functions to use to get distances and angles
def get_distances_between_point_layers(point_layer: napari.layers.Points) -> np.array:
    return distance_matrix(point_layer.data, point_layer.data)

# For the axis I will assume the following (x,y,z) are each of the following
#  (anteroposterior, mediolateral, vectical)
def get_angles_between_consecutive_points(point_layer: napari.layers.Points) -> Tuple[List[float], List[float]]:
    # TODO: Assumed points are always 3d, be careful when that's not the case
    points_array  = point_layer.data
    n_points = points_array.shape[0]
    ap_angles = []
    mp_angles = []
    for i in range(1, n_points):
        pointA = points_array[i-i, :]
        pointB = points_array[i, :]
        segment_vector = pointB - pointA
        # projecting the vector in the sagital plane is just removing
        #  the "y/mediolateral" coordinate
        segment_vector_zx = segment_vector[[2,0]]
        # for the angle, z is used as the first direction/axis and x as the other
        ap_angle = math.atan2(segment_vector_zx[1], segment_vector_zx[0])
        ap_angles.append(ap_angle)
        # projecting the vector in the frontal plane is just removing
        #  the anterioposterior coordinate.
        segment_vector_zy = segment_vector[[2,1]]
        # for the angle, z is used as the first direction/axis and y as the other
        mp_angle = math.atan2(segment_vector_zy[1], segment_vector_zy[0])
        mp_angles.append(mp_angle)

    return ap_angles, mp_angles

# create a Viewer and add an image here
viewer = napari.view_image(astronaut(), rgb=True)
# add random points to the view
points = np.array([[100, 100, 0], [200, 200, 1], [300, 100, 50]])
points_layer = viewer.add_points(points, size=30)

points_distance_matrix = get_distances_between_point_layers(points_layer)
ap_angles, mp_angles = get_angles_between_consecutive_points(points_layer)

print('distances', points_distance_matrix)
print('angles', ap_angles, mp_angles)

# start the event loop and show the viewer
napari.run()

Hi @juanma9613,
From a quick look, that looks good!
Your idea is a good one. If you get this up and running as a napari widget, we can decide later whether it should live on it's own, or whether it should be part of brainreg-segment. It's straightforward for one plugin to have >1 widget.
I would have a play with magicgui to create a GUI that allows the user to choose a points layer, and run the function, perhaps reporting the results in a separate window, or saving to disk. The widget could also optionally run on e.g. only selected points, or >1 points layer.

Unfortunately it was a busy month but this is my first PR for this tool.
Unit tests and some checks to make the plugin more robust to errors are pending, but I'd like to know if the functionality is approved.
https://github.com/brainglobe/brainreg-segment/pull/43
thanks again.


Update initializing-classes-and-structs-without-constructors-cpp.md

fix typo

@drvoss : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the typo fix.
@drvoss Thanks for submitting this fix.


Spring internal libraries variable string value is getting changed

Happening in the class org.springframework.cglib.proxy.MethodInterceptorGenerator don't know why. I am trying to configure proguard for spring based application. Is there any way to mention not to change anything in internal library. Is very hard to configure
Before obfuscator
private static final Signature GET_DECLARED_METHODS = TypeUtils.parseSignature("java.lang.reflect.Method[] getDeclaredMethods()");
After obfuscator
private static final Signature GET_DECLARED_METHODS = TypeUtils.parseSignature("java.lang.reflect.Method");

You can check the proguard documenation about ignoring things in obfuscation https://www.guardsquare.com/en/products/proguard/manual/examples


Deprecation and cleanup

I'd like to open this as a discussion and a collaborative effort to clean up code that is no longer in use or has been deprecated for a long time.

[ ] Remove long-deprecated code
[ ] Check that examples are all running non-deprecated code

Examples which are still not running:
edmet

[ ] 70-h-ring-benchmark.py (fermion-boson coupling symmetry broken)
[ ] 71-h-ring-benchmark-df.py (fermion-boson coupling symmetry broken)
[ ] 72-h-chain-benchmark.py (fermion-boson coupling symmetry broken)

ewf/molecules

[ ] 24-delta-tailor.py (convergence)
[ ] 24-tailor-with-fragments.py  (convergence)
[ ] 71-modify-hcore.py (population analysis needs updating)

ewf/other

[ ] 72-sc-h-plane.py (convergence)
[ ] 76-sc-graphene.py (convergence)

@maxnus same question as above, but for vayesta/core/DEL?

This is a good idea! I made a PR.
I kept some of these files and commented code, since you quickly start to forget previous work, once it's just part of the git history and not that visible anymore. Really these should probably be stale branches.
PMO indeed stands for projected MO, a la regional embedding from Tim Berkelbach. I compared their performance to MP2 BNOs in the past, but the BNOs were much better in the tested systems.

Codecov Report
Patch coverage has no change and project coverage change: -0.54 :warning:

Comparison is base (be22731) 71.73% compared to head (d607657) 71.20%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   71.73%   71.20%   -0.54%
==========================================
  Files         133      133
  Lines       18460    18110     -350
  Branches     2573     2514      -59
==========================================
- Hits        13243    12895     -348
- Misses       4485     4486       +1
+ Partials      732      729       -3

Impacted Files
Coverage Δ

vayesta/core/foldscf.py
75.25% <ø> (-0.73%)
:arrow_down:

vayesta/ewf/ewf.py
64.14% <ø> (-1.34%)
:arrow_down:

vayesta/ewf/fragment.py
67.65% <ø> (-0.22%)
:arrow_down:

... and 52 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Just as a follow-on from the SCMF stuff, the functionality https://github.com/BoothGroup/Vayesta/blob/be227313c17c10d183e3dc9c7a522099cc426b6a/vayesta/core/qemb/qemb.py#L228-L235 in Embedding.__init__  doesn't seem to be used anywhere, let alone tested, and as demonstrated in #91 uses dodgy syntax. It seems ripe for depreciation unless we have any good reasons not to.

I've removed core/DEL and core/ao2mo/DEL - let me know if you want me to restore these into a stale branch. Otherwise at least this PR serves as a checkpoint for removed functionality so they won't be completely lost to git history...

What's the deal with add_tsymmetric_fragments? It has a deprecation warning but as far as I can tell it's the intended function, were make_tsymmetric_fragments is the deprecated one?

I think the preferred interface is currently to use emb.symmetry.set_translations(supercell_mesh) prior to adding any fragments, which will then automatically include all translationally related fragments.
This uses qemb.create_transsym_fragments rather than add_tsymmetric_fragments or make_tsymmetric_fragments, so I think we should depreciate both of those functions entirely.
I think I have an OK idea of how the different symmetries in Vayesta are being applied- translational symmetry is the only one using this approach (termed being applied in fragment context in the code comments, since it should apply to all included fragments) while rotation, inversion and mirror symmetries are handled via context managers within the fragmentation itself (termed as being within their own context).
However, as I think think there was much review done on these changes the examples and tests don't all reflect these updates- @basilib has caught some of them in #105  (eg. no longer supported approaches to rotational symmetries) but we should make a concerted effort to clean all this up here, as it is very unclear due to the number of old interfaces. If we then fix any tests broken by this, then merge this and fix any broken examples along with the rest in the above PR that seems  sensible to me? I've also mentally added updating the docs to have a proper discussion of this to my TODO list...

I've updated this branch to remove conflicts with master; I'd suggest we merge this once tests pass, then I'll open a PR for clarifying the symmetries functions, as that's a suitably different set of things and can also involve updating the docs.

I merged the example fixes into this branch, but there are still a few which require attention. I also wrote a quick script to run the examples.

The interface for rotational symmetry has been changed to no longer accept letters (x,y,z) to specify the rotation axis and instead requires the use of an explicit vector. I have changed the examples to use explicit vectors but the tests use letters.
Is this an intended change or do we want to keep the option of specifying the axis by a letter?

I think the preferred interface is currently to use emb.symmetry.set_translations(supercell_mesh) prior to initialising any fragmentations, which will then automatically include all translationally related fragments. This uses qemb.create_transsym_fragments rather than add_tsymmetric_fragments or make_tsymmetric_fragments, so I think we should depreciate both of those functions entirely.
I think I have an OK idea of how the different symmetries in Vayesta are being applied- translational symmetry is the only one using this approach (termed being applied in fragment context here, since it should apply to all included fragments) while rotation, inversion and mirror symmetries are handled via context managers within the fragmentation itself (termed as being within their own context).

Yes, this is correct 👍 All symmetry-related fragments are added via qemb.create_symmetric_fragments at the moment, which is invoked via creating fragments within a symmetry context manager

This is good to know, but also aware that once this PR is merged the discussions on this thread re. implementation of translational/other symmetry will be essentially lost! We need to make sure that this is clearly described in the docstrings / documentation / examples going forward...

As I said above, I think at the same time as depreciating the alternative symmetry interfaces we should add a section into the quick start documentation discussing symmetry considerations. However, I'm a little wary that this PR already makes a lot of progress and delaying it for this purpose isn't actually beneficial, so would suggest merging this (once all examples are fixed) then I'll open a new PR updating symmetry stuff.

I've updated the EDMET examples. Otherwise I've found:
-the tailoring examples appear to have had the same convergence problems on the commit they were introduced in (1e0c76a1c1a089238b5d0e8267150379ce871e31, see #68 as well...), so I think scrap them and start again. @abhishekkhedkar09 do you have any good scripts as an example of tailoring? I know you don't use delta tailoring so much, so maybe not for that.
-the population analysis functionality appears have been broken since the removal of ActiveSpace objects in favour of Cluster objects in 796e9a8e166f1a0ac56a6d6beaf55e048471111c. I would suggest fixing this probably falls outside the remit of this PR, but is definitely worthwhile; I don't think it'll be much effort(just requires adding functionality to add in the environmental 1rdm contribution) but is worth doing robustly. I'd suggest we leave this for now; I'll raise an issue to make sure it's documented, this might be a nice short PR for someone who wanted to have a go at it.
Just going through the last few examples now..

I've updated the EDMET examples. Otherwise I've found: -the tailoring examples appear to have had the same convergence problems on the commit they were introduced in (1e0c76a, see #68 as well...), so I think scrap them and start again. @abhishekkhedkar09 do you have any good scripts as an example of tailoring? I know you don't use delta tailoring so much, so maybe not for that. -the population analysis functionality appears have been broken since the removal of ActiveSpace objects in favour of Cluster objects in 796e9a8. I would suggest fixing this probably falls outside the remit of this PR, but is definitely worthwhile; I don't think it'll be much effort(just requires adding functionality to add in the environmental 1rdm contribution) but is worth doing robustly. I'd suggest we leave this for now; I'll raise an issue to make sure it's documented, this might be a nice short PR for someone who wanted to have a go at it. -The ewf/other examples have a comment saying they were broken from from 3d82332 (4th December 2021) so I've deleted them; I don't think it's worth the effort to fix them. I've also added rotational symmetry to 71-sc-h-ring.py for computational efficiency.

alright..  I will add an illustrative example for Tailored CC.

I think I am done - what's the status on the examples?

I've just tweaked the delta tailoring example, and opened issues (#110 and #111) for the topics we've discussed here but not yet fixed. As such, I think this is ready to be merged.

Ready to merge then


Doc: Add more context into %sqlrender API Reference

Context:
We need to provide more info into %sqlrender API Reference
Task:

The schema for example authors table
Add the detail spec (input, parameters), something like we did in sqlplot

I would like to get assigned this issue as part of the ploomber internship interview process

assigned!


Docs: update unavailable task property annotations in the runtime API

Fixes #21594
Context
More accurate documentation, less confusion.
Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@aSemy pls. sign your commit properly (see failed check)

@jbartok I made this commit through the GitHub web gui which doesn't have this option. My GitHub email and username are already in the commit, so it looks like it's redundant information?

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

@bot-gradle cancel

OK, I've already cancelled the pre-tested commit build.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

@jbartok I made this commit through the GitHub web gui which doesn't have this option. My GitHub email and username are already in the commit, so it looks like it's redundant information?

My comment was misleading. A sign-off was needed. I did it now and will merge it in.

OK, I've already triggered a build for you.


Switch FBbt mappings to SSSOM

Currently, mappings between CL and FBbt are managed the “classical way”, as cross-references stored on the CL side (though some of them also used to be stored on the FBbt side).
This PR switches from the “classical way” to FBbt-maintained mappings in the SSSOM format. To do that, it:

removes all FBbt cross-references from the -edit file;
imports a new dedicated mappings.owl component;
updates the Makefile to automatically download the SSSOM file from FBbt and generate the mappings.owl component.

This is exactly the same approach as the one already in use in Uberon.
The initial plan was to have those mapping components managed directly by the ODK (to avoid duplication of code across repositories), but since we don’t have yet a roadmap in the ODK for that, I’d rather accept some duplication for now instead of letting the CL/FBbt mappings go without updates.

Not a great fan either (that’s akin to a Mungall-ism, but in a language even older than Perl :p ), but sssom convert does not satisfy the use case for now, does it? Unless I missed something, there is currently no way to customise the generated OWL to introduce the annotation we want (in this case, oboInOwl:hasDbXref) instead of the annotation as it appears in the mapping file (skos:exactMatch).
I certainly don’t want this AWK script to propagate outside of CL/Uberon, and I look forward to replace all of it with a proper solution implemented directly in the ODK. But until we can do that, this will do.

How does this relate to bridge file generation?

@dosumis With this PR, CL will automatically pick up any changes that I do to the FBbt/CL mappings (that I manage on the FBbt side). Those mappings are converted to xrefs in the released version of CL, and after that the bridge generation process that is in place in the Uberon repository (based on Chris’ make-bridge-ontologies-from-xrefs.pl script) takes over as usual to create the bridge files from the xrefs.
So this PR does not actually change anything in the way the bridge files are generated (yet!). The goal here is to start introducing the use of SSSOM without breaking the bridge generation pipeline.
Later (dependent notably on updates to the SSSOM tooling), we hope to be able to skip the xrefs step altogether and generate the bridge files directly from the SSSOM (though we might still keep the xrefs for backward compatibility). But we are not there yet.


aws_cdk.aws_ec2.Vpc:  max_a_zs ignored?

I'm submitting a ...

[x] :beetle: bug report
[ ] :rocket: feature request
[ ] :books: construct library gap
[ ] :phone: security issue or vulnerability => Please see policy
[ ] :question: support request => Please see note at the top of this template.

What is the current behavior?
For the code below, it seems as if the synthesized template includes only 4 subnets (2 public and 2 private) even if max_a_zs value and subnet configuration would allow for more in the affected region.

If the current behavior is a :beetle:bug:beetle:: Please provide the steps to reproduce
Consider this code:
import sys
from aws_cdk import core
from aws_cdk import aws_ec2 as ec2

app = core.App()

env = core.Environment(region = 'us-east-2')
stack = core.Stack(app, 'vpc-test-cdk036', env = env)
vpc = ec2.Vpc(stack, 'vpc', cidr='<IP_ADDRESS>/17', max_a_zs=3,
    subnet_configuration = [
        ec2.SubnetConfiguration(name='pub', subnetType=ec2.SubnetType.PUBLIC),
        ec2.SubnetConfiguration(name='prv', subnetType=ec2.SubnetType.PRIVATE),
    ]
)

print(f'Region: {stack.region}', file=sys.stderr)
print(f'Availability Zones: {stack.availability_zones}', file=sys.stderr)
for subnet_type in ('public', 'private'):
    subnets_attr = f'{subnet_type}_subnets'
    print(f'{subnet_type}: {len(getattr(vpc, subnets_attr))}', file=sys.stderr)

app.synth()

Then, run the CLI like so:
$ cdk synth --json | jq '.Resources | to_entries | [.[] | select(.value.Type == "AWS::EC2::Subnet")] | length'
The jq filter simply counts subnet resources declared in the synthesized template.

What is the expected behavior (or behavior of feature suggested)?
Six subnets should have been created.  I can't seem to create more than 4.  Note that us-east-2 has at least 3 AZs.  Also, I notice that no context values were saved by the CLI after a synth command.

I reviewed CHANGELOG.md and commits on master since v0.36.0 but didn't notice anything relevant.  I feel like I may have missed something here (sincerest apologies if so), as this kind of issue seems fairly easy to encounter, so I'd be surprised somewhat if indeed this is a bug and I am the first to report it.

What is the motivation / use case for changing the behavior or adding this feature?
I'd like to create more than 4 subnets and preserve my existing VPC stacks having more than 4 subnets.  Unless I misunderstood something, I'm pretty sure this is a regression because I don't recall having such a problem in v0.34.0.  When I run cdk diff from v0.36.0 against similar VPC stacks created by v0.34.0, results indicate a reduction to 4 subnets and change of the remaining subnets to a reduced CIDR prefix (quite disruptive).

Please tell us about your environment:

CDK CLI Version: 0.36.0 (build 6d38487)
Module Version: 0.36.0
OS: cpe:/o:fedoraproject:fedora:30
Language: Python

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

Have a look at #3083

Thank you @mhuebner.  This worked as I expected when I replaced:
env = core.Environment(region = 'us-east-2')

with:
import os
env = core.Environment(
        account = os.environ.get('CDK_DEFAULT_ACCOUNT'),
        region = 'us-east-2'
)


Adopt structlog as a replacement for loguru

https://www.structlog.org/en/stable/getting-started.html#installation
Although loguru is generally a good logging solution, structlog has additional functionality that can help us check some other boxes, such as dynamic switching between normal logs and JSON logs

moving to done


Watcher not working

Below is the watcher config put through sense

PUT watcher/watch/Email_watch
{
"trigger": {
"schedule": {
"interval": "1m"
}
},
"input": {
"search": {
"request": {
"indices": "logstash-2017.02.20",
"body": {
"size": 0,
"query": {
"range": {
"syslog_sev_level": {
"lte": "6 "
}
}
}
}
}
}
},
"condition": {
"script": "return ctx.payload.hits.total > 0"
},
"actions": {
"send_email": {
"throttle_period": "60m",
"email": {
"to"<EMAIL_ADDRESS>"from"<EMAIL_ADDRESS>"subject": "Syslog_sev_level less than or equal to 5",
"body": "Syslog_sev_level less than or equal to 5",
"attachments": {
"attached_data": {
"data": {
"format": "json"
}
}
},
"priority": "high"
}
}
}
}

Below is the Curl output

XXXX@ubuntu:/usr/share/elasticsearch/config$ curl -XGET 'http://localhost:9200/_watcher/stats?pretty'
{
"watcher_state" : "started",
"watch_count" : 2,
"execution_thread_pool" : {
"queue_size" : 0,
"max_size" : 15
},
"manually_stopped" : false
}

Elasticsearch.yml config

watcher.index.rest.direct_access : true
watcher.actions.email.service.account:
exchange_account:
profile: outlook
email_defaults:
from<EMAIL_ADDRESS>smtp:
auth: false
starttls.enable: false
host: Smtp.1bank.XXX.com
port: 25
user<EMAIL_ADDRESS>password:

Below is the versions  been used ..
Kibana Version 4.5.4
elasticsearch 2.4.2
Logstash 2.3.4
Watcher 2.4.4.
Email for some reason is not been initiated ..Anyone can help if possible

@sreejithseradi This repository is for a standalone version of the Watcher APIs that is compatible with NEST 1.x. Since you are using Elasticsearch 2.4.2, you should use the latest NEST 2.x (currently 2.5.2) which contains the Watcher APIs and is compatible with Elasticsearch 2.4.2 and Watcher 2.4.4.
I'm going to close this issue; if there is an issue with NEST 2.x, feel free to open a ticket on the NEST github repository.


New Proposal - Capability and Runtime Restrictions

CAMARA Service APIs are designed with many optional parameters and features.  It’s unreasonable to expect each API Producer (i.e. Operator) to support all these optional parameters.  In addition, some supported features and parameters may not be enabled at Service API invocation time, based on network state, who might be invoking and/or for whom/which device, location, …)  There is currently no mechanism to exchange such information with API Consumers (i.e. Application Service Providers (ASP)/Developers/Aggregators) and keep the CAMARA APIs the same across the Exposure Gateways.
This API proposes reuse of JSON schema to communicate 'limits' enforced by API Producer/Provider to developers.

@jgarciahospital as time ran out in the API Backlog call yesterday (Sept 26, 2024), I couldn't provide an update.  Given the alternate timing of the meetings, I'll not be able to join until the following meeting.  Please find the couple slides providing an update embedded in the API Backlog Minutes:  Capabilities_and_Runtime_Restrictions_Update.pptx
We request this proposal to be taken to TSC for request of 'sandbox' creation?

Hi Murat,
As proposal was already considered and approved in backlog to be proposed to TSC, I don't see any problem on pushing it this thursday. Please confirm your presence on the next TSC (3rd October, 10-11:30 CET/UTC+2)

Hi Murat,
As proposal was already considered and approved in backlog to be proposed to TSC, I don't see any problem on pushing it this thursday. Please confirm your presence on the next TSC (3rd October, 10-11:30 CET/UTC+2)

Thank you, Jorge. Unfortunately, I can't commit to this week's TSC, but I can be there at the next TSC, I believe on October 17th).

Perfect! I take note of it.

Hi @gmuratk, can you upload in the PR #74 the documentation included in those minutes? The folder https://github.com/camaraproject/APIBacklog/tree/main/documentation/SupportingDocuments is a good place for it.


Use E2E_PIPELINE_ID to determine the package to install

What does this PR do?
Stop relying on CI_PIPELINE_ID and rather use E2E_PIPELINE_ID that is configured to be equal to CI_PIPELINE_ID in classic pipelines. But it offers us more flexibility.
For example this is useful if tests are running in  a child pipeline and we want to use the artifact from parent pipeline
Also add a failure on installer tests when E2E_PIPELINE_ID does not exist. The test is doomed to fail
It also removes CI_PIPELINE_ID reference in WithStackName the framework itself is already responsible for creating unique stack name from the CI_JOB_ID variable

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Implemented a directory structure

Related Issues or Pull Requests
Implemented a directory structure and cleaned up code
Have you read the [Contributing Guidelines on Pull Requests]
Yes
Description
Turned every feature a module of its own package according to the category. Cleaned up existing code.
Checklist

[ X ] I've read the contribution guidelines.
[ X ] I've checked the issue list before deciding what to submit.
[ X ] I've followed 4 space indentation throughout the file(s)
[ X ] My code follows the style guidelines(Clean Code) of this project
[ X ] I have performed a self-review of my own code
[ X ] I have commented my code, particularly in hard-to-understand areas
[ X ] I have created a helpful and easy to understand README.md
[ X ] I have made corresponding changes to the documentation
[ X ] My changes generate no new warnings
[ X ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

File(s) Added / Modified
Added:
botactions (Folder)
init.py
addPinEmoji.py
reactToPinEmoji.py
entertainment (Folder)
music (Folder)
init.py
joinAndLeaveVc.py
lyrics.py
songsControl.py
init.py
saynoice.py
saypong.py
wordmeaning.py
tools (Folder)
init.py
exportChat.py
linkchecker.py
serverStats.py
userInfo.py
bot.py
requirements.txt
setEnvVar.sh
tokensandkeys.sh

Language(s) Used
Python
Bash

Markdown

Closing this PR as we are going with Cogs


Reconsider XON/XOFF PR to keep slave in sync with terminal

See if https://github.com/sourcelair/xterm.js/pull/146 performs better after https://github.com/sourcelair/xterm.js/pull/422 lands. It could also be changed to let larger chunks of data (~1 viewport page?) as that should suffice for keeping ctrl+c more responsive as well as making commands such as time accurate.

I think pausing the process once a certain threshold is hit so xterm.js can catch up is the best thing to do here. The threshold could be quite large as well, say 1000+ lines or something, it's just commands that send a tonne of output will always outrun us.

Should we consider implementing this eventually? I think that after #422 performance improved radically and I am quite skeptical about this as it seems more like a hack, rather an actual performance improvement.

This is a must imo after looking into perf over the last week. Running a command such as yes will send too much output for xterm.js to possibly handle, meaning it will be chugging as fast as it can all the time and interrupting such a process is only possible once the output has been processed. Definitely not hacky, it improves stability significantly in certain use cases in addition we support XON (ctrl+s) and XOFF (ctrl+q)!


Update files icon

What is the purpose of this pull request?

[x] Other: Icon update

Description
Reduced sharpness by adding round corners
Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

As we discussed in Discord, we keep it as it is.


There should be @SuperBuilder.Default annotation in my understanding

I used lombok 1.18.2, and I find @Builder.Default is not supported by the class which annotated by @SuperBuilder

Thanks for your work!
I am wondering when can we get the fixed stable version?

@janrieke Another question is that when I use both Data and SuperBuilder in Idea, I got a warning that ToString's callsuper is false, can Data manage callsuper boolean value?

Hi, I running into the same problem. Please let us know when this update is available.

That @Data problem (not calling super) seems to be a different problem unrelated to @SuperBuilder. I'm getting the warning even without the @SuperBuilder annotation. Can you also confirm that, @kingraser?

@janrieke
Yes, I think you are right. The problem is unrelated to @SuperBuilder annotation.
I just wondering if we can have annotation like this @Data(callSuper=true) ,
so the code will be much more elegant than explicitly add @EqualsAndHashCode(callSuper=true) annotation.

@kingraser: All PRs relevant to this issue are now merged. Could you give the latest edge release a try to confirm this issue is fixed?

@janrieke
Thanks very much, I've just tried and I think the issue is fixed.
Another thing is that can We have a annotation like this @Data(callSuper=true)
So the callSuper can be used for both @EqualsAndHashCode and @ToString
Thanks for your dedicated work.

You can configure lombok to always callSuper without a warning using lombok.config:
lombok.equalsAndHashCode.callSuper=call

If this is not sufficient for you, there are already some other issue open on that topic, and there are some ideas related to it (e.g., https://github.com/rzwitserloot/lombok/wiki/FEATURE-IDEA:-@SuperToString). Please use the existing issues to discuss that topic.
This issue can be closed here.

@janrieke  Thx very much


[BUG] Testing on a single document

Describe the bug
Testing on a single document results in a code crash
To Reproduce
Steps to reproduce the behavior:

Train a model
Try to test it on 1 document

Reproduction example
I copy pasted code from the readme.md example. The only difference was my train and test sets were not different. I just pulled 1 document from the train set and sent that as input [test_doc] to the transform function.

Ran into the same thing, I think that based on the documentation, (looking at v1.5.1), for the stop_words arg

If None, no stop words will be used. In this case, setting max_df to a higher value, such as in the range (0.7, 1.0), can automatically detect and filter stop words based on intra corpus document frequency of terms.

It might be the case that some corpuses are too small or something to automatically infer stop words. I'm just skipping that step in documents_without_stop_words.


Fluent Design for Wordpress

Would be really nice if Microsoft could partner with wordpress and bring a fully functioning Fluent Design UWP theme and editor with all the things that make it great.
Please empower every wordpress author to achieve more.

Thanks, @A55imilat0r ; I've shared your feedback with our engineering team.


⚠ Bofrost.fr has degraded performance

In f2d9382, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1297 ms

Resolved: Bofrost.fr performance has improved in dfaf448 after 22 minutes.


fix(SbDataTableActions): increase SbDataTable actions sticky version z-index

Increases the z-index CSS property of the SbDataTableActions component so that it sets on top of other components
Pull request type
Jira Link: WORK-1177

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Other (please describe):

How to test this PR

What is the new behavior?

SbDataTableActions z-index should be 2 to prevent it from being below other absolute elements (see example below)

Other information

Reopened using the correct JIRA ticket reference


Command trigger in guild, to get args from DM

Hello,
Is it possible to have a command that is triggered from within a guild, that then DMs the user to get the required args?
This is so the command args aren't shown within a channel
Thanks for the great work on this project!

Closing because I've got what I wanted by adding in a message collector on the DM channel

You can ask in the Support Server instead of opening issues. Its easier, faster :)