Temp body created when trying to perform an intersection on bodies which do not intersect.

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
When trying to perform an intersection between two bodies which do not intersect we can find a temp body within the saved geometry which is not shown in the pygeometry design.
from the scdocx:

from design object:

I have added a script to reproduce the problem.
📝 Steps to reproduce
import os
from pathlib import Path
from ansys.geometry.core.math import (
    UNITVECTOR3D_X,
    UNITVECTOR3D_Y,
    Plane,
    Point2D,
    Point3D,
)
from ansys.geometry.core.misc import DEFAULT_UNITS
from ansys.geometry.core.sketch import Sketch
from ansys.geometry.core.connection.launcher import launch_modeler_with_geometry_service
from ansys.geometry.core.designer import DesignFileFormat

modeler = launch_modeler_with_geometry_service()
design = modeler.create_design("RVE")

unit = DEFAULT_UNITS.LENGTH

plane = Plane(
    Point3D([1 / 2, 1 / 2, 0.0], unit=unit),
    UNITVECTOR3D_X,
    UNITVECTOR3D_Y,
)
box_plane = Sketch(plane)
box_plane.box(Point2D([0.0, 0.0]), width=1, height=1)

box = design.extrude_sketch("Matrix", box_plane, 1)

p = Point3D([1.0, 1.0, 1.5], unit=unit)
plane = Plane(p, UNITVECTOR3D_X, UNITVECTOR3D_Y)
sketch_fibres = Sketch(plane)
sketch_fibres.circle(Point2D([0.0, 0.0], unit=unit), radius=0.5)
fibre = design.extrude_sketch("fibre", sketch_fibres, 1)

box_copy = box.copy(design)
try:
    fibre.intersect(box_copy)
except:
    design.delete_body(box_copy)

design.plot(show_edges=True)

file_path = Path(os.getcwd(), "trial.scdocx")

design.download(
            file_location=file_path,
            format=DesignFileFormat.SCDOCX,
        )

💻 Which operating system are you using?
 I believe this might be an underlying library issue... are you interested in having that "temp" body? Because I believe you aren't.

Okay so, after verifying with @rmanno91, they are not interested in having that body (which makes total sense).
We should delete this "temp" file whenever these operations occur. Pinging @ansys/pyansys-geometry-maintainers. This is an issue happening in SC/DMS/Discovery... Happened as well in 24r1 - let's try to fix this before 24r2.

Seems to be fixed in the latest dev version - I will give it a try and implement a test for this.

Seems to be fixed in the latest dev version - I will give it a try and implement a test for this.

Thanks Roberto, I will have a go on my end too.

Hi @rmanno91 - see #1258 ... seems like it still isn't fixed. I reported it back to @b-matteo

This test will verify that the change is implemented


Mobile type

What is this PR trying to achieve?
This brings the mobile typography in line with the article PSDs.

Let's have a chat about this.
Does this mean there are fonts that we can not load for mobile?

Just sizings


Crash with canary and apothiccurios

Version

Forge 1.20.1-47.3.5
Placebo-1.20.1-8.6.2 (https://www.curseforge.com/minecraft/mc-mods/placebo/files/5414631)
ApothicAttributes-1.20.1-1.3.6 (https://www.curseforge.com/minecraft/mc-mods/apothic-attributes/files/5529789)
Apotheosis-1.20.1-7.4.0 (https://www.curseforge.com/minecraft/mc-mods/apotheosis/files/5486368)
ApothicCurios-1.20.1-1.0.3d (https://www.curseforge.com/minecraft/mc-mods/apothic-curios/files/5497444)
Cloth Config API [Forge 1.20(.1)] v11.1.118 (https://www.curseforge.com/minecraft/mc-mods/cloth-config/files/4973441)
Accessories Neoforge 1.0.0 Beta 22 for 1.20.1 (https://www.curseforge.com/minecraft/mc-mods/accessories/files/5570403)
Curios Compat 7.4.0 Layer Beta.6 for 1.20.1 (https://www.curseforge.com/minecraft/mc-mods/accessories-cc-layer/files/5576360)
Canary 0.3.3 for MC 1.20.1 (https://www.curseforge.com/minecraft/mc-mods/canary/files/5089991)

Reproduction Steps

The game crashes after a few seconds inside a world

Crash Report File

https://gist.github.com/fg1989/d6ae00d47f3e0ff9ed679f995d35bb63

Additional Information

Game starts correctly if canary is not installed, if apothiccurios is not installed or if accessories is replaced by curios

Yea, pushed an attempted work around with some not-thought-out code. I have updated such and pushed it to modrinth and curseforge


[Support]RPi can connect with OpenVPN but no traffic

{please fill the checkboxes, e.g: [X]}

[X] I have read and understood the contributors guide.
[X] The issue I am reporting can be replicated.
[X] The issue I am reporting can be is directly related to the pivpn installer script.
[X] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Did a clean of the minimal Raspbian Buster image.
Used the script to do all the install work.
Opened the default UDP port to the IP of the Raspberry
Transfered the .ovpn file to my iphone
I can connect to it with my phone but can't browse any site or access internal webpage of router or printer
Have you searched for similar issues and solutions?
(yes/no / which issues?) Yes

Console output of      curl -L install.pivpn.dev | bash
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100    17  100    17    0     0    459      0 --:--:-- --:--:-- --:--:--   472
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (35) error:14094438:SSL routines:ssl3_read_bytes:tlsv1 alert internal error

Console output of      pivpn debug
  ::: Generating Debug Output
::::		PiVPN debug		 ::::
=============================================
::::		Latest commit		 ::::
commit 13f0fe7cbdcdb31537b3fd0e2eb34652e886cc1b
Author: 4s3ti<EMAIL_ADDRESS>Date:   Wed Dec 9 19:22:29 2020 +0100

    ProBot Stale

    Added probot integration to marke topics as inactives and automatically
    close them.
    read .github/stale.yml for more details.
=============================================
::::	    Installation settings    	 ::::
PLAT=Raspbian
OSCN=buster
USING_UFW=0
IPv4dev=eth0
IPv4addr=<IP_ADDRESS>/24
IPv4gw=<IP_ADDRESS>
install_user=pi
install_home=/home/pi
VPN=openvpn
pivpnPROTO=udp
pivpnPORT=1194
pivpnDNS1=<IP_ADDRESS>
pivpnDNS2=<IP_ADDRESS>
pivpnSEARCHDOMAIN=
pivpnHOST=REDACTED
TWO_POINT_FOUR=1
pivpnENCRYPT=256
USE_PREDEFINED_DH_PARAM=
INPUT_CHAIN_EDITED=0
FORWARD_CHAIN_EDITED=0
pivpnDEV=tun0
pivpnNET=<IP_ADDRESS>
subnetClass=24
UNATTUPG=1
INSTALLED_PACKAGES=()
HELP_SHOWN=1
=============================================
::::  Server configuration shown below   ::::
dev tun
proto udp
port 1194
ca /etc/openvpn/easy-rsa/pki/ca.crt
cert /etc/openvpn/easy-rsa/pki/issued/openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1.crt
key /etc/openvpn/easy-rsa/pki/private/openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1.key
dh none
ecdh-curve prime256v1
topology subnet
server <IP_ADDRESS> <IP_ADDRESS>
# Set your primary domain name server address for clients
push "dhcp-option DNS <IP_ADDRESS>"
push "dhcp-option DNS <IP_ADDRESS>"
# Prevent DNS leaks on Windows
push "block-outside-dns"
# Override the Client default gateway by using <IP_ADDRESS>/1 and
# <IP_ADDRESS>/1 rather than <IP_ADDRESS>/0. This has the benefit of
# overriding but not wiping out the original default gateway.
push "redirect-gateway def1"
client-to-client
client-config-dir /etc/openvpn/ccd
keepalive 15 120
remote-cert-tls client
tls-version-min 1.2
tls-crypt /etc/openvpn/easy-rsa/pki/ta.key
cipher AES-256-CBC
auth SHA256
user openvpn
group openvpn
persist-key
persist-tun
crl-verify /etc/openvpn/crl.pem
status /var/log/openvpn-status.log 20
status-version 3
syslog
verb 3
#DuplicateCNs allow access control on a less-granular, per user basis.
#Remove # if you will manage access by user instead of device.
#duplicate-cn
# Generated for use by PiVPN.io
=============================================
::::  Client template file shown below   ::::
client
dev tun
proto udp
remote REDACTED 1194
resolv-retry infinite
nobind
remote-cert-tls server
tls-version-min 1.2
verify-x509-name openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1 name
cipher AES-256-CBC
auth SHA256
auth-nocache
verb 3
=============================================
:::: 	Recursive list of files in	 ::::
::: /etc/openvpn/easy-rsa/pki shows below :::
/etc/openvpn/easy-rsa/pki/:
basvaningen.ovpn
ca.crt
crl.pem
Default.txt
ecparams
index.txt
index.txt.attr
index.txt.attr.old
index.txt.old
issued
openssl-easyrsa.cnf
private
renewed
revoked
safessl-easyrsa.cnf
serial
serial.old
ta.key

/etc/openvpn/easy-rsa/pki/ecparams:
prime256v1.pem

/etc/openvpn/easy-rsa/pki/issued:
basvaningen.crt
openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1.crt

/etc/openvpn/easy-rsa/pki/private:
basvaningen.key
ca.key
openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1.key

/etc/openvpn/easy-rsa/pki/renewed:
private_by_serial
reqs_by_serial

/etc/openvpn/easy-rsa/pki/renewed/private_by_serial:

/etc/openvpn/easy-rsa/pki/renewed/reqs_by_serial:

/etc/openvpn/easy-rsa/pki/revoked:
private_by_serial
reqs_by_serial

/etc/openvpn/easy-rsa/pki/revoked/private_by_serial:

/etc/openvpn/easy-rsa/pki/revoked/reqs_by_serial:
=============================================
::::		Self check		 ::::
:: [OK] IP forwarding is enabled
:: [OK] Iptables MASQUERADE rule set
:: [OK] OpenVPN is running
:: [OK] OpenVPN is enabled (it will automatically start on reboot)
:: [OK] OpenVPN is listening on port 1194/udp
=============================================
:::: Having trouble connecting? Take a look at the FAQ:
:::: https://github.com/pivpn/pivpn/wiki/FAQ
=============================================
::::      Snippet of the server log      ::::
Dec 23 15:40:23 openvpn ovpn-server[556]: REDACTED:62992 peer info: IV_PROTO=2
Dec 23 15:40:23 openvpn ovpn-server[556]: REDACTED:62992 peer info: IV_AUTO_SESS=1
Dec 23 15:40:23 openvpn ovpn-server[556]: REDACTED:62992 peer info: IV_GUI_VER=net.openvpn.connect.ios_3.2.2-3507
Dec 23 15:40:23 openvpn ovpn-server[556]: REDACTED:62992 peer info: IV_SSO=openurl
Dec 23 15:40:23 openvpn ovpn-server[556]: REDACTED:62992 Control Channel: TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384, 256 bit EC, curve: prime256v1
Dec 23 15:40:23 openvpn ovpn-server[556]: REDACTED:62992 [basvaningen] Peer Connection Initiated with [AF_INET]REDACTED:62992
Dec 23 15:40:23 openvpn ovpn-server[556]: basvaningen/REDACTED:62992 OPTIONS IMPORT: reading client specific options from: /etc/openvpn/ccd/basvaningen
Dec 23 15:40:23 openvpn ovpn-server[556]: basvaningen/REDACTED:62992 MULTI: Learn: <IP_ADDRESS> -> basvaningen/REDACTED:62992
Dec 23 15:40:23 openvpn ovpn-server[556]: basvaningen/REDACTED:62992 MULTI: primary virtual IP for basvaningen/REDACTED:62992: <IP_ADDRESS>
Dec 23 15:40:23 openvpn ovpn-server[556]: basvaningen/REDACTED:62992 PUSH: Received control message: 'PUSH_REQUEST'
Dec 23 15:40:23 openvpn ovpn-server[556]: basvaningen/REDACTED:62992 SENT CONTROL [basvaningen]: 'PUSH_REPLY,dhcp-option DNS <IP_ADDRESS>,dhcp-option DNS <IP_ADDRESS>,block-outside-dns,redirect-gateway def1,route-gateway <IP_ADDRESS>,topology subnet,ping 15,ping-restart 120,ifconfig <IP_ADDRESS> <IP_ADDRESS>,peer-id 6,cipher AES-256-GCM' (status=1)
Dec 23 15:40:23 openvpn ovpn-server[556]: basvaningen/REDACTED:62992 Data Channel: using negotiated cipher 'AES-256-GCM'
Dec 23 15:40:23 openvpn ovpn-server[556]: basvaningen/REDACTED:62992 Outgoing Data Channel: Cipher 'AES-256-GCM' initialized with 256 bit key
Dec 23 15:40:23 openvpn ovpn-server[556]: basvaningen/REDACTED:62992 Incoming Data Channel: Cipher 'AES-256-GCM' initialized with 256 bit key
Dec 23 15:40:29 openvpn ovpn-server[556]: REDACTED:62980 TLS Error: TLS key negotiation failed to occur within 60 seconds (check your network connectivity)
Dec 23 15:40:29 openvpn ovpn-server[556]: REDACTED:62980 TLS Error: TLS handshake failed
Dec 23 15:40:29 openvpn ovpn-server[556]: REDACTED:62980 SIGUSR1[soft,tls-error] received, client-instance restarting
Dec 23 15:40:34 openvpn ovpn-server[556]: REDACTED:62981 TLS Error: TLS key negotiation failed to occur within 60 seconds (check your network connectivity)
Dec 23 15:40:34 openvpn ovpn-server[556]: REDACTED:62981 TLS Error: TLS handshake failed
Dec 23 15:40:34 openvpn ovpn-server[556]: REDACTED:62981 SIGUSR1[soft,tls-error] received, client-instance restarting
=============================================

Have you taken any steps towards solving your issue?
  - Uninstalled PiVPN
  - Tried other DNS settings
  - Turned off/on the compression on the iPhone app

I've seen similar, when I had a bad client config file (out of date/wrong pivpn install).  From the logs the connection was made to the server but the TLS negotiation failed.  Are you sure you have a current client config for that server that is installed?  Can you check with another device?

Set the server config to use verb 4 (Replace verb 3) and post your server log again.

@TinCanTech  Here is the new server log:
::: Generating Debug Output
::::		PiVPN debug		 ::::
::::		Latest commit		 ::::
commit 13f0fe7cbdcdb31537b3fd0e2eb34652e886cc1b
Author: 4s3ti<EMAIL_ADDRESS>Date:   Wed Dec 9 19:22:29 2020 +0100
ProBot Stale

Added probot integration to marke topics as inactives and automatically
close them.
read .github/stale.yml for more details.

=============================================
::::	    Installation settings    	 ::::
PLAT=Raspbian
OSCN=buster
USING_UFW=0
IPv4dev=eth0
IPv4addr=<IP_ADDRESS>/24
IPv4gw=<IP_ADDRESS>
install_user=pi
install_home=/home/pi
VPN=openvpn
pivpnPROTO=udp
pivpnPORT=1194
pivpnDNS1=<IP_ADDRESS>
pivpnDNS2=<IP_ADDRESS>
pivpnSEARCHDOMAIN=
pivpnHOST=REDACTED
TWO_POINT_FOUR=1
pivpnENCRYPT=256
USE_PREDEFINED_DH_PARAM=
INPUT_CHAIN_EDITED=0
FORWARD_CHAIN_EDITED=0
pivpnDEV=tun0
pivpnNET=<IP_ADDRESS>
subnetClass=24
UNATTUPG=1
INSTALLED_PACKAGES=()
HELP_SHOWN=1
::::  Server configuration shown below   ::::
dev tun
proto udp
port 1194
ca /etc/openvpn/easy-rsa/pki/ca.crt
cert /etc/openvpn/easy-rsa/pki/issued/openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1.crt
key /etc/openvpn/easy-rsa/pki/private/openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1.key
dh none
ecdh-curve prime256v1
topology subnet
server <IP_ADDRESS> <IP_ADDRESS>
Set your primary domain name server address for clients
push "dhcp-option DNS <IP_ADDRESS>"
push "dhcp-option DNS <IP_ADDRESS>"
Prevent DNS leaks on Windows
push "block-outside-dns"
Override the Client default gateway by using <IP_ADDRESS>/1 and
<IP_ADDRESS>/1 rather than <IP_ADDRESS>/0. This has the benefit of
overriding but not wiping out the original default gateway.
push "redirect-gateway def1"
client-to-client
client-config-dir /etc/openvpn/ccd
keepalive 15 120
remote-cert-tls client
tls-version-min 1.2
tls-crypt /etc/openvpn/easy-rsa/pki/ta.key
cipher AES-256-CBC
auth SHA256
user openvpn
group openvpn
persist-key
persist-tun
crl-verify /etc/openvpn/crl.pem
status /var/log/openvpn-status.log 20
status-version 3
syslog
verb 4
#DuplicateCNs allow access control on a less-granular, per user basis.
#Remove # if you will manage access by user instead of device.
#duplicate-cn
Generated for use by PiVPN.io
=============================================
::::  Client template file shown below   ::::
client
dev tun
proto udp
remote REDACTED 1194
resolv-retry infinite
nobind
remote-cert-tls server
tls-version-min 1.2
verify-x509-name openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1 name
cipher AES-256-CBC
auth SHA256
auth-nocache
verb 3
:::: 	Recursive list of files in	 ::::
::: /etc/openvpn/easy-rsa/pki shows below :::
/etc/openvpn/easy-rsa/pki/:
basvaningen.ovpn
ca.crt
crl.pem
Default.txt
ecparams
index.txt
index.txt.attr
index.txt.attr.old
index.txt.old
issued
openssl-easyrsa.cnf
private
renewed
revoked
safessl-easyrsa.cnf
serial
serial.old
ta.key
/etc/openvpn/easy-rsa/pki/ecparams:
prime256v1.pem
/etc/openvpn/easy-rsa/pki/issued:
basvaningen.crt
openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1.crt
/etc/openvpn/easy-rsa/pki/private:
basvaningen.key
ca.key
openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1.key
/etc/openvpn/easy-rsa/pki/renewed:
private_by_serial
reqs_by_serial
/etc/openvpn/easy-rsa/pki/renewed/private_by_serial:
/etc/openvpn/easy-rsa/pki/renewed/reqs_by_serial:
/etc/openvpn/easy-rsa/pki/revoked:
private_by_serial
reqs_by_serial
/etc/openvpn/easy-rsa/pki/revoked/private_by_serial:
/etc/openvpn/easy-rsa/pki/revoked/reqs_by_serial:
::::		Self check		 ::::
:: [OK] IP forwarding is enabled
:: [OK] Iptables MASQUERADE rule set
:: [OK] OpenVPN is running
:: [OK] OpenVPN is enabled (it will automatically start on reboot)
:: [OK] OpenVPN is listening on port 1194/udp
:::: Having trouble connecting?
::: Copy saved to /tmp/debug.log
:::

Edited your comment, please be more careful when pasting outputs, wrap it inside 3 back-ticks like this:
```
Codeblock // output  here
```

@basvaningen your server log suggests that the client is having a problem.
Please set verb 4 in your client config and try to connect then paste your log (correctly) here.
My initial thought is that this may be incorrect: client config
verify-x509-name openvpn_9fa5225d-f490-48e7-b171-8e3bcb4639f1 name

No replies in a while, closing...


vk_mem_alloc: Update to latest upstream + volk: Finish update + Revert custom approach to small objects

This updates VMA to the most recent trunk, which aims to provide a better solution than the one in 4e6c9d3ae979f2eb0151cf581fe61d2f3194ea72 (see #57989), which gets reverted.
VMA now works with a TLSF algorithm by default, in contrast to the former default (linear) we were using. This is the new recommended default approach; slightly slower, but allows to free memory instead of growing until exhaustion (see https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/issues/178#issuecomment-1048201561).
Also, Volk is upgraded to the correct version (it seems some commit was supposed to do it, but failed for some reason).
Also, patches already merged upstream or not needed any longer are removed. The nullability patch has been upstreamed in https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/pull/242.
Supersedes #58137.

Also, Volk is upgraded to the correct version (it seems some commit was supposed to do it, but failed for some reason).

Indeed, I had updated all related components and eventually forgot to update Volk itself it seems. (Ref #57980)

Thanks!


Using hidden input type instead of text.

If the 'magic' field will be hidden in any way, why not use 'hidden' input type?
We're currently autofocusing the first text field when a modal is shown in our website. Sometimes the first text element was created by Selectize.js. Then we have to verify this special case before autofocus the form field. If it was a hidden field we wouldn't have this problem.

All tests have passed.

+1

Selectize fields which require or allow user text input won't work with this patch.


ISSUE-62 - Allow sugarcane to be placed on sand

Not vanilla compatible since loading world without this change would cause all sugar cane on sand to break


WARNING - updating to Microsoft.AspNetCore.App (2.1.1) completely breaks IIS

From @Bridgeway on June 21, 2018 9:17
Tempted by the Updates option in "Manage Packages for Solution" in VS 2017, I thought it would make sense to upgrade from the 2.1.0 preview final release version.
However after doing so, I noticed several packages that were removed during the upgrade were not re-installed and after this whenever running by clicking the green arrow next to IIS Express I got 502.5 at first from Chrome with no ability to debug web application at all, then the browser just flashed up and and the app stopped.
So it seems at the moment it is best to stick with the 2.1.0 preview version.
Hopefully this post will save others loads of wasted time :(
Copied from original issue: dotnet/corefx#30573

FYI: The Application log in Event Viewer shows the following error:
Application 'MACHINE/WEBROOT/APPHOST/XXXX' with physical root 'C:\Dropbox\kh\Code\XXXX\src' failed to start process with commandline 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\Extensions\Microsoft\Web Tools\ProjectSystem\VSIISExeLauncher.exe -argFile "C:\Users\BjornSigurd\AppData\Local\Temp\tmpAD46.tmp"', ErrorCode = '0x80004005 : 0.

Confirmed, seems to relate to https://github.com/aspnet/Home/issues/3241

I updated the SDK to 2.1301 and update the NuGet packages, but now I get a build error in VSTS with the implicit SDK reference to Microsoft.AspNetCore.App. The migration guide (2.0 -> 2.1) says that you should omit the version number, but this leads to the situation that the build uses v2.1.0 instead of the available 2.1.1. This results in the following build error:
NU1107: Version conflict detected for Microsoft.AspNetCore.Hosting. Reference the package directly from the project to resolve this issue. FileStorage.Api -> Microsoft.AspNetCore.AzureAppServicesIntegration 2.1.1 -> Microsoft.AspNetCore.Hosting (>= 2.1.1) FileStorage.Api -> Microsoft.AspNetCore.App 2.1.0 -> Microsoft.AspNetCore.Hosting (= 2.1.0). Errors in C:\agent\_work\20\s\FileStorage.Api\FileStorage.Api.csproj NU1107: Version conflict detected for Microsoft.AspNetCore.Hosting. Reference the package directly from the project to resolve this issue. FileStorage.Api -> Microsoft.AspNetCore.AzureAppServicesIntegration 2.1.1 -> Microsoft.AspNetCore.Hosting (>= 2.1.1) FileStorage.Api -> Microsoft.AspNetCore.App 2.1.0 -> Microsoft.AspNetCore.Hosting (= 2.1.0).)
I guess I have to explicitly set the version of the package, although the migration guide told me not to.
See https://docs.microsoft.com/de-de/aspnet/core/fundamentals/metapackage-app?view=aspnetcore-2.1

Also results in a package version error if you try to use Entity Framework Core 2.1.1 without specifying a version for Microsoft.AspNetCore.App.
Warning	NU1608	Detected package version outside of dependency constraint: Microsoft.AspNetCore.App 2.1.0 requires Microsoft.EntityFrameworkCore.SqlServer (= 2.1.0) but version Microsoft.EntityFrameworkCore.SqlServer 2.1.1 was resolved.	MyProject	C:\MyProject\MyProject.csproj	1

Warning	NU1608	Detected package version outside of dependency constraint: Microsoft.AspNetCore.App 2.1.0 requires Microsoft.EntityFrameworkCore.Tools (= 2.1.0) but version Microsoft.EntityFrameworkCore.Tools 2.1.1 was resolved.	MyProject	C:\MyProject\MyProject.csproj	1

Error	NU1107	Version conflict detected for Microsoft.AspNetCore.Hosting. Reference the package directly from the project to resolve this issue.
 MyProject -> Microsoft.AspNetCore.AzureAppServicesIntegration 2.1.1 -> Microsoft.AspNetCore.Hosting (>= 2.1.1)
 MyProject -> Microsoft.AspNetCore.App 2.1.0 -> Microsoft.AspNetCore.Hosting (= 2.1.0).	MyProject	C:\MyProject\MyProject.csproj	1

As @zuckerthoben said, ignoring the migration advice and specifying a version for Microsoft.AspNetCore.App seems to be the way to fix this.
.NET Core 2.1 and Microsoft.AspNetCore.App have been out for a while now - it would be nice to update the migration guide to stop others following its problematic advice and wasting time.

@cocowalla you are running into a known issue with the 2.1.0 package and 2.1.300 SDK. I recommend installing the latest .NET Core SDK on your machine, however, VSTS has not yet updated their images to 2.1.301 (see https://github.com/Microsoft/vsts-image-generation/issues/168). So, the only available workaround is to put the Version attribute on the PackageReference.
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.1" />
  </ItemGroup>

⚠ please be aware that when you add Version="2.1.1" to your project, you will need to have the 2.1.1 runtime installed on your deployment servers for your app to work. Your app will still compile, even if the 2.1.1 runtime is not installed, but your server may fail to start (HTTP 502.5) because the 2.1.1 runtime (or higher) must be present
cref https://github.com/aspnet/Docs/pull/7540 and https://github.com/aspnet/Home/issues/3292

I will completely skip 2.1.1 and wait for 2.1.2.
I am using Visual Studio for productive development, not technical hassle...  ; )
Please make sure that all the SDK/version etc stuff works smoothly.
For instance, in my 'Control Panel' > 'Programs' folder, I now have an older .Net Core SDK with a higher version number than the SDK following following todays Visual Studio upgrade to VS version 15.7.5.
Personally, I think smooth installation should be prioritized above new or improved functionality.

I will completely skip 2.1.1 and wait for 2.1.2.

FYI - 2.1.2 became available earlier this week. It includes a few security patches, so you may want to take a look. (See https://blogs.msdn.microsoft.com/dotnet/2018/07/10/net-core-july-2018-update/)

I am using Visual Studio for productive development, not technical hassle... ; )

Deeply sorry. We learned too late that our original design was not equipped to handle servicing events. We've spent the last week discussion alternatives that we can reasonably implement soon to solve this issue. (cc @nguerrera)

For instance, in my 'Control Panel' > 'Programs' folder, I now have an older .Net Core SDK with a higher version number than the SDK following following todays Visual Studio upgrade to VS version 15.7.5.

This is a known issue. Please use https://github.com/dotnet/core-setup/issues/4188 for further discussion on the pros/cons of installers which remove old versions. (I personally agree, which is why I opened the issue, but there are some implications we have to think through.)

Ok, so you say that upgrading from 2.1.0 to 2.1.2 using NuGet Package Manager will be plug&play?
I have the latest VS version (15.7.2) which installed 'Microsoft .NET Core SDK - 2.1.202 (x64).

Actually, I would recommend keeping your PackageReference set to 2.1.1. I realize this is a confusing behavior, and it's something we're trying to address soon (see ongoing discussion here https://github.com/aspnet/Home/issues/3307).
The shortest answer I can give as to "why" is that the PackageReference to AspNetCore.App is special. The version acts as a minimum version. So, if you download and install the 2.1.2 runtime, your application will roll forward and run on 2.1.2 because it is the highest patch higher than 2.1.1. It doesn't work the other way around. If you update your PackageRef to 2.1.2 and your machine only has 2.1.0 or 2.1.1, .NET Core won't run the application.

What does "your machine only has 2.1.0 or 2.1.1" mean?  (If you talk about the SDK, I have 2.1.202 which I assume is a 2.1.2 version).

So, the 2.1.202 SDK only includes the 2.0.9 runtime (confusing too, I know.1) The 2.1.* runtimes are included with the .NET Core SDK starting in 2.1.300. The latest SDK is 2.1.302. This includes the 2.1.2 runtime.

1 Starting with SDK 2.1.300 and going forward, the SDK . will match the . of the runtime it includes.

So, if I

Install the 2.1.302 SDK
Use NuGet Package Manager in my VS project to upgrade to .Net Core 2.1.2
I will be all good?

Yes, 2.1.302 SDK + the 2.1.2 packages will work.
Self-contained is 95% self-contained. The other 5% is machine pre-requisites depend in on OS. for example, you need libcurl3 and others on Ubuntu, or the C++ 2015 Redist for Windows 7 SP 1. Windows 10 or Windows Server 2016 have all the prerequisites by default. See https://docs.microsoft.com/en-us/dotnet/core/windows-prerequisites  for details.

Thank you for your good and understanding explanations.
2.1.302 SDK + NuGet Package Manager update to 2.1.2 worked seems to work fine.
Also, deployment of self-contained application (to Windows Server 2016 Datacenter) works fine by just using a plain application file copy.

** ERROR WHILE TRYING TO UPDATE ** The current .NET SDK does not support targeting .NET Core 2.1. target .NET Core 2.0 or lower or use a vs of the .NET SDK that support NET Core 2.1

@natemcmaster the post above contains unrelated link - likely spam (the account was created 11 hours ago).
Can you please delete it? (I don't have the edit-super-powers on aspnet org :()


Interfaces that extend Symbol can't be used as computed props

Bug Report
Extending a Symbol allow the variable to be used as a symbol key. See:
https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgJIgFYQWYB7EAaQgE9kIAPSEAEwGdkBlEgWwCM8AbZAbwF8AsAChhCAnTDIA1qWQBeJqw6cAFAEpkcBuiw58RUsNHjJMPHnm9hyZAG0ZJALoAuZAHIAbnE4BXCG+E+IA
🔎 Search Terms
"extends symbol"
🕗 Version & Regression Information
This errors on all versions tried on the TypeScript playground
⏯ Playground Link
Playground link with relevant code
💻 Code
Note: this is an issue because it it means that the recommended pattern in Vue 3 can't be used to inject values in test environments like Vitest without explicitly re-casting to symbol. https://vuejs.org/guide/typescript/composition-api.html#typing-provide-inject

### 🙁 Actual behavior

A value that is a symbol, but cast as an interface that extends symbol, is no longer recognized as a symbol.

### 🙂 Expected behavior

Because the interface extends symbol, it should qualify as a symbol key.

Note: this is an issue because it it means that the recommended pattern in Vue 3 can't be used to inject values in test environments like Vitest without explicitly re-casting to symbol.

Perhaps it would be good to include some code to demo this problem.
Reading the Vue docs we might find this:

To properly type injected values, Vue provides an InjectionKey interface, which is a generic type that extends Symbol.

Honestly, it just sounds like an abuse of the compiler - especially given the fact that T doesn't appear anywhere in the InjectionKey, it's just used as a type param (Vue's source code here)

@Andarist

Honestly, it just sounds like an abuse of the compiler

I'm not a member of the Vue team, but I'm sure they would love to know a different way to support this pattern:
// File 1
provide(key, someValue) // key must be string, number, or symbol

// File 2
inject(key) // return value must be the type of `someValue`

Regardless, even though I discovered this because of Vue's API, it's not really about Vue. The issue is: why is an interface that extends symbol not allowed to be used as a key?

Perhaps it would be good to include some code to demo this problem.

I did? The playground link is most simplified version of the issue.

I'm not a member of the Vue team, but I'm sure they would love to know a different way to support this pattern:

Perhaps they could reconsider the API. React does a similar thing with its createContext and it doesn't suffer from that because the type is "bound" by the createContext factory and doesn't have to "provided" to both Provider and useContext separately. That's a tangent discussion though - but I feel like they are using this pattern to accommodate their API and that with a different API the problem would just go away).

The issue is: why is an interface that extends symbol not allowed to be used as a key?

Only unique symbols can be used as keys like that. Symbol() factory is kinda special for TS and it only returns unique symbols when you call Symbol() in the top-level scope. Remember that those might have to be printed in declaration files so it's not that obvious how you'd emit declarations even for this:
function wrapper() { return Symbol() }
export const obj = {
  [wrapper()]: 1
}

What should be the type of obj? Remember that each wrapper call gives you a new unique symbol at runtime so you can't emit something "static" for this.
But either way - this is just a showcase of how symbols are a little bit special. In your case, you are altering (by casting) the type there. extends Symbol inherits from the interface, it might inherit all of the properties from there etc but it doesn't inherit the related "primitive type".
This doesn't work either:
interface InjectionKey extends String {}
declare const key: InjectionKey
const foo = { [key]: 'value' } // error

function accept(a: string) {}
accept(key) // error as well

I did? The playground link is most simplified version of the issue.

I referred to this part: "the recommended pattern in Vue 3 can't be used to inject values in test environments like Vitest without explicitly re-casting to symbol"
It seems like usually, Vue users don't suffer from this problem since there are not a lot of issues reported about this here. So I wonder how your use case is different.

@Andarist I think you're right. Vue's official TypeScript API for provide / inject is not great and an abuse of the type system.
I went ahead and made this: https://github.com/matthew-dean/vue-atoms. That seems to solve the type issue and doesn't abuse the type system, so we could probably close this.

It seems like usually, Vue users don't suffer from this problem since there are not a lot of issues reported about this here. So I wonder how your use case is different.

provide and inject are fairly new, so not many people use it, I think. Being new, I'm not sure why they designed it by default in a way that's impossible to infer the type, while, as you note, React Context and other state libraries don't have this issue. I think it was just poorly-thought-out.

extends Symbol is not the same as being a symbol; Symbol is the global interface that defines which properties are available on symbol values.
I would write
interface InjectionKeyProps {
  idunno: string;
}

const key = Symbol() as (symbol & InjectionKeyProps);

const foo = {
  [key]: 'value'
}

@RyanCavanaugh I agree, and unfortunately Vue types fail if you do that, so I could open that as a specific Vue types bug. Thanks for feedback!


Revert "Fix: change check function for waitProjectAsync"

Reverts parodos-dev/parodos#322
The fix is wrong: the waitAsyncProjects ends too early.

/approve
/lgtm


asusctl 4.x support

asusctltray wont start after recently update of asusctl
➜  ~ asusctltray
Traceback (most recent call last):
  File "/usr/local/bin/asusctltray", line 224, in <module>
    TrayIcon()
  File "/usr/local/bin/asusctltray", line 64, in __init__
    self.presets = self.config["power_profiles"].keys()
KeyError: 'power_profiles'

➜  ~ asusctl --version
App and daemon versions:
      asusctl v4.0.3
        asusd v4.0.3

Component crate versions:
    rog-anime v1.1.0
     rog-aura v1.1.0
     rog-dbus v4.0.2
 rog-profiles v1.1.2
rog-supported v4.0.0
  supergfxctl v2.0.0

Product family: ROG Zephyrus G14
Board name: GA401QM

have you any plans to update?

The current situation with asusctl is quite prone to changing (and I had a discussion with asusctl's developer on the Discord about the 4.x release). Many breaking changes were made both to the dbus interfaces and the configuration files (they're now in a TOML-like format instead of JSON), but I'm working on several fixes which I want to push a single commit, so for now asusctltray is completely broken. Said fixes are not trivial at all and will take some time and considerable code refactoring, but I'm positive I can manage. I've already fixed the dbus interfacing code and I'm currently tackling reading the configuration files as the python standard library does not support such a file format. And thank you for opening an issue, this will stay open and pinned as long as this project is in a broken state (or at least asusctl gets a stable 4.x API)
PS: my plans include adding a way to toggle turbo boost on demand, which was removed from asusctl in this latest release

Implemented everything in dcffa98. If more functionality is required or asusctl 4.1.x comes out and something breaks, this issue will be reopened.


update yard per github warning

Github sent me a warning about an out of date version of yard.  PR'ing an update to satisfy that.

Thanks. I’m on paternity leave but this was pretty simple.


clini: init at 0.1.0

Description of changes
clini is basically a faster alternative to crudini (which is already packaged, but takes almost a second to change one value in a small ini).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 201378 run on x86_64-linux 1

1 package built:

clini


build(deps-dev): bump dependencies

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (c3b16f2) compared to base (28d7c2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          619       619
  Branches        48        48
=========================================
  Hits           619       619

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix(cynosdb): support enable/disable public access

:tada: This PR is included in version 1.20.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Availability update dataflows-introduction-self-service.md

As a capacity manager in DoD environment, I can confirm that Dataflows are available in the DoD (app.mil.powerbigov.us) environment.  I have created multiple Dataflows myself in that environment.

@davidiseminger - can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Okay, thanks for your confirmation, and your contribution!
#sign-off


Sleep sort description added

Have you read the Contributing Guidelines on Pull Requests?
yes
Description
In this sort, we create different threads for every element within the input array, then each thread sleeps for an amount of the duration which is proportional to the value of the corresponding array element.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Fixes #7142

@HarshCasper @ankitaggarwal23 @bhav09 @gat786 @anushkrishnav can anyone please review this pr

Did you forget to commit the code file?

@gat786 no I have just added the description as a part of documentation in Resources folder


Code fixes - suggest decorators for vars, resources, modules & outputs

Parameter decorator code fixes was recently added under #5544. It would be good to expand this to other declarations which support decorators.

@anthony-c-martin Can you provide a list (or documentation) of decorators that are supported for vars, resource, modules and outputs?

Completions in VS code for this should be accurate and complete, which you can look at.

Looks like we support the following:
var: @description()
output: @description()
resource: @description(), @batchSize() (only when using a for expression)
module: @description(), @batchSize() (only when using a for expression)

FYI, the way to figure this out programatically is using the FunctionFlags here:
https://github.com/Azure/bicep/blob/207be1b380d914319a99e86f1fdb249de6e66e76/src/Bicep.Core/Semantics/Namespaces/SystemNamespaceType.cs#L704-L827
We have various flags indicating which type of statement each decorator is permitted on - this is how the completions suggest the right options:
https://github.com/Azure/bicep/blob/eb42cad9597de04b7a881fa8a0a666e639acb614/src/Bicep.Core/TypeSystem/FunctionFlags.cs#L28-L56
Here's the logic that we use when offering completions to show the right set of decorators based on statement type:
https://github.com/Azure/bicep/blob/207be1b380d914319a99e86f1fdb249de6e66e76/src/Bicep.LangServer/Completions/BicepCompletionProvider.cs#L668-L672

The problem statement here is that Ctrl + . doesn't bring up an equivalent list of code fixes on non-param declarations.


Update certificates used in TLS tests to use RSA keys & SHA-256 signature algorithm so that TLSv1.3 support can be added

Problem
In TLSv1.3, certificates using SHA-1 signature algorithm are considered legacy and it's not recommended that TLSv1.3 implementations accept certificates that use SHA-1 signature algorithms.
In RFC8446, section <IP_ADDRESS>.  Receiving a Certificate Message
SHA-1 is deprecated, and it is RECOMMENDED that any endpoint receiving any certificate which it would need to validate using any signature algorithm using a SHA-1 hash abort the handshake with a "bad_certificate" alert.
Support for Digital Signature Algorithm (DSA) is also removed in TLSv1.3:
In RFC8446, section 1.2 Major Differences from TLS 1.2
Other cryptographic improvements were made, including changing the RSA padding to use the RSA Probabilistic Signature Scheme (RSASSA-PSS), and the removal of compression, the Digital Signature Algorithm (DSA), and custom Ephemeral Diffie-Hellman (DHE) groups.
Solution
Update all certificates (server and client) used in Pulsar tests to use RSA keys & SHA-256 signature algorithms so that it's possible to add TLSv1.3 support.
Additional context
#8580, #8581
TLSv1.3 is available in Java 8 since 8u161 (since OpenJDK 8u272).

@lhotari what's the status of this issue today?


api: Deprecate Pod.labels field

Deprecate Pod.labels field which contains Cilium identity labels, and document that it has been replaced by Pod.pod_labels field.
Ref: #794

CC: @rolinh @kaworu

Thanks for the ping @kkourt, FWIW we added support for the new pod_labels field with https://github.com/isovalent/hubble-timescape/commit/75dfde3ee6597c335d169025c5dc2d0f7d4cb912.


ENH: filters check whether their geometry is set

Attempt at solving #270.
As suggested, this affects all filters returned by grep Geometry include/*.h | grep itkSet | sed "s/:.*$//g" as of 72878637c67c55a709c3841bfd51cf0cdce8f035. I suspect that some already existing checks are to be moved in VerifyPreconditions but I guess that's something we can leave for future pull requests.
With this version, rtkAmsterdamShroudTest fails because of those lines. I don't really know what this filter does and if it is supposed to work without geometry. Can someone explain if this test should be left as it currently is? If yes, I can remove the geometry check.

Looks great. Please remove the superfluous lines found with grep -r "GetGeometry() == nullptr" -A 3. And for the Amsterdam shroud, the geometry is not mandatory, see the test (and the comment) here. So undo the modifications of rtkAmsterdamShroudImageFilter.h*. I'll merge when all this has been changed! Thanks a lot, Simon

Should be alright now, tell me if you agree then I'll squash everything!


Add mappings for relative movement

I've named the forward and side velocities for a LivingEntity velocityWalk and velocityStrafe based off their names in the controls, but falling is just as common as jumping so I changed that to velocityVert. That seems a bit clunky and I'd like ideas.
relativeVelocityToGlobal is also a clunky name but I can't think of a more succinct way to phrase what it does.
I considered naming moveRelative as moveSelf because it's only used with MovementType.SELF in LivingEntity, but I haven't checked subclasses so it might be overridden elsewhere.

oh shit, I re-read things and re-calculated stuff and I think I mixed a few names up.

Just throwing this out there: in Quake 1, these variables were named sidemove, forwardmove, and upmove. I've always liked those names, and the forward/up names have the benefit of making it clear which direction is positive vs negative (i.e. a positive up is up, a negative up is down).
Also, 'move' and 'relative' are both bad descriptions of what's going on in these functions. There's no movement happening at all: position never changes, only velocity. I don't have a good name for it, but the function is more based around updating velocity while applying friction/dampening effects. Maybe something like updateVelocity or applyVelocity or something like that.

I do like @squeek502's suggestion, 'move' means go to a specific position so in this case it would be wrong.
The field names make more sense as well.

I'm gonna keep with the velocity scheme for the fields, so they're sideVelocity, upVelocity, and forwardVelocity. I've decided to make doRelativeMovement -> applyVelocity and moveRelative -> updateVelocity.

Did some more digging into this:

The LivingEntity (FFF)V function could probably be named travel as there is a this.world.getProfiler().push("travel");/this.world.getProfiler().pop(); surrounding its call in LivingEntity.updateMovement. Note that this function does affect position.
The side/forward living entity fields are mostly direct analogs to the float fields in net.minecraft.client.input.Input, and I think calling them velocities is wrong, as they are treated as always being between -1 and 1, and are more about the direction the player intends to be moving (relative to their look direction, which is only applied later). Also worth noting that speed effects are applied to these fields (i.e. when sneaking they get multiplied by 0.3, etc) I'm having trouble coming up with a good name for them, but I don't think velocity should be it.
friction is probably an incorrect name for the 4th argument of Entity (FFFF)V (I was wrong about that before). Throughout the code its treated as a movement speed argument from what I can tell. For example, in the EntityLiving (FFF)V function, this is how the Entity (FFFF)V is called for normal movement (not falling, not in liquids, etc); comments added by me:

// get the friction modifier of the block we're standing on
if (this.onGround) {
    float_10 = this.world.getBlockState(blockPos$PooledMutable_1).getBlock().getFrictionCoefficient() * 0.91F;
}

// get friction and apply the block's friction modifier
float_11 = 0.16277137F / (float_10 * float_10 * float_10);
if (this.onGround) {
    // method_6029 is a getter for movement speed (the value is set in `updateMovement`
    // using the return of `this.getAttributeInstance(EntityAttributes.MOVEMENT_SPEED)`)
    // and then friction is applied to that move speed
    float_13 = this.method_6029() * float_11;
} else {
    // seems to be fly speed or something, not sure when this is used
    float_13 = this.field_6281;
}

// update velocity based on intended movement direction and move speed with friction already applied
this.method_5724(float_1, float_2, float_3, float_13);

So, my recommendations for naming this stuff:

Entity (FFF)V should be called travel or something better that conveys that it takes normalized (-1 to 1) intended movement (a combo of direction+speed, see the note about speed effects above) and actually moves the entity based on that. Arguments could be named something like intendedMovementSideways, intendedMovementUp, intendedMovementForward?
EntityLiving (FFFF)V should be called updateVelocity or something better that conveys that it takes intended movement and movement speed and updates velocity accordingly (projects intended movement on the player's look direction and applies the movement speed). Argument names should match the (FFF)V function and the fourth should be named movementSpeed
The LivingEntity fields should match the (FFF)V arguments
net.minecraft.client.input.Input fields could also be given the same names as the side/forward fields.

some description of float_4 in (FFFF)V
Wrote this while trying to understand the 4th argument to the `(FFFF)V` function, not sure if it's of any use but figured I'd keep it somewhere

(FFFF)V does float_5 = float_4 / length_of_intended_movement_directions (where length_of_intended_movement_directions is set to 1 if its lower than 1), and then multiplies each intended movement direction by float_5, and then projects the intended movement directions on the look direction of the entity and modifies velocity based on that. The float_4 / length_of_intended_movement_directions means that the larger that length_of_intended_movement_directions is, the smaller float_5 will be. My best guess is that this is to combat the 'pressing forward/strafe together makes you go faster' problem

@squeek502 wait, you mean EntityLiving (FFF)V -> travel and Entity (FFFF)V -> updateVelocity, correct? I think you mixed those two up in the last block.
I wanted to avoid the name travel since I thought it was a voldemap name, but if there's a constant string in the code for it I'll name it that.

@squeek502 wait, you mean EntityLiving (FFF)V -> travel and Entity (FFFF)V -> updateVelocity, correct? I think you mixed those two up in the last block.

Yes, fixed.

Can this be closed now?

I believe so, yes. We've got some really good names in Squeek's PR, so we're all good here.


bazarr dracula domain fix

This should fix Bazarr Dracula theme not applying.
Thank you for the PR!
Please remember to add a before and after screenshot(s) on any css changes!

Thanks :)


Add option to swap positions of available and selected lists

The option "availableOnLeft" will place the available items on the left
and selected items on the right when true, and vice-versa when false.
This will resolve issue #93.

Just wanted to point out that crdeutsch is doing a good job of integrating pull requests into his fork, and there's already a patch in master for this feature:
https://github.com/crdeutsch/multiselect/

Yeah, I saw that after i put up the pull request. I've since merged his version.


updated eslint to match wallet eslint rules

What kind of PR is this?:

/kind refactor

Codecov Report

Merging #227 (c324aee) into main (b7f163e) will decrease coverage by 1.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   80.03%   78.38%   -1.66%
==========================================
  Files          45       44       -1
  Lines         511      495      -16
  Branches      117      109       -8
==========================================
- Hits          409      388      -21
- Misses         95      102       +7
+ Partials        7        5       -2

Impacted Files
Coverage Δ

src/pages/blocks/index.tsx
81.81% <0.00%> (-18.19%)
:arrow_down:

src/pages/masternodes/index.tsx
54.83% <0.00%> (-12.91%)
:arrow_down:

src/layouts/contexts/WhaleContext.tsx
59.25% <0.00%> (-7.41%)
:arrow_down:

src/components/prices/PriceOracleTable.tsx
86.66% <0.00%> (-6.67%)
:arrow_down:

src/components/prices/PriceTickerDetail.tsx
75.00% <0.00%> (ø)

src/pages/dex/index.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f163e...c324aee. Read the comment docs.


Refine additional installs in the readme

I noticed earlier that the installation steps in our README have started acting up, for whatever reason:

I've done some quick tidying to this section of the docs, that should resolve this issue.
While I was at it, I also removed a couple of Americanism I identified in the README.

As a side note, the README can now be spellchecked using the logic found in https://github.com/moj-analytical-services/splink/pull/2000.

Oh, and I've managed to trim the README... let's resolve that one quickly

This: https://github.com/moj-analytical-services/splink/pull/2007#issuecomment-1969040237 was a simple copy-paste error that has been resolved in https://github.com/moj-analytical-services/splink/commit/cf4d6deb228a3b770d0106700333fa9b755295ca


Allow ProcessCallback To Work When Dealing With Arcade Bodies That Do Not Have GameObjects

This PR

Fixes a bug

Describe the changes below:
Following up on a recent discussion in the discord / this commit this PR fixes a small bug in the separate() function.
On these lines: https://github.com/phaserjs/phaser/blob/master/src/physics/arcade/World.js#L1946-L1950 - we see that the "detached" arcade body (the Body without a game object) is treated as a sprite (it isBody - unlike a sprite that has the body property .body) but in the processCallback this same dual nature of "sprite" in this context is not applied in reverse, the process callback will only pass back game objects, leading to potential bugs in consuming code trying to run a processCallback on their detached body colliders. This fix implements the same check in reverse, if the body has no gameObject (no sprite) the body itself will be returned to the callback, so that it can be executed/evaluated appropriately.

👍


Console does not pick up non-default Pythonpath settings from Python Manager

From<EMAIL_ADDRESS>on 2013-06-18T13:01:13Z
Spyder Version:  2.1.9
Python Version:  2.7.3
Qt Version:      4.8.1, PyQt4 (API v2) 4.9.1 on Linux
What steps will reproduce the problem?
1.Change PythonPath to non-default location on Linux
2.Run import numpy as np, print np.file
3.it will print "/usr/lib/python2.7/dist-packages/numpy/init.pyc" which is different then location you specified. What is the expected output? What do you see instead?
Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1446

From ccordoba12 on 2013-09-04T12:02:20Z
Our Python path manager adds their paths to the end of sys.path. To make what you want work, you need to change your current interpreter. For that please go to
Tools > Preferences > Console > Advanced Settings > Python Executable
and add the full path of the python version you want to use there.
Status: Invalid
Labels: Cat-Console


how to input audio?

I couldn't input audio into the audio input ports of any nodes. The audio ports cannot be connected, regardless of whether it is a WAV file or an MP3 file. Could you please tell me the reason for this? How should I solve this problem?

Can you show me what your workflow looks like? You might have to right click on the node and click "fix nodes".

I have two "load audio" nodes. Please see the image: Node A is summoned by clicking the "audio" input port of "vocal removal," while Node B is summoned from the right-click menu (as shown, it is in the root directory of the audio menu, not under the RVC-studio sub-options). Node A can connect to the vocal removal (and other nodes that require audio input), but Node B cannot. I personally suspect that it might be due to a conflict in node names. My ComfyUI is an integrated package created by someone else, not self-deployed. Additionally, where should I place the UVR models for vocal separation, the singer voice models, and the whisper models? Lastly, can this node be used to train vocal models?  I would appreciate your guidance. Thank you very much.

Your script forces downloading the model from huggingface.co. Could you please tell me which file I should modify to change this setting? My network is restricted, and I can't download it. Later, I individually accessed /sayanoai/rvc-studio and found only one safetensors model of over 300MB. Actually, I already have these models, but I don't know where to place them.

Yep, I suspect there's a naming conflict somewhere with the Load Audio Node. All the nodes that work with Comfy-RVC should be organized under the RVC-Studio tab in the menu.
Your RVC models should go in ComfyUI\models\RVC, UVR models go in ComfyUI\models\UVR.

The example workflows are outdated in that regard, but I found fitting conversion nodes from this custom node pack :
ComfyUI-VideoHelperSuite
This is the reworked version of the complete example, it is a little customized already, but does not use any other nodes than that videohelper suite and all settings are at the default pretty much.

complete-ai-voice-changer_custom.json

Thanks for that, the latest update should have an extra output that works fine with the regular comfyui audio:


Please document spread filter requirements for "quantity size"

When creating a market and adding initial liquidity, it's possible to get the message "Increase quantity size to both sides to Pass", but it's not explained what that means or what the minimum quantities one needs to have the filter pass are. This information should be added to the market creation help modal.

@Chwy5 we should add this to the modal and the help center.
@petervecchiarelli

Can you point me to the code where it's checked? Searching with git grep for "increase quantity", "quantity size", "both sides" and even "to pass" didn't find me the relevant place.


Roll engine ae8e6d9f4699..ebb5b909fbb1 (2 commits)

https://github.com/flutter/engine/compare/ae8e6d9f4699...ebb5b909fbb1
git log ae8e6d9f46990b9585dc1fb5b8aabe491c08aaf3..ebb5b909fbb10dad2275acd4fc8ec1d9744a0bf6 --no-merges --oneline
ebb5b909f IOS Platform view transform/clipping (flutter/engine#9075)
13145e90c ios-unit-tests: Started using rsync instead of cp -R to copy frameworks. (flutter/engine#9471)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5447068512944128

Commit queue failed; closing this roll.


Separate pretty printing concern

Instead of maintaining pretty printing logic inside the IR nodes, this PR puts it into a class, which makes use of functools.singledispatch on it's format method. This is a light weight implementation of a design approach we use heavily in GT4Py, for pretty printing as well as code formatting of our zoo of IRs.
Advantages

IR node code is more concise
No reliance on class hierarchies or IR nodes knowing details of each other
Any node can be petty printed in a format which is consistent with pretty printing the root node.
Pretty printing can become as customizable as it needs to be without intrusion into the IR code
Multiple Pretty printers could coexist with different formatting for the same types
str, repr methods of the IR nodes are free to be optimized for traditional purposes

Disadvantages

Breaking changes in the IR nodes will require changes in a separate module

This is mitigated by testing, as failing tests will indicate where the changes are due

Unchanged

Breaking changes in the IR nodes will not require more complex changes to the formatting this way, only the location of the changes is different

Additional improvements (could be separated out)
parametrize the fixtures in the config tests, to allow more code reuse.

I like the PR a lot actually, thanks! Still there are probably a few things I did not understand, see questions in the review.


Fixed blinking navbar when clicked

In a bigger screen (> 768 px), when navbar list items are clicked, the navbar flashes briefly.
This is a fix to prevent the navbar from flashing.

Tried out this fix on my personal project using this template and I can confirm it stopped the flickering! Thanks @yulonglong!

bump


Complete reset of browser settings and deletion of history on every new launch of live server

I'm submitting a...

[ x] Regression (a behavior that used to work and stopped working in a new release)
[ x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Other: <!-- Please describe: -->

Current behavior

On every initial launch, ie, when opening a project, and then launching live server, the extension resets all browser settings and deletes all history.
Expected behavior

Environment
Browser:

- [ x] Chrome (desktop) version XX
- [x ] Firefox version XX
- [x ] Safari (desktop) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:

- Live Server: <!-- Check which version is installed -->
- Platform:  <!-- Mac, Linux, Windows -->
- Visual Studio Code: <!-- `code --version` -->

Others

Yo can one of the owners please delete my issues? Lol 😅

@ritwickdey Please delete this issue when you have some time, I would really appreciate it. I'll even pay you if that's what has to be done lol.


Create Images page (images.html) and folder for images

This page will contain images, at the current time only screenshots of the game client. Will also need to create folders /images/screenshots/

Took 4 screenshots which should be sufficient for the time being. This can be added after Issue #20 is sorted out.

Need to upload these to the content branch in the images/screenshots/ folder, then add the images to the webapp/WEB-INF/images.html directory.

Page content and image links have been added to images.html. Now only need to add the image files to the relevant folders, and test and format images for ideal sizing.

All done and working, and merged to master.


Summarize Issue: IndexError: index out of range in self

Getting this error when running Summarize
"Return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
IndexError: index out of range in self"

Summarization is currently removed and will be integrated with GPT-3 in the next update and should fix this issue.


Shell error "Failed to fill utterance template, There is no slot with this name nor did you pass the value explicitly when calling the template. Return template without filling the template"

Rasa version:
2.0
Rasa SDK version (if used & relevant):
Rasa X version (if used & relevant):
Python version:
3.7
Operating system (windows, osx, ...):
osx
Issue:
Im seeing errors in Rasa Shell claiming about a response template I have containing buttons. The template looks like this:
  utter_ask_device_type:
  - text: Devices
    buttons:
    - title: Mac
      payload: /inform{"device_type":"mac"}
    - title: PC
      payload: /inform{"device_type":"pc"}
    - title: Linux
      payload: /inform{"device_type":"linux"}
    - title: iOS
      payload: /inform{"device_type":"ios"}
    - title: Android
      payload: /inform{"device_type":"android"}

And my slot looks like this
slots:
  device_type:
    type: text
    influence_conversation: false

Error (including full traceback):
2020-11-05 14:04:33 ERROR    rasa.core.nlg.interpolator  - Failed to fill utterance template '/inform{"device_type":"pc"}'. Tried to replace '"device_type":"pc"' but could not find a value for it. There is no slot with this name nor did you pass the value explicitly when calling the template. Return template without filling the template.
Traceback (most recent call last):
  File "/Users/nbm/Library/Caches/pypoetry/virtualenvs/w3-digital-assistant-rasa-core-V6FNUaHk-py3.7/lib/python3.7/site-packages/rasa/core/nlg/interpolator.py", line 28, in interpolate_text
    text = text.format(values)
KeyError: '"device_type":"pc"'
2020-11-05 14:04:33 ERROR    rasa.core.nlg.interpolator  - Failed to fill utterance template '/inform{"device_type":"linux"}'. Tried to replace '"device_type":"linux"' but could not find a value for it. There is no slot with this name nor did you pass the value explicitly when calling the template. Return template without filling the template.
Traceback (most recent call last):
  File "/Users/nbm/Library/Caches/pypoetry/virtualenvs/w3-digital-assistant-rasa-core-V6FNUaHk-py3.7/lib/python3.7/site-packages/rasa/core/nlg/interpolator.py", line 28, in interpolate_text
    text = text.format(values)
KeyError: '"device_type":"linux"'
2020-11-05 14:04:33 ERROR    rasa.core.nlg.interpolator  - Failed to fill utterance template '/inform{"device_type":"ios"}'. Tried to replace '"device_type":"ios"' but could not find a value for it. There is no slot with this name nor did you pass the value explicitly when calling the template. Return template without filling the template.
Traceback (most recent call last):
  File "/Users/nbm/Library/Caches/pypoetry/virtualenvs/w3-digital-assistant-rasa-core-V6FNUaHk-py3.7/lib/python3.7/site-packages/rasa/core/nlg/interpolator.py", line 28, in interpolate_text
    text = text.format(values)
KeyError: '"device_type":"ios"'
2020-11-05 14:04:33 ERROR    rasa.core.nlg.interpolator  - Failed to fill utterance template '/inform{"device_type":"android"}'. Tried to replace '"device_type":"android"' but could not find a value for it. There is no slot with this name nor did you pass the value explicitly when calling the template. Return template without filling the template.

Command or request that led to error:
rasa shell

Content of configuration file (config.yml) (if relevant):

Content of domain file (domain.yml) (if relevant):

Thanks for the issue, @dakshvar22 will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

Hi @tatianafrank, thanks for reporting this! Looks to be the same as this one and I think @erohmensing will look into fixing it :-)

You can workaround this issue with double curly braces:
      payload: /inform{{"device_type":"mac"}}

@rgstephens thanks for your response! Is this the permanent solution or are you guys working on a fix to the rasa code? Just wondering if we should hold off on using this workaround if a proper fix is coming in the next release.

The PR you see above your post shows the code change to fix this.

Thanks


Create a Provider (Github/Gitlab) during init and pass it on to other steps

JIRA
n/a
Overview
The high level goal here is to setup the provider once during
initialize. After that, all following steps will respect this
configuration.

created package lib, which now holds

Provider abstraction (for Github or Gitlab)
Repo - allows us to pass along the Provider configuration

centralized the logic to setup a Github or Gitlab client, in the
Provider

This is also prep work that should help simplify adding Github Enterprise support. https://github.com/Clever/microplane/pull/44
⚠ WARNING: This version has a breaking UX change for Gitlab users. We now pass provider and provider-url via flags instead of using env vars to determine (1) Github vs Gitlab and (2) whether or not a custom URL is set. See README.md regarding Gitlab.
NOTE: There's some other cleanup here, apologies for the noise. The key commits for the provider work are:

bc56dbb
72d1c01

Testing

[ ] Test e2e for Github :octocat:
[ ] Test e2e for Gitlab 🧪

seems like CODEOWNERS auto-assignment isn't enabled

Added an integration_test.sh script and caught some errors in the Gitlab (one I just introduced with this PR e56d44a, and one that existed previously e133845) with it. 🥳

seems like CODEOWNERS auto-assignment isn't enabled

fixed here https://github.com/Clever/microplane/commit/e6a3cda3d7f7dabe7a8326f36b3ecd807d4c5314


Android: Svg elements are inside of a PanResponder don't update event.nativeEvent.location

This may be related to https://github.com/react-native-community/react-native-svg/issues/363, but I wasn't sure so I'll file a separate issue.
When Svg elements are inside of a PanResponder, onPanResponderMove's event.nativeEvent.locationX (and Y) do not change for Android, but do for iOS. Demo:
import React from 'react';
import { StyleSheet, Text, View, PanResponder } from 'react-native';
import Svg, { Rect } from "react-native-svg";

class Container extends React.Component {
  constructor(props) {
    super(props);
    this.panResponder = this.getResponder();
  }

  getResponder() {
    const yes = () => true;
    const no = () => false;
    return PanResponder.create({
      onStartShouldSetPanResponder: yes,

      onStartShouldSetPanResponderCapture: no,

      onMoveShouldSetPanResponder: yes,

      onMoveShouldSetPanResponderCapture: yes,

      onShouldBlockNativeResponder: yes,

      onPanResponderTerminationRequest: yes,
      // Active touch or touches have moved
      onPanResponderMove: this.props.onPanResponderMove.bind(this),
      onPanResponderGrant: this.props.onPanResponderMove.bind(this),
    });
  }

  render() {
    return (
      <View {...this.panResponder.panHandlers}>
        {this.props.children}
      </View>
    );
  }
};

export default class App extends React.Component {
  render() {
    return (
      <View>
        <Container
          onPanResponderMove={
            (event) => {
              console.log(
                event.nativeEvent.locationX,
                event.nativeEvent.locationY
              );
            }
          }
        >
          <Svg
            height="100"
            width="100"
          >
            <Rect
              width={100}
              height={100}
              fill="blue"
            />
          </Svg>
        </Container>
      </View>
    );
  }
}

We're developing a prototype app that uses Victory Charts and is affected by this issue. It affects several of the best features of Victory Charts including cursors and scrollable charts.

I have a similar issue. I have a panresponder on a View which contains an SVG.
in onMoveShouldSetPanResponderCapture, dx and dy start with a big value even on the first press. I think this is because mutlipe elements inside the svg report different locations. Also movement speeds (vx, vy) get messed up because of this. I tried to work around it, but without any success.

Maybe its related to https://github.com/react-native-community/react-native-svg/issues/433 ?

This may be of interest:
https://github.com/facebook/react-native/issues/12591
https://github.com/facebook/react-native/pull/15123/files

I think I might have fixed the issue now, can you try with the latest commit from the master branch?

Closing because of inactivity.

Is this fixed? Zoom still doesn't work for Victory Native Zoom container. Unable to Pan Out of Line graph.
"dependencies": {
"victory-native": "^34.1.0"
"react-native-svg": "^12.0.3",
"react-native": "0.62.2",
}

Can you make a repro?

This is a repr code.
`import React from 'react';
import {
StyleSheet,
View,
} from 'react-native';
import {
VictoryLine,
VictoryChart,
VictoryZoomContainer,
} from 'victory-native';
const App: () => React$Node = () => {
return (

<VictoryChart
containerComponent={
<VictoryZoomContainer
zoomDimension="x"
// minimumZoom={{x: 1, y: 0.01}}
/>
}>
<VictoryLine
data={data1.frst}
style={{data: {stroke: 'red'}}}
interpolation="natural"
/>

);
};
const data1 = {
frst: [
{x: 'Mon', y: 6},
{x: 'Tue', y: 2},
{x: 'Wed', y: 3},
{x: 'Thu', y: 2},
{x: 'Fri', y: 5},
{x: 'Sat', y: 1},
{x: 'Sun', y: 6},
{x: 'Mon2', y: 6},
{x: 'Tue2', y: 2},
{x: 'Wed2', y: 3},
{x: 'Thu2', y: 2},
{x: 'Fri2', y: 5},
{x: 'Sat2', y: 1},
{x: 'Sun2', y: 6},
{x: 'Mon3', y: 6},
{x: 'Tue3', y: 2},
{x: 'Wed3', y: 3},
{x: 'Thu3', y: 2},
{x: 'Fri3', y: 5},
{x: 'Sat3', y: 1},
{x: 'Sun3', y: 6},
],
};
const styles = StyleSheet.create({
container: {
flex: 1,
// padding: 10,
justifyContent: 'center',
}
});
export default App;
`

Can you make a repro?

This is a repr code.
import React from 'react';
import {
  StyleSheet,
  View,
} from 'react-native';

import {
  VictoryLine,
  VictoryChart,
  VictoryZoomContainer,
} from 'victory-native';

const App: () => React$Node = () => {
  return (
    <View style={styles.container}>
      <VictoryChart
        containerComponent={
          <VictoryZoomContainer
            zoomDimension="x"
            // minimumZoom={{x: 1, y: 0.01}}
          />
        }>
        <VictoryLine
          data={data1.frst}
          style={{data: {stroke: 'red'}}}
          interpolation="natural"
        />
      </VictoryChart>
    </View>
  );
};

const data1 = {
  frst: [
    {x: 'Mon', y: 6},
    {x: 'Tue', y: 2},
    {x: 'Wed', y: 3},
    {x: 'Thu', y: 2},
    {x: 'Fri', y: 5},
    {x: 'Sat', y: 1},
    {x: 'Sun', y: 6},
    {x: 'Mon2', y: 6},
    {x: 'Tue2', y: 2},
    {x: 'Wed2', y: 3},
    {x: 'Thu2', y: 2},
    {x: 'Fri2', y: 5},
    {x: 'Sat2', y: 1},
    {x: 'Sun2', y: 6},
    {x: 'Mon3', y: 6},
    {x: 'Tue3', y: 2},
    {x: 'Wed3', y: 3},
    {x: 'Thu3', y: 2},
    {x: 'Fri3', y: 5},
    {x: 'Sat3', y: 1},
    {x: 'Sun3', y: 6},
  ],
};

const styles = StyleSheet.create({
  container: {
    flex: 1,
    // padding: 10,
    justifyContent: 'center',
  }
});

export default App;

Can you make a repro?

This is a repr code.
import React from 'react';
import {
  StyleSheet,
  View,
} from 'react-native';

import {
  VictoryLine,
  VictoryChart,
  VictoryZoomContainer,
} from 'victory-native';

const App: () => React$Node = () => {
  return (
    <View style={styles.container}>
      <VictoryChart
        containerComponent={
          <VictoryZoomContainer
            zoomDimension="x"
            // minimumZoom={{x: 1, y: 0.01}}
          />
        }>
        <VictoryLine
          data={data1.frst}
          style={{data: {stroke: 'red'}}}
          interpolation="natural"
        />
      </VictoryChart>
    </View>
  );
};

const data1 = {
  frst: [
    {x: 'Mon', y: 6},
    {x: 'Tue', y: 2},
    {x: 'Wed', y: 3},
    {x: 'Thu', y: 2},
    {x: 'Fri', y: 5},
    {x: 'Sat', y: 1},
    {x: 'Sun', y: 6},
    {x: 'Mon2', y: 6},
    {x: 'Tue2', y: 2},
    {x: 'Wed2', y: 3},
    {x: 'Thu2', y: 2},
    {x: 'Fri2', y: 5},
    {x: 'Sat2', y: 1},
    {x: 'Sun2', y: 6},
    {x: 'Mon3', y: 6},
    {x: 'Tue3', y: 2},
    {x: 'Wed3', y: 3},
    {x: 'Thu3', y: 2},
    {x: 'Fri3', y: 5},
    {x: 'Sat3', y: 1},
    {x: 'Sun3', y: 6},
  ],
};

const styles = StyleSheet.create({
  container: {
    flex: 1,
    // padding: 10,
    justifyContent: 'center',
  }
});

export default App;

Were you able to reproduce the issue?


Dev Task: audio system

The simple way of using audio in Godot is to instantiate a player > add it to the scene > load an audio stream into the player > play the audio > free the player (while making sure it's parent remains in the scene)
This is pretty cumbersome and inefficient, which is why many projects use a Singleton for managing audio by pooling players and preloading some common audio streams. I think it would be a good idea to do the same.

Audio is something we should start to implement as it is a very important feature to give feedback towards the player.


Instant download

Type

New feature

Related JIRA Issue(s)
ENSWBSITES-573
Description

Add InstantDownloadTranscript component for downloading sequences related to transcript or to its parent gene
Add the general-purpose downloadAsFile helper for downloading data present in browser's memory to disk

Other changes

Change the black colour across the site, and add soft-black colour.
Update the Checkbox component to change cursor appearance to pointer when mousing over label, and to catalogue classNames props that can be passed to the Chackbox.
Update the Button component so that the active state of the PrimaryButton and SecondaryButton have a 1px-wide border. This helps avoid changes in block height when toggling between disabled and enabled states of the button.

Views affected
Storybook

@azangru Sorry, I added those three comments yesterday but I didn't realise it was in the review mode so none of them got submitted.


fix(controller): keep special characters in json string when use withItems

Checklist:

[ ] My organization is added to USERS.md.

https://github.com/argoproj/argo/blob/4eaae251d9147b53604481237732bff36a16a91e/workflow/controller/operator.go#L2729
When WithItems setting a array of object json, and one json field value  contains a & or other char which will  becomes \uxxxx in json, the value in template execute will be wrong!
For example, my command is curl http://xx/x?a=b&c=d. it will becomes curl http://xx/x?a=b\u0026c=d.
When generate replaceMap , the value is
fmt.Sprintf("%v", itemVal)

https://github.com/argoproj/argo/blob/4eaae251d9147b53604481237732bff36a16a91e/pkg/apis/workflow/v1alpha1/item.go#L67
This must not only remove quote , it must be unmarshal.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can you please sign-off your commits for the DCO check?

Commits need to be signed-off.

Done.

Commits need to be signed-off.

Done.

Phew!

Phew!


We can't see who has and hasn't attested.

Portal needs a screen to view this info.

GP 478

Hi @ledgerleapllc!  Is there any info about who requested this feature, when, where, and why? Might be good to have them on record for teh future, and also for the purpose of assessing importance/priority.

Deployed. We are not billing for this one @mrkara but it needs to exist. Sometimes we eat costs on these for efficiency because we identify a problem, they are small, and no VA prompts it for fix. The why is because things remain in attestation for long periods and Tim M has not oversight into who he needs to speak to to move things.


foreach formatting doesn't obey line_length

Input:
foreach(X aa bb cc dd ee ff gg hh ii jj kk ll mm nn oo pp qq rr ss tt uu vv ww xx yy zz)
    message("${X}")
endforeach()

Config:
{
  "tabs_as_spaces": true,
  "tab_size": 2,
  "line_length": 60
}

Expected output:
foreach(X aa bb cc dd ee ff gg hh ii jj kk ll mm nn oo pp qq
          rr ss tt uu vv ww xx yy zz)
  message("${X}")
endforeach()

# or

foreach(X
    aa
    bb
    cc
    # ...
    xx
    yy
    zz)
  message("${X}")
endforeach()

# or (if refactoring is allowed)

foreach(X
    IN ITEMS
      aa
      bb
      cc
      # ...
      xx
      yy
      zz)
  message("${X}")
endforeach()

# or...

Actual output: same as input
Side note: RANGE and IN {ITEMS,LISTS,ZIP_LISTS} variants need to be considered as well.

Thank you for the input!
I would go for the approach of:
foreach(X
    aa
    bb
    cc
    # ...
    xx
    yy
    zz)
  message("${X}")
endforeach()

The reason for it is mainly that I'm still in a process of figuring out how I would like to handle line-breaking in more general way for similar cases to:
foreach(X aa bb cc dd ee ff gg hh ii jj kk ll mm nn oo pp qq
          rr ss tt uu vv ww xx yy zz)
  message("${X}")
endforeach()

Regarding the refactored case with IN ITEMS: this is a great point, but I would like to keep formatting and refactoring as 2 separate steps/subcommands as they have different concerns for me. For that reason I've opened #147 issue to track this change.


Add setup.py

Distribute the pure headers library on pypi.
This is meant for the pypi packaging of xtensor-python.
Instead of using distutils' install_headers directive which places headers under include/pythonX.Y, using wheels data_files feature to distribute headers in the same location as where it would be installed with cmake.
Problem: can we generate the xtensorConfig.cmake files without cmake?

cc @stonebig + the companion PR in xtensor-python.
One issue is that I don't know how to generate xtensorConfig.cmake without requiring cmake.

For me the major issue is that we are adding packaging stuff to the code base, while that should be independent. And we use that packaging code to "build and install" instead of relying on the provided build tools, meaning the installation process will be different from other xtensor packages.

I agree. we could have a separate repository xtensor.py. (Similarly do the same thing with Julia).
If we could built a wheel from conda-forge or a similar service, that would be great.

So, good news, kitware maintains a pip wheel for cmake! So we can have cmake as a build dependency for the xtensor wheel.

We could make a xtensor.py repo holding the setup.py and pushing a wheel to pypi on commits to master using https://docs.travis-ci.com/user/deployment/pypi/

hi again. Does Xtensor works now with "pip" + "Windows10" ? currently the html pointer shows a sort of a Null value:  https://pypi.org/project/xtensor/

The pypi package is a placeholder to prevent name squatting. At the moment we are not sure of the consistent way to package this on pypi.


Invoke-ScriptInBCContainer with usePsSession False and a Function as Value for the Scriptblock Param

Describe the issue
In Order to handle our Problems with Timeouts in Pipelines we changed the Param UsePsSession to false.
In several Parts our Powershell Library we use complete Functions for the Scriptblock Param.
With the current Version of the BcContainerhelper we cant use Invoke-ScriptInBCContainer with a Function for the Scriptblock Param.
Scripts used to cause the issue
function GetNavAppInfo {
    param (
        [string]$ServerInstance
    )
    Get-NavAppInfo -ServerInstance $ServerInstance
}
$ContainerName = 'Test'
New-BcContainer -accept_eula -containerName $ContainerName -artifactUrl (Get-BCArtifactUrl OnPrem -version 20 -country de)
$serverInstance = (Get-BCContainerServerConfiguration $ContainerName).ServerInstance
Invoke-ScriptInBCContainer -containerName $ContainerName ${function:GetNavAppInfo} -argumentList $serverInstance

Thats the Result of the Script above
BcContainerHelper version 3.0.10
Setting hostHelperFolder = C:\ProgramData\NavContainerHelper
Setting containerHelperFolder = C:\ProgramData\NavContainerHelper
Setting usePsSession = False
Setting bcartifactsCacheFolder = d:\bcartifacts.cache
Setting sandboxContainersAreMultitenantByDefault = False
BcContainerHelper emits usage statistics telemetry to Microsoft
Invoke-ScriptInBCContainer : The property 'ParamBlock' cannot be found on this object. Verify that the property exists.
At C:\Git\Testscripte\Testlocal.ps1:11 char:1
+ Invoke-ScriptInBCContainer -containerName $ContainerName ${function:G ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Invoke-ScriptInBcContainer], PropertyNotFoundException
    + FullyQualifiedErrorId : PropertyNotFoundStrict,Invoke-ScriptInBcContainer

Scripts without external Function
$ContainerName = 'Test'
New-BcContainer -accept_eula -containerName $ContainerName -artifactUrl (Get-BCArtifactUrl OnPrem -version 20 -country de)
$serverInstance = (Get-BCContainerServerConfiguration $ContainerName).ServerInstance
Invoke-ScriptInBCContainer -containerName $ContainerName {
    param (
        [string]$ServerInstance
    )
    Get-NavAppInfo -ServerInstance $ServerInstance
}  -argumentList $serverInstance

The Result of the script above is as expected and prints  the whole list of installed Apps in the BcContainer.
I also tried the script with Windows 11 but sadly get the same Result.
When i turn on the Param UsePsSession both scripts prints the whole list of installed Apps in the BcContainer.

Shipped in BcContainerHelper 3.0.11


Improve wireframe plots for targets near RA=0°

Closes #326.
Added:

New option, body.plot_wireframe_radec(use_shifted_meridian=True), to allow plotting RA/Dec wireframes with RA values between -180 and 180 (rather than the default of 0 and 360)
Improved wireframe plots when a body is located on both sides so that plotted lines shouldn't cover the whole plot (see https://github.com/ortk95/planetmapper/issues/326#issuecomment-1934275816)

Pull request checklist

[x] Add a clear description of the change
[x] Add any new tests needed
[ ] Run spell check on new text visible to user (documentation, GUI etc.)
[ ] Check any changes to requirements.txt are reflected in setup.py and conda-forge feedstock
[ ] Check code passes CI checks (run run_ci.sh or check GitHub Actions)

See CONTRIBUTING.md for more details.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

27 of 27 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 99.543%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
2855

Relevant Lines:
2867

💛  - Coveralls


Can I change port number??

I'm using PokemonGoMap-Win.exe on windows7.
I would like to oparate by change the port number.
What can i doing it ?

is this an attempt to be able to run the "mobile" connection direct from your PC instead of through the "tunnel" that's built in (and randomly locks you out because "it's had too many incoming connections")?  if so, good lord, I'd love to be able to do that....how about some documentation on that too?

This can done already as is(NOT changing the port though). If you are running the map application now, it's already running on port 8001, if you forward that port thru your router to the computer running it, and allow that app/port in your OS firewall, then you can see it directly without using the ngrok tunnel. You don't even need to 'enable' the mobile mode as all that does it fire off the ngrok binary and create the tunnel.

^ fantastic! that was exactly what I wanted...
bungasnail: there's no need to change port numbers on the app itself, do it with your router when you're forwarding the port.  For example, when you set up the forwarding, I forwarded TCP and UDP (since I don't know which it wants) from port "80" to "8001" so that all I have to do is go into a browser and type in my dynamic dns address and bam, the site pops right up...(ok, not entirely true, I picked an arbitrary port number, checked to see that nothing else uses that port number typically, and then did that, so that the URL is http://my.dynamic.dns:portnumber and it goes straight to it...now, I can pop into the server via teamviewer, launch the app, and as soon as it logs in successfully, I close out of TV, launch the browser on my phone, and load the link....nice and silky smooth...


[Suggestion] Add ESP/Glow on key

Why would it be useful?

Maybe sometimes you want to be legit. Its just easy way to have that. For example i use it :)

is not it better to add a lua script and players would do it themselves?

And if they dont know how to make lua?

Added