FA100 issue: Ruff doesnt suggest adding from __future__ import annotations

Search keywords
"TCH rules", "move under TYPE_CHECKING", "FA100"
Ruff Version
0.5.7
Config

 Part of pyproject.toml
[tool.poetry.group.dev.dependencies]
ruff = "0.5.7"

[tool.ruff]
line-length = 120
extend-exclude = ["venv", "stubs"]

[tool.ruff.lint]
select = ["ALL"]
unfixable = ["ERA001", "COM819"] # remove comment out code lines
# COM819 prohibited-trailing-comma. Это фиксить должна format команда, чтоб как в black было
# если есть запятая в конце - раскрывает на несколько строк. Если нет - оставляет в одной
ignore = [
    "Q", # flake8-quotes
    "D100",	# undocumented-public-module	Missing docstring in public module
    "D101",	# undocumented-public-class	"Missing" # docstring in public class
    "D102",	# undocumented-public-method	Missing docstring "in" # public method
    "D103",	# undocumented-public-function	Missing docstring in "public" # function
    "D104",	# undocumented-public-package	Missing docstring in public package	"🛠"
    "D105",	# undocumented-magic-method	Missing docstring in magic method
    "D106",	# # undocumented-public-nested-class	Missing docstring in public nested class
    "D107",	# # undocumented-public-init	Missing docstring in __init__
    "ANN101", # missing-type-self
    "TD003", # missing-todo-link missing issue link on the line following this TODO
    "TD002", # missing-todo-author  missing author in TODO; try: `# TODO(<author_name>): ...` or `# TODO @<author_name>: ...`Ruff
    "S101", # assert Use of assert detected
    "ANN002", #	missing-type-args	Missing type annotation for *{name}
    "ANN003", #	missing-type-kwargs	Missing type annotation for **{name}
    "RUF001", #	ambiguous-unicode-character-string	String contains ambiguous {}. Did you mean {}? Может на русскую "с" в комменте ругаться
    "RUF003", #	ambiguous-unicode-character-comment
    "SLF001", # private-member-access	Private member accessed: {access} | учитывая, что в Django постоянно дергаем _Meta моделей и поля в духе _prefetched_objects_cache и т.д.
    # "FA100", # future-rewritable-type-annotation	Missing from __future__ import annotations, but uses {name}
    # "FA102", # future-required-type-annotation	Missing from __future__ import annotations, but uses
    "DJ001", # django-nullable-model-string-field	Avoid using null=True on string-based fields such as
    "PGH004", # Use specific rule codes when using `noqa`
    "TRY003", # Avoid specifying long messages outside the exception class
    "EM102", # Exception must not use an f-string literal, assign to variable first
    "RUF002", # Docstring contains ambiguous `у` (CYRILLIC SMALL LETTER U). Did you mean `y` (LATIN SMALL LETTER Y)?
    "FBT001", # Boolean-typed positional argument in function definition
    "FBT002", # Boolean default positional argument in function definition
    "ANN204", # Missing return type annotation for special method `__init__`
]

[tool.ruff.lint.flake8-annotations]
mypy-init-return = true # ANN204 | checkers often allow you to omit the return type annotation for __init__ methods, as long as at least one argument has a type annotation

[tool.ruff.lint.isort]
force-wrap-aliases = true
combine-as-imports = true

Bug Report
My request:
I would like all imports that are used only for type hints to be placed under a TYPE_CHECKING block. If you have not yet implemented this function, please consider this issue as a feature request.
Sometimes ruff doesn't detect imports, that are used only for type-hints without from __future__ import anotations. I know, that existing of from __future__ import anotations is one of requirements for ruff to make give TCH-warnings. But sometimes FA100 rules doesnt detect cases, when import is used only for type-hints. I will make an example for django-migration:
# Generated by Django 4.0.2 on 2022-09-19 12:51

from django.db import migrations
from django.db.backends.base.schema import BaseDatabaseSchemaEditor
from django.db.migrations.state import StateApps

def migrate(apps: StateApps, _schema: BaseDatabaseSchemaEditor) -> None:
    apps.get_model("app_name", "ModelName").objects.all().delete()

class Migration(migrations.Migration):
    dependencies = []  # noqa: RUF012

    operations = [  # noqa: RUF012
        migrations.RunPython(
            code=migrate,
            reverse_code=migrations.RunPython.noop,
        ),
    ]

No ruff-warnings are shown in this code.

I think there are multiple things at play here.

Ruff doesn't emit any TCH error for the provided example even if the __future__ import annotations is present. It has to do with the migrations.RunPython call but I'm not sure why. See Playground Maybe @charliermarsh knows why?
Whether Ruff should add from __future__ import annotations I'm not so sure about. It could be a configuration option but the general idea is that these comments are explicit opt ins by the user.

If you know you want from __future__ import annotations added to all your Python files, you can use Ruff's I002 rule in combination with this setting: https://docs.astral.sh/ruff/settings/#lint_isort_required-imports

I think there are multiple things at play here.

Ruff doesn't emit any TCH error for the provided example even if the __future__ import annotations is present. It has to do with the migrations.RunPython call but I'm not sure why. See Playground Maybe @charliermarsh knows why?

I dont think, thats true:
https://github.com/user-attachments/assets/4bc6bc04-712c-41e6-8baf-a10d0927fcab
As you can see, error appears after adding from __future__ import annotations

Whether Ruff should add from __future__ import annotations I'm not so sure about. It could be a configuration option but the general idea is that these comments are explicit opt ins by the user.

Im not talking about autofixing this rule (ruff have autofix option). Im talking, that i want ruff to tell me every time when some import is used only for type hint

If you know you want from __future__ import annotations added to all your Python files, you can use Ruff's I002 rule in combination with this setting: https://docs.astral.sh/ruff/settings/#lint_isort_required-imports

I dont rly want form __future__ import annotations present in my files. But, if that is the only way to force ruff tell me, if some import is used only for type-hint, i will apply this rule. So... This way is the only one, right?

I dont think, thats true:

You're right. The problem was that the original code snipped contained a syntax error. It works as expected if I fix the syntax error playground

The same file with flake8 and flake8-type-checking emits the necessary error codes:
$ flake8 test.py
test.py:5:1: TC002 Move third-party import 'django.db.backends.base.schema.BaseDatabaseSchemaEditor' into a type-checking block
test.py:6:1: TC002 Move third-party import 'django.db.migrations.state.StateApps' into a type-checking block

$ ruff check --select TCH test.py
All checks passed!

flake8-type-checking doesn't care whether you have imported future annotations yet. If you fix the imports by moving them into T.TYPE_CHECKING, it will still emit an error telling you how to fix your use of annotations that are evaluated at runtime and aren't available, via the "how to handle forward references" (there's an option to have it always advise you to use quoted strings instead):
TC100 Add 'from __future__ import annotations' import

It might be nice for flake8-type-checking to warn you about both at the same time. I just recently opened https://github.com/snok/flake8-type-checking/issues/190 which is related to this but not exactly the same thing.
In the same situation, by the way, ruff reports:
test.py:8:44: TCH004 Move import `django.db.migrations.state.StateApps` out of type-checking block. Import is used for more than type hinting.
test.py:9:48: TCH004 Move import `django.db.backends.base.schema.BaseDatabaseSchemaEditor` out of type-checking block. Import is used for more than type hinting.
Found 2 errors.

It's not used for more than type hinting, but whatever. ;)

By the way my reading of FA100 is that it is specifically applicable to cases where an annotation could be rewritten in a manner that ordinarily requires a new version of CPython, but where __future__.annotations would allow "backporting" support to an earlier version of python, i.e. PEP 585 / 604.
It is not about unlocking additional ways to discover TCH001-TCH003 "move import into a type-checking block" issues.

It is not about unlocking additional ways to discover TCH001-TCH003 "move import into a type-checking block" issues.

So, can we treat this issue as feature request or should i create another one?

BTW, ruff has a feature that automatically moves imports under the TYPE_CHECKING block, but this can cause issues with tools like drf-spectacular, which rely on type hints for certain classes (e.g., Serializers). When Ruff moves these type hints to the TYPE_CHECKING block, it causes Swagger to crash.

Please take a look at:

https://docs.astral.sh/ruff/settings/#lint_flake8-type-checking_runtime-evaluated-base-classes
https://docs.astral.sh/ruff/settings/#lint_flake8-type-checking_runtime-evaluated-decorators


[cdk/drag-drop cdkDragStartDelay demo] Disable user-select on the draggable box.

On iOS 13, press-and-holding for one second on the dragging box causes text to start being selected which can break/severely interrupt the dragging routine. Therefore, user-select should be set to none to disable the text selecting.
Demo of errant behavior: https://i.imgur.com/xq6fwM4.mp4
(this demo was posted in the following issue and also displays another bug with the drag-drop library on iOS 13 that still needs to be addressed: https://github.com/angular/components/issues/17923#issuecomment-588258600)
https://caniuse.com/#feat=user-select-none

@googlebot I signed it!

I don't think is something we should be fixing in the demo, but rather in the drag&drop module. We already have something that disables user selection, but maybe it's not firing at the right time.

@crisbeto Do we have an issue to track this so we can close this PR out for a fix in the module?


Supports providers using legacy API

Some injection providers, such as Opera wallet and Coinbase wallet, continue to use deprecated API: https://docs.metamask.io/guide/ethereum-provider.html#ethereum-enable-deprecated
I have added a fallback to support them.

Thanks @aggre 🙌 this is really useful. Currently we are refactoring this codebase to split it into multiple packages and once that's complete I will include this fix with the v2.0.0

Thank you for checking! I can fix anytime this if there is a problem :)

This PR is too big unfortunately... sorry for leaving it stale for so long but we will need to handle this differently


ng build generating vendor source maps even if set to false

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
I don't know, first detected in ng-cli's version 11.0.7
Description
In angular.json I added a configuration like follows:
"configurations": {
    "dev": {
        "optimization": true,
        "outputHashing": "all",
        "sourceMap": {
            "scripts": true,
            "styles": true,
            "hidden": false,
            "vendor": false
        },
        "namedChunks": true,
        "extractLicenses": false,
        "vendorChunk": true,
        "buildOptimizer": true
    },
    "production": {
      ...

Then I build with ng build --configuration=dev and, taking a look at the dist folder, I see the vendor.*.js files are getting source maps generated:
~/my-project/ $ ll dist/vendor*
-rw-r--r-- 1 dwilches 1.3M Jan 26 15:52 dist/vendor-es2015.d5ada0d379d2aba7da41.js
-rw-r--r-- 1 dwilches 7.5M Jan 26 15:52 dist/vendor-es2015.d5ada0d379d2aba7da41.js.map
-rw-r--r-- 1 dwilches 1.4M Jan 26 15:52 dist/vendor-es5.d5ada0d379d2aba7da41.js
-rw-r--r-- 1 dwilches 7.6M Jan 26 15:52 dist/vendor-es5.d5ada0d379d2aba7da41.js.map

But notice in my source map config I set "vendor": false.
🔬 Minimal Reproduction

ng new hello: accept all defaults
Add this configuration to angular.json:

"dev": {
    "optimization": true,
    "outputHashing": "all",
    "sourceMap": {
        "scripts": true,
        "styles": true,
        "hidden": false,
        "vendor": false
    },
    "namedChunks": true,
    "extractLicenses": false,
    "vendorChunk": true,
    "buildOptimizer": true
},

ng build --configuration=dev
ls -l dist/hello/vendor*

🔥 Exception or Error
There will be a source map for vendor inside of dist/hello.

Hi @dwilches,
Thanks for opening this request, however this is the working as intended.
When vendor sourcemaps is disabled, the vendor sourcemap file is still generated. Although this doesn't the contains of the resolved 3rd party libraries.
There are two main reasons for this:

//# sourceMappingURL comments will not be removed from the source file of the libraries and a warning will be issued in the console because the sourcemap cannot be loaded. (#19236)
Having the vendor sourcemap file still improves debugging experience, even when the sourcemaps are not fully resolved.

vendor.js.map generated with vendor: false

vendor.js.map not generated

Hi @dwilches,
Thanks for opening this request, however this is the working as intended.
When vendor sourcemaps is disabled, the vendor sourcemap file is still generated. Although this doesn't the contains of the resolved 3rd party libraries.
There are two main reasons for this:

//# sourceMappingURL comments will not be removed from the source file of the libraries and a warning will be issued in the console because the sourcemap cannot be loaded. (#19236)
Having the vendor sourcemap file still improves debugging experience, even when the sourcemaps are not fully resolved.

vendor.js.map generated with vendor: false

vendor.js.map not generated

@alan-agius4  In my case I have 29MB of vendor.js.map and source map generation takes 22min (because of the usage of fat corporate libraries). Without sourceMap the build takes 4min.
I also expected vendor.js to be disabled with any option.
But for now, as I understand the only way to make build faster is to disable sourceMap completely.

@alan-agius4  In my case I have 29MB of vendor.js.map and source map generation takes 22min (because of the usage of fat corporate libraries). Without sourceMap the build takes 4min.
I also expected vendor.js to be disabled with any option.
But for now, as I understand the only way to make build faster is to disable sourceMap completely.

Or maybe I am wrong and the fact of fat vendor.js.map that includes all 3rd-party libs is a problem (checked it via source-map-explorer). Do you know why all libs are included?

Or maybe I am wrong and the fact of fat vendor.js.map that includes all 3rd-party libs is a problem (checked it via source-map-explorer). Do you know why all libs are included?

Possibly one of the reasons why the generation is slow is due to optimization and buildOptimizer being used in combination with sourceMaps.
The mentioned 2 options are not meant to be during development.
if you can provide a reproduction I’ll happily take a look.

Possibly one of the reasons why the generation is slow is due to optimization and buildOptimizer being used in combination with sourceMaps.
The mentioned 2 options are not meant to be during development.
if you can provide a reproduction I’ll happily take a look.

@alan-agius4 Thank you in advance. I've prepared an example with monaco-editor: https://github.com/gorshkov-leonid/test-source-map . There buildOptimizer is disabled but optimization is enabled to have source maps on the preproduction server.
Don't pay attention to code where web workers for monaco-editor are bundled. Just call npm install && npm run build. And look into build/dist/test-source-map/vendor.js.map

@alan-agius4 Thank you in advance. I've prepared an example with monaco-editor: https://github.com/gorshkov-leonid/test-source-map . There buildOptimizer is disabled but optimization is enabled to have source maps on the preproduction server.
Don't pay attention to code where web workers for monaco-editor are bundled. Just call npm install && npm run build. And look into build/dist/test-source-map/vendor.js.map

Thanks for the reproduction.
The monaco-editor source is huge, this causes the sourcemap to grow quite a lot because the source content is included in vendor sourcemap.
This is working as expected and as documented in here https://angular.io/guide/workspace-config#source-map-configuration because when vendor is set to false vendor source-maps are not resolved to actually source-map as this process is considerably slow.
It is also important to point out that vendorChunk is only meant to be used for development purposes and shouldn't be used when using the optimization option. Using vendor chunking can cause several optimization bailouts.
At the point I see two options here;

Extend the CLI using 3rd party builds such as https://github.com/manfredsteyer/ngx-build-plus and https://www.npmjs.com/package/@angular-builders/custom-webpack
Provide a way to truly disable vendor sourcemaps, this would however has some cavets, such as the issue with stacktraces explained above.

I think for the time being, option 1 is the best way option to achieve this. We can re-evaluate option 2, if we see more community members requiring this.

Thanks for the reproduction.
The monaco-editor source is huge, this causes the sourcemap to grow quite a lot because the source content is included in vendor sourcemap.
This is working as expected and as documented in here https://angular.io/guide/workspace-config#source-map-configuration because when vendor is set to false vendor source-maps are not resolved to actually source-map as this process is considerably slow.
It is also important to point out that vendorChunk is only meant to be used for development purposes and shouldn't be used when using the optimization option. Using vendor chunking can cause several optimization bailouts.
At the point I see two options here;

Extend the CLI using 3rd party builds such as https://github.com/manfredsteyer/ngx-build-plus and https://www.npmjs.com/package/@angular-builders/custom-webpack
Provide a way to truly disable vendor sourcemaps, this would however has some cavets, such as the issue with stacktraces explained above.

I think for the time being, option 1 is the best way option to achieve this. We can re-evaluate option 2, if we see more community members requiring this.


small moth changes

moths can eat prisoner jumpsuits, berets and head hats. ghost burger is edible since it uses cloth
can no longer eat magboots, face items (like gas masks), or anything with items stored in it
they can now squeak

Changelog

:cl: Lank

tweak: What Moths consider to be made of cloth should now be more accurate.
tweak: Moths are now able to squeak.

Why specifically can't they eat winter coats?

I'm not sure if they were also changed, but if storage is the no-go for edible items, make sure web vests, jensen/gentle coats, bomber jacket and so on aren't edible.

combat boots applies for knife
this should probably just be a check on food when eating it so anything that has items cant be eaten

I'm not sure if they were also changed, but if storage is the no-go for edible items, make sure web vests, jensen/gentle coats, bomber jacket and so on aren't edible.

outerwear was already restricted to winter coats so this is fine

combat boots applies for knife
this should probably just be a check on food when eating it so anything that has items cant be eaten

Not sure how easy that would be to implement nor do I really think it's worth it, but either way I think the combat boots are fine since it can only eat knives which is far less abusable

shouldn't be trying to catch this on a case-by-case basis, either eating stuff with containers should be disallowed or the container contents should be dropped

shouldn't be trying to catch this on a case-by-case basis, either eating stuff with containers should be disallowed or the container contents should be dropped

I can work on that later, but at the moment it’s probably good to stop people from deleting items still

check medibot construction emptying i think that would apply here

shouldn't be trying to catch this on a case-by-case basis, either eating stuff with containers should be disallowed or the container contents should be dropped

eating containers is now disallowed

they can now eat winter coats again, just not if anything is stored in them

Why specifically can't they eat winter coats?

they have storage, which allows you to eat any item that can be put in them (like hypos, door remotes, nuke disk, etc.)

You can allow them to eat winter coats. Just when the coat is deleted, force the items to drop.

You can allow them to eat winter coats. Just when the coat is deleted, force the items to drop.

I just changed it to disallow them from eating coats that have anything stored inside. I think that works just as well.

You can allow them to eat winter coats. Just when the coat is deleted, force the items to drop.

I just changed it to disallow them from eating coats that have anything stored inside. I think that works just as well.

Are players going to realize why they could not eat the coat? This is not intuitive. Dropping the item seems like a better solution

its fine it says that it cant be eat because an item is stored inside


Unable to close tabs

Clicking the close button (small cross) on a tab on http://yasgui.org/ does not close that tab.
Behavior occurs on Firefox and Chrome.

This is probably a caching issue, try a hard refresh. This was already reported/fixed in #101 ;)


cast from Nil to Crystal::GenericInstanceType+ failed

While trying to convert a Ruby code sample into a Crystal sample I came across what could be a bug (because the compiler told me it was a bug).
The following code sample is the problem causer, and the issue is the lack of a type declaration in the Array's in the validate_pixel method. When type declarations are included it compiles.
class RGBColor
  getter :red, :green, :blue

  def initialize(@red : Int32, @green : Int32, @blue : Int32)
    unless (0 <= @red <= 255) && (0 <= @green <= 255) && (0 <= @blue <= 255)
      raise ArgumentError.new("invalid RGB parameters: #{[@red, @green, @blue].inspect}")
    end
  end

  RED   = RGBColor.new(255,0,0)
  GREEN = RGBColor.new(0,255,0)
  BLUE  = RGBColor.new(0,0,255)
  BLACK = RGBColor.new(0,0,0)
  WHITE = RGBColor.new(255,255,255)
end

class Pixmap
  getter :width, :height

  def initialize(@width : Int32, @height : Int32)
    @data = fill(RGBColor::WHITE)
  end

  def fill(color : RGBColor)
    @data = Array.new(@width) {Array.new(@height, color)}
  end

  def validate_pixel(x, y)
    unless (0 <= x <= @width-1) && (0 <= y <= @height-1)
      raise ArgumentError.new("requested pixel (#{x}, #{y}) is outside dimensions of this bitmap")
    end
  end

  def [](x, y)
    validate_pixel(x,y)
    @data[x][y]
  end

  def []=(x, y, color)
    validate_pixel(x, y)
    @data[x][y] = color
  end
end

Here is a running (well not really running) example https://carc.in/#/r/2kfz

Reduced:
class Gen(T)
  def self.new(&block)
    Gen(T).new
  end
end

class Foo
  def foo
    @x = Gen.new { }
  end
end

Workaround:
class Pixmap
  @data : Array(Array(RGBColor))
end

I just hit this same compiler error and narrowed it down to the following:
class Foo
  property bar = Array.new(2) { Array(DoesntMatter).new(2) }
end

which gives
cast from Nil to Crystal::GenericInstanceType+ failed, at /private/tmp/crystal-lang-20170713-99958-vd502v/crystal-0.23.1/src/compiler/crystal/types.cr:1420:20:1420
0x1017517e8: *raise<TypeCastError>:NoReturn at ??
0x101e14864: *Crystal::TypeParameter#solve<Crystal::NonGenericClassType>:Crystal::ASTNode+ at ??
0x101e15520: *Crystal::GenericInstanceType+@Crystal::GenericInstanceType#replace_type_parameters<Crystal::NonGenericClassType>:Crystal::Type+ at ??
0x101e1259a: *Crystal::TypeDeclarationProcessor#process_owner_guessed_instance_var_declaration<Crystal::Type+, String, Crystal::TypeDeclarationProcessor::InstanceVarTypeInfo>:(Crystal::MetaTypeVar | Crystal::TypeDeclarationProcessor::Error | Nil) at ??
0x101e0c233: *Crystal::TypeDeclarationProcessor#process_instance_vars_declarations:Nil at ??
0x101d5e97b: *Crystal::Program#top_level_semantic<Crystal::ASTNode+>:Tuple(Crystal::ASTNode+, Crystal::TypeDeclarationProcessor) at ??
0x101d58999: *Crystal::Program#semantic<Crystal::ASTNode+, Bool>:Crystal::ASTNode+ at ??
0x1021d7145: *Crystal::Compiler#compile<Array(Crystal::Compiler::Source), String>:Crystal::Compiler::Result at ??
0x1022468ce: *Crystal::Command#run_command<Bool>:Nil at ??
0x10179608c: *Crystal::Command#run:(Bool | Crystal::Compiler::Result | IO::FileDescriptor | Nil) at ??
0x101766b86: main at ??

Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

Searching led me to this issue, but I'm not sure if it's actually the same as any of the 3 open issues with the same error.

So @data is an ivar whose type is not explicitly annotated neither can be inferred from constructors bodies, right? The fix for this should be for the compiler to report that instead gracefully instead of blowing up then.

Duplicate of #4460
@mverzilli Yes, it's a problem with the type guesser and generic types. I think it deduces that the type is Array(T) but T is not bound. I tried to fix it once but it's not clear for me how to do it because of the current code layout.


Image Layer Corruption

Describe the bug
When using a WebView on Image layer can sometimes rotate and skew on render.
To Reproduce
Steps to reproduce the behavior:

Open WebView with OpenLayers app.
Image Layer incorrectly rotated, skewed, and clipped.

Expected behavior
Static Image displays as provided.
--
I have been able to reproduce this most easily using a base 64 image uri or a object url. It seems like some kind of race condition, potentially with the projection?
If anyone even has pointers into how to debug this that would be amazing - there are no errors handled or otherwise.

So far I can track it down to ImageStatic.handleImageChange, specifically when the image height or width has changed (link). I am still looking into this issue.
As an additional note, target height and width result in rounding issues which can trigger needless updates.

That is required if the image aspect ratio is different to the extent aspect ratio and is only done when the image loads.  There should be no reason for image state to change after loading.

That is required if the image aspect ratio is different to the extent aspect ratio and is only done when the image loads. There should be no reason for image state to change after loading.

Looking into the rounding issues - I found my issue related to difference in calculations for preserving aspect ratio, i.e. PIL's thumbnail method rounds down, instead of using center point rounding.

Although the above does not remove the underlying issue, the canvas is somehow corrupted when the image size changes.
Attached below are screenshots of what is rendered and the source image. The projection and extent are 1994 x 1094, and the background colour of the map element is yellow, with the static image being a solid red rectangle 1000 x 549.
Rendered - Projection 1994 x 1094

Sample Code
const url =
  "https://github.com/openlayers/openlayers/assets/8308646/66c7e384-814c-4baf-8704-910ad5fc4296";
const extent = [0, 0, 1994, 1094];

const projection = new Projection({
  code: "sample-image",
  units: "pixels",
  extent: extent,
});
const map = new Map({
  layers: [
    new ImageLayer({
      source: new Static({
        url,
        projection: projection,
        imageExtent: extent,
      }),
    }),
  ],
  target: "map",
  view: new View({
    projection: projection,
    center: getCenter(extent),
    zoom: 2,
    maxZoom: 8,
  }),
});

Source Image
Source Image (for ImageStatic) - 1000 x 549


Update refined, refined-cats, ... to 0.9.6

Updates

eu.timepit:refined
eu.timepit:refined-cats
eu.timepit:refined-scalacheck

from 0.9.5 to 0.9.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "eu.timepit" }]

labels: semver-patch

Codecov Report

Merging #1117 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
+ Coverage   80.51%   80.61%   +0.09%
==========================================
  Files          54       54
  Lines        1016     1016
  Branches       46       46
==========================================
+ Hits          818      819       +1
+ Misses        198      197       -1

Impacted Files
Coverage Δ

core/src/main/scala/io/finch/Endpoint.scala
73.14% <0%> (+0.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470e8d3...e196479. Read the comment docs.


Day340

Resolves #679.

Pull Request Test Coverage Report for Build 1252

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1258:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls

Pull Request Test Coverage Report for Build 1260

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1258:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


Changed YT label from "last updated" to "last checked" (part 2)

Oops, missed out one file in the previous PR.

https://github.com/lbryio/lbry-desktop/pull/4523#issuecomment-659097018 @seanyesmunt: I commented the badge out on the file page because it was the floating viewer wasn't pushed down properly on mobile. I would like to avoid using two lines for the lbry URL and the youtube badge. Maybe we could add an ellipsis on the lbry URL so they don't wrap to two lines? That would help on channel pages too

Fix floating-player misalignment due to YT badge in mobile by hiding the badge.
At first, the suggestion to truncate the left URI to keep the entire thing single-lined was implemented, but during testing, I realized that the YT badge will take up the entire width anyway (especially on other languages). The URI is more important than the badge, and truncating both of them would be ugly.
Given the preference to not have 2 lines for this, we'll just hide the badge for the mobile case.
For the Channel Page case, let's make it single-line through #4454 URL / top claims overlap instead. We'll keep this commit/PR limited to fixing the YT badge.


update-report: summarize updated casks for --preinstall

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

This mirrors what's currently done for formulae. No obvious speed advantage; more because the list of updated casks tends to be rather long in comparison. Also, show less output if --quiet is passed.

Review period will end on 2020-12-16 at 00:55:18 UTC.

Review period ended.

Thanks @EricFromCanada!


[FormRecognizer] revert dependency downgrade

Now that preview.1 is out.

Closing as dependency version were all updated as part of core-tracing PR #7998


Factor out common test setup in DefundChannel tests

Sharing common test setup makes it easier to reason about how tests differ from each other. This PR is a refactor.

I began to review this PR, but the first commit is dd75f9e7f075154fe325c1397b9c9af013dcb15d

refactor: factor out defunding logic from protocols

This does not line up with the PR's title or description. Am I reviewing the right changeset?

This does not line up with the PR's title or description. Am I reviewing the right changeset?

The base defunder branch was force-pushed, creating a very large changeset. Closing this PR and opening https://github.com/statechannels/statechannels/pull/3267 instead.


Problem with hie-wrapper in windows related with location of cabal-helper-wrapper

Hi,

when running hie-wrapper in a cabal based project, i've got this output:

PS D:\dev\ws\haskell\cabal-test> hie-wrapper -d
2019-04-08 06:30:47.6085931 [ThreadId 3] - run entered for hie-wrapper(hie-wrapper.exe) Version <IP_ADDRESS> (2497 commits) x86_64 ghc-8.6.4
2019-04-08 06:30:47.6325875 [ThreadId 3] - Current directory:D:\dev\ws\haskell\cabal-test
hie-wrapper.exe: Could not find $libexecdir/cabal-helper-wrapper

If you are a cabal-helper developer you can set the environment variable
`cabal_helper_libexecdir' to override $libexecdir[1]. The following will
work in the cabal-helper source tree:

    $ export cabal_helper_libexecdir=$PWD/dist/build/cabal-helper-wrapper

[1]: D:\dev\ws\haskell\haskell-ide-engine\.stack-work\install\f33caf5a\libexec\x86_64-windows-ghc-8.6.4\cabal-helper-<IP_ADDRESS>
D:\dev\ws\haskell\haskell-ide-engine\.stack-work\install\f33caf5a\libexec\x86_64-windows-ghc-8.6.4\cabal-helper-<IP_ADDRESS>\cabal-helper-wrapper.exe
junk\build\cabal-helper-wrapper\cabal-helper-wrapper
D:\dev\ws\haskell\haskell-ide-engine\.stack-work\install\f33caf5a\bin\cabal-helper-wrapper

If you don't know what I'm talking about something went wrong with your
installation. Please report this problem here:

    https://github.com/DanielG/cabal-helper/issues

When running it in a stack based project i've got:

2019-04-08 06:32:16.4865135 [ThreadId 3] - run entered for hie-wrapper(hie-wrapper.exe) Version <IP_ADDRESS> (2497 commits) x86_64 ghc-8.6.4
2019-04-08 06:32:16.5065097 [ThreadId 3] - Current directory:D:\dev\ws\haskell\stack-test
2019-04-08 06:32:20.9344611 [ThreadId 3] - Cradle directory:D:\dev\ws\haskell\stack-test
2019-04-08 06:32:20.9544579 [ThreadId 3] - Using stack GHC version
2019-04-08 06:32:21.7829755 [ThreadId 3] - Project GHC version:8.4.4
2019-04-08 06:32:21.7909774 [ThreadId 3] - hie exe candidates :["hie-8.4.4.exe","hie-8.4.exe","hie.exe"]
2019-04-08 06:32:21.8189699 [ThreadId 3] - found hie exe at:D:\bin\hie.exe
2019-04-08 06:32:21.8269592 [ThreadId 3] - args:["-d"]
2019-04-08 06:32:21.8349577 [ThreadId 3] - launching ....

haskell-lsp:Starting up server ...

When i open the stack project in vscode the lsp server seems to be completely irresponsive (so maybe it is related with #1133?)
The path to my cabal-helper-wrapper executable is D:\dev\ws\haskell\haskell-ide-engine\.stack-work\install\f33caf5a\bin instead D:\dev\ws\haskell\haskell-ide-engine\.stack-work\install\f33caf5a\libexec\x86_64-windows-ghc-8.6.4\cabal-helper-<IP_ADDRESS> (in fact libexec doesnt exist) or D:\dev\ws\haskell\haskell-ide-engine\.stack-work\install\f33caf5a\bin\cabal-helper-wrapper (the executable itself is there but there is not a "dir" with that name :thinking: )
When i set the cabal_helper_libexecdir env var to the correct path (D:\dev\ws\haskell\haskell-ide-engine\.stack-work\install\f33caf5a\bin) as suggested the hie-wrapper error in cabal project is not there and both projects (cabal and stack) can be opened in vscode normally.
Tested in windows 10 and windows 7

Well, it seems the code is testing the file existence in the bin dir without the exe extension: https://github.com/alanz/cabal-helper/blob/8fecf6a7754424ed1653dce632382707e8f03499/lib/Distribution/Helper.hs#L519-L520
I think i could make a pr a test in my windows system

pr tested in windows 7: https://github.com/alanz/cabal-helper/pull/5

Maybe we could close this one cause the fix is merged: 01807e6


account labels style needs improvement

current labels:

suggested style by ajsharkk:

approximate colors are:
background: #F1F1F1;
color: #515151;

border-radius could be around 6px

note: extra vertical spacing between account label and address is good, but should also be added between nano/fiat balances


Manual mode changes do not work

Describe the bug
In a barebones SvelteKit project with Shadcn-svelte, the mode-watcher toggle does not work.
Project configured using shadcn-svelte@next.

The <ModeWatcher /> works as expected. (Tested using devtools Rendering tab)
Using toggleMode sets style="color-scheme: dark;", but does not set class="dark"
Using setMode does not set anything.

Reproduction
Steps to recreate on stackblitz:

Create a barebones SvelteKit project or use pnpm dlx sv create new-app (Enable typescript and tailwindcss)
Initialize shadcn-svelte using pnpm dlx shadcn-svelte@next init
Add mode-watcher using pnpm i mode-watcher
Replace +layout.svelte with:

<script lang="ts">
	import { ModeWatcher, toggleMode } from 'mode-watcher';
	import '../app.css';
	let { children } = $props();
</script>

<!-- <ModeWatcher /> --> <!-- This works -->
<button onclick={toggleMode}>Toggle Mode</button> <!-- This does not work -->
{@render children()}

Stackblitz
Logs
No response
System Info
System:
    OS: Linux 6.11 Fedora Linux 41 (KDE Plasma)
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 22.28 GB / 31.09 GB
    Container: Yes
    Shell: 5.2.32 - /bin/bash
  Binaries:
    Node: 20.17.0 - ~/.local/share/mise/installs/node/lts/bin/node
    npm: 10.8.2 - ~/.local/share/mise/installs/node/lts/bin/npm
    pnpm: 9.14.2 - ~/.local/share/mise/installs/node/lts/bin/pnpm
    bun: 1.1.29 - ~/.local/share/mise/installs/bun/latest/bin/bun
  Browsers:
    Chrome: 131.0.6778.85
  npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.8.4
    mode-watcher: ^0.5.0 => 0.5.0
    svelte: ^5.0.0 => 5.2.8

Severity
blocking all usage of mode-watcher

wait - what do you mean?
you need to include the <ModeWatcher /> component somewhere in your app, for example in the layout is included in the instructions:

Add the ModeWatcher component to your root +layout.svelte file.

<script lang="ts">
	import { ModeWatcher } from "mode-watcher";
</script>

<ModeWatcher />

have you done that?

I'm confused when you write:

Replace +layout.svelte with:

<script lang="ts">
	import { ModeWatcher, toggleMode } from 'mode-watcher';
	import '../app.css';
	let { children } = $props();
</script>

<!-- <ModeWatcher /> --> <!-- This works -->
<button onclick={toggleMode}>Toggle Mode</button> <!-- This does not work -->
{@render children()}

because ModeWatcher is commented out, then it makes sense that it does not work.
but are you saying that:
<script lang="ts">
	import { ModeWatcher, toggleMode } from 'mode-watcher';
	import '../app.css';
	let { children } = $props();
</script>

<ModeWatcher />
<button onclick={toggleMode}>Toggle Mode</button>
{@render children()}

also does not work?
please clarify :)


sourceMountPath or subPath(Expr) for volumes

Hi,
I have an issue to integrate moosefs-csi in StatefulSet. I need a way to determine the source path to mount. I already know I can make a subPath under volumeMounts such as:
kind: Pod
apiVersion: v1
metadata:
  name: my-csi-app
spec:
  containers:
    - name: my-frontend
      image: busybox
      volumeMounts:
      - mountPath: "/data"
        name: moosefs-volume
        subPath: subdir  # <--------- here
      command: [ "sleep", "1000000" ]
  volumes:
    - name: moosefs-volume
      persistentVolumeClaim:
        claimName: moosefs-csi-pvc

but I need to do this under Volume:
kind: Pod
apiVersion: v1
metadata:
  name: my-csi-app
spec:
  containers:
    - name: my-frontend
      image: busybox
      volumeMounts:
      - mountPath: "/data"
        name: moosefs-volume
      command: [ "sleep", "1000000" ]
  volumes:
    - name: moosefs-volume
      persistentVolumeClaim:
        claimName: moosefs-csi-pvc
      subPath: subdir # <--------- here

Even if it looks the same, it is fundamentally different. I need to be able to choose which directory in the source I want to mount, with the ability to add a POD_NAME in case of StatefulSet.
My use case is OpenLdap, that has a data persistence in /var/lib/openldap. I cannot mount /var/lib/openldap/$(POD_NAME) or I would need to modify the OpenLdap configuration to refer to a dynamic path.
Eg of what I want for my usecase:
kind: Pod
apiVersion: v1
metadata:
  name: my-csi-app
spec:
  containers:
    - name: my-frontend
      image: busybox
      volumeMounts:
      - mountPath: "/data"
        name: moosefs-volume
      command: [ "sleep", "1000000" ]
      env:
        - name: POD_NAME # <--------- here
          valueFrom:
            fieldRef:
              fieldPath: metadata.name
  volumes:
    - name: moosefs-volume
      persistentVolumeClaim:
        claimName: moosefs-csi-pvc
      subPathExpr: $(POD_NAME) # <--------- here

Not sure if this is a MooseFs plugin issue or Kubernetes issue. I created an issue in Kubernetes side: https://github.com/kubernetes/kubernetes/issues/89091 . But I still believe this is a MooseFs plugin issue. The sourcePath in the code is set to the endpoint of mfsmaster, but it could be configurable.

The way to accomplish this is somewhat of a hack.  First, manually create the directory in your moosefs cluster (this plugin doesn't create directories, yet).
Then, define the volume pointing at that directory (reference the volume in the pvc definition):
---
apiVersion: v1
kind: PersistentVolume
metadata:
  name: moosefs-pv
spec:
  accessModes:
  - ReadWriteOnce
  persistentVolumeReclaimPolicy: Retain
  storageClassName: moosefs-block-storage
  volumeMode: Filesystem
  capacity:
    storage: 5Gi
  storageClassName: moosefs-block-storage
  csi:
    driver: com.tuxera.csi.moosefs
    fsType: ext4
    volumeHandle: moosefs-pv
    volumeAttributes:
      endpoint: '<master endpoint>:/<directory path>'
...

This will mount the directory from within the moosefs cluster as the root of the volume in kubernetes.
Now you can point the claim at the volume you created:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: moosefs-csi-pvc
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 5Gi
  storageClassName: moosefs-block-storage
  volumeMode: Filesystem
  volumeName: moosefs-pv

It's enough to get you started.  I'm working on a patch to add the directory path as an entry on VolumeAttributes, similar to how the csi plugin for nfs storage allows setting of the share to mount.

Hi, is this going to be added soon?
Also, I can see "ext4", should we write the filesystem containing MooseFs chunks or do we always need to write that? Thank you.

@antoinetran Sorry to have disappeared.  Didn't expect for the world to catch on fire all at once.  :sob:
I spent a lot of time trying to refactor and update, but the aws driver gave me problems the entire way.
Ended up creating an on-prem, focused driver, so I can iterate on it more cleanly and so I don't need to spend time studying up on the goals of the aws target here.  github.com/Kunde21/moosefs-csi


Hide nodemon logs

I wish there is a way to hide all the logs that come with nodemon.
Check this as a reference for nodemon options.
But, you already have an option called --quiet. So do you think there is a way to pass an option that makes nodemon silent (or replace nodemon logs with new ones instead)
I could help if you're planning to implement this.
[Update]: one of the reasons why I'm asking if there's a solution for this is that I'm already using nodemon in my environment and the command line is throwing a lot of unnecessary logs which making the console very complex.

as variant, you can run this command npm-watch | grep --invert-match nodemon

does --silent do what you need?
For reference => https://github.com/M-Zuber/npm-watch#silent

does --silent do what you need?
For reference => https://github.com/M-Zuber/npm-watch#silent

No it doesn't.. I'm on Windows by the way

My apologies, I answered without refreshing my mind
Currently we don't offer the ability to pass flags from the command line, you need to instead set the config in the package.json,
for example:
"watch": {
    "echo": {
        "path": "index.js",
        "silent": true
    }
}

Please let me know if this fixes your issue


Write a cmd line tool to send job build request as github would.

This command line tool is very important to help developers on board. It will basically allow developers to easily test the octopusci locally as if they had pushed some code to github and github had made a post back to their octopusci. The primary benefit to this though is that it would make it so our developers wouldn't have to setup a test github repo, hook up the post commit hook, and setup port forwarding to their development box from the outside world.

This task has been completed by the above listed commits.


Resolve merge conflicts from #1182

This resolves the merge conflicts introduced to https://github.com/studentinsights/studentinsights/pull/1098 by https://github.com/studentinsights/studentinsights/pull/1182.

@edavidsonsawyer This has one additional commit on top which you might want to check out (https://github.com/edavidsonsawyer/studentinsights/pull/1/commits/d1d92a3a9d0c08ec61359cbf066c770e2bb68bb8), which moves the "routing" bit of code that was in main.jsx into the new ui/route.js file.  This also touches up some imports, and removes the HighchartsWrappercopy and imports from the existing one.
I think this resolves the conflicts and restores everything to a good working state, here's what it looks like locally:

@kevinrobinson this looks good, except I don't think I can use the existing highcharts wrapper as is. I had to add some code to the wrapper in order to get the charts to redraw when the date range changes. Is it cool if I add the componentWillReceiveProps bit to the existing wrapper? I don't think it should affect the student profile, but I'll play around with it to be sure.

@edavidsonsawyer ah yeah sorry I missed that, yeah adding that in is a great improvement!


[Combobox] Storybook is blowing up when you type into input

Describe the bug
Combobox story is crashing when you try to interact with the component
To Reproduce
Steps to reproduce the behavior:

Go to https://carbon-addons-iot-react.com/?path=/story/watson-iot-experimental-combobox--default
Try to interact with component
See error

:tada: This issue has been resolved in version 2.101.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


FIX: add seeg to pick_types

Solves some bugs related to seeg data. Also see https://github.com/mne-tools/mne-python/issues/2548#issuecomment-149875453

LGTM
however we should have a way to test this.

EpochsArray + arbitrarry data

sounds like a plan

shall I add separate tests with EpochsArray, or just add some seeg to an meeg data?

just change as little code as possible to have this tested.

is this error due to me?

I don't think so. I restarted the builds. We'll have to keep an eye on other PRs, maybe Anaconda pushed an update that broke something.


rewrite contents_helper for compatibility with CMS

Description
This pull request fixes a minor bug highlighted when preparing for the help centre demo for the Content Management System.
The issue was discovered when attempting to move a help centre subcategory into a different category using the Help Centre Structure JSON in Contentful. The table of contents in the help centre would be correctly updated, however clicking through to the subcategory page would result in a 404 error.
This was due to an issue with the guidances method; within this method the category_labels method was always being called with the local help_centre.json file path rather than using the help centre structure from the CMS.
The category_labels method was also restructured to expect a dictionary type rather than a file path to the dictionary, since the content dictionary from the CMS is not stored in a file (i.e. the content is stored in a variable as a result of the CMS API call)
Code has not been commented and documentation has not been provided since it is not necessary for this pull request.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Technical Enhancements

Checklist:
If any of these are not completed, please explain why in the notes.
Definition of Done
Code and merges

[ ] Code to be commented on where applicable
[x] Documentation updated where required
[x] Have considered non-functional requirements such as Security, Performance, Scalability, and Fault Tolerance
[ ] I have linted the code

Testing

[ ] All levels of acceptance test are passing (automated, integration, manual, accessibility, etc.)
[ ] I have run the behave command to check the selenium behaviour tests pass locally
[x] Acceptance criteria met

Other Checks

[x] I have performed a self-review of my own code
[x] I have checked for spelling errors
[ ] I have commented on my code, particularly in hard-to-understand areas
[x] My changes don't break anything unexpected
[x] I have checked and updated the security.txt file where required
[x] Up to date with the main branch
[ ] For a change that needs to be deployed in a release I have a commit with the fix:, feat: or BREAKING CHANGE:
tags and will copy this commit message to the squash
[ ] For a change that does not affect the deployed code I have added a commit with ci:, docs: or test:
depending upon which area of the solution was affected

Note when merging, squash commit must begin with one of the following tags:
"BREAKING CHANGE", "feat", "fix", "ci", "docs", "test"
Usage
BREAKING CHANGE: any change that breaks current functionality and may cause compatibility errors to users upgrading
E.G BREAKING CHANGE: refactored method x to take variable y as input (changed from variable z)
feat: A new feature
E.G feat: adding method x to future methods table
fix: A bug fix
E.G fix: amending page for method x to show correct release version
ci: Changes to our CI configuration files and scripts (Concourse)
docs: Documentation only changes
test: Adding missing tests or correcting existing tests

DEPLOY_URL=https://d1jyolznmop7fw.cloudfront.net/
cloudfront_id=E2BTC0F0WUROHA

DEPLOY_URL=https://d1jyolznmop7fw.cloudfront.net/
cloudfront_id=E2BTC0F0WUROHA


Use team for codeowners

In the future perhaps there is a more appropriate team for this, but in the meantime it definitely shouldn't have me listed explicitly on it.

Codecov Report

Merging #172 (8ea2352) into main (7ddba6f) will increase coverage by 73.91%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #172       +/-   ##
===========================================
+ Coverage        0   73.91%   +73.91%
- Complexity      0       15       +15
===========================================
  Files           0        3        +3
  Lines           0       46       +46
  Branches        0        5        +5
===========================================
+ Hits            0       34       +34
- Misses          0        8        +8
- Partials        0        4        +4

Impacted Files
Coverage Δ

...elemetry/awspropagator/AwsCompositePropagator.java
87.87% <0.00%> (ø)

...metry/javaagent/providers/AwsTracerConfigurer.java
62.50% <0.00%> (ø)

...emetry/javaagent/providers/AwsAgentProperties.java
0.00% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Added shader-reflect as shader tool

ShaderReflect is a handy CLI tool to reflect GLSL/HLSL/SPIR-V shader interface resources and conclude all the detail in an JSON.

ty :+1:


Allow HTML data in PDF Atbd

Add pdf data in summary and full Atbd endpoint
Allow all HTML workflow for PDF Atbd
Fix issue related to clearing out contacts

@sunu @wrynearson Let's deploy this to the staging


Added Customer Complaint Form

Fixes Issue🛠
Closes #869
Description👨💻
Customer Complaint Form Added.
Type of Change📄

[x] New feature (non-breaking change which adds functionality)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

Why the files of Hotel Reservation Form is showing, pls fix by making the commits in this same PR @Nayanika1402

@Rakesh9100 Sorry for the issue.Now you can merge this pr.

Form is not getting scrolled to the starting top, pls fix @Nayanika1402

@Rakesh9100 Problem solved


createConvolver makes sketch hang

I am trying to add a convolver to a mp3 file and it is mkaing the sketch hang.
The mp3 is about 2:44 long, and the convolver IR file is a .wav from here https://freesound.org/people/recordinghopkins/sounds/ (concrete 01)
Below is my code:
var conv, sound, button;
function preload() {
	soundFormats('mp3', 'wav');
	conv = createConvolver('concrete01.wav');
	sound = loadSound('speech.mp3');
}

function setup() {
	noCanvas();

	sound.disconnect();
	conv.process(sound);
	sound.play();

	button = createButton('Toggle');
	button.mousePressed(toggleSound);
}

function toggleSound() {
	if (sound.isPlaying()) {
		sound.stop();
	} else {
		sound.play();
	}
}

Pretty basic example, but for some reason, it's stuck loading.

That is strange. I can't tell if it is an issue with createConvolver() or preload()
You scrap preload() and do something like this instead:
let conv, sound;
let button;

function setup() {
    conv = createConvolver('concrete01.wav', () => {
        sound = loadSound('speech.mp3', () => {
            sound.disconnect();
            conv.process(sound);
        })
    });

    button = createButton('Toggle');
    button.mousePressed(() => {
        if (sound.isLoaded()) {
            if (sound.isPlaying()) {
                sound.stop();
            } else {
                sound.play();
            }
        } else {
            console.log('be patient while sounds are loading...')
        }
    });
}

It loads them linearly so it's slower. Ideally we would use promises.

Upgrading from 0.3.7 to 0.3.8 fixed the issue :/


Add storyshots watch compatability for jest --watch and wallaby

Issue details
As per #2259, with storyshots there is one storyshots.test.js file so every time i change a story file, jest --watch or wallaby re-runs all the stories which is a bit slow.
Is there a way to correctly setup multiple jest tests, one per story file so the dependency chain is correct?
Happy to submit a PR but thought someone might have some ideas how I'd approach this?
Many thanks
Here is my storyshots.test.ts file where i'm using react native, typescript and prefer multiple snapshot files generated using enzyme shallow.
import initStoryshots, {
  getSnapshotFileName,
} from '@storybook/addon-storyshots';
import { shallow } from 'enzyme';
import toJson from 'enzyme-to-json';
import path from 'path';

//
// initialise storyshots
// https://github.com/storybooks/storybook/tree/master/addons/storyshots
//

// fix _global import in storyshots code to be jest global including describe method
jest.mock('global', () => global);

initStoryshots({
  framework: 'react-native',
  configPath: path.join(__dirname, 'storybook.config.js'),
  test: ({ story, context }: { story: any; context: any }) => {
    // do multi file snapshots with shallow not mount as nicer to compare for humans
    const snapshotFileName = getSnapshotFileName(context);
    const storyElement = story.render(context);
    const shallowTree = shallow(storyElement);

    if (snapshotFileName) {
      // @ts-ignore toMatchSpecificSnapshot added by storyshots
      expect(toJson(shallowTree)).toMatchSpecificSnapshot(snapshotFileName);
    }
  },
});

and my storyshots.config.js which just loads the stories dynamically generated to storyLoader.js using react-native-storybook-loader (https://github.com/elderfo/react-native-storybook-loader)
import { configure } from '@storybook/react-native';
import { loadStories } from './storyLoader';

//
// Loads the generated stories for Storybook.tsx and storyshots.test.ts
//

configure(() => {
  loadStories();
}, module);

cc @igor-dv

I'll try to take a look at it next week.

As you can imagine I failed to take a look. Hope will get to it soon

I have a related problem. If I have setup a precommit hook with jest, and I create a file, say:
thingamabob.tsx
and a corresponding story file:
thingamabob.stories.tsx
then if I change thingamabob.tsx then jest won't detect that the tests related to the stories related to that file should update. This happens even if I create a thingamabob.test.tsx to setup stories that would be in the same context as thingamabob.tsx.

I assume that these all are related also to #3483.

@thomasbertet added a fix to the jest-specific-snapshot that is published as v1.0.0. I assume it will be adopted here soon

@igor-dv Hi, thanks for your great work. Are there any updates on this?

The change was not adopted here yet

It was released.

for any future people finding this thread, i actually ended up writing a little script to run in the prestorybook target that generates one .test.ts file per .story.tsx file. Watching then works no problem and you can check in that new .test.ts file to git.
I wrote up how i did it here: https://codeburst.io/react-native-storybook-generating-individual-test-files-to-snapshot-bdbda32625ce


Testing the cli functionality doesn't match real world

Tests that use the Symfony ApplicationTester have to pass the input in the format of:
[
  'command' => 'build',
  0 => '--quiet',
  'env' => 'development'
]

Which does not match the expected input of $_SERVER['argv'] when running on the actual command line:
[
  0 => 'build',
  1 => '--quiet',
  2 => '--env=development'
]

Unit tests need refactoring so that the arguments passed to Tapestry are consistent with what it receives in the real world.

Solved by 27e6bc903046c61e953e8cb39eaae3905fa1116b


fix: 增加行头收起展开按钮回调事件的透传参数

👀 PR includes
🐛 Bugfix

[x] Solve the issue and close #0

🔧 Chore

[ ] Test case
[x] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

:tada: This PR is included in version @antv/s2-v1.10.0-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-react-v1.10.0-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-v1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-react-v1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix size_t/int mismatch in cms_ec.c and rsa_sig.c

Fixes #20435

This pull request is ready to merge

Merged with manual fix for 3.1 and 3.0.

This seems to have broken the build on 3.1. Possibly due to a bad merge??
crypto/cms/cms_ec.c:278:16: error: unused variable 'enckeylen' [-Werror,-Wunused-variable]
        size_t enckeylen;

@mattcaswell Yes, the PR #20516 fixes the bad merge.


Support for retrieving attributes just from context

Would need another overload for Style, and remove the hard requirement for attributeset not to be null in the generated Barbershop#style(...) method.
private static final int[] ATTRS = new int[]{
        android.R.attr.listDivider
};

// Want to do this boilerplate
final TypedArray a = context.obtainStyledAttributes(ATTRS);
mDivider = a.getDrawable(0);
a.recycle();

// Probable method signature
style(Object target, int[] attrs);

Closed since it kind of just falls under #19


from_delayed can trigger large computation

What happened:
Creation of a dask dataframe from delayed objects now triggers computation.
What you expected to happen:
When a using a dd.from_delayed with the meta keyword, no computation should be done.
Minimal Complete Verifiable Example:
The following code triggers the function with the sleep statement:
import dask
import dask.dataframe as dd
import numpy as np
import pandas as pd

def gimme_a_hull():
    import time
    print("I'm so sleepy")
    time.sleep(1000)
    return pd.DataFrame({"segment_id": np.array([1,2,3])})

results = dask.delayed(gimme_a_hull)()
meta = dd.utils.make_meta([("segment_id", np.int64)])
dd.from_delayed(results, meta=meta)

Anything else we need to know?:
Environment:

Dask version: 2021.6.0
Python version: 3.8.5
Operating System: Ubuntu 20.04.01
Install method (conda, pip, source): pip

I think this line is the culprit.
I'm not familiar with what parent_meta is representing here.  galipremsagar , what is the intention here, and is it possible to avoid triggering a computation?

Thanks for raising the @chrisroa - I think https://github.com/dask/dask/pull/7769 will fix.


Terrain Issues and fallthrough

I was wondering if its supposed to work properly with the Terrain gameobject?  I've tried to get it to work with my own project, but I seem to fall through on jump, and when I throw in your Test Terrain into the TestZone unity area, the player falls through that too after moving around or jumping at an angle.
I'm pretty new to unity development, it could just be user error, but if I'm doing something wrong, please elaborate.

Hey CooL,
The Super Character Controller does not currently support the Terrain
colliders, as each individual collider needs to have code written for it
specifically. In the future it hopefully will.
Thanks,
Erik
On Tue, Sep 15, 2015 at 9:30 PM, CooLTanG<EMAIL_ADDRESS>wrote:

I was wondering if its supposed to work properly with the Terrain
gameobject? I've tried to get it to work with my own project, but I seem to
fall through on jump, and when I throw in your Test Terrain into the
TestZone unity area, the player falls through that too after moving around
or jumping at an angle.
I'm pretty new to unity development, it could just be user error, but if
I'm doing something wrong, please elaborate.
—
Reply to this email directly or view it on GitHub
https://github.com/IronWarrior/SuperCharacterController/issues/4.


[v2] Webpack example

This is an unfinished attempt at setting up webpack in v2. This adds an entrypoint in which we can import anything (fonts, css ...) to create a bundle named django_material. For the moment, I have only worked on importing the JS in the bundle, but it needs to be adapted to stop using window and start using scoped variables and modules exports. I added a config we have which also supports code coverage and JS tdd with jest and linting with npm lint (not done).
To run this run npm install and npm start to start a webpack watcher, or npm pack to just build and exit.
Could you take a look and let me know if you like the direction where this is going ? In this case, I would like to finish the JS, and add the CSS and fonts to the webpack bundle and basically bring back the features from the current v2. I think this direction will make it easier to contribute and reuse components in JS.

Another advantage with this is that you don't need to keep a copy of minified vendor JS because you can install/update with npm install and then import anything you need in the webpack entrypoint (you can import fonts and css and anything into that entry point and webpack will figure out how to expose it to the user).

Also, it is possible to spread the output into any number of chunks and entry points, do you think that would solve the http2 problem ?
I'd like to add this datepicker through npm install: https://github.com/FreddyFY/material-datepicker


EB Payment Journal (Belgium) not suggesting payments for multiple ledger entries.

When posting multiple ledger entries on the same document number, the EB Payment Journal -> Suggest Vendor Payment creates just one payment entry, with the message below:
"Some payments were not suggested because there are still open payments in journal template ."
I understand the intentionality behind it but it's not ideal when you expect to have multiple ledger entries on the same document number. This can be easily done in the Gen. Journal today.
Is there any chance this can be changed so that it will create payment lines for all the open ledger entries on the same document?
Can't this be done better, so that the suggested payment line is a total of all the open ledger entries?
Or, finding a better way to find duplicated payments, instead of throwing a general message?
Thank you.
Belgian localization
EB Payment Journal

Sorry, we are not processing requests for functional changes here. Please create support requests or even better new idea about this possibility on aka.ms/bcideas


Add OSFamily field in SnowMachineConfig

Issue #, if available:
#4050
Description of changes:
Add os family option in EKS-A Snow API and support BottleRocket, on top of Ubuntu.
Testing (if applicable):
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/LGTM


Broken curve pin via rc.2

This results in incompat API between x/curve.

x25519-dalek rc.2 did not pin to curve25519-dalek rc.2
x25519-dalek rc.2 is now picking up curve25519-dalek rc.3 and breaks some builds
x25519-dalek rc.3 fixed this pin in 53e5d9 but rc.2 remains broken

I think the only action that could be taken is to yank x25519-dalek rc.2 with the broken non-pinned curve dependency.
This should not as far as I remember break anyone using --locked in dependency bin which may have old rc.2 in lock ?
This makes it so nobody new will use it and instead use x25519-dalek rc.3 or pre.1
Unless the Scalar API changes #120 between rc.2/3 would be reverted and leave it for next major - which I would not recommend.
Another option would be to release new set of release candidates w/o Scalar #120 change and then Scalar #120 change on top but this could be highly confusing with the versions and could create even a bigger mess.
Could also release "fixup" rc.2 but dunno how that would work with SemVer ?
If someone needs a patch release that is not rc.3 -
e.g. could 2.0.0-rc.2+fixup1 work that utilizes the "build" construct in SemVer ?

Good catch. I'll yank rc.2

Yanked.


Visual debugging and profiling.

A machine code debugger that allows for live viewing of memory, current CPU registers, disassembly etc. This would be similar to many applications that use x86 debugging instructions to step trough an exe file although by integrating it with an emulator it can be used to figure out what an program actually are doing.
A profiler that counts instruction executions to figure out where a program spends time.
A live patcher. A patch specifies a memory location or a function call to replace with a call to a target native dll/so file. This can be used both to speed up programs and also to modify their behavior. Potentially this can be done in a way that is invisible to the guest application by having the emulator just recognize where the program counter enters the code to replace.
For live patching it is useful to be able to replace parts of a function. For example the beginning of main could be replaced with native code that does something that is useful to do in native host-optimized code but then still run parts of the main function. It could also call some of the functions that are called from the original main functions while replacing others with target native code. This would allow an application to be gradually rewritten and translated to a modern programming language. Although it will only make sense to patch parts where features or performance can be improved.

Something like this for debugging: https://x64dbg.com/
Other inspirations (emulator based):
https://syncsim.sourceforge.net/index.php?show=screenshots
https://github.com/slatinsky/x86sim

If you click one of the samples linked from the home page, there is a "view in debugger" button at the top.  Click 'step' a few times to see some asm.
I can't tell from this if you are sharing a general idea, or requesting something specific, could you clarify?

I will do a bit more thinking on the debugger part of this issue as I see that there are a primitive debugger already implemented. The first thing that comes to mind is that there are no restart button. Also neither register content nor memory can be edited. Saving the application state (think action replay) in a format that can be reloaded would also be useful both in the debugger and directly from the emulator.
As for profiling that doesn't seem to be implemented at all. All I can think of here is to count how often the program counter visits a memory location and run an instruction.


Handle CAA cert conflict error

Properly handling CAA cert conflict error that can happen when attempting to alias or when issuing a cert

Codecov Report

Merging #2121 into canary will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           canary   #2121      +/-   ##
=========================================
- Coverage     4.5%    4.5%   -0.01%
=========================================
  Files         243     243
  Lines        8628    8639      +11
  Branches      882     887       +5
=========================================
  Hits          389     389
- Misses       8222    8233      +11
  Partials       17      17

Impacted Files
Coverage Δ

src/commands/alias/set.ts
0% <0%> (ø)
:arrow_up:

src/util/certs/finish-cert-order.ts
0% <0%> (ø)
:arrow_up:

src/util/certs/create-cert-for-cns.ts
0% <0%> (ø)
:arrow_up:

src/util/errors-ts.ts
0% <0%> (ø)
:arrow_up:

src/commands/certs/issue.ts
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c297d2...62c09e0. Read the comment docs.

Tests are failing


Can not save Bitmap to MemoryStream

Repro
var img = new Bitmap(128, 128);
using var ms = new MemoryStream();
img.Save(ms, ImageFormat.Png);
StackTrace
at WinFormsComInterop.WinFormsComWrappers.ComputeVtables(Object, CreateComInterfaceFlags, Int32&) + 0x1af
at System.Runtime.InteropServices.ComWrappers.CreateCCW(Object, CreateComInterfaceFlags) + 0x39
at System.Runtime.InteropServices.ComWrappers.<>c__DisplayClass14_0.b__0(Object) + 0x1c
at System.Runtime.CompilerServices.ConditionalWeakTable2.GetValueLocked(TKey, ConditionalWeakTable2.CreateValueCallback) + 0x2d
at System.Runtime.CompilerServices.ConditionalWeakTable2.GetValue(TKey, ConditionalWeakTable2.CreateValueCallback) + 0x3e
at System.Runtime.InteropServices.ComWrappers.GetOrCreateComInterfaceForObject(Object, CreateComInterfaceFlags) + 0xa8
at System.Runtime.InteropServices.ComWrappers.ComInterfaceForObject(Object, Guid) + 0xe
at System.Drawing.SafeNativeMethods.Gdip.GdipSaveImageToStream(HandleRef, Interop.Ole32.IStream, Guid&, HandleRef) + 0xbd
at System.Drawing.Image.Save(Stream, ImageCodecInfo, EncoderParameters) + 0x144
at Test.Program.Main() + 0x8f

Also can you try add
<PackageReference Include="System.Drawing.Common" Version="6.0.0-preview.7.*" />

to you project. That way my library no longer needed. If you want completely go reflection-free, you need net6.0-windows

I have
.NET Version: 6.0.0-preview.6.21352.12
System.Drawing.Common 6.0.0-preview.6.21352.12

How problematic for you would be use System.Drawing.Common at least 6.0.0-preview7.*.After https://github.com/dotnet/runtime/pull/54884 I cannot rely on internal interfaces, so it may break. Also remove reference to WinFormsComInterop you would not longer need it.

OK. Thank you

I update https://github.com/kant2002/NativeAOTImages to be more inline with changes. so my lib no longer needed. Let me know when you resolve issue.

Yes it works in normal and reflection-free mode


BCC field doesn't work :( ...... (copies in TO instead)

Hi,
I have just been testing this tool to use in my School. It works beautifully for everything we need, except....
When we use our database program to create an email it uses the BCC for confidentiality. But this tool creates the email with the email addresses in the TO field :(
Is this a known issue? Is there anything that we can do?
Thanks,
Pete

Indeed, that's a bug.  Surprising nobody noticed this before.
Todo: look at lpMessage->lpRecips[i].ulRecipClass
and match against:
MAPI_TO
1
Indicates a primary message recipient.
MAPI_CC
2
Indicates a recipient of a message copy.
MAPI_BCC
3
Indicates a recipient of a blind copy.
gmaildrafter can already handle these but the c code doesn't differentiate between them.

Ok, great.
Is gmaildrafter another program you have made that i can use? :)

gmaildrafter is part of tvhgooglemapi, it's the java part that does the actual call, but the dll doesn't currently pass it the proper input parameters


Feature Request Thread (Share your feature requests here)

If you have any feature requests, share them here.

Could you please make the calculator functionable.

and also please make the finder also functionable and one last thing a notes app

Finder is a far stretch because it requires access to system files. (a fake
system may be possible). Notes & calculator are possible though they may
take some time.
On Sun, 22 May, 2022, 2:19 pm thegreatnugget725, @.***>
wrote:

and also please make the finder also functionable and one last thing a
notes app
—
Reply to this email directly, view it on GitHub
https://github.com/PuruVJ/macos-web/issues/48#issuecomment-1133847116,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARVAWVGWZSH65WWLVZJOHE3VLHYIXANCNFSM5VXC57QQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

But can we make the finder link to a computer storage or to a google drive?

Add finder, just with sample pictures and files.

And Safari.

Add finder, just with sample pictures and files.

sure!  @PuruVJ, is this possible to be implemented?

And Safari
see #20 where this has been discussed.

I'm working on adding finder and the notes app on my pull request #63


System.ObjectDisposedException: The object has been closed. after a few seconds

After a few seconds and one command being sent to a Lego hub it abruptly closes the connection. Is there a heartbeat step that needs to occur? This is currently guaranteed to happen every time I try with my current codebase.
System.ObjectDisposedException: The object has been closed. (0x80000013)
   at SharpBrick.PoweredUp.WinRT.WinRTPoweredUpBluetoothCharacteristic.WriteValueAsync(Byte[] data)
   at SharpBrick.PoweredUp.Bluetooth.BluetoothKernel.SendBytesAsync(Byte[] data)
   at SharpBrick.PoweredUp.Protocol.LegoWirelessProtocol.SendMessageAsync(LegoWirelessMessage message)
   at SharpBrick.PoweredUp.Protocol.ILegoWirelessProtocolExtensions.SendMessageReceiveResultAsync[TResultMessage](ILegoWirelessProtocol self, LegoWirelessMessage message, Func`2 filter)
   at SharpBrick.PoweredUp.Protocol.ILegoWirelessProtocolExtensions.SendPortOutputCommandAsync(ILegoWirelessProtocol self, PortOutputCommandMessage message)
   at SharpBrick.PoweredUp.BasicMotor.StartPowerAsync(SByte power)

In the protocol there is no concept of heartbeat. The hubs have a very strange initial connection mode but aside of that it is a very simple protocol on the frame layer.

This is a bit strange considering that StartPower is one of the most basic commands.

I guess this is the hub shutting down. Question is why:

command wrong encoded: i do not believe so
too many commands at once (have you tried with throttling/waiting in between or is your code multi-threaded
do you have esoteric BT hardware? Does it work otherwise/default Lego app?

This is repeatable after sending only one command after the initial connect call. Also the Hubs I've tested with work fine otherwise with the controller or the Lego app.

Have you had the chance to test it on another device? I have no trains, it worked last time I used it (tm) and right now I am in an actual train so hard time supporting you 😂

Creating a trace file would be helpful. I could verify the correct encoding there and check the exact place the thing fails

Have you had the chance to test it on another device? I have no trains, it worked last time I used it (tm) with a technic hub and motor and right now I am in an actual train so hard time supporting you 😂

I have not. I'll try that later today.

Creating a trace file would be helpful. I could verify the correct encoding there and check the exact place the thing fails

Do you have a preferred tool for trace files?

Additional bit of information. It seems to disconnect/stop on its own regardless if I send any new commands. Also sometimes it keeps working flawlessly but its rare. When the abrupt stop happens the light on the hub is still on like its connected but the object has been disposed from .NET.

Which Hub ist it exactly? The train one with the motors or the default Lego two port hub?

I'm using the Lego two port hubs from the RC trains.

I do not have any and I do not remember special behavior for them. They are a late product like the technic hubs.


Feat fz token sort

Added token sort similarity measure with test cases. Token sort has dependency on ratio similarity measure. Added fuzzy wuzzy ratio similarity measure also in this branch.

Coverage decreased (-1.3%) to 98.656% when pulling dbdcc36d8e59fe988a2681a42fd0ba6d99d6b13b on rishab93:feat_fz_tokenSort into b568b6b4de8956250bcca3b45c69523d7ab1bfe3 on anhaidgroup:master.

Coverage decreased (-1.3%) to 98.656% when pulling 5e8b906458277e47a0f19727ba66d5dc87d26bef on rishab93:feat_fz_tokenSort into b568b6b4de8956250bcca3b45c69523d7ab1bfe3 on anhaidgroup:master.

Coverage decreased (-0.9%) to 99.136% when pulling 4921e5c2bba0522397a81baaef786cb4aa3db80b on rishab93:feat_fz_tokenSort into b568b6b4de8956250bcca3b45c69523d7ab1bfe3 on anhaidgroup:master.


ERC20 Example

Add basic ERC20 token functionality

Hi @joenyzio, I saw that there are lot of issues to add examples. Can you tell me what is the contribution process for adding these examples? If all these issues (add example of X) are active then I want to complete as many issues as possible.

I want to complete these as a showcase for my development skills which would help me in the career change.

@nikbhintade you still interested?


adds ceph adapter file and tests

Closes #6410
Here are the test results attached to it

Although I have a doubt that in Ceph.php
How will I get region constants and '.$region.'.ceph.io' this value.

👏 👏 👏 👏 👏 👏 👏  Thank you for including tests and results!

Great PR! 🤯 We left some comments during the review, please check them out.
Please also make sure to:

to run the formatter to fix the lint errors
attach a screenshot of successful tests

In the main branch, if I run vendor/bin/phpunit --configuration phpunit.xml then also the tests are failing, so in my PR tests won't be able to pass well. Only formatters and lint tests can run

Hey,
Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.
When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.
Thanks for helping us improve Appwrite!

Hello @mugdha273
Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.
We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.
Looking forward to your updates and thank you!

Hello @mugdha273
Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.
We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions/make sure the tests are passing by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.
Looking forward to your updates and thank you!

Hi my PR is complete though it is not passing tests. I fetched it from main branch and the tests are failing on main branch also, I've already asked my doubt, waiting for the reply.

okay thanks @mugdha273 ill let the engineering team know you are awaiting a response

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.
Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

discord username: mugdha4791
On Tue, 9 Apr, 2024, 1:42 am Vincent (Wen Yu) Ge, @.***>
wrote:

Hey there! There were a lot of big PRs during this Hacktoberfest, and we
wanted to give everyone ample time to collaborate with our engineering
team. If you were able to merge your PRs during October, amazing. If it’s
still not merged, don’t worry about it either. Either way, we’ve got your
Hacktoberfest swag minted and ready to ship.
Please comment with your Discord username here so we can contact you about
your shipping information to deliver your Hacktoberfest swag.
—
Reply to this email directly, view it on GitHub
https://github.com/utopia-php/storage/pull/88#issuecomment-2043559537,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUI3Z7RMZN4IX4KM6ZFZMXLY4L2Z3AVCNFSM6AAAAAA5PNBGCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGU2TSNJTG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Remove CI workaround for Golangci-Lint

Preflight Checklist

[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[X] I am not looking for support or already pursued the available support channels without success.
[X] I agree to follow the Code of Conduct.

Vault SDK Version
v0.9.4
Expected Behavior
Context: https://github.com/bank-vaults/vault-sdk/pull/427
Actual Behavior
Remove the workaround once Nix builds Golangci-lint with Go version 1.23
Steps To Reproduce
No response
Additional Information
No response

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


JBDS-4313 Show installer window when content is loaded and ready

Codecov Report

Merging #610 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage   86.36%   86.51%   +0.14%
==========================================
  Files          27       27
  Lines        2457     2588     +131
  Branches      218      218
==========================================
+ Hits         2122     2239     +117
- Misses        335      349      +14

Impacted Files
Coverage Δ

browser/model/hyperv.js
92.68% <0%> (-2.19%)
:x:

browser/directives/breadcrumb.js
10% <0%> (-1.12%)
:x:

browser/services/request.js
20% <0%> (-0.84%)
:x:

browser/services/platform.js
86.39% <0%> (-0.38%)
:x:

browser/pages/start/controller.js
44.79% <0%> (-0.04%)
:x:

browser/model/virtualbox.js
71.75% <0%> (-0.03%)
:x:

browser/services/data.js
100% <0%> (ø)
:white_check_mark:

browser/model/cygwin.js
100% <0%> (ø)
:white_check_mark:

browser/directives/pathValidator.js
100% <0%> (ø)
:white_check_mark:

browser/model/helpers/hash.js
100% <0%> (ø)
:white_check_mark:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f5acf...beb0d7d. Read the comment docs.

Here are the demos how it worked before and after fix


ISPN-10601 fix continuous query in server-ng

https://issues.jboss.org/browse/ISPN-10601

@karesti I have an actual fix coming up for registering extensions at boot time.

Replaced by https://github.com/infinispan/infinispan/pull/7314


Krmoos/model and examples

@krmoos how about moving the dsl-file to the docs/diagrams-folder before merging this PR?

@djorgensendk - I think it is more appropriate to keep them in the source folder. It is the "product" that this repository is responsible for.

@Sondergaard and @krmoos makes sense to keep the dsl-files in this repo in the source folder


I need to work with Cr4xy and MastaCoder.

I'd like to become the official translator of the project for the French language please .

I'm not a admin for this project. Ask @Cr4xy, maybe he can make a branch for it ;)

Good idea...car en français je peu vous traduire n'importe quoi... ;)

Or make a lang file :)

@W1LKC0, im happy that you wanna be our french translator for the project. :)
I will make an lang-file, as @MastaCoder said, which you can customize without having to touch any other files.

Gotta work on the lang file :+1:

Yesss thank you :D

@Cr4xy Do you Want Portuguese or Spanish too?

I can do Bulgarian :)

lol i can do any language in google translate. :)

xd nvm

Google Translate is not 100% accurate. :P

^^

I vote for lang file. ;)

yea true. you could always use people for what languages you have and use GT for the languages you don't know about.

@Cr4xy send me a word file so i can translate

Isnt it useless to translate this... as almost only those who can use Google find this repo...  the thing is that I dont want 1 click thing so that noobs can abuse this.


Add a Named Color Picker

Hi @rydmike ,
A huge thank you for this package, it is extremely complete.
Just a small suggestion, the possibility to choose a color among the 1566 named colors in the form of a list or a grid with the possibility to research.
Have a nice day

Hi @LefebvreIlyas, I like it, that's a cool idea! 😎
A list with color+name and a search bar might work, you could scroll and pick or search/filter by name too, perhaps a toggle view to a smaller small/tight grid view as well where you can see more colors at once and still filter by name, but names are not shown (maybe as tooltips). Any other suggestions? How do you see it working ideally?
The "Name That Color" algorithm applies the same color name to many similar colors, by finding the named color with the color value "closest" to a given color value. Picking a given color name could return the exact color definition for the named color from this list: https://github.com/rydmike/flex_color_picker/blob/38337d1cdfdb150f57ce6f831fb7c0fe270989b4/lib/src/color_tools.dart#L821
BTW I did not come up the original color names and codes, it came as mentioned in the source from this project: https://chir.ag/projects/ntc/
And glad to hear you like the package, it is due for some updates and more features, this could certainly be one of them.

Cool! 😀
Your proposal is very good, that's what I had in mind, the tooltips seem to me a very good idea.
As a suggestion I could say:

Allow the configuration of the tile spacing and tile run spacing.
Allow the display of the hexadecimal code in addition to the color name.
When the developer specifies an initial color or the user chooses a color and it doesn't 100% match a named color, I think a symbol like ± or ≈ or something better should be added, I don't know (this suggestion is more general, it also applies to other pickers).
The list / or grid of the named color picker should be scrolled directly to the nearest named color (as all tiles have the same height it should not be very complicated to do, there is also this package to do that: https://pub.dev/packages/scrollable_positioned_list).
The tile of the selected color should be highlighted.
If the color does not match 100%, an additional click sets the selected color as the named color.

Don't forget the quality of the README.md and the demos which allow you to have an overview of the functionality and the degree of customization in an instant, it's really a great job!!


🎉🎊🍾  [New Feature] (code + config + docs) Add new modules, add CI (GitHub Action) and update README.

Pre-Checking
‼Please must read this section and check by yourself.
⚠Do NOT modify this section if it doesn't have any necessary reason.
Please verify the PR header should be satisfied below format:
[commit topic] (commit scope) <commit summary>

commit topic: The major topic of your modify. It could have multiple topics, e.g., [Breaking Change + Test].
commit scope: The scope in project of modify. It could have multiple scopes, e.g., (config + test).
commit summary: Summary of the commits. It should be clear that the target, the KEY POINT why you modify it or what you resolve, etc.

Please refer to GCR (Git Commit Rules) of SmoothCrawler-Kotlin to get more detail about it.

Target

Add configuration of tool gradle
Add new modules.
Add CI (GitHub Action) process.
Update document README.

Modify Code Scope

Add configuration of gradle with the file in format xxx.gradle.kts.

Add new modules in different new packages in directory lib/:

org.smoothcrawler.component.httpio
org.smoothcrawler.component.data
org.smoothcrawler.factory

Add CI configuration in directory .github/workflow.

Modify content of README.

Effecting Scope

The entire how the project should be compiled by gradle.
The entire CI automation how it run by GitHub Action after developers trigger git event push or pull.
Document README.

Description

Add the first part code of SmoothCrawler in programming language Kotlin.

All the code in directory lib/.

org.smoothcrawler.component.httpio
org.smoothcrawler.component.data
org.smoothcrawler.factory

Add CI configuration of GitHub Action in YAML format.

Update the content of README.

Codecov Report

:exclamation: No coverage uploaded for pull request base (release@577bed1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             release       #1   +/-   ##
==========================================
  Coverage           ?   83.33%
  Complexity         ?        5
==========================================
  Files              ?        2
  Lines              ?        6
  Branches           ?        0
==========================================
  Hits               ?        5
  Misses             ?        1
  Partials           ?        0

Flag
Coverage Δ

unit
83.33% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Import tokens to trade via contract address

Currently users can only trade assets that are in the app's asset list.  As a user, I want to be able to trade any asset by pasting in the contract address. 0x's API supports this by passing through the token's contract address (see matcha.xyz example with 0x900dB999074d9277c5DA2A43F252D74366230DA0).

"Search" copy in the field in the trade modal is updated to "Search by name or contract address"

When a user pastes a contract address in the search field, they can see the corresponding asset's Symbol, Name, auto-generated icon, and their current balance populated
*

*use existing styles so this matches current UI in trade modal

If a user clicks the imported asset, they see the Imported Token Alert

Copy: "⚠ Unknown Token Alert
⚠ Unknown Token Alert
This token was detected in your wallet, but is not on the CoinGecko list. Therefore, we cannot verify its legitimacy.
Anyone can create a token and transfer it to your wallet. Before interacting with any token you are not expecting, be sure to research it. ShapeShift makes no representation about the quality, nature, or legal categorization of any tokens.
BTN: (IMPORT TOKEN)
Text link: Read our terms of service

If a user clicks 'I Understand,' the asset is selected and the user can proceed with trading the asset; they can see the asset's name, symbol, and auto-generated icon displayed throughout the trade flow as if it was an asset in the app's token list

Users can click a back arrow to cancel the token import

I can take this up after #959 as I have a feeling people might import tokens that are not very popular and don't have icons

@willyogo do you know where we can source this missing asset data that isn't coingecko, coincap, or yearn?

ah i see, if it's this rudimentary, just symbol/name/decimals, according to @theoboldfrazier we can get this via web3 utils
@mrnerdhair has some valid points that we should provide some sort of indication

when importing custom tokens, and
in a few places in the UI, to denote that a user is dealing with a custom token

ah i see, if it's this rudimentary, just symbol/name/decimals, according to @theoboldfrazier we can get this via web3 utils
engineering note - we need to refetch the portfolio after importing a custom asset to pick up balances etc
@DiggyDiggy2 @reallybeard @SS-FOX-McCloud - @mrnerdhair has some valid points that we should provide some sort of indication

when importing custom tokens, and
in a few places in the UI, to denote that a user is dealing with a custom token

sweet! re: providing indications,

we've got this mockup for warning a user in the trade modal when they import a token
we could consider adding an info/warning icon to any token's icon throughout the UI if a token is not on the CoinGecko list (ideally with a tooltip on hover with the same copy displayed when importing a token, but instead of "trade" we should say "interact with"), but I think that is a separate issue. metamask and other wallets don't show any kind of warning after a token has been imported, but as we move to automatically displaying all tokens in a users' wallet, I do like the idea of showing a non-invasive warning for tokens outside of the "approved" asset list.

ah i see, if it's this rudimentary, just symbol/name/decimals, according to @theoboldfrazier we can get this via web3 utils
engineering note - we need to refetch the portfolio after importing a custom asset to pick up balances etc
@DiggyDiggy2 @reallybeard @SS-FOX-McCloud - @mrnerdhair has some valid points that we should provide some sort of indication

when importing custom tokens, and
in a few places in the UI, to denote that a user is dealing with a custom token

sweet! re: providing indications,

we've got this mockup for warning a user in the trade modal when they import a token

we could consider adding an info/warning icon to any token's icon throughout the UI if a token is not on the CoinGecko list (ideally with a tooltip on hover with the same copy displayed when importing a token, but instead of "trade" we should say "interact with"), but I think that is a separate issue. metamask and other wallets don't show any kind of warning after a token has been imported, but as we move to automatically displaying all tokens in a users' wallet, I do like the idea of showing a non-invasive warning for tokens outside of the "approved" asset list.

i like this justification and you're right, they only warn on import, we're super clear on import here in the mocks, and it's up to them after that. will remove needs product and we can architect this and get it going on engineerings side.

new AC alert:

add a back button so users can cancel

Updated copy from product:
⚠ Unknown Token Alert
This token was detected in your wallet, but is not on the CoinGecko list.  Therefore, we cannot verify its legitimacy.
Anyone can create a token and transfer it to your wallet. Before interacting with any token you are not expecting, be sure to research it. ShapeShift makes no representation about the quality, nature, or legal categorization of any tokens.
BTN: (IMPORT TOKEN)

@0xdef1cafe to take a look at a spike for this.

closing as low priority


Use leader for polling etcd status

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #531
Does this PR introduce a user-facing change?:
NONE

/assign @kron4eg

/retest