⚠ Mobitopup has degraded performance

In d36d63c, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 5575 ms

Resolved: Mobitopup performance has improved in da71bb3.


Project: Overdensities in source density maps

I would like to create a tutorial showing some ways to search for and characterize overdensities in sky maps of the source density in some region of sky. I'm thinking that this will include aspects such as (a) creating density maps of sources selected based on CMD or color-color criteria, (b) exploring the distribution of objects classified as "star" vs. "galaxy" by the 'default' Stack classifier, and possibly tweaking the star/galaxy separation to see the effects, and (c) extracting sources in overdensities and plotting their properties (in, e.g., CMDs, color-color diagrams, density profiles, etc.).
I will use HSC data, but need to select a particularly illustrative field - preferably one with some known "overdensity" such as a Milky Way dwarf galaxy or a rich galaxy cluster.

This sounds good to me, Jeff! I think this belongs in the "Object
Measurement" part of the syllabus, in a folder called "Measurement". I'll
push a suitable folder with a README.rst in it for you. @kadrlica @bechtol
I think you'll be interested in this project! :-)

I think that this has been closed by #250


Ason class/AsonSerializer: Allow serializing superclass fields as well

Considering I have the following class structure:
public class Request {

    public final int id = 1;
    public final String type;

    public Request() {
        type = "important_type";
    }

    public static class SubRequest extends Request {

        public final String data;

        public SubRequest() {
            data = "example_data";
        }
    }
}

When I now run Ason.serialize(new SubRequest()).toString(4);, the String doesn't include the attributes of the superclass, and I can't pass in the fields manually since the AsonSerializer class is private and additionally the AsonSerializer.serializeField() package-private.
I suggest adding a method serialize(Object object, boolean recurse) which also includes the superclasses.

Available in release 1.4.14

Wow, thanks a lot!


orc.b is listed with two operands in section 30.4

orc.b is listed as orc.b rd, rs1, rs2 in section 30.4 instead of the correct orc.b rd, rs as in section 30.5.24.

Thanks for pointing this out.


Signal handling fixes

These changes improve signal handling to make the tcp server easier to manage when running it under Docker.

@vainu-arto thank you for updating!
I have some not-committed changes similar to yours. So I'll commit them into develop branch and close your PR. You can check them and tell if something is wrong.
I'll release this changes in about a month if everything is ok.


Newman-Issue reading data from response body and use them as variables

When I run the collection using newman, getting the error (see snapshot) that "Cannot read property 'xyz' of undefined'. The collection works fine from the Postman tool.
What I am trying to do in my collection that I read some data from the response body and use them as variables in further api calls. (Note that my api call takes nearly 30 seconds to return response)
var retData = JSON.parse(responseBody);
postman.setEnvironmentVariable("msid", retData.data.msid);

Can you put a console.log(responseBody); as the first line of your test script?
Since the request is returning a 400 response, the request isn't being sent correctly for some reason, and I doubt the response will contain the JSON you expect.

Thanks for replying, so I added the log and observed that it is asking for "pid" variable which I already have in my ENV file. And note that it is working fine from Postman UI.
Mverma-Mpro:postman-collections mverma$ less less PB_DEMO.postman_environment | grep -A 3 pid
less: No such file or directory
"key": "pid",
"value": "BAH",
"type": "text",
"name": "pid",
"enabled": true
},
{
Mverma-Mpro:postman-collections mverma$

Also noticed with this other api endpoint, is it coz my form data is in raw format? See snapshot.

Mverma-Mpro:postman-collections mverma$ newman -c Jetpacks_SM_Happy_Paths_V2.json.postman_collection -e SM_DEMO.postman_environment
Iteration 1 of 1
{"message": "The following arguments are required: ['country', 'address', 'city', 'zip', 'companyName'].", "version": "2.0", "requestId": "5519860f00ff00ffebcb4a65a7520001737e736f636d6b74672d64656d6f0001617069733a3237312d6163636f756e742d67726f75702d766f626a65637400010103", "responseTime": 8, "statusCode": 400}
EXCEPTION - TypeError: Cannot read property 'accountGroupId' of undefined
400 518ms V2 - External - CreateSite - Happy https://socmktg-demo.appspot.com/api/v2/account/create/?apiUser=

Can you send the collection file to<EMAIL_ADDRESS>

I have sent you an email with the collection file

Can you try adding a "Content-Type: application/json" header in your Postman request? Chrome adds a content-type header, Node doesn't - which is why your server wasn't recognising your request data as JSON.

So instead of adding that line (I tried it did not work that way, maybe I added it at wrong place) I changed the "Text" to "JSON (application/json)" in postman UI it worked with newman. See snapshot.

So if that is the only way, I will change all endpoints to select that and save them.

Thanks, you may close this issue now, as it is working after making that change you mentioned.

How can i solve this problem in the version 3.0? I cant the option application/json.

If you have a POST or PUT request and select the raw mode in the Body tab, there's a dropdown to the right of the form/url-encoded/raw/binary selector. If you select JSON, a Content-Type: application/json header will be added.


feat(assert): haveResource lists failing properties

Make the haveResource assertion tell you which fields failed matching.
This helps in case of differences in hard-to-read fields, such as
'<IP_ADDRESS>/16' vs '<IP_ADDRESS>/16'.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

cc @SoManyHs


runners_token returns null

To reproduce run the following query
> select
  path,runners_token
from
  gitlab_group

Using the same token I can access the runner registration token using the api so the problem appears to be with the gitlab plugin
curl --fail  --header "Private-Token: ${GITLAB_TOKEN}" "https://$URL/api/v4/groups/$id"

Hey @nmoreau-ocl
Thanks for the report, I can confirm this is indeed the case. It seems to stem from the underlying SDK used returning an empty string for the group.RunnersToken property regardless of the value being in the API call.
I will check to see if this has been remediated in a newer version of the GitLab SDK & if so update accordingly.

I've checked with latest release of the SDK v0.73.1 and this still currently returns empty string for the RunnersToken property of a group when called by the ListGroups function, but returns it based on the GetGroup function.
I've created an issue over on their repo: here

For now (as a temporary workaround) - you can obtain the runners_token by simple querying for a specific group:
select path, runners_token from gitlab_group where ID = 123;

This should return your required value.

Great news, thank you

Hey @graza-io ... for List APIs that don't include all the get information, one approach is to use a Hydrate function to do the sub-API call to the GET for those affected columns.
Pro - This makes the list behave identically to the get commands in terms of the per-row data.
Con - You do a get call per row (if those columns are requested in the query).

Hey @graza-io ... for List APIs that don't include all the get information, one approach is to use a Hydrate function to do the sub-API call to the GET for those affected columns.
Pro - This makes the list behave identically to the get commands in terms of the per-row data.
Con - You do a get call per row (if those columns are requested in the query).

Yup, that's a potential band-aid, would be interesting to see why the SDK drops this value for the List approach, when it's actually there in the returned JSON payload from the API.


Compiled builds?

Do you have some jars for me to use or a build server?

I just made a pull request where I add maven support. Check my fork. You will only have to install Maven in your pc and execute a command. But I uploaded a jar here: https://drive.google.com/file/d/0B6YspTAL_CB_UWhTaW94QlZIMWc/view?usp=sharing

Answer if it helped you pls

404

On Dec 8, 2016, at 9:10 PM, Lmmb74<EMAIL_ADDRESS>wrote:
I just made a pull request where I add maven support. Check my fork. You will only have to install Maven in your pc and execute a command. But I uploaded a jar here: https://drive.google.com/file/d/0B6YspTAL_CB_UWhTaW94QlZIMWc/view?usp=sharing
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

lol, gonna upload it again now

https://drive.google.com/open?id=0B6YspTAL_CB_TTAwQlV4TExWdnM

Close this. The maven update has been succesfully pushed.

@samerton, close this.

There is now a Jenkins build server available, you can find the first available jar file here. Please note that the plugin is still in development, and is not yet ready for use on a public server.


People to add

[x] Sören Mindermann https://arxiv.org/abs/1712.05812
[x] Alex Mennen, intern at MIRI https://www.facebook.com/alexmennen
[x] Nicolas Gagné, intern at MIRI April 2014 to August 2014 https://www.facebook.com/nicolas.gagne.9/about?lst=100008068993970%3A514911510%3A1531639016&section=education
[x] Alex Appel = Diffractor, "related essay by Alex Appel" https://agentfoundations.org/item?id=1816
[ ] the people in https://www.general-ai-challenge.org/solving-the-ai-race-results
[x] https://arxiv.org/abs/1806.04067
[ ] https://www.openphilanthropy.org/focus/global-catastrophic-risks/potential-risks-advanced-artificial-intelligence/ai-scholarships-2018
[x] new people on MIRI team page
[x] https://www.linkedin.com/in/michael-page-71318613/ "Policy and Ethics Advisor Company Name OpenAI Dates Employed 2017 – Present Employment Duration 1 yr Location San Francisco Bay Area"
[ ] Daniel Braun https://www.greaterwrong.com/posts/bXLi3n2jrfqRwoSTH/human-aligned-summer-camp-a-summary#section-6
[x] Luke Raskopf http://rationality.org/about/team (added around week of August 12)
[x] Johannes Treutlein http://effective-altruism.com/ea/1rz/request_for_input_on_multiversewide/ "I am currently working on a research project as part of CEA’s summer research fellowship."
[x] Michaël Trazzi https://arxiv.org/abs/1808.03644
[x] Jeremy Nixon? https://www.linkedin.com/in/jeremyvnixon/
[x] Christopher Olah, from Google Brain to OpenAI https://www.facebook.com/100003775051002/posts/1402487849887037/
[x] Vishal Maini, https://www.greaterwrong.com/posts/Y8ezvHWZXW232CkKr/link-new-deepmind-ai-safety-research-blog
[x] [OpenAI; update https://github.com/riceissa/aiwatch/blob/master/sql/positions/openai-positions.sql after @riceissa gives repo permissions] Daniel Ziegler https://80000hours.org/podcast/episodes/olsson-and-ziegler-ml-engineering-and-safety/
[ ] https://arxiv.org/abs/1811.07871
[ ] https://futureoflife.org/ai-safety-research/
[ ] "In the Christmas period just gone, Peter McIntyre visited Oxford and the San Francisco Bay Area for a month each and interned at CFAR in the latter." https://eaforum.issarice.com/posts/EpQqh6wCDtfZkeneg/should-you-visit-an-ea-hub
[ ] some of the grantees for the long-term future fund
[ ] "volunteer Zack Davis" https://www.lesswrong.com/posts/iLGrNTwTZivTX5774/less-wrong-q-and-a-with-eliezer-yudkowsky-ask-your-questions#h76Luakpa2JeWmsBJ
[ ] "March 2015 [...] I become a MIRI contractor instead." https://www.greaterwrong.com/posts/iBBK4j6RWC7znEiDv/history-of-the-development-of-logical-induction

@omgitsmana For Australian National University for Michael Cohen, please remove the "The".

For the paper https://arxiv.org/abs/1811.07871 can you cover all the authors, e.g. David Krueger has DeepMind and MILA as affiliations, but right now only FHI is recorded in Org Watch.

For the people in https://futureoflife.org/ai-safety-research/ I think the current notes field is a little misleading. You can just say "One of the 2018 [or 2015] Future of Life Institute AI safety grant recipients."


iFrame with dynamic blog posts nested in toggles not resizing in mobile phones.

Firstly, great work on the resizer! Works well on desktop. Just one small issue, when I test it on my mobile, it does not resize the iFrame. Half of the content just sinks, it does not calculate the dynamic height too. Here's the page for reference - thebreeze.com.au/who-we-work-with/
Nothing too special on how it is called. Just the regular CSS (iframe {width: 1px;min-width: 100%;}) script code (iFrameResize({ log: true }, '#myIframe');). I have also tried and experimented the different values from heightCalculationMethod.
resizer version is v4.3.9
Please let me know if you need more info! Thanks :)

Check the console output, I'm seeing error 403 in the iframe when it tries to load the js file.

There might have been a hiccup but I don't see the 403 error on my console on my end now.
It's also worth mentioning I've set the warningTimeout to 20000.

https://rebelagency.com.au/wp-admin/js/iframeResizer.contentWindow.min.js

You're right! I didn't notice because my IP was whitelisted in my .htaccess file. For others experiencing the same error, here's how I managed to allow access without compromising the security/permissions of my other files.

You can try to adjust the file's permission first to 7/5/5 - ultimately allowing/ticking everything on the Execute row.

If that still does not work, you might have an .htaccess file nested on your /wp-admin folder. Put on this code -
<Files "iframeResizer.contentWindow.min.js">
Allow From All

#iFrame Resizer allow execution/permission

Again, thank you David for this awesome library! 🤘

Glad it works now. Could I ask a small favour, I'm currently updating the docs and I would love to add a small guide on how to use iframe-resizer with WordPress, but I've never used it. I was wondering, if you could detail how you set it up, so I could include it and help everyone else.

I would have expected 644 to be ok for the permission, as it does not run on the server.

lo

Sure thing! In my case, we use a theme builder and a cpanel hosting with some custom security blocks to restrict .

Thank you, I've just put a page together on the draft website for Version 5.
https://iframe-resizer.com/frameworks/wordpress/


Video only audio

https://biyori.moe/d/uhewwssnsa.png
Only sound is playing on video.
using Chrome

This is because you need to use the correct codecs for HTML5 video:
https://developer.mozilla.org/en-US/docs/Web/HTML/Supported_media_formats


share terminal backend code in the constructor

https://github.com/microsoft/vscode/blob/e42240c92de43ea593548f119dce26a9ff4a9a67/src/vs/platform/terminal/common/terminal.ts#L224-L231
with a shared refreshEnvironment (or something) function
https://github.com/microsoft/vscode/blob/e42240c92de43ea593548f119dce26a9ff4a9a67/src/vs/workbench/contrib/terminal/electron-sandbox/localTerminalBackend.ts#L275-L318

with a shared refreshEnvironment (or something) function

Just parseSerializedState instead since the environment stuff would happen in the server process for remote.


When grafana repliacas is > 1 , then the log in session is lost during browsing

Hello,
I has set Grafana to use more that 1 replica, also I have created my own kubernetes services (I don't use the one provided by operator because I need to customize the service name due to backward compatibility).
But when I go to the browser I log in and when I move through different grafana pages, the log in session is lost and I cannot get in where privileges are needed.

Looks like this can be fixed by upgrading to Grafana >= 6.2: https://grafana.com/docs/tutorials/ha_setup/#user-sessions (where session storage is enabled by default)

@pb82  in fact I am using 6.4 version and the problem of session still happens, I am using these options in operator.yaml:
args:
    - '--grafana-image=grafana/grafana'
    - '--grafana-image-tag=6.4.3'

Right, that actually makes a lot of sense: the default database that Grafana uses is sqlite and when we scale to multiple instances, there will be one database file per instance (pod). So user sessions are not shared.
I can see a number of possible solutions:

use an external database and configuration to outsource all grafana data & sessions to it.
use an external Redis instance for user sessions and configure it using remote_cache.
we change the grafana operator to use a postgres database by default to support proper scaling.

Please let me know what you think.

I recommend making grafana stateless as much as possible without using another DB to maintain.
For this use case I recommend using kubernetes secrets and use them inside the grafna pods as environment variable or as a volume.
You can see an example in this helm repo that uses secrets in environment variables:
https://github.com/helm/charts/blob/67ed74b614bb5f4e068017101a8673c63459f383/stable/grafana/templates/_pod.tpl#L221

@clausa20 I think this would be best solved by providing an example that sets up a remote cache along with Grafana. I'll try to get to this.

@clausa20 An example for a deployment with multiple replicas is now provided: https://github.com/integr8ly/grafana-operator/tree/v3.0.1/deploy/examples/ha


New package: LeafletPluto v1.0.0

Registering package: LeafletPluto
Repository: https://github.com/florianfmmartin/LeafletPluto.jl
Created by: @florianfmmartin
Version: v1.0.0
Commit: 3da33200ee0933ffc7464771f7521451b0dae7f6
Reviewed by: @florianfmmartin
Reference: https://github.com/florianfmmartin/LeafletPluto.jl/issues/2#issuecomment-2372463664

Thank you for submitting your package! However, please make sure to add some documentation before registering. At the very least, that would be a description of the package's purpose and a small usage example in the README.
For a 1.0 initial release, the bar would be a bit higher than that. A 1.0 release by definition defines a stable API, which is only possible if that API is fully documented.

I would also strongly recommend adding some tests. Having a Pluto notebook as your actual implementation seems unusual. Does that actually work? It would be hard to tell, without having an actual test suite ;-)

Hi @goerz !
I considered your comments and added documentation. As for the Pluto notebook implementation, it is what PlutoMapPicker does, and as this packages is meant for Pluto notebooks I think it makes sense. I'll update the PR via @JuliaRegistrator register().

Closing in favor of https://github.com/JuliaRegistries/General/pull/115921


Backport release script from.

Backport the release script from #213.

Resolved via https://github.com/r2dbc/r2dbc-h2/commit/cf9c83e609447514811eb15b2902cab4fe61a9ca


enable COPY from .gz/bz2/zip/tar/tgz files through libarchive

NOTE: Boost:iostream does not work for tar/tgz/zip types!!

The "universal decompressor" of libarchive does work!!


Support for Private Git Repo as source for cloning onto Share Workspace/

For the git clone feature that is mentioned in the screenshot below. Does the source git repo need to be accessible via the internet or does AML also support cloning from a internal git repo hosted on premise i.e. can AML leverage an Express Route or VPN tunnel back to a customer site to enable cloning from an internal git repo not accessible via the internet.
It is unclear from the documentation if this is possible. The equivalent documentation for Azure Data Factory and Azure Databricks both explicitly mention that only internet facing git repo are supported but a similar mention is not made on this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05d7effc-75db-7b0d-538a-493b02ce7432
Version Independent ID: 4e4b77f0-abfd-13f1-81f2-dd17c6df0025
Content: Git integration for Azure Machine Learning - Azure Machine Learning
Content Source: articles/machine-learning/concept-train-model-git-integration.md
Service: machine-learning
Sub-service: mlops
GitHub Login: @jpe316
Microsoft Alias: jordane

@pnarsi Thank you for your post. We will look into it and get back to you shortly.

@pnarsi Thanks again for reaching out to us, I have assigned this issue to author @jpe316 for reviewing and necessary updating.

@pnarsi Can you clarify what you are trying to achieve? Are in trying to clone internal Git Repos only available on a company-specific VNET? This should be possible.  Are you running into any issues?

Thanks @jpe316 @AbeOmor for clarifying that it is the AML Compute Instance that needs connectivity to the git repo in order to enable the cloning. We are in the middle of deploying our first AML instance and working out the required network connectivity between the different components (so that we can lock it down it get it reviewed by our Security team) has been a quite a challenge.


Unable to Import PREMIUM Shadowdark Rulebook PDF

As title suggests, my kickstarter reward only includes the PREMIUM_SHADOWDARK_RPG_-_V4-8 version of the PDF and it is not recognized as a supported PDF.

@MelvinMcSnatch the premium rule book is not supported. See issue #11


Optimal parameters for VP8/9 encoder for every stream level (low, mid, hi)

Need to find optimal encoder parameters in terms of maximum/target bandwidth and framerate for three levels of video quality: low, medium and high. Latest encoder unit tests show higher actual bandwidth for 720p than requested:
[ RUN      ] TestCoder.TestEncode700K
[ INFO     ] 5 frames encoding took 100 ms (avg 20.00 ms per frame)
[ INFO     ] Encoded 30 (1280x720) frames with target rate 700 Kbit/s: encoded 5 frames, dropped 25 frames, actual rate 1155 Kbit/s, 1 key, 4 delta
[ INFO     ] Encoded frame sizes (bytes): key - 29384.00, delta - 28393.00
[       OK ] TestCoder.TestEncode700K (1357 ms)
[ RUN      ] TestCoder.TestEncode1000K
[ INFO     ] 7 frames encoding took 139 ms (avg 19.86 ms per frame)
[ INFO     ] Encoded 30 (1280x720) frames with target rate 1000 Kbit/s: encoded 7 frames, dropped 23 frames, actual rate 1606 Kbit/s, 1 key, 6 delta
[ INFO     ] Encoded frame sizes (bytes): key - 29376.00, delta - 28378.83
[       OK ] TestCoder.TestEncode1000K (1349 ms)
[ RUN      ] TestCoder.TestEncode2000K
[ INFO     ] 11 frames encoding took 213 ms (avg 19.36 ms per frame)
[ INFO     ] Encoded 30 (1280x720) frames with target rate 2000 Kbit/s: encoded 11 frames, dropped 19 frames, actual rate 2917 Kbit/s, 1 key, 10 delta
[ INFO     ] Encoded frame sizes (bytes): key - 75784.00, delta - 28305.40
[       OK ] TestCoder.TestEncode2000K (1335 ms)
[ RUN      ] TestCoder.TestEncode3000K
[ INFO     ] 16 frames encoding took 304 ms (avg 19.00 ms per frame)
[ INFO     ] Encoded 30 (1280x720) frames with target rate 3000 Kbit/s: encoded 16 frames, dropped 14 frames, actual rate 4325 Kbit/s, 1 key, 15 delta
[ INFO     ] Encoded frame sizes (bytes): key - 109829.00, delta - 28218.53
[       OK ] TestCoder.TestEncode3000K (1339 ms)
[ RUN      ] TestCoder.TestEnforceNoDrop
[ INFO     ] 30 frames encoding took 920 ms (avg 30.67 ms per frame)
[ INFO     ] Encoded 30 (1920x1080) frames with target rate 1000 Kbit/s: encoded 30 frames, dropped 0 frames, actual rate 16223 Kbit/s, 1 key, 29 delta
[ INFO     ] Encoded frame sizes (bytes): key - 66965.00, delta - 64891.14
[       OK ] TestCoder.TestEnforceNoDrop (1562 ms)
[ RUN      ] TestCoder.TestEnforceKeyGop
[ INFO     ] 90 frames encoding took 1748 ms (avg 19.42 ms per frame)
[ INFO     ] Encoded 90 (1280x720) frames with target rate 10000 Kbit/s: encoded 90 frames, dropped 0 frames, actual rate 9937 Kbit/s, 3 key, 87 delta
[ INFO     ] Encoded frame sizes (bytes): key - 194611.33, delta - 35067.60
[       OK ] TestCoder.TestEnforceKeyGop (4044 ms)
[ RUN      ] TestCoder.TestEnforceKeyTimed
[ INFO     ] 36 frames encoding took 732 ms (avg 20.33 ms per frame)
[ INFO     ] Encoded 90 (1280x720) frames with target rate 3000 Kbit/s: encoded 36 frames, dropped 54 frames, actual rate 3442 Kbit/s, 3 key, 33 delta
[ INFO     ] Encoded frame sizes (bytes): key - 117339.67, delta - 28202.61
[       OK ] TestCoder.TestEnforceKeyTimed (4096 ms)
[----------] 10 tests from TestCoder (16478 ms total)

As can be seen from the test, 720p@30fps requires much higher bandwidth than expected:
[ RUN      ] TestCoder.TestEnforceKeyGop
[ INFO     ] 90 frames encoding took 1748 ms (avg 19.42 ms per frame)
[ INFO     ] Encoded 90 (1280x720) frames with target rate 10000 Kbit/s: encoded 90 frames, dropped 0 frames, actual rate 9937 Kbit/s, 3 key, 87 delta
[ INFO     ] Encoded frame sizes (bytes): key - 194611.33, delta - 35067.60
[       OK ] TestCoder.TestEnforceKeyGop (4044 ms)

This might be due to the enforced key frames. For non-drop enforcement, 720p@30fps gives around 7Mbit/s:
[ RUN      ] TestCoder.Test720pEnforceNoDrop
[ INFO     ] 30 frames encoding took 546 ms (avg 18.20 ms per frame)
[ INFO     ] Encoded 30 (1280x720) frames with target rate 1000 Kbit/s: encoded 30 frames, dropped 0 frames, actual rate 7085 Kbit/s, 1 key, 29 delta
[ INFO     ] Encoded frame sizes (bytes): key - 29420.00, delta - 28365.79
[       OK ] TestCoder.Test720pEnforceNoDrop (1329 ms)

Another note: randomly generated frames might not be a good source for measuring encoder.


ci(release): fix macos nydusd rust target

Can not use declare -A in macos shell.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Go over all the following points, and put an x in all the boxes that apply.

[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

Thanks for working on this, it should fix the failure in release github action.


MH-13556, Fix Login Page

Unfortunately, pull request #883 did remove a few necessary libraries as
well which completely broke the log-in page making it impossible for
anyone to log-in.

That was possibly the fastest merge we ever had 🙀
Thanks!


Affected by Imagemagick security issue?

Does anybody know if this lib and therefore thumbor is affected by the imagemagick security flaw published at https://imagetragick.com/  ?

We do not protect against anything in Graphicsmagick, so if it has the same issues as ImageMagick, we'll probably have them here. Don't know for sure, though. Sorry.


Add currency allow list proposal

This adds an on-chain proposal for community alignment on guidelines when enabling tokens into the ecocredit marketplace currency allow list, as originally outlined in this forum post.

I think the proposal is clear and well-written @clevinson ; @glandua just questioning if RND can author and submit this proposal given legal limitations, and if we need a third party (LOA volunteered) to submit this signaling proposal.


Progress bar

Add a file upload progress bar
Todo:

[x] Make it work on the homepage, too
[x] Funny loading messages

Design:


upgrade mixpanel version to 5.3.1

Fixing issue #162

Can you upgrade this to 5.5.0? It moved from GCM to Firebase Messaging.

@davodesign84 Do you have plans to update this library to support the 5.5.0 release anytime soon? Looking to move everything over to FCM to comply with the April 11th GCM API removal.
https://github.com/mixpanel/mixpanel-android/releases/tag/v5.5.0

@davodesign84 We have updated the module to 5.6 so it can be closed.


Missing Server.JS

I tried to run the source on my local machine using Node.JS as explained in the readme. However the repo doesn't include a server.js file.

+1. I ended up forking the project in order to add a server.js and other scripts to make it easier to simply "clone and run" the project:
https://github.com/roanosullivan/ynab-csv/commit/00132ec719b3738b90f1d881739ffdf352f57359

Thanks Roano

Thanks, not sure why that was in .gitignore.

 So any webserver would do potentially. It just needs to serve up the static files.


osx bug fix: awk: calling undefined function gensub

# mac bug fix
AWK_COMMAND=`[ "$(uname)" == "Darwin" ] && echo gawk || echo awk`
program_exists() {
    local ret='0'
    command -v $1 >/dev/null 2>&1 || { local ret='1'; }
    if [ "$ret" -ne 0 ]; then
        echo 0
    fi
    echo 1
}
if [ "$(uname)" == "Darwin" ] && [ $(program_exists gawk) -eq 0 ]; then
    echo "Command not found: gawk"
    echo "    Use Homebrew and then just run: brew install gawk"
    exit 1;
fi
...
${AWK_COMMAND} -F"$fs" '{
...

Hi @easonjim
There is a issue for this #31. I just opened a solution on #37.

Hi @easonjim
There is a issue for this #31. I just opened a solution on #37.


[Regex] Build _RegexParser without resilience

Cherry-pick of #58810

_RegexParser does not need resilience as it's only ever going to be used by _StringProcessing and RegexBuilder. It's version-locked with its dependent modules.
Resolves rdar://93067204.

This needs to wait for swift-experimental-string-processing#409.

swift-experimental-string-processing#409
@swift-ci please test

apple/swift-experimental-string-processing#409
@swift-ci please test

@swift-ci please test

@swift-ci please test and merge


[Flutter News Toolkit] Upgrade to Mason v0.1.0 (stable release)

Use case
There's finally a stable release of pkg:mason and pkg:mason_cli (v0.1.0) 🎉
This issue is tracking the changes needed to upgrade the flutter_news_template to v0.1.0 of pkg:mason
cc @wolfenrain @alestiago @tomarra
Proposal
The only changes needed should be to upgrade the environment constraint in the template's brick.yaml to include ^0.1.0 and to bump the mason version in the hooks' pubspec.yaml to ^0.1.0.

Great to know! What do you think if adding Dependabot there to make sure it's always updated?

Great to know! What do you think of adding Dependabot there to make sure it's always updated?

Yup sounds like a great idea 👍

Done! Dependabot added and Mason updated 👌


Move NLU pipeline to Windows Build Agent to work around bug

There is a bug with downloading artifacts on a Mac/Linux build agent, which prevents us from running the NLU pipeline on one of those agents. There is nothing specific in the nlu.yml pipeline that requires *nix, so we should move it over to Windows.

Pipeline has been updated in Azure DevOps to use a Windows Build Agent by default


Flask throws an error while searching a med

Steps to replicate:

Created a new medicine reminder called "Paracetamol".
Then went to schedule to check.
Then went to medicine page but it throws an error - "IndexError IndexError: list index out of range"

Full Traceback
File "/Users/pancham/opt/anaconda3/envs/tshack/lib/python3.7/site-packages/flask/app.py", line 2088, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/pancham/opt/anaconda3/envs/tshack/lib/python3.7/site-packages/flask/app.py", line 2073, in wsgi_app
response = self.handle_exception(e)
File "/Users/pancham/opt/anaconda3/envs/tshack/lib/python3.7/site-packages/flask/app.py", line 2070, in wsgi_app
response = self.full_dispatch_request()
File "/Users/pancham/opt/anaconda3/envs/tshack/lib/python3.7/site-packages/flask/app.py", line 1515, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/pancham/opt/anaconda3/envs/tshack/lib/python3.7/site-packages/flask/app.py", line 1513, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/pancham/opt/anaconda3/envs/tshack/lib/python3.7/site-packages/flask/app.py", line 1499, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
File "/Users/pancham/Documents/test123/main.py", line 354, in medicines
medicine_card_html += medicine_card(results['names'][index], results['prices'][index],
IndexError: list index out of range

FIXED smiles slightly again?


Update to edition 2018 & clippy

#70 is missing changes for edition 2018
The edition="2018" entry in Cargo.toml and cargo fix --edition-idioms

Please remove the commit that removes the Error stuff.

bors r+
Thanks again!


API Add GraphQL can not query attributes by @auth

Describe the bug
Amplify API Add GraphQL with @auth schema, query those custom attributes using AppSync console returns error.
To Reproduce

Create a new Amplify project with amplify init
amplify add api and select GraphQL
Setup API with Cognito User Pool authoriser
Use the following schema:

type Note
@model
@auth(rules: [{allow: owner, ownerField: "user"}])
{
id: ID!
content: String
}

amplify push
Go to AppSync console > Query. Login Cognito user.
Create a note with createNote mutation. The query result is OK:
{
"data": {
"createNote": {
"id": "e514d430-7946-4dce-9eda-d42a20caa4af",
"content": "Hello World Note 1"
}
}
}
Check DynamoDB, a record is created with fields id, content, user, createdAt, updatedAt
Run the query:
query ListNotes {
listNotes {
items {
id
content
user
}
}
}
Get back the following error:
{
"data": null,
"errors": [
{
"path": null,
"locations": [
{
"line": 13,
"column": 7,
"sourceName": null
}
],
"message": "Validation error of type FieldUndefined: Field 'user' in type 'Note' is undefined @ 'listNotes/items/user'"
}
]
}

Expected behavior
The resulted schema by Amplify CLI does not list those fields (user, createdAt, updatedAt) inserted by resolvers.
Additional context
amplify --version
0.1.29

This is because you are not adding the user: String field to your Note type. Change your Note type to this and it will work as expected.
type Note
@model
@auth(rules: [{allow: owner, ownerField: "user"}])
{
  id: ID!
  content: String
  user: String
}


Use without bootstrap-icons

I'd be great to be able to use without bootstrap-icons, since unplugin-icons with vite (or other bundlers) is so good at only including used icons.

I agree we shouldn't import all icons, is pointless. I like the way that BootstrapVue team implemented it. They run a script that generates all the icons, I don't know the cost of replicating that behavior in our library.

unplugin-icons really shines when you use it with auto-import: https://github.com/antfu/unplugin-icons#auto-importing
After using that setup, which works in vue2 and vue3, it's hard to think that BootstrapVue's or any other approach makes sense, especially considering that all collections  (not just BS) are just one kebab string away from being in your app.  For this reason, I imagine that bootstrap-icons are at the very bottom of the list of things people want out of this library.


Remove unnecessary release plugin configuration

What was changed? Why is this necessary?

Removed the unnecessary configuration for maven-release-plugin
Update the release guide
updated the travis configuration to also build tags.

How was it tested?
n/a
Reviewers

[ ] John Leacox
[ ] Nimesh Subramanian
[ ] Supriya Lal
[ ] Brian van de Boogaard

+1


Correct comment block

CSS comments use the syntax /* */. This might be the cause of CI failing in https://github.com/w3c/vc-json-schema/actions/runs/5904523609/job/16016782352?pr=205

@OR13 mind taking a look?

This looks correct, I'm afk so I can't publish a new version for a while.

No rush, thank you sir!

Technically if you can push a new build, with this change up I may be able to publish a tag from my phone... That could be fun to attempt


Comparing commits results in an empty changelog

A picture is worth a thousand words; I would expect that text would be present here.

Aditional information:
Version: <IP_ADDRESS>5
This only happens when clicking on the link 'View comparison for these x commits' from the dashboard. The differences from the individual commits does work as expected.

Please add more information. Diffing works on 0.8.22 on our end.

@exmex I updated my original post.

This is claimed to be fixed by merging #2480

:+1: Thanks!


Network exceptions

Dear @o1298098 ,
let me suggest a complete and robust Network communication module used under Fish in this repo: https://github.com/bozaigao/fish-redux-demo .
I think that it could even inspire us to create a lib for network using the patterns found there.
cheers
hh

Thank you for your suggestion, I will improve network exceptions, all API requests will return a base class, including status code， data and exception information


About demo  face precision

hi ,i saw the pose in you demo face as blow , and the yaw is 40, apparently it can not be true ,have you check the  actual results?

The sample image might be between 35 ° and 40 ° ，and you can take photos by yourself (confirm your angle) to test and confirm


Add namespaced alternatives for what is strictly speaking invalid HTML

r: @Garbee @sgomes

LGTM, thanks @surma!

We don't seem to have shipped the data-for yet, so LGTM.

Thanks guys.


Upgrade to latest sphinx 3.3.0

Requires released version of https://github.com/prestosql/docker-images/pull/77

Thanks for updating Sphinx. This is something I've been wanting to do for a while. However, I don't think we should move the Docker image out now. I'm happy to merge this now without that part of the change.

Thanks!


Support projection post operator

To retain only required columns in result. We can make columns via post-aggregator, etc. but cannot remove column which is not needed or should not be returned.

example:
"context": {
   "postProcessing" : {
      "type": "projection",
      "columns": ["column", "list", "you", "want", "to", "retain"]
   }
}

My feeling is that this is a neat feature but would better belong in the ToolChests (probably in postMergeQueryDecoration) than in a post processing operator. That way it would be extensible for custom queries.

@gianm Thought about that but for that we need add new fields (something like "retainSolumns") in query objects. would it be better?

IMO it wouldn't be too bad to add an optional "projection" field to any query that wants to support projections. welcome opinions from others though.

@gianm addressed comment. added outputColumns to timeseries/groupby/topn/select queries.


fix: update cache_format_version for rails 7.1.2

Solves the following deployment error by following the guide below.
STDERR:

DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.

Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format
for more information on how to upgrade.

Closes #1509
EDIT: Turns out the deployment issue was unrelated to this error. However, this update is recommended for Rails going forward.
Changes proposed in this pull request

update cache_format_version for rails 7.1.2

Instructions for Reviewers
PS: Does anyone know how to test this locally?
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

That is what I was getting at. That modifying load_defaults to 7.0 would mean that you would have to implement the changes.
From: Stephen Hulme @.>
Reply to: sanger/limber @.>
Date: Monday, 15 January 2024 at 15:22
To: sanger/limber @.>
Cc: Stephen Inglis @.>, Review requested @.***>
Subject: Re: [sanger/limber] fix: update cache_format_version for rails 7.1.2 (PR #1545) [EXT]
I presume that setting config.load_defaults = 7.0 will not work as it would introduce further issues?
Setting it to 7.0 does appear to work, but the list of changes [guides.rubyonrails.org]https://urldefense.proofpoint.com/v2/url?u=https-3A__guides.rubyonrails.org_configuring.html-23versioned-2Ddefault-2Dvalues&d=DwMCaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=PioAYl_Zz9lnGwJRms8MsEB0E-grNRW-ut-_gAGl70g&m=bDPH67_whaV4RBNquuxCKfJZbfGshwq0i5aWgPZjnut5PKgFglyED3zb8js0f-NL&s=4Hr9_v2IVndBZwNNIqJAQIWdHkt6WqDPhOUkDoamD3o&e= is quite long and I'm not sure I fully understand the consequences of them.
In hindsight, I think I'd prefer to leave it at config.load_defaults = 6.0
—
Reply to this email directly, view it on GitHub [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sanger_limber_pull_1545-23issuecomment-2D1892371511&d=DwMCaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=PioAYl_Zz9lnGwJRms8MsEB0E-grNRW-ut-_gAGl70g&m=bDPH67_whaV4RBNquuxCKfJZbfGshwq0i5aWgPZjnut5PKgFglyED3zb8js0f-NL&s=YIUOYmjpJdRjIsrPHsWYCJEXJGecKVMR9v3_HBDwkhk&e=, or unsubscribe [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAD6ZH3HB7SKZUMZCEGIQLDYOVCTRAVCNFSM6AAAAABB3BF752VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGM3TCNJRGE&d=DwMCaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=PioAYl_Zz9lnGwJRms8MsEB0E-grNRW-ut-_gAGl70g&m=bDPH67_whaV4RBNquuxCKfJZbfGshwq0i5aWgPZjnut5PKgFglyED3zb8js0f-NL&s=pBsIg2qKJVDE1HNi-9TMNvjKtuLTUo2BAQdq4aKVrd8&e=.
You are receiving this because your review was requested.Message ID: @.***>
--
The Wellcome Sanger Institute is operated by Genome Research
Limited, a charity registered in England with number 1021457 and a
company registered in England with number 2742969, whose registered
office is Wellcome Sanger Institute, Wellcome Genome Campus,
Hinxton, CB10 1SA


[Feature request]  Android live photo support

Platforms
Android
Description
Android devices now also have live photo, such as Xiaomi. Is there any plan to support it in the future?
Why
No response

Could you try using https://github.com/ente-io/motion_photos?

It must be supported by Android API. If each manufacturer has its own live photo format, it will be difficult to support it.


Use framework and call register only when needed

@t-nonque please re-submit the PR without the changes to plugin.xml and the deletion of android-support-v13.jar. I can't merge those changes until PhoneGap Build supports building Android projects via Gradle. This is why PR #26 isn't merged.
I will merge the change to GCMRegistrar if you re-send the PR.

Hi,
This PR works and also fix these build errors http://cl.ly/image/350g1w2W0A1D & http://cl.ly/image/1I0y0j1v3Z05

@felquis Yes, I know but I can't merge it because the plugin will stop working on PhoneGap Build.

This should be applicable now, just need to rebase the commits so that only PushPlugin.java gets modified (because the framework thing has been fixed).

I'm moving to the new way of doing things for GCM so this PR won't be valid in the near future.
https://developers.google.com/instance-id/guides/android-implementation


⚠ Bofrost.be has degraded performance

In 3dcb5f7, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1518 ms

Resolved: Bofrost.be performance has improved in 128e281 after 8 minutes.


Feature/nav rail enhancements

Changes proposed in this Pull Request:

Add condensed rail documentation
Show what a word-break looks like on nav rail.
Show what a dash delimited break looks like on nav rail.
Update DrawerLayout example rail header to match rail example.

Screenshots:

didn't notice this before but the icons are not switching over when RTL

It was my bad before. For when to mirror what icon, see https://material.io/design/usability/bidirectionality.html#mirroring-layout

I've been noticing this strange ripple behavior that sometimes the ripple does not cover the entire box before it vanishes. The exact triggering condition is unknown.

What was the rationale behind making the menu item padding 14px 8px 16px instead of 15px 8px?

What was the rationale behind making the menu item padding 14px 8px 16px instead of 15px 8px?
Edit: the design says the horizontal padding should be 4px

I was following material design's specs for their nav rail found here: https://material.io/components/navigation-rail#specs

I've been noticing this strange ripple behavior that sometimes the ripple does not cover the entire box before it vanishes. The exact triggering condition is unknown.

I've noticed this too but couldn't figure out what was causing this strange half-fill effect.  Seeing that it's seemingly random, I was just going to ignore it.   Maybe we could put an issue for it?  I'm pretty sure the issue has something to do with our usage of the ripple instead of the mat-ripple itself.

I see. It looks like the aligning is different here. They are aligning up to the text's baseline, rather than where the text actually ends.

(which they often do in their docs... their docs can be full of mines)

I changed the padding to be 15px 8px; it looks fine to me.

Looking right.

wait can you make selected item font weight 600? Or does this go with other drawer updates?

wait can you make selected item font weight 600? Or does this go with other default drawer style updates?

I would save this for the general drawer styles story, since it's outside scope of the rail.

Sounds good! Looks nice to me otherwise

I've been noticing this strange ripple behavior that sometimes the ripple does not cover the entire box before it vanishes. The exact triggering condition is unknown.

It happens when you click on an item when something else is focused. Once your first click focuses the new item, clicking it again uses the full ripple, but if you click another one, that one will have the partial ripple. It might be by design, idk.

I've moved the nav rail header to the footer for each example.

Is there a directive to turn off the nav rail tooltip?

Is there a directive to turn off the nav rail tooltip?

No, whenever the condensed prop is active, the tooltip is currently not optional.  If this is something we want users to have toggle-able we can include it in the Drawer refactor story.


Many items are missing

Where are you getting your item data?
There's a lot of stuff missing from Brita's
Perhaps your data ingesting is not working correctly, does your backend read the game/mod json files directly?

A little more context, because I've run into this problem before.
A lot of the weapons that are colloquially known as Britas, are actually in the Arsenal 26 mod
Brita just defines the models for a lot of the weapons that are in that mod
Here is an example, does this fit your format?
module Base	{

	item	Carbon15_97	{

	DisplayName                 	=	Carbon-15 Type-97	,
	Icon                        	=	Carbon15_97,
	WeaponSprite                	=	Carbon15_97,
	Type                        	=	Weapon,
	SubCategory                 	=	Firearm,
	Ranged                      	=	TRUE,
	IsAimedFirearm              	=	TRUE,
	WeaponReloadType            	=	handgun,
	FireMode                    	=	Auto,
	FireModePossibilities       	=	Single/[3]Burst/Auto,
	AttachmentType              	=	Holster,
	UseEndurance                	=	FALSE,
	/* ============ PERFORMANCE DATA ============= */
	MinRange                    	=	0.61	,
	MaxRange                    	=	23.5	,
	AimingPerkRangeModifier     	=	2.35	,
	MinDamage                   	=	1.9	,
	MaxDamage                   	=	2.5	,
	CriticalChance              	=	25	,
	CritDmgMultiplier            	=	4,
	AimingPerkCritModifier      	=	10,
	HitChance                   	=	11	,
	ToHitModifier               	=	1.5,
	AimingPerkHitChanceModifier 	=	10	,
	MinAngle                     	=	0.923	,
	AimingPerkMinAngleModifier  	=	0.005	,
	ConditionMax                	=	60	,
	ConditionLowerChanceOneIn   	=	55	,
	MultipleHitConditionAffected	=	FALSE,
	JamGunChance                	=	0.08	,
	AimingTime                  	=	10	,
	ReloadTime                  	=	27,
	SwingTime                   	=	0.5	,
	MinimumSwingTime            	=	0.5	,
	SwingAmountBeforeImpact     	=	0,
	RecoilDelay                 	=	37	,
	Weight                      	=	1.9	,
	OAL				=	1.3	,
	/* ============= AMMUNITION DATA ============= */
	AmmoType                    	=	Base.556Bullets,
	AmmoBox                     	=	556Box,
	MaxAmmo                     	=	30,
	MagazineType                	=	Base.556Clip,
	ProjectileCount             	=	1,
	MaxHitCount                 	=	2,
	PiercingBullets             	=	TRUE,
	ShareDamage                 	=	FALSE,
	SplatSize                   	=	3,
	SplatNumber                 	=	3,
	SplatBloodOnNoDeath         	=	TRUE,
	PushBackMod                 	=	0.3,
	KnockBackOnNoDeath          	=	TRUE,
	KnockdownMod                	=	3,
	DoorDamage                  	=	12,
	/* ============ ANIMATION & SOUND ============ */
	RunAnim                     	=	Run_Weapon2,
	IdleAnim                    	=	Idle_Weapon2,
	SwingAnim                   	=	Rifle,
	MetalValue                  	=	45,
	SoundVolume                 	=	60,
	SoundRadius                 	=	60,
	SoundGain                   	=	1,
	NPCSoundBoost               	=	1.5,
	BringToBearSound		=	M16BringToBear,
	SwingSound      		=	M16Shoot,
	HitSound            		=	BulletHitBody,
	ClickSound         		=	M16Jam,
	BreakSound       		=	M16Break,
	EquipSound       		=	M16Equip,
	UnequipSound     		=	M16UnEquip,
	InsertAmmoSound  		=	M16InsertAmmo,
	EjectAmmoSound  		=	M16EjectAmmo,
	InsertAmmoStartSound		=	M16InsertAmmoStart,
	InsertAmmoStopSound		=	M16InsertAmmoStop,
	EjectAmmoStartSound		=	M16EjectAmmoStart,
	EjectAmmoStopSound		=	M16EjectAmmoStop,
	ShellFallSound    		=	M16CartridgeFall,
	RackSound        		=	M16Rack,
	Impact                 		=	null,
	/* =========== TRANSFORM VARIABLES =========== */
	DrumMagType	=	Base.556Drum,
	/* =========== ATTACHMENT DATA ============ */
	ModelWeaponPart = Launcher             		Launcher launcher launcher,
	ModelWeaponPart = Bipod               		Bipod bipod bipod	,
	ModelWeaponPart = ForeGrip           		ForeGrip foregrip foregrip	,
	ModelWeaponPart = Carrier_12g          		Carrier_12g carrier carrier	,
	ModelWeaponPart = AmmoBelt           		AmmoBelt sling sling	,
	ModelWeaponPart = Sling               		Sling_1 sling sling	,
	ModelWeaponPart = Light_Small			Light_Small  side  side		,
	ModelWeaponPart = Light_Large			Light_Large  side  side		,
	ModelWeaponPart = Laser_Green	  		Laser_Green  side  side		,
	ModelWeaponPart = Laser_Red	    		Laser_Red    side  side		,
	ModelWeaponPart = Suppressor_Pistol		Suppressor_Pistol suppressor suppressor	,
	ModelWeaponPart = Suppressor_Rifle		Suppressor_Rifle suppressor suppressor	,
	ModelWeaponPart = Suppressor_Oil		Suppressor_Oil suppressor suppressor	,
	ModelWeaponPart = Suppressor_Bottle		Suppressor_Bottle suppressor suppressor	,
	ModelWeaponPart = Suppressor_Shotgun		Suppressor_Shotgun 	suppressor suppressor	,
	ModelWeaponPart = Suppressor_BMG		Suppressor_BMG suppressor suppressor	,
	ModelWeaponPart = Bayonet_M4        		Bayonet_M4 bayonet bayonet	,
	ModelWeaponPart = Bayonet_AK        		Bayonet_AK bayonet bayonet	,
	ModelWeaponPart = Bayonet_M1917    		Bayonet_M1917 bayonet bayonet	,
	ModelWeaponPart = RecoilPad            		RecoilPad pad pad	,
	ModelWeaponPart = MuzzleBrake    		MuzzleBrake suppressor suppressor	,
	ModelWeaponPart = Compensator     		MuzzleBrake suppressor suppressor	,
	ModelWeaponPart = GhostRing            		GhostRing reddot reddot	,
	ModelWeaponPart = Sight_MicroDot 		Sight_MicroDot reddot reddot	,
	ModelWeaponPart = Sight_RaceDot 		Sight_RaceDot scope scope	,
	ModelWeaponPart = Sight_SRS       		Sight_SRS reddot reddot	,
	ModelWeaponPart = Sight_Aimpoint       		Sight_Aimpoint  reddot reddot	,
	ModelWeaponPart = Sight_Aimpoint_Dot     	Sight_Aimpoint_Dot  reddot reddot	,
	ModelWeaponPart = Sight_Fiber_Shotgun 		Sight_Fiber_Shotgun scope scope	,
	ModelWeaponPart = Sight_Mepro_M21      		Sight_Mepro_M21 reddot reddot	,
	ModelWeaponPart = Sight_Mepro_MOR      		Sight_Mepro_MOR reddot reddot	,
	ModelWeaponPart = Sight_UH1      		Sight_UH1 reddot reddot	,
	ModelWeaponPart = Sight_C79			Sight_C79 scope scope	,
	ModelWeaponPart = Sight_SUSAT			Sight_SUSAT scope scope	,
	ModelWeaponPart = Sight_Raven			Sight_Raven scope scope	,
	ModelWeaponPart = Sight_G28_Scope		Sight_G28_Scope scope scope	,
	ModelWeaponPart = Sight_EOTech      		Sight_EOTech reddot reddot	,
	ModelWeaponPart = Sight_3xEOTech		Sight_3xEOTech scope scope	,
	ModelWeaponPart = Sight_4xACOG    		Sight_4xACOG scope scope	,
	ModelWeaponPart = Sight_6xELCAN  		Sight_6xELCAN scope scope	,
	ModelWeaponPart = Scope_1-4x         		Scope_1-4x scope scope	,
	ModelWeaponPart = Scope_20x           		Scope_20x scope scope	,
	ModelWeaponPart = Sight_KOBRA        		Sight_KOBRA scope2 scope2	,
	ModelWeaponPart = Scope_4xPSO            	Scope_4xPSO scope2 scope2	,
	ModelWeaponPart = Scope_12xPSO    		Scope_12xPSO scope2 scope2	,
	ModelWeaponPart = Sight_Thermal   		Sight_Thermal scope scope	,
	ModelWeaponPart = Sight_Thermal_AK   		Sight_Thermal_AK scope2 scope2	,
	ModelWeaponPart = Sight_ACRO      		Sight_ACRO reddot reddot	,
	ModelWeaponPart = Sight_MRO      		Sight_MRO reddot reddot	,
	ModelWeaponPart = Sight_SRO      		Sight_SRO reddot reddot	,
	ModelWeaponPart = Sight_Nikon      		Sight_Nikon reddot reddot	,
	ModelWeaponPart = Sight_M8      		Sight_M8 scope scope	,
	ModelWeaponPart = Sight_VX3      		Sight_VX3 scope scope	,
	ModelWeaponPart = Sight_1P63        		Sight_1P63 scope2 scope2	,
	ModelWeaponPart = Sight_Brownells      		Sight_Brownells scope scope	,
	ModelWeaponPart = Sight_L2      		Sight_L2 scope scope	,
	ModelWeaponPart = Sight_LUX      		Sight_LUX scope scope	,
	ModelWeaponPart = Sight_Malcom      		Sight_Malcom scope scope	,
	ModelWeaponPart = Sight_NO32      		Sight_NO32 scope2 scope2	,
	ModelWeaponPart = Sight_PKAS      		Sight_PKAS scope scope	,
	ModelWeaponPart = Sight_PU        		Sight_PU scope2 scope2	,
	ModelWeaponPart = Sight_PVS4      		Sight_PVS4 scope scope	,
	ModelWeaponPart = Sight_XPS      		Sight_XPS reddot reddot	,
	ModelWeaponPart = Laser_DVAL	    		Laser_DVAL    side  side		,
	ModelWeaponPart = Laser_PEQ15	    		Laser_PEQ15    side  side		,
	ModelWeaponPart = Grip_Magpul          		Grip_Magpul foregrip foregrip	,
	ModelWeaponPart = Grip_MLOK           		Grip_MLOK foregrip foregrip	,
	ModelWeaponPart = Grip_TG           		Grip_TG foregrip foregrip	,
	ModelWeaponPart = Standard_Mag  		Standard_Mag_Type97 mag mag	,
	ModelWeaponPart = Extended_Mag  		Extended_Mag mag mag		,
	ModelWeaponPart = Drum_Mag          		Drum_Mag_556 mag mag		,
	}

	model Carbon15_97
	{
		mesh = weapons/firearm/Carbon15_97,
		texture = weapons/firearm/Carbon15_97,

		attachment light
		{
			offset = 0.0000 0.1409 -0.0336,
			rotate = 0.0000 180.0000 0.0000,
		}
		attachment side
		{
			offset = 0.0000 0.1409 -0.0336,
			rotate = 0.0000 180.0000 0.0000,
		}
		attachment suppressor
		{
			offset = 0.0000 0.2198 -0.0318,
			rotate = 0.0000 0.0000 0.0000,
		}
		attachment muzzle
		{
			offset = 0.0000 0.2782 -0.0318,
			rotate = -90.0000 0.0000 0.0000,
		}
		attachment reddot
		{
			offset = 0.0000 0.0605 -0.0158,
			rotate = 0.0000 180.0000 0.0000,
		}
		attachment scope
		{
			offset = 0.0000 0.0605 -0.0158,
			rotate = 0.0000 180.0000 0.0000,
		}
		attachment scope2
		{
			offset = 0.0000 0.0191 -0.0167,
			rotate = 0.0000 180.0000 0.0000,
		}
		attachment mag
		{
			offset = 0.0000 0.0000 0.0000,
			rotate = 0.0000 0.0000 0.0000,
		}
		attachment drum
		{
			offset = 0.0000 0.0110 -0.0067,
			rotate = 0.0000 180.0000 0.0000,
		}
	}

	fixing Fix Carbon15_97
	{
		Require : Carbon15_97,
		Fixer : Cleaning=1,
		Fixer : WD=1,
	}
}


Barrow Wights and Barrows

The Spooky Lowlands Barrows biome needs to have barrows and barrow wights (such as those in the lord of the rings). Perhaps you can sometimes find treasure in said barrows.

Also should have a mini boss called the “Wight Lord” or “Wight King”

Barrows, which have now been added, should generate loot chests and wight spawners in the hollow areas.

Still waiting on wights themselves to be made so this can be resolved


Bad detection of DataMatrix

I know this project is in maintenance mode. However I found that the detection rate of QR codes is fairly robust but detecting DataMatrix codes is almost impossible.
Anyone know the reason for this? Has the Java part a better detector?

The detector is made for when the code is dead center and fairly large in view. You could try making your own pre-localisation.

In case that is still relevant: I had the same issue and found the c++ port from @huycn (https://github.com/nu-book/zxing-cpp. It is a completely new port based on the current Java code with the goal of having an idiomatic c++ library instead of a 1:1 mapping of Java classes.
That said, the DMDetector had the same limitations: it only works with sufficient resolution and an unrealistic requirement on the amount of whitespace surrounding the code and the orientation of the code. I reimplemented the detector from scratch and now it can detect all the samples from the test directory and more challenging examples like https://www.deutsche-apotheker-zeitung.de/_Resources/Persistent/55c53726b5bbcc918ec7800229cf2e9d27794c21/k4_931_258080_258181-800x343-660x283-482x271.jpg
I'd be happy to get feedback.

You implementation can be tested where?

If you have a Linux/macOS machine, you can use the test runner project https://github.com/nu-book/zxing-cpp/tree/master/test/runners/generic to build a binary that can be called with an image path and it will try to decode that. You'll need the imagemagic convert tool in the path for internal jpg/png->pgm conversion.


310 fallback service provider

Pull request description

PR meta checklist

[x] Pull request is targeting at DEV branch.
[x] Pull request is linked to all related issues, if any.
[x] I have read the CONTRIBUTING.md document.

Content checklist

[x] My code follows the code style of this project and AspNetCore coding guidelines.
[x] My change requires a change to the documentation.

[x] I have updated the documentation accordingly.

[x] I have updated the appropriate sub section in the CHANGELOG.md.
[x] I have added, updated or removed tests to according to my changes.

[x] All tests passed.

#315

Looks good so far. There are still a few test cases missing, as far as I can see. These are a few suggestions from the related issue:

when no fall back is added, the base service provider is used
when a fallback provider is added, the result from service provider is used when it is not null
when a fallback provider is added, it is called when the service provider returns null
if multipel fallbacks are added, only the latest is used
adding null as fallback throws argument null exception

Your right, thanks for the feedback, ill add them tonight / this weekend.

@egil I processed all you feedback but now one of the test fails.
The test contained this description:
// In some cases, the original assert wont work, since the sync context might not be idle,
/ which results in this order: First Third Second Fourth Fifth
Is this something i should look at?

@egil I processed all you feedback but now one of the test fails.
The test contained this description:
// In some cases, the original assert wont work, since the sync context might not be idle,
/ which results in this order: First Third Second Fourth Fifth
Is this something i should look at?

No, that is a race condition bug i am having a hard time reproducing locally, and have so far only seen here when running with GitHub actions. It is unrelated to this.

@egil I processed all you feedback but now one of the test fails.
The test contained this description:
// In some cases, the original assert wont work, since the sync context might not be idle,
/ which results in this order: First Third Second Fourth Fifth
Is this something i should look at?

No, that is a race condition bug i am having a hard time reproducing locally, and have so far only seen here when running with GitHub actions. It is unrelated to this

Then i think i got every thing done except for the changelog. Or is their anything else you would like to see improved?

Hey @ventigrande,
Do you mind taking a look at the updated doc page in this PR. Here is a link with just the .md files visible in the Files Changed tab.

Everything looks good to me. Ill give wait with the merge until @ventigrande has had a chance to review the doc changes. Thanks for your contribution @thopdev!

@egil Sounds good. Thanks for all the help and feedback.

@ventigrande Thanks for the feedback.

Thank you @ventigrande.
One last thing @thopdev was needed. I updated the changelog file, let me know what you think.

Thank you @ventigrande.
One last thing @thopdev was needed. I updated the changelog file, let me know what you think.

Sounds good!

@egil @thopdev I am new to bUnit but not to AutoFixture and XUnit. I could you please help me understand how to use/implement a FallbackServiceProvider using AutoFixture and Moq? I can't even seem to get the code from this Discussion to work. But maybe this code isn't needed now that you have allowed for a FallbackServiceProvider.
Any guidance would be greatly appreciated.
Thanks!!

Hi @mwasson74 The service provider looks correct. Could you share one test class that shows bunit.

Thanks for getting back to me, @thopdev! Below, you'll find our test class with 1 bUnit test. It is working but I'll likely create an extension method to retrieve the Mock instead of doing Mock.Get(). But ideally, I could just have that mock instance given to me as a test method parameter like you did in your #307...
public class ClientSearchTests : TestContext
{
  private readonly IFixture _fixture;

  public ClientSearchTests()
  {
    _fixture = new Fixture();
    _fixture.Customize(new AutoMoqCustomization { ConfigureMembers = true });
    JSInterop.Mode = JSRuntimeMode.Loose;
    Services.AddMudServices();
    Services.AddFallbackServiceProvider(new AutoFixtureServiceProvider(_fixture));
  }

  [Theory, AutoMoqData]
  public void MyLittleTest(string clientCode)
  {
    //Actors
    var cut = RenderComponent<ClientSearch>(parameters =>
      parameters.Add(p => p.SearchCriteria, clientCode));
    var mockClient = Mock.Get(Services.GetService<IClientManagementClient>()!);

    //Acts
    cut.Find("button").Click();

    //Asserts
    mockClient?.Verify(x => x.GetClient, Times.Once);
  }
}


Fix crash due to bad rounding in BarChart when no y_step was provided and the max y value was close to 0

Overview: What does this pull request change?
This PR fixes a bug in BarChart that lead to a crash if the user did not provide the y_step (i.e. tick rate, the user provided y_range=[y_min, y_max]) and the y values were very close to 0 (round(max(ys), 2) == 0).
Motivation and Explanation: Why and how do your changes improve the library?
When the user only provided the minimum and maximum of the y_range, the code for BarChart was deducing the tick rate for the y axis using the following code:
round(max(self.values) / y_length, 2)

However, this returns 0 if the maximum is small, because it is rounded down to zero. This lead to a division by zero in a np.arrange downstream. This issue can be fixed by replacing the 2 by a computed value.
This PR replaces the hard-coded 2 with $\max\left(\lceil - \log_{10}(x) \rceil, ~ 2\right)$, with $x$ being equal to max(self.values) / y_length (unrounded y_step in the original code). To ensure retro-compatibility, the newly computed value can't go below 2, in the case of large y values.

Reviewer Checklist

[x] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[x] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[x] If applicable: newly added functions and classes are tested

Hey thanks for the PR! Do you mind adding a (non-graphical) test for this?

Hello and thank you for the reply. I added one simple test and checked to make sure it was failing before this PR, but don't throw errors after this PR.
If it's not enough, I could add more tests.

I think it looks fine from my cursory testing :)
Could you please just fix the pre-commit linting errors, and then explain where you got your formula from (preferably as a comment in the code)?

I added comments and fixed the linting. Do you think the explanations are clear enough? I can expand them if needed.

I may have broken something with my last commits, because I recently made an animation with very low values that worked perfectly from 6 bars of values 1/10000th to 1.
I think forcing the y_step could be a good solution too. In fact I did that at first, then thought that the code I used may be useful as it fixed the problem and provided smooth transitions when animating.

Could you share some non-working examples, please? I could also try to understand what's going wrong and fix it.

from manim import *

class BarChartExample(Scene):
    def construct(self):
        values = [1 / 10000 for _ in range(8)]
        chart = BarChart(
            values=values,
            bar_names=["one", "two", "three", "four", "five"],
            y_range=[0, 2 / 10000],
            y_length=6,
            x_length=10,
            x_axis_config={"font_size": 36},
        )

        c_bar_lbls = chart.get_bar_labels(font_size=48)

        self.add(chart, c_bar_lbls)

config.preview = True
BarChartExample().render()

Is what I tried, which results in


Refactor onNothingThrow

Rename onNothingThrow to onNothingThrowA, which reads better.
The A suffix is the English work "a" as in onNothingThrowA Banana reads as "on nothing, throw a banana".
Lift the type of onNothingThrowA to into ExceptT.  Add onNothing, onLeft and onLeftThrowIt functions.
onNothingThrowA has this type signature:
onNothingThrowA :: Monad m => e -> Maybe a -> ExceptT e m a

And it was used like this:
f :: Maybe a

r <- f
    & onNothingThrowA ErrorValue

It bothered me that I would have to have another version to accomodate this case:
g :: ExceptT ErrorType IO (Maybe a)

onNothingThrowAM :: Monad m => e -> ExceptT e (Maybe a) -> ExceptT e m a

r <- g
    & onNothingThrowAM ErrorValue

Then I realised that any pure expression can be lifted so if I delete onNothingThrowA and renamed onNothingThrowAM to onNothingThrowA, I can use the new lifted function by adding pure
f :: Maybe a

r <- pure f
    & onNothingThrowA ErrorValue

This means I don't have to have a pure version and a ExceptT version for every possible function.  I can just have the ExceptT version and lift into it.

Relevant comment https://github.com/input-output-hk/cardano-node/pull/4666#discussion_r1073948828

I was worried about stackability, but maybe it works as long as the first one is >>=?
g :: ExceptT ErrorType IO (Maybe a)

r <- g
    >>= onNothingThrowA ErrorValue
    & handleE (\e -> throw Wrapper e)

I chose A because it was short, but I could keep it as onNothingThrow and just change the type signature.


x/website: go.dev/cl redirector does not work for CL 80780043

According to https://github.com/golang/go/commit/881d693c8603510bee3b88205a90ca97942ee0b9 that change was reviewed on https://golang.org/cl/80780043.  However, neither that link nor https://go.dev/cl/80780043 resolves to the actual change.  I'm unable to find the change on codereview.appspot.com, although other changes around that one do still exist.
The conversation remains at https://groups.google.com/g/golang-codereviews/c/6waUN-WcrRM/m/rn7OsN-pShEJ .
Not sure what happened here.

cc @golang/tools-team

The redirector is working as expected, it appears the target is missing the change.

/cc @rsc who might have more context on https://codereview.appspot.com.

From internal discussion

Looking at the Datastore viewer that record seems to just be gone. It is possible that the CL author used Edit Issue > Delete.

@rsc started a process to copy the remaining data to prevent this type of loss in the future. Thanks!


Ubuntu now supports AWS native integration as part of the install

Updates AWS documentation to include reference to conjure-up.
As a side note - should deprecated install instructions be removed?

Removed outdated instruction block

This change is

@marcoceppi 👋

should deprecated install instructions be removed?
Yes, please.

I've removed those instructions, thanks @zacharysarah :wave:

@marcoceppi Thanks! LGTM :shipit:


api: Update doc link for request codes.

I'm not sure if this is the right link, but the current link is broken as seen on https://docs.rs/v4l/latest/v4l/v4l2/api/fn.ioctl.html

Theoretically the CI should run a RUSTDOCFLAGS=-Dwarnings cargo doc --no-deps --workspace --document-private-items step to catch all broken links.

I'm not sure if this is the right link

Notice that the v4l module isn't in scope, so this new link is wrong too:
error: unresolved link to `v4l::ioctl::codes`
   --> src/v4l2/api.rs:156:14
    |
156 | /// [codes]: v4l::ioctl::codes
    |              ^^^^^^^^^^^^^^^^^ no item named `v4l` in scope

The right link is straight to the [`vidioc`] module. There are many more violations so I fixed them all in #49 and added a job to the CI to disallow broken docs (and links) in the future :)

Wow, that's a much better cleanup.  Thanks! And sorry for creating more work for you.

@wathiede No worries, I just have an itch for cleaning up random repositories (there's a lot to do here, all the clippy lints, oh my!) and educating others on the topic! I hope I've been able to teach you how to build-test documentation for the next broken link that you encounter :grin:

Thank you for your efforts! Is this patch obsoleted by the now-merged other PR: https://github.com/raymanfx/libv4l-rs/pull/49? In that case, feel free to close this one.


Add Windows support

Describe the Feature
I'm getting started working on the Windows implementation of the Slider component.
Should push a PR within 2 weeks.
Creating this issue to let the maintainers know of this effort.
Please, assign this one to me, in case I cannot self-assign.
Related Issues
Closes microsoft/react-native-windows#4612

Hello,
Thanks for letting me know, good luck with implementation!

@sharcoux/slider should work just fine with Windows.
Can you try and report?

The Slider implementation recommended by Facebook is this one. Microsoft's effort to increase RN adoption on Windows also relies on the performance provided by native code, hence this choice.

Looking forward to this!
Implementation looks to be in PR and ready to merge soon I hope.

@rectified95  Thank you!


Run SonarCloud on pull request to master only

Run SonarCloud less often to reduce build times for normal CI builds.

done


[Bug fix with an enhancement] Standardize "Shop Now" Button Behavior and Link Products to Shops

I've noticed a few inconsistencies with the "Shop Now" button behavior, "Products" button behavior and how products are linked with shops:
Current Behavior:

The "Shop Now" button on category cards on the home page redirects to the products page for that category whereas the "Shop Now" button on the category page redirects to the shops page related to that category.
When clicking the "Products" button on the shops page, it currently displays products related to the category instead of products from that specific shop.

Proposed Changes:
Link Products with Shops: [Enhancement]

I will add a shop property to each product so they can be associated with a specific shop.
Display the shop name alongside other details in the product card for better clarity.

Standardize "Shop Now" Button Behavior: [Bug Fix]

Ensure that the "Shop Now" button on both the home page and category page behaves consistently.
Both buttons should either take users to the category products page (Let me know if the buttons have to take the user to display relevant shops instead of products).

Fix Products Display in Shops Page: [Enhancement]

Update the "Products" button on the shops page to display products from the selected shop rather than the entire category-based products.

Screenshots:
Products (with no shop name)

I would like to work on this issue, please assign this to me.

[x] I have read the Contributing Guidelines
[x] I'm a GSSOC'24-Extd contributor
[x] I'm a Hacktoberfest contributor
[x] I have starred the repository
[x] I am willing to work on this issue (optional)

@kavya410004 Issue acknowledged! You are going to be assigned.

Hey @kavya410004 can you do one more thing;

You created the main feature for the product page, so when any user clicks on the page to be redirected, an alert message should appear saying "please login first." Once the user logs in, they can be redirected to the product or shop page. Please let me know if you're interested in working on this.

@mdazfar2 Let me rephrase it.
If a user hasn't logged in and tries to visit products page or shops page, an alert should appear saying "please login first". If the user has already logged in, only then the user would be redirected to products or shops page.  Is this right?

Yep, @kavya410004, here I will send you the demo video of the alert message, how it appears and removes itself automatically in about 2-3 seconds:
https://github.com/user-attachments/assets/0c459506-21dc-4dd1-ab87-c7ab674f1779

Okay @mdazfar2, I can work on this issue.
In the video the alert message was displayed without redirecting the user to login/ signup page. Is displaying the message alone is enough or is redirection to login page also required?

@kavya410004 When we redirect to the login/signup page, this functionality makes the user irritated, so we can add only the alert message without redirecting to the login page.

@mdazfar2 , I have raised the issue here #225 .
I will be working on issue #222 first and move on to the next issue #255
Thank you.

Hey @mdazfar2 ! Just noticed my PR got merged yesterday, but the issue is still open. Did you miss closing it? Thanks!

Thanks for letting me know @kavya410004


XTDB CTS failures (3.14)

The current xtdb connector in main (3.13-SNAPSHOT b885e7f6024dc67f7d638cfcda4f94f21c114704 ) is failing some retype test cases in CTS (3.14, release 31bac9c63582a9da50cd82d74d36828debed3c4a )
3.13 / PASS -> https://github.com/planetf1/cts/actions/runs/3731435406
3.14 / FAIL ->   https://github.com/planetf1/cts/actions/runs/3730203800
The failing test profiles are:
Metadata sharing
Reference copies
Metadata maintenance

The only change I see to the CTS is https://github.com/odpi/egeria/commit/0baee7c3b69cdc4ccafd700cbaf72fb774ae08eb#diff-e204add70705500d0979d0c68c76846f5cb30d8ce4943bb24324a5f1276c117d
Also this may be expected, since the next release of the xtdb connector is still being developed.

dup. (github/network issue)

Another run shows failures again, so intermittent - possibly a test driver issue, so won't reopen here yet, but for info ... https://github.com/planetf1/cts/actions/runs/3751230156


Have GetSubtreeAsLeaf() return a pointer instead of a reference.

This way, if the subtree is nullptr, we don't check-fail right there,
but give the caller a chance to recover.
Use this to fix the kythe facts extractor that crashed before on
encountering .* module instance ports.
The DIE_IF_NULL is not eliminated all the way, in some cases it was pushed one level up to avoid having this change much larger (to be addressed in follow-up changes).

CC @ivan444

Codecov Report

Merging #1125 (4ff62ad) into master (9f0278e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   92.86%   92.87%   +0.01%
==========================================
  Files         337      337
  Lines       22471    22490      +19
==========================================
+ Hits        20867    20888      +21
+ Misses       1604     1602       -2

Impacted Files
Coverage Δ

verilog/CST/module.h
100.00% <ø> (ø)

verilog/CST/port.h
100.00% <ø> (ø)

verilog/CST/type.h
100.00% <ø> (ø)

common/text/tree_utils.h
100.00% <100.00%> (+3.33%)
:arrow_up:

verilog/CST/class.cc
100.00% <100.00%> (ø)

verilog/CST/declaration.cc
100.00% <100.00%> (ø)

verilog/CST/macro.cc
100.00% <100.00%> (ø)

verilog/CST/module.cc
100.00% <100.00%> (ø)

verilog/CST/net.cc
100.00% <100.00%> (ø)

verilog/CST/package.cc
100.00% <100.00%> (ø)

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0278e...4ff62ad. Read the comment docs.

This should fix the GetSubTreeAsSymbol() check failures we see in the Verible Kythe extractor.

(Also adding Rafal, in case David is already on holiday vacation)

Yes, ran tests in asan mode (The CI also has it as one of its runs)


"go tool cover -func=cover.out" reports wrong percentage value on Windows?

What version of Go are you using (go version)?

$ go version  # inside GitHub Actions CI
go version go1.15.4 windows/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
  set GO111MODULE=
  set GOARCH=amd64
  set GOBIN=
  set GOCACHE=C:\Users\runneradmin\AppData\Local\go-build
  set GOENV=C:\Users\runneradmin\AppData\Roaming\go\env
  set GOEXE=.exe
  set GOFLAGS=
  set GOHOSTARCH=amd64
  set GOHOSTOS=windows
  set GOINSECURE=
  set GOMODCACHE=C:\Users\runneradmin\go\pkg\mod
  set GONOPROXY=
  set GONOSUMDB=
  set GOOS=windows
  set GOPATH=C:\Users\runneradmin\go
  set GOPRIVATE=
  set GOPROXY=https://proxy.golang.org,direct
  set GOROOT=C:\hostedtoolcache\windows\go\1.15.4\x64
  set GOSUMDB=sum.golang.org
  set GOTMPDIR=
  set GOTOOLDIR=C:\hostedtoolcache\windows\go\1.15.4\x64\pkg\tool\windows_amd64
  set GCCGO=gccgo
  set AR=ar
  set CC=gcc
  set CXX=g++
  set CGO_ENABLED=1
  set GOMOD=D:\a\go-wait-for-it\go-wait-for-it\go.mod
  set CGO_CFLAGS=-g -O2
  set CGO_CPPFLAGS=
  set CGO_CXXFLAGS=-g -O2
  set CGO_FFLAGS=-g -O2
  set CGO_LDFLAGS=-g -O2
  set PKG_CONFIG=pkg-config
  set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\RUNNER~1\AppData\Local\Temp\go-build677325866=/tmp/go-build -gno-record-gcc-switches

What did you do?
This is my first ever bug report to the Go community. Please bare with me if anything in here is not optimal, yet. Thank you! :pray:
I have publicly available code that is not platform specific and has 100.0% code coverage when run on Linux or macOS. Now I added Windows to the CI mix, and one function (waitForAddress) seems to be mis-reported as 91.7% by go tool cover -func=cover.out on Windows only, for no apparent reason. In detail (this is Bash on Windows in this very GitHub Actions CI):
$ git clone --branch make-ci-cover-windows https://github.com/hartwork/go-wait-for-it
$ go-wait-for-it
$ go build .
$ go test -v -coverprofile=cover.out ./...
$ go tool cover -func=cover.out
[..]
github.com/hartwork/go-wait-for-it/internal/network/wait.go:22:		waitForAddress				91.7%
[..]

What did you expect to see?
I expect the coverage to be 100.0% just like on macOS and Linux, because

there is nothing platform specific here
I have compare the output of diff -u internal/network/wait.go <(go tool cover -mode=set internal/network/wait.go)
across all three platforms (and that very output is included in the CI log): all three are identical.

So I'm suspecting a Windows-specific bug in go tool cover here. What do you think?
What did you see instead?
A misreport of 91.7% for function waitForAddress on Windows, only. Linux und macOS show 100.0%.

In wait.go you have:
func waitForAddress(address syntax.Address) <-chan bool {
	available := make(chan bool, 1)
	go func() {
		for {
			c, err := net.Dial("tcp", address.String())
			if err == nil {
				available <- true
				c.Close()
				break
			}
			time.Sleep(500 * time.Millisecond)
		}
	}()
	return available
}

Depending on how you set up the test and on timing, net.Dial() may succeed the first time and never hit the time.Sleep() line. Check out the html output and you'll see what happens.
I wouldn't worry too much about 100% test coverage. Depending on how you are using the function in question, I'd perhaps worry a bit more about the unstoppable go routine it spawns. For example, if you give it an unreachable address, the go routine will continue to dial it forever, with no way to stop it.

Hi @antong, thanks for your reply!
The output from go tool cover -mode=set internal/network/wait.go shows that the line with time.Sleep was already hit on Windows and the tool's output is identical across platforms. :thinking:
On the other hand, I just added another test spinning the loop for 3 seconds and that brought coverage up to 100% on Windows.  These two findings contract themselves, any ideas what is going on? :thinking:
PS: waitForAddress is intended to loop forever and be used with an external timeout.  I'll rename the function to waitForAddressForever to make that more clear in a second.  Getting to 100% coverage was intended because I wanted to see what it would take to get there (e.g. compared to Python).

I think go tool cover -mode=set just rewrites the source code to make it possible to produce the cover profile. go test -cover uses that internally to produce the actual coverage report. So the source code would be identical between runs and between different platforms, but if there are nondeterministic things like the timing in your test, then the coverage report itself can be different between platforms and between run. Don't look at the -mode=set output, but on the coverage profile that go test produces (go test -coverprofile=c.out). Do check the html output. It is really cool!

You're right, here is proof based on new CI output:
--- /tmp/linux.txt       2020-11-08 23:42:51.919840484 +0100
+++ /tmp/windows.txt      2020-11-08 23:42:52.860847559 +0100
@@ -23,7 +23,7 @@
 github.com/hartwork/go-wait-for-it/internal/network/wait.go:24.12,25.7 1 1
 github.com/hartwork/go-wait-for-it/internal/network/wait.go:25.7,27.18 2 1
 github.com/hartwork/go-wait-for-it/internal/network/wait.go:27.18,30.10 3 1
-github.com/hartwork/go-wait-for-it/internal/network/wait.go:32.4,32.38 1 1
+github.com/hartwork/go-wait-for-it/internal/network/wait.go:32.4,32.38 1 0
 github.com/hartwork/go-wait-for-it/internal/network/wait.go:35.2,35.18 1 1
 github.com/hartwork/go-wait-for-it/internal/network/wait.go:38.130,42.17 3 1
 github.com/hartwork/go-wait-for-it/internal/network/wait.go:42.17,44.3 1 1

So I was using the tool wrong. Thanks for your help :pray: , I'll close the issues as invalid then.

@hartwork , glad I could help and happy that you got it working!


Use standard StorageClass for MySQL pvc.

This defers to the system default storage class when provisioning the PV
for result storage. This should avoid any environment specific issues
around the use of hostPath.
Manually tested this works on a fresh deploy to GKE.
Fixes #65

/lgtm

/lgtm


Assertion failed in superposition.ml

Hello
Sorry to disturb you again.
I'm on master now and I try to run the following zf file:
# Integers

data nat := Zero | Succ nat.

val One : nat.

assert One = Succ Zero.

# Lists

data list a := nil | cons a (list a).

val length : pi a. list a -> nat.

assert length nil = Zero.

assert forall l x.
	length (cons x l) = Succ (length l).

val rankedTerm : pi a. (list a) -> nat -> a.

assert forall l x.
	rankedTerm (cons x l) Zero = x.

assert forall l x n.
	rankedTerm (cons x l) (Succ n) = rankedTerm l n.

# F2

val isInF2 : nat -> prop.

rewrite forall x.
	isInF2 x <=> (x = Zero || x = One).

I get File "src/prover_calculi/superposition.ml", line 2211, characters 13-19: Assertion failed
It seems that it works when I remove either of:

the definition of length
the definition of rankedTerm
the definition of isInF2

KR
Marc

I can reproduce that, but I really don't have time to look more into it right now, sorry.

@petarvukmirovic has fixed this bug on the bool_calculi branch. So maybe you could try that branch instead? I guess it will still take a while until it gets merged into master.

It works with the branch you told. Thanks.


@media block gives syntax error

@media (min-width: 1220px) {
  div { width:auto; }
}

gives an "Syntax error in CSS: Identifier expected. Got “}” [line no: 3]"
This looks like a regression in version 8.4.0 - I'm suspecting https://github.com/sabberworm/PHP-CSS-Parser/pull/162

I can confirm the issue. We also had errors in @keyframe rules.

Is there any progress with this? I tried to upgrade from 8.3.0 to latest code from composer which claims to be be "8.4.0" even though no such version has been released yet in GitHub. That version fails to parse even simple media queries like
@media print
{
	html
	{
		background: white;
		color: black;
	}
}

so I have to revert back to 8.3.0 and apply PHP 8 compatibility fixes manually.

This issue still seems to be present in version 8.5.0 so unfortunately we still can't update to the latest version.
However it is good to see that this library gets some much needed maintenance and care. As far as I know it is the only PHP-based CSS parser/validator available. Keep up the good work, it is highly appreciated!

I can only reproduce this with strict parsing (Settings::beStrict()).
I think the mistake is in https://github.com/MyIntervals/PHP-CSS-Parser/pull/162/commits/134f4e62fe8ab9f316425f3c0f480b3f4f52d804 with the change to CSSList.php.
The logic has not been correctly preserverd.  When a } is encountered and bIsRoot is false, it should not fail, but merely return null to indicate the end of the list.  But now it's throwing an exception if strict parsing is set.
This was picked up by turning on strict parsing in the tests.  So maybe we should be running the tests with strict parsing set (actually I think both flavours).
@sabberworm, does my analysis make sense?

@sabberworm, does my analysis make sense?

It seems that this bit of code should not have been changed at all for #162.  After refactoring, it has the same logic as before, so I we may as well change it back, with an additional comment about what returning null means.

Having the same issue here. The rule it's failing on for us is:
@media only screen and (max-width: 768px) {
.body-signin .content {
margin-top: 120px;
}
}
Should I just hang-tight and do a composer update in the next couple of days?

Should I just hang-tight and do a composer update in the next couple of days?

I think we are planning to make an 8.5.1 release with this fix soon.
The other option you have is to not use strict parsing.  In future major releases we plan to deprecate this and replace it with a logging option.

I think we are planning to make an 8.5.1 release with this fix soon.
The other option you have is to not use strict parsing. In future major releases we plan to deprecate this and replace it with a logging option.

Thanks for the info. Really appreciate the transparency and the utility of the project. Thanks for the hard work.

I've just tagged V8.5.1 and published the release: https://github.com/MyIntervals/PHP-CSS-Parser/releases/tag/v8.5.1


Warn or error for long socket directory paths

When trying to run HSDS in the nodocker mode, socket directory paths above certain number of characters can break low-level socket communication code. I encountered this problem when setting up nodocker HSDS in a pytest fixture on a macOS computer. Temporary directories on macOS have long paths and prevent communication with HSDS if used as socket directories.
Two reported errors are: AF_UNIX path too long or UnicodeError: encoding with 'idna' codec failed (UnicodeError: label empty or too long). For the first error, the limit seems to be somewhere around 104-108 characters, while for the second 64 characters.
I suggest that HSDS when started in nodocker mode warns or raises an exception if socket directory path is longer than 64 characters.

I've put in a check here: https://github.com/HDFGroup/hsds/commit/f7d8f0cccf3379b50a0299f8bb48b84debff0808.
It's unfortunate that tempfile package on MacOS returns such long directory names.  Currently when a socket_dir is not specified hsds_app is using /tmp/hs1234abcd/ as the directory name where "1234abcd" is a random hex string.

It is funny there are still these limits from ye olde days of computing. 😁
Thanks!

Yes, something to do with max hostname length - see https://bugs.python.org/issue32958.  Why this should matter when you are using sockets, I don't know.


Automated cherry pick of #10161

Cherry pick of #10161 on release-6.6.
/cc  @hmhealey
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: d1a2c598e67cc926d116e3530a3198fcc11ec76d


Support item instances with identity

Currently, the system manages items by class. Sets of identityless items exist in storage locations.
Some items have a meaningful identity, like a serial number. The system currently has no way to state something along the lines of "an item with serial number X exists in location Y".

The system would need to take into account that it makes no sense to talk about the identity of an item until that item is actually present in a storage location... I can't say "I have an item with serial number X but it isn't physically present anywhere".

The current situation is this: The item_locations table asserts that there are c instances of item i in location L. It's essentially an array of:
data ItemLocation = IL Item Count Location

There is an additional constraint that the combination of item and location must be unique.
Instead, it should be an array of this:
data ItemLocation =
  | ILSet Item Count Location
  | ILOne Item Location Serial

The ILSet constructor asserts that there are c items of type i at location L, but there is no longer a uniqueness requirement over (i, L). The ILOne constructor asserts that there is an item i at location L with serial number S.
This is fairly simple to slot into the existing model.

Done.


Autoloading plugins

Hi
The server loads all plugins in the plugins folder, wouldn't it make sense to only load those specified in the config file?
When you start release consumer level software you'd want to include all plugins available, why load them if they aren't needed?

I take it some are supposed to be autoloading, but it appears it's loading everything.

It's loading all of them that aren't marked manualload (which is an option when you're creating a plugin), however they don't really have a runtime cost just to be loaded so manualload is not recommended. This is because most of them register an auto-detection routine, so the actual driver code in there is started up only if the corresponding piece of hardware is detected. Those that don't autodetect are registering a name so that they can be manually instantiated from the config file with parameters.

I'm looking at it from an end user point of view, I'm worried that at some stage there could be a problematic plugin causing problems and the only way to disable it would then be to move/del/ren the dll(not ideal). Your explanation makes good sense why it doesn't matter from a systems point of view though, however is it possible to at least include the ability to disable autoloading plugins via config then instead?(disabled:"com_osrvr_xxxxxx") I'm looking at a config utility that builds on the "user settings" app here, and I'm thinking perhaps we should have a server section where we can give the user the ability to turn off plugins.
Ps. On my machine osvr runs at 100% cpu core utilisation.

Ah, that's a good idea, to have a user-configurable plugin blacklist. I'm changing the issue title accordingly.

(and the CPU utilization: that's to reduce latency, it will yield time if it needs to. If you want to reduce usage, you can edit the "sleep" parameter in the config file to be 1, at the cost of latency.)

I thought it might be by design, other that pushing the dev notebook fan it's no issue.


feat(toolbars): 顶部工具栏改造，新增可引入公共组件

English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our Commit Message Guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Built its own designer, fully self-validated

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

Summary by CodeRabbit
Release Notes

New Features

Introduced ToolbarBaseButton component, allowing for customizable button features within toolbars.
Enhanced toolbar components with new options prop for improved configurability.

Bug Fixes

Improved rendering logic for various toolbar components to ensure accurate display based on state and props.

Refactor

Streamlined toolbar component structures, consolidating functionalities into the new toolbar-base component for better organization and maintainability.
Refactored multiple toolbar components to utilize the toolbar-base, enhancing usability and clarity.

Documentation

Updated metadata for toolbar configurations to improve clarity and extensibility.

按钮的样式有点问题，多了一个边框


Socket.io-client 404 Not Found

This has been driving me nuts for a whole month.
Socket.io-client would not generate socket.id.
Keep getting this error:

NextJS CRA Component:
import React, { Component } from 'react';
import io from 'socket.io-client';

export default class OAuthWidget extends Component {
  state = {};
  componentDidMount() {
    this.socket = io('https://localhost:4444');
    console.log( {this.socket} );
    fetch('https://localhost:4444/').then(res => {
      if (res) {
        console.log('Response from server received');
      }
    });
  }

  render() {
    console.log('this.socket: ', this.socket);   // returns undefined

    return
Socket id: {this.socket}
;
  }
}

NodeJS w/ GraphQLServer Backend
(sanitised from irrelevant modules):
index.js:
const fs = require('fs');
const express = require('express');
const session = require('express-session');
const socketio = require('socket.io');
const cookieParser = require('cookie-parser');
const createServer = require('./createServer');

const server = createServer();

server.express.use(express.json());

server.express.use(
  session({
    secret: process.env.SESSION_SECRET,
    resave: true,
    saveUninitialized: true
  })
);

const io = socketio(server);
server.express.set('io', io);
socketio.listen(server);

server.express.use(cookieParser());

server.start(
  {
    cors: {
      credentials: true,
      origin: ['http://localhost:3000']
    },
    https: {
      key: fs.readFileSync(`./src/ssl/server.key`),
      cert: fs.readFileSync(`./src/ssl/server.crt`)
    }
  },
  async details => {
    console.log(`Server started on: https://localhost:${details.port}`);
  }
);

createServer():
const { GraphQLServer, PubSub } = require('graphql-yoga');
..
function createServer() {
  return new GraphQLServer({
    typeDefs: 'src/schema.graphql',
    resolvers: {
      Query,
      Mutation
    },
    resolverValidationOptions: {
      requireResolversForResolveType: false
    },
    context: req => ({
      ...req,
      db,
      pubsub
    })
  });
}

module.exports = createServer;

many thanks in advance

This doesn't seem related to Next.js, but to your server not serving a certain route. Next.js/React is calling componentDidMount and it's fetching as specified.


Use MID (Wikibase identifiers) instead of title (filenames) everywhere in the app?

[Very long-term]
In the app, we use media identifiers at various places, for instance in the gallery/etc. We even store some, in the cache and in the bookmarks.
Commons titles (for instance Moissac-Bellevue Ruines d’un moulin à blé.JPG) are bad as identifiers because:

They can be very long
They can be in very strange alphabets or contain weird characters that trigger bugs when going through various protocols/languages/formats
Most importantly, they sometimes change, for various reasons (for instance someone felt the title was erroneous, or the title contains a word that has now a slur connotation, or many other reasons)

On the opposite, the new Wikibase identifiers are great:

Short
Only ASCII characters, for instance M293529
Can not be modified

If someone has time, please evaluate the feasibility of using the Wikibase identifiers.
Points to check:

Some API operations might not accept them,
API operations that accept them might be slower or require hops,
Migration of user bookmarks, and possibly other cached data, must be thought about.

I can't find any reference to MID's in https://commons.wikimedia.org/w/api.php. However, it might be a good idea to use pageids instead of filenames as our identifiers. ´pageid´ is of type int, so we can use it as an index in SQL as well.