Option / Setting to disable "Restarting..." and "Started!" message

Is your feature request related to a problem? Please describe.
There is no need for me, to get every restart information of the ioBroker / "ioBroker.telegram" -Adapter and / or to disturb the user(s) every time if something happen.
Describe the solution you'd like
I'd like to have an option, which disables the default messages: "Restarting..." and "Started!" by restarting the adapter.

Why you not simply increase the loglevel to warn.. Then you do not get info logs anymore and you're fine?

Hi, this does not have any effect.
I'll receive every morning the same Message, sent by telegram bot.

Die Startmeldungen würde ich auch gern deaktivieren können.

Why you not simply increase the loglevel to warn.. Then you do not get info logs anymore and you're fine?

Ich galb da gehts nicht um Meldungen im (ioBroker)-Log sindern um die restartung / started Meldungen in Telegram. Die werden wohl kaum vom ioBroker Log Level abhängen

As far as I known - and as I just tested with v1.14.1 - you do not receive any restart / started messages if the text files "restarting" and/or "restarted" are EMPTY (see screenshot)

Please note that admin does not display an empty area for empty text fields but shows the lebale of the textfield instead. So the captured screenshot sown emptye (blank) data.
And please note too, that after saving the blank data the adapter restarts. This sends one (last) message as the new config will be in use only AFTER the restart so the shutdown still uses the old config.

@MediaMemphis
@peterfido
Please verify

@MediaMemphis @peterfido
Please verify

Hi @mcm1957, thank you for your support! Yes, this helped to disable these messages.
There was an _ in the textbox, maybe that's why I didn't understand to change the vlaue :/.

We should document it

Its already documented at the help text in wblate.
We "only" must check why its not delivered....
See oth issue regarding helptest missing

Documentation is likely available at next release v1.15.x
The help text below the two textfields describes that an empty field suppresses the telegram messages:
"This text will be sent to clients once the adapter instance started. Leave blank to deactivate."

The help text shown with 1.15.2 decribes the functionality, i.e.
DE: Dieser Text wird nach dem Start der Adapter-Instanz an die Clients gesendet. Zum Deaktivieren: leer lassen.
EN: This text will be sent to clients once the adapter instance is going to be stopped. Leave blank to deactivate.

If additional documentation should be implemented this issue should be kept open, otherwise it could be closed in my oppinion

Sorry für die späte Rückmeldung. Leer lassen hilft.

Sorry für die späte Rückmeldung. Leer lassen hilft.

Versteh ich :-)
Ist aber das Standard Google Design / Verhalten für Textfelder. Daher keine Änderung geplant.


Expose add an API command to start a func task and to check if CLI tools is installed

Exposing these commands to be used by external teams. Basically, they just need a way to start a func task but without using our VS Code launch/task configuration.
In order to launch the func host cli, it needs to be installed, so just exposing a way for them to see if it is or not.

@alexweininger I think I have a hunch as to what might be going on here. It appears that your build is pulling pre-release bits of the Azure Functions Core Tools.
[20:53:58] Starting 'getFuncLink'...
Func cli feed version: 4.101.0
Func downloadLink: https://functionscdn.azureedge.net/public/4.0.123/Azure.Functions.Cli.linux-x<IP_ADDRESS>43.zip
[20:53:58] Finished 'getFuncLink' after 197 ms
[20:53:58] Starting 'installFuncCli'...
[20:54:08] 'installFuncCli' errored after 10 s
[20:54:08] Error: ENOTDIR: not a directory, scandir '/home/runner/tools/func/in-proc6/tools'

Perhaps we should pin the CI machine to the non-prerelease version? I dunno if you have controller one that based on the feed things are being pulled from.


calc.abs doesn't work on page margin inside context

Description
#set page(margin: (left: 1in, right: 1in))
#set rect(stroke: black + 1in)
#context [
  #assert(page.margin.left == rect.stroke.thickness)
  #calc.abs(rect.stroke.thickness)
  #calc.abs(page.margin.left)
]

The type of stroke.thickness and margin.left are verified to be the same. However, the compiler panics in the second abs calculation with:
expected integer, float, length, angle, ratio, or fraction, found relative length

If a relative length is not allowed, then shouldn't calc.abs fail on the first calculation too? What causes relative lengths to be invalid only on the page margin?
Reproduction URL
No response
Operating system
No response
Typst version

[X] I am using the latest version of Typst

This works
#set rect(stroke: black + 1in)
#context [
  #assert(page.margin.left == rect.stroke.thickness)
  #calc.abs(rect.stroke.thickness)
  #calc.abs(page.margin.left.length)
]```

Stroke.thickness is not a relative length, unlike page.margin.left. While ratio in this case is 0% you still have to explicitly extract the absolute part of it before applying calc abs.

@Enivex not so: #calc.abs(-72pt) will happily return 72pt as is the case during the stroke calculation. The bug report is that the behavior is inconsistent.

@Enivex not so: #calc.abs(-72pt) will happily return 72pt as is the case during the stroke calculation. The bug report is that the behavior is inconsistent.

-72pt is not a relative length

Apologies for the confusion. I was surprised that 72pt can be both a relative length and a length, since printing the value doesn't give an indication that the types are different (along with the == operator indicating they are equal)

I agree that it's not ideal.


Update cookie name

cc @Tratcher

https://github.com/aspnet/Coherence-Signed/issues/166

:shipit:


Flash attention 2 not working, "Moondream does not support Flash Attention 2.0 yet."

    model = AutoModelForCausalLM.from_pretrained(
  File "/home/user/.local/lib/python3.8/site-packages/transformers/models/auto/auto_factory.py", line 561, in from_pretrained
    return model_class.from_pretrained(
  File "/home/user/.local/lib/python3.8/site-packages/transformers/modeling_utils.py", line 3456, in from_pretrained
    config = cls._autoset_attn_implementation(
  File "/home/user/.local/lib/python3.8/site-packages/transformers/modeling_utils.py", line 1302, in _autoset_attn_implementation
    cls._check_and_enable_flash_attn_2(
  File "/home/user/.local/lib/python3.8/site-packages/transformers/modeling_utils.py", line 1382, in _check_and_enable_flash_attn_2
    raise ValueError(
ValueError: Moondream does not support Flash Attention 2.0 yet. Please open an issue on GitHub to request support for this architecture: https://github.com/huggingface/transformers/issues/new

Can you check if you're using the 2024-03-06 revision? Previous ones don't support it yet.

@vikhyat The batch processing from 2024-03-05 with 2024-03-06 seems to be broken

Using revision 2024-03-06 results in this:
Traceback (most recent call last):
  File "moondream_batch.py", line 201, in run_model
    captions = model.answer_question(enc_images, [query_prompt] * len(batch_images), tokenizer)
  File "/home/user/.cache/huggingface/modules/transformers_modules/vikhyatk/moondream2/c064b4c517bbdbbad6351b1959c90b79858822be/moondream.py", line 95, in answer_question
    answer = self.generate(
  File "/home/user/.cache/huggingface/modules/transformers_modules/vikhyatk/moondream2/c064b4c517bbdbbad6351b1959c90b79858822be/moondream.py", line 78, in generate
    inputs_embeds = self.input_embeds(prompt, image_embeds, tokenizer)
  File "/home/user/.cache/huggingface/modules/transformers_modules/vikhyatk/moondream2/c064b4c517bbdbbad6351b1959c90b79858822be/moondream.py", line 56, in input_embeds
    return torch.cat(embeds, dim=1)
RuntimeError: Sizes of tensors must match except in dimension 1. Expected size 1 but got size 24 for tensor number 2 in the list.

answer_question only supports a single image, there's a new batch_answer API for batch generation:
answers = moondream.batch_answer(
    images=[Image.open('<IMAGE_PATH_1>'), Image.open('<IMAGE_PATH_2>')],
    prompts=["Describe this image.", "Are there people in this image?"],
    tokenizer=tokenizer,
)

Thanks! Now, I'm trying the new function and it seems to be resulting a new error message
    captions = model.batch_answer(enc_images, [query_prompt] * len(batch_images), tokenizer)
  File "/home/user/.cache/huggingface/modules/transformers_modules/vikhyatk/moondream2/c064b4c517bbdbbad6351b1959c90b79858822be/moondream.py", line 120, in batch_answer
    image_embeds = self.encode_image(images)
  File "/home/user/.cache/huggingface/modules/transformers_modules/vikhyatk/moondream2/c064b4c517bbdbbad6351b1959c90b79858822be/moondream.py", line 31, in encode_image
    return self.vision_encoder(image)
  File "/home/user/.cache/huggingface/modules/transformers_modules/vikhyatk/moondream2/c064b4c517bbdbbad6351b1959c90b79858822be/vision_encoder.py", line 130, in __call__
    [self.preprocess(image.convert("RGB")) for image in images]
  File "/home/user/.cache/huggingface/modules/transformers_modules/vikhyatk/moondream2/c064b4c517bbdbbad6351b1959c90b79858822be/vision_encoder.py", line 130, in <listcomp>
    [self.preprocess(image.convert("RGB")) for image in images]
AttributeError: 'Tensor' object has no attribute 'convert'

Is enc_images a list of PIL Images? It looks like you might have already run them through the image encoder?

@vikhyat that was the output from model.encode_image, but I see that functionality is built into batch_answer now. Everything is working now, thanks for the help!

Nice! This is good feedback, I'm going to improve the error messages.

I do not know what the attention flash is, although it works very fast the same, in version 2, I have added it like that. (in what they mention about the version)
I don't know if it's okay as he adds it.
 Model_id = "vikhyatk/moondream2"
 REVIEW = "2024-03-13"
 Tokenizer = Tokenizer.from_pretrained (Model_id)
 moondream = moondream.from_pretrained (model_id) .to (device = device, dtype = dtype)
 Attn_implementation = "Flash_attenion_2"
 Mondream.Eval ()

 I cannot paste the entire code because I would confuse more, I use the Mondream to see an image, and the answer translates it into Spanish, then I use it for other things.


Optimisation: copy linux_amd64.yml to scripts

linux_amd64.yml  move to scripts dir

Where does the script need to be changed?

#1167
Whether the goRelease configuration file also needs to be modified？
https://goreleaser.com/customization/nfpm/

#1167
Whether the goRelease configuration file also needs to be modified？
https://goreleaser.com/customization/nfpm/

#1153   This issue is tracking this problem. If you are interested, you can commit a PR.


Refactors Notification action with new interface

Issue #, if available:
Description of changes:
Refactors Notification action with new interface. To support the settings dynamically used in the notification action, as well as the script service used in the notification and transition actions, the settings and script service fields were added to the step context.
CheckList:

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #238 (7c2ae2f) into development-extension (f8fc089) will increase coverage by 1.19%.
The diff coverage is 70.14%.

@@                     Coverage Diff                     @@
##             development-extension     #238      +/-   ##
===========================================================
+ Coverage                    63.47%   64.67%   +1.19%
- Complexity                    1450     1488      +38
===========================================================
  Files                          249      249
  Lines                         9684     9741      +57
  Branches                      1498     1506       +8
===========================================================
+ Hits                          6147     6300     +153
+ Misses                        2786     2655     -131
- Partials                       751      786      +35

Impacted Files
Coverage Δ

...ement/step/notification/AttemptNotificationStep.kt
63.63% <63.63%> (+63.63%)
:arrow_up:

...statemanagement/action/NotificationActionParser.kt
70.00% <68.42%> (+70.00%)
:arrow_up:

.../indexstatemanagement/action/NotificationAction.kt
88.23% <84.61%> (+88.23%)
:arrow_up:

...anagement/indexstatemanagement/ISMActionsParser.kt
79.48% <100.00%> (+0.53%)
:arrow_up:

...agement/indexstatemanagement/ManagedIndexRunner.kt
29.78% <100.00%> (ø)

...t/indexstatemanagement/model/ManagedIndexConfig.kt
74.28% <0.00%> (-2.86%)
:arrow_down:

.../opensearch/indexmanagement/rollup/model/Rollup.kt
83.96% <0.00%> (+0.47%)
:arrow_up:

...nt/indexstatemanagement/ManagedIndexCoordinator.kt
52.26% <0.00%> (+0.69%)
:arrow_up:

...earch/indexmanagement/transform/TransformRunner.kt
84.04% <0.00%> (+1.06%)
:arrow_up:

...anagement/indexstatemanagement/model/Transition.kt
19.71% <0.00%> (+1.40%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fc089...7c2ae2f. Read the comment docs.


Branch not shown in activity list of multi-branch pipeline

Versions Used
KubeSphere: v3.2.0-alpha.0

/kind bug
/cc @kubesphere/sig-console
/priority medium

/area console

nightly20211011 did not have this problem, I close this issue for now.


Use floating DIPs throughout the stack

I sure hope I didn't break anything!
While til::math was a good idea its convenience led us to use it
in the only place where it absolutely must not be used: The UI code.
So, this PR replaces all those til::points, etc., with floats.
Now we use DIPs consistently throughout all layers of the UI code,
except for the UIA area (that would've required too many changes).
Validation Steps Performed
Launch, looks good, no obvious defects, UIA positioning seems ok. ✅

everything's so much easier

In defense of the previous code, I personally wouldn't even say that it's easier, but I do think it has the benefit of being more correct at high DPI, because we now always transmit DIPs with floats. 🙂


translate set-up-cluster-federation-kubefed-2017-10-15.md to chinese

NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

@xiaosuiba @markthink 需要更多次 review，比较长

谢谢@xiaosuiba 的仔细review , 我修改了一遍提交了一个commit ，麻烦你再看看，谢谢


RTL support

UIs for languages that are read from right-to-left (RTL), such as Arabic and Hebrew, should be mirrored to ensure content is easy to understand.
Mirroring layout
The main difference between left-to-right (LTR) and right-to-left (RTL) language scripts is the direction in which content is displayed:
LTR languages display content from left to right
RTL languages display content from right to left

RTL content also affects the direction in which some icons and images are displayed, particularly those depicting a sequence of events.
In general, the passage of time is depicted as left to right for LTR languages, and right to left for RTL languages.

A detailed description of the problem is required

A detailed description of the problem is required

UIs for languages that are read from right-to-left (RTL), such as Arabic and Hebrew, should be mirrored to ensure content is easy to understand.
Mirroring layout
The main difference between left-to-right (LTR) and right-to-left (RTL) language scripts is the direction in which content is displayed:
LTR languages display content from left to right
RTL languages display content from right to left

RTL content also affects the direction in which some icons and images are displayed, particularly those depicting a sequence of events.
In general, the passage of time is depicted as left to right for LTR languages, and right to left for RTL languages.

not think about it now

not think about it now

UIs for languages that are read from right-to-left (RTL), such as Arabic and Hebrew, should be mirrored to ensure content is easy to understand.
Mirroring layout
The main difference between left-to-right (LTR) and right-to-left (RTL) language scripts is the direction in which content is displayed:
LTR languages display content from left to right
RTL languages display content from right to left

RTL content also affects the direction in which some icons and images are displayed, particularly those depicting a sequence of events.
In general, the passage of time is depicted as left to right for LTR languages, and right to left for RTL languages.

I think this issue should go  upstream.
https://github.com/PanJiaChen/vue-element-admin


[UI] Unpublished assets should not be accessible anonymously

Describe the bug
After an admin unpublished an asset (unchecks the boxes for featured and published), the direct access link should no longer work for unauthenticated users (private browser, not logged in).
To Reproduce
Steps to reproduce the behavior:

Go to Datasets, select one, i.e. "Finance Proposition Bank"
In the browser URL, you will find the direct access link: https:///datasets/finance-proposition-bank
As a logged-in admin user, click on "VIEW ALL DATASETS"
Uncheck the boxes for "Featured" and "Published" for the "Finance Proposition Bank"
Go back to "FEATURED" and see the "Finance Proposition Bank" dataset should no longer be there
Open a Private Browser and paste the link from step 2.: https:///datasets/finance-proposition-bank
See the page show up with all the details.

Expected behavior
The user should get a 404 page.

@ckadner I would like to work on this issue.


Updated elastic commands in travis.yml.

Closes #115

Please take a look at strict-standard errors.


Gonzus/c library benchmark

Add a benchmark to compare C and C++ versions
Make benchmark output easily parseable
Make benchmark run on linux
Keep benchmark cases sorted alphabetically

No other implementation has a benchmark, so what is the justification for having this specific one checked into the repo? I don't expect that it's something that we're going to want to run regularly, or am I missing something?

You are correct. On the other hand, benchmarks are usually included in a project's repo for transparency, so that anyone can replicate the measurements and come to their own conclusions.
I am OK with not having this here, of course.

I am not sure if other changes are required, or if this is still under consideration (which is fine, of course)... I ask because I keep seeing a "Changes requested" and I don't have any additional way for me to say "your requested changes were applied".

Sorry, I didn't get an email notification with your code changes (and I was out for Thanksgiving). Code looks good and I don't have any concerns with including this here, so merging now.


MaxZoomIn for ZoomInOutWidget

Hi, is there a way to limit the MaxZoomIn of the ZoomInOutWidget? I have a OpenStreetMap as a TileLayer but it does not respect the MaxZoomIn of the TileLayer.
Thank you.

Is this in the latest version? I thougt i fixed this at some point.

No, it wasn´t. I have just updated Mapsui package and my Mapsui.UI.InfoEventArgs is given me an error. I changed it to Mapsui.UI.MapInfoEventArgs and it responded with an Unhandled Exception: System.TypeLoadException: Could not resolve type with token 0100002f (from typeref, class/assembly Mapsui.UI.MapInfoEventArgs, Mapsui, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null).
I cleaned and rebuilded the solution but the problem still remains. Because of this problem, I cannot check if the ZoomInOutWidget works.

This is the sample: https://github.com/Mapsui/Mapsui/blob/master/Samples/Mapsui.Samples.Common/Maps/OsmSample.c
CRS = "EPSG:3857",
Transformation = new MinimalTransformation()

Thank you, now it worked. The problem was that I had the CRS defined on both pages: the MapUIView page and the principal Map page. So, the solution was to only include it on the MapUIView page.

Great


CORS with bucket

Loading assets with bucket is broken on last Chrome :
see : https://www.chromestatus.com/feature/5629709824032768

Maybe related to the url of bucket :
https://s3-eu-west-1.amazonaws.com/ ... works
https://s3.amazonaws.com/ doesnt

So yes, bucket must contain region.

As you know, I'm not very happy with the bucket solution right now.
Do you know if this is possible to upload assets in another bucket not related to the ssr stack ?
If so, this asset can be created in Route53, CloudFront, and get a real url like assets.EXAMPLE_Domain.com.

Another way I can think of is adding a layer in index.js handling static file as express do it.
Something similar as
app.use("/_next/static", express.static(path.join(__dirname, "/static")));

As you know, I'm not very happy with the bucket solution right now.
Do you know if this is possible to upload assets in another bucket not related to the ssr stack ?
If so, this asset can be created in Route53, CloudFront, and get a real url like assets.EXAMPLE_Domain.com.

You should be able to do this now by using the plugin config assetsBucketName  😀 https://github.com/danielcondemarin/serverless-nextjs-plugin#hosting-static-assets

👍

Closing this for : https://github.com/danielcondemarin/serverless-nextjs-plugin/issues/31


amplify env checkout never completes (spins forever)

Describe the bug
It looks like something happened to env checkout command. I can't checkout environment using any version after 4.28.2.
It just never completes and shows no errors.
Amplify CLI Version
4.29.x, 4.30.x, 4.31.x
To Reproduce
when ever I run
amplify env checkout ${envName} --providers '{ "awscloudformation": {"configLevel": "project", "useProfile": true, "profileName": "${profileName}"} }'

it spins with "Initializing your environment: {...}" forever
Expected behavior
Environment get checked out
Desktop (please complete the following information):

OS: Mac
Node Version: v14.0.0

I'm using api, auth, function, storage
Previous issue got closed, I overlooked that sorry: https://github.com/aws-amplify/amplify-cli/issues/5695
Is there any thing I can do to troubleshoot the issue?

Closing as duplicate of #5695


Does it work with latest ROS 2 version

Hi,
I am using ROS 2 Iron since 'galactic' has reached end-of life. Should I expect Create 3 work with Iron. I could not see any ros2 topic by 'ros2 topic list'. Here are my settings.
(1) Create 3 is connected to my laptop via 'usb_c_to_ethernet_adaptor  -- ethernet_cable --- usb_c_to_ethernet_adaptoer'
(2) Both create 3 and my laptop's RMW_IMPLEMENTATION are set to rmw_cyclonedds_cpp
(3) I could access the website http://<IP_ADDRESS>
Thank you very much. Any help is greatly appricated.

By the way, I am not using wifi connection.


DSD-1105: dark mode support for Content Display components

Fixes JIRA ticket DSD-1105
This PR does the following:

Adds dark mode support for the HelperErrorText and StatusBadge components.

How has this been tested?

local Storybook

Accessibility concerns or updates

The dark mode updates are implemented using the NYPL WCAG compliant dark color palette.

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] Review the Vercel preview deployment once it is ready.

The a11y error has been fixed.  When I was initially working on this, I stripped out some styles to fix one issue, only to then caused this problem with the error color.


Add a type field to Facebook postbacks

Closes #447.

Superseded by #469 .

Thanks for your work!


(BUG / v1.12-1.1.4) Haunted Buildings no longer generating.

Minecraft 1.12
Lost Souls v1.12-1.1.4
Lost Cities v1.12-2.0.5
McJtyLib v1.12-2.6.5
Forge v<IP_ADDRESS>15
Mod Pack - https://github.com/Vaygrim/wasted
Currently not getting any Lost Cities buildings generating as being Haunted. Building percentage is set at 80% in the Lost Souls config, you can check my config files for all your mods in the above linked GitHub for the mod pack.
At present this has only been tested under Single Player as I don't want to update my test server until this is resolved. Help?

Since when did this start? Also you mean outside I suppose as your haunt chance for inside is set to 0

This started on Monday as I went thru and updated a ton of mods. Also yes, this is outside as we've got no buildings generating inside domes. Mallrat208 has done testing with the same updates and configs on his end, and it appears to be working FINE on his end. (Just got this information about 2 minutes ago.) So I'm going to go back and see what is different about my setup.

Did you manage to find anything about this? I have no clue what could be wrong on the mods side I'm afraid

This was a corrupt / bad configuration file. Finally tracked that down and proved it yesterday afternoon (sorry for late notification.. it's been a whirlwind Sunday)


Update Get-MailTrafficSummaryReport.md

https://github.com/MicrosoftDocs/office-docs-powershell/issues/1662

OPS Build status updates of commit 732c16c:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit 732c16c:
:clock10: Incremental building: average incremental building time is 12 min(s) 23 sec(s)

OPS Build status updates of commit 732c16c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/reporting/Get-MailTrafficSummaryReport.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 155385e:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit 155385e:
:clock10: Incremental building: average incremental building time is 12 min(s) 23 sec(s)

OPS Build status updates of commit 155385e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/reporting/Get-MailTrafficSummaryReport.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 79e76ba:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit 79e76ba:
:clock10: Incremental building: average incremental building time is 12 min(s) 24 sec(s)

OPS Build status updates of commit 79e76ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/reporting/Get-MailTrafficSummaryReport.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 747ff01:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit 747ff01:
:clock10: Incremental building: average incremental building time is 12 min(s) 23 sec(s)

OPS Build status updates of commit 747ff01:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/reporting/Get-MailTrafficSummaryReport.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 9ba7d07:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit 9ba7d07:
:clock10: Incremental building: average incremental building time is 12 min(s) 23 sec(s)

OPS Build status updates of commit 9ba7d07:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/reporting/Get-MailTrafficSummaryReport.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


sync possibility with a "personal dev" workspace

The following image shows that there is a sync possibility with a "personal dev" workspace.

Where can I find documentation for this specific sync, is this also possible with PowerBI Pro or Premium?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f25aa02c-35e6-7554-a78d-cf79c50bc5eb
Version Independent ID: f25aa02c-35e6-7554-a78d-cf79c50bc5eb
Content: Azure DevOps build pipeline integration with Power BI Desktop projects - Power BI
Content Source: powerbi-docs/developer/projects/projects-build-pipelines.md
Service: powerbi
Sub-service: ****
GitHub Login: @mberdugo
Microsoft Alias: monaberdugo

Thanks for your comment, @wrende. This issue has been assigned to the doc author for review.

Sorry for the confusion and we will update the diagram. But, no you cannot sync with a Personal Workspace. Its not yet supported by Fabric Git Integration.
The "{Personal Dev} Workspace" meaning is the "Develop using another workspace" isolation described in our docs: https://learn.microsoft.com/en-us/fabric/cicd/git-integration/manage-branches#develop-using-another-workspace.


perf(ngClass): refactor to optimize the case of static map of classes with large objects

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...): performance improvement
What is the current behavior? (You can also link to an open issue here): it makes copies of very large objects:
    it('should not copy verylargeobject', inject(function($rootScope, $compile) {
      var getProp = jasmine.createSpy('getProp');
      var verylargeobject = {};
      Object.defineProperty(verylargeobject, 'prop', {
        get: getProp,
        enumerable: true
      });
      element = $compile('

')($rootScope);
      $rootScope.verylargeobject = verylargeobject;
      $rootScope.$digest();

      expect(getProp).not.toHaveBeenCalled();
    }));

What is the new behavior (if this is a feature change)?: the user perceives no change but that it is faster with very large objects
Does this PR introduce a breaking change?: no
Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

Other information:
This PR responds to https://github.com/angular/angular.js/pull/14394#issuecomment-207812797
It is alternative to https://github.com/angular/angular.js/pull/14394

For one time binding is getting hard, I just cannot previously convert to a plain string because of:
  it('stabilizes when in a literal are not undefineds', inject(function($rootScope, $compile) {
    $rootScope.foo = true;
    element = $compile('

')($rootScope);
    $rootScope.$digest();
    expect(element).toHaveClass('foo');
    $rootScope.bar = true;
    $rootScope.$digest();
    expect(element).toHaveClass('bar');
    $rootScope.bar = false;
    $rootScope.$digest();
    expect(element).toHaveClass('bar');
  }));

In the current implementation the watcher watches a string which cannot contain undefineds. I will change the strategy. Fortunately it is only one level:
  // this test fails (nested undefineds)
  it('stabilises when nested?', inject(function($rootScope, $compile) {
    $rootScope.foo = true;
    element = $compile('

')($rootScope);
    $rootScope.$digest();
    expect(element).toHaveClass('foo');
    $rootScope.bar = true;
    $rootScope.$digest();
    expect(element).toHaveClass('bar');
    $rootScope.bar = false;
    $rootScope.$digest();
    expect(element).toHaveClass('bar');
  }));

from parse.js (see that isAllDefined is one level, not nested):
    function oneTimeLiteralWatchDelegate(scope, listener, objectEquality, parsedExpression) {
      var unwatch, lastValue;
      return unwatch = scope.$watch(function oneTimeWatch(scope) {
        return parsedExpression(scope);
      }, function oneTimeListener(value, old, scope) {
        lastValue = value;
        if (isFunction(listener)) {
          listener.call(this, value, old, scope);
        }
        if (isAllDefined(value)) {
          scope.$$postDigest(function() {
            if (isAllDefined(lastValue)) unwatch();
          });
        }
      }, objectEquality);

      function isAllDefined(value) {
        var allDefined = true;
        forEach(value, function(val) {
          if (!isDefined(val)) allDefined = false;
        });
        return allDefined;
      }
    }

@gkalpak can you take a look to:

https://travis-ci.org/angular/angular.js/pull_requests

it seems that the following test fails randomly for Firefox:
[firefox 28 #2] ..F...............................................................................................................................................................
[firefox 28 #2]
[firefox 28 #2] Failures:
[firefox 28 #2] 1) $anchorScroll with `yOffset` should automatically scroll when navigating to a URL with a hash
[firefox 28 #2]   Message:
[firefox 28 #2]     Expected #anchor-5's top to be 50, but it was 208
[firefox 28 #2]   Stack:
[firefox 28 #2]     Error: Failed expectation
[firefox 28 #2]         at /home/travis/build/angular/angular.js/test/e2e/tests/anchor-scroll.spec.js:113:32
[firefox 28 #2]         at /home/travis/build/angular/angular.js/test/e2e/tests/anchor-scroll.spec.js:160:7

Yeah, I've seen it too. I thought these were flakes. Maybe #14912 will make them go away.

Indeed. Firefox 28 is quite old :D

It's green now.

Did this LGTY back in July @gkalpak ?

@drpicox can you please rebase this?

Did this LGTY back in July @gkalpak ?

Not if I didn't say so :smiley:
(I got caught up in other stuff and I never gave this a final review. I'll take a look asap.)

Ops!
I'll do it now.
David

Rebased. Waiting for travis tests.

Green.

I have an alternative PR (#15228) which includes several refactorings, the fix mentioned above and some perf improvements (that should cover the ones in this PR and more).
I have "borrowed" the tests and part of the implementation :grin:
WDYT?

You have done a really good job 👍


fix(dropdown): place outside label 8px above dropdown like design spec

Describe pull-request
Places outside label variant of dropdown 8px above the dropdown, to align with appearance in figma, and also with appearance of text field.
Also makes the label take up space on the page, which it did not previously do (it was placed with position absolute).
Solving issue
AB#718
How to test
Go here https://production.d1g8v8mrkx992n.amplifyapp.com/?path=/story/component-dropdown--label-outside,
or equivalent path on your localhost when running sdds.
Screenshots
Before

After

If there is a lack of space at the bottom, the dropdown menu will open upwards.
It causes this behavior:

@charlottelorensson and @matyldamc  - Should the menu in this case touch the top part of the dropdown and hide the label?

@theJohnnyMe unfortunately yes, it should behave as you said, and cover the label. Not great for accessibility but I see no other solution.

@theJohnnyMe I did a small update to remove the gap, please have a look whenever you have time 😄

I am just thinking if overwriting the existing rule for a situation where the label is out would be a more neat solution, so instead of introducing -24px on the margin, can you change the bottom property calculation in case the label is out?
I did test it here, seems to work OK:

so something like this in the code:
:host(.sdds-dropdown--open-upwards:has(span.sdds-dropdown-label-outside)) {   .sdds-dropdown {     .sdds-dropdown-menu {          bottom: calc(100% - 24px);          }   } }
What do you think? 🤔

I am just thinking if overwriting the existing rule for a situation where the label is out would be a more neat solution, so instead of introducing -24px on the margin, can you change the bottom property calculation in case the label is out?
I did test it here, seems to work OK:

so something like this in the code:
:host(.sdds-dropdown--open-upwards:has(span.sdds-dropdown-label-outside)) { .sdds-dropdown { .sdds-dropdown-menu { bottom: calc(100% - 24px); } } }
What do you think? 🤔

I definitely like this approach more than the negative margin!

I am just thinking if overwriting the existing rule for a situation where the label is out would be a more neat solution, so instead of introducing -24px on the margin, can you change the bottom property calculation in case the label is out?
I did test it here, seems to work OK:

so something like this in the code:
:host(.sdds-dropdown--open-upwards:has(span.sdds-dropdown-label-outside)) { .sdds-dropdown { .sdds-dropdown-menu { bottom: calc(100% - 24px); } } }
What do you think? 🤔

I definitely like this approach more than the negative margin! Me and @alexandereneroth was discussing the :has selector tho, it is not yet supported in FF so we would have to look use something else to check if the label is outside and then target the parent element.

I get you, good thinking for support on Firefox. Well, since it is a web component, one way is that if the label is used and it is lable outside, you can make another class to appear on top level, something like "sdds-dropdown--lable-outside" and based on that style menu position accordingly, just one idea.

I am just thinking if overwriting the existing rule for a situation where the label is out would be a more neat solution, so instead of introducing -24px on the margin, can you change the bottom property calculation in case the label is out?
I did test it here, seems to work OK:

so something like this in the code:
:host(.sdds-dropdown--open-upwards:has(span.sdds-dropdown-label-outside)) { .sdds-dropdown { .sdds-dropdown-menu { bottom: calc(100% - 24px); } } }
What do you think? 🤔

I definitely like this approach more than the negative margin! Me and @alexandereneroth was discussing the :has selector tho, it is not yet supported in FF so we would have to look use something else to check if the label is outside and then target the parent element.

I get you, good thinking for support on Firefox. Well, since it is a web component, one way is that if the label is used and it is lable outside, you can make another class to appear on top level, something like "sdds-dropdown--lable-outside" and based on that style menu position accordingly, just one idea.

I think we can target the right element like this:
:host(.sdds-dropdown--open-upwards[label-position="outside"]){
   span.sdds-dropdown-menu {
      bottom: calc(100% - 24px);
    }
}

@alexandereneroth do you want to test it out aswell?

I am just thinking if overwriting the existing rule for a situation where the label is out would be a more neat solution, so instead of introducing -24px on the margin, can you change the bottom property calculation in case the label is out?
I did test it here, seems to work OK:

so something like this in the code:
:host(.sdds-dropdown--open-upwards:has(span.sdds-dropdown-label-outside)) { .sdds-dropdown { .sdds-dropdown-menu { bottom: calc(100% - 24px); } } }
What do you think? 🤔

I definitely like this approach more than the negative margin! Me and @alexandereneroth was discussing the :has selector tho, it is not yet supported in FF so we would have to look use something else to check if the label is outside and then target the parent element.

I get you, good thinking for support on Firefox. Well, since it is a web component, one way is that if the label is used and it is lable outside, you can make another class to appear on top level, something like "sdds-dropdown--lable-outside" and based on that style menu position accordingly, just one idea.

I think we can target the right element like this:
:host(.sdds-dropdown--open-upwards[label-position="outside"]){
   span.sdds-dropdown-menu {
      bottom: calc(100% - 24px);
    }
}

@alexandereneroth do you want to test it out aswell?

Great idea!

@mJarsater That worked well, nice!

@theJohnnyMe Should be fixed now


Add support to create issues in Redmine

This looks like a promising library to help here https://github.com/malko/node-promised-redmine

I'm going to have to think through the configuration details here, as there likely won't be a simple OAuth solution for redmine

@gregelin do you have a redmine instance already set up that we can test with?

Nope. Feel free to set one up please.
Sent from my iPhone

On May 25, 2016, at 12:43 PM, Chris Birk<EMAIL_ADDRESS>wrote:
@gregelin do you have a redmine instance already set up that we can test with?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Redmine might be best addressed via an API key in combination with specific individual accounts with permission to install tickets.
In other words, for Redmine the common scenario would be issue packs for a single enterprise that is using Redmine. So they have complete control over their Redmine install and access control could be set up specifically between the install and issuepacks.
The github use case we started with was much broader in comparison. With GitHub, you addressed the very general case of any github user installing tickets into any repo for which they had permissions.
Sent from my iPhone

On May 25, 2016, at 12:23 PM, Chris Birk<EMAIL_ADDRESS>wrote:
I'm going to have to think through the configuration details here, as there likely won't be a simple OAuth solution for redmine
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

This has been set up on issuepacks.com in the RedmineController
https://github.com/GovReady/Issue-Packs-Site/blob/master/app/Http/Controllers/RedmineController.php
Redmine functionality should be back-filled to this library at some point.


[dotnet][toaster] Change dotnet weblog to make it supports other dotnet versions

Motivation
In part of the integration of the dotnet tracer into toaster, in order to test the weblog with different dotnet version, this PR allows the weblog to be built for older dotnet versions.
This PR doesn't change the default dotnet version used, which is net6.0.
Changes
Changes in the csproj to correctly set the package version depending of the dotnet version.
Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
[ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team

FYI, you can still use later C# versions in earlier platforms, as long as you're building with the latest SDK, which I would 100% advocate doing if possible

Ohh I did not know that


fix: add missing package-lock.json for npm users

You are right, thanks for making it clear in the docs.


Character Counter

Issue Id you have worked upon -
580
Briefly explain your program logic -
The core idea of the provided code is to create a character counter application using React and the Material-UI library. The code defines a functional component called MainCharacterCounter that maintains various state variables to track the text input and perform character counting operations.
Here are the key points of the code:

The code imports necessary dependencies from React and Material-UI, including the useState hook for managing state.

Inside the MainCharacterCounter component, several state variables are defined using the useState hook. These variables include text (to store the input text), characterCount, wordCount, spaceCount, tabCount, lineBreakCount, and characterFrequency.

The handleTextChange function is called whenever the input text changes. It updates the text state and invokes the countCharacters function to perform character counting operations.

The handleKeyDown function is triggered when a key is pressed. If the pressed key is the Tab key, it prevents the default behavior, inserts a tab character at the current cursor position in the text, updates the text state, increments the tabCount state, and adjusts the cursor position.

The countCharacters function takes a text parameter and performs various counting operations. It splits the text into an array of characters and words using the split method. It calculates the character count by removing whitespace characters, sets the word count by counting the number of words, and counts the occurrences of spaces, tabs, and line breaks using the filter method. It also calculates the frequency of each unique character using an object (characterFrequency).

The return statement renders the UI elements using Material-UI components. It displays a text input field, and below it, it shows the character count, word count, space count, tab count, line break count, and character frequency.

Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @1520229462 on your contribution.
Thanks for adding value to this repository. 😊
Project is live at - https://calc-for-everything-psi.vercel.app/


Markdown syntax broken with Language Pack

the command in our markdown command syntax [foo](command:{0}) will get translated to the target language when using a language pack unless specified via a comment. Affected lines:
@aeschli

[x] new workspace.contribution.ts#L377
[x] new workspace.contribution.ts#L387
[x] new workspace.contribution.ts#L397
[x] new remoteIndicator.ts#L304

@alexr00

[x] remoteExplorer.ts#L317

@jrieken

[x] saveParticipants.ts#L237
[x] saveParticipants.ts#L340

@Tyriar

[ ] terminalConfiguration.ts#L251

@JacksonKearl

[x] new gettingStartedExtensionPoint.ts#L67
[x] new gettingStartedExtensionPoint.ts#L70
[x] new gettingStartedContent.ts there are quite a few

Recommendation:
Follow @JacksonKearl's example and take the guesswork as much as possible for the translators:
https://github.com/microsoft/vscode/pull/125790

I’ve marked the “new” ones. Just the new ones should be considered for candidate.

Closing for this milestone but then will reopen and move out for the last change needed.

Verified the ones checked off so far. Re-opening and moving to June for that last one for @Tyriar


Bump Jasmine timeout to hopefully make CI more stable..

I suspect a lot of the random CI timeouts we've been seeing are just travis being overly slow.  This removes that possibility by making the timeout 30 seconds.  This may result in some long passing tests, but that's a much better problem to have than constant random CI failures (plus the long test reporter should point them out).

Thanks for the pull request @mramato!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

@OmarShehata these all look like legitimate test failures in blob related code (which I know changed slightly recently with image bitmap stuff).  Can you take a look?

I could not reproduce this locally with any browser. It was also fixed with a Travis restart. This is strange because it's not like the image is failing to load, it's just loading a 16x16 image instead of the 1x1 requested in that test? Most of our tests here are either 16x16 or 1x1 images, so, some kind of obscure race condition? I can't think of what bizarre scenario would cause independent promises to interfere like that.

I understand that, but there's clearly something going on or the test wouldn't have failed

This is true. It's different from other erratic failures in that it's not a timeout. My other guess was that the first image fetch is going to fetch a 1x1 image to test createImageBitmap support, and that may be interfering with it, but the reported failure was the opposite issue. It was expecting a 1x1 and getting a 16x16.
I've posted a note here so we can look into it more https://github.com/AnalyticalGraphicsInc/cesium/issues/7249#issuecomment-479925986. I don't think this is caused by this PR.

@OmarShehata the above tests failed again in an unrelated PR: https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/517293290?utm_source=github_status&utm_medium=notification
There's definitely something going on in those tests that the build server doesn't like.

Randomization is disabled.
Tests do not run in parallel.

Thanks again for your contribution @mramato!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @mramato!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @mramato!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @mramato!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

We are seeing a lot of random CI failures, so I'm going to merge this just to rule out time-out related issues (travis itself seems to have gotten slower and more performance prone in the last few months).


Prepare release for AppContainers 1.0.3

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.AppContainers


Update index.html

my vanilla javascript solution

Pass, nice work. Your prize is an invitation to try our long test! :)
https://github.com/Ontraport/frontend-interview-test-long
Also, make sure that Sara in HR has you resume<EMAIL_ADDRESS>


python311Packages.fastcore: 1.5.44 -> 1.5.45

Diff: https://github.com/fastai/fastcore/compare/refs/tags/1.5.44...1.5.45
Changelog: https://github.com/fastai/fastcore/blob/1.5.45/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 318470 run on x86_64-linux 1

2 packages marked as broken and skipped:

python311Packages.openllm
python311Packages.openllm.dist

24 packages built:

ghdorker
ghdorker.dist
python311Packages.execnb
python311Packages.execnb.dist
python311Packages.fastai
python311Packages.fastai.dist
python311Packages.fastcore
python311Packages.fastcore.dist
python311Packages.fastdownload
python311Packages.fastdownload.dist
python311Packages.ghapi
python311Packages.ghapi.dist
python311Packages.nbdev
python311Packages.nbdev.dist
python312Packages.execnb
python312Packages.execnb.dist
python312Packages.fastcore
python312Packages.fastcore.dist
python312Packages.fastdownload
python312Packages.fastdownload.dist
python312Packages.ghapi
python312Packages.ghapi.dist
python312Packages.nbdev
python312Packages.nbdev.dist


The locale dropdown does not switch the locale

Link to reproduction
https://github.com/ivan-kardash/payload/tree/locale-dropdown-not-switching
Payload Version
3.0.0-beta.73
Node Version
20.15.0
Next.js Version
15.0.0-rc.0
Describe the Bug
The locale dropdown does not switch the locale. It changes query string params only without any UI updates. I caught several times states, when selected in the dropdown locale, did not correspond with the locale that UI was rendered
Reproduction Steps

Setup in payload config

localization: {
    defaultLocale: 'en',
    locales: ['en', 'by'],
    fallback: true,
}

Create Global with fields that include filed with config like this

{ name: 'globalText', type: 'json', required: true, localized: true  }

Pass created early Global to payload config
Setup in payload config

  onInit: async (payload) => {
    await payload.updateGlobal({
      slug: "your_slug_here",
      locale: "en",
      data: {
        globalText: { someText: "Some global text in English" },
      },
    });
    await payload.updateGlobal({
      slug: "your_slug_here",
      locale: "by",
      data: {
        globalText: { someText: "Нейкий глабальный тэксту па-беларуску" },
      },
    });
  }

Log in
Forward to Global and try to switch locale

Adapters and Plugins
db-postgres

Can you make sure you're on the following Next and React versions?
"react": "^19.0.0-rc-06d0b89e-20240801",
"react-dom": "^19.0.0-rc-06d0b89e-20240801",
"next": "15.0.0-canary.104",

The rc release from nextjs is quite old at this point and we're using canary.104 internally.
Does this still happen on these versions?

Closing this as far as my testing goes it works, but let me know if the above doesn't fix it for you

Hey @paulpopus! Thanks for your prompt reply and suggestion.
I've tried to create new payloadcms project utilizing npx create-payload-app@beta command and noticed that the issue still reproduced.
The issue is most likely in data displaying. It's tied at least with json localized fields in edit view since list view and REST api work as expected.
Attached a screen record with reproduction demo below.
The code could be found here: https://github.com/ivankyrpa/payload-beta-test
Packages versions:
  "payload": "3.0.0-beta.87",
  "react": "19.0.0-rc-06d0b89e-20240801",
  "react-dom": "19.0.0-rc-06d0b89e-20240801",
  "next": "15.0.0-canary.104"

https://github.com/user-attachments/assets/3779f81d-7230-49a4-a778-2943c8636d03
What are your thoughts? Probably we should reopen the issue and proceed investigation?

@ivankyrpa I'm now looking into our locale-related issues but on the latest beta it seems like I cannot reproduce this bug
Can you confirm it's working fine now?

I've checked on 3.0.0-beta.98 and it looks like it works correct


Widget tests fail when closing/reopening notebooks with saved widget output

Problem with this test is simple, when we open a notebook with an existing widget output,
then the widget renderer loads first, not the test script, even though the
test scripts have been defined in the controller script dependencies as the first script in list of scripts to be loaded.
Hence the widget renderer cannot find the test script and we cannot communicate with the widget renderer.

Can be fixed using IPyWidgets 8 (new protocol methods in kernel)

Closing in favour of https://github.com/microsoft/vscode-jupyter/issues/14856


Static Analysis Compliance (again)

The tests added a couple warnings that I also fixed. Other than that, it's the same as before

All of this is just linter-recommended stuff. my goal was to get rid of all the warnings that pop up when running flutter analyze. As far as I can tell, nothing breaks when I make any of these changes


pyferret.start() messes up command history in python

Reported by karl smith on 5 Jan 2011 19:54 UTC
After executing pyferret.start(), the up/down arrow keys to go through the command history in python no longer work.  The escape strings are printed instead of being captured.  The command history still works in ferret when pyferret.run() is executed.
This was not a problem when the python includes were not part of the build of original ferret code.  In fact, they used to share the command history which was nice to have.  Maybe two copied of the readline library are somehow getting used?
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1781

Comment by karl.smith on 11 Apr 2011 16:40 UTC
PyFerret built at home under Ubuntu does not have this problem.  Ends up this is an issue in the readline 5.0 library used by RHEL 5.  Upgrading to readline 6.2 solves this problem.  However, using 6.2 the Python and the Ferret histories are separate.  The version of readline under Ubuntu (and what I had used back on Porter) still has the shared histories.


Add choosing-a-driver Chinese file

Add choosing-a-driver Chinese file
Signed-off-by: tianying<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cytianying
To complete the pull request process, please assign rajakavitha1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @rajakavitha1 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @rajakavitha1

/assign @rajakavitha1

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cytianying, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 2e0f2e0863b76fd6dc9a3322b48faf325e8e8252


404 on link

Expected content
I expect the link to work
Actual content
Link returns 404
Link to page:
https://sendgrid.com/docs/ui/account-and-settings/inbound-parse/#using-the-api

Hi @realfink,
Please use this link going forward. I will fix the link on the page in question. Thank you!


Stormblessed: Watch DriftTime420

Stormblessed requests the watch of the watch_keyword DriftTime420. See the MS search here and the Stack Exchange search here.

DriftTime420 has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Usually we don't watch usernames unless the user has demonstrated that they are hopping from one SE site to another or that they are re-creating accounts with the same username.


Ship anchored in space (1.16.5 server)

After assemble ship does not move
https://user-images.githubusercontent.com/125739059/219864553-8b8c90b5-badd-41c6-878a-7c74485d7b42.mp4

Align it first and when it is aligned then disassemble

Align it first and when it is aligned then disassemble

the problem isn't position after disassemble, but fact that ship is flying after assemble...

I'm having the same problem but in single player as well, the ship assembles and in fact it has an hitbox and Ican't move on it while shifting. When disassembled the ship will move up by one block and then to the side. 1.18.2 works perfectly, only 1.16.5 gives me this issue.
I have installed only the required mods

valk skies
eureka
cloth config
architectury
kotlin for forge
they are all the latest most downloaded version for 1.16.5 for forge
Also noticed that if a helm is on the ground, assembling and then breaking it completely removes ALL of the world
and last I noticed that when recreating a world minecraft says that the cloth config mod is incompatible / outdated
I made sure that java is updated and 64 bit
I then tried to change some of the mods versions to use past ones without any result
Seeing that 1.18.2 works just fine I would say that maybe it's a compatibility issue with architectury or cloth config

I'm having the same problem but in single player as well, the ship assembles and in fact it has an hitbox and Ican't move on it while shifting. When disassembled the ship will move up by one block and then to the side. 1.18.2 works perfectly, only 1.16.5 gives me this issue. I have installed only the required mods
* valk skies

* eureka

* cloth config

* architectury

* kotlin for forge
  they are all the latest most downloaded version for 1.16.5 for forge
  Also noticed that if a helm is on the ground, assembling and then breaking it completely removes ALL of the world
  and last I noticed that when recreating a world minecraft says that the cloth config mod is incompatible / outdated
  I made sure that java is updated and 64 bit
  I then tried to change some of the mods versions to use past ones without any result
  Seeing that 1.18.2 works just fine I would say that maybe it's a compatibility issue with architectury or cloth config

well, in single player i don't have that problem..... strange....

have you found any solution to this problem?

have you found any solution to this problem?

nope

where can i change it?

If you have fabric you'll need cloth config and modmenu to change the mod settings, or i guess on forge you just go to mods > then config. And if all else fails you could probably find it in your .minecraft/config/valkyrienskies/vs_core_server.json


Remove the deprecated helper pageUrl

In #2216 pageUrl is being renamed to page_url, but the original name is being left in as an alias with a deprecated warning message.
We've left that in for a Ghost version to give theme developers time to update their themes, after #2216 is complete, and we have shipped 0.5, we need to clean up after ourselves and remove the deprecated pageUrl alias.

@ErisDS I see one PR, but it looks like there are more references to PateUrl in the Ghost core, does this still need to be tackled?

Not for a while yet.

This should be finally removed in 1.0.0


Error: Cannot find module 'node:crypto'

Hello,
After running npm install -g staticrypt on a pristiine npm environment (Ubuntu 22.04) I get an error when trying to run staticrypt.
Thanks for your help.
> staticrypt
internal/modules/cjs/loader.js:818
  throw err;
  ^

Error: Cannot find module 'node:crypto'
Require stack:
- /usr/local/lib/node_modules/staticrypt/lib/cryptoEngine.js
- /usr/local/lib/node_modules/staticrypt/cli/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/staticrypt/lib/cryptoEngine.js:1:48)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/usr/local/lib/node_modules/staticrypt/lib/cryptoEngine.js',
    '/usr/local/lib/node_modules/staticrypt/cli/index.js'
  ]
}
> npm version
{
  npm: '8.5.1',
  node: '12.22.9',
  v8: '7.8.279.23-node.56',
  uv: '1.43.0',
  zlib: '1.2.11',
  brotli: '1.0.9',
  ares: '1.18.1',
  modules: '72',
  nghttp2: '1.43.0',
  napi: '8',
  llhttp: '2.1.4',
  http_parser: '2.9.4',
  openssl: '1.1.1m',
  cldr: '40.0',
  icu: '70.1',
  tz: '2023c',
  unicode: '14.0'
}

Hey @bagatel, thanks for reporting with the details of your install.
The latest version of StatiCrypt is 3.x and isn't compatible with node version < 16 . You need to either update your node version to 16+ (the recommended option if you can, that way you get the latest and most secure StatiCrypt version), or downgrade StatiCrypt to 2.x (for ex with npm i -g staticrypt@2).
I'll put a friendlier warning error message to StatiCrypt 3.x so that the fix is clearer.

Bonjour @robinmoisson
Thanks for your help, works fine with node 18 now!
Have a nice day.

Great, thanks for letting me know!


Correction for raw affiliation Professor of anthropology at Portland State University. She is the author of The Kitchen Spoon's Handle: Transnationalism and Sri Lanka's Migrant Housemaids (2000) and Breaking the Ashes: The Culture of Illicit Liquor in Sri Lanka (2008).

Correction needed for raw affiliation Professor of anthropology at Portland State University. She is the author of The Kitchen Spoon's Handle: Transnationalism and Sri Lanka's Migrant Housemaids (2000) and Breaking the Ashes: The Culture of Illicit Liquor in Sri Lanka (2008).
raw_affiliation_name: Professor of anthropology at Portland State University. She is the author of The Kitchen Spoon's Handle: Transnationalism and Sri Lanka's Migrant Housemaids (2000) and Breaking the Ashes: The Culture of Illicit Liquor in Sri Lanka (2008).
new_rors: 00yn2fy02
previous_rors:
works_examples: W2066972628
contact: 4cded0c1c9311ff2572715337538bbd0:c6b70432 @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


[Request] Customize name of Replicache tables

It would be great if we could easily provide custom names for the Replicache internal tables. For instance the "space" table clashes with a table name I'm already using. Right now I'm forking the lib just so I can change the hardcoded table names.
Thank you!

In the meantime maybe add a prefix to the Replicache tables such as "repli_space"?

I agree that it makes sense to prefix the tables with e.g., replicache_. Would you be open to providing a PR for this.

Same issue here and I have 2 PRs coming your way for this (one for the nextjs backend and one for express).


I have fixed some typos in the guidelines

I should have rebased the branch, and there should't be conflicts right now

There are 10 commits but you basically did only 1 more then main

That's right, i'll create a new PR then, because i messed up some stuff i guess


Namespace errors for Home and WebPage

Do we need both:
@using ContentModels = Umbraco.Cms.Web.Common.PublishedModels;
@using Umbraco.Cms.Web.Common.PublishedModels;

@deanleigh No we dont, basically the @using ContentModels option just provides a shortcut and cleans up the code in the view instead of using the long name version.

Now we are using Models builder which @using should we use?

I would use @using ContentModels = Umbraco.Cms.Web.Common.PublishedModels; for clarity


run rancher agent with userns=host when usernamespace is enabled

My docker is configured with users namespace.
To get privileged, we can add userns flag when run docker. Is disable for this container user namespace
`
docker run --userns=host --privileged
when I run docker-agent to add an host, the container launch multiple container agents (health, vps, scheduler, ...), but this option is not set in run.sh inside container
To solve the issue, I will have to build my own image.
It's good be a good solution to allow a extra flag in rancher-agent command, and add this to all docker run command executed inside.

Users namespace is a great security feature introduced in docker 1.10.
Adding the extra flag --userns=host everywhere the --privileged flag would allow rancher users to use the namespace feature.

is there any news for this feature ?

Thanks for your report!
With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.
If you think we should keep this issue open, please let me know.

May be this ticket could be done for Rancher 2?

Agreed. Allowing the use of Kernel User Namespaces in Rancher 2.x is a critical security feature, and is one of the top features recommended by several security vendors like Aqua as it helps to prevent root exploits.

My docker is configured with users namespace.
To get privileged, we can add userns flag when run docker. Is disable for this container user namespace
`
docker run --userns=host --privileged
when I run docker-agent to add an host, the container launch multiple container agents (health, vps, scheduler, ...), but this option is not set in run.sh inside container
To solve the issue, I will have to build my own image.
It's good be a good solution to allow a extra flag in rancher-agent command, and add this to all docker run command executed inside.

Hi, I have the same mistake
could you tell me what did you do with run.sh inside the container?

in run.sh, anywhere you have docker run something, you ahve to add the "--userns=host --privileged" options, and should works.


fix: add vendor after version update

What type of PR is this?
/kind cleanup

What does this PR do?

#20  Cleaned up some historical issues and updated the go version used by netdoctor.
This pull request supplements the vendor update.
Which issue(s) does this PR fix?

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

resolve the errors reported by go lint first

resolve the errors reported by go lint first

done


Sequence contains more than one matching element

Have you tried the Dark theme?

@brianhartung yes

(It was funnier in my own head when I typed it but it looks like you interpreted it literally instead of "as if that would fix the issue" as I had intended to imply :)


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
fedf06c -> 3ece40d

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.21.5 -> v1.21.7

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.21.7
Compare Source
Bug Fixes

clear the plan file path only if SkipTestSetup is enabled (#647) (169b0d0)

v1.21.6
Compare Source
Bug Fixes

deps: update gomod (#646) (19f21bf)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

GitHub release
v3.0.0

Your semantic-release bot :package::rocket:


Unit Testing: ListView

Add appropriate testing specification into the repository.
Note: When submitting your PR, this page may be a good guide on how to make it close your issue once the PR is accepted: https://github.com/blog/1506-closing-issues-via-pull-requests

Fixed via #13.


Reuse a resource

If I wanted to use a resource multiple times in different questions, I would upload it multiple times, which is inefficient. Instead, if I could select a resource OR have an option to upload a new one, that would be great!
(by the way: thank you for all of your amazing work on this! it is amazing!)

This is a good suggestion, thanks.
The database is set up to support this, but there's nothing in the web interface for it yet. I don't fancy writing a media library manager myself, so I've been putting it off!


consider collaboration/communication with American Institute for Biological Sciecnes https://www.aibs.org/

see https://www.aibs.org/ .

see also BCoN

and


New Traits for std.traits

Using Kenji Hara's code that was posted in the issue tracker; I guess he just never got around to making a PR?
Adds the following traits:

isType
isFunction
isPropertyFunction
isVariable
isEnum
isFinal

ping @turkeyman

Not quite sure what's going on with the auto tester here.

There's a blast from the past!
It'd certainly be nice to have these in phobos.

The (X...) if(X.length == 1) idiom is rather ugly, and will probably confuse people who are new to D when they see it in the docs - especially since the constraint seems to be missing.
Is there really no cleaner way to do this?
I confess that I haven't come up with anything better yet, but it doesn't seem right to be forced to resort to a variadic parameter, and then constrain it to an exact fixed length.

Maybe doable with overloading:
template isFunction(alias T);
template isFunction(T);

@JakobOvrum added the overloads, but I don't like how it's not DRY, any tips on that?

I guess there's always this:
private template isFunctionImpl(X...)
{
    static if (is(typeof(&X[0]) U : U*) && is(U == function) ||
               is(typeof(&X[0]) U == delegate))
    {
        // x is a (nested) function symbol.
        enum isFunction = true;
    }
    else static if (is(X[0] T))
    {
        // x is a type.  Take the type of it and examine.
        enum isFunction = is(T == function);
    }
    else
        enum isFunction = false;
}

enum isFunction(T) = isFunctionImpl!T;
enum isFunction(alias T) = isFunctionImpl!T;

But honestly, I think we could just stick to the module norm of using T... until issue 9029 is fixed.

I have run into a situation where I could really use these traits again.
Some of these are really hard to detect reliably.

In particular, I need the isFunction and isPropertyFunction ones.
If some of these are controversial, can we split those out into a separate PR so the non-controversial ones can be merged?

@JakobOvrum went back to the original solution because your work around showed isFunctionImpl in the ddoc.
I believe this is ready to go.

@JackStouffer, it's trivial to replace enum isFunction(T) = isFunctionImpl!T; with template isFunction(T) { enum isFunction = isFunctionImpl!T; }

Well, you also mentioned that you preferred the (X...) solution because of that bug ;)

Yes, for a completely different reason.

Ping.  I don't think there's anything blocking this.

ping @JakobOvrum
Any further comments on this? Can we merge yet?

ping @quickfur @JakobOvrum

There are two unanswered comments in the diff but they're really not that critical.
This patch introduces a large number of largely unrelated new symbols in one pass which I think is procedurally suboptimal but it's also true that most of the code here is very trivial. I think we can merge.

I want to know what the justification is for isEnum being true for manifest constants, which has yet to be answered. I can understand adding helper templates like this PR introduces so that they can be fed into other templates, but treating manifest constants like they're enums isn't simply providing a wrapper. It's a deliberate change of behavior from is(T == enum), and I see no reason why it should be different from is(T == enum).
Also, the documentation on these is very sparse, and my first reaction with seeing them is why on earth you'd use them - why are they here rather than just use is expressions? At a glance, they seem to test exactly what some very basic is expressions test - e.g. is(T == enum) and is(T == function). Some of the comments help clarify that, but the documentation sure doesn't. Each trait is documented with a sentence which is basically a long form of its name and a bunch of examples via ddoc-ed unittest blocks. So, really, the only informative part is the examples. The documentation should explain why you would use these traits rather than is expressions - especially when we have basic is expressions which are already intended for what these traits do.

I beefed up the docs as much as possible, but short docs are typical in std.traits, for example:
isAbstractClass: Detect whether T is a an abstract class.
isNestedFunction: Determines whether function f requires a context pointer.

Also fixed one of the comments on the code that I missed.

@jmdavis I guess I could make isEnumType and isEnumConstant and if someone wants the current behavior they could do something like static if(isEnumType!T || isEnumConstant!T).

@JackStouffer +1 for separate isEnumType and isEnumConstant. IMO, in the majority of cases you need one of them, but not the other.

I beefed up the docs as much as possible, but short docs are typical in std.traits

Thanks. Most of the templates in std.traits test for things that require more complicated is expressions, whereas for some of those added here, they're pretty much just wrappers around really basic is expressions, and that immediately raises the question as to why you should use these rather than a basic is expression, which is why I think that the docs for these need to be a bit more descriptive than just a sentence which is basically repeating the name of the trait in sentence form.

I guess I could make isEnumType and isEnumConstant and if someone wants the current behavior they could do something like static if(isEnumType!T || isEnumConstant!T).

That would definitely be better, but it really should be isManifestConstant if we want to be testing for that, though I confess that at the moment, I can't think of why you'd ever want to test for it.  But the key thing is that manifest constants aren't enums, much as they use the enum keyword (for better or for worse), and having stuff in the standard library which treats them as being the same will just add to that confusion.
As for actual enums as opposed to manifest constants, isEnumType would make more sense if it's supposed to be true for an enum type but not for an enum member, whereas if it's supposed to be operate on enum members as well, then it should probably just be left as isEnum but without being true for manifest constants (having an enum member be true with isEnumType would just be confusing IMHO, since it's not a type).

When the objective is usability in places like allSatisfy(<here>, …) then isStruct, isClass and isInterface also make sense.

then isStruct, isClass and isInterface also make sense.

Ok.
I want to clean up some of my other PRs before I return to this.

@JakobOvrum @quickfur @jmdavis I removed isVariable and isEnum from this PR as they are controversial and can be handled in a different PR at a later date.
I believe this PR is now ready to go.

approved with amends

approved with amends

Ping @JackStouffer - did you manage to incorporate the feedback from Andrei?

Addressed comments and added changelog entry. This is ready to go as this has been approved by Andrei.

Ping @jmdavis @JakobOvrum @quickfur

Ping, this has been approved and is ready to go.

Ping @jmdavis @JakobOvrum @quickfur @wilzbach

Removed isPropertyFunction as it was controversial.
Let's get this merged

What about isStruct, isClass, isInterface, ...?

Let's wait for a different PR for those, as Andrei has already approved this.
I'm having a hard enough time merging this as is :)

Ping @jmdavis @JakobOvrum @quickfur
52 days and counting since approval

@JackStouffer only because Andrei approves does not mean any of the mentioned four is required to pull or approve as well. And actually he does want to see some additional changes.

I completely understand that Andrei's approval is not a golden ticket, but it's just a little frustrating that no one is reviewing this. I would agree with not merging this if people found problems, but I have had two documentation nitpicks (including yours) since Andrei signed off on this.

@burner fixed

LGTM

Auto-merge toggled on

Thanks :)


Remove unreachable code

Hello!
I've been building a tool to identify unused code and found Helpy on http://www.opensourcerails.com/.
Each discrete commit outlines removal of unused code, as well as the corresponding commit(s) that led up to it becoming unreachable. I've verified the test suite runs green for each commit; however, I'm obviously not as familiar with the codebase so if there are areas where metaprogramming are involved or integration tests don't cover certain aspects, please let me know and I can adjust.
Thanks!

Thats a really interesting tool, great for removing cruft.  I will take a look at these suggestions.


[Bug]: Why Winston is printing logs (for JSON format) in alphabetical order

🔎 Search Terms
winston printing logs in alphabetical order
The problem
We have made custom transports to print in JSON format.
And we added the metadata using key "additionalInfo"
Previously "addidtionalInfo" was getting printed at the end of the line as it was added to the object in the end.
But now, after updating to 3.7.2 the print is in alphabetical order.
Causing issue in readability in AWS cloudwatch.
Previous:
{
"level": "info",
"message": "Extraction of file completed",
"timestamp": "6/14/2022, 2:34:21 P6",
"customerName": "XYZ",
"fileName": "processor.js",
"methodName": "extractFilesOnS3",
"additionalInfo":
{         "0": [             "DE/Extract/"         ]     }

}
Current:
{
"additionalInfo":
{         "0": [             "DE/Extract/"         ]     }
,
"customerName": "XYZ",
"fileName": "processor.js",
"level": "info",
"message": "Extraction of file completed",
"methodName": "extractFilesOnS3",
"timestamp": "6/14/2022, 2:34:21 P6"
}
What version of Winston presents the issue?
v3.7.2
What version of Node are you using?
v12.18.4
If this worked in a previous version of Winston, which was it?
v3.3.3
Minimum Working Example
No response
Additional information
No response

In general, I'd advise against any parsing/reading that relies on the same-level keys of a JSON object to be in any particular order, though it should be consistent from ES2015.  See e.g. this SO question or this older article for some discussion, including noting the spec change from ES5 to ES6.

Closing as stale and don't perceive this to be an actionable issue.


fix: Paddings and scrolls in Plugin Action Editor

Description
Updates the padding and fixes the unnecessary scrolls renders in the new Plugin Action Editor flow
Fixes #31573
Fixes #37214
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11678843795
Commit: efcc7ef01d188902905e92aa329df2b00eac4f78
Workflow: PR Automation test suite
Tags: @tag.Datasource
Spec: ``
Tue, 05 Nov 2024 06:35:19 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Introduced a new TabbedViewContainer for improved layout in the CommonEditorForm.
Added support for binary file uploads in the PostBodyData component.

Improvements

Enhanced padding and border behavior in the Section component based on the new withoutPadding attribute.
Adjusted minimum height for the .CodeMirror class in the PostBodyData component.

Bug Fixes

Updated tooltip content handling in the DatasourceConfig component for better clarity on invalid entries.

Refactor

Streamlined the RequestTabs component by integrating styles directly into the Tabs component.

/build-deploy-preview skip-tests=true


Pipe attributes should be configurable via Parameters as well

Describe the issue
We are using a delay pipe and want to increase this every for each retry.
The solution for the Delaypipe is to accept a delayTime parameter. Other pipes can also benefit if this was generic functionality.
Reporter
JJVR, Ali

These are some ways this could be implemented that I came up with:
As an attribute
<DelayPipe delayTime="4000">

</DelayPipe>

As a parameter:
Dangerous, because you can accidentally overwrite an attribute without having the intention to do so.
<DelayPipe>
    <Param name="delayTime" value="4000" />
</DelayPipe>

Deliberate, but lacks type safety. A typo could break the configuration.
Typos can be caught when the configuration is loaded, but that sucks for the developer experience.
<DelayPipe>
    <Param name="delayTime" value="4000" attribute="true" />
</DelayPipe>

Deliberate, and also has the added benefit that it can easily be added to the FrankConfig.xsd thus
adding type safety during development to these attribute params.
The name is a bit confusing however.
<DelayPipe>
    <AttributeParam name="delayTime" value="4000" />
</DelayPipe>

Allows complex types, such as dates, but that is not useful, because only primative and enum values can be used in attributes.
<DelayPipe>
    <AttributeParam name="delayTime">
        <NumberParam name="value" value="4000" />
    </AttributeParam>
</DelayPipe>

The order is also an important detail. A parameter should overwrite an attribute. This is because of the following reasons:

An attribute could be used as a backup when no parameter exists
This forces mandatory attributes to always have a value even when no parameters exist, because those are determined at runtime.t a

You can also directly use a NumberParameter instead of wrapping it in an AttributeParam.
Tricky to implement this and it could have nasty side effects, perhaps it should be an opt in action, so an annotation needs to be present on the attribute (setter method)?

Getting the value of an parameter requires the message and pipe line session, which is only available during the doPipe operation (at runtime). There are two ways that the value can be made available to the pipe:

Temporarly overwriting the attributes with reflection. This is a very very bad idea, because thread safety is not guarenteed, and because reflection can behave strange.
Creating a neat function, which accepts the message and session and returns the parameter or attribute. This does mean that we have to manually decide and implement which attributes are modifyable at runtime. This is a good idea in my opinion, because we don't want to give people too much freedom to modify the name or transactionAttribute for example. These are a bit too dangerous to modify on the fly.

The second idea is also very commonly used in the framework to achieve the same result. The goal of this PR can be shifted to standardize this and to maybe also add an annotation, so it is included in the frankdoc that the attribute can be overwritten with an attribute.
My suggestion would be to use the following format for params, which can also serve as parameters. This makes it clear that these are special and that they do not interfere with regular parameters.
<DelayPipe>
    <AttributeParam name="delayTime" value="4000" />
</DelayPipe>


Change the host and port of Agora to the endpoint

Agora's information is entered via the command line parameter in the endpoint rather than the hostname and port (ex http://<IP_ADDRESS>:2826).
Inside the store, it was used separately from the hostname and port.
Therefore, it will not function normally when the protocol is changed.
I changed this so that Agora's endpoint was used as they were inside Stoa. Thus, it may be possible to apply the protocol that may change in the future.

LGTM
However, I think agora_address is more appropriate than agora_endpoint.

Why not pass an URL instead ?

agora_address

How about agora_url?

LGTM
However, I think agora_address is more appropriate than agora_endpoint.

How about agora_url?

Why not pass an URL instead ?

If Matias' suggestion is to convey URL objects created using 'npm module url', that is a good idea.
I intended to simplify coding in 'main.ts'.
Therefore, I tried to organize the parameters with only strings and numbers here.
Internally, AgoraClient uses URL objects to complete the endpoints and request data from Agora.
Therefore, it would be natural to handle it with a string here.
Thank you for your opinion.

Yes, the idea is to use the URL module. Because URL is a structured representation, while strings are not structured.
It's almost always better to pass an URL object than a string (host) + short (port) + string (path).
Also, regarding the naming, I'm personally happy with endpoint.

Yes, the idea is to use the URL module. Because URL is a structured representation, while strings are not structured.
It's almost always better to pass an URL object than a string (host) + short (port) + string (path).
Also, regarding the naming, I'm personally happy with endpoint.

@Geod24 Thank you for your review
I fixed it. I will apply this to other PR.