gradle for aarch64-linux will not run on via qemu-user

Describe the bug
When running gradle for aarch64-linux on x86_64-linux with qemu-user it immediately crashes with org.gradle.api.UncheckedIOException: Could not load properties for module 'gradle-build-cache' from /nix/store/9iy553chxc2gb8w2c4di7f2yinpa70i1-gradle-8.3/lib/gradle/lib/gradle-build-cache-8.3.jar
this makes cross compiling anything that requires gradle impossible
the below can be used for qemu-binfmt
{
  pkgs,
  lib,
  ...
}: let
  inherit (lib.modules) mkForce;
in {
  boot.binfmt = {
    emulatedSystems = ["aarch64-linux"];
    registrations.aarch64-linux = {
      interpreter = mkForce "${pkgs.qemu}/bin/qemu-aarch64";
    };
  };
  nix.settings.extra-sandbox-paths = ["/run/binfmt" "${pkgs.qemu}"];
}

Steps To Reproduce
Steps to reproduce the behavior:
Run: nix run "github:NixOS/nixpkgs?branch=nixos-unstable&rev=f2ea252d23ebc9a5336bf6a61e0644921f64e67c#gradle" --system aarch64-linux -- --help on any linux with qemu binfmt configured for aarch64-linux
Expected behavior
gradle to run and output its help message
Screenshots

Notify maintainers
@lorenzleutgeb
@liff
Metadata
Crashes:
lappy-t495 :: ~ » nix-shell -p nix-info --run "nix-info -m"                                                 1 ↵
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.2, NixOS, 23.11 (Tapir), 23.11.20230914.f2ea252`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - nixpkgs: `/nix/store/kxz698yrnad9csyrsf6sb842ryarss7b-source`

Runs Fine:
raspberry :: ~ » nix-shell -p nix-info --run "nix-info -m"                                                130 ↵
 - system: `"aarch64-linux"`
 - host os: `Linux 6.1.52, NixOS, 23.11 (Tapir), 23.11.20230914.f2ea252`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - nixpkgs: `/nix/store/kxz698yrnad9csyrsf6sb842ryarss7b-source`

Thanks for filing this. Unfortunately, I won't have the bandwidth to fix this anytime soon.


Tom named args

a couple of notes:

there are a few functions that are very close to each other which could be DRYed up (PythonAstConverter::unpackUnnamedArgs and PythonAstConverter::unpackNamedArgs)
I kept the "old" calling convention in a few places. The reasons for that were:
a. we instantiate (fora) classes from python using the FS1 simulator, which (I don't believe) knows about named args.
b. From pyfora clients, we instantiate ComputationDefinition objects, and I didn't know how to set up the right ComputedValues to use named args.
although the change is large, it's mostly because of changes to the pyfora builtins.

Other than that, remember that the basic idea is that

Any python Call expression gets turned into a fora call expression of the form f(@unnamed_args: @unnamed_args, @named_args: @unnamed_args) where the named and unnamed args come from the actual call expression.

Any function definition, for example def f(x, y, z=z_expr) gets turned into the fora function:
let f = fun(@unnamed_args:, @named_args:) {
let x = if (size(@unnamed_args)) {
let elt0 = @unnamed_args[0];
@unnamed_args = @unnamed_args[1,];
elt0
}
else {
match (*@named_args) with (x:elt, rest) {
@named_args = rest
elt
}
(...) {
throw TypeError("couldn't find a match for x')
}
}
let y = if (size(@unnamed_args)) {
let elt0 = @unnamed_args[0];
@unnamed_args = @unnamed_args[1,];
elt0
}
else {
match (@named_args) with (y:elt, rest) {
@named_args = rest
elt
}
(...) {
throw TypeError("couldn't find a match for y')
}
}
let z = if (size(@unnamed_args)) {
let elt0 = @unnamed_args[0];
@unnamed_args = @unnamed_args[1,];
elt0
}
else {
match (@named_args) with (x:elt, *rest) {
@named_args = res
elt
}
(...) {
z_expr
}
}
   // rest of function body
   }

@braxtonmckee: could you make sure this is OK from the fora compiler's perspective?

This looks great!


Ratings filtering issue

Brief Description: On the main Phore search page, the rating is set to 5 stars.  If you change the rating to 1 Star, everything remains to be displayed.  However selecting any other rating at this point leads to no results.  This could be an issue due to the fact there are no ratings yet?
Operating System (OS and version): Windows 10
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:
Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always
Steps to reproduce:

Enter the Phore Marketplace
Click the radio button "One start & Up"
Click any other radio button
All listings are removed "No listings match your search criteria"

Observed Behavior:
Selecting any Rating other than One Star & Up removes all the listings.
Expected Behavior:
If the page loaded at 5 stars, clicking back to it should display all items.
Additional info (links, images, etc go here):  This could be related to issue #33 where perhaps since there are NO ratings at this time, the default filters aren't working well.

Right, if there aren't any ratings, the items default to 1 star. This is expected behavior.


Bump up BuildKit to v0.9.3

Release note: https://github.com/moby/buildkit/releases/tag/v0.9.3

Failed windows test seems unrelated to BuildKit.
--- FAIL: TestRunUserName (0.01s)
    --- FAIL: TestRunUserName/ContainerUser (0.09s)

:eyes:
 --- FAIL: TestIPFSComposeUp (300.20s)
    --- PASS: TestIPFSComposeUp/overlayfs (32.12s)
    --- FAIL: TestIPFSComposeUp/stargz (268.09s)


Wechat keep asking for version upgradation after QR code scanning;unable to login

Hi,
I installed wechat for docker using the following command. It is opening but I am unable to login.

curl -sL https://raw.githubusercontent.com/huan/docker-wechat/master/dochat.sh | DOCHAT_WECHAT_VERSION=<IP_ADDRESS> bash

      |  _ \  ___  / ___| |__   __ _| |_
      | | | |/ _ \| |   | '_ \ / _` | __|
      | |_| | (_) | |___| | | | (_| | |_
      |____/ \___/ \____|_| |_|\__,_|\__|

      https://github.com/huan/docker-wechat

                +--------------+
               /|             /|
              / |            / |
             *--+-----------*  |
             |  |           |  |
             |  |   盒装    |  |
             |  |   微信    |  |
             |  +-----------+--+
             | /            | /
             |/             |/
             *--------------*

      DoChat /dɑɑˈtʃæt/ (Docker-weChat) is:

      📦 a Docker image
      🤐 for running PC Windows WeChat
      💻 on your Linux desktop
      💖 by one-line of command

🚀 Pulling the docker image...

<IP_ADDRESS>: Pulling from zixia/wechat
Digest: sha256:4b9598367a63becd1f3630812056e655eda08c3e9e952ac866a13d5964fbda2d
Status: Image is up to date for zixia/wechat:<IP_ADDRESS>
docker.io/zixia/wechat:<IP_ADDRESS>

🚀 Pulling the docker image done.
🚀 Starting DoChat /dɑɑˈtʃæt/ ...

[DoChat] 盒装微信 v0.11.4
Disabling patch for /home/user/.wine/drive_c/users/user/AppData/Roaming/Tencent/WeChat ...
Disabling patch for /home/user/.wine/drive_c/users/user/Application Data/Tencent/WeChat ...
[DoChat] WeChat <IP_ADDRESS>
[DoChat] Starting...
[1229/103720:INFO:exception_record.cc(518)] [QB]Process ID: 47 Type: 1
[1229/103720:ERROR:network_change_notifier_win.cc(156)] WSALookupServiceBegin failed with: 8

It seems that we should upgrade the WeChat version in DoChat next month...
I hope that I could be able to write a script so that the DoChat will upgrade with the new version whenever the WeChat upgraded.

Thanks for the reply. It seems like a very good initiatives for people like us who do not want to install wine to use the windows version of wechat. Even if there would be a way to access the directory of the docker image through ssh, I guess we could try to update the wechat by downloading the exe file and installing within that system but again I do understand that would be a hassle as docker does not allow persistent storage (from my personal understanding) so once closing the image may need us to do the entire process again. No worries we will wait until you would update with the latest wechat. Thanks again for the contribution. Its not so convenient to use webchat version of wechat in linux (electron-wechat).

I didn't see this window, but my WeChat also exited after scanned the QR code.

[DoChat] Found new version
[DoChat] WeChat.exe exited

System:
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.1 LTS
Release:	20.04
Codename:	focal

$ uname -a
Linux sqybi-PC-Ubuntu 5.4.0-59-generic #65-Ubuntu SMP Thu Dec 10 12:01:51 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Not sure if they are the same problem...

It seems that we should upgrade the WeChat version in DoChat next month...
I hope that I could be able to write a script so that the DoChat will upgrade with the new version whenever the WeChat upgraded.

In the meantime, is there a way to make WeChat upgrade a bit easier for the average Joe (i.e. those who has basic understanding of dockerfile and wine) ?

@kngharv Sorry but I'm afraid that it has not very easy for the average Joe to update the DoChat system because it's very tricky.
However, if you are interested to try to upgrade it, I'd like to help. Please feel free to let me know if you have any questions.


Use single erb template per outcome

Using content_for blocks allow us to combine our title and body templates
into a single template per outcome. We think this is probably easier to manage
right now, and hope that it'll make it easier to add support for next_steps.

 Is the change to generated HTML visible to users or is it only white space that is causing regression tests to fail?

 Is the change to generated HTML visible to users or is it only white space that is causing regression tests to fail?

Indenting the title results in additional whitespace in the rendered outcomes, which isn't really a big deal.
Indenting the body isn't possible/easy as the leading whitespace screws with govspeak/markdown. We could do something nasty like strip the first two spaces but that doesn't seem ideal.

I agree with @tadast that the lack of indenting isn't great, but I think that's a problem that is independent of this PR i.e. the problem is the mixing of markdown/govspeak with ERB.

Other than my small comments, this LGTM :+1:

Manually merged in 3391fc3eaf9030f5b502672e32baf37086844f30.


[SPARK-17379] [BUILD] Upgrade netty-all to 4.0.41 final for bug fixes

What changes were proposed in this pull request?
Upgrade netty-all to latest in the 4.0.x line which is 4.0.41, mentions several bug fixes and performance improvements we may find useful, see netty.io/news/2016/08/29/4-0-41-Final-4-1-5-Final.html. Initially tried to use 4.1.5 but noticed it's not backwards compatible.
How was this patch tested?
Existing unit tests against branch-1.6 and branch-2.0 using IBM Java 8 on Intel, Power and Z architectures

Test build #64938 has started for PR 14961 at commit 38ca07b.

Looks good for master to 1.6

Test build #64938 has finished for PR 14961 at commit 38ca07b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64938/
Test FAILed.

Merged build finished. Test FAILed.

Test build #3246 has started for PR 14961 at commit 38ca07b.

Test build #3246 has finished for PR 14961 at commit 38ca07b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #3247 has started for PR 14961 at commit 38ca07b.

Test build #3247 has finished for PR 14961 at commit 38ca07b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Also many other downstream and upstream applications may also use different version of Netty jar, it would be better to keep stable for these fundamental dependences.

@jerryshao that's a good point though in theory a maintenance release contains no API or behavior changes (that aren't bugs). Let's perhaps not touch 1.6 then to be conservative. Hadoop uses a different major release of Netty. I agree with caution though we also need to be able to get some bug fixes in where necessary.

Thanks, so are we saying netty 4.0.29 can't be upgraded to 4.0.41 without breaking changes? That's not even a minor version change...
On branch 1.6 with the netty change for myself I see 8477 tests, two failures (flaky network events and DateTimeUtilsSuite to UTC timestamp, unrelated to this)
And against master I see 11,148 tests with unrelated failures again (furtherRequestsDelay, hive metastore warehouse dir, executor allocation manager basic functionality, replsuite clone and clean line object)
I'm using two maven commands to first build and then run
mvn -T 1C ${R_PROFILE} -Pyarn -Phadoop-${HADOOP_VERSION} -Phive -Phive-thriftserver -DskipTests -Dscala-$SCALA_VERSION clean package

mvn -Pyarn -Phadoop-${HADOOP_VERSION} -Phive -Phive-thriftserver -Dscala-$SCALA_VERSION -Dtest.exclude.tags=org.apache.spark.tags.DockerTest ${TESTS_RUN_OPTIONS} -fn test

In this case the profiles used are for Hadoop 2.6, Scala 2.10 on branch-1.6 then Hadoop 2.7 and Scala 2.11 for branch-2.0, no additional test run options. Therefore I think it's all about the Hadoop version we use because in the community job I see:
**-Phadoop-2.3** -Phive -Pyarn -Pmesos -Phive-thriftserver -Pkinesis-asl -Dtest.exclude.tags=org.apache.spark.tags.ExtendedHiveTest,org.apache.spark.tags.ExtendedYarnTest test

If this is the case then surely we actually should not upgrade the version of Netty until we either drop support for Hadoop 2.3 and below (and perhaps we see the problem in 2.4 too) or make the necessary changes in our Spark codebase to address issues seen in the above jobs using Hadoop 2.3.

Are you saying thousands of tests fail with certain Hadoop versions and this version change? That's hard to believe. I'd be very surprised if this caused a test failure. However I do see this PR fail a Hive test, and that's failed twice. It could still be unrelated.

In the description I mentioned that for testing I used "Existing unit tests against branch-1.6 and branch-2.0 using IBM Java 8 on Intel, Power and Z architectures", so clarifying that I only used Hadoop 2.6 and Hadoop 2.7, but I see in the pull request builder we use Hadoop 2.3 and a dozen failures happened

Test build #3249 has started for PR 14961 at commit 38ca07b.

Hm, I see just one in the PR builder here, really. And it's different from run to run so this could well be spurious. Re-running tests one more time here.

Thanks, I did a ctrl-f for "** fail", you'd have a better idea of what the known flakies are in this farm though, my quick checking:

using external shuffle service -> looks to be a timeout

These six mention a stopped Spark context (perhaps the previous test doesn't clean up properly and causes this):

kryo objects are serialised consistently in different processes *** FAILED *** (1 minute) -> never seen

cluster mode, FIFO scheduler *** FAILED *** (1 minute) -> never seen

cluster mode, fair scheduler *** FAILED *** -> never seen

verify that correct log urls get propagated from workers *** FAILED *** (1 minute) -> never seen

verify that log urls reflect SPARK_PUBLIC_DNS (SPARK-6175) *** FAILED *** (1 minute) -> never seen

task throws not serializable exception *** FAILED *** (1 minute) -> never seen

simple groupByKey *** FAILED *** (1 minute) [info]   java.lang.NullPointerException:
[info]   at org.apache.spark.SparkContext.(SparkContext.scala:552) > different causes now, never seen

onTaskGettingResult() called when result fetched remotely *** FAILED *** (135 milliseconds) -> never seen

set spark.sql.warehouse.dir *** FAILED *** (5 minutes, 0 seconds) -> never seen

set hive.metastore.warehouse.dir *** FAILED *** (10 seconds, 552 milliseconds) -> never seen

Test build #3249 has finished for PR 14961 at commit 38ca07b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Hm, no I take it back, it's a consistent failure that doesn't show up in the main test builds (for any Hadoop version):
[info] - using external shuffle service *** FAILED *** (1 minute, 33 seconds)
[info]   org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 4 times, most recent failure: Lost task 0.3 in stage 0.0 (TID 11, localhost): java.io.IOException: org.apache.spark.storage.BlockFetchException: Failed to fetch block after 1 fetch failures. Most recent failure cause:
[info] 	at org.apache.spark.util.Utils$.tryOrIOException(Utils.scala:1260)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast.readBroadcastBlock(TorrentBroadcast.scala:174)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast._value$lzycompute(TorrentBroadcast.scala:65)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast._value(TorrentBroadcast.scala:65)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast.getValue(TorrentBroadcast.scala:89)
[info] 	at org.apache.spark.broadcast.Broadcast.value(Broadcast.scala:70)
[info] 	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:72)
[info] 	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:47)
[info] 	at org.apache.spark.scheduler.Task.run(Task.scala:86)
[info] 	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:274)
[info] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[info] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[info] 	at java.lang.Thread.run(Thread.java:745)
[info] Caused by: org.apache.spark.storage.BlockFetchException: Failed to fetch block after 1 fetch failures. Most recent failure cause:
[info] 	at org.apache.spark.storage.BlockManager.getRemoteBytes(BlockManager.scala:567)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$org$apache$spark$broadcast$TorrentBroadcast$$readBlocks$1.apply$mcVI$sp(TorrentBroadcast.scala:136)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$org$apache$spark$broadcast$TorrentBroadcast$$readBlocks$1.apply(TorrentBroadcast.scala:125)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$org$apache$spark$broadcast$TorrentBroadcast$$readBlocks$1.apply(TorrentBroadcast.scala:125)
[info] 	at scala.collection.immutable.List.foreach(List.scala:381)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast.org$apache$spark$broadcast$TorrentBroadcast$$readBlocks(TorrentBroadcast.scala:125)
[info] 	at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$readBroadcastBlock$1.apply(TorrentBroadcast.scala:186)
[info] 	at org.apache.spark.util.Utils$.tryOrIOException(Utils.scala:1253)
[info] 	... 12 more
[info] Caused by: org.apache.spark.SparkException: Exception thrown in awaitResult:
[info] 	at org.apache.spark.util.ThreadUtils$.awaitResult(ThreadUtils.scala:194)
[info] 	at org.apache.spark.network.BlockTransferService.fetchBlockSync(BlockTransferService.scala:104)
[info] 	at org.apache.spark.storage.BlockManager.getRemoteBytes(BlockManager.scala:556)
[info] 	... 19 more
[info] Caused by: java.io.IOException: Connection reset by peer
[info] 	at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
[info] 	at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
[info] 	at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
[info] 	at sun.nio.ch.IOUtil.read(IOUtil.java:192)
[info] 	at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
[info] 	at io.netty.buffer.PooledUnsafeDirectByteBuf.setBytes(PooledUnsafeDirectByteBuf.java:221)
[info] 	at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:899)
[info] 	at io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:275)
[info] 	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:119)
[info] 	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
[info] 	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
[info] 	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
[info] 	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
[info] 	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
[info] 	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
[info] 	... 1 more
[info]

The rest are knock-on errors.
Clearly something to do with the block fetcher no longer quite working, or maybe failing to start. If you want to debug it I'd maybe scan mvn dependency:tree to see if somehow this updated only one of several netty artifacts and we somehow have a mismatched set now. (You will see Netty 3 artifacts from Hadoop but the question is whether something is stuck on 4.0.29).

I saw the error in the log:
16/09/05 08:21:56.758 shuffle-server-593-8 WARN TransportChannelHandler: Exception in connection from /<IP_ADDRESS>:44788
io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 16777216 byte(s) of direct memory (used:<PHONE_NUMBER>, max:<PHONE_NUMBER>)
	at io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:528)
	at io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:482)
	at io.netty.buffer.PoolArena$DirectArena.allocateDirect(PoolArena.java:688)
	at io.netty.buffer.PoolArena$DirectArena.newChunk(PoolArena.java:677)
	at io.netty.buffer.PoolArena.allocateNormal(PoolArena.java:237)
	at io.netty.buffer.PoolArena.allocate(PoolArena.java:213)
	at io.netty.buffer.PoolArena.allocate(PoolArena.java:141)
	at io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:271)
	at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:177)
	at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:168)
	at io.netty.buffer.AbstractByteBufAllocator.ioBuffer(AbstractByteBufAllocator.java:129)
	at io.netty.channel.AdaptiveRecvByteBufAllocator$HandleImpl.allocate(AdaptiveRecvByteBufAllocator.java:104)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:117)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
	at java.lang.Thread.run(Thread.java:745)

Seems some configuration in netty has been changed and caused the failure?

Aha, possibly this:
https://groups.google.com/forum/#!topic/netty/3BoF7q34Z4I
Is the lesson here to not bother with pooling and use the UnpooledByteBufAllocator?

Is the lesson here to not bother with pooling and use the UnpooledByteBufAllocator?

Not sure. Pooling is for improving the performance because allocating direct buffers is pretty slow.

I think we can binary search the first broken netty version. It would be easy to find out the real issue.

Hm, I can't get this test to fail with Netty 4.0.41 when I 'mvn install' and run the test suite locally. I'm having a hard time seeing what could alleviate the failure.
I suspect that this change might be relevant: https://github.com/netty/netty/commit/1a9ea2d349c42f7c7ccb56daea29f083ee60870e#diff-23eafd00fcd66829f8cce343b26c236a
In any event, we ideally want to fix-forward and find a way to work with the current version, unless we have reason to believe it's an unresolved bug (and we don't have a pressing bug fix we need to ingest).
I suppose one hacky way to test the theory above is to push a commit here that sets this in NettyUtils:
  static {
    System.setProperty("io.netty.recycler.maxCapacity", "0");
  }

... or post a change that tries the UnpooledByteBufAllocator to see how that behaves.
It may not be worth it if it's hard to get this working, but, if it's not really a Netty bug but a behavior change, we'll eventually have to sort this out.

I'm not familiar with netty's Recycler. But the default value of io.netty.recycler.maxCapacity is 262144. This seems too big for Spark anyway. I don't think we need to cache 260k objects.

I suppose one hacky way to test the theory above is to push a commit here that sets this in NettyUtils:

Let's add it in TransportConf so that it's easy to find since it's the place of the network configs.

In addition, I think we should figure out why upgrading the netty version will fail. The issue about Recycler seems also in 4.0.29.Final. Is it because netty starts to track the memoryprint since https://github.com/netty/netty/commit/62655c00a93a3c4c9e421fabbf5991c19dfb4161#diff-8d83d75ebf8a18cc48bf0a0b1183c188 or there is a new issue introduced by the new netty version?

@a-roberts are you in a position to add this change to this PR as an experiment? I can try it on the side too. I can't seem to reproduce the failure locally, even when fully rebuilding the project with a newer netty.

Sean, yep, I've had trouble reproducing it too, kicked off a bunch of builds over the weekend including one using Hadoop-2.3 which was my initial theory (only difference between our testing environments apart from the options I mention below)
I'll add
  static {
    System.setProperty("io.netty.recycler.maxCapacity", "0");
  }

in TransportConf then build and test locally before updating this.
FWIW I use these Java options for testing as our boxes have limited memory:
-Xss2048k -Dspark.buffer.pageSize=1048576 -Xmx4g

No new test failures with my runs ranging from Hadoop 2.3 to Hadoop 2.7 today so pushed the commit above

Test build #65264 has started for PR 14961 at commit 502ebf4.

Test build #65264 has finished for PR 14961 at commit 502ebf4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65264/
Test FAILed.

Test build #3256 has started for PR 14961 at commit 502ebf4.

Test build #3256 has finished for PR 14961 at commit 502ebf4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

[info] - using external shuffle service *** FAILED *** (1 minute)
[info]   java.util.concurrent.TimeoutException: Can't find 2 executors before 60000 milliseconds elapsed
60 seconds really is an eternity, I can't reproduce this on my local set up, I expect we've got deadlock going on after the upgrade and would require some proper debugging (again, if only I could reproduce it on my test systems with access to tools like gdb/healthcenter/servicing APIs we use here). My systems have between two and eight cores and I know this farm has a lot more available...could be that having more cores increases the chances of thread contention.
I had a look at other pull requests being tested and see it typically completes in 3 seconds on a good run
using external shuffle service (3 seconds, 822 milliseconds)
at https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3258/consoleText
using external shuffle service (4 seconds, 543 milliseconds)
https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3233/consoleText

OK, so same failure with this change. Hm. I don't think it's that something is just slow but that the error in https://github.com/apache/spark/pull/14961#issuecomment-245090209 causes netty to never start at all.
A next step would be to try modifying the code to use the Netty unpooled buffer? just to see if that avoids the issue?

Yep that makes more sense, UnpooledByteBufAllocator usage coming up

Had a look to see how to do this
https://github.com/netty/netty/blob/a01519e4f86690323647b5db45d9ffcb184b1a84/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
so I'll add io.netty.allocator.type to be unpooled, will make this change in TransportConf again (removing the recycler experiment)

Test build #65322 has started for PR 14961 at commit faefd9c.

Test build #65322 has finished for PR 14961 at commit faefd9c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65322/
Test FAILed.

Still saw the following errors in the unit-test log:
16/09/13 07:41:18.817 shuffle-server-466-7 WARN TransportChannelHandler: Exception in connection from /<IP_ADDRESS>:36871
io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 16777216 byte(s) of direct memory (used:<PHONE_NUMBER>, max:<PHONE_NUMBER>)
    at io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:528)
    at io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:482)
    at io.netty.buffer.PoolArena$DirectArena.allocateDirect(PoolArena.java:688)
    at io.netty.buffer.PoolArena$DirectArena.newChunk(PoolArena.java:677)
    at io.netty.buffer.PoolArena.allocateNormal(PoolArena.java:237)
    at io.netty.buffer.PoolArena.allocate(PoolArena.java:213)
    at io.netty.buffer.PoolArena.allocate(PoolArena.java:141)
    at io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:271)
    at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:177)
    at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:168)
    at io.netty.buffer.AbstractByteBufAllocator.ioBuffer(AbstractByteBufAllocator.java:129)
    at io.netty.channel.AdaptiveRecvByteBufAllocator$HandleImpl.allocate(AdaptiveRecvByteBufAllocator.java:104)
    at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:117)
    at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
    at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
    at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
    at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
    at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
    at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
    at java.lang.Thread.run(Thread.java:745)

Seems the error cannot be reported correctly in Jenkins.

@a-roberts could you binary search the first broken netty version? Since this cannot be reproduced locally, you have to push new commits.

Oh, the allocator is set here: https://github.com/apache/spark/blob/master/common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java#L95

Hm, I can reproduce the same error using this command build/sbt "project core" "test-only *Shuffle*" locally. The first broken version is 4.0.37.Final.

Confirmed the issue was introduced by https://github.com/netty/netty/commit/d58dec8862e02fc2a98f8dcdb166db4b788be50a#diff-8d83d75ebf8a18cc48bf0a0b1183c188
Add System.setProperty("io.netty.maxDirectMemory", "0"); to disable this feature then the tests pass.

Test build #65361 has started for PR 14961 at commit 8f6783b.

Thanks @zsxwing, I've removed our older experiments in favour of this one
For future reference here is the context of how that option is used: https://github.com/netty/netty/blob/e7449b1ef361c55457ed21d44d6ed8387ec1fa45/common/src/main/java/io/netty/util/internal/PlatformDependent.java

Nice research here. So that's probably the only real way to set this property? it has to be a system property I guess and this should fire before the classes in questions init as far as I can see.
@zsxwing you seem to understand this better, but is it that the default behavior changes and is probably a bad default now, or just that it's inappropriate for Spark?

Test build #65361 has finished for PR 14961 at commit 8f6783b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65361/
Test PASSed.

For future reference here is the context of how that option is used: https://github.com/netty/netty/blob/e7449b1ef361c55457ed21d44d6ed8387ec1fa45/common/src/main/java/io/netty/util/internal/PlatformDependent.java

Thanks! I just found I posted a wrong link :(. Fixed the link in my previous comment.

@zsxwing you seem to understand this better, but is it that the default behavior changes and is probably a bad default now, or just that it's inappropriate for Spark?

I don't have a theory now. But I guess we never release direct buffers created by Netty and count on GC to release them. As per the following description in this commit,

Add new buffer implementations that can be enabled with a system flag as optimizations. In this case no Cleaner is used at all and the user must ensure everything is always released.

we need to disable using the no cleaner direct buffers, or fix all leaking places.

OK, I think this is a good change. Maybe to be conservative we'll only put this in master.

Agreed. I'm going to merge to master. Thanks!

FYI, finally, I figured out the root cause: https://github.com/netty/netty/issues/5833
As far as I understand, System.setProperty("io.netty.maxDirectMemory", "0"); should be a correct workaround.


Detect python instead of using hardcoded value for python executable

This PR replaces the use of hardcoded python with a proper detection of Python with CMake. The main reason for this is that Fedora buildroots don't have /usr/bin/python but they do have python3.
Status

[x] Ready for merge

It makes senses to use CMake's system to detect the Python executable name/path. I actually ran into this issue on one of the GHA Runner environments, and I ended up using an Action to create a more standardized Python environment. This is a more general and portable fix, and I should probably go back and revert my CI script to use the default Python environment at some point.


Convert timestamp to number for arithmetics

Whenever a timestamp is used in arithmetics, e.g. ts + 1 or ts / 1.0, we
previously operated in the timestamp domain. This led to problems because we
converted long/double to timestamp. Longs are converted by interpreting them as
milliseconds, whereas Doubles are converted as seconds with milliseconds as
fraction. For example:
1.0 would be interpreted as 1000
1   would be interpreted as 1
The solution is to treat the timestamp as long and cast it to other data types
when necessary. The result of an arithmetics with a timestamp, will never be a
timestamp but a number data type. Only when functions accept timestamps as the
direct argument, the special double conversion will be performed.

tests are failing?

Codecov Report

Merging #6552 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #6552      +/-   ##
============================================
+ Coverage     82.94%   83.11%   +0.17%
- Complexity    13114    13127      +13
============================================
  Files          1504     1504
  Lines         48756    48756
  Branches       5878     5878
============================================
+ Hits          40439    40524      +85
+ Misses         5545     5463      -82
+ Partials       2772     2769       -3

Impacted Files
Coverage Δ
Complexity Δ

core/src/main/java/io/crate/types/DataType.java
89.13% <ø> (-0.24%)
17 <0> (ø)

...re/src/main/java/io/crate/types/TimestampType.java
100% <ø> (ø)
12 <0> (-1)
:arrow_down:

core/src/main/java/io/crate/types/DataTypes.java
94.18% <100%> (ø)
42 <0> (ø)
:arrow_down:

...va/io/crate/operation/scalar/ExtractFunctions.java
85.13% <100%> (+0.3%)
14 <1> (ø)
:arrow_down:

core/src/main/java/io/crate/types/LongType.java
82.45% <100%> (+0.31%)
28 <1> (+1)
:arrow_up:

...eration/scalar/arithmetic/ArithmeticFunctions.java
78.48% <100%> (-0.54%)
25 <0> (ø)

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...c/main/java/io/crate/exceptions/SQLExceptions.java
69.09% <0%> (-2.73%)
37% <0%> (-2%)

...ration/collect/collectors/LuceneBatchIterator.java
90.1% <0%> (-1.1%)
37% <0%> (-1%)

...ecutor/transport/SnapshotRestoreDDLDispatcher.java
87.3% <0%> (-0.8%)
13% <0%> (ø)

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0637f0e...32ff693. Read the comment docs.

Sorry, passing now.


User engagement analysis

Now that's we've finished our user engagement, what did we learn and what can we share?

[x] Complete analysis of user feedback
[x] Rollup of feedback
[x] Share out

Hey @NicoleGovvy - anything left to do on this or do you think it's almost good to close? Thanks!

@patriciarussellCAS I think just sharing the findings then we're good. This can be a small group - I might even just post in the Giraffe design chat.

Business area follow-up
Advanced guidance/notice if possible for changes to help operators with setting up their own systems/spreadsheets to get ready for reporting
Features we have tickets for OR are in the user story map
Download in-progress/submitted reports in multiple formats (#144, #149)
View historical reports (I swear this has a ticket but can't find it)
Bulk upload feature (#133)
Would like ability to view/download before submitting #144, #201)
See completion status (#186)
Version history table for operators: see date, name, reason (#178)
View aggregate LFO summary for all facilities (#202)
User story map, no ticket:
Confirmation after submission via email
Submit a correction to a report
General opportunities (not feature-specific)
Clear terminology (site/facilities were being mixed up)
Provide system guidance
Auto-populate as much as possible
Features for consideration
Submission notifications or correction requests: ability to designate who receives these or by default have these sent to the system users (not an executive)
Transparency in calculations - have info on what the math is so it can be reproduced by the operator
Ability to override calculations
(post-post-post-post-post-post MVP) Ideally would like to select and compare multiple rows of data to each other (compare a specific year to another)


iphone XS/XS Max/XR missing models

The entries for iphone xs/xs max/xr do not have any models so none of those iphones are included in the all variable in index.js. Thus the following does not return any results:
    deviceByInternalName("D331pAP")

The issue being that all is constructed by iterating over device models.
All the models are available on the wiki: https://www.theiphonewiki.com/wiki/Models

done


[#5157]fix: User can specify the krb5 conf file path for Kerberos enabled Hadoop catalog

What changes were proposed in this pull request?
User can specify the krb5 conf file path for Kerberos enabled Hadoop catalog.
Why are the changes needed?
Fix: #5157
Does this PR introduce any user-facing change?
Add a property key java.security.krb5.conf for Kerberos enabled Hadoop catalog.
How was this patch tested?
Create a Hadoop catalog for Kerberos enabled HDFS, you can put krb5.conf in any readable path of Gravatino host, and add the config java.security.krb5.conf=/X/krb5.conf , then the Hadoop catalog can be created succeed and all works well.

krb5 conf can't be config option of the catalog. System.properties() can't be isolated with the class loader.


Dispatch doesn't enable the same file to be used across multiple dispatch intents

Tool
Dispatch
Version: 1.3.0
OS: Windows 10
Describe the bug
We would like to use the same calendar.luis source file across multiple dispatch intents, e.g.:
dispatch add -t file -n calendarSkill/createEvent -f calendar.luis --includeIntents CreateCalendarEntry,FindMeetingRoom -intentName calendarSkill/createEvent
dispatch add -t file -n calendarSkill/changeEventStatus -f calendar.luis --includeIntents AcceptEventEntry,DeleteCalendarEntry -intentName calendarSkill/changeEventStatus

However Dispatch reports that the source file has already beeen added to dispatch:

To Reproduce
Steps to reproduce the behavior:

... Run above commands with attached calendar.luis file

calendar.zip
Expected behavior

Dispatch to accept the same source file for different dispatchIntents / names providing the intents don't overlap.

[bug]

This is merger to master.  @darrenj, you should be able to get it from myget when daily build is deployed.


The vite sever cannot be accessed in docker

Describe the bug
a service visite the vite dev server. the result is 404. react-script and vue-service is ok。
Reproduction
nothing
System Info
System:
    OS: Windows 10 10.0.19043
    CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor
    Memory: 6.82 GB / 23.95 GB
  Binaries:
    Node: 14.17.5 - C:\Program Files\nodejs\node.EXE
    npm: 6.14.14 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (95.0.1020.40)
    Internet Explorer: 11.0.19041.1202

Used Package Manager
npm
Logs
vite

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I had a similar issue, changing the start script from vite to vite --host <IP_ADDRESS> helped.
(https://vitejs.dev/config/#server-host)


feat(CategoryTheory/Sites): categories of sheaves are Grothendieck abelian

If J is a Grothendieck topology on a small category C : Type v, and A : Type u₁ (with Category.{v} A) is a Grothendieck abelian category, then Sheaf J A is a Grothendieck abelian category.

[x] depends on: #19979
[x] depends on: #18510

Thanks very much @dagurtomas for the reviews!


excessive retries in CreateOffer - Single Port

I'm receiving excessive retries in CreateOffer error when using the ice single port option.
The only thing that is different than the example is that instead of only datachannel i'm also creating a video and audio stream and the backend is creating the offer instead of the frontend.
Couldn't find anything more specific about why this is occuring

Hi @Chimerax2 !
That is happening because you aren't using a MediaEngine. Pion attempts to create the Offer, but has no codecs (and keeps attempting to generate).
You will want to do something like this
Just exclude these lines if you aren't interested in Simulcast.
Please re-open if that doesn't help!


Windows still needs pyreadline3 after pip install

After pip install asteroid-lang on a Windows system, attempting to start asteroid reports ModuleNotFoundError: No module named 'pyreadline3'. @lutzhamel believes it may need to be added to setup.py as well as having already been added to requirements.txt.

Hey @davidhbrown-uri ! Long time no see, I took 301 and 305 with you a few years ago!
It looks like the method of how Python software packages should specify what their build dependencies are has changed with PEP 517/518 .
pyproject.toml is the newer format.
setup.py is the older format.
Depending on what version of pip you are using you might get a different behavior here. With newer versions the installer will recognize the pyproject.toml file and use the meta data contained within to set up and execute installation. If this happens, any setup.py file and data contained within will be ignored. This is what was happening to Professor Brown.
If you have an older pip version that does not recognize the PEP517/518 standard it will use the setup.py file for installation and ignore the pyproject.toml file.
I've gone ahead and updated both of these installation meta-data files to be up to date and consistent.

@TimColaneri  (Hello again! I'm catching up on asteroid as I'll be teaching the second section of CSC 301 this semester.)
Thank you for your knowledge of how python is packaged these days. In general, time has not been kind to PEP 20's idea that "there should be one -- and preferably only one -- obvious way to do it."


Kill child process in test

Oops, I was trying to open a PR in my own fork to test stuff out. Jesus GitHub..


system-wide autotype does not work

Installed goldwarden from the AUR
following https://github.com/quexten/goldwarden/wiki/System‐wide-Autotype
I cant get dbus-send --type=method_call --dest=com.quexten.Goldwarden.autofill /com/quexten/Goldwarden com.quexten.Goldwarden.Autofill.autofill
tested trying to get my password for google  with goldwarden logins get www.google.com and that works so Goldwarden seems to be accessing my bitwarden account fine
systemctl --user status goldwarden.service
● goldwarden.service - "Goldwarden daemon"
     Loaded: loaded (/home/zany130/.config/systemd/user/goldwarden.service; enabled; preset: enabled)
     Active: active (running) since Thu 2023-12-28 19:22:22 EST; 1min 24s ago
   Main PID: 796781 (goldwarden)
      Tasks: 17 (limit: 38363)
     Memory: 80.4M (peak: 2.0G)
        CPU: 7.039s
     CGroup<EMAIL_ADDRESS>             └─796781 /usr/bin/goldwarden daemonize

Dec 28 19:23:30 Garuda-Linux goldwarden[796781]: [INF] [19:23] [Goldwarden > Keyring] >>> Unlocking keyring with account key
Dec 28 19:23:30 Garuda-Linux goldwarden[796781]: [INF] [19:23] [Goldwarden > Bitwarden API] >>> Clearing vault...
Dec 28 19:23:30 Garuda-Linux goldwarden[796781]: [INF] [19:23] [Goldwarden > Bitwarden API] >>> Adding 560 ciphers to vault...
Dec 28 19:23:30 Garuda-Linux goldwarden[796781]: [INF] [19:23] [Goldwarden > Systemauth] >>> Checking permission for goldwarden with session type com.quexten.goldwarden.accessvault
Dec 28 19:23:30 Garuda-Linux goldwarden[796781]: [INF] [19:23] [Goldwarden > Systemauth] >>> Permission granted from cached session
Dec 28 19:23:30 Garuda-Linux goldwarden[796781]: [INF] [19:23] [Goldwarden > Pinentry] >>> Asking for approval |Approve Credential Access|zany130 on alacritty>fish>goldwarden is trying to access credentials for u>
Dec 28 19:23:30 Garuda-Linux goldwarden[796781]: [INF] [19:23] [Goldwarden > Websocket] >>> Connected to websocket server...
Dec 28 19:23:33 Garuda-Linux goldwarden[796781]: [WRN] [19:23] [Goldwarden > Websocket] >>> Invalid message received, length too short
Dec 28 19:23:33 Garuda-Linux goldwarden[796781]: [INF] [19:23] [Goldwarden > Pinentry] >>> Got approval from user
Dec 28 19:23:39 Garuda-Linux goldwarden[796781]: [WRN] [19:23] [Goldwarden > Websocket] >>> Invalid message received, length too short

Thanks for reporting the issue. Autotype is currently only available when running the Flatpak (or by running the python ui manually). The daemon does not need to run in the Flatkpak, so running as a systemd service is fine, but you do need to have have the Flatpak (or just the ui/main.py) running in some way. I'm working to get the Flatpak published on Flathub to make installation easier, but in the meantime you can find the latest Flatpak build here:
https://github.com/quexten/goldwarden/actions/runs/7352949205
I have also updated the Wiki to inform about this.
(Also, beware that running outside of the Flatpak is not super well tested at the moment, so Flatpak is the easier route)

Ah ok, thanks I was using the AUR package (should have mentioned it) so the flatpak is the preferred method?

Since the flatpak/ui was only implemented last week or so, I haven't had time to think about how to distribute it yet. On the one hand, many users might prefer just having the single go binary without any further dependencies, on the other, installing the UI version from the AUR would also be nice. But then, different mechanisms for automatically starting on boot would have to be used. I'll think about this.

FWIW I tried getting the main.py under the ui folder working locally on my system but had issues trying to get the python deps installed. Specifically tendo, there doesn't seem to be an arch package for that.
So it may just be easier to just have it flat packed and the cli portion available through the aur.
that's what I am doing now didn't realize you can use both together


chore(jasmine-given): support for jasmine-core 4

Updated project dependencies to work with latest jasmine
fix #9

Thanks @WynieCronje !
did you run yarn test from the root of the project?

I tried running yarn test in root had buggy behaviour. (I'm using project level yarn)
So I ran yarn test:jasmine and yarn test:jest separately.
The action seemed to fail on Authentication level (assuming to npm)

Let me fix that real  quick

@WynieCronje
BTW, what do you mean by "buggy behavior" on yarn test ?

@WynieCronje
BTW, what do you mean by "buggy behavior" on yarn test ?

No tests ran. And some updates were happening in the terminal when saving files

@all-contributors please add @WynieCronje for code, tests, maintenance


About CollapsingHeader's

Quick question - is there a way for collapsing headers to be enabled quite like the bool on button? I am running into a problem where I would not like the content within a header rendered until, for lack of a better comparison, .clicked() is enabled. I quite like the implementation of buttons but am curious on how to not .show() a collapsing header until an action. With cascading tree structures of collapsing headers with a lot of information, implementations get slow quickly as the calls are recursively generating headers. Yes - this is more an implementation detail that is user error - BUT I think that having an action on headers would be a life saver for people.
Sorry for my bad question/comment - I am new to the library.

Just to make sure I understand the question: You'd like to control whether or not a CollapsingHeader is collapsed/expanded based on a bool you pass to CollapsingHeader and ignore any clicks on the CollapsingHeader?
If that is what you mean: that is not currently supported, but it is a good idea and something I can add pretty quickly.

Thanks for getting back so fast and for making an amazing library!
So adding onto what you said - yes that would be an amazing addition. I was thinking more along the lines of unless header clicked, do not render ui elements ( .show() ). This could be a simple label or more complex structures. Hopefully that makes it a bit more clear.

Closed by https://github.com/emilk/egui/issues/174


Package request: Tilde (Text Editor for the Terminal)

Package request: Tilde (Text Editor for the Terminal)
https://github.com/gphalkes/tilde

@boustanihani the project seems to be abandoned (last commit was 2 years ago)


Event Card Descriptions Links Outside Card On Mobile

@CanopusFalling I would like to work on this issue assigned to me.

Sure thing! Feel free to submit a merge request to development when your done and ask for more details about this issue. I'll assign it to you now @thezeeshann

@CanopusFalling I'm trying to run the project but got an error (Google API key is not defined) can you give me the API key?

@thezeeshann If you move to the development branch there are instructions for how to run the project in the README. These changes haven't been pushed to the main branch yet.
Here is the section about how to set up the key:

Create a copy of .env.local.sample and name it .env.local.
Replace [Google-Calendar-API-Key] with your google API key. The API key must have the calendar API enabled. Instructions to obtain a Google API key.

@CanopusFalling I have fixed this issue.

@thezeeshann Amazing! If you want to submit a pull request into the development branch of this repository I'll review and merge those changes asap.

@CanopusFalling okay great. I have tested this project it is working perfectly on all devices.


Create Avatar Rotator sock_module for @sockbot

Create a sock_module that allows sockbot to cycle through a set of predefined avatars, either randomly or in sequence and on a configurable schedule(possibly even randomizeable)

obsolete


[BUG] Fix computation of welch's PSD when the number of jobs exceeds the number of channels

Closes #11297
cc @mmagnuski

please add a test with n_jobs=-1
thank you.

@sam-s n_jobs=-1 will spawn as many workers as there are cores, which on CI is probably 2 anyway (depends on the CI provider).
And to explain the issue and the fix, the input to the // function is split on the channel axis by the number of workers. For instance, if you have 4 channels and 2 workers, both will receive 2 channels. If you have 4 channels and 4 workers, both will receive one channel. And now for the breaking edge-case, if you have more workers than channels, some workers were receiving arrays of shape (0, n_times), i.e. 0 channels, and were put to work on those empty arrays, thus returning nothing and raising during the concatenation of results.
The fix is thus very simple, you don't use more workers than channels even if the user provides an invalid number of jobs for the provided array.

@sam-s n_jobs=-1 will spawn as many workers as there are cores, which on CI is probably 2 anyway (depends on the CI provider).

I know, the issue is when -1 is replaced by the actual number of cores - I was afraid that this error might happen before the replacement (and thus you get something like 4 // -1 &c)
I suppose you thought about it already.
Thank you for fixing the issue so fast.

No risk on that side, arguments like n_jobs are checked and converted to a value at the beginning of the function, and I did check locally with -1 anyway ;) Do note however that providing a number of jobs above the number of channels will not yield any performance benefit.


Prepare for running on AWS

Description
Adds a run.sh script that can be the entry point for the docker container
Renames commandline args to --start-date and --end-date
Checklist
Please confirm that this pull request has done the following:

[ ] Tests added
[x] Documentation added (where applicable)

Notes

This now runs on AWS


Issue with sequence naming

Using Beta12 on live, I cannot name my warrior sequence FURY. if I do so, the sequence will not fire, and any attempt at editing it causes GSE to stop working properly until I reload. Naming the sequence FURY_DPS made it work just fine and editable without issue.
I tried this with a clean install as well.

First off you are using the BfA beta build on live.  There will be issues as the new GSE build is expecting different WoW API elements that aren’t present in Live till the PrePatch hits.
The issue of not being able to call the macro Fury is working as intended.  Each macro has a hidden object that it operates with.  Each of these objects have a unique name.  Blizzards internal code also creates these objects in the same area.  If an object already exists, GSE won’t let you create a macro of the same name as you then get problems when two processes are trying to use the same object for different purposes.
This existed with PVP and WW in Legion and sometimes macros with those names worked other times it broke things very badly.  GSE now checks to prevent these conflicts.
TimothyLuke

On 28 Jun 2018, at 2:08 am, MechaZao<EMAIL_ADDRESS>wrote:
Using Beta12 on live, I cannot name my warrior sequence FURY. if I do so, the sequence will not fire, and any attempt at editing it causes GSE to stop working properly until I reload. Naming the sequence FURY_DPS made it work just fine and editable without issue.
I tried this with a clean install as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks a bunch for the clarification. I just changed up my naming a bit and everything seems fine now.


Add file log whichs rotates by day

PR for issue #919

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Please sign the CLA first.

Double check that it passes all testes in my laptop. It seems to fail on another unrelated test case.

LGTM

rest LGTM

LGTM


resposivness issue

Both the login and dark theme button are too closed
they need some difference
@07sumit1002 I can fix it and make this more impressive  assign me

Pull the latest code and then work on it


Debian package of paths module

@soumith @borisfom
I'm working on on Torch Debian packaging, and now I have successfully built lua-torch-paths package locally. I'll upload it some time later.
This partially solves torch/distro#70
BTW, I wish torch upstream can make releases so I can write a file named watch, which automatically tracks upstream updates, so we can update corresponding modules in time.
https://bugs.debian.org/826529
FYI, I currently use such version for paths package: 0~20160203-g68d579a, where the HEAD commit hash is following -g, and the date is the latest commit date.
Thanks.

packaging repo is here:
http://anonscm.debian.org/cgit/debian-science/packages/lua-torch-paths.git/
package is now pending for review:
https://bugs.debian.org/826705

lua-torch-paths_0~20160203-g68d579a-1 uploaded onto unstable.
https://tracker.debian.org/pkg/lua-torch-paths

marking this issue as done.


compile

I don't know how to compile

What is the problem? With "I dont know how to compile" I cant do much. Google might be able to help you.


OpenDevin does not run with Rancher on a Mac

Known issue with Rancher on Mac. Please add to README.md
If you are running Rancher Desktop you need this line:
sudo ln -s ~$USER/.rd/docker.sock /var/run/docker.sock
https://github.com/rancher-sandbox/rancher-desktop/issues/2534

Probably a little too much of an edge case for the README, but we're working on various cookbooks for various scenarios. This seems like a good one to add

I don't know how OpenDevin connects to the docker daemon, but modern client libraries normally support the concept of docker contexts.
Rancher Desktop creates a rancher-desktop context and also makes it the current context if no context exists yet:
$ docker context show
rancher-desktop

If it is set to a different context, you can switch with docker context use rancher-desktop. Alternatively you can also set the DOCKER_CONTEXT=rancher-desktop environment variable. Or set DOCKER_HOST="$HOME/.rd/docker.sock".
But if OpenDevin doesn't have support for the regular docker context/host mechanisms, then creating the symlink may be the only option. But it should be a last resort, as it makes permanent changes to the system.
PS: You can also configure Rancher Desktop to allow Administrative Access, which will allow it to create the socket in the default location. Personally I would not recommend it, as you will have to enter your password to re-enable sudo access every time you start the app after you reboot your machine.

Hopefully the new docker installation method fixes this. If not, lmk and I'll reopen


Create nano IDs for home team to test in COLIN - urgent

[ ] Home team requires more Nano IDs for testing in COLIN, they need these urgently to ensure we are ready for the Sep 3rd release

Assign to Omid's team, they should be able to do this. Same prep issue as always, test businesses in Colin are needed.

@hanlunBCRegistries how confident are you in creating Nano IDs in TEST to give to @nsmenon8890 and other testers when needed.
@rarmitag @EPortman also are you comfortable doing this as well as requested.
If all three of you are, lets close ticket

I can create nano ids once we have necessary data from CTEST, also updated a new jupyter notebook to make the process more streamlined.https://github.com/bcgov/business-ar/blob/hanlun-notebook-new/ops/notebooks/Business-AR-cohort-7.ipynb


Fix wrong regex pattern from 55f71c3, and use precompiled regex pattern for better performance

This fix is mostly same as #17, but with one more regex pattern fix and performance tweak

@soarqin  Hi, I'd like to take this up, just need change __init.py?

Thank you for fixing this. I originally fixed this locally almost 4 months ago but forgot to push it to GitHub.
Closes PR #17 #21 (as this fix is preferred to the other ones).


Use gemmi method to implement rs.utils.compute_structurefactor_multiplicity()

This PR rewrites rs.utils.compute_structurefactor_multiplicity() to be implemented with methods provided by the gemmi.GroupOps class. Originally, we had implemented this on our own to vectorize the calculation; however, a vectorized version of this calculation is now provided in gemmi.

Codecov Report

Merging #160 (836f694) into main (6258b95) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%
==========================================
  Files          43       43
  Lines        1697     1688       -9
==========================================
- Hits         1671     1662       -9
  Misses         26       26

Flag
Coverage Δ

unittests
98.45% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

reciprocalspaceship/utils/structurefactors.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6258b95...836f694. Read the comment docs.


data_import: Stop tar'ing up converted data.

./manage.py import does not take a tarball; it takes a directory. Making a separate tarball is a waste of CPU time and disk, as it is never used.
This was included in the commit of the initial Slack conversion code in 5b37c5562bfc and propagated from there into every conversion tool.
Remove the unnecessary tarball creation.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I guess in theory the tarball setup may be useful if one is running the import on a different system than the host where you did the conversion. That's obviously a very useful thing to do with the Zulip export tool, which is I'm sure where that approach was copied from ... but less so for these others. The situations where I'd expect one to use that option are probably there will be cases where one is, say, moving from Slack to a self-hosted system inside a company firewall that won't have access to query the Slack API (as the conversion tool requires to get email addresses).
You can always just run tar, so I'm not sure it would be worth having a default-off --tarball option to do that for you (which I think is the other reasonable alternative); I'll leave that up to you.
This may need /help/ documentation updates; I've not looked.

You can always just run tar, so I'm not sure it would be worth having a default-off --tarball option to do that for you (which I think is the other reasonable alternative); I'll leave that up to you.

The ability to just run tar manually was why this seemed totally removable.  And I can think of literally no time when I have actually used the tarball, so I don't think the command-line flag is worth adding.

This may need /help/ documentation updates; I've not looked.

I just checked, and all of the self-hosted instructions just reference the directory (unsurprisingly) and none of the Zulip Cloud instructions have the users run the conversion and email us a tarball to import -- it's always sending us the raw exported data, and we do the conversion.


Locking fails under specific circumstances with private dev dependencies

Issue description
I have a pipfile which is roughly like this:
[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[[source]]
name = "private"
url = "private_url"
verify_ssl = true

[dev-packages]
private_dev_repo = {version="*", index="private"}

[packages]
private_repo = {version="*", index="private"}

[requires]
python_version = "3.9"

In this case private_dev_repo also has private_repo as a dependency.
I am unable to lock this pipfile (ie. pipenv lock --dev) as it fails to resolve dependencies for dev libraries.
However, if I add private_repo = {version="*", index="private"} to the dev list it will succeed.
I also can do pipenv install --dev --skip-lock fine, so it's just locking that fails.
Expected result
I would expect that since the non-dev packages are locked before dev packages, any dependencies which are resolved there would also be used for the dev packages.
Actual result
Dependencies fail to be resolved.
Steps to replicate
See above description for steps.
I haven't tested on older versions to see if this is a regression, however I can investigate further if required. This was tested on the latest version (2023.7.4)

However, if I add private_repo = {version="*", index="private"} to the dev list it will succeed.

This is expected, as you have your default index as pypi and the package groups or categories get locked independently.   The dev-group is constrained by the default group but that doesn't help the pip resolver any.

This seems... unintuitive? Is this documented somewhere?
To me it seems like it would make more sense to re-use the already found dependencies in a "global" sense, otherwise I need to duplicate dependencies across both dev and non-dev packages which just looks wrong...

Any documentation on the topic lives here: https://pipenv.pypa.io/en/latest/indexes/
The docs probably stands to be improved, but the problem with the named package categories (in this case default and dev), is it is totally possible to specify you want to a different versions in different package groups.   While default does constrain the other groups in terms of pip constraints.txt and version resolution, lets consider instead this example, say I had:
[groupA]
private_repo = {version="1.x", index="private"}

[groupB]
private_repo = {version="2.x", index="private"}

Well, my initial take is that it wouldn't be possible when locking to reference the Pipfile entries from the other group and still get good results.
There are kind of a number of factors here that would make this hard to sort out; on the surface it seems you could infer if groupB didnt have private-repo it could take the Pipfile entry from the default group, this might be reasonable seeing as default does constrain the other groups (there have been some requests to be able to override this behavior to not have default constrain other groups though).
In any case, it seems related to the other similar issues around private package indexes and the desired ability for transient dependencies to more easily specify what index they should be able to pull from.
Not to get into the weeds on this, but it kind of requires pip make some additional decisions too about how to handle better index restrictions -- there is discussion of removing the ability to scan multiple indexes (or alternative proposals) from pip in order to ensure all users are protected from dependency confusion attacks.

@matteius On this topic, if I'm understanding correctly what you've said here: pipenv locks each category independently, i.e. there is no resolution between dependencies of categories? So, does that mean two categories can have conflicting dependencies if both installed?

@kalebmckale the only category the constraints the other categories currently is the default one -- some people have complained on both sides of this which makes me think that should become a pipenv configuration directive (in the Pipfile) whether or not default will constrain the other groups.  Possibly there is a use case where you want constraints across categories other than default, but that gets somewhat complicated.

Understandable. I think this is probably fine for my use case.

@kalebmckale the only category the constraints the other categories currently is the default one -- some people have complained on both sides of this which makes me think that should become a pipenv configuration directive (in the Pipfile) whether or not default will constrain the other groups. Possibly there is a use case where you want constraints across categories other than default, but that gets somewhat complicated.

The idea of having a flag which is something like "globally constrained" would be good I think? Then if people want to have everything constrained by the one set of of constraints it would be easy. I think that having any more granularity than that would be too complex like you say.

Ideally, it would be easy. However, I suspect that it may also cause the pip Resolver to fail or give up if the number of dependencies / graph gets too large. Alas, it's out of my depth; so hopefully you'll consider submitting a PR for it.


refactor: update Options.lua classic filters to new data pipeline

Also re-organized the layout and added appropriate headers using FRAME_XML globals.
images

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#26
#25  👈
#24
#23
#22
#21
#20
#5
#19
#2 : 1 other dependent PR (#3 )
working-trunk

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @juemrami and the rest of your teammates on  Graphite

Merge activity

May 18, 6:20 PM EDT: @juemrami started a stack merge that includes this pull request via Graphite.


controllers: create SCCs on Openshift

Create SCCs for topolvm-node and vgmanager on openshift.
Signed-off-by: N Balachandran<EMAIL_ADDRESS>

/hold

/unhold

Cannot create SCCs using the ENV tests so skipping that for now.

/approve


utf8 issues in Neko

I tried to parse a YAML containing UTF8 chars and the validation step failed. I removed the following lines and it worked.
https://github.com/mikestead/hx-yaml/blob/master/src/yaml/Parser.hx#L167
https://github.com/mikestead/hx-yaml/blob/master/src/yaml/Parser.hx#L1313
Isn't there a double encoding going on?

I had a std@utf8 crash on neko that happened when there were some formatting errors or a white space. I'm guessing it's a similar issue.

Wow this is old, apologies @fponticelli. As you guessed not much time to maintain this anymore and not writing Haxe these days.
That said if there's a bug then a PR with tests and a fix are more than welcome from anyone bumping into this


Formula referencess not updated after InsertCols

Description
Formula references are not updated after using InsertCols.
Steps to reproduce the issue:

Create a formula in cell F5 that references  C5 + D5 + I5
InsertCols at column C or D or G

Describe the results you received:
Formula references are not updated, so formula still reads C5 + D5 + I5
Describe the results you expected:
Formula references should be updated to:
D5 + E5 + J5 for insert at C
C5 + E5 + J5 for insert at D
C5 + D5 + J5 for insert at G
Output of go version:
go version go1.20.5 linux/amd64

Excelize version or commit ID:
v2.7.2-0.20230703160637-e2c74162925c

Environment details (OS, Microsoft Excel™ version, physical, etc.):
Ubuntu Linux on laptop

Thanks for your issue. As the documentation of the InsertCols function says: "which will affect changes in references such as formulas, charts, and so on. If there is any referenced value of the worksheet, it will cause a file error when you open it. The excelize only partially updates these references currently". I'll consider adding support for this in the future.

This library now support this feature, please upgrade to the master branch code, and this feature will be released in the next version.


Add M-AILABS Data

https://www.caito.de/2019/01/the-m-ailabs-speech-dataset/

If you need voice training data (specifically also for Speech Synthesis) my former company created a dataset that I am now making available on my website. Since the company is closed (and I used to be the CTO/MD), I had decided to release it into the public with a BSD 3-clause license.
It contains German (237hrs), Queen's English (45h), US-English (102h), Spanish (108h), Italian (127h), Ukrainian (87h), Russian (46h), Polish (53h) and French (190h).

269a04bd2fac1bd3e7e355ac74f722b7915b7d95


ENH: Rework Single Point Jobs

Bit of scope creep, but basically:

Updates / refactors out the Parameters

Instead of passing a giant (often unused) structure, we now have separate configurations per job / section

Makes ownership semantics trivial to note

I think we will see very little heap allocation, most of the jobs know upfront how many objects are to be created, i.e. stack allocation should be good enough, maybe a few reference_wrapper objects

Most Potentials have parameters either hardcoded / or stored in a slightly unintuitive way under Parameters, and they don't require them for construction anyway, the factory functions have been updated as well
Better performance and less bugs, by virtue of more enum class and stronger type system use

Most of these don't require any changes at all to the server other than the rather obvious TOML migration issue.

OK so this is getting out of hand, so it is being merged with:

The single point job correctly using the new stack based approach with the parameters

Subsequent PRs will refine this and add back more functionality.

These are roughly at the same speed as the eOn SVN branch.

Command
Mean [ms]
Min [ms]
Max [ms]
Relative

eonclient -s client/example/pos.con -p lj
11.1 ± 2.0
5.5
15.8
1.00

eonSVNonly/client/eonclient -s client/example/pos.con -p lj
11.8 ± 2.3
4.8
23.5
1.06 ± 0.28

Ergo, this is being merged in for now. Much cleaner.


Chore/improve api docs generation

getswagger.sh improvements:

Exit on invalid options.
Show curl output and errors (e.g. when the filepath is incorrect).
Replace $_ with $outFile for readability.
Replace context with platform, the common jargon.

generate.sh improvements:

Speed up dev and deployments by only regenerating HTML if the current file differs from master.

Refactor to remove code repetition.

[x] Rebased/mergeable

@sunbryely-influxdata Please try this for a while to shake out any potential problems.


a Nintendo Switch Pro sometimes doesn't work (random buttons are pressed)

Ebitengine Version
f17be388b2fe87a9d0390783e0f93d17c5af5d9a
Operating System

[X] Windows
[X] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
go version go1.19.4 darwin/amd64
What steps will reproduce the problem?

Connect a Nintendo Switch Pro controller
Run examples/gamepad

What is the expected result?
Nothing happens when no button is pressed
What happens instead?
Random buttons are pressed even if no button is pressed
Anything else you feel useful to add?
This is a known long-term issue: https://www.reddit.com/r/NintendoSwitch/comments/8ljuc6/random_buttons_pressing_when_i_connect_switch_pro/
Chrome has its own driver and doesn't have this issue.

Duplicated with #1903


Change all download buttons to feedback buttons

Change all the download stuff to feedback stuff. Includes the buttons in modals, which pop up the feedback modal on top of them so that the user can return after submitting feedback.
Edit: also includes changes to prompt (modal) text in order to direct users to submit feedback rather than to download the data and email it to us.

@migueldcepeda: Just pinging you on this one because the setup for the style of the download button got changed when it turned into the feedback button and it'd be nice to have your eyes on the new setup to see if it lines up right.

@knod Has change from download button to feedback button been merged. I don't see it on the latest version.

@migueldcepeda Not yet, I'm gonna make that one change to the modal copy that @knod suggested tonight. After that I think we can merge?

@ethanbb Oh ok, just wanted to make sure I wasn't doing anything wrong on my end.


Don't get len of response data if there is no data

Fixes #505

Coverage remained the same at 100.0% when pulling fe0917865c5ecc217de084f339402714bc27a3fb on dangitall:issue/505 into 23e421c5a614bc7043dcbaada4c286889698e1f9 on timothycrosley:develop.

Looks great, thanks!


Get rid of the warnings in py tests

cd py && make test
echo "Testing using LOCAL UPLOAD AND BASE URL" && H2O_WAVE_WAVED_DIR=".." H2O_WAVE_BASE_URL="/foo/" ./venv/bin/python -m tests
Testing using LOCAL UPLOAD AND BASE URL
2024/02/08 08:06:32 #
2024/02/08 08:06:32 # ┌────────────────┐ H2O Wave
2024/02/08 08:06:32 # │  ┐┌┐┐┌─┐┌ ┌┌─┐ │ (version) (build)
2024/02/08 08:06:32 # │  └┘└┘└─└└─┘└── │ © 2021 H2O.ai, Inc.
2024/02/08 08:06:32 # └────────────────┘
2024/02/08 08:06:32 # ┌──────────────────────────────────────────┐
2024/02/08 08:06:32 # │  Running at http://localhost:10101/foo/  │
2024/02/08 08:06:32 # └──────────────────────────────────────────┘
2024/02/08 08:06:32 # {"address":"assets/","source":"./assets","t":"public_dir"}
2024/02/08 08:06:32 # {"address":":10101","base-url":"/foo/","t":"listen","web-dir":"/Users/mturoci/projects/wave/ui/build"}
.................2024/02/08 08:06:33 # {"path":"/foo/_f/9c8bad93-e3b0-4b29-a7c8-8c862e0b3574/test.txt","t":"file_download"}
2024/02/08 08:06:33 # {"path":"/foo/_f/9c8bad93-e3b0-4b29-a7c8-8c862e0b3574/test.txt","t":"file_unload"}
2024/02/08 08:06:33 # {"error":"not found","path":"/foo/_f/9c8bad93-e3b0-4b29-a7c8-8c862e0b3574/test.txt","t":"file_download"}
.2024/02/08 08:06:33 # {"path":"/foo/_f/4f6cf8cb-1503-4205-b3de-378488f96e90/temp_file1.txt","t":"file_download"}
.........................2024/02/08 08:06:33 # {"path":"/foo/_f/07766f71-4e39-489b-bdd6-0b9987df0c74/dir1/test.txt","t":"file_download"}
..2024/02/08 08:06:33 # {"path":"/foo/_f/66d1a7cd-ce0d-47f0-9343-15a27135735c/test.txt","t":"file_download"}
2024/02/08 08:06:33 # {"path":"/foo/_f/66d1a7cd-ce0d-47f0-9343-15a27135735c/test.txt","t":"file_unload"}
2024/02/08 08:06:33 # {"error":"not found","path":"/foo/_f/66d1a7cd-ce0d-47f0-9343-15a27135735c/test.txt","t":"file_download"}
.2024/02/08 08:06:33 # {"path":"/foo/_f/c29f3ce4-9695-4bfc-94fc-47194428b7d3/temp_file1.txt","t":"file_download"}
...2024/02/08 08:06:33 # {"path":"/foo/_f/eaca45e9-485b-4a47-b049-e4e559906724/dir1/test.txt","t":"file_download"}
.............../Users/mturoci/.asdf/installs/python/3.10.10/lib/python3.10/asyncio/selector_events.py:710: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=10>
  _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/Users/mturoci/.asdf/installs/python/3.10.10/lib/python3.10/unittest/mock.py:2119: ResourceWarning: unclosed <socket.socket fd=13, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('<IP_ADDRESS>', 49513), raddr=('<IP_ADDRESS>', 10101)>
  if getattr(self, "_mock_methods", None) is not None:
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/Users/mturoci/.asdf/installs/python/3.10.10/lib/python3.10/asyncio/selector_events.py:710: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=13>
  _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/Users/mturoci/.asdf/installs/python/3.10.10/lib/python3.10/asyncio/selector_events.py:710: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=11>
  _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/Users/mturoci/.asdf/installs/python/3.10.10/lib/python3.10/asyncio/selector_events.py:710: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=12>
  _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/Users/mturoci/.asdf/installs/python/3.10.10/lib/python3.10/asyncio/selector_events.py:710: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=14>
  _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/Users/mturoci/.asdf/installs/python/3.10.10/lib/python3.10/asyncio/selector_events.py:710: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=15>
  _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback

@mturoci The issue seems to start from here. Seems the issue is in mock_q or the way it is being called for the mentioned lines. Though I'm unable to see where Q is defined. I can resolve this issue if you can help me out a bit @mturoci.

Thanks for the initiative @Devanshusisodiya! Q is defined here.

@mturoci Why are all the tests running a total of 4 iterations? And how are parameters of BASE_URL and H2O_WAVE_BASE_URL being set for the testruns?

Why are all the tests running a total of 4 iterations?

each iteration uses a different server config. The link also answers the second question.


Spaces at the beginning and end of some inputs could be discarded

Sometimes people copy/paste spaces at the beginning or end of their invite code and it invalidates their attempt to register. Flairs will take spaces at the end of the input, and display them, which looks weird.
Fields that could discard the spaces at the beginning and end:
post flair
user flair
invite code creation field
invite code input field on registration

Hey Is this still open? I would like to work on this

Yes, this issue is till open


a more repeatable version of a deploying a README file. It uses a mai…

…nfest file to include the README.rst, then ensures the remove of the symlink (if exists) and always links it.
I was having trouble with the symlink for README getting packaged, because setuptools by default includes a README or README.txt by default and not a README.rst. Then when it unpacked and saw the broken README symlink there it would fail running the setup.py. I believe after reading the docs that the solution I am proposing will help with this issue.

Actually recent versions of Python packaging tools seem to be happy with a README.rst -- at least that's what the documentation recommends these days. I'll commit a significantly simpler version of setup.py.


Problem enabling LDAPS.

ISSUE TYPE

Bug Report

COMPONENT NAME

Code, API.

CLOUDSTACK VERSION

CloudStack <IP_ADDRESS>

CONFIGURATION

Using many domains.
Trying to use LDAP server with TLS.
All certificates generated and tested.
Keystore configured and tested.
OS / ENVIRONMENT

Ubuntu Server 20.04.3 LTS.
KVM.
cloudstack-management                <IP_ADDRESS>~focal
SUMMARY

Need to communicate management server with LDAP using TLS (LDAPS). Documentation says if ldap.truststore and ldap.truststore.password are configured it will switch working to LDAPS. It just happens when these parameters are configured globally but using API it is possible to configure them inside a domain. When configured inside a domain we have no effect.
STEPS TO REPRODUCE

Try to configure ldap.truststore and ldap.truststore.password for a domain:
cmk -p user@myprofile update configuration name='ldap.truststore' value='/etc/cloudstack/management/cloud.jks' domainid="e8b2ec00-21e2-430b-bd9b-a31c3d642bbf"
cmk -p user@myprofile update configuration name='ldap.truststore.password' value=PASSWORD domainid="e8b2ec00-21e2-430b-bd9b-a31c3d642bbf"

EXPECTED RESULTS

LDAPS enabled and communication between management and LDAP servers using TLS.

ACTUAL RESULTS

LDAPS is not enabled.
LDAP server logs shows "initializing ldap with provider url: ldap://ldapserver.domain:636".
All queries trying to log in a user use ldap:// too, not ldaps://.

If we configure ldap.truststore and ldap.truststore.password globally (not for a domain), so we can make LDAPS to work.
cmk -p user@myprofile update configuration name='ldap.truststore' value='/etc/cloudstack/management/cloud.jks'
cmk -p user@myprofile update configuration name='ldap.truststore.password' value=PASSWORD
# Until here no domain was specified!
cmk -p user@myprofile add ldapconfiguration hostname=ldapserver.mydomain port=636 domainid="e8b2ec00-21e2-430b-bd9b-a31c3d642bbf"
cmk -p user@myprofile update configuration name='ldap.basedn' value='...............' domainid="e8b2ec00-21e2-430b-bd9b-a31c3d642bbf"

I think the code is looking for ldap.truststore and ldap.truststore.password only in global configuration. It would be interesting looking inside domain configurations too. So, each domain could have a different LDAP configuration.  As the API accepts the domainid= parameter to configure the truststore, I believe that the initial idea was this, but something is not working as well.

@correajl if i make a PR on 4.16 to fix this will you be able to test it? I seems like the fix is rather simple (but testing isn't) I'll try to add some unit tests later.

ping @correajl can you test #5816 ?

ping @correajl can you test #5816 ?

Hi @correajl Can you help in testing the PR #5816. Thanks.

Yes, I'm going to test as soon as possible.
tks

JLC

On Mon, Jan 3, 2022 at 3:52 AM sureshanaparti @.***>
wrote:

ping @correajl https://github.com/correajl can you test #5816
https://github.com/apache/cloudstack/pull/5816 ?
Hi @correajl https://github.com/correajl Can you help in testing the PR
#5816 https://github.com/apache/cloudstack/pull/5816. Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/cloudstack/issues/5712#issuecomment-1003898733,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANV52X7WRMODYSWDNHQYD3UUFBUHANCNFSM5ITNKXMQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Fixed in https://github.com/apache/cloudstack/pull/5816


Update README directions

Closes #12

Related to this, can we get an example configuration file? My _config.yml is empty and I can't see how to generate it.

What, keeping that documentation in a comment on a closed issue is a bad idea?
https://github.com/tymorrow/assigner/issues/3#issuecomment-172292646

THIS IS GOOD ENOUGH
(ALSO I FUCKED UP AND COMMITTED TO THE WRONG BRANCH)
YOLO SHIPIT


Updated team-velocity.md

I had attended some customers that were confused after creating iteration dates by the widget is showing message "Set iteration dates".

@v-nealva : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Accessibility page needs updates

There are a number of typos on the accessibility page and I don't have the rights to save the change.  In addition, I can provide additional specifics on what accommodations are available.
Here's the proposed text:
The Drupal GovCon team is committed to providing a rewarding experience to all our attendees. If you require any assistive technology or other accommodations, please let us know [link to https://www.drupalgovcon.org/drupal-govcon-2015/contact-us]. We will do our very best to accommodate all requests.
The NIH campus, including the security building, campus shuttles, and the Natcher Conference Center (Building 45) are all wheelchair accessible.  [NIH Building Accessibility Maps] [link to http://www.ors.od.nih.gov/maps/accessibility/Pages/se_section.aspx]
In preparation for the 2015 Drupal GovCon, the following accommodations have already been arranged:
•	Sign Language interpreters will be available at the keynote sessions
•	Headsets are available in the Natcher auditorium upon request
•	The three keynote sessions will be live streamed, with live captioning, in the balconies and on the open web.
We also have the following additional services available upon advanced request:
•	Sign language interpreters in breakout session
•	CART (Computer-Aided Realtime Translation)
If you need any of these additional services or require assistance beyond what is listed, please contact us at least two weeks before the conference. [link to https://www.drupalgovcon.org/drupal-govcon-2015/contact-us]
Read more about the NIH Interpreting Services here [http://www.ors.od.nih.gov/pes/dats/interpret/Pages/index.aspx]

should be done @cmndr-king check it please.

You have some literal text in there that should be removed.  For example, I said [link to …) and that text is still in there.  I added those notes because the ticket stripped out HTML.
-James

James King, MLS, FSLA
http://about.me/cmndr_king
From: Kirsten<EMAIL_ADDRESS>Sent: Tuesday, June 30, 2015 3:11 PM
To: Drupal4Gov/Drupal-GovCon-2015
Cc: King, James (NIH/OD/ORS) [E]
Subject: Re: [Drupal-GovCon-2015] Accessibility page needs updates (#122)
should be done @cmndr-kinghttps://github.com/cmndr-king check it please.
—
Reply to this email directly or view it on GitHubhttps://github.com/Drupal4Gov/Drupal-GovCon-2015/issues/122#issuecomment-117308741.

updated

Awesome, thanks!
-James

James King, MLS, FSLA
http://about.me/cmndr_king
From: Kirsten<EMAIL_ADDRESS>Sent: Tuesday, June 30, 2015 3:31 PM
To: Drupal4Gov/Drupal-GovCon-2015
Cc: King, James (NIH/OD/ORS) [E]
Subject: Re: [Drupal-GovCon-2015] Accessibility page needs updates (#122)
updated
—
Reply to this email directly or view it on GitHubhttps://github.com/Drupal4Gov/Drupal-GovCon-2015/issues/122#issuecomment-117314201.


about popover border

i have set applyShadow = no,then i set the popover borderWidth and borderColor ,but the grayLine doesn't surround the popover's triangle,how to do

hello

sry, it's not supported


Should Support/Expect Common Pre-Release Versioning Strategy

We've realized a versioning oddity with the pre-release strategy that currently expected.
Basically, the change is to do what we'd often have seen / done with release candidates/alphas/betas (for other projects) and put the next expected version that you're building towards in the standard release version. We would support/expect to convey the upcoming version that we're building towards, not just what we're building on and letting it auto calculate.
Example

We're currently at version 12.0.0
We make a minor change: 12.1.0-pr.0.1.0.
We make a major change: 13.0.0-pr.1.0.0.
We make a major change: 13.0.0-pr.2.0.0.
We make a minor change: 13.0.0-pr.2.1.0. -- not minor bump on standard release version since we've already passed the major threshold

We think that bumping the pre-release to the next version your building towards makes the most sense with what's commonly seen/done. For example, we might see a pre-release from Microsoft for .NET 7 being 8.0.0-pr2.3.8 (they might actually follow 8.0.0-preview.4 for most but it's a similar strategy nonetheless).

The initial support option was added. We've also kept around the initial "unmanaged standard release version" option if ever useful, but that may be removed in future versions of this tool.


Tailwind classes awkwardly purging in development

Describe the bug
Adding a new Tailwind class during development doesn't reliably cause the browser to hot drop in the style, leaving you to have to do an Empty Cache and Hard Reload in the browser to see it.
Running yarn static builds & exports the site then pops open a local server of the build, which shows the Tailwind classes being correctly included.
Expected behavior
Adding a Tailwind class to your project should automatically reflect it in the browser the first time it's used in your project without any tomfoolery. Tailwind should probably just throw up all the classes into the global.css while in Dev and only purge in Production. It's currently configured that way but there must be something conflicting.

Fixed in 6ae840a


Docs on using CUE and Rego to craft policies in policy-controller

There are a couple of policy examples in the policy-controller docs that use cue policies, but I can't find any documentation that specifically address CUE and Rego support and how it works.

Here's how to craft a CUE policy, here is the spec/language reference
Here's how Rego policies work, here is the reference on how they need to be written (including custom error messages)

@amdawson I'm interested to take this up! Can you please provide me with some resources to get started? Or if you have anything specific regarding this, feel free to share! 😄


Edit container name isn't persistent

Edit container name in UI isn't persistent.
After reinstall rancher server / agent all containers use id instead of name. After edit container name und restart the container the new name is lost and replaced by the ID (not docker id, seems like Rancher container id: "a221bcbe-ffea-47ef-a27a-3d66afaeae69").

Hi @pwFoo.
The rancher container name is only stored in the rancher database. By default, the rancher database is run inside the rancher/server container and reinstalling rancher/server means the database is lost. This is why you are losing the names. I believe we have docs for run the database outside of the rancher/server container (which should be done when running rancher for production), but I don't know the link the offhand. I'll respond later today with docs explaining that setup.
That said, with the addition of labels to docker, we can start giving containers user-friendly names. I've opened issue #1399 to track this.

@pwFoo @cjellick Here's the link to how to set up an external database. http://rancher.docs.rancher.com/docs/installing-rancher/installing-server/#using-an-external-database

Hi and thanks @deniseschannon, but no need for an external database. If needed for persistent data I prefer an data only container ;)
I hope rancher container name will synced with the docker container name (docker ... --name=).

Since @cjellick opened #1399, I'll close this issue.
@pwFoo Please follow #1399 to see progress on the naming of containers.


Option to disable Live Table.

Option to disable Live Table in order process to fix an issue with azure devops pipeline agent running with ubuntu
fixes #24

Is it possible to get this feature mergend?

Thanks @jaehnem - apologies for delay

Thanks @dirkhoefling for the change - i've approved - sorry for the delay


CodeReview

This branch is not crated from master. Please create a new branch from master and make your commit from it.


Remove activation hook

Tool-bar late loading does not look good. It makes the Atom look bulky. I think 20ms is not that long to defer it.

Do you mean that the toolbar is being loaded in quite late and it suddenly just appears? I'm not entirely against removing it, but I'm personally not in favor of it. 20ms is not much but 1) that might be more on a slower computer and 2) if every package maintainer thinks that it adds up quickly.
Some alternatives we could consider:

Remove the activation hook but update our implementation to get that 20ms down even further
Add an animation for when the toolbar get's loaded, I suspect that will make it look less "bulky"

Yes. It appears suddenly. I don't know how to add an animation. If you know, that can help.
For performance, I can improve the loading time. That is on my todo list. 👍

@suda Could you merge this? It makes Atom look much better.

Hi Amin, the activation hook was added on purpose to improve Atom's performance.
I agree with adding the animation on showing the toolbar, and a CSS transition should be enough to create "slide-in" animation.

Hi Wojtek! In #304 and #302, I improved the actual loading time of the package. The toolbar gets almost twice fast. I think this activation hook is not necessarily useful anymore.
Note that I don't know how to add this CSS animation.

Hi Wojtek! In #304 and #302, I improved the actual loading time of the package. The toolbar gets almost twice fast (90ms to 45ms). I think this activation hook is not necessarily useful anymore.

In that case it would definitely make more sense to merge those PRs before merging this one :wink: If for whatever reason those PRs don't get merged we don't want this one having been merged already.

Note that I don't know how to add this CSS animation.

That's fine, someone else can make that contribution if we decide not to merge this PR.

I agree we can add the animations later.

The toolbar gets almost twice fast (90ms to 45ms)

Yes because it's trying to be loaded in parallel with Atom's core making it a bit slower instead. The goal of the hook was to give Atom all resources to bootstrap and then let it decide what to initialize in what order. We shouldn't try to squeeze ourselves into this process.

@suda Can we merge this? Trying the trick in #306 was not successful for me.

As I said, there was a reason for adding the activation hook and I wouldn't like to remove it. We should come up with a nicer implementation of #306 instead of going against Atom's recommendation of using the hook IMO.

@suda
Activation hook is very useful for packages that don't need to load a feature right away. For example, they just work in the text editor, etc. But toolbar should appear when atom loads, and if does not, it makes atom look weird (compared to other IDEs)
I mentioned in the other repository too:
I think here we are doing things that are not common in other software/IDEs. All the usual software, load their toolbar normally during the loading time. We don't need to circumvent doing this!
Tool-bar is, in my opinion, a crucial part of Atom, and it is so useful that I want to include in atom-community builds: https://github.com/atom-ide-community/atom/projects/4#card-41191288

You have a fair point. Lets merge this in then :+1:

Thanks! :tada: