Downloading an exercise is annoying as exercism is more geared to command line - we should parse the command line example on fetch

The exercism site is really geared to command line junkies, and we don't have much control over the layout of the track site and the instructions that it gives.
Thus is shows an example for download like: exercism download --exercise=acronym --track=pharo
I propose we let you paste this into the fetch dialog (as well as acronym) and we can parse out the exercise and just fetch it.
This makes it much easier for users to crack on.

This is cut-n-paste is exactly what I was trying to achieve from the Playground doing...
ExercismDownload track: 'pharo' exercise: 'acronym'

actually, one feature that impressed me when learning Pharo was controlling the GUI from the REPL.
For example we might do this...
Exercism download track: 'pharo' exercise: 'acronym' ; browse

where...
Exercism-class>>download
    ^ ExercismDownload new

ExercismDownload>>track: aStringTrack exercise: aStringExercise
	track := aStringTrack.
	exercise := aStringExercise asKebabCase.
	self execute

ExercismDownload>>browse
     "open system browser on the downloaded exercise"

whoops, sorry. I think I missed your point, that the instructions are "standard" and presented only for their own client?

@bencoman yes - my point was that we couldn't control the instructions on the exercism site (so nice - request on them).
For now - I've whacked in something that simply parses what their current site lets you easily copy to the clipboard - so now you can paste it into our fetch prompt (and not have to tediously edit it).
If we could control the instructions, it would be handy to have a way to easily copy the exercise kebab name AND as you suggest, easily copy what the playground command would be too (the latter I also like as it nicely shows that we do have a form of command line in the playground - but the former is also nice for just point and click too).
I guess I'll leave this issue open but rename.

I'm closing this issue as we have a way to parse what we get from the existing template - but have opened up #132 which is what @bencoman spotted we should request.


Silverstripe 5 support

CMS 5
silverstripe/admin already implied
latest commonmark
use any version of PHPunit (presumes ^9 if CMS 5 is used)

Hi @elliot-sawyer - thanks for this PR! In the interest of not making this a major change, can we use ||-style requirements?

@andrewandante fixed

Hi mate, sorry for the delay, all issues have been noted and fixed  :+1:

Amazing, thanks @elliot-sawyer !


Media Library folder name flagged for forbidden characters

Trying to migrate K13 site. Hotfix v13.0.130. Target is XbyK 29.3.3.
I'm receiving an error indicating that the Media library folder name contains forbidden characters.

However, this isn't the case—the folder is named jobs.

@tkrch
No results for both databases for the given query.
The expectedPath variable value is:

For source K13 project: C:\\Users\\hello\\source\\repos\\<solution-folder-name>\\<site-folder-name>
For target XbyK project: C:\\Users\\hello\\source\\repos\\<solution-folder-name>\\bin\\Debug\\net8.0

@tkrch I'm afraid I don't have time to work on this right now. If you'd like to dive into it, the site of subject is jobs.kentico.com. You might want to reach out to Kentico's Internal team to get the code and database backups and try migrating the site on your own.

čau Milánku, I have asked our Intra team for the code and database backups, we will let you know how it goes.


More improvements to shutdown process

Gets Windows support working
Logic fixes

At this point all the deep issues are dealt with (getting it working with the sys calls for all 3 platforms, having a way to kill old/frozen daemon instances, etc.) and it's in a place where we can fiddle with the shutdown sequence however we want.
For example, we could do the trick we discussed earlier--i.e., when the daemon was started externally, instead of killing everything called "lbrynet-daemon," it only kills the one that opened the port. Or, if there were some way to detect which of the running daemons are frozen or left over from other versions, we could do that on every upgrade (or even every shutdown!)

merged


ComplexityRatingDao.getForApp(): NullPointerException when the app has no associated scores

Some apps don't have associated servers, connections and capabilities (i.e. those in DEVELOPMENT) - so the method shouldn't throws NullPointerException but return NULL rating instead.

@glorymanutd

Can you make the pull agains rel-1.1.x ?  (https://github.com/khartec/waltz/tree/rel-1.1.x)

Merge into master


[terraformer] run container as non-admin

How to categorize this issue?
/area security
/kind enhancement
/priority normal
What would you like to be added:
I would like the container to be run as a non-root user.
Why is this needed:
Security policies in my cluster prevent containers from being executed which run under root permissions.
See https://kubernetes.io/docs/concepts/policy/pod-security-policy/#users-and-groups for the specific policy in question.

/title [terraformer] Run container as non-admin

/assign


using try/catch with an async method inside a middleware causes a nuxt instance unavailable error.

Environment

Operating System: Linux
Node Version:     v17.9.0
Nuxt Version:     3.0.0-rc.4
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules, runtimeConfig, autoImports
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
Visit the /secret page to see the error:
https://stackblitz.com/edit/nuxt-starter-elpq43?file=middleware%2Fauth.ts
Describe the bug
I'm trying to write an async middleware. However, when catching the rejected promise an error is thrown by nuxt when using navigateTo():
async function fetchUser() {
  throw new Error();
}

export default defineNuxtRouteMiddleware(async (to, from) => {
  let user;

  try {
    user = await fetchUser();
  } catch (e) {
    user = null;
  }

  if (!user) return navigateTo('/');
});

Additional context
No response
Logs
No response

Hi,
I am having the same issue but with a request from a created method. Basically I am trying to do a simple fetch outside the setup function.
async created() {
await this.fetchData();
}
In the fetch method I'm trying to call nuxt auth composable to retrieve the status of the user.
const { status, data } = useAuth();
The error is from useAuth(); I tried using callWithNuxt(who by the way is nowhere mentioned in the docs) and it doesn't work. If I do a entire refactoring and put the call in the setup script or method it works and I understand that I have an option to fix it but the most common use case is to do fetch from create or any other functions. I don't understand how an issue with some many complaints it's closed. Not every component can be written with the setup method in the best way and the main thing of Vue is that it let's you use both composition and options api. Here is still has an advantage over react.
Could you give us another solution to avoid this error?
Thanks.

Hi,
I am having the same issue but with a request from a created method. Basically I am trying to do a simple fetch outside the setup function.
async created() { await this.fetchData(); }
In the fetch method I'm trying to call nuxt auth composable to retrieve the status of the user.
const { status, data } = useAuth();
The error is from useAuth(); I tried using callWithNuxt(who by the way is nowhere mentioned in the docs) and it doesn't work. If I do a entire refactoring and put the call in the setup script or method it works and I understand that I have an option to fix it but the most common use case is to do fetch from create or any other functions. I don't understand how an issue with some many complaints it's closed. Not every component can be written with the setup method in the best way and the main thing of Vue is that it let's you use both composition and options api. Here is still has an advantage over react.
Could you give us another solution to avoid this error?
Thanks.

I ran into this issue too(it was way too dank to debug and fix btw).
I feel like I understand better now thanks to an expanded explanation in the https://github.com/nuxt/nuxt/issues/14269#issuecomment-1397352832.
I was able to fix my stuff by following how it's done in the next-auth: https://github.com/sidebase/nuxt-auth/blob/main/src/runtime/composables/authjs/useAuth.ts#L60.
I have a custom page middleware with some async stuff going on and which had a weird behavior, but after wrapping the middleware function with defineNuxtRouteMiddleware as well as refactoring it, everything worked as expected!
Fix that worked for me:

in case some route middleware has any async/await action going on in it - wrap it with defineNuxtRouteMiddleware
save the reference to the nuxt app
pass the reference everywhere you use nuxt composables(useState, navigateTo etc.)
use the callWithNuxt

Example:
// utils/data.ts
export const moreCoolStuff = async (nuxt: NuxtApp) => {
  const result = await callWithNuxt(nuxt, () => useFetch('/api/cool-stuff'))
  // ...
}

// composables/cool-stuff.ts
export const useCoolStuff = async (nuxt: NuxtApp) => {
  try {
    await moreCoolStuff(nuxt)
  } catch(error) {
    return await callWithNuxt(nuxt, () => navigateTo('/failed'))
  }
}

<!-- page.vue -->
<script setup lang="ts">
definePageMeta({
  middleware: [
    defineNuxtRouteMiddleware(async (to, from) => {
      const nuxt = useNuxtApp()

      return await useCoolStuff(nuxt, to)
    })
  ]
})
</script>

Hi @KonstantinVlasov, yes, I made a plugin to handle the async operation and share the auth data using Nuxt's useState which I can then check inside the middleware. You can see an example here: https://stackblitz.com/edit/nuxt-starter-1dvjxv?file=middleware%2Fauth.ts
Ideally the usage of useState should be abstracted to a composable which contains all auth data and operations used by the rest of the app, so that when the user logs out for example you can update the shared state in a single place and the middleware gets the latest updated value next time it runs. You can check the code in this repo as an example for implementing this: https://github.com/amrnn90/breeze-nuxt

Thanks, that's very helpful


THe text editor does not update the code so if i change a color it does not reflect making the experience bad, I cant even add my own code or collaborate with it technically

I had this working at one point.  Will try to bring it back soon

I have the same issue, after relaoding a couple of times it works.

Yeah, I saw this in Michael's video.  I'll try to reproduce and figure out what's up...

This should be fixed now...


chore: Move maps 2017-01-preview under preview folder

Fixes #6700

Automation for azure-sdk-for-python

@zikalino here you go.
@jhendrixMSFT FYI, I found the Go had a reference to the preview version. Maybe you can check to see if I updated the output path correctly

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

normally we dont change folder of swagger file, but I saw the conversation below @zikalino and @nschonni in the issue referenced. Need @zikalino 's confirmation on whether there's no impact to all sdks, such as java, go etc. I'll close the pr for now, will revisit it after @zikalino back from vacation.

@zikalino did you want to re-open this one?


deps: update Angular dependencies

PR Type

[x] update deps
What Is the New Behavior?
update angular & ngrx
(fixed can-i-use lite "out of date" warnings)
Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

I still get

Browserslist: caniuse-lite is outdated. Please run next command npm update

Is your (global) Angular CLI up-to-date?
Try running npm run ng -- serve which should force using the one in the node_modules.
'Cause it works for me... :man_shrugging:

Works with npm run ng -- serve for me too.


Exiting model downloader with non-zero exit code

Signed-off-by: Aaron Chong<EMAIL_ADDRESS>
Bug fix
Fixed bug

Fixes https://github.com/open-rmf/rmf_traffic_editor/issues/451
Fix applied

If your pull request is a bug fix, delete this line and all the below lines.
If your pull request is a feature implementation, delete this line and all the above lines.
Exit model downloader script with non-zero exit code, to fail any calls in package building.

@orensbruli Testing it statically I am able to fail the build whenever the fuel tools client fails to download a model. I'm not too sure how to test this, other than running it over and over again :laughing:

@orensbruli Testing it statically I am able to fail the build whenever the fuel tools client fails to download a model. I'm not too sure how to test this, other than running it over and over again laughing

You are right, It's not something obvious to test without too much work. I think we can merge and keep an eye on it.


Eliminate conversion error

sqlite3pp was converting a std::size_t to an int, this generates a warning when warnings are turned all the way up on 64-bit platforms. It can also be considered a little dangerous to do this conversion without ensuring the value will fit in an 'int'.
To be a little more correct/robust, I added a function details::trim_strlen that ensures the value will fit into an int or it truncates the value to fit. Using this function eliminates the warning on 64-bit platforms.

I prefer just using static_cast if you want to remove the warnings.
I'm pretty sure it's safe here.

Actually, it's not perfectly correct here.
The problem is std::size_t can hold a larger value than int (on both 32bit and 64bit architectures). When the value can be stored in an int it will be without problem. When the value is too large, then what happens is implementation defined. That means portability goes out the window :(
See https://stackoverflow.com/questions/7601731/how-does-one-safely-static-cast-between-unsigned-int-and-int (second answer quotes C++03 standard, I don't think this has changed in C++11).

What happens with clang when the value is larger than an int can hold (and I believe Visual Studio has the same behavior) is a negative number is returned from the static_cast.
I don't think passing a negative value into sqlite3 here will cause an issue, but as a rule I generally avoid implementation defined behavior.

I meant that practically it's pretty safe to assume that the strlen of a sql statement is shorter than numeric_limits<int32_t>::max().
And your code is not fixing the problem either when the strlen of it is longer than that, which very unlikely happen.

My code prevents depending on implementation defined behavior by truncating the length to the size int can hold. The result is predictable behavior on every platform, which is better than static_cast'ing and who knows what is passed into sqlite3.
I agree, running into a sql statement long enough to trigger the condition would be a very unlikely occurrence... but we should handle it gracefully, no?

Sorry about this one, but having a helper method for this is too much to my taste for this project.
BTW, thanks for all your pull requests. Now, it's more useful with less warnings!


Try...Suppress

Description
The @ suppression was preventing errors from being thrown & caught in the try...catch block, causing delete_files() to return true even when it failed. The "failure" test was still passing because RecursiveIteratorIterator still failed on the non-existent directory.
@samsonasik Is there a Rector rule for @ suppression in try...catch? Seems like it should be an easy one.
Checklist:

[X] Securely signed commits
[X] Component(s) with PHPdocs
[X] Unit testing, with >80% coverage
n/a User guide updated
[X] Conforms to style guide

Do you mean a rector rule that can remove @ error suppress? It seems not yet.
There is ErrorSuppress node for that that we can use on create custom rector rule for it, like this:

@MGatner do you want me to create PR for it to add custom rector rule to https://github.com/codeigniter4/CodeIgniter4/tree/develop/utils/Rector for it?

In my opinion, there should never be an error suppression (e.g. @unlink($file)) inside a try {} block, because it prevents the error from being thrown and caught. I assume any instance of these would be a logic error.
If that's easy to write it would be a nice addition, but don't spend a lot of time on it. I thought there might be something already since this seems like perhaps not an uncommon mistake.

I agree. The @ operator should not be present inside a try catch as that would be contradicting.
As there is an ErrorSuppress node, maybe there's an equivalent Node object for try catch in the php-parser library. We should check the presence of both node types before applying the rector rule.

Ok, so it should be RemoveErrorSuppressInsideTryRector

@MGatner @paulbalandan here the PR https://github.com/codeigniter4/CodeIgniter4/pull/4724


Support Echo Show directive

Echo Show Directive
Added a new folder into the UI with the necessary files for the Echo Show directive. These includes all the possible basic options the user can change:

Tittle
Background Image
Main Image
Primary Text Content
Secondary Text Content
Tertiary Text Content

Also, the user can change the properties available for the text content and the format of the UI in general:

Type of text (plain or rich text)
Type of template
Back button

Here is a screenshot of how the directive will be sent to the Amazon Alexa service:

Notes

There's still no support for the "List Items" option, but it is planned for the near future to support it.
The way you need to set up every value in the directive is very inconvenient and ugly, but I believe this can be resolved by each person that implements the library since there are a lot of ways to fix it, and everyone can come up with a different solution depending on whatever they need to do.

Reference
If you need to know more about what an Echo Show directive is and what it can do, here's the official link where we got all the information we needed to make the directive.

Even though the commits are only mine, the changes were made by Aifos29 and me

Any plans to update code again?  Looking for Display_ElementSelected and the List templates?  I am playing around trying to make something work to share as well.
Cheers

@Jasc01 This is a great PR, thanks! How much testing have you done? One reason I'm slow about merging PRs is that I feel I need to test everything myself before releasing. If you can help me get assurance about QA I'd love to get this into the main library asap.

@psantiago1969 Sorry for being slow. I'm swamped with other priorities at my work and need some help managing this project. As soon as I can test/validate this PR happy to merge and release. As for new features I'm afraid it's not a priority for me, but might be for @Jasc01

I have used the code Jasc01 provided and it works great.  However, I am working on Display_ElementSelected for BodyTemplates  and the List templates usage.

If you want to play a video with this on echo show, its currently not working. For that to work, you need to make the ShouldEndSession property nullable.

@stefann42 Sorry for my late reply. I have used this code for a few months now and there's not been problems with it. One thing I haven't done is to publish an skill using this code, so I can't prove that point yet (maybe in the future, but I don't really know).
@psantiago1969 @petersantiago To use those features is not a priority in my projects, thus I'm not planning to make any of them in the near future. But it would be nice if you help us and provide the necessary code for it. Actually, it would be really great! :smile:
@teriansilva I'm sorry, but playing a video wasn't one of my requirements. However, you are free to make the necessary changes for it to work, of course. :smiley: :+1:


[3.x] Fix crash when creating thread

3.x version of #53059
Unlike the master version, this uses ObjectDB::instance_validate() to validate Object *.

Thanks!


Trev8939/blend renderer

Next release of the SDK will no longer allow creating a new RasterLayers from a Raster which is already used to create an existing RasterLayer.  Fix creates new RasterLayers when updating the renderer.

@doneill global -> local variables done.
As to the whitespace, Shelly's said I ought to start using the auto-format file (which introduces that extra whitespace between global variables). If there's a different format on samples, happy to change it!

@TADraeseke The guideline doc you reference needs to be updated, although I don't see where it states every variable needs a line space between them.  Otherwise updates look good to merge.

@doneill When Code > Reformat Code is run using the ESRI_RTC_Java scheme, it adds all those line spaces. I can remove them manually or merge as is, depending on your preference.

@TADraeseke Hmm, ok, yeah we will need to update that as it may be ok for SDK code we can pass more globals around in app facing code.  Block them up for now and I will look to update our public facing format.
  private MapView mMapView;
  private Raster mImageryRaster;
  private Raster mElevationRaster;
  private SlopeType mSlopeType;

  private int mAltitude;
  private int mAzimuth;
  private double mZFactor;

  private ColorRamp.PresetType mColorRampType;
  private double mPixelSizeFactor;
  private double mPixelSizePower;
  private int mOutputBitDepth;
  private FragmentManager mFragmentManager;

@doneill Reformatted, including blocking globals. Reformatting code also moved listener in ParametersDialogFragment to the bottom of the code.

@TADraeseke good to merge.


Ug bugfixes

Codecov Report

Merging #193 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #193      +/-   ##
============================================
- Coverage     61.68%   61.66%   -0.02%
  Complexity      842      842
============================================
  Files           134      134
  Lines          3114     3115       +1
  Branches        349      349
============================================
  Hits           1921     1921
- Misses         1043     1044       +1
  Partials        150      150

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/seedu/momentum/model/ModelManager.java
61.44% <0.00%> (-0.38%)
36.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74006a...3723126. Read the comment docs.


status quo: Alan missing C# async

Rendered
I do have one todo left near the end. I wasn't sure if it was worth it to add an example of Alan trying to implement cancellation correctly or whether leaving it undone would show that it might be out of Alan's reach initially.
Also, should I add more C# examples earlier on to show where Alan is coming from?

It might be interesting to hear how stop-token (or, very similarly stopper) meet the c# expectations of what a stop token does

I've done a quick review and they look very promising. I'll extend the cancellation section with notes on those. I was surprised that none of those came up in my searches. I discovered that only the tokio one comes up lower in the search when I search rust async cancellation, but none of those show up when searching rust cancel future or rust cancel async.

Sorry for amending the commit. I've been working in gerrit too much lately...
I expanded the cancellable section with an example usage of one of the libaries. I wasn't sure whether to extend it with the painful aspects of discovering futures::select! for the first time or not since that's not part of std.
I also fixed some typos in the C# cancellation example and expanded on the morals. Let me know if they're still too vague.

Ecosystem crates are definitely part of the status quo. But you might be able to link to another story that mentions select!.

Thanks @Nashenas88 !


TODO: follow 4.1.0 / 4.1.1 upgrade

See-also: https://github.com/tronprotocol/java-tron/releases/tag/GreatVoyage-v4.1.0

PBFT

Ugly design, performance degradation under large networks, OpenTron will not follow

TVM

opcodes done, altbn128 update TODO

Market order support

TODO


Entur "value cannot be processed as a number"

Home Assistant release with the issue:

0.102.3
Last working Home Assistant release (if known):
I'm not 100% sure, but I think this first occured after upgrading to 0.102.1, so 0.101.3 then (because I jumped from 0.101.3 to 0.102.1).
Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io
Integration:

https://www.home-assistant.io/integrations/entur_public_transport/
Description of problem:
I get warnings on the Entur-integration.
I see this warning being spammed every 45 seconds or so. HomeAssistant tries to parse this value, but somehow it's not working. Looking at the states it seems all the values does not have a unit of measurement except the field "next_due_in". Not sure if that's the reason, but that's the biggest difference I've found. I checked the other sensors for the other platforms though and same values there. I'm just trying to optimize my HomeAssistant by removing problematic entities that might slow things down, that's why I noticed this.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
## TRANSPORT SENSOR ##
- platform: entur_public_transport
  name: Transport
  expand_platforms: true
  show_on_map: true
  stop_ids:
    - 'NSR:StopPlace:58277'   # Østerås T
    - 'NSR:StopPlace:58366'   # Jernbanetorget T
  line_whitelist:
    - 'RUT:Line:2'

Traceback (if applicable):
Log Details (WARNING)
Sun Dec 01 2019 10:19:05 GMT+0100 (sentraleuropeisk normaltid)
Value cannot be processed as a number: <state sensor.transport_osteras=12; route=2 Ellingsrudåsen, route_id=RUT:Line:2, due_at=10:32, real_time=True, delay=0, next_route=2 Ellingsrudåsen, next_route_id=RUT:Line:2, next_due_at=10:47, next_due_in=27 min, next_real_time=True, next_delay=0, attribution=Data provided by entur.org under NLOD, stop_id=NSR:StopPlace:58277, unit_of_measurement=min, friendly_name=Transport Østerås, icon=mdi:subway @ 2019-12-01T10:19:05.008350+01:00> (Offending entity: state.sensor.transport_osteras.delay)

Log Details (WARNING)
Sun Dec 01 2019 10:18:20 GMT+0100 (sentraleuropeisk normaltid)
Value cannot be processed as a number: <state sensor.transport_osteras=13; route=2 Ellingsrudåsen, route_id=RUT:Line:2, due_at=10:32, real_time=True, delay=0, next_route=2 Ellingsrudåsen, next_route_id=RUT:Line:2, next_due_at=10:47, next_due_in=28 min, next_real_time=True, next_delay=0, attribution=Data provided by entur.org under NLOD, stop_id=NSR:StopPlace:58277, unit_of_measurement=min, friendly_name=Transport Østerås, icon=mdi:subway @ 2019-12-01T10:18:20.004719+01:00> (Offending entity: state.sensor.transport_osteras.delay)

Additional information:

Thank you for making me aware of this issue. I tried to use your configuration, but couldn't replicate exactly what you are seeing. However I believe I got close enough to find the problem behind it.
Seems like the internal discovery function for looking up which platforms are active with the configuration doesn't take the whitelisting into account. That resulted in a lot of sensors that doesn't give any results, and thus no attributes (except the static ones) and an unknown state.
Working on a fix now, and it will hopefully be out on next release.

Nice! Thanks for the quick response!


Enable listening with IPv6 or IPv4 (non-Windows only)

This PR allows listening on an IPv6 address except on Windows, which it forces to fallback to IPv4.
This is to cover the case when the user specifies "localhost", which will likely detect and try to use IPv6, but for reasons yet to be determined, does not work on Windows (causing the server to be unresponsive).
It is #39 with a workaround due to lack of time/familiarity-with-Windows to fix the actual issue on Windows.

Thanks for preparing this. All good on skipping the Windows behavior trouble. Will be tagging this in my next release with some other stuff I'm working on.

This has been tagged in release 0.2.15

Thanks, that's great!  I'd still like to know what the problem is on Windows, though!  I doubt I'll find the time/motivation to look at it again as I don't use Windows for anything but if I do and find out, I'll make a PR with the fix.
If any future Windows-y developer finds this and fixes it, let me know what the issue was!  :-)


Make bots check their API keys at startup time.

For bots like giphy, it might make sense to validate API keys right in the initialize function after loading config info, just by sending a quick request to the third party server.  This can prevent the embarrassing thing of launching a bot and have people test it before you realize your API key is wrong or out of date, or whatever.
I think it's fine to just do this in on bot-by-bot basis.

I want to work with this issue. Can you please guide me?

I would start with gihpy, following my suggestions above.  You can ask for help on the "integrations" stream on chat.zulip.org.

We have updated giphy, and it's probably a good model for other third-party bots:
https://github.com/zulip/python-zulip-api/commit/6121002b351a5016150299d22a84e937d9ae35a4

Can I help? What bot(s) should I take up?

@zulipbot claim

@zulipbot claim

Done all the maintained bots.

We got a good batch of bots covered with checks now. The next step is to find some general pattern in these verifications, and apply it to the implemented verifications. After that, all remaining bots using APIs should be updated.

I'm gonna close the general issue for now, and we can open up more specific tickets if we see bots not doing this, or if we have follow up tasks that are more infrastructure-related.


Task 21,22,24,25

Activities name changed

@SwapnaThiagarajan
Task21: Not modified the updates.
Task22: Not modified the updates.

Task24: Changes Verified.
Task25: Changes Verified.


Nav Tabs use single variable to style `$nav-tabs-link-hover-border-co…

…lorand$nav-tabs-link-active-border-color`
I think it's easier to customize Nav Tabs hover and active state if we can pass in the border colors through one variable instead of a few.

 Personally, I don't think I will encounter many situations where I will only need to change the border-bottom-color, but I'm good with whatever you guys decide. Either fix makes it a lot easier to style via variables. Thanks!


Update backup-azure-arm-restore-vms.md

See #32306.

@dcbrown16 : Thanks for your contribution! The author, @geethalakshmig, has been notified to review your proposed change.

@GeethalakshmiG  - If the change is ok, please sign off.

as requested in email, i have reviewed this PR and am merging based on approval by @dcurwin .


[react-query] Fetcher headers get generated as ...([object Object])

Describe the bug
When passing headers to the fetcher config, those get generated as ...([object Object]). Maybe I'm missing something here.
To Reproduce
Steps to reproduce the behavior:
https://codesandbox.io/s/stoic-swanson-qhck5?file=/generated/index.ts Check the codegen.yml and how the headers get generated in this file.
Expected behavior
The headers to get generated as expected.

It works for me without the trailing back-tick symbol. Thanks a lot. 👍

For anyone using a JS GraphQL Config, you can stringify the object yourself until it is fixed:
fetcher: {
  endpoint: "http://localhost:3001/graphql",
  fetchParams: JSON.stringify({
    headers: {
      "Content-Type": "application/json"
    }
  })
}

I have the same error..

Hi and thank you all for the report
Sorry but I'm not adding a lot here but just labeling it according to our new Contribution Guide and issue flow.
It seems already got into stage 1 thanks to your reproduction! Thank you for that!
Now in order to advance to stage 2 we'll need a failing test, would be great if someone could help progress the issues through the stages.
Thank you and sorry that this comment is not a complete solution (yet).

I've added a test case via PR https://github.com/dotansimha/graphql-code-generator/pull/7024. It also adapts the react-query/src/config.ts type definition for HardcodedFetch.
Please let me know if everything is correct :-)

Wow thank you so much @zirkelc !!
It seems already got into stage 2 thanks to your reproductions and tests, that is a huge push for us!
The next stage 3 phase is about finding a solution for the issue locally.
If anyone wants to help, check out the instructions here on how to clone the repo and gradually become aware of the internal codebase.
We would love to help with any questions you might have!
Thank you and sorry that this comment is not a complete solution (yet).

I added a fix for fetchParams as I described it in my comment above. The new test case does succeed now:

I also generated a changeset as requested by stage 4.
Let me know in case I missed something

Available in<EMAIL_ADDRESS>🎉


Flat List Component not able to render items showing error Incompatible Receiver , Map Required.

React Native version: 0.57.5
Current Behaviour
On Fetching the Json data from remote url and while trying to render it via FlatList Component ,I am constantly getting Red-Screen with this error. I strongly guess it is related to android. Json Response is coming as seen in react-logger.
Describe what you expected to happen:
Should not get this red page error.
code
package.json
{
"scripts": {
"start": "react-native start",
"android": "react-native run-android",
"ios": "react-native run-ios"
},
"dependencies": {
"@babel/runtime": "^7.4.4",
"firebase": "^5.11.1",
"isomorphic-fetch": "^2.2.1",
"native-base": "^2.12.1",
"prop-types": "^15.7.2",
"react": "^16.8.6",
"react-native": "0.57.5",
"react-native-elements": "^1.1.0",
"react-native-firebase": "^5.3.1",
"react-native-gesture-handler": "^1.1.0",
"react-native-google-places-autocomplete": "^1.3.9",
"react-native-otp-inputs": "^2.0.1",
"react-native-phone-input": "^0.2.1",
"react-navigation": "^3.9.1",
"react-redux": "^5.0.7",
"redux": "^4.0.0",
"redux-immutable-state-invariant": "^2.1.0",
"redux-thunk": "^2.3.0"
},
"devDependencies": {
"babel-polyfill": "^6.26.0",
"babel-preset-expo": "^5.0.0",
"eslint-plugin-react-hooks": "^1.6.0",
"expo": "^32.0.6"
},
"resolutions": {
"core-js": "2.5.2"
},
"private": true
}
HomeScreen.js
import React, { Component } from "react";
import {
Text,
View,
FlatList,
ActivityIndicator,
Platform
} from "react-native";
import { Button } from "native-base";
import { connect } from "react-redux";
import firebase from "react-native-firebase";
import { onSignOut } from "../Actions/AuthActions";
import { stringify } from "qs";
class HomeScreen extends Component {
constructor(props) {
super(props);
this.state = {
isLoading: true,
dataSource: []
};
}
static navigationOptions = {
header: null
};
componentDidMount() {
// Checking user Auth State
this.unsubscribe = firebase.auth().onAuthStateChanged(user => {
this.props.navigation.navigate(user ? "App" : "Auth");
});
 Fetching the list of workers from Remote Url
return fetch("https://api.myjson.com/bins/xyz")
  .then(response => response.json())
  .then(responseJson => {
    this.setState(
      {
        isLoading: false,
        dataSource: responseJson.workers
      },
      function() {
        // In this block you can do something with new state.
      }
    );
  })
  .catch(error => {
    console.error(error);
  });

}
componentWillUnmount() {
if (this.unsubscribe) this.unsubscribe();
}
render() {
First Loadf the activity indicator till the json data is not fetched
if (this.state.isLoading) {
return (
<View style={{ flex: 1, paddingTop: 20 }}>

);
}
console.log(JSON.stringify(this.state.dataSource));

return (
  <View style={styles.container}>
    <FlatList>
      data = {this.state.dataSource}
      renderItem=
      {({ item }) => <Text>{item.name}</Text>}
      keyExtractor={(item, index) => index}
    </FlatList>
  </View>
);

}
}
const styles = {
container: {
flex: 1,
alignItems: "center",
alignContent: "center",
flexDirection: "row",
flexWrap: "wrap",
justifyContent: "center"
},
FlatListItemStyle: {
padding: 10,
fontSize: 18,
height: 44
}
};

The issues is in line " data = {this.state.dataSource}" but don't know why?
Pasting dataSource json response
[{"id":"a","name":"Kanta","gender":"F","workertype":"m","identification":"y","PoliceVerified":"y"},{"id":"b","name":"Shakku","gender":"F","workertype":"m","identification":"y","PoliceVerified":"y"},{"id":"c","name":"Churu","gender":"F","workertype":"m","identification":"y","PoliceVerified":"y"},{"id":"d","name":"Ramesh","gender":"M","workertype":"c","identification":"y","PoliceVerified":"n"},{"id":"e","name":"Ranjeet","gender":"M","workertype":"c","identification":"n","PoliceVerified":"y"}]

Yeah I have the same exact thing. Am using react-native-alpha-scroll-flat-list. It is in the state also I think and my data looks the same.


Link to 'system icons section' of material.io/icons/ is incorrect

https://material.io/icons/
Sorry – couldn't find the right place to file this issue.
The link points to https://design.google.com/spec/style/icons.html#icons-system-icons
I think it should point to https://material.io/guidelines/style/icons.html#icons-system-icons

Thanks. I'll bring this up with the spec team.

Comment on issue


HADOOP-18654. Remove unused custom appender TaskLogAppender

TaskLogAppender is no longer being used in codebase. The only past references we have are from old releasenotes (HADOOP-7308, MAPREDUCE-3208, MAPREDUCE-2372, HADOOP-1355).
Before we migrate to log4j2, it would be good to remove TaskLogAppender.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 38s

trunk passed

+1 :green_heart:
compile
25m 17s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
21m 43s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
4m  6s

trunk passed

+1 :green_heart:
mvnsite
2m 32s

trunk passed

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
1m 30s
/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 1 extant spotbugs warnings.

+1 :green_heart:
shadedclient
24m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 35s

the patch passed

+1 :green_heart:
compile
24m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
24m 27s

the patch passed

+1 :green_heart:
compile
21m 47s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
21m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m  0s

root: The patch generated 0 new + 36 unchanged - 4 fixed = 36 total (was 40)

+1 :green_heart:
mvnsite
2m 30s

the patch passed

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
4m 30s

the patch passed

+1 :green_heart:
shadedclient
31m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
27m  5s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
9m 27s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
asflicense
1m 39s

The patch does not generate ASF License warnings.

265m 18s

Reason
Tests

Failed junit tests
hadoop.metrics2.source.TestJvmMetrics

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5457

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux 44c9a339674f 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5544d7aed8a1bdea6b972471a36fbfe263a8a6d6

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/1/testReport/

Max. process+thread count
1236 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  2s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m  2s

trunk passed

+1 :green_heart:
compile
33m 12s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
37m 52s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
5m 38s

trunk passed

+1 :green_heart:
mvnsite
3m 18s

trunk passed

+1 :green_heart:
javadoc
2m  6s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
0m 39s
/branch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common in trunk failed.

-1 :x:
spotbugs
0m 37s
/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
hadoop-mapreduce-client-core in trunk failed.

+1 :green_heart:
shadedclient
15m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 49s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
mvninstall
0m 22s
/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
hadoop-mapreduce-client-core in the patch failed.

-1 :x:
compile
0m 22s
/patch-compile-root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
root in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javac
0m 22s
/patch-compile-root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
root in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
compile
0m 22s
/patch-compile-root-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
root in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-1 :x:
javac
0m 22s
/patch-compile-root-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
root in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 22s
/buildtool-patch-checkstyle-root.txt
The patch fails to run checkstyle in root

-1 :x:
mvnsite
0m 23s
/patch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
mvnsite
0m 33s
/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
hadoop-mapreduce-client-core in the patch failed.

-1 :x:
javadoc
0m 22s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 52s

the patch passed

-1 :x:
shadedclient
9m 16s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 31s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
unit
0m 26s
/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
hadoop-mapreduce-client-core in the patch failed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

155m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5457

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux f9a85e5f5c6c 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5544d7aed8a1bdea6b972471a36fbfe263a8a6d6

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/2/testReport/

Max. process+thread count
184 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 40s

trunk passed

+1 :green_heart:
compile
31m 10s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
27m  2s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
4m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 54s

trunk passed

+1 :green_heart:
javadoc
1m 52s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
1m 48s
/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 1 extant spotbugs warnings.

+1 :green_heart:
shadedclient
24m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 47s

the patch passed

+1 :green_heart:
compile
30m 18s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
30m 18s

the patch passed

+1 :green_heart:
compile
26m 19s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
26m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m  1s

root: The patch generated 0 new + 36 unchanged - 4 fixed = 36 total (was 40)

+1 :green_heart:
mvnsite
2m 41s

the patch passed

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 14s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m  7s

the patch passed

+1 :green_heart:
shadedclient
24m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 59s

hadoop-common in the patch passed.

+1 :green_heart:
unit
7m 14s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

271m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5457

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux dd4a4865b8ec 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5544d7aed8a1bdea6b972471a36fbfe263a8a6d6

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/4/testReport/

Max. process+thread count
1308 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 10s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 25s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m  8s

trunk passed

+1 :green_heart:
compile
31m  0s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
26m 51s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
4m  9s

trunk passed

+1 :green_heart:
mvnsite
2m 58s

trunk passed

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
1m 49s
/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 1 extant spotbugs warnings.

+1 :green_heart:
shadedclient
24m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 48s

the patch passed

+1 :green_heart:
compile
30m 14s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
30m 14s

the patch passed

+1 :green_heart:
compile
26m 13s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
26m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 57s

root: The patch generated 0 new + 36 unchanged - 4 fixed = 36 total (was 40)

+1 :green_heart:
mvnsite
2m 39s

the patch passed

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 12s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m  4s

the patch passed

+1 :green_heart:
shadedclient
24m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  7s

hadoop-common in the patch passed.

+1 :green_heart:
unit
7m  9s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

272m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5457

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux 9ac5b98c2ca1 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5544d7aed8a1bdea6b972471a36fbfe263a8a6d6

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/3/testReport/

Max. process+thread count
1244 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5457/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

The only use of this class among Apache projects is in Chukwa which is in attic.
But a number of Apache projects (Ambari, Bigtop, among others) has log4j.properties referencing TaskLogAppender. (https://github.com/search?l=Java+Properties&p=2&q=org%3Aapache+org.apache.hadoop.mapred.TaskLogAppender&type=Code)
If this is a Hadoop 3.4.0 only change then it's okay.

If this is a Hadoop 3.4.0 only change then it's okay.

Oh yes, this is for 3.4.0 only, at least that's what I am proposing for this Jira.

I will update Jira releasenotes to indicate that downstreamers should use RFA and not TLA (TLA is anyways not public/stable)

I will update Jira releasenotes to indicate that downstreamers should use RFA and not TLA (TLA is anyways not public/stable). TLA is private and marked unstable.

This is done.


Unimplemented intrinsics required to codegen Firecracker vmm

Not implemented intrinsics:

atomic_xchg
atomic_xchg_acq
atomic_xchg_acqrel
atomic_xchg_rel
atomic_xchg_relaxed
try

We have atomic_cxchg* implemented so it should be easy to support these atomic intrinsics. try seems a little harder though.


Update akka-projection-core, ... to 1.2.0

Updates

com.lightbend.akka:akka-projection-core
com.lightbend.akka:akka-projection-eventsourced
com.lightbend.akka:akka-projection-kafka
com.lightbend.akka:akka-projection-slick

from 1.1.0 to 1.2.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.1.0).
You might want to review and update them manually.
project/Dependencies.scala

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lightbend.akka" } ]

labels: library-update, semver-minor, old-version-remains

This PR needs some QA

handled in this https://github.com/namely/chief-of-state/pull/312


Revert "chore: enable jemalloc on rocksdb itself (v0.5 backport)"

Reverts fedimint/fedimint#6493, lead to problems at Fedi. @dpc lmk how you want to play this. Maybe we can also only activate it for the server?

Should we cut another release candidate once this is merged?

Should we also revert the backport to releases/v0.4?
https://github.com/fedimint/fedimint/pull/6499

I'll just make it work at Fedi.


change the command names

Could you change the command names to:
gpt
gptFile
gptRun
or
chatGPT
chatGPTfile
chatGPTrun
etc...
The reason is that, it is annoying to uppercase the first letter (g) all the time when using it in (n)vim  :(

Do you not use the mappings?
with the mappings you can just say gpt/gpf/gpr in normal mode to use them

Oh! Haven't tried them...
But, still, consider to changing the command names for the sake of command-mode.
Thx.

Oh, I was just about to add this in. But I've gotten an error:
E183: User defined commands must start with an uppercase letter

So I will not be pulling this change in.
One thing I will have to do yet is change up the readme to make the mappings stand out more, as those are really the best way to use the plugin I'd say, much faster, no need to ever really write the


save flie  slow

let path = std::path::Path::new("./1.xlsx");
let mut book = umya_spreadsheet::reader::xlsx::lazy_read(path).unwrap();
let  sheet1=book.get_sheet_by_name_mut("Sheet1").unwrap();
sheet1.get_cell_by_column_and_row_mut(&1, &1).set_value("value");
//save
let _ = umya_spreadsheet::writer::xlsx::write(&book, path).expect("save error!");

I only change  one data of the table, but it takes a long time to save

Thank you for your report.
Does Sheet1 of the file that is causing the problem contain a large amount of data?
If so, lazy_read will not be very effective.
It takes a long time to read and save the file.
In the case of lazy_read, it is effective when editing a sheet that does not contain a large amount of data.

You can refer to the implementation of golang, which  read and write file fast
github.com/xuri/excelize

Thank you very much.
That sounds like a good hint about speeding up the process.
I will refer to it.

The write process has been reviewed and is now 4 times faster.
Please try the latest version.

It solved the problem perfectly.
Thank you for your work.


Sync eng/common directory with azure-sdk-tools for PR 5040

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/5040  See eng/common workflow

/check-enforcer override


Enable an option to purge all of '/etc/cron.d'

Primary: @hashbrowncipher
I think we have finally arrived. We are at the point where I think we, at yelp, can purge all the cron jobs.
  This would basically enshrine a policy that OS packages cannot use /etc/cron.d (unless whitelisted).  I imagine this will be surprising for someone expecting certain functionality from their packages.  As an example, atop restarts nightly in order to rotate its logfile.  It could be quite painful for someone who expects this default behavior if they installed atop, forget to add to the whitelist (they totally will), and experience broken behavior.
It's just a bit too silent for my tastes.  That said, I would be happy to enable purging for a short period of time to remove all of the cruft you've identified.
Could you clarify your goal?  Is it to create a new policy?  Is it to clean up existing infrastructure?

I agree that would be surprising, that is why it defaults to false.
At Yelp I'm suggesting a new policy, and that is to have cronjobs that are not configured in puppet.
Are you suggesting I should turn it on for only a short while, let the cruft clear, and then turn off the purging?

Yes, I think such a policy would be pretty surprising, even at Yelp.  Most people don't inspect the contents of packages before installing them, so I think we'll break functionality for those people, in a possibly painful way (probably involving disks, simultaneously filling).  I'm willing to be convinced otherwise.
At Puppetconf, @jolynch and I discussed the possibility of Puppet resource types capable of purging files, but which automatically ignored files installed by packages.  I think that's what we want here, because ideally Yelp would have a policy of "You may have any cronjob you like, so long as it comes from Puppet or a package".  I've sketched such a possibility as pseudocode in a gist

Closing for now, I agree this is a bit aggressive.


[Bug]: API models endpoint problems.

What happened?
There are currently quite a few problems with the models endpoint, these are the one's I could find:

The sort parameter sometimes returns results that are not right, for example, when searching: https://civitai.com/api/v1/models?limit=15&sort=Newest&period=AllTime&query=dream
It shows 15 models (as requested) but none have any modelVersions it seems they are all already deleted from CivitAI.
Additionally it does not contain a nextPage URL, it seems that this happens whenever all the returned models have empty modelVersions as it does supply a nextPage when the same request is used with a higher limit as it then contains some models with non empty modelVersions:
https://civitai.com/api/v1/models?limit=40&sort=Newest&period=AllTime&query=dream

The nextPage is broken very often resulting in an internal server error, example URL:
https://civitai.com/api/v1/models?limit=15&period=AllTime&query=dream&sort=Most Downloaded&cursor=12976%3A2764%3A4481

The types parameter does not seem to influence search results if a query parameter is used in the same request, example URL:
https://civitai.com/api/v1/models?limit=15&query=dream&types=LORA
https://civitai.com/api/v1/models?limit=15&query=dream

Steps to reproduce the problem
Attempt to use any of the API Request URLs provided as examples.
What should have happened?
API should function as expected.
What platforms do you use to access the site?
Windows
What browsers do you use to access the site?
Brave
Additional information, context and logs
No response

Same issues here.


getlongestrepeatedsubstring doesn't work as expected on "CAAAABDAAAABD"

getlongestrepeatedsubstring returns "AAA" instead of "AAAABD" for the string "CAAAABDAAAABD"

You need to add the "$" terminator (Char '$') to the end.  Added to the tests.
tests = [
	("CAAAABAAAABD\$", "AAAAB"),
	("GEEKSFORGEEKS\$", "GEEKS"),
	("AAAAAAAAAA\$", "AAAAAAAAA"),
	("ABCDEFG\$", ""),
	("ABABABA\$", "ABABA"),
	("ATCGATCGA\$", "ATCGA"),
	("banana\$", "ana"),
	("abcpqrabpqpq\$", "ab (or) pq"),
	("pqrpqpqabab\$", "ab (or) pq"),
	("CAAAABDAAAABD\$", "AAAABD"),
	("CAAAABDAAAABD", "AAA"),

]
println("Longest Repeated Substring in:\n")
for (test, ans) in tests
	st = SuffixTree(test)
	@show getlongestrepeatedsubstring(st) == ans
end

Passes all.

I will update with a change in the constructor for SuffixTree: add a default to add a terminator so that this issue will not arise for you when you leave off the terminator.

See https://github.com/wherrera10/SuffixTrees.jl/commit/2c5495957e0129180d50beb2d9383c6fe000bd5b


Changelog structure change to achieve some improvements

Hi @Danp2 , hi @mlipok , hi to the other contributors 😀 ,
I already announced that I want to create an Issue (later on a Pull Request) for the CHANGELOG.md structure.
Now here we are 😅 :

A changelog should make it easier for users and contributors to see precisely what notable changes have been made between each release (or version) of the project.
https://keepachangelog.com

Please have a look on that page to get an idea why I want to change the structure. It didn't make much sense to say it on my own - the page describe it even better than I could.

I am already happy to see that it's not a REVISION.MD file anymore => 👍 @Danp2.
As a showcase how it would look like, see my forked project.
One nice advantage is the comparison between the releases (or the tags of the releases). Just click on a version and you will get the commits and all the file changes which make it very handy to get a deeper view about the actually changes 😀 .

What did I change so far:

As you can see there is the version number and the date which matches the date of the release.
I changed it to categories (Added, Changed, Fixed etc.) which make the file more readable in my opinion.

That part was a bit tricky with RegEx, but it works and a good diff was also very helpful 😅 .

I added the missing release [<IP_ADDRESS>.1] - 2019-04-30.

💡 What is open and will be hopefully discussed:

The change to Semantic Versioning which is really common since few years and pretty easy to understand.

My suggestion is to start the next release with 1.0.0 or with 5.2.0 (based on the current version <IP_ADDRESS>) when we want to stick with the other schema without the leading 0.

Legend - Types of changes:

Added for new features.
Changed for changes in existing functionality.
Deprecated for soon-to-be removed features.
Removed for now removed features.
Fixed for any bug fixes.
Security in case of vulnerabilities.

What do you think about this all 🤞 ?
Best regards
Sven
Stay innovative!

Please have a look on that page to get an idea why I want to change the structure. It didn't make much sense to say it on my own - the page describe it even better than I could.

I actually ran across that site earlier today.

What did I change so far

It looks nice at first glance. I'll take a closer look later.

I added the missing release [<IP_ADDRESS>.1] - 2019-04-30

Man... you guys are tough! 😮  Not required IMO, but whatever.

My suggestion is to start the next release with 1.0.0 or with 5.2.0 (based on the current version <IP_ADDRESS>) when we want to stick with the other schema without the leading 0.

Up til now I've always viewed this UDF as being in beta, so the 0.x version made sense to me. Now that it's been "polished" and has a help file, maybe it's time for the jump to 1.0. 🤔

Semantic Versioning

Let's definitely discuss this further. I'm confused by their summary section because their description of the major, minor, & patch labels doesn't seem to apply IMO.

Now that it's been "polished" and has a help file, maybe it's time for the jump to 1.0.

It may sound bad, but ... lets wait few next months.
I hope we will review some other functions which I mention in other Issues.
At least I must end my wd_capabilites.au3 refactoring.

@mlipok

I hope we will review some other functions which I mention in other Issues.
At least I must end my wd_capabilites.au3 refactoring.

I'm not sure if that should really be a reason not to upgrade the version.
I will think about it and sort my argues, be prepared 😅 .
@Danp2
I'm happy to read that there is no general disagreement or rejection. Of course we can and should discuss details, but I look to a positive future.

I will think about it and sort my argues, be prepared 😅 .

So this time I'll let it go ;)

@Sven-Seyfert Will you be submitting a PR on this?

Will you be submitting a PR on this?

Of course I can. But as far as I understood we want to wait a bit, at least until @mlipok finished his work on wd_capabilites.au3?
After that I planned to create the PR or should I do it now @Danp2 ?

There isn't any reason to hold off on switching the changelog formatting, so feel free to submit PR now.


Bugfix #175 naming conventions stefanlack

@adyachok : please see this pull request with refactoring / improvements and testing.
Please note that org.opendevstack.provision.controller.E2EProjectAPIControllerTest#testQuickstarterNamingBeNodeExpress is ignored. The reg expression for component be-node-express is invalid.

Note: this are the commits I added today:

https://github.com/adyachok/ods-provisioning-app/pull/1/commits/fa0b14de69a72fc1c19e0631333557eba27aa835

@adyachok : are you going to use my changes and will you merge my pull request into your branch?


Feature/more string methods

What's Changed:
Adds collapseSpaces and wrap methods to string type.
Type of Change:

[ ] Bug fix
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

[x] Tests have been updated to reflect the changes done within this PR (if applicable).
[x] Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

Apologies I will get around to this! Will try my best to have a look tomorrow for you mate

Apologies I will get around to this! Will try my best to have a look tomorrow for you mate

At your leisure. No rush. :D

Thanks for this!


Check seeds are always logged

The WG has discussed requiring logging the seeds for official submissions. This PRs contains the changes to reflect that:

Check seeds are always logged
Remove unnecessary warnings and outdated tests
Update comments

Only merge if seed requirement is approved by the WG and changed in the policies/training_policies repositories

@pgmpablo157321 could we add support to bypass this seed check in case someone wants to resubmit logs from a previous round and those logs don't have the seed value being reported?

@ShriyaPalsamudram I added the flag to skip the seed checker.
@hiwotadese for visibility


Sprint Planning

Based on our discussion at standup this week, I relayed our discussion to Robert and he felt that being a week off sync (based on my 4 week sprint proposal) from the user team may be a nuisance. After speaking more with Orta I think we could try 3 weeks, see how it goes and add more time if we feel it is necessary. As I outlined above, this suggests that we should base the scope of each sprint off a 2 week development period (writing new code) instead of a full 3 weeks. We leave the last week then for QA and bug fixing with a goal of deploying a new build at the end of the 3rd week.
This is not by any means final I am looking for your feedback!!!

I think this looks great 👌 Possibly the only thing we might want to plan in is to force doing another short round (e.g. 1 day) of stress testing after fixing bugs and before submitting. Regressions are more easily made in the heat of the moment.
2, 2½, or 3 weeks is just arbitrary at this point anyways, so see if it works and adjusting based on experience sounds like the way to go :+1:

Looks good to me!

One of the aspects that I found interesting is that it gives a nice cadence to features vs bug fixing. It's hard to get a sense that we'd be doing "too much cleanup / bug fixing" when 1/3rd of the time is spent on it. But always better to start with something and evolve then to try mastermind something perfect IMO.

Hey team @ashfurrow @1aurabrown @orta @alloy
I will be sending a larger email update soon but wanted to let you all know that after speaking with @alloy  Robert and @orta we'll be splitting off from the User Experience Team and holding our own prioritization meetings as the Consumer Mobile Apps team (Eigen and Eidolon). This will include a new sprint schedule that runs six weeks instead of the previous three.
We'll start the sprint with a prioritization meeting where we discuss what we want to include in our next release. We will have support from product ops to looking into KPIs to identify how the app is preforming. There will be four weeks of "build time" after which we will get together to discuss what got done in the build phase, what didn't and why, and determine what will make it into the release candidate. The following two weeks will be spent perfecting the release candidate (bug fixes etc.) and we will release at the end of the six weeks.

Even though the sprint is 6 weeks long, our prioritization and planning should be based on what we think we can feasibly build in 4 weeks. We will use that hard stop to evaluate how good we were at estimating and what adjustments we can make for the future.
To help facilitate, @alloy will be Eigen's lead engineer, practically meaning that he will be responsible for assigning issues. Issues will by default be assigned to him and other team members and he will offload to the rest of the team, seeing as he has a better understanding of everyone's strengths and weaknesses (more than I do!)
I think operating as a separate team will be great for us and will allow us to focus more on how we're impacting Artsy.
Let me know your thoughts or if you have any questions!

Sounds really awesome!

This is what we’re doing now :+1: Closing for now.


Bump scylla version to 5.4.6 and use it for all of the nodes

Previously scylla integration tests used scylla 5.2.9 and tablet tests used scylladb/scylla-nightly.
This PR changes scylla version to scylladb/scylla:latest for all of the nodes so as not to use an outdated version, but at the same time not to risk stability.

The CI does not work. It looks like there is a problem with the scylla.yaml file (that is the main difference between node1 and the rest of nodes) when using scylla version higher than 5.2.x
https://github.com/scylladb/gocql/blob/master/testdata/config/scylla.yaml

@sylwiaszunejko , in general I think it is bad idea to run tests on dynamic tags, better pick something static and update it time to time

@sylwiaszunejko , in general I think it is bad idea to run tests on dynamic tags, better pick something static and update it time to time

I agree after I saw the logs from failing container I agree we should be more thoughtful about changing these versions.

CI is failing due to merging #188 by mistake.
After #189 is merged CI should work fine here.

CI works now


Always on top and PiP for Chrome

Microsoft PowerToys version
0.53.3
Running as admin

[ ] Yes

Area(s) with issue?
Always on Top
Steps to reproduce

Use picture in picture plugin (https://chrome.google.com/webstore/detail/picture-in-picture-extens/hkgfoiooedgoejojocmhlaklaeopbecg)
Exit PowerToys
Open PowerToys
Exit PiP

✔ Expected Behavior
The colored boarder to disappear when PiP ends.
❌ Actual Behavior
The colored boarder persists when PiP ends.
Have to re-enable PiP and disable Always on Top with Hot Key before ending PiP; but this causes future PiP windows to lose the always on top ability.
Other Software
Picture-in-Picture Extension (by Google)
Chrome

Duplicate of #15300

Thanks for reporting this. This issue is a duplicate.
I'm linking this issue to #15300 to centralize the discussion thread for tracking.
Thanks for your help to make PowerToys a better piece of software!


Feature/53/issuer v2

Added endpoints in relation to issuer-v2

Why are we using header parameters? We should use query parameters please.


Don't use setuptools option.data_files to install bash-completion

it requires setuptools >= 40.6.0 (rhel/centos/epel-8 has 39.2.0)
it installs it into bash_completion/ while we (epel/fedora) need bash-completion/

recheck


Navigation Button Not Working Nav Open

Nav Open Button (Issue with nav-open-btn):
Expected Behavior: The nav-open-btn should allow users to open the navigation bar when clicked, displaying the menu options.
Actual Behavior: Clicking on the nav-open-btn does not open the navigation bar, rendering the menu inaccessible.
Possible Cause: The data-nav-toggler attribute for the nav-open-button is not connected to an event listener, making the button non-functional.

I have fixed this issue.

I have fixed the issue

I have fixed the issue!

i have fixed the issue


i have a problem

can i set indicator null ?
i want have number,but not have background
thank you!!

If you need it as a number, why do you want it to be null?
Can you explain more, please?


IE11 support

It should be possible to support IE11, as IE11 supposedly supports getting the computed style of pseudo-elements.  When I smoke-tested it in IE11 however, it didn't work (no errors were thrown either).

IE 11 support would be really helpful.


Should we reexport ChainedError or error_chain itself?

This trait is really important to use with a code like e.display_chain().to_string().
But there is no reason to depend on this crate in every project and keep its version in sync with jni-rs.

Closing this since the most likely move will be to abandon error_chain in favor of Failure.


OCPBUGS-32370: Add TLS config to CSI driver daemonset

Replace ${TLS_CIPHER_SUITES} and ${TLS_MIN_VERSION} in node DaemonSet manifests. Re-using functionality that we already have for Deployments.
cc @openshift/storage

/hold
After 4.16 is branched.

/hold cancel
They say 4.16 is branched


Feature request: Semantic production code coverage information in sqlite database

The sqlite database table "context" already contains semantic information "context". As far as I know the type of the context is limited to "test" right now.

context_id
context

1
test_some_method

2
test_some_function

The sqlite database tables "line" and "arc" contain line/branch based production code coverage information.
Could we add production code coverage information with semantic meaning? This could be done either as (option a) a separate table "semantic" or as (option b) part of the line and arc table as additional info?
option a (separate "semantic" table):

file_id
context_id
module
class
method
function

1
1
some_module
SomeClass
some_method

2
2
some_module

some_function

option b (line table with additional info):

file_id
context_id
module
class
method
function
lineno

1
1
some_module
SomeClass
some_method

17

1
1
some_module
SomeClass
some_method

18

...

2
2
some_module

some_function
34

2
2
some_module

some_function
35

...

For some consistent, exemplary database table content refer to python-tia/coveragepy_database_tables.ipynb.

It's a bit off-topic in this issue but because you mentioned dynamic contexts: For advanced test impact analysis it would be helpful to track fixtures, setup functions, teardown functions, etc. means everything which relates to test code, which is executed as part of a single test execution and which would in case of a change imply the need for a re-execution of one or several affected test(s). Let's call it kind of "test code coverage". Is something like that in the scope of dynamics contexts?

My plan is that the dynamic context could be determined by plugins, so someone could write as complex a determination as they want.  I'm sure pytest (for example) has enough information to set the context based on fixtures, setup, etc.
My theory is that a plugin that can set a string as the context will be sufficient.  Do you agree? Or is something more elaborate needed?

My theory is that a plugin that can set a string as the context will be sufficient. Do you agree? Or is something more elaborate needed?

I agree.
It should be possible to map test code specific dynamic contexts to single tests of course. I don't know how coveragepy interacts with test runners exactly. All information should be there: The test runner knows the executed test and coveragepy knows what's executed as part of this test.

Coverage.py 5.0a5 now supports context plugins and an API entry point for test runners to use to set the context.  There's a branch of pytest-cov that sets the pytest test id, and phase (setup, call, teardown) as the context.  Is that getting closer to what you want? https://nedbatchelder.com/blog/201905/coveragepy_50a5_pytest_contexts.html

Wow, that looks nice. According to your blog post the context table contains entries which allow to link test specific setup
5           test_it.py::test_prod2|setup

to file id(s) and line regions in the arc table (file_id, context_id, fromno, tono)
1 5 25 46

, right? (The file id to file mapping is contained in the file table as usual.)
I'll have a look into the data.

The pytest-cov plugin now provides good support for tracking test ids: https://nedbatchelder.com/blog/201910/pytestcov_support_for_whotestswhat.html .  I'm going to close this for now, let me know what you find when you try the latest code.


feat: check duplicate dependencies

fixes #715
e.g. if you add:
[dependencies]
python = "3.11.*"
flask = "2.*"
Flask = "2.*"

pixi run fails as:
  × failed to parse pixi.toml from /home/orhun/gh/pixi/examples/flask-hello-world
  ╰─▶ duplicate dependency: Flask

I'm not sure if it is possible to collect different fields (run, build, host dependencies) and check for duplicates in them 🤔

Could just throw an error if capitalization is used right?

I'm not sure if it is possible to collect different fields (run, build, host dependencies) and check for duplicates in them 🤔

In that case I think its fine, because these can overwrite each other.  This is OK (although weird):
[dependencies]
foobar = 1

[build-dependencies]
foobar = 2

Could just throw an error if capitalization is used right?

Thats an alternative approach, to only allow normalized names in the pixi.toml.

I added a function for deserializing dependencies in a1df903666b50d9a83aa0092f97ee2a31ad0772b
I can add tests if you think it looks good.

I think it is best to removed to chaining of the different dependency fields. As I just understood bas' comment. We broke the functionality with this changed.
My plan was to error on:
[dependencies]
foobar = "*"

[build-dependencies]
FooBar = "*"

But we now also error, but shouldn't on:
[dependencies]
foobar = "*"

[build-dependencies]
foobar = "*"

The plan to avoid any capitalization is still a thought but might be breaking. Lets throw it in the community.

I see, so just checking the uppercase for each dependency section is enough?

No its not. Especially Pypi dependencies have more rules than just lowercasing (dashes, dots and underscores).
Would this work?
#[serde(default)]
#[serde_as(as = "IndexMap<DisplayFromStr, PickFirst<(DisplayFromStr, _)>>")]
dependencies: IndexMap<NormalizedPackageName, NamelessMatchSpec>,

Not really.
NormalizedPackageName is deserialized from the FromStr implementation (via DisplayFromStr):
impl FromStr for NormalizedPackageName {
    type Err = ParsePackageNameError;

    fn from_str(s: &str) -> Result<Self, Self::Err> {
        Ok(PackageName::from_str(s)?.into())
    }
}

And it is basically the same thing as PackageName.

A maybe thats something we can change! We could implement a custom DeserializeAs (StrictNormalizedName) or whatever, that requires the normalized name to be the same as the non-normalized name?

Thanks for the tip @baszalmstra!
I went with a waaaay simpler approach in c70586c670a445369c09dcc6108e005234f210bb

That's totally reasonable. I'm happy to take the second route and ping you in case I need any guidance 🐻

@baszalmstra I took a look at this again and there are a couple of points that I want to clarify:

Write a custom Deserializer that while it builds the mapping also checks each key of the map for duplicates.

I came up with this:
fn deserialize_package_map<'de, D>(
    deserializer: D,
) -> Result<IndexMap<PackageName, NamelessMatchSpec>, D::Error>
where
    D: Deserializer<'de>,
{
    struct PackageMapVisitor(PhantomData<()>);

    impl<'de> Visitor<'de> for PackageMapVisitor {
        type Value = IndexMap<PackageName, NamelessMatchSpec>;

        fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
            write!(formatter, "a map")
        }

        fn visit_map<A>(self, mut map: A) -> Result<Self::Value, A::Error>
        where
            A: MapAccess<'de>,
        {
            let mut result = IndexMap::new();
            while let Some((k, v)) = map.next_entry::<String, String>()? {
                let package_name = PackageName::from_str(&k).map_err(serde::de::Error::custom)?;
                let match_spec =
                    NamelessMatchSpec::from_str(&v).map_err(serde::de::Error::custom)?;
                if result.insert(package_name, match_spec).is_some() {
                    return  Err(serde::de::Error::custom(
                        "invalid dependency: please avoid using capitalized names for the dependencies",
                    ));
                }
            }

            Ok(result)
        }
    }
    let visitor = PackageMapVisitor(PhantomData);
    deserializer.deserialize_seq(visitor)
}

However, this is used with serde(with) attribute which means we can no longer use serde_as:
- #[serde_as(as = "IndexMap<_, PickFirst<(DisplayFromStr, _)>>")]
+ #[serde(default, deserialize_with = "deserialize_package_map")]
dependencies: IndexMap<PackageName, NamelessMatchSpec>,

Also, in the case of Option<IndexMap<...>, this won't work.

Both allow non-normalized names but check for duplicates and have contextual errors

Right now we get:
  × failed to parse pixi.toml from /home/orhun/gh/pixi/etc/issue717
  ╰─▶ failed to parse project manifest
    ╭─[pixi.toml:11:1]
 11 │
 12 │ ╭─▶ [dependencies]
 13 │ │   python = "3.11.*"
 14 │ │   flask = "2.*"
 15 │ ├─▶ Flask = "2.*"
    · ╰──── invalid dependency: please avoid using capitalized names for the dependencies
    ╰────

What do you mean by allowing non-normalized names? Isn't this a contextual error?

Probably using some custom DeserializeSeed implementations.

I took a look at the DeserializeSeed example and couldn't wrap my head around how that can be applied to this case. If I understood correctly, it is used when there is an already allocated type that we want to pass into a Deserializer. In our case we can probably allocate the map inside the Deserializer as well.
Maybe I got it wrong though. Do we have any usages of DeserializeSeed already that I can use as an example?

@orhun that's indeed what I had in mind. We indeed lose serde_as which is fine I think.
Instead of deserializing the key value pairs as Strings you could directly parse them as PackageName and NamelessMatchSpec (or some wrapper type to allow custom deserializers). The NamelessMatchSpec can be deserialized using serde_untagged instead of using serde_with (its either a string or the mapped object itself).
The only remaining issue is that now any error is emitted at the level of the entire dependencies block. I think there you could use a DeserializeSeed implementation for the package name which you pass a mutable reference (or some *Cell type) to the map in construction. The deserializer impl then checks if an entry with the same key already exists and errors there. That will then raise the error for the key itself instead of for the containing block. Hopefully, that yields error Valhalla bliss!

Made the requested changes in ea724bf28db7372d7f2e6fb455188ca058be6c15
2 things:

I added deserialize_package_map and deserialize_opt_package_map for deserializing Option<T> and T - not sure if there is a cleaner way of doing this.
How should we test this? Is adding unit tests for deserialization enough?

@ruben-arts Please test to see if you liky!

First thing I tried was this:

:sweat_smile:
I do see that as an issue, should we make an issue for it to merge this or do you think it is easy to fix with this PR. I'm fine either way as it already is an improvement over the current state.

What do you mean? The error indicates there is a duplicate flask entry which is indeed the problem?

What do you mean? The error indicates there is a duplicate flask entry which is indeed the problem?

The add still lets you add a duplicate, leaving the toml in a broken state. I don't think we should never do that.

Should we also check duplicates for the pixi add command? Maybe that can be handled in a separate PR.


getEvents("2023-08-21") not working

Evaluation Error: TypeError: Cannot read properties of null (reading 'getEvents')
    at eval (eval at <anonymous> (plugin:dataview), <anonymous>:1:110)
    at eval (eval at <anonymous> (plugin:dataview), <anonymous>:7:4)
    at DataviewInlineApi.eval (plugin:dataview:18404:16)
    at evalInContext (plugin:dataview:18405:7)
    at asyncEvalInContext (plugin:dataview:18412:16)
    at DataviewJSRenderer.render (plugin:dataview:18436:19)
    at DataviewJSRenderer.onload (plugin:dataview:18020:14)
    at e.load (app://obsidian.md/app.js:1:631421)
    at DataviewApi.executeJs (plugin:dataview:18954:18)
    at DataviewPlugin.dataviewjs (plugin:dataview:19559:18)

used the dataview example here: https://github.com/muness/obsidian-ics/pull/33

Hi, sorry about the delay. Can you try making sure the plugin id is set to ics (instead of obsidian-ics).


Design usability features

We have the following possible usage scenarios that we should consider for UX improvements:

Send sats from the on-chain channel to the fiat channel.
Pay an invoice only from fiat channels.
Pay an invoice only from non-fiat channels.

P.S. These scenarios were irrelevant for originally hosted channels as sats in them had the same value that in ordinary channels.

Agreed with them however I think the technology should be in priority right now.


Invalid sample at the end of a race

One sample is added for some reason after the race has ended - with strange values that might break some calculations.

probably done in release 1.8

after a test run, the logger detected a new race while i was in the service area. a new progress bar was shown without anything happening. when i really started the race, the logger crashed.
the reason is probably that DR2 sometimes sends a broken message at the end of a test run. couldn't reproduce afterwards. saving the data from the broken message should help with debugging.

hopefully fixed in release 1.8.1


select2 add i18n for other locale

for select2 blade file, I added language parameter when initial the select2 element.
@if (app()->getLocale() !== 'en')
    language: "{{ str_replace('_', '-', app()->getLocale()); }}",
@endif

Added for language support

A new inspection was created.

The inspection completed: No new issues

Hmm this is interesting @shiroamada .
Maybe there's room here to clear up which format we should use for the language string. It's always been one of those questions in Laravel that I didn't know the answer to. And I think you can tell by our lang folder - seems like we're a bit all over the place now, trying to cover all the bases 🙄 I've double-checked and I see Backpack provides:

both da-DK and da_DK
both fr-CA and fr_CA
both pt-BR and pt_BR
zh-cn
zh-Hant

Also, the only relevant standards I could find are RFC 5646 and [https://tools.ietf.org/html/rfc4646](RFC 4646), both of which encourage dash (not underscore). PHP also gives the same thing as an example.
So I guess the question becomes: why did you choose to make your language zh_CN and not zh-CN? I'm genuinely asking, since I rarely work with dash-languages. Are other important packages using zh_CN and you're stuck with it or something?
The reason I'm asking is that... since the JS library already uses RFC 5646, if you'd use zh-CN... this PR wouldn't be needed any more, right?
Thanks for the PR - really appreciate it. Just trying to get a handle of it since I don't work with dash-languages very often.
Cheers!

Hello @shiroamada , thanks for the PR. 👍
@tabacitu this is something we are already aware, more info at: https://github.com/Laravel-Backpack/CRUD/issues/3537
We should fix this in next version, or in this one using aliases ?

Thanks for your reply. I didn't notice that there is a RFC standard on it.
I was follow by https://github.com/Laravel-Lang/lang/tree/master/locales/zh_CN. I already search people comment about it.
https://github.com/Laravel-Lang/lang/issues/1073
Another popular Laravel-Lang, I believe is created by Chinese, because of the readme also given Chinese explanation.
https://github.com/overtrue/laravel-lang
I went to China Laravel website, they also have people discuss about it.
https://learnku.com/laravel/t/5933/should-the-chinese-language-package-be-zh-cn-or-zh-cn
I also no idea which one is the correct solution. Something new to me.
This one I think should be putting in debate :) Or the best Backpack can support both~

Wow - thanks for the detailed explanation @shiroamada . I had no idea things were so divided. Using str_replace() in this case seems like a sensible solution, thanks 🙏 We should probably assume people are using pt_BR then (but be ready for both).
@pxpm I believe we can support both in 4.1 already, with copy-pasted folders. It'll be duplicate code, but hey... at least we help those people... Then in Backpack 4.2 we can delete the pt-br-like directories and stick to ISO 15897 (pt_BR) if that's what both Laravel and the most popular Laravel language package recommend. Even if we don't agree, it'll be easier for our users to just stick to the standard.

A new inspection was created.

A new inspection was created.

The inspection completed: No new issues

The inspection completed: No new issues

@tabacitu in my opinion this PR is ready 👌
Since select2 uses kebab-case (pt-BR, en-US, ...) we can make sure the locale is always in that format by replacing _ with -.
Meanwhile, you've closed #3537, and that is another task, a BC for 4.2, clean those duplicated locale folders.
So I'll open #3537, and leave there a note.

@tabacitu I agree with that if we have more cases like select2, where we need the app locale "hyphenated".
Let's keep this in mind, and if we ever need the hyphened_app_locale() again, we proceed to the helper ✌


adding clarifications

Description
Attempting to make the experience a little more informative and easier to set up for first time users.
[Describe what this change achieves]
Based on some first hand experiences, I've seen new users struggle with how to correctly configure this cookbook.  This is just one attempt to make the path easier for them.
Issues Resolved
[List any existing issues this PR resolves]
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Thanks @jeremymv2 for this improvement!


Apply Pay/Wallet not opening - iPhone X 2.1.2 B34

Wallet and Apple Pay not opening - freezes in settings, white screen when trying the app. Does not work in non jailbroken state either.
Verizon.

This is not a issue with Unc0ver. @Cryptiiiic please close this issue.


BLD: New pandas 🐼

Coverage increased (+0.02%) to 83.043% when pulling c8fe5f3bf5d1e7378b5932f862baa80091b16999 on ElDeveloper:new-pandas into 837d18d9f714169437d329c37a52331fd98c7d42 on biocore:master.

All test are passing - what do we do with this? We merge it or should be upgrade the test environment to use the last pandas and play with it in there?

Hmmm, after seeing the error that @antgonza sent around, I would say
it's only worth adding this restriction if this solves the problem we
saw in the study that was not being updated.
On (May-04-16|15:01), Jose Navas wrote:

All test are passing - what do we do with this? We merge it or should be upgrade the test environment to use the last pandas and play with it in there?

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/pull/1824#issuecomment-217017117


Fixed release trigger

Short Description:
On TransferPokemon task, the bot randomizes min_free_slot by up to 20 (to simulate human-like behaviour?), so a value of 5 in config could actually be anything from 5 to -15. Bag limit never gets below zero, so bag has very large chance of filling up. Changed so will trigger if space <= 1 if random gives anything equal to or below 0.
Fixes/Resolves/Closes (please use correct syntax):

#5480

Very minor change, merging.


Mac: debug symbols aren't cleaned

make clean does not clear debug symbols (*.dSYM) on MacOS.

Fixed by #27


Table pagination

Hi,
How can i add the option to load the first and the last page, or set a list of all pages in table pagination.
Thanks.

Please submit support requests and questions to StackOverflow using the tag material-ui. StackOverflow is better suited for this kind of support. The issue tracker is for bug reports and feature discussions. See also our CONTRIBUTING guidelines.


How does the CausalStarGANv2VC model realize streamining inference?

Hi, thank you very much for sharing this great repo.
I am wondering how the causal starganv2 model achieves low-latency real-time voice conversion.
The most confusing part for me is the InstanceNorm2d modules in the causal model. For example, here https://github.com/fss1t/CausalStarGANv2-VC/blob/e1d9bdb86f2d091a43f78f8886e47a58e12eb347/CausalStarGANv2VC/CausalStarGANv2VC/models/generator.py#L114 In my understanding, the layer takes an input feature with shape [N, C, H, W] as input, and computes statistics (i.e., the mean and std) along the axes (H, W). Hence, the model can see all the future frames in the input, thus violating the causal rule.
Please clear me up if my understanding is wrong. Thanks.

Thank you very much for visiting my repository.
When doing streaming inference, we need to fix the normalization parameters using pre-recorded source speaker audio.
generator.load_state_dict(checkpoint_path)
generator.train()
_ = generator(source_melspec,target_style_code) # fix norm params by tracking running stats
generator.eval()
# start streaming

In this case, it is not strictly any-to-many, but streaming conversion can be done with only one source speaker's utterance.

Thanks for your reply.


check --get-login when login

Check --get-login is set in podman since it is not shared option from c/common and does not valid by the package.
Signed-off-by: Qi Wang<EMAIL_ADDRESS>

LGTM, Not sure what this is for?

check whether --get-login is set
**--get-login**

Return the logged-in user for the registry.  Return error if no login is found.

/approve
@TomSweeneyRedHat @baude @mheon @jwhonce @giuseppe PTAL

LGTM assuming happy tests

/lgtm