Bug: Codegen Incorrectly Uses PydanticUndefined Instead of Undefined in Pydantic Version < 2

Bug description
I'm using pydantic = "1.10.8" and needed to create a migration with the addition of constraints.
I've used the Addition of Constraints Recipe from the docs and created the migration:
Latest Schema:
class SendRequest(BaseModel):
    subject_text: str = Field(min_length=1)

Migration:
from pydantic.fields import Undefined
from cadwyn.structure import VersionChange, schema
from api.v1.schemas import SendRequest

class SubjectBodyTextAtLeast1Character(VersionChange):
    description = "Added constraint on min_length of subject_text"
    instructions_to_migrate_to_previous_version = [
        schema(SendRequest).field("subject_text").had(min_length=Undefined),
    ]

But, after I ran generate_schemas.py, codegen created the following schema:
class SendRequest(BaseModel):
    subject_text: str = Field(min_length=PydanticUndefined)

Despite using the first version of Pydantic, it incorrectly inserts a PydanticUndefined object, which is from the second version.
The generated schema file also lacks an import line for PydanticUndefined, so it fails with NameError:
NameError: name 'PydanticUndefined' is not defined
Expected behavior
I expect the generated schema to contain either Field(min_length=Undefined) or just Field() and no NameError exception.
P.S.
As a temporary workaround, I reworked my migration a bit and it helped:
class SubjectBodyTextAtLeast1Character(VersionChange):
    description = "Added constraint on min_length of subject_text"
    instructions_to_migrate_to_previous_version = [
        schema(SendRequest).field("subject_text").had(min_length=0),
    ]

Big thanks! I'll add it as a test.
On a side note:

You used regular code blocks without a language specification: https://www.markdownguide.org/extended-syntax/#syntax-highlighting
The naming of your migration could get a bit confusing. We have naming recommendations here


.NET Standard support

Hi,
Is there a practical limitation as why the library cannot support .NET Standard? Most of the services I have are all in .NET Standard and can thus be called from any other .NET Standard project. Using this package would require me to either change all 30+ projects to .NET Core, which is not desired, or 'workaround' the issue by having a web project pull the data and then use the .NET Standard project to store the data in the database. I would prefer to call the service from a business logic, which is a .NET Standard project.
Any plans for .NET Standard?
Thanks!

its a practical limitation.
.net standard 2.x is missing some of the data contact processors that are in .net 4.8 which prevents us from running on it.
We have been discussing this with the .net team.. but no ETA for support at this point, even so, any support would be in a future version of .net.

@MattB-msft any updates on this?
I have a legacy project that I'd like to port step-by-step, so all my common classes should ideally target Standard 2.0.
This way I'll be able to use the same code in .NET Framework 4.6.2 (legacy project) and .NET 6.0

@MattB-msft any updates on this? I have a legacy project that I'd like to port step-by-step, so all my common classes should ideally target Standard 2.0. This way I'll be able to use the same code in .NET Framework 4.6.2 (legacy project) and .NET 6.0

Depends on your purpose, but at the time I ended up writing my own Dynamics integration with just HttpClient using the /api/data/v9.1/{entity} endpoints. In the end it's just a OData API. Gives me some more flexibility then previous didn't think of I needed.

@Misiu We provide both .net framework and .net core targets for this purpose.

@MattB-msft I've noticed that :) THank you for the reply.


Task timed out after 18.01 seconds in us-west-2

I have a lambda function that fetches some things on the network and puts that in a S3 bucket... and yes, it can run for more than 18s. This wasn't a problem in ap-southeast-1, but since deploying in us-west-2, I've struck this issue.
time ./remote-test.sh
HTTP/2 502
content-type: application/json
content-length: 36
date: Mon, 30 Oct 2017 08:55:46 GMT
x-amzn-requestid: 137e58fd-bd50-11e7-8987-517e92f930cf
x-cache: Error from cloudfront
via: 1.1 2ed072dcf3e5d253ca3caad233e07058.cloudfront.net (CloudFront)
x-amz-cf-id: dvdFtAbC1rqCt2lOb9GeUJWvWCIEyD1dAssVRQ8LiWXN9HFs7X9Eww==

{"message": "Internal server error"}
real    0m18.602s
user    0m0.025s
sys     0m0.014s

From up logs:
  6:55:25am INFO REPORT RequestId: 137f9168-bd50-11e7-973f-2f07cefa3cfe        Duration: 18018.19 ms   Billed Duration: 18000
ms      Memory Size: 512 MB     Max Memory Used: 45 MB
  6:55:25am INFO 2017-10-30T08:55:46.064Z 137f9168-bd50-11e7-973f-2f07cefa3cfe Task timed out after 18.02 seconds

Searching for "timeout" upon https://apex.github.io/up/#configuration ... I'm not sure if I can get around this. Can I return from the request and have a goroutine running for a minute or two, until the copy is done? Or am I basically stuck with moving to AWS batch at this point?

Lambda itself has 5m limits, so you could use Lambda internally for more long-running stuff, but unfortunately for now API Gateway is limited to 30s, and we need a bit of "breathing room" within Up to timeout properly.
I'm hoping they'll increase the limit at Reinvent, but for now there's no way around the timeout they enforce :'(. Closing for now since it's not actionable, but if it's work which can be delayed I'd fire off an event to SNS and use Lambda to process those events

Made a video how I am struggling to find a nice paradigm for dealing with long running operations at work on this topic https://www.youtube.com/watch?v=vw4TJ7QnfXE


Add the extrinsic mean estimator

It's just the mean in the ambient space and point projection. Not a particularly good estimator but it is fast and simple.

This would be good to have. Although currently we don't denote manifolds that are implemented as an embedded manifold (i.e. with coordinates of the embedding) in any special way. Perhaps we need a function like ambient_manifold that errors by default and otherwise returns the ambient manifold. Then the extrinsic mean is something like extrinsic_mean(M, xs) = project_point(M, mean(ambient_manifold(M), xs)).
It might be worth having a version that returns the point in the ambient space and the projected point, as at least in the spherical case (von Mises-Fisher), the distance of the unprojected mean from the projected mean informs the variance of the distribution. Perhaps this will generalize for other Restricted distributions. But I'd hold off on that more general version until we know it will be generally useful.

It's worth noting that in the von Mises-Fisher case, this is a maximum likelihood estimator of the modal point μ.

I think a nice feature to have is a decorator pattern (like the default metric) that indicates that a manifold is an embedded one, maybe with functions like

ìs_embedded(M)`,
is_isometrically_embedded(M) if the embedding is isometric
embed(M,x) returns the representation of x in the embedding (if that's different from the internal data structure, so in a lot of cases this might just be the identity
embedded_manifold(M) returns the manifold M is embedded into

And we should then maybe have a fallback if the manifold is not embedded or projection is not possibel (for example for SymmetricPositiveDefinite, the set of matrices is open in the embedding, so there is no projection) – to provide a better error message then “not implemented”.

Adding a few functions related to embedding is a good idea. I can add is_embedded and is_isometrically_embedded and embedded_manifold along with the extrinsic mean (although we don't currently have Lorentzian manifolds for the hyperbolic space but it should be easy to add). embed would be useful as well but using it consistently across the whole library would take some work.

Yes, the embed will be a little bit of work, but starting with the others fist is a good idea, I think.


How to ensure the atomic operation of Redis

How does Redis get set guarantee atomicity in the cluster environment of PM2 with multiple processes

I don't know if this is a joke, but this is off-topic.

this is not a joke.
https://github.com/nestjs/throttler/blob/master/src/throttler.guard.ts
in method handleRequest,  between getRecord and addRecord.
In the distributed case, don't you think there will be another get / add  Record between these two calls ?

If you'd made your initial description like this, then I would not close it.
To answer you question, no I am 99% sure there will be no problem with this. There are no other async operations being done that need to be awaited so this process is being handled very rapidly. The current behavior works for many people, although it hasn't been tested on a cluster environment by the people who've worked on the project.
If you experience a problem with it, feel free to submit another issue.


Add configuration to 'firstDayOfWeek'.

It sets the firstDayOfWeek to all calendars instead of just the one that has the configuration. It should just set the firstDayOfWeek to one calendar, but as DateTime is an Injectable I couldn't figure out how to do it.
For my case this solution is valid because all the calendar in my app must follow the same style.
Cheers

Sorry, can you make PR again for me? I will accept it.

merged after resolving conflicts


ISPN-11902 WriteBehindFaultToleranceTest.testBlockingOnStoreAvailabilityChange random failures

https://issues.redhat.com/browse/ISPN-11902

Invoke the 3rd putAll (2nd putAll in fork thread) only after PersistenceManagerImpl
is available
Clean up duplicate logging and add more batch ids
Make test failures clearer

Thanks @danberindei


Custom CSS style for preview

Hi,
many thanks for your nice QL plugin that supports CommonMark. It looks very promising. Btw, is there any way to customize the preview using CSS style just like MMD QuickLook Plugin does?
Cheers,
Huy

Note to self: document ~/.cmqlstyle.css in the README


Generalized ivf element

I've rewritten IVF element in such way that is utilises caps to determine type of coded carried by stream. During rewriting process I've applied changes requested to the PR #1.

@AndrzejPodo

fix CI
apply fixes from #1 first

@AndrzejPodo

fix CI
apply fixes from #1 first


Question regarding the Discord Format String

Hello! is there any guide or source i can use to understand how to format the discord message? i am getting the message correctly to the discord but i can only add text in a very basic format like "Hello world %s". Is there any way i can create more interesting formats like extra lines, paragraphs or emojis?

It uses printf, please refer to printf documentation or any related article such as https://linuxize.com/post/bash-printf-command/


[stdlib][task] - Task redesign - service model

Purpose

Re-design the task library as a service - listener model.

Merge Appointment and Timer to one Listener object.
Use separate wrapper object Scheduler to use timers and appointments as a library.
Add option to restrict the number of runs for a particular task. (Using noOfRecurrences field)
Use a separate record type AppointmentData to provide appointment details, alternatively for cronExpression.

streams:Scheduler.bal looks good.

@praneesha please verity the contents which falls under examples/*

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9084b8a). Click here to learn what that means.
The diff coverage is 76.43%.

@@            Coverage Diff            @@
##             master   #13632   +/-   ##
=========================================
  Coverage          ?   64.77%
  Complexity        ?      426
=========================================
  Files             ?     2179
  Lines             ?    96122
  Branches          ?    12828
=========================================
  Hits              ?    62264
  Misses            ?    28836
  Partials          ?     5022

Impacted Files
Coverage Δ
Complexity Δ

...inalang/langserver/index/tools/IndexGenerator.java
0% <ø> (ø)
0 <0> (?)

...ballerinalang/stdlib/task/utils/TaskConstants.java
0% <0%> (ø)
0 <0> (?)

...va/org/ballerinalang/langserver/index/DTOUtil.java
2.77% <0%> (ø)
0 <0> (?)

...tdlib/task/compiler/TaskServiceCompilerPlugin.java
0% <0%> (ø)
0 <0> (?)

...va/org/ballerinalang/stdlib/task/service/Init.java
100% <100%> (ø)
0 <0> (?)

...rg/ballerinalang/stdlib/task/service/Register.java
100% <100%> (ø)
0 <0> (?)

...lang/stdlib/task/impl/TaskServerConnectorImpl.java
100% <100%> (ø)
0 <0> (?)

...a/org/ballerinalang/stdlib/task/utils/TaskJob.java
100% <100%> (ø)
0 <0> (?)

...ang/stdlib/task/objects/ServiceWithParameters.java
100% <100%> (ø)
0 <0> (?)

...va/org/ballerinalang/stdlib/task/service/Stop.java
100% <100%> (ø)
0 <0> (?)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9084b8a...f96324c. Read the comment docs.


SyntaxError when saving as png

I just tried saving a simple scatter plot as a png. I receive the following error:
/home/user/miniconda3/envs/track/lib/vega-cli/node_modules/vega-dataflow/build/vega-dataflow.js:43
  async function asyncCallback(df, callback) {
        ^^^^^^^^

SyntaxError: Unexpected token function
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/user/miniconda3/envs/track/lib/vega-cli/node_modules/vega/build/vega-node.js:6:20)

I installed Altair Saver using conda install altair_saver as instructed in the docs. I'm guessing it's somehow related to the version of Nodejs and the code using syntax that is not supported by that version.
If it's any help, when I run node --version I get v6.13.1.

Async funcitons are not supported in older nodeJS versions. You'll need to update nodeJS to use this functionality.

Deleting the conda package, installing the packages through pip and manually installing the node dependencies seems to solve the issue.


Support generic transaction

As per https://github.com/vapor/fluent/pull/462/commits/85a1f81e065601e81b6bb770be478f2e0ff143f4
All tests passed on local

This has been added on the development branches. Unfortunately couldn't merge these PRs because of conflicts created by an internal refactor. Thank you for the contribution!


Add links to @scope

From https://github.com/Fyrd/caniuse/issues/6056

https://github.com/WebKit/standards-positions/issues/13
https://fullystacked.net/posts/scope-in-css/

Thanks!


SSR: Absolute URI for HttpLink handling?

Is this the only way to handle the absolute URL requirement for SSR?:
const httpLink = new HttpLink({
    uri:
      url ?? isServer()
        ? `${process.env['HOST']}:${process.env['PORT']}/api/graphql`
        : '/api/graphql',
  });

It seems to me like the only other way is with ENV variables based on environment, for example in development HOST grabs localhost:4200 but in production, the hostname (either IP or DNS name) should be known by the CI pipeline to embed in the env variables, such a pain for such a simple need...

Sorry, I missed this issue!
When your Next.js server is also your GraphQL server, you can get around a network request completely by using a Schema link.
You can see an example of that here: https://github.com/apollographql/apollo-client-nextjs/pull/36/files

I'll have to test again, last time I tried Schema Link, the issue was that my schema was generated async and made it hard to pass it into the client:

The issue being that the makeClient of the ApolloNextAppProvider didn't accept async client factory:

Hmm, that's an interesting problem. Can you maybe work with a top-level await in some way here?
If we were to allow makeClient to be async, that would only work in SSR, but not in the browser, and it might become very confusing if that method needed two implementations.

Top-level await usually gets troublesome in one way or another, I tend to avoid it, will give that a try as well.

I'm dumb, ok so I found a workaround, basically what I can do is turn ApolloWrapper into an async component, call my factory with await like const makeClient = await clientFactory(graphQLURI); and in the factory clientFactory get the async schema before I pass it to the returned makeClient:

However I still get some issues getting it to run:

I created an issue in https://github.com/apollographql/federation/issues/2942 just to try and get some feedback.
I think what happens is that even with the if to ensure the part that awaits the schema, it still tries to import the @neo4j/driver which ends up importing @apollo/federation-internals, which expects to be done in the server and does something like this:

So I'm left with an issue here where I can't properly build the schema.

I think the problem might be your isServer function here. If you write if (typeof window !== "undefined"), the bundler can remove that when bundling for the client, but if you wrap it in a function statical analysis by the bundler won't work anymore.
That said, I don't believe static client components (and the wrapper has to be a Client component!) are a stable React feature at this point.

As for async client components, you might want to use use instead, but it will require a split into two components and a suspense boundary to prevent your clientFactory from being called all over again:
function ParentWrapper({children}){
  const [promise] = useState(clientFactory)
  return <Suspense><ChildWrapper promise={promise}>{children}</ChildWrapper></Suspense>
}
function ChildWrapper({promise, children}){
  const makeClient = use(promise)
  return <ApolloNextAppProvider makeClient={makeClient}>{children}</ApolloNextAppProvider>
}

We can't do that on a library level since it would wrap all our user's applications into an additional suspense boundary and that changes general UX, so it the developer needs to be very aware of that.

I'll try removing the isServer function, then the use one and see if that helps my db library.

Hmm, would it matter if the factory is called again if I move the httpLink and NextSSRApolloClient into global variables that I check for with ??= nullish assignment operator before returning?

Then all your SSR-rendered requests share one instance of ApolloClient, potentially leaking sensitive data between requests, which I would really not recommend.
(We will start adding warnings for that soon)

Ah right this is the client instance, would be a different matter with a server instance right?

That might be a misconception: Even though they are called "Client" Components, they will still run on the server for SSR on the first request of a user session.

Yes, I meant that it's supposed to be a client-level instance because of ApolloClient, I do get that the first run goes in the server, then gets hydrated in the client to continue the interaction.
And now that I think about it, wouldn't that mean the SchemaLink in this case only helps with the first render and then it has to use the HttpLink for subsequent ones?

Yes, the SchemaLink would only be used in SSR.
All we are talking about in this issue pretty much only has relevance in that "first render on the server" - that's why I'm saying you shouldn't use a global variable for it.

As for async client components, you might want to use use instead, but it will require a split into two components and a suspense boundary to prevent your clientFactory from being called all over again:
function ParentWrapper({children}){
  const [promise] = useState(clientFactory)
  return <Suspense><ChildWrapper promise={promise}>{children}</ChildWrapper></Suspense>
}
function ChildWrapper({promise, children}){
  const makeClient = use(promise)
  return <ApolloNextAppProvider makeClient={makeClient}>{children}</ApolloNextAppProvider>
}

We can't do that on a library level since it would wrap all our user's applications into an additional suspense boundary and that changes general UX, so it the developer needs to be very aware of that.

Tried the use and useState thing, it worked but suddenly got this kind of issue, I scanned the lock file, it should only exist a single version of graphql in my app, maybe it is creating multiple instances?

Ah yes I remember now, I knew I saw it somewhere, but I already put the serverComponentsExternalPackages config in place, so I can't tell why its happening in my case...
https://github.com/neo4j/graphql/issues/4297

Funny enough it doesn't break my unit tests, so the functionality is still the same, but the SSR part is broken indeed, the HTML of the SSR part (the first request that should be using the SchemaLink) only contains that error template, I've updated my branch in which I'm getting that "String!" error:
https://github.com/luchillo17/graph-meister/tree/feature/schema-link-wrapper

And I realized we went out of the scope of the original issue, do you want me to close this one and create a new one?

@luchillo17  Yes please open a new issue - it's hard to keep track otherwise :)

TLDR to avoid having to define an absolute URL ideally we use SchemaLink, the issue about the schema being created async is a separate issue reported separately, if we can't use SchemaLink for this or any other reason, we can build the absolute URL like in the description of this issue, grabbing the host and port from environment variables, that way we can have a different host and port in local env and in a prod env, which then we can configure in our CI/CD on deployment.


Skip level selection screen the first time someone plays

Discuss with Jeff, Rajesh, and Divya at Sprint Planning-- will this mess up our funnel at all? E.g. We would probably want to move level_selected after Learner Acquired in the visualization?
User Story
As a Product Owner,
I want to skip the level selection screen on the first time someone plays the app only,
So that we get them into playing the game faster.
Acceptance Criteria
Given that I have installed FTM JS for the first time for a given language and have no level completion data saved to my user profile,
When I open FTM JS for the first time and press "play" on the splash screen,
Then I should see the first level and tutorial.
Given that I am launching FTM JS for a second time or more for any given language and DO have level completion data saved for my user profile,
When I open FTM JS for the second or more time and press "play" on the splash screen,
Then I should see the level selection screen.

Sending to Backlog as there is more to think about concerning the impact on the funnel visualization-- do we rename the level selected event to differentiate that this event would come later or should we just remove level selected entirely (preferred at the moment of writing) because there is technically more than one way to fire that event at times that wouldn't necessarily correlate to where they are in the funnel (e.g. a user could pause level 1 and click on level selection and select a level which could lead to misrepresentation the event happened either before or after they completed a level).


Issue 14621, 14624, 14625 - Fix bugs in array operator overloading semantics

This is same with #4686, excepting the base branch is 'stable'.

Issue 14621 - [REG2.066] ICE: Assertion failure: 'global.gaggedErrors || global.errors' on line 752 in file 'statement.c'
Issue 14624 - The array operator overloading fallback is not correct
Issue 14625 - opIndex() doesn't work on foreach container iteration
Shorten the length of gagged semantic path, and improve ArrayExp as the entry point of array operator overloading.

I fixed ddmd build failure in Win32/64.

All green.

LGTM, I'll have to merge stable into master before pulling, or I'll have to deal with too many conflicts at once.

https://github.com/D-Programming-Language/dmd/pull/4979

Auto-merge toggled on

Thanks.


New Numpy Version Issues

To report a non-security related issue, please provide:

Issues with version 1.6.0
Environment Information (i.e. Operating System, compiler info, java version, python version, etc.)

Windows ()
All Python versions (3.6, 3.7, 3.8, 3.9, 3.10)

The issue: When updating to the numpy version (1.23.0), there are issues with the num2date module, as shown below from our Py-ART CI logs. It seems to tied to the Cython num2date function.

Potential solution in PR #281

PR #281 merged. A 1.6.1 release is coming with this fix.


Locked Issue

For testing rnystrom/GitHawk#151

Oh I can't lock issues, well this was a sudden disaster 😂


Broken link in NCSO alert email

In my Islington CCG alert the link to the "view our dashboard for NHS Islington CCG" is broken. My browser gives  http://%22%22/

Was this fixed @brianmackenna ?

It appears not however as no users have contacted us it probably isn't causing too much of an issue.

I've actually fixed this as part of #1731 which hasn't been merged yet but will be soon.


Add pre commit

tldr
Minimal QA Uplift and Automation
With reference to the previous PR, these changes introduce only one additional, optional (highly recommended) developer dependency: pre-commit, and offers guidance on its installation.
In doing so, we ensure that all standard linting and custom business logic QA is applied before PR review, including the existing yapf style choice, boilerplate, documentation, links and name length checks.
Rationale
Pre-commit

Git hook scripts are useful for identifying simple issues before submission to code review. We run our hooks on every commit to automatically point out issues in code such as missing semicolons, trailing whitespace, and debug statements. By pointing these issues out before code review, this allows a code reviewer to focus on the architecture of a change while not wasting time with trivial style nitpicks.

I believe the addition of this one tool will significantly improve DX and reduce cognitive load for both the developer and those responsible for code review.  Reducing manual pre- and post-commit burden should also reduce the size of CONTRIBUTING.md as much of the QA will be implemented automatically, including Terraform and Python formatting, vulnerability checks, tdfoc creation etc, however I have elected to minimise the number of changes to CONTRIBUTING at this time, until code owners validate the proposed new developer flow.
Changes
No breaking changes are included in this PR.  The use of the pre-commit hook is optional.
The only changes to the main codebase are aesthetic:

fixing line-endings
ensuring a blank newline at end of file
convert tabs to spaces
remove trailing whitespace

The check-documentation hook indicated that the compute-mig readme had missed changes, and so that file has been updated also.
A Makefile is included for convenience, but the use of which is optional.
Note: this will conflict with #680 so will rebase one or the other if accepted.

I think this is an outstanding repo, and am very grateful for its availability. In particular the techniques for factory resource generation will be very useful for our organisation.  Applying some standardised QA is my small way of trying to say thanks 🙏

+1 @ludoo's comments. I like the overall idea but we're introducing a ton of dependencies (pre-commit, random third-party plugins, etc). Some of the checks also break the standard conventions for certain code (e.g. the remove-tabs task is removing tabs from Go code).
That being said, I like the idea of a Makefile to simplify some tasks. @27Bslash6 @ludoo  what do you think of a simple Makefile to run the existing tools (check, lint, tests etc) without introducing extra checks/tools?

Thanks for taking the time to peruse, folks!
A few thoughts:

Pre-commit is optional, not mandatory. The addition of the YAML file doesn't do anything without developers first initialising the hook via something like brew install pre-commit && pre-commit init, at which point it kicks in automatically before each commit.  No additional friction unless opted-in and though I strongly believe that, once adopted, you'll appreciate the benefits and find it hard to go back, you're free to continue doing it all manually.
The argument against adding third party dependencies is certainly valid. Though mitigated by usual open source conversation: exact version pinning and the maturity and health of the community-supported projects, it's admittedly the equivalent of adding new python modules, and a potential vector for bad actors. That said, all three non-Google projects are MIT licensed and pretty simple code, so bringing them in-house is eminently doable.  Happy to do so if this is the preference.
I expect the Venn diagram of users who have Terraform and a recent version Python installed is pretty nearly a single circle, and if they're updating Terraform code don't they also need to update tfdocs via the Python script?
@juliocc good point re: go formatting. If you're interested in proceeding with this solution I'm very happy to push an update with exclude_types for the tab manipulation hook, and we might consider adding a gofmt hook in future.

I'm going to close this, as it adds friction with no clear benefit. Feel free to reopen individual issues for each pre-commit feature and we can discuss there.


Replace HashMap<Long, Long> etc with primitive maps

Summary
Data structures like HashMap<Long, Long> are poor in memory utilization.
The key and value are the effective data you are storing (2 * 8 bytes). The boxing from long to Long will make each a 24 byte object (including obj heads and Klass pointers). Then the Map.Entry<Long,Long> object will add another round of object heads and Klass pointers. Then the Entry has a 8-byte next field and a 4-byte hash. Then in the HashMap there's the 8-byte ref to the Entry object. I'm not counting the padding the JVM mem allocation so the actual utilization is even lower.
For big maps we should try our best to utilize primitive maps like fastutils.
Urgency
MEDIUM - LOW

Upon investigation, we found that there is no usage of HashMap<Long, Long> in Alluxio. There are only two instances where HashMap<Long, WorkerNetAddress> is used, namely in mBlockLocationCache of RoundRobinPolicy, and mWorkerIdMap of DefaultBlockMaster. Typically, these two HashMaps will only contain a few hundred objects, so they are unlikely to grow very large. Additionally, DefaultStorageTier contains a HashMap<Integer, StorageDir> mDir, which also consumes minimal memory.
Therefore, in my opinion, there is no room for optimization here :D


Registration info

It seems like registration ought to be more prominent. When you load up the home page, it's buried under logistics rather than appearing as a top level item on the left. Also, if / when you find it, it's not a live weblink to EventBrite -- user has to copy / paste the link in the browser.

both fixed


Network document

Add document to explain the principles of Harvester networking, including management network and VLAN network.

@yaocw2020 can u resolve the conflict and do not include any code changes of the doc PR.

@yaocw2020 can u resolve the conflict and do not include any code changes of the doc PR.

Done

Can we clarify the usage of VLAN 1 given that it's the default PVID in most switches?

Can we clarify the usage of VLAN 1 given that it's the default PVID in most switches?

Done


Multiple errors thrown. No such file or directory

Description
Multiple errors are being thrown. Running on MacBook Pro on 10.15.7 Catalina
Figured an image would be easiest for you to see.
https://imgur.com/wyTuI1Z

You've not followed the instructions correctly and have changed directory cd before cloning. Consequently, you should be in the directory ~Desktop/nv/nvidia-snatcher before running npm install and npm run start.


UN 744 Removed redundant link wrapping the image

Ticket URL: UN 744
About these changes
Removed the additional redundant link wrapping the image in the card as flagged by WAVE
How to check these changes
Please review this page
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer.
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
[x] Ensured that PR includes only commits relevant to the ticket.
[ ] Waited for all CI jobs to pass before requesting a review.
[ ] Added/updated tests and documentation where relevant.

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

As mentioned on slack - I'm going to close this PR following a chat with Lauren this morning as we've agreed to keep the links as-is for now. If there's an issue with the label not being read that should be fixed separately but we need to keep the links in the tab order and on the images for now.


invalid ipv6 host

 let uri = "mysql://username:p@ssw0rd@[::1]:5432/database";
 let opts = MySqlConnectOptions::from_str(uri).unwrap();
 println!("{:?}", opts.host); // the opts.host is "[::1]"

sqlx try to use this host to connect at https://github.com/launchbadge/sqlx/blob/dfd9cf59f1920e134c7c8bf912f515012c721faf/sqlx-core/src/mysql/connection/stream.rs#L46
but [::1] is a invalid address for tokio::net::TcpStream::connect, which expect a address like ::1 without a []
so, we will get an error failed to lookup address information: Name or service not known

My question is: is this a uri crate bug, a Tokio bug, or a SQLx bug?

I'm pretty sure this is a SQLx bug. The [] are part of a URL containing an IPv6 address, they're not part of the address itself. A type like IpAddr that this is likely parsed into internally won't have parsing code that expects [].
The url crate explicitly documents that the [] are part of the host string, though it's unfortunate that you can so easily shoot yourself in the foot because of that when using the crate.

So the fix here would be to just trim [] from the host string.


Add F# to list of .NET languages

Duplicate of #736.

@adrientetar  #736 is a closed PR, you probably meant #740

Note that #736 is closed so it might be valid to open a new PR (but it should have a better description).
Also note that #736 was closed for discussion in #740 so if that discussion didn't agree on something this PR will probably also be closed.

Just want to explain why I think F# should appear on the list:

You currently can't build UWP apps with F#. (because you can't access the UI related assemblies.) This will change when the Controls are shipped as a NuGet Package. (And as far as I've seen this is planned)

F# is a .Net language just like VB and C#. If WinUI is just a .Net library why wouldn't it work with F# ? I'm not assuming that the tooling is great or something, but you can use the library. (Just as it is with WPF and F#).

You should be able to reference separate F# libraries, but as noted in #736 we want to make sure that any "officially supported" languages on the roadmap are truly fully supported.
For F# that would require some new features (e.g. for the Xaml markup compiler and Visual Studio tooling) that .NET doesn't provide for free and which aren't currently planned for the first release of WinUI 3.0, so closing this PR for now.
However we definitely want to keep discussing how we could improve WinUI's F# support over time in #740. Better F# support is something we can revisit for a future release and/or once WinUI 3 is open source if people are interested in contributing to the effort.


[BEAM-9678] Create Go SDK introduction kata

This pull request closes BEAM-9678 by adding an Introduction Beam Kata for learning the Go SDK.  It patterns after the existing Java and Python Beam Katas.
I would like to request @lostluck to review this PR.
Currently, this PR submits:
Introduction

Hello Beam
Hello Beam Test

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

I can help to review this as well.

@henryken  That would be valuable! I'm familiar with Go, and Beam, but not katas. Please chime in!

@lostluck @henryken I've made the recommended changes. Thank you for reviewing.

Thank you @henryken.  I've changed the PR based on your helpful feedback.

If everything is okay, I can help to upload this course to Stepik.

@henryken I think everything is ok and if you could help uploading this to Stepik that would be really helpful.  I'll email you about hopefully meeting with you to plan out the rest of the katas.

Awesome! @lostluck, please help to merge this PR. Thanks.

Thank you very much! I look forward to the next lessons.
This can wait for a next PR, but having a small README on how to keep the go side of the katas up to date (eg commands to run, like go mod tidy or pointers to instructions for how to upload them to stepik) would be valuable for ongoing maintenance and improvement as the SDK has more features added (like Trigger support).
I know that when the SDK becomes module compatible and no-longer experimental, we'll definitely need to update these files :) .

There are 2 go.sum files without apache license header, which breaks RAT check. Could you please take a look at it?

Thank you for letting me know. 😨 @lostluck Should we put the license information in the go.sum files?  And yes that README on how to keep the go katas up to date will be helpful.  I created BEAM-9782 subtask so its not forgotten.

There is also no license not in any of the *-remote-info.yaml files either but that didn't break the RAT check?  Should we add them there too?

I think i tried previously and they wouldn't stick on regeneration so I've
already submitted a change to ignore the go.sum files in the license
check.  Note that I did ask for licenses to be put on the files earlier, so
i assume you just ran into the same problem i did.
They're important information in that it's checksums for the versions
indicated in the go.mod file, but they're ultimately automatically derived
from files with licenses, so this should be fine.
On Sat, Apr 18, 2020, 6:30 PM Damon Douglas<EMAIL_ADDRESS>wrote:

Thank you for letting me know. 😨 @lostluck https://github.com/lostluck
Should we put the license information in the go.sum files? And yes that
README on how to keep the go katas up to date will be helpful. I created
BEAM-9782 https://issues.apache.org/jira/browse/BEAM-9782 subtask so
its not forgotten.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/11340#issuecomment-616002270, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKDOFORKN56JIQNUUPYIHLRNJH4DANCNFSM4MDS5PKQ
.

I'd need to check but I suspect they're probably getting ignored already?
Yaml is another finicky format.
On Sat, Apr 18, 2020, 6:34 PM Damon Douglas<EMAIL_ADDRESS>wrote:

There is also no license not in any of the *-remote-info.yaml files
either but that didn't break the RAT check? Should we add them there too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/11340#issuecomment-616002810, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKDOFNB6WFEY3J6RLNWRLTRNJIJFANCNFSM4MDS5PKQ
.

Yes. Already being ignored.
https://github.com/apache/beam/blob/7869455ff38ce4791c5531022ffb75e7f007e06e/build.gradle#L105
I suspect it's more trouble than it's worth to force users who are
refreshing auto generated files to manually reinstate the license which
might interfere with the automatic users of those files.
Community over code.
On Sat, Apr 18, 2020, 6:35 PM Robert Burke<EMAIL_ADDRESS>wrote:

I'd need to check but I suspect they're probably getting ignored already?
Yaml is another finicky format.
On Sat, Apr 18, 2020, 6:34 PM Damon Douglas<EMAIL_ADDRESS>wrote:

There is also no license not in any of the *-remote-info.yaml files
either but that didn't break the RAT check? Should we add them there too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/11340#issuecomment-616002810, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKDOFNB6WFEY3J6RLNWRLTRNJIJFANCNFSM4MDS5PKQ
.

Yeah the *-remote-info.yaml files are auto generated and they are overwritten after the course has been uploaded.

I'd suggest we do the same for the go.sum files.

As noted in a previous reply, i already submitted a change to ignore go.sum
files. (It's ok, there were many replies).
https://github.com/apache/beam/blob/7869455ff38ce4791c5531022ffb75e7f007e06e/build.gradle#L77
On Sun, Apr 19, 2020, 12:15 AM Henry Suryawirawan<EMAIL_ADDRESS>wrote:

I'd suggest we do the same for the go.sum files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/11340#issuecomment-616063862, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKDOFNHMT7NHGQDZEWH6G3RNKQJ7ANCNFSM4MDS5PKQ
.


Only show localhost in UI when testing

PR targets 59

LGTM!

@edisinovcic I'm going to add 1 other thing here, just a sec...


[engsys] remove unused dev dependency mocha-junit-reporter

We have moved to use Mocha's builtin XUnit reporter
Resolves #28242

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure-rest/ai-vision-image-analysis


add naturalearth and hydrosheds entries

naturalearth.countries would parallel the prior geopandas naturalearth_lowres dataset
thanks to @JessicaS11 for pointing out the missing geodatasets

Hey, thanks for the PR.
However, I will ask you to remove naturalearth.countries and hydrosheds (for different reasons).
Geodatasets has a strict policy of avoiding data reflecting contested political boundaries, so a dataset representing countries of the world will never be admitted.
Hydrosheds are out of scope due to the size of the data. We're aiming to provide links to data that are useful for learning and illustrative purposes. This dataset has 820MB, which significantly exceeds what I'd consider useful for such purpose.
I am potentially fine with keeping cities and lakes though, there's no harm in having those.

Makes perfect sense. Trimmed the json of those entries.


Update README.md

Adding Elastalert for those that want to alert on content who are running Elastic.

Thanks for your contribution @echin20!


CLOUD-51636 fixed shell execution states

@bbihari

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1994/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1995/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1996/


Set use_utc to true

Fixes arjun/soda-2681-snowflake-local-timezone-ambiguity

Opened this in error, apologies!


Use post images in meta tags when possible

Ideally we'd want to use an image associated with a post in the og:image meta tag, rather than just the generic RAC logo. Research whether it's possible to:

Automatically pull in the first image in the post or, if that's not possible/too difficult
Add a conditional that looks for an image specified in the YAML frontmatter (and some some documentation encouraging users to explicitly add a featured image to their posts)

There aren't that many posts with images in them, so closing this as it's more of an edge case than previously imagined.


Process for adding or removing pages in language docs is unclear

To get the language docs to show up in the user guide at https://docs.microsoft.com/en-us/azure/quantum/user-guide/, there are stubs and a UID mapping defined for each page here: https://github.com/MicrosoftDocs/quantum-docs/tree/main/articles/user-guide/language
However, if pages are added or removed, the stubs don't seem to be updated automatically. It's not clear to me what the process is for updating them and it doesn't seem to be described in this repo. I think it would be better to:

Document clearly how this other repo is supposed to be updated so that people making changes to the Q# docs here will know what to do.
Update the CI to prevent merging PRs that add or remove pages without updating the corresponding stubs/UID map (like #136).

@bettinaheim do you have any thoughts on the process and how to prevent the docs repo from becoming out of sync?

And just to clarify/rephrase, but my understanding of the situation is:

To update the contents of existing pages, only this repo needs to be changed.
To add, remove or rename pages, both this repo and quantum-docs need to be changed simultaneously.

IMO this split is kind of weird. I'd prefer everything to be done all in one repo. Or at least it should be clearly documented and checked in CI for the second case.


driver: add a link against swiftCore

This was a missing dependency which results in undefined references.
Add the missing dependency which will also ensure that the build graph
is correct.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @eeckstein

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 8bf7b4da152522df603e84545a0354d7394896b6

@swift-ci please test macOS platform

Build failed
Swift Test OS X Platform
Git Sha - 8bf7b4da152522df603e84545a0354d7394896b6

@swift-ci please test macOS platform

Build failed
Swift Test OS X Platform
Git Sha - 8bf7b4da152522df603e84545a0354d7394896b6

It's better to link the libraries to the SwiftCompilerModules targets. This avoids adding them to all host tools which link the compiler modules. Also, this must be conditional on the bootstrapping mode.
See https://github.com/eeckstein/swift/commit/d2ab30312a971a1b1224302afab5924c3484fda8

CC: @DougGregor
I think that I am going to close this off for now as I believe that we are investigating a different approach to handling this?


Axes in rplot should be linked

I would have expected that the Axis in the rplot would be linked, so that zooming into one also zooms into all the others.
It might be good to be able to set this with a keyword argument if this is not the behaviour that one would like to have depending on the data.

PR?

I looked into the code and realized that there are already some linkaxes calls and I can't reproduce it anymore that it is not linked. I will reopen it, when I find an example dataset, where the axes are not linked.


Unification of Runtime Libraries

I need to create a runtime container for Flutter applications. My goal is to minimize the final image footprint as much as possible. Although I have already managed to reduce the size significantly, I still want to further optimize it. To achieve this, I plan to unify the following Flutter runtime libraries: elinux-arm64-debug, elinux-arm64-profile, and elinux-arm64-release. I would greatly appreciate any suggestions or input you may have on this matter.

I plan to unify the following Flutter runtime libraries: elinux-arm64-debug, elinux-arm64-profile, and elinux-arm64-release.

Basically, there are all necessary. But if you don't need debug and profile flavors, elinux-arm64-debug and elinux-arm64-profile can be deleted. Naturally, in this case, flutter-elinux commands with debug/profile won't work.

Also, if there are unnecessary display backends that you don't support, their .so files can be deleted.
libflutter_elinux_eglstream.so for EGLStream
libflutter_elinux_gbm.so for GBM
libflutter_elinux_wayland.so for Wayland
libflutter_elinux_x11.so for X11

Closing.


Horrible Energy Impact when opening tensorflow.org with Safari

Not sure it appropriate issue this kind problem here, but got nothing with google.
Every time opening https://www.tensorflow.org, the battery consuming speed is unreasonably high, why?

This question is better suited on Apple Support forums.
See https://discussions.apple.com/welcome
I was not able to repro the energy consumption as reported. Energy impact was 66.2 for me using Google Chrome browser.
Perhaps you can try using other browsers and reach out to the support forums to seek additional help.
Thanks!


env variable not effictive

Expected Behavior
Actual Behavior
[root@master01 task]# tkn taskrun logs steptemplate-run-f42k6 -f -n tekton
[unnamed-0] FOO is ${FOO}
[unnamed-1] FOO is ${FOO}
Steps to Reproduce the Problem
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: steptemplate
spec:
  stepTemplate:
    env:
    - name: "FOO"
      value: "bar"
  steps:
  - image: ubuntu
    command: [echo]
    args: ["FOO is ${FOO}"]
  - image: ubuntu
    command: [echo]
    args: ["FOO is ${FOO}"]
    env:
      - name: "FOO"
        value: "baz"

Additional Info

Kubernetes version:
Output of kubectl version:

[root@master01 task]# kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.5", GitCommit:"6b1d87acf3c8253c123756b9e61dac642678305f", GitTreeState:"clean", BuildDate:"2021-03-18T01:10:43Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.5", GitCommit:"6b1d87acf3c8253c123756b9e61dac642678305f", GitTreeState:"clean", BuildDate:"2021-03-18T01:02:01Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}

- Tekton Pipeline version:
[root@master01 task]# tkn version
Client version: 0.18.0
Pipeline version: v0.24.1
Dashboard version: v0.17.0
**Output of `tkn version` or `kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'`**

<!-- Any other additional information -->

() needs to be used instead of {}
https://tekton.dev/docs/pipelines/resources/#variable-substitution

thanks


Use Key as fallback

Hello, is there a way to make localizer return the key string instead of "..." as a fallback when resources are not found? For example @Localizer["Product"] will return "Product" instead of "..." when no resources are found for the current culture.

Hello,
Yes, you can use the EnableDisplayKeysWhileLoadingAsynchronously() method in the options builder.
For example on a server side application:
services.AddServerSideJsonLocalization(
    builder =>
    {
        builder.EnableDisplayKeysWhileLoadingAsynchronously();
    });

or on a Wasm application:
services.AddWebAssemblyJsonLocalization(
    builder =>
    {
        builder.EnableDisplayKeysWhileLoadingAsynchronously();
    });

Hope this helps!

Yes, it does what I needed, thanks!


Add manual dependencies not found by find-overlay-dependencies.sh.

cmake patch only.

@swift-ci Please test OS X platform


adding more padding and margin helpers

Adding completion to padding and margin helpers: .[size]-[padding/margin]-[direction].
Examples: .no-margin-top, .tiny-padding-bottom, .small-margin-left, .padding-right.

Adding a new margin helper: .auto-margin
.auto-margin {
  margin: auto !important;
}

Fixing a probable error of .tiny-margin:

.tiny-margin {
padding: 0.25rem !important;
margin: 0.25rem !important;
}

Is there a reason for this being closed? I think a padding-left helper would be nice for visually showing indentation. I don't think beercss has a way to visually indent elements at the moment.

I think the dev branch was deleted and restored. So all the PRs was closed automatically. I believe.
Here we can use the same logic of round helper, because we are trying to maintain the consistency in used names. And stay in the 10kb size too.
I would suggest from {size}-margin-{direction} to {size}-margin {direction}-margin.
// Instead this

// Do this


Improve handling of IP->mac lookup failure in template rendering.

test this please

test this please

BUILD on-http #122 : FAILURE

test this please


Multiple css properties output on a single color?

Firstly, thank for your great product.
I 'd like to ask that can we generate multiple css properties on a single color declaration. For example, for a color, can I generate color and background-color css output.

Kirki now supports multiple output elements, all you have to do now is define them in an array, like so:
'output' => array(
					array(
						'element'  => '.element',
						'property' => 'color',
					),
					array(
						'element'  => '.element',
						'property' => 'background-color',
					),

Thank you so much.


Task list api in self hosted version

Hi,
I am trying to call the get task list api for the self managed version.
It is giving the error:
 /Users/work/Documents/practice/workflow-engine/camunda-ts/node_modules/.pnpm/camunda-8-credentials-from-env@1.2.2/node_modules/camunda-8-credentials-from-env/dist/index.js:50         throw new Error(Credentials do not have required scope 'Tasklist'. Credential scopes: '${tasklistCache.CAMUNDA_CREDENTIALS_SCOPES}'`);
^
Error: Credentials do not have required scope 'Tasklist'. Credential scopes: 'undefined'
at getTasklistCredentials (/Users/work/Documents/practice/workflow-engine/camunda-ts/node_modules/.pnpm/camunda-8-credentials-from-env@1.2.2/node_modules/camunda-8-credentials-from-env/dist/index.js:50:15)
at new TasklistApiClient (/Users/work/Documents/practice/workflow-engine/camunda-ts/node_modules/.pnpm/camunda-tasklist-client@0.9.5/node_modules/camunda-tasklist-client/dist/lib/TasklistApiClient.js:56:83)
at Object. (/Users/work/Documents/practice/workflow-engine/camunda-ts/dist/app.js:29:18)
at Module._compile (node:internal/modules/cjs/loader:1375:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1434:10)
at Module.load (node:internal/modules/cjs/loader:1206:32)
at Module._load (node:internal/modules/cjs/loader:1022:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:142:12)
at node:internal/main/run_main_module:28:49
`
But,
For the self managed version, we are not getting those information. Or where can we find these details
https://forum.camunda.io/t/how-to-obtain-zeebe-cluster-details/37197

This is what a set of environment variables for self-hosted looks like:
export ZEEBE_SECURE_CONNECTION=false
export ZEEBE_ADDRESS='localhost:26500'
export ZEEBE_CLIENT_ID='zeebe'
export ZEEBE_CLIENT_SECRET='zecret'
export ZEEBE_AUTHORIZATION_SERVER_URL='http://localhost:18080/auth/realms/camunda-platform/protocol/openid-connect/token'
export ZEEBE_TOKEN_AUDIENCE='zeebe.camunda.io'
export CAMUNDA_CREDENTIALS_SCOPES='Zeebe,Tasklist,Operate'
export CAMUNDA_OAUTH_URL='http://localhost:18080/auth/realms/camunda-platform/protocol/openid-connect/token'


Could someone resize those for me? Could be worth it as a small pull request.

@KhounborineII I can take this on

@garrettcollier All yours!

This change has been made along with some other code updates to remove warnings and issues on my end when running. Let me  know what you think @KhounborineII


stream settings: Warn users before locking them out of a stream.

Organization owners can make streams private even if they're not subscribed to them, but cannot access private streams they're not subscribed to. This means they're able to lock themself out of streams.
This change warns users of this and give them a chance to subscribe.
Fixes #26437.
Things I've tested:

Clicking subscribe updates the button at the top of the stream settings menu and the checkmark on the left menu, and closes the banner.
Close button closes the banner.
Banner shows up under the correct conditions.

Pending UI feedback on CZO

Looks great, merged, thanks @evykassirer!
(I assume we'll make some further tweak to the CSS pending further discussion of what we want as the components)


Can we have an anti-drag option for the left click dropper?

As title says :)

I will look into this. Should be allowed due to the nature of this plugin not being able to be abused for anything but dropping things.
Thanks for using my plugin.

Hey, how is the list organized? I've added a bunch of items since wildcarding doesn't seem to work, but since adding them all, it doesn't filter them, only the first item in the list left click drops.
I've tried comma separation and breaks, and both combined.

Done. Sorry about delay.

Thanks man, really nice to have while training on 2 accounts :)

It was harder than i thought but it is perfect now! Thanks for your advice because I love losing my own plugin now lol


Option to cap low winds to 0.5 m/s

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #1634

[X] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[x] CHANGES.rst has been updated (with summary of main changes)

[X] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Adds an option to the universal_thermal_climate_index function to cap low wind to a minimum of 0.5 m/s

Does this PR introduce a breaking change?

No

Other information:
References for the change:

https://link.springer.com/article/10.1007/s00484-011-0454-1
https://www.mdpi.com/2079-7737/12/6/802

[x]  The relevant author information has been added to AUTHORS.rst and .zenodo.json

I expanded the original UTCI test by trying two wind values (2 and 1 km/h, or 0.556 and 0.278 m/s) with and without the option to cap the minimum wind velocities. Now the test checks:

If the UTCI is similar to the expected value at wind velocity higher than 0.5 m/s (original test)
If the UTCI is NaN when the wind is lower than 0.5 m/s and wind_cap_min is set to False
If the UTCI is similar to the expected value when the wind velocity is lower than 0.5 m/s and wind_cap_min is set to True

Included the article of Bröde 2012 in the description of wind_cap_min. This article is more than enough to explain wind_cap_min so I didn't include Bröde 2023

coverage: 90.171% (+0.002%) from 90.169%
when pulling 3ac6c5dd1bd65569d67d2acd40fcf9fc83c5e7f5 on profesorpaiche:utci-low-wind
into 41379c573276c3509cf43acec2d223a8f3f1c8bb on Ouranosinc:master.

@profesorpaiche Thanks for the contribution!


seloader skip checking PE and p7b signature

Hi Jia,
I'm running into a problem, with upstream SecureCore on qemu, grubx64.efi and grub.cfg.p7b checking are bypassed. For example,  if grub.cfg.p7b is removed or grubx64.efi is signed by a unknown key, seloader can boot grub, which is not an expected behavior.
Sounds in MokVerifyProtocolInstalled(), seloader can't locate gEfiMokVerifyProtocolGuid, see:
Status = EfiProtocolLocate(&gEfiMokVerifyProtocolGuid,
(VOID **)&MokVerifyProtocol);
I  guess gEfiMokVerifyProtocolGuid is installed by shim loader, but why this protocol is not located by seloader?
Can you help with this?
Thanks,
Yunguo

@yunguowei It is possible that shim installs the MOK protocol but disables MOK secure boot. I will check whether it is there.

@yunguowei I can reproduce this issue. The root cause is due to calling fallback, leading shim uninstalling MOK Verify Protocol. Getting rid of this logic is simple, but this means shim has to be patched and this modification would be rejected by Redhat's reviewers when you are requesting MSFT signing.

@jiazhang0
Yes, I have found out that fallback introduced this issue. But still not locate where(source code) fallback uninstall shim's MOK Verify Protocal. Can you advise more about it?
fallback has some issue with setting BootOrder on NUC boards. SELoaderx64.efi is set to BootOrder and this leads to UEFI SB verify failed.
MSFT signing might not be a priority for now, so I would like to take fallback away. What do you think?

@yunguowei I agree with dropping fallback anyway. Introducing fallback is intended to work around MSFT signing review which needs to touch shim source code. However fallback cannot work with SELoader well. Note that dropping fallback still blocks MSFT signing review, unless you would like to exchange the names between SELoader to grub.
Next I will do the items below this weekend.

Drop fallback boot flow
Update READM
Update shim to the latest

@yunguowei This issue is resolved in the latest meta-secure-core.


env.test fails in a coverage run

PASS: env -i uses old $PATH
FAIL: env -i env
echo -ne '' | "/system/bin/env" -i env
--- expected	2023-03-06 18:22:13.948004125 +0000
+++ actual	2023-03-06 18:22:13.968004126 +0000
@@ -0,0 +1 @@
+__LLVM_PROFILE_RT_INIT_ONCE=__LLVM_PROFILE_RT_INIT_ONCE

Maybe it needs fix similar to what was done in bionic
https://android.googlesource.com/platform/bionic/+/refs/heads/master/tests/unistd_test.cpp#1372

If "env -i env" is producing output, something is broken. (What's broken might be libc or libcc.)
Elliott, do you understand this?

define "understand"...
it's caused by https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/profile/InstrProfilingFile.c#L529
but i don't understand why that code is doing what it's doing. why not just check for EEXIST on the mkdir()?
apparently i asked that question last September on internal bug https://buganizer.corp.google.com/issues/244345732#comment6 but -- although it was confirmed that there isn't an SELinux problem with that (because coverage builds have more relaxed SELinux policies anyway, to allow things that normally wouldn't be allowed to write to disk to write their profiling data) -- there's no real answer there.
personally my stance (until/unless proven otherwise) remains that LLVM's implementation is bad, and should be improved. if it's really only bionic's and toybox's tests that are affected by this (and there's an actual reason why they need this environment variable in the first place!), then that's different. but for now i'm assuming that we'll get to revert the hack in the bionic tests at some point, and so right now i don't think toybox should do anything.


Implement fixed relationships between Overarching Categories/Themes and Concepts

We entered fixed relationships between the Overarching Categories -> Concepts and the Themes -> Concepts (not all are entered for OA->concepts, because of the max amount of characters to enter, still something that needs to be fixed).
Those fixed relationships are meant to automatically tag a resource with the particular OA and/or Theme if it's tagged with a particular concept (Specifically useful with older resources that were added before these OAs and Themes existed).
Can we implement this?
(This will become especially important with publishing the thematic pages. We need enough content to be appearing on those pages).

Quick comment : this is completely agreed and was actually tested as a POC, it now needs to be implemented properly on those taxonomies (Overarching and Themes).

Just to add to this: I saw that the total characters to match the concepts and OAs was fixed a while back, so I just completed filling in the fixed relationships. All the information is there now :)

Any news on this? We're getting more thematic pages soon and we need to have them populated with content ! Just to note that this is something I entered in August last year......

this is deployed.
We already have the first views taking advantage of this in the Library and Thematic pages.


docs.dahliaos.io not working

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior
The link above doesn't work
Expected behavior
No response
Steps to reproduce
No response
Environment (values that do not apply assign with "N/A")
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Fixed


docs: external auth missing service definition

The documentation for the (Authorization Service](https://www.envoyproxy.io/docs/envoy/latest/api-v2/service/auth/v2alpha/external_auth.proto#envoy-api-msg-service-auth-v2alpha-checkrequest) has a few issues:

The Authorization service itself is entirely MIA in the docs, which is strange given that it exists in the .proto definition file (https://github.com/envoyproxy/envoy/blob/master/api/envoy/service/auth/v2alpha/external_auth.proto#L26). Are services not included in the protobuf-to-rst generation? If so, it would be great to add it at some point since it would be incredibly helpful in properly understanding how the different parts of the puzzle work.

The generated .rst file contains links that are "off by one" line in terms of referring to the original .proto file. For example, this .rst file line: https://github.com/envoyproxy/envoyproxy.github.io/blame/master/docs/envoy/latest/_sources/api-v2/service/auth/v2alpha/external_auth.proto.rst.txt#L14. It refers to https://github.com/envoyproxy/envoy/blob/master/api/envoy/service/auth/v2alpha/external_auth.proto#L26 but the definition for the message being referred to starts at line 27 (not line 26).

cc @gsagula

I will look into it.
@zuercher Could you assign it to me, please? Thanks.


Out-of-bounds access in GPRCHost.m due to non-null-terminated strings

What version of gRPC and what language are you using?
Objective-C.
What operating system (Linux, Windows, …) and version?
MacOS High Sierra 10.13.3
What runtime / compiler are you using (e.g. python version or version of gcc)
XCode 9.2
What did you do?
In GRPCHost.m, NSString's dataWithEncoding: method is being used to convert the string to a byte buffer, which is then passed to grpc_ssl_credentials_create as a C-string. dataWithEncoding: does not return a null-terminated buffer (see docs, "note that the data returned by dataUsingEncoding:allowLossyConversion: is not a strict C-string since it does not have a NULL terminator"). This results in an out-of-bounds access, because grpc_ssl_credentials_create assumes that it receives a null-terminated C string:

grpc_ssl_credentials_create invokes ssl_build_config;
ssl_build_config invokes gpr_strdup;
grp_strdup passes the string to strlen, resulting in an out-of-bounds access.

We found this in Firestore running integration tests under ASan.
See #15554 for a fix.

Fixed by #15554


fix: broken links to Kubernetes documentation

Some pages must've been working for a while (I see 301s in web archive) but since a lot of time has passed, those redirects are now removed and not functioning anymore.

@ahmetb :wave: Out of curiosity i dug in a bit on this and found that those redirects were removed here: https://github.com/kubernetes/website/pull/39143.


Problem with react-tap-event-plugin

Hi,
following the react js tutorial, after installing all the dependencies required (MUI etc.) I run the project one last time and I get an error coming from react-tap-event-plugin. I am using the latest version of react (16.8.1) and I read that react-tap-event is no longer supported. Any idea on how I might get this package to work nonetheless?

I had the same issue, I completely removed react-tap-even-plugin and update MUI to alpha release. It somewhat works but not ready for production I guess. @aeneasr If you can point where we should do changes to drop react-tap-event dependency, I'd like to send a PR, work on this issue.
Wanted to know if you are cool with these?

Drop react-tap-event-plugin dependency
Upgrade MUI to latest alpha release

This way ory editor would have latest React version compatibility.

Is this issue about this?

Yes

Any updates about this issue?

Some guidance as to the correct way to solve this for now would be great. The @react-page/core package specifies:
  "peerDependencies": {
    "react": "^16.8.6",
    "react-dom": "^16.8.6"
  },

However, these newer versions don't play nice with react-tap-event-plugin (support is only through react 16.4.x), but that is required and specifically included in the documentation. So either we should have deps at a lower react version (if that works) or something else needs to be adjusted. Not 100% on what though.
Can we please get an official fix or workaround documented by someone that works on the project and has a good idea of how to resolve this? Pretty please :D

I did not notice any problem with that. Just don't install react-tap-even-plugin. I will remove it from the documentation, its no longer used or supported


AutoPr-ManagedServices-rajivnandivada-REST Spec PrNumber 5448

Rest spec Pr is unrelated to net sdk

Closing due to conflicting changes


Fetch user rather then using the host.user

The only reason for this change its that a lot of people create a set
verbal that is called user rather then on sever server seeing the user.
Plus this seams how capistrano 3 works.

@ydkn Do you mind reviewing this for me. I changed out the where the user data is pulled from based off the Capistrano document station and how we use it in are applications.
https://github.com/capistrano/capistrano/wiki/2.x-significant-configuration-variables

Hi,
the link you posted refers to the capistrano 2 configuration. In capistrano 3 you have to specify the username in the server statement e,g, https://github.com/TalkingQuickly/capistrano-3-rails-template/blob/master/config/deploy/production.rb#L14 that also allows different users on different servers.
Afaik setting the user with set :user, 'appuser' should not work. Can you please provide the relevant parts of your deployment configuration so we can figure out the problem?

Your right I am sorry. I thought they still used fetch user however they removed it. I have been using set :user and having the system overwrite some of the defaults in the Capistrano gem so it was not required to add it on ever single server. Thanks for catching this.


Add InitConfig function to brige pflag.FlagSet to viper config

Closed since this requries a bit more thought. The function is not yet reusable enough for this project.
I want to take some time and think through this.


Profile Server Input Options Usage

Pull Request Description

Added Usage Guide for Profile Server
- name: Setup Pritunl Profile and Start VPN Connection
  uses: nathanielvarona/pritunl-client-github-action@v1
  with:
    profile-file: ${{ secrets.PRITUNL_PROFILE_FILE }}
    ...
    profile-server: profile-server

It has been tested with the following parameters:

Runner Virtual Environments:

Linux

[ ] Ubuntu 22.04
[ ] Ubuntu 20.04

macOS

[ ] macOS 12
[ ] macOS 11

Windows

[ ] Windows 2022
[ ] Windows 2019

VPN Modes:

[x] OpenVPN (ovpn)
[ ] WireGuard (wg)

Client Versions:

[x] Installed from the package manager
Version specific

[ ] 1.3.3637.72

Start Connection: If the connection is started on the setup step.

[x] True
[ ] False

Runner Types:

[x] Tested on GitHub-hosted runner

Tested on Self-Hosted runner
If it runs on a self-hosted runner:

[ ] Manage Self-hosted
[ ] Action Runner Controller (ARC) (a Kubernetes Operator)

Documentation related to #80 and #83


Workspace trust - loose file choice is cleared when reloading

Steps to Reproduce:

Open Workspace and trust it
Run code-insiders foo.txt from a folder that is not trusted. -> Shows the dialog
Run code-insiders bar.txt from a folder that is not trusted. -> No warning dialog
Reload the window
Run code-insiders bar2.txt from a folder that is not trusted.

Expected:
No warning dialog should be shown
Actual:
A warning dialog is being shown

Pushed a fix for this to main. Fix is low risk so we can take it as a candidate.


sign releases

You can store public GPG keys inside the git repo itself:
http://git-scm.com/book/ch5-3.html#Tagging-Your-Releases
This then makes it convenient for others to be able to add your public key to their keychain and verify any tags or commits you have signed. Just signing tags is sufficient to sign the entire git history on the branch that is tagged, since each commit's SHA is a product of hashing that commits content with its parent commit's SHA.

We'll start doing this, at least manually, with the next release.
I've tagged and added (as a raw git object) my PGP public key.
This is how you can fetch it and add it to your GPG keychain:
$ git fetch --tags origin # assuming origin is sourceryinstitute/opencoarrays
$ git show zbeekmanpubkey | gig --import

Then tags can be verified with: git tag -v 1.3.0
The release archives can also be signed and verified with gpg.
Get it for OS X from [GPGTools}(https://gpgtools.org) or on other/all platforms from GnuPG

Release 1.3.0 is the first signed release. It should be easy/straightforward to automate some/all of this with Travis-CI for future releases.

It would be a good idea to edit the release page near the bottom to explain the different files.  I’m not clear on what each one is are so it’s certainly the case that others won’t be certain either. While we’re at it, it wouldn’t hurt to request that people download one of the first three files, which we posted, rather than the final two files, which GitHub posts automatically.

Damian Rouson, Ph.D., P.E.
President, Sourcery Institute
http://www.sourceryinstitute.org
+1-510-600-2992 (mobile)

On Jan 26, 2016, at 8:54 PM, Izaak Beekman<EMAIL_ADDRESS>wrote:
Release 1.3.0 https://github.com/sourceryinstitute/opencoarrays/releases/tag/1.3.0 is the first signed release. It should be easy/straightforward to automate some/all of this with Travis-CI for future releases.
—
Reply to this email directly or view it on GitHub https://github.com/sourceryinstitute/opencoarrays/issues/113#issuecomment-175397731.

OK, take a look at it now. You can edit it too if you like.

Nice!!!!  That documentation is a work of art.  :)


Keycloak 4.8 Support

Codecov Report

Merging #36 into develop will increase coverage by 0.14%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
+ Coverage     35.4%   35.54%   +0.14%
===========================================
  Files           32       32
  Lines          870      875       +5
===========================================
+ Hits           308      311       +3
- Misses         562      564       +2

Impacted Files
Coverage Δ

src/django_keycloak/app_settings.py
100% <100%> (ø)
:arrow_up:

src/django_keycloak/services/oidc_profile.py
69.07% <60%> (-0.83%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5211fba...f3d8155. Read the comment docs.

unsuccessful checks are related to django 1.1 which have reached it's end of life (not supported any more),
Entitlement API is deprecated in all keycloak version >= 4.8
i don't see a reason not to merge this pr and make a release


problem of 'gbk'

xbitinfo version:0.03
Python version:3.8
Operating System:windows

Description
After I installed the library, I selected a data file from the dataset submitted in Code Ocean to test the functionality of this library, and used the sample code given by the author to call it, but he kept prompting me with this error:
Traceback (most recent call last):
File "", line 991, in _find_and_load
File "", line 975, in _find_and_load_unlocked
File "", line 671, in _load_unlocked
File "", line 843, in exec_module
File "", line 219, in call_with_frames_removed
File "D:\anaconda3\envs\test\lib\site-packages\xbitinfo_init.py", line 8, in
from .bitround import jl_bitround, xr_bitround
File "D:\anaconda3\envs\test\lib\site-packages\xbitinfo\bitround.py", line 4, in
from .xbitinfo import _jl_bitround, get_keepbits
File "D:\anaconda3\envs\test\lib\site-packages\xbitinfo\xbitinfo.py", line 15, in
already_ran = install(quiet=True)
File "D:\anaconda3\envs\test\lib\site-packages\xbitinfo\julia_helpers.py", line 22, in install
julia.install(quiet=quiet)
File "D:\anaconda3\envs\test\lib\site-packages\julia\tools.py", line 112, in install
output, _ = proc.communicate()
File "D:\anaconda3\envs\test\lib\subprocess.py", line 1015, in communicate
stdout = self.stdout.read()
UnicodeDecodeError: 'gbk' codec can't decode byte 0xb0 in position 925: illegal multibyte sequence
What I Did
I searched for the reason for this problem, I think it may be a problem with the encoding of the environment, I tried to modify the encoding of the environment, including specifying UTF-8, etc., but the modification did not bring changes, every time I debug, this error still appears, I want to ask the author whether this question is my operation problem. I'm a beginner and may make some mistakes, sorry.

Hi @maker-slim,
Could you please provide a minimal working/failing example with the packages that you imported and the code you executed?
Thanks!

I'm trying to process my data：import xarray as xr
from scipy.io import loadmat
data_dict = loadmat('datadumps/test/2ASK/test_2ASK.mat')
np_data = data_dict['phd_save']
xr_data = xr.DataArray(np_data)  and then I'm trying to call this library，I'm adding a breakpoint to the import library sentence：
import xbitinfo as xb，Then I debugged it, and he just reported the error：Traceback (most recent call last):
File "", line 991, in _find_and_load
File "", line 975, in _find_and_load_unlocked
File "", line 671, in _load_unlocked
File "", line 843, in exec_module
File "", line 219, in call_with_frames_removed
File "D:\anaconda3\envs\test\lib\site-packages\xbitinfo_init.py", line 8, in
from .bitround import jl_bitround, xr_bitround
File "D:\anaconda3\envs\test\lib\site-packages\xbitinfo\bitround.py", line 4, in
from .xbitinfo import _jl_bitround, get_keepbits
File "D:\anaconda3\envs\test\lib\site-packages\xbitinfo\xbitinfo.py", line 15, in
already_ran = install(quiet=True)
File "D:\anaconda3\envs\test\lib\site-packages\xbitinfo\julia_helpers.py", line 22, in install
julia.install(quiet=quiet)
File "D:\anaconda3\envs\test\lib\site-packages\julia\tools.py", line 112, in install
output, _ = proc.communicate()
File "D:\anaconda3\envs\test\lib\subprocess.py", line 1015, in communicate
stdout = self.stdout.read()
UnicodeDecodeError: 'gbk' codec can't decode byte 0xb0 in position 924: illegal multibyte sequence
So I didn't even test its functionality, just calling this library and it just reported an error

It seems like this is an issue of the Julia installation. By default xbitinfo will install Julia if it isn't installed.
We run some automatic tests that try to cover all OS including windows and they currently do not fail.
You might try the following:

update your python to the one we test with (3.11)
install Julia manually
or use the python only implementation available with conda install xbitinfo-python

I downloaded the software Julia, I don't know if you mean installing Julia software or plug-ins? I use pycharm, which doesn't seem to have julia-related plugins. As for the two other methods, I will try them now, thank you very much.

    Regarding the three solutions you gave, I tried them one by one, I first changed my python environment to 3.11 but it is still the same problem as before, and then I have indeed installed the software julia manually, and finally the installation command you said conda install xbitinfo-python I tried in the terminal but the installation failed。
    Dear author, I will probably tell you how I use your library, I have installed the software Julia, and then I created a new 3.11 python environment, installed some libraries and installed your library through the pip command, and then I tested it according to the code I showed you above, and then this problem appeared. I'd like to know how you tested and got error-free, sorry to bother you, but my assignment requires your method, and I'd appreciate it if I could help!!

https://github.com/observingClouds/xbitinfo/blob/10a08dd3432caf82a8fc6bbea150fcd9b2db4f18/.github/workflows/ci.yaml#L144-L147
Here you can see that we do a "smoke test" on linux, Mac and windows. We install xbitinfo with pip and import it, just like you did in your mentioned example.
Could you please show us which error you get when you tried the conda install xbitinfo-python option?

  Yesterday the failure to type conda install xbitinfo-python should be the cause of the network, I tried it again and it was okay.
  I tried again today, I reinstalled Julia, I tried to type Julia in the anaconda prompt to start it and it succeed. Then I installed the xbitinfo library in the 3.11 version of Python, as you can see:

xarray                  2023.6.0
xbitinfo                0.0.3
Then I go into that environment and try to import this library:

import xbitinfo
Traceback (most recent call last):
File "", line 1, in
File "D:\anaconda3\envs\learn311\Lib\site-packages\xbitinfo_init_.py", line 8, in
from .bitround import jl_bitround, xr_bitround
File "D:\anaconda3\envs\learn311\Lib\site-packages\xbitinfo\bitround.py", line 4, in
from .xbitinfo import _jl_bitround, get_keepbits
File "D:\anaconda3\envs\learn311\Lib\site-packages\xbitinfo\xbitinfo.py", line 15, in
already_ran = install(quiet=True)
^^^^^^^^^^^^^^^^^^^
File "D:\anaconda3\envs\learn311\Lib\site-packages\xbitinfo\julia_helpers.py", line 22, in install
julia.install(quiet=quiet)
File "D:\anaconda3\envs\learn311\Lib\site-packages\julia\tools.py", line 112, in install
output, _ = proc.communicate()
^^^^^^^^^^^^^^^^^^
File "D:\anaconda3\envs\learn311\Lib\subprocess.py", line 1196, in communicate
stdout = self.stdout.read()
^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'gbk' codec can't decode byte 0xb0 in position 923: illegal multibyte sequence
In the terminal he still tells me this error，I don't think there's anything wrong with my operation, but he keeps telling me about this error, which is very confusing.

Do you really do conda install xbitinfo-python and not conda install xbitinfo? I'm surprised that you get Julia errors if you do the former of the too installation options.

I did use the previous installation instruction and I was also confused. I just changed another computer and re-tested with python, this time still in version 3.11, only xbitinfo and xarray installed, julia was not even installed on this computer, but this time I imported xbitinfo and tested it without error.If there are no mistakes this time, it should be usable, but I don't even know how to solve this problem, but thank the author for answering my question.thanks！！

Thanks for testing a different machine. It seems like your conda environment on your first machine might have some issues. Because our CI is not failing and we cannot reproduce your error due to the lack of windows machines, I am closing this issue. Glad you got the pure python implementation working.


Custom URL Support

See ML thread. This affects Issues #367 and #474 as well.

Here's the kickoff quote from Sean's mailling list post:

IIUC you're suggesting that there would be a hook so that I could handle
seansprivategitlab:// however I wanted behind the scenes. That sounds
intriguing, but how would I ensure that the seansprivategitlab:// support
was loaded in the image to be used by MetaC? Also, when you say that cloning
isn't necessary, last I checked SSH keys, gitlab, and bitbucket did not seem
well-supported by MetaC, so I'm not sure how I would avoid it (or whether I
want to; I still don't like the idea of unencrypted credentials in the
image, even if they're secure on disk; finally I've been using SmalltalkCI -
primarily because I thought Travis was GH-only).

I don't know how to implement, or how/if it fits into MetaC, but sample logic that would seem to cover both or my use cases (remote CI and local dev) is:

Augment the MetaC API to provide both a local and remote repository
If the local clone is not present, create it using SSH key auth
Then, load from the local clone

@seandenigris doesn't iceberg create local clones using SSH key auth?

@seandenigris it does look like iceberg has come to your rescue unless I am missing something else?


Incorrect feature name in linux_session

First off, I am really enjoying this library, so thank you. I've noticed an issue using asyncio on linux, where the code is conditional on a feature that doesn't exist (notice the _ instead of -)
https://github.com/cloud-hypervisor/fuse-backend-rs/blob/f18d4be0fe08b1bb4d04cf167f19e422f03e46ef/src/transport/fusedev/linux_session.rs#L405
https://github.com/cloud-hypervisor/fuse-backend-rs/blob/f18d4be0fe08b1bb4d04cf167f19e422f03e46ef/src/transport/fusedev/linux_session.rs#L408

Hey,
Please see my comment on https://github.com/cloud-hypervisor/fuse-backend-rs/issues/188


iscloudver() understrand +up versions.

I apologize, I didn't see this PR before pushing my own fix (which did the same :-(). Sorry!


Created example for external database scenario, altered module to mak…

…e rds database optional

resolves #6


Time dependence and AMR for ADM

This merge request adds a new function pointer, SetADMVariables, to the ADM class. By default it uses ADM::SetADMVariablesToKerrSchild, which uses the existing Kerr-Schild infrastructure. By setting coord/minkowski = true in the parameter file, this reverts to flat Minkowski space as it would for anything else using the Kerr-Schild functions. This has the added benefit that many of the shared pgens using Minkowski or Kerr-Schild coordinates are cleaned up and replaced with a single call to padm->SetADMVariables() instead.
This API is intended to fix #600. When AMR is enabled, SetADMVariables is called at the end of MeshRefinement::RedistAndRefineMeshBlocks, which means that the ADM metric will be completely defined everywhere on the new grid, allowing AMR evolution with DynGRMHD without needing to enable Z4c as well. Other metrics can be defined by pointing SetADMVariables to a different function; it should be a void function that takes the MeshBlockPack as a single argument.
An additional task has been added to the DynGRMHD task list to allow for dynamical ADM evolution, and examples are contained in an extension to the blast pgen with an FLRW metric and the new dynbbh pgen, which superposes two Kerr-Schild black holes and moves them along a circular orbit. Dynamical evolution in the task list can be enabled with adm/is_dynamic = true.
Draft to-do list:

[ ] Update TOV pgen to use SetADMVariables. This probably needs to be postponed and done as part of the TOV refactor.
[x] Check that all pgens compile and work as intended.
[x] Check that GRMHD+Z4c still works as intended.

@jfields7 @jmstone I'm getting the following compilation error on della because of the change in shock_tube.cpp; have you guys seen this?
/home/hz0693/athenak/src/pgen/tests/shock_tube.cpp(129): error: identifier "_NV_ANON_NAMESPACE::shk_dir" is undefined in device code

It seems to me that I saw this once before, but apparently it didn't end up in this branch. I think it's a very selective issue that only shows up in some versions of the CUDA compiler. If I recall correctly, it's related to the variable shk_dir declared inside the anonymous namespace at the beginning of the pgen file. The easiest solution is to replace the references on lines 125 and 331 auto &shk_dir_ = shk_dir with the direct copies auto shk_dir_ = shk_dir.


redirect_uri can only be set during instantiation of the OAuth Provider?

It seems one has to provide the redirect_uri as part of the $options array when instantiating a OAuth2Provider.
I would like to have a DependencyInjectionContainer instantiate the OAuth2Provider using only the clientId and clientSecret parameters, and then have our application logic figure out the redirect_url and hand it over in one of these approaches:

$provider->authorize(['redirect_uri' => 'run-time assembled URLgoes here']);
$authorizationUrl = $provider->getAuthorizationUrl(['redirect_uri' => 'run-time assembled URLgoes here']);

This is currently not possible. However, our DIC should not be aware of any redirectUrls... Is this limitation on purpose?

Can I ask which service you are planning to consume with this expected functionality? There are no absolutes in the OAuth conversation and many API providers require an explicit list of acceptable redirect_uris be configured within their application's developer portals as an additional security measure. This security measure, when present, would directly compete with your desire to generate URLs on-demand. My guess is that many iterations ago it was decided to not implement the setter method in question because it likely not be useful due to the redirect uri whitelisting.
If you are consuming a very specific API that does not implement this whitelisting requirement, may I suggest building a custom client, if it doesn't already exist, or extending an existing client to add the setter method in question?

and many API providers require an explicit list of acceptable redirect_uris be configured within their application's developer portals as an additional security measure.

Yeah, this was also the case, had to register specific URLs. So I now have stored this URL as (DTAP environment-specific) setting instead of autogenerating it.
I think you are right, I should have reported back here and closed the issue to prevent others from wasting energy on this, sorry! => closing issue.


New secondary button variant: Decline

Description
Add new variant for secondary button called 'declination' that has a more visible color on hover state.
Issue ticket number and link
https://trello.com/c/fciq6gbU/224-decline-button-in-user-approval-has-no-hover-state-approve-has
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged and published in downstream modules

Is this a new requirement coming from the base design system?

I checked it with the UI team, we don't have a new "decline" variant in the design system. If this is a bug with one of the existing components please discuss it with the UX/UI team and update the existing component variant.

@nemvalid I've talked to the UI team and this won't be needed after all. Thank you. Closing this.


Kubeapps package v10.3.3 - app v2.5.1

Summary:
Generate and publish a new package corresponding to release Kubeapps v2.5.1 (chart version 10.3.3).
Acceptance criteria

[x]  Test passed for new package
[x]  New carvel package available for Kubeapps v2.5.1

Kubeapps Carvel Package 10.3.3 has been released.
It can be found in production Harbor.
Test results
Info: Testing installation of new package 10.3.3
Creating cluster "kubeapps-carvel-e2e" ...
 • Ensuring node image (kindest/node:1.24.0) 🖼  ...
 ✓ Ensuring node image (kindest/node:1.24.0) 🖼
 • Preparing nodes 📦   ...
 ✓ Preparing nodes 📦
 • Writing configuration 📜  ...
 ✓ Writing configuration 📜
 • Starting control-plane 🕹  ...
 ✓ Starting control-plane 🕹
 • Installing CNI 🔌  ...
 ✓ Installing CNI 🔌
 • Installing StorageClass 💾  ...
 ✓ Installing StorageClass 💾
 • Waiting ≤ 2m0s for control-plane = Ready ⏳  ...
 ✓ Waiting ≤ 2m0s for control-plane = Ready ⏳
 • Ready after 19s 💚
Set kubectl context to "kind-kubeapps-carvel-e2e"
You can now use your cluster with:

kubectl cluster-info --context kind-kubeapps-carvel-e2e --kubeconfig /tmp/kubeapps-carvel-e2e

Thanks for using kind! 😊
Cluster config: /tmp/kubeapps-carvel-e2e
namespace/kapp-controller created
namespace/kapp-controller-packaging-global created
apiservice.apiregistration.k8s.io/v1alpha1.data.packaging.carvel.dev created
service/packaging-api created
customresourcedefinition.apiextensions.k8s.io/internalpackagemetadatas.internal.packaging.carvel.dev created
customresourcedefinition.apiextensions.k8s.io/internalpackages.internal.packaging.carvel.dev created
customresourcedefinition.apiextensions.k8s.io/apps.kappctrl.k14s.io created
customresourcedefinition.apiextensions.k8s.io/packageinstalls.packaging.carvel.dev created
customresourcedefinition.apiextensions.k8s.io/packagerepositories.packaging.carvel.dev created
deployment.apps/kapp-controller created
serviceaccount/kapp-controller-sa created
clusterrole.rbac.authorization.k8s.io/kapp-controller-cluster-role created
clusterrolebinding.rbac.authorization.k8s.io/kapp-controller-cluster-role-binding created
clusterrolebinding.rbac.authorization.k8s.io/pkg-apiserver:system:auth-delegator created
rolebinding.rbac.authorization.k8s.io/pkgserver-auth-reader created
Waiting for v1alpha1.data.packaging.carvel.dev apiservice to be available...
Waiting for v1alpha1.data.packaging.carvel.dev apiservice to be available...
Waiting for v1alpha1.data.packaging.carvel.dev apiservice to be available...
Waiting for v1alpha1.data.packaging.carvel.dev apiservice to be available...
Waiting for v1alpha1.data.packaging.carvel.dev apiservice to be available...
True
Installing Kubeapps with Carvel package 10.3.3
packagemetadata.data.packaging.carvel.dev/kubeapps.community.tanzu.vmware.com created
package.data.packaging.carvel.dev/kubeapps.community.tanzu.vmware.com.10.3.3 created

 Added installed package 'kubeapps'
Package install for version '10.3.3' reconciled successfully. Deleting...
Uninstalled package 'kubeapps' from namespace 'default'
Deleting cluster "kubeapps-carvel-e2e" ...


misc: slist: Rework sys_slist_get_not_empty

Magic spell to address #4022.
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

I would suggest a bit more verbose commit message, it is very unclear from comment what the fix is doing.

@jukkar , yeah, expect continuation of #4022 detective. This was mostly posted to have a CI run.

yeah, expect continuation of #4022 detective.

That went as https://github.com/zephyrproject-rtos/zephyr/issues/4022#issuecomment-336844059 , including as the last step, spotting the real issue.
This patch is no longer considered a fix, but a possible optimization, subject for more assessment. See https://github.com/zephyrproject-rtos/zephyr/pull/4350 instead.

Ok, I withdraw this patch. Checking with x86 showed that sample app's total size increased by 8 bytes, whice ARM stayed the same. Both are likely subject to code section alignment though.
Looking at the assembly, the compiler definitely had to materialize 0 to a register with this patch, which it didn't have to do before. On the other hand, the efficiency on the current code depends on compiler's reusing node->next as a common subexpression. If I write such code, I'd introduce an explicit variable (sys_snode_t *next = node->next), to make such common subexpression reuse unavoidable for the compiler, but well, GCC does CSE itself well in this case, so I guess it makes no sense to patch the code just from a paranoia that some compiler won't.


[[CHORE]] Remove unuseful code

Some great finds here! Merged to master at commits:

db7e29b30a653f05c1142c86d3761d5c602dc505
92aaaf0bd69450590db822fd926fe8fbe6985391
bdf3ea0312e131bffa6850e4e587348c6e3abafa


GUI for initializing the instrument selecting

instrument list: all instruments in the lab or all instruments in the server;
function:

Check the instruments you want to control in the following measurement;
Quick restore the latest setting;
Save and read the project-specific setting.

instrument list: all instruments in the lab or all instruments in the server;
function:

Check the instruments you want to control in the following measurement;
Quick restore the latest setting;
Save and read the project-specific setting.


Seldon Core charm re-write using sidecar (discard this PR)

PR for side car re-write of Seldon Core Operator.
Work tracked in https://github.com/canonical/seldon-core-operator/issues/42
Summary of changes
Refer to commit logs.
Outcomes
The following resources deployed and example deployment can be deployed (related to seldon-core-operator):
Juju
Model
seldon-sidecar
App
seldon-controller-manager
Unit
seldon-controller-manager/0

K8S
pod/seldon-core
service/seldon-core-endpoints
service/seldon-core
service/seldon-webhook-service
statefulset.apps/seldon-core

Testing
Refer to https://github.com/canonical/seldon-core-operator/issues/42 for more details on testing and verification.

Need to discard/close this PR due to incorrect branch name.
Store operation failed:
- None: Invalid branch name: kf-568-gh42-feat-sidecar_rewrite (letters, numbers or hyphens only; no hyphens at the start or the end)
Full execution log: '/home/runner/snap/charmcraft/common/cache/charmcraft/log/charmcraft-20221007-155342.240980.log'
Error: The process '/snap/bin/charmcraft' failed with exit code 1

Closing this pull request due to incorrect branch naming.


(profile::pi::gpshat) fwv

Depends on #1008

I just realized pigpio is missing. I'm pulling this back from review.

looks ok but i guess this is more for @fritzm


added support for npm-shrinkwrap.json

Fixes #1848
Changes proposed:

[x] Add
[ ] Delete
[ ] Fix
[ ] Prepare

Just FYI, pnpm also uses shrinkwrap.json as a lock file. But because npm has the prefix it makes the filename unique.


Loadout CRUD Operations

Need to complete the edit/delete operations for loadouts.

Need to update the save label from loadouts to loadouts-v2


[FE] Validate token bindings checkbox value is not reflected in checkbox

Describe the Issue:
The checkbox Validate token bindings is always checked, regardless of the value returned from the API.
How To Reproduce:

In the console, create a new standard-based application.
Go to the Protocol tab and enable sso-session binding for the access token.
Notice that the checkbox Validate token bindings is checked by default.
Uncheck this and click update.
Reload the page and observe that the checkbox is still checked.

Notice in the network trace that the updates are happening correctly and the correct value is returned. It is not reflected in the checkbox correctly.
https://github.com/wso2/product-is/assets/46979289/e91afaa2-0ce9-44e5-953e-fbb2ef7966c4
Expected behavior:
The checkbox should indicate the actual value.

Issue was a regression introduced through: https://github.com/wso2/identity-apps/commit/e2ed10aaa3c1bc125cee4996a20e8ae21906bd9c#diff-7e55f319d275ebee15c91c34b2455b3ce53cee47cecb1befc266b18d83649f26R2183

Fix: https://github.com/wso2/identity-apps/pull/5241

Verified in latest wso2is-7.0.0-beta6-SNAPSHOT
https://github.com/wso2/product-is/assets/37938529/9050b396-1918-44dc-913f-53822d786851