rewriteAssetPath matches code blocks

I have a project called Ted that uses ember-simple-auth. At some point in the ember build pipeline the regex /["'\(=]{1}\s*([^"'\(\)=]*ted\.js[^"'\(\)\\>=]*)(\?[^"'\)> ]*)?\s*[\\]*\s*["'\)> ]{1}/g is used on the vendor file. Since ember-simple-auth has a code part like this
transition and instead transitions to the
{{#crossLink "Configuration/authenticationRoute:property"}}{{/crossLink}} if
the session is not authenticated.

```js
// app/routes/protected.js
import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';

export default Ember.Route.extend(AuthenticatedRouteMixin);
```

The regex now matches
"}}{{/crossLink}} if
the session is not authenticated.

```js
// app/routes/protected.js
import AuthenticatedRouteMixin from '

which leads to this error
File: assets/vendor-6461e56a880aae756be022e1c294a533.js
The Broccoli Plugin: [AssetRewrite] failed with:
TypeError: Cannot read property '2' of null
    at AssetRewrite.rewriteAssetPath (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-asset-rewrite/index.js:124:91)
    at AssetRewrite.processString (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-asset-rewrite/index.js:163:24)
    at AssetRewrite.processFile (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-filter/index.js:165:31)
    at asyncProcessFile (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-filter/index.js:122:21)
    at lib$rsvp$$internal$$tryCatch (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/rsvp/dist/rsvp.js:493:16)
    at lib$rsvp$$internal$$invokeCallback (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/rsvp/dist/rsvp.js:505:17)
    at /###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/rsvp/dist/rsvp.js:1001:13
    at lib$rsvp$asap$$flush (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/rsvp/dist/rsvp.js:1198:9)
    at nextTickCallbackWith0Args (node.js:420:9)
    at process._tickCallback (node.js:349:13)

The broccoli plugin was instantiated at:
    at AssetRewrite.Plugin (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-filter/node_modules/broccoli-plugin/index.js:7:31)
    at AssetRewrite.Filter [as constructor] (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-filter/index.js:34:10)
    at new AssetRewrite (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-asset-rewrite/index.js:27:10)
    at AssetRewrite (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-asset-rewrite/index.js:22:12)
    at new AssetRev (/###/Projects/ted/node_modules/broccoli-asset-rev/lib/asset-rev.js:29:10)
    at AssetRev (/###/Projects/ted/node_modules/broccoli-asset-rev/lib/asset-rev.js:7:12)
    at Class.module.exports.postprocessTree (/###/Projects/ted/node_modules/broccoli-asset-rev/index.js:32:14)
    at /###/Projects/ted/node_modules/ember-cli/lib/broccoli/ember-app.js:506:27
    at Array.forEach (native)
    at EmberApp.addonPostprocessTree (/###/Projects/ted/node_modules/ember-cli/lib/broccoli/ember-app.js:504:23)

Any suggestions for a workaround for now?

I'm also experiencing this where broccoli-asset-rev is being called with multiple lines. This causes the regexp to fail. In my instance it is being called on:
assets/bootstrap.css-c7ffd8c7a285780039b2366034f3bca2.map */

/*!
 *  Font Awesome 4.5.0 by @davegandy - http://fontawesome.io - @fontawesome
 *  License - http://fontawesome.io/license

@spieker I have a workaround however I don't think this is actually a bug in this repo, since this isn't expecting a multiline sourcemap input. My instinct is that the bug is actually in broccoli-asset-rewrite, but I don't know much about how this all really works.
If you want to use my workaround you can add my repo to your package.json.
npm install binhums/broccoli-asset-rewrite --save-dev

I'll submit a pull request anyway to highlight the issue / bug fix.

I don't know if this is what is going on here, the stack trace looks very similar:
https://github.com/ember-cli/ember-cli/issues/6265

I get this same error, it's preventing us from upgrading to the latest broccoli-asset-rewrite

One workaround is to add assets/vendor.js to your fingerprint config's ignore list. (exclude won't work)

In our case we just renamed the output file from /assets/ted.js to /assets/app.js and everything was working again.

Same problem here. I wanted to experiment with some fingerprinting settings locally. I was manually enabling fingerprinting in dev by setting app.options.fingerprint.enabled = true; in ember-cli-build.js and running ember build. I got the same error as @spieker except with vendor.css.
Everything works fine for a normal production build though: ember build --environment=production

Did the same as @spieker. When step debugging, it looks like the rewrite chokes on the comments added during concatenation.

+1

Cannot read property '2' of null```

@omairvaiyani Running into this exact error after upgrading an Ember 3.4 app to Ember 3.5. Did you ever figure this out?

I ran into this again while upgrading from Ember 3.3 to Ember 3.16 (🤞 🐹 🤞), this time in our fingerprinted test-support.js file. I noticed we never grabbed the broccoli-asset-rev 3.0.0 update, which bumps broccoli-asset-rewrite to 2.0.0, and contains this change: https://github.com/ember-cli/broccoli-asset-rewrite/pull/64/files. This fixed my most recent issue!
If you're running into this still, double check that you're using broccoli-asset-rewrite 2.0.0+ (npm ls broccoli-asset-rewrite)


Bugfix of Electron Density Plot

This pull request provides the bugfix in the export of the electron densities; the lack of the comm_is_root checks. Presently, this routine does not make any problems in the calculation, however we expect it will cause the significant I/O troubles in the future implementation.

Thank you!


Convenient Use of Function Parameters

Addresses Part 1 of #115: Users can use arbitrary argument names for the functions and parameters are automatically forwarded based on the function interface.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It would be good to explain the usage of the arguments in the documentation

It would be good to explain the usage of the arguments in the documentation

This is only the first part of a larger change that I break down into self-contained features to be better consumed by the reviewers. Explaining the current state won't make too much sense since it will change a bit. I'll add it with the next change.


Remove cycles from IR by migrating the type inference pass to use the StaticModuleScope metadata instead of BindingsMap

In #11399 I'm introducing StaticModuleScope needed to be able to resolve method calls on atoms. It has some resemblance to BindingsMap but it is a bit 'higher-level' - instead of holding raw IR expressions, it contains type representations that are not part of raw IR. It was needed to reflect the runtime ModuleScope.
Since it's available, the resolution of atom constructors in type propagation could also rely on StaticModuleScope instead of BindingsMap. This will allow us to remove the added typReference expression from Argument type which will get rid of a problematic cycle in the IR. This should then fix an issue with duplicate that does not like cycles in the IR.

I am facing the "cycle in IR" problem while working on

#11171

The cycle goes from Argument an cycles thru:
[error]     at org.enso.compiler.core.ir.Name$Literal.duplicate(Name.scala:531)
[error]     at org.enso.compiler.core.ir.Name$Literal.duplicate(Name.scala:474)
[error]     at org.enso.compiler.pass.resolve.TypeSignatures$Signature.duplicate(TypeSignatures.scala:369)
[error]     at org.enso.compiler.core.ir.MetadataStorage.duplicate(MetadataStorage.java:98)
[error]     at org.enso.compiler.core.ir.Name$Literal.duplicate(Name.scala:531)
[error]     at org.enso.compiler.core.ir.Name$Literal.duplicate(Name.scala:474)


resolves #1093 allow column rule to be specified for columns in running content

@marcdexet-cnrs If you'd like to see this make it into beta.1, see if you're able to achieve the layout you want so I can determine if this is the right change.

@marcdexet-cnrs If you'd like to see this make it into beta.1, see if you're able to achieve the layout you want so I can determine if this is the right change.

Sure. Which branch should I use ?

https://github.com/mojavelinux/asciidoctor-pdf/tree/issue-1093-running-content-column-rule

I get a problem
base:
  font_size: 10
  font_size_large: $base_font_size * 1.25
  font_size_small: $base_font_size * 0.85

page:
  size: A4
  margin: [3.2cm, 1cm, 1cm, 1cm]

header:
  columns: <25% =50% >25%
  border_color: #dddddd
  border_style: solid
  column_rule_color: '333333'
  column_rule_width: 0.5
  recto:
    left:
      content: 'A name'
    center:
      content: '{doctitle}'
    right:
      content: |
        ref-doc: *{ref-doc}* +
        version: *{revnumber}* +
        date: {localdate} +
        page: *{page-number}/{page-count}*
  verso:
    left:
      content: $header_recto_left_content
    center:
      content: $header_recto_center_content
    right:
      content: $header_recto_right_content
  height: 3cm

I try to adjust my properties, maybe there's something with my former values wrong.

Nope, it's not your settings. The code is moving the cursor location and
not restoring it. That's the testing I was looking for.
Btw, you can use column_rule_spacing to move the text away from the line.

It should be resolved now. Give it another shot.

It should be resolved now. Give it another shot.

I have no more header at all :)

Do you want my documentation and my theme file ?

Your example works perfectly for me. Are you sure you updated the branch correctly? Try deleting it and pulling it down again.

I check

Yes ! It's good :)
I have removed but forgotten to checkout the right branch.

It's very good !!


DIOR-R

Hello, I want to reproduce your ARS-DETR model on DIOR-R dataset, but there was an error during testing, can you provide the configuration file for DIOR-R dataset? Thank you for your work!

Can you provide specific information about the error you encounted?

您好，这是我的配置信息和报错，麻烦您帮我看一下哪里有问题？
酒醉逍遥
@.**

------------------ 原始邮件 ------------------
发件人:                                                                                "httle/ARS-DETR"                                                                                @.>;
发送时间: 2024年3月25日(星期一) 上午8:27
@.>;
<EMAIL_ADDRESS>主题: Re: [httle/ARS-DETR] DIOR-R (Issue #11)
Can you provide specific information about the error you encounted?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

您好，您这个报错文件没传上来，麻烦重传一下


Update reference documents for Azure CLI @ 0.4.0-beta.2

Update reference documents for Azure CLI @ 0.4.0-beta.2

Learn Build status updates of commit b81b740:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because ref +refs/pull/993/merge has been deleted or has been force pushed.
 If this is pull request, please ensure it is mergeable (no merge conflict) and open (not closed).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Update cats-time to 0.4.0

Updates io.chrisdavenport:cats-time from 0.3.4 to 0.4.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.chrisdavenport", artifactId = "cats-time" } ]

labels: library-update, semver-minor

Codecov Report

Merging #552 (4361e34) into main (03a6877) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   85.27%   85.27%
=======================================
  Files         124      124
  Lines        1596     1596
  Branches       34       34
=======================================
  Hits         1361     1361
  Misses        235      235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a6877...4361e34. Read the comment docs.


chore(attachments): create attachments component to alleviate duplicate code

What this PR does 📖

create attachments component to alleviate duplicate code

Which issue(s) this PR fixes 🔨

Resolve #
No resolve # for this issue

Special notes for reviewers 🗒
For testing, attachments should look and function exactly how they already do.
Also, this pr is dependent on the #652 pr going in first
Additional comments 🎤

Thank you and pretty sure I got it fixed @phillsatellite !

Hey @phillsatellite ! after a long battle with css and a boatload of merge issues  I decided to have a little work around and it should be good now!


RHMAP-11489 Uncheck Requires full screen to add multitasking support

@jcesarmobile Is it still valid? I don't can I test it?

@danielpassos is valid, but the issue was about updating all the templates and I only had time to update this one. We can close it and create a new one in the future  (as it's a really small PR) or reopen once we work on RHMAP-11489 again


Fixes ACDC AcquisitonEra, etc setting

fixes #6098

@amaltaro, Please review. Still need more test. Please don't merge yet.

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/362/ for details

@amaltaro, Alan, I am not sure how to create the task chain workflow and only to make merge job fail. Could you help me with the test? Thanks,

Seangchan, AFAIK creation of Resubmission workflows is working fine and inheriting the right information. From the quick look I had, it fixes only request creation but not assignment, right?
If so, the problem happens during assignment when merge tasks default to None.
About the test, we can use this template
https://github.com/dmwm/WMCore/blob/master/test/data/ReqMgr/requests/DMWM/TaskChain_MC.json
but then we need to watch those jobs from the agent and kill the merge jobs when they make it to condor (the hard way :)).

No pylint warnings for pull request 6161:

No changes to unit tests for pull request 6161

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/364/ for details

No pylint warnings for pull request 6161:

No changes to unit tests for pull request 6161

Hi Alan, do you know which script they are using to assign Resubmission workflow?
So when they assign it they don't pass acquisition era, etc. The way it (merge task acdc) get assigned different from other tasks (acdc)?
It is weird that only Merge task ACDC has the problem not others.
Anyway, I updated the code I will try to test it. (reqmgr2-dev.cern.ch) Could you run the test there as well when you get a chance.  Thanks.
Seangchan

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/368/ for details

No pylint warnings for pull request 6161:

Pre-python 2.6 idioms found in changed files. Please consider updating the code. Suggested patch follows:
--- src/python/WMCore/HTTPFrontEnd/RequestManager/Assign.py (original)
+++ src/python/WMCore/HTTPFrontEnd/RequestManager/Assign.py (refactored)
@@ -316,7 +316,7 @@
         if kwargs.get("ProcessingString", None):
             processedDatasetParts.append("ProcessingString")
         for field in processedDatasetParts:
-            if type(kwargs[field]) == dict:
+            if isinstance(kwargs[field], dict):
                 for value in kwargs[field].values():
                     self.validate(value, field)
             else:
@@ -325,9 +325,9 @@
         # Set white list and black list
         whiteList = kwargs.get("SiteWhitelist", [])
         blackList = kwargs.get("SiteBlacklist", [])
-        if type(whiteList) != list:
+        if not isinstance(whiteList, list):
             whiteList = [whiteList]
-        if type(blackList) != list:
+        if not isinstance(blackList, list):
             blackList = [blackList]
         helper.setSiteWildcardsLists(siteWhitelist = whiteList, siteBlacklist = blackList,
                                      wildcardDict = self.wildcardSites)

No changes to unit tests for pull request 6161

Sure, I'll run a test and kill some jobs as soon as I get at CERN.
ACDCs are usually assigned via webpage, but not TaskChain since we need to provide:
"AcquisitioEra": {'Task1Name': 'Tas1AcqEraValue', 'Task2Name': 'Tas2AcqEraValue', ..}
and the same for ProcessingString. (and that's when the merge task is lost)

Thank you very much Alan,

ACDCs are usually assigned via webpage, but not TaskChain since we need to provide:
"AcquisitioEra": {'Task1Name': 'Tas1AcqEraValue', 'Task2Name': 'Tas2AcqEraValue', ..}
and the same for ProcessingString. (and that's when the merge task is lost)

Do you know which script is used for assigning the TaskChain ACDC?
For ACDC, why  do we need above in assignment? ACDC workflow is not TaskChain anymore, isn't it?
(since ACDC runs over only one task.)

Can you believe I ran 3 workflows and I failed to kill a single merge job?!?! :-(
I even set this cronjob to get them automatically removed
*/3 * * * * condor_rm -const 'CMS_JobType =?= "Merge"'
but did not work. I'll inject more requests.
Now answering your last message, I believe this is what they use to assign ACDC TaskChain
https://github.com/CMSCompOps/WmAgentScripts/blob/master/assignProdTaskChain.py

For ACDC, why do we need above in assignment? ACDC workflow is not TaskChain anymore, isn't it?

This is not true for TaskChains :) It will still have the same structure as a TaskChain, well, actually starting the task where it was resubmitted from. So exactly the same if recovering Task1, slightly different if recovering Task2. See this example:
https://reqmgr2-dev.cern.ch/reqmgr/view/showWorkload?requestName=amaltaro_ACDC_TaskChain_Task_Multicore_Seangchan_Bugfix6161_TEST_v3_150825_163959_4395

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/410/ for details

No pylint warnings for pull request 6161:

Unit test changes for pull request 6161:

WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testContinuousSplittingSupport was added. Status is success
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testMultiTaskProcessingWorkload was added. Status is success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testParentProcessing changed from failure to success
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlockWithParents changed from success to error
WMCore_t.WMRuntime_t.DashboardInterface_t.DashboardInterfaceTest:testAFailedJobMonitoring changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testGetMaskedBlocks changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testListOpenFileBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testTier1ReRecoWorkload changed from success to error
nose.failure.Failure:runTest was deleted. Prior status was error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Dataset_t.DatasetTestCase:testMultiTaskProcessingWorkload changed from error to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testPileupData changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWhiteBlackLists changed from failure to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testBlockIsOpen changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testContinuousSplittingSupport changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReDigi_t.ReDigiTest:testThreeStepChainedReDigi changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testExtremeSplits was added. Status is success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testInvalidSpecs changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testInvalidSpecs was added. Status is success
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testEmptyACDC changed from success to error
WMCore_t.WMBS_t.JobSplitting_t.LumiBased_t.LumiBasedTest:testA_FileSplitting changed from failure to success
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testShiftedStartSplitting was added. Status is failure
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFileBlock changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testGetFiles changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testLHEProductionWorkload was added. Status is failure
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testDataDirectiveFromQueue changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testWithMaskedBlocks changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.ReReco_t.ReRecoTest:testReReco changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testBasicProductionWorkload was added. Status is success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testLumiSplitTier1ReRecoWorkload changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.ResubmitBlock_t.ResubmitBlockTest:testUnsupportedACDC changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testlistDatasetFileDetails changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testlistRunLumis changed from success to error
WMCore_t.Services_t.DBS_t.DBSReader_t.DBSReaderTest:testBlockToDatasetPath changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testIgnore0SizeBlocks changed from success to error
WMCore_t.WorkQueue_t.Policy_t.Start_t.MonteCarlo_t.MonteCarloTestCase:testMultiMergeProductionWorkload was added. Status is success
WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testMultiTaskProcessingWorkload changed from success to error
WMCore_t.WMSpec_t.StdSpecs_t.StoreResults_t.StoreResultsTest:testStoreResults changed from success to error

fixed by #6266


Add support for picking fields with @

as discussed at https://github.com/pegjs/pegjs/issues/11,
foo = @bar _ @baz
bar = $"bar"i
baz = $"baz"i
_ = " "*

parse('barbaz') // returns [ 'bar', 'baz' ]

I use this syntax frequently when it's available.

Like the idea in principle. Will this syntax clash if we decide to use @decorators or @annotations for rules?

Oh, great question.  Let's mock those in when we first implement this, and make sure the grammar doesn't clash.  In peg.js, it's pretty straightforward, and applies only on the RHS of rules: https://github.com/pegjs/pegjs/blob/b7b87ea8aeeaa1caf096e2da99fd95a971890ca1/src/parser.pegjs#L148

I personally prefer to reserve @ sign for the picking operator, because it is very short and take attraction to itself, and for annotations/decorators/attributes use another syntax, for example, Rust-like: #[attribute]. Symbol # now is unused in the grammar so no clash.
Having @ both as picking operator and as annotation operator definitely will create clash on the grammar until semicolons for delimiting rules are optional

Are there any other ASCII-7 characters available?  I'd like to make sure we're not misaligned with https://github.com/tc39/proposal-decorators as it goes to stage 3, if possible.

# is used to indicate private in JS, maybe that's a better fit? it would imply inverting the syntax though:
foo = bar #_ baz
bar = $"bar"i
baz = $"baz"i
_ = " "*

How about "any rule starting with an underscore".
Since this could potentially break existing code, hide this behind an opt-in.
Next step is auto-generating such rules, i.e.
foo = bar _ws baz
bar = $"bar"i
baz = $"baz"i
ws = " "*

where _ws isn't explicitly defined.

@TymurGubayev syntax changes should be purely additive imo. It's really important that we don't break the grammars that exist in the wild. _ is a valid identifier character so we can't use it for this

Another possible way of evolution -- change how the rule rule itself is defined and thus make it impossible to create clash.
At least two options can be suggested:

change the rule definition to something like this (the https://github.com/kevinmehall/rust-peg way):

rule rule_name() = ...

The empty brackets are not allowed in the current grammar, so no clash.

the other way is just make the optional semicolon in the end of the rule definition required. Personally I think that is easest and right way to solve this problem, because modern JS rules also requires semicolons to make syntax consistent.

* the other way is just make the optional semicolon in the end of the rule definition required. Personally I think that is easest and right way to solve this problem, because [modern JS rules](https://eslint.org/docs/rules/semi#require-or-disallow-semicolons-instead-of-asi-semi) also requires semicolons to make syntax consistent.

I'm -1 on this.  A more nuanced reading of the link above might be "There are problems with ASI no matter which way you choose.  Make sure to use lint rules to protect yourself either way." I really don't want us to pick a side on this, because it will alienate a bunch of people either way we pick for not enough benefit.

the other way is just make the optional semicolon in the end of the rule definition required.

This has been repeatedly suggested throughout the years.  This breaks javascript and must not occur.

because modern JS rules also requires semicolons to make syntax consistent.

No they don't.  Your preferred eslint config is not "modern JS rules."

@hildjj - In the linked issue, you suggested that this could be used to ignore productions.  At this time I do not yet understand how.
The ability to ignore productions would be huge for me.  I maintain a compiler behind peg mostly just for this.
Would you show me how this syntax enables that, or did I misunderstand?

Another possible way of evolution -- change how the rule rule itself is defined and thus make it impossible to create clash.

If there are breaking changes, this is a meaningless anti-fork, and I will just resurrect my fork.
No, we're not going to throw away the entire community on a whim to get a minor feature that can be had other ways.  Don't be irresponsible.

@hildjj - In the linked issue, you suggested that this could be used to ignore productions. At this time I do not yet understand how.

It would allow it by solving a slightly different problem: marking the productions you want to save.  If the syntax is small enough, it seems like an approach you might like just as well as marking the ones you want to ignore.

No, we're not going to throw away the entire community on a whim to get a minor feature that can be had other ways. Don't be irresponsible.

Let's all assume good intent from everyone involved, please.  We'll make decisions together, but ideas that we don't take may kick off new ideas that we do like.

We'll make decisions together, but ideas that we don't take may kick off new ideas that we do like.

Any significant breaking change means this library is useless to me, and the original must be re-saved.  This will almost certainly be true of every other user of the old library.
I'm letting you know, right now, that people who clung to the old library for a year and a half after its old maintainer murdered it through negligence are doing so because they don't have a choice.
If you make breaking changes, you're creating the exact same extermination choice.
It's important to get this through everyone's head, early, or else you'll lose the whole thing over whimsy.
The way to fork a dying library to save the old community is well understood.  Don't re-murder it.

It would allow it by solving a slightly different problem: marking the productions you want to save. If the syntax is small enough, it seems like an approach you might like just as well as marking the ones you want to ignore.

Well, okay, that's fine, maybe even useful
But please understand that it's critically different than the issue you tagged it from, and doesn't do anything at all for people who need to ignore productions

I'm committed to backward compatibility.   I'm committed to doing good semantic versioning to ensure that people can make good decisions about when to upgrade.  I'm committed to being a steward for the community's consensus (see my work at the IETF for examples of how much I value consensus over my own opinions).
Over time, hopefully we can build enough trust in those commitments.

I'm committed to backward compatibility

❤

I'm committed to doing good semantic versioning to ensure that people can make good decisions about when to upgrade.

👍

my work at the IETF

🦾

This has been repeatedly suggested throughout the years. This breaks javascript and must not occur.

I'm confusing: how is slight change of the PEG syntax can break (generated) js? Furthermore, requiring semicolons doesn't really introduce new syntax, but reuses existing one. I can't imagine any situation where you won't be able to switch from the optional semicolons to the required ones. That is why I think that this is the most safe way to resolve ambiguity (except using the other symbol, of course).

Your preferred eslint config is not "modern JS rules."

That is not my preferred config, honestly, I'm even don't use JS regularly. It is just ESLint default. And I think that people had some good reasons to make defaulted exactly that variant. So I think, that choice could be called "modern rules".

Let's not get bogged down in any of the syntax wars here, please.  Any valid JS should be able to go into an action block.

Any valid JS should be able to go into an action block.

Of course, of course, that is holy cow... My suggestion doesn't touch any code blocks at all, it is about semicolons in the grammar, not in the code blocks. Code blocks are always were opaque things and that remains unchanged.

Nod, that's a helpful distinction.

PR #89 is pretty close at this point.
I do like it; I use @ enough that i've gone out of my way in a couple of non-production projects to rely on odd versions of pegjs in the past.  The implementation is adequate (if a little confusing because of the way the stack manipulation has to happen).  Tests gave adequate coverage.  I've prototyped ahead the few other places I might like us to use @ and am not concerned about overlaps from a grammar perspective.
Note that the example I added to the end of the documentation is:
list = head:word tail:(_ "," _ @word)* { return [head].concat(tail); }
word = $[a-z]i+
_ = [ \t]*

which shows off how @ can pluck from parens, which is its killer feature, imo.

I think, that feature is ready to merging, clash with the proposed annotations syntax actually not so big and I think is easy solvable (if not by requiring semicolons, then by using, for example @@annotation, or rust-style annotations)

Needs a version bump for a release

Yep, I'm going to do that on #101 since this isn't the only feature.


Fix GitHub 1401, diagnostics relative to workspace folder

This change addresses item #1401
This changes how relative filepath in diagnostics are resolved
The following changes are proposed:

relative diagnostics files are searched in build_dir and src_dir, first existing file is returned
defaults to old behavior : path.resolve(build_dir, file)
resolveDiagnostics has been made async to not slow down IDE when testing files

The purpose of this change
Depending on tools, compiler and CMake invocation, diagnostics paths may be relative, but either to source directory or build directory.
This is a try and guess approach, with a preference for old behavior (returning build_dir/file).
Other Notes/Information

@microsoft-github-policy-service agree company="CERN"

These changes look reasonable to me, but please make a CHANGELOG update and feel free to give yourself credit using examples already present in the changelog. Thanks!

Sure, there you are.
Thanks


Flatpickr not working in production using rails 6 and webpacker. Works in development

I don't know if it's Flatpickr or Webpacker or me. Posted an issue with Webpacker that detail all I know.
A node modules (flatpickr.js) works in development but not in production

Sorry I left this here. It was me!, Didn't read webpacker documentation close enough. had to add a javascript_pack_tag to include the flatpackr css


Microsoft Edge - double empty input generated after each command input

KUI v5.1.12 on Microsoft Edge:

Use Edge
Enter any command; even clear works
Two empty input bars get displayed

I do not see any associated console errors when this happens.  I do not see this issue on Chrome, Firefox, or Safari.

Note, this is without any plugins that extend, modify or override the command input area.  Seems likely it could be different event processing of a user Enter on Edge.


Fixed a potential bug in metrics-event-stream-jaxrs

I had defined currentConcurrentConnections as a static variable in abstract class by mistake which caused it to be shared between implementations which was wrong. Now, I have moved it to the implementation class. This was the reason tests where failing sometimes.

Good catch - sorry I missed it when I reviewed.  Thanks for the PR!


Add UI telemetry

What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6900
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

/override windows-integration-test/Windows-test


Deforestation Plugin

Makes it so that when you cut down a tree it never respawns, either leaving a stump behind or a blank tile. Saves a file to make sure that data is saved between sessions, can be deleted through the config.

The dataset looks like it could get quite large, yes?  Some things to keep in mind:

There is a max size for config entries
We'd prefer large static sets like this be saved to a file on disk instead of in config
You can use serializable properties to decrease the save size

closing as the above comments have not been resolved yet. feel free to resubmit when they are


Move db connections to application/db

Landed in https://github.com/metarhia/Example/commit/f4b7c666556abdeca8b75d2e0f7b3386d3e278bb and https://github.com/metarhia/Example/commit/873079b09ea180dcd299adcfad74830e6c18d3d8


Add warts notation

Currently, the app only gives ticks (ie 17' ) for non-patent maps.
This is lossy and strictly worse than the 'wart' notation (eg 17c).

Fixed as of 02900443f562cda44a8b5bce847a5f8f81cb2053


Free mode auto slides active state bug

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.3.6

Platform/Target and Browser Versions: Chrome (latest) W10

What you did
Example is on here: https://stackblitz.com/edit/swiper-demo-15-free-mode-no-fixed-positions-lp1aqs?file=index.html.
I also tried with fixed .swiper-slide width (1200px in this case) and behavior is same as with width: auto.
Expected Behavior
Idea is that content in each slide has auto width which can be infinite (depends on content), while every slide can have different width. This demo is, however, made with all slides of equal width to simplify it, but still it has those bugs with active state while dragging and an extra bullet.
Actual Behavior
Pagination creates 1 extra bullet which leads to the end of slider. This extra bullet is also set as active on drag when I drag to the very end of slider. Other pagination bullets work ok, but it has bug while dragging slider; it sets active bullets before actual slide is in viewport; for example 2nd bullet becomes active when drag is between blue and green (more to the green side) div of first slide.
Edit: also active state is offset on .swiper-slide divs

Anything?


Legend updates

Description of new feature

Make the legend in the right, bottom corner of the app -- beside the network.
Make the legend have two entries: (1) node colour, (2) edge width
Node colour should have a gradient bar, like this.
Maybe small multiples for the edge width?

Motivation for new feature

Users have trouble finding the legend.
Users don't understand the legend contents.
The current node merging and layout approach makes the network tall and skinny.  This gives room on the sides for the legend, without the legend overlapping the network that often.

TODO @maxkfranz: Log potential enhancements that might be used in future.
Ref: https://github.com/cytoscape/enrichment-map-webapp/pull/91#issuecomment-1491908206

Potential, future improvements logged in:

#94
#95

Re. image export of the legend, this is tracked in:

#78

Closing


Creating edges without creating new vertexes

Hi.
I have created all my vertexes using ETL. These are user vertexes (Which let's call it MyUser).
Now, in a separate ETL operation I would like to create edges between them, just like in a communication network:
A->B (#messages sent as a property of the edge)
I tried this:
{
"source": { "file": { "path": "F:/OrientDB/bin/data/rels.csv" } },
"extractor": { "row": {} },
"transformers": [
{ "csv": {} },
{ "vertex": { "class": "MyUser" } },
{ "edge": { "class": "SENT_MESSAGE",
"joinFieldName": "end",
"lookup": "MyUser.id",
"direction": "out",
"unresolvedLinkAction":"CREATE"
}
}
],
"loader": {
"orientdb": {
"dbURL": "remote:localhost/databases/MyDB",
"dbType": "graph",
"classes": [
{"name": "MyUser", "extends": "V"},
{"name": "SENT_MESSAGE", "extends": "E"}
]
}
}
}
But seems like I have the wrong understanding with that "Vertex" in the beginning. If I don't use that vertex in the transformer it seems like it is also not right, as ETL does not know what nodes to actually use.
Basically:
Nodes
"id","name","label"
1,"Gustavo","Person"
2,"Vikram","Person"
Edges
"start","end"
"2","1"
Then create a simple Gustavo->Vikram relashionship using ETL.
How can I accomplish that?

Take a look at: http://orientdb.com/docs/last/Import-from-CSV-to-a-Graph.html. For questions, please don't open new issues, but rather write to the Community Group where more than 2k users can answer to your question:
https://groups.google.com/forum/#!forum/orient-database


Enable Options class for customization

Currently we're hardcoding values, like the Bluetooth MAC address, which developer should be able to customize.
cc: @hsalameh

I2C addresses too.


Added new API endpoints (logs, evidence)

Description of the change
This PR creates new API endpoints to retrieve log data for Turbinia components in a similar way to the "tail" command.
It also adds a new endpoint to download evidence files based on evidence IDs.
Applicable issues

fixes #1528

Additional information

Checklist

[X] All tests were successful.
[X] Unit tests added.
[X] Documentation updated.


is there a way to lazyload screen component?

I have many screen components defined in AppNavigator. below is code:
import MainScreenNavigator from './MainTab';
import ArticleDetailScreen from '../containers/ArticleDetailScreen';
import ArticleListScreen from '../containers/ArticleListScreen';
import SignInScreen from '../containers/SignInScreen';
...
export const AppNavigator = StackNavigator({
MainTab: { screen: MainScreenNavigator },
ArticleList:{screen: ArticleListScreen , ...
ArticleDetail:{screen: ArticleDetailScreen , ...
SignIn:..
SignOut:...
...
})

it seems the app loaded all screen components  before loads AppNavigator, so the screen is frozen before all components loaded successfully, it's a bad experience to client.how to resolve this problem?

You can put this option 'lazy' in 'TabNavigatorConfig' :)

Thanks, but my screen components is defined in StackNavigator, such as ArticleListScreen, ArticleDetailScreen and so on , it seems that StackNavigatorConfig doesn't have this option.

All screens in the stacknavigator won't be loaded until they're active or in the stack. If that's the case please supply a demo of the issue. Thanks!

@arkhwise - Can you please share an updated link or some documentation regarding getScreen property ? The link shared above is not working


Add a button to open extension in a tab

Add a button that allow users to open the extension in a new tab, getting  the full window UI.


Fixed Issue 'Trailing comma is duplicated when obstructed by comments'

Fixes #3876 .

Sorry I was away from open source in last months. @calebcartwright Can you review again?

Excellent thank you!


Version Information

I moved this from here:
the contributor is asking for aditional information
The comment below was machine translated:
@michel-priori commented 13 hours ago — with docs.microsoft.com
"a new feature of the database engine" says nothing about the versions (vintage) or editions concerned.
Thanks for adding the information

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a825ecf0-9d63-29be-8e8a-aab285a53c7a
Version Independent ID: 4e25d0f7-56b5-3229-89d8-7509264647a5
Content: Accelerated database recovery - Azure SQL Database
Content Source: articles/sql-database/sql-database-accelerated-database-recovery.md
Service: sql-database
Sub-service: high-availability
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

Duplicate of #41450

@CeciAc The document does mention the product the feature is available for.

The Azure SQL does not have editions or versions as was available in on-premise versions.
Hope this helps. We will close this by EOD if no further questions.

We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


fix Travis configuration to actually run the integration tests

Codecov Report

Merging #1571 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1571   +/-   ##
=======================================
  Coverage   87.69%   87.69%
=======================================
  Files          95       95
  Lines        6127     6127
=======================================
  Hits         5373     5373
  Misses        535      535
  Partials      219      219

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257c473...3f3fe2b. Read the comment docs.


Subclass hydrolab cr1000 class to add flexibility with the different configurations available.

Fix issue #11

Oups, bugs on  hanna_file_reader plotting methods:
WARNING *** file size (636117) not 512 + multiple of sector size (512)
WARNING *** OLE2 inconsistency: SSCS size is 0 but SSAT size is non-zero
Traceback (most recent call last):
  File "C:/Users/Laptop/PycharmProjects/scientific_file_reader/file_reader/compagny_file_reader/hanna_file_reader.py", line 105, in <module>
    hanna_file_2.plot()
  File "C:/Users/Laptop/PycharmProjects/scientific_file_reader/file_reader/compagny_file_reader/hanna_file_reader.py", line 70, in plot
    self._add_first_axis(axe, temperature_text)
  File "C:\Users\Laptop\PycharmProjects\scientific_file_reader\file_reader\abstract_file_reader.py", line 241, in _add_first_axis
    main_axis.plot(self.records[line_def.param],
AttributeError: 'str' object has no attribute 'param'

need to refactor all the plot methods of other classes


iter8-in-docker-in-tekton

Signed-off-by: Srinivasan Parthasarathy<EMAIL_ADDRESS>Fixes #721
The Tekton task is modeled after https://github.com/tektoncd/catalog/tree/main/task/kind/0.1

Why not do this work on https://github.com/tektoncd/catalog ?

Yes @kalantar This definitely should end up there eventually. This is an initial attempt to get a sample / use-case working with this feature.


How to predict non-natural amino acids?

The input seems only accept natural amino acids in fasta format. The sequence will be converted to real structures at somewhere. Is there a straightforward way to change some amino acids to non-natural ones?

Sorry, this is not possible with AlphaFold. However, if it is just a small change, then it should be possible with external tools afterwards.


Front end pagination

Implemented Sorting functionality in Queues page and Admin history page. (#81)

Completed and merged to master


Duplicate authorization will throw an Illegal Argument Exception

https://github.com/apache/accumulo-access/blob/2da31d3643916c020b14c9e61fa632543dbc56b7/src/main/java/org/apache/accumulo/access/Authorizations.java#L67
Set.of will throw an IllegalArgumentException as expected, but as a consumer to the API we should avoid the exception and prune duplicates .
Would love thoughts. I think it's reasonable to suggest that the client of the Authorizations API should do this work.
I'll submit a PR for this trivial change if there is any concurrence from @keith-turner  or @dlmarion  that we can de-dupe in the of helper method in Authorization

@phrocker - do you know if Set.copyOf does the same?

The other API objects have good javadoc coverage, I wonder if that's what is missing here.

The other API objects have good javadoc coverage, I wonder if that's what is missing here.

I think that is fair. If I knew this beforehand I would have guarded against it.
Apache Accumulo leverages a hashset which guards against this with the linked code:
private static Set<ByteSequence> createInternalSet(int size) {
    if (size < 1) {
      return EMPTY_AUTH_SET;
    } else {
      return new HashSet<>(size);
    }
  }

  private static List<byte[]> createInternalList(int size) {
    if (size < 1) {
      return EMPTY_AUTH_LIST;
    } else {
      return new ArrayList<>(size);
    }

  }

  /**
   * Constructs an authorization object from a collection of string authorizations that have each
   * already been encoded as UTF-8 bytes. Warning: This method does not verify that each encoded
   * string is valid UTF-8.
   *
   * @param authorizations collection of authorizations, as strings encoded in UTF-8
   * @throws IllegalArgumentException if authorizations is null
   * @see #Authorizations(String...)
   */
  public Authorizations(Collection<byte[]> authorizations) {
    checkArgument(authorizations != null, "authorizations is null");
    this.auths = createInternalSet(authorizations.size());
    this.authsList = createInternalList(authorizations.size());
    for (byte[] auth : authorizations) {
      auths.add(new ArrayByteSequence(auth));
    }
    checkAuths();
  }

Set.copyOf also creates a HashSet from the collection, then calls Set.of. If we put the responsibility on the user to provide a deduplicated array when calling Authorizations of(String... authorizations), then it's likely that they would use a Set and call Authorizations of(Collection<String> authorizations) instead.
I wonder if we should remove the two of implementations and do the following. This would reduce the extra HashSet object allocation if we called Set.copyOf.
  public static Authorizations of(HashSet<String> authorizations) {
    return new Authorizations(Set.of(authorizations.toArray()));
  }

I did not realize Set.of would throw an exception when there are dupes.  We could do the following in the impl
  public static Authorizations of(String... authorizations) {
    return new Authorizations(Set.copyOf(Arrays.asList(authorizations));
  }

Arrays.asList() wraps the array and does not copy it.


UIKit Dynamics

UIKit Dynamics support

Dynamics are hard to config via IB in my opinion. Do you have any idea?

I am thinking adding UIKit Dynamics to some components. For example, dismissing a Popup (VC) or an image via a Swipe gesture, it is like TweetBot app. then we can have an IBInspectable property called swipeToDismiss to support UIKit Dynamics.

Brilliant!


🌱 Release v0.1.0

This is an overarching issue to make sure we track whatever is left to accomplish for releasing CAPN.

/milestone v0.1.x

/assign

@Fei-Guo @charleszheng44 @weiling61 could you all for book keeping put /lgtm on this issue to track that we all agreed to do our first release.

/lgtm

/lgtm

/lgtm

/lgtm

Our official first release! 🎉
https://github.com/kubernetes-sigs/cluster-api-provider-nested/releases/tag/v0.1.0

/close


feat(show2): add a context card

The type of this PR is: Feature

This PR resolves FX-2227
Description
(These screenshots cheat a bit by hiding everything except the Show2Header and the Show2ContextCard. This was in lieu of setting up the whole scrollable sections FlatList stuff, which could be a separate PR)
Mobile

Mobile Partner Show
Mobile Fair Booth

Tablet
There's no specific spec for tablet sizes. But this is how it looks by default 🤷

Tablet Partner Show
Tablet Fair Booth

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

Rebased to get rid of conflicts, and got rid of most of the TODOs. Taking this out of draft mode now...

Nice!


stage1: populate /etc/rkt-resolv.conf from CNI plugins

This implements part of #2044

Open question: What do we do when a DNS configuration is obviously invalid (doesn't contain a nameserver, nameserver not a valid IP address, etc)? Skip it, or fail?

Current project: figure out how to test CNI in the functional test suite.
My plan is to build a wrapper / proxy cni plugin that logs the state of the environment somewhere.

@steveeJ care to review?

Test failure is a flake :-(

Test failure is a flake :-(

It should be solved now (at least this flake :stuck_out_tongue:)

@steveeJ would you mind another review pass on this?

We're going to refactor this a bit and make it part of a larger change to how the --dns flag works.


The data type of the timestamp saved by InfluxDB line protocol API should be TimestampNanosecond

What type of bug is this?
Incorrect result
What subsystems are affected?
Frontend
Minimal reproduce step
In order to preserve the time information of the timestamp, we should use nano seconds as the default precision.
But greptime use milliseconds now.
For example, I save timestamp data with ns precision:
curl 'http://localhost:4000/v1/influxdb/api/v2/write?db=public&precision=ns' \
    -d 'census,location=klamath,scientist=anderson bees=23<PHONE_NUMBER>000000000
census,location=portland,scientist=mullen ants=30<PHONE_NUMBER>000000000
census,location=klamath,scientist=anderson bees=28<PHONE_NUMBER>000000000
census,location=portland,scientist=mullen ants=32<PHONE_NUMBER>000000000'

What did you expect to see?
The data type of the ts column in thecensus table schema should be TimestampNanosecond.
DESC census;

+-----------+----------------------+------+------+---------+---------------+
| Column    | Type                 | Key  | Null | Default | Semantic Type |
+-----------+----------------------+------+------+---------+---------------+
...
| ts        | TimestampNanosecond | PRI  | NO   |         | TIMESTAMP     |
...
+-----------+----------------------+------+------+---------+---------------+

What did you see instead?
TimestampMillisecond is used as the ts type.
+-----------+----------------------+------+------+---------+---------------+
| Column    | Type                 | Key  | Null | Default | Semantic Type |
+-----------+----------------------+------+------+---------+---------------+
...
| ts        | TimestampMillisecond | PRI  | NO   |         | TIMESTAMP     |
...
+-----------+----------------------+------+------+---------+---------------+

What operating system did you use?
Mac
What version of GreptimeDB did you use?
0.7.2
Relevant log output and stack trace
No response

@fengjiachun is this issue resolved by your previous PR? If so, please link the PR here and we can close this issue,

@fengjiachun is this issue resolved by your previous PR? If so, please link the PR here and we can close this issue.

Yes, this issue has been resolved in #3794. I will now close it.


Restore uniqueness of mac-addresses

As per #135 mac addresses (amongst other details) will be available, for proper testing purposes this PR recreates per-userdata unique mac addresses again.
Suggesting to merge this after #135 so we have just the tests to tinker with

TODO: stretches (<network_router might be possible to automate, but multiple <master_controller tags make it hard to run over I guess.

[ ] faulty_stretch
[ ] stretch_v23
[ ] stretch_v27_no_domain
[ ] stretch_v31

As discussed merging this ahead of #135 to improve it's overall quality


SCP-3953: Improve cost inference for verifyEcdsaSecp256k1Signature

... and update the cost model.
As explained here there was some confusion regarding the costing for verifyEcdsaSecp256k1Signature because verification fails rapidly (returning False) for some apparently reasonable signatures. This improves the R code that infers the cost, and also adds some notes documenting the unexpected (or at least non-obvious) behaviour.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

@michaelpj This should probably be included in the backport at #4600.

Has conflicts


Ensure parameter in opeldap::server::globalconf

(This is the same PR than #63, but I closed that because I had to remove my original fork and branch)
Althought documentation shows an example with param ensure in openldap::server::globalconf and openldap_global_conf supports it, the parameter is not actually allowed. This is a fix.

@amateo thanks


[BUG] Fix Meeting Creation Order: New Meetings Appear at the End of the List

Describe the bug
When creating a new meeting, it is incorrectly positioned at the beginning of the list instead of being added to the end.
To Reproduce
Steps to reproduce the behavior:

Book a room
Then go to my event

Expected behavior
When a new meeting is created, it should be added to the end of the list instead of appearing at the beginning.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

@Propo41 Hi, I would like to work on this feature, can you please assign it to me?

@Propo41 Hi, I would like to work on this feature, can you please assign it to me?

Nice finding! Although the events are sorted by the meeting start time, multiple events having the same start and end time should be sorted by their creation date.
Please share how you would approach the problem

I think the proper way to sort it is via their creation date. This approach ensures that when multiple meetings have the same start and end times, the order of the meetings reflects their actual creation sequence. In the future, if a user wants to update the start time of a meeting, having them sorted by creation date makes it easier to manage and avoid confusion. Also helps in organizing meetings effectively.

Yes, i deleted my reply i think we need to sort via start time and if there's having the same start and end time i think we need to sort it via their creation date. I think this good. What do you think?

Yes you are right, i deleted my reply i think we need to sort via start time and if there's having the same start and end time i think we need to sort it via their creation date. I think this is good. What do you think?

Correct. But need to check if the api response contains any such field to track this. Perhaps the updated field?

What about this https://developers.google.com/calendar/api/v3/reference/events#resource? there's a created date.

What about this https://developers.google.com/calendar/api/v3/reference/events#resource? there's a created date.

The one you sent is the response of an event after its creation. We need this api: https://developers.google.com/calendar/api/v3/reference/events/list
The updated field looks promising. But need to confirm if it works.

Ah, I understand now! May I try working on this?

Ah, I understand now! May I try working on this?

Only if you can confirm that we can utilize the updated field sent as a response or something else. You can try out the api using the api playground that google provides


inputs

Edited Index.html for Inputs section and center aligned all the box contents., making it look neat.
Added style section for that in main.css
Updated html definition in 2 files.

@atapas Can you review this PR

@atapas Can you review this PR. It passes all checks and is mergable.


Datamodel Issues

Hi Brian,
I've had some issues using the app when ingesting 100GB+ of PAN events a day and after speaking with other Palo Alto customers it seems I'm not alone.
The first issue is the default acceleration time, however, I noticed it's now been changed from 'all time' to '1w'. That's really good, but also reckon third-party apps like this shouldn't automatically enable datamodel acceleration. It's a bit like having indexes.conf in Splunkbase apps, it's just not cool. :) What are your thoughts on perhaps changing this? The pan_tstats macro should also probably not have 'summariesonly=t'.
The biggest issue however is the size and number of datamodels. In large environments they're huge and they've resulted in heavy indexer load and instability in our environment on more than one occation.
Hope this is helpful feedback mate.
Thanks,
Doksu

Hi Doksu,
Thanks for your comments.  I'll address each one:

Third-party apps like this shouldn't automatically enable datamodel acceleration

Generally, I agree with you.  However, most vendor apps don't have to deal with the sheer volume of data that we have to in each dashboard.  The firewall can generate a dozen logs for each network flow in order to convey the detail and visibility it has into the flow.  So all the dashboards in the App have to use the accelerated summary index created by the datamodel because they would be unusably slow pulling raw logs from the index.  We work very closely with Splunk in the development of our App as they are a strategic partner of ours, and this course was a recommendation from their App development team.  In fact, many of the techniques used in our App come directly from Splunk as recommendations and best practices.
Your feedback here is still important, which is one of the reasons we split the App into an App and Add-on starting with App version 5.0.0.  If you don't need the datamodel and acceleration, then you can install only the Add-on.  If you prefer to have the dashboards that are included in the App, then the App comes with the datamodel and acceleration necessary to make the dashboards work.

The pan_tstats macro should also probably not have 'summariesonly=t'.

You are welcome to remove 'summariesonly=t'.  That's why we put it in a macro, so you can easily enable and disable it globally.  However, you'll notice that if you disable it, your dashboards will take longer to come up because Splunk is pulling from both the accelerated and non-accelerated data.  Slower dashboards did not seem like a good default and tested poorly in customer feedback sessions.  So we left it as a customization you can make yourself.

Size and number of datamodels

Every environment is different, and a datamodel that works great and provides required detail in one environment might be overly verbose in another environment, or run slower in another with higher log volume.  What we've attempted to create in the App is a collection of good defaults.  But you are welcome to tune the datamodel to your needs.  You can change acceleration timeframes, change how dashboard data is pulled, remove extra fields from the datamodel that you don't need, etc.  The datamodel in the latest version of the App has been checked by several teams at Splunk including the datamodel PM's, and is the collection of all the best practices and optimizations we could get.  Even after that, it is still not a one-size-fits-all, but it's the closest we feel we could get.
It sounds like what is really needed is a guide that instructs administrators in all the App customizations that can be made to taylor the App/Add-on to your environment, and the benefits and drawbacks of each customization.  Something like a post-install customization guide.  I've heard this feedback a couple times now, so I'm starting to work on this part of the App's manual.  Let me know in the comments here if this would be helpful, and any feedback I should incorporate while writing this documentation.
Thanks for taking the time to provide feedback!
-Brian

Thanks Brian, I agree on all counts and can appreciate the challenge of making apps the work well in different Splunk environments.
Here's something I've done in our environment that might be useful in the doco (assuming Splunk agrees with my suggestion):
Create a filesystem on the indexers specifically for datamodel acceleration then override the default datamodel volume's path to use that filesystem and apply a volume size restriction so it can never overflow:

[volume:_splunk_summaries]
path = $SPLUNK_HOME/var/lib/splunk/summary
maxVolumeDataSizeMB = 50000

Hope this helps. You'll have to try my app (https://splunkbase.splunk.com/app/2642/) and provide feedback so I can make it better! :)


External variables support (closes #514)

Closes #514
To fix the problem extern variable declaration was added to KLEE wrapper and gtest file.

Seems currenly we get a problem with tests
[  FAILED  ] 36 tests, listed below:
[  FAILED  ] Regression_Test.Incomplete_Array_Type
[  FAILED  ] Regression_Test.Global_Char_Array
[  FAILED  ] Regression_Test.Global_Array_Of_Pointers
[  FAILED  ] Server_Test.Globals
[  FAILED  ] Syntax_Test.Pointer_Return_Test_1
[  FAILED  ] Syntax_Test.Pointer_Return_Test_2
[  FAILED  ] Syntax_Test.Pointer_Return_Test_3
[  FAILED  ] Syntax_Test.Return_Long_Long_Array
[  FAILED  ] Syntax_Test.Structs_With_Arrays_Parameter_Test_1
[  FAILED  ] Syntax_Test.Structs_With_Arrays_Return_Test_1
[  FAILED  ] Syntax_Test.Struct_With_Double_Pointer
[  FAILED  ] Syntax_Test.Return_Const_Char_Pointer_1
[  FAILED  ] Syntax_Test.Return_Const_Char_Pointer_2
[  FAILED  ] Syntax_Test.Return_Const_Struct_Pointer_1
[  FAILED  ] Syntax_Test.Return_Int_Array
[  FAILED  ] Syntax_Test.Return_Void2D
[  FAILED  ] Syntax_Test.Return_Null_Pointer
[  FAILED  ] Syntax_Test.Return_Null_Struct
[  FAILED  ] Syntax_Test.Multi_Array_1
[  FAILED  ] Syntax_Test.Multi_Pointer_1
[  FAILED  ] Syntax_Test.Struct_With_Multi_Array
[  FAILED  ] Syntax_Test.Multi_Pointer_Struct
[  FAILED  ] Syntax_Test.Return_Struct_With_Array
[  FAILED  ] Syntax_Test.Sum_Matrix
[  FAILED  ] Syntax_Test.Count_Dashes
[  FAILED  ] Syntax_Test.Accept_Const_Int_Pointer_Pointer
[  FAILED  ] Syntax_Test.UnnamedTypeUnionField
[  FAILED  ] Syntax_Test.UnnamedTypeStructField
[  FAILED  ] Syntax_Test.AnonymousUnionField
[  FAILED  ] Syntax_Test.AnonymousStructField
[  FAILED  ] Syntax_Test.Pass_Forward_Decl
[  FAILED  ] Syntax_Test.Duplicate_Struct
[  FAILED  ] Syntax_Test.Global_Unnamed_Variable
[  FAILED  ] Syntax_Test.bitfields_check_simple_signed_str
[  FAILED  ] Syntax_Test.bitfields_check_fields_bounds
[  FAILED  ] Syntax_Test.bitfields_check_unnamed


should prompt user for project name at least two letters when create project

In GitLab by @wknet123 on Sep 21, 2017, 17:41

In GitLab by @yhua123 on Nov 8, 2019, 07:37
follow docker tag design

In GitLab by @sokril on Nov 8, 2019, 08:11
closed

In GitLab by @sokril on Nov 8, 2019, 08:11
assigned to @wknet123


Pulsar Functions Leak Database Credentials to Logs

Is your enhancement request related to a problem? Please describe.
When I look at logs of function workers, I can see where database passwords are revealed in plain text.
21:51:55.889 [main] INFO org.apache.pulsar.functions.worker.FunctionAssignmentTailer - Received assignment update: instance {
functionMetaData {
functionDetails {
tenant: "market_data"
namespace: "deribit"
name: "skew_iv_v2"
className: "org.apache.pulsar.functions.api.utils.IdentityFunction"
processingGuarantees: EFFECTIVELY_ONCE
autoAck: true
parallelism: 1
source {
subscriptionType: FAILOVER
typeClassName: "org.apache.pulsar.client.api.schema.GenericRecord"
subscriptionName: "clickhouse-sink"
inputSpecs {
key: "market_data/deribit/skew_iv_v2"
value {
}
}
cleanupSubscription: true
}
sink {
className: "org.apache.pulsar.io.jdbc.ClickHouseJdbcAutoSchemaSink"
configs: "{\"userName\":\"USERNAME\",\"password\":\"PASSWORD\",\"jdbcUrl\":\"jdbc:clickhouse://ADDRESS:PORT/DATABASE\",\"tableName\":\"TABLE_NAME\",\"timeoutMs\":60000.0,\"batchSize\":100000.0}"
typeClassName: "org.apache.pulsar.client.api.schema.GenericRecord"
builtin: "jdbc-clickhouse"
}
resources {
cpu: 1.0
ram:<PHONE_NUMBER>
disk:<PHONE_NUMBER>0
}
componentType: SINK
}
packageLocation {
packagePath: "market_data/deribit/skew_iv_v2/08b8f87d-6db5-4907-a85a-4f1fac9c5d5d-pulsar-io-jdbc-clickhouse-2.6.1.nar"
originalFileName: "pulsar-io-jdbc-clickhouse-2.6.1.nar"
}
version: 7
createTime:<PHONE_NUMBER>790
instanceStates {
key: 0
value: RUNNING
}
functionAuthSpec {
data: "viv6c"
}
}
instanceId: -1
}
workerId: "pulsar-function-0"

This is an example snippet of logs I see. I've replaced some information with placeholders in all-caps, like USERNAME and PASSWORD. Most sensitive information is seen under configs.
Note that this is also the ClickHouse JDBC sink.
Describe the solution you'd like
For database credentials (at least) to not be exposed in the logs, or some option to disable it. I can already restrict access to who can administrate the cluster, but I cannot as easily restrict what logs someone is able to see in our log monitoring solution.

Move this to the next release.

I can help with this issue.


Web UI (/dashboard and /nodes) should display all non-docker files that it logs

Currently, we display statistics about how many docker containers we are streaming logs from. We should allow the user to see how many files that we are logging from directly  the mesos slave as well.

UI support has been postponed


How to see per-version download distribution?

I'd like to be able to see download metrics for each major release of superagent. For example, I'd like to know what percentage of downloads listed on NPM are from superagent 0.x, 1.x, and 2.x.
Is there any way I can find this information?
Thanks!

I don't have that information. I vaguely remember that there was a 3rd party project which allowed you to download and query a massive data dump of npm stats, but I forgot how it was called.

OK thanks for the fast response.


Allow react i18next v14

Checklist

[x] only relevant code is changed (make a diff before you submit the PR)
[x] run tests npm run test
[x] tests are included
[x] commit message and code follows the Developer's Certification of Origin

Fix
Will fix https://github.com/i18next/next-i18next/issues/2248 and add support for react-i18next v14

Thx @adrai :)

included in v15.1.2


NIFI-9057 - Manage GitHub Workflow Runs

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Adjust GitHub workflow to limit builds triggered by pull requests to the latest invocation for each pull request.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

I'm using this document to interpret the meaning of github.head_ref.
https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#github-context


Fatal Exception: android.app.RemoteServiceException

PlaylistCore version: 2.0.0
Device OS version: 5.1
Devide Manufacturer: Huawei
Device Name: X2, P8 Lite
Crash:
Fatal Exception: android.app.RemoteServiceException
Bad notification posted from package com.audio.app: Couldn't expand RemoteViews for: StatusBarNotification(pkg= com.audio.app user=UserHandle{0} id=2131230989 tag=null score=0 key=0|com.audio.app|2131230989|null|10133: Notification(pri=0 contentView= com.audio.app/0x109007f vibrate=null sound=null defaults=0x0 flags=0x72 color=0x00000000 category=transport actions=3 vis=PUBLIC))

Good afternoon! The application crashes when it is launched on some devices. I really hope for help from your side. Thank you for your work.

Does this happen in the Demo app as well?
Is the notification icon a bitmap/mipmap or a vector drawable?
Are any of the notification images null?

unfortunately I can not say, but this happens on some devices, I do not have this (
raster (add image asset - notification icons)
no


Add exception handling for symlink calls with helpful error message.

Currently, provisioning with Vagrant on Windows will fail with an unhelpful OSError exception if you don't have permissions to create symlinks. This small change does two things:

uses os.symlink method in place of run
catches OSError exceptions and prints more helpful error message

(Ideally our provisions script would check for the ability to create symlinks at the very beginning and halt if it isn't available. In the meantime, this will at least provide a more helpful error message.)

Automated message from Dropbox CLA bot
@christi3k, it looks like you've already signed the Dropbox CLA. Thanks!

Awesome, thanks for working on this @christi3k!
This looks great, but we should take the opportunity in our error message to link to a document about this issue that goes into more detail (e.g. that if you're using Zulip in Vagrant-on-windows, you need to run as administrator).
Another thought is whether we should just create a test symlink early in provision.py so that we don't need to worry about regressions where some other tool that runs before building emoji starts using a symlink.

I do think the better solution is to try and create a lest link earlier on in provision.py, perhaps where we test for compatible architecture and operating system and the like.
Do you have a recommendation as to where to create the test link? I got a little lost trying to follow the path designations in provision.py.

One option would be to just create it in var/, e.g. var/zulip-test-symlink -> var/zulip-test-symlink-dest`.  If it succeeds, we can just remove the symlink on the next line and proceed knowing that symlinks are supported.

@christi3k what was the problem with doing the symlink test in Travis CI?

@timabbott I don't know exactly what the problem was other than the symlinks weren't created while running under Travis. You should be able to see run details here: https://travis-ci.org/christi3k/zulip/builds/174363300

Oh, I bet it's because the var directory doesn't exist yet where you put the check.

Ok, I just fixed that and merged this (minus the last commit adding the TRAVIS conditional).  Thanks @christi3k!  I think this will make a big difference in how able Windows users are to get the Zulip development environment working :)


Add atob btoa via new third party install method

shirnkwrap always seems to change more than I expect it to...

Looks good 👍


Use environment variables to override settings (user-agent, timeout, workers)

Following up on the ticket #369

nice one! thank you!


impl-only-use

This RFC gives Rust the syntax:
use foo::FooTrait as _;

Here, _ means that we want to import the FooTrait trait’s impls but
not the trait symbol directly, because we might declare the same symbol
in the module issuing the use.

Rendered

Just as a reference, Haskell as that:
import Foo.Bar.Zoo () -- imports the instances (impls) but not the typeclasses (traits) directly

We'd want this for inherent methods too, not just traits, right?

@burdges inherent methods don't need to be imported to be used.

No need for inherent methods because you never express them in the use position. :)

Neat RFC.
Also related to traits, but perhaps deserving of a separate RFC... How about importing trait methods of the following form as free functions:
trait TheTrait {
    fn notUsingInArgPos2(x: T1, y: T2, ...) -> X<TheTrait>;
}

where X can be something like Result<T, ?>

Hm, isn't conventionally _ used to describe a concrete thing you just don't care about, rather than a template variable?

Yes, and here it’s the same: a concrete thing (a trait) ou don’t care about. :)

Oh please this. I could use this in the prelude crate so I don't have to alias io::Write vs fmt::Write.

This RFC has been merged!
Tracking issue


Option inIncludedFiles is too greedy

Using a plugin config like this doesn't produce the expected results:
"replaceText": {
    "inCodeCommentText": false,
    "inCodeCommentTags": false,
    "inIncludedFiles": true,
    "replacements": [
        {
            "pattern": "A",
            "replace": "B"
        }
    ]
}

Expected
Once would expect that A is replaced by B only in the README and other included markdown files as suggested by the plugin's README.
Actual
With the config above A is replaced everywhere by B even in code comment text and code comment tags.

Requires a change in TypeDoc to be fixed: https://github.com/TypeStrong/typedoc/pull/2284

Fixed in 3.0.0


observedProps pitfall?

I wonder if all props should be observed by default and instead you would have to specify something like staticProps to exclude props from being observed. React's default behavior is to re-render on any prop change so perhaps morearty should do the same.

Nice idea, Gil.


feat: automatically prefetch tags before running changelog generator

It is too easy to produce a changelog with the wrong entries in it because one's local tags are not up to date; for example:
https://github.com/liferay/alloy-editor/pull/1219
This commit makes it harder to do that by running a git remote update before generation. If there is an error (say, because you are not connected to the network; unlikely, I know) or you simply want to run things more quickly, you can pass the --no-update-tags switch.
I also allow --update-tags as a switch, for symmetry, but that's the default anyway.
Test plan:
Run the generator and see this in the output:
Fetching remote tags: run with --no-update-tags to skip

Break the git remote command by changing it to git remote updates and see this instead:
Fetching remote tags: run with --no-update-tags to skip
command: git remote updates
stdout:
stderr: error: Unknown subcommand: updates
usage: git remote [-v | --verbose]
   or: git remote add [-t <branch>] [-m <master>] [-f] [--tags | --no-tags] [--mirror=<fetch|push>] <name> <url>
   or: git remote rename <old> <new>
   or: git remote remove <name>
   or: git remote set-head <name> (-a | --auto | -d | --delete | <branch>)
   or: git remote [-v | --verbose] show [-n] <name>
   or: git remote prune [-n | --dry-run] <name>
   or: git remote [-v | --verbose] update [-p | --prune] [(<group> | <remote>)...]
   or: git remote set-branches [--add] <name> <branch>...
   or: git remote get-url [--push] [--all] <name>
   or: git remote set-url [--push] <name> <newurl> [<oldurl>]
   or: git remote set-url --add <name> <newurl>
   or: git remote set-url --delete <name> <url>

    -v, --verbose         be verbose; must be placed before a subcommand

warning: Failed to update tags: run with --no-update-tags to skip

Note that this is just a warning, not an error, because we allow execution to continue.
Run with --no-update-tags and --update-tags too to confirm that it disables tag fetching (or allows it).

Just started reviewing :)


Make ratelimiter instance thread specific for PulsarActivity

Motivation
Makes the ratelimiter instance thread specific for the Pulsar driver operations.
use case: producing to individual topics where rate should be limited by topic, for example 500 msgs/s per topic across 100 topic partitions. This can be achieved with this type of scenario when threads=100:
bindings:
  partition_num: ThreadNum(); Mod(100); ToString()
params:
  topic_uri: persistent://public/perf/perftest-partition-{partition_num}
  async_api: 'true'
blocks:
  - name: producer
    statements:
      - name: produce
        optype: ec2-msg-proc-send
        async_api: 'true'
        msg_value: "hello world!"

Modifications

cyclerate becomes thread specific when cyclerate_per_thread is set to true
only supported in the Pulsar driver since this is an intermediate solution.

Would it be an issue when thread specific rate limit is not aligned with "global" stride rate?


Refactor Area Controller Unit Tests

Refactored area controller unit tests based on actions (Create, Show, CreateChild, ...)
This fixes https://github.com/fabric8-services/fabric8-wit/issues/1938

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-1

Codecov Report

Merging #1941 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
- Coverage   63.81%   63.75%   -0.06%
==========================================
  Files         144      144
  Lines       13583    13583
==========================================
- Hits         8668     8660       -8
- Misses       4080     4088       +8
  Partials      835      835

Impacted Files
Coverage Δ

remoteworkitem/jira.go
75% <0%> (-25%)
:arrow_down:

remoteworkitem/scheduler.go
53.65% <0%> (-7.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2f410...cf6fcf2. Read the comment docs.

@jarifibrahim  thanks, this looks good but I will recommend refactoring https://github.com/jarifibrahim/fabric8-wit/blob/cf6fcf24aa5323e28103340e1c942fd7692f6ba5/controller/area_blackbox_test.go#L313 with testFixtures as well.

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-2

@pranavgore09 Thanks! I've updated the createSpaceAndArea method.

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-3

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-4

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-5

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-6

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-9

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-10

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-11

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-12

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-15

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-16

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-17

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-18

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-19

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-20

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-21

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-22

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-23

@jarifibrahim snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1941-24


[braft] --triplet=arm64-linux bugs

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

END OF PORT UPDATE CHECKLIST (delete this line) -->

cross compile, target arm64-linux, on x64-linux
vcpkg install braft --triplet=arm64-linux # ok, no problem
cmake -S . -B build -DVCPKG_TARGET_TRIPLET=arm64-linux -DCMAKE_CXX_COMPILER=/usr/bin/aarch64-linux-gnu-g++ -DCMAKE_BUILD_TYPE=Debug -DCMAKE_TOOLCHAIN_FILE=${HOME}/vcpkg/scripts/buildsystems/vcpkg.cmake # ok, no problem
cmake --build build -j # error

output:
/usr/lib/gcc-cross/aarch64-linux-gnu/11/../../../../aarch64-linux-gnu/bin/ld: can't find -lz: no such file or direcotry
/usr/lib/gcc-cross/aarch64-linux-gnu/11/../../../../aarch64-linux-gnu/bin/ld: can't find -lz: no such file or direcotry

By referring to the fix-build.patch in brpc[https://github.com/Microsoft/vcpkg/tree/master/ports/brpc/fix-build.patch], modify the zlib related items and finally successfully

This LGTM once the merge conflicts have been resolved.

Pinging @FredyVia for response, please resolve the conflicts.


use_logger is Compulsory

tl;dr
Expected:
# stop bugsnag from collecting test errors (it's always running locally so we can see the errors anyway)
config :bugsnag, use_logger: false

Actual
** (Mix) Could not start application bugsnag: exited in: Bugsnag.start(:normal, [])
    ** (EXIT) an exception was raised:
        ** (CaseClauseError) no case clause matching: "false"
            (bugsnag) lib/bugsnag.ex:15: Bugsnag.start/2
            (kernel) application_master.erl:273: :application_master.start_it_old/4

So, it doesn't matter if you set it to false, it MUST be true, the process will fail to start otherwise:
https://github.com/jarednorman/bugsnag-elixir/blob/master/lib/bugsnag.ex#L15-L17
My only question, was this intended?
If yes, why bother giving the option in the first place if it's mandatory? Why not give it an actual human-readable error message?
else, can we change it to ignore ?

You're right. That looks like a bug.
I had other questions about that line which blinded me to the more obvious issue. I'll commit a fix in a moment.


GROOVY-8623: Show Groovy version in about help

Show current version of the Groovy in Groovy Object Browser in about->help
Jira: https://issues.apache.org/jira/browse/GROOVY-8623
How it looks like:

Merged, thanks!


Error while exporting the PointPillars network

Hi there,
I met an error while exporting the PointPillars network using Paddlepaddle.
python tools/export.py \     --config configs/pointpillars/pointpillars_xyres16_kitti_car.yml \     --model /path/to/model.pdparams \     --save_dir /path/to/output
And here is the error:

Any suggestions would be helpful.

What's the version of your paddlepaddle? (pip show paddlepaddle-gpu or pip show paddlepaddle)

What's the version of your paddlepaddle? (pip show paddlepaddle-gpu or pip show paddlepaddle)

Hi, it's 2.3.0, same as the version in the tutorial.

This bug is fixed as of paddlepaddle v2.3.1, please follow the steps here to install paddlepaddle>=2.3.1.
We'll correct the version specified in the tutorial.

ok, thx

Another error popped up after upgrading paddlepaddle to 2.3.1.

Thanks for the help~


Support authentication via google oauth 2.0

Tested locally with a project of mine waiting for Gaurav to create a project for us.
Still a no-op because no /api routes are being forced to be authenticated yet.

 Set up a login and auth mechanism.


Add stability note

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.74%. Comparing base (afd94a3) to head (219f1a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   99.74%   99.74%
=======================================
  Files           9        9
  Lines        1931     1931
=======================================
  Hits         1926     1926
  Misses          5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Idea: top-level environment option

KaTeX currently essentially only supports $...$ and $$...$$ for entering math mode.  It doesn't support:

\begin{equation}...\end{equation} (#445, which includes automatic equation numbering #350)
\begin{eqnarray}...\end{eqnarray} (requested once in #1931)
\begin{align}...\end{align} (similar effect to $$\begin{aligned}...\end{aligned}$$, as described in one of our common issues, but the effect is actually very different with equation numbering, so this will be more relevant with #350, and it's even an issue with \tag, see also #2004)
\begin{alignat}{n}...\end{alignat} (but, having an argument, this one isn't addressed by this proposal)
\begin{gather}...\end{gather}
\begin{multline}...\end{multline}
\begin{flalign}...\end{flalign} (#1990, though we have the related option fleqn)

I propose a new render option with a name like mathEnv or topEnv or env or something, or else a redefinition of displayMode to allow values other than false (meaning $...$) and true (meaning $$...$$).  Either way, I'd like to allow values like equation, eqnarray, eqnarray*, align, align*, split, split*, as well as math (equivalent of inline $...$) and displaymath or equation* (equivalent of display $$...$$).  Then we could add a matching option to auto-render's delimiters (or replacing the existing display option) so that \begin\s*{equation}...\end\s*{equation} would end up calling render with the top-level environment set to equation.
This would finally let us support other top-level math environments in what I believe is a natural way.  Assuming you like the idea, I'd appreciate some suggestions on the name for the option, or whether to overload displayMode, or whether to deprecate displayMode (as it's effectively redundant with this option).

@edemaine Good stuff. I wholly agree with what you propose.
As to the details, I think that deprecating displayMode would be too drastic. It would break too many existing documents. And for that reason my inclination would be to overload the existing displayMode option.  When the system is fully built out, displayMode would be settable to:
true | false | equation  | equation* | align | align*  | gather  | gather*  | flalign | flalign*| multline | multline*| alignat | alignat*
That list comes from section 3.1 of the AMS Users Guide. I did not include split because split occurs inside the equation environment.
displayMode would continue to be optional, with a default of false.
When this system is in place, the auto-render extension could be upgraded so that it would trap, for example, \begin{equation} and call KaTeX with displayMode: equation.

Now a question: Should the auto-render extension allow nesting of a top-level environment inside $$…$$?
LaTeX does not allow it. MathJax does, and I suspect that many Markdown environments will depend on it. Because of the Markdown aspect, my initial answer is "yes, we should allow it".

@ronkok Agreed on the list; mine had typos, sorry!
I personally find it weird, and possibly impossible, to support something like $\begin{equation}...\end{equation}$.  But to the extent it's possible, we could try to MathJax behavior, when strict is false or "warn".
This raises the question of how the new option will be implemented.  I had assumed that top-level environments were being treated differently, which is necessary in some sense because it will interact with \tag that is handled with special code at the top level (because of layout).  Will/can they still be processed via defineEnvironment, or are they something new?  I'll have to think about this and/or try implementing it to see.  This will impact the extent to which we can achieve "outer environments inside math mode instead of outside".

Yes, \tag has layout implications at the top level. But I think we'll also want to support things like \notag and \shoveright, so the values of leqno and fleqn will need to be available and locally changeable from inside parseArray() which is currently not the case.
Like you, I have not yet worked out any way to implement this. I think it will involve something like what you did for persistent macros with Namespace. Some sort of data structure that persists between KaTeX fields and gets incremented when the parser hits the appropriate environment. The data structure can no doubt be much simpler than Namespace.

So the issue is that there are a number of environments that can only be entered from text mode but we're already in math from the get go which makes using \begin{align} weird and undefined behavior in LaTeX.
Another approach might be to introduce a new delimiter that only accepts a text environment.  Assuming the new delimiter is && then people could write the following in their HTML and have it work with the auto-render extension: &&\begin{align} ... \end{align}&&.
&& would essentially be limited top-level text mode.  It would also be available via an option to render.

@kevinbarabash That's a neat idea (though a little ugly).  But beyond how to notate entering KaTeX in text mode (that's an auto-render issue), there's no way to enter the main KaTeX engine starting in text mode.  I guess we could add an option to render/renderToString which specifies an initial mode of text or math (defaulting to math)... but I fear that this would be much harder to implement, because parsing LaTeX in text mode is a much taller order than our current support of \text, because that only required supporting TeX horizontal mode.  Whereas \begin{align} ... \end{align} only makes sense in TeX vertical mode, which we are really far away from supporting.
So I think it's best to stick to fixing "how do I specify the top-level math environment".  I guess life would be easier if the argument to render/renderToString already included the wrapping $s or \(...\) or \[...\] -- then the user could just specify a different wrapping environment.  So another way would be to add an option like wrapped that specifies whether the argument has the wrapper.  But the outer wrapping environment really does behave differently from everything else that we support.  Hmm, now I see that this might be exactly what @kevinbarabash meant by "limited top-level text mode".

Related #604.

@edemaine I was thinking that "limited top-level text mode" would essentially be as if we wrapped the entire expression in \text{}.

@kevinbarabash But \begin{align}  etc. don't work within \text, I believe because \text enters horizontal text mode while \begin{align} only works in vertical mode.

I see what you're saying now.


No way to step through Guild_Array/Channel_Array besides forEach

There is no way to step through those Guild_Array/Channel_Array besides using forEach which you can't use in all coding situations.  For example, you can denote them with [i] for i = 1 to 50 or anything like that.

I ended up making a function like this to get around the problem.
function guild_selector(guilds, index) {
	var ID = guilds.toArray()[index].id;
	var guild = guilds.get(ID);
	return guild;
}

It doesn't make sense to go by indexes, when a guild because unavailable.
You should go by id and access them directly over guild.get(id).

This is if you want to going through a guild on the list but do not want to go through them all.  Just the very next one.


Scrape events and display upcoming bills

Scrape hearings, special events, and sessions from the api and store them all in the /events collection. Storing them in one collection, vs separate collections as done in the api, makes it easier to list them all by date. We scrape events every 60 minutes. We only scrape events with start times later than yesterday.
Also add an option to sort the bill list by next hearing date.

On this one, there is a mismatch between the bill's next hearing date and the bill's status, but that is probably because the history is a mock up and not live data.


Images of AVL Tree Rotations not accessible

Well this issue is certainly not accessible either :smile:

emmm...now there's only one image not accessible

It should be fixed now.


Ruby version requirement change in 6.0.0?

Just saw the 6.0.0 release -- nice, thanks!
Curious about this ruby version req change - https://github.com/fnando/browser/commit/e54203b13995b4cc6199b521e430427a95ab4579#diff-53ec28e04e87eace119c08cf1afa508aa03532493a9e256ed8ddcd2fd0c72423R15 - I think ruby 3.0 was recently EOL'd but ruby 3.1 is still supported for another ~year or so ... https://www.ruby-lang.org/en/downloads/branches/
Was there a rubocop requirement or other ruby style thing somewhere in the recent changes that merited bumping all the way up to 3.2 minimum, or could 3.1 have been kept? Would like to bump the browser gem dep, but still have some legacy 3.1 installs to support.
(I originally left this as a comment on a commit, but realized that may not be super visible. Sorry about the effective double posting...)

I also ran into this issue. I'm using Debian stable and they are at Ruby 3.1. Dropping the 3.1 seems a little to soon?

To solve this I added the following monkey patch to my gem (or application
config/initializers/browser_monkey_patches.rb

if Browser::VERSION.to_f < 6.0
  Browser::Base.class_eval do
    def chromium_based?
      false
    end
  end

  Browser::Chrome.class_eval do
    def chromium_based?
      true
    end
  end

  Browser::Edge.class_eval do
    def chromium_based?
      match? && ua.match?(/\bEdg\b/)
    end
  end
end

Closing this on assumption that there was a year mixup (3.1 is EOL in April 2025, but presumably maintainer read that as 2024?)
In ~4 months, this will be retroactively correct.