Extra space at the bottom on ios18

I am observing some weird behavior with this library on ios18.
Having two tabs with LazyVStack causes the list to extra space at the bottom equal to the screen height.
MaterialTabs(
                // A binding to the currently selected tab.
                selectedTab: $selectedTab,
                // A view builder for the header title that takes a `MaterialTabsContext`. This can be anything.
                headerTitle: { context in
                    VStack {
                        Text("Header Title")
                        Text("Header Title2")
                        Text("Header Title3")
                        Text("Header Title4")
                        Color.purple
                            .frame(height: 100)
                    }
                    .padding()
                },
                // A view builder for the tab bar that takes a `MaterialTabsContext`.
                headerTabBar: { context in
                    // Use the `MaterialTabBar` or provide your own implementation.
                    MaterialTabBar(selectedTab: $selectedTab, sizing: .equalWidth, context: context)
                },
                headerBackground: { context in
                    // The background can be anything, but is typically a `Color`, `Gradient` or scalable `Image`.
                    // The background spans the entire header and top safe area.
                    Color.clear
                },
                // The tab contents.
                content: {
                    MaterialTabsScroll(tab: Tab.first) { _ in
                        LazyVStack {
                            Text("FIRST TAB")
                                .padding()
                                .background(Color.blue)
                                .frame(height: 100)

                            ForEach(0..<100, id: \.self) { num in
                                Text("\(num)")
                            }
                        }
                        .scrollTargetLayout()
                    }
                    .materialTabItem(tab: Tab.first, label: .secondary("First"))

                    MaterialTabsScroll(tab: Tab.second) { _ in
                        LazyVStack {
                            Text("SECOND TAB")
                                .padding()
                                .background(Color.red)
                                .frame(height: 100)

                            ForEach(0..<100, id: \.self) { num in
                                Text("\(num)")
                            }
                        }
                        .scrollTargetLayout()
                    }
                    .materialTabItem(tab: Tab.second, label: .secondary("Second"))
                }
            )

https://github.com/user-attachments/assets/2090cdb7-83e0-4254-bb5c-c58559e43be3

The extra space is only supposed to be applied when there's not enough content to fill the screen. I'll take a look.

Hey. Did you have a chance to look into it?

Yesh. A preference key broke on iOS 18 and I had to be more careful in the reduce() function.
If you don't mind, try out the head of master and letting me know if it's working for you.

Thanks, I believe it's working fine now!

2.0.3


Vapor crashes when creating new MPAS renderer

To reproduce:

Spin up vapor and import the MPAS file:
/little_glade/data/Source/MPAS/MPAS-O/hist.mpas-o.0001-01-01_00.00.00.nc
Create a TwoDData renderer and Vapor will crash

Note, this also happens with the files in /little_glade/data/Source/MPAS/MPAS_V4.0

This is stalled pending resolution of #1050


run basic tests for travis confirmation

Run sbt test under travis.

Type of change

[x] Feature request

Impact

[x] no functional change

Development Phase

[x] implementation

@jackkoenig - this now installs Verilator (à la firrtl) and runs all tests.

Consensus: look at it again and merge it or close it if it's not worthwhile

No longer required: we're using CircleCI.


Do not embed tobs VERSION in golang files

What is missing?
Simple way of examining what tobs version is currently checked out. Also clear way to release new version.
Why do we need it?
To simplify release process.
Anything else we need to know?:
Currently version string is embedded in cli/cmd/version/version.go, install-cli.sh as well as in chart/Chart.yaml. By creating a VERSION file in top level directory we can create a single source of truth and verify read that file during building as well as check in CI if correct version is set.

Closing as we are deprecating CLI.


[Bug?] Return type in function may contain more object parameters as expected

Bug Report
🔎 Search Terms
interface/type contain more parameters
Return type of function may contain more object parameters as expected
When a function return object, passed to function type as generic and that object has more params than required should be an error.
🕗 Version & Regression Information
Tested from 3.6. to current version 4.3.5
⏯ Playground Link
Playground link with relevant code
💻 Code
type TFn<S> = (obj: S) => S

interface IState {
    test: number
}

const Func: TFn<IState> = (store) => ({
    ...store,
    thatsOkay: 47,
    shouldBeTypeError: 69 // but its not
})

const obj: IState =  {
    test: 47,
    shouldBeTypeError: 1 // and it is!
}

🙁 Actual behavior
Expected Func to has an error type since 'TFn' doesn't contain 'shouldBeTypeError' parameter
🙂 Expected behavior
Maybe there is a reason for this behavior, but for me, it's not clear why. Object 'obj' has an error, but Func not
Error in
...
shouldBeTypeError: 69
}
...

No bug. You didn't specify a return type for your function, so it's inferred. Then assignability is checked, and additional properties to not prevent an assignment, the types are not incompatible. The excess property checks that occurs for object literals is more of a linter feature. This issue comes up here over and over again.
You can get the behaviour you expect by adding a type annotation for the return type to your function: (store): IState => ({...})

Object types are open and extendible on purpose; they are not closed or "exact" as proposed in #12936.  Presumably you are expecting excess property checking to happen as in #3823 (a great feature but it leads to widespread confusion about how types work in TypeScript).  But excess property checking only happens on object literals being assigned in particular circumstances.  It does not happen with function return values, which means maybe this issue is a duplicate of (checks notes) #241.


All.features execution produces "Uncaught Error: There is already a parameter type with name"

Cypress: 3.7.0
cypress-cucumber-preprocessor: 1.17.0
Cypress mode: UI/Electron
defineParameterType() is working as expected when one single feature file (CustomParameterTypes.feature) is executed (which uses that defineParameterType).

However when the same feature is executed with All.features file below error produced

Note: Below test used the definedParameterType (ordinal/note) example given in Readme.

Today I have moved *.feature and All.features from cypress/integration/Features/ folder to cypress/integration/ and getting following error when running "All.features"
TypeError: Cannot read property 'name' of undefined
at C:\Users\rnandap\Repo\FundMasterApp\ui\node_modules\cypress-cucumber-preprocessor\lib\featuresLoader.js:99:66
at Array.map (:null:null)
at module.exports (C:\Users\rnandap\Repo\FundMasterApp\ui\node_modules\cypress-cucumber-preprocessor\lib\featuresLoader.js:97:6)
at Stream.end (C:\Users\rnandap\Repo\FundMasterApp\ui\node_modules\cypress-cucumber-preprocessor\lib\index.js:21:18)
at _end (C:\Users\rnandap\Repo\FundMasterApp\ui\node_modules\through\index.js:65:9)
at Stream.stream.end (C:\Users\rnandap\Repo\FundMasterApp\ui\node_modules\through\index.js:74:5)
at DestroyableTransform.onend (C:\Users\rnandap\Repo\FundMasterApp\ui\node_modules\readable-stream\lib_stream_readable.js:577:10)
at Object.onceWrapper (events.js:282:20)
at DestroyableTransform.emit (events.js:199:15)
at endReadableNT (C:\Users\rnandap\Repo\FundMasterApp\ui\node_modules\readable-stream\lib_stream_readable.js:1010:12)
at processTicksAndRejections (internal/process/task_queues.js:81:17)

I realize one empty feature file causing 'All.features' or 'Run all specs' (on Cypress UI) to fail with above error. Is this expected behavior?

@pravynandas my understanding is that the .features feature is meant to be used with cypress run only.
The cypress gui is for focus-based development testing
If you want to run all tests why use the gui? Just use run its faster.

@alastair-todd is correct.
But can you, @pravynandas , please confirm that the issue is with:
All.features using gui
but not with
All.features using run?
and not with
running all features using the GUI but not having the .features file?

is there any update for this story? I'm encountering a similar issue!

This happen even when using "cypress run". I tested with "--headless" , and it still happens.
In my case, the problem is that I have two test that import the same common file, in which my custom parameter type is defined.
I believe it may be possible to avoid the issue by replicating "#pragma once" from c++. Basically, put all of your parameter type definition in a if, then use a boolean to enter that if only once.
I haven't tested it, but the boolean should only reset when the test runner is closed.
This workaround doesn't change the fact that some import (that cannot be protected by the if) may still break the test execution.

any update on this, I'm having same problems on cypress open and run

Due to personal reasons, the previous maintainers of this package are stepping down and handing the reigns over to me, a long-time contributor to the project and a user of it myself. This is a responsibility I'm very excited about. Furthermore, I'd like to thank @lgandecki ++ for all the work that they've done so far.
Read more about the transfer of ownership here.
The repository has however moved and all outstanding issues are being closed. This is not a reflection of the perceived importance of your reported issue. However, if after upgrading to the new version, you still find there to be an issue, feel free to open up another ticket or comment below. Please make sure to read CONTRIBUTING.md before doing so.


BUG FIXING & ADDITION

SOMETHING WENT WRONG WITH THE HEADER AND FOOTER I ADDDED IN THE FIRST 3 PAGES NEED TO FIX THAT.
ALSO WANT TO ADD MORE 5-6 DESTINATIONS DEDICATEDD PAGES!

Screenshots (Mandatory)

Please assign me under JWOC 2024

@ratnojitsaha Really good issue. Make "CHECK OUT" button also workful & also make all of the changes you have mentioned

@apu52 It was working well enough after merge it seems messed up.
Should I work on making a complete different nav and footer or (look a like) , and not use the main styles.css sheet.
Please, Tell me what you think!

@apu52 It was working well enough after merge it seems messed up. Should I work on making a complete different nav and footer or (look a like) , and not use the main styles.css sheet. Please, Tell me what you think!

yes you can do that . Just link it with the main file. I will suggest you to make a new issue on it so that it will be considered in the JWOC

ok


[migrant_lib] migration complete

Add a convenience method to migrant_lib::errors::Error to check if it's a MigrationComplete variant.

da8535a526f84fbb9fab31b44d5c3c92d6ceb6e5


Add hamming

i included difference-of-squares in this PR as well, just turned out to be easier and figured the config.json file might conflict if these were separate. happy to break up if that's better.

@jonboiser @kytrinyx wondering if you could take a look at this? Would like to get more exercises into the R track.

Thanks @cmiller01—I'm looking at these today. I've merged difference of squares and will pull this down locally so we just get hamming in this PR.
I think that config.json won't conflict if you put some things earlier in the list (as opposed to at the end). This does affect the order that the exercises are delivered, so sometimes it won't make sense to put things earlier, but if it does make sense that would be a way to avoid the conflicts.

Merged in d4c904de1abec5811227fca0cd97d3438c378d6b

Thanks @kytrinyx, good call on the ordering exercises in config.json. I'll work on getting more of these created. Would love for R not to be an orphaned repo for exercism.

Would love for R not to be an orphaned repo for exercism.

I would love that too! :heart:


Can't track duration below 1:00 hour

Open https://track-your-time.dev.ds4g.net/projects
Type "0:30" in "Hours"
Type "Onbaord new designer" in "What"
Click "Add"
Actual result: See red outline in "Hours" input field

Expected result: See confirmation of accepted input.
Improvement idea: Display error message on outlined input field for the user to help themselves.

One fix would be to put 0.5 but I will add a fix for this case as well :-)


Add CI to check proof stability

Category
Other
Describe the feature you'd like to request
Add CI to check proof stability, similar to what's used in the dafny-reportgenerator CI.
Note that we'll want this CI to be non-blocking since our proofs are currently resource intensive, and will take some time to properly optimize. We just want a warning when a PR makes proofs more expensive, as was the case with #44.
Describe the solution you'd like
N/A
Describe alternatives you've considered
N/A
Additional context
No response
Is this something that you'd be interested in working on?

[X] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

Marking this as done since #61 was merged.


Deployment Issue: failed to verify artifact in SupplyChain Example

failed to verify artifact: computed checksum 'e271f3ebff201e301f705bd5e29c267760a89ee7d92b8c002f554d88800c2c5e' doesn't match advertised '9f1b6ab0f6ae006a6fe153a32c9eca4626cfdad3684bae98bf730ee68a49788e'
To Reproduce
Steps to reproduce the behavior:

Deploy the network (using site.yaml) with five organisation with none proxy (ansible-playbook  platforms/shared/configuration/site.yaml -e<EMAIL_ADDRESS>Maintaining separate repo for bevel and bevel samples
Deploy supplychain app example (ansible-playbook examples/supplychain-app/configuration/deploy-supplychain-app.yaml -e<EMAIL_ADDRESS>Playbook script stuck at "Wait for Pod manufacturer-expressapi in manufacturer-net"
See the error from each and every organisation namespace in events(lens)

Expected behavior
Supplychain example should be up and running at this stage of time
Screenshots

Environment:

OS: macOS
Version: 13.0.1 (22A400)

Additional context
Client Version: v1.26.3
Kustomize Version: v4.5.7
Server Version: v1.23.16-eks-48e63af

@Prajval108 The checksum error is a secondary error, please check other errors for the helmrelease.

Closed as no updates and not an issue


Automatically create releases and add assets

Reference: https://trstringer.com/github-actions-create-release-upload-artifacts/

Done! Ended up going with a different GitHub action because the one the article uses was deprecated.
For every commit or merge to main, we now:

Create a tag with the version number
Create a release with the version number and auto-generate notes

When I release a new "official" (non-minver-generated) version, I tag the main branch, push the tag, and run the build process for the main branch.


Add flexibility to hand menu positioning

Overview
Add two parameters to allow for more fine tuning of hand menu position. Thank you to @tonyambrus for the contribution of algorithms / core code.
ForwardOffset
Moves menu toward or away from user.

SafeZoneAngleOffset
Offset angle offset at which hand menu is placed. Ignored when the placement position to use is "AtopPalm"

Fixes: #8193

/azp run

/azp run

/azp run


Walk the tree

Closes #106
Closes #107
It only diverges from the original proposal in that it adds WalkExpressions and InspectExpressions in plan package because of the limitation of Expressions not being Nodes.

Fixed @ajnavarro


Adopt orphan nodes when parent is destroyed

Ancestry has an interesting feature named "orphean_strategy". Is it possible to replicated their "adopt" strategy when parent node is destroyed ?
:adopt     The orphan subtree is added to the parent of the deleted node.
           If the deleted node is Root, then rootify the orphan subtree.

+1 for "orphanize" strategy on node deletion


[CARBONDATA-2785][ExternalFormat] Optimize table pruning info for pruning by segment

In previous implementation, table pruning is performed once for all
segments. In this case, the pruning info is updated after default/CG/FG
datamap pruning.
Now we want the table pruning to be performed segment by segment, so in
this case, the pruning info will be updated after default/CG/FG datamap
pruning for each segment.
This means that we need to accumulate the pruning info during pruning.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?
Only internal interfaces changed

[x] Any backward compatibility impacted?
NO

[x] Document update required?
NO

[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
NO, only optimize procedure
- How it is tested? Please attach test report.
Tested in local
- Is it a performance related change? Please attach the performance test report.
NO
- Any additional information to help reviewers in testing this change.
NO

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7524/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6278/

retest sdv please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6051/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7641/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6383/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6198/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7825/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6550/


fork choice spec test seems not fully handling future attestation

Description
This issue stems from insufficient future attestation handling in Teku spec test. In Teku, it has an attestation scheduling so the future slot attestations can be deferred until their slot in the past. However, Teku's spec test environment does not fully support future attestations, i.e., it cannot defer attestations more than one slot. Teku assigns one of the two states for incoming future slot attestation. The first state is DEFER_FOR_FORK_CHOICE, indicating that the attestation should be handled in the next slot. The other state is SAVED_FOR_FUTURE, which is used to save attestations that should be handled after several slots in the future. Teku's fork-choice testing environment supports DEFER_FOR_FORK_CHOICE state attestations but not SAVED_FOR_FUTURE state attestations. This results in test cases with attestations attesting the future after the one slot failing in Teku tester. See scenario below.
Steps to Reproduce
Scenario
Assumption: No attestation except Attestation X and Y, or B and C has same vote.
Steps:
 N      N+1     N+2     N+3
[A]  –  [B]  –  [ ]  –  [ ]
     \  [ ]  –  [C]  –  [ ]

Slot N   : Block A
Slot N+1 : Block B (parent: A)
Slot N+2 : Block C (parent also A)
           Receive Attestation_0 from validator X of slot N+4 (attesting block B)
Slot N+4 : Check head

Expect: head is B due to Teku can handle deferred attestation (later ignored)
Result: Teku decide with tie-break rule
Reference: deferredAttestations, futureAttestations

Thanks for raising! We'll have to take a closer look, but the description is very helpful.


Fix for latest flake8

Resolves #76 - store_true + type doesn't make sense

Pull Request Test Coverage Report for Build 260

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.368%

Totals

Change from base Build 259:
0.0%

Covered Lines:
33

Relevant Lines:
34

💛  - Coveralls

Oh, thanks a lot!

I will release it soon.
By the way, @asottile check out https://github.com/wemake-services/wemake-python-styleguide
I hope you will like it!

ooh, they have the same bug -- I can fix it there too :D

You are welcome 👍

ah shoot it's a little trickier to fix there, I'll see what I can do though :thinking:


Spans opened by reactive WebClient .retry() are not nested correctly

Preface
I have two Spring WebFlux apps with configured Sleuth and Jaeger server.
One app has an /error functional endpoint that returns 500 error.
Other has a /test functional endpoint that sends a request to the /error.
I'm using a Spring reactive WebClient to send a http request. With a .retry(...) added to the web client mono chain.
Description
App ONE sends a request to app TWO /error endpoint, gets a 500 error, and makes 3 more retry requests.
The problem is that TWO's spans opened by retry are not nested under corresponding ONE's web-client individual request spans. By the timeline you can see which TWO belongs to which ONE span.

Resources
Code: https://github.com/archie-swif/sleuth-webclient-retry
Run two instances of the application, one with 'one' spring profile, another with 'two'.
ONE's log: https://gist.github.com/archie-swif/2dfbf28c0837830cd75ad68c069079d8
TWO's log: https://gist.github.com/archie-swif/c0103c6e695c01d8c6786a6940335ea5
Trace JSON from Jaeger: https://gist.github.com/archie-swif/d2453c556272371fd5961a4bc243cccb

@adriancole Sure, no problem.
Trace JSON: https://gist.github.com/archie-swif/81ea16a55ae9dccf3f2505257f2beac4
Logs: https://gist.github.com/archie-swif/2e98e07fb667ff391ed36e5b2402a211
That's how it looks in Zipkin. There is only a single TWO span for some reason, for the exact scenario.

In the JSON I see that there are 4 get records for app TWO, with the same Span Id ddc5003cea7888a7
  {
    "traceId": "bbf04ad17fce973c",
    "parentId": "bbf04ad17fce973c",
    "id": "ddc5003cea7888a7",
    "kind": "SERVER",
    "name": "get",
    "timestamp":<PHONE_NUMBER>469143,
    "duration": 3361,
    "localEndpoint": {
      "serviceName": "two",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "error": "500",
      "http.method": "GET",
      "http.path": "/error",
      "http.status_code": "500"
    },
    "shared": true
  },

For the app ONE, there is one get record with the same Span Id ddc5003cea7888a7
And three more get records with unique Span Ids.

Can you try with latest 2.1.0 snapshots?

It works correctly in 2.1.0.BUILD-SNAPSHOT spring-boot-starter-parent. Retry spans have unique ids.
Trace JSON: https://gist.github.com/archie-swif/513bcf9cc97a87938f2491bca0d950c8
Logs: https://gist.github.com/archie-swif/10282e2039c232b9b2889028e06ffd5f

So, 2.1.0 snapshots did not help with for this issue

However I see that IDs in TWO's logs are now unique
Let me take a closer look

With 2.1.0 Snapshot, ID assignment has changed.
Now each WebClient GET call on app ONE opens a span with unique id.
And app TWO code is executed in the span with the same id.
Still, I would expect a new span opened when app TWO code is executed. And this span be nested under app ONE's WebClient GET span. Please correct me if I'm wrong with this. Thank you!

Hey @archie-swif can you check if the latest versions work fine for that matter?

Hi @marcingrzejszczak , thanks for checking up!
I have tried it with Spring Boot 2.3.2.RELEASE, 2.4.0-SNAPSHOT, and latest zipkin image 2.21.5.
Here is how it looks by default:

I see that more spans of the service ONE are present in json, but they are not visible in zipkin UI.
It looks like the issue is in non unique "id" values in span objects. Zipkins takes the one span with an unique id and ignores others with the same id.
If exported trace json is updated so that all ids are unique:
https://github.com/archie-swif/sleuth-webclient-retry/commit/853173bae76492ae74fbbd8aaba4d4cc2741617a
Then it looks this way, no spans are lost:

Thank you!

I've bumped boot to 2.4.0 and Cloud to 2020.0.0-SNAPSHOT and I got the following trace

I guess it looks fine?

In 2.4.0, additional "async" span is being tracked, but ONE's "get" span is still ignored, even if it's present in json. After id fix it looks this way:

Please upgrade to Micrometer Tracing. Spring Cloud Sleuth is feature complete and out of OSS support.


Move all imports to the top-level

Codecov Report

Merging #560 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   87.62%   87.59%   -0.03%
==========================================
  Files           5        5
  Lines         509      508       -1
  Branches       85       85
==========================================
- Hits          446      445       -1
  Misses         50       50
  Partials       13       13

Impacted Files
Coverage Δ

taggit/managers.py
89.38% <100%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e25604...75b51c6. Read the comment docs.


flow controller panic when sending data when available > window

It's possible to panic the stream-level flow controller:
thread 'main' panicked at 'assertion failed: sz <= (self.window_size as WindowSize)', /home/ver/.cargo/git/checkouts/h2-5627e19d2c95dbee/d56531f/src/proto/streams/flow_control.rs:136:8
stack backtrace:

This is because FlowController::available() is used to determine stream capacity, but FlowController::send_data uses FlowController::window_size() as an upper bound. Because available is intended to be greater than window_size at times, this leads to a panic.
Changing prioritize to check window_size() appears to resolve this issue:
--- a/src/proto/streams/prioritize.rs
+++ b/src/proto/streams/prioritize.rs
@@ -450,7 +450,7 @@ impl<B, P> Prioritize<B, P>
                             // window.
                             //
-                            // TODO: Is this the right thing to check?
-                            let stream_capacity = stream.send_flow.available();
+                            let stream_capacity = stream.send_flow.window_size();
                             let sz = frame.payload().remaining();

It's unclear to me how available is to be used on the send-side, if at all.

The fact that available can be greater than window_size makes me very suspicious.

This should be fixed on master.


Duplicate virtual environments in CircleCI

Application
Currently, CircleCI builds and caches a virtual environment for each demo. This is wasteful especially if many of the demos share the same requirements.txt (i.e. they can run in the same virtual environment). As the number of demos increases, this will become a problem.
Proposed Solution
Before building a new environment for a demo, check if it can run in an existing environment.

Will wait for more demos to come in (and see their requirements) before deciding on how to implement a solution to this.


Git decorator colors not consistently appearing

Noticed that the git decorator colors are not consistently showing up in either the explorer or SCM view:

And when I open the file, the decorators finally show up:

Version: 1.70.0-insider (Universal)
Commit: 3da2d669a4dcf93938a262ba92f50b128ca7262a
Date: 2022-07-20T05:16:19.460Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.5.0

same here.
That's the git decorator colors also not showed  in the file as below (the blue decorator ):

Share my situation:
For some reason, it took me to disable the built-in git extension, and then I can't find that extension again.
Solution:
To search built-in extension, you need to add a tag @builtin.
For example:
a. search git, you can't get the built-in git:

b. search @builtin git:

And maybe you also need to setup some configs in "settings.json":
  "git.enabled": true,
  "git.decorations.enabled": true

how to open "settings.json":

F1 or ctr + shift + p ( mac: command + shift + p )
type settings.json

There are probably two issues here:

The error decorators (3) do not show up in Explorer and the Source Control view.  @mjbvz is there a known issue for that?
A file that contains errors is represented differently in the Source Control view. @joaomoreno, is that by design or a bug?

@lszomoru I think @jrieken may own file decorations


Enable use of the libv8 gem

libv8 <IP_ADDRESS>.1beta2 is up for testing, got mini_racer to compile and run tests with the changes below.

wow awesome!!!! Thanks heaps


Error on MacOS M1 (ARM arch)

I see "Marcel" user on binary launch :
Downloads % ./deleter-macos
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x12cd6e5]

goroutine 1 [running]:
main.(*requester).Request(0xc000097140, {0x136402e, 0x100cc67})
	/Users/marcel/pr/facebook-delete/deleter.go:67 +0x65
main.(*fbLogin).IsLoggedIn(0xc0000b0480)
	/Users/marcel/pr/facebook-delete/deleter.go:168 +0x34
main.newFbLogin(0xc000097140)
	/Users/marcel/pr/facebook-delete/deleter.go:113 +0x53
main.main()
	/Users/marcel/pr/facebook-delete/deleter.go:522 +0x289

Downloads % ./deleter-macos-arm64
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x10 pc=0x10485e384]

goroutine 1 [running]:
main.(*requester).Request(0x14000113140, {0x10486fcd0, 0x23})
	/Users/marcel/pr/facebook-delete/deleter.go:67 +0x84
main.(*fbLogin).IsLoggedIn(0x14000140440)
	/Users/marcel/pr/facebook-delete/deleter.go:168 +0x40
main.newFbLogin(0x14000113140)
	/Users/marcel/pr/facebook-delete/deleter.go:113 +0x60
main.main()
	/Users/marcel/pr/facebook-delete/deleter.go:522 +0x32c

It looks like the HTTP requests fail. Do you have something installed that blocks internet traffic for some applications?

Hum yes i have Pi-Hole to have a fake-dns, but i can whitelist domain/wildcard.

Does it work when you visit https://mbasic.facebook.com/ in a browser?

Does it work when you visit https://mbasic.facebook.com/ in a browser?

Nop, GAFA tracking is all blocked ahah ! Why need this ?

Fixed ! Amazing, thank you so much !! Have a nice day


Postee customized integration with SMTP Relay Service

We would require below feature enhancement for Postee
-->Integration with custom smtp replay service by providing hostname and port number
-->no user authentication.

hi @sandip4aqua - this already exists today https://github.com/aquasecurity/postee/blob/main/cfg.yaml#L74-L89

Please reopen if issue is still unresolved. Thanks.

The Customer is looking to have the user/pass not a requirement for their email smtp integration.
Since we don’t provide user and password, the connection parameters from Postee would only be the following:
•	SMTP server: hostname or IP address
•	Port number: currently it is using the default 25
On Aqua side there is an internal process that we have to follow with the Messaging Team; they have to set us up to use the SMTP service in their end:
•	They need to register our application node information as connection originator
o	With this I am only allowed to send messages from a specific application node
•	They have to setup an account for the Postee “sender” parameter:
o	For example the value of the sender parameter in this case would be<EMAIL_ADDRESS>


Add demo for ConstraintLayout feature Margins

Margins

Fig. 3 - Relative Positioning Margins
If side margins are set, they will be applied to the corresponding constraints (if they exist) (Fig. 3), enforcing the margin as a space between the target and the source side. The usual layout margin attributes can be used to this effect:
android:layout_marginStart
android:layout_marginEnd
android:layout_marginLeft
android:layout_marginTop
android:layout_marginRight
android:layout_marginBottom
Note that a margin can only be positive or equals to zero, and takes a Dimension.
Margins when connected to a GONE widget
When a position constraint target's visibility is View.GONE, you can also indicate a different margin value to be used using the following attributes:
layout_goneMarginStart
layout_goneMarginEnd
layout_goneMarginLeft
layout_goneMarginTop
layout_goneMarginRight
layout_goneMarginBottom

I think this is a very basic feature, no longer required.


Fix spelling in README.md

PR Details

Description
Fixed some spelling mistakes.
Related Issue
https://github.com/HUSKI3/FireOS/issues/10
Motivation and Context
Fixes spelling.
How Has This Been Tested
Ran through spell checker.
Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

Thank you!


https://www.youtube.com/*CHANNEL NAME**/live does not work

I can see you have attempted a fix and can see that what you have changed but i think you misunderstood the issue.
Its when the URL is in this format:
https://www.youtube.com/*CHANNEL NAME**/live
EG: https://www.youtube.com/sameoldarsenal/live
You appear to have fixed it when the format is:
https://www.youtube.com/watch?v=hRVvwTEQHhk/live
NOTE - these examples will only work if that channel is live when you are testing.
You need to find a channel which is currently live -> go to channel homepage and add /live to the URL and then test

I'm not misunderstanding this issue.
This is a bug due to YouTube's URL pattern being different depending on the user account.
@username/live
username/live
And there seems to be a pattern that redirects these to each other.

Fixed by next ver. Now under review in store.


Support Telegram Bot API 4.7

Added the method sendDice for sending a dice message
Added the field dice to the Message object
Added the field emoji to the Dice object.
Added the method getMyCommands for getting the current list of the bot's commands.
Added the method setMyCommands for changing the list of the bot's commands.
Added the ability to create animated sticker sets.
Added the ability to add animated stickers to sets.
Added the field thumb to the StickerSet object.
Added the ability to change thumbnails of sticker sets.

This is awesome, thanks for your contribution!


Change Category UI

Current:

The box could probably show a few examples, maybe have a different color (shade), and the "layered" part behind it could be enlarged:

I just feel it's hard to distinguish a category (and what a category offers) from other features.
It also could have a different icon (https://github.com/openstreetmap/id-tagging-schema/issues/41 ).

#6085 is about differentiating the category icons. I think that along with the disclosure caret, the ellipsis, and the layered effect would make these pretty clear.
I'm not sure whether or not listing the contents would be worth the visual noise, but we can consider it.


VSCode - recognising language in code blocks

I'm a new user, so please pardon any gross ignorance!
Without the { after the ``` VSCode will respect the language asserted to be in the code block. This seems to be a behaviour of the built-in Markdown parsing. I couldn't find any sign of an option in VSCode's settings to change the trigger for attributes on a fence delimiter.
So ``` js has a much richer experience than  ``` { .js ....
Any advice or comment?

There was a discussion thread in the Mkdocs project on a similar theme - https://github.com/mkdocs/mkdocs/discussions/3521

I also found https://github.com/microsoft/vscode/issues/157793 and https://github.com/microsoft/vscode/pull/157947 which I kinda hoped would show signs of improvement.

Sorry for not replying sooner. Entangled also supports a different syntax, using Quarto style comments at the top of your code blocks.
```js
//| id: #hello-world
...
```

or

```js
//| file: main.js

<<hello-world>>
...

This needs some settings in entangled.toml though:
#| file: entangled.toml
version="2.0"
watch_list=["*.md", "docs/**/*.md"]   # or whereever your files are
hooks=["quarto_attributes"]

[markers]
open="^(?P<indent>\\s*)```(?P<properties>.*)$"
close="^(?P<indent>\\s*)```\\s*$"

Thanks for that.
I found values for //| id: ref shouldn't have the leading #.
Also, is there any interaction between this scheme and adding custom language types?
My entangled.toml is now:
# required: the minimum version of Entangled
version = "2.0"
hooks=["quarto_attributes"]

[markers]
open="^(?P<indent>\\s*)```(?P<properties>.*)$"
close="^(?P<indent>\\s*)```\\s*$"

[[languages]]
name = "plx"
identifiers = ["plx"]
comment = { open = "! " }

but a fragment beginning with:
```plx
//| file: text.plx

```

asserts 'nothing to do'.

Yes! I would say comment = {open = "!"} without the space. Then you can do
```plx
!| file: test.plx
...
```

Thanks for your help.


Diagonal augmentation for weighted graphs

Reference Issues/PRs
Fixes #261
What does this implement/fix? Explain your changes.
Weighted graph functionality for augment_diagonal by adding up nonzero entries and dividing by (nverts-1). Also contains test.
Any other comments?

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   87.51%   87.51%
=======================================
  Files          33       33
  Lines        1954     1954
=======================================
  Hits         1710     1710
  Misses        244      244

Impacted Files
Coverage Δ

graspy/utils/utils.py
91.17% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844af99...f23ebb0. Read the comment docs.

Goal is to consider a weighted network, not to multiply the diagonal by a scalar

@jheiko1 PR looks good besides the docstring, could you just update the documentation to say something about how this considers sum of edge weight rather than degree (and could add that this is equivalent to degree for a weighted network if you want). Other than that looks good!


Update EKS cluster creation page for Rancher v2.5

This PR addresses the feedback from this other PR that I accidentally merged https://github.com/rancher/docs/pull/2661
It partly addresses this issue https://github.com/rancher/docs/issues/2639

I'm going to merge this PR for now because Ricky is going to make a PR and I want it to be based on these changes. I will make sure Bill's feedback gets addressed in another PR.


Add flaggen.exe running under WinME

Flaggen.exe running under Windows Mistake Edition. The wrong OS but definitely the right flag

Thanks, the last of the 9x family should def. have a photo of running progress pride.


ignore invalid instruction of rune commit tx

fix https://github.com/ordinals/ord/issues/3306

We get transactions from bitcoin core, so I don't think it's possible to encounter a transaction with an invalid instruction. Have you found a case where it is possible?


[SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

What changes were proposed in this pull request?

Support JDBC/ODBC tab for HistoryServer WebUI. Currently from Historyserver we can't access the JDBC/ODBC tab for thrift server applications. In this PR, I am doing 2 main changes

Refactor existing thrift server listener to support kvstore
Add history server plugin for thrift server listener and tab.

Why are the changes needed?
Users can access Thriftserver tab from History server for both running and finished applications,
Does this PR introduce any user-facing change?
Support for JDBC/ODBC tab  for the WEBUI from History server
How was this patch tested?
Add UT and Manual tests

Start Thriftserver and Historyserver

sbin/stop-thriftserver.sh
sbin/stop-historyserver.sh
sbin/start-thriftserver.sh
sbin/start-historyserver.sh

Launch beeline
bin/beeline -u jdbc:hive2://localhost:10000

Run queries

Go to the JDBC/ODBC page of the WebUI from History server

Test build #113164 has started for PR 26378 at commit f4a16a5.

Test build #113164 has finished for PR 26378 at commit f4a16a5.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113164/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18077/
Test PASSed.

Test build #113165 has started for PR 26378 at commit bff90de.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18078/
Test PASSed.

Test build #113165 has finished for PR 26378 at commit bff90de.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113165/
Test FAILed.

Test build #113166 has started for PR 26378 at commit dfd1ff6.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18079/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18083/
Test PASSed.

Test build #113170 has started for PR 26378 at commit 5490c8e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18084/
Test PASSed.

Test build #113170 has finished for PR 26378 at commit 5490c8e.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113170/
Test FAILed.

Test build #113166 has finished for PR 26378 at commit dfd1ff6.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113166/
Test FAILed.

Test build #113171 has started for PR 26378 at commit 24dde37.

Test build #113171 has finished for PR 26378 at commit 24dde37.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveThriftServer2HistoryServerPlugin extends AppHistoryServerPlugin
class HiveThriftServer2AppStatusStore(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113171/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18085/
Test PASSed.

retest this please

Test build #113172 has started for PR 26378 at commit 905e635.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18086/
Test PASSed.

Test build #113172 has finished for PR 26378 at commit 905e635.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveThriftServer2HistoryServerPlugin extends AppHistoryServerPlugin
class HiveThriftServer2AppStatusStore(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113172/
Test FAILed.

Test build #113173 has started for PR 26378 at commit 4eab137.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18087/
Test PASSed.

Test build #113173 has finished for PR 26378 at commit 4eab137.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveThriftServer2HistoryServerPlugin extends AppHistoryServerPlugin
class HiveThriftServer2AppStatusStore(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113173/
Test FAILed.

retest this please

Test build #113204 has started for PR 26378 at commit 4eab137.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18115/
Test PASSed.

Test build #113204 has finished for PR 26378 at commit 4eab137.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveThriftServer2HistoryServerPlugin extends AppHistoryServerPlugin
class HiveThriftServer2AppStatusStore(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113204/
Test FAILed.

retest this please

Retest this please

Test build #113216 has started for PR 26378 at commit 4eab137.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18127/
Test PASSed.

Test build #113217 has started for PR 26378 at commit 540faf0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18129/
Test PASSed.

Test build #113216 has finished for PR 26378 at commit 4eab137.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveThriftServer2HistoryServerPlugin extends AppHistoryServerPlugin
class HiveThriftServer2AppStatusStore(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113216/
Test FAILed.

Test build #113217 has finished for PR 26378 at commit 540faf0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveThriftServer2HistoryServerPlugin extends AppHistoryServerPlugin
class HiveThriftServer2AppStatusStore(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113217/
Test FAILed.

retest this please

Test build #113224 has started for PR 26378 at commit e965c5f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18135/
Test PASSed.

Test build #113225 has started for PR 26378 at commit e965c5f.

Test build #113224 has finished for PR 26378 at commit e965c5f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveThriftServer2HistoryServerPlugin extends AppHistoryServerPlugin
class HiveThriftServer2AppStatusStore(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113224/
Test FAILed.

Not sure which test is failing. seems all  UTs are passing as per the Jenkins report.

Test build #113225 has finished for PR 26378 at commit e965c5f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveThriftServer2HistoryServerPlugin extends AppHistoryServerPlugin
class HiveThriftServer2AppStatusStore(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113225/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18192/
Test PASSed.

Test build #113284 has started for PR 26378 at commit 5c2932e.

Test build #113284 has finished for PR 26378 at commit 5c2932e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113284/
Test FAILed.

Test build #113287 has started for PR 26378 at commit a93ca4e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18195/
Test PASSed.

Test build #113287 has finished for PR 26378 at commit a93ca4e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113287/
Test PASSed.

Are you saying that JDBC tag only supports live web UI not history server? I thought we've completely refactored the UI stuff to use kv store, not sure how JDBC tag works now.
cc @gengliangwang

Thanks @cloud-fan for the comment. Yes, currently we can't access the JDBC tab from History server.  We can access the JDBC tab from Live UI only.
History server WebUI
Before the PR:  (No JDBC/ODBC tab)

After PR:

You did something I wanted to do before， a big deal.
For me , I prefer not change Operation classes, post event in ThriftServerListener
cc @wangyum @juliuszsompolski

:+1: to @AngersZhuuuu suggestion. To avoid changes in the operation classes, you could call keep calling the onFooBar functions directly there, and then if (live) { postLiveListenerBus(createEvent) } from there.

Actually, let's think a bit more about it.
Normal listeners work by getting events from the live listener bus, not be called directly. So maybe it's better to make it behave the same way and also post events?
The only argument against it is that the listener bus can drop events if it becomes to busy, but the same argument applies for other Spark UI events. Making it be fully events driven, like in this PR, makes it consistent with all other SparkListeners.
WDYT @shahidki31 @AngersZhuuuu @wangyum @gengliangwang ?

Actually, let's think a bit more about it.
Normal listeners work by getting events from the live listener bus, not be called directly. So maybe it's better to make it behave the same way and also post events?
The only argument against it is that the listener bus can drop events if it becomes to busy, but the same argument applies for other Spark UI events. Making it be fully events driven, like in this PR, makes it consistent with all other SparkListeners.

Thanks @juliuszsompolski for the comment. Yes, I followed similar to the other existing listeners here. Only difference is that, posting the events to the listener bus from the listener itself, using the SparkContext that passed from the HiveThriftServer2.  Also, the frequency of Thriftserver events is relatively very low compared to the TaskEvents or JobEvents. But, without that the events we can't populate the UI from HistoryServer.

Thanks @juliuszsompolski for the comment. Yes, I followed similar to the other existing listeners here. Only difference is that, posting the events to the listener bus from the listener itself, using the SparkContext that passed from the HiveThriftServer2. Also, the frequency of Thriftserver events is relatively very low compared to the TaskEvents or JobEvents. But, without that the events we can't populate the UI from HistoryServer.

Agree to this, to be honest, we don't want to lose event related to UI, especial some event about progress， status. Always when event is too busy,  server's status is bad, and we need to check job's status to help us find out problem. losing these important events is really bad.

I think, Event dropping is not specific this listener. if at all happens, then it will impact other UI too, like Job, Task or Stages. Easy fix is make a seperate ThriftServerListener for HistoryServer, and keep the live Listener as it is. But, I think the existing design is more consistent compared to the other listeners.  May be I can update according to the comment https://github.com/apache/spark/pull/26378#discussion_r343029168 ?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18223/
Test PASSed.

Test build #113318 has started for PR 26378 at commit 207de3a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18224/
Test PASSed.

Test build #113318 has finished for PR 26378 at commit 207de3a.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113318/
Test FAILed.

retest this please

Test build #113319 has started for PR 26378 at commit 207de3a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18225/
Test PASSed.

Test build #113319 has finished for PR 26378 at commit 207de3a.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113319/
Test FAILed.

retest this please

Test build #113320 has started for PR 26378 at commit 7046ea2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18226/
Test PASSed.

Test build #113320 has finished for PR 26378 at commit 7046ea2.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113320/
Test FAILed.

Retest this please

Test build #113326 has started for PR 26378 at commit c18ba07.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18231/
Test PASSed.

Test build #113326 has finished for PR 26378 at commit c18ba07.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113326/
Test FAILed.

Test build #113327 has started for PR 26378 at commit 0a261d1.

Test build #113329 has started for PR 26378 at commit e6bca76.

Merged build finished. Test PASSed.

Test build #113329 has finished for PR 26378 at commit e6bca76.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113329/
Test FAILed.

Test build #113331 has started for PR 26378 at commit c608ad0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18233/
Test PASSed.

Test build #113327 has finished for PR 26378 at commit 0a261d1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113327/
Test FAILed.

Unrelated failure. Retest this please

Test build #113338 has started for PR 26378 at commit c608ad0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18239/
Test PASSed.

Test build #113331 has finished for PR 26378 at commit c608ad0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113331/
Test PASSed.

Test build #113338 has finished for PR 26378 at commit c608ad0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113338/
Test PASSed.

ping @juliuszsompolski @vanzin

cc @cloud-fan @gengliangwang

I have also tested the following scenarios with UT

Cleanup session and  statements if exceeds the threshold, for both live and history events.
If out-of-order event come, then store should update correctly.

Test build #113585 has started for PR 26378 at commit 97a7548.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18471/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18472/
Test PASSed.

Test build #113586 has started for PR 26378 at commit a87c851.

Test build #113586 has finished for PR 26378 at commit a87c851.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113586/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18476/
Test PASSed.

Test build #113589 has started for PR 26378 at commit da2ae4c.

Test build #113589 has finished for PR 26378 at commit da2ae4c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113589/
Test FAILed.

Test build #113585 has finished for PR 26378 at commit 97a7548.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113585/
Test PASSed.

cc @squito @vanzin Seems most of the changes are from listener/history server side. could you please review the PR. I have tested with both live and history UI and both are working fine. Thanks

That's a big change ... I don't know enough to review it.

Thanks @srowen . I think HiveThriftServer2Listener class is mostly refactoring the exisiting code. HiveThriftServer2HistoryServerPlugin and HiveThriftServer2AppStatusStore are newly added. rest are minor changes.

I would like to review it, but likely only will have time for it next week.

I would like to review it, but likely only will have time for it next week.

Sure. Thanks @juliuszsompolski

Thanks @juliuszsompolski for the review. I will update the PR

Test build #114322 has started for PR 26378 at commit c3df928.

Test build #114322 has finished for PR 26378 at commit c3df928.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114322/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19161/
Test PASSed.

Test build #114324 has started for PR 26378 at commit c277183.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19163/
Test PASSed.

Test build #114324 has finished for PR 26378 at commit c277183.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114324/
Test PASSed.

Test build #114357 has started for PR 26378 at commit 9287118.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19196/
Test PASSed.

Test build #114357 has finished for PR 26378 at commit 9287118.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114357/
Test PASSed.

Test build #114420 has started for PR 26378 at commit 4ab4e92.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19257/
Test PASSed.

Test build #114420 has finished for PR 26378 at commit 4ab4e92.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114420/
Test FAILed.

Test build #114421 has started for PR 26378 at commit 607dded.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19258/
Test PASSed.

Test build #114421 has finished for PR 26378 at commit 607dded.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114421/
Test PASSed.

Test build #114489 has started for PR 26378 at commit ff7267c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19322/
Test PASSed.

LGTM on the rest, but would be helpful if another set of eyes could look on the store updating logic, because I don't fully know how the flushing, making sure that updates are synced etc. works.

Thanks @juliuszsompolski . I have slightly refactored the store update logic
Ideally in all the listeners, the store logic goes like this,
LiveUI: update the store whenever an event comes. To prevent frequent updates, if there are frequent events like tasks event, there is a threshold liveUpdatePeriod, so that after the threshold + last written time we update the store.
HistoryUI: Keep all the events data in a hash map and update the store, after the last event occurs,(or during flush). But here, I am also updating when the session closed event, and execution closed event, so that we can remove the map entries.

Test build #114490 has started for PR 26378 at commit eaea6e3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19323/
Test PASSed.

Test build #114492 has started for PR 26378 at commit a55927e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19325/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19326/
Test PASSed.

Test build #114489 has finished for PR 26378 at commit ff7267c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114489/
Test PASSed.

Test build #114494 has started for PR 26378 at commit 69ab021.

Test build #114494 has finished for PR 26378 at commit 69ab021.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114494/
Test FAILed.

Test build #114490 has finished for PR 26378 at commit eaea6e3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #114495 has started for PR 26378 at commit af65eed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114490/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19328/
Test PASSed.

Test build #114497 has started for PR 26378 at commit db4269c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19330/
Test PASSed.

Test build #114497 has finished for PR 26378 at commit db4269c.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114497/
Test FAILed.

Test build #114492 has finished for PR 26378 at commit a55927e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114492/
Test PASSed.

Test build #114495 has finished for PR 26378 at commit af65eed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114495/
Test PASSed.

Test build #114538 has started for PR 26378 at commit f7fcc75.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19367/
Test PASSed.

Test build #114538 has finished for PR 26378 at commit f7fcc75.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114538/
Test PASSed.

@shahidki31 one more comment, I have a good idea about fixing the UI tab order.
We can add a new API displayOrder in the trait AppHistoryServerPlugin(with default value as Int.MaxValue).
And then we can set the displayOrder of SQL tab as 0, and the thriftserver tab as 1
I will merge this one once this is updated.

@shahidki31 one more comment, I have a good idea about fixing the UI tab order.
We can add a new API displayOrder in the trait AppHistoryServerPlugin(with default value as Int.MaxValue).
And then we can set the displayOrder of SQL tab as 0, and the thriftserver tab as 1

Yeah, that is a nice idea. Thanks @gengliangwang . I will update the code


Created unit tests for organizationSuggestionTasks API, Fixed Ballot unit tests errors, Some variable name changes in organizationSuggestionTasks API

This looks great Anisha. 👍


Please update Assembly and Nuget versions.

https://github.com/samuelneff/MimeTypeMap/blob/ffbb2d45e3ef66b34a6596779218bba99b0d0f0f/src/MimeTypes/MimeTypes.csproj#L15

@zbarrier see https://www.nuget.org/packages/MediaTypeMap.Core

The nuget version and assembly version differ.  The .csproj has older version.  When using this in a asp.net project, it throws an exception looking for the version referenced in the .csproj.

I didn't create or manage the nuget package.


chore: bump node version from 16 to 18

https://github.com/cdklabs/cdklabs-projen-project-types/pull/350 made 18 the default, so use the new default.

Closing in favor of #1275 since this has conflicts I don't wanna deal with


fix: throw when useFiber is used without a FiberProvider

I spent some time debugging why my app (which uses useContextBridge) wasn't working in production, the reason was I didn't have a FiberProvider. This might be a breaking change so I can of course change it, but would it be possible to add some kind of error or warning when there's no FiberContext? Is there any reason it should not throw?

I removed this during the Codesandbox outage where package.exports wasn't resolved correctly and this error kept confusing people as React was merely mismatched. We can safely add it back, sorry to see that it was needed in the intervening time.

All good, I aligned it with previous changes w/tests.


The getLastEvaluatedKey object returned by the secondary index query is incorrect

Hi mhart,
I have a problem,when the query according to the secondary index in the getLastEvaluatedKey only return to the global hashkey,then use this getLastEvaluatedKey object once again to get an error.
In fact AWS DynamoDB will return to global hashkey and the secondary index attribute key-value and so on.

@qumingxing I'm sorry, I don't understand what you mean.
Can you show me some code to illustrate?

Hi mhart,
Thanks for your answer,I have found the cause of the problem.
Sorry I'm mistake.

Hi mhart,
Thanks for your answer.Here is a code example:
BasicAWSCredentials awsCredentials = new BasicAWSCredentials("test", "test");
        Map<String, AttributeValue> lastKeyEvaluated = null;
        AmazonDynamoDBClient dynamoDBClient = new AmazonDynamoDBClient(awsCredentials).withEndpoint("http://<IP_ADDRESS>:8081");
        DynamoDBMapper mapper = new DynamoDBMapper(dynamoDBClient);
        Map<String, String> attributeNamesMap = new HashMap<>();
        attributeNamesMap.put("#hashkey", "user_id_group");
        attributeNamesMap.put("#rangekey", "deleted_created_at");
        attributeNamesMap.put("#hashkey", "user_id_group");
        Map<String, AttributeValue> attributeValuesMap = new HashMap<>();
        attributeValuesMap.put(":st_val", new AttributeValue("0_0"));
        attributeValuesMap.put(":ed_val", new AttributeValue("0_3484012576557"));
        attributeValuesMap.put(":hk_val", new AttributeValue("123456_SEARCH"));
        DynamoDBQueryExpression<ChemicalHistory> queryExpression = new DynamoDBQueryExpression<>();
        queryExpression
                .withExpressionAttributeNames(attributeNamesMap)
                .withExpressionAttributeValues(attributeValuesMap)
                .withConsistentRead(false)
                .withScanIndexForward(false)
                .withKeyConditionExpression("#hashkey = :hk_val AND #rangekey between :st_val AND :ed_val")
                .withProjectionExpression("history_id,created_at,history_params,history_type,history_source");
        queryExpression.setIndexName("user_id_group-deleted_created_at");
        queryExpression.setLimit(5);
        do {
            QueryResultPage<ChemicalHistory> results = mapper.queryPage(ChemicalHistory.class, queryExpression.withExclusiveStartKey(lastKeyEvaluated));
            lastKeyEvaluated = results.getLastEvaluatedKey();
        } while (null != lastKeyEvaluated);

This code works fine in DynamoDB Local.
But in dynalite throw exception "com.amazonaws.AmazonServiceException: The provided starting key is invalid" when second for loop execution,and if remove "withProjectionExpression("history_id,created_at,history_params,history_type,history_source")" is ok,I don't  know what the cause is.

@qumingxing great – can you also show me the configuration for the table? what does the user_id_group-deleted_created_at index look like?

@mhart
This is my table structure:

AttributeName
KeyType

history_id
HASH

Index Name
Index Type
Hash Key
Range Key

user_id-deleted_created_at
Global
user_id
deleted_created_at

user_id_type-deleted_created_at
Global
user_id_type
deleted_created_at

user_id_group-deleted_created_at
Global
user_id_group
deleted_created_at

@qumingxing great, ok thanks – I'll look into this and see what I can find 👍

I believe this can be resolved by modifying db/index.js
The code which filters out results based on attributes set (around lines 853-857) can be moved to after line 861.
This seems to work for me - just wondered if there were any side affects.


Bad Credentials due to username?

The problem
I have Home Assistant running with HACS and implemented the WebUntis Integration.
Running without problems the last couple of month with two School-Accounts.
Now I installed an update of WebUntis from v0.4.x (don't know the exact version) to 0.6.1 and I am no longer able
to receive data for one of the accounts. Both accounts are registered to the same school. Both accounts are able
to login via web. But every time I try to add the second account to the HA WebUntis integration it tells me:
'Bad credentials' and 'Code: -8504'
The only difference I can find between the two accounts is the username (and password, of course).
While the account that is able to login via HA is written like: 'lisamueller'
the other account has a space in its name: 'max mueller'
I already tried to enter the username with single and double quotation marks, but without any positiv result.
Is something like that already known? Could it be a possible reason or any other advice what to do?
Version of Home Assistant?
2023.09.2
What type of installation are you running?
Home Assistant OS
Version of WebUntis
v0.6.1
Last working WebUntis version
v0.4.x
Traceback/Error logs
2023-09-26 21:39:55.343 ERROR (SyncWorker_7) [webuntis] {'jsonrpc': '2.0', 'id': '2023-09-26 21:39:55.173454', 'error': {'message': 'bad credentials', 'code': -8504}}
2023-09-26 21:39:55.949 WARNING (MainThread) [custom_components.webuntis] Login to WebUntis 'school-address@max mueller' failed - OSError: bad credentials
(I changed the login address due to data protection)
Additional information
No response

Tried to dig deeper and I used a simple python script to connect to WebUntis with the same credential... and it worked. I can login, read the class list and get timetable of the current day.
import webuntis
import datetime

today = datetime.date.today()
monday = today - datetime.timedelta(days=today.weekday())
friday = monday + datetime.timedelta(days=4)

print(webuntis.__version__)

s = webuntis.Session(
    server='https://tipo.webuntis.com',
    username='7d',
    password='Krauß',
    school='name+city',
    useragent='foo'
)

s.login()

for klasse in s.klassen():
    print(klasse.name)

source = s.klassen().filter(name='7d')[0]

day = datetime.date.today()

tt = s.timetable(start=day, end=day, klasse=source).to_table()

for time, row in tt:
    print(format(time.strftime('%H:%M')))
    for date, cell in row:
        for period in cell:
            print(', '.join(su.name for su in period.subjects))

s.logout()

Exactly the same credential don't work with the Home Assistant integration. With additional logging outputs, I can confirm that the config information entered was transfered correctly into the session object and is neither altered nor deleted during login trial.
2023-10-11 20:56:45.515 INFO (MainThread) [custom_components.webuntis.config_flow] hc server 1: https://tipo.webuntis.com/WebUntis/jsonrpc.do
2023-10-11 20:56:45.515 INFO (MainThread) [custom_components.webuntis.config_flow] hc school 1: name+city
2023-10-11 20:56:45.515 INFO (MainThread) [custom_components.webuntis.config_flow] hc username 1: 7d
2023-10-11 20:56:45.515 INFO (MainThread) [custom_components.webuntis.config_flow] hc password 1: Krauß

2023-10-11 20:56:45.517 DEBUG (SyncWorker_1) [webuntis] Making new request:
2023-10-11 20:56:45.517 DEBUG (SyncWorker_1) [webuntis] URL: https://tipo.webuntis.com/WebUntis/jsonrpc.do?school=kepi+tuebingen
2023-10-11 20:56:46.057 DEBUG (SyncWorker_1) [webuntis] Valid JSON found
2023-10-11 20:56:46.057 DEBUG (SyncWorker_1) [webuntis]   Got data{"jsonrpc":"2.0","id":"2023-10-11 20:56:45.517114","error":{"message":"bad credentials","code":-8504
2023-10-11 20:56:46.058 ERROR (SyncWorker_1) [webuntis] {'jsonrpc': '2.0', 'id': '2023-10-11 20:56:45.517114', 'error': {'message': 'bad credentials', 'code': -8504}}

2023-10-11 20:56:46.061 INFO (MainThread) [custom_components.webuntis.config_flow] hc server 2: https://tipo.webuntis.com/WebUntis/jsonrpc.do
2023-10-11 20:56:46.061 INFO (MainThread) [custom_components.webuntis.config_flow] hc school 2: name+city
2023-10-11 20:56:46.062 INFO (MainThread) [custom_components.webuntis.config_flow] hc username 2: 7d
2023-10-11 20:56:46.062 INFO (MainThread) [custom_components.webuntis.config_flow] hc password 2: Krauß

The only difference I could spot is that my python-webuntis has version 0.1.22, whereas the home assistant version has 0.1.21. Could this be a root cause?
Anyone has an idea how to continue with the debugging?

The only difference I could spot is that my python-webuntis has version 0.1.22, whereas the home assistant version has 0.1.21. Could this be a root cause?

I updated the version to 0.1.22. You may check if it will work now.

Installed the update and both logins are accepted now.
So, looks fine to me with the current version 1.0.1
Thanks for your effort!

Hero!
My login also works now. Thanks for the fast turn-around.


Feat: Provision for password entry in SSH

Summary
For both "password" and "keyboard-interative" authentication types, this provides the ability to ask the user for a password just-in-time, avoiding the need for either configuration changes or secret storage.
In support of need for fallback options when SSH_AUTH_SOCK isn't set (Issue #1059) and needing password authentication more generally (Issue #294), I propose this change.
It does two things:

Adds an event handler for "keyboard-interactive", and, if a password is being required by the server, prompts user for a password
Modifies the event handler for connection error so that if it's an authentication error, then the user is given a chance to enter a password then the config is modified appropriately and the connection is re-initiated

Extra Notes about the "password" fallback
The "password" authentication method, when requested by a server, is usually at the end of the priority list. But the "password" field is on the configuration passed to "connect()" on the connection object. It's not currently possible to delay asking for a password until needed with the SSH2 API [*]. So we have a choice:

Ask for password, every connection, unnecessarily [User Hostile]
Add something to the SSHProfile object that points to a password [eg by incorporating secrets management, or having a boolean "request_password" parameter] [User unfriendly, and potential attack surface]
Explicitly recognise when there was a connection error due to authentication, and let the user have another chance to enter a password.

I chose option 3, for this pull request.
[*] I have put in a feature request with SSH2 for this, here: https://github.com/mscdex/ssh2/issues/1400 . But, I have a relatively immediate need for this feature to work. If SSH2 implements my proposed change, then this module can be modified to reflect that, later. Until then, I believe this is an appropriate fix.
Testing
These code changes are only in play when actually connecting to a remote server, and observing events that are triggered. I have tested this on my local system:
{Keyboard-Interactive Enabled on server: On, Off} X {Password enabled on server: On, Off} X {Public Key Auth set up Properly: Yes, No} X {Entering a valid password: Yes, No}.
I'm unclear how to configure tests where interaction with the remote server is key [and none of the other SSH tests are set up to do this either]
Signed-off-by: Gary Briggs<EMAIL_ADDRESS>

@smorrisj this is a really meaningful patch in terms of improving usability for SAS where I work. If it's possible for this to be reviewed and, ideally, merged before the next release, that would be a big deal for us in terms of adoption. Please let me know what specifically I can do to move it along, if anything.

@chunky thanks for the PR. Apologies for the delay, I was out of the office last week.
I think that the best solution with regards to setup friction and ease of use would be option 2 in the long term. VSCode has a secret storage api that we make use of to store secrets for the other connection types for viya and IOM. I think that ideally we use the same JIT approach to prompt for the password that we're currently using for IOM. We created #294 to track this a while back. Typically, in the ssh2 library, the authHandler property is used to control the different types of auth names that are supported during handshake. The obvious downside (which it looks like you ran into on the ssh2 issue) is that it requires writing custom code to define the names for them, or a custom function that can use the supported callbacks.
I think that if we can implement first class support for #294, then we should also rollout explicit fallback support. It seems like there could be value in allowing advanced users to determine what that order looks like? The default chain is:
None -> Password -> Private Key -> Agent (-> keyboard-interactive if tryKeyboard is true) -> Hostbased
Tagging @snlwih for awareness and as input to current conversations around enhancing SSH Connection support.

I tried to create something that did the password entry JIT with secrets manager, and couldn't get it to work. Something was awry, and I know it's my fault, but I couldn't figure out what.
I also coded something that uses the authhandler, based on feedback from the ssh2 maintainer. You can find the code in a separate branch here:
https://github.com/sassoftware/vscode-sas-extension/commit/d276e0c27026fa18afb9ebbb1fb61824016af10d
The flow is a little awkward [and almost impossible to meaningfully test], but it does get the job done. If you want to implement that, then I would also recommend rolling in something for unshielded identity files since [as you see in the code there], it can work but it's commented out.
I guess another way to put this is... what can I do, or say, or code, that culminates in something getting into any of the next few releases that means my windows users don't need to deal with SSH_AUTH_SOCK? We cannot install the windows SSH stuff on our laptops as described, and overall for windows the whole thing is a bit too user-hostile for most of my potential users.

I'm absolutely not precious about my code, or PRs. If you want to butcher/cannibalise whatever you can from what I've done, please, feel free. I'm flattered you might find it useful.
For our users, I also note that unshielded private keys are in prolific use for day to day ssh, as the next step beyond password. Handling that, in addition to password, would really give good reach across the community.
My time issue is that I currently have a SAS infrastructure project to roll out viya. This extension is so good, I also want to get our 9.4 / grid users using it, and I'm sneaking this engagement in to the viya thing. But once the viya project completes, I'll have to move on.

Opened #1126 to implement username/password support for SSH. I put some initial thoughts in TODOs based on conversations here. @chunky do you mind double checking those comments to ensure we've captured the different items that were discussed here?

@chunky , now that we're planning for user/pass support for SSH connections (#1126), which also includes some slight internal rearchitecture, can we close this PR?
@smorrisj , do we need a dedicated feature request to ask for fallback to user/pass when key-based authentication fails for SSH, which could be implemented once #1126 is in place? You mention it in one of your earlier comments (https://github.com/sassoftware/vscode-sas-extension/pull/1081#issuecomment-2242857277) in this PR.

@smorrisj , do we need a dedicated feature request to ask for fallback to user/pass when key-based authentication fails for SSH, which could be implemented once #1126 is in place? You mention it in one of your earlier comments (#1081 (comment)) in this PR.

I dont think so. The plan was to implement this refactor to use fallback methods as part of #1126. The goal would be to get the list of supported auth methods that the server can be supported from the server, and then diff that list against what we can support in the extension. As part of that PR we would also add back in support for specifying identify files. It turns out that the ssh2 library we use has a built-in function for detecting encrypted private keys, so in my draft of changes on #1126, I've added in an extra feature that would detect the encryption and prompt the user to enter the passphrase in the scenario that a private key is specified in the SAS Profile Connection, but it has a passphrase on it. In setting up the auth handler this way, we could support users that:

Want to use the ssh agent for all key setup and auth (current method that we support)
Do not want to use the ssh agent, and instead specify their private key in the SAS Connection Profile json. This method supports passphrased and non passphrased private key files. This is something that @chunky mentioned above that would ease setup friction.
Want to not use any of item 1 or item 2 above, and just want to use a simple username and password to authenticate.

@snlwih Yes, please feel free to close this PR. I'm not precious about my code - I just want this capability, and since you're implementing it elsewhere, then you can close this.

As discussed above, closing this as the capability will be implemented using pull request #1126


DEV: preps and documentation of new_type

DEV:
Misc changes to find middle ground between old and new API, i.e,

fixing occurrences of make_seq which do not use keyword args
fixing occurrences of creating seqs without a moltype
using get_moltype instead of directly importing a moltype in order to allow code to respect setting new_type=True with an environment variable

DOC

documentation of the existence of new API

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

37 of 55 (67.27%)  changed or added relevant lines in 11 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 91.998%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/cogent3/core/alignment.py
6
7
85.71%

src/cogent3/core/new_genetic_code.py
1
2
50.0%

src/cogent3/core/new_moltype.py
2
3
66.67%

src/cogent3/evolve/fast_distance.py
3
4
75.0%

src/cogent3/evolve/parameter_controller.py
2
3
66.67%

src/cogent3/core/new_alphabet.py
5
7
71.43%

src/cogent3/evolve/likelihood_tree.py
9
14
64.29%

src/cogent3/core/new_sequence.py
2
8
25.0%

Files with Coverage Reduction
New Missed Lines
%

src/cogent3/core/alignment.py
1
93.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
33086

Relevant Lines:
35964

💛  - Coveralls


closing issues with keywords in commits

Moving forward, I will be closing issues with keywords in commits when the commit solves the specific issue. I was not aware of this function until now.
https://docs.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords

ohhhh this is amazing. I saw that if you comment on it in a PR it sometimes closes the issue.


Same script for Magic Eden?

Hello! Great script, working like a charm!
Can you modify your script so it can download images from Magic Eden? No API though...

The name of this repository and project is OpenSea NFT Stealer. I can make a separate script for Magic Eden. However, this isn't a valid issue for this repo.

I just did not get how to contact to you directly. If you can DM me - we can discuss.

Maybe you can contact me at telegram balda8?

@rokii666 You can reach me at my email listed on my GitHub, or my Discord @DanChan#6969.

Sent you request in Discord

Hello! Are you still willing to do same script for MagicEden?
On Wed, Jan 26, 2022 at 9:42 AM Dan @.***> wrote:

@rokii666 https://github.com/rokii666 You can reach me at my email
listed on my GitHub, or my Discord @Danchan https://github.com/Danchan
#6969.
—
Reply to this email directly, view it on GitHub
https://github.com/sj-dan/OpenSea-NFT-Stealer/issues/26#issuecomment-1021942377,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYUCVQRXGJ3TOO4R47QQ5LUX6QVZANCNFSM5M2JK5LQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


LayoutLMv2 nan training loss and eval

Describe the bug
Model I am using is LayoutLMv2 with custom dataset.
The problem arises when using:

[x] the official example scripts:
I am using the same run_funsd.py, but using a modified dataset.

To Reproduce
Steps to reproduce the behavior:
run_funsd.py --do_eval=True --do_predict=True --do_train=True --early_stop_patience=4 --evaluation_strategy=epoch --fp16=True --load_best_model_at_end=True --max_train_samples=1000 --model_name_or_path=microsoft/layoutlmv2-base-uncased --num_train_epochs=30 --output_dir=/tmp/test-ner --overwrite_output_dir=True --report_to=wandb --save_strategy=epoch --save_total_limit=1 --warmup_ratio=0.1

Fortunately, I recorded everything with wandb.

After 8 epochs the training and eval loss went to nan, while the f1 score dropped suddenly. The samples per second increased significantly as well.

Platform:
Python version: 3.7.1
PyTorch version (GPU?): tesla T4

@victor-ab
I was trying to use a dataset with a sample annotation like https://github.com/doc-analysis/DocBank/blob/master/DocBank_samples/DocBank_samples/10.tar_1701.04170.gz_TPNL_afterglow_evo_8.txt are there any pointers on how to convert the dataset to the run_funsd.py script format?

@victor-ab Have you figured out where the problem is? I also used the official example script run_funsd.py with my own custom dataset and got nan training loss. The run_funsd.py script runs perfectly well on funsd dataset.

same question, maybe something wrong with spatial aware self attention

Hey where is the option to provide custom dataset path in run_funds.py file.

Okay continuing my debug process here:
In LayoutLMv2ForTokenClassification the loss is calculated in the following manor:
loss = None
if labels is not None:
    loss_fct = CrossEntropyLoss()

    if attention_mask is not None:
        active_loss = attention_mask.view(-1) == 1
        active_logits = logits.view(-1, self.num_labels)[active_loss]
        active_labels = labels.view(-1)[active_loss]
        loss = loss_fct(active_logits, active_labels)
    else:
        loss = loss_fct(logits.view(-1, self.num_labels), labels.view(-1))

The problem with this is, if active_labels contains a lot of -100 values.
This is the case if one sets only_label_first_subword in the tokenizer to True.
The issue hereby is that the CrossEntropyLoss ignores all losses where the label is -100. It takes all other values, and takes an average over them.
Let's assume the extreme case where only one of the 512 labels is not -100. In that case the average is just the value divided by one. This as well means the gradient is only divided by one. Therefore, the gradient through the one active output is approximately 512 times higher than expected.
If all labels are different from -100 the average is the sum of all losses divided by 512, meaning that the gradient is as well divided by 512.
What solved the problem for me is to calculate the loss' sum and divide by the maximum number of labels:
loss_fct = CrossEntropyLoss(reduction="sum")
if attention_mask is not None:
    active_loss = attention_mask.view(-1) == 1
    active_logits = logits.view(-1, self.num_labels)[active_loss]
    active_labels = labels.view(-1)[active_loss]
    class_loss = loss_fct(active_logits, active_labels)
else:
    class_loss = loss_fct(logits.view(-1, self.num_labels), labels.view(-1))

class_loss = class_loss / len(labels.view(-1))

This way the gradients are independent of the number of labels that are -100.
I hope this helps others 🙂 If my assumptions are wrong, I would love some input 👍

Hey
I am having a similar issue where the logits outputted by the model after training is nan. Any reason why this is happening?
I am training this on a custom dataset with 29 classes and 40000 data points. The steps followed are identical to this link except for a few tweaks : https://github.com/NielsRogge/Transformers-Tutorials/blob/master/LayoutLMv2/RVL-CDIP/Fine_tuning_LayoutLMv2ForSequenceClassification_on_RVL_CDIP.ipynb
I do not know if this is a problem but I am training it on multiple gpus using the Accelerate API of huggingface. Any help to this is much appreciated

您发的邮件已收到，谢谢！

Your email has been received, thank you!
Ihre e - mail bekommen, danke!
あなたのメールが届きましたが、ありがとうございます！——————————————————————————Xue Xu    Tel: @.***

Perhaps there is no problem with the loss calculation code.
In my case, I got NaN value only when calculating loss with autocast(), but when I stopped using amp, I no longer get NaN value.
I hope this will be helpful to you.
NaN calculation with AMP is a known issue.
https://github.com/pytorch/pytorch/issues/40497

您发的邮件已收到，谢谢！

Your email has been received, thank you!
Ihre e - mail bekommen, danke!
あなたのメールが届きましたが、ありがとうございます！——————————————————————————Xue Xu    Tel: @.***


python-jwt is deprecated

Good day to you!
Describe your environment

Operating System version: Windows 10
Firebase SDK version: (not sure)
Firebase Product: auth
Python version: 3.11.4
Pip version: 23.3.1

Describe the problem
Steps to reproduce / Relevant Code:
The code
import firebase

Now emits a warning
api\firebase\admin.py:4: in <module>
    import firebase
..\.venv\Lib\site-packages\firebase\__init__.py:13: in <module>
    from .auth import Auth
..\.venv\Lib\site-packages\firebase\auth\__init__.py:20: in <module>
    import python_jwt as jwt
..\.venv\Lib\site-packages\python_jwt\__init__.py:14: in <module>
    warnings.warn('The python_jwt module is deprecated', DeprecationWarning, stacklevel=2)
E   DeprecationWarning: The python_jwt module is deprecated

Seems like the author of https://github.com/davedoesdev/python-jwt released a new version with this warning and archived their repo.
This is fine, I can pin the version of the lib in the lock file or add this warning to the list of ignored warnings, but this might prompt you to migrate this library to another JWT implementation.

The official Firebase Admin Python SDK does not use python-jwt as a dependency. Could you provide more information on the SDK and the version you are using? Thanks!

Forgive me, I confused this repo with https://github.com/AsifArmanRahman/firebase-rest-api
Sorry about that!