Quantised sequence start

Shift+pads: Queue a stopped sequence to start playing on beat.
To me I would have expect this to be the default case for any step sequencer. I would suggest setting this as defaul. May we can use the shift mode for a quantised launch of two sequences so that the stopped sequence will start when the other sequence resets to the first step. Does that make sense?

Yes, makes sense. One of the things I want to avoid is putting too many arbitrary restrictions on what the program can do, since I find that things like playing a sequence out of step with its original position can be the thing that leads to happy creative accidents. Of course, I also want the software to be something that people actually like using, so I'm happy to change the default behaviors and make them more useful.
Both of your suggestions make sense. For your suggested shift behavior, am I right in thinking it would be a workflow of hold shift, then hold a first - already playing - sequence's play button, then press the play button of the stopped sequence?
If this change was made, pressing the pads in session mode could still be used unquantized, which would probably make more sense, as the pads are something that can be "played" so they are more suitable for interactions that need good timing, and the play buttons are more rigid and shouldn't require accurate timing. Anyway, that makes sense to me.

:+1: Sounds great to me.

play button: quantised (synced to beat) :heavy_check_mark:
shift+play button: sync to selected track. Maybe this functionality could be simplified so that it can be used without selecting any other patterns at all. I would therefore just sync it to the track which is the first that jumps to step 1. But I also like your idea as well. But I'm not sure if this is easy to learn for beginners
pads: immediately start playing the sequence

I believe that last commit fixes all this up, unless there's anything I missed? I went with shift+play snapping to the first sequence that wraps back around.

Works as advertised. Love it


Welcome: Error reading markdown document at ... common/media/theme_picker

Steps to Reproduce:

run insiders on a fresh user data dir
welcome opens with an error:

Error reading markdown document at `file:///private/var/folders/fv/p__j7gw9097crr40g7sf2pxw0000gn/T/vscode-bisect/.builds/dc9412125d4e0a480593962ae2687e74e64af728/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/contrib/welcomeGettingStarted/common/media/theme_picker?%7B%22moduleId%22%3A%22..%2Fcommon%2Fmedia%2Ftheme_picker.js%22%7D`: Error: Unable to read file '/private/var/folders/fv/p__j7gw9097crr40g7sf2pxw0000gn/T/vscode-bisect/.builds/dc9412125d4e0a480593962ae2687e74e64af728/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/contrib/welcomeGettingStarted/common/media/theme_picker' (Error: Unable to resolve nonexistent file '/private/var/folders/fv/p__j7gw9097crr40g7sf2pxw0000gn/T/vscode-bisect/.builds/dc9412125d4e0a480593962ae2687e74e64af728/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/contrib/welcomeGettingStarted/common/media/theme_picker')

@bhavyaus probably related to ESM

Bisect points to https://github.com/microsoft/vscode/compare/11e9922e50c5a8c628cd7d27e802d388818139c0...6fd50371a51285fe8635a99420dd84ab6a7dd122
I assume its from https://github.com/microsoft/vscode/commit/3c2092601e46a27728d0bd41474af8a6367050d1

@bhavyaus the problem here is that you await import welcome content from disk, but this content is not present in a real build because its not an entry point known to the build process.
I see 2 options:

restore how it used to be with my registry
adding real entry points for the welcome content somewhere here

If I could choose, I would restore my solution, any objections?

Since this is for built-in walkthroughs only, your change makes sense instead of setting up entry points just for these modules.
Revert PR: https://github.com/microsoft/vscode/pull/228534


jpegio.write saves the original coefs rather than the modified coefs

I have to modify a grayscale jpeg's dct coef and save it to another path. But it seems that jpegio.write() saves the original coefs rather than the modified coefs. Could you please check this out for me? Thanks a lot!
######################################
import jpegio as jio #jpegio version is 0.2.2
import imageio
import numpy as np
cover = jio.read(cover_path)
cover_coef_input = np.array(cover.coef_arrays[0])
cover.coef_arrays[0] = cover.coef_arrays[0] + pert
cover_coef_modified = np.array(cover.coef_arrays[0])
jio.write(cover, stego_path)
cover = jio.read(cover_path)
cover_coef = np.array(cover.coef_arrays[0])
cover_spatial = imageio.imread(cover_path)
stego = jio.read(stego_path)
stego_coef =  np.array(stego.coef_arrays[0])
stego_spatial =  imageio.imread(stego_path)
print('num_cin_cm_diff:',np.sum(cover_coef_modified!=cover_coef_input))  # 1034
print('num_cin_c_diff:',np.sum(cover_coef!=cover_coef_input))                     # 0
print('num_c_s_diff:',np.sum(cover_coef!=stego_coef))                                  # 0
print('num_cm_s_diff:',np.sum(cover_coef_modified!=stego_coef))               # 1034
print('num_c_s_spatial_diff:',np.sum(cover_spatial!=stego_spatial))               # 0

Thanks for reporting the issue.
Could you please upload or send me an example file (i.e., the grayscale JPEG file)?

cover.zip
Thanks for your consideration. Some example grayscale JPEG files are in the above zip file url.

I faced the same issue, when I tried to modify the coefficients in my image. So I guess there is no solution for now?

So this whole repo can be considered as not working?

Try the below project, which is more comprehensive and supported.
https://github.com/martinbenes1996/jpeglib


Ensure correct compliance icon, 7 day timeline, last hour utilization

https://bugzilla.redhat.com/show_bug.cgi?id=1516807
Resource details state also now truncates utilization available resources to 3 places
Ends up vm metrics stream sometimes returns two entries per hour, that means we need to find the one from the last hour, hence the .find
Set default timeline option to a 7 day period, this is then updated to better fit the events data
Ensured compliance text is capitalized
with events in timeline (after)

with events in timeline (before)

without events in timeline (after)

without events in timeline (before)  (you'll notice we're missing storage because we were grabbing the wrong hour)

cc @Loicavenel  lemme know if this satisfies the ask of the bz 🙇♀ ❤

@AllenBW There is a conflict backporting this to Gaprindashvili for manageiq-ui-service.pot. Normally translation related files are not backported and it has its own branch specific PRs.  What should I do with this conflict?
cc @mzazrivec

@simaishi uggghhh yeah that didn't need to be in this pr, must have missed it, can that file be disregarded  and the rest backported?

Changes in manageiq-ui-service.pot should not be backported (i.e. the one already in gaprindashvili
branch should stay as it is).

OK, will backport the rest.

Gaprindashvili backport details:
$ git log -1
commit d12281acb8ce63bc7511c8cdb01ca3f53a7293bb
Author: Chris Kacerguis<EMAIL_ADDRESS>Date:   Tue Nov 28 19:22:53 2017 -0600

    Merge pull request #1284 from AllenBW/bug/master/#1516807-update-resource-details

    Ensure correct compliance icon, 7 day timeline, last hour utilization
    (cherry picked from commit c60105b1dd7f9c862c76e0134bb2b4d176db236b)

    https://bugzilla.redhat.com/show_bug.cgi?id=1518748


no segment3 in newest ndnts library

hi, I download the newest ndnts library, and I could not find name convention3 in the library

Please provide all error messages as text, not as pictures.

Ok, I figure it out, I must run 'yarn cache clean', otherwise the yarn will use caching file of ndnts. Finally, it works.

otherwise the yarn will use caching file of ndnts

That's a shortcoming of NDNts-nightly.
https://yoursunny.com/t/2020/NDNts-nightly/


Command (mine) is not available for driver (both GD and Imagick)

So I'm trying to test on what kind of mine the image is. The input is a string to a image found on the internet.
public function store()
    {
        $rules = array(
            ....
            'image' => 'required'
        );

        $campaign = array(
            .....
            'image' => Input::get('image')
        );

        $validator = \Validator::make($campaign, $rules);

        if($validator->fails())
        {
            return Redirect::back()->withErrors($validator)->withInput();
        }

        $imgPath = public_path().'/images/campaigns/'. $campaign['slug'] .'_'. time() .'_';
        $img = Image::make($campaign['image']);//->save($imgPath .'350x300.jpg');

        dd($img->mine());

The dd($img->mine()); throws the following exception:
Intervention\Image\Exception\NotSupportedException thrown with message "Command (mine) is not available for driver (Gd)."
Stacktrace:
#22 Intervention\Image\Exception\NotSupportedException in /vendor/intervention/image/src/Intervention/Image/AbstractDriver.php:115
#21 Intervention\Image\AbstractDriver:getCommandClassName in /vendor/intervention/image/src/Intervention/Image/AbstractDriver.php:90
#20 Intervention\Image\AbstractDriver:executeCommand in /vendor/intervention/image/src/Intervention/Image/Image.php:101
#19 Intervention\Image\Image:__call in /app/controllers/dashboard/CampaignsController.php:100

I've tried to change the driver, but it results in same error. The mine type is already defined on the original image.

It's mime().


MM-40528 Fix error caused by changes to QuickInput

In my other PR to forward the ref through the QuickInput to the inner input, I missed a place that was still trying to access the ref as a field of the QuickInput
Ticket Link
https://mattermost.atlassian.net/browse/MM-40528
Related Pull Requests
https://github.com/mattermost/mattermost-webapp/pull/9452
Release Note
NONE

/cherry-pick release-6.3

Cherry pick is scheduled.


support char as map key

When attempting to use an untagged enum over a char as a map key while serializing to TOML I see this error: map key was not a string.
Writing my own serializer which uses char::encode_utf8 lets me work around this, but I think TOML should directly support a char as a map key?
Presumably this is just a little code in KeySerializer's fn serialize_char, maybe also the deserializer.

The approach I've been taking is that we do whatever serde_json does.
Please follow the pattern in #586 by including a complete reproduction case that contrasts tomls behavior with serde_json.


[ts-sdk] Fix incorrect param serialize

Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Current dependencies on/for this PR:

main

PR #9365   👈

This comment was auto-generated by Graphite.


[Android] onRenderError -1001,degradeToH5|createInstance fail|wx_create_instance_error isJSFrameworkInit==false reInitCount == 1  weex version is 0.28.0

Describe the bug
weex: idle from create instance cache size is 0
weex: onRenderError -1001,degradeToH5|createInstance fail|wx_create_instance_error isJSFrameworkInit==false reInitCount == 1
To Reproduce

Environment

Device: [MeiZu 6 Pro]
OS: [ 联发科x25 aarch64 arm64-v8a]
Version [Android 7.1.1]
Weex Version 0.28.0
jsc apply from: 'https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle'

Expected behavior
start app and white screen
but in others phone is work,eg:HuaWei aarch64 arm64-v8a
@YorkShen can you give  some help?

Describe the bug
weex: idle from create instance cache size is 0
weex: onRenderError -1001,degradeToH5|createInstance fail|wx_create_instance_error isJSFrameworkInit==false reInitCount == 1
To Reproduce

Environment

Device: [MeiZu 6 Pro]
OS: [ 联发科x25 aarch64 arm64-v8a]
Version [Android 7.1.1]
Weex Version 0.28.0
jsc apply from: 'https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle'

Expected behavior
start app and white screen
but in others phone is work,eg:HuaWei aarch64 arm64-v8a
@YorkShen can you give some help?

@Felix8029 I have the same problem as you. Have you solved this problem?

same bug

same bug.
My project has a SplashActivity render first screen, it doesn't has weex instance, and it will redirect to MainActivity which has weex instance after several seconds, and it triggers onRenderError very frequently on android 7, maybe the low performance phone leaded.
I wrote the code below in onRenderError:
        Log.i(Tag, "WXSDKEngine.isInitialized: " + WXSDKEngine.isInitialized());
        Log.i(Tag, "WXSDKEngine.isSoInitialized: " + WXSDKEngine.isSoInitialized());

while reproduce, isInitialized always false.
so, I wrote the code below in SplashActivity, before redirect:
            while (true) {
                try {
                    Thread.sleep(100);
                    if (WXSDKEngine.isInitialized()) {
                        break;
                    }
                } catch (InterruptedException e) {
                    e.printStackTrace();
                }
            }

It works!
But sometimes  it will take about 30+ seconds until MainActivity shows.


Hansard(s)

A lot of Commonwealth counties provide official transcripts of parliamentary debates going back many years. The work on the Canadian one already seems to be done (couldn't find a license, can ask them), and the UK Hansard can be easily scraped.

Looks like the Canadian hansard is about 5GB in .csv format and wouldn't require too much cleanup. If the UK hansard is of a similar size and would require tooling to scrape, it might not be worth it. Can we confirm that this content is indeed public domain?

The UK hansard is under the Open Parliament Licence which tracks pretty closely with Public domain except has personal information and national security exemptions.
For the Canadian one, there doesn't seem to be any authoritative source on the dataset site or the government's. The dataset seems to be mostly sourced from government publications according to the website. Should probably come under this, but I sent them an email.

I would love to help with this.
(Looks like several countries do not clearly specify the licensing information of the Hansards)

I would love to help with this.
(Looks like several countries do not clearly specify the licensing information of the Hansards)

Hey! I'm mostly done with the Canadian and UK ones, and yeah haven't been able to get much license information for all others. The Australian one is CC-BY-ND-NC which is out of scope . The Singapore one is also under a limited license iirc.

I would love to help with this.
(Looks like several countries do not clearly specify the licensing information of the Hansards)

Hey! I'm mostly done with the Canadian and UK ones, and yeah haven't been able to get much license information for all others. The Australian one is CC-BY-ND-NC which is out of scope . The Singapore one is also under a limited license iirc.

Yes, I noticed both Australia and Singapore were out of scope.
Is there anything else you think I can help you with? (even if it is not this specific Hansard task)


Single tap zap doesn't send custom sat amount

Describe the bug
In the Primal app, changing the single tap zap value doesn't actually send the custom value. I set my single tap zap to 21 sats, however tapping a note to zap it still sends 42 sets (the original value).
Steps to reproduce
Change the single tap value in Primal Zap settings to a new number of sats. Test out zapping a note and compare how many sats were sent to the custom value you set in the Settings.
Expected behavior
The user set value of single tap zaps should be the amount of sats sent when the user taps the zap button on a note.
Environment
I'm on the latest version of Primal from the Play Store - 0.90.2

Thanks for reporting the bug. This was fixed 3 days ago in 765461a2cd3ba88b61907b17bacd51d230d41e3b and it will be released this week.

This issue is now fixed the latest release 0.91.2

This issue is now fixed the latest release 0.91.2


Feature request: Setting help panel order of commands

I often use cyclopts to create scripts for my research, and sometimes I want the commands to be executed in an order.
For example, I might want to parse data files, EDA, and detect outliers in that order. But the help panel would be displayed in the following order
╭─ Commands ──────────────────────────────────────────────╮
│ detect-outlier                                          │
│ eda                                                     │
│ parse-data                                              │
│ --help -h       Display this message and exit.          │
│ --version       Display application version.            │
╰─────────────────────────────────────────────────────────╯

This is quite confusing when using the script later.
How about the option to display commands in the order of registration, not than sorting by name?
Or letting the user manually decide the order.
Thanks for reading and thanks for the great package!

Hi beskep!
A related feature is that Cyclopts supports user-defined ordering of Groups. You could add each command to their own group and have them ordered that way, but it's not exactly what you asked for.
We could add a similar sort_key to App.command; I think that wouldn't be too much trouble and it would be consistent with the Group feature. Displaying commands in order of registration could then be expressed as:
"""Example of forcing registration-order."""
import itertools
from cyclopts import App

_counter = itertools.count()
app = App()

@app.command(sort_key=next(_counter))
def foo():
    pass

@app.command(sort_key=next(_counter))
def bar():
    pass

What do you think of this?

I knew about group ordering, but I couldn't use it for commands because I already group my commands for preprocessing, analysing, plotting, etc.
I was using App inherited class if help_panel.format == "command": help_panel.sort() is removed.
A sort_key option would be nice! It would be a simple solution.
Thanks you for the answer.

sounds like a plan; i can implement this soon!

That was quick! Thank you very much.


Automate updating go version in rancher/machine

Follow-up to https://github.com/rancher/rancher/issues/46515 to potentially automate this process

PRs created by renovate in rancher/machine

https://github.com/rancher/machine/pull/260
https://github.com/rancher/machine/pull/261
https://github.com/rancher/machine/pull/262
https://github.com/rancher/machine/pull/263


SVGs change to default when switching contrast themes while enhance inputs is turned on

Describe the bug
A clear and concise description of what the bug is.
SVGs switch to default attribute values when user is switching contrast themes while enhance inputs is turned on.
To Reproduce
Steps to reproduce the behavior:

Go to mobile view (any mobile view will do)
Turn on enhance inputs UIO preference
toggle through UIO contrast themes
See error in brand svg and header search svg

Expected behavior
The same svg attribute values should remain (except colour/contrast) when switching contrast themes while enhance inputs is turned on as before.
Screenshots

Additional context
N/A

This issue is reproducible with the desktop view too.

Fixed with the merge of #233.


Collapse ErrorHandler and BatchErrorHandler interface hierarchies into a single interface for each

Closing as won't fix.

Reopening: https://github.com/spring-projects/spring-kafka/pull/1837


added chicken parm nachos

It is the size of (or larger than) some dinners but is designed eaten as a midnight snack.

I got my hands on some chicken parm. Going to wait until it can properly ferment into leftover status and then add pictures.

Cool. I'm ready for some serious nacho action.


chore(ansible): Create service monitor

Ansible based operator's should also create the service monitor as
appropriate.

@fabianvf @jmrodri I think one thing that would be helpful, in the future to prevent needing these kinds of PRs, would be to pull out the startup tasks that are common to all operators into an operator-sdk lib that is used in the scaffolding. I'm sure there are risks in that kind of effort but worth considering.

/ok-to-test

/retest

/retest

Hi @djzager,
Regards:

It appears that my suspicion was correct (that the ServiceMonitor resource doesn't exist in the CI environment):
Ensure that no errors appear in the log
{"level":"info","ts":1578688227.027858,"logger":"cmd","msg":"Could not create ServiceMonitor object","Namespace":"default","error":"no ServiceMonitor registered with the API"}
{"level":"info","ts":1578688227.0278876,"logger":"cmd","msg":"Install prometheus-operator in your cluster to create ServiceMonitor objects","Namespace":"default","error":"no ServiceMonitor registered with the API"}
It may be possible to create the ServiceMonitor CRD simply to allow for it to be created and verified. wdyt?

The ServiceMonitor schema is from Prometheus Oper. In Kubebuilder we are installing the Operator. See: https://github.com/kubernetes-sigs/kubebuilder/blob/8f8905aadf0e26019b6ed2e6345d0bd2a70faff0/test/e2e/utils/test_context.go#L100. We may would like to do the same which means apply https://raw.githubusercontent.com/coreos/prometheus-operator/release-0.33/bundle.yaml .

CI will fail until I make the necessary updates to the molecule based testing. I will wait to do that until #2425 is merged.

@fabianvf @camilamacedo86 I believe I have addressed all of the comments and CI is passing. Please, take another look.

/lgtm

/lgtm


Check for IK solution without breaking (ROS)

Is there a way to check if an IK solution exists without breaking the script and throwing an error?
If so, could an example of how to do this be added to the docs?
For example, I would like to be able to first check if solution exists and then offer an alternative frame if it doesn't.

The usual way to handle exceptions in Python is with a try-except clause.  For example, if frames is a list of frames you'd like to check inverse kinematic solutions for in decreasing order of preference:
for frame in frames:
    try:
        ik_solution = client.inverse_kinematics(robot, frame)
        break
    except BackendError:
        print("trying again")
else:
    print("No ik solution found.")

Would something like that suit your purposes?

Yes... BackendError works. Thanks!

Great!


Fix: Silent Handlebars helper/partial console warnings when used w/ Gulp

Re: #77
This change to init() indirectly fixes the prompts about duplicate helpers/partials by using a new Handlebars instance each time Drizzle is started (if no handlebars instance argument is supplied).

👍


Node17 cannot start up "web" project

Package subpath './lib/tokenize' is not defined by “exports“ postcss-safe-parser

@Candytt plz use Node.js LTS (16)


Make the sync transaction and error handler callbacks safe to run after the SyncSession has been destroyed

The documentation for sync::Session states that they may be run after the sync::Session goes away, which means they may also be run after the SyncSession goes away. Capture a weak_ptr to this in the two callback lambdas so we can detect whether the SyncSession exists and guarantee it remains alive for the duration of the callback.
Fixes one of the problems noted in #207.
Needs:

[x] To do something besides abort in the error handler when called after the SyncSession goes away.
[x] Tests
[x] Verify that this approach is safe throughout the entirety of SyncSession's lifecycle, including when it transitions to being owned by a unique_ptr.

I've not had any luck in writing a test case that crashes without this fix. We don't have precise enough control over when sync invokes callbacks so it's difficult to trigger on demand.

Since I cannot see how to write a test for this at present, this is now ready for review.


Switch to ListOptions pagination for Dependabot alerts

Fixes 2852

Please see feedback here: https://github.com/google/go-github/issues/2852#issuecomment-1660900173


Promisify vs PromisifyAll

Hi,
I'm trying to promisify the request library and I need to use it as a function and sub methods. I'm doing the code below but I'm hoping there's a cleaner way to achieve this.
var Promise = require('bluebird');
var request = require('request');
var requestAsync = Promise.promisify(request);
var jarAsync = Promise.promisifyAll(request.jar());
return requestAsync(options).spread(function (response, body) {});
return jarAsync.getCookiesAsync(...).then(function (cookies) {});
if i do requestAsync.jar() it complains that the method does not exist.
Any insight appreciated.

What is performance difference between Bluebird promisify vs promisifyAll  when want to promisification of one method from module
Suppose,
I want to know performance difference between bluebird promisify vs promisifyAll.
I have tried performance test of bluebird promisify and promisifyAll.
But time and memory wise i do not see major difference, Still i thought promisify is slightly fast and less memory occupy. Still what is best.
Suppose i want Promisification of renderFile of ejs module for just 1 method renderFile.
I have 2 options
const ejs = require('ejs');
const renderFile = Promise.promisify(ejs.renderFile, {context: ejs});

const ejs = Promise.promisifyAll(require('ejs'));
I test performance via
console.time('A');
console.timeEnd('A');

and console.log(process.memoryUsage());
Pls answer about what should i use when i want promisification of only 1 method.
http://stackoverflow.com/questions/42455669/bluebird-promisify-vs-promisifyall-performance-compare-when-want-to-promisificat


kotlin.KotlinNullPointerException

Expected Behavior
Detect does static analysis
Observed Behavior
NPE
Steps to Reproduce
FinalNewline:
active: true
(setting it to false makes it work)
Your Environment
com.pinterest.ktlint.ruleset.standard.FinalNewlineRule.visit(FinalNewlineRule.kt:18)
Analyzing '.../CardInfo.kt' led to an exception.
The original exception message was: kotlin.KotlinNullPointerException

Version of detekt used:1.0.0-RC16
Version of Gradle used (if applicable):5.5-rc-1
Operating System and version:Mac 10.14.6

Since detekt provides a wrapper over ktlint, this is not directly a problem of detekt.
@ber4444 May I ask you to report this issue with the complete stack trace and the report lines of code to ktlint's repository?

Is the FinalNewline did not disappear from Ktlint ?

@afaucogney I don’t see that. How did you conclude that?
https://github.com/pinterest/ktlint/blob/master/ktlint-ruleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/FinalNewlineRule.kt
What


Compat with Species mod.

The Species mod (By Ninni) adds suspicious red sand, and would like the mod functionality to work on it as well.

On it :]

Thank you so much!


Add Support for 'sequencer' field in S3 Event Notifications

As per Event Message Structure, S3 event notifications support a string 'sequencer' field against the 'object' which should be used to verify event order as events are not guaranteed to arrive in order.
Expected Behavior
Amazon.S3.Util.S3EventNotification.S3ObjectEntity should be updated to include the Sequencer property:
/// <summary>
/// Gets and sets the sequencer of the S3 object event. This can be used to determine the relative order of some events such as PUT and DELETE.
/// </summary>
public string Sequencer {get;set;}

Amazon.S3.Util.S3EventNotification.Parse should be updated to parse the 'sequencer' field from JSON into the S3ObjectEntity object.
Current Behavior
Amazon.S3.Util.S3EventNotification.S3ObjectEntity does not contain a property called Sequencer and hence the value from the JSON event can't be used.
Context
I'm implementing a Lambda function in C# on .NET Core 2.1 that responds to S3 event notifications (PUTs, DELETEs) and updates an ElastiCache Redis cluster. Without this enhancement I will not be able to verify event order and this could result in DELETEs being incorrectly processed before PUTs and vice-versa.
Your Environment

AWSSDK.Core version used: <IP_ADDRESS>
Service assembly and version used: AWSSDK.S3 <IP_ADDRESS>
Operating System and version: Microsoft Windows [Version 10.0.14393]
Visual Studio version: Visual Studio Code 1.28.2

.NET Core Info

.NET Core version used for development: 2.1.4
.NET Core version installed in the environment where application runs: 2.1.4
Output of dotnet --info:

.NET Core SDK (reflecting any global.json):
 Version:   2.1.402
 Commit:    3599f217f4

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.402\

Host (useful for support):
  Version: 2.1.4
  Commit:  85255dde3e

.NET Core SDKs installed:
  2.1.300 [C:\Program Files\dotnet\sdk]
  2.1.301 [C:\Program Files\dotnet\sdk]
  2.1.302 [C:\Program Files\dotnet\sdk]
  2.1.401 [C:\Program Files\dotnet\sdk]
  2.1.402 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

Thank you for reporting this.

Yes, thank you. I am interested in this fix too.


[ALLUXIO-2666] Make BufferUtils Test Final

ALLUXIO-2666

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15557/
Test PASSed.

Hello there, A off topic question I am gonna ask:)
how to configure this utility? what plugin/plugins you are using?Are the items (valid pull request title;Contains link to JIRA ticket,Commits ...) configurable? Thks~


Support ES6 syntax

Using ES6 arrow functions causes parse errors in ng-annotate.
Running ng-annotate after transpilation is not possible due to Traceur removing comments, meaning explicit @ngAnnotate markers go missing.

Please check out the proposal in https://github.com/olov/ng-annotate/issues/124#issuecomment-68484704 where a "use strict"-like "ngInject" string literal would be used for ES6 constructors. Feedback welcome in #124 or here!

Please check out the proposal in https://github.com/olov/ng-annotate/issues/124#issuecomment-68484704 where a "use strict"-like "ngInject" string literal would be used for ES6 constructors. Feedback welcome in #124 or here!

Thanks for you work! Sorry if it's wrong place to ask.
Spent a few hours trying to make ng-annotate working with es6ify (traceur) output. Without success. I have the latest version of ng-annotate.
Please provide correct syntax to use with es6 classes and the real state of – searching through various issues didn't left any clear vision of how to do that.

@rootical use "ngInject"; inside of ES6 functions that you want to have annotated. The ES5-output from Babel will preserve these strings and you can then run them through ng-annotate. I'll add a section about this to the README eventually.

@olov That only works on functions right? not classes?

@mithun-daa For classes: class MyCtrl { constructor($a, $b) { "ngInject"; ... } }

Babel will actually preserve comments as well, as long as you have the "compact" option set to "false". I am using /* @ngInject */ annotations on all my ES6 controller functions and classes.
Unless you have very good reasons to keep using Traceur, I recommend switching to Babel. It's has far better support, documentation and configurability.

:+1:

@olov , @JonRimmer guys, please clarify it a bit. I was able to successfully ng-annotate classes with traceur using  this way class MyCtrl { constructor($a, $b) { "ngInject"; ... } }.
After switching to babel, I try to use it along with browserify-ngannotate in a gulp task basically the same way as before with traceur:
  bro = browserify('./client/app/app.js', {debug: true});
  bro.transform(babelify.configure({
    compact: true,
    comments: true
  }));
  bro.transform(ngAnnotate);

Nothing seems to be ng-annotated. I've also tried to do /* @ngInject */ instead of "ngInject"; with no luck. Am I missing something?

Duck debugging helped, that's how it works with babel:
/* @ngInject */
class MyCtrl { constructor($a, $b) { ... } }

Thanks

@rootical thanks for reporting, "ngInject"; not working turns out to be a bug in Babel, which doesn't preserve directive prologues (see https://babeljs.io/repl/#?experimental=true&playground=false&evaluate=true&loose=false&spec=false&code=class MyCtrl { constructor(a) { "use strict"%3B foo } }). I'm filing a bug!

FYI, Babel 4.7.4 and newer supports directive prologues properly so "ngInject"; will work fine with it

I'm about to release ng-annotate 1.0 soon and with it I'll close this issue. I'll add proper documentation to the README of how to deal with ES6 and TypeScript, i.e. run ng-annotate on the transpiled output and use "ngInject"; (preferred) or /*@ngInject*/ (more fragile to transpiler changes). ng-annotate supporting ES6 (ESxy) code directly could happen in the future if a contributor stepping up.

A couple of other points wrt to using ngAnnotate on the output of Babel ES6 modules. Babel will transpile an Angular import like so:
import angular from 'angular'
angular.module(...)

var _angular = require('angular');
var _angular2 = _interopRequireDefault(_angular);
_angular2['default'].module(...)

Which breaks all the usual auto-detection. Would it be possible to configure detection for the angular.module as well?

Check out our regexp option https://github.com/olov/ng-annotate#declaration-forms. You case use that to match [regexp].controller and so on. The default regexp is ^[a-zA-Z0-9_\$\.\s]+$ which matches things like myMod or myMod.foo.
As an example (from the README), --regexp "^require(.*)$" will work properly for require('app-module').controller(..). In your case, perhaps try --regexp "angular.*\.module(.*)$" (not tested).

1.0.0 is out so closing this because https://github.com/olov/ng-annotate/issues/64#issuecomment-78462297

@natefaubion what did you end up doing? You should be able to call ng-annotate before babel.

@breandr I ended up not importing angular directly (but a util lib instead), and then writing a plugin to match the (0, foo.bar)(...) syntax babel emits for imports. I had to fiddle around with $chained and $methodName (which ngAnnotate uses internally to identify nodes) to get it to work though. The plugin API could use a little love, but maybe I'm not using it correctly.
function NgAnnotateBabelPlugin() {
  var ngProps = ['directive', 'controller', 'config', 'run', 'provider',
                 'service', 'factory', 'filter', 'animation']

  this.init = _.noop
  this.match = function(node) {
    if (node.type === 'CallExpression' &&
        node.callee.type === 'SequenceExpression' &&
        node.callee.expressions[0].type === 'Literal' &&
        node.callee.expressions[0].value === 0 &&
        node.callee.expressions[1].type === 'MemberExpression' &&
        _.contains(ngProps, node.callee.expressions[1].property.name)) {

      return node.arguments.filter(function(arg) {
        if (arg.type === 'FunctionExpression') {
          arg.$chained = 4 // Regular chain
          arg.$methodName = node.callee.expressions[1].property.name
          return true
        }
      })
    }
  }
}

import { directive } from '...'

export default directive('foo', () => { ... })

It's a bit ironic that one of Babel's selling points is clearer transpiled source, yet it doesn't work out of the box with ng-annotate, unlike Traceur.
@olov Thanks for the regex, that works (at least for our purposes)! I've modified it the following way for safety: angular.*?\.module\(.*?\)$

@pmowrer just find out, here is a more reasonable one: angular.*?\\.module(.*?)$


Create npm-publish-github-packages.yml

@prechayimmee, thank you for your pull request! Could you please explain why a separate workflow is necessary?


helm dependency update panics on symlink

SSCCE
To reproduce, run:
helm create foo
helm create bar

echo '
dependencies:
  - name: bar
    version: 0.1.0
' >> foo/Chart.yaml

ln -s $(pwd)/bar foo/charts/bar

helm dependency update foo

It will fail with
walk.go:74: found symbolic link in path: /.../foo/charts/bar resolves to /.../bar
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "pmd" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Dependency bar did not declare a repository. Assuming it exists in the charts directory
Deleting outdated charts
Could not verify foo/charts/bar for deletion: cannot load a directory (Skipping)panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x53b980d]

goroutine 1 [running]:
helm.sh/helm/v3/pkg/chart.(*Chart).Name(...)
	helm.sh/helm/v3/pkg/chart/chart.go:76
helm.sh/helm/v3/pkg/downloader.(*Manager).safeMoveDeps(0xc0001a90e0, {0xc000010088, 0x1, 0x57}, {0xc000befc70, 0xd}, {0xc000befc56, 0xa})
	helm.sh/helm/v3/pkg/downloader/manager.go:452 +0x48d
helm.sh/helm/v3/pkg/downloader.(*Manager).downloadAll(0xc0001a90e0, {0xc000010088, 0xc0004d2e20, 0x1})
	helm.sh/helm/v3/pkg/downloader/manager.go:371 +0x176b
helm.sh/helm/v3/pkg/downloader.(*Manager).Update(0xc0001a90e0)
	helm.sh/helm/v3/pkg/downloader/manager.go:201 +0x109
main.newDependencyUpdateCmd.func1(0xc00036c780, {0xc0004f42b0, 0x1, 0x1})
	helm.sh/helm/v3/cmd/helm/dependency_update.go:74 +0x35c
github.com/spf13/cobra.(*Command).execute(0xc00036c780, {0xc0004f4280, 0x1, 0x1})
	github.com/spf13/cobra@v1.2.1/command.go:856 +0x60e
github.com/spf13/cobra.(*Command).ExecuteC(0xc00026b900)
	github.com/spf13/cobra@v1.2.1/command.go:974 +0x3bc
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.2.1/command.go:902
main.main()
	helm.sh/helm/v3/cmd/helm/helm.go:87 +0x234

Output of helm version:
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.17"}

In the example you provided, it is expected that the user provides the repository field to inform the helm client that the chart foo depends on chart bar, which can be found at a particular directory.
Off the top of my head, your example should look something like this:
helm create foo
helm create bar

echo '
dependencies:
  - name: bar
    repository: file://../bar
    version: 0.1.0
' >> foo/Chart.yaml

ln -s $(pwd)/bar foo/charts/bar

helm dependency update foo

That will fix the warning "Dependency bar did not declare a repository." Because otherwise it assumes chart bar already exists in foo's charts directory.
Regardless, we should capture the stack trace and return an error gracefully. Please feel free to contribute a fix for this.

Hmm... Perhaps this has to do with how Go loads and resolves symbolic links as opposed to regular files.
Did this work in prior versions?

@bacongobbler here is what helm used to do. Version 3.6.3 outputs
Saving 1 charts
Dependency bar did not declare a repository. Assuming it exists in the charts directory
Deleting outdated charts

Helm 3.7.0 turned Assuming it exists in the charts directory into a panic.

Would it be possible to have a fix before the 12th January 2022 (date of the milestone) ?

@dastrobu @mitchello PRs is welcome. Thanks very much.

Can reproduce with given commands on v3.7.0.
$ helm dependency update foo

walk.go:74: found symbolic link in path: /home/abai/git/playground/foo/charts/bar resolves to /home/abai/git/playground/bar
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "openshift-helm-charts" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Dependency bar did not declare a repository. Assuming it exists in the charts directory
Deleting outdated charts
Could not verify foo/charts/bar for deletion: cannot load a directory (Skipping)panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x23c22ce]

goroutine 1 [running]:
helm.sh/helm/v3/pkg/chart.(*Chart).Name(...)
        helm.sh/helm/v3/pkg/chart/chart.go:76
helm.sh/helm/v3/pkg/downloader.(*Manager).safeMoveDeps(0xc0001a15f0, 0xc000114028, 0x1, 0x1, 0xc002863ed0, 0xd, 0xc002863ec0, 0xa, 0x0, 0x0)
        helm.sh/helm/v3/pkg/downloader/manager.go:452 +0x46e
helm.sh/helm/v3/pkg/downloader.(*Manager).downloadAll(0xc0001a15f0, 0xc000114028, 0x1, 0x1, 0x0, 0x0)
        helm.sh/helm/v3/pkg/downloader/manager.go:371 +0x671
helm.sh/helm/v3/pkg/downloader.(*Manager).Update(0xc0001a15f0, 0xc0001a15f0, 0x2)
        helm.sh/helm/v3/pkg/downloader/manager.go:201 +0x1b7
main.newDependencyUpdateCmd.func1(0xc000481680, 0xc00048a000, 0x1, 0x1, 0x0, 0x0)
        helm.sh/helm/v3/cmd/helm/dependency_update.go:74 +0x1da
github.com/spf13/cobra.(*Command).execute(0xc000481680, 0xc00021c200, 0x1, 0x1, 0xc000481680, 0xc00021c200)
        github.com/spf13/cobra@v1.2.1/command.go:856 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc000480c80, 0xc000115768, 0x1, 0xc000653f60)
        github.com/spf13/cobra@v1.2.1/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/cobra@v1.2.1/command.go:902
main.main()
        helm.sh/helm/v3/cmd/helm/helm.go:87 +0x27b

Hi I am facing a similar issue as well when using helm package . --dependency-update to resolve charts from oci (azure).
I have to use helm dependency update first to succeed with helm package ..
$ helm version
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}

$ helm package . --dependency-update
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x185a9ba]

goroutine 1 [running]:
helm.sh/helm/v3/internal/experimental/registry.(*Client).Pull(0x0, 0xc000e10d70, 0x43, 0x0, 0x0, 0x0, 0x43, 0xc0012435e0, 0x44f0a5)
	helm.sh/helm/v3/internal/experimental/registry/client.go:235 +0x21a
helm.sh/helm/v3/pkg/getter.(*OCIGetter).get(0xc000d28b40, 0xc000e72700, 0x34, 0xc001243678, 0xc000e72700, 0x34)
	helm.sh/helm/v3/pkg/getter/ocigetter.go:57 +0x23b
helm.sh/helm/v3/pkg/getter.(*OCIGetter).Get(0xc000d28b40, 0xc000e72700, 0x34, 0xc00064b900, 0x7, 0x8, 0xc000d28b40, 0x0, 0x0)
	helm.sh/helm/v3/pkg/getter/ocigetter.go:36 +0x77
helm.sh/helm/v3/pkg/downloader.(*ChartDownloader).DownloadTo(0xc001243a98, 0xc0003a07d0, 0x34, 0xc0003a0805, 0x14, 0xc00082ccf0, 0x2d, 0x8, 0x0, 0x0, ...)
	helm.sh/helm/v3/pkg/downloader/chart_downloader.go:99 +0x142
helm.sh/helm/v3/pkg/downloader.(*Manager).downloadAll(0xc000197290, 0xc000562000, 0x3, 0x3, 0x0, 0x0)
	helm.sh/helm/v3/pkg/downloader/manager.go:360 +0xd95
helm.sh/helm/v3/pkg/downloader.(*Manager).Update(0xc000197290, 0xc000197290, 0x225ac48)
	helm.sh/helm/v3/pkg/downloader/manager.go:201 +0x1b7
main.newPackageCmd.func1(0xc0002a8a00, 0xc000680ca0, 0x1, 0x2, 0x0, 0x0)
	helm.sh/helm/v3/cmd/helm/package.go:99 +0x431
github.com/spf13/cobra.(*Command).execute(0xc0002a8a00, 0xc000680c80, 0x2, 0x2, 0xc0002a8a00, 0xc000680c80)
	github.com/spf13/cobra@v1.2.1/command.go:856 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc00050ec80, 0xc0005b2370, 0x1, 0xc000563f60)
	github.com/spf13/cobra@v1.2.1/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.2.1/command.go:902
main.main()

$ helm dependency update
[...]
Update Complete. ⎈Happy Helming!⎈
Saving 3 charts
Downloading xxx from repo oci://xxx.azurecr.io/helm/xxx/main/
Pulled: xxx.azurecr.io/helm/xx/main/xxx:1000.0.0-preview.154
Digest: sha256:...
Downloading Downloading xxx from repo oci://xxx.azurecr.io/helm/xxx/main/
Pulled: xxx.azurecr.io/helm/xx/main/xxx:1000.0.0-preview.154
Digest: sha256:...
Downloading xxx from repo oci://xxx.azurecr.io/helm/xxx/main/
Pulled: xxx.azurecr.io/helm/xx/main/xxx:1000.0.0-preview.154
Digest: sha256:...
Deleting outdated charts

$ helm package .
Successfully packaged chart and saved it to: ...

Add a +1 here as well. Running into this while running -u or any dependency update:
bash-5.1# helm dep update sample-service/
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "evps-charts" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 3 charts
Downloading evps-common from repo https://charts.pkg.{redacted}.com
Downloading evps-php from repo https://charts.pkg.{redacted}.com
Downloading evps-nginx from repo https://charts.pkg.{redacted}.com
Deleting outdated charts
Could not verify sample-service/charts/.gitignore for deletion: file 'sample-service/charts/.gitignore' does not appear to be a gzipped archive; got 'application/octet-stream' (Skipping)panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1a20f8e]

goroutine 1 [running]:
helm.sh/helm/v3/pkg/chart.(*Chart).Name(...)
        helm.sh/helm/v3/pkg/chart/chart.go:76
helm.sh/helm/v3/pkg/downloader.(*Manager).safeMoveDeps(0xc000184fc0, 0xc003496000, 0x3, 0x3, 0xc000a3bcf8, 0x18, 0xc000a3bcc8, 0x15, 0x2d, 0xc001ed8bd0)
        helm.sh/helm/v3/pkg/downloader/manager.go:452 +0x46e
helm.sh/helm/v3/pkg/downloader.(*Manager).downloadAll(0xc000184fc0, 0xc003496000, 0x3, 0x3, 0x0, 0x0)
        helm.sh/helm/v3/pkg/downloader/manager.go:371 +0x671
helm.sh/helm/v3/pkg/downloader.(*Manager).Update(0xc000184fc0, 0xc000184fc0, 0x3)
        helm.sh/helm/v3/pkg/downloader/manager.go:201 +0x1b7
main.newDependencyUpdateCmd.func1(0xc00029b180, 0xc00045a6e0, 0x1, 0x1, 0x0, 0x0)
        helm.sh/helm/v3/cmd/helm/dependency_update.go:74 +0x1da
github.com/spf13/cobra.(*Command).execute(0xc00029b180, 0xc00045a6c0, 0x1, 0x1, 0xc00029b180, 0xc00045a6c0)
        github.com/spf13/cobra@v1.2.1/command.go:856 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc000523b80, 0xc0002f7018, 0x1, 0xc0005dff60)
        github.com/spf13/cobra@v1.2.1/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/cobra@v1.2.1/command.go:902
main.main()
        helm.sh/helm/v3/cmd/helm/helm.go:87 +0x27b

Here's the source: https://github.com/helm/helm/blob/9fafb4ad6811afb017cc464b630be2ff8390ac63/pkg/downloader/manager.go#L445-L459
I would look at how the existsInSourceDirectory map is populated - seems like some files that are not charts are no longer being populated in that list.
As @yxxhero mentioned previously, contributions to fix this are most welcome.


fix RWops read and write return values.

testfile program fails without this. Tested on i686-linux.

@madebr: Rebase your setup-sdl patch for one less testsuite failure

I didn't realize the SDL2 APIs returned number of elements

Yeah, inspired by fwrite(), not write(). I wasn't sad to change this for SDL3.


Property dependency emitter

This adds a new dependency emitter which reads the properties of a class and parses the @var annotation for class references. This might be useful for projects where the dependencies are not directly visible i.e. they use some sort of @Inject annotation.

hi, thanks a lot - supporting (some kind of) annotations would be a great addition.
i believe supporting @var and not @param / @return would confuse people so we should collect the most common annotations and support them all.
do you want to work on a more generic annotation dependency emitter?

if not, don't worry. I could take over and extend your code.

Hi, this sounds great, yes I will build a more generic "AnnotationDependencyEmitter" which can
detect also other annotations. I try to update the pull request in the next few days.

played a bit with finding all doc blocks, may it allows you to save some time :)
feel free to find a smarter way :)
Collector:
/** @return Doc[] */
    public function getDocComments(Node $ast) {

        $docBlocks = array_map(
            function(\PhpParser\Node $node) { return $node->getDocComment(); },
            AstHelper::walkNodes($ast, function(\PhpParser\Node $node) {
                return !!$node->getDocComment();
            })->getArrayCopy()
        );

        $buffer = [];
        foreach ($docBlocks as $blockDoc) {
            $buffer[spl_object_hash($blockDoc)] = $blockDoc;
        }

        return array_values($buffer);
    }

AstHelper:
public static function walkNodes($nodes, callable $cb, \ArrayObject $bag = null)
    {
        if (!$bag) {
            $bag = new \ArrayObject();
        }

        foreach ($nodes as $i => &$node) {
            if (is_array($node)) {
                static::walkNodes($node, $cb, $bag);
            } elseif ($node instanceof Node) {

                if ($cb($node)) {
                    $bag->append($node);
                }

                static::walkNodes(static::getSubNodes($node), $cb, $bag);
            }
        }

        return $bag;
    }

ok, so I have updated the AnnotationDependencyEmitter, at the momemt we collect only the annotations from properties and methods but @slde-flash maybe we should use your logic to get all doc comments inside a file regardless of the position?

i believe getting all annotations is the best we could do. it should be simple to create a list of dependency objects. the doc block contains it's position

I have updated the code to use the NodeTraverser from the PHP-Parser project to get all doc comments. Maybe you want to move the code to some helper if you want to be independent of the project but this is probably the most efficent way to get the nodes.


Error on clicking Project button on left menu bar.

https://github.com/NFDI4Chem/nmrxiv/issues/223

@NishaSharma14 @NRayya Could you please provide more details on how to recreate the issue ??

You click on "projects" folder :D . But it is working now

When clicking "projects", I am getting projects shared with me from super admin:

Those are public projects. Accessible to everyone. It just happened to be from the same user at the moment. It's not shared projects.


Fix/ensure secure connection

Continued work on #75

LGTM, I would suggest you just merge your fixes into the first commit

(btw, you can also force push to the original PR)


beets: fix absubmit deps

Motivation for this change
See #73589
TL;DR: Beets (tools/audio/beets) has a plugin called absubmit which relies on a statically linked binary provided by MusicBrainz.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @aszlig @domenkozar @pjones

Pinging @pjones again

Can someone please help me push this through, cc. @andir @pjones


⚠ Msite has degraded performance

In 7d39479, Msite ($MSITE_URL) experienced degraded performance:

HTTP code: 200
Response time: 15839 ms

Resolved: Msite performance has improved in 6059fae.


dynamic attributes accord props in component

I have a "invalid" variable that come from redux-form props,  it means the form is valid or not, I'd like to change the color in button styled component, but it does not work, in chrome developper tools i see working well with a normal 'button' but not with the Button styled component:
const Form = (props) => {

  const { handleSubmit, invalid, pristine, reset, submitting, t } = props;
  return (
    <form onSubmit={handleSubmit}>

        <Button type="submit" disabled={submitting}  primary={invalid ? "" : null} >
          Buton styled component does not work
        </Button>
        <button primary={invalid ? "" : null}>  button native works</button>

styled component:
export const Button = styled.button`
  font-size:  ${props => resolveSize(props)};
  padding: 0.25em 1em;
  border: solid 1px  ${(props) => {
      let color;
      if (props.invalid) {
        color = 'red';
      } else {
        color = '#ffffff';
      }
      return color;
  }};
`;

is possible in styled component modify the attributes on the fly , and the button be repainted  with another colors ?

You need to use the right property:
export const Button = styled.button`
  font-size:  ${props => resolveSize(props)};
  padding: 0.25em 1em;
  border: solid 1px  ${(props) => {
      let color;
      if (props.primary) {
        color = 'red';
      } else {
        color = '#ffffff';
      }
      return color;
  }};
`;

You can also shorten that way down:
export const Button = styled.button`
  font-size:  ${props => resolveSize(props)};
  padding: 0.25em 1em;
  border: solid 1px  ${(props) => props.primary ? 'red' : '#ffffff'};
`;

Nice, it's working, style component is so cool !


Fixed Gradle file

Gradle File Refactor

Replaced Compile with Implementation
Replace TestCompile with TestImplementation

Remove .idea files from commit


Class SplQueue not found

im using ZendFramework and trying to setup an Little League Page with your api.
sadly im getting this error:
Fatal error: Class 'League\Model\SplQueue' not found in /var/www/html/ZendTest/module/League/src/League/Model/riotapi.php on line 45
(i renamed the file to make it more easy to call)
 $this->shortLimitQueue = new SplQueue();-> isent found, he dosent know the class SqlQueue();
i just installed Curl and im running PHP 5.6.21, with Zend Engine v2.6.0 and xdebug v2.4.0 on an CentOS 6.3.
is there any other package i need that i maybe dident see?

update: with zend it works just fine :/ guess i gotta look why zend is crashing this.

solved it my self... way to solve: if you want to work with an namespace you gotta add an \ before SqlQueue(); -> $this->shortLimitQueue = new \SplQueue();
or add use SplQueue;


Explorer.EXE Server Execution Failed on Open in Windows Terminal in the Background of the Folder With Chinese Windows Username

Environment
Windows build number: 10.0.18363.1316
Windows Terminal version (if applicable): 1.5.10271.0

Any other software?

Steps to reproduce

Have a Chinese Username (That is, the folder in C:\User is in Chinese and I've tested account with non Chinese user folder but with the same Microsoft account and it is okay)
Go in any folder in explorer and open the context menu in the backround
Select "Open in Windows Terminal"

Expected behavior

A windows terminal prompt open with the directory as the current directory in explorer

(note that this screenshot is taken on another laptop with higher version of Windows so I cannot test if version actually affects the problem)
Actual behavior

A prompt opens and displays a server execution failed error

Thanks for the report! This is actually something that was being tracked in #8936, and was fixed in #8977. Thanks!
/dup #8936


Connexion does not convert query parameters with hyphens to underscores in python code

Description
Hi, I have a set of query parameters like the following:
openapi: '3.0.3'
# ...
components:
    parameters:
        CreatedByQuery:
            name: created-by
            in: query
            schema:
                type: string

I expected that when using this query parameter on an endpoint, that the call to the python controller function would have a created_by="someone" keyword argument as a snake_case representation of the kebab-case query (or even createdBy="someone" if we are in Javascript lowerCamelCase land) , but instead I simply get createdby="someone" without any spaces, which was unexpected!
Is this intended behaviour and is there any way to specify how the query names get converted to python kwarg names?
Additional info:
Output of the commands:

python --version -> Python 3.8.5
pip show connexion | grep "^Version\:" -> Version: 2.7.0

Hi @Liam-Deacon,
As mentioned in the documentation, all characters not allowed in Python are removed during parameter name sanitation.
There is however the undocumented pythonic_params argument, which allows to change the behavior to what you're looking for. We should add this to the documentation.
We also might want to make this the default behavior in the next major release.


hdfs fuzz test failed

test panicked: check next failed: output bs is None, we still have bytes to read, actions: [Seek(Start(196)), Seek(Start(77)), Next, Seek(Start(182)), Read(6), Seek(Current(-77)), Read(0), Next]

failures:
    services_hdfs::test_blocking_fuzz_part_reader

duplicated with https://github.com/apache/incubator-opendal/issues/2906


Dialog accept

In:
https://github.com/benlau/quickandroid/blob/master/QuickAndroid/Dialog.qml#L104
done(1) --> done(0)
you dont want to accept when click aside the dialog

oh, thx for pointing out. Fixed in master branch.

:D


Add nightly CI run

I'm impressed with github's UI hint when editing the cron schedule

(:07 because the docs suggest avoiding the top of the hour which has higher traffic)

Yeah GitHub is super user-friendly with it's cron format, hopefully more like that to come!


Change Picture Parameter for POST and PUT of Person #669

Expected Behaviour
Uploading an image URL or base 64 image data to profile_picture for the person, should replace the existing profile photo.
Actual Behaviour
Instead the base 64 image data is passed as the parameter _input_image, which gets uploaded to S3, then updating profile_picture with the final URL.
Steps to Reproduce
PUT https://api.staging.rollcall.io/api/v1/organizations/5/people/150
_input_image:"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICA....

@dalezak OK to launch without this fix for soft launch?


Dependabot is stuck in "checking now"

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
maven
Package manager version
maven
Language version
No response
Manifest location and content before the Dependabot update
No response
dependabot.yml content
version: 2
updates:

package-ecosystem: "maven"
directory: "/core-customize/bin/custom/bned/bnedcore"  # Directory where the pom.xml is located
schedule:
interval: "weekly"

open-pull-requests-limit: 5
target-branch: "develop"
commit-message:
  prefix: "deps"

Updated dependency
No response
What you expected to see, versus what you actually saw
dependabot detect dependency and create PR
but stuck in "checking now"
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs

Smallest manifest that reproduces the issue
No response

Can you share your pom file?


Fix FAQ accordion in Dark Mode

Description
Fix the accordion colour of FAQ page and change in to dark colour
Screenshots

Additional information
No response

I will do it. Please assign it to me.

Assign it  to me

@RajKanani1206 assigned you

@RajKanani1206 Any Progress?

Working on it. Will update progress soon.


[BUG] Website says module should be imported from mod.ts, when the entry file is set to mod.js

Description
The description at https://nest.land/package/maze_generator says that the package can be used with ...mod.ts:

even though the egg.json file says ...mod.js (and using the URL stated doesn't work):

Expected behavior
It should display exactly the same except with a .js at the end of the URL instead of .ts.
Desktop:

OS: Windows 10
Browser: Firefox 78
nest.land Version 0.1.2

We will be working on adapting the entry field in the front end in the near future

Actually might just do it today


feat(bump): bump terraform sources to v1.30.0

Signed-off-by: Christopher Paul Haar<EMAIL_ADDRESS>
Description of your changes

bump terraform sources to v1.30.0

Fixes #
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
create, update, delete Datasource, Dashboards

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Christopher Paul Haar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[VL] Refine shuffle writer return types and namespace

Currently, there are inconsistencies in the shuffle writer code related to namespaces and return types.

Namespace Usage: In some instances, the prefix velox:: is used, such as velox::RowVector. In others, there is no prefixed namespace, simply using RowVector. It would be better to consistently use the full namespace: facebook::velox::RowVector.
Return Types: Some parts of the code return arrow::Status or arrow::Result, while others throw exceptions. This inconsistency complicates our C++ unit tests, making it unclear whether to check for exceptions or inspect the returned status code. A uniform approach should be adopted, returning arrow::Status and arrow::Result where applicable.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3544_time.csv
log/native_master_10_26_2023_d3b91cda7_time.csv
difference
percentage

q1
33.94
36.45
2.514
107.41%

q2
24.83
25.07
0.240
100.97%

q3
40.54
40.23
-0.311
99.23%

q4
38.09
36.93
-1.164
96.94%

q5
71.20
71.27
0.073
100.10%

q6
8.84
7.21
-1.628
81.57%

q7
85.79
87.36
1.564
101.82%

q8
85.05
87.57
2.525
102.97%

q9
120.67
120.10
-0.561
99.54%

q10
52.27
51.67
-0.602
98.85%

q11
19.40
20.48
1.078
105.56%

q12
28.65
28.70
0.050
100.17%

q13
49.14
48.75
-0.387
99.21%

q14
18.01
20.14
2.129
111.82%

q15
34.90
33.99
-0.914
97.38%

q16
16.05
16.44
0.390
102.43%

q17
101.84
101.67
-0.174
99.83%

q18
149.05
148.54
-0.511
99.66%

q19
18.61
16.98
-1.632
91.23%

q20
31.63
31.88
0.242
100.77%

q21
223.36
223.59
0.232
100.10%

q22
13.53
13.21
-0.320
97.63%

total
1265.40
1268.23
2.832
100.22%


Minor refactoring on existing SCRAMSHA1AuthMechanism

This is a minor refactoring on existing SCRAMSHA1AuthMechanism. Common logic is moved to a new parent class SCRAMSHAAuthMechanism. Descendant classes SCRAMSHA1AuthMechanism and SCRAMSHA256AuthMechanism only customize the hash function to use.
This PR doesn't implement the handshake mentioned in #87.

Thanks for the contribution.
It looks good, I will merge it. But it'd be good to add a test using this new authentication method, even if some manual instructions are needed to setup the server.
Anyway, I think it's enough for the moment.

Thanks for the contribution.
It looks good, I will merge it. But it'd be good to add a test using this new authentication method, even if some manual instructions are needed to setup the server.
Anyway, I think it's enough for the moment.

The CI errors in Pharo 9 are unrelated to this change, and same tests run successfully in Pharo 8.

The CI errors in Pharo 9 are unrelated to this change, and same tests run successfully in Pharo 8.


404 Error after refresh

Probably Nginx only allows / route, but sub routes need to be allowed as well

Improve chart labels


A bad experience with 2FA recovery codes

I've been getting nagging emails and banners about setting up recovery codes. I had no interest in setting up recovery codes because I have my 2FA configured with redundancy, but rather than complain about it, I decided simply to generate the recovery codes to suppress the messaging.
When I did, I ran into additional issues. I generated the recovery codes and like a responsible person, I stored the codes in my password manager, a secure place I'd likely think to search if I needed them. I then closed my password manager and hit continue, only to find that I needed to burn one of the recovery codes to verify that I'd stored them safely.
So I unlocked my password manager again and cut out the last recovery code. Since it won't be usable again, I didn't want to leave it in the list of codes. I then closed my password manager, not realizing that it would clear the clipboard on close, so by the time I got back to my browser, the code was gone and was now irretrievable.
Thankfully, the workflow allowed me to regenerate the codes, so I went through the process again, this time being careful to paste the recovery code into the form before closing my password manager.
I've generated recovery codes for other services in the past, but I've never encountered this kind of experience. I've never had to use a recovery code to prove I knew how to save recovery codes. It feels a little heavy handed.
In any case, I'm all set up with recovery codes. I'm only posting this to capture a less than pleasant experience.

Thanks for the 'friction log' @jaraco -- I'm curious if you have any suggestions as to what would make this better besides removing the requirement to 'burn' a code.

Just chiming in: I've used services that require a user to "burn" a code to prove that they saved them correctly.
I agree that the current UX is tedious, though. A possible improvement: we could make the "burn" more upfront -- instead of being a separate view that we render after generating the codes, it should be part of a validation we perform when the user hits "Continue."

What about adding an ability to opt out of the recovery codes, with an acknowledgment of the consequences?
I did notice there's at least one workflow dependent on having requested recovery codes - the ability to enroll with a security device, so that requirement would need to be severed (or dependent on the opt out). I don't understand what the relationship is between having recovery codes on one auth method and enrolling with another auth method.

I think the problem with "acknowledgement of the consequences", is that I don't think you really can do that?
At the end of the day, the consequences are that you're more likely to require admin intervention to recover your account, unless we take a hard-line stance against helping to recover accounts from people who opted not to generate recovery codes. However, I have a hard time imagining us being willing to say that hey "Jason lost his codes, so now some number of widely used projects are just SOL and he needs to register a new user and possibly make whole new names for that project".
IOW, I think the consequences affect more people than just the user in question.

It's not been my experience that loss of 2FA means the backing resources are lost forever. My expectation (acknowledging that PyPI could have a different policy) would be that if someone lost their 2FA and recovery codes, they would lose any automated access to recover the account and they would need to escalate to manual intervention, which may take days or weeks and require any level of manual re-authentication, revocation of keys or access, payment of fees, etc.

Right, that's what I mean. If a user on PyPI loses their account, it requires the PyPI admins to take extra effort, that's the "manual intervention" part, so the consequences of a user not having recovery codes are not borne entirely by that user, but also by the PyPI admins themselves.


[ENH] Shared steps

Added support for shared steps, following the discussion in #16.

Codecov Report

Merging #19 into master will decrease coverage by 0.12%.
The diff coverage is 98.63%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   97.58%   97.45%   -0.13%
==========================================
  Files          13       13
  Lines         620      667      +47
  Branches      114      119       +5
==========================================
+ Hits          605      650      +45
- Misses         11       12       +1
- Partials        4        5       +1

Impacted Files
Coverage Δ

baikal/steps/expression.py
100% <100%> (ø)
:arrow_up:

baikal/_core/data_placeholder.py
100% <100%> (ø)
:arrow_up:

baikal/_core/model.py
100% <100%> (ø)
:arrow_up:

baikal/_core/digraph.py
97.22% <100%> (ø)
:arrow_up:

baikal/_core/step.py
98.61% <96.66%> (-1.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c013b...a9b0086. Read the comment docs.


Django 1.7 compatibility issues

Hi. I am trying to use Postal with Django 1.7, but I receive the following error:
ImportError: cannot import name simplejson
The issue is actually a django-piston one, but I think it would be better to django-postal not to depend on django-piston.

I have fixed the "import simplejson" issue in Pull Request #19 and I have added a few bunch features.
Is it possible for you to release a new version on PyPi?
Please note that my pull request does not close this issue because django-postal still depends on django-piston, and django-piston is still not compatible with Django>=1.7. I suggest to remove dependancy.

:+1:

Hi Francesco,
I will remove the django-piston dependency (or accept pull request) and release a new version next week , all going well.
Thanks
Michael

Hi Francesco,
I've uploaded a new version at https://pypi.python.org/pypi/django-postal/0.96
Thanks again for your contribution.
Michael


[Feature][Sort] Add IsNotNullOperator definition to support transform

Description
Add IsNotNullOperator definition to support transform
Use case
No response
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Same as https://github.com/apache/incubator-inlong/pull/3820.


945 improve large area utilities example

We have improved the large area utilities jupyter notebook with some examples of how to download and visualize the data once the previous utilities step has been performed.

Codecov Report
Base: 90.01% // Head: 89.99% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (0e77c48) compared to base (16e6214).
Patch has no changes to coverable lines.

:exclamation: Current head 0e77c48 differs from pull request most recent head 0988da7. Consider uploading reports for the commit 0988da7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
- Coverage    90.01%   89.99%   -0.03%
===========================================
  Files           54       54
  Lines         4779     4779
===========================================
- Hits          4302     4301       -1
- Misses         477      478       +1

Impacted Files
Coverage Δ

sentinelhub/data_collections.py
96.41% <0.00%> (-0.45%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Enable mypy --strict

This makes mypy --strict work with odxtools. It also fixes two real bugs found during this exercise.
Andreas Lauser<EMAIL_ADDRESS>on behalf of MBition GmbH.
Provider Information

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Error: Unexpected exception, ReferenceError: id is not defined

After updating with the latest commit, get an error.
Expected Behavior
Current Behavior
[2016-10-22 10:46:24.326] [ERROR] console - Unexpected exception: ReferenceError: id is not defined
[2016-10-22 10:46:24.327] [ERROR] console - Unexpected exception stack: ReferenceError: id is not defined
    at model.UX.userSchema.methods.updateHistory (/logic/superscript/lib/users.js:84:22)
    at /superscript/index.js:107:16

Possible Solution

    var cleanId = this.id.replace(/\W/g, '');

Steps to Reproduce (for bugs)

Your Environment

Version used: https://github.com/superscriptjs/superscript/commit/3ed767c80da5305e40731f92f26b660318c7c6bb
Environment name and version:
Server type and version: NodeJS 6.7
Operating System and version: Mac OSX

Dupe of #299 - closing. :)


windows-terminal-1-16: Add previous version 1.16.10261.0

What type of Apps related PR is this? (check all applicable)

[x] ✨ Add Manifest
[ ] ♻ Refactor
[ ] 🐛 Bug Fix
[ ] 👷 Optimization
[x] 🚩 Other

Description
This new manifest is the rename version of the windows-terminal to support the version 1.16 installation which is different of the new portable version available since the 1.17 version
Related Tickets & Documents
No
[optional] What gif/emoji best describes this PR or how it makes you feel?
:truck: :alien: :bookmark: :poop: :wastebasket: :pushpin:
Did you verify the followings
Add/Modify a description in the manifest?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Check URLs?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Update to the latest version?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Update Hashes?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Format the json manifest?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Did you identify extra steps
Notes in the manifest?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Dependencies?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Suggestions?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Pre-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Post-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

File persistence to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Your changes do not pass checks.
windows-terminal-1-16

[x] Description
[x] License
[x] Hashes
[ ] Checkver
[ ] Autoupdate

/verify

All changes look good.
Wait for review from human collaborators.
windows-terminal-1-16

[x] Description
[x] License
[x] Hashes


How to design the Options window.

I want the layout of the Options window to look something like the image below. Basically, the buttons at the bottom will be "Cancel," "Save," and on the left side of the window, "Defaults." "Save" takes the place of the "Apply" button in the image below.

Combine the Office Version drop-down box and the Office 365 checkbox into the same groupbox.

Use this tutorial for combobox contents:
https://msdn.microsoft.com/en-us/library/x8160f6f(v=vs.110).aspx

Open the Control Panel System Info page:
http://answers.microsoft.com/en-us/windows/forum/windows_xp-performance/how-can-i-open-control-panelsystem-and/a35df4dd-ce3c-47fc-a615-94595bcbc415
This is the command:
control /name microsoft.system

How to use Radio Buttons:
https://msdn.microsoft.com/en-us/library/6xtydwb3(v=vs.100).aspx


(QENG-2198) Convert PuppetDB acceptance over to vmpooler.

@waynr seems alright, lets see how it passes.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/5/
Test PASSed.

@kbarber looks like it passed without a problem, the current test run was triggered by the PR update when I pushed a commit with the comments you requested.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/6/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/7/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/17/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/18/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/19/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/20/
Test FAILed.

Looks like the completion of this is open-ended in regards to switching to vmpooler, so I'm going to close this PR for now.


[zpp-bits] Add new port

Add zpp-bits library port : https://github.com/eyalz800/zpp_bits

Whoops, not sure how I managed to miss that. It's fixed.


Add support for ensureType langlib function

Purpose

$Subject.

Fixes #25464
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@chiranSachintha can you please resolve the conflicts and update the PR? There could be some changes required due to the switch to Java 11 too.

@chiranSachintha There is a build failure with the latest master. Can you please check?


Int feature tracking ticket

Related

#1 (feature request), and
#624 (initial discussion).
#694 (abandoned attempt involving sign-magnitude representation),

Features

[ ] add, sub, mul, div #695
[ ] and, or, xor, not #697
[ ] gcd #698
[ ] mul_uint, div_uint #699
[ ] Encoding support (from_be_slice, from_le_slice)
[ ] xgcd
[ ] prop-tests (see also https://github.com/RustCrypto/crypto-bigint/pull/695#issuecomment-2438256609)

@tarcieri with #695 merged to signed-int, whats the plan for this feature? Specifically, will it be included in the next release? Could be helpful esp. because of  comparability other crates like elliptic-curves depending on crypto-bigint

@ycscaly yeah, we should be able to get at least a preliminary implementation into the release and then we can additively improve it.
I went ahead and added it to the list in #681


JSON-RPC APIs return incorrect results for system contracts.

Description

When call eth_getStorageAt or eth_getProof, the storage will be loaded from default trie_db.

eth_getStorageAt:
https://github.com/axonweb3/axon/blob/835cb164fae28f3d200fc2a0eb790bfedd426049/core/api/src/adapter.rs#L239
eth_getProof:
https://github.com/axonweb3/axon/blob/835cb164fae28f3d200fc2a0eb790bfedd426049/core/api/src/adapter.rs#L268

But data of system contracts are stored in another column family.
https://github.com/axonweb3/axon/blob/835cb164fae28f3d200fc2a0eb790bfedd426049/core/executor/src/system_contract/metadata/store.rs#L31-L33
https://github.com/axonweb3/axon/blob/835cb164fae28f3d200fc2a0eb790bfedd426049/core/executor/src/system_contract/image_cell/store.rs#L29-L31
https://github.com/axonweb3/axon/blob/835cb164fae28f3d200fc2a0eb790bfedd426049/core/executor/src/system_contract/ckb_light_client/store.rs#L22-L24

If I'm correct, data of system contracts could NOT be accessed or proved.
Application Scenarios

You can cheat users that data in metadata is not existed, even it really exists.
You can NOT prove data in metadata is real.

As the annotation below:
https://github.com/axonweb3/axon/blob/3dbfe5a515c8c46eec434d4584acec13b8d69649/core/executor/src/system_contract/metadata/store.rs#L19-L42
The metadata info stores in a column of RocksDB which is different from the trie. However, the metadata trie root is stored in the storage account with the following key-value pair.
https://github.com/axonweb3/axon/blob/3dbfe5a515c8c46eec434d4584acec13b8d69649/core/executor/src/system_contract/metadata/store.rs#L41-L42
https://github.com/axonweb3/axon/blob/3dbfe5a515c8c46eec434d4584acec13b8d69649/core/executor/src/system_contract/m.rs#L53
Besides, the key is a fixed string. So the proof can prove the metadata.

[ ]  axon_getMetadataStorageAt
[ ]  axon_getMetadataProof
[ ]  axon_getCkbLightClientStorageAt
[ ]  axon_getCkbLightClientProof (p.s. I didn't find any API for it.)
[ ]  axon_getImageCellStorageAt
[ ]  axon_getImageCellProof (p.s. Since contract address is not the same, account proof will be different. The code could be reused.)

I prefer these API, rather than provide two APIs axon_getSystemContractStorageAt and axon_getSystemContractProof.

[ ]   axon_getMetadataStorageAt
[ ]   axon_getMetadataProof
[ ]   axon_getCkbLightClientStorageAt
[ ]   axon_getCkbLightClientProof (p.s. I didn't find any API for it.)
[ ]   axon_getImageCellStorageAt
[ ]   axon_getImageCellProof (p.s. Since contract address is not the same, account proof will be different. The code could be reused.)

I prefer these API, rather than provide two APIs axon_getSystemContractStorageAt and axon_getSystemContractProof.

To be notice that the ckb light client and the image cell use a same column, so these two contracts should provide one pair interface like axon_getHeaderCellStorageAt and axon_getHeaderCellProof.


[BUG]build_model loads wrong state_dict

Short in short, in Windows, when initiating model using kelip.build_model('ViT-B/32'), sometimes it loads a wrong state_dict from the huggingface cache folder. Maybe I've downloaded too much stuff from Huggingface, especially many different clips?
Now I have to add a line to load the right state_dict: model.load_state_dict(torch.load(r"C:\Users\*****\.cache\huggingface\transformers\8f525db77e15271b26656a43682a71b06f93efef9b38f2e880117210d3f3be74.f30d465dc319e53701f2bea7f3e60214c3846cd9cc0b6b27445f121d496322f6"))
Maybe rename the model will help?

No. It won't solve the problem you reported.
'ViT-B/32' is used to indicate the name of revision, not the whole model name.
Please check this line: https://github.com/navervision/KELIP/blob/master/kelip/model_loader.py#L108-L111
We didn't try to test KELIP with any edition of Windows.

@Dango233
I had the similar problem in Ubuntu, and I fixed it by removing the huggingface cache folder and re-downloading the model checkpoints.
Can you try to remove the cache folder?
I haven't tried in Windows, tho.


Underlying type lost due to resolveAliases

Take a function m(int, int) (with underlying types int), build a tuple out of its arguments, you get [Integer/int,Integer/int], with element type Integer/int|Integer/int. Now call resolveAliases it will give you the first type Integer/int, and we then go an propagage the underlying type of the union (null) to the Integer/int type which is used by the method's parameter list, thus breaking it.

Fixed.


patch_content breaks Markdown structure when modifying heading sections

When using patch_content with any operation (append, prepend, or replace) to modify a heading section, it doesn't add necessary line breaks, which breaks the Markdown structure.
Example:
When applying:
{
  operation: "append",
  target_type: "heading",
  target: "test1",
  content: "baz"
}

to:
# test1
foo
# test2
bar

Current output:
# test1
foo
baz# test2
bar

Expected output:
# test1
foo
baz
# test2
bar

The function should automatically handle line breaks to preserve Markdown formatting for all operations.

We need to check what the API expects here and what is the behaviour of the API.

Yes, I agree. That's why I avoided creating a PR independently and raised this as an issue first.


Add generate PCH job

First PR. Wanted to know more about how the bridging PCH worked, so I started there.
Obviously need tests still, but does it look like I'm on the right track?

Definitely looks like you're on the right track, thanks for the contribution @cltnschlosser! Once you add some tests I think this is good to go.

Okay, tried to mimic the tests from the swift repo. Found some issues while I was doing it, fixed those up. Still not exactly the same as the original driver, but I've put FIXME comments where I know there is a difference. I think this is ready for a more full review now.

@swift-ci please test

@DougGregor Looking into OutputFileMap so I can understand what changes need to be made. Also haven't run this against a project, I'll look for a suitable project to test this. What's the best way to confirm that it's working correctly? Matching(Same commands and arguments) json-compilation-database?

@swift-ci please test

For testing a real project, I have a very ad hoc approach: I grab an iOS app (MovieSwiftUI is a favorite) and build it with the old driver; then I swap in the new driver, clean, and build again to see if the steps and command lines look right. It's not as scientific as comparing command lines exactly, but it establishes whether things seem to work end-to-end. There are other specific things to look for... for example, if the bridging header has code that produces a warning, does that show up in Xcode?

@swift-ci please test


Update Translation keys to JavaScript convention

Fixes:

user #575
admin #576
navigation #574
labels #577
messages #578
buttons #579
login #580

Changes proposed in this pull request:

The start of changing Translation keys from _ standard to camel case to work with JavaScript convention.

Note: @billybonks asked  me to submit a PR with what I had so far.
cc @HospitalRun/core-maintainers

Thanks for the PR @TheBanditDave !  It looks like according to the tests some of the translation labels are missing, so I assume you are still working on this one?

Hello @jkleinsc, your welcome! I am still working on it, I am planning to work on it today when I get home from work.

@TheBanditDave is this PR ready to go now?  Let me know if/when you are done.  Thanks!

If it's not then it's an untested part of the app

@jkleinsc I just pushed up the last changes for this PR. It was passing all the tests on my local environment. If there is any changes I need to make please let me know.

@TheBanditDave looks good to me!  Thanks for working through this PR.  I'll merge it in.


deployment: script and README.md

Now the script is located deployment/churn... and also a README is added.

Ok, new folder...


tdengine 1.14.0 plugins problem

Excuse me, where can I see which tdengien versions are officially supported at https://packages.emqx.net?

Only tdengine v 2.x

Only tdengine v 2.x
thanks


About Replica dataset

Hi, thanks for the great work. I am reading the code, and wondering if the models & data processing of Replica will be available.
Thank you.

@zhongyingji did you manage to train the model on Replica?

We have updated the replica data preparation in readme.


policy: Do not dump selections on logs

Dumping all security identities selected by a cached selectors can
make for huge logs if there are a thousands of PODs in the cluster,
so don't do it.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

test-me-please

Not sure why this wasn't automatically marked as ready-to-merge given the approval by all code owners and all required tests passing (/cc @aanm)
Manually marking as ready-to-merge.

Marking for v1.8 backports to simplify the backport of #16801.


display warning in file viewer if file is binary

@mishaschwartz you can target master for this one. Also, would be good to change the type to 'error', and also modify the comment on line 493 (right above the changed line).


[tool_crash] FileSystemException: Cannot delete file, OS Error: Permission denied, errno = 13

Command
flutter run -v

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot delete file, OS Error: Permission denied, errno = 13
#0      _File.throwIfError (dart:io/file_impl.dart:675:7)
#1      _File._deleteSync (dart:io/file_impl.dart:329:5)
#2      FileSystemEntity.deleteSync (dart:io/file_system_entity.dart:407:7)
#3      ForwardingFileSystemEntity.deleteSync (package:file/src/forwarding/forwarding_file_system_entity.dart:70:16)
#4      ForwardingFileSystemEntity.deleteSync (package:file/src/forwarding/forwarding_file_system_entity.dart:70:16)
#5      ErrorHandlingFileSystem.deleteIfExists (package:flutter_tools/src/base/error_handling_io.dart:80:12)
#6      Target.clearStamp (package:flutter_tools/src/build_system/build_system.dart:167:29)
#7      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:888:19)
<asynchronous suspension>
#8      Future.wait.<anonymous closure> (dart:async/future.dart:518:21)
<asynchronous suspension>
#9      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:799:32)
<asynchronous suspension>
#10     FlutterBuildSystem.buildIncremental (package:flutter_tools/src/build_system/build_system.dart:702:16)
<asynchronous suspension>
#11     ResidentRunner.runSourceGenerators (package:flutter_tools/src/resident_runner.dart:1277:18)
<asynchronous suspension>
#12     HotRunner.run (package:flutter_tools/src/run_hot.dart:401:7)
<asynchronous suspension>
#13     RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:808:27)
<asynchronous suspension>
#14     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1389:27)
<asynchronous suspension>
#15     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>

[✓] Flutter (Channel , 3.19.6, on Arch Linux 6.8.8-arch1-1, locale es_ES.UTF-8)
    • Flutter version 3.19.6 on channel  at /usr/lib/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision archlinuxaur (unknown (arch linux aur package)), 2038-01-19 03:14:08
    • Engine revision c4cd48e18646
    • Dart version 3.3.3
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /opt/android-sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /opt/android-sdk
    • ANDROID_SDK_ROOT = /opt/android-sdk
    • Java binary at: /opt/android-studio/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /usr/bin/google-chrome-stable

[✓] Linux toolchain - develop for Linux desktop
    • clang version 17.0.6
    • cmake version 3.29.2
    • ninja version 1.12.0
    • pkg-config version 2.1.1

[✓] Android Studio (version 2023.2)
    • Android Studio at /opt/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Arch Linux 6.8.8-arch1-1
    • Chrome (web)    • chrome • web-javascript • Google Chrome 124.0.6367.91

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel:
Creation framework version: archlinuxaur0000000000000000000000000000

Can you please check this to see if it can help to solve your case?


Diff frag type

This pull request is for searching MS2-MS2 or MS2-MS3 type of data, which is widely used in crosslinked and glycopeptides.

I think a more flexible experimental design would be nice. We could have 3 different experiment types: MS2, MS2/MS2, MS2/MS3. For each fragmentation type, you could choose a dissociation type. That way it would be simple to select MS2-HCD/MS3-LowCID, or whatever combination you want, rather than having certain combinations pre-loaded.
I like the idea of parent/child scans. I think we need to best determine how to report child scans (MS3, MS2 with different fragmentation, etc). If the scores are simply added to the parent scan, this affects FDR. Do we want to do this?

Good idea.


Migrate to io.github.play-swagger and update swagger-ui

Project com.iheart:sbt-play-swagger has been migrated to a new repository, so update to use the new name io.github.play-swagger:sbt-play-swagger:1.6.2. Also update org.webjars:swagger-ui from 4.14.3 to 5.10.3.

This branch is baking in staging and I'm trying it out, it seems to work fine and after some more validation i'll merge


Don't extend the last tab beyond its required size

Testing #114827

The close button is WAY too far away, and the huge underlying doesn't look good imo.

Duplicate of #113801

Duplicate of #113801


Damage control tracking issue for UX template semantic change in 1.3

In https://github.com/fusetools/uno/pull/1306, we refactored ux:Template to generate both a factory class (as it did before) as well as an instance class which, like ux:Class, would inherit from the element type the ux:Template was declared with. This was done in order to fix scoping issues with template children referencing named objects in their parent scopes (see https://github.com/fusetools/uno/issues/1303), as it allowed us to generate fields on the subclass that would allow it to look up objects in its parent scope correctly (this is how ux:Class does this).
While this doesn't seem like a big semantic change at first, it has some unintended consequences that have already been reported by some users with early 1.3 builds. The main issue this causes is that now we can't build templates out of sealed classes, eg. WhileString. Arguably these classes shouldn't be sealed in order to let users subclass them in UX with ux:Class for various reasons, but simply removing sealed may have some unintended consequences, as it basically expands our public API by making previously inaccessible internal/protected symbols effectively public via subclassing. Additionally, it's possible that we're doing some type comparisons currently assuming that the instance created from a template factory is of the exact type the template was declared with, which now isn't the case as it could be a subclass.
As it's too late to revert the change for 1.3, we should do a few things right away:

[ ] Document a workaround for issues that arise. For most issues this is going to be using ux:Template with a non-sealed container, eg. NodeGroup.
[ ] Investigate other ways of fixing the scoping problems than subclassing, to see if we can swap out the original fix with something else for 1.4.

If we're unable to find an alternative fix for the scoping issues, I think we should lean into the change by doing the following:

[ ] Vetting code for sealed classes that shouldn't be sealed to allow subclassing/templating. Since we can still mark methods as sealed, we should still attempt to hide internal implementation specifics in this way.
[ ] Documenting (where?) either that 1. generally protected parts of the fuselibs classes shouldn't be overridden unless explicitly stated otherwise, and/or 2. explicitly mark protected parts of fuselibs classes that shouldn't be overridden.
[ ] Vetting code for type checks/comparisons that assume a template produces a specific type, rather than a type or subtype of the template's declared type.

It looks like we're going to revert the breaking changes for 1.3 after all, so then the priority here becomes finding an alternative fix for https://github.com/fusetools/uno/issues/1303 only, and the rest of this ticket is invalid. Though between the issues here and https://github.com/fusetools/uno/issues/1358, tests should be added to prevent such breakages in the future.

I'm very opposed to #1363 as the only robust solution here long term is to do the template->class transform.

@Duckers: The only long-term robust solution for ux:Class is to no longer generate actual uno classes (to facilitate hot-patching on iOS, for instance), so in the long term these can share the mechanism. In the short term, this fixes real problems.

no longer valid as of https://github.com/fusetools/uno/pull/1364


DINO encoder

Dear authors:
Thank you for your great work! I wonder why you used DINOV1 instead DINOV2, which is more suitable for dense prediction task. Thank you!

Hi,
Thanks for your interest!
We used DINOv1 during our first development to align with the original LRM paper and to avoid introducing new factors. Now that the codebase is been verified in v1.0, we switch to DINOv2 to ensure its absolute performance.


Provide version 1 of the GNU GPL

Since this is the version of the licence that the code is provided under, it seems to make most sense to include this version rather than version 2.
Also, the old text had the wrong (outdated?) address for the Free Software Foundation.

Released 0.04, which switches to the MIT license.