[ACCUMULO-4787] Close input stream in AccumuloReplicaSystem

Contemplating how to make a test for this, but pushing this build out to our dev system has removed the CLOSE_WAIT connections.

@adamjshook Were there additional changes, unrelated to the original issue also done in your updated commits? It seems like a larger change was made, but I'm having trouble following it.

@ctubbsii The try-with-resources caused an indentation change that makes it look larger and I moved a large block of code into a new method to make it more readable.  The summary of the changes are:

Added a try-with-resources in the replicateRFiles and replicateLogs
Moved processing of the WAL header into getWalStream.
Moving the exceptions that would be thrown from getInputStream here and here down to the bottom of the try-with-resources.
Refactoring this block of code into a processBatches method.

Ah, it was the relocation to a new method that screwed me up. If you ignore whitespace, the regular diff without that change is much better. To ignore whitespace in the GitHub.com view, add ?w=1 to the end of the diff URL.

To do a diff on the command-line with git, just do: git diff --ignore-all-space

To ignore whitespace in the GitHub.com view, add ?w=1 to the end of the diff URL.

TIL 🙌

Any more changes left for this or are we good to merge?

@adamjshook I'd like to update my review, but with the code relocations, I'm still having trouble following it. If you could update the code to undo the relocations, so a clean diff, ignoring whitespace, can be viewed, I could update my review.

@ctubbsii @keith-turner Undo on the code relocations and applied Keith's suggestion to refactor out the FSDataInputStream.  Back to you!

Is there a particular process for merging in fixes and applying them to other release lines?

Created ACCUMULO-4815 to track some cleanup efforts.

Is there a particular process for merging in fixes and applying them to other release lines?

No hard+fast rules. General recommendation is to apply it to the oldest branch and then merge it through newer release lines.

@joshelser Thanks!  Looks like I don't have write access here on Github.  Is that a mistake or should I apply it via gitbox.apache.org.

Try  following https://gitbox.apache.org/setup/ @adamjshook

Created follow-on issue for the potentially unclosed crypto stream from DfsLogger.readHeaderAndReturnStream https://issues.apache.org/jira/browse/ACCUMULO-4816


feat: make frontend normalize line endings to LF

To eliminate parsing differences between Windows and other platforms, the frontend now normalizes all CRLF line endings to LF, like in Rust (issue).
Effects:

Lake's hashes already use normalized line endings. This change makes the hashes be faithful to what Lean sees.
Docstrings are affected by line endings. In particular, this fixes #guard_msgs failing multiline tests for Windows users using CRLF.
Now strings don't have different lengths depending on the platform. Before this PR, the following theorem is true for LF and false for CRLF files.

example : "
".length = 1 := rfl

Note: the normalization will take \r\r\n and turn it into \r\n. In the elaborator, we reject loose \r's that appear in whitespace. Rust instead takes the approach of making the normalization routine fail. They do this so that there's no downstream confusion about any \r\n that appears.

Now that we have position termination proofs in core (e.g., termination_by text.utf8ByteSize - pos.byteIdx), it may be worth supporting these automatically through decreasing_trivial. For example, I did this over in my Partax library (code).


U — [DevTools] Minor tools, Fx 75 tasks

Trello
https://trello.com/c/IzhhiELs/252-minor-tools-eg-ruler-color-picker-fx-75
Acceptance criteria

[x] Allow resizing the area selected by measuring tool via mouse

Thanks to Sebastian for updating Measuring a portion of the page.


Challenge Complete page location

Fixes #283

based on the recent discussion in issue #283, the challenge completion page will remain after the genesis-terminal Challenge.

Hey @vinayaksh42 if you wanna open this back up, Christoph suggested moving the page and provided additional copy.

Check his latest comments in https://github.com/saving-satoshi/saving-satoshi/issues/283

Hey @vinayaksh42 if you wanna open this back up, Christoph suggested moving the page and provided additional copy.

I think i misunderstood the comment, I have reopened the PR

Ooof I'm sorry. I got confused as well. His updates in figma only require copy changes. We can handle that in a separate PR.


virt-api: request/limits can now be used with CPU/Memory hotplug

What this PR does / why we need it:
The limitation in configuring requests/limits when using CPU/Memory hotplug has no real technical roadblock and as such can be removed to have more freedom when defining a VM.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

Requests/Limits can now be configured when using CPU/Memory hotplug

/cc @mhenriks

/lgtm
/approve

/retest-required

Love PRs that just delete code!

@acardace @mhenriks Please provide an example of how this should work, I fail to understand this. Afaik there was a real usability /& correctness issue that caused us to block requests/limits!

@xpivarc Perhaps its the case where you for some reason define liveUpdateFeatures, but at the same time you use CPU and mem requests instead of using VM CPU/mem topology. In such case every change you do afterwards in the VM CPU/mem topology should be staged to the next power cycle.

Well if you define the liveUpdateFeatures then the changes will not be staged or?

@acardace @mhenriks please look into reverting this PR or creating a blocker issue for the next release to sort out all possible technical implications this has.
As an example currently, one VM spec can have 2 meanings, depending if the VM was started or hotpluged.


Replace queue of future messages with some other catch-up mechanism

#124 (for #122) added a queue of messages for future instance, but opens up lots of DOS risk (#12) because they can't be validated. This should be removed before production use.
Brief thoughts about what to do instead:

Nodes can queue the messages that they have received and validated for the current instance and make them available for fetching by lagging nodes, until the instance completes. After a decision, the finality certificate can catch a node up.
Nodes might be able to skip rounds in a multi-round evaluation by fetching/observing evidence that a strong quorum of other nodes have reached a particular round. The evidence attached to a CONVERGE message is close to this, but not quite right yet. Perhaps we can tweak it to make it self-contained. Then we'll only need refetching of messages for a single round.

An alternative to the in-instance catchup mechanism could be speculatively starting a new instance.
Handling it without power table delay is challenging, as we would need to be able to re-verify all decisions we verified speculatively when the power table is available.
With power table delay, we could passively listen, progressing through stages and rounds until we 1. get confirmation that the last instance was completed successfully and 2. we know what chain we want to vote on.

@Kubuxu and I discussed, and concluded that with a power table delay we don't need speculative execution. We can just check signatures and queue messages.

See #151. These probably need to be done together:

Implement delayed power tables, maintaining a list of the table for the most recent N instances
Use these power tables, with offset, instead of getting from the host with every new chain?

Perhaps receive resulting power table in response to notifying a decision

Drop messages for which the power table isn't available (10 instances ahead of current), thus bounding the queue

The host should fetch finality certificates to skip over instances to get within 10 of the currently executing one.

AI captured in #169  - @anorth ok for us to close?

This issue is about messages for future instances, not future rounds in this instance. But it's tightly coupled to #151 so I'll expect scope there and close this one.


Automated Package Upgrade

:tada: This PR is included in version 1.3.37 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Input focusOutlineColor property doesn't work

Description
focusOutlineColor property of Input component does not work, in the below example it should be black, but it is still in primary color
CodeSandbox/Snack link
https://codesandbox.io/s/clever-bird-kx7p1x
Steps to reproduce
No response
NativeBase Version
3.4.3
Platform

[ ] Android
[ ] CRA
[ ] Expo
[ ] iOS
[ ] Next

Other Platform
No response
Additional Information
No response

Hi @JohnBerd, It's working for me. you can check here.

Thanks for your quick reply @Viraj-10.
In your example, it seems not working on IOS.

You can try _focused={{borderColor: 'desiredColor'}}

Hi @JohnBerd, sorry but currently we are finding out a solution for getting this work with IOS and Android. We know this is a difference in Design for native devices and the web. adding borderWidth 2px when input is in focus state and 1px when it's normal state causes a shift in layout of 1px when input is focused. react-native still has an issue with box-shadow. One solution was to wrap it in a Box with a transparent 1px border and then change its colour when the state is focused but it is a hack which we might go for if there is no better solution. We are open to discussion.

Hi @Viraj-10,
Happy to know it is actually a bug and you are working on it, the @otavioq solution works so maybe it would be a good idea to implement the same behavior for the selectionColor property.
We can maybe let this issue open awaiting for a PR to fix this


MSID: 89679 Version: 1 DOI: 2<IP_ADDRESS>0653

"msas": "Biochemistry and Chemical Biology", "Computational and Systems Biology"
"msid": "89679"
"preprintDoi": "10.1101/2<IP_ADDRESS>0653"
"Reviewed Preprint posted": "2023-08-24"
"Sent for peer review": "2023-06-13"
"Posted to bioRxiv": "2023-07-29" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>0653v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[ ] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=89679)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/89679/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>0653)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[x] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/89679/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/89679)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/89679

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/89679

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/89679/v1/89679-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/89679)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

The fonts don't match between equation images and the HTML (because the glyphs are different in the PDF and the equations are images taken from the PDF):

Short of getting bioRxiv (or Exeter) to capture the specific glyphs also as images, there's nothing we can do here, and since it's in the original on bioRxiv I think it's fine.
However there are issues with table and figure citations throughout. Here are some examples:

And also, as in the last screenshot above, the reference citation style is incorrect throughout (should be in brackets).
@JGilbert-eLife do you know if the reference citation style is an issue with our overleaf template? Or is this simply a mistake from the authors?
@acollings do you think it's worth asking the authors about these issues to do with citations (or at least just the broken figure/table ones)?

Not sure how to classify the reference thing - the template allows both styles, but clearly the authors have picked the wrong one here.

Good to know - thanks James.

I'll ask the authors: thanks!

@acollings have we heard back from the authors of this one at all?

Hi @fred-atherden thanks for checking. The authors seem very confused, I'm afraid. They emailed a new PDF to me, but didn't update the preprint. I explained again they need to update the preprint 11 days ago, but haven't heard more. I'm not sure what to do next: should we proceed and publish despite the issues? Or I can send you the PDF they sent, if it helps?

Thanks @acollings. Would it be OK to try and explain what we need them to do again and if that fails we'll explore other options?
I think it'd be better to get Exeter to typeset this one than publish as is, but obviously it'd be preferable of we use a bioRxiv version.

Yep, will do now @fred-atherden

Hi @fred-atherden, the new preprint is up! https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>0653v2

Nice one - thanks Andy! I'll keep an eye out for the MECA package appearing.

MECA package available at s3://transfers-elife/biorxiv_Current_Content/September_2023/07_Sep_23_Batch_1727/c950c731-6d9e-1014-b9d8-bf71361d0298.meca

First author is noted as corresponding and has another authors email as a result. I think this is a mistake on the authors side, and given the delays already and the issues with getting this fixed I think we should live with it.


Clarified use case for Add-BindingRedirect

Docs Build status updates of commit e9a0d3f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/ps-reference/ps-ref-add-bindingredirect.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Expose "testPath" for "setup*File"

Feature request
What is the current behavior?
Currently, testPath is passed to JasmineReporter (https://github.com/facebook/jest/blob/v18.1.0/packages/jest-jasmine2/src/index.js#L37). However, it's quite tricky/unsafe to access it in setupFile/setupTestFrameworkScriptFile (to use in custom reporters for example):
function getTestPath() {
  if (Symbol && typeof Symbol.for === 'function') {
    var globalStateKey = Symbol.for('$$jest-matchers-object');
    if (globalStateKey) {
      var globalState = global[globalStateKey];
      if (globalState) {
        var state = globalState.state;
        if (state) {
          return state.testPath;
        }
      }
    }
  }
}

It'd be great if testPath would be exposed in more standard way. Thanks.

I'd love to have access to as much relevant info about the currently executing test(s) as possible.

We prefer not to expose this there. If you need custom setup, use beforeAll in your specific test file.


Support mhchem in KaTeX core

This PR supports mhchem as a core part of KaTeX. I offer this as an alternative to PR #1436.
Towards this purpose, I have modified the code from https://github.com/mhchem/MathJax-mhchem/blob/master/unpacked/mhchem.js in several ways, listed below. The first four items enable KaTeX to run mhchem. Only item 4 changes mhchem behavior. Item 5 tweaks the vertical alignment of dashed bonds and items 7 through 14 enable the code to pass the KaTeX linter.

Changed the interface to mhchem so that it runs within KaTeX rather than as an extension to MathJax.
Replaced \rlap and \llap with \mathrlap and \mathllap.
Modified four lines of code in order to change \raise to \raisebox.
Simplified the code for the reaction arrows, since KaTeX provides a full set of extensible arrows and work around hacks are not needed.
Slightly raised the vertical alignment of \tripledash, to address an earlier comment.
Included a preamble that is meant to address licensing issues.
Changed indentation to 4 spaces and max line length to 80. Prettier did most of this work.
Changed each var to either const or let.
eslint found ~50 unnecessary escapes in RegEx literals. I removed them.
At each for (key in foo) statement, I added a condition that guards us from calling a key that might be attached to the prototype instead of the object.
Five variable declarations were located within a case. I moved those declarations above the switch statement.
throw statements now throw a KaTeX `ParseError` object instead of plain text.
There were a few locations where Prettier did not get line length below the limit. I
made some minor rearrangements, mostly of comments, at those locations. Some of
those long lines were @type statements apparently there to enable JSDoc. Rather than mangle just a few of the long @type lines, I removed all the @type lines.
I disabled eslint at a few lines, (a) to allow an Array.isArray() call, (b) to allow a while (true) statement, and (c) to avoid messing with some long complicated RegEx literals.

I’ve added only minimal documentation to this repo. For more complete explanation, I have a link to the mhchem Manual. I plan to write a PR to that page so that it acknowledges KaTeX as well as MathJax.
The jest parser tests are derived from https://github.com/mhchem/MathJax-mhchem/blob/master/tests/mhchem-tests.js. I also wrote a few jest build tests that will get us coverage of some arrow SVGs.
I’ll add screenshot tests for the reaction arrows and bonds that KaTeX renders slightly differently than MathJax. @ylemkimon, per your comment, I have revised one arrow SVG so that its "second brush stroke" (Ref) applies to the correct arrow shaft.
I invite comments from everyone, but especially from @mhchem.

RE: the circleci failure: I'm the wrong person to edit a bash script. If someone can correct that, feel free.

@ronkok It seems that this condition $CIRCLE_PROJECT_USERNAME != "Khan" is not longer valid since this repo was moved to its own KaTeX project? So I think you could try simply rewriting "Khan" to "KaTeX" and see whether it resolves it?

try simply rewriting "Khan" to "KaTeX"

Yes, I also read the error message. But I have no idea where that string should be modified. Rather than have me blunder about trying to fix something that I don't understand, I'll wait for someone who knows what they are doing.

Hi Ron,
it seems you've put a lot of work into this. Some changes are definitely necessary, come are good, some are personal taste, some will make my life more complicated. I would prefer to keep the mhchem core aligned between different MathJax and KaTeX. With things like 'different linebreaks' you make this task very hard. Similar argument for const and let. I am not sure I want to change that for MathJax too, because that would exclude IE<11. This might not be a priority any more, but that was my reason to use var. (Yes, really, MathJax/mhchem runs in IE 6. ☺)
So, again, I'd prefer a (first) PR where the core mhchem can be kept identical between MathJax and KaTeX. This makes it easier to keep mhchem working identical everywhere. From there, we can discuss improvements like shorter lines or const.

I'd be okay with that approach (I maintain just one version, you converting it on every change).
I am not so sure about every change. For instance, 9, I find it much less error-prone to say \. in a regular expression if I mean a literal dot, even if I could omit the backslash in some instances. The backslash doesn't hurt, decrease performance or anything. 10, I have to look into it. I'd like to do a performance measurement to see how this additional condition in the for loop works. 11 the same, I have to look into it. Contrary to some other coding styles, I'd like to have variable declarations visible on the same screen, I know that the position of the declaration does not change anything. But I am not sure we should do the discussions here at this point in time.
Let's discuss the fundamental idea first: KaTeX using an adapted version of mhchem core, where every change has to be re-done by hand.

@ronkok thanks for exploring an alternative approach for mhchem support.  My preference would be for #1436.  It sounds like it'll be easier to keep it in sync but more importantly keeping it as an extension saves bytes.  My hope is that eventually we end up with more extensions like it and a smaller core so that users can pick and choose what they want.


Please provide documentation

I count 21 editable parameters/settings on the Job Queue Entry Card. 14 if you don't count the "Run on <day of week." checkboxes.
I count 0 named parameters that are identified or explained on this documentation page. I am a user/developer, and I need to know the implication and use of the "Maximum No. of Attempts to Run" parameter, so I can implement it properly. If there is to be documentation, please provide it down to the level of editable parameters, so that users can know how to properly configure their systems.
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0fcb95cd-fd17-03c1-d52b-368c37671df9
Version Independent ID: 2d7b250b-a699-f4bd-14f6-4496ec33cd42
Content: Schedule jobs to run automatically - Business Central
Content Source: business-central/admin-job-queues-schedule-tasks.md
Service: dynamics365-business-central
GitHub Login: @edupont04
Microsoft Alias: edupont

Hello buzzwick,
Thank you for your feedback! In Business Central, the explanation of each field in a given page is implemented as a tooltip, so that you can find out what the field does right there in the product. That is why you rarely find descriptions of fields in the docs.
To read a tooltip, either hover over the name of a field, or choose the name of the field. Specifically for the Max No. of Attempts to Run field, this is the description:
"Specifies how many times a job queue task should be rerun after a job queue fails to run. This is useful for situations in which a task might be unresponsive. For example, a task might be unresponsive because it depends on an external resource that is not always available."

Aha! Wonderful! Okay, this is very helpful because I will stop looking in the wrong places.
One feature request:  Someone decided that a Tool Tip should disappear just before it has been visible long enough to read these helpful messages. Is there a way to lengthen that setting, or to keep Tool Tips in place until the cursor is moved off the field?
Thanks again,
David
From: Eva Dupont<EMAIL_ADDRESS>Sent: Friday, November 30, 2018 5:48 AM
To: MicrosoftDocs/dynamics365smb-docs<EMAIL_ADDRESS>Cc: David Baldwin<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/dynamics365smb-docs] Please provide documentation (#72)
Hello buzzwick,
Thank you for your feedback! In Business Central, the explanation of each field in a given page is implemented as a tooltip, so that you can find out what the field does right there in the product. That is why you rarely find descriptions of fields in the docs.
To read a tooltip, either hover over the name of a field, or choose the name of the field. Specifically for the Max No. of Attempts to Run field, this is the description:
"Specifies how many times a job queue task should be rerun after a job queue fails to run. This is useful for situations in which a task might be unresponsive. For example, a task might be unresponsive because it depends on an external resource that is not always available."
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/dynamics365smb-docs/issues/72#issuecomment-443165762, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AmYcolso4Z9EZkgIFWK9XnvY0ca_i_sbks5u0QzfgaJpZM4Y54Ay.

Hi David,
I'm happy to help - tooltips are a bit problematic, I agree, but that's the implementation we have currently. One of the problems is that you can only view the tooltip if you use a mouse device or a touch screen, not if you navigate Business Central using a keyboard.
Anyway, here is how to keep a tooltip open long enough to actually read it:
In a page like the Customer Card, simply choose the name of the field. That leaves the tooltip open until you leave the field again.
In a list such as the Customers list, or the lines in a document such as a sales order, you have to choose the little drop-down menu to the right of the name of the column and then choose the "What's this?" menu item.
I'm going to add these tips to the Help so that other people also get the benefit of our tooltips.

Hi David,
With your mouse, click the name of the field. That opens the tooltip and leves it open until you move on to another field on that page.

Nope, sorry, that is not what I am seeing. This is NAV 2018. Clicking on the field does nothing if the tool tip is not visible and makes it go away if it is.  Are you seeing this behavior in a version you are running?

Eva,
Not a problem at all. I get it. We are testing with Dynamics 365 now, so going forward we will have the benefit of that functionality. It's good to hear that someone picked this up in the transition from NAV to 365.
Thanks so much for your responsiveness!


-Property is case-sensitive

I'm not sure if this is intentional, but reporting it as it feels like a step backwards vs ActiveDirectory: Requesting specific attributes with -Property is case-sensitive in PSOpenAD. With #41 merged, it's also not always obvious what the correct casing is, particularly for more complex attribute names like ms-Mcs-AdmPwd.
eg
Get-OpenADComputer testcomputer -Property Name
# Get-OpenADComputer: One or more properties for computer are not valid: 'Name'

vs Get-OpenADComputer testcomputer -Property name and Get-ADComputer testcomputer -Property Name working.

Scratch that sorry I had an older version installed on my test host. I can see this problem and will dig deeper as it should not be case sensitive.

The PR https://github.com/jborean93/PSOpenAD/pull/52 should fix this to go back to the case insensitive comparisons.

Yep, that's fixed it for me. Thanks very much!


ModuleNotFoundError: No module named 'mmcv_custom'

Thank you for publishing the great work! Please check the following error in xcit/detection/backbone/xcit.py file:
from mmcv_custom import load_checkpoint
ModuleNotFoundError: No module named 'mmcv_custom'

Probably you forgot to add this folder: https://github.com/SwinTransformer/Swin-Transformer-Object-Detection/tree/master/mmcv_custom
Thanks again!

Thanks for spotting this problem ! It is suppsed to be fixed now (https://github.com/facebookresearch/xcit/commit/3bd7bf7f483aea18c63fbc242e4f27d3da486c17).


Fix copy text in webviews

Cody part: https://github.com/sourcegraph/cody/pull/5236
Test plan

Ask chat to generate a piece of code
Click "Copy Code" on the generated code block
Verify that the code has been copied (try to paste it)

Replaced by https://github.com/sourcegraph/jetbrains/pull/2063


Fix walkback in StsAdminShell when versioning all packages (issue #2).

Also added ./Repository to .gitignore file.
My first contribution to the Dolphin project; feel free to accept or ignore; feedback welcome on the process and content.

I probably need to work on my Git process. I think I should have done a fork for each change since I now have two fixes in the master...

I probably need to work on my Git process. I think I should have done a fork for each change since I now have two fixes in the master...

I'm going to close this request and create a new pull request from a branch that isolates the changes for each issue.

I'm going to close this request and create a new pull request from a branch that isolates the changes for each issue.


tests/lib/spsc_pbuf/libraries.spsc_pbuf on nucleo_wb55rg failed

Describe the bug
Running the testcase tests/lib/spsc_pbuf/libraries.spsc_pbuf on the nucleo_wb55rg board fails on the test_spsc_pbuf.test_stress testcase with twister or west
-->    specific commit from which the test is failing : d0e58ad0a6d4e05d7a1016b0a94af1d2d0937a12
To Reproduce
Steps to reproduce the behavior:

twister --device-testing --device-serial /dev/ttyACM0 --disable-suite-name-check -p nucleo_wb55rg --test tests/lib/spsc_pbuf/libraries.spsc_pbuf
OR
west build -p always -b nucleo_wl55jc tests/lib/spsc_pbuf
west flash

Expected behavior
START - test_stress
Reading from an interrupt, writing from a thread
0% remaining:0 ms mss
Ztress execution report:
context 0:
- executed:37476, preempted:0
- ticks initial:4, optimized:4
context 1:
- executed:22151, preempted:1713
- ticks initial:4, optimized:4
Average CPU load:26%, measurements:150
Writes:33264 failures: 11
Writing from an interrupt, reading from a thread
100% remaining:14000 ms
100% remaining:13000 ms
100% remaining:12000 ms
100% remaining:11000 ms
100% remaining:10000 ms
100% remaining:9000 ms
Ztress execution report:
context 0:
- executed:15746, preempted:0
- ticks initial:4, optimized:4
context 1:
- executed:8932, preempted:1000
- ticks initial:4, optimized:4
Average CPU load:28%, measurements:63
Writes:53866 failures: 3057
PASS - test_stress in 21.385 seconds

Impact
CI failure
Logs and console output
START - test_stress
Reading from an interrupt, writing from a thread
0% remaining:0 ms mss
Ztress execution report:
         context 0:
                 - executed:37476, preempted:0
                 - ticks initial:4, optimized:4
         context 1:
                 - executed:22101, preempted:1652
                 - ticks initial:4, optimized:4
        Average CPU load:26%, measurements:150
Writes:33088 failures: 7
Writing from an interrupt, reading from a thread
100% remaining:13000 ms
    Assertion failed at WEST_TOPDIR/zephyr/tests/lib/spsc_pbuf/src/main.c:439: stress_read: check_buffer(buf, len, ctx->read_cnt) is non-zero

 FAIL - test_stress in 17.890 seconds

Environment (please complete the following information):

OS: ubuntu
Toolchain 0.15.2
Commit SHA:  7bdae081e3c0ad66e7edff0a03cfdcca2630672d

Additional context
Test is NOT failing with another stm32 board like nucleo_wl55jc

I do not have the board to reproduce this problem. It's difficult to understand why the problem is related to https://github.com/zephyrproject-rtos/zephyr/commit/d0e58ad0a6d4e05d7a1016b0a94af1d2d0937a12 since the test seems to work on other boards (nucleo_wl55jc). More information is needed.


[FEAT] fuzzing tests

Is your feature request related to a problem?
tsduck might crash in case of non-expected input data
Proposed solution:
make fuzzing test to emulate broken data/garbage
Alternatives:
use static analyzers (might help in some cases, but not for all)
Additional information:
I've developed very simple PoC quality fuzzing tests, it's here https://github.com/svlobanov/tsduck-fuzzing , to run the tests, it is required to put some realistic ts dump of SPTS/MPTS normal DVB/ATSC signal (50-500MB+ is the best choice) with the name "in.ts" and the run the tests via make test
Points to discuss:

It would be nice to implement fuzzing tests as a part of tsduck or tsuck-tests repo.
Fuzzing might be an option for normal tests of tsduck-tests (use the same dumps (after fuzzing) and the same tsduck commands, but check only for segfaults, aborts, etc and timeouts). Right now I'm working on this
Fuzzing tests require a lot of computation time (the more the better) so it can't be a part of free github actions CI (or maybe very limited - e.g. use just one seed value)
I would like to use GNU "timeout" tool to catch infinite loops like #1398, but I'm not sure if it's OK to use non-posix tools. Please suggest
I have a prototype for fuzzing ts files written in bash, it works but it is extremely slow due to bash limitations so it is not realistic to write everything in bash like it's done in tsduck-tests repo. I don't want to write fuzzing tool in python, perl and similar languages because it will cause compatibility headache. As I can see you support a lot of OS so I think pure C99 + bash is a good choice
Currently I don't use any framework for tsduck fuzzing so I'm not sure if you like the idea of implementation from scratch

Hi @svlobanov
Thank you for this excellent idea. Let me share some thoughts and then let's see how we can proceed.
Doing fuzzing tests means two things: 1) generating corrupted input data, 2) running tests and handling errors. This is roughly what you already do in your tsduck-fuzzing project with 1) fuzzing.c and 2) fuzzing.sh. Let's see the two steps separately.
Step 1: generating corrupted TS files
Generating corrupted TS files, based on selected criteria, can be useful to anyone. It can be used to stress the resistance of TSDuck but it can also be useful to test a set-top box, a TV set, any intermediate reception equipment or media tools.
So, it could be a good idea to add in TSDuck a tsfuzz tool to corrupt an existing TS file, just like your fuzzing.c. We need to specify a list of features / options for that tool. I am not sure to fully understand all command line parameters of your fuzzing.c program.
The tsfuzz tool should be developed in C++17, just like the rest of TSDuck. If you agree, I can provide a skeleton of tool with basic features (command line options, reading / modifying a TS file). Then, you could update it with new ideas, new options, new TS corruptions, using pull requests.
Step 2: running fuzzing tests
This part is about TSDuck testing and would use the tsfuzz tool. As you mention, these tests should be part of the tsduck-test repo but shall not be run on any push or PR.
First, because they would use too many resources, as you pointed out.
But, second, the automated test suite only contains reproducible tests, tests which do the same thing, all the time, on all platforms. By design, fuzzing tests are random and not reproducible.
In the tsduck-test repo, there is an extra directory which contains tests which are not part of the automated test suite, mainly because they need some form of manual operation or specific hardware. I think that a fuzzing subdirectory could be placed there.
The fuzzing tests should be run from time to time, in "fuzzing campaigns", in the background of some powerful system (typically an Arm64 Mac).
For a start, a simple script such as your fuzzing.sh can be sufficient, based on the tsfuzz tool.
Question for your next sleepless night: how to fuzz tsfuzz ? 😉
The tsfuzz specifications
Let's start with this and please provide your ideas.
Syntax (based on tsfclean): tsfuzz [options] filename ...
Options (also based on tsfclean):
-o path, --output path: Output file or directory. If more than one input file is specified, the output name shall specify a directory.
-p pid, --pid pid: Only corrupt the specified PID's (several options allowed).
Please formalize in terms of command options your ideas from your fuzzing.c (and other ideas).

So, it could be a good idea to add in TSDuck a tsfuzz tool to corrupt an existing TS file, just like your fuzzing.

I'm 100% agree.

We need to specify a list of features / options for that tool

I think we can start from two easy things: corrupt random bytes and drop random TS packets like it's done in tcprewrite (https://tcpreplay.appneta.com/wiki/tcprewrite-man.html , see fuzz-factor and fuzz-seed). Frankly, I don't like tcprewrite fuzzing because there is no possibility to split drop and corrupt features so I have my own tools for pcap drops/corrupting, but in general it is likely the same as tcprewrite.
I have some more idea like: changing random bytes in the tables and recalculate CRC32 mpeg value to pass crc32 filters

If you agree, I can provide a skeleton of tool with basic features (command line options, reading / modifying a TS file)

For sure, I agree

Please formalize in terms of command options your ideas from your fuzzing.c (and other ideas)

I can explain fuzzing.c args:
INPUT_FILE ($1) - no need to describe
OUTPUT_FILE ($2) - no need to describe
SEED_VALUE ($3) - very important option for reproducibility. Also, it is highly important to use OS- and CPU-independent random generator like I use in fuzzing.c. Otherwise, it will be required to save produced .ts/pcap/etc file every time when running script founds an issue.
CHANGE_PROB_X ($4) and CHANGE_PROB_Y ($5) - these two options defines probability of byte corruption. the probability of corruption is CHANGE_PROB_X/CHANGE_PROB_Y . You can use just one float value, I just prefer to avoid floating point calculations.
IGNORE_SYNC_BYTE ($6) - if it equal to 1 then sync_byte (every 188 byte) is ignored and not touched. this options is needed to pass sync_byte validations

An initial implementation is available. You may propose new features through pull requests.
To remain consistent with the rest of TSDuck, the fuzzing features are available through C++ classes in the TSDuck library and can be used from any application. A tool named tsfuzz and a plugin named fuzz are available and are simple wrappers to these C++ classes. They are documented in the user's guide (which then may need to be updated when new features are added).
The fuzzing is implemented in two separate classes.
The class TSFuzzingArgs defines the fuzzing options. They can be set in a dedicated application. The class may also define and decode them as command line options.
These command line options are used in tsfuzz and plugin fuzz. This means that the source code of tsfuzz and plugin fuzz is final and do not need to be changed. If you want to add new options, simply update the class TSFuzzingArgs.
The fuzzing itself is done packet per packet in the class TSFuzzing.
Currently, the features of TSFuzzing and TSFuzzingArgs are exactly the same as in your code. For this reason, I added your name in the copyright of these two classes.
The only difference with your code is the PRNG. I used a more cryptographically secure PRNG (derived from Fortuna without external entropy pools). It is still strictly deterministic based on the initial seed. It is probably much slower though.
If you look at the source code of the fuzz plugin, you can see the advantage this structure. You can implement fuzzing anywhere at virtually zero development cost. The same principles are used in TSDuck with utilities tsanalyze, tstables, tspsi and the corresponding plugins analyze, tables, psi.

OK, we do not need cryptographic security to fuzz. I changed the PRNG to xoshiro256** and the result is much faster of course.
Concerning the differences between Arm64 and Intel (not macOS vs. Linux), the implementation of SHA-256 and AES (used by the crypto PRNG) are accelerated using specialized instructions on Arm64, not on Intel. In practice, the insertion of crypto algos in TSDuck dates back to the very beginning (circa 2005). The code was grabbed from LibTomCrypt, a fast (for the time) library with a very liberal license. The code is pure C/C++. Recently, I wrote an accelerated version for Arm64 because I work on security on Arm64 CPU's. This is why TSDuck crypto is much faster on Arm64 than Intel.

Let's close this one, if you agree. The new feature (tsfuzz) is in place. Please submit a specific PR or issue for new features inside the TSFuzzing class.

Yes, let's close this one.


Use the primitive boolean expression

See Sonar flagged issues https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS5411&severities=MINOR&id=open-metadata_OpenMetadata

Hi, please assign me to this issue

Thanks @semnim assigned it to you.

Just to clarify, I cant find the path annotated in sonarcloud (catalog-rest-service/src/main/java/org/openmetadata/catalog/fernet/Fernet.java). Did I miss any info? There is no catalog-rest-service folder.


Tests do not run in Microsoft Edge 16.16299

What is your Test Scenario?
Form submission on this page http://devexpress.github.io/testcafe/example
What is the Current behavior?

Running tests in Microsoft Edge 16.16299 / Windows 10
Testing page opens
No value is set in the text field
In the developer tools I see an error: Object doesn't support property or method 'postMessage'

What is the Expected behavior?
Text typed and submit button is clicked
What is your web application and your TestCafe test code?

 Use the async_context variant of MakeCallback or the AsyncResource class instead.
ERROR The Microsoft Edge 16.16299 / Windows 10 browser disconnected. This problem may appear when a browser hangs or is closed, or due to network issues.
Type "testcafe -h" for help.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>test:edge: `testcafe edge tests --hostname localhost`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test:edge script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\Vitaly\AppData\Roaming\npm-cache\_logs\2020-07-08T11_14_07_593Z-debug.log

Screenshots:

Browser

Node.js command prompt

Steps to Reproduce:

Run tests from tutorial in Microsoft Edge 16.16299
See the error Object doesn't support property or method 'postMessage' in the developer tools

Your Environment details:

testcafe version:                   1.8.8
node.js version:                    12.18.2
command-line arguments:  testcafe edge tests --hostname localhost
browser name and version: Microsoft Edge 41.16299.15.0 / Microsoft EdgeHTML 16.16299
platform and version:          Windows 10 Pro, 1709

Hello, thank you for your input.
I checked your scenario on BrowserStack with Edge 16 and it does not work as expected. However, I see that version 18 works well. TestCafe supports the latest version of each browser (https://devexpress.github.io/testcafe/documentation/guides/concepts/browsers.html#officially-supported-browsers)
I would recommend you update your Edge version. Or, if it's possible, you can install the new Edge based on Chromium.


populating 'many to many association' records not working

Hello there, hope everything is fine!
I'm developing an application including two tables in the database, respectively named Post and Tag. There's going to be a many to many association between the two resources.
I'm using Sequelize as the ORM, and the code for defining the model for two entities is as follows:
const Post = sequelize.define('post', {
  title: {
    type: DataTypes.STRING,
  },
  summary: {
    type: DataTypes.STRING,
  },
  content: {
    type: DataTypes.STRING,
  }
});

const Tag = sequelize.define('tag', {
  title: {
    type: DataTypes.STRING,
  }
});

// Many-To-Many association between Post & Tag

Post.belongsToMany(Tag, { through: 'PostTags' });
Tag.belongsToMany(Post, { through: 'PostTags' });

I need to customize the edit and show component for the Tag property in the Post resource in the AdminJS panel in order to make the creation of the post resource with associated tags more user-friendly. I succeeded in creating a custom component for editing tag property using the library's own API and react-select async(multi) component. I just place the code of the edit component here for better clarification:
import React from "react";
import Select from "react-select/async";
import { FormGroup, FormMessage, Label } from "@adminjs/design-system";
import { EditPropertyProps, ApiClient, SelectRecord, RecordJSON } from "adminjs";

type SelectRecordEnhanced = SelectRecord & {
  record: RecordJSON;
};

export default function TagsSelect(props: EditPropertyProps) {
  const { onChange, property, record } = props;

  const handleChange = (selectedArr: SelectRecordEnhanced[]): void => {
    if (selectedArr) {
      onChange(property.path, JSON.stringify(selectedArr.map((selected) => selected.value)));
    } else {
      onChange(property.path, null);
    }
  };

  const loadOptions = async (inputValue: string): Promise<SelectRecordEnhanced[]> => {
    const api = new ApiClient();

    return api
      .searchRecords({
        resourceId: property.name,
        query: inputValue,
      })
      .then((optionRecords: RecordJSON[]) =>
        Promise.resolve(
          optionRecords.map((optionRecord) => ({
            label: optionRecord.title,
            value: optionRecord.id,
            record: optionRecord,
          }))
        )
      );
  };

  const error = record?.errors[property.path];

  return (
    <FormGroup>
      <Label required={property.isRequired}>{property.label}</Label>
      <Select
        cacheOptions
        defaultOptions
        isMulti
        loadOptions={loadOptions}
        onChange={handleChange}
        isClearable
      />
      <FormMessage>{error?.message}</FormMessage>
    </FormGroup>
  );
}

Therefore I can catch the tagsId in the after hook of the new action, and set the association of the tags using Sequelize mixins:
new: {
  after: async (response, request, context) => {
    let tagsId = JSON.parse(request.payload?.tags || '[]');
    let postId = response.record.params.id;
    const post = await db.Post.findByPk(postId);
    post.setTags(tagsId)
    return response;
  },
},

The logic for creating a new post and setting tags id works completely as expected!
But in case I want to create the custom component for the show action of the post resource, when I try to get record.populated of the post record in the custom show component, I receive an empty object. However, I expect to get the related tags to the post as an array in the record.populated property.
The property option for tag in the post resource is also as follows:
tags: {
  components: {
    edit: AdminJS.bundle("./components/TagsSelect.tsx"),
    show: AdminJS.bundle("./components/TagsList.tsx")
  },
  type: 'reference',
  resourceId: 'post'
},

How I'm supposed to make the request of API client of AdminJS to get the populated records in the corresponding resource?
Setting the resource: 'Tag' property in the option above also seems to encounter error as I gave it a try.
I would be grateful for any assistance and help.

I'm facing the same issue. I've walked through the whole code like five times and I can't find any bug. Did you find yours?

Did you find a solution for this?


"Spam" menu item hard to find on a tablet

Describe the bug
On my phone, when viewing a message, the "Spam" option is right at the top of the menu.  On my tablet, with the same version of K-9, it's buried in the "refile" submenu, which makes it hard to find.
To Reproduce
Steps to reproduce the behavior:

Open a message
Click on the three-dots button to open the menu
Look for "Spam"

Repeat steps on both a phone and a tablet
Expected behavior
The menus should be similar on both types of hardware.
Screenshots
Tablet:

Phone:

Environment (please complete the following information):
Phone:

K-9 Mail version: 5.800
Android version: 11
Device: Samsung Galaxy S10+
Account type: IMAP

Tablet:

K-9 Mail version: 5.800
Android version: 7
Device: Samsung Galaxy Tab S2
Account type: IMAP

Additional context
Logs

Could this be due to different configuration of Settings > General settings > Display > Visible message actions?

@cketti the default actions I see in my inbox (folderview) are

Sort by
Select all

Earlier versions had mark as spam as well ....
Thanks for providing the hint to above settings, which at least allows me to manually select a message for Spam.
I'd prefer to mark multiple messages and send them to the spam folder, but I'm not sure if this functionality exists. Thanks.

@justdave I know your problem. Are you in the folder view or are you looking for the "Spam" when inside a particular message? If you are in a message @cketti 's hint should do the trick.

This was inside a message, and @cketti was spot on. I don't recall having ever set that on the phone, but then again I've been using k9 for years and memory is fleeting.

Maybe you want to follow the issue to improve visible message actions: #5300
Closing this issue since it seem to be resolved.


Add share Analytics modal on login

[x] Please add this modal on app creation flow
[x] Once user clicks on the CTA " Share" in settings we will turn on the share Analytics button
[x] Once user clicks on CTA "Don't Share" in settings we will turn off the share Analytics button

Design Link : -  https://xd.adobe.com/view/5a515bfd-fc47-464b-9c25-11b2e978711e-0f02/screen/78a58a00-48af-4c16-afd8-a27b28abaea6/specs/

Verified this issue on keeper app v 1.2.11(379)

Completed


⚠ Aither has degraded performance

In a915b90, Aither ($AIH) experienced degraded performance:

HTTP code: 200
Response time: 2326 ms

Resolved: Aither performance has improved in f6eabad after 6 minutes.


Can't read iso-8859-5 encoded files

Not that you should support it; just thought I'd report it.
>>> massedit -e "line" -m 99 nonascii.py
Traceback (most recent call last):
  File "/usr/bin/massedit", line 9, in <module>
    load_entry_point('massedit', 'console_scripts', 'massedit')()
  File "/home/tyler/repos/massedit/massedit.py", line 475, in main
    command_line(sys.argv)
  File "/home/tyler/repos/massedit/massedit.py", line 462, in command_line
    output=arguments.output)
  File "/home/tyler/repos/massedit/massedit.py", line 440, in edit_files
    diffs = list(editor.edit_file(path))
  File "/home/tyler/repos/massedit/massedit.py", line 168, in edit_file
    from_lines = from_file.readlines()
  File "/usr/lib/python2.7/codecs.py", line 314, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xb1 in position 81: invalid start byte

Where the offending file is nonascii.py from the IPython project.

Hey tgoodlet, thanks for the example. Kind of struggling with my tests and the unicode transition between 2.7 and 3.3. I've found http://python3porting.com/ but I need to find the time to focus on it a little.
I'll get there eventually...

Hey @tgoodlet, the release v0.68.1 should fix this issue. Let me know if it does not.

Fixed by d8330735aa454b117bfa12d83524f456364883f9

Hey @elmotec I'm still seeing this issue (sorry it's been a while - haven't needed massedit for a bit).
An example would be a utf-8 encoded tags file generated from the VIM editor.
If you need an example I can probably whip another one up.

Mmmmmh. Yeah @tgoodlet, I could use another test case. The one I had was fixed with 0.68.1.

Sorry @goodboy, it's been 2 years. I just realized I pinged the wrong person. If you can provide an example, I could take a look.

Without a test case it's difficult to make sure the issue is resolved. If you could provide an example, that would give us a change to resolve the issue.


[V2] Documentation - Breaking change for Reverse proxy

code-server version: v10.15.1
OS Version: docker:latest
VS Code Version:

Version: 1.39.2
Commit: f133b00851c6c05aedaf78ff139443a46cd8d036
Date: 2019-10-21T22:06:51.355Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36

Description
I have a similar issue to #997 after upgrading to V2, but it's different enough to warrent a separate issue.
I'm getting a 404, not found after upgrade for all web views (extension readme's, markdown preview etc.). But I don't think it's code-server's fault it's my reverse proxy config. I'm not sure the exact changes, but I think because I have some path matchers on my reverse proxy it's rejecting /webview paths as not found. because something obviously changed between v1 and v2, it should probably be documented.

Duplicate of #997

This was my fault; I accidentally excluded the webview HTML from the final build. It should be fixed in the latest v2 Docker image.

@code-asher confirmed! Thank you for all of the awesome work!!


Provide helpful terminal messages to fix web component CSP errors

Fixes #566. This makes it a lot easier to fix CSP errors by printing a helpful message in the terminal. Particularly helpful with #723.
Screenshot:

Looks like report-uri is deprecated (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/report-uri).
Seems like the newer way is report-to, however not all browsers support it yet (Firefox) https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/report-to.

Yeah, I looked into this a little bit, but the lack of Firefox support made me not go down the route. There's also some trickier aspects where it's unclear whether it'll work locally and there may be a delay. For now, I think report-uri is OK (I think lots of Google sites use it exclusively and not report-to) and if it does break eventually, we can switch over to report-to.

One thing that could be helpful is to also include the full url that got blocked since there could be multiple files that got blocked from the same domain. So I think it could be important to verify that all the urls were expected ones.

Good idea. I've included the full blocked URL.


react: example solution adds dependency incorrectly if given valid then invalid dependency ID

https://github.com/exercism/xrust/pull/191/files#r78686049

I know, it's just an example and isn't shown to students, and it still passes the tests anyway (it'd be quite difficult to write a test for this at all), but I don't like to set a bad example.


Server Development Merged NKS Code

The Latest Update
Merge all the server-dev branch
Need Merge~

This is the work from Server Group. We merged the code to handle request.
The code of server behavior should be modified under the condition (flag_test == 0).
The conflicts are resolved. But the request handle is not tested with the client.

Hi,
Our group member has tested the request handle part and find there are segmentation fault in handling part.
The test without handling request is in file /test/server-kv-test.c and works well.
So, there may be some issues in the handle_request.

Why are there commits from the client side included here? Are the needed?
The tests have failed. Please update this pull request so that they pass.

Lots of things that need to be fixed here. @zhangwei1984 @huyang1988 any comments?

Hello, thanks for your code review.
This pull request is merged from various repositories. We worked hard to make sure that the compiling is working.
I agree that there are still lots of issues need to clean up. I will discuss with my group members and then push a new commit.
@phil-lopreiato @zhangwei1984 @wenhuizhang

Can you go through and reply to my comments above? Some of this pull requests includes things that might be out of your group's scope, so I don't want you do have to do extra work. Also take note of some of the things that you shouldn't have removed (specifically https://github.com/gwAdvNet2015/gw-kv-store/pull/63#discussion_r29203973 and https://github.com/gwAdvNet2015/gw-kv-store/pull/63#discussion_r29203956)

Closed due to updates: see PRs #65 and #66


Update readme to current project status

updated the "upcoming features" to "existing features"

👏 👏


Added Recursive code for Taylor Series

Hey there i have added the recursive method for finding the result of a Taylor Series.

Thanks for your contribution and please append your name to the contributors.md file.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/channel-wg-leads
/assign knative-sandbox/channel-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/eventing 38bfba7...38f3845:
  > 38f3845 Clarify meaning of `default-br-config` (# 5713)
  > 546b3b6 upgrade to latest dependencies (# 5712)
  > 158f189 Test runner: Increase MaxNamespaceSkip (# 5706)
  > bbd498b upgrade to latest dependencies (# 5702)
  > 4a55e51 Fix inaccurate description of default-br-config (# 5703)
bumping knative.dev/pkg dec98b4...bb433c9:
  > bb433c9 Add tests for retriable errors to the spoof client (# 2277)
  > b09fa45 Declare `DefaultErrorRetryChecker` as `ErrorRetryChecker` type (# 2276)

/lgtm
/approve


Clean up/Split the code

The code in the frontend is starting to be huge and hard to follow.
Split the code in multiple files:

One for the css
One for the icons / utils
Create a Lit controller and move the behavior like filter, highlight...
The main component

I think it's ok for now


Absolute Positioned Elements Don't Expand Height

Without the custom scrollbar enabled everything works fine, but when I try to set it on my body element the content clips at the end of the static positioned elements and all of my absolute positioned elements it cut off.  This plugin needs to be able to support absolute positioned elements adjusting the height of the area as well.

@malihu I was having a similar issue and your post above fixes it. But if the container is too big for a scrollbar on page load it will cause the error: this.mcs is undefined. Do you know how to get round this?

@malihu Even I am getting the same error. Anything i might be missing

If you could send me link with your page I might be able to check/modify the snippet to make it work.

I have the same problem as Matt Hicks, you can try to make aceadmin left sidebar autoscroll with this plugin, site:
https://github.com/bopoda/ace
http://ace.jeka.by


Playback fails with @presentationTimeOffset in Chrome of video with compressed b-frames

What version of Shaka Player are you using?
2.0.1-debug
http://shaka-player-demo.appspot.com/demo/
on chrome (works in ff)

Can you reproduce the issue with our latest release version?
tested on the hosted demo

Can you reproduce the issue with the latest code from master?
master not tested

Are you using the demo app or your own custom app?
demo app

What did you do?
Compressed big_buck_bunny.mp4 with h.264 and generated dash manifest for the fragments, then provided an endpoint and tried to playback in the demo shaka player

What content did you load?
Custom asset of compressed big buck bunny, and custom dash manifest software. Attached

What did you expect to happen?
Should play back, as it does in firefox

What actually happened?
Shaka Error MEDIA.VIDEO_ERROR (3,)

my notes:
Very specifically, we fail to playback dash on vod content with compressed B-frames in chrome. The b-frame compression pushes our first fragments decode time to be less than its presentation time. This adjustment is necessary for players that we currently must support. However, we found in testing that If we incorrectly report the decode times as being equal to the fragment's presentation time, then shaka in chrome will play the dash endpoint. Unfortunately, this work around is not an option for us.
Shaka in firefox successfully plays the content. Also, if we provide a live dash stream with decode time offset as explained, shaka in chrome also plays back. A notable difference in the manifest for vod content is the @presentationTimeOffset field. If we omit this field, surprisingly shaka in chrome will playback, which then breaks playback for basically every other player we tested.
dash spec used: https://www.dvb.org/resources/public/standards/a168_dvb-dash.pdf
The spec says these things of interest

[A]t the start of a Period, if the earliest presentation time of any access unit of a Representation is not equal to the presentation time offset signalled in the @presentationTimeOffset attribute then the playout procedures need to be adjusted accordingly.

In all our cases, we are able to keep these two fields equal. No special adjustment should be necessary.

Current play position is the composition time of the currently presented samples minus @presentationTimeOffset

In all cases, our pts - presentationTimeOffset of the first sample is zero, giving us a "play now" behaviour

...the sole purpose of composition offsets is to re-sequence pictures from decode order to display order

Having a decode time of 0 and a presentation time of 1001 should not affect the "Current play position" negatively. The decode time should be used to order the samples.

When non-sequential or partial Media Segments are passed to a decoder, the baseMediaDecodeTime stored in the Track Fragment Decode Time Box ('tfdt') combined with the Period@presentationTimeOffest[sic] in the MPD can be sufficient to locate the movie fragment on the presentation timeline and provide synchronization between Adaptation Sets encoded with separate timelines, origins, and timescales in the same Period.

We find that our decode time + presentationTimeOffset is always equal to the presentation time of the first sample (due to no gaps nor overlap). Thus, this equation holds true in our case.
bunny-chrome-test.zip

This appears to be a duplicate of #377.  Chrome has several open bugs right now regarding mixups between DTS and PTS:
https://bugs.chromium.org/p/chromium/issues/detail?id=402502
https://bugs.chromium.org/p/chromium/issues/detail?id=398141
https://bugs.chromium.org/p/chromium/issues/detail?id=398130
https://bugs.chromium.org/p/chromium/issues/detail?id=373039
I'm closing this as a duplicate of #377, which we will keep open until Chrome has fixed these bugs.  As far as I know, there's nothing Shaka Player can do to work around these bugs in the browser.  If you have any information to contribute to those Chrome bug reports, please do.  I apologize for the inconvenience.


Use docker orb

Uses Docker CircleCI Orb for publishing new docker images instead of a custom script.

Let's go ahead and delete the /bin folder if it's no longer necessary.


Redefinition of the COMPILE_ASSERT macro

Hi, I'm working on chromium and I'm in a situation where libphonenumber and libaddressinput are both redefining the COMPILE_ASSERT macro.
I was thinking of submitting a patch to add a #ifndef check. Does that make sense?
Thanks!

It used indeed to have this. Fredrik submitted this change to its
implementation, which removed it:
https://github.com/googlei18n/libphonenumber/commit/768e05f0bc477eccfa9bf263e905fdf60c52fbde#diff-f02d3727ee225083264b0f0869f9716a
Fredrik - was this intentional?
2017-04-19 21:56 GMT+02:00 Zeb<EMAIL_ADDRESS>
Hi, I'm working on chromium and I'm in a situation where libphonenumber
and libaddressinput are both redefining the COMPILE_ASSERT macro.
I was thinking of submitting a patch to add a #ifndef check. Does that
make sense?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/googlei18n/libphonenumber/issues/1699, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AIjis01pzHyyGPvVkngtdFNelc8rChpCks5rxmbmgaJpZM4NCKlF
.

On Wed, Apr 19, 2017 at 10:46 PM, Lara Rennie<EMAIL_ADDRESS>wrote:

Fredrik submitted this change to its implementation, which removed it:
https://github.com/googlei18n/libphonenumber/commit/768e05f0bc477eccfa9bf263e905fdf60c52fbde#diff-f02d3727ee225083264b0f0869f9716a

The point of that change was only to bring the file in sync with
Chromium, from where the file was originally copied, for in general, I
think it's a good idea to have as few different versions of this file
as possible.
Chromium has since migrated to C++11, thus eliminating the need for
basictypes.h which was finally deleted a year ago:
https://chromium.googlesource.com/chromium/src/base/+/a431b4b
--
Fredrik Roubert
<EMAIL_ADDRESS>

So in answer to the original question: seems fine to add an if !defined.
2017-04-19 22:55 GMT+02:00 Fredrik Roubert<EMAIL_ADDRESS>
On Wed, Apr 19, 2017 at 10:46 PM, Lara Rennie<EMAIL_ADDRESS>wrote:

Fredrik submitted this change to its implementation, which removed it:
https://github.com/googlei18n/libphonenumber/commit/
768e05f0bc477eccfa9bf263e905fdf60c52fbde#diff-
f02d3727ee225083264b0f0869f9716a

The point of that change was only to bring the file in sync with
Chromium, from where the file was originally copied, for in general, I
think it's a good idea to have as few different versions of this file
as possible.
Chromium has since migrated to C++11, thus eliminating the need for
basictypes.h which was finally deleted a year ago:
https://chromium.googlesource.com/chromium/src/base/+/a431b4b
--
Fredrik Roubert
<EMAIL_ADDRESS>

Hi @sebsg, would you be able to contribute this patch?
If not we can take it up when have some cycles.

I found a temporary fix on the Chrome side for the moment, and I'm pretty busy at the moment. So feel free to tackle it if you have the time. Thanks :)


[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] [$250] [One expense reports] Update the UI for Held transactions in Single Transaction Report Preview / MoneyRequestAction

Slack discussion here
Goal
Expand upon the new UI pattern introduced as part of the Wave 5/6: Update how we display / report expenses doc to include reports where all transactions that are on  HOLD (including reports with only one transaction where we show only one expense) using the copy "All requests were put on hold. Review the comments for next steps."
Note 1: that a report could be in two states simultaneously: the receipt could be scanning and the transaction(s) on the report could be on hold
Note 2: One-transaction reports currently do not show an option to hold an expense, but this is easily rectified by including the logic from here in src/components/MoneyReportHeader.tsx
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017ed767635e9fa640
Upwork Job ID:<PHONE_NUMBER>318855680
Last Price Increase: 2024-05-10
Automatic offers:

dukenv0307 | Reviewer | 0
tienifr | Contributor | 0

Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Adding design so we can get some mocks of how this should ideally look 🙇

Note 1: that a report could be in two states simultaneously: the receipt could be scanning and the transaction(s) on the report could be on hold

My understanding was that this isn't possible for a one-expense report: you can't hold a scanning receipt. Is that right @trjExpensify @JmillsExpensify ?

I believe @dragnoir is in the process of fixing that. @dragnoir can you provide an update?

In terms of the banner style, I posted to Slack but I think it might look something like this:

Can't think of a reason why we'd block holding a scanning receipt, though I'm not super passionate.

Ah, you said the opposite over here:

What's the latest here?

Bump @dragnoir ^^

I'm going to move this into [One expense reports] to track for August!

Hmm, yeah this issue was intended to be specifically for the one-transaction view. Let's make this external (since we have a mockup here) and get this updated!

Contributor assigned and waiting on PR.

When we put the transaction in one transaction expense report on hold, should we keep the next steps banner? If so, there would be 2 banners at a time.

No, the intention is that there's 1 banner as illustrated here. That would be the same for a one expense report with a held request, or a multi-expense report where all requests on the report are held.

Automatically submit the report in the BE/Show the next steps banner?

No, we shouldn't automatically submit the report if all requests on a draft open report are held. We should just show the banner illustrated here.

Agree with Tom - thanks for clarifying!

We apply it to multi-expense reports when all expenses are held.

Ended up reverting the PR associated with this issue. See this comment on the PR. See where we decided to do this internally here.
The deploy blockers that caused us to revert were this one and this one. We need to redo this PR and make sure those don't happen.

@tienifr did you open that PR?

When all expenses within an expense report are on hold (same with one-transaction expense report), should we show submit and settlement (approve/pay) button in report preview and report header?

An expense report can be submitted with held requests, so if the report is in the open state they can Submit.
An expense report can be approved/paid with held requests, we just display a modal when clicked to ask if they want to unhold any held requests to approve/pay them all, or only the expenses on the report that are unheld.

should we display any message in the report preview indicating the hold status of the expense report?

When an expense report contains held requests, the report preview component in the parent chat has a red dot in the header. It doesn't contain a message currently, and I don't think we need to add that here.

Agree with everything @trjExpensify mentioned.

@alexpensify are we paying this PR via your issue or this one?

I started the payment process in my GH. We can combine the two since it was one PR.

Ok cool, so then I'll just close this one out. Someone please comment if you disagree.


How to setup the Environment without Conda?

What if I don't have access to Conda (Anaconda, Miniconda)? Is there any other way to setup the environment?

Can you install packages via pip @dardodel ?

@dardodel sorry for the late follow up to this. if you can pip install python packages, I would try the following
conda create -n halos3 python=3.10.12
pip3 install numpy==1.24.3 ninja==<IP_ADDRESS> packaging==23.1
conda install pytorch==2.1.1 pytorch-cuda=12.1 -c pytorch -c nvidia
pip3 install flash-attn==2.3.3
pip3 install transformers==4.35.2 datasets hydra-core==1.3.2 wandb==0.15.3 openai==1.6.1 accelerate==0.21.0 tensor-parallel

if you can't use cuda 12.1, i would replace the third line above with
conda install pytorch==2.1.1 pytorch-cuda=11.8 -c pytorch -c nvidia

i think this should work, but you may have to change the version of flash-attention in case there are any compatibility issues


Remove Danger - Switch to Peril

Spellcheck is now inside Peril

If anyone is interested, I'm happy to pair with someone on it ~20-30m


fix: update tests dependent on spoon's travis-ci.org

Signed-off-by: Javier Ron<EMAIL_ADDRESS>

Changes moved to #1200


Add cross tasks

Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?

...

PR checklist
Please check if your PR fulfills the following requirements:

[ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[ ] Have you read the contributing guidelines?
[ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

/bench workloads/hackernews-add-new-documents.json workloads/hackernews-modify-*

/bench workloads/hackernews-add-new-documents.json workloads/hackernews-modify-*


DO NOT MERGE! Fast Forward stable to 7caef36b20632b3f4997a53e78de7216a3b7bffa.

This PR will be merged automatically once checks are successful.

Jenkins job auth/postsubmit passed


user defined filename in the text to pdf tool

Is your feature request related to a problem? Please describe.
whenever we download the pdf in the text to pdf feature , the filename remains the same (text.pdf)
Describe the solution you'd like
the tool should have a input field for getting the user defined filename. whenever it is downloaded the pdf should be like
( user defined filename.pdf)
if the input is syllabus , then the output of the pdf should be (syllabus.pdf)

can i work on it ?

can i work on it ?

Yes


Is it supports skywalking 6.x now?

Is it supports skywalking 6.x now?

yes. Supported as of (sky_php_agent) version 3.1.1
https://github.com/SkyAPM/SkyAPM-php-sdk/releases

v3.1.0 (skywalking 6.x Support)
v3.1.1 (fix bugs)

↓ For your reference
https://github.com/SkyAPM/SkyAPM-php-sdk/issues/80#issuecomment-510023048
 it was OK even with nginx + php-fpm

Nginx v1.17.0
php-fpm PHP 7.2.14 (fpm-fcgi)
skywalking v6.2.0
sky_php_agent v3.1.1

@iZRIdJJ53S said the right. 😄


Build failure

ocamlbuild -I src -I lib -I parser -I kremlib -use-menhir -use-ocamlfind -classic-display -menhir "menhir --infer --explain" Kremlin.native
ocamlfind ocamlc -c -g -annot -bin-annot -strict-sequence -w @1-2-3@8..12@14..21@23..29-30@31..38-39-40-41@43@57 -package ppx_deriving.std -package ppx_deriving_yojson -package zarith -package pprint -package unix -package menhirLib -package sedlex -package process -package fix -package wasm -package visitors.ppx -package visitors.runtime -I src -I parser -I kremlib -I lib -o src/CFlatToWasm.cmo src/CFlatToWasm.ml
+ ocamlfind ocamlc -c -g -annot -bin-annot -strict-sequence -w @1-2-3@8..12@14..21@23..29-30@31..38-39-40-41@43@57 -package ppx_deriving.std -package ppx_deriving_yojson -package zarith -package pprint -package
unix -package menhirLib -package sedlex -package process -package fix -package wasm -package visitors.ppx -package visitors.runtime -I src -I parser -I kremlib -I lib -o src/CFlatToWasm.cmo src/CFlatToWasm.ml
File "src/CFlatToWasm.ml", line 196, characters 18-32:
196 |   [ dummy_phrase (W.Ast.TeeLocal (mk_var (env.n_args + 2)));
                        ^^^^^^^^^^^^^^
Error: Unbound constructor W.Ast.TeeLocal
Command exited with code 2.
Makefile:22: recipe for target 'minimal' failed
make: *** [minimal] Error 10

I am using wasm 1.1, maybe that's the problem?

ah, I was unaware that the wasm package had been updated -- do you know what replaced the TeeLocal instruction?

Is Kremlin supposed to support OCaml >= 4.08.0?
The opam package wasm 1.0 supports < 4.08.0, wasm 1.1 supports >= 4.08.0.
I'm using 4.08.1 so I encountered the issue.
Therefore I don't think this would be an easy fix... Maybe it's necessary to contact wasm maintainer to relax the version requirements

Unfortunately, for various reasons in Everest, we can only work with at most OCaml 4.06.1... so this error flew under our radar.
I think we should just be explicit that Everest doesn't work with recent OCaml versions. Once we fix the sedlex replacement in FStar, we can consider an upgrade and then I'll fix kremlin. Does that sound good?

I see, I can easily create a switch for 4.06.1 and build kremlin.
Sedlex replacement in F* is a bit tricky, I tried to create a patch for that and didn't have time to finish.
But I've been able to use F* with 4.08.1 with my current local configuration

But I've been able to use F* with 4.08.1 with my current local configuration

It would be very nice to learn how to reproduce this. It's quite problematic to me to hear that F*/Kremlin are so far behind current OCaml.

But I've been able to use F* with 4.08.1 with my current local configuration

It would be very nice to learn how to reproduce this. It's quite problematic to me to hear that F*/Kremlin are so far behind current OCaml.

I think you can install required packages using opam, and then build from source? I didn't encounter extra issues with 4.08.1 (F* and Kremlin). If you have specific errors I might be able to help

I get the same error you described earlier, with wasm 1.1 and OCaml 4.08.1 when I try to build Kremlin.
I'm honestly a bit surprised there doesn't seem to be an effort to have the OCaml build tooling around F*/Kremlin specify dependency versions, when OPAM is one of the best package managers around at actually dealing with that correctly. Is this some deficiency in ocamlbuild? Would transitioning to dune help?

I have unfortunately very few cycles to figure out how to state that kremlin only works with wasm 1.0. Do you know how to achieve that with Dune? I have expressed in another issue that I'm very much in favor of switching to Dune so if you know how to do the migration and solve the dependency issue, I'd be more than happy to review and merge any pull request.
Thanks,
Jonathan

Oh sorry for the confusion. I meant 4.07.1. My apologies for all

Workaround for OCaml 4.08.1:

Clone wasm repo, checkout v1.0 tag
In Makefile, silence warning 3 (for deprecations) by adding "-3" to warn-error
make install in wasm
build Kremlin as usual

@fangyi-zhou: Thanks for the workaround tip!
@msprotz: Oh, interesting. Do you happen to know what issue I should look at for the Dune effort?

OK, I've looked at the "Switch to Dune" ticket and poked around a bit at OCamlbuild, which had always put me off, and I have essentially three thoughts:

An OCamlbuild to Dune migration would not be a trivial effort.
It's astonishing to me that OCamlbuild does not appear to support dependency version constraints. At all.
Even when dependency version constraints are supported (e.g. by Dune), they are Findlib dependency version constraints, and apparently the version field in Findlib META files is optional. Many libraries don't provide a version. Including wasm.

This is sufficiently ridiculous as to cause me to reconsider my interest in the OCaml ecosystem.

I don't think switching to dune would be a huge effort: the build of kremlin itself is simple, and the extraction and linking of libkremlib + tests are handled separately with their own individual Makefiles. So this should be pretty textbook.
Now if Dune doesn't allow a way to require a downgrade of a package, that's more of an issue. But reading from their description:

It also supports multi-context builds, such as building against several opam roots/switches simultaneously. This helps maintaining packages across several versions of OCaml and gives cross-compilation for free.

So surely that must be achievable. I should also mention that we're going to have to require everyone in everest to upgrade their opam setups owing to a dependency on bigstring, so now might be the right time to flip the switch for requiring dune to build kremlin, too. I just lack the cycles to do this myself.

FYI: wasm 1.0.1 is released with the version constraint removed.

Thanks very much. This means that KreMLin will be broken at the next OPAM upgrade... do you know what and how we can fix KreMLin to be compatible with the upcoming version of the Wasm package?
ping @denismerigoux who's working on this and may be impacted

@msprotz wasm 1.0.1 is wasm 1.0 without the version constraint of OCaml.
If KreMLin is not updating to use wasm 1.1, staying on wasm 1.0.1 allows KreMLin to compile with latest OCaml, fixing the initial compilation problem in the first message of this issue.

I just wanted to confirm that kremlin builds with OCaml 4.09.1, OPAM 2.0.4, & wasm 1.0.1! This should probably be specified in the README but I believe the everest script would also need to be updated.

Wonderful, can you mention this in the README?

@protz I have just hit that bug, with ocaml 4.12.0 and wasm 1.1.1.

you can merge branch wasm1.1 of the repository into your local master to get unblocked -- I'm holding off on merging that branch until F* moves to a recent OCaml and it becomes official

Apparently I get an error when installing ctypes-foreign with ocaml 4.12.0...
❯ opam install ctypes-foreign
The following actions will be performed:
  ∗ install   conf-pkg-config 2      [required by ctypes-foreign]
  ∗ install   conf-libffi     2.0.0  [required by ctypes-foreign]
  ∗ install   ctypes-foreign  0.18.0
  ↻ recompile ctypes          0.18.0 [uses ctypes-foreign]
===== ∗ 3   ↻ 1 =====
Do you want to continue? [Y/n] y

<><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><>  🐫
[ctypes.0.18.0] found in cache

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><>  🐫
[ERROR] The compilation of conf-pkg-config failed at "/Users/bbeurdouche/.opam/opam-init/hooks/sandbox.sh build pkg-config --help".

#=== ERROR while compiling conf-pkg-config.2 ==================================#
# context     2.0.8 | macos/arm64 | ocaml-base-compiler.4.12.0 | https://opam.ocaml.org#15d6aa57
# path        ~/.opam/default/.opam-switch/build/conf-pkg-config.2
# command     ~/.opam/opam-init/hooks/sandbox.sh build pkg-config --help
# exit-code   71
# env-file    ~/.opam/log/conf-pkg-config-74001-ffb3fd.env
# output-file ~/.opam/log/conf-pkg-config-74001-ffb3fd.out
### output ###
# sandbox-exec: execvp() of 'pkg-config' failed: No such file or directory

<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><>  🐫
┌─ The following actions failed
│ λ build conf-pkg-config 2
└─
╶─ No changes have been performed

The packages you requested declare the following system dependencies. Please make sure they are installed before retrying:
    pkg-config

❯ gmake -j
OCAML_ERROR_STYLE="short" ocamlbuild -I src -I lib -I parser -I kremlib -use-menhir -use-ocamlfind -classic-display -menhir "menhir --infer --explain" Kremlin.native
ocamlfind ocamlopt -c -g -annot -bin-annot -strict-sequence -package compiler-libs -package compiler-libs.common -package ocaml-migrate-parsetree -w @1-2-3@8..12@14..21@23..29-30@31..38-39-40-41@43@57 -package ppx_deriving.std -package ppx_deriving_yojson -package zarith -package pprint -package unix -package menhirLib -package sedlex -package process -package fix -package wasm -package visitors.ppx -package visitors.runtime -I src -I lib -I parser -I kremlib -o src/GenCtypes.cmx src/GenCtypes.ml
+ ocamlfind ocamlopt -c -g -annot -bin-annot -strict-sequence -package compiler-libs -package compiler-libs.common -package ocaml-migrate-parsetree -w @1-2-3@8..12@14..21@23..29-30@31..38-39-40-41@43@57 -package ppx_deriving.std -package ppx_deriving_yojson -package zarith -package pprint -package unix -package menhirLib -package sedlex -package process -package fix -package wasm -package visitors.ppx -package visitors.runtime -I src -I lib -I parser -I kremlib -o src/GenCtypes.cmx src/GenCtypes.ml
findlib: [WARNING] Interface topdirs.cmi occurs in several directories: /Users/bbeurdouche/.opam/default/lib/ocaml, /Users/bbeurdouche/.opam/default/lib/ocaml/compiler-libs
File "src/GenCtypes.ml", line 25, characters 16-32:
Error: Unbound module Versions
Command exited with code 2.
gmake: *** [Makefile:25: minimal] Error 10

Let me move this to another bug, it doesn't seem specific to the wasm-1.1 branch...

The packages you requested declare the following system dependencies. Please make sure they are installed before retrying:
pkg-config


Missing LICENSE file

In the README, you note a license file but none exists. Would you be willing to add the license file to this repo?

Thanks Ethan I’ll action this today
Leon
Practical AI Strategies is available now at Amba Press
https://ambapress.com.au/products/practical-ai-strategies
Educational Consultant and PhD Student
Practical Writing Strategies is out now from Amba Press
https://ambapress.com.au/products/practicalwritingstrategies
Non-Executive Director - Young Change Agents
https://youngchangeagents.com/
Non-Executive Director - Reframing Autism
https://reframingautism.org.au/about-us/
leonfurze.com
On Wed, 27 Nov 2024 at 03:22, Ethan Holz @.***> wrote:

In the README, you note a license file but none exists. Would you be
willing to add the license file to this repo?
—
Reply to this email directly, view it on GitHub
https://github.com/lfurze/simple-bluesky-comment-embed-wp/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3GVOUOTUQ2TDCRRQI234L2CSN4FAVCNFSM6AAAAABSQ2XNTSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4TKMRXGEYTAOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks!


[HOLD for payment 2023-07-12] [$1000] User without display name shows two same emails on mention

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging dot on web chrome and login with User A
Click on new chat and provide an email of a User B (new user)
Click on header of chat and copy the email of User B
Go to the chat composer and type @ and paste the email and notice that for the user that has no display set, two same emails are shown. For users without display name, one email should have shown.

Expected Result:
User without display name should show one email on mention
Actual Result:
User without display name shows two same emails on mention
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/7b7e3272-1985-4f39-ab99-417503463ed8

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686819408619579
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016f9042e91e3c7e0f
Upwork Job ID:<PHONE_NUMBER>519577088
Last Price Increase: 2023-06-23

Proposal
Please re-state the problem that we are trying to solve in this issue.
User without display name shows two same emails on mention
What is the root cause of that problem?
The user mention is displayed by the following code.
https://github.com/Expensify/App/blob/1e71ef26c27595f965549ed1db201738b77c2f56/src/components/MentionSuggestions.js#L67-L68
If the user has not set display name, item.text and item.alternateText are set to the email.
So two same emails are displayed.
What changes do you think we should make in order to solve the problem?
If item.text and item.alternateText are equal, we can set item.alternateText to an empty string.
const styledHandle = item.text === item.alternateText ? '' : getStyledTextArray(item.alternateText, props.prefix);

What alternative solutions did you explore? (Optional)

I think this should be fixed to only display one email if the user does not have a name. Added the external label.

@StevenKKC I think you should update your proposal to also conditionally render Text component here
https://github.com/Expensify/App/blob/b8aeec0bcf2cac06d51129f287f932ba0421ed4e/src/components/MentionSuggestions.js#L94-L106

In the proposal above, you are going to remove/hide the handle (right part with grey color). I think it'd be better to remove left part (display name with bold font style) and keep handle, that would indicate that the suggested user doesn't have a display name, and all emails in the list would maintain same styling. What do you think?

@alitoshmatov Updated proposal(https://github.com/Expensify/App/issues/21245#issuecomment-1601569294).

Proposal of @StevenKKC looks good to me https://github.com/Expensify/App/issues/21245#issuecomment-1601569294
Some code changes can be discussed in direct PR
🎀 👀 🎀 C+ reviewed

Thanks @narefyev91 for reviewing the proposal, assigning @StevenKKC 🚀

@narefyev91  can you please complete the checklist above so that I can process payment? Thanks!

The PR that introduced the bug has been identified. Link to the PR - https://github.com/Expensify/App/pull/18951/files
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - https://github.com/Expensify/App/pull/18951/files#r1262815825
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - no discussions
Determine if we should create a regression test for this bug - let's have this QA steps (in case that it was some regressions)
Test:

Open app and login with User A
Click on new chat and enter an email of a User B (new user)
Click on header of chat and copy the email of User B
Click on any chat and go to the chat composer
type @ and an email address of a User B who has not set display name
Verify that one email is shown.
Do we agree 👍 or 👎

@priya-zha offer sent!
@StevenKKC -  I'm not sure that I have the right Steven in UW, to confirm, can you send me a link to your profile or confirm your name in UW? Thanks!

@flaviadefaria My upwork profile is https://www.upwork.com/freelancers/~0128670d4717009718. Thanks.

@StevenKKC offer sent!

@flaviadefaria Thanks. Accepted.

All done!


[ACS Rooms] Fix ACS Rooms CHANGELOG to include links

Description
[ACS Rooms] Fix Readme for Rooms to include readme and concept document links
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


⚠ GitLab Server has degraded performance

In 0357e77, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6747 ms

Resolved: GitLab Server performance has improved in c1a7bb4.


HIVE-26762: Remove operand pruning in HiveFilterSetOpTransposeRule

What changes were proposed in this pull request?

Remove operand pruning in this rule since it's now taken care by other (more generic and powerful) rules.
Why are the changes needed?

Simplifying the code forked from Calcite by removing (now) redundant code, paving the way to remove the Hive fork completely.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Added an extra qtest to show that pruning for UNION ALL operands still happens:
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile="union_all_filter_transpose_pruned_operands.q" -Dtest.output.overwrite -pl itests/qtest -Pitests

@kasakrisz, tests are green, can we merge this?


Changing header for various views?

I like the week view, but for my project I'm trying to schedule events for multiple locations. Is it possible to set up the header so that instead of each column being a different day it's instead something else say a different location. That way I can get quick glance at what locations are scheduled for a given time slot. If not, then what about adding additional columns to the day view? That'd give me the same result.

You are probably looking for "resources" https://github.com/intljusticemission/react-big-calendar/pull/423 there isn't anything there yet, but if you want to pick up the PR and finish it we can get it merged :)


Update react.md code sample var name

Since Vault is itself an API object, it is confusing to name an instance of the App object "vault"; why not name it "app"?

Hey (and sorry for the late response)!
Maybe I'm misunderstanding you here, but vault doesn't refer to the app instance here, but the vault instance.
The following code:
const { vault } = useApp();

Is equivalent to:
const app = useApp();
const value = app.vault;

The { vault } syntax extracts a property from the object on the right hand side.


Impl rest catalog + table updates & requirements

Hi @zeroshade
I think it's really cool that you are working on a golang-iceberg implementation, and I would like to contribute if I can.
I have tried to finish the rest catalog implementation, and then I have added table updates and requirements, using a new MetadataBuilder struct that can simplify updating metadata. Like the existing implementation, I have tried to stay close to the pyIceberg implementation.
I thought this could be a good starting point for also implementing transactions and table updates. I would love to get your input and change/adjust the implementation accordingly.

Hi @zeroshade
I sincerely apologise for not getting back to you sooner, I suddenly found myself with very little time on my hands.
Once more, I thank you for your feedback - I will make sure to address all of your comments above this week!

@jwtryg any updates?

@zeroshade thank you for your patience :)
I have implemented your feedback and made some other changes - specifically, being more mindful of what should be exported, and then undoing the manic nil-pointer checking I somehow got myself into.

My apologies for the long delay here, could you resolve the conflicts? I should be able to give this a new pass of review in the next day or so.


Add a secure section

As someone asked me by mail, this cookbook need a 'secure' version which can be applied both on server and galera.
The goal is to simulate the result of the mariadb_secure_installation script, via attributes:

set a secure root password (via openssl opscode cookbook)
remove test database
remove anonymous login
remove root remote access (already done, but put the attribute in secure section)

https://github.com/sinfomicien/mariadb/issues/65 would also apply here.

I just spent a good half an hour trying to figure out why my 'foo'@'%' GRANT wasn't working and eventually discovered it was due to the presence of the anonymous login. This is very annoying.