Avoid new Guid().ToString()

Great repository and examples!
I would however strongly advise against the use of new Guid().ToString(), in the example to Guid.NewGuid().ToString().
I.e. in in Startup.Auth.cs.
RefreshTokenGenerator = () => new Guid().ToString()
Else, new Guid().ToString() will produce a guid of 00000000-0000-0000-0000-000000000000 that will be used in RedisRefreshTokenProvider.CreateAsync, which in conjuction with the Owin OAuthAuthorizationServerOptions, will leak the same (zero:ed) refresh token to multiple users, hence handing out access tokens to other users.
I know it's just an example, but this might prevent bad things from happening.

Hi @sledgas, thanks for heads-up, fixed 👍


fix(context selection): implement improvements TECH-1238

Closes TECH-1238
Closes subtask TECH-1239
Closes subtask TECH-1240
Closes subtask TECH-1241
Closes subtask TECH-1242
Closes subtask TECH-1248
(TECH-1243 seems to have been implemented already, so marked it as done with "Won't do" in Jira)
Commit messages say exactly what's been done in this PR

Thanks @tomzemp

TECH-1239
looks good. I'd suggest making the max-height for the menuSelect class the same as for the OrgUnit selector (itemContentContainer class), i.e. 80vh (or make them both 70vh)

Done

TECH-1240
looks good. I think the logic for the check in useShouldComponentRenderNull can now be simplified a bit.

Done

TECH-1241
looks good. Maybe a design question for Joe, but if the attribute option combo name is really long, we might want to truncate it?

Yes, this is something @cooper-joe should decide. We could do that in an extra PR so this one isn't blocked. Could you create a Jira issue and assign it to epic TECH-1187?

current logic for calculating future periods only looks at the next year. I think this needs to be redone as while loop or similar (e.g. so if dataset is monthly and there are 30 openFuturePeriods, the future periods might span the next 3 years)
there does not appear to be any logic for adding future years if dataset is yearly and there are openFuturePeriods

Good catch, will implement that now!

the logic for determining acceptable future periods now seems (to me) to be [...] less optimal for code maintenance over time.

Will take a look at this one, too

only returning the last 10 years

I'm wondering about what's the best solution here. Maybe it makes sense to simply show all possible years. It's the quickest solution right now. I'll just ahead with that implementation right now. @cooper-joe if you prefer to do this differently, please create a jira Issue and add it either to the epic for the next release (TECH-1152) or to the one for the following release (TECH-1187)

@tomzemp In case I don't manage to get this PR merged before I leave, do you mind taking it over as you've already spent some time digging through the code & changes this PR should add?

@tomzemp I think I've addressed all your points. The user can now select any year when the type is yearly and all future periods should be covered. I also tried to untie couple code a bit, but it still feels like we could improve the code quite a bit. Handing over the PR to you as I'll be on vacation

This looked good. I liked the hooks for controlling the period logic, and it seems like there is not duplicated logic of testing for future period validity! I looked into why the cypress test was failing in CI (and not locally) which then led me to discover some issues (see below), and then I tested on the other periodTypes and found a few more things to clean up. Changes I've made are summarized below.
Cypress test failure (January 2022 appearing in 2021 months)
TL;DR: this is fixed by not using moment in the app. I've removed moment and made some other small updates to account for JavaScript's worse handling of date addition/subtraction.
The cypress test for number of months was failing in CI because of a difference in date instantion between JavaScripts native Date constructor and moment.js.
FYI: moment appears to instantiate a date from a string in the local timezone, so moment.date('2022-01-31') would be 2022-01-31 00:00:00 (CET) whereas JavaScript Date() is treating the dateString as UTC time, so Date('2022-01-31')  would be 2022-01-31 01:00:00 (CET).
The test then failed because we had logic to account for the possibility of dates spanning years (so we looked up through the first startDate in the new year). When running locally in CET time zone, we'd check that the January 2022 period was valid by checking that the period's end date was less than our maximum date and it did not because of where we were using moment/Date()
2022-01-31 01:00:00 (CET) <= 2022-01-31 00:00:00 (CET)`
However, when the test was executed in CI mode, it seems to run in UTC and the test ends up as
2022-01-31 00:00:00 (UTC) <= 2022-01-31 00:00:00 (UTC), which passes and then we end up with January 2022 showing up in our list of 2021 months.
Period end date
Throughout fixed-periods, we record the endDate for a period as the day before the subsequent startDate, e.g. for August 2022 month, the endDate is 2022-08-31. In the logic in getFixedPeriodsForTypeAndDateRange, we instantiated a date with Date(endDate) which means we could have a user log in on 2022-08-31 at 10am and be shown August 2022. I've updated the logic to make the endDate be end of day, so that users could not, for example, see August 2022 until the period actually ends and they log on in September 2022 or later.
[This would be something to consider for Approvals app as well]
Future period calculations
I like the approach of iteratively building up an array of future periods (getFollowingFixedPeriodsForPeriod), as I think that's the surest way to get the exact number of periods needed. However, since this used called to getFixedPeriodsForTypeAndDateRange which in turn called getFixedPeriodsByTypeAndYear, we could end up in a situation where we evaluated many periods repeatedly. For example, when iteratively getting openFuturePeriods for daily periodType, we seem to be getting a year's worth of days and then using a forEach to evaluate each of those periods, so e.g. if we need 500 future daily periods, we do something like 365*500 evaluations.
Because of that, I've just switched to trying to find the startDate of the period after the final open future period and then calling getFixedPeriodsForTypeAndDateRange with that set as the end date. This should be more performant and worked in all tests I tried. After making that change, it was no longer necessary to have a separate calculation of futurePeriods, so in my last commit I changed the logic to remove the separate useFuturePeriods hook; if we wanted to keep this differentiation, I could revert the last commit.
Additional cypress tests
I added in some additional tests to cover the other periodTypes available in the Sierra Leone database.
Yearly period types
Year selector was being hidden only for periodType=='yearly'. I've hidden for the other yearly period types (e.g. FinancialYearOct)
Periods accross years
The future periods had a slightly different logic for presenting periods that crossed over year boundaries. I've standardized to make all years display periods that cross a given year (e.g. SixMonthlyApril for 2022 would show October 2021-March 2022, April 2022 - September 2022, October 2022 - March 2023)
Six-monthly November
This period was missing from fixed-periods.js. I've added it in as the backend allows datasets to be created with this periodType.
[Something to consider for other uses of this code. Also the developer documentation does not include all periods]
Miscellaneous cleanup

some of the updates to fixed-periods.js resulted in some errors (e.g. like const period = {startDate: '2022', iso: period.startDate})
there were some inconsistencies in period definition, e.g. correcting 2022October to 2022Oct for FinancialYearOct periodTypes
I removed some calls to parsePeriodId() where the function was just being called to add in the periodType (and cleaned up corresponding unit tests)

Issues outside the scope of this PR

Backend seems to allow for negative values on openFuturePeriods (it's set as an Integer). In the last commit, I enforced logic to ensure we had only "future" periods and didn't get disabled "past" periods. The user docmentation does not mention any possibility of negative values, so I believe this is just a bug.
biweekly data periods in past years sometimes lead to situations where certain dates are inaccessible, e.g. 2020 Bi-Week 26 is 2020-12-14 to 2020-12-27 and 2021 Bi-Week 1 iss 2021-01-04 to 2021-01-17 which seems to imply there is a week where data entry is not possible?


[Optional] Menus: Add schema validation of JSON document contributions to reject bad JSON before check-ins happen

As a Platform.Bible developer, I want to get early feedback if my JSON menu contribution document is clearly broken.

Depends on #421
The purpose of this ticket is to add some basic JSON schema validation to the extension check-in process so that JSON contribution documents have some level of validation done before updates are checked in.  This would presumably be an update to the Git commit hooks to run JSON files through a schema validation process.  The menu contribution design document includes a JSON schema that could be used for this process.
I am assuming that this work would target the extension template repo.  If other locations for real extensions need to be updated because we couldn't use the template repo for all of our real extensions, then this ticket should include updating those locations, too.

This was fixed as part of #419


Update version to 2.1

This is to make a release that https://github.com/ReactiveCocoa/ReactiveObjCBridge/pull/6 will be able to consume.
I think it would make sense to merge #34 and #37 before making this release.

I think it would make sense to merge #34 and #37 before making this release.

Agreed. 👍


exited with code 127 Error, possible shell config issue?

While trying to profile a python script in vscode on macOS 12.4 and austin 0.10.8 I keep getting the error:
 *  Executing task: austin: profile /Users/user/Desktop/dev_folder/test_profile_script.py

Starting Profiler in /Users/user/Desktop/create_transfer_functions.
Running 'austin' with args '-i 100 --pipe  /Users/user/miniconda3/envs/mtpytest/bin/python "/Users/user/Desktop/dev_folder/test_profile_script.py"'.
austin process exited with code 127

 *  The terminal process failed to launch (exit code: 127).
 *  Terminal will be reused by tasks, press any key to close it.

the Austin output in vscode appears to indicate it's being launched through bash, rather than zsh
/bin/sh: austin: command not found

It's possible this error is unrelated to austin at all, but rather my misunderstanding of vscode settings. I suppose it may also be related to #21.

@k-a-mendoza thanks for reporting this. How did you install Austin? Was it through homebrew? If so I'd expect it to be available from any shell, so the command not found error is a bit weird. Please note that Austin on macOS requires sudo. Perhaps following the discussion here might help https://github.com/P403n1x87/austin/issues/124. Let me know how it goes.

Closing due to inactivity. Feel free to re-open if necessary.


Unwanted Buffers created on the output data and boundary

I was trying to export data using a geojson file of Itahari Sub-Metro, Nepal as follows:

But after the processing is complete, you can see the boundary file has changed in the following screenshot.

The buffer has been created although I didn't select the activate buffer option.
I visualised the data in GIS and noticed the data outside of my original AOI has also been downloaded. The extent of AOI has been revised and it's the updated-buffer-boundary now (labelled as clipping boundary in the screenshot).

Hi @ghimiresushma99 , thank you for providing so much details in the issue, this will surely help developer to look in to it.
Meanwhile, Currently we are testing geojson and shapefile option on our staging server , If possible can you try same export on staging server and visualize the clipping boundary ? To see either it also has the same error or not !

I can verify that this bug is due to the feature that export tool simplifies the geometry if geometry contains too many points to make query faster ! Using galaxy this can be enhanced and put in to consideration as galaxy supports complex geometry as well

The issue is similar in the staging server too.
The geometry is oversimplified which does not meet the objective of specifying AOI by giving a boundary of that region.
If simplification of the boundary is necessary to ensure the fast operation of the query, this simplification can be reduced such that the out-of-boundary data, which is usually unnecessary to users is not exported as well.

This feature is live on our staging server , You can use Preserve Geometry Option on the Summary @ghimiresushma99


Removed the BLC from travis jobs on release/1.3

@khussey, It appears the environment variables holding the container registry credentials changed. I think it is safe for you to merge (with your super-powers) since we don't expect to ship any docker images on the 1.3 branch and keep it alive only for docs.


Use Threads target. Fixes Android.

https://github.com/hunter-packages/tesseract/releases/tag/v3.05.01-hunter-3


Add cross reference between SCons Configure Context and CMake equivalents

Add cross reference between SCons Configure Context and CMake equivalents
Either in Wiki or in Appendix to Users guide..

Maybe also add cross ref with autoconf/automake? Though I think the checkers should be named the same.

I don't use cmake, so don't know about this.
Someone tried to create autoconf xref in wiki, it may predate the current configure implementation, don't know.


pkg/kvstore: fix nil pointer in error while doing a transaction in etcd

txnresp can obviously be nil if err is != nil. We should check if
txnresp.Succeeded after checking if err == nil first.
Fixes: 84291c30ece5 ("pkg/kvstore: implement new *IfLocked methods for etcd")
Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

Coverage increased (+0.004%) to 44.594% when pulling 63a474f5fa2d9b43046fe171748050f5731a73c1 on pr/fix-nil-kvstore into 57fa7a626db1246f769557821ec721caf4d3d1e7 on master.

test-me-please

test-me-please


Create IQirMachine interface

This change implements the interface to submit a Q# program for execution in Azure Quantum using a QIR executable.

@samarsha this is the idea for the interface that the QIR machine class would implement. It is very similar to IQuantumMachine.
The assumption that I am making is that we would extend the EntryPointInfo class to contain data about the names of the arguments.
One idea to extend the EntryPointInfo class would be to add a new property called InData which is of type Tuple<Type, ITuple<string>?>. The Type  portion of the tuple is the same as the InType property while the ITuple<string>? portion has the same structure as the Type portion but the values represent the names of each argument. Note that it is nullable in case it is a QVoid operation. Does it make sense?

To clarify, the client needs three pieces of information for each entry point argument, right?

Name
Type
Value

Would an encoding like this be sufficient? (Using F# for brevity, but we can convert it to C#.)
type ArgumentValue =
    | Bool of bool
    | Integer of int64
    | Double of float
    | Pauli of Pauli
    | Range of Range
    | Result of Result
    | String of string
    | Array of ArgumentValue[]

type Argument = { Name: string; Value: ArgumentValue }

val SubmitAsync:
    args: Argument list
    * qir: byte[]
    * configureJob: ConfigureJob
    -> IQuantumMachineJob Task

Yes, an encoding like that would be sufficient.


Help...Failed to prepare distributions

When I run the  uv pip install -r requirements.txt  I get the following error:
E:\speech-to-speech huggingface\speech-to-speech>uv pip install -r requirements.txt
 Updated https://github.com/andimarafioti/MeloTTS.git (b6604df)
 Updated https://github.com/huggingface/parler-tts.git (8e465f1)
Resolved 208 packages in 4.03s
error: Failed to prepare distributions
  Caused by: Failed to fetch wheel: aliyun-python-sdk-core==2.15.2
  Caused by: Failed to run `C:\Users\Administrator\AppData\Local\uv\cache\builds-v0\.tmpfUqYcT\Scripts\python.exe`
  Caused by: stream did not contain valid UTF-8

I just new to this , any solutions? thanks!

Hey @westoned, it is tough to help without being able to reproduce your issue. I can see that You are trying to install dependencies on a Windows machine that we do not officially support. I'd be glad to help but I can't do more than a Google search here...


New Design: Photo Quality (Mobile)

Some of the photos on the individual listing page would not sharpen. The first main photos would be clear but after like photo number seven or so, they would become and stay blurry.
First noticed this on Tiffany's Catering.


HBASE-26421 Use HFileLink file to replace entire file‘s reference whe…

…n splitting

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 11s
master passed

+1 :green_heart:
compile
4m  6s
master passed

+1 :green_heart:
checkstyle
1m 36s
master passed

+1 :green_heart:
spotbugs
2m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 46s
the patch passed

+1 :green_heart:
compile
4m  0s
the patch passed

+1 :green_heart:
javac
4m  0s
the patch passed

-0 :warning:
checkstyle
1m  9s
hbase-server: The patch generated 1 new + 258 unchanged - 2 fixed = 259 total (was 260)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
3m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

54m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3842

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux f807eb951a73 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cb3ecf65fd

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
95 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 18s
master passed

+1 :green_heart:
compile
1m 31s
master passed

+1 :green_heart:
shadedjars
8m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 57s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

+1 :green_heart:
shadedjars
8m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 54s
hbase-common in the patch passed.

-1 :x:
unit
161m 49s
hbase-server in the patch failed.

198m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3842

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cbcb8b91cda1 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cb3ecf65fd

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/testReport/

Max. process+thread count
3716 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
compile
3m 11s
master passed

+1 :green_heart:
checkstyle
1m  8s
master passed

+1 :green_heart:
spotbugs
2m  3s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
the patch passed

+1 :green_heart:
compile
3m 11s
the patch passed

+1 :green_heart:
javac
3m 11s
the patch passed

-0 :warning:
checkstyle
1m  7s
hbase-server: The patch generated 1 new + 258 unchanged - 2 fixed = 259 total (was 260)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m  9s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
2m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

48m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3842

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 5a9f97ab0b19 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1c47f80d83

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
master passed

+1 :green_heart:
compile
3m 10s
master passed

+1 :green_heart:
checkstyle
1m  8s
master passed

+1 :green_heart:
spotbugs
2m  2s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
the patch passed

+1 :green_heart:
compile
3m  9s
the patch passed

+1 :green_heart:
javac
3m  9s
the patch passed

-0 :warning:
checkstyle
1m  9s
hbase-server: The patch generated 1 new + 258 unchanged - 2 fixed = 259 total (was 260)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m  4s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

48m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3842

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 9c79ed53f986 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1c47f80d83

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 I have fixed the broken UT and checkstyle issue, please take a look at your convenience, thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 13s
master passed

+1 :green_heart:
compile
1m  8s
master passed

+1 :green_heart:
shadedjars
9m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
9m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
158m 35s
hbase-server in the patch passed.

192m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3842

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 896194cb9379 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1c47f80d83

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/testReport/

Max. process+thread count
4032 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 42s
master passed

+1 :green_heart:
compile
1m 36s
master passed

+1 :green_heart:
shadedjars
10m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 46s
the patch passed

+1 :green_heart:
compile
1m 38s
the patch passed

+1 :green_heart:
javac
1m 38s
the patch passed

+1 :green_heart:
shadedjars
10m 11s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
234m 41s
hbase-server in the patch passed.

274m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3842

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f618e7099d8e 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1c47f80d83

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/testReport/

Max. process+thread count
2753 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

The failed TestReplicationKillMasterRSWithSeparateOldWALs and TestReplicationEndpointWithMultipleAsyncWAL are not relevant to this PR.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.


Enforce closing of files in 0.9.x

I had a recurring problem where my carbon-cache.py writer thread would deadlock which I traced down to a race condition in whisper.py.  I had enabled Flock locking.  When an error occurred updating the WSP file (like a zero length file which generated the CorruptWhisperFile exception) the WSP file would not be closed.  A race condition between the Python GC (which would close the file referenced by an out of scope variable) and the next time there were data points to write to the same corrupt WSP file triggered a deadlock.  As the out of scope file descriptor wasn't closed the file was still locked and the writer thread would wait forever trying to obtain an exclusive lock on the same file.
This should easily be fixed by enforcing that files get closed.  I found that the master branch does this  but not 0.9.x.  I would offer a pull request but I much perfer the current method of using Python's with statement to the original commit's try/except/finally:
f610a6505a76df4f4dca9099c0d9c6824b80cb57
That commit has been cleaned up several times since making it difficult to back port.
Is anyone up for a backport of this?  Or should I make a pull request with the original patch?
Is the master branch stable enough to run in production with a 0.9.12 / 0.9.13 Graphite setup?

 If you're ever in Chicago, find me for free :beers:


Update transformers dependency

The transformers dependency is fixed to version 4.29.2. However, the most recent transformers version is 4.44.0, as of writing this (see Releases for updates).
Downstream projects will require a recent transformer version, so the version should be updated, or un-pinned to allow for compatibility with more recent version.
Is there are a reason for pinning this dependency version?

I see now there is some inconsistency between setup.py and requirements.txt.

You are right about the requirements.txt, I missed that. My apologies.
The issue I encountered regarding the transformers dependency was unrelated. I have been looking into it and found out it is about the indirect adapters dependency. With a transformers version >=4.40, I get the following error when I try to install my package (my_package):
$ pip install -e .
[...]
INFO: pip is looking at multiple versions of adapters to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install adapters==0.2.1, my_package==0.0.1 and my_package because these package versions have conflicting dependencies.
    adapters 0.2.1 depends on transformers~=4.39.3
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

However, when I have transformers==3.39.0, this does not seem to be an issue.
The issue itself is hence resolved. I have not been able to figure out why adapters==0.2.2 does not work with wtpsplit, there must be an indirect dependency somewhere in the tree.


Settings reordered by resolving conflicts

Testing https://github.com/microsoft/vscode/issues/91226
I set up sync in window A, set some settings, then set one setting in window B, enabled sync, and was confused by the conflict resolution diff.
Window A settings:

Window B settings, I just set one:

And I got a conflict resolution prompt as expected, and clicked the button to see the diff, which is confusing. I expect to just see the one fontSize setting on the right. Or, I expect to see the merged settings on the right with just the one fontSize setting in conflict. Instead it reordered autoSave and autoSaveDelay:

Agree that this is confusing but can be explainable. Order of a setting is tried to retained while merging. It is retained by it's previous setting or by its next setting.
Since files.autoSave and files.autoSaveDelay are after editor.fontSize they are tried to place under it when merged. Order of editor.fontSize is retained in the local (machine B) as it is the file that is getting merged and hence it is respected.

I see, I'm not sure how it could be improved but yeah it's confusing that the result doesn't really match either the local or the remote settings.


[BUG] API: k8s/clusters/<CLUSTER_ID>/v1 500 Error

Rancher Server Setup

Rancher version: 2.7.4 / 2.7.5
Installation option (Docker install/Helm Chart):

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1 / RKE2

Proxy/Cert Details:

Information about the Cluster

Kubernetes version:
Cluster Type (Local/Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):
RKE1(Nutanix), RKE2(VMware)

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

If custom, define the set of permissions: ADMIN

Describe the bug
When using the official Terraform Rancher Provider to create resources i.e. Secrets/Confimaps the provider fails, when the Cluster is deleted from the outside(i.e. removed via the Rancher UI).
Terraform ouputs the following error:
Error: Getting configMap V2: Timeout getting Catalog V2 Client at cluster ID c-m-someid: Bad response statusCode [500]. Status [500 Internal Server Error]. Body: [lost connection to cluster: failed to find Session for client stv-cluster-someid] from [https://domain/k8s/clusters/c-m-zpflb68b/v1]
This is due to the k8s/clusters/<CLUSTER_ID>/v1 endpoint returning with status code 500 and running into an timeout for unknown cluster ids.
Expected Result
Should return 404

Related:
https://github.com/rancher/rancher/issues/41991


U+2639 Frowning Face Emoji renders incorrectly on Android

The frowning face emoji does not render correctly on Android, even though typical Android fonts such as Noto Color Emoji support it.

Another dev reported this issues ~2 years ago, but it was closed because technically users can override the default fonts in order to get the emoji to work.
I haven't found a solution yet that works without importing Google Fonts, which shouldn't be necessary. In theory specifying Noto Color Emoji or NotoColorEmoji should work, but it didn't when I tried it in the Android simulator.

Coming into this I assumed that Android bundled Noto Color Emoji, or at least that Pixel phones would include it. I still suspect that this is true, but maybe for some reason Flutter isn't able to access it. I don't know enough about how Flutter and Android handle fonts to say either way. I just doubt that every Android app that uses emojis is forced to bundle an emoji font. That would be madness.

Yes I agree and that's probably that's the case, Flutter apps must not able to access the native fonts for some reason. I will continue to keep my eyes open for an explanation or solution.

I asked a question on the Flutter repo since after searching for a while this morning I wasn't able to find any documentation explaining how Flutter interacts with system fonts. Hopefully someone can clarify.

https://github.com/flutter/flutter/issues/48381#issuecomment-1879766322

@emesterhazy Good news! I was told by another Flutter dev that this issue is solved from 3.18 and I could confirm it with current beta that the frowning face and others are being rendered correctly! 🤩 Not sure which exact commit did it, tho.

Since Flutter 3.19 has been released and the issue is solved, I think we can close this issue 🙏 Thanks for your help !


Matplotlib RuntimeError() whenever Eureka is imported and plt.show() is called.

Whenever Eureka is imported into a file, attempting to call plt.show() for a matplotlib.pyplot plot results in the error copied below.
If Eureka is simply not imported, but the same anaconda environment is used, no such error appears. It's important to note that you don't have to actually use Eureka / specify any latex for this to appear. Simply importing the package whilst trying to call plt.show() results in this error.
Temporary workaround is to add the following lines at some point in the code prior to any calls to plt.show()
from matplotlib import rc
rc('text', usetex=False)

However, this isn't the best long term solution. Current thought is that the error is being raised by the use of latex in label text within the Eureka package, and whether 'r' should be placed before the label text itself. I expect we need to discuss whether the 'r' is important or not, personally I've never had to include it and any latex commands (e.g. $\mu$) have been interpreted correctly by matplotlib.
Final note, it seems this issue isn't unique to me, and at least 3 other people experienced this during the ERS hackathon.

Mac OS Catalina 10.15.7
Python 3.9.5 Anaconda Environment
Traceback (most recent call last):
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/texmanager.py", line 252, in _run_checked_subprocess
    report = subprocess.check_output(
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/subprocess.py", line 505, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/subprocess.py", line 1821, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'latex'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/backends/backend_macosx.py", line 45, in _draw
    self.figure.draw(renderer)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/artist.py", line 74, in draw_wrapper
    result = draw(artist, renderer, *args, **kwargs)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/artist.py", line 51, in draw_wrapper
    return draw(artist, renderer, *args, **kwargs)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/figure.py", line 2780, in draw
    mimage._draw_list_compositing_images(
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/image.py", line 132, in _draw_list_compositing_images
    a.draw(renderer)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/artist.py", line 51, in draw_wrapper
    return draw(artist, renderer, *args, **kwargs)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/_api/deprecation.py", line 431, in wrapper
    return func(*inner_args, **inner_kwargs)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/axes/_base.py", line 2921, in draw
    mimage._draw_list_compositing_images(renderer, self, artists)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/image.py", line 132, in _draw_list_compositing_images
    a.draw(renderer)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/artist.py", line 51, in draw_wrapper
    return draw(artist, renderer, *args, **kwargs)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/axis.py", line 1137, in draw
    ticklabelBoxes, ticklabelBoxes2 = self._get_tick_bboxes(ticks_to_draw,
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/axis.py", line 1063, in _get_tick_bboxes
    return ([tick.label1.get_window_extent(renderer)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/axis.py", line 1063, in <listcomp>
    return ([tick.label1.get_window_extent(renderer)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/text.py", line 903, in get_window_extent
    bbox, info, descent = self._get_layout(self._renderer)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/text.py", line 306, in _get_layout
    _, lp_h, lp_d = renderer.get_text_width_height_descent(
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/backends/backend_agg.py", line 229, in get_text_width_height_descent
    w, h, d = texmanager.get_text_width_height_descent(
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/texmanager.py", line 399, in get_text_width_height_descent
    dvifile = self.make_dvi(tex, fontsize)
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/texmanager.py", line 291, in make_dvi
    self._run_checked_subprocess(
  File "/Users/acarter/anaconda3/envs/eureka/lib/python3.9/site-packages/matplotlib/texmanager.py", line 256, in _run_checked_subprocess
    raise RuntimeError(
RuntimeError: Failed to process string with tex because latex could not be found

One workaround may be to run the above two lines only if an exception is thrown.  That way those with Latex can still enjoy the nice labels.  Long term, I'm not sure what a good solution would be.

I suppose the issue is that the user has to run those lines on their end, even if they don't directly use anything from Eureka. I'm not sure if it's possible to get the package to detect if a plt.show() causes a crash somewhere in an exterior file.
To be clear though, I have Latex installed and want to enjoy nice labels too! I've attached a nonsense plot below which was made in the exact same anaconda environment as above, but without importing Eureka, as you can see the latex commands have been readily understood for the axis labels.
import matplotlib.pyplot as plt

y= [1,2,3,4,5]
z=[10,11,12,13,15]

plt.plot(y,z)
plt.gca().set_ylabel(r'$\Sigma \mu$', fontsize=14)
plt.gca().set_xlabel(r'$\rho \pi$', fontsize=14)
plt.show()

Can you tried the following suggestions from Stack Overflow?
https://stackoverflow.com/questions/54477891/filenotfounderror-errno-2-no-such-file-or-directory-latex-latex-python
Maybe this will help us to identify a solution that we can then post in an FAQ section on the Eureka! webpage.

When I ran Eureka! for the first time on a different machine, I got the same matplotlib error.
I fixed it by checking out the same Stack Overflow Kevin just posted and installing: sudo apt install cm-super
I actually mentioned it in the docs quickstart (https://eurekadocs.readthedocs.io/en/latest/quickstart.html#run-eureka)

Okay, thanks very much for the links! Unfortunately I couldn't get Sebastian's solution to work, however from Kevin's link I was able to piece together a permanent solution... I think.
The trick is to identify where your TeX installation is and manually add it to PATH in your bashrc or bash_profile (whichever you use). So, for my case the following line in my ~/.bashrc:
export PATH="~/anaconda3/bin:$PATH"
Changes to...
export PATH="~/anaconda3/bin:~/Library/TeX/texbin:$PATH"
If you are using Ubuntu or an older version of Mac it might be in /usr/bin instead. Also, for anyone reading this who isn't familiar with editing bashrc/bash_profile, make sure you run source ~/.bash_profile or source ~\.bashrc to apply the changes, or simply close and reopen the terminal window you're working in.
I'm still pretty confused as to how I was able to create the plot above without making this change / why importing Eureka produced the error. However, I'm not sure it's worth spending too much more time figuring things out. If you're comfortable with this current solution Kevin feel free to close this issue.

@gianninapr Can you capture the list of potential solutions given above for this problem and add it to the webpage (possibly under a Troubleshooting header)?  Thanks!


Start using prefetch hooks

Context
Adding that task just to remember, that we have a dependency on composition-api.
Dependencies

https : // github.com / vuejs / composition-api / pull / 80

https://github.com/vuejs/composition-api/pull/80/files - seemingly it has been done on the branch

Commit was made on on Aug 24. @filrak bumped it in the comment on Nov 6.


Release vp1

closes #256

Codecov Report

Merging #255 (e39628b) into master (417893f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   52.93%   52.94%   +0.01%
==========================================
  Files          23       23
  Lines        2747     2748       +1
==========================================
+ Hits         1454     1455       +1
  Misses       1293     1293

Impacted Files
Coverage Δ

hnn_core/__init__.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417893f...e39628b. Read the comment docs.

Codecov Report

Merging #255 (e39628b) into master (417893f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   52.93%   52.94%   +0.01%
==========================================
  Files          23       23
  Lines        2747     2748       +1
==========================================
+ Hits         1454     1455       +1
  Misses       1293     1293

Impacted Files
Coverage Δ

hnn_core/__init__.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417893f...e39628b. Read the comment docs.

okay I just uploaded on test.pypi to see if the sdist approach works. Can someone give it a shot on:

[ ] Linux
[ ] Mac
[ ] Windows

$ pip install --index-url https://test.pypi.org/simple/ hnn-core

Tried following on macOS Catalina:
conda create -n hnn_pip python=3.7
conda activate hnn_pip
pip install --index-url https://test.pypi.org/simple/ hnn_core

Resulting in
Looking in indexes: https://test.pypi.org/simple/
Requirement already satisfied: hnn_core in /Users/au210321/miniconda3/envs/hnn_pip/lib/python3.7/site-packages (0.1)
Collecting hnn_core
  Downloading https://test-files.pythonhosted.org/packages/88/e1/818763673c61c0b22823ca3d9e36ed03ef84ae53c56bad50b63521fb8389/hnn-core-0.1.3.tar.gz (100 kB)
     |████████████████████████████████| 100 kB 2.9 MB/s
  Downloading https://test-files.pythonhosted.org/packages/c4/eb/c4266a4e53828cde9bcd33074177e0d7f3951265f15fd84507d4402eac14/hnn-core-0.1.2.tar.gz (100 kB)
     |████████████████████████████████| 100 kB 3.8 MB/s
  Downloading https://test-files.pythonhosted.org/packages/7d/18/40e2db1956d14cae0d990bd7631325690777100aed1ea23a11a27145c413/hnn-core-0.1.1.tar.gz (224 kB)
     |████████████████████████████████| 224 kB 4.0 MB/s

So no dependencies were downloaded, and it didn't even attempt to compile the mechanisms :( My username on test.pypi is cjayb...

Looking at setup.py, is it just because build_mod is only defined but never called? I'm not totally sure is the setup() function is supposed to do that automatically or not.

So no dependencies were downloaded, and it didn't even attempt to compile the mechanisms

why do I see only downloading and no installing message logs? Are you sure there wasn't an existing version of hnn_core available in your environment that needed to be removed first

Looking at setup.py, is it just because build_mod is only defined but never called?

It's used here: https://github.com/jonescompneurolab/hnn-core/blob/master/setup.py#L107

@cjayb can you verify that after this step

conda activate hnn_pip

you can't import hnn_core in ipython

Looking at setup.py, is it just because build_mod is only defined but never called?

It's used here: https://github.com/jonescompneurolab/hnn-core/blob/master/setup.py#L107

That's what I mean, I was under the impression that pip internally runs setup.py install. Does it automatically use the commands defined in cmdclass as well?

I was under the impression that pip internally runs setup.py install

right this is what I think too. And the "install" command in the setup file calls the "build" command which in turn calls the "build_py" and "build_mod" commands I believe. I guess if bdist is already provided, the "build" command might be skipped.
Do also read this and the rest of the comments on this thread. That's when I was learning how all this works.

Some progress here. Part of our problem is that we're testing a non-standard installation (via test.pypi). Setting the --index-uri means that pip can't find the dependencies! A simple fix was to use  --extra-index-url instead:
pip install --force-reinstall --extra-index-url https://test.pypi.org/simple/ hnn_core

This pulls in all the dependencies (yay!) and triggers a build (yay^2!), but alas:
  => Building mod files ...
  error: [Errno 2] No such file or directory: 'nrnivmodl': 'nrnivmodl'

which is because hnn_core is running its build before NEURON (and nrnivmodl) are installed. Simply re-running the above pip-line now works.
Haven't been able to figure out how to force the dependencies to be installed before build, any thoughts? We're so close... :)

Based on some digging (here, here, here and of course here ), 7a189ee seems to work on my machine locally! @jasmainak try uploading to test.pypi?

Just uploaded again to test.pypi! This is turning out to be quite the teamwork :)

Yeah!

[x] macOS Catalina, including build

also maybe need to update MANIFEST.in to include it in the dist/?

I don't think this is needed: the file is only relevant for installation using setuptools, then safe to ignore. Unless of course it's somehow relevant when upgrading.

okay so here is the game plan I propose:

@ntolley tests this one Windows and tells us if it works/ if it needs further changes. But I guess we don't want to spend too much time on it. If we can get it to work in a day or two that's good. Otherwise, I suggest we go for a release with only Linux and Mac support for now. It would be great to have it working though.
@rythorpe makes the wordsmithing PR on the somatosensory example with links to HNN tutorials. This is not urgent though. The website can always be updated later ... we will however freeze the website at the 0.1 release or after Ryan makes the PR. So that users don't get confused by mismatch between examples and hnn-core version.
you guys approve this PR when it's good by you
I'll self-merge (because I want to be 100% sure myself that everything works) and make the release on pypi.

Windows install is proving finnicky. Here is the output from pip install --no-deps  https://test.pypi.org/simple/ hnn_core -vvv

It's not very obvious to me where this is failing as I thought the directory error was resolved with my more recent commit. Not sure if I'll be able to troubleshoot too intensely until next week so it may be worth holding off on the windows release? I'm hoping it's a fairly straightforward discrepancy in the windows directory but hard to say at the moment.

okay let's move forward without Windows. If we do find a fix later, we can backport it. I'll let some Windows user complain before fixing it :) FWIW, we did make it work before with @kohl-carmen in the development environment. But unfortunately my antiquated Windows machine is complaining too much now ... so I'll skip this step for now.

alright folks, single line install of hnn-core is here.
$ pip install hnn-core

Enjoy Mac and Linux users!

@rythorpe makes the wordsmithing PR on the somatosensory example with links to HNN tutorials. This is not urgent though. The website can always be updated later ... we will however freeze the website at the 0.1 release or after Ryan makes the PR. So that users don't get confused by mismatch between examples and hnn-core version.

I've been in manuscript-writing land and am just getting caught up now - sorry for the very late reply. I'll try to make a PR by the end of this weekend. I'm super excited about this release, it's been a long time coming @jasmainak!

sounds good! You might have to do something like https://github.com/jonescompneurolab/hnn-core/commit/1a1072d597f9553f52425a9d875bdf9dc84f9156 if you want to push the changes to 0.1 documentation.


MAUI

We will do this once MAUI is released.

Excited. Where is the link?

It's here
https://github.com/IdentityModel/IdentityModel.OidcClient.Samples/tree/main/Maui

this is only authentication. we need a complete sample that get data through HttClient from server API that has "authorize" attribute.


Bump dcos-metrics version

High Level Description
This updates metrics in dcos master to include two bugfixes. These are already merged in the 1.9.3 branch.
Related Issues

DCOS_OSS-1451 Stale datapoints can occur in container metrics
DCOS_OSS-1486 Metrics agent crashes when the mesos containers endpoint is missing fields

Checklist for all PR's

[x] Included a test which will fail if code is reverted but test is not.
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): changelog
[x] Test Results: link to CI job test results for component
[x] Code Coverage (if available): link to code coverage report

@collinvandyck and @darkonie , would you mind reviewing this when you get a minute?

@mesosphere-mergebot label ready for review

@mesosphere-mergebot bump-ee

@collinvandyck yes, that's in master. It's not in the changelog because it's a plugin and doesn't have any impact on the code that gets built into DC/OS.

The enterprise build failures are failing on other PRs as well.


multipe y axis for same dataset

I'm trying to get ticks on both the right an left of the chart that use the same data sets. A simple example would be time on the x axis, miles on the left and km on the right. but more specifically I'm working on a experience graph for an rpg like so like so
the left is actually experience earned by the character and the right is level. I've achived this with
    ticks: {
        min: 0,
        max: 300000, // set dynamically to equal the left y-axis (max experience)
        stepSize: 1,
        callback: function (value, index, values) {
        const lvlIndex = lvlXP.indexOf(value);
        if (lvlIndex !== -1) {
            return 'lvl ' + (lvlIndex + 2);
        }
   }

but considering that the experience could be as high as 500,000 this requires that callback is called up to 500k times and runs incredibly slowly
Is there an efficient was to handle this? I've looked at the documentation but havn't ben able to find anything relevant to this

@myrddraall it's not possible to have 1 dataset generate the limits for multiple axes. This is because each dataset has only one yAxisID allowed.
One workaround here is to manually set the limits on each axis to the same values using the config options

I've done that as part of my hacky solution
this.xpOverviewChart.update(); // required to genereate the min max on y-axis-0
this.xpOverviewChart.config.options.scales.yAxes[1].ticks.min = this.xpOverviewChart.scales.y-axis-0.min;
this.xpOverviewChart.config.options.scales.yAxes[1].ticks.max = this.xpOverviewChart.scales.y-axis-0.max;
this.xpOverviewChart.update(1000);

though it requires that i call update twice. which isn't to bad, my bigger concern is how to generate the second axis without looping over all the possible values.
is there a way to just tell it something like  value 2010 = label "lvl 2", value 4164 = label "lvl 3" ...
without using the callback?

Something like this: https://codepen.io/kurkle/pen/GRgBgWL?editors=0010

Something like this: https://codepen.io/kurkle/pen/GRgBgWL?editors=0010

yes something exactly like that

Is it posible to plot multiple (more than 2) Y axes?
Something like this or that
I do a test an get limited to two (yAxisID: "y-axis-1" and "y-axis-2"),
maybe I missed something.

Is it posible to plot multiple (more than 2) Y axes?
Something like this or that
I do a test an get limited to two (yAxisID: "y-axis-1" and "y-axis-2"),
maybe I missed something.

Yes, it is possible. Just I was missing...

Yes, it is possible. Just I was missing...

Yes, it is possible. I was missing to set yAxes array properly.
And for custom axis legend color, we need ticks: { fontColor:... }
yAxes: [{
  type: "linear",
  display: true,
  id: "y-axis-1", // default position -> left
  ticks: { fontColor: "#F57" }, // this here
},{
  type: "linear",
  display: true,
  id: "y-axis-2",
  position: "right",
  ticks: { fontColor: "#3AE" }, // this here
  gridLines: { drawOnChartArea:false } // only want the grid lines for one axis to show up
}],

Yes, it is possible. I was missing to set yAxes array properly.
And for custom axis legend color, we need ticks: { fontColor:... }
yAxes: [{
  type: "linear",
  display: true,
  id: "y-axis-1", // default position -> left
  ticks: { fontColor: "#F57" }, // this here
},{
  type: "linear",
  display: true,
  id: "y-axis-2",
  position: "right",
  ticks: { fontColor: "#3AE" }, // this here
  gridLines: { drawOnChartArea:false } // only want the grid lines for one axis to show up
}],

Sorry to resurrect this, but where does the yAxes configuration actually go? Is it inside the options or inside the data?
I am using chart.js 3.8 for reference and could not get this example to work in either.

Sorry to resurrect this, but where does the yAxes configuration actually go? Is it inside the options or inside the data? I am using chart.js 3.8 for reference and could not get this example to work in either.

https://www.chartjs.org/docs/latest/migration/v3-migration.html#scales

So the functionality to have one dataset registered for two scales was removed with the migration from v2 -> v3?

So the functionality to have one dataset registered for two scales was removed with the migration from v2 -> v3?

No, you can define multiple scales, just name them and reference them via yAxisID: 'y1'

Configuration wise thats fine and how we do it at the moment, but how would you assign one dataset to more than one scale then? You can just do yAxisID: 'y1', and not yAxisID: ['y1', 'y'], right?
The only way i found this to work is to register the same dataset twice, once for the left y-axis scale and then again for the right y-axis scale. But this comes with its own problems, because the one dataset i want to show is shown twice.
This sandbox does it this way:
https://codesandbox.io/s/chartjs-two-axis-sandbox-zhvlsf?file=/src/index.js

For everyone else who's looking for a solution for Chart.js 4.x:
A hacky way would be to imitate the original y axis where your dataset is bound to, by modifying your scale id before data limits are calculated. To make sure you don't break anything you can reset the id in afterDataLimits, but for me nothing was breaking. Just set and forget!
options: {
  scales: {
    levels: {
      beforeDataLimits: function(axis) {
        axis.origId = axis.id;
        axis.id = "y";
      },
      afterDataLimits: function(axis) {
        axis.id = axis.origId;
      },
      // manually mirror ticks, stepSize and so on from y axis
    },
  },
}

A more robust solution would be to update and get min max values from the y axis, which is bound to the dataset.
options: {
  scales: {
    levels: {
      afterDataLimits: function(axis) {
        const y = axis.chart.scales.y;
        y.determineDataLimits(); // update y.min/max
        axis.min = y.min;
        axis.max = y.max;
      },
    },
  },
}


Transfer - Relationship with mastermold

@jpscaletti
Admittedly, I do not understand what mastermold is.
How is it related to copier?
What is the mm.py file for?

It's unnecessary now, especially because this project has different defaults, like mypi.
I wrote about it here: https://jpscaletti.com/master-mold-for-python-packages/

mm.py got removed via ced4284


Remove type arguments from error types

NOTE:  "Remove tip argument to ChainSyncClient" is #1238.
This commit paves the way for consensus error policies. It removes type parameters from exception types, so that we cannot introduce bugs where we miss certain exceptions because due to (type) matching on exceptions of the wrong type (e.g., instantiated to header instead of block).
It also removes onSlot from BlockchainTime. This was used only in tests, where it is easily replaced.

Yes, will do. Once 1238 is merged, will rebase and reintroduce the exception in the consensus tests.

bors r+


Delete room?

Good day to all! I use js client, php server. When trying to delete room in front got 401 and as i see i cant delete room using php too? Thanks guys!

The default role that users are given doesn't have permissions to delete a room. You can find out more about that here: https://docs.pusher.com/chatkit/roles-and-permissions#initial-app-permissions
The "fix" here is to either change the permissions associated with the default role in your app, or to assign the user who you want to be able to delete the room an appropriate role that has the room:delete permission.
We could add the ability to delete rooms from the PHP SDK as well though. Although it should be quite easy to add if you're in need of it. We're more than happy to accept a pull request!

Cant understand why its not working. Need some help guys
`public function makeItModerator($user_id)
{
$body = array(
"name" => "admin"
);
    $token = $this->generateToken(array(
        'user_id' => $user_id,
        'su' => true
    ));

    $ch = $this->createCurl(
        $this->api_settings,
        '/users/' . $user_id . '/roles',
        $token,
        'PUT',
        $body
    );

    return $this->execCurl($ch);
}`

Found reason. I should send it to different url


Support for Segment Anything

Describe the feature
Allow transfer learning using FAIR's Segment Anything Model (SAM), which is a ViT under the hood.
Motivation
SAM is an Apache-licensed instance segmentation model trained on over a billion images. They claim that is a foundation model for instance segmentation.
Support for fine-tuning SAM is one of the most requested features in the downstream repository (see https://github.com/facebookresearch/segment-anything/issues/5).
Related resources
Official website, with demo
SAM weights from the official repo
Semantic-SAM
timm implementation (for classification)

@crypdick Thank you very much for your interest. We will soon support RSPrompter, which includes fine-tuning capabilities.

Do we have support this yet?

插眼


Added example for using unions of models, useful for agents

This is the example from https://github.com/jxnl/instructor/discussions/296
I searched for Union in the sources - and it seems that there are no examples of this approach.

Summary by CodeRabbit

New Features

Introduced a new tool selection functionality with options for search, lookup, and finish actions.
Enhanced integration with external APIs using response models for better action processing.

do you mind:

move to examples/union/run.py
add some docs to https://jxnl.github.io/instructor/concepts/union/

I would rename the concept to Agent - because this is what people are looking for.


Release a new version

There's been a suite of recent changes to substrait-validator, and it would be useful to release a new version, as mentioned briefly here.
I'm opening this issue to raise the question - what features or changes (outside the documented release chores) do we want before we're ready for a new version?

In my opinion we can just bump versions and push a new release now and repeat this whenever beneficial.

Ah, ok! Fair enough.
🤔  I'm not sure how automated it currently is / how well it will work; it looks like there's a Github Action for releasing (Python too), so if we tag the commit with a version number that should trigger it? I guess we'll have to see how functional that is 🤞
I can put together a PR for that. @mbrobbel - did you want to get #276 in first? It looks like that would update the Python packager maturin, which might affect this.

did you want to get #276 in first?

No, let's not block this release on that.

OK! I'll put together a PR for that. Any thoughts on the version number?
We're currently at 0.0.11; perhaps its time to go to 0.1.0? This seems like more than a patch update, but pre-1.0 I'm not sure it matters much...

^ OK! I made a PR. I went with 0.1.0 for now, but its real easy to switch if there are other opinions. Thanks for your help on this!


proto: can't skip unknown wire type 4 cafe_outbox

Client and cafe both rc28. Fresh install.
11:16:06.693 ERROR   tex-core: cafe STORE request to <redacted> failed: proto: can't skip unknown wire type 4 cafe_outbox.go:199
11:16:06.696 DEBUG tex-servic: sending CAFE_STORE_THREAD to <redacted>/cafe/v0/service main.go:133

This is happening on me from client when attempting to do textile cafes add.
Happening on Linux, Windows, and WSL

Hey @doodlemania2, I spent some time today on our docker container (which needed to happen anyway) in an effort to try and reproduce this on Linux. Sadly, I still cannot. Can you help me with some extra info? I know you said rc43 but just to be sure...

What version is your cafe node running?
What version is your local node running?

If you want to try the docker image (latest is rc45):
$ docker run -it -p 4001:4001 -p 8081:8081 -p 5050:5050 -p 40600:40600 -p 40601:40601 textile/go-textile

I need to put a little more work into that image to allow it to be used as a cafe, but you could use it as a client and then register against my dev cafe (running rc45 as well):
$ textile cafes add http://<IP_ADDRESS>:40601 --token <token>

Will DM you with my that token.

You could docker exec -it <name> "/bin/sh" and configure the node as a cafe as well.

Gonna close this for now. Based on our DM convo, seems to be working w/ latest versions.

still getting proto errors in a few places...here's some logs:
server says hello:
00:02:06.421 DEBUG   tex-core: received CAFE_CHALLENGE from 12D3KooWQ7jRq96ZipeNkNf3J2Wr9d7tPmxG61vR38EFWvvyHiLh cafe_api.go:276
[GIN] 2019/02/28 - 00:02:06 | 200 |    32.65223ms |   <IP_ADDRESS> | POST     /cafe/v0/service
00:02:06.537 DEBUG   tex-core: received CAFE_REGISTRATION from 12D3KooWQ7jRq96ZipeNkNf3J2Wr9d7tPmxG61vR38EFWvvyHiLh cafe_api.go:276
[GIN] 2019/02/28 - 00:02:06 | 200 |  160.244974ms |   <IP_ADDRESS> | POST     /cafe/v0/service
client then says:
28 Feb 19 00:01 UTC  vvyHiLh added ANNOUNCE update to thread PyvU4Umz
proto: can't skip unknown wire type 4
appears registration worked - textile cafes ls shows "stuff"
so the bug, if it is a bug, is somewhere right after the challenge and prior to the client spitting out the registration information
in a while (dinner time now) i'll try to add some pics to a thread and see if magic happens
Also, at least one other operation is encountering proto which is textile cafes messages

Hmm, okay... reopened. What type of machine is the client on?

Cool.

Windows 10 running Textile 46 in WSL mode (WSL=Ubuntu)
Ubuntu 18.04 running Textile 46
Ubuntu 16.10 running Textile 46
Windows 10 running Textile 46 using the Windows binary.

All sad face with proto error but registration does appear to be working. Haven't gotten to attempting to upload a file yet to see if it actually uploads to cafe - that's next!

Are these nodes brand new or have they seen some migrations?

newbies - most of my testing, i wipe .textile each time just to be sure :)

Just an FYI, confirmed this same error running a Cafe and a client using Docker on Linux 18.10 giving same error :(

Thanks @doodlemania2 - I'm spinning up Ubuntu now so I can reproduce. More soon.

Okay to close! Suggest adding some sort of validation on cafe setup with the URL requiring http://andaportnumber:somethinghere

Thanks for the patience @doodlemania2 - I'll be working on a detailed cafe guide this week.


Minor warning about nameScheme property

Issue
On startup, plugin complains about invalid key in the config.json. It looks like it was removed in this commit: 5871b3b5fe319ec8defe49dc168674c844ec389d but there is still a reference to it in the README.md file.
It's just a warning in the logs, so it shouldn't cause problems.
I thought I'd post this issue to help others, as I didn't notice this called out in any release notes.
I can easily remove from the config.json, I was just doing some research to make sure that was going to be fine, and see if I could find out what happened (or what I missed).
Log Messages
[Sonos] warning: config.json: nameScheme: invalid key

Debug Files
(skipping the debug log, since this doesn't seem needed in this case. but, let me know if I'm mistaken)

Removed the mention in README.


Comical "use strict" prologue emitted in .json files with --alwaysStrict

./foo.json
{
    "lol": "what"
}

./foo.ts
import Foo = require("./foo.json");

Foo.lol

./tsconfig.json
{
    "compilerOptions": {
        "alwaysStrict": true,
        "module": "commonjs",
        "resolveJsonModule": true,
        "moduleResolution": "node",
        "outDir": "lib"
    },
    "include": [
        "./foo.ts"
    ]
}

Expected
foo.json is emitted as
{
    "lol": "what"
}

Actual
foo.json is emitted as
"use strict"
{
    "lol": "what"
}

@DanielRosenwasser I'll work on this issue if you don't mind

Following example from today's announcement post I've stumbled exactly on this issue :) Otherwise, this feature is amazing!


Cannot read from localhost or local file after Windows OS update (21H1 19043.1052)

After updating to latest Windows OS version 21H1 19043.1052 stops WebView to read localhost file. Also file:// url kills the WebView.
ms-appdata:///local/ seem to work.
Environment:

OS: Windows 10
OS version: 21H1
OS build: 19043.1052
react-native-windows version: 0.62.22
react-native-webview version: 10.10

Issue is in all these Windows OS versions
Release Date: 6/8/2021
Version: OS Builds 19041.1052, 19042.1052, and 19043.1052

WebView seems to partially block HTTP requests to non-standard ports after the recent Windows update. E.g. a request to http://localhost:5612 receives a response but apparently without any header information, which is why the WebView considers the response to be plain text and thus doesn't try to render HTML but simply prints the source code. The same request to standard 80 port works without issues.

Several issues might be at play here, none of which seem like a recent OS regression, though.

re: the restriction on localhost, that can be related to network isolation:

https://docs.microsoft.com/en-us/previous-versions/windows/apps/dn640582(v=win.10)?redirectedfrom=MSDN
https://github.com/microsoft/ProjectReunion/issues/113
https://github.com/windows-toolkit/WindowsCommunityToolkit/issues/2226

the app might be missing the private network capability in its manifest: https://docs.microsoft.com/en-us/windows/uwp/packaging/app-capability-declarations

I'm not sure about why a response from a non-standard port would return without header information, did this use to work differently in prior OS releases? I'd be surprised if this changed.

@asklar , we've been using localhost access previously (from WebView) without any issues. So we've adjusted our app capabilities etc. to make it work a long ago. We also tested this against older version of our app to rule out the possibility that some of our own recent change would have caused the issue. The issue started just after the recent OS update last week.
I'll try to run some other investigations on this topic, like if the non-standard ports are blocked also when accessing content outside localhost.

Some of our test findings regarding to the source prop used with the WebView:

<VebView source={{uri: 'ms-appx-web://.../index.html'}} ...  - requests to http://localhost:any-port within the WebView work
<VebView source={{uri: 'file://.../index.html'}} ...  - WebView crashes
<VebView source={{uri: 'ms-appdata:///local/.../index.html'}} ...  - WebView renders HTML but any requests within WebView to http://localhost:non-standard-port fails (according to Edge DevTools the requests are missing response headers, but I'm not sure that can be trusted)
<VebView source={{uri: 'http://localhost:non-standard-port/.../index.html'}} ... - WebView doesn't render the HTML but simply prints the code (we assume it is missing response headers and considers the content to be text/plain)
<VebView source={{uri: 'http://localhost:80/.../index.html'}} ... - WebView renders the HTML perfectly

The internal server we run here doesn't change its behavior in any way based on the port used (unless 443 of course).

@juhasuni is it possible that there was a network isolation exception set up which enabled the app to work, and the update to the new Windows version didn't carry it forward? Can you try enabling the exception as described in the docs I linked above?

Can you try enabling the exception as described in the docs I linked above?

Thanks, I'll check that one next.

@asklar , you meant the loopback exemption? We're not using that, because we don't need inter-communication with other apps and besides it is only meant for dev releases/sideloading.

Just to clarify, the localhost web server in our case is running within the same app. That's why it doesn't (shouldn't) require any loopback hacks.

The issue with accessing http://localhost:non-standard-port has been resolved and it is indeed due to missing headers, but the problem is at our end.
The hypothesis here is, that Windows WebView component prior to last updates was running in some kind of compatibility mode, where it guessed the Content-Type of the response if the header wasn't present. After the update the hypothetic compat mode is only active if the port is standard 80.
Then the issue with file:// URLs seems to be a real one. However, opening content in WebView using file:// URLs is an undocumented feature (not mentioned anywhere in official MS docs). It should be probably stated here as well, that it is not recommended to open content from file URLs (ms-appdata:// is the proper format).

Yes I imagine accessing file:// urls wouldn't work inside the uwp appcontainer.
You can use ms-appx-web, ms-appdata, or http/https. See the webview samples here which show accessing appx-packaged files as well as content through UriToStreamResolver if you need to create content on the fly.


statas.code is 0 in Jeager output

Use the below code to reproduce
https://github.com/shafreenAnfar/springboot-and-ballerina/tree/main/ballerina-user-rest-service

Transferred the issue Ballerina lang as observerbility is done at lang level. Please feel free to re-transfer if needed.

Noticed that the status.code tag only appears in Jaeger and not appeared in Zipkin or New Relic. Also checked whether we add a tag with key name status.code and not found.


UpdateOptions does not have a tostring

in 0.13.9 show updateOptions tells smth like sbt.UpdateOptions@b970d734
i'd prefer something useful like updateOptions.withCachedResolution(true).etc

Hopefully gets fixed in 1.0 using sbt-datatype.
See also sbt/librarymanagement/pull/6.

Closing this as the equivalent ticket exists in sbt/librarymanagement#6.


Added Stock App

Pull Request for PyVerse 💡
Issue Title : Stock App

Info about the related issue (Aim of the project) :
Name: Ananya Gupta
GitHub ID: @ananyag309
Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a WoB 2024 participant it's, WoB Participant)

GSSOC STD and hacktober
Closes: #19
Describe the add-ons or changes you've made 📃
This App show stock details of the entered ticker. - Compnay Profile - Income Statement Details - EPS Chart - Company Current Quotes
Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[x] Any dependent changes have been merged and published in downstream modules.

@UTSAVS26 please have a check and let me know if any changes required further

Yes it looks good now. Great job 👏


Decide how to quantify image similarity

mapping the problem

[x] find complex edge cases and determine scenarios where we want to return an exact match, and where we just want a similarity score.

working with work metadata

[x] simple CNN text classifier
[x] multi-modal CNN text classifier
[x] word2vec and doc2vec on corpus

working with raw images

[x] simple similarity measures (keypoint, histogram, SSIM)
[x] embedding with pre-trained network (eg inception, VGG)

Deep ranking task moved to separate issue (#1957)


Active again?

Hey @jlhawn & @vieux, I have a quick question. What's the status of this package? Are you planning to be more active in terms of merging PRs and adding requested features?

I'm certainly not the final authority on it, but I do not expect anyone to be actively addressing issues and new pull requests on this repository. My recent contribution  was just done to address outstanding issues in one of our commercial products which still uses components which depend on this library. Internally at Docker, we only have products which use the the etcd libkv backend (and still only use the v2 api).
I believe folks from Docker originally began this project as a component of Docker Swarm so that it could be used with multiple key-value stores. While that project is still maintained, there's not been much new feature development there (mostly just bug fixes in order to address issues with Docker's commercially-supported products) and it is not recommended for new Docker users in favor of the newer built-in orchestration features of Docker over the past year. Most of Docker's orchestration development efforts have been focused on those built-in SwarmKit orchestration features and more recently in integrating Kubernetes into the Docker platform.
I would suggest using @abronan's fork (https://github.com/abronan/libkv) for any new projects. He was previously the most active maintainer on this library has it seems he and several others have been actively maintaining that fork. It also includes part of the etcd v2 fix I had worked on here and even has a newer etcd v3 backend and a redis backend.

@jlhawn thank you for the detailed answer!


Console Grid isn't down, but ice is reporting it as unavailable

I'm getting the following error.
There was a problem with '[Grid Images] Cource' in config.txt The Source of game images is unavailable.
Here is my Grid Images section of config.txt
[Grid Images]
The website listed should provide the grid images used by Ice. This URL will
most likely need to be provided by the website itself, as it is fairly specific.

The default is ConsoleGrid (consolegrid.com/api/top_picture)

If this field is left blank, Ice will not attempt to download images
Source=consolegrid.com/api/top_picture

There's a major problem with this which is stopping me from using it entirely. You use "Nickname" to denote the name of the folder that Ice will use for the games, but at the same time you use that same field to look up the images on ConsoleGrid which means that unless your game folders match the names that ConsoleGrid use, it won't work.
Can you please split out these two names into separate options as they're completely unrelated. My folders have specific names and I don't really want to rename everything to fit ConsoleGrid's own naming system.

what enverex said is the same for me. i already had rom and emulator files prior to learning of ices existence creating new sub folders and splitting all of them would be a major pain for me as it would reset alot of the configs i have set up for the games. I am having hte same issue as this thread
=========================Starting Ice
Detected Emulator: Snes9x
Detected Emulator: ePSXe
Detected Console: Playstation 1 => ePSXe
---------------Running for user 12923
---Downloading grid images
=========================Stopping
There was a problem with '[Grid Images] Source' in config.txt
The source of game images is unavailable.

Mhh I have a similar problem adding Atari to my console list. ICE simply breaks because gridImage does not support atari5200 as emulation nickname. Does anyone know of a solution?


Fix retrying batched instructions, work around ESP32S3 external memory access issue

This PR fixes a whole host of bugs that caused issues on Xtensa.

I had a bit of flashing weirdness going on but it seems it's gone without me changing anything, so let's say this is done.


Fix passing redoc UI parameters

Currently passing redoc UI parameters has the following issues:

It puts json-ed values of parameters in single quotes, which breaks if the value itself contains single quotes.
If the value is falsy, only the name of the parameter is used. This syntax is not treated as falsy by redoc.

The latter causes the download button to be always hidden, because the default parameters have "hide-download-button": False. There is no way to un-hide it with the current code.
Change this to use the javascript API to pass UI parameters[1], which is much simpler and more robust.
Also, stop using the "next" version of redoc, as suggested here[2]. This was an old release candidate for version 2. Use the officially released version 2.
[1] https://redocly.com/docs/redoc/deployment/html/#the-redoc-object
[2] https://github.com/tiangolo/fastapi/pull/9700

Summary by Sourcery
This pull request fixes issues with passing Redoc UI parameters by using the JavaScript API and updates the Redoc version to the officially released version 2. It also includes updates to the tests to ensure the changes are correctly implemented.

Bug Fixes:

Fixed issue with passing Redoc UI parameters where JSON values were incorrectly wrapped in single quotes, causing errors if the value contained single quotes.
Resolved issue where falsy values for Redoc UI parameters were not correctly handled, leading to the download button being always hidden.

Enhancements:

Updated the method of passing Redoc UI parameters to use the JavaScript API for improved robustness and simplicity.
Replaced the usage of the 'next' version of Redoc with the officially released version 2.

Tests:

Updated tests to verify the correct version of Redoc is used and that the 'hideDownloadButton' parameter is correctly set.

Summary by CodeRabbit

New Features

Improved Redoc display with updated CDN URL for better performance and stability.

Bug Fixes

Corrected configuration key naming for Redoc to ensure proper functionality.

Tests

Updated tests to reflect changes in Redoc configuration and CDN URL.

@hasansezertasan could you please take a look?

@hasansezertasan could you please take a look?

Thank you @eltoder for your interest 🙏.
I'm bit busy lately 🤖. I will take a look at this as soon as I get a chance 😇

Hey, @eltoder 👋. Thank you for your effort and interest 🚀. I just reviewed your other PR (#24), it would be awesome if you could take a look at that and resolve the conflict on this PR 😇.

Hi @hasansezertasan! I resolved the conflict. Please take another look.

Hi @hasansezertasan! I resolved the conflict. Please take another look.

I'll take a look at it when I get the chance. Thank you for the effort 🙏.


status code 200 instead of 416 in support-notification for ErrTransmissionGET001?

Hi @cloudxxx8 , @cherrycl , @melody
The following test case belongs to transmission test case of support-notification,
ErrTransmissionGET001 - Query all transmissions with invalid offset range
    Given Create Subscriptions And Notifications
    When Query All Transmissions With offset=10
    Then Should Return Status Code "416"
    And Should Return Content-Type "application/json"
    And Response Time Should Be Less Than "${default_response_time_threshold}"ms
    [Teardown]  Run Keywords  Delete Multiple Subscriptions By Names  @{subscription_names}
                ...      AND  Cleanup All Notifications And Transmissions

As a response, I am getting 200 status code instead of 416.
please let me know if you can provide some suggestions ? Thanks in advance.

please provide the full steps and environment.  how did you trigger the test?  what is the version?

@cloudxxx8

Ireland version is being used.
non-docker environment is being used for TAF . The services are being run manually.
core-data, core-command, core-metadata, support-notification, support-scheduler, device-virtual , app-service-configurable are running in background.
Test is being executed using the python command given in the following link , https://github.com/edgexfoundry/edgex-taf/blob/main/docs/run-tests-on-local.md

@dipshirajput When the API returns status code 200, does it contain any transmission in response body?
By the way, when running non-docker environment, you need to update the variables in common-taf.env to your local IP which running the TAF script.

@cherrycl

It gives the response body as can be seen in this screenshot.
Also, all the required variables have been modified based on the local ip for non-docker environment.

@cloudxxx8  @cherrycl
This error is common for test cases which tries for
Transmission with invalid offset range

If this test returned 200 with transmissions, it means you have transmissions more than offset value. Did you clear data every time before running TAF test? If yes, it may be previous tests cleanup failed.
DOCKER_HOST_IP variable is used on positive tests and connect a http server which test script started. If you run this test alone, you don't have to change to variable.

@cherrycl

yes, actually cleanup is failing while performing the support-notification test. what could be the possible correction to correct the failing cleanup ?

please let me know if you have any suggestions. Thanks.

It is strange, seems cleanup API is passed but still found data on validation. You can send API manually and view support-notification logs to figure out.
I think you may need to cleanup redis data.

@cloudxxx8

Ireland version is being used.
non-docker environment is being used for TAF . The services are running manually.
core-data, core-command, core-metadata, support-notification, support-scheduler, device-virtual , app-service-configurable are running in background.
Test is being executed using the python command given in the following link , https://github.com/edgexfoundry/edgex-taf/blob/main/docs/run-tests-on-local.md

To provide the steps, please include all the commands you executed from the very beginning.
Also, the Ireland release is not the LTS release, so we won't maintain it.

Hi @cloudxxx8 , @cherrycl ,
The screenshot below shows the report part of test case: ErrTransmissionGET004 failing with status code 200 where 416 is expected. The transmission doesnt contain anything. I already have deleted the redis DB still getting 200.
Please let me know if you have any suggestions.

with respect to providing the steps,

I am using the Ireland version in a non-docker environment without security.
platform - x86
running the services manually in background, core-data, core-metadata, core-command, support-notifications, support-scheduler, system-agent, app-rules-engine, device-virtual using the below command,
./support-notifications -cp=consul.http://<IP_ADDRESS>:8500 --registry --confdir=./res > /home/dipshi/core-metadata.log
Test is being executed for support-notification using the below command,
python3 -m TUC --exclude Skipped --include v2-api -u functionalTest/V2-API/support-notifications -p default

If these details are still incomplete, please help me understand what details should i mention further ?
Thank you.

Close this issue due to no activity. If you have further question, please file questions on Github Discussions (https://github.com/orgs/edgexfoundry/discussions). Thank you.


Turbo progress bar not working with CSP enabled

I have upgraded to v7.2.0-beta.2 in order to include https://github.com/hotwired/turbo/pull/501, and I have validated that the nonce is being added to the element however I am still receiving an error when turbo attempts to inject the progress bar styles.
Screenshot showing the nonce being added:

Screenshot of the error:

This is with the default Rails CSP enabled:
Rails.application.configure do
  config.content_security_policy do |policy|
    policy.default_src :self, :https
    policy.font_src :self, :https
    policy.img_src :self, :https
    policy.object_src :none
    policy.script_src :self, :https
    policy.style_src :self, :https
    # Specify URI for violation reports
    # policy.report_uri "/csp-violation-report-endpoint"
  end

  config.content_security_policy_nonce_generator = ->(request) { request.session.id.to_s }
  config.content_security_policy_nonce_directives = %w[script-src]
end

I believe It is not a problem to allow unsafe_inline style policy in the CSP

cc @rience

No, whole point of adding the CSP nonce handling is that we shouldn't have to allow unsafe inline.

I looked into this and opened a corresponding PR (https://github.com/rails/rails/pull/46141) on the Rails repo. My suggestion would be to update the suggested CSP configuration in Rails, because everything is working as expected if the CSP configuration adds style-src to the csp-nonce-directives.

Makes total sense. Thank you for adding this.

I have updated my application to now use config.content_security_policy_nonce_directives = %w(script-src style-src) and everything is functioning properly. Thank you for putting the PR against Rails to correct this, hopefully for the sake of future users it is accepted! I'll go ahead and close this issue since the fix is known and there's an open PR to fix it on the appropriate project.

I have updated my application to now use config.content_security_policy_nonce_directives = %w(script-src style-src) and everything is functioning properly.

Isn't that a default in Rails?
https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/http/content_security_policy.rb#L168

I have updated my application to now use config.content_security_policy_nonce_directives = %w(script-src style-src) and everything is functioning properly.

Aren't those directives used by default in Rails?
<EMAIL_ADDRESS>
Yes thanks to @codergeek121 making a PR to fix it in Rails after this issue was made 😃

Even with meta tag containing the nonce in the head like this:
<meta name="csp-nonce" content="EAcP7YZ0Z/753crufRT+Rg==">
...it still doesn't work and on page refresh in production environment it gives me this error:
Refused to apply inline style because it violates the following Content Security Policy directive: "style-src 'self' https://www.gstatic.com https://fonts.googleapis.com". Either the 'unsafe-inline' keyword, a hash ('sha256-WAyOw4V+FqDc35lQPyRADLBWbuNK8ahvYEaQIYF1+Ps='), or a nonce ('nonce-...') is required to enable inline execution.
I have checked the source code and inspected the element and couldn't find any nonce.
Temporary solution was to use the hash.
I am using Symfony 7.1.3 and...
<EMAIL_ADDRESS><EMAIL_ADDRESS>

@4lllex I solved it and I propose changing the name to:
<meta name='csp-style-nonce' ...
... which is clearer, because there can be a script nonce as well.

@DavidPetrasek that's probably a good idea, you should post it as a separate issue.


Change publicity level of KfCustomer, TextXpath

closes #269
@h1alexbel take a look, please
if you know some classes that we can hide, list them, I'll fix

@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon.
If this PR solves a todo from the code, please don't forget to remove it.

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-04-27T14:42:22.741667.
You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.
Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

lgtm

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@l3r8yJ thanks!

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Camera permission

I am seeing this alert when I call function to take picture instead of the custom usage description specified in the plugin.xml
Also, the Camera permission by default is set to 'Denied' in App's settings.

You probably used the id of another app where the permission was denied and you overwrote it.


Running Prisma command on read only file system leads to errors

Bug description
I'm using Prisma on Platform.sh. Platform.sh uses roughly 3 steps to deploy an application:

Install phase, installs dependencies, all directories writable (database not available)
Build phase, builds applications, all directories writable (database not available)
Deploy phase, deploys applications, allowing for migrations, all directories read only (database available)

Migrations have to be run in step 3, but Prisma uses temporary files that require a writable root directory. This results in errors when running the migrations.
          W:  EROFS  EROFS: read-only file system, open '/app/apps/api/_tmp_193_b39d08c8a96de5022c0882e3be1cb10f'
          W:
          W:
          W:
          W:  EROFS  EROFS: read-only file system, open '/app/apps/api/_tmp_211_e18736f02895240f952730c448f7f99d'
          W:
          W:
          W:
          W:  EROFS  EROFS: read-only file system, open '/app/apps/api/_tmp_223_027d2ad94819493069d66334e895541d'
          W:

How can I either change the temporary directory, so I can mount it as a writable directory OR prohibit Prisma from using temporary files?
How to reproduce
N/A
Expected behavior
N/A
Prisma information
N/A
Environment & setup
N/A
Prisma Version
5.1.1

Hey @joriregter, can you please fill describe the environment provided by platform.sh? Which Linux distribution and Node.js version is it using? Does the platform itself provide customisation settings for determining which directories should be writeable? Thanks.

Does the same problem happen if your run for example pnpx prisma -v?
If not, which of the two commands causes the problem you are observing?
Generally both these commands are not supposed to write any temporary files, but maybe some other component of the CLI does and is triggering this in a way that never surfaced to us - as usually it an find a writable spot. Pretty weird, but also not impossible - so happy to dig deeper with you.

Thanks, that gives me an idea. We'll have to reproduce this, track this down, and then make sure we can work without those files (or at least do not crash as we do right now).

What could help maybe would be to run that command again with DEBUG=* like DEBUG=* pnpx prisma -v, could you do that and post the output here @joriregter ?

Absolutely, unluckily this gives the same result.