Reports missing image content

I am really new to this scripting so I may just be ignorant in this question but when I run the scan on a folder, I get a positive result on a few files but the report only says how many images are found. It doesn't list the location or show the actual image itself. Is this expected behavior or do I need to alter the script.py to get what I'm looking for?
Thank you

I am really new to this scripting so I may just be ignorant in this question but when I run the scan on a folder, I get a positive result on a few files but the report only says how many images are found. It doesn't list the location or show the actual image itself. Is this expected behavior or do I need to alter the script.py to get what I'm looking for?
Thank you

Hi!
Add some screenshot of the console, the directory that the report is in and the faulty report please. Normally, after finding images, it should create multiple HTML files, the last one only contains the number of matches, the other HTML files contain the actual images in a gallery style.

I thought about it running from a different drive so I just tried running it from a new install from C: but I get the same results. I also did another clean install and disabled my Avast antivirus before hand. Still get the same results.

So, I pulled some images varying by content from mild to full blown adult intercourse. Still get the same results. Just one report produced, and it now shows a count of 9 total images and this matches the actual number of nsfw images in this folder.
I ran all the NSFW images through https://nudenet.notai.tech/ and all the images got baseline 60 to 80% on breast. Two of the images got hits on six different categories and still did not produce any additional reports. I even tried lowering the hit score when you start the scan to like 4.
Originally the folder contained 640 images. I reduced that down to 150 and I still get not additional reports.
I removed all images except for the nsfw images and I still only get one report.
Does it have to do with operating system? I'm running on Windows 11 Pro. I don't have any other browsers installed besides Edge. Do I need Chromium for this to work?

I tried installing this on another computer running Windows 10 Pro. Still no luck, I only get the one report exported.
I did copy the install output though. Anything in here stand out to you as a major problem?
Preparing a virtual environment...
Collecting pip
Using cached pip-23.3.1-py3-none-any.whl.metadata (3.5 kB)
Collecting setuptools
Using cached setuptools-69.0.2-py3-none-any.whl.metadata (6.3 kB)
Collecting wheel
Using cached wheel-0.42.0-py3-none-any.whl.metadata (2.2 kB)
Using cached pip-23.3.1-py3-none-any.whl (2.1 MB)
Using cached setuptools-69.0.2-py3-none-any.whl (819 kB)
Using cached wheel-0.42.0-py3-none-any.whl (65 kB)
Installing collected packages: wheel, setuptools, pip
WARNING: The script wheel.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The scripts pip.exe, pip3.8.exe and pip3.exe are installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed pip-23.3.1 setuptools-69.0.2 wheel-0.42.0
Requirement already satisfied: pip in d:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\lib\site-packages (23.3.1)
Collecting Pillow
Using cached Pillow-9.5.0-cp38-cp38-win32.whl (2.2 MB)
Installing collected packages: Pillow
Successfully installed Pillow-9.5.0
Requirement already satisfied: wheel in d:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\lib\site-packages (0.42.0)
Collecting virtualenv
Using cached virtualenv-20.25.0-py3-none-any.whl.metadata (4.5 kB)
Collecting distlib<1,>=0.3.7 (from virtualenv)
Using cached distlib-0.3.8-py2.py3-none-any.whl.metadata (5.1 kB)
Collecting filelock<4,>=3.12.2 (from virtualenv)
Using cached filelock-3.13.1-py3-none-any.whl.metadata (2.8 kB)
Collecting platformdirs<5,>=3.9.1 (from virtualenv)
Using cached platformdirs-4.1.0-py3-none-any.whl.metadata (11 kB)
Using cached virtualenv-20.25.0-py3-none-any.whl (3.8 MB)
Using cached distlib-0.3.8-py2.py3-none-any.whl (468 kB)
Using cached filelock-3.13.1-py3-none-any.whl (11 kB)
Using cached platformdirs-4.1.0-py3-none-any.whl (17 kB)
Installing collected packages: distlib, platformdirs, filelock, virtualenv
WARNING: The script virtualenv.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed distlib-0.3.8 filelock-3.13.1 platformdirs-4.1.0 virtualenv-20.25.0
created virtual environment CPython3.8.0.final.0-32 in 755ms
creator CPython3Windows(dest=D:\offline-nsfw-scanner-master\venv, clear=False, no_vcs_ignore=False, global=False)
seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=C:\Users\User\AppData\Local\pypa\virtualenv)
added seed packages: pip==23.3.1, setuptools==69.0.2, wheel==0.42.0
activators BashActivator,BatchActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator
Activating virtual environment...
Installing requirements...
Collecting colorama==0.4.6 (from -r requirements.txt (line 1))
Using cached colorama-0.4.6-py2.py3-none-any.whl (25 kB)
Collecting coloredlogs==15.0.1 (from -r requirements.txt (line 2))
Using cached coloredlogs-15.0.1-py2.py3-none-any.whl (46 kB)
Collecting distlib==0.3.7 (from -r requirements.txt (line 3))
Using cached distlib-0.3.7-py2.py3-none-any.whl.metadata (5.1 kB)
Collecting filelock==3.12.4 (from -r requirements.txt (line 4))
Using cached filelock-3.12.4-py3-none-any.whl.metadata (2.8 kB)
Collecting flatbuffers==23.5.26 (from -r requirements.txt (line 5))
Using cached flatbuffers-23.5.26-py2.py3-none-any.whl.metadata (850 bytes)
Collecting humanfriendly==10.0 (from -r requirements.txt (line 6))
Using cached humanfriendly-10.0-py2.py3-none-any.whl (86 kB)
Collecting mpmath==1.3.0 (from -r requirements.txt (line 7))
Using cached mpmath-1.3.0-py3-none-any.whl (536 kB)
Collecting nudenet==3.0.8 (from -r requirements.txt (line 8))
Using cached nudenet-3.0.8-py3-none-any.whl.metadata (2.4 kB)
Collecting numpy==1.24.4 (from -r requirements.txt (line 9))
Using cached numpy-1.24.4-cp38-cp38-win32.whl.metadata (5.6 kB)
Collecting onnxruntime==1.16.1 (from -r requirements.txt (line 10))
Using cached onnxruntime-1.16.1-cp38-cp38-win32.whl.metadata (4.3 kB)
Collecting opencv-python-headless==<IP_ADDRESS> (from -r requirements.txt (line 11))
Using cached opencv_python_headless-<IP_ADDRESS>-cp37-abi3-win32.whl.metadata (20 kB)
Collecting packaging==23.2 (from -r requirements.txt (line 12))
Using cached packaging-23.2-py3-none-any.whl.metadata (3.2 kB)
Requirement already satisfied: Pillow==9.5.0 in d:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\lib\site-packages (from -r requirements.txt (line 13)) (9.5.0)
Collecting platformdirs==3.11.0 (from -r requirements.txt (line 14))
Using cached platformdirs-3.11.0-py3-none-any.whl.metadata (11 kB)
Collecting protobuf==4.24.4 (from -r requirements.txt (line 15))
Using cached protobuf-4.24.4-cp38-cp38-win32.whl.metadata (540 bytes)
Collecting pyreadline3==3.4.1 (from -r requirements.txt (line 16))
Using cached pyreadline3-3.4.1-py3-none-any.whl (95 kB)
Collecting sympy==1.12 (from -r requirements.txt (line 17))
Using cached sympy-1.12-py3-none-any.whl (5.7 MB)
Collecting tqdm==4.66.1 (from -r requirements.txt (line 18))
Using cached tqdm-4.66.1-py3-none-any.whl.metadata (57 kB)
Collecting virtualenv==20.24.6 (from -r requirements.txt (line 19))
Using cached virtualenv-20.24.6-py3-none-any.whl.metadata (4.5 kB)
Using cached distlib-0.3.7-py2.py3-none-any.whl (468 kB)
Using cached filelock-3.12.4-py3-none-any.whl (11 kB)
Using cached flatbuffers-23.5.26-py2.py3-none-any.whl (26 kB)
Using cached nudenet-3.0.8-py3-none-any.whl (10.6 MB)
Using cached numpy-1.24.4-cp38-cp38-win32.whl (12.5 MB)
Using cached onnxruntime-1.16.1-cp38-cp38-win32.whl (6.3 MB)
Using cached opencv_python_headless-<IP_ADDRESS>-cp37-abi3-win32.whl (28.2 MB)
Using cached packaging-23.2-py3-none-any.whl (53 kB)
Using cached platformdirs-3.11.0-py3-none-any.whl (17 kB)
Using cached protobuf-4.24.4-cp38-cp38-win32.whl (410 kB)
Using cached tqdm-4.66.1-py3-none-any.whl (78 kB)
Using cached virtualenv-20.24.6-py3-none-any.whl (3.8 MB)
Installing collected packages: pyreadline3, mpmath, flatbuffers, distlib, sympy, protobuf, platformdirs, packaging, numpy, humanfriendly, filelock, colorama, virtualenv, tqdm, opencv-python-headless, coloredlogs, onnxruntime, nudenet
Attempting uninstall: distlib
Found existing installation: distlib 0.3.8
Uninstalling distlib-0.3.8:
Successfully uninstalled distlib-0.3.8
WARNING: The script isympy.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Attempting uninstall: platformdirs
Found existing installation: platformdirs 4.1.0
Uninstalling platformdirs-4.1.0:
Successfully uninstalled platformdirs-4.1.0
WARNING: The script f2py.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script humanfriendly.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Attempting uninstall: filelock
Found existing installation: filelock 3.13.1
Uninstalling filelock-3.13.1:
Successfully uninstalled filelock-3.13.1
Attempting uninstall: virtualenv
Found existing installation: virtualenv 20.25.0
Uninstalling virtualenv-20.25.0:
Successfully uninstalled virtualenv-20.25.0
WARNING: The script virtualenv.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script tqdm.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script coloredlogs.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script onnxruntime_test.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script nudenet.exe is installed in 'D:\offline-nsfw-scanner-master\python-3.8.0-embed-win32_modified\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed colorama-0.4.6 coloredlogs-15.0.1 distlib-0.3.7 filelock-3.12.4 flatbuffers-23.5.26 humanfriendly-10.0 mpmath-1.3.0 nudenet-3.0.8 numpy-1.24.4 onnxruntime-1.16.1 opencv-python-headless-<IP_ADDRESS> packaging-23.2 platformdirs-3.11.0 protobuf-4.24.4 pyreadline3-3.4.1 sympy-1.12 tqdm-4.66.1 virtualenv-20.24.6
Please enter the destination directory:

sorry, i've been very busy with my job and life.
i'm currently trying to copy your issue, though i hope in the meantime you found a solution or alternative.

Hey, so glad I checked back in on this. I figured you probably had stuff going on. Thanks for circling back around. I did start try going through the installation processes again and I noticed that the python version didn't match what was installed on my computer. I ended up trying it on two separate computers though, making sure I had no standalone version of python installed and I still could never get it to work right. It looks like it is failing to complete the install correctly. Seems like it's not installing all the required components. The reason your solution is so appealing is because you state that everything is wrapped up in a nice package. I'm a complete noob with Python. I can review logs and kind of get an idea of what might be happening, but I don't really know how to resolve these issues. Instead of it being automated in the setup, is there any way I can manually install these components to get it working?
I'm assuming you have some correspondence with other users saying that this solution is working for them? Again, I really appreciate you checking back on this. Any help is always greatly appreciated.

I made it a little further. I manually installed python with Chocolatey. I tried to run the setup.py but it doesn't even want to do anything now. I took the list of dependencies and manually downloaded them with poweshell.
So I can manually run the script.py in powershell and it does detect nsfw images correctly. As the scan is going I can actually open the report and the resulting images are showing as I believe they should be. Problem I'm having now though is that once the scan finishes running, the report file gets overwritten and just says how many files were found but removed all the other content from the page.
I mean... it's better than nothing I guess lol. Would be nice to know why it's doing that though.


Adding issue forms to the Repo

Issue Type:

[ ] Bug Report
[x] Feature Request
[ ] Documentaion

Describe the bug

I was about to submit an issue regarding my project and I noticed that this repo doesn't have any issue forms. Issue forms make it very convenient for the contributors to create new issues.

Possible solution

I want to add a few issue Forms so that it will be convenient for new contributors to open issues. I plan to create  Bug Report and Feature Request Forms. You can read more about issue forms here

The Bug Report issue form will have the following fields

Description of the bug
How to Reproduce
Urgency indicator

The Feature Request issue form will have the following fields

Is your feature request related to a problem? Please describe.
Describe the solution you'd like

Kindly assign this issue to me.

@arpit456jain

@arpit456jain

@MonarchGitHub what type of issue form i think we have issue template

share some ss @MonarchGitHub

Yeah, they're different from issue templates, here's an ss of how they look @arpit456jain

Its not needed for now


Typescript - Left-hand side of assignment expression cannot be a constant or a read-only property

Severity	Code	Description	Project	File	Line	Suppression State
Error		Build:Left-hand side of assignment expression cannot be a constant or a read-only property.	Roadkill.Web	C:\Users\jeffm\Downloads\roadkill-2.0\roadkill-2.0\src\Roadkill.Web\Assets\Scripts\roadkill\filemanager\ajaxrequest.ts	58
	private makeAjaxRequest(url: string, data: any, errorMessage: string, successFunction: (data: any) => void)
	{
		var request = $.ajax({
			type: "POST",
			url: url,
			data: data,
			dataType: "json"
		});

		request.done(successFunction);

		request.fail(function (jqXHR, textStatus, errorThrown : SyntaxError)
		{
			// Logged out since the call was made
			if (errorThrown.message.indexOf("unexpected character") !== -1)
			{
				window.location = window.location;  "ERROR LOCATION"
			}
			else
			{
				toastr.error(errorMessage + errorThrown);
			}
		});
	}

This is an issue with Typescript 2 (Roadkill version 2 uses 1.x)

This is fixed in the version-2 branch we varies very slightly from the release now, to fix this issue for Azure CI deploys.


Django issue

As reported by BigBobbyTable on irc there is an issue in the following configuration:

MySQL as backend
New database
Submitted a file to all machines

Under these conditions Django would throw the following issue:
NoReverseMatch: reverse for 'analysis.views.file' with arguments  ('sample', '') and key arguments '{}' not found. 1 pattern tried, file/(?P<category>\\w+).

It's possible will be like https://github.com/cuckoobox/cuckoo/issues/524

Updates?

Probably resolved or unrelated now. Closing the issue.


Update: Include sample_name IRIDA-Next input column

Modified the template for input samplesheet.csv file to include the sample_name column in addition to sample in-line with changes to IRIDA-Next update as seen with the speciesabundance pipeline. What this means is that the output files and the sample name will be changed to sample_name if a sample_name is called. If staramrnf is being locally then the sample_name can be left blank.
Made a few changes:
- sample_name special characters will be replaced with "-"
- If no sample_name is supplied in the column sample will be used
- To avoid repeat values for sample_name all sample_name values will be suffixed with the index of the input samplesheet.csv
- Tests to check that the variety of different sample_names work with the
PR checklist

[x] This comment contains a description of changes (with reason).
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] Make sure your code lints (nf-core lint).
[x] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[x] Usage Documentation in docs/usage.md is updated.
[x] Output Documentation in docs/output.md is updated.
[x] CHANGELOG.md is updated.
[x] README.md is updated (including new tool citations and authors/contributors).

A big change was updating the assets/samplsheet.csv and tests/test_samplesheet.csv so I have changed the files to point to the local files rather than the URL in the repository. A temporary change until the PR is merged, then will update to the dev branch URL


Fix port_map stanza typo in redis.nomad job spec

Old: sampleservicedbport = 6379
New: sampleservicedb_port = 6379
Addresses Issue #4
Background:  https://github.com/hashicorp/nomad/issues/7532

Nice catch, thanks!


issues on dst

Hi,
when evaluating the JGA for DST, did you remove both the none slot and dontcare slot?
When I ran the dialogue_generation.py, it seems that the generated belief states are always empty in the MODEL_OUTPUT file. so could you please provide more details about how the model is trained for DST?
Thanks!

Hi,
We are only removing none. it is fixed now.
On dialogue_generation.py, this seems a parsing issue. We will fix this

@smartyfh empty belief issue: add text=text.strip() before tokenizer.encode(text), or there is always an space at the end. However I didn't get the joint acc in the paper, will you?

@smartyfh empty belief issue: in generate_dialogue.py file, add text=text.strip() before tokenizer.encode(text), or there is always an space at the end. However I didn't get the joint acc in the paper, will you?

@fasterbuild Have you checked all the checkpoints or just one checkpoint? If ignoring both none and dontcare slots, the results should be reproducible. However, if keeping the dontcare slots, the acc would go down several points. But this needs the author to confirm.

@smartyfh I am struggling in reproducing the result, could you please share the hyper-params you use for the training?

@smartyfh empty belief issue: in generate_dialogue.py file, add text=text.strip() before tokenizer.encode(text), or there is always an space at the end. However I didn't get the joint acc in the paper, will you?

@fasterbuild Have you checked all the checkpoints or just one checkpoint? If ignoring both none and dontcare slots, the results should be reproducible. However, if keeping the dontcare slots, the acc would go down several points. But this needs the author to confirm.

If keeping the dontcare slots, what is the JGA you get?

@smartyfh empty belief issue: in generate_dialogue.py file, add text=text.strip() before tokenizer.encode(text), or there is always an space at the end. However I didn't get the joint acc in the paper, will you?

@fasterbuild Have you checked all the checkpoints or just one checkpoint? If ignoring both none and dontcare slots, the results should be reproducible. However, if keeping the dontcare slots, the acc would go down several points. But this needs the author to confirm.

If keeping the dontcare slots, what is the JGA you get?

about 52

@smartyfh empty belief issue: in generate_dialogue.py file, add text=text.strip() before tokenizer.encode(text), or there is always an space at the end. However I didn't get the joint acc in the paper, will you?

@fasterbuild Have you checked all the checkpoints or just one checkpoint? If ignoring both none and dontcare slots, the results should be reproducible. However, if keeping the dontcare slots, the acc would go down several points. But this needs the author to confirm.

If keeping the dontcare slots, what is the JGA you get?

The JGA is 50.32% if keeping the dontcare. After ignoring both none and dontcare, I can achieve 55.45% JGA.

I got 50.46 joint accuracy, keeping dontcare and doing default cleaning.

@smartyfh empty belief issue: in generate_dialogue.py file, add text=text.strip() before tokenizer.encode(text), or there is always an space at the end. However I didn't get the joint acc in the paper, will you?

@fasterbuild I tried text=text.strip() before tokenizer.encode(text), it doesn't work.


Dropping a column not working in 0.17

I'm executing the following code:
import pandas as pd

df = pd.read_csv('2015-09-25.csv', header=None,\
                 names=['ID', 'ORIG', 'LAT', 'LONG', 'CITY', 'STATE', 'TIMESTAMP'], \
                 parse_dates=['TIMESTAMP'], \
                 usecols=['ORIG','LAT', 'LONG', 'CITY', 'STATE'])

df1 = df[df['ORIG']==1]
df1.drop(df1.columns[0], inplace=True)

However, the last line will give me this error in 0.17, but works fine with 0.16.2. The 0.17 version of pandas is being used with python 3.5, while pandas 0.16.2 is being used with python 3.4.
Traceback (most recent call last):
  File "C:/Users/Leb/Desktop/Python/test2.py", line 29, in <module>
    df.drop(df.columns[0], inplace=True)
  File "C:\Program Files\Python 3.5\lib\site-packages\pandas\core\generic.py", line 1616, in drop
    new_axis = axis.drop(labels, errors=errors)
  File "C:\Program Files\Python 3.5\lib\site-packages\pandas\core\index.py", line 2736, in drop
    raise ValueError('labels %s not contained in axis' % labels[mask])
ValueError: labels ['ORIG'] not contained in axis

I've also tried df1.drop('ORIG', inplace=True) but the same problem arises. This presist ever with df.
Output of df.columns or df1.columns will show:
Index(['ORIG', 'LAT', 'LONG', 'CITY', 'STATE'], dtype='object')
Index(['ORIG', 'LAT', 'LONG', 'CITY', 'STATE'], dtype='object')

Adding axis=1 will result in an additional error of:
SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame
SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame

See the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy
  df1.drop(df1.columns[0], axis=1, inplace=True)

These errors only show up with python3.5 and pandas 0.17.

pls put a copy-pastable example
and pd.show_versions()

You're also trying to drop ORIG from the index, not the columns. Do you want df1.drop(df1.columns[0] , axis=1)?

@TomAugspurger I did that, I get the SettingWithCopyWarning:  error.
@jreback Here's a copy-pastable example:
import pandas as pd
import io

data="""ORIG    LAT    LONG
1    3.2    4.4
1    2.8    7.5
1    4.9    7.7
0    5.4    5.8
1    7.6    9.5"""

df = pd.read_csv(io.StringIO(data), delimiter='\s+')

df1 = df[df['ORIG']==1]

df1.drop(df1.columns[0], axis=1, inplace=True)

The error seems to be when including inplace=True.  It might work depending on the dtypes, but you would need to copy it first.

@jreback thank you for the feedback. It was initially confusing as to why the same code works with 0.16.2 but not with 0.17

IIRC some bug fixes, you need to pay attention the SettingWithCopyWarnigns they are there for a reason. further, in general inplace is a bad idea.


Point graphing functionality

Problem Statement

I want to be able to graph single points on the graphing calculator, but it is not possible. This would help with finding solutions to math problems.
Evidence or User Insights

It is relatively simple to plot a small filled-in circle at the given point. It would add a simple feature to the graphing calculator.
Proposal

It will let he use define a point to display to help them visualize a solution.
Goals

Adding the ability to graph points, or individual dots, by typing (x, y), with "x" being the x-coordinate and "y" being the y-coordinate. I know this is technically not a function, however, it would be a nice feature.
Non-Goals

Low-Fidelity Concept

A small filled-in circle will be placed at the given point.
Requested Assignment

I might try to implement it myself if I have the time and can figure it out.

I had posted a version of this issue earlier, but it was closed without being resolved, as far as I am aware. I have added more detail and specifics to the issues.

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.


Instantiate EditorState from HTML

Hi,
Thanks for developing such a useful library!
My question might seem dumb but I can't figure how to do it... How can I generate an EditorState out of exported HTML, which preserves inline styles?
I use the following chunk of code to get HTML from an editorState, which works perfectly:
import { stateToHTML } from 'draft-js-export-html'

const inlineStyles = exporter(editorState)
const content = editorState.getCurrentContent()
const html = stateToHTML(content, { inlineStyles })

But then, when I do:
import { stateFromHTML } from 'draft-js-import-html'

EditorState.createWithContent(stateFromHTML("
yo
 "))

I lose the font-size. Any hints?
Thanks a lot!

That is a good question, I don't have an answer for you right now but I will look into it and see of that would be possible. It would really be a nice to be able to import html -> draft-js and keep the styles consistent.

Thanks!

When this issue will be fixed?

I have the functionality for this issue working but It depends on having a PR to draft-js-utils accepted.
https://github.com/sstur/draft-js-utils/pull/155

I was able to resolve this using the draft-convert package, here's a snippet of the code
import { convertFromHTML } from 'draft-convert';

export const convertHTMLToDraft = (htmlText: string) => {
  const contentState = convertFromHTML({
    htmlToStyle: (nodeName, node, currentStyle) => {
      let style = currentStyle;
      if (nodeName === 'span' && node.style.fontFamily) {
        style = style.add(`CUSTOM_FONT_FAMILY_${node.style.fontFamily}`);
      }
      if (nodeName === 'span' && node.style.fontSize) {
        style = style.add(`CUSTOM_FONT_SIZE_${node.style.fontSize}`);
      }
      return style;
    },
  })(htmlText);
  return contentState;
};

I hope this is helpful.


Skip compile external_custom project if EXTERNAL_CUSTOM_REPO is not set

Skip compile external_custom project if EXTERNAL_CUSTOM_REPO is not set
Move external_custom tests to functional group
Fix #3187
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

Tested sanity.external: https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/436/


.vscode doesn't exist in all projects

Specifically, belize-reports doesn't have one that came when project was created.

npx @seasketch/geoprocessing init produces a correct .vscode folder on mine machine as well. Weird. Maybe it was a temporary issue with a previous version


"Can't find variable: document" React Native error (3.3.0-alpha.2)

Hello,
I am trying to get 3.3 up & running so that I can have accessibility labels (#1780) for Detox testing. Everything installs fine, but when I start up the app, I get a RSOD on Can't find variable: document.

The sheet.js in the trace is inside of the glamor package. That particular line looks like:
const oldIE = (() => {
  if(isBrowser) {
    let div = document.createElement('div') // <--- this line
    div.innerHTML = ''
    return div.getElementsByTagName('i').length === 1
  }
})()

isBrowser looks like:
const isBrowser = typeof window !== 'undefined'

(https://github.com/threepointone/glamor/blob/master/src/sheet.js)
Maybe there is a global.window defined in Storybook 3.3 that wasn't there in 3.2?
P.S. I realize this is alpha release, but I figured I'd report it sooner rather than later if it is legit. Also, my setup is a tad bit complicated — I'm using react-native-storybook-loader — so I tried to create a vanilla CRNA/Storybook repo for you, but I couldn't get past #1943.
Edit: Additional info
React Native: 0.47.2
Some npm ls output:
├─┬<EMAIL_ADDRESS>...
│ ├─┬<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>deduped
│ │ ├─┬<EMAIL_ADDRESS>│ │ │ ├─┬<EMAIL_ADDRESS>

looks like this change made the linkTo component dependent on styled components. https://github.com/storybooks/storybook/pull/1829/files
this seems to affect the Welcome.js template, but the same error still occurs when I remove that instance and make linkTo render null. I can't seem to find any other React only components that are leaking into React-Native but it seems to be a problem.

Help highly appreciated!
Somehow react-native bundler is bundling glamorous and some React styled components inside the react-native bundle. I can't pin where this is happening because I'm not too familiar with the rn cli tools. If anyone has time, I'd love some help.

Had a look at this with @danielduan's help.
The issue comes from this line: https://github.com/storybooks/storybook/blob/release/3.3/addons/links/src/index.js#L8
The problem is that addon-links is imported from RN's preview context (which runs inside react native, not a web browser). As addon links is importing our components (which are web components, reliant on glamorous which doesn't run in RN) we get an exception.

I'm not sure what the best solution is but it probably involves separating the "UI" exports from addon-links from the "functionality" exports. @Hypnosphi, what do you think?

Ok, so I can remove the reexport, and add a deprecation placeholder in case someone used it, right?

Probably -- perhaps it should be exported by addon-links/UI or something so people can use it?

maybe event addon-links/react

That's technically accurate but maybe a little confusing as you may want to use the export within an addon which can work with any framework (but in the react-based manager UI of course). What do you think?

(updated my comment above with the opposite opinion ;) )

This component is rendered in preview not manager, so it's usable only in React environment

This component is rendered in preview not manager, so it's usable only in React environment

Oh, right. Even moreso then :)

verified fixed with PR ^

Hi,
I am not able to print "Hi" on screen.

Can't find variable: autobind.

`// @flow
import moment from "moment";
import * as React from "react";
import { StyleSheet, View, Text, TextInput, Switch } from "react-native";
import { H1, ListItem, List, Item, Body, Right, Icon, Picker, CheckBox, Button, SettingsSwitch, Container, Content, Segment } from "native-base";
import { BaseContainer, Styles, Avatar, Field, Small } from "../components";
import type {ScreenProps } from "../components/Types";
import variables from "../../native-base-theme/variables/commonColor";
export default class Contact extends React.Component<ScreenProps<>> {
//Variable define
// http://dev-app.pamtree.com/dashboard/contacts/put
// Note : Marital Status
// Note : confirmation
// Note : Custum fields (Add Button) click to add fields
// note : delete button after submit
constructor(props) {
    super(props);
    // For Maritial Status
    this.state = {
        selectedItem: undefined,
        selected1: 'key1',
        results: {
            items: []
        },
        customerTitle: [],
        customerValue: [],
        toggled: true
    }
}
//  Marital status Change valice
onValueChange(value: string) {
    this.setState({
        selected1: value
    });
}

go(key: string) {
    this.props.navigation.navigate(key);
}

//start code of adding dynamically custome fields
addTextInput = (key) => {
    console.log('key 1 --', key);
    let customerTitle = this.state.customerTitle;
    customerTitle.push(<View key={key}><Field key={key} label="Customer Field Title" defaultValue="Customer Title" />
        <Field label="Value" key={key} defaultValue="Field value" /></View>);
    this.setState({ customerTitle })
}

toggleSwitch1 = () => {
    let switchValue = !this.state.toggled;
    this.setState({ toggled: switchValue })
    console.log(' this.state.toggled -', this.state.toggled);
}
//end

render(): React.Node {
    return <BaseContainer title="Contact" navigation={this.props.navigation} scrollable>
        <View style={[Styles.center, style.header]}>

Add New Contact

        </View>

        {/* <Switch
            onValueChange={props.toggleSwitch2}
            value={props.switch2Value} /> */}
        <List>
            <ListItem itemDivider>
                <Text>Personal Information</Text>
            </ListItem>
            <Field
                label="First name"
                defaultValue="Type first name here"
                textInputRef={this.setFirstnameRef}
                onSubmitEditing={this.goToSurname}
                returnKeyType="next"
            />
            <Field
                label="Surname"
                defaultValue="Type last name here"
                textInputRef={this.setSurnameRef}
                onSubmitEditing={this.goToOccupation}
                returnKeyType="next"
            />
            <Field
                label="Occupation"
                defaultValue="Occupation"
                textInputRef={this.setOccupationRef}
                onSubmitEditing={this.goToPhone}
                returnKeyType="next"
            />
            <Field
                label="Phone Number"
                defaultValue="0123-123456789"
                textInputRef={this.setPhoneRef}
                onSubmitEditing={this.goToEmail}
                returnKeyType="next"
            />
            <Field
                label="Email"
<EMAIL_ADDRESS>                textInputRef={this.setEmailRef}
                onSubmitEditing={this.goToAge}
                returnKeyType="next"
            />
            <Field
                label="Age"
                defaultValue="25"
                textInputRef={this.setAgeRef}
                onSubmitEditing={this.goToStatus}
                returnKeyType="next"
            />
            <Picker
                mode='dropdown'
                selectedValue={this.state.selected1}
                onValueChange={this.onValueChange.bind(this)}>
                <Item label='Marital Status' value='' />
                <Item label='Single' value='Single' />
                <Item label='Married' value='Married' />
                <Item label='Separated' value='Separated' />
                <Item label='Divorced' value='Divorced' />
                <Item label='Civil Partnership' value='Civil Partnership' />
                <Item label='Widowed' value='Widowed' />
            </Picker>
            <Field
                label="Address"
                defaultValue="Address"
                textInputRef={this.setAddressRef}
                onSubmitEditing={this.goToImg_url}
                returnKeyType="next"
            />
            <ListItem itemDivider>
                <Text>Image</Text>
            </ListItem>
            <Field
                label="Image"
                defaultValue="Image"
                textInputRef={this.setImg_urlRef}
                onSubmitEditing={this.goToTags}
                returnKeyType="next"
                secureTextEntry
            />
            <ListItem itemDivider>
                <Text>Tags</Text>
            </ListItem>
            <Picker
                mode='dropdown'
                selectedValue={this.state.selected1}
                onValueChange={this.onValueChange.bind(this)}>
                <Item label='stage 1' value='stage 1' />
                <Item label='stage 2' value='stage 2' />
            </Picker>
            <ListItem itemDivider>
                <Text>Confirmation</Text>
            </ListItem>
            <CheckBox checked={false} />
            <Text>This person gave me permission to contact them This person will not receive a confirmation email from Pamtree as you are
            adding this recipient manually so be sure you have permission to contact them first.</Text>

            <ListItem itemDivider>
                <Text>Custom Fields</Text>
            </ListItem>
            <View>
                {this.state.customerTitle.map((value, index) => {
                    return value
                })}
                <Button primary Small onPress={() => this.addTextInput(this.state.customerTitle.length)}>
                    <Text>Add</Text>
                </Button>
            </View>
            <ListItem itemDivider>
                <Text>Other Information</Text>
            </ListItem>
            <View>
                <Text>Drives ?</Text>
                <Switch
                    onValueChange={() => this.toggleSwitch1()}
                    value={this.state.toggled}
                />
            </View>
            <Field
                label="Objective"
                textInputRef={this.setDrivesRef}
                onSubmitEditing={this.goToObjective}
                returnKeyType="next"
            />

            <ListItem itemDivider>
                <Text>Notes</Text>
            </ListItem>
            <Field
                label="Notes"
                defaultValue="Notes"
                textInputRef={this.setNotesRef}
                onSubmitEditing={this.submit}
                returnKeyType="go"
                last
            />
            <Button primary full>
                <Text> Submit </Text>
            </Button>
        </List>
        <Container>
            <Content>
                {/* {this.state.customerTitle.map((value, index) => {
                    return value
                })} */}
            </Content>
        </Container>
    </BaseContainer>;
}

}
const style = StyleSheet.create({
header: {
backgroundColor: variables.lightGray
},
icon: {
color: variables.brandInfo,
fontSize: 30
},
avatars: {
flexDirection: "row",
justifyContent: "center",
alignItems: "center"
},
avatar: {
marginRight: variables.contentPadding / 2
}
});
`

This is a problem again due to components/GroupTabs importing @storybook/components and components/types/Date/index imports and references insert-css. Commenting these out makes it work.

I'm not sure what the best solution is but it probably involves separating the "UI" exports from addon-links from the "functionality" exports. @Hypnosphi, what do you think?

can u explain in detailed?


mariadb: 10.2.17 -> 10.3.15

Motivation for this change
The goal for the split is to avoid duplicating binary files in client and server packages. Change default codepage to utf8mb4. Additional improvements.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

It would be nice if you could split the changeset to multiple commits, it is pretty hard to wrap my head around this. Also why are you removing the comments?

Comments were removed by mistake.I will try to fix and split the PR to separate commits soon.

Changed PR. Please check.

Is this PR still relevant? 10.3.12 is already on master (https://github.com/NixOS/nixpkgs/blob/68ba646f83f95da67a7fa58845fed8f66e25d63b/pkgs/servers/sql/mariadb/default.nix#L25). The install flags are also used (https://github.com/NixOS/nixpkgs/blob/68ba646f83f95da67a7fa58845fed8f66e25d63b/pkgs/servers/sql/mariadb/default.nix#L57-L68). utf8mb4 is also used (https://github.com/NixOS/nixpkgs/blob/68ba646f83f95da67a7fa58845fed8f66e25d63b/pkgs/servers/sql/mariadb/default.nix#L53).

Current variant - https://github.com/Izorkin/nur-packages/blob/master/pkgs/servers/mariadb/default.nix

@bobvanderlinden in master branch - 10.2.17 version
https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/sql/mariadb/default.nix#L25

@Izorkin I think you're having trouble finding 1 person willing to merge each of these changes. Some of these changes individually aren't a big deal to merge, but all together at the same time make it difficult to be certain regressions aren't introduced. If this was broken into several PRs I'm guessing at least a few of the new PRs would be merged much sooner than this individual PR would be. Merging the contents of this PR spread out over several PRs over a period of time would likely also help tracking down any potential regressions that might arise from this much quicker.
Just my 2 cents.

@aanderse see https://github.com/NixOS/nixpkgs/pull/44343#issuecomment-409904778
I can squashed in 1 PR.

@Izorkin multiple commits was an improvement... but I wonder if you might need to go as far as multiple commits to get some action on this.
You are doing quite a few things in a single PR and I just wonder if you're making too many changes at once so no one is comfortable enough to merge all the changes at once.
I don't speak for others, I just wonder if they feel that way.

Simplify PR to, for example, 5 commits?

You might consider creating a PR to change the default code page, a PR to bump the version, and a PR to apply some cleanup.

Reconfigured and updated to 10.3.15

@GrahamcOfBorg build mariadb.server mariadb.client
@GrahamcOfBorg test mysql mysqlBackup mysqlReplication

Updated PR.

Thanks!


feat: autotune support multi models

one more thing, we also need test case for different datatypes (fp16 fp32 mixed precision case)


SpoonDetector first run and another error

[x] This issue isn't duplicated - you can check if it is by using the search bar located at the top left hand corner and select "Issues" on the left.
[x] This issue includes appropriate markdown for sections - e.g. code blocks for crash dumps.
[x] This issue is understandable - feel free to use your native language to write issues if you are not comfortable with English.

Issue description
This is a pretty hidden and awkward one. When the plugin is run for the first time and the plugin folder has not been created yet and a spoon was detected, this line will result in true.
But the problem now is that on the next line the spoon detection tries to open a file in a non-existing directory which results in an error.
I tested this with an edited pmmp version which returns "Spoon" as it's name:

Reproducing the issue

Setup a server which doesn't return "PocketMine-MP" in Server->getName().
Make sure the MyPlot plugin folder isn't created yet
Run the server with a MyPlot version using the spoon detection class
Watch out for errors in the console

Optional information
This could be fixed by creating the MyPlot directory before checking if the server is running a spoon or by requesting the creation of the plugin folder on the SpoonDetection repository.
I believe this should be fixed because spoon users won't see the disclaimer otherwise, but instead an error and the disabling of the plugin. That could lead to unnecessary issue reports.

The other error which I didn't include up there is that if a spoon was detected and the plugin folder is present, the plugin would continue inside it's onEnable() function without checking if the plugin is disabled or not.
This results into this:

I believe this is an issue with the SpoonDetector virion.

[10:25:48] [Server thread/CRITICAL]: ClassNotFoundException: "Class spoondetector\SpoonDetector not found" (EXCEPTION) in "src/spl/BaseClassLoader" at line 144


Fix webservice linting

Description
This PR includes changes to:

fix glob patterns for linting pipelines
modified github actions to make it depend only on package.json, to avoid having to change 2 things to make a change

How Has This Been Tested?
This has been tested by checking the outcome of the actions on github

Ok for me


Google Meet PIP doesn't work.

I've tried it on Chrome and Brave. But it doesn't work at all.

Possible reasons for this that I can think of:

All meeting participants didn't have their video turned on
Can't check for now, but Brave might not have support for Picture-in-Picture API yet which is what this extension relies on.

Closing this for now, feel free to reopen if you still encounter the same issue after checking the above. Thanks!


Multiple toasts laggy with animation on Next.JS

I'm using the next-expo-solito starter, showing a toast is fine, but if toast.show is triggered multiple times, then it takes awhile before the next toasts appear.
After commenting animation='quick', the toasts appear immediately, but this animation is used in Dialog without any delay issue.
Tamagui version: 1.39.8

can you check with latest i spent a lot of time optimizing the mount and unmount there

This issue is still present in iOS. The second toast only appears a couple seconds after the initial toast is hidden. I can also confirm that the issue disappears if you remove animation=quick, but that disables all animation is not pretty.


nimble/ll: Vendor error event on assert

With this patch controller will send Vendor Debug event
on asserts.
First octet of this event is Debug event type

Debug event type (0x00 - assert information)
Assert information (file and line)

Example below shows my test asset in ble_ll_hci.c line 767

HCI Event: LE Meta Event (0x3e) plen 67
Unknown (0xff)
00 72 65 70 6f 73 2f 61 70 61 63 68 65 2d 6d 79   .repos/apache-my
6e 65 77 74 2d 6e 69 6d 62 6c 65 2f 6e 69 6d 62    newt-nimble/nimb
6c 65 2f 63 6f 6e 74 72 6f 6c 6c 65 72 2f 73 72    le/controller/sr
63 2f 62 6c 65 5f 6c 6c 5f 68 63 69 2e 63 ff 02    c/ble_ll_hci.c..
00 00

Note that if debugger is connected, there will be regullar assert
called.

@andrzej-kaczmarek  updated with macro enabled only for debug.


Inconsistent data found after cdc finish.

Bug Report
1. Describe the bug
Inconsistent value is found in dst tikv cluster after cdc process finish.
2. Minimal reproduce step (Required)

Start two tikv-cluster, one is source with cdc server, the other is cdc destination.
Create changefeed with tikv-cdc
Run case rawkv_cdc_correctness_put in pr https://github.com/pingcap/endless/pull/721, with 1kw keys.
Result show that the checksum in src and dst are not the same.
Scan all data show that the first value is sync to dst instead of the second.

3. What did you see instead (Required)
4. What did you expect to see? (Required)
5. What is your migration tool and TiKV version? (Required)

TiKV CDC:

Fixed by https://github.com/tikv/migration/pull/155.


Unclear doxygen diagnostics release 5.7

rdar://90953916
Summary
Currently there are confusing "Directives are not supported in symbol source documentation" while building Doxgyen content.
Dependencies
No known dependencies
Testing
Steps
Build docc locally with these changes
Create a new project in Xcode and an Objective class to it.3.
In a Objective-C class, add a method and document it with Doxygen tags4.
/// Brief description of this method
@image something Description of this Image
@params Description of this parameter
@returns Description of return value
(NSString *)methodNameWithSomething:(NSString *)something;
Build documentation for the target by pointing docc_exec to the locally build docc.
There shouldn’t be any warnings for the @param and @returns lines and there should be one for @image. @image is a known directive and hence we expect only that one to have warning.
Steps:

Provide setup instructions.
Explain in detail how the functionality can be tested.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ 👍🏻] Added tests
[ 👍🏻] Ran the ./bin/test script and it succeeded
[👍🏻 ] Updated documentation if necessary

@swift-ci please test

@d-ronnqvist Thank you, i will just close this PR and open a new one


fix: Improvement for the dialog to create a new list, when there is none

Hi everyone!
As noted in #4293, the current dialog shown when there is no user list has some UI issues.
Here is the new look:

Codecov Report

Merging #4296 (5ff7f31) into develop (cac58a2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4296      +/-   ##
===========================================
- Coverage    10.79%   10.79%   -0.01%
===========================================
  Files          287      287
  Lines        14288    14290       +2
===========================================
  Hits          1542     1542
- Misses       12746    12748       +2

Impacted Files
Coverage Δ

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
88.18% <ø> (ø)

...app/lib/pages/product_list_user_dialog_helper.dart
0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks for your review @monsieurtanuki


MONDO:0035117 & MONDO:0033482 Spinocerebellar ataxia 47 [Merge]

Mondo term (ID and Label)
MONDO:0035117 PUM1-associated developmental disability-ataxia-seizure syndrome
Reason for deprecation
Orpha is exact match to OMIM, per ORDO: http://www.orpha.net/ORDO/Orphanet_642747
Term to be merged with
MONDO:0033482 Spinocerebellar ataxia 47
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

Dear @kanems,
Thank you for reaching out to the Mondo Disease Ontology, part of the Monarch Initiative!
We have received your ticket and will review it as soon as possible.
If you have any additional information or updates relevant to your inquiry, please add them in a comment on this ticket. Your input is valuable in helping us understand and resolve the issue effectively.
Thank you for your patience and for your contributions to Mondo!
Sincerely,
The Mondo Team

@kanems Thank you for this request!
Based on the overlapping mappings that you point out, MONDO:0035117 PUM1-associated developmental disability-ataxia-seizure syndrome will be merged into MONDO:0033482 Spinocerebellar ataxia 47.
These changes will appear in the next Mondo release.


Import Project error on Project 'General' already exists

Hi.
When I export all project from dbeaver 4.02. on one Windows PC and try to import only selected projects into dbeaver 4.02. on another Windows PC org.jkiss.dbeaver.DBException: Project 'General' already exists error is generated even General is not selected.

Same happens when I rename target General project

Can you, please, check it? Thanks.

Thanks for report


feat: allowing column to be omitted when window size get too small

What does this PR do?
Making column having an optional property, meaning they can be hidden when the screen get too small.
Screenshot / video of UI
https://github.com/projectatomic/ai-studio/assets/42176370/00f4a80d-78f4-4558-8865-58d6cab6bc95
What issues does this PR fix or reference?
Fixes https://github.com/projectatomic/ai-studio/issues/273
How to test this PR?

TODO: write unit tests

Closing as we still not have a single source of truth and the Table component is used by the core


DNM: Test of master

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sdake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: howardjohn
If they are not already assigned, you can assign the PR to them by writing /assign @howardjohn in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-istioctl-k8s-presubmit-tests.sh
703fde54c82cadc4cd1026957620f27a781e0c6c
link
/test integ-istioctl-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-istioctl-k8s-presubmit-tests.sh
703fde54c82cadc4cd1026957620f27a781e0c6c
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
703fde54c82cadc4cd1026957620f27a781e0c6c
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-istioctl-k8s-presubmit-tests.sh
703fde54c82cadc4cd1026957620f27a781e0c6c
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-new-installer-k8s-presubmit-tests.sh
703fde54c82cadc4cd1026957620f27a781e0c6c
link
/test integ-new-install-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
703fde54c82cadc4cd1026957620f27a781e0c6c
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

this was a validation PR, it passed the gate.


[MSCM] Connection failed MultiplayerApiUnreachable

I've tried latest versions of BeatTogether & MultiplayerCore on Quest2 with 1.21.0
Got it working but when I'm trying to connect to QuickPlay or CreateServer it throws an error
[MSCM] Connection failed MultiplayerApiUnreachable

BeatTogether was compiled from here: https://github.com/michael-r-elp/BeatTogether.Quest
MultiplayerCore logs
04-19 00:08:14.295 INFO QuestHook[MultiplayerCore|v0.1.0]: Creating config file...
04-19 00:08:14.299 INFO QuestHook[MultiplayerCore|v0.1.0]: Config file already exists.
04-19 00:08:14.299 INFO QuestHook[MultiplayerCore|v0.1.0]: Completed setup!
04-19 00:08:15.092 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hooks...
04-19 00:08:15.093 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: NetworkPlayerEntitlementChecker_GetEntitlementStatus to offset: 0x7776c72b58
04-19 00:08:15.093 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: NetworkPlayerEntitlementChecker_Start to offset: 0x7776c7276c
04-19 00:08:15.093 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerResultsPyramidPatch to offset: 0x7776ba5ea4
04-19 00:08:15.093 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: IntroAnimationPatch to offset: 0x7776bf2e0c
04-19 00:08:15.093 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerIntroAnimationController_BindTimeline to offset: 0x7776bf6a90
04-19 00:08:15.093 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerOutroAnimationController_BindOutroTimeline to offset: 0x7776ba4dec
04-19 00:08:15.094 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerPlayersManager_get_allActiveAtGameStartPlayers to offset: 0x7776ba7a2c
04-19 00:08:15.094 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: CreateServerFormController_get_formData to offset: 0x7776c0afec
04-19 00:08:15.094 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: CreateServerFormController_Setup to offset: 0x7776c0b0fc
04-19 00:08:15.095 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerLobbyController_ActivateMultiplayerLobby to offset: 0x7776c01444
04-19 00:08:15.095 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerLobbyAvatarManager_AddPlayer to offset: 0x7776bfddc8
04-19 00:08:15.096 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: AvatarPoseRestrictions_HandleAvatarPoseControllerPositionsWillBeSet to offset: 0x7776cc29d0
04-19 00:08:15.096 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: QuickPlaySongPacksDropdown_LazyInit to offset: 0x7776b7f984
04-19 00:08:15.096 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerModeSelectionFlowCoordinator_HandleJoinQuickPlayViewControllerDidFinish to offset: 0x7776ba0374
04-19 00:08:15.096 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: SessionManagerStart to offset: 0x7776f0772c
04-19 00:08:15.097 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: SessionManager_StartSession to offset: 0x7776f08224
04-19 00:08:15.097 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbyPlayersDataModel_HandleMenuRpcManagerGetRecommendedBeatmap to offset: 0x7776d26124
04-19 00:08:15.098 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbyPlayersDataModel_HandleMenuRpcManagerRecommendBeatmap to offset: 0x7776d26700
04-19 00:08:15.098 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbyPlayersDataModel_SetLocalPlayerBeatmapLevel to offset: 0x7776d23dc0
04-19 00:08:15.099 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: BeatmapIdentifierNetSerializableHelper_ToPreviewDifficultyBeatmap to offset: 0x7776cce0fc
04-19 00:08:15.099 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerConnectedPlayerInstaller_InstallBindings to offset: 0x7776bd83e8
04-19 00:08:15.099 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbyPlayersActivate to offset: 0x7776d24768
04-19 00:08:15.100 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerLevelLoader_LoadLevel to offset: 0x7776bfb870
04-19 00:08:15.100 INFO QuestHook[MultiplayerCore|v0.1.0]: Hello BeatTogether!
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbyGameStateController_HandleMultiplayerLevelLoaderCountdownFinished to offset: 0x7776c9ab90
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbyGameStateController_Activate to offset: 0x7776c97ea8
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbySetupViewController_SetPlayersMissingLevelText to offset: 0x7776d28838
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbySetupViewController_SetStartGameEnabled to offset: 0x7776d2889c
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LobbySetupViewController_DidActivate to offset: 0x7776d289fc
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: MultiplayerLobbyConnectionController_CreateParty to offset: 0x7776bffd90
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: LevelSelectionNavigationController_Setup to offset: 0x7776c8d364
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: CenterStageScreenController_Setup to offset: 0x7776b56c14
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: BGNetDebug_Log to offset: 0x777829ad3c
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: BGNetDebug_LogError to offset: 0x777829ae3c
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: BGNetDebug_LogException to offset: 0x777829af40
04-19 00:08:15.102 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: BGNetDebug_LogWarning to offset: 0x777829b054
04-19 00:08:15.103 INFO QuestHook[MultiplayerCore|v0.1.0]: Installing hook: GameServerPlayerTableCell_SetData to offset: 0x7776be30c4
04-19 00:08:15.103 INFO QuestHook[MultiplayerCore|v0.1.0]: Installed all hooks!
04-19 00:08:29.375 DEBUG QuestHook[MultiplayerCore|v0.1.0]: (BGNetDebug::Log) [MasterServerNetworkPlayerModel] Create ConnectedPlayerManager. params: MasterServerConnectionManager+ConnectToServerParams
04-19 00:08:29.401 DEBUG QuestHook[MultiplayerCore|v0.1.0]: (BGNetDebug::Log) Sending ConnectToServer Message to MasterServer
04-19 00:08:29.416 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Creating MpPacketSerializer
04-19 00:08:29.416 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Constructing MpPacketSerializer
04-19 00:08:29.416 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Registering MpPacketSerializer
04-19 00:08:29.416 DEBUG QuestHook[MultiplayerCore|v0.1.0]: MpPacketSerializer Registered Successfully
04-19 00:08:29.416 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Registering Callback
04-19 00:08:29.416 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Callback HandleMpexBeatmapPacket Registered
04-19 00:08:29.416 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Callback HandlePlayerData Registered
04-19 00:08:29.416 DEBUG QuestHook[MultiplayerCore|v0.1.0]: MultiplayerSessionManager.StartSession, creating localPlayer
04-19 00:08:29.422 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Platform: Oculus = OculusQuest
04-19 00:08:29.422 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Creating MpPlayerData
04-19 00:08:29.423 DEBUG QuestHook[MultiplayerCore|v0.1.0]: Creating MpPlayerData finished
04-19 00:08:39.462 DEBUG QuestHook[MultiplayerCore|v0.1.0]: (BGNetDebug::Log) Sending ConnectToServer Message to MasterServer
04-19 00:08:49.509 DEBUG QuestHook[MultiplayerCore|v0.1.0]: (BGNetDebug::Log) [MSCM] Connection failed MultiplayerApiUnreachable

I've appreciate ur work on this mod and wanna help if i could

Unfortunately the current public BT server isn't compatible with the current version of Beat Saber, so if you want to test the mod, you'd either need access to the BT test servers which are patreon and BSMG Quest Testers only or you'd need to run your own instance of the dedicated and master server using the code in the BeatTogether org.

Thanks for info


fix: read version number from lint-staged package.json (#1043)

I think the current code is reading package.json from the current working directory.
If the package.json did not have a version number, it would cause lint-staged to crash.

It seems that reading JSON is problematic with ESM... it should read lint-staged's own version number.


Provide option to set log level for the prom-migrator tool

The prom-migrator tool is lacking a --log-level=<level> which may be very handy to reduce useless messages from the output (i.e. msg="Exceeded 'max-read-duration', setting back to 'max-read-duration' value" and similar).

closing this issue, as we haven’t received multiple requests from users for this feature and it's quite stale! :)
If you still have a need for this, Please open a new issue.
Thanks!


Update rule-processing.md

In ChildRCG1, Network rule should have a higher priority (smaller priority field value) than Application rules. Corrected Capitalization on NetworkRc1.
Corrected AppRCG2 to AppRC2 as it is a collection, not a group.

@vhorne

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Allow building against latest Binary Ninja API version

This adds -DBINEXPORT_BINARYNINJA_LATEST=ON to build against the latest available API.
Additionally, this PR updates the stable/dev pinned versions and stubs.
This fixes #120 and #108

Now uses add_custom_command so we only need to run the stub generator once. Added a PS1 script that does the equivalent of the current bash one. I don't have a Windows install available, but running using pwsh this generates exactly the same output.

Thanks for the PR. I spent way too long trying to modify the project to work with the latest Binja API. Can confirm this PR works with the dev channel (at the time of writing 4.2.6146-dev (d7e28a65))


What Docker Version?

Hello, I am interested in using this project; could you please confirm and document in the readme the recommended versions of Docker and Docker compose?

Sorry, I found them in the cluster readme. https://github.com/NLKNguyen/alpine-mpich/tree/master/cluster

Glad you are interested in using this.  I will put Docker version information in the front page too.
Also, I've just added screencasts in the wiki pages of deployment sections for more clarification.


Ensure older session does not clobeer newer session.

The following sequence caused older session to kill newer session.

User 1 joins - u1s1 (User 1, Session 1)
User 2 joins
User 1 leaves - u1s1 leaves
User 1 joins immediately - u1s2 joins
User 2 gets ParticipantInfo of u1s2
u1s1 leave - participant close - change to DISCONNECTED state propagates - as this is in a goroutine, the participant update happens after u1s2 has propogated and sent to User 2.
In the non-publisher path, batched updates checks for existing participant update for that identity and ignores if theere is a newer session.
But, for publisher (which is always immediately sent), there was no check for a newer session of that participant identity. So, the participant DISCONNECTED of u1s1 ended up getting sent to User 2 and client saw that as a change in participant SID.

Fix by checking for newer session of participant.
Also changing the participant cache update to do them after sending the update message. Else, there was a window where cached version would have been updated before send and a version compare could have concluded that the update has been sent.

Awesome find!

Also changing the participant cache update to do them after sending the update message. Else, there was a window where cached version would have been updated before send and a version compare could have concluded that the update has been sent.

If we updated the map after it's sent.. wouldn't it be possible for two goroutines to enter SendParticipantUpdate concurrently and both versions of the messages being sent?

Awesome find!

Also changing the participant cache update to do them after sending the update message. Else, there was a window where cached version would have been updated before send and a version compare could have concluded that the update has been sent.

If we updated the map after it's sent.. wouldn't it be possible for two goroutines to enter SendParticipantUpdate concurrently and both versions of the messages being sent?

Good point. I guess calling WriteMessage inside the lock is fine as that is non-blocking operation. WDYT?

Awesome find!

Also changing the participant cache update to do them after sending the update message. Else, there was a window where cached version would have been updated before send and a version compare could have concluded that the update has been sent.

If we updated the map after it's sent.. wouldn't it be possible for two goroutines to enter SendParticipantUpdate concurrently and both versions of the messages being sent?

Good point. I guess calling WriteMessage inside the lock is fine as that is non-blocking operation. WDYT?

Actually, reverting that change in this commit. Will think more about it.


Feature Request: Checkbox and Radio classes configurable

Hello,
I would like to do a Feature Request.
I am developing a survey using survey-vue and had difficulties accessing the checkbox and radiobox classes. As far as I know there is currently no possibility to change the "checkbox-material" or the "circle class into something else.
It would be great to make these classes also configurable through the css Object. Maybe as "decorator" or something like that.
My current solution is to "hardcode" the classes into the library which is not very satisfying.
Thank you very much in advance!

@cschra great! Thank You!


No access to the camera on the Pi4 b

Description
Creating a distro for the Raspberry Pi 4 B using yocto dunfell, I'm getting an error message when I'm trying to launch:
raspivid -d(error copied below)
and when I launch:
vcgencmd get_cameraI get: supported=0 detected=0
But using Raspbian it works correctly.
Steps to reproduce the issue:

Clone a clean yocto project, using dunfell:

git clone -b dunfell git://git.yoctoproject.org/poky.git
git clone -b dunfell git://git.yoctoproject.org/meta-raspberrypi
git clone -b dunfell git://git.openembedded.org/meta-openembedded

Launch enviroment variables script:

source poky/oe-init-build-env

Modify config files:

in local.conf add:
MACHINE = "raspberrypi4"
ENABLE_UART = "1"
VIDEO_CAMERA = "1"
IMAGE_INSTALL_append = " userland"

in bblayers.conf add:
meta-openembedded/meta-oe
meta-openembedded/meta-multimedia
meta-openembedded/meta-networking
meta-openembedded/meta-python
meta-raspberrypi

Little fix on packagegroup-rpi-test.bb:

wireless-regdb \ ----> wireless-regdb-static \

Bitbake:

bitbake rpi-test-image

Describe the results you received:
Launching: raspivid -d
I get:
mmal: Cannot read camera info, keeping the defaults for OV5647
mmal: mmal_vc_component_create: failed to create component 'vc.ril.camera' (1:E)
mmal: mmal_component_create_core: could not create component 'vc.ril.camera' (1)
mmal: Failed to create camera component
mmal: main: Failed to create camera component
mmal: Camera is not enabled in this build. Try running "sudo raspi-config" and d

Launching: vcgencmd get_camera
I get: supported=0 detected=0
Describe the results you expected:
Launching: raspivid -d
Get no errors.
Launching: vcgencmd get_camera
Get: supported=1 detected=1
Additional information you deem important (e.g. issue happens only occasionally):
Additional details (revisions used, host distro, etc.):
It works with raspbian: 2020-05-27-raspios-buster-lite-armhf.img

I have the same problem.
Add local.conf and bitbake core-image-weston
VIDEO_CAMERA = "1"
KERNEL_MODULE_AUTOLOAD += "bcm2835-v4l2"
GPU_MEM = "512"

Occurs on the dunfell and zeus branches.
Same 32bit and 64bit
Raspberry Pi 4 Model B (I have not checked it with Raspberry Pi 3/2/1).

I get dmsg | grep bcm2835
[    3.024650] bcm2835_vc_sm_cma_probe: Videocore shared memory driver
[    3.201590] bcm2835_mmal_vchiq: module is from the staging directory, the quality is unknown, you have been warned.
[    3.201613] bcm2835_mmal_vchiq: module is from the staging directory, the quality is unknown, you have been warned.
[    3.251221] bcm2835_v4l2: module is from the staging directory, the quality is unknown, you have been warned.
[    3.263214] bcm2835_codec: module is from the staging directory, the quality is unknown, you have been warned.
[    3.269040] bcm2835-codec bcm2835-codec: Device registered as /dev/video10
[    3.269069] bcm2835-codec bcm2835-codec: Loaded V4L2 decode
[    3.271035] bcm2835-codec bcm2835-codec: Device registered as /dev/video11
[    3.271066] bcm2835-codec bcm2835-codec: Loaded V4L2 encode
[    3.274723] bcm2835-codec bcm2835-codec: Device registered as /dev/video12
[    3.274747] bcm2835-codec bcm2835-codec: Loaded V4L2 isp

@SCVready
I was able to solve this problem.
Changed /boot/config.txt (Near line 460 to 480).
Before:
## start_x
##     Set to "1" to enable the camera module.
##
##     Enabling the camera requires gpu_mem option to be specified with a value
##     of at least 128.
##
##     Default 0
##
#start_x=0

After:
## start_x
##     Set to "1" to enable the camera module.
##
##     Enabling the camera requires gpu_mem option to be specified with a value
##     of at least 128.
##
##     Default 0
##
start_x=1

Probably "start_x=1" near the last line of config.txt is not read.

Thank you so much @NobuoTsukamoto, it is also working for me.


GraalVM 17 flags for 1.20.1 modded server (Prominence II)

Tried to use the flags but I cannot run the server (I use pterodactyl with this image ghcr.io/rikodev/pterodactyl-graalvm:17)
Now I'm running only with xms 16G and xmx 16G, and it works, but I wanted to optimize the server, 10 player, 400+ mods, 128gb ram, i7-11700k
The flags have an order, I don't know how to handle them, if you could help me, thanks

Sorry for not seeing this issue, what do you mean it doesn't run? Is there any error?

Start with memory allocation, then base flags, then gc flags, and finally anything else.

I tried but all other than xms and xmx cant get the server to start, and it's unstable even with only them

If you could help me with some flags to start, i tried but I cannot combine with GC

What do you mean "combine with GC", you just paste the gc flags after the base flags with a space between them.

Try these flags:
-Xms12G -Xmx12G -XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions -XX:+AlwaysActAsServerClassMachine -XX:+AlwaysPreTouch -XX:+DisableExplicitGC -XX:NmethodSweepActivity=1 -XX:ReservedCodeCacheSize=400M -XX:NonNMethodCodeHeapSize=12M -XX:ProfiledCodeHeapSize=194M -XX:NonProfiledCodeHeapSize=194M -XX:-DontCompileHugeMethods -XX:+PerfDisableSharedMem -XX:+UseFastUnorderedTimeStamps -XX:+UseCriticalJavaThreadPriority -XX:+EagerJVMCI -Dgraal.TuneInlinerExploration=1 -XX:+UseZGC -XX:AllocatePrefetchStyle=1 -XX:-ZProactive -XX:ConcGCThreads=8

12G Ram
Uses GraalVM Flags
Non-Proactive ZGC
8 Threads for GC

Using 12G of memory as allocating too much memory can cause similar issues and I think 12G should be fine for 10 players. Bump it up if needed

Seems working for now, will see

Awesome! Probably forgot the space between each flag section and put too much ram

Still lags/freeze sometimes for a few seconds, added 2gigs, now will see

Lagging and freezing can indicate too much ram as well though

Closing as it seems to be resolved


RFC: Refactor to models.

This RFC is a fantasy-land documentation for how I think we could internally organize our code to benefit multiple use cases ranging from API client testing to API server testing. The idea here is not to suggest that Meeshkan should do all of this, but to explore a flexible design that would allow implementing such use cases. The suggestions here are not all mine but are loaned/stolen from or inspired by @fornwall 's internal gist and @aby2s 's existing implementations.
Much of the functionality presented here can be covered by the current Faker() and callback implementations. The purpose of this RFC would be to formalize those into PBT framework. For example, I think the ability to transform the generated data is exactly what is offered by PBT generator transformations. I also feel that the "storage" solutions we have now could be formalized into something that's easy also for users to implement. That would only be needed when requiring stateful testing, which I don't think that many users actually do.
The markdown document can be viewed in browser here.
TODO:

[ ]  Some idea how the stateful testing would work for both API clients and API producers

It'd be interesting to see how "dumb" we could make the SDK so that most of the logic was still handled on a server - it'd allow us to decouple the model from python (or any language).

It's a good question. I would guess that a Pyro server would be the fastest way to get started but all the solutions are on the table.

The million-dollar question is how we make the model. I know there are a lot of experiments floating around, and there are still more questions than answers, but it's all exciting!

That's a big question! This proposal is a bit more about the user-facing API of the model (once it exists) rather than how it's built, but it'll of course be important that we can offer tools for flexible generation and extension of such model objects from different sources (programmatic, standard OpenAPI, "extended OpenAPI with x-meeshkan-?).

It's not documentation for something real but rather a proposed architecture. I don't think it's a good idea to have it in the main branch. It could be confusing.

It's not documentation for something real but rather a proposed architecture. I don't think it's a good idea to have it in the main branch. It could be confusing.

Yes, this was not meant to be merged to master but an RFC for how the tool should be extended to cover testing clients and servers.


BSM Lane Change Fault

Describe the bug
2021 RAV4. The Lane Change BSM has a fault scenario. This vehicle has a “BLINKING” lane change marker that may allow BSM to NOT override the Lane Change Assist, depending on instantaneous status of signal when turn signal is turned on.
How to reproduce or log data
Activate lane change while OP is engaged. If a vehicle is present or approaching, the “blocked” message comes up on C2 Screen and OP prevents lane change. Once in awhile, the BSM Light on side-mirror appears to BLINK and vehicle starts lane change despite another vehicle being in blind spot.
Expected behavior
The vehicles BSM status should prevent lane change, even when side-mirror indicator blinking a warning.
Device/Version information (please complete the following information):

Device: Comma Two
Dongle ID: e346693d5b95a02f
Route: https://my.comma.ai/cabana/?route=14b218baa26b0ebd|2020-12-30--19-08-07&exp=1640910369&sig=oFZ6%2FlxvNqUbhAA11InY9wxnRmifvAtBByv2byUqg%2Fs%3D&max=3&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F14b218baa26b0ebd%2Ffef299cdaf7f0f1d294776fff0d96974_2020-12-30--19-08-07
Timestamp: 67
Version: 0.8.1 master
Car make/model: 2021 RAV4 TSS 2.0  (toyota_nodsu_hybrid_pt_generated.dbc)

Additional context

A minimum (0.5sec?) lockout delay upon blindspot-detect should solve issue.

Is there another bit that signifies the blinking state?

Is there another bit that signifies the blinking state?

Is it actually blinking or just losing track of the car for a little bit?

Is it actually blinking or just losing track of the car for a little bit?

After looking for the other bit, now I’m agreeing that it’s probably just losing and regaining. The physical light on the car appears to be a three state. Off,  Solid, or R Rapid Blinking.
It’s a little difficult to test... because it may scare people when I turn on the signal when they’re in my blind spot.
Thanks,
Cowan Moore
330-701-3922

On Jan 4, 2021, at 6:55 AM, Willem Melching<EMAIL_ADDRESS>wrote:

Is it actually blinking or just losing track of the car for a little bit?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

After looking for the other bit, now I’m agreeing that it’s probably just losing and regaining. The physical light on the car appears to be a three state. Off,  Solid, or R Rapid Blinking.
It’s a little difficult to test... because it may scare people when I turn on the signal when they’re in my blind spot.
Thanks,
Cowan Moore
330-701-3922

On Jan 4, 2021, at 6:55 AM, Willem Melching<EMAIL_ADDRESS>wrote:

Is it actually blinking or just losing track of the car for a little bit?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

This discusses that third blinking state.  BSM light will blink if there’s a car in the Blindspot, and the turn signal is activated in that direction. I’ll try to re-simulate it this morning and send you the cabana
Thanks,
Cowan Moore
330-701-3922

On Jan 4, 2021, at 6:52 AM, Willem Melching<EMAIL_ADDRESS>wrote:

Is there another bit that signifies the blinking state?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

This discusses that third blinking state.  BSM light will blink if there’s a car in the Blindspot, and the turn signal is activated in that direction. I’ll try to re-simulate it this morning and send you the cabana
Thanks,
Cowan Moore
330-701-3922

On Jan 4, 2021, at 6:52 AM, Willem Melching<EMAIL_ADDRESS>wrote:

Is there another bit that signifies the blinking state?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks! My feeling it's just losing the car. Not sure if we want a cooldown on the signal, that could be annoying if you try to change lanes right after a car passes you.

Thanks! My feeling it's just losing the car. Not sure if we want a cooldown on the signal, that could be annoying if you try to change lanes right after a car passes you.

Even 1 second delay could be helpful...   the BSM appears to fully deactivated prior to passing car being fully passed.

Even 1 second delay could be helpful...   the BSM appears to fully deactivated prior to passing car being fully passed.

Even 1 second delay could be helpful... the BSM appears to fully deactivate prior to passing car being fully passed.

Even 1 second delay could be helpful... the BSM appears to fully deactivate prior to passing car being fully passed.

I don't think we should be writing hacks like this to overcome deficiencies in the car's built in BSM. These delay values may not be consistent between models in a make.

I don't think we should be writing hacks like this to overcome deficiencies in the car's built in BSM. These delay values may not be consistent between models in a make.


Link for the API on the modlinks.xml is unsuitable for MacOS

Hi, dude!
I'm toying with the ModInstaller, and found that for the link provided on hodlinks.xml for the API is not working too well on MacOS:
        <ModLink>
            <Name>Modding API</Name>
            <Files>
                <File>
                    <Name>Assembly-CSharp.dll</Name>
                    <SHA1>E880EA1B2B4B57FBD6ECA36B26746F08FF4EEF9F</SHA1>
                    <Patch><IP_ADDRESS></Patch>
                </File>
            </Files>
            <Link>yada yada yada</Link>
            <UnixLink>yada yada yada</UnixLink>
            <Dependencies />
        </ModLink>

At least my GamePad was not working on this Assembly-CSharp.dll  - I didn't did a very comprehensive test however, as playing without my M30 is out of question.
So I cloned the HollowKnight.Modding project and built it on my Mac, and the resulting DLL appears to be working fine (at least the GamePad is now working).
There's a way to add it to the project, so other MacOS users can use it too?
Cheers!

Just came here to say that the ModdingAPI I compiled for my Mac is working flawless since I started to use it - without any colateral effects (at least until this moment).
And I'm able to use my M30 as before modding it.

As it is, the UnixLink and Link setup is a bit of a mess which I've been planning to fix with the next update to the game. As far as Linux v Mac goes in regards to libraries, both use the same version of InControl for input handling with the Assembly between the two being identical. Windows differs in that it has XInput used. The only real pain is that the hash is poorly setup for cross-platform as every other dll tends to be platform-independent. A PR fixing this now instead of waiting for the next release would be nice considering how long the beta has been out for without making it to stable. If you don't want to bother, I could probably fix this later this week. I went ahead and put a release up on the actual API repo with both versions for later. Sorry for how long it's taken to get to this, I've been busy recently.

I completely understand the "bust" status, I'm on the same boat - took a month to remember this. Sorry.
I will check and remember what I toyed here, and will come back to you on the week-end.
Cheers!

Took a while, but I released a new installer (fifty-six/Scarab) and that should deal with the issue as it swaps to a new version of modlinks.xml.

Thank you!
I had a disk crash (induced by Apple, that screwed up the GUID partitions of two HDs of mine - the one that was failing, and the one that was its backup!!!), and still didn't had the time to rebuild my HollowKnight setup.
But I will soon - already missing playing while listening that fantastic music! :)
Cheers!


Warnings compiling ws_listener_impl.cpp in VS 2017

There are several warnings building ws_listener_impl.cpp under VS 2017. These seem to be  coming from the cpprestsdk-2.10.11 library so maybe this issue is in the wrong place.  See messages below. The warnings don't really identify the location of the source code so they are hard to track down.
The first error is related to the websocketpp::utility::to_lower function in utilities_impl.hpp. Adding a cast seems to satisfy the warning but the return value from tolower() could be -1 and that is not really handled.
inline std::string to_lower(std::string const& in)
{
    std::string out = in;
    std::transform(out.begin(), out.end(), out.begin(), [](char c) { return (char)::tolower(c); });
    return out;
}

The others seem more subtle and coming from frame.hpp with the extended_header functions.

1>ws_listener_impl.cpp
1>c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\algorithm(1443): warning C4244: '=': conversion from 'int' to 'char', possible loss of data
1>e:\projects\3rdparty\cpprestsdk\cpprestsdk-2.10.11-nmos-cpp\cpprestsdk\release\libs\websocketpp\websocketpp\impl\utilities_impl.hpp(39): note: see reference to function template instantiation '_OutIt std::transform>>,std::_String_iterator>>,int(__cdecl *)(int)>(const _InIt,const _InIt,_OutIt,_Fn)' being compiled
1>        with
1>        [
1>            _OutIt=std::_String_iterator>>,
1>            _Ty=char,
1>            _InIt=std::_String_iterator>>,
1>            _Fn=int (__cdecl *)(int)
1>        ]
1>c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\xutility(2949): warning C4244: '=': conversion from 'const _Ty' to '_Ty', possible loss of data
1>        with
1>        [
1>            _Ty=int
1>        ]
1>        and
1>        [
1>            _Ty=uint8_t
1>        ]
1>c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\xutility(2972): note: see reference to function template instantiation '_OutIt *std::_Fill_n_unchecked2<_Ty*,unsigned int,int>(_OutIt,_Diff,const int &,std::false_type)' being compiled
1>        with
1>        [
1>            _OutIt=uint8_t *,
1>            _Ty=uint8_t,
1>            _Diff=unsigned int
1>        ]
1>e:\projects\3rdparty\cpprestsdk\cpprestsdk-2.10.11-nmos-cpp\cpprestsdk\release\libs\websocketpp\websocketpp\frame.hpp(237): note: see reference to function template instantiation '_OutIt *std::fill_n(_OutIt,_Diff,const _Ty &)' being compiled
1>        with
1>        [
1>            _OutIt=uint8_t *,
1>            _Diff=unsigned int,
1>            _Ty=int
1>        ]

Looks like all of those are due to websocketpp, and mostly harmless.
See https://github.com/zaphoyd/websocketpp/pull/758 for someone else's attempt to resolve these, and https://en.cppreference.com/w/cpp/string/byte/tolower#Notes.

These are still not fixed in upstream websocketpp, though more people have submitted similar PRs... see https://github.com/zaphoyd/websocketpp/pull/767 and https://github.com/zaphoyd/websocketpp/pull/783


Setup branch push coverage and fix coverage uploads

Signed-off-by: Peter Zhu<EMAIL_ADDRESS>Description
Setup branch push coverage and fix coverage uploads
Issues Resolved
https://github.com/opensearch-project/opensearch-build/issues/2193
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Note: we still need to test a bit more on this.
As codecov requires the base branch to have codecov 1st before it can compare for analysis.
We might need more changes before this is fully ready.
Thanks.


[Bug]: dlib won't install because of building wheels?

What Operating System(s) are you seeing this problem on?
Windows
dlib version
19.24.2
Python version
3.12
Compiler
C++ Compiler
Expected Behavior
No response
Current Behavior
this is my first time using these and i don't really know how to fix this. this is my 4th time trying to install dlib but it just won't install. this is where process stops
Collecting dlib
  Using cached dlib-19.24.2.tar.gz (11.8 MB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'
Building wheels for collected packages: dlib
  Building wheel for dlib (pyproject.toml): started
  Building wheel for dlib (pyproject.toml): still running...
  Building wheel for dlib (pyproject.toml): still running...
  Building wheel for dlib (pyproject.toml): still running...
  Building wheel for dlib (pyproject.toml): still running...
  Building wheel for dlib (pyproject.toml): still running...
  Building wheel for dlib (pyproject.toml): still running...
  Building wheel for dlib (pyproject.toml): still running...

Steps to Reproduce
is there any way that can solve this?
Anything else?
i hope i can have an immediate response, this project is for our thesis due on dec. 1 :')))

Could you try with python 3.11 instead?
I haven't tried with 3.12, but 3.11.6 works fine.
Pybind11 needs to be updated to 2.11 (using 2.10 now, and I can see in the 2.11 changelog that they added some stuff for Python 3.12)
So, if you're in a hurry, the fastest way to solve your issue would be to downgrade Python.

What's the exact problem?  Maybe you didn't wait long enough for it to compile?  I don't see an error in the post.

What's the exact problem? Maybe you didn't wait long enough for it to compile? I don't see an error in the post.

i did wait for it to compile but it just keeps getting the process cancelled by its own, but i tried installing it using command prompt and it did install, but then the dlib in my venv script folder is nowhere to be seen, however dlib can be seen in my lib folder, is that alright or there should also be a dlib in my script folder?

I'm still not sure what you have been trying.  For instance, the only way I know to install is to use the command prompt.  I'm not sure what the non-command-prompt way of installing would be (so whatever that is probably won't work).  I would just do pip install dlib on the command prompt.

FYI dlib takes about 15 min to compile on my machine.


Have consistent method/parameter names across SDKs

This is the actions from review of this issue "Consistency of API names surfaced by each SDK" dapr/dapr#2535
Service Invocation API

Rename invokeService to invokeMethod
Rename param serviceID to appId
Rename param method to methodName

Like this
func (c *GRPCClient) invokeMethod(ctx context.Context, appID, methodName string) (out []byte, err error)
func (c *GRPCClient) InvokeMethodWithContent(ctx context.Context, appID, methodName string, content *DataContent) (out []byte, err error)
State Store API

Rename param from store to storeName
Rename param from data to value

For example like this on one of the APIs
func (c *GRPCClient) SaveState(ctx context.Context, storeName, key string, value []byte) error
Secret Store API

Rename param from store to storeName

For example like this
func (c *GRPCClient) GetSecret(ctx context.Context, storeName, key string, meta map[string]string) (out map[string]string, err error)
Binding

Change struct BindingInvocation  to InvokeBindingRequest
Make sure that in BindingInvocation  struct uses name, operation, data as names.

Pubsub

Rename param from component to pubsubName
Rename param from topic to topicName
Rename param from in to data

For example like this
func (c *GRPCClient) PublishEvent(ctx context.Context, pubsubName, topicName string, data []byte) error

Resolved in #121


Why I can't get any app store information in my app?

My app has been published to app store, but I can't get any data with below code:
PackageInfo packageInfo = await PackageManager.getPackageInfo();
    print('app name: ${packageInfo.appName}');
    if (Platform.isIOS) {
      VersionInfo? versionInfo = await UpgradeVersion.getiOSStoreVersion(
          packageInfo: packageInfo, regionCode: "US");
          debugPrint(versionInfo.toJson().toString());
    }

just got the below result:
flutter: app name:
flutter: {localVersion: , storeVersion: null, appStoreLink: null, releaseNotes: null, isReviewing: true, canUpdate: false}

oh, sorry, after stop and rebuild the app, the problem has been solved, thanks!


librispeech dataset has to download whole subset when specifing the split to use

Describe the bug
librispeech dataset has to download whole subset when specifing the split to use
Steps to reproduce the bug
see below
Sample code to reproduce the bug
!pip install datasets
from datasets import load_dataset
raw_dataset = load_dataset("librispeech_asr", "clean", split="train.100")

Expected results
The split "train.clean.100" is downloaded.
Actual results
All four splits in "clean" subset is downloaded.
Environment info

datasets version: 2.3.2
Platform: Linux-5.4.188+-x86_64-with-Ubuntu-18.04-bionic
Python version: 3.7.13
PyArrow version: 6.0.1
Pandas version: 1.3.5

Hi! You can use streaming to fetch only a subset of the data:
raw_dataset = load_dataset("librispeech_asr", "clean", split="train.100", streaming=True)

Also, we plan to make it possible to download a particular split in the non-streaming mode, but this task is not easy due to how our dataset scripts are structured.

Hi,
That's a great help. Thank you very much.


Make Event Consumption optimization adjustable

It would be beneficial if the EmbeddedEventStore allowed a setting to have the internal EventConsumers aggregate to a global event stream or for them to stay on a private event stream.
In some scenario, this optimization (along the lines of database resources for example) is not mandatory and maybe not even desired.
Hence, this issue should allow adjusting that optimization, through a boolean you could set through the constructor (Axon 3) or the builder (Axon 4).

This issue has been resolved in PR #919, hence closing.


Issue adding M3U Playlist from a local file

Describe the bug
When I add a playlist and xmltv file from a local file and then create a filter to display the channels, when a go to Mapping, it is adding "     ,"  (quotes there to show how many spaces in front of the comma) in front of the Channel Name. I'm attaching a sample M3U and XMLTV file.
Server (please complete the following information):

OS Windows
Arch Intel 64 Bit
Threadfin Version 1.1 (16)

To Reproduce
Steps to reproduce the behavior:

Add Playlist test.m3u
Add XMLTV file test.xmltv
Create M3U Group Title Filter for Group Title:  TEST-JS. Add an Include field of:  TEST
Go to Mapping
The Channel name has added 5 spaces and a comma in front of the Channel Name

Expected behavior
I'd expect the Channel Name to be exactly what is in the M3U file
Screenshots

Desktop (please complete the following information):

OS: Windows 11 Pro, but it is also happening on Windows 10 Pro
Browser Chrome
Version 126.0.6478.127 (Official Build) (64-bit)

I cannot upload the m3u and xmltv files so I'm adding them here.
 You have a comma after #EXTINF: which should not be there. That is why it shows

It should be #EXTINF: not #EXTINF,


public polynomial should use alpha

in the prover:
        let public = witness[0][0..index.cs.public].to_vec();
        let public_poly = -Evaluations::<Fr<G>, D<Fr<G>>>::from_vec_and_domain(
            public.clone(),
            index.cs.domain.d1,
        )
        .interpolate();

From a quick glance I believe this should use the first alpha for the generic gate.
Note: if this is correct, we could also add a future tweak to halve the size of the public input (cc @imeckler), where the public polynomial values are computed as l1 + alpha^i * l2 where l1 and l2 are the two left registers for the double generic gate.
is this correct?

Maybe it's not, because we sample alpha after absorbing the public polynomial. Does this mean that we are forced to use alpha^0 as the first alpha for the gates? Need to think more about this (the spec will help hopefully).
We absorb the public input as part of the fiat shamir transform, why is this necessary? The PLONK paper doesn't do that, and we don't actually use that in the proof. I think we could remove this part.

From a quick glance I believe this should use the first alpha for the generic gate.

This relies on the fact that the 'first alpha' for the generic gate is alpha^0. I would prefer if we assert that this is the case instead of using alpha for this.

where the public polynomial values are computed as l1 + alpha^i * l2 where l1 and l2 are the two left registers for the double generic gate

To compute alpha^1 * l2 in the verifier circuit for the indexth public input, we need lagrange(index / 2) ^ (alpha * public_input[index/2 + 1]) (for the second input). This works out as the more expensive (lagrange(0) ^ alpha) ^ public_input[1]. I'm not that a ~3/2 increase in cost for the verifier circuit to handle public input is a good trade-off, even if it halves the number of gates used for public input by the prover.

sounds like a better path indeed!
Yeah I discussed this with @imeckler as well and it seems to be a bad idea, at least because of the verifier circuit.


Shutter control needs to be added

ADAravis does not open and close the shutter when taking images.  This needs to be added.

What camera are you using?

It does not matter what camera.
All drivers should call setShutter(1) before starting acquisition, and setShutter(0) after stopping acquisition. This allows the use of shutters controlled by EPICS PVs, or for some drivers, by the camera vendor’s API.
See ADVimba and ADSpinnaker for examples.