Generator for yahoo_finance package

@AndrewAday: Still a couple style things. Take a look at the flake8 stuff (https://travis-ci.org/ADI-Labs/bfd/builds/85823923).
Also, I messed up. Concord uses the google style guide (see http://google.github.io/styleguide/pyguide.html#Comments in particular), so the docstring should be something like:
"""One line description of the function

Args:
     name (type): description
     name (type): description
Returns:
     type: description

I think that the Mypy type specs are pretty good (e.g. Iterator[(float, float)]).

Also, can we move these files to a different folder than yahoo_finance? That'll wreck havoc with Python's module system b/c we already have a module named yahoo_finance.
Let's create a bcd folder and put this stuff in an data subfolder, so something like:
.
└── data
    ├── test.py    # do we need to include this file? It's not really very useful.
    └── yahoo.py


Publish a new release?

I noticed there was an update where you can add an option to allow intercom to show when the environment is development but a new version wasn't released after the change.
Might want to cut a new release and maybe update the docs to show that extra config.

@HeinrichFilter Are you planning on doing this soon? ^

A new release would be nice! :-)

I would greatly appreciate this also. Showing the widget in development mode would be a huge help


IOS NativeDemo pod warnings - CocoaPods was not able to update the master repo

Mac OS X 10.10.1

git clone from https://github.com/EricssonResearch/openwebrtc-examples
git clone the ios-sdk to the folder
in NativeDemo folder, remove .lock file and run pod setup
pod install
I got the following warnings:

Analyzing dependencies
Fetching podspec for OpenWebRTC-SDK from ../openwebrtc-ios-sdk/OpenWebRTC-SDK.podspec
Downloading dependencies
Installing InAppSettingsKit (2.4.4)
Installing OpenWebRTC (0.1.1)
Installing OpenWebRTC-SDK (0.1.1)
Generating Pods project
Integrating client project
[!] CocoaPods was not able to update the master repo. If this is an unexpected issue and persists you can inspect it running pod repo update --verbose
[!] Unable to read the license file /Users/kerwin.ma/openwebrtc-examples/ios/NativeDemo/Pods/OpenWebRTC/LICENSE for the spec OpenWebRTC (0.1.1)
[!] Unable to read the license file /Users/kerwin.ma/openwebrtc-examples/ios/NativeDemo/Pods/OpenWebRTC/LICENSE for the spec OpenWebRTC (0.1.1)
[!] Unable to read the license file /Users/kerwin.ma/openwebrtc-examples/ios/NativeDemo/Pods/OpenWebRTC/LICENSE for the spec OpenWebRTC (0.1.1)
[!] Unable to read the license file /Users/kerwin.ma/openwebrtc-examples/ios/NativeDemo/Pods/OpenWebRTC/LICENSE for the spec OpenWebRTC (0.1.1)

This issue is not specific to the OpenWebRTC pod. Seems like your computer cannot access the official pod trunk:

[!] CocoaPods was not able to update the master repo. If this is an unexpected issue and persists you can inspect it running pod repo update --verbose

Because of this, you can't fetch the latest OpenWebRTC pod which as version 0.3.0. Try follow the instruction of running pod repo update --verbose again.

Feel free to re-open this issue if you have problem with the OpenWebRTC pod. Thanks.

Hi @stefanalund, thanks for your help. I thought it would be our office firewall. I tried at home and I didn't remove the lock file this time, I got the following error:
localhost:NativeDemo kerwin.ma$ ls
NativeDemo		NativeDemo.xcworkspace	Podfile			README.md
NativeDemo.xcodeproj	NativeDemoTests		Podfile.lock
localhost:NativeDemo kerwin.ma$ pod install
Analyzing dependencies
Fetching podspec for OpenWebRTC-SDK from ../../../openwebrtc-ios-sdk/OpenWebRTC-SDK.podspec
[!] Unable to satisfy the following requirements:

OpenWebRTC (= 0.3.0) required by Podfile.lock
OpenWebRTC required by OpenWebRTC-SDK (0.1.1)

Does it mean I get a wrong SDK version?

You need to update your openwebrtc-ios-sdk clone.

Thanks @superdump, I cloned the master ios-sdk from https://github.com/EricssonResearch/openwebrtc-ios-sdk
manually.
I ran the search with command
pod search OpenWebRTC
-> OpenWebRTC (0.1.1)
OpenWebRTC.framework wrapped in CocoaPod
pod 'OpenWebRTC', '~> 0.1.1'

Homepage: http://www.openwebrtc.io
Source:   http://static.verkstad.net/OpenWebRTC.framework_old.zip
Versions: 0.1.1, 0.1 [master repo]

No version 0.3.0 in repo.

Seems my environment issue:
localhost:~ kerwin.ma$ pod setup
Setting up CocoaPods master repo
Setup completed
[!] CocoaPods was not able to update the master repo. If this is an unexpected issue and persists you can inspect it running pod repo update --verbose
If I run 'pos repo update --verboss', it will say:localhost:~ kerwin.ma$ pod repo update --verbose
Updating spec repo master
$ /usr/bin/git pull --ff-only
error: Your local changes to the following files would be overwritten by merge:
CocoaPods-version.yml
Specs/AdobeMobileSDK/4.4.0/AdobeMobileSDK.podspec.json
Specs/BugHD/1.1.0/BugHD.podspec.json
Specs/LlamaKit/0.6.0/LlamaKit.podspec.json
Specs/SynergyKIT-SDK-iOS/0.0.2/SynergyKIT-SDK-iOS.podspec.json
Specs/SynergyKIT-SDK-iOS/0.1.0/SynergyKIT-SDK-iOS.podspec.json
Specs/SynergyKIT-SDK-iOS/0.2.0/SynergyKIT-SDK-iOS.podspec.json
Specs/SynergyKIT-SDK-iOS/0.2.1/SynergyKIT-SDK-iOS.podspec.json
Specs/TestFlightSDK/0.8.3/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.0/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.1.beta1/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.1.beta2/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.1.beta3/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.1/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.2.3.beta1/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.2.4.beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.2.4/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.2.5/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.2.6/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.2.beta1/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.2.beta2/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.2/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.3.0-beta.5/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.3.0-beta.6/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.3.0-beta.7/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.3.0.beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.3.0.beta2/TestFlightSDK.podspec.json
Specs/TestFlightSDK/1.3.0.beta4/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.0.2/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.0/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.1.1-beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.1.2-beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.1.3-beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.1.3-noadid-beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.1.3-noadid/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.1.3/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.1.4/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.2.0-beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.2.0-noadid-beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.2.1-beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.2.1/TestFlightSDK.podspec.json
Specs/TestFlightSDK/2.2.3-beta/TestFlightSDK.podspec.json
Specs/TestFlightSDK/3.0.0/TestFlightSDK.podspec.json
Specs/TestFlightSDK/3.0.2/TestFlightSDK.podspec.json
Specs/UILabel-M5FillFrame/1.0.0/UILabel-M5FillFrame.podspec.json
Specs/UILabel-M5FillFrame/1.0.1/UILabel-M5FillFrame.podspec.json
Specs/XcodeEditor/1.0/XcodeEditor.podspec.json
Specs/XcodeEditor/1.1/XcodeEditor.podspec.json
Specs/XcodeEditor/1.2/XcodeEditor.podspec.json
Specs/XcodeEditor/1.3/XcodeEditor.podspec.json
Specs/XcodeEditor/1.4/XcodeEditor.podspec.json
Specs/XcodeEditor/1.5/XcodeEditor.podspec.json
Specs/XcodeEditor/1.6/XcodeEditor.podspec.json
Please, commit your changes or stash them before you can merge.
Aborting
Updating 7c0f9e7..541b754
Should be my cocoaPods issue, not the SDK or Demo code issue.

I think it would be that I had the old cocoaPods version installed and updated to a newer version later.
The following will help if anyone else has the same issue:
sudo rm -fr ~/Library/Caches/CocoaPods/
sudo rm -fr ~/.cocoapods/repos/master
pod setup
Setting up CocoaPods master repo
CocoaPods 0.37.0.rc.1 is available.
To update use: gem install cocoapods --pre
[!] This is a test version we'd love you to try.
For more information see http://blog.cocoapods.org
and the CHANGELOG for this version http://git.io/BaH8pQ.
Setup completed
localhost:~ kerwin.ma$ pod search OpenWebRTC
-> OpenWebRTC (0.3.0)
OpenWebRTC.framework wrapped in a CocoaPod
pod 'OpenWebRTC', '~> 0.3.0'

Homepage: http://www.openwebrtc.io
Source:   http://static.verkstad.net/OpenWebRTC_0.3.0.zip
Versions: 0.3.0, 0.1.4, 0.1.3, 0.1.2, 0.1.1, 0.1 [master repo]

Thanks.

Nice to hear that you found the problem, good to know for the future. Thanks.

@KerwinMa, thanks it works


Replace kotlin-platform-jvm with kotlin-platform-android

Hello,
This project is a great example but wouldn't it make more sense to use kotlin-platform-android to illustrate how to implement the common part with an Android Library directly, then using in an Android App Project (here AndroidApp)?

That make sense, yes.
TBH I didn't know that there exist a kotlin-platform-android plugin 🙃
Do you know what the difference is (compared to the *-jvm) plugin?

@StefMa In a JVM project you get the JVM Java API, in an Android one you get the Android API so you can develop complete Android Libraries besides Javascript and iOS one! (I'm still trying to figure out the iOS one btw)

@StefMa yes there is kotlin-platform-android and it is mentioned in
https://kotlinlang.org/docs/reference/multiplatform.html. -android allows to to use it with android app/library.

Guess it is fixed by now.

@galex  Have you solved this problem? I am also confused with using Android API


gem install backup2qiniu failed

$ ruby -v
ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
$ gem install backup2qiniu
Building native extensions.  This could take a while...
ERROR:  Error installing backup2qiniu:
	ERROR: Failed to build gem native extension.

    /Users/lidaobing/.rvm/rubies/ruby-2.2.3/bin/ruby -r ./siteconf20151216-3556-1x3pxeo.rb extconf.rb
creating Makefile

make "DESTDIR=" clean

make "DESTDIR="
compiling generator.c
In file included from generator.c:1:
./../fbuffer/fbuffer.h:175:47: error: too few arguments provided to function-like macro invocation
    VALUE result = rb_str_new(FBUFFER_PAIR(fb));
                                              ^
/Users/lidaobing/.rvm/rubies/ruby-2.2.3/include/ruby-2.2.0/ruby/intern.h:793:9: note: macro 'rb_str_new' defined here
#define rb_str_new(str, len) __extension__ (    \
        ^
In file included from generator.c:1:
./../fbuffer/fbuffer.h:175:11: warning: incompatible pointer to integer conversion initializing 'VALUE' (aka 'unsigned long') with an expression of type 'VALUE (const char *, long)' [-Wint-conversion]
    VALUE result = rb_str_new(FBUFFER_PAIR(fb));
          ^        ~~~~~~~~~~
1 warning and 1 error generated.
make: *** [generator.o] Error 1

make failed, exit code 2

Gem files will remain installed in /Users/lidaobing/.rvm/gems/ruby-2.2.3/gems/json-1.8.0 for inspection.
Results logged to /Users/lidaobing/.rvm/gems/ruby-2.2.3/extensions/x86_64-darwin-14/2.2.0/json-1.8.0/gem_make.out

fixed in #12


Update to Dart 2.0.0?

when I try to use it I get this error:
package: ed25519_dart / src / ed25519_dart_base.dart': error: line 16 pos 1: integer literal<PHONE_NUMBER>9535400772501151409588531511454012693041857206046113283949847762202 is out of range
15112221349535400772501151409588531211454012693041857206046113283949847762202;

I think it is because I am using dart 2.0.0, try to change all the int to BigInt and other things but it did not work for me, I am new using dart.

Hey, thanks. I will take a look.

Hi, current version of library is not supporting 2.0, however it is open for patches, you can add one and create PR, thanks.


Sets an oghttp2 option in ClientHttp2Options.

Commit Message: Sets an oghttp2 option in ClientHttp2Options.
Additional Description:
Risk Level: low
Testing: ran unit and integration tests
Docs Changes:
Release Notes:
Platform Specific Features:
Runtime guard: existing envoy_reloadable_features_http2_use_oghttp2

/assign @alyssawilk


Auto-import completion should support string based requires

Right now it only supports Roblox-style requires. We should support string paths if we know we aren't in a roblox environment

Will wait for Luau's require-by-string support to complete before working on this

Also requesting this please 🙏

When this feature is implemented, ideally there should be a setting to always use an alias path instead of relative paths, or use relative paths within the same alias, and aliases for paths outside of the alias of the file. This could be difficult because aliases may or may not be mutually exclusive, or in other words a single file may be within multiple aliases.


Godot crashes on quit on Mac when not first exiting to Project Window (Godot Standard 3.1.2)

Godot version:
Standard 3.1.2
OS/device including version:
Using Godot on Mac OS 10.14.6
Issue description:
When pressing Command-Q (Quit) on the Mac after regular saving, the Godot app should quit, but instead goes into spin and eventually crashes. While this bug is non-lethal, and does not occur when first exiting to the Project Manager via Alt-Cmd-Q, it happens often, though not on a reliable basis.
The Mac OS problem Report reads:

Process:               Godot [43427]
Path:                  /Applications/Programming/Godot.app/Contents/MacOS/Godot
Identifier:            Godot
Version:               3.1.2 (3.1.2)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Godot [43427]
User ID:               503
Date/Time:             2020-01-16 12:48:01.849 -0500
OS Version:            Mac OS X 10.14.6 (18G1012)
Report Version:        12
Anonymous UUID:        D6FA67C1-4967-6769-D5D7-2052E64E39EB
Time Awake Since Boot: 1300000 seconds
System Integrity Protection: disabled
Crashed Thread:        0  Dispatch queue: com.apple.main-thread
Exception Type:        EXC_BAD_ACCESS (SIGABRT)
Exception Codes:       EXC_I386_GPFLT
Exception Note:        EXC_CORPSE_NOTIFY
Application Specific Information:
abort() called
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff6dcb62c6 __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff6dd71bf1 pthread_kill + 284
2   libsystem_c.dylib             	0x00007fff6dc206a6 abort + 127
3   org.godotengine.godot         	0x000000010eaddb00 handle_crash(int) + 1776
4   libsystem_platform.dylib      	0x00007fff6dd66b5d _sigtramp + 29
5   dyld                          	0x0000000113b39b76 dyld::fastBindLazySymbol(ImageLoader**, unsigned long) + 86
6   org.godotengine.godot         	0x0000000110d8c916 RefPtr::unref() + 54
7   org.godotengine.godot         	0x0000000110df6a72 Variant::clear() + 114
8   org.godotengine.godot         	0x0000000110cce8a6 HashMap<StringName, Variant, HashMapHasherDefault, HashMapComparatorDefault, (unsigned char)3, (unsigned char)8>::clear() + 86
9   org.godotengine.godot         	0x0000000110cc93f0 HashMap<StringName, HashMap<StringName, Variant, HashMapHasherDefault, HashMapComparatorDefault, (unsigned char)3, (unsigned char)8>, HashMapHasherDefault, HashMapComparatorDefault, (unsigned char)3, (unsigned char)8>::clear() + 80
10  org.godotengine.godot         	0x0000000110cc91cc ClassDB::cleanup() + 492
11  org.godotengine.godot         	0x0000000110d96bbe unregister_core_types() + 1230
12  org.godotengine.godot         	0x000000010eb13d62 Main::cleanup() + 914
13  org.godotengine.godot         	0x000000010eaeb240 main + 816
14  libdyld.dylib                 	0x00007fff6db7b3d5 start + 1

Steps to reproduce:
I just tried with an all empty project and it did NOT occur. However, using the file below I just tried immediately after opening Godot again, and it seems to be connected to the process of cleaning up references and saving while quitting.

Open up attached project,
Enter the script, change e.g. by adding and deleting a space
Immediately save, then immediately
press Cmd-Q

The app does crash upon quit, in this case it just opened a problem report with a slight alteration in the chrash thread:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff6dcb62c6 __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff6dd71bf1 pthread_kill + 284
2   libsystem_c.dylib             	0x00007fff6dc206a6 abort + 127
3   org.godotengine.godot         	0x00000001044eeb00 handle_crash(int) + 1776
4   libsystem_platform.dylib      	0x00007fff6dd66b5d _sigtramp + 29
5   libdyld.dylib                 	0x00007fff6db6732e dyld_stub_binder + 282
6   org.godotengine.godot         	0x000000010679d916 RefPtr::unref() + 54
7   org.godotengine.godot         	0x0000000106807a72 Variant::clear() + 114
8   org.godotengine.godot         	0x00000001066df8a6 HashMap<StringName, Variant, HashMapHasherDefault, HashMapComparatorDefault, (unsigned char)3, (unsigned char)8>::clear() + 86
9   org.godotengine.godot         	0x00000001066da3f0 HashMap<StringName, HashMap<StringName, Variant, HashMapHasherDefault, HashMapComparatorDefault, (unsigned char)3, (unsigned char)8>, HashMapHasherDefault, HashMapComparatorDefault, (unsigned char)3, (unsigned char)8>::clear() + 80
10  org.godotengine.godot         	0x00000001066da1cc ClassDB::cleanup() + 492
11  org.godotengine.godot         	0x00000001067a7bbe unregister_core_types() + 1230
12  org.godotengine.godot         	0x0000000104524d62 Main::cleanup() + 914
13  org.godotengine.godot         	0x00000001044fc240 main + 816
14  libdyld.dylib                 	0x00007fff6db7b3d5 start + 1

Minimal reproduction project:
PathFollow2D.zip

I tried several times with the included project and was not able to reproduce this crash.
macOS 10.14.6
Godot Engine v3.2.3.rc.mono.custom_build.a24e30abd
OpenGL ES 3.0 Renderer: AMD Radeon Pro 580X OpenGL Engine

Haven't had this crash since 3.2.1, so I think we can safely close this case.


Feature Request: Active conversion and synchronization of .gitignore and .tfignore

As git-tfs walks the changesets if it happens on the introduction or delta of .tfignore, it should add the content or delta of that file to .gitignore as part of the commit for that changeset in git.

We are trying to clean up old/stale issues. As this issue hasn't seen any updates (or progress with pull requests) in quite a while, the issue will be closed. In case further information is provided, we can revisit that and reopen the issue again.

Keep in mind that the .gitignore stuff was more or less revised in #1214


Setting consul_group fails deployment

Setting the consul_group variable to anything but "bin" fails.
This seems to be because the "consul_manage_group" variable is never set to true regardless of the value of consul_group. If this is intended behavior it doesn't say so in the docs, but I'm assuming it's not.

In the same vein since "consul_manage_group" is default to false, in some deployments root's primary group gets changed to "bin" (gid 2) which really messed up some things. I would recommend putting something in the readme or defaulting that to true.

Thanks for the heads up; I've changed the default value of consul_manage_group to true and pushed that to master so that it will be the default in the next release version.


Support custom error types

Hello :spock-hand: ! Does someone have any guidance/sample project on how to handle network/http errors with Store? Currently the network layer in our Android app takes care of catching exceptions, parsing error payloads and returning a custom monad class like Result<NetworkError, T>> . Looking at StoreReadResponse it seems that using Throwable or String is the only way to go. Thanks for your answers!

https://kotlinlang.slack.com/archives/C06007Z01HU/p1699457424194509

@digitalbuddha We would need to fix tests obviously but I wanted to get something up first for discussion. Adding a generic to StoreReadResponse and FetcherResult would introduce breaking changes I know we don't want. Thoughts?

@matt-ramotar thanks for bringing up implementation ideas so quickly. Would it be possible for the Custom error to accept any type instead of only Throwable? As an example, our network layer uses a sealed interface with no Throwable inheritance. Something like this
sealed interface NetworkError {
    data class StatusCodeError(val statusCode: Int, val error: CustomApiError?) : NetworkError()
    data class UnknownError(val throwable: Throwable) : NetworkError()
    data object NetworkUnavailableError : NetworkError()
}

@borsini Seems fine to me 👍🏽

Hello @matt-ramotar, I checked how this PR was doing and came up with an idea. I created this little draft PR to illustrate my thinking. What if, instead of having a sealed hierarchy, Store use only one generic Error type.
Let me know what you think 😄

Sorry to be slow @borsini, will try to get this merged by end of week

No worries @matt-ramotar this is open source 🙂


How is the different performance from  face-parsing.PyTorch?

Since there is no Qualitative and Quantitative showcases about the difference.

@cfanyyx , yes I did not include any of them. I tested it only on some number of samples.


Does not work with XUnit + ReSharper, keeps looking for the configuration file under the ReSharper folder

I did a quick PR with the proposed change, to use Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location) as base folder -
Unfortunately I don't have the time to debug it - please take a look if you can.

I have no issues with XUnit + ReSharper


Fix observable merge operation

The PR that was merged before for physical remove of the entries from the bucket works fine until it hits a spike of actions, so it looks to be failing to operate when there is a load of actions, this change is intended to fix this issue and increase the performance of the plugin under load.
Why this change?

There is an issue with Observable.merge(...) operation under load, it becomes too zealous of JVM resources and fails with a nasty stack trace, so I fixed it by rewriting that part of the code with a more appropriate one and tested under load this time, it performed as expected, the change is also written in a batching mutation approach.

Looks like I was using the internal sequence id in order to build the document key for the document that needs to be removed, it was a wrong approach as the sequence number is not equal to document sequence, so rewritten that part too to pass the correct document key to be removed, verified this under some load tests with Akka 2.5.3, the entries number in the bucket are kept according to the configuration, all the unnecessary entries are removed.

Updated Akka to 2.5.3 and couchbase java-client to 2.4.7 in order to have a better compatibility and performance with couchbase 4.6+

If this changes are accepted please release a new version of the plugin

Thank you very much. There are some problems running the tests.
akka.persistence.couchbase.snapshot.CouchbaseSnapshotStoreSpec
akka.persistence.couchbase.journal.CouchbaseJournalSpec
akka.persistence.couchbase.replay.CouchbaseReplaySpec

Can you have a look at these problems?

Yes, I made sure the test were passing, will have a look and fix it


Allocate proper number of texture coordinates for cylinder

Allocate proper number of texture coordinates for cylinder

Looks good to me. Will merge in the afternoon.

Good catch.  +1

Perhaps ahould double-check sphere and cube as well.

@thomasflynn The other two cases are fine.


Store records by id

Hey,
Very nice library.
It is very handy and avoids a lot of boilerplate code.
But IMHO records should be stored by id rather than in an array.
The current design makes searching records and maintaining sub-lists very inefficient.
Rather than
[
   {
      id:1,
      name:"Hello"
   },
   {
      id:2,
      name:"World"
   }
]

It would be better to have:
{
   1: {
      id:1,
      name:"Hello"
   },
   2: {
      id:2,
      name:"World"
   }
}

It still allows to iterate over the collection but also to quickly find one or more particular records.
Have a look at https://github.com/paularmstrong/normalizr
N.

Hi, thanks for your input, see some discussion about this here https://github.com/Versent/redux-crud/issues/15 the main reason for having arrays is preserving the order or records as they come from the server

@sporto I also need my store in map-form and I'm currently playing around with creating a wrapper around redux-crud reducers that converts state into an array on the way in and back to a map on the way out and it's crazy simple. Seems to work pretty well, any thoughts on this idea? Would you accept a PR to add a "store as map" setting like this?

@mattvague 	thanks for the comment, I'm concerned with the performance of this. Converting from map to array then back to map seems like a lot of overhead. Works but I think it can go against the purpose of using a map, as a map helps to have fast writes into the store.
Let me think about what are the implications of having a baked in map store.

I'm concerned with the performance of this. Converting from map to array then back to map seems like a lot of overhead

Yeah no, it is not super performant. I started off by forking redux-crud and playing around with doing it the "right way" but it definitely seemed (as you've said elsewhere) non-trivia and I really needed this to work now. The app I'm working on doesn't deal with huge data sets so it seems to be ok but would obviously be great to have it built in.

Let me think about what are the implications of having a baked in map store.

Cool. Let me know if you can see a reasonable path to making this happen and whether I can help.
Cheers

I have started a branch for this
https://github.com/Versent/redux-crud/pull/38
It will take me a while as I can put very limited time on this. Any help would be appreciated.

This is done in v3


Allow passing of axios_config

Description
This PR is fairly simple. It just gives you the ability to pass extra axios_config in the options parameter. The
It Fixes https://github.com/LuanRT/google-this/issues/21 by allowing you to pass proxy servers.
import SocksProxyAgent from 'socks-proxy-agent';

const httpsAgent = new SocksProxyAgent.SocksProxyAgent(...);
const options = {
  page: 0,
  safe: false,
  additional_params: {
    hl: 'en'
  },
  axios_config: {
    timeout: 15000,
    proxy: false,
    httpsAgent: httpsAgent
  }
}

const response = await google.search('how do you scrape google results?', options);

It should support standard HTTPS proxies, too. I just generally use Socks5.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

If this looks good, I'll finish other items on the checklist. Adding tests and documentation. It's a minor change though.

Sweet! And yup I agree, you don't have to add tests for this particular change. Left a review.
Thanks again!


Deep linking

How would you deep link in this setup? I have tried to add deep link for the profile fragment similar to the basic navigation sample from jetpack repo, to see what happens and it basically just starts to the login page. I also cannot catch this intent in the MainActivity to navigate manually

Supposedly there is a <deep-link tag but I'm not sure how to get it to work, I've read the documentation multiple times and it's super inconclusive. I think that's only for createPendingIntent(), too.
I presume the way to do it would be to use popUpTo at the root with an action in the root NavGraph. 🤔

I have managed to make deep linking work, by removing splash_graph as a start destination and by using splash_fragment. The only problem is that when you jump deeper to some screen and start to go up it really adds start destination for every nested graph on the way and splash as a root one which is problematic.

The only problem is that when you jump deeper to some screen and start to go up it really adds start destination for every nested graph on the way

That sounds like it's by design. The alternate variant https://github.com/Zhuinden/simple-stack-ftue-sample makes this easy, but that's clearly not Jetpack Nav.


[BUG] Path to document is wrong in comment

Describe the bug
The comment made on the PR includes a link to the CLA, But this was empty.
This is however on a private repo (for now) so that could be the reason.
To Reproduce
config:
name: "CLA Assistant"
on:
  issue_comment:
    types: [created]
  pull_request_target:
    types: [opened, closed, synchronize]

jobs:
  CLAssistant:
    runs-on: ubuntu-latest
    steps:
      - name: "CLA Assistant"
        if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target'
        # Alpha Release
        uses<EMAIL_ADDRESS>        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          # the below token should have repo scope and must be manually added by you in the repository's secret
          PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_ACCESS_TOKEN }}
        with:
          path-to-signatures: "signatures/version1/cla.json"
          path-to-document: "https://github.com/<hidden>/core/blob/main/CLA.md"
          branch: "main"
          allowlist: bot*
          create-file-commit-message: 'chore(docs): Creating file for storing CLA Signatures'
          signed-commit-message: 'chore: $contributorName has signed the CLA in #$pullRequestNo'

Expected behavior
The link included in the commit message

hi @cskiwi, Have you tried on a Public repository ? :)

hi @cskiwi, Have you tried on a Public repository ? :)


feat(components): adding code snippet component

Description
Adding Code snippet web component to the web component library
Figma (needs td login)
https://www.figma.com/file/4qn8W9GCuhyNxEMBhMeahz/Code-samples?node-id=0%3A1&t=Rs15lTIuTGzTzrxQ-1
What's included?

Adding code snippet using highlight.js
Supports the common 34 languages
Uses atom one light and dark theme
Supports adding a title in the header and a slot for action

Test Steps

[ ] npx run components:storybook
[ ] then wait for the browser window open
[ ] finally navigate to the code snipppets story

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

Screenshots or link to StackBlitz/Plunker

@owilliams320 The default theme should match that of the parent app, but allow you to use the icon button to reverse it. So in this demo it should start as dark themed.

@owilliams320 The default theme should match that of the parent app, but allow you to use the icon button to reverse it. So in this demo it should start as dark themed.

For this i added the code snippet tokens to the to tokens package so we can use as variables to switch between like the rest of the system.

:tada: This PR is included in version 4.13.0 :tada:
The release is available on:

v4.13.0
GitHub release

Your semantic-release bot :package::rocket:


Fix a forever loop on CMS modules if an error occurs

HH-326.

Move the reusable Apollo error handler init to new hook

The Apollo error reducer should not create a new state object
when nothing changes, or otherwise it will be dealt as a new
state in the component / provider as well.

NOTE: There is still a reloading issue in pages that uses CMS
modules like event carousels, but it won't lead to a forever loop anymore. Because of a reload the error toaster will just appear again.

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr470.dev.hel.ninja :rocket::rocket::rocket:

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr470.dev.hel.ninja :rocket::rocket::rocket:

Sports-Helsinki branch is deployed to platta: https://liikunta-pr470.dev.hel.ninja :rocket::rocket::rocket:

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr470.dev.hel.ninja :rocket::rocket::rocket:

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr470.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://tapahtumat-pr470.dev.hel.ninja :laughing::tada::tada::tada:


Manifestwork enhancement: query workload status which created by Manifestwork

End user wants to run a Job (e.g. tf job) in OCM.
End user created a manifestwork in one managed cluster namespace.
Managed cluster pull the manifestwork and run on the job.
End user wants to know what is the status of the Job (e.g. tf job).

OCM should provide a way to let end user know the status of the real workload (tf job in above scenario).

@zychina basically i can think of two approaches to reflect the real-time state of resources in managedcluster to the hub cluster:

having a gateway/proxy server so that k8s clients can access the apiservers imperatively, ref: https://github.com/open-cluster-management-io/community/issues/73 which is previously discussed in the meeting to automate the installation of https://github.com/kubernetes-sigs/apiserver-network-proxy. by the proxy, the hub cluster will be able to access the target kube-apiserver through the tunnel w/o having any concrete per-cluster credentials.

have a new resource projection/mapping api which basically list-watches the target resources and reflect the latest status in near real-time.

we will be seeing the first approach landing as a new sub-project really soon in month-ish, or do you have any alternatives in mind?

Yes, I think the first approach has more flexibility if hub cluster could access managedcluster to query resource status, as for some workload (tf job), there will have some other resource belong to it, like pod and service, some advanced user may want to access pod/service resource to do debug work.
Additionally, what is the authorization design for the proxy ? For example in hub cluster, user(controller or real person user) uses a service account or token to access hub cluster api server, then api server forward the request to proxy server. Is there any authorization running on proxy server ? when request proxy to proxy client, then the request will use proxy client service account to forward request to managedcluster api server. What kind of permission for the proxy client service account ? Only query permission ?
The proxy is good to bring convenience, but is also bring some security risk. We need to design the authorization carefully. Like:

leverage user's permission in hub cluster, proxy server do authorization on hub cluster before forward the request to managedcluster.
only allow the query action to be forwarded.

I think it is becoming an important requirement. I will create a doc to collect the use cases and some ideas at first
/assign @qiujian16

/kind feature

So is this work still planned?

yes, this is finished with PR https://github.com/open-cluster-management-io/work/pull/107

/close


Excessive Memory Usage when decoding using MediaSDK

MediaSDK requires >500 MB of memory when decoding h264 clips.  For example, sample_decode h264 -i input.h264 -hw -vaapi will require >500 MBs of memory.  Centos doesn't seem to show this issue requiring only ~60 MB's of memory/stream.  Not clear why Centos is requiring less than Ubuntu 18.

Can you please describe:

CentOS version
kernel version
MSDK/UMD/libgmm versions

and attach a video clip
?

Release builds use the expected amount of memory, roughly 50 MB for 1080p decode.  Release-internal and debug builds use roughly 10x.  Since release builds use the expected amount of memory, this is not an issue.

Thank you for confirmation!


service Package

Service Package Request

### Tasks
- [x] cd azure-sdk-for-go-samples/sdk/resourcemanager/network/virtualnetwork go mod tidy go run main.go

### Tasks
- [ ] https://github.com/Azure/azure-sdk-for-go/pull/23073
- [ ] https://github.com/Azure/azure-sdk-for-go/issues/23050
- [ ] https://github.com/Azure/azure-sdk-for-go/issues/23155

I'm closing this because it looks like spam. If you encountered a problem using the SDK, please describe it.


Google Sign-in doesn't work

Google doesn't allow signing in using application embedded authentication, gives an error "browser cannot be trusted"

I have same issue

I have same issue
"This browser or app may not be secure"

+1

Google sign in not allowing- not secure. Ubuntu 19.10

This browser or app may not be secure. Learn more

Try using a different browser. If you’re already using a supported browser, you can refresh your screen and try again to sign in.

+1


Setup dc_relay_domains not only for simple relays

Good morning!
I need to configure dc_relay_domains with SES for work with k8s.

Hi @zzzsochi, thanks a bunch!

Can you update the image on docker hub? Maybe set up automatic builds?

Very strange as we already have automated builds on master :-S
Anyhow, just triggered a new manual build, you should be able to pull a new latest soon.

Thanks!


Add a simple maintenance notice

I googled around a little and also talked to @eelucio about a maintenance notice for freva. The people on the internet suggested temporarily changing the web server config if the system is not usable.
So my thinking was to add these two files to the static folders und update the web server config aliasing the two files in the config. Something like this:
<VirtualHost *:443>
   ProxyPass /static/ !
    ProxyPass / http://${FREVA_HOST}:8000/
    ProxyPassReverse / http://${FREVA_HOST}:8000/
    RequestHeader set X-Forwarded-Proto 'https' env=HTTPS
    SSLEngine on
    Alias /static /srv/static/
    Alias /robots.txt /srv/static/robots.txt
    Alias /favicon.ico /srv/static/favicon.ico
    Alias /under_construction.gif /srv/static/under_construction.gif
    Alias /index.html /srv/static/outoforder.html

If a maintenance notice would be needed we then could simply comment the two lines:
#ProxyPass /static/ !
#ProxyPass / http://${FREVA_HOST}:8000/

Since the web config is saved outside the docker container in /opt/freva/<project>/<project>_web/ it would be kinda straight forward to turn the notice one an of.

I think that is a practical and easy way to do it.
maybe @Karinon  has some insight if this has some flaws, tho.
LGTM

I guess LGTM for the more severe cases.
For the less severe cases we also have a new messaging-table (configurable via admin-interface) to let users know about events without disabling everything. I guess this could be more polished in order to disable subpages (like starting runs etc). I think in the most cases it is not necessary to turn off the whole website.


Ability to disable log spam

We are currently working on a solution with several dozen projects, where our logs are bloated with the following repetitive lines during the build process.
Total time:                                                                         4413ms
Total files:                                                                         145
Files that were not formatted:                                                         0
Total time:                                                                          507ms
Total files:                                                                           0
Files that were not formatted:                                                         0

Can these be disabled?

There isn't currently a way to adjust the logging level but I can look at adding a way to disable/configure the level of logging.
One option for now would be to switch to running csharpier using the CLI outside of the build process. That would also cut down on the time it takes CSharpier to run, there is some initial overhead starting up the process, running it against the full solution you only get that overhead once.


Add configuration to retain a Lease in LifecycleAwareSessionManager after Vault server failures

Set-up

Spring Boot 2.1.2 application.
Spring Cloud Vault starter: spring-cloud-starter-vault-config

Given this code to configure Vault Authentication
@Configuration
public class VaultAuthentication extends AbstractVaultConfiguration {

    @Override
    public VaultEndpoint vaultEndpoint() {
        return VaultEndpoint.from("[some-vault-endpoint]");
    }

    @Override
    public ClientAuthentication clientAuthentication() {
        KubernetesAuthenticationOptions options = KubernetesAuthenticationOptions.builder()
                // not relevant
                .build();
        return new KubernetesAuthentication(options, restOperations());
    }

    @Bean
    @Override
    public SessionManager sessionManager() {
        ClientAuthentication clientAuthentication = clientAuthentication();
        Assert.notNull(clientAuthentication, "ClientAuthentication must not be null");
        int refreshTimeout = 30; // Overrides default
        LifecycleAwareSessionManagerSupport.FixedTimeoutRefreshTrigger refreshTrigger = new LifecycleAwareSessionManagerSupport.FixedTimeoutRefreshTrigger(
                refreshTimeout, TimeUnit.SECONDS);
        return new LifecycleAwareSessionManager(clientAuthentication, threadPoolTaskScheduler(), restOperations(), refreshTrigger);
    }
}

Scenario

The vault server goes down for a while, say 30 minutes.

Outcome

Token renewal process in LifecycleAwareSessionManager fails. Cannot renew token message is output and token is set to Optional.empty() (see here).
The sessionManager bean never tries again to renew the token. It doesn't invoke itself the getSessionToken() method so it doesn't initiate again the process to get a new, fresh token. Therefore, sessionManager remains in an invalid state indefinitely.
The vault server becomes available again and revokes all existing secrets.
The service tries to connect to services using Vault (e.g. Cassandra) but the access is denied due to invalid permissions.

Expected Outcome

LifecycleAwareSessionManager tries to re-login indefinitely, which makes it self-healing, and also as per this message.
When Vault server comes back, the service performs a new login and it starts working again.

A bit of analysis
I think this behavior might be caused by the combination of:

This line of codetoken.ifPresent(tokenWrapper -> getTaskScheduler().schedule(task, createTrigger(tokenWrapper)));. It does not include an else scenario to trigger a new login.

Not having more interactions with the Vault server after the service has booted up and set up everything related to the Vault. Due to this, the VaultTemplate's interceptor (this one) does not restart the login process and the subsequent token renewal task.

Let me know if I'm misunderstanding the whole flow and I should actually call somewhere getSessionToken() myself after detecting this situation. But, in that case, where do you recommend to implement this logic?
Thanks,
Moises

Thanks for your detailed report. I currently fail to understand where the blind hole is.
The purpose of LifecycleAwareSessionManager is to make sure that a component, that wants to interact with Vault obtains a valid session token and to not perform a login for each getSessionToken() but buffer these requests.
The active component in LifecycleAwareSessionManager is to keep a token alive.
I struggle currently with understanding:

The vault server becomes available again and revokes all existing secrets.
The service tries to connect to services using Vault (e.g. Cassandra) but the access is denied due to invalid permissions.

When Vault comes back up, it is natural to revoke secrets because we weren't able to renew these. Please help me understand how Spring Vault could prevent this. I currently do not see anything that we could do here.

access is denied due to invalid permissions

Is this the consequence of the expired session token?
Please note, that when your Vault server is down, that SecretLeaseContainer is also no longer able to renew leases. Any I/O failures during renewal stop Lease renewal.
Lease renewal happens, in general, a couple of seconds before the lease expires. If Vault goes down then the expiry time is exceeded and Vault again revokes leases by the time it is back up again.

Thanks for the quick response.
To keep it simple: how can I know from within the application that the lease renewal failed and something went wrong so I can (try to) re-login to the Vault? Should I use a listener with SecretLeaseContainer?
Right now, LifecycleAwareSessionManager doesn't notify directly in any way that it couldn't renew the lease. The Vault just does its part indeed: revokes secrets and, as a consequence, access is denied. The problem is that, from the application side, this should be known as soon as possible to react to that and perform any needed operation.

You can register your own listener via SecretLeaseContainer.addErrorListener(…)

so I can (try to) re-login to the Vault

What is the point of performing a re-login? You will get a new session token.
SecretLeaseContainer does the same already when attempting to renew a lease.

You can register your own listener via SecretLeaseContainer.addErrorListener(…)

I see now. What happened is that, for some reason, I missed that part of the docs and I implemented the code that read secrets in a different way:
final VaultAuthentication auth;
// ...
auth.vaultTemplate().read(secretsPath, MySecretsClass.class);

And, in this case, I fully depend on LifecycleAwareSessionManager's scheduled task for token renewal. Funny thing is that it works perfectly as long as you don't rotate secrets and connection works fine.
So now I know how I could make it work, thanks for that. And I think I understood why LifecycleAwareSessionManager does a "best-effort" token renewal and stops renewing it without having support for listeners: VaultTemplate is intended to be used for one-shot Vault operations, not for retrieving secrets and keeping the lease. Just correct me if I'm wrong.

Thanks for your response.
On a related note: You could integrate with Spring Retry to catch network hiccups that might occur at times by overriding VaultTemplate.doWithSession(…) but that is entirely application-specific regarding their needs.

One extra question, since I'm still experiencing issues related to this and I think I'm still missing something in terms of how to use Spring Vault in my specific use case.
To add some extra context, I'm using Periodic Tokens in Vault: https://www.vaultproject.io/docs/concepts/tokens.html#periodic-tokens
This means, according to the docs:

Therefore, as long as a system is actively renewing this token -- in other words, as long as the system is alive -- the system is allowed to keep using the token and any associated leases.

My Cassandra secrets, no matter if I use now the SecretLeaseContainer, are an associated lease for Vault since I got them using the Authentication token. This means the secrets will be revoked if I fail to renew the lease for the periodic Vault authentication token. As additional info, I'm using a relatively long TTL for the Cassandra secrets (longer than the TTL for the Authentication token).
Therefore, what happens now is that when LifecycleAwareSessionManager fails to renew the Vault token lease for whatever reason (for instance, Vault is unreachable for 10 minutes), secrets are revoked and the application doesn't have a way to detect this.
So, what I'm actually missing is a listener approach for LifecycleAwareSessionManager similar to the one inSecretLeaseContainer, because the app needs to know that the token could not be renewed and act upon that even before the next secret lease renewal attempt happens (which is expected to fail anyway).
Do you recommend a different way to detect this? I couldn't find it in docs.

There are currently no listeners/events available in LifecycleAwareSessionManager. Can you file a separate ticket to add events to the session manager? We had a PR once but that didn't really go in the right direction.
Let's revisit how renewal works. For both, login tokens and leases, we run renewal just before the token expires. With this strategy, if renewal fails (Vault server is down), it's almost guaranteed that when Vault comes up again, tokens will expire.
If we would switch renewal to a much earlier time (e.g. renewal after 50% of the TTL is reached), we would add a security buffer. If renewal fails, this isn't a problem expecting that Vault will come back up before reaching 100% of the TTL to expire. We would need to make sure to re-attempt token/lease renewal.

I reopened the ticket since during the discussion the actual goal of this one changed

Thanks! I created https://github.com/spring-projects/spring-vault/issues/431.

Authentication events are now in place. The only missing bit to address this issue is controlling over whether the LoginToken should be removed on renewal failure. Currently, all renewal failures cause the token to be reset. We could introduce a control flag whether the token should be retained after a renewal failure and expose the renew() method. This way, an application could listen for renewal failures (LoginTokenRenewalFailedEvent) and call the renew() method after a certain time.
With sufficient TTL, the token should be kept alive and we're closing that loophole.
What do you think?

Great, thanks! I'll give it a try and provide some feedback.

We've introduced now means to configure Lease retention on renewal failures. Leases are dropped by default but now you can configure the session managers and SecretLeaseContainer to retain these for manual retries.

Could you please let me know how this issue got resolved ?
relogin to vault if vault server goes down for some time and spring cloud is not able to renew lease.


Trashbin Restore does not work

Delete a file and try to restore that file from the trasibn we get error.
curl 'http://<IP_ADDRESS>:9140/remote.php/dav/trash-bin/TU1/test.html.d1585113012' -X MOVE -H 'Destination: http://<IP_ADDRESS>:9140/remote.php/dav/files/TU1/test.html' -u tu1:1234 -v

...
< HTTP/1.1 405 Method Not Allowed
...

cc @IljaN same as in https://github.com/owncloud/ocis/issues/1307

cc @IljaN same as in https://github.com/owncloud/ocis/issues/1307

It works now.


lxatac-core-image-base: Apply Some Cleanups

This is a first step into reducing the quite long and very explicit IMAGE_INSTALL list by oe-core default mechanisms like IMAGE_FEATURES and feature-controlled packagegroups.

@ejoerns please rebase to solve the conflict in tacos.conf.


Unique check request

add a new refresh button to the check-details view of a client
it forces a check request for that check on that host
it triggers a sensu-api /request with {check: "checkname", dc: "sensu", subscribers: ["client:clientname"]}
tested on uchiwa 0.25.3
fixes: https://github.com/sensu/uchiwa/issues/639

Awesome, thank you very much for this pull request!


Fix CODEOWNERS

After a discussion on the Tweag slack, this (explicitly listing code owners) seems to be the most reasonable option for now. The Tweag engineering org didn't work as code owners (https://github.com/tweag/chainsail/pull/436#issuecomment-1449582526) and would be too broad anyways.

Auto-approving and merging this, as this agreement has been reached among Tweag engineers and this allows merging of other PRs without having to override branch protection.


[BUG] FileNotFoundError when apply Categorify after JoinExternal

Bug description
When I try to use the Categorify() operator on a column after a JoinExternal(), I have the following kind of error:
FileNotFoundError: [Errno 2] No such file or directory: '~/data/categories/unique.XXXXX.parquet'
Expected behavior
Save file unique values of categorified column, like the ones done before the JoinExternal operation.
Environment details

Merlin version: 23.8.0
Platform: macOS
Python version: 3.11.6
Tensorflow version (GPU?): 2.12.1 CPU

@PaulSteffen-betclic can you pls send us a toy repro example? thanks.


fix(bh): exception string being freed during throw

The const char * thrown here is obtained from a std::string and is subject to being freed while the exception is being thrown.
It seems like all other exceptions thrown in the repo are of std::exception class, either from standard exception classes like std::runtime_error and std::range_error, or custom subclass C.*Error, that can be shown with
  grep -RHn 'throw ' src inc TestHarness/ \
  | grep -v 'C.*Err' | grep -v 'std::runtime_error'

Although given this fact, the exception thrown here is caught early at CBrokerageHouse::Run* methods, e.g. line 856 of BrokerageHouse.cpp simply logging a text saying TR EXCEPTION, and it might be making too much changes to apply for this simple improvement if consistency of exception class is demanded.
https://github.com/osdldbt/dbt5/blob/5575431ad9826c532a466191239338c635002b0f/src/BrokerageHouse/BrokerageHouse.cpp#L856

Merged. e1ce4a7ad7b9a38e9d5029570bb1209c2a7907fc


Fix segfault on zero-length slice assignment on memoryview

As outlined in #6227 — we have experienced an issue in production where attempting to write a folly:IOBuf with zero-length backing buffers is triggering a SIGSEGV.
The specific issue actual has to do with how memoryview attempts to use scalar assignment instead of slice assignment in the case where the source buffer (in this case, an empty slice) has len == 0. By fixing the fork to properly use slice assignment, we avoid the SIGSEGV when we string format the view format (which is NULL).
This PR also adds two additional tests for writing either a single byte or an empty slice to a memoryview.
Tested via: python runtests.py memslice -vv (which includes the two new tests)
fixes #6227

Thanks for taking a look! Applied suggestions :)

Seems like the test changes broke the tests due to TypeError: an integer is required — I refactored the tests via the cdef helper pattern used by other tests in this file, and tests seem to be working again

I don't think this is the right fix. Here's a test that fails for me and succeeds if I make your change in MemoryView.pyx:
diff --git a/tests/memoryview/memoryview.pyx b/tests/memoryview/memoryview.pyx
index de5fa4f21..5f95559c0 100644
--- a/tests/memoryview/memoryview.pyx
+++ b/tests/memoryview/memoryview.pyx
@@ -1081,6 +1081,22 @@ def test_dtype_object_scalar_assignment():
     assert m[0] == m[4] == m[-1] == 3

+def test_assign_to_slice(obj, start, end):
+    """
+    >>> test_assign_to_slice(b'abc', 0, 3)
+    b'abc'
+    >>> test_assign_to_slice(b'a', 0, 1)
+    b'a'
+    >>> test_assign_to_slice(b'', 0, 0)
+    b''
+    >>> test_assign_to_slice(b'', 5, 5)
+    b''
+    """
+    view = memoryview(bytearray(len(obj)), PyBUF_C_CONTIGUOUS)
+    view[start:end] = obj[start:end]
+    return bytes(view)
+
+
 def test_assignment_in_conditional_expression(bint left):
     """
     >>> test_assignment_in_conditional_expression(True)
@@ -1310,5 +1326,5 @@ def test_untyped_index(i):

 _PERFORMANCE_HINTS = """
 243:9: Use boundscheck(False) for faster access
-1313:21: Index should be typed for more efficient access
+1325:21: Index should be typed for more efficient access
 """

Sorry for the wrong changes to your test. I got confused by the fact that you put it into memslice.pyx rather than memoryview.pyx, but looking at your original bug report, it needs to go there since it's a test for the actual memoryview Python type.

Good callout, my "fixed" tests didn't actually repro the segfault.
I thought to put the test in memoryview.pyx but got confused by the "slice" terminology 😅 — thanks for providing an updated test! I've also verified that this new test works with the fix and segfaults without it.

Thanks.
Does anyone care about a backport? Seems appropriate to me. The test won't apply trivially to the 3.0.x branch because the doctest output was written for Python 3.x. And performance hints weren't there yet, so that part needs to be removed.


[api-docs] feat(interactions/slash_commands): add note about resolved member and…

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/4692b2adc671c651fbba88a5d050ab0ef379083f

ncn


Minify Production code

webpack command updated to allow for more RAM. Otherwise build crashes.

Some stats:
courses bundle from 6mb -> 417 kb.
editor bundle from 34.1mb -> 903kb.
Build time increased for production build significantly.
Dev build: 61 seconds.
Prod build: 200 seconds.

Looks good, ship it!


ENV2023-03-01 new SMTYP codes

https://vocab.ices.dk/?ref=152
From requester:
Dear colleagues,
we need two new entries for SMTYP because we use glass bottles at BSH do determine organic pollutant concentration.
We use two different types: Glass bottles with 10L and with 100L content.
To refer properly we need to be able to have both of them available in SMTYP.
We would recomment the following codes:
WASGFL10         Glass water sampler with 10L content
WASGFL100       Glass water sampler with 100L content
Thanks in advance and best regards,
Susanne

consult L22 before creating the codes

@Osanna123 create codes :)


Upload file using protractor

Hi @juliemr ,
Need some info, i need to upload a file using protractor below is the screenshot of the app
Now when i click on the Select File it shows browse button, can i automate the fileupload window of browser. If yes can you provide me with  example.

Hoping for reply.
Thanks,
Naresh Kumar

Hi there!
Your question is better suited for StackOverflow or Gitter. There is already an answer on StackOverflow for your question. If that does not resolve your problem, please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!

Hi,
i have checked in StackOverflow but couldnot figure it out. so posted over her...
can you provide me with some links... that would be helpful.


the train data download fail

https://www.robots.ox.ac.uk/~vgg/research/FontAdaptor20/FontSynth_v1.1.tar
You don't have permission to access this resource.
The train data can't download ,so is it others download urls ?

Hi, thank you for pointing it out.
I have reset the permission, Could you please try again?
Sorry for the inconvenience.


action-used-by-link doesn't work: selectHas(...) is undefined

Description
The action-used-by-link feature isn't working. From a quick look it seems like the selectHas call isn't finding anything.
This is the stacktrace:
init@.../refined-github.js:9634:37
runFeature@.../refined-github.js:3955:26
setupPageLoad@.../refined-github.js:3961:40
add/<@.../refined-github.js:3986:35
async*add@.../refined-github.js:3987:11
async*@.../refined-github.js:9631:20
@.../refined-github.js:11575:5
@.../refined-github.js:11576:3

How to replicate the issue
https://github.com/marketplace/actions/urlchecker-action
Extension version
22.7.20
Browser(s) used
Mozilla Firefox 102.0.1

I get a different error:
❌ action-used-by-link
refined-github.js:3897 📕 22.7.20 → TypeError: Cannot read properties of undefined (reading 'pathname')
    at init (refined-github.js:9634:67)
    at runFeature (refined-github.js:3955:26)
    at setupPageLoad (refined-github.js:3961:40)
    at refined-github.js:3986:35

Same error, different browser

Hmm, I get a different stacktrace depending on whether I normally load the page (like from clicking the link above) or if I refresh the page (where I get the one on the first comment), though the error message is still TypeError: selectHas(...) is undefined.
If I just load the page I get one quite similar to yours:
22.7.20 → TypeError: selectHas(...) is undefined
    init action-used-by-link.tsx:10
    runFeature index.tsx:207
    setupPageLoad index.tsx:223
    add index.tsx:302

I don't think it really matters though, the error seems to be the same, just worded differently.

Fixed https://github.com/refined-github/refined-github/pull/5867


journal settings update bug

I can update but it does not show what is updated.
https://drive.google.com/file/d/0B7yJMr_wSCAYRHZJeWY0cy1aUFU/view

Problem detected and fixed permanently with this commit
https://github.com/okulbilisim/ojs/commit/f5f2093a1355591a9f108ec4794d366d6fc7c4b9


How to export an opaque pointer/handle to JS?

Is it possible to pass a handle/opaque pointer to a rust struct to javascript, without exposing its
content?
Right now I've tried the following:
#[wasm_bindgen]
pub struct WrappedEnv {
  // I don't want Javascript to have access to this
  env: Box<Env> // Env not marked with wasm_bindgen
}

#[wasm_bindgen]
pub fn init_unita() -> Box<RefCell<unita::env::Env>> {
  panic!("TODO")
}

But it doesn't work. I guess I can do it by manually like in the manual but I'd like to avoid it if possible

Thanks for the report! Do you want to expose WrappedEnv to JS? If you do that and it doesn't have any #[wasm_bindgen] annotated impl blocks or public fields it should only have a free function for JS to free it when necessary. Does that work for your use case?

I think that would work, I also give what I ended up with as a (I hope) temporary workaround:
fn with_env<F, T>(env_ref: u32, f: &mut F) -> T
  where F : FnMut(&mut Env) -> T {
    let me = env_ref as *mut WasmRefCell<Env>;
    wasm_bindgen::__rt::assert_not_null(me);
    unsafe { f(&mut (*me).borrow_mut()) }
}

#[wasm_bindgen]
pub fn init_env() -> u32 {
  let ret = inetrpreter::setup_default_prelude();
  Box::into_raw(Box::new(WasmRefCell::new(ret))) as u32
}

#[wasm_bindgen]
pub fn eval_expr(env_ref: u32, s: &str) -> String {
  with_env(env_ref, &mut |env: &mut Env| -> Result<String, std::io::Error> {
    // ...
    // do stuff with env
  }// unwrap and more
}

Hm does this work?
#[wasm_bindgen]
pub struct MyData(<return type of setup_default_prelude here>);

#[wasm_bindgen]
pub fn init_env() -> MyData {
  MyData(inetrpreter::setup_default_prelude())
}

#[wasm_bindgen]
pub fn eval_expr(data: &mut MyData, s: &str) -> String {
    // do stuff with data.0 == env
}

It works really well.
Thank you very much


feat: add info panel to app

closes https://github.com/zakodium-oss/analysis-ui-components/issues/253

Codecov Report
Base: 91.73% // Head: 91.73% // No change to project coverage :thumbsup:

Coverage data is based on head (ee53eaf) compared to base (43adbe8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   91.73%   91.73%
=======================================
  Files           9        9
  Lines         593      593
  Branches      100      100
=======================================
  Hits          544      544
  Misses         49       49

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Functionality looks ok to me. However we need to discuss what will happen if many measurements are selected ?
https://github.com/zakodium-oss/analysis-ui-components/pull/286
I guess in this case we should for now display a message like 'Information is only available when one (and only one) measurement is selected'
The same message should be displayed if no measurement is selected.


Issue with frame allocator code

In function src/mm/frame.c/read_multiboot_mem_map_entry(), init_bitmap isn't working properly and causing triple-faults on qemu! Also a workaround has been made but that causes corruption to VGA and crashes QEMU with some tss_cpu errors. Fix it ASAP!!

This issue was solved by this commit with a minor warning.


Sample App Initial Commit

Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist

[ ] The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
[ ] I have performed end-to-end test locally.
[ ] New and existing unit tests pass locally with my changes
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I used clear names for everything
[ ] I have performed a self-review of my own code

same here asserts are not for 2 parameters, add equal checks in first parameter itself


Add ability to return errors from custom functions.

Also provide initial documentation on using and providing functions.

Awesome Work! Nice with tests! But why current method is not okay? You can just panic in custom func.

Awesome Work! Nice with tests! But why current method is not okay? You can just panic in custom func.

While true that panic's will also return errors it is not always useful. For example there could be cases when "panic" is forbidden by style-guide. Also checking for returned error message instead of it's type or behavior is not the best approach either.
I learned that it is useful to re-use already existing functions in the environment, but in some(if not most) cases such functions/methods can also return error to specify is something went wrong. Leaving out the error in such case could lead to unpredictable results of expression evaluation.
It will also be possible to check if the error is from compiling or running stage(like types mismatch) or from the functions that are being called in expression. In such case if error is *file.Error - then it is from compiling/runtime, while everything else is from functions from environment.
And most useful feature would be to preserve the context of the error, such as its type. Consider this example:
// Error1 and 2 are types like below, which also implement `error` interface
// type Error1 struct { Message string, Val interface{} }

env := map[string]interface{}{
  "err": func(i interface{}) (int, error) {
    switch typed := i.(type) {
    case int:
      return typed, nil
    case float64:
      return 0, Error1{Message: "value is float", Val: typed}
    default:
      return 0, Error2{Message: "value not numeric", Val: i}
    }
  },
}

program, _ := expr.Compile(`err(11.1)`)
res, err := expr.Run(program, env)
// err will be Error1, preserved from the return statement

While it is simple and crude example, it shows that this approach can be used to get error type and even capture context in a type that implements error interface.

While true that panic's will also return errors it is not always useful. For example there could be cases when "panic" is forbidden by style-guide. Also checking for returned error message instead of it's type or behavior is not the best approach either.
I learned that it is useful to re-use already existing functions in the environment, but in some(if not most) cases such functions/methods can also return error to specify is something went wrong. Leaving out the error in such case could lead to unpredictable results of expression evaluation.
It will also be possible to check if the error is from compiling or running stage(like types mismatch) or from the functions that are being called in expression. In such case if error is *file.Error - then it is from compiling/runtime, while everything else is from functions from environment.
And most useful feature would be to preserve the context of the error, such as its type. Consider this example:
// Error1 and 2 are types like below, which also implement `error` interface
// type Error1 struct { Message string, Val interface{} }

env := map[string]interface{}{
  "err": func(i interface{}) (int, error) {
    switch typed := i.(type) {
    case int:
      return typed, nil
    case float64:
      return 0, Error1{Message: "value is float", Val: typed}
    default:
      return 0, Error2{Message: "value not numeric", Val: i}
    }
  },
}

program, _ := expr.Compile(`err(11.1)`)
res, err := expr.Run(program, env)
// err will be Error1, preserved from the return statement

While it is simple and crude example, it shows that this approach can be used to get error type and even capture context in a type that implements error interface.

This is a great argument. Give me some time to review your PR.

This is a great argument. Give me some time to review your PR.

Hello,
Sorry to bother, but have you had any time to check this out?
We would like to use this feature in prod ASAP..

I still need time to review it, as change is quite big.

Any progress on this PR?

Will try to have a look on this weekend. Sorry for a delay.

Hi @antonmedv is there any issue with this PR?

Sorry for a loooong delay))


Dockerfile: switch to python 3.10

Motivation for changes:
Python 3.10 is supported by Flexget, no reason to keep using 3.9
Detailed changes:

change image version to use python 3.10

👍 Thanks!


Clean up Python dependencies in owl-bot-postprocessor/requirements.in

Clean up Python dependencies in owl-bot-postprocessor/requirements.in.

obsolete


Add backdround/improved-ft.nvim

Repo URL:
https://github.com/backdround/improved-ft.nvim
Checklist:

[x] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] The title of the pull request is Add/Update/Remove `username/repo`  (notice the backticks around `username/repo`) when adding a new plugin.
[x] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
[x] The description doesn't contain emojis.
[x] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
[x] Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

Thanks for the PR!


SO-5437: Support x-author header in a code system version creation

Codecov Report

Merging #1018 (13fb1fa) into 8.x (c88f8d6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                8.x    #1018      +/-   ##
============================================
+ Coverage     64.93%   65.00%   +0.06%
- Complexity    12224    12256      +32
============================================
  Files          1697     1699       +2
  Lines         56453    56492      +39
  Branches       5215     5221       +6
============================================
+ Hits          36657    36720      +63
+ Misses        17567    17535      -32
- Partials       2229     2237       +8

Impacted Files
Coverage Δ

...owowl/core/rest/codesystem/VersionRestService.java
95.00% <100.00%> (+0.12%)
:arrow_up:

...owl/core/request/version/VersionCreateRequest.java
83.70% <100.00%> (+0.12%)
:arrow_up:

...e/request/version/VersionCreateRequestBuilder.java
92.59% <100.00%> (+0.92%)
:arrow_up:

...hir/core/request/codesystem/FhirLookupRequest.java
85.71% <0.00%> (-9.03%)
:arrow_down:

...nal/snowowl/core/repository/ApiRequestHandler.java
70.37% <0.00%> (-5.63%)
:arrow_down:

...ernational/snowowl/internal/eventbus/EventBus.java
82.16% <0.00%> (-4.21%)
:arrow_down:

...ational/index/query/AbstractExpressionBuilder.java
91.04% <0.00%> (-2.44%)
:arrow_down:

...d/datastore/request/SnomedConceptRequestCache.java
75.80% <0.00%> (-0.56%)
:arrow_down:

...owowl/core/authorization/AuthorizationService.java
66.66% <0.00%> (ø)

...om/b2international/snowowl/eventbus/IEventBus.java
100.00% <0.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88f8d6...13fb1fa. Read the comment docs.


v2.5.1 Run Script > return value from Reshaper.event.getMessageValue not change

I tried to get value of body message from HTTP request in Repeater using Reshaper.event.getMessageValue("HttpRequestBody", "").
However, this function always return value from first call and keep this value persistent when i change body data in Repeater.

Reshaper v2.5.1
Burp Suite Professional v2024.8
Windows 11
openjdk version "21.0.4"

Hi @sondk. Please export your rules as JSON or Yaml and attach them here. Be sure to first remove any private or proprietary data.

Hi @ddwightx , here is exported rules as JSON.
ReshaperBackup.json
btw, when using v2.4.0 its work. I downloaded v2.5.1 from releases.

@sondk Thanks for the excellent report. This has been fixed in v2.5.2.


hemorrhage versus haemorrhage

Related to #2691
Any MP term with the word hemorrhage/hemorrhagic should have a synonym that replaces hemorrhage/hemorrhagic with haemorrhage/haemorrhagic.
hemorrhage
lung hemorrhage
gastrointestinal hemorrhage
kidney hemorrhage
intracerebral hemorrhage
spinal hemorrhage
brainstem hemorrhage
vitreous body hemorrhage
ovary hemorrhage
uterine hemorrhage
heart hemorrhage
pulmonary alveolar hemorrhage
glomerulus hemorrhage
skin hemorrhage
internal hemorrhage
remittent intestinal hemorrhage
intracranial hemorrhage
intraventricular hemorrhage
hemopericardium (pericardial hemorrhage)
hemoperitoneum (peritoneal cavity hemorrhage)
cerebellum hemorrhage
hypothalamus hemorrhage
rectal hemorrhage
retinal hemorrhage
eye hemorrhage
liver hemorrhage
genital hemorrhage
umbilical cord hemorrhage
epistaxis (nasal hemorrhage)
nipple hemorrhage
ear hemorrhage
retrolental blood (retrolental hemorrhage)
hemorrhagic ascites
hemopericardium (hemorrhagic pericardial effusion)

Done.


unit-test: add unit test for pkg/ingress/kube/annotations

Signed-off-by: charlie<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
add unit test for pkg/ingress/kube/annotations
Ⅱ. Does this pull request fix one issue?

fixes #86
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
➜  annotations git:(ut/annotations) ✗ go test -coverprofile=count.out
2023-02-02T05:33:30.210033Z     error   ingress Fallback service foo/app within ingress test/ haven't ports
2023-02-02T05:33:30.414255Z     error   ingress Custom HTTP code 5ac within ingress test/ is invalid
2023-02-02T05:33:30.414880Z     error   ingress parse destination error invalid annotation value within ingress /
2023-02-02T05:33:30.415359Z     error   ingress CA secret bar/foo is invalid
PASS
coverage: 81.7% of statements

Codecov Report

Merging #156 (f4c342a) into main (5ae9151) will increase coverage by 4.58%.
The diff coverage is 100.00%.

:exclamation: Current head f4c342a differs from pull request most recent head 829865f. Consider uploading reports for the commit 829865f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   37.62%   42.21%   +4.58%
==========================================
  Files          29       29
  Lines        4864     4866       +2
==========================================
+ Hits         1830     2054     +224
+ Misses       2884     2651     -233
- Partials      150      161      +11

Impacted Files
Coverage Δ

pkg/ingress/kube/annotations/destination.go
80.76% <100.00%> (+80.76%)
:arrow_up:

pkg/bootstrap/server.go
59.16% <0.00%> (-2.30%)
:arrow_down:

pkg/ingress/kube/annotations/parser.go
61.78% <0.00%> (+3.18%)
:arrow_up:

pkg/ingress/kube/annotations/util.go
100.00% <0.00%> (+9.09%)
:arrow_up:

pkg/ingress/kube/annotations/canary.go
53.50% <0.00%> (+35.08%)
:arrow_up:

pkg/ingress/kube/annotations/redirect.go
50.00% <0.00%> (+50.00%)
:arrow_up:

pkg/ingress/kube/annotations/upstreamtls.go
81.00% <0.00%> (+81.00%)
:arrow_up:


[Feature] Add a Dynamic Square Grid Loader

Description
Add a new square grid animated loader
Screenshots
https://github.com/Rakesh9100/Beautiify/assets/56386613/7d3045d4-651b-4cc0-9598-bc14279ef24f
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Proceed @Nemesis-AS


Improve build spec flexibility

Replace PackageManager enum with customizable struct
Replace Vec<T> with T in BuildSpec
Transpose Matrix items
Use immutable reference for Context in ResolvedConfig
Consolidate main entry point logic

Closes #68


Update menu.md with info on allowed_updates

Couldn't see this anywhere in the docs and wasn't immediately obvious to someone starting to use grammy and Telegram for the first time.
Feel free to close if it actually just confuses things.

I see the point of adding such a note, but I'd like to do it slightly differently. Does #1069 work for you?

Thats perfect @KnorpelSenf 👌


Remove #if os check on Package.swift file

Bug/issue #, if applicable:
Summary
A follow-up PR for #608 (Revert the change of Package.swift in that PR)
See https://github.com/apple/swift-docc/pull/608#issuecomment-1580891971
TLDR: Adding #if os check on Manifest file is not a good practice because it only indicates the host platform not the destination platform.
Imagine the following two scenarios:

We have added the cross compile ability to SwiftPM (Build Linux product on Windows) then the check here will give us a wrong answer.

We have added a new platform support which NIO also does not support and NIO support for Windows is ready.

For the original code, we need to remove the exclude for Windows and then add another exclude for the new platform.

In this simple case only one dependency NIO is considered, it would be simple to change #if os(Windows) to #if os(newOS)

But if there are multi dependency and Windows is getting support for only one dependency then  we will have to maintain such code for the 2 platform

For the updated code, no major changed is needed. If NIO adds Windows support, we just add it to the condition: .when(platforms: [.macOS, .linux, .android]) array. And that's it.
Testing

[ ] Windows Platform build is not checked.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[x] Updated documentation if necessary

@swift-ci please test

Sure, this seems reasonable. I might want a quick follow up if this regresses the build on Windows (we don't have CI coverage yet :-().

I'll get it a try on my Windows machine before merging it.

Sure, this seems reasonable. I might want a quick follow up if this regresses the build on Windows (we don't have CI coverage yet :-().

I'll give it a try on my Windows machine before merging it.

Awesome, thank you!  I'm hoping to get the rest of the changes for the tests merged soon.  There is some work that needs to happen with Foundation to improve long paths to improve the test coverage pass rate, but the non-test components should build at least.

@swift-ci please test

Sorry swift 5.8 on my Windows computer can only build simple packages. When it comes to swift-docc, it will always fail for some unknown error. 😭

Yeah, there were some recent changes to SPM to support it, so it needs main.

Maybe we can merge it first and if this regresses the build on Windows I'll do a quick follow up/

I think that is reasonable.

Sorry swift 5.8 on my Windows computer can only build simple packages. When it comes to swift-docc, it will always fail for some unknown error. 😭

Yeah, there were some recent changes to SPM to support it, so it needs main.

Maybe we can merge it first and if this regresses the build on Windows I'll do a quick follow up/

I think that is the right thing here.

Got it. I'll try it will Swift 5.9 or the latest nightly toolchain later on.


Speed up pipeline calls

As per this thread: https://stackoverflow.com/questions/62599036/python-requests-is-slow-and-takes-very-long-to-complete-http-or-https-request the requests library first attempts an IPv6 connection and once that fails it will try an IPv4. After testing with curl --ipv4 it seems that the pipeline only has an IPv4 connection. We will add a timeout of about 7 seconds to speed up the calls to the pipeline to reduce it from about 1 minute to 10 seconds.

This endpoint utilizes threading which was not enabled in UWSGI.ini, this is why it was not working properly


gamm: Use expectedErr fields with error types

Partially closes: #2959
What is the purpose of the change

Update tests that are using expectPass or expectErr as the bool variable to the error type in the gamm module

Brief Changelog
(for example:)

Coverage gamm module
All tests pass
Commented at test cases where the error returned is not as expected

Copying my previous message here:
There seems to be some miscommunication internally on desired endstate for tests. While you completed what was requested from the github issue, we had internally decided to stick with bool error checking (for now) and possibly discuss moving to this at a later time. cc @mattverse

Going to close this for now and we can potentially reopen after further discussions


Request search for MAC address

Issue type
[X] Feature request
[ ] Bug report
[ ] Documentation

Environment

Python version: 3.5.2
NetBox version: 2.3.2

Description
Would be nice to have the ability to search for MAC addresses in any format from the UI. Would help track down interfaces of servers and/or VM's by MAC rather then by IP.

Hello,
It seems it's already implemented, see 1379
You can globally search for MAC addresses (in the global search input field), but I don't know why it doesn't seems to work.
Or you can use the dedicated filter in dcim -> Devices view, there is an input field on the bottom of the search box to the right of that page.
@jeremystretch It seems this dedicated filter doesn't exist for Virtual Machine, is it desired ?

@emarton77 There's a "MAC address" field in the search form to the right-hand side of the devices list.
@Keyhaku We can add one for virtual machines, but please open a new ticket specifically for that.

It would be nice for global search bar (top right, next to username) to include MAC search.

Global search for MAC address works for me in v2.5.8. However, the global search only supports the AABBCCDDEEFF MAC address format. The MAC address search field on /dcim/devices allows both the AA:BB:CC:DD:EE:FF and the AABBCCDDEEFF formats.
@jeremystretch Is it possible for the global search to support both formats?
Also referencing #1379 since I found that first when looking for the ability to search by MAC.

Bumping for global MAC search in multiple common notations. I’ve seen them as

MM:MM:MM:SS:SS:SS
MM-MM-MM-SS-SS-SS
MMM.MMM.SSS.SSS


question on the G(eneral)-Prompt learning

Thanks for your impressive work. There is still one thing that I can't figure out. According to the setting of continual learning, when learning on the current task, the data from previous tasks is unavailable. My question is, how do you make sure that the G(eneral)-Prompt learned on the current task also works for previous tasks? How do you deal with the forgetting problem of the G(eneral)-Prompt itself?

I have the same question when I read the paper


Use DRY principle for components

Gatsby site reuses many components. Remove reuse and centralize component in a single location. This will allow for easier maintainability.

Issue no longer applies since site uses styled-components library for all styling instead of CSS/SCSS


When initialing the instance, I got this error.

Traceback (most recent call last):
File "C:\Users\hao\Desktop\lil_tool_py\skype\test.py", line 4, in
sk = Skype(username, password) # connect to Skype
File "C:\Python27\lib\site-packages\skpy\main.py", line 69, in init
self.conn.getSkypeToken()
File "C:\Python27\lib\site-packages\skpy\conn.py", line 262, in getSkypeToken
self.liveLogin(user, pwd)
File "C:\Python27\lib\site-packages\skpy\conn.py", line 361, in liveLogin
self.getRegToken()
File "C:\Python27\lib\site-packages\skpy\conn.py", line 423, in getRegToken
self.syncEndpoints()
File "C:\Python27\lib\site-packages\skpy\conn.py", line 433, in syncEndpoints
params={"view": "expanded"}, auth=self.Auth.RegToken).json().get("endpointPresenceDocs", []):
File "C:\Python27\lib\site-packages\skpy\conn.py", line 215, in call
raise SkypeApiException("{0} response from {1} {2}".format(resp.status_code, method, url), resp)
SkypeApiException: ('404 response from GET https://client-s.gateway.messenger.live.com/v1/users/ME/presenceDocs/messagingService', <Response [404]>)

Can't seem to reproduce here. Please set SKPY_DEBUG_HTTP=1 in your environment, try signing in again, and include the response from Skype below (make sure to blank your password and tokens).

It just work fine today. thx a lot anyway


Update authors.

👍

Thanks @lynnlangit and @artemnikitin ! You're on the credits list now. :)

thanks! look for more content (pull requests) soon


Base api: jme3-alloc base api

This PR adds the following:

[x] Native base api jmealloc.h utilities.
[x] JVM side api NativeBufferUtils.java and NativeBufferAllocator.java.
[x] Native image extractor NativeBinaryLoader.java that loads the system specific library.
[x] Build script {java.home} supply to include the native headers on compile-time.
[x] Build script enhancements including {stdin, stderr} output logs.
[x] Documentation for the native side api.
[x] Documentation for the java side api.

@Ali-RS I am done laying out the base api and the documentation, please give them a look before merging.
About other methods memorySet(), memoryMove(), there will be techdemos showing their usages.
As for TestLibrary.java class it was for prototyping and the API shouldn't have a main runnable method, and the jme3-testalloc will have a list of techdemos later on.


Can't remove cart attribute using cartAttributesUpdate action from useCart() hook

What is the location of your example repository?
No response
Which package or tool is having this issue?
Hydrogen
What version of that package or tool are you using?
^2024.4.2
What version of Remix are you using?
No response
Steps to Reproduce

Make sure you are using 2024-04 storefront api version.
Wrap your app with ShopifyProvider, CartProvider, and ProductProvider if needed

destruct cartAttributesUpdate from useCart()

Create cart attribute: cartAttributesUpdate([  {    key: 'gift-note',    value: 'test',  }]);

Try to remove cart attribute or clear the value by passing an empty string:

 cartAttributesUpdate([     {       key: 'gift-note',       value: '',     }   ]);
Expected Behavior
attributes from useCart() is should return an empty string value for gift-note cart attribute. Or I think attributes should not return gift-note cart attribute since the value is an empty string.
Actual Behavior
attributes from useCart() is still returning the same value for gift-note cart attribute.

D'oh. Closing. If I want to remove it, just don't need to add it to the cartAttributeUpdate action

D'oh. Closing. If I want to remove it, just don't need to add it to the cartAttributeUpdate action


Ran clang-tidy with modernize-redundant-void-arg

Running clang-tidy over the 7.1.x branch to make things easier to backport

[approve ci clang-analyzer]


Issuer Key Rotation in the Event of compromised Issuer private key.

The Indy AnonCreds Design here Anoncreds Design included provisions for key rotation leveraging the Indy/Sovrin Ledger.  I see no mention of key rotation in this specification. How do you plan on providing for key rotation in the event the private key of the Issuer becomes compromised?

Currently, the only method I'm aware of in AnonCreds for dealing with a Cred Def (which is the object that contains the public keys for a issuing a credential) is to create a new one, stop using the old one when issuing and only issue with the new Cred Def.  Any existing credentials issued with the old Cred Def would reference the old Cred Def, any new credentials, the old Cred Def.
In theory, an issuer could do more.  An Issuer with an Aries agent that retains a persistent DIDComm connection to the holders, would have a way to proactively issue a new credential to replace all of the old ones. If revocation is active for the credential type, the issuer could revoke all of the credentials associated with the old Cred Def.

So if the the private key of the public keys is compromised what stops the compromiser from issuing fraudulent credentials under the old cred def? How does a verifier know that credentials should be using the new cred def not that old one. The Indy AnonCreds design used time-stamps of the key state on the ledger for the cred defs to signal that old public keys in the cred defs were no longer valid and a verifier had to check the time stamp provided by a majority BLS sig of the ledger nodes.
Simply issuing a new cred def doesn't invadate credentials issued under the old cred def, unless the policty is to auto-revoke all credentials issued under the old cred def the instant the new cred def is published.
How does the legitimate issuer know that their key has been compromised and that they need to issue a new cred def. Given that the purpose of using Anoncreds is to prevent issuer linkability at presentation, a verifier would have to volunteer to the Issuer that they suspected an fraudulent issuance in spite of it being verifiable.
Seems heavy weight to require a persistent didcom connection from issuers to holders. Not to mention that survelliance privacy issues such a persistent connection would engender for third party survellors.
Without a normative key rotation mechanism, key compromise makes anoncreds fundamentally insecure.

All that said. AnonCreds may choose not to have a normative key rotation mechanism, but then the spec should be caveated that it should/must be used with some key rotation mechanism and some though should go into providing normative hooks in AnonCreds for such mechanisms.

Is this part of the "all roads must lead to KERI?" tour, Sam?
I've quoted a few of your questions and responded as per the AnonCreds model.

So if the the private key of the public keys is compromised what stops the compromiser from issuing fraudulent credentials under the old cred def?

Assuming the malicious actor replicates the environment of the Issuer and can attract holders interested in receiving a credential from the malicious actor, nothing stops them. It depends on how much control/information they have over the Issuer as to how effective it would be.

How does a verifier know that credentials should be using the new cred def not that old one?

Either the verifier does not know to ask for credentials from the new CredDef (and so never gets them -- holder can't satisfy the presentation request with the new credential) or the verifier gets a presentation that uses the new credential, with the Id of the new CredDef and they must decide if they trust it or not. As such, your definition of "how Indy did it" remains the same.

Simply issuing a new cred def...

Correct. And as noted, revocation is an option if the credential type supports revocation. Batch revocation is possible, although there is not "automation tied to publishing the new cred def", unless the issuer implements that. That is a policy issue supported by, but well above AnonCreds.

How does the legitimate issuer know that their key has been compromised and that they need to issue a new cred def?

There is no specified way to handle this as by definition. it is unknown. The issuer might detect the compromise. Verifiers could contact the Issuer (perhaps using the IssuerId in the credential) or perhaps a Trust Registry that supports reporting abuse could be used.  This issue is well-above the AnonCreds protocol and part of governance.

Seems heavy weight to require a persistent didcom connection from issuers to holders. Not to mention that survelliance/privacy issues such a persistent connection would engender third party surveillors to correlate holders to the credentials they hold...

There is no requirement to have a DIDComm connection. An issuer unilaterally revokes credentials -- the DIDComm connection can help them with notifications of the revocation and optionally, re-issuance. I merely offered that as a policy that an issuer might want to use, a deployment model they might choose. There is no surveillance about keeping a persistent connection.  An issuer supporting revocation MUST track the holder and credential issued in order to revoke the credential.  Again, no surveillance, just a technical requirement.

Rest of your response are statements.
There is a security section in the specification and in that, we'll include the issue of compromised keys and the options an issuer has, mostly outlined in this issue.
Thank you for raising this issue.

Very much appreciate your thoughtful responses.

Is this part of the "all roads must lead to KERI?" tour, Sam?

Actually i was trying to see what it would take to use AnonCreds as an optional proof type for ACDCs and ran into the inherent trade-off between stronger authenticiy and weaker privacy or weaker authenticity and stronger privacy that is a fundamental property of the limited crypto options at our disposal.  I raised this issue primarly becasue  I wanted see this new spec for AnonCreds sans Indy had any new thinking on the key rotation problem.
We have a very limited set of properties we can play with and as expressed by the PAC theorem we have a trilemma when doing systems design. We can have all of Privacy, Authenticity, and Confidentiality at some level of security but not all three at the highest level. We must pick two. Usually the trade is between Authenticity and Privacy and key rotation is one of the sticky points that forces the trade. PKI can only do so much and ZKPs can only do so much and when you want absoulte unlinkability you must give up some other property to some degree.
KERI is opinionated in that it makes the choice to always have authenticity as the strongest of the three which necessarily means some compromise on privacy. It may not be a big compromise but the one that is sticky point is malicious unpermissioned correlation between Issuer and Issuee by a verifier. All the other correlations can be dealt with without sacrificing authenticity. It is the trade-off induced by key rotation vis a vis linking key state to revocation state that is the problem.
I have yet to see a satisfying approach to key rotation that doesn't make a trade-off between linkability and authenticity (secure attribution).

Interesting discussion! Is that something we can tag as next version?

Closing this issue.  The “solution” for key rotation is “cred def rotation” — a new cred def is used.


[all] Reflected API changes in tket #20

There is now a pytket 0.16.0rc0 release with this API change. Please change pytket ~= 0.15.0 to pytket == 0.16.0rc0 in the setup.py of all 12 modules to pick up this version.


Add bracket to raids cn names for all the raids from "02-arr" to "05-shb" (#1193 fix)

This commit only contains the fix of CN raids zoneRegex problem. All 02~05 raids are fixed.

This commit fix the issue #1193

Thanks for the quick fix!


test(py): new ana testcase for checking io policy

Added new testcase to validate that I/O policy for a multipath nexus
is NUMA.
Fixes CAS-980

bors r+


feat(md-dropdown): add stopPropagation option

Same PR as #457  but with correct naming convention and only one commit.
Fix the issue #451

Thank you! 😃


Plugin is not properly removing unused classes like for example from bootstrap.

So when running the plugin I am not seeing any significant reduction and in fact I am still seeing references to css that isn't being used via bootstrap. I have followed all directions and I am seeing other experiencing the same issue such as here: https://github.com/webpack-contrib/purifycss-webpack/issues/49

It's hard to say anything concrete based on output alone. I would need as simple as possible project to study that fails to pick up some class to say more.

Feel free to re-open with a proper example.


feature request: Include project files to download

Hello
Can you please include project files to download automatically for a course
Thanks

Closing this for now, feel free to create a new issue with a more specific example if you're still interrested


lorri: 1.4.0 -> 1.5.0

Motivation for this change
update
I ran eval $(nix-build -A lorri.updater) but it had no effect.
cc @Profpatsch
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Thanks!