Why does there appear some dirty lines after dragging the control many times?

Download the package from git, according to the instructions, step by step to build the site
Then visit the about.html of the site
When I drag the control on the design panel several times, there will be some dirty lines.
But doing the same thing on the http://www.zebkit.org/website/dark/about.html doesn't have dirty lines, why?

You locally generated website uses GIT zebkit version (located in "build/zebkit.js" folder). Could you tell me browser and OS you have met the problem ?

locally generated website uses GIT zebkit version (located in "build/zebkit.js" folder)
the operating system is win7,
the browser is Google Chrome, more than 60 versions are like this
thanks

According code comparison  I would say the versions (GIT and zebkit website) have to have the same problem, could you double check website version of design panel example doesn't leave artifacts ?
PS: I am trying to find a Win7 to reproduce the problem. My parallels Win7 VM Chrome has strange problem with performance and stability.

Have tested Win10 Chrome 62. No problem detected. As far as I can see Chrome 62 is the latest version. Could you try to update your chrome version ?

I have the same problem with win10 chrome 62, and http://www.zebkit.org/website/dark/about.html also has this problem,
Before using zebra in chrome38, 40 did not appear this problem, now zebra and zebrkit in chrome 58, 60, 61, 62 have appeared this problem,
There has never been this problem on firefox.
I really hope to be able to solve this problem
thanks

Could you tell me what is value of "zebkit.web.$deviceRatio" variable in your case ?
Actually I suppose the cause is loosing precision when zebkit round coordinates. It happens when screen dpi is float.

Download from git,
No changes have been made,
Setting up a site according to the operation steps specified on git,
The test is just a sample downloaded from git,
How do you set the value "zebkit.web.$deviceRatio"?

window.devicePixelRatio
1.100000023841858
window.devicePixelRatio
1.100000023841858

Thanks. As far as I have told the problem is triggered with devicePixelRatio value is not integer. HTML Canvas does some transformation to scale coordinates from the values zebkit expects to canvas physical pixels. In your case physical x is x' = x * 1.1  Seems HTML Canvas clearRect API method rounds the value, what means in some cases the expected cleaning area will be smaller then expected.
I am on the way to fix it, but for the time being you can fix it with a workaround taking in account  DPI of your device is very close to 1, you can try to set zebkit dpi value to 1 before you start instantiating zCanvas:
zebkit.web.$deviceRatio = 1; // instead of 1.1
//  below you can start initiating zCanvas
...

ok,thanks


Clean up ic init parameters and a clone method

Remove :saved, :data and :data_index params from the init method and make them as attr_accessor. Clean up clone method using those.

@miq-bot assign @agrare
@miq-bot add_label refactoring


Remove runner on instance shutdown.

Description
This is primarily set up to resolve the issues I pointed out in #163. This creates a one-line script that sends a DELETE request to the proper Gitlab endpoint to remove this runner from Gitlab. I'm also removing the key from SSM at the same time, since the key is now unable to be used in the future.
Migrations required
NO, I don't think?
Verification
I've been verifying this by pointing my usage of this module to my fork/branch and then trying doing apply/destroys. At this point, it seems to be working as expected, but I'd love to see someone else validate it on their own.
Documentation
I've added what I help are appropriate comments - let me know if I should add more robust documentation elsewhere, but this doesn't seem to have a place to put it.
Issues Outstanding
Currently, I'm running into problems around the use of SSM caching of the runner Token in the following situation:
1. Token is returned when the Runner is created the first time.
2. Token is put into SSM as a param.
3. I terminate the instance in the ASG from the AWS Console to simulate an instance failure/reboot.
4. The runner api is called with a DELETE for that token, removing the runner as expected.
5. A new instance boots, finds the token in SSM and presumably tries to use it like normal to register.
6. Seemingly, Gitlab rejects the token, since it's been removed/deleted, but there's not fallback/retry/reset built into the boot script, so the instance is up and running, but not registered with Gitlab.
I'm not totally sure how to get around this. We could probably set up some sort of retry logic around registering the Gitlab runner with tokens, where it would fall back and register from scratch if it's rejected with that token?
I also just don't generally understand the purpose of the SSM caching of something that Gitlab seems to treat as a per-Runner key. Why not just always get a new key for every instance and de-register them as the instance dies?
Issues seem to be resolved in my own testing at this point!

I'm really lost here on what's going wrong with using Runlevel for cleanup. The script is in place, and if I run things manually with /etc/rc.d/init.d/remove_gitlab_registration start, it runs fine and works. When I terminate the instance, however, nothing gets logged, and the runner isn't removed, and it doesn't seem to be running the initial lockfile setup on startup either.

@pshuman-heb Hopefully I have next week some time to have a look at the issue as well.

So, it feels a bit hacky, but I think it's working right now! I don't like that I'm manually having to touch the lockfile during the userdata script, but that seems to be necessary since I'm not seeing the actual start script getting run as part of the initial boot up.
I also adjusted things some so that the Removal script is only run on shutdown, and not on reboot. In general, reboot seems like a case where we actually want to keep the key active and in SSM, so that we can pick it up on reboot. This is also necessary for now because there doesn't seem to have any logic in the scripting for dealing with having the runner fail to boot up because of a bad key.
I'll make a different issue for that matter. It seems like we should be able to recognize that the Runner failed to boot because of a bad key, and just request a new one.
It's also important to note that I don't think this script will reliably work when an instance is Terminated as opposed to Stopped. This seems to be ok when it comes to terraform destroys, but could cause issues in other cases.

@pshuman-heb thanks, will check the PR this weekend.

@pshuman-heb I have tested several scenarios. The removal works fine when I terminate the instance. But by running a terraform destroy the runner remains in GitLab. I have no clue why the shutdown script in that case is not executed. Maybe it is related to the use of a auto scaling group.
Another approach could be remove the runner with a local-exec resource. But in that case we should first obtain the token via SSM.
Was terraform destroy working for you?

I quickly tried to remove the runner via terraform. Could not got i working with a data_source to obtain the token but with a simple script is was quite ease:
I have created the following script
set -e
TOKEN=$(aws ssm get-parameters --name $3 --with-decryption --region $1 | jq -r ".Parameters | .[0] | .Value")
curl -sS --request DELETE "${2}/api/v4/runners" --form "token=${TOKEN}"

And added the following local-exec to the main.tf file
resource "null_resource" "remove_runner" {
  depends_on = [aws_ssm_parameter.runner_registration_token]
  provisioner "local-exec" {
    when       = destroy
    on_failure = continue
    command    = "${path.module}/remove-runner.sh ${var.aws_region} ${var.runners_gitlab_url} ${local.secure_parameter_store_runner_token_key}"
  }
}

What do you think of this approach

I've seen it work when using terraform destroy in my testing, but my guess is it's not necessarily going to be consistent, perhaps because it's removing the instance faster than the instance can run the script.
I like doing both solutions then, perhaps? Your script there should solve for the case of destroying via Terraform, and mine should hopefully solve for "natural" loss of the instance in AWS due to hardware issues or a reboot.
The only potential issue is if both the instance and this script both try to delete the runner at the same time, but I think that doesn't cause any real problems that would need to be solved. One or the other of the scripts would fail, but we could probably add some output logging to explain the situation if this "local" one fails.

You mention the script solved the issue of natural lost. This is already handled by the user data script. In case the instance is destroyed it fetch the token from smm. So it will reuse the same, all ready registered runner. Are you aware of this a bit magic behaviour?

I'm aware of the behavior, but I've found it can be a bit awkward in some situations. In the case that AWS terminates the instance and then it immediately comes back up through the ASG, or there's scaling rules that remove the runners during off-hours, it's fine to have the new instances come back up and get the value from SSM. There's a couple other use-cases where I think it could cause issues.
First, I'm unsure of how Gitlab handles potentially having multiple active instances all registered with the same token? Right now, if the ASG ever scales to 2, it seems like it could lead to Gitlab's scheduler getting confused since two Runners are reporting as the same registration.
Second, in the case where you deploy an update to the Runner config that would cause it to need to re-register with a different Token, there's no neat way to do that right now without manual intervention, or totally destroying the module. For instance, if I rotate the key for runner registration for my Group/Project, the runners will keep thinking the old registration will work. This is also a problem if you have to move a set of runners to a different Group/Project - since they just get the key from SSM, they never pick up the new location. This is a similar issue to #173.
I'll admit that neither of these are major issues that demand a change, but personally, I also just feel like it's better practice to always de-register when the runner is going offline, and re-register as a new runner when they come up again. Registrations are essentially free, so I don't see much downside to having each instance make its own registration.

Caching in SSM was introduced since it was hard to delete the runner, now we can delete the runner maybe I go to remove the whole SSM part. It does not make that much sence anymore.

Yea, the SSM stuff works well, but now that it's clean and easy to create/destroy runners, that seems like it could be the better solution.


PHP Enums not converted correctly

PHP Enums and backed Enums are not correctly converted to TS Enums
#14 introduced TS enums transformations but the toEnum method always create string enums
Is this the intended way ?

Hi @angauber,
You're right, enums shouldn't always be transformed into String enums. At the moment we're not using the enum functionality of the package (we just use a list of string, the default option) so I have no time at the moment to fix this. But I would accept a tested PR that adds this functionality!

I think #19 should resolve this issue.

Merged and released!


install gem in the sandbox

https://github.com/packit/packit-service/issues/771
needed for ruby-based projects

pushing to stable as well


Backport of
https://github.com/mongodb/node-mongodb-native/pull/3553
Double check the following

[x] Ran npm run check:lint script
[x] Self-review completed using the steps outlined here
[x] PR title follows the correct format: type(NODE-xxxx)[!]: description

Example: feat(NODE-1234)!: rewriting everything in coffeescript

[x] Changes are covered by tests
[x] New TODOs have a related JIRA ticket

Marking blocked pending review of #3553


Added Python Snake Game with Turtle Graphics

This pull request introduces a simple yet engaging Snake Game implemented in Python using the turtle library. The game features a graphical user interface (GUI) and provides the following functionalities:
Gameplay: The player controls a snake that moves across the screen, consuming food to grow in size. The game ends when the snake collides with the screen boundary or itself.
Score Tracking: Displays the current score and updates it as the snake eats food.
High Score: Tracks and displays the highest score achieved during gameplay, allowing players to compete for a new high score each time they play.
User Interface: The game uses the turtle library to create a simple and interactive GUI, where players can use the arrow keys to navigate the snake.
Features:
Interactive UI: Clear and responsive controls using the arrow keys.
Live Score Updates: Real-time updates of the score displayed on the screen.
High Score Tracking: Remembers and displays the highest score achieved.
This game provides an enjoyable and interactive experience for users and serves as a fun way to showcase Python’s turtle graphics library. I believe it adds a fun feature to the repository and enhances the overall project!

I’ve added the README file with detailed information about the Snake Game. Please review it and let me know if any further changes are needed, Thank you.


Swapper: Change location of gas fee errors

Overview
Currently in the swapper, we have multiple error types that appear inside the button. Going forward, we'll need to remove any errors related to 'gas' from the button and pull them out into an error state that will display above the button. The reasoning, is due to bridging— with a bridge sometimes the user will need gas on two different chains (ex: eth and avax) and the button does not provide enough room to display a longer error.
References and additional details

The error for gas should appear above the button
In the case when the user doesn't have enough gas, the "preview trade" button should mute/fade and the error would display
Please use the yellow error styling
Message will state " Insufficient gas" you need at least: [asset amount] on [chain name]

Acceptance Criteria
As a user, I should see any errors related to insufficient gas in a yellow alert box above the "preview trade" button. I should not be able to continue my trade when this error occurs.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

No longer relevant


Fix local command

This is related and a fix for this issue https://mirrorful.slack.com/archives/C04QKTVD8FP/p1680718339754139.

I don’t think those commands are actually ever used. I think all the scripts should be deleted from that package.json because the only package.jsons that are used are the ones in the editor and in the core.

I don’t think those commands are actually ever used. I think all the scripts should be deleted from that package.json because the only package.jsons that are used are the ones in the editor and in the core.

Okay as Teddy mentioned Ill delete the local scripts so they won't interfere.

updating the thread here, these are used for testing the cli locally.
Thanks to @karanvirsb for adding a fix for windows users.


Prototype/secret manager with java library

Test

This is redundant because tests are run from GitHub engine so authImplicit will never work as clarified in the standup on 7/7/2020.


ios app performance

Submit feature requests to http://www.mattermost.org/feature-requests/. File non-security related bugs here in the following format:
Summary
ios app scrolling stutters.
Environment Information

Device Name: iphone 7 plus
OS Version: 113
Mattermost App Version:  1.7.1
Mattermost Server Version: 4.8.0

Steps to reproduce
i have a test channel with 30 messages and the scrolling is far away from smooth.
Expected behavior
if i try the same with safari on my iphone in the same chatroom it is completely smooth no stuttering.

Hi @faxe78,
Thanks for your feedback,
You might want to try upgrading to the latest version of the Mattermost server to see if this resolves the scrolling issue for you.

Hi,
Did the upgrade no change in the ios app. In mobile safari i see the dark theme in ios i see some white theme. Maybe the app should use the standard mobile theme?
Greetings
Markus

Hi @faxe78
Apologies, I'm totally confused, is your issue about scrolling issues or theme colour?
The scrolling issues are fixed in the latest app and server versions.
If I change my theme in a browser (the actual setting to change it in the app is not yet available) it does display in the app (on Android and iOS).
Please help me understand if I'm not on the right path here :)

Hey, @faxe78 are you saying that mobile app the scrolling stutters but on viewing the same channel in safari(i.e accessing webapp mobile version using a browser) the scrolling experience is better?

yes that's i meant the scrolling with safari on an iphone is way better, with the app it stutters.
i was searching for the cause of the stuttering, the light and dark theme mobile code for safari and the code that the mobile app is using maybe there is the reason of the issue. i think safari and the webviews are not 100% the same on ios but i am not a dev.

Thanks @faxe78 @sudheerDev
I've created a ticket to investigate the scrolling
issue in the app.
I'll close this issue off here for now and we can track via the ticket.


unable to recognize "install/weather-v1.yaml": no matches for kind "Deployment" in version "extensions/v1beta2"

请教下，运行示例时候报错：
k8s version: 1.16.2
kubectl apply -f install/weather-v1.yaml -n weather
unable to recognize "install/weather-v1.yaml": no matches for kind "Deployment" in version "extensions/v1beta2"
unable to recognize "install/weather-v1.yaml": no matches for kind "Deployment" in version "extensions/v1beta2"
unable to recognize "install/weather-v1.yaml": no matches for kind "Deployment" in version "extensions/v1beta2"

1.16 extensions/v1beta2 group version 被删除了， 需要升级使用apps/v1

我在windows上用minikube 也遇到同样问题，请问怎么修改，怎么升级使用apps/v1?


Background color ignored in pdf output

export_fig works fine for bitmap but neglect the axes color when outputting pdf.
Even after set(gcf,'InvertHardcopy','off'), in which print can retain the background color, export_fig always treat the axes color as white.
figure('color','w');
axes('color','k'); % black background
x = rand(50,50);
x(10:20,10:20)=nan;
h = imagesc(x);
set(h,'alphadata',isfinite(x)); % make nans transparent

export_fig test.png

export_fig test.pdf
test.pdf

Fixed - this is a bug with Matlab's built-in print function (which is used internally by export_fig, in its print2eps function), when the painters renderer is used. Exporting works ok with opengl so when a similar case is detected, the output is automatically switched to opengl.
Also see issue #206 , which is another image-specific bug that only happens with painters and not opengl.


Gcloud

New gcloud plugin prototype. (Prototype incomplete)
Take a look : Configuration looks like like below
buildscript {
    repositories {
        jcenter()
    }
    dependencies {
        classpath 'com.google.appengine:gradle-appengine-plugin:${version}'
    }
}

repositories {
    jcenter();
}

apply plugin: 'java'
apply plugin: 'war'
apply plugin: 'appengine-gcloud'

dependencies {
  compile 'javax.servlet:servlet-api:2.5'
}

gcloud {
  //configurations (of deployables and runnables)
  configurations {
    prod {
      args project: "myProd", "hyphen-param": "tomato"
	deployArgs something: "value"
      runArgs "admin-host": ":1995"
      modules ":a", ":b”
    }
    test {
      modules ":a", ":b"
      args project: "myTest"
    }
    singleProd {
      modules ":a"
    }
    indexes {
      modules ":a"
      descriptors "index.yaml"
    }
  }
}

Will dynamically create run/deploy tasks for each configuration
gcloudDeployProd
gcloudDeployTest
gcloudDeploySingleProd
gcloudDeployIndexes  //no associated run command because no app.yaml
gcloudRunProd
gcloudRunTest
gcloudRunSingleProd

@rdayal @patflynn @salguarnieri
Take a look in interested

For the record:
Issues:

Couldn't get this to work for the 'Run' task. Haven't tried the 'Deploy' task
yet. I kept getting:
gcloudRunLocal=task ':gcloud:gcloudRunLocal'
[gcloud, preview, app, run]
[--enable-mvm-logs]
[]
[gcloud, preview, app, run, --enable-mvm-logs]
usage: gcloud preview app run  RUNNABLES [RUNNABLES ...] [optional flags]
ERROR: (gcloud.preview.app.run) too few arguments
:gcloud:gcloudRunLocal FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':gcloud:gcloudRunLocal'.

Process 'command 'gcloud'' finished with non-zero exit value 2

Seems the configuration.descriptors were not being set on the runTask within the
GCloudPlugin. I added the following line:
--- a/src/main/groovy/com/google/gcloud/GCloudPlugin.groovy
+++ b/src/main/groovy/com/google/gcloud/GCloudPlugin.groovy
@@ -89,6 +91,7 @@ public class GCloudPlugin implements Plugin {
void execute(RunTask runTask) {
runTask.setArgs(configuration.args + configuration.runArgs)
runTask.setModules(configuration.modules)

                       runTask.setDescriptors(configuration.descriptors)
                       runTask.setAsync(configuration.runAsync)

and it started working.

Doc States (https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/pull/189):
apply plugin: 'gcloud'
However, plugin is configured as:
apply plugin: 'appengine-gcloud'
See: src/main/resources/META-INF/gradle-plugins/appengine-gcloud.properties

Evaluation order. The default evaluation order of the projects is
alphanumeric (for the same nesting level). Therefore, if I add a gcloud
declaration in a subproject that appears before my modules it fails with:
Task with name 'appengineStage' not found in project ':'.
Because the GCloudPlugin.createDynamicTasks() has a call to afterEvaluate()
and that plugin is evaluated before some of the module sub-projects since
it's alphanumeric position is before them. Two work arounds:
A. Add evaulationDependsOn(':') to my gcloud sub-project for each
module that it depends on.
B. Name my gcloud sub-project something like 'zzzzzz' just make sure it's
evaluated after all the other module related sub-projects (seems kind of
magical and contrived so I don't really like this one).
Not sure if there is something you can do to make this easier to use. Even if
I put the gcloud declaration on the root project I get the same problem since
the evaluation order is root first then sub-projects.

New Issues:
Again, just working with 'Run' tasks for now...

gcloud plugin only seems to trigger dependsOn for the last module in the list.
at com.google.gcloud.task.app.AppTask.getAppPath(AppTask.groovy:52)
No signature of method: java.io.File.absolutePath() is applicable for argument types: () values: []
Possible solutions: getAbsolutePath()
When I can get the modules staged I get the following when the server starts
to run:
google.appengine.api.yaml_errors.AmbiguousConfigurationFiles: App has both XML and YAML configuration files: ['/usr/local/google/gitbench/endgame/server/default/build/staged-app/index.yaml', '/usr/local/google/gitbench/endgame/server/default/build/staged-app/WEB-INF/datastore-indexes.xml']

-------------- Build info related to #1:
[...my app has three modules: default, event, and spatialbackend.  Only one
seems to be staged - the last one in the list...]
gcloud/build.gradle:
[...]
gcloud {
configurations {
local {
modules ":default", ":event", ":spatialbackend"
args "enable-mvm-logs": true
}
prod {
modules ":default", ":event", ":spatialbackend"
}
}
}
$ ./gradlew clean gcloud:gcloudRunLocal --full-stacktrace
:common:clean
:default:clean UP-TO-DATE
:event:clean UP-TO-DATE
:gcloud:clean UP-TO-DATE
:spatialbackend:clean
:tools:clean UP-TO-DATE
:spatialbackend:appengineDownloadSdk
:checkJdk UP-TO-DATE
:common:unpackPlatformProtos
:common:extractProto
:common:unpackProtoc UP-TO-DATE
:common:generateProto
:common:compileJava
:common:processResources
:common:classes
:common:jar
:spatialbackend:compileJava
:spatialbackend:processResources
:spatialbackend:classes
:spatialbackend:war
:spatialbackend:appengineExplodeApp
:spatialbackend:appengineStage
Reading application configuration data...
Jun 01, 2015 6:08:18 PM com.google.apphosting.utils.config.AppEngineWebXmlReader readAppEngineWebXml
INFO: Successfully processed /usr/local/google/gitbench/endgame/server/spatialbackend/build/exploded-app/WEB-INF/appengine-web.xml
Jun 01, 2015 6:08:18 PM com.google.apphosting.utils.config.AbstractConfigXmlReader readConfigXml
INFO: Successfully processed /usr/local/google/gitbench/endgame/server/spatialbackend/build/exploded-app/WEB-INF/web.xml
Beginning interaction for module spatialbackend...
Success.
Temporary staging for module spatialbackend directory left in /usr/local/google/gitbench/endgame/server/spatialbackend/build/staged-app
:gcloud:gcloudRunLocal
gcloudRunLocal=task ':gcloud:gcloudRunLocal'
:gcloud:gcloudRunLocal FAILED
FAILURE: Build failed with an exception.
[...]
-------------- Stack Trace for #2:
[...Note, this code path was executed because some of the module staged build
artifacts were missing due to Issue #1...]
Caused by: groovy.lang.MissingMethodException: No signature of method: java.io.File.absolutePath() is applicable for argument types: () values: []
Possible solutions: getAbsolutePath()
at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:55)
at org.codehaus.groovy.runtime.callsite.PojoMetaClassSite.call(PojoMetaClassSite.java:46)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:112)
at com.google.gcloud.task.app.AppTask.getAppPath(AppTask.groovy:52)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
-------------- Stack Trace for #3:
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/dev_appserver.py", line 83, in
_run_file(file, globals())
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/dev_appserver.py", line 79, in _run_file
execfile(PATHS.script_file(script_name), globals)
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/devappserver2.py", line 1002, in
main()
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/devappserver2.py", line 995, in main
dev_server.start(options)
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/devappserver2.py", line 794, in start
request_data, storage_path, options, configuration)
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/devappserver2.py", line 894, in _create_api_server
appidentity_oauth_url=options.appidentity_oauth_url)
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/api_server.py", line 391, in setup_stubs
auto_id_policy=datastore_auto_id_policy)
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/google/appengine/datastore/datastore_sqlite_stub.py", line 580, in init
app_id, trusted, root_path)
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/google/appengine/datastore/datastore_stub_util.py", line 2923, in init
self._xml_configuration = self._XmlConfiguration()
File "/usr/local/google/home/martyg/bin/google-cloud-sdk/platform/google_appengine/google/appengine/datastore/datastore_stub_util.py", line 2978, in _XmlConfiguration
'App has both XML and YAML configuration files: %s' % existing)
google.appengine.api.yaml_errors.AmbiguousConfigurationFiles: App has both XML and YAML configuration files: ['/usr/local/google/gitbench/endgame/server/default/build/staged-app/index.yaml', '/usr/local/google/gitbench/endgame/server/default/build/staged-app/WEB-INF/datastore-indexes.xml']
ERROR: (gcloud.preview.app.run) DevAppSever failed with error code [1]
:gcloud:gcloudRunLocal FAILED

Looks like some projects dependencies weren't being added because they had already been evaluated :, I'll push a fix for this on an update of this CL.
The devapp server stuff, I'm not sure what's going on. Taking a deeper look

lgtm

Squashed down commits. Carrying over LGTM.


create reminders about messages that have not been responded to

probably use task loop for this
Need to poll the database and check time passed since the mention. Perhaps a poll rate of 5 minutes where it checks if a certain amount of time has passed -- maybe like 1, 2,4,6,  hours etc... -- some kind of function that increases the amount of time between each notification.

implemented in f3ceaa0922d7c1c12b10b66d036cc2b46cb5afd7


HDMI Audio?

Is there any way to support HDMI Audio output with this, maybe with mostly static graphics (now playing or album art)?

It should be possible but I haven't implemented it.

I would love to have audio. Maybe I can help implement it?

@Wren6991 I'd like to look into the audio aspect, at the very least for my own projects.
Do you have a link to a reference where you got the info for the DVI/HDMI communications protocol?

I second the proposal to the HDMI audio, also where could we find information about technical implementation.

@Wren6991 I'd like to look into the audio aspect, at the very least for my own projects. Do you have a link to a reference where you got the info for the DVI/HDMI communications protocol?
@blueOkiris check https://www.intel.com/content/www/us/en/docs/programmable/683798/22-1-19-7-0/hdmi-overview.html
basically on the actual video stream, it has to be placed an additional audio frame (data island preamble-guard-audio-guard-video preamble)

https://github.com/shuichitakano/pico_lib (apparently a C++ fork of PicoDVI) has audio support.

https://github.com/shuichitakano/pico_lib (apparently a C++ fork of PicoDVI) has audio support.

I'm taking this info to add audio support to a project based on Wren's pico lib, it will be opensource.
For the time being I added something from there that was missing in current implementation which is to be able to start and stop DVI transmission without breaking.
I use it since I built an RGB2HDMI converter (for retro computers) and when there is no RGBHV signal I can stop HDMI after a while and allow HDMI screen to turn off.

@c1570 @Wren6991 I took the work on pico_lib From @shuichitakano and tried to honor the same flows.
DVI start stop works and DVI works if dataislands are not enabled.
Anyone wanting to collaborate?
https://github.com/mlorenzati/PicoDVI

The work can be merged back here from https://github.com/mlorenzati/PicoDVI, kudos to @shuichitakano


Contribution Guidelines

Pull Request Test Coverage Report for Build 147721832

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.685%

Totals

Change from base Build 147673963:
0.0%

Covered Lines:
142

Relevant Lines:
144

💛  - Coveralls

Pull Request Test Coverage Report for Build 147721832

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.685%

Totals

Change from base Build 147673963:
0.0%

Covered Lines:
142

Relevant Lines:
144

💛  - Coveralls

Pull Request Test Coverage Report for Build 147808134
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.685%

Totals

Change from base Build 147673963:
0.0%

Covered Lines:
142

Relevant Lines:
144

💛  - Coveralls


[stable/kiam] Add support to specify priorityClassName for agent and server pods

What this PR does / why we need it:
This PR allows user to set priorityClassName for agent and server pods. See k8s docs
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @davidkarlsen

ping @mattfarina, @scottrigby, @davidkarlsen

/cc @paulczar
/cc @cpanato
/cc @jlegrone

/ok-to-test

ping @mattfarina

/lgtm


Big newcomer: Next.js 3.0

See anouncement:
https://zeit.co/blog/next3#static-export-support
and tuto:
https://learnnextjs.com/excel/static-html-export

Feel free to open a PR @fhaller75 adding https://github.com/infiniteluke/next-static to the list


update for rails 5

Just had a look to see what this is about, because i am running 1.5.2 quite fine with rails 5.
So i guess this not needed, yes?

:+1:

Thanks for the PR @xiaopow. I realize this is an old PR but I would love to get it merged.

I am closing this as stale. We will get rails 5 support merged in soon with backwards compatibility for rails 3.x. Please feel free to reopen if you feel the need.


UnoCSS work with Tailwind or other preprocessors by just enabling the icons preset

I'm especially looking forward to this feature for nuxt 3. 🥰

what do you mean by other preprocessors ? in what preprocessors uno doesn't work ?

You can already do it,
UnoCSS({
  presets: [presetIcons()]
})

or in Nuxt
buildModules: [
  '@unocss/nuxt',
],
unocss: {
  uno: false,
  preflight: false,
  icons: true,
}

vite used
UnoCSS({
  presets: [presetIcons()]
})

console.log
[unocss] entry module not found, have you add import 'uno.css' in your main entry?

You will need to add import 'uno.css' in your entry

iam added some problem

im getting this too,
[unocss] entry module not found, have you add `import 'uno.css'` in your main entry?

with solidjs/ts-unocss

Hi @wommy  install the latest version of unocss
We fixed that a few weeks ago

i was on version 0.26.2 which as of now is only 10 days old
but the update did fix it, ill patch the solidjs starter soon

Is possible that when using tailwindcss(with uno: false of course), I can still make variants with icon classes like hover:i-twemoji-face-with-tears-of-joy work?

You can already do it,
UnoCSS({
  presets: [presetIcons()]
})

or in Nuxt
buildModules: [
  '@unocss/nuxt',
],
unocss: {
  uno: false,
  preflight: false,
  icons: true,
}

Is possible that when using tailwindcss(with uno: false of course), I can still make variants with icon classes like hover:i-twemoji-face-with-tears-of-joy work?

You can already do it,
UnoCSS({
  presets: [presetIcons()]
})

or in Nuxt
buildModules: [
  '@unocss/nuxt',
],
unocss: {
  uno: false,
  preflight: false,
  icons: true,
}

Is possible that when using tailwindcss(with uno: false of course), I can still make variants with icon classes like hover:i-twemoji-face-with-tears-of-joy work?

I tried now, it doesn't work for me.
 <div class="dark:i-ph-moon-duotone i-ph-sun-duotone" />

@productdevbook the dark: variant is implemented in the preset-uno (preset-mini more precisely). You can either copy the code to implement only the dark variant or import only variants from preset-uno

Still getting this issue with Storybook, though uno.css is imported

Ok, the issue seems to be in ordering of imports, when I moved import 'uno.css' to the top of the file the issue was resolved

im getting this too,
[unocss] entry module not found, have you add `import 'uno.css'` in your main entry?

with solidjs/ts-unocss

i got this problem when use vercel dev start local project，but use vite it will works fine

I'm getting this too.
vite.config.js:
export default defineConfig({
  plugins: [
    unocssPlugin(),
    unocss(),
    {
      ...(
        mdx({
          jsxImportSource: "solid-js",
          jsx: true,
          providerImportSource: "solid-mdx",
          rehypePlugins: [rehypeHighlight, remarkGfm],
        })
        //
      ),
      enforce: "pre",
    },
    solid({
      adapter: (await import("solid-start-static")).default(),
      extensions: [".mdx", ".md"],
      ssr: true,
    }),
  ],

  ssr: {
    external: ["ag-grid-solid"],
  },
});


Improve callback error handling

Platforms affected
All
Motivation and Context

Problems solved:

Allow users to get the stack trace for errors via cordovacallbackerror event
Remove redundant console logs

Description

Improve error handling.

Add 'original' parameter to the 'cordovacallbackerror' event so that users can view the actual original error.

This is extremely important so that users can get the stack trace for logging and debugging.

Removed the console logs.

They were redundant since the error is printed when it is thrown anyways.
console.log's without an option to turn them off can be annoying.

Testing

npm test

all passed.
Added test for this change.  (Passed)

Ran mobile spec before and after.

Test results were unchanged.
10 cordova-plugin-file-tests failed both times.  See screen shot.

If someone can tell me what to do to make those work I will re-run.
(I have the cordova-labs#cordova-filetranfer server running, and have set FILETRANSFER_SERVER_ADDRESS.  This fixed a couple tests.)

Manual testing.

See before and after photos of default output.
tested window.addEventListener("cordovacallbackerror", function (err) {

before:

after:

mobilespec:

Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

Created corresponding pull request with documentation here:
https://github.com/apache/cordova-docs/pull/1018

@Lindsay-Needs-Sleep Thanks a lot for your contribution and sorry for the late response! This does look like a good addition to me. I'll try to give this PR a thorough review in the following days. If I take too long, please remind me.
Maybe in the meantime @janpio can say something about the mobile spec failures. He might know a bit about that, IIRC.

Actually, I think something like this would be the nicest/cleanest option:
 } catch (err) {
    err.cordovaCallbackId = callbackId;
    err.cordovaCallbackSuccess = isSuccess;
    corodva.fireWindowEvent(“cordovacallbackerror”, err);
    throw err;
}

Pro’s:

This provides the information that was provided in ‘message’ in a much easier to use format.
It does not clobber the err’s message like my last suggestion.
The error is the top level object.

Cons

Not backwards compatible for someone was parsing the original ‘message’ string to get the callback Id and callback success state.

Reasons to do this despite the con:

Depending on parsing a string like that is bad practice. So likely (hopefully) very few people have done this.
cordovacallbackerror is completely undocumented.  So, this feature is even less likely to have been used/abused.
If someone was parsing message, it will be a small change to fix and will result in nicer code.

Thoughts? @erisu @raphinesse

Well, the message is not exactly clobbered. We only prepend a string. Which might be helpful for someone who doesn't know what's going on.
Adding callbackId and isSuccess as props would be nice. Why not return the error with added props and amended message?

Well, the message is not exactly clobbered. We only prepend a string. Which might be helpful for someone who doesn't know what's going on.

True, fair point.
My first thought was that we shouldn’t prepend the message incase some one was depending on the error message having an exact message.  (But that it almost the exact same thing I was saying we shouldn’t worry too much about :p)  But, the modified message is slightly more likely to cause an inconvenience to future people who expect an unmodified error message.  This is possibly a slight concern because this error is picked by window.onerror (which quite a few more people use I assume).  But this is still minor.
Since we have the stack trace included in the error, the first file reference will take you directly to where the error came from (which will be inside your success/error callback).  (You can see that in my attached screenshots).   This makes the majority of the prepended message  redundant.

Why not return the error with added props and amended message?

But I am fine with this as well if my points didn’t sway you. :p

Adding ‘callbackId’ and ‘isSuccess’ as props would be nice.

To further decrease our odds of accidentally clobbering someone’s custom error property (unlikely, but better to be a bit safer I think), we could do this instead as well:
err.cordovaCallback = { id: cordovaCallbackId, isSuccess: isSuccess }

@Lindsay-Needs-Sleep  Your points about messing with user's objects (in this case their errors) are good ones. I think with Cordova being a library, we should be as defensive as possible here. To me, that would mean:

return a new object (like before)
add the message property exactly like it was before
add the new error property with the original, unchanged error object
add callbackId
add a property callbackType with a value of either 'fail' or 'success'. That might be clearer than having isSuccess

I changed the "original" parameter name to "error" as suggested.

@Lindsay-Needs-Sleep Thanks again for this PR. :+1:

And thank you all for the feedback!
And you, @raphinesse, for improving the test. :)


Outline vision for Egeria deployment in the cloud for ODPi resource request

See https://www.ibm.com/cloud/garage/tutorials/use-develop-kubernetes-app-with-helm-toolchain?task=4 for an example of an example toolchain that could be integrated with a build process - ie going from source in github to a fully deployed cloud instance. Whilst we want more control for demo instances, this could be superb for testing - and gets many items in place for quick setup of other environments.
this example

only uses a single docker image - we will have multiple
deploys to IBM cloud -- but this could be replaced with alternative environments (assuming based on docker+kubernetes)
uses minikube locally - this is effectively deprecated now, since docker CE comes with kubernetes as standard (mac, windows)

As such it can't be used as-is - but is an indication of the kind of thing we could do.
One aspect in common across all these environments, and requirements, is that docker+kubernetes, and to some extend helm, are becoming the core OS environment. Our development activities should focus on enabling that.

Closing for now.
We are having discussions about testing in general, whilst deployment is focussed on our current helm charts
Will re-open when we have something actionable


Add warning message for abnormal vote counts

There are myriads of abnormalities in the results. This exceeding number of vote counts is one of them. I suggest that we should warn the viewer that this weird result is probably incorrect.

I would suggest using this description:
พบความผิดพลาดในข้อมูลของกกต. รอการตรวจสอบอีกครั้ง

We may go for that, as it clearly states the responsible entity for this error, which in this case is likely to be กกต. Having said that, the error might be from our side, so I think we might not be able to mention the source of the error. What do you think?
Anyway, it seems that กกต. has resolved the issue. Hopefully, we won't see this error again ... but who knows?

agreed, I'm going to merge anyway.  Thank you very much for your contribution, although the election has already finished.


Fonts are broken on windows

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10
Hyper.app version:  3

Issue

The fonts are broken.

I am experiencing the same thing when running some things in hyper even when I am using mac

Try webGLRenderer: false


nt-client does not work on Windows

While integrating ntp-client with cardano-wallet https://github.com/input-output-hk/cardano-wallet/issues/1394 we have learnt that ntp-client currently does not work on Windows platform (tested on Windows 10 VM).
The error reported is:
ntp client experienced error Network.Socket.recvBufFrom: failed (Invalid argument (WSAEINVAL)) when using IPv4 protocol

Please also note that, while working on the integration we also had observation that the ouroboros-network/ntp-client library is missing tests on error paths -> https://github.com/input-output-hk/cardano-wallet/issues/1394#issuecomment-595084104

Related to #1548


feat(watcher): Allow using braces in watcher

Expands braces in watcher, so you can watch: ['a/{b,c}'] which would
expand to ['a/b', 'a/c']
Closes #1249

Still does not work with globs such as:
  'src/{bindHtml,position}/**/*.js',

DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/src/{bindHtml,position}"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/src/bindHtml"

DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/src/position"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/src/typeahead"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/template/bindHtml"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/template/position"
DEBUG [watcher]: Watching "/Users/dmitrizaitsev/Dropbox/p/WebDev/Repos/angular-ui-bootstrap/template/typeahead"

@dmitriz
What version of karma you use?

Sorry, should have mentioned:
$> karma --version; node -v; npm -v
Karma version: 0.12.31
v0.12.2
2.7.4

@dmitriz Thanks!
That feat was merged to canary branch. You can install canary version of karma and all should work
npm install karma@canary

Thanks - that work brilliantly!
How about mention it here - can help others:
http://karma-runner.github.io/0.12/intro/installation.html


Getting same Error Not enough points to compute AUC.

Not enough points to compute AUC.
----- 0 PRO-AUROC: N/A (MAX:N/A)
INFO:main:Instance AUROC: 0.837
INFO:main:Full Pixel AUROC: 0.942
INFO:main:Anomaly Pixel AUROC is None. Skipping logging.
INFO:main:instance_auroc: 0.837
INFO:main:full_pixel_auroc: 0.942
INFO:main:anomaly_pixel_auroc: None
How to solve it ?

I havn't met such problem, recommend trying "pdb" to debug


Avoid potential deadlock when running cqlsh

As described in the [documentation] (https://docs.python.org/2.7/library/subprocess.html#subprocess.Popen.wait), using p.wait() may result in a deadlock. This seems to happen quite regularly on Windows, although I did see it once on Linux too. The solution is quite simple, just use p.communicate() instead. This should be safe provided the input and output can be buffered in memory.

Thanks Stefania.


Bugfix: Show "Edit my profile" if the user has already a dev profile

Fixes #229
-> In the developers index, show "Edit my profile" in the CTA button if the user has already a developer profile

Pull request checklist

[X] Your code contains tests relevant for code you modified
[X] You have linted and tested the project with bin/check

Hey @salochara, do you still have appetite to make my requested changes? If not, no worries, I can take over. Just let me know.

Hey @joemasilotti 👋
Sorry. I haven't been able to get to this.
Yeah.. it'd be better if you can take it over.
I'll definitely try to keep on contributing once things stabilize on my side!

@joemasilotti Can I work on this? I can have this done this weekend.

Go for it! Thanks for the heads up.
I think all that's left is extracting the logic to a view component and changing the icon to a pencil for Edit.

@joemasilotti added #301 fixing everything in #229
It was easier to just create a new clean branch.


Constraining doc build requirements

Issues with unexpected changes in python requirements have plagued us before. It's better to be proactive about this and constrain versions to a sensible range, so we don't get surprise build failures at some point.

recheck

recheck

recheck

recheck

/retest


PowerShell Completion label has changed from powershell to power-shell.

Steps to Reproduce

Install Rye 0.34.0
Type rye self completion --shell powershell

Expected Result
Get output about powershell completion.
Actual Result
# rye self completion --shell powershell
error: one of the values isn't valid for an argument

Version Info
# rye --version
rye 0.34.0
commit: 0.34.0 (d31340178 2024-05-20)
platform: linux (x86_64)
self-python<EMAIL_ADDRESS>symlink support: true
uv enabled: true

Stacktrace
No response

In Rye document
-s, --shell <SHELL>: The shell to generate a completion script for (defaults to 'bash')

[possible values: bash, elvish, fish, powershell, zsh, nushell]

In help command
# rye self completion --help
Generates a completion script for a shell

Usage: rye self completion [OPTIONS]

Options:
  -s, --shell <SHELL>
          The shell to generate a completion script for (defaults to 'bash')

          Possible values:
          - bash:        Bourne Again SHell (bash)
          - elvish:      Elvish shell
          - fish:        Friendly Interactive SHell (fish)
          - power-shell: PowerShell
          - zsh:         Z SHell (zsh)
          - nushell:     Nushell

  -h, --help
          Print help (see a summary with '-h')

Thanks, that was a bug introduced when we added Nushell. Will fix.


Unable to set priority for FCM templated messages

Describe the bug
In order to set priority for FCM messages, one needs to declare the priority tag on the same level as the data tag or, in the latest version it should be under the android tag. When using FcmTemplateRegistrationDescription with such template, an exception System.Xml.XmlException: There are multiple root elements is raised though.
Exception or Stack Trace
System.AggregateException: One or more errors occurred. (There are multiple root elements.)
 ---> System.Xml.XmlException: There are multiple root elements.
   at System.Xml.XmlExceptionHelper.ThrowXmlException(XmlDictionaryReader reader, String res, String arg1, String arg2, String arg3)
   at System.Xml.XmlBaseReader.EnterScope()
   at System.Runtime.Serialization.Json.XmlJsonReader.ReadNonExistentElementName(StringHandleConstStringType elementName)
   at System.Runtime.Serialization.Json.XmlJsonReader.Read()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r, LoadOptions o)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at Microsoft.Azure.NotificationHubs.FcmTemplateRegistrationDescription.OnValidate()
   at Microsoft.Azure.NotificationHubs.RegistrationDescription.Validate(Boolean checkExpirationTime)
   at Microsoft.Azure.NotificationHubs.RegistrationSDKHelper.ValidateRegistration(RegistrationDescription registration)
   at Microsoft.Azure.NotificationHubs.NotificationHubClient.CreateOrUpdateRegistrationImplAsync[TRegistration](TRegistration registration, EntityOperatonType operationType, CancellationToken cancellationToken)

To Reproduce
Steps to reproduce the behavior:

Create FcmTemplateRegistrationDescription with template like this:

{
    "data":{
        "message":"$(message)",
    },
    "priority":"high"
}

Call CreateOrUpdateRegistrationAsync

Code Snippet
The code snippet that causes the issue.
var hub = NotificationHubClient.CreateClientFromConnectionString("put your connection string here", "your hub name");
var registration = new FcmTemplateRegistrationDescription(token, @"
            {
	            ""data"":{
		            ""message"":""$(message)"",
	            },
	            ""priority"":""high""
            }");
registration.RegistrationId = await hub.CreateRegistrationIdAsync();
await hub.CreateOrUpdateRegistrationAsync(registration); //will raise exception

Expected behavior
The template should be accepted, or there should be another option to set properties such as priority (or any other of the dozens of properties)
Setup (please complete the following information):

OS: Windows 10
IDE : Visual Studio 2019
Version of the Library used: 4.1.0

Additional context
I believe the problem lies in the FcmTemplateRegistrationDescription.OnValidate, line 294, which explicitly requires to have only 1 root.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Actually looks like I have found the problem - the error returned by XmlReader is misleading. The problem was in the extra comma after the message tag. Removing it it has worked as expected. Took me half day to figure out and only saw that after re-reading this post.
Closing the issue - misleading error is not relevant to this library anyway.


Added ability to shutdown nodejs servers gracefully

Gracefully shutting down APIServer
Gracefully shutting down ServiceBroker

Normally there should be a test added especially for the keep-alive, but we can go without it for now.


Avoid using unavailable APIs when linking against app extension targets.

When using Bolts in an app extension development. Some Blots classes have references to [UIApplication sharedApplication] which is not available in an app extension target.
Need a way to avoid the unavailable API usage when linking against app extension targets. Maybe a macro for conditional compile?

Or please separate two subspecs: Tasks and AppLinks. The AppLinks is not needed for extension anyway.

+1 Two subspecs would be very nice. Tasks and AppLinks are independent from each other, and I would like to use Tasks in static libraries as well.

two subspecs +1 ;)

See #60 for the specs issue

Fixed by #94


[Question] Build the database based on the graphql scheme

Thank you so much for this tutorial! I started off using DynamoDB and realized I needed a relational database which lead me to this example.
Is there a way to build the database based on the graphql scheme? When I was using DynamoDB it would build the database which was great; similar to what sequelize does.
Thanks again!

Thanks for the feedback. This quick start only demonstrates how you can use AWS AppSync with a relational database. It does not provide GraphQL -> SQL code generation capabilities.


Upload image doesn't get uploaded for books or shelves

Describe the feature you'd like
https://github.com/BookStackApp/BookStack/issues/4275
Describe the benefits this would bring to existing BookStack users

Can the goal of this request already be achieved via other means?

Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?
Not using yet, just scoping
Additional context

There is no issue related to this,
bookstack working properly in BookStack: version 24.10.2
This is My Docker Compose File
services:
  bookstack:
    image: lscr.io/linuxserver/bookstack:latest
    container_name: bookstack-linuxserver
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Etc/UTC
      - APP_URL=http://localhost:6876
      - APP_KEY=bhjdkslairueydgshcbdgeudhbdjloyg
      - DB_HOST=<IP_ADDRESS>
      - DB_PORT=3306
      - DB_USERNAME=bookstack-test
      - DB_PASSWORD=bookstack-test
      - DB_DATABASE=bookstack-dev
      - QUEUE_CONNECTION= #optional
    volumes:
      - ./BookStack/.env:/config/www/.env
      - ./BookStack/storage/logs/laravel.log:/config/log/bookstack/laravel.log
      - ./BookStack/storage/backups/:/config/backups/
      - ./BookStack/storage/uploads/files/:/config/www/files/
      - ./BookStack/storage/uploads/images/:/config/www/images/
      - ./BookStack/themes/:/config/www/themes/
      - ./BookStack/public/uploads/:/config/www/uploads/
    ports:
      - 6876:80
    restart: unless-stopped
    networks:
      - bookstack_default

networks:
  bookstack_default:
    external: true

Check the Path you provide for volume


Accessing any route with the word backup in it attempts to list backups

I've been able to reproduce this on v0.5.0 of longhorn and on the master versions of all of the longhorn components.
The main way to encounter this issue is by creating a volume named backup and attempting to view its information. This will take you to the route /volume/backup, which triggers the logic that the longhorn-ui uses to attempt to list off Backups. This applies to other routes too, so appending backup to the dashboard route to obtain /dashboard/backup, while it returns the 404 page, still triggers the Backup list logic.
This means that if the Backup Target Setting is unset, the error notification for it being unset will pop up. If there's an issue accessing the Backup Target to list the Backups, that error notification will pop up. Nothing occurs on the page if accessing the Backups page would've been successful.

Nice catch @ttpcodes ! @smallteeths Can you take a look at what's happened?

Steps to test:

Make sure Backup Target Setting is unset.
Create a volume named backup

/volume/backup path in longhorn ui should go to volume details page.
/dashboard/backup should return 404 error.
in both cases, you should NOT be able to see error listing backups: error listing backup volumes  notification


Drop search connection early for ldap service registry during updates

LDAP service registry opens to connections when attempting to update services: one to search and one to modify. This patch closes the first connection early before attempting to obtain the second connection. If the ldap instance does not allow connection pooling, (or if the pool size is set to 1) the current behavior causes updates to hang.

This should be ported over to all branches.

+1


Restructure thread closing

Description:
The Thread object has 3 ways to complete:

destroyThread -- which may as well terminate the thread if timeout expires;
shutdownThread -- same as destroy, but with infinite timeout. As well it may differ in each class implementation;
completionWait -- waits the thread to complete the job without terminating it.

These might be a little confusing for developers and in most cases it nearly does same thing. For this reason, these 3 methods should be merged in one function, for example, all in shutdownThread. As well, all object that call these methods should be reviewed and probably a little bit restructured.

Restructured threads in #241
No more an issue.


fixes #126

It's not necessary to open issue and PR separately, unless the issue itself is in need of discussion.
Please rebase this branch against upstream/master so that the PR only contains the commit 35f6cdf, and not all of those merge commits.

link #126

Sorry Rodney, pretty new to Github. Working on getting you a clean pull request.

Sorry Rodney, pretty new to Github.

no worries… it's not like I know what I'm doing, either ;)

Working on getting you a clean pull request.

If you guys want to continue contributing changes (which I'd much appreciate!), I'd suggest you throw away your origin/master and start new from upstream/master. And then keep that branch clean (i.e. don't git merge upstream/master as suggested by syncing a fork, but git rebase upstream/master instead). Otherwise branch off upstream/master (after running a git fetch upstream) for your PRs.


style: Added relevant icons for preferences UI #4902

Description
Added appropriate icons (SVG) to the preferences fragment UI. SVGs (most) used (and edited) from svgrepo. Appropriate licensing was checked to allow change and use of the SVG.
Related issues
Fixes #4902
Screenshots

Link to the automatically generated build APK

Thank you! 🎉

I'm a bit annoyed because they clearly lack consistency (eg the lines have a different thickness) with material icons which we use throughout the app


git diff HEAD is an ambiguous argument

Question asked by @sindyoke from https://github.com/githubschool/sleepy-koala/issues/15#issuecomment-297096336
$ git diff HEAD
fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tr
ee.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

@sindyoke this may be because you had no history on this repository.


Make eventHandlers uid parameter dynamic instead of int

This line  await engine.joinChannelWithUserAccount(null, this.gameID.toString(), userId); allows you to join a channel with a string instead of an int.
However when you create event handlers, (userJoined, userOffline) the uid variable is an int not a string.
Could we make this variable dyanmic instead so it reports back the correct uid?

the uid in the callback is always int, you can use getUserInfoByUid


Establish a simple release workflow via CI

Feature request
The project should have a simple solution for providing

automatically increase semver
latest changes via npm so that fixes/features are always available
pre-releases using npm dist-tags
only deploy releases when there are changes that need to be deployed -> That's the most "pressing" issue with the current flow using standard-version as this always increases the version number and therefor deploys, even if there were only changes made to the dev dependencies or CI
automatically create GitHub releases
auto-generate Changelog
Easy so figure out so that "onboarding" isn't too complicated

Proposed solution
Check out semantic-release for an easy and "standardized" solution.

Fixed with #85


Go to definition on network drives not working

Following configuration:
Windows 10 Pro, 10.0.1563 Build 15063
VS Code: 1.31.1
C/C++ Extension: 0.22.2
If my Project is placed on a Network drive, the go to definition functionality is not working properly. The popup window "no definition found" appears. Additionally files open with ist filenames in uppercase letters (f.e. ioport.h opens as IOPORT.H)
Working with the same Project on a local drive, everything works fine, so I assume c_cpp_properties.json is set correctly:
 {
            "name": "Win32",
            "includePath": [
                "${workspaceFolder}/**",
                "${workspaceFolder}",
                "../linux-4.15.16_include_linux"
            ],
            "defines": [
                "_DEBUG",
                "UNICODE",
                "_UNICODE"
            ],
            "intelliSenseMode": "msvc-x64"
}

Solution was found, hope this helps other VS code sympathizers:
Network drive has to be mapped to a local drive letter!
Example:
\\anydriver\dir1\dir2\myproject                            does not work
X:\anydriver\dir1\dir2\myproject                           works!

Please file this issue against the c++ extension


[MSY2 MINGW64] Styles structures are problematic

These structures are not properly exposed and not accessible either with shared or static version of the library:
vaca::Widget::Styles::
vaca::Frame::Styles::
vaca::MdiClient::Styles::
vaca::TextEdit::Styles::
vaca::SplitBar::Styles::
vaca::TreeView::Styles::
The use of constexpr maybe the problem.
Update: it's very likely that constexpr is causing the problem, a quick Google searched showed constexpr doesn't work with __declspec(dllexport) and __declspec(dllimport). Strangely enough, these structures are not exposed and accessible on the static version of the library too.

Fixed removing the VACA_DLL (dllimport/export) to the Styles struct. It looks like a new issue with MinGW introduced after changing the Styles to constexpr.
Now vaca is compiled correctly with msvc/mingw/msys/clang: https://github.com/dacap/vaca/actions/runs/4674104463


Remove developer preview verbiage

I believe all of the calling and meeting bot APIs and app manifest parameters are GA, and not in developer preview any longer. If true, the developer preview verbiage needs to be scrubbed from all of the documentation for calling and meeting bots.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac64d14f-aec8-9dd6-e987-d2325de46fd6
Version Independent ID: ba050a58-d98a-68f7-3190-8001d2a9d12c
Content: Register calls and meetings bot for Microsoft Teams - Teams
Content Source: msteams-platform/bots/calls-and-meetings/registering-calling-bot.md
Product: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

Thanks for reporting it. We are checking it and will update the documentation if required.

Redirecting to the doc team for updating the part


feat: move nested reference logic to executor (keep config w/ verifiers)

Description
What this PR does / why we need it:
This PR moves the nested references logic out of plugins and into the executor while keeping the nestedReferences config values with Verifiers. There is no effective behavior change but it provides a clearer code execution. This lays out the initial changes for decoupling nested references from verifiers

Moves verifying nested references out of pkg/verifier/plugin/plugin.go and into pkg/executor/core/executor.go
Removes executor from Verifier.Verify()
adds GetNestedReferences method for verifiers

notary signature verifier method returns empty slice because signatures should not check nested references

adds tests for nested references

TestVerifySubject_NoNestedReferences_Expected
TestVerifySubject_NestedReferences_Expected

adds a test memory store to enable testing for nested references
Removes/modifies outdated nested references tests from of pkg/verifier/plugin/plugin_test.go

modifies existing test and adds one to check for IsSuccess (please comment if these tests were doing more than I thought, as they were not clear on what they were trying to accomplish. They appeared to be related to nested references but only checked for errors and IsSuccess)

Adding nested references to Verifiers works the same as before:
k8s
apiVersion: config.ratify.deislabs.io/v1alpha1
kind: Verifier
metadata:
  name: verifier-sbom
spec:
  name: sbom
  artifactTypes: org.example.sbom.v0
  parameters:
    nestedReferences: any-string-here-enables-nested-references

cli
      {
        "name": "sbom",
        "artifactTypes": "org.example.sbom.v0",
        "nestedReferences": "any-string-here-enables-nested-references"
      }

Which issue(s) this PR fixes:
related to https://github.com/deislabs/ratify/issues/192
Type of change

[X] Cleaner execution flow (non-breaking change)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[X] TestVerifySubject_NoNestedReferences_Expected - executor
[X] TestVerifySubject_NestedReferences_Expected - executor
Modifies pkg/verifier/plugin/plugin_test.go as nested references are removed

Checklist:

[X] Does the affected code have corresponding tests?
[X] Do all new files have appropriate license header?

Hi @joshuaphelpsms，looks like there there is conflict that needs to be resolved. Could you take a look ? thanks!

Hi @joshuaphelpsms，looks like there there is conflict that needs to be resolved. Could you take a look ? thanks!

@susanshi No problem. It is resolved now

@akashsinghal , just want to check with you this is good to merge.  I wonder if this PR has anyoverlapping changes with RC prs which could make cherry picking messy

@joshuaphelpsms Can you re-base?


Kaspersky

Win.10.2<IP_ADDRESS>

when starting the script , Kaspersky sees it as a virus and remove it .

LOL.
Warning: Some third-party Antivirus may detect this script or it's part as a false positive due to this variable:
https://github.com/farag2/Windows-10-Setup-Script/blob/298307bafee70b55ea00d9cba7a9e14ea6e4f5a4/Win 10 2004.ps1#L2689
So you might need to disable tamper protection from your Antivirus settings (or use Microsoft Defender, cos it's much better) and re-enable it after run the script and reboot.

ah i see!

I'll try to avoid that method in the next release


Create chatops-binder.yaml

Please ensure your pull request adheres to the following guidelines:

[ ] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[ ] Updated documentation of features that add new functionality.
[ ] Update CHANGELOG.md with major/minor changes.

/binder


[Bug] Border controls missing if a child div inherits a border color class from a parent

It seems like if a border is applied to a parent class, the child shows the border color (in this case perhaps it's an issue here #118) @Kitenite  for comment

Border color is not an inherited property and should be treated as such. This is likely a bug and likey related to https://github.com/onlook-dev/onlook/issues/118

Closing as this is fixed as part of editor enhancements


fix(clerk-js): Properly show the deprecation warnings for usage of limit and offset

Description
Previously the deprecation warnings will be used when limit or offset was not used.

Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Nice 😅

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Webpack Issues

Steps to Reproduce

Set up a Node.js project with @dsnp/parquetjs as a dependency.
Configure Webpack for the project with the following settings:

Target: 'node'
Output library target: 'umd'
Entry: [Point to the main file of the test package]

Include the import statement const { ParquetWriter } = require('@dsnp/parquetjs'); in the main file.
Run Webpack to bundle the project.
Execute the bundled code.

Expected Behaviour
The application should bundle without errors and the @dsnp/parquetjs module should be correctly imported and functional when running the bundled code.
Actual Behaviour
Upon running the Webpack bundle, the application throws an error: Error: Cannot find module 'util'. This suggests that Webpack is unable to resolve the util module, a core Node.js module, which is required by @dsnp/parquetjs or its dependencies.
Any Logs, Error Output, Etc.?
Error: Cannot find module 'util'
    at t (index.js:2:2329285)
    at 86275 (index.js:2:2327909)
    ... [Additional stack trace] ...
    at 19785 (index.js:2:565811) {
  code: 'MODULE_NOT_FOUND'
}

Any Other Comments?

Attempts to resolve the issue by adding a fallback configuration for util in Webpack did not succeed.
The project works as expected without Webpack bundling.
This issue seems to arise specifically when using @dsnp/parquetjs in a Webpack-bundled Node.js environment.
Any insights or recommendations on configuration changes or workarounds would be greatly appreciated.

There might be an easier way, but I think you have to map it to the browser distribution via alias in the webpack config. Assuming you want to webpack it without also doing the browserification part as well.
via: https://github.com/LibertyDSNP/example-client/blob/main/config/webpack.config.js#L308-L316
webpack.config.js
return {
// ...
    alias: {
        "@dsnp/parquetjs": path.resolve(
            __dirname,
            "..",
            "node_modules",
            "@dsnp",
            "parquetjs",
            "dist",
            "browser",
            "parquet.cjs.js"
        ),
    // ...
    }

This still doesn't seem to work causing an error
TypeError: Cannot read properties of undefined (reading 'webkitRequestFileSystem')
@wilwade

Hmm..

Can you share your webpack config file?
What version of webpack are you using? My example was from Webpack 4. I'm not sure what the equivalent would be in Webpack 5.

Here is what the webpack config looks like
const path = require('path');
const libExternals = {
}
const streamWorkerPackage = {
    entry: ['./packages/stream-workers/index.js'],
    target: 'node',
    output: {
        path: `${process.cwd()}/bin/stream-workers`,
        filename: 'index.js',
        libraryTarget: 'umd'
    },
    resolve: {
        symlinks: false,
        extensions: ['.js', '.json'],
        alias: {
            "@dsnp/parquetjs": path.resolve(__dirname, 'node_modules', '@dsnp/parquetjs', 'dist', 'browser', 'parquet.cjs.js')

            // "@dsnp/parquetjs": path.resolve(
            //     __dirname,
            //     "..",
            //     "node_modules",
            //     "@dsnp",
            //     "parquetjs",
            //     "dist",
            //     "browser",
            //     "parquet.cjs.js"
            // ),
        }
    },
    externals: {
        ...libExternals
    }
}
module.exports = [
    streamWorkerPackage
];

and I am using versions listed here:
"webpack": "5.90.1",
"webpack-cli": "5.1.4"

@thekevshow Hmm... Is this for a library or for a direct web application?
If it is a library, then I would suggest a different route to get a better build: Handle the shims directly. So Parquetjs takes a lot of node libraries to work. The browser edition is designed to be used directly in a script tag, or in some cases in a build where you know there are no need for the build to otherwise shim those node packages.
Might also help to get a trace for that TypeError: Cannot read properties... error. This sounds like a Webkit issue and I am very out of date on my webkit.

This is not for a web application it is for an AWS lambda which we are webpacking to bundle everything into for cost saving and cold time reducing pieces here. For all intensive purposes it is a nodejs application. Testing was done locally with the webpack result. @wilwade but that makes sense appreciate it.


[Foundation] Bridge difference APIs between Foundation and swift stdlib

We need this to fix a source compatibility issue when building with Xcode 11 beta 1.
(Note: The second commit reverts availability to 9999 while we're working to land #25230; it will need to be reverted once that lands.)
rdar://problem/51604652

@swift-ci test

@swift-ci test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - 89b918a35a67cede05065285daf14e41ea31aea3

FAIL: Swift(appletvsimulator-x86_64) :: PrintAsObjC/mixed-framework-fwd.swift
Seems to be a temporary hiccup (51610004). Let's try that again.
@swift-ci test macos platform

So, uh, full PR testing has been down for a while. thisisfine.png
@swift-ci smoke test


[stdlib-private][oslog] Remove OSLogArguments.serializeAt method

and instead directly access the array stored in OSLogArguments. This will make constant folding of the arguments array possible when its contents are inferred at compile time by the OSLogOptimization pass.

@swift-ci Please test and merge


influxd requires SIGINT to exit

influxd will hang indefinitely when running the config, help, and version commands.
It seems to only be a problem with top level commands, help [command] works as expected.

Confirmed -- I've seen this. The system should exit when passed -h.

This is fixed. I don't know what fixed it, but I no longer see the behaviour I saw before.


Remove requirement for aggregates to implement [de]serialize

Aggregates are now default-[de]serialized to the tupleof of their members by default.
Any aggregate wishing a special handling can do so by defining '[de]serialize' as before.
Additionally, `DefaultSerializer` and `DefaultDeserializer` have been removed,
as they are now redundant with the default.

Fixes #432
The serialize / deserialize methods haven't been removed yet, as there are some more room for improvements (in particular for deserialization) that require some more research.

Hope it doesn't break anyone's PR. 🤞


Add support for the Advanced Web Interface

Your styles are really great and I love both of them ❤
But I'm a little bit sad that they don't work when using extended webinterface… Can you or someone make them also work with that? Kind regards and greetings from Germany 🇩🇪

I'm not planning to add support for the advanced web interface for now. But I might get on it at some point :)

Initial support for the advanced web interface has been added in Tangerine UI v2.0.0-prerelease2 https://github.com/nileane/TangerineUI-for-Mastodon/releases/tag/v2.0.0-pre2

Thanks for this! ❤ I tipped you a Ko-fi.


Torque3D CI server

BeamNG has offered CI servers to test Torque3D.
Sorry for all problems i causing while I configure everything.
Actually all pull request are tested against:

Windows8/MSVC2013 release build.
Dedicated server - Ubuntu with gcc and clang.

Todo:

[x] Ubuntu/clang (dedicated server)
Windows/VS2008
[ ] Run unit tests
[ ] Generate script documentation

Looking into unit tests.

@LuisAntonRebollo @Areloch - Can we close this?


Board view: Show due dates for today in another colour

Expected behaviour
I'd like to have the due date of the tasks due for today shown in a colour that is different from the one of past-deadline tasks. Green or blue could be a good choice.
Actual behaviour
Current tasks that are due today have their due date coloured in red, just like tasks that are already in the backlog.
Configuration
Copy and paste the configuration section from the Kanboard settings page or fill these fields:

Kanboard version: 1.0.25-framaboard
Database type and version: sqlite, version unknown
PHP version: Unknown
OS: Windows 7 x86_64
Browser: Google Chrome 50.0.2661.102 m

This is now part of master.


belindas-closet-android_3_120_create-categories-for-other-clothing-types

This PR adds more categories for all of the other clothing types to the home page.
https://github.com/SeattleColleges/belindas-closet-android/assets/77591083/83889dad-0020-4b71-8dd2-8703b3455072

Hey @heosman, I think the image in this screenshot is causing the error in the unit tests:

I would try using another image. You will need to close and open this PR once you push the new commit to this PR's branch to retrigger CI tests.

Hey @heosman, I think the image in this screenshot is causing the error in the unit tests:  I would try using another image. You will need to close and open this PR once you push the new commit to this PR's branch to retrigger CI tests.

I was stuck on that, thank you for the tip!


Height inline style should have !important to override everything

In my widget I had to use !important everywhere to reset the style of the parent. By doing that, when the autoresizer sets the inline style, it doesn't get overridden because of the !important tag.
Can I contribute to add it?

Sure.  The issue is that the inline style this library sets, doesn't override these 2 values above.

I guess this:
https://github.com/Andarist/react-textarea-autosize/blob/61ca826a3fbe33abb9c67885d5bbd7b34ecd66db/src/index.tsx#L78
could be changed to:
node.style.setProperty(height, `${height}px`, 'important');

Correct. That's what I was about to do in PR.
What do you think?

Let’s try this

Done, let me know what you think 👍

Closed by https://github.com/Andarist/react-textarea-autosize/pull/278 . Releasing this might take a me a few days though. Thanks for your contribution!

FWIW, i don't think this was a good change
needing to use !important everywhere is an anti-pattern, and adding it to an inline style makes it impossible to override with any other CSS

FWIW, i don't think this was a good change
needing to use !important everywhere is an anti-pattern, and adding it to an inline style makes it impossible to override with any other CSS

This component is all about controlling its height - it should have the ultimate power to set it and if you want to influence what height does it have then you should do it through its available props.

This component is all about controlling its height - it should have the ultimate power to set it and if you want to influence what height does it have then you should do it through its available props.

@Andarist thanks for the reply. i don't disagree with that, but you were already pretty much doing it by using an inline style
i don't think this was an issue that needed to be fixed in your original implementation, but rather it's an issue with the CSS structure the issue-opener was using
in any case, would you accept a PR to make this optional at least? it's a problem for me because there are cases (as i'm sure you can imagine) where it's useful and/or necessary to override the height

@Andarist thanks for the reply. i don't disagree with that, but you were already pretty much doing it by using an inline style
i don't think this was an issue that needed to be fixed in your original implementation, but rather it's an issue with the CSS structure the issue-opener was using
in any case, would you accept a PR to make this optional at least? it's a problem for me because there are cases (as i'm sure you can imagine) where it's useful and/or necessary to override the height

Could you post a real-life scenario in which this is causing you trouble? I firmly believe that we should have control over our own height and !important helps us to achieve that.

Could you post a real-life scenario in which this is causing you trouble? I firmly believe that we should have control over our own height and !important helps us to achieve that.

so the primary issue for us is in Storybook snapshot testing components which are using the resizable textarea. the height calculation is sometimes different by a pixel or two, which is causing false positives (the snapshots aren't exact matches so it's considered a "failed" test)
there are a few potential reasons why the height is calculated differently (like the timing of font loading, etc), but since the resizing functionality is unimportant as far as static snapshots are concerned, we have until now just overridden the height with !important in a Storybook-only stylesheet
now, when !important is added to the inline style it is impossible to have a rule with greater specificity so this workaround isn't possible

so the primary issue for us is in Storybook snapshot testing components which are using the resizable textarea. the height calculation is sometimes different by a pixel or two, which is causing false positives (the snapshots aren't exact matches so it's considered a "failed" test)
there are a few potential reasons why the height is calculated differently (like the timing of font loading, etc), but since the resizing functionality is unimportant as far as static snapshots are concerned, we have until now just overridden the height with !important in a Storybook-only stylesheet
now, when !important is added to the inline style it is impossible to have a rule with greater specificity so this workaround isn't possible

From my PoV you try to hack this around - I understand that it would be simpler but that doesn't change the nature of what you are trying to do. Your visual snapshot is flaky and you should stabilize the test by awaiting whatever influences the textarea's size. You could also just raise the diff threshold that would accept this subtle difference.

From my PoV you try to hack this around - I understand that it would be simpler but that doesn't change the nature of what you are trying to do. Your visual snapshot is flaky and you should stabilize the test by awaiting whatever influences the textarea's size. You could also just raise the diff threshold that would accept this subtle difference.

so are you saying that you would NOT accept a PR to make this optional?

so are you saying that you would NOT accept a PR to make this optional?

Yeah - I don't think this is something I'd like to support here (unless some other compelling argument is made that I should).

Yeah - I don't think this is something I'd like to support here (unless some other compelling argument is made that I should).

it feels oddly inconsistent that you see this as an issue that should be solved outside of your package, but don't apply the same consideration to the original issue that led to this change in the first place. both are arguably edge-cases, but this package clearly worked fine for a majority of users before this sweeping change so it's certainly disappointing to get this kind of response
unfortunately this package doesn't give us enough control over the rendering to consistently prevent this sizing issue, and even if we could adjust the diff threshold it doesn't help because the change in height shifts location of all elements rendered below the textarea
anyway, i think it's better that we switch to a package (it's worth noting that none of the alternatives to this package are doing the inline !important "hack") maintained by someone with a little better understanding of CSS and best practices for open-source packages anyway, so that we don't run into any other conflicts like this in the future
thanks for your time, and good luck!

it feels oddly inconsistent that you see this as an issue that should be solved outside of your package, but don't apply the same consideration to the original issue that led to this change in the first place. both are arguably edge-cases, but this package clearly worked fine for a majority of users before this sweeping change so it's certainly disappointing to get this kind of response
unfortunately this package doesn't give us enough control over the rendering to consistently prevent this sizing issue, and even if we could adjust the diff threshold it doesn't help because the change in height shifts location of all elements rendered below the textarea
anyway, i think it's better that we switch to a package (it's worth noting that none of the alternatives to this package are doing the inline !important "hack") maintained by someone with a little better understanding of CSS and best practices for open-source packages anyway, so that we don't run into any other conflicts like this in the future
thanks for your time, and good luck!

I agree that maybe I could dismiss the original request but it made sense to me (and still makes) that we should be solely responsible for managing our height - that's the core responsibility of this package and as such, I don't want it to be indirectly overridden from the outside without the package even knowing about it.

anyway, i think it's better that we switch to a package (it's worth noting that none of the alternatives to this package are doing the inline !important "hack") maintained by someone with a little better understanding of CSS and best practices for open-source packages anyway, so that we don't run into any other conflicts like this in the future

This comment is outright rude and you should reconsider using such rhetoric in the future. Other people do not have to always agree with your technical decisions, nor you have to agree with technical decisions made by others. More often than not there is just no single perfect answer to the problem. Everything is a tradeoff.
Open source is still managed by people that have to manage their own time & preferences while trying to help others by sharing what they have done. This doesn't mean that every single feature request or anything else will make it to the package. If anything - you are free to just fork a package and adjust it to your needs. Nothing stopping you from that. I'm a maintainer of several popular packages on GitHub and something tells me that I have a pretty good grasp of what open source is and what best practices for it are. Your comment is not one of them.

I agree that maybe I could dismiss the original request but it made sense to me (and still makes) that we should be solely responsible for managing our height - that's the core responsibility of this package and as such, I don't want it to be indirectly overridden from the outside without the package even knowing about it.

anyway, i think it's better that we switch to a package (it's worth noting that none of the alternatives to this package are doing the inline !important "hack") maintained by someone with a little better understanding of CSS and best practices for open-source packages anyway, so that we don't run into any other conflicts like this in the future

This comment is outright rude and you should reconsider using such rhetoric in the future. Other people do not have to always agree with your technical decisions, nor you have to agree with technical decisions made by others. More often than not there is just no single perfect answer to the problem. Everything is a tradeoff.
Open source is still managed by people that have to manage their own time & preferences while trying to help others by sharing what they have done. This doesn't mean that every single feature request or anything else will make it to the package. If anything - you are free to just fork a package and adjust it to your needs. Nothing stopping you from that. I'm a maintainer of several popular packages on GitHub and something tells me that I have a pretty good grasp of what open source is and what best practices for it are. Your comment is not one of them.


Improving readability of .log.txt file

https://github.com/agrc/uic-forms/blob/5372488e6970c17a736cd2492965e3cb3ff58026/uic-forms/models/CsvMappings.cs#L17
Would it be a huge headache to write the csv column name to the .log.txt file rather than the old pdf form field names?  This would facilitate the writing of the narrative that accompanies the csv submittals.  Thanks.

Not a huge headache. Just a lot of typing. I'll get it done for ya.

Thanks, Steve.
Candace C. Cady, PG | Underground Injection Control (UIC) Program
phone:<PHONE_NUMBER>
office location:    195 North 1950 West, Salt Lake City, Utah  84116
mailing address:  Utah Division of Water Quality
PO Box 144870
Salt Lake City, Utah   84114
Emails to and from this email address may be considered public records and
thus subject to Utah GRAMA requirements.
On Mon, Nov 5, 2018 at 10:52 AM steveoh<EMAIL_ADDRESS>wrote:

Not a huge headache. Just a lot of typing. I'll get it done for ya.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/agrc/uic-forms/issues/14#issuecomment-435969788, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEKquLmx49PaW56j1xBOyrFLYRc-bfFTks5usHrVgaJpZM4YMHNe
.


Email validation (InputValidationErrorDomain)

When we use email validator for email with spaces at the begin of text we have such kind of validation error - InputValidationErrorDomain
example: @"<EMAIL_ADDRESS>

@dkorkin I think that a client is responsible for trimming an user input and in this particular case validators behave as they should. Closing.


Add Slash Commands

As Discord puts it: "Slash Commands are the new, exciting way to build and interact with apps on Discord."
I should probably get on the hype train already.

i don't think this is really needed/wanted? @Aidam7 @x10102 pls thoughts

Yeah, I don't think we need to implement them, not like we're gonna reach the point where they become mandatory for us to use them anytime soon, close away


[+0-all-args] Fix const_cast issue.

This is hidden behind the +0 preprocessor flag, so it only affected me.
NFC.
rdar://34120147

@swift-ci smoke test and merge


ability to group tabs

It would be nice to have the functionality to create groups of tabs (e.g. so I could have one set of tabs on codelist diagnostics and a second set of tabs on cohort diagnostics (perhaps could be combined with #86 in a single new argument where the user can pass a list)

copied your comment to #60 so we do not have duplicated issues


Add datatype statistics to the metadata

It would be interesting to see how many unique datatypes (not datatype literals) are there in a dataset.
To do this, we should:

[x] Add the new term to the metadata ontology
[x] Update the documentation ontology
[x] Implement the statistic

[x] Unique datatype counting – for this using a bloom filter is most definitely overkill. Let's just go with a simple set.

Done, it works.


Convergence speed.

Hello,  we train with a "unification"  and  “regression”  strategy respectively.  Abs depth err of "unification" in both avg train and
ave test  is higher than that of “regression” at the first few epoches. Is it normal to converge slower for "unification" strategy？

Just looking at the error of the depth map, "unification" does drop slower than “regression”. But from our experience, when the error of depth map decreases to a certain level, the point cloud reconstruction quality does not get better as the depth map error decreases.

Thanks a lot.  A recent confusion is that "classication" compares prob volumes with supervision signals. From your experience, is it very different in the point cloud reconstruction to use  pure prob_volume_pre, softmax (prob_volume_pre ), or sigmoid (prob_volume_pre) when training?

I think so!

What is the Abs depth err? Mine seems a little big.

What is your Abs depth err value? Mine seems a little big.


Error Register-PnPManagementShellAccess : A parameter cannot be found that matches parameter name 'ShowConsentUrl'.

Hi All,
I'm a newbie to the start kit installation
When i tried installing the webparts only using
Apply-PnPTenantTemplate -Path starterkit-spfx-only.pnp
I get this error

Apply-PnPTenantTemplate : Please provide consent to the PnP Management Shell application with 'Register-PnPManagementShellAccess' and
follow the steps on screen.

But when i run
'Register-PnPManagementShellAccess'
I get error  Register-PnPManagementShellAccess : A parameter cannot be found that matches parameter name 'ShowConsentUrl'.
I'm following this article below
But not sure why the option to be able to get the link and send it for consent approval doesn't work for me
My pnp powershell version is SharePointPnPPowerShellOnline 3.29.2101.0
Thanks in advance

Please note that issues that do not follow this template will automatically be rejected.
Use the following form to submit ask a question related to this repo. If you have an issue related to the SharePoint Framework or its documentation, please submit the issue at https://github.com/SharePoint/sp-dev-docs/issues/new. This will help us respond to your issue faster.

Thank you for asking a question. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
(DELETE THIS PARAGRAPH AFTER READING)

Category

[x] Question

Question

Provide as many details as possible to help the community answer your question.
(DELETE THIS PARAGRAPH AFTER READING)

Guidelines for issue creator (DELETE AFTER READING)

All questions are welcome, please let us know what's on your mind.
Remember that this repository is maintained by community members who volunteer their time to help. Be courteous and patient.
If you have technical questions about the framework, we’ll be monitoring #spfx, #spfx-webparts, and #spfx-tooling on (SharePoint StackExchange)> [http://sharepoint.stackexchange.com/]. You can also alternatively submit your question to (SharePoint Developer group)> [https://techcommunity.microsoft.com/t5/sharepoint-developer/bd-p/SharePointDev] in the Microsoft Tech Community.
Remember to include sufficient details and context.
If you have multiple suggestions or bugs please submit them in separate bugs so we can track resolution.
(DELETE THIS SECTION AFTER READING)

Thanks for your contribution! Sharing is caring.

Please use PnP PowerShell 1.7.0 as this was tested and should work for you.
https://github.com/pnp/sp-starter-kit/blob/master/documentation/common-provision-results.md#error-improper-version-of-pnp-powershell-installed
you will also want to use Invoke-PnPTenantTemplate


Alternative suggestion: Naming syntax of subfolder icons

If you have an icon in a subfolder, for example icons/social/twitter.svg it will be parsed to
icons/social/twitter.js, and it will register its name as social/twitter
import icon from 'vue-svgicon'
icon.register({
  'social/twitter': {
    width: 16,
    height: 16,
    viewBox: '0 0 50 50',
    data: '<path pid="0" d="M45 13.2c-1.5.6-3.1 1.1-4.7 1.3 1.7-1 3-2.6 3.6-4.5-1.6.9-3.3 1.6-5.2 2-1.5-1.6-3.6-2.6-6-2.6-4.5 0-8.2 3.7-8.2 8.2 0 .6.1 1.3.2 1.9-6.8-.3-12.9-3.6-16.9-8.5-.7 1.2-1.1 2.6-1.1 4.1 0 2.8 1.4 5.3 3.6 6.8-1.3 0-2.6-.4-3.7-1v.1c0 4 2.8 7.3 6.6 8-.7.2-1.4.3-2.2.3-.5 0-1-.1-1.5-.2 1 3.2 4.1 5.6 7.7 5.7-2.8 2.2-6.3 3.5-10.2 3.5-.7 0-1.3 0-2-.1 3.6 2.3 7.9 3.7 12.6 3.7 15.1 0 23.3-12.4 23.3-23.2v-1.1c1.6-1.4 3-2.8 4.1-4.4z"/>'
  }
})

This makes it really hard to import the icons on case by case basis. I have a vue app and I only import the icons I need per component.
import { back, chat } from '~/components/icons'

but I of course can't do
import { social/twitter } from '~/components/icons/social'

I would suggest a syntax change to for example social_twitter

If you are using nuxt, you can to try https://github.com/dschewchenko/nuxt-svgicon

@dschewchenko looks cool!
vue-svgicon should consider adding your extended config additions to their core :)


Add a script called gandlf_preprocess for offline processing

Is your feature request related to a problem? Please describe.
Currently, GaNDLF performs pre-processing on-the-fly, which is fine but causes issues when there are hardware constraints.
Describe the solution you'd like
Include a script called gandlf_preprocess (which could be an extension of gandlf_padder) which performs all preprocessing and saves the processed images on disk.
Describe alternatives you've considered
N.A.
Additional context
This should create a mechanism which ensures that the preprocessing isn't repeated when the data is called using gandlf_run.

Follow in https://github.com/sarthakpati/GaNDLF/tree/127_preprocess

Facing a weird issue right now: https://github.com/fepegar/torchio/discussions/598