repurposing component index code for charts index

Addressing #1647
At this point primarily duplicated the community component index into a "Charts" component, and relevant GraphQL schema.
Very much WIP.
Need to refine from a code / functionality perspective.
Need design feedback on possible changes to layout for a chart index vs a component index.

If it builds this time (!), also interested in a sanity check from @joshblack / @andreancardona. At this point it really is primarily a near-complete duplicate of all the component index code and schema.
I think that should work as a foundation for any other type of index (as we'll end up doing likewise for patterns at some point)...although also feels like maybe longer term there's a better way than just rebuilding three different indices with three different (but basically identical) schemas. :D

Definitely could try and repurpose the index plugin too to work for both types, would be great if we could do:
{
  resolve: 'gatsby-plugin-index',
  options: {
    sources: [
      {
        name: 'community',
        directory: '...',
      },
      {
        name: 'charts',
        directory: '...',
      },
    ],
  },
}

And it would just work. In the future might even make sense for this data just to be coming from an API and editable through a UI (which could be do-able with our service that we're doing right now since we'll have component data there)

That makes sense.
Presumably then we could just add all the chart .yml files in the interim, even if they're initially being referenced by chart-index, and then change to reference them from a combined index in future (i.e. we add the data first).
This is, I think, definitely the correct approach. Because then we'll end up with (as a final result)...
{
  resolve: 'gatsby-plugin-index',
  options: {
    sources: [
      {
        name: 'components',
        directory: '...',
      },
      {
        name: 'charts',
        directory: '...',
      },
      {
        name: 'patterns',
        directory: '...',
      },
    ],
  },
}

...where we can present the different types on different pages (so a "component index", "chart index" etc), but also in theory a single, filterable, "catalog of everything".

@andreancardona / @joshblack - this works ok, but it breaks completely if you filter to a point of "no results". Do you have any thoughts?

@shinytoyrobots took a quick look, I think the fix is that suggestion above 👀  let me know if it works!

Now that this has some population with data - I think it's important that we get some design feedback. @aagonzales, I'll set up a brief chat with you, @aledavila and I about any considerations we should take into account. Let me know if there's anyone else I need to add to that meeting.

@andrea-gm or @joshblack...
If I were to update the schema.js for this so that "Chart Type" was an array;
chart_type: Joi.array().items(Joi.string().valid('Comparisons', 'Trends', 'Part-to-whole', 'Correlations', 'Connections', 'Geospatial: overlays', 'Other')),
...how would I update the ChartIndexPage component's search function so that it returns data correctly for the filter.
If I just update the schema to make Chart Type array rather than string, the "Chart Type" filter as currently written just returns no results (as it's presumably searching for a single string and not an array item).

@jeanservaas / @aagonzales - from a data/functionality perspective this is pretty much ready now. What would we want to do in terms of thumbnail images (I made a couple of pngs using the svgs on the carbon site to test how they looked)?

Moving this out of draft (though it still needs visuals), as it is now functional.

I added updated images for all of the Carbon Charts types (with the exception of "step chart", which doesn't have a thumbnail).

@janchild are we cool with calling it a "charts" index or are we leading with the name "data visualization" — we've been inconsistent on this front.
@shinytoyrobots I will reformat the thumbnails like I did for the others so the margins are roughly the same, but that doesn't need to block this from going live.

@jeanservaas I'd prefer we go with Data visualization if that fits. It's a mouthful but I think when people say it, they'll shorten it to data viz index anyway.

OK, let me update with that language - see how it looks. And also just do a minor bit of cleanup (remove a couple of AI Apps solutions that don't have descriptions right now, and remove the Cognos test chart!)

That's a good point @aagonzales. Presumably also applies on the component index.
Especially in the example you show, where there are duplicate entries, maintainer info to distinguish between the two seems important.

There's a minor bugginess in the "Previous/Next" at the bottom of the page (same on the component index), which isn't a stop shipper but flagging here so we don't forget.

@shinytoyrobots I think it would need to be an update to this method:
https://github.com/carbon-design-system/carbon-website/pull/1746/files#diff-817efa7c15d29e19212dd673e7ce745bR82
Specifically:
function filterItems(items, filters) {
  return items.filter((item) => {
    // If there are no filters, return true.
    if (filters.length === 0) {
      return true;
    }
    const { chartType, availability, maintainer, complexity } = item;
-    const fields = [chartType, availability, maintainer, complexity];
+    const fields = [...chartType, availability, maintainer, complexity];
    return filters.every((filter) => fields.includes(filter));
  });
}

This should add every item from chartType to the "fields" array that is checked against for each filter 👀

@shinytoyrobots @aledavila For the "no chart found" results do we want to add a sentence or two linking them to contribute a chart?

@shinytoyrobots @aledavila For the "no chart found" results do we want to add a sentence or two linking them to contribute a chart?

Good thinking, @andreancardona. I added that to last push.
@joshblack - thanks for the feedback. I'll test that as a post initial release thing, I think.
@janchild / @mjabbink - are we good with the "Data visualization index" language now?
If all that's OK then we can approve and merge I think.

@shinytoyrobots yes, the language looks good. We might take a look at the labeling of the tabs to remove the repetition, but this is good for now.
Tricky because I don't think tabs can have the same name, is that correct @alisonjoseph ?

I think that intro copy needs to speak to the designs expressing IDL and quality. I’d remove anything that isn’t.
Most of the ones in AI Apps are just referencing existing carbon charts and the rest are barely anything more than a gesture.
A few also are misnamed in the index like bumble chart leads to bullet in AI Apps.

Looking at the AI Apps charts I think these need to probably not be included in the index. Only 5–6 new ones and they are incredibly weak with no guidance, specs, or refined designs, Sketch files zero. Just a static image with missing details and misleading.
We have current design efforts on following charts:
Bullet
KPI
Network Diagram
Histogram
Alluvial
Lollipop

Part of the point of the index is to highlight duplicates though - to provide a greater impetus to consolidate and refine. So would we be better keeping the AI Apps charts in (for a soft launch at least) and using that as a basis to reach out to Craig to discuss effective next steps?

Is there a reason we are duplicating the code from the component index and not reusing the same component for both? Would we want to just have one component for both so its easier to update in the future and keep them in sync?

@alisonjoseph so that will actually be a next step. To repurpose the component plug-in to allow for us to reuse it and be able to add the charts and patterns.

@shinytoyrobots you can't have two properties on an object with the same name. This PR broke all the component index images.

Thanks for the spot. And a good reminder that just testing the thing being built can mean missing knock-on effects (from clumsy coding on my part).


crypto-square examples have trailing spaces stripped, not in README

The crypto-square examples and directions do not mention that trailing spaces should be stripped. It instead requires perfect squares which should include trailing spaces. This should be fixed in the README for example, the splunk example should be:
"s-u- "
"p-n- "
"l-k- "
However the output requires no space after the lk pair. This issue is repeated in other ones as well.
Originally filed against the Golang README as https://github.com/exercism/xgo/issues/348

@ErikSchierboom @NobbZ @IanWhitney @petertseng @kotp @Insti you're the first ones to come to mind with respect to details on curriculum. Would you mind having a look/think about this one?

All spaces are stripped from the input string. From the Readme:

First, the input is normalized: the spaces and punctuation are removed ...

Then the output is generated as code blocks separated by a single space there should be no trailing space.

... output in r-length chunks separated by spaces.

I believe the Go example solution is correct.

I agree with @Insti, this is mentioned in the README and thus the example is correct.

If you remove the trailing spaces it's no longer a perfect square which is
also a requirement right?
On Aug 28, 2016 11:17 AM, "Erik Schierboom"<EMAIL_ADDRESS>wrote:

I agree with @Insti https://github.com/Insti, this is mentioned in the
README and thus the example is correct.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/exercism/x-common/issues/356#issuecomment-242986779,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABm7FdwHFwIgjCDla8MPhxsMi_-iMv1Lks5qkcLEgaJpZM4Ju1it
.

perfect square which is also a requirement right?

Readme asks for a rectangle, not necessarily a square. It says c - r <= 1 so it doesn't have to be a square (it won't be a square if c - r = 1)

As far as I do understand the README, there is no way to have anything in the encoded text that is not matching /[[:alnum:]]/, since whitespace and punctuation has to be stripped (personally I do strip all non-printables as whitespace).
I haven't looked at the xgo issue though, I have some problems to read go and currently I do not have the time to try it ;)

Stripping the input is not relevant here. The question is on adding back
the filler spaces at the end.
On Aug 28, 2016 1:44 PM, "Norbert Melzer"<EMAIL_ADDRESS>wrote:

As far as I do understand the README, there is no way to have anything in
the encoded text that is not matching /[[:alnum:]]/, since whitespace and
punctuation has to be stripped (personally I do strip all non-printables as
whitespace).
I haven't looked at the xgo issue though, I have some problems to read go
and currently I do not have the time to try it ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/exercism/x-common/issues/356#issuecomment-242994995,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABm7Fa8ZSESbNDU_OHdV6SkCOVYHHsA2ks5qkeUfgaJpZM4Ju1it
.

There are no filler spaces.
@matthewfischer can you quote the section of the readme that leads you to believe there are?

Absolutely. There will always be spaces in the output from what I see. The text says:

Phrases that fill perfect squares
(r X r) should be output in r-length chunks separated by spaces.
Imperfect squares will have n empty spaces.  Those spaces should be
distributed evenly across the last n rows.

However after re-reading everything I don't see anything that mentions that the output should be a perfect square. Just spaces between segments and spaces filling in to make a rectangle (not a square). So I am indeed wrong in my initial bug report.

That text could probably be improved to be more clear.
Do you have any suggestions for better wording to help remove confusion?

Let me think about it it some but to me it seems like the directions could be distilled a bit more. At the root there all you want is essentially spaces between rows and hence never at the end to "fill out" the rectangle. Whether or not they're full rows is immaterial right?

The 'fill out' the rectangle is part of an intermediate step.
Maybe it needs to be made more clear that it is a multi-step process?

The way I read the current README at https://github.com/exercism/x-common/blob/master/exercises/crypto-square/description.md -

Imperfect squares will have n empty spaces. Those spaces should be distributed evenly across the last n rows.

The value of "n" is unclear. It's r * c - message_length (in the example, 56 - 54).
"last n rows" is unclear because the "rows" that have one fewer character only appear if you stack up the chunks, and the example of that is only shown after. It's unclear which rectangle (the transposed one or the non-transposed one) the rows refer to.
I recommend clarifying the value of n, and saying instead that the last n chunks will have one fewer character, without referencing "rows"

I recommend clarifying the value of n, and saying instead that the last n chunks will have one fewer character, without referencing "rows"

In the linked PR, the last half of this recommendation (the last n chunks will have one fewer character, without referencing "rows") was done.
The first half (clarifying the value of n) was not done, but maybe it will be sufficiently understood that n is just a variable representing the number of empty spaces.
I guess the second half was more important so I can call it closed.


ParallaxView make the app crash in tvOS11 beta2

Cant return row 46 ( static func defaultGlowImageView() -> UIImageView ) in ParallaxEffectOptions.swift so it return Fatal error and crashes the app.

This issue was already fixed in this PR:
https://github.com/PGSSoft/ParallaxView/pull/5


update calicovpp version to v3.24.0

Description

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

LGTM, but could you take a look please @caseydavenport ?

/sem-approve

/merge-when-ready

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.


Struct methods

Assuming there is a Foo struct, this would be the method implementation for "some_method":
impl Foo.some_method(x: int) {
    self.bar = x
}

To call this method, a familiar syntax is used
fn main() {
    let some_foo = new Foo {
        bar: 5
    }

    some_foo.some_method(10)
}

Note: syntax has been adjusted. See documentation.


Rename LightningLite to Fabric

What does this PR do?
Renames LightningLite to Fabric
New Fabric features have been kept
pytorch.LightningLite is kept but deprecated
Co-authored-by: awaelchli<EMAIL_ADDRESS>Does your PR introduce any breaking changes? If yes, please list them.
None
cc @borda @carmocca @justusschock @awaelchli

The test-on-tpus (lite) failure is expected because the job uses the pull_request_target event, so the changes to the TPU fabric tests are not reflected in the CI until this is merged.


Windguard method including data filtering

We noticed that windguard also have a power-to-power comparison which is different from the smart blade method. I think there is some merit in implementing both methods and seeing how they compare. The Windguard method seems more intuitive.
However, in Windguard's document they identify some data filtering steps which I think will be useful for both methods. Therefore I began working on this data filtering code in this branch based on these recommendations. The recommendations are:

Test Turbine and Reference Turbine operational, filtering by status code or e.g. by RPM signal
Test Turbine and Reference Turbine not curtailed, filtering by status signal
No blade icing, filtering by temperature
Test Turbine and Reference Turbine free of wakes is often preferable, but no necessary condition
In Testing Period: use only wind direction ranges and power ranges also covered by Training Period

@jecheniq @reos-otulloch @Visgaard

I have also in this branch now moved to using Matlab packages. I chose the package name windp2p so the functions in the package a re called like
windp2p.filterData
windp2p.findWakeFreeConditions
I have also split out the parse_pv_pairs function to it's own file instead of being a subfunction. For this project it must now also be called with the following syntax windp2p.parse_pv_pairs. You will see I updated the code to do this.

@Visgaard Yes, I've been thinking about this too, however, I think the right approach is actually more likely to be to interpolate one of the data sets to match the other. This will probably have to be done in blocks, because there will be large sections of data removed out.
There is a built-in matlab function to synchronize data, with the option of interpolation. I think we may be able to use this.
The only problem is big gaps in the either data series will produce bad results, but we could identify the big gaps and remove them after synchronisation with something like the following.
I was thinking something like
% calculate durations between time steps in both data sets, something like

time_diff_ControlPre = diff (Data.ControlWTPre.Time);
time_diff_TestPre = diff (Data.ControlWTPre.Time);

% identify the data where the differences are below a chosen threshold,
% e.g. 5 x the nominal sample period or something
sample_threshold_ControlPre = time_diff_ControlPre < options.GapThreshold
sample_threshold_TestPre = time_diff_ControlPre < options.GapThreshold

Next we could find the start and end of the continuous blocks above the threshold (I googled this a bit and there are some solutions we can use), and lets say we end up with a three column matrix with the start index, end index and size of the good blocks for each data set. Then we can use this information to remove 'bad' chunks from the synchronized data.

I suppose the above is simpler if we synchronize the time series before we do any filtering on other criteria, so maybe that is the solutions. I think we would still want to check and warn about big gaps though.

Yes, that's right, we should interpolate to find the values at the exact same time stamp. synchronize does this for us, but it does mean using the timetable object for the data instead of a simple structure, maybe this is fine, I haven't used it much before.
The main issue will be when there are big gaps in either time series, e.g. because the internet went down or something. The interpolated values in these sections will be nonsense, so we would need to strip them out.
For adding a block of code I just type it out, then highlight it and click on the Add code button! Or you can use backticks three top and bottom of code blocks, or one either side of the words forinline`

That makes perfect sense to me. I don't have experience with the timetable object either. But I think we need to have a structure for the data that is "light". Just 3 days of 1s log is 259200 data points, which is quite a lot. I've been using cell arrays for the data analysis that I do at work, but I find it's too slow when dimensions are high.
Test Code

I'm going to go ahead and merge this branch since it doesn't interfere with anyone.


Fix release url

Release mail comes with
https://github.com/ViroCommunity/virocore/releases/tag/refs%2Ftags%2Frc-1.20.1
there are aar as assets included
but click on release here https://github.com/ViroCommunity/virocore/releases
the url is
https://github.com/ViroCommunity/virocore/releases/tag/rc-1.20.1
there are no aar as assets included
This pull request will solve it. To test it, please create a new tag again after merge

@doranteseduardo To test it, please create a new tag


[DBAAS-1092] Remove logging from setConnectionStatusMetrics

Description
Remove logging from setConnectionStatusMetrics as it generates too much of logs
Verification Steps
The multiple logs from setConnectionStatusMetrics should not appear, as they are deleted
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA or in issue number have been completed
[ ] Unit tests added that prove the fix is effective or the feature works
[ ] Documentation added for the feature
[ ] all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer

@rhkp how about other objects like platform as seen in attached logs
dbaas-operator-controller-manager-7f6c76bcb-r942m-manager (5).log

I agree. I do not know why would DBaaSPlatform reconciliation is almost being happening continually? And that is why the logs are appearing more frequently.
Wait let remove from DBaaSPlatform logs as well. Give me a few minutes.

Thanks @redhatHameed. Please check now and approve/merge. Thanks.

@rhkp thanks,
can you share the pods logs with these changes. Also you can you create the different objects like inventory, connection , instance and see how is the frequency of log generation,

Okay, sure.
I still will keep a few logs if they are not too frequent. But let us check and remove the frequent ones.

No worries. I have this Jira which we will take up sometime March/April 2023 hopefully, by when we will know if these features are stable enough.
https://issues.redhat.com/browse/DBAAS-1103
Can you approve and merge the PR now?


[Feature]: Create the GraphQL Query Editor Page with Query and Variable Inputs

Is there an existing issue for this?

[X] I have searched the existing issues

Summary

[x] Create a GraphQL Query Editor Page
[x] Add Query and Variable Inputs for the GraphQL requests

Why should this be worked on?
This is the important part of creating a GraphQL queries for the user.

WAiting for DP

Verified on instance provided


Update group ID for Shared Voicemail in Set-CsCallQueue.md

Please confirm if this is supported. I have tested it and works. Thanks!

@tomkau, could you review it? Thanks!

@JohanFreelancer9

@tiburd Please merge this PR. Thanks


Security: To test feature of BMC chip lock down

Associated Development story: https://github.com/openbmc/openbmc/issues/258

@joseph-reynolds your expert advise / suggestion will be good .

I don't know how this is different from issue 59.  Would this be covered by https://gerrit.openbmc-project.xyz/#/c/openbmc/docs/+/11164/2/security/obmc-securityarchitecture.md?

As development not considered this, Will reopen if we get associate issue/feature get open by development.


Use the latest label module to support the environment attribute

Freshen the module to use the latest terraform-null-label module, replacing the older terraform-terraform-label module, so that the environment attribute is supported.

/codefresh run test

/codefresh run test

/codefresh run test


How to not pick up everythingg

Details
The bot is great and I have tried doing it myself but it would be great if the pickit files made it so the bot wouldn't even pick up things that you don't want.
I attempted to remove items from the d2go folder that I replaced in go.mod:
replace github.com/hectorgimenez/d2go => F:/Downloads/BOTS/d2go
This just caused it to fail on:     d.CollisionGrid = gd.GetCachedMapData(isNewGame).CollisionGrid(d.PlayerUnit.Area)
If i get it to work, i'll let everyone else know the fix.
Version
newest
Logs
CollisionGrid was not found

I have the same issue.
My solution was to delete a lot of items in the pickit files. It hasn't fully resolved the issue but it seems to have significantly reduced the random items that get picked up.

the pickit file doesn't disallow items from being picked up but only the items you keep.


Cow: Watch Sentry[\W_]+Vantage[\W_]+Hacker

Cow requests the watch of the watch_keyword Sentry[\W_]*+Vantage[\W_]*+Hacker. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Sentry[\W_]*+Vantage[\W_]*+Hacker has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Dragonrage in Charcoal HQ


Fix podDNSSearchNamespaces validation issue

Fix: https://github.com/istio/istio.io/issues/5515

@elfinhe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
ec7e1e67735b00361a34902cbaa0f3498ae8c941
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
a90d7cb49de9b3b98724c78db3391a3dc9cf54be
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test_operator
e2e6fedd33595fac0d391c0d87d4793de4eb29a8
link
/test test_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfinhe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test_operator
1df9322452a998d41b7f2567034fdfffb3d3f044
link
/test test_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fixing tests

In response to a cherrypick label: #561 failed to apply on top of branch "release-1.4":
Applying: Re-run make gen
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/apis/istio/v1alpha1/v1alpha1.pb.html
M	pkg/apis/istio/v1alpha1/values_types.pb.go
M	python/istio_api/pkg/apis/istio/v1alpha1/values_types_pb2.py
Falling back to patching base and 3-way merge...
Auto-merging python/istio_api/pkg/apis/istio/v1alpha1/values_types_pb2.py
CONFLICT (content): Merge conflict in python/istio_api/pkg/apis/istio/v1alpha1/values_types_pb2.py
Auto-merging pkg/apis/istio/v1alpha1/values_types.pb.go
CONFLICT (content): Merge conflict in pkg/apis/istio/v1alpha1/values_types.pb.go
Auto-merging pkg/apis/istio/v1alpha1/v1alpha1.pb.html
Patch failed at 0002 Re-run make gen

I will cherry pick this manually.


component update clears innerHTML?

<Editor ref="edit" id="editor" className="edit"
              style={{
                fontFamily: fields.fontFamily.value,
                fontSize: fields.fontSize.value,
                fontWeight: fields.fontBold.value ? 'bold' : 'normal',
                color: fields.fontColor.value,
              }}
              onKeyDown={(e)=>this.onKeyDown(e)}
              onInput={(e)=>this.onInput(e)}
              dangerouslySetInnerHTML={{__html: currConver.editor}} />

It seems the innerHTML clears when one of the css style updates.
When I switch back to react, it works.
Is it a bug of react-lite?

I wonder the type of  currConver.editor, it's string or not?
since:
let oldHtml = oldValue && oldValue.__html
let html = value && value.__html
if (!isStr(html)) {
  elem.innerHTML = ''
} else if (html !== oldHtml) {
  elem.innerHTML = html
}

if currConver.editor is equal to undefined, innerHTML will also be clears.
Had better got a demo for debugging:)

Yes, you're right. It is undefined :cry:
But this is different with React. Is it better to make them consistent? ;)

@fritx That's ok, I will check the behavior about inneHTML in this case with react, and make them consistent.

Thanks! At this time, I prefer consistancy. Thank you!
But maybe in the future, react-lite's simple and lightweight wins!

I think the version v0.0.13 of react-lite made consistancy with below change:
let oldHtml = oldValue && oldValue.__html
let html = value && value.__html
if (html != null && html !== oldHtml) {
  elem.innerHTML = html
}

It won't be patched if html is equal to null or undefined such like regular react does.
try the lastest version to confirm this problem was resolved:)
BTW, I think regular react will provide lightweight version in the feature, or something like rollup \ tree shaking, make react-lite not necessary
haha ~ just wait and see what will happen.

@Lucifier129 haha~ ok, wait a sec

Ok alright!

[x] It won't be patched if html is equal to null or undefined
[x] It will be patched if html is equal to empty string

That's good:)

issue should be closed :+1:


Breaking change in master branch

https://github.com/byuoitav/terraform-kubernetes-nginx-ingress-controller/commit/75fd2b082588cecba95a7868015d6b65556a954a#r42284248
I can't see where that odd naming comes from, but it is required.

Changing the line to
resource_names = ["${var.name}-leader", "${var.name}-leader-${var.name}"]

worked in a local test, I suspect both aren't required.


feat(rewards): debank rewards support

Background
Badger DAO users currently cannot see their pending rewards on any chain via DeBank. The API has this information for every token available and they are willing to integrate support for our rewards if we provide them an API to do so.
Requirements

API is provided via DeBank, is non-negotiable in terms of fields, typing etc. even if they do not conform to the code standards in the repository.

[ ] Provider paginated user rewards by chain
[ ] Support querying chains via chain id

https://github.com/Badger-Finance/badger-api/pull/1096
Released and discussed with @axejintao


Add Common Labels Support

Common Labels to Helm Chart
Description

Adds optional common labels support which gets added to all deployable Kube resources.
References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

Thank you for your contribution to the Helm charts! If you're comfortable with it, we encourage contributors to update documentation where it makes sense. In this case, you may want to mention common labels in the chart’s README.md and include a usage example in values.yaml to help users. If you do wish to update the documentation, you can do so in a separate PR and link it to this one.

Thank you for reviewing @hello-caleb ! I am not sure which separate documentation I need to update but I have now provided usage examples.


broken ColorTest with cpu rendering

While tracking down rendering errors, I found that color rendering is broken with cpu rendering (cpu_fix).
Here's a code snippet to render ColorTest.
use egui_skia::rasterize;
use skia_safe::{EncodedImageFormat, Paint, Point};
use std::fs::File;
use std::io::Write;

pub fn main() {
    let mut demo = egui_demo_lib::ColorTest::default();

    let mut surface = rasterize(
        (800, 2000),
        |ctx| {
            egui::CentralPanel::default().show(ctx, |ui| {
                demo.ui(ui);
            });
        },
        None,
    );

    let data = surface
        .image_snapshot()
        .encode_to_data(EncodedImageFormat::PNG)
        .expect("Failed to encode image");

    File::create("output.png")
        .unwrap()
        .write_all(&data)
        .unwrap();

    println!("wrote output.png");
}

This is cpu-rendered image, generate from a code above, which shows errors.

Here's a side-by-side screenshot, comparing cpu-rendered with webgl one (from https://egui.rs)

Some errors could be fixed by un-premultiplying colors from egui.
diff --git a/src/painter.rs b/src/painter.rs
index 5c07f5b..8696332 100644
--- a/src/painter.rs
+++ b/src/painter.rs
@@ -205,11 +205,19 @@ impl Painter {

                             pos.push(Point::new(fixed_pos.x, fixed_pos.y));
                             texs.push(Point::new(v.uv.x, v.uv.y));
+
+                            let c = v.color;
+                            let c = Color::from_argb(c.a(), c.r(), c.g(), c.b());
+                            // un-premultply color
+                            let mut cf = skia_safe::Color4f::from(c);
+                            cf.r /= cf.a;
+                            cf.g /= cf.a;
+                            cf.b /= cf.a;
                             colors.push(Color::from_argb(
-                                v.color.a(),
-                                v.color.r(),
-                                v.color.g(),
-                                v.color.b(),
+                                c.a(),
+                                (cf.r * 255.0) as u8,
+                                (cf.g * 255.0) as u8,
+                                (cf.b * 255.0) as u8,
                             ));
                         });

Hi! I applied your fix in #7, improving on the color test results. But as you already mentioned it's not perfect yet so I'll leave this issue open for now.
I also tested if I could get this to work by changing the type of the created skia texture but it didn't seem to make any difference.
Happy to accept a PR if someone figures out how to fix the additive blending and linear interpolation test cases!

The colors on rendered images are all messed up (weird pink tinge), I wonder if this is related?

I tried rendering a gradient texture and when I sample the color with a color picker, the red and the blue components appear to be swapped. I fixed it with this:
let scol = [0x1E, 0x55, 0xFF];
let ecol = [0xFA, 0x0D, 0xD4];

 // TODO: skia has r/b colors swapped for some reason, fix this
let start_color = Color32::from_rgb(scol[2], scol[1], scol[0]);
let end_color = Color32::from_rgb(ecol[2], ecol[1], ecol[0]);

let gradient = Gradient::linear(start_color, end_color);

before: https://cdn.jb55.com/s/0cdefad30a081797.png
after swapping r/b: https://cdn.jb55.com/s/2da42af5f9f69756.png


Adding comments on Kanister Resource Types Fields in types.go

There were comments missing from kanister resource types fields in types.go ,because of which there was missing description while creating the documentation using tools like https://github.com/ahmetb/gen-crd-api-reference-docs/ . So, added missing comments on fields present in types.go
Signed-off-by: Kartik-Garg<EMAIL_ADDRESS>Change Overview
The documentation generated now has description of all the fields present in Types.go:

Added missing comments on fields on types.go file.
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[x] :world_map: Documentation
[ ] :robot: Test

Issues

fixes #1721

Test Plan

[x] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

@Kartik-Garg Please go through https://docs.kanister.io/architecture.html to understand the significance of each field and correct the comments. I went through few but will re-review once you correct the field comments by referring the doc

@PrasadG193 I see, I did not realize we could write comments by referring to https://docs.kanister.io/architecture.html
Thanks a lot for pointing it out :D

@Kartik-Garg have you addressed all the review comment's suggestion in this PR? If yes, can you please mark the comments resolved.

@Kartik-Garg have you addressed all the review comment's suggestion in this PR? If yes, can you please mark the comments resolved.

@viveksinghggits There's just one comment left about Prefix, other than that I have made changes and commited

Looks in good shape.
@pavannd1 can you please have a look quick look when you get time. And then we can merge this.

LGTM. I will approve once Pavan has taken a look.

Part 1 of my review. I'll post the remaining comments tomorrow

Thanks a lot for the reviews, made changes according to the review comments, eagerly waiting for upcoming parts :D

@pavannd1 Thanks for the review comments, I have made the commits according to the suggestion. :D

@pavannd1 I just updated the branch with respect to upstream, if everything is in order, could you please merge the PR


Remove EditorHints.

EditorHints is no longer used by VisualStudio tooling and is not populated during Razor parse time. This feature was marked obsolete in 1.1.0.

@NTaylorMullen - it looks like this was never ported forward to the new codebase. Close?

Talked to @NTaylorMullen - this is gone.


.${gameType} file is ignored

I'm doing HoI4 modding with this plugin, however, the plugin mark the mod as Stellaris's one.
Project Directory

Project is recognized as Stellaris mod

I suggest to use VSCode with CWTools until I implement CWT Config File Support more perfectly.
Bug feedback is always welcomed.

THX!

47ca26ad471d329131add82353581cb6962d29dc


62 connect gui to mongo and start recieveing information

review this please

there seems to be a ton of work done here for the report generation side. that isn't bad literally at all -- its sick. just keep in mind with future development that we will be getting model prediction in real time and its as simple as a int->str for displaying what attack is currently happening. the only reason we would save these is for producing a report after


build: skip the harness tests when running integration tests

Manually running the integration tests against this branch worked: https://github.com/cloudspannerecosystem/liquibase-spanner/actions/runs/12398776883


Attempt to fix login

Description
The changes I initially made to Basim's stuff had broken the build for others.
On my emulator I no longer see the example.com redirect, if someone could / fork my repo and test it out on their devices it would be much appreciated.
Changelog

Attempt to fix login

Addresses Issues

Login would redirect to example.com, and not properly send the intent to the main activity.

The PR looks good! I'm in class til 10 today, when I get home I'll fork and try running it myself


Removed typeof statement, that was root cause of problem with imports.

In AMD API specification, id and dependencies are optional parameters. Problem was caused by this condition:
if(typeof define === "function" && typeof define.amd){
typeof define.amd always returned non-empty string (which is evaluated as true value), so whole condition was actually checking if function define is defined - not if that is actuall amd define.

@kbialowas thanks


Bluzi patch 6

Travis tests has failed
✓ should contain a lowercase name, same as the filename
✓ should not have duplicate names
1) should have ISO-639-3 language codes
2) should have correct structure
Translations
✓ should be lowercase
4 passing (46ms)
2 failing

name files
should have ISO-639-3 language codes:
Error: a is not a valid ISO-639-3 language code in adam.json
at Context.it (test/test.js:52:27)

name files
should have correct structure:
Error: Error in name file "adam.json":
instance.translations additionalProperty "a" exists in instance when not allowed
at Context.it (test/test.js:101:23)

Powered by: Travis Buddy


Please document the MSRV for async-h1

I used async-std and surf in unleash-client-rust recently, and trying to document the minimum supported rust version for it is turning out harder than expected ;(. async-h1 seems to be using latest-everything features - and thats probably fine, async is new etc, but it would be nice to know what the actual policy is going forward. Just a one liner in README.md.
Thanks!
(https://github.com/rust-lang/rust/issues/65721 is what caught me trying to make 1.40 the MSRV, which is used by async-h1).

This is an interesting one -- I have no objections to documenting the MSRV but given the nature of async in Rust right now I would like us to reserve the option to bump the minimum version without publishing a major. In effect the stability guarantee we provide is that we work on stable Rust.


🔧 [Refactor] Stage sends Production Opt-In links

🔧 Refactor

Stage sends Production Opt-In links.
Since only the opt-in code is filled in the link points to the production page.
Two options to solve:

Make another template with correct link
Provide full link to template

fixed with own template


TypeError: unsupported operand type(s) for -: 'int' and 'simsimd.DistancesTensor'

ERROR:    Exception in ASGI application .......     research_result = await researcher.conduct_research()                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/gpt_researcher/master/agent.py", line 85, in conduct_research     self.context = await self.get_context_by_search(self.query)                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/gpt_researcher/master/agent.py", line 158, in get_context_by_search     context = await asyncio.gather(*[self.process_sub_query(sub_query) for sub_query in sub_queries])               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/gpt_researcher/master/agent.py", line 174, in process_sub_query     content = await self.get_similar_content_by_query(sub_query, scraped_sites)               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/gpt_researcher/master/agent.py", line 226, in get_similar_content_by_query     return context_compressor.get_context(query, max_results=8)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/gpt_researcher/context/compression.py", line 43, in get_context     relevant_docs = compressed_docs.invoke(query)                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/langchain_core/retrievers.py", line 194, in invoke     return self.get_relevant_documents(            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/langchain_core/_api/deprecation.py", line 148, in warning_emitting_wrapper     return wrapped(*args, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/langchain_core/retrievers.py", line 323, in get_relevant_documents     raise e   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/langchain_core/retrievers.py", line 316, in get_relevant_documents     result = self._get_relevant_documents(              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/langchain/retrievers/contextual_compression.py", line 48, in _get_relevant_documents     compressed_docs = self.base_compressor.compress_documents(                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/langchain/retrievers/document_compressors/base.py", line 39, in compress_documents     documents = _transformer.compress_documents(                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/langchain/retrievers/document_compressors/embeddings_filter.py", line 61, in compress_documents     similarity = self.similarity_fn([embedded_query], embedded_documents)[0]                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/philipp/Library/Caches/pypoetry/virtualenvs/backend-xXYcI_nD-py3.11/lib/python3.11/site-packages/langchain_community/utils/math.py", line 29, in cosine_similarity     Z = 1 - simd.cdist(X, Y, metric="cosine")         ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TypeError: unsupported operand type(s) for -: 'int' and 'simsimd.DistancesTen
I am getting the error above when running the ".conduct_research()" function.
I am using the pip package in version 0.4.0.
I am using the FastAPI example

Hey @ockiphertweck is this happening always or for specific queries? If so can you please share more information about your query?

Hi @assafelovic at least for the queries below, the error occurs.
The step that is executed always prints the following in the logs :
📝 Getting relevant content based on query: .....
query: "Towards an LLM Synthesized Publication Tool: ''Crises'' or Opportunities for Science in the AI Era?"
report_type: research_report
query: "LLM in Science"
report_type: research_report
query: "what team may win the NBA finals?"
report_type: "research_report"

Hey @ockiphertweck have tested all queries and works fine on my end. Have you tried running with the local UI to see if it works? Can you please share the entire code snippet you're trying to run?

Hey @assafelovic hmm that is strange. Using the docker image, everything was working.
The code I used is the following:
from gpt_researcher import GPTResearcher
@router.get("/report/{report_type}")
async def get_report(query: str, report_type: str) -> dict:
    researcher = GPTResearcher(query, report_type)
    research_result = await researcher.conduct_research()
    report = await researcher.write_report()
    return {"report": report}

Then I use the SwaggerUI for making the request.
Just updated the package to version 0.4.5 and still getting the same error.

Not aware of SwaggerUI @ockiphertweck . ANy update on this?

Not aware of SwaggerUI @ockiphertweck . ANy update on this?

Hey, I'm running into the same error when executing the following code:
researcher = GPTResearcher(
    query=req_body.prompt, report_type=report_type, config_path=None
)

# Conducting research and generating report asynchronously
logger.info("Conducting research... \n")
await researcher.conduct_research()

I believe the issue is in compression.py, within the ContextCompressor class. The error seems to occur in the get_context function, specifically at the relevant_docs line, since the print statement right after it isn't showing up:
def get_context(self, query, max_results=5):
    print("\n\n\nDocuments before compression: ", self.documents)
    compressed_docs = self._get_contextual_retriever()
    print("Going to get relevant documents ...")
    relevant_docs = compressed_docs.get_relevant_documents(query)
    print("Got relevant documents ...")
    return self._pretty_print_docs(relevant_docs, max_results)


Percy cli

Percy CLI changes for the Percy C# SDK

👋🏼 I'm curious -- can we get clarification why it can't be an instance method on the class (rather than having to init a class)? I remember something being mentioned about parallel suites, which I don't think impacts the SDK. All of our other SDKs follow that pattern with no issues. Curious to see an example of it failing with an instance method, if possible.
Other than getting the function signature right (percySnapshot(driver, name, options)), this looks pretty good for us to take over and make it production ready. 💯 🔥 👏🏼

So @samirans89, speaking with @Robdel12 the only real comment on this PR is updating the interface to better match what we'd make it in the future in a productionized SDK.
Looking at C# style, I believe this would be:
Percy.Snapshot(driver, name, [option-kwargs])

example:
Percy.Snapshot(drive, "homepage", widths: [1280, 768], percyCss: ".foo { display: none; }")

@Robdel12 does this look right?

That looks pretty close. I did a bit of reading through the C# spec and it looks like we can make this an instance method and we'd use the dictionary (like what's being done now). I wish we could use parameter array's, but they're forced to the same type (and we have a mix of ints & strings).
So I believe it'd be something like:
Percy.Snapshot(driver, "homepage", new Dictionary<string, object> { { "widths", new List<int> { 768, 992, 1200 } })

Hi @Robdel12 and @fotinakis ... thanks for your review comment.
Our team will be checking w.r.t adding the driver in the next 1-1.5 weeks. Would it be fine then to merge this code into main and create a separate PR for that?
@Robdel12 - The current signature for the Dictionary object is same as what you have provided. Let me know if I'm missing anything. Example repo usage:
https://github.com/samirans89/example-percy-csharp-selenium/pull/3/files#diff-64b6bd4518545437a6793878fd7673f5582cdcffe09b3b6f345209b04d8a4c58R87-R90
https://github.com/samirans89/example-percy-csharp-selenium/pull/3/files#diff-64b6bd4518545437a6793878fd7673f5582cdcffe09b3b6f345209b04d8a4c58L67-R65

@samirans89

Our team will be checking w.r.t adding the driver in the next 1-1.5 weeks. Would it be fine then to merge this code into main and create a separate PR for that?

Totally works! Just as long as there isn't a release cut until then (only because the version is now 1.0.0-alpha -- don't want to release that from 0.x and then have a breaking change follow in 1.0.0-alpha-1 or whatever is next 😃)

The current signature for the Dictionary object is same as what you have provided. Let me know if I'm missing anything

Not at all! I was semi-correcting Mike's example (this sadly isn't possible Percy.Snapshot(driver, "homepage", widths: [1280, 768], percyCss: ".foo { display: none; }") -- only in Ruby I think can turn that into a hash nicely). All is good here 💯


Reify linting for multi-portion gating

Fixes-bug: #595
--
This splits the gating out into two linting scripts:

scripts/linting-pep8.sh
scripts/linting-ansible.sh

And it changes scripts/linting.sh to use tox to isolate those dependencies and run them in virtual environments for us.
This also updates our Travis-CI configuration to run tox for each of the two checks. One check may fail while another may pass and the output from both will be easily readable from both. Travis will report "one check" to GitHub, but it has two "sub-checks" that it runs - one for hacking/flake8, one for ansible-lint.

I'm not convinced this is working at the moment but I can't figure out why tox is being difficult.

:+1: for this, I think this makes the goal of better identifying failures even more obvious than simply failing fast, like I had originally tried.
I think @rackertom and @mancdaz should take a look, too.

Taking a glance at it, I like it. :+1:

:+1:

is this not merged yet? :shipit:

Shall I do the backporterating?

@sigmavirus24 I approve of backporting this.


Cannot remove volume/pool after creating

Hi, first would like to thank you so much for the script !  I created a RAID1 pool with 2x 2T  non-synology NVMe SSD.  But after creating, I cannot remove the volume nor the pool.   (I changed the mind and wanted to create a RAID0 pool with these 2 m.2 SSD ,  I run the script again but it is said the drive is already being used by DSM).
How to remove the m.2 SSD from the volume/pool ?
Thank you!

If you run the script with the --all option it will allow you to select any detected NVMe drives, even if they have already have a RAID array on them.
sudo -i /volume1/scripts/syno_create_m2_volume.sh --all
Note: Replace /volume1/scripts/ with the path to where the script is located.

it threw an error , see below
Using options: --all
Type yes to continue. Type anything else to do a dry run test.
yes
NVMe M.2 nvme0n1 is WD Blue SN570 2TB
NVMe M.2 nvme1n1 is WD Blue SN570 2TB
WARNING Drive has a volume partition
Unused M.2 drives found: 2

Single

RAID 0

RAID 1
Select the RAID type: 2
You selected RAID 0

nvme0n1

nvme1n1
Select the 1st M.2 drive: 2
You selected nvme1n1

nvme0n1
Select the 2nd M.2 drive: 1
You selected nvme0n1

Ready to create RAID 0 volume group using nvme1n1 and nvme0n1
WARNING Everything on the selected M.2 drive(s) will be deleted.
Type yes to continue. Type anything else to quit.
yes
You chose to continue. You are brave! :)
Using md4 as it's the next available.
Creating Synology partitions on nvme1n1
    Device   Sectors (Version7: SupportRaid)

/dev/nvme1n11   4980480 (2431 MB)
/dev/nvme1n12   4194304 (2048 MB)
Reserved size:    262144 ( 128 MB)
Primary data partition will be created.
WARNING: This action will erase all data on '/dev/nvme1n1' and repart it, are you sure to continue? [y/N] y
Cleaning all partitions...
Creating sys partitions...
[/sbin/sfdisk -N1 -uS -q -f -j256 -z4980480 -tfd -F /dev/nvme1n1] failed. err=255
Create system partitions failed.

I tried again and it worked for the 2nd time !  You are genius !   Thank you !

Cleaning all partitions...
Creating sys partitions...
[/sbin/sfdisk -N1 -uS -q -f -j256 -z4980480 -tfd -F /dev/nvme1n1] failed. err=255
Create system partitions failed.

Did the script stop there or did it also show ERROR 5 Failed to create syno partitions! error?
If it showed the ERROR 5 Failed to create syno partitions! error I could change it to suggest running the script again.


Add extension instruction for Emacs

@j-fu @pjaap FYI

and that the alias is set

So the Emacs will run the command through a shell where the rc file defining the alias have been loaded?

We realized in testing that that is sadly not the case.
What works is putting a shell script in PATH that can be called. We could add that to the PR if you want.
Might also be useful for others to not use the alias?

Looking at https://github.com/radian-software/apheleia/blob/main/apheleia-formatters.el it seems like you can include a more elaborate command (e.g. something similar to https://github.com/fredrikekre/Runic.jl/blob/6bd8eaebed5b19859cd6b2771c05c053ad482384/README.md#L132-L133 ?

I had tried a few options but the error output always looked the same if I only split part of the command into individual blocks of "<sth>" but splitting it completely worked.


Diagram time: avoid "infinite project"

It feels like I'm weaving a very intricate pattern - its diagram time again - part of complexity management; do you know what happens if I don't manage complexity? - "infinite project" happens :)

Almost no code had to be modified as a result. Thats way too much luck; something is fishy. To be continued.


Analytics of some kind

Not necessarily google; maybe a creative use of application logs

If someone else is looking at this topic, #6 has a discussion on the pros/cons of Google Analytics.

It might be possible to get New Relic access through CfA. I am assuming the page refers to last November.

I am closing this for now, since we have some rudimentary New Relic tracking


panic: invalid argument

The issue is not resolved, so I create it one more time. I tried docker, make build, but no matter what I do, the issue is still not resolved.
i finish to make build, but when i test example/main.go, the following error was found:
➜  tokenizers git:(main) ✗ go run example/main.go
---  invalid argument
panic: invalid argument
goroutine 1 [running]:
main.main()
/home/zhaopanpan/aigc/tokenizers/example/main.go:13 +0x396
exit status 2

are you synced up to main branch? do you have local changes? line 13 does not panic.


Deleted data appearing in List report (CAP Project) columns

How to avoid deleted still data showing in the List report smart table column, please help me.

What's the name of the tutorial?

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


Title

Could anyone give an example of how to set up a different title?

I would like an example too

You can change it in this part. Example is from readme

$scope.$on('IdleWarn', function(e, countdown) {
document.title = "Hello world: " + countdown;
});


Add travis' validation of "Signed-off-by:" line

This adds validation of "Signed-off-by:" line.
Signed-off-by: Fabio Utzig<EMAIL_ADDRESS>

Regarding the comment suggesting to add commiter checking as well as author:
[utzig@inspiron mcuboot]$ git show -s --format="%cn <%ce>" cb1bb48
David Brown<EMAIL_ADDRESS>[utzig@inspiron mcuboot]$ git show -s --format="%an <%ae>" cb1bb48
David Brown<EMAIL_ADDRESS>
I'm not sure it would be a great idea at the moment. I would prefer to work on it later in a new patch (if at all).

You should only ever see the davidb.org commit after github rebases it. It is using my primary account for the rebase, as far as it is concerned.
You should always be ok adding the committer check, and when added, it will usually be after the author Sob.

Added check for commiter as well, let's see how it goes.


⚠ Bofrost.be has degraded performance

In 5a2c75d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1152 ms

Resolved: Bofrost.be performance has improved in 559573d after 8 minutes.


Feature save restore layout

This implements save/restore dock layout. Fixes #33.
The only thing I'm not sure about is the top level layout object. Currently it's a simple object with one main property which holds the layout config for the main area. The thinking here is that if we expand dock layout support to maximized panels and/or tear-out panels, then we'll need space to grow extra properties. However, @ellisonbg and I talked at length today, and were thinking that such feature may end up not being necessary, because there are better ways to implement a similar experience. In that case, we can ditch the container object, and the main property value could be the value of interchange.
cc @ellisonbg @jasongrout @blink1073 @afshin

This looks great! Will the "Save layout" and "Restore layout" stuff be
built in? How will that interact with sessions?
On Sat, Mar 4, 2017 at 6:47 PM, S. Chris Colbert<EMAIL_ADDRESS>wrote:

This implements save/restore dock layout.
The only thing I'm not sure about is the top level layout object.
Currently it's a simple object with one main property which holds the
layout config for the main area. The thinking here is that if we expand
dock layout support to maximized panels and/or tear-out panels, then we'll
need space to grow extra properties. However, @ellisonbg
https://github.com/ellisonbg and I talked at length today, and were
thinking that such feature may end up not being necessary, because there
are better ways to implement a similar experience. In that case, we can
ditch the container object, and the main property value could be the
value of interchange.
cc @ellisonbg https://github.com/ellisonbg @jasongrout
https://github.com/jasongrout @blink1073 https://github.com/blink1073
@afshin https://github.com/afshin
[image: browser]
https://cloud.githubusercontent.com/assets/137289/23584065/b86ce61c-011b-11e7-9728-13916ee8ac81.gif
You can view, comment on, or merge this pull request online at:
https://github.com/phosphorjs/phosphor/pull/222
Commit Summary

add save/restore dock layout functionality
update example to demonstrate save/restore

File Changes

M examples/example-dockpanel/src/index.ts
https://github.com/phosphorjs/phosphor/pull/222/files#diff-0 (30)
M packages/widgets/src/docklayout.ts
https://github.com/phosphorjs/phosphor/pull/222/files#diff-1 (355)
M packages/widgets/src/dockpanel.ts
https://github.com/phosphorjs/phosphor/pull/222/files#diff-2 (34)

Patch Links:

https://github.com/phosphorjs/phosphor/pull/222.patch
https://github.com/phosphorjs/phosphor/pull/222.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/phosphorjs/phosphor/pull/222, or mute the thread
https://github.com/notifications/unsubscribe-auth/AABr0Mza1e_JX9_Kp9sFxw_w0ob3nNZXks5riiIrgaJpZM4MTShc
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Yeah it will be built in in jlab. In the gif, I've just hooked up some
commands to the API to show it off. In jlab, the instance restorer should
take care of everything automatically.
On Mar 4, 2017 22:40, "Brian E. Granger"<EMAIL_ADDRESS>wrote:

This looks great! Will the "Save layout" and "Restore layout" stuff be
built in? How will that interact with sessions?
On Sat, Mar 4, 2017 at 6:47 PM, S. Chris Colbert<EMAIL_ADDRESS>
wrote:

This implements save/restore dock layout.
The only thing I'm not sure about is the top level layout object.
Currently it's a simple object with one main property which holds the
layout config for the main area. The thinking here is that if we expand
dock layout support to maximized panels and/or tear-out panels, then
we'll
need space to grow extra properties. However, @ellisonbg
https://github.com/ellisonbg and I talked at length today, and were
thinking that such feature may end up not being necessary, because there
are better ways to implement a similar experience. In that case, we can
ditch the container object, and the main property value could be the
value of interchange.
cc @ellisonbg https://github.com/ellisonbg @jasongrout
https://github.com/jasongrout @blink1073 <https://github.com/blink1073
@afshin https://github.com/afshin
[image: browser]
<https://cloud.githubusercontent.com/assets/
137289/23584065/b86ce61c-011b-11e7-9728-13916ee8ac81.gif>
You can view, comment on, or merge this pull request online at:
https://github.com/phosphorjs/phosphor/pull/222
Commit Summary

add save/restore dock layout functionality
update example to demonstrate save/restore

File Changes

M examples/example-dockpanel/src/index.ts
https://github.com/phosphorjs/phosphor/pull/222/files#diff-0 (30)
M packages/widgets/src/docklayout.ts
https://github.com/phosphorjs/phosphor/pull/222/files#diff-1 (355)
M packages/widgets/src/dockpanel.ts
https://github.com/phosphorjs/phosphor/pull/222/files#diff-2 (34)

Patch Links:

https://github.com/phosphorjs/phosphor/pull/222.patch
https://github.com/phosphorjs/phosphor/pull/222.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/phosphorjs/phosphor/pull/222, or mute the thread
<https://github.com/notifications/unsubscribe-
auth/AABr0Mza1e_JX9_Kp9sFxw_w0ob3nNZXks5riiIrgaJpZM4MTShc>
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/phosphorjs/phosphor/pull/222#issuecomment-284205067,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIYSZ679oNBMPBSNdW9eJ-I58PSwsbCks5rijykgaJpZM4MTShc
.

@sccolbert One item you might want to consider at the top level is a version number for your main object structure?  IMO You have two choices:

Include the package version number, IOW the version of phosphor at the time the structure was created:
Maintain a separate "save" version which changes if/when your saved structure changes
(or both)

Question:  If a panel contains a "widget" are there hooks for that widget to append information to the layout?

@GordonSmith A version number is one way to deal with it. Another one I was thinking about is that as/if we add functionality, I simply make a saveLayoutV2/restoreLayoutV2, saveLayoutV3/restoreLayoutV3, etc... methods. That prevents downstream users from having to switch on a version number. They can simply update to the new functionality at their leisure.
Wrt appending information to the layout: in what fashion do you mean? Do you have a use case in mind?

@sccolbert I was thinking the other way round - I reach into my DB an pull out a layout, it would be nice to know either which version of phosphor created it, or which version of layout it is..

@GordonSmith Since the layout holds widget objects, you'll still need your own serialization step to convert it into something you can store in your db. But let me think if I can come up with a type-safe way to handle this...


Core ledger interactions should utilize the default chain id

As of<EMAIL_ADDRESS>the default_chain_id is not being used in termination_abci.
It's possible there are other such occurrences.

@0xArdi Is this issue resolved? Because I can see default chain id being used here.

@Devanshusisodiya looks like it was added to termination. We need to check if all such occurrences have been addressed.

@0xArdi are all functions using get_contract_api_response performing core ledger interactions? In that case default_chain_id should be used as a parameter in all of them according to the issue definition right?


Blacklist language-autotools for Makefiles

The current version messes the indent_size up (see #181)

Given the age of the issue, I'm not sure this will be resolved. But the package is not respecting rules for Makefile in the .editorconfig file. Possibly related to this.

@shellscape Whatever you're observing, it likely isn't related to this issue (@florianb likely forgot to close this after #181 turned out to be unrelated.
Please file a new issue for this. Remember to include your local config and list of installed packages.


Build(deps-dev): Bump @types/file-saver from 2.0.5 to 2.0.7 (#5265)

Pull request opened by the merge tool on behalf of #5265

Merged in a3714735f37a7edf59230d870ec8f6610e3e8804


configure problem with unusual Lua directory layout

The following ./configure incantation yields an unwanted LUA_SUFFIX=5.3 in config.unix (the binary is called lua):
./configure --prefix=/home/siffiejoe/.self/programs/luarocks-2.2.0/ --lua-version=5.3 --versioned-rocks-dir --force-config --with-lua=/home/siffiejoe/.self/programs/lua5.3 --with-lua-include=/home/siffiejoe/.self/programs/lua5.3 --with-lua-bin=/home/siffiejoe/.self/programs/lua5.3 --with-lua-lib=/home/siffiejoe/.self/programs/lua5.3

and I can't specify an explicitly empty --lua-suffix, so I had to edit config.unix by hand. The reason seems to be that the search_interpreter function refers to an outside loop variable suffix.

Does changing all instances inside search_interpreter from $suffix to $LUA_SUFFIX fix this?

@hishamhm: No, but it sounds like a reasonable change anyway. Changing if [ -n "$find_lua" ] to
if [ -n "$find_lua" -a -x "$find_lua/bin$LUA_SUFFIX" ]
seems to fix it.

Got it. This should fix it. (I'm fixing the testsuite for 5.3 in the meantime :) )

Thanks for the cprint fix while I was having dinner! :)


Carbon Design in VueJS -- Carvue

Detailed description
Hi, guys,
I really appreciate your works, Carbon Design is such great design.
And I am familiar with VueJS, so I implemented a UI components library according to Carbon Design with VueJS which name is Carvue
this is REPO
and Live Demo
To be honest, there is still so much work I should do, and I am still working on it.
Just Let you know it exists

The demo looks awesome! Great to see your effort and thank you for letting us know!

@nicholaslee119 This is great! Thanks for taking the time to work on this implementation! Looking forward to seeing the progress you make on this 🎉

Hi guys,
I am working on making a website for carbon design in VueJS, and here it is CarvueJS
And I am wondering could I use some materials from http://carbondesignsystem.com/
such as some icons, or some pictures?


Add ruby-head as a allow failures in .travis.yml.

Summary
I added "ruby-head" as a "allow_failures".
Details
Motivation and Context
See https://github.com/cucumber/cucumber-ruby/pull/1087 for detail and the motivation.
How Has This Been Tested?
Travis tests my modified code.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I've added tests for my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Good idea!


fuzz test: Fix clearing buffers

Commit Message: fuzz test: Fix clearing decoding_buffer and stats.
Additional Description:
In filter_fuzz_test a pointer to a buffer was stored, that could have
been freed between two fuzzer runs. Furthermore are stats reset, that
should be zero for each fuzzer run.
Signed-off-by: Andre Vehreschild<EMAIL_ADDRESS>Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign-from @envoyproxy/x41-fuzz-triage
CC @adisuissa @KBaichoo @pradeepcrao


Enable azure-keyvault metapackage during build

enable azure-keyvault metapackage. ignore pylint errors. mypy has not opted in

Can one of the admins verify this patch?


Agitoon : Network request Failed

Source information
Agitoon
Steps to reproduce
Type error : Network request failed.
Expected behavior
It may domain has changed.
Sometimes the number of domain has change
Like at this time domain is “ https://agit556.xyz/” but few days ago it was “ https://agit554.xyz/“
Actual behavior
Sometimes the number of domain has change
Like at this time domain is “ https://agit556.xyz/” but few days ago it was “ https://agit554.xyz/“
LNReader version
1.1.15
Android version
AOS 13
Other details
Please fix this issue🙏
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 1.1.15.
[X] I have updated all installed extensions.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

My bad
It works well


fix method invocation automatically unescape

Description
Do not automatically unescape params in method invocation.
Issue reference

Please reference the issue this PR will close: #4008
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[x] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@Taction can you check why e2e tests are failing?

@Taction can you check why e2e tests are failing?

Sure, I'll look into it asap.

@yaron2 I have fixed the e2e. This code https://github.com/dapr/dapr/blob/master/pkg/channel/http/http_channel.go#L193 will format the URL to http://localhost:3000//method in some cases, if fasthttp don't parse it will cause an error.
The latest e2e is a connection error, I don't think it is related to this pr and will try to look into it later.

Thanks @Taction.
@artursouza can you please look at this and share your opinion about the possibility of this being a breaking change in the encoding parsing format?

Hi, do you think this can be merged for the next release : )

Can we have E2E test for this?

@artursouza e2e test added.

Hi, do you think this can be merged for the next release? Cheers.

Tossing in my request for a merge too.

@artursouza please approve too. E2E are added.

Thanks for the fix @Taction!


Many elements are styled directly rather than through a class

Why are many elements styled directly rather than through a class? e.g. tables
What is the reasoning behind it? Bootstrap, for example, doesn't seem to do this.

I've been a Bootstrap user for years. I still use it in some projects. In my experience, I've never used a
, for example, without
. It's redundant. They're not custom components, they're just elements such as headings, links, etc. The latter are styled by default (in Bootstrap too), so why not other elements?
I've also never used an input in Bootstrap without <input class="form-control">. Why would one want styled inputs on one part of the page and unstyled inputs elsewhere?
If the answer is "because it makes it easier to style myself" then I could argue that it actually makes it harder. Shoelace provides a minimal reset that makes it much easier to override its default styles than starting from scratch.
All in all, Shoelace !== Bootstrap. It's a forward thinking experiment that may break paradigms here and there :)

In my experience, I've never used a
, for example, without
. It's redundant. They're not custom components, they're just elements such as headings, links, etc. The latter are styled by default (in Bootstrap too), so why not other elements?

I actually quite like this argument. Never thought about it that way, but it makes a lot of sense, especially considering Shoelace's general philosophy.

Note that Bootstrap v1 automatically styled tables as well.
http://bootstrapdocs.com/v1.4.0/docs/#tables
Might be interesting to understand why they changed that.

I'd be interested to know that to. I assume it was to please people who used tables for non-table purposes (which is IMO not a good reason).

Bootstrap made this change so that you could use external JavaScript widgets on the page without the default styles trashing their layout. In particular the default table classes caused problems with the jQuery UI DatePicker widget, and apparently the default form styles were also problematic.

Thanks for the links. I think that made sense five years ago, but it's less relevant these days. 😄
I know some people will disagree with my decision, and I realize some third-party controls may still utilize tables [incorrectly] as layout devices. I'm OK with a style collision here and there (although I haven't run into any yet). Until we have custom elements to provide better namespacing, these things will continue to happen no matter how hard to try to avoid it.
I prefer convenience over redundancy.
Most projects these days are aware that they need to provide a certain level of specificity and "resets" of their own to ensure a consistent appearance. Worst case, the developer can choose to patch any display issues they run into themselves. (I suspect there won't be many with modern controls.)
At the end of the day, my argument for styling
 without a class is the same for styling  or
 or even  — it's an element, not a component, and Shoelace treats it as such.

@claviska Yeah, I think you've probably made the right decision. I just saw that someone asked about the reasoning behind Bootstrap's decision and I remembered those issues.

No worries. And I wasn't trying to target you specifically. Lots of eyes on this project today and people have certain expectations ("why isn't this like Bootstrap?") so I wanted to write down my thoughts.
I try to keep an open mind, so if there are other valid arguments I'm happy to listen.

@claviska  for what it's worth, I'm wondering if the logic behind it isn't that, when you want a differently styled variant, you just have to remove a class. In this case you'd need to explicitly unstyle all of the defaults

In this case you'd need to explicitly unstyle all of the defaults.

Well, it's either:

Set defaults and require users to override a handful of properties if and only if they want to create a special variation

OR

Don't set defaults and make users add redundant classes every time they want a table to look like a table

If you think about it, # 1 actually makes a lot of sense because the default styles are minimal and any variations a user wants to make will have a starting point that, aesthetically, is consistent with the rest of the library.
At least that's my thinking. 🤷🏻♂

@claviska  it's reasonable thinking, and great job with the cool project :)


LoggingServiceV2Client.WriteLogEntries requires not-null entryLabels

LoggingServiceV2Client.WriteLogEntries method has a number of parameters and one of them is entryLabels. These are supposed to be optional labels that you can attach to the log. However, you cannot pass in null for entryLabels. If you do, you get a "value cannot be null" error. So, in effect, these labels are not really optional.
The workaround is to create an empty Dictionary and pass that for entryLabels but this is not ideal.
You can use the following code to reproduce the problem, just replace entryLabels with null:
https://cloud.google.com/logging/docs/reference/libraries#client-libraries-usage-csharp

Assigning Chris to look into this - basically it's a case of parameter flattening. A couple of options:

We could accept null for map/repeated fields, and simply not assign that when creating the request
We could add extra flattenings

I've just seen that the gapic yaml contains a list of required_fields for each flattening. E.g.: https://github.com/googleapis/googleapis/blob/master/google/logging/v2/logging_gapic.yaml#L341
So I'll see if I can make a change to accept null, and not assign, for flattened parameters that are not specified as required.

This was fixed in toolkit#1051, and the optionality of it can now be seen in LoggingServiceV2Client.cs line 638.


fix(export): 优化复制数据到剪贴板的逻辑

👀 PR includes

✨ Feature

[ ] New feature

🎨 Enhance

[x] Code style optimization
[x] Refactoring
[ ] Change the UI
[ ] Improve the performance
[ ] Type optimization

🐛 Bugfix

[ ] Solve the issue and close #0

🔧 Chore

[ ] Test case
[x] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

📝 Description

优化复制数据的处理逻辑
优化相关文档
修复类型错误

🖼 Screenshot

Before
After

❌
✅

🔗 Related issue link

cc @YardWill @zxc0328
🔍 Self Check before Merge

[x] Add or update relevant Docs.
[x] Add or update relevant Demos.
[x] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-v1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-react-v1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(MockHttpSocket): exhaust .write() callbacks for mocked requests

The socket now correctly emits the finish event for mocked responses.
The socket now calls all the .write() callbacks for mocked responses.
The socket now correctly emits the end event when the readable ends.

Todos

[ ] Fix the event order: https://github.com/mswjs/interceptors/pull/542#discussion_r1545794943

Hi, @mikicho 👋 This is the fix for the finish event not being emitted for mocked requests. Can you please give it a look and see if you spot anything off? Thanks.

Test run
For some reason, CI didn't trigger on this pull request. Sharing the test runs below.
Unit tests
pnpm test:unit

 Test Files  24 passed (24)
      Tests  143 passed (143)
   Start at  12:51:24
   Duration  11.62s

Integration tests (Node.js)
pnpm test:node

 Test Files  1 failed | 85 passed | 1 skipped (87)
      Tests  1 failed | 277 passed | 2 skipped (280)
   Start at  12:52:02
   Duration  37.81s

The failing test can be ignored. It's modules/http/compliance/http-errors.test.ts > forwards EHOSTUNREACH error for a bypassed request and it fails only on my machine (it never emits that precise error for me).

I just tested it, and it fixed some tests, YaY.
However, I encountered an interesting time-based edge case that our tests caught.
I'm not sure if this is the expected behavior, but somehow, Nock preserves the same event order as Node.
Anyway, if you think about something quickly, it should be cool; if not, we may revisit it later.
Scenario A - quick abort:
const http = require('http')
const sinon = require('sinon')
const { ClientRequestInterceptor } = require('@mswjs/interceptors/ClientRequest')

const interceptor = new ClientRequestInterceptor()

interceptor.on('request', async function rootListener({ request }) {
  request.respondWith(new Response('OK!'))
})
// interceptor.apply()

const req = http.request('http://example.com')
const emitSpy = sinon.spy(req, 'emit')

req.on('finish', () => {
  setTimeout(() => {
    req.abort()
  }, 10)
})
req.end()

setTimeout(() => {
  console.log('unmocked');
  console.log(emitSpy.args.map(i => i[0]));
}, 500)

➜  nock git:(Michael/fetch-support) ✗ node a.js
unmocked
[ 'socket', 'prefinish', 'finish', 'response', 'close', 'abort' ]
➜  nock git:(Michael/fetch-support) ✗ node a.js
mocked
[ 'socket', 'prefinish', 'finish', 'response', 'close', 'abort' ]

Scenario B - abort after long time:
const http = require('http')
const sinon = require('sinon')
const { ClientRequestInterceptor } = require('@mswjs/interceptors/ClientRequest')

const interceptor = new ClientRequestInterceptor()

interceptor.on('request', async function rootListener({ request }) {
  request.respondWith(new Response('OK!'))
})
// interceptor.apply()

const req = http.request('http://example.com')
const emitSpy = sinon.spy(req, 'emit')

req.on('finish', () => {
  setTimeout(() => {
    req.abort()
  }, 1000)
})
req.on('error', err => {
  // console.log(err);
})
req.end()

setTimeout(() => {
  console.log('unmocked');
  console.log(emitSpy.args.map(i => i[0]));
}, 5000)

➜  nock git:(Michael/fetch-support) ✗ node a.js
mocked
[ 'socket', 'prefinish', 'finish', 'response', 'close', 'abort' ]
➜  nock git:(Michael/fetch-support) ✗ node a.js
unmocked
[ 'socket', 'prefinish', 'finish', 'abort', 'error', 'close' ]
➜  nock git:(Michael/fetch-support) ✗

For small abort timeout, we emit response event that Node.js doesn't.

@mikicho, we should improve event compatibility but it's out of scope of this change. The order of abort/error/close events is also off compared to Node.js. Let's tackle those separately.
For now, some XHR tests are failing and I need to look at why. Fail in the base feature branch also, so unlikely to be relevant to these changes.

@kettanaito Agreed.

For now, some XHR tests are failing and I need to look at why. Fail in the base feature branch also, so unlikely to be relevant to these changes.

I saw this failing test and expected them to reflect in one of Nock's, but it didn't (although I skipped on around ~40 for now). It surprised me a little.
Can you please take a look at this before merging this PR? https://github.com/mswjs/interceptors/pull/542#discussion_r1545794943

The failing test has been resolved in the base feature branch. I forgot to migrate the new interceptor to use a fixed request ID header vs the hard-coded x-request-id string, which broke the XHR -> ClientRequest interceptors deduplication and resulted in extra request/response events on the interceptor.

It fixed more tests!

(P.S.: Some tests have revealed that Nock is not behaving properly, and the new interceptor has found the issue!)

That is the best kind of discovery! Yohoo! Should we merge this?


JS: torrent content as a remote flow source

This PR makes us treat most content of torrents parsed by parse-torrent as untrusted. Such torrent content was the taint source in CVE-2019-15782 (we do not flag this vulnerability yet, we are missing a flow step elsewhere).
Implementationwise, I would have liked parseTorrent(...) to be a labelled RemoteFlowSource, and then let the flow label mechanism ensure that we only propagate through certain properties of the parsed torrent, but that requires unreasonable adjustments in all Configurations.
Instead, I have used type tracking to track the parsed torrent, and then used certain property reads of that tracked torrent as ordinary RemoteFlowSources. This leads to sub-optimal sources in the path-problem alerts, but it is the same pattern as the one we use for RequestInputAccess: we do not provide a link to the request object itself, but rather a use of it.
Generally speaking, this new source is related to the js/zipslip sources where we model that something is expected to be provided by external parties and thus should not be trusted. We should investigate such sources more thoroughly, and perhaps even deprecate js/zipslip in favor of a js/path-injection with zip-file content as a RemoteFlowSource.
Evaluation

3 likely TPs among some packages that have parse-torrent as a dependency.
sanity check on nightly.slugs (ongoing)

Uninteresting evaluation. Good to go.


datetime.strftime('%s') is not supported in Windows platform

in file qtpylib/reports.py. it use datetime.strftime('%s'). this format seems only supported in unix system. it will raise an Error in Windows platform. see the answer of Ulf Aslak in stackoverflow
In python's official doc: https://docs.python.org/3/library/datetime.html#strftime-strptime-behavior . the format '%s' is not mentioned also.

Fixed. Forgot to close this issue


added disable-enable actions

Implemented the action endpoint routes for enabling/disabling the status for products
Wrote appropriate test cases for same

Codecov Report

Merging #79 (a4b5473) into main (124d1ec) will decrease coverage by 0.08%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   95.42%   95.34%   -0.09%
==========================================
  Files           6        6
  Lines         284      322      +38
==========================================
+ Hits          271      307      +36
- Misses         13       15       +2

Impacted Files
Coverage Δ

service/routes.py
97.16% <90.90%> (-1.64%)
:arrow_down:

service/models.py
93.33% <100.00%> (+0.22%)
:arrow_up:

service/products.py
98.14% <100.00%> (+0.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124d1ec...a4b5473. Read the comment docs.


Add covenants review to bitcoin-design/learning-bitcoin-and-design

This PR adds covenants transcript review to the bitcoin-design/learning-bitcoin-and-design directory.

I  must say, your editing style truly stands out. You're doing an exceptional job at enhancing the readability and overall quality of our transcripts. I've made some minor edits and adjustments on top of your work, including breaking some longer segments into smaller text blocks, which I believe further aids in making the transcript more accessible to the readers.
While reviewing, I noticed instances of paraphrasing within the transcript. I want to clarify our transcription style as outlined in our review guidelines, which we refer to as clean verbatim transcription, or "edited" for short. This style aims to deliver the speaker's exact words, refined to omit filler words, stammers, and non-verbal interruptions. The goal is to ensure the transcript remains true to the original speech while being polished for readability. I recognize that the term "edited" might have led to some confusion, and I'll be looking to clarify this in our guidelines. That being said, the places where you've applied paraphrasing were done with precision and greatly contributed to the readability of the transcript. Your ability to recognize where such changes make sense is commendable and you can keep doing that if you want.
Keep up the great work and please continue to bring your keen eye and thoughtful edits to this project. Looking forward to your continued excellent contributions, @varmur!

I must say, your editing style truly stands out. You're doing an exceptional job at enhancing the readability and overall quality of our transcripts. I've made some minor edits and adjustments

Thank you, @kouloumos, for your appreciation, it's a delight to have a reviewer and guide who is keenly interested in making these transcripts the best they can be. The adjustments you made addressed several issues I had, such as breaking the flow of walls of single speaker sections with empty lines, and enclosing editor changes or annotations in parentheses, which I will incorporate in future contributions.

While reviewing, I noticed instances of paraphrasing within the transcript. I want to clarify our transcription style as outlined in our review guidelines, which we refer to as clean verbatim transcription, or "edited" for short.

Good to know that my occasional paraphrasing did not change the intended meaning of the speaker. I aim to only do these where it enhances readability, the written phrase has different means of communicating cadence and rhythm from the spoken one. If I go too far, I see that I can trust you to catch and correct them!
Your thorough reviews and detailed suggestions (across many previous pull requests, as well as this one) are truly helpful in communicating what is expected, and the goals we are striving for. I just read the Reviewer Manifesto you've posted in the Issues section, and thought it was very well written.

Your thorough reviews and detailed suggestions (across many previous pull requests, as well as this one) are truly helpful in communicating what is expected, and the goals we are striving for. I just read the Reviewer Manifesto you've posted in the Issues section, and thought it was very well written.

I'm glad that previous reviews have been beneficial to you. Our aim is to make the review process as clear and helpful as possible, and feedback like yours is invaluable in achieving that goal.
Towards that end, starting with your recent submission, we're exploring the idea of assigning different labels to reviews. This initiative is designed to help other reviewers more easily identify exemplary reviews and learn from them. Additionally, it will enable me to more efficiently highlight noteworthy examples. This approach was challenging to implement previously, mainly because we didn't include the original AI-generated transcripts in the repository, making it difficult to track the specific changes made by reviewers.
Regarding the Reviewer Manifesto, my plan is to eventually incorporate it into our main website, ensuring it's one of the first resources new contributors encounter. Since it's still relatively new and feedback is sparse, I'd greatly appreciate any thoughts or suggestions you might have.
I'm keen to discuss your review process and experience further on our Discord server; your insights are invaluable and could significantly shape our project's direction. Thank you for your dedicated contributions—your input is crucial as we strive to continuously improve our review process.

I'm keen to discuss your review process and experience further on our Discord server

I get an invalid or expired invite error.


missing parameter BROWSER_AUDIENCES in docs

I think also to a part in the docs for autologin for fast development, i'm following the django-browserid docs but i have some problems

Thanks for this PR @Mte90!
In case you are trying to setup the ReMo portal locally, please keep in mind that the vagrant method is deprecated and the recommended option at this point is through virtualenv [0]. There is also a Dockerifile and soon new documentation is going to be added for this option as well.
Thanks again for your contribution! r+ :ice_cream:
[0] http://remo.readthedocs.org/en/latest/installation-virtualenv.html

i've see that vagrant have some problems, for this reason i've created this script https://gist.github.com/Mte90/43d38ed65d415c6679eb (also configure remo and execute few manage.py commands)


Problems with execution of openssl version

Hi there.
I am looking for the intergration of a new QKD cipher suite into the OpenSSL library,
so for that I need to understand very well how it works.
I have found a guide to integrate a new cipher suite into the library, which is the case of aria cipher suite.
To understand exactly what steps should I take to integrate it, I am trying to extract it from the library, compile the new library without aria and, when I have proven its correct functioning, re-integrate aria step by step.
There are no failures on ./config, make, but in make tests appears errors in some tests (test_md2, test_ rc5, test_enc, test_gost, test_overhead, test_external_boringssl, test_external_krb5, test_external_pyca).
I think everything is ok because the errors are not fatal (md2 and rc5 not implemented on this version, no test GOST engine found...), and in the make install step everything is ok.
Now, exploring the directory /usr/local/, you can find all the binaries and libraries that are listed in the file INSTALL.
The error appears here:
            $ openssl version -a
            openssl: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

I understand this is out of the scope of the project, but ¿anyone can give me some advice? I am not able to find the error.

Try:
LD_LIBRARY_PATH=/usr/local/lib openssl version

To better understand what is happening and why Matt's advice works you should familiarize to how shared libraries work in Linux: http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html

I'd also suggest carefully reading the file NOTES.UNIX
https://github.com/openssl/openssl/blob/master/NOTES.UNIX
In particular the section on "Shared libraries and installation in non-default locations"

Effectively this works, thank you all very much, I will.


Peer to Peer Code Review

Good job so far!
Your code is very clean and works great. There are some improvements you can make, though these are all optional! :

Your deployment seems to launch on the README file instead of the dist folder. Be sure to make the link redirect you to that folder
Very well done on the fetching and generating data of your API. Be sure to check applications and clients like Postman or curl in your command line, so that you don't have to create new games or initialize the API from the code alone.

THank you @Arch-Noize  👍 👍


Joystick input for sliders is not reported

Using a Thrustmaster Warthog Throttle which has a "Slider". It seems to be different from a normal axis because events are not reported, even though it moves in the Windows properties window:

Any idea why that would be happening? Would I have to implement that, if so can you give me a lead where to start?
Cheers

Yeah I think I know what might need doing here (even though I can't test this myself. I attempted to add support on the branch "slider_test". Let me know if it works and I'll merge it in!

slider_test sure can be merged, works as expected now. You really are on fire today 😄 Thanks!
(also I love using Gitter for projects I am involved in)


Updates to plugin

Draft PR for the time being. Will edit this as more things are changed.
Currently added/changed:

Implemented discovering keepass-proxy path by reading Chrome Native Messaging manifests. For users that don't have keepass-proxy on PATH, this should be able to still find keepass-proxy. If users do not already have it enabled, they will need to enable browser integration for Chrome to use this method of discovery.

merged as 0107099e89a85bf5a295c7ee9a1b907320b73a0a...188b3249501ffa321d0b67cd3840ea83661e31b2

merged as 0107099e89a85bf5a295c7ee9a1b907320b73a0a...188b3249501ffa321d0b67cd3840ea83661e31b2


Suggestions

This is a great tool and saved me a lot of time. Two suggestions:

CSV files should be created for every month and not year. Much easier to handle the data size-wise.
There should be an option to filter symbols. I only needed it for XBTUSD but had to load large datasets again and filter the required symbol.

I know these are very small changes but python handicap like me struggles moving large datasets.

@danishhasan2 thanks for the suggestions, I'll look into doing this sometime soon

@bmoscon great package thank you for sharing. FYI i actually needed the symbol filtering feature so just added it in my fork.
Just added a simple filtering function using panda since the package was already in the requirement.txt
Happy to submit a pull request if of interest.


Energy fix examples

@mrutkows here are the needed fixes for the examples.
and i've brought the description back


Use tables for the alumni lists on the members page

This is a good enough start. Other lists can be converted to tables in new PRs.


Fix corner cases for peers bootstrapper

WIP still have not finished tests, published this ahead of time to get early eyes.

Coverage decreased (-0.4%) to 78.423% when pulling 8f536fb70144bd700c4936856cf14a97f6115bf5 on peers-bootstrap-fixes into bd87191334e36bf1a89b19c160f6b9a29d10344a on master.


Document intake process

The intake process is not/barely documented, this should be changed especially since it's not possible to change some attribute via the API (See #485).

Intake process integrated and documented.


[WIP] Fix overloading ambiguity in ndimage filters

Close #6048.

Jenkins, test this please

ok the change does not break anything. Later I'll fix flake8, expand the coverage (there are other ambiguities), and add tests.

Jenkins, test this please

/test mini


Allow @ApiModelProperty allowableValues property to be set using application properties

Hi people,
Currently (version 2.9.2) the allowableValues only accepts a comma separated string as value. It would be very nice if it would also accept an application properties value (same as the value property does) so I can reference defined properties. In my case I have a list of acceptable languages in the properties file and I have to hardcode something which is defined in the properties making the API docs wrong (if the properties are changed during the deployment) and/or having unnecessary hardcoded constants in my code.
Thank you

Facing similar issue here. Any news?