migmix: init at 20150712

Motivation for this change
migmix is one of high-quality free Japanese font.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] ~Tested execution of all binary files (usually in ./result/bin/)~
[x] Fits CONTRIBUTING.md.

Thanks!

@Mic92 Thank you for your improving. I have a question about sha256 and outputHash. Where do you retrieve these value? Is there a command?

By building the font with a wrong checksum and taking the correct one from the build log.


Add pack privacy switch

Closes #8
Add a switch on the pack edit view for users to make their pack public or private.
Because all packs created so far have the default value of public: false in the database but packs are actually public no matter the value, after merging this PR I recommend running the following command in the database so that all existing packs are public.
UPDATE packs SET public=true;
If you'd like me to add a sequelize migration, I can certainly do it, I just wasn't sure what kind of workflow exists for how the production database is managed by code.

Here's a short clip that demonstrates that the user who is the owner of the pack can view their own pack whether or not it's private, but other users (including both users that are not logged in and users that are logged in) cannot view when the pack is marked private.
https://user-images.githubusercontent.com/1940054/105613847-15aa7380-5d93-11eb-95e6-5872f7a7202e.mp4
The tooltip says "When public, the pack will be viewable by anyone with a link".

This will need to be updated after MR #41 is merged.

This will need to be updated after MR #41 is merged.

Really nice 🎉 !
What do you think about the UX for when a Pack is not public? To me the spinner+pop-up says "something accidentally went wrong", where I think want we want here is more of "something is deliberately not allowed/found"... if that makes sense? Maybe a static (read: less spinny) page with a 404 and message like "Either the pack does not exist or you do not have permission to see it", or just "Pack not found" to give less away. What do you think?

Really nice 🎉 !
What do you think about the UX for when a Pack is not public? To me the spinner+pop-up says "something accidentally went wrong", where I think want we want here is more of "something is deliberately not allowed/found"... if that makes sense? Maybe a static (read: less spinny) page with a 404 and message like "Either the pack does not exist or you do not have permission to see it", or just "Pack not found" to give less away. What do you think?

Also what do you think about adding a marker of some sort on the owner's view pack page?

Also what do you think about adding a marker of some sort on the owner's view pack page?

Good point! That certainly makes more sense.
I don't think there are any existing full page error status pages, but I can make one. I'll also add something to the owner's view pack page that indicates public/private. Thanks!

Good point! That certainly makes more sense.
I don't think there are any existing full page error status pages, but I can make one. I'll also add something to the owner's view pack page that indicates public/private. Thanks!


Wrong shipping method displayed after SalesChannelContextSwitcher::update

PHP Version: 8.3   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Expected behaviour:
Cart displays the selected shipping method
Actual behaviour:
Cart uses the old shipping method for the initial load.
After the first load, the shipping method is displayed correctly.
How to reproduce:

Create a subscriber for the OffcanvasCartPageLoadedEvent
Change the current shipping method in the function with SalesChannelContextSwitcher
2.1 For this you can just use a simple logic like "if product x is in the cart change shipping method to Express"
Add product x to an existing cart

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39743
[created from NEXT-39743, comment 515609]


Deactivate User

Implement deactivating user on both profile page and on the complaint page. Block the services and events too and work on applications. Give credits back too.

Deactivation for users is implemented.


iOS 13 not working?

Bug
Only on iOS 13 does not work and gives me this error, iOS 12 works properly.

Environment info

React native info output:
React Native Environment Info:
    System:
      OS: macOS 10.14.5
      CPU: (4) x64 Intel(R) Core(TM) i5-4258U CPU @ 2.40GHz
      Memory: 629.88 MB / 8.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 8.11.1 - /usr/local/bin/node
      Yarn: 1.17.3 - ~/.yarn/bin/yarn
      npm: 6.7.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 13.0, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
      Android SDK:
        API Levels: 19, 23, 24, 25, 26, 27, 28
        Build Tools: 23.0.1, 23.0.2, 23.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3, 28.0.0, 28.0.0, 28.0.1, 28.0.2, 28.0.3, 29.0.0
        System Images: android-25 | Google Play Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom
    IDEs:
      Android Studio: 3.4 AI-183.6<IP_ADDRESS>92245
      Xcode: 11.0/11A420a - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.9 => 0.59.9
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-cli: 2.0.1
      react-native-create-library: 3.1.2
      react-native-git-upgrade: 0.2.7

Library version: 1.1.0
Steps To Reproduce

run code ImagePicker.showImagePicker for pick a video
wait callback response
message: 'Response = ', { error: 'You don’t have permission.' }

Describe what you expected to happen:

run code ImagePicker.showImagePicker for pick a video
wait callback response
The video has been uploaded correctly

Reproducible sample code

Use the code in Readme under Usage.

I fixed it by changing moveItemAtURL to copyItemAtURL at line 459 on ImagePickerManager.m

We encountered an issue on iOS 13 and ended up discovering the same fix that @zirkc recommended. For us, changing copyItemAtURL to moveItemAtURL on that line resolves the issue. The tradeoff is that the original file is not being removed from its source location, which appears to be in a /tmp directory. I assume this /tmp directory will be periodically emptied though.

Being very new to iOS development, after finding the same fix, I'm left scratching my head and wondering how much do I really know about file permissions re: move vs copy?

prob because you are not allowed to remove items from certain directories.

#1118

For those interested in the patch-package file on 0.28.0 (react-native-image-picker+0.28.1.patch) :
diff --git a/node_modules/react-native-image-picker/ios/ImagePickerManager.m b/node_modules/react-native-image-picker/ios/ImagePickerManager.m
index 28d5870..8c060b1 100644
--- a/node_modules/react-native-image-picker/ios/ImagePickerManager.m
+++ b/node_modules/react-native-image-picker/ios/ImagePickerManager.m
@@ -456,7 +456,7 @@ - (void)imagePickerController:(UIImagePickerController *)picker didFinishPicking

                 if (videoURL) { // Protect against reported crash
                   NSError *error = nil;
-                  [fileManager moveItemAtURL:videoURL toURL:videoDestinationURL error:&error];
+                  [fileManager copyItemAtURL:videoURL toURL:videoDestinationURL error:&error];
                   if (error) {
                       self.callback(@[@{@"error": error.localizedFailureReason}]);
                       return;

please, merge it

hmm I changed it locally on my node module and it's still crashing for me - am I missing something?

@mdere-unbound did you rebuild the app in Xcode after making the change?

@mdere-unbound make sure you also follow the post install steps to include the necessary permissions in Info.plist


Add Canonical On-Prem and Managed, Correct URL

Ubuntu / Canonical also provides deployment options for on-premesis and managed Kubernetes, as linked on our Kubernetes landing page.

I signed it

/lgtm
/approve


Fix a segfault in debug mode with lightpack

1. Tell us something about your changes.
This fixes a segmentation fault in debug mode with a Lightpack device.
Without this change:
#
./bin/hyperiond  -d
[hyperiond MAIN] <INFO> Set user data path to '/home/patrick/.hyperion'
...
[hyperiond LEDDEVICE] <DEBUG> <LedDeviceLightpack.cpp:97:open()> USB context initialized
[hyperiond LEDDEVICE] <INFO> Found a lightpack device. Retrieving more information...
[hyperiond LEDDEVICE] <DEBUG> <LedDeviceLightpack.cpp:168:testAndOpen()> Lightpack device found: bus=3 address=116 serial=9523030323**********
[hyperiond LEDDEVICE] <INFO> Lightpack device successfully opened
Segmentation fault (core dumped)

With this change:
./bin/hyperiond  -d
[hyperiond MAIN] <INFO> Set user data path to '/home/patrick/.hyperion'
...
[hyperiond LEDDEVICE] <INFO> Found a lightpack device. Retrieving more information...
[hyperiond LEDDEVICE] <DEBUG> <LedDeviceLightpack.cpp:162:testAndOpen()> Lightpack device found: bus=3 address=116 serial=9523030323**********
[hyperiond LEDDEVICE] <INFO> Lightpack device successfully opened
[hyperiond LEDDEVICE] <DEBUG> <LedDeviceLightpack.cpp:228:testAndOpen()> Lightpack device opened: bus=3 address=116 serial=9523030323********** version=6.5.
...

2. If this changes affect the .conf file. Please provide the changed section
N/A
3. Reference an issue (optional)
N/A
Note: For further discussions use our forum: forum.hyperion-project.org

Merci beaucoup 👍


fix: go back to use a fixed version for the CSI deployment

We're going back to use a fixed version of the deployment until we have a release
and we can use the kubernetes-latest path

/ok-to-merge fixing CSI deployment


[multitop_dev][WIP] Port DIF to multitop and two FPGA tests

This PR adds the DIF modifications for DT and ports two test: aon_timer_test and sysrst_ctrl_outputs.
Since we don't have a darjeeling top yet, I had to mark the dma, keymgr_dpe and mbx DIFs as incompatible. This will be changed when we have a proper top and a configuration selection for the top.

This PR was getting big so I split it into two, the second part is #25161


Not working on Safari Desktop 13.0.5

I haven't tested with other versions, but it scrolls on this version for sure. Perhaps related to #1?

Seems to be because the overflow: hidden gets applies to the body, not the html 🤔 If I do it on html it locks it just fine


Timeline not rendered when load with peaks

Hi,
When use timeline pluging and load wavesurfer with peaks, timeline is not rendered before you play song.
Wavesurfer.js version(s): (1.2.3 see codepen beelow) and local test : v2.0.0-beta01,  v2.0.0-beta02
Browser version(s): FireFox : 57.0.2 Quantum, Chrome : 63.0.3239.84 (Build officiel) (64 bits)
Code needed to reproduce the issue:
To reproduce, I use https://codepen.io/frumbert/pen/MOGrKm  (issue #1260) and add peaks like https://codepen.io/johnsq/pen/KyVOLd
First load, timeline is not rendered, use play and it's visible.
Hope you can reproduce it and render timeline in first load with peaks data.
Regards

Hi,
For your help, this is not look like true if you add backend: 'MediaElement' parameter.

Can you try with the latest 2.0.1?

Hi @thijstriemstra : Same issue.
So, today I can put backend to MediaElement and timeLine is correct, but for zoom issue #1261 no change too in this latest version.


Many source code links are broken

For instance on page DocumentDB Partitioning Samples all links like this:
https://github.com/Azure/azure-documentdb-net/tree/master/samples/partitioning/DocumentDB.Samples.Sharding/DocumentDB.Samples.Sharding/Partitioners/LookupPartitionResolver.cs

should actually lead to:
https://github.com/Azure/azure-documentdb-net/blob/master/samples/code-samples/Partitioning/Partitioners/LookupPartitionResolver.cs

This has been fixed with the latest release.


CSP issue on opensuse

Link to product page on endoflife.date
https://endoflife.date/opensuse
Details of incorrect and correct details you have found
I have the following warning in my browser's console and I do not see the image (on http://localhost:4000/opensuse I see it).
Content Security Policy: The page’s settings blocked the loading of a resource at https://upload.wikimedia.org/wikipedia/en/timeline/qaub9pjgtzf5zjbrlbjruujp47jv6r5.png (“img-src”).

A free account on https://report-uri.com/ may help to catch these issues.

The CSP for this page is:

content-security-policy | default-src 'none'; connect-src 'self'; img-src 'self' https://img.shields.io https://www.netlify.com https://simpleicons.org/ https://github.githubassets.com/ https://user-images.githubusercontent.com/https://upload.wikimedia.org; script-src 'self'; style-src 'self'
-- | --

content-security-policy
	default-src 'none'; connect-src 'self'; img-src 'self' https://img.shields.io/ https://www.netlify.com/ https://simpleicons.org/ https://github.githubassets.com/ https://user-images.githubusercontent.com/https://upload.wikimedia.org; script-src 'self'; style-src 'self'

A space is missing between user-images.githubusercontent.com URL and upload.wikimedia.org URL.


update for zig 0.11.x + package manager

As per title this adds support for Zig 0.11.x and usage with the new built-in package manager.

The current usage in the README still works, however if you use the new package manager you can import the module in build.zig:
const lib_string = b.dependency("string", .{
    .target = target,
    .optimize = optimize,
});
exe.addModule("string", lib_string.module("string"));

Then the import becomes:
const String = @import("string").String;

I need to get around updating the CI to pull the actual latest version. Great work though! I am glad people come by and contribute. 😸


Release binary builds of GodotECS from master

Release binary builds of GodotECS from master as Github releases.
Possible cicd pipelines:

Github actions
My systems

Would you know how to setup the CI to make Godex compile and possibly run tests??

Would you know how to setup the CI to make Godex compile and possibly run tests??

Yes

Yes

Done with: #93 #94.


Additional Code Block ignore example for Readme? Possible default. (suggestion)

I have long been in search of way to ignore all within a backtick whether it be
single backtick
or
triple backtick

or with
Write-Host -Foreground-Color red 'Code tag'

I recently took the time to get a regex string that works, I hope it is of use to others, or if there is issue with it let me know. But if it can be added to the README, I thought it could help save some time for people who want it, or to the default json config?
"/(({1,3})([^]+?)\\\\2)/gm"
Thanks!
-Eric

This extension has had a large number of stability issues based on the availability of the underlying service.  Today I published an update which points users to another extension for Spell Checking.
I'm closing the majority of issues as development on the extension has stopped. Sorry for any inconvenience this caused anyone, the good news is that there are better options out there now that don't require the service.
Sean


[Form] The Float Label Pattern

Hi, it would be very convenient to have floating labels
examples:
http://bradfrost.com/blog/post/float-label-pattern
http://codepen.io/simoberny/pen/gpddYQ
https://css-tricks.com/float-labels-css
http://mds.is/float-label-demo

Would you be willing to take a shot at it with a codepen yourself? Once started, perhaps others can begin to contribute.

Moving it to https://github.com/Semantic-Org/Semantic-UI/issues/3965


CLP-0000: Add "dockerenabled" input to GitOps template

Type of Change

[ ] Bugfix
[x] Enhancement / new feature
[ ] Refactoring
[ ] Documentation

Description

Checklist

[ ] Add relevant labels (for example type of change or patch/minor/major)
[ ] Make sure not to introduce some mistakes
[ ] Update documentation
[ ] Review the Contributing Guideline and sign CLA
[ ] Reference relevant issue(s) and close them after merging

@flaxel Where do I have to sign? :laughing:

I have read the CLA Document and I hereby sign the CLA

recheck


Baseline maintainers and codeowners

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6e85cf5). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 80bcef3 differs from pull request most recent head 65b55d8. Consider uploading reports for the commit 65b55d8 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage        ?   86.54%
=======================================
  Files           ?       51
  Lines           ?     1479
  Branches        ?      365
=======================================
  Hits            ?     1280
  Misses          ?      196
  Partials        ?        3

Flag
Coverage Δ

dashboards-notifications
86.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

No need to backport 2.x.

@opensearch-project/admin, could anyone help to sync this repo's permissions? Thanks.


HDDS-7643. rocksdb iterator is not closed properly

What changes were proposed in this pull request?
iterator creation moved to try-with-resource block
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7643
How was this patch tested?
E2E cases tested and this warning log is not observed in OM

The patch LGTM, +1.  Thanks @sumitagrawl


[3.2] Improved Inspector Sub-Resource Editing

Backport of #45907.

Didn't feel like waiting ¯\_(ツ)_/¯
If any substantial changes occur, I can backport them as well.
CC @Xrayez

Thank you for back porting this!

Excited for this, will it be in 3.2.4?

will it be in 3.2.4?

Unlikely - it's currently in the release candidate phase, so if this PR were to be merged, it would happen in time for 3.2.5.
Disclaimer: I'm not a Godot developer, this PR was created in response to https://github.com/godotengine/godot/pull/45907#issuecomment-778177281.

Consider rebasing your PR to latest 3.2, your current branch is still on 3.2.3-rc which was 7 months ago according to commit history. 🙂
It took me much longer to compile the engine because of that, and other folks might want to test this PR as well.

It may be considered "spam". I just wanted to drop by and let you know how thankful I am for the backport to 3.2
I work a lot with the SmartShape2D Plugin and the resources and sub resources there are a real hell to work with.
Above is a screenshot comparing the two variants and it is obvious how much better the elements are distiguishable 👏

Consider rebasing your PR to latest 3.2, your current branch is still on 3.2.3-rc which was 7 months ago according to commit history. slightly_smiling_face

Indeed, please rebase. I'm surprised it can even be merged without conflicts, but if the base branch is so old, there's no guarantee that it won't actually break the build once merged on 3.2 (the current CI build ran with the config from the base branch).

Rebased to f30d82744817461ff475d9893d48ecf087ad1b43.

Thanks!


Version glitch?

Loaded on 2018.3.7f1:
Assets\PostProcessing\Editor\PropertyDrawers\MinDrawer.cs(6,34): error CS0104: 'MinAttribute' is an ambiguous reference between 'UnityEngine.PostProcessing.MinAttribute' and 'UnityEngine.MinAttribute'

Looks like MinAttribute has been placed in a different namespace in newer versions of Unity. Have you tried changing the import in MinDrawer.cs to UnityEngine.MinAttribute or UnityEngine.PostProcessing.MinAttribute? Does either one work?

Yes, they both work. Your choice.

Finally got around to fixing this. :satisfied:


Feature/frontend i18next translation changes

address this story:  https://www.pivotaltracker.com/story/show/150506204
first attempt at incorporating the i18next library
details on how I arrived at the translation.json/pot files are specified in the gulpfile (i.e. i18next_gulp.js) that I created and ran when testing.
I tried to tag everything where applicable.
debugging mode is enabled in development so can see which translation key/text is targeted
feedback on this is much appreciated.
not for this release, but the next one

@ivan-c  Ivan, I made changes based on most of your comments.  A few things I found when I was making the changes...
Regarding i18next interpolation, I found that in order for that to do, the key and the corresponding translated text will need to be in the source json file already.
Example code in question:
original code in main.js:
"consent to share information with " + orgName
tried changing it to:
i18next.t("consent_key", {orgname: orgName});
for the key to be translated, I needed to add this to the source json for this to work:
{"consent_key": "consent to share information with {{orgname}}"}
hmm..that means we have to maintain some of these key and value pairs?
So my hack was to separate out the text to be translated:
i18next.t("consent to share information with: " )
i18next.t(orgName)
so that each will have a corresponding key and its associated translated text in the source file.
And I am not sure if some of the text generated at runtime will be translated - example will be the error text that are generated as a result of a failed ajax call - I did look into the on missing key event of i18next (the event that runs when a key/value pair is missing from source json file) - it seems that you can run custom code in it to capture some of these missing key/value pairs - but what to do with those is my question - do we store them somewhere and upload those to smartling as well?

@ivan-c @OptimusRhine @pbugni
Closing this for now - will re-open after the release


Sampling at arbitrary positions

Hi, the example in the wiki shows how to use the library in a 3D grid. I would like to provide my own 3D coordinates instead. Is that possible?
As an example imagine that I have an array of particles, and I want to deviate their movement based on the noise. Another example is to generate some properties for vertices of a general mesh.
Thanks

Have a look at the VectorSet struct in the header, you can pass in an array of float vectors to any of the noise functions. It should be mostly self explanatory, let me know if you need some more guidance.

Hi, thanks for quick reply.
Just to be sure, does the following code show correct use of the vector set?
FastNoiseVectorSet fnvs(1000000);
for (int i = 0; i < 1000000; i++)
{
  fnvs.xSet[i] = foo[i][0];
  fnvs.ySet[i] = foo[i][1];
  fnvs.zSet[i] = foo[i][2];
}
float *es = FastNoiseSIMD::GetEmptySet(1000000);
FastNoiseSIMD *fns = FastNoiseSIMD::NewFastNoiseSIMD();
fns->FillValueSet(es, &fnvs);
for (int i = 0; i < 1000000; i++)
  bar[i] = es[i];
FastNoiseSIMD::FreeNoiseSet(ns);
delete fns;

That looks correct, does it work?
On Mon, 16 Sep 2019, 09:01 Tomáš Malý<EMAIL_ADDRESS>wrote:

Hi, thanks for quick reply.
Just to be sure, does the following code show correct use of the vector
set?
FastNoiseVectorSet fnvs(1000000);for (int i = 0; i < 1000000; i++)
{
fnvs.xSet[i] = foo[i][0];
fnvs.ySet[i] = foo[i][1];
fnvs.zSet[i] = foo[i][2];
}float *es = FastNoiseSIMD::GetEmptySet(1000000);
FastNoiseSIMD *fns = FastNoiseSIMD::NewFastNoiseSIMD();
fns->FillValueSet(es, &fnvs);for (int i = 0; i < 1000000; i++)
bar[i] = es[i];FastNoiseSIMD::FreeNoiseSet(ns);delete fns;
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Auburns/FastNoiseSIMD/issues/41?email_source=notifications&email_token=AAKJPLDPVLWFBIVN36KDSBTQJ44NNA5CNFSM4IW33XE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6YMCDI#issuecomment-531677453,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKJPLDSHUPAXXS3VL2BCP3QJ44NNANCNFSM4IW33XEQ
.

I did not try it yet. I am already using your other library and I intend to wrap them both in common api and use the simd one where possible. I will let you know.


Broker time range pruning(#6189)

For issue #6189:
Add broker time range based pruner for routing. Query operators supported: RANGE, =, <, <=, >, >=, AND, OR
To enable this pruner, table config need to be set as:
"routing": {
    "segmentPrunerTypes": ["TimeRange"]
  }

For multiple pruners, time pruner will by default be the first one.

@jtao15 is it true that we need to store the segment name multiple times in different segments.? My understanding was just to store a bit more extra information for each node (e.g. max value, pointers).
@Jackie-Jiang If storing segment name multiple times is the concern, we can optimize by using a hash map and use unique id instead of the segment name. I actually was also thinking of starting with the naive approach; however, @kishoreg and @noahprince22 had some concerns on the O(n) performance of the naive approach.
@kishoreg How do you think on this?

Codecov Report

Merging #6259 (f1adcfa) into master (1beaab5) will decrease coverage by 20.19%.
The diff coverage is 38.97%.

@@             Coverage Diff             @@
##           master    #6259       +/-   ##
===========================================
- Coverage   66.44%   46.24%   -20.20%
===========================================
  Files        1075     1246      +171
  Lines       54773    59240     +4467
  Branches     8168     8797      +629
===========================================
- Hits        36396    27398     -8998
- Misses      15700    29586    +13886
+ Partials     2677     2256      -421

Flag
Coverage Δ

integration
46.24% <38.97%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...org/apache/pinot/broker/queryquota/HitCounter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...che/pinot/broker/queryquota/MaxHitRateTracker.java
0.00% <0.00%> (ø)

...ache/pinot/broker/queryquota/QueryQuotaEntity.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ceselector/StrictReplicaGroupInstanceSelector.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/TimeSegmentPruner.java
0.00% <0.00%> (ø)

...ker/routing/segmentpruner/intervalST/Interval.java
0.00% <0.00%> (ø)

...r/routing/segmentpruner/intervalST/IntervalST.java
0.00% <0.00%> (ø)

... and 1238 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a53fbe...f1adcfa. Read the comment docs.


[WIP] Add post CI hook

Fixes https://github.com/MatchedPattern/ex_health/issues/7

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@242591b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   94.23%
=========================================
  Files             ?        5
  Lines             ?       52
  Branches          ?        0
=========================================
  Hits              ?       49
  Misses            ?        3
  Partials          ?        0

Impacted Files
Coverage Δ

lib/ex_health/plug.ex
66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242591b...5a63758. Read the comment docs.


On deleting customer their invoice and shipment records are getting disappeared.

Bug report
Title
On deleting customer their invoice and shipment records are getting disappeared.
Preconditions
1. framework Version. Master

Steps to reproduce
1. step1: place order, create invoice and shipment and then delete that customer
2. step2:check invoice and shipment for that order

Expected result:
should not disappear
Actual result:
https://prnt.sc/tx5a8z
https://prnt.sc/tx5afr

Fixed in Master


Hide 'Uw attributen' behind pin option

I can always open IRMA and get a view on my attributes. Some attributes are very private like BSN so consider to give the user the option to hide the attributes behind the app's pin code as an extra security measure.
The next thing to consider is then what to do when the user wants to authenticate intimidate afterwards: enter pin again or has a grace period of 10 seconds.

Thank you for the suggestion. This is now implemented in the latest versions on both iOS and android.


Rollup config unify

Good question yet I do not have solid experience on webpack's .mjs supporting.
Thinking it'd be better just leave as existing index-esm.js for now and make the cut?


SSO for paginated reports and Analysis Services on premise

The article mentions that SQL Server Analysis Services on premises is supported via the Enterprise or VNet Gateway.
It doesn't mention if Single Sign On for SQL Server Analysis Services is supported or not.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 40a5444a-ce6c-9a0c-3e84-832e67b75d47
Version Independent ID: df2623ba-2917-faf6-0077-e9d182a9e96c
Content: Supported data sources for Power BI paginated reports - Power BI
Content Source: powerbi-docs/paginated-reports/paginated-reports-data-sources.md
Service: powerbi
Sub-service: report-builder
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @skliehm. This issue has been assigned to the doc author for review.


Scatter Mixed Chart not Showing in Angular 7

Hi Team,
Below is my snippet/configuration for mixed chart
//ts
public scatterChartData: ChartDataSets[] = [
{
  type: 'bar',
  label: 'Bar Dataset',
  data: [10, 20, 30, 40],
  backgroundColor: [
    'rgba(255, 99, 132, 0.2)',
    'rgba(54, 162, 235, 0.2)',
    'rgba(255, 206, 86, 0.2)',
    'rgba(75, 192, 192, 0.2)'

  ],
  borderColor: [
    'rgba(255, 99, 132, 1)',
    'rgba(54, 162, 235, 1)',
    'rgba(255, 206, 86, 1)',
    'rgba(75, 192, 192, 1)'

  ],
  order: 2
}, {
  type: 'line',
  label: 'Line Dataset',
  data: [10, 20, 30, 40],
  order: 1
}

];
options: {
scales: {
y: {
beginAtZero: true
}
}
}
public labels: string[] = ['January', 'February', 'March', 'April'];
//Html part

Using the above config i am not getting any error in chart, but  chart  interface is not loaded properly
reference image has been attached for your reference

pls guide me on this workaround at earliest

Is this being used with Chart.js v3 or v2.9.4? Also do you use any Angular libraries for adapting chart.js or you try doing it with pure chart.js.

I have utilized chart js v3 in my project, and i have not utilized any additional libraries to integrate chartjs
I am in urge of my project release ,kindly suggest me workaround asap

You've utilized the 3.x options format which is likely part of the cause. V2 docs at https://www.chartjs.org/docs/2.9.4/charts/mixed.html
The options should be
options: {
  scales: {
    yAxes: [{
      beginAtZero: true
    }],
  }
}


Checkbox from "enableRowSelection" wont change status

material-react-table version
v2.12.1
react & react-dom versions
v18.2.0
Describe the bug and the steps to reproduce it
In my react javascript application i have added a simple table where i have enabled the "enableRowSelection" has in the example.
I can see the checkbox but when i click on them this wont change their status and they will remain unselected.
I have made an easy table only to try the functionality but i am not able to make it working and i am not able to understand why is not working.
Minimal, Reproducible Example - (Optional, but Recommended)
import { useMemo } from 'react';
import {
  MaterialReactTable,
  useMaterialReactTable,
} from 'material-react-table';

//nested data is ok, see accessorKeys in ColumnDef below
const data = [
  {
    name: {
      firstName: 'John',
      lastName: 'Doe',
    },
    address: '261 Erdman Ford',
    city: 'East Daphne',
    state: 'Kentucky',
  },
  {
    name: {
      firstName: 'Jane',
      lastName: 'Doe',
    },
    address: '769 Dominic Grove',
    city: 'Columbus',
    state: 'Ohio',
  },
  {
    name: {
      firstName: 'Joe',
      lastName: 'Doe',
    },
    address: '566 Brakus Inlet',
    city: 'South Linda',
    state: 'West Virginia',
  },
  {
    name: {
      firstName: 'Kevin',
      lastName: 'Vandy',
    },
    address: '722 Emie Stream',
    city: 'Lincoln',
    state: 'Nebraska',
  },
  {
    name: {
      firstName: 'Joshua',
      lastName: 'Rolluffs',
    },
    address: '32188 Larkin Turnpike',
    city: 'Charleston',
    state: 'South Carolina',
  },
];

const Example = () => {
  //should be memoized or stable
  const columns = useMemo(
    () => [
      {
        accessorKey: 'name.firstName', //access nested data with dot notation
        header: 'First Name',
        size: 150,
      },
      {
        accessorKey: 'name.lastName',
        header: 'Last Name',
        size: 150,
      },
      {
        accessorKey: 'address', //normal accessorKey
        header: 'Address',
        size: 200,
      },
      {
        accessorKey: 'city',
        header: 'City',
        size: 150,
      },
      {
        accessorKey: 'state',
        header: 'State',
        size: 150,
      },
    ],
    [],
  );

  const table = useMaterialReactTable({
    columns,
    data, //data must be memoized or stable (useState, useMemo, defined outside of this component, etc.)
    enableRowSelection: true,
  });

  return <MaterialReactTable table={table} />;
};

export default Example;

Screenshots or Videos (Optional)
https://github.com/KevinVandy/material-react-table/assets/166718290/acb94ad2-3bb2-41ec-bc3d-f8ce862604e4
Do you intend to try to help solve this bug with your own PR?
No, because I do not know how
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

you must have something else going on in your code besides what you pasted here. Or are you using an old unsupported version of React with MUI v5?


How to obtain T+?

Hi!
Thanks for releasing the codes!
Sorry to bother in this busy CVPR week, but here's one minor question:
It's said in Sec. 3.2 that two sets of textual inputs, T and T+, are to be fed to h(.) and h_hat(.), respectively. Could you point me anywhere that how to obtain T+ exactly?
Thanks!

Oops sorry, I guess they're meant to be the same just notated distinguishably.


Ambiguous use of decode (v. 2.1.0)

Hello.
After an upgrade from JSONWebToken 2.0.1 to 2.1.0
I get the following error:
Ambiguous use of 'decode(_:algorithm:verify:audience:issuer:)'
My code
let payload = try JWT.decode(cryptedResponse, algorithm: .hs256((api.key).data(using: .utf8)!))
And when I click on "decode", XCode leads me to this
typedef struct vImage_CGImageFormat {     uint32_t                bitsPerComponent;     uint32_t                bitsPerPixel;            CGColorSpaceRef         colorSpace;              CGBitmapInfo            bitmapInfo;              uint32_t                version;                 const CGFloat *         decode;     CGColorRenderingIntent  renderingIntent; }vImage_CGImageFormat;
Which has nothing to do with JWT, but with the Accelerate framework (that I don't use...).
I've tried to clean the project, removed the derived data, and even upgraded my XCode from 8.1 to 8.2, but still ...
I finally downgraded your lib from 2.1.0 to 2.0.2, and the error is gone.
Hope this report can help.
Thanks.

The issue is that there are now duplicate method signatures for the two decode functions.  They return different types.  To disambiguate you need to use the type for the variable or constant name.
let claims : ClaimSet =
instead of:
let claims =


Integrate redux with Navigator

Hi,
First, cheers for your great work.
I might no be good using redux well, but I cannot make it work with React Native Router Flux.
I simply connect redux to the router like this :
var { bindActionCreators } = require('redux');
var { connect } = require('react-redux/native');
var Router = require('./Router');
var CounterActions = require('./actions/counter');

function mapStateToProps(state) {
  return {
    counter: state.counter
  };
}

function mapDispatchToProps(dispatch) {
  return bindActionCreators(CounterActions, dispatch);
}

module.exports = connect(mapStateToProps, mapDispatchToProps)(Router);

And my Router look like this :
'use strict';

var React = require('react-native');
var {Router, Route, Actions, Animations, Schema} = require('react-native-router-flux');

var Counter = require('./components/Counter');

var RouterModule = React.createClass({
    render: function() {
        console.log('FROM ROUTER  : ',this.props.counter);
        return (
            <Router>
              <Schema name="default" sceneConfig={Animations.FlatFloatFromRight} />
              <Route name="launch" {...this.props} component={Counter} initial={true} hideNavBar={false} title="Launch"/>
            </Router>
        );
    }
});

module.exports = RouterModule;

When I click on the "+", my Router Component updates well and receive the good count value, but the  value is not updated in Counter Component.
Please let me know if you need anything.

After more thoughts,
It might be an issue regarding React Native Router Flux ?

Closing.


Honour system

I think an interesting solution to players making accidents in picks/bans is an "honour system" where the opponent is prompted to approve a change.
This system could also be applied to when a player misses a timer, or a match needs to be paused and other non-standard scenarios.

I like this idea, the only issue I'd have with it is that I really don't want this to turn into an issue of remembering all the commands to make this happen. Currently, all usable commands are !skip, !choose, !pick, !ban, !score, !list, and !bans, which are pretty intuitive.
This might become a hidden feature that only a few know about

I'll wait until after Closed beta to come back to this, because I suspect you're not the only one with this concern

I actually just thought of a solution to this:
The !pick command currently only accepts one map, and is then shut down from switching phases. Instead what we could do, is allow the command to be used for 5-10 seconds after the phase is switched, so if they input the wrong command, and type the right map quickly, it will switch back. As long as people are aware that this feature exists it should be fine


global_step/sec

hi,
when i train this model,i get a problem.that is the global_step/sec is always zero.can you tell me the reason?

Hi @zhangzhizz ,
I have the same problem as you had and I was wondering if you solved it. And if so, how?

@AlexaGh @zhangzhizz were you able to figure out the prob??

I have the same problem as you had

@AlexaGh @xk503775229 @v3nm I am sorry, I didnt process it.


[TRACE-X] QG 4 checks (Release 24.08)

name: Quality Gate Checklist
about: 'product check for a upcoming Release'
title: 'QG X checks (Release 24.8)'
labels: documentation
assignees: @mkanal

QG checks
Please open and fill in this issue in your product repository to document the compliance with our Tractus-X Release Guideline (TRGs)
Show compliance with TRGs by referencing to a tagged link in the respective repository where possible, example: TRG 1.01 (see github.com/eclipse-tractusx/example-repo/tree/1.0.0/README.md)
Close this issue once the compliance with the TRGs has been documented
Committer(s): https://github.com/eclipse-tractusx/traceability-foss/blob/main/AUTHORS.md
Helm Chart Version: https://github.com/eclipse-tractusx/traceability-foss/releases/tag/helm-charts-1.3.42
App Version: https://github.com/eclipse-tractusx/traceability-foss/releases/tag/13.0.0
Release Management Reference Issue:
Check of Tractus-X Release Guidelines

Currently implemented automatic checks can be found under your product on our Release Guidelines Checks Board
This QG Check is depending on the mandatory information from our current Release Guidelines

TRG 1 Documentation

[x] TRG 1.01 appropriate README.md
[ ] TRG 1.02 appropriate install instructions either INSTALL.md or in README.md
[x] TRG 1.03 appropriate CHANGELOG.md
[x] TRG 1.04 editable static files

TRG 2 Git

[x] TRG 2.01 default branch is named main
[x] TRG 2.03 repository structure
[x] TRG 2.04 leading product repository
[x] TRG 2.05 .tractusx metafile in a proper format
[x] TRG 2.06 Dependabot

TRG 3 Kubernetes

[ ] TRG 3.02 persistent volume and persistent volume claim or database dependency (subchart) are in place when needed

TRG 4 Container

[x] TRG 4.01 semantic versioning and tagging
[ ] TRG 4.02 base image is agreed
[ ] TRG 4.03 image has USER command and Non Root Container
[ ] TRG 4.05 released image must be placed in DockerHub, remove GHCR references
[x] TRG 4.06 separate notice file for DockerHub has all necessary information
[ ] [TRG 4.07] (https://eclipse-tractusx.github.io/docs/release/trg-4/trg-4-07) root file system is set to read access by default, but can be overwritten by the user

TRG 5 Helm

[ ] TRG 5.01 Helm chart requirements
[ ] TRG 5.02 Helm chart location in /charts directory and correct structure
[ ] TRG 5.03 proper version strategy
[ ] TRG 5.04 CPU / MEM resource requests and limits and are properly set
[ ] TRG 5.06 Application must be configurable through the Helm chart
[ ] TRG 5.07 Dependencies are present and properly configured in the Chart.yaml
[ ] TRG 5.08 Product has a single deployable helm chart that contains all components
[ ] TRG 5.09 Helm Test running properly
[ ] TRG 5.10 Products need to support 3 versions at a time
[ ] TRG 5.11 Upgradeability

TRG 6 Released Helm Chart

[ ] TRG 6.01 Released Helm Chart

TRG 7 Open Source Governance

[x] TRG 7.01 Legal Documentation
[x] TRG 7.02 License and copyright header
[x] TRG 7.03 IP checks for project content
[x] TRG 7.04 IP checks for 3rd party content
[x] TRG 7.05 Legal information for distributions
[x] TRG 7.06 Legal information for end user content
[x] TRG 7.07 Legal notice for documentation
[x] TRG 7.08 Legal notice for KIT documentation

TRG 8 Security

[x] TRG 8.01 Mitigate high and above findings in CodeQL
[x] TRG 8.02 Mitigate high and above findings in KICS
[ ] TRG 8.04 Mitigate high and above findings in Trivy
[x] TRG 8.03 No secret findings by GitGuardian or TruffleHog

Hints
Information Sharing

Hi @ds-jhartmann  would you please proceed the TRG checks for Trace-X. Thank you very much.

appropriate CHANGELOG.md

[x] latest released version should be on top
[x] each released version should have a separate block entry and each version should be linked to the corresponding tag
[x] use the "unreleased section" to track updates to features or functions of upcoming releases
[x] same kinds of changes should be grouped (e.g. changed, fixed, removed, etc.) and each change should be linked to the corresponding issue or pull request

TRG 1.04 editable static files

https://github.com/eclipse-tractusx/traceability-foss/pull/1250
https://github.com/eclipse-tractusx/traceability-foss/pull/1249

TRG 2.03 repository structure

[x] /docs
[x] /charts
[x] CODE_OF_CONDUCT.md
[x] CONTRIBUTING.md
[x] DEPENDENCIES
[x] LICENSE
[x] NOTICE.md
[ ] README.md
[ ] SECURITY.md
[ ] AUTHORS.md
[ ] INSTALL.md

https://github.com/eclipse-tractusx/traceability-foss/blob/main/.tractusx LGFM

TRG 1.02 appropriate install instructions either INSTALL.md or in README.md

@ds-jhartmann  description is required to have a proper and working install instruction this will be resolved with https://github.com/eclipse-tractusx/traceability-foss/issues/511

TRG 2.06 Dependabot

Checked https://github.com/eclipse-tractusx/traceability-foss/blob/main/.github/dependabot.yml

TRG 4.01 semantic versioning and tagging

[x] https://github.com/eclipse-tractusx/traceability-foss/releases/tag/13.0.0

TRG 7.01 Legal Documentation

[x] LICENSE
[x] LICENSE_non-code
[x] NOTICE.md
[x] DEPENDENCIES
[x] SECURITY.md
[x] CONTRIBUTING.md
[x] CODE_OF_CONDUCT.md
[x] Apache-2.0 for code
[x] CC-BY-4.0 for non-code

TRG 7.05 Legal information for distributions

[x] LICENSE
[x] NOTICE.md
[x] DEPENDENCIES file(s)
[x]  SECURITY

TRG 7.06 Legal information for end user content

[x] Copyright statements https://github.com/eclipse-tractusx/traceability-foss/blob/49bbbed1da45a4f46b85602ad333c19c8a0e78aa/NOTICE.md
[x] License https://github.com/eclipse-tractusx/traceability-foss/blob/49bbbed1da45a4f46b85602ad333c19c8a0e78aa/NOTICE.md
[x] Trademarks owned by the Eclipse Foundation on behalf of the project >>  NOTICE.md
[x] The source code repositories
[x] Used 3rd party libraries
[x] When applicable a cryptography notice https://github.com/eclipse-tractusx/traceability-foss/blob/49bbbed1da45a4f46b85602ad333c19c8a0e78aa/NOTICE.md

deploy: 49bbbed1da45a4f46b85602ad333c19c8a0e78aa

@ds-lcapellino
KICS is outdated:

KICS no findings

PO acceptance in behalf of @jzbmw


Very obscure issue...

I love the theme overall, I've already managed to make a few tweaks here and there, and am in the middle of writing content, but I have a weird issue with a published page, and I'm sure it has something to do with use of html and the page.hbs, but I'm just not quite knowledgeable enough with handlebars to even know what I'm looking at. I've made no changes to page.hbs in my theme, and only added the Facebook comment code into post.hbs.
When I go to a page (not a post, but haven't tried publishing one with embedded html tables) I've created (https://nextgenwar.info/acronyms) it displays everything in the actual table down below with all the proper styling and css I've manually styled in the code injection section (and I've tried removing it, and it makes zero change to my problem), and basically, I have all the "unformatted html" contents of my html table showing up again up above, over my top image, and then disappearing behind the content.
I've tried both Chrome and Edge and get the same problem with both. IE doesn't display the table itself correctly, but IE is pretty deprecated, so I'm not terribly worried.
How do I get the data from the table to not display twice, specifically the unformatted one that appears up above over the background image?

Two other things...

This isn't a problem for a post. Only a page.

The page title ONLY shows up on the top, over the image, and not in the post above the correctly formatted table below. Though I think that's by design and the way I'd want it if the unformatted table data wasn't showing up too.

Weird.


Use HList instead of List[Any] for prepared statements

Currently, queries accept a List[Any] for parameters in their prepared statements. I think it would be a huge improvement to use an HList or something similar, to retain type safety at the time that those are filled in.

@Jacoby6000 Are you using IntelliJ? It infers the wrong types in 0.1.0. Could you test if the 0.1.3 version solves your problem?

I'm closing this issue, please feel free to reopen it.


Working with Visual Studio

In some cases you might see the files not loaded for the project even if you install the Power Query SDK. Try installing Visual Studio 2019 Community Edition and add Web Development and Desktop Development features.

Issue Closed


send_resolved should not be configured in receiver config.

In my opinion, alertmanager can be a single component running. Now prometheus mainly do the monitoring things and alerts about the metrics . it is obviously that alermanager do the good job.
In some case about logging monitor, when some errors occur, and then passed to the alertmanager and alert, but this logging error isn't a constant event, not like metrics monitor , if we configure a receiver with "send_resolved :true" and, after the timeout it will send a resolved alert. if we don't configure it ,other metric alerts can't send resloved alert.
so i think the send_resolve should be configured in route block , the same as group_by,gour_interval. what do you think?

Whether sending resolved makes sense depends on the notifier. For example it is spammy for email/slack, but not so for Pagerduty. This it needs to be configured per notifier.


Fix format.ProcessJSONs flatten directive

without this format.ProcessJSON would fail to flatten keys containing json objects, because json objects must be cast to map[string]interface{} instead of map[interface{}]interface{}

:+1: /merged


Multitenancy: Supplier can register Customer for different tenant

[Version]
16.1 fix7+ 2017/03/30
[How to reproduce]

Configure default tenant (D) and one additional tenant (A)
Create Marketplace Owner and Marketplace in D
Create Marketplace Owner and Marketplace in A
Register new customer as Marketplace Owner in D for Marketplace in A

[Expected result]
Not possible / Exception because of different tenant
[Observed result]
New user is registered
[Comment]
There has to be a check added for UI und SOAP if the tenant of the customer, supplier and the marketplace are identical.

Given scenario needs to be covered by SOAP API tests.

What about marketplaces which are not assigned to any marketplace? Should they be seen in the drop down list, in this case, or not?


How to improve the accuracy of  plam detection

in hand-tracking demo ,
When there is no hand in the field of vision, there are landmarks  constantly. How to improve the accuracy of  plam detection ?

We always output landmarks. So in the case when there's false positive from the detector, the landmark model will run once and drop the tracking by the hand flag. In the next frame, it'll re-trigger the detection. So the correct way is to filter out non-hand is to use the hand flag score, if the score give low values, then the hand landmark should be dropped and could not be trusted.


Other command for SMTP nio library

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Major release (change is NOT backward compatible with prior release)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@OnePunMan
Hi Jackie, here are your other commands. Feel free to contribute if you are interested.

Thanks @fansu, I'll start looking into them

@fansu is this PR going to be merged?

Is a refresher of this PR worth my time?

Is a refresher of this PR worth my time?

Thanks for your attention and feel free to contribute.

Closed. PR 42 merged with duplicate changes.


Marcom 98

Capabilities list now shows up in a modal.
Lots of little fixes and code cleanup.
Broke the single index.html file into modular angular directives.

:octocat:


Cannot connect to mysql in docker

Not sure if I'm on the right track with this issue.
I've setted up my db in a docker container.
That's what the config looks like
version: '2'

services:
  db:
    image: mysql:5.7
    environment:
      MYSQL_ROOT_PASSWORD: 1234
      MYSQL_DATABASE: foobar
      MYSQL_USER: root
      MYSQL_PASSWORD: 1234
    ports:
    - "3306:3306"

I'm not trying to establish a connection
   fn get_opts() -> Opts {
        let user = "root";
        let addr = "<IP_ADDRESS>";
        let pwd: String = String::from("1234");
        let port: u16 = 3306;
        let mut builder = OptsBuilder::default();
        builder.user(Some(user))
                .pass(Some(pwd))
                .ip_or_hostname(Some(addr))
                .tcp_port(port);
        builder.into()
    }

    fn get_connection() {
      let opts = self.get_opts();
      let pool = Pool::new_manual(1, 1, opts).unwrap();
    }

Now I'm getting:
error: Could not connect to address `/var/run/mysqld/mysqld.sock': No such file or directory (os error 2)
I debug it and in conn/mod.rs I saw fn can_improved() which improves the connection by choosing socket over tcp if possible.
I have limited knowledge in this field - so I'm not sure if this is an issue with this lib or my setup.

use
        builder.user(Some(user))
                .pass(Some(pwd))
                .ip_or_hostname(Some(addr))
                .tcp_port(port)
                .prefer_socket(false)

-.- yep saw it just a second ago. thank you :) 👍


refactor(sink): refactor es and opensearch to support async

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
refactor es and opensearch with https://docs.rs/opensearch/latest/opensearch/ and https://docs.rs/elasticsearch/latest/elasticsearch/
they support async, and their sink_debuple defaults to true
https://github.com/risingwavelabs/risingwave/issues/17073
The new sink is exactly the same as the original creation parameters. For now, we keep two copies of the code (elasticsearch and elasticsearch_rust), after which we can delete the old one.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Do we have any test or CI to validate whether the current implementation works?

Yes, since we've changed our name to elasticsearch, the original tests can be used on the new implementation


My git submodule widget UI breaks on release mode but not the debug one

Steps to reproduce
I just tried every possible fixes out there like:

flutter clean && flutter pub get in the git submodule directory
git submodule update --recursive --remote in the main repo
Also flutter clean && flutter pub get here
And flutter build apk --release

Also ensure dependency versions between my main repo and git submodule align.
Expected results
The released app should have the same consistent UI as the debugged one.
Actual results
The app data fetching, navigation are both fines but not the UI from the git submodule. There are other notices that: Sometimes it works as expected including the first time downloaded or after some manual app data clearing attempts.
Code sample
I think there's nothing related to application code.
Screenshots or Video

Screenshots / Video demonstration
Uploading 435623534_26015744731357851_5524658442515799120_n.mp4…

Logs
The log contains no error or isssue.
Flutter Doctor output
Doctor output

[√] Flutter (Channel stable, 3.19.5, on Microsoft
    Windows [Version 10.0.22631.3447], locale
    en-US)
    • Flutter version 3.19.5 on channel stable at
      C:\Users\Admin\AppData\Local\flutter
    • Upstream repository
      https://github.com/flutter/flutter.git
    • Framework revision 300451adae (2 weeks ago),
      2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[√] Windows Version (Installed version of Windows
    is version 10 or higher)

Checking Android licenses is taking an unexpectedly                                                   [√] Android toolchain - develop for Android devices
    (Android SDK version 34.0.0-rc4)
    • Android SDK at
      C:\Users\Admin\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0-rc4
    • Java binary at: C:\Program
      Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment
      (build 17.0.9+0--11185874)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files
      (x86)\Google\Chrome\Application\chrome.exe

[!] Visual Studio - develop Windows apps (Visual
    Studio Community 2022 17.8.5)
    • Visual Studio at C:\Program Files\Microsoft
      Visual Studio\2022\Community
    • Visual Studio Community 2022 version
      17.8.34511.84
    X Visual Studio is missing necessary
      components. Please re-run the Visual Studio
      installer for the "Desktop development with
      C++" workload, and include these components:
        MSVC v142 - VS 2019 C++ x64/x86 build tools
         - If there are multiple build tool
         versions available, install the latest
        C++ CMake tools for Windows
        Windows 10 SDK

[√] Android Studio (version 2023.2)
    • Android Studio at C:\Program
      Files\Android\Android Studio
    • Flutter plugin can be installed from:

      https://plugins.jetbrains.com/plugin/9212-flu
      tter
    • Dart plugin can be installed from:

      https://plugins.jetbrains.com/plugin/6351-dar
      t
    • Java version OpenJDK Runtime Environment
      (build 17.0.9+0--11185874)

[√] VS Code, 64-bit edition (version 1.88.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.86.0

[√] Connected device (4 available)
    • 22041216G (mobile) • NRXSOVMZOFPBO7JZ •
      android-arm64  • Android 13 (API 33)
    • Windows (desktop)  • windows          •
      windows-x64    • Microsoft Windows [Version
      10.0.22631.3447]
    • Chrome (web)       • chrome           •
      web-javascript • Google Chrome 123.0.6312.122
    • Edge (web)         • edge             •
      web-javascript • Microsoft Edge 123.0.2420.81

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Here is my reproduction demo on physical device:
https://github.com/flutter/flutter/assets/132418932/7396e679-ffc2-4406-ad73-9f02a732f190

Without the code no one can help you

Oh I see, I will get back soon.


Create ServeCommand.php

php katana serve command will serve local site with php built-in server with option to configurable port as -p "port" | --port "port"

please register this command as a find this very helpful

@vivekdhumal you can open this PR to katanaphp/katana-core?


feat(auction2): Add promoted sale rail

This adds the promoted sale "Buy Now" rail to the page:

cc @artsy/grow-devs

Ah @dzucconi's internet is down, assigning to myself but can follow up feedback-wise.


How to get all recipe data using scrapper from specific website?

Hi,
We are having a query to use the scrapper library for getting the data of all recipes using it. The current demo of the library only allowed to put a single URL and gives the scraped data.
But if we want to sync all the recipes from the following website. How it can be achieved?
1.https://www.yummly.com/
2. https://www.woolworths.com.au/
3. https://www.thespruceeats.com/
4. https://www.myrecipes.com/
5. https://www.seriouseats.com/
6. https://www.food.com/
7. https://www.foodnetwork.com/
8. https://www.finecooking.com/
Thanks & Regards.

You'd like to scrape the entirety of a website? If that's the case you'd need to figure out how the domain paths of each website are structured and see if there is some iterable way to run through all the ones containing recipes (or some brute force strategy).
The way this library works is by making an HTTP request to a URL and then combing through the HTML that it responds with. Because of this, you'd need to do the requests individually. You could certainly create a wrapper function with this library that takes multiple urls and iterates through them though.


Modify parameter set modal to better support different parameter sets

See here. Parameter sets are currently hardcoded by ID. We need a more general mechanism.

Can this be closed? I think this was addressed in https://github.com/biocore/qiita/pull/863, right? If not please describe what's missing.


Create Simplified Chinese

Thank you for this, it will be included in the next release.

Thank you for this, it will be included in the next release.

我译完了跑过来才发现已经有人提交了（悲）


Update request module as it has been deprecated.

warning alasql ><EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142

Thanks for letting me know. Fix released as part of v2.1.7


Brush in Series-Pie

Version
4.6.0
Reproduction link
http://output.jsbin.com/tihahereco
Steps to reproduce
Just click on button 'Click Me'
What is expected?
That the 'brushselected' event triggered contains the information of the selected dataIndex.
What is actually happening?
The information of the parameters of the triggered 'brushselected' event does not contain the information of the selected dataIndex.

The behavior should be similar to what happens with the brush in Series-Bar charts.

Pie charts don't support brush operation. See https://echarts.apache.org/en/option.html#brush .
What's the user scenario for this?

Discover the piece of pie selected by the brush. I know that there are the 'pieselectchanged', 'pieselected' and 'pieunselected' events for this, but I would like to keep the selection uniform through the brush.

Pie select is not the same with brushing.

What do you expect from pie brushing? Selecting the whole pie or pieces? @unknow

What do you expect from pie brushing? Selecting the whole pie or pieces? @unknow

Pieces, Something like that:
Before Brushing:

After Brusing:

Event Params:

@unknow OK. I'm afraid I have to mark this as a low priority request.
If you are interested in making a pull request, please refer to https://github.com/apache/incubator-echarts/wiki/How-to-setup-the-dev-environment


Versioning

I think versioning is necessary. http://semver.org

Yep, we already discussing about this in #63, please check for dublicates before posting issue.


Design | UX

Design is lacking. Not great responsively. Needs redesign

I have slightly edited the top menu bar. I'm not completely sure you will like it, but have a look and see what you think. (I created a pull request)


Gitlab modules not showing up on the website

Modules hosted on Gitlab show this error in update.log:
[error] Received fatal error while building https://gitlab.com/.../raw/master/META6.json: Use of uninitialized value $code in numeric eq (==) at lib/ModulesPerl6/DbBuilder/Dist/PostProcessor/p30METAChecker.pm line 106.

p30METAChecker.pm:106

I made the code handle undefs but I suspect the real problem is $dist->{url} not being properly set for gitlab dists.


SRI Digest Hash Algorithm sha256 Doesn't Meet Recommended Baseline of sha384

[x] I tried updating to the latest version

[ ] I can't, there is an issue
[ ] This is about an < latest

[ ] I understand older versions may be unsupported

[ ] I Am on Windows

[ ] Ubuntu Bash on Windows
[ ] Fedora Bash on Windows
[ ] Other  Bash on Windows

[ ] I Am on Linux

[ ] Ubuntu
[ ] Fedora
[ ] CentOS
[ ] Redhat
[ ] Debian

[ ] I am on macOS 10.13
[x] I am on macOS 10.14
[ ] I'm on Docker

[ ] I understand Docker may be unsupported

Description
When subresource integrity is enabled, Jekyll-Assets uses sha256 to calculate the digest. However, this algorithm doesn't meet the baseline recommendations from the Subresource Integrity specification.
Jekyll-Assets should instead use sha384 by default, and optionally allow for this to be configured (as discussed in #535).
Steps

Enable subresource integrity in a Jekyll project that uses Jekyll-Assets
Use the {% asset %} tag to include a script or stylesheet.

Output
<link rel="stylesheet" type="text/css" href="screen.css" integrity="sha256-_______" crossorigin="anonymous">

Expected
<link rel="stylesheet" type="text/css" href="screen.css" integrity="sha384-_______" crossorigin="anonymous">

Possibly related to #270 ?
Don't quote me on this, but as far as I know SHA256 is not currently considered unsafe (as of 2019) and the convention to use SHA384 is largely due to an old bug in Firefox that resulted in SHA256/SHA512 SRI hashes being incorrectly validated. SHA224/SHA384 was being validated correctly despite this bug, hence the convention to use it over SHA256.
I may have some of those details wrong, so apologies if that's not the exact story. It's based on some very fuzzy memories of how it all happened. Still would be great to see it changed to SHA384 and align it with W3C recommendations however I don't think it's an issue based on security concerns.


Fixing to work, little refactoring

Make it work with UNMS 1.2.7.

Now we can ask for clients for some devices.


fix: [NEEDS MORE TESTING] operator does not reconcile on Argo CD server route path(#468)

What type of PR is this?

/kind bug

What does this PR do / why we need it:
Fixes #468
Have you updated the necessary documentation?
In place.
Which issue(s) this PR fixes:
Fixes #468
How to test changes / Special notes to the reviewer:
NA

It seems to be missing a modification of deployment.go getArgoServer() from
https://github.com/argoproj-labs/argocd-operator/blob/18afda802312a424d96079f881a8e7e9f9fd09f3/controllers/argocd/deployment.go#L207-L238
the code above should check for the route path and append the command if set
with something like
cmd = append(cmd, "--rootpath")
cmd = append(cmd, getRoutePath(...)) // defaults to '/'

Thanks 🙏  .. Will update the PR accordingly.

This PR seems to be obsolete.

This PR was to implement the --root-path parameter as it is defined in the operator interface, but just not implemented.
See #468
@wtam2018 why would this be obsolete?
Maybe it was implemented somewhere else since ?

Instead of adding a "one-off" fix for --rootpath, we probalby should come up with a general solution to allow users to pass start command arguments to repo server.

Instead of adding a "one-off" fix for --rootpath, we probalby should come up with a general solution to allow users to pass start command arguments to repo server.

makes sense. probably in a configmap or somewhere. Also these entries should be merged with the ones created already by the operator.

Instead of adding a "one-off" fix for --rootpath, we probalby should come up with a general solution to allow users to pass start command arguments to repo server.

makes sense. probably in a configmap or somewhere. Also these entries should be merged with the ones created already by the operator.

After giving it a thought I feel Argo CD CRD is the best place for this.


Fix broken portal links

Also add some mobile padding

📝 Changed routes:

/

(view full size)

Commit f98df9474f7f54be4271c0d065f8422295592583 (https://thirdweb-ognc7gaal-thirdweb.vercel.app).


Categories sorted for palette colors

I think this should solve #218 , assuming what one assigns colors to label sorted in alphabetical order.

Sorry for the PR, was not prop tested.


Proper support for type use annotation locations + develop a deprecation path for incorrect locations

For context, see #706 and particularly this summary by @msridhar (slightly edited from here):

Let me try to summarize the overall situation here so we can think about potential solutions and their tradeoffs.  #702 addressed an issue where writing List<@Nullable String> list made list itself @Nullable, due to the type use annotation on the type argument (identified in https://github.com/uber/NullAway/issues/674#issuecomment-1363205545).  The change there was to only consider a type-use @Nullable annotation to be relevant a field / parameter / return type if the annotation was not in an array, inner type, wildcard, or type argument position.
Unfortunately, this change was bad for a couple of reasons:

As shown in #705, sometimes type use annotations are in an inner type position even when it doesn't syntactically look like it (see example in https://github.com/uber/NullAway/issues/705#issuecomment-1368082909).
Syntactically, the "correct" location for a type use annotation is not what NullAway users (who mostly use declaration annotations) are used to.  Relevant discussion is in the JSpecify user guide.  The change in #702 unintentionally broke cases where users used a type use annotation (like the Checker Framework or JSpecify @Nullable) and wrote @Nullable Object[] foo2 = null;, as it changed NullAway to only look for the annotations in the syntactically-correct place (Object @Nullable [] foo2).

For inner types, we have a fix, with caveats, in #706.  It fixes point 1 above and gets rid of the surprising change in checking behavior for inner types from point 2.  It does lead to a bit of weirdness, as shown in here:
https://github.com/uber/NullAway/blob/1b1a5b1008612606a36062a99e7f5e21eb704680/nullaway/src/test/java/com/uber/nullaway/NullAwayCoreTests.java#L1113-L1117
In particular, writing A.@Nullable B.C foo2 makes foo2 @Nullable.  But this seems like a corner case that shouldn't affect users much right now.
Dealing with arrays is a bit more complicated, since users may want to write annotations to express the nullability of array contents.  If we adopt a solution like the one used in this PR for inner types, writing either @Nullable Object[] foo or Object @Nullable[] foo would make foo @Nullable.  But, this would mean that if foo were intended to be a @NonNull reference to an array containing @Nullable Objects, a user could not write the correct annotation for this case (@Nullable Object[] foo) without adverse impacts from NullAway (since foo itself would then be treated as @Nullable).  Such NullAway users would be forced to either not write the correct annotations for the nullability of array contents for now or to deal with references becoming unintentionally @Nullable (the latter seems worse).  A similar issue is seen in #674 for varargs arrays.  While this downside is unfortunate, it does match the behavior of NullAway before #702 landed.
We could also just stick with requiring users to write type use nullability annotations for arrays in the right spot.  But that kind of breaking change seems weird to introduce by accident, and I'm not sure of other unintended consequences.  That seems like a change we should introduce deliberately and possibly behind a flag at first to let users adopt gradually.
So, I think our best option is to handle inner type and array type use annotations in the same way for now, as inner types are currently being handled in this PR.  I'm not sure about a combination of these, e.g., A.B.@Nullable C [][] foo = null;.  This annotation does not make foo @Nullable under proper usage of type use annotations nor in a backward compatibility scenario.  So I guess we can just treat foo as @NonNull for this case?

The stop gap fix for the issues above implemented in #706 does the following:

Interpret an annotation on any inner or outer type of the field/argument declaration as annotating the field/argument itself (equivalently: as an annotation on the innermost inner type in proper type use annotation semantics)
Interpret an annotation on any sequence of array locations (including @Nullable Foo [][], Foo @Nullable [][], and Foo [] @Nullable []) as marking the array itself as being nullable.
We don't support type use annotations on generics or wildcards
We don't support type use annotations in locations that involve both inner classes and arrays (so, for A.B.C [] foo the only two valid places for the annotation are @Nullable A.B.C [] foo and A.B.C @Nullable [] foo)

Still, this means we fail to correctly follow standard semantics for type use annotations, which will only get more confusing once we want to introduce JSpecify-like support for annotating the nullability of array elements.
We should, relatively soon, introduce a breaking change intentionally that prevents adding @Nullable in the wrong position for arrays and inner types. To do this, we probably need to refactor some of our location parsing logic in NullabilityUtil to provide more information about what is being annotated/queried. We also want a reasonable UX for developers upgrading past this breaking change and/or switching between declaration and type use annotations at any point after the change (i.e. If possible, we should avoid a situation where changing the imports for @Nullable to a different annotation silently causes nullability to switch from applying to the array reference itself to applying to the elements! Though I am not whether we can do something here...)
At any rate, the version introducing this breaking change should bump the "minor" release number, not the "patch" number (not that NullAway follows semver, per se)

(When you do revisit this, you might find cushon's recent https://github.com/google/error-prone/commit/5123cd56ba7fdf8be7b81c0812af19c0256856d4 to be helpful in handling annotations on inner types.)

Related: #1007 #674 #853
My rough plan here is as follows.  In an upcoming NullAway release, if you are using type-use annotations like JSpecify's, by default NullAway will only recognize them in the correct locations, even outside JSpecify mode.  This is because with the release of JSpecify 1.0 we want to encourage correct placement of these annotations.  There will be a flag LegacyAnnotationLocations (or something like that) to get NullAway's previous behavior, but we will remove that flag eventually.
For declaration annotations outside of JSpecify mode, we will try our best to preserve NullAway's extant behavior.  Inside JSpecify mode we can do the same, but maybe also warn about their use?  Not sure.
If a single annotation is both declaration and type-use, we'll treat it as declaration.  JSpecify and Checker Framework @Nullable annotations are just type-use.
I'm not yet sure about multiple annotations on a single element, possibly mixing declaration and type use, that possibly contradict each other.  I think mixing contradictory JSpecify annotations is against the JSpecify spec and we can warn on that in JSpecify mode.  Seems like maybe we should try to detect and warn on all these cases and see what happens, since it's almost surely some kind of mistake.  But, maybe not the highest priority.


new: hashid

--> Introduce hashID which is basically the xxhash64 of contextID passed.
--> This will remove the constraint on having a fixed length contextID.
--> Nflog does a lookup on aclcache when it receives a flow and gets the pu context by the hash which is in the nflog-prefix, yes, this is removed contextID:policyID:serviceID.
--> The new rule will look like
    0     0 NFLOG      tcp  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            match-set TRI-v4-ext-4yr0x3e4dA4fB src state NEW ! match-set TRI-v4-TargetTCP src multiport dports 1:65535 state NEW nflog-prefix<PHONE_NUMBER>8543694078 nflog-group 11

--> There is an ongoing issue related to this where the pod contextID is longer and the nflog-prefix exceeds the 64 characters length and we fail reporting flows.

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "hash",
    "component": "trireme-lib",
    "pr-id": "838",
    "commit-sha": "271aa066f0491055f5f5de26f0e8b00b4d183177"
  },
  {
    "project": "hash",
    "component": "enforcerd",
    "pr-id": "1302",
    "commit-sha": "2d2c19be0fe2b13b84b2ba5bd94c1da960bb0d0a"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "hash",
    "component": "trireme-lib",
    "pr-id": "838",
    "commit-sha": "6800285f8071d74444b65f37e7e843a612b562ea"
  },
  {
    "project": "hash",
    "component": "enforcerd",
    "pr-id": "1302",
    "commit-sha": "2d2c19be0fe2b13b84b2ba5bd94c1da960bb0d0a"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "hash",
    "component": "trireme-lib",
    "pr-id": "838",
    "commit-sha": "5d66d821ec5dc2e66c95aacb1e801384f071baa8"
  },
  {
    "project": "hash",
    "component": "enforcerd",
    "pr-id": "1302",
    "commit-sha": "2d2c19be0fe2b13b84b2ba5bd94c1da960bb0d0a"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "hash",
    "component": "trireme-lib",
    "pr-id": "838",
    "commit-sha": "8c1b8757c0e7ec8b505f52955362a9c10925c70e"
  },
  {
    "project": "hash",
    "component": "enforcerd",
    "pr-id": "1302",
    "commit-sha": "2d2c19be0fe2b13b84b2ba5bd94c1da960bb0d0a"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "hash",
    "component": "trireme-lib",
    "pr-id": "838",
    "commit-sha": "5e9d4d2a1201762fccaeb0dbf10c87282ba32024"
  },
  {
    "project": "hash",
    "component": "enforcerd",
    "pr-id": "1302",
    "commit-sha": "2d2c19be0fe2b13b84b2ba5bd94c1da960bb0d0a"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "hash",
    "component": "enforcerd",
    "pr-id": "1302",
    "commit-sha": "2d2c19be0fe2b13b84b2ba5bd94c1da960bb0d0a"
  },
  {
    "project": "hash",
    "component": "trireme-lib",
    "pr-id": "838",
    "commit-sha": "940a906c8d3ef8026d197acff998aabaa798575f"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "hash",
    "component": "trireme-lib",
    "pr-id": "838",
    "commit-sha": "94f1e2a1b358accc9909928885a72a575e62d3ca"
  },
  {
    "project": "hash",
    "component": "enforcerd",
    "pr-id": "1302",
    "commit-sha": "2d2c19be0fe2b13b84b2ba5bd94c1da960bb0d0a"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "hash",
    "component": "trireme-lib",
    "pr-id": "838",
    "commit-sha": "a5de9cfd64af3a7760a69aef4a435a90b98b8af3"
  },
  {
    "project": "hash",
    "component": "enforcerd",
    "pr-id": "1302",
    "commit-sha": "e524f8a67b3e8fdb6cfc7172190a4072cf6c3d41"
  }
]

All relevant FTs have passed (enforcerd-monitoring-tests test suite). Merging this now so we can get this into 3.11 - otherwise reporting there is going to be bugged.


No license

As it is right now, this project is UNLICENSED, you should put a license notice.
http://choosealicense.com/

Done. Thanks!


@abstract

What about @abtract decorator?
function abstract (target, name, descriptor) {
  descriptor.value = () => {
    throw new Error(`${target.constructor.name}.${name} not implemented.`)
  }
}

class A {
  @abstract
  method () {}
}

class B extends A {
  method () { console.log('h1') }
}

console.log(new B().method()) // h1
console.log(new A().method()) // error with message: A.method not implemented.

I dig that. IMO it should also require you to declare the class is abstract so we can check whether the abstract methods are indeed provided when you extend it, without waiting until someone invokes the method to error. It should also prevent direct instantiation, which is tricky cause the constructor should still be called without error if it's from a super() call (manually or by the runtime). These two additions are to keep it consistent with the behavior in Java/PHP/etc. If you have differing opinions, let me know!
If you want to take a crack at it, please do! I'm happy to help as well. I can always PR commits to your fork while we iron the kinks out.

i'd :-1: unfortunately. i'd say sure, if javascript wasn't duck typed; but it is. why bother even creating the method. you'll get thrown an error at the call site anyway. it makes sense for java however.

@moimikey if there was a clean way to have the error thrown at extend-time, it would be pretty close to Java/PHP. Also, Python is duck typed as well and supports similar abstract abilities and even decorators for them.
That said, as I noted in my previous comment edits, I can't think of an elegant way to run arbitrary code immediately when someone extends the abstract class...without that, I do indeed question its usefulness.

Hey, and Abstract Class?

@SrMouraSilva yes, if this idea gets legs. See my first comment for concerns.

+1

Ops! Sorry

Closing due to lack of consensus. Anyone is absolutely feel free to continue to discuss and if the listed issues can be resolved will reconsider. Thanks!

@jayphelps I'd like to have that decorator too.
Reasoning here is:

abstract methods are defined by the abstract base class and thus will be documented there including its parameters and overall behavior
no more need to throw new Error('derived classes must implement');
throwing these error during runtime is fine with me, considering existing tests to flesh out all non implemented methods, provided that they are actually being used in the tests
insufficient tests will make the runtime instable, so who cares if a non implemented super method causes a fatal error when being used by a third party - issues will arise and the missing tests and also the missing behavior will be implemented
being able to instantiate the abstract class is fine with me and will help in testing basic behavior of that class

other than that, a babel plugin would be required to find such issues during compile time, but that is just additional sugar on top of the icing, so to say...
the only issue I could come up with would be the developer to override an existing abstract method and then call super on that, causing the exception to be thrown... but then again...

Hi, @jayphelps! According to your first message:

It should also prevent direct instantiation, which is tricky cause the constructor should still be called without error if it's from a super() call (manually or by the runtime)

I'm not sure, but I think it must be implemented this way (REPL: http://goo.gl/eIFaZS)?
class AbstractClass {
  constructor() {
    if (this.constructor == AbstractClass) {
      throw new Error('You cannot instantiate abstract classes directly')
    }
  }
}

class ConcreteClass extends AbstractClass {
  constructor() {
    super()
    console.log('Child class instantiated successfully')
  }
}

new ConcreteClass // does not throw
new AbstractClass // throws

But there is two problems with the decorator:

I have no idea how to inject this check into AbstractClass#constructor without extending it. And extending does not looks like a good solution for me
It's not allowed in ES6 to use this before calling super, so we must use a dirty hack to be able to do the check

There is some fast implementation which demonstrates this problems (REPL: http://goo.gl/ejn8XL):
function abstract(ClassConstructor) {
  return class AbstractWrapper extends ClassConstructor {
    constructor(...args) {
      const self = eval('this') // <- the dirty hack

      if (self.constructor == AbstractWrapper) {
        throw new Error('You cannot instantiate abstract classes directly')
      }

      super(...args)
    }
  }
}

@abstract
class AbstractClass {
  constructor(message) {
    this.message = message
  }
}

class ConcreteClass extends AbstractClass {
  constructor(...args) {
    super(...args)
    console.log('Child class instantiated successfully! ', this.message)
  }
}

new ConcreteClass('Hello')
new AbstractClass

I absolutely not recommend to use the code above, it's just for continue the discussion.

@anatoliyarkhipov you again bring abstract classes into play. these are much more complicated than just having an abstract method decorator.
@jayphelps I for my part would stick with the abstract method decorator first and then, as the decorators evolve, consider making it also a class decorator.

@jayphelps Currently working on this, see REPL

REPL
abstract methods now work as expected sigh enclosing the throw in quotation marks did not do the trick...

@jayphelps  Please have a look WIP!
Revised version of the REPL
Now detects whether a subclass (Foo) should be decorated is still abstract and notifies the user of that fact. Only concrete subclasses can be instantiated (Bar).

How about a PR while I flesh out the code and rework it according to your coding style?

Ran into some conceptional problems

abstract classes can be declared using the decorator on the class: done
abstract methods can be declared: done

Now for the problems

abstract properties (get,set) can be done but making either getter or setter abstract is difficult as
E.g.

class Foo {
   @abstract
   get bar() {}

   set bar(bar) { this._bar = bar; }
}

will cause the transpiler to generate the code along the line of
{ key: 'bar', decorators : [abstract], get: function get() {}, set: function set(bar) {...} }

In the decorator we are then unable to decide whether get or set should be made abstract, unless one looks at the string representation of that function and tries to determine whether it is an empty function body. But then again, this might be intentional and the decorator would then simply generate a function that will throw an error which is definitely not what the user wants.

abstract instance initializers cannot be done
E.g.

class Foo {
    @abstract
    bar;
}

class Concrete extends Foo {
    bar = 5;
}

Here Foo will redeclare the instance property, however, since the Bar constructor will be applied first, the abstract bar is still there and will throw an error when initialized.
So, in order to make this decorator work, limitations need to be put in place, so that the decorator can only be used on classes and methods.

Hi all!
abstract - reserved word in ES and it using in TypeScript.
What do you think about it?

@frontdevops abstract was removed as a reserved word in ES5 (which this library requires at minimum).
It also is not a reserved word in TypeScript and is intentionally supported as an identifier https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#221-reserved-words.
I appreciate you following and bringing it up though cause we'd be SOL if that were the case! :smile:

Thanks for clarifying =)


Fix aocsseg inconsistency when rollback add column

Before current commit we initailized pg_aocsseg entries with frozen tuples. It is a working approach for AO tables, but AOC tables store additional vpinfo structure with serialized information about every column EOF. This can cause inconsistency when we initialize new pg_aocsseg entries with a modified amount of columns under explicit transaction and rollback it later. As we used frozen tuples, pg_aocsseg fails on the next vacuum when extracts wrong amount of columns from rollbacked tuples. As a fix we insert regular tuples to pg_aocsseg but still insert frozen tuples to gp_fastsequence as we should care about indexes.
This PR should be backported to 5X as well (master branch is not affected).

Opened https://github.com/greenplum-db/gpdb/pull/11371 to GPDB 6X_STABLE.

Opened https://github.com/greenplum-db/gpdb/pull/11371 to GPDB 6X_STABLE.

This PR break up isolation tests on adb-6.x:
--- \/home\/gpadmin\/gpdb_src\/src\/test\/isolation2\/expected\/uao_crash_compaction_column\.out2021-01-19 02:42:53.759871207 +0000
+++ \/home\/gpadmin\/gpdb_src\/src\/test\/isolation2\/results\/uao_crash_compaction_column\.out2021-01-19 02:42:53.777871199 +0000
@@ -630,10 +630,7 @@
  1     | 0          | 1              | 10       | 2        | 1
  1     | 1          | 129            | 10       | 2        | 1
  1     | 2          | 257            | 10       | 2        | 1
- 2     | 0          | 2              | 0        | 0        | 1
- 2     | 1          | 130            | 0        | 0        | 1
- 2     | 2          | 258            | 0        | 0        | 1
-(6 rows)
+(3 rows)
 -- generates truncate xlog record for all the files having entry in
 -- pg_aocsseg table.
 6:VACUUM crash_vacuum_in_appendonly_insert_1;

This PR break up isolation tests on adb-6.x:
--- \/home\/gpadmin\/gpdb_src\/src\/test\/isolation2\/expected\/uao_crash_compaction_column\.out2021-01-19 02:42:53.759871207 +0000
+++ \/home\/gpadmin\/gpdb_src\/src\/test\/isolation2\/results\/uao_crash_compaction_column\.out2021-01-19 02:42:53.777871199 +0000
@@ -630,10 +630,7 @@
  1     | 0          | 1              | 10       | 2        | 1
  1     | 1          | 129            | 10       | 2        | 1
  1     | 2          | 257            | 10       | 2        | 1
- 2     | 0          | 2              | 0        | 0        | 1
- 2     | 1          | 130            | 0        | 0        | 1
- 2     | 2          | 258            | 0        | 0        | 1
-(6 rows)
+(3 rows)
 -- generates truncate xlog record for all the files having entry in
 -- pg_aocsseg table.
 6:VACUUM crash_vacuum_in_appendonly_insert_1;

Thanks to @Stolb27 we found out a failed isolation test uao_crash_compaction. The idea of it is simple: we create AOC table, populate it with data, run update to generate enough bloat ratio, run vacuum, pause it on writing WAL on some primary segment with fault inject, persist new segment file with checkpoint, restart primary and validate that its mirror survives this operation.
As AOC table has only a single bloated segment file, vacuum creates a new segment file on compaction phase and inserts simple tuples in pg_aocseg  instead of frozen ones.
  * frame #0: 0x000000010f045e82 postgres`InsertInitialAOCSFileSegInfo(prel=0x00007ff83ba63d48, segno=2, nvp=3) at aocssegfiles.c:89:19
    frame #1: 0x000000010f03f4b7 postgres`OpenAOCSDatumStreams(desc=0x00007ff83b008aa0) at aocsam.c:772:3
    frame #2: 0x000000010f03f26f postgres`aocs_insert_init(rel=0x00007ff83ba63d48, segno=2, update_mode='\0') at aocsam.c:848:2
    frame #3: 0x000000010f04c714 postgres`AOCSCompact(aorel=0x00007ff83ba63d48, compaction_segno=0x00007ff83b0360c8, insert_segno=2, isFull='\0') at aocs_compaction.c:535:16
    frame #4: 0x000000010f216e28 postgres`vacuum_appendonly_rel(aorel=0x00007ff83ba63d48, vacstmt=0x00007ff83b035f58) at vacuumlazy.c:1873:5
    frame #5: 0x000000010f21496f postgres`lazy_vacuum_aorel(onerel=0x00007ff83ba63d48, vacstmt=0x00007ff83b035f58) at vacuumlazy.c:498:4
    frame #6: 0x000000010f21413d postgres`lazy_vacuum_rel(onerel=0x00007ff83ba63d48, vacstmt=0x00007ff83b035f58, bstrategy=0x00007ff83b035e48) at vacuumlazy.c:274:3
    frame #7: 0x000000010f212e32 postgres`vacuum_rel(onerel=0x00007ff83ba63d48, relid=32907, vacstmt=0x00007ff83b035f58, lmode=4, for_wraparound='\0') at vacuum.c:2416:3

So when we rollback running transaction (when restart primary during vacuum), this records rolls back and the failed test shows us this change (previously we used frozen tuples that are always visible, even after rollback). It seems to be ok to modify the test output for this case.

Thanks to @Stolb27 we found out a failed isolation test uao_crash_compaction. The idea of it is simple: we create AOC table, populate it with data, run update to generate enough bloat ratio, run vacuum, pause it on writing WAL on some primary segment with fault inject, persist new segment file with checkpoint, restart primary and validate that its mirror survives this operation.
As AOC table has only a single bloated segment file, vacuum creates a new segment file on compaction phase and inserts simple tuples in pg_aocseg  instead of frozen ones.
  * frame #0: 0x000000010f045e82 postgres`InsertInitialAOCSFileSegInfo(prel=0x00007ff83ba63d48, segno=2, nvp=3) at aocssegfiles.c:89:19
    frame #1: 0x000000010f03f4b7 postgres`OpenAOCSDatumStreams(desc=0x00007ff83b008aa0) at aocsam.c:772:3
    frame #2: 0x000000010f03f26f postgres`aocs_insert_init(rel=0x00007ff83ba63d48, segno=2, update_mode='\0') at aocsam.c:848:2
    frame #3: 0x000000010f04c714 postgres`AOCSCompact(aorel=0x00007ff83ba63d48, compaction_segno=0x00007ff83b0360c8, insert_segno=2, isFull='\0') at aocs_compaction.c:535:16
    frame #4: 0x000000010f216e28 postgres`vacuum_appendonly_rel(aorel=0x00007ff83ba63d48, vacstmt=0x00007ff83b035f58) at vacuumlazy.c:1873:5
    frame #5: 0x000000010f21496f postgres`lazy_vacuum_aorel(onerel=0x00007ff83ba63d48, vacstmt=0x00007ff83b035f58) at vacuumlazy.c:498:4
    frame #6: 0x000000010f21413d postgres`lazy_vacuum_rel(onerel=0x00007ff83ba63d48, vacstmt=0x00007ff83b035f58, bstrategy=0x00007ff83b035e48) at vacuumlazy.c:274:3
    frame #7: 0x000000010f212e32 postgres`vacuum_rel(onerel=0x00007ff83ba63d48, relid=32907, vacstmt=0x00007ff83b035f58, lmode=4, for_wraparound='\0') at vacuum.c:2416:3

So when we rollback running transaction (when restart primary during vacuum), this records rolls back and the failed test shows us this change (previously we used frozen tuples that are always visible, even after rollback). It seems to be ok to modify the test output for this case.


How to build VoTT in Visual Studio 2017 ?

How to build VoTT in Visual Studio 2017 ?

Most of our dev team uses VS Code for VoTT development and a heavy IDE like full blown VS 2017 are not officially supported.


Update Exchange.sol: SellOrder should mint a Prime

Currently, if a user wants to open a new short position (sell) they would need to submit three transactions. (1) Mint Prime, (2) Approve Prime transfer to Exchange, (3) List Prime on Exchange with sellOrder(). This is costly in both gas fees and time, and it would be exacerbated during a period of network congestion.
AC:

In the sellOrder() function in Exchange.sol call createPrime() directly and mint it directly to the Exchange contract. This way there is only one transaction with sellOrder().

Currently listing a Prime on the DEX that is already owned (minted not through Pool or Exchange) isn't even supported, so there's no reason not to include a Prime mint in the function call.

This would also fix #10 because it would mean buy and sell orders are 1 transaction.


memory issue, train.py

Hi,
I use the train.py to train our data. However, it shows no memory. Which parameter should I change? Our data size is 6000*4000.
2017-08-28 21:55:18.073583: I tensorflow/core/common_runtime/bfc_allocator.cc:700] Sum Total of in-use chunks: 10.55GiB
2017-08-28 21:55:18.073595: I tensorflow/core/common_runtime/bfc_allocator.cc:702] Stats:
Limit:<PHONE_NUMBER>2
InUse:<PHONE_NUMBER>8
MaxInUse:<PHONE_NUMBER>8
NumAllocs:                     275
MaxAllocSize:<PHONE_NUMBER>
2017-08-28 21:55:18.073630: W tensorflow/core/common_runtime/bfc_allocator.cc:277] ***********************************************************************************xxxxxxxxxxxxxxxxx
2017-08-28 21:55:18.073655: W tensorflow/core/framework/op_kernel.cc:1152] Resource exhausted: OOM when allocating tensor with shape[24000000,2]
Traceback (most recent call last):
File "train.py", line 131, in
tf.app.run()
File "/home/ubuntu/anaconda2/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 48, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "train.py", line 127, in main
train.do_training(hypes)
File "incl/tensorvision/train.py", line 396, in do_training
run_training(hypes, modules, tv_graph, tv_sess)
File "incl/tensorvision/train.py", line 245, in run_training
feed_dict=feed_dict)
File "/home/ubuntu/anaconda2/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 778, in run
run_metadata_ptr)
File "/home/ubuntu/anaconda2/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 982, in _run
feed_dict_string, options, run_metadata)
File "/home/ubuntu/anaconda2/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1032, in _do_run
target_list, options, run_metadata)
File "/home/ubuntu/anaconda2/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1052, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.ResourceExhaustedError: OOM when allocating tensor with shape[1,3,4000,6000]
[[Node: conv1_1/Conv2D = Conv2D[T=DT_FLOAT, data_format="NHWC", padding="SAME", strides=[1, 1, 1, 1], use_cudnn_on_gpu=true, _device="/job:localhost/replica:0/task:0/gpu:0"](Processing/concat, conv1_1/filter/read)]]
[[Node: Loss/loss/add_1/_27 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/cpu:0", send_device="/job:localhost/replica:0/task:0/gpu:0", send_device_incarnation=1, tensor_name="edge_1956_Loss/loss/add_1", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/cpu:0"]]
Caused by op u'conv1_1/Conv2D', defined at:
File "train.py", line 131, in
tf.app.run()
File "/home/ubuntu/anaconda2/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 48, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "train.py", line 127, in main
train.do_training(hypes)
File "incl/tensorvision/train.py", line 377, in do_training

Hi @qoo . Can you please explain how did you train the KittiSeg Model on your own data. As in where the training and validation data should be kept ?