fixes wagtail.Site instance retrieval

makes it work with wagtail 2.9

Thanks for this, released in version 3.1.0 :tada:

woop woop!


Report bibliography

Contact mechanics functions should return DOIs of relevant papers. (An @doi decorator for this was recently introduced into SurfaceTopography.)

Related to #46

Ar you sure you point to the proper issue ?


Hyperlink DOIs against preferred resolver

Purpose
Same as #5436: Updating code that generates DOI links to use the preferred resolver, see √https://www.doi.org/doi_handbook/3_Resolution.html#3.8
Changes
See above.
QA Notes

Documentation

Side Effects
I'm not sure whether the change to citeproc.js should be included here. My PR against their source is "open": https://bitbucket.org/fbennett/citeproc-js/pull-requests/8/
Also, instead of updating the test, maybe duplicating it with both URL variants makes more sense?
Ticket

Good catch. Thanks!

You're welcome, and thanks for merging :-)


https://jira.desk.technology/browse/APIC-155

@nartiles please review

@nartiles After pushing these changes I started looking into documentation more and I found out that Cases API (http://dev.desk.com/API/cases/#history) has also "class":"history", hence there will be a conflict when we make a request for Case history, it will return DSAPIOpportunityTimeline class.
I'm thinking about following workarounds:

Ask API team to change class name for something different.
Use single class DSAPIHistory for both Case and Opportunity history. I notice that both Case and Opportunity history response have similar structure.

Thoughts?

Btw, In https://github.com/forcedotcom/DeskApiClient-ObjC/pull/26 there was a similar scenario with attachments and I decided to use DSAPIAttachment class for both case and opportunity attachments.

Regarding 'history', I think I'd prefer we have different classes similar to what we have for filters. Semantically, I don't see a reason why a case history would be the same as an opportunity history so even though they are similar now they could change later. However, before we ask the API team though I'd like to know what Android is doing and get on the same page with them. (BTW, they're out this week at Google IO).
Regarding 'attachments', I'm ok with attachment being the same class. This is more representative of a file so semantically I think its ok if they are the same.

The resource classes doesn't have any model structure related logic. Hence, If the structure of the history API changes, it will not cause any issues.
However, if in either of these API, we'll have case or opportunity specific methods (like: showOpportunityForHistory), in that case we might need to create a specific resource class.
Similar scenario we had with filters, where each filter API has specific methods for models it has relation. What if we take the same approach here?
Start with DSAPIHistory class and if we have a new method specific to the model it is relating, than we create DSAPICaseHistory and DSAPIOpportunityHistory.
Btw, fyi, we don't have a DSAPIHistory class for cases. We are using DSAPIResource.
I'm also very concerned about dynamic mapping resource classes based on "class" attribute. It is very brittle.
If "class" attribute is changed on API side, it will cause a big issue on our end. I think we should eventually get rid of this approach.

I'm ok with that. Start with one class and change later if we need to.

@nartiles please review

@eldark88 :shipit:


Native scrollbars on Windows?

Terminus is displaying "native" scrollbars on Windows
If you look to the right, you can see that the scrollbars are native-styled.

Could you replace these scrollbars with something like OverlayScrollbars instead?

I can reproduce this on https://github.com/Eugeny/terminus/commit/dff55558dd05c7d5cc743cdbf0d2e7dad5d11dd4.


revision is same for different files

Library Affected:
<EMAIL_ADDRESS>Issue or Feature Request Description:
The revision is the same for css and js files, this results in an update of both even if only one is changed.
Here the resulting precache-manifest
self.__precacheManifest = [
  //[...]
  {
    "revision": "eff352b7020bf1abb0f7", //<--
    "url": "/js/app.12d0499e.js"
  },
  {
    "revision": "eff352b7020bf1abb0f7", //<--
    "url": "/css/app.e8acb75f.css"
  }
];

My vue.config.js file (using https://www.npmjs.com/package/@vue/cli-plugin-pwa)
process.env.VUE_APP_VERSION = (new Date()).toISOString();

module.exports = {
    devServer: {
        proxy: 'http://localhost:8000'
    },
    // ...other vue-cli plugin options...
    pwa: {
        name: 'My App',
        themeColor: '#4DBA87',
        msTileColor: '#000000',
        appleMobileWebAppCapable: 'yes',
        appleMobileWebAppStatusBarStyle: 'black',
        workboxPluginMode: 'InjectManifest',
        workboxOptions: {
            //https://developers.google.com/web/tools/workbox/modules/workbox-webpack-plugin
            swSrc: __dirname + '/public/service-worker.js',
            importWorkboxFrom: 'local',
        }
    }
}

Here is the code that assigns the same hash to all files in a chunk:
https://github.com/GoogleChrome/workbox/blob/b146d8d3c2db89fa51afc322049b9795894bb4f2/packages/workbox-webpack-plugin/src/lib/get-manifest-entries-from-compilation.js#L110-L119

This is definitely an area where improvement is needed—I believe https://github.com/GoogleChrome/workbox/issues/1454 already tracks this, and I'm closing this issue in favor of that.
If you're asking about a different issue, then please let us know and we can reopen this request.


Input & Output FTP/SFTP components

Develop input and output FTP/SFTP components which will be able to transfer files to and from any FTP/SFTP server.

Merged into main branch.


allow skipping global configuration

Allows skipping global logrotate configuration in /etc/logrotate.conf

closed: created dedicated branch


Release 2.14.0

Please verify that the merged PRs include only the attached Trello cards and Greenkeeper PRs.

 Update script to whitelist with Kaspersky and McAfee automatically

 [uploader] Libre date&time changes are stored as two separate time change events

 [uploader] TypeError when there are no records on a Libre

 [uploader] Upload Libre "scan" records as SMBG record

 [Uploader] Add qa1 environment to Uploader server list

 Improve usability of Mac DMG installer

 Store Omnipod IBFs using blob service

 [uploader] VCA appears to be able to change non-custodial patient email address, but silently fails

 [BUG] Uploader not handling the "user already exists" error


Are test spec durations missing?

I'm using the plugin, and see all my tests show up fine, but I can't seem to be able to see test duration for either 'spec' reporter or 'mocha' reporter.  Am I missing something?

@adjavaherian - Test output depends entirely on what reporter/s you have enabled. If this is still an issue, past in your Karma config and i'll take a look.


interface.base.SQLInterface.get_SQL options

the get_SQL() method takes a few kwargs options:
count_query -- boolean -- true if this is a count query SELECT
only_where_clause -- boolean -- true to only return after WHERE ...

It might make it easier to fully support subqueries if these options were on the Query instance and this method didn't take any defined options. Something like:
q = Query()
q.is_count = True
q.only_where = True # q.is_where?

q.count_query = True
q.where_query = True

I have to be careful of the names so they don't interfere with actually doing a query. Although I think is_count and is_where would work because both count and where are SQL keywords

get_SQL was broken into multiple methods sometime in the last 3 years, and render_select_sql and render_where_sql kind of handle this so I'm not sure it's worth adding more things to the Query class anymore.


DJ UI: Top level page for building SQL and viewing sample data

Summary
This adds a "Cube Builder" page (all suggestions for a better name are welcome!). It's a top level page where you can select metrics and dimensions and see the SQL get generated. As metrics are selected, it uses the /metrics/common/dimensions/ endpoint to filter the dimension list down to those shared by the metrics.
I've also added a Run Query button that will let you run the generated query and provides the data in a table below. I don't think we need to go all out and build this as an analytics BI tool (there are plenty out there that are feature rich and that DJ should eventually integrate with), but it's a good demo/dev mechanism to testing much of the functionality end-to-end. I'm planning to put a very low hard cap on the data table rendered, maybe 100 records, so it will serve as more of a mechanism for viewing a "sample" of the results of the query.
Curious to hear everyone's thoughts.
https://github.com/DataJunction/dj/assets/43911210/132fcf73-088c-4ac3-9c7f-2d6d1f80e568
Test Plan

[ ] PR has an associated issue: #
[ ] make check passes
[ ] make test shows 100% unit test coverage

Deployment Plan

I do wonder if at some point we want to move towards using the JS client, since otherwise we'll just have a lot of parallel functionality in DJService 😅 No need to do anything for this PR obviously

I kept thinking a lot about this and I totally agree. I was going to work on this but I figured it may be good to get the UI to a point where it's touching a larger surface area of the GET portion of API first (which is where I think we are now with this PR and your materialization one). My plan now is to match up the direct API calls to the javascript client and implement any missing features into the javascript client. Then I'll do an in-place swap and make sure there aren't any regressions.

@shangyian sounds good! I'll update this PR to use that 👍

@shangyian I updated the PR to use react-form and updated the video in the PR description. After rebasing I also worked in some various cleanups including fixing an incorrect join in the demo notebook, renaming the djui directory to be datajunction-ui for consistency, and adding the docker compose dj.demo.db -> dj.db copy hack that I did for djqs.


Option to open R console in split editor window

Is your feature request related to a problem? Please describe.
For some time, it's been possible to open up a terminal in VS Code's editor area, by toggling the "terminal.integrated.defaultLocation": "editor" setting. This affects the behaviour of the R console too; the R console will open in the editor area rather than the traditional "view" area.
By default this editor-based terminal opens up in a new (background) editor tab. But it's also possible to open it up in a separate window by invoking the "workbench.action.createTerminalEditorSide" action ("Terminal: Create New Terminal in Editor Area to the Side" in the command palette).
Unfortunately, I cannot see a way to control/automate this open-to-the-side behaviour for the R console specifically. It always seems to open in a new tab, even if I have an existing terminal opened to the side, or have configured my layout in a custom grid.
Of course, I can can drag and drop the spawned R console into a side window once it's running. But I would like to trigger this behaviour automatically.
Describe the solution you'd like
A setting that would open the R console in a separate editor window (to the side, rather than a new tab), provided that "terminal.integrated.defaultLocation": "editor" is enabled.
Describe alternatives you've considered
Provided that you keep the default "terminal.integrated.defaultLocation": "view" setting, it's easy to enact this "open to the right" behaviour through the "workbench.panel.defaultLocation": "right" setting. But again, this requires your terminal to be running in the "view" area, rather than the "editor" area. And this, in turn, limits the layout configuration that you can impose inside VS code.  (Here's one example of many SO questions to this effect.)
Additional context
https://github.com/REditorSupport/vscode-R/issues/682 is loosely related (although I feel this editor-anchored console is much more reliable now)
As always, thanks for an incredibly useful extension!

You could set
"terminal.integrated.defaultProfile.osx": "R Terminal" (profile name might be different),
then the default terminal will always be Rterm.
If you have a user keyboard shortcut, then instead of using r.createRTerm, you could change it to workbench.action.createTerminalEditorSide, and then it will always be opened in the side editor window.


feat(storage): seed buckets locally from config file

What kind of change does this PR introduce?
closes #2413
What is the new behavior?
TODO:

[x] push buckets on supabase seed buckets [--local|--linked]
[x] overwrite existing bucket properties
[ ] sync buckets on supabase link?

Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

21 of 24 (87.5%)  changed or added relevant lines in 2 files are covered.
11 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 60.302%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/start/start.go
18
19
94.74%

internal/storage/cp/cp.go
3
5
60.0%

Files with Coverage Reduction
New Missed Lines
%

internal/start/start.go
11
56.49%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
6916

Relevant Lines:
11469

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

36 of 92 (39.13%)  changed or added relevant lines in 5 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 61.192%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/start/start.go
3
5
60.0%

internal/storage/client/api.go
5
7
71.43%

cmd/seed.go
8
16
50.0%

internal/seed/buckets/buckets.go
15
59
25.42%

Files with Coverage Reduction
New Missed Lines
%

internal/start/start.go
2
69.72%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
7053

Relevant Lines:
11526

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

36 of 92 (39.13%)  changed or added relevant lines in 5 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 61.192%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/start/start.go
3
5
60.0%

internal/storage/client/api.go
5
7
71.43%

cmd/seed.go
8
16
50.0%

internal/seed/buckets/buckets.go
15
59
25.42%

Files with Coverage Reduction
New Missed Lines
%

internal/start/start.go
2
69.72%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
7053

Relevant Lines:
11526

💛  - Coveralls

@sweatybridge I needed this today and just upgraded to the latest CLI version to use it. The core functionality worked like a charm, thanks! 🎉
One thing I noticed is that the S3_* variables in [experimental] are now required, throwing the following error when not included in config.toml:
Error evaluating "env(S3_HOST)": environment variable S3_HOST is unset.
I presume that this is unintended and that all experimental variables should be considered optional? In my case, I added the following to config.toml to get everything working locally:
[experimental]
S3_HOST="http://<IP_ADDRESS>:54321/storage/v1/s3"
S3_REGION=""
S3_ACCESS_KEY=""
S3_SECRET_KEY=""

^ Confirming that this same S3_* breaking change bit us today and that adding the snippet from above to our config.toml also resolved the problem.
Thanks for the assist, @lightstrike 🙏


No map in scenario editor

Describe the bug
In dreamland, when I try to see a map in scenario editor, it doesn't show anything
To Reproduce
Steps to reproduce the behavior:

Go to Dreamland
Click on scenario Management -> Scenario Editor
Create a map
Nothing will be there

Expected behavior
It's expected to have a map in the editor.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 18.04
Browser: Firefox, Google Chrome

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


PIC12F1840: Wrong device ID: 0000, expected: 1b80

Hi.
I have been trying to use this application on Windows to program a PIC12F1840, however, the pp3 reports the following problem:
C:\>pp3.exe -c COM7 -t 12f1840 blink.X.production.hex
PP programmer, version 0.99
Wrong device ID: 0000, expected: 1b80
Check for connection to target MCU, exiting now

My is an Arduino Uno connected as following:

Arduino pin
Target PIC pin

GND
GND

5V
VDD

A3
MCLR

A1
ICSPDAT

A0
ICSPCLK

Note: I'm using series resistors (470 Ohms) because the target IC is in the board below being programmed via ICSP:

NOTE: the board was programmed via PICKit3 before, so the problem is not related to the board.
HEX file for testing in attachment, It is just a blink application (in RA5 pin) generated from MCC using latest XC8 version.
teste.X.production.hex.txt
TIA for any help to solve it!

It could be a PIC12LF1840; I bought on aliexpress 10 mcu marked as PIC12F1840 and got PIC12LF1840 instead. I don't know if it is a fake chip remarked or if it is a mistake of microchip.

I have the same issue. What I have is just PIC12F1840 soldered to 8-pin breakout board, and connected to Arduino Nano as silvioprog described. At first I tried to use Arduino Mega at 3.3V to program it, but had the same issue, so I thought using Arduino Nano at 5V will help, but I still get device ID "0000". Any ideas what else to try?

According to the data sheet, Vpp on MCLR needs to be within 8-9V range. I found another project https://diyodemag.com/projects/arduino_pic_programmer they had to use charge pump to generate high voltage, since using 5V from Arduino is not sufficient, and adding pull-up to high voltage would kill the Arduino, so opto-isolator is necessary.
I'm not sure if reading the device ID supposed to work without 9V Vpp? If reading device ID happens after entering programming mode, then I guess it is impossible, because 12F1840 will not enter programing mode without 8-9V Vpp according to the datasheet.

After reading the datasheet carefully, I see that PIC12F1840 supports Low-Voltage Programming so in theory it should work using VDD only, without high voltage. But unfortunately so far I cannot make it work. I do not have high-voltage programmer so I cannot try high-voltage programming.

I personally verified PIC12F1840 and it worked. Could you show me your hardware connection?

Sure, I would appreciate any ideas what could be wrong.
Arduino pin | PIC12F1840 pin
        GND | GND
         5V | VDD
         A3 | MCLR
         A1 | ICSPDAT
         A0 | ICSPCLK

It may be hard to see connection on the photos, especially the last one, but at very least it shows 5V (the red wire) is connected to pin 1 (VDD) and the brown wire to ping 8 (GND). Other connections are as described above, I checked them multiple times.
I also connected oscilloscope, and captured first sequence of signals after ICSPCLK was triggered for the first time. Yellow line is MCLR and for the duration of captured period it is about 0V, the green line is ICSPCLK and the red line is ICSPDAT.

PIC12F1840 is brand new, it was always connected with right polarity and wasn't overheated during soldering, and I checked that every wire conducts electricity as it should. From what I see in the oscilloscope, it seems to confirm I have used right Arduino pins. Unfortunately all I get is the error "Wrong device ID: 0000, expected: 1b80".
Am I doing something wrong, and if not, is it worth to try high voltage programming (I have no problem adding it in the circuit, but I did not figured out yet how to change the firmware)?

Hello,
I just tried to take fresh arduino compatible board, downloaded sources from repository, flashed the arduino board, connected 12F1840 on a piece of breadboard and it just worked.

Are you sure the PIC is new? Does it come from reputable source?

I got it from AliExpress seller, and they had a lot of good feedback, so this can be considered a reputable source. I double checked everything, and to my surprise I have discovered that ground on my soldering iron wasn't properly connected, and AC voltage was present on the soldering iron. Perhaps this is what killed it. I decided to buy one more 12F1840 locally because I couldn't wait 1-2 months again for a delivery from AliExpress, I really needed 12F1840 for an old project for which I had the source code, but porting it to modern microcontroller would take many days of work.
I of course fixed ground connection on my ESD-safe soldering iron before soldering. After that, I have soldered it and tried programming it, and it worked. I tested programming with 3.3V and 5V, in both cases programming finished successfully.
Perhaps my experience would be useful to somebody in the future (this thread comes up high in Google when searching for "Wrong device ID: 0000, expected 1b80"), but the point is, programming firmware and software works fine, my issue was because of dead 12F1840. I was not able to realise this right away because I was new to this and did not have another PIC to test at the time.


Add documentation for new mix options

Adding documentation for new mix options mix:compile --no-progress and mix:list --json in pull request at wintercms/winter#1087

Blocked by https://github.com/wintercms/winter/pull/1087


Can't compile in VS 2017: NU1101	Unable to find package Microsoft.Logging.Stubs

Repro steps:

Open .sln in VS 2017
Ctrl+F5

Expected:
compiles and runs
Actual:
Error in VS:
Severity	Code	Description	Project	File	Line	Suppression State Error	NU1101	Unable to find package Microsoft.Logging.Stubs. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages, NuGet.org

Same error for VS 2015.

Visual Studio(2015 or 2017) and Visual Studio Code should be listed in the installation prerequisites.

NU1101 Error

Thank you for reporting the issue and we are looking at it.  I'll post an update as soon as it's available.  Also, Visual Studio 2017 should be the go to IDE for this project.  I'll update the description.

The master branch should have this issue resolved now.


Transformer.sol Documentation

/cib

@aqzhen also add more tests for Transformer.sol to achieve 100% branch coverage


More details on conclusion

Hey!
The paper is extremely well written but could you give some more info on the following part -
The proposed CC shows its promising performance in clustering. In the future, we plan to extend it to other tasks and applications such as semi-supervised learning and transfer learning.
This was mentioned in the conclusion.
Is this a new area of research, or are there applications other than clustering that can be done with this existing repository?
Can you please give some more insights about this part?

Thanks for your interest! What you mentioned above is our intuitive plan on extending our method in the future. This repository is used for image clustering or unsupervised representation learning.


Add new RSpec/BeEmpty cop

This PR is almost a copy of #1594, but with this feedback incorporated.
This pull request add a new cop should use the be_empty matcher when using contain_exactly or match_array to check for an empty array.
# bad
expect(array).to contain_exactly
expect(array).to match_array([])

# good
expect(array).to be_empty

Similar but unpublished behavior is removed from RSpec/ContainExactly and RSpec/MatchArray cops.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[x] Added the new cop to config/default.yml.
[x] The cop is configured as Enabled: pending in config/default.yml.
[x] The cop is configured as Enabled: true in .rubocop.yml.
[x] The cop documents examples of good and bad code.
[x] The tests assert both that bad code is reported and that good code is not reported.
[x] Set VersionAdded: "<<next>>" in default/config.yml.

cc @pirj if you’re back 🙏🏼


Bending of a Mesh as per Curvature

can we apply bending or curvature to a mesh as:

If you already know the displacements at each vertex you can update the new positions with:
mesh.points(mesh.points()+displacements)
If displacements are only known for arbitrary positions in 3d space you can use:
mesh.warp(sourcepts, targetpts)
vedo --search warp
Otherwise you need to model the deformation by e.g. FEM. The are numerous example in examples/other/dolfin.

I apologize for bringing this topic back to life. I am wondering if this is possible by attaching the mesh to a curve, such as a Spline.
Or is there any option to extrude a mesh along a defined Spline?
Kind regards,
Kostas

Hi Kostas, I think these two examples can be useful:
examples/basic/ribbon.py
examples/advanced/contours2mesh.py

Thanks a lot for the prompt answer!  :)


Increase Required Pip Version

Tensorflow and jaxlib installs will fail unless latest pip version is installed -- default Windows Ubuntu pip version is very low.

Nice!

Tensorflow and jaxlib installs will fail unless latest pip version is installed -- default Windows Ubuntu pip version is very low

Right, we currently have the pip upgrade in the installation instructions. Hmm... I didn't realize you could actually put the pip version in requirements.txt. I am not super knowledgeable on the Python dependency system; I wonder if this has any problematic consequences?
I will ask someone who knows a bit more to come comment, but I guess it should be ok.

I have gotten a few reassurances that this should be fine. I will import it today so it should go out in Monday's update. Thanks!


feat: add short name for PGN(Public Goods Network) and Sepolia PGN

What it solves
Adds short names for PGN and Sepolia PGN:

https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-424.json
https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-58008.json

Contracts we published at v1.29.0 of safe-deployments
Thanks in advance!

This was already added in the development branch
https://github.com/safe-global/safe-core-sdk/blob/d5927980cae6d84d2a58fe3cf45931339fea0506/packages/protocol-kit/src/utils/eip-3770/config.ts#L59
https://github.com/safe-global/safe-core-sdk/blob/d5927980cae6d84d2a58fe3cf45931339fea0506/packages/protocol-kit/src/utils/eip-3770/config.ts#L138


Close hangs app when WithNoConnClose

When stun connection is created from existing connection, and WithNoConnClose is provided, Close hangs app.

I have the same issue. Debugging showed that Close waits for readUntilClosed go-routing to exit, but that go-routine is blocked on ReadFrom call here https://github.com/pion/stun/blob/0f7f72b905d54eaf8e477af78c6a3d42f54ea217/client.go#L327 .
Workaround is to call SetReadDeadline(time.Now()) before calling Close for the stun.Client. It causes ReadFrom to immediately exit.

@hashok Calling SetReadDeadline(time.Now()) closes the connection.

@adsko It shouldn't do that. Make sure you call SetReadDeadline(time.Time{}) on the underlying connection after stun connection is closed to restore the original behavior of the underlying connection.

How do we fix this issue?
Setting the read deadline in Close() is not feasible since the connection only implements the following interface:
// Connection wraps Reader, Writer and Closer interfaces.
type Connection interface {
	io.Reader
	io.Writer
	io.Closer
}

We could call c.wg.Done() manually to unblock the c.wg.Wait() in Close().
However, that would leave us with a leaked Goroutine and might cause some panic if the connection still ends up receiving data while the client has been closed?


'cache()' should allow subscribe after unsubscribe

RxJS version: Latest
Code to reproduce:
var cached = Observable.timer(200).cache();
var subscription = cached.subscribe(v => console.log(v));
setTimeout(() => {
    subscription.unsubscribe();
    cached.subscribe(v => console.log(v));
}, 100);

Expected behavior:
"0" in console.
Actual behavior:
Nothing in console.
Additional information:
Subject should be nulled on outerSub unsubscribtion
https://github.com/ReactiveX/rxjs/blob/master/src/operator/cache.ts#L55

... and here's another issue that leads me to believe cache should be removed from v5 until we more specifically bikeshed it's behavior.

Oh, it's probably a dupe of #1959
Use case from my project (serviceCall is angular 2 http.post with retry logic):
cache.observable = serviceCall
    .expand(() => Observable.timer(period).concatMap(() => serviceCall))
    .cache(1, period);

@newsash we ended up removing the .cache() operator for RC1 because in it's current state it was too confusing and [poorly] trying to solve too many problems.


fix(actix): support parsing arrays for schemas

Array field types were not being parsed.
Also in this case errors were not being handled gracefully.
Resolves #454

@sireaev this should fix it.
@formlogic-kirk seems arrays were not being handled properly, would you mind taking a look at this fix?


Enabled warnings as errors for Visual Studio builds.

Enabled warnings as errors for VS builds.
Largely reduced build times by removing redundancies for VS builds.

Fixed all the incorrect type casts reported by the compiler.
Fixed uninitialized pointer variables.

I believe I forgot to set up the dependencies for all of the projects. I'll fix that in a moment.

I can revert the changes in the triangle example if you like. I don't see the point on building over and over the vulkanexamplebase files for the other projects and I believe most people dealing with this code probably knows about linking a simple lib. In my case I did this because my computer is too slow and building 50 times the same files for no reason is something I just can't afford.

Thx for your effort. Moving the example base to a library has been requested several times, but I actually prefer it the way it currently is, so if there are no other advantages rather than I'd prefer not to change that.
I also don't want warnings to be treated as errors. While I do that at work for production stuff I prefer a bit more freedom for my personal projects.
But befor discussing this any further: Does this also affect Linux and Android builds? And if so did you test on Android too? CI is only applied for Windows and Linux currently.

This affects only Windows builds because the only files changed are the .sln, the .vcxproj and the .filters files, so if you use other build pipeline than VS it should be the same as before except for a few variables to which I added the initialization but that shouldn't be a problem for any of the builds I suppose (I just added = VK_NULL_HANDLE; in front of some member variables). The warnings I had were mostly casts from size_t to uint32_t or signed/unsigned mismatch but I fixed them all and I believe they shouldn't be any problem for any of the builds.

Okay, if it's windows only I may think about it again. As this is a pretty extensive PR please give me some time to review and decide on it. And thx for all the effort 👍

Thanks, it's really helpful to reduce the timing because my notebook is slow and it eats up a lot of battery when building. Sadly I don't own an Android device with Vulkan support to test it but the code is mainly untouched.
There is one of the warnings reported by the static analyzer is that in VulkanDevice::copyBuffer() line 441 there is the following check: assert(src->buffer && src->buffer); which is redundant, so I thought maybe the intention was to check for dst->buffer in one side? If so, I can fix it in my next commit, which would leave all the warnings reported by the static analysis also fixed.
The warnings I've fixed from the static analysis were just a few:

A hidden variable due to using the same name in an inner scope (I can't remember the name now).
The WinMain missing the SAL annotations.
Using uninitialized shaderStages variable.
The one I mentioned about the redundant src->buffer assert (pending).

Actually, there's one more thing. I've been fooling around with the warning level last night and noticed than when increasing it from 3 to 4 the compiler throws more warnings, some of which being actual bugs that go unnoticed. The most common problems seems to be cause of the naming convention and it's that some parameter variables end up being assigned to themselves instead of copying the value to the member variables. Also, some of the initializers are failing to assign the "flags" parameter to the Vulkan structs.

The most common problems seems to be cause of the naming convention and it's that some parameter variables end up being assigned to themselves instead of copying the value to the member variables. Also, some of the initializers are failing to assign the "flags" parameter to the Vulkan structs.

Thx for the info. I'll take a look at these.

Glad to be of help. I'll be working with your code so I'll let you know if I find something else.

I've added another bug fix. This one was spotted after I added initialization of Texture::device to nullptr to find out in shadowmappingomni that it was never being assigned yet it was being used to call vkDestroyImage or something from Texture::destroy().

Closing due to inactivity.


Exclude entities from LongParameterList rule

Entities typically have large constructors, reflecting the columns in the database tables. Trying to reduce the number of arguments is non-trivial and may result in worse performance and an unnecessarily fragmented database design.
This commit globally excludes Entities from that rule, and removes any detekt-baseline.xml entries that are now covered by this exclude.

Yeah, happy with this - we've got a couple of @Suppress annotations with LongParameterList included, so would be good to get rid of these in this branch too if we can 👍

Good thinking, I didn't consider checking for existing @Suppress annotations. I've just checked and all our existing LongParameterList annotations are against types other than entities, so i'll leave them as-is


Add an ability to disable expiration time randomization.

The library has this code to slightly change the expiration time.
$expirationDiff = rand(0, floor($cacheTime * .15));
$expiration -= $expirationDiff;

I know the reason, it's also discussed here.
Could you please add an ability to disable this feature when it's needed?
Developers should be able to set precise TTL when they really want to do that.

You can disable this at the Pool or Item level.
$pool->setInvalidationMethod(Stash\Invalidation::NONE)

This can be done on the item level as well. You may want to read through all the invalidation methods to see which one fits your needs most.

I checked it, but this parameter does not change the behavior I mentioned.
Here
private function executeSet($data, $time)
    {
       ....

        // We need to be able to disable this part
        if ($cacheTime > 0) {
            $expirationDiff = rand(0, floor($cacheTime * .15));
            $expiration -= $expirationDiff;
        }


Nib files are available via CocoaPods

Hi,
I want to use Tutti via CocoaPods without merging nib files manually.
So I pull to request this changes.
Please check diffs😊
Thanks

Hi,
Thank you for the pull request! However, the xib files and image resources are intentionally placed in the example app and not in the library, since each app that uses Tutti will most probably use their own styles. Therefore, adding all images and xibs from the example project (which I haven't put that much time and energy into) would make all standard tutorials created with this library look sketchy.
However, I think you're on to something, that there should be some built-in styles, so that creating a basic tutorial becomes really easy. If so, I'll create an issue to add some nicer styles to it.
/Daniel

Hi @danielsaidi
Thank you for reviewing.
I modified my PR code by your response.

Recommend as User's own style

Updated README
Updated samples

Yes, I want to use as built-in style.
In my opinion, TutorialViewController is may not have a lot of customizability because it's can only  extend from UICollectionViewController.
It means change difficultly to other protocol even if User prepared User's own .xib file .
(Easy to customize size, color, text)
Or maybe implementation via IBDesignable and IBInspectable is better than this PR diffs.

Hi again @WataruSuzuki
I'm sorry for my very slow reply. I've been away traveling without my computer, and haven't had a chance to look at your changes.
I agree with the TutorialViewController - it should have a more specific name. I am currently busy with another library, but I will return to Tutti and improve things later, most probably in August.
I also want to wait with adding resources like xibs and images to the library, since I am planning to add support for Swift PM...and I don't think it supports static content. If so, I think that it would be better to add a bunch of tutorial styles that you can drag and drop from the demo app to your own app.
Would love to hear your thoughts on that idea.

HI @danielsaidi
Thank you for replying and sorry late to response.
I'm not mind supports static content or not.
And I'm not sure about "drag and drop" steps adding manuals.
It means Tutti library cannot start without own Users customize.
I want to add the option : Can start without customize style.

sometimes, I use Tutti with optimize own App.
sometimes, I use Tutti ASIS (**default style)

Could you add default/place holder style for Tutti?

Hi again @WataruSuzuki
I will add improved tutorial support and some templates, when the new Xcode and iOS versions are released later this autumn. I hope to be able to get around to this in August/September.


reproduce arxiv classification task

We try to reproduce arxiv task with f1 92 as shown in the paper, we are using default hyperparameters defined in bigbird/classifier/base_size.sh, pretrained checkpoint here, but with batch size = 2 due to memory limitation (total batch size = 8gpu * 2 = 16), after  16k steps (16000 * 16 / 30034 = 8.5 epoch), but only get f1 84 in the end, which is too low compare to the paper which is trained by 10 epochs.
Did we missing something? preprocessing of Arxiv? or just because of the batch size is too small?
Will you release the checkpoint of Arxiv in the future?
About the difference of dataset, we have finetune roberta on the same arxiv dataset and get f1 86, pretty close the the paper.

Yes, I am experiencing a similar result. Did you forget to remove the leaked labels in the original data of the text from the scraped PDF text? (i.e., some samples have the label directly in the text, so classifying it is trivial)
The fixed version (non-leaked labels) is on huggingface: https://huggingface.co/datasets/ccdv/arxiv-classification, but I'm not sure if the authors used this version (no_ref subset).


Admin Dashboard Delete Confirmation Dialog

Resolves #21
I created a smaller PR for the admin panel, because the other one started to get too big and complicated. This one is just focused on breaking the admin panel down into smaller components. Styling changes will come later. Also I couldn't abstract the v-dialog for editing, so would really appreciate if someone else could tackle that one!
What this PR does:

Creates a PendingSubmissions component
Creates a DeleteDialog component
Abstracts the table headers to dbTableHeaders.json

How to test
Create a fake clinic submission on the site preview and delete it.
Screenshots

Great stuff.
Re:

Also I couldn't abstract the v-dialog for editing, so would really appreciate if someone else could tackle that one!

Was there a specific change you wanted to add to it?

Just to make it a separate component so it can be used to edit pending submissions and existing data in the db.

Great stuff.
Re:

Also I couldn't abstract the v-dialog for editing, so would really appreciate if someone else could tackle that one!

Was there a specific change you wanted to add to it?

Just to make it a separate component so it can be used to edit pending submissions and existing data in the db.

Ah I see. Creating a generic dialog component, ne. If we want to preserve inline styling that could make sense; otherwise I'd say <v-dialog /> is itself the abstraction.

LGTM!


Sections content with notebook name and hostname

The first section should ideally have the notebook name to be extra clear b) add the hostname (socket.gethostname()) as the title of the second section.

Fixed by https://github.com/Quansight/jupyterlab-kernel-usage/commit/f8831be7e9aa70b1fbd1ab5f17a0fef5ba19cf37


Extracting package name from pubspec.yaml

Is there a reason why the --package is required when the imports are in form of package:?
I was thinking that if in the --path there is pubspec.yaml, we can extract the package name directly from there. Then the parameter could be useful and used only when the --path leads to a folder where there is no pubspec.yaml.

The original assumption was that most projects use the lint https://dart.dev/tools/linter-rules/prefer_relative_imports
So, this parameter is needed for very rare set of projects.
What you suggested makes sense, but feels as something that is easily breakable by updated format of pubspec.yaml in future versions of dart/flutter.
But may be I am wrong. Feel free to put together PR that implements it. I will review and merge it :)

We use lint collection lint, which is quite popular, especially for being so strict, and there is used the exact opposite, i.e. always_use_package_imports. To be honest, I don't have any strong preference, but I like how lint package is curated, so I stick to most of its rules and I would say most of the lint users do the same.
So, I would say this is not only for some rare projects. However, I'm also not fond of linking directly to pubspec.yaml notation, but I don't know any other way. If you aren't against it or have a better solution, I would create a PR in the coming weeks once I have time for that.

Thank you for explaining. Sure, feel free to go ahead with the PR. I will review it.

Implemented.
Thank you @martingeorgiu

Did you push/publish it @polina-c? I can't find it anywhere

Oh, i mixed it with something else. Reopening. Thanks for the catch.🌤


internal-BE/faster-import

Phases
MP
MM
MB
MR
JM
Total

ETA
0
0
0
0
0
0

Developing
3
0
0
0
0
0

Review
0
0
0
0
0
0

Total
-
-
-
-
-
0

ETA est.

0

ETA cust.
-
-
-
-
-
0

Problem description
Try to make the import faster.
Analysis
Save values from dictionaries into jasons. Than you have the full database and mapping in jsons and the second run can be faster.

The changes in this issue are from https://github.com/dataquest-dev/DSpace/issues/243 and https://github.com/dataquest-dev/DSpace/issues/238.


Make image format detection and SvgImageFile initialisation more robust

https://pastebin.com/jNWdCZ2N
File "/usr/local/lib/python3.8/site-packages/willow/image.py", line 313, in __init__
cms-app-6b79f8884b-tmjzb cms-app     self.dom = ElementTree.parse(f)
cms-app-6b79f8884b-tmjzb cms-app   File "/usr/local/lib/python3.8/site-packages/defusedxml/ElementTree.py", line 130, in parse
cms-app-6b79f8884b-tmjzb cms-app     return _parse(source, parser)
cms-app-6b79f8884b-tmjzb cms-app   File "/usr/local/lib/python3.8/xml/etree/ElementTree.py", line 1202, in parse
cms-app-6b79f8884b-tmjzb cms-app     tree.parse(source, parser)
cms-app-6b79f8884b-tmjzb cms-app   File "/usr/local/lib/python3.8/xml/etree/ElementTree.py", line 601, in parse
cms-app-6b79f8884b-tmjzb cms-app     parser.feed(data)
cms-app-6b79f8884b-tmjzb cms-app   File "/usr/local/lib/python3.8/xml/etree/ElementTree.py",

Update: the issue seems to be with https://github.com/wagtail/Willow/blob/830aa3d386fd2ef2aa48c8032ba7d62bf2e04fc1/willow/image.py#L82-L99 (and specifically https://github.com/wagtail/Willow/blob/830aa3d386fd2ef2aa48c8032ba7d62bf2e04fc1/willow/image.py#L86-L87) where the user is uploading a PNG (allegedly)

@zerolab It would be helpful to have an image file that causes this bug.

Yeah.. I have been trying.. https://wagtailcms.slack.com/archives/C81FGJR2S/p1709908265029289
I suspect they are uploading images without an extension, and then there's potentially something with the system that filetype cannot determine the file so Willow thinks it may be svg-ish

OK, so finally got confirmation. It was images without an extension, so https://github.com/wagtail/Willow/blob/830aa3d386fd2ef2aa48c8032ba7d62bf2e04fc1/willow/image.py#L86-L87 is kicking in

Honestly - does it matter?
I thought he mentioned there was a file extension visible in the database.
We should probably fallback on extensions after checking the mimetype; and then try to guess if it's SVG, no? Seems like a generally good improvement to me.

We have a custom model inheriting from AbstractImage:
class Asset(AbstractImage):
    file = models.ImageField(
        verbose_name=_('file'),
        upload_to=settings.ASSET_UPLOAD_PREFIX,
        width_field='width',
        height_field='height',
        storage=MediaStorage()
    )

MediaStorage here is using django-gcloud-storage
When I upload an image I get the following error:
xml.etree.ElementTree.ParseError: not well-formed (invalid token): line 1, column 0

Which is weird as I am uploading a png or jpeg image.
After further investigation and help from Wagtail Slack channel I think the problem is arising when willow is guessing the wrong file type /extension in https://github.com/wagtail/Willow/blob/830aa3d386fd2ef2aa48c8032ba7d62bf2e04fc1/willow/image.py#L86-L87
The code blame shows that this part of the code was added last year. I am upgrading from Wagtail 4.2 to Wagtail 5, which would explain why it never occurred before.
When I run the following:
import filetype
from wagtail.images import get_image_model

Image = get_image_model()

image = Image.objects.get(file="dev/chair-unsplash.jpg")
with image.open_file() as image_file:
    ext = filetype.guess_extension(image_file)
    print(f"Image {image.pk} {image.file} has extension {ext}")

I get Image 149277 dev/chair-unsplash.jpg has extension None
My guess is that it is unable to guess the correct file type for the BLOB when opening a file from gcloud storage.

I still get the issue even if the extension column in DB is jpeg. The file itself has the extension as well.

Hi, I am doing some more investigation and here's my findings
In [4]: image = Image.objects.get(file="cms-dev/chair-unsplash_TAJSD0d.jpg")

In [5]: image.file
Out[5]: <ImageFieldFile: cms-dev/chair-unsplash_TAJSD0d.jpg>

When I try to get the path I get unimplemented error, which is understandable as it is being read from Gcloud into a temp fle:
In [11]: image.file.path
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
Cell In[11], line 1
----> 1 image.file.path

File /usr/local/lib/python3.10/site-packages/django/db/models/fields/files.py:59, in FieldFile.path(self)
     56 @property
     57 def path(self):
     58     self._require_file()
---> 59     return self.storage.path(self.name)

File /usr/local/lib/python3.10/site-packages/django/core/files/storage.py:128, in Storage.path(self, name)
    122 def path(self, name):
    123     """
    124     Return a local filesystem path where the file can be retrieved using
    125     Python's built-in open() function. Storage systems that can't be
    126     accessed using open() should *not* implement this method.
    127     """
--> 128     raise NotImplementedError("This backend doesn't support absolute paths.")

NotImplementedError: This backend doesn't support absolute paths.

When using the open_file method I get the extension is None:

In [21]: with image.open_file() as image_file:
    ...:     ext = filetype.guess_extension(image_file)
    ...:     print(f"Image {image.pk} {image.file} has extension {ext}")
    ...:
[24/Mar/2024 11:28:35] | urllib3.connectionpool._get_conn:292 | DEBUG | Resetting dropped connection: storage.googleapis.com
[24/Mar/2024 11:28:35] | urllib3.connectionpool._make_request:549 | DEBUG | https://storage.googleapis.com:443 "GET /storage/v1/b/staging/o/cms-dev%2Fchair-unsplash_TAJSD0d.jpg?projection=noAcl&prettyPrint=false HTTP/1.1" 200 839
[24/Mar/2024 11:28:36] | urllib3.connectionpool._make_request:549 | DEBUG | https://storage.googleapis.com:443 "GET /download/storage/v1/b/staging/o/cms-dev%2Fchair-unsplash_TAJSD0d.jpg?generation=1710246298001500&alt=media HTTP/1.1" 200 323686
Image 149277 cms-dev/chair-unsplash_TAJSD0d.jpg has extension None

When I open it using default_storage.open  method I am getting the extension correctly:

In [22]: with default_storage.open(image.file.name, 'rb') as file:
    ...:     extension = filetype.guess_extension(file.read())
    ...:     print(f"Image {image.pk} {image.file} has extension {extension}")
    ...:
[24/Mar/2024 11:32:10] | urllib3.connectionpool._get_conn:292 | DEBUG | Resetting dropped connection: storage.googleapis.com
[24/Mar/2024 11:32:11] | urllib3.connectionpool._make_request:549 | DEBUG | https://storage.googleapis.com:443 "GET /storage/v1/b/staging/o/cms-dev%2Fchair-unsplash_TAJSD0d.jpg?projection=noAcl&prettyPrint=false HTTP/1.1" 200 839
[24/Mar/2024 11:32:11] | urllib3.connectionpool._make_request:549 | DEBUG | https://storage.googleapis.com:443 "GET /download/storage/v1/b/staging/o/cms-dev%2Fchair-unsplash_TAJSD0d.jpg?generation=1710246298001500&alt=media HTTP/1.1" 200 323686
Image 149277 cms-dev/chair-unsplash_TAJSD0d.jpg has extension jpg

I also get the extension if I do the following:

storage = image.file.storage

with storage.open(image.file.name, 'rb') as file:
    extension = filetype.guess_extension(file.read())
    print(f"Image {image.pk} {image.file} has extension {extension}")

# Image 149277 cms-dev/chair-unsplash_TAJSD0d.jpg has extension jpg

Does that mean that the open_file method is not reading the file correctly?

Just an update, I was able to solve the issue by making changes to the storage class. The package I was using was downloading the image file from Gcloud and using a SpooledTemporaryFile to store it temporarily. See the code.
I changed it o use a NamedTemporaryFile and willow's open_file method started to read the mime type correctly.
May be someone can add compatibility in Willow for SpooledTemporaryFile.
But thanks for all your time and help. Really appreciate it.


Workspace = JobWorkspace.All result in error on DevOps Pipeline

In my Pipeline Definition under a Job i define
Workspace = JobWorkspace.All
In my yml filel this gets translated to:
workspace: All
with this added my pipeline in Azure DevOps fails.
If i look at the documentation from Microsoft:
https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/workspace?view=azure-pipelines
The correct output should be:
workspace:   clean: all

Hi, thanks for reporting this. It should be an easy fix. I will have a look at it soon.

@MichielNL83 you can bump Sharpliner to 1.5.16 which has the fix


Problems about ablation experiments and Oracle

Thanks for your great paper! I have some questions about the paper.
1.What does Oracle actually mean? Is it an existing detector or something else? I cannot find any paper about it.
2.Row 4 of ablation experiments(Table 4) shows that only ALU can have a good effect on experiments. How it works without contrastive clustering?

Hi @moyoung1996, thank you for your kind words.

What does Oracle actually mean? Is it an existing detector or something else? I cannot find any paper about it.

As mentioned in Sec 5.3: "An ‘Oracle’ detector has access to all known and unknown labels at any point, and serves as a reference."

Row 4 of ablation experiments(Table 4) shows that only ALU can have a good effect on experiments. How it works without contrastive clustering?

The RPN proposals are auto-labelled based on the objectness measure. Please find more info in Sec 4.2. Contrastive clustering is not a pre-req for ALU.


[Keras] Map and reduce functions.

Does MXNET support higher order map-reduce kind of functions(map, foldl, foldr), like described below in TensorFlow
https://www.tensorflow.org/versions/r0.11/api_docs/python/functional_ops.html
Theno has similar functionality described here
http://deeplearning.net/software/theano/library/scan.html
If yes, any pointers on where to look is appreciated,
if not, any pointers on how to get started implementing them would be helpful. -Thanks.

what function are you trying to implement?
MXNet has a different programming model. Graphs are static and loops are done imperatively by calling executor.forward()/backward() and call imperative apis on the result

@piiswrong let me come up with the exact code and functions I need. I will get back to you.

@piiswrong is there a way in MXNET to implement element-wise version of java/C++ ternary operator ?
x = a <= p ? 1 : 0;
To give you a specific example I am looking to implement random_binomial function using the available random_uniform function on the same lines as tensor_flow implementation (search for random_binomial). In TensorFlow we can achieve such an operation using tf.select operator

In some sense I am in a similar boat as @jsusskin in #1394. I am unable to find some of the aggregation operations(mean, std, prod, any, argmax, argmin) expecially per axis based ones. I understand there might be some indirect way of achieving them. But I think it would be clean to provide them in the API so that end-users do not have to reinvent them. I can help out with implementing them but just want to make sure I didn't miss something or if there is already an ongoing effort for it.

We have sum and max argmax in nnvm branch
We don't have binary compare ops but it's very easy to add those in src
operator tensor binary broadcast op
Shiv Gowda<EMAIL_ADDRESS>周六下午5:06写道：

In some sense I am in a similar boat as @jsusskin
https://github.com/jsusskin in #1394
https://github.com/dmlc/mxnet/issues/1394. I am unable to find some of
the aggregation operations(mean, std, prod, any, argmax, argmin) expecially
per axis based ones. I understand there might be some indirect way of
achieving them. But I think it would be clean to provide them in the API so
that end-users do not have to reinvent them. I can help out with
implementing them but just want to make sure I didn't miss something or if
there is already an ongoing effort for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/mxnet/issues/4162#issuecomment-266253681, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudNz_0_l3FExuGuPpRxYZWyQYQWOjks5rG0yagaJpZM4LIO7l
.

OK, Thanks for the confirmation. I think implementing one of the compare ops might be a good starting point for me, I will work on it. Any idea on the timeline of the merge of NNVM branch to the master?

We just need more testing hopefully some time this month
Shiv Gowda<EMAIL_ADDRESS>周六下午7:28写道：

OK, Thanks for the confirmation. I think implementing one of the compare
ops might be a good starting point for me, I will work on it. Any idea on
the timeline of the merge of NNVM branch to the master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/mxnet/issues/4162#issuecomment-266258332, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudNqaBc3EUvqbDeHB-926Z4Uk75lgks5rG23fgaJpZM4LIO7l
.

@piiswrong I have a pull request for the comparison operators #4182, please review when you get a chance.

@piiswrong is anybody pursuing Theano's Scan operator equivalent, is it in the pipeline or is there an equivalent existing mechanism?

We talked about it. It would be equivalent to a subgraph loop in mxnet. I don't think anyone is working on it now since you can do the same thing with imperative api.
We can have it just to make conversion from theano easier but I think scan was designed to workaround theano's limitations (lack of imerative api) and in the long term people should change the way they think and use imperative api instead

Actually I think you can easily simulate it with custom op

Thanks for the quickly reply. Let me chew on that.

for example, for rnn we use bucketing instead of scan. basically you create a graph for each k (length of sequence) and they share memory with each other. Then you just pick the one with the right length instead of looping inside a graph

@piiswrong I see that MXSymbolGrad is not yet implemented in NNVM branch. Is it in the works?

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


[BUG] Can't use html entities in input label

Describe the bug
The value of label argument in input group is encoded while it is output. This creates a situation where we can't use html entities as they too are encoded in the output.
@php($val = "a < b")
<x-adminlte-input name="rank" label=" "/>
<x-adminlte-input name="max" label="{{$val}}"/>

should generate

a < b

but generates
&nbsp;
a &lt; b

Similar bugs
The same problem of double encoding occurs in title of Alert and Card and maybe a few other components as well. Eg.
<x-adminlte-card title="Hello World"/>

In my opinion, it is safe to assume that the value of any attribute is already encoded, so should be output unescaped using {!! !!} instead of {{ }}
Environment
Complete the next environment information.

Item
Version

Laravel
v8.49.2

Project
v3.6.1

OS
10.15.7

Hi @adwiv , to get

a < b

you can try with next ones:
@php($val1 = " ")
@php($val2 = "a < b")
<x-adminlte-input name="rank" :label="$val1"/>
<x-adminlte-input name="max" :label="$val2"/>

I will check this in the future. Currently I can't find any official documentation about {!! !!} usage on the components, and I want to be sure it does not introduce any security issue.

@adwiv Have you tested the previous code. Can we close this one or we still need a fix?

@Shidersz The suggested code doesn't seem to solve the issue. The labels are still encoded. Have you tested it?

My use case is very simple (and maybe common).
<form class="d-flex">
  <x-adminlte-input name="name" label="Name"/>
  <x-adminlte-input name="email" label="Email"/>
  <x-adminlte-input name="action" type="submit" label=" "/>
</form>

The   in label is important to align the submit button property.
I can understand how its difficult to fix given that the label value may either be passed as a variable or specified in the view file and to be on the safe side we should always reencode.
If you have any solution for above, it would be great. Else we can close the issue as 'wontfix'.

@adwiv I haven't understand your goal, since you write:

should generate

a < b

I believed you wanted the text that represents the html entity as output, not the rendered html entity.
We can leave this open, in case we found an elegant solution on the future. Currently, you may try using the component attributes (fgroup-class, igroup-class) to add extra classes for align the elements...


Profile page error

Describe the bug
When I open my profile I get an error
./components/collective-page/images/ContributorsGridBackground.svg
Module parse failed: Unexpected token (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> <svg width="1718" height="1450" viewBox="0 0 1718 1450" fill="none"
|   xmlns="http://www.w3.org/2000/svg">
|   <g opacity="0.64">

To Reproduce
Steps to reproduce the behavior:

npm run dev
Go to http://localhost:3000/
Click on avatar
Click "View Profile" button
See error

Expected behavior
I want to see my profile
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS] Windows 10 Pro 19044.2486
Browser [e.g. chrome, safari] Google Chrome
Version [e.g. 22]  109.0.5414.74

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

Triage Template (core team only)
This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:
P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact
Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.
High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

That's a known issue (https://github.com/opencollective/opencollective/issues/5836), but this one has better documentation. Thanks, @NikitaKorevo!


Feature: TypeScript Definitions

Hello,
I'm using TypeScript with this component and I didn't find any typings on the official repo. Would it be possible to create them?
Thanks in advance,
Pete.

Hi @petrmanek,
I don't plan to support TypeScript. I don't know the ecosystem, however one can use a JavaScript sourced library in TypeScript environment. Did you look into that?


[Error] failed to review

I'm getting unexpected results when I try to compile my tests locally
My test environment is Win10, set the environment variable openmp to use 8 cores
Compiled akochan with msys2 and mjai-reviewer with rust
Copy the compilation result of akochan to the release directory, and copy the tactics.json to the akochan directory
The sample in test is used for testing, but the following results are given
$ ./mjai-reviewer -e akochan -i log.json -a 3
02:10:14.576913 src\main.rs:258 converting to mjai events...
02:10:14.577033 src\main.rs:293 players: Aさん, Bさん, Cさん, Dさん
02:10:14.577049 src\main.rs:294 target: Dさん (3)
02:10:14.624658 src\review\akochan.rs:221 reviewing kyoku 0 honba 0 junme 0 (3.16%)
Assertion failed: false, file ../share/include.cpp, line 6
Error: failed to review
Caused by:
0: failed to parse JSON output of engine
1: expected ident at line 1 column 2
Would you tell me if I made a mistake in the process?
Looking forward to your help
Thanks for the project, it makes sense for summarizing mistakes

Try with -v

This is the result of the test
PS C:\mjai-reviewer\target\release> .\mjai-reviewer -e akochan -i log.json -a 3 -v
03:02:23.610573 src\main.rs:258 converting to mjai events...
03:02:23.611774 src\main.rs:293 players: Aさん, Bさん, Cさん, Dさん
03:02:23.612480 src\main.rs:294 target: Dさん (3)
03:02:23.613566 src\review\akochan.rs:108       $ cd "C:\mjai-reviewer\target\release\akochan"
03:02:23.617374 src\review\akochan.rs:109       $ "C:\mjai-reviewer\target\release\akochan\system.exe" "pipe_detailed" "C:\mjai-reviewer\target\release\akochan\tactics.json" "3"
03:02:23.667487 src\review\akochan.rs:151       > {"type":"start_game","names":["Aさん","Bさん","Cさん","Dさん"],"kyoku_first":4,"aka_flag":true}
03:02:23.668488 src\review\akochan.rs:151       > {"type":"start_kyoku","bakaze":"E","dora_marker":"3s","kyoku":1,"honba":0,"kyotaku":0,"oya":0,"scores":[25000,25000,25000,25000],"tehais":[["3m","3m","7m","1p","4p","5p","1s","2s","3s","3s","6s","S","N"],["2m","9m","9m","1p","5p","6p","8p","E","S","W","W","F","C"],["3m","5m","5mr","7m","6p","2s","5s","5sr","8s","E","E","W","P"],["2m","6m","1p","3p","3p","4p","7p","7p","4s","6s","6s","7s","P"]]}
03:02:23.669234 src\review\akochan.rs:151       > {"type":"tsumo","actor":0,"pai":"S"}
03:02:23.670376 src\review\akochan.rs:151       > {"type":"dahai","actor":0,"pai":"N","tsumogiri":false}
03:02:23.671131 src\review\akochan.rs:221       reviewing kyoku 0 honba 0 junme 0 (3.16%)
A03:02:23.677528s ssrc\review\akochan.rse:r240t i< otactics input_json base error!n
Error: ffailed to reviewa
Caused by:i
l e d :  0f: afailed to parse JSON output of enginel
s e ,   f1i: lexpected idente at line  1. column .2/
share/include.cpp, line 6

I tried to recompile boost and akochan and mjai-reviewer after setting openmp 8 in terminal, but still get the same result
W10LTSC@DESKTOP-RUKESU1 MINGW64 ~
$ export OMP_NUM_THREADS=8
W10LTSC@DESKTOP-RUKESU1 MINGW64 ~
$ cd C:/mjai-reviewer/target/release
W10LTSC@DESKTOP-RUKESU1 MINGW64 /c/mjai-reviewer/target/release
$ ./mjai-reviewer -e akochan -i log.json -a 3 -v
04:07:00.289702 src\main.rs:258 converting to mjai events...
04:07:00.290000 src\main.rs:293 players: リクヒロ, 秀吉是个宅, 00XYZ00, Acha
04:07:00.290018 src\main.rs:294 target: Acha (3)
04:07:00.290216 src\review\akochan.rs:108       $ cd "C:\mjai-reviewer\target\release\akochan"
04:07:00.290304 src\review\akochan.rs:109       $ "C:\mjai-reviewer\target\release\akochan\system.exe" "pipe_detailed" "C:\mjai-reviewer\target\release\akochan\tactics.json" "3"
04:07:00.335413 src\review\akochan.rs:151       > {"type":"start_game","names":["リクヒロ","秀吉是个宅","00XYZ00","Acha"],"kyoku_first":0,"aka_flag":true}
04:07:00.335473 src\review\akochan.rs:151       > {"type":"start_kyoku","bakaze":"E","dora_marker":"3m","kyoku":1,"honba":0,"kyotaku":0,"oya":0,"scores":[25000,25000,25000,25000],"tehais":[["7m","9m","4p","6p","6p","6p","7p","7p","1s","2s","9s","E","P"],["4m","5mr","1p","4p","5p","8p","9p","1s","3s","7s","8s","C","C"],["2m","7m","2p","4p","8p","9p","9p","3s","5sr","5s","7s","7s","8s"],["3m","6m","9m","5pr","5p","7p","1s","5s","6s","S","N","F","F"]]}
04:07:00.335495 src\review\akochan.rs:151       > {"type":"tsumo","actor":0,"pai":"C"}
04:07:00.335513 src\review\akochan.rs:151       > {"type":"dahai","actor":0,"pai":"9s","tsumogiri":false}
04:07:00.335525 src\review\akochan.rs:221       reviewing kyoku 0 honba 0 junme 0 (0.38%)
Assertion failed: false, file ../share/include04:07:00.345030.cpp src\review\akochan.rs:240     < tactics input_json base error!
, line 6
Error: failed to review
Caused by:
0: failed to parse JSON output of engine
1: expected ident at line 1 column 2

I found something wrong with my tactics, after the modification the situation changed
This seems to be a relatively common problem, I will try to modify it and see
04:15:30.997483 src\review\akochan.rs:240       < [{"moves": [{"actor": 3, "type": "none"}], "review": {}}]
04:15:30.997548 src\review\akochan.rs:377       review entry created: Disagree
(1/0/2, 100.000)
04:15:30.997577 src\review\akochan.rs:383       Entry { junme: 1, last_actor: 2, tile: 2m, state: State { actor: 3, tehai: Tehai { inner: [3m, 4m, 6m, 9m, 5pr, 5p, 7p, 1s, 5s, 6s, N, F, F], is_sorted: true }, fuuros: [] }, at_self_chi_pon: false, at_self_riichi: false, at_opponent_kakan: false, expected: [None], actual: [Chi { actor: 3, target: 2, pai: 2m, consumed: [3m, 4m] }, Dahai { actor: 3, pai: 9m, tsumogiri: false }], details: [DetailedAction { moves: [None], review: Detail { total_houjuu_hai_prob_now: None, total_houjuu_hai_value_now: None, pt_exp_after: None, pt_exp_total: None } }], acceptance: Disagree }
04:15:30.997794 src\review\akochan.rs:151       > {"type":"chi","actor":3,"target":2,"pai":"2m","consumed":["3m","4m"]}
04:15:30.997818 src\review\akochan.rs:151       > {"type":"dahai","actor":3,"pai":"9m","tsumogiri":false}
04:15:30.997847 src\review\akochan.rs:151       > {"type":"tsumo","actor":0,"pai":"P"}
04:15:30.997874 src\review\akochan.rs:151       > {"type":"dahai","actor":0,"pai":"2s","tsumogiri":false}
04:15:30.997888 src\review\akochan.rs:221       reviewing kyoku 0 honba 0 junme 2 (2.43%)
AError: failed to review
Caused by:
failed to read from engine: unexpected EOF

Under win10, 8 threads can be changed to 4 threads and it can work. Under win11, it has not been successful yet, but I think it can be used first.
Thank you for your help！


kubernetes example

Hi,
If someone had already worked on it, how to enable the plugin and then write the rule when deploying traefik on kubernetes.
Thanks in advance

Hi @isshwar,
Thanks for your interest in this Traefik Plugin!
As per this>install this Plugin:
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
    name: my-htransformation
    namespace: my-namespace
spec:
    plugin:
        htransformation:
            Rules:
                - Header: X-Traefik-*
                  Name: Header transformation
                  Type: Rename
                  Value: X-custom
                - Header: NewHeader
                  Name: Header addition
                  Type: Set
                  Value: "True"
                - Header: Cache-Control
                  Name: Header deletion
                  Type: Del
                - Header: Accept-Language
                  Name: Header join
                  Sep: ', '
                  Type: Join
                  Values:
                    - Foo
                    - Bar


eslint failing on master branch

Context (Environment)
Linux Mint 19.3
Kernel 5.3.0-51-generic
npm -version
6.14.5
node -v
v14.0.0
Expected Behavior
npm run lint runs, and no errors experienced
Actual Behavior
The following behavior is experienced

library/server/formatter.js
86:46  error  Parsing error: Invalid regular expression: /(?<=#heading=)([^/]+)/: Invalid group

Possible Solution
This error is due the compatibility of what's called a "positive look behind" in regular expression land... The best way to explain what's happening here is by example:
decoded = "#heading=test"
decoded.match(/(?<=#heading=)([^/]+)/i)

returns: test,test

decoded = "#heading=test"
value = decoded.match(/#heading=([^/]+)/i))

returns: #heading=test,test

The first index value is a match for the regular expression in its entirety, while the second is a match for the group, identified by the final set of "( )" in our examples. We should be able to use my example regular expression, and do something like if (!= null): return array[size-1], rather than using the positive look behind

Closed via #157


Consistency update for TOCs of manual instrumentation pages

Another consistency update for the manual instrumentation pages. After this PR gets merged:

all languages more or less have the same structure:Setup
Traces
Metrics
Logs
...
Next Steps

if a signal is not yet stable or documentation is missing, this is called out in place. if the signal is stable, readers are asked to contribute
Moved the section about OTLP Exporter for erlang to a separate page to follow the structure of other languages
Some other structural updates to create consistency

Overall LGTM, just wondering why some files don't have a top-level Setup section? e.g., .NET

That's a task for another update. I added some where possible, but that might need some extra work to create this consistently.

Sounds good!


chore: add shadcn

Problem solved
Short description of the bug fixed or feature added
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address:

PR-Codex overview
This PR adds new features and refactors existing code in the wallet-ui app.
Detailed summary

Added remote image patterns in next.config.mjs
Updated client creation in client.ts
Implemented nameToChainId function in simplehash.ts
Refactored layout in login/layout.tsx
Added Erc721 type in erc721.ts
Updated Providers component in Providers.tsx
Added Badge component in ui/badge.tsx
Added Input component in ui/input.tsx
Implemented getErc721Tokens in erc721.ts
Added NftCard component in NftCard.tsx
Updated tailwind.config.ts
Added Layout function in wallet/[address]/layout.tsx
Added Popover components in ui/popover.tsx

The following files were skipped due to too many changes: apps/wallet-ui/src/app/[ecosystem]/(ui)/wallet/[address]/page.tsx, apps/wallet-ui/src/components/ui/button.tsx, apps/wallet-ui/src/components/ChainCombobox.tsx, apps/wallet-ui/src/app/globals.css, apps/wallet-ui/src/components/ui/dialog.tsx, apps/wallet-ui/src/components/ui/command.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3511  👈
#3498 : 1 other dependent PR (#3499 )
#3478
#3477
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on  Graphite


Nicholas Lee Bateman All my Cards And App on account And locked out windows please help

I don't think this issue is related to this repo, if I am missing something here, please let me know.


Encoding of JSON results

Is there any way to set the encoding of return results from Web API controllers?
Right now I'm having some trouble with åäö in my JSON result, the client side expects utf-8. My guess is that the encoding is set to iso-8859-1 per default?
Regards!

With JsonResult the encoding set on the ContentType property will be honored for the response.
When using content negotiation you can configure the set of supported encodings on the JsonOutputFormatter.


Dev to master merge for versioning

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

493 of 493 (100.0%)  changed or added relevant lines in 20 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
965

Relevant Lines:
965

💛  - Coveralls


Rancher v2.5.5 Apps & Marketplace charts not working with k3s 1.20.2+k3s1 clusters

kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2+k3s1", GitCommit:"1d4adb0301b9a63ceec8cabb11b309e061f43d5f", GitTreeState:"clean", BuildDate:"2021-01-14T23:52:37Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2+k3s1", GitCommit:"1d4adb0301b9a63ceec8cabb11b309e061f43d5f", GitTreeState:"clean", BuildDate:"2021-01-14T23:52:37Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Going to https://rancher-REDACTED:8443/dashboard/c/c-lmwqg/apps/charts
Charts /  Deploy Chart
All Categories
It only shows "There are no charts available, have you added any repos?"
Installed Apps tab shows State: Unknown | fleet-agent
Chart Repositories tab shows
State: Unknown | Partners ...
State: Unknown | Rancher ...

This stuff all works for "local" cluster still, v1.18.12+rke2r2
Worked for k3s clusters v1.19.5+k3s2, which I will move back to

2.5.5 does not support 1.20.  https://github.com/rancher/rancher/issues/30556


fix: add animation delay

Marquee is not playing on FireFox unless window is resized or reduced motion is toggled.
Adding an animation delay fixes this issue.

Looks good to me @chanroyc 🎉
Couple small things:

can we please add a comment in the CSS explaining why we're adding this delay?
let's bump the patch version before merging. npm version patch should do the trick.

Thanks @andrewrubin ! I'll leave a comment in the css and bump the patch version now.


v1.2 backports 2019-02-10

PRs:

#6978
#6936

This change is

test-me-please

test-docs-please

test-missed-k8s


Implement View class

Constructor

Screen size;
background image;

Draw

vertices — C array of vertices (for OpenGL drawing functions);
triangles — C array of triangles (for OpenGL drawing functions); init this static?
rotation — rotations of the model by axes;
position — position of the model.

Close

Done in https://github.com/char-lie/mfm/pull/11


Add more advanced docs and testing

[ ] How to do different roll-over strategies for licensing
[ ] Ingress, examples, etc.
[ ] Config practices, string overrides, etc.
[ ] Note about default callback URL for RStudio Workbench...

It would be nice if there was an example for package manager


Thorough testing of SocketIO send/receive message events

Describe the task that needs to be done.
(If this issue is about a bug, please describe the problem and steps to reproduce the issue. You can also include screenshots of any stack traces, or any other supporting images).
#72 was not able to be properly tested as the front-end code was not implemented at the time of creating this issue. Make sure it works properly.
Describe how a solution to your proposed task might look like (and any alternatives considered).
Manual testing and verification
Notes
Relates to #44

Manual testing and verification is already done with frontend when chat page is setup. Would be interesting if we could get integration testing setup in the java backend with socket io. Thoughts on refactoring the issue?

The purpose of this issue was to ensure the current implementation works. It clearly does so I'm of the opinion that we close this off and create a new issue for integration testing.

Cool, make sure you

Update the wiki (future work)
remove this issue from Future issues to Projects
Add issue to Future issues


style: FilterSelect style tweaks

After

Before

Added a couple suggestions using the theme variables instead of the hard-coded 12px. Otherwise, simple enough :) 👍

Added some suggestions in a branch off of your branch., and opened a PR on the fork for your consideration.

Codecov Report

Merging #10446 into master will decrease coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10446      +/-   ##
==========================================
- Coverage   70.25%   69.85%   -0.40%
==========================================
  Files         605      196     -409
  Lines       32377    19079   -13298
  Branches     3271        0    -3271
==========================================
- Hits        22745    13327    -9418
+ Misses       9522     5752    -3770
+ Partials      110        0     -110

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
69.85% <ø> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/views/database/mixins.py
59.64% <0.00%> (-21.06%)
:arrow_down:

superset/db_engine_specs/mysql.py
78.72% <0.00%> (-12.77%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.36% <0.00%> (-2.64%)
:arrow_down:

superset/databases/api.py
84.61% <0.00%> (-2.57%)
:arrow_down:

superset/models/core.py
85.27% <0.00%> (-1.95%)
:arrow_down:

superset/views/database/views.py
61.32% <0.00%> (-1.66%)
:arrow_down:

superset/jinja_context.py
80.00% <0.00%> (-0.96%)
:arrow_down:

superset/db_engine_specs/base.py
84.26% <0.00%> (-0.29%)
:arrow_down:

superset/views/core.py
74.33% <0.00%> (-0.25%)
:arrow_down:

... and 420 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f56cd5...364e17b. Read the comment docs.

shakes fist at Cypress CI process

Impacts #8976


Use a platform independent path to LLVM_EXTERNAL_LIT.

Should fix the Windows post-submit error in #12256.

Verified locally that this fixes the windows issue.


Definitions of static or macro-defined arrays are not emitted

Input C Header
#define MACRO_ARRAY {1, 2}

static const int static_const_array[] = {3, 4};

Bindgen Invocation
$ bindgen input.h

Actual Results
extern "C" {
    #[link_name = "\u{1}static_const_array"]
    pub static mut static_const_array: [::std::os::raw::c_int; 2usize];
}

(The presence of the mut is #511, it's not the point of this issue but I'm just noting that that's a separate incorrect thing here.)
Expected Results
As it is, neither array can be used with bindgen alone. MACRO_ARRAY is not emitted and attempting to use static_const_array will result in a link error, because there is no definition, only a declaration.
I was hoping to see at least:
static static_const_array: [::std::os::raw::c_int; 2usize] = [3, 4];

And ideally:
// Inferred as c_int based on the types of 1 and 2
static MACRO_ARRAY: [::std::os::raw::c_int; 2usize] = [1, 2];

static static_const_array: [::std::os::raw::c_int; 2usize] = [3, 4];

I figure that cases like MACRO_ARRAY are difficult in general, relating to issues like #316. But if at least the static_const_array case would work, it could be used as a simple workaround for the macro support.
Workaround
As it is, one has to write and compile some C (typically involving the cc crate) that provides a symbol to hold the array value, and in the non-macro case a way of initializing it because C can't do it at compile time. For example:
#include <string.h>
#define MACRO_ARRAY {1, 2}
static const int static_const_array[] = {3, 4};

const int my_macro_array[] = MACRO_ARRAY;

int my_static_const_array[sizeof(static_const_array) / sizeof(static_const_array[0])];
void my_static_const_array_init(void) {
   memcpy(my_static_const_array, static_const_array, sizeof static_const_array);
}

And then in the bindgen stub declare e.g.:
const int my_macro_array[sizeof((int[])MACRO_ARRAY) / sizeof(int)] = MACRO_ARRAY;

extern int my_static_const_array[sizeof(static_const_array) / sizeof(static_const_array[0])];
extern void my_static_const_array_init(void);

And finally, arrange a way of calling my_static_const_array_init when needed.
Needless to say, this is quite painful. :-) I'm open to better approaches, this is just the most straightforward thing off the top of my head.

The clang constant evaluation stuff doesn't work for arrays at all afaict, so this would need upstream changes to libclang to be fixable.

You're right. I filed it upstream: https://bugs.llvm.org/show_bug.cgi?id=36576
Otherwise, I suppose #297 would provide a fix, but it's a bigger undertaking.


Monadic for

Completely re-worked for-comp from work by Alex Piggott. For-comps can now be generated for things other than streams

@Alex-At-Home here's the final implementation. I had to make some specific changes. With StreamFor filter() is required as once you start processing a stream you can't add more or you get an exception. So MonadicForImpl now has 2 methods for yielding depending on whether or not fitler() is available. Halva's original For now uses a generated StreamFor internally.

@Alex-At-Home have a look at https://github.com/Randgalt/halva/blob/9fa3179a3ff955fdfbe39592e1354b09c3ccb633/halva-test/src/test/java/com/company/FutureForFactory.java to see how the class generator works.

Nice! And the generated class is the same as before. That's awesome. What about the multi type case?
(ps Yeah I hadn't gotten around to testing filter, sorry about that!)

What about the multi type case?

I need to test that - I'll do that next.

@Alex-At-Home fyi - I tried it with your FP example Writer and it worked perfectly.

merged


Cesium error

Sandcastle example:
Browser:
Operating System:
getting  Cesium error on 3d flight 24 on firefox as well,opera is fine

I'm closing this issue due to incomplete info. If you believe this is still an issue, please feel free to re-open with a more detailed description.
For example, please include a Sandcastle example that replicates the issue.
Thanks!


3 to 4

➡ Forward port
Port ign-gazebo3 to ign-gazebo4
Branch comparison: https://github.com/ignitionrobotics/ign-gazebo/compare/ign-gazebo4...ign-gazebo3

I had to resolve a few merge conflicts. I believe that we will also need an ign-gui4 release in order to support https://github.com/ignitionrobotics/ign-gazebo/pull/904, which is part of this forward-port.
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

It looks like macOS hasn't picked up on the new GUI release: https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/6141/consoleFull#18361520546ea37b8d-a6d4-40ae-8431-d90c018842af
However, the bottle has been built (I think): https://github.com/osrf/homebrew-simulation/pull/1541
Is there a way to verify that macOS has picked up the new GUI release?

Now that the ign-gui release is out, I have updated CMakeLists.txt to require ign-gui 4.5.0.

macOS is building now. The INTEGRATION_user_commands test failed again, but it has failed for the past 19 builds, so I don't think it's related to this PR. I'll go ahead and merge this.


Create new branch for upcoming v2 schema

Create a new branch for kyverno/policies where some (at least PSS) can be upgraded to the new v2beta1 schema.

Created v2 branch; will begin to migrate some of the policies to v2beta1.


Custom Character

how can i add this https://gt-mp.net/forum/thread/1299-custom-character-creator/ in the GM?

It will be quite hard to directly add that but at some point I have planned to make editor like that for custom characters. Now I am busy with other stuff like police, fire department, fishing etc.


fixing comparison list

Adding in spring cloud to the list and fixing order to match the document order.

@PixelRobots : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Thanks for the callout - will fix the order in the newer version (as this has write conflicts) - closing this one for now
#please-close

Thanks

n/p - just merged it in. Should publish here in the next 12-24 hours

Awesome. Thanks again.


Docker no longer installing

All of the links in the script are erroring out for me. Looks like Docker recently restructured its offerings and you're no longer able to grab the installer without an account.
This one should probably be removed from the script, unfortunately.

Do you have a log or terminal output as an example? At first glance the URLs still work in my browser.

Looks like I may have jumped the gun on this one. Not running into the 'access denied' errors I was getting yesterday when hitting the download URL's and I was able to install via Installomator this morning.


await deep.delete({ type_id: await deep.id('@deep-foundation/rss-to-deep', 'Post'), order_by: { id: 'asc' }, limit: 1 });

const adminId = await deep.id('deep', 'admin');
const containTypeId = await deep.id('@deep-foundation/core', 'Contain');
const messageTypeId = await deep.id('@deep-foundation/messaging', 'Message');
const replyTypeId = await deep.id('@deep-foundation/messaging', 'Reply');
const tokensTypeId = await deep.id('@deep-foundation/tokens', 'Tokens');
await deep.delete({ from_id: adminId, type_id: containTypeId, to: { type_id: { _in: [messageTypeId,replyTypeId,tokensTypeId] } } }, limit: 1);

This code is transformed to query:
{
  "operationName": "DELETE",
  "variables": {
    "where0": {
      "from_id": {
        "_eq": 380
      },
      "type_id": {
        "_eq": 3
      },
      "to": {
        "type_id": {
          "_in": [
            1361,
            1363,
            1393
          ]
        }
      }
    }
  },
  "query": "mutation DELETE($where0: links_bool_exp!) {
    m0: delete_links(where: $where0) {
      returning {
        id
      __typename
    }
    __typename
  }
}"
}

But it does not use limit.
We need support limiting of deep.delete just like with deep.select.

Well turns out it is not possible to solve until https://github.com/hasura/graphql-engine/issues/9997 is implemented.

Workaround 1
Use deep.select before deep.delete:
const adminId = await deep.id('deep', 'admin');
const containTypeId = await deep.id('@deep-foundation/core', 'Contain');
const messageTypeId = await deep.id('@deep-foundation/messaging', 'Message');
const replyTypeId = await deep.id('@deep-foundation/messaging', 'Reply');
const tokensTypeId = await deep.id('@deep-foundation/tokens', 'Tokens');
const linksToDelete = await deep.select({ from_id: adminId, type_id: containTypeId, to: { type_id: { _in: [messageTypeId,replyTypeId,tokensTypeId] } }, limit: 1 });
const linksIdsToDelete = linksToDelete.data.map(link => link.id);
await deep.delete({ id: { _in: linksIdsToDelete } });

Btw, we can still use deep.select in that case inside deep.delete logic in DeepClient.


Any thought given to dependency injection for Redis client?

We really like your library but our project is already using gopkg.in/redis.v5 and it feels odd to use a different Redis client library (which maintains its own connection to Redis) when we'd like to just use the client we've got elsewhere.
Any plans for dependency injection in this regard?

I've modified your library a little to use gopkg.in/redis.v5 here, and I'd love any feedback you have. It doesn't do dependency injection for the Redis client as I suggested above.
https://github.com/iandouglas/rerate

Thanks for suggestion, dependency injection looks like a good idea.

Granted, dependency injection might be tricky unless the user's Redis client of choice implements all Redis commands properly that you utilize in this library. I'm happy to maintain my copy and I'll set a watch on your repo to see if new code gets merged in to apply bug fixes on my side as well.

I just added the Buckets interface which is the backend of rerate, so we can using builtin RedigoBuckets/RedisV5Buckets or building a custom Buckets( MySQLBuckets, InMEMBuckets, etc.)


CI: bpf-map-sync-cilium_lb4_backends_v2: map sync errors

	 Controller Status:      30/31 healthy
	   Name                                          Last success   Last error   Count   Message
	   bpf-map-sync-cilium_lb4_backends_v2           never          4s ago       4       1 map sync errors

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/1978/testReport/junit/Suite-k8s-1/21/K8sChaosTest_Connectivity_demo_application_Endpoint_can_still_connect_while_Cilium_is_not_running/
Sysdump:
e80c9b92_K8sChaosTest_Connectivity_demo_application_Endpoint_can_still_connect_while_Cilium_is_not_running.zip
cc @brb

Is https://github.com/cilium/cilium/pull/19352 striking us again? cc @borkmann

We are seeing this issue in our environment as well. Any idea what is causing this and is there a way to debug this error?
bpf-map-sync-cilium_lb4_backends_v2                               never          23s ago      31      1 map sync errors

level=debug msg="Starting periodic BPF map error resolver" file-path=/sys/fs/bpf/tc/globals/cilium_lb4_backends_v2 name=cilium_lb4_backends_v2 remaining=1 subsys=bpf
level=debug msg="BPF map error resolver completed" duration="37.753µs" file-path=/sys/fs/bpf/tc/globals/cilium_lb4_backends_v2 name=cilium_lb4_backends_v2 remaining=1 resolved=0 scanned=4 subsys=bpf
level=debug msg="Controller func execution time: 52.217µs" name=bpf-map-sync-cilium_lb4_backends_v2 subsys=controller uuid=79bbf788-b454-4fd6-ab32-39ea03d3a74c
level=debug msg="Controller run failed" consecutiveErrors=42 error="1 map sync errors" name=bpf-map-sync-cilium_lb4_backends_v2 subsys=controller uuid=79bbf788-b454-4fd6-ab32-39ea03d3a74c
`
``

@eminaktas Can you post a sysdump for the node which has hit the sync errors?

I added the sysdump for the node here -> cilium-sysdump-20220726-120708.zip
I have just upgraded the image version to 1.12.0, I didn't see the error message. However, the 1.11.7 version has the same error message.

We're seeing this in 1.11.10 as well.
Name                      Num entries   Num errors   Cache enabled
cilium_lb4_source_range   0             0            true
cilium_ipcache            11482         0            true
cilium_lb4_backends_v2    3070          2081         true
cilium_lb4_reverse_nat    4156          0            true
cilium_policy_02008       0             0            false
cilium_policy_02981       0             0            false
cilium_lxc                2             0            true
cilium_lb4_services_v2    4127          0            true
cilium_policy_03068       0             0            false
cilium_metrics            0             0            false

  Name                                  Last success   Last error   Count   Message
  bpf-map-sync-cilium_lb4_backends_v2   never          8s ago       190     2274 map sync errors

Max size for the map is the default value of 65536
Why would we see map is full errors when the map isn't full ?
Error msg also says argument list too long. Is the error msg wrong ?

We also ran into this at Cilium 1.11.14 with Kernel 5.15.89 on Flatcar.
We mitigated the issue by rolling back to Cilium 1.11.6, but this may not be the root cause, since it only affected devices with newer kernels. After a roll back newer kernels seem to work fine.


Followup request deduplication: ignore "advanced" in payload, target_group_ids in deduplication

@nabeelre

@nabeelre I added the rest of what we talked about in this PR as well if you want to take a look before tonight's deploy.
Now I'll work on the Fritz PR.

looks good!


Refactor ConfigStorage

Config class too complex

async loading config
CRUD with async synchronization
event listening to subscribe on updates
subscribing on changes a specific properties

We have to split this class to few components
Notes

Config class may be fully async
Track changes must implement another component

Now review code and test it. Try to add new tests for config and config observer


feat: resvg wasm

Close #8
@casungo can you try it?

It looks great! Cloudflare is experiencing some issues with combining the branch and specifying a path because they don't use version 9 of pnpm for their build system. However, it builds without issues locally (it previously displayed the same error as Cloudflare, which is a good sign!). LGTM!


Tic-Toc-Toe

Tic Toc Toe is a game multiplayer build in javascript.

Thank you, but the projects here are inline with the course

elaborate more about the course please


Generate xml

I would like to merge this to master. This code encodes the <publisher_request> and <repository_response> XML files. It uses a hardcoded binary IdCert for now, but that will be fixed next week when I generate and encode a proper IdCert for this.
Also, any comments on the code here are welcome, but since I started work on another branch to handle the publication protocol PDUs based off of this, I prefer to fix things in that branch (publication-protocol).

Drop this pull request, will combine things in the other branch


part 4: allow signing with multiple TUF format

Signed-off-by: Asra Ali<EMAIL_ADDRESS>
Allow signing with multiple TUF key formats, exposing a boolean to allow for deprecated Key IDs.
Update scripts to add signatures associated to deprecated key IDs signing for root role
Simplifies code by removing the SigningAndKey struct: we use a TUF key constructor from a signature.Signer

Fixes https://github.com/sigstore/root-signing/issues/329

Summary

Release Note

Documentation

Ready for review!

On all, the PR looks good, waiting for clarification on one comment I had (I'm probably wrong, but just want to be sure).


Add spinel property and its handler to get the msg buffer counter info

This is related to PR https://github.com/openthread/openthread/pull/940.
(it should go in after the https://github.com/openthread/openthread/pull/940 is merged. Currently this PR also includes the commit from https://github.com/openthread/openthread/pull/940).

Current coverage is 72.84% (diff: 0.00%)

Merging #944 into master will increase coverage by 0.17%

@@             master       #944   diff @@
==========================================
  Files           116        118     +2
  Lines         17407      17472    +65
  Methods        2433       2450    +17
  Messages          0          0
  Branches       2116       2118     +2
==========================================
+ Hits          12650      12728    +78
+ Misses         4059       4049    -10
+ Partials        698        695     -3

Powered by Codecov. Last update 252bd7d...0e529b2

Rebased on master. It's ready for review/merge...
Also verified/tested the change along with its wpantund counterpart in https://github.com/openthread/wpantund/issues/95


Saved audio file length

Hello, I've been trying out your noise2noise denoising on jupyter notebook, and I found that the audio saved is locked to 3 seconds, even if the audio processed is more than 3 seconds long. Is there a way to control this? Thank you.

Hello @joeoct93, sorry for the late reply
Yes, we are cutting/padding audios in the datasets to 165000 numpy array length, which equates to 165000/48000 = 3.4 seconds on a 48khz sample rate.
This fixed length can be modified by setting self.max_len attribute in the SpeechDataset class.


Show numberOfMessagesVisible and numberOfMessagesNotVisible/InFlight

It would be nice if we can see the number of messages in each queue before clicking on it, because in the right side we'll only see the messages that aren't consumed yet. Wdyt?
(BTW tested the last changes and it's all good!)

That's a good point, I also thought about that, however it requires constantly polling all queues for that stats. I have concerns this would have major impacts on the usability and resource consumption.

Yeah, you're right.
Maybe we can add a fetch button to each queue and just get the numbers when clicking the button. Or even a check-box so the user can select the queues to keep fetching just for them

I still fear that the numbers are eventually consistent and need tight polling. Do you really think that provides value? What would be the use case for selection on queues to get this metrics?

I think will be very useful when we're monitoring a specific queue, so we can track the messages that are still in this queue but already in flight, like on AWS console.. For example the user implements some consumer and wants to be sure it reaches the right queue, without this option they will never see the messages on the right side because their application is consuming them before the UI

Right makes sense. Would be happy if you find time to provide a PR, otherwise i can look into it as soon as I find time 👍


add PyUp (or another dependencies checker)

PyUp.io lets you know when package dependencies are out of date or have security vulnerabilities. It automatically makes a pull request to update the package on GitHub.
On https://pyup.io/ register through GitHub, and connect your organization.

No custom settings configured
We have not detected a .pyup.yml configuration file in the root directory of your repo. You can configure the PyUp bot by creating this file.
Please take a look at the PyUp docs on how to configure the bot.
Based on our defaults, your current settings are:
Update: all
Search: True
Pin: True
Default Branch: master
Branch pre-fix: pyup-
Close PRs: True
Label PRs: False
Update hashes: True
https://pyup.io/docs/bot/config/