Problems when exporting the routes of a library

Versions
Angular CLI: 6.0.0
Node: 8.11.1
OS: win32 x64
Angular: 6.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.6.0
@angular-devkit/build-angular      0.6.0
@angular-devkit/build-ng-packagr   0.6.0
@angular-devkit/build-optimizer    0.6.0
@angular-devkit/core               0.6.0
@angular-devkit/schematics         0.6.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.0.0
@schematics/angular                0.6.0
@schematics/update                 0.6.0
ng-packagr                         3.0.0-rc.2
rxjs                               6.1.0
typescript                         2.7.2
webpack                            4.6.0

Repro steps
We have a SPA that uses a library that exports a routing. The components are loaded lazy.
Code library:
import { NgModule, ModuleWithProviders } from '@angular/core';
import { RouterModule, Routes } from '@angular/router';

const routes: Routes = [
  { path: 'screen1', loadChildren: 'lib1/screens/screen1/screen1.module#Screen1Module' },
  { path: 'screen2', loadChildren: 'lib1/screens/screen2/screen2.module#Screen2Module' }
];

const routing: ModuleWithProviders = RouterModule.forChild(routes);

@NgModule({
  imports: [],
  exports: [
    RouterModule
  ]
})
export class Lib1RoutingModule {

  // Method export routing
  public static getRoutes() {
    return routing;
  }
}

We know that there is a problem when loading modules in a lazy way when they are outside the SPA and it is necessary to use a wrapper, but in this case it applies because the components are loaded where they have been defined.
The problem we have here is different and it occurs when the application is compiled and uses routing defined in the library. It is not able to load the component because it looks for its definition in the application itself and not in the library where it is defined.
Code SPA:
import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';
import { Lib1RoutingModule } from 'lib1';
import { Comp1Component } from './comp1.component';

@NgModule({
  declarations: [
    Comp1Component,
  ],
  imports: [
   // Use routing library
    Lib1RoutingModule.getRoutes()
  ],
  providers: [],
  bootstrap: [Comp1Component],
  exports: [RouterModule]
})
export class Comp1Module {
}

Observed behavior
The error message when compiling is:
ERROR in Could not resolve module lib1/screens/screen1/screen1.module relative to /C/Environment/Angular/Angular6/repository/spa/src/app/comp1/comp1.module.ts

The module has been defined in the library but is looking for it in the SPA.
Desired behavior
Mention any other details that might be useful (optional)

Hi,
Is there any update on this issue?  me too got stuck with this issue.
It will be great if some one can help on this issue
Thanks,

Duplicate of #6373


Provide Amazon Linux 2 or non CentOS Docker Images

See original description here:
https://github.com/opendistro-for-elasticsearch/opendistro-build/issues/696
Currently only CentOS 8 images are supported:
https://github.com/opensearch-project/OpenSearch/blob/0ba0e7cc26060f964fcbf6ee45bae53b3a9941d0/buildSrc/src/main/java/org/opensearch/gradle/DockerBase.java#L39
Would Alpine Images will be possible too?

Hi @kanchev!  We're planning to support AL2 going forward :)

Moving this to opensearch-build repo.


tools for comparing models

def compare(models, sweeps, posys, tol=0.001):
    from gpkit.interactive.plot_sweep import assign_axes
    sols = [m.autosweep(sweeps, tol, verbosity=0) for m in models]

    GPCOLORS = ["#59ade4", "#FA3333"]
    posys, axes = assign_axes(sol1.bst.sweptvar, posys, None)
    for posy, ax in zip(posys, axes):
        for i, sol in enumerate(sols):
            if isinstance(posy, tuple) and len(posy) == len(sols):
                p = posy[i]
            else:
                p = posy
            color = GPCOLORS[i % len(GPCOLORS)]
            if sol._is_cost(p):  # with small tol should look like a line
                ax.fill_between(sol.sampled_at,
                                sol.cost_lb(), sol.cost_ub(),
                                facecolor=GPBLU, edgecolor=color,
                                linewidth=0.75)
            else:
                ax.plot(sol.sampled_at, sol(p), color=color)

compare([aec, fbc], {"R": (160, 300)}, ["cost", ("W_{\\rm batt}", "W_{\\rm fuel}")], tol=0.001)

test models please

retest this please


[0.1.16 rc 3] off-center avatars in chat connection indicator enabled

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #feedback.

Fixed my beta branch


Fix messy sequence of PipelineRuns

What dose this PR?

Implement a list handler for PipelineRun
Set StartTime status while reconciling PipelineRun

Why do we need it?
Please see #360
Which dose this PR fix?
Fix #360
Steps to test
Docker images for test:
johnniang/devops-apiserver:dev-v3.2.1-rc.1-d6e861a
johnniang/devops-controller:dev-v3.2.1-rc.1-d6e861a

Create a simple Pipeline
Trigger it in Jenkins dashboard
See "Run Records" in KubeSphere console

/kind bug
/milestone v3.2

/cherrypick release-3.2

/label tide/merge-method-squash


merge uproxy-networking with uproxy-lib

We've spent a bunch of time messing about with patches and things when testing changes that affect both repos, which happens quite a bit.
I would suggest moving everything in uproxy-networking into uproxy-lib. It should speed development and reduces the number of NPMs we need to maintain.

:+1:  Yeah, my experience of working in these repos is the same. Once we get to a point where we want independent re-usable freedom-modules as repos we can pull out just the relevant (independent) parts.

Keeping this open until all outstanding pull requests are copied across.

OK, all done bar for two outstanding uproxy-networking pull requests:

https://github.com/uProxy/uproxy-networking/pull/210
https://github.com/uProxy/uproxy-networking/pull/255

The second is the one I'm concerned about finishing and porting across. @mollyling, do you think you can get that done this week?

OK, just one pull request left on uproxy-networking and I'm not really sure what we want to do with it.
@mollyling I'll leave the repo there for a while (like a couple of weeks) and delete it then, up to you if you want to merge that pull request.


Google drive cache added

regarding both this PR and #195, are you actually using Dropbox and/or Drive with imageproxy, or did you add these somewhat as an exercise?  This is not the kind of service Dropbox and Drive are really designed for, and they're unlikely to provide the kind of performance you'd likely want in a production environment.  Yes, it's technically possible to do it, but unless there's a real need to add support for these, I'd rather not encourage it.

@willnorris I think my use case is very unconventional, I understand that both google drive and dropbox are not build for this kind of workloads, specially google drive where you have to search for the file first before retrieving it. But this fits my needs, using tiered caches (memory than dropbox). The reason for using these services is the fact that they are free and have a no credit card required policy.
Feel free to close the PRs, if you think this will not be very helpful for others because its a very niche case.

closing for now, but adding "plugins" label, as this should be possible with https://github.com/willnorris/imageproxy/blob/master/docs/plugin-design.md


End-Game Tablebases / Specialized Evaluation

This is probably the weakest part of the engine right now: playing well into the end-game.
Porting over Stockfish End of Game table bases would fix this, and seems pretty easy to do.

Maybe using this would be the easiest way? https://github.com/niklasf/shakmaty-syzygy


#776 - Added Android Wear features

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Extended the notification action buttons to Android Wear

Extended the notification action buttons to Android Wear

@michellarcari looks good, do you have a twitter handle?

@macdonst my twitter is somehow abandoned, but yeah, it's @michellarcari just like here! =]


Need to implement use of AWS SQS queue for DOI code

Use Amazon SQSDOIScheduler as in /Users/waltershands/Documents/UCSC/gitroot/dockstore/dockstore-webservice/src/main/java/io/dockstore/webservice/doi/SQSDOIScheduler.java for code that generates DOI
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Issue Number: DOCK-829
┆Epic: Create DOIs

Thinking might punt this until services lambda is polished.
Maybe a ticket to make sure that the failure case (i.e. a DOI is requested when zenodo is down) is handled properly would be better at this juncture.


Lucene index not  available in 2.0.11

The package is not available in repository. I tried to use back the 2.0.10 version of Lucene with 2.0.11 community server, but got errors.

Could you attach any errors you received?

The orientdb-lucene-*-dist.jar file is missing from the plugins directory  in the 2.0.11 download at http://orientdb.com/download/
In previous releases the jar file was included in the plugins directory.
This is particularly vexing because the issue
Lucene indexes are removed if lucene plugin is not installed
https://github.com/orientechnologies/orientdb/issues/3522
caused lucene indices to become inaccessible after a test upgrade.

Something went wrong during the release, however 2.0.12 fixed it.


Should Kubeflow publish and maintain TF Serving Docker Images?

Opening this issue to consider whether Kubeflow should publish and curate TF Serving Docker images.
I think there is a reasonable expectation in the community that users shouldn't have to build Docker images just to serve models: see

tensorflow/serving#513
tensorflow/serving/issues/311 (this comment

A number of folks have already publicly shared Docker images (see tensorflow/serving#513), Kubeflow has also made a Docker image publicly available based on this Dockerfile
Kubeflow's ksonnet component for serving depends on having a publicly available Docker image to prevent customers from having to build their own image.
I think what's missing is a committement to maintaining and supporting these images. I think kubeflow should try to figure out what that would mean and whether we want to take that on.
Here are some questions to consider

Which versions of TensorFlow serving would we support?
What validation/verification of images we perform?
Would we provide GPU images?
Are there other artifacts we should release? e.g. the python client libraries for TF serving?

Initial proposal

We provide a Docker image for each TensorFlow Serving minor release

Starting with the current 1.4.0 release

We only provide an image for CPU

/cc @bhack @chrisolston @rhaertel80 @lluunn@nfiedel @bhupchan@ddysher

Finally! /cc @nfiedel @bhupchan @ddysher

I hope we support centos images as well.
As a sidenote wrt to tf-serving in openshift there exists

tensorflow-serving-s2i
tensorflow-serving-gpu-s2i
The way we get the latest bits of model_server is via
tensorflow-build-s2i
I don't know how but if we can reuse some ideas here that would nice.

If we want to start with CPU image what flags want we activate? Cause generally AVX etc.. are disabled.

What's the issue with providing a GPU image?
(at the risk of sounding like a broken record, it would be nice to have the same conversation for an "official" notebook image).

@flx42 Reason for trying to limit to CPU is just trying to scope work given staffing is very scarce and CPU is probably the more common case. If you or someone else wants to take the lead on providing a GPU image for TFServing; you'd have my full support.
I think there's some basic infrastructure we need to get into place for CI/CD of images. Once we have that in place hopefully we can add images to cover more use cases.
I'll open an issue to discuss official notebook images.

So we've decided that we need to publish and maintain Docker images to have a good experience. At least until TFServing takes this on.
Lets use the uber tracking bug #64. To track actual work.


Provide FromValues methods

The idea would be to have methods to make it easier to generate sequences from values:
public static IEnumerable<T> FromValues<T>(T in1);
public static IEnumerable<T> FromValues<T>(T in1, T in2);
public static IEnumerable<T> FromValues<T>(T in1, T in2, T in3);
public static IEnumerable<T> FromValues<T>(params T[] ins);

The result would be yielding the parameters in order.
C# already provides an easy way to create arrays, but those are mutable, so they can be undesirable in certain situations.

Appreciate forking #122 into this one issue but would be best as two separate issues: one for FromValues and another for FromDelegates, as the merits of each require separate discussions.

Ack. I have split the FromDelegates as issue #151. Could you please reopen this issue? I don't seem to be able to do so since you closed it.

C# already provides an easy way to create arrays, but those are mutable, so they can be undesirable in certain situations.

Hmm…it is really worth the trouble?
var s1 = new[] { 123, 456, 789 }.AsEnumerable();
var s2 = MoreEnumerable.FromValues(123, 456, 789);

Unfortunately, AsEnumerable does not touch the passed sequence. It is only
a hint for the compiler
https://github.com/dotnet/corefx/blob/master/src/System.Linq/src/System/Linq/Enumerable.cs
Therefore the sequence is still mutable.
On 20 Feb 2016 04:00, "Atif Aziz"<EMAIL_ADDRESS>wrote:

C# already provides an easy way to create arrays, but those are mutable,
so they can be undesirable in certain situations.
Hmm…it is really worth the trouble?
var s1 = new[] { 123, 456, 789 }.AsEnumerable();var s2 = MoreEnumerable.FromValues(123, 456, 789);
—
Reply to this email directly or view it on GitHub
https://github.com/morelinq/MoreLINQ/issues/150#issuecomment-186529468.

@fsateler So the value proposition of FromValues is to guard against anyone from shooting themselves in the foot by downcasting and getting back the array or mutable container? In other words, you want a ToEnumerable (conversion) rather than an AsEnumerable (masking)? If that's the case, I would say that it has some potential downsides like all the optimizations built-into some of operators would become useless. In other words, MoreEnumerable.FromValues(123, 456, 789).Count() would become expensive. I would say that for an array, you would want to render it read-only via Array.AsReadOnly. This would make it immutable downstream, but admittedly not at the source.

So the value proposition of FromValues is to guard against anyone from shooting themselves in the foot by downcasting and getting back the array or mutable container?

That is one value. The second is that the intent of the code is more immediately apparent.

In other words, you want a ToEnumerable (conversion) rather than an AsEnumerable (masking)?

Rather than a conversion, a generator. Although one version (params T[]) would be equivalent to a ToEnumerable.

In other words, MoreEnumerable.FromValues(123, 456, 789).Count() would become expensive.

For the length of the sequences likely to be generated from such a method, this is is unlikely to be problematic.

The second is that the intent of the code is more immediately apparent.

Don't quite see how.

For the length of the sequences likely to be generated from such a method, this is unlikely to be problematic.

Fair point.
Naming-wise, MoreEnumerable.FromValues reads long & clumsy. What do you think about Seq.Create or Seq.Return?

There is now an immutable collections package, thus one can now do:
new [] { 1, 2, 3 }.ToImmutableArray();

Which makes this enhancement request partially obsolete. The only remaining value is a bit of syntactic sugar, but I don't think it is worthwhile to spend the effort.
Closing.


Ideas for improving the first run experience

Just a small idea I had, but I was thinking maybe we could make the first run experience a bit easier by prefilling the appName property in mup.json with the parent directory's name?
So if I do mup init inside /telescope, the appName would default to telescope.
And maybe app could default to . instead of /path/to/the/app?

Good idea. Rather than making it default.
Yes. this can be done.
On Wed, Mar 18, 2015 at 2:28 PM Sacha Greif<EMAIL_ADDRESS>wrote:

Just a small idea I had, but I was thinking maybe we could make the first
run experience a bit easier by prefilling the appName property in mup.json
with the parent directory's name?
So if I do mup init inside /telescope, the appName would default to
telescope.
And maybe app could default to . instead of /path/to/the/app?
—
Reply to this email directly or view it on GitHub
https://github.com/arunoda/meteor-up/issues/320.


Add git lfs content

This pull request adds Git LFS content based on the list of needed content found here: #240
❓: This content specifically introduces Git LFS for use on a specific repository as an example and does not contain the steps to add Git LFS to a new project, do we thing it would be valuable to include that information as an appendix item?

❓: This content specifically introduces Git LFS for use on a specific repository as an example and does not contain the steps to add Git LFS to a new project, do we thing it would be valuable to include that information as an appendix item?

Yes, I think this would be valuable information to have.

Fixed the template repository to use main and not master as the default branch. Merging this change into the manual.


K-NRM log1p a little different from original paper

Hi, I found the soft-TF in K-NRM is a little different from the original paper.
MatchZoo: log1p(x)
https://github.com/faneshion/MatchZoo/blob/c69cafa3d4f615f96f7d4ff058a537e1d101fa2a/matchzoo/models/knrm.py#L61
K-NRM: log(max(x, 1e-10)) * 0.01
https://github.com/AdeDZY/K-NRM/blob/fa5d60c38d894c3ef6cc7e580f60938773c3a8b3/knrm/model/model_knrm.py#L112
Is it a verified improvement?
cc: @AdeDZY

Hey, in my implementation log(max(x, 1e-10)) * 0.01 , 1e-10 is used to prevent log(0). *0.01 is used to scale down the values, otherwise it may cause problems in tanh in the next layer. In my code, without `*0.01' it sometimes does not converge.
As long as the there is no log(0) error or convergence problem, `log1p(x)'  would not make a huge difference?

log(x) and log(1+x) are quite different for very small x. I'm not sure whether log1p is better.
There are another 2 differences:

In the last Dense layer, the activation of tanh is removed.
https://github.com/faneshion/MatchZoo/blob/c69cafa3d4f615f96f7d4ff058a537e1d101fa2a/matchzoo/models/knrm.py#L72
The masking of _PAD_ for OOV and padding terms is applied differently. In the original code, it is calculated as exp(.) * mask. But here, _PAD_ is assigned to [0] * embed_size , thus it leads to exp(-0.5 * mu * mu / sigma / sigma).

I am not sure how log1p affects the results, either.
For the other two differences, I happen to have tried them in my own experiments.

Removing tanh does not hurt the performance. In some cases, it is even better.
_PAD_: when there are not too many OOV or padding terms, it is more efficient to pad the embeddings; the results won't get hurt.  The network some how learns to put these noisy words into a useless kernel.

Thank you for your precious comments. Can you give more detail about how to pad embeddings? By the way, can you help us to check the code K-NRM in MatchZoo?

For OOV and padding terms, besides having a  embedding, I also use a mask on the similarity matrix. Thus, if query term i or document term j is a OOV, their similarity score will not be considered by the kernels. In the MatchZoo version, it will be a mask on the exp_mm:
mm_exp = Kernel_layer(mu, sigma)(mm)
mm_exp = mm_exp * mask
Sure, my pleasure! Actually, I have read and run your codes. I think they are fine....
Do you want to add the Conv-KNRM implementation? I have one based on your K-NRM.

Of course we need! Thanks.


[Feature]  Question about pretrain obejct of Chatglm-6b

Is your feature request related to a problem? Please describe.
We would like to do continue pretrain on Chatglm-6B model, I was wondering whether the Chatglm-6b has the same pretrain object as in the GLM project. Since they have quite different context length. Could you please help me with this?
Solutions
Provide pretrain code of chatglm-6b if possible
Additional context
No response

Yes. The objective is the same as GLM.


add javadoc for property class fields

@yungez @xscript @aovechki
Fix #50

@ZhijunZhao,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4435124...4b3a1ba. Read the comment docs.


Make listcompactions work with external compactions

Got this working in 01ab70d3a75bf401f3f0d33159f7bd907830aa92.  Below is some sample output from the shell.  I added the C to the Server column for a compactor, not sure I like that though.
root@uno> listcompactions
 SERVER               | AGE       | TYPE  | REASON | READ  | WROTE | TABLE           | TABLET                                   | INPUT | OUTPUT                              | ITERATORS | ITERATOR OPTIONS
      C accumulo:9101 |     427ms |  FULL |   USER | 31.7K | 31.7K |       testTable | 2<;8                                     |     1 |   /2/default_tablet/A000001a.rf_tmp |        [] | {}
      C accumulo:9102 |   2s457ms |  FULL |   USER |  210K |  210K |       testTable | 2;8<                                     |     1 |        /2/t-0000016/A0000019.rf_tmp |        [] | {}
root@uno> listcompactions
 SERVER               | AGE       | TYPE  | REASON | READ  | WROTE | TABLE           | TABLET                                   | INPUT | OUTPUT                              | ITERATORS | ITERATOR OPTIONS
      C accumulo:9101 |  19s159ms |  FULL |   USER | 1.60M | 1.60M |       testTable | 2<;8                                     |     1 |   /2/default_tablet/A000001a.rf_tmp |        [] | {}
      C accumulo:9102 |  21s196ms |  FULL |   USER | 1.82M | 1.82M |       testTable | 2;8<                                     |     1 |        /2/t-0000016/A0000019.rf_tmp |        [] | {}
root@uno> listcompactions
 SERVER               | AGE       | TYPE  | REASON | READ  | WROTE | TABLE           | TABLET                                   | INPUT | OUTPUT                              | ITERATORS | ITERATOR OPTIONS
      C accumulo:9101 |  33s372ms |  FULL |   USER | 2.84M | 2.84M |       testTable | 2<;8                                     |     1 |   /2/default_tablet/A000001a.rf_tmp |        [] | {}
      C accumulo:9102 |  35s419ms |  FULL |   USER | 3.00M | 3.00M |       testTable | 2;8<                                     |     1 |        /2/t-0000016/A0000019.rf_tmp |        [] | {}

This is what an internal compaction looks like.
root@uno> listcompactions
 SERVER               | AGE       | TYPE  | REASON | READ  | WROTE | TABLE           | TABLET                                   | INPUT | OUTPUT                              | ITERATORS | ITERATOR OPTIONS
      T accumulo:9997 |  39s270ms |  FULL |   USER | 2.95M | 2.95M |       testTable | 2<;8                                     |     1 |   /2/default_tablet/A000001u.rf_tmp |        [] | {}
      T accumulo:9997 |  39s269ms |  FULL |   USER | 2.96M | 2.96M |       testTable | 2;8<                                     |     1 |        /2/t-0000016/A000001v.rf_tmp |        [] | {}

What does the C and T mean? You could leave the internal ones the way they are now and put (external) next to the external compactions.

What does the C and T mean? You could leave the internal ones the way they are now and put (external) next to the external compactions.

That seems better.  Maybe something like ext accumulo:9101

You could list them separately and replace the title SERVER with INTERNAL COMPACTION and EXTERNAL COMPACTION. Its usually pretty obvious that column is the server.

I like that information efficiency of that.  Don't like the header column just showing in the middle of data.


[AST] Retrive EndLine after StartStartLineAndColumn for SingleRawComment

Cherry-pick of https://github.com/apple/swift/pull/14733
Explanation: llvm::SourceMgr caches the line and column of the last query. For subsequent queries, It usually scans from that position. However, if the query is for a position ahead of the last query, it re-scan from the top of the whole buffer. This significally slows down the performance.
This change reorder the queries to llvm::SourceMgr so that they aligns the appearance order in the source file. This change effectively mitigate performance regression introduced in https://github.com/apple/swift/pull/11264 without functional changes.
Scope: SourceKit and ASTSerialization. Changes are localized in SingleRawComment class, no interface change.
Radar/SR: rdar://problem/37570893
Risk: Low. No API change. This change is just for utilizing cache functionality of llvm::SourceMgr
Testing: Passes all tests.
Reviewer: Not yet

@swift-ci Please test

is there maybe a way to add an assertion hit that triggers if a re-scan occurs
I don't think there's simple way to assert it.
We probably should setup some performance tests to detect regression.


Logo Design

Hi. I am a graphic designer. I volunteer to design a logo for open source projects. I can design it for you to use it in the readme file. What dou you say?

That would be awesome :) what would you need from my side?

Do you have any ideas or thought you want to design?

I would close this issue, because it doesn't represents a real software problem and keeping it open would negatively impact the resolve-time statistics.

Design wise: something with network or puzzle like would be interesting. Feel free to use your imagination. An example https://cdn.app.compendium.com/uploads/user/e7c690e8-6ff9-102a-ac6d-e4aebca50425/d7eaeb73-4b9e-4764-ad10-b5785d99d114/File/97a592b44f25ecde6c903f1485aaad17/microservices_472.jpg


couldn't install the tools

when I do pip install pytorch2keras  in my virtual environment “conda，python3.6” I got an error:
`Collecting pytorch2keras
Downloading https://files.pythonhosted.org/packages/2f/61/9fd96f62814ddf7d0a3d60db85be6965451c7d6efd8d5c52b1877db68bd3/pytorch2keras-0.1.6.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "/home/yx.wang/anaconda3/envs/py3torch2keras/lib/python3.6/site-packages/pip/_internal/download.py", line 436, in get_file_content
with open(url, 'rb') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/pip-install-zk3qnkav/pytorch2keras/setup.py", line 16, in <module>
    reqs = [str(ir.req) for ir in install_reqs]
  File "/tmp/pip-install-zk3qnkav/pytorch2keras/setup.py", line 16, in <listcomp>
    reqs = [str(ir.req) for ir in install_reqs]
  File "/home/yx.wang/anaconda3/envs/py3torch2keras/lib/python3.6/site-packages/pip/_internal/req/req_file.py", line 82, in parse_requirements
    filename, comes_from=comes_from, session=session
  File "/home/yx.wang/anaconda3/envs/py3torch2keras/lib/python3.6/site-packages/pip/_internal/download.py", line 440, in get_file_content
    'Could not open requirements file: %s' % str(exc)
pip._internal.exceptions.InstallationError: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'

----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-zk3qnkav/pytorch2keras/
`

Hello there. Yep, requirements.txt is missing in the previous package version. I fixed it in the latest pypi version.


Add license field (MIT) to package.json

npm install gives a warning:  npm WARN<EMAIL_ADDRESS>No license field.
This PR adds a license to package.json, and gets rid of this warning.
The repo already has an MIT license file, so it's no changing the license, just repeating it.

Makes sense, thanks!


Fix #72/#125/#189, separate into 2 package while remain monorpoe

Fix #72/#125/#189
Separate into 2 packages, graphql_client (I was added as the "uploader" for this dart pub package) and graphql_flutter.

This PR is pretty massive, might take a bit for me to get to it. Will be easier to look at once #202 is merged. Also, merging it would make merging downstream work pretty difficult. Might be best to defer merging until we've consolidated more features like optimism (#199) and do a big rebase of this PR.

Apologies, but I'm closing this in favor #245. I'm sure this PR was done just fine, it's just that I wanted to merge the prior outstanding PRs before it, and after that was done I didn't want to try and rebase these diffs 😅


chore(rpc): pending block helper trait

Moves EthApi methods for loading pending block to default trait methods of new trait LoadPendingBlock. Needed to impl default trait methods for EthBlocks and EthTransactions.

blocked by https://github.com/paradigmxyz/reth/pull/8639


How can one fit auto arima for daily data?

All the examples typically use non-daily data. How can one specify and fit auto-arima to daily data?

I believe what you're talking about is covered here and here in our docs. You should just need to set m=7 for daily seasonality. Let us know if that answers your question

It also depends on the seasonal periodicity in your data, which we don't know. Take a look at Rob Hyndman's blog post on this topic.


[WIP] Backport "Add Support for Persistent OVMF Settings in Pillar"

This PR is a testing backport of #4261 into 9.4

Did we have only the DCO check in the pipeline in 9.4? oO

FYI: If this is the customer ask to have a backport to a branch which is end of support for quite a while, please be aware, that this branch does not include many other fixes due its EOS status

FYI: If this is the customer ask to have a backport to a branch which is end of support for quite a while, please be aware, that this branch does not include many other fixes due its EOS status

Yeah, sure, we remember it


Python client datetimes are influenced by time zone

Description
The Python client API is inconsistent with time zones. When a datetime attribute is inserted, everything is fine. However, when this same attribute is queried, there is an offset of 2 hours (UTC+01:00 + summertime).
Environment

OS: Windows 10
TypeDB version: TypeDB 2.17.0
TypeDB client-python version: client-python 2.17.0 (the newest release 2.18.0 crashes at this moment for some reason)
Python version: Python 3.10.6, Python 3.8.2 and Python 3.7.8 (tested the issue on these three versions)
Other environment details: Clean venv with only typedb-client installed

Reproducible Steps

Make sure that the system time is NOT on (UTC+00:00) or summer/wintertime is ENABLED
Create a virtual environment and install the client

python3 -m venv venv               # Create virtual environment in Python 3
.\venv\Scripts\activate            # Activate the virtual environment
pip install typedb-client==2.17.0  # Install the typedb-client (version 2.18.0 crashes)

Run the TypeDB server

typedb server  # Version 2.17.0

Run this minimal test python file

from typedb.client import TypeDB, SessionType, TransactionType

KEYSPACE = "datetime_issue"

def main() -> None:
    # Create a client
    with TypeDB.core_client(TypeDB.DEFAULT_ADDRESS) as client:
        # Create the keyspace if it does not exist
        if not client.databases().contains(KEYSPACE):
            client.databases().create(KEYSPACE)

        # Create a schema session
        with client.session(KEYSPACE, SessionType.SCHEMA) as session:
            with session.transaction(TransactionType.WRITE) as write_schema_transaction:
                # Only define a datetime attribute
                query = "define test_date sub attribute, value datetime;"
                write_schema_transaction.query().define(query)
                write_schema_transaction.commit()

        # Create a data session
        with client.session(KEYSPACE, SessionType.DATA) as session:
            with session.transaction(TransactionType.WRITE) as write_data_transaction:
                # Insert first of every month, at 00:00:00
                query = """insert
                $time_date_jan isa test_date;  $time_date_jan 2023-01-01T00:00:00;
                $time_date_feb isa test_date;  $time_date_feb 2023-02-01T00:00:00;
                $time_date_mar isa test_date;  $time_date_mar 2023-03-01T00:00:00;
                $time_date_apr isa test_date;  $time_date_apr 2023-04-01T00:00:00;
                $time_date_may isa test_date;  $time_date_may 2023-05-01T00:00:00;
                $time_date_jun isa test_date;  $time_date_jun 2023-06-01T00:00:00;
                $time_date_jul isa test_date;  $time_date_jul 2023-07-01T00:00:00;
                $time_date_aug isa test_date;  $time_date_aug 2023-08-01T00:00:00;
                $time_date_sep isa test_date;  $time_date_sep 2023-09-01T00:00:00;
                $time_date_oct isa test_date;  $time_date_oct 2023-10-01T00:00:00;
                $time_date_nov isa test_date;  $time_date_nov 2023-11-01T00:00:00;
                $time_date_dec isa test_date;  $time_date_dec 2023-12-01T00:00:00;
                """
                write_data_transaction.query().insert(query)
                write_data_transaction.commit()

            with session.transaction(TransactionType.READ) as read_data_transaction:
                # Match all date attributes and print them
                query = "match $date isa test_date; get $date;"
                answer = read_data_transaction.query().match(query)  # <- PROBLEM IS HERE
                dates = [ans.get("date") for ans in answer]
                for date in dates:
                    print(f"Retrieved date: {date.get_value()}")

if __name__ == "__main__":
    main()

Expected Output
I would expect to retrieve back the exact same dates as inserted in the query().insert():
Retrieved date: 2023-01-01 00:00:00
Retrieved date: 2023-02-01 00:00:00
Retrieved date: 2023-03-01 00:00:00
Retrieved date: 2023-04-01 00:00:00
Retrieved date: 2023-05-01 00:00:00
Retrieved date: 2023-06-01 00:00:00
Retrieved date: 2023-07-01 00:00:00
Retrieved date: 2023-08-01 00:00:00
Retrieved date: 2023-09-01 00:00:00
Retrieved date: 2023-10-01 00:00:00
Retrieved date: 2023-11-01 00:00:00
Retrieved date: 2023-12-01 00:00:00

Actual Output
Instead, there is a clear offset in time, 1 hour in wintertime and 2 hours in summertime (exactly UTC+01:00).
Retrieved date: 2023-01-01 01:00:00
Retrieved date: 2023-02-01 01:00:00
Retrieved date: 2023-03-01 01:00:00
Retrieved date: 2023-04-01 02:00:00
Retrieved date: 2023-05-01 02:00:00
Retrieved date: 2023-06-01 02:00:00
Retrieved date: 2023-07-01 02:00:00
Retrieved date: 2023-08-01 02:00:00
Retrieved date: 2023-09-01 02:00:00
Retrieved date: 2023-10-01 02:00:00
Retrieved date: 2023-11-01 01:00:00
Retrieved date: 2023-12-01 01:00:00

Additional information

Issue is in the Python client (TypeDB Studio works fine)
Doing a read data match query in the datetime_issue keyspace inside of TypeDB Studio 2.11.0 on Windows, does NOT have this time offset. This means that the problem is clearly in the Python API, especially in the transaction.query().match(query) method.
It depends on the system time
When the system time in Windows is changed to UTC+00:00 and summer-/wintertime is disabled, there is no time offset.

I met the same issue, does anybody have a solution?

@hezhichenghzc  @steenstral FYI the release is out on github & pip, please let us know if there are any remaining issues :)

@flyingsilverfin Unfortunately I cannot test it yet, because there is a version mismatch between te client (2.18.1) and the server (2.17.0). When trying to create a client I get the following error:
Error traceback

Traceback (most recent call last):
  File "c:\<path_to_workspace>\datetime_example.py", line 55, in <module>
    main()
  File "c:\<path_to_workspace>\datetime_example.py", line 9, in main
    with TypeDB.core_client(TypeDB.DEFAULT_ADDRESS) as client:
  File "C:\<path_to_workspace>\venv\lib\site-packages\typedb\client.py", line 70, in core_client
    return _CoreClient(address, parallelisation)
  File "C:\<path_to_workspace>\venv\lib\site-packages\typedb\connection\core\client.py", line 35, in __init__
    self._channel, self._stub = self.new_channel_and_stub()
  File "C:\<path_to_workspace>\venv\lib\site-packages\typedb\connection\core\client.py", line 52, in new_channel_and_stub
    return channel, _CoreStub(channel)
  File "C:\<path_to_workspace>\venv\lib\site-packages\typedb\connection\core\stub.py", line 42, in __init__
    raise e
  File "C:\<path_to_workspace>\venv\lib\site-packages\typedb\connection\core\stub.py", line 39, in __init__
    self._stub.connection_open(connection_open_req())
  File "C:\<path_to_workspace>\venv\lib\site-packages\grpc\_channel.py", line 1030, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "C:\<path_to_workspace>\venv\lib\site-packages\grpc\_channel.py", line 910, in _end_unary_response_blocking
    raise _InactiveRpcError(state)  # pytype: disable=not-instantiable
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
        status = StatusCode.UNAVAILABLE
        details = "failed to connect to all addresses; last error: UNAVAILABLE: ipv6:%5B::1%5D:1729:
WSA Error"
        debug_error_string = "UNKNOWN:failed to connect to all addresses; last error: UNAVAILABLE: ipv6:%5B::1%5D:1729: WSA Error {grpc_status:14, created_time:"2023-07-06T08:58:42.245912889+00:00"}"
>

I saw this issue also passing by on Discord. Is there a way I can test this patch update, or do I need to wait for the new TypeDB server release?

I updated my TypeDB server version, and I can confirm that it is working and that I now get the expected result. Thank you for solving this issue!


Flask infer MIME type in javascript modules

When loading static assets and a javascript module is declared like so:
   <script
      type="module"
      src="{{ url_for('static', filename='js/app.js') }}"
    ></script>

and files are imported within the module like this:
import SomeClass from './utils'

then it will have the content-type in the header set to 'html/text' and it will spit this error in the browser console
Failed to load module script: The server responded with a non-JavaScript MIME type of "text/html". Strict MIME type checking is enforced for module scripts per HTML spec.

The workaround for this is to import files in javascript like this:
import SomeClass from './utils.js'

And then the server sends the correct content-type with the header.  My recommendation would be that if a file is getting imported as part of a javascript module, the server should infer that it is javascript even without the .js extension
Lastly, since it is the server that sets these headers, I assumed Flask was the culprit.  If I am mistaken, let me know where I should repost this issue.
Environment

Python version: 3.8.2
Flask version: 1.1.2
Werkzeug version: 1.0.1

Flask send files with the mime type detected from the file name. If you need another behavior, you can implement a different route to send files with a hard coded type.


How to get back some original apps

Hello,
I've tried to modify your Standard version of the script, and removed line 400 which is the line to delete Notepad, and that works. When installing it comes with Notepad.
However when I try this with the calculator, camera, alarm (clock), paint, it doesn't seem to work and is not installed.
Also it still installs the old calculator instead of the new one from Windows 10 even though I removed the line to delete calculator.
When pressing Windows + R and typing 'mspaint' it says it can't be found so it's not hidden I believe. For some reason the "Getting Started" app seems to get installed even though I never removed that line.
I am on Windows 11 IoT Enterprise LTSC 24H2.
Are there any solutions?

Hi there,
I haven't tested the file(s) on IoT Enterprise LTSC versions and also not on 24H2. I mention this in the README as well.
You can compare my IoT-LTSC version with the Standard version and see that I removed the lines in the IoT-LTSC version for apps like Notepad, Paint, Calculator etc. and those are installed when using a Pro or Home version of Windows, I'm not sure if it's different for the Enterprise versions of Windows.
As for the "Getting Started" app, there is no way to remove it that I've found.


Java crash in operations_research::RoutingModel::~RoutingModel()+0x2f

I'm doing a CVRPWTW in Java, and it's working pretty well. However, after I have run my routing model a couple of times (I think basically until the Garbage Collector kicks in), it crashes:
11:39:49 web.1  | # A fatal error has been detected by the Java Runtime Environment:
11:39:49 web.1  | #
11:39:49 web.1  | #  SIGSEGV (0xb) at pc=0x000000011ffae33f, pid=87260, tid=14339
11:39:49 web.1  | #
11:39:49 web.1  | # JRE version: Java(TM) SE Runtime Environment (8.0_31-b13) (build 1.8.0_31-b13)
11:39:49 web.1  | # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.31-b07 mixed mode bsd-amd64 compressed oops)
11:39:49 web.1  | # Problematic frame:
11:39:49 web.1  | # C  [libortools.dylib+0x2f433f]  operations_research::RoutingModel::~RoutingModel()+0x2f
11:39:49 web.1  | #
11:39:49 web.1  | # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
11:39:49 web.1  | #
11:39:49 web.1  | # An error report file with more information is saved as:
11:39:49 web.1  | # /Users/andygeers/hubbub/capacity-manager/hs_err_pid87260.log

Log file attached: hs_err_pid87260.log.txt
Here's a (mostly) minimal Java program that crashes when you run it:
crashingcvrptw.zip
java -cp objs:lib/com.google.ortools.jar:lib/uk.co.hubbub.ortools.jar uk.co.hubbub.ortools.CapacitatedVehicleRoutingProblemWithTimeWindows

So latest update is that I can reproduce this purely from Java (so it was nothing to do with using JRuby) - basically as soon as the Garbage Collector kicks in it crashes. I've attached a zip file with my Java program that crashes when you run it.

There is an old discussion topic on the same issue: https://groups.google.com/forum/#!topic/or-tools-discuss/dpTJ35xJA64

Hello Andy,
I would like to debug your code, so can you please attach the zip file you talked about?
Regards.

It was that link at the bottom of my first post: crashingcvrptw.zip
Just in case, I've built another one that should hopefully do the same thing:
CrashReproduction.zip

Just checked the problem. It runs fine on my machine.
Closing the issue.


reflect: TestCallReturnsEmpty does not work for -test.count=2

$ ../bin/go test reflect -count=2
--- FAIL: TestCallReturnsEmpty (5.00s)
    all_test.go:1706: finalizer did not run
FAIL
FAIL	reflect	5.816s

This test seems to fail for any count > 1.

@Quasilyte


Bucket Sort

🚀 Feature
Bucket Sort is a sorting technique that sorts the elements by first dividing the elements into several groups called buckets. The elements inside each bucket are sorted using any of the suitable sorting algorithms or recursively calling the same algorithm.
Have you read the Contributing Guidelines on Pull Requests?
yes
Pitch
It should be implemented because it is quicker than bubble sort.Putting data into small buckets that can be sorted individually reduces the number of comparisons that need to be carried out

I think this is the same as #426


Make pasting on Linux more robust, close #65

As stated in #65 this seems to be more robust

@tecosaur It would be cool to make the keyboard shortcut configurable. Feel free to send a pull request.

I mean, I guess that would be nice, it just seems unnecessary to me. I use CopyQ a lot, and have never had an issue with that pasting; it uses Shift+Insert. However Ctrl+V is rebound in a fair few apps, notably most terminals.

@zachcurry would be good if you could follow up on my previous comment :slightly_smiling_face:

Sorry for the delay, @tecosaur.
You may be right. As someone who only uses Linux for a production environment, I don't know all of the ways in which a user might configure their environment, or if certain issues may arise from which applications use PRIMARY and which applications use CLIPBOARD with Shift+Insert, etc. Making this configurable would give the user, the one who knows more about their environment and use case(s), more control over how the paste operation works; however, since simply hardcoding Shift+Insert seems to be preferable to hardcoding Ctrl+v, I will go ahead and merge your pull request and table the potential corner cases for a later date.


Wokers list

Proposal
Workers list is added. Nothing more.
Related card on Trello. We need a list of cleaners so later on admin can select specific cleaner, update, assign to a job.
Checklist

[x] I have made this pull request to the master branch
[x] I have run npm run lint and there are no errors

Here is one problem with eslint. Like there: https://github.com/yannickcr/eslint-plugin-react/issues/2654

I'm not sure that a manager will use a mobile device, but anyway, this is not time to talk about it. Even I did not create a separate component for table rows, and this should be done before the adaptation for mobile.

Looks good!


Customizable color and sound

Two colors for gradient
Add a selector for sounds (not custom yet)

Color done

just one sound for now


Add auto reboot

Could be possible to add an auto reboot option every N hours? Useful in case of loss of internet or APRS server connection
Thanks, Mikel

hi Mike, would look at it also ;)
what should be a default value if this was "on"? every 12 hours? every 6? once a day?

Hi & thanks for answering!
We have other soft iGates around here set at 6 or 12 hours.
73, MikeL


Duplicate namespace buttons

After I had a view of a Kubernetes cluster open for a while, the namespace buttons at the bottom grew really long, and I could see some of the names were repeated.
Refreshing the screen made the problem go away.

@bboreham were you able to reproduce it again recently?

@fbarl no, I left a window open for a while and do not see it happening now; I'll close this issue.

I'm pretty sure the trigger for this is the back-end restarting.  We auto-deploy all master builds to Weave Cloud staging environment, so when I leave a view open there it will tend to hit some restarts over time.

I have just seen the buttons duplicate right in front of me, when I restarted the probe.
Can reproduce on demand now.


Error : Uncaught (in promise) TypeError: Failed to execute 'Cache' on 'addAll': Request failed

In my local , i am using this routing. it works fine. but when i'm going to deploy in aws, i'm getting this error. once i remove all routing coding it works in release mode. so my code was not wrong . once i include the routing code in flutter project. i getting this above error

Could you provide some more info?
Flutter version,
qlevar_router version,
when this error appears? when you navigate to some route or the project does not run at all?

i'm also facing the same issue
Flutter 2.0.1 • channel stable •
Tools • Dart 2.12.0
qlevar_router: ^1.1.0
while working in Localhost it's working fine. but when I deploy in AWS it shows page not found
my initial route is the same as your example Project
QRoute(name: subdomain, path: '/', builder: () => SubDomain())
After hit URL , subDomain page comes but within a millisecond it says page not found
Can you guide us in this issue @SchabanBo
Thanks in advance

Sorry for the late response, but I tried to deploy to AWS (my first deployment on AWS, so it took a little bit), but the weird It works fine, so I could not find the problem.
But from the image you provide @ajaylg , it looks like the browser trying to navigate to the /index.html route which I think is not defined in the routes tree.
Could you please try adding the flowing route to your routes and try if this will works?
QRoute(path: '/index.html', builder: () => Container(), middleware: [
          QMiddlewareBuilder(redirectGuardFunc: (s) async => '/')
        ]),

@SchabanBo  now working.
i'm going to close this issue
Thank you

Hey @SchabanBo, It's Working now
Thankzzz a lot


Moved to mostly using only functional components.

After reading https://facebook.github.io/react/blog/2015/12/18/react-components-elements-and-instances.html, I couldn't resist the urge to moving all stateless components to pure functional ones.
r=? @leplatrem

I'm just gonna land this with r=me and keep moving forward.


Remove cAndCwithStickyE project files

Per team discussions, projects like cAndCwithStickyE should live only in their own REMARK, not duplicated in the package distribution of HARK.  This commit removes the project files for StickyE.

I will do this when we have verified that everything works properly for a fresh install.  Probably nearly there now, but this issue needs to be fixed (on the cAndCwithStickyE-Latest private repo).  When that is done, I'll run my scripts again to generate the public version.
I'd also like to do a global search in HARK, DemARK, and REMARK for things that might break.

This is the only repository in the econ-ark organization with a reference to HARK/cAndCwithStickyE:
https://github.com/econ-ark/econ-ark-make/search?q=cAndCwithStickyE&unscoped_q=cAndCwithStickyE
It is a checklist with no functionality.
The other references to cAndCwithStickyE are to the llorracc/cAndCwithStickyE version, which is a REMARK:
https://github.com/econ-ark/REMARK/search?q=cAndCwithStickyE&unscoped_q=cAndCwithStickyE
https://github.com/econ-ark/REMARK-make/search?q=cAndCwithStickyE&unscoped_q=cAndCwithStickyE
Or the paper:
https://github.com/econ-ark/econ-ark.org/search?q=cAndCwithStickyE&unscoped_q=cAndCwithStickyE
https://github.com/econ-ark/PARK-make/search?q=cAndCwithStickyE&unscoped_q=cAndCwithStickyE
https://github.com/econ-ark/HARK-make/search?utf8=✓&q=cAndCwithStickyE&type=
https://github.com/econ-ark/PLUTARK/search?q=cAndCwithStickyE&unscoped_q=cAndCwithStickyE
In other words, I could find no reason to think removing these HARK files would break downstream code.

This is done in #442


Can't find Tokenizer access from NPC Sheet

Hi,
While translating your module, I saw there is a VTTA Tokenizer button or something like that ? Could you tell me how to use this feature. When I click on creature image, it opens it. I have to switch to default sheet to open Tokenizer.
Best regards

The Tokenizer button is in the cog menu in the upper left corner. If the VTTA Tokenizer module is installed, a new option will appear in that menu.


Version links in sidebar are broken

They all link to http://readthedocs.org/ Note that version links in the corner hover work fine.
Also, its probably intentional, but the html_sidebars sphinx directive does not work.

Thanks for fixing this!


[CT-2808] [Feature] Support hiding all resources from a package (not just models)

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature
This is an extension of https://github.com/dbt-labs/dbt-core/issues/1671
Currently, we can hide docs of models in packages by doing:
# dbt_project.yml
name: my_dbt_project

models:
  local_package:
    +docs:
      show: false
  my_dbt_project:
....

However, this causes package macros to still show up in the docs site. Since macros is not a top level key in the dbt_project.yml file (https://docs.getdbt.com/reference/dbt_project.yml), you can't hide docs of a packages macros easily. And of course, most dbt packages include macros :)
We can try this out quite simply:
# dbt_project.yml
name: my_dbt_project
profile: snowflake
config-version: 2
version: 1.0

models:
  my_dbt_project:
    +materialized: table

# packages.yml
packages:
  - local: ../some_package
  - package: brooklyn-data/dbt_artifacts
    version: 2.3.0

# ../some_package/dbt_project.yml
name: "some_package"
version: "0.1.0"
config-version: 2

-- ../some_package/models/bar.sql
select 1 id

Now let's hide those docs!
# dbt_project.yml
name: my_dbt_project
profile: snowflake
config-version: 2
version: 1.0

models:
  some_package:
    +docs:
      show: false
  dbt_artifacts:
    +docs:
      show: false
  my_dbt_project:
    +materialized: table

^ There is no longer a folder for some_package since it only contains models but still one for dbt_artifacts - cause of the macros.
Describe alternatives you've considered
Not too sure how one go about hiding entire package macros from docs today.
Who will this benefit?
Anyone who wants to remove some clutter from their dbt docs site.
Are you interested in contributing this feature?
No response
Anything else?
Trying to put a top level macros key like so:
# dbt_project.yml
name: my_dbt_project
profile: snowflake
config-version: 2
version: 1.0

models:
  some_package:
    +docs:
      show: false
  dbt_artifacts:
    +docs:
      show: false
  my_dbt_project:
    +materialized: table

macros:
  dbt_artifacts:
    +docs:
      show: false

Results in:
$ dbt docs generate

01:02:26  Running with dbt=1.5.2
01:02:27  Encountered an error:
Runtime Error
  at path []: Additional properties are not allowed ('macros' was unexpected)

Error encountered in /Users/jeremy/src/dbt-sandcastles/dbt/snowflake/dbt_project.yml

Thanks for such a nice write-up @jeremyyeo 🤩
It seems reasonable to enable configs for macros within dbt_project.yml as you described:
# dbt_project.yml

...

macros:
  dbt_artifacts:
    +docs:
      show: false

This could include the docs config shown in the screenshot below as well as any other current or future configs for macros (like meta).

@jtcohen6 Is there any reason why we wouldn't want to add macros as a top level key in dbt_project.yml?

@jtcohen6 Is there any reason why we wouldn't want to add macros as a top level key in dbt_project.yml?

Just that macros don't yet / haven't historically supported any other configs that could be set in dbt_project.yml. Sounds like this might want to be the first!

Is there a reason the docs config isn't implemented for sources? I have a use-case where I want to hide most of my sources (since they are mostly duplicate schemas and they clutter up the documentation site).

@dbeatty10 Thanks for the info.
For sources specifically the behaviour is:

If the docs property is set in dbt_project.yml the property is largely ignored. It is added to manifest.json under the unrendered_config key, but is unused.
If the docs property is set directly on the source config, a parsing error is raised:

Parsing Error
  Invalid sources config given in models/sources.yml @ sources: {'name': 'test', 'schema': 'test', 'docs': {'show': False}, 'tables': [{'name': 'test'}]} - at path []: Additional properties are not allowed ('docs' was unexpected)

Any news on this issue. I also want to hide macros from my doc

Any news on this issue. I also want to hide macros from my doc

Check this out

@brunodeprez
This feature is not a priority for us right now. Implementing this feature correctly requires fairly extensive knowledge of our codebase, so we're not encouraging pull requests from the community on this one either.
As a result, using a workaround like @hvignolo87 suggested is your best bet: https://github.com/dbt-labs/dbt-core/issues/8061#issuecomment-2138408151


Missing lemma about Sum.elim

I couldn't find this lemma in Std so I proved it myself:
import Std

theorem Sum.elim_eq_iff {α β γ : Type _} {u u' : α → γ} {v v' : β → γ} :
    Sum.elim u v = Sum.elim u' v' ↔ u = u' ∧ v = v' := by
  apply Iff.intro (fun huv =>
    ⟨funext (fun a => congr_fun huv (Sum.inl a)), funext (fun b => congr_fun huv (Sum.inr b))⟩)
  intro ⟨hu, hv⟩
  ext i
  cases i with
  | inl a => rw [Sum.elim_inl, Sum.elim_inl]; exact congr_fun hu a
  | inr b => rw [Sum.elim_inr, Sum.elim_inr]; exact congr_fun hv b

Please consider adding it to Std.

Here's a shorter proof:
theorem Sum.elim_eq_iff {α β γ : Type _} {u u' : α → γ} {v v' : β → γ} :
    Sum.elim u v = Sum.elim u' v' ↔ u = u' ∧ v = v' := by
  simp_rw [Function.funext_iff, Sum.forall]
  rfl

You are right, but I need to decrease the set of imports, not increase it.

@madvorak, what would you think about just moving the prerequisites of Eric's proof into Std?
I'm happy either way.

(In either case, please open a PR.)

https://github.com/leanprover/std4/pull/715


Build console displays warning that utf-8 not declared[bug]

Describe the bug
When building the project, there is a warning that is displayed in the maven console that denotes that the utf-8 format is not explicitly declared
Package version
1.2.0
1.2.3-SNAPSHOT
Remediation
Append the following property to the all/pom.xml and the core/pom.xml
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

Internally tracked by CQ-4317712

Exact warning -
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
and
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!

Fixed via https://github.com/adobe/aem-spa-project-core/pull/30 and released  spa.project.core-1.2.8
Closing this issue


error code is given whenever lsp imports an item that can be filled

example: when pressing Tab or Enter to autocomplete winit::dpi::LogicalSize<>

after pressing 'OK', cursor jumps to the correct position:

so i have no idea why this error is shown. this error appears for anything that has to be filled up:

function in question is 4th line from the top, .build(window_target)

#93 fixes this issue

rust-analyzer adds the command rust-analyzer.triggerParameterHints in https://github.com/rust-lang/rust-analyzer/pull/14147
Seems it will then execute the editor.action.triggerParameterHints command in vscode.
This is how LSP handles editor.action.triggerParameterHints
https://github.com/sublimelsp/LSP/blob/0d149265408824b73184709619af4497d9044650/plugin/execute_command.py#L26-L33
I copy them to plugin.py and it works. But ignoring the command and returning True like #93 also fixes this. The signature help still pops up.

Yeah, I suppose there are some client-specific differences in when the signature help is triggered. So it looks like we might actually need to explicitly trigger that command.
But the behavior might differ based on in which context completion is invoked so in theory there could still be cases where explicitly triggering the command would be necessary. But in that case we could fix that later.

Fixed in this PR
And I made a new release that should include the fix -> https://github.com/sublimelsp/LSP-rust-analyzer/releases/tag/v1.4.0


New version: Distributions v0.21.2

Registering package: Distributions
Repository: https://github.com/JuliaStats/Distributions.jl
Created by: @matbesancon
Version: v0.21.2
Commit: 5b6c2dd271897999c1b50aaa18ed210b0ec6dce7
Reviewed by: @matbesancon
Reference: https://github.com/JuliaStats/Distributions.jl/issues/974#issuecomment-535430823

All good here


Richardcho/cancel live test

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Error creating machine: Error in driver during machine creation: not supported (vCenter only)

Pretty new to Rancher but I cant get it to create a new node (creating new cluster) using Vsphere 6.7. It creates the VM and then fails with a " NodeController c-htmck/m-x9twd [node-controller] failed with : Error creating machine: Error in driver during machine creation: not supported (vCenter only)"
2018/05/27 01:32:14 [INFO] stdout: Creating CA: management-state/node/nodes/test1/certs/ca.pem
2018/05/27 01:32:15 [INFO] stdout: Creating client certificate: management-state/node/nodes/test1/certs/cert.pem
2018/05/27 01:32:16 [INFO] stdout: Running pre-create checks...
2018/05/27 01:32:17 [INFO] stdout: Creating machine...
2018/05/27 01:32:17 [INFO] stdout: (test1) Image cache directory does not exist, creating it at management-state/node/nodes/test1/cache...
2018/05/27 01:32:17 [INFO] stdout: (test1) Downloading management-state/node/nodes/test1/cache/boot2docker.iso from https://releases.rancher.com/os/latest/rancheros.iso...
2018/05/27 01:32:26 [INFO] stdout: (test1) 0%!.(MISSING)..10%!.(MISSING)..20%!.(MISSING)..30%!.(MISSING)..40%!.(MISSING)..50%!.(MISSING)..60%!.(MISSING)..70%!.(MISSING)..80%!.(MISSING)..90%!.(MISSING)..100%!(NOVERB)
2018/05/27 01:32:26 [INFO] stdout: (test1) Generating SSH Keypair...
2018/05/27 01:32:29 [INFO] stdout: (test1) Creating VM...
2018/05/27 01:32:29 [INFO] stdout: (test1) Uploading Boot2docker ISO ...
2018/05/27 01:32:43 [INFO] stdout: The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.
2018/05/27 01:32:43 [INFO] stdout:
2018/05/27 01:32:43 [INFO] Generating and uploading node config test1
E0527 01:32:43.641542       1 generic_controller.go:204] NodeController c-htmck/m-x9twd [node-controller] failed with : Error creating machine: Error in driver during machine creation: not supported (vCenter only)
2018/05/27 01:32:43 [INFO] NodeController c-htmck/m-x9twd completed with dropped err: [node-controller] failed with : Error
2018/05/27 01:32:44 [INFO] NodeController c-htmck/m-x9twd completed with dropped err: [node-controller] failed with : Error
2018-05-27 01:32:59.870981 I | mvcc: store.index: compact 503805
2018-05-27 01:32:59.873562 I | mvcc: finished scheduled compaction at 503805 (took 1.930844ms)

Useful
Info

Versions
Rancher v2.0.2 UI: v2.0.48

Access
local admin

Route
global-admin.clusters.index

Use rancheer OS for vmware image: https://github.com/rancher/os/releases/download/v1.4.0-rc2/rancheros-vmware.iso
The default image need internet connection for vmware tools download.
The rancheros-vmware.iso image have vmware tools include in iso.

I did try that image and it makes no difference. I still get the same error:
2018/05/27 23:42:36 [INFO] stdout: Creating CA: management-state/node/nodes/kub-man1/certs/ca.pem
2018/05/27 23:42:36 [INFO] stdout: Creating CA: management-state/node/nodes/kub-work2/certs/ca.pem
2018/05/27 23:42:37 [INFO] stdout: Creating CA: management-state/node/nodes/kub-work1/certs/ca.pem
2018/05/27 23:42:38 [INFO] stdout: Creating client certificate: management-state/node/nodes/kub-man1/certs/cert.pem
2018/05/27 23:42:38 [INFO] stdout: Creating client certificate: management-state/node/nodes/kub-work2/certs/cert.pem
2018/05/27 23:42:39 [INFO] stdout: Creating client certificate: management-state/node/nodes/kub-work1/certs/cert.pem
2018/05/27 23:42:39 [INFO] stdout: Running pre-create checks...
2018/05/27 23:42:41 [INFO] stdout: Running pre-create checks...
2018/05/27 23:42:42 [INFO] stdout: Running pre-create checks...
2018/05/27 23:42:42 [INFO] stdout: Creating machine...
2018/05/27 23:42:42 [INFO] stdout: (kub-man1) Image cache directory does not exist, creating it at management-state/node/nodes/kub-man1/cache...
2018/05/27 23:42:42 [INFO] stdout: (kub-man1) Downloading management-state/node/nodes/kub-man1/cache/boot2docker.iso from https://github.com/rancher/os/releases/download/v1.4.0-rc2/rancheros-vmware.iso...
2018/05/27 23:42:43 [INFO] stdout: Creating machine...
2018/05/27 23:42:43 [INFO] stdout: (kub-work1) Image cache directory does not exist, creating it at management-state/node/nodes/kub-work1/cache...
2018/05/27 23:42:43 [INFO] stdout: (kub-work1) Downloading management-state/node/nodes/kub-work1/cache/boot2docker.iso from https://github.com/rancher/os/releases/download/v1.4.0-rc2/rancheros-vmware.iso...
2018/05/27 23:42:43 [INFO] stdout: Creating machine...
2018/05/27 23:42:43 [INFO] stdout: (kub-work2) Image cache directory does not exist, creating it at management-state/node/nodes/kub-work2/cache...
2018/05/27 23:42:43 [INFO] stdout: (kub-work2) Downloading management-state/node/nodes/kub-work2/cache/boot2docker.iso from https://github.com/rancher/os/releases/download/v1.4.0-rc2/rancheros-vmware.iso...
2018-05-27 23:43:01.617351 I | mvcc: store.index: compact 623444
2018-05-27 23:43:01.619974 I | mvcc: finished scheduled compaction at 623444 (took 1.987294ms)
2018-05-27 23:43:19.196584 W | wal: sync duration of 2.304582558s, expected less than 1s
2018/05/27 23:43:20 [INFO] stdout: (kub-man1) 0%!.(MISSING)..10%!.(MISSING)..20%!.(MISSING)..30%!.(MISSING)..40%!.(MISSING)..50%!.(MISSING)..60%!.(MISSING)..70%!.(MISSING)..80%!.(MISSING)..90%!.(MISSING)..100%!(NOVERB)
2018/05/27 23:43:21 [INFO] stdout: (kub-man1) Generating SSH Keypair...
2018/05/27 23:43:24 [INFO] stdout: (kub-man1) Creating VM...
2018/05/27 23:43:25 [INFO] stdout: (kub-man1) Uploading Boot2docker ISO ...
2018/05/27 23:43:39 [INFO] stdout: (kub-work2) 0%!.(MISSING)..10%!.(MISSING)..20%!.(MISSING)..30%!.(MISSING)..40%!.(MISSING)..50%!.(MISSING)..60%!.(MISSING)..70%!.(MISSING)..80%!.(MISSING)..90%!.(MISSING)..100%!(NOVERB)
2018/05/27 23:43:40 [INFO] stdout: (kub-work2) Generating SSH Keypair...
2018/05/27 23:43:43 [INFO] stdout: (kub-work2) Creating VM...
2018/05/27 23:43:44 [INFO] stdout: (kub-work2) Uploading Boot2docker ISO ...
2018/05/27 23:43:44 [INFO] stdout: The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.
2018/05/27 23:43:44 [INFO] stdout:
2018/05/27 23:43:48 [INFO] Generating and uploading node config kub-man1
E0527 23:43:48.415541       1 generic_controller.go:204] NodeController c-gwdfc/m-lx8vd [node-controller] failed with : Error creating machine: Error in driver during machine creation: not supported (vCenter only)
2018/05/27 23:43:48 [INFO] NodeController c-gwdfc/m-lx8vd completed with dropped err: [node-controller] failed with : Error
2018/05/27 23:43:48 [INFO] NodeController c-gwdfc/m-lx8vd completed with dropped err: [node-controller] failed with : Error
2018/05/27 23:43:52 [INFO] stdout: (kub-work1) 0%!.(MISSING)..10%!.(MISSING)..20%!.(MISSING)..30%!.(MISSING)..40%!.(MISSING)..50%!.(MISSING)..60%!.(MISSING)..70%!.(MISSING)..80%!.(MISSING)..90%!.(MISSING)..100%!(NOVERB)
2018/05/27 23:43:53 [INFO] stdout: (kub-work1) Generating SSH Keypair...
2018/05/27 23:43:56 [INFO] stdout: (kub-work1) Creating VM...
2018/05/27 23:43:57 [INFO] stdout: (kub-work1) Uploading Boot2docker ISO ...
2018/05/27 23:44:01 [INFO] stdout: The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.
2018/05/27 23:44:01 [INFO] stdout:
2018/05/27 23:44:02 [INFO] Generating and uploading node config kub-work2
E0527 23:44:02.635638       1 generic_controller.go:204] NodeController c-gwdfc/m-lztq5 [node-controller] failed with : Error creating machine: Error in driver during machine creation: not supported (vCenter only)
2018/05/27 23:44:02 [INFO] NodeController c-gwdfc/m-lztq5 completed with dropped err: [node-controller] failed with : Error
2018/05/27 23:44:03 [INFO] NodeController c-gwdfc/m-lztq5 completed with dropped err: [node-controller] failed with : Error
2018/05/27 23:44:15 [INFO] stdout: The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.
2018/05/27 23:44:15 [INFO] stdout:
2018/05/27 23:44:16 [INFO] Generating and uploading node config kub-work1
E0527 23:44:16.163667       1 generic_controller.go:204] NodeController c-gwdfc/m-mlqts [node-controller] failed with : Error creating machine: Error in driver during machine creation: not supported (vCenter only)
2018/05/27 23:44:16 [INFO] NodeController c-gwdfc/m-mlqts completed with dropped err: [node-controller] failed with : Error
2018/05/27 23:44:17 [INFO] NodeController c-gwdfc/m-mlqts completed with dropped err: [node-controller] failed with : Error

In vSphere 6.5 works for me. You trie use boot2docker.iso instead rancheros? I no have vSphere 6.7 to test.

yeah, I tried the standard one that the vsphere node driver is configured for by default:
https://github.com/boot2docker/boot2docker/releases/download/v17.03.2-ce/boot2docker.iso
That doesnt work either. Same error.

I don't think this has anything to do with the ISO being used, but with using one of the options for the driver that just isn't supported for ESXi vs vCenter.

Thanks for the report.
Can you submit your issue to https://github.com/rancher/os/issues if you can still reproduce the issue, please?


Date picker modal not showing in android

Hi, I was trying to implement the date picker onto my application, but the date picker modal isn't showing up on my android version, on IOS it works like charm, can someone help me out here.?
<DatePickerInput
    locale="en"
    label="Valid till date"
    value={inputDate}
    onChange={d => {
      console.log(d)
    }}
   inputMode="start"
   mode="outlined"
   style={{width: '90%', marginTop: '2.5%'}}
/>

Removing mode="outlined" seem to fixed it.

Hmm I think it should work with outlined but I only tested it on the web & iOS and not on Android yet

Hi.
Had the same problem.
I fixed it by adding a zindex to the style.calendarButton in line 130 in src/Date/DatePickerInput.tsx.
const styles = StyleSheet.create({   root: {     minWidth: 150,     flexDirection: 'row',     position: 'relative',     alignItems: 'center',     flexGrow: 1,     alignSelf: 'flex-start'   },   input: {     flexGrow: 1,   },   calendarButton: { position: 'absolute', right: 0, zIndex:1000 }, }) export default React.forwardRef(DatePickerInput)

This should be fixed now! Thanks @professionally


adjustments to mobile CSS

mobile figure captions should have about half the font size they have now:

bullet points in the list sections are a good size for desktop, but are too large for mobile. Reduce by about 25% if possible.

@jread-usgs Smaller or good?

bullets look good, but captions seem too big (also, can they be centered?)

@jread-usgs on just mobile or both for centered?

Centered for all please @mwernimont

@jread-usgs #91 is merged, I centered the caption text and reduced it to .9em, it is 1.5em on desktop, so its a significant down size which does look nice on mobile/

thanks @mwernimont !


Add DiscardMapZeros helper transformer

In some situations users want to compare two maps where missing entries
are equal to those that have the zero value.
For example, the following maps would be considered equal:
x := map[string]int{"foo": 12345, "zero":0}
y := map[string]int{"foo": 12345}
To help with this, we add DiscardMapZeros to cmpopts that transforms maps
by stripping entries with zero values.
This is not implemented in terms of a FilterPath+FilterValues+Ignore where the
Ignore is filtered to only activate if both of values are either the zero value
or missing. The reason is because the FilterValues will not even be evaluated
for invalid reflect.Value. In other words, there is no way to represent the
concept of a "missing" value in the Filter API.

@alercah provided an interesting example where DiscardMapZeros and EquateEmpty does not compose well.
Consider the following:
x: map[string][]int{"foo": []int{}}
y: map[string][]int{"foo": nil}

If only EquateEmpty were used, then these two are equal. However, the moment DiscardMapZeros is used, these are no longer equal because DiscardMapZeros only applies on y producing map[string][]int{}, while keeping the x value the same.
The current API will need to be thought about more carefully.

If the API for transformers allowed for func(T, T) (R, R) you could take an additive approach where all missing elements of the other map could be added as the zero value. However, I'm particularly fond of adding another function signature for transformers.

Hmm, that example suggests that DiscardMapZeros should discard all values that are equal to the zero value, not just values identical to the zero value.

Hmm, that example suggests that DiscardMapZeros should discard all values that are equal to the zero value, not just values identical to the zero value.

That would also be an API change where you could take in the cmp.state itself and call comparisons with it, because the definition of equality is dependent on the set of Options that are currently being used. messsagediff takes this approach where you had access to the comparer. I'd like to avoid that since it gets messy.

I see at least 4 possible options:

Add API to allow Options to operate on "non-existent" values
Add API to allow Options to allow functions to call cmp.Equal themselves with the set of Options already provided to the initial call to cmp.Equal
Add API to allow Transformers to also operate on func(T, T) (R, R)
Add no new API and just change how this helper is used.

Add API to allow Options to operate on "non-existent" values
This approach would involve altering the algorithm of cmp.Equal to still descend into two values even if one of them is missing. There would need to be new API to allow Options to have a concept of "non-existent" values. Non-existent values are possible for maps and slices. Arguably it is possible for interfaces and pointers to have "non-existent" values if we consider nil values to be "non-existent".
I am opposed to this approach since whether two elements of a slice are "non-existent" or not is dependent on the exact diffing algorithm used to compare two slices. Thus, the output of whether two objects are equal or not is now possibly dependent on the diffing algorithm, which causes the results of cmp.Equal to be tied to specific internal implementation details.
Add API to allow Options to allow functions to call cmp.Equal themselves with the set of Options already provided to the initial call to cmp.Equal
I don't have an idea of how the function signatures would change to be able to accommodate plumbing a custom comparator down to each Option. Regardless of the function signatures, I'm opposed to this approach since the result of cmp.Equal is dependent on the Path, and exposing the current custom equality operation to the user requires the user to properly update Path, which seems like a very brittle API and easy for users to get wrong.
Add API to allow Transformers to also operate on func(T, T) (R, R)
Early in the design of cmp, there were no Filter options, and transformers used to take in a signature of func(T, T, Path) (R, R, bool). The Path and bool types correspond with a FilterPath. The resulting func(T, T) (R, R) was simplified to simply func(T) R. When that happened, I noted that this prevents the use case where the transformation is a function of the other value.
Using func(T, T) (R, R), we can pre-emptively add the zero value for keys that exist in the other map. Thus, after transformation, both maps would be the same length.
Although I do see some utility in func(T, T) (R, R), I'm not convince that this use-case is a sufficient strong candidate for adding that as a valid Transformer to accept. (See option 4 below)
Add no new API and just change how this helper is used.
Instead of changing cmp, we can change the helper option being added to give more control to the user.
We can go with the following:
// DiscardElements transforms all slices and maps of type []V or map[K]V,
// where type V is assignable to type T, by removing elements where the
// remove function, f, reports true.
//
// As an example, all zero elements can be discarded with:
//	DiscardElements(func(v MyStruct) bool { return v == MyStruct{} })
//
// DiscardElements can be used in conjunction with EquateEmpty,
// but cannot be used with SortMaps.
func DiscardElements(f func(T) bool) cmp.Option

There are two benefits to this helper options:

Unlike DiscardMapZeros which operates on all maps, this scopes the operation to only work on maps where the value is type T, specified by the user.
For Alexis' example, it can now be handled with:

DiscardElements(func(v []int) bool {
    return cmp.Equal(v, []int(nil), cmpopts.EquateEmpty())
})

It is a little unfortunate, that the user would have to specify EquateEmpty again, but at least the control is in the user's hands, and it doesn't require exposing too much internal state of the comparison to the user.

Hmm. If you provided helper functions for the zero and zero/empty cases, I think that would be good.

@alercah, I'm going to hold off on adding sub-helper functions for those cases. It did not seem like the original problem was common enough to warrant more helpers. We can always add those in the future.

SGTM

PR updated with DiscardElements helper that operates on both slices and maps.

I just ran into this issue in my first attempt at using cmp for some unit tests. In my particular case, one of the maps will always be a superset of the other, so I just want to set the missing keys in the smaller map to the zero value.
This is what I came up with:
func FillMaps(keys interface{}) cmp.Option {
	var mf mapFiller
	vk := reflect.ValueOf(keys)
	if vk.Kind() == reflect.Map {
		// Use the keys from an existing map.
		mf.keyType = vk.Type().Key()
		mf.keys = vk.MapKeys()
	} else {
		// Array or slice of keys.
		mf.keyType = vk.Type().Elem()
		for i, l := 0, vk.Len(); i < l; i++ {
			mf.keys = append(mf.keys, vk.Index(i))
		}
	}
	return cmp.FilterValues(mf.filter, cmp.Transformer("Fill", mf.fill))
}

type mapFiller struct {
	keyType reflect.Type
	keys    []reflect.Value
}

func (mf mapFiller) filter(x, y interface{}) bool {
	vx, vy := reflect.ValueOf(x), reflect.ValueOf(y)
	return (x != nil && y != nil && vx.Type() == vy.Type()) &&
		(vx.Kind() == reflect.Map && mf.keyType.AssignableTo(vx.Type().Key())) &&
		(mf.hasMissingKey(vx) || mf.hasMissingKey(vy))
}

func (mf mapFiller) hasMissingKey(v reflect.Value) bool {
	for _, k := range mf.keys {
		if !v.MapIndex(k).IsValid() {
			return true
		}
	}
	return false
}

func (mf mapFiller) fill(m interface{}) interface{} {
	vm := reflect.ValueOf(m)
	if !mf.hasMissingKey(vm) {
		return m
	}
	tm := vm.Type()
	vn := reflect.MakeMap(tm)
	vz := reflect.Zero(tm.Elem())
	for _, k := range mf.keys {
		vn.SetMapIndex(k, vz)
	}
	for _, k := range vm.MapKeys() {
		vn.SetMapIndex(k, vm.MapIndex(k))
	}
	return vn.Interface()
}

And I just use it like:
cmp.Diff(want, got, FillMaps(got))

While this works for maps, it seems weird to me that the Option is a function of the values of the input, rather just the type.

#121 provides the ground work for ignoring missing map and slice elements. I'm abandoning this PR since the other PR is a superior approach in my opinion.


chart: Add extraPaths to Ingress of GitHub Webhook Server

Hi, congratulation that the team released appVersion 0.21.0 and chartVersion 0.16.0.
I want to add some extra paths to the Ingress of the GitHub Webhook Server but every paths is automatically connected to the server, so I've add extraPaths just like grafana or argo-cd charts.
References:

https://github.com/grafana/helm-charts/blob/afcaf811ae181b64032994e677790266d49049db/charts/grafana/values.yaml#L200-L213
https://github.com/grafana/helm-charts/blob/afcaf811ae181b64032994e677790266d49049db/charts/grafana/templates/ingress.yaml#L40-L42
https://github.com/argoproj/argo-helm/blob/591de85984906ad5e98e4bb9785448dc4a78eb8a/charts/argo-cd/values.yaml#L1027-L1040
https://github.com/argoproj/argo-helm/blob/591de85984906ad5e98e4bb9785448dc4a78eb8a/charts/argo-cd/templates/argocd-server/ingress.yaml#L38-L40

I just confirmed that applying your suggestion results:
# Source: actions-runner-controller/templates/githubwebhook.ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: RELEASE-NAME-actions-runner-controller-github-webhook-server
  labels:
    helm.sh/chart: actions-runner-controller-0.16.0
    app.kubernetes.io/name: actions-runner-controller
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "0.21.0"
    app.kubernetes.io/managed-by: Helm
spec:
  rules:
    - host:
      http:
        paths:

          path: /*

(I provided only path: /* to see how it templated.) Please re-review! Thanks.

@KENNYSOFT Hey! Sorry for the delay and thanks for the fix.
Rereviewed this just now, and I added a minor tweak 56e1f5b
That's all and this LGTM! Thanks for your contribution


How feasible would WordPress-like named arguments and default values be?

Came across your plugin because I was looking for WordPress-like shortcode-plugins that do not actually use WordPress, GPL'ed code.
Now that I am trying to implement, I realize however that named argument with default values are missing. Is this a conscious decision? Do you have a general direction how to implement them? I could try and come up with a PR then?

Can you give me an example in pseudo code?


grpc keepalive: test server-to-client HTTP/2 pings

Need add tests around https://github.com/coreos/etcd/pull/8535.

Can you fill in more details here?
maybe @spzala can give this a try.

@gyuho hi, I am trying to see the behavior with setting --grpc-keepalive-min-time and --grpc-keepalive-interval, --grpc-keepalive-timeout following steps you suggested above but I guess I am probably not doing it right and not able to see errors like too many ping or ever server closing the connection. I have a single node cluster, and I tried testing with using simple go program from another machine (i.e. client pings server every few seconds (set higher than timeout or keep alive interval) I sent you earlier but without any luck of reproducing this behavior. Appreciates any help from you to go forward with it:) Thanks!

@spzala

probably not doing it right and not able to see errors like too many ping or even server closing the connection.

Have you dropped packets? We want to simulate faulty networks with iptables.

@gyuho hi, thanks, so I run this on client machine iptables -A INPUT -s <serverip> -j DROP and I see that stopped server message and then when I unblock it, the connection was back and started receiving messages.

We expect

Server closes the connection to the client (confirm by just looking at the logs maybe?)

You may tune gRPC keepalive timeout in server-side. The disconnect may have been too short for server-side keepalive to kick-in.

I would also add more debugging lines or adjust log levels in gRPC side. Server may not display all logs.

@gyuho hi, I am getting back from some vacation and work travel :). I could run tests manually and I think we should try adding two integration test - one for MinTime (i.e. goaway too many pings error)  and second for Timeout.
While testing manually, Timeout works as expected to me with actual closing of connection. With MinTime I see couple of things:

I could only see the log messages if I set up env variables export GRPC_GO_LOG_VERBOSITY_LEVEL=2 and  export GRPC_GO_LOG_SEVERITY_LEVEL=info on both server and client CLI. I also have to comment this line https://github.com/etcd-io/etcd/blob/7a759c18d294698f537f8be91927354818a71e51/clientv3/logger.go#L47 So to rely on log messages, we need to think  more here.
I see following log messages after enabling logging as step one above,
Server side: ERROR: 2018/10/15 22:35:18 transport: Got too many pings from the client, closing the connection.
Cline side: INFO: 2018/10/115 22:35:18 Client received GoAway with http2.ErrCodeEnhanceYourCalm.

I will be working on creating the integration test but have another related question, you mentioned to use blackhole - can I use the Blackhole() or something similar on client (clientv3.New(ccfg))?, something similar to https://github.com/etcd-io/etcd/blob/7a759c18d294698f537f8be91927354818a71e51/clientv3/integration/black_hole_test.go#L91 Per what I see is the method is used for cluster members.  Thanks!

@spzala Tests would be great. Thanks a lot!

@gyuho thanks, and qq can you please help me understand how you are thinking on using blackhole on client side?. Any thoughts would be helpful. Thanks!


Add interface to allow systems to declare parameters

🎉 New feature
Based on https://github.com/ignitionrobotics/ign-transport/pull/305.
Replacement of https://github.com/ignitionrobotics/ign-gazebo/pull/1280.
Summary

This PR adds:

An interface that can be implemented by systems that allows them to declare parameters (ISystemConfigureParameters):

The gazebo simulation runner creates an instance of ignition::transport::parameters::ParametersRegistry (see https://github.com/ignitionrobotics/ign-transport/pull/305) with a namespace /world/<world_name> that provides the following services:
/world/<world_name>/list_parameters service: List available parameters names and types.
/world/<world_name>/get_parameter service: Get the type and value of a parameter.
/world/<world_name>/set_parameter service: Set a parameter: parameter name, value and type need to be provided.

Summary of what's needed to declare and use a parameter can be seen in the wheel slip demo branch: diff.
Test it

I haven't written automated tests yet, but there's a demo using parameters in the wheel slip plugin:

https://github.com/ignitionrobotics/ign-gazebo/tree/ivanpauno/parameters-component-wheel-slip-demo6
https://github.com/ignitionrobotics/ign-msgs/tree/ivanpauno/parameters-component-wheel-slip-demo8

Steps to run the demo:

Build from source ignition fortress checking out the two branches specified above (I can provide PRs for another version if needed).
Launch the trisphere cycle world:ign gazebo trisphere_cycle_wheel_slip.sdf

In another terminal with the workspace sourced:

List available parameters:
ign param -r /world/wheel_slip -l

Expected output

systems.wheel_slip.trisphere_cycle1.wheel_front            [ignition.msgs.WheelSlipParameters]
systems.wheel_slip.trisphere_cycle1.wheel_rear_right            [ignition.msgs.WheelSlipParameters]
systems.wheel_slip.trisphere_cycle0.wheel_rear_right            [ignition.msgs.WheelSlipParameters]
systems.wheel_slip.trisphere_cycle1.wheel_rear_left            [ignition.msgs.WheelSlipParameters]
systems.wheel_slip.trisphere_cycle0.wheel_rear_left            [ignition.msgs.WheelSlipParameters]
systems.wheel_slip.trisphere_cycle0.wheel_front            [ignition.msgs.WheelSlipParameters]

Get the systems.wheel_slip.trisphere_cycle1.wheel_front parameter:
ign param -r /world/wheel_slip -g -n systems.wheel_slip.trisphere_cycle1.wheel_front

Expected output

Getting parameter [systems.wheel_slip.trisphere_cycle1.wheel_front] for registry namespace [/world/wheel_slip]...
Parameter type [ign_msgs.WheelSlipParameters]

slip_compliance_lateral: 1
slip_compliance_longitudinal: 1

Set the systems.wheel_slip.trisphere_cycle1.wheel_front parameter to a different value:
ign param -r /world/wheel_slip -s -n systems.wheel_slip.trisphere_cycle1.wheel_front -t ign_msgs.WheelSlipParameters -m "
  slip_compliance_lateral: 1
  slip_compliance_longitudinal: 2"

Expected output

Setting parameter [systems.wheel_slip.trisphere_cycle1.wheel_front] for world [wheel_slip]...
Parameter successfully set!

Get the systems.wheel_slip.trisphere_cycle1.wheel_front parameter again, its value should have changed:
ign param -r /world/wheel_slip -g -n systems.wheel_slip.trisphere_cycle1.wheel_front

Expected output

Getting parameter [systems.wheel_slip.trisphere_cycle1.wheel_front] for registry namespace [/world/wheel_slip]...
Parameter type [ign_msgs.WheelSlipParameters]

slip_compliance_lateral: 1
slip_compliance_longitudinal: 2

Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

I've made a prerelease of gz-transport11, so macOS and windows CI is unstable, but Ubuntu will need some extra work for CI to pass. I think this is ready for review

@scpeters I have rebased the PR.

I think this is ready for review

Yes!
Let me know if I should add any reviewer here

I think there are still some linter issues here.

I think there are still some linter issues here.

Could you share in which job you are seeing the failures?
It seems to me that all jobs are failing when building, because the gz-transport changes needed haven't been released yet.
I didn't find linters failures in the jobs' output.
Locally, I also don't see linter failures (though I'm not sure if I have cppcheck configured correctly, as I see a lot of unrelated linter errors).

testing against prerelease of ignition-transport11 with https://github.com/gazebosim/gz-sim/pull/1789

Thanks Steve!
Failures look unrelated to me, let me know if that's not the case.
I think this is ready for review.

Is there a way you could add any tests for these ? Otherwise looks good.

I think I can add some test, I will try to do that in the following days.

This needs a (not-prerelease) transport11 release. Is there anything blocking that at this point?

just the principle of testing with prereleases before we lock in new APIs. I'll open a ci_matching_branch/ PR  to test with prereleases

This needs a (not-prerelease) transport11 release. Is there anything blocking that at this point?

just the principle of testing with prereleases before we lock in new APIs. I'll open a ci_matching_branch/ PR to test with prereleases

I forgot I had already done that with #1789. The Ubuntu CI is building fine but failing with some test failures

Test looks good, but CI is failing with :
 /github/workspace/include/ignition/gazebo/System.hh:28:10: fatal error: ignition/transport/parameters/Registry.hh: No such file or directory
   #include <ignition/transport/parameters/Registry.hh>

Changes here look good to me, waiting for green CI.

I think this was working with the 11.3.0~pre1 prerelease, but it is not working with the 11.3.0 or 11.3.1 stable releases. Investigating...

@osrf-jenkins run tests please

there's a few jobs with failing tests, but there are some clean CI jobs as well

A question for @ivanpauno , is this meant to be used by sensors (or their systems) ? Right now for the wheel slip plugin I can understand that there will be only a single system, but in future if some sensor wants to declare parameters, how should the system separate parameters between sensors ?
For e.g., camera 1 and camera 2 want to have different parameters in the rendering sensors system ? Maybe this is not the intended use case.

My idea is that the system is responsible of correct naming.
My branch with a wheel slip plugin demo is out of date, but it still gives an idea of how to avoid name colisions:
https://github.com/gazebosim/gz-sim/blob/c7ca5a33a450533223908b08b9a18d9ab5d1f723/src/systems/wheel_slip/WheelSlip.cc#L380-L389
e.g. for cameras it could be:
/systems/sensors/cameras/camera1/<param_name>

I think https://github.com/gazebosim/gz-transport/pull/374 should fix it, though it will require another release

Thanks for the fix @scpeters !!!

there's a few jobs with failing tests, but there are some clean CI jobs as well

I have taken a look to the failing jobs and they seem to have unrelated failures.
Let me know if any change is needed here.


Error injecting constructor, java.lang.NoClassDefFoundError: com/exsoloscript/challonge/library/javax/net/ssl/HostnameVerifier

Hi, I was keen to try out this library via Scala (SBT project, so my test project isn't missing dependencies) and it doesn't work.
Same thing happens in this reproducible case with Nashorn:
$ wget http://central.maven.org/maven2/com/exsoloscript/challonge/challonge-java/1.0/challonge-java-1.0.jar
...
$ jjs -cp challonge-java-1.0.jar
jjs> var Challonge = Java.type("com.exsoloscript.challonge.Challonge")
jjs> Challonge.getFor("A", "B")
com.exsoloscript.challonge.library.google.inject.ProvisionException: Unable to provision, see the following errors:
...

I tried this on an OS X machine and a CentOS 7 machine.
The full stack trace is TLDR so pasted here: https://gist.github.com/ScalaWilliam/5b15f653736881b2aad53993b0a55d0b
PS I notice this JAR depends on JUnit as well. Not sure that should be in compile time dependency. It imports hamcrest library, I wasn't sure where that was coming from.

This is odd. It looks like the shaded dependencies are missing. I also thought I had JUnit excluded from the shade process. Weird. I'll look into it, but it might take a while, since I am quite busy at the moment.

The bug you encountered should be fixed. I also removed junit and hamcrest from the shading process.


Add Dockerfile

Follow-up to https://github.com/SubstraFoundation/substra-backend/pull/154
Companion PR: https://github.com/SubstraFoundation/substra/pull/123

1. Build substra image
~/code/substra$ make docker
docker build -f docker/Dockerfile . -t substra:latest
Step 1/9 : FROM python:3.7
[...]
Successfully tagged substra:latest

Note: You can specify the tag to build: make docker DOCKER_TAG=my-version
2. Build substra-tests image
~/code/substra-tests$ make docker
docker build -f docker/Dockerfile . -t substra-tests:latest --build-arg SUBSTRA_VERSION=latest
Step 1/10 : ARG SUBSTRA_VERSION=latest
[...]
Successfully tagged substra-tests:latest

Note:

You can specify the tag to build: make docker DOCKER_TAG=my-version
You can specify the base substra image tag to use: make docker DOCKER_TAG_SUBSTRA=my-version

3. Run the tests
$ docker run -it substra-tests:latest bash
root@36dbccf952d0:/usr/src/app/substra-tests# pytest -rs -q tests/test_execution.py -k test_tuples_execution_on_same_node
.                                                                                [100%]
1 passed, 10 deselected in 12.55s

Thanks @AurelienGasser, looks very good.
I'm just wondering, why depending on the substra image? We could install the substra library using pip. It would make the process to build this image simpler.

@samlesu @ClementGautier The reason not to install substra from pip is that currently pip only contains publicly released versions. In order for a pip version to be created, and if I understood correctly, two conditions must be present:

a git tag must be pushed
substra/__version__.py needs to be bumped

As of writing this, the latest substra version on pip is over 2 months old.
Since this PR is about testing prior to releases, depending on a release creates a circular dependency!
Another reason not to use pip is that it allows us to use custom/forked version of substra, which might be useful later. Although this is speculative so I wouldn't use this to influence decisions.
Both issues would be fixed by setting up a private pip server and a mechanism to push arbitrarily to it. But since there's no such server currently, the solution in this PR addresses the issues.

@ClementGautier I'm addressing your other suggestions, thanks!

@samlesu Sounds like a great solution, let me give it a shot

@ClementGautier any thoughts/improvement ideas?


Performance issue in concurrency mode with maxWorkers=4, keepAlive=true, warmUpWorkers=true

I noticed some performance issue configuring a pool of websocket in this way:

createEasyWebWorker(
[ new Worker(new URL('path to my static file', import.meta.url)) ],
{
workerOptions: { type: 'module' },
maxWorkers: 4,
keepAlive: true,
warmUpWorkers: true,
})

Basically here I would like to create a pool of 4 web-workers at the beginning of the configuration phase as the parameter warmUpWorkers suggests.
Unfortunately from the tests I did it seems that the pool is not created immediately and this ends up with performance issue running the test application.
As a workaround my pseudo-code now looks like this one:

let ws = [];
for (let idx = 0; idx < 4; ++idx) {
ws.push(new Worker(new URL('path to my static file', import.meta.url)));
}
return createEasyWebWorker(
ws,  // that is an array of 4 elements
{
workerOptions: { type: 'module' },
maxWorkers: 4,
keepAlive: true,
warmUpWorkers: true,
})

that seems to work correctly.
I am not 100% sure this could be considered a bug (properly speaking), but something to share if anyone else needs...

Hi @robertomonno77,
Thank you so much for reporting this, and you're absolutely right! The configuration wasn't being properly applied for concurrent mode, and the warmup process was being ignored. I’ve made the necessary changes.
The only case where the configuration will still be ignored is when working with an array of workers, which must be kept alive as there is no way to restore them once terminated.
To summarize, for your initial use case, everything should be working as expected now.
const worker = new EasyWebWorker(new URL('path to my static file', import.meta.url),
  {
    workerOptions: { type: 'module' },
    maxWorkers: 4,
    warmUpWorkers: true,
    keepAlive: true,
  }
);

The previous config will warm up 4 workers and keep them alive.


Does Visual Studio Code support searching by Class in typescript?

I know you can search a file by class name in other IDE like webstorm. Does visual studio code support it or plan on supporting it?

Yes - by default it works for C# and TypeScript and can be invoked with Cmd+T. Other extension can contribute via the WorkspaceSymbolProvider

Is there any way to merge/union it with searching by file?

I believe that is     "search.quickOpen.includeSymbols": true,