MultiCurl->beforeSend() with retry

Hi.
Code:
        // Curl
        $curl = new Curl();

        $curl->beforeSend(function (Curl $instance) {
            echo 'Message from beforeSend callback' . PHP_EOL;
        });

        $curl->setRetry(function (Curl $instance) {
            echo $instance->getHttpStatusCode() . ' | ' . $instance->url . PHP_EOL;
            return $instance->retries < 1;
        });

        $curl->get('https://httpbin.org/status/503');

        //MultiCurl
        $multi_curl = new MultiCurl();

        $multi_curl->beforeSend(function (Curl $instance) {
            echo 'Message from beforeSend callback' . PHP_EOL;
        });

        $multi_curl->setRetry(function (Curl $instance) {
            echo $instance->getHttpStatusCode() . ' | ' . $instance->url . PHP_EOL;
            return $instance->retries < 1;
        });

        $multi_curl->addGet('https://httpbin.org/status/503');
        $multi_curl->addGet('https://httpbin.org/status/503');

        $multi_curl->start();

Output:
Curl
Message from beforeSend callback -> first attempt
503 | https://httpbin.org/status/503
Message from beforeSend callback -> second attempt
503 | https://httpbin.org/status/503
MultiCurl:
Message from beforeSend callback -> first attempt
Message from beforeSend callback -> first attempt
503 | https://httpbin.org/status/503
503 | https://httpbin.org/status/503
-> missed messages from second attempt
503 | https://httpbin.org/status/503
503 | https://httpbin.org/status/503
Thank you

Hello. Thanks for the answer. I would like to see the same behavior in MultiCurl. It seems logical to me.

I would like to see the same behavior in MultiCurl. It seems logical to me.

Agreed. However, this change will need to be included in a major version bump.

Any workaround until patched?

Hi, @zachborboa can we get a patch for this?


nvidia-drivers-lts missing dependency

attempting to launch nvidia-settings results in Error while loading shared library: libjansson.so.4 : cannot open shared object file: no such file or directory.
Needs package:
dev-libs/jansson

dev-libs/jansson should be added to layers/X

In my tests on a stable install, it works fine now.


Prune and DelMsg conflict

I got this error after a prune failed. It works after.

On top of that: a .timely with delmsg enabled:


Custom Propagator not working

Description
We want to create a new propagator to fetch traceid/spanid from a URL, I create a new propagator and assign it to the instrumentation but I never see my code being executed.
Steps to reproduce
class UrlPropagator  {
    fields() {
        return ['traceid', 'spanid'];
    }

    inject(context, carrier: unknown, setter: TextMapSetter): void {
    }

    extract(context, carrier, getter) {
        const traceId = getter.get(carrier, 'traceId');
        const spanId = getter.get(carrier, 'spanId');
        console.log("extract: ", traceId, spanId)
        if (!traceId || !spanId) {
            return context;
        }
        const spanContext = {
            traceId,
            spanId,
            traceFlags: TraceFlags.SAMPLED,
        };
        console.log("spanContext: ", spanContext)
        return trace.setSpanContext(context, spanContext);
    }
}

...initializeFaro
new TracingInstrumentation({
      propagator: new UrlPropagator()
}),

Expected behavior
We expect the propagator be executed and at least see the console.log
Actual behavior
The propagator it's never executed

I think the Web SDK is behaving correctly in this case.
The intention of a propagator is to extract information from an incoming request and to inject information into an outgoing request. OpenTelemetry tracing propagates context forward, not backwards.
Ref: https://opentelemetry.io/docs/specs/otel/context/api-propagators/#extract

Extracts the value from an incoming request. For example, from the headers of an HTTP request.

In case the intention is to capture every interaction in a single trace, the OpenTelemetry docs list an example how to map a server-started trace and use it as root-span for your browser level tracing needs. https://opentelemetry.io/docs/instrumentation/js/getting-started/browser/#example-application
We are exploring ways to connect client side events stronger with server side context by using a lose coupling. We are tracking #216 which captures the initial ideation around using server-timing http headers and enhancements to our new fetch instrumentation to create the context necessary.

@facucus @cedricziel Can we close this issue or is anything left to clarify?


Regression in jcouyang/dhall-generic for implicit search

Based on OpenCB failures in jcouyang/dhall-generic - build logs
The compiler fails to search for implicit instances defined in companion of the typeclass. It requires explicit import at the place of usage
Compiler version
Last good release: 3.5.0-RC1-bin-20240406-521ce95-NIGHTLY
First bad release: 3.5.0-RC1-bin-20240408-1e8a653-NIGHTLY
The compilation errors when building compiler prevented gathering the exact commit that coused regression it can be any of:
d2a6392131001af941b0614c9e6d812e8c761965
1dc5b995cfb84dd3e2673041d6e954ed6043900e
321d0d2cdee757fe311c9959817794acaad0fbdb
1e8a653cce58ddb038c04a906448db92172828dd
The project-wise bisect nominated 90c3fbde37a70fdd366ed25d2082e05ddf24ac3e as the cause of the regression
Minimized code
Needs to be defined as 2 compilation units
I was able to reproducer Decoder[Empty] in single file, but the other cases required definitions and usage to be split in previous Scala versions.
// 1_defns.scala
import scala.compiletime.*
import scala.deriving.*

sealed trait Decoder[T]
object Decoder:
  inline given summonEmptyTuple[H]: Tuple.Map[EmptyTuple.type, Decoder] = EmptyTuple
  inline given summonTuple[H, T <: Tuple](using
      hd: Decoder[H],
      td: Tuple.Map[T, Decoder]
  ): Tuple.Map[H *: T, Decoder] = hd *: td
  inline given derived[T](using
      m: Mirror.Of[T],
      d: Tuple.Map[m.MirroredElemTypes, Decoder]
  ): Decoder[T] = ???
  given Decoder[Double] = ???

// 2_usage.scala
case class Empty()
object Empty {
  val fails = Decoder.derived[Empty]
}

enum Shape:
  case Rectangle(width: Double, height: Double)
  case Circle(radius: Double)

object Shape:
  val fails1 = Decoder.derived[Rectangle]
  val fails2 = Decoder.derived[Shape]

Output
-- [E172] Type Error: /Users/wmazur/projects/sandbox/repro.test.scala:4:39 -----
4 |  val instance = Decoder.derived[Empty]
  |                                       ^
  |No given instance of type Tuple.Map[m.MirroredElemTypes, Decoder] was found for parameter d of given instance derived in object Decoder
  |
  |Note: a match type could not be fully reduced:
  |
  |  trying to reduce  Tuple.Map[m.MirroredElemTypes, Decoder]
  |  failed since selector m.MirroredElemTypes
  |  does not match  case EmptyTuple => EmptyTuple
  |  and cannot be shown to be disjoint from it either.
  |  Therefore, reduction cannot advance to the remaining case
  |
  |    case h *: t => Decoder[h] *: Tuple.Map[t, Decoder]
-- [E172] Type Error: /Users/wmazur/projects/sandbox/repro.test.scala:12:38 ----
12 |  val rec = Decoder.derived[Rectangle]
   |                                      ^
   |No given instance of type Tuple.Map[m.MirroredElemTypes, Decoder] was found for parameter d of given instance derived in object Decoder.
   |I found:
   |
   |    Decoder.summonTuple[Double, Double *: EmptyTuple.type](
   |      Decoder.given_Decoder_Double,
   |      Decoder.summonTuple[Double, EmptyTuple.type](Decoder.given_Decoder_Double,
   |        /* missing */summon[Tuple.Map[EmptyTuple.type, Decoder]])
   |    )
   |
   |But no implicit values were found that match type Tuple.Map[EmptyTuple.type, Decoder].
   |
   |Note: a match type could not be fully reduced:
   |
   |  trying to reduce  Tuple.Map[m.MirroredElemTypes, Decoder]
   |  failed since selector m.MirroredElemTypes
   |  does not match  case EmptyTuple => EmptyTuple
   |  and cannot be shown to be disjoint from it either.
   |  Therefore, reduction cannot advance to the remaining case
   |
   |    case h *: t => Decoder[h] *: Tuple.Map[t, Decoder]
3 errors found

Expectation
Should compile

I believe this is an expected error. Or at least, we intended for it to be an error in #20077.
The i15183 test looks to be a very similar minimisation as above, it was changed in the PR to account for the fix in determining implicit scope.
TLDR the regression is necessary for the implicit scope to be the same for joint vs separate compilation.
I believe it would be fixed here too by adding an import Decoder.given in 2_usage.scala.


cocomac: Watch royalaces88.org

cocomac requests the watch of the watch_keyword royalaces88\.org. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

royalaces88\.org has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by Makyen in Charcoal HQ. Reason: 'I made a separate watch for this, because I didn't notice the PR had been created.'


✨Figma-broker export small icons

resolves #1826
New IconData used in eds-icons looks something like this for icons with small icons:
export const fullscreen: IconData = {
  name: 'fullscreen',
  prefix: 'eds',
  height: '24',
  width: '24',
  svgPathData:
    'M7 10H5V5h5v2H7v3zm-2 4h2v3h3v2H5v-5zm12 3h-3v2h5v-5h-2v3zM14 7V5h5v5h-2V7h-3z',
  sizes: {
    small: {
      name: 'fullscreen_small',
      prefix: 'eds',
      height: '18',
      width: '18',
      svgPathData:
        'M5 7H3V3h4v2H5v2zm-2 4h2v2h2v2H3v-4zm10 2h-2v2h4v-4h-2v2zm-2-8V3h4v4h-2V5h-2z',
    },
  },
}

Lets see how this format feels and revise it again in #1827.
Did not update the svg files, as I would like a separate issue for that as we already have a lot of changes in this PR. For now they will be exported as separate files with _small ending. Like so: fullscreen_small. Follow up #1885

Functionality-wise everything seems to be working as expected, and I agree with the format at this point. Meanwhile there are a couple of areas where I think the legibility of the code could be improved by being consistent in the use of empty lines, so I would go over that real quick – apart from that it LGTM 👍🏻

Yeah, I was hoping to rewrite the code to typescript and in that regards also improve the legibility, as some parts of the code were made to support features we no longer have.

Also, here’s an example we can learn from when it comes to deprecating things 😉

Hehe, yeah, we should really start using jsdoc to its strengths., we have an issue for this here: #801
I have written down to add issue for updating svgo and re-write figma-broker to typescript. Good reminder to add those to the backlog :)

Added followup issues #1885 #1886 #1887


Improvement to mutual SSL feature when Gateway is fronted with LB

Describe your problem(s)
Feature to validate certificate sent in header is added to 3.1.0 in [1], it needs to be back-ported to 2.6.0 to validate certificate received from LB.
[1] https://github.com/wso2/carbon-apimgt/pull/8145

Fixed with https://github.com/wso2/carbon-apimgt/pull/8145/files


MultiLineString - LineString

Hi Matt
Having done some tests over the last few days I believe the geometry definition for the topographicline table should be LINESTRING
https://github.com/AstunTechnology/Loader/blob/master/extras/ordnancesurvey/osmm/topo/pgdump/create-tables.sql
When I used your version of create-tables.sql, loader through an error
Cheers
Tim

Leaving as MULTILINESTRING following discussion with @TimJMartin


Simplify ordering of execute steps

The current ordering of execute steps is overly complex and doesn't even work all the time as demonstrated by https://github.com/Microsoft/vscode-azurefunctions/issues/1137. I changed it so that the order is based on a simple priority property that must be defined in each execute step. I definitely wish I had done it this way in the first place because it feels so much more intuitive, flexible, and simple.

I was referring to an assert/exception, although console.warn would be fine.  It’s up to you if you think it makes sense or not.
From: Eric Jizba<EMAIL_ADDRESS>Sent: 29 March, 2019 4:23 PM
To: Microsoft/vscode-azuretools<EMAIL_ADDRESS>Cc: Stephen Weatherford<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode-azuretools] Simplify ordering of execute steps (#463)
@EricJizbaMSFT commented on this pull request.

In ui/src/wizard/AzureWizard.tshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode-azuretools%2Fpull%2F463%23discussion_r270598546&data=02|01|Stephen.Weatherford%40microsoft.com|503ac42ce4c046be499108d6b49d84c6|72f988bf86f141af91ab2d7cd011db47|1|0|636894985964529991&sdata=GWmHaKz6Y%2BpIL3cskjoeAktDt%2FecFrlyoRafhBwoA8s%3D&reserved=0:

@@ -91,7 +88,7 @@ export class AzureWizard implements types.AzureWizard, IInternalAzureWizar

     await vscode.window.withProgress({ location: vscode.ProgressLocation.Notification }, async progress => {

         let currentStep: number = 1;

       const steps: AzureWizardExecuteStep<T>[] = getExecuteSteps(this._wizardNode);

       const steps: AzureWizardExecuteStep<T>[] = this._executeSteps.sort((a, b) => b.priority - a.priority);

Not sure what you mean by "warn":

I don't want to do vscode.window.showWarningMessage because I'm guessing most cases will work just fine even if there's duplicate priorities and this feels like it would "block" those cases
I'm not opposed to console.warn, but I wouldn't add it myself. Just a personal preference to avoid console.* in production code

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode-azuretools%2Fpull%2F463%23discussion_r270598546&data=02|01|Stephen.Weatherford%40microsoft.com|503ac42ce4c046be499108d6b49d84c6|72f988bf86f141af91ab2d7cd011db47|1|0|636894985964539996&sdata=nQTyreQ7rGnQ8koP4fI99ue5w%2FmFznNdYMUblORrslg%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGl9SoBc94GoXW-lugRfQ6ydMl3cmzLFks5vbqBigaJpZM4cTQI5&data=02|01|Stephen.Weatherford%40microsoft.com|503ac42ce4c046be499108d6b49d84c6|72f988bf86f141af91ab2d7cd011db47|1|0|636894985964550010&sdata=2iSHIS6nzmS5QTrYvOiXeRerh%2BNrQ3TMtzwWHy%2B9HgE%3D&reserved=0.


AYS: Make RETRY_DELAY fixed to 10 seconds endlessly in "Development Mode"

Currently when a run fails it first reties after 10 seconds, then after 1 minute, ....
RETRY_DELAY = {
    1: 10,  # 30sec
    2: 60,  # 1min
    3: 300,  # 5min
    4: 600,  # 10min
    5: 1800,  # 30min
    6: 1800,  # 30min
}

This is exactly what we need when running AYS in production, but it is very cumbersome in development. Because after fixing the code the developer want to see it go again as soon as possible without to much hassle.
This is of course only possible and depending on this FR: https://github.com/Jumpscale/jumpscale_core8/issues/856

implemented in https://github.com/Jumpscale/jumpscale_core8/pull/860


Redis scalers are not shown when searched

Expected Behavior
Show results when a specific scaler is searched.
Bug introduced by #805
Actual Behavior
Tried using the Redis keyword to search through the scaler list and no result was shown.
Steps to Reproduce the Problem

Navigate to the scaler's page
search "Redis"
Notice that it returns no results even though is present on the scaler's list

Specifications

KEDA Version: Please elaborate
Platform & Version: Please elaborate
Kubernetes Version: Please elaborate
Scaler(s): Please elaborate

I tried a few queries, and they showed up with no results as well.

I tried a few queries, and they showed up with no results as well.

Seems to be some problem with spaces.

Duplicate of #857 as this is more than just Redis


Check out await-sync - replace child process with WebWorkers

I just created this async-to-sync package today that i named await-sync
it utilize web workers instead of spawning sync processes and data is transfered synchronous over SharedArrayBuffer so less code needs to be copied over.
Therefore it's also more compatible with other enviorments like Deno, Bun, and also Web Workers.
it's as simple as just doing:
import { createWorker } from 'to-sync'

const awaitSync = createWorker()

const fetchSync = awaitSync(async function (...args) {
  const res = await fetch(...args)
  const ab = await res.arrayBuffer()
  return new Uint8Array(ab)
})

const uint8 = fetchSync(url)
const text = new TextDecoder().decode(uint8)
const json = JSON.parse(text)
const blob = new Blob([uint8])

if you would use this instead then your package would have the possibility of being able to run in Deno, Bun.js and also Web Workers. but why web workers when you sync xhr...? that's a good question...

I think someone else might have mentioned web workers before. I haven't used Deno or Bun but I'm not against supporting that. I think the main doubt I had was the same as what you mention:

but why web workers when you sync xhr...? that's a good question...

But there's actually a clear answer to that: sync xhr has a bunch of limitations, including not allowing binary responses and (at least in the past) some cryptic, undocumented CORS restrictions.

I've implemented the trick for binary data from MDN that you mentioned, it's released in v0.4.4.


20200423 change #3: Fixed some mistakes and inconsistencies in CLIC Implementation Parameters

Draft 20200423 – separating multiple changes as individual issues to enable change tracking/approval from draft-20200423 doc upload.
20200423 change #3: Fixed some mistakes and inconsistencies in CLIC Implementation Parameters
Was:
Name           Value Range                     Description
CLICCFGLBITS   0-ceil(lg2((lg2(CLICLEVELS))))  Number of bits implemented for cliccfg.nlbits
CLICMNXTI      0-1                             Has mnxti CSR implemented?
CLICMCSW       0-1                             Has mscratchcsw/mscratchcswl implemented?
Changed to:
CLICCFGLBITS   0-ceil(lg2(CLICLEVELS))         Number of bits implemented for cliccfg.nlbits
CLICXNXTI      0-1                             Has xnxti CSR implemented?
CLICXCSW       0-1                             Has xscratchcsw/xscratchcswl implemented?

changed M to X to represent m,s,u.  See issue Script m vs plain m #32
closing here.


We have moved to generate the lib.d.ts from the webidl spec instead of from the Edge webidl spec. the result of that is many vendor speciifc declarations are removed and only declarations part of the spec are left behind.

The recommendation for the vendor specific properties is to define in them locally in a .d.ts file.
Originally posted by @mhegazy in https://github.com/Microsoft/TypeScript/issues/25515#issuecomment-403897228

Can you provide a clear way to migrate
?

@DanielRosenwasser did we ever put up a guide for this?

@weswigham I did dig dipper around the we I could not find a clear way, my usercase is I am using angular 7.1 and it use latest typescript where those web spec can not be found.

It's cumbersome, but why is creating a webkit.lib.d.ts file, redefining the missing types, and adding them to your project not currently working?


mhddfs: init at 0.1.39

travis seemed to have died due to "error: getting status of ‘/home/travis/build/NixOS/nixpkgs/pkgs/os-specific/linux/miraclecast’: No such file or directory"
@pSub for #11008 the version is also missing in the name, should i create a new PR for this?

@makefu yeah, please make a PR for https://github.com/NixOS/nixpkgs/pull/11008, that was my mistake that I haven't seen that there is no version in the name. Thank you!

For #11008 this is fixed in 59bb76e8945841bffd40c286794a2022748a3910.

@psub i fixed the version issue for this package saturday, thanks for fixing the snapraid package :)

Thanks. This PR looks good now. I will merge.


Multiple GitHub Issue Fixes

Issues
3, 4, 5, 6

@chrischildresssg I've tested it in my current customers environment, it's building the plan all the way into stg and has successfully deployed into dev.


Draw interaction does not work as expect when there is a select interaction

diff --git a/examples/draw-features.js b/examples/draw-features.js
index b7cb4ce..5f13bae 100644
--- a/examples/draw-features.js
+++ b/examples/draw-features.js
@@ -2,6 +2,7 @@ goog.require('ol.Map');
 goog.require('ol.View');
 goog.require('ol.geom.Polygon');
 goog.require('ol.interaction.Draw');
+goog.require('ol.interaction.Select');
 goog.require('ol.layer.Tile');
 goog.require('ol.layer.Vector');
 goog.require('ol.source.MapQuest');
@@ -46,6 +47,8 @@ var map = new ol.Map({
   })
 });

+map.addInteraction(new ol.interaction.Select());
+
 var typeSelect = document.getElementById('type');

 var draw; // global so we can remove it later

Is there an obvious reason why this combination of interactions should be avoided?

Also, this does not happen if the layer is unmanaged. If the layer is managed, you can see the above effect.

This line is causing the observed behaviour: https://github.com/openlayers/ol3/blob/master/src/ol/interaction/selectinteraction.js#L257

In the end I made sure in my application I did not have these two interactions active at the same time. Workaround though.

Can you reference the faulty logic me in selectinteraction.js for the revision in question instead of master? The line on master is a JSDoc comment.


Fix incomplete list of CLU Prebuilt entities

When creating a Prebuilt entity via the portal for an English (UK) project, I am offered a number of prebuilt entity types not listed on this page. I've listed out the ones I think are missing. Could they be added please?
Choice.Boolean
General.Event
General.Organization
Geography.Address
Geography.Location
IPAddress
Person.Name
Quantity.NumberRange

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 61591de7-77ec-5c44-99f8-2884e092a4f3
Version Independent ID: 4eca8b47-473a-f9df-f9b6-ff7f9f591f53
Content: Supported prebuilt entity components - Azure Cognitive Services
Content Source: articles/cognitive-services/language-service/conversational-language-understanding/prebuilt-component-reference.md
Service: cognitive-services
Sub-service: language-service
GitHub Login: @aahill
Microsoft Alias: aahi

@Zaragor
Thanks for your feedback! We will investigate and update as appropriate.

@aahill
Could you please review add comments on this, update as appropriate.

Thanks for letting us know about this issue @Zaragor . I'll go through and add the missing entities to the documentation.
#please-close


Improve clues

The level of the clues different widely day to day. Is it possible to make it more consistent? Additionally, remove where we are travelling from since that is confusing.
Also save all destination with clues and store points ppl got to better evaluate the difficulty of the clues.

Could we add another llm to solve the clues and provide feedback for a second refine clue step.

I added some prompt updates in #24 Enough?

Now it is a good level. Solved


How to retrieve optional properties when calling getChat

When calling getChat with an ID, it works perfectly to get the basic properties:
    this.client.getChat(chatId).then(res => {       console.log(res)     })

but if I want to get back additional properties such as pinned_message, there is not any clear documentation on how to do this and I have tried all the combinations I can think of.  How can I make this happen?  I assume its with the optional param to getChat, but I can't figure out how that needs to be formatted.

Optionals parameters are filled only if present generally.
pinned_message is a Message object.

Ok then if thats how it should be working there must be an issue with the library or API.  Myself and others have both tried to call getChat on a chat with a pinned_message, but it is not returned.  Any ideas?

Have you tried with a bot set as administrator?

Have you tried with a bot set as administrator?

Yes

  id: XXX,
  title: 'XXX',
  type: 'group',
  permissions: {
    can_send_messages: true,
    can_send_media_messages: true,
    can_send_polls: true,
    can_send_other_messages: true,
    can_add_web_page_previews: true,
    can_change_info: true,
    can_invite_users: true,
    can_pin_messages: true
  },
  all_members_are_administrators: true
}```

This is the entire object I get back

The problem is that the field is filled only in supergroups, your group type is group.
"getChat now also returns pinned messages in supergroups, if present. Added the new field pinned_message to the Chat object."

I updated to supergroup and its still same
  id: XXX,
  title: 'XXX',
  type: 'supergroup',
  permissions: {
    can_send_messages: true,
    can_send_media_messages: true,
    can_send_polls: true,
    can_send_other_messages: true,
    can_add_web_page_previews: true,
    can_change_info: true,
    can_invite_users: true,
    can_pin_messages: true
  }
}

Try with pin a new message when supergroup.

Yep it is working now, thank you so much


update highcharts to 2.1.9

Fix a few bugs involving rendering

Thanks!
Hadn't noticed Highcharts was updated. Pulled the updated JavaScript, but I like to keep a global .gitignore with platform-specific files like .DS_Store and so on.
(Hope I managed to do it properly…)

Thanks, working great for us! Makes sense with the .DS_Store, we're going to set that up as well.


Document API - toward a common understand for MVP

NAME
ABOUT
TITLE
LABELS

Document API / MVP Development
Describe the current understanding of the end points that need to be defined to achieve a MVP version of the FAM API
Document API MVP
enhancement

As a *Developer and or architect * I want communicate api requirements for an MVP So That we can prioritize future development, and ensure there is a common understanding about how the api will function
Additional Context
As development of the user / role end points have progressed, we have realized that we do not have a common understanding around how the data model should work, and how it will be used to back the api.
Hoping that discussion of the documentation will eliminate any misunderstandings.  The document that is being produced will likely initially contain many errors.  Its intent is to clarify these misunderstandings and resolve them.
Acceptance Criteria

[ ] Everyone on the team has read, and understands at least at a high level the requirements for MVP.
[ ]  The document can serve to define an EPIC for FAM MVP

Definition of Done

[ ] Ready to Demo in Sprint Review
[ ] Does what I have made have appropriate test coverage?
[ ] Documentation and/or scientific documentation exists and can be found
[ ] Peer Reviewed by 2 people on the team
[ ] Manual testing of all PRs in Dev and Prod
[ ] Merged

Documentation page exists here:
https://github.com/bcgov/nr-forests-access-management/wiki/FAM-API-Common-Understanding-MVP
To be completed:

define the user end points and how the relate to the existing end points
Review document with FAM team.
Edit and remove any errors

Read through a few times, added some comments, new sections.  As continue work on it feel like we need to have a conversation about this before any more work is completed on this document.   too many unknowns to be able to proceed.
Example:

can roles exist independent of application
can groups exist independent of application

Propose that a result of out latest sprint planning meeting we call this done for now?  @gormless87 / @ArogeG


Add an issue template

This PR introduces 3 significant additions to this repository:

It includes a standardized issue template to assist users in creating their issue descriptions.
It provides a link to an official CodeSandbox that is synced with next-template.
It encourages contributors to provide comprehensive and relevant information about their issues.

@shadcn, please review and let me know your thoughts. Do you want to implement this issue template? If so, are there any additional fields, rules, or updates you would like to include?

@shadcn do you think it'll be helpful to get this merged to bring some structure to the filed issues?


Tidy up data setup in tests

Using get_one, etc. Could have used the built in object instantiation. Tidy them up.

Also add teardowns to all integration tests.


During uptodate ness check with buildInfo, check if there are errors explicitly with noEmit

Fixes #50959

Do we know when this fix will be released? Looks like it didn't quite make it into 4.8.4. We are stuck on 4.7 until it's out.


Allow external redirects to victimandwitnessinformation.org.uk

This allows users to feature "Victim and Witness Information" content on their organisation homepage.
Requested (and approved by Policy & Strategy) in
https://govuk.zendesk.com/agent/tickets/5632486.
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

Thanks @ryanb-gds - as discussed offline, looks like I updated the wrong allowlist! Have force-pushed, please give this another ✅ when you're ready.
I've kicked off a discussion with P&S around merging the two lists, and then as discussed, I'm hoping to extract the combined allowlist out to govuk_app_config and remove the duplication from Short URL Manager and Publishing API.


check if parse correct.

check if parse correct.

Why are these changes needed?

Related issue number

Checks

[ ] I'm working against the latest source on the experimental branch.
[ ] I've run scripts/format.sh to lint the changes in this PR.
[ ] I've included any doc changes needed.
[ ] I've made sure the tests are passing. Note that there might be a few flaky tests.
Testing Strategy

[ ] Unit tests
[ ] Release tests
[ ] This PR is not tested :(

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

parse failure.


quay.io/centos/centos:stream8 is outdated

Installing okd 4.9.0 by kubeinit 2.0.1 fails at TASK [kubeinit.kubeinit.kubeinit_services : Install python3]
TASK [kubeinit.kubeinit.kubeinit_services : Install python3] *************************************************************************************************************
fatal: [localhost -> hypervisor-01(drejmar.eu)]: FAILED! => {"changed": false, "cmd": ["podman", "exec", "io-credentials", "dnf", "install", "-y", "python3", "openssh"], "delta": "0:00:05.076773", "end": "2022-01-06 13:12:13.625189", "msg": "non-zero return code", "rc": 132, "start": "2022-01-06 13:12:08.548416", "stderr": "", "stderr_lines": [], "stdout": "Last metadata expiration check: 0:00:49 ago on Thu Jan  6 12:11:20 2022.
Dependencies resolved.
This series of commands tends to cause the issue:
podman run --rm -i -t quay.io/centos/centos:stream8
[root@9a064fce332f /]# dnf
[root@9a064fce332f /]# dnf update -y
Transaction Summary
Install  37 Packages
Upgrade  60 Packages
[root@9a064fce332f /]# dnf
[root@9a064fce332f /]# dnf install python3 -y
Transaction Summary
Install  4 Packages
Total download size: 1.8 M
Installed size: 7.2 M
Downloading Packages:
(1/4): python3-pip-9.0.3-22.el8.noarch.rpm                                                                                377 kB/s |  20 kB     00:00
(2/4): python36-3.6.8-38.module_el8.5.0+895+a459eca8.x86_64.rpm                                                             347 kB/s |  19 kB     00:00
(3/4): python3-setuptools-39.2.0-6.el8.noarch.rpm                                                                           1.8 MB/s | 163 kB     00:00
(4/4): platform-python-pip-9.0.3-22.el8.noarch.rpm                                                                          7.3 MB/s | 1.6 MB     00:00
Total                                                                                5.7 MB/s | 1.8 MB     00:00
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
Preparing        :                                                                                1/1
Installing       : python3-setuptools-39.2.0-6.el8.noarch                                                                                1/4
Installing       : platform-python-pip-9.0.3-22.el8.noarch                                                                                2/4
Installing       : python36-3.6.8-38.module_el8.5.0+895+a459eca8.x86_64                                                                               3/4
Running scriptlet: python36-3.6.8-38.module_el8.5.0+895+a459eca8.x86_64                                                                               3/4
Installing       : python3-pip-9.0.3-22.el8.noarch                                                                                4/4
Running scriptlet: python3-pip-9.0.3-22.el8.noarch                                                                                4/4
Verifying        : python3-pip-9.0.3-22.el8.noarch                                                                                1/4
Verifying        : python36-3.6.8-38.module_el8.5.0+895+a459eca8.x86_64                                                                               2/4
Verifying        : platform-python-pip-9.0.3-22.el8.noarch                                                                                3/4
Verifying        : python3-setuptools-39.2.0-6.el8.noarch                                                                                4/4
Installed:
platform-python-pip-9.0.3-22.el8.noarch                        python3-pip-9.0.3-22.el8.noarch           python3-setuptools-39.2.0-6.el8.noarch
python36-3.6.8-38.module_el8.5.0+895+a459eca8.x86_64
Complete!
Illegal instruction
[root@9a064fce332f /]# dnf
Traceback (most recent call last):
File "/usr/bin/dnf", line 57, in
from dnf.cli import main
File "/usr/lib/python3.6/site-packages/dnf/init.py", line 30, in
import dnf.base
File "/usr/lib/python3.6/site-packages/dnf/base.py", line 32, in
from dnf.comps import CompsQuery
File "/usr/lib/python3.6/site-packages/dnf/comps.py", line 36, in
import libcomps
File "/usr/lib64/python3.6/site-packages/libcomps/init.py", line 1, in
from ._libpycomps import *
ImportError: /usr/lib64/python3.6/site-packages/libcomps/_libpycomps.so: invalid ELF header
Can you use
tgagor/centos:stream8
instead?

Thanks for your reply.
This is the series of commands which caused the issue several times (yesterday):
dnf update -y
dnf install python3 -y
dnf install openssh -y
Image was deleted between trials:
podman rmi quay.io/centos/centos:stream8
Untagged: quay.io/centos/centos:stream8
Deleted: dc28896b677ede1d5bd9f7d596807c14aaf3f3acf2abf4b4d19dcd0e5d3211fb
podman run --rm -i -t quay.io/centos/centos:stream8
Trying to pull quay.io/centos/centos:stream8...
Getting image source signatures
Copying blob 203c612978b4 done
Copying blob e3ff3ac72de5 done
Copying blob 5186e8704530 done
Copying blob 758c773fb4aa done
Copying config dc28896b67 done
Writing manifest to image destination
Storing signatures
Today I cannot reproduce it.
My guess is that some file is/was faulty on one of centos mirrors. Today I cannot prove this, because I downloaded it from all known mirrors in Germany and its contents were intact:
wget http://de.mirrors.clouvider.net/CentOS/8-stream/BaseOS/x86_64/os/Packages/python3-libcomps-0.1.16-2.el8.x86_64.rpm -O python3-libcomps.rpm.101
...
wget https://mirrors.xtom.de/centos/8-stream/BaseOS/x86_64/os/Packages/python3-libcomps-0.1.16-2.el8.x86_64.rpm -O python3-libcomps.rpm.134
diff python3-libcomps.rpm.101 python3-libcomps.rpm.102
...
diff python3-libcomps.rpm.101 python3-libcomps.rpm.134
dnf provides /usr/lib64/python3.6/site-packages/libcomps/_libpycomps.so
python3-libcomps-0.1.18-1.el8.x86_64 : Python 3 bindings for libcomps library
Repo        : baseos
cat /var/log/dnf.librepo.log | grep libcomps
2022-01-16T08:13:45+0000 INFO Downloading: http://ftp.hosteurope.de/mirror/centos.org/8-stream/BaseOS/x86_64/os/Packages/libcomps-0.1.18-1.el8.x86_64.rpm
2022-01-16T08:13:45+0000 INFO Downloading: http://ftp.hosteurope.de/mirror/centos.org/8-stream/BaseOS/x86_64/os/Packages/python3-libcomps-0.1.18-1.el8.x86_64.rpm
2022-01-16T07:38:31+0000 INFO Downloading: http://centos.schlundtech.de/8-stream/BaseOS/x86_64/os/Packages/libcomps-0.1.18-1.el8.x86_64.rpm
2022-01-16T07:38:31+0000 INFO Downloading: http://centos.schlundtech.de/8-stream/BaseOS/x86_64/os/Packages/python3-libcomps-0.1.18-1.el8.x86_64.rpm
2022-01-16T07:46:44+0000 INFO Downloading: http://ftp.rz.uni-frankfurt.de/pub/mirrors/centos/8-stream/BaseOS/x86_64/os/Packages/libcomps-0.1.18-1.el8.x86_64.rpm
2022-01-16T07:46:45+0000 INFO Downloading: http://ftp.rz.uni-frankfurt.de/pub/mirrors/centos/8-stream/BaseOS/x86_64/os/Packages/python3-libcomps-0.1.18-1.el8.x86_64.rpm
https://pastebin.com/xKimWaNJ
I would still suggest that you use
tgagor/centos:stream8
image, because it's updated weekly

@drejmar I opened an issue against the centos releng-tools project.  They have updated the image at quay and have indicated that they will continue to do so in the future.

@gmarcy Thanks for resolving this


[designsystem] Fix display compatibility with nuxt playground

Since PrimeVue v4 is used, some components are broken,
and
since translation has been updated to use a new root key locokit, the playground is not up to date anymore.
This issue is here to track updates on components and translation's keys.

After some coding with @Lonnytunes , we change the goal of the design system.
As we encounter too much difficulties with nuxt, we are updating the stack.
The app of LocoKit (back office, and maybe front office too) will be a SPA VueJS.
The @locokit/designsystem become @locokit/vue-components to be more predictable.
We give up the nuxt ecosystem as we don't feel any advantage at the DX level, and maybe the "killer app" features like SSR/SSG is not needed for now on LocoKit project. So we'll see in the future if it's really a must-have feature. And there are alternatives, like vike-vue or simply SSR functions provided by VueJS.


Bump wavelink3.4

Here is a polished and organized version of your release notes:

Release Notes
New Features

reset_filters Command: Resets equalizer, speed, and volume settings.
Autoplay Commands: Added autoplay and queue_autoplay commands. #15
Track Information: On track start, send an embed with track information.

Enhancements

Equalizer and Speed: Refactored due to new Wavelink version.
pause and resume: Merged into just pause which acts as a toggle command.
Autoplay Status: Activity now specifies if a track is playing with autoplay.
Track Artwork and Album: now_playing command displays artwork and album name (if available).
skip Command: Refactored for improved performance.
Outro Command: Fixed issues and enhanced functionality.
Streaming Commands: No more youtube or spotify commands! Now it's one universal command play which can play youtube, youtube music, spotify, soundcloud, vimeo, and also streams from youtube and twitch
Bot Operations: No longer requires specific guilds to operate. To synchronize discord application tree commands, just start the bot and press Ctrl+R in discord to reload it, then commands should be up-to-date.

Updates

Lavalink Config: Updated to include necessary plugins. Lavalink own youtube source is deprecated, so it now utilizes separate youtube plugin to search for youtube videos and music, and lavasrc plugin for spotify.
Spotify credentials are now moved to lavalink.yaml file
Spotify Extension: Removed deprecated Spotify extension for Wavelink.
Version Stick: Sticking to the major version of Lavalink.
Dependencies: Updated dependencies to the latest versions.

lgtm


Corrupted bounded vec after branch not taken

Aim
Running in the aztec sandbox this test that runs this function
    #[aztec(private)]
    fn request_attestation(
        from: AztecAddress,
        attestor: AztecAddress,
        blacklist_root: Field,
        proofs: [Field; DEPTH * BOUNDED_VEC_LEN],
        nonce: Field
    ) {
        if (!from.eq(context.msg_sender())) {
            assert_current_call_valid_authwit(&mut context, from);
        } else {
            assert(nonce == 0, "invalid nonce");
        }

        let maybe_note = storage.balances.last_unattested_note(from, attestor);
        if maybe_note.is_some() {
            let note = maybe_note.unwrap_unchecked();

            let attested = Attestor::at(attestor).request_attestation(&mut context, note.partition_table, blacklist_root, proofs)[0] as bool;
            if attested {
                storage.balances.add_attestation(from, note, attestor);
            }
        }
    }

Expected Behavior
The function should run normally
Bug
The simulator complains that the private_call_stack_hashes exposed by the function do not match the oracle calls emitted to call other functions. Digging into the code with debug logs:
    #[aztec(private)]
    fn request_attestation(
        from: AztecAddress,
        attestor: AztecAddress,
        blacklist_root: Field,
        proofs: [Field; DEPTH * BOUNDED_VEC_LEN],
        nonce: Field
    ) {
        dep::aztec::oracle::debug_log::debug_log_array_with_prefix(
            "Start request_attestation",
            context.private_call_stack_hashes.storage
        );
        if (!from.eq(context.msg_sender())) {
            assert_current_call_valid_authwit(&mut context, from);
        } else {
            assert(nonce == 0, "invalid nonce");
        }

        let maybe_note = storage.balances.last_unattested_note(from, attestor);
        dep::aztec::oracle::debug_log::debug_log_array_with_prefix("Maybe_note is some", [maybe_note.is_some()]);
        if maybe_note.is_some() {
            let note = maybe_note.unwrap_unchecked();

            let attested = Attestor::at(attestor).request_attestation(&mut context, note.partition_table, blacklist_root, proofs)[0] as bool;
            dep::aztec::oracle::debug_log::debug_log_array_with_prefix("Attested", [attested]);
            dep::aztec::oracle::debug_log::debug_log_array_with_prefix("Before if", context.private_call_stack_hashes.storage);
            if attested {
                dep::aztec::oracle::debug_log::debug_log_array_with_prefix(
                    "Should not appear",
                    context.private_call_stack_hashes.storage
                );
                storage.balances.add_attestation(from, note, attestor);
            }
            dep::aztec::oracle::debug_log::debug_log_array_with_prefix("After if", context.private_call_stack_hashes.storage);
        }
    }

We can see that the bounded vec that stores the private_call_stack_hashes gets corrupted after the if attested {} that is not taken in runtime:
2024-03-20T13:56:52.766Z aztec:simulator:oracle Start request_attestation: 0x00000000
2024-03-20T13:56:53.106Z aztec:simulator:oracle Maybe_note is some: 0x0000000000000000000000000000000000000000000000000000000000000001
2024-03-20T13:56:53.468Z aztec:simulator:oracle Attested: 0x0000000000000000000000000000000000000000000000000000000000000000
2024-03-20T13:56:53.468Z aztec:simulator:oracle Before if: [0x013fd03529742b8117424d1ed6c26da57fbc732224fa42976c2544b644b5f15a, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000]
2024-03-20T13:56:53.497Z aztec:simulator:oracle After if: [0x013fd03529742b8117424d1ed6c26da57fbc732224fa42976c2544b644b5f15a, 0x013fd03529742b8117424d1ed6c26da57fbc732224fa42976c2544b644b5f15a, 0x013fd03529742b8117424d1ed6c26da57fbc732224fa42976c2544b644b5f15a, 0x013fd03529742b8117424d1ed6c26da57fbc732224fa42976c2544b644b5f15a]

Where the initial item gets duplicated to all other items.
The call_stack_item_hashes is only written in assert_current_call_valid_authwit (which isn't executed, so no item is pushed) and request_attestation (which is executed, and that where the initial item that gets duplicated comes from)
To Reproduce

Clone the repo
aztec-up 0.29.0
run yarn compile && yarn codegen && yarn test -t "Request attestation after blacklisting"

Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Installation Method
None
Nargo Version
No response
NoirJS Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response

Note: rewriting it in this form:
    #[aztec(private)]
    fn request_attestation(
        from: AztecAddress,
        attestor: AztecAddress,
        blacklist_root: Field,
        proofs: [Field; DEPTH * BOUNDED_VEC_LEN],
        nonce: Field
    ) {
        if (!from.eq(context.msg_sender())) {
            assert_current_call_valid_authwit(&mut context, from);
        } else {
            assert(nonce == 0, "invalid nonce");
        }

        let maybe_note = storage.balances.last_unattested_note(from, attestor);
        let mut attested = false;

        if maybe_note.is_some() {
            let note = maybe_note.unwrap_unchecked();

            attested = Attestor::at(attestor).request_attestation(&mut context, note.partition_table, blacklist_root, proofs)[0] as bool;
        }

        if attested {
            storage.balances.add_attestation(from, maybe_note.unwrap(), attestor);
        }
    }

Makes the corruption no longer happen

Unfortunately I didn't manage to simplify it to a point where the SSA isn't huge :/

I'm thinking that we should make the --show-ssa more selective. Oftentimes we are interested in a single pass but get a wall of text where the majority is irrelevant.

This is the simplest I could make it while still reproducing the corruption:
  use crate::types::token_note::OwnedNote;
    use dep::aztec::protocol_types::{
        constants::{MAX_NOTES_PER_PAGE, MAX_NOTE_HASH_READ_REQUESTS_PER_CALL},
        abis::side_effect::{SideEffect, SideEffectLinkedToNoteHash}
    };
    use dep::aztec::context::{PrivateContext, PublicContext, Context};
    use dep::aztec::note::{
        lifecycle::{create_note, create_note_hash_from_public, destroy_note},
        note_getter::{get_notes, view_notes}, note_interface::NoteInterface,
        note_viewer_options::NoteViewerOptions, utils::compute_note_hash_for_consumption
    };
    use dep::aztec::oracle::notes::{notify_created_note, notify_nullified_note};
    use dep::aztec::{hash::pedersen_hash};

    #[contract_library_method]
    fn compute_nullifier(hash: Field, account: AztecAddress, context: &mut PrivateContext) -> Field {
        let secret = context.request_nullifier_secret_key(account);
        pedersen_hash(
            [
            hash,
            secret.low,
            secret.high
        ],
            0
        )
    }

    // TODO: Recursively call `request_attestation` until all attestations are received?
    #[aztec(private)]
    fn request_attestation(
        from: AztecAddress,
        attestor: AztecAddress,
        blacklist_root: Field,
        proofs: [Field; DEPTH * BOUNDED_VEC_LEN],
        nonce: Field
    ) {
        dep::aztec::oracle::debug_log::debug_log_array_with_prefix(
            "Start request_attestation",
            context.private_call_stack_hashes.storage
        );
        if (!from.eq(context.msg_sender())) {
            assert_current_call_valid_authwit(&mut context, from);
        } else {
            assert(nonce == 0, "invalid nonce");
        }

        let maybe_note = storage.balances.last_unattested_note(from, attestor);
        let note = maybe_note.unwrap();

        let attested = Attestor::at(attestor).request_attestation(&mut context, note.partition_table, blacklist_root, proofs)[0] as bool;
        dep::aztec::oracle::debug_log::debug_log_array_with_prefix("Attested", [attested]);
        dep::aztec::oracle::debug_log::debug_log_array_with_prefix("Before if", context.private_call_stack_hashes.storage);
        if attested {
            dep::aztec::oracle::debug_log::debug_log_array_with_prefix(
                "Should not appear",
                context.private_call_stack_hashes.storage
            );

            let mut nullifier = 0;
            let mut consumed_note_hash: Field = 0;
            nullifier = compute_nullifier(27, from, &mut context);

            context.push_new_nullifier(nullifier, consumed_note_hash);
        }
        dep::aztec::oracle::debug_log::debug_log_array_with_prefix("After if", context.private_call_stack_hashes.storage);
    }

I've attached the SSA
ssa.zip
I think the corrupt private_call_stack_hashes are v750230, v750233, v750236, v750239. I think the last two items should always be zero and the compiler is not realizing it

We seem to have hit a similar instance of this issue in the branch palla/04-09-fix_use_entrypoint_instead_of_pay_init_fee-with-a-stupid-number-of-logs of aztec-packages. Running ENABLE_GAS=1 yarn test e2e_account_init_fees -t 'minimal example for empty app payload issue' > log.txt 2>&1 in yarn-project/end-to-end should generate a log that showcases the error.
In this case, the function causing issues is this one:
    fn execute_calls(self, context: &mut PrivateContext) {
        dep::aztec::oracle::debug_log::debug_log("Starting execute calls");
        context.print_note_hash_read_requests();
        for call in self.function_calls {
            if !call.target_address.is_zero() {
                dep::aztec::oracle::debug_log::debug_log_format(
                    "Executing function call to={0} args={1}",
                    [call.target_address.to_field(), call.args_hash]
                );
                if call.is_public {
                    context.call_public_function_with_packed_args(
                        call.target_address,
                        call.function_selector,
                        call.args_hash,
                        false,
                        false
                    );
                } else {
                    let _result = context.call_private_function_with_packed_args(
                        call.target_address,
                        call.function_selector,
                        call.args_hash,
                        false,
                        false
                    );
                }
            }
        }
        dep::aztec::oracle::debug_log::debug_log("Ended execute calls");
        context.print_note_hash_read_requests();
    }

The logs that correspond to a run where self.function_calls is an array of empty structs (meaning target_address is zero for all of them, so the conditional is not taken, which can be seen in the logs by the absence of the debug log) show that the note_hash_read_requests of the PrivateContext (a BoundedVec in the struct) are filled with copies of the first two items:
2024-04-09T19:56:58.479Z aztec:simulator:oracle Starting execute calls
2024-04-09T19:56:58.479Z aztec:simulator:acvm Oracle callback debugLogWithPrefix
2024-04-09T19:56:58.479Z aztec:simulator:oracle Printing note hash read requests: [0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000]
2024-04-09T19:56:58.529Z aztec:simulator:acvm Oracle callback debugLog
2024-04-09T19:56:58.529Z aztec:simulator:oracle Ended execute calls
2024-04-09T19:56:58.529Z aztec:simulator:acvm Oracle callback debugLogWithPrefix
2024-04-09T19:56:58.529Z aztec:simulator:oracle Printing note hash read requests: [0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b, 0x060657913957bf5535951df734bc7886e9ccf62d9def3eb8c5c3d1196268773b]

We have also tried to reproduce this in a noir circuit outside aztec-packages, in noir-projects/bug-repro (note that compiling that one requires commenting out a few lines in noir-projects/noir-protocol-circuits/crates/types/src/debug_log.nr which are flagged with a note), but with no luck. Running nargo prove or nargo test there works fine.

I wonder if this is related to the constant folding bug I found in https://github.com/noir-lang/noir/pull/4716.
If you make this change: https://github.com/noir-lang/noir/pull/4716/files#diff-1d0f0549b989551a60174308917ce4e7cbd5615ef86813e1729ac60e903f3702R281-R285 does it fix the issue?

@jfecher that worked, thanks so much!! Does it make sense to submit a PR with just that change, or is it best to wait for 4716 to be ready?
2024-04-11T15:17:46.641Z aztec:simulator:oracle Gonna call app payload execute calls
2024-04-11T15:17:46.642Z aztec:simulator:acvm Oracle callback debugLogWithPrefix
2024-04-11T15:17:46.642Z aztec:simulator:oracle Printing note hash read requests: [0x21aa9972aba518dbb557c751c7cc79a9545d83b18e58ee4f845c0d6c33ca110e, 0x21aa9972aba518dbb557c751c7cc79a9545d83b18e58ee4f845c0d6c33ca110e, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000]
2024-04-11T15:17:46.690Z aztec:simulator:acvm Oracle callback debugLog
2024-04-11T15:17:46.690Z aztec:simulator:oracle Called app payload execute calls
2024-04-11T15:17:46.690Z aztec:simulator:acvm Oracle callback debugLogWithPrefix
2024-04-11T15:17:46.691Z aztec:simulator:oracle Printing note hash read requests: [0x21aa9972aba518dbb557c751c7cc79a9545d83b18e58ee4f845c0d6c33ca110e, 0x21aa9972aba518dbb557c751c7cc79a9545d83b18e58ee4f845c0d6c33ca110e, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000000]

@spalladino good to hear! I'll make a separate PR with that change now.
#4716 may not be ready for a while since there is 1 remaining failing test in it that is very tricky to fix.


Add ZSH suggestions and aliases

Description

I try to improve ZSH user experience.
As auto completion is already implemented, I suggest being able to activate autosuggestions plugins too.
With the env var SHELL_OH_MY_ZSH_AUTOSUGESTIONS default is false.
As mentioned here https://github.com/laradock/laradock/issues/2703
I suggest being able to load bash aliases into ZSH too.
With the env var SHELL_OH_MY_ZSH_ALIASES default is false
Motivation and Context
Those are very useful plugins and improve dev experience. Set it up every time in the container is really painful. Now the user can activate autosuggestions or aliases with ZSH if needed.
Types of Changes

[] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Definition of Done Checklist:

[x] I've read the Contribution Guide.
[x] I've updated the documentation. (refer to this for how to do so).
[x] I enjoyed my time contributing and making developer's life easier :)

I set the variables to true:
SHELL_OH_MY_ZSH=true
SHELL_OH_MY_ZSH_AUTOSUGESTIONS=true
SHELL_OH_MY_ZSH_ALIASES=true

When I run the command docker-compose exec workspace zsh, an error message appears:
"/root/aliases.sh:160: command not found: complete"


Add integration test

IDVA3-550
Add new integration test
Minor update to existing test

CI: Security warnings found!


Improvements to bring in line with nwjs-builder-phoenix

Issue Type

[x] Feature Request

Current/Missing Behaviour
There is no functionality to configure things like the icon, plist entries, company name, copyright, etc
Expected/Proposed Behaviour
add this functionality
Additional Info
here is a sample from my package.json for nwjs-builder-phoenix. We run a script to replace all the @@ variables before we do the build. After the new app is built we package and sign the installer. We need all these properties to be properly configured so that we can distribute our app
"build": {
        "ffmpegIntegration": true,
        "nwVersion": "0.78.1",
        "nwFlavor": "normal",
        "appId": "@@APP.NAMESPACE",
        "output": "./../../builds/dist/",
        "excludes": ["**/*.tar.gz"],
        "win": {
            "productName": "@@APP.EXECUTABLE",
            "companyName": "@@APP.NAME",
            "fileDescription": "@@APP.TITLE",
            "productVersion": "@@APP.VERSION",
            "copyright": "@@APPP.COPYRIGHT",
            "icon": "../../output/white-label/icon.ico"
        },
        "mac": {
            "productName": "@@APP.EXECUTABLE",
            "companyName": "@@APP.NAME",
            "copyright": "@@APPP.COPYRIGHT",
            "version": "@@APP.VERSION",
            "icon": "../../output/white-label/nw.icns",
            "documentIcon": "../../output/white-label/nw.icns",
            "plistStrings": {
                "CFBundleIdentifier": "@@APP.NAMESPACE",
                "LSApplicationCategoryType": "public.app-category.education"
            }
        }
    },

@sysrage ah amazing - thank you
Would you perhaps happen to have a working example - bare API documentation is a little sparse, and a working example would go a long way to helping users get this working

It would be nice if there was one, copy-pastable, example of passing everything in. Every setting. And then if you have questions about what options can be passed in for specific part of the API, the docs can fill in the details.

Is there a way to pass app arguments from CLI?
We use a single package.json and build for windows and macOS
The nwjs-builder-phoenix has seperate sections for each platform, so depending on which platform you build for, it reads from the relevant section.
As far as I can tell the app section in nw-builder is not platform dependent and will be used for whichever platform you build for.
I suppose I could use a js script to handle the build for each platform - this way I wouldn't need to rely on a CLI implementation

Is there a way to pass app arguments from CLI?

One way is to pass all app.* properties inside the package.json:
package.json:
{
  "nwbuild": {
    "icon": "...", #the icon will be parsed for all platforms
    "NSHumanReadableCopyright": "..." # only parsed for osx platform
  }
}

The nwbuild function does a single build for a single platform and architecture. You can reuse the same options from the package.json and it will parse the ones necessary for the given platform.
I haven't used the options in package.json in some time so it may not work as expected.


Created ashishtom.json

Fixes #
Proposed Changes

Screenshots

Oh😅 so shall i exclude it and commit again?

I have excluded it and I have done the necessary changes. Can you have a look?

Please further exclude package-json and package-json.lock from the pr (only exclute them in the pr not in the gitignore :) )

Ok got it 🙂@schmelto

Now I have done everything that needed to be merged right?. Or is there anything else? @schmelto

Now I have done everything that needed to be merged right?. Or is there anything else? @schmelto

No please delete those three files from the pr

only your username.json should be in the pr :)

okay got it

Done. I just added JSON file in the pr just as you told me to do. @schmelto

Unfortunately the other changes are still in this pr.
you can undo the other files as follows:

The instructions below assume that the unwanted updates are in a file that already exists in the GitHub repository. If the unwanted updates are in an entirely new file that you created, then you can delete the file from your file system, then run git rm  followed by git commit to remove the file from the PR.
here

Okay got it


Add dependabot.yml

Let's use GitHub's dependabot to check for GitHub Actions and GoLang dependencies
RELEASE_NOTES=n/a
Signed-off-by: Michael Gerlach<EMAIL_ADDRESS>

Fixes https://github.com/gopasspw/gopass/issues/1765

Sorry for the noise. First I haven't had a look at the contribution guideline and messed up the signoff afterwards.. -,-

And please use git commit --amend and git push --force to avoid opening too many PRs ;)
force pushing does not lead to re-run the test base. But I didn't tried to re-run them manually....

There are some other useful options too: https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates
I guess rebase-strategy is one which might be needed?


make config be .bqn instead of .txt

Config is currently just special syntax, I would rather have it be json since that's more known and more extendable for the future.

I just realized json doesn't allow duplicate keys and has troubles with backslashes in paths since you need escaping so I've decided i won't use that. Some other format would be nice though.

I've renamed since I've decided making it bqn syntax is the best way for an extendable config. I was worried about symbols being in a config but I'm not finding any reason for it being an issue.

the following commit implemented bqn config: https://github.com/Brian-ED/rayed-bqn/commit/af8062e6fe15afd73f3cfec8e64353818b80ad77


refactor(mistral): update safe_mode property and max temperature in ChatCompletionRequest

Description:
The request body schema for Chat Completion changed.

We use now safe_prompt instead of safe_mode property.
The max temperature is now 1 instead of 2.

@davidmigloz
I have a big doubt about the "refactor" I chose for the PR. Because it's not a bug. More of a small breaking change.

Released!
https://github.com/davidmigloz/langchain_dart/releases/tag/langchain-v0.3.3


[REQUEST] Setting to remove the hamburger icon

In some cases you don't have a navigationdrawer but just want the backbutton to appear.
For example when you search in Google Play store you can only go back and there is no hamburger icon.

I know. This is in my ToDo List and I will do it probably in next release.

Great to hear, keep up the good work!

Thanks

if you want to prepare for next release then test version 0.1 is uploaded to jCenter. It has some new features, but be aware that version has a lot of changes and still has some bugs.And Arrow thing is not done yet.

Arrow thing will be fixed in 3.0. And try test version 0.2 :).


Generalize & improve underlying interfaces

@evan-forbes made some interesting suggestions to generalize the underlying interface from a merkle tree to a vector commitment prover; see:
https://github.com/lazyledger/rsmt2d/pull/9#issuecomment-736805729

Related to this @Wondertan also brought this draft / write-up (?) to my attention: https://math.mit.edu/research/highschool/primes/materials/2018/Kuszmaul.pdf
It analyses bandwidth requirements and shows how to improve on bandwidth while slightly increasing computational complexity. It's certainly something we should look into post-launch.


Support version tags with custom prefix or suffix

Description
I work on a project in a monorepo that provides published libraries in multiple languages, including Swift. I would like to track the Swift package version using git tags with a custom prefix, like releases/swift/v1.0.0. We use this scheme so that we can version each language's packages separately. Examples of our release tags for other languages: https://github.com/foxglove/mcap/tags
Expected behavior
I would like a way to specify in Package.swift that my tags are prefixed with releases/swift/v.
Actual behavior
It appears that when one uses a dependency of the form .package(url: "https://github.com/my/repo", from: "1.0.0"), SwiftPM will only consider git tags named 1.0.0, v1.0.0, and similar.

It appears that when one uses a dependency of the form .package(url: "https://github.com/my/repo", from: "1.0.0"), SwiftPM will only consider git tags named 1.0.0, v1.0.0, and similar.

Yes, this is correct. Currently, the only accepted forms are (v)x.y(.z)(-pre-release)(+build-metadata). Basically a more leniently parsed SemVer 2.0.0 that allows dropping the patch version and prefixing a lowercase "v"[^1]: https://github.com/apple/swift-package-manager/blob/eb62733fc421666e54a85f7570731d709c66c830/Sources/Basics/Version%2BExtensions.swift#L19-L25
I think your request makes sense, especially seeing many of Swift's own repositories group release tags like what you've shown. Maybe we can loosen the rule a bit more so that if the tag looks like a path, then we take just the last path component of it and verify that it follows the current rule?
[^1]: Actually a bit more lenient than this, due to a few bugs I introduced last year, which I hope I can fix some time soon.

if the tag looks like a path, then we take just the last path component of it and verify that it follows the current rule?

Does this approach provide any way to restrict the prefixes that are considered? While splitting path components could be part of the solution, I wouldn’t want swiftpm to consider all tags whose last path component looks like a version, because then it’d be mixing up versions from all the different packages in the repo. The point of this request is to restrict matching to a subset of the tags.

Hi sorry for the late response!

Does this approach provide any way to restrict the prefixes that are considered?

No.

While splitting path components could be part of the solution, I wouldn’t want swiftpm to consider all tags whose last path component looks like a version, because then it’d be mixing up versions from all the different packages in the repo. The point of this request is to restrict matching to a subset of the tags.

Ok I think I know what you mean now. Sorry for misunderstanding your request at first!
I think maybe we could add some new methods as follows to PackageDescription for your needs?
func package(url: String, from version: Version, groupedUnder tagGroup: String) -> Package.Dependency
func package(url: String, from version: Version, prefixedBy prefix: String = "v") -> Package.Dependency

Yes, that could work. In my case I’d use groupedUnder: “releases/swift” or prefixedBy: “releases/swift/v”.
I’m not sure if this setting belongs in the .package() dependency, or in the Package struct itself. Putting it in the Package struct would allow the package repo to set it once and then it would work automatically for anyone who wants to depend on it. Putting it in .package() means anyone who wants to depend on the package needs to remember to include the prefix info in their dependency.

Side note: I’m guessing that the forthcoming package registry (SE-0292) would also help, because then I could simply choose which tags I upload to the registry. But having your proposed solutions would still be good, for packages that are pulled from git repos.

@jtbandes How did you resolve this? I see your package contains swift now. I am running into the same problem with adding a swift package to a monorepo.

To my knowledge it’s not resolved; consumers have to depend on a specific commit SHA. Although there is another issue blocking consumers from depending on the package, #5351

@jtbandes I don't know if this helps you, but I solved this for myself by writing a semantic-release plugin that "publishes" my Swift subpackage to a standalone Git repository for easier consumption. https://www.npmjs.com/package/semantic-release-git-publish


fix: skips exporting duplicate blocks as they are encountered

Title
Skip exporting duplicate blocks in @helia/car

Description
When calling export on an @helia/car instance the yielded export contains duplicate blocks.  This PR skips yielding duplicate blocks resulting in compact CAR files.

Notes & open questions
Added a SET to track which CID(s) have already been written to the stream.  Might need to add an option to toggle behavior if any users are relying on duplicate blocks in the output of CAR exports.
Change checklist

[Y] I have performed a self-review of my own code
[Y] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[N] I have added tests that prove my fix is effective or that my feature works

Fixes #556

For the sake of consistency Kubo does not export duplicate blocks.  At least from my limited testing.

What specs say?
Last time we looked into this the default behavior is left unspecified, and trustless gateway responses have explicit note about this:

https://specs.ipfs.tech/http-gateways/trustless-gateway/#car-format-parameters-and-determinism

Gateway's CAR responses in Kubo and Rainbow (both backed by boxo/gateway) do not include duplicates by default.
There is dups parameter that can be used for making this explicit, allowing for signaling duplicate presence in response via Content-Type header params:

https://specs.ipfs.tech/http-gateways/trustless-gateway/#car-dups-content-type-parameter
https://specs.ipfs.tech/http-gateways/trustless-gateway/#car-format-signaling-in-request

Kubo/Rainbow use it to signal the response does NOT have duplicates.
Sidenote: When are duplicates useful?
Duplicates have niche utility when you have a light client that has limited memory, so it can't cache blocks for later user, and has to “consume” blocks by unpacking data on the fly, and then discarding them (no blockstore, no cache, even in-memory).
Such client would explicitly opt-in for receiving duplicates via dups=t.
FWIW as of today, I am not aware of any clients that require this behavior, every client is usually smart enough to spawn follow-up application/vnd.ipld.raw request for any missing blocks, as this works with every gateway.
On this PR
I think the only concern here is that writtenBlocks could grow in size and become DoS / OOM vector if the user tricks the system into exporting a big DAG with many duplicated CIDs.
Having the ability to control this at the library level (and disable deduplication, and the memory cost that comes with it) would be nice, but can be added once this becomes an actual and not theoretical problem.

I think the only concern here is that writtenBlocks could grow in size and become DoS / OOM vector if the user tricks the system into exporting a big DAG with many duplicated CIDs.

This can be mitigated by using a filter instead of a set, that way we don't need to store every CID encountered.
See createScalableCuckooFilter in @libp2p/utils
import { createScalableCuckooFilter } from '@libp2p/utils/filters'

const filter = createScaleableCuckooFilter(maxItems, errorRate)

filter.has(bytes) // returns boolean
filter.add(bytes) // `.has` will probably now return `true`

The only thing to consider is the reliability of the filter.  False positives are possible but false negatives are not.  That is, if .has returns false the item is definitely not present.  If it returns true then the probability of the item being present is a factor of the errorRate.
The implementation should be structured so that there may be the (very) occasional duplicate block but there should never be a missed block.

Good to know about the Kubo behaviour too, we should align with that though an allowDuplicateBlocks: boolean option would be good to have.

I need the allowDuplicateBlocks: boolean option anyways so I will go ahead and add that into this PR to round it out.

In this PR I am sticking as a set as I need no duplicates in the resulting CAR files and I need that to be consistent always.

Switched to passing in an external filter to allow the consumer to choose how blocks are filtered without a specific purpose.
blocksFilter: Filter(@libp2p/utils/filters)

Are any other changes needed?

Apologies for the radio silence, this fell by the wayside while prepping for IPFS Camp.  Normal service will resume on Monday!

seems like just a merge from main will fix CI here thanks to https://github.com/ipfs/helia/pull/572

i think the error at https://github.com/ipfs/helia/actions/runs/10043251811/job/27755609508?pr=557#step:4:183 is caused by https://github.com/multiformats/js-multiformats/issues/300

Confirmed no errors on my side using the bytes of the multihash once I switched from using a built in Set to using the ScalableCuckooFilter.  Built in SET performs comparisons on bytes by reference versus looking at each pointer.
No blocker from me anymore


#repo-content-pjax-container is gone

Extension version
main
Browser(s) used
Chrome
Description

Open https://github.com/refined-github/refined-github/issues
#repo-content-pjax-container exists
Click on Issues tab
#repo-content-pjax-container is gone, see console error on this line

https://github.com/refined-github/refined-github/blob/5cda3447bf80cca0c64ae5eb79779ecd62fec18e/source/features/dim-bots.tsx#L44
Related code: https://github.com/refined-github/refined-github/search?q=repo-content-pjax-container
However GitHub’s own code is still using this selector too, so it might be a temporary issue. The specific console error could probably be avoided though

I was gonna open a new issue to warn against this new turbo-frame element I noticed, only to find that it's already causing issues:

I think we need to rethink our deduplication strategy.
We've been using has-rgh to determine whether RGH was run on the page after navigation, but we can already know this: if the navigation is caused by back/forward, we’ve already been on the page, right?
The issue has historically existed because we never distinguished between a new navigation and a history navigation: both of them triggered pjax:end. In practice though we always have popstate which can tells us whether a load is new or cached.
Can we replace all deduplicate checks with a single isPopstateEvent check? deduplicate: false should be preserved though.
Related

https://github.com/hotwired/turbo/issues/620

@fregante Hovering bot commits doesn't reveal the full details anymore since 2 weeks. Could this be related to this issue or should I open a new issue?

Related, but can you open a new issue?

@fregante Done: https://github.com/refined-github/refined-github/issues/5786

We have a lot on our plate 😅
$ rg -l repo-content-pjax-container | xargs basename -s .tsx | sort
comments-time-machine-links
default-branch-button
dim-bots
index
latest-tag-button
linkify-branch-references
linkify-symbolic-links
quick-review
rgh-feature-descriptions
rgh-linkify-features
same-branch-author-commits
swap-branches-on-compare
useful-forks

ripgrep has the -i flag
❯ rg -l -i repo-content-pjax-container
source/features/linkify-branch-references.tsx
source/features/useful-forks.tsx
source/features/quick-review.tsx
source/features/comments-time-machine-links.tsx
source/features/same-branch-author-commits.tsx
source/features/rgh-feature-descriptions.tsx
source/features/latest-tag-button.tsx
source/features/default-branch-button.tsx
source/features/swap-branches-on-compare.tsx
source/features/dim-bots.tsx
source/features/linkify-symbolic-links.tsx
source/features/rgh-linkify-features.tsx
source/features/index.tsx

Indeed, I have --smart-case aliased.

Same goes for the .repository-content selector, which targets the same element. It causes:

https://github.com/refined-github/refined-github/issues/6077


Still supported

Hey @grover is this plugin still supported?
I tried installing it and got all kinds of errors. Would love to get this implemented on my system.
[1/20/2022, 11:47:03 AM] ====================
[1/20/2022, 11:47:03 AM] ERROR LOADING PLUGIN homebridge-dacp:
[1/20/2022, 11:47:03 AM] Error: Cannot find module 'ip'
Require stack:
- /homebridge/node_modules/homebridge-dacp/src/artwork/ArtworkCamera.js
- /homebridge/node_modules/homebridge-dacp/src/index.js
- /usr/local/lib/node_modules/homebridge/lib/plugin.js
- /usr/local/lib/node_modules/homebridge/lib/pluginManager.js
- /usr/local/lib/node_modules/homebridge/lib/server.js
- /usr/local/lib/node_modules/homebridge/lib/cli.js
- /usr/local/lib/node_modules/homebridge/bin/homebridge
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/homebridge/node_modules/homebridge-dacp/src/artwork/ArtworkCamera.js:3:10)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
[1/20/2022, 11:47:03 AM] ====================

I just tried setting up the plugin as well and I'm getting the same error.  Error: Cannot find module 'ip'
Would love to get this working if someone has a solution for fixing this error.

Anybody has found a solution or a functional alternative?


Update winsorization.mdx

add note that we only winsorize using non-zero values

🚀 Deployed on https://6695b9d6296a3fdbad945846--cozy-fox-0defec.netlify.app


Kernel state should persist across VS Code sessions

Feedback from PyCon 2022
"Sometimes I have to reload VS Code, and other times I accidently close VS Code. And it's a bummer that kernel state doesn't persist between VS Code sessions. I lose all my variables and have to run my whole notebook again to test something out. I want VS Code to persist my kernel state until I tell it to restart my kernel."

duplicate of #3998


Differences to syrusakbary/snapshottest

How does this project differ from syrusakbary/snapshottest, which seems to offer the same functionality but has been developed since 2017. Any differences in the feature set that could perhaps be mentioned in the README?

I wrote this package because I felt that snapshottest was too opinionated and not easily customizable. For example, I wanted to save large json objects in separate files in YAML format in a logical path in the git repository which would make viewing diffs as easy as possible. I had trouble getting this to work.
In pytest-snapshot every snapshot is in a separate file, you serialize the object however you want, and you have complete control over the path to the snapshot. In my opinion, this makes the library more customizable and intuitive due to its simplicity.
Does this answer your question? Do you think I should add a paragraph to the README?

Since they are so similar, I think adding a note to the README would be nice. I was reconstituting an old project that used snapshottest and accidentally installed pytest-snapshot. The usage pattern was very similar. When the test failed due to a missing parameter tried to find out what was going on and what the differences were. There was not a lot of info based on my searches. I was going to just re-install snapshottest until I saw this comment.

I concur. Explaining the point behind this newer project would be useful to those trying to decide which library to apply.

I created a pull request which adds this to the readme. Feel free to add any suggestions to the documentation.

I created a pull request which adds this to the readme. Feel free to add any suggestions to the documentation.


Added config flag to test and e2e

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #278   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          57     57
  Lines        1353   1370   +17
  Branches      203    208    +5
=====================================
+ Hits         1353   1370   +17

Flag
Coverage Δ

#builder
100% <100%> (ø)
:arrow_up:

#runtime
100% <ø> (ø)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

index.js
100% <ø> (ø)
:arrow_up:

cli/test.js
100% <100%> (ø)
:arrow_up:

cli/e2e.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 756fd8c...bc4ecf3. Read the comment docs.

Adding this comment, so we don't forget to address it: "If the SPA does not have an e2e folder, the custom config will never run (even though it might have *.visual-spec.ts files)."

After talking to @Blackbaud-SteveBrush and @Blackbaud-PaulCrowder, we've decided to be a little more explicit in how we allow configuration overrides.  Ultimately this allows to accomplish the same behavior, but in a more first-class way as well as not having karma be a leaky abstraction.


Make has_submenu_items a property (for programatically setting option)

Hi,
I am spinning up some fake data for my site using FactoryBoy/faker, including Wagtail Menus.  I noticed that MenuPage objects have the has_submenu_items getter method, but I would like to programatically set this option from a python script.
I am guessing it would be a trivial fix to make the method a property instead.
If this seems plausible, i'd be happy to attempt a PR.
(maybe this is implemented in the Wagtail Menus API #302 ? )

@schlich I'm not sure changing code to facilitate such a test is the best idea. Plus, making it a 'property' would not make the value settable unless you used cached_property, or added a dedicated setter method, neither of which do I think fit the design very well.
If you do need to control the method result, why not update your factory to replace the method on the instances it creates? The unittest.mock library in python core is perfect for this kind of thing.


Block header corrupt on correct XZ file

Unhandled Exception: System.IO.InvalidDataException: Block header corrupt   at SharpCompress.Compressors.Xz.XZBlock.CacheHeader () [0x00060] in <57fade50bf4b4b0aa2c9652265c0bd24>:0    at SharpCompress.Compressors.Xz.XZBlock.LoadHeader () [0x00006] in <57fade50bf4b4b0aa2c9652265c0bd24>:0    at SharpCompress.Compressors.Xz.XZBlock.Read (System.Byte[] buffer, System.Int32 offset, System.Int32 count) [0x0000a] in <57fade50bf4b4b0aa2c9652265c0bd24>:0    at SharpCompress.Compressors.Xz.XZStream.ReadBlocks (System.Byte[] buffer, System.Int32 offset, System.Int32 count) [0x0001f] in <57fade50bf4b4b0aa2c9652265c0bd24>:0    at SharpCompress.Compressors.Xz.XZStream.Read (System.Byte[] buffer, System.Int32 offset, System.Int32 count) [0x0001a] in <57fade50bf4b4b0aa2c9652265c0bd24>:0
File is https://download.freenas.org/9.2.1/RELEASE/x86/FreeNAS-9.2.1-RELEASE-x86.vmdk.xz

Thanks!


WG: Unable to hit enter on mobile device (iPhone 6s)

Setting environment: 3 player (2 from MacOS chrome, 1 from iOS safari)
The two players from desktop were able to start the game properly by entering the "start link article", while the page on the iphone froze, unable to hit enter.

Fixed as of commit 52a0120fe0a5a80d1526a842d5fce6859e45d01f.