Update middleware example

Description
Add common exclusions the URL rewrite to maintain page rendering capabilities and asset paths even in maintenance mode.
Referencing this discussion: https://github.com/vercel/next.js/discussions/38615
Demo URL

Type of Change

[ ] New Example
[x] Example updates (Bug fixes, new features, etc.)
[ ] Other (changes to the codebase, but not to examples)

New Example Checklist

[ ] 🛫 npm run new-example was used to create the example
[x] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
[ ] 📱 Is it responsive? Are mobile and tablets considered?

As far as I'm concerned, this change might be redundant since the middleware function is already limited to running only on specific paths by the config.matcher. Are you trying to prevent people from blindly copying code into their middleware that will run on all traffic?

As far as I'm concerned, this change might be redundant since the middleware function is already limited to running only on specific paths by the config.matcher. Are you trying to prevent people from blindly copying code into their middleware that will run on all traffic?

Given the context of this specific example, and if you were to follow this example as-is, you'd most likely find that any maintenance page you create (assuming it's using any referenced dependencies like components, assets, etc) would be blocked resulting in a broken page...including things some basic things that I'd assume many may not consider, like your favicon. Maybe this could be a readme update to the example instead, but I think it's worth calling out that code like this will block all paths.
I do also think there's value in showcasing that there are certain paths you may want to leave open to traffic even when a site is in maintenance mode. For instance, paths your hosting on your app to assets referenced externally may not be links you want to break when taking a site down via something as quick/easy as an external config.

I see. So it might be better to refactor this example to run on all paths and then exclude assets like you did.
WDYT @lfades @goncy ?

In the current rewrite all static assets will also get rewritten to the assets of the maintenance page, which is intended behavior.  It can't just be the browser URL and it won't include assets like those in the public folder unless this line explicitly includes them:
const isInMaintenanceMode = await get<boolean>('isInMaintenanceMode')

It currently does and we should change that, but once that's changed the behavior of also rewriting the static files should persist. @goncy can you check this one out as I might be missing something 🙏

Hey @mattschwarz thanks for the PR! I get your point that sometimes when you go into maintenance mode, some "parts" of your app, like assets or static files can still be accessed. In this case we are showing how to get just one part of your app in maintenance mode, but I think we can add a section to the example saying that if you want to put your entire app in maintenance mode you should take care of excluding the assets and internal files from middleware. In that case we can leave a minimal example working but still covering your case, what do you think?

Hey @mattschwarz thanks for the PR! I get your point that sometimes when you go into maintenance mode, some "parts" of your app, like assets or static files can still be accessed. In this case we are showing how to get just one part of your app in maintenance mode, but I think we can add a section to the example saying that if you want to put your entire app in maintenance mode you should take care of excluding the assets and internal files from middleware. In that case we can leave a minimal example working but still covering your case, what do you think?

Yeah I don't necessarily think we need to include my code change since the current example specifies a config matcher, but considering that this is the only example offered of implementing some kind of maintenance mode, I think it's a reasonable assumption that most would benefit from instruction on how to do that for an entire app. With that in mind, mentioning how and what paths to avoid accidentally targeting to keep critical links and functionality working would be nice.


add app: Pathephone

Pathephone uses IPFS to share music as well as discover and stream music shared by others.

This looks awesome! :)

@koalalorenzo sure, all recent work has been done in english) we'll try to keep it that way


fixed a deref of a null ptr

Fixes AB#1671

This overlaps with #676, we can probably close this and attach AB#1671 to that PR too?

@int-Frank, can you follow up on this PR?

@OsiJr @samsinsane Sam is correct. Although the geozone fallback is different in each of these. This PR we have:
current -> project
#676 we have
current -> preferred -> pProgramstate->geozone.
I'm not sure which one is correct in this context.

I'll close this, if its broken we can revisit. At the moment this doesn't merge and the attached issue is resolved.


bump sentry-sdk to 0.14

sentry tells us to do this

we should finally do something about the failing requre tests

rebased, let's see some greens

recheck


Benchmarks that use the HeadlessFrontend / Map are hanging

The benchmarks in benchmark/api/query.benchmark.cpp and benchmark/api/render.benchmark.cpp are hanging in this loop:
https://github.com/maplibre/maplibre-native/blob/619408d09d107b92630a4e04848de1178a2f9e81/platform/default/src/mbgl/gfx/headless_frontend.cpp#L157-L159
I'm enabling the other benchmarks and plan to look into this issue.

Which platform?
Note that in this specific case I suspect that the image never gets valid. Can you confirm that?

@ntadej I tried both Android and Linux. Possibly the sprites are never loaded.
Yes the image never gets valid.


Fix bugs in tests-integration sources

This PR addresses some issues and bugs found by @kilohsakul and addresses issues raised in  #302
So far, this PR:

Simplifies some code in tests-integration sources,
Introduces TIMER macros where they were not used,
Introduces load_automata function, which loads vector of automata and mintermizes them together.

The PR looks good to me overall. It should fix the bug with mintermization, as far as I can tell.
What are the findings about the other bugs you mention? Did you figure it out? If so, how? Or what else do you plan to fix in this PR?

This focuses on the mintermization bug only, after some hounding and discussion with Lukas, there are probably not issues (the 15th state is true and we could discuss it on meeting; the performance is OK, it was easy example, not problematic as certain someone said :D).
Once I rewrite the skip_mintermization I will ping you again and you can merge it.

Sounds good. Since the mintermization was already discussed with Lukáš, if he manages to review the PR before merge, all the better, but we can merge first and he can review it later, too.

@Adda0 I improved the comment a little and flipped it to positive variant, check it out and merge it as you wish.


Carousel transition breaks when viewing another tab on the browser

Bug description:
When a carousel has automatic sliding, if you are viewing a different tab in the same browser when the transition happens, the carousel gets stuck. The auto transition no longer happens, and the manual transition using the arrows doesn't work either.
I've recreated it in Chrome and Edge.
Note - if you simply minimise the browser or look at another window the bug doesn't happen, it seems to be only when looking at a different tab on the same browser instance.
This is the same issue as reported here: https://github.com/angular-ui/bootstrap/issues/5471
Link to minimally-working plunker that reproduces the issue:
I can create this on your demo page.
Version of Angular, UIBS, and Bootstrap
Angular: 1.5.6
UIBS: 1.3.3
Bootstrap: 3.3.6

Ah wait.. Even though I had specified angular-animate 1.5.6 in my bower.json after looking at the source code for their fix it seems for some reason I only had 1.5.0 on my machine. Very odd.
Anyway, I force deleted from my bower cache and it pulled down the correct version, and now it's all fine.
Was made confusing by the fact that I could reproduce it on your demo site though, so you may want to update that :)
Cheers


Workflowy Won't Load

I have attempted to install Workflowy as an app, but it will not install. If I use the pre-installed app, it tells me that the page does not exist (the app is directing towards the wrong url), and the "Home" link does not do anything. If I try to install it as a custom app, it just tells me that the page will not load. I am attempting this on a Mac, if that makes any difference.

Start page is incorrect. The right one is https://workflowy.com/login/
But then application crashes with error:

In the pure webview Workflowy loads without errors


Is the suse release at going to be available at https://packages.microsoft.com/ ?

I see suse linux in the releases.
Any chance on getting the instructions here: https://blogs.msdn.microsoft.com/powershell/2017/02/01/installing-latest-powershell-core-6-0-release-on-linux-just-got-easier/ merged into this repo and kept up to date?
Thanks!

@DarwinJS we merged a PR to update the instructions for registering the repository https://github.com/PowerShell/PowerShell/blob/master/docs/installation/linux.md#ubuntu-1604 already.  Will look into suse support.

I just did a PR to make download.sh autodetect the version.
What about also making download.sh automatically use repos for any variants that have repo support?

@DarwinJS I suggested you change to use repo support before a read this.  Could you update your PR?
I'm working on getting an OpenSUSE 42.1 repo setup.

@TravisEz13 - is the repo updated? I will also need to be briefed on the OpenSUSE commands to register the repo and pull the package. Thanx!

42.1 is about to be unsupported.  Does it make sense to publish this?

I wasn't aware that the previous restriction was based on known issues - I have no problem putting it back in.

@DarwinJS  don't do anything yet.

This is dependant on #3961

We now have only one RPM package for all supported red hat family of distros and it's published to the Microsoft YUM repository. However, an interactive manual step is required to install on OpenSUSE, see the docs here. Starting from the next release, we will publish .tar.gz packages for Linux/macOS, so the installation on OpenSUSE can be done using the tarball package.
.NET Core 2.0 RPM package has the same manual step requirement: https://www.microsoft.com/net/core#linuxopensuse

This manual step is not very workable.  I spent several hours trying to work around it.  Could it be avoided by having a separate package for Open SUSE?
Is the manual step required for every update as well?
I was able to work around it by downloading the RPM and then using rpm -ivh  --nodeps.
But is looks like a possible side effect of that is that NONE of the dependencies are installed (rather than just skipping problematic ones) (http://blog.endpoint.com/2008/08/rpm-nodeps-really-disables-all.html)

Starting from the next release, we will publish .tar.gz packages for Linux/macOS, so the installation on OpenSUSE can be done using that tarball package. Here is an example of doing it: https://github.com/PowerShell/PowerShell/blob/master/docker/release/opensuse42.2/Dockerfile
You can play with it using the tarball package I uploaded at https://github.com/daxian-dbw/PowerShell/releases/download/v6.0.0-beta.8/powershell-6.0.0-beta.8-linux-x64.tar.gz

@daxian-dbw - Ok I will adapt these lines in the open suse installer: https://github.com/PowerShell/PowerShell/blob/master/tools/installpsh-suse.sh#L142-L158
Is Suse the only one affected by the inability to use a package manager to create a fully automated install?

As far as I know, the Amazon Linux is also affected. You can find the updated dockerfile for Amazon Linux here: https://github.com/PowerShell/PowerShell/blob/master/docker/community/amazonlinux/Dockerfile
It's moved to the community folder as the Amazon Linux image is not officially supported.

installpsh-suse.sh has been updated to the tar.gz binary archive via the PR #5309. I will close this issue.


[Event Hubs Client] Track Two: Third Preview (Iterator Read Improvements)

Summary
The intent of these changes is to enhanced the logic around reading and publishing events to the channel used by the asynchronous iterator in order to remove an arbitrary delay and make the loop more responsive without polling in a tight loop when no items are available.
Last Upstream Rebase
Wednesday, August 14, 2019 8:44am (EDT)
Related and Follow-Up Issues

[Epic] Release Event Hubs Track 2 Library Preview 3 for .Net (#7141)
Revisit Async Iterator Loop (#7094)

Feels like we are suppressing to many exceptions in this type.

Feels like we are suppressing to many exceptions in this type.

I respectfully disagree.   We're suppressing exceptions for known scenarios around cancellation to allow for cleanup and exit.  I don't see value in bubbling cancellation exceptions in this case, as we have a clear path for honoring the request without triggering an exception path.

Any reason not to make ChannelEnumerableSubscription an IAsyncEnumerator?

Any reason not to make ChannelEnumerableSubscription an IAsyncEnumerator?

You mean being both the enumerable and enumerator, or just an enumerator?
...I didn't think of the first scenario during the initial implementation, but now it seems obvious.   In the second case, I'm not sure what that would look like, though I'm open to it if you don't mind sketching out a quick example of your thought or pointing me at something that illustrates.

The first one, having it be both the enumerable and enumerator because enumerable is mostly calling in parent class and the ChannelEnumerableSubscription is single-use anyway

The first one, having it be both the enumerable and enumerator because enumerable is mostly calling in parent class and the ChannelEnumerableSubscription is single-use anyway

Yeah, the only reason was that it didn't occur to me and I have no idea why.  One of those things that, once you see it, you can't believe that you overlooked it.

Feels like we are suppressing to many exceptions in this type.

Incorporating other feedback and restructuring cut down on this quite a bit.  We've still got one special case that I believe we need to handle, but the multiple levels are no longer necessary.

Pending comments

I responded to both and after looking things over don't believe there's any action to take.  I'm going to close this out, but if I've overlooked something that you're picking up on, please let me know and I'll address it in a follow-up patch.


Add support for range selection

Hi, thanks for the plugin!
Can you add support for range selection using visual mode?

it actually quite difficult for me 😅, so sorry, but thanks for the suggestion


Enforce uniqueness validation on User models

Enforce uniqueness validation on User models. If a new user is attempted to be made with an email that already is in the database it should fail with flash error.

unique: true is set on the email field in the User model, so I'm assuming this has been implemented since this issue was made.


Stetho filling logs with "unsupported request received: GET /devtools/browser"

If I open a tab at chrome://inspect, my application starts logging the following every second:
08-21 14:47:00.437    5655-6693/com.***.*** W/stetho﹕ Unsupported request received: GET /devtools/browser HTTP/1.1

This is a bit annoying because in Android Studio, the log keeps jumping down to the bottom each second whilst trying to review errors or other debugging logs. So I resort to closing chrome://inspect, only to have to open the tab again to connect to the app once re-deployed.
Chrome version: 44.0.2403.155
Thanks

Looks to be related to this change in Chrome.
https://chromium.googlesource.com/chromium/src/+/f30ed78e50a7569001f37845601b8a71fcefd4a4^!/

Well now this is very interesting indeed.  It looks like they're making it possible to provide our own custom UI to support this protocol but still integrate within Chrome.  This could be very powerful for us down the road...

I can't seem to reproduce this on Chrome beta: 46.0.2490.13.  Is there something special you had to do to turn this on?

I'm seeing it in version 45.0.2454.85 but not in 47.0.2506.0 canary.
However, I've also just realised this doesn't happen when deploying the app to my test device, it's only happening in the emulator (Nexus 5 x86 API 22).

Ok, I've figured out what's causing the issue. You need to have port forwarding enabled at chrome://inspect (any Chrome version). Disabling port forwarding resolves the issue.


TTS: Added voice-name attribute for tts instead of languageCode (fixed)

Voice name is more powerful.
Google docs I have used: LINK
Available voices: https://cloud.google.com/text-to-speech/
Could you create a release after merging this PR?
I would do it myself, but I have troubles installing goreleaser.
Thanks in advance
Bartek

Thanks. Do we still need the language code or is can we just use the voice name? I don't have an easy way to verify at the moment but looking at the expected API request it looks like it wants language code as well?:
{
  "audioConfig": {
    "audioEncoding": "LINEAR16",
    "pitch": 0,
    "speakingRate": 1
  },
  "input": {
    "ssml": "<speak> <emphasis level=\"strong\">To be</emphasis> <break time=\"200ms\"/> or not to be, <break time=\"400ms\"/> <emphasis level=\"moderate\">that</emphasis> is the question.<break time=\"400ms\"/> Whether ‘tis nobler in the mind to suffer The slings and arrows of outrageous fortune,<break time=\"200ms\"/> Or to take arms against a sea of troubles And by opposing end them. </speak>"
  },
  "voice": {
    "languageCode": "fil-PH",
    "name": "fil-PH-Wavenet-A"
  }
}

Thanks. Do we still need the language code or is can we just use the voice name? I don't have an easy way to verify at the moment but looking at the expected API request it looks like it wants language code as well?:
{
  "audioConfig": {
    "audioEncoding": "LINEAR16",
    "pitch": 0,
    "speakingRate": 1
  },
  "input": {
    "ssml": "<speak> <emphasis level=\"strong\">To be</emphasis> <break time=\"200ms\"/> or not to be, <break time=\"400ms\"/> <emphasis level=\"moderate\">that</emphasis> is the question.<break time=\"400ms\"/> Whether ‘tis nobler in the mind to suffer The slings and arrows of outrageous fortune,<break time=\"200ms\"/> Or to take arms against a sea of troubles And by opposing end them. </speak>"
  },
  "voice": {
    "languageCode": "fil-PH",
    "name": "fil-PH-Wavenet-A"
  }
}

Oh my bad it looks like it is requi

Thanks. Do we still need the language code or is can we just use the voice name? I don't have an easy way to verify at the moment but looking at the expected API request it looks like it wants language code as well?:
{
  "audioConfig": {
    "audioEncoding": "LINEAR16",
    "pitch": 0,
    "speakingRate": 1
  },
  "input": {
    "ssml": "<speak> <emphasis level=\"strong\">To be</emphasis> <break time=\"200ms\"/> or not to be, <break time=\"400ms\"/> <emphasis level=\"moderate\">that</emphasis> is the question.<break time=\"400ms\"/> Whether ‘tis nobler in the mind to suffer The slings and arrows of outrageous fortune,<break time=\"200ms\"/> Or to take arms against a sea of troubles And by opposing end them. </speak>"
  },
  "voice": {
    "languageCode": "fil-PH",
    "name": "fil-PH-Wavenet-A"
  }
}

Oh my bad. It looks like the languageCode is required then, but I am sure that name overrides that, but anyway maybe good idea would be to leave both. I was also wondering about speed and pitch to add to arguments but didnt want it get too messy.

Oh my bad it looks like it is requi

Thanks. Do we still need the language code or is can we just use the voice name? I don't have an easy way to verify at the moment but looking at the expected API request it looks like it wants language code as well?:
{
  "audioConfig": {
    "audioEncoding": "LINEAR16",
    "pitch": 0,
    "speakingRate": 1
  },
  "input": {
    "ssml": "<speak> <emphasis level=\"strong\">To be</emphasis> <break time=\"200ms\"/> or not to be, <break time=\"400ms\"/> <emphasis level=\"moderate\">that</emphasis> is the question.<break time=\"400ms\"/> Whether ‘tis nobler in the mind to suffer The slings and arrows of outrageous fortune,<break time=\"200ms\"/> Or to take arms against a sea of troubles And by opposing end them. </speak>"
  },
  "voice": {
    "languageCode": "fil-PH",
    "name": "fil-PH-Wavenet-A"
  }
}

Oh my bad. It looks like the languageCode is required then, but I am sure that name overrides that, but anyway maybe good idea would be to leave both. I was also wondering about speed and pitch to add to arguments but didnt want it get too messy.

You might be right and it gets overridden, the documentation isn't clear about this. If it works for you without the language code then I am happy to merge it as is.

I was also wondering about speed and pitch to add to arguments but didnt want it get too messy.

I don't mind adding them as new command arguments for the tts subcommand where the defaults get set to what you currently have:
ttsCmd.Flags().Float32("speaking-rate", 1.0, "speaking rate")
ttsCmd.Flags().Float32("pitch", 1.0, "speaking rate")

and then pass those through. But happy to also leave as is. I am not sure how often the TTS gets used, or how customizable it needs to be.

You might be right and it gets overridden, the documentation isn't clear about this. If it works for you without the language code then I am happy to merge it as is.

I was also wondering about speed and pitch to add to arguments but didnt want it get too messy.

I don't mind adding them as new command arguments for the tts subcommand where the defaults get set to what you currently have:
ttsCmd.Flags().Float32("speaking-rate", 1.0, "speaking rate")
ttsCmd.Flags().Float32("pitch", 1.0, "speaking rate")

and then pass those through. But happy to also leave as is. I am not sure how often the TTS gets used, or how customizable it needs to be.

@vishen I can see that build has failed because GetFloat cant be found.

Looks good. Just the one change to the help text of one of the arguments and then I will merge and release.

Looks good. Just the one change to the help text of one of the arguments and then I will merge and release.


Fix threejs portal demo

Move from babel-plugin-glsl to vite-plugin-glslify
Update encodings_fragment to colorspace_fragment

[x] Ready to merge

The portal shadermaterial is not working in production. I'll have to fix that as well.

One further analysis, it works fine when I run
npm run -w demos/threejs-journey-portal/ build
npm run -w demos/threejs-journey-portal/ preview

But it breaks when running npm run build && npx serve out


HDDS-4259. Edit URI_EXCEPTION_TEXT in BasicOzoneFileSystem to include omServiceId

What changes were proposed in this pull request?
Include the omServiceId as part of the example syntax when HA is enabled: o3fs://bucket.volume.omServiceId/key
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4259
How was this patch tested?
Tested using:

hadoop-ozone/dev-support/checks/rat.sh
hadoop-ozone/dev-support/checks/checkstyle.sh

Added @bharatviswa504 @hanishakoneru for any suggestions or modifications required.

@siddhantsangwan Thanks for the contribution! @hanishakoneru @bharatviswa504 Thanks for the reviews! I have committed the PR to master branch.


Add page to list github repos for a Course

In this PR, we add a page that allows the user to list all repos for a course.
This is done with pagination, and with a filter by repo name, and a filter for visibility (All, Public, Private).
Each repo also now has a "show page" (i.e. you can click on any repo, and go to a page in the app that displays
information just for that repo.)
This is a preliminary step for future work that is NOT in this PR:

being able to setup a page to run jobs against a repo to load all commits for that repo's master branch into the database
allowing the user to download those commits to a CSV

Closes #274


not find compatible versions for pod "MultiplatformBleAdapter"

[!] CocoaPods could not find compatible versions for pod "MultiplatformBleAdapter":
In snapshot (Podfile.lock):
MultiplatformBleAdapter (= 0.1.6)
In Podfile:
react-native-ble-plx (from ../node_modules/react-native-ble-plx) was resolved to 2.0.1, which depends on
MultiplatformBleAdapter (= 0.1.6)
Specs satisfying the MultiplatformBleAdapter (= 0.1.6), MultiplatformBleAdapter (= 0.1.6) dependency were found, but they required a higher minimum deployment target.

I do not get it. The last time podspec for MultiplatformBleAdapter was changed in commit f0d06265176433405e3d1a9c855ec5b7584e2289 of MultiplatformBleAdapter which was made on 9th of December 2019 which was before<EMAIL_ADDRESS>Could you elaborate what was working and is not working anymore?

im upgrade from 1.1.1 to 2.1.1 then i pod install and i get this issue
[!] CocoaPods could not find compatible versions for pod "MultiplatformBleAdapter":
In Podfile:
react-native-ble-plx (from ../node_modules/react-native-ble-plx) was resolved to 2.0.1, which depends on
MultiplatformBleAdapter (= 0.1.6)
None of your spec sources contain a spec satisfying the dependency: MultiplatformBleAdapter (= 0.1.6).
You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, pod repo update does not happen on pod install by default.

Correct me if I am wrong but it seems that the pods even tells you all steps you need to perform to make it work?

yes i try it but not working
i downgrade to @2.0.0 its  working but the problem only on version 2.0.1 on ios

What have you tried? pod repo update?

pod install --repo-update

Judging from cocoapods podspec file everything seems to correctly point to version 0.1.6. It also seems to work on my end.
Do you have any ideas what may be wrong?

why not simply  pod update MultiplatformBleAdapter ?

Its fine thé problème

If you use an m1 apple chipset MacBook like me, use arch -x86_64 pod repo update instead of pod repo update

You should run pod update MultiplatformBleAdapter to apply changes you've made.

You should run pod update MultiplatformBleAdapter to apply changes you've made.

Its working for me, thank you!


Fixing bug on allowMultipleSelection

Fixing bug when allowMultipleSelection is true get weird selection image.

@ajijoyo I can't reproduce the bug this is supposed to fix.

in version 1.3.0, just set allowMultipleSelection = false and try re-click over and over again, and we cant select anymore, and i check,its because when selected just append to selectectImages and selectedAssets and check if photoSelectionLimit <= selectectImages , therefore when allowMultipleSelection == false im remove selectedImage and selectedAssets

@ajijoyo Got it, reproduced! Thank you.


Update packages after repo move.

@jacobrose - I've been a little slow to get the new repo cleaned up.

@kellegous Awesome! Thank you for this! I was able to build and submit a PR for the fix I wanted to do (see #313).


fix the contributing

Description
(Please describe what this PR do.)
fix the contributing
Type of change
Please insert 'x' one of the type of change.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[x] Refactoring, Maintenance
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Dear @dd-jy ,
Is this PR for testing?
The only changes to the file are adding "."

Actually, I cannot remember it...
But it seems to be not bad to be merged.

@dd-jy , Merge anytime you want. :-)

@hyesung2 메일 어떤걸로 가시나요? (test)


Feature/extract ners

Add ner extras to create heat time space maps from place names in corpora.

Merged in #137 .


ci(buildbot): update Go compiler to 1.11.5

buildbot/go-1.11-module failure is expected and will be fixed in #3431.


fonts from js

Description
Really need to download fonts using js?
It cannot be builded correctly
How should look like the building process with the transfer of files? Or add a hash to the file names?

Fonts are not downloaded using js. Most likely you have your font files misplaced.


[move-prover] Implementing the schema apply weaving operator.

This implements the weaving operator for schemas. One can use something like:
spec module {
    apply SumOfCoinsModuleInvariant<X> to public *deposit*<X> except excepted_*;
}
spec schema SumOfCoinsModuleInvariant<X> { .. }

... to apply a schema to all functions in a module which match the inclusion/exclusion pattern.
This mechanism is to eventually replace our existing module invariants which did not work for methods of different genericity.
The example above is taken from the added test marketcap_as_schema_apply.move.
There are some changes to the move-lang parser as well, all simplifications because in type SpecApplyPattern, we actually only need type parameters, not type argument lists.
Motivation
Global specifications.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Add new test.
Related PRs
NA

@bors-libra r=DavidLDill

:pushpin: Commit d89c5aa has been approved by DavidLDill

:hourglass: Testing commit d89c5aa5b8d54c6dfcc8fa4d46a20755a3b1c166 with merge 1e3b7ed72da377a40969f204676105a052aa4199...

:broken_heart: Test failed - checks-actions_land_blocking_test

@bors-libra retry

@bors-libra retry

:hourglass: Testing commit d89c5aa5b8d54c6dfcc8fa4d46a20755a3b1c166 with merge 6a769f52bf4149bf819862a424f68701b7cd49c3...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: DavidLDill
Pushing 6a769f52bf4149bf819862a424f68701b7cd49c3 to master...


[MAS4.2.1][Screen Reader-Connect the bot] Voiceover reads the all content present in the conversation pane in a same flow.

Actual Result:
When focus lands on the conversation pane after link, the voiceover reads the all content in a same flow as they are defined in the complementary landmark.
Expected Result:
The voiceover should only informs about the complementary landmark when the focus lands on the whole pane.
Note:
Same issue found in Debug, here the voiceover narrates the whole content of the conversation pane in a same flow.
Repro Steps:

Open the Bot Framework V4 Emulator.
Welcome tab screen gets opened.
Navigate to the "Open Bot" button and activate it.
Open a Bot Dialog box gets opened.
Navigate to the "bot URL" edit box and enter URL- http://localhost:3978/api/messages
Navigate to "Connect" button and activate it.
"Live Chat" separate window appears.
Navigate to "Type a message" edit box and send some messages.
Now, navigate the pane in voiceover mode and observe the issue after "http://localhost:3978/api/messages".

User Impact:
Voiceover dependent users will find difficulty to understand and navigate the page if the landmark are announced in a same flow.
Test Environment:
OS: MacOs Version 10.15
Application: Bot Framework V4 Emulator (Version 4.5.2-80829)
Impacted MAS Link:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a12f3779-bdf1-40c2-bbcc-0e314ea94858}
Attachment:
Voice reads whole content.zip

@Kumar2608 @awalia13
Since this issue was initially reported, we made a change to the Emulator to update the embedded Web Chat control (#1925) which we believe has changed the Voice Over behavior that you originally experienced.
Would it be possible for you to run through this scenario again and update the ticket so that we can proceed fixing the issue with its current behavior?

@Kumar2608 @awalia13 friendly ping

As verified in the latest version of Bot Emulator, the issue is fixed now.
So, we are closing the issue.
Verified On: 31/10/2019
OS: MacOs Version 10.15
Application: Bot Framework V4 Emulator (Version 4.5.2-87002)


Coordinator's channel announcement chain hash does not match genesis hash

Since we upgraded to rust-lightning:0.0.116 we started seeing this message in the app logs:
lightning::ln::peer_handler: Error handling message from 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156; ignoring: Channel announcement chain hash does not match genesis hash

The error message seems to suggest that the production coordinator sent a channel announcement about a non-mainnet channel.
The log was added with the recent upgrade, so perhaps it just uncovered a problem that was already happening before.

Waiting to see if we see this anymore after the next release.

I guess we may be able to fix that issue by implementing a UTXO lookup on the P2PGossipSync https://docs.rs/lightning/latest/lightning/routing/gossip/struct.P2PGossipSync.html#method.new

UTXO lookup is used to make sure announced channels exist on-chain, channel data is correct, and the announcement is signed with channel owners’ keys.

or changing to RapidGossipSync

The error message seems to suggest that the production coordinator sent a channel announcement about a non-mainnet channel.

I don't think its the coordinators channel, but just a gossiped channel that is not on chain.

Closing this ticket as this should be resolved with switching to rgs. https://github.com/get10101/10101/pull/1631
Reopen if the log message is shown again.


Separate the leafs hash domain from the internal nodes' one

See #20 for the rationale behind this change.

LGTM


Exclude only vmtools check

Hi Jannos,
I'm using your script since 2021, very thank you for the great job, you saved me many times:).
I've some virtual appliances without the vmtools, to avoid the warning I've put the VMs in the $IgnorePattern exclusion, but by this way the VMs are excluded to all checks.
At the beginning of the script, in the comments notes, you write: "If exceptions have to be made on a per sensor level, the script parameter VMIgnorePattern or AlarmIgnorePattern can be used.
Can you give me some tips to implement this exclusion?
Thank you in advance

Hey cipo,
I am happy that this script helps you :)
Could you check if the branch "2-exclude-only-vmtools-check" fits your needs?
Best Regards,
Jannos

Hi Jannos,
just tried, but I received the generic: "The returned XML does not match the expected schema. (code: PE233) -- JSON: The returned JSON does not match the expected structure (Invalid JSON.). (code: PE231)"
I swapped the .ps1 files in the PRTG keeping the same parameters.
Thank you again!

@cipo80 could you try the new version in the branch?
Maybe you also have to right click "unblock" the file.
Otherwise if it is still not working, please enable "store result" and upload the complete ".txt" log (not the ".Data.txt" one)
if it is working you should be able to exclude vmware for vmwaretools check with the -ExcludeVM_VMTools '^(ServerName1|ServerName2)$' command

@cipo80 could you try the new version in the branch? Maybe you also have to right click "unblock" the file.
Otherwise if it is still not working, please enable "store result" and upload the complete ".txt" log (not the ".Data.txt" one)
if it is working you should be able to exclude vmware for vmwaretools check with the -ExcludeVM_VMTools '^(ServerName1|ServerName2)$' command

Hi Jannos, just tried and with unblock the script it's working!
There's still a problem, the -ExcludeVM_VMTools seems to not working good, I've a VM without the tools installed, declared in the PRTG parameters, but the script mark the error.
If I use the -IgnorePattern the VM is exclude correctly, like the first script release, please check the images and store result TXT attached (edited without sensible data).
Thank you agai nfor your time!
Result of Sensor 6459.txt

Next try please :)
I also changed quite a bit to add some other excludes.
hopefully it works now, I don´t have a option to test it currently, thats the reason we have to test it this way.

Hi Jannos,
just tried and nothing change, BUT I've found the problem in the script, there is a typo repeated many times, please replace all the $exlude with the correct $exclude and the script working like a charm!
Thank you for your (spare) time to implement my request, have a great w.end!

good catch :D
fixed it and I wish you also a great weekend 👍🏻


scroll performance on huge list

From @karneaud on March 13, 2015 23:41
Been trying to improve the performance of using list with huge number of list items using the beta-14.
as you can see from this demo kendallarneaud.me/mobile/android/AATT/version/<IP_ADDRESS>/
I've tried using my own list and infinite-scrolling implementations but on an iphone 4 running iOS 7.x. It quits the Safari browser after a certain number of times.
I'm trying to understand what the cause is but can't figure it out. hoping someone can shed some light on it as this performance issue is a huge setback for the framework
Copied from original issue: driftyco/ionic-site#255

@karneaud, I'm having trouble with your example. It sits as loading indefinitely.

Yeah... sorry about that... the server for which i get as my data source from seems to be down. project is on hold until I can get it sorted out

Greetings @mhartington!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.

Greetings @mhartington!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.


unable to trigger actions.intent.NO_MATCH

This is the configuration I've set up for my action:

I've tested against my smartphone, nest hub, and the web simulator. Doesn't seem to trigger or send a request at any point.
Is this the case for anyone else?

 See the note here.

 See the note here.

I had a device with a screen during testing, that was the issue


Giroux7

@dagiro : Thanks for your contribution! The author, @MikeRys, has been notified to review your proposed change.


Allow data to be updated

C3 has the ability to load data using the <chart>.load function.
Because the data in react-c3 is in a property, it cannot be modified and the entire component must be re-rendered.
Looking at react-rt-chart, it seems the way to do this is to use state instead of props.

Hey @adamlwgriffiths - thanks for the info!
It looks like you are correct, we are using generate on every re-render. I'll check out the c3 docs for load and see how we can do it that way (probably just check if this.chart is not null; if it's not we've already generated it and we should use load. We might even be able to get by without using state.
At least I think that's how it should work. I'll do a little investigation - PR's are also welcome!


Drop projection wrappers in tutorial #1

One-hot encoding followed by matrix multiply for input encoding is just bad — I suspected it back when I was writing the tutorial, but thought that using wrappers simplifies tutorial a bit. Now I know that it is not worth it, time to fix it.

Done for both 1 and 2 with 14a1af0abdf5d0f1d483f1c6aad287519784707f


Kube context cluster name with spaces cannot be connected to

Bug Description
If you have your kubernetes cluster context with a name with a space: eg. Staging Cluster, then you are unable to switch to the cluster in VScode:
The error reported:
Failed to switch the namespace: error: Unexpected args: [Staging Cluster]

If I change the name to staging-cluster in the kube config, then connecting works.
Steps to Reproduce

Create a cluster and make sure that the name has a space in the kube config.
Try to switch the namespace and / or the cluster.

Backtrace
No response
Relevant Logs
No response
Your operating system and version
Mac OS latest
Local process
.
Local process version
No response
Additional Info
No response

Hey @alexbowers - thanks for reporting this. Can you share a screenshot how you're doing this? I don't think it's a feature that's part of our extension (rather feature of the VSCode k8s extension 😄 )

Hey @alexbowers - please let me know if it's still relevant.


Running main.py with a single input_params gives the same accuracy

Hey,
I noticed your work on GOT's death prediction, pretty awesome stuff!
I wonder if I'm doing something wrong when i run it with all input_params, and
exclude_rows = range(1000,1500) (just to make it a bit challenge)
i get accuracy:  0.762102351314
but then when i disable all input_params and leave just one, say
input_params = ['book5']
i get accuracy:  0.738589211659, when i was expecting a big drop in accuracy, i also tried different single
input_params and got the same high accuracy.
Do you know why accuracy is so high with a single param?
Thank you in advance
Roy.

Hey Roy,
Thanks for checking out our project!
Running neural network with only 'book5' as an attribute should not be surprising to give almost 74% accuracy since that attribute represents if character appeared in fifth book and because of that there is high chance that if character appears in fifth book that he is alive. That also applies if character does not appears in fifth book there is high chance that he is already dead.
Could you provide me test results including which attributes were used in training and what was the accuracy?
Best regards,
Stefan.

Closed for inactivity.


If token is revoked on org, error displayed and no way to login.

If I revoke that token in the Salesforce org, I get an error and no way to reauthorize again: Failed to retrive GitHub repository details : com.force.sdk.oauth.exception.ForceOAuthSessionExpirationException.

Even if you restart your browser?

Try to access githubsfdeploy.herokuapp.com/logout after revoking access from salesforce.

Should we put a link to this page in the tool header?

Or even redirecting to it in case of an authentication error to Salesforce. We can put a link to Salesforce oAuth usage page ( or whatever the name of the page where you can revoke access) i did something similar for GitHub oAuth. I also should fix the error message too, it's a bit confusing now .

:+1:


fix canSplit when typesAfter contains null element

WhencanSplit is used inside splitListItem, typesAfter contains null as first element. It throws error on typesAfter[i].attrs.

Thanks for fixing that. Merged!

Hi again, just wanted to let you know that lists are pretty broken in 0.22.0, it throws an error when you hit enter on a list item. This PR fixes that, I thought maybe you could publish it to NPM as 0.22.1

Done!


Frequent crashes around the addition of sources & sources not working 1st time when added

Using Version 4.1.2
Seem to be getting frequent crashes when operating with the Add Booru feature, namely when I Click on the 'OK' button on the sources window after adding something to it.
Doesn't happen all the time, but it's pretty jarring if you've had a session open or the like.
Best steps to re-create this is to do what I've been doing to get It:
Open up the sources window, manually add sources (Guess function rarely ever works you see) from http://booru.org/top (Most included are Gelbooru version 0,1 Boorus with a few variants) and deselect your chosen sources to search with save for the one you've just added and click okay and search something with it.
If you did it right, you get a working new source, but at some point between getting the source and adding it in this process, there tends to be a crash during this process, or sometimes though you selected the correct source, it isn't added properly, so you have to delete it and add it again.
Asides from that, thanks for fixing the DL issue, was starved of content for an age.
Edit, seems to occur mostly when you switch windows WITH the sources window open of Grabber.
Edit:I've noticed one of the problems is, It seems when making a transition from one window to the sources window state, for instant, the scroll bar is not present,  and all the sources are bundled together in an instant, before the scroll bar comes in,
It's too quick to capture a screen shot of, but you'll probably see it when you recreate the issue or when opening up the sources window.

Did you make sure not to include the http or https when you added it?
Taking the link you gave at an example, "http://rule34.xxx/" would need to be added as "rule34.xxx"
I agree that should however be removed automatically if someone put it, so I'll remove the http:// and trailing slash it in the next update.
I also managed to get the crash you're talking about, so I'll check this one out too. Seems like there's a problem with some indexes.

Thanks man. also, you need to add a scroll bar to the search results page when you get round to it, because mass sources reduces the page to mere blue pixels.

This should be fixed with the 4.1.3 version (commit 1094ca1c02b2e44ed75b883e7cb30a8ae420062c).


[FR] Bring back autocomplete when referring to fields in the view bar

In the past, typing a field name into a view stage that accepts a field name, like SortBy, would provide an autocomplete dropdown to help you more quickly choose the right field (and to help you see what you should be entering in the field).
But, I noticed that this behavior has disappeared. Can we bring it back!?

This can probably make it into the next release. I just need to think through some things.
We have a field parameter type, label field parameter type, and then sort by which takes a label field or an expression.


update protobuf API to v0.22+

xref https://github.com/mesosphere/kubernetes-mesos/issues/256

It would be lovely to get access to the Mesos shared log as part of this as well. Is that a TODO?

Agreed, a state abstraction would be most welcome. See #139.

Replaced by #167


IOS Fail ReactNativeShareExtension.h

Hi There!
I using this library and get 'ReactNativeShareExtension.h' file not found
I link the library manually
react: 16.8.3
react-native: 0.59.0
react-native-share-extension: 2.0.0
Anyone ever saw this problem?
Thanks

i ve used this package  with all new features with react native greater than 0.60 support  react-native-receive-sharing-intent


Option in config.toml to control requeue strategy

Allow to turn off automatic requeue when a job fails or walltime used up.

upvote. Please add a flag in config.toml to control whether re-queue or not


Package install: Fix ordering when data_dir isnt managed

Previously, we ensured that the package resources comes before creating
a file resource for the data dir. This doesn't always make sense. The
rpm/deb packages (depending in the platform) will create the directory for us, so we
don't need to care about it.
Contains https://github.com/voxpupuli/puppet-consul/pull/604 to proove it's a bug.

Implemented in #610


Bootstrap 4 support

Hi,
if anyone needs a Bootstrap 4 version, here is my fully compatible one : https://github.com/djibe/clockpicker/tree/gh-pages/dist

Thanks man!


chore: remove dependency on activation/wire from tests outside activation

Motivation
Most packages should be unaware of wire types and not depend on packages implementing them (including tests).
This removes the dependency on activation/wire from most other packages.
Description
The actual bytes that are stored don't matter for most tests and even before the change didn't match the domain object thats persisted in some tests. This just removes the dependency and uses random bytes instead.
NOTE: The checkpoint package still uses wire types and in my opinion shouldn't. But to get rid of that dependency we would need to store prevATX and posATX in the DB so we don't have to decode them from the stored blob.
Test Plan

existing tests pass

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge

bors merge

bors merge

bors merge


Generate GraalVM native image config

Motivation:
Armeria and its dependencies (e.g. Netty, JCTools and Caffeine) use
fair amount of reflections, JNI and other advanced features of JVM,
which require explicit configuration when building a native image with
GraalVM. We should provide native image configuration in our artifacts
so that a user can easily build a native image out of the box.
Modifications:

Added a new project flag native. For a project with native flag,
we add a task nativeImageTrace that runs select test cases annotated
with a GenerateNativeImageTrace to collect the trace files generated
by native-image-agent.

See https://www.graalvm.org/22.0/reference-manual/native-image/Agent/

Added a new project :native-image-config, which:

aggregates all traces into native image config; and
cleans up the noise from the generated native image config

Added the initial version of native image config to
META-INF/native-image/com.linecorp.armeria/armeria.
Renamed and relocated some test classes so that they are not included
in the native image config

Result:

A user can now easily build a native image of an Armeria application.
Future works:

Configure our build pipieline to generate native image config for
different platforms automatically (macOS, Linux epoll, Linux io_uring
and Windows).
Use annotation processors rather than reflection for scanning
annotations.
Add entries for Windows and Linux io_uring.

@ikhoon wrote:

I was able to run the SAML example after fixing the code to use InputStream.

Do you think we should update the example, then? 🤔

No today. 😆
Someday, I believe we need a CI to build Armeria examples as native images and run them with minimal setup to verify native image configurations are sensible enough. Let's fix our examples then.

Let me merge this after the build passes AND I confirm the native image configuration actually works manually.


Html5 support for fields

Html5 introduce new attributes for input tag and allow client side form validations.
Currently I hacked lift-record source like following (But a more general solution will be better)

  //TODO find a better way to support html5 addtional attributes (and a way to transform every type of field)
  protected def elemAttr: MetaData = {
    val b = new UnprefixedAttribute("type", "text", Null) // to inject maxLength,...
    isHtml5 match {
      case true => {
        val b2 = regExp.map { x => new UnprefixedAttribute("pattern", x, b) }.getOrElse(b)
        new UnprefixedAttribute("required", (!optional_?).toString, b2)
      }
      case false => b
    }
  }

  protected def elem = S.fmapFunc(SFuncHolder(this.setFromAny(_))) { funcName =>
    val b =
    b % elemAttr
  }

(full source at

http://github.com/lift/lift/blob/davidb_record_protouser/framework/lift-persistence/lift-record/src/main/scala/net/liftweb/record/field/RegExpTypedField.scala
http://github.com/lift/lift/blob/davidb_record_protouser/framework/lift-persistence/lift-record/src/main/scala/net/liftweb/record/field/EmailField.scala
)

And I override localForm method into User( extends MetaMegaProtoUser ) :

  override protected def localForm(user: User, ignorePassword: Boolean): NodeSeq = {
    signupFields.
    flatMap(fi => user.fieldByName(fi.name)).
    filter(f => !ignorePassword || (f match {
          case f: PasswordField[User] => false
          case _ => true
        })).
    flatMap(f =>
      f.toForm.toList.map(form =>
        (
          {f.displayName}{if(f.optional_?) "" else " *"}
          {form.
              map{case e : Elem => e % new UnprefixedAttribute("required", (!f.optional_?).toString, Null)}
          }
        ) ) )
  }

And to allow isHtml5 to return true I add into Boot.boot (lift:Html5 tag set the DocType too late):

   S.addAround(new LoanWrapper{
      def apply[T](f : => T) : T = {
        S.setDocType(Full(DocType.html5))
        f
      }
    })

html5 specs for form validation : http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html
a report about browser support : http://www.findmebyip.com/litmus#html5-forms-inputs
** javascript lib, used to test browser CSS3/html5 support : http://www.modernizr.com/
the page I used to know possible input's attributes : http://miketaylr.com/code/input-type-attr.html
the javacsript lib (jQuery based) I used with html5 to provide form validation : http://flowplayer.org/tools/release-notes/index.html#form
HTML5/CSS/JS template  : http://html5boilerplate.com/

This issue / PR is being closed because the Lift community has decided to decomission the Lift Persistence group of libraries including Mapper, Record, et al. We encourage folks to check out using some alternatives for their persistence needs. In particular the following libraries may be of interest:

ProtoQuill
slick
scalasql

There are likely others, as well! Please feel free to reach out on the Lift Mailing List if you have any questions or concerns.


We have no help page!

The registration form had a couple links to /help but there's no page!
We should create a page with FAQ.

Resolved in #62


SBA support for Teams to Teams (VoIP) calls?

Can you add a clarification to page to say if Teams to Teams (VoIP) calls are supported by the SBA? Scenario: Internet connection goes down. Can users call each other using Teams without it being a PSTN call? In other words, can an SBA be used to maintain intrasite calling in general, or only those users with Phone System making a hairpin call off the PSTN?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 183fc921-e9b1-cc74-2bcb-26d32b994919
Version Independent ID: 1765bda3-dd62-76d7-1e2d-9f5496ac9094
Content: Direct Routing SBA - Microsoft Teams
Content Source: Teams/direct-routing-survivable-branch-appliance.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@ahunkins Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @ahunkins, thank you for your feedback.
I think the article is pretty clear that the SBA is to continue making PSTN calls in case of an Internet outage. For example:
"This article describes how to use a Survivable Branch Appliance (SBA) to enable Microsoft Phone System to continue to make and receive Public Switched Telephone Network (PSTN) calls in the case of an outage."
"When the Microsoft Teams client is in offline mode, the following calling-related functionality is available:

Making PSTN calls via local SBA/SBC with media flowing through the SBC.

Receiving PSTN calls via local SBA/SBC with media flowing through the SBC.

Hold and Resume of PSTN calls."

Correct. But I don’t mean PSTN calls. I mean VoIP calls. Forget the PSTN. Does an SBA allow Teams to Teams audio calls between users on the same LAN when the internet connection to O365 goes down?
If the answer is no, then that means a working PSTN connection is needed just to maintain INTERNAL calling during a PSTN outage, correct? Or no?
Think of a hospital. Can Nurse A talk to Doctor B using Teams (with an SBA) in the event of internet failure?
Andrew
Andrew Hunkins
Field Solution Architect | Microsoft Collaboration | CDW
Phone:<PHONE_NUMBER>tel:+18473712950 – Central Time Zone
From: Dario Woitasen @.>
Sent: Wednesday, April 14, 2021 7:00 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness @.>
Cc: Andrew Hunkins @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] SBA support for Teams to Teams (VoIP) calls? (#6953)
Hi @ahunkinshttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ahunkins&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=dCqlv-nyIPyymjGw1B0-lFUuBeUOQFyWb4zkH-cqM0Y&s=uiHPc4l0gJpK_tJ7V4nySD6la5oCe_MR9lA-569YzYI&e=, thank you for your feedback.
I think the article is pretty clear that the SBA is to continue making PSTN calls in case of an Internet outage. For example:
"This article describes how to use a Survivable Branch Appliance (SBA) to enable Microsoft Phone System to continue to make and receive Public Switched Telephone Network (PSTN) calls in the case of an outage."
"When the Microsoft Teams client is in offline mode, the following calling-related functionality is available:

Making PSTN calls via local SBA/SBC with media flowing through the SBC.
Receiving PSTN calls via local SBA/SBC with media flowing through the SBC.
Hold and Resume of PSTN calls."

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_OfficeDocs-2DSkypeForBusiness_issues_6953-23issuecomment-2D819463219&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=dCqlv-nyIPyymjGw1B0-lFUuBeUOQFyWb4zkH-cqM0Y&s=8Og6bE3T-i13u1VBWkXALq1UDDb1GDbU7EI6T3SWU0A&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ARJG2E2SY2NOTWJ43TQ2DWLTIV7U5ANCNFSM42FEGT7A&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=dCqlv-nyIPyymjGw1B0-lFUuBeUOQFyWb4zkH-cqM0Y&s=zriKbwhdjCsqNUeu6TvaB0EU9h3_vzXBuhWAaI94F94&e=.

@ahunkins peer-to-peer Teams calls between two Teams desktop clients in the same network are not available in offline mode, only PSTN calls.

Have in mind the following requirement:
"The SBC needs to be configured for Media Bypass to ensure that the Microsoft Teams client in the branch site can have media flowing directly with the SBC"

Thanks. I think this explanation will improve the documentation.
When customers look at the SBA solution, they are trying to duplicate the survivability of a distributed PBX environment. If a hospital has a PBX and the internet goes down, they can still call each other internally. This is not the case with Teams. If the PSTN is required to do so, then the user experience will be critical. If Nurse A normally calls Doctor B by clicking the phone icon for a peer-to-peer call, what happens when the internet goes down? Does Nurse A somehow have to know to use the drop down to select Doctor B’s DID (or mobile number), or find Doctor B’s DID in his contact card? In fact, the article/documentation could be improved with a description of the UX differences in the event of internet failure / survivability mode.
I would also suggest you heavily emphasize the fact that hard phones are not currently supported for survivability with an SBA. Such a use case is assumed for an old school PBX. Any organization expecting “survivability” from an SBA must understand this point.
Thanks for listening!
Andrew
Andrew Hunkins
Distinguished Field Solution Architect | Microsoft Collaboration | CDW
Phone:<PHONE_NUMBER>tel:+18473712950 – Central Time Zone
From: Dario Woitasen @.>
Sent: Thursday, April 15, 2021 2:00 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness @.>
Cc: Andrew Hunkins @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] SBA support for Teams to Teams (VoIP) calls? (#6953)
@ahunkinshttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ahunkins&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=4BR7ZBcwZy6oM-52vVe4KrGEjh_KrQRM9MimYKKEMRk&s=eTHMD08HYZ0hhqWVARbmv7RN7bt6Zo65fkWOwl2a1I4&e= peer-to-peer Teams calls between two Teams desktop clients in the same network are not available in offline mode, only PSTN calls.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_OfficeDocs-2DSkypeForBusiness_issues_6953-23issuecomment-2D820169868&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=4BR7ZBcwZy6oM-52vVe4KrGEjh_KrQRM9MimYKKEMRk&s=me2sjcXIr1bk-khRoVkdcXzolWXHYhnRCrUwl7V4cm4&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ARJG2E72QATIYHDHPCX7RMLTI2FG7ANCNFSM42FEGT7A&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=4BR7ZBcwZy6oM-52vVe4KrGEjh_KrQRM9MimYKKEMRk&s=c79Bpyf209ME4vD2ZQJ3mPeu6OHduTv8E4U6Lvm4Bbk&e=.

I'm not sure if I fully understand you and can apply the updates you are suggesting.
Maybe @CarolynRowe you can kindly help here. Thanks!

@ahunkins another important information. There are plans to add peer-to-peer calls support for this scenario.

Okay. Well, maybe just stating that fact in the documentation is enough.
Make clear hard phones are not (yet) supported. Make clear peer-to-peer calls are not (yet) supported. That should help a perspective customer (who’s knows how a PBX works when the internet goes down) understand what an SBA can and can’t do (today).
Andrew
Andrew Hunkins
Field Solution Architect | Microsoft Collaboration | CDW
Phone:<PHONE_NUMBER>tel:+18473712950 – Central Time Zone
From: Dario Woitasen @.>
Sent: Monday, April 19, 2021 4:24 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness @.>
Cc: Andrew Hunkins @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] SBA support for Teams to Teams (VoIP) calls? (#6953)
@ahunkinshttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ahunkins&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=lVGU9f2_sqRbBGQI2qeTca5U3WCkOzWCpfP-IFalVQs&s=CSw195jJb3J4GFVz44-oyzE51sc_OhMpgJ6U4a5h4Is&e= another important information. There are plans to add peer-to-peer calls support for this scenario.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_OfficeDocs-2DSkypeForBusiness_issues_6953-23issuecomment-2D822317441&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=lVGU9f2_sqRbBGQI2qeTca5U3WCkOzWCpfP-IFalVQs&s=OfyKbBlViTz25QhHrKcG6MEik_b6jL7WYS7iTxB-qH8&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ARJG2EZGRQCFYGV43BXUJATTJPZDTANCNFSM42FEGT7A&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=lVGU9f2_sqRbBGQI2qeTca5U3WCkOzWCpfP-IFalVQs&s=mqY_rejWmsRCl9Ton1Mj_gOEHhYkWgvu4eV8xMgg0Zk&e=.

@ahunkins to be honest, I'm not convinced to add that.
About desk phones, I think the article clearly states that this feature only works with Teams Windows desktop and Teams macOS desktop.
About peer-to-peer calls, I think the article clearly states that the only supported scenarios are:

Making PSTN calls via local SBA/SBC with media flowing through the SBC.

Receiving PSTN calls via local SBA/SBC with media flowing through the SBC.

Hold and Resume PSTN calls.

If we add something not supported, it can lead to list all the unsupported features. Maybe I could be wrong, but that's my thinking on this.

Roger that. Thank you!!
Andrew Hunkins
Field Solution Architect | Microsoft Collaboration | CDW
Phone:<PHONE_NUMBER>tel:+18473712950 – Central Time Zone
From: Dario Woitasen @.>
Sent: Monday, April 19, 2021 9:53 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness @.>
Cc: Andrew Hunkins @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] SBA support for Teams to Teams (VoIP) calls? (#6953)
@ahunkinshttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ahunkins&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=uI0aa7mKWqcBoMY-UWZ-t6B_oRVt1LkXkwjcEtSbkOw&s=yzAGIjcELzZvw0bHanUH0p_nQJM1y-NynHjrawoh--4&e= to be honest, I'm not convinced to add that.
About desk phones, I think the article clearly states that this feature only works with Teams Windows desktop and Teams macOS desktop.
About peer-to-peer calls, I think the article clearly states that the only supported scenarios are:

Making PSTN calls via local SBA/SBC with media flowing through the SBC.
Receiving PSTN calls via local SBA/SBC with media flowing through the SBC.
Hold and Resume PSTN calls.

If we add something not supported, it can lead to list all the unsupported features. Maybe I could be wrong, but that's my thinking on this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_OfficeDocs-2DSkypeForBusiness_issues_6953-23issuecomment-2D822530835&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=uI0aa7mKWqcBoMY-UWZ-t6B_oRVt1LkXkwjcEtSbkOw&s=QMOk0zqM5FIz59Gzucc25m3eLSw0Tpq2Gk2yPLqNt6g&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ARJG2E27E245XXOCDHGFCUTTJQ7VPANCNFSM42FEGT7A&d=DwMCaQ&c=PzM68gSF_5r1R7BCE75oeA&r=MwOnmrYKOSWmB8WUHGCKPAY7cnUJNn1AYHdKVT-8Tqc&m=uI0aa7mKWqcBoMY-UWZ-t6B_oRVt1LkXkwjcEtSbkOw&s=Jx8TNGi2F0kmSGxbcZcRV6ybEBT5UZTcZJW89DpsR5c&e=.

Thank you very much for your comprehension. Although we disagreed on this topic, I encourage you to continue contributing to docs.microsoft.com. Any feedback is very valuable for us.

Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Add connection string config file path

I'm reading the database connection properties from a configuration file and putting them in an field in the event, using the ruby filter plugin.
Would it be difficult to add string interpolation to the connection string, so I can keep sensitive information out of my logstash.conf file?
I think the change would just be something like this:
@connection = driver.connect(event.sprintf(@connection_string), java.util.Properties.new)

In this line: https://github.com/theangryangel/logstash-output-jdbc/blob/master/lib/logstash/outputs/jdbc.rb#L74
Does that make sense?
Thanks.

I see that change is not possible because connection string is determined in the register phase.
What about another plugin parameter like "config_path" that points to a database.yml?

I'm happy to accept the pull request, if there's a reason I'm not seeing (forgive me if I am, but it's the end of the day here and I'm pretty tired :sweat_smile:)... but I'm not sure of the benefit?
My thinking; the user that logstash runs as will need to read the yaml file - so it's not like you're trying to prevent the logstash user from being able to read the credentials? As a matter of best practice I'd make sure that the logstash configuration should be reasonably secured anyway i.e. locked down to the account that logstash runs as.
If it's a case of ease of deployment, you should be able to template the logstash configuration using your deployment tool(s) - which negates the need for another configuration file.
I'm just trying to understand what I'm missing :smile:

Yes, I see. Looks like using templates is the way to go with logstash, since no other plugin has this feature.
Ok, sorry for the inconvenience and thanks for your time :)

No problem @enriquerodbe :smile:
If there is a reasonable reason, other than just another config file I'm happy to accept the pull request.
I know other plugins have considered supporting environment variables and string interpolation, but I don't know of any that currently do it. I'd be kinda fine with that personally, rather than another config file, but thats just me :laughing:

@enriquerodbe  - just as a FYI incase you missed it, Logstash now supports ENV vars  - https://www.elastic.co/blog/logstash-2-3-0-and-2-2-3-released


Iodine

The "iodine" concept of event tracing would be very helpful in app development. It should provide a sequence map of events, when they're fired, what fired them (LOC), and the ability to explore the event/payloads.
Ideally, this would provide a visual/clickable map.
A devtools extension would also be nice (or a Fenix logging add-on) to emit a desktop notification when a specific event is called.

Kamino closed and cloned this issue to ngnjs/NGN


Chat history got deleted

Describe the bug
I had build an app however it is being automatically deleted which is very frustrating. I have put that much effort to reach at some level and all of a sudden it is gone. Can you pls reinstate my chat and it was to create an accounting app.
Link to the Bolt URL that caused the error
Not available
Steps to reproduce
it is not regarding the steps
Expected behavior
The chat should have been in history
Screen Recording / Screenshot
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

Wish they take note of it and get it fixed  quickly, else I have to ask for
refund.
On Thu, 14 Nov 2024 at 11:33 PM elogicuk @.***> wrote:

Same here bro i dont believe they have bugs like this, this should be a
alpha release not a paid app im so pissed i wasted alot of time.
—
Reply to this email directly, view it on GitHub
https://github.com/stackblitz/bolt.new/issues/2386#issuecomment-2477621385,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHODLD2I4K4QTFYVPCH5NPT2AUXLVAVCNFSM6AAAAABRZ64ALSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZXGYZDCMZYGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi all,
Sorry to hear about this! A few things you can try:

Go to stackblitz.com, login (same credentials as Bolt), click Collections on the left-hand side of the page, then open Bolt Collection. See if your project is there.

While in a chat session on Bolt, mouseover the left-hand side of the screen to open the options menu. Open Settings and then click Backups. Select a backup to restore to a previous state.

Hello, That was helpful. It is available on stackblitz.com](https://stackblitz.com/


Add 3rd arrow to visio pics

It seems that the Visio files are missing the third arrow from the Data tier subnet (from LB to VM).

@MikaVirkkunen,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/dmz/secure-vnet-dmz.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


What can be done to achieve (system) symbol resolution for minidumps?

I'm working on a Windows Minidump loader for Ghidra. The basic memory loading works fine currently, which is already a huge help in being able to position the modules in proper addresses to follow calls between modules.
The next thing I'd love to achieve is better symbol name resolution. I'm not completely familiar with the mechanism Ghidra uses for resolving symbol names, but I noted for PE files the system symbols are resolved even with no PDB files being available. The minidumps have module information embedded in them so I'm now wondering whether there is a way to communicate that to Ghidra to allow Ghidra to resolve the symbols?
I noted that some symbols were already resolved by the analyzer in some cases (atoi, __CheckForDebuggerJustMyCode), which made me hopeful that being able to resolve more of them wouldn't be too difficult.
If no one is able to answer this, my fallback plan will be to dig through the PE-loader and see how it provides the module information to Ghidra. Even if no one can describe the mechanism in full, I'm hoping someone could give at least a pointer at which parts of the PE loader I should start my research from.
I know analyzing Minidumps (ie. runtime state) is slightly off the usual use cases of reverse engineering programs, but my other option was tracking calls in Inkscape and that was getting unbearable. :)

Does the Minidump file have the full PE header present?

Now that you mention it, it should. I'm not completely familiar with either one (the last few days have been a bit of a crash course into working with these files by hand), but as far as I know, the complete file image is part of the process memory and should be part of the dump.
The dump also lists the included modules, together with their base address where they are loaded in the memory: https://docs.microsoft.com/en-us/windows/win32/api/minidumpapiset/ns-minidumpapiset-minidump_module
The radare blog has an article that has extracting the PE file from the minidump as one of the examples. I did consider just doing that and then working with those files instead of trying to debug the dump as is - but that would lose the runtime information (process stack, etc.).
Re-using the PE information in loading the symbols sounds like a definite step towards the goal. I guess I'll just need to figure out how to feed the base address information to whatever part processes the PE stuff.

Check out the PortableExecutable class.  It can be created with SectionLayout.MEMORY for your case, if you have an in-tact memory dump of the entire PE file.  You can look at the PeLoader.load() method to see how it uses the PortableExecutable class (with SectionLayout.FILE in this case).  You'll also see PeLoader.load() call processSymbols(), which may also help you.

Thanks! Those tips will definitely be useful when I'll get back to the project over the weekend!

Got my symbols loading! Thanks a lot for the pointers, they ended up working great!
In the end I ended up just calling into PeLoader directly (after copying the class over and exposing some of its internals as static methods). The big thing I couldn't directly reuse was the actual PE image loading.

Instead of relying on program.getBaseImage(), which is set to the base address of the Minidump (in practice just 0x0), I'm keeping track of the individual PE base addresses as defined in the Minidump MINIDUMP_MODULE struct and using that to calculate various section offsets.
Include the name from MINIDUMP_MODULE in the sections (HEADERS, `.text´, etc.) to avoid duplicate names.
Move the individual module fragments into their own folders to better organize them.

Once the individual PortableExecutable had been loaded and its memory mapped into the Program with section addresses resolved in a Map, the rest of the processXyz methods worked more or less as is. The only thing I had to comment out for now was the Ghidra comment handling, since those are relying on actual instance data and getting them working through static methods would have required moving the comment maps to parameters.
I do feel the code changes required to support using PeLoader/AbstractPeDebugLoader directly for this wouldn't be too bad if Ghidra ever wants to upstream this implementation, but for now I'll just keep using the copied loaders.
I'll close the issue since the original problem was answered and I feel a bit more comfortable digging through the Ghidra code base myself in case I encounter more similar problems.
With any luck I'll have something useful out next week.


Added support for easily making channels out of observables

The 'problem' is that simple
const chan = observableChannel(Observable.from([1, 2, 3]))
yield take(chan)

will result in END, as subscribe happens first, before taking, but I guess its just the nature of observables and there is not much to do about this without buffering and it is hard to tell upfront what buffers should be used by default.
Ideas:

wondering if we could handle yielding observables (maybe wrapping them automatically with observableChannel? and then we could treat call results the same same when observable
also maybe we could implement $$observable on the middleware so put actions can be observed?

We could delay subscription until the first take (using a custom channel instead of eventChannel). I think this makes more sense since most of the observables are lazy (cold). And for the case of eager (hot) observables I dont think it makes a difference (unless we introduce buffering, but I dont think we need to support buffering for those channels since observables have more powerful support for that)

Hm, delaying the subscription is certainly a neat idea, only cancelation, unsubscription etc will be a little bit more trickier, shouldnt be a problem though. Gonna attemp to implement this.
In most cases such event channels gonna be created and immediately followed by a take, so it in fact doesnt really matter, as take will have its opportunity to set up, therefore subscribe and nothing will be missed as nothing can happen in the same stack.
As to buffering - we have those primitives already so it is reasonable to allow passing them in I think.
For a brief moment I thought it would be neat to propagate the item to every registered taker, but after a thought it would only cause confusion and also initial take (the one causing subscription) would be problematic.

also maybe we could implement $$observable on the middleware so put actions can be observed?

WDYT about this idea?

also maybe we could implement $$observable on the middleware so put actions can be observed?

would be useful

We could delay subscription until the first take (using a custom channel instead of eventChannel)

Sorry to comment on an old PR but I'm facing the same problem (also using eventChannel). @Andarist did you figure out something or have some tips to share?

Umm, passing buffers.expanding() to eventChannel seems to fix the issue. Not sure if I missed anything.


Schema with enum and Default value generating wrong Schema

hello, I have a really simple class with just one field (whose type is a custom enum) and a default value
public enum MyEnum {
    DefaultValue = 0,
    FirstValue = 1,
    SecondValue = 2
}

public class MySchemaClass {
    [System.ComponentModel.DefaultValue(MyEnum.SecondValue)]
    public MyEnum MyDefaultField {get; set;} = MyEnum.SecondValue;
}

and generating the JSON schema like this
var schema = await JsonSchema.FromTypeAsync<MySchemaClass>();
Console.WriteLine(schema.ToJson());

the generated schema is this one
{
  "title": "MySchemaClass",
  "type": "object",
  "additionalProperties": false,
  "properties": {
    "MyDefaultField": {
      "default": 2,
      "oneOf": [
        {
          "$ref": "#/definitions/MyEnum"
        }
      ]
    }
  },
  "definitions": {
    "MyEnum": {
      "type": "integer",
      "description": "",
      "x-enumNames": [
        "DefaultValue",
        "FirstValue",
        "SecondValue"
      ],
      "enum": [
        0,
        1,
        2
      ]
    }
  }
}

but when I paste that into react-jsonschema-form playground I see 2 select components

if I remove the "oneOf" from the schema properties, like this
"properties": {
    "MyDefaultField": {
      "default": 2,
      "$ref": "#/definitions/MyEnum"
    }
  },

it works properly...

how is the proper way to have default value for a "select" component or is it an issue?
ps: If a don't add the DefaultValue attribute to field, it will generate only the $ref prop and will work properly (but without a value being set by default of course)

hey, any tip related to my problem?

hey, any tip related to my problem?

The reasoning behind this is that you might have two props with different defaults referencing the same enum. $ref is not allowed with other props (default in this case) so the only option is to use a oneOf $ref here.. my proposal is to ask the react form guys to fix/support this case in their component?

The reasoning behind this is that you might have two props with different defaults referencing the same enum. $ref is not allowed with other props (default in this case) so the only option is to use a oneOf $ref here.. my proposal is to ask the react form guys to fix/support this case in their component?

Ah another option: There is a setting similar to allowReferencesWithProperties on the schema generator which generates $refs even if there are other props - its technically invalid json schema but many tools allow it...

Ah another option: There is a setting similar to allowReferencesWithProperties on the schema generator which generates $refs even if there are other props - its technically invalid json schema but many tools allow it...


Fix blank view when report is deleted

Explanation of Change

A blank detail page is shown when deleting report from debug page for from another client. This PR fixes it by preventing showing the blank view if the screen is focused.
Fixed Issues

$ https://github.com/Expensify/App/issues/51388
PROPOSAL: https://github.com/Expensify/App/issues/51388#issuecomment-2434992806
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite: enable debug mode

Open any chat
Press the header to open details
Press Debug
Scroll to the bottom and press Delete
Verify you see a not found detail page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/3258fef8-1196-4cf2-92c7-022129fe7fdc

Android: mWeb Chrome

https://github.com/user-attachments/assets/f194e9e7-9050-48ac-920f-9c37c97c91c9

iOS: Native

https://github.com/user-attachments/assets/8517f432-2850-42c3-9596-e48324cf3c5e

iOS: mWeb Safari

https://github.com/user-attachments/assets/cb7e3994-6e4c-4b66-aa26-c909c21d20fd

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/8563aa1b-0c92-4c75-91ed-365cc7259cb2

MacOS: Desktop

https://github.com/user-attachments/assets/7f3b8256-1102-4432-87ab-7b88405bc289

After deleting the report, the report screen will infinitely show a skeleton loader instead of a not found page because wasReportAccessibleRef here is true.
https://github.com/Expensify/App/blob/bef062b4caa7f665159dc107911e708031e648c4/src/pages/home/ReportScreen.tsx#L391-L394
It was first added at https://github.com/Expensify/App/pull/33041 and its purpose is actually similar to contentShown, that is to prevent showing the not found page when the report is deleted while getting navigated to another report. But I'm not sure if we can isFocused state because report screen is not focused when RHP is open.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This PR is failing because of issue #52191

Oh, this PR https://github.com/Expensify/App/pull/51425 now changes it so when we delete the report, we navigate to concierge.
https://github.com/Expensify/App/blob/c658375530adce8cf24d641523556a91712e741d/src/pages/Debug/Report/DebugReportPage.tsx#L146-L148


iOS Native App

Thanks for this project - I love the idea of the business logic and view models in the Kotloin shared layer.
I am concerned about the iOS application - it does not feel like a native application due to the navigation style being employed. There are no animations. Is this by design? Can we use this architecture with the regular iOS Navigation, so it feels completely native?

The thing could be easily solved by setting up the same iOS animation of the iOS Navigation. I am just not expert with iOS animations. Someone with experience in iOS animations can easily fix this.
SwiftUI navigation is very limited and can get very messy when projects gets complex. A shared navigation can really make things very easy on bigger multiplatform projects.
I have tried to wrap the SwiftUI navigation, but it's a big mess, as NavigationLink is a dreadful piece of software. Hopefully at the new WWDC in a couple of weeks, there will be upgrades to SwiftUI navigation, and things can get easier?

I actually found a solution, to use native SwiftUI navigation!
It was able by keeping a map of all active NavigationLinks.
I should be able to publish the update within a week.

This is great to hear. Will look forward to the update - hopefully I can help with the iOS refinements...

Hi. How are you? Any progress on the code?

Hi @adesugbaa, it took more time than expected. I am still refining. Hopefully I will be able to publish the update this week.

I am currently blocked by an issue on Compose beta08:
https://issuetracker.google.com/issues/190795684
I will have to solve this, before publishing the new version

I read the issue will be fixed in Compose beta09, which will be released next week.
So I should release the new version then.

I am trying to put all together now with the Desktop and Web version too, but it's still not ready.
For the time being, writing shared code that is optimised for 4 different platforms (Android, iOS, Desktop, Web) presents several challenges. I still trying to understand a few things.
I am planning to publish the next update when I am happy with overall result, but as it looks now, it might take some time.

Hi @adesugbaa, I have finally managed to publish the update.
Now the iOS app is using NavigationLink under the hood, so native animation occurs when navigating to a new screen.
I have also published the Desktop app.

Thanks @dbaroncelli. I will test and provide feedback.


Projetcwide settings for character encoding, line endings tab width etc...

If your IDE does not support it out of the box please find and install a plugin for your environment from EDITORCONFIG
Your welcome

😍

Thanks @daffyDukk