Linking - canOpenURL returns wrong response

Description
Linking.canOpenUrl returns true even the app is not installed on the device.
For example on iOS I removed both google maps and apple maps but didn't remove waze. When I check which app is installed using Linking.canOpenUrl($urlscheme) it returns true for waze and apple maps but not for google maps.
Version
0.67.2
Output of npx react-native info
System:
OS: macOS 12.3.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 99.62 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 14.15.5 - /usr/local/bin/node
Yarn: Not Found
npm: 8.12.1 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /Users/brent/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK:
API Levels: 28, 29, 30
Build Tools: 29.0.2, 30.0.2
System Images: android-29 | Intel x86 Atom_64, android-29 | Google Play Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.2 AI-202.76<IP_ADDRESS>86908
Xcode: 13.4/13F17a - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_292 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Calling the provided function in the example results in the bug.
Snack, code example, screenshot, or link to a repository
export default async function isAppInstalled(appName: string, appList: AppListType[]) {
  const urlScheme = appList.find(app => app.name === appName)?.urlScheme;
  if (!isValidString(urlScheme)) {
    return false;
  }

  try {
    const hasApp = await Linking.canOpenURL(`${urlScheme}://`);

    return hasApp;
  } catch (err) {
    /* eslint-disable no-console */
    console.warn('Can not open app');
    return false;
  }
}

This is a duplicate of https://github.com/facebook/react-native/issues/34037
Please follow up over there 👍


Changes to README.md for xSQLServerDatabaseRecoveryModel

Changed anchor link for xSQLServerDatabaseRecoveryModel to lower-case.
I missed this in the review before I merged the recent pull request. This will make the link work.
This Pull Request (PR) fixes the following issues:
n/a

[ ] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


fix move fault-injection data to the right place (pick from master 26618)

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Doc Browser ehnancements

Build doc browser support for defining top-level home pages for types.
** Apps can achieve the override by registering templates that respond to the ‘home’ type (instead of the other existing ‘label’,’embedded’ and ‘standalone’ modes).
Enhance doc browser to show header and location expectations on action responses that have them defined
redefine all base response templates so that all can take/override media_type:,location:,headers: and description parameters when defined in actions (all of them optional)

Coverage increased (+0.9%) to 92.436% when pulling a29e9878eb3fd360c79be8c1756354107b893428 on override_docs_type_homepage into 43e80246bf6af0fd88f50bde9084ab4f24f74fab on master.

Coverage increased (+0.9%) to 92.436% when pulling c854a49bde4ced1806adb827a75307036b685ffd on override_docs_type_homepage into 43e80246bf6af0fd88f50bde9084ab4f24f74fab on master.

LGTM. @gampleman should probably give all the squiggly-bracket based code a looksee though.

Coverage increased (+0.9%) to 92.431% when pulling 975e4b8b87586941f6753f56cbe690accee38d29 on override_docs_type_homepage into 43e80246bf6af0fd88f50bde9084ab4f24f74fab on master.

Coverage increased (+0.9%) to 92.436% when pulling 0a133d0a6def2ef82cfab39249f1ff371b90f53f on override_docs_type_homepage into 43e80246bf6af0fd88f50bde9084ab4f24f74fab on master.

Also would be good to update the docs about doc browser customization with the new option.

Coverage increased (+0.9%) to 92.431% when pulling 108b16411b59ed9b699063acf5e3f95069791add on override_docs_type_homepage into 43e80246bf6af0fd88f50bde9084ab4f24f74fab on master.


kongdash start failed on centos7

0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 silly lifecycle<EMAIL_ADDRESS>no script for prestart, continuing
7 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>8 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
9 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/root/kongdash/node_modules/.bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/root/bin
10 verbose lifecycle<EMAIL_ADDRESS>CWD: /root/kongdash
11 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'gulp start' ]
12 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
13 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
14 verbose stack Error<EMAIL_ADDRESS>start: gulp start
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:885:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd /root/kongdash
17 error Linux 3.10.0-327.el7.x86_64
18 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
19 error node v7.2.1
20 error npm  v3.10.10
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>start: gulp start
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>start script 'gulp start'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the KongDash package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     gulp start
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs KongDash
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls KongDash
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

A new version (now called Primate) is released. Please open a new issue if this problem still exists.


[FEATURE] Add html preview of dataset

This PR is still work-in-progress. It's not a complete feature yet!
Currently the preview is done by __html__() function in Dataset.py, which is a pure python implementation using data from collect(). The problem is that it is really slow on the large dataset
I am in the middle of adding takeLast() operator to C++ backend, which will speed up the computation (hopefully!).

test is passing now, so this is ready to merge whenever you're ready @LeonhardFS


fix(connectivity_plus): Ensure Connectivity on Android is correctly reported when lost

Description

Doing tests, I noticed that the connectivity did not change when disabling mobile connection, see https://github.com/fluttercommunity/plus_plugins/issues/2831#issuecomment-2048946133

The events received in onConnectivityChange were not correct.
When I disconnected mobile, the onConnectivityChange was still reporting connectivity mobile.

I did some changes on the connectivity change listeners in Android and the issue is gone.

In the onLost callback, the plugin will emit a none to ensure plugin consumers get notified connectivity is lost.
In the other two callbacks, use the provided Network and Capabilities objects, this ensures that the actual event payload is used and not reading a value that may be not up-to-date.
I added a distinct to the stream, because the callback was being called a lot of times after a change. I don't think users will miss that ;)

Tested on Pixel 5, disconnecting wifi and/or mobile network, and it gets reported correctly.

What a plugin consumer will see:

Phone connected to wifi and mobile: [wifi] is emitted.
Phone disconnects from wifi: [none] is emitted.
Phone connects to mobile: [mobile] is emitted.
Phone connects to wifi again: [wifi] is emitted.
All connection is lost: [none] is emitted.
etc.

With a VPN + wifi will be similar:

Phone connected to wifi + vpn: [wifi, vpn]
Phone disconnects from vpn: [none]
followed by: [wifi]

I don't think getting a [none] in the middle should be an issue, but otherwise this has been documented in the method.
BTW, from the Android documentation:

Do NOT call ConnectivityManager.getNetworkCapabilities(android.net.Network) or ConnectivityManager.getLinkProperties(android.net.Network) or other synchronous ConnectivityManager methods in this callback as this is prone to race conditions ; calling these methods while in a callback may return an outdated or even a null object.

Which is why users were still seeing mobile connectivity even if it was disconnected.
The 100 ms delay we had in place was not enough to ensure that wasn't an issue.
Related Issues

Fix #2831
Potentially other older tickets.

Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I titled the PR using Conventional Commits.
[x] I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[x] No, this is not a breaking change.

Reading a bit more the Android documentation, I need to do some changes, as this is not fully correct still.

BTW, from the Android documentation:

Do NOT call ConnectivityManager.getNetworkCapabilities(android.net.Network) or ConnectivityManager.getLinkProperties(android.net.Network) or other synchronous ConnectivityManager methods in this callback as this is prone to race conditions ; calling these methods while in a callback may return an outdated or even a null object.

It is something I shared in this PR adding 100 ms delay: https://github.com/fluttercommunity/plus_plugins/pull/2673#issue-2178781449
I think it depends on device, because I had no issues on Pixel 7 and emulators.

The events received in onConnectivityChange were not correct.
When I disconnected mobile, the onConnectivityChange was still reporting connectivity mobile.

In the PR that I already mentioned above there is a screen recording that disconnecting mobile works fine and updates status properly. It was on a real device. And same happened on emulator.

I have updated the implementation, the onLost callback now doesn't emit a [none], but rather uses the same postDelayed as before, except the delay is now 500 millis rather than 100. This ensures that the device has enough time to report the correct value.


Feature Request - Audio Spectrogram Integration

Would like to know if it's possible to integrate this guys work.

winner of the logitech challenge contest
Dhyan Yahampath
Description: This program displays an audio spectrogram on your Logitech RGB Keyboard based on the audio currently playing on your computer. The ARX app is used to control the spectrogram or to display its on-screen output.

It's pretty fun to play with but it doesn't seem to play nice with Aurora. You can only have one or the other running his Spectrogram software overrides Aurora.
Sadly I'm not much of a coder and this is beyond my capabilities or I would try to figure it out myself. Would love to see the two programs play nice so I can more easily watch my keyboard beat to the music and change on load up to a game.
crosses fingers

So this? #34
Also, patching Logitech LED SDK with Aurora's wrapper will make it go through Aurora.

Hah yes exactly :) Sorry I'll look harder before posting, I'm new to all of
this. Just got the G910 keyboard for Christmas and was kind of disappointed
by the lack of Logitech software/plugins so I went searching elsewhere and
found Aurora. Used to have a G15 and some pretty cool display features for
it like seeing who is talking on Ventrilo, What song I have playing and
more. As cool as the ARX app could be it's really lacking. I hope things
improve with Logitech but in the meantime Aurora seems to add a lot more.
On Wed, Dec 28, 2016 at 7:34 PM, Anton Pupkov<EMAIL_ADDRESS>wrote:

So this? #34 https://github.com/antonpup/Aurora/issues/34
Also, patching Logitech LED SDK with Aurora's wrapper will make it go
through Aurora.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/antonpup/Aurora/issues/283#issuecomment-269577272,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXq2u7EE1m6u--v4xrawyR-bo5Ykgj8Qks5rMypRgaJpZM4LXU43
.


repair time calculation

Related: #36
Just adding functionalities for calculating repair time, not sure where to put it in the UI though.
To load the module:
var RT = PS['KanColle.RepairTime'];

Interfaces are:

RT.dockingInSecJS(<ship type>,<ship level>,<current HP>,<max HP>) for calculating docking time, return value are in seconds.

RT.facilityInSecJS(<ship type>,<ship level>,<current HP>,<max HP>) for calculating Akashi's repair time (as I described in #36)

One example:

> var RT = PS['KanColle.RepairTime'];
> RT.dockingInSecJS('FBB',80,26,83)
45345
> 12*3600 + 35*60 + 45
45345
> RT.facilityInSecJS('FBB',80,26,83)
45600
> 12*3600 + 40*60
45600

:+1:

:+1:


Make the environment variable name more explicit

See: https://github.com/moul/travis-docker/issues/28#issuecomment-126431850
BRANCH should be TRAVIS_DOCKER_BRANCH

I need to :

[ ] Look at the other variables
[ ] Update scripts and documentation
[ ] Don't break the compatibility for at least the next release

Thanks for your diligence on this :)


Shipped version of plugin generator should match shipped version of Kibana

Right now the plugin generator only supports Kibana master and there's no obvious way to only use 4.4 supported features. We shouldn't release a plugin generator that requires a version of Kibana we haven't released.

I think this is resolved now that Kibana 5.0 is released.
We have also improved the tooling a bit to ask which kibana version you want to write for (only listing options for supported version) and if you choose master then the build script will ask you which kibana version you are building when you build.

We are also mostly matching the elastic stack version now


Removed invalid overwrite for return value.

While working on a littlefs integration I've received the return value LFS_ERR_NAMETOOLONG for several error scenarios where it doesn't apply. I think the affected line may have been copied by mistake.
E.g., I've received this return value for an invalid block device driver where I've messed up the offsets within the memory and also with bugs in an optimized CRC32 calculation.

Hi @lmapii, thanks for the PR. This definitely shouldn't mask all errors like it is.
The original motivation for that condition was to handle a difficult case where the file name doesn't fit in our metadata blocks. For example a 256 byte file name will never fit in a 128 byte block (which is in theory allowed for littlefs but causes problems like this one).
Looking into this more, maybe we should consider adding a new error (LFS_ERR_2BIG?) to differentiate between running out of storage (LFS_ERR_NOSPC), filename too long (LFS_ERR_NAMETOOLONG), and this errro which occurs due to geometric limitations in littlefs.
At the very least, this shouldn't catch/hide all errors. We should change this to only change the error for LFS_ERR_NOSPC.

The original motivation for that condition was to handle a difficult case where the file name doesn't fit in our metadata blocks. For example a 256 byte file name will never fit in a 128 byte block (which is in theory allowed for littlefs but causes problems like this one).

To be honest I'm not too familiar with the details of littlefs since simply thus far it worked so well that I didn't have to :). My question is this:

Would this case you're describing be a configuration error, meaning the block size supported by the configuration and the block device driver do simply not match the file name configuration,
Or can this happen during runtime, e.g., when there's not enough space to create this last metadata block?

In both cases LFS_ERR_NOSPC would be my favourite, I'd also not think that adding a new error code would be necessary since in any case one would end up debugging their case.
Adding a comment to describe either scenario would be very helpful.

Would this case you're describing be a configuration error, meaning the block size supported by the configuration and the block device driver do simply not match the file name configuration,
Or can this happen during runtime, e.g., when there's not enough space to create this last metadata block?

I think the problem is that LFS_ERR_NOSPC can mean both of these...
In the first case LFS_ERR_NOSPC means the block_size is too small to fit all of the metadata (file names and custom attributes make this not determinable at compile time).
In the second case LFS_ERR_NOSPC means the there are no more blocks available. This can happen on any lfs_dir_commit, since wear-leveling may need to move the directory to a new block.
(The reason LFS_ERR_NAMETOOLONG isn't returned by lfs_dir_commit is because internally lfs_dir_commit is committing various types of "attributes" such as file names, file sizes, pointers, etc.)
In hindsight we probably should have used a different error, perhaps LFS_ERR_2BIG (-7), since these are fundamentally different types of errors. But this would be a bigger change and probably API breaking...

In both cases LFS_ERR_NOSPC would be my favourite, I'd also not think that adding a new error code would be necessary since in any case one would end up debugging their case.

I may be biased as a maintainer, but the number of issues I've seen so far about mostly empty filesystems returning LFS_ERR_NOSPC suggest it's not a good error code outside of strictly "no more blocks left". Perhaps because this is its purpose on most other filesystems :)

Ok I see how there are other use-cases which might affect more users. I've updated the PR to only convert the LFS_ERR_NOSPC error to LFS_ERR_NAMETOOLONG as you suggested, I hope that fits your need. Notice that your proposed change of if (err == LFS_ERR_NOSPC) should not have worked since we would not have left the function in case of an error anymore (?).

Thanks for the PR!


RDDRONE-UAVCAN / UCANS32K146 boards cleanup & update

Summary

Removes RDDRONE-UAVCAN144 board (this board design was abandoned before it became an actual product).
Renames RDDRONE-UAVCAN146 board to UCANS32K146 (name under which the board is actually available).
Cleanup/update similar to #4541.
Adds a configuration that enables the CAN buses and CAN utilities.

Impact

RDDRONE-UAVCAN144 removal should not impact anybody. This board was only produced in very small numbers and made available to some early adopters and is probably not used anymore.
RDDRONE-UAVCAN146 users should now use the UCANS32K146 config, which has the exact same features. In practice most users will probably be using the board with PX4 anyway, which has its own configuration outside NuttX.

Testing

Builds just fine locally with both :nsh and :can configs.
Boots just fine on my own UCANS32K146 boards.
Verified by @PetervdPerk-NXP as well.

Looks like there is a warning being caused by the SLCAN application. This PR gets rid of the warning: https://github.com/apache/incubator-nuttx-apps/pull/855. If that gets merged and checks are run on this PR again it should pass.


x/GAMM: Create a function to refund all LP shares for a pool

We should create a function in x/gamm that takes in a pool ID, and then dissolves that pool, and refunds the LP shares back into the constituent assets, and distributes to all holders. This would eventually become something callable in upgrades or governance, to dissolve pools with less than $X liquidity. (See https://gov.osmosis.zone/proposal/discussion/2047-proposal-raise-the-pool-creation-fee-and-refund-pools-with-less-than-1000-tvl/ for discussion from Osmosis community on why this is quite desirable!)
This would be done by iterating over all accounts looking for folks who hold that pools LP shares. If you hold that pools shares, then it burns those shares, and then gives you the constituent tokens back.
It then destroys the pool.
If there are any LP shares IBC'd out of Osmosis, I think those should for now just be 'stuck', as a v1 of this feature. We can make a way to redeem them back subsequently.

Will be closed by #652


In Ruby 3.1 I am getting a gem error

You have already activated "set 1.0.3", but your Gemfile requires set 1.0.2.

set is a default gem at 1.0.2 but as character_set depends on sorted_set ~> 1.0, installing it can update to 1.0.3, and then it causes these issues. Even if you manually add gem 'set', '= 1.0.2' ; gem 'sorted_set', '= 1.0.2' it still manages to load 1.0.3 in some cases until you manually uninstall it.
Maybe lock to 1.0.2?

hi @mikebaldry and thanks for the report!
the set dependencies have caused various nuisances over time so i've now included their code (which is actually only used as fallback on some exotic Rubies and for testing) directly in the gem.
i've just released v1.7.0 which no longer depends on sorted_set.
btw, out of curiosity, are you using character_set directly or via client_side_validations/js_regex?

Great, thanks. I'm using it via js_regex


Deprecated warning ".translation"

Hi,
I got this message in my log.

ngenic: the '.translations' directory has been moved, the new name is 'translations', starting with Home Assistant 0.111 your translations will no longer load if you do not move/rename this

Better be prepared than sorry 😉

Made a copy of the .translations folder, and keeping the old folder to be backwards compatible.


Metagenomics Data Literature Search

Primary: Urnisha | Backup: Steph

Link to Metagenomic Literature Search Document

The literature search for the month of September is completed and I will reach out to the authors of promising papers after my break.


Fix TFLint output to turn the build green

build
../modules/bind-server/main.tf
	NOTICE:63 "iam_instance_profile" is not specified. If you want to change it, you need to recreate the instance. (aws_instance_not_specified_iam_profile)
../modules/dnsmasq-server/main.tf
	NOTICE:62 "iam_instance_profile" is not specified. If you want to change it, you need to recreate the instance. (aws_instance_not_specified_iam_profile)
../modules/vpn-gateway/main.tf
	NOTICE:29 "iam_instance_profile" is not specified. If you want to change it, you need to recreate the instance. (aws_instance_not_specified_iam_profile)
main.tf
	WARNING:348 Module source "../modules/init-snippet-gitlab-docker" is not pinned (terraform_module_pinned_source)

Result: 4 issues  (0 errors , 1 warnings , 3 notices)

This is a duplicate of #107, closing in favor of the original


Dynamic bitset blocks size should not be configurable and be a single byte

Currently, it's possible to choose any size for the blocks in the Dynamic bitset's template argument, but in the apache arrow documentation: https://arrow.apache.org/docs/dev/format/Columnar.html#validity-bitmaps
But using a block size greater than a byte will lead to endianess issues

dynamic_bitest itself is a generic type, it's not designed to be specific to arrow. It's usage in the library, for example there, here the block size is 8bit, which matches the spec, isnt it? It can't be changed by the user AFAIK.

In that case, it requires modifications to works on big endian architectures. I don't know if we really want to add complexity for cases we don't use.


Update to use latest npm CLI release

The new version has provenance support built in.
https://github.com/npm/cli/pull/6163

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

:art: If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
:fast_forward: If this is a PR that includes changes to an interaction, please include a video recording in the description.
:warning: If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.


Add OceanFacts to Math & Science

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not have more than 100 characters
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Thanks for your contribution @willuhm-js 😄
Can you resolve this review, please?

Done


Upgrade version.mockito 5.1.0 -> 5.1.1

This PR contains the following updates:

Package
Type
Update
Change

org.mockito:mockito-errorprone

patch
5.1.0 -> 5.1.1

org.mockito:mockito-bom
import
patch
5.1.0 -> 5.1.1

Release Notes

mockito/mockito
v5.1.1
Compare Source
Changelog generated by Shipkit Changelog Gradle Plugin
5.1.1

2023-01-30 - 1 commit(s) by Andriy Redko
StackWalker.Option not found on Mockito 5.1.0 (#2891)
StackWalker.Option not found on Mockito 5.1.0 (#2890)

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Mockito 5.1.0 -> 5.1.1

See:
- https://github.com/mockito/mockito/releases/tag/v5.1.1
- https://github.com/mockito/mockito/compare/v5.1.0...v5.1.1


License

Hi there,
Just wanted to confirm that the license for this project is MIT? There is no mention on the README file but it say "license": "MIT" in your composer file.
Thanks,
James

Yes the license is MIT.
You will find a licence badge on the top of the readme file also.

Ah sorry I missed that, was looking for the License section at the bottom of the file. Thanks for getting back to me :)


build: update alpine to 3.18 and include arm64 image builds for goreleaser

Merged https://github.com/yannh/kubeconform/pull/204 which should solve the arm64 need - I do need to upgrade the base image still :)


Dependencies updated to the latest versions

Dependencies updated to the latest versions in the package.json

thanks for the PR, could you also re-generate package-lock.json?


Add url encoding functions

I was trying to use curl from just:
upload credentials file:
   curl '-u{{credentials}}' -T {{quote(file)}} 'https://example.com/foo/bar/{{file_name(file)}}'

and this worked fine until the filename had a # character - which broke the above because i was not URL-encoding it.  I think just could use a url encoding function to handle such cases

Seems reasonable to me! Maybe url_encode(STRING). This would make a great first PR for anyone who wants to take a crack at it.

agree, url encoding has a number of different usecases, so it might be useful to provide more than one function.   For my usecase, encodeURIComponent is enough. I do not know how common are other usecases - I haven't encountered them (yet)

Yup, thanks for noticing!


Odd characters in Windows Linux Subsystem

It's most visible in images but also visible in the tweet info. The likes and retweets icons are not properly drawn. I imagine this is more an issue with WLS terminal emulation mode. The coloration is also a little off because of this.
This issue aside, it seems very stable in WLS.

Thanks for report.
It might be problem with Unicode display on WLS terminal and currently i can not do anything with it.  You can try another terminal for better display :smile:


Added demo game "Eat the Apple"

Hello @macoene! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file hooman/demos/eat_the_apple_game.py:

Line 21:80: E501 line too long (87 > 79 characters)
Line 45:1: W293 blank line contains whitespace
Line 52:80: E501 line too long (155 > 79 characters)
Line 56:80: E501 line too long (151 > 79 characters)
Line 57:80: E501 line too long (95 > 79 characters)
Line 63:14: W292 no newline at end of file


python312Packages.pytile: 2023.12.0 -> 2024.12.0

Diff: https://github.com/bachya/pytile/compare/refs/tags/2023.12.0...2024.12.0
Changelog: https://github.com/bachya/pytile/releases/tag/2024.12.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368770

x86_64-linux

:white_check_mark: 5 packages built:

home-assistant-component-tests.tile
python312Packages.pytile
python312Packages.pytile.dist
python313Packages.pytile
python313Packages.pytile.dist


Implement Transcirption dataclass

The Transcription dataclass needs to be implemented. Possible attributes:

text: the transcription text
length: length of Transcription string
time_stamps: time stamps of words
sections: names of sections of transcription
...

Isse reopened. I am working on a solution on subranch feature/transcriber-arveds-version.

Implementation finished


Get the actual height after apply the attributed text.

Thanks for sharing the library which is very useful to provide attribute text.
It would be possible to get the height of whole text after apply the attributed text.
As I had implemented an application where I have to show the description with mix of images and font styles in the list. And I have used the UITableView for listing those description, so if I can get the actual height after apply the attributed text then I can simply get the value and apply on the UITableView heightForRowAtIndexPath delegate.

Hi, @ram2386, and thanks for your question! There are two common ways to achieve what you're looking for:

Use self-sizing table view cells. This uses Auto Layout to measure your cells after they're configured, so you don't have to calculate the height yourself. It was introduced in iOS 8, it works quite well in iOS 9, and in iOS 10 they made some nice improvements which you can learn about in the WWDC session from this year on UICollectionView, which covers topics that also apply to UITableView. This is the method I recommend.
You can also measure an attributed string yourself using -[NSAttributedString boundingRectWithSize:options:]. You can read more about it on this StackOverflow thread.

I would definitely go with option 1 if you can, because it's a lot less code to write.
Will one of these options work for you? Please let me know if you can think of a way that BonMot can make this task easier. Good luck!


Issue - CI jobs cannot handle Proton branches containing '/' in their name

Here's what it looks like. There is still the problem that it looks for 0.37.0 tag in the astitcher/qpid-proton, but the / issue is now fixed.
https://github.com/jiridanek/skupper-router/actions/runs/2590978453/attempts/1

Codecov Report

Merging #585 (b47dc37) into main (3358a8f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
- Coverage   25.04%   25.04%   -0.01%
==========================================
  Files         117      117
  Lines       28919    28922       +3
  Branches     4684     4685       +1
==========================================
- Hits         7244     7243       -1
- Misses      20706    20709       +3
- Partials      969      970       +1

Flag
Coverage Δ

unittests
25.04% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/router_core/address_watch.c
73.86% <0.00%> (-1.14%)
:arrow_down:

src/adaptors/http2/http2_adaptor.c
2.07% <0.00%> (-0.01%)
:arrow_down:

src/adaptors/tcp_adaptor.c
2.27% <0.00%> (+<0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3358a8f...b47dc37. Read the comment docs.


nanopolish_makerange.py

I have used 1D minion data, called on albacore v2
Followed the github read.me example, editting for file names
nanopolish index -d /path/to/raw_fast5s/ albacore_output.fastq
bwa index draft.fa
bwa mem -x ont2d -t 8 draft.fa reads.fa > reads.sam
samtools view -bS reads.sam > reads.bam
samtools sort reads.bam reads_sorted.bam
samtools index reads_sorted.bam
Then following this I try the nanopolish steps:
~/nanopolish$ python scripts/nanopolish_makerange.py draft.fa | parallel --results nanopolish.results -P 8  ./nanopolish variants --consensus polished.{1}.fa -w {1} -r albacore_outpout.fa -b reads_sorted.bam -g draft.fa -t 4 --min-candidate-frequency 0.1
and get the following error:
parallel: invalid option -- '-'
parallel [OPTIONS] command -- arguments
for each argument, run command with argument, in parallel
parallel [OPTIONS] -- commands
run specified commands in parallel
Traceback (most recent call last):
File "scripts/nanopolish_makerange.py", line 32, in
print("%s:%d-%d" % (name, start, end + OVERLAP_LENGTH))
IOError: [Errno 32] Broken pipe
I editted the above to contain 'parallel gnu' incase it was a problem with the naming and another package and receive this:
/nanopolish$ python scripts/nanopolish_makerange.py draft.fa | parallel gnu --results nanopolish.results -P 8  ./nanopolish variants --consensus polished.{1}.fa -w {1} -r albacore_outpout.fa -b reads_sorted.bam -g draft.fa -t 4 --min-candidate-frequency 0.1
Traceback (most recent call last):
File "./scripts/nanopolish_makerange.py", line 32, in
print("%s:%d-%d" % (name, start, end + OVERLAP_LENGTH))
IOError: [Errno 32] Broken pipe
Why is there an issue with this step?
The head of my sam file, converted to bam is such:
~/nanopolish$ head reads.sam
@SQ	SN:tig00000003	LN:468395
@SQ	SN:tig00000004	LN:1050679
@SQ	SN:tig00000006	LN:135090
@SQ	SN:tig00000007	LN:339130
@SQ	SN:tig00000010	LN:832368
@SQ	SN:tig00000011	LN:66627
@SQ	SN:tig00000012	LN:150659
@SQ	SN:tig00000013	LN:808737
@SQ	SN:tig00000016	LN:654433
@SQ	SN:tig00000021	LN:589863
Thanks in advance

What version of parallel are you using?
On Wed, Sep 27, 2017 at 8:08 AM, PhDstuff<EMAIL_ADDRESS>wrote:

I have used 1D minion data, called on albacore v2
Followed the github read.me example, editting for file names
nanopolish index -d /path/to/raw_fast5s/ albacore_output.fastq
bwa index draft.fa
bwa mem -x ont2d -t 8 draft.fa reads.fa > reads.sam
samtools view -bS reads.sam > reads.bam
samtools sort reads.bam reads_sorted.bam
samtools index reads_sorted.bam
Then following this I try the nanopolish steps:
~/nanopolish$ python scripts/nanopolish_makerange.py draft.fa | parallel
--results nanopolish.results -P 8 ./nanopolish variants --consensus
polished.{1}.fa -w {1} -r albacore_outpout.fa -b reads_sorted.bam -g
draft.fa -t 4 --min-candidate-frequency 0.1
and get the following error:
parallel: invalid option -- '-'
parallel [OPTIONS] command -- arguments
for each argument, run command with argument, in parallel
parallel [OPTIONS] -- commands
run specified commands in parallel
Traceback (most recent call last):
File "scripts/nanopolish_makerange.py", line 32, in
print("%s:%d-%d" % (name, start, end + OVERLAP_LENGTH))
IOError: [Errno 32] Broken pipe
I editted the above to contain 'parallel gnu' incase it was a problem with
the naming and another package and receive this:
/nanopolish$ python scripts/nanopolish_makerange.py draft.fa | parallel
gnu --results nanopolish.results -P 8 ./nanopolish variants --consensus
polished.{1}.fa -w {1} -r albacore_outpout.fa -b reads_sorted.bam -g
draft.fa -t 4 --min-candidate-frequency 0.1
Traceback (most recent call last):
File "./scripts/nanopolish_makerange.py", line 32, in
print("%s:%d-%d" % (name, start, end + OVERLAP_LENGTH))
IOError: [Errno 32] Broken pipe
Why is there an issue with this step?
The head of my sam file, converted to bam is such:
~/nanopolish$ head reads.sam
@sq https://github.com/sq SN:tig00000003 LN:468395
@sq https://github.com/sq SN:tig00000004 LN:1050679
@sq https://github.com/sq SN:tig00000006 LN:135090
@sq https://github.com/sq SN:tig00000007 LN:339130
@sq https://github.com/sq SN:tig00000010 LN:832368
@sq https://github.com/sq SN:tig00000011 LN:66627
@sq https://github.com/sq SN:tig00000012 LN:150659
@sq https://github.com/sq SN:tig00000013 LN:808737
@sq https://github.com/sq SN:tig00000016 LN:654433
@sq https://github.com/sq SN:tig00000021 LN:589863
Thanks in advance
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jts/nanopolish/issues/234, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXxn0cBGwiPj7vT2cFVwrnSDNiR-s06ks5smjqsgaJpZM4PlqSa
.

I appear to have fixed it by reinstalling and moving the parallel command,
sudo apt-get install parallel
sudo mv /usr/bin/parallel /usr/bin/gnu_parallel
sudo apt-get install moreutils
And then using gnu_parallel in my scripts
Following this, I now receive this error message:
nanopolish: src/nanopolish_read_db.cpp:179: std::__cxx11::string ReadDB::get_read_sequence(const string&) const: Assertion m_fai != NULL' failed. ##fileformat=VCFv4.2 ##INFO=<ID=TotalReads,Number=1,Type=Integer,Description="The number of event-space reads used to call the variant"> ##INFO=<ID=SupportFraction,Number=1,Type=Float,Description="The fraction of event-space reads that support the variant"> ##INFO=<ID=BaseCalledReadsWithVariant,Number=1,Type=Integer,Description="The number of base-space reads that support the variant"> ##INFO=<ID=BaseCalledFraction,Number=1,Type=Float,Description="The fraction of base-space reads that support the variant"> ##INFO=<ID=AlleleCount,Number=1,Type=Integer,Description="The inferred number of copies of the allele"> ##FORMAT=<ID=GT,Number=1,Type=String,Description="Genotype"> #CHROM	POS	ID	REF	ALT	QUAL	FILTER	INFO	FORMAT	sample [fai_load] build FASTA index. [fai_build] fail to open the FASTA file albacore_output.fa.fa.gz [fai_load] fail to open FASTA index. nanopolish: src/nanopolish_read_db.cpp:179: std::__cxx11::string ReadDB::get_read_sequence(const string&) const: Assertion m_fai != NULL' failed.
So it is unable to open a file that doesn't exist 'albacore_output.fa.fa.gz'. considering I indexed a fastq file as suggested in the first step?

the -r option should be -r albacore_output.fastq, not -r albacore_output.fa.

That seems to have fixed, I will report if the process is completed successfully


DSDL libcanard-compatible C source files or headers

gnss_Fix.c
function uavcan_equipment_gnss_Fix_encode_internal
source->ned_velocity No conversion using canardConvertNativeFloatToFloat16 causes data parsing error

@aasmune may I ask you to verify this, please?

After I made changes to the code, the data was parsed normally. The following is the modification:
	**tmp_float = canardConvertNativeFloatToFloat16(source->ned_velocity[c]);**         canardEncodeScalar(msg_buf, offset, 16, (void*)&tmp_float); // 32767         offset += 16;


using eslint-loader or pre/post loaders.

How to use eslint-loader in webpack.mix.js file
I have added extra webpackConfig in the file. but this doesn't work.
.webpackConfig({
            plugins: [
                new webpack.LoaderOptionsPlugin({
                    options: {
                        eslint: {
                            configFile: path.join(__dirname, '.eslintrc'),
                        },
                    },
                })
            ],
            module: {
                rules: [{
                    test: /\.js$/,
                    exclude: /node_modules/,
                    inlclude: [path.join(__dirname, './client')],
                    enforce: 'pre',
                    use: [{
                        loader: 'eslint-loader'
                    }],
                }, ],
            },
  })

I see a typo, "inlclude", but not sure if that's related.
Are you requiring webpack into your webpack.mix.js file? If you need to configure your Webpack config file significantly like this, it's best to copy our webpack.config.js file to your project root, and then work off of that directly.

@JeffreyWay atm you can not just copy the config file as its just loader for WebPack builder and it has lines like:
require('../src/index');
let WebpackConfig = require('../src/builder/WebpackConfig');

Which will fail once this file is moved to project root directory.
How to add custom webpack plugins officaly ?

Some problem here. I investigated and found out that the generated configuration object has in test key the value of {} when passing a regular expression on our "webpack.mix.js". Maybe that's the only issue that's causing that, I'll try look more deeply later.
Got the generated code by placing require('fs').writeFile('generated_webpack.js', JSON.stringify(new WebpackConfig().build(), null, 2), 'utf-8') on "node_modules/laravel-mix/setup/webpack.config.js"


Code error in onPlayerDisconnect.sqf after headless client disconnects.

onPlayerDisconnect.sqf - line 70
if ((owner _unit) in hcArray) then
if statement is not true in case of a headless client disconnecting.
As far as I can tell owner _unit, in this case, is the server and there therefore not in hcArray.
My understanding is you can not get the playerID of a client after he disconnected. hcArray holds the playerID of all headless clients.
I made a fix by myself but I'm not familiar with SQF and there is probably a better way. Trying to avoid breaking something else, I introduced a hc2Array and used that instead of the hcArray.
Code can be found here:
https://github.com/A3Antistasi/A3-Antistasi/compare/master...enxyo:enxyo-patch-1

To be honest, totally untested but AFAIK the EH which executes the script fires before doing anything else from the server side, so it should work. Have you tested? I cannot do it on my PC because I still dont know how to make the server not kicking my HC (BattleEye thing)
If not, there is a cheapest way, as the EH provides the owner in _this select 4. See here: https://community.bistudio.com/wiki/Arma_3:_Event_Handlers/addMissionEventHandler#PlayerDisconnected

To be honest, totally untested but AFAIK the EH which executes the script fires before doing anything else from the server side, so it should work. Have you tested? I cannot do it on my PC because I still dont know how to make the server not kicking my HC (BattleEye thing)

-write a line how you starting HC, and are steam is starting or not?

I do it in the most simple way: from steam launcher I launch my client, a dedi and a headless. Dedi works ok, but the HC gets kicked.

problem is in steam account - the dedi start with same steam acc as the HC
you dont need start steam at all when you starting dedi and HC

start dedi and HC wuthout steam- and after you may start steam and start client

try copy this in the bat file and put bat in arma 3 folder then start
start /min arma3server_x64.exe -client -connect=<IP_ADDRESS> -port=2502 -nosound -profiles="C:\A3DS3\profiles\HC1" -hugepages -maxMem=12288 -enableHT -mod=""
arma3server_x64.exe -port=2502 -nosound -profiles="C:\A3DS3\profiles" -name=Server -config=Antistasi.cfg -hugepages -maxMem=12288 -mod=""

paths "C:\A3DS3\profiles\HC1" and "C:\A3DS3\profiles" - you select youself

thanks!

or find and set this in dedi config
kickDuplicate        = 0;

solved with _owner = _this select 4. Thanks anyway!


Add speakeasy-cli package

Description of changes
Source: https://github.com/speakeasy-api/speakeasy
Homepage: https://www.speakeasyapi.dev
Note that although this is a Golang command, building from source seems to fail because of private dependencies.
This installs the binary speakeasy that is used to generate and configure SDKs using the speakeasy api service.
Things done

Built on platform(s)

[] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Also, hash should be used instead of sha256.

Thanks, @arthsmn, for all the comments and pointers, this was a learning experience for me!
Unfortunately, I'm not in a position to be able to maintain or keep with the software up to date for this PR, I'll defer this to the folks that own the actual project to decide if they want to expand into the nixpkgs world.
For now, I'm closing this PR 😢


moved mdutils to analysis requirements

Problem
the install failed because it needed mdutils
Solution
mdutils is only used in the analysis code so I moved the requirement there
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.63%. Comparing base (e8c834e) to head (9b808a1).
Report is 16 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   98.63%   98.63%
=======================================
  Files          18       18
  Lines         511      511
=======================================
  Hits          504      504
  Misses          7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add GHA builds and tests

Most of the files were copied verbatim from the workspace_deluxe repo.
Closes #350

Not sure why codecov isn't updating, it's been hinky lately

It's got the report... https://app.codecov.io/github/kbase/auth2/commit/641f04e2f30e980f871b058c04b1c9061fab5282


+1<PHONE_NUMBER>

https://github.com/bigpinkdicknetwork/nulk/issues/19

https://github.com/bigpinkdicknetwork/nulk/issues/19


Document APISnoop Vocabulary

Request:
Document usage of terms such as "groups", "verbs", "kinds", "endpoints".
Short description:
There are a number of terms which may or may not match the larger K8s community. Terms should be researched, documented, and possibly changed to match the common definition.

Current state:

Terms are used but not defined.

Desired state:

Terms are explicitly defined and documented

Tasks:

[ ] Research usage of terms in greater k8s community
[ ] Document definitions
[ ] Make adjustments to usage as seen necessary

Some terms which we should look into how we are currently using:
Groups vs Category
Verbs vs Methods
Endpoints vs Kind

/meow

@hh:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

also: level versus version?

We don't need to change the names used within APISnoop, but we might be able to document where they come from better.

This was a useful team exercise, we know have internalized the shared vocabulary of the k8s community.


O(log N) calculations fixed

Ah right, these should be calculated as log2. I used wolfram alpha with just log


Nuxt or Vue compiler errors

Nuxt and Vue compiler make error,
ERROR in ./node_modules/textify.js/src/components/Animation.js 1:0-89
Module not found: Error: can't resolve 'prefix' in "D:\travel-app\src\animations\text.js......

this error make lot of problem in my app. fix it please..

letest version of vue and nuxt are in used.

we are working on it!!!

same error come with next.js !!!

we are fixing very soon all error or bug .

Nuxt and Vue compiler make error,
ERROR in ./node_modules/textify.js/src/components/Animation.js 1:0-89
Module not found: Error: can't resolve 'prefix' in "D:\travel-app\src\animations\text.js......

this error make lot of problem in my app. fix it please..

download prefix in dependency and restart next js or nuxt server with deleting server_caches

Nuxt and Vue compiler make error,
ERROR in ./node_modules/textify.js/src/components/Animation.js 1:0-89
Module not found: Error: can't resolve 'prefix' in "D:\travel-app\src\animations\text.js......

this error make lot of problem in my app. fix it please..

download prefix in dependency and restart next js or nuxt server with deleting server_caches

error was fixed.. :100:


[Part 5] Increase Microsoft.Bot.Schema.Teams code coverage

Fixes #5647

Description
Part 3 of 8.
Write unit tests to bring Microsoft.Bot.Schema.Teams to 100% code coverage 🎊🥳🎉

Original Microsoft.Bot.Schema.Teams Coverage: 6.23%

Coverage Raised to with this Chunk: 18.58%

Pull Request Test Coverage Report for Build 250813

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.03%) to 78.857%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder/DelegatingTurnContext.cs
1
88.24%

/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Recognizers/EntityRecognizers/TextEntityRecognizer.cs
1
85.71%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/DatetimePrompt.cs
1
77.5%

/libraries/Microsoft.Bot.Builder/Adapters/TestFlow.cs
2
78.32%

/libraries/Microsoft.Bot.Builder.Dialogs/Memory/DialogStateManager.cs
4
78.76%

Totals

Change from base Build 250626:
-0.03%

Covered Lines:
18156

Relevant Lines:
23024

💛  - Coveralls


Fix loss typo

The comment mentions binary cross-entropy loss whereas the loss being used is categorical cross entropy

Thanks!

@googlebot I signed it!


add TB culture HSI

This branch has the HTM scale-up scenarios plus the new culture diagnostic test for tb which is used for people with a false test (xpert, sputum, xray or clinical) but all the symptoms indicative of tb. It is only called if program scale-up is 'target' or 'max'

Thanks Tara -- running now.
For the review, maybe we should allow this to happen only under 'max', since we think it's quite hypothetical?

Thanks Tara -- running now.
For the review, maybe we should allow this to happen only under 'max', since we think it's quite hypothetical?

Sure. I think it will depend on what we want to present, are you thinking that we only present the max scenario? The targeted scenario will likely show a very muted effect.

Thanks @tdm32 --- do we want to roll-back the analysis scripts on here, so that it's just the changes to the TB module....?

Thanks @tdm32 --- do we want to roll-back the analysis scripts on here, so that it's just the changes to the TB module....? Or, are you using this for your production runs for your current GF and FCDO analyses?

@tbhallett I've rolled back those files which do exist on master. Additional analysis scripts on this branch - which are not present in master - don't need to be pushed. Should we delete them or can we just merge those relevant files?
Required for merge to master:
resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES.xlsx
src/tlo/methods/tb.py

Are we keeping this or closing it off? @tdm32

@tdm on this one:

there are lots of script file from the FCDO/GF analysis bundled in here, that I presume we don't want to come in on this PR. I believe the only changes needed are in tb.py. If so, please roll back the others\

I see that with the last merge in of master, there were failing tests -- so after that fix, we'll need to wait for the test to pass.

@tdm32  --- I've removed the files that I think didn't want to be on this PR. The .xlsx for Priority Polices look the same to me? Are you sure we need to update?

@tdm32 --- I've removed the files that I think didn't want to be on this PR. The .xlsx for Priority Polices look the same to me? Are you sure we need to update?

@tbhallett there should be the additional HSI for TB culture in the priority policies sheets


Angular module

I'm writing angularjs module for this - https://github.com/Kroid/angular-nlp-compromise, if someone need.

gorgeous!  thanks for doing this George!
i've added a link to your project and demo to the readme.
let me know if I can help at all
cheers!


Fix invalid escape sequences

Coverage remained the same at 99.792% when pulling 225ce89413ab226a45f7f4d111da55bf4d1bd20c on asottile:invalid_escape_sequences into ca1e3f0b2e601a8551007613f72546c685dc9d98 on pytest-dev:master.


Created Zeroed Pulse shapes

What is the expected enhancement?
Currently, several pulses are implicitly zeroing the ends of the pulses to removed initial and final discontinuities for pulses that are settable with the flag zero_ends which is True. Naively reading the pulse name this would be unexpected behavior. This flag should be removed and the functionality should be split into two different pulses,eg.,  ZeroedGaussian and Gaussian. Similarily parametric pulse implementations should be made for these pulses.

[ ] Split pulses with zero_ends attributes into two pulse classes
[ ] Create parametric pulses for all split pulses

I was just working on the docs for discrete.py and came across this issue (@lcapelluto pointed me to the literal github issue). Let me know if this discussion has been taken further outside of these comments @eembees and @taalexander (and perhaps my comments are obsolete).
I think that whatever the functionality is, it should be consistent. Currently, e.g.:

the drag function is inconsistent, in that if you call it with zero_ends == True, it returns samples from the function g(x) + 1j * beta * h(x), where g(x) is the zeroed gaussian, but h(x) is the derivative of the non-zeroed gaussian
So, the current drag function is not actually returning something satisfying the drag conditions. One response to this is that these things are equivalent up to a scaling which is absorbable into beta, but I think the current behaviour is "unpredictable" from a user perspective

So, I would suggest:

Wherever the discussion on having proper 'zeroing' for the derivatives goes, there should at least be a function that returns the derivative of the zeroed guassian; i.e. the "derivative of (zeroed gaussian)" as opposed to the "zeroed (derivative of gaussian)".

To this end:

The _fix_gaussian_width function maps each function output value y to:
amp*(y - zero_offset)/(amp-zero_offset)  (i.e. it is not just a constant offset)
So, having a "derivative of (zeroed gaussian)" function requires scaling the derivative portion of the output of gauss_deriv by amp/(amp-zero_offset)

It may be a bit awkward but if "zeroing" functionality is to be provided, for full user control there needs to be multiple levels of "zeroing" options:

drag with no zeroing
drag with zeroing of the gaussian but not the derivative (but with consistent derivative as per the above suggestion), and
drag with both the gaussian and its derivative zeroed (consistently, so drag condition is preserved by whatever transformations are performed)

@DanPuzzuoli

the drag function is inconsistent, in that if you call it with zero_ends == True, it returns samples from the function g(x) + 1j * beta * h(x), where g(x) is the zeroed gaussian, but h(x) is the derivative of the non-zeroed gaussia

The derivative of the zeroed gaussian is the same as the nonzeroed gaussian since it is a constant offset. The amplitude is also being rescaled for the gaussian derivative component properly see https://github.com/Qiskit/qiskit-terra/blob/0e2102057ad0d56eea50de132d69030c603df20a/qiskit/pulse/pulse_lib/continuous.py#L135 and https://github.com/Qiskit/qiskit-terra/blob/0e2102057ad0d56eea50de132d69030c603df20a/qiskit/pulse/pulse_lib/continuous.py#L343.

drag with no zeroing
drag with zeroing of the gaussian but not the derivative (but with consistent derivative as per the above suggestion),
drag with both the gaussian and its derivative zeroed (consistently, so drag condition is preserved by whatever transformations are performed, as already discussed above)

I understand why 1. and 3. are needed, but I don't understand the use case of 2.

@taalexander
Yes sorry my bad, I thought I had been very careful before posting the comment, but you are totally correct.
What I meant by the 1, 2, 3 cases has 2 as what is currently being done when zero_ends == True: it is enforced that the output gaussian starts and ends at 0, but the derivative can have non-zero starting/ending points.
Case 3 corresponds to what we just discussed in person; it would correspond to a pulse shape that starts and ends at 0 that also has derivative starting/ending at 0. (To recap/record our discussion: it isn't possible to do this using the set of functions parameterized in Equation 5 of the drag paper. So, if one wants to enforce that the function and its first derivative start/end at 0, it is necessary to consider a broader class of functions [e.g. a linear combo of gaussians with different widths].)

Another option would be to add the parameter B which would be the offset of a gaussian, this could be 0 by default and then set by the drag pulse function to appropriately zero the pulse if desired.

Another option would be to add the parameter B which would be the offset of a gaussian, this could be 0 by default and then set by the drag pulse function to appropriately zero the pulse if desired.

And then add a flag on whether that should propagate onto the derivative?  Or do you still think we should add a separate set of classes for DRAG pulses? I'm a bit confused on exactly what direction this should go ATM.

It might look something like
Gaussian(duration, amp, b, sigma)

gaussian(duration, amp, b, sigma, zero_ends=True) -> Gaussian(duration, adjust(amp), adjust(b), sigma)
gaussian(duration, amp, b, sigma, zero_ends=False) -> Gaussian(duration, amp, 0, sigma)

I'm not really certain currently. Perhaps we should close this and reopen at a later date when it is no longer a hypothetical problem?

I was looking through "good first issues" to work on and found this one. But it seems this new feature request is already addressed by #4640 as mentioned in #4317

Yes, I believe so @HuangJunye. Thank you for catching.


Node tests: test failures on tests-collection.js tests 100-109 only when running full test suite

This does not manifest itself when running tests-collection.js tests by themselves. What’s different?
To reproduce:
npm run test:node

Failures:
not ok 100 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 101 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 102 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 103 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 104 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 105 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 106 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 107 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 108 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12
not ok 109 - error:SyntaxError: Unexpected token  in JSON at position 25
#     at JSON.parse (<anonymous>)
#     at Typeson.s.parse (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:776:2369)
#     at Object.decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:6617:20)
#     at IDBCursorWithValue.IDBCursor.__decode (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1789:35)
#     at Object.cursorContinue [as op] (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1845:20)
#     at executeNextRequest (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5237:23)
#     at success (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:5173:13)
#     at /Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1767:13
#     at triggerSuccess (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1839:36)
#     at checkKey (/Users/aral/indie/other/forks/IndexedDBShim/dist/indexeddbshim-node.js:1849:29), expected: true, got: false, test: or-issue#15-test, module: collection, source: at /Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:2194:12

This is a test runner timeout related issue with test or-issue#15-test.
The errors that we’re seeing occur when the QUnit test timeout is hit. I had this at 3000ms. Raising the per-test timeout to 5000ms has all tests passing in tests-collection.js.

OK, no, that’s not it. This is a random error.
I just raised the per test timeout to 10 seconds and the main test runner timeout to 30 seconds and I can reproduce the “Unexpected token in JSON at position 25" error, above, on some runs but not others.
This looks like a hairy one.

It may literally a random one: or-issue#15-test populates the DB with random strings generated like this:
    db.on('populate', function () {
        ok(true, "on(populate) called");
        for (var i = 0; i < 100; ++i) {
            db.phones.add({ id: 3 + i, name: "Name" + randomString(16), additionalFeatures: [randomString(10)], android: 1, availability: 0, battery: 1, camera: 1 });
        }

        function randomString(count) {
            var ms = [];
            for (var i = 0; i < count; ++i) {
                ms.push(String.fromCharCode(32 + Math.floor(Math.random() * 96)));
            }
            return ms.join('');
        }
    });

Maybe the IndexedDBShim without the unicode support, bails out after this has happened.

But the chars are in ascii 32-96 so shouldn't be issue actually. I might be wrong here.

Oh, it is chars [32..127] and it could be char 127 (DEL) that makes the shim unhappy. Trying now to change from 96 to 95 to avoid that special char. Then the strings will only contain basic ascii chars.

Closing this particular issue as the randomness was solved after avoiding char 127 in the set of random strings generated in or-issue#15-test.

@dfahlander Hmm, afaik, IndexedDBShim should handle Unicode correctly (and if it doesn’t, that’s a bug). I’m not sure if “fixing” the test here actually hides the core issue. @brettz9: thoughts?

Yes, it should handle any string correctly, even unpaired surrogates. If there is a problem, I suspect the underlying SQLite might not like some control character or other, in which case, we probably just need to add to one or more of our escaping functions in utilities.

Think it is closed from the dexie point of view. This could be opened in IndexedDBShim. A narrowed down repro would probably do:
store.put({id: 1, str: String.fromCharCode(127)})

Yeah, but I didn't find a single problem on my end running through all code units or code points, at least not with a single number supplied to String.fromCharCode (0 - 0xFFFF) or String.fromCodePoint (0 - 0x10FFFF)...
Running Node 9.2.1... Test at https://github.com/brettz9/IndexedDBShim/blob/code-unit-code-point-tests/tests-mocha/IDBObjectStore/put-spec-chars.js

I see. Maybe the property need be indexed to trigger the issue. If not there must be something else. Don't know if we're using the unicode version of the shim or not in our tests.

Looks like from the error messages above, the file is indexeddbshim-node.js which would not be including the Unicode support. It should be using indexeddbshim-UnicodeIdentifiers-node.js...

@brettz9 Ah, my bad. I’ll fix that, thank you @brettz9. @dfahlander will you revert the test (or shall I?) It’s good to have the Unicode characters in there (or to create a new test specifically for that – happy to do it) so that we cover that use case. Dexie should be Unicode compliant by default.

Let's see if that was the issue. I thought the unicode module regards to index- and table names only. This was an issue with the data. The particular test that I modified was not testing unicode support, but we could easily add a new unicode test.

(Re: Unicode support: Yeah, I was confused for the same reasons when I read the IndexedDBShim docs.)


asp-area

Provide an example using asp-area

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 90dc429b-11d9-c0f6-678d-dfb22e23c273
Version Independent ID: 61eb6984-18c3-2bb1-db35-62735a0b24a4
Content: Anchor Tag Helper in ASP.NET Core
Content Source: aspnetcore/mvc/views/tag-helpers/built-in/anchor-tag-helper.md
Product: aspnet-core
GitHub Login: @pkellner
Microsoft Alias: scaddie

@BrettBock I'm trying to better understand what you're looking for here. Did you already look at the doc's sample app's Views/Home/Index.cshtml file?

Looking for an anchor example that can be used to reference a razor page that is in an area.  I was able to just use an href, e.g. "/area/controller/action", but was not able to get this working with any of the asp anchor tags.  asp-page indicates that it is mutually exclusive to several tags, but asp-area is not include.


[UBS Admin History]The event "Замовлення Частково оплачено" doesn`t appeared if customer ordered additional package(s) after paying for the current order.

Environment: Windows 10 pro 64 bit Opera 89.0.4447.51
Reproducible: always
Build found: 27.07.2022
Preconditions
Preconditions:

User is logged in as administrator https://www.testgreencity.ga/GreenCityClient/#
There is at least one order created in the system and the order paid.
Сustomer ordered additional package(s) after paying for the current order by phone or email
Administrator has opened an order from current orders view table

Steps to reproduce

Pay attention on the order work log "Історія замовлення". Verify that the order status is "Оплачено"
In section "Деталі замовлення" in field "Підтверджена к-ть" add more items.
Klick "Зберегти" button
Pay attention on the order work log "Історія замовлення".'

Actual result
The event "Замовлення Частково оплачено" doesn`t appeared if customer ordered additional package(s) after paying for the current order.
Expected result
If the customer ordered additional package(s) after paying for the current order, then the event "Замовлення Частково оплачено" appeared in the order work log "Історія замовлення"
User story and test case links
E.g.: "User story #GC-2263
GC-3341
Labels to be added
"Bug", Priority ("pri: high"), Severity ("severity:"), Type ("Functional")
https://user-images.githubusercontent.com/102593506/181264492-36c3b634-c02b-4677-b8ce-8c5c8e2a714c.mp4


[GOBBLIN-956] Continue loading dags until queue is drained

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-956

Description

[x] Here are some details about my PR, including screenshots (if applicable):

If many dags are added at once (such as on gaas startup), each DagManagerThread will still only load one each run (10 seconds). Added a while loop to continue loading dags until the queue is drained instead.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Tested locally

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2805 into master will decrease coverage by 0.95%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #2805      +/-   ##
============================================
- Coverage     45.47%   44.52%   -0.96%
+ Complexity     8905     8736     -169
============================================
  Files          1899     1899
  Lines         71068    71070       +2
  Branches       7825     7826       +1
============================================
- Hits          32320    31643     -677
- Misses        35764    36487     +723
+ Partials       2984     2940      -44

Impacted Files
Coverage Δ
Complexity Δ

...blin/service/modules/orchestration/DagManager.java
78.91% <50%> (-0.16%)
12 <0> (ø)

...re/filesystem/FsDatasetStateStoreEntryManager.java
0% <0%> (-100%)
0% <0%> (-3%)

...askStateCollectorServiceHiveRegHandlerFactory.java
0% <0%> (-100%)
0% <0%> (-2%)

...gobblin/runtime/mapreduce/GobblinOutputFormat.java
0% <0%> (-100%)
0% <0%> (-2%)

...in/runtime/mapreduce/CustomizedProgresserBase.java
0% <0%> (-83.34%)
0% <0%> (-1%)

...rg/apache/gobblin/runtime/ZkDatasetStateStore.java
0% <0%> (-80.77%)
0% <0%> (-7%)

...lin/runtime/locks/LegacyJobLockFactoryManager.java
0% <0%> (-78.58%)
0% <0%> (-2%)

.../apache/gobblin/metastore/ZkStateStoreFactory.java
0% <0%> (-71.43%)
0% <0%> (-2%)

...he/gobblin/runtime/ZkDatasetStateStoreFactory.java
0% <0%> (-71.43%)
0% <0%> (-2%)

...apache/gobblin/runtime/MysqlDatasetStateStore.java
0% <0%> (-70%)
0% <0%> (-7%)

... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1efb9...b5b99e6. Read the comment docs.


'Up Next' video content

This seems to have dropped off the site when the 360 video player was made.

This still seems to work OK for me. e.g. on this page.
This was only ever implemented for videos in the Channel section as far as I recall.

This is strange—this feature hasn't been functioning for a few months since we did some work with Brightcove for the 360 player.
I can confirm it's working once more on Channel though. However, if we look at the end of the Ming Wong video, it's linking to non-video material:

The middle link above is a blog post in this instance.

Ah, good spot. Seems it was picking up the manually set related content, should only return other channel episodes now.

Thanks, @rdunk — checked it. Looks like it's working as expected.


twitch-tui: 2.4.1 -> 2.5.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Xithrius/twitch-tui/releases.
meta.description for twitch-tui is: Twitch chat in the terminal
meta.homepage for twitch-tui is: https://github.com/Xithrius/twitch-tui
meta.changelog for twitch-tui is: https://github.com/Xithrius/twitch-tui/releases/tag/v2.5.1
Updates performed

Rust version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.5.1 with grep in /nix/store/s8bp4lq93b2yvxxsjmd7w0bgahx9f5jr-twitch-tui-2.5.1
found 2.5.1 in filename of file in /nix/store/s8bp4lq93b2yvxxsjmd7w0bgahx9f5jr-twitch-tui-2.5.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
twitch-tui

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s8bp4lq93b2yvxxsjmd7w0bgahx9f5jr-twitch-tui-2.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A twitch-tui https://github.com/r-ryantm/nixpkgs/archive/9c4a92c0a70d90d658ef27e2dcbab4ca72f1a86c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s8bp4lq93b2yvxxsjmd7w0bgahx9f5jr-twitch-tui-2.5.1
ls -la /nix/store/s8bp4lq93b2yvxxsjmd7w0bgahx9f5jr-twitch-tui-2.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

twitch-tui

Maintainer pings
cc @tgharib for testing.


uploading to s3 using type file to public bucket not setting public

Version information

Laravel: v5.8
Voyager: v1.3
PHP: 7.2
Database: MySQL Ver 14.14 Distrib 5.7.29, for Linux (x86_64)

Description

I have set up an s3 bucket with public permissions. I am building a podcast management site so each episode needs a file upload for the mp3 file. I don't want to use the media picker type because there needs to be only one file associated with each record and there will be way too many files to "pick" from using the media picker. With BREAD settings for input type = file, uploading the mp3 is successful because I'm using the IAM credentials, but the file is not being saved with public access. I perused the voyager code and noticed that all image upload commands have the 'public' option set...

But I see in ControllersCommand.php that the command is $this->filesystem->put($path, $content);
Here are lines 80-96
foreach ($files as $file) {
    $parts = explode(DIRECTORY_SEPARATOR, $file);
    $filename = end($parts);

    if ($filename == 'Controller.php') {
        continue;
    }

    $path = app_path($location.DIRECTORY_SEPARATOR.$filename);

    if (!$this->filesystem->exists($path) or $this->option('force')) {
        $class = substr($filename, 0, strpos($filename, '.'));
        $content = $this->generateContent($stub, $class);
        dd($content);
        $this->filesystem->put($path, $content);
    }
}

Steps To Reproduce
Steps to reproduce the behavior:

Create s3 bucket with public permissions
Set BREAD field to 'file'
Select an MP3 file and submit the form (SAVE button)
Upload is successful but file is uploaded without public access.

Expected behavior
Need an option to upload a file type to s3 with public access.
Additional context
I am using Laravel Forge for server.

Ok, I was ignorant of all the options for setting up the filesystem config file for s3. All I had to do was add 'visibility' => 'public' to the array. D'oh!
's3' => [
    'driver' => 's3',
    'key' => env('AWS_ACCESS_KEY_ID'),
    'secret' => env('AWS_SECRET_ACCESS_KEY'),
    'region' => env('AWS_DEFAULT_REGION'),
    'bucket' => env('AWS_BUCKET'),
    'url' => env('AWS_URL'),
    'root' => env('AWS_SUB_FOLDER'),
    'visibility' => 'public',
]

However, it would be good to be able to set the public option for each field. I can see where having file permissions might vary in the same project.


Enhancement: Add Gatling's Silencing Ability for Calling Feature Files

Would be nice to have this without having to use scala and Gatling's http request handler.
https://gatling.io/docs/current/http/http_request/?highlight=silent#silencing

Would be nice to have this without having to use scala and Gatling's http request handler.
https://gatling.io/docs/current/http/http_request/?highlight=silent#silencing

moving this to project roadmap board: https://github.com/intuit/karate/projects/3#card-22529251


Lost all variables after rendered the algorithm.

Hi there,
I'm happy to find out this repo that exactly what I'm looking for.
However, when I tried to add your code to my page by copying/pasting your file .html and .md in the /docs folder.
I'm facing this issue: The output algorithm immediately loses all variables, i.e., i in a loop, like the below page.
https://dohaison.github.io/InfoSysID/#/algorithms/ZF

And this is my algorithm code in latex:
\begin{algorithm}
\caption{Test algorithmic package}
\begin{algorithmic}
\State $i \gets 10$
\If{$i\geq 5$}
    \State $i \gets i-1$
\Else
    \If{$i\leq 3$}
        \State $i \gets i+2$
    \EndIf
\EndIf
\end{algorithmic}
\end{algorithm}

Please help me debug this issue, this is the source code of my Docsify page:
https://github.com/DoHaiSon/InfoSysID
Thank you so much!

I found that the hided variables can appear by disabling this css as shown in this picture. However, the form of output algorithm is still mis-format.
    /* clip: rect(1px, 1px, 1px, 1px);

I found that I have to add katex to index.html, I'm not sure why only mathjax does not work, but it worked.


Generate JSON config file

Details TBC pending further conversations with back-end team

This has already been implemented as a javascript config file within folder '/profiles' in the public folder of the application.
Terraform provisioner has already been extended for supporting this feature in Open Targets Platform and Partner Preview deployments.
@andrewhercules , are we going to use this approach for Genetics Portal as well?

That's great - thank you @mbdebian! 👍
Yes, we will take the same approach with the Genetics Portal — I'll add to the genetics-app refactor epic https://github.com/opentargets/genetics/issues/511

I'll close this issue then, thanks @andrewhercules !!!


Support XML schema list

Description
Currently a xs:list parses to its base type
Repro steps

Unzip  FSharp.Data.Xsd_issue.zip

See the error in the .fsx on od and Some id

Expected behavior
The constructor accepts float list for od and Some float list for id.
Actual behavior
The constructor accepts float for od and Some float for id.
Known workarounds
No idea.
Related information

Operating system: Windows 10 Home; Version 1607; Build 14393.1480
Branch: NuGet package v1.0.0
.NET Runtime, CoreCLR or Mono Version: .NET framework 4.5.2, F# runtime 4.0

Interesting catch. I'll have a closer look in a few days. I hope we can improve on the current behavior but I'm afraid the optimal behavior is not easy to achieve.

In the meantime a workaround may be to ignore the provided properties corresponding to list types and for those elements directly use the XElement property.

I have fallen back on manual use of XAttribute / XElement / XDocument for the time being; now works so it is not urgent.

commit cf7d0e2e8d987a8765bb15620668ba5a78020ce3 should mitigate the issue. For simple types of the list or union variety we simply fallback to string properties. This adds very little to the aforementioned workaround of directly using the underlying XElement, but at least we avoid the misleading behavior of providing for example a property of type float instead of float list.
Doing the right thing and providing a float list is not impossible but I think it is out of scope for this project, which is just a thin wrapper around the XML type provider of F# Data.


Question about sequential B part code performance

I ran the sequential_PartB code provided on github, why it is much slower than the baseline performance?

I have the same problems! My performance is close to yours

Just try to avoid nested for loop, which often leads to bad parallelism. For example, we assume that the filter size is always 3, and why do we need two for loops (for -1 to 1) to handle the computation? Can we do it directly as 9 lines of codes so that the memory access is more efficient?

Just try to avoid nested for loop, which often leads to bad parallelism. For example, we assume that the filter size is always 3, and why do we need two for loops (for -1 to 1) to handle the computation? Can we do it directly as 9 lines of codes so that the memory access is more efficient?

I see. Thank you!


AttributeError: module 'wrapt' has no attribute 'decorator'

    I am seeing the following issue when loading the intergration using Home Assistant 2022.12.8 in docker

2022-12-27 16:20:57.703 ERROR (MainThread) [homeassistant.loader] Unexpected exception importing component custom_components.alexa_media
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/loader.py", line 709, in get_component
cache[self.domain] = importlib.import_module(self.pkg_path)
File "/usr/local/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/config/custom_components/alexa_media/init.py", line 49, in
from .config_flow import in_progess_instances
File "/config/custom_components/alexa_media/config_flow.py", line 64, in
from .helpers import calculate_uuid
File "/config/custom_components/alexa_media/helpers.py", line 143, in
@wrapt.decorator
AttributeError: module 'wrapt' has no attribute 'decorator'
2022-12-27 16:20:57.708 ERROR (MainThread) [homeassistant.setup] Setup failed for custom integration alexa_media: Unable to import component: Exception importing custom_components.alexa_media
Originally posted by @jeremyj84 in https://github.com/custom-components/alexa_media_player/issues/1808#issuecomment-1366257485
Results of pipdeptree -r -p wrapt
wrapt==1.14.1

aiobotocore==2.1.0 [requires: wrapt>=1.10.10]
Deprecated==1.2.13 [requires: wrapt>=1.10,<2]

jwcrypto==1.4.2 [requires: deprecated]

python-jwt==4.0.0 [requires: jwcrypto>=1.4.2]

Pyrebase4==4.6.0 [requires: python-jwt>=2.0.1]

thermoworks-smoke==0.1.8 [requires: pyrebase4>=4.3.0]

melnor-bluetooth==0.0.20 [requires: Deprecated>=1.2.13]
openevsewifi==1.1.2 [requires: Deprecated>=1.2.10,<2.0.0]

There's something wrong with your wrapt installation. The error is literally referring to the basic use case of wrapt. https://github.com/GrahamDumpleton/wrapt/blob/1.14.1/README.rst#quick-start
You can try testing in your dev container. If you don't see something like this identifying the decorator function, then it confirms somethings really wrong with your wrapt.
vscode ➜ /workspaces/home-assistant $ python3
Python 3.9.16 (main, Dec  8 2022, 01:43:07)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import wrapt
>>> wrapt.decorator
<function decorator at 0xffffa7d9f4c0>

Thank you for the hint, I went into the container and forcefully reinstalled wrapt and now it works as intended. I am not entirely sure how it ended up in the broken state.


Produce::getInstance() ignores arguments

After first initialization arguments for Produce::getInstance() are silently ignored. This way you cannot use more than one kafka cluster. Is there a reason for this?
$ProducerOne = new Producer($someHosts, $timeout);
$ProducerTwo = new Producer($otherHosts, $timeout);

This way it is more flexible, users would cache Producer instance if they want to.

It's much better when running long-term CLI programmes.

Yeah, can consider to cancel creating singleton restrictions.

public function __construct()

instead of

private function __construct()

but if only one kafka cluster using the default Produce::getInstance()  get Instance recommendation

Done!

Z-AN, Zan!


Autocomplete value

Hi,
I am using autocomplete component:
<md-input-container class="full-width">
    <input type="text" [(ngModel)]="selectedValue" [formControl]="autoComplete" mdInput [mdAutocomplete]="auto">
</md-input-container>

<md-autocomplete #auto="mdAutocomplete">
    <md-option  *ngFor="let option of filteredControls | async" [value]="option.id">
    {{option.label}}
    </md-option>
</md-autocomplete>

When i select an option the input text shows an id whici i set at the value attribute. Is it a specification ? If yes is it possible to get the text instead of the value attribute ?
Thanks

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are Stack Overflow, gitter, mailing list, etc.


Added originAt support to Image

Added originAt support to Image (Issue #122)
Method works correctly and can take Vec, Point, x and y coordinates and polar coordinates just like the originAt in Picture.
Example with x, y coordinates:
val atAndOriginAt =
      Image
        .circle(100)
        .at(25, 25)
        .debug
        .beside(Image.circle(100).originAt(25, 25).debug)

Output:

I've also updated the docs.

👍