NTR: medication timepoint

NTR: medication timepoint
Definition: a time measurement datum that specifies the point in time that a human participant under investigation self-administers a medication material
Parent: time measurement datum

I might be wrong, but I think you are not really looking at a time measurement datum here (definition: A scalar measurement datum that is the result of measuring a temporal interval.) What you seem to be looking for seems to be more the identifier of a specific time point (think Star Trek star dates). These aren't measurements. The are names we stick on specific periods of time (notable the name of one time slice can be different in the Central time zone and in the Eastern time zone). Just food for thought.

A number of OBI folks are leaning towards adding (see https://github.com/obi-ontology/obi/issues/981)
instantaneous time value specification
    'has specified value' some (xsd:dateTime or xsd:dateTimeStamp)"

So then above defn. could be:
an instantaneous time value specification that specifies the point in time that a human participant under investigation self-administers a medication material

Thank you both for your suggestions. I agree the term is an identifier/specifier of a time point rather than a measurement. @ddooley , that definition works for me (even if we just call it a value spec w/o the phrase "instantaneous time").

About whether it is a measurement or not - consider that all such recorded times (not predictions or simulations though) are achieved by noting the digits provided by an analog or digital clock device. Whatever it spits out is a measurement, regardless of the underlying scheme the numbers present, in the same way as measuring "20g" mass. Experimentally one may later discover an error occurred with the clock apparatus just like any other device. It suffers the vagaries of measurement.

I should add that I think the primary semantic defn. for "medication timepoint" should be a value specification as above.  Its just that one can then additionally layer on whether it is a measurement, recommendation, estimate etc. if needed.

Discussed on the OBI call 2019-06-17.
This should go in the value-specification.tsv.
I think that this term is fine, but there are still decisions to make about #981.

This is a term for a record of something that is already completed, as in the medication has already been administered.
Action item: @johnwjudkins to create PR


Exposing line renderer positions

Overview
The calculated line renderer points are not able to access from out side.
Changes

Fixes: # .
-calculated points now can be accessed from outside (private setter)

/azp run

/azp run

Thanks for this addition!


Organize interview feedback forms table results by color

@mrealm

What?

The table we use for Second Actives from the interview follow-up forms has green, yellow, and red I think depending on how their interviewers graded them. Benson wants that organized by color for easier use at Second Actives.

So like make the following groups?:
-All green
-At least one yellow but no red
-At least one red
Michael Hand
Electrical Engineering: Systems Ph.D. Candidate
The University of Michigan
<EMAIL_ADDRESS>On Sat, Jan 3, 2015 at 8:34 PM, domansyl<EMAIL_ADDRESS>wrote:

The table we use for Second Actives from the interview follow-up forms has
green, yellow, and red I think depending on how their interviewers graded
them. Benson wants that organized by color for easier use at Second
Actives.
—
Reply to this email directly or view it on GitHub
https://github.com/tbpmig/mig-website/issues/159#issuecomment-68617049.

yea that way they're organized and in order for second actives, thanks!


Add HashVectorGrouper based on MemoryOpenHashTable.

This causes vectorized hash-based groupBys to use MemoryOpenHashTable
instead of ByteBufferHashTable (see #9308).
Additional supporting changes:

Modifies VectorGrouper interface to use Memory instead of ByteBuffers.
Modifies BufferArrayGrouper to match the new VectorGrouper interface.
Removes "implements VectorGrouper" from BufferHashGrouper.

Benchmarks:
master @ a085685182d62e5dd1b716f1bbb9bcbbaeb1c661

Benchmark              (query)  (rowsPerSegment)  (vectorize)  Mode  Cnt    Score   Error  Units
SqlBenchmark.querySql       10           5000000        force  avgt   25  683.263 ± 8.382  ms/op
SqlBenchmark.querySql       11           5000000        force  avgt   25  691.823 ± 7.979  ms/op
SqlBenchmark.querySql       12           5000000        force  avgt   25   34.977 ± 0.842  ms/op
SqlBenchmark.querySql       13           5000000        force  avgt   25   42.408 ± 0.984  ms/op
SqlBenchmark.querySql       14           5000000        force  avgt   25   98.015 ± 0.887  ms/op
SqlBenchmark.querySql       15           5000000        force  avgt   25  449.379 ± 6.541  ms/op
SqlBenchmark.querySql       16           5000000        force  avgt   25  519.083 ± 5.115  ms/op
SqlBenchmark.querySql       17           5000000        force  avgt   25  456.992 ± 4.015  ms/op
SqlBenchmark.querySql       18           5000000        force  avgt   25  534.258 ± 8.832  ms/op

groupby-hvg @ 9fdc4bcf8e6dd6896a5fe687145e5ea0f1c6a709

Benchmark              (query)  (rowsPerSegment)  (vectorize)  Mode  Cnt    Score   Error  Units
SqlBenchmark.querySql       10           5000000        force  avgt   25  450.345 ± 6.428  ms/op
SqlBenchmark.querySql       11           5000000        force  avgt   25  473.163 ± 4.918  ms/op
SqlBenchmark.querySql       12           5000000        force  avgt   25   32.281 ± 0.566  ms/op
SqlBenchmark.querySql       13           5000000        force  avgt   25   39.259 ± 1.300  ms/op
SqlBenchmark.querySql       14           5000000        force  avgt   25   91.553 ± 0.892  ms/op
SqlBenchmark.querySql       15           5000000        force  avgt   25   85.417 ± 0.670  ms/op
SqlBenchmark.querySql       16           5000000        force  avgt   25  158.197 ± 1.458  ms/op
SqlBenchmark.querySql       17           5000000        force  avgt   25  103.445 ± 0.872  ms/op
SqlBenchmark.querySql       18           5000000        force  avgt   25  175.661 ± 1.859  ms/op

The largest improvements are on queries 10 and 11 (~50%) and queries 15–18 (3–5x). Queries 12–14 look very slightly faster or maybe unchanged.
Queries 10 & 11 are groupBys on two strings and would use hash-based grouping.
Queries 12–14 are groupBys on one string and would use array-based grouping. It makes sense that they haven't changed much, since they wouldn't use hash-based grouping. The changes to the array-based grouping code were more minimal.
Queries 15–18 are groupBys on one long column and would use hash-based grouping.

Please check the LGTM warning.

I just looked at it. It's complaining that keySpace.getInt(i * Integer.BYTES) accepts a long and in theory i * Integer.BYTES could overflow. It's not very plausible: it would only happen if the vector size was crazy huge. I added a check to the start of the method that will detect this and block it. I'm not sure if LGTM will be smart enough to understand it, but it means the issue isn't real.


Membership Restricted Video Issue

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
Hello!
This is my first time ever trying to use yt-dlp so bear with me. I have been struggling to download videos on this youtube playlist all night. I'm not sure what I am doing wrong. If you can help me with instructions on what exactly I should write in Terminal I would really appreciate it!
Provide verbose output that clearly demonstrates the problem

[x] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[x] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below
[ ] If using API, add 'verbose': True to YoutubeDL params instead

Complete Verbose Output
users-MBP:~ user$ yt-dlp -f "bv*[height<=1080][ext=mp4]+ba[ext=m4a]/b[height<=1080][ext=mp4] / bv*+ba/b" https://youtube.com/playlist?list=PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn&si=MDK-IAm0QYYzdomL
[1] 98493
users-MBP:~ user$ [youtube:tab] Extracting URL: https://youtube.com/playlist?list=PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn: Downloading webpage
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn: Redownloading playlist API JSON with unavailable videos
[download] Downloading playlist: Dimension 20: Dungeons and Drag Queens (Full Episodes)
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn page 1: Downloading API JSON
WARNING: [youtube:tab] Incomplete data received. Retrying (1/3)...
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn page 1: Downloading API JSON
WARNING: [youtube:tab] Incomplete data received. Retrying (2/3)...
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn page 1: Downloading API JSON
WARNING: [youtube:tab] Incomplete data received. Retrying (3/3)...
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn page 1: Downloading API JSON
WARNING: [youtube:tab] Incomplete data received. Giving up after 3 retries
[youtube:tab] Playlist Dimension 20: Dungeons and Drag Queens (Full Episodes): Downloading 5 items of 5
[download] Downloading item 1 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=w664JpkrDio
[youtube] w664JpkrDio: Downloading webpage
[youtube] w664JpkrDio: Downloading ios player API JSON
[youtube] w664JpkrDio: Downloading android player API JSON
ERROR: [youtube] w664JpkrDio: Join this channel to get access to members-only content like this video, and other exclusive perks.
[download] Downloading item 2 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=1gq-iJ8eerY
[youtube] 1gq-iJ8eerY: Downloading webpage
[youtube] 1gq-iJ8eerY: Downloading ios player API JSON
[youtube] 1gq-iJ8eerY: Downloading android player API JSON
WARNING: [youtube] YouTube said: ERROR - Precondition check failed.
WARNING: [youtube] HTTP Error 400: Bad Request. Retrying (1/3)...
[youtube] 1gq-iJ8eerY: Downloading android player API JSON
WARNING: [youtube] YouTube said: ERROR - Precondition check failed.
WARNING: [youtube] HTTP Error 400: Bad Request. Retrying (2/3)...
[youtube] 1gq-iJ8eerY: Downloading android player API JSON
ERROR: [youtube] 1gq-iJ8eerY: Join this channel to get access to members-only content like this video, and other exclusive perks.
[download] Downloading item 3 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=37vlzMCTfdg
[youtube] 37vlzMCTfdg: Downloading webpage
[youtube] 37vlzMCTfdg: Downloading ios player API JSON
[youtube] 37vlzMCTfdg: Downloading android player API JSON
ERROR: [youtube] 37vlzMCTfdg: Join this channel to get access to members-only content like this video, and other exclusive perks.
[download] Downloading item 4 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=OrAxFXlvKqc
[youtube] OrAxFXlvKqc: Downloading webpage
[youtube] OrAxFXlvKqc: Downloading ios player API JSON
[youtube] OrAxFXlvKqc: Downloading android player API JSON
ERROR: [youtube] OrAxFXlvKqc: Join this channel to get access to members-only content like this video, and other exclusive perks.
[download] Downloading item 5 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=RT6XwcsQ3Tc
[youtube] RT6XwcsQ3Tc: Downloading webpage
[youtube] RT6XwcsQ3Tc: Downloading ios player API JSON
[youtube] RT6XwcsQ3Tc: Downloading android player API JSON
ERROR: [youtube] RT6XwcsQ3Tc: Join this channel to get access to members-only content like this video, and other exclusive perks.

when sharing a log in an issue, add -vU to your command to get verbose output, which helps us diagnose what is wrong and how to fix it

always quote the URL

update to nightly: yt-dlp --update-to nightly if you are using the exe/zip, or python3 -m pip install -U --pre yt-dlp if you installed with pip

most importantly: pass cookies to yt-dlp

see this issue about problems with youtube cookies and workarounds:

https://github.com/yt-dlp/yt-dlp/issues/8227#issuecomment-1867184804

Hi @bashonly thanks for replying. I tried to do export my cookies from youtube and got a text file. I'm not sure what to do beyond that. Sorry about not writing it correctly. I'm new at this and I don't really know what I'm doing. Please let me know what other steps I need to take to download this playlist.
yt-dlp -vU yt-dlp -f "bv*[height<=1080][ext=mp4]+ba[ext=m4a]/b[height<=1080][ext=mp4] / bv*+ba/b" https://youtube.com/playlist?list=PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn&si=MDK-IAm0QYYzdomL

All 5 steps are necessary. Read the links in #4 and #5. You've added -vU to your command but you have not shared the log, and it doesn't look like you've followed any of the other steps

Apologies again! Is this correct?
yt-dlp -vU yt-dlp -f "bv*[height<=1080][ext=mp4]+ba[ext=m4a]/b[height<=1080][ext=mp4] / bv*+ba/b" https://youtube.com/playlist?list=PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn&si=MDK-IAm0QYYzdomL
[1] 1880
Sarahs-MacBook-Pro:~ sarahraines$ [debug] Command-line config: ['-vU', 'yt-dlp', '-f', 'bv*[height<=1080][ext=mp4]+ba[ext=m4a]/b[height<=1080][ext=mp4] / bv*+ba/b', 'https://youtube.com/playlist?list=PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [f10589e34]
[debug] Python 3.12.2 (CPython x86_64 64bit) - macOS-13.6.4-x86_64-i386-64bit (OpenSSL 3.2.1 30 Jan 2024)
[debug] exe versions: ffmpeg 4.4.4 (setts), ffprobe 4.4.4
[debug] Optional libraries: pycrypto-3.19.0, sqlite3-3.45.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[CommonMistakes] Extracting URL: yt-dlp
ERROR: [CommonMistakes] You've asked yt-dlp to download the URL "yt-dlp". That doesn't make any sense. Simply remove the parameter in your command or configuration.
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 718, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/commonmistakes.py", line 25, in _real_extract
raise ExtractorError(msg, expected=True)
[youtube:tab] Extracting URL: https://youtube.com/playlist?list=PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn: Downloading webpage
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn: Redownloading playlist API JSON with unavailable videos
[download] Downloading playlist: Dimension 20: Dungeons and Drag Queens (Full Episodes)
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn page 1: Downloading API JSON
WARNING: [youtube:tab] Incomplete data received. Retrying (1/3)...
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn page 1: Downloading API JSON
WARNING: [youtube:tab] Incomplete data received. Retrying (2/3)...
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn page 1: Downloading API JSON
WARNING: [youtube:tab] Incomplete data received. Retrying (3/3)...
[youtube:tab] PLuKg-WhduhknUrmt6iHEjL0AoZ42tylCn page 1: Downloading API JSON
WARNING: [youtube:tab] Incomplete data received. Giving up after 3 retries
[youtube:tab] Playlist Dimension 20: Dungeons and Drag Queens (Full Episodes): Downloading 5 items of 5
[download] Downloading item 1 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=w664JpkrDio
[youtube] w664JpkrDio: Downloading webpage
[youtube] w664JpkrDio: Downloading ios player API JSON
[youtube] w664JpkrDio: Downloading android player API JSON
ERROR: [youtube] w664JpkrDio: Join this channel to get access to members-only content like this video, and other exclusive perks.
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 718, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/youtube.py", line 4175, in _real_extract
self.raise_no_formats(reason, expected=True)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 1196, in raise_no_formats
raise ExtractorError(msg, expected=expected, video_id=video_id)
[download] Downloading item 2 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=1gq-iJ8eerY
[youtube] 1gq-iJ8eerY: Downloading webpage
[youtube] 1gq-iJ8eerY: Downloading ios player API JSON
[youtube] 1gq-iJ8eerY: Downloading android player API JSON
ERROR: [youtube] 1gq-iJ8eerY: Join this channel to get access to members-only content like this video, and other exclusive perks.
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 718, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/youtube.py", line 4175, in _real_extract
self.raise_no_formats(reason, expected=True)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 1196, in raise_no_formats
raise ExtractorError(msg, expected=expected, video_id=video_id)
[download] Downloading item 3 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=37vlzMCTfdg
[youtube] 37vlzMCTfdg: Downloading webpage
[youtube] 37vlzMCTfdg: Downloading ios player API JSON
[youtube] 37vlzMCTfdg: Downloading android player API JSON
ERROR: [youtube] 37vlzMCTfdg: Join this channel to get access to members-only content like this video, and other exclusive perks.
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 718, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/youtube.py", line 4175, in _real_extract
self.raise_no_formats(reason, expected=True)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 1196, in raise_no_formats
raise ExtractorError(msg, expected=expected, video_id=video_id)
[download] Downloading item 4 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=OrAxFXlvKqc
[youtube] OrAxFXlvKqc: Downloading webpage
[youtube] OrAxFXlvKqc: Downloading ios player API JSON
[youtube] OrAxFXlvKqc: Downloading android player API JSON
ERROR: [youtube] OrAxFXlvKqc: Join this channel to get access to members-only content like this video, and other exclusive perks.
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 718, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/youtube.py", line 4175, in _real_extract
self.raise_no_formats(reason, expected=True)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 1196, in raise_no_formats
raise ExtractorError(msg, expected=expected, video_id=video_id)
[download] Downloading item 5 of 5
[youtube] Extracting URL: https://www.youtube.com/watch?v=RT6XwcsQ3Tc
[youtube] RT6XwcsQ3Tc: Downloading webpage
[youtube] RT6XwcsQ3Tc: Downloading ios player API JSON
[youtube] RT6XwcsQ3Tc: Downloading android player API JSON
ERROR: [youtube] RT6XwcsQ3Tc: Join this channel to get access to members-only content like this video, and other exclusive perks.
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 718, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/youtube.py", line 4175, in _real_extract
self.raise_no_formats(reason, expected=True)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 1196, in raise_no_formats
raise ExtractorError(msg, expected=expected, video_id=video_id)
[download] Finished downloading playlist: Dimension 20: Dungeons and Drag Queens (Full Episodes)

You are not passing cookies though. Please actually read the links I sent above. You need to pass the --cookies-from-browser or --cookies options. And if you pass --cookies with a cookiefile, you need to read the link I sent with step 5

Your youtube account has access to these videos, right? You can watch them in your browser?


feat: expose field to configure run configuration environment

This uses the same workspace.xml serialization format that any of the node run configuration use:
<envs>
  <env name="FOO" value="BAR" />
</envs>

fixes #253

Mh looks like i've accidentally made some intellij reindent changes. Should I revert them?

Wait i noticed something isn't working correctly. I'll have to fix some things.

Turns out i somehow added a env variable when launching intellij with the addon. This causes it to not list the dummy env variable in the user environment variables as it's overwriting the system environments.

So everything worked as expected 😅


feat: filter plans that are expired

Related to #51

Codecov Report

Merging #52 (43211d1) into dev (727994b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #52   +/-   ##
=======================================
  Coverage   95.30%   95.30%
=======================================
  Files           5        5
  Lines         362      362
=======================================
  Hits          345      345
  Misses         17       17


[Stackdriver] Samples for documentation.

This PR is to provide samples for the Stackdriver documentation.

Thanks @remi I have updated the PR!


Suggestion: get rid of context or making it optional

Disclaimer: Don't take the tone of this issue too seriously, it's just a representation of a user's frustration, not necessarily mine 😄 Read this as a story.

Alright! AsyncAPI has a CLI, this is cool. I'm gonna install it and validate my file.
npm install -g @asyncapi/cli

Lovely. Let's now validate my AsyncAPI file:
$ asyncapi validate
No contexts saved yet, run asyncapi --help to know more.

Oh! My fault, I have to provide the file name:
$ asyncapi validate asyncapi.yml
No contexts saved yet, run asyncapi --help to know more.

❗ 😕
context? what the f*ck is a context? what do they mean by context? ok, let me try with asyncapi --help:
(redacted)
       context
                current  show the current set context
                list     show the list of all stored context
                remove  <context-name> remove a context from the store
                use <context-name>  set any context as current
                add <context-name> <filepath> add/update new context

  Examples
        $ asyncapi context add dummy ./asyncapi.yml
        $ asyncapi validate --context=dummy
        $ asyncapi validate --file=./asyncapi.yml

🤦 Ok, now I know I can create contexts, list contexts, remove contexts, and obviously add them. But I still don't know what is a "context".
HOW DO I VALIDATE MY FILE FOR GOD SAKE!? :rage1:
Oh, wait, from the examples I can guess I need to add my file to a "context" and then run asyncapi validate --context=my-context. Let's do that.
Cool! How do I name my context?  Or maybe I can just use "test" for now. I wonder where this information is stored 🤔
Anyway, let's just use "test"
asyncapi context add test ./asyncapi.yml
asyncapi validate

Cool, it works now. Oh wait, there was a shorter way! 🤦 I could just have done:
asyncapi validate --file=./asyncapi.yml

Do you see where I'm going? I agree contexts can be useful for experienced and regular users but for newcomers, having to deal with the burden of contexts for simple things like validating a file is such a huge barrier that shouldn't exist.
My proposal is that we remove contexts completely. I think they may make sense in the future —who knows?— but for now, this is only making things more difficult to reason about. Instead, we can rely on a convention ~over~ and then configuration style. For instance:
asyncapi validate

Would look for files with the name asyncapi.yml, asyncapi.yaml, or asyncapi.json in the current directory. If it's found, it validates the file. If it's not, it fails and shows a message saying it couldn't find an asyncapi file and suggesting how to continue.
Following what we discussed on #1, I think asyncapi verb noun should be respected. The noun may be optional when we can easily default to something. Like this case or the case of asyncapi new which could be the equivalent of asyncapi new file. I'm always in favor of options/flags over arguments but if an option is mandatory, it's not an option.
But Fran, my file is called something else, like spec.yml and I still want to benefit from short commands
Cool, now we introduce contexts. The user is going to enable the "contexts" feature knowing what they're doing and on purpose.
$ asyncapi enable contexts
Awesome! From now on, I'll use the `default` context.

Please add your AsyncAPI file to the context:

asyncapi update context your-asyncapi-file.yml

$ asyncapi update context spec.yml
✅  Your AsyncAPI file (spec.yml) has been added to the `default` context.

Note I keep using the pattern asyncapi verb noun and I'm always trying to go ahead of the user. For instance, I decided there's going to be a default context (eliminating the need to think about a name). Users should be able to customize the name if they prefer, doing asyncapi enable contexts --context=my-context-name. With asyncapi update context your-asyncapi-file.yml, we could even go further and make the file name optional, and if you run asyncapi update context the CLI will prompt you a file name or fail if stdin is not interactive.
Summary
In short, I think we should be making the UX seamless for newcomers and let experienced and avid users to get the most out of the CLI by letting them configure the behavior. Let's assume defaults and conventions whenever possible. Let's make them configurable via options/flags or interactive terminal when possible.

Or at least introduce the concept of a default context, which a simple input document will use.

I really like the idea about enabling contexts, at it removes confusion for the newcomers but also keeps it for the experince users to leverage it if they want it.

Or at least introduce the concept of a default context

Yes, sorry, I had that in the issue title but somehow lost it. Changing it.

Ouch, lots of frustrations here 😅 tell this imaginary user that I recommend 🍵 with a bit of lemon balm 😆
Keep in mind this CLI is in a super early stage of development at 0.3 release and many basic improvements are missing (like good UX messages to the user). Of course long term instead of No contexts saved yet, run asyncapi --help to know more. we should be much more descriptive, explaining what are the possible options if defaults were not met.
Context purpose is to be optional, not default. Except of WebSocket use case, developers work in many cases with more than just one AsyncAPI file. Contexts are to support such work, this is why you want to be able to easily switch between files with their names instead of remembering paths.
Contexts are not optional as they are not completed feature. The --file flag was added in 0.3.

Would look for files with the name asyncapi.yml, asyncapi.yaml, or asyncapi.json in the current directory. If it's found, it validates the file. If it's not, it fails and shows a message saying it couldn't find an asyncapi file and suggesting how to continue.

This is exactly what we discussed with @Souvikns on his initial PR for contexts but did not want to over-complicate the PR, same was about --file flag. This functionality will follow. Plan is -> if --file is not passed, and if --context is not passed, and if there is no default context already set that could be used, we look for asyncapi.yml, asyncapi.yaml, or asyncapi.json in the current directory, otherwise help message with good explanation of possible options.
So, too summarize, we do have UX in mind, but please do not expect all good things at 0.3 version 😉
PS. about verb noun vs noun verb, it is not related to context itself, so I suggest you report a separate issue if you want to discuss further.

btw, I actually checked and asyncapi.yml, asyncapi.yaml, or asyncapi.json in the current directory is already supported in 0.3 version. @Souvikns you are fast 🥳 💪🏼

Referring to the Łukasz's comment, we can treat the AsyncAPI docs as the first-citizens of the our CLI, so passing them not as flags, but as standalone arguments. Idea is described here.

Well, first of all I'd like to apologize if someone has felt offended by the tone of the message. Please don't take this personally as an attack to what's been developed so far 🙏 I thought it'd be funny to add some example of a raging user, that's why the all caps and the :rage1: and 🤦  emojis. I'm very aware this is 0.3.0 (very early stage) and not judging your work, especially @Souvikns and @jotamusik who have been working a lot on this project. I'm sorry if this has offended any of you 🙏

we should be much more descriptive, explaining what are the possible options if defaults were not met

Agree. Just keep in mind that when you have to explain too much, it means something is failing in the UX.

Except of WebSocket use case, developers work in many cases with more than just one AsyncAPI file. Contexts are to support such work, this is why you want to be able to easily switch between files with their names instead of remembering paths.

You'd have to explain this a bit more to me. Why is it different when using Websockets? 🤔

With WebSocket you deal with one backend, one AsyncAPI file. With other architectures, broker-centric for example, you deal with more than just one microservice, so multiple files. Example https://github.com/amadeus4dev/amadeus-async-flight-status where you have 3 services and therefore 3 files. You do not work with these files every day, most likely from time to time, so you add them to context so it is easier to find and go back.
For such case you work like this
$ asyncapi context list
monitor : /Users/me/sources/amadeus-async-flight-status/monitor/asyncapi.yaml
notifier : /Users/me/sources/amadeus-async-flight-status/notifier/asyncapi.yaml
subscriber : /Users/me/sources/amadeus-async-flight-status/subscriber/asyncapi.yaml
$ asyncapi context use notifier
$ asyncapi validate
$ asyncapi list channels
$ asyncapi add channel
$ asyncapi ...

Otherwise you work like
$ asyncapi validate /Users/me/sources/amadeus-async-flight-status/notifier/asyncapi.yaml
$ asyncapi list channels /Users/me/sources/amadeus-async-flight-status/notifier/asyncapi.yaml
$ asyncapi add channel /Users/me/sources/amadeus-async-flight-status/notifier/asyncapi.yaml

or like
$ asyncapi validate --file /Users/me/sources/amadeus-async-flight-status/notifier/asyncapi.yaml
$ asyncapi list channels --file /Users/me/sources/amadeus-async-flight-status/notifier/asyncapi.yaml
$ asyncapi add channel --file /Users/me/sources/amadeus-async-flight-status/notifier/asyncapi.yaml

Does it make sense now?
And anyway, contexts are optional, you do not need them, you have --file or  asyncapi.yml, asyncapi.yaml, or asyncapi.json in the current directory

Oh, I see. Thanks for explaining.

or asyncapi.yml, asyncapi.yaml, or asyncapi.json in the current directory

That's not how it's working. Maybe how it's intended to work?

You do not work with these files every day, most likely from time to time, so you add them to context so it is easier to find and go back.

Just to make a point regarding this. If it's something you only use "form time to time" it seems way too much to create a feature like contexts. It overcomplicates the CLI unnecessarily IMHO. When I'm working with different microservices at the same time, I usually have different terminals open because I anyway need them to start, stop, or reload the microservice. But that's probably just how I work.
It seems the idea is taken from the kubectl CLI. I think it makes sense there because you open a terminal and become an operator for different clusters that are usually defined in the same k8s config file. Therefore, you don't have this option of changing to another directory because the other contexts are defined in the same k8s file. I know, it's not always like this but it's a common option and you have to take it into consideration (and they did it, good for them). Of course, you can always open another terminal and operate each cluster on a terminal but that's not convenient because you'd have to open a terminal exclusively for operating a given cluster. Hence, contexts is a clever feature. However, with AsyncAPI, an asyncapi.yaml file defines only one service and you will anyway need to open another terminal to start/stop the service (if you're working with it, of course).
In short, the more I think about contexts, the more I think the feature is not justified here. Will it make sense in the future? Probably. Or probably not. I'm just seeing this as a very early optimization. Precisely because it's 0.3.0, I think this very edge-case shouldn't be considered yet.

Nonetheless, I see a case where contexts could be useful tho. For those tools that need multiple asyncapi files as the input, it would be super useful. For instance, if we wanted to leverage https://github.com/asyncapi/app-relations-discovery from the CLI, having to pass a bunch of asyncapi files each time is not really convenient. In such case, having something like a context would be super cool but it should allow us to add more than one asyncapi file to the context.
asyncapi create context --name=graph
asyncapi add file ./service/dummy1/asyncapi.yaml
asyncapi add file ./service/dummy2/asyncapi.yaml
asyncapi add file ./service/dummy3/asyncapi.yaml
asyncapi create graph

Contexts feature is there already, optional, I don't see a point of removing it really.

but it should allow us to add more than one asyncapi file to the context

As you can see in my example, you have multiple files in the context because you can add multiple contexts, just one can be the default of course:
$ asyncapi context list
monitor : /Users/me/sources/amadeus-async-flight-status/monitor/asyncapi.yaml
notifier : /Users/me/sources/amadeus-async-flight-status/notifier/asyncapi.yaml
subscriber : /Users/me/sources/amadeus-async-flight-status/subscriber/asyncapi.yaml

Using some kind of name as you showed in your example, or rather a label could be good. Something to consider when we integrate relations discovery, or diff.

That's not how it's working. Maybe how it's intended to work?

It works on my side 😄 but I have some files in my context. You found a bug https://github.com/asyncapi/cli/issues/35

Precisely because it's 0.3.0, I think this very edge-case shouldn't be considered yet.

it took some time discussing the initial CLI setup (https://github.com/asyncapi/cli/issues/1) and there were no objections for context (that I've put there from the very beginning, clearly stating kubectl inspiration). As I showed, in broker-centric arch it is useful and therefore not edge-case really.

When I'm working with different microservices at the same time, I usually have different terminals open because I anyway need them to start, stop, or reload the microservice. But that's probably just how I work.

The current most common practice that I'm aware of is that people prefer mono repo (like in the case of amadeus showcase) and definitely not open and start each service one by one in a separate terminal but use docker-compose to make your life easier, thus single terminal window. I don't believe we should consider such a flow of working as an edge-case

As you can see in my example, you have multiple files in the context because you can add multiple contexts, just one can be the default of course:

🤔 Now I'm more confused then. These are different contexts, right? What I mean is having a single context with multiple asyncapi files. I don't think we're meaning the same.

it took some time discussing the initial CLI setup (#1) and there were no objections for context

To be honest, I always understood contexts as a way to have multiple files as the input for a command. That's why I thought it would be cool.

but use docker-compose to make your life easier, thus single terminal window

This is a good argument for contexts, I agree 👍

PS. about verb noun vs noun verb, it is not related to context itself, so I suggest you report a separate issue if you want to discuss further.

I opened an issue: https://github.com/asyncapi/cli/issues/37

Alright, so I think this issue doesn't make sense anymore as it seems it was already the intention to make it optional and a good and frequent use-case (when using docker-compose) has been argued. Other issues have been created to fix the exposed problems. I'm closing it but feel free to reopen if you think there's still a case.


[DO NOT MERGE - Base branch] [msal-node] scaffolding - tsdx

This PR adds the node build/lint/test environment.
We are choosing the msal-node environment based on typescript's recommendation for node projects here. This is to simplify  environment for msal-node and to leverage the support tsdx has already inbuilt.
We did slight modifications to add test paths as jest does not work out of the box.

Coverage remained the same at 76.011% when pulling 63da95257d95f9f4230bb779214a977d72337ba0 on msal-node-scaffolding into 6e93f24442a37426698fd5cf62f875ce5a2d9b80 on dev.

Rebasing this to a new branch msal-node-base


Binja Plugin License is BSD but Repo License is MIT

See line 9: https://github.com/angr/binsync/blob/master/plugins/binja_binsync/plugin.json

@mahaloz we BSD-2 everything. Why MIT?

@ltfish I did MIT because I liked the generality of it; we can switch to BSD if you recommend it since I have little experience in license choices

Updated to BSD2


just Corecting

corect word that a bit wrong

This is actually not a typo, helloWorld is a variable. It cannot be renamed to Hello World.

:v sorry i just want to get on hacktoberfest
Pada tanggal Sel, 30 Okt 2018 pukul 03.29 Spencer Park <
<EMAIL_ADDRESS>menulis:

This is actually not a typo, helloWorld is a variable. It cannot be
renamed to Hello World.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SpencerPark/IJava/pull/41#issuecomment-434067215, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ApQZyweVqDVht2cZ86jCDWmoe--zT5-oks5up2UtgaJpZM4X9HpC
.

Are you in ?
Pada tanggal Rab, 31 Okt 2018 pukul 05.19 rahmadi cahaya putra <
<EMAIL_ADDRESS>menulis:

:v sorry i just want to get on hacktoberfest
Pada tanggal Sel, 30 Okt 2018 pukul 03.29 Spencer Park <
<EMAIL_ADDRESS>menulis:

This is actually not a typo, helloWorld is a variable. It cannot be
renamed to Hello World.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SpencerPark/IJava/pull/41#issuecomment-434067215,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApQZyweVqDVht2cZ86jCDWmoe--zT5-oks5up2UtgaJpZM4X9HpC
.

Oh haha, no worries. I just signed up. Thanks for the info!


Path rework + Cmp function/method

Pull Request Test Coverage Report for Build 346

398 of 398 (100.0%)  changed or added relevant lines in 16 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 99.632%

Totals

Change from base Build 338:
-0.03%

Covered Lines:
4601

Relevant Lines:
4618

💛  - Coveralls


[fix][bug] FE web exists insecure cookie setting

Proposed changes
Issue Number: close #30180

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

is there same problem in master branch?

is there same problem in master branch?
Yes, master has been fix merged

is there same problem in master branch?
Yes, master has been fix merged

So it's better to have a link to master's fix patch in the pr's description


Adds valgrind support, started to correct some bugs in SITL

So far valgrind has helped find a lot of "branch depends on unitialized value" issues. Mostly in our polling for SITL. There are a ton of other unfixed memory errors,  you can run this using:
make posix_sitl_default jmavsim___valgrind

Cool! See more of this here:
https://github.com/PX4/Firmware/pull/3064

Merging when build checks passed.

Had a formatting issue, rebuilding now.

Rebased sitl_bus_fixes on this. Lets see if it finally works on Mac Os..

No luck on that branch - trying master..

No, dies similarly. Sensor data stops updating after some time.


Add resource id

I propose a pull request in order to display the internal id on the "book" page, the "chapter" page and the "page" page.
For what ? When we use the rest api intensively, it is difficult to know the id of an element by browsing the web interface, this id that we use to request objects by the rest api.
This id will be displayed in the page of each entity in the metadata block.
A configuration option can be added to enable this display by the administrator.
I am not a Laravel specialist, but if it is necessary to add the corresponding tests, I can do it, but it will need help on the scenarios to be tested.
Regards

Thanks for offering this @rouet, but I've never been keen on exposing metadata without there being specific value to the main audience of the platform, especially where the are alternative options like there are here since:

You can get the ID via the content/permalink popup.
You could expose this detail via the visual theme system.
You could expose this detail via custom custom code in the "HTML Head Content" customization setting.

Thanks for offering this @rouet, but I've never been keen on exposing metadata without there being specific value to the main audience of the platform, especially where the are alternative options like there are here since:

You can get the ID via the content/permalink popup.

it's really not an easy fix for our use of BookStack. in addition we can not have the id of a chapter or a book

You could expose this detail via the visual theme system.

we will use this system for our needs

You could expose this detail via custom custom code in the "HTML Head Content" customization setting.

the pull request may be closed


terraform apply [plan] gives an error when used together with publishPlanResults

Bug Description
Hello! :)
I'm using terraform plan -out="terraform.tfplan" in one stage, and then applying said plan using the plan text file (passed as an artifact) in another stage: terraform apply terraform.tfplan. During the plan task I use the publishPlanResults as option.
The plan is valid and shown properly in the Terraform Plan tab. However, I get this error during apply:
Error: Failed to load "terraform.tfplan" as a plan file
Error: zip: not a valid zip file

I researched a bit and found out it seems to be a problem for Terraform to process the plan after it has been used by publishPlanResults. At least it's the theory that has been discussed at the end of this thread: https://github.com/hashicorp/terraform/issues/22396 where they could also reproduce the problem.
To Reproduce
Steps to reproduce the behavior:
1. Setup pipeline as:
stages:
  - stage: Plan
    jobs:
      - job: Plan
        steps:
          - task: TerraformCLI@0
            ...
            inputs:
              command: plan
              publishPlanResults: plan.tfplan
              ...
          - publish:
              artifact: plan
              ...

  - stage: Apply
    ...
    jobs:
      - job: Apply
        ...
        steps:
          - download: ...
          - task: TerraformCLI@0
            inputs:
              command: apply
              commandOptions: '--input=false $(Pipeline.Workspace)/plan/plan.tfplan'

2. Execute pipeline
Let both stages run. The plan is saved accordingly and available in apply stage.

See error

The error appears in the log. It's gone when I remove the publishPlanResults option.
Error: Failed to load "terraform.tfplan" as a plan file
Error: zip: not a valid zip file

Expected behavior
I would like to use both the publishPlanResults option and a saved plan :)
Agent Configuration

VM: ubuntu
Terraform version: 1.1.4

Thank you!

I can confirm this issue.

I have the same issue using gitlab ci !

I can also confirm this issue. Any plan, when it will be fixed?

Hi. I was facing same issue, but I was using publishPlanResults: tfplan
After changing publishPlanResults to something random, it worked. Somewhere in documentation it states you should not use the same file as the output plan. If yuo do this, the output plan gets overwritten with text file, and it is not binary anymore, and hence it fails to apply.
So change publishPlanResults: plan.tfplan to publishPlanResults: plan

Hi, the "publishPlanResults" is meant to be the name of the tab in Azure Devops web page which shows the plan output, not the name of the terraform plan used to store terraform data.  As @ricklahaye says, naming these the same will cause issues.
Not a bug, but we can take a look if the documentation can make this situation clearer.

Thank you! :)

Will be resolved by #339.


Need a way to override sudo execution.

Currently, "sudo: true" is at the root level, which means all the build steps will get executed as sudo. If we need to execute a particular step in between as non-sudo, we don't have option for that.
name: "Install Management Server"
sudo: true
vars:
  openjdk: "java-1.7.0-openjdk"
  edge_install_dir: "/opt"
  profile: "edge-management-server"

hosts:
  - mgmt

tasks:
  - name: Stop iptables
    shell: cmd="service iptables stop"

  - name: Zip
    shell: chdir="files" cmd="zip -r token.zip token"
    local: true
    sudo: false #Expecting something like this

  - name: Copy token folder to /opt
    copy: src=files/token.zip dest=/opt/token.zip

@baskaran-md This issue is fixed. Can you test and close?


nixos/znapzend: Run znapzendzetup import in parallel

Patch by @Baughn, who noticed these imports being very slow when run
serially with many datasets, so much that the service would time out and
fail, this fixes it.
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Tested this myself, gonna merge


Elastic Search Issue Indexer fuzzy search

Gitea version (or commit ref): 1.12.0
Git version: 2.16.4
Operating system: SLES 15.1
Database:

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No
[ ] Not relevant

Log gist: https://gist.github.com/thedoginthewok/56fa4db31d560a1b40eeee5fe7431a5b

Description
I have set up elasticsearch with the following settings:
[indexer]
REPO_INDEXER_ENABLED = true
ISSUE_INDEXER_TYPE: elasticsearch
ISSUE_INDEXER_CONN_STR: http://localhost:9200
ISSUE_INDEXER_NAME: gitea_issues

I have created a test issue with the text "bla bla bla mr. freeman" and I am trying to find it using the issue search. I've done the same thing on the try.gitea.io test instance:
Issue: https://try.gitea.io/thedoginthewok/test_issue_search/issues/1
Search: https://try.gitea.io/issues?type=your_repositories&repos=[]&sort=&state=open&q=freema
On the test instance, the issue is successfully found. On my instance, I can only find the instance if I search for the complete word freeman.
Is there any way to configure a fuzzy search for elastic?
Screenshots
My instance with search term freeman:

My instance with search term freema:

Maybe you mean
[indexer]
REPO_INDEXER_ENABLED = true
ISSUE_INDEXER_TYPE = elasticsearch
ISSUE_INDEXER_CONN_STR = http://localhost:9200
ISSUE_INDEXER_NAME = gitea_issues

I've changed it to "=", but it behaves the same.
New log gist: https://gist.github.com/thedoginthewok/eaa51d81d8a82f13145ff7be1c56888b

Try searching freema*

Nope.
What is the try.gitea.io instance running on?

It just uses database search

So, probably with LIKE '%SEARCHTERM%'.
This is a bug in the elasticsearch indexer, right?

Elastic search query should be improved

That's because how we use elastic search. Below is the configuration from the source,
"mappings": {
			"properties": {
				"id": {
					"type": "integer",
					"index": true
				},
				"repo_id": {
					"type": "integer",
					"index": true
				},
				"title": {
					"type": "text",
					"index": true
				},
				"content": {
					"type": "text",
					"index": true
				},
				"comments": {
					"type" : "text",
					"index": true
				}
			}
		}

We should change the configuration to resolve the problem?

unstale


Shortcut for approving merged pull requests

Often times I'm still reviewing pull requests that have been merged already. It would be nice if there would an approve button.
Currently it looks like this:

Maybe a button next to Submit review that is called Approve and when clicked will insert :+1: into the textfield and hit on the submit review button.

@vanniktech you cant, once its merged you cant approve anymore

Two issues with this:

approvals after a merge mean nothing, so if you’re still reviewing you’ll just have to send it as comment, if you have anything to say
👍 might not be what people want to say, and we can’t have an option to customize this shortcut

I had cases like the one described in the OP above, when the PR was merged before I approved it. I could not prevent the PR from being merged into master (this is as intended - my opinion is advisory only, not meant to prevent anyone from carrying out what is the best course of action).
But there have been cases when I want to go back later and actually approve the PR after the branch was merged into master. This is, for example, for record keeping purposes, and for team communication purposes. We need to know and keep track of what was approved and not approved, and why. I could only find a way to comment that I approve. I could not find a way to approve and display the " approved these changes" icon in the UI.

I could not find a way to approve and display the " approved these changes" icon in the UI.

Because there isn't. GitHub does not allow it, so we can't do anything about it. This is not a UI issue but a model issue.
Keep in mind that this repo is for the Refined GitHub browser extension. If you want this, contact GitHub.


Login in footer behavior needs checking

[ ] Login in footer behavior needs checking

Could you please elaborate more on this issue?
Is it to change the text to "Logout" if the user is logged in?

This screen shows that you are logged in as per the top status, but the bottom footer says login, and doesn't seem connected:


Long load time

Issue Type: Bug
Extension Name: ligatures-limited
Extension Version: 1.4.0
OS Version: Windows_NT x64 10.0.19041
VS Code version: 1.55.2

{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 63,
		"activateCallTime": 0,
		"activateResolvedTime": 44,
		"activationReason": {
			"startup": true,
			"extensionId": {
				"value": "kshetline.ligatures-limited",
				"_lower": "kshetline.ligatures-limited"
			},
			"activationEvent": "*"
		}
	},
	"runtimeErrors": []
}

Can you add any more detail? Is that "codeLoadingTime" in seconds? (Because over a minute would be really long! 63 milliseonds, not so much.) Does this happen all the time, frequently, rarely?

I know something very related had been closed and actually been fixed, which was a long while ago, though. However, this looks pretty much like those numerous bug reports, that are mentioned here:
https://github.com/microsoft/vscode/issues/60318
I just jumped to the issues of any other plugin– first one gave me similar reports, that had also been submitted more recently... e.g. https://github.com/eamodio/vscode-gitlens/issues/1193 / https://github.com/eamodio/vscode-gitlens/issues/1244 / https://github.com/eamodio/vscode-gitlens/issues/1509
The reports, that I noticed so far, were all sent from from Windows clients
/cc @egamma


Reduce lag when ChatBloc is loading in each chat page

if I leave the app and reenter on the chat list, scrolling is very laggy

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #android-development.

The lag is because we fetch the chats from the DB and add them to the chat bloc. Something we do causes a ton of lag when each page is finished loading and the chat list state updates. Tons of hitters for me and an overall bad UX

We probably need to make it so we don't fully reload the chat bloc each time the app is resumed

I’m also increasing the chat bloc batch size to 15. This way, the first page will also have more items than what your phone can probably display. Might show a short lag for tablets, but it's better than before


Unstyled classes not applying properly in 1.2.0

No custom styles are applied in latest version. The following works in v1.1.4 without issue, but does not work in v1.2.0:
<Toaster
    position="top-right"
    :toast-options="{
        unstyled: true,
        classes: {
            toast: 'w-full px-4 py-3 rounded-md !font-normal text-sm bg-white !border shadow',
            description: 'text-gray-500 text-sm',
        },
    }"
/>

I am also experiencing this, the only one that is applying for me is title

Hi, can you guys provide a minimal reproduction?

I created a blank Vue/tailwindcss app and cannot reproduce this; the styles are applied normally. In my large codebase with many styles the styles are applied as expected on versions < 1.2.0, and break in versions > 1.2.0. I am not entirely sure why this is the case, but I will investigate further.


Parentheses and Braces are colored

Hi
On my VS parentheses and braces are showing with colors. I checked my global settings file and it seems I don't have any settings that override them.

Can you please help fix them?

You need to disable editor.bracketPairColorization.enabled


初始化数据都报错了

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See erro

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

done


HDFS-9895. Push up DataNode#conf to base class

Please kindly review the patch v001, see also https://issues.apache.org/jira/browse/HDFS-9895.

https://issues.apache.org/jira/browse/HDFS-9895 has been fixed. Closing.


Android - background scan while screen off

Hi,
It appears that the scan - monitor is not functioning on Android when the phone screen is off.
From the logcat, I've encountered warnings: "Cannot start unfiltered scan in screen-off.
This scan will be resumed later," even though I initiated monitoring with added regions:
_streamMonitoring = _beaconScanner.monitoring(regions).listen((result) async {
printDebug("${result.region.identifier} : ${result.region.beaconId} : ${result.monitoringEventType.name}");
});

As far as I can see, the issue will be resolved by this pull request: https://github.com/AltBeacon/android-beacon-library/pull/1176.

@akoskuczi-bw Did you manage to resolve this issue? If yes, How?

@akoskuczi-bw Did you manage to resolve this issue? If yes, How?

No, I didn't. I had to switch to FlutterBluePlus.


Fix dependency of docker aliases on docker plugin functions

Some of the docker aliases use functions found in the docker plugin. If the plugin is not enabled, these aliases do not work. This commit only defines the aliases if the plugin is enabled.
Also changed: dkelc now creates an explicit login shell, has the synonym dkbash and uses no backticks. Reason: on some docker images the status as login-shell is not set automatically, which causes e.g. /etc/bash.bashrc and /etc/profile not to be loaded in these images.
Note: There should be a convenience function in lib/helpers.bash that checks if a plugin is available/enabled/disabled. The if-statement if rather clonky.

Thanks for the quick fix!


Revert smooth slider background color

As per https://github.com/iterative/vscode-dvc/pull/3427#issuecomment-1464255980

I spent a couple of hours looking at this. Doesn't look like an easy fix.


Meaning of keys in .pkl after running track.py

Hi! Thanks for your great work!
As I finished running track.py and I got a .pkl file with following dict_keys(['time', 'shot', 'frame_path', 'tracked_ids', 'tracked_bbox', 'tid', 'bbox', 'tracked_time', 'appe', 'loca', 'pose', 'center', 'scale', 'size', 'img_path', 'img_name', 'class_name', 'conf', 'annotations', 'smpl', 'camera', 'camera_bbox', '3d_joints', '2d_joints', 'mask', 'extra_data']). Some of the keys are easy to understand like 'time', 'frame_path', however, some of the keys are really confused me like 'appe', 'tracked_bbox', 'bbox'... So, I wonder whether it is convenient for you to provide some detailed explanaion about the result after running track.py.
Furthermore, I noticed that some of the people can be detected when I run python demo.py independently on a single image, but can not be observed when running track.py in a video. Why is that happened?
Looking forward to your reply soon!

The output structure of the PHALP pkl file is described here.
When you run the track.py demo, you use the PHALP tracking algorithm. PHALP has its own set of hyperparameters and the visualization might differ from detection on independent frames. As an example, PHALP might need to track the people in multiple frames and could reject detections on independent frames that cannot initialize a consistent tracklet.

The output structure of the PHALP pkl file is described here.
When you run the track.py demo, you use the PHALP tracking algorithm. PHALP has its own set of hyperparameters and the visualization might differ from detection on independent frames. As an example, PHALP might need to track the people in multiple frames and could reject detections on independent frames that cannot initialize a consistent tracklet.

Thanks for your reply! I'll check it out later for the description.
Futhermore, your 4D-Humans paper mentioned that the tracker algorithm can be replaced with any other models. However, since the PHALP is installed towards pip, so I wonder how to replace the model in PHALP?

Do you want to use HMR2.0 with a different tracking algorithm, or do you want to use PHALP with a different 3D human pose estimation system?

Do you want to use HMR2.0 with a different tracking algorithm, or do you want to use PHALP with a different 3D human pose estimation system?

Sorry for missing the reply, my email didn't inform me.
In your paper section4, you wrote "Originally, PHALP used pose features based on the last layer of the HMR network, i.e., a 2048-dimensional embedding space. This limits the ability of PHALP to be used with different pose models (e.g., HMR 2.0, PARE, PyMAF etc.). To create a more generic version of PHALP, we perform the modification of representing pose in terms of SMPL pose parameters, and we accordingly optimize the PHALP cost function to utilize the new pose distance."
I wonder how your code represent this change, since track.py directly use the pip installed PHALP from github.

The track.py file defines the method used for Human Mesh Recovery. You could change this with a method other than HMR2.0.


As an HR advisor I want to view and employee's details so that the employee's promotion request can be supported.

Completed


Update dependencies and BDB

This updates the dependency builder with our versions of dependencies. Most notable changes are bdb and OpenSSL.
The second commit updates bdb everywhere to get a fully build running.

Looks good!

ACK if you fix the docs :)

Fixed the docs, and also the Qt Windows Printsupport thing. That should in theory make Travis light up green too (if it doesn't run out of disk space again... )

Reviewed & tested. ACK.


Type narrowing should be abandoned after an operation with potential side effects

TypeScript Version:  2.1.1
Code
export interface IUpdatee {
    id: string;
}

export class Container {
    public constructor(private updatee: IUpdatee) { }

    public setId(id: string) {
        this.updatee.id = id;
    }
}

export function TestContainer() {
    const updatee = {
        id: "before"
    };
    const container = new Container(updatee);

    if (updatee.id !== "before") {
        throw new Error("Updatee should stay with an initial value.");
    }

    // After this point we shouldn't be assuming updatee.id === "before"
    container.setId("after");

    // Operator '!==' cannot be applied to types '"before"' and '"after"'.
    if (updatee.id !== "after") {
        throw new Error("Updatee should receive a new value.");
    }
}

Expected behavior:
No errors, since this code is correct.
Actual behavior:
Operator '!==' cannot be applied to types '"before"' and '"after"'. thrown on line 28.
As put by @sethobrien: In the most extremely conservative compiler, it wouldn't do type narrowing on properties at all because the property getter itself could have side effects. that's probably too risk-averse to be useful. But if any other function call comes after we've narrowed a property, we should lose the narrowing info.

But if any other function call comes after we've narrowed a property

This seems conservative to the point of annoyance. It'd be very surprising to find a property narrowing reset after calling console.log or assert, for example. I would not look forward to getting daily bug reports on that one.
I would agree that it seems reasonable to invalidate narrowings on properties of an object which has a method called on it, though. It'd fix some really "stupid" narrowings we have (Array#length specifically) and is easier to understand.
Per usual see #9998 for other discussion

I wonder if it would be reasonable to make a dependency graph within each block scope of which objects have access to which other objects? In the above example, container has access to updatee because it's a constructor param; therefore, anything container does should have access to updatee.

Needless to say this would be a massive breaking change, and incorrectly lots of correct code an error in ways that would be rather difficult to get yourself out of without type assertions.
A proper fix would be some kind of mutability notation (similar to const methods in C++, or assume the reverse and mark which methods do have local side effects) that would have to be pervasive throughout all classes. Maybe in the far future we'll do some "immutable first" paradigm-shifting mode, but not anytime soon as a local change to narrowing behavior.


Support for historical countries?

Thanks for this gem. It looks really useful.
Do you have any plans to add historical countries as well to this list, for instance Czechoslovakia or ex Yugoslavia, or ex Soviet union?
If not, what are the plans going forward if a country splits or dissolves in the future?

So far we have simply not modeled historical data, I don't think it's an unreasonable request and most likely be solved with tracking a "dissolved_on" value.
Historically we delete these records.


Update requirements.txt

The packaging dependency was missing for the repository, causing a dependency error.

I would do this PR to adjust this, waiting to go up to master

Thanks @fabioselau077 @elianbarci


feat: Replications and WAF alignment for App Store - avm/res/app-configuration/configuration-store

Description

Added replicas
Update settings per pester results
ReadMes Update
Configured replicas for WAF alignment
Removed orphan Markdown

Fixes #1502
Closes #1502
-->
Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utlities (Non-module effecting changes)
[x] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[x] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

@matebarabas @eriqua
Looking for feedback on this on two items.
I was not sure on replicas what to do with locations...I found avm\res\aad\domain-service\tests\e2e\waf-aligned\main.test.bicep where locations are hard coded and figured maybe this is how it should be handled?
I also per https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.AppConfig.AuditLogs/ Audit logs are required and I wasn't sure what to put for diagnostic log locations for the default testing. I left them all (Event Hub, Storage Account, Workspace). I felt this was heavy and not sure on guidance.

@matebarabas @eriqua
Looking for feedback on this on two items.
I was not sure on replicas what to do with locations...I found avm\res\aad\domain-service\tests\e2e\waf-aligned\main.test.bicep where locations are hard coded and figured maybe this is how it should be handled?
I also per https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.AppConfig.AuditLogs/ Audit logs are required and I wasn't sure what to put for diagnostic log locations for the default testing. I left them all (Event Hub, Storage Account, Workspace). I felt this was heavy and not sure on guidance.

For the last point, those rules are currently not blocking as they are not part of the WAF reliability pillar. I'm not saying we shouldn't care about them, just that are not a priority 1 and can be taken for example in a next PR.
That said, as a rule of thumb, defaults tests should only cover required parameters, so audit logs rules can be exempted for defaults tests only. The exemption file specific for defaults tests is https://github.com/Azure/bicep-registry-modules/blob/main/avm/utilities/pipelines/staticValidation/psrule/.ps-rule/min-suppress.Rule.yaml

@matebarabas @eriqua
Looking for feedback on this on two items.
I was not sure on replicas what to do with locations...I found avm\res\aad\domain-service\tests\e2e\waf-aligned\main.test.bicep where locations are hard coded and figured maybe this is how it should be handled?
I also per https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.AppConfig.AuditLogs/ Audit logs are required and I wasn't sure what to put for diagnostic log locations for the default testing. I left them all (Event Hub, Storage Account, Workspace). I felt this was heavy and not sure on guidance.

For the last point, those rules are currently not blocking as they are not part of the WAF reliability pillar. I'm not saying we shouldn't care about them, just that are not a priority 1 and can be taken for example in a next PR.
That said, as a rule of thumb, defaults tests should only cover required parameters, so audit logs rules can be exempted for defaults tests only. The exemption file specific for defaults tests is https://github.com/Azure/bicep-registry-modules/blob/main/avm/utilities/pipelines/staticValidation/psrule/.ps-rule/min-suppress.Rule.yaml

@JFolberth now finally replying on the first point :)
The CI uses a region rotation for the deployment. So every test deployment may target a different location randomly picked up from this list: eastus, uksouth, northeurope and eastasia.
That is unless a location is hardcoded in the test file, like the example you mentioned for AADDS. In this case, I guess we can rely on the default logic for the primary resource, while we should hardcode the location for the replica in the test, as you did already.
I'm not an expert of App Store, but I'd expect it is not allowed to use the same location for the primary resource and the replica. So if, for example, the rotation logic picks 'eastus' for the primary resource, using 'eastus' for the replica would probably fail the deployment. Is that correct? If so,  for the hardcoded replica location we should pick a set not including the 4 locations we are rotating from.

@matebarabas @eriqua
Looking for feedback on this on two items.
I was not sure on replicas what to do with locations...I found avm\res\aad\domain-service\tests\e2e\waf-aligned\main.test.bicep where locations are hard coded and figured maybe this is how it should be handled?
I also per https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.AppConfig.AuditLogs/ Audit logs are required and I wasn't sure what to put for diagnostic log locations for the default testing. I left them all (Event Hub, Storage Account, Workspace). I felt this was heavy and not sure on guidance.

For the last point, those rules are currently not blocking as they are not part of the WAF reliability pillar. I'm not saying we shouldn't care about them, just that are not a priority 1 and can be taken for example in a next PR.
That said, as a rule of thumb, defaults tests should only cover required parameters, so audit logs rules can be exempted for defaults tests only. The exemption file specific for defaults tests is https://github.com/Azure/bicep-registry-modules/blob/main/avm/utilities/pipelines/staticValidation/psrule/.ps-rule/min-suppress.Rule.yaml

@JFolberth now finally replying on the first point :)
The CI uses a region rotation for the deployment. So every test deployment may target a different location randomly picked up from this list: eastus, uksouth, northeurope and eastasia. That is unless a location is hardcoded in the test file, like the example you mentioned for AADDS. In this case, I guess we can rely on the default logic for the primary resource, while we should hardcode the location for the replica in the test, as you did already.
I'm not an expert of App Store, but I'd expect it is not allowed to use the same location for the primary resource and the replica. So if, for example, the rotation logic picks 'eastus' for the primary resource, using 'eastus' for the replica would probably fail the deployment. Is that correct? If so, for the hardcoded replica location we should pick a set not including the 4 locations we are rotating from.

I am not overly familiar with it app stores as well. I have updated. My thought was with two to 1.) ensure we hit a region that the resource is not deployed to and 2.) ensure it can handle multiple locations. I have just updated it not to use eastus so this should be accomplished.

@matebarabas @eriqua
Looking for feedback on this on two items.
I was not sure on replicas what to do with locations...I found avm\res\aad\domain-service\tests\e2e\waf-aligned\main.test.bicep where locations are hard coded and figured maybe this is how it should be handled?
I also per https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.AppConfig.AuditLogs/ Audit logs are required and I wasn't sure what to put for diagnostic log locations for the default testing. I left them all (Event Hub, Storage Account, Workspace). I felt this was heavy and not sure on guidance.

For the last point, those rules are currently not blocking as they are not part of the WAF reliability pillar. I'm not saying we shouldn't care about them, just that are not a priority 1 and can be taken for example in a next PR.
That said, as a rule of thumb, defaults tests should only cover required parameters, so audit logs rules can be exempted for defaults tests only. The exemption file specific for defaults tests is https://github.com/Azure/bicep-registry-modules/blob/main/avm/utilities/pipelines/staticValidation/psrule/.ps-rule/min-suppress.Rule.yaml

@JFolberth now finally replying on the first point :)
The CI uses a region rotation for the deployment. So every test deployment may target a different location randomly picked up from this list: eastus, uksouth, northeurope and eastasia. That is unless a location is hardcoded in the test file, like the example you mentioned for AADDS. In this case, I guess we can rely on the default logic for the primary resource, while we should hardcode the location for the replica in the test, as you did already.
I'm not an expert of App Store, but I'd expect it is not allowed to use the same location for the primary resource and the replica. So if, for example, the rotation logic picks 'eastus' for the primary resource, using 'eastus' for the replica would probably fail the deployment. Is that correct? If so, for the hardcoded replica location we should pick a set not including the 4 locations we are rotating from.

I am not overly familiar with app stores as well. I have updated. My thought was with two to 1.) ensure we hit a region that the resource is not deployed to and 2.) ensure it can handle multiple locations. I have just updated it not to use westus and centralus so this should be accomplished.

Sounds great. Just added a suggestion for the other test file to do the same. Overall it looks good. As a final step, could you please

Rerun the set-AVMModule utility to update the Readmes
Retrigger the pipeline manually to verify if the run works after enabling purge protection by default. Based on the result I may need to look into the CI deployment removal logic.

Thanks!

@matebarabas @eriqua
Looking for feedback on this on two items.
I was not sure on replicas what to do with locations...I found avm\res\aad\domain-service\tests\e2e\waf-aligned\main.test.bicep where locations are hard coded and figured maybe this is how it should be handled?
I also per https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.AppConfig.AuditLogs/ Audit logs are required and I wasn't sure what to put for diagnostic log locations for the default testing. I left them all (Event Hub, Storage Account, Workspace). I felt this was heavy and not sure on guidance.

For the last point, those rules are currently not blocking as they are not part of the WAF reliability pillar. I'm not saying we shouldn't care about them, just that are not a priority 1 and can be taken for example in a next PR.
That said, as a rule of thumb, defaults tests should only cover required parameters, so audit logs rules can be exempted for defaults tests only. The exemption file specific for defaults tests is https://github.com/Azure/bicep-registry-modules/blob/main/avm/utilities/pipelines/staticValidation/psrule/.ps-rule/min-suppress.Rule.yaml

@JFolberth now finally replying on the first point :)
The CI uses a region rotation for the deployment. So every test deployment may target a different location randomly picked up from this list: eastus, uksouth, northeurope and eastasia. That is unless a location is hardcoded in the test file, like the example you mentioned for AADDS. In this case, I guess we can rely on the default logic for the primary resource, while we should hardcode the location for the replica in the test, as you did already.
I'm not an expert of App Store, but I'd expect it is not allowed to use the same location for the primary resource and the replica. So if, for example, the rotation logic picks 'eastus' for the primary resource, using 'eastus' for the replica would probably fail the deployment. Is that correct? If so, for the hardcoded replica location we should pick a set not including the 4 locations we are rotating from.

I am not overly familiar with app stores as well. I have updated. My thought was with two to 1.) ensure we hit a region that the resource is not deployed to and 2.) ensure it can handle multiple locations. I have just updated it not to use westus and centralus so this should be accomplished.

Sounds great. Just added a suggestion for the other test file to do the same. Overall it looks good. As a final step, could you please

Rerun the set-AVMModule utility to update the Readmes
Retrigger the pipeline manually to verify if the run works after enabling purge protection by default. Based on the result I may need to look into the CI deployment removal logic.

Thanks!

All updated!


chia-monitor setup in a secondary network reports a duplicate harvester

Configuration:

So I have a peculiar setup with 2 chia full nodes in different locations, each with its harvesters, and I wanted to set them up in a single dashboard, because all the plots are for the same wallet.
Node A - Harvester A1 (<IP_ADDRESS>)
Harvester A2 (<IP_ADDRESS>)

Node B - Harvester B1 (<IP_ADDRESS>)
Harvester B2 (<IP_ADDRESS>)
Harvester B3 (<IP_ADDRESS>)

(The IP adresses are the same ones seen in the screenshot below)
Grafana and prometheus are setup in Node A, whereas chia-monitor is installed on both nodes and they are made available to prometheus using this config:
scrape_configs:
  - job_name: chia_monitor_node_a
    static_configs:
    - targets: ['<IP_ADDRESS>:8000']
  - job_name: chia_monitor_node_b
    static_configs:
    - targets: ['NODE_B_DOMAIN_NAME.COM:8000']

So the issue is caused by the fact Node B and its harvesters are behind 2 routers before reaching the internet:
Node B
-------- Network2 - <IP_ADDRESS>
Router2
-------- Network1 - <IP_ADDRESS>
Router1
-------- INTERNET

Router1 is set to have Router2 as DMZ, and then port 8000 is forwarded in Router2 toward Node B.
In the dashboard I get 2 entries for harvester B2, one with its own IP address, and one with Router2's IP. and this doesn't happen with the other 2 harvesters.

All the metrics that report the harvester host have the same issue. One workaround I found was to change the PromQL query in Grafana to have a filter for that duplicate entry like so: chia_plot_size{host!="<IP_ADDRESS>"}. but I'm still wondering if it's not messing up other things like notifications (In telegram I have plots changed in 24H at -99 plots...).

Hmm strange... Do you see the same result when using chia farm summary?

Okeey so it seems chia is detecting that harvester in a weird way:
Local Harvester
   208 plots of size: 20.590 TiB
Remote Harvester for IP: <IP_ADDRESS>
   81 plots of size: 8.018 TiB
Remote Harvester for IP: <IP_ADDRESS>
   103 plots of size: 10.196 TiB

The machines are set with the IPs <IP_ADDRESS> for the main node, <IP_ADDRESS> (the one detected sometimes as <IP_ADDRESS> same as router IP) and <IP_ADDRESS> (this one I changed from <IP_ADDRESS> in the screenshots above)
In the harvesters the config is set like this:
harvester:
  # The harvester server (if run) will run on this port
  port: 8448
  farmer_peer:
    host: <IP_ADDRESS>
    port: 8447

When I saw that I thought I forgot an earlier setting where I was using a domain name and thus I go through the router, this would have explained it, but it's actually configured as LAN only...
Anyway this doesn't relate to chia-monitor, but more to chia's harvester detection. You can close if you don't see any obvious fix/workaround.
Thanks.


Build OASIS3-MCT by default

eTSMP now builds OASIS3-MCT by default instead of reusing an existing OASIS3-MCT library.
cc: @chartick @s-poll

Fixes #4 . Thanks for verifying @mvhulten


Occurring error when I add new tokens to the tokenizer.

Hi,
I want to add new tokens to the tokenizer through:
tokenizer.add_tokens("<NEW1>", special_tokens=True)
tokenizer.add_tokens("<NEW2>", special_tokens=True)
model.resize_token_embeddings(len(tokenizer))
model.config.vocab_size = len(tokenizer)

Then I save the model as LoRA adapters through:
model.save_pretrained(save_path)

When I load the model, the error occurs:
model, tokenizer = FastLanguageModel.from_pretrained(
    model_name = save_path, # YOUR MODEL YOU USED FOR TRAINING
    max_seq_length = max_seq_length,
    dtype = dtype,
    load_in_4bit = load_in_4bit,
)

RuntimeError: Error(s) in loading state_dict for PeftModelForCausalLM:
        size mismatch for base_model.model.model.embed_tokens.weight: copying a param with shape torch.Size([32002, 4096]) from checkpoint, the shape in current model is torch.Size([32000, 4096]).
        size mismatch for base_model.model.lm_head.weight: copying a param with shape torch.Size([32002, 4096]) from checkpoint, the shape in current model is torch.Size([32000, 4096]).

It seems that the saved checkpoint does not match the pre-defined model architecture (with 32000-d output). What should I do to solve this issue?
Thanks,

@charlesCXK Oh I think you'll have to add modules_to_save ie https://github.com/unslothai/unsloth/wiki#finetuning-the-lm_head-and-embed_tokens-matrices

@danielhanchen
Dear author,
Thanks for your reply! I think there is no need to add modules_to_save. We can see that the model is already saved ("copying a param with shape torch.Size([32002, 4096]) from checkpoint"). I am wondering how can I load the saved model using FastLanguageModel.from_pretrained. I want to use the saved model (with new vocabulary) for inference.

@danielhanchen
Dear author,
is there any updates? I tried the newest version and there still occurs error when adding new tokens and loading checkpoints.

Dear author,
I have fixed the issue and create a pull request: https://github.com/unslothai/unsloth/pull/272.
Now we can successfully load checkpoints with newly added special tokens through new_token_num argument in FastLanguageModel.from_pretrained function.

@charlesCXK Oh thanks!! So sorry again on the issue! I'll take a look a your PR - thanks so much again!

Hi, bumping this up again! I added a new token to the tokenizer. Now I want to load my LoRA checkpoint using from_pretrained, but I got the same error:
RuntimeError: Error(s) in loading state_dict for PeftModelForCausalLM:
	size mismatch for base_model.model.model.embed_tokens.weight: copying a param with shape torch.Size([32001, 4096]) from checkpoint, the shape in current model is torch.Size([32000, 4096]).
	size mismatch for base_model.model.lm_head.weight: copying a param with shape torch.Size([32001, 4096]) from checkpoint, the shape in current model is torch.Size([32000, 4096]).

@danielhanchen Would you mind reviewing charlesCXK's PR?

@charlesCXK @chtmp223 Whoops I actually totally missed this, but now using resize_model_vocab = True in FastLanguageModel.from_pretrained(...) should hopefully fix the issue


Example without an InAppWebView or show code from example.openwallet.org?

I wanted to use this plugin to try and sign in to my Metamask wallet on iOS or Android completely natively, but your example uses an InAppWebView that completely hides what happens when we click the "Connect to WalletConnect" button. As a Wallet Connect newbie I'm completely lost. Is it a requirement to go through a web page that does most of the work like that, and if so, can you share how you implemented the website on example.openwallet.org? And if it's possible to do everything natively, could you show an example of how to do that, with clearer indication as to what the values for each parameter should be? Right now the documentation is not very helpful.

any example to this?


python: add gpiozero as pip dependency

Ubuntu is the only platform I have to test, and it's not packaged.

Please use the -pip suffix when adding pip only keys.
And add python packages in the python.yaml file rather that base.yaml.
Even if you dont test with it can you please add a debian entry as well?
Note for the future: this package will be available in apt soon:

ubuntu arm since zesty no amd64 yet
debian since buster

same comments apply to #16545

Sure thing, done. Fixed #16545 as well.

I see ubuntu and debian packages for this too:
https://packages.ubuntu.com/zesty/python-gpiozero
https://packages.debian.org/source/buster/gpiozero

Alright, updated.

Thanks for iterating. Two slight requests, add yakkety which was skipped and CI needs the keys in alphabetical order.
you can validate locally with nosetests -s or specifically for rosdep nostests -s test/test_rosdep_formatting.py

Whoops, not sure how I missed Y! Done and done.

Can you please add ubuntu bionic as well? and rename the key to python-gpiozero

Ah yes of course. Renamed and added bionic.

Sorry, also top level alphabetization here.

Fixed here as well.


feat(event-bridge): Add trace-header field to Event type

Relevant aws-sdk-js commit: https://github.com/aws/aws-sdk-js/commit/438670cd3d6687c355e79d71ba3444f08a3cf5fc#diff-e39ababf70a50051cafcb815f0f7bb71fbb9f0ee616713dc2730885fbff9d7a7R1295-R1298

Thanks for the contribution!

Thanks for the contribution!

Thanks for the work you've done on the library, as well as the quick response and helpful suggestions!

Thanks for the fix! I'm curious, can you share any details on your use-case for functionless?

Thanks for the fix! I'm curious, can you share any details on your use-case for functionless?

@sam-goodwin Glad to!
I'm leading the effort to build a greenfield data processing PaaS. I'm pretty much an FP and event-sourcing zealot, so every operation is decoupled. Some of the categories of events we deal with are:

User management operations (sales leads generated, new companies registered, subscriptions enabled/expired, users added/removed, permissions added/removed, etc.)
Data processing operations (new datasets uploaded, automated processing events, user job submissions/events, etc.)
Support operations (user requests, investigations, resolutions, admin overrides, etc.)

We have a skeleton crew, so I try to choose as many AWS managed services as possible (and of course, full CDK). For the event bus, as much as I love Kafka, I didn't want to risk the human overhead that I've seen, so EventBridge was a logical choice. (I also have no experience with MSK.) Similarly, as much as I love Scala, it's hard to hire for, and the learning curve can be steep. Plus, using Typescript for CDK and React (web and apps), it was a logical choice for backend code as well.
Despite religiously typing events, there was still way too much boilerplate written and time spent debugging issues caused by EventBridge's stringly-typed events. So I looked for a better way, and that's how I found Functionless!

@bakerlee thanks for the response - super interesting. Those sound like great use-cases we would love to support with Functionless. We are working on some foundational pieces right now (like closure serializer and IAM Policy inferrence) which we are excited to use to build type-safe SQS, SNS, Kinesis and Firehose constructs with map, flatMap, reduce, collect etc. operations for functionally piping data around.
Straw-man experience would look something like the following
const bus = new EventBus<T>(stack, "bus");

const queue = bus.all().toSQSQueue(stack, "queue");

const firehose = queue.flatMap(event => tranform(event)).toKinesisFirehose({
  // s3
  // elastic search
  // redshift
  // snowflake??
  // etc.
  ..
})

Would love to connect and chat more if you're interested!

One thing to note re: Kafka vs Event Bridge is ordering. Event bridge has no order guaranteees which are helpful for stream processing.
On top of the SQS, SNS, Kinesis and Firehose abstractions, we could also explore a MSK abstraction. Type safe topics !


Added solution of contains-duplicate (Leetcode) in Java.

Description
Added solution of contains-duplicate(Leetcode) in java along with some example test cases.
Fixes #1400
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@rajeshkumar2024 main function??

@Amit366 in leetcode we only get one function to solve.

@Amit366 I have updated the code please check.


I am not able to search content in PDF

Attach (recommended) or Link to PDF file here:
HebrewText.pdf
Configuration:

Web browser and its version: Firefox 124
Operating system and its version: Mac OS
PDF.js version: v4.0.379
Is a browser extension: NO

Steps to reproduce the problem:

Open attached document in Mozila firefox
search for the available content ההתרחבות הבינלאומית התרחשה גם היא

What is the expected behavior? (add screenshot)
I should be able to search multi word contents in PDF when underlying Language is RTL (Hebreww in this case)
Why pdf.js fails to search such cases ? It is a show stopper in large scale when it comes to RTL languages.
What went wrong? (add screenshot)
Multi word content search is not possible in PDF documents1.  with RTL language where as I can do the search when same PDF is opened in chrome browser directly.

Duplicate of #16716

@Snuffleupagus May I know next plans by pdf.js on searching multi words in PDF containing RTL languages ?
Can you please share some details to make us aware if PDF.js consider this as defect to address or permanent limitation  ?
Many thanks!


Disco colors showing when either VS or language server refer to out-of-date project.razor.vs.bin

Steps to repro

change TFM in the project file, and save
open App.razor and observe disco colors

Summary
This summary explains in a bit more detail a cause for why/when we end up seeing disco color in @ code blocks in razor files.
Latest observations suggest that:

VS and the language server both rely on project.razor.vs.bin file which gets created in the obj folder.

disco color bugs happen when VS and language server end up looking at project.razor.vs.bin file in two separate obj folders
(and when one of the two ends up looking at an out of date / incorrect file)

With the bug explained in

Razor Language Server finds old obj folders to watch, causing issues · Issue #9600 · dotnet/razor (github.com)
which is fixed in PR: https://github.com/dotnet/razor/pull/9601
with the fix, the language server no longer reads the out-of-date file

it assumes that VS is updating the new file

But for the current issue,

knowing that
opening a razor file or creating a new razor component triggers creation or update of project.razor.vs.bin file (when not created yet)
we are noticing that

once we change target framework in csproj (e.g. from net6 to net8)
assuming the project.razor.vs.bin file does not exist yet in either net6 or net8 obj Debug folders, then:

if we open an existing razor file in VS, that causes the file creation in the old obj path

causing disco colors

but if we create a new razor file in VS, that causes the file creation in the new obj path

causing no disco colors

Debugging in main branch
related to
Fire telemetry if language server and client get out of sync by davidwengier · Pull Request #9202 · dotnet/razor (github.com)
when I debug locally I get into:
Debug.Fail($"The language server is sending us changes for what it/we thought was an empty file, but their/our copy is not empty. Generated C# file may have corrupted file contents after this update.");

shows up when debugging in main branch right after I:

created blazor server app net6
switched tfm in csproj to net8
then opened app.razor

Debugging in release branch
Using @davidwengier 's offline instructions, given repro:
1- change TFM in the project file, and save
2- open App.razor and observe disco colors

Confirmed step 1, DefaultWindowsProjectHost updates the project system to understand the new TFM (which will manifest as a new ProjectKey) and the _mappings field holds one item per TFM.
Then with step 2 the language server starts up since this is the first time the VS instance opens any razor file.
When starting the language server, it pulls from DefaultProjectConfigurationFilePathStore and tells the language server which bin files to read
EditorDocumentManagerListener sets up Changed event for DefaultProjectConfigurationFilePathStore, for all the razor documents we see the ProjectKey actually points to net6 TFM so the project.razor.vs.bin from the net6 will get picked up.

I laded here from #9700 then #9600.
I don't know if this is related, but every time I created a new page or component, VS does not recognize it. If you right click and open Properties of the newly created .razor file, you can see that the build action is None. Changing it to Content may get around the bug, but ultimately this could be fixed by getting rid of the obj directory then clean the solution.

The modern, released versions of VS Win and VS Code no longer use project.razor.*.bin.  Please let us know if you continue to run into issues with similar symptoms.


ci(lint): allow list items without ending dot in comments

What this PR does
Allow list items without ending dot in comments.

Current dependencies on/for this PR:

main

PR #304   👈

PR #305

PR #306

This comment was auto-generated by Graphite.

Codecov Report
Base: 63.12% // Head: 63.31% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (91eac93) compared to base (a988730).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   63.12%   63.31%   +0.19%
==========================================
  Files         130      130
  Lines       17355    17355
==========================================
+ Hits        10955    10988      +33
+ Misses       5847     5826      -21
+ Partials      553      541      -12

Impacted Files
Coverage Δ

internal/storagenode/storagenode.go
71.28% <0.00%> (+0.33%)
:arrow_up:

internal/metarepos/report_collector.go
77.00% <0.00%> (+0.42%)
:arrow_up:

internal/storagenode/replication_server.go
78.81% <0.00%> (+0.84%)
:arrow_up:

internal/storagenode/logstream/executor.go
81.48% <0.00%> (+1.20%)
:arrow_up:

internal/metarepos/storage.go
80.79% <0.00%> (+1.65%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Proposition:

I propose to change RingCube to examine the input type, and if it's a string, to automatically open the filestream. This, to avoid the, IMHO, cumbersome Ringcube.open API.
If you agree, I can do a PR?

Maybe leave the existing .open for backwards compatibility of course, so that no code changes are required for older code.

Sounds good to me. Looking forward to your PR.