Info flag is drawn behind route

The information element that appears on mouseover on the route is displaying behind the route. See the attached screenshot for details.

Route is here https://brouter.de/brouter-web/#map=14/52.0727/9.9091/standard,route-quality&lonlats=9.90057,52.065103;9.909067,52.084148 .

Thanks for the report! You might have missed #408 when searching for existing issues, though ;)
Feel free to close the issue (which apparently I am not allowed to do, along with adding a "duplicate" label...).


added kokuwa repo

Signed-off-by: André Bauer<EMAIL_ADDRESS>

/assign @rimusz

The Helm Hub has been superseded by the Artifact Hub. Chart repositories should now be listed there. Closing this PR.


Improvement for k8s.io/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume/

Hi,
I was unable to create using the provided information. and done some adjustments to make this work.
My setup has workers with NFS mount to /mnt/data. I create /mnt/data/wp/mysql and /mnt/data/wp/wordpress folders.
I added the following to the end of mysql-deployment.yaml:
apiVersion: v1
kind: PersistentVolume
metadata:
name: mysql-pv-claim
labels:
app: wordpress
tier: mysql
spec:
capacity:
storage: 20Gi
accessModes:
- ReadWriteOnce
hostPath:
path: "/mnt/data/wp/mysql"
And just for using NFS directly added the following to the end of wordpress-deployment.yaml.
apiVersion: v1
kind: PersistentVolume
metadata:
name: wp-pv-claim
labels:
app: wordpress
tier: frontend
spec:
capacity:
storage: 20Gi
accessModes:
- ReadWriteMany
persistentVolumeReclaimPolicy: Retain
nfs:
path: /vol/vol2/wp/wordpress
server: <IP_ADDRESS>
readOnly: false
I have changed the mysql image to 5.7....
Please add a remark that you will not be able to download images unless register to docker hub and apply that to the Kubernetes settings at the master:
First file - create-secret-docker-registry.sh:
#!/bin/bash
for ns in $(kubectl get namespaces |grep -v NAME|awk '{print $1}')
do
kubectl create secret docker-registry docker.registry
--docker-username=
--docker-password='' -n $ns
done
Second file:
for ns in $(kubectl get namespaces|grep -v NAME|awk '{print $1}')
do
for sa in $(kubectl -n $ns get sa|grep -v SECRETS|awk '{print $1}')
do
kubectl patch serviceaccount $sa -p '{"imagePullSecrets": [{"name": "docker.registry"}]}' -n $ns
if [ $? -eq 0 ]; then
echo $ns $sa patched
else
echo Error patching $ns $sa
fi
done
done
I had to create the mysql wordpress DB
kubectl exec --stdin --tty  wordpress-mysql-xxxxxxxxxxxx -- /bin/bash
mysql -u root -p
CREATE DATABASE wordpress;
Also after deployment you need to access the application using web browser to /admin/install.php not the root (I got 500 error).
I don't think below is true if one use hostpath like I did (/mnt/data/wp/mysql).

/language en

@ydahan the issue description is rather hard to read. Would it be OK if I reformat it for you?

Yes, sure

Yes, Sure

I tidied it.
/reopen

@ydahan I am able to run all the given steps for MySQL-word-press-persistent-volume successfully , although all the steps for creating PV,PVC's service are running fine in my environment but i am not able to access wordpress setup page

@ydahan I am able to run all the given steps for MySQL-word-press-persistent-volume successfully , although all the steps for creating PV,PVC's service are running fine in my environment but i am not able to access wordpress setup page

Are you able to reach any page? if yes just run http://x.x.x.x/wp-admin/install.php

@ydahan no, it throws error for setup page

@ydahan no, it throws error for setup page

O.K, you need to open console and to do tail -f /var/log/apache2/error.log
I don't know what kind of setup are you running but DNS must be working since the sql server parameter is passed as a variable using name , if application is running on default namespace you should be able to nslookup wordpress-mysql.default.svc.cluster.local from any worker.

Sure , i will try this.

After restarting cluster , i got the expected output , i don't need to perform the above steps, i don't know why its failing earlier.

/remove-lifecycle stale


add multiline comments

See https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.HTMLFormatter.html#module-comments

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

can we get a version bump for this?

@TheArrowsmith I have asked publish access.

Done.

Thanks!


feat(GitHubOrgEntityProvider): adds throttling and rate limit handling to GithubOrgEntityProvider

Hey, I just made a Pull Request!

When using the GithubOrgEntityProvider in organizations with over 14000 users on a GitHub Organization, the EntityProvider was failing 100% of the time with Secondary Rate Limit errors.
This fix adds the official throttling plugin to the graphql client responsible for fetching the data.

I extracted the code to instantiate the GraphQL Client into a separate function, so we can re-use this in the other EntityProviders later

I tested this package locally and not only the rate limit consumption went down significantly, but when a rate limit error happened, it successfully retried and moved on.
PS: Using octokit versions on this monorepo is getting complicated, as there are so many different versions installed. I spent most of my time trying to find the exact octokit versions I could use that would not break types everywhere.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Something seems flaky in the Windows E2E test. Can someone retry that ?

Not stale


Add Kelli Blalock to /team page

Name: Kelli Blalock
Picture: TBD
LinkedIn URL: https://www.linkedin.com/in/kelliblalock/
Title: Social Media & Contributor
Bio: TBD

Thanks, I'd like to do this one 😃

Go for it, @kellim 🙂

merged to master Nov 30th.


Problem displaying long captions

Most of the captions I use are longer, as they describe the image.  Is there a way to display longer captions?

I just had this issue too. I'm sure you've already solved it by now but in case anyone else needs it, I changed the white space to get the text to wrap.
.slbCaption {
white-space: normal;
}

Hey vikkic23,
thank you for your help. Unfortunately, this doesn't really solve my problem, because when I apply white-space: normal; the caption covers the image.

also try to reduce font size.
.slbCaption {
    font-size: 1rem;
    white-space: normal;
}


Challenge Integrating Repack in React Native Mono Repo: App1 Loads Successfully, App2 Fails to Load from Server Bundles

Ask your Question

Dear GitHub Community,
We are currently in the process of integrating repack into our React Native project to facilitate collaborative work across multiple teams. Prior to finalizing this integration, we are rigorously testing to ensure that it aligns with our expectations.
I have set up a mono repo containing three React Native projects: one serving as the host and the other two as mini apps. Locally, everything functions as expected - both on Android and iOS - with the successful loading of the two mini apps into the host app.
However, the challenge arises when attempting to download the bundles from the server. Here are the commands used to generate the iOS and Android bundles:
"bundle:ios": "react-native webpack-bundle --platform ios --entry-file index.js --bundle-output ./dist/index.bundle --dev=false",
"bundle:android": "react-native webpack-bundle --platform android --entry-file index.js --bundle-output ./dist/index.bundle --dev=false",

Despite uploading these bundles to Firebase Storage and attempting Firebase Hosting, both approaches have proven unsuccessful.
Below is the code snippet utilized for bundle download, with an emphasis on utilizing these server bundles exclusively in development mode:
const resolveURL = Federated.createURLResolver({
  containers: {
    app1: 'http://localhost:9000/[name][ext]',
    app2: 'https://firebasestorage.googleapis.com/v0/b/jaswant-dhayal.appspot.com/o/index-android.bundle?alt=media&token=0f5ab5ee-4b55-424a-8b6b-cd5f13ac119c',
  },
});

ScriptManager.shared.addResolver(async (scriptId, caller) => {
  let url;
  if (caller === 'main') {
    url = Script.getDevServerURL(scriptId);
  } else {
    url = await resolveURL(scriptId, caller);
  }

  if (!url) {
    return undefined;
  }
  return {
    url,
    cache: false, // For development
  };
});

const App1 = React.lazy(() => Federated.importModule('app1', './App'));
const App2 = React.lazy(() => Federated.importModule('app2', './App'));

function App(): React.JSX.Element {
  return (
    <SafeAreaView>
      <Text style={styles.sectionTitle}>This is Host app Jassu</Text>
      <React.Suspense fallback={<Text>Loading app1...</Text>}>
        <App1 />
      </React.Suspense>
      <React.Suspense fallback={<Text>Loading app2...</Text>}>
        <App2 />
      </React.Suspense>
    </SafeAreaView>
  );
}

Additionally, I am exploring the possibility of introducing versioning for these server bundles and investigating the compatibility of utilizing CodePush bundles in this context.
Note:
While app1 is loading fine, app2 never loads. Surprisingly, when attempting to load app2 using the local bundle URL (app2: 'http://localhost:9001/[name][ext]'), it loads perfectly fine.
Any assistance or guidance provided would be greatly appreciated.
Thank you.

Hey @dhayaljaswantgit
for your first issue, please try changing the production path in the following manner:
from:
const resolveURL = Federated.createURLResolver({
  containers: {
    app1: 'http://localhost:9000/[name][ext]',
    app2: 'https://firebasestorage.googleapis.com/v0/b/jaswant-dhayal.appspot.com/o/index-android.bundle?alt=media&token=0f5ab5ee-4b55-424a-8b6b-cd5f13ac119c',
  },
});

to:
const resolveURL = Federated.createURLResolver({
  containers: {
    app1: 'http://localhost:9000/[name][ext]',
    app2: 'https://firebasestorage.googleapis.com/v0/b/jaswant-dhayal.appspot.com/o/[name][ext]',
  },
});

this is because there is more than one file to resolve using the resolver here. Typically you first download .container.bundle and then the app.chunk.bundle. Also please note that you don't need to include the index-android.bundle for the mini-apps as it's unused in MF setup.
when it comes to versioning, I can tell you from my experience that it's not a trivial problem to solve, you can look into this PR that introduced SDK to the super-app-showcase to help with having only 1 version to align to.


[WIP] add generic sets to utils

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We have a sets utils in pkg in k8s/k8s. This refactors that implementation to use generics instead of code-generation and moves the library here.
Release note:
utils now requires golang 1.18

utils now requires golang 1.18

A couple thoughts:

as long as we have supported Kubernetes release branches that use k8s.io/utils and aren't on go1.18, I would not expect us to make the minimum version go1.18... can we use go version build tags or something similar to scope these files to go1.18 while making the rest of the module consumable by earlier versions of go?
we have strict go API compatibility checks on this repo... is this the best place to start experimenting with go APIs using generics? we'll be stuck with any mistakes we're unhappy with

as long as we have supported Kubernetes release branches that use k8s.io/utils and aren't on go1.18, I would not expect us to make the minimum version go1.18... can we use go version build tags or something similar to scope these files to go1.18 while making the rest of the module consumable by earlier versions of go?

Agreed, if we can have some form of conditional compilation and isolate the packages that require go1.18, that'd be nice. Otherwise, we could also branch into a requires-1.18 vs no-1.18. In case we have to make a patch to an older version, we could apply it to the no-1.18 and merge that change back into the 1.18 branch, the process is a little more involved. We can also put that process in place lazily when/if we eventually need it. How often have we needed to patch utils in a minor release?

we have strict go API compatibility checks on this repo... is this the best place to start experimenting with go APIs using generics? we'll be stuck with any mistakes we're unhappy with

The thing is that yeah, utils are usually the best place to start using generics :-(

/reopen

We let this age-out. When do we bring it back?

1.27 (so next release)

/lifecycle frozen

/remove-lifecycle rotten

/close

I've lost track again - did we MEAN to close this or will this come back?  I just saw https://github.com/kubernetes/kubernetes/pull/112377 which does this but inside apimachinery.  That seems like an unfortunate final home to me...

I can reopen this, I'll circle back around to this later this week.
/reopen

I didn't mean to add urgency, just that I wondered why it was OK for apimachinery to go generic and this not to, and then saw it was closed :)

I didn't mean to add urgency, just that I wondered why it was OK for apimachinery to go generic and this not to, and then saw it was closed :)

Friendly ping :)

Oh, I thought this was still on hold until ... later (I lost track of the dates, honestly).  Will take a look

Oh, I thought this was still on hold until ... later (I lost track of the dates, honestly). Will take a look

I think we're already using generics in utils.

The doc on comparable is ... tricky to digest.

The doc on comparable is ... tricky to digest.

That’s putting it mildly! But I think it’s the right approach in this case (assuming a Go 1.20 bump is acceptable).

I'm trying to digest why it's OK to runtime-panic on any and how to apply the dirty trick at the end of the doc

So basically my plan is twofold:
(1) introduce sets using ordered type so that we can have set.SortedList
(2) once we can bump utils to golang 1.20, then I will introduce a set[comparable] which has the exact API as set[ordered] without the SortedList method. Then I will create an API compatible version of set[ordered] which delegates all calls underneath to set[comparable] and then implement SortedList on set[ordered].

once we can bump utils to golang 1.20, then I will introduce a set[comparable] which has the exact API as set[ordered] without the SortedList method. Then I will create an API compatible version of set[ordered] which delegates all calls underneath to set[comparable] and then implement SortedList on set[ordered].

Is there an issue open for tracking that? Do you already have a prototype?


Az/preview images

Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added a description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

@azhavoro , some tests are failed
ndex created!
[2254](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2255)
  File "/home/django/cvat/apps/engine/tests/test_rest_api.py", line 3370, in _test_api_v2_tasks_id_data_spec
[2255](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2256)
The following import formats have no pair: {'CVAT 1.1'}
[2256](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2257)
    self.assertLessEqual(preview.size, image_sizes[0])
[2257](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2258)
The following export formats have no pair: {'CVAT for video 1.1', 'CVAT for images 1.1'}
[2258](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2259)
AssertionError: (256, 52) not less than or equal to (244, 507)
[2259](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2260)
loading annotations into memory...
[2260](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2261)

[2261](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2262)
Done (t=0.00s)
[2262](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2263)
----------------------------------------------------------------------
[2263](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2264)
creating index...
[2264](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2265)
Ran 272 tests in 467.384s
[2265](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2266)
index created!
[2266](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2267)

[2267](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2268)
The following import formats have no pair: {'CVAT 1.1'}
[2268](https://github.com/opencv/cvat/actions/runs/3713037113/jobs/6295588528#step:7:2269)
FAILED (failures=1, errors=2, skipped=36)

Generally, fine. But could you please look license headers and reduce code duplication according to proposed ideas?

@azhavoro , any updates?


edit image package version from 3.0.2 to 4.0.02

could this be approved please ?
I have an app which requires the image package and using esc_pos_utils forces me to keep image at version 3.0.2 instead of being able to upgrade to 4.1.6...
thanks

@dprophete I have it in my fork I published
https://pub.dev/packages/esc_pos_utils_updated


demo files?

having difficulty locating the demo files mentioned....  any help appreciated...

What demo files are you referring to @nextgennewmedia ?

closing due to inactivity.


Timex.shift/2 with time-shift always converts precision to :microsecond in Elixir v1.14+

Steps to reproduce
with Elixir v1.13
iex(1)> now = ~U[2023-01-01 10:20:30Z]
~U[2023-01-01 10:20:30Z]
iex(2)> Timex.shift(now, hours: 1)
~U[2023-01-01 11:20:30Z] # OK

with Elixir v1.14
iex(1)> now = ~U[2023-01-01 10:20:30Z]
~U[2023-01-01 10:20:30Z]
iex(2)> Timex.shift(now, hours: 1)
~U[2023-01-01 11:20:30.000000Z] # precision changes unnecessarily

Description of issue

Elixir v1.14 changes DateTime.add/4 behaviour to preserve the maximum precision of given parameters.

commit: https://github.com/elixir-lang/elixir/commit/5a583c753b96865a7cdec2fb4c1ab9c96b836d24
relates to: https://github.com/elixir-lang/elixir/issues/12303

Timex.shift/2 uses DateTime.add/4 with :microsecond precision to apply time-shift result.

https://github.com/bitwalker/timex/blob/e1c4d424a5c7840f63efd33cd70e3b5d4f9bfaa1/lib/datetime/datetime.ex#L450

This causes unnecessary precision conversions in Elixir v1.14 and later.

For me this has been happening specifically in 1.14.3, not any of the other 1.14 versions.

It looks like Elixir adds the precision to datetime and naive_datetime unlike before where it didn't merge it
https://github.com/elixir-lang/elixir/compare/v1.14.2...v1.14.3#diff-b83c142c2405080dc98ca11f1da9784fe7199a376c974e456a70b86c14bfd1a9R1547

It might be this commit
https://github.com/elixir-lang/elixir/commit/5a583c753b96865a7cdec2fb4c1ab9c96b836d24

Same happend to NaiveDatetime, as it uses


Verify channels against server and reddit OAuth2 in constants on startup.

closes: #780
closes: #794
Adds new ConfigVerifier cog which now verifies if configured channels are present in server.
Checks if Reddit OAuth2 id and secret were set before attempting to load its cog.
1 unrelated commits included, https://github.com/python-discord/bot/pull/785/commits/6174792c01f238e32aca5cc9222caa4feb788281 for removing an unused function.

When going over the last commit I noticed this: https://github.com/python-discord/bot/blob/1ccc0f11fd4511d13c7cdf59070dca86465fe59f/bot/cogs/reddit.py#L43-L47
Is the comparison operator supposed to be checking the other way around?
Tokens auto expire and become unusable in an hour, and now the check only executes if the token's already expired (expired time before current) if I'm getting it right

@Numerlor Yes, I believe the operator in the datetime comparison should be flipped around i.e. revoke the token if it's still valid. Also realised there needs to be a None check for the access token as it's not guaranteed to have been created before the cog unloads.

@Numerlor Yes, I believe the operator in the datetime comparison should be flipped around i.e. revoke the token if it's still valid. Also realised there needs to be a None check for the access token as it's not guaranteed to have been created before the cog unloads.

Pushing a fix through, just made sure it's not intended. Already included a bool if check on the access_token in https://github.com/python-discord/bot/pull/785/commits/e8e2fa9ee8f607bb6593b7c8325446dc074a972d


Rfm::VERSION still not working

In v1.4.3, Rfm::VERSION is returning only the major component "1".

Rails 3.1.1 (and before?) changes the way string components are parsed. I've fixed the Rfm::VERSION issue in 1.4.4.pre2


Please publish new release 7.1.0

Hello,
There are a lot of improvements and bug-fixes since previous release.
As I can see, all of issues in 7.1.0 milestone are closed. Could you please publish new release?
Thank you!

Yeah, could we prioritize releasing 7.1.0?

Hi @oliemansm, is there a planned date for 7.1 release? Are there any further issues that need to be resolved before this release?

Traveling atm, will do a release this Sunday when I arrive.

Just released it


Lint, then build, then test

Make a couple of updates to the GitHub workflow that executes on pushes to pull requests and main:

Lint before building instead of afterward. Why? Typically when running checks, the lint step fails more often than the build step, and compiling TypeScript can take longer than linting especially on larger repos like this one. Switching around these steps in the workflow config means that a developer who has pushed changes to their pull request is now able to monitor the GitHub checks in real time more easily, because if there any linting violations with their latest changes, the developer will be able to see them more quickly.
Validate the changelog directly after the  linting step. As with the linting step, the changelog validation step is likely to fail, especially on a release branch, so again, the whole workflow should fail more quickly if there are any formatting issues.

It might also be useful to run lint, build, test in separate jobs if they don't depend on each other.

I'll merge this for now but I can submit another PR with all jobs running concurrently to see if it makes a difference. For reference, this one took ~2m40s on average (Yarn dependencies are already cached).


Item Submissions 30/08/19

7 from Akerus, 16 from Boaty, 13 from Schizopheonix, 3 from Reaper, 14 from ZeroHands2Feet

Also 1 from AscendantLegacy


Mangle file names with a specific meaning for go build

This includes all GOOS, GOARCH and "_test"

fixes #1596

ok done


[pulsar-io] Specify the database when getting the table definition

Fixes #15285
Motivation
Fix the problem of getting db1.tebble1 but getting db2.tebble1.
Modifications
Specify the current database when getting the table schema
Verifying this change

[ ] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] no-need-doc
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-added
(Docs have been already added)

Could you add some tests to verify it?

No problem, I will find some time to write this verification.

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.


DataGrid: Alternating rows

Add a way to add alternating row coloring in the DataGrid

@rsuter could you please tell me how i can disable this feature? For ordinary tables it makes perfect sense, but i really would like to have uniform colored rows in my app.
And how can i disable the highlighing of the selected row?
I tried both with DataGrid.RowStyle, but so far everything i tried either disabled all highlighting (i would like to keep the pointed-over hover effect) or crashed the app.


Get endpoints

Let's wait for core 0.11 and implement this using Pipeline.call

Dialyzer fails because of wrong typespec of Membrane.Pipeline.call/3.


Document search option in CLI / atomic_lib

The code for  #778 works, but it is not yet properly tested and documented.

@AlexMikhalev


pager should be active

Now, when you support the pager (I tested 0.9.1 and it works very well), I think so pager should be enabled by default.
\pset pager on

Note that psql has pager enabled by default.

@kenshaw recently enabled the pager by default if PAGER or USQL_PAGER are set to less or more: https://github.com/xo/usql/commit/e905f59621b6cc5aaef8840fad10585f6b8e4552
Shouldn't it be enabled when those vars are set to any valid binary that's in PATH?

I think so this check is not good. If you want to use pager, and the pager doesn't there, then I expect error message. Disabling pager in this case is hiding error, and it is not good idea, I think.

The PAGER variable should be set from the USQL_PAGER or PAGER environment variables now, and should be enabled as less by default if not defined now. If this is not working in the latest master commit as expected, please feel free to reopen this issue with more details and I'll look into it further.


Pod name retains random segments from Deployments

We noticed that %{pod} is meant to be the "friendly" name of an app, stripping out the randomized parts added by different controllers. A pod created by a Deployment on<EMAIL_ADDRESS>is named like this:
app-556455c97c-k8tdx

The plugin assumes the pod name has 2 random parts when the second to last part is a numeric string (is_number?(pod_parts[-2])). However, this has not been the case for several recent versions of Kubernetes.
ReplicaSets are named with a encoded version of the pod template hash, seemingly since<EMAIL_ADDRESS>Given our example above, there would be a ReplicaSet named app-556455c97c. Kubernetes is continuing to move forward in this direction and in a future release pod template hashes themselves will be encoded and no longer numeric.
We're still thinking about a better solution for stripping the dynamic parts with the metadata that the plugin receives but wanted to outline the problem in the mean time.

Just upgraded to 1.11 and also seeing this issue.

Sergei and I worked together on https://github.com/SumoLogic/fluentd-kubernetes-sumologic/pull/83 🙂
Kubernetes defines metadata.labels.pod-template-hash for pods so I think it would be ok to strip that out directly.

If anybody has a chance to take a look, #100 should address this issue.

fixed in v2.1.0


Sending web push fails on OTP 26

I noticed sending of push notifications were failing after I updated to Elixir 1.15.0 on OTP 26. My app is using HTTPoison for the HTTP client.
This is the error that was resulting:
{:error, %HTTPoison.Error{reason: {:options, :incompatible, [verify: :verify_peer, cacerts: :undefined]}, id: nil}}

I noticed that on OTP 25 I was getting this warning, even though web push was working:
[warning] Description: ~c"Server authenticity is not verified since certificate path validation is not enabled"
     Reason: ~c"The option {verify, verify_peer} and one of the options 'cacertfile' or 'cacerts' are required to enable this."

I suspect that a change in OTP 26 has meant that requests that cannot verify server authenticity now fail instead of just issuing a warning. I don't think it's Elixir 1.15 related as compiling my app on 1.15 with OTP 25 works fine.
I also came accross this thread that talks about that warning: https://elixirforum.com/t/warning-description-authenticity-is-not-established-by-certificate-path-validation/41588/4
It mentions to not override the SSL defaults as it clobbers the rest of the default configuration.
I feel this line could be responsible: https://github.com/danhper/elixir-web-push-encryption/blob/master/lib/web_push_encryption/push.ex#L66
Is there a reason it needs to specify the SSL version? I feel that removing it would fix the problem in OTP 26 but I currently don't have an easy way to test it as OTP 26 is not yet easily available for my system (MacOS).

Hi, very sorry for the delay.
I think that at the time I wrote this code, the default version was 1.1 and GCM wanted 1.2 or something like that.
It would be good if this could be tested before making changes though. Is there any chance you could try changing the version to 1.3 (even if it's in OTP 25, doesn't matter) and see if it works please?

https://github.com/midarrlabs/web-push-elixir
Hi, I've created a library that supports OTP 26 that is heavily inspired by your work @danhper thank you 🙏
Feel free to check it out and raise any issues you come across over there 😄


chore: Move some utility methods to submodules of scalar_funcs

Which issue does this PR close?
Rationale for this change
This is a follow-up as discussed in https://github.com/apache/datafusion-comet/pull/449#discussion_r1608635628
What changes are included in this PR?

hex_encode and wrap_digest_result_as_hex_string goes to hex submodule
spark_murmur3_hash and spark_xxhash64 goes to hash_expressions submodule
update benchmark and modify test code

How are these changes tested?
Existing tests with one slightly modification.

Merged. Thanks @advancedxy @kazuyukitanimura @tshauck @comphead


eddsa-poseidon should return numbers as bigint not string

Is your feature request related to a problem? Please describe.
All the functions in eddsa-poseidon return numeric values in stringified form, including bare string as well as Point<string> and Signature<string>.  In all cases, the values are bigint internally, and converted via toString() before return.
For a caller who wants to manipulate these numbers mathematically, this is a pessimization, since the caller will need to immediately parse the string back into a bigint.
Describe the solution you'd like
Change these functions to return bigint.  Callers who want a string can call toString() and pay the same cost they're already paying.  Callers who want a bigint save that cost.
Describe alternatives you've considered
Leaving it as-is is the primary alternative.  It would avoid a breaking change.  The annoyance and cost is relatively small, but now is probably a better time for a breaking change than in future when there will be more users of a more stable package.
Additional context
I'm willing to implement this change, but this would be a breaking change, so I'm submitting this issue to spark discussion before I submit a PR.  Attn: @cedoor.
I don't know what other users of this library exist who could be broken by this.  If they're passing the values to another zk-kit function which accepts multiple input types (like a BigNumberish) their code would keep working.  If they're converting to a number via BigInt() that will also keep working, since the extra conversion is a nop.  However if they're using the values in a way which requires a string, they'd need to add an explicit call to toString().

Hey @artwyman! I think this change is totally fine and it would be more consistent with baby-jubjub, which is already returning bigints.

but now is probably a better time for a breaking change than in future when there will be more users of a more stable package.

Yes, there aren't many projects using these libraries and they aren't stable yet. So this is the right time.
Feel free to open a PR 👍🏽


cmd/server: log on GET /ping if x-request-id is set

Codecov Report

Merging #27 into master will decrease coverage by 0.31%.
The diff coverage is 25%.

@@            Coverage Diff            @@
##           master     #27      +/-   ##
=========================================
- Coverage   43.42%   43.1%   -0.32%
=========================================
  Files           7       7
  Lines         456     457       +1
=========================================
- Hits          198     197       -1
- Misses        221     222       +1
- Partials       37      38       +1

Impacted Files
Coverage Δ

cmd/server/main.go
7.05% <25%> (-1.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fedc3...250f2e3. Read the comment docs.


Update hamburger style

Make's the hamburger prettier
added a deploy script to make deploying easier.
refactored links from both menus into one file.

:+1:


⚠ Bofrost.fr has degraded performance

In 90650b9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1338 ms

Resolved: Bofrost.fr performance has improved in 536771c after 11 minutes.


Interest in connecting with https://github.com/nafg/scalac-options ?

I wrote a thing that generates an API for scalac options by parsing the output of scalac -help etc.: https://github.com/nafg/scalac-options
Would there be any benefit, or is there any interest, in joining forces somehow?

This is really interesting @nafg as it presents the possibility of supporting all kinds of patch versions of Scala and prevents us from being to pass incorrect options!
I will look into how this might fit into the plugin.

Hi, any update?

Sorry @nafg I have been swamped on UK transit projects for ~18 months and I am just starting to emerge from the wreckage 😆
I've started a more detailed discussion about this in #49

But don't you think there would be any benefit to combining forces somehow?

Hi @nafg sorry for the long delay but this has just popped into my head again!
@satorg, @armanbilge and I have been investigating extracting sbt-tpolecat's logic into a library, and this reminded me of your efforts to generate a DSL for scalac-options.
@satorg has been working on some ideas in https://github.com/typelevel/scalac-options/pull/18 and I wondered if you have some thoughts too?

My thoughts are that the high level API can sit on top of the auto-generated low-level code

Would you (or anyone) like to have a voice or video chat?


adding a dark mode toggle button

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I like the idea. If you know any other Jekyll-based themes or websites that have this feature, could you add links? Thanks.

yes, as an example check this one: https://github.com/piharpi/jekyll-klise
It has a toggle button on top left

Created a pull request modifying code to add dark mode. Code was also modified to allow for easier changes to theme colors.

Sorry for the inconvenience, moved PR to a different branch : https://github.com/alshedivat/al-folio/pull/119


Add support for configuring prefetch capacity

This is a squashed cherry pick with a few changes removed
in order to just collect the changes related to prefetch capacity.
It is based on the following commits:
75f9d4eca8ec179564768c74b8c5cd67154ea1d8
5a221f2e8ad581b23e4b4b1ec86d3ee02e41e460
c89f3b2def16023bd08360705e923eeb73815013

Fixes #881


Flatten A Binary Tree

I have written a code to flatten a binary tree in C++. please check it out and merge it

@codenipun
Wohoo!! Congrats🥳 your PR has been merged.


App Info:Edit Wallet Name.

shouldnt need to confirm twice, we ask this only once during the wallet set up. this should also have text-lenght and character restrictions.

No change happened here.
It is still asking for confirmation twice and also there is no text-length and character restrictions.
Tested on dev app v2.0.7(394)

Verified this issue on dev app v2.0.7(395)

It is again asking for confirmation twice and also there is no text-length and character restrictions.
Tested on dev app v2.0.68(419)

Verified this issue on dev app v2.0.69(428)


fix: small error in docs

Coverage remained the same at 98.653% when pulling 89d5af09985a9afcf39fe7d2afa0e2dd8324e343 on 0xflotus:patch-1 into 67543f867a6e5e1cd49fb65e4b9c80f312942a55 on uber:master.

Thanks for noticing & fixing these!


[BEAM-10023] Don't add interactive extra for dependency check in python 2

Post-Commit Tests Status (on master branch)

Lang
SDK
Dataflow
Flink
Samza
Spark

Go

---

---

Java

Python

---

XLang
---
---

---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

R: @aaltay
CC: @KevinGG

Python failure is due to BEAM-10333, I'll go ahead and merge.


Option to force adding .js extension when importing from .ts files into .ts files

// foo.ts
export const foo = 'foo';
// index.ts
import { foo } from './foo';

Because of the infamous https://github.com/microsoft/TypeScript/issues/24779, if you want to use tsc to compile this code into ES modules that can run natively in node 14+, sorry you can't, because the import line lacks a .js extension.
As crazy as it sounds, the current consensus is to add the .js extension in the import line when you're writing the .ts file, like this:
// index.ts
import { foo } from './foo.js'; // add `.js`, even though the file does not exist

It works. But unfortunately auto-import won't do it for you.
So, can we add an option to force appending .js with auto import, even when writing .ts files?

You want TypeScript > Preferences: Import Module Specifier Ending: js

You're right. Thanks!


Update to v0.2

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.


Ubuntu 18 not working test

MSI GS63vr7rf.
during installation selected 'y'
all installed ok, but test not working.
$ sudo howdy test
Opening a window with a test feed
Press ctrl+C in this terminal to quit
Click on the image to enable or disable slow mode
QObject::moveToThread: Current thread (0x2d71ea0) is not the object's thread (0x2e03a20).
Cannot move to target thread (0x2d71ea0)
Segmentation fault

I've searched for similar issues already, and my issue has not been reported yet.
Linux distribution (if applicable): Ununtu 18
Howdy version: latest

Please use the search function before posting a new issue, this same issue (with a solution) has already been posted over at #54


[Windows] RunCommand with os/exec

Use "os/exec" to run commands on Windows host
Implemented NetRoute related methods to replace "github.com/rakelkar/gonetsh/netroute"

Signed-off-by: Zhecheng Li<EMAIL_ADDRESS>Fixed: #2364

Codecov Report

Merging #2363 (49bd518) into main (05eee25) will decrease coverage by 18.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2363       +/-   ##
===========================================
- Coverage   59.98%   41.66%   -18.33%
===========================================
  Files         281      144      -137
  Lines       21771    17813     -3958
===========================================
- Hits        13060     7422     -5638
- Misses       7315     9732     +2417
+ Partials     1396      659      -737

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/cniserver/pod_configuration_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/apis/controlplane/v1beta1/register.go
0.00% <0.00%> (-92.86%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-90.00%)
:arrow_down:

pkg/agent/nodeportlocal/k8s/annotations.go
0.00% <0.00%> (-83.88%)
:arrow_down:

pkg/agent/client.go
0.00% <0.00%> (-77.42%)
:arrow_down:

pkg/ovs/ovsconfig/ovs_client_linux.go
0.00% <0.00%> (-76.93%)
:arrow_down:

... and 230 more

/test-all

/test-windows-all

/test-windows-e2e /test-windows-conformance /test-windows-networkpolicy

I think we should merge this before we release 1.2 - this is a pretty serious issue as gonetsh causes deadlocks in clusters with Windows Nodes.
@tnqn I also think we should backport this to 0.13, 1.0 and 1.1. What do you think?

@lzhecheng could you link this to https://github.com/antrea-io/antrea/issues/2364? Thanks.

/test-windows-e2e /test-windows-conformance

/test-all

/test-windows-conformance

@antoninbas not yet but I will.

/test-all

/test-windows-e2e /test-windows-networkpolicy /test-e2e /test-conformance

/test-windows-networkpolicy

@antoninbas I tested on a 2 linux + 4 windows testbed. With following commands to check:
antctl proxy --agent-node <node name>
curl -L http://<IP_ADDRESS>:8001/debug/pprof/goroutine?debug=2

With TOT code, I can see that all windows nodes are hung when AddRoute:
goroutine 444 [semacquire, 10 minutes]:
sync.runtime_Semacquire(0xc00020f5b8)
        c:/go/src/runtime/sema.go:56 +0x49
sync.(*WaitGroup).Wait(0xc00020f5b0)
        c:/go/src/sync/waitgroup.go:130 +0x6b
github.com/antoninbas/go-powershell.(*shell).Execute(0xc0000a0380, 0xc000336070, 0x64, 0x3, 0x3, 0xc000336070, 0x64, 0x3f4c600, 0x0)
        C:/gopath/pkg/mod/github.com/antoninbas/go-powershell@v0.1.0/shell.go:64 +0x4d3
github.com/rakelkar/gonetsh/netroute.(*shell).runScript(...)
        C:/gopath/pkg/mod/github.com/rakelkar/gonetsh@v0.0.0-20210226024844-dfffed138500/netroute/netroute.go:146
github.com/rakelkar/gonetsh/netroute.(*shell).NewNetRoute(0xc000532130, 0x34, 0xc000a560f0, 0xc00020e5fc, 0x4, 0x4, 0x2, 0x2)
        C:/gopath/pkg/mod/github.com/rakelkar/gonetsh@v0.0.0-20210226024844-dfffed138500/netroute/netroute.go:90 +0x1a3
antrea.io/antrea/pkg/agent/route.(*Client).AddRoutes(0xc0000a03c0, 0xc000a560f0, 0xc00093bac0, 0xb, 0xc00020ea40, 0x10, 0x10, 0xc00020e5fc, 0x4, 0x4, ...)
        C:/antrea/pkg/agent/route/route_windows.go:144 +0x4c7
antrea.io/antrea/pkg/agent/controller/noderoute.(*Controller).addNodeRoute(0xc0005994a0, 0xc00093bac0, 0xb, 0xc0005ad5a0, 0x0, 0x0)
        C:/antrea/pkg/agent/controller/noderoute/node_route_controller.go:501 +0xb74
antrea.io/antrea/pkg/agent/controller/noderoute.(*Controller).syncNodeRoute(0xc0005994a0, 0xc00093bac0, 0xb, 0x0, 0x0)
        C:/antrea/pkg/agent/controller/noderoute/node_route_controller.go:372 +0x177
antrea.io/antrea/pkg/agent/controller/noderoute.(*Controller).processNextWorkItem(0xc0005994a0, 0x2030000)
        C:/antrea/pkg/agent/controller/noderoute/node_route_controller.go:337 +0x109
antrea.io/antrea/pkg/agent/controller/noderoute.(*Controller).worker(0xc0005994a0)
        C:/antrea/pkg/agent/controller/noderoute/node_route_controller.go:308 +0x32
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0xc00065e120)
        C:/gopath/pkg/mod/k8s.io/apimachinery@v0.21.0/pkg/util/wait/wait.go:155 +0x66
k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc00065e120, 0x2f2d580, 0xc000a56000, 0x1, 0xc0006176e0)
        C:/gopath/pkg/mod/k8s.io/apimachinery@v0.21.0/pkg/util/wait/wait.go:156 +0xad
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc00065e120, 0x3b9aca00, 0x0, 0xc000634201, 0xc0006176e0)
        C:/gopath/pkg/mod/k8s.io/apimachinery@v0.21.0/pkg/util/wait/wait.go:133 +0x9f
k8s.io/apimachinery/pkg/util/wait.Until(0xc00065e120, 0x3b9aca00, 0xc0006176e0)
        C:/gopath/pkg/mod/k8s.io/apimachinery@v0.21.0/pkg/util/wait/wait.go:90 +0x54
created by antrea.io/antrea/pkg/agent/controller/noderoute.(*Controller).Run
        C:/antrea/pkg/agent/controller/noderoute/node_route_controller.go:300 +0x269

Then tried again with this PR, I searched "semacquire" and found nothing. I think it is ok now.

@lzhecheng please backport to the 0.13, 1.0 and 1.1 release branches: https://github.com/antrea-io/antrea/blob/main/docs/contributors/cherry-picks.md

I think we should merge this before we release 1.2 - this is a pretty serious issue as gonetsh causes deadlocks in clusters with Windows Nodes.
@tnqn I also think we should backport this to 0.13, 1.0 and 1.1. What do you think?

Sorry for the late reply. Yes, I think it should be backported as it affects basic functionality.


Add an option to clear cache

Summary:
We should add an option to clear the cache in the settings of the app.
It not only helps you free up space but also sometimes when there is a software update the app behaves oddly, luckily clearing the cache helps most of the time.
It is easier for some phones running stock android to clear the cache by quickly going to the system settings, but not for all Android Launchers and for a non-tech person it is difficult.
Many apps follow this for example Spotify.

Would you like to work on the issue?
Yes

It is easier for some phones running stock android to clear the cache by quickly going to the system settings, but not for all Android Launchers and for a non-tech person it is difficult.

I'm not sure what you mean when you say it would difficult for some android launchers. But your other point sounds contradictory to me. For me a "non-tech" person wouldn't know about caching at all. If they do, they would as well know that there would be an option to clear for each app in the device's settings. This could just be me, though 🙂

Many apps follow this for example Spotify.

Of all the apps I've used, the only ones that provide the option to clear the cache in their app's settings are Spotify and Pocket. Both have a valid reason to do so. One of their primary things is handling cached, offline content. I don't think the Commons app has similar goals.

It not only helps you free up space but also sometimes when there is a software update the app behaves oddly, luckily clearing the cache helps most of the time.

That's interesting. I've not faced the "weird behaviour that goes away on clearing the cache". Can you describe what issues you've faced? Ideally you shouldn't have faced the odd behaviour you describe. So, fixing those issue would be something worth pursuing.

I'm not sure what you mean when you say it would difficult for some android launchers. But your other point sounds contradictory to me. For me a "non-tech" person wouldn't know about caching at all. If they do, they would as well know that there would be an option to clear for each app in the device's settings. This could just be me, though 🙂

I mean some launchers I used before don't give you 2 step process to clear an app's cache as stock android os do. It is tricky to find this option, I can only say this about the launchers I used before.

Of all the apps I've used, the only ones that provide the option to clear the cache in their app's settings are Spotify and Pocket. Both have a valid reason to do so. One of their primary things is handling cached, offline content. I don't think the Commons app has similar goals.

I agree Commons app don't have goals to be an offline-focused app but we still cache a lot of media to the phone, for instance when you open the app for the first time we cache all the media from user's contributions in high resolution, this can be verified by comparing the size of the cache before log in and after first time login.

That's interesting. I've not faced the "weird behaviour that goes away on clearing the cache". Can you describe what issues you've faced? Ideally you shouldn't have faced the odd behaviour you describe. So, fixing those issue would be something worth pursuing.

I was trying to set a media as wallpaper but it was not working for the one which has cached copy, I cleared the cache and it worked!

Hi @madhurgupta10 , thanks for the suggestion. Given that the option is already present in the Android system, and it isn't something that the average non-technical user would use often anyway (unlike, say, logout), I'm personally not sure it's worth adding the complexity to our app. Do bear in mind that all features that are added need to be maintained (bugs/crashes fixed, compatibility with all future features that are added, etc), so there has to be a really good reason to add a feature.

@misaochan I agree maybe in the future. But, for now, we can skip working on this feature.

I guess we can close this task for now and reopen it when the need arises. :)

I see there already a consensus here. I just wanted to add a few comments.

I mean some launchers I used before don't give you 2 step process to clear an app's cache as stock android os do.

Yeah, but clearing the cache of a specific app is not something you should be doing often. As I've noted before, that just indicates that something is wrong with app's handling of the cache. We should be identifying and fixing the mishandling rather than providing a way to work around it. 🙂
That said, there's one valid case where clearing the cache would be valid thing to do: to make some space. But even in that case the person is more likely to clear the cache of all the apps via the Storage settings of the device rather than clearing the cache for an individual app.

It is tricky to find this option, I can only say this about the launchers I used before.

Personally, I've never found it hard to go through Settings > Applications > Choose your app > Clear cache (or) Settings > Storage > Clear cache. 😉 Of course, I can only speak for the devices I've used. I'm not sure if some devices make this flow hard.

I was trying to set a media as wallpaper but it was not working for the one which has cached copy, I cleared the cache and it worked!

If you're sure that it wasn't a coincidence that clearing the cache made it work, kindly open an issue.

Do bear in mind that all features that are added need to be maintained (bugs/crashes fixed, compatibility with all future features that are added, etc), so there has to be a really good reason to add a feature.

That's one thing I had in mind too when I was thinking if it was worth including the feature now. I'm curious about why I never mentioned it #SelfAnalysis 🤔


Feedback banner

Before:

After:

Summary by CodeRabbit

New Features

Enhanced the PrevNextNavigationWrapper component with a new layout that includes an engaging image and clearer prompts for user feedback.
Updated call-to-action text to encourage user interaction regarding their developer experience with ZetaChain.

UI Improvements

Replaced the previous grid layout with a streamlined flexbox design to improve visual presentation.

@zeta-chain/fullstack please, review.


require('someFile.JSON') is caching on iOS

A require against a JSON file should not be cached; the file can be changed by other means; and if I use a require to make my life simpler, I expect the current data to be retrieved....
Please note, this is also inconsistent with the Android engine which is NOT caching it (the proper behavior).

Hey, @NathanaelA,
Thanks for reporting this inconsistency. Before we can discuss it, can you confirm that we are talking about the following use case or can you give another example of it:
var object = require('./test.json');
console.log(object["test-prop"]); // Android: "test-value"; iOS: "test-value"; Node: "test-value"

object["test-prop"] = "new-value";

var object = require('./test.json');
console.log(object["test-prop"]); // Android: "test-value"; iOS: "new-value"; Node: "new-value"

Where test.json is a file containing the simple object: {  "test-prop": "test-value" }.
Ping @NativeScript/android-runtime

Hi @NathanaelA
Again, thanks for reporting this inconsistency. It seems this is a regression in Android bridge. I fixed it and added a common iOS/Andorid unit test in order to prevent future regressions. The fix is already pushed in master and release branches.
As a side note, I would like to point that while current CommonJS spec doesn't explicitly discuss loading JSON files it does discuss that modules should be cached. The Node.js implementation also caches required JSON files. I cannot comment whether this behavior is useful but at least it is expected for the majority of the community. I guess it's fine to require small JSON files, especially if they are treated as read-only data.

@slavchev & @jasssonpet  - Ack; I don't want them to be cached!  That was my complaint that iOS caches it...   ;-(
// Original Data: {"someData": "NS Rocks"};
var data = require('some.json');
console.log(data.someData);  // outputs "NS Rocks"  <-- CORRECT

// manually change the some.json file using FS.writeText so the JSON file now says
// {"someData": "NS is cool"} on disk
var data = require('some.json');
console.log(data.someData);  // outputs "NS Rocks" <-- WRONG

I can manually load the file; and then JSON.parse it, but using Require is so much simpler.  ;-)

@NathanaelA If I understand the issue correctly you are looking for a convenient one-liner to load JSON files. If so then we can collaborate around such feature and keep require functionality aligned with the specs and the common expectation.

@slavchev It isn't a big issue for me; using readtext and json parse is extremely simple.    I have to admit it caching json seems like really backwards behavior...   Which is why I complained to THIS repo about it caching it and not to the android one where it was behaving "properly" in my opinion.   But if you guys prefer the caching behavior it is fine.   I just think it is unexpected behavior.  :-)
Oh and just because node does something wrong, doesn't mean you have to do something wrong -- if I load a really large json file; you realize because you are caching it; and you are then wasting lots of memory for no good reason, on a mobile device!


keytar brings in a lot of files in the build

I'm looking into reducing the number of files in our server build.
Turns out that keytar brings in a lot of file because the use of prebuild-install in the install script.
Because of that prebuild-install is a dependency (not just a dev dependency) and prebuild-install and all it's dependencies end up in the bits we ship (tar-fs, tar-stream, readable-stream....).
It's not easy to remove all these unnecessary from the build. We have a hand curated filter (https://github.com/microsoft/vscode/blob/main/build/.moduleignore) but that's cumbersome and might change after an update.

tar-fs/etc. isn't me, seems to be a node module that keytar depends on: https://www.npmjs.com/package/tar-fs.

I think we need to solve this in our build scripts. In https://github.com/microsoft/vscode/blob/b0cbac3f939329d4074b709058aae05a553089dd/build/lib/dependencies.ts#L60 we compute the tree of dependencies. There we could remove the keytar dependencies (along with all it's subdependencies) as we know they are not needed at runtime).
I want to look at implementing this, unless there are better ideas. @joaomoreno ?

prebuild-install is a production dependency. It needs to be, since npm doesn't have the notion of installation-time dependencies. Unfortunately, it brings many other things: https://www.npmjs.com/package/prebuild-install?activeTab=dependencies

There we could remove the keytar dependencies (along with all it's subdependencies) as we know they are not needed at runtime.

I'm not sure you'll find success here since dependencies might be shared with another one of our dependencies, due to deduplication.
Given that keytar doesn't have any dependencies other than installation-time dependencies, we can take the approach of installing keytar on an isolated location, and then just copying the keytar folder to our node_modules, excluding everything in keytar/node_modules. This also has the risk of breaking as soon as keytar depends on something, but feels like a smaller risk to me.
Another approach: fork keytar into a version which ships all prebuilt binaries variants at install time and have a postinstall step to delete all which do not apply to the desired os/arch.

Those both seem like decent options. The former seems easier...
@deepak1556 do you have any advice here?
Also is there something I could ask the keytar folks to do that would make this easier?

Agree with @joaomoreno on the available solutions, sqlite3 native dependency also has the same issue and we took the second approach with a slight variant https://github.com/microsoft/vscode-node-sqlite3/commit/59a82b27af26664474acf0fc1ea7fb9698a7df31. We simply do not rely on the prebuilt binaries in the fork, since essentially we want to ship native modules for both our client and server compiled with the toolchain we have customized for our CI based on the electron and node versions, prebuild is unnecessary in these cases.
I don't think the upstream keytar can make things easier for us, since prebuild-install cannot be made optional. The issue we are facing is specific to how we bundle and ship these modules, so I would align with a fork and control what we want to ship.

@deepak1556 do you think we could meet and go over the approach with vscode-node-sqlite3 and how I could do the same for keytar? I like the idea of following that pattern and I'm curious to know how we publish vscode-node-sqlite3

I don't think the upstream keytar can make things easier for us, since prebuild-install cannot be made optional

Came across the same issue using this package in a VS Code extension, recommend supporting keytar moving to using prebuildify
https://github.com/atom/node-keytar/issues/255

Looks like my issue should be marked as a dupe :) https://github.com/atom/node-keytar/issues/462
@thegecko btw, I noticed you mentioned bringing in keytar for a vscode extension... you actually don't need to bundle keytar in your extension because we shim keytar so that you use the keytar that ships in vscode.
In your code, you can use keytar as you do today (importing it as normal), but you don't need to bundle it (and it's deps) with your extension.

In your code, you can use keytar as you do today (importing it as normal), but you don't need to bundle it (and it's deps) with your extension.

That's awesome! is it easy to discover other packages which can be leveraged in this way? Especially native ones.

@thegecko that comes from here:
https://github.com/microsoft/vscode/blob/3268d1d47d1ae902bc1ec45bd2153fdacab66ff6/src/vs/workbench/api/common/extHostRequireInterceptor.ts#L36
It's really just keytar, the vscode module itself, obviously, and the open/opn module.
Keytar behaves this way so that you have consistency if your extension is actually running on a remote. You get the value stored on the client side (the side with an actual keychain).


Whether there are configurable parameters to disable the client reconnection mechanism？

I don't think that can be done out of the box.

Hi,
Just to be clear, you are trying to disable all connection retries? Even
in case of multiple servers?
Or do you mean, regardless of the number of participants in the ensemble,
after a successful connection (you have a session Id), from then on if
you get disconnected (lose the session), do not retry?
The former is too low level, kazoo tries to abstract the individual members
of the ensemble as much as possible and instead focuses on the session
abstraction. For instance you can easily setup a state watcher that will
react on session loss.
I hope this helps
On Fri, Mar 8, 2024, 15:13 Stephen Sorriaux @.***>
wrote:

I don't think that can be done out of the box.
—
Reply to this email directly, view it on GitHub
https://github.com/python-zk/kazoo/issues/667#issuecomment-1986355531,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIFTHV4BLHTTPADT6T4OYLYXILWNAVCNFSM5WZ3TEN2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJYGYZTKNJVGMYQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Please add GitHub webhook to support CWL integration tests

https://github.com/BD2KGenomics/toil/settings/hooks/new
"Payload URL" https://ci.commonwl.org/github-webhook/
"Content type" application/x-www-form-urlencoded
"Which events would you like to trigger this webhook?" Just the push event.
I would do it myself, but I don't have permission. Thanks!

This is done. Let me know if it doesn't work.

@hannes-ucsc It is working great; and the build is now passing. Thanks!

Feel free to use this CWL conformance badge: http://ci.commonwl.org/job/toil-conformance/badge/


[feature] Putting code selection directly into handlebars output

🧩 Feature
Removing the HTML script tag from the handlebars output and inserting direct code snippets
Description

My use case for this tool is to try and copy the HTML from the Handlebars generated report, and insert it into an HTML comments box to give formatted feedback to students. However, this comments box does not support script tags in them (to be fair, for good reason), and so I wanted to see the feasibility of trying to re-place the functionality in the


Publish the "cdn" manipulated files into a publishing/ directory in master

This will make it more transparent what's happening as well. the publishing directory could be used to manually copy and paste files down from it to the root if desired.

#148 resolves the need for this


Add chart name check to lint

I run into an issue with a chart which contained a dot in the name. Thought it would be nice to get this reported when performing a lint.

ping @mattfarina @prydonius @unguiculus

/remove-lifecycle stale

test failure: https://circleci.com/gh/kubernetes/helm/6048

@bacongobbler Hope it's fine now :)


NAS-123591 / 24.04 / Fix progress reporting

time 0:20

Jira URL: https://ixsystems.atlassian.net/browse/NAS-123591

time 0:20

time 0:20


pull request for e2e test at 12/13/2016 15:15:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Enable CI & add build status

Enable Travis CI for project to make sure we didn't break the build :)

I'm on it 😃
I'll start on my fork at lunch today 🚀

Cool. Seem done? @Ekt0s

Yep @itchix has done the changes based on my fork.
Don't if it's gonna work for the pull request though

It builds on master, should be okay!
I'll close the ticket in that case. Thank you both @Ekt0s @itchix 👍


.NET Interactive's Open Notebook palette command opens notebooks as plain text

Looks like this palette command calls a vscode workbench command directly, which bypasses our existing notebook logic. Note that opening a file from File -> Open still works as expected.

Closing issue since this command is removed in the latest version of the extension.


Add checkpoint_comm_enabled flag

Optional disable communication collectives inside load/save checkpoint via a new top-level json parameter:
checkpoint_comm_enabled: [true|false]
This option is not tested with zero-3 or moe, it might work okay but wanted to be on the safe side adding asserts in these cases. We can test these paths if/when someone needs this option with those features.
New zero json parameter: move_params_to_cpu_during_init: [true|false]. Setting this to false will skip the move_to_cpu(self.bit16_groups[i]) call inside zero 1/2 initialization. In the context of Big Science this might help them to reduce cpu memory usage when CPU memory is smaller than GPU memory per node.
/cc @stas00

Can one of the admins verify this patch?


BUG - scrolling interrupted

Related Feature
Feature request: scrolling in result list of Guided Answers extension
Description
When scrolling through the result list of guides in Guided Answers extension, the scrolling is disrupted by loading animation (not smooth). This behavior started after merging https://github.com/SAP/guided-answers-extension/pull/414.
Steps to Reproduce
Steps to reproduce the behavior:

Open latest version of Guided Answers extension (from https://github.com/SAP/guided-answers-extension/releases)
Search for a generic term like SAP that has many results
Scroll down

Expected results
Smooth scrolling
Actual results
Interrupted scrolling
Screenshots

Version/Components/Environment
Add any other context about the problem here
OS:

[x] Mac OS
[ ] Windows
[ ] Other

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

Fixed with https://github.com/SAP/guided-answers-extension/pull/422


Casting from byte array to Struct

It took me a while to figure out how to take a byte array and cast it to a C struct for the purposes of implementing a binary protocol.
This is what I've got so far, but it feels like there's a nicer way somewhere:
lib C
  @[Packed]
  struct Message
    msg_size : UInt16
    descriptor : UInt16
    source : UInt32
    target : UInt8[8]
    site : UInt8[6]
    options : UInt8
    sequence : UInt8
    at_time : UInt64
    type_id : UInt16
    _reserved : UInt16
  end
end

def decode(data)
  ptr = Pointer(UInt8).malloc(36)
  data.each_with_index do |v, i|
    ptr[i] = v
  end
  msg_ptr = ptr as C::Message*
  msg_ptr.value
end

data = [0x25, 0x00, 0x00, 0x34, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0xcb, 0x00, 0x00, 0x00, 0x01].map { |i| i.to_u8 }
p decode(data) #=> C::Message(@msg_size=37, @descriptor=13312, @source=0, @target=[0, 0, 0, 0, 0, 0, 0, 0], @site=[0, 0, 0, 0, 0, 0], @options=0, @sequence=0, @at_time=0, @type_id=203, @_reserved=0)

Issues I ran into along the way:

(resolved) Can't do [0x25, ...] as UInt8 because 0x25 is still treated as a Int32
I naively assumed pointerof(Array(UInt8)) would give a raw byte array

Is there a better way to do this?

You can do data = UInt8[0x25, ...] and you'll have an array of UInt8.

Oh cool, that helps. Thanks!

Also in decode I think you could cast data's buffer directly instead of allocating more memory:
(data.buffer as C::Message*).value

Awesome, I didn't know about buffer. That's pretty much all I need I think, thanks! Closing.


snapshot: apply delta encoding for better compression rate

Snapshot is always created and processed in order, taking advantage of that, we can apply delta encodings to some fields:

version
IAVL tree has the nice property that parent node's version is always bigger than or equal to children's version, and in snapshot, nodes are added in post-order, where parent node is put after children nodes, so we can only record the delta value, to be specific parent version - max(left version, right version), smaller value results in smaller encoded size with varint encoding.
key
After the #688 improvement, we only have leaf keys in snapshot, they are ordered, so delta encoding can also potentially have some good compression rate there.
height
since IAVL tree has the invariant that parent height = max(left height, right height) + 1, I think we don't need to encode the height field at all in the snapshot.

The version and height compression rely on the fact that nodes are exported in post-order. the key compression only need the leaf nodes are exported in order.

Some thoughts about snapshot format migration:

the IAVL library always support all the legacy versions, add a format parameter to import/export methods, so it's always a non-breaking change to introduce a new format in IAVL library.
add a new api to return all the supported formats in current version.
let cosmos-sdk to handle the versioning of the snapshot, it can check the snapshot format against supporting list, and can have a new config option to specify which format to export.


Mac app instantly closing

Doesn't matter if its 2.6.6, 2.6.7 or 2.6.8. Feather only opens on first launch since install, after that when you are trying to open it - handles for a sec in the Dock and closes without even showing a window. Tried installing a x86 app via Rosetta - same behavior. Nothing helps. System is up to date. Thought that it might have something related to Qt but the latest version is installed as per brew versions.
Didn't have this problem before on the same version, started after OS reinstall. Macbook M3

What version of macOS are you running?

What version of macOS are you running?

Mac Sonoma 14.5
Started to issue on earlier version but can't remember the number. Update didn't help.

I faced the same issue. It was working just fine and this happened. I didn't upgrade or make any changes. The app just crashed and wouldn't open after.

i have same issue on windows version, some times it's happens
2.6.7 version

works randomly, latest (2.6.8) on 15.0 (24A335) Sequoia

This will be fixed in an upcoming release. Should be out later this week.

It opens, when I open it from the downloads folder, but as soon as I copy it to the Applications folder, it will not start.

This should be fixed now in the latest release.


Opening link in new tab prevents modal from closing after single click on overlay

Summary:
If modal content has a link inside, and this link is opened in new tab, the modal enters a state where it requires a click anywhere before it can be closed by clicking on its overlay.
Steps to reproduce:

Place a link inside modal.
Open this link in new tab (either via the context menu or by middle mouse button).
Now the modal can't be closed by clicking on its overlay without clicking anywhere first.

Expected behavior:
A modal should always close after a single click on its overlay.
Link to example of issue:
https://codesandbox.io/s/jolly-water-e59ej
Additional notes:
The issue is reproducible in Chrome 97.
As far as I can tell, the issue boils down to this. It looks like handleOverlayOnClick is expected to always be called after handleContentOnMouseDown, handleContentOnClick, or handleContentOnMouseUp, but it's not the case, because there are ways to trigger mousedown without triggering click. Opening link in new tab is just one of them.

I am curious, does this seem to ever work?
Because I think this might be the correct behavior, but I maybe wrong.


Agent must use async-await interface

The client should implement Python async-await protocol in all of its functions

@Mec-iS please elaborate

Agent should implement wherever possible Python generators and asynchronous co-routines both for calling the servers ([asyncio](asyncio is a library to write concurrent code using the async/await syntax.)) and updating the graph in Redis (possibility of using Streams).
Heracles.ts implements asynchronous behaviour in Typescript (example).


defaultValue gives null for Boolean

When using false as defaultValue, the default value is null instead of false.
I have another preference which is of type string and it works properly for that preference.
Using: localStorage

Also, i noticed that the preferences are not consistent. They are properly saved in the localStorage but sometimes they are not reflected in the UI. The user needs to refresh the page in order to see the updated preference.

Hi @TheAndroidGuy, thank four reporting the issue 😄! And sorry for the delay

I was just able to see look into this, regarding the first comment I think I know what the issue is. I will do a bit more research and see if it easy to fix.
Regarding your second comment  can you provide an example where that happens? Or is that an intermittent thing? Please provide the version you are using


rename module to enable 'go install', update readme

Hi,
the PR is a proposal to address:
go install github.com/malisetti/rmbin@latest
go: downloading github.com/malisetti/rmbin v0.0.2
go: github.com/malisetti/rmbin@latest: <EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: rmbin
	        but was required as: github.com/malisetti/rmbin

thanks for the PR 👍


ConnectionOptions should follow the normal pattern for options being passed into a new class

Describe the bug
The ConnectionOptions class is created and passed into the operator. The expected pattern to be used is by using a function to set the options from within the consuming class.
Expected behaviour
The expected pattern should look like this:
BackupOperator backupOperator = new();

backupOperator.BackupDatabase(options =>
  {
    options.ConnectionString = @"server=MyComputer\SQLDEV;database=TestDatabase;Integrated Security=SSPI;Connect Timeout=5;";
    options.BackupPath = @"E:\Database\Backups\";
  });

Additional context
The backup path and the execution timeout have default values, so can be supplied or not as the consuming application chooses.
Breaking Change
This pattern will be a breaking change for the library. This pattern is also used mainly for options that have full default values. This library requires the connection string.
Questions
As the connection string must be supplied, should this pattern be implemented?

I think I also need to split out the connection string options from the backup path options.
The execution timeout will be required for backup and restore operators.

I have taken this idea from the excellent Nick Chapsas.
See his YouTube video at the link: https://www.youtube.com/watch?v=kIkbGXLkc-g

I'm going to update the readme to use a more friendly welcome to other contributors.

I've updated the wiki now, so this can be closed.


Property "$device" was accessed during render but is not defined on instance.

Migrating from Nuxt2 to Nuxt3 and receiving the following errors:
[Vue warn]: Property "$device" was accessed during render but is not defined on instance.
[nitro] [dev] [unhandledRejection] TypeError: Cannot read properties of undefined (reading 'isMobileOrTablet')

component:

      <TouchGallery v-if="$device.isMobileOrTablet" />
      <DesktopGallery v-else />

</template>

Any ideas on what might be going on here?

This turned out to be an issue with nuxt.config.ts


fix: race condition when editing folder/website retrieval config

Description
fixes https://github.com/dust-tt/tasks/issues/735
Will need to be aligned so that all actions use this pattern (although not an actual problem in production since we don't call onSave in a loop).
Risk

Deploy Plan

@fontanierh can you explain the problem and the fix a bit more :grimacing: :pray:


Contact form not properly working with ID based Formspree form

Hey there,
I am using this for my homepage and wanted to configure the contact form.
I created a form with Formspree and wanted to use ID-based forms.

When I add my f/<form_id> as formspree_form_path in _config.yml, the contact form still uses the configured email instead of ID.
I tried to work around this by configuring the Formspree ID as my email in _config.yml. Now it uses the correct action URL and I receive the messages via Formspree. However, the user still gets the error message _Sorry , it seems that my mail server is not responding. Please try again later! _ .

Am I doing something wrong? I'd be happy to submit a pull request if I know what to look for.
Thanks.
Best regards
Ralph

Good catch! Looks like I forgot to add the formspree_form_path: "f/a_form_id" to this repo's config.yml.

If you add formspree_form_path: "f/a_form_id" to your config.yml everything should work as expected.

Hi, thanks for the quick reply.
However, as I mentioned in the original post, I have formspree_form_path configured (there was a template for it in my _config.yml that I just needed to uncomment).
Unfortunately, it still doesn't properly work.
If I comment out email and only provide a formspree_form_path, the contact form uses action="https://formspree.io/" and fails to insert the formspree id.
Any thoughts?

Oh I see, that's odd. Everything works as intended for me when I test it. Can you make sure you are using the correct form ID, and that everything is up to date? Run bundle update and test your form locally. If it works locally but doesn't work when published, you can narrow down the cause of the issue.

Closing stale issue, feel free to reopen with an update


Set initial dates to commits

It's not finished, the property from the form won't get passed on to the migration function.
Closes #22050

@CodeDoctorDE Will you continue working on this PR?

Sorry, I don't think so. I'm very busy right now

I'll close it, feel free to reopen if you want to work on it again


Added note about Availability Zone (AZ) support

Added note about Availability Zone (AZ) support

@stefsch : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


introduce binary operators for aggregation

Allow to aggregate binary data using binary operations like and (all merged features have to
be true for the merged feature to be true) or or (some merged feature has to be true for the
merged feature to be true).

My guess is that no one at Mapbox will see this PR, but if you remake it to https://github.com/felt/tippecanoe I will accept it in the maintained version of Tippecanoe there.

Thanks for the hint.  I opened https://github.com/felt/tippecanoe/pull/152 over there.


Add workflow for running tests on PR

Add a github action for running tests on new PRs and commits.

Marking as a draft while working getting it to work.


Make After-Drawing Menu Interactive

Allow the user to continue drawing, draw on a fresh canvas, or to create a new scribe. Quit functionality already works!

Summon case seems to have issue with recursion- trying putting prompt in different locations to remedy the problem.


Add Calltospeakers.com RSS feed to importers

https://calltospeakers.com

Site is no longer active.


[Bug]Trying again after eth_getLogs RPC call timed out

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I m running the subgraph (basically its uniswap subgraph fork on bsc), its been 2 weeks running fine but I just got this error:
Unexpected RPC error, error: Timeout elapsed, component: BlockStream
```Trying again after eth_getLogs RPC call timed out (attempt #7), component:``

@leoyvens - this looks like the same timeout issue we saw with BSC previously. I am wondering if we should increase the timeout again?

Possibly, but it should be noted that the timeout is currently at over 15 minutes. Can you provide the sugraph link and hash?


Replace the gem to nprogress-rails from pace-rails

Coverage remained the same at 94.36% when pulling 995e8cb9b8816a6661d54793c4e65781d9a79838 on replace-the-gem-to-nprogress-from-pace into 764455a84cc3e31db6acbb797bb301c3f7746b87 on master.


Create view 'annotation' (currently called medicationWithGuidelines)

Wont fix because we're in too deep


Update readme

Ugh, need to take out the other commit first.

Yeh,

I've sorted it anyway now.

Yeh but pr closed? :p I'm confused

Your PR contained extra changes so I just made the tiny fix myself to the readme.

K


Fix missing poll_interval_ms

This pull request also fixes the problems with lxml & Python 3.4 (by setting the version to an older release which supports 3.4) and flake8 & nightly Python (by using a newer version of flake8 & resolving the found linting problems).

don't know why I didn't merge this pull request earlier, looks nice


update

Update intended to give more clarity and simplicity to the use of words.

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@LucidSamuel Thanks so much for opening a PR! I'll get this triaged for review :zap:


Blur event not working

Hi,
Is there anyway to have a blur event while using the mwlDraggable? I have a input using both mwlDraggable and mwlResizable, if i have only the mwlResizable the blur event works, but when i have mwlDraggable it does not.
Thanks

This will be fixed in 2.0 by the behaviour change that only prevents default on the element if its actually dragged. Thanks for reporting! 😄


chore: persist data in test until after migrations are complete

closing in favour of a new PR which splits the postUprade / preUpgrade jobs into two separate jobs instead of one with conditionals to avoid confusion/errors if or when we need to add new post/pre upgrade functionality.


Silence warnings on building TBB with g++ 9+

Summary
Fixes #1992  by adding -Wno-missing-attributes to CXXFLAGS
Tests
/
Side Effects
/
Release notes
Added -Wno-missing-attributes to CXXFLAGS.
Checklist

[x] Math issue #1992

[x] Copyright holder: Rok Češnovar
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

This is ready for review.

Should we silence these warnings in math or should they be something we are aware of and upstream repos handle warnings? I'm fine either way, but worry nulling them out here could cause us to not see other warnings like them in the future

but worry nulling them out here could cause us to not see other warnings like them in the future

That is reasonable yes. Counterpoint is that I would expect that if I use a library compiling its dependencies would not produce warnings.
Anyhow, this discussion is probably irrelevant as I found that this doesn't completely fix it, as we build the TBB with their makefiles. So for the case of TBB we have to do it in Math, other repos do not access the TBB makefiles.

I added the flags to the TBB makefiles. There are no more warnings now. Just not sure if this is the right place to put them. As in, are there better ones.
@wds15 where is the best place to put makefile flags for the TBB building? I put them in common.inc and marked the change for future reference.

@rok-cesnovar, unfortunately, that failed when building ./runTests.py -j16 test/unit/math/opencl --make-only  on Jenkins.

I'm guessing those options aren't available for that version of clang++?

Thanks. Seems that we need to restrict it to the gcc type.

The logic is now:
ifeq (gcc,$(CC))
WARNING_SUPPRESS = -Wno-missing-attributes -Wno-class-memaccess -Wno-sized-deallocation
else
WARNING_SUPPRESS = -Wno-deprecated-copy
endif

Hmm... looking at the TBB makefiles, they seem to use the
CPLUS_FLAGS
variable for C++ options. So maybe define that here:
https://github.com/stan-dev/math/blob/6c4fff7d8bfe602e9996a99b3fe99beba79243dd/make/libraries#L145
should that work, then you won't need to modify the TBB sources.

Thanks. That would be the preferred way yes.

Refactored again, this only touches Math makefiles now, which is much cleaner.

@syclik ready for another look. I had to include a few fixes as develop broke after the merge of #1965 The problem was that the PR was not in sync with develop. It passed tests a while back but develop had a few larger changes after the tests last ran. If you want me to separate that in another PR, let me know.


VS2013 RC4, TypeScript 1.4, NTVS 1.0RC2: pasting a function mutilates its comment

Not sure if this should be reported here, please let me know.
Pasting the following text in a TypeScript file
        /**
	 * Try to get resources to write some of the to-be-done archives to the database
	 */
	private _doSomeWriting(): Promise<void> {
        }

consistently yields
	/**
		 ry to get resources to write some of the to-be-done archives to the database

	private _doSomeWriting(): Promise<void> {
	}

i.e. the top comment is mutilated. Pressing Ctrl+Z once solves it.

Is that in an empty file? or did the file has something else? do you get this re-produce consistently?

I cannot reproduce it but symptoms look very suspicious as you describe it - formatting should never took away anything but whitespaces. Do you have anything else in this file?

Yeah i did have other things in the file. Tomorrow at work I can see if I
can reproduce it and I'll give you a full file.
On Jan 21, 2015 7:18 PM, "Vladimir Matveev"<EMAIL_ADDRESS>wrote:

I cannot reproduce it but symptoms look very suspicious as you describe it

formatting should never took away anything but whitespaces. Do you have
anything else in this file?

—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/1756#issuecomment-70891166
.

Also, you need to have all the "Format on XXX" checkboxes checked under
Tools - Options - Text Editor - Typescript somewhere
On Jan 21, 2015 7:18 PM, "Vladimir Matveev"<EMAIL_ADDRESS>wrote:

I cannot reproduce it but symptoms look very suspicious as you describe it

formatting should never took away anything but whitespaces. Do you have
anything else in this file?

—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/1756#issuecomment-70891166
.

I've tried several times now but I can't reproduce it anymore. I was doing some heavy  refactoring and  experienced the issue in multiple files before. If I see it again I'll send the whole file.

Will close this issue then. Feel free to log a new one if you see it again and can't reopen this.


xSQLServer: Updated year to 2017 in license file

Updated year to 2017 in license file (issue #711).
Pull Request (PR) description

Changes to xSQLServer

Updated year to 2017 in license file (issue #711).

This Pull Request (PR) fixes the following issues:
Fixes #711
Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Codecov Report

Merging #712 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #712   +/-   ##
===================================
  Coverage    97%    97%
===================================
  Files        30     30
  Lines      3250   3250
===================================
  Hits       3165   3165
  Misses       85     85

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable