ResNet18 18x slower than TensorRT on RTX 4000

What happened?
I benchmarked a ResNet18 model on GPU RTX4000 with both IREE and TensorRT, and it turns out TRT takes 1ms but IREE takes 18ms.
IREE

TRT

Steps to reproduce your issue

benchmark IREE with this script

import torch

import os
import io
import numpy as np
import time

import torch_mlir
import iree.compiler as ireec
import iree.runtime as ireert

# os.environ["IREE_SAVE_TEMPS"] = "./"

FP16 = False

model = torch.hub.load('pytorch/vision:v0.10.0', 'resnet18', pretrained=True)
model.eval()

# Download an example image from the pytorch website
import urllib
url, filename = ("https://github.com/pytorch/hub/raw/master/images/dog.jpg", "/tmp/dog.jpg")
try: urllib.URLopener().retrieve(url, filename)
except: urllib.request.urlretrieve(url, filename)

# sample execution (requires torchvision)
from PIL import Image
from torchvision import transforms
input_image = Image.open(filename)
preprocess = transforms.Compose([
    transforms.Resize(256),
    transforms.CenterCrop(224),
    transforms.ToTensor(),
    transforms.Normalize(mean=[0.485, 0.456, 0.406], std=[0.229, 0.224, 0.225]),
])
input_tensor = preprocess(input_image)
input_batch = input_tensor.unsqueeze(0) # create a mini-batch as expected by the model

# move the input and model to GPU for speed
device = "cuda"
input_batch = input_batch.to(device)
model.to(device)

if FP16:
    model.half()
    input_batch = input_batch.half()

# warmup
with torch.no_grad():
    output = model(input_batch)

    start = time.time()
    output = model(input_batch)
    print("torch result", output[0, 0])
    print("torch time", time.time() - start)

# IREE
mlir = torch_mlir.compile(
    model,
    input_batch,
    output_type="linalg-on-tensors",
    use_tracing=True)

# with open("torch.mlir", "w") as f:
#     f.write(str(mlir))

iree_input_type = "tm_tensor"
bytecode_stream = io.BytesIO()
mlir.operation.write_bytecode(bytecode_stream)
flatbuffer = ireec.compile_str(bytecode_stream.getvalue(),
                              target_backends=[device],
                              input_type=iree_input_type,
                              extra_args=[
                                "--iree-hal-cuda-llvm-target-arch=sm_75",
                                # "--mlir-print-ir-after=iree-flow-form-dispatch-workgroups",
                                # "--mlir-elide-elementsattrs-if-larger=8",
                                "--iree-flow-dump-dispatch-graph",
                                "--iree-flow-dump-dispatch-graph-output-file=foo.dot"])

iree_device = ireert.get_device(device)
config = ireert.Config(device=iree_device)
ctx = ireert.SystemContext(config=config)
vm_module = ireert.VmModule.from_flatbuffer(ctx.instance, flatbuffer)
ctx.add_vm_module(vm_module)
invoker = ctx.modules.module

# warmup
iree_input_batch = ireert.asdevicearray(iree_device, input_batch.cpu().numpy())
result = invoker.forward(iree_input_batch)

start = time.time()
result = invoker.forward(iree_input_batch)
numpy_result = np.asarray(result)
print("iree result", numpy_result[0][0])
print("iree time", time.time() - start)

I got iree time 0.018112897872924805, which means iree takes 18ms.

Benchmark TRT

import torch

import time
import os

FP16 = False

model = torch.hub.load('pytorch/vision:v0.10.0', 'resnet18', pretrained=True)
model.eval()

# Download an example image from the pytorch website
import urllib
url, filename = ("https://github.com/pytorch/hub/raw/master/images/dog.jpg", "/tmp/dog.jpg")
try: urllib.URLopener().retrieve(url, filename)
except: urllib.request.urlretrieve(url, filename)

# sample execution (requires torchvision)
from PIL import Image
from torchvision import transforms
input_image = Image.open(filename)
preprocess = transforms.Compose([
    transforms.Resize(256),
    transforms.CenterCrop(224),
    transforms.ToTensor(),
    transforms.Normalize(mean=[0.485, 0.456, 0.406], std=[0.229, 0.224, 0.225]),
])
input_tensor = preprocess(input_image)
input_batch = input_tensor.unsqueeze(0) # create a mini-batch as expected by the model

# move the input and model to GPU for speed
device = "cuda"
input_batch = input_batch.to(device)
model.to(device)

if FP16:
    model.half()
    input_batch = input_batch.half()

with torch.no_grad():
    output = model(input_batch)

    start = time.time()
    output = model(input_batch)
    print("torch result", output[0, 0])
    print("torch time", time.time() - start)

torch.onnx.export(model,         # model being run
    input_batch,       # model input (or a tuple for multiple inputs)
    "/tmp/ResNet18.onnx",       # where to save the model
    export_params=True,  # store the trained parameter weights inside the model file
    do_constant_folding=True,  # whether to execute constant folding for optimization
    input_names = ['modelInput'],   # the model's input names
    output_names = ['modelOutput'])

if FP16:
    os.system("trtexec --onnx=/tmp/ResNet18.onnx --saveEngine=/tmp/ResNet18.trt --fp16")
else:
    os.system("trtexec --onnx=/tmp/ResNet18.onnx --saveEngine=/tmp/ResNet18.trt")

I got Latency: min = 1.01019 ms, max = 1.11401 ms, mean = 1.04413 ms, median = 1.04384 ms.
What component(s) does this issue relate to?
Runtime
Version information
6a46afd4f82715979b54c57fb41a8505466cd68f
Additional context
No response

@qcolombet Can you help give this a quick triage?

Given the kind of workload, this is not surprising.
We didn't have time to spend a lot of time on convolution performance at this point.
@qedawkins I believe you still have some convolution improvements to land (e.g., https://github.com/openxla/iree/pull/13449), do you think that would be enough to close the gap here?

Given the kind of workload, this is not surprising. We didn't have time to spend a lot of time on convolution performance at this point.
@qedawkins I believe you still have some convolution improvements to land (e.g., #13449), do you think that would be enough to close the gap here?

There are a few more missing pieces after #13449. First, that won't support trailing elementwise fusion just yet, and the version of resnet I have locally (I'm guessing this is the same) produces dispatches like:
func.func @forward_dispatch_1_conv_2d_nchw_fchw_1x64x112x112x3x7x7_f16(%arg0: !flow.dispatch.tensor<readonly:tensor<1x3x230x230xf16>>, %arg1: !flow.dispatch.tensor<readonly:tensor<64x3x7x7xf16>>, %arg2: !flow.dispatch.tensor<writeonly:tensor<1x64x112x112xf16>>) {
  %cst = arith.constant 9.953970e-06 : f16
  %cst_0 = arith.constant 0.000000e+00 : f16
  %cst_1 = arith.constant dense_resource<__elided__> : tensor<1x64xf16>
  %cst_2 = arith.constant dense_resource<__elided__> : tensor<1x64xf16>
  %cst_3 = arith.constant dense_resource<__elided__> : tensor<1x64xf16>
  %cst_4 = arith.constant dense_resource<__elided__> : tensor<1x64xf16>
  %0 = flow.dispatch.tensor.load %arg0, offsets = [0, 0, 0, 0], sizes = [1, 3, 230, 230], strides = [1, 1, 1, 1] : !flow.dispatch.tensor<readonly:tensor<1x3x230x230xf16>> -> tensor<1x3x230x230xf16>
  %1 = flow.dispatch.tensor.load %arg1, offsets = [0, 0, 0, 0], sizes = [64, 3, 7, 7], strides = [1, 1, 1, 1] : !flow.dispatch.tensor<readonly:tensor<64x3x7x7xf16>> -> tensor<64x3x7x7xf16>
  %2 = tensor.empty() : tensor<1x64x112x112xf16>
  %3 = linalg.fill ins(%cst_0 : f16) outs(%2 : tensor<1x64x112x112xf16>) -> tensor<1x64x112x112xf16>
  %4 = linalg.conv_2d_nchw_fchw {dilations = dense<1> : vector<2xi64>, strides = dense<2> : vector<2xi64>} ins(%0, %1 : tensor<1x3x230x230xf16>, tensor<64x3x7x7xf16>) outs(%3 : tensor<1x64x112x112xf16>) -> tensor<1x64x112x112xf16>
  %5 = linalg.generic {indexing_maps = [#map, #map1, #map1, #map1, #map1, #map], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%4, %cst_1, %cst_2, %cst_3, %cst_4 : tensor<1x64x112x112xf16>, tensor<1x64xf16>, tensor<1x64xf16>, tensor<1x64xf16>, tensor<1x64xf16>) outs(%2 : tensor<1x64x112x112xf16>) {
  ^bb0(%in: f16, %in_5: f16, %in_6: f16, %in_7: f16, %in_8: f16, %out: f16):
    %6 = arith.addf %in_8, %cst : f16
    %7 = math.rsqrt %6 : f16
    %8 = arith.subf %in, %in_7 : f16
    %9 = arith.mulf %8, %7 : f16
    %10 = arith.mulf %9, %in_5 : f16
    %11 = arith.addf %10, %in_6 : f16
    %12 = arith.addf %11, %in : f16
    %13 = arith.cmpf ugt, %12, %cst_0 : f16
    %14 = arith.select %13, %12, %cst_0 : f16
    linalg.yield %14 : f16
  } -> tensor<1x64x112x112xf16>
  flow.dispatch.tensor.store %5, %arg2, offsets = [0, 0, 0, 0], sizes = [1, 64, 112, 112], strides = [1, 1, 1, 1] : tensor<1x64x112x112xf16> -> !flow.dispatch.tensor<writeonly:tensor<1x64x112x112xf16>>
  return
}

which won't go down the implicit gemm path. Currently there is an issue with trailing elementwise related to transform.structured.hoist_redundant_vector_transfers which doesn't model parallelism and will store the promoted C-matrix without a barrier before the trailing part.
Second, f16 support is missing, for which I have a draft PR here: #13735. I've been waiting on the aligned matmul PR for putting it up for review. With those patches alone I wouldn't expect the gap to close completely though as there are still some in-progress perf items listed in #13641.
I can take this issue though as most of this should be addressed by in-progress items on my side.

Don't we also need a layout conversion for these models coming from PyTorch? In SHARK we use a custom pass to swap https://github.com/openxla/iree/commit/0016622a6e5535e33bb5b97b66f0e1880313939b and here is the list of models we apply that pass for coming from Torch https://github.com/nod-ai/SHARK/blob/main/tank/all_models.csv

Don't we also need a layout conversion for these models coming from PyTorch? In SHARK we use a custom pass to swap 0016622 and here is the list of models we apply that pass for coming from Torch https://github.com/nod-ai/SHARK/blob/main/tank/all_models.csv

Yep, we'll definitely want to do that for resnet as well as the packs/transposes that come out of it cancel nicely for that model. Although I would probably keep that part separate from the convolution work as it's not strictly required, just better for performance with implicit gemm. Performance cliffs with PyTorch models due to poor handling of NCHW convolutions has been a problem point in the past and we should be able to at least to reasonably well without the layout transformation.
I think landing something similar to that pass was planned (or at least some way to do the layout transformation), but would be cool if this accelerates that part also :D


fix some 3rd-party versions in build.gradle (see FINERACT-805)

FINERACT-805

@xurror @awasum how about this?

@awasum @xurror how do you like this one?
@ptuomola @maektwain FYI if interested.

LGTM...
Someone interested in this should also just update the Spring Boot and Spring versions along with Gradle Wrapper version so we dont forget. A GSoC Applicant reading might like to do this... @nnatarajan  will u be interested to do that? in a different(new) PR?

I'm going to rebase this to resolve conflicts following related earlier #803 #802 #806.
I'll also awai @xurror review feedback on this one, as he introduced some of what I'm upgrading here.
@ptuomola hope this and earlier #803 #802 #806 wont' cause too much rebase conflict for your #807.

LGTM...
Someone interested in this should also just update the Spring Boot and Spring versions along with Gradle Wrapper version so we dont forget. A GSoC Applicant reading might like to do this... @nnatarajan will u be interested to do that? in a different(new) PR?

Is there a jira ticket for this one?


Draft: Implement check as subcommand

I started working on creating subcommands.
Could I get feedback for this? Is this the direction you want it to go?
It would be good for me when we could define all commands with the possible options

Could I get feedback for this? Is this the direction you want it to go?

I only had time to scan it quick, but yeah I this looks like what I was thinking, breaking apart the commands so it is clear which options apply to which command.

Ok i am finished. You could go for a review. One thing I was not sure about was which option should be available for the check command.

As you want. You can also ping me when you figured it out.

Got the last few sub options cleaned up and settled on just making a new branch for 1.0.0 instead of waiting to merge this to main. Thanks again!


dev: enforce katana in make test-end-to-end

Time spent on this PR: 45 -50 mins
Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[x] Other (please describe):

What is the current behavior?

from .env file, the variable STARKNET_NETWORK is used to both:

decide on which network to deploy kakarot
decide on which network to run the integration tests

Resolves #1100
What is the new behavior?

make test-end-to-end forces STARKNET_NETWORK to be katana

This change is

@jaipaljadeja see comments on the issue, there is still a disagreement on the strategy, sorry!


Add Part number to PRA webpage

We're missing the number "1002" from the "Part" as listed in the Paperwork Reduction Statement. See below in bold what should be added.
Paperwork Reduction Act
According to the Paperwork Reduction Act of 1995, an agency may not conduct or sponsor, and a person is not required to respond to a collection of information unless it displays a valid OMB control number.  The OMB control number for this collection is 3170-0013 It expires on 08/31/2026   The time required to complete this information collection is estimated to be 3,098 hours annually per respondent. The obligation to respond to this collection of information is mandatory per the Equal Credit Opportunity Act  (ECOA), 15 U.S.C. 1691 et seq., implemented by Regulation B, 12 CFR Part 1002. Comments regarding this collection of information, including the estimated response time, suggestions for improving the usefulness of the information, or suggestions for reducing the burden to respond to this collection should be submitted to Bureau at the Consumer Financial Protection Bureau (Attention:  PRA Office), 1700 G Street NW, Washington, DC 20552, or by email to<EMAIL_ADDRESS>

@chynnakeys
Did anything else other than the part number change? Is it ok if I add "the" before "Bureau" as per our editorial style guidelines?

@angelcardoz @chynnakeys
We made these updates before beta launch. Can we close this ticket at this point or do we need to track this work somewhere?


Tempo for The Cooldown

the tempo is not taken into account for the cooldown times of the spells...
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Sim Links and Screenshots
If applicable, add links to your sim settings or screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hey thanks for the report, the description is pretty vague though. Could you clarify what the ask is here?

Hey thanks for the report, the description is pretty vague though. Could you clarify what the ask is here?

mind blast has a cd time of 8sec, due to my tempo rating the cd is currently reduced to 5.5sec which is not taken into account according to the timeline, it is only cast again after 8sec.

Could you provide a settings link to show the issue? Export --> Link

Ah, there's no bug here, this is just the rotation logic.  If you look closely, you'll see that the time between casts is still often < 8s.


Fix incorrect array size specification

The count and start arrays are dimensioned to NC_MAX_DIMS even though the maximum size should be NDIMS which is set to 3; possibly, the maximum size could be 2 since only indices 0 and 1 are used to access both start and count.  I left it at NDIMS since that matches the number of items in the initialization and is consistent with other uses in the file.

Looks good, let me review the rest of the pull requests before I start making comments on any particular one.

Got lots of merge errors, trying to merge master into this, for some reason.  I'm going to merge it by hand.


[BUG] SIWEConfig and SIWEContext are not exported

Describe the bug
I'm trying to implement my own custom sign in button using next-auth.
When I configure the SIWEProvider, I have to import the SIWEConfig from "connectkit/build/components/Standard/SIWE/SIWEContext" because it's not available from connectkit.
Same issue with the actual React context too. I'm trying to follow the SIWEButton component, and use context to correctly create the message and sign in, but the context that I can import returns a module not found error.
To reproduce
// SignInEthButton.tsx

// Have to import from here since `SIWEContext` isn't available from `connectkit`
import { SIWEContext } from "connectkit/build/components/Standard/SIWE/SIWEContext";
import { useContext } from "react";

export function SignInEthButton() {
  // Fails since `SIWEContext` cannot be found
  const siweContext = useContext(SIWEContext);

  // Rest of button logic similar to `SIWEButton` from connectkit
}

Results in the following error:
./src/components/ui/SignInEthButton.tsx:1:0
Module not found: Can't resolve 'connectkit/build/components/Standard/SIWE/SIWEContext'
> 1 | import { SIWEContext } from "connectkit/build/components/Standard/SIWE/SIWEContext";

Expected behavior
To be able to import the context so that I can make my own sign in button.
Alternatively expose an easy way to call signIn, or to open the sign in section of the modal from another component.
Screenshots
N/A
Environment details
Using:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Additional context
My use case is basically because I don't want to prompt the user to sign a message as soon as they connect their wallet. I want them to only have to sign a message when it's necessary for a certain part of my app. I set the enabled flag to false on the SIWE provider (which is also kind of weird to me, I would expect something like signInOnConnect), which means I need a SIWE button. I don't want to have to reskin the connectkit component, and would rather provide my own underlying Button component. Happy to rebuild my own, but it's hard when you don't have access to the same context.

A new update to SIWE has just been released, check out the release notes to learn more. This should hopefully resolve this issue ☺


Set up Intel/Nvidia/AMD gpus

We already load gpu drivers into the initrd, but we do not yet setup opengl/vulkan drivers.

For nvidia we can detect the gpu chip generation and than decide if want the open or closed gpu driver.
We figured out that lspci has the gpu generation for nvidia in its first few characters encoded.

I am getting the following with nixos-anywhere and facter:
error:
       … while calling the 'seq' builtin

         at /nix/store/m1szqwijms610n6325mwjswslha4nd92-source/lib/modules.nix:322:18:

          321|         options = checked options;
          322|         config = checked (removeAttrs config [ "_module" ]);
             |                  ^
          323|         _module = checked (config._module);

       … while calling the 'throw' builtin

         at /nix/store/m1szqwijms610n6325mwjswslha4nd92-source/lib/modules.nix:298:18:

          297|                     ''
          298|             else throw baseMsg
             |                  ^
          299|         else null;

       error: The option `hardware.graphics' does not exist. Definition values:
       - In `/nix/store/isph9via2616d4hf2ixavza3ig9wjk2c-source/modules/nixos/graphics.nix':
           {
             _type = "if";
             condition = true;
             content = {
               enable = {
           ...

@geekodour This option was introduced in nixpkgs-unstable but is not yet available in 24.05.
Fix in https://github.com/numtide/nixos-facter-modules/pull/45
We currently don't actively test nixos 24.05 compatibility, but we might start doing this with 24.11.

We have now some support for AMD GPUs. For nvidia, we need to detect the gpu generation to figure out if we can use the open driver or not. For Intel we need to detect the iGPU generation as well to load the right opencl/opengl and vaapi driver.


Gitalytics link on the README is broken.

Looks like gitalytics doesn't even exist anymore?

Thanks, removed.


Saving the HARP output doesn't give a default file extension (Linux)

In MacOS, if you leave off a file extension, it adds .wav. If you pick another supported extension (like .ogg) it saves just fine.  If you pick a non-supported extension (like .xml) HARP tells you it cannot save in that format and tells you ".wav" is required (even though multiple formats are supported).
 That's a bug for sure.

On Windows and Linux the non-supported extensions are not throwing errors either (the outputted file is a .wav but with whatever extension that's been put).


Implement GraphQL

So I manage to set up GraphQL query with the inclusion of the Apollo client, end-to-end type safety with GraphQL Code Generation and set up an environment variable for querying Hasura database for the app. All of the setups are documented on the README.md.
The way GraphQL API calls seem simple enough with a simple fetch and load approach (as an example here), but I keep getting stuck with how to set up loading screens to render while juggling between dependent useEffects and page components. The MeetPage.tsx seems more straightforward as the <CommunityVideoComponent> seems more self-contained, so I didn't have much in terms of problems. But when trying to implement loading at MapPage.tsx, that is when I got lost on what useState hooks are dependent on by what components and errors result from it. I fear that I might have to severely refactor MapPage.tsx, seeing how intertwined it seems.
Outside of loading issues, I am also unsure how I set up GraphQL codegen or how to organize GraphQL queries in the project, but I do want some consensus on how to structure it moving forward.

I think I got the graphql query for the Mapbox storytelling folder working on my localhost. Nice!
What do you think the next step would be to get the table to be controlled in the mattapan-mapping admin panel for demoing?


missing "caBundle" in ValidatingWebhookConfiguration

I try to apply manifest but validating webhook can not be created.
With --validate=false it works fine
$ kubectl apply -f https://raw.githubusercontent.com/jetstack/cert-manager/master/deploy/manifests/cert-manager.yaml
serviceaccount/cert-manager-webhook created
serviceaccount/cert-manager configured
clusterrole.rbac.authorization.k8s.io/cert-manager configured
clusterrolebinding.rbac.authorization.k8s.io/cert-manager configured
clusterrole.rbac.authorization.k8s.io/cert-manager-view created
clusterrole.rbac.authorization.k8s.io/cert-manager-edit created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-webhook:auth-delegator created
rolebinding.rbac.authorization.k8s.io/cert-manager-webhook:webhook-authentication-reader created
clusterrole.rbac.authorization.k8s.io/cert-manager-webhook:webhook-requester created
service/cert-manager-webhook created
deployment.apps/cert-manager-webhook created
deployment.apps/cert-manager configured
cronjob.batch/cert-manager-webhook-ca-sync created
job.batch/cert-manager-webhook-ca-sync created
configmap/cert-manager-webhook-ca-sync created
serviceaccount/cert-manager-webhook-ca-sync created
clusterrole.rbac.authorization.k8s.io/cert-manager-webhook-ca-sync created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-webhook-ca-sync created
apiservice.apiregistration.k8s.io/v1beta1.admission.certmanager.k8s.io created
issuer.certmanager.k8s.io/cert-manager-webhook-selfsign created
certificate.certmanager.k8s.io/cert-manager-webhook-ca created
issuer.certmanager.k8s.io/cert-manager-webhook-ca created
certificate.certmanager.k8s.io/cert-manager-webhook-webhook-tls created
error: error validating "https://raw.githubusercontent.com/jetstack/cert-manager/master/deploy/manifests/cert-manager.yaml": error validating data: [ValidationError(ValidatingWebhookConfiguration.webhooks[0].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[1].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[2].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig]; if you choose to ignore these errors, turn validation off with --validate=false

+1

I'm having the same issue

This looks like it is due to this change: https://github.com/jetstack/cert-manager/pull/911
I think you should be able to just add an empty string for caBundle, but ultimately this should be made to be an optional property.

Thanks @rrichardson
Adding empty string for caBundle helps:
diff --git a/deploy/manifests/cert-manager.yaml b/deploy/manifests/cert-manager.yaml
index 7a2d3a63..d965256c 100644
--- a/deploy/manifests/cert-manager.yaml
+++ b/deploy/manifests/cert-manager.yaml
@@ -595,6 +595,7 @@ webhooks:
         name: kubernetes
         namespace: default
         path: /apis/admission.certmanager.k8s.io/v1beta1/certificates
+      caBundle: ""
   - name: issuers.admission.certmanager.k8s.io
     namespaceSelector:
       matchExpressions:
@@ -622,6 +623,7 @@ webhooks:
         name: kubernetes
         namespace: default
         path: /apis/admission.certmanager.k8s.io/v1beta1/issuers
+      caBundle: ""
   - name: clusterissuers.admission.certmanager.k8s.io
     namespaceSelector:
       matchExpressions:
@@ -649,4 +651,4 @@ webhooks:
         name: kubernetes
         namespace: default
         path: /apis/admission.certmanager.k8s.io/v1beta1/clusterissuers
-
+      caBundle: ""

I just encountered this problem with 0.6:
 kubectl apply -f https://raw.githubusercontent.com/jetstack/cert-manager/release-0.6/deploy/manifests/cert-manager.yaml
customresourcedefinition.apiextensions.k8s.io "certificates.certmanager.k8s.io" configured
customresourcedefinition.apiextensions.k8s.io "issuers.certmanager.k8s.io" configured
customresourcedefinition.apiextensions.k8s.io "clusterissuers.certmanager.k8s.io" configured
customresourcedefinition.apiextensions.k8s.io "orders.certmanager.k8s.io" configured
customresourcedefinition.apiextensions.k8s.io "challenges.certmanager.k8s.io" configured
namespace "cert-manager" configured
serviceaccount "cert-manager-webhook" unchanged
serviceaccount "cert-manager" unchanged
clusterrole.rbac.authorization.k8s.io "cert-manager" created
clusterrolebinding.rbac.authorization.k8s.io "cert-manager" created
clusterrole.rbac.authorization.k8s.io "cert-manager-view" created
clusterrole.rbac.authorization.k8s.io "cert-manager-edit" created
clusterrolebinding.rbac.authorization.k8s.io "cert-manager-webhook:auth-delegator" created
rolebinding.rbac.authorization.k8s.io "cert-manager-webhook:webhook-authentication-reader" created
clusterrole.rbac.authorization.k8s.io "cert-manager-webhook:webhook-requester" created
service "cert-manager-webhook" unchanged
deployment.apps "cert-manager-webhook" configured
deployment.apps "cert-manager" configured
cronjob.batch "cert-manager-webhook-ca-sync" unchanged
job.batch "cert-manager-webhook-ca-sync" unchanged
configmap "cert-manager-webhook-ca-sync" unchanged
serviceaccount "cert-manager-webhook-ca-sync" unchanged
clusterrole.rbac.authorization.k8s.io "cert-manager-webhook-ca-sync" created
clusterrolebinding.rbac.authorization.k8s.io "cert-manager-webhook-ca-sync" created
apiservice.apiregistration.k8s.io "v1beta1.admission.certmanager.k8s.io" created
issuer.certmanager.k8s.io "cert-manager-webhook-selfsign" configured
certificate.certmanager.k8s.io "cert-manager-webhook-ca" configured
issuer.certmanager.k8s.io "cert-manager-webhook-ca" configured
certificate.certmanager.k8s.io "cert-manager-webhook-webhook-tls" configured
error: error validating "https://raw.githubusercontent.com/jetstack/cert-manager/release-0.6/deploy/manifests/cert-manager.yaml": error validating data: [ValidationError(ValidatingWebhookConfiguration.webhooks[0].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[1].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[2].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig]; if you choose to ignore these errors, turn validation off with --validate=false

As per the install guide, you need to either upgrade to kubectl 1.13 or
later, or add '--validate=false' to your 'kubectl apply' command.
On Sat, 9 Mar 2019 at 20:24, Mike Bridge<EMAIL_ADDRESS>wrote:

I just encountered this problem with 0.6:
kubectl apply -f https://raw.githubusercontent.com/jetstack/cert-manager/release-0.6/deploy/manifests/cert-manager.yamlcustomresourcedefinition.apiextensions.k8s.io "certificates.certmanager.k8s.io" configuredcustomresourcedefinition.apiextensions.k8s.io "issuers.certmanager.k8s.io" configuredcustomresourcedefinition.apiextensions.k8s.io "clusterissuers.certmanager.k8s.io" configuredcustomresourcedefinition.apiextensions.k8s.io "orders.certmanager.k8s.io" configuredcustomresourcedefinition.apiextensions.k8s.io "challenges.certmanager.k8s.io" configured
namespace "cert-manager" configured
serviceaccount "cert-manager-webhook" unchanged
serviceaccount "cert-manager" unchangedclusterrole.rbac.authorization.k8s.io "cert-manager" createdclusterrolebinding.rbac.authorization.k8s.io "cert-manager" createdclusterrole.rbac.authorization.k8s.io "cert-manager-view" createdclusterrole.rbac.authorization.k8s.io "cert-manager-edit" createdclusterrolebinding.rbac.authorization.k8s.io "cert-manager-webhook:auth-delegator" createdrolebinding.rbac.authorization.k8s.io "cert-manager-webhook:webhook-authentication-reader" createdclusterrole.rbac.authorization.k8s.io "cert-manager-webhook:webhook-requester" created
service "cert-manager-webhook" unchanged
deployment.apps "cert-manager-webhook" configured
deployment.apps "cert-manager" configured
cronjob.batch "cert-manager-webhook-ca-sync" unchanged
job.batch "cert-manager-webhook-ca-sync" unchanged
configmap "cert-manager-webhook-ca-sync" unchanged
serviceaccount "cert-manager-webhook-ca-sync" unchangedclusterrole.rbac.authorization.k8s.io "cert-manager-webhook-ca-sync" createdclusterrolebinding.rbac.authorization.k8s.io "cert-manager-webhook-ca-sync" createdapiservice.apiregistration.k8s.io "v1beta1.admission.certmanager.k8s.io" createdissuer.certmanager.k8s.io "cert-manager-webhook-selfsign" configuredcertificate.certmanager.k8s.io "cert-manager-webhook-ca" configuredissuer.certmanager.k8s.io "cert-manager-webhook-ca" configuredcertificate.certmanager.k8s.io "cert-manager-webhook-webhook-tls" configured
error: error validating "https://raw.githubusercontent.com/jetstack/cert-manager/release-0.6/deploy/manifests/cert-manager.yaml": error validating data: [ValidationError(ValidatingWebhookConfiguration.webhooks[0].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[1].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[2].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig]; if you choose to ignore these errors, turn validation off with --validate=false
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jetstack/cert-manager/issues/1143#issuecomment-471218930,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbP2ORqo7KwCrcdvQjcS_uuo9Zf8Ukks5vVBhygaJpZM4ZH8pr
.

@munnerz my mistake, thanks! (link)

Still happening with 1.12 at GKE.
 kubectl version
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.2", GitCommit:"17c77c7898218073f14c8d573582e8d2313dc740", GitTreeState:"clean", BuildDate:"2018-10-24T06:54:59Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.5-gke.5", GitCommit:"2c44750044d8aeeb6b51386ddb9c274ff0beb50b", GitTreeState:"clean", BuildDate:"2019-02-01T23:53:25Z", GoVersion:"go1.10.8b4", Compiler:"gc", Platform:"linux/amd64"}

This is the error
certificate.certmanager.k8s.io/cert-manager-webhook-webhook-tls created
error: error validating "https://raw.githubusercontent.com/jetstack/cert-manager/release-0.7/deploy/manifests/cert-manager.yaml": error validating data: [ValidationError(ValidatingWebhookConfiguration.webhooks[0].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[1].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[2].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig]; if you choose to ignore these errors, turn validation off with --validate=false

On GKE the webhook never gets to the completed state.  The errors in the stackdriver log say
message:  "Forbidden: "/", Reason: "no RBAC policy matched""
Here are the RBAC policies I have set up.
kubectl create clusterrolebinding cluster-admin-binding \
    --clusterrole=cluster-admin \
    --user=$(gcloud config get-value core/account) \
    --dry-run \
    -o yaml | kubectl apply -f -

kubectl create clusterrolebinding add-on-cluster-admin \
    --clusterrole=cluster-admin \
    --serviceaccount=kube-system:default \
     --dry-run \
     -o yaml | kubectl apply -f -

I had the same error, my cluster version is 1.12.7, but the error in my case was by the following:
I was trying attach cert-manager as a helm dependency in my requirements.yaml helm chart file and when I do that, I execute helm dep update to tell to helm that attach to cert-manager.
Then a *.tgz cert-manager package is downloaded to my chart/ directory.
My idea was to remove cert-manager like dependency and so I had to remove the *.tgz cert-manager package from chart/ directory and also update the helm dependencies executing again executing helm dep update in order to don't have any dependency attached.
⟩ helm dep update
Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "local" chart repository (http://<IP_ADDRESS>:8879/charts):
        Get http://<IP_ADDRESS>:8879/charts/index.yaml: dial tcp <IP_ADDRESS>:8879: connect: connection refused
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 0 charts
Deleting outdated charts

And my problem with the "caBundle"has disappear.

This is still happening for me with version v1.13.4

I'm also seeing it with v1.14.1

I too am seeing this with v1.14.1

Still happening, also when using helm as per docs
helm install \   --name cert-manager \   --namespace cert-manager \   --version v0.7.0 \   jetstack/cert-manager

I also have the same error

Me as well

/reopen
I'm seeing this as well on
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.2", GitCommit:"66049e3b21efe110454d67df4fa62b08ea79a19b", GitTreeState:"clean", BuildDate:"2019-05-16T16:23:09Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.7", GitCommit:"6f482974b76db3f1e0f5d24605a9d1d38fad9a2b", GitTreeState:"clean", BuildDate:"2019-03-25T02:41:57Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}```
```$ helm version
2019/05/29 02:32:48.168301 main.go:220: WARNING: cannot create syslog logger
Client: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}

seeing a similar error
Error: validation failed: error validating "": error validating data: [ValidationError(ValidatingWebhookConfiguration.webhooks[0].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[1].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig, ValidationError(ValidatingWebhookConfiguration.webhooks[2].clientConfig): missing required field "caBundle" in io.k8s.api.admissionregistration.v1beta1.WebhookClientConfig]

Client: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-06T01:44:30Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.7-gke.10", GitCommit:"8d9b8641e72cf7c96efa61421e87f96387242ba1", GitTreeState:"clean", BuildDate:"2019-04-12T22:59:24Z", GoVersion:"go1.10.8b4", Compiler:"gc", Platform:"linux/amd64"}

Solved upgrading Helm to 2.14.1 (both client and server)
Reference:

https://github.com/helm/helm/pull/5643
https://github.com/jetstack/cert-manager/issues/1690


that's mean with command '../bin/codis-config action ...'?

请问一下../bin/codis-config action 该命令的用意是什么？gc选项在什么意境下使用？

every time you use codis-config (data migration, add/remove server group), it will generate a action log in zookeeper (/zk/codis/db_xxx/actions/...), for logging and communicating with proxies. After a long time, it will generate a alog out-of-date actions .
use 'action gc' to clean them, or you can delete them in zookeeper manually.

it's clear action log from zookeeper only?

yep. when we're developing codis, we wrote some scripts for auto integration test and run them 24/7, that will make codis generate a lot action log. I have to delete them manually using zk-cli everyday. it's boring, so i add a simple command 'action gc' to do it.

那我是不是需要写一个crontab去调用 '../bin/codis-config action gc ...' ，来清除zookeeper里面的关于一些action等的一些日志？还是这个过程，codis已经自己做到了呢？

call '../bin/codis-config action gc' manually. for example. keep last 1 day actions
../bin/codis-config action gc -s 86400
but, in production environment, action log is not growing fast (you won't use codis-config everyday :D ), so you don't  have to write a crontab script on purpose.

I understand, tks.


[Feature Request] API for rendering an adaptive card to an image

Issue Description
Adaptive cards are still not completely supported in e.g. Cortana, Skype and Teams. A roadmap is not really around. So adapting the Adaptive Card technology/standard is impeded, because people cannot bring their already existing adaptive card implementations to those platforms. Thus, people are stopped form releasing features.
Instead of waiting for Adaptive Cards being completely supported by a platform, we can simply use images: An adaptive card could be rendered to an image that can be used in conversation messages on channels that are not (yet) supporting adaptive cards or even in all new channels that will appear in the future.
Rendering cards to an image is shown in the WPFVisualizer sample (https://github.com/Microsoft/AdaptiveCards/tree/master/source/dotnet/Samples/WPFVisualizer). But this is specific to WPF and does not work properly in other scenarios (based on WPF, so you have to deploy it, e.g. with a bot implementation).
Feature Request
We need a utility service that renders an adaptive card to an image. Only a simple default design is needed, e.g. the card design of WebChat. The service works async and returns at least a byte stream of the image.
Code Example
var hostConfig = new AdaptiveHostConfig()
{
    SupportsInteractivity = false
};

var renderer = new AdaptiveCardRenderer(hostConfig)
{
    // Set defined resources here.
    Resources = new ResourceDictionary()
};

Stream pngImageStream = await renderer.RenderToImageAsync(parseResult.Card);

Hi @robbiezhang, we are hard at work on all Microsoft channels to get native adaptive cards support launched asap. Stay tuned we should have more to share before the end of the year.
As for the image service, Bot Framework currently does automatically render to image on non-MSFT channels, this works today. It's a less than ideal experience in some cases, since Actions and Inputs get dropped. You are of course able to run/host that WPF image service yourself and use it any specific channels that don't have adaptive support yet.

Why not providing the code for rendering as an image to non-MSFT channels to the community if it already exists? Only the basic rendering part? As I said, reduced, without special formatting and design for the target channel/platform would be enough.
I tried to use the WPF image service to render to an image within my bot. But it does not work properly. E.g. the method RenderToImageAsync does not return when using it within a bot implementation, adaptive image elements within a card are not rendered from time to time and at least, I don't know whether it's good to bring WPF with my bot implementation - only to render to an image.
Yes, as we can see in the images below, some channels show an image (e.g. Slack). But why not on the MSFT channels (Skype, Skype for Desktop, Cortana)? For show cases, that would be great.

Ok, if you say there will be something announced this year, I should perhaps wait. But a properly working image service could help in all cases you are not working on currently. And we can start show casing our bots with adaptive cards earlier. Especially when there is no official roadmap!! :)

@matthidinger is the image service you suggest https://github.com/Microsoft/AdaptiveCards/tree/master/source/dotnet/Samples/ImageRendererServer ?
That sample seems to work, but the resulting images are quite low quality and blurry. So I'm wondering if that is really the correct service?

@matthidinger I found the new method AdaptiveCardRenderer.RenderCardToImageAsync in package AdaptiveCards.Rendering.Wpf 1.0.0-beta06 and used it in my server as well. Works fairly good! The threading was the problem with previous version of the WPF renderer that caused images not to be rendered in a card. If that is the answer on that issue, many many thanks! :)

That's great that you got it working, that is indeed why we provided that library! Please let us know if you run into anything or have any other feedback!

Thanks for the lib and being so fast on this feedback! :)

@matthidinger is there anything like the AdaptiveCardRenderer.RenderCardToImageAsync but for node?

@ejadib there isn't such a thing at this time, but I was doing some research and it seems like there are quite a few node packages that would enable it. I don't have time to really investigate it right now but I'd be more than happy to review/integrate a PR if someone got it going

@matthidinger @ejadib I felt free to create issue #1012 for the NodeJS implementation. Hope that's ok. Could you please provide your results of package evaluation?

Is there a way to improve the image quality on NodeJS? They're so pixelated...


(GH-36) Return source branch for pull request

This brings the SourceRefName property and appropriate parts of the unit tests in.
Fixes #36

@yansklyarenko Your changes have been merged, thanks for your contribution 👍

Cool, that was super fast! :)


internal/restorable: integrate drawing history for DrawTriangles and WritePixels

Operating System

[ ] Windows
[ ] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] Xbox
[ ] Web Browsers

What feature would you like to be added?
Now, if an image's DrawTriangles is called after WritePixels, the image becomes stale and needs to read pixels from GPU at the end of the frame. Reading pixels from GPU is a very heavy operation and we should avoid this whenever possible.
In the current implementation of atlas, this often happens when an image becomes a source image from a destination image.
Let's integrate history items for DrawTriangles and WritePixels and reduce the chances of becoming stale.
Why is this needed?
n/a

Now, if an image's DrawTriangles is called after WritePixels, the image becomes stale and needs to read pixels from GPU at the end of the frame. Reading pixels from GPU is a very heavy operation and we should avoid this whenever possible.

Hmm? This should not happen since DrawTriangles after WritePixels doesn't make the image stale. Let me investigate more.


v4: plugin feature request: minify template literals

Started using lit-html lately.
Would be great if fusebox could minify template literals
Found this, maybe it can help you make a plugin after v4 is released
https://github.com/asyncLiz/minify-html-literals#readme

You can solve this using customTransformers now (recently added :) Just scan the AST for template literals and return the minified text. The modified AST will be given to the typescript compiler. You can also write a plugin that registers this transformer in the context config, so when your plugin is used, the customTransformer is used.

@kyr0
Nice, will try and look at this in the weekend.
Might ask you for help, since I have really no clue about this :-)

You can also write a plugin that registers this transformer in the context config, so when your plugin is used, the customTransformer is used.

@kyr0
Wont anything I add be destroyed by the plugin,or where you thinking about something else ?
https://github.com/fuse-box/fuse-box/blob/master/src/plugins/core/plugin_customtransform.ts
Maybe this should check if there is allready added customTransformers ?

fixed


Show a preview of the control in the SUI

Summary of the Pull Request
In the 'Appearance' tab of a profile, show a preview of what the control looks like
TODOs left:

[ ] We probably want more things in PreviewConnection
[ ] Don't hard code the size of the control preview
[ ] Placement of the control preview should be centralized
[ ] Revisit the way we set the settings of the embedded control

PR Checklist

[x] Closes #9122
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[x] I work here

Validation Steps Performed

[ ]  We probably want more things in PreviewConnection

Thoughts:

We could just go with the text that was in the old propsheet preview:

but we could probably do better than that
We could do the whole color table,

but that requires 80 columns to display right, which is a lot. Plus that's maybe better suited for the color scheme page
What if we had something simple with default, red, and green text in it, like some git output?

Other random thought - should the preview be above the scroll viewer, so the preview is always visible as you scroll through the list of settings 🤔? @cinnamon-msft for design help here

real connection

snippet from the shell

ABSOLUTELY NOT.
Imagine I make a profile that runs...
wsl -d Ubuntu rm -rf /home/dustin/profile_launched or whatever?
I'm typing it in, and I get to wsl -d Ubuntu rm -rf /home and well, there you go. Terminal decided to RUN THE COMMAND just to give me, what, a preview?
We don't want to spawn TWO NEW PROCESSES for every preview update, either.
The connection needs to be representative of what people use Terminal for. Powerline is not guaranteed (in the font); a shell is, emoji may be, etc.
I'm imagining that we have emoji in there, and some characters that might ligature together, and some colors. Not a lot of them (check the color scheme page for that). The emoji will change when you toggle colored emoji, etc.

Other random thought - should the preview be above the scroll viewer, so the preview is always visible as you scroll through the list of settings 🤔? @cinnamon-msft for design help here

Yeah I think this makes sense. I think it'll look okay once we change the Pivot to the horizontal NavView.

Other random thought - should the preview be above the scroll viewer, so the preview is always visible as you scroll through the list of settings 🤔? @cinnamon-msft for design help here

Yeah I think this makes sense. I think it'll look okay once we change the Pivot to the horizontal NavView.

You may experience weirdness nesting a NavigationView inside another NavigationView

Misc settings
Do the following profile settings do anything?

Retro terminal effects
Cursor shape & height
Acrylic and acrylic opacity
scrollbar visibility

They all work except acrylic!

They all work except acrylic!

I'm a bit conflicted on this. Definitely not blocking the PR for this, but we should probably file a follow-up to be able to provide a preview of the acrylic (if that's even possible).
But if it's not too much work for you to do it now, that'd be cool too ;) haha.

A few updates:

The preview connection now automatically sends the default text, as well as red/green/blue text
The preview connection no longer allows any input from the user
The control preview is now above the General/Appearance/Advanced tabs (so this automatically gives us the ability to scroll without losing sight of the control)
When the window width is <640 px, the control preview will resize itself to fit the window width (with a small margin on both sides), otherwise the control preview width is set at 640

Notes from Demo w/ @cinnamon-msft

Add a border to the preview (probably with the accent color?)

This'll help distinguish the preview background from the page background.

Cursor should just stay on (no blinking)

This'll make it look like it's not interactive.

Move terminal preview to be under the pivot control/selector

The space between the page header and the preview looks a little weird. This might fix that problem and make it look more natural.

Move the preview to be inside the "Appearance" pivot item

There's no need for us to be able to see the preview when in "General" or "Advanced", really. The entire purpose of this is to be a preview of the appearance, so it'll look nice if it's only in the "Appearance" item.

Align the preview to the left

I disagree with Kayla on this one, but who knows, maybe it'll look good. She has a better eye for this stuff than I do, generally.

Content inside the preview

People probably want to see something more like a prompt. Kayla and I came up with this...

Windows Terminal
Copyright (c) Microsoft Corporation.

C:\Windows\Terminal>  <CURSOR>

I think it'll look nice and kinda match the initial output of PowerShell/CMD.

[punt] figure out a way to show selected text. Some ideas:

let you select text (I feel like this is the least appealing option here)
have some pre-selected text on the preview?

[punt] show colored text:

This one is weird. The preview in the ColorSchemes page is going to show this off a lot better with a full color table. So I think we should just revisit this topic once we get a preview in the ColorSchemes page
I'm not really too sure what the best approach here is, so that's why I think it's better to punt on it and get this in.

[punt + feature idea?] Allow multiple customizable previews:

Realistically, we'll never be able to make everybody happy, especially when you start taking into account that some people have a powerline theme (and it might be a custom one too). Maybe we should eventually allow users to import their own preview output? Like, they can import some kind of text file that is just gets output via the preview connection, and any color changing VT sequences get handled too?
This would be a huge undertaking and is definitely off topic, but I think this is a good example of future work that we can do after this feature goes in and we get some user feedback. 😊

Miscellaneous notes

"scrollbar visibility" doesn't do anything

It makes sense that it doesn't. We only show it if we're scrolled down.

good job on the scrolling behavior

the preview should always be visible, so it's nice that you can just make changes and immediately see them without having to scroll up. LOVE IT!

Acrylic works!!!!

Notes from Demo w/ @cinnamon-msft Kayla Cinnamon FTE

Add a border to the preview (probably with the accent color?)

This'll help distinguish the preview background from the page background.

Cursor should just stay on (no blinking)

This'll make it look like it's not interactive.

Move terminal preview to be under the pivot control/selector

The space between the page header and the preview looks a little weird. This might fix that problem and make it look more natural.

This is incompatible with keeping it visible while you scroll, which you loved.

Move the preview to be inside the "Appearance" pivot item

There's no need for us to be able to see the preview when in "General" or "Advanced", really. The entire purpose of this is to be a preview of the appearance, so it'll look nice if it's only in the "Appearance" item.

What about Advanced > Text Antialiasing, Advanced > Bell Notification Style, General > Tab Title, General > Tab Color (when we have tab preview), General > Icon?

Align the preview to the left

I disagree with Kayla on this one, but who knows, maybe it'll look good. She has a better eye for this stuff than I do, generally.

I think this will look bad.

Content inside the preview

People probably want to see something more like a prompt. Kayla and I came up with this...

Windows Terminal
Copyright (c) Microsoft Corporation.

C:\Windows\Terminal>  <CURSOR>

I think it'll look nice and kinda match the initial output of PowerShell/CMD.

The initial output of PowerShell/CMD is atrocious, and I see no reason for us to make that mistake again. We've been showing people how to customize
their shells for two years now, and it seems shortsighted for us to display a preview of what it used to look like in 1985.
We need to display, at the minimum: Colors. Emoji (because we will have a [disable emoji] [(x) use color emoji] switch, per user request). Italic text. Bold text (when we have bold.)
I don't care if Color is covered by the Color Schemes preview: it doesn't show up oiver a background image or over acrylic, because those aren't part of a color scheme.
All of those are not represented in the shell rpeamble.

...

[punt + feature idea?] Allow multiple customizable previews:

Realistically, we'll never be able to make everybody happy, especially when you start taking into account that some people have a powerline theme (and it might be a custom one too). Maybe we should eventually allow users to import their own preview output? Like, they can import some kind of text file that is just gets output via the preview connection, and any color changing VT sequences get handled too?
This would be a huge undertaking and is definitely off topic, but I think this is a good example of future work that we can do after this feature goes in and we get some user feedback. 😊

Hard veto. Absolutely not. There's no purpose apart from making ourselves feel accomplished.
We should make the preview as inclusive of normal person scenarios as we possibly can.

...

good job on the scrolling behavior

the preview should always be visible, so it's nice that you can just make changes and immediately see them without having to scroll up. LOVE IT!

This is incompatible with moving the preview under the pivot, as you suggested.
/cc @cinnamon, since some of the refuted opinions might have been hers

Move terminal preview to be under the pivot control/selector
This should be possible by doing the following:
<PivotItem x:Uid="Profile_Appearance">
	<Grid>
    	<Grid.RowDefinitions>
			<RowDefinition Height="Auto"/>
			<RowDefinition Height="*"/>
		</Grid.RowDefinitions>

		<Border x:Name="ControlPreview"
				Height="320"
            	Margin="8,0,8,0"
            	HorizontalAlignment="Stretch"
            	Grid.Row="0"/>

		<ScrollViewer Grid.Row="1">
			<StackPanel>
				<!-- All of the settings controls -->
		</ScrollViewer>
	</Grid>
</PivotItem

Tested it out myself, and that doesn't break the scrolling.
Now, the only question left is...

What about Advanced > Text Antialiasing, Advanced > Bell Notification Style, General > Tab Title, General > Tab Color (when we have tab preview), General > Icon?

This'll require a broader discussion on the design. Let's talk about this at our next sync meeting.
Align the preview to the left
I agree that this'll look bad too (sorry Kayla haha). But it should be a quick one-line change.
@PankajBhojwani mind making that change and sending it over to @cinnamon-msft (or even the team over email if you want). I think it's just a matter of visualizing it tbh.
Content inside the preview
This'll require a broader discussion on the design. Let's talk about this at our next sync meeting.

I seriously think the text should not be localizable. I don't want to ship with it localizable and then have to back that out. :smile:

Updates:

There is now a little tab above the control preview, where the icon and title will update accordingly (would like feedback on this if someone wants to switch to this branch and play with it)
The preview is now left aligned (it will be extremely annoying to align the fake tab with the preview without doing this)
The cursor is now always on (doesn't blink)

Here's a screenshot as of 4/19:

The preview has moved to under the appearance pivot
The preview is now inside the Scroll Viewer (and is scrollable)
The fake tab has been removed
The width has been made smaller to align with the pivot menu

I think if we want to have the fake tab/settings from the other pivots in the preview, we can figure out how to do it in a clean manner later on. For now though, I've removed all those extra things to try and get this in before the bug bash

This looks great. Probably just want to fix the width, since it's the size of the window. :)

This looks great. Probably just want to fix the width, since it's the size of the window. :)

Thats very strange, on my machine the width is the size of the pivot headers...

I just rebuilt it and it's still expanding the width to the whole window, but I won't block on it and we can fix the bug in a follow-up.

I am a bit concerned about using the TSF control's settings size here? We're a control -- we have a size of our own.

We use the control's width and height now!

What happens when the window is resized?

Nothing, the control's width and height are fixed

Please avoid hardcoding colors.

We use a system theme resource colour now :)


Renaming Files and Folder from Device Internal storage crashes the app

Expected behavior
I should be able to rename files and folder from the file manager of the device's internal storage.
Actual behavior
But the app crashes on trying to rename a file or folder from device's internal storage
How to reproduce

Install the app from playstore.
Launch the app.
Click on the "External Stoage 1" option and select root device's internal storage pathway.
Select any folder or file from your device internal storage and rename it.
The app crashes.

App Version: 1.0.2
Device: Samsung Galaxy J5
Operating System: Android 6.0.1

Recording Of The Bug
https://youtu.be/R-Y8tUAnq0U

Thanks you for trying QuicXplo i will check and fix it.


model error : lot of Role missing permissions/Role reference in iam policy not found

[ ] Which version of Forseti Security you're using : 2.25.1
[ ] Which module(s) (inventory, scanner, enforcer, explain) you're having trouble with. : inventory (role) / model
[ ] Include errors, log output, and host operating system, including installed packages.
[ ] Note how you deployed (via Deployment Manager, Terraform, local system, etc.). Terraform (with   role_enabled                = "true")

Inventory run without error, created model from inventory, got multiple of
Role missing permissions: roles/apigee.portalAdmin
Role missing permissions: roles/dataprocessing.iamAccessHistoryExporter
Role missing permissions: roles/resourcemanager.organizationCreator
Role missing permissions: roles/stackdriver.resourceMaintenanceWindow.editor
Role missing permissions: roles/stackdriver.resourceMaintenanceWindow.viewer
And a lot ~(+3000) of Role reference in iam policy not found
Checked IAM Security (ok) + tested using gcloud with service account (gcloud projects get-iam-policy) (ok).
Still cannot get roles with explainer (give nothing) but list_members work.

Sample debug output :
Expand all | Collapse all{
insertId: "32gfilchv1i9r7ri2"
labels: {…}
logName: "projects/infra-forseti/logs/forseti"
receiveTimestamp: "2020-08-27T17:59:39.015217282Z"
resource: {…}
severity: "DEBUG"
textPayload: "[forseti-security][2.25.1] google.cloud.forseti.services.dao(set_done): warnings = Role missing permissions: roles/apigee.portalAdmin
Role missing permissions: roles/dataprocessing.iamAccessHistoryExporter
Role missing permissions: roles/resourcemanager.organizationCreator
Role missing permissions: roles/stackdriver.resourceMaintenanceWindow.editor
Role missing permissions: roles/stackdriver.resourceMaintenanceWindow.viewer
Role reference in iam policy not found: roles/securitycenter.serviceAgent
Role reference in iam policy not found: roles/compute.serviceAgent
Role reference in iam policy not found: roles/compute.serviceAgent
Role reference in iam policy not found: roles/compute.serviceAgent
Role reference in iam policy not found: roles/compute.serviceAgent
Role reference in iam policy not found: roles/compute.serviceAgent
Role reference in iam policy not found: roles/appengineflex.serviceAgent
Role reference in iam policy not found: roles/compute.serviceAgent
Role reference in iam policy not found: roles/container.serviceAgent
Role reference in iam policy not found: roles/serv"
timestamp: "2020-08-27T17:59:35.593Z"
}

Seem resolved in 2.25.2


batch upsert to databases_store

Description
Upsert in database_store in batch when upserting a table
Risk
Tested locally the sanity of the query
Deploy Plan

deploy core

I'm pretty sure the query is legit since I tested locally will give it a spin to see if it reduces the latencies of upserts and the load on the databases_store DB


UTF-8 support is not present on Server side FCM/GCM push

Not able send FCM/GCM notification with characters of other languages!
Reason
In Sender class, the content type for Json is set as application/json
Resolution
Content type should be : application/json;charset=UTF-8

Closing the issue as it seems to be server side format read reading issue


Yaml include feature

Updated ami_cache.json and instancetype_to_arch.json along with the amazon linux region map generator script


Provide option to give custom events to wait for navigation

Currently goto by default waits for LoadEventFired NetworkIdle and FirstMeaningfulPaint. Provide option to wait for custom events so that user will have flexibility to choose events based on scenarios. Default event can FirstMeaningfulPaint if not overridden.

Fix available in 86ded09. Can be used like await goto("google.com",{waitForEvents:['loadEventFired']})

This enhancement has been verified with the below version.
86ded09


[FIX] Imports, Custom Bundle Loading, Refactor

DO NOT ACCEPT THIS RIGHT AWAY AND ACTUALLY TEST

The shim is working - the loading of the bundles is not. I'm not getting a console error so it's more than likely a pathing issue.

MTGA-AKI-Compatibility-Layer.zip
New Compat. Layer mod


Installing using docker-compose behind a proxy

I'm trying to install the provisioner on a server behind a proxy.
It is not functioning because, in spite the fact that I've already set the proxies variables both in the environment and also into the docker.service, while trying to download and install the images of the containers nothing is ok cause they cannot contact the github server; for instance.
Do you have any idea on how to solve that issue?
Best regards

Hi @glycerin-ce, any chance you would be able to post some logs or error messages you're seeing?
Sorry, we definitely didn't architect this sandbox with proxies in mind.

Hi @jacobweinstock .
Thanks for giving me support.
I'll attach here the logs using a fresh copy of the project.
Please tell me if is correct in this way.
d25829fa0d500f5a3165a5ba20b769f02cc6399d16a612d56f0b984c0bfce9bb-json.log
310662bff70221a1ea97b125fb053af0fe9c2b578b8320318f9920eb565be42e-json.log
9ae332e1eeebdc9945c0e703fb0637e6851a3bd7c2ad444e8c2553426a581237-json.log
docker-compose_logs.txt
25c5f300e28cfc774797ffff1f1d22806c3360d38d8604d6759e1e321f46852a-json.log
3d9b5aa8b05cb98fc1bc743bbe9c9498722f91b0a15c131401814b1f46bf52b7-json.log
d030dbc3e2d83f2e1d36ec7ccdc804ddae6c911d1d641eea0e9485522576ca80-json.log
Take in count that I have already set the proxy conf in the /etc/systemd/system/docker.service.d/http-proxy.conf.
Please. Tell me if you need more information.
Thanks in advance.

Here you are the containers:
:~# docker container ls
CONTAINER ID   IMAGE                                      COMMAND                  CREATED          STATUS                          PORTS                                                                   NAMES
d030dbc3e2d8   quay.io/tinkerbell/hegel:sha-89cb9dc8      "/usr/bin/hegel"         37 minutes ago   Up 37 minutes                   <IP_ADDRESS>:50060-50061->50060-50061/tcp, :::50060-50061->50060-50061/tcp   compose_hegel_1
8acdb91b2084   quay.io/tinkerbell/tink-cli:sha-3743d31e   "/bin/sh -c 'sleep i…"   37 minutes ago   Up 37 minutes                                                                                compose_tink-cli_1
d25829fa0d50   quay.io/tinkerbell/boots:sha-36f12f81      "/usr/bin/boots -dhc…"   37 minutes ago   Up 27 seconds                                                                                compose_boots_1
962c5416dbe0   quay.io/tinkerbell/tink:sha-3743d31e       "/usr/bin/tink-server"   37 minutes ago   Up 37 minutes (healthy)         <IP_ADDRESS>:42113-42114->42113-42114/tcp, :::42113-42114->42113-42114/tcp   compose_tink-server_1
310662bff702   registry:2.7.1                             "/entrypoint.sh /etc…"   37 minutes ago   Restarting (1) 48 seconds ago                                                                           compose_registry_1
5f9dde94d5a3   postgres:14-alpine                         "docker-entrypoint.s…"   37 minutes ago   Up 37 minutes (healthy)         <IP_ADDRESS>:5432->5432/tcp, :::5432->5432/tcp                               compose_db_1
:~#

Hi @glycerin-ce. Did you manage to debug any further? Is there anything we can assist with?

Hi @glycerin-ce. Did you manage to debug any further? Is there anything we can assist with?

Hi @chrisdoherty4 .
Thanks for posting this question.
I'm still trying to debug cause I saw that the code is still under development.
Do you are considering to add a branch line about this issue in order to let to deploy a tinkerbell solution behind a proxy?
Best regards.
Gabriele

@glycerin-ce Thanks for the ping, your message got lost in my notifications. We can consider adding an issue to address hosting behind a proxy. I can raise it in next Tinkerbell community meeting.

Happy to hear this news @chrisdoherty4 .
I hope to read more news.
Do you have any idea about a possible timetable for solving this issue?
Thanks too much.
Gabriele

Hi @chrisdoherty4 thanks for your answer.
Please may I ask if you let me know about that point after your meeting of 5th July?
Thanks in advance.

Goof afternoon @chrisdoherty4 any news after your last meeting about the project?

Hi @glycerin-ce.

Do you are considering to add a branch line about this issue in order to let to deploy a tinkerbell solution behind a proxy?

The community concluded the scope of the sandbox is a set of possible ways to deploy Tinkerbell (we're adding some commentary to the README that will clarify this). We don't have strong rules about what can or can't live here, but its typically driven by use-case contributions as opposed to maintainers adding explicit support for something. If you would like to raise a PR, we would welcome additional use-cases or adjustments to the existing code that accommodate your case.

To your original post, I haven't deployed Tinkerbell behind a proxy of any sort. Providing steps to recreate your environment might be useful and perhaps someone will be able to reproduce and provide further guidance.

No action taken.


[jsf-cdi]WELD-001408: Unsatisfied dependencies for type Map<String, Object> with qualifiers @RequestCookieMap

Hi Hantsy,
I cloned your repository and tried to run your jsf-cdi code as-is in a freshly downloaded Glassfish 5.0 (web profile). But got this error:
CDI deployment failure:WELD-001408: Unsatisfied dependencies for type Map<String, Object> with qualifiers @RequestCookieMap
That's from the class com.hantsylabs.example.ee8.jsf.BackingBean, line 36.
What am I doing wrong??
Regards,
NN

Thank you very much for the reply!
I was trying to use gradle for the build/test thing (better for buidling CI/CD pipelines later). In the JEE 8 world it's yet difficult to find definitive one-stop guide for even trivial JEE projects. For example, a hello-world JSF application example, or a hello-world REST service example. All the guides I found either start with some specific IDE or end up dealing with server/library specific configs. Yesterday I spent half day getting an JSF 2.3 toy app running on a local OpenLiberty <IP_ADDRESS>, but the Liberty gradle plugin did not really work well (I filed an issue in their official github repo). It's been very, very frustrating.
I found the Spring Boot docs extremely good in this respect. They have quality gradle plugins, I even do not need to know what server is running under the hood ( Tomcat, or Payara, or Glassfish, or Liberty, or Jetty, whatever that is, actually I don't care at all, as long as that server runs my code ). I followed a very short official Spring Boot guide, and got the latest container features setup and run within half hour.  No puzzle to solve in the gradle build file and no server mentioned in build file, it simply builds and tests.
Sorry for my nagging! If one day I figure out how to streamline the build/test thing with gradle for JEE, I'd like to write short and concise guides.
I found your code showcasing JEE 8 features very helpful! Thank you very much!
Regards,
nn

@nnworkspace I also wrote some notes about these Java EE 8  sample codes, check here.

Hi Hantsy, thank you very much for your tutorial, I find it very well written, much appreciated! Meanwhile I got the first parts of my one-case-showing-all-features application up and running, your articles are linked in the "special thanks" section in the readme file:
https://github.com/nnworkspace/crossword-gen-jsf
This project is on its very early stage, I'm adding code to it everyday.


matrix-ios-sdk uses an unspecced original_event field from the /relations response

The /relations endpoint does not return an original_event field, yet the matrix-ios-sdk uses it.
We would like to remove support for this from Synapse in < 6 months. See matrix-org/synapse#12930 for more context.

It is unclear to me if any consumers of this API actually use it:

https://github.com/matrix-org/matrix-ios-sdk/search?q=_originalEvent
https://github.com/vector-im/element-ios/search?q=_originalEvent

It is used in the SDK in MXAggregations, MXThreadEventTimeline and MXKeyVerificationStatusResolver along with EditHistoryViewModel in Element.


feat(config): add support for Wink WNK-MOT1 motion sensor

Add support for the Wink WNK-MOT1 Motion Sensor

@AlCalzone Ready to merge

The file is duplicate - see error annotation

Confirmed device already exists.


Query terminal width from STDOUT_FILENO

Rather than 0 (stdin). So it will work even if ninja's stdin isn't connected to
the terminal for whatever reason.

I've just rebased this. Any objection? Using the stdout handle makes more sense as that's where the output actually goes to. I've had reason before to redirect Ninja's stdin to /dev/null, which currently doesn't work properly because of this.

STDOUT_FILENO is 1, correct?

Yeah.

As we are using isatty(1), too, this makes perfect sense to me. Thanks for the PR!


add Weibo

m.weibo.cn/beta
the popular social network in China

if you want I'm making https://www.pwaawards.com/ and would love for you make a pr @wangshuy


False Positive on tagsoup-1.2.1.jar

False positive on library tagsoup-1.2.1.jar - reported as cpe:2.3:a:tag_project:tag:1.2.1:*:*:*:*:*:*:*
<dependency>
    <groupId>org.ccil.cowan.tagsoup</groupId>
    <artifactId>tagsoup</artifactId>
    <version>1.2.1</version>
</dependency>

What version of DependencyCheck do you use? Cannot reproduce with 6.1.3

Apologies, the plugin version was behind. Verified with v6.1.3 and no issue. Thanks a lot for looking into this, and sorry for the false flag.


1.8.1 fix

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

I want to fix tag 1.8.1 nzTooltipDirective use renderer listen DOM event, But don't use callback on ngOnDestory hook unlisten event.


Fix environment propagation

Fixes #2411
Closes #3000
Reason for the fix:

Printing array requires converting the array back to pyobject.  The process requires the Environment object (Env).
The Env is passed to the top-level jitted function by the python-to-nopython bridge.  But, it is not available to function called from within a nopython function.  As a result, array printing only works if the function is top-level.

New behavior:

Make the Env a global per compiled-user-function for both nopython-mode and objectmode.
The calling-convention is changed.  The Env used to be passed as the 3rd argument.  The Env argument is now dropped.  The first actual argument starts at the 3rd argument.
The Env is emitted as a zero-initialized i8* global variable.
When the JIT loads a compiled function into memory, it updates the Env global pointer.  The same process works for cached function as well.
When the AOT module is loaded, the module initializer updates all the Env global pointers in the module.
In the body of the emitted function, the Env can be obtained by loading the corresponding global-variable.
To obtain the Env for a particular function, one only needs to know the FunctionDescriptor, from which the name of the symbol that points to the Env can be obtained.
All Env global-variables are defined to have common linkage.  They exist and merge like C int my_global; in global scope.

Codecov Report

Merging #2986 into master will decrease coverage by 0.01%.
The diff coverage is 92.5%.

@@            Coverage Diff             @@
##           master    #2986      +/-   ##
==========================================
- Coverage   85.79%   85.77%   -0.02%
==========================================
  Files         327      327
  Lines       68422    68453      +31
  Branches     7729     7732       +3
==========================================
+ Hits        58700    58718      +18
- Misses       8483     8494      +11
- Partials     1239     1241       +2

Thanks for the fixes. Merging.


Distortion/glitching after hundreds of calls to SoundFile.play()

This is likely related to #494 but I have a minimal example with some more detailed testing. Also, a user said here that updating to chrome 92 fixed the issue but I've tested this in chrome 94 and its still there.
Version: 1.4.0
Behavior: distortion, choppiness, glitchiness of sounds after calling the SoundFile.play() method hundreds of times.
minimal reproduction
Interestingly, this issue is not present on version 0.6.1. However, 0.6.1 has a big memory leak issue on Firefox.
setups tested:
FIREFOX on LINUX MINT 20.2 on a Lenovo Ideapad 5
CHROMIUM on LINUX MINT 20.2 on a Lenovo Ideapad 5
FIREFOX on WINDOWS 10 on a custom PC (Ryzen 5 2600)
GOOGLE CHROME on WINDOWS 10 on a custom PC (Ryzen 5 2600)
BRAVE on ANDROID 11 on Samsung Galaxy A32
Really the only setup variable missing is Apple products. I don't have any ¯_(ツ)_/¯
while different setups exhibited different counts before distortion all setups eventually did distort and get worse from there. While each setup was consistent test to test initially, I did observe different counts-before-distortion day-to-day, and I was able to get the distortion to come a little earlier by opening a lot of applications and tabs on my computer. So it might be a memory related thing.
calling stop() on a file before playing it doesn't prevent distortion (though this wouldn't be ideal anyway since it would disallow a sound overlapping itself, which is kind of the point of having a library to play sounds like this)
As in #494, it was worst on mobile. Firefox lasted longer before distorting on Windows, chromium lasted longer on Linux.
I tested letting each sound run to completion before playing it again vs letting a sound overlap itself.
I also tested playing multiple different sounds at once vs playing one at a time.
I tested all four combinations of these two parameters, none of which seem to make a difference to how many play() calls were made before distortion kicked in.

Reproduces on Chrome 94 on Mac OS 11.2.3
but does not reproduce on Safari 14 Mac OS 11.2.3 (though I only could take about 2000 frames before stopping it :)

I'm seeing this bug in my game (https://github.com/zenzoa/bunbons). Has anyone made progress in fixing this or coming up with a workaround?

Seeing this as well, using Firefox 98.0.2 (64-bit), Ubuntu 20.04.4 LTS (64-bit).


Add add_project_path action

The extension didn't have any method for users to add their own projects to it manually.
I wanted to write my own project root directory finder and then add those projects to telescope. This is a good telescope project picker, but it didn't support me adding the projects I found with my own logic.

I like this. Thank you


UI doesn't update when reindexing is happening

If I try to use fuzzy-finder right after switching branches, it says reindexing. Fair enough. But if I try to type while this is happening, it takes a while for keystrokes to appear and for the results to render. It seems like the reindexing is blocking the UI thread. Any chance reindexing can happen without impacting the UI?

Seems to be fixed.


Unable to Login to Admin

Hello,
I am new to Voyager, i have installed it as you directed in the documentation, its installed successfully, but when i try to login with default credentials<EMAIL_ADDRESS>then i get following error.

Thanks,
Faraz

What version of laravel are you using it on?

same problem..

5.2, same problem.

Here is a solution for this problem..
Change in: vendor/tcg/voyager/src/Controllers/VoyagerAuthController.php
`public function postLogin(Request $request){
//dd( $this->getCredentials($request) );
$authenticated = false;
    $this->validate($request, [
        $this->loginUsername() => 'required',
        'password' => 'required'
    ]);

    // If the class is using the ThrottlesLogins trait, we can automatically throttle
    // the login attempts for this application. We'll key this by the username and
    // the IP address of the client making these requests into this application.
    $throttles = $this->isUsingThrottlesLoginsTrait();

    if ($throttles && $this->hasTooManyLoginAttempts($request)) {
        return $this->sendLockoutResponse($request);
    }

    $credentials = $this->getCredentials($request);

    if (Auth::attempt($credentials, $request->has('remember'))) {
        $authenticated = true;
    }

    if($authenticated){
        return $this->handleUserWasAuthenticated($request, $throttles);
    }

    // If the login attempt was unsuccessful we will increment the number of attempts
    // to login and redirect the user back to the login form. Of course, when this
    // user surpasses their maximum number of attempts they will get locked out.
    if ($throttles) {
        $this->incrementLoginAttempts($request);
    }

    return redirect($this->loginPath())
        ->withInput($request->only($this->loginUsername(), 'remember'))
        ->withErrors([
            $this->loginUsername() => $this->getFailedLoginMessage(),
        ]);
}`

Yes its laravel 5.2 i have checked it in laravel 5.3.* and its working fine in that version but not in 5.2
And ooocrniooo solution also worked in 5.2 but after login avatar and profile image is not showing.

you must set manually a symlink to the storage path, after that your image path will be correct.

@faraz-purelogics As @ooocrniooo suggested, try to manually set a symlink (php artisan storage:link), but make sure you run console with admin rights.

Sadly - we do not support Laravel 5.2.
Could however, if many people need this feature for Laravel 5.2, it could be implemented.

i take this error in login voyager dashbord for first time :These credentials do not match our records.
<EMAIL_ADDRESS>and password input ...help me guys thanks

@jafarchoupan, this issue has been closed for a year and a half.  Please ask for help on our Slack group instead.


Support turnip_3.0.0-beta.4

refs https://github.com/jnicklas/turnip/pull/187

Coverage remained the same at 94.724% when pulling 5c7f9c11eaa1e88db9d70d2be99e40b17e40f94c on support_3.0.0-beta4 into 249409e5388de52b5f462b6f2f304f22d6a83b39 on 0.6.0.

Coverage remained the same at 94.724% when pulling 5c7f9c11eaa1e88db9d70d2be99e40b17e40f94c on support_3.0.0-beta4 into 249409e5388de52b5f462b6f2f304f22d6a83b39 on 0.6.0.


Don't highlight text within documentation

There should not be a need to highlight text within the GOV.UK Elements documentation.
This removes all 6 occurrences of inset text used to highlight content within the documentation. Even before deprecating it, I noticed that none of it really makes any sense to highlight.
This change would be necessary if we merged #586 but also makes sense on its own.
Exact changes before and after

Bottom section of all form error example pages: before and after
Bottom note of date example: before and after
Note on examples on colour use: before and after
Bottom note on summarising errors (have also changed wrongly used heading to paragraph): before and after
Note below hidden text: before and after
Form error example page with additional guidance (this is the only case where I think it could make sense to keep it): before and after

Would it be possible to add a before / after screenshot?

I really don't think making screenshots makes sense as you would need to see everything within context. (And it would result in 12 very long screenshots.) Instead I've just listed all the relevant sections to the description and added before and after links to them.

I agree with this pull request and I think it gives some useful examples of places where inset text doesn't do anything much at all.
Will the links mentioned in this pull request (especially the 'after' ones) continue to be available indefinitely? If so, then I agree that there's no need for screenshots. If not, then please can we have screenshots, no matter how many of them or how long they are, so that they continue to be available as an example?
By the way, on this page: https://govuk-elements-review-pr-587.herokuapp.com/errors/#summarise-errors, I spotted an errant 'should' that somehow sneaked past me when we wrote this originally:
"Additionally, you should reflect that there's been an error in the  by prefixing the existing title with "Error: ". That will make sure screen readers are alerted to there being an error as soon as possible."
Two options for fixing this:

Change 'should' to 'must' (simplest)
OR
Change the whole paragraph around to avoid 'must reflect' which sounds a little awkward to me. Suggestion
"To make sure that screen readers are alerted to the error as soon as possible, you must prefix the existing title with "Error: "
(which has the merit of being shorter, too).

Failing tests are related to #589 and should be fixed by rebasing once that's merged.

Hmm, even if the 'after' links still work afterwards, it will be the 'before' that will be missing a reference, because the current version will be updated to be the 'after' version.
I guess that means it definitely makes sense to add screenshots. I will do that later.

@edwardhorsford and @timblair, is there anything in the way of merging this? If yes, what exactly?

Following the launch of the GOV.UK Design System, GOV.UK Elements will now only get major bug fixes and security patches.
I believe in this case, we deprecated inset text, but since then we have decided to continue recommending the inset text component.
Thanks for raising this originally, sorry for the lack of updates.


small text changes

Hi! I tried to edit some small text (headers). Hope this is trivial enough to skip testing.

Looking good!


Add documentation for new HttpContext JSON extension methods in 5.0

Issue describing feature: https://github.com/dotnet/aspnetcore/issues/17160
Note that there have been some minor changes to behavior between the issue and the PR
PR: https://github.com/dotnet/aspnetcore/pull/21731

@JamesNK  can you provide a draft and sample code when you have time?

[ ] Write sample using at HttpContext JSON extension methods  https://github.com/dotnet/AspNetCore.Docs.Samples
[ ] Update Doc with samples.

@JamesNK  please suggest where this should be documented.

I don't think this is needed anymore.


Implement tags feed (media with specific tags)

This PR implements tags feed function.
Tags feed is used to get media with specific tags in captions.

There's already feed function named tag, which lists up tags for autocompletion. "feed.tag" and "feed.tags" might be confusing but I couldn't think of a better name than "feed.tags".
This function is very similar to location feeds. I reused a lot of code from location feeds so a lot of code could be refactored.
Unlike location feed, tags feed has a full_width layout type section for the top area. I didn't implement this.

Feedbacks are welcome.

@dilame could you review this, please?

Looks good enough to me, thank you, @deopard and sorry for late merge.


Python3 bencode()

Hello,
Looks like python3 support remains problematic.
Opening a torrent fails with UnicodeDecodeError with something as simple as:
t = open(torrent_path,'rb')
t_ = libtorrent.bdecode(t.read())
My version of libtorrent: 0.16.17
There is a ticket on google code but I wasn't able to post a comment, I can't sign up because of a bug in google code. Pretty annoying. Apparently you thought this bug was resolved. I do not think it is the case.
Best,
Michaël

Has there been any progress on this issue? I'm seeing the same thing in python 3.6.
The specific error I get is:
e = lt.bdecode(open('sample.torrent', 'rb').read())
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x85 in position 1: invalid start byte

which version of libtorrent are you using? and please make sure you're using the one from the main repository, under arvidn/libtorrent
In fact, if you're still seeing an issue with the latest release (1.1.2) please post an issue in that repo.


fix inverted coords and test

This PR supersedes theislab/scanpy#1149 and closes theislab/scanpy#1148 and theislab/scanpy#1059
I have changed couple of if statements from previous version, now it plots circles and not scatterplot.

Yes, I understand the point and agree. Now coordinates are inverted whenever basis='spatial' but circled are plotted only when library_id is not None, which is passed by sc.pl.spatial to embedding. Otherwise, scatterplot is used

Can I merge this ?

@giovp, I'll merge this. I'm merging a couple other things first though.
I'm not super happy with the logic flow here at the moment. Could we aim for separating out the code for scatter plots, and overlaying grids on-top of images in the next release cycle?

Yes for sure


GVST: init at 0.0.1-beta

Collection of free audio plugins
Contains the following plugins:
Effects

GBand - Band-pass filter.
GChorus - Chorus effect.
GClip - Wave-shaping signal clipper.
GComp - Compressor.
GComp2 - Compressor.
GDelay - Delay effect.
GDuckDly - Ducking delay effect.
GFader - Signal gain (-100 to 0 dB).
GGain - Signal gain (-12 to 12 dB).
GGate - Gate.
GGrain - Granular resynthesis.
GHi - High-pass filter.
GLow - Low-pass filter.
GLFO - Triple LFO effect.
GMax - Limiter.
GMonoBass - Bass stereo imaging effect.
GMulti - Multi-band compressor and stereo enhancer.
GNormal - Noise generator for avoiding denormal problems.
GRevDly - Reverse delay effect.
GSnap - Pitch-correction.
GTune - Chromatic tuner.

Instruments

GSinth - Mono synth using three continuous portamento sine generators.
GSinth2 - Extends GSinth by adding triangle, square and saw-tooth wave.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 96190 run on x86_64-linux 1


tour: Missing documentation on "Named Return Values"

Context: https://tour.golang.org/basics/7
The tour for "Named Return Values" doesn't mention a crucial, yet short, piece of information that is documented in the golang spec (https://golang.org/ref/spec#Return_statements).

A "return" statement that specifies results sets the result parameters before any deferred functions are executed.

So perhaps an additional example that is worth while to show is something like:
package main

import "fmt"

func split(sum int) (x, y int) {
	defer func(){
		fmt.Println(x, y) // prints 5, 6
	}()

	x = 2
	y = 3

	return 5, 6
}

func main() {
	split(17)
}

Without testing this myself (and then looking for it in the spec), I was doing redundant things like this:
func boomer(num int) (err error) {
	defer func(){
		// defer logging, metrics, etc. until the end
		if err != nil {
			println("log")
		}
	}()

	if num == 0 {
		// redundantly set err first
		err = errors.New("boom")
		return err
	}

	return nil
}

Also, for what it's worth, the spec statement on this is a little confusing on first read.

Defer has not yet been introduced at that point, so mentioning it would be quite confusing. The tour (especially the first lessons) are meant to be read by beginners, and in general it tries really hard not to confuse readers with information that is not absolutely necessary.
Closing here, since I believe it would be better not to mention this in that lesson.


block coinbase  spec

this PR depends on https://github.com/appliedzkp/zkevm-specs/pull/77 to add block coinbase op code spec with test.

@lispc @HAOYUatHZ Could you help take a look at the spec PR?

LGTM

So I actually review it again. This PR in general looks good. just would like to learn about the answers to my 2 questions.

For no miner or difficulty condition, return zero as placeholder, as there are no more other constrains except stack bussmapping & lookup .

close this one as a PR has been created to upstream


Print the name of the conflicting inventory on conflicts

If there is a conflicting inventory that can be resolved by the provided inventory policy, we currently just print an error message that there is a conflict. We should print the name/namespace of the inventory objects with conflicts.

The current error message is indeed confusing and hard to debug: #3373


Mint Login Broken Since Mint Refresh

I am using the latest release. I usually fetch the report but in my last attempt re-used the one already downloaded by the app.
Issue:

I enter my credentials for login but the tagger get stuck on login to mint and eventually times out with the error - cannot log into mint
Despite the error, I am fully logged in when this happens.

Any suggestion? I tried to do the "I will login myself". I checked I have the latest Chrome update. Looking for ideas!

Hi @ovitch! You're not crazy; it seems that Mint has changed the login flow. I've made some initial improves and published it as version 1.44. Give that a shot and see if it gets you going again. Any input is helpful, thanks!

@jprouty thank you for your comment. Still gets stuck. I wonder if this would work in a private window.
When login in I get the intuit account selector (the intuit SSO). Then password (with option 2FA), then loading in the platform.
It seems they made several improvement on the platform too so maybe there is more to it.
Did you succeed to run in on your end?

@jprouty Here is my testing so far

logging manually: idle in logging to mint even after I complete the process
logging automatically: have to interact with Chrome to click on the profile.

Either one end up in the same loop. The script doesn't realize I am logged in and cannot move to the next step.
Additionally, it seems the refund file structure from Amazon is different from the past (see other issue raised)

I'm having a similar issue, though there may be more going on.
Here's the output from the ChromeDriver:
DevTools listening on ws://<IP_ADDRESS>:16567/devtools/browser/91027118-c68b-4878-ba7e-f6fe26b54782
[728:22416:0604/195417.975:ERROR:device_event_log_impl.cc(214)] [19:54:17.975] USB: usb_service_win.cc:104 SetupDiGetDeviceProperty({{A45C254E-DF1C-4EFD-8020-67D146A850E0}, 6}) failed: Element not found. (0x490)
[728:2784:0604/195512.648:ERROR:util.cc(127)] Can't create base directory: C:\Program Files\Google\GoogleUpdater

Hi @jprouty
Great looking tool!
I'm having the same issue with v1.44 FYI

Thanks for all of the details / reports! The new Mint version requires a moderate rewrite on the mint client for the tagger. I'll get to this within the next 48 hrs.

Yes, please retry with release 1.45 and report back here. Thanks for your patience.

@jprouty just wanted to give a heads up that we've done a good amount of rewrite for Mint's new UI over at https://github.com/mintapi/mintapi.  It seems to be a constant battle as little tweaks have been necessary just about every week.  Feel free to use whatever if it's at all helpful!

Thanks for the heads up @burkematthew. I split ways with mintapi back when it was still v1, due to unwanted dependencies and a slow release cadence that didn't always result in fast enough update to unbreak this tool. However, it looks like v2 is a big improvement, with more active contributors. I will take another consideration if this continues to be an issue.
@ovitch, Please reopen if you are still having login issue. The flow is working for me and I have included a few tweaks as of release 1.53. Cheers.


Added support for handling Politician CTCL data in import_export_batches

Defined BatchRowActionPolitician table  and added ctcl_uuid to Politician master table
Added functionality to process politician ctcl data in import_export_batches and templates

Thank you @mnneelam! 👍


Snackbar Text Visibility Issue in Dark Mode on About Page

On the About page of our GitHub repository, when copying the repository link to the clipboard, a bottom snackbar appears with text that is not visible in dark mode. This creates a usability issue as users are unable to read the text displayed in the snackbar.
Expected Behavior:
The text in the snackbar should be visible and easily readable, even in dark mode. It should have sufficient contrast with the background to ensure optimal visibility.
Steps to Reproduce:
On the phone dark mode.
Navigate to the About page.
Copy the repository link.
Observe the bottom snackbar and notice the lack of text visibility.
Suggested Solution:
Apply appropriate styling to the snackbar component, ensuring that the text color in dark mode provides sufficient contrast for clear visibility.
ScreenShot:

Please assign me this issue, I am a GSSOC'23 participant and would love to work on this issue

Sorry,this issue has been already taken care by @BhavaniSaranga12 .