iox-#1566 Replace QAC++ suppressions with Axivion AUTOSAR suppressions

Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
[x] Assign PR to reviewer

Notes for Reviewer

Replace QAC++ suppressions with AUTOSAR suppressions using Axivion

Checklist for the PR Reviewer

[x] Commits are properly organized and messages are according to the guideline
[x] Code according to our coding style and naming conventions
[x] Unit tests have been written for new behavior
[x] Public API changes are documented via doxygen
[x] Copyright owner are updated in the changed files
[x] All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
[x] PR title describes the changes

Post-review Checklist for the PR Author

[x] All open points are addressed and tracked via issues

References

Closes #1566

Please add an entry in the changelog

@dkroenke

Please add an entry in the changelog

As these changes are not relevant for the user API (just some comments got removed), I would vote for omitting a release note entry just for that. What's for sure worth a release note entry is the clang-tidy and AUTOSAR fixes. I would suggest to add this shortly before v3.0 is released. I'll add this to #1295, ok?


Key Generation Wizard UX improvement

Describe your problem(s)

Token Type  options are not visible,

Describe your solution
Since the number of options are low its better to always display them with radio buttons.
How will you implement it
Use radio buttons instead dropdown for options less than 6

As of 3.2 release the toke type is only JWT we can close this issue.


Fix wrong comment on enableAsyncWorkflowConsumption dynamic config

What changed?
Key name should have been worker.enableAsyncWorkflowConsumption but was system.enableAsyncWorkflowConsumption.

Pull Request Test Coverage Report for Build 018f3a1f-73b3-43a5-bfd7-bf52dcb292f1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
59 unchanged lines in 11 files lost coverage.
Overall coverage decreased (-0.02%) to 68.083%

Files with Coverage Reduction
New Missed Lines
%

service/matching/taskReader.go
2
83.55%

common/task/parallel_task_processor.go
2
93.06%

common/util.go
2
91.78%

service/matching/matcher.go
2
91.41%

service/history/execution/mutable_state_util.go
2
78.52%

common/persistence/historyManager.go
2
66.67%

common/task/weighted_round_robin_task_scheduler.go
3
87.06%

common/persistence/statsComputer.go
3
96.07%

service/history/task/fetcher.go
4
85.05%

service/history/execution/mutable_state_task_refresher.go
17
56.65%

Totals

Change from base Build 018f3600-6fcf-45e7-b48b-9de2fc42208d:
-0.02%

Covered Lines:
99982

Relevant Lines:
146853

💛  - Coveralls


Support for TTLs

First off...THIS IS AWESOME!  I've been dreaming about this for a while, and then found you've already done most of the legwork! :)
It would be cool to see a lock expire based on supplied TTL...and/or, a method to update the TTL of an existing lock -- basically, I'd like the "dead-man's switch" model...

@stensonb, sorry for the delay :cold_sweat:
Perhaps the zookeeper_bridge_sem resource does not cover your use case, but I think it works as expected. I mean, the purpose of a semaphore is to control how many processes can access to a resource at the same time. And that's just what that resource does. Nothing more, nothing less.
To manage errors inside semaphores, I think you should combine them with other resources, like locks or waits. Maybe we should implement a resource like zookeeper_bridge_signal to notify zookeeper_bridge_wait (or zookeeper_bridge_sem?) and use it to signal the other processes when there are no errors.

(I understand this discussion has now diverged wildly from the original "TTL" question...maybe I'll move this to the wiki)

I think this place is better than the wiki for discussions. But you can add to the wiki whatever you think appropriate.


Faster extension field multiplication

This PR improves latency and throughput of multiplication in extension fields by delaying the reduction in the calculation of each coefficient of the result until the very end. The performance improvements on my machine (Intel i9-11950H @ 2.60GHz) are as follows (table entries are raw nanoseconds reported by cargo bench for 100 iterations and conversion to cycles is in parens):

Ext. deg.
Latency

Throughput

Before
After
Improvement (%)
Before
After
Improvement (%)

1
388 (10)
388 (10)
--
146 (3.8)
146 (3.8)
--

2
1024 (26.6)
908 (23.6)
11
712 (18.5)
613 (15.9)
14

4
4054 (105)
3406 (89)
16
3150 (82)
2344 (61)
26

5
5204 (135)
4192 (109)
19
4441 (115)
3296 (86)
26

Unfortunately, the same trick applied to squaring causes problems with latency. Based on profiling data, the reason seems to be that the delayed reduction code increases register pressure to the point that registers are spilling into the L1 cache. There also seem to be L1 loads blocked by store forwarding. Neither of these make much sense to me, since, morally speaking, the amount of code/register pressure should be less than before. Next step would be to investigate the code generated by the compiler to see if it's doing something stupid, but I'll hold off until it becomes a higher priority. The branch implementing squaring is hamish/faster-extension-field-squaring and the associated issue is #507.
It's probably worth noting that the register spilling mentioned above was already happening for the multiplication code (i.e. before this PR), so if we can work out what triggered the register spilling in the squaring case, we might be able to use that info to improve the latency across the board.
@wborgeaud: I'm not entirely convinced that the choice of file/directory for this code is right; happy to hear your thoughts on any cleaner ways to arrange things (as the original author of the extension field code).

@wborgeaud: I'm not entirely convinced that the choice of file/directory for this code is right; happy to hear your thoughts on any cleaner ways to arrange things (as the original author of the extension field code).

I think it looks good like it is. Another option would be to have a module field/src/goldilocks_field/ with the base field-related code in mod.rs and your extension field code in extension_field.rs. Not sure it's better though, so I'll let you decide which one you prefer.

so much code for multiplication but i deserve to be reviewing this after everything i've sent your way

I'm not convinced that extension_field should contain Goldilocks-specific code. Before this PR, the extension_field mod did not know about any specific field (although fields knew about extension_field). Adding Goldilocks-specific code to that mod means that we will have a two-way dependency, which I'd rather avoid. This can be easily fixed by just putting the file somewhere else.

Good call. I've moved this and all other code relating to Goldilocks extension fields into fields/src/goldilocks_extensions.rs. Let me know if you see a better option.


Added switch to allow sorting of numeric strings

My first pull request. I hope everything is in order :)

@fmquaglia Can you merge this into master since this is really helpful?

Hi @toastermagic , @fabian-markaban
Thanks for the PR. I am very sorry this took so long.
I am seriously overworked.
Would you guys like to contribute to the project?

@toastermagic your improvement is great although I think we could do better in the code level. I'll be trying to refactor/simplify the logic, while having the same functionality.


Stop messaging after disconnect

Having this state machine feels dirty to me. Would be nice if we could encapsulate it somehow. However, that isn't a blocker for this PR.

and I have been working on adding one similar one elsewhere :D. yah, I need to think if we can get rid of these


boolean --no-flags

Is there an easy way to provide flags like cp does?

-T, --no-target-directory
        treat DEST as a normal file

The problem in my view is the requirement of an alias for a --no-… flag.
I've tried the following, with limited success (parsing ['-T'] works like expected):
require('yargs')
    .boolean('T')
    .alias('T', ['no-target-directory'])
    .parse(['--no-target-directory'])

{ _: [],
  T: false,
  'no-target-directory': false,
  noTargetDirectory: false,
  'target-directory': false,
  targetDirectory: false,
  '$0': 'node' }

require('yargs')
    .boolean('no-target-directory')
    .alias('no-target-directory', ['T'])
    .parse(['--no-target-directory'])

{ _: [],
  'no-target-directory': false,
  T: false,
  noTargetDirectory: false,
  'target-directory': false,
  targetDirectory: false,
  '$0': 'node' }

@schnittstabil as you might already know, --no has a special meaning in yargs, reversing whatever argument it is the suffix for., so --no-foo will result in argv.foo = false.
To get the behavior of cp, we could look at how hard it would be to add this syntax:
require('yargs')
    .boolean('T')
    .alias('T', ['--no-target-directory'])
    .parse(['--no-target-directory'])

I would expect the output of this to be:
.parse(['--no-target-directory']) -> ['target-directory': false, targetDirectory: false]
.parse(['-T']) -> ['target-directory': false, targetDirectory: false]

@bcoe Oh, I think I oversimplified the code above. I'm seeking for a mixture of boolean, alias and default calls, such that:
var yargs = require('yargs').
    //…
.parse(['--no-target-directory']).targetDirectory; // is falsy
.parse(['-T']).targetDirectory; // is falsy
.parse([]).targetDirectory; // is truthy --- but equals to undefined, with the code above

It does not need to be targetDirectory, but also T and noTargetDirectory does not seem to work.
Because of the special meaning of --no, I wouldn't have difficulties with:
var yargs = require('yargs')
    .boolean('T')
    .alias('T', ['--no-target-directory'])
    .default('target-directory', true)

yargs.parse(['-T']).targetDirectory; // but sadly this equals to true

I was gonna open an issue similar to this, I just want to document the not version of a flag that defaults to true, for example having --colors defaulting to true in the help is not very informative, what you want is the --no-colors flag. By the time being I am using examples to have a better users experience.

In yargs 4.x, you can now turn various parsing features on and off:
https://github.com/bcoe/yargs/blob/4.x/README.md#configuration
Give it a spin by installing the next tag of yargs:
npm i yargs@next

Many thanks, boolean-negation: false is a very clean and elegant solution :+1:


Role Support

Added Mesos role support to the cassandra framework.

Worked on this collaboratively with @ritazh
Thanks!

Thanks for this @VenkateshSub and @ritazh I'll get this merged soon.

@VenkateshSub can you rebase is against rewrite? If not let me know and I can do it in another branch and then merge it but it won't be as clean for me.

Sure! Let me spend sometime on this later today and get back.
Thanks
Venkatesh
Cell#<PHONE_NUMBER>

On Mar 10, 2015, at 10:38 PM, BenWhitehead<EMAIL_ADDRESS>wrote:
@VenkateshSub can you rebase is against rewrite? If not let me know and I can do it in another branch and then merge it but it won't be as clean for me.
—
Reply to this email directly or view it on GitHub.

Awesome thanks!

Ben, Sorry just found sometime today to wrap this.
Merged the code with the latest branch. But now I wonder, I probably should have done rebase right? Let me know what you feel, I can probably remove the latest commit and try to rebase it.
Thanks!

@VenkateshSub yes, please rebase rather than just merging up.

Yep, I have rebased the code now! Feel free to let me know if you would like me to add a test :)

Thanks @VenkateshSub


Is there a plan to make Microsoft Graph objects standard and not require experimental features enablement?

Is your feature request related to a problem? Please describe.
I am wondering if there is a plan to remove the need for the experimental features configuration that is required to access the "microsoftGraph" provider?

Not sure if you are asking two questions here @masonwolff?

Remove the need to specify the experimental feature config to use the microsoftGraph provider?
Remove the need to even specify the provider or extension statement (extension to be added in the upcoming v0.29 Bicep release - see https://github.com/Azure/bicep/issues/14374)?

For 1: yes, we plan to remove this requirement, once the Bicep "extensibility" feature comes out of preview.
For 2: we have discussed whether this statement is required or not, if the resource declarations already have the Microsoft.Graph namespace.  I think this one is still TBD, and the provider`extension` statement is still required for now.

@masonwolff Have I answered your question?  If so, please go ahead and close this issue.


Desktop: Add Icon type

it is basically a rewrite of the GIcon serialize implementation
that Notification/Dynamic Launcher expects
Fixes #56

This was merged already


Serializable Consumer Configuration

Serializable Consumer Configuration
Builder added ability to create a ConsumerConfiguration from json.

Thanks @scottf .
The changes look solid.
Please ensure the tests cover all possible configurations, including edge cases, for both serialization and deserialization. We can include tests for error scenarios such as handling invalid JSON input.
Once its merged, I can refactor the connector code to use this instead of what we have used now.

Please ensure the tests cover all possible configurations, including edge cases, for both serialization and deserialization
What edge cases? If the json is invalid, it will throw a parse error. Also since I run the json through the builder invalid data should be caught there but...
I don't think it's necessary to handle edge cases. The expectation is that the json comes from the objects' toJson method so should never be invalid.
Is there something I am missing?

Okay, then it should be pretty much covered @scottf.
Looks good. 👍

It's impractical to make configuration object serializable because it would make any changes like an addition of a field NOT backward compatible because the serialVersionUID would change, versioning the entire class, requiring a semver major version.
So instead,

relevant classes are ensured to be JsonSerializable if not already
builders are modified to accept json.
wrapper classes have been added that use the json to serialize and deserialize

thanks @scottf for this.
we won't have to use proxy pattern for each field now.
will refactor our connector code and be back with you.

got these warning when I tried to build Maven locally, mostly due to missing Javadoc comments.

Task :javadoc
ConsumerConfiguration.java:697: warning: no @param for json
public Builder json(String json) throws JsonParseException {
^
ConsumerConfiguration.java:697: warning: no @return
public Builder json(String json) throws JsonParseException {
^
ConsumerConfiguration.java:697: warning: no @throws for io.nats.client.support.JsonParseException
public Builder json(String json) throws JsonParseException {
^
ConsumerConfiguration.java:704: warning: no @param for v
public Builder jsonValue(JsonValue v) {
^
ConsumerConfiguration.java:704: warning: no @return
public Builder jsonValue(JsonValue v) {
^
ConsumerConfiguration.java:650: warning: no @param for cc
public Builder(ConsumerConfiguration cc) {
^
BaseConsumeOptions.java:124: warning: no @param for v
public B jsonValue(JsonValue v) {
^
BaseConsumeOptions.java:124: warning: no @return
public B jsonValue(JsonValue v) {
^
8 warnings

got these warning when I tried to build Maven locally, mostly due to missing Javadoc comments, @scottf
Warnings right? I'll; fix the java doc, thanks


Use HKEY_LOCAL_MACHINE instead of HKEY_CURRENT_USER for eBPF store.

Describe the feature you'd like supported
eBPF store currently uses HKEY_CURRENT_USER. This registry hive can be accessed by non-admin users.
Change eBPF store to use HKEY_LOCAL_MACHINE instead which requires admin privileges for edit.
Proposed solution
Use HKEY_LOCAL_MACHINE instead of HKEY_CURRENT_USER
Additional context
No response

Based on discussion in triage 12/4/2023 we should be able to just use HKCU now that we have a hash over program info.
And ebpf store km can then be removed.

KM store APIs have now been removed completely, and user mode APIs use HKCU. Per discussion in triage meeting, using HKCU is fine as it is only used for offline verification, and it should not be a security concern.


Button remotes do not trigger

Button remotes got added in the latest test version but they do not seem to work properly. Upon pressing a button it does not trigger the flow card actions. I would help you debug but the code isn't updated in the SDK3 branch on Github to support the remotes

Hi there. I'm waiting for a button to arrive in the mail, will fix this asap when it does. I think t's the action handling/bindings that are wrong but it's hard to troubleshoot without the units. Hmm, if I have not already I'll make sure latest updates get synced.

Should now be fixed, and github is updated.
Battery info is currently not supported.


Support making standalone container and node admin RPMs

Support for:

Making standalone JDisc container RPM, including script to start (and eventually stop) based on start-configserver.
Making standalone Node Admin RPM, including script to start (and eventually stop)

@aressem for RPM-related changes, e.g. .spec files.
@arnej27959 for jdisc-container and node-admin scripts.
@gjoranv for the list of dependencies in vespa-jdisc-container.spec. It would be nice to somehow get this list of dependencies from an authoritative source, as discussed. Alternatively, all target/-jar-with-dependencies.jar and target/dependency/*.jar files could be included, but it would raise the size of the RPM from about 75M to 325M, which I would like to avoid for now. I'm thinking a simplification can be done later if it actually is needed.
FYI @smorgrav

ping @arnej27959

i'm also worried about you setting VESPA_USER.  is node-admin going to control docker containers including starting stuff inside them? docker-api has the "executeInContainer" method which uses getDefaults().vespaUser() which again uses VESPA_USER.

looks good to me now

@aressem I'll assume you're fine with my response to your comment

👍


Make project file resolution from URIs dependent on rootUri

Currently the project file resolution ignores the rootUri sent during initialization. Using it would help resolve issues with nested projects.

Closed by #29.


Fix inline JSON struct tags. These were originally reported by staticcheck, but staticcheck master has been fixed.

These were originally reported by staticcheck, but staticcheck master has been fixed to account for openapi-gen mis-using the json struct tags.

thanks @dominikh

closes #194


self-host all external fonts

instead of referencing external domain resources and include google fonts we should self-host those and have no foreign domain requests

I was trying to get some performance metrics for what Google is shipping, but it seems that the behavior varies quite a bit depending on who is accessing the site. Logged into my Google account in Chromium, and disabling the cache, I get a 20K download. When caching is enabled, the CSS URL sends a truncated version. An Incognito window receives a 15.2K download, and an extended version of the CSS file. Why this results in a smaller download, I am not entirely sure.
On-disk, the provided ttf is 213K for the Regular variant. Chromium receives the font in Google's .woff2 format. Gzip can take the on-disk size down to 110K, and woff2 takes it down to 58K.
That all to say that Google is very clearly selecting a subset and serving a converted version based on the user's browser information.
What, if any, of these actions would we like to replicate? The Apache license would cover converted subsets of the font, should we want to go that route. The Google sites have a bit of per-platform variance that we could replicate.
Considering we are not relying on any special glyphs, though, I am of the opinion that we should just fall back to the user's default and be done with it, since they'll almost assuredly have the Unicode coverage we need.

Well while all you said is right i still think its a bit of premature optimization and we can just rely on cache doing its job. TBH I don't care much about initial uncached page hit when we are just speaking about some K and i still like my bikeshed neatly shaped :yum:
I think just supporting woff and woff2 is sufficient, it covers a wide range of stuff including android 4.4+, iOS 5.1+ and even IE9+. We will also just need regular and bold variants, no special granularity is needed. So taking into account that we only want woff and woff2 i pretty much think we can get around any per-platform dynamic switching and just have a single font-face. we can revisit optimizations if we really run into some "problems".

Alright. I will convert the Google-provided ttf for regular and bold to woff and woff2 and add those to app/static/font. Do we want to ship the more extensive CSS file that Google sends to Incognito users as our default? I can add what that contains to style.css.

cool, can you clarify what you mean by more extensive css file? We don't really need differentiate like Cyrillic, shouldn't a single @font-face that has both, the woff and woff2 be sufficient?

That should be fine for our needs, yeah. I was just referencing the incognito version versus the logged-in truncated version. I do not think we need that for anything, though.

We have Google's upstream project for woff2. Is there a recommended/preferred ttf to woff converter out there?

@pid1 i have no clue about existing ones. I googled a bit some time ago and found some converter... but maybe it is also just a downloader from fonts.google... no clue... guess you need to make some research or find someone with experience getting woff :yum:

I've used the official woff tools (AUR woff2-git) to decompress woff2 to ttf and then aur/ttf2woff to convert the ttf to woff format.


Broken link on README.md

This link no longer works: https://facebook.github.io/react-native/docs/sample-application-movies.html

There are lots of documentation links that are broken over version updates. If you know the correct link, I'm sure Facebook team working on React native will appreciate a PR.

OK I just put up a PR to fix this at https://github.com/facebook/react-native/pull/12270 . Since this doesnt seem like the sort of rocket science we need an issue to discuss on, I'm going to close this issue ;-) Thanks for reporting it!


Changing gamemode requires map reload

Currently users need to manually select a map, even if they want to play on the same one, when changing gamemode. Gamemode changes don't apply properly until a map reload so this must be incorporated into the changing of a map.
Mod should prompt after gamemode is selected:
Switch Maps?

Change Map
Stay on this map

If option 1, execute practisemode's .map command to bring up the list of maps so the player can select one. If option 2, use the .map command to reload the current map (gamechange will need to know this information, unless there is a way to reload the map without calling its name again)

Labelled as bug because the core workflow of the mod is not operating as expected

Gamble said this is working correctly now - the menu with the appropriate options appear, and the map changes or refreshes successfully.


Support virtual workspaces

👋 Hi there, Martin here, from the VS Code team.
Recently we've announced the Remote Repository feature that lets you browse and edit files and folders directly on GitHub.
Open Remote Repository... opens VSCode on a folder or workspace located on a virtual file system. We call this a virtual workspace. We observed that not all extension support this well, either because they can not, or they haven't thought about it.
It would be fantastic if you could test whether your extension can handle virtual workspaces:
Check out the Virtual Workspaces Extension Author Guide on how to do that.
When done, set the new virtualWorkspaces capability in your 'package.json'.
{
  "capabilities": {
    "virtualWorkspaces": true | false
  }
}

Use "virtualWorkspaces": true if your extension is prepared for virtual workspaces
Use "virtualWorkspaces": false if your extension should be disabled when a virtual workspace is opened

For questions and comments please use the Virtual Workspaces Tracking Issue.
Thanks for the support and the great work! ❤

Thanks for adopting the virtualWorkspaces capability!
It's now also possible to give a description why the capability is enabled or disabled:
{
  "capabilities": {
    "virtualWorkspaces": {
      "supported": false,
      "description": "Debugging is not possible in virtual workspaces."
    }
  }
}

{
  "capabilities": {
    "virtualWorkspaces": {
      "supported": "limited",
      "description": "In virtual workspaces, resolving and finding references across files is not supported."
    }
  }
}

This message can be seen in the extensions view:

A added a description

I forgot to mention that this requires 1.57 (insiders).

Thanks, not published yet.


Option to CC the user and default GDPR text

Hi @novafacile, Happy New Year.
I was making a few changes elsewhere and noticed I had these changes sitting in my local fork and wondered if you'd like to have them.

Added option to CC the user the message that was sent.
Added default GDPR text as 'gdprPolicyText' = 'By filling the in above field and clicking on the send button you have consented to your supplied information being transmitted to us via email.No personal data is stored within this website.'
some trailing whitespaces removed

Hi @BlakesHeaven,
thanks a lot for your input! Currently I'm rewriting the whole plugin. I will include your idea with cc receiver.
Unfortunatly I can't implement the prefilled gdprPolicyText. The legal text must be created by the user of the plugin for legal reasons and risks.

Hi @BlakesHeaven,
thanks a lot for your input! Currently I'm rewriting the whole plugin. I will include your idea with cc receiver.
Unfortunatly I can't implement the prefilled gdprPolicyText. The legal text must be created by the user of the plugin for legal reasons and risks.


Subheadings in the navigation menu don't work

Hi, the navigation menu on the left side of generated docs works only on the H1 level. It doesn't scroll when you click on the subheading even though url changes. On the other hand if you click on the subheading itself in the docs (the main part) it works. When you scroll, subheadings are not getting marked as active, but when you click a subheading and then reload, that subheading gets active styling.

Yup, I second that, here's an example here : https://aymeric-giraudet.github.io/tsuurukitto/src-components-alert-alert#properties

mark,me too.


Create Permutation of string in C++

🛠 Issue (Number)

Issue no #249
👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Please @Durgesh4993 get the issue assigned and then start working on that issue


feat(workspace): Add a command to migrate existing regular vaults into self contained vaults

This PR adds a new command which can migrate existing vaults into self contained vaults. The command only supports regular vaults, no seed or workspace vaults, which can be supported on a later iteration. The prompt will only display vaults that can be migrated.
Docs: https://github.com/dendronhq/dendron-site/pull/498
Dendron Extended PR Checklist
Code
Basics

[x] code should follow Code Conventions
[x] circular dependency check: make sure your code is not introducing new circular dependencies in plugin-core.  See Avoiding Circular Dependencies.
[x] sticking to existing conventions instead of creating new ones

eg: if configuration for utilities are already in one module or package, add future utilities there as well

Extended

General

[x] check whether code be simplified
[x] check if similar function already exist in the codebase. if so, can it be re-used?
[x] check if this change adversely impact performance

Operations

[x] when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?

Architecture

[x] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

eg: making changes to DNode

Instrumentation
Basics

[x] if you are adding analytics related changes, make sure you Document changes in airtable

Extended

[x] can we track the performance of this change to know if it is successful?

eg: see usage for export pod

Tests
Basics

[x] Write Tests
[x] Confirm existing tests pass
[x] Confirm manual testing
[x] Common cases tested
[x] 1-2 Edge cases tested
[x] If your tests changes an existing snapshot, snapshots have been updated

Extended

[x] If you are adding a new language feature (graphically visible in VS Code/preview/publishing), an example is included in the test workspace

CSS

[ ] display is correct for following dimensions

[ ] sm: screen ≥ 576px, eg. iphonex, (375x812)
[ ] lg: screen ≥ 992px
[ ] xxl: screen ≥ 1600px eg. mac (1600x900)

[ ] display is correct for following browsers (across the various dimensions)

[ ] safari
[ ] firefox
[ ] chrome

Docs
Basics

[ ] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Basics

[ ] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop
Basics
Extended

[ ]  is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

eg. breaking dev change due to new dependency

looks like a build error

there's an issue with how we do the migration. a regular workspace has the following setup

- Dendron
    - dendron.yml
    - vault
        - note1.md

when we migrate the vault, we end up with the following configuration

- Dendron
    - dendron.yml
    - vault
        - dendron.yml
        - dendron.code-workspace
        - notes
            - note1.md

this makes sense if the user has multiple vaults but is confusing in the common case (user has a single vault to their workspace). for the sake of iteration, lets launch it but also highlight it in the docs. can we also have a followup to automatically take care of the common case of a workspace with a single vault?

this looks good. can you merge and follow the new merge process in [[Async Update to Pr Merge Process|dendron://private/user.kevin.journal.2022.05.20.m.async-update-to-pr-merge-process]]?
also, this command introduces a new analytics point (the MigrateSelfContainedVaults command). can you add this to upcoming metrics in airtable?


Exercises

Most of the notebook content on the more interesting systems (e.g. pentapeptide) are in the form of exercises. Is that what is wanted in LiveComs?
I am not sure if this is ideal. This way we show everything on the most boring system and ask the user to do the interesting stuff themselves. OK in a live PyEMMA school, but I haven't seen that in an online tutorial.

I believe we should use the most simple (boring) systems for showcasing because they do not add complexity when learning the API.
The pentapeptide is more challenging than the double well and alanine dipeptide, but the exercises only ask for repetitions of tasks which have either just been shown (on a simple system) or used several times before in other notebooks. Do you think that using the pentapeptide here would distract too much?

Following up in yesterday's discussion, we will use the pentapeptide example in an exercise-free showcase notebook and remove it from the other notebooks wherever possible.
The alanine dipeptide example will continue to have exercises.


Add documentation generation

It would be useful to be able to generate Sphinx documentation for programs using cli_command_parser Commands.

Done: https://dskrypa.github.io/cli_command_parser/documentation.html#restructuredtext


Generate sourcemap to source files

When merging multiple files into a single file, is it possible to generate sourcemaps to point to the original files?

It is not possible, I think. because we need to regenerate the source map after merging.

Thanks, I was able to do it by replacing rollup-plugin-copy-merge with a custom plugin using MagicString


deleted LICENSE

Imagine that's following the livestream, glad you actually did it!

I will be out of the office from July 12 to July 16.
If you need immediate assistance, please contact Schuyler Bush - @.***


New installation: API field to toggle atomic upgrades

Description
In a normal upgrade, if components can't be upgraded, the installation library will rollback. This can be problematic in non-productive clusters if we wish to debug the issues.
Add a field to the parallel install API to disable upgrade rollbacks.
Reasons
Allow better debugging capabilities, rollbacks need to be disabled on demand.

Atomic field was added in #198 - is this ticket also including the changes we need on the HELM client side?

Yes, this ticket includes 2 things:

API change so that the CLI can send the atomic field (you already did that on the CLI ticket linked above).
Implementation on the helm client to actually disable the rollbacks on failure.

Closing this issue as PR was merged.


7 -> main

➡ Forward port
Port gz-rendering7 to main
Branch comparison: https://github.com/gazebosim/gz-rendering/compare/main..gz-rendering7
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

fixed a test in 91d3ae0. CI is now :green_circle:

fixed a test in 91d3ae0. CI is now green_circle

I included the luxcore PR too


Make validator use transpiler as separate module

Maven project should consider parser as separate package
Transpilation should be called only by one method Transpile.transpile
Validator shouldn't use any of transpiler's internals

Project structure was refactored in #123 and #139


acq_optimizer is not documented in forest_minimize

The argument acq_optimizer is not presented in the docstring of forest_minimize.
Additionally, acq_optimizer is later passed as ````acq_optimizer="sampling"tobase_minimize. Although that makes sense because forest_minimize`` uses a tree-based regression model, I think the user should be aware of that behavior, at least.
Should acq_optimizer be removed from forest_minimize?

I vote yes for removing it as you can't set it to anything other than "sampling". The only caveat would be if we plan to introduce an alternative to sampling in the near future.


Refresh tiles by force / memory leak

Hi. I need Leaflet to refresh all visible tiles by some actions like dragend. I stumbled upon this ticket: https://github.com/Leaflet/Leaflet/issues/788
Someone there suggests to use "map._resetView(map.getCenter(), map.getZoom(), true)" to accomplish a smooth refreshing. While this works quite good at the beginnig, it seems to consume all available memory over time making leaflet unusable after some time.
map._resetView(map.getCenter(), map.getZoom(), false) does also reset the view, but you can see the screen becoming black for a moment before the tiles are reloaded which is really annoying. Here the memory leak does not appear.
Can somebody explain this to me or even better provide a solution for my problem resetting the view without visible flickering?
I appreciate every hint. Thanks in advance!

Is there a possibility that this has been improved in Leaflet 1.0?

@mourner I'm also very interested in your answer to this ^

@nickponline Could you provide a reproducible example which triggers these crashes? AFAIK the Leaflet team isn't aware of any crashes from excessive memory consumption.
Having said that, of course Leaflet, just like any web page, will have trouble if you just throw in huge numbers of images (like a large number of stacked tilelayers). Like @mourner says above, to our knowledge this is not a Leaflet problem but a general problem for the browser.


observeCharacter immediately calls cleanup

observeCharacter is expected to trigger its callback when a new character is added, and then trigger the provided cleanup function (if any) on the character's removal.
In testing, the cleanup is called immediately after the callback, despite the character not being removed. This makes this observer currently unusable.

Looks like I missed this because it works properly with workspace.SignalBehavior set to Deferred. In Immediate mode, it does not work as expected. I'll investigate and push a fix.


follow chains of replies

as of Feb 2023 if someone replies to a Fedimarks post on Mastodon it gets queued as a comment in Fedimarks, but if someone replies to that Mastodon reply, it doesn't.
To fix this, we'll need to index all existing replies and look those up as reply-to ids to check when determining what bookmark to file a comment under. We could retain this specific reply-to information and build threaded comments on the fedimarks side, or experiment with flattening it all, but we should at least keep enough information to try some things out on the frontend.

I was messing around with this since I am routinely receiving comments that wouldn't show up on the bookmark because they're replies to me or to others and not directly on the bookmark this is what I ended up with:

Essentially I just added another column in the comments table for in_reply_to_url, so if a comment comes in with an inReplyToId that matches one of my existing stored comments then I add that to the table referencing the original bookmark ID and the replied to comment URL. I'm open to creating a PR for this but I'm planning on waiting until #138 gets merged in as I'm not sure what kind of database changes that introduces


Dbg add traceable plugin

Summary

Add Traceable integration to Kong Hub.
Reason

Per discussion with Gang Guo.
Testing

Local doc build.

@kongguogang When you have a chance, could you review this plugin doc? Thanks!

we will park it during v3.2 release, will resume it after v3.2 released

Thanks @kongguogang and @cloudjumpercat. Rough timeframe on when we can pick this back up? Days, weeks, months, quarters? Thanks.

@cloudjumpercat Hi I could use some assistance here. Apparently, the build failed thinking that I have an incorrectly spelled word, which I don't.
[vale] reported by reviewdog 🐶 [kongplugins.Pluginspelling] Did you really mean 'exfiltration'?
How do I tell it that "exfiltration" is exactly the word I want and that it should stop flagging it?
Thanks for your help.

@dbgordon Hi! If you add it to this file (this is the dictionary that Vale uses when looking for spelling errors, words in here will be treated as correct spellings), that should fix the problem!

Hi reviewers. Is there anything else that I need to do to get this change approved and published (to the Kong Hub)? Thanks!

Hi @dbgordon , we'll work w/ responsible parties internally to set some timelines for this release. Thank you.

Thanks, @acgoldsmith. Any ETA on this? Can we get it done by end of this month? Thanks.

@acgoldsmith @kongguogang
Are there any corrections that I need to make with my Kong Hub submission, or is there something else I need to fix, to get this change merged? Please let me know how I can get this update accepted.
Thanks,
Dan Gordon
Traceable

@dbgordon, apologies for the delayed response - Gang is not involved in this process anymore, so I'm looking for another internal point of contact who can assess this addition from strategic perspective before we move ahead with publishing.


Update sql_usage.md

See my small edits.

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@e12db08). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev       #1   +/-   ##
======================================
  Coverage       ?   63.42%
======================================
  Files          ?       41
  Lines          ?     3746
  Branches       ?        0
======================================
  Hits           ?     2376
  Misses         ?     1370
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e12db08...20c0b41. Read the comment docs.


Android version unable to add multiple nodes

Godot version
3.5.stable
System information
Android 12, GLES3, Snapdragon 750G, Galaxy Tab S7 FE
Issue description
After creating a new empty project, creating a 2d scene and adding more than one node the app just crashes and became unresponsive.
After restarting the project the resources folder becames empty as if the godot configuration became missing.
The same issue also happened on my Poco F3 with android 12 and Snapdragon 870.
Obs: In the images you can see a video player control, this is because I recorded the error, but the file is too large for github issues (40mb) if you ask I can upload it on youtube and send the link here.
Image 1: Creating an empty project

Image 2:The editor crashing after adding the thrid node

Image 3: Re-opening the project and the resources not showing my scene and nothing else, even the godot icon became missing

Steps to reproduce
1 - Download the official apk available on github releases
2 - Installing the apk
3 - Open godot
4 - Create a empty project
5 - Create a 2d scene
6 - Add 2 nodes (can be anyone, not related to specific node)
Minimal reproduction project
Due to the problem being with an empty project I will just zip the crashed project.
Test android.zip

Duplicate of https://github.com/godotengine/godot/issues/64166.


Add missing length checks on key and associated data

Argon2::hash_impl forgets this.

Fixed in 61628955 and 08342ecc


Render Uint8Array throw error

Hi all,
I wan't to render a base64 PDF file with your solution !
I convert base64 to Uint8Array and I try to render it with PDFJS like the following
    function convertDataURIToBinary(dataURI) {
      var base64Index = dataURI.indexOf(BASE64_MARKER) + BASE64_MARKER.length;
      var base64 = dataURI.substring(base64Index);
      var raw = window.atob(base64File);
      var rawLength = raw.length;
      var array = new Uint8Array(new ArrayBuffer(rawLength));

      for(var i = 0; i < rawLength; i++) {
        array[i] = raw.charCodeAt(i);
      }
      return array;
    }
    var pdfAsDataUri = "data:application/pdf;base64,JVBERi0xLjUN..."; //AWESOME LENGTH
    var BASE64_MARKER = ";base64,";
    $scope.pdf = convertDataURIToBinary(pdfAsDataUri);

But when I test it, I see the following warning :

Warning: Deprecated API usage: getDocument is called with pdfDataRangeTransport, passwordCallback or progressCallback argument

And the following error :

TypeError: url.charAt is not a function
at combineUrl (pdf.js:333)

Thanks to your help !

Hi! Have you tried this? Closing, but feel free to re-open if this doesn't work.

In case anyone needs a working version of the process: (where base64 is your base64 string)
var binaryImg = atob(base64);
var length = binaryImg.length;
var arrayBuffer = new ArrayBuffer(length);
var uintArray = new Uint8Array(arrayBuffer);
for (var i = 0; i < length; i++) {
uintArray[i] = binaryImg.charCodeAt(i);
}
var currentBlob = new Blob([uintArray], {type: 'application/pdf'});
$scope.pdfUrl = URL.createObjectURL(currentBlob);

@johnjspiteri with your code provided above it does creates a pdf but when opened in browser shows no data.
This is the url generated below
blob:http://localhost:8888/be9be94b-5750-418c-9159-43d62c0657ad

I would love to help a fellow coder - would need more information. It can be difficult to create an online example...
It seems to me that the issue is browser related - can you test FireFox, Chrome and Safari to see if the PDF works on any of those browsers?


Remove Paragraph Clean module

Why?
Documentation states

Not compatible with revisions. Creating node / entity revisions with varying paragraph relations will have adverse consequences.
if you're re-using paragraphs among different entities, then don't install this module.

https://www.drupal.org/project/paragraphs_clean

yup, wrong repo. Sorry.


#15 Bootstrap Modal - Home Page Alerts

When I enter an invalid entry in the search bar,
Then I'm presented with a modal prompt message "Invalid entry"
When I enter an item and don't select an option from the menu,
Then I'm presented with a modal prompt message "Please select one option from the drop down menu".

complete


🚀 CI: Nightly Build

Changes
🚀 Add nightly build to CI
🚚 Move PR template to .github root

Adding todo here for later reference.

[ ] Parallelize runs over multiple GPUs

I feel that maybe the callback tests should be executed at pre-merge instead of nightly. We could run them on a dummy dataset so that it does not take a long time to run.


Adding new web files

Added new:

Web page (index.html)
Style sheet (style.css)
test.md

Hello, i hope this email finds you well.
I used the Microverse Template for the README.md file on my second code
review request. Where did I make a mistake?
Can you please be more specific on what I need to change?
Frankline Osoro @.***> escreveu no dia terça,
20/09/2022 à(s) 21:56:

@.**** requested changes on this pull request.
Hi @enoqueJonas https://github.com/enoqueJonas ,
Good job so far!
There are some issues that you still need to work on to go to the next
project but you are almost there!
[image: YesYouAreGIF (2)]
https://user-images.githubusercontent.com/50941074/172881298-64e98170-87c5-4075-8a77-71d65d991f55.gif
Highlights
✅ Correct use of Github workflow
✅ No linter error
Required Changes ♻

As the previous reviewer requested, Kindly use this microverse
template https://github.com/microverseinc/readme-template on your
readme file and modify it as it will make your wake easier and make your
readme file more professional. This is important for documentation purposes

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHub
https://github.com/enoqueJonas/Hello-World/pull/4#pullrequestreview-1114397773,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASG3SOVX7FMWBM4KZAT2KUTV7IJFRANCNFSM6AAAAAAQRJIYH4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello, i hope this email finds you well. I used the Microverse Template for the README.md file on my second code review request. Where did I make a mistake? Can you please be more specific on what I need to change? Frankline Osoro @.> escreveu no dia terça, 20/09/2022 à(s) 21:56:
…
@.* requested changes on this pull request. Hi @enoqueJonas https://github.com/enoqueJonas , Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there! [image: YesYouAreGIF (2)] https://user-images.githubusercontent.com/50941074/172881298-64e98170-87c5-4075-8a77-71d65d991f55.gif Highlights ✅ Correct use of Github workflow ✅ No linter error Required Changes ♻ - As the previous reviewer requested, Kindly use this microverse template https://github.com/microverseinc/readme-template on your readme file and modify it as it will make your wake easier and make your readme file more professional. This is important for documentation purposes Optional suggestions Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. ------------------------------ As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s. — Reply to this email directly, view it on GitHub <#4 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASG3SOVX7FMWBM4KZAT2KUTV7IJFRANCNFSM6AAAAAAQRJIYH4 . You are receiving this because you were mentioned.Message ID: @.***>

@enoqueJonas , By the  time I was reviewing it, the readme file was not updated. Good job notifying me. Now you can submit you PR for approval.

Hello Enoquejonas
Kindly submit your PR for approval
On Wed, Sep 21, 2022 at 12:42 PM Enoque Jonas Macanda <
@.***> wrote:

Hello, i hope this email finds you well.
I used the Microverse Template for the README.md file on my second code
review request. Where did I make a mistake?
Can you please be more specific on what I need to change?
Frankline Osoro @.***> escreveu no dia terça,
20/09/2022 à(s) 21:56:

@.**** requested changes on this pull request.
Hi @enoqueJonas https://github.com/enoqueJonas ,
Good job so far!
There are some issues that you still need to work on to go to the next
project but you are almost there!
[image: YesYouAreGIF (2)]
<
https://user-images.githubusercontent.com/50941074/172881298-64e98170-87c5-4075-8a77-71d65d991f55.gif
Highlights
✅ Correct use of Github workflow
✅ No linter error
Required Changes ♻

As the previous reviewer requested, Kindly use this microverse
template https://github.com/microverseinc/readme-template on your
readme file and modify it as it will make your wake easier and make your
readme file more professional. This is important for documentation
purposes

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if
something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use
the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you
have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can
request
a second opinion using this form <https://airtable.com/shrQAqnBwek5a0O0s
.
—
Reply to this email directly, view it on GitHub
<
https://github.com/enoqueJonas/Hello-World/pull/4#pullrequestreview-1114397773
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ASG3SOVX7FMWBM4KZAT2KUTV7IJFRANCNFSM6AAAAAAQRJIYH4
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/enoqueJonas/Hello-World/pull/4#issuecomment-1253460820,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPETWYKFHUSHJQXL6LAUSDV7LKB7ANCNFSM6AAAAAAQRJIYH4
.
You are receiving this because you commented.Message ID:
@.***>

Hello, hope this email finds you well
I already merged the pull request, but it is not updating on my dashboard.
Something I need to do?
Frankline Osoro @.***> escreveu no dia quarta,
21/09/2022 à(s) 13:49:

Hello Enoquejonas
Kindly submit your PR for approval
On Wed, Sep 21, 2022 at 12:42 PM Enoque Jonas Macanda <
@.***> wrote:

Hello, i hope this email finds you well.
I used the Microverse Template for the README.md file on my second code
review request. Where did I make a mistake?
Can you please be more specific on what I need to change?
Frankline Osoro @.***> escreveu no dia terça,
20/09/2022 à(s) 21:56:

@.**** requested changes on this pull request.
Hi @enoqueJonas https://github.com/enoqueJonas ,
Good job so far!
There are some issues that you still need to work on to go to the next
project but you are almost there!
[image: YesYouAreGIF (2)]
<

https://user-images.githubusercontent.com/50941074/172881298-64e98170-87c5-4075-8a77-71d65d991f55.gif

Highlights
✅ Correct use of Github workflow
✅ No linter error
Required Changes ♻

As the previous reviewer requested, Kindly use this microverse
template https://github.com/microverseinc/readme-template on your
readme file and modify it as it will make your wake easier and make
your
readme file more professional. This is important for documentation
purposes

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if
something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use
the
same Pull Request submitted for the first review, either valid or
invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you
have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can
request
a second opinion using this form <
https://airtable.com/shrQAqnBwek5a0O0s
.
—
Reply to this email directly, view it on GitHub
<

https://github.com/enoqueJonas/Hello-World/pull/4#pullrequestreview-1114397773

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ASG3SOVX7FMWBM4KZAT2KUTV7IJFRANCNFSM6AAAAAAQRJIYH4

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/enoqueJonas/Hello-World/pull/4#issuecomment-1253460820
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AXPETWYKFHUSHJQXL6LAUSDV7LKB7ANCNFSM6AAAAAAQRJIYH4
.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/enoqueJonas/Hello-World/pull/4#issuecomment-1253594570,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASG3SOWSVIQLHB4F3SL5GNTV7LY5XANCNFSM6AAAAAAQRJIYH4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fixes and Updates to the azure-json Libraries

Description
Removed gsonCurrentToken from GsonJsonReader as this is duplicate information to currentToken, fixed GsonJsonReader returning DefaultJsonReader when buffering the object, fixed requirements for bufferObject to ensure that a JSON object is being buffered, and fixed nextToken() in GsonJsonReader to not require the previous token to be consumed which could have resulted in an infinite look if the previous token was never consumed.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Add option to hide retweets from a Twitter feed

Me from Slack:

Is there a way to remove retweets from a Twitter feed (but keep quote tweets)?  (Twitter’s search UI doesn’t display rewteets)

Since Twitter integration will stop working soon — as soon as Twitter ends free Twitter API access — I’m closing this.


Python Language Server conflicting with GraphQL extension

Environment data

VS Code version: 1.51
Extension version (available under the Extensions sidebar): v2020.11.371526539
OS and version: macOS 10.15 Catalina
Python version (& distribution if applicable, e.g. Anaconda): Anaconda Python 3.8
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: graphql-0.13.12
Value of the python.languageServer setting: true

Expected behaviour
Execute GraphQL queries to a remote endpoint successfully, inside of a multi-root, multi-language workspace.

Actual behaviour
Installing and running this extension inside of my Python Workspace with the listed configuration generates the following error
  ERR name must not be falsy: Error: name must not be falsy
	at Function.validate (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:524:978)
	at new C (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:524:927)
	at new C (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:511:436)
	at asSymbolInformation (/Users/user/.vscode/extensions/graphql.vscode-graphql-0.3.12/node_modules/vscode-languageclient/lib/protocolConverter.js:383:22)
	at /Users/user/.vscode/extensions/graphql.vscode-graphql-0.3.12/node_modules/vscode-languageclient/lib/protocolConverter.js:372:42
	at Array.map (<anonymous>)
	at Object.asSymbolInformations (/Users/user/.vscode/extensions/graphql.vscode-graphql-0.3.12/node_modules/vscode-languageclient/lib/protocolConverter.js:372:23)
	at /Users/user/.vscode/extensions/graphql.vscode-graphql-0.3.12/node_modules/vscode-languageclient/lib/client.js:1005:62

The errors do not appears to be from the Language Server, but googling for the error itself yields only issues related to the Python Language Server. I am able to run the graphql extensions inside a single language, non multi-root workspace (From my screenshot above). Search Reference
Steps to reproduce:

Create a multi-root workspace
Initialize the Python Language Server
Install graphql from the Extensions marketplace
Configure GraphQL with a remote or local schema
Create a query file
Run 'Execute Query'
The query window will return an empty screen instead of data.

Logs

This is a work computer, please DM me on twitter for more logging :)

Thanks!

We have recently released a new and more performant language server called Pylance which could solve this issue you are reporting.  You can download Pylance from the marketplace and install it alongside the core Python extension. Because our team's development efforts have shifted to support the new language server, we'd encourage you to try it out.

@luabud Not a problem. I'll try out Pylance and see if it resolves the issue.
Is there an EOL for the Python Language Server in favor of Pylance?

@webdog not that I'm aware of, but passing the question to @savannahostrowski in case she has a better answer 😊

@webdog Not at this time! However, my team's efforts are focused on developing and adding new features to Pylance.

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.


Some errors with the latest build

@losbagos
Love the script, great job! The new version has some issues for me:
- Like the old version, it can't find the kitty.ico file. Maybe you can upload it? For now i always remove that row.
C:\Temp\mailboxdef2\totalmailboxdeath-main>python main.py
DevTools listening on ws://<IP_ADDRESS>:58016/devtools/browser/edf79682-8340-44d1-b801-458f1d22a07d
Traceback (most recent call last):
File "C:\Temp\mailboxdef2\totalmailboxdeath-main\main.py", line 47, in
tmdApp.iconbitmap("kitty.ico")
File "C:\Users\Wu\AppData\Local\Programs\Python\Python39\lib\tkinter_init_.py", line 2080, in wm_iconbitmap
return self.tk.call('wm', 'iconbitmap', self._w, bitmap)
_tkinter.TclError: bitmap "kitty.ico" not defined
- Can't run the new version because tmdShank is not defined in main.py:
C:\Temp\mailboxdef2\totalmailboxdeath-main>python main.py
DevTools listening on ws://<IP_ADDRESS>:58083/devtools/browser/15589697-dd4d-4d8f-811c-c43d90c4137d
Traceback (most recent call last):
File "C:\Temp\mailboxdef2\totalmailboxdeath-main\main.py", line 156, in
tmdContactSubmit_button = tkinter.Button (tmdApp, text='run contact form spammer', background=Pink, command = tmdShank)
NameError: name 'tmdShank' is not defined
Keep up the great job!!

seems like a silly error on my part, ill look at this now

these should be fixed now! just some silly little errors i shouldve picked up on! let me know if theres any more issues!

Yes, working great now, Thanks chief!


chore: Fix compiling error in AsSubscriber.java and FromPublisher.java

Motication:
Fix compiling error.
refs: https://github.com/apache/incubator-pekko/actions/runs/7522637028/job/20474910545
Result:
It compiles now.

Wait, why wasn't this compiling in the first place? The CI should pickup these things and since the source file is in java-jdk-9 only this could have been caused by having wrong JDK set or something along those lines?

@mdedetrich I'm re triggering the nightly build, I think that maybe cause of some dependencies change?

@pjfanning Do you have any idea on this?

Triggered at https://github.com/apache/incubator-pekko/actions/runs/7524512274

@mdedetrich @pjfanning it's works now.

@mdedetrich @pjfanning it's works now.

I understand that it works now, im questioning why it stopped working in the first place. Our CI should be picking up compilation issues so no PR should have been merged causing this breakage in the first place.

The CI build for PRs mustn't cover ever single line of code. The setup for PRs is a complicated set of subjobs that run in parallel.

If thats the case then we should fix this, at a bare minimum the CI that gets trigged on every PR run should ensure that all code can compile.


Use pin instead of password to unlock account + some small fixes

Meetup: Show note that a password is needed if no password was entered in the dialog and return to the ceremony page.

Tested with a successful meetup.

Breaking Change: After this PR is merged, the keyboards of all password forms exclusively contain digits. Thus, old accounts cannot be used anymore as they had to contain letters, which can't be entered anymore.

#90 does not seem to be fixed after all.

I'll wait with merging until #90 is fixed as it is somewhat related to this PR. ok?

leaving #90 for later


Avoiding copies of uWebSocket messages in message callback

Hi,
Currently the message callback provides an std::string_view, which means it does not support transferring ownership.
For my application, I need to keep accumulating it (well, the last X messages), and was thinking it would be nice to avoid the copy and be able to take ownership?
Thoughts on supporting that? Or perhaps I'm just missing how it is supported.
Kyle

This is a fundamental design and not something that's going to change


Confirm that microphone permission is no longer being requested

I'm upgrading to Xamarin.Essentials 1.7.0 which claims to have fixed that issue
https://docs.microsoft.com/en-us/xamarin/essentials/release-notes/1.7
I also removed the microphone permission description from info.plist and added some new permissions which I think caused some crashes reported on AppCenter
Still need to confirm that this has actually worked bc my iPhone 7 doesn't request any permissions for some reason..?
Edit:
@tomShoutTheSecond if you could QA this on the iOS release candidate later it'd be helpful, idk why on my device permissions aren't being requested

App doesn't request microphone permissions now 🎉


Reducer: replace Global VariablesDeclarationReduction with expression

Similar idea to #480:
When not preserving semantics, the reducer should try to replace global veriable declarations:
int a = 1;
void main()
{
}

with
int a;
void main()
{
 a = 1;
}

Note that the new expressions must be the first statement in main().

Fixed by #576.


fix(backup): set IAM conditions conditionally

IAM conditions can only be used to restrict access to DatabaseInstances or BackupRuns. They can't be used to restrict access to Database resources.
The export workflow uses the googleapis.sqladmin.v1.databases.list call to gather all database names.
This call fails with the error code 403: unauthorized when the IAM conditions are set.

The client is not authorized to make this request.

Supported Resource Type Values in IAM Conditions: docs

/gcbrun


[Doc] Add API reference

This repo should include documentation that explains all possible parameters for the available result transformers.
As we reimplement result transformers as search pipeline processors (see e.g. https://github.com/opensearch-project/OpenSearch/issues/7158, which probably belongs in this repo, not in OpenSearch core), we will need to update the documentation.

Can you be more specific with the APIs to document? Is this going to be covered by search pipelines?

@noCharger is your original request satisfied? If not, what's left? The process to update docs for users is to create an issue in #opensearch-project/documentation-website.

Close this issue since API references are updated https://opensearch.org/docs/latest/search-plugins/search-pipelines/index/


Supermium fail in some websites

Hi! same website in regular chrome load fine, attach screenshot, any ideas are welcome
Chromium

Supermium

I wonder if this issue is related to the secure DNS provider issues?
But I'll be sure to investigate once the build system is functional again (right now I'm focusing on the Electron offshoot of Supermium).

I have run across this issue several times but then I tap on the blue icon and the pages ge to load just fine.


Updates to README

issue #2

@nshanbhag20001412  seems all good ,
your PR getting PR now , you can update the rest of screenshots if available

@nshanbhag20001412  thanks for you contribution.
don't forget to star the repo.
would like to offer swags from loginradius , to avail those please fille the form
https://docs.google.com/forms/d/e/1FAIpQLSfnwWUWlRRwZpgmOX7X8lGMKotLbVe1JXCjPFSahLxLWugwig/viewform


fix(removeSelected): fix incorrect removal of preselected item

Make sure that removeSelected only affects multiples, include unit test, and add comment in demo examples.
Addresses #1672 and possibly #1681

Cheers @dondi!


Create a migration doc covering changes from alpha & beta to stable v4

Document the breaking and the most notable changes for people who update Material to stable v4 from alpha or beta:

[x] FAB with dropdown menu
[x] Navigation drawer variations with responsive behaviours
[x] Textarea auto resize removed
[x] Waves removed

Thanks.

Textarea autosize is here ;-) https://jsfiddle.net/djibe89/bofcrp8v/

Migration doc: http://daemonite.github.io/material/docs/4.1/getting-started/migration/


Bump tendermint-rs crates to 0.28

@thanethomson this seems like a potential tendermint-rs bug?
https://github.com/cosmos/cosmos-rust/actions/runs/3825434673/jobs/6508425796#step:4:194

error[E0277]: the trait bound alloc::vec::Vec<u8>: core::convert::From<bytes::Bytes> is not satisfied
--> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/tendermint-0.28.0/src/hash.rs:237:26
|
237 |         Ok(AppHash(value.into()))
|                          ^^^^ the trait core::convert::From<bytes::Bytes> is not implemented for alloc::vec::Vec<u8>

@thanethomson it looks like you're depending on a feature of bytes which was added some time after 1.1.
You might want to pin to bytes 1.3 (or whatever version added that From conversion)

Thanks for bringing this up @tony-iqlusion! cc @mzabaluev


Add more tests notification ctrl

Description:
Input for NotificationsApi is not validated.
Improvements

Validate input
Extend Test-Suite

Pull Request Test Coverage Report for Build 2498

20 of 20 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.2%) to 67.11%

Totals

Change from base Build 2496:
1.2%

Covered Lines:
1169

Relevant Lines:
1675

💛  - Coveralls


Module to project

First pass at removing the module level and other general cleanup

failing tests, fix the following
./crowdsourcing/serializers/project.py:49:104: W291 trailing whitespace
./crowdsourcing/serializers/worker.py:32:57: W291 trailing whitespace
./crowdsourcing/serializers/worker.py:65:28: W292 no newline at end of file
./crowdsourcing/viewsets/project.py:1:1: F401 'get_object_or_404' imported but unused
./crowdsourcing/viewsets/project.py:2:1: F401 'mixins' imported but unused
./crowdsourcing/viewsets/project.py:9:1: F401 'IsReviewerOrRaterOrReadOnly' imported but unused
./crowdsourcing/viewsets/project.py:182:96: W292 no newline at end of file
./crowdsourcing/viewsets/rating.py:59:120: E501 line too long (122 > 119 characters)
./crowdsourcing/viewsets/worker.py:114:59: W292 no newline at end of file

fix prototype popup
rest looks good

lgtm


Fix the ActionFailed exception

For some unknown reason, the action to run the upgrade in one of the nova-compute units failed with time out. During the exception handling another exception happened like the logs bellow show:
2024-04-22 21:22:54 [cou.steps.execute] [INFO] Running: ├── Upgrade the unit: 'nova-compute/0'
2024-04-22 21:22:54 [cou.steps] [DEBUG] running step: UnitUpgradeStep(├── Upgrade the unit: 'nova-compute/0')
2024-04-22 21:24:46 [cou.utils.juju_utils] [INFO] function _get_waited_action_object failed [0]
Traceback (most recent call last):
  File "/home/ubuntu/charmed-openstack-upgrader-1/cou/utils/juju_utils.py", line 116, in wrapper
    return await func(*args, **kwargs)
  File "/home/ubuntu/charmed-openstack-upgrader-1/cou/utils/juju_utils.py", line 257, in _get_waited_action_object
    raise ActionFailed(action, output=action_obj.data)
  File "/home/ubuntu/charmed-openstack-upgrader-1/cou/exceptions.py", line 102, in __init__
    params[key] = getattr(action, key, "<not-set>")
  File "/home/ubuntu/charmed-openstack-upgrader-1/.venv/lib/python3.10/site-packages/juju/model.py", line 287, in __getattr__
    return self.safe_data[name]
KeyError: 'parameters'
2024-04-22 21:24:47 [cou.cli] [ERROR] The following substeps of 'Upgrade plan for units: nova-compute/0' failed
Upgrade plan for unit 'nova-compute/0': TimeoutException('function _get_waited_action_object timed out after 10s')

This seems to be caused by https://github.com/juju/python-libjuju/issues/1048, closing


[version 6.0.3] swiper/react can't find use method in TS project

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 6.0.3

Live Link or JSFiddle/Codepen or website with isssue: https://codesandbox.io/s/react-id-swiper-update-two-4irn6?file=/src/App.tsx

What you did
Wanted to try out how to use Controller (as per the description in: https://swiperjs.com/react/#controller) with Swiper/React + React in a CRA with TS configured.
Expected Behavior
The example works as described in the Swiper/React page.
Actual Behavior
Type Error: _react2.Swiper.use is not a function
Is there any way to make these imports to work in a TS project?

It must be SwiperCore.use(...)

Maybe the docs should be a little more verbose about this. Now it's written like it should be done on the swiper instance. Also I was unsure what to pass the function, the docs of this function should maybe also state that this should be SwiperComponent classes in an array, and not strings.


Minified pseudoselectors are not spec-compliant, breaking Qwik

Describe the bug
span::before {
  content: '';
}

Becomes:
span:before{content:""}

By dropping the extra : from ::before, this is against the spec depended on by a plugin used by the Qwik build, see issue: https://github.com/BuilderIO/qwik/issues/2189
Reproduction
https://stackblitz.com/edit/vitejs-vite-hwufm4?file=style.css
Steps to reproduce
Run npm run build, then inspect the dist/assets/index-xxx.css to see the output.
System Info
Stackblitz/Firefox/Windows

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Vite uses esbuild to minify CSS and esbuild transforms
span.foo::before {
  content: '';
}

into
span.foo:before{content:""}

repl
But I think changing ::before to :before is spec-compliant. This is written on the spec.

For compatibility with existing style sheets written against CSS Level 2 [CSS2], user agents must also accept the previous one-colon notation (:before, :after, :first-letter, :first-line) for the ::before, ::after, ::first-letter, and ::first-line pseudo-elements.
https://w3c.github.io/csswg-drafts/css-pseudo/#css2-compat

I guess qwik's transformation doesn't take pseudo elements like :before into account.


Implement Cloneable in org.asciidoctor.Options

Hello there.
I recently encountered multiple scenatios where I needed an org.asciidoctor.Options instance to be (almost) the same as the original. Unfortunately, the only way of doing this is to use the internal/deprecated methods involving the underlying map.
Is there any intended way of doing this? Otherwise, I'd be happy to open a PR ;)
Kind Regards

I don't think it is a good idea to clone an Options object.
AsciidoctorJ will mutate it before passing it to Asciidoctor Ruby, and I cannot tell what Asciidoctor Ruby will do with this object.
I think it's best if the caller of the API builds an abstraction if they need slightly different options between 2 conversions.

Hey @robertpanzer,
What would you think about removing the underlying Options-Instance of org.asciidoctor.OptionsBuilder and replacing it with a map that will be passed to a new created instance everytime the OptionsBuilder#build() method is invoked?

I am still reluctant to do that.
The same problem applies to the attributes property that is a member of Options.

I also thought the same way as @Marfien: collect the state passed to OptionsBuilder and only create the Options instance and the attributes when invoking build(). If the same would be done for AttributesBuilder, the issue regarding the attributes map would also be solved (or instead or in addition copying the map before setting it as to the OptionsBuilder). That way, users could pass on the OptionsBuilder instance, modified it where needed and always create a fresh and decoupled instance of Options when calling AsciidoctorJ APIs.
Being forced to create your own abstraction is very inconvenient and somehow defeats the purpose of having a convenient Java API for the underlying Ruby AsciiDoc API, don't you think?

I cannot tell what Asciidoctor Ruby will do with this object

I think this needs clarification. Even if Options is guaranteed to be unique, we cannot guarantee it won't be mutated by the core. In the example below, you may expect op to be the same in both calls, but that's not true.
Options op = optionsBuilder.build()

convert(op);
convert(op);

Being forced to create your own abstraction is very inconvenient and somehow defeats the purpose of having a convenient Java API for the underlying Ruby AsciiDoc API, don't you think?

I agree, but since the underlying issue of mutability remains, I don't think any change in Builder will suffice. If anything I'd take the radical approach to remove Builders 🪓

What do you think about the approach of making a copy of the Options instance internally every time the underlying Ruby API?
Or maybe the current Options implementation could be modified to be used as a Wrapper for an internally used Ruby-Options?


handle file/dir cleanup errors gracefully

Overview
This PR catches cleanup errors, logs the error and emits an ows:ExceptionReport response.
Related Issue / Discussion
#150
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[ ] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

Coverage decreased (-0.1%) to 76.559% when pulling b382c83bbe720b575d3b83a2647c4ff56ee97c30 on tomkralidis:issue-150 into be1d094b7ec6fb2655d23dbe66f19343d5708de6 on geopython:master.

Do we want to the process to fail in case PyWPS fails to remove the temp folder? Wouldn't it be better to send back the response and simply log the exception?

Good point @ldesousa.  PR updated to only log the error.

Coverage decreased (-0.1%) to 76.571% when pulling 2ab39099f3654fb72374400500ea0b9e282427df on tomkralidis:issue-150 into be1d094b7ec6fb2655d23dbe66f19343d5708de6 on geopython:master.

Coverage decreased (-0.1%) to 76.571% when pulling 2ab39099f3654fb72374400500ea0b9e282427df on tomkralidis:issue-150 into be1d094b7ec6fb2655d23dbe66f19343d5708de6 on geopython:master.


KYLIN-4441 Add restart command to kylin.sh

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] If this change need a document change, I will prepare another pr against the document branch
[x] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #1176 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1176      +/-   ##
============================================
- Coverage     25.06%   25.01%   -0.06%
- Complexity     6250     6251       +1
============================================
  Files          1446     1449       +3
  Lines         88309    88499     +190
  Branches      12358    12373      +15
============================================
- Hits          22136    22134       -2
- Misses        64003    64187     +184
- Partials       2170     2178       +8

Impacted Files
Coverage Δ
Complexity Δ

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0.00%> (-5.41%)
6.00% <0.00%> (-1.00%)

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0.00%> (-4.77%)
5.00% <0.00%> (-1.00%)

...va/org/apache/kylin/cube/common/SegmentPruner.java
58.46% <0.00%> (-4.04%)
26.00% <0.00%> (+1.00%)
:arrow_down:

...he/kylin/job/impl/threadpool/DefaultScheduler.java
74.41% <0.00%> (-2.33%)
12.00% <0.00%> (ø%)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
70.21% <0.00%> (-0.92%)
7.00% <0.00%> (ø%)

...a/org/apache/kylin/dict/Number2BytesConverter.java
81.74% <0.00%> (-0.80%)
17.00% <0.00%> (-1.00%)

...he/kylin/engine/mr/common/MapReduceExecutable.java
12.91% <0.00%> (-0.42%)
6.00% <0.00%> (ø%)

...ain/java/org/apache/kylin/engine/mr/CubingJob.java
1.53% <0.00%> (-0.04%)
2.00% <0.00%> (ø%)

...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...ava/org/apache/kylin/tool/JobDiagnosisInfoCLI.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734a997...8ce3d3e. Read the comment docs.

Pull Request Test Coverage Report for Build 5821

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.005%) to 27.475%

Files with Coverage Reduction
New Missed Lines
%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java
2
57.95%

Totals

Change from base Build 5800:
-0.005%

Covered Lines:
24315

Relevant Lines:
88499

💛  - Coveralls


Add implemention of MemSize for std::net addresses

Sorry about the unannounced sudden PR..
It seems simple enough to add, and something that I need.
Feel free to reject/modify/insert differently.

Thanks for the PR! We'll release a new version ASAP.

0.2.1 is out.


Result export "Open file" button does nothing on Mac/Linux

SQL Operations Studio Version: master 03ea265
OS: Mac

Steps to Reproduce:

Run a query
Export the results to CSV, JSON, or Excel
Close out of the new file if it opens but do not dismiss the pop-up that tells you the export succeeded
Click the "Open file" button on that pop up

Expected behavior: The exported file opens
Actual behavior: nothing happens

@MattIrv I think this may be related to the OS.  Open file seems to work for me on Windows, but not on Linux.

This should be fixed on latest builds.  Thanks!


Border of mj-section doesn't use the border-radius

Describe the bug
If you set the border radius in mj-section and then a border of 1 px, the background color is rounded, but not the border
To Reproduce
<mj-section backgroundColor='#C8C9CA' border='solid 1px' borderRadius={10}>
Expected behavior
The border should use the border radius
MJML environment (please complete the following information):

OS: MacOS
MJML Version 4.13.0
MJML tool used Mjml React

Email sending environment(for rendering issues):

Screenshots

This is a limitation because of the use of border-collapse as it's incompatible with border-radius.
What you can do is target the table to set border-collapse to separate and apply the radius on the td with a css-class.

Thanks for the response but can you share a response with code?

Here https://mjml.io/try-it-live/x4mYo2A57

I followed it and thanks for that.


Apple music Gradient causes screen to tear

from the discord: https://discord.com/channels/842219447716151306/842818946243887134/1246188906542661763
Relavant info to reproduce: whoneedsnix.txt

could you check if this selector evaluates in inspect element:
:root .Root__main-view .main-view-container main:not(:has(.lyrics-lyricsContainer-LyricsContainer))

Same issue, affects playlists and fullscreen menu. Have tried reinstalling both spotify and spicetify with and without other extensions, does not work now.


fabric 1.20.1 version 1.0.0 of the mod says it requires 1.20.2

Just recompiled the fabric mod with different properties so now it will run for 1.20 - 1.20.4


test(BigInputComponent): created unit test for BigInputComponent

fixes #271

Hi @hhubik ! Thank you for the adjusted PR. I will merge it.
For the future, I described git rebase with squashing in the comment of the previous PR so feel free to check and try it. Also for the  next time, please put fixes #<issue-number>in the commit message itself so that GitHub automatically connects and closes relevant issue.
Thank you again!

@hhubik also one more thing the scope in the commit. For the future let's keep it on the module level. So it would have been test(shared) ....
In bigger apps there might be many components so to signify impact on other developers it makes sense to specify changed module which they should be aware of while they probably  don't know every single component location by heart.

Hi @tomastrajan - glad to help.  Thank you for the learning opportunity :)
Regarding fixes #<issue-number>, I did put that in the body of the commit comment on a separate line.  I thought that is where it should go.  I now see that the examples in the latest CONTRIBUTING doc have it on the subject line, separated by a comma from the rest of the subject text.  Are you saying that having it in the body does not work and that it must be in the subject line?
If I read this correctly, it should work anywhere in the commit message.
Regarding test(shared) ... and module level, that sounds reasonable.  However, the CONTRIBUTING doc includes an example of a commit comment starting with test(todos) ..., where todos is a component, not a module.  If you want to use the module names for test scope, the doc should be updated to reflect that.

Hi @hhubik !
Thank you for clarifications! I missed the fact that you provided fixes string in the commit body, of course that's enough, well done!
As for module level, you are right, I should adjust the documentation. In case of todos it was meant as a "submodule" of examples module even though it was not separated (extracted) yet. Todos contains component, reducer and effects. I agree that it is not obvious and docs can and will be improved.
Thank you for your feedback!

@hhubik I have just updated CONTRIBUTING.md with more detailed info about commit scopes.


bug in scrolling clusterize table if it has different row heights

If is enabled break-word css property in td elements and I put a number of words that go out of td bound it causes the end line and the current row height is modified. Then if I try to scroll, the next cluster is updated but not in right moment.

Please provide codepen.io example
This is not a bug, it's mostly like a plugin's restriction of rows height. Rows should be same height or at least approximately the same height. See first item at FAQ.
It behaves this way because clusterize picks height from one of rows during initialisation and uses this height for further operations. It only suggests height of cluster (chunk of rows) based on previously picked row height. Clusterize isn't aware of actual full-list height.
That's why rows should have similar height.
I will be happy to hear your suggestions regarding solution to this task :)

ok... in my opinion the best thing to do is to avoid this bahavior of clusterize. Adding in clusterize.css a word-wrap: nowrap; in td elements of table it  keeps rows height unchanged.

It will work for you but may break someone other's expectations.
Not everyone needs one-line rows in their tasks.
So no silver bullet here IMO.
It's great if word-wrap: nowrap; works for you and solves your task. Use it and let this thread be example of possible solution if someone else faces similar problem.

I've been tinkering around with providing an array of row heights along with the markup array and then using this array of heights for most of the calculations done for determining cluster postion and so on. This works really well.
This approach may help others who do now theire row heights in advance.

@de-robat Do you have a patch of your fix for passing the row heights? Thanks!

nothing generic unfortunatley. I wanted to prepare a MR for the root project but haven't found the time to do so by now.
What i basically did, is extending a view of the original functions in clusterize.js:
i changed the update function to take in an array of row heights:
self.update = function(new_rows, row_heights) {
	rows = isArray(new_rows) ? new_rows : [];
	self.row_heights = row_heights;
	var scroll_top = self.options.scroll_top_getter();
	// fixes #39
	var totalHeight;
	if (self.row_heights) {
		totalHeight = self.row_heights.reduce(function(a, b) {
			return a + b
		}, 0);
	} else {
		totalHeight = rows.length * self.options.item_height;
	}

	if (totalHeight < scroll_top) {
		self.options.scroll_top_setter(0);
		last_cluster = 0;
	}
	self.insertToDOM(rows, cache);
	self.options.scroll_top_setter(scroll_top)
}

then i adjusted all the places where the heights calculations are done do respect this array if present:
self.getScrollProgress = function() {
	var totalHeight;
	if (this.row_heights) {
		totalHeight = this.row_heights.reduce(function(a, b) {
			return a + b
		}, 0);
	} else {
		totalHeight = rows.length * this.options.item_height;
	}
	return ((this.options.scroll_top / totalHeight) * 100) || 0;
}

...

getClusterNum: function() {
	this.options.scroll_top = this.options.scroll_top_getter();
	if (this.row_heights) {
		//if we know the exact heights of each row we determine the current cluster by getting the currently drawn rows
		//deviding them by rows per cluster
		var currentHeight = 0;
		for (var rowNum = 0, len = this.row_heights.length; rowNum < len - 1; rowNum++) {
			currentHeight += this.row_heights[rowNum];
			if (currentHeight >= this.options.scroll_top) {
				//this is the row that determines the activley shown cluster
				return Math.floor(rowNum / (this.options.rows_in_cluster - this.options.rows_in_block)) || 0;
			}
		}
	}
	return Math.floor(this.options.scroll_top / (this.options.cluster_height - this.options.block_height)) || 0;
}

...

generate: function(rows, cluster_num) {
	var opts = this.options,
		rows_len = rows.length;
	if (rows_len < opts.rows_in_block) {
		return {
			top_offset: 0,
			bottom_offset: 0,
			rows_above: 0,
			rows: rows_len ? rows : this.generateEmptyRow()
		}
	}
	var items_start = Math.max((opts.rows_in_cluster - opts.rows_in_block) * cluster_num, 0),
		items_end = items_start + opts.rows_in_cluster,
		top_offset = Math.max(items_start * opts.item_height, 0),
		bottom_offset = Math.max((rows_len - items_end) * opts.item_height, 0),
		this_cluster_rows = [],
		rows_above = items_start;

	if (this.row_heights) {
		top_offset = this.row_heights.slice(0, items_start).reduce(function(a, b) {
			return a + b;
		}, 0);
		bottom_offset = this.row_heights.slice(items_end - 1).reduce(function(a, b) {
			return a + b;
		}, 0);
	}

	if (top_offset < 1) {
		rows_above++;
	}
	for (var i = items_start; i < items_end; i++) {
		rows[i] && this_cluster_rows.push(rows[i]);
	}
	return {
		top_offset: top_offset,
		bottom_offset: bottom_offset,
		rows_above: rows_above,
		rows: this_cluster_rows
	}
}

To do all this properly and put up a MR for the root repo one should probably go into the direction of extension points. I'd be willing to help revise it if you find the time to do so.

Fell in the same but. Unfortunately, for our case, we won't know the row size previous to cluster update - so cluster height has to be dynamic.
Current workaround we've adopt is to toggle white-space nowrap to normal on row selection. That gives us some way to display the data to user without issues on scrolling.
Yet, this is not the best outcome, as we intend to provide visibility to all data, all the time.
Any hints on how to update the cluster height after all row heights are updated?


Obfuscate the real username to enforce uniqueness

This is just a PoC. Now that I've demonstrated the concept, I'm stopping.
This still needs:

Unit tests
Real documentation
A real UUID instead of Date.now()

Closing this in favor of #140


Expected Behavior After Policy Days

Hello,
What is the expected behavior of the exchange in place holds action item 2 after the retention policy expires? Are you able to HARD delete a item (mailbox or email) after that timeframe?
The section i'm referring to is this:
"Understanding the format of the InPlaceHolds value for retention policies"
Action #2:
2 - Indicates that the retention policy is configured to hold items. The policy doesn't delete items after the retention period expires.
Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4119f918-a0b2-4bdc-535e-11d2c476f675
Version Independent ID: 1520175d-398b-4df1-86db-8ba6b26260df
Content: How to identify the type of hold placed on an Exchange Online mailbox - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/identify-a-hold-on-an-exchange-online-mailbox.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@usvjosh Here's info about retention policy behavior for Exchange: https://docs.microsoft.com/en-us/microsoft-365/compliance/retention-policies-exchange. It describes what happens to items (based on whether they were deleted or not) after the retention period expires.
Also, ability to hard-delete items would assume that no other type of hold (or no other retention policy) is applied to the user mailbox. And, single-item recovery feature will also impact when a hard-deleted items is permanently removed. See https://docs.microsoft.com/en-us/exchange/recipients-in-exchange-online/manage-user-mailboxes/enable-or-disable-single-item-recovery
Hope this helps.


Enable feedback for SendAsync

Prototype: https://github.com/aspnet/SignalR/pull/222
+

throw exception when sending and the connection is before Connected or in Disposed state
HubConnection.Invoke should check the value returned by Connection.SendAsync

Previously tracked as #206

Fixed via abc9109cf39fec53f530a5d3e08cdcd333e0eb9d