Issue with SEQUENCE OF [0] INTEGER definitions encoded as BER/DER.

We've encountered a bug in the decoding of tag definitions of the type SEQUENCE OF INTEGER, where a context ID is given for the integer... Provided below is an example of such an anonymous repeating integer;
BugReport DEFINITIONS IMPLICIT TAGS ::=
BEGIN
   BuggyExample ::= [0] SEQUENCE {
      regularInteger [0] INTEGER OPTIONAL,
      buggySequence [1] SEQUENCE OF [0] INTEGER OPTIONAL
   }
END

An example payload encoded according to this for this would be A0 0E 80 01 7F A1 09 80 01 01 80 01 02 80 01 03.
I've managed to track down where I believe the issues are, and part of it is in the constr_SET_OF.c skeleton code. That it on the SET_OF I assume is because it's a "simplified" sequence of only a single element type, so that part seems plausible.
Line 208 in the current master branch reads:
		rval = elm->type->ber_decoder(opt_codec_ctx,
				elm->type, &ctx->ptr, ptr, LEFT, 0);

The last parameter in this should most likely be altered to elm->tag_mode, as to not always state tag_mode to be 0.
In addition in the generated asn_TYPE_member_tdefinition for the buggySequence members gives that tag_mode for the anonymous integer is +1, whereas the generated code for the regularInteger states that tag_mode is -1. I would be assuming that they should be the same, as they are both defined as [0] INTEGER.
Now, my assumptions may be entirely whack, as I've only had quite short time debugging and understanding what's happening, but changing the above listed "oddities" (which would have to be done manually each time the code is regenerated) made sure that everything decoded properly.

Can add a workaround which works;
Redefine the definition to:
BugReport DEFINITIONS IMPLICIT TAGS ::=
BEGIN
   BuggyExample ::= [0] SEQUENCE {
      regularInteger [0] INTEGER OPTIONAL,
      buggySequence [1] SEQUENCE OF ContextIdInteger OPTIONAL
   },
   ContextIdInteger ::= [0] INTEGER
END

This gives you an additional type definition, but avoids the issues at the cost of a bit of footprint.


Need to explicitly mention that the prometheus-for-paas user is needed when binding apps to the prometheus service

When I followed the steps to just use the container metrics I was unable to bind the container metrics app to prometheus as it needed the prometheus-for-paas user.
The metric export page doesn't contain information about giving the prometheus-for-paas access to the space like in the monitor paas apps doc, would be good to update the page.

Maybe we just need a reference to that page at the top, rather than duplicating the whole thing?

These docs have been significantly updated since this issue was raised. Closing.


[Bug] CSS WorkerManager is no longer accessible/public

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[X] Not reproducible in the monaco editor playground

Monaco Editor Playground Code
No response
Actual Behavior
No response
Expected Behavior
No response
Additional Context
As mentioned here: https://github.com/microsoft/monaco-editor/issues/2746#issuecomment-994927923
OLD
I use CSS completion from HTML. To do so I have done this:
languageId = "html";
require(['vs/language/css/cssMode', 'vs/language/css/cssWorker'], (mode: any, workerMod: any) => {
	// THIS no longer works
	const workerManager = require('vs/language/css/workerManager');
	const worker = function () {
		return client.getLanguageServiceWorker.apply(client, arguments);
	}
	// THIS no longer works
	const languageFeatures = require('vs/language/css/languageFeatures');
	monaco.languages.registerCompletionItemProvider(languageId, new languageFeatures.CompletionAdapter(worker));

HACK
To make it work I go to cssMode.js and add:
__export(cssMode_exports, {
	setupMode: () => setupMode,
	// THIS makes it work
	WorkerManager: () => WorkerManager,
	CompletionAdapter: () => CompletionAdapter,
});

Then I can replace the = requre( with this:
const workerManager = mode;
const languageFeatures = mode;

FIX
Can I have the WorkerManager adapters to becomes "public" again?
This is my first encounter, I will test the other languages and extensions to see if there are more. I know this is not in the public documented stuff - but it would be really nice to have access to these advanced features.
Thanks

The same with monaco-editor/esm/vs/language/typescript/languageFeatures.
I use all those adapters in my custom workers with some preprocessing of the models.

Maybe @alexdima knows more what has changed. But yes, all these modules are not API.
So you get CSS proposals everywhere in the HTML file?

This is a side-effect from bundling the AMD variants with ESBuild. The conceptual difference is that now vs/language/css/workerManager is no longer exposed as an AMD module, it gets completely inlined inside vs/language/css/cssMode.

@aeschli ye, but I do believe a some of us are using them and are ok with the cheese being move - but not when it goes away :) I just think its a regression (from your perspective) due to the new build tooling.. and no - I only get CSS completion and colors inside <style> and style="here" + lint and completion for my own language + XSD schema completion and linting 🕺

To clarify, this is not a regression because these classes were internal and not part of the API described in monaco.d.ts. But I also don't think it is a problem for us to re-export these classes from cssMode.ts.

Could you also consider re-exporting ts/languageServices?

@alexdima Those adapters are really helpful for us :(

Sorry, I've meant this file https://github.com/microsoft/monaco-editor/blob/main/src/typescript/languageFeatures.ts

@mifopen I've also pushed a change to export those classes in vs/language/typescript/tsMode.js

@alexdima Sry if I was not clear enough - I only meant from YOUR (users) perspective 😊 I do use a lot of inner stuff not in the monaco.d.ts to make cool thing happen, but maybe I should investigate just using the typescript source instead as my project is TS already - don't know if that is event possible.. And thanks!

@alexdima When will you have a chance to release a new version of the lib with this fixed? Is it possible till tomorrow?

@alexdima ping? :) btw, what release policy do you use? Shouldn't such bugs just produce new patch version?

@alexdima Sorry for bothering you again and again, but the fix becomes more and more crucial for us :( Could you please release something with it?

@hediet tagging you just in case as I'm not aware about who's responsible for that and what is the process

@mifopen please read my initial post - under "hack" headline

@alexdima Sorry for bothering you again and again, but the fix becomes more and more crucial for us :( Could you please release something with it?

We usually release the monaco editor shortly after the VS Code release. That will be in about three weeks - that way, the editor will be part of our thorough testing process.
You can either roll back to an old version of the monaco editor or build the editor yourself.


Feature/esp eye support

Adding ESP-Eye and Wrover support to main branch

Looks good, we will have to fix the CI later, but for now it's fine, thanks!


feat(amplify-codegen): add headless support

Issue #, if available:
fix #56
fix #60
Description of changes:
Add headless support for amplify codegen add. The change follows the rules of using headless mode in amplify plugins.
How are these changes tested:
yarn test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Is there a reason this was closed? I was looking foward to the headless support


Add mocked tests: update database user

Overview
Enhance test coverage by adding mocked test for the function that updates database user.
Mocked tests do not act against the real API so no real resources are created.
To run mocked tests, run: make test-mocked
Instructions

Clone this repo.
If you haven't already, install Python (version: >= 3.7.2) through their official installer.
CD into the directory and run make install
Open file: tests/mocked/test_databases.py
Add a mocked test for databases.update_user (you can use test_databases_get_user for reference)
API documentation: update_user

Could you assign this to me?

@loosla can you please review PR.


Fix SlotNo Word16 Overflow

Issue Number

#1025
Overview

[x] I have added a regression test and... didn't saw it fail until I forced the evaluation to WHNF :'( (alternatively, could have added a bang ! on the BlockHeader field, but I thought we might as well check everything!)

[x] I have fixed the slot no to be Word16

Comments

We still use this flatSlot to store the slot id into the database. This means that in practice, the Epoch can't be greater than 2^32 =<PHONE_NUMBER>, which, if we had a new epoch every seconds which still give us 3268 years to find a better solution to this problem.

bors r+

bors r+


Made the scrolltop button responsive and changed the css of home page…

… to make it look more attractive
Before

After

please resolve conflicts and also do some styling for the read more functionality as it's not looking good

@Himanshi1207 please respond, otherwise will close this pr on saturday.

closing this pr as no reply from last 2 weeks


Updating to account for new contributors guide.

Primary links will go to the contributor's guide.
Funnel newbies to detail guide but leave behind some quick tips for impatient experienced folks.
Reduced some redundancy in language.
Sentence case all the headings.
@docker/maintainers and so forth...please to review.  LGTM once copy-edits are fixed.

Nits picked up and kicked out.

@thaJeztah I'll pick that up next time I'm in the file. I kinda want to get this out. Takes a bit to build.

No problem at all, I realise there's pressure for the bday party. Just noted the issues while reading

LGTM


battle-net: update install filename

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

On my machine, I end up with this:
$ ls /opt/homebrew-cask/Caskroom/battle-net/latest
Battle.net-Setup.app

Not sure if the installer name has just changed over time?

Not sure if the installer name has just changed over time?

Yes, sometimes this happens. Thank you for noticing and submitting a PR.


Laboratory work #1, Eva Patrakova - 19FPL2

@EvaPatrakova
Please, rename your Pull Request. Use this template – Laboratory work #1, Fedorov Makar - 19FPL1

Unfortunately, the deadline is not that far. Please, push changes so that we can review them.

do not forget about target_score.txt and start.py

I change some functions, but I have some problems with get_concordance function: it doesnt work with bad_input in the place of word and I dont have an idea how to fix it

tests fail when left_context_size/right_context_size = True or False
just add simple check on this type

For better checking some of the functions, I needed to fix some tests because there was wrong file path. Do I need to push new tests` programmes for it?

do not push (if you mean "lab_1/")

delete everything from target score and put 8 there

Work on lint, make a pipeline green

correct two issues (about RESULT and print)

Open another PR with the second lab


Removing ANSIBLE_ENABLE_TASK_DEBUGGER

ref: https://github.com/ansible/ansible-runner/issues/1327

/override rdoproject.org/github-check
CI failure is related to variable names from https://github.com/openstack-k8s-operators/ovn-operator/blob/main/config/default/manager_default_images.yaml x https://github.com/openstack-k8s-operators/dataplane-operator/blob/main/config/default/manager_default_images.yaml


Don't work api weather

Problems at time to make requests for API Weather due to Heroku Application Error.

Thanks for letting me know and sorry for the inconvenience @JulianP911 .
The API is back, can you confirm?

Yes, it's back.
Thanks @robertoduessmann


Auto-import doesn’t work with a bunch of LSPs

Checkhealth
Put result of :checkhealth compe.
health#compe#check
========================================================================
## compe:snippet
  - OK: snippet engine detected.

## compe:mapping
  - OK: `compe#complete` is mapped: (`i  <C-Space>     compe#complete()`)
  - OK: `compe#confirm` is mapped: (`i  <CR>          compe#confirm('<CR>')`)
  - INFO: `compe#close` is not mapped
  - INFO: `compe#scroll` is not mapped

Describe the bug
Auto-imports doesn’t work with some LSPs (tried with purescriptls and hls). I figured it’s likely a bug in nvim-compe as it works with rust-analyzer.
To Reproduce
Steps to reproduce the behavior with the minimal config:

Open a Haskell or PureScript project.
Cry.

nvim-compe does not support purescript-ls.
You can use nvim-cmp successor of nvim-compe.


stdenv: runPhase returns status

Description of changes
The relatively new runPhase function in stdenv seems to be the best practice for building packages within a devshell, rather than manually executing sub-commands (e.g., cmake .. && make). This creates better consistency between dev workflow and the eventual realized derivation created by nix build.
However, the runPhase command obscures any failures which take place within the individual build phases. To fix that problem, this PR installs an ERR trap handler within the subshell created by eval and sets a return value to 1 on the first non-zero exit status.
~My primary motivation was to allow better scripting around runPhase, e.g., run phases consecutively only if prior phases succeed, alert on errors. However it seems like this would facilitate a change to make genericBuild halt on any failed phases, which could be meaningful for CI pipelines. Happy to have that conversation here or in a separate forum. Also would appreciate links to any prior conversations about this behavior within stdenv genericBuild/runPhase.~
(Edit: I have since discovered that stdenv invokes genericBuild with -e shell option, causing immediate exit on failure when using e.g., nix build. Importantly, set -e is not a viable option in the devshell since it causes the devshell to exit on failure.)
I realize this PR has broad impact, despite being relatively low risk. In light of that and Hyrum's Law, I'm also open to making a flag or separate function so that the return value of runPhase is unaffected in current usage.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Bisect says 8e1442adb28858e61d893f943f844d0ce688f2e6 Add return value to runPhase bash function in stdenv broke systemdMiniman in staging as:
$ nix build --no-link -f. -L systemdMinimal
...
systemd-minimal> Found ninja-1.12.1 at /nix/store/6bmi344xip8d8cp8llbn31w0m0i7v9xr-ninja-1.12.1/bin/ninja
systemd-minimal> mesonConfigurePhase: enabled\ parallel\ building
systemd-minimal> substituteStream() in derivation systemd-minimal-256.8: WARNING: pattern SYSTEMD_CGROUP_AGENTS_PATH doesn't match anything in file 'config.h'

Bisect says https://github.com/NixOS/nixpkgs/commit/8e1442adb28858e61d893f943f844d0ce688f2e6 Add return value to runPhase bash function in stdenv broke systemdMinimal in staging.

Indeed it did. I'm taking a look, but I welcome all sorts of help.

I can't see what command is failing! I added a bunch of set -x but no indications on what's actually causing the failure in the subshell.

If you throw NIX_DEBUG in it gives a hint:
--- a/pkgs/os-specific/linux/systemd/default.nix
+++ b/pkgs/os-specific/linux/systemd/default.nix
@@ -553,0 +554 @@ stdenv.mkDerivation (finalAttrs: {
+  NIX_DEBUG = "7";

$ nix build --no-link -f. -L systemdMinimal
...
systemd-minimal>  evaling implicit 'postConfigure' string hook
...
systemd-minimal> ++ return 0
systemd-minimal> ++ date +%s
systemd-minimal> + endTime=1733249932
systemd-minimal> + showPhaseFooter configurePhase<PHONE_NUMBER><PHONE_NUMBER>
systemd-minimal> + local phase=configurePhase
systemd-minimal> + local startTime=1733249919
systemd-minimal> + local endTime=1733249932
systemd-minimal> + local delta=13
systemd-minimal> + ((  delta < 30  ))
systemd-minimal> + return
systemd-minimal> + '[' configurePhase = unpackPhase ']'
systemd-minimal> + return 1
systemd-minimal> + exitHandler
systemd-minimal> + exitCode=1
systemd-minimal> + set +e
systemd-minimal> + '[' -n '' ']'
systemd-minimal> + ((  1 != 0  ))
systemd-minimal> + runHook failureHook
systemd-minimal> + local hookName=failureHook
systemd-minimal> + shift
systemd-minimal> + local 'hooksSlice=failureHooks[@]'
systemd-minimal> + local hook
systemd-minimal> + for hook in "_callImplicitHook 0 $hookName" ${!hooksSlice+"${!hooksSlice}"}
systemd-minimal> + _logHook failureHook '_callImplicitHook 0 failureHook'
systemd-minimal> + [[ -z 2 ]]
systemd-minimal> + local hookKind=failureHook
systemd-minimal> + local 'hookExpr=_callImplicitHook 0 failureHook'
systemd-minimal> + shift 2
systemd-minimal> + declare -F '_callImplicitHook 0 failureHook'
systemd-minimal> + type -p '_callImplicitHook 0 failureHook'
systemd-minimal> + [[ _callImplicitHook 0 failureHook != \_\c\a\l\l\I\m\p\l\i\c\i\t\H\o\o\k* ]]
systemd-minimal> + _eval '_callImplicitHook 0 failureHook'
systemd-minimal> + declare -F '_callImplicitHook 0 failureHook'
systemd-minimal> + eval '_callImplicitHook 0 failureHook'
systemd-minimal> ++ _callImplicitHook 0 failureHook
systemd-minimal> ++ local def=0
systemd-minimal> ++ local hookName=failureHook
systemd-minimal> ++ declare -F failureHook
systemd-minimal> ++ type -p failureHook
systemd-minimal> ++ '[' -n '' ']'
systemd-minimal> ++ return 0
systemd-minimal> + return 0
systemd-minimal> + '[' -n '' ']'
systemd-minimal> + return 1

Ah. I believe systemd's derivation makes use of set +e; ...; set -e to mask possible errors in the configure phase. This approach is caught by the new ERR trap handler introduced in this PR and causes config phase to return non-zero.
I'm not sure how widespread this pattern is (set +e), but a packaging fix which preserves this PR would be to use the more common || true idiom for bash commands that may fail.
Happy to discuss alternatives if this PR is going to generate an untenable number of packaging fixes. (e.g., adding another alias to use in devshell with the ERR trap behavior, runPhase2)

$ rg -F 'set +e' -l --sort=path
ci/eval/default.nix
nixos/modules/services/backup/btrbk.nix
nixos/modules/services/mail/spamassassin.nix
nixos/modules/services/misc/ollama.nix
nixos/modules/services/networking/jibri/default.nix
nixos/modules/system/activation/lib/test.sh
nixos/modules/virtualisation/nixos-containers.nix
pkgs/build-support/checkpoint-build.nix
pkgs/build-support/docker/default.nix
pkgs/build-support/fetchpatch/default.nix
pkgs/build-support/rust/build-rust-crate/configure-crate.nix
pkgs/build-support/testers/hasPkgConfigModules/tester.nix
pkgs/by-name/ax/ax25ms/package.nix
pkgs/by-name/da/darling/package.nix
pkgs/by-name/de/devmode/package.nix
pkgs/by-name/fl/fluxcd/update.sh
pkgs/by-name/ni/nixos-install/nixos-install.sh
pkgs/by-name/sc/scion/package.nix
pkgs/development/compilers/factor-lang/factor99.nix
pkgs/development/python-modules/invisible-watermark/tests/cli.nix
pkgs/development/python-modules/semgrep/update.sh
pkgs/misc/my-env/default.nix
pkgs/os-specific/bsd/netbsd/pkgs/mkDerivation.nix
pkgs/os-specific/linux/systemd/default.nix
pkgs/test/build-environment-info/default.nix
pkgs/test/texlive/default.nix
pkgs/top-level/nixpkgs-basic-release-checks.nix

It's a list, but not that bad.

I am more concerned that the expectation of the community is roughly "stdenv invokes the default builder (i.e., genericBuild) with the -e shell option, and therefore I can suppress the option to suppress failing commands.
Studying this a little more closely after several months, it may be better to make a change which exclusively affects devshells making the runPhase behavior more consistent with nix build (which uses set -e). I can't work on this immediately, but would suggest a rollback of this commit for now.

Reverted in https://github.com/NixOS/nixpkgs/commit/41d4a66bba6843f060c41f385fd00f8e89eda0ae so people can continue working on the staging branch.

Thanks @mweinelt. That's definitely the right call for the present.
Right now (immediately after the 24.05 release) is the right time to consider taking breaking changes to the stdenv, in my view, should we get the nixpkgs tree in shape for them. So I'd like to consider taking this change as first proposed, then rooting out set +e in nixpkgs. Open to feedback about how that's the wrong approach, but that's my inclination.

To further characterize the two options that I proposed here:
Option A: ERR trap handler

Any pipeline, list, or compound command with a non-zero exit status will trigger the trap handler and set retval nonzero
Remaining commands in the stdenv phase variable / function may be executed

Option B: subshell with errexit option (see above reply)

Any pipeline, list, or compound command with a non-zero exit status will cause the subshell to exit (but not the devshell)
runPhase function can capture the subshell exit status and return that val
Remaining commands in the phase var / function will not be executed

On further reflection, I'm partial to option B. It's more consistent with popular CI execution environments and probably a little easier to reason about.


presenterm: 0.7.0 -> 0.8.0

Description of changes
Changelog: https://github.com/mfontanini/presenterm/releases/tag/v0.8.0
cc @mikaelfangel

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Smart Search Not working

When searching clients through admin panel it just displays nothing even if client is there, tested in mozilla, chrome.

I have just tried and it works flawlessly in our test environment. Are you sure that your are typing user name correctly? If you are sure that it is not working, please submit support ticket from member area with your login credentials so that we could check it.


Browser UiConfiguration does not get viewport height correctly

It's always 0.

This is #1456. The height of the <div> starts at 0, obviously, and then once it resizes we never report that size because we aren't watching the change.


fusion of all configuration files in configuration_config.yml

These are the current configuration files for the module upon installation:
classification_config.yml
general_config.yml
keyboard_shortcuts_config.yml
label_config.yml

Pull request includes deletion of four mentioned configuration files and addition of configuration_config.yml which includes their contents. Includes simplification of main file.
#68 states that these files are too confusing and should be regrouped into a single configuration file modifiable by the Configuration Window upon startup of the module.
Pull request should be tested to see if any errors come from not being able to access the new configuration_config.yml
There is a known bug in this pull request that opens up two SlicerCARTConfigurationSetupWindows after Configure segmentation... is clicked.
See screenshots for more information regarding the reproduction of this bug:
First step

Second step

Add labels, toggle the timer checkbox, etc. **Then click on Apply**
Third step

Two configuration windows appear for no apparent reason. The issue is not reproducible when Configure classification... is clicked on step 1 instead of Configure segmentation...

I have a feeling that this problem is with Qt and Slicer itself. The logic itself to handle window opening and closing is often not robust on my side - windows open & load slowly, windows will close and open inconsistently, etc. Maybe an issue with the fact that I'm using Windows?

Issue fixed. There were two lines of code connecting to the opening of the ConfigurationSetupWindow. Code fragmentation is a top priority as this issue could have been resolved much easier with easier legibility.


Promoting a docker image script calls chart publish instead of promote-docker-image.

There is currently an issue where promoting the docker image script is calling the chart-publish instead of the promote-docker-image step and it's causing builds to fail.
We should fix this properly and do a test on it by re-tagging the version. Once the version is re-tagged to a test that it succeeds.

Available to test with master-head c3529070ec1aaeed5ca7f.

Available to test in v2.6.0-rc1

@superseb Should I be retagging a RC version to test this?

I'll test it tomorrow

@superseb Have we tested that this is working off of the release branches?

@superseb are you testing this or should someone else ? dev-validate got added

@cbron Not sure why this was labeled as dev-validate, I guess it makes sense as I created it.
I just tested it on v2.6.0-rc5:
$ bash scripts/promote-docker-image.sh v2.6.0-rc5 donotuse
drone version 1.3.0
Promoting v2.6.0-rc5 to donotuse
Finding build number for tag v2.6.0-rc5
Found build number 6370 for tag v2.6.0-rc5
Number: 6381
Status: pending
Event: promote
Commit: 863351dc2c3a4ad4e49281cecd62e9adc5c3de5c
Branch: release/v2.6
Ref: refs/tags/v2.6.0-rc5
Author: kinarashah<EMAIL_ADDRESS>Message: Merge pull request #34366 from kinarashah/rc5

[2.6] update ui tag for 2.6.0-rc5

Docker Hub shows both archs present for donotuse tag, running it shows v2.6.0-rc5.
Someone can still dev-validate it, I think @aiyengar2 was planning to do it.

Validation: PASSED
Steps used to validate:

Setup connection to Rancher drone server (connection info can be found in your user settings)
Run bash scripts/promote-docker-image.sh v2.6.0-rc6 donotuse using the latest rc version and see the following output

$ bash scripts/promote-docker-image.sh v2.6.0-rc6 donotuse
drone version 1.2.4
Promoting v2.6.0-rc6 to donotuse
Finding build number for tag v2.6.0-rc6
Found build number 6388 for tag v2.6.0-rc6
Number: 6409
Status: pending
Event: promote
Commit: b43e4d955c8fdbb85bbbba1962937b0abbdf4a09
Branch: release/v2.6
Ref: refs/tags/v2.6.0-rc6
Author: kinarashah<EMAIL_ADDRESS>Message: Merge pull request #34397 from kinarashah/rc6

[v2.6] update ui tag and rke for v2.6.0-rc6

I am able to see both archs present for donotuse tag in Docker Hub
Running docker run -d --restart=unless-stopped -p 80:80 -p 443:443 --privileged rancher/rancher:donotuse shows v2.6.0-rc6


Download influxdb-0.11.0-1 ?

I am unable to locate standalone 64bit binary of influxdb-0.11.0-1 ? I do not see "Older releases link" on influxDB website.
As influxdb-0.11.0-1 is last stable release with cluster support that is open sourced, it might be important for most of us looking for open source version with cluster support.
Please provide with a link.

You can build it from the tag that's in the repository. There's a download link here, but I do not guarantee it will stay there forever.
I also highly advise you do not use this. Clustering was not complete in that version. If you want an open source solution, the Influx Relay is probably your best bet.

Your documentation says we have to use it to upgrade to a newer version; so having downloads available would be nice (I got my binaries out of a backup).

They are also listed in the 0.12 documentation along with the upgrade instructions here:
https://docs.influxdata.com/influxdb/v0.12/administration/upgrading/#urls-for-influxdb-0-11


Allow the bundle to work without the annotation reader

Describe the bug
With Symfony 6.4 we get this deprecation:

Since symfony/framework-bundle 6.4: Enabling the integration of Doctrine annotations is deprecated. Set the "framework.annotations.enabled" config option to false.

However, disabling the annotation reader produces this exception (I guess there would be more):

The service "stof_doctrine_extensions.listener.timestampable" has a dependency on a non-existent service "annotation_reader".

To Reproduce

install Symfony 6.4-dev
install this bundle & enable e.g. Timestampable
disable annotation reader in FrameworkBundle config

Expected behavior
The bundle should be able to work without the annotation reader enabled.
Additional context
N/A

@stof Could you maybe release this change, I also ran into this exception when trying to disable the annotations reader in the symfony framework config

@bartholdbos I tagged the 1.9.0 release

Thank you! :+1:


host.adduser doesn't support group keyword argument

In DistConfig, addusers function in utils.py:
        for username, details in self.users.items():
        primary_group = None
        groups = details.get('groups', [])
        if groups:
            primary_group = groups[0]
        host.adduser(username, group=primary_group)
        for group in groups:
            host.add_user_to_group(username, group)

host.adduser doesn't support group keyword argument. It seems most of the bigdata Charms use a patched charmhelpers library to circumvent this. The patched charmhelpers causes all kinds of problems when porting Charms to the reactive framework + jujubigdata layer. Is it possible to either merge the adduser patch into charmhelpers or put the patched version in this library?
Thanks!

Pull request https://github.com/juju-solutions/jujubigdata/pull/19 would solve this problem, although I'm not sure how Hadoop permissions will react to the user's primary group not being hadoop anymore.

I'm leaning more and more toward porting the host.adduser change from our branch to upstream charmhelpers.

https://code.launchpad.net/~johnsca/charm-helpers/adduser-group/+merge/278649

cosed with #24


require Payment from /lib/payment, as /src/ is .coffee

just saw the previous https://github.com/shatran/card-react/pull/3 ... sorry for the spam

@hhursev i understand this cause you errors when trying to include card-react?

yep :) As it cannot find /lib/payment/ (it is .coffee file).
But I use webpack and it says requiring from prebuild js file is not recommended. So my approach is wrong.
$ npm info card-react version
$ 1.0.18


Initial add of Hyper

[ ] Change default terminal to Hyper?
[ ] Enable extensions (yadm or ansible template)

https://github.com/romkatv/powerlevel10k


Graphics only returning vram for controller

Issue Type

[x] Bug
[ ] Feature Request
[ ] Question

Expected behavior
Graphics to return model, vendor, bus and vramDynamic.
Actual behavior
{
	"graphics": {
		"controllers": [
			{
				"vram": 8
			}
		],
		"displays": []
	}
}

Specifications

package version: 3.52.2
operating system: Unraid 6.6.5
hardware: Built in VGA on Dell R710.

As I have another issue with graphics, I will have a closer look on this...

Check on my Macbook I get the same issue.
root@Devon:/mnt/user/code/api# node -r esm
> import si from 'systeminformation'
undefined
> si.graphics().then(console.log)
Promise {
  <pending>,
  domain:
   Domain {
     domain: null,
     _events:
      { removeListener: [Function: updateExceptionCapture],
        newListener: [Function: updateExceptionCapture],
        error: [Function: debugDomainError] },
     _eventsCount: 3,
     _maxListeners: undefined,
     members: [] } }
> { controllers: [ { vram: 8 } ], displays: [] }

May I ask you to provide full output of
system_profiler SPDisplaysDataType on your Mac (and with OS version you are running)
as well as full output of
lspci -vvv  2>/dev/null and xrandr --verbose 2>/dev/null on your linux machine?
Thank you in advance!

Here's the Mac details. Just booting up my server now and I'll edit this post.
Graphics/Displays:

    Intel HD Graphics:

      Chipset Model: Intel HD Graphics
      Type: GPU
      Bus: Built-In
      VRAM (Dynamic, Max): 288 MB
      Vendor: Intel (0x8086)
      Device ID: 0x0046
      Revision ID: 0x0018
      Automatic Graphics Switching: Supported
      gMux Version: 1.9.21

    NVIDIA GeForce GT 330M:

      Chipset Model: NVIDIA GeForce GT 330M
      Type: GPU
      Bus: PCIe
      PCIe Lane Width: x16
      VRAM (Total): 256 MB
      Vendor: NVIDIA (0x10de)
      Device ID: 0x0a29
      Revision ID: 0x00a2
      ROM Revision: 3560
      Automatic Graphics Switching: Supported
      gMux Version: 1.9.21
      Displays:
        Color LCD:
          Display Type: LCD
          Resolution: 1440 x 900
          Pixel Depth: 32-Bit Color (ARGB8888)
          Main Display: Yes
          Mirror: Off
          Online: Yes
          Rotation: Supported
          Automatically Adjust Brightness: Yes

Weirdly enough I'm now seeing the correct details on my Macbook.
"controllers": [
    {
        "model": "Intel HD Graphics",
        "bus": "Built-In",
        "vram": 288,
        "vramDynamic": true,
        "vendor": "Intel"
    },
    {
        "model": "NVIDIA GeForce GT 330M",
        "bus": "PCIe",
        "vram": 256,
        "vramDynamic": false,
        "vendor": "NVIDIA"
    }
],
"displays": [
    {
        "model": "Color LCD",
        "main": true,
        "builtin": false,
        "connection": "",
        "sizex": -1,
        "sizey": -1,
        "resolutionx": 1440,
        "resolutiony": 900,
        "pixeldepth": 32
    }
]

@OmgImAlexis just to be sure:

so macOS is now working? I was not able to reproduce the problem on macOS.
for your linux graphics controller: I found the issue why I was not detecting the controller. Will provide a fix for that today ...
for the connected linux displays: as xrandr --verbose 2>/dev/null does not return anything, I guess you are running without a display manager?? Does one of the following directories /sys/class/backlight/ or /proc/acpi/video/ exists and have any content?

Thank you in advance.

Just published v3.52.4 which should detect your graphics card correctly (linux)...

Tested with v3.52.4.
Neither /sys/class/backlight/ or /proc/acpi/video/ exists.
Anything else I could check?
Macbook:
➜  api git:(master) ✗ node -r esm
> import si from 'systeminformation'
undefined
> si.graphics().then(console.log)
Promise {
  <pending>,
  domain:
   Domain {
     domain: null,
     _events:
      { removeListener: [Function: updateExceptionCapture],
        newListener: [Function: updateExceptionCapture],
        error: [Function: debugDomainError] },
     _eventsCount: 3,
     _maxListeners: undefined,
     members: [] } }
> { controllers:
   [ { model: 'Intel HD Graphics',
       bus: 'Built-In',
       vram: 288,
       vramDynamic: true,
       vendor: 'Intel' },
     { model: 'NVIDIA GeForce GT 330M',
       bus: 'PCIe',
       vram: 256,
       vramDynamic: false,
       vendor: 'NVIDIA' } ],
  displays:
   [ { model: 'Color LCD',
       main: true,
       builtin: false,
       connection: '',
       sizex: -1,
       sizey: -1,
       resolutionx: 1440,
       resolutiony: 900,
       pixeldepth: 32 } ] }

Linux:
root@Devon:/mnt/user/code/api# node -r esm
> import si from 'systeminformation'
undefined
> si.graphics().then(console.log)
Promise {
  <pending>,
  domain:
   Domain {
     domain: null,
     _events:
      { removeListener: [Function: updateExceptionCapture],
        newListener: [Function: updateExceptionCapture],
        error: [Function: debugDomainError] },
     _eventsCount: 3,
     _maxListeners: undefined,
     members: [] } }
> { controllers:
   [ { vendor: 'Matrox Electronics Systems Ltd.',
       model: 'MGA G200eW WPCM450',
       vram: 8 } ],
  displays: [] }

@OmgImAlexis So at least is some progress ;-) I would consider the macOS problem as solved, OK?
May I ask some additional questions (for the linux part - here the display detection is still missing)?

so the Dell R710 is used as a server, right?
the OS is Unraid 6.6.5 (as far as I know this is based on Slackware)?
are you running your machine in run level 3 (without any desktop UI / windows manager)?
if you are running your machine in run level 5 (with a windows manager), which one are you using?

For run level 3 I did not yet found a way to reliably check a connected display resolution, color depth. The solution I implemented is only working fine in run level 5.

@OmgImAlexis Unraid uses run level 3 normally unless you're booted in to Desktop GUI mode.  In that case it is in run level 4 using the Fluxbox windows manager.

@eschultz thank you. 🙏
@sebhildebrandt I was booted into normal mode(level 3) when running those tests.
Should I try again in Desktop GUI mode(level 4)?

So I guess when used as a server in run level 3, display information is maybe not important. Only if you have time, a bootup in run level > 3 would be nice to see if I can detect any display information. Thank you once again for your support!

The main reason for wanting all the info even in level 3 is that I’ll be using the graphics options, etc to launch virtual
machines.
I’ll do a reboot today into GUI mode and see if it changes the results. Shall I just check the same details as https://github.com/sebhildebrandt/systeminformation/issues/184#issuecomment-450232306?

So I just rebooted into level 4 and same issue. That command returns nothing and neither directory exists.

Thank you @OmgImAlexis , seems that this is a little different either with Slackware or with Fluxbox. I will make a little research and hopefully come back with a solution.

So first research results: also fluxbox (the one that was mentioning above) should also return something when running xrand as this is also a windowmanager for X (see also http://fluxbox-wiki.org/category/howtos/en/Change_resolution.html). So if you do not get any results from xrandr this seems to be difficult to get proper display information. I do not see any reliable way to get proper information at the moment :-(
@eschultz : any ideas ???

Should work now. Version 4.0.0 published


Fix comment overflow and ensure content fits within div

Proposed Changes

Fixes #8699
Adjusted comment wrapping in the UI for better readability.

@ohcnetwork/care-fe-code-reviewers

Merge it into #8722


Default screen height should be the documentHeight

The default document height for screenshots is set to 1500px, this causes issues with some pages which are longer than this. Current workaround is to set something like:
screen_widths:

320x5000
600x5000
1024x5000

in order to get the full page in the screenshot. This obviously isn't ideal if we end up with a very long page.

We could quite easily set the viewport height to the full document height, but I wonder what effect that would have when diffing images with different heights?
Feel free to experiment -- you should be able to do this by changing the following line in javascript/_getDimensions.js from
'viewportHeight': parseInt(dimensions[2] || 1500)

to
'viewportHeight': parseInt(dimensions[2] || document.body.offsetHeight)

Hmm, this isn't an easy fix. These dimensions are passed to Phantom/Casper before it loads the page - so the height is unreliable. Not to mention that the height might change at runtime, or after you do something with the before_capture hook.
I think what you'll want to do is put this in your YAML config:
before_capture: javascript/resizeHeight.js
And make a resizeHeight.js file something along the lines of:
module.exports = function (phantom) {
    phantom.viewportSize.height = document.body.offsetHeight;
    phantom.open(phantom.page.url);
}

I've been running into the same issue, wanting to get the the full page height, while using wraith with history/latest. We've used wraith in the past and the output was full height. I'm not sure if thats a change in wraiths behaviour, or perhaps in an un-versioned dependency on phantomjs behaving differently?
Currently, i'm trying to put together a wraith config for a new app, using the latest version of wraith, and a modern config (which is :+1: better). The behaviour we're after is full page height capture and image diffs.
I tried some variations of the phantom.viewportSize.height suggestion, but unfortunately couldn't get it to alter the capture height - it also looks like crop_images would override that before the diff is generated anyway :/
It sounds like this isn't supported right now, and not straight forward to add? If I can find the time i'd be interested in looking into this in more detail, but i'd be good to get a steer first :smile:

I, too, consider this a huge failing of version 3.x, as capturing with an arbitrarily large height of, say, 10000px has a major performance impact. A job that used to take about 2-3 minutes with version 2.x now takes over 10 minutes to perform the same analysis.
Why was this changed from version 2? Can the old behavior be restored?

I hear you - it would definitely be great to fix this.
Reopening the issue by popular demand, will try to look at this more closely in the coming weeks. In the meantime, pull requests are welcome!
Wraith v3.1.1 has more resilient image cropping, so should cope with dynamic heights much better, so hopefully this issue can be fixed more easily now.

From what I'm seeing in phantom.js there is no way to set the dimensions via a before_capture script as they will always be overridden by the configured dimensions.
@ChrisBAshton What needs to be done to move https://github.com/BBC-News/wraith/pull/439 forward?

Hello,
I currently use the version 4.0.0 with phantomjs but I still have the same issue when I didn't specify a height in the screen_widths attribute it is still resized to 1500px.
The _getDimensions.js didn't exist in the project should I create it? What is his content?
Regards,
Benjamin V.

Hello,
My friend and colleague found a wonderful solution to this issue. All we had to do was reduce the default height in helper.js to 100 instead of 1500 px in the function getWidthAndHeight(), and comment the line page.clipRect in Phantom.js to prevent setting the height. The code then takes the rendered height of the page for the screenshot!!! Try out and let us know how it works out...

If this helps, I seem to have Wraith producing full-screen screenshots using Casper and the following:

Set a small, arbitrary height under the screen_widths section of the capture file and then have a pre-capture script similar to the below.

module.exports = function (casper, ready) {     // test interaction on the page     casper.wait(5000, function() {         casper.viewport(320, 765); // this seems to take a dynamic height?         ready();     }); }

@rithipooh That worked perfectly fine. Do we really have to change the _helper.js file? Did not understand why that is being done. page.clipRect basically did the magic.

You can get full-page screenshots by commenting out a few lines in lib/wraith/javascript/phantom.js
diff --git a/lib/wraith/javascript/phantom.js b/lib/wraith/javascript/phantom.js
index 78f1a89..9332b86 100644
--- a/lib/wraith/javascript/phantom.js
+++ b/lib/wraith/javascript/phantom.js
@@ -132,12 +132,12 @@ function resizeAndCaptureImage() {

 function takeScreenshot() {
   console.log('Snapping ' + url + ' at: ' + currentDimensions.viewportWidth + 'x' + currentDimensions.viewportHeight);
-  page.clipRect = {
-    top: 0,
-    left: 0,
-    height: currentDimensions.viewportHeight,
-    width: currentDimensions.viewportWidth
-  };
+  // page.clipRect = {
+  //   top: 0,
+  //   left: 0,
+  //   height: currentDimensions.viewportHeight,
+  //   width: currentDimensions.viewportWidth
+  // };
   page.render(image_name);
 }

Hi guys,
I have the same issue.
The fix to phantomjs seems to work fine, can this be fixed in Wraith?
I call this from within CI and every time spin a new docker instance so it would be awesome if it comes correct on install.
Cheers,

@ssteigen's solution works perfect for me.
(I have only one item in screen_widths)

Is there any news on this?

All,
There is a teribble, awful, awful way to workaround this without having to modify the core code so that it addresses this comment from @duartegarin.
If it weren't for the immediate need to have this resolved, I would never do this but what you can do is copy the snap file phantom.js and it's helper class _helper.js into your project directory, make the change to phantom.js described in this comment from @ssteigen.  Then use the old snap_file config property to point to your local copy of phantom.js.
Again, I caution this is a terrible solution as you won't pick up maintenance or enhancements to the core copies of these files, but it will get you a temporary solution that works around having to patch the core code.

Here is a PR that attempts to integrate the suggestions above.
https://github.com/BBC-News/wraith/pull/572

Hey. I'm stuck with this issue. Was this issue resolved?

We're considering using Wraith on a project and would also be interested in a resolution.


Does the cgroup can make better?

Description of problem
Hi, I try to use podoverhead in kata-containers,but i have some questions.

The kata-container config:

sandbox_cgroup_only=true

The runtimeclass crd yamlruntimeclass_crd.yaml:

apiVersion: apiextensions.k8s.io/v1beta1
metadata:
  name: runtimeclasses.node.k8s.io
  labels:
    addonmanager.kubernetes.io/mode: Reconcile
spec:
  group: node.k8s.io
  version: v1alpha1
  versions:
    - name: v1alpha1
      served: true
      storage: true
  names:
    plural:   runtimeclasses
    singular: runtimeclass
    kind:     RuntimeClass
  scope: Cluster
  validation:
    openAPIV3Schema:
      properties:
        spec:
          properties:
            runtimeHandler:
              type: string
              pattern: '^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*)?$'
            runtimeCpuReqOverhead:
              type: string
              pattern: '^([0-9]+([.][0-9])?)|[0-9]+(m)$'
            runtimeCpuLimitOverhead:
              type: string
              pattern: '^([0-9]+([.][0-9])?)|[0-9]+(m)$'
            runtimeMemoryReqOverhead:
              type: string
              pattern: '^[0-9]+([.][0-9]+)+(Mi|Gi|M|G)$'
            runtimeMemoryLimitOverhead:
              type: string
              pattern: '^[0-9]+([.][0-9]+)+(Mi|Gi|M|G)$'

The runtimeclass yamlkata_v2_class.yaml:

apiVersion: node.k8s.io/v1beta1  # RuntimeClass is defined in the node.k8s.io API group
kind: RuntimeClass
metadata:
  name: kata-containers  # The name the RuntimeClass will be referenced by
  # RuntimeClass is a non-namespaced resource
handler: kata
overhead:
    podFixed:
        memory: "1024"
        cpu: "1"

The pod yamlbusybox-two.yaml:

apiVersion: v1
kind: Pod
metadata:
  name: busybox-two
spec:
  runtimeClassName: kata-containers
  containers:
  - name: busybox-1
    image: busybox
    stdin: true
    tty: true
    imagePullPolicy: IfNotPresent
    resources:
      limits:
        cpu: 1
  - name: busybox-2
    image: busybox
    stdin: true
    tty: true
    imagePullPolicy: IfNotPresent
    resources:
      limits:
        cpu: 1

Execute commands as below:

kubectl apply -f runtimeclass_crd.yaml

kubectl apply -f kata_v2_class.yaml

kubectl apply -f busybox-two.yaml

We can see the pod is running.
[root@host-69 yaml]# kubectl get pods
NAME          READY   STATUS    RESTARTS   AGE
busybox-two   2/2     Running   0          4h51m

Then, I go to the pod cgroup:
[root@host-69 pod21390dc3-79c0-46f1-9f1d-00be3aec9cc9]# pwd
/sys/fs/cgroup/cpu/kubepods/burstable/pod21390dc3-79c0-46f1-9f1d-00be3aec9cc9
[root@host-69 pod21390dc3-79c0-46f1-9f1d-00be3aec9cc9]# cat cpu.cfs_period_us
100000
[root@host-69 pod21390dc3-79c0-46f1-9f1d-00be3aec9cc9]# cat cpu.cfs_quota_us
300000
[root@host-69 pod21390dc3-79c0-46f1-9f1d-00be3aec9cc9]# cat cgroup.procs
[root@host-69 pod21390dc3-79c0-46f1-9f1d-00be3aec9cc9]#

Then go to the sandbox cgroup:
[root@host-69 kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92]# pwd
/sys/fs/cgroup/cpu/kubepods/burstable/pod21390dc3-79c0-46f1-9f1d-00be3aec9cc9/kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92
[root@host-69 kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92]# cat cpu.cfs_period_us
100000
[root@host-69 kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92]# cat cpu.cfs_quota_us
200000
[root@host-69 kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92]# cat cgroup.procs
1840
1943
1946
[root@host-69 kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92]#

And the  pids and process:
[root@host-69 kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92]# ps aux | grep 1840
root      1840  0.1  0.0<PHONE_NUMBER>4 ?        Sl   10:03   0:31 /usr/bin/containerd-shim-kata-v2 -namespace k8s.io -address /run/containerd/containerd.sock -publish-binary /usr/bin/containerd -id 57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92 -debug
[root@host-69 kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92]# ps aux | grep 1943
root      1943  0.4  0.1 2775560 179664 ?      Sl   10:03   1:12 /usr/bin/qemu-vanilla-system-x86_64 -name sandbox-57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92 -uuid 7a7c089a-f268-4f3c-b0ec-4f31f570b0f0 -machine pc,accel=kvm,kernel_irqchip,nvdimm -cpu host -qmp unix:/run/vc/vm/57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92/qmp.sock,server,nowait -m 2048M,slots=10,maxmem=97494M -device pci-bridge,bus=pci.0,id=pci-bridge-0,chassis_nr=1,shpc=on,addr=2,romfile= -device virtio-serial-pci,disable-modern=false,id=serial0,romfile= -device virtconsole,chardev=charconsole0,id=console0 -chardev socket,id=charconsole0,path=/run/vc/vm/57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92/console.sock,server,nowait -device nvdimm,id=nv0,memdev=mem0 -object memory-backend-file,id=mem0,mem-path=/usr/share/kata-containers/kata-containers-image_clearlinux_1.9.0-alpha1_agent_dc235c3d74.img,size=134217728 -device virtio-scsi-pci,id=scsi0,disable-modern=false,romfile= -object rng-random,id=rng0,filename=/dev/urandom -device virtio-rng,rng=rng0,romfile= -device virtserialport,chardev=charch0,id=channel0,name=agent.channel.0 -chardev socket,id=charch0,path=/run/vc/vm/57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92/kata.sock,server,nowait -device virtio-9p-pci,disable-modern=false,fsdev=extra-9p-kataShared,mount_tag=kataShared,romfile= -fsdev local,id=extra-9p-kataShared,path=/run/kata-containers/shared/sandboxes/57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92,security_model=none -netdev tap,id=network-0,vhost=on,vhostfds=3,fds=4 -device driver=virtio-net-pci,netdev=network-0,mac=26:66:a7:0e:f6:aa,disable-modern=false,mq=on,vectors=4,romfile= -global kvm-pit.lost_tick_policy=discard -vga none -no-user-config -nodefaults -nographic -daemonize -object memory-backend-ram,id=dimm1,size=2048M -numa node,memdev=dimm1 -kernel /usr/share/kata-containers/vmlinuz-<IP_ADDRESS>-43.1.container -append tsc=reliable no_timer_check rcupdate.rcu_expedited=1 i8042.direct=1 i8042.dumbkbd=1 i8042.nopnp=1 i8042.noaux=1 noreplace-smp reboot=k console=hvc0 console=hvc1 iommu=off cryptomgr.notests net.ifnames=0 pci=lastbus=0 root=/dev/pmem0p1 rootflags=dax,data=ordered,errors=remount-ro ro rootfstype=ext4 quiet systemd.show_status=false panic=1 nr_cpus=8 agent.use_vsock=false systemd.unit=kata-containers.target systemd.mask=systemd-networkd.service systemd.mask=systemd-networkd.socket -pidfile /run/vc/vm/57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92/pid -smp 1,cores=1,threads=1,sockets=8,maxcpus=8
[root@host-69 kata_57d39a01c7f0abc582f9fb32b8c25db7a8b686242dc192844e92a5e119c02c92]# ps aux | grep 1946
root      1946  0.0  0.0      0     0 ?        S    10:03   0:00 [vhost-1943]

Accoding to these resources:
https://github.com/kata-containers/runtime/pull/1880
https://github.com/kata-containers/runtime/issues/1879

config add option to use only pod cgroup (SandboxCgroupOnly)
Get the sandbox Cgroup path based on cgroupsPath from Sandbox Container
Join the Sandbox Cgroup before create any process
All the kata processes are inside the Sandbox Cgroup
The cgroup is not restricted by the runtime but the caller is free to limit it.

I think we should not write limits into the sandbox cgroup!
@jcvenegas
@egernst

I don't understand neither why kata's overheads(qemu,kata-proxy,shimv2) are limited by sandbox cgroup.In my opinion ,kata's processes(qemu,kata-proxy,shimv2 )should be control by parents cgroup which is create by k8s.

cc @jcvenegas

@Marshalzxy you are right that kubelet will create a cgroup specifically for the pod.  In Kubernetes, as is, for most scenarios, we shouldn't need to create a child cgroup, and instead should operate within the parents'.  As @liangxianlong highlights, today's implementation results in the 'sandbox' being over-constrained, since the Kata created cgroup is not sized to take pod overhead into account.
There were a couple of initial concerns which lead to this:

If we want to handle static CPU management, we may need to edit the cgroup that is constraining the Kata components. We wanted to avoid modifying a cgroup which is managed by "our parent."
If Kata is called from an orchestrator/tool that doesn't create a cgroup, the Kata components will run completely unconstrained.  This is the scenario with Docker, for example.

The options to fix all of this is to either just rely on upper-layer doing the right thing, or to size our cgroup to take pod-overhead into account.  CRI, and OCI doesn't have a concept of PodOverhead today, and this just lives within the Pod.Spec in Kubernetes.  As a result, today we cannot get this information in Kata.
Based on this, I would propose we:

First, modify SandboxCgroupOnly to assume that the caller has setup an appropriate sandbox for us (this is easy - just do nothing).  If this is not the case, SandboxCgroupOnly should not be selected.
Drive update to CRI specification to pass the sandbox details, including CPU/memory limits as well as pod overhead.
Long term if CRI API is updated to include pod information, Kata can size the host cgroup appropriately.

@liangxianlong @Marshalzxy @jcvenegas WDYT?

To follow up, I talked to @jcvenegas IRL, and we agree this is a bug.  The current implementation should just inherit the parent's constraints.

I agree with you that while sandboxonly=true kata should inherit parent's cgroup configuration @egernst .
Still I think there is another bug with sandboxonly feature. When orchestrator doesn't set parent cgroup ,we should set sandboxonly=false right? In this case kata create sandbox cgroup and containers cgroups,put shimv1 into those cgroups,but leave alone qemu process and kata-proxy.
Is there any reason kata don't set those processes? @jcvenegas @egernst

The same question

Still I think there is another bug with sandboxonly feature. When orchestrator doesn't set parent cgroup ,we should set sandboxonly=false right? In this case kata create sandbox cgroup and containers cgroups,put shimv1 into those cgroups,but leave alone qemu process and kata-proxy.
Is there any reason kata don't set those processes?

@liangxianlong -- Was looking to reproduce your issue exactly -- why do you define a CRD for runtimeclass?  What version of kubernetes are you using?
And, what version of Kata did you test with?
Thx.


Proposal with passing vote and results not yet submitted is categorized as "Failed".

Steps to reproduce:

Submit a proposal (e.g., membership).
Sponsor the proposal.
Vote "Yes" to pass the proposal.
After the voting period has ended and before the results are submitted - view all the proposals to see that it is categorized under "Failed".

Thanks for noticing this. I will look into this.

Reproduced:

The best and actually easiest way to fix this is to place it in the "Voting" category. The reasons are:

There are no votes data submitted to the contract for the off-chain vote, yet. Technically, it has not passed.
Grace period does not start until the votes results are submitted.

It could be good to try and include a new status when a vote result has not yet been submitted. Something to the effect of "Ready to submit result" could work. I can create a new issue for this.

We were able to reproduce the bug still with this test proposal: https://molochv3.org/membership/0x20a3737e0a4da49bbf3e600035251fbe031291d2a8bd01af10154abb3973553e
The vote is passing and the vote results have not yet been submitted. (From the proposal details page, click "view all" to see it listed under "Failed".)

Looks like this bug applies when there are "NO" votes. If there are only "YES" votes, then the proposal correctly is listed under the "Voting" category.

Having trouble reproducing this one. I have tested locally with the latest contracts from PR #251 and I get the correct result.
I tested the following:

Only "yes" votes: OK
Only "no" votes: OK
More "yes" than "no" to match upstream bug: OK

Unfortunately this bug is reappearing again.
https://molochv3.org/membership
The two listed "Failed" proposals have passing votes and the vote result has not been submitted.

A related bug has recently appeared:

Voting period has expired with more YES votes than NO votes.
Grace period has expired and vote result has not been submitted yet.
The proposal is listed under the "Failed" category (when it should be listed under "Voting").


log browserstack browsers in CI

log only in CI the number of browsers, and name of theses, in the following format
Testing specs in NUMBER browsers (BROWSER1, BROWSER2...), e.g.
Testing specs in 3 browsers (browserstack:chrome, browserstack:safari, browserstack:firefox)

@alencar13 better no?


Configurable allow list of HTTP headers to record

The agent captures an hard-coded list of specific HTTP request headers. Headers often include sensitive information that should not be recorded in telemetry, so we ought not record them all. Adding a configurable allow list of header names to record would allow users to selectively include headers they want the agent to record into events sent to Honeycomb.

Consider having a specific allow-list. Include user-agent by default, and show that in an example and encourage folks to always have it. We can do this like the OTEL_PROPAGATORS, which defaults to tracecontext,baggage and if that environment variable is updated it must include those explicitly if they are wanted, otherwise they will be overwritten.
Since this will likely be case-sensitive, be sure to document that.


[Substrate Roadmap] High Level Concept: What is a blockchain?

Description

Add the blog post: What is a blockchain

Related Issue
https://github.com/lowlevelers/lowlevelers.com/issues/41

This article needs to expand more in detail. We already have many articles about blockchain definitions out there. As we focus on low-level development and deep technical concepts, we must make a few assumptions about the audience instead of covering basic concepts.

@henchiyb Could you please help to resolve my feedback so I can merge this PR?

@henchiyb all other articles are good but could you please help me to resolve feedback for this first article before I merge others?

@chungquantin Hey I just updated the example for blockchain. Please review it 🙆♂

Perfect! This looks really good. Thank you.


doesn't work for bower

Hi , the command '$ bower install  metismenu '  specified in README.MD it does not work.
The correct is  "$ bower install metisMenu"  - using lowerCamelCase.
Thanks!

Thanks @Rafaelgfirmino
https://github.com/onokumus/metisMenu/commit/73a8abb9a3aa65cd6cbf67ba191bea6f21534778


Write the "Error Handling" Concept

Official docs:
https://book.cairo-lang.org/ch09-00-error-handling.html
The concept should include descriptions for both recoverable (Result) and unrecoverable (panic) errors.
The idea is to have a short and to-the-point article about the concept without going too deep. Avoid just copy/pasting everything from The Cairo Book; the Book should be used as a more in-depth learning resource for students after they finish the concept on Exercism (or they can use it in parallel).

Exercism Concepts docs:
https://exercism.org/docs/building/tracks/concepts
Use the following Rust's concept as inspiration for the format:
https://github.com/exercism/rust/blob/main/concepts/structs/about.md

Assign this to me.

Hey, Can I use own simple example? or I have to write from Cairo website.

@xiakshay of course you can think of your own examples, that's even better than copy/pasting!

Error Handling Concept #125 #131
Added the concept, ready to merge.

Updated the file according to the reviews.

Updated the files once again according to the reviews. #131

Made final changes and resolved all the issues. Please check and let me know if there are any discrepancies.

Thank you so much 😊


[Bug]: Video is vertically stretching on android

Version
v2.0.0
Which operating systems have you used?

[X] Android
[ ] iOS

Environment that reproduces the issue
the video is being vertically stretch in if the resolution is in 16:9 ratio like 854*480. The issue is only reproducible on devices that can record 8k, like Xiamo 14 Ultra, Samsung s23/s24 ultra. The stretch is being faced on social destination (facebook,youtube)

Is it reproducible in the example application?
Yes
RTMP Server

Reproduction steps

Set any 854*480 resolution
start streaming
check on the social destination

Expected result
The streaming video shouldn't stretch vertically in 16:9 resolution
Actual result
The streaming video is stretching vertically in 16:9 resolution
Additional context
No response
Relevant logs output
No response

Hi,
Does it happen with other resolutions?
It seems really weird that it only happens on 8k devices. Unfortunately, I don't have such a phone, so it will be difficult to reproduce.


Images in Mastodon Toots do not appear in NNW

I am viewing Mastodon postings in NNW by adding .rss to the link to the Mastodon account.  That part works great and I even created a folder so all the "toots" are gathered together in a single place like my twitter feed was.  However, images linked in the post as well as other links I guess are not being displayed by NNW.  This makes me sad and it feels broken.

What kind of account are you using? iCloud, Feedbin, On My Mac, or…?
Would you provide the URLs of a couple feeds that have this issue?
Are you seeing this on Mac or iOS (or both)?

I created the feeds in my iCloud account.  It happens on both iOS and Mac.  Some example feeds are:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

@brentsimmons Duplicate of #3754

I am viewing Mastodon postings in NNW by adding .rss to the link to the Mastodon account.

I didn't know you could this. It might be worth adding this to the FAQ. Something like "How do I subscribe to a Mastodon account?"


How to use the finetuned model with lora?

Interface.py can not load the model that finetuned with lora.

Interface.py can not load the model that finetuned with lora.

It needs lora conversion. This codebase didn't full implement it yet.
For a hard-coded workaround, you have to feed this peft_config
peft_config = LoraConfig(
        target_modules=r'.*language_model.*\.(q_proj|v_proj)', inference_mode=False, r=8, lora_alpha=32, lora_dropout=0.05
        )

into the function get_model in interface.py.


Reduce redundancy in test files

Instead of re-deploying contracts, use already deployed contracts for testing.
This allows certain tests to be run on forked mainnet with minimal changes.

Not so much on speed up of the tests themselves, but this makes the process of writing forked mainnet tests easier.
Since we can rely on already deployed contracts instead of re-deploying them at the beginning of each test.


Adding Color to highlight extraction

Hi there,
just wanted to say that I love this plugin and thanks for your work on this.
I added a bit of code on my own to also pull out the colour of the highlights from Amazon.
I am fairly new to Github, so I had trouble trying to submit my code in a new branch and making a pull request for that branch.
But I just made the adjustments here:
in "scrapeBookHighlight.ts", I added :
color : $('#annotationHighlightHeader', highlightEl).text().split(' ')[0] at line 19-20
to the parseHighlights function.
Then I added color to the respective nunJucks model
export type Highlight = {
  id?: string;
  text: string;
  location?: string;
  page?: string;
  note?: string;
  color? : string;
};

Hope that was alright.
Thanks

I'd also find this useful. Added to pull request

Thanks so much @BradenKoh27 for the suggestion and @owenvachell for the PR implementation. Hopefully we will have it merged and added to the plugin soon

Thank guys. @owenvachell @hadynz. Again, just great work on the plugin. It's awesome.

Sorry for taking time to release your work @owenvachell.
Your change has just been released in the latest version.


docs: Add xcb cursor dependency to README

IIRC I made xcb-util-cursor an optional dependency; should it be changed to a required dependency?

Technically it is optional because the functionality is turned off, if the macro is not set when building. But for example in the PKGBUILD xcb-util-cursor is a regular dependency. Do you think I should specifically mention that it is optional in the README?

It probably should be listed as optional to reflect the code.

I will add an optional dependencies section

I did a force push. Have a look at it and merge, if you think everything is in order.


tap_migrations.json: cleanup

@vitorgalvao Is it okay to merge this and https://github.com/caskroom/homebrew-versions/pull/5466?


*.js: Refactor coding style

Refactors code to a standard coding style.
Also introduces indentation via Spaces of 4.
Reviewers please note that I have tested the changes and they do not break the program, this is just a refactor and nothing more.

@rajdeepsharma17 Since not many people will be working on the core, we can do our changes rn. This makes it ready and standard as and when some newcomer decides to contribute.


Deletion of update files, autoUpdater

Running electron version 1.2.5.
I'm using nuts to host my release files for my app. When I run autoUpdater.checkForUpdates(), any update files I have are downloaded and shipit uses them to install them for my app, but only when they're from the stable channel. When I download from a channel other than stable, the update files are deleted and I get the shipit error that says "unable to copy bundle, since it doesn't exist" etc., (I'll find the more detailed log and post it shortly).
In what cases does Shipit delete the update files (.app, .zip)? Does it really have anything to do with what channel I'm downloading my updates from?

In what cases does Shipit delete the update files (.app, .zip)?

It should just do that once it's been installed.

Does it really have anything to do with what channel I'm downloading my updates from?

It shouldn't, but software's gonna be software 😂

Haha, damn. So the .app and .zip shouldn't get deleted until the update is installed? Does shipit expect a certain configuration or name / signature on the downloaded files to before it deletes them? Just gotta figure out a way to debug this. 😁

It expects the updated to be signed with the same signature as the existing app.
Check ~/Library/Caches/your-bundle-name.ShipIt/ and ~/Library/Application Support/your-bundle-name.ShipIt/. There should be logs saved there.

I see. There weren't any logs saved in ~/Library/Caches/my-bundle-name.ShipIt/, which is kind of concerning, but here is the log from the other one you mentioned.
016-07-13 16:43:41.300 ShipIt[6023:184438] Beginning installation
2016-07-13 16:43:49.188 ShipIt[6023:184454] Installation error: Error Domain=SQRLInstallerErrorDomain Code=-1 "Failed to copy bundle file:///Users/ibm/Library/Application%20Support/org.eclipse.orion.ShipIt/update.OASOzbN/Orion.app/ to directory file:///var/folders/78/2s1rhhg95f38l4z3w_d39zt00000gn/T/org.eclipse.orion.ShipIt.GIs3fq4H/Orion.app" UserInfo=0x7f8298417060 {NSSourceFilePathErrorKey=/Users/ibm/Library/Application Support/org.eclipse.orion.ShipIt/update.OASOzbN/Orion.app/Contents/Frameworks/Squirrel.framework/Resources, NSUserStringVariant=(
    Copy
), NSDestinationFilePath=/var/folders/78/2s1rhhg95f38l4z3w_d39zt00000gn/T/org.eclipse.orion.ShipIt.GIs3fq4H/Orion.app/Contents/Frameworks/Squirrel.framework/Resources, NSFilePath=/Users/ibm/Library/Application Support/org.eclipse.orion.ShipIt/update.OASOzbN/Orion.app/Contents/Frameworks/Squirrel.framework/Resources, NSUnderlyingError=0x7f829840cdf0 "The file “Resources” doesn’t exist.", NSLocalizedDescription=Failed to copy bundle file:///Users/ibm/Library/Application%20Support/org.eclipse.orion.ShipIt/update.OASOzbN/Orion.app/ to directory file:///var/folders/78/2s1rhhg95f38l4z3w_d39zt00000gn/T/org.eclipse.orion.ShipIt.GIs3fq4H/Orion.app}
2016-07-13 16:43:49.188 ShipIt[6023:184454] ShipIt quitting
2016-07-13 16:44:16.952 ShipIt[6043:184847] Resuming installation attempt 2
2016-07-13 16:44:23.186 ShipIt[6043:184892] Installation error: Error Domain=SQRLInstallerErrorDomain Code=-1 "Failed to copy bundle file:///Users/ibm/Library/Application%20Support/org.eclipse.orion.ShipIt/update.DTnyvzW/Orion.app/ to directory file:///var/folders/78/2s1rhhg95f38l4z3w_d39zt00000gn/T/org.eclipse.orion.ShipIt.LinpnPdW/Orion.app" UserInfo=0x7fe19a422960 {NSSourceFilePathErrorKey=/Users/ibm/Library/Application Support/org.eclipse.orion.ShipIt/update.DTnyvzW/Orion.app/Contents/Resources/app/node_modules/body-parser/node_modules/iconv-lite/encodings/tables/cp936.json, NSUserStringVariant=(
    Copy
), NSDestinationFilePath=/var/folders/78/2s1rhhg95f38l4z3w_d39zt00000gn/T/org.eclipse.orion.ShipIt.LinpnPdW/Orion.app/Contents/Resources/app/node_modules/body-parser/node_modules/iconv-lite/encodings/tables/cp936.json, NSFilePath=/Users/ibm/Library/Application Support/org.eclipse.orion.ShipIt/update.DTnyvzW/Orion.app/Contents/Resources/app/node_modules/body-parser/node_modules/iconv-lite/encodings/tables/cp936.json, NSUnderlyingError=0x7fe19a4c5530 "The file “cp936.json” doesn’t exist.", NSLocalizedDescription=Failed to copy bundle file:///Users/ibm/Library/Application%20Support/org.eclipse.orion.ShipIt/update.DTnyvzW/Orion.app/ to directory file:///var/folders/78/2s1rhhg95f38l4z3w_d39zt00000gn/T/org.eclipse.orion.ShipIt.LinpnPdW/Orion.app}
2016-07-13 16:44:23.186 ShipIt[6043:184892] ShipIt quitting
2016-07-13 16:48:19.491 ShipIt[6055:186104] Resuming installation attempt 3
2016-07-13 16:48:19.528 ShipIt[6055:186104] Installation error: Error Domain=SQRLInstallerErrorDomain Code=-1 "Failed to copy bundle file:///Users/ibm/Library/Application%20Support/org.eclipse.orion.ShipIt/update.DTnyvzW/Orion.app/ to directory file:///var/folders/78/2s1rhhg95f38l4z3w_d39zt00000gn/T/org.eclipse.orion.ShipIt.PpUuESNt/Orion.app" UserInfo=0x7fe6e2c24c60 {NSFilePath=/Users/ibm/Library/Application Support/org.eclipse.orion.ShipIt/update.DTnyvzW/Orion.app, NSLocalizedDescription=Failed to copy bundle file:///Users/ibm/Library/Application%20Support/org.eclipse.orion.ShipIt/update.DTnyvzW/Orion.app/ to directory file:///var/folders/78/2s1rhhg95f38l4z3w_d39zt00000gn/T/org.eclipse.orion.ShipIt.PpUuESNt/Orion.app, NSUnderlyingError=0x7fe6e2c287f0 "The file “Orion.app” couldn’t be opened because there is no such file."}
2016-07-13 16:48:19.529 ShipIt[6055:186104] ShipIt quitting
2016-07-13 16:48:19.580 ShipIt[6070:186120] Too many attempts to install, aborting update
2016-07-13 16:48:19.581 ShipIt[6070:186124] ShipIt quitting

Alright! Turns out it doesn't matter which channel I update from, but the update files get deleted unless they're the latest one from the releases. This makes me wonder if I should have multiple release servers...

Was this working before Electron 1.2.5?
How do you know the files are downloaded but then deleted?

Here's another data point. We prune update directories (https://github.com/Squirrel/Squirrel.Mac/blob/e9e2188cda3efb4bc08b1719bdef71880f9dc9b1/Squirrel/SQRLUpdater.m#L516) every time we check for updates if we haven't already downloaded an update.

Sorry. I meant Electron 1.2.3.
And I know it's primitive but I go to ~/Library/Application Support/mybundlename.ShipIt and I have the files ShipIt_stderr.log, ShipIt_stdout.log, ShipItState.plist, and a new folder that gets created called update.aBcDeFg which downloads osx_x64 and Myapp.app. If it's the latest version (regardless of channel name) I see the files stay and my app get updated with no problems, otherwise I just see osx_x64 and Myapp.app disappear along with the update.aBcDeFg folder.
Could you clarify what you mean by "prune update directories" and what that line does?

Yeah, that's legit.

Could you clarify what you mean by "prune update directories" and what that line does?

If we've haven't don't have an update downloaded and are ready to relaunch and install, then when we check for updates again, we'll delete any already downloaded updates.

which downloads osx_x64 and Myapp.app

That sounds a little off. It should just be the zipped up app.

If it's the latest version (regardless of channel name) I see the files stay and my app get updated with no problems

This makes it sound like some version discrepancy. I'm not familiar with nuts, but how would you update to the non-latest version? I'm having trouble making sense of that.

Sorry. It may be that only the zipped app is downloaded, but I am definitely seeing both the .app and zipped app in my update.abcdefg folder.
In nuts, it does a filter of the releases by the tag number and gets the latest version. However, I added an endpoint which filters also by the channel name as well, i.e., if I have two channels stable and alpha (these are simply specified by dash-suffixes on my tag names), then it finds the latest version for that channel. It works fine on Windows, which is why I came here and not posted an issue to nuts. I might just look to use a different update server than nuts, lol.
Would updating my electron version have any benefit here?

It may be that only the zipped app is downloaded, but I am definitely seeing both the .app and zipped app in my update.abcdefg folder.

Ah, ok. I was thrown off by the mention of osx_x64.

Would updating my electron version have any benefit here?

You could give it a shot. Electron 1.2.5 did update Squirrel.

Updated to the latest version of electron (1.2.7 as of this comment) with great success! Thank you. :heart:


Branch addmember display

Changes

Edit UI to show assignments and groups
Added check if group exists, and if person is in group before adding an assignment

Group non-existent:

Person non-existent in the group:

LGTM


UnhandledPromiseRejection if a test returns a rejected promise without an error

Crash:
(node:57962) UnhandledPromiseRejectionWarning: TypeError: Cannot set property 'tapCaught' of undefined
    at ret.then.er (/path/to/node_modules/tap/lib/test.js:380:22)

Code to reproduce:
const tap = require('tap');
tap.test(() => Promise.reject());

I know people aren't supposed to ever reject without an error, but I had a bug and tap caught it in a way it probably shouldn't have. 😆
Looks like it needs to be checking that er is an object here.
      // lib/test.js line 279
      ret.then(end, er => {
        er.tapCaught = 'returnedPromiseRejection'
        done(er)
      })

Yeah that’s a bug. If it doesn’t get an error, it should create one.


Create gentx-44ed792ecf717ee0cdac61340a3280de4c231b67.json

tg:
@tarabukinivan

You're welcome to join our permissionless testnet after the genesis


Modify pack macos sparse image

Using hdituil resize was creating a corrupt disk image. Instead I created again a 5g sparse image that should suit our needs for a long time

I will cherry-pick for other main branch

I will cherry-pick for other main branch


Mention multicloud offering in boilerplate

This updates the boilerplate text to mention that we are multicloud.

LGTM!

Merging! Thanks for review!


direct only error output

after, OutputManager.setOutput()
add
OutputManager.setStderr() and OutputManger.setStdout() that do only those parts.

please explain how it should work, right now Output widget has two methods which can be used to write directly to stdout and stderr
public void appendStdout(String text) {
    sendOutput(new ConsoleOutput(false, text + "\n"));
}

public void appendStderr(String text) {
   sendOutput(new ConsoleOutput(true, text + "\n"));
}

try our example test/notebooks/groovy/JavaWidgetsTest.ipynb

this is neither this is about capturing stderr.  right now we have the method OutputManager.setOutput(out) that redirects stdout and stderr to an output widget.
we want to be able to redirect only stderr to the widget, and stdout would continue to appear in each cell output as normal.


GriefPrevention Error

So im not sure how to explain the error but the plugin on my spongeforge server says its started but its like constantly and rapidly showing the same warn over and over. Ill attach a log of the server to this issue. Im sorta stuck because i meet the requirements for it to function, seems to be something about "Owning Mod/Plugin: griefprevention" thats being repeated. Thanks for any help. (sorry i have to upload it as a txt file)
debug-1.log
2019-09-07-3.log

Same happening to me, using griefprevention-1.12.2-<IP_ADDRESS>2 for spongeforge.


Repo Cleanup

Repo Cleanup
Problem
Before being forked or updated for future competitions, the SUAS-2023 repo must be cleaned up.
Solution
Things that should be completed:

Document all open branches and the changes that contain that have not been merged
Delete any branches that do not have changes
Documentation must be updated (See #114 #115)
Any active pull requests must be: 1. Completed and Merged or 2. Add a comment to the PR describing the changes made by the PR and what state of progress it is in. Apply the help wanted tag to it and unassign any participants.
Update the three projects associated with the repo and close them (can be done in the project's settings).
Disable pre-commit auto updates
Any other changes that may need to be made to put the repo in a somewhat clean state.

Some of the stuff here is more meant to be done after the semester has ended, but before the next repo is forked.


Status of scikit-image compatibility

A tracker issue already exists in the repository https://github.com/scikit-image/scikit-image/issues/7464,
testsuite is passing as of https://github.com/scikit-image/scikit-image/pull/7463

Closing in favor of the upstream issue.


Trie: Implement Trie (Prefix Tree) in Java

https://leetcode.com/problems/implement-trie-prefix-tree/?envType=study-plan-v2&envId=top-interview-150

hey, can I work on this issue?

@akgmage - can we close this issue?


[Sql] Address archboard review comments

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.Sql


Mobile hover cards

since on mobile, there is no hover, it does not make sense to have hover actions like quick buy and cart

please disable hover card actions on all touch devices, cart stays (you can add items through the item detail)
its not pleasant to click on the card and instead of getting to the detail it "popups" quick actions.

👋🏻


Problem, Marios invisible

this is the error

invisible

in this screenshot.. there could just be a Mario below you.

Im also having this issue!

happy last year to this


Support for exploring state

Given state will be stored in a volume, will we be able to browse the stored state in that volume?
It would be great to have a "State Explorer" that provides this capability for both development & operational reasons.
Kudos to @samneirinck for the idea.

I agree :).

@tomkerkhove Which volume are you referring to and what state do you wish to view? Can you please elaborate?

@gkhanna79 I'm referring to reliable collection state and the corresponding volume.

@tomkerkhove The VolumeDisk based upon reliable collections (i.e. SFvolumeDisk) looks like a regular disk that you can view using existing file exploration tools like Windows Explorer. Are you looking for something other than that?

I would need to see how the structure is - If it's straight forward then it's ok but if it's not a tool would be good.

@gkhanna79  @tomkerkhove SF volumes and reliable collections are not available in preview, how are you even using them?

SFVolumeDisk will be part of SFMesh upcoming preview @aloneguid.
@tomkerkhove Can you please elaborate on the structure you refer to? SFVolumeDisk is a regular disk as far as OS is concerned and will look like any other disk.

@gkhanna79 @tomkerkhove SF volumes and reliable collections are not available in preview, how are you even using them?

@aloneguid Not =)
@gkhanna79 	Reliable collections are glorified dictionaries, would I then have a folder which is the key with a file in it which is the value or?

@tomkerkhove Not really. The disk is a block device, so that is what the dictionaries will have (blocks of data). The view, from a user standpoint, is not the dictionary entries but rather the disk made available to the storage stack.


Release azure-cli-network 0.1.1b1

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Release of 'azure-cli-network' with version '0.1.1b1' successful. View at https://pypi.python.org/pypi/azure-cli-network/0.1.1b1.

GitHub release created. https://github.com/Azure/azure-cli/releases.


Strip out less, stylus, sass loaders

First of all, big thanks to you for this contribution, great work!
Not all devs use these loaders and mostly not use them all at once. sass loader also require node-gyp step so I already encountered some problems on windows. I guess cool solution for this - make some webpack.config hook for user, so he could override configuration.
Like search for some webpack.chrome-extension.config,js file in the root of user project and merge it then with default config.

Also this project is more like seed now, but if we strip out all extra stuff and leave some core that could be installed from npm, we can cover it with tests, linting add travis support.

@lapanoid thanks for positive feedback. It is little bit old version for me. We are working on project and it is under heavy development :) I am little out of time now, but as soon as possible i will commit update with everything and then we can make cuts and sharp it.
Any suggestions or pull requests are welcome.

@lapanoid I made some cleaning, refactoring, commenting.
https://github.com/schovi/webpack-chrome-extension/commit/355a2aa2200fc44371b1851398c25462f9328937
https://github.com/schovi/webpack-chrome-extension/commit/57927db13c71d427f40f28b6ca2fbdd7e7008a4b
https://github.com/schovi/webpack-chrome-extension/commit/041dd9791c66954a930baa6bd881a8eac326f5f2
https://github.com/schovi/webpack-chrome-extension/commit/4b26d8a17ce533f0cc516ea220e1e15e02edc2cc
https://github.com/schovi/webpack-chrome-extension/commit/1827b14e598ac87346f9c8d189c6eaadeb48a8ac
https://github.com/schovi/webpack-chrome-extension/commit/9978c68a914470327ee40ffb52040c108212280e
Any more suggesting? My plan for now is to improve README file.

That is great! At least this issue should be closed now. Would be great if you write about how it works underhood.

I will try :)

I will try


Added syevdx & sygvdx to the regular API

This PR adds syevdx/heevdx and sygvdx/hegvdx to the regular API, pending the appropriate implementation(s) in rocSOLVER.

Ready for review


C++23 fold algorithms

Channel
"C++Weekly"
Topics
C++23's new std::ranges::fold_* algorithms
Length
Not sure

See also #250.


only build.critical for json encoding errors

Previously, WriteJSON and WriteError would cause a build.critical if the remote caller hung up the connection.

Iguess not easy to make a regtest here


Failed to upgrade to 0.4.5

System Info
System:
OS: macOS 14.2.1
CPU: (10) arm64 Apple M1 Pro
Memory: 76.17 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.18.1 - ~/.nvm/versions/node/v18.18.1/bin/node
Yarn: 1.22.21 - /opt/homebrew/bin/yarn
npm: 9.8.1 - ~/.nvm/versions/node/v18.18.1/bin/npm
pnpm: 8.12.0 - ~/Library/pnpm/pnpm
bun: 1.0.14 - ~/.bun/bin/bun
Browsers:
Brave Browser: <IP_ADDRESS>
Chrome: 119.0.6045.105
Edge: 119.0.2151.97
Safari: 17.2.1
Details

Reproduce link
No response
Reproduce Steps

set the version of @rspack/core to 0.4.5
Run the pnpm i

it seems your network problem, it works for me

weird, thanks for reply.

Seems like I have to login to the privjs.com in the terminal to solve this authentication problem

Remove privjs registry from your npmrc or remove @module federation from its scope.


Allow admin to associate missing LFS objects for repositories

Background
There are some flaws in Gitea's LFS module.

Adopted repositories don't contain LFS objects
Missing LFS objects (which do not exist in lfs_meta_object table) can not be associated to a repository
Forked/rsynced repositories might not serve LFS objects correctly

Some related issues:

https://github.com/go-gitea/gitea/issues/18137
https://github.com/go-gitea/gitea/issues/17715
https://github.com/go-gitea/gitea/issues/17207

Solution (partially)
This PR doesn't resolve all these issues.
This PR reworked the Find pointer files feature in Settings -> LFS page.
When a LFS object is missing from database, admin can associate it to the repository by clicking the Associate button.
This PR did help a user to recover their LFS repositories successfully.
I agree that this PR is not perfect, because the LFS module itself should be improved too, but I think this feature is nice to have.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c99b8ef). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #18143   +/-   ##
=======================================
  Coverage        ?   44.93%
=======================================
  Files           ?      825
  Lines           ?    91595
  Branches        ?        0
=======================================
  Hits            ?    41155
  Misses          ?    43863
  Partials        ?     6577

Impacted Files
Coverage Δ

models/lfs.go
23.96% <0.00%> (ø)

routers/web/repo/lfs.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99b8ef...79ba035. Read the comment docs.

trigger bot

trigger bot


making the tools idempotent.

I would really like if you could make all the tools idempotent.
This would be useful, since packer can retry after it failed.
So it would be nice, if Pester could test before and skip if the tool is already installed.
Today, if the whole process fails after a 5 hour run, it is frustrating having to start all over again, because it doesn't know how to continue from where it started even though the possibility to retry is present.
This could be fixed by making a check before running the install of the tools, maybe by using pester.

@AHuusom Thank you for your report. We will take a look and share our thoughts on it.

Hi @AHuusom,
this topic more fits the discussion section, as it is something that will require significant process update if we decide to do that.
I am going to convert it into discussion, thanks for raising up this point.


[New chain]: Game 7 Testnet 1.4.1

Summary
I would like to add Game7 Testnet 1.4.1 contract and block explorer data
Chain ID
13746
Chain detail URL
https://chainlist.org/chain/13746
RPC URL
https://testnet-rpc.game7.io
Blockscout Client URL
https://testnet.game7.io/api/v1/graphql
Etherscan Client URL
No response
Etherscan Client API URL
No response
Version
1.4.1
Address (Master copy)
0x41675C099F32341bf84BFc5382aF534df5C7461a
Deployment Tx hash (Master copy)
0xbb88598d764ae93896d582098734e7991c02f24f49bd013938d43ab62a607996
Block explorer URL (Master copy)
https://testnet.game7.io/address/0x41675C099F32341bf84BFc5382aF534df5C7461a
Address (Master copy L2)
0x29fcB43b46531BcA003ddC8FCB67FFE91900C762
Deployment Tx hash (Master copy L2)
0x6a7bb46f2f96c0b06835c532e6143e48268ddf4cbc6e5e7773c924cf69e28b02
Block explorer URL (Master copy L2)
https://testnet.game7.io/address/0x29fcB43b46531BcA003ddC8FCB67FFE91900C762
Address (Proxy factory)
0x4e1DCf7AD4e460CfD30791CCC4F9c8a4f820ec67
Deployment Tx hash (Proxy factory)
0xe1741bd66a605cb0919e084f131c677aaf2f9441b4ae9f1f7bef290c2b9b14b5
Block explorer URL (Proxy factory)
https://testnet.game7.io/address/0x4e1DCf7AD4e460CfD30791CCC4F9c8a4f820ec67

to fix your trouble check this solution click
maybe this will solve your problem.

/execute


no demo for k-nearest p-median

I just realized we never got a demo into the notebooks for the new $k$-nearest $p$-median functionality. What I am thinking is a new notebook that highlights the differences & similarities in $p$-median variations, all solved with euclidean distance for comparability:

standard $p$-median
capacitated $p$-median
$k$-nearest $p$-median

This should be created and merged prior to the next release (v0.6.0), with #386 also being a blocker.

This fits what I can imagine - now the standard and capacitated are blended together. It will be better to have a straightforward comparison and to use the same real-world dataset similar to other coverage notebooks.

Following #410/#411, I'd like to put something together for this and cut a v0.6.0 release this coming week.

Resolved via #431


remove unnecessary calls to storage driver

What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Yes, we can assume some of these checks to be unnecessary. If there is an error just log that.


Docker engine labels

Provides a mechanism to label the Docker engine with user specified tags.
It piggybacks the existing INFRAKIT_LABELS template function.

new property in the Swarm flavor spec: EngineLabels
INFRAKIT_LABELS returns the InfraKit instance links and the content of EngineLabels

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "swarm-labels" git@github.com:ndegory/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353658144
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.