Speed up InlineInstances

Create instance maps once for each Module
Performance regression introduced in https://github.com/freechipsproject/firrtl/pull/1073
This doesn't fix the entire performance regression (there's still an issue with lots and lots of rename maps), but for a large SiFive design, this reduced Inline Instance runtime from 94 minutes to 86 seconds (out of a total of 534 seconds). There is still a lot of improvement to be had considering it takes 6 seconds when I revert https://github.com/freechipsproject/firrtl/pull/1073.
I think we ought to make the instMaps code a utility on InstanceGraph, but I'm unsure of the right API (but note that this code is duplicated, it also exists in ConstantPropagation).

getChildrenInstancesOfModule is the closest thing, but unfortunately it returns a Map[String, Set[(Instance, OfModule)]]
The idea was to try to make more APIs use strings that are boxed with annotation / target utilities, but that never really took off. It might be good to wait for the Named / Target stuff to all be past the deprecation stage, but it also might be worth just adding this as a Map[String, (String, String)] for convenience.

views can be good.

Note that the views here are only to prevent additional traversals, you can do the map and .toMap (ie. new collection construction) at the same time. It's the replacement for collection.breakOut in Scala 2.13 (and I'm pretty sure the performance is roughly equivalent in Scala 2.12)

@jackkoenig, how confident are you that the Map you get from this would have stable iteration order?

@albert-magyar I am 100% confident it will not have stable iteration order, it's not intended to be iterated on.

Then it doesn't automatically make sense to have that pattern appear as an API, since it will create the risk of someone using it and iterating over it.

@albert-magyar: I agree with you that a public InstanceGraph API doing the same thing as instMaps must be stable (and can be made stable), but the usage of instMaps in InlineInstances is private and is not iterated over. Is your concern about a future public API or the fact that this PR introduces a private Map with an unstable iteration order?
Basically, do you see a reason to hold this up? (As this is a blocker on 1.2, I'd like to get this in!)

I think we should just merge this now and add the API / delete code later since just copying over what's in InlineInstances isn't ideal for use everywhere.


Feature Leakage

When calling getFeatures, the API returns ALL feature flags. I'm proposing we should only return those flags which are enabled for the given user.
I don't see the point in "leaking" feature flags to an inquisitive user that otherwise doesn't need to know they exist :+1:
Proposing the API would return this, instead of the latter:
{
    "gt8_feature_flag_test": {
        "enabled": true,
        "value": null
    },
    "floating_action_button": {
        "enabled": true,
        "value": null
    },
    "oauth_google": {
        "enabled": true,
        "value": null
    },
    "interactive_tutorial": {
        "enabled": true,
        "value": null
    },
    "breadcrumbs": {
        "enabled": true,
        "value": null
    },
    "tasks": {
        "enabled": true,
        "value": null
    }
}

instead of:
{
    "gt8_feature_flag_test": {
        "enabled": true,
        "value": null
    },
    "floating_action_button": {
        "enabled": true,
        "value": null
    },
    "oauth_google": {
        "enabled": true,
        "value": null
    },
    "test_remote": {
        "enabled": false,
        "value": "1"
    },
    "interactive_tutorial": {
        "enabled": true,
        "value": null
    },
    "breadcrumbs": {
        "enabled": true,
        "value": null
    },
    "thought_from_template": {
        "enabled": false,
        "value": null
    },
    "tasks": {
        "enabled": true,
        "value": null
    }
}

We've had a discussion about this and we're not sure hiding those disabled flags is the right approach. There will be cases where the default state for an app is having something enabled, and so the feature flag state being disabled would be relevant/required.
We're not sure how we could get around this situation? I guess an option would be to add a second boolean '''hidden''' property to each flag that allowed you to prevent them from being sent back to clients?

We're not sure how we could get around this situation? I guess an option would be to add a second boolean hidden property to each flag that allowed you to prevent them from being sent back to clients?

Seems like a sensible solution to me :+1:

We now have the ability to hide disabled flags.


signed git tags

Can you please OpenPGP sign your following git tags? It's also useful in case github gets hacked again in case SSL CA's get hacked again.
With git it requires minimal effort.
In my ~/.gitconfig I use.
[user]
         name = adrelanos
         email = adrelanos at riseup dot net
         signingkey = 713AAEEF

After setting that up you can just use.
git tag -s 1.9

Users who wish can verify it with.
git tag -v 1.9

I am using it all the time. If there are any questions about this git feature / feature request, I am happy to answer.

@adrelanos
Thanks for reporting this issue.  As requested, I have signed the existing tags: https://github.com/theupdateframework/tuf/tags
$ git pull upstream develop --tags
remote: Counting objects: 3, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
From https://github.com/theupdateframework/tuf
 * branch            develop    -> FETCH_HEAD
 - [tag update]      v0.7.5     -> v0.7.5
 - [tag update]      v0.9.8     -> v0.9.8
 - [tag update]      v0.9.9     -> v0.9.9
Already up-to-date.

$ git tag -v v0.9.9
object 08b2a68d6cc89e7dc710ee1412f480ed67aacf4e
type commit
tag v0.9.9
tagger Vladimir Diaz<EMAIL_ADDRESS>1420481103 -0500

TUF 0.9.9 (pre-release)
gpg: Signature made Mon 05 Jan 2015 01:05:03 PM EST using RSA key ID 1D253935
gpg: Good signature from "Vladimir Diaz (Vlad<EMAIL_ADDRESS>gpg:                 aka "Vladimir Diaz<EMAIL_ADDRESS>$ git tag -v v0.9.8
object cd8f5534c49e86b6e28867cad8f16c1073b1a938
type commit
tag v0.9.8
tagger Vladimir Diaz<EMAIL_ADDRESS>1420480949 -0500

TUF 0.9.8 (pre-release)
gpg: Signature made Mon 05 Jan 2015 01:02:29 PM EST using RSA key ID 1D253935
gpg: Good signature from "Vladimir Diaz (Vlad<EMAIL_ADDRESS>gpg:                 aka "Vladimir Diaz<EMAIL_ADDRESS>$ git tag -v v0.7.5
object d7899e536bc416e19bcceb20ddba0d1fe97e2c80
type commit
tag v0.7.5
tagger Vladimir Diaz<EMAIL_ADDRESS>1420480781 -0500

TUF 0.7.5 (pre-release)
gpg: Signature made Mon 05 Jan 2015 12:59:41 PM EST using RSA key ID 1D253935
gpg: Good signature from "Vladimir Diaz (Vlad<EMAIL_ADDRESS>gpg:                 aka "Vladimir Diaz<EMAIL_ADDRESS>$


METRON-1867 Remove /api/v1/update/replace endpoint

The /api/v1/update/replace endpoint is no longer used.  This is dead code and should be removed.
This is dependent on the following PRs.

[x] #1242
[ ] #1247
[ ] #1254

Testing

Spin-up Full Dev.
Open the Alerts UI.

View alerts.
Escalate an alert.
Comment on an alert.
Create a meta-alert.
Escalate a meta-alert.

Run the UI e2e tests.

Pull Request Checklist

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?
[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
[x] Have you included steps or a guide to how the change may be verified and tested manually?
[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

Closing.  This is replaced by #1284 .


viewportFeatures returns null values

Hi !
version : "@carto/carto-vl": "^1.2.3"
In our test case, we would like to get all the viewport features and make some on the fly data normalization WITH category values aggregation such as :
$ / population with aggregated categories
Which is not possible with the viewportHistogram method if I am right.
viewportFeatures returns some null values when we try to make some operations between e.g.
feature.properties.variableName1 / feature.properties.variableName2
The described method return some random null values that will return an error because of the division by null or zero.
This seems only to happen when value is set with an mathematical operation, it behave well when called alone.
See attached the jsfiddle with quite explicite code.
https://jsfiddle.net/captainOski/z47yqovm/
Thank you very much for the good work !

Has you said, there's no way to do with the current viewportHistogram and it has to be done "manually". I'm adding here the solution that I think solves your issue. It uses the viewportFeatures expression to go through all the features and calculate the values, which then uses to build the histogram:
Viz:
const viz = new carto.Viz(`
    @v_features: viewportFeatures($here_city, $total_spent, $r1_rta)
`);

Update function:
function histogramFactory () {
       const histogram = new Map();
       const features = layer.viz.variables.v_features.value;
       const defaultValue =  { total: 0, rta: 0 };

       features.forEach(feature => {
          const city = feature.properties.here_city;
          const total = feature.properties.total_spent;
          const rta = feature.properties.r1_rta;
          const currentValue = histogram.has(city) ? histogram.get(city) : defaultValue;
          const value = {
              total: currentValue.total + total,
              rta: currentValue.rta + rta
          }

          histogram.set(city, value);
        });

     const categories = [];
     histogram.forEach((value, key) => {
        const ratio = (value.total / value.rta) * 100;
        categories.push({ name: key, value: ratio })
      });

     $categoryWidget.categories = categories.sort((a, b) => b.value - a.value);
}

Live example here

Hola !
With the exact same example you gave me I am able to reproduce the issue as described.
Note that the issue is not on the way to achieve the way of creating a proper histogram, but that the layer.viz.variables.v_features.value return null values
Just changed a few variables details but it is self explanatory.
I commented where the issue is
// ISSUE HERE //
console.log(features.filter(a=>a.properties.r1_rta==null))
// ISSUE HERE //
See issue as reproduced : https://jsfiddle.net/captainOski/s5jpLzc1/

InfinityG is caused by null values

@elenatorro are you able to reproduce and debug this ? Thank you very much.

Hi 👋
Sorry we didn't answer this sooner. We're working on an issue related with null values, but also how can we style these values as 'others', for instance.
Meanwhile, there's a solution to avoid this InfinityG values. We can use the filter expression to filter the values that aren't null, in this case it would be:
const viz = new carto.Viz(`
    @v_features: viewportFeatures($here_city, $total_spent, $r1_rta)
    filter: not(isNull($r1_rta))
`);

Do you think this solution solves your current problem? Thanks!

I've prioritized the issue to take a deeper look at it 👍

Thank you for prioritizing this ! 🙏
Unfortunatly this is not solving our issue, we had to make some conditionals , if null => return statistical extrapolation.
We can't afford losing data by filtering, this would mean rendering inaccurate information in the widgets.
Thank you again.


Handling scroll height / silent failure feature request

First of all thanks for making this library it is great.
I ran into a case where the ngx-virtual-scroller is setup to use [parentScroll]="scroll.window" and also uses (vsEnd)="loadMore($event)" so essentially the end result to have virtual and infinite scroll.
The problem I ran into is that one of the routes in Angular had a css template where the html height was unset. For ex:
::ng-deep html {
    height: unset;
}

When a person went to this page then to a page where it has the ngx-virtual-scroller, the vsEnd would fire for all the items and would load hundreds of items all at once in the DOM so essentially the infinite part was working but not the virtual scroll part.
I was wondering if it is possible to set the height, would it be safe to use "scrollbarHeight" as part of DI and set it to "100%", I think in the document it is mentioned and would just like to confirm.
Also, my suggestion/feature request is that because the failure happens silently (when there is no height) to error out because the side effect is really bad (where all items are loaded on the DOM at once and could potentially be hundreds).

Hi
I have a same issue. Link for Stackblitz (https://stackblitz.com/edit/angular-ngx-virtual-scroller-possible-bug). But I found workaround. I added:
virtual-scroller {
  max-height: 100vh;
}

And everything works as expected. Is this bug or I'm doing something wrong?
Best regards

Any new tips on this, how we can make it work?


Add a static equivalent of the table getter actualTableName

Is your feature request related to a problem? Please describe.
In the project I'm working on. We record "updates"/"changes" of the local database in an outbox. In this outfox, there are 2 entries.

The name of the SQL table that was modified.
The modifications that were applied.

Let's say I have a table Todos:
class Todos extends Table {
  IntColumn get id => integer()();
  TextColumn get title => text()();
}

and let's say I have a method
Future<void> recordChangesInOutbox(String tableName, Map<String, dynamic> changes);

When I want to record some changes I have to specify the table name 'todos'. And I either have to hardcode it:
recordChangesInOutbox('todos', {});

Or I can use the generated $TodosTable by drift.
Unfortunately the getter actualTableName is not static so it forces me to instantiate the table:
recordChangesInOutbox($TodosTable(attachedDatabase).actualTableName, {});

Describe the solution you'd like
It would be useful to also generate a static getter to get the actual table name, for example:
static String get actualTableNameStatic;

so I don't have to instantiate the table:
recordChangesInOutbox($TodosTable.actualTableNameStatic, {});

Is the problem not having access to the database

Kind of, in that outbox code, there is no need to "inject" or "know" about the database


Accessibility Release test pass on TSDoc on Web platform in May'23

https://github.com/microsoft/rushstack-websites/issues/166
https://github.com/microsoft/rushstack-websites/issues/167
https://github.com/microsoft/rushstack-websites/issues/171
https://github.com/microsoft/rushstack-websites/issues/172
https://github.com/microsoft/rushstack-websites/issues/170
https://github.com/microsoft/rushstack-websites/issues/169
https://github.com/microsoft/rushstack-websites/issues/168
https://github.com/microsoft/rushstack-websites/issues/157
https://github.com/microsoft/rushstack-websites/issues/155
https://github.com/microsoft/rushstack-websites/issues/154
https://github.com/microsoft/rushstack-websites/issues/153
https://github.com/microsoft/rushstack-websites/issues/151
https://github.com/microsoft/rushstack-websites/issues/148
https://github.com/microsoft/rushstack-websites/issues/147
https://github.com/microsoft/rushstack-websites/issues/146
https://github.com/microsoft/rushstack-websites/issues/145
https://github.com/microsoft/rushstack-websites/issues/144

Report Shared hence closing the Task


[ZF3] bin/console does not work

Zend Framework 3 removed the Console component from its MVC component and moved it to its own component:
https://zendframework.github.io/zend-mvc-console/intro/
We need to integrate this module and make YAWIKs' console api working again.

In a second step we should consider following the suggestion made in the last paragraph of the above link:
Use zf-console as zend-mvc-console will be abondoned.

@kilip Please do this.

@TiSiE based on answer in this stackoverflow question:
https://stackoverflow.com/questions/38636186/how-to-create-zf3-console-application
I think we should start using symfony console component to handle yawik related console job, because I am more familiar in working with symfony console then zf-console. I want you to notice that symfony console is widely used in opensource project like composer, doctrine.
I have create this symfony console integration in feature-zf3-console. And because doctrine is using symfony console too, I could easily import doctrine command into our yawik console application. I also create app:generate:keywords command to automaticaly generate keywords from all applications.
Here's a sample output:

Our primary goal is to make the yawik  console tools working with zf3 ASAP, which means we will use zend-mvc-console, as it does not require to change any code (because it is backward compatible with zf2)
For the long term migration (what I described as second step) I did not mean to dictate the usage of zf-console, that was just the one mentioned in the documentation I have linked to.
But we should probably discuss this on the mailing list, in the forum or in another issue.

@TiSiE  my #413 pull request should fix this issue, I have integrated zend-mvc-console into yawik


Try Build Service Tagging

I am expecting this to break?
Confirmed.

Yeah I don't think there is any way to add a tag from a PR build from a fork.


dead link in the readme

this link: https://github.com/uber/react-vis/blob/master/examples is broken.

Good catch, I've updated the readme and all should be well.


Swift version

I ported this project to Swift 2.x. Check it out here:  https://github.com/rlaferla/CLTokenInputView-Swift

@rlaferla This is great! Nice work! :+1:


rm unnecessary russian text duplication

Simple minor fix for the beauty

oops, https://github.com/flant/dapp/pull/1106

oops, #1106

no problem ¯_(ツ)_/¯


Update metadata and example

Summary:

Add dev_langs to metadata
Move snippets to file

Questions:

These file contains quotation mark in metadata while some others not. Shall I remove them?
ms.topic: article seems to be replaced by ms.topic: conceptual.

If so, docs/styleguide/template.md also needs minor updating.

Closing and reopening to begin new build.

You're right @imba-tjd. I'll review the topics that are still using ms.topic article to remove them all in a separate PR.

@mairaw Can you look at this one? The conflicts are all in the metadata section, and it looks like the PR may have been caught in the recent changes you were making across many topics.

@BillWagner yes they did. It should be fixed now.

@meganbradley because I merged the master branch to this PR, the commit validation report is showing things that are not applicable to the PR itself.


Fix for gauge stats in installationcount

Fix so that we don't accrue gauge stats in InstallationCount where none exist in RealmCount

Automated message from Dropbox CLA bot
@umkay, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @umkay!


v-bind:class isn't reactive on page load

Environment

Operating System: Darwin
Node Version:     v18.18.2
Nuxt Version:     3.8.2
CLI Version:      3.10.0
Nitro Version:    2.8.0
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, modules, srcDir, css, vite, app, eslint, stylelint, gtag, image
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-hqpmmt?file=app.vue
Describe the bug
To reproduce, click on one of the two links. This should turn the link colour to pink. Then refresh the playground browser (not the whole browser)
Expected: The link should have a class of active and be pink
Actual: The link doesn't have the class of active but the value is true. Also causes the link to no receive the active class when clicked again after reload
Additional context
No response
Logs
No response

The fragment part, also known as hash, is never transferred to the server by the browser. Hence, you can't use it to achieve what you want.
This is not a Nuxt issue but intended by the spec.

I feel this was closed prematurely. The computed value resolves during the hydration phase.

Click a link, this makes it active
Reload the play area, not the whole browser
Check the value printed in the play area, the boolean is true but the active class isn't added to the anchor

This value is reactive and should work. The value is true after the hydration phase so SSR doesn't have anything to do with it.
This causes another bug when clicking the link that should be active doesn't give it the active class since the value is already true after hydration. Please have another look.

The computed value resolves during the hydration phase.

Sadly not. If you check the condition on the server and client-side, you will receive a hydration error because server and client state are not matching, breaking parts or the rest of the application. From that point on, you can't do much.

This value is reactive and should work.

Yes, if you check it only on the client side it does (and will)

Ah okay thank you for the explanation. I will find a different way to render this link as active.


Border outline of "Icons" in the Menu list items are not following the High Contrast standards on mouse hovering

Repro Steps

Set theme to High Contrast Black or White.
Launch Calculator app.
Navigate to "Open navigation" button and activate it.
Hover the mouse on the menu list items in High Contrast Black/White theme.
Observe the issue.

Actual Result
Border outline of "Icons" in the Menu list items are not following the High Contrast standards on mouse hovering.
Expected Result
Border outline of "Icons" in the Menu list items should follow the High Contrast standards on mouse hovering.

Test Environment
OS Version: Windows 10 Build 18351.1
App Name: Calculator
App Version: 10.1902.16.0

This is your friendly Microsoft Issue Bot. I created this issue automatically as requested by a team member.

Can I work on this issue?

Yes! Thanks for taking a look, @jeffsieu.

It looks that this issue is already fixed.

@kaceka thanks! It does indeed look like this is resolved in Calculator 10.2009.4.0.


Automigration not creating collection

Hi,
I think this might be a version incompatibility, I'm using arangodb 3.3.8, it might come from arangojs version (yours is 5.0.0, latest is 6.2.4)
I get this error : ArangoError: collection not found
Error code 1203, code 404
Apparently in arangodb.js:1350, it tries to drop the collection first, then create it, so of course it's going to fail...
Any ideas ?

The error message probably changed on this version of ArangoDB, line 1353 should be
if (!(err.error === true && err.errorNum === 1203 && err.errorMessage === 'collection not found')) {

@Gby56 Added support for arangodb 3.3! Please install version 2.1.0


Bump Dependencies #8469333034

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/8469333034

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Updated with: https://github.com/wso2/product-is/pull/20127


Implicit memory references to shadow stack pages should cause traps

The document states that instruction fetches should cause an instruction page fault, but does not describe behavior of other implicit memory accesses. (e.g., page table walks, Svadu A/D bit updates).  I'm assuming these should also cause faults but should be specified.

Given that the shadow stack page is characterized as a virtual memory attribute, other implicit memory accesses fall outside the scope of this specification. It should be noted that the physical memory allocated for mapping a shadow stack page may also serve as a page table structure; however, such usage is not discernible within the context of this specification.

As presently defined, the XWR=010 encoding continues to be reserved for future standard use in G-stage PTE. Is the intent to cause an access fault instead of a guest-page-fault for an XWR=010 encoding in the G-stage PTE.

Is the intent to cause an access fault instead of a guest-page-fault for an XWR=010 encoding in the G-stage PTE.

The Architecture Review Committee discussed this recently and the answer is "no".  The ARC concluded that G-stage address translation should be unchanged and not cause any new access faults, even when a G-stage PTE's permission bits XWR are binary 010.  The new interpretation that Zicfiss gives to XWR = binary 010 should apply only to single-stage translation controlled by CSR satp, and to VS-stage translation controlled by CSR vsatp.
Because automatic reads and updates of PTEs in memory always involve either real physical addresses or guest physical addresses, those memory accesses will not cause access faults due to any PTE's XWR bits = binary 010.  Scratch that part of Krste's original description of this issue.
Two changes are requested for the Zicfiss document:
First, if not already done, it should be made clear that the new interpretation that Zicfiss gives to a PTE's bits XWR = binary 010 applies only to single-stage and VS-stage address translation and not to G-stage translation.  For G-stage translation, there will be no way to mark any pages as shadow stacks, and no distinction will be made between SS and non-SS memory accesses.  These distinctions occur only for single-stage and VS-stage translation.
Second, instead of having an instruction fetch from an SS page cause an instruction page fault, Zicfiss should specify that an implicit memory access that goes through full address translation (single-stage translation under the control of satp or VS-stage translation controlled by vsatp) causes an access fault if the implicit access is attempted to an SS page.  (As usual, if an access may be split into multiple pieces, such as a misaligned instruction fetch, then each piece may raise a different exception.)  We suggest also adding a nonnormative comment that, at the time this spec is written, the only implicit memory accesses that go through full address translation and thus can cause such SS-page access faults are instruction fetches.

First, if not already done, it should be made clear that the new interpretation that Zicfiss gives to a PTE's bits XWR = binary 010 applies only to single-stage and VS-stage address translation and not to G-stage translation.

This matches how its specified currently. The encoding is reserved in G-stage PTEs. There is also an informative note that a future extension may define the XWR=010b encoding.

Second, instead of having an instruction fetch from an SS page cause an instruction page fault,

This change has been made to the specification. The updated text is as follows:
Implicit accesses, including an instruction fetch, to the shadow stack page are not allowed. Such memory accesses cause an access-fault exception corresponding to the original access type.

We suggest also adding a nonnormative comment that, at the time this spec is written, the only implicit memory accesses that go through full address translation and thus can cause such SS-page access faults are instruction fetches.

The following comment is included in PR #166

While the specification mandates that an access-fault exception shall be generated when either single-stage or VS-stage address translation is invoked for an implicit access targeting a shadow stack page, it is pertinent to highlight that, at the time of this specification's drafting, instruction fetches are the exclusive class of implicit accesses that are subjected to either single-stage or VS-stage address translation.

Suggested updates were merged into the document.


How to define max_seq_length for the BERT encoder?

Describe the bug
When using the BERT encoder for a text input feature, is the 'word_sequence_length_limit' parameter used?
The examples given on the BERT github refer to a 'max_seq_length' parameter.
Is this defined at the level of the 'input_features' like the other encoders with the type 'text' or at the level of 'preprocessing' where the tokenizer parameter is defined?
Additional context
The documents I'm working with range from 200 - 1200 words so I'm trying to make sure the longest sequencing are being captured when using the bert encoder.

@danielduckworth it should be. Now there's a slight weirdness with using text the rather than sequence in that bert doesn't properly use words, this will be solved in future versions where words, chars and bpes will be treated the same way.
But for now word_sequence_length_limit if text and sequence_length_limitif sequence should do the job.
You can define it both at the input feature level or at the global preprocessing level. The difference is that in the global preprocessing it applies to all features of a specific type, while at input feature level it applies only to that specific feature. If you define both, the input feature one overrides the global one.
Consider that 1200 words is very very long for bert, you are likely going to run out memory even if you set the batch size to be very small, so you may want to trade it off.

OK, got it, thanks.


CsvInputFormatter throws exception for nullable reference types

The exception is thrown everytime csv data is received if the model it's trying to parse contains nullable reference types.
I have a model like this
public class Item
{
    public string ItemID { get; set; } = "";
    public string ItemNumber { get; set; } = "";
    public string? Description { get; set; }
    public int Active { get; set; }
    public float? Weight { get; set; }
}

sample CSV to parse
ItemID,ItemNumber,Description,Active,Weight
10002-18985,10002-18985,3M 5952,1,0

The exception thrown
System.InvalidCastException: Invalid cast from 'System.String' to 'System.Nullable`1[[System.Single, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]'.
   at System.Convert.DefaultToType(IConvertible value, Type targetType, IFormatProvider provider)
   at System.String.System.IConvertible.ToType(Type type, IFormatProvider provider)
   at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
   at WebApiContrib.Core.Formatter.Csv.CsvInputFormatter.ReadStreamAsync(Type type, Stream stream)
   at WebApiContrib.Core.Formatter.Csv.CsvInputFormatter.ReadRequestBodyAsync(InputFormatterContext context)
   at Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BodyModelBinder.BindModelAsync(ModelBindingContext bindingContext)
   at Microsoft.AspNetCore.Mvc.ModelBinding.ParameterBinder.BindModelAsync(ActionContext actionContext, IModelBinder modelBinder, IValueProvider valueProvider, ParameterDescriptor parameter, ModelMetadata metadata, Object value)
   at Microsoft.AspNetCore.Mvc.Controllers.ControllerBinderDelegateProvider.<>c__DisplayClass0_0.<<CreateBinderDelegate>g__Bind|0>d.MoveNext()

Can support for nullable reference types be added?

@patzila yes, this sounds like a good idea. Will see if I can add this, unless you would like to do a PR youself.
Greetings Damien

If you can take a crack at it first that would be great :)


Feat/dashboard UI

Perfect for gorgeous looks, can push asap

Split out into two pie charts, as there was an oversight with having it combined (as contracts can both be pending and active, so contracts could accidentally be counted more than once). Feel free to change this up tho.


Move types for AWS SDK credentials to a separate crate

Motivation and Context
This PR is purely refactoring and lays the groundwork for this RFC and for its parent RFC. At a high level, we are preparing for making a set of APIs for credential providers and caching more consistent for our customers.
To that end, we will allow ConfigLoader, aws_types::sdk_config::Builder, and service clients' config::Builders to have new methods credentials_cache (which happens in a later PR). This implies that whoever uses one of those builders will need to be able to construct a credential cache (today that's LazyCachingCredentialsProvider) and to pass it to the credentials_cache method. The issue is that the user of the builder could be in the aws-types crate but LazyCachingCredentialsProvider is in the aws-config crate; the former crate cannot depend on the latter.
Description
To solve the pain point, we first need to straighten out the dependencies between Rust runtime crates. This PR introduces a new crate called aws-credential-types that houses credential-related traits and types. aws-credential-types then sits at the top of the dependency graph among Rust runtime crates (as shown in this figure). aws-credential-types will be the new home for LazyCachingCredentialsProvider, and the user can create a credential cache even from within the aws-types crate.
What we see in Files changed is a result of this proposed arrangement and placing the affected items accordingly. You can read more about it in the descriptions for 6058acb, ea0168b, and 67a73a5.
This PR implements only the refactoring portion of the said RFC (the first three items in the changes checklist).
Testing

[x] Passed all tests in CI but iam-code-examples that depends on a feature that has been moved from aws-types to aws-credential-types (will fix the example once this PR has been merged to main)

Checklist

[ ] I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
[ ] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks John for your review!

Also, you may want to dig into why there is a server codegen diff here. These changes seem like they shouldn't affect the server at all.

I believe that was due to this PR not merging the latest main when that diff appeared. The latest test run kicked off as part of 3f4f67a no longer shows a server codegen diff.


WPF support

I built Mictlanix.DotNet.Onvif into WPF,
and simple program was created with reference to test.
However, await does not return.
What should I do?
MainWindow.xaml.cs(partial)
private void Button_Click(object sender, RoutedEventArgs e){
  MainAsync("xx.xx.xx.xx", "", "").Wait();
}
static async Task MainAsync(string host, string username, string password) {
  var device = await OnvifClientFactory.CreateDeviceClientAsync(host, username, password);
}

I found the answer.
private void Button_Click(object sender, RoutedEventArgs e){
var TaskMainAsync = Task.Run(() =>
{
    return MainAsync("xx.xx.xx.xx", "", "");
});
TaskMainAsync.Wait();
}

You could try to use async/await in your click event.
private async void Button_Click(object sender, RoutedEventArgs e)
{
    var device = await OnvifClientFactory.CreateDeviceClientAsync(host, username, password);
    var result = await device.SomeMethodAsync();
    ...
}


Add GitHub action to run unit tests on PRs

Overview
GitHub actions run on docker and are much faster than a Travis VM.
Examples
https://github.com/HeroTransitions/Hero/blob/develop/.github/workflows/test.yml

Done in #36


Does not work with Laravel 5.8

Had it installed on Laravel 5.7
Upgraded to 5.8
outcome:

Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 8 installs, 8 updates, 4 removals
  - Removing lcobucci/jwt (3.2.5)
  - Removing laravel/slack-notification-channel (v1.0.3)
  - Removing laravel/nexmo-notification-channel (v1.0.1)
  - Removing nexmo/client (1.6.2)
  - Installing phpoption/phpoption (1.5.0): Loading from cache
  - Updating vlucas/phpdotenv (v2.6.1 => v3.3.2): Loading from cache
  - Updating laravel/framework (v5.7.28 => v5.8.2): Loading from cache
  - Updating folklore/graphql (v<IP_ADDRESS> => v<IP_ADDRESS>): Loading from cache
  - Installing psr/http-factory (1.0.0): Loading from cache
  - Updating zendframework/zend-diactoros (1.8.6 => 2.1.1): Loading from cache
  - Installing symfony/options-resolver (v4.2.3): Loading from cache
  - Installing clue/stream-filter (v1.4.0): Loading from cache
  - Installing php-http/message-factory (v1.0.2): Loading from cache
  - Installing php-http/message (1.7.2): Loading from cache
  - Installing php-http/discovery (1.6.1): Loading from cache
  - Installing php-http/client-common (1.9.1): Loading from cache
  - Updating sentry/sentry (1.10.0 => 2.0.0): Loading from cache
  - Downgrading sentry/sentry-laravel (0.11.0 => 0.8.0): Loading from cache
  - Updating spatie/laravel-csp (2.1.3 => 2.2.0): Loading from cache
php-http/message suggests installing slim/slim (Used with Slim Framework PSR-7 implementation)
php-http/discovery suggests installing puli/composer-plugin (Sets up Puli which is recommended for Discovery to work. Check http://docs.php-http.org/en/latest/discovery.html for more details.)
php-http/client-common suggests installing php-http/logger-plugin (PSR-3 Logger plugin)
php-http/client-common suggests installing php-http/cache-plugin (PSR-6 Cache plugin)
php-http/client-common suggests installing php-http/stopwatch-plugin (Symfony Stopwatch plugin)
Writing lock file
Generating autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
PHP Fatal error:  Class NunoMaduro\Collision\Adapters\Laravel\ExceptionHandler contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Contracts\Debug\ExceptionHandler::shouldReport) in /vagrant/project/vendor/nunomaduro/collision/src/Adapters/Laravel/ExceptionHandler.php on line 27
PHP Fatal error:  Uncaught Error: Cannot instantiate abstract class NunoMaduro\Collision\Adapters\Laravel\ExceptionHandler in /vagrant/project/vendor/nunomaduro/collision/src/Adapters/Laravel/CollisionServiceProvider.php:44
Stack trace:
#0 /vagrant/project/vendor/laravel/framework/src/Illuminate/Container/Container.php(791): NunoMaduro\Collision\Adapters\Laravel\CollisionServiceProvider->NunoMaduro\Collision\Adapters\Laravel\{closure}(Object(Illuminate\Foundation\Application), Array)
#1 /vagrant/project/vendor/laravel/framework/src/Illuminate/Container/Container.php(671): Illuminate\Container\Container->build(Object(Closure))
#2 /vagrant/project/vendor/laravel/framework/src/Illuminate/Container/Container.php(619): Illuminate\Container\Container->resolve('Illuminate\\Cont...', Array)
#3 /vagrant/project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(757): Illuminate\Container\Container->make('Illuminate\\Cont...', Array)
#4 /vagrant/project/vendor/laravel/framework/src/Illuminate/Foun in /vagrant/project/vendor/nunomaduro/collision/src/Adapters/Laravel/CollisionServiceProvider.php on line 44
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255

Basically, artisan doens't work:
$ ./artisan --version
PHP Fatal error:  Class NunoMaduro\Collision\Adapters\Laravel\ExceptionHandler contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Contracts\Debug\ExceptionHandler::shouldReport) in /vagrant/project/vendor/nunomaduro/collision/src/Adapters/Laravel/ExceptionHandler.php on line 27
PHP Fatal error:  Uncaught Error: Cannot instantiate abstract class NunoMaduro\Collision\Adapters\Laravel\ExceptionHandler in /vagrant/project/vendor/nunomaduro/collision/src/Adapters/Laravel/CollisionServiceProvider.php:44
Stack trace:
#0 /vagrant/project/vendor/laravel/framework/src/Illuminate/Container/Container.php(791): NunoMaduro\Collision\Adapters\Laravel\CollisionServiceProvider->NunoMaduro\Collision\Adapters\Laravel\{closure}(Object(Illuminate\Foundation\Application), Array)
#1 /vagrant/project/vendor/laravel/framework/src/Illuminate/Container/Container.php(671): Illuminate\Container\Container->build(Object(Closure))
#2 /vagrant/project/vendor/laravel/framework/src/Illuminate/Container/Container.php(619): Illuminate\Container\Container->resolve('Illuminate\\Cont...', Array)
#3 /vagrant/project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(757): Illuminate\Container\Container->make('Illuminate\\Cont...', Array)
#4 /vagrant/project/vendor/laravel/framework/src/Illuminate/Foun in /vagrant/project/vendor/nunomaduro/collision/src/Adapters/Laravel/CollisionServiceProvider.php on line 44

Seems that you are using an old version of collision.

💥 true, sorry for the noise; I was still on ^1.1 🤷♀


fix(scylla_manager): set segments_per_repair=16 in manager yaml

In an effort to make manager repairs faster, I set segments_per_repair to 16 in scylla_manager.yaml

Solves https://github.com/scylladb/mermaid/issues/1817


windows binary, YOLO format: multiple bounding boxes but only one object-class label in .txt file

OS: Windows
PyQt version:

Hi, I am using the binary version 1.8.0 for Windows. I want to tag multiple classes in one image, in YOLO format. This should for each bounding box include 'object-class', 'x', 'y', 'height' and 'width'.
However, when I take a look at the label .txt file, the object class is only labeled for the first bounding box. For all following bounding boxes, only the parameters 'x', 'y', 'height', and 'width' are saved.
As you can see in the picture, there is a class index 0 (dog) for the first picture but no class label for the subsequent pictures.

Thanks!

sorry, it was a text editor issue. thanks for your good work

Yes, I've encountered the same issue. And it seems to me that the issue occurs when opening the .txt label file in Notepad . Not while opening in a good text editor like Sublime.


Add github-cloning-forking lesson

@ktyle do we no longer have the ability to review with reviewNB, or am I missing something? I don't see a link. Thanks!

Hi @clyne , I think it's because there's no notebook that's changed in this PR ... just a markdown file (and several PNG files that are linked to in the document).

Thanks @clyne for the comments! Will address/respond to each as the day progresses.

@clyne let me know if you want to give this another review or if I should just get it merged for now!

@clyne Ok thanks going to go ahead and merge.


scanBleDevices using with kotlin cause compile error

Disclaimer
Before you will post a new issue to the RxAndroidBle library consider if you are filling a bug/feature request or a general question
about:

Usage of RxJava
Usage of Bluetooth Low Energy
Usage of RxAndroidBle
Weird behaviour of the peripheral you are using
Other not directly related to a new feature request or a bug

If any of the above points seems to match your use case — consider using Google or creating a question on www.stackoverflow.com with
a tag rxandroidble where it will be easier to access by other people with similar questions. Issues that are not bugs or feature requests
will be closed.
Summary
Using scanBleDevices with Kotlin we have an compile error.
I think its because both "scanBleDevices " methods expecting variable number of arguments.
Deleting the already deprecated method will fix this issue.
Library version
1.5.0 (that uses rxjava 2)
Preconditions
kotlin_version = '1.2.30'
implementation "com.polidea.rxandroidble2:rxandroidble:1.5.0"
Steps to reproduce actual result

Try to write code to scan devices

Minimum code snippet reproducing the issue
val rxBleClient by lazy { RxBleClient.create(this) }
val scanSettings : ScanSettings = ScanSettings.Builder().build()
rxBleClient.scanBleDevices(scanSettings, ScanFilter.empty())
Logs from the application running with setting RxBleLog.setLogLevel(RxBleLog.VERBOSE)

None of the following functions can be called with the arguments supplied.
scanBleDevices(ScanSettings!, vararg ScanFilter!) defined in com.polidea.rxandroidble2.RxBleClient
scanBleDevices(vararg UUID!) defined in com.polidea.rxandroidble2.RxBleClient

Actual result
Can not compile.
Expected result
It should compile.

Sorry. Wrong import of ScanSettings.

Glad you did it :D

Had the same problem:) because of auto imported by Android Studio:) This is why I like my api classes prefixed.

Sorry. Wrong import of ScanSettings.

You should have written how you solved the problem!


[Suggestion] Change the default font-family

Hello.
First thanks for your job ;)
The font "Helvetica Neue" doesn't include a lot of (special) characters (ex: çéèêëµ€).
I see the problem in title and text/html part. No problem with texts of buttons.
The problem occurs in Google Chrome 55 and Internet Explorer 11. No problem with FireFox 33 and Microsoft Edge 38. Not tested in Safari/Opera.
This is a Plunker to reproduce the problem. Uncomment my custom style to see my solution.
https://plnkr.co/edit/HlxZTS9xz2xZIubhIGRH?p=preview

Hm, are you sure that you're not having an encoding issue or something?
I see that Helvetica Neue is the primary font of Bootstrap, for example. They would not take an ascii-only font :)
On Linotype, I read that Helvetica Neue "supports up to 100 languages, such as English, German, French, Arabic, and Russa.".

I try the plunker with 2 other computers, no problem.
The one with problem: windows 7 64bits.

Tested in Linux/Chrome and Win7/Chrome and can't reproduce. This issue is up to your environment, @dethierx

I delete my local buggy font "helvetica regular.ttf" and and everything works perfectly.


Add a Key to FlutterDemo widget

It's a good practice to let clients supply a key for every widget.
Fixes #2910

@Hixie

lgtm


Get variables LESS_TERMCAP_* from lesskey file

The command less skips the variables LESS_TERMCAP_* defined in the lesskey file (e.g. ~/.less).
This is because, the function main() retrieves the variables LESS_TERMCAP_*
before loading of the lesskey file. I propose to just invert two lines.
I explain that in details on this site:
https://unix.stackexchange.com/a/377221/13999
This is the current source code at line 110 in main.c
/*
 * Process command line arguments and LESS environment arguments.
 * Command line arguments override environment arguments.
 */
is_tty = isatty(1);
get_term();
init_cmds();
init_charset();
init_line();

This is the fix I have validated on my computer:
/*
 * Process command line arguments and LESS environment arguments.
 * Command line arguments override environment arguments.
 */
is_tty = isatty(1);
init_cmds();         /* Load lesskey file before */
get_term();          /* getting variables LESS_TERMCAP_* */
init_charset();
init_line();

I have just inverted two lines: get_term(); and init_cmds();
Questions:

Do you want a pull request ?
Do you want to follow the bug-fix from upstream project ?

For information I have sent the same bug report a fix proposal to the less mainteners.

Inverting the two function calls get_term() and init_cmds() has some major regression issues.
The fix is in discussion with @rivy and official maintainer Mark Nudelman (and original author since 34 years).
A good fix should be implemented soon...

Let me know once you've got a good solution to this.  Then I'm happy to review a PR.

Hi Garrett. I have successfully tested the beta version as proposed by Mark Nudelman (that version fixes this issue). You will have a new release on http://greenwoodsoftware.com/less/ in the coming months... Mark Nudelman has clean a bit the source code removing, for example, the keyword register as you did. Thank you for your work. Cheers

Thanks.  Can I close this PR pending a new one with changes?

Yes you may close this Issue.
However I do not have time/motivation to prepare a Pull Request to fix the issue.


Feat: UE - Move to prompts

:tada: This issue has been resolved in version 1.2.0-beta.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Pybind v2.2.1

Bumps the pybind version from v1.8.1 to v2.2.1, resolving all compile & runtime issues that arose.
Upgrades to the API used https://github.com/pybind/pybind11/blob/master/docs/upgrade.rst as the point of reference.
This also solves a long-standing bug we had, where a type would spontaneously and intermittently change in the C++ -> Python boundary.
\cc @Yangqing

This also solves a long-standing bug we had

See https://github.com/caffe2/caffe2/issues/793

@slayton58 ,
How to deal if someone wants external pybind (not compiled with -fvisibility=hidden) ? E.g. one wants relay on distro's own pybind.

Pybind11 is used as a header-only library, so people would be compiling based on the distro-provided headers, and -fvisibility=hidden should still be used.

@pietern Just pushed an update with those comments (and more) removed

@soumith since you did https://github.com/caffe2/caffe2/commit/3f9a93da285b86b4cd43210cae26b7729bcbc8e9 , do you mind taking a look at this as well?

everything in this PR is now in https://github.com/caffe2/caffe2/commit/3f9a93da285b86b4cd43210cae26b7729bcbc8e9 except for updating the git submodule of pybind11 to latest.
@slayton58 sorry for subsuming your PR, I had to do the update in-sync with some other internal changes.

@Yangqing i didn't actually know how to update the pybind git submodule of c2 with our internal workflow, so i didn't do that. once you guys update that, travis will get back to passing status too

@Yangqing I can rebase this to just encompass the updated pybind commit, but that seems like it'd be a quicker fix for you (or someone else) to do from your internal tools.
If there are no objections I'll close this out due to https://github.com/caffe2/caffe2/commit/3f9a93da285b86b4cd43210cae26b7729bcbc8e9


Implement first-pass UI for user roles and permissions

Requires https://github.com/NASA-AMMOS/aerie/issues/861, https://github.com/NASA-AMMOS/aerie/issues/862, and https://github.com/NASA-AMMOS/aerie-ui/issues/544
This task is to do a first pass at implementing the design for user roles ~and permissions~.
We can break up this task into smaller sub-tasks as needed.
The four roles are admin, user, viewer, and not authorized. The UI should account for these 4 roles, and not break.
- [ ] https://github.com/NASA-AMMOS/aerie-ui/pull/668
- [x] https://github.com/NASA-AMMOS/aerie-ui/issues/684
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/690
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/685
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/686
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/687
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/692
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/723
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/730
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/742
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/751
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/757
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/763
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/782
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/783
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/774
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/778
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/786
- [ ] https://github.com/NASA-AMMOS/aerie-ui/issues/792

💯


grad_req from symbol.bind doesn't work in lstm?

Hi
For the current lstm.py code, if I change grad_req in rnn_sym.bind from "add" to "write". It will produce the same perplexity curve as the one with "add".
Moreover, I am rewriting the RNN components in mxnet and using similar design from TensorFlow. But I met some problems. I am pretty sure that the grad_req in my rewriting version is "write". Because under my experiments, the result get worser when the sequence length of input increase. Furthermore, I have used python/visualization.py to visual both the current lstm.py and my rewriting version. These two graph are the same.
Thanks;

add and write should be the same if we update every batch, because the gradient is always accumulated before write to the gradient holder.
The only difference was when doing update every two batches for example, then reset every two batch and with add will work differently than write

+1, if you check out the parameter in the IPython notebook, it says
update_period = 1

so add and write are the same here.

That's really helpful
Thanks;


Run on local repositories

E.g.:

via cli string flag
via cli flag pointing to filename

Why:

will enable non-github workflows on top

sure sounds like a good idea. let's support this via file?

A lot of people are asking for this + supporting local Git repos. Let's discuss @klieret , but I think we should prioritize this.

Perhaps we could support a markdown file with a yaml header with metadata? Something like
---
local_repo_path: ...
setup_command: ...  # allow to install things in the container
---
I have an issue I run

this is code
blah blah

hmmm I think that would require more documentation reading from users. I think it's better to just accept a text/.md file and then accept the other things from other args in the run file.
I want to make the usage experience as easy as possible for new users

Adding additional command line options comes with a price though: The run.py interface is already complex. If we add more options that are only sometimes relevant, it will lead to a lot of confusion with for example --local_repo_path being ignored depending on what you pass in as --data_path. In addition, these additional arguments also require users to read the documentation.
The only other way (which might require a bit more work, but might be worthwhile) is to spilt up the CLI more into subcommands/different executables.
For example a separate solve-batch (swe-bench-style evaluation-focused submissions), solve-issue (what we currently support with the issue path), solve-local (the new thing proposed here).
So then for example you'd do
python run.py solve-local --repo /path/to/repo --instructions /path/to/issue.md --install /path/to/setup.sh

and the command line options here wouldn't apply to solve-batch etc.

I think the split-into-subcommands approach is actually the best one. Every other strategy will run into a wall eventually.

people just want to try this out on their own code -- not having to go thru the whole github issue madness ideally

@cschubiner You can already check out #193 and run it locally. It will be merged very soon.


pip warns of missing README.md and SUPPORT files

Hello,
I noticed when updating f5-sdk tonight that pip warns of missing README.md and SUPPORT. Checking MANIFEST.in, it appears that the filenames for these are incorrect.
$ pip install --upgrade f5-sdk
.....
warning: no files found matching 'README.md'
warning: no files found matching 'SUPPORT'
The correct files appear to be README.rst and SUPPORT.md.
Thanks.

@vsnine is this still an issue?

a recent run of this shows the following
(foo4) SEA-ML-RUPP1:f5-common-python trupp$ pip install --upgrade f5-sdk
Collecting f5-sdk
Collecting f5-icontrol-rest<2.0.0 (from f5-sdk)
Requirement already up-to-date: six<2.0.0 in /Users/trupp/src/envs/foo4/lib/python2.7/site-packages (from f5-sdk)
Collecting requests<3,>=2.5.0 (from f5-icontrol-rest<2.0.0->f5-sdk)
  Using cached requests-2.18.4-py2.py3-none-any.whl
Collecting idna<2.7,>=2.5 (from requests<3,>=2.5.0->f5-icontrol-rest<2.0.0->f5-sdk)
  Using cached idna-2.6-py2.py3-none-any.whl
Requirement already up-to-date: urllib3<1.23,>=1.21.1 in /Users/trupp/src/envs/foo4/lib/python2.7/site-packages (from requests<3,>=2.5.0->f5-icontrol-rest<2.0.0->f5-sdk)
Requirement already up-to-date: certifi>=2017.4.17 in /Users/trupp/src/envs/foo4/lib/python2.7/site-packages (from requests<3,>=2.5.0->f5-icontrol-rest<2.0.0->f5-sdk)
Requirement already up-to-date: chardet<3.1.0,>=3.0.2 in /Users/trupp/src/envs/foo4/lib/python2.7/site-packages (from requests<3,>=2.5.0->f5-icontrol-rest<2.0.0->f5-sdk)
Installing collected packages: idna, requests, f5-icontrol-rest, f5-sdk
  Found existing installation: idna 2.5
    Uninstalling idna-2.5:
      Successfully uninstalled idna-2.5
  Found existing installation: requests 2.18.3
    Uninstalling requests-2.18.3:
      Successfully uninstalled requests-2.18.3
Successfully installed f5-icontrol-rest-1.3.0 f5-sdk-2.3.3 idna-2.6 requests-2.18.4
(foo4) SEA-ML-RUPP1:f5-common-python trupp$

@vsnine there is a 3.0.1 release that was just made. let us know whether this is or is not a problem still.

closing. this is fixed to the best of our knowledge. if the problem persists, please file a new issue


Update Networks and Categories for 0xPlasma Finance dApp

dApp Name: 0xPlasma Finance
dApp website: https://apy.plasma.finance/
Categories: DeFi, Dashboard, DEX, Tooling, Bridge, Aggregator, Staking, Yield
Supported Chains: Ethereum, Polygon, Avalanche, Arbitrum, Optimism, BNB Chain

Hey there! QA from safe apps here 😄
The app looks good on all of the supported chains so it should be all good to add it to the list on all of the remaining chains.
The team will give it a final 👀 and we will notify you here when the addition is performed.
Cheers!

Hey there! Doing some 👀 of our board I see that the app was added on all the requested chains so apologies we did not post any confirmation message for the addition 🤦
We currently support a max of 3 categories per app and I see that the current ones set for the 0xPlasma are:

Let us know if you would prefer others from the ones on the original message and we will happily change them.
Cheers!


ImportError: cannot import name 'deform_conv_cuda'

this problem happened when i run the High-leval-APIS code,i can't solve this problem, can anyone tell me the reason

Did you run the setup script?

env:anaconda +python3.7+pytorch1.1
i meet this error too,but i can't find solves.
Traceback (most recent call last):   File "/home/dell/Desktop/AFA/mmdetection-master/mmdet/ops/dcn/deform_conv.py", line 9, in <module>     from . import deform_conv_cuda ImportError: cannot import name 'deform_conv_cuda'
i just want to run demo.py.
like:`import os
from mmdet.apis import init_detector, inference_detector, show_result
if name == 'main':
config_file = 'configs/faster_rcnn_r50_fpn_1x.py'
checkpoint_file = '/home/dell/Desktop/AFA/mmdetection-0822/mmdetection/checkpoints/faster_rcnn_r50_fpn_1x_20181010-3d1b3351.pth'
# checkpoint_file = 'tools/work_dirs/mask_rcnn_r101_fpn_1x/epoch_1200.pth'
img_path = '/home/dell/Desktop/AFA/mmdetection-master/demo/demo.jpg'
model = init_detector(config_file, checkpoint_file, device='cuda:0')
# print(model)
# 输入可以为文件夹或者图片
if os.path.isdir(img_path):
imgs= os.listdir(img_path)
for i in range(len(imgs)):
imgs[i]=os.path.join(img_path,imgs[i])
for i, result in enumerate(inference_detector(model, imgs)):	# 支持可迭代输入imgs
print(i, imgs[i])
show_result(imgs[i], result, model.CLASSES, out_file='output/result_{}.jpg'.format(i))
elif os.path.isfile(img_path):
	result = inference_detector(model, img_path)
	show_result(img_path, result, model.CLASSES)

`
can you tell me,what's happen?thnx you so much!! @hellock @bbg-pjg @DXist

and ImportError: /home/dell/Desktop/AFA/mmdetection-master/mmdet/ops/dcn/deform_conv_cuda.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC1ENS_14SourceLocationERKSs
this error offer happen.

when I install mmdetection, I meet the same issue
the specific issue as following:
https://github.com/open-mmlab/mmdetection/issues/1949

and ImportError: /home/dell/Desktop/AFA/mmdetection-master/mmdet/ops/dcn/deform_conv_cuda.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC1ENS_14SourceLocationERKSs
this error offer happen.

I meet this problem too. I solve it by installing pytorch from pytorch office channel instead mirror such as tsinghua and alibaba.


Users are prompted to recommit "Deleted by us" conflicts

When backport tries to cherry-pick a PR, if the changes conflict and have a set of conflicts which are simply "deleted by us" backport will suggest that the used add them back to the repo. This is probably part of the reason the CODEOWNERS file has been added back to Kibana a handful of times and I think is the wrong behavior for this scenario. It would probably be most appropriate to just ask the user to resolve the issue:

Thinking about this more I'm guessing this is caused by the fact that backport tried to look for conflict markers in the files and doesn't spot any.

If I handle this issue by running
git rm .github/CODEOWNERS src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json

then come back to the backport script I have to click enter "to stage them", which feels weird too... I kinda wish that the UI would just start at the same place every time instead of possibly skipping the step which shows me the path to the repo and lets me hit enter to continue.

Released in v5.5.3


Update to 2.6.1

Issue
Towards https://github.com/orgs/giantswarm/projects/344/views/1?pane=issue&itemId=54244110

Description
This PR updates upstream fork to the version used by the app repository.

Checklist

[ ] Added tests that cover your change (if possible)
[ ] Added/modified documentation as required (such as the README.md, or the docs directory)
[ ] Manually tested
[ ] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

[ ] Backfilled missing tests for code in same general area :tada:
[ ] Refactored something and made the world a better place :star2:

pretty much unreviewable, if you tested it I'm good

this repo is not at the moment but the commit I used is the commit we reference  at the app repo. So we should be on the safe side.


Update method change created_at column value

I used update method for updating multi rows with one query. but after that all created_at column values changes!
$notifications->update(['read' => 1]);

I found out created_at column attribute defined as ON UPDATE CURRENT_TIMESTAMP.
How can I define timestamp without this attribute in migration file?

I used $table->nullableTimestamps(); in migration.

It happens because $this->timestamps() was equal to $this->timestamp('created_at'); $this->timestamp('updated_at'); which led to the following query being executed:
CREATE TABLE ... (... created_at timestamp not null, updated_at timestamp not null)

which is equivalent to
  `created_at` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
  `updated_at` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00',

in mysql. Do note the ON UPDATE CURRENT_TIMESTAMP part. Already fixed in the repo.

Yup, as commit message "Use the current timestamp as a default." the current timestamp is default value. anyway I set created_at nullable so the default value is null.
Thanks


enable Windows CPU CI on GHA

Same deal as for the other migrations here: let's run the CircleCI and GHA tests in parallel for a few weeks and if nothing comes up, we can remove the ones on CircleCI. This only ports the CPU jobs for now due to pytorch/test-infra#3979.
cc @seemethere

@atalman Just downloading nvjpeg from conda didn't work since we only look for it in $CUDA_HOME:
https://github.com/pytorch/vision/blob/781f512b01bc2324d7fdd11f0901f60571fc476f/setup.py#L313-L317
Until we rebuild the base images to include this by default, we could do the same as we do in our packaging scripts:
https://github.com/pytorch/vision/blob/781f512b01bc2324d7fdd11f0901f60571fc476f/packaging/windows/internal/cuda_install.bat#L59-L83
However, due to pytorch/test-infra#3986 it is currently almost impossible for me to try this. Thus, to unblock this PR, I'm going to remove the GPU workflow for now.
When nvjpeg is available by default on the Windows runners, or they spin up predictable enough for me to SSH in and debug, we can re-enable them.


Undefined variable in handleHistory.js

On this line:
https://github.com/yahoo/fluxible-router/blob/master/lib/handleHistory.js#L109
this._enableScroll appears to be undefined. Is this a typo?

@phuson looks like this is a relic from when we repurposed the old RouterMixin into handleHistory.
This is indeed a bug and we need to change all instances of this._enableScroll to options.enableScroll. Would you like to submit a PR?

@Vijar Sure, I'll submit a PR for this soon.

Fixed by #34.


Use Scorpio's SHA engine for digest validation in common cases

This PR uses Scorpio's SHA engine for validating the firmware. Since the (trivial) usage of the SHA engine is for one-shot continuous digest calculations that are multiples of SHA block sizes, the implementation is directly in image_validate.c then a more general hookup via the sha256.h header. The call to scorpio_sha256() is specifically utilized if RAM loading is enabled and some additional feature (such as split images) are not used. In those cases, the digest should fall back on the slow path (though this is not tested thoroughly).
With the usage of the SHA engine, the image validation time goes from ~10 seconds to ~1 second.
Also, see https://github.com/recogni/scorpio-fw/issues/1022.

Only comment is on the unconstrained loops waiting for the SHA engine to be ready...would we want to use some kind max iterations?

@brudley that's a fair observation. I looked one more time at the Verilog RTL (here) and I just don't see a way in which the FSM can get stuck short of a catastrophic hardware circuit defect (the FSM is basically either idle or counting rounds). Since this is the boot loader, and not the main firmware, there's also no remedy available in case of such a catastrophic hardware circuit defect, so I'll go ahead and merge for now.


Fix data_types incompatibility with Django 1.8+, issue #128.

Django 1.8 changed to assume the data_types attribute is on the DatabaseWrapper class, rather than the DatabaseCreation class, causing issues when saving objects (see issue #128 for more details).
I've added data_types to the DatabaseWrapper as well so as to be compatible with Django 1.8+ as well as retain compatibility with older versions.

Hi Chris,
Thanks for the contribution.  Apologies for the lack of response on your issue.  We're all crazy busy right now, unfortunately.
Your django-pyodbc does not want to drop support for Django 1.4-1.7 at this time.  I don't have mssql on my home machine, so I can't test it, but it seems like your edits are not backwards compatible with versions less than 1.7.  Have you tried running your version against django 1.7? e.g. pip install django==1.7.11 and try to invoke your code.

Hi Ross,
No worries, I understand you're busy, wasn't expecting such a quick response even!
I haven't removed the data_types from the DatabaseCreation class so now it's present in both classes, which I think should mean ensures compatibility with older Django versions as well.
I've tried it against 1.7.11 and 1.6.11 and it works fine (I was having some issues running the test suites so I've only done a few basic tests, e.g. some regular Django queries and a .save() that previously failed before this fix).
Thanks for the feedback

Yeah, the test suites are a little rusty too.  W.I.P...
I can't see how your edits could cause a conflict, so I'll merge it in.

Great, thanks!

I'll do a proper release in my morning tomorrow and bump the version to 1.0.1 .

Released as version 1.0.1


Feature multi line test

Here is a multi-line test for PR #3698 and issue #3629

Uh oh, something went wrong with the build. Need to check on that

Tests out, although I was confused at first why Jenkins failed it over a bad test, until I realized the dependency 👍


Predicate push-down does not work for views

ClickHouse does not push predicates, including partition column filters, down to the views. That results in very slow query performance of normal views comparing to tables.

Confirmed. We have this in plans.

Is there any update on this development.
As currently to get BI tools to work with AggregatingMergeTree we would need a view on top that does the sumMerge, countMerge etc from the sumState.
But it isn't workable as long as the view reads the whole table when querying

+1

What is the current state of this issue? I plan to implement it. @alexey-milovidov

It is blocked by other tasks.
Direct implementation on top of existing code of InterpreterSelectQuery and ExpressionAnalyzer is possible, but most likely will introduce a huge mess (probably not - you should try).
First we want to rewrite current implementation of UNION ALL. It is not necessary for this task, but it's very important for further evolution of code.

Thank for you reply. I will try to make a pr.
BWT,   Could you please tell me more about the implementation details of the new UNION ALL?  or can you tell me about the branch that you're working on? I only found better-union-all and union-all-preparation, but they were relatively old.

Basic idea is to separate InterpreterSelectQuery and InterpreterUnionQuery; and ASTSelectQuery and ASTUnionQuery. I plan to do it only after https://github.com/yandex/ClickHouse/pull/1935

Is there any progress on this? I'm on 18.5.1 and querying against a view that has union all scans the entire rows of all tables.

What is the current state of this issue?

https://github.com/yandex/ClickHouse/pull/4846


Update all blueprints in books

This changes behavior for blueprint books. With this change, if a blueprint book is held in the cursor, all blueprints in the book are updated. This is done recursively, updating any books within the book, too.
This was requested in https://mods.factorio.com/mod/GhostOnWater/discussion/636127bf321a67b094934dfb, and I agree with the request. I have a large blueprint book of train blueprints, and I'd like to update all of them in one pass. I have another book of hundreds of belt balancers - and likewise I want that to be updated in one go. Writing this PR was honestly quicker than doing each update one-by-one!
I haven't updated the changelog or any documentation; let me know whether you'd like me to do that or you prefer to do it yourself.

While I don't have anything against updating all BP in BP books I'm not sure if this is something everyone would always want. so maybe add a mod setting to turn recursively update BP books on or off (probably on by default).
I'd be happy if you updated the changelog and maybe the readme (which is basically the same thing as the mod page), as this adds a feature I'd be version 0.11.0 , I'll change the date in the changelog when I release it. I won't say to to having to to less work myself.

Sure @KeinNiemand. I have put this behavior behind a setting which defaults to true and updated the readme and changelog.


Document how to register all animations as stache helpers

It could be nice to register all of the animations under an animations object on the stache helpers
stache.registerHelper("animations", canStacheAnimate.animations);

..in order for that to work, we would need to use get (or similar) in can-stache/helpers/core's getHelper method (here)
I'll create an issue in can-stache and link it here

issue in can-stache to use get or observationReader: https://github.com/canjs/can-stache/issues/204


Error when using minified version.

When I use the minified version, I am getting this console error:
TypeError: a.drawing is not a function
    at Object.Skycons.draw (http://localhost/myapp/bower_components/angular-skycons/angular-skycons.min.js:1:7570)
    at Object.Skycons.add (http://localhost/myapp/bower_components/angular-skycons/angular-skycons.min.js:1:6998)
    at link (http://localhost/myapp/bower_components/angular-skycons/angular-skycons.min.js:1:8244)
    at http://ajax.googleapis.com/ajax/libs/angularjs/1.3.8/angular.min.js:70:370
    at $ (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.8/angular.min.js:70:426)
    at v (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.8/angular.min.js:59:401)
    at g (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.8/angular.min.js:52:9)
    at g (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.8/angular.min.js:52:26)
    at g (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.8/angular.min.js:52:26)
    at g (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.8/angular.min.js:52:26) <skycon icon="weather.skycon.icon" class="ng-isolate-scope">

Order of my scripts:
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.3.8/angular.min.js"></script>
<script src="//code.angularjs.org/1.3.8/angular-animate.min.js"></script>
<script src="assets/js/ui-router.min.js"></script>
<script src="bower_components/angular-skycons/angular-skycons.min.js"></script>

It works fine when not using minified version.

Thanks for catching this! Not sure what happened with my Grunt task. Just pushed up a fix and retagged so it is available on Bower as v2.0.2. Check it out and let me know if you still have problems.

@ryanwiesjahn I pushed an updated version for Bower last week. Let me know if you have any issues with that version. I am closing the issue. Thanks!


runtime error with<EMAIL_ADDRESS>

Hi,
I upgraded to<EMAIL_ADDRESS>this morning and it seems that there is an issue with react-ssr-prepass
Here is the stacktrace :
TypeError: Cannot read property 'dispatch' of null
useReducer
/home/jgoux/Projects/eurofins/colisage-ts/node_modules/react-ssr-prepass/src/internals/dispatcher.js:182:42
useState
/home/jgoux/Projects/eurofins/colisage-ts/node_modules/react-ssr-prepass/src/internals/dispatcher.js:163:10
useState
/home/jgoux/Projects/eurofins/colisage-ts/node_modules/react/cjs/react.development.js:1619:21
useSubscription
/home/jgoux/Projects/eurofins/colisage-ts/node_modules/urql/node_modules/use-subscription/cjs/use-subscription.development.js:37:25
useSource
/home/jgoux/Projects/eurofins/colisage-ts/node_modules/urql/src/hooks/useSource.ts:22:3
useQuery
/home/jgoux/Projects/eurofins/colisage-ts/node_modules/urql/src/hooks/useQuery.ts:59:17
useGetSitesQuery
./src/generated/graphql/hooks.ts:1499
  1496 |     `;
  1497 |
  1498 | export function useGetSitesQuery(options: Omit<Urql.UseQueryArgs<GetSitesQueryVariables>, 'query'> = {}) {
> 1499 |   return Urql.useQuery<GetSitesQuery>({ query: GetSitesDocument, ...options });
  1500 | };
  1501 | export const GetSiteDocument = gql`
  1502 |     query getSite($id: UUID!) {
View compiled
Component
./src/components/pages/settings/sites/index.tsx:40
  37 | const page = usePage();
  38 | const snackbar = useSnackbar();
  39 | const dialog = useDialog();
> 40 | const [{ data }] = useGetSitesQuery();
     | ^  41 |
  42 | const handleFabClick = () => {
  43 |   page.actions.setCreateSiteForm();

Everything is fine with<EMAIL_ADDRESS>

Interesting! I suspect this may be a subtle bug in react-ssr-prepass and we'll have to investigate it there. Can you send us over the version of react-ssr-prepass you're using please?

If using next-urql @0.2.5 I believe that version would be 1.0.8 for react-ssr-prepass. Once I release 0.3.0 it'll bump up to 1.1.0, so may be worth waiting until that new version gets released to verify that it's still an issue. Should have the release out early next week.

I'm also getting this issue and can confirm I'm using react-ssr-prepass 1.1.0

yeah, same issue react-ssr-prepass throwing error

We’ve debugged this and found the issue. A patch should be incoming today


Retry Listener

What are your thoughts on adding a listener framework to the the Retryer?
My use case is that I would like to log each failed retry attempt but I don't see any way to inspect the results
I was thinking we could add a simple interface
interface RetryListener {
    void attempt(Attempt attempt, int attemptNumber);
}

That should cover most use cases.  Spring retry has a different interface but I think just logging each Attempt should cover onClose/onError.
Happy to create a pull request for this if you're interested.

Looks like something similar is proposed in https://github.com/rholder/guava-retrying/pull/21

@rholder any thoughts here? It looks like this has come up a few times.

It has come up a few times. Would the PR in #21 handle your case, too?

I think the implementation in this fork https://github.com/txtr/guava-retrying/commit/a13cc7d1e2e766cdcf74d1a5edbc117bd9989fe4 was closer to what I had in mind.
The FailedAttemptEvent concept doesn't make sense if you want to capture successful invocations too.

I would be in favor of a solution similar to what's in that fork. Feel free to open a PR and if you don't hear back from me on it just keep commenting until I respond.

Hey @rholder any update on when this will be released?
Thanks!

It's getting closer to a release. I've been swamped lately, but hope to block out some time this weekend.

Hi @rholder any news on 1.8 or 2.0 release?
Thank you

Hi @rholder, is there an ETA when this will be released?

@kevinconaway This is for sure the next project I'm blocking out time to ship. I'm setting a personal deadline for getting a 2.0 out at the end of June (regardless of how many things don't make it in). Thanks for continuing to send me reminder feedback that there are things to do here because it helps me prioritize projects.

Your implementation has landed in the 2.0.0 release that just went out. I'd planned to eventually be able to register listeners specifically for failure events, too, but I would rather release this now since your functionality is complete and appears to be working delightfully. I've added a @Beta annotation to give a heads up to early adopters that the API is still subject to change moving forward in case we get that in there at a later date.

Thanks again for your contributions and relentless patience!


Add a couple of new/old SoCs

Add a couple of new/old SoCs

LGTM except a comment regarding the MCCC.

msm8998 joined the party "accidentally", apparently i had it on the local branch..


[Bug] Client Update still buggy

Try to reproduce the update problems with remote clients.

Syd711 | [MAT] — Today at 5:50 PM
For reproducing it: you started the update remote or did you first update everything on the cabinet and then launched the remote client?
Enthusiast — Today at 5:52 PM
I did everything remote, client and server


"Folder column sizing" is not respected when folder is expanded

When using this feature, the folders respect the column sizing when minimized, but not when clicked and opened.

if i recall correctly, i had done that on purpose because of the way things would reposition when a tall skinny thing was open. i'll have to try again to see what can be done.

yeah this is the effect it has:

since i'm not using any of the masonry type stuff. idk how to feel about it really.


Reimplement callables using func call.

Remove call declarations.
Treat methods named func call as call-syntax delegate methods.

The majority of the diff comes from reverting #24086.
The actual reimplementation is <100 LOC.

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please test tensorflow

@swift-ci Please clean test tensorflow

@swift-ci Please clean test tensorflow

@swift-ci Please clean test tensorflow macOS

We should add tests in combination with other language features such as IUOs and try.
struct CallableStuff {
  func call() {}
  func call(_ f: () throws -> ()) rethrows {}
}

var x: CallableStuff! = CallableStuff()
x() // should work
x!() // should work
x {} // should work
try x { throw ... } // should work

We should add tests in combination with other language features such as IUOs and try.

Added more tests along those lines in https://github.com/apple/swift/pull/24157.

Much simpler Dan, great work!


Add Individual GBs to the Spoiler

An addition to having the available GB count on the sphere, this update also adds the "logically required" GBs to the spoiler. I skipped this in the original commit because it added a ton of time to paring the playthrough. With some tricks, we can cut down on that dramatically.
A "logically required" GB is any GB that can be obtained in a sphere with a smaller available GB count than the largest B Locker requirement (usually Helm, but some maniacs might not make it that). This concept lets us very quickly cull GBs that aren't required.
Where these changes work best is early in level order randomizer seeds where the logic can sometimes require you to get every GB available. Knowing that you needed all 5 GBs isn't very helpful, but being given the locations in the spoiler can be very educational.

I was going to request to ensure GBs wouldn't end up in the woth list, but I guess GBs are set to constant so they're already ignored.
Can you provide a measure of how much impact this has on seed gen time? Like gen 3-5 seeds with and without the change and see how much it changes the average?

Basically no difference on seed gen. This makes sense, as the changes just add a few operations per sphere, which is nothing compared to the rest of ParePlaythrough. My testing found a higher average ParePlaythrough runtime on v1.1 than this branch, which is probably just variance but shows this has very little impact in the grand scheme of things.


refactor GC: do not maintain GCBits of dead objects

There is no need to maintain GCbits for dead objects, so we can avoid clearing them during sweeping (apart from the finalize bits that still need to be cleared because runFinalizers doesn't know which objects are alive).
This PR adds a small overhead in malloc by calling both clrBits and setBits, but this can be reduced by a combined setting function to be added by another PR.

I've run the druntime/benchmarks and they are actually slightly slower after applying this PR.

How much slower? Anyhow your changes make the code smaller which may have an impact on larger codebases.
@MartinNowak LGTY? I'm thinking our two resident GC experts @rainers and @MartinNowak should review each GC-related pull request (and obviously each others').

 IMO too bad to compensate the code cleanup. I'll try the combined set method...

I'll try the combined set method...

That doesn't help, so there seems no good rescue for this PR. I guess it's clrBitsSmallSweep that makes the difference.

ok thanks!

That doesn't help, so there seems no good rescue for this PR. I guess it's clrBitsSmallSweep that makes the difference.

Most likely, @dsimcha introduced it, because bitops aren't among the fast operations.
But I actually already have an idea to get rid of clrBitsSmallSweep. Let's me quickly try that.


Reproducible Build

[x] use cargo make
[x] add Cargo.lock to repo
[x] add rust-toolchain.toml
[x] update ci to use cargo make rules
[ ] update CONTRIBUTING.md to mention cargo make
[x] update pre-commmit.yaml to use cargo make

ref: https://github.com/0xPolygonMiden/miden-vm/issues/1259

What is missing here? Can we close that today?


Adoption Application Reviews - Translation missing

Translation for "awaiting data" is missing form en.yml. Update to resolve error.
To reproduce, visit Adoption Applications on the staff dashboard. Change a application status to "Awaiting Data".

shall i fixed this in the same PR
@jmilljr24 ?

@Aaryanpal I think we should just keep things separate. I doubt any issues will come up with either but it makes it easier if it does. Push up the fix for the other and I can then assign this to you if you want.

@jmilljr24 sure.
Let's Keep them separate.


Unable to View Any .m3u8 Streams

Using version 0.2.0
Toggling "start_stream" for Eufy Cam 2/2 Pro generates a livestream url tail similar to:
/eufy-security.0/T8010XXXXXXXXX/live/T8114XXXXXXXXX.m3u8

But when I try something similar to the following url, the stream does not actually load (it does not appear that this path actually exists on the webserver):
http://<IPAddress>:8082/eufy-security.0/T8010XXXXXXXXX/live/T8114XXXXXXXXXX.m3u8

I've tried with both VLC and in the Chrome browser.
(I can resolve other files via other paths like http://<IPAddress>:8082/eufy-security.0/T8210XXXXXXXXXX.jpg without issue)

Hi @pldmgg,
please activate the debug mode 2 of the adapter and reproduce the error. Then please send me the logfile (note: the logfile contains sensitive data; mainly the token, so redact it).
You can find my mail in the license description here.

Hi @bropat - I can't quite figure out how to enable "debug mode 2" for the eufy adapter. I looked through the Admin UI and couldn't really find anything. I also found iobroker.json, but I'm sure that's not what you're looking for. The other documentation refers to using Webstorm - Is Webstorm officially how I'm supposed to enable debug mode 2 for a particular adapter?

@pldmgg Sorry, when copying the message I lost the link ;). Look here

Thanks for all your hard work @bropat!
Unfortunately, same here. It looks like the stream is processed ok in the log. But it can not be accessed at http://:8082/eufy-security.0/T8010XXXXXXXXXXX/live/T811XXXXXXXXXXXX.m3u8. Same goes for http://:8082/eufy-security.0/T8010XXXXXXXXXXX/last_live/T811XXXXXXXXXXXX.jpeg. I get a File T8010XXXXXXXXXXX/last_live/T811XXXXXXXXXXXX.m3u8 not found: Not exists

Just tried version 0.2.2 and this is resolved. Thanks so much for your work on this!

Hi @bropat
Version 0.2.2 / Eufy Cam 2
I have deleted the instance ioBroker.eufy-security and create a new one.
http://<IP_ADDRESS>:8082/eufy-security.0/T8010XXXXXXXXXXX/live/T8114XXXXXXXXXXX.m3u8 => empty after activation of the flow.
attached log file (DEBUG)
Thank you great work!
iobroker.2021-02-16.log


fix(cdk) pass valid LW_API_TOKEN to components

Summary
When the cached token expires running lacework iac ... does not pass LW_API_TOKEN.
How did you test this change?
With the iac component installed, I run lacework access-token -d 10 to generate a very short lived token.
Initially a command like lacework iac org list will succeed.  But after ~10 seconds you will get:
samshen@Sams-Lacework-Laptop go-sdk % lacework iac org list
[Error] GET https://api.demo.soluble.cloud/api/v1/users/profile returned 401 in 463ms
[Error] {
  "ok" : false,
  "status" : 401,
  "error" : "Unauthorized",
  "timestamp" : "2022-11-07T17:21:12.923519Z",
  "message" : "401"
}
[ Info] Are you not logged in?  Use lacework iac auth profile to verify.
[ Info] See https://docs.lacework.com/iac/ for more information.
Error: https://api.demo.soluble.cloud/api/v1/users/profile returned 401
ERROR unable to run component: exit status 1

You can look under ~/.config/lacework/cache to see that the token has not been refreshed.
Issue
RAIN-42604

@afiune ,
I think that as part of a component's spec it should be allowed to communicate to the CLI that it wants a token with a certain TTL/expiry.  This will ensure that the CLI gives the component a token that will be valid for an appropriate amount of time.
Thoughts?
David

@hazedav I could see a case where we need such communication, but today, it is not a must have but more a nice to have. Lets add notes to https://lacework.atlassian.net/browse/ALLY-1026

@hazedav I could see a case where we need such communication, but today, it is not a must have but more a nice to have. Lets add notes to https://lacework.atlassian.net/browse/ALLY-1026

May not be needed as long as the token properly refreshes itself once a valid client is established...


404 Error on Website (#307)

Fixes #307
This PR addresses the 404 errors encountered on the website as outlined in issue #307.
Screenshots (if applicable)
https://github.com/user-attachments/assets/6572f3a9-dd68-4324-944f-8aaae4ac1aa5
Checklist

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

this pr is given label 3 because contributor had to detect bug and solve it in the backend


plantnet - multiple search - avoid previous candidate post

Following #17
We  need to avoid verifying a given candidate multiple times,
for example when a Pl@ntNet identification gives 404 no result or a result with bad score (<20%)
Suggest: we may try to see if we could use "mask this post" feature ?

"mask this post" seems only client decorator and not available through API

⚠ muteEntry::indexedAt  : seems to be ACCOUNT date and note mute date !!


Code for Normalization is wrong

Expected Behavior
Actual Behavior
Normalization happens over 13 rows not over columns (features)
def scale(feature):
max = np.max(feature)
feature = (feature / max).astype(np.float)
return feature, max
params = []
for _ in range(13):
x_train[], max = scale(x_train[])
x_test[], _ = scale(x_test[])
params.append(max)
Steps to Reproduce the Problem

Change line for this one: x_train[:+1:]

Specifications

Version:
Platform:

fixed


specter: move to dedicated user and store data on the disk

Fixing: https://github.com/rootzoll/raspiblitz/issues/1842

create the specter user
store data on the disk
update to v0.10.2

@openoms do you see this as something that can wait a bit until v1.7 (maybe spring 2021) is ready or should we target a v1.6.3 release for end of this year?

The only big difference here that with this the Specter data can be carried over during an update or restore.
It depends how one uses Specter, but should utilise the built-in backup option of Specter if storing valuable data.  Now even hot wallets are possible to be done with Specter so can be an issue.

So if this is the only slightly critical fix I think we can delay it to v1.7 ... but if we make a 1.6.3 this should be part of it.


Replace signatures in IdentityUpdate

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1051  👈
#1050
#1049
#1048
#1047
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @neekolas and the rest of your teammates on  Graphite


Texture transformation on each texture

Add texture transformation to each texture and remove it from Mesh and InstancedMesh. Keep it in Instances to be able to apply different texture transformations for each instance, but rename to texture_transformation to be consistent.

Fixed in #301 💪


Please add LICENSE

Been looking at this and related repositories, amazing stuff!
Can you please include a LICENSE for this project like the GNU AGPLv3? Thank you for your work!

Thanks, added MIT license. Meant to have it there all along!


Need more build minutes on CircleCI

Just saw this:

Looks like our activity is up, probably in part due to Dependabot, and that some of the recent issues we've been having have meant more rebuilds than usual.

If we reached out to them, maybe they would give us more.

I emailed 'em.

It's a UI bug 😌


Checkout main branch instead of ref that triggered workflow

Following-up on https://github.com/Expensify/react-native-onyx/pull/252, we need to checkout the main branch, not the ref that triggered the workflow, for this to work as expected.
Tests
Merge this PR and another one in quick succession. publish workflows should start for both, and the second should wait for the first to complete before starting. Both workflows should succeed

This is valuable lesson to learn w/ much faster feedback than we would have in E/App, sorry for the noise react-native-onyx

https://github.com/Expensify/react-native-onyx/actions/runs/5247955421
https://github.com/Expensify/react-native-onyx/actions/runs/5247956234

kk this worked, we are all set here


PDF frontend

It would be nice to use Pathfinder as the backend for a PDF renderer.

I might look into that. I have created PDFs in Rust before, so not the worst precondition.

Oh. I just realize "Pathfinder as a backend for a PDF renderer", not a PDF as a backend for Pathfinder.
Well, now there is one at https://github.com/s3bk/pathfinder/tree/pdf_export

Okay. I can now convert the Tiger from SVG to PDF and PDF to SVG. PDF Fonts though are a nightmare.

Some PDFs work. I have not figured out how symbol fonts work though.

The symbol fonts might be caused by some fonts (e.g. cmsy) being bitmaps rather than type 1. There are ttf versions, e.g. https://ctan.org/tex-archive/fonts/cm/ps-type1/bakoma/ttf/ I don't know if your TeX installation can be persuaded to use them.

This is an example. It is a Type1C font (Compact Font Format). Glyph 3 is very much defined and has a valid outline. However I can't get the glyph out of font-kit's Font
font_F3.zip

I managed to implement Type1 (PostScript, OpenType and CFF), Type2 (CFF) and TrueType (via stb-rusttype) in Rust. Stll has a lot of missing parts, but it can render a few PDFs so far.

Progress report for those not on matrix:

[x] PDF integration in demo
[ ] merge my fork back
[ ] fix text transformation

We have a PDF frontend now.


⚠ CD BUILTIN SEGV

this is may be due to the last modification to the reset_variable function , in the memory freeing

after proceeding for some memory freeing in the export_utils.c file, the cd builtin broke down and now fixed, but there are surely some leaks out there in export.


Fix description of bio-hazard cades

About the PR

description of bio-hazard upgraded cades to be less misleading
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

:cl:

tweak: Changed bio-hazard cades description

Wouldn't it just be better to remove the breaks easier part

okay


Centering slide images vertically

I need to set a fixed width for the slide show, which also means max-width and max-height for the images. This means that some images will be less high than the slideshow container, and they are positioned at the top.
I was wondering how one can center slide images vertically.  Adding a top: xx directive will apply to all images, not only the small ones.

Hi @william-vw, you can try using css flex-box to align things vertically and horizontally. For example:

without display: flex:

with display: flex, using align-items: center and justify-content: center:

Thanks a lot for this! Yes, using flex-box works. Seems like I stopped following CSS about ten years ago .. I had actually outfitted the slidr code with a dynamic re-positioning (setting top, left) based on the naturalHeight and naturalWidth of the images once they were loaded. Talk about overkill .. Lol.
FYI, I was wondering why the pause effect was not working when using the auto mode - it looks like mouse tracking is only enabled when keyboard is found in the settings:
if (_.settings['keyboard']) nav.mouse.track(_.slidr);
Which seems a bit strange, but maybe there's a reason?
Anyway, thanks for the awesome library :-)


chore: optimize CollectionInfoBuilder

Optimize CollectioninfoBuilder
Description

Converted CollectionTypeInfo to a struct
Removed duplicate IImmutableQueue and added ImmutableSortedDictionary
Added check to HasValidAddMethod for types with known Add methods, otherwise all none None types return false. None types are manually checked for Add methods.
IsCountKnown returns null for IEnumerable, "Length" for Array, Span and Memory and "Count" for all none None types. None types are manually checked for length properties.

Added a special check for string to return IEnumerable, because string isn't actually a "collection" type but does implement IEnumerable and is marked None by GetCollectionTypeInfo. It would iterate thrrought every possible collection type causing a considerable slow down.

Moved GetEnumeratedType into BuildCollectionInfos. This is a quick check to ensure that both the source and target types are actually enumerable, saving a lot of wasted time.

Splitting up changes from https://github.com/riok/mapperly/pull/530
Benchmarks
Small performance boost with 2000KB memory savings
Optimize CollectionInfoBuilder

Method
Mean
Error
StdDev
Gen0
Gen1
Allocated

Compile
2.498 ms
0.0321 ms
0.0284 ms
160.1563
35.1563
289.22 KB

LargeCompile
66.696 ms
1.2895 ms
1.0768 ms
1833.3333
666.6667
11943.5 KB

Method
Mean
Error
StdDev
Gen0
Gen1
Gen2
Allocated

Compile
2.500 ms
0.0365 ms
0.0305 ms
164.0625
35.1563
-
290.83 KB

LargeCompile
69.251 ms
1.3676 ms
2.4310 ms
2000.0000
714.2857
142.8571
11946.09 KB

Original

Method
Mean
Error
StdDev
Gen0
Gen1
Allocated

Compile
2.640 ms
0.0524 ms
0.0490 ms
179.6875
46.8750
320.39 KB

LargeCompile
75.350 ms
1.4524 ms
1.3586 ms
2333.3333
833.3333
14283.01 KB

Method
Mean
Error
StdDev
Gen0
Gen1
Allocated

-------------
----------:
----------:
----------:
----------:
---------:
------------:

Compile
2.627 ms
0.0428 ms
0.0379 ms
179.6875
39.0625
326.46 KB

LargeCompile
72.979 ms
1.1195 ms
0.8740 ms
2285.7143
571.4286
14280.24 KB

Checklist

[x] The existing code style is followed
[x] The commit message follows our guidelines
[x] Performed a self-review of my code
[x] Hard-to-understand areas of my code are commented
[x] The documentation is updated (as applicable)
[x] Unit tests are added/updated
[x] Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@TimothyMakkison can you rebase onto main? 😊

@TimothyMakkison can you rebase onto main? 😊

Done 👍


Is iFrame to Parent Communication is Supported by IE10 with PortHole?

Does iFrame to Parent Communication is Supported by IE10 with PortHole.
I Followed the documentation and my parent view don't receive message but it work well on Chrome and safari

Tested to be working on IE10