How do I use this with the package / workspace root being a subdirectory?

I have a project where there is no Cargo.toml at the repository root (all the Rust stuff is in a subdirectory).
I've tried this:
jobs:
  cargo-deny:
    runs-on: ubuntu-latest
    defaults:
      run:
        working-directory: api
    steps:
      - uses: actions/checkout@v2
      - uses: EmbarkStudios/cargo-deny-action@v1

but it doesn't work (seems like defaults.run doesn't apply to cargo-deny-action).
Is there some way to do this with cargo-deny-action as-is, or would this be a new feature?

Ping @repi

Don't think we've had that use case or tested that. But cargo-deny itself does support passing in, similar to Cargo, a --manifest-path to point to the Cargo.toml to run on, so passing that in to the action likely also works.
https://embarkstudios.github.io/cargo-deny/cli/common.html

Thanks. Works with
      - uses: EmbarkStudios/cargo-deny-action@v1
        with:
          arguments: --manifest-path=api/Cargo.toml


Make 'docker-push' a separate task

We shouldn't push the docker image to docker hub
every time anyone runs 'make server' to do local
development on the user guide.
This commit extracts that function to a separate
makefile target, and adds instructions to the
README.

Just came here to open this issue myself 🤗


slot-scope cannot be written on  tag after version 2.6.x

Version
2.6.10
Reproduction link
https://codepen.io/anon/pen/GewZMr?editors=1010
Steps to reproduce
2.5.22 demo1 : https://codepen.io/anon/pen/moQEmx （Ignoring the text on the
 tag, the actual Vue version referenced is 2.5.22）

===========================
2.6.x demo2: https://codepen.io/anon/pen/GewZMr?editors=1010

What is expected?
display normailly
what’s the different between demo1 and demo2？
What is actually happening?
<slot slot-scope="props">
  123
</slot>

this part can't display on the page

The workaround would be to use a template. As we move to the v-slot syntax to unify normal and scoped slots I'm not sure it is worth to support this

I don't think we ever intended to support this. The semantics is quite vague and I think it's better to not work at all.


Consolidate Documentation sections of README

Some more post-patch cleanup!

Closing because it's already been fixed with a patch!


Web interface

👋 Hi, I'm a front-end developer and am using this software for a baby monitor quite successfully! Because my wife and I use this as a baby monitor, we're often using our phones to view the camera. The web interface is decently mobile friendly but there's definitely some love that could be given and I'd be glad to help. It's been quite awhile since I've done anything in PHP and would propose not to do a rebuild in regular PHP/HTML/CSS and instead move over to a framework like Angular.
I pulled down the code and started poking around and it seems like it would be a lot of effort to make that conversion and so I want to chat about it first before starting down that path only to have it not be inline with the project's direction.
Please let me know if this kind of redesign is something you're interested in. Thanks!

Yes. I would be interested in this.
As you can probably tell I am not a front end developer. I started contributing a few years ago when it had a very basic interface. I rewrote and added quite a lot of functionality into the underlying raspimjpeg process and gradually expanded the web side bit by bit to include the preview and scheduler side.
I could foresee 2 basic approaches here.
First is to keep the php server side functionality dealing with video generation and support of command processing (i.e. injection of commands into the raspimjpeg command pipe); and then rework the html, css, javascript client side to do the presentation. Today, that is still concentrated primarily server side with the html being fairly fully generated. The server side would need extra support functions (e.g. responding to requests for preview file details (json) rather then generating the html, but that is fairly easy to do and I would be able to support that..
The second approach is to do a radical rework of the back end as well using a framework as you suggest. That is probably quite a lot of work and sometimes one can spend quite a bit of time fighting the philosophy of the framework to fit in specific functionality. The scheduler is maybe one example here where the scheduler.php actually provides 2 functions. The first is the user access to changing settings, but secondly the scheduler.php is also running as background process to perform the scheduling actions.   It would be fairly straightforward to provide setting functions to a new front end for display and editing as these are already json. The background process is reasonably complex and would be quite a lot of work to rewrite that.
The other comment I would make is that myself and a lot of users base the camera server side on Raspberry Pi Zero platform (cost, power, size). The current software runs nicely on this and with fairly modest CPU utilisation as a lot of the heavy duty work is in the GPU, I would want to make sure that any changes keep the server side processing low enough to keep  this.
Let me know your further thoughts.

Thanks for getting back so quickly!
It's very easy for me to get lofty ideas for web-based apps but I 100% appreciate the ability to iterate quickly. As much as I personally love the second option you proposed, I frankly don't know enough about the server-side complexities but I do think if I had your support for backend services that we could accomplish it. The biggest change would be migrating the PHP server code to perform more like a RESTful API instead of a page-request model. I understand the performance concerns for the Raspberry Pi Zero as that guy does not have great specs but in my mind, the biggest CPU hurdle would be the video streaming. Standing up a simple API served up by PHP should not crush the server (unless many users were hitting it at once which I don't think is the use-case we are concerned about).
Could we work off an experimental 7.0.x branch to see what's possible? Are there any reasonable lightweight PHP frameworks for serving up a RESTful API? As for scheduler.php

The background process is reasonably complex and would be quite a lot of work to rewrite that.

I don't think that needs to be rewritten, especially if it already interacts with json unless I'm missing something.

OK. I think I could handle most aspects of RESTful API support at the server side. I would need to think a bit about the data model as I am not keen to introduce a database. Currently, everything is generated  on the  fly from the filing system.
On the performance side the preview streaming is actually fairly lightweight on the main CPU.
From a development perspective it may be easiest to generate a separate fork into my github account. That is where the current source for the raspimjpeg process lives. The web side lives under silvanmelchior who was the original developer. Although I am effectively the sole developer I don't have the administrative control so I don't think I can add additional contributors.
I won't be able to respond further till tomorrow due to other commitments.

I have forked over to my github account (roberttidey).
If you are still interested in trying to proceed then I can add you as collaborator on that and start to investigate making php RESTful server side.

Yes I would love that! I should have time tomorrow and Thursday this week. Hopefully can sprinkle in some time during the weekend as well.

This is great, something I had thought about contributing before but I just don't have the necessary skills to do a good job on the UI. Anyway, I commend the effort! Happy to participate in any testing, etc if needed

@ffcruz85 UI skills aren't all that's needed! To begin with we need to document the API domain models and endpoints (kicked off here https://github.com/roberttidey/RPi_Cam_Web_Interface/blob/master/API.md). Any feedback or contribution there would be very helpful!

I have opened a development discussion issue on the fork'd repo to make it a bit easier and avoid any confusion here.
I made some quick comments on API.md but will add more after giving more thought.

@SirZach Will look at it over there - I will have some time in a couple of weeks

I am going to start adding a template manager, probably smarty as that is what I am most familiar with.  I should have something worth looking at in a day or two.  Once that is done the rest of the UI work could continue from there since the JS and HTML will be separated from the PHP.
I am not sure this project really needs a "Framework" but that's a discussion that should happen up front and soon as it's easy now to code it into one whereas with each change it gets harder.


menu-icon Issues Native Mobile

Is there an existing issue for this?

[X] I have searched the existing issues

Do you want this issue prioritized?

[ ] Yes, I have sponsored
[X] Not urgent

Current Behavior
The menu-icon example seems to be having issues on purely native platforms. No issues in web though.
Discord chat for further context: https://discord.com/channels/1085921563372703815/1234718900651032707
Expected Behavior
menu-icon works on iOS/Android
Steps To Reproduce
Copy the menu-icon example into a React Native project. Run project on either iOS or Android. Should observe the animation not working.
Versions
- Moti: 0.28.1
- Reanimated: 3.6.3
- React Native: 0.73.6

Screenshots
No response
Reproduction
<EMAIL_ADDRESS>

Also running in to this. Is there a workaround?


Support for curseforge resource packs

To be able to release modpack on the CurseForge, resource pack files should be referenced in the manifest.json.
Otherwise, the modpack will be rejected.

Good idea! For now, you can add them manually to the manifest, but I'll add the feature later.

Marked as bug, because adding a resourcepack manually breaks pax.

Ok, after testing again I realised pax doesn't break anymore with a resource pack, at least not when I'm testing.
If it does for you, try updating to the newest version first, if that still doesn't help, tell me about what commands are causing a crash for you.
The act of adding a resource pack with ./pax add would complicate things a bit, I'm gonna think about how to manage them a bit longer.
./pax upgrade should also work with resource packs.

I was exporting my modpack with the resource pack in the manifest with no problem, even on the older version of Pax. But, thanks for the info!
Running ./pax add also for resource pack could be confusing. Hard to tell how to make it. Take your time with it!
Oh, that's great.


pagination working incorrectly while using slideTo

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 3.4.2

Platform/Target and Browser Versions: Chrome and mobile

What you did
The idea is that when you click on an image from an index of thumbnails, it should swipe to the correct image.
Expected Behavior
This works. But :
Actual Behavior
The pagination is a bit laggy. It doesn't refresh.
For instance, if you click on the thumbnail number 2, it goes to the image number 2, but the pagination stays at 0. Then if you want to change the slide with the arrow key, instead of going to slide 3, it will go to slide 1, because the pagination was stuck at 0.
Live version : www.dianedeschenaux.ch/beta -> section "selected works"
Thanks

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


API verification service

add unlimited access for referers.
monthly count doesn't take year into account.

Updated in v1.2.5


Rename wgWiki* to wgSlackNotificationWiki*

Noting it would be preferable to do this because or else it interferes with other extensions such as DiscordNotifications.

Yep. At start all these configs should have been like this, something I did not realize to do.
I am debating whether I should add info to quite close to top of the readme file so that anyone updating to latest version of the extension would notice this change. Potentially this will break anyone updating to latest version if they have changed these parameters. What do you think?

Yep. When I started creating this extension, all these configs should have been named like this. Unfortunately I did not realize this :/
I am debating whether I should add info to quite close to top of the readme file so that anyone updating to latest version of the extension would notice this change. Potentially this will break anyone updating to latest version if they have changed these parameters. What do you think?

Sounds fine to me :)

Thanks! I will now bump the version and make a note of this change.

Thank you for the merge!


RSDK-5238 - Versioned releases

Note to reviewers: the release job worked entirely in testing up until the actual release step (that is, everything built and uploaded, artifacts downloaded, etc., but github couldn't create the release). I did some digging and ensured that all the recommended fixes were in place, but nothing worked.
I am hopeful that the issue is simply that the job was running from a PR with a forked branch, where the workflow file didn't exist yet in main. I'd like to merge and test that theory; if it's wrong, I can go back to the drawing board. That said, if anyone has suggestions I'm certainly all ears.

I'm a little puzzled by this review. Is it intending to produce binary releases for end-user consumption? Based on the title I was expecting work around automating versioning, not producing "release" builds.

Yeah that's fair. My intent here is to have a process that follows that used by rust-utils and the Python and TS SDKs. Specifically, a job that users can run to create new downloadable versioned releases. This one is slightly more manual in that a human PR is required to bump version at this time but from conversation with @benjirewis and @njooma it seemed like this was acceptable at least in the short-term.

a human PR is required to bump version

The Mongo Go driver, Rust driver and C driver all required this at some point when I worked there FWIW.

@stuqdog - Just checking in on this review: I think it is waiting on you, but I wanted to double check that it wasn't actually waiting on me for something.

@stuqdog - Just checking in on this review: I think it is waiting on you, but I wanted to double check that it wasn't actually waiting on me for something.

@acmorrow sorry I somehow missed your earlier comments! You are right, I will look into integrating those today.

LGTM but what's the deal with the uploaded artifacts? Do we think users will install the C++ SDK from the Github artifacts? Or will we point the eventual homebrew formula at those artifacts?

Yeah I think for mac users we'll more likely point them to homebrew, but I don't think there's much harm in having these artifacts available as well. And, for jammy/bullseye/bookworm I think it'll be some time before we have anything in apt, so having the artifacts available seems nice.


question: how to get go code from .aar file

Dear team,
I have built .aar file from gomobile by command such as = ... gomobile bind -x -v -target=android successfully, thanks for this great tool ...
Then i wanna update my .aar / Go code. Unfortunately, i miss the source code file.
I have tried to decompile the file by extract .aar and decompiled file classes.jar via jd-gui but i only got unnecessary java file which not my real Go code.

Thanks.

If by "miss the source code file" you meant that you lost it then unfortunately you can't get it back. Your code is compiled and packed into somethinglib.so file which is a shared object file. At best you can get back the assembly code by using some disassembler. What you see here is the JNI binding, some of it generated for GO and the rest for your code.

A better place to ask this kind of question is golang-nuts. See https://golang.org/wiki/Questions.


cross should use docker --mount instead of docker --volume

docker --mount seems to be the "recommended" way of handling volumes nowadays, cross should use that.

However, according to the docker site, there are no plans to depricate "-v" and there may be many older implentations out there. Perhaps use --mount with a fall-back to -v?

I don't believe this is a good idea, since the main differences seem to be the simplicity and readability of the result, but mount is very verbose. Since we programmatically generate our docker arguments and only bind host directories to container ones (IE, only using bind mounts), extra verbosity doesn't seem to be an advantage here. According to the documentation:

--mount: Consists of multiple key-value pairs, separated by commas and each consisting of a = tuple. The --mount syntax is more verbose than -v or --volume, but the order of the keys is not significant, and the value of the flag is easier to understand.

This doesn't matter, since we're programmatically generating these anyway, and the source and destination directory are quite clear. The focus isn't on the docker command: it's on the Rust we use to generate it. I'm of the opinion that the volume syntax is more readable here.
// Using volume syntax
docker.args(&[
    "--volume",
    &format!("{}:{}:ro", host_root.display(), mount_root.display()),
]);
// Using mount syntax
docker.args(&[
    "--mount",
    &format!("type=bind,source={},target={},readonly", host_root.display(), mount_root.display()),
]);

This would generate the following docker arguments (as examples):
# Using volume syntax
--volume "$(host_root)":"$(mount_root)":ro
# Using mount syntax
--mount type=bind,source="$(host_root)",target="$(mount_root)",readonly

The --mount flag does not support z or Z options for modifying selinux labels.

This is an issue, since we use these labels.
As docker's documentation specifies:

Because the -v and --volume flags have been a part of Docker for a long time, their behavior cannot be changed. This means that there is one behavior that is different between -v and --mount

So there are no plans to remove volume, and it supports the features we want.


AI pathfinding out of bounds

The choose_random_location() function in enemy AI sometimes goes out of bounds of the map

Added a potential fix to goblin_rock_thrower AI. Clamping the pathfinding to the bounds of the map.


Contrib-dash not working in Microsoft Edge

VideoJS-contrib-dash does not seem to work in Microsoft's new browser Edge. The browser does support Dash, because a stand-alone dash.js player does work in the browser.
When using it with VideoJS through contrib-dash, the player fails. No usefull console-output, just the basic error.
"The video could not be loaded, either because the server or network failed or because the format is not supported."

@Tralapo can you provide an example of the issue? I tried demo in Edge and it worked properly

@patrickkettner You'r re right, that demo does work in Edge. I created two demo's for you:

videojs-contrib-dash: Does not work in Edge for me: http://bit.ly/1HLd1Q7

dash.js only: does work in Edge for me: http://bit.ly/1KlphIT

@patrickkettner @forbesjo Where you able to take a look at the demo's I created?

@Tralapo your video does work if I load it into your player with src(). I haven't yet looked into why the error is occurring but that can be a possible workaround.

@forbesjo How would that work? Can't seem to find the right way of doing so in the docs. And does that work when having >5 players on one page?
Problem would also be solved if we could find a solution for #10 by the way.

@imbcmdth and I discovered that Edge has native Dash support which causes video.js to use the native source handler and not the Dash source handler registered by this plugin. In my previous comment I set the player source with
videojs.players.CamTest.src('https://stream.bobkoetsier.nl/live/havenkom.stream/manifest_mvtime.mpd')

The native source handler cannot handle that type of source input so the player then uses the Dash source handler.

@forbesjo I don't know what I do wrong, but if I apply that code the player won't load at all.

Here is a jsbin of what I'm doing http://jsbin.com/tewinevahe/1/edit?html,output

@forbesjo Thanks, that one works indeed. But as soon as I add multiple sources, it fails again.
I need three sources, because I want the stream to be supported on all platforms and browsers. On Android I need HLS, because at least my devices do not seem to play dash. Firefox won't play HLS and/or Dash, so that one needs RTMP with Flash.
It works in Edge if I put HLS first and Dash second, but that brings me back to my problem in #10, so that's not ideal either. If you put Dash first and HLS second, Edge goes bad.
player.ready(function() {
	player.src([
  { type: "application/dash+xml", src: "https://stream.bobkoetsier.nl/live/havenkom.stream/manifest_mvtime.mpd" },
  { type: "application/x-mpegurl", src: "https://stream.bobkoetsier.nl/live/havenkom.stream/playlist.m3u8" },
  { type: "rtmp/mp4", src: "rtmps://stream.bobkoetsier.nl/live/havenkom.stream" }
]);
});

The array of sources doesn't all need to be the same type, see this example http://jsbin.com/noxanerewu/edit?html,output

@forbesjo That solution doesn't work. Dash won't be selected at all. Edge chooses HLS and Chrome falls back to RTMP with Flash. I would like to move away from Flash, the reason I look at Dash.

@Tralapo I have a simple change that should give videojs-contrib-dash priority over any native support in #16
Should be landing in master soon. It would be great if you could test it and make sure it fixes the issue you are seeing.

@imbcmdth Works, thanks!


⚠ Bofrost.fr has degraded performance

In 01d59b2, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1741 ms

Resolved: Bofrost.fr performance has improved in 808710c after 13 minutes.


Make component CSP safe

Feature request
Overview
As discovered in https://github.com/mantinedev/mantine/issues/3597 @radix-ui/react-scroll-area currently can't be used in a CSP enabled environment without setting style-src: unsafe-inline.
By being able to configure a nonce or getting rid of the inline styles this scenario would be possible.
Implementation idea
Provide a property to specify a nonce. This nonce then gets passed to the style tag.
Who does this impact? Who is this for?
This is relevant for applications in CSP enabled environments that use strict rules to enhance security.
Additional context
Inline styles are set here:
https://github.com/radix-ui/primitives/blob/main/packages/react/scroll-area/src/ScrollArea.tsx#L152

I'm also seeing this not just for <style> tags but for inline styles on an element. for example:
<div style="--radix-popover-content-transform-origin: var(--radix-popper-transform-origin); --radix-popover-content-available-width: var(--radix-popper-available-width); --radix-popover-content-available-height: var(--radix-popper-available-height); --radix-popover-trigger-width: var(--radix-popper-anchor-width); --radix-popover-trigger-height: var(--radix-popper-anchor-height);">
 ...
</div>

I'm not sure if a nonce would help in this case, but can some of this be moved to a proper stylesheet instead of inline? Or if something needs to be added in javascript (not in SSR) could the JS API be used instead? So instead of using React to set the style attribute, you could instead use something like ref.current.style["--radix-popper-available-width"] = "300px".


tsh login UX vs tele login

A few observations I shared on slack around tsh login vs tele login when testing out the deltas on a 6.3 in prep for tele login being deprecated and soon removed.

tsh login can "login" to a cluster that does not exist:

tele-login kqa stable2
> Profile URL:  https://opscenter.example.com:443
  Logged in as<EMAIL_ADDRESS>  Cluster:      opscenterexample.com
  Roles:        @teleadmin, admin, edit*
  Logins:       bob
  Valid until:  2020-05-15 23:39:16 -0700 PDT [valid for 11h58m0s]
  Extensions:   permit-port-forwarding, permit-pty
* RBAC is only available in Teleport Enterprise
  https://gravitational.com/teleport/docs/enterprise

stable2 is not a real cluster; this will in fact log me into hub (opscenter); Given the lack of info of cluster not-existing and the fact it logs you into the hub it is possible to do bad things by accident on the wrong cluster.
tele login had a similar regression recently that got fixed in https://github.com/gravitational/gravity/pull/1500

tsh login does not tell me which cluster I have logged into; it instead shows the --proxy as the Cluster

tele-login kqa stable4
> Profile URL:  https://opscenter.example.com:443
  Logged in as<EMAIL_ADDRESS>  Cluster:      opscenter.example.com
  Roles:        @teleadmin, admin, edit*
  Logins:       bob
  Valid until:  2020-05-15 23:39:16 -0700 PDT [valid for 11h52m0s]
  Extensions:   permit-port-forwarding, permit-pty

* RBAC is only available in Teleport Enterprise
  https://gravitational.com/teleport/docs/enterprise

Here the Profile URL and Cluster are that of --proxy (hub) but no mention of stable4 which is the real destination.

The "RBAC only available in Teleport Enterprise" seems like it shouldn't display if you have Gravity Enterprise (and thus Teleport Enterprise). This is more a stylistic thing but feels like it should be a bit more aware if it has RBAC available, or not.

I am also running into a situation where if I do tele logout (or tsh logout) and then use tsh login
👻  tsh-login kstg stable4
error: Get https://opscenter.example.com:3080/v1/webapi/ping/Keycloak: dial tcp <IP_ADDRESS>:3080: i/o timeout

^ just wraps tsh login with --proxy, --auth (Keycloak) and all that.
A normal tele login works against the same host, and then if I do tsh login it picks up the cert from tele login
Is there something I can do to test if tsh login is broken for me or just not working against a 6.3.17 cluster?


Constructor changes-- to compare to PR #389

@tejasbubane looks like the issue with the build in #389 is around some of the exercises having arrow functions where they should have constructors.  Why this is now a problem, but wasn't before, is a mystery to me.
This PR is purely to demonstrate a fix for #389.  Please make changes in #389 and we can delete this branch after.
@exercism/ecmascripts if anybody has any insight into why code that was previously passing linting and testing is now failing, please explain!  I'm guessing it's a change in some underlying dependency, but I don't see what.

@tejasbubane @tarunvelli I've just made an additional commit to the PR to determine if using npm install --no-save would work, an it sppears that it works as expected-- it does not alter the main package.json, so everything works as expected.
I'm going to open a separate issue to discuss if this change makes sense.

Also can you change the PR title to reflect the changes? (since there are no constructor changes now I guess).


Fix division by zeros

For the pyinstaller bundle this will result in a program crash.
@marty-pmr, @slacrherbst, @bungernut    Can division by zero handled by setting rates to zero or the display show Nan or blank?

More context would be good, permalink line?
I would say any of your options is fine

https://github.com/slaclab/pabv_control/blob/f4e3325ee95e67712d412a8e6a295fc070bb6c22/python_client/ambu_control.py#L53
This one already fixed:
https://github.com/slaclab/pabv_control/blob/f4e3325ee95e67712d412a8e6a295fc070bb6c22/python_client/ambu_control.py#L184
I think there is not much else left at first glance.

Fixed, pulled into devel branch.


Search is not so good

Search result does not seem to be useful even if I give full details of the movie title.
> ap imdb.search_for_title('back to the future 1985', limit: 2)
[
    [0] {
                :type => "title_approx",
             :imdb_id => "tt5124786",
               :title => "Back to the 2015 Future",
        :release_year => "2015"
    },
    [1] {
                :type => "title_approx",
             :imdb_id => "tt1841512",
               :title => "Back to the Future: The Game - Episode 5, Outatime",
        :release_year => "2011"
    }

Have you tried limitting results to popular titles with types: %w(title_popular)?


[Feature] Comma thousand numeral formatting

Cleave has a great internalization in telephone numbers. However, we don't have this internalization in numbers.
My suggestion is a new Numeral formatting style: Comma thousand.
It will act just as thousand style, but the commas are periods and the periods are commas. Some countries use this number format, like Brazil.
For example:
thousand: US$ 1,000,000.00
comma:      R$ 1.000.000,00

The formatting with "." as the thousands separator and "," as the decimal marker is indeed common outside of the US, however such formatting is already supported by using this combination of options:
numeral: true, numeralDecimalMark: ',', delimiter: '.'
This was found in the documentation for numeralDecimalMark. Having a single option to condense that is probably not impossible, but it doesn't seem necessary to me.

This is exactly what I needed. Thank you.

If anyone is looking for an easy way to map from locale to what CleaveJS neads, I think this code will be helpful:
export const localeToParts = (locale: string) => {
  const anExampleNumber = 111222333.456;
  return Intl.NumberFormat(locale)
    .formatToParts(anExampleNumber)
    .reduce(
      (prev, curr, index) => {
        if (curr.type === "decimal") {
          prev.numeralDecimalMark = curr.value;
        }
        if (curr.type === "group") {
          prev.delimiter = curr.value;
        }
        return prev;
      },
      { numeralDecimalMark: ".", delimiter: "," }
    );
};

But at the moment I'm using react-aria's number masking since I think it's a better experience and provides built-in locale support. I'm not sure if the code above or my decision is final though.

The formatting with "." as the thousands separator and "," as the decimal marker is indeed common outside of the US, however such formatting is already supported by using this combination of options:
numeral: true, numeralDecimalMark: ',', delimiter: '.'
This was found in the documentation for numeralDecimalMark. Having a single option to condense that is probably not impossible, but it doesn't seem necessary to me.

Big Thanks, Mate


Bump rdf-dataset-fragmenter version

This is just a small change to bump the rdf-dataset-fragmenter version. This needs to be updated after the fix the the bloem types issue is released, because this will not build before it. That was my fault. :grimacing:

Now this finally works! Thank you for being so quick with the releases. :partying_face:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
116

Relevant Lines:
116

💛  - Coveralls


Feature: Add new msbuild tasks to common.targets that supports terraform

Acceptance Criteria:
Terraform offers a great tool for building Infrastrure as code. To simplify local development, common command which are used for testing terraform are needed.  These commands are added to the common.targets.

Add init, plan and apply commands
Establish common folder for terraform files
Add support for terraform azure provider A simple command to build docker image and deploy to azure instance

resolved in #68


[SMALLFIX] Remove duplicate function call

What changes are proposed in this pull request?
Remove duplicate getPort() call.
Why are the changes needed?
The result of getPort() has been recorded and can be used directly
without calling this function again.
Does this PR introduce any user facing changes?
No.

Close and reopen to trigger new test actions

alluxio-bot, merge this please


CSS stylesheet missing

Hi,
I am using this framework for my new react application. After implication, I can see there is no stylesheet, I checked that even no inline styles are rendering. But downloading the stylesheet from the UK Govt releases, and works for me.
But I'm facing some other issue for which I am raising this. It's for accordions.
The accordion header Hide and Show actions are missing in the react component. Is there any chance to append it or do I've to create a
separate component for it?
Appreciate any thought.

@DonAmit197 can you explain this bit further please? What do you mean by hide/show actions?
There is a prop for open which will hide and show as per example:
https://govuk-react.github.io/govuk-react/?path=/story/details--default&args=open:true

Hi @rottitime
Thanks for your reply.
If you see this Govt UK Accordion style guide you will see that it is missing in your application.
Somehow, I had to do some custom coding to make it work.


Get rid of harmonise and adjoint_test

All the functionality has been now moved to ChainRulesTestUtils and should be used there.
This includes:

[ ] Using ChainRulesTestUtils.rand_tangent rather than FiniteDifferences.rand_tangent
[ ] Deprecate harmonise
[ ] Deprecate adjoint_test

Resolved by #129


account value displayed wrong in MoneyMoney(*100)

Hello.
My 97€ account value is displayed as 9.700€ in MoneyMoney. I wish microinvesting would yield such huge returns after one day, yet I suspect I should not spend this money yet :)
I tried different decimal/thousand separators, which are taking effect when displaying https://www.bondora.com/de/dashboard/overviewnumbers/ in the browser, but it doesn't solve the problem.
Any help would be appreciated. Screenshots for illustration.
Regards,
skdnp

Hi @EmDee ,
Bondora gibt den Wert des Kontos mit 4 Stellen hinterm Komma aus. Bei mir ist der gleiche Faktor übertragen.

Sorry this took so long, haven't had the time to check this out. Looks like Bondora is not returning the value in cents anymore, but Euro decimals. Will try to get a new version up today.


Petition - Update error copy on SIWE

--> "Sign-in failed. Make sure you've set your Network to Ethereum."

Done in https://github.com/tallycash/tally.cash/commit/7ec73a5bf1fc59a8f9ab1ffd677c2916ef0dbdca


could not load api

also 2x same url;s

Originally the api console worked more or less fine using the features/new-raml branch of the api-console. After adding the oauth security schemes these resources are no longer available. This branch was abandoned by the api-console team in favour of the feature/raml-1.0 branch on which their development continued. In the mean time the raml spec progressed towards 1.0-rc2 which is incompatible with rc1 on a couple of places. The feature/raml-1.0 of api-console is merged in master by now but master is currently broken.
I expected/hoped that the api-console team would have solved the bugs by now.
This leaves us in a quite disastrous situation where the alternatives (like ramlo) are also still in development, missing functionality and still require quite some work from our side to integrate them.
Best option imo is to fix the blocking issues in api-console ourselves and try to get it merged upstream.


Image is not showing after uploading

After dragging the image and after uploading the image is not showing in the image box.

@fsociety-js  Hi,Can you assign this issue to me?

@snehautekar05 Sure


Non-Branch Links are not detected by the plugin

I’ve implemented NonBranchLinkHandler() like below, which is detected into iPhone/iPad but it is not detected into Android phones/tab.  Note: I’m using cordova-ionic-phonegap-branch-deep-linking version: 2.1.6
window.NonBranchLinkHandler = function (data) {
   console.info(data);
   topic.publish('xyz', data);
};

I did not found any exception to show on post!
Community ref → https://mobilegrowth.org/questions/question/non-branch-links-are-not-detected-by-the-plugin/

Hey @suzon - That's strange. I swear I fixed this in the latest release. I will investigate first thing tomorrow.

@suzon - please review the PR I just made!

@aaustin - yes! this fix is working for me. Thank for quick fixing.

@aaustin - yes! this fix is working for me. Thank for quick fixing.

Still not working for me.
the string sent from out = String.format("NonBranchLinkHandler(\"%s\")", message.toString()); has this extra "" around the parameter object compared to the out = String.format("DeepLinkHandler(%s)", referringParams.toString());.
the javascript eval() method in cordova.js which is executing the output from webView.sendJavascript(out); is throwing an "uncaught syntaxerror: missing ) after argument list"
so the string looks like this:

NonBranchLinkHandler("{"error":"Not a Branch link!","url":"myapp://subsite/86"}")

when i change it in runtime to:

NonBranchLinkHandler({"error":"Not a Branch link!","url":"myapp://subsite/86"})

the eval() method doesnt throw an error and NonBranchLinkHandler gets called properly.

Thanks for the catch and suggested fix Malua. I'm merging this fellow in: https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/pull/165


Remove crazy eager loading from show name_description

At some point, Rails was asking for each and every one of these, but NameDescriptions currently take a whole minute to load.
I'm finding that none of them are required now. I don't understand why, but let's go.

coverage: 94.504%. remained the same
when pulling c876e9155a5d564be345a203b18520dc355a5a5d on nimmo-show-name-description-strict-loading
into 7ff0d433e164b5d7d799c46c8f062e3ccc5f7fbe on main.


[RFC] piping all console to a centralized place in development

How do you envision this feature/change to look/work like?
Whenever you click inspect on the Popup window, it should be available all the time. There's no need to open it once again after making small changes in the code and saving it.
Also If there could be a "server tab" opened like in React Native, where all the logs would be visible, this is fine too.
What is the purpose of this change/feature? Why?
Every time I make a small change in the code, the Popup page refreshes and the console window closes.
It's hard to debug anything this way.
(OPTIONAL) Example implementations
No response
(OPTIONAL) Contact Details
<EMAIL_ADDRESS>Verify canary release

[X] I verified that the issue exists in plasmo canary release

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

I think piping the log back to either the watcher console or into a page like expo would be nice.
I wonder if the reloading is caused due to our popup.js generates a new hash (?) or due to the chrome runtime reload we're using to do hot reload (?)...
Piping console is likely most long-term solution tho

The piping is possible by introducing a middle-man runtime at the parcel runtime level, replacing all console log within the bundle code with a call to the internal websocket server. That should definitely work - once the console piping is done, then it should be trivial to deal with the log data either on a dashboard or just throw it on the main terminal runner for now, maybe behind a flag.

As long as I can read the logs they can be shown anywhere. The best would be to have it in the console, but the terminal is fine too.
@louisgv And I think the answer to your question is yes. I think that reloading is caused to generating a new hash every time.

As long as I can read the logs they can be shown anywhere. The best would be to have it in the console, but the terminal is fine too.
@louisgv And I think the answer to your question is yes. I think that reloading is caused to generating a new hash every time.

Yeah the main problem with using the console is that it is controlled by chrome process. I think this is the key reason why Expo piped all their log and show it with their own console UI, unlike Cordova/Phonegap where they relied on the chrome remote console, which would lose information the moment they disconnect xD


JSFiddles linked from CartoDB docu don't show anything

Hi,
I was trying to show some colleagues how to use CartoDB.js with the JSFiddle examples I used some time ago to learn, and they don't seem to work anymore. This is the doc site that links to them, and this is the list of links that once showed some data, but don't anymore:

http://jsfiddle.net/gh/get/library/pure/CartoDB/academy/tree/master/t/03-cartodbjs-ground-up/lesson-2/jsfiddle_demo_ondone
http://jsfiddle.net/gh/get/library/pure/CartoDB/academy/tree/master/t/03-cartodbjs-ground-up/lesson-2/jsfiddle_demo_multilayer

Maybe something on the documentation user has changed. The vis.json looks OK to me, but nothing is being plotted.
Cheers,
Raquel

Hi Rachel!
First of all, thanks for your feedback. Let me move this discussion to the correct repository, ok?
https://github.com/CartoDB/docs/issues/384
Cheers!


Support azure primitive types

Fixes #45948
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

@weshaggard could you have a review on this PR as well? I have to introduce something in the ci jobs to run the unit tests of our new generator, during which I borrowed some of the scripts from the generator project of csharp in typespec repo, and I am not sure if I am doing this correctly.


[Feature] Median Cut Algorithm

Couple of things to do:

We want this algorithm to work with current API
Remove erroneous behaviour and have more tests
Look for speed and memory improvements
Write its GPU version (Could be done in later PR but let's see

Sounds great. If we notice the package needs some API changes along the way, that's totally ok, we're still in 0.1.0.


Update package.json

PR adding possibility to use this package with react-native-svg >=14.0.0

cc @awesomejerry could we get this merged and released? Or is there something I am missing about the support?

@awesomejerry  please make this guy the maintainer.


Question - Can roles/perms can be inherited ?

Say if there are 2 users one with READ and another with WRITE permission. Then can the user with WRITE permission READ the given resource/document also?
In addition to that, the secure-todo example is sharing items to another user hence giving the access to it.
Can't we assign the same permissions to a new user with which an existing user created a resource and this new user can directly access this given the fact that both the users have same permissions? Is this possible.

Hi Yagnesh,
I answered this on your cross-post in the OACC user group here: https://groups.google.com/g/oacc-users/c/llIYSOTxy9o
Thanks,
Adi


IncludeFilter > Take() not translated in SQL query

Using .NET Core 2.x (and Z.EntityFramework.Plus.EFCore version 2.0.50).
I noticed that IncludeFilter got very slow on our production. We try limiting the include by adding a Take()-statement, but that doesn't seem to get translated into SQL. So I assume that all the records are transferred to memory and only there the Take() gets executed.
Code:
using (var db = new SomeDbContext())
            {
                var classA = db.ClassAs.
                     IncludeFilter(x => x.ClassBs.Where(y => y.SomeProp < (int.MaxValue - 1000)).OrderBy(y => y.Id).Take(5))
                     .Single();
            }

SQL:
-- EF+ Query Future: 1 of 2
SELECT TOP(2) [c].[Id], [c].[SomeProp]
FROM [ClassAs] AS [c]
;

-- EF+ Query Future: 2 of 2
SELECT [x].[Id], [x].[SomeProp], [x.ClassBs].[Id], [x.ClassBs].[ClassAId], [x.ClassBs].[SomeProp]
FROM [ClassAs] AS [x]
LEFT JOIN [ClassBs] AS [x.ClassBs] ON [x].[Id] = [x.ClassBs].[ClassAId]
ORDER BY [x].[Id]
;

A full program is available here:
https://github.com/janmarques/efplus-failing-take/tree/master/ConsoleApp3
Note that the above DOES work as expected in .NET Core 3 with the corresponding nuget package (Take gets included in SQL), but we cannot currently port our production yet.

Hello @janmarques ,
Unfortunately, you are currently experiencing an issue with the Client Side evaluation in EF Core 2 (which has been removed in EF Core 3).
The "Take" is done on the client side, so no SQL was generating by EF Core. Therefore, our library don't see it either.
There is currently nothing we can do, as you stated this issue is solved in EF Core 3 since it do not longer do any more client-side evaluation.
Best Regards,
Jon

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Hi Jonathan
ok thanks for having a look and clarifying where the issue lays.
-Jan


Minimise existing presence.

The existing TumblThree repository should direct users here. Updating the Readme, closing the issues, and making it obvious in the releases that this is the new home of TumblThree will help reduce discontinuity and confusion in the future.

The issue has been fixed and closed.


Git job not working

Whenever I try to use git job the following gits outputted
$ git job
git: 'job' is not a git command. See 'git --help'.

Did you mean this?
        log

Should return an actual job from a job listing service

That should probably be documented somewhere. Does it throw the normal git error if no job is found?

@Wolvan I think @jaimelive was making a joke, nothing about getting an actual job listing is in the code.
@fsufitch git spooked, git job, and git money do not work. They return actual git errors still

Looks like the new methods are pulled down with pip...

A work around:
pip uninstall gitgud
pip install git+https://github.com/fsufitch/git-gud.git
This will install from master

@Wolvan @jankcat Definitely a joke, my bad

@jankcat @jaimelive try gitgud2

It has currently no improvements, but I'll do many changes and eventually port it to C/C++ soon


12th January 2023 - Waltz Project Meeting

Date
Thursday 12th January 2023 - 10am ET / 3pm UK
Occurs the second Thursday of every month
Untracked attendees

Name
Firm
Comment

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene, roll call, welcome new people (5mins)
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
[ ] Approve previous meeting minutes - https://github.com/finos/waltz/issues?q=is%3Aissue+is%3Aclosed+label%3Ameeting
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] ...

Action Items

[ ] ...

WebEx info
Webex:
https://finos.webex.com/finos/j.php?MTID=m00a97bac66d1324e1ca89b9bb4eb37c6
Dial-in

US +1-415-655-0003 US Toll
UK +44-20319-88141 UK Toll
Access code: 2554 479 5248

Github Repo: https://github.com/finos/waltz/
Project Microsite: https://waltz.finos.org

Hello!

Hello!

Hello

https://github.com/finos/waltz/tree/master/docs/features


Missing methods in Quarkus Native

When compile to Quarkus Native. Bucket delete in reactive shows method not found
After looking at the reflection output of the build, found certain methods to be missing.
Tested these configurations to be working with Bucket Delete

please correct all checks

Thanks for contribution!


Access is denied on psexec as admin.

How can you get Access is denied on a SYSTEM level execution?
I wish for a fix.
Thank you for your effort making this script!!!!!
Output:
Backup of existing permissions...
Successfully processed 0 files; Failed processing 8 files
Saved to C:\Program Files\WindowsApps_20211201_121131.txt
Fixing WindowsApps permissions...
[RED TEXT]
.
.
.
Get-ChildItem : Could not find a part of the path 'C:\Program
Files\WindowsApps\SUPERHOTTeam.533673F36228B_<IP_ADDRESS>_x64__hj98apedv0ctt'.
At C:\Utilities\WindowsAppsUnfukker-main\WindowsAppsUnfukker.ps1:110 char:18

... pxFolders = Get-ChildItem $WinAppsPath -Filter 'AppxMetadata' -Depth  ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ReadError: (C:\Program File...__hj98apedv0ctt:String) [Get-ChildItem], DirectoryNotFound
Exception
FullyQualifiedErrorId : DirIOError,Microsoft.PowerShell.Commands.GetChildItemCommand

[end of RED TEXT]
Fixing WindowsApps subfolders inheritance...
Successfully processed 270 files; Failed processing 1 files
Fixing WindowsApps subfolders permissions...
Fixing AppData Packages permissions, this could take a couple minutes...
C:\Users\Cohen\AppData\Local\Packages: Access is denied.
C:\Users\Cohen\AppData\Local\Packages*: Access is denied.
Successfully processed 0 files; Failed processing 2 files
C:\Users\Cohen\AppData\Local\Packages: Access is denied.
Successfully processed 0 files; Failed processing 1 files

Huh, that's weird... I think I know what's wrong for Superhot, but I'm confused about the AppData errors. Can you provide a screenshot of the Security > Advanced panel for C:\Users\Cohen\AppData\Local\Packages?

It is owned by my user and only my user is listed in the permissions list as "full access"

Normally, the Packages folder is supposed to inherit SYSTEM Full control from C:\Users\Username, you must have fukked it beyond what the script can handle 😂

well I get “Failed to Enumerate Objects in the Container. Access is denied.” when trying to apply the root user security values to the subfolders.
same as when I try to change the security settings on the WindowsApps
FFS how can my access be denied if I'm the damn Admin???? Linux will self destruct if I tell it so with admin privileges.
Going to safe mode to try and fix it from there.

Maybe try running the script without psexec? (remove the SYSTEM user verification from the script)

Going to safe mode to try and fix it from there. doing this fixed the issue without having to run the unfukker.
Apparently if SYSTEM (and administrators) don't have access to appdata/packages it is bad.
So I appllied the appdata security settings to all the subfolders and it fixed the "windows can't access path or device" (just like it is on the new account I made).

OMG thank you! I clicked "Enable Inheritance" for "C:\Users\username\AppData\Local\Packages" which added the SYSTEM permissions automatically then re-ran the unfukker script. Everything finally works and the script didn't have any errors. Finally my windows store apps can start more than once without breaking.


Use datatime conversion provided by Azure::Core for x-ms-date HTTP header

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[x] C++ Guidelines
[x] Doxygen docs
[x] Unit tests
[x] No unwanted commits/changes
[x] Descriptive title/description

[x] PR is single purpose
[x] Related issue listed

[x] Comments in source
[x] No typos
[x] Update changelog
[x] Not work-in-progress
[x] External references or docs updated
[x] Self review of PR done
[x] Any breaking changes?

/azp run cpp - storage

/azp run cpp - storage

/azp run cpp - storage

/azp run cpp - storage


Enhancement:  Option to Skip Countdown before song

An option to skip the 3, 2, 1, go before a song would be nice because sometimes you just wanna get to playing and not have to wait for anything.

kinda added this in my engine, but it's buggy on some songs tht start immediately

this would basically completely break any song that starts immediately


Login Problem

Hello,
I've tried 1.3.2 and 1.3.3 x64 & 32bit  windows versions but i had a problem with login.
It keeps reopening new login screens after i enter my credentials. Looks like an infinite loop.

do you have 2FA? (two-factor authentication) if so, that's still in the works. try logging in with an app password though.

@trgcyln can you give more information?
if the problem persists try removing yakyak config directory at %APPDATA%
that seems to be the only solution so far

@trgcyln if you are still experiencing this problem in 1.4.1 or up, please reopen this issue


[fullscreen ad] why check AppLifecycleState for Interstitial, AppStateEventNotifier.appStateStream for "App Open"?

AppLifecycleState
https://api.flutter.dev/flutter/dart-ui/AppLifecycleState.html
AppStateEventNotifier
https://pub.dev/documentation/google_mobile_ads/latest/google_mobile_ads/AppStateEventNotifier-class.html
otherwise may throw AdError code 3, message the ad can not be shown when app is not in foreground
but AppStateEventNotifier events are very not active (rare) compared with AppLifecycleState events?
thanks
updated
provide message for the ad error code 3
Interstitial
Interstitials that show when your app is in the background are a violation of AdMob policies and may lead to blocked ad serving. To learn more, visit  https://googlemobileadssdk.page.link/admob-interstitial-policies
App Open
The ad can not be shown when app is not in foreground.

Hi @peterweb2005
Can you please share the detailed steps to reproduce along with a minimal sample code to replicate for Interstitial and App Open cases? (You can use sample code from this plugin and modify it if needed on your forked project and then share it here).
Please provide the entire error stack trace as well. Thank you!

this only means that if I mismatched event for fullscreen ads, eg AppLifecycleState  event for App Open Ads,, but not AppStateEventNotifier.appStateStream events
that would easily lead fullscreen ad not showing in foreground error,
and moreover, AppStateEventNotifier.appStateStream still inaccurate for App Open Ads, which I opened another issue

Hi @peterweb2005
I would suggest you provide clear Steps to reproduce and a minimal sample code along with it so that we can verify the issue properly.

just your sample, app open ad,
and crash report the show error, it happens often
thanks

Can you share the steps to reproduce the issue? I check this with app_open_example but the ad can display well:

Demo
https://github.com/googleads/googleads-mobile-flutter/assets/104349824/0c464ff2-01c0-44e4-8841-966d168ea157

yes
but if you had a published app, and use the sample code for app open ads, and crash log the show error,
      onAdFailedToShowFullScreenContent: (ad, error) {

the crashlytics would tell
for example,
it had about 26 events of "AdError code 3, message the ad can not be shown when app is not in foreground",
in just few days

Thanks for your response. It looks like _appOpenAd!.show() or _interstitialAd!.show() is called when app is in the background.
This could be related to your implementation, please see https://github.com/googleads/googleads-mobile-android-examples/issues/145 and please confirm you also didn't trigger ad to show from background. Btw, can you share places where you are showing ad in your app?

yes, please, as i mentioned many times,
all logics are from the example:

on app init event, register AppLifecycleReactor

  @override
  void initState() {
    super.initState();
    AppOpenAdManager appOpenAdManager = AppOpenAdManager()..loadAd();
    _appLifecycleReactor =
        AppLifecycleReactor(appOpenAdManager: appOpenAdManager);
    _appLifecycleReactor.listenToAppStateChanges();
  }

on AppLifecycleReactor foreground event, call showAdIfAvailable()

  void listenToAppStateChanges() {
    AppStateEventNotifier.startListening();
    AppStateEventNotifier.appStateStream
        .forEach((state) => _onAppStateChanged(state));
  }

  void _onAppStateChanged(AppState appState) {
    print('New AppState state: $appState');
    if (appState == AppState.foreground) {
      appOpenAdManager.showAdIfAvailable();
    }
  }

Thanks for your response. Looks like it's only reproducible in production, I will label the issue for the investigation.

all I can tell is that it is not only in production,
but I don't want to continue

summary,
2 problems much decline the revenue:

AppStateEventNotifier foreground event fewer happens than AppLifecycleState resume event
even if have AppStateEventNotifier foreground event, show() call would throw error "AdError code 3, message the ad can not be shown when app is not in foreground"

I ran into exactly the same issue (or bug). If I sleep for 80ms before calling showAdIfAvailable, it always works. I found around 20ms is the threshold on my phone (SM-G937U1). Here is my "workaround":  public void onStart(@NonNull LifecycleOwner owner) {
DefaultLifecycleObserver.super.onStart(owner);
// Show the ad (if available) when the app moves to foreground.
try {
Thread.sleep(80);
} catch (Exception e) {
}
appOpenAdManager.showAdIfAvailable(currentActivity);
}

@wujieliulan
thanks
I currently trying visibility detector,  which the plugin depends, there has a important updateIntevral variable
is that because?

May I ask how you detect visibility?

May I ask how you detect visibility?

https://pub.dev/packages/visibility_detector

Hello, I would like to get a more detailed explanation on how to reproduce this problem since my attempts to get the same error message were unsuccessful.
If I understand correctly, this happens even in the app_open_example project on both production and debug versions. Also, I understand that it happens sometimes but what I don't understand is the exact steps you follow to get the error.
What I did:

Open app open example app.
Minimize it and quickly bring it back to the foreground (I sometimes did fast enough that it didn't trigger the ad).
Also tried doing it at a normal pace but I never got the error.

My result was that, when it detected going to background and then foreground, it always showed the open ad with no error message at all.
I tried to reproduce on a physical device as well as on Android emulators with similar results.

it is hardly to reproduce the error when just 1 user, or developer
But if one has a production project, and just copy the example, full stuffs (on lifecycle events, register, showIfAvailible()),
maybe the app has hundred active users, the crash log count can be 1/10 of user count, in 1 week
don't forget, add the line to report error inside onAdFailedToShowFullScreenContent, if error code is 3
Thanks

Thanks @peterweb2005 . I found out that locking and unlocking the phone while the app is in the foreground is the most reliable way to reproduce this error message. I also found that the issue comes from the native Android format (don't know about iOS) and have triaged to look into the problem.

Actually Google had a new release on last week, they seemed to fix it, it doesn't happen to me, which is good, I don't need the work around anymore. The new version is com.google.android.gms:play-services-ads:22.4.0

@wujieliulan Thanks for that.
@peterweb2005 can you confirm that upgrading the Android SDK to com.google.android.gms:play-services-ads:22.4.0 resolves your issue?

@peterweb2005 For the sake of experiment, if the api of the Android GMA SDK is set to com.google.android.gms:play-services-ads:22.0.0 please try changing to com.google.android.gms:play-services-ads:22.4.0. This will also require a kotlin version change.
In doing so, are you still able to reproduce the issue?

@malandr2
seems @LTPhantom know how to reproduce much effective
thanks 🙏

Got it, thanks.

seems still happen, but dont know if the rate lower

isnt it obvious?
when showing interstitial, after wait on resumed, no error code 3
why when showing app opened ad, after on foreground, but not wait on resumed?
if it do so, there should be no error code 3?

is it ok?? check both app state AppLifecycleState.resumed & AppStateEventNotifier's AppState.foreground
  static const interval = Duration(milliseconds: 50);
  static const maxInterval = Duration(milliseconds: 250);
  StreamSubscription<int>? appResumedSubscription;

  pause() {
    log.finer('pause()');
    appResumedSubscription?.cancel();
    appResumedSubscription = null;
  }

  resume({required AdAppState adAppState}) async {
    log.finer('resume()');
    log.finest('userAccepted: ', userAccepted);
    if (userAccepted) {
      log.finest('adAppState: ', adAppState);
      switch (adAppState) {
        case AdAppState.app:
          // page ad..
        case AdAppState.admob:
          // if page ad end
          if (ref.read(adProvider.notifier).pageAdEnded == true) {
            log.finest('isAppResumed: ', isAppResumed);
            if (isAppResumed) {
              appOpenAdHandler.resume();
            } else {
              appResumedSubscription ??= RxUtil.interval(
                initialDelay: interval,
                period: interval,
              ).listen(
                (int i) {
                  log.finer('onData()');
                  //log.finest('i: ', i);
                  final time = interval * (i + 1);
                  log.finest('time: ', time);
                  if (isAppResumed || time >= maxInterval) {
                    //
                    if (foreground) {
                      log.finest('call resume, time: ', time);
                      debugShow('call resume, time: $time');
                      appOpenAdHandler.resume();
                    }

                    appResumedSubscription?.cancel();
                    appResumedSubscription = null;
                  }
                },
                onError: (e) {
                  throw e;
                },
                //cancelOnError: true,
              );
            }
          }
        default:
      }
    }
  }

WARNING
the above approach is good, much lower error rate,
but google can ban account
it is just admob foreground event (which happen earlier) wait for flutter resumed event,
delay for 0.1 to 0.15 second

Following up on this, the issue was fixed in #843, which updated androidx.lifecycle:lifecycle-process dependency from 2.2.0 to the latest stable version of 2.6.2. This fix will be out in the next release.
Closing the issue.

nothing changed

stat update, error rating updated from 5.8% to 9.5%

See https://github.com/googleads/googleads-mobile-flutter/issues/1029#issuecomment-2008350027 for any insight, the fix applied there may be applicable for others.

See #1029 (comment) for any insight, the fix applied there may be applicable for others.

NO that 2 flags, thanks

Error continues: https://github.com/googleads/googleads-mobile-flutter/issues/1196

I have solved this issue by putting some delay between when the app comes to the foreground and call showAppOpen function

I have solved this issue by putting some delay between when the app comes to the foreground and call showAppOpen function

await canRequestAds, i thought it legal


Estimated Time Frame For  (Bridge) Transaction on website

Describe the feature request
Transactions should be for a given time period. And the problem is that there is no estimated time frame for bridge transaction . Feature such as an estimated time frame for transactions on the taiko website  be it for native bridge should entail the amount of time that a transaction will take, which can be identified and used by users. Primary or immediate time frames are actionable right now and are of interest to day-users and high-frequency users. Below is a pictorial instance.

Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

Describe the feature request
Transactions should be for a given time period. And the problem is that there is no estimated time frame for bridge transaction . Feature such as an estimated time frame for transactions on the taiko website  be it for native bridge should entail the amount of time that a transaction will take, which can be identified and used by users. Primary or immediate time frames are actionable right now and are of interest to day-users and high-frequency users. Below is a pictorial instance.

Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

Describe the feature request
Transactions should be for a given time period. And the problem is that there is no estimated time frame for bridge transaction . Feature such as an estimated time frame for transactions on the taiko website  be it for native bridge should entail the amount of time that a transaction will take, which can be identified and used by users. Primary or immediate time frames are actionable right now and are of interest to day-users and high-frequency users. Below is a pictorial instance.

Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

@Viktor110 @Vtalike reported for spam. Enjoy your account bans. 🫡


various improvements around metric param and early_stopping_rounds param description

consistent and more clear (in part of "all of them except the training data") description of early_stopping_rounds parameter;
added alias lambdarank for ndcg metric to fix the expected behavior "(empty string or not specified) means that metric corresponding to specified objective will be used", which was broken for lambdarank objective;
added "na" alias to custom objective for consistency with description and code here;
it turned out that ReadTheDocs didn't show all members in Scikit-learn API section, :inherited-members: option fixes this;
added default metric to the evaluation list in case of string (built-in) feval parameter in sklearn wrapper to match the description: "In either case, the metric from the model parameters will be evaluated and used as well." (refer to https://github.com/Microsoft/LightGBM/pull/1505#issuecomment-404472494)

ping @guolinke for metric part;
ping @henry0312 for python and docstrings part;
ping @Laurae2 for R part

@guolinke While we're waiting @henry0312 with his use-case, are you OK with this PR?

LGTM


Python 3 fixes

Relates to issue #1 (Python 3 support)
Made setup.py work with Python 3 (convert binary to text).
In Python 3 the SCSS source code must be decoded from binary to text before processing. The latest compressor passes a charset argument to our filter, which will be used. If not passed, it will default to utf-8.
Note that Python 3 support currently depends on the latest (master) compressor and a pyScss with this fix incorporated (pull request submitted): https://github.com/wojas/pyScss/commit/e4cf419509f3c568c108c3196e2fda50bcc37536
NOTE: Tests related to the sprites fail for me, both on python 2.7 and 3.4. The hash is different from what's expected.

fixed with #31!
Thanks for getting this started @wojas


No "tie-button-red" CSS class exists in LearnerViewDirective.

Fixing shortly, but that's why the privacy modal looks weird on some OSs -- there's a default that isn't being caught.

Is this bug still open or was it fixed in #568 ?

Fixed in #568


Fix memory leak in varlen pool

Bring back the logic in GCManager to reclaim varlen pool
Tweek the varlen pool implementation to support Free()

#442

Coverage decreased (-0.003%) to 65.733% when pulling 7475cd2f326cab8cf4d391d3fd78aba1874324e3 on jessesleeping:gc-fix into 00256b8f6369fe6061b75c4b979f1bf954576e57 on cmu-db:master.


Make use of hashing algorithm configurable per SP

EB currently uses SHA1 to sign its SAML assertions. It would be nice to be able to upgrade this hashing algorithm. However, we cannot do a big-bang change so we want the hashing algorithm to use to be configurable per SP in the serviceregistry.

For those looking to configure this globally, that's not possible. There is however one line that determines outgoing signature method in library/EngineBlock/X509/PrivateKey.php:27
Change that to SHA256 and all outgoing responses will be signed 256.

Fixed in EB 5.6.


Sigh couldn't download certificate, got this instead:

I have been assigned to be a member of a team and this is what I get when running sigh in fastlane. I am updated to the latest version of fastlane and spaceship. No solutions for similar threads have helped me. Any ideas?
[17:12:24]: Fetching profiles...
[17:12:30]: Variable Dump:
[17:12:30]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios crashlytics", :CERT_FILE_PATH=>"/Users/qsystems/Documents/Test/R55U24HEB4.cer", :CERT_CERTIFICATE_ID=>"R55U24HEB4"}
[17:12:30]: Couldn't download certificate, got this instead: {"responseId"=>"54b95dd0-a2f8-4f37-bf5a-a72d2eb08388", "resultCode"=>1200, "resultString"=>"webservice.certificate.downloadNotAllowed", "userString"=>"You are not permitted to download this certificate.", "creationTimestamp"=>"2016-07-11T14:12:30Z", "protocolVersion"=>"QH65B2", "userLocale"=>"en_US", "requestUrl"=>"https://developer.apple.com/services-account/QH65B2/account/ios/certificate/downloadCertificateContent.action", "httpCode"=>200}

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | cocoapods                           | 9           |
| 4    | cert                                | 31          |
| 5    | sigh                                | 10          |
+------+-------------------------------------+-------------+

You are not permitted to download this certificate
You don't have the permission to download the given certificate. Make sure you either have admin access or skip the certificate verification using

sigh --skip_certificate_verification

@KrauseFx Thanks! However, now I get this:
Processing Info.plist
invalid character ' ' in Bundle Identifier at column 12. This string must be a uniform type identifier (UTI) that contains only alphanumeric (A-Z,a-z,0-9), hyphen (-), and period (.) characters.
▸ Generating 'Test.app.dSYM'
▸ Running script '[CP] Embed Pods Frameworks'
▸ Running script '[CP] Copy Pods Resources'
▸ Running script 'Run Script'
▸ Touching Test.app
** ARCHIVE FAILED **

The following build commands failed:
ProcessProductPackaging /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.3.sdk/Entitlements.plist /Users/qsystems/Library/Developer/Xcode/DerivedData/Test-cfcyqqbyylxicshboklqsljrfgmi/Build/Intermediates/ArchiveIntermediates/Test/IntermediateBuildFilesPath/Test.build/Release-iphoneos/Test.build/Test.app.xcent
(1 failure)
[20:04:10]: Exit status: 65
[20:04:10]: Variable Dump:
[20:04:10]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios crashlytics", :CERT_FILE_PATH=>"/Users/qsystems/Documents/Test/R55U24HEB4.cer", :CERT_CERTIFICATE_ID=>"R55U24HEB4", :SIGH_PROFILE_PATH=>"/Users/qsystems/Documents/Test/Development_qs.test.mobileprovision", :SIGH_PROFILE_PATHS=>["/Users/qsystems/Documents/Test/Development_qs.test.mobileprovision"], :SIGH_UDID=>"34c3f448-162d-46f4-82cb-58744423d947", :SIGH_PROFILE_TYPE=>"development"}
[20:04:10]: Error building the application - see the log above


KeyError: "No object named 'DRCTModel' found in 'model' registry!"

Hi,
I can train the model with the following command
python drct/train.py -opt options/train/train_DRCT_SRx4_from_scratch.yml

but, I can't test my model with this command:
python drct/test.py -opt options/test/DRCT_SRx4_ImageNet-pretrain.yml

and I get the following error:
File "../python3.8/site-packages/basicsr/utils/registry.py", line 65, in get

  raise KeyError(f"No object named '{name}' found in '{self._name}' registry!")
KeyError: "No object named 'DRCTModel' found in 'model' registry!"

Hi,
We encountered this issue during testing, and it may be due to the register being referenced repeatedly when you installed the "hat" package. There are two possible solutions:
(1) If you have already installed hat, please try uninstalling it and resolving any potential bugs. This package might not be necessary.
(2) Try to copy-paste the model-related code into train.py or test.py without importing the related package. Although this approach is inefficient and somewhat messy, it is feasible.


Shift 32 bits variable in ULP Coprocessor (IDFGH-2746)

Hello guys,
I need to interface HX711 with ESP32 in deep sleep mode. That shouldn't be a problem because interfacing with HX711 is really simple, just putting some pins up, some pins down and read some pins and do some basic math.
The biggest challenge i'm facing right now is to work with 32 bits variable. At some point of the code i need to shift 1 bit left, and thats really hard to do because all 4 registers are 16 bits only. I'm having trouble right now at the line "jump b_lsb_1, 0x8000". Compiler gives me this error : "Jump adress is to far. Input text was eq.".
Code is below and i haven't finished yet, i'm trying to do part by part. If someone could please give me some advice of a easiest way to work with 32 bits variables on ULP or even a easiest way to interface HX711 with ULP ESP32, i would be very pleased.
PS: Sorry 4 PT-BR comments in the code :lol: , the parts that i have doubts are commented in english :D
Thank u very much,
Matheus
#include "soc/soc_ulp.h"
#include "soc/rtc_io_reg.h"
#include "soc/sens_reg.h"
#include "soc/rtc_cntl_reg.h"
.bss//Variaveis sao declaradas dentro da secao .bss
.global measurement_count
measurement_count: .long 0
.text//O codigo é feito dentro da secao .text
.global main
main://O codigo e iniciado aqui, equivale ao void setup()
jump loop
loop: //add0 = 9 adsk = 8
WRITE_RTC_REG(RTC_GPIO_OUT_W1TS_REG, RTC_GPIO_OUT_DATA_W1TS_S+9, 1, 1)//sobe add0
WRITE_RTC_REG(RTC_GPIO_OUT_W1TC_REG, RTC_GPIO_OUT_DATA_W1TC_S+8, 1, 1)//desce adsk
le_add0:
READ_RTC_REG(RTC_GPIO_IN_REG, RTC_GPIO_IN_NEXT_S + 9, 1) // le gpio_num_15 = rtc gpio 13
and r0, r0, 1 // faz uma and do valor lido com 0x01
jumpr le_add0, 0, eq // se o valor de r0 for igual zero, volta para ler dnv r0
stage_rst
loop_count:
WRITE_RTC_REG(RTC_GPIO_OUT_W1TS_REG, RTC_GPIO_OUT_DATA_W1TC_S+8, 1, 1)//desce adsk
and r0, r1, 0x8000 // R0 = R1 & 0X8000
jumpr b_lsb_1, 0x8000, // if R1 (LSB BYte) MSB BIT is 1, R0 will be equal to 0x8000 then jump to b_lsb_1
jump b_lsb_0 // if R1(LSB Byte) MSB bit is 0, R0 will be 0x0000
b_lsb_0: // R1 MSB Bit equal 0
lsh r0, r1, 1 // shift 1 bit left from LSB Byte
mov r1, r0
lsh r0, r2, 1 // shift 1 bit left from R2( MSB Byte)
mov r2, r0
jump loop_count
b_lsb_1: // R1 MSB Bit equal 0
lsh r0, r1, 0x01 // shift 1 bit left from lsb byte
mov r1, r0
lsh r0, r2, 0x01 // shift 1 bit left from msb byte
add r2, r0, 1 // add 1 to the value that correspondsto MSB bit from LSB byte that now is LSB bit of MSB Byte.
jump loop_count

Shouldn't
jumpr b_lsb_1, 0x8000, // if R1 (LSB BYte) MSB BIT is 1, R0 will be equal to 0x8000 then jump to b_lsb_1

be:
jumpr b_lsb_1, 0x8000, GE // if R1 (LSB BYte) MSB BIT is 1, R0 will be equal to 0x8000 then jump to b_lsb_1

Yes, it is, i forgot to put it in the code, but did you got my logic? Is there any easiest way?

Another question, i'm searching but what is the easiest way to read one 32bits variable of my ulp program in my main program?

The ULP hardware can only access the lower 16bits of memory. It is styled as a 16bit cpu.  So, no.  You have to work with 16bit values. to pass a 32 bit value to the main extensa cpu's you have to use combine 2 32bit memory locations:
// c code
extern long ulp_var1;
extern long ulp_var2;

// asm code
    .global var1
var1:  .long 0
    .global var2
var2:  .long 0

// c code
uint32_t measurement = ((var2 & 0xffff) << 16) | (var1 & 0xffff);

Your asm code is incomplete, i don't have any advice because I don't know what it is trying to do.
Chuck.

Hi, @Matheusmbgm , I just want to do a confirmation, did you post your desired code, here?
https://www.esp32.com/viewtopic.php?t=14349
thanks you


style: 🛁 linting

Description
Fix typos
Type of change

[X] Style

How Has This Been Tested?

[X] cargo test run with all tests passing

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.55%. Comparing base (608ad26) to head (fb28a79).

Files
Patch %
Lines

src/parse.rs
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   36.55%   36.55%
=======================================
  Files           4        4
  Lines        1160     1160
=======================================
  Hits          424      424
  Misses        736      736

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update Sparse_matrix_Operation.py

In this code, I added the addition and subtraction program code.
I hope this might helpful.

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Description
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

Here in this code I added the addition and subtraction program with simple algorithm.

here in this code I added addition program which will store sorted output in list and display it.
hope this might helpful!!

I am part of DWOC

plz review the changes made in code
commit id :- https://github.com/TesseractCoding/NeoAlgo/commit/55f2531f4b33cc8eb153d3fda6636bede17f648c

@Yash202000 Please make the README updates as well, and once you are done, squash your commits. We can review it then, because having a lot of commits makes review hard for us.

Closing the PR because of no updates!


refactor(audit): rename from 'inspect' to 'audit'

Fix #1505

change looks good to me.

rebased.

I'll check this in around today if there isn't specific suggestion around. Since this is name change only, I think it'll be ok.

Merged with 9630daa, thanks @saneyuki


Jenkins Configuration as Code

What this PR does / why we need it:
Implements Jenkins Configuration as Code. JCasC has been promoted as a top-level Jenkins project, and the corresponding Jenkins Enhancement Proposal has been accepted.
Which issue this PR fixes
Allows configuration of Jenkins using yaml configuration files that are concise and human-readable. The files also have user-friendly naming conventions making it easy for administrators to configure all Jenkins components.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

@davidkarlsen, did you get a chance to review this at all?

Note: Currently this PR only loads Jenkins config at startup.  As an option, should introduce a Jenkins "sidecar" - another container running inside the pod that monitors the JCasC configmap, creates the yaml files on the file-system, then executes the Jenkins CLI command to reload the config.  The Grafana Helm chart is a good example of how "sidecar" functionality can be added.  Would need to ensure this real-time CasC approach won't bork Jenkins if bad config is introduced.  But this is something for a future PR.  Startup-only is good enough for now.

Any news here? I'd love to have that feature!

Hey all,
The work that has been done here is really extensive, and I would really like to approve this PR.
There is just one thing that I would like to discuss:
The sidecar image that is being used is not an automated build, and as a user, I can not see the source code that was used to build it. This may be intimidating for users. When looking under the docker hub repo, I couldn't find any details regarding this image, as opposed to the image it was forked from.
In addition, and this is a smaller comment, I think that the logic in these sections can be simplified to use if-else:
https://github.com/helm/charts/pull/9057/files#diff-7146a5152507fba3404ff5118aab029cR248
https://github.com/helm/charts/pull/9057/files#diff-7146a5152507fba3404ff5118aab029cR274
But that is not as important as the previous comment.
Thanks for all the hard work all of you put in, your contribution is highly appreciated!

Hi @maorfr, good points.  I've documented my [sidecar image[(https://hub.docker.com/r/shadwell/k8s-sidecar) on dockerhub and included a link to the github repo.  I'll also start getting into the habit of adding proper change logs to each version.
I've replaced a few if conditions with simpler else statements in config.yaml as you suggested.  Let me know if it isn't what you had in mind.  We've been happily doing on-the-fly config reloads for over two weeks now in our busy Jenkins, so hopefully this is in a good enough state to merge.

/lgtm
Good job on this PR!

I've been looking into JCasC, and the Helm chart. We've been using a fork of 0.6.0 since two years ago, and are looking into moving back to the latest upstream version. I had some thoughts yesterday that I wanted to post here, but I see the PR has since been merged.
Either way, here's a quick summary, feel free to ignore it if you don't think it's relevant.
I think using the JCasC plugin makes a lot of sense. At the same time, I also think we should take this opportunity to either 1) kill off 90% of the current configuration flags that can just as easily be defined using the JCasC yaml-based set-up (and do a backward breaking release), or 2) create a new chart with only the following features:

Persistence support (but slightly tweaked to support a useable ephemeral set-up, see https://github.com/helm/charts/pull/11225)
Plugin installation support (since the JCasC plugin installation support is still considered beta)
All the relevant Kubernetes tweakables (RBAC, annotations, Ingress, ports, etc)
All the relevant flags that you need to set before Jenkins starts (JVM arguments, user to run Jenkins as, etc)
JCasC support
Init scripts (for those who want full access to the Jenkins API, for the things that JCasC does not yet support)

With this, you can eliminate a lot of extra configs, while still being able to achieve the exact same set-up as before, using JCasC. It would reduce the complexity of this chart, and we'd be able to point to the proper JCasC documentation for people to read, instead of having to read this Chart's documentation to be able to understand what you need to do to get the config you want.
As it currently stands, this PR (and the entire Jenkins chart) has so much complexity and hidden details based on the combination of configurables you set, that I'm almost inclined to ditch the chart and use a more simple set-up. With the above list of features "simple" would not mean "only useful to us", it would just mean less mental overhead when working with the chart, and moving to a set-up that is more in-line with the entire Jenkins ecosystem.
I've been experimenting locally with the JCasC setup, and the official Jenkins Docker image, and with a few volumes, JCasC, and some init scripts, you can get the exact set-up you want. Add to that the regular Kubernetes tweakables, and you end up where this chart is, without all the added complexity.
(note that I'm not criticising the current state, as I know how we got here, and a lot of the things that Jenkins properly supports these days (blueocean, kubernetes, JCasC) where just not easy to do one or two years ago, but given the current state, I think they are, and I think this chart would be better off if it reduced its complexity and off loaded the heavy lifting back to the official plugins)

I will prioritize any PR that simplifies this chart. Assign me to any such PR!

I will prioritize any PR that simplifies this chart.

That's good to know, but I'm sure there are qualifiers. Do we want to make backward breaking changes, if so do we want to do them all in one big overhaul PR, and if not, do we see any simplifications we can make without breaking backward compatibility?

I'm in the process of reconfiguring our CI right now, starting from scratch. I plan on taking the current chart, stripping it of everything except the things I mentioned above, and see if that works.
I can create a PR with those changes once done (sometime next week), and we can see if anything can be upstreamed, or not.

My guidelines are:

as few breaking changes
PRs should be as small as possible

Maybe we can open an issue to follow this process. Each PR can reference this issue (but not close it). Once all the work is done, the issue can be closed. It will also be a way to involve additional community members!
What do you think? Would you like to lead this effort?

Simple is good. But I'd prefer not to break existing users who use alternate (non JCasC) methods of configuring Jenkins.  Rather than be too brutal about discarding without warning, I'd prefer marking all non-JCasC configuration methods as deprecated for a period to nudge users off them and onto JCasC.  Breakages will dissuade people from using and relying on this chart.
I suggest moving non-JCasC configuration to the bottom of the Readme table and as low as poss in the values.  Mark them clearly as "deprecated" and add comments that these options will be removed shortly.  Also warn the user in Notes.yaml output if they're using these options.
@JeanMertz, pls can you clarify what "proper JCasC documentation... [not] this Chart's documentation" means?  In values.yaml and notes.yaml, I link clearly to the most authoritative JCasC reference: https://<jenkins_url>/configuration-as-code/reference, which contains info for the user's specific Jenkins implementation (their unique set of plugins, etc).  Also to the CasC demos on github which give practical examples that users can copy and paste.  Perhaps these links are needed more prominently in the Readme?

Would you prefer to discuss this in an issue instead of a merged PR? ;)

Would you prefer to discuss this in an issue instead of a merged PR? ;)

Done.

@holmesb can you help me, please? How can i run the sidecar configuration to autoreload the casc configuration? I do it like that

but give me error, miss something?

@ricardompcarvalho It would help if you could provide more details about the error.

The configuration that i show in image above is correct? I still need someone else configuration to do an auto-reload? @torstenwalter

@torstenwalter @holmesb gives me this

@ricardompcarvalho
Pls see latest values.yaml  Should be:
Sidecars:
    configAutoReload:
        enabled: true
        image: shadwell/k8s-sidecar:0.0.2
        imagePullPolicy: IfNotPresent
        resoureces:

etc.  Sorry we changed this in the latest version to accommodate multiple sidecars.

Yes, i already see that and change. Gives the error that i send above your answer @holmesb

This is a 403 Forbidden error.  Are you using the internal jenkins user database, or an external one such as LDAP?  The admin user will no longer exist if the later, hence you must change the Master.adminUser property to one that has Overall\Administer perms.
Anyway, this discussion doesn't belong in this merged PR.  Please raise an issue.

@holmesb thank you


Review GlorpTestCase class>>#isAbstract implementation

It sends #sunitName, which we can get rid of (thats legacy from original Sunit)
we could use the stardard #isAbstract mechanism of Pharo


[varLib.interpolatable] Allow for sparse masters

Hi!
I love using varLib.interpolatable but I noticed it doesn't work well with sparse masters. I think the default behavior should still be to report missing glyphs, but perhaps there should be a --ignore-missing flag to allow the tool to run without reporting missing glyphs as errors. It should still check for compatibility between glyphs in masters in which they exist, though.
For example:

Font1 has a and e glyphs
Font2 just has e
Font3 has a and e

varLib.interpolatable --ignore-missing should check Font1, Font2, and Font3 for compatibility in e, but only Font1 and Font3 for a. Crucially, if the sparse master happens to be the first master, it should not skip a altogether.

I made a PR #3075 to that effect, I certainly welcome edits or feedback!


Filter VINs

This adds in support to only add specific Teslas (or none) to homeassistant if you have multiple on your account. For my particular setup I have 2 energy sites and a tesla on my account. However I did not want the tesla added to my homeassistant and getting polled.
Implementation Details

I tried to add new tests, but they were failing locally with an error about not finding the tesla integration. I tried to solve this but could not find much information online about how to. Would appreciate any thoughts.
The default value for including all teslas is to use a space, this is because the homeassistant options flow will not pass through an empty value to the options flow. So if you add in a list of vins, then decide to remove them, the options flow will not signify that the vin value changed. So you have to use a space to signify this.   Ideally including all vins should be a checkbox and if not checked the text box appears, but I could not find out how to do this in the homeassistant documentation.

Upgrades
I did have to upgrade the teslajsonpy integration and the homeassistant integration because of two new features:

Teslajsonpy - https://github.com/zabuldon/teslajsonpy/pull/263
Homeassistant - https://github.com/home-assistant/core/pull/49912

Marking this as a draft because of the tests and some uncertainty. I will note that I am using this version of the integration as a daily driver just fine.

What's the error you're seeing on local tests? Hard to provide advice without more details. Also, I'm not enthused by requiring a space for all as it will generate issues. HA hasn't implemented select lists yet?

I also get the pytest-errors about missing integration:
ERROR    homeassistant.config_entries:config_entries.py:711 Cannot find integration tesla_custom
It happens on 7 of 10 tests in tests/test_config_flow.py and I guess the problem is this:
    with patch(
        "custom_components.tesla_custom.config_flow.TeslaAPI.connect",
        return_value={
            "refresh_token": TEST_TOKEN,
            CONF_ACCESS_TOKEN: TEST_ACCESS_TOKEN,
            CONF_EXPIRATION: TEST_VALID_EXPIRATION,
        },
    ):

The 3 test_option_flow... tests completes successfully.

And I think you can use a multi_select in config_flow (however, I have not tested it).
It should be something like:
vol.Optional(
    CONF_VINS_TO_INCLUDE, default=DEFAULT_VINS_TO_INCLUDE
): cv.multi_select(ALL_VINS),

(Not tested and verified against your code)

Oh. I didn't realize you didn't know about the polling switches. Those have been available for a long time. I thought you wanted some way to filter during the device discovery.


Installing pyMC3

In #98 i tried to install pyMC3 according to these instructions but failed because...
Encountered problems while solving:
  - package mkl-service-2.3.0-py39h07f9747_1 requires mkl >=2020.2,<2021.0a0, but none of the providers can be installed

conda-forge/noarch
conda-forge/linux-64
The command '/bin/sh -c echo "Installing conda packages..."  && mamba install -n ${CONDA_ENV} -y         altair         bqplot         plotly         python-kaleido         seaborn         ipycanvas         ipympl         jupyter_bokeh         jupyterlab-geojson         black         flake8         pep8         pyflakes         pylint         pytest         pytest-cov         jupyter-book         jupytext         numpydoc         sphinx         pymc3         theano-pymc         mkl         mkl-service         ipydatagrid         ipyparallel         lxml         pyhdf         vaex         mhealpy         pytables         statsmodels         xlrd         jupyter-repo2docker         jupyter-vscode-proxy         "jupyterlab>=3.2.4"         "jupyterlab-link-share>=0.2.2"         jupyterlab-git         jupyterlab-system-monitor         nbdime         qgis         retrolab         ipydrawio         websockify         compilers         cxx-compiler         cython         fortran-magic         google-cloud-sdk         sympy         cupy         cudatoolkit=11.2.2  && echo "Installing conda packages complete!"' returned a non-zero code: 1

It isn't clear to me what's the core issue is yet, but I'll try to resolve it and follow up in this issue.
/cc: @abbyazari @facusapienza21 who are interested in this

Investigation

Closing as resolved, import pymc3 now works.
For reference, @fperez made a comment about removing the nomkl package (that is a dummy package to make sure mkl isn't installed) and installing mkl as a dependency: https://github.com/pangeo-data/jupyter-earth/pull/100#issuecomment-1021736812

BTW, it seems to me that this can now be closed, right? In light testing everything worked fine for me - @abbyazari/@facusapienza21, pls let us know if you encounter any issues...


Combat Mechanics

As a player, I want to fight enemies found around the map.

There is still work to be done:
-Actual combat stats & mechanics (HP, Damage, Knockback, I-Frames)
-Refactor code to be generic and support items
Currently it's blocked by progress on Enemies and Items