Qwen1.5 Model 'tensorrt_llm' loading failed with error: key 'use_context_fmha_for_generation' not found

System Info

20.04 Ubuntu
NVIDIA H800
CUDA version 11.8

Who can help?
@kaiyux @byshiue
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
git clone https://github.com/NVIDIA/TensorRT-LLM.git
cd TensorRT-LLM
cd examples/qwen
pip install -r requirements.txt
python convert_checkpoint.py --model_dir /share/datasets/public_models/Qwen_Qwen1.5-72B-Chat/
--output_dir /share/datasets/tmp_share/chenyonghua/models/tensorrt_engines/qwen/checkpoint/qwen1.5_72b_chat_tllm_checkpoint_4gpu_tp4
--dtype float16
--tp_size 4
--workers 4
trtllm-build --checkpoint_dir /share/datasets/tmp_share/chenyonghua/models/tensorrt_engines/qwen/checkpoint/qwen1.5_72b_chat_tllm_checkpoint_4gpu_tp4
--output_dir /share/datasets/tmp_share/chenyonghua/models/tensorrt_engines/qwen/Qwen_Qwen1.5-72B-Chat_TP4/
--gemm_plugin float16
--workers 4
docker run --rm -it --gpus all --net host --shm-size=2g
--ulimit stack=67108864
-v /share/datasets/tmp_share/chenyonghua/models/tensorrt_engines/qwen/Qwen_Qwen1.5-72B-Chat_TP4/tensorrtllm_backend:/tensorrtllm_backend
-v /share/datasets/public_models/Qwen_Qwen1.5-72B-Chat:/share/datasets/public_models/Qwen_Qwen1.5-72B-Chat
nvcr.io/nvidia/tritonserver:24.05-trtllm-python-py3 bash
cd /tensorrtllm_backend
python3 scripts/launch_triton_server.py --world_size=4 --model_repo=/tensorrtllm_backend/triton_model_repo
Expected behavior
I would expect the tensorrt engine to work with the triton inference server
actual behavior

additional notes
Triton Inference Server used : nvcr.io/nvidia/tritonserver:24.05-trtllm-python-py3
Model used: Qwen_Qwen1.5-72B-Chat

Update: used tensorrt_llm version 0.10.0 to convert checkpoints and compile model

could you try pip install tensorrt_llm==0.11.0.dev2024061800?

could you try pip install tensorrt_llm==0.11.0.dev2024061800?

I've got the same issue with tensorrt_llm==0.11.0.dev2024061800
[TensorRT-LLM][INFO] Engine version 0.11.0.dev2024061800 found in the config file, assuming engine(s) built by new builder API.
[TensorRT-LLM][WARNING] Parameter max_output_len cannot be read from json:
[TensorRT-LLM][WARNING] [json.exception.out_of_range.403] key 'max_output_len' not found
E0624 09:58:34.138728 386 backend_model.cc:692] "ERROR: Failed to create instance: unexpected error when creating modelInstanceState: [json.exception.out_of_range.403] key 'use_context_fmha_for_generation' not found"
E0624 09:58:34.138787 386 model_lifecycle.cc:641] "failed to load 'tensorrt_llm' version 1: Internal: unexpected error when creating modelInstanceState: [json.exception.out_of_range.403] key 'use_context_fmha_for_generation' not found"
I0624 09:58:34.138805 386 model_lifecycle.cc:776] "failed to load 'tensorrt_llm'"
[TensorRT-LLM][WARNING] Don't setup 'skip_special_tokens' correctly (set value is ${skip_special_tokens}). Set it as True by default.
[TensorRT-LLM][WARNING] Don't setup 'add_special_tokens' correctly (set value is ${add_special_tokens}). Set it as True by default.

Update: That's my configuration about triton inference server. I wish I could be of some help～
python3 tools/fill_template.py --in_place
triton_model_repo/tensorrt_llm/config.pbtxt
engine_dir:/tensorrtllm_backend/triton_model_repo/tensorrt_llm/1,
triton_backend:tensorrtllm,triton_max_batch_size:64,decoupled_mode:False,max_beam_width:1,max_tokens_in_paged_kv_cache:2560,max_attention_window_size:2560,kv_cache_free_gpu_mem_fraction:0.5,exclude_input_in_output:True,enable_kv_cache_reuse:False,batching_strategy:inflight_fused_batching,max_queue_delay_microseconds:0,batch_scheduler_policy:guaranteed_no_evict
python tools/fill_template.py --in_place
triton_model_repo/preprocessing/config.pbtxt
tokenizer_dir:/share/datasets/public_models/Qwen_Qwen1.5-72B-Chat,
tokenizer_type:sp,triton_max_batch_size:64,preprocessing_instance_count:1,add_special_tokens:True
python tools/fill_template.py --in_place
triton_model_repo/postprocessing/config.pbtxt
tokenizer_dir:/share/datasets/public_models/Qwen_Qwen1.5-72B-Chat,
tokenizer_type:sp,triton_max_batch_size:64,postprocessing_instance_count:1
python tools/fill_template.py --in_place
triton_model_repo/ensemble/config.pbtxt
triton_max_batch_size:64
python tools/fill_template.py --in_place
triton_model_repo/tensorrt_llm_bls/config.pbtxt
triton_max_batch_size:64,decoupled_mode:False,bls_instance_count:1,accumulate_tokens:False

@HowardChenRV Did you manage to resolve the problem?

same problem here with tensorrt-llm==0.11.0.dev2024052800.
[TensorRT-LLM][INFO] Engine version 0.11.0.dev2024052800 found in the config file, assuming engine(s) built by new builder API.
E0703 14:20:40.781912 368 backend_model.cc:692] "ERROR: Failed to create instance: unexpected error when creating modelInstanceState: [json.exception.out_of_range.403] key 'use_context_fmha_for_generation' not found"
E0703 14:20:40.781964 368 model_lifecycle.cc:641] "failed to load 'tensorrt_llm' version 1: Internal: unexpected error when creating modelInstanceState: [json.exception.out_of_range.403] key 'use_context_fmha_for_generation' not found"
I0703 14:20:40.781972 368 model_lifecycle.cc:776] "failed to load 'tensorrt_llm'"
I0703 14:20:40.916041 368 model_lifecycle.cc:838] "successfully loaded 'tensorrt_llm_bls'"
[TensorRT-LLM][WARNING] Don't setup 'skip_special_tokens' correctly (set value is ). Set it as True by default.
[TensorRT-LLM][WARNING] Don't setup 'add_special_tokens' correctly (set value is ). Set it as True by default.

BTW, tritonserver release a new docker image: nvcr.io/nvidia/tritonserver:24.06-trtllm-python-py3, @ZhaoJianghua could you please try this new docker image?

This message stopped for me when I built the Docker container myself with these instructions and commit.

Hi @HowardChenRV
We have tried to reproduce your error, but the issue didn't arise when we ran it. First, we ran the latest triton server image (tritonserver:24.06-trtllm-python-py3). Then, inside the container, we converted the checkpoint, built the engine, and served the model successfully.
It is important to note that due to version compatibility issues, it is recommended to convert, build, and serve the models using the same installed packages. According to your description, you might have converted and built the engine using different versions than those installed on the triton server image. When we performed your commands on the same container, everything worked seamlessly.
Please use the latest Triton server and inform us if the problem still occurs.

Closing due to inactivity. @HowardChenRV - feel free to reopen or create a separate issue if the problem persists.

Hi @HowardChenRV We have tried to reproduce your error, but the issue didn't arise when we ran it. First, we ran the latest triton server image (tritonserver:24.06-trtllm-python-py3). Then, inside the container, we converted the checkpoint, built the engine, and served the model successfully. It is important to note that due to version compatibility issues, it is recommended to convert, build, and serve the models using the same installed packages. According to your description, you might have converted and built the engine using different versions than those installed on the triton server image. When we performed your commands on the same container, everything worked seamlessly. Please use the latest Triton server and inform us if the problem still occurs.

Thank you for your support; the issue has been resolved.


Use of curve-style: bezier is necessary to add directed style to graphs

I was reading the docs of this property and it really doesn't make much sense to me why this is happening.
Originally posted by @marimeireles in https://github.com/QuantStack/ipycytoscape/pull/70

Have to test it again on mac.

It's not in the docs but just found the SO answer by the maintainer of ipycytoscape:
https://stackoverflow.com/a/37843786/835607
seems that it is indeed necessary

Yeah, that's weird-ish.
Maybe we should just ask him, doesn't seem like smth the API should have right?
Thanks for digging this out @ianhi =)


Document in keyboard shortcuts documentation that Zulip makes browser back/forward hotkeys work

See https://chat.zulip.org/#narrow/stream/138-user-community/topic/Jump.20to.20previous.20location.3F/near/1182104 for some background.
We should add these to our keyboard shortcut documentation, taking care to to deal with the fact that these are Alt+Left on Linux/Windows and Option + Left on Mac.

@zulipbot claim


Bug/ep 2084

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


electrum 4.4.0-4.4.2 not working with jade-diy bitcoin app (pre-2.1): no sig for <compressed_pubkey>

the same problem is happening on the link that I will send below, in the electrum wallet jade cannot make transactions, according to the electrum staff it is because it is probably running the old version of something related to bitcoin ,
I hope this bug is fixed (and also the bug that prevents using jade diy on windows with the green wallet app)
https://github.com/spesmilo/electrum/issues/8365

This is a regression issue with electrum wallet, and was resolved by commit: https://github.com/spesmilo/electrum/commit/2752cd21834f81af4b71b80277191271f98f6518
See: https://github.com/spesmilo/electrum/issues/8463
My understanding is that it is fixed in: https://github.com/spesmilo/electrum/releases/tag/4.4.5

Thanks, I'm going to compile and test, it looks like this release came out 7 hours ago and it's still not available on the electrum website to download

Super - pls close this issue if their fix resolves the problems you are experiencing.
Many Thanks.

Is this resolved ?  Can we close ?  Thanks ?

Closing due to inactivity.  Believed to be caused by a now-resolved Electrum issue.


nodeport service targeting nginx controller intermittently times out

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

create a nodeport service that targets nginx-ingress-controller in a mixed cluster on a custom port
attempt to curl the nodeport from a linux ingress worker node

Result:
intermittent time outs to the nodeport
Other details that may be helpful:
Mixed cluster hosted entirely in AWS. 3 linux master nodes and 4 windows worker nodes
If you curl the nginx-ingress-controller directly, it responds 100% of the time. The time outs only occur when trying to curl the nodeport service.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.3.5
Host OS: CentOS 7
Windows worker OS = Windows 2019 (10.0.17763)

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): custom (aws)
Machine type (cloud/VM/metal) and specifications (CPU/memory): cloud (aws), m5.large for linux nodes and r4.xlarge for windows worker nodes
Kubernetes version (use kubectl version): v1.17.4

Closed for staleness.


Tyrkson/update token symbols

What kind of PR is this?:

/kind feature
What this PR does / why we need it:
Updates all token symbols to a black circle with white text
Which issue(s) does this PR fixes?:

Fixes #800
Sample Links & Screenshots:

Link:

Desktop Screenshot

Mobile Screenshot

Additional comments?:
Developer Checklist:

[x] Read your code changes at least once
[x] Tested on multiple web browsers
[x] Tested responsiveness (e.g, iPhone, iPad, Desktop)
[x] No console errors
[ ] Unit tests*
[ ] Added e2e tests*

I'm not sure did I have to change the symbols shown on mobile screenshot as well. That's also why I left the PR on draft mode right now.

Thanks @Tyrkson! I will check with the team regrading those pair symbols.

@Tyrkson Got an update from the team. We will also be updating the design of the LPs tokens. Similar to loan tokens but with 2 lines instead as shown below.

LP Token

I didn't remove dGME, dBABA etc custom symbol files but If they aren't needed anymore then I can do that as well.


Adds metadata requirement for reviewer and author and manager.

Docs Build status updates of commit 2ea679d:
:clock10: Full build: the average full build time is 14 min(s) 18 sec(s), this is based on the last 99 build(s) for this repository.
:warning: This is a FULL build due to the incremental build being disabled in configuration file (.openpublishing.publish.config.json in 'live' branch). For more detailed info, please click here.

Docs Build status updates of commit 2ea679d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

repo_docs/NEW_CMDLETS.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Metro 4 has beed added to Gabo's Awesome CSS Frameworks

Just to inform that Metro 4 has beed added to Gabo's Awesome CSS Frameworks in the "General Purpose" section.

Thank you


Uncaught SyntaxError: Export 'import_react3' is not defined in module

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
Steps:

Current behavior 😯
No response
Expected behavior 🤔
No response
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Please provide a minimal reproduction test case with the latest version. This would help a lot 👷. A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

@ShahMuhammad786
This is just a problem of uninstalled dependency.
I faced the same error when I didn't install @emotion/react and @emotion/styled
Installing those two fixed the problem.
Hope it helps.

@ShahMuhammad786 This is just a problem of uninstalled dependency. I faced the same error when I didn't install @emotion/react and @emotion/styled Installing those two fixed the problem. Hope it helps.

I love you buddy.


Remove user task list from manage section

@nmirasch @bsremac please take a look.

@bsremac yep,  I created a separated JIRA only for that as we might want to push into master as well: https://issues.jboss.org/browse/JBPM-6881


Get Tentacle building release versions again

Team

[X] I've assigned a team label to this issue

What happened?
Tentacle isn't building release versions
Reproduction
See TeamCity
Error and Stacktrace
No response
More Information
No response
Workaround
No response

Release Note: Fixed an issue with Tentacle not producing release versions


Fishing overlay randomly displays empty fish timings

Description
The fishing overlay sometimes "forget" the fish timings for a location.
It seems to think I've changed location, bait or buff and displays an empty list of known fish timings.
I've produced the issue during ocean fishing, 2 days in a row.
Everything was working fine before last update.
Additional information
I've captured the issue a few times on video : https://youtu.be/qP-pFbR6UlU
For this example, I've kept the same bait and didn't get any buff for the whole duration.
I've also uploaded the ACT logs, if that can help : https://gist.github.com/Neraud/ff0d7ad35561c719728c64377ee88a46

I tried reproducing this myself with fishing in various places but couldn't do it.  If this happens again, can you check the OverlayPlugin log messages? e.g. ACT -> Plugins -> OverlayPlugin.dll -> log window at the bottom?  My guess is that there's some error that's happening.

I've tried again in Ocean Fishing.
No logs in the ACT Windows (I cleared them before fishing, and nothing appeared).
Also, the issue seems to trigger at the same time for someone else in my party.
I haven't tried fishing in other zones.

Also having this issue. Just to add, I also noticed that issue while fishing in the Northwestern Caliban Gorge (The Tempest). Sometimes the overlay won't go empty, but its info gets inaccurate (it forgets the data you had for one fish and said fish is listed at the bottom again).
Log window is empty. I tried tweaking with self/everyone else's fishing messages, and it had no effect.

Reproduced in a controlled case.
If someone near you uses chum, it's detected as your own.
I could see handleChumGain and then updateFishData (with chum = true) getting called.

@Neraud Thank you for the detailed debugging.  That was exactly it.  Sorry for the hassle!

No worries, thanks for the fix !


Make polyfactory work with Ellipsis in dataclasses

Pull Request Checklist

[x] New code has 100% test coverage
[ ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[ ] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

By submitting this issue, you agree to:

follow Starlite's Code of Conduct
follow Starlite's Contribution Guidelines

Description
User claims that tuple[int, ...] doesn't work with dataclasses. I've added a test and it's true. It works however for pydantic, because pydantic doesn't return Ellipsis' in fields representation.
I've added a test that fails for given scenario. I've then added a set of types to ignore.
Close Issue(s)
Fixes: https://github.com/litestar-org/polyfactory/issues/181

I was also thinking whether instead of generating only one value for a variable-length tuple - maybe it should generate variable number of values?
Should be fairly easy. If you find it useful - let me know - I'll implement it.

Nice 🙂
@all-contributors add @mdczaplicki code

I was also thinking whether instead of generating only one value for a variable-length tuple - maybe it should generate variable number of values (e.g., in range of 0 & 5)?
Should be fairly easy. If you find it useful - let me know - I'll implement it.

That can definitely be useful. But it must be based on the type annotation -
tuple[str, str] is a 2 length tuple, but tuple[str, ...] is variable length. Apologies if you meant this - better safe than sorry.

That's what I've meant, of course 😁. I believe this could also be applied for all collections types. I also think that the user should be able to easily decide whether to generate only one item or many items in their collections.

That's what I've meant, of course 😁. I believe this could also be applied for all collections types. I also think that the user should be able to easily decide whether to generate only one item or many items in their collections.

Sounds great, PR is welcome.
Also, you're welcome to join our discord if you want to discuss stuff


How to show captured image and send it to server.

Hello,
I want to show capture image to next page and also want to send it.
I tried this way:
onBottomButtonPressed(event) {
 // I am passsing image uri to component as props
// but nothing is  showing on next screen.
    const captureImages = (event.captureImages);
    Actions.resultProduct({image: captureImages[0].uri});
  }

Thanks

probably related to #152


⚠ ClamAV has degraded performance

In 83d84d2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 96 ms

Resolved: ClamAV performance has improved in 8442806.


Contributing guideline

This is issue is for requesting a contributing guideline, mainly describing the source code structure and internal architecture of your work. Your work is very interesting in comparison with flutter-desktop-embedding and I would like to contribute!

Hi, btwael. Thank you for your interest in this project. I added this guideline. I also updated some comment in the code. Hopeful that helps.


Heal companion doesn't match Remaster

Heal companion is still written as if it was Preremaster
https://i.imgur.com/nYqSAau.png - how it is written in foundy
https://i.imgur.com/wome59A.png - AoN written

Verified there's an issue against the PDF.


[Bug]In mongo db->For distinct query->The response is not correct under response tab it display an error

Description
[What happened]In mongo db->For distinct query->The response is not displayed correctly under response tab it display an error
Steps to reproduce the behaviour:
Add steps to reproduce this behaviour, include console / network logs & screenshots

Go to Datasource page
Select the Mongo Db
Select the new query
Select Distinct from command
add all mandatory fields
Click on Run
Verify the display

Expected Result : The response should be displayed correctly
Actual result :  In mongo db->For distinct query->The response is not displayed correctly under response tab it display an error "ERROR":{
"message":"src property must be a valid json object" even thought query ran successfully
https://drive.google.com/file/d/1CSbiq4X8bTmS8XRhBlj55er0PU1xl8RA/view
Important Details

Version: [Cloud]
OS: Windows
Browser Chrome
Environment [production]

This is a UI issue where the display does not handle response of the following format :
[
  0:""
  1:"aarav"
  2:"deeksha"
  3:"kushi"
  4:"raksha"
  5:"vaibhavi"
  6:"vaish"
]

@trishaanand Shouldn't the server be returning proper JSON objects back to the client? The sample data you've posted is not valid JSON.

@trishaanand can we please fix this?

The result is returned in the following format :
["FORM", "GITHUB", "GOOGLE"]

The UI is not handling this correctly. An array of strings is what distinct command sends.

@trishaanand the UI is not expected to handle this format, queries are expected to return an array of objects. In this case, the key should be the key on which the distinct is being performed right?

@nidhi-nair @arunvjn Hey team! Can you please add your planning poker estimates with ZenHub


Added migro

I wrote migro as I wanted a better SQL migration tool than e.g. Liquibase or Flyway. While there are existing database migration tools written in Crystal already, they're limited to migrations written in SQL.
With migro, you can specify migrations in YAML or SQL. In the future, I hope to support automatic rollback for migrations written in YAML (ala ActiveRecord Migrations).

Looks like cql opens a new connection to the database for every query.  A single DB instance should be kept around and it does the pooling for you:
https://github.com/aisrael/cql/blob/dcad61b45838c7f78b53a10bd6d41d6fc945b591/src/cql/database.cr#L40

Also this is a SQL injection: https://github.com/aisrael/cql/blob/dcad61b45838c7f78b53a10bd6d41d6fc945b591/src/cql/postgresql.cr#L15
even for table_exists? you should be able to use a $1 placeholder to get proper escaping.

@RX14 Thanks! I've taken your suggestion about SQL injection and parameterised table_exists? as well as added some table name checking in CreateTable to help avoid it.

@aisrael DB pooling is SUPER simple: just add
@db = DB.open(@url)

here
then remove with_db and s/db/@db and you're done.
Pooling is automatic and built in to the DB drivers.


unknown postgres type jsonb

jsonb is a pretty common data type nowadays.

Yes.  We want to somehow expose the schema of these automatically.  Not sure if that is possible.  At a minimum you should be able to declare the structure and use them like nested object...


WFLY-11636 WeldClassFileInfo should account for meta-annotations.

JIRA - https://issues.jboss.org/browse/WFLY-11636
There is no test attached because the test is a part of Weld PR(https://github.com/weld/core/pull/1892) where this originated. We need similar test for SE, embedded container and WFLY all of which we can cover on Weld side.

Retest this please


Consider adding support for custom parsers of utterances

Today, we expect that the utterances JSON file is always an array of utterances with entities in one of two formats, an NLU.DevOps generic format:
[
   {
      "text": "order pizza",
      "intent": "OrderFood",
      "entities": [
        {
           "matchText": "pizza",
           "entityType": "FoodItem"
        }
      ]
   }
]

Or LUIS batch format:
[
   {
      "text": "order pizza",
      "intent": "OrderFood",
      "entities": [
        {
           "entity": "FoodItem",
           "startPos": 6,
           "endPos": 10
        }
      ]
   }
]

I suspect we can make this a bit simpler and afford an opportunity to leverage other tooling (that is less likely to get out of sync) if we allow dependency injection of the parser for utterances. One potential scenario I'd like to unblock is I'd like to write a simple script that takes a test utterance JSON file and sends the utterances off for prediction against LUIS / Lex / etc., storing the unmodified results directly from LUIS / Lex back in a JSON array.
I.e., could we easily enable something like this:
[
  {
    "query": "order pizza",
    "topScoringIntent": {
      "intent": "OrderFood",
      "score": 0.99999994
    },
    "entities": [
      {
        "entity": "pizza",
        "type": "FoodItem",
        "startIndex": 6,
        "endIndex": 10,
        "score": 0.973820746
      }
    ]
  }
]

We could achieve this with a couple different options.
Option 1, we add some flags to the compare command for how to inject the parser:
dotnet nlu compare \
  --expected tests.json \
  --actual results.json \
  --expectedFormat luis-batch \
  --actualFormat luis-response

Option 2, we add an optional envelope to the utterances JSON file:
{
  "format": "luis-response",
  "utterances": [
    {
      "query": "order pizza",
      "topScoringIntent": {
        "intent": "OrderFood",
        "score": 0.99999994
      },
      "entities": [
        {
          "entity": "pizza",
          "type": "FoodItem",
          "startIndex": 6,
          "endIndex": 10,
          "score": 0.973820746
        }
      ]
    }
  ]
}

There are a few benefits to this approach:

You do not need to depend on NLU.DevOps to run your tests. If an NLU provider exposes their own batch API, you could consider using that batch API directly and only use NLU.DevOps for comparing.
Whatever the test results are, we do not lose result data by "lifting" the results to a generic format.

Acceptance Criteria

dotnet nlu test command returns verbatim results from NLU provider
Default parsing (when not otherwise specified in the compare command CLI options or in a data envelope) should support generic utterances and LUIS batch formats. If a parser is specified, we should always support falling back on the default parsing behavior.
Should be an optional feature of NLU providers (e.g., luis, luisV3, lex, etc.), option to return generic utterance format from the test command should still exist
For now, let's only support 1 format per NLU provider, so we can continue to use the NLU provider moniker (e.g., luis, luisV3, lex, etc.) to represent the format in the compare command.

Examples
If we use a CLI option:
dotnet nlu test -s luis -u tests.json -o results.json
dotnet nlu compare -s luis -e tests.json -a results.json

The tests.json file may contain generic utterances format, whereas the results.json file will contain raw LUIS responses.
If we use the envelope method:
dotnet nlu test -s luis -u tests.json -o results.json
dotnet nlu compare -e tests.json -a results.json

The tests.json file may contain generic utterances format, whereas the results.json file will contain raw LUIS responses embedded in an envelope, e.g.:
{
  "format": "luis",
  "utterances": [
    {
       /* raw LUIS response */
    }
  ]
}


Use Font Awesome to provide a cute icon

Another little patch from my instance of the plugin.  Adds the GitHub icon next to the "GitHub Login" link to better distinguish it, and make clearer that it will send users to GH.

You can see an example of how this looks at https://trac.sagemath.org/

Something to consider is whether we want to include the Font Awesome script in the plugin (see ITemplateProvider) so that it can be served directly. If we choose to not do that, it could still be served directly by adding the script to the Environment or shared htdocs directory and using a path starting with /chrome/site/.

I'd rather not add several hundred kilobytes of Font Awesome to every page for loading a single icon.
Can we load only the icon we need, one way or another?

@rjollos @aaugustin I've thought about both these things. I definitely agree FA is overkill, it was just the quickest and easiest way to do this.  What I do like about it is that it's an actual font glyph and scales with the text nicely, but I've heard of ways to extract just the bits you need out of FA. I could look into that.
For my purposes it was fine, but I agree with these points.

http://fontello.com/ make is super easy to build a custom subset of Font Awesome — in that case, a subset with only the icon you need.

It looks like there are merge conflicts; I guess a rebase is needed?


Take advantage of Joi's meta ability to specify columnName for a property

This feature will allow Schwifty to retro-fit onto an existing database with strange or ugly column names, preserving your right to have sensible prop names that're easy on the eyes.
When writing a joiSchema, be able to specify the database's columnName that maps to this property like so:
{
    fieldName: Joi.string().meta({
        columnName: 'field_name'
    })
}

@mattboutet is this something you've ever wished for since schwifty v1 came out?

Nope, but to be fair, I've not yet been saddled with an old/janky database.

I'll leave this as a request for now.  My guess is that when schwifty-migrations comes through we'll want to be able to set options like this.

Adding to this meta addition, I was thinking it would be great to support specifying constraints in the meta for a model's property. For example: specify db varchar length (defaults to 255) in the meta so you don't have to dig into the knex migration file every time

This was an initial turn-off as I was investigating whether I wanted to use Schwifty. But in case anyone stumbles upon this, it's possible to use camelCase properties in JavaScript while keeping snake_case column names in your database.
These two methods involve creating your own instance of Knex and passing that to Schwifty when registering the plugin. The conversion happens at the Knex-level, so in most cases these options have the benefit of allowing you to use the camelCase version when using the Query Builder methods.

knexSnakeCaseMappers - Handles camelCase to snake_case conversion automatically. You will still have to follow some conventions, since the conversion is automatic.
knexIdentifierMapping - This is an explicit mapping that you provide. The link includes an example of how you could add a column property to your models in order to keep that information with the model.

I personally use knexSnakeCaseMappers. (I don't use Knex's migration features, but if you do, it seems there is an issue related to migrations and this option - https://github.com/Vincit/objection.js/issues/1144.)
Alternatively you can set a columnNameMappers static property on your model(s). Objection exports a function that you can set on this property to get the commonly desired camelCase ↔ snake_case behavior. Because this happens in Objection, you would still need to use snake_case column names whenever you use Query Builder methods. This is a good choice if you just want to convert between database column name ↔ JavaScript property name ↔ JSON (stringified) property name.
There are pros and cons to each, so I encourage reading the relevant Knex and Objection documentation.

I am closing this, mostly because I think it has become a bit old/stale.  We can reopen if folks become interested again or want to spec out a specific feature proposal.  I personally think this would make for a great schwifty/objection plugin or even just a function to work with static columnNameMappers() similarly to objection's snakeCaseMappers().


No Status is returned by many commands

Hello,
Could you please take a look and see if this is legit or if I need to do things differently?
Here is an example of my code:
    ` string status =  await _redisConnectionProvider.Connection.UnlinkAsync($"student:{studentId}");`

Under the hood in namespace Redis.OM --> public static class RedisCommands
        public static string Unlink(this IRedisConnection connection, string key) => (string) connection.Execute("UNLINK", (object) key);
Status is always empty string --> ""
OR: I tried to go deeper and I found this result:
    ` var status= await _redisConnectionProvider.Connection.ExecuteAsync("UNLINK",$"student:{studentId}");`

here status is of type Task<RedisReply> and return _internalLong which can be used to check the status but I felt it is not very straightforward

Unlink wouldn't return a 'status' per se, it would return the number of keys that the unlink touched. Not entirely sure why this was set to a string (that's why it's not working)
var numUnlinked = (long)(await _redisConnectionProvider.Connection.ExecuteAsync("UNLINK",$"student:{studentId}"));

Will get the result you're looking for (we'll need to change this API so it's correct). Interesting that this hasn't come up before.

@slorello89, thanks very much for your quick response and also for your videos on YouTube, very insightful :)


Getting validation failures in AfterValidation interceptor method

Previously we were using FluentValidation.AspNetCore to automatically validate parameter for controller actions. We then had an IAsyncActionFilter that was registered to detect if there are ModelState errors, and convert them into a custom error model. Since FluentValidation.AspNetCore is no longer supported we moved to SharpGrip.FluentValidation.AutoValidation however we noticed that SharpGrip seems to pre-empt our filter if there are errors and just return a plain ProblemDetails object.
After looking at the documentation I see you provide an AfterValidation interceptor, so I tried to convert our filter to be a IGlobalValidationInterceptor instead but I don't see how you get the list of failures in this method. The IValidationContext doesn't seem to have a way to get at the failures so I am wondering how is this used? Is the purpose of this method not to be able to take action based on the results of the validation? It's kind of hard to do that if I don't have access to the results of the validation in this method. Any help understanding would be greatly appreciated.

Hi @nkamenar,
You are correct that the validation interceptors are not receiving the validation result. This was an oversight on my part when implementing the validation interceptors.
Since adding a new parameter to the interface would break existing code, I will set the milestone for this to v2. I haven’t conducted a deep dive into the code to determine if there is a backward-compatible fix that avoids introducing new interfaces. However, if you discover anything, please let me know!
See also: https://github.com/SharpGrip/FluentValidation.AutoValidation/issues/12

I was able to replace an IActionFilter, which converts ModelState errors to ValidationProblemDetails, and use a custom IFluentValidationAutoValidationResultFactory instead.
services.AddFluentValidationAutoValidation(configuration =>
{
    // Replace the default result factory with a custom implementation.
    configuration.OverrideDefaultResultFactoryWith<CustomResultFactory>();
});

public class CustomResultFactory : IFluentValidationAutoValidationResultFactory
{
    public IActionResult CreateActionResult(ActionExecutingContext context, ValidationProblemDetails? validationProblemDetails)
    {
        // ModelState errors are available in context.ModelState
        return new BadRequestObjectResult(new {Title = "Validation errors", ValidationErrors = validationProblemDetails?.Errors});
    }
}


Upgrade to support rails 5.2.5

Upgrade gemspec to support rails 5.2.5
and all dependencies
Github: https://github.com/artofthetrekcom/inciweb/pull/9
Trello: https://trello.com/c/MmJXZQQP

@kasunvp this is ready for review

 Upgrade rails to 5.2.5


Detect Git LFS username

The plugin demands that you set the "username to lock files on the LFS server". If not set, it won't be able to recognize the content you can actually edit. Other Git clients such as TortoiseGit have no issue detecting the Git LFS user that should be used for a given clone. I was wondering why this plugin does not take the same approach and requires the user to input this information.

Where can I change this after the plugin is installed?
I changed git user and I keep getting the lock with the old username and I cant find where to change it ANYWHERE
tried to change the username in unreal, github desktop, local config, global config, nothing works


Error: Cannot find module '../package.json'

webpack
module.js:471
throw err;
^
Error: Cannot find module '../package.json'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (/Users/vinyuan/code/uculture/webpack-demo3/node_modules/.bin/webpack:17:22)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
npm ERR! Darwin 16.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
npm ERR! node v6.11.2
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: webpack
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'webpack'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the webpack-demo2 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     webpack
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs webpack-demo2
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls webpack-demo2
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/vinyuan/code/uculture/webpack-demo3/npm-debug.log

Do you want to request a feature or report a bug?

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.

It's stupid for me to missing comma in webpack.config.js ,TOT.
as you see, between the line 8 and line 9, there is no comma, so error occurs
module.exports = {   4     entry: './src/index.js',   5     output: {   6         filename: 'bundle.js',   7         path: path.resolve(__dirname, 'dist')   8     }   9     module: {  10       rules: [
Be careful for the comma between key:value in config file~
so I post this issue for many other people who is new for webpack

hello @Vin-Yuan  I am suffering from same issue can you please help.
I went through your solution but in my case there is no comma issue. Please help

@mygovernance I had the same error after moving a project to a different directory. I fixed it by nuking my node_modules and redoing 'npm install'.

I encountered the same problem, I moved my project directory because I cannot use network in that os, are there any other ways to fix this issue?

I just fix it by adding new symbolic link:
cd node_modules/.bin
rm -rf vue-cli-service
ln -s<EMAIL_ADDRESS>vue-cli-service

I just fixed it by rebuild webpack npm rebuild webpack or rebuild all dependencies with npm rebuild.

this worked for me!

I just fixed it by rebuild webpack npm rebuild webpack or rebuild all dependencies with npm rebuild.

npm rebuild webpack didn't work but npm rebuild did


Private hosted AKS cluster status indefinitely switches from Active to Unavailable after successful cluster provisioning

Rancher Server Setup

Rancher version: v2.6-head
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc):

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: v1.23.5
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): AKS

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Standard

If custom, define the set of permissions:

Describe the bug

When creating a private hosted AKS cluster within Rancher, I am able to successfully provision following the steps in issue https://github.com/rancher/rancher/issues/37164#issuecomment-1139161978. However, as mentioned in that same comment, there is a flickering of the cluster's status between Active and Unavailable.
Looking in the backend, each time this flickering happens, the aks-command namespace repetitively performs the following actions:

Creates a new pod until it reaches Running state
Once that pod reaches Running state, Rancher shows the cluster as Active
Immediately after, the pod terminates and a new aks-command namespace is spun up along with a new corresponding pod`. This repeats over and over again, explaining the unstable cluster status in Rancher

Additionally, there may be some issue with regards to how controllers are being handled in this hosted Rancher setup. That will need further investigation.
To Reproduce

In a local client machine, ensure that you have downloaded the az cli and have logged into your Azure subscription.
Setup Rancher and navigate to the Rancher UI.
Create a standard user and login to Rancher as that user.
Create a 3 node, private AKS cluster via Rancher. Be sure to set the following:

Check off Enable Private Cluster in Networking Options.
In Cluster Options, add tags that match your Kubernetes service. If you know them beforehand, you can do it before you create it. If not, you will need to come back to this step and add the tags.

Navigate back to your client machine and run the following command once the cluster is created: az aks command invoke --resource-group <resource group> --name <cluster name> --command "<registration command".
You should see the following:

Result
Hosted AKS private cluster status flickers indefinitely between Active and Unavailable.
Expected Result

Hosted AKS private cluster status should stay on Active.

This issue might be fixed as part of https://github.com/rancher/rancher/issues/37608
can you try it again with the latest 2.6-head?

Still reproducing this issue on v2.6-head https://github.com/rancher/rancher/commit/79a3bcba901add6249cfbb6d9d4961599553f8da following my reproduction steps described in the issue description.
Perhaps this commit I used is outdated? Either way, I can try again early next week, but I am still seeing this issue.

I think this is due to the aks-operator latest chart version 1.0.6-rc2 failing to deploy on 2.6-head. I'm looking into this today with Kinara and Arvind.

Still reproducing this issue on v2.6-head https://github.com/rancher/rancher/commit/0fd630dd1328233958bdef6b9f7f413eb7463005.
ENVIRONMENT

Rancher HA
Rancher version: v2.6-head https://github.com/rancher/rancher/commit/0fd630dd1328233958bdef6b9f7f413eb7463005
AKS version: v1.23.5
Browser: Chrome

TEST RESULT
FAIL
REPRODUCED STEPS

In a local client machine, ensured that I downloaded the az cli and have logged into my Azure subscription.
Setup Rancher and navigated to the Rancher UI.
As my default admin user, created a hosted AKS cluster.

Created a 3 node, private AKS cluster via Rancher. Be sure to set the following:
Checked Enable Private Cluster in Networking Options.

Navigated back to my client machine and run the following command once the cluster is created: az aks command invoke --resource-group  --name  --command "<registration command".
I see see the following:

Verified that my aks-operator is updated to the latest version:


DIDynamic renamed to DIAssociate

Coverage remained the same at 50.0% when pulling f02a090fa21925e4412126d5567c8ea25504fa2c on fix/rename-assoc into 20e07077d784af7fd2fa0cf7885fae833aa78683 on master.

Coverage remained the same at 50.0% when pulling f02a090fa21925e4412126d5567c8ea25504fa2c on fix/rename-assoc into 20e07077d784af7fd2fa0cf7885fae833aa78683 on master.


links formatted differently in FCM

in the featured content module, the content link and the optional additional links provided are formatted differently. we'd like them to be formatted the same. an example of this is here: /consumer-help/financial-resources-servicemembers/

Is this a duplicate of #1328

We're going to tackle this issue in #1379


fix(rollup): again

:tada: This PR is included in version 4.29.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Certain Unicode characters not affecting the label size

I've implemented a way to dynamically size TextInputs depending on the text inside of them. But after a little testing I discovered a strange issue. The Unicode smile character ("☺") is ignored for some reason when I refer to the _lines_labels property of a TextInput to get their width. So for example:

You can see that normal letters are recognized and the size is increased, but for the smile chars it doesn't work. The font I use is OpenSans-Emoji. Here is the link to the Google Groups post about that.

@illright: I suspect the font itself has misinformation about emoji widths. Can you try it with a different font?
(The OpenSans-Emoji font doesn't seem to have any updates, or I would recommend upgrading.)

Afraid I can't, this issue is way overdue :) I became a JS developer in the meantime, I no longer use Kivy


tweet-api flask endpoint

connected front-end to pre-built pytorch twitter sentiment classifier model
some cleanup TODOS remaining:

[ ] I want to update the test file to use pytest and add some tests and test-payloads
[ ] serve api template or tweet-api on a different port so there's no conflict (or remove api?)
[ ] pin transformers, torch and scipy in requirements.txt
[ ] for @soulshake , fix issue with needing to comment out volumes for front-end
[ ] figure out how to set the tweet-api app to refresh / check for updates to the code so I can iterate on the code and test it without taking the app down (I had this before, I think a gunicorn param or something)

Architecture design decisions to discuss:
Response Payload:

We could demonstrate architecture design trade-offs between having the api return the most likely class (simple and the design we have here) OR sending back the scores for each class. Example response:
{"joy": .92, "sadness": .02, "optimism": .83, "anger": .03}
This would force the caller to do logic on their side but gives them a lot of flexibility to change the UI without requiring an update to the api. Examples:

filter to the most likely class and display that
only accept a classification if the score is above a threshold of say .9
filter to any classes that have a score above a threshold, say .8
display a ranked list of the classes as suggestions in a drop-down menu

Alternatives? Return both? Two separate endpoints? Force the caller to specify what they want in their request payload with a parameter like "verbose"?

Loading the model files into memory:

This implementation loads pre-built model files into memory when the app starts up (upon import of inference.py). Those are baked into the docker image from the requirements.txt

We could cover architecture design trade-offs of alternative approaches for custom-built model archive files. For example:

bake them into the docker image
download via an api call to s3/blob storage etc. when the app starts
volume mount them when developing locally with docker-compose and store them on a persistent volume for running on kubernetes?
other options?

Also noting that here for further reference: the tokenizer model is downloaded when we import inference, but the emotion model is downloaded when we call predict(...) the first time.
Both models are cached in ~/.cache/huggingface/transformers:
$ rm -rf ~/.cache/huggingface/transformers/
$ ipython
Python 3.10.8 (main, Nov  1 2022, 14:18:21) [GCC 12.2.0]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.6.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import inference
Downloading: 100%|██████████████████████████████| 768/768 [00:00<00:00, 446kB/s]
Downloading: 100%|████████████████████████████| 878k/878k [00:02<00:00, 347kB/s]
Downloading: 100%|████████████████████████████| 446k/446k [00:00<00:00, 815kB/s]
Downloading: 100%|█████████████████████████████| 150/150 [00:00<00:00, 93.5kB/s]

In [2]: inference.predict("it is a beautiful day")
Downloading: 100%|███████████████████████████| 476M/476M [00:34<00:00, 14.4MB/s]
Out[2]: 'joy'

In [3]: inference.predict("it is a very beautiful day")
Out[3]: 'joy'

In [4]:
Do you really want to exit ([y]/n)?
$ du -sh ~/.cache/huggingface/transformers/
477M	/home/jp/.cache/huggingface/transformers/


docs: add reference to my question

In case anyone else is curious :)
ref #8

IMO you should add a summary of the contents of the issue, rather than just linking to it.  Perhaps an FAQ section?

Especially now that issues are disabled 😅

Added detail to the README

issues page disabled :/


Fix prefix bug race condition

If a user presses a key and pauses long enough for the autocomplete to initiate (100ms by default) and then presses a key before an async provider returns its value, the 'boldification' of the letters in the autocomplete list will trail behind the actual text. In addition accepting the completion will fail.
This is a fix for that issue.

I have no idea where the conflict comes from: I made the change against the master head.

My mistake. Doing the merge.

Dont need to close it. Just rebase on master:
git checkout master
git pull
git checkout bug-prefix-race-condition
git rebase master

Then fix all the conflicts and
git push -f

Ok, re-opening this one.

Can you rebase this on master? Rebasing should get rid of that merge commit

Done, sorry: not used to using rebase.

Are you getting into this situation with one of your providers in practice? This doesnt solve the whole issue as providers can still specify a replacementPrefix which would be stale at the point where this happens.
Here are the the steps in prose format:

Type ab
Provider getSuggestions call 1 is kicked off
Type c
Call 1 returns, and displays results to user
Provider getSuggestions call 2 is kicked off
The user selects something from call 1 results.

Yeah, so I was messing around with a clang (C++) provider and do intend to release it at some point, this had a visible (and frustrating) experience in the editor. Your prose looks correct.
As for your concerns I intend to fix that with the filtering, the provider will do its async work in getSuggestions and then could do any final logic in filterSuggestions (if a function is provided) - which may include setting the replacementPrefix to something appropriate. This could be split into two functions, but, they would likely be called in sequence from autocomplete-manager in any case.

I think we should simply invalidate a suggestion if it is confirmed and the current cursor/position does not match the cursor/position for which the suggestion was provided.

 The means that if you have a long-running provider autocomplete doesn't work after the first keystroke: if you type fast enough.

I'm currently on the side of the current behavior as well as @joefitzgerald. Thinking about how to better handle this in a background process...

If the cursor has moved since the current suggestion list's suggestions were displayed they are inherently invalid. I think if we focus on that, and provide a mechanism for a cursor movement to invalidate any existing suggestion requests, we've solved the problem.


Documentation Updates

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@665647a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   84.66%
=========================================
  Files             ?        9
  Lines             ?      600
  Branches          ?        0
=========================================
  Hits              ?      508
  Misses            ?       53
  Partials          ?       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665647a...f39cc8d. Read the comment docs.


Share training parameters and join indices

Hi!
Cool project!
Have a few questions. Is it possible to re-use the training parameters (I.e. for IVF_PQ) to initialize a new index when calling create_index?
A somewhat related question, if one had two indices that have the same training parameters, would it be possible to join them? Much like what FAISS does (on_disk merge). Just thinking of uses cases where different jobs create different indices in a distributed fashion and then you want to join them.
I’m also interested in understanding the partitioning parameter. Is this equivalent to nlist parameter in FAISS or does it control the number of shards which you end up creating (and then later merge?)
Thanks!

Hey, @fferroni
These are super exciting features. thanks for reporting them, we would love to support them soon.

A somewhat related question, if one had two indices that have the same training parameters, would it be possible to join them? Much like what FAISS does (on_disk merge). Just thinking of uses cases where different jobs create different indices in a distributed fashion and then you want to join them.

That'd be interesting, so this is like a merge sort from two different indices (i.e., IVF_PQ with different parameters)? Tha'd be interesting to support. We do have full-text-search merge with vector index, and will soon have a sorted index with vector index soon. But i'd admit that I have not thought about merging two vector indices yet.
Would love to see what kind of use case that is. Implementation-wise i feel that it should be just an extension & refractor of our current i/o path.

I’m also interested in understanding the partitioning parameter. Is this equivalent to nlist parameter in FAISS or does it control the number of shards that you end up creating (and then later merge?)

IVF64,PQ32 in faiss == num_partitions=64, num_sub_vectors=32 in Lance.
nlist in faiss == nprobs in Lance.
Please keep shooting us great ideas! We'd love to support them.

Hi,
For the merging of indices, I was actually thinking of a simpler case where two (or more) different indices with the same training parameters are joined. This is the on_disk merge function of FAISS. That however would require control of the training parameters. The use case is simple - you have a distributed workload that generates smaller indices and you want to combine these smaller indices into a larger one
Thanks!


sorbet/files.yaml: Merge the two false lists into one

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] ~Have you written new tests for your changes? Here's an example.~
[x] ~Have you successfully run brew style with your changes locally?~
[x] ~Have you successfully run brew tests with your changes locally?~
[x] ~Have you successfully run brew man locally and committed any changes?~

I've been asked a couple of times now what the two different false: lists mean. And the answer is "nothing". So to avoid confusion (and to stop my YAML linter moaning about duplicate keys), merge the two lists and re-alphabetize.

Thanks @issyl0, I just noticed this and was also wondering why false is in there twice.


Add the possibility to set the contact phase in  SwingFootPlanner and FixedFootDetector without resetting the internal time

In the fixed foot detector and in SwingFootPlanner the initial time is reset every time a new set of contact is passed to the classes
https://github.com/ami-iit/bipedal-locomotion-framework/blob/252e9308b91f034bafc90388755336a447002801/src/Planners/src/SwingFootPlanner.cpp#L126-L129
https://github.com/ami-iit/bipedal-locomotion-framework/blob/252e9308b91f034bafc90388755336a447002801/src/Contacts/src/FixedFootDetector.cpp#L202-L203
This is actually a problem in the case you want to change only the position of a contact in the contact list and reuse the very same instance of the class. I know that this can be really dangerous if someone does not know what is actually doing.
Since I need this feature for enabling the step recovery for the CentroidalMPC I will try to implement something in a quick and dirty manner. Then I think we should discuss some more elegant approach with @S-Dafarra

By the way, probably the setContactPhase functions should not reset the internal clock of the advanceable. I think that the initial clock should be set by an ad-hoc method.
cc @traversaro

As discussed quickly F2F, I guess that we can have two different methods, one that initializes everything and does all the resets (like setInitialContactList), and another to update only specific quantities (like updateContactList).

This has been faced thanks to several PR I opened:

SwingFootPlanner https://github.com/ami-iit/bipedal-locomotion-framework/pull/637 and https://github.com/ami-iit/bipedal-locomotion-framework/pull/688
https://github.com/ami-iit/bipedal-locomotion-framework/blob/ba95103f95745ae604ff14dc4d191cd07e18ca6e/src/Planners/src/SwingFootPlanner.cpp#L262-L265

Fixed foot detector https://github.com/ami-iit/bipedal-locomotion-framework/pull/624
https://github.com/ami-iit/bipedal-locomotion-framework/blob/747fb929fb082576eb5916fc60baf086962b6ec1/src/Contacts/src/FixedFootDetector.cpp#L246-L249

Indeed both the classes have a function to reset the time


Remove redundant wal files

TSM1 is the only engine for InfluxDB. The old wal files are not used now.

:+1:

Thanks @li-ang!


make_function returns wrong result with sparse Jacobian for very simple functions only

julia> using FastDifferentiation

julia> x = make_variables(:x, 4)
4-element Vector{FastDifferentiation.Node}:
 x1
 x2
 x3
 x4

julia> y = diff(x)
3-element Vector{FastDifferentiation.Node}:
 (x2 - x1)
 (x3 - x2)
 (x4 - x3)

julia> jac = jacobian(y, x)
3×4 Matrix{FastDifferentiation.Node}:
  -1    1  0.0  0.0
 0.0   -1    1  0.0
 0.0  0.0   -1    1

julia> jac_sparse = sparse_jacobian(y, x)
3×4 SparseArrays.SparseMatrixCSC{FastDifferentiation.Node, Int64} with 6 stored entries:
 -1   1   ⋅  ⋅
  ⋅  -1   1  ⋅
  ⋅   ⋅  -1  1

julia> jac_exe = make_function(jac, x)
RuntimeGeneratedFunction(#=in FastDifferentiation=#, #=using FastDifferentiation=#, :((input_variables,)->begin
          #= /home/guillaume/.julia/packages/FastDifferentiation/7I3sT/src/CodeGeneration.jl:192 =#
          #= /home/guillaume/.julia/packages/FastDifferentiation/7I3sT/src/CodeGeneration.jl:192 =# @inbounds begin
                  #= /home/guillaume/.julia/packages/FastDifferentiation/7I3sT/src/CodeGeneration.jl:193 =#
                  begin
                      result_element_type = promote_type(Float64, eltype(input_variables))
                      result = Array{result_element_type}(undef, (3, 4))
                      result .= [-1.0 1.0 0.0 0.0; 0.0 -1.0 1.0 0.0; 0.0 0.0 -1.0 1.0]
                      return result
                  end
              end
      end))

julia> jac_sparse_exe = make_function(jac_sparse, x)
RuntimeGeneratedFunction(#=in FastDifferentiation=#, #=using FastDifferentiation=#, :((input_variables,)->begin
          #= /home/guillaume/.julia/packages/FastDifferentiation/7I3sT/src/CodeGeneration.jl:227 =#
          begin
              element_type = promote_type(Float64, eltype(input_variables))
              result = SparseMatrixCSC(3, 4, [1, 2, 4, 6, 7], [1, 1, 2, 2, 3, 3], zeros(element_type, 6))
              vals = nonzeros(result)
              vals .= [-1, 1, -1, 1, -1, 1]
              # return result missing here
          end
      end))

julia> jac_exe(rand(4))
3×4 Matrix{Float64}:
 -1.0   1.0   0.0  0.0
  0.0  -1.0   1.0  0.0
  0.0   0.0  -1.0  1.0

julia> jac_sparse_exe(rand(4))  # returns the vector of nonzeros instead of the result
6-element Vector{Float64}:
 -1.0
  1.0
 -1.0
  1.0
 -1.0
  1.0

I think this happens because of a missing return result line in the generated function. What's weird is that for a slightly more complicated function, this line does appear and the result is correct:
julia> g(x) = diff(x) .^ 2
g (generic function with 1 method)

julia> y = g(x)
3-element Vector{FastDifferentiation.Node}:
 ((x2 - x1) ^ 2)
 ((x3 - x2) ^ 2)
 ((x4 - x3) ^ 2)

julia> jac_sparse = sparse_jacobian(y, x)
3×4 SparseArrays.SparseMatrixCSC{FastDifferentiation.Node, Int64} with 6 stored entries:
 (-2 * (x2 - x1))   (2 * (x2 - x1))                 ⋅                ⋅
                ⋅  (-2 * (x3 - x2))   (2 * (x3 - x2))                ⋅
                ⋅                 ⋅  (-2 * (x4 - x3))  (2 * (x4 - x3))

julia> jac_sparse_exe = make_function(jac_sparse, x)
RuntimeGeneratedFunction(#=in FastDifferentiation=#, #=using FastDifferentiation=#, :((input_variables,)->begin
          #= /home/guillaume/.julia/packages/FastDifferentiation/7I3sT/src/CodeGeneration.jl:252 =#
          begin
              element_type = promote_type(Float64, eltype(input_variables))
              result = SparseMatrixCSC(3, 4, [1, 2, 4, 6, 7], [1, 1, 2, 2, 3, 3], zeros(element_type, 6))
              vals = nonzeros(result)
              var"##262" = input_variables[2] - input_variables[1]
              var"##261" = -2var"##262"
              vals[1] = var"##261"
              var"##263" = 2var"##262"
              vals[2] = var"##263"
              var"##265" = input_variables[3] - input_variables[2]
              var"##264" = -2var"##265"
              vals[3] = var"##264"
              var"##266" = 2var"##265"
              vals[4] = var"##266"
              var"##268" = input_variables[4] - input_variables[3]
              var"##267" = -2var"##268"
              vals[5] = var"##267"
              var"##269" = 2var"##268"
              vals[6] = var"##269"
              return result
          end
      end))

julia> jac_sparse_exe(rand(4))
3×4 SparseArrays.SparseMatrixCSC{Float64, Int64} with 6 stored entries:
 -0.943871  0.943871     ⋅           ⋅
   ⋅        0.0243471  -0.0243471    ⋅
   ⋅         ⋅          0.443617   -0.443617

Looks like it's related to one of the optimizations for constant jacobians. Should be an easy fix but may not be done till tomorrow since it's already late here.

No worries at all!

Fixed the bug and am waiting for the PR CI to finish. Should be done in 15-20 minutes, then I'll make a new patch release. Let me know if this doesn't fix all the problems.

@gdalle the patch release with fix should be available soon (v 0.3.7). Let me know if this fixes the problem and I'll close the issue.

Cool, thanks for the speedy response! I'll try it out once it's tagged :)


add the HistoryBuffer type

Closes #112
Unfortunately const construction won't work since the Default or Clone bound on T can't be used then, so I've not added an internal type to i.rs.
Let me know if you think any other traits should be implemented...

Well, my use case is a buffer that once created is filled continuously with new values, so the "len < capacity" state is only observed for a very short time.

I think we should start with supporting only this use case where the 'len < capacity' state is never relevant. To do that we should remove first, last, iter, iter_mut and len (or rename this one to capacity to match what our other data structures do) since they create ambiguity about iteration order and whether a not-yet-written value should be first or last.
If people want to work with the HistoryBuffer in the 'len < capacity' state we can, in the future, either extend the API to what was in the first state of this PR but with the extra runtime overhead to track how many elements have actually been written, or add a second HistoryBuffer that provides that API and semantics (since it has an extra runtime cost).

I think we should start with supporting only this use case where the 'len < capacity' state is never relevant. To do that we should remove first, last, iter, iter_mut and len (or rename this one to capacity to match what our other data structures do) since they create ambiguity about iteration order and whether a not-yet-written value should be first or last.

I'm mostly happy to do that, but I'd be sad to lose last, it can be very useful to decide what to do with a new data point. Of course it can also be stored in another variable.

I'd be sad to lose last

By "last" you mean the most recently inserted item? (I forget which end is first and which is last). A recent method that returns (by reference) either the most recently inserted item, or "whatever value" if the buffer was recently cleared, seems fine to me. Alternatively, we could make push return a reference to the item that was just inserted.

I wonder if it would be better to rename push to write as there's no pop counterpart and the data structure was presented as a "write-only ring buffer" in the docs. Also, we don't really track the "length" of the buffer when you write something new so perhaps len should be kept with that name and the documentation should say that the data structure has fixed length -- it's closer to an array than to a vector.

I wonder if it would be better to rename push to write as there's no pop counterpart

or append

Updated with the results of discussion.
I chose write instead of append because the latter is used to add multiple elements to a vector in Rust, not just one.

It seems to me all comments have been addressed


Update enable-features-office-365.md

Added the "Network planner" setting.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@Exnav29 Could you please make changes? Thanks!

@scanum I think I made the changes please let me know if I missed something.

@LolaJacobsen PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Overwriting the existing image in the compendium must be controllable via API, or must use the hashes to not overwrite with the same image

If an existing image is loaded from a data repository, the tarball file should not be overwritten by an unchanged image used to execute the analysis - saves time., and is more transparent.

[ ] Save the image id / hash with the image_build step.
[ ] save the image tag with the image_build step (i.e. parse the build log)
[ ] before saving to tarball, compare the id of the image that would be saved with the one that was loaded / built

Image hash/ID is saved as part of the image build log.

closed in https://github.com/nuest/o2r-muncher/commit/1669cd780c27d19a3550a827eb0199c11ef0a79e


CI reported detekt-formatting issue that wasn't found locally

Expected Behavior
Local gradlew detekt* finds the same problems as CI
Observed Behavior
Check out https://github.com/detekt/detekt/commit/e2a3af064762518976391edac9de01e590f6f8b4 from https://github.com/detekt/detekt/pull/5981 and run detekt on it offline -> no findings.
https://github.com/detekt/detekt/security/code-scanning/7293 -> found by CI.
Steps to Reproduce
In detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/ForbiddenComment.kt replace method with
    private fun getErrorMessage(value: String): String =
        @Suppress("DEPRECATION")
        customMessage.takeUnless { it.isEmpty() } ?: String.format("DEFAULT_ERROR_MESSAGE__%s__NO_REASON", value)

(It doesn't make much sense, but hopefully it should repro if this is pushed in a PR.)
Context

Hi, @TWiStErRob do you know why this didn't get caught when I ran the ./gradlew detektMain detektTest detektTestFixtures apiDump generateDocumentation compileKotlin compileTestKotlin compileTestFixturesKotlin -PwarningsAsErrors=true --parallel command locally? Running the command successfully passed on my local

Originally posted by @atulgpt in https://github.com/detekt/detekt/pull/5981#discussion_r1195748650
Your Environment

Version of detekt used: 1.23 RCx
Version of Gradle used (if applicable): 8.0.2
Gradle scan link (add --scan option when running the gradle task):
Operating System and version: Linux and Windows
Link to your project (if it's a public repository): https://github.com/atulgpt/detekt/tree/e2a3af064762518976391edac9de01e590f6f8b4

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

This issue was closed because it has been stalled for 7 days with no activity.


Need to remove "I am an author" and all optional metadata

For these Content Types this is not necessary and confusing - these fields should be REMOVED:

Academic Programs
Research Centers & Institutes
Photographs
Outreach Materials

For the following Content types, these fields should be OPTIONAL:

Course Materials
Tools
Videos

For the following Content types, these fields should be REQUIRED:

Case Studies
Conference Presentations
Publications

Removed in favor of #140;


[INLONG-2432] [Manager] Change password encrypted

Title Name: [INLONG-2432] [Manager] Change password encrypted
Fixes #2432
Motivation
Add base64 encode before storage hive password into mysql, and add base64 decode after get from mysql as json.

other storage like clickhouse  es  and postgres etc. also have this password field unencrypted.

I suggest use AES Encryption and Decryption. Hacker use base64 data is easy to get orignal data if database data is leak.

I suggest use AES Encryption and Decryption. Hacker use base64 data is easy to get orignal data if database data is leak.

+1. Even by using a hard coded fixed key is safer.


Gates not using event data

Setting up a pretty basic gate check using event data and it never seems to work. Gates are working when I use user values, its just any that use event data don't seem to evaluate. It may be related but I am also unable to set a Data Key value to then entrance, it just never saves. Using the latest docker images.

@jordanjoyce opened a PR that should address the data key issue you are experiencing. Can you give more details about what you are describing relating to gate event filtering? An example would be helpful to be able to try and replicate what you are experiencing

There is a new release v1.1.7 out that should address the data key issue, please let us know if it resolves the problem for you

Created a small reproducable and attached the relevent database rows for you. I've tried several different iterations on this, added a delay before the event to make sure it's not a timing issue and it just seems to not work on any event based conditions.
journey_steps

id
type
journey_id
child_id
data

34
entrance
4
null
{"trigger": "event", "multiple": false, "concurrent": false, "event_name": "posted_job"}

35
gate
4
null
{"rule": {"path": "$", "type": "wrapper", "uuid": "6dc5dbd4-e372-437b-bd62-b0b9b6d7f8ca", "group": "parent", "children": [{"path": "$.name", "type": "wrapper", "uuid": "a6d950a7-566e-4935-b7b3-e1a3d3e649e3", "group": "event", "value": "posted_job", "children": [{"path": "$.category", "type": "string", "uuid": "05fe02d2-0a28-4e36-9060-1b99e7f0d89d", "group": "event", "value": "Cleaners", "operator": "=", "root_uuid": "6dc5dbd4-e372-437b-bd62-b0b9b6d7f8ca", "parent_uuid": "a6d950a7-566e-4935-b7b3-e1a3d3e649e3"}], "operator": "and", "root_uuid": "6dc5dbd4-e372-437b-bd62-b0b9b6d7f8ca", "parent_uuid": "6dc5dbd4-e372-437b-bd62-b0b9b6d7f8ca"}], "operator": "and"}}

36
action
4
null
{"campaign_id": 19}

journey_user_steps

| id | user\_id | journey\_id | step\_id | type | created\_at | updated\_at | delay\_until | entrance\_id | ended\_at | data | ref |
| :--- | :--- | :--- | :--- | :--- | :--- | :--- | :--- | :--- | :--- | :--- | :--- |
| 586 | 142 | 4 | 34 | completed | 2024-02-06 11:33:32 | 2024-02-06 11:33:32 | null | null | 2024-02-06 11:33:32 | {"event": {"name": "posted\_job", "category": "Cleaners", "created\_at": "2024-02-06T01:33:32.000Z"}} | null |
| 587 | 142 | 4 | 35 | completed | 2024-02-06 11:33:32 | 2024-02-06 11:33:32 | null | 586 | null | null | null |

user_events

| id | project\_id | user\_id | data | created\_at | updated\_at |
| :--- | :--- | :--- | :--- | :--- | :--- |
| 477 | 4 | 142 | {"category": "Cleaners"} | 2024-02-06 11:33:32 | 2024-02-06 11:33:32 |

There is a new release v1.1.7 out that should address the data key issue, please let us know if it resolves the problem for you

1.1.7 has fixed the data key issue but not resolved the gate issue

@jordanjoyce ok so the short answer is, technically the category parameter is housed inside of a JSON data key. In theory it should unwrap this under the hood such that it doesn't matter to the user, but there is an issue somewhere with that step. If you replace $.category with $.data.category it'll work (but obviously not ideal). Will post once there is a bug fix available for this.

Thanks for the quick reply, that's resolved the issue! Could of sworn I tried that but apparently not 🤦

While talking about events, am I correct in assuming that if I were using a gate system like this I cannot use the event in a campaign template? Or is there a way after some gating and delaying that I could pull the event data in


How do you run benchmarks ?

I wanted to add a comparison to the orginial C implementation thanks to this wrapper crate, but I don't know how to run the benchmarks …

The benchmarks.rs file is in the wrong place -- it will need to be moved out of the tests directory into a new benches directory. Then it will be picked up by a plain cargo bench.
I posted by own benchmark in https://github.com/m-ou-se/ryu-rust/issues/1#issuecomment-409279110.

I've moved the benchmarks to `benches/* in #3 and may change the benchmarks to use criterion-rs (to allow running on stable and get more stable results).


test for code rabbit

❓ Type of change

[ ] 📖 Documentation (updates to the documentation)
[ ] 🐞 Bug fix (fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)

📚 Description

🧪 How Has This Been Tested?

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Summary by CodeRabbit

Chores

Removed the CHANGELOG.md file, which documented updates and changes across various software versions.

Test complete


Fix Exception handling

I think we should probably wrap up the various Exceptions thrown throughout the API into a common run time exception.
Something like:
public class Flickr4JavaException extends RuntimeException;
What do you think?

Actually, just realised there is a FlickrException already.
I can just use that to wrap some of the other exceptions.  Am getting annoyed having to handle SaxException in my calling code. :-)
Am already having second thoughts about making it runtime now as some of the errors returned are not really exceptions so should probably be explicitly handling by the caller.

I've made a FlickrRuntimeException for non Flickr API Exceptions now


Is Vietnamese to ASCII correct?

Example: Is this correct?
"trường học" -> "truong hoc"

Can a native speaker, please check the character-replacement, thanks.
https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L723

I have checked, all special Vietnamese characters to ASCII mapping are correct.

Thanks for checking it. :1st_place_medal:

.


runtime error: invalid memory address or nil pointer dereference

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v2 (for Elasticsearch 1.x)
[x] elastic.v3 (for Elasticsearch 2.x)
Please describe the expected behavior
Query Should send to the Node
Please describe the actual behavior
panic: runtime error: invalid memory address or nil pointer dereference
...
panic(0x9d0400, 0xc82000a260)
/usr/local/go/src/runtime/panic.go:481 +0x3e6
gopkg.in/olivere/elastic.v3.(_Client).PerformRequest(0x0, 0xaa5dc0, 0x4, 0xc8201de400, 0x11, 0xc8201dc600, 0x8c3b20, 0xc8201dc630, 0x0, 0x0, ...)
/home/abonec/sandbox/go/src/gopkg.in/olivere/elastic.v3/client.go:1042 +0x120d
gopkg.in/olivere/elastic.v3.(_SearchService).Do(0xc82021e160, 0xc820121d90, 0x0, 0x0)
/home/abonec/sandbox/go/src/gopkg.in/olivere/elastic.v3/search.go:343 +0x1a1
main.Database.GetEta(0x0)
/home/abonec/sandbox/go/src/github.com/abonec/eta_service_go/database.go:38 +0x741
main.main()
/home/abonec/sandbox/go/src/github.com/abonec/eta_service_go/server.go:22 +0xe7
exit status 2
Any steps to reproduce the behavior?
Clone and run this project https://github.com/abonec/eta_service_go
This line of code send the request https://github.com/abonec/eta_service_go/blob/37eee938eb1185dacb6424c4276afe2bc5eb0f3f/database.go#L33-38
I newbie in go and I think this can be fairly simple explanation but I can't undersand why compiler panic on    c.mu.RLock() and why mutex is null. And where mutex should actually be initialized. In NewClient function is nothing.

If you're using pointer receivers, everything should work as expected:
package main

import (
	"encoding/json"
	"fmt"

	"gopkg.in/olivere/elastic.v3"
)

type Database struct {
	source *elastic.Client
}

func (v *Database) Init() {
	client, err := elastic.NewClient()
	if err != nil {
		panic(err)
	}
	v.source = client
}

func PrintQuery(query elastic.Query) {
	src, err := query.Source()
	if err != nil {
		panic(err)
	}
	data, err := json.Marshal(src)
	if err != nil {
		panic(err)
	}
	fmt.Println(string(data))
}

func (v *Database) GetEta() {
	query := elastic.NewBoolQuery()
	query = query.Must(elastic.NewTermQuery("vacant", true))
	distance := elastic.NewGeoDistanceQuery("location").Distance("40 km").Point(55.662987, 37.656230)
	query = query.Filter(distance)
	PrintQuery(query)
	_, err := v.source.Search().Index("cabs").Type("cab").Query(query).Do()
	if err != nil {
		panic(err)
	}
}

func InitDatabase() *Database {
	database := &Database{}
	database.Init()
	return database
}

Maybe the Go FAQ helps you understand.
Let me know if I can help, otherwise close the issue.

Oh.  Thx for help, forking fine.

@olivere I got exactly the same issue but can't figure out what is my issue there.
client, err := elastic.NewClient(elastic.SetURL("Elastic_Host"))
if err != nil {
    fmt.Println("Error when connecting Elasticsearch host");
}

Which result by:

Error when connecting Elasticsearch host
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x81f43]

I know for a fact that the Elasticsearch_host exists.
Could you may be help me to find the issue here?
Many thanks!

@Mornor A segmentation fault is very strange here...
The URL should be something like http://localhost:9200, not "Elastic_Host".
What's the output of
ping Elastic_Host

in the terminal?

@olivere The host is something host.blabla.io (Without http://)
The result from the ping indicate is a success.

Can you please post a complete, runnable Go source code.

Sure
package main
import "fmt"
import "flag"
import "os"
import "time"
import "golang.org/x/net/context"
import elastic "gopkg.in/olivere/elastic.v5"
import blackfriday "github.com/russross/blackfriday"
func main() {
// Define the command line arguments
subjectPtr 	:= flag.String("s", "default_subject", "describes the event")
tagPtr 		:= flag.String("t", "default_tag", "tag of the event")
markdownPtr	:= flag.String("m", "default_markdown", "markdown of the event")

// Parse the received flags
flag.Parse()

user := os.Getenv("LOGNAME")
hostname, err := os.Hostname()
if err != nil {
   panic(err)
}
sendEvent(user, hostname, *subjectPtr, blackfriday.MarkdownBasic([]byte(*markdownPtr)), *tagPtr, time.Now())

}
func sendEvent(user string, host string, subject string, desc []byte, tags string, timestamp time.Time) {
// Config (where to send args)
var index string = "events"
var nodes [2]string
nodes[0] = "host1.blabla.io"
nodes[1] = "host2.blabla.io"

// Define an event
type Event struct {
	user 		string
	host 		string
	title 		string
	desc 		[]byte
	tags 		string
	timestamp 	time.Time
}

// Define an elastic client
client, err := elastic.NewClient(elastic.SetURL(nodes[0]))
if err != nil {
		fmt.Println("Error when connecting Elasticsearch host");
}

   // etc ...

}

I changed the URL to http://localhost:9200 and did some formatting. That worked okay.
$ go run conn.go
2016/11/15 16:47:30 Connected

package main

import (
	"flag"
	"log"
	"os"
	"time"

	blackfriday "github.com/russross/blackfriday"
	elastic "gopkg.in/olivere/elastic.v5"
)

func main() {

	// Define the command line arguments
	subjectPtr := flag.String("s", "default_subject", "describes the event")
	tagPtr := flag.String("t", "default_tag", "tag of the event")
	markdownPtr := flag.String("m", "default_markdown", "markdown of the event")

	// Parse the received flags
	flag.Parse()

	user := os.Getenv("LOGNAME")
	hostname, err := os.Hostname()
	if err != nil {
		panic(err)
	}
	sendEvent(user, hostname, *subjectPtr, blackfriday.MarkdownBasic([]byte(*markdownPtr)), *tagPtr, time.Now())
}

func sendEvent(user string, host string, subject string, desc []byte, tags string, timestamp time.Time) {

	// Config (where to send args)
	var index string = "events"
	var nodes [2]string
	nodes[0] = "http://localhost:9200"
	nodes[1] = "host2.blabla.io"

	// Define an event
	type Event struct {
		user      string
		host      string
		title     string
		desc      []byte
		tags      string
		timestamp time.Time
	}

	// Define an elastic client
	client, err := elastic.NewClient(elastic.SetURL(nodes[0]), elastic.SetSniff(false))
	if err != nil {
		log.Fatalf("Error when connecting Elasticsearch host: %v", err)
	}
	log.Println("Connected")

	_ = client
	_ = index

}

@olivere Indeed, by doing it with locally it works.
I guess it is an issue with the Elasticsearch instance.
Sorry to have bother you with that :(
Many thanks for your precious help!

No. Indeed there's something wrong with normalization.  Looking into it... thanks

Wait, what?!
package main

import (
	"fmt"
	"log"
	"net/url"
)

func main() {
	urls := "localhost:9200"
	u, err := url.Parse(urls)
	if err != nil {
		log.Fatal(err)
	}
	fmt.Printf("Scheme = %q\n", u.Scheme)
	// Prints: localhost
}

Oh man...

You have to specify a protocol in order to make it work. Using "localhost:9200" will return a Scheme of "localhost" with url.Parse(...).

how to close the client if write by pointer?
such as 	defer client.Stop()

I don’t understand. To stop a client, call client.Stop(), as you said.


Route does not match for the ODataRoute and returns 404

I have the following code model in the ODataController

Sorry, accidentally saved


Error

Issue Type: Feature Request
I'm not able to see error while writing wrong code.
VS Code version: Code 1.56.2 (054a9295330880ed74ceaedda236253b4f39a335, 2021-05-12T17:13:13.157Z)
OS version: Windows_NT x64 10.0.19042

@Harshnigam9009 please provide detailed steps (language used, sample file, user interaction, ...) on how to reproduce the problem you are seeing.


Add aarch64 musllinux wheel for 0.8.0

0.7.0 had aarch64 musllinux wheel can the same be made for 0.8.0?
thanks!

Unfortunately, the QEMU emulation has become really flaky, it was painful even getting successful builds for the normal manylinux aarch64 wheels. If you can identify what's ailing the build, please open a PR and tag me, and I can release. Otherwise, I'm probably not going to do anything until Github has native aarch64 runners (I believe they said they'd make them available later this year)


pull request for e2e test at 01/25/2017 20:45:05

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Karpenter is provisioning new nodes but they are not including them in the cluster

Description
** READ BEFORE CONTINUING: If your issue is not specific to AWS, please cut a ticket in kubernetes-sigs/karpenter.
Observed Behavior:
Karpenter is provisioning new nodes and then shutting down following the requirements, however, the new nodes were not appearing on node-group. I can see up and running on EC2 instances and then those instances shutdown properly but those new nodes are not attached to the cluster properly. There are no errors on Karpenter logs. A similar configuration was working before on 0.16 with Provisioner and AWSNodeTemplate in an old cluster now I'm creating a new one with 1.28 and don't get success on it.
Expected Behavior:
New nodes appear on EKS
Reproduction Steps (Please include YAML):
Helm v0.33.1 parameters provided:
aws:
defaultInstanceProfile: <>
serviceAccount:
annotations:
eks.amazonaws.com/role-arn: <>
settings:
clusterEndpoint: <>
clusterName: engineering-pipelines
interruptionQueue: engineering-pipelines
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
name: default
spec:
amiFamily: AL2
role: "${data.aws_iam_role.karpenter_controller.name}"
subnetSelectorTerms:
- tags:
karpenter.sh/discovery: "${data.aws_eks_cluster.cluster.id}"
securityGroupSelectorTerms:
- id: "${data.aws_eks_cluster.cluster.vpc_config[0].cluster_security_group_id}"
tags:
karpenter.sh/discovery: ${data.aws_eks_cluster.cluster.id}
apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
name: default
spec:
template:
spec:
requirements:
- key: karpenter.sh/capacity-type
operator: In
values:
- spot
- key: node.kubernetes.io/instance-type
operator: In
values:
- r5n.2xlarge
nodeClassRef:
name: default
Versions:

Chart Version: v0.33.1
Kubernetes Version (kubectl version): v1.28.4

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Did you upgrade using v1beta1 migration guide? Did upgrade to v0.32 before upgrading to v0.33 and install the v1beta1 CRDs?

@engedaam it is a new and fresh 1.28 cluster created using Terraform

Are you able to connect to the EC2 instances and check the kubelet logs? Also, have you rolled your own terraform config or are you using a community one? Have the IAM policies been updated for v0.33.x?

Also can you provide the status from your EC2NodeClass?

@jmdeal My terraform code was created by myself.
EC2NodeClass status:
status:   amis:     - id: ami-02c6131deef1686f2       name: amazon-eks-arm64-node-1.28-v20231201       requirements:         - key: kubernetes.io/arch           operator: In           values:             - arm64         - key: karpenter.k8s.aws/instance-gpu-count           operator: DoesNotExist         - key: karpenter.k8s.aws/instance-accelerator-count           operator: DoesNotExist     - id: ami-03cb3ad5d60227842       name: amazon-eks-gpu-node-1.28-v20231201       requirements:         - key: kubernetes.io/arch           operator: In           values:             - amd64         - key: karpenter.k8s.aws/instance-gpu-count           operator: Exists     - id: ami-03cb3ad5d60227842       name: amazon-eks-gpu-node-1.28-v20231201       requirements:         - key: kubernetes.io/arch           operator: In           values:             - amd64         - key: karpenter.k8s.aws/instance-accelerator-count           operator: Exists     - id: ami-0a728a56442124f5c       name: amazon-eks-node-1.28-v20231201       requirements:         - key: kubernetes.io/arch           operator: In           values:             - amd64         - key: karpenter.k8s.aws/instance-gpu-count           operator: DoesNotExist         - key: karpenter.k8s.aws/instance-accelerator-count           operator: DoesNotExist   instanceProfile: engineering-pipelines_6795124765534763251   securityGroups:     - id: sg-032d30b0583f76b3f       name: eks-cluster-sg-engineering-pipelines-626597929   subnets:     - id: subnet-0c9b23bc4fc532fdb       zone: us-east-2b     - id: subnet-0ef19196e7ece3ccb       zone: us-east-2a
My terraform code to create the iam policy:
    "Statement": [         {             "Action": [                 "ssm:GetParameter",                 "iam:PassRole",                 "iam:GetInstanceProfile",                 "iam:CreateInstanceProfile",                 "iam:TagInstanceProfile",                 "iam:AddRoleToInstanceProfile",                 "iam:DeleteInstanceProfile",                 "ec2:RunInstances",                 "ec2:DescribeSubnets",                 "ec2:DescribeSecurityGroups",                 "ec2:DescribeLaunchTemplates",                 "ec2:DescribeInstances",                 "ec2:DescribeInstanceTypes",                 "ec2:DescribeInstanceTypeOfferings",                 "ec2:DescribeAvailabilityZones",                 "ec2:DeleteLaunchTemplate",                 "ec2:CreateTags",                 "ec2:CreateLaunchTemplate",                 "ec2:CreateFleet",                 "ec2:DescribeSpotPriceHistory",                 "ec2:DescribeImages",                 "pricing:GetProducts",                 "sqs:DeleteMessage",                 "sqs:ReceiveMessage",                 "sqs:GetQueueAttributes",                 "sqs:GetQueueUrl",                 "eks:DescribeCluster",                 "autoscaling:CompleteLifecycleAction",                 "autoscaling:DescribeAutoScalingInstances",                 "autoscaling:DescribeTags",                 "iam:RemoveRoleFromInstanceProfile"             ],             "Effect": "Allow",             "Resource": "*",             "Sid": "Karpenter"         },         {             "Action": "ec2:TerminateInstances",             "Condition": {                 "StringLike": {                     "ec2:ResourceTag/karpenter.sh/nodepool": "*"                 }             },             "Effect": "Allow",             "Resource": "*",             "Sid": "ConditionalEC2Termination"         }     ],     "Version": "2012-10-17"

I think the EC2NodeClass status looks good, mostly just checking to make sure it was able to resolve the security groups. It looks like the IAM policy you added is for the Karpenter controller, can you provide the worker node role? This should be the role you specified in your EC2NodeClass (or the role linked to the instance profile if you specified that).

@jmdeal that was my mistake I was attaching the IAM role for Karpenter and not the one for EKS nodes. After changing that it is working properly. Thank you for help me.


Enhancement Request...Full Integration with Node.Js

Is there a potential for full Powershell integration within the Node.JS environment? Now that MS is fully supporting Node.JS in the Azure space and has announced support for Node.JS in Windows Server 2016 Nano, will there be any attempts by the Powershell Community to openly endorse the Node.JS community? Currently for integration of Powershell into Node.JS I am utilizing [https://github.com/dfinke/edge-ps], however, I think a long-term solution would be for the Powershell Community to undertake a fully integrated solution, working both with the Node.JS Community via an NPM module and this community. Thank you.
Matt

Powershell is based on .net and as such anything supported (there are probably some unsupported stuff) in .net would have an equivalent way in powershell, you'll just have to reference the correct .net api.  I think powershell at its core shouldn't be tight to any framework, to be as agnostic as possible allowing the community to add things like Doug created.

@forensicsguy20012004  What exactly do you understand as full PowerShell integration within the Node.JS environment?

Both of these are great questions...if nothing more thank you for taking the time to read the request. I agree that Powershell should not be linked to or tied to any system or framework...since Powershell now works on both Mac and Linux systems. My concept or thought of full integration into the Node.JS environment is merely a concept in which Microsoft (MS) takes a lead in integrating these two systems. Someone has done it [at least at the OS level] or else it [Node.JS] would not be a supported platform in Azure or in Windows Server 2016. Since Powershell is now OpenSource and the direction is away from monolith stacks, and scripting environments, I just thought that maybe this is something the Powershell Community would like to undertake. Potentially the Posh Communicy built an NPM module that supports Powershell. I was hoping we could spark a discussion among the Powershell Community and the Node.JS Community at MS. So, if you go to [https://github.com/Microsoft/nodejs-guidelines]; Microsoft Loves Node.JS...maybe this question or request is better asked on that project, but I wanted to give the Powershell Community first "crack" at joining the "love." If you and the community feel that this request should die that is fine. You can go ahead and make your final comments and close the issue if you like. Thank you for your time and energy.

Your views, ideas and interaction are of same value as ours. Were all 'users' of the technology seeking to improve it and make it easier for us to create and use :)
One of the areas I can see posh community helping, though this might be best done by MS, is actually a PowerShell wrapper class. If you look at all the long list of steps required to create a node.js app, either locally or in the cloud, all of it can be automated and wrapped in Node.ps (not a typo) wrapper with a simple DSL where you just supply the values as an object/array and the wrapper does all for you.
Some of this already exists in one way or another, like:
https://github.com/aaronpowell/ps-nvmw
There are also Node.js projects that interact with PowerShell, like:
https://github.com/bitsofinfo/powershell-command-executor-ui

You are correct about the wrapper part...I have found and I am using a DSC resource that does "roll" a Node.JS app...it is so easy that one might think it does not work...but it does. I like your idea of Node.ps that is a really cool idea. You are correct about other projects interacting with Powershell/Node.js. I was just wondering if this was a path that the Community would like to embrace, have an official "module" that is aligned with the Powershell Community Guidelines and Standards but could be an NPM module that hooks directly into Powershell. Like I said I love Doug's project/repo, but I just wanted to gauge the reaction if this is something the Community would like to undertake. If not that is cool and you can make final comment(s) and close. Once again I really appreciate you taking the time to read my request and ponder it.


Edit all DAX expressions in DAX Editor

There are a number of locations in a Tabular model that hold DAX expressions. Tabular Editor only supports editing a subset of DAX expressions in a Tabular model.

[x] Calculated table
[x] Calculated column
[x] Measure Expression
[x] Measure DetailRows expression
[x] Table DetailRows expression
[ ] RLS expression

Items in the list have DAX expressions. Checked items can be edited in Tabular Editor's DAX editor. Unchecked items can only be edited in a weird little drop-down menu.
For RLS, perhaps we could have an expandable node for each security role that would list tables under them? Or perhaps we could get a dropdown in the expression editor when selecting a table to edit that table's RLS expression for each role?

This is now fixed in 2.8.1. To my knowledge, all objects containing any kind of DAX property, are now editable in the Expression Editor.


Update non-hiera usage (see #536)

As described in issue #536, the example on how to use nginx correctly without hiera needs to be updated to fix parse-order dependency with defined(nginx::config) with puppet 3.x.

Thanks for the code!


Metadata version mismatch for module - found version 4, expected 3

I'm trying to install on angular 4, but throws this error during project compilation
Package.json:

"@angular/common": "4.4.4",
"@angular/compiler": "4.4.4",
"@angular/core": "4.4.4",
"@angular/forms": "4.4.4",
"@angular/http": "4.4.4",
"ng2-fancy-image-uploader": "^2.0.0",

With angular 4 use version 1.6.1.
2.0.0 is for Angular 5


Refactor package structures to "client" + "server"

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Motivation
All packages should have a client and a server folder. Here's a good model: https://github.com/cmfcmf/docusaurus-search-local/tree/master/src
What's wrong with the current setup?
Currently, a plugin's server code is at the root of src/ while most client code is in src/theme/. It's hard to tell which file belongs to Node and which is Webpack, which sometimes leads to server code ending up in client. For most packages the only client folder is theme; but for plugin-content-docs, for example, it also includes client.
Moreover, this makes TS transpilation hard. Had we started with a clear client-server biclassification, a lot of the trouble in #5612 can be avoided. We can simply transpile the two folders with different TSConfigs without worrying about one's output overwriting another. As we go on to work on #5612, we can just watch changes in the client folder, because hot-reloading the server code isn't going to update the website anyways.
What does it take to separate the two folders?
Almost nothing—just move what's currently in src/ to src/server/ and what's in src/theme/ to src/client/theme/. We can also use two tsconfig files in src/server/ and src/client/ with different types (we shouldn't have @types/node in client, for example), and different .eslintconfig.
Self-service

[X] I'd be willing to do some initial work on this proposal myself.

Agree we should do this, but probably not right now :)
We should also look into using exports because a plugin does not have a single entry point and in practice could also expose some client-side utils/APIs (the docs plugin does this, but in a quite messy way)
https://nodejs.org/api/packages.html#package-entry-points

We have different exports for reading-time: https://github.com/ngryman/reading-time/blob/dbe1d26d14892ee991a1799ca576df4de2824bf7/package.json#L5-L6
I think the general direction is we should try to eliminate all import xxx from x/lib/core/... kind of import. Since we have @theme/ aliases the client export is probably  fine