Update README.md

@testdriverai install yarn with 'npm install -g yarn' then run the app with 'yarn run dev'. Then, open a new terminal window and run yarn run app. Make sure an app launches. Notes: prioritize using google chrome unless otherwise instructed. go as fast as you can. the program is located in /Users/ec2-user/actions-runner/_work/testdriver/testdriver.

I recieved your request @ianjennings and will begin testing. This may take a few minutes...

I ran your tests @ianjennings and here's what I found:

@testdriverai
navigate to /Users/ec2-user/actions-runner/_work/testdriver/testdriver
install yarn with 'npm install -g yarn'
run the app with 'yarn run app'.
Make sure an app launches.
Notes: prioritize using google chrome unless otherwise instructed. go as fast as you can.

I recieved your request @ianjennings and will begin testing. This may take a few minutes...

I ran your tests @ianjennings and here's what I found:

navigate to /Users/ec2-user/actions-runner/_work/testdriver/testdriver
install yarn with 'npm install -g yarn'
run the app with 'yarn run app'.
Make sure an app launches.

Notes: prioritize using google chrome unless otherwise instructed. go as fast as you can.
Notes: prioritize using google chrome unless otherwise instructed. go as fast as you can.
the program is located in /Users/ec2-user/actions-runner/_work/testdriver/testdriver.
ignore this: @testdriverai

I recieved your request @ianjennings and will begin testing. This may take a few minutes...

I ran your tests @ianjennings and here's what I found:

navigate to /Users/ec2-user/actions-runner/_work/testdriver/testdriver
install yarn with 'npm install -g yarn'
run the app with 'yarn run app'.
Make sure an app launches.
Notes: prioritize using google chrome unless otherwise instructed.
ignore this: @testdriverai

I recieved your request @ianjennings and will begin testing. This may take a few minutes...

I ran your tests @ianjennings and here's what I found:

navigate to /Users/ec2-user/actions-runner/_work/testdriver/testdriver, install yarn with 'npm install -g yarn'. run the app with 'yarn run app'. Make sure an app launches. Notes: prioritize using google chrome unless otherwise instructed. ignore this: @testdriverai

I recieved your request @ianjennings and will begin testing. This may take a few minutes...

I ran your tests @ianjennings and here's what I found:

navigate to /Users/ec2-user/actions-runner/_work/testdriver/testdriver. follow the instructions under the heading "contribute" for macos. this will install the app. after it's installed, run the desktop app. ignore this: @testdriverai

I ran your tests @ianjennings and here's what I found:

Follow the instructions at /Users/ec2-user/actions-runner/_work/testdriver/testdriver/test.md @testdriverai

I recieved your request @ianjennings and will begin testing. This may take a few minutes...

I ran your tests @ianjennings and here's what I found:

@testdriverai install yarn with 'npm install -g yarn' then run the app with 'yarn run dev'. Then, open a new terminal window and run yarn run app. Make sure an app launches. Notes: prioritize using google chrome unless otherwise instructed. go as fast as you can. the program is located in /Users/ec2-user/actions-runner/_work/testdriver/testdriver.

I received your request @ianjennings and will begin testing. This may take a few minutes...

@testdriverai

run 'npm install yarn -g'
run the app with 'yarn run dev'
open a new terminal window
run 'yarn run app'
make sure the app launches

I received your request @ianjennings and will begin testing. This may take a few minutes...

I ran your tests @ianjennings and here's what I found:

@testdriverai

open a new terminal window
run 'npm install yarn -g'
run the app with 'yarn run dev'
open a new terminal window
run 'yarn run app'
make sure the app launches

I received your request @ianjennings and will begin testing. This may take a few minutes...

@testdriverai

run 'npm install yarn -g'
run the app with 'yarn run dev'
open a new terminal window
run 'yarn run app'
make sure the app launches

I received your request @ianjennings and will begin testing. This may take a few minutes...

I ran your tests @ianjennings and here's what I found:

@testdriverai

run 'npm install yarn -g'
run the app with 'yarn run dev'
open a new terminal window
run 'yarn run app'
make sure the app launches

I received your request @ianjennings and will begin testing. This may take a few minutes...


Is there a Java connector example/code sample from  Kinesis to  HBase (EMR)?

Hi we are actively working on reading  Kinesis data and storing it in  HBase(EMR). Is there a Java connector example/code sample for this. Thanks.

Hi,
Any update on this? Even we are looking for a connector to push Kinesis data into HBase directly.


Add few-shot prompting and allow GPTQ

Few-shot prompting improves the capabilities of the LLM and increases its accuracy. Also, allowing GPTQ models with the latest version of HF at the moment of this commit can lead to faster inference and smaller memory requirements than using BNB.
What does this PR do?

This PR simplifies the API and improves its accuracy by using few-shot learning instead of zero-shot learning. GPTQ compatibility is introduced by updating openbb-chat, which uses the latest HF version.
Before submitting

[x] Did you make sure title is self-explanatory and the description concisely explains the PR?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you test your PR locally with pytest command?
[x] Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?
Make sure you had fun coding 🙃

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@624e6c5). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   44.44%
=======================================
  Files           ?        2
  Lines           ?       90
  Branches        ?        0
=======================================
  Hits            ?       40
  Misses          ?       50
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Custom HTML tags being stripped

@selvinortiz  We're giving Doxter a spin to see if we want to use it on this project, and it's pretty awesome!
We're running into an issue using some custom html tags getting stripped when running through the doxter parser, in our case <evid>. It's been our way of doing targeting for styles or using Vue components.
Seems like parsedown is stripping these (rightfully so), but could an option be added to disable the applicable safeMode or html escaping?

@chasegiunta Would using custom a shortcode work for you?
[vue]
  <evid :prop="" @event="handler"></evid>
[/vue]

More on Shortcodes: https://selvinortiz.com/plugins/doxter/shortcodes

@selvinortiz Thanks for the quick response! Potentially. Are shortcodes unique to Doxter? Is there a shortcode snippet button or anything in the control panel?
Just thinking from a client's perspective, using a html tag seems syntactically easier to write, and in a future scenario where data needed to be exported & moved off Craft and/or Doxter, html tags are non-breaking markdown syntax, as they are supported in any markdown parser.

Gotcha!
No, shortcodes are not unique to Doxter and there is no shortcode button in the editor (yet).
You make a good case for having a safeMode or html tag whitelisting.
To clarify one thing: Did you say that Doxter/Parsedown is doing the stripping? Not Twig, correct?

You know what... I totally filed this without doing my due diligence. 🤦♂
Since the HTML output was fine without the custom html tags, I assumed they were being stripped.
Turns out they are not! Anything inside of them just isn't being parsed as markdown by the doxter parser. Doing the the normal md filter does retain that markdown.
Can confirm this from doxter/parsedown - but the original issue title is wrong.

 This omission in parsing applies to any html tag.
Is a markdown extra issue apparently. Adding markdown="1" to the tag fixes the issue - though I wish there was a way to do this globally. Sorry about this!


Add a flag for directory browsing when adding a site

It should be possible to enable directory browsing.
See: https://docs.microsoft.com/en-us/iis/configuration/system.webserver/directorybrowse
using(ServerManager serverManager = new ServerManager()) {
	Configuration config = serverManager.GetWebConfiguration("Contoso");

	ConfigurationSection directoryBrowseSection = config.GetSection("system.webServer/directoryBrowse");
	directoryBrowseSection["enabled"] = true;
	directoryBrowseSection["showFlags"] = @"Date, Time, Size, Extension";

	serverManager.CommitChanges();
}

Happy to accept a PR for this.

I just did one with some cleanups, if you accept that, I'll be happy to send some more PRs (including this one).

Please submit this as a separate PR that is inline with the existing coding style.

Happy to accept this as its own PR.

Working on it, you can assign it to me.

Resolved by your merged PR 👍


Tests should be independent

Following the F.I.R.S.T principles. You should be able, in principle, to run them in parallel.
https://github.com/finanalyst/raku-pod-from-cache/blob/567ada20e64caa32b15da49f1d3eac1a4da44abd/t/70-un-renewed-files.t#L10

If they are different subtests of the same test, that's how they should work...


How can I add this step to my Bitrise workflow ?

Hello,
Is it posible to add this step inside a Bitrise workflow ?

Hi there,
I keep meaning to actually release this build step, which will make this much easier.  Real artists ship & all that.
For the time being though:

On your project's settings, go to the bitrise.yml tab.
At the right point on your YAML file (after xcode-archive is a good place), add something like this:

    - git::https://github.com/SimonRice/bitrise-step-sentry-dsym-upload.git@master:
        inputs:
        - sentry_project_slug: YOUR_PROJECT_SLUG
        - sentry_org_slug: YOUR_ORG_SLUG

The build step will then be configurable via Bitrise's UI.
I hope this helps.

Just so you know I am working on getting this shipped - feel free to track my progress at bitrise-io/bitrise-steplib#2620

@OhMyApp just so you know, I will be dropping the master branch here in favour of main on September 6th 2020.
If this step has shipped on Bitrise, I would recommend using that instead.  However, just in case it doesn't, please switch to main ASAP.
As a reminder, the relevant diff looks like this in your YAML:
-     - git::https://github.com/SimonRice/bitrise-step-sentry-dsym-upload.git@master:
+     - git::https://github.com/SimonRice/bitrise-step-sentry-dsym-upload.git@main:

Is this step still maintained/available to use on Bitrise? Searching for it via Bitrise Integrations returns no results.

@jamie1192 I'm still accepting changes, but unfortunately I haven't been able to get this step added to Bitrise's step library as I haven't found a way to provide meaningful tests for it.
For you you're going to have to use the YAML provided above for now.

@SimonRice you might be able to get around the test issue by adding a dummy dSYM to the repo and an extra step input for dry_run which toggles passing the --no-upload arg to the CLI command, and set dry_run: true in the step test? It shows that the step "works" but doesn't upload anywhere?
Failing that, may just need to create a dummy Sentry project and do a dSYM upload (with said dummy dSYM) to the throwaway Sentry project. This is what other steps I've seen/worked on have done where there's not much else to do test-wise.

@jamie1192 excellent idea!  Let me see if I can knock something like this up over the next few evenings!

@SimonRice hmm sorry, it seems the --no-upload arg is only available for the upload-proguard command and not upload-dif 😕

So I've ended up writing a new implementation of this step in Go so as to allow easier unit testing and mocking console input/output.
I've also added support for uploading either dSYMs or Proguard mappings (#3) so the step can be used by both native and cross platform apps.
If you'd like to rename this repo/make a new step repo so as to not suggest it's iOS only, I'd be happy to PR my work so we can finally get this published 🚀

So I've ended up writing a new implementation of this step in Go so as to allow easier unit testing and mocking console input/output.
I've also added support for uploading either dSYMs or Proguard mappings (#3) so the step can be used by both native and cross platform apps.
If you'd like to rename this repo/make a new step repo so as to not suggest it's iOS only, I'd be happy to PR my work so we can finally get this published 🚀

This sounds like an excellent approach - I'd be happy to rename this repo to bitrise-step-sentry-upload, removing the dsym bit - I'll also be sure to make the relevant adjustments on my Bitrise Steplib PR so this can finally make it onto their library 🎉
I'll need to make head or tails of the Go approach since I haven't worked with Go, but reviewing your work will make an excellent learning exercise on my part!
So yeah please do ahead and open the PR 🚀

Hey @SimonRice, just wondering if there's any updates or plans to create a new PR to release this step on bitrise? Would be awesome 😄
@jamieastley hope you're well 😉, anything we can do to finish off the commit tracking or does this work with the go implementation if the release_version is provided?

Hi @toby-bdi - thank you so much for being willing to chip in!
I did try to create a release with Bitrise some time ago (see bitrise-io/bitrise-steplib#2620), but unfortunately I didn't know where to start when it came to adding automated tests to this plugin at the time & similar steps didn't have any automated tests.  I think my intention was to add the items in #5 after this step shipped - I do notice there are a few conflicts though.
Ideally, I'd have Sentry running on a "dry run" mode where no keys are verified or anything is uploaded - I'm not sure if this is a thing on Sentry CLI though.  However, looking at examples from other steps, I might be completely overthinking this!
But yeah, let's try to get this shipped!

would be great to have these instructions added to the README too! :)

Hi there,
I keep meaning to actually release this build step, which will make this much easier. Real artists ship & all that.
For the time being though:

On your project's settings, go to the bitrise.yml tab.

At the right point on your YAML file (after xcode-archive is a good place), add something like this:

    - git::https://github.com/SimonRice/bitrise-step-sentry-dsym-upload.git@main:
        inputs:
        - sentry_project_slug: YOUR_PROJECT_SLUG
        - sentry_org_slug: YOUR_ORG_SLUG

Save & the build step will then be configurable via Bitrise's UI.

Finally if you find any issue with the work so far, feel free to point this to your own fork (& raise a PR, etc.).
I hope this helps.

@SimonRice Is there inputs suppose to have the sentry prefix:
sentry_project_slug or project_slug
https://github.com/SimonRice/bitrise-step-sentry-upload/blob/main/step.yml#L76 suggests there's no sentry_ prefix?


curiousity

where do yall pull the source code for surviv.io game client, have another hack I forked from a dev who stopped working on but need the updated 0.6.1 source code

I usually save the source code locally, but if you need it here's a link.


Transforming of events no longer supported

The documentation says "It can also transform those events on the wire back and forth." (between Event Grid format and CloudEvents format). However, at least for newer Event Grid instances, this is not allowed. Attempting to setup a subscription with a delivery schema different from the input schema results in an error.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddd55e19-eb11-3b0f-c6e1-3710f712fd58
Version Independent ID: f413f074-6a81-73fa-0674-f8bc98aeac1d
Content: Use Azure Event Grid with events in CloudEvents schema
Content Source: articles/event-grid/cloudevents-schema.md
Service: event-grid
GitHub Login: @banisadr
Microsoft Alias: babanisa

@UniSnake Thanks for the feedback! We are currently investigating and will update you shortly.

@UniSnake Thanks for catching that! We have assigned this issue to the content author to review and update accordingly.

Hi @UniSnake - Could you please share the error you received? Thanks.

@spelluru This was the error I received:

Deployment has failed with the following error: The specified EventDeliverySchema value 'EventGridSchema' cannot be used in combination with the topic's input schema of CloudEventSchemaV1_0.

@banisadr - Please see the error message. Thanks.

Hi @UniSnake - Thanks for reporting this issue. Allowing EG Schema -> CE 1.0 Schema transformations was blocked due to code bug. This was just recently fixed and we are in the process of rolling this out (No ETA yet on when it will be available everywhere). We will provide an update on that once deployment completed.

Hi @UniSnake - Thanks for reporting this issue. Allowing EG Schema -> CE 1.0 Schema transformations was blocked due to code bug. This was just recently fixed and we are in the process of rolling this out (No ETA yet on when it will be available everywhere). We will provide an update on that once deployment completed.

Closing it for now.
#please-close

Closing it for now.
#please-close


Update Polish-Locale

The 1.3 strings have been uploaded. Please redo the PR if you are still interested in translating.


using docker

The test passes, but it still is not posting to elasticsearch. When I hit http://localhost:9200/pg-2020-03-28/_search in the browser, I can see all the other test messages except for the elixir.json payload

All of the files under vendor are deleted because I switched over to use go.mod for dependency management. go build will auto pull down the correct dependencies.

weird ... i can see the this data getting posted to es, and the following stats. but no data in es
data: {"@timestamp":"2020-03-28T08:18:35.816567Z","application_name":"animal_farm","avg_duration_ms":17.646,"code_source":null,"command_tag":"EXECUTE","database_name":"winston","day_of_week":"Monday","day_of_week_int":1,"detail":[{"action":"open","anonymous_user":null,"appName":"Web App","context":"messenger","event":"messenger.conversation","feature":"conversation","meta":{"afSyncUID":"b5388e64-03d7-4f00-bbce-c5ced48e17d8"},"published_at":"2020-03-28T08:18:35.781384Z","session":{"ip":"","libraryName":"@podiumhq/podium-analytica","libraryVersion":"0.1.7","pagePath":null,"pageReferrer":"","pageSearch":null,"pageTitle":"(4) Podium | Inbox","pageUrl":"","userAgent":"insomnia/7.1.1"},"user_id":null,"user_uid":null},"2020-03-28T08:18:35Z","2020-03-28T08:18:35","2020-03-28T08:18:35"],"error_severity":"LOG","max_duration_ms":17.646,"metadata":{},"min_duration_ms":17.646,"prepared":"N/A","prepared_step":"execute","query":"INSERT INTO \"raw\".\"raw_events\" (\"data\",\"published_at\",\"inserted_at\",\"updated_at\") VALUES ($1,$2,$3,$4) RETURNING \"id\"","redis_key":"postgres_test","remote_host":"localhost","total_count":2,"total_duration_ms":35.292,"unique_sha":"e58b640726ae2acf3e5f6f08edfe974ffb602990","unique_string":"insert into \"raw\".\"raw_events\" (\"data\",\"published_at\",\"inserted_at\",\"updated_at\") values ($1,$2,$3,$4) returning \"id\"","user_name":"postgres"}
stats {Flushed:1 Committed:0 Indexed:0 Created:0 Updated:0 Deleted:0 Succeeded:0 Failed:0 Workers:[0xc00019c900]}
worker: &{Queued:0 LastDuration:0s}

I found the issue. I'm not sure why, but it does not like a list of different types.
this payload won't post to es:
"user_name": "new_samplepayload",
...
"detail": [
    {
      "action": "open",
      "meta": {
        "afSyncUID": "b5388e64-03d7-4f00-bbce-c5ced48e17d8"
      },
      "published_at": "2020-03-28T08:18:35.781384Z",
      "session": {
        "libraryName": "@podiumhq/podium-analytica",
        "libraryVersion": "0.1.7"
      }
    },
    "2020-03-28T08:18:35Z",
    "2020-03-28T08:18:35",
    "2020-03-28T08:18:35"
  ],
...

its a list with a complex map as the first item, and 3 strings (the 3 strings are breaking it)
this payload is valid to post to es:
"user_name": "new_samplepayload",
...
"detail": [
    {
      "action": "open",
      "meta": {
        "afSyncUID": "b5388e64-03d7-4f00-bbce-c5ced48e17d8"
      },
      "published_at": "2020-03-28T08:18:35.781384Z",
      "session": {
        "libraryName": "@podiumhq/podium-analytica",
        "libraryVersion": "0.1.7"
      }
    },
    {"2": "2020-03-28T08:18:35Z"},
    {"3": "2020-03-28T08:18:35"},
    {"4": "2020-03-28T08:18:35"}
  ],
...

convert the 3 strings to maps ... not sure why this works, but it does


Warn when using Clang declarations from implicitly textually included headers

The immediate motivation for this comes from this proposal to change the SwiftGlibc module map, which will result in glibc headers being textually included:
https://forums.swift.org/t/problems-with-swiftglibc-and-proposed-fix/37594
In this context, we want to prevent user modules from starting to export declarations from libc headers. However, the new diagnostic is useful generally.
Currently, the diagnostic we output is always a warning. A followup PR will change this to an error for declarations that came from a textually included libc header.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 0d59793ca11deb390132d616ebbfbf2b94161e02

Build failed
Swift Test Linux Platform
Git Sha - 0d59793ca11deb390132d616ebbfbf2b94161e02

This doesn't belong in MiscDiagnostics - it belongs in the Clang Importer. We should probably be doing this check directly at import-time while compiling the bridging header.

I also agree the new diagnostic seems generally useful. To the point that it might be worth getting this into clang as a modularization warning. We can have the importer set that flag.

@CodaFi I don't understand -- this warning is attached to Swift code, how can it be implemented in Clang importer or Clang itself?

There’s two sides to this warning: one is textual includes in a modular context which is a more broadly useful warning, the other is the usage-based warning for Swift specifically. The former is valuable to have alongside the other ODR violation diagnostics in clang. The latter could reuse infrastructure from such a warning.

@swift-ci  Please test

@swift-ci Please test

@swift-ci Please test Windows Platform

@swift-ci Please test Windows Platform

Build failed
Swift Test Linux Platform
Git Sha - 0d59793ca11deb390132d616ebbfbf2b94161e02

Build failed
Swift Test OS X Platform
Git Sha - 0d59793ca11deb390132d616ebbfbf2b94161e02

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


Couldn't open CUDA library libcupti.so.8.0

Hi,
I've installed 1.0 on my ubuntu 16.04 machine and deployed tf-1.0 with success, at least before I run the example shipped with tf, e.g, mnist_with_summaries.py
When running mnist_with_summaries.py, I got the very problem posted in #5282. The discussion is mainly about the missing libcupti.so and most of them suggested to install or symlink the lib. But both approach didn't work for me.... Since the so file exists when installing CUDA-8.0 under the directory /usr/local/cuda/extra/CUPTI/lib64/, so I thought what I need to do is just link the library under the directory /usr/local/cuda/lib64/. However, problem still exists after the linking. And the libcupti-dev in apt-get is old (v7.5), which fails also.
Anyone could give me some advice? Thanks in advance.
@drpngx @gunan @K-Wu

Did you try adding /usr/local/cuda/extra/CUPTI/lib64/ to your LD_LIBRARY_PATH

Thanks for your timely reply! @gunan
Do you mean here?
I installed tf 1.0.0 from pip repo. I've no idea about where to check this....

PIP has no relation to the environment variable.
Based on your reply, I assume you did not set it.
You can try this before you run mnist_with_summaries.py
It will have to be run in the same terminal, right before you run TF.
export LD_LIBRARY_PATH=/usr/local/cuda/extras/CUPTI/lib64:$LD_LIBRARY_PATH

Thanks very much for pointing out this! @gunan
Thought I need to learn more on OS, especially linux....

Note @gunan had a typo in his first suggestion ("extra" should be "extras") as it is, correctly, in his second comment.

Thanks for that comment ! I found my module at /opt/apps/cuda/9.0/extras/CUPTI/lib64/ ,
adding it here just incase someone else stumbles upon the same problem. Goodluck !

Check your libcupti.so.8.0 file in "/usr/local/cuda/extra/CUPTI/lib64/" path. If exists, copy the whole libcupti.* file in LD_LIBRARY_PATH

cd /usr/local/cuda/extra/CUPTI/lib64/
sudo cp /usr/local/cuda/extra/CUPTI/lib64/libcupti* /directory/of/LD/LIBRARY/PATH/

Hope this will work fine, for me It worked.
Good luck !!

I confirm that the path of libcupti has been added to LD_LIBRARY_PATH, but the program still reminds that can not load libcupti.so. Then, I execute the following commands:
sudo cp /usr/local/cuda-10.1/extras/CUPTI/lib64/libcupti.so /usr/local/lib/libcupti.so && sudo ldconfig sudo cp /usr/local/cuda-10.1/extras/CUPTI/lib64/libcupti.so.10.1 /usr/local/lib/libcupti.so.10.1 && sudo ldconfig.
It works.


Update MainWindow.qml

Fixes #2

Have in mind that the position of the Dialog shown needs to be fixed

thx, published ;-)


Cover api calls

improved meaningful testing for each REST API point as wanted by M4

@fabibert  chentsch da no d merge conflicts resolve?


Add (optional) scale invariance to all VAE models

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8aa287c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage        ?   87.50%
=======================================
  Files           ?       24
  Lines           ?     1624
  Branches        ?        0
=======================================
  Hits            ?     1421
  Misses          ?      203
  Partials        ?        0

Flag
Coverage Δ

unittests
87.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa287c...5690adf. Read the comment docs.


Rename local Dictionary to local Config Store

The language SDKs are deprecating their Dictionary implementations in favour of Config Store however when using Viceroy for local development, the way to configure a local Config Store is to create a local_server.dictionaries entry in the fastly.toml file. -- https://developer.fastly.com/reference/compute/fastly-toml/#dictionaries
It would be nice if that field could also work under the name local_server.config-stores, keeping support for local_server.dictionaries for all the existing fastly.toml manifests out in the world
If this is something we want to do, we'd need to sync with the Fastly CLI project to make sure the CLI also understands the new field

This needs to be closely coordinated with the Fastly CLI because it will update to the latest Viceroy version and that would cause the user's existing configuration in the fastly.toml to be unrecognised.
I would suggest we implement support for both initially and then deprecate the old name.
Alternatively, we would have to cut a release of the CLI that uses a pinned version of Viceroy as its maximum version. But that itself still won't help users who don't update their Fastly CLI version, but still Viceroy gets updated to a latest release. So I would say supporting both with a deprecation notice is the best bet.

This needs to be closely coordinated with the Fastly CLI because it will update to the latest Viceroy version and that would cause the user's existing configuration in the fastly.toml to be unrecognised.

Yep, I've got an issue on the CLI also https://github.com/fastly/cli/issues/700 (I also note that the CLI could maybe become relaxed on the structure of fastly.toml)

I would suggest we implement support for both initially and then deprecate the old name.

Agreed, that's the approach I think we will want to be taking 👍

This was added in https://github.com/fastly/Viceroy/pull/240


Library should not contain(almost) any unwrap/expect calls

Fixed with commit a163774. I removed unnecessary unwraps and added comments to safe ones. Thank you!


Added animated contact page, review and book now card

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
None
Fixes:  #449
Description
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]
I have added quite a cool animated forms of contact, review and book now. Hope you would like it and merge it. Thank you

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
https://github.com/user-attachments/assets/2416efa0-efe3-4b21-b717-10aa03f780bb
Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@Astro-Dude Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


SQLi authentication bypass by spidersec

Hello, I would like to suggest this authentication bypass that was shared by spidersec on Twitter which is.
'--'
"--"
TwitterPost

Done in https://github.com/swisskyrepo/PayloadsAllTheThings/commit/eaac0e748eabbf25d63a88d2d8c7e69f8b6677c0, thx


Code refactoring

What I've done:

Rename Components folder to component
Rename globalState folder to store folder
Refactor component's imports to default imports
Made constants file more useful

Nice work! These are really good changes.
I've also got the api-integration-v1 branch that I've got to merge which will have some conflicts with this. I'm going to merge the other branch first because I think it will be a lot easier to fix the conflicts in this branch than in that branch. It should also make this branch a bit simpler as it removes the redux store completely, as well as some redundant components.
Let me know if you want any help with the conflicts. Thanks!

Okay, I'll solve this!

@oetherington Probably, I done with this. Please, check it and let me know, didn't I miss anything?

Looks good to me! Thanks!


Running SQL script as part of another... (including by using @ char)

Hi,
notice feature in sqlplus and sqldeveloper:
select * from foo limit 1;
@nameOfScript.sql
drop database bar;

will "include" nameOfScript.sql into that listing... QUESTION - is dbeaver have any similar feature?
And, do anybody want to have it?
Docs here
Best regards.

This correlates with #639

@serge-rider thanks for marking as related. Is there any option/abbrev. in dbeaver to do so?

These issues are related (both requires DBeaver to analyze script content and extract meta-information) but still different - and will be resolved separately.
Will set 3.8 milestone although it is not final.

Hi,
Is it possible to enhance this feature by platform-specific MS-SQL command? Like this:
:r scriptFile.sql
See sqlcmd reference
It's required for testing purpose performed in DBeaver followed by patch compiling/deploying in CI.

'Getting things done'
@serge-rider chop this task into some subtasks and say what community should do...

Not sure that it can be chopped at this stage.
I need to improve SQL evaluation in core module first.

Thanks. Could you point where they are described or you want to do it on your own?

In 4.1.2 DBeaver will support following syntax:
@include file-name
@include "file-name"

file-name is relative or absolute file path.
See https://github.com/serge-rider/dbeaver/wiki/Client-side-scripting for details.
If other database-specific syntax is needed - please create separate feature requests.


[release-1.12] Stop previous remote cluster when updating secret

Manual cherrypick required.
#39367 failed to apply on top of branch "release-1.12":
Applying: Cleanup previous remote cluster when updating secret
Using index info to reconstruct a base tree...
M	pkg/kube/multicluster/secretcontroller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/kube/multicluster/secretcontroller.go
CONFLICT (content): Merge conflict in pkg/kube/multicluster/secretcontroller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cleanup previous remote cluster when updating secret
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

duplicate


Slack now support 2FA

https://slack.zendesk.com/hc/en-us/articles/204509068-Enabling-two-factor-authentication

@didlix Would you be able to add a doc: value as well pointing to their documentation? I think this site would be best: https://slack.zendesk.com/hc/en-us/articles/204509068

Also, their Twitter tag can now be removed and software: Yes needs to be added.

Does keeping twitter tag interfere with anything? If not, then I think we should keep them just in case for the future..

omg ;-; #ninjad

actually, I'm closing this PR since it needs more work and mine's complete. Hope that's okay with everyone.
It just feels a lot easier to do it like that.


Artem-BulletinsController and views for it was created

Link to task

Question making operation was tested - nice )


Datatable crud operations

My Datatable has 4 columns. id, name, email, edit/delete.
On server side, I have defined my columns as (User is my model)
columns = [
ColumnDT(User.id),
ColumnDT(User.username),
ColumnDT(User.email)
]
query = User.query.with_entities(User.id, User.username, User.email)
params = request.args.to_dict()
rowTable = DataTables(params, query, columns)
return jsonify(rowTable.output_result())
returned data contains only 3 columns but my datatable has 4 columns. So I am getting an error. What should I do?

@saifraider I've just added a very quick example in order to do that in a1068c2. Hope it helps !

Thank you so much. It would be nice if you can provide flask example

what matters here is this javascript code
"columnDefs": [ {
    "targets": -1,
    "data": null,
    "defaultContent": "Edit / Delete"
} ]

The use of Flask or Pyramid isn't related to your problem.

source: https://datatables.net/examples/ajax/null_data_source.html


Folder re-org

@saltycrane: this structure look better?

That looks good. Personally, I would get rid of the lib directory and move the demo directory up to the root. react-motion has a similar directory structure: https://github.com/chenglou/react-motion


Support absolute address for memory computations

The patch is based on #273

Please rebase it

Updated. Thanks!


Add liveness sidecar to ceph csi drivers

The CSI livenessprobe is a sidecar container that monitors the health of the CSI driver and reports it to Kubernetes via the Liveness Probe mechanism. This enables Kubernetes to automatically detect issues with the driver and restart the pod to try and fix the issue.

@Madhu-1 fyi

What is an unhealthy CSI driver? How we define it? Are there are any metrics we can use?

What is an unhealthy CSI driver? How we define it? Are there are any metrics we can use?

if the CSI driver is not sending any response to the GRPC request sent by liveness container it will be treated as unhealthy
how to use liveness is here https://github.com/kubernetes-csi/livenessprobe#usage

@humblec as we already have a liveness container which is built as part of ceph-csi can we expose an endpoint and use the same or do we need to use k8s-csi liveness

@humblec do we need it in release-3.0.0 milestone? or can we move it outside

Moving it to release-v3.1.0

@humblec can this be done in 3.1.0? or do we need to move it out to the next release?

@Yuggupta27 interested to work on this ?

@humblec, I think @Yuggupta27 is busy with CI/e2e stuff, I'm happy to take over.
@Yuggupta27 feel free to jump in :-)
Thanks!

Any Updates on this?

This can be reworked using https://github.com/kubernetes/enhancements/issues/2727

This can be reworked using kubernetes/enhancements#2727

This currently works for GRPC server with port not with socket, we need to see if its possible or not.


added command to update route53 record

Added command to update route53 record (or create if not exist).
Use case: self-registration of the ec2 instance on route53, with the ability to rewrite existing record.
Implemented by using Route53 API native UPSERT action.

Hi,
Thanks for this contribution, it is a good idea to add such a feature.
I have a few comments before accepting the changes:

In order to generate the files beginning with gen_, run the command go generate gen/aws/generators/main.go. You don't have to write these files manually. (You will see that the generated files are a bit different than yours).
As the the Update_Record and Create_Record are very similar, but not generated code, I propose to remove code duplication:

For the DryRun, in Update_Record_DryRun body, call Create_Record_DryRun
For the real execution, in Update_Record and Create_Record (and perhaps also in Delete_Record) extract a method building the input and performing the ChangeResourceRecordSets call, taking as input params map[string]interface{} and action string. This method will be wrapped in Update_Record Create_Record and Delete_Record with their specific code.

@fxaguessy thanks for your suggestions, I just updated the PR

Great ! Merged in master, it will be in next release. Thanks @Trane9991 for your contribution.
As we try to focus awless on broad practical usage, it would be great if you could have a look at this form: https://goo.gl/forms/1lQFPEIxdt37aDn43


How to properly add custom extractor?

Hi there. So I know how to create an extractor python file.
But if I add from .extractor import NameIE to _extractors.py, it'll eventually be overwritten next time an update edits the file.
Is there a better to do this that I don't know of?

_extractors.py belongs to yt-dlp. In that case read about yt-dlp plugins, which is probably what you want. With yt-dl, you have to maintain your own version of the program if you want to use a private custom extractor.

RIght. I mixed up the two cuz I have both installed.
Sorry about that.
So how do I add a custom extractor to youtube-dl?
Do I just add it to the _init.py file and hope it won't be updated anytime soon?

See https://github.com/ytdl-org/youtube-dl#user-content-adding-support-for-a-new-site, especially item #5.

Thank you.
But just to clarify, this is the correct way?
Because I did this, but the site is still not a "supported url".
import contextlib
import os

from ..plugins import load_plugins

# NB: Must be before other imports so that plugins can be correctly injected
_PLUGIN_CLASSES = load_plugins('extractor', 'IE')

_LAZY_LOADER = False
if not os.environ.get('YTDLP_NO_LAZY_EXTRACTORS'):
    with contextlib.suppress(ImportError):
        from .lazy_extractors import *  # noqa: F403
        from .lazy_extractors import _ALL_CLASSES
        _LAZY_LOADER = True

if not _LAZY_LOADER:
    from ._extractors import *  # noqa: F403
    _ALL_CLASSES = [  # noqa: F811
        klass
        for name, klass in globals().items()
        if name.endswith('IE') and name != 'GenericIE'
    ]
    _ALL_CLASSES.append(GenericIE)  # noqa: F405

globals().update(_PLUGIN_CLASSES)
_ALL_CLASSES[:0] = _PLUGIN_CLASSES.values()

from .common import _PLUGIN_OVERRIDES  # noqa: F401

# Custom extractors
from .kimcartoon import KimCartoonIE
_ALL_CLASSES.append(KimCartoonIE)

In yt-dl, edit extractor/extractors.py. For yt-dlp, ask there (#30839).

Yea, that is my extractors.py file in youtube-dl.
I don't really care for editing yt-dlp. I just confused it earlier.
So is the one I provided the correct implementation?

Example (git log --patch de48105dd870e353af468bfb8d49b14d9894e649 youtube_dl/extractor/extractors.py):
commit de48105dd870e353af468bfb8d49b14d9894e649
Author: fonkap<EMAIL_ADDRESS>Date:   Sat Feb 11 03:47:43 2023 +0100

    [KommunetvIE] Add extractor for kommunetv.no (#31516)

    * Add extractor for kommunetv.no
    * Using utils.update_url instead of regex

    ---------

    Co-authored-by: dirkf<EMAIL_ADDRESS>
diff --git a/youtube_dl/extractor/extractors.py b/youtube_dl/extractor/extractors.py
index f63a2e030..d8428f46f 100644
--- a/youtube_dl/extractor/extractors.py
+++ b/youtube_dl/extractor/extractors.py
@@ -557,6 +557,7 @@ from .khanacademy import (
 from .kickstarter import KickStarterIE
 from .kinja import KinjaEmbedIE
 from .kinopoisk import KinoPoiskIE
+from .kommunetv import KommunetvIE
 from .konserthusetplay import KonserthusetPlayIE
 from .krasview import KrasViewIE
 from .kth import KTHIE

Thank you. Yea, I figure that part out.
Turns out there's an issue with my extractor.
from __future__ import unicode_literals
from youtube_dl.extractor.common import InfoExtractor

class KimCartoonIE(InfoExtractor):
    _VALID_URL = r'https?://(?:www\.)?kimcartoon\.(?:li|me)/[^/]+/watch/[^/]+'
    _TESTS = [
        {
            'url': 'https://kimcartoon.li/Cartoon/Camp-Lazlo/Season-02-Episode-12-Theres-No-Place-Like-Gnome-Hot-Spring-Fever',
            'info_dict': {
                'id': '21899',
                'ext': 'mp4',
                'description': 'Watch online and download cartoon Camp Lazlo! Season 02 Episode 12 Theres No Place Like Gnome - Hot Spring Fever  in high quality. Various formats from 240p to 720p HD (or even 1080p). HTML5 available for mobile devices',
                'title': 'Season 02 Episode 12 Theres No Place Like Gnome - Hot Spring Fever',
            },
            'params': {
                # Some episodes may be geo-restricted
                'skip_download': True,
            },
        }
    ]

    def _real_extract(self, url):
        webpage = self._download_webpage(url, None, note=False)

        # Extract video information from the webpage
        video_id = self._match_id(url)
        title = self._html_search_regex(r'<title>(.*?)</title>', webpage, 'title')
        description = self._html_search_regex(r'<meta name="description" content="(.*?)"', webpage, 'description')

        return {
            'id': video_id,
            'title': title,
            'url': 'Sample URL',
            'ext': 'mp4',
            'description': description,
        }


Propagate Exit Code for Errors in Applications Instrumented with serverless-init

What does this PR do?

serverless-init propagates the exit code when an application errors.
Motivation

https://github.com/DataDog/datadog-agent/issues/21879
https://datadoghq.atlassian.net/browse/SVLS-5046
Additional Notes

When there is an error, propagate the exit code if it's available. Otherwise return an exit code of 1.
Also handles the case when multiple errors are joined together. While testing in Google Cloud Run the type of the error returned is errors.joinError.
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Build serverless-init test image from https://github.com/DataDog/datadog-lambda-extension/tree/main/scripts.
VERSION=1.0.0 ./build_serverless_init.sh
cp -r .layers/. ./scripts/bin/
docker build --build-arg="TARGET_ARCH=amd64" --platform linux/amd64 -f Dockerfile.serverless-init.build -t duncanharveydatadog/serverless-init-test:1.0.0-test .
docker push duncanharveydatadog/serverless-init-test:1.0.0-test

Deploy Spring app to Google Cloud Run
gcloud run deploy serverless-init-exit-code --update-env-vars=DD_API_KEY=<Datadog API Key>,DD_LOG_LEVEL=DEBUG --source .

Application code
package hello;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

@SpringBootApplication
public class Application {

	public static void main(String[] args) {
		System.exit(2);
	}
}

Dockerfile
FROM azul/zulu-openjdk:17-latest

RUN groupadd application && useradd -g application application

COPY --from=duncanharveydatadog/serverless-init-test:1.0.0-test /datadog-init /app/datadog-init
ADD https://dtdg.co/latest-java-tracer /dd_tracer/java/dd-java-agent.jar

RUN chown -R application /app/datadog-init /dd_tracer/java/dd-java-agent.jar

USER application

COPY demo-0.0.1-SNAPSHOT.jar /opt/application/app.jar
COPY startApp.sh /opt/application/startApp.sh

# ENTRYPOINT ["/app/datadog-init"]
# CMD ["/opt/application/startApp.sh"]

CMD exec /app/datadog-init java ${JAVA_OPTS:-} -jar /opt/application/app.jar

Tested the same image as a sidecar and confirmed the agent runs as expected.

/merge


Adding contact creates tx

Hey! So on any device I've tried this with, the same issue happens. When trying to add a contact, both through the address book and send screen, as soon as an individual scans the qr for the address it takes you to the TX creation screen, rather than actually creating a contact in the address book. Kinda makes the whole feature pointless. Attempted on both an ASUS Max plus running android Oreo as well as an iPhone SE

Thanks for the feedback. I can replicate this error on Android.
This should be fixed in the next update to be released soon.
We are very sorry for any inconvenience caused.


Base mode stress test fix

Fixed the issue of oslo library with monkey_patching.

@njagadish

Wrong pull request.


Fixed legacyShader.Draw() to draw Circle borders in the correct color.

Rebased this onto the current master branch.

Changes Unknown when pulling d27059470a8625953b33640f2a4cb2d2c34eaf61 on countcb:circlecolor into ** on EngoEngine:master**.

Changes Unknown when pulling d27059470a8625953b33640f2a4cb2d2c34eaf61 on countcb:circlecolor into ** on EngoEngine:master**.

Changes Unknown when pulling 0309bdea94152c9b230b0881979d4e6d25f31899 on countcb:circlecolor into ** on EngoEngine:master**.

Changes Unknown when pulling 57d071035f4df3e6191a847b9c76dad25c87284f on countcb:circlecolor into ** on EngoEngine:master**.

Changes Unknown when pulling ca0d81b0599a20531d082f7dd73210ee2b13a35f on countcb:circlecolor into ** on EngoEngine:master**.


THRIFT-5453: Defer DNS from NewTSocketConf to TSocket.Open

Client: go
We used to do DNS lookups in NewTSocketConf, without any timeout checks.
Stop doing that and do DNS lookups in TSocket.Open instead, which
already checks for ConnectTimeout set in TConfiguration.
This will be cherry-picked into 0.15.0 branch.

The test looks good, but I realized that since NewTSocketConf can never return an error now, I'd remove that from the function signature while I'm here.
Also updated some of the tests to stop using deprecated functions and switch to use the -Conf versions.
@dcelasun please take another look :)


TypeError: Cannot read property 'substring' of undefined

What version of Butler SOS are you using?
App version: 9.6.2
What version of Node.js are you using? Not applicable if you use the standalone version of Butler SOS.
Node version   : v14.20.1 | Node version   : v18.17.1
What command did you use to start Butler SOS?
node src\butler-sos.js -c config file
What operating system are you using?
Windows 10
What CPU architecture are you using?
Intel(R) Core(TM) i5-10500 CPU
What Qlik Sense versions are you using?
Qlik Sense May 2022 Patch 3
Describe the Bug
Is not Update Health Metrics to InfluxDB Have try it in 3 Version of InfluxDB and 3 versions of butler-sos also 2 version of Nodejs
The Butler SOS Usage that will write it to the InfluxDB
I've tried various settings and always get the same result, so I think there's an error in the config file that I'm missing,
Could you give me a tip where there could possibly be a problem in the config if you see the error code?
Error in Node Version 14
023-09-14T16:52:06.429Z verbose: HEALTH: Received ok response from
2023-09-14T16:52:06.445Z debug: HEALTH: "<!doctype html>\r\n<html ..........
2023-09-14T16:54:05.112Z debug: HEALTH: Calling HEALTH metrics Influxdb posting method
(node:19808) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'substring' of undefined
at getFormattedTime (c:\tools\butler-sos-9.6.2\src\lib\post-to-influxdb.js:13:22)
at Object.postHealthMetricsToInfluxdb (c:\tools\butler-sos-9.6.2\src\lib\post-to-influxdb.js:45:27)
at c:\tools\butler-sos-9.6.2\src\lib\healthmetrics.js:103:36
at processTicksAndRejections (internal/process/task_queues.js:95:5)
(Use node --trace-warnings ... to show where the warning was created)
(node:19808) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:19808) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Error in Node 18
2023-09-14T17:18:05.652Z debug: HEALTH: URL=******
2023-09-14T17:18:05.733Z verbose: HEALTH: Received ok response from
2023-09-14T17:18:05.735Z debug: HEALTH: "<!doctype html>\r\n<html lang="en">\r\n\r\n    <meta name="robots" content="noindex, nofollow" />\r\n    <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">\r\n    Qlik Sense login page\r\n    <meta charset="utf-8">\r\n
2023-09-14T17:18:05.850Z debug: HEALTH: Calling HEALTH metrics Influxdb posting method
c:\tools\butler-sos-9.6.2\src\lib\post-to-influxdb.js:13
const year = str.substring(0, 4);
^
TypeError: Cannot read properties of undefined (reading 'substring')
at getFormattedTime (c:\tools\butler-sos-9.6.2\src\lib\post-to-influxdb.js:13:22)
at Object.postHealthMetricsToInfluxdb (c:\tools\butler-sos-9.6.2\src\lib\post-to-influxdb.js:45:27)
at c:\tools\butler-sos-9.6.2\src\lib\healthmetrics.js:103:36
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Node.js v18.17.1
Expected Behavior
Write Data to the InfluxDB
To Reproduce
I have now try it with Butler-SOS Version from 9.5.3 to 9.6.2  i got everytime the same Failer also i have try it with more versions of influxDB, i don't finde the Problem

Looks like a config error, I agree.
But even so, the error message you get could obviously be a bit better... Will see if I can do something about that.
You should def use Node 18, but even easier is prob to use the pre-compiled binaries.
Unless you want to develop/tweak Butler SOS itself of course, then you need to get Node.js. working.

This log entry is a bit suspicious:
2023-09-14T17:18:05.735Z debug: HEALTH: "<!doctype html>\r\n<html lang="en">\r\n\r\n <meta name="robots" content="noindex, nofollow" />\r\n <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">\r\n <title>Qlik Sense login page</title>\r\n <meta charset="utf-8">\r\n

It indicates that you are trying to pull info from a web page rather than an API.
Which in turn indicate that your authentication to Sense isn't working...
Butler SOS is only compatible with InfluxDB version 1.x.
Support for 2.x etc coming.

What does your server definitions look like in the configuration file?
Here is mine. Important that you include the port 4243!
    # Sense Servers that should be queried for healthcheck data
    servers:
      - host: pro2-win1.lab.ptarmiganlabs.net:4747    # Example: <IP_ADDRESS>:4747
        serverName: sense1
        serverDescription: Central
        logDbHost: sense1
        userSessions:
          enable: true
          # Items below are mandatory if userSessions.enable=true
          host: <IP_ADDRESS>:4243
          virtualProxies:
            - virtualProxy: /                         # Default virtual proxy
            - virtualProxy: /sales                    # "sales" virtual proxy

Hello Göran,
Firstly, thank you for your quick support yesterday, I was able to narrow down the problem, I hadn't rolled out the system myself.
For whatever reason, the ports were redirected to port 80 health engine in the case of http tos 443, and there was also a problem with the certificates.
If my colleagues are in favor of using the tool (and I will convince them of this) we will run it in a Docker environment.
But to try it out, I took it into Node because it's easier to set up internally (guidelines, etc.)
I was able to adapt the server so that it now runs without problems. Thank you for your hint.
Thank you for your hard work in all your works
Best regards
Raffael

You got it working, cool!
Reload failure alerts too?
Yeah Docker is a good way to run tools like Butler and Butler SOS.
At least if you have the skills/infrastructure to do so.
I've had cases where Butler and Butler SOS in Kubernetes clusters that already existed in the company.
A bit overkill - maybe - but it also gives really good fault tolerance etc.
And there were also people already looking after Kubernetes, so very little extra operations overhead.
Good luck!


Return null when offset is null for lead/lag

This is to match Presto's behavior for offset null scenario. Before this commit, Lead/Lag use kNullRow to describe both out of range and null offset scenario, in this commit we introduced another constant: kDefaultValueRow: we use kNullRow if offset is null, otherwise use kDefaultValueRow. We only copy default value from input vector for rows marked as kDefaultValueRow.
Fixes #6413
cc @mbasmanova @aditi-pandit

Thanks @xumingming for the PR. Minor nit comments only.

Do we have further comments?

@xumingming : I'm satisified with the changes. Please get approval from @mbasmanova

@mbasmanova Can you help merge this one?

Gentle ping.

Looks good % some nits.
@aditi-pandit Aditi, testing for window functions feels out of control. Let's invest in extending Fuzzer to cover window functions.

@mbasmanova : Are you referring to Presto fuzzer testing or existing Velox fuzzer ?
The main issues in Window testing have come about are when there is a choice of returning a default value or null and it seems like DuckDB behavior differs from Presto on those. For that we have added hard-coded Velox tests.
At the time being we have been adding tests in https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeWindowQueries.java for window function queries. This has helped us discover many gaps. (There are couple pending PRs post fixes as well).
I'm inclined to build up that test in the short-term until fuzzer functionality is fleshed out. I hear that someone in Meta is going to work on it. I will stay on top of the fuzzer found issues for window functions.

@xumingming : Please add e2e Presto tests for this change in https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeWindowQueries.java  as well.

@xumingming : Please add e2e Presto tests for this change in https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeWindowQueries.java as well.

I will. After this change is merged.

@mbasmanova are you still not satisfied with the window document? If that is the case, how about merge this PR first and I(maybe @aditi-pandit can help here too) optimize the window doc in another PR?

@xumingming I'm getting "Diff Is Old or Base Revision Is Old" error. Would you rebase?


[frontend] Resolve Test Suite NewRun.test.tsx

Steps to reproduce

Checkout Branch kfp-46-npm-install
nvm use 14
npm ci
npm test

closing this ticket as we are moving away from pipelines


[string-theory] Update to 3.3

Update string-theory port to upstream version 3.3

Thanks for making an awesome library! :)


Improved reporting on shared build services with same FQCN but different class

Expected Behavior
It happens regularly that questions come up like
Cannot set the value of task ':grpc:stub:python:checkPython' property 'envService' of type ru.vyarus.gradle.plugin.python.service.EnvService using a provider of type ru.vyarus.gradle.plugin.python.service.EnvService.

This is typically caused by a plugin being applied to two sibling projects and then using a shared build service.
The first project register the service, the second gets the previous registration but receives an instance of the class on the other class loader so cannot use the service.
It would be nice if on getting a service, and / or setting a provider, and the expected and actual type are not equal but have the same FQCN, a more actionable message is presented like "add the plugin with problem with apply false to the root build script" or something similar.

The issue is in the backlog of the relevant team and is prioritized by them.


[.NET] HtmlTag Id/Name property

The HtmlTag class should have a strongly typed first class property for Id and/or Name this should be populated via with the value from the AdativeCard when rendered; this would allow the developer to perform queries based on the Id/name of a element for things like late data-binding.

Hey Grahame,
For things like inputs, which have Id properties in the Card schema, I believe we do transfer those ids over to the name property of the HTML input.
For everything else, in the Adaptive Card schema there's currently no purpose for an Id on elements, hence we didn't add one.
For data-binding, that's something we're thinking of adding support for natively into Adaptive Cards in a future release.
What other scenarios do you have in mind that would require ids being specified? And what is your scenario where you're rendering cards?

@anbare I currently have a requirement where I need to render a card for multiple host configurations and replace some of the textual content based on the recipient eg. applying branding/contact information (rending cards with data-binding to a model etc.) injecting sections etc.

Would it make sense to replace those before rendering? You can parse the Card they sent, and you can inspect additional properties they specified (you could have them specify ids, or any other property you'd like), and then you can replace info ahead of rendering.


Add External Annotator to get mutation results in problems window

Added benefit: the annotator can

add a gutter icon (red/green)
highlight a line (when mutation survives)
add a hover tooltip into the existing hover view

Additionally I refactored a bit so that we have less places where the parser is explicitly called.

Made all the loggers lowercase and added the try-catch


Configure Caffe's AlexNet prototxt files for fine tuning

Configure Caffe AlexNet prototxt files for fine tuning/transfer learning (freeze some layers, slow down others, etc.). Make sure that the feature scaling values are correct for what we copied over; also configure the solver file to ensure its values are consistent with what we want.

Not sure if this goes into this specific issue but given our current setup I should be fairly simple to try two approaches:

finetuning AlexNet for cloudless
training from scratch

Just mentioning it so that once our pipeline is nicely streamlined, we can mess with getting better results.

Now that I'm done prepping the data I'm going to move onto this (and also #3).

This is done but it's not generalizing terribly well. Once I get EC2 GPU instances setup I'll explore this again or perhaps shift over to VGG-128 to match what Planet Labs is doing.


Should we have some concept of "unique by" separate from primary_key?

Currently defining the primary_key for a source serves two purposes:

Make the with join syntax available
Provide the key on which to make aggregates symmetric.

I was chatting with @lloydtabb earlier and he mused that we might want to separate these purposes and have a parameter of some sort for "unique by". maybe we use primary_key if you don't specify something for uniqueness to avoid unnecessary verboseness?? Let's discuss.
CC @mtoy-googly-moogly @christopherswenson

Yeah, because "primary key" means a thing, and it isn't really the primary key.
two words, first word is distinct or unique then and _ and the second word is on, by, or key


Final version for master

Please create 5 branches called:
chap-1
chap-2
chap-3
chap-4
chap-5

Fantastic. Thanks!!


Implement authorisation of users - Staff and Owner

Closing, as not really applicable anymore, see issue #19

At the moment we are using token based authentication. When the user provides the token, we are aware of what the user can and cannot do, hence this issue is not really applicable.


Sign up flow UI tweaks

Related Issue or Background Info
Just a few UI tweaks to the sign up flow suggested by @vz3
Screenshots / Demos

Typo fix looks good. @nickclyde
For the "Request access to SimpleReport" message, it'd be good to shorten it. Pls replace the second line with: "Not sure who your admins are? Email<EMAIL_ADDRESS>

Is the dashed underline on hover/info states in here? Also have we tested that that pattern works on tap on mobile?

@vz3 the tooltips don't work on mobile, we had an issue for that previously but decided not to prioritize mobile designs for sign up, see here
I opened a separate ticket for the dashed underline as I couldn't get it to work quickly and want to be sure to get these changes in quickly


PSI List Task

Task: Simulated data should be saved to disk

This task has been completed by defining a function in python, putting that program text into a txt document that is callable from the main program, this function is callable because the txt document of the function is in the main branch.


change team attribution

What does this PR do?
fixes attribution from first meetup

Cool! I'll let you click the merge button :smile:

Thanks @synek, good review! I should have kept the old -m 😅
I'm not authorised to merge though... 🤨 not 'authorized' (another bug?)

I invited you to the COMOB Github org, which I think should give you access? Let me know if it doesn't work.

Thanks, still no go with auth status, think I need admin permission because it's an org project, see related SO question
At the moment it appears as before and links to an info page on protected branches

Github permissions is a little confusing, sorry. I just gave you access manually, so hopefully it works now?

Oh I remember now, I restricted who can push to the main branch a while ago! I didn't want to run the risk of someone accidentally force-pushing it and deleting all the group's work!
I'll met this PR now, but I'm also open to removing that restriction if anyone feels strongly about it (and can quell my fears).

Sounds like a good threat model to me!


BytesMut memory usage grows without bound

I'm working on a high-throughput network service with Tokio, and I'm running into an issue where the memory used by a BytesMut grows without bound as more and more messages are processed. After some debugging, I was able to come up with this minimal example:
extern crate bytes;
use bytes::*;

fn leaks_memory() {
    let mut data = BytesMut::from(Vec::with_capacity(16));

    loop {
        data.reserve(4);
        data.put(&b"leak"[..]);
        data.advance(4);
    }
}

fn also_leaks_memory() {
    let mut data = BytesMut::with_capacity(8192);

    loop {
        data.reserve(4);
        data.put(&b"leak"[..]);
        data.advance(4);
    }
}

fn constant_memory() {
    let mut data = BytesMut::from(Vec::with_capacity(16));

    loop {
        data.reserve(4);
        data.put(&b"leak"[..]);

        data = data.split_off(4);
    }
}

fn also_constant_memory() {
    let mut data = BytesMut::with_capacity(16);

    loop {
        data.reserve(4);
        data.put(&b"leak"[..]);
        data.advance(4);
    }
}

It looks like what's happening is that a BytesMut backed by a Vec isn't actually reusing space at the beginning of the buffer when reserve is called, but only if it was moved forwards with advance. I'm not sure whether any of the other methods (e.g. truncate) cause the problem. The documentation says reserve will try to recycle existing space (which it's clearly doing in also_constant_memory) but it seems to be failing when it shouldn't.

I see what is going on. This is kind of the intended behavior as advance though I can see how the docs could be confusing.
That said, the case you are illustrating could be optimized by "resetting" the cursors when the read cursor and the write cursor line up.
Do you want to take a stab at implementing that?

The advance implementation looks entirely reasonable to me. I did implement a fix for the issue though. In reserve, when kind == KIND_VEC, instead of just calling Vec::reserve I check whether there's free space at the beginning of the buffer and copy everything back to the start if so.
With the fix implemented, the test cases I showed all run in constant memory. Does it seem like a reasonable approach to you? If so, I can open a PR.


MinimumVolumeBox3: Adjust class data to make it reusable for multiple data sets

The primary problem was that mEdgeIndices was not being reset (it was being reserved and pushed to).
I also changed convex hull to be a member. Not sure if it was a good idea. But it works fine in my tests (single-threaded)
This is a lazy optimization but at least it allowed me to save a few seconds for thousands of data sets.

The resetting of members is fine. However, would you mind explaining why you replaced the local ConvexHull3 (ch3) by a class member (mConvexHull3)? There is no public accessor to mConvexHull3, and the constructor for ConvexHull3 has minimal overhead (all std::vector are defaulted to empty). Thanks.

I didn't look too deep into the ConvexHull3 class, but based on a quick look I had back then I think it used hashmaps and vectors in its members. So I figured it would minimize reallocations if the previous sizes of these containers were greater than the current required sizes.
But if they are don't have a lot of overhead I will put it back.

It is difficult to determine statically whether or not the resizes in ConvexHull3 are better than starting with a new object each time. Have you run a profiler to find out whether it does make a difference? Regardless, having a member mConvexHull3 instead is probably useful in case someone wants that hull in addition to the minimum volume box. If you do not mind, add a read-only accessor to that object, say, "ConvexHull3 const& GetConvexHull3() const { return mConvexHull3; }" and I will merge your pull request with the code base.
Thank you for taking the time for providing feedback and modifying the code.

Have you run a profiler to find out whether it does make a difference?
I will definitely try this later to see if it makes a noticeable difference.

If you do not mind, add a read-only accessor to that object, say, "ConvexHull3 const& GetConvexHull3() const { return mConvexHull3; }" and I will merge your pull request with the code base.
Added. I also added a note that this convex hull is not generated when using the overload that already uses the convex hull.

Thank you for taking the time for providing feedback and modifying the code.
No problem. Thank you very much for sharing this extremely useful library. It has saved me a lot of time.


The ssh extension generates invalid paths in ssh config file when multiple host patterns are used

Extension name (the extension in question)
ssh
{
  "experimental": false,
  "extensionType": "whl",
  "name": "ssh",
  "path": "/Users/username/.azure/cliextensions/ssh",
  "preview": true,
  "version": "1.0.0"
}

Description of issue (in as much detail as possible)
❗ The issue arrived with version 1.0.0 and was not actual for 0.1.*
When I have multiple hosts in the getting config expression like this
az ssh config --ip '*.internal 10.31.*' --file ~/.ssh/azure/config

It populates the following config
Host *.yscan.local 10.31.*
	User<EMAIL_ADDRESS>	CertificateFile /Users/username/.ssh/azure/az_ssh_config/*.internal 10.31.*/id_rsa.pub-aadcert.pub
	IdentityFile /Users/username/.ssh/azure/az_ssh_config/*.internal 10.31.*/id_rsa

Where Host directive is correct, but when I try to connect to a host I get the following error:
ssh ys-admin-app.yscan.local
/Users/username/.ssh/azure/config line 4: garbage at end of line; "10.31.*/id_rsa.pub-aadcert.pub".

/Users/username/.ssh/azure/config: terminating, 2 bad configuration options

I tried to double-quote the path in the populated config like this
CertificateFile "/Users/username/.ssh/azure/az_ssh_config/*.internal 10.31.*/id_rsa.pub-aadcert.pub"
IdentityFile "/Users/username/.ssh/azure/az_ssh_config/*.internal 10.31.*/id_rsa"

and then it worked as expected.

route to service team

@vthiebaut10, please help take a look.

@legigor Thank you for bringing this problem to our attention. We will have if fixed on the next release of the extension. Meanwhile, another possible workaround is to use the --keys-destination-folder parameter to save the generated keys on a different folder. For example:
az ssh config --ip '*.internal 10.31.*' --file ~/.ssh/azure/config --keys-destination-folder ~/.ssh/azure/mykeys

I am experiencing a possible variant of this bug.
As an attempt at a workaround we followed @vthiebaut10's suggested workaround and did
az ssh config --ip ip.of.vm --file e:\config --keys-destination-folder e:\keys
The same error is still retuerned.

@Tea23 Yes, that is a variant of the same bug. That will be fixed on the next release. For now, creating a config file with a --keys-destination-folder and using that config to connect to your resource should be working.
What exactly happens when you run:
az ssh config --ip ip.of.vm --file e:\config --keys-destination-folder e:\keys
ssh -F e:\config ip.of.vm

@Tea23 @legigor Both your issues have been addressed in the new version 1.0.1 of the SSH extension. Please validate that it works for you.

closing as it is called out as fixed.


Can't Serialize Simple Chain

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
from langchain_openai import ChatOpenAI
from langchain_core.prompts import ChatPromptTemplate
from langchain_core.output_parsers import StrOutputParser
import json

llm = ChatOpenAI()
prompt = ChatPromptTemplate.from_messages([
    ("system", "You are a helpful assistant."),
    ("user", "{input}")
])
output_parser = StrOutputParser()
chain = prompt | llm | output_parser
json.dumps(chain.to_json())

Error Message and Stack Trace (if applicable)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
[<ipython-input-35-d8b5c0c45d51>](https://localhost:8080/#) in <cell line: 1>()
----> 1 json.dumps(chain.to_json())

3 frames
[/usr/lib/python3.10/json/encoder.py](https://localhost:8080/#) in default(self, o)
    177
    178         """
--> 179         raise TypeError(f'Object of type {o.__class__.__name__} '
    180                         f'is not JSON serializable')
    181

TypeError: Object of type ChatPromptTemplate is not JSON serializable

Description
I'm trying to serialize a very simple chain to JSON, but the library is complaining that ChatPromptTemplate is not serializable. Removing that node from the chain, I then get the error ChatOpenAI is not JSON serializable.
System Info
langchain==0.1.9
langchain-community==0.0.24
langchain-core==0.1.27
langchain-openai==0.0.8

I got this to work using the load and dump utility functions


Allow more control over the handshake?

The websocket protocol allows some options during the handshake that currently aren't exposed:

The client can propose a list of possible "subprotocols"

The client can send arbitrary HTTP headers (e.g., authorization headers)

The server can see the list of possible subprotocols and headers

The server can pick a subprotocol to use

The server can include arbitrary headers when accepting the connection

The server can reject the connection with some kind of HTTP 4xx response, including headers and body

Not all of these are actually exposed through wsproto currently (e.g. see https://github.com/python-hyper/wsproto/issues/61), but it would be good to at least leave the door open to supporting them later. In particular, I'm a bit nervous about the server API, since it does the handshake automatically before the user's handler has a chance to do anything.

related:  trio-websocket is not exposing handshake info such as path (#17)

Overview
I'm starting to plan for this issue. I read the WebSocket RFC so I can understand the handshake details better. I think wsproto already handles the following issues:

Subprotocols
Extensions

And it does not handle the following issues:

Rejecting with HTTP 4xx response (https://github.com/python-hyper/wsproto/issues/61)
Arbitrary headers (there doesn't seem to be an open issue for this on wsproto?)

So I'll write up my thoughts here about how to add eventual support for all of these features...
Subprotocols
On the client side, subprotocols can be added to the API as a subprotocols=[…] argument to the client constructor/factories. We can pass this down to wsproto, which will send the list of subprotocols in its HTTP upgrade handshake. When the connection is established, the client can read the selected subprotocol and expose it as a property of the WebSocketConnection instance.
The server side is a bit more complicated. The server gets a ConnectionRequested event that contains the list of subprotocols provided by the client. It needs to choose zero or one subprotocols and pass it to accept() to finish the handshake.
The simple server implementation is to provide a list of subprotocols to the server constructor/factories. On each connection, the server can loop over the client's proposed subprotocols and pick the first one that it supports, or None if it doesn't support any of them.
The simple server implementation is limited because once set, that server instance will never be able to offer other subprotocols. Maybe it wants to offer one subprotocol on path /chat and a different subprotocol on /hearbeat. So the more complicated and generalized server solution is to offer a callback that receives connection request metadata (headers, URL path, subprotocols, etc.) and returns zero or one subprotocols. (This same design might be preferred for the other aspects of this issue. See below.)
Open questions for subprotocols:

If a client requires a certain subprotocol, should we have a way to express that? The client can specify a list of acceptable subprotocols but the server has the right to choose zero of them. The client can check the subprotocol property to see if it got what it was expecting, and it can close the connection if needed. Should we offer some shortcut way to demand a certain subprotocol?
Do we prefer the "simple" server subprotocol selection, the "complex", or something else? I'm leaning towards "complex" because it is more generalized and will help with the other parts of this issue.

Extensions
Extensions can be added to the API as an extensions=[…] argument to the client constructors/factories. wsproto exposes extensions as classes (e.g. wsproto.extensions.PerMessageDeflate) so we can either re-export those classes in trio-websocket, or we can allow the user to specify extensions as strings. Strings are more convenient but would preclude the user from providing their own extension implementation, so maybe we support both, i.e. you can pass a string like permessage-deflate or you can pass a subclass of wsproto.extensions.Extension.
The negotiated extensions should be exposed as a read-only property of WebSocketConnection.
As with subprotocols, the server side is a bit murkier. The most flexible approach is to have a callback that receives connection request metadata and chooses which extensions to enable. On the other hand, wsproto only implements one extension and I'm not sure how useful it would be to change extensions based on connection request metadata.
Open questions for extensions:

Should we specify extensions as strings, classes, or allow both?
Should the server use a callback to decide which extensions to enable? (If so, it can be unified with the subprotocol's callback.)

Arbitrary Headers
Wsproto doesn't support this feature yet, but we can at least think about how it would work.
On the client-side, we can offer a headers={…} argument. On the server side, for reasons similar to those discussed above with subprotocols and extensions, we probably want a callback that receives connection request metadata and can modify headers before the response is sent.
Open questions for headers:

Should we block certain headers? E.g. we don't want the user to pass in a Sec-WebSocket-Extensions header because that would mess up wsproto's internal state machine. (Maybe this is something for wsproto to handle.)
Should headers be exposed as a read-only property of WebSocketConnection? Probably not, because headers are not negotiated and the caller already knows which headers they set.

Rejecting with HTTP 4xx response
Wsproto doesn't support this feature yet, but we can at least think about how it would work.
This feature only applies to the server. The only reasonable way to implement this is by using a callback that receives connection request metadata (headers, URL path, etc.) and can signal when an HTTP error needs to be returned.
Conclusions
It seems like most of this can be accomplished by a combination of the following changes:

New client-side arguments like headers, extensions, and subprotocols that get passed down to wsproto.
New WebSocketConnection properties that expose the negotiated extensions and subprotocol.
A callback for server connections that receives connection metadata and is allowed to do things like selecting a subprotocol, enabling/disabling extensions, modifying headers, or raising an HTTP error.

In order to simplify usage, a default callback should implement common options, like setting subprotocol to None and enabling all extensions that are supported by wsproto. If a user implements a callback, they should be able to ignore the parts they don't care about. I.e. if they don't care which extensions are enabled, then they should get all the built-in extensions automatically. Therefore, the callback requires some careful design to handle all 4 of these features (subprotocols, extensions, headers, http errors) without requiring each user to write lots of boilerplate.

For extensions, I wouldn't get fancy at this stage. wsproto has all this "generic" extension machinery, but... Extensions are defined through RFCs and can make more-or-less arbitrary changes to the protocol. Websockets have been shipping in browsers since 2009, and in that time only 1 extension has been defined (permessage-deflate). So... there might never be another extension. Or if there is, it might turn out that wsproto's current machinery can't handle it, and needs to be redone anyway. So wsproto's whole extension API is kind of optimistic. For now, I'd probably just stick to a simple API for configuring permessage-deflate. (The simplest version would be a bool to enable/disable it. If you want to get fancier I guess you could expose the extension parameters.)
For the server-side negotiation API, I wouldn't use a callback. Instead, I'd let the handler task start up, examine the situation, and possibly reconfigure things before accepting/rejecting the connection.
One approach would be, server handlers don't receive a websocket object, they receive a WSConnectRequest and then they have to call .accept() to actually accept the connection and get a websocket object.
Another approach would be, server handlers receive an "uninitialized" websocket object: it's a full-fledged websocket object but it hasn't done the handshake yet. If you start calling send/receive without doing the handshake, then it automatically performs the handshake with default values and then performs the requested operation. But, if you want, before you start using the object for real, you can examine it and then explicitly complete the handshake by calling a method like accept or reject. (This is how Trio's SSLStream handles the TLS handshake.)
The "request object" approach is nicely explicit, but would mean that our getting started examples are slightly more complicated than other competing websocket libraries. I don't have a strong intuition for which is better.

I think I prefer the explicit approach (request object). A user only needs to add 1 line of code in the base case. I'll work on this approach first and see how it looks.
The alternative approach sounds like it would be deceptively tricky for the user. The user can only call accept() or reject() during a window of time after the client has done its part of the handshake but before the server has done its part of the handshake. This seems like it would cause more confusion than it prevents. But I'll keep this in mind as an alternative to later, if needed.

First commit is done. The scope is limited to subprotocols. I ended up not supporting extensions because wsproto's ConnectionRequested event doesn't expose the client's proposed extensions, and wsproto's accept() method doesn't have any argument to specify extensions. But I think the general design will work for extensions, custom headers, and rejecting connections.

Fixed in #62


modified dnd.teamInfo to have a required Users argument

Summary
As per changelog June 2019, this PR adds users as a required argument to dnd.teamInfo

As announced on March 25, the dnd.teamInfo method now requires the users parameter. An explicit list of users helps you, and us, avoid slow API calls.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.splinterific seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I will fix this by #678


Feat/cmc 1650: MP Respond to Claim RPA changes (Hand-Off/Goes Offline)

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CMC-1650
Change description

refactor and reuse event text method from full defence response
add divergent and non divergent responses to json
add and update tests

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

reopening for QA


review readme.md

I review the readme.md file.
I hope it is clearer, let me know if it looks good.
I had an example to help readers understand what we mean.

Thanks for your contribution! :+1:


During a2c training, why use advantage as the target for actor?

Hi
Nice job. When I tried to understand the a2c.py, I noticed that you are using advantage as the target to train the actor:
    actor_loss = self.actor.fit(update_inputs, advantages, nb_epoch=1, verbose=0)

But as I understood, shouldn't it use the policy that derives from softmax(value_predicted) to train?
Thanks!!

Oh I see the categorical_crossentropy in the loss function. Never mind, I'll close the post.


Add endpoints for guild events

Docs
Instructions

This will need to be done in dippy/core/api/endpoints/guild_events.py
Fields in the docs that have a type with a question mark should be optional (ex. ?integer should be Optional[int])

Tasks

[ ] List scheduled events for guild
[ ] Create guild scheduled event
[ ] Get guild scheduled event
[ ] Modify guild scheduled event
[ ] Delete guild scheduled event
[ ] Get guild scheduled event users

Be sure to commit each new endpoint separately

hi! i'd like to be assigned to this issue
also noticed a thing, in list scheduled events for guild there is nothing said about with_user_count being required and/or default.. what should i put in QueryArgField()?


Cluster component not updating if child Markers change

Thought I'd try out the new Marker and Cluster components (awesome idea!), and noticed that whilst the child Markers show/hide on a query change, the Clusters always remain the same from first load.
Same pointCount and coords, even if the children underneath change or no longer exist. Also means no new Clusters appear for Markers that didn't exist on first load and start with a parent Cluster (or were outside of the getBounds on first load). Tried out the demo and but the data doesn't change so couldn't reproduce the issue there. Looked at the component as well, and only saw mapChange updating the pointCount, but not for a new query.
Seeing as the child Markers update happily along with other map components, I couldn't think what the issue with Clusters not updating.
The chance of html Markers makes me not want to switch back to Layers, so any help is appreciated!

@drekli Can you try out with react-mapbox-gl v2?

Sure thing, I'll look forward to testing that! Thanks for the heads up on v2 and all the hard work!

this is still happening even on version 2

@marek-sed, @Wykks will look into that

@Wykks I looked at the code I think I found the issue and was able to fix it properly.
Hope it helps
#286

Released with version 2.0.6


(maint) Bump to ezbake 1.7.3

This commit updates to the latest version of ezbake, which will set build_tar to false, preventing the nightlies job from attempting to sign tars that don't exist.

Test PASSed


Understanding the flow of iob-cache

Hello Community
Is there any user documentation which explains basic flow of the "iob-cache" and how can we understand it.? I am getting perplexed  with files getting generated after verilation in obj_dir directory. I am unable to  generate user guide with the minimal commands provided.
It is getting difficult in understand as a user, how the back-end ,front-end sections are in sync with main memory section and can they be tested from testbench
Which sequence to follow for a basic successful test case
Thank you in advance.

We are adding a basic test to the verilator testbench. It should be ready in a couple of days.
This test writes to one memory address and then reads from the same address.
An external memory is missing from the verilator  testbench. Of course a cache does not work without a memory attached.
As for the user guide it was working when I last tried though the document needs reviewing and is incomplete. Is it because of the FPGA compilation? You need to have vivado and quarts installed but it makes sense to disable that and not include implementation results by default.

I have simulated testbench by adding the below changes. I wanted to see the output to analyse the changes But i dont even see the "clk" changes in gtkwave

Could you pleaee suggest in which manner i can configure such changes in testbench.cpp ..
Thank you in advance

Hello
Please refer to the updated verilator testbench available on doc branch. It performs a simple write/read test.
I hope it could help.

Documentation can now be generated on branch build-lib. Thanks.


Added VolumeMount support

This adds VolumeMount support to the main container and extraContainers,
so that they can actually use the Volumes defined in the previous PR.

This one is ready for review too, but I'm a bit concerned.
For this one, it seems to complained that all existing jobs on my dev stack
2021-09-25 01:03:30,520 ERROR [cass_titus_dev-nio-worker-3] service.JobReconciliationFrameworkFactory:? - Bad job record found: jobId=83482f6f-338f-40b8-9383-4def4709699f, violations={jobDescriptor.container='null' in fields: volumeMounts}
Which makes me think I must relax the nonNull constraint?


improve bitset

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

29 of 32 (90.63%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 91.237%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

overlaps.go
1
2
50.0%

internal/bitset/bitset.go
17
19
89.47%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.2%

Covered Lines:
1541

Relevant Lines:
1689

💛  - Coveralls


Export of simple json to xlsx file causes error in EXCEL

When exporting a simple JSON to xlsx, EXCEL throws the following error and claims to need to repair file.

On repairing the file, EXCEL report the following error in its log
<repairedRecord>Repaired Records: Worksheet properties from /xl/workbook.xml part (Workbook)</repairedRecord>
The JSON  file exported is a very simple test file - see below
[
{series name: 'Compliance/Legal', x: '0.5', y: '0.5', value: '1'},
{series name: 'People', x: '4.5', y: '3.5', value: '1'},
{series name: 'Brexit', x: '0.5', y: '4.5', value: '1'},
{series name: 'Business Plan', x: '0.5', y: '4.5', value: '2'}
]
code used to create the file is as follows:
let workSheet = $XLSX.utils.json_to_sheet(data, {header: ['series name', 'x', 'y', 'value']});
let wb = $XLSX.utils.book_new();
$XLSX.utils.book_append_sheet(wb, workSheet, fileName);
$XLSX.writeFile(wb, fileName, {bookType: 'xlsx'});
Please advise.

You gave everything except for the part causing problems :/
The error message suggests that the worksheet name may be causing issues.  What is fileName and can you share the bad file?
To be sure this is not a normal occurrence, here's an example using your exact data: https://jsfiddle.net/gb2hakmd/
const fileName = "issue2720.xlsx";

const data = [
{'series name': 'Compliance/Legal', x: '0.5', y: '0.5', value: '1'},
{'series name': 'People', x: '4.5', y: '3.5', value: '1'},
{'series name': 'Brexit', x: '0.5', y: '4.5', value: '1'},
{'series name': 'Business Plan', x: '0.5', y: '4.5', value: '2'}
];

let workSheet = XLSX.utils.json_to_sheet(data, {header: ['series name', 'x', 'y', 'value']});
let wb = XLSX.utils.book_new();
XLSX.utils.book_append_sheet(wb, workSheet, fileName);
XLSX.writeFile(wb, fileName, {bookType: 'xlsx'});

Hi, yes, no problem. Attached is the file and the fileName is: RiskThemes_ Bubble Chart.xlsx.
RiskThemes_ Bubble Chart.xlsx
I tried exporting with a fileName of test.xlsx and you are correct, it is fine, but I don't see anything wrong with the filename - it seems perfectly valid to me? Any ideas?
RiskThemes_ Bubble Chart.xlsx

Hey there, I just had the same problem, but managed to find a fix.
In my case one of the sheet names had a colon : in the name which Excel apparently does not like.
I removed the colon and the shown error message disappared.
@SheetJSDev could validation of the sheet names be possible?

That was added in 0.18.10.  Discussion continued in #2722


Build(deps-dev): Bump @types/styled-components from 5.1.21 to 5.1.22 (#2672)

Pull request opened by the merge tool on behalf of #2672

Merged in c47809aefd102198d8ccad43b419ff679ea3eb96


Trashing runs causes recalculation of DataPoints

When a Run is trashed (updated on the DB level) this causes a recalculation of tags and that in turn causes recalculation of DataPoints. While we have removed the datapoints upon trashing the Run we are adding these again.

[ ] make sure that Run that triggers the evaluation is not trashed.
[ ] add test

Outdated.


[Bug]: Error accesing to Torii API from examples

Dojo.js Version
0.7.3
What happened?
I followed along the steps of Contributing to Dojo Guidelines.
After finishing the installation steps, I tried to run the examples/react/react-app example following the examples guide.
It seems to goes all good, but when I opened http://localhost:5173/ it displays just a white screen instead of the app. This because the call to setup function from main.tsx is falling -->

Debugging
I opened the console and found this message:
http://<IP_ADDRESS>:8080/world.World/WorldMetadata net::ERR_ADDRESS_INVALID

After, I go to the examples/react/react-app/src/dojo/generated/setup.ts file, and harcode the value for toriiUrl passed to torii.createClient function. I hardcoded the value to "http://localhost:8080" instead of the "http://<IP_ADDRESS>/8080" url that is been taking from the config.toriiUrl prop.
This seems to be the solution, because after this I was able to run the example without any problem.
Of course, hardcode the Torii url value is not the best practice. So I researched on the code and change the url on the next files:

examples/node/torii-bot/.env.example
examples/node/torii-bot/codegen.ts
packages/core/src/constants/index.ts

But, despite that, when I ran the app again it still is using "<IP_ADDRESS>" instead of "localhost". Maybe I have to rebuild something again to make the changes take effect?
Looking on packages/core/src/constants/index.ts I found that LOCAL_KATANA variable is using localhost, so I think this is a suitable solution cause in the same file is the LOCAL_TORII variable (using <IP_ADDRESS>) but again, I change it and not takes effect.
ps: I found this issue where the same function freeze the app, but it not seems to be related to this problem (https://github.com/dojoengine/dojo.js/issues/130)
What is the expected behavior?
Shows the example application
Steps to reproduce

follow up the Contributed to Dojo Guidelines steps.
Try to run the examples/react/react-app
When open the browser on port 5173, it shows a white screen instead of the app.

Trace

Is there an existing issue for this?

[X] I have searched the existing issues and verified no issue exits for this problem.

If the solution is going the way I am, I would like to receive some feedback about my last question @ponderingdemocritus @tarrencev and be assigned to this same issue so I can fix it :)

i want to work on this issue

This is fixed.


better error msg for incorrect WAV format chunk

simple wording change to be more specific about WAV "format chunk size", vs the ambiguous "file size".
this goes back to #36823

We will not be encouraging one liner grammatical changes as this is expensive process, thank you for your interest.
CC @mihaimaruseac @chanshah

Let's take this as it improves UX and fixes a confusion from an issue

@googlebot I signed it!
On Thu, May 7, 2020, 17:42 googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Ftensorflow%2Ftensorflow%2Fpull%2F39288
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/39288#issuecomment-625567618,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAAJ2AJSKBOD5KVKIJU3T3RQNIQZANCNFSM4M3YZ72Q
.

@mihaimaruseac -- looks good to you?


Document the customizations

If I understand well, this library provides default usage but also provides abstractions to choose and customize:

the JSON library
the Client
the HTTP requests

It would be nice to add a section in the README to show with simple lines of code how to customize all of these points 🙂

Hi @curquiza
I have some previous knowledge in JSON library and HTTP requests. I can read a little about client and create a section in the README file for the same. Can you please assign this issue?

Hi @ishika22,
Thanks for asking, It's done.


Add Andrew Konecki to the Contributors list

Addition of my name to the list of contributors.

@awkonecki, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.