ng build --prod changes opacity value of CSS rule on brand new ng new project

🐞 Bug report
Command (mark with an x)

[ ] new
[X] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
I don't know.
Description
When doing ng build --prod, it changes the opacity value of a css rule.
🔬 Minimal Reproduction
Create a new project:
PS D:\Projects\Test Projects> ng new cssBug
? Would you like to add Angular routing? No
? Which stylesheet format would you like to use? SCSS   [ https://sass-lang.com/documentation/syntax#scss
Open file /src/styles.scss
Add the following lines in the file:
.mat-form-field-appearance-outline.mat-focused .mat-form-field-outline-thick,
.mat-form-field-appearance-outline.mat-form-field-invalid.mat-form-field-invalid .mat-form-field-outline-thick {
  opacity: 50% !important;
}

Build new project:
PS D:\Projects\Test Projects> cd cssBug
PS D:\Projects\Test Projects\cssBug> ng build --prod
Open /dist/cssBug/style.hash.css.
Look at previously inserted lines.
Result: opacity has been change from 50% !important to 1% !important.
I have reproduced this 3 times.
🔥 Exception or Error
No Exception. The error is a change in the CSS value of opacity.
🌍 Your Environment
PS D:\Projects\Test Projects\cssBug> ng version
Angular CLI: 9.1.0
Node: 10.16.3
OS: win32 x64
Angular: 9.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes
Package                           Version
@angular-devkit/architect         0.901.0
@angular-devkit/build-angular     0.901.0
@angular-devkit/build-optimizer   0.901.0
@angular-devkit/build-webpack     0.901.0
@angular-devkit/core              9.1.0
@angular-devkit/schematics        9.1.0
@ngtools/webpack                  9.1.0
@schematics/angular               9.1.0
@schematics/update                0.901.0
rxjs                              6.5.4
typescript                        3.8.3
webpack                           4.42.0
Anything else relevant?
Change in CSS rule causes a display issue when going from dev to prod build. Issue is visible across all browsers.

I closed the issue I found this was a Sass issue which compiles percentages to 1%. You can delete this.


Devnet-3: Besu forked off at block 110500

Initial review shows a wrong gas calculation, Besu is charging 2500 gas more for a CALL than the other clients. It seems the problem is:
The tx causing it is 0x01911cedc5083ed9342846193bc1fbf187616f2366df7ba8606e49f39f2b7b93
Analysis

Tx is sent to account 3093
3093 is an account which has delegated code
At some point the contract make a CALL to itself, 2500 gas is charged too much
Whenever an OP code needs to resolve an account with delegated code, we either charge 2600 (cold read) or 100 (warm read) for the resolution. The difference between the 2 is exactly 2500.

Conclusion:
Other clients seem to warm up the to address when the account has delegated code, even though no other additional gas costs are charged for this specific resolution at the beginning of the transaction.
Solution:
Besu needs to warm the to address in this case as well.

Here is a test which a similar problem:
To execute it:
1) ./gradlew installDist
2) download https://github.com/ethereum/execution-spec-tests/releases/download/pectra-devnet-3%40v1.5.0/fixtures_pectra-devnet-3.tar.gz and extract it
3) build/install/besu/bin/evmtool block-test $PATH_TO_FIXTURES/blockchain_tests/prague/eip7702_set_code_tx/set_code_txs/set_code_to_self_caller.json

4) to run the debugger add export JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005" && before the last command


Can't resolve function call stack offsets with shared fixup instruction

Describe the bug
I've got x86 binary with following assembly code:

It seems that BN unable to deduce that last basic block (at the picture) always will have same stack offset, so it produces invalid HLIL at this point:

So, I can't see arguments for next function calls (even "Override Call Type" doesn't help)
there two files in attach:

test1.elf - files produced by compiler
wrong.elf -This file actually has the same behaviour as first one, but was manually patched in order to simulate real-world case from binarywhich unfortunately I can't share.

I'm unable at this moment to find out exact compiler option which will force to generate buggy code without my patch.

BN version - 2.3.2802-dev, Build ID 86543874
To Reproduce
Steps to reproduce the behavior:

Download attached binaries
Open wrong.elf in BN
Goto test function
See at 0x139e

Expected behavior
I guess we should deduce that stack offset will be same for all paths and have same HLIL for both binaries (this one from test1.elf):

Binaries: bins.zip

This is partially mitigated in 2.4.2902-dev with the inclusion of the "Show Stack Pointer Usage" option in LLIL. While the underlying bug (two functions share their stack fix instruction) is not fixed, it will be easier to discover how to work around the issue and see where to override stack adjustments:

In the meantime, I'll retitle this issue to reflect the underlying bug

I have the similar issue in 3.0.3233. I tried to set a value for the esp register for fixing stack frame offset and ran reanalyze of the function but it doesn't work. Are there any ways to fix this?

FYI 4.1.5747 still has the bug and I can't find workaround...


hide comment page unless logged in

This code redirects the user to the comment page after they initially click the "Comment" link -> redirecting them to login.

LGTM!


Add support for decorators to be used as Volume Classifiers

Currently, volume classifiers can be used only for iModel elements. This PR allows decorators or box geometry to be used as volume classifiers.

Modified SpatialClassifierProps interface.

modelId is now can be a string or VolumeClassifierModelProps[]

Added interface VolumeClassifierModelProps.

id - transient id that is used to identify the volume classifier(for eg: to show the tooltip).
color - of the volume classifier geometry.
points - an array of points that will be used to create box geometry for volume classification.
transform - transform of the geometry.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Are you submitting this PR as a proof-of-concept, or as a candidate for merging?

Are you submitting this PR as a proof-of-concept, or as a candidate for merging?

Assuming POC means that this feature will only be available on dev builds. While we want this to be on stable release as well. It makes sense to have it on dev first then we can make some iterative changes and add it to the stable release.

We can't merge this PR as-is because it introduces breaking API changes, and it adds support only for your own very narrow requirements ("classify by a set of boxes").
Let me spend some time on this today to try to come up with a more general solution.

Working on it here.

Closing this PR. Since similar PR https://github.com/iTwin/itwinjs-core/pull/6532 is merged.


Always on top doesn't work anymore

Microsoft PowerToys version
0.59.1
Running as admin

[X] Yes

Area(s) with issue?
Always on Top
Steps to reproduce
press shortcut keys to acvtivate always on top (tried several different ones)
✔ Expected Behavior
current session of the application in focus should get on top (as it was in the previous version.
❌ Actual Behavior
Activating always on top just starts a new session of the application in focus, not making the current session always on top
Other Software
Tidytabs pro 1.18.5
Workshelf from Nexus
Greenshot
Citrix Workspace

Can you please provide additional info on how can I reproduce this behavior? A screen record can be useful also.
/needinfo

Hi Seraphima,
Windowskey/CTRL/T is my shortcut key.
When I, for example have my focus on an Outlook window (as the one I'm typing in right now), I expect (as it was in the previous version, before the update) that this outlook window is always on top (as the function suggests).
But instead of doing that, a NEW window (session) of Outlook starts and that that's also NOT on top.
But ... while pIaying around, formulating this answer, I've discovered it myself now :-)
It was Tidytabs (an app that arranges similar windows in tabular form) that had already claimed that hook windowskey/CTRL/T.
So, you can mark this issue as solved and the root cause was PEBKAC (Problem Exists Between Keyboard And Chair).
Thanks anyway for the swift reaction
Roeland Verwilligen
From: Seraphima Zykova @.>
Sent: vrijdag 17 juni 2022 14:17
To: microsoft/PowerToys @.>
Cc: Roeland Verwilligen @.>; Author @.>
Subject: Re: [microsoft/PowerToys] Always on top doesn't work anymore (Issue #18903)
== EXTERNAL MAIL == This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Can you please provide additional info on how can I reproduce this behavior? A screen record can be useful also.
/needinfo

Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F18903%23issuecomment-1158813761&data=05|01|Roeland.Verwilligen%40inetum-realdolmen.world|4ef58e3bae9e47f09ab208da505b55a1|1685007349774869916308e8d38eac81|1|0|637910650481581625|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=xHeHo43q4Xa3qg9x3adHCjDe21dYi%2BmRrarHjvZHt9Q%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKIC57D7WDAK6AW3MPTPA3LVPRUETANCNFSM5ZBXAAYA&data=05|01|Roeland.Verwilligen%40inetum-realdolmen.world|4ef58e3bae9e47f09ab208da505b55a1|1685007349774869916308e8d38eac81|1|0|637910650481581625|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=D8S6GHIR4L%2BhEM0Pzt%2FCq4zHbYbowmx63lI9rOGbUm8%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Thank you for your answer! A similar issue with shortcuts is in progress right now, so yours will be fixed too.
/dup of https://github.com/microsoft/PowerToys/issues/17312


Iterator on cached tf.data Dataset cannot be reinitialized

Found a likely bug when trying to use a reinitializable iterator to read from two cached datasets, one for validation and one for training. The iterator can however only be initialized once per cached dataset. Seems to me like the iterator should remove the lock file when being reinitialized, it is not in my case and that is why I get this issue. Here's a minimal example with only one cached dataset.
(basic system information below)
Example
import os

import numpy as np
import tensorflow as tf

data = np.random.rand(10, 3).astype(np.float32)
dataset = tf.data.Dataset.from_tensor_slices(data)
batches = dataset.shuffle(10).repeat().batch(5)

config = tf.ConfigProto(device_count = {'GPU': 0})
sess = tf.Session(config=config)

cache_dir = os.path.join(os.getcwd(), 'cache_dir')
try:
    os.makedirs(cache_dir)
except OSError:
    print('Cache directory already exists')

cached = batches.cache(os.path.join(cache_dir, 'cache'))
iterator = tf.data.Iterator.from_structure(output_types=tf.float32, output_shapes=(5, 3))
batch = iterator.get_next()

init1 = iterator.make_initializer(cached)
init2 = iterator.make_initializer(batches)

sess.run(init1)
sess.run(batch)

array([[ 0.11960778,  0.3081578 ,  0.96522039],
[ 0.90339011,  0.12458269,  0.30650312],
[ 0.58160347,  0.55877644,  0.50363588],
[ 0.2350398 ,  0.33509603,  0.4165386 ],
[ 0.76757395,  0.50134581,  0.93601096]], dtype=float32)

sess.run(init2)
sess.run(batch)

array([[ 0.76757395,  0.50134581,  0.93601096],
[ 0.2350398 ,  0.33509603,  0.4165386 ],
[ 0.90339011,  0.12458269,  0.30650312],
[ 0.13266359,  0.82675195,  0.26691398],
[ 0.58160347,  0.55877644,  0.50363588]], dtype=float32)

sess.run(init1)
sess.run(batch)

AlreadyExistsError (see above for traceback): There appears to be a concurrent caching iterator running - cache lockfile already exists ('/home/ubuntu/ai_notebooks/notebooks/projects/deep-purple/cache_dir/cache.lockfile'). If you are sure no other running TF computations are using this cache prefix, delete the lockfile and re-initialize the iterator. Lockfile contents: Created at:<PHONE_NUMBER>
[[Node: IteratorGetNext = IteratorGetNextoutput_shapes=[[5,3]], output_types=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"]]

Sytem information
Tensorflow version: v1.4.0-rc1-11-g130a514 1.4.0 (installed from pip)
Python version: 3.5.2
OS: Linux Ubuntu 16.04.3
CUDA: 8.0.61
cuDNN: 6

Brennan, can you please take a look?

As a temporary fix I tried deleting the lockfile before reinitializing. When I do I keep getting new cache files after reinit. Here's an example from a cache directory with a larger dataset:
1199681441 Dec 13 19:41 cache.data-00000-of-00001.tempstate12238922573150074415
1199681441 Dec 13 19:48 cache.data-00000-of-00001.tempstate18257683081874428073
1199681441 Dec 13 19:45 cache.data-00000-of-00001.tempstate5944011296618694888
...

Double checked and all have the same content.

Hey @agrinh
If you have not finished reading the underlying input data, then we do not release the lock. Can you read the entire underlying dataset before switching between the validation / training datasets?
All the best,
-Brennan

@saeta Thanks for helping out, that seemed to solve that particular problem.
I was applying the repeat() before caching (both in the example and in my real data loader), so I assume the cache releases the lock and produces the index file on tf.errors.OutOfRangeError. When I move the repeat to after the caching and make sure to run through all data this example works.
Perhaps this behaviour could be documented. Some interactions (e.g. repeat - cache, shuffle - cache etc.) are pretty non-obvious to me and it would save me a huge amount of time to get at least some of those details listed.
Thanks again,
Agrin

@agrinh Funny you should ask. I and @jsimsa have been working on a datasets performance guide we hope to publish soon, and we cover recommended order-of-operations. I'll make sure repeat vs cache and shuffle vs cache are included. :-)
Nice sleuthing and getting it all working!!

Awesome, looking forward to it, thanks again @saeta

@sata @mrry Seems that shuffle_and_repeat with cache doesn't work instead dataset.shuffle(buffer_size, reshuffle_each_iteration=True).repeat(count) works.
Docs tells that is the same call. Is there any different internal details that invalid the iterator of shuffle_and_repeat combined with cache?

@mrry We start with https://github.com/tensorflow/tensorflow/issues/18266

For anyone facing this problem, note that it doesn't matter if you initialized a different set, just running the same iterator initializer twice in a row is enough to cause this. My training loop had a logic similar to this:
job = get_next_job()

if job.set == 'train':
    session.run(train_initializer)
elif job.set == 'validation':
    session.run(validation_initializer)

# training code

Even though the logic theoretically allows for any mixture of training and validation batches, the jobs were only sent in a typical epoch oriented fashion. To fix the error I had to add a check to only initialize when switching sets.


Fix readthedocs commit hook

New commits don't update the documentation website. Find out why and fix it.

It seems to be working now, a re-sync of the hook via the readthedocs site seemed to have fixed it.


Vulnerability roundup 61: jasper-2.0.14: 1 advisory

search, files

[ ] CVE-2018-20622 (nixos-18.09, nixos-unstable)

Scanned versions: nixos-18.09: 8008d0bbc69; nixos-unstable: 2d6f84c1090. May contain false positives.

See also #53949, #52248, #51737

So, jasper is now marked vulnerable.
jasper is abandoned upstream, so I think we should remove it from Nix. How long do we wait between marking vulnerable and attempting to remove? (and seeing what breaks)

I think removal is fair. It has been a few months since we marked it as insecure.

Closing as NixOS 18.09 is no longer supported and unstable is no longer vulnerable.


Fix/use posix style paths

Generator application would always use POSIX-style paths.
Closes #58

Hi @aashis-kishore - thanks a lot for your contribution. If you rebase the pr and remove the it.only, I'll merge it through and release it.

Hi @beeman - okay, will do that.


Improvise Machine Learning readme

💥 Proposal
Improvise the readme a little and sort the projects by algorithms so it becomes easier to navigate.

Hey! I would like to work on this issue, please assign it to me.

@Soumya-Kushwaha - we can do it halfway through the program? Say around June 30th?

@khusheekapoor alright, will stay tuned.

@Soumya-Kushwaha - please go ahead. Also, please clean up the readme by ensuring that all the notebooks/ folders have been linked. Thanks!

@Soumya-Kushwaha are you taking this up?

Yes yes, I am.
I'll work on it.
On Tue, Jun 27, 2023 at 10:47 PM Khushee Kapoor @.***>
wrote:

@Soumya-Kushwaha https://github.com/Soumya-Kushwaha are you taking this
up?
—
Reply to this email directly, view it on GitHub
https://github.com/The-Data-Alchemists-Manipal/MindWave/issues/151#issuecomment-1609929078,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU3RDXRI3VQZ3YJAX7CJPA3XNMIT7ANCNFSM6AAAAAAYLJRCNM
.
You are receiving this because you were mentioned.Message ID:
@.***>


runtime: avoid functions forbidden on Windows 10 UWP

What version of Go are you using (go version)?
go version go1.9 windows/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\maxr\go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\maxr\AppData\Local\Temp\go-build474350779=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config

What did you do?

Created static library with func defined in Go and exported to be used in C++
Command line: go build -buildmode=c-archive puregodll.go

Linked puregodll.a static library generated on previous step into the shared MinGW dll library.
Command line:

gcc -dumpspecs | sed -e 's/-lmingwex/-lwinstorecompat -lmingwex -lwinstorecompat -lole32 -lruntimeobject/' >./specfile
gcc -specs=./specfile -shared -o goDLL.dll goDLL.c -Wl,--dynamicbase -Wl,--whole-archive puregodll.a -Wl,--no-whole-archive -lWinMM -lntdll -lWS2_32 -lsetupapi

It produces goDLL.dll as result.

Running script to adjust binary PE header of produced goDLL.dll to be compatible with Windows 10 UWP platform (it expects appcontainer bit set in PE header)

Created Windows 10 UWP project with latest Visual Studio 2017 and P/Invoke goDLL.dll to call func initially defined in puregodll.go

Run Windows Store Certification Kit for Supported APIs Test on generated Windows Store appx bundle and getting list of forbidden API calls, it seems, used in go-runtime:

API AddVectoredExceptionHandler in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API ExitProcess in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API FreeEnvironmentStringsW in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API GetConsoleMode in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API GetEnvironmentStringsW in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API GetProcessAffinityMask in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API GetStdHandle in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API LoadLibraryA in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API RtlAddFunctionTable in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API RtlCaptureContext in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API RtlVirtualUnwind in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API SetConsoleCtrlHandler in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API SetProcessPriorityBoost in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API VirtualAlloc in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API WriteConsoleW in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API timeBeginPeriod in winmm.dll is not supported for this application type. goDLL.dll calls this API.
API timeEndPeriod in winmm.dll is not supported for this application type. goDLL.dll calls this API.

What did you expect to see?
I expect to have a way for go runtime to not use API calls which are forbidden on Windows 10 UWP platform

API AddVectoredExceptionHandler in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API ExitProcess in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API FreeEnvironmentStringsW in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API GetConsoleMode in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API GetEnvironmentStringsW in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API GetProcessAffinityMask in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API GetStdHandle in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API LoadLibraryA in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API RtlAddFunctionTable in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API RtlCaptureContext in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API RtlVirtualUnwind in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API SetConsoleCtrlHandler in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API SetProcessPriorityBoost in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API VirtualAlloc in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API WriteConsoleW in kernel32.dll is not supported for this application type. goDLL.dll calls this API.
API timeBeginPeriod in winmm.dll is not supported for this application type. goDLL.dll calls this API.
API timeEndPeriod in winmm.dll is not supported for this application type. goDLL.dll calls this API.

What are the replacement functions that provide this functionality on Windows 10 UWP?

I expect to have a way for go runtime to not use API calls which are forbidden on Windows 10 UWP platform

I don't think Go is supported on Windows 10 UWP platform. What is that you are building for Windows 10 UWP?
Alex

Hello @alexbrainman ,

What are the replacement functions that provide this functionality on Windows 10 UWP?
I believe, some functions doesn't have replacement, since UWP doesn't support console output and maybe some others limitations also.

Possibly good reading why Go should support UWP platform can be announcement of UWP support for Qt(C++) framework with some explanations why it was done:
http://blog.qt.io/blog/2015/04/29/windows-10-support-in-qt/
Basically, UWP apps can be placed in Windows 10 Store and distributed to any kind of device with Windows 10 ( package should has multiple builds for x86, x64 and arm platforms, but only x64 can be supported too ).

I don't think Go is supported on Windows 10 UWP platform. What is that you are building for Windows 10 UWP?

On Windows it's possible to build static library with CGO using MSYS2/MinGW-w64 toolchain and link static library to MinGW DLL to be P/Invoked from UWP application.
Ideally, CGO should support msvc compiler toolchain to eliminate some difficulties to support UWP platform, but because MinGW already is supported and it's possible to bring MinGW DLL with exported C-functions to UWP, it might be not so much additional work to support UWP platform.
I'm trying to consume to Windows 10 UWP platform the go module , which is already used cross-platform for iOS and Android. The main benefit of UWP platform is that UWP port of react-native library + Windows 10 Store publishing will be available.
Thanks

What are the replacement functions that provide this functionality on Windows 10 UWP?
https://docs.microsoft.com/en-us/cpp/cppcx/crt-functions-not-supported-in-universal-windows-platform-apps

@MaxRis thank you for explaining. Unfortunately I have no plan to work on this. So, if you are interested, you have to do it yourself. I am happy to answer any questions you have along the way.
Alex

@alexbrainman thank you! I've started looking into this, so definitely will have some questions soon...

Hello @alexbrainman ,
It seems that support of UWP will require extending Go with new GOARCH.
I'm planning to start adding of "windows_amd64_uwp" GOARCH support.
Going to start looking into extending of src\cmd\dist bootstrap tool with new UWP arch.

I assume you mean a new GOOS, not a new GOARCH.
If you intend your work to be added back to the main Go distribution, please discuss it on the golang-dev mailing list.  If this really needs a new GOOS value--I don't really know--there are various requirements that need to be addressed.  See https://golang.org/wiki/PortingPolicy.

@MaxRis what Ian said. It is a big job.
You can also just copy Go source code, change it for yourself and see if it is useful to you. I would say you should do it anyway - you need something working and useful before it can be merged back into main Go repo.
Alex
PS: See related (but, probably, not relevant today) https://groups.google.com/d/topic/golang-dev/ZfmKRl5V6kw/discussion

Thank you @ianlancetaylor @alexbrainman !
Links should be very helpful!
My best guess, is that new GOARCH should suit better, because it's the same Windows OS, but some API calls can't be used. That's the only difference.
Maybe even new ARCH is too much for such small difference, but after looking a little bit at source, it seems should be more cleaner way to implement, than put some additional checks into source code for Windows platform.

Just to be clear, it can not be a new GOARCH value.  It could possibly be a new GOOS value.
But I would hope that it can be done without changing either GOARCH or GOOS.

Okay, @ianlancetaylor thanks!

Just wanted to say that I am also interested in building UWP apps in Go. @MaxRis have you been able to get something running yes?

@tfriedel6 , not yet, but still planning to work on this. Sample project might be used as starting point to bring dll built with MinGW to UWP platform. As suggested above, some discussion should be started.

Can anyone tell me the status of this ?
About a week ago Microsoft finally stabilised their winrt c/c++ runtime so that you don't need to use their weird cx API.
Chrome uses the c / c++ winrt runtime for example.
So does this mean a new golang GIOS is not needed and I can use golang on Windows 10 and call the winrt runtime now ?

@rsc could you comment on this please ? It's really important that golang is not locked out of Windows 10 desktops for me. Especially the new appx and windows store

This 2019 post says the venerable win32 API is now has "full support" in their windows store:
https://news.xbox.com/en-us/2019/05/30/microsoft-approach-to-pc-gaming
Look for "Supporting Win32 Games on Windows 10".
Is this issue still relevant?

This 2019 post says the venerable win32 API is now has "full support" in their windows store:
https://news.xbox.com/en-us/2019/05/30/microsoft-approach-to-pc-gaming
Look for "Supporting Win32 Games on Windows 10".
Is this issue still relevant?


Modularize Depenecies

Codecov Report

Merging #34 (eed6c52) into main (741718a) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head eed6c52 differs from pull request most recent head bfeded9. Consider uploading reports for the commit bfeded9 to get more accurate results

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           36        36
  Lines          826       828    +2
=========================================
+ Hits           826       828    +2

Impacted Files
Coverage Δ

zetta_utils/__init__.py
100.00% <100.00%> (ø)

zetta_utils/training/datasets/layer_dataset.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Translations for the updated site breakage report screen

Task/Issue URL: https://app.asana.com/0/0/1205823859163167/f
Description
Adds translations for the updated site breakage report screen.
Steps to test this PR

[ ] Ensure all checks are green

Current dependencies on/for this PR:

develop

PR #3774

PR #3775   👈

This stack of pull requests is managed by Graphite.


feat: add managed resources metrics

Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Codecov Report
Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@b81cd99). Learn more about missing BASE report.

Files
Patch %
Lines

cmd/provider/main.go
0.00%
19 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #70   +/-   ##
======================================
  Coverage        ?   0.00%
======================================
  Files           ?     309
  Lines           ?   30516
  Branches        ?       0
======================================
  Hits            ?       0
  Misses          ?   30516
  Partials        ?       0

Flag
Coverage Δ

unittests
0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bug - Fix sorting by interview

Sorting order was wrong

Codecov Report

Merging #223 (0447bbf) into master (6d2f185) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0447bbf differs from pull request most recent head f85e0a1. Consider uploading reports for the commit f85e0a1 to get more accurate results

@@            Coverage Diff            @@
##             master     #223   +/-   ##
=========================================
  Coverage     67.71%   67.71%
  Complexity      550      550
=========================================
  Files            96       96
  Lines          1908     1908
  Branches        245      245
=========================================
  Hits           1292     1292
  Misses          531      531
  Partials         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2f185...f85e0a1. Read the comment docs.


/dev/shm troubles in docker 1.4.1

This doesn't work:
root@callisto ~ $ docker run --rm ubuntu:14.04 date
FATA[0000] Error response from daemon: mkdir /home/docker/overlay/d2dbd3b3186dc7899502af99203459dc083b210c6c6efbb69d01ee871f534565-init/merged/dev/shm: invalid argument

But this works:
root@callisto ~ $ docker run --rm busybox date
Fri Dec 26 19:19:18 UTC 2014

root@callisto ~ $ docker info
Containers: 6
Images: 50
Storage Driver: overlay
Execution Driver: native-0.2
Kernel Version: 3.18.1-031801-generic
Operating System: Ubuntu 14.04.1 LTS
CPUs: 2
Total Memory: 3.791 GiB
Name: callisto
ID: ZWU6:UVBQ:HL5R:AAB5:GKYQ:2MSR:UPQW:TN6H:32C4:JJFX:WLWA:YPNZ
WARNING: No swap limit support

cc @alexlarsson

@SvenDowideit ok，let me collect overall fs.

so, how will I fix this?

Does this problem still exist?

@laijs see the PR that closed this issue; https://github.com/docker/docker/pull/9834. Running overlay in top of btrfs doesn't work. If you're having similar issues but don't have btrfs as a backing file system, please open a new issue instead

I'm locking the conversation on this issue, because the original issue reported here was resolved


try iOS 15 emojis

https://github.com/PoomSmart/EmojiLibrary/releases/tag/0.15.4

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #feedback.

Font itself works, but its alignment in text is not correct.


Breyson Bayu Companion Response Dialogue Incorrect Conditions

When speaking to Breyson during Absolute Power, he has dialogue to respond to companions but the conditions are incorrect so they never fire.
Details
All INFOs under [DIAL:0018238B]
00182384
00182385
00182386
00182387
Conditions for GetDistance are set incorrectly and should be:
QuestAlias.GetDistance(PlayerRef [PLYR:00000014]) <= COM_InterjectionDistance [GLOB:0000D8A9]
For 00182386, both conditions are incorrect. The conditions should be:
QuestAlias.GetIsVoiceType(NPCMBarrett [VTYP:00005B85]) = 1 AND
QuestAlias.GetDistance(PlayerRef [PLYR:00000014]) <= COM_InterjectionDistance [GLOB:0000D8A9]
Fix Attached:
BreysonBayuReponseFixCF06.zip
Game Version
1.9.67
Language
English (EN)
Have you recreated this issue on a new game?
Yes, I can recreate this issue.
Reproduction Steps
During Absolute Power, talk to Breyson. Choose "I agree, he deserves everything coming to him."  Breyson then talks about Benjamin Bayu talking about him behind his back. This is where a companion will chime in and Breyson is suppose to respond to them, but the conditions are incorrect so the dialogue doesn't fire.

The ESM provided seems to forward the records without actually changing them. I've manually applied the fix based on your notes here.


Improve help output for create commands

Required arguments for create commands are now displayed in a separate
block. For update action, all the arguments end up in one block.
JIRA: PDC-1079

Looks good to me.


Get / Set authentication info

There have been already few issues opened for this, but I still don't see any update in this article to clarify how to get and set the authentication info as they seem to be returned by the API in AAD portal.
    "authenticationPhoneNumber": "",
    "authenticationAlternativePhoneNumber": null,
    "authenticationEmail": ",
    "strongAuthenticationDetail": {
        "verificationDetail": {
            "alternativePhoneNumber": null,
            "email": "",
            "phoneNumber": ""
        }
    },

I'm looking at removing these info as part of the user offboarding script / process, I thought I would get useful info from this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aae83fda-27b9-edca-1b59-1140de4cc3f5
Version Independent ID: c93eb84b-f04b-de03-f3f5-57d4672b0559
Content: Azure AD SSPR data requirements
Content Source: articles/active-directory/authentication/howto-sspr-authenticationdata.md
Service: active-directory
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@mrik23 Thanks for the feedback. We are actively investigating and will get back to you soon.

@mrik23 as was mentioned in the previously opened issues work is being done to create a Graph API for setting and changing security info is coming soon but no dates to share.

#please-close

@mrik23 We will now close this issue. If there are further questions regarding this matter, please reply to @femsulu and we will gladly continue the discussion.

@femsulu, this issue is quite old, but I still can't find a corresponding method in the Graph API
Is there a way to get or set the authentication info already?

@azzzy Check the Graph API Beta branch:
https://docs.microsoft.com/en-us/graph/api/resources/phoneauthenticationmethod?view=graph-rest-beta
There's a known issue where the Graph API won't return a phone number that was stored without a space after the country code:
https://docs.microsoft.com/en-us/answers/questions/593114/authentication-methods-not-available-at-graph-api.html


Determine CompositeByteBuf implementation by using ByteBufAllocator

Motivation:
Currently, using a MessageAggregator in the pipeline always results in the creation of an unpooled heap CompositeByteBuf. By using a ByteBufAllocator the CompositeByteBuf will use the settings specified by the ByteBufAllocator.
Modifications:
Use the ChannelHandlerContext's ByteBufAllocator to create the CompositeByteBuf for message aggregation
Result:
The CompositeByteBuf is now configured based on the ByteBufAllocator's settings.

AUTOMATED MESSAGE for ADMINS:Please verify and accept the pull request.To accept, say @netkins acceptTo build again, say @netkins buildTo whitelist the author, say @netkins whitelist

@netkins accept

@blucas thanks! merged into 4.1 (aa8917115c594b111929c4115cb699327af2ff73) and master (4e34d2ce6d6f2eb5f7535025948a853d4f852bc4)


Different results with and without OpenMP threads

Tests from testcorenrn repository that simulate more than 1 cell produce different outputs from Neuron when run with CoreNeuron with SoA configuration and more than 1 OpenMP thread.
 /

To run a test (for example "watch" which produces different output):
git clone git@github.com:pramodk/testcorenrn.git
cd testcorenrn
nrnivmodl mod
nrnivmodl-core mod
mkdir testwatchdat
mpirun -n 6 ./x86_64/special -mpi -c sim_time=100 testwatch.hoc
cat out.dat | sort -k 1n,1n -k 2n,2n > out_nrn_watch.spk
export OMP_NUM_THREADS=1
mpirun -n 6 ./x86_64/special-core -mpi -d test${NAME}dat -e 100
diff -w -q out.dat out_nrn_watch.spk // Same results
export OMP_NUM_THREADS=2
mpirun -n 3 ./x86_64/special-core -mpi -d test${NAME}dat -e 100
diff -w -q out.dat out_nrn_watch.spk // Different results

We have seen that nrn_setup phase2 has race conditions! look at global hash tables which are not protected by OMP critical section.

@iomaganaris do you know if this is still an issue? I ran a quick test locally where I ran all testcorenrn tests with multiple threads as well as 1, and nothing failed.
I wonder if this was fixed with #283?

I am not sure whether this fixed the issue. I think it would be useful to run the test added in this PR https://github.com/BlueBrain/CoreNeuron/pull/299 and see whether there is still an issue

OK, this, #292 and #299 all look related. I guess #299 should be updated to run in CTest/GitLab.


Header is displayed incorrectly when page is pushed from a modal

Ionic version:  (check one with "x")
[ ] 1.x
[x] **2.0.1
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
See screenshot. Only on iOS and iOS simulator.

Expected behavior:
Push a page from a modal page with this.nav.push(NotificationsPage) and page has a header with correct padding.
Related code:
Open a modal via:
Step1:
openModal() {
let modal = this.modalCtrl.create(Page1);
modal.present();
};
Modal is opened correctly
Now open a page from this modal:
openPage(){
this.nav.push(Page2);
}
Code Page 2:

Hello! While we appreciate you opening an issue with us i am going to close this issue and ask that you open a new one that has the issue template filled out please. Thanks for using Ionic!

What is wrong will this info?


Full build machine paths in panic messages

When a Wasm contract panicks, the full file path and line number is visible in the panic message. If a user does not use workspace-optimizer/rust-optimizer, this exposes personal file system infomation

Query failed with (6): rpc error: code = Unknown desc = failed to execute message; message index: 0: Error calling the VM: Error executing Wasm: Wasmer runtime error: RuntimeError: Aborted: panicked at 'Denominator must not be zero', /Users/username/.cargo/registry/src/github.com-AABBCCDDEEAABBCCDD/cosmwasm-std-1.2.6/src/math/decimal.rs:136:17: execute wasm contract failed [!cosm!wasm/wasmd@v_X.Y.Z_/x/wasm/keeper/keeper.go:389] With gas wanted: '100000000' and gas used: 'SOME_VALUE' : unknown request

The contents of the Aborted error is coming from Wasm:

panicked at 'Denominator must not be zero', /Users/username/.cargo/registry/src/github.com-AABBCCDDEEAABBCCDD/cosmwasm-std-1.2.6/src/math/decimal.rs:136:17

The source of this is https://github.com/CosmWasm/cosmwasm/blob/v1.4.1/packages/std/src/panic.rs#L10-L12. If I recall correctly, this used to be a relative path.
It seems like more recent versions of Rust use a line break between location and message.

So to me there are two open questions:

[ ] Can we ensure there are no full file paths in the Wasm file or do we just need to accept that and point to containerized build systems?
[ ] Should we customize how we build up the panic message let full_message = info.to_string();?

This seems more like something that should be fixed in the Rust compiler.
I did a bit of testing around this and here is what I found:

Removing the info.to_string() will obviously hide the paths from the panic messages, but it did not remove them from the wasm file. We could probably go through the result of info.to_string() and remove all absolute paths, but it feels a bit like a hack.
Adding something like RUSTFLAGS="--remap-path-prefix /Users/christoph=/" works, but is obviously very user-specific, so I don't see a way to add it for example to cw-template

Yeah, my 2 cents:

We should communicate it as a known limitation that a user's paths end up in the Wasm if no rust-optimizer/workspace-optimizer is used
Instead of info.to_string() we can build the panic message manually for stability. E.g. in the past it was only a relative file path. Not it's the full path. And in the latest Rust source code there is a line break between location and message, which we don't really want.
--remap-path-prefix might be useful inside of rust-optimizer/workspace-optimizer to reduce the size of the Wasm and keep error messages short

Looks like we cannot build the panic message ourselves, since access to PanicInfo::message is currently not stabilized.


refactor(JS): Encapsulated JS in a module instead of using the gobal scope

This refactor encapsulate the JS code in its own module instead of using the global scope which could be tampered with.
Important notice, support for dotnet standard 2.0 has been dropped because of the use of IJSObjectReference.
The JS has been cleaned a bit:

Removed the use of nested objects and (possibly) misleading this
Used arrow functions everywhere instead of some kind of mix
Removed deprecated var, enforced proper use of const/let (it was used randomly)
Added missing null checking (of editor for instance)
Used (de)structuring/spread operator

- /*...*/.editors.push({ id: id, editor: editor, dotnetRef: dotnetRef });
+ editors.push({ id, editor, dotnetRef });

- editorHolder.editor.addAction({
-     id: actionDescriptor.id,
-     label: actionDescriptor.label,
-     keybindings: actionDescriptor.keybindings,
-     precondition: actionDescriptor.precondition,
-     keybindingContext: actionDescriptor.keybindingContext,
-     contextMenuGroupId: actionDescriptor.contextMenuGroupId,
-     contextMenuOrder: actionDescriptor.contextMenuOrder,
-     run: function (editor, args) {
-         editorHolder.dotnetRef.invokeMethodAsync("ActionCallback", actionDescriptor.id);
-     }
- })
+ editorHolder.editor.addAction({
+     ...actionDescriptor,
+     run: (editor, args) => editorHolder.dotnetRef.invokeMethodAsync("ActionCallback", actionDescriptor.id)
+ });

Replaced null checking with shorthands:

- if (model == null)
+ if (!model)

- if (options == null)
-     options = {};
+ options = options || {};

- return editorHolder == null ? null : editorHolder.editor;
+ return editorHolder?.editor;

Enforced string comparisons (===/!== instead of ==/!=).
Avoided unnecessary rewraps

- defineTheme: function (themeName, themeData) {
-     monaco.editor.defineTheme(themeName, themeData);
-  }
+ export const defineTheme = monaco.editor.defineTheme;

Thanks for this PR. As this is a breaking change, I'll merge these changes in v4.0.0

+1


quickopen and quickoutline will now show the field icon for field symbols

This addresses https://github.com/Microsoft/vscode/issues/21315.
I noticed a few issues:

SymbolKind.to and SymbolKind.from didn't map SymbolKind.Field to anything so SymbolKind.Property was used by default
There were no classes for field icons except for one high contract mapping that field icons shared with variable icons. I could see that the icon used for variables in that location matched Field_16x.svg, so I operated under the assumption that in the other locations that variable icon classes were defined, field icon classes should be created to point to the same icon

@hoovercj,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@hoovercj looks good to me but do you have an example where I could verify the fix? When I use TypeScript on an example like this:
class Test {
    public test: string;
}

It looks like test is of kind property and not field.

I recently added document symbol support in the HTML language service, so if that version has been pulled in by vscode then you should see html elements as fields/blue bricks in the quick outline. This is how I spotted the discrepancy, I returned SymbolKind.Field but they were appearing with the wrong property wrench icon.
I put together a small extension that you could use to preview the icons. There is a .vsix in the dist/ directory. You open a file named icons.ts and the symbol provider provides one symbol of each type so you can see the icons. Before this change you can see field uses a wrench, after it uses the blue brick.
Otherwise, a quick and dirty way of verifying that the icons are correct is looking at where I modified src/vs/editor/common/modes.ts and modifying the SymbolKind.from/to to always return field, property, or variable and then observe the effects in the document symbols outline.

Thanks!


Project link http://node-xmpp.org/doc/expat.html dead?

It seems like the project link http://node-xmpp.org/doc/expat.html seems to point to a domain that no longer exists?

cc: @sonnyp @lloydwatkin

Sorry about that I forgot node-expat had a documentation on node-xmpp website.
I'm working on a new website for node-xmpp, for simplicity and because the website was pretty short I didn't plan on getting it back online before the new one which should happen this weekend.
Since node-expat isn't part of node-xmpp anymore I think we shouldn't include node-expat documentation there, what do you think?

Double checked, actually I removed expat and stringprep documentation from the website a year ago
See https://github.com/node-xmpp/node-xmpp.github.io/commit/889096487f2fb4b97bdd9ede3236b2293d2d05f6

Ok, removed the links.


Skybell not notify when pushed button

When I push button on SkyBell I got ring on phone. But in HA UI I not see that it was pressed...
In logs I see only this:
Updating skybell binary_sensor took longer than the scheduled update interval 0:00:05
2:40 PM helpers/entity_platform.py (WARNING) - message first occurred at February 19, 2020, 2:06 PM and shows up 7208 times

What's problem?

Please fill out the issue template. You can find it by clicking on New Issue and then on Report a bug with Home Assistant.


Update versions to v3.20.1

Description

Update versions to v3.20.1
For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

Out of interest how come this has only been done for v1.20 and not v1.21?


Add Divide for great justice

Let's do this!

Hi StuySplash!
I'm getting spammed by GitHub notifications. 😠


End City Chest Loot Table (and possibly other ones as well) breaking with this mod

Describe the bug
With this mod enabled, the end city loot table gets broken.
Instead of giving the loot when broken or interacted with, you*ll get a stack trace that (for me) doesn't seem to fit to this weird issue.
To Reproduce
Steps to reproduce the behavior:

use setblock to place a Chest with the right loot table:   /setblock ~ ~1 ~ minecraft:chest{LootTable:"minecraft:chests/end_city_treasure"}
break or interact with the newly placed chest (its a good idea to copy it with control + middle mouse button)
if you interact with it, nothing will happen ingame, you'll just get an error in the console
if you break it, nothing will drop and the same error will appear in the console

Expected behavior
The end loot will generate as normal without issues
Versions

OS: Win10
Minecraft Version: 1.18
Fabric Version: 0.12.8
Fabric API Version: 0.43.1
Mod Version: 1.2.3

Additional context
Stack Trace i got while testing

Fixed in 1.1.11 for 1.17.1 and 1.2.5 for 1.18 (which I guess you are more interested in)
Thank you for using my mod and reporting this issue!


Delete suggestions of deleted arcs

(used to be supported in older shell planning)

The PR https://github.com/PolymerLabs/arcs/pull/2486 only addresses deletion of arcs from remote planner.
When arc is deleted from Shell's launcher, the planificator for that arc doesn't even exist. Should I create it and delete the suggestions? @sjmiles please, advise what's the best approach here.


Add outgoing link tracking to analytics

To see which town sites are being searched for and exited to; add to google analytics via events/tag manager

Dupe of #54


fix: pfe-jump-links offset & updates to demo file

Add fake navbar to demo page
Tidy demo CSS
shorten length of paragraphs between panel headings
Add offset variable in the jump links nav

Demo page

@starryeyez024 Can you take a look at why the CI is failing?

Lazarra good to merge


[1.12.2] [TiC] Grinding Balls Unsing Wrong Cast

I noticed that the grinding balls use the gem cast. But I think they should use the pan cast because they round and not "gem molded".

And this should be used instead.

The reason gem was chosen was otherwise you wouldnt be able to have any pan made from enderio metals

And how would you build a pan from our alloys if you got balls from casting the pan?

 :D
I don't thought about that.
But wasn't there a ball cast in previous verions of TiC?

Not that im aware of

Unless some mod added it, no.


[release-1.22] Embedded etcd server does not account for exceeding database space

Backport to branch release-1.22:

https://github.com/k3s-io/k3s/issues/4787

Reproduced the issue in k3s with v1.22.7+k3s1 and Verified the fix with v1.22.8-rc1+k3s1 by following the steps and recording the observations as described in https://github.com/k3s-io/k3s/issues/4787#issuecomment-1076451785


Python refactor

Making this repo a python repo. will keep a separate repo for the npm package.

@phuchle  please see https://github.com/5-gwoap/slng/pull/8 before reviewing this.


fix flaky task tests

@tamarrow yay, thanks for fixing this! I had one suggestion, otherwise LGTM.

thanks @cruhland!


Don't check slider position on mouseup or touchend events

Fix for https://github.com/illright/attractions/issues/379

Hey, thanks for that! Could you run Prettier as well? Then it's good to merge

I've added & formatted it, only github has some degraded performance on pull requests, so it won't show (yet).

Perfect! Thanks a lot. I'll make a PR to release this fix now


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
sanity-inspect-image

✅ Succeeded
56 seconds
clamav-scan

✅ Succeeded
15 seconds
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
16 seconds
sanity-label-check

✅ Succeeded
16 seconds
sanity-optional-label-check

✅ Succeeded
6 seconds
show-summary


Per Device Default Presets

I am not sure if this would be possible with how runelite works but, it would be nice to have an option to automatically load a certain preset when the client is launched based on the device its running on. With this I could have a default preset for my laptop and desktop with graphics settings for each without having to manually switch after the client is launched. This would allow me to be on the same runelite profile and have all the settings I want synced but still be able to keep my graphics settings separate by default.

Can't you have local preset for your graphics settings on each of your devices that you can enable once you switch to a new device? You could have own presets for PC and Laptop to store for example your GPU plugins settings. It's not automatic but really just a single keybind to toggle the preset.
I'm affraid manual toggling would be relative difficult and fairly marginal thing to implement. Problem is to detect the device and whether it is different than last time the RuneLite client was opened on the same profile. I am not sure if RuneLite client has access to such info of the running device.

Yeah I have been switching with local presets on each device which is already much better than having to change everything manually like I used too. Just thought a default would be nice if it is possible.


Taiko's

Title of your project
Taiko projects
Short (1-2 sentence) description of your project
Nice and Big projects
Link to your project
Taiko.xyz
Live on Testnet
Yes (default)
If your project is live on one of Taiko's testnets, please provide evidence of that here (eg. links, screenshots).
No response
Upload a quality logo to your project
No response

Hmm

Done


Hi, does it support different height and width of patch as input, e.g. 224x288

Hi, does it support different height and width of patch as input, e.g. 224x288

Maybe set 7x9 window size for 224x288 patch size？

Maybe set 7x9 window size for 224x288 patch size？

Setting 7x9 window size is a good idea.

How can i set window size to 7x9 as window size is int but not a tuple?


bug:conflicting versions of lacework/lacework provider dependency

Describe the bug
I am getting a conflict in provider versions. Using module lacework_ecr that depends on lacework/lacework ~>1.1 and also depends on module lacework_ecr_iam_role ~> 0.4. However, this leads to using lacework_ecr_iam_role 0.4.5, which requires incompatible version of lacework/lacework ~> 2.0.
This is a snippet from terraform providers:
├── module.lacework_ecr
│   ├── provider[registry.terraform.io/hashicorp/aws] >= 3.0.0
│   ├── provider[registry.terraform.io/hashicorp/time] ~> 0.6
│   ├── provider[registry.terraform.io/lacework/lacework] ~> 1.1
│   └── module.lacework_ecr_iam_role
│       ├── provider[registry.terraform.io/hashicorp/random] >= 2.1.0
│       ├── provider[registry.terraform.io/lacework/lacework] ~> 2.0
│       └── provider[registry.terraform.io/hashicorp/aws] >= 3.0.0

As a result, running terraform init -upgrade leads to:
╷
│ Error: Failed to query available provider packages
│
│ Could not retrieve the list of available versions for provider lacework/lacework: no available releases match the given constraints ~> 1.1, ~>
│ 2.0
╵

Steps to reproduce
Expected behavior
If lacework_ecr_iam_role requires major upgrade of a dependency, it should also increment its version to reflect the impact. In other words, lacework_ecr_iam_role should be 0.5.0.
(Although I would argue, that if it is ment as semver, major increase in a dependency should imply major version increase here. So it would be 1.0.0. But it doesn't seem necessary to fix the bug.)
Please complete the following information):

Terraform Version: v1.5.7
Module Version (see the description)

Hello @jaroslav-muller-jamf.
We recently upgraded lacework provider to 2.0 and consequently all the modules. But in that process our major versions did not get updated for each of these modules.
Are you able to use the latest lacework_ecr as I believe that will remove the conflict


fix: Check that feature owners are able to view the project of a feature

Thanks for submitting a PR! Please check the boxes below:

[ ] I have run pre-commit to check linting
[ ] I have filled in the "Changes" section below?
[ ] I have filled in the "How did you test this code" section below?
[ ] I have used a Conventional Commit title for this Pull Request

Changes
Before users from anywhere could be added to a feature as an owner, even if they were outside the organisation. Now, they must be able to view the project of the feature in order to be added as feature owners. This mirrors much of the existing logic around this part of the codebase, but I could be convinced to make it differently. For example, users as members of the organisation could make sense as well.
How did you test this code?
Updated the existing code, watched the formerly passing test fail, then updated the test and added a new one to make sure users can't be added as owners if they're not affiliated with the feature.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a09436d) 95.61% compared to head (5559a4d) 95.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2931   +/-   ##
=======================================
  Coverage   95.61%   95.61%
=======================================
  Files        1011     1011
  Lines       29023    29038   +15
=======================================
+ Hits        27749    27764   +15
  Misses       1274     1274

Files
Coverage Δ

api/features/views.py
85.62% <100.00%> (+0.17%)
:arrow_up:

...pi/tests/unit/features/test_unit_features_views.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Provide CacheDir function

It would be great if you could provide a function func CacheDir(appname string) (string, error) that (in contrast to CacheFile) only creates the cache dir for appname.
What do you think?

Hi @herzrasen. Thank you for your interest in the library.
Creating a CacheDir function would not be problem at all. However, I'm not sure it's completely necessary as creating a cache application directory is already a one-liner, by using xdg.CacheHome as a base path.
os.MkdirAll(filepath.Join(xdg.CacheHome, "appDir"), os.ModeDir|0700)

What's your use case for this? xdg.CacheFile creates the file and all its parent directories. So when the first cache file is written, all cache directories would be created anyway.

I just re-thought my use case and figured that I indeed could use xdg.CacheFile. The use case I thought of was just to create an application specific cache directory on application startup and create the files I want to store directly. But it is perfectly reasonable to use xdg.CacheFile. Thanks for the hint.


README: context section typo fix (#447)

Remove a duplicate in the table
Use word "set" to emphasize $USER as a shell variable

Closes #447.

Nice work, @light2yellow! Thanks for the PR, and welcome to the project! =)


Question: How to see the assembly code of this lib?

Why I need assembly code:
I am implementing  SwissTable for C#(heavily reference this distinguished lib), but the benchmark result is slow. I do not know whether it is the benchmark problem or I have done something wrong or the C# language design limitation. Currently the bottle neck is find_insert_slot in my C# implementation. So I want to have a look at the assembly code.
What I have tried:
cargo rustc --release -- --emit asm
cargo asm

The first command generated a lot of files under target/release/deps, but it feels like the real data is hidden in .rmeta and .rlib files.
And the second command should list all functions that could be shown, in which I only find one related to hashbrown.
Have I done something wrong? How could I read the assembly code of this lib?

Most of the functions are inlined, so the best way is to create a separate cargo project which uses hashbrown as a dependency and simply calls one function. You can then get the disassembly for that function.
See this example on the playground: https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=b390a0acf79a51ecd71687b46c5e8866


Auth0 allow adding the audience to access api permissions

Hey, I just made a Pull Request!
This PR allows the passing of the audience to auth0. Currently the auth0 implementation allows logging in but it doesn't allow an audience which means that you can't connect to the api, it blocks the access_token being returned, and means that permissions can't be returned.
This moves the auth0 to use passport-auth0 package instead of the base passport-oicd package, it then pulls the audience in from the config files at the base level.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi! As you'll see in the build log, it warns about formatting errors. You may want to enable automatic formatting with prettier in your editor, or do yarn prettier --write plugins/auth-backend/src/providers/auth0/provider.ts

Now prettier is complaining about the changeset file instead :)

ANNNND PRETTIER
:)

You can run yarn prettier:check and yarn lint etc locally before submitting so you don't have to wait for CI here

ANNNND PRETTIER
:)

I know sorry! only found out when in bed 🤞  it works this time!

@freben its ready! 🤣

@freben if it does get approved can you merge it, I will be away for the weekend...

Thanks @freben very kind!


Running recipes in subprojects directly results in warnings about catalog-specific environment variables not existing

Description

If you run just api/init on main, you get messages like this flooding the output:
WARN[0000] The "PROJECT_PY_VERSION" variable is not set. Defaulting to a blank string.

Reproduction

Checkout main
Run just api/up then just api/init.
See warnings.

Ah, I presumed this was something I had just misconfigured! This may also be affected by #1225 when that gets merged

Also thinking that just's .env loading feature could be very helpful here.


Running against standard Postgres container?

I am trying to get EHRbase running with a standard Postgres container by following the instructions here.  After following the instructions I can create a composition, read a composition but can't update a composition - returns 412.  Is there something I have missed?
These are the steps I followed:

Run a standard Postgres container:

$ docker run -d -p 5432:5432 -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD=postgres postgres:12

Run the 'cloud-db-setup.sql' script using psql

$ psql -U postgres < cloud-db-setup.sql

Run the Flyway Maven goal

$ mvn flyway:migrate

Start EHRbase with the following environment entry set

SERVER_AQL_USE-JSQUERY=false

When I try and PUT a new composition I get
412 Precondition Failed
{
    "error": "If-Match header does not match latest existing version",
    "status": "Precondition Failed"
}

Sorry my mistake.  Version numbers begin at 1 👍


Update metrics.rb

Text intros with meter named "something", but every reference thereafter uses "thing". Correcting the meter name.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Just signed the CLA.


feat: beautify login message

What has been done?
feat: beautify login message
Has your code been documented?
ye

I don't think instructions are clear enough.

Thank you for your pull request. After careful consideration, we have decided not to merge your proposed changes. Replacing the login message with the RuneScape name does not align with the goals and user experience we aim to maintain in our project.
In the future, please consider the following principles before submitting a pull request:

Relevance and Alignment with Project Goals: Ensure that your changes are relevant to the project's objectives and overall vision. Each feature or modification should add value and enhance the user experience or functionality.
Simplicity and Clarity: Aim for simplicity. Unnecessary complexities or changes that could confuse users are generally not favorable. The code should be clear and well-documented.
Quality and Testing: High-quality code that is thoroughly tested reduces the chance of introducing bugs. Ensure your code adheres to our coding standards and includes appropriate tests.
User Impact: Consider the impact of your changes on the end-users. Enhancements should be user-centric, improving usability, accessibility, or performance.
Documentation: Any new feature or significant change should be accompanied by corresponding updates in the documentation, explaining how to use the new functionality.
Community Consensus: It's advisable to discuss changes with the community or maintainers before putting effort into changes. This can be done through GitHub issues, discord or our discussion forums.

We appreciate your effort and encourage you to keep these principles in mind for future contributions. If you have any questions or need guidance on a potential feature, feel free to reach out to us.


Question: SQL2017 Installation throws error on readonly mode

Question: Today I noticed SQL installation is throwing an error saying that D drive is read only mode in the summary.txt file in C drive. It was working fine for last one month. I have enabled security mode to SQL and added saaccount. However I have comment out again and testing the old code.
OS: Windows 2016
SQL: Sql 2017
sql server DSC Module version : <IP_ADDRESS>
Any help?

looks like my disk was not initialized properly which resulted in error. After fix the initialization, it worked fine.


Permissions

Traceback (most recent call last):
File "C:\YouTube-shorts-generator-main\main.py", line 17, in
os.remove(directory + file)
PermissionError: [WinError 5] Acces denied
Runned with CMD as a Admin.
Anyone ideas?

Hi, same error is mentioned before. Check out: https://github.com/zackmawaldi/YouTube-shorts-generator/issues/6
It seems to be a common theme with windows and python editing stuff. If you do enough googling, I think you'll find a solution. I worked on this in Linux and Mac. Hope this helps!

On which version of Python did you worked on?

Python 3.8 if I recall correctly. 3+ for sure

Hi @zackmawaldi. I ran into this same problem on Windows 11, and I have tried literally every solution to fix it, but it just doesn't work :( It would be really helpful if you could take a better look at this. Thank you.
Traceback (most recent call last):
File "C:\Users\me\PycharmProjects\YouTube-shorts-generator\main.py", line 17, in
os.remove(directory + file)
PermissionError: [WinError 5] Access is denied: 'temp_clips/redvid_temp'
Process finished with exit code 1

@jxck13 Hmm... I updated the code recently, can you retry it with the new code? (and also sorry for late reply, life got super busy!)

@jxck13 Hmm... I updated the code recently, can you retry it with the new code? (and also sorry for late reply, life got super busy!)

PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'videos2\main_clip.mp4'
error is still here (windows 11,  3.11.4)

Got the same error, the video gets downloaded and the program did work once.
PermissionError: [WinError 32] Het proces heeft geen toegang tot het bestand omdat het door een ander
proces wordt gebruikt: 'temp_clips\main_clip.mp4'
Retrying...


expand test coverage of validate_data script

Several of the functions in the test suite for checking treelist format were incomplete or failed when running the tests. These are currently commented out in test_validate_data.py  script, and can be uncommented, updated, and added to a new pull request once they're fleshed out and working.

THis issue is solved I think. It passes tests on my side


Table-mode: sort ips numerically

Nicely done! Keeping the ip as a padded string rather than converting it into a number works really well and still allows for comparisons w/ domains etc too. 👍
I'm not sure if we really need to render the components to test the sorting though.. you could export function getSortedNodes in node-details-table and test that instead (i think?).

Ooops! The rebase looks like its gone a bit funny (commits from master now in this branch),
You wanna do something like:
git fetch
git rebase origin/master
git push -f

@davkal PTAL before I merge (I will squash all the commits into one as Simon suggested).

LGTM


Update email regex logic in javascript files that handling feedback and signature forms

This is to fix javascript forms that were still having old regex logic for email validation.

LGTM

Worth pointing out that I've dropped the JS from the signature form in my branch for https://www.pivotaltracker.com/story/show/94485346 (incoming real soon now) so maybe we don't need to pay too close attention to this right now.

That said, this is the correct fix so we can merge it.

Thanks for the comments! Merging!


Having issues to understand the process

I have installed zapp-cie via npm and created a new javascript file in iobroker - but receiving this issue:

23:01:56.438
[error]
javascript.0 script.js.Skript1: Error: Cannot find module '/opt/iobroker/node_modules/iobroker.javascript/node_modules/zapp-cie'

23:01:56.438
[error]
javascript.0 at script.js.Skript1:1:14

23:01:56.438
[error]
javascript.0 script.js.Skript1: Error: Cannot find module '/opt/iobroker/node_modules/iobroker.javascript/node_modules/zigbee-shepherd'

update: the issue was the path; but now I receive this error msg:
TypeError: "baudrate" is an unknown option, did you mean "baudRate"?
at new SerialPort (/opt/iobroker/node_modules/serialport/lib/serialport.js:121:11)
at CcZnp.init (/opt/iobroker/node_modules/cc-znp/lib/ccznp.js:115:71)
at Promise.post (/opt/iobroker/node_modules/q/q.js:1181:36)
at Promise.promise.promiseDispatch (/opt/iobroker/node_modules/q/q.js:808:41)
at /opt/iobroker/node_modules/q/q.js:1411:14
at runSingle (/opt/iobroker/node_modules/q/q.js:137:13)
at flush (/opt/iobroker/node_modules/q/q.js:125:13)
at _combinedTickCallback (internal/process/next_tick.js:132:7)
at process._tickCallback (internal/process/next_tick.js:181:9)
at Function.Module.runMain (module.js:696:11)

@wossix I think the problem is not from the zapp-cie.


How to use Redisson to upload byte array?

Hello,
I haven't found an explanation about how to upload pure array of bytes. Redisson has a RBitSet but it manages an array of bits not bytes. How to store a byte array by using Redisson?
Here is my configuration:
Config config = new Config();

LoadBalancer loadBalancer = new RoundRobinLoadBalancer();

config.useClusterServers()
        .setScanInterval(5000) // cluster state scan interval in milliseconds
        .addNodeAddress("<IP_ADDRESS>:6379", "<IP_ADDRESS>:6379")
        .setReadMode(ReadMode.MASTER_SLAVE)
        .setLoadBalancer(loadBalancer)
        .setPassword("bTFBx1NYYWRMTUEyNHhsCg")
        .setSlaveConnectionPoolSize(10)
        .setMasterConnectionPoolSize(10);

RedissonClient redisson = Redisson.create(config);

You can supply a custom codec to achieve this.

Could you please help me with it?
Do you know how to use it?
I see that redisson already has a ByteArrayCodec but I don't know how to use it.
Here is the codec:
Codec codec = new org.redisson.client.codec.ByteArrayCodec();
How to use it to upload a byte array?
To upload a long right now I am using the next code:
RAtomicLong longObject = redisson.getAtomicLong("myLong");
longObject.set(3);

If you want to store binary array. You could you use follow code snippet:
RBucket<byte[]> bucket = redisson.getBucket("myBucket", ByteArrayCodec.INSTANCE);
byte[] myarray = ...
bucket.set(myarray);

Hello Nikita,
Thank you very much for help! It works like a charm :)
I am closing the issue as you have answered the question.
Sincerely,
Alexandr


Cannot enable light theme

Disclaimer: Somehow, I feel like being too stupid to get me a light Material look and feel. 😕
Please just advice the correct steps if possible. ❤
Summary
Cannot enable the lighter variant of the Material Theme in IDEA.
Expected behavior
I get an IDE as documented with the Screenshots seen in the READMEs here.
Actual behavior
The theme is always reset to dark.
Steps to reproduce

Select the Editor Color Scheme ' Material Lighter'
Apply and also Activate the Light IDE theme by accepting the popped up dialog
Notice that the tree views still have dark background
Restart IDEA

The intermediate state before restarting looks like

Environment
IntelliJ IDEA 2017.3 EAP (Ultimate Edition)
Build #IU-173.3622.25, built on November 9, 2017
IntelliJ IDEA EAP User
Expiration date: December 9, 2017
JRE: 1.8.0_152-release-1038-b6 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

Which plugin version? I've just checked and it works good (not EAP)

It is EAP, version 1.3.0-beta5 (latest I could get).

Please dl the last version and tell me if it reproduces

Still no difference with this issue.
The logs do not reveal anything critical AFAICS. I attached it anyway, it is a fresh one from only performing the steps from above.
idea.log
However, I noticed you brought the progress bars back 👍

You're talking about the Light Custom Theme or the Lighter Theme?

The Lighter Editor Color Scheme.
What is the Light Custom Theme? The thing that gets activated after the dialog is being confirmed?

The dialog I am talking about is this one:

Confirming with yes, these settings can be found under Material Custom Theme:

If you change the color scheme, IDEA will ask you if you want to change the Look And Feel of the application, without changing the Material Theme.
I don't know what steps you used but do the following:

Open the Quick Switch (Ctrl+~)
In Material Theme, select "Lighter Theme"
Switch the color scheme to Lighter as well
If the IDEA popup appears, click "NO"
Restart if necessary

Thanks, I did thing the settings were the primary interface.
I'll experiment a bit.
BTW: The 'All actions' (Ctrl+Shift+A) also allowed me to turn the Lighter theme on.


Unnecessary http requests HEAD.

With logging being DEBUG, i see that txtai send requests every time i initialize LLM() class.
DEBUG 2024-01-09 23:58:56,704 Starting new HTTPS connection (1): huggingface.co:443
DEBUG 2024-01-09 23:58:57,075 https://huggingface.co:443 "HEAD /TheBloke/TinyLlama-1.1B-Chat-v1.0-GGUF/resolve/main/tinyllama-1.1b-chat-v1.0.Q4_K_M.gguf HTTP/1.1" 302 0

I have TinyLlama downloaded and would not like to block a service for a short while by them.
Actually i have two questions here:

How to disable this HEAD request?
How to manually download a model, should i do it without txtai or with?

Hello,
These requests are coming from the huggingface_hub library. It's checking to see if a newer version of the file exists. They have an offline mode that disables this - https://huggingface.co/docs/huggingface_hub/v0.20.2/en/package_reference/environment_variables#hfhuboffline
Couple different options for manually downloading.

Run the code once normally and then set the offline parameter
Manually download the files through the web interface. For example - https://huggingface.co/TheBloke/TinyLlama-1.1B-Chat-v1.0-GGUF/blob/main/tinyllama-1.1b-chat-v1.0.Q4_K_M.gguf
Run wget -O tinyllama-1.1b-chat-v1.0.Q4_K_M.gguf https://huggingface.co/TheBloke/TinyLlama-1.1B-Chat-v1.0-GGUF/resolve/main/tinyllama-1.1b-chat-v1.0.Q4_K_M.gguf?download=true

If you manually download the GGUF file and put it in a local directory, the huggingface_hub library is bypassed and the llm pipeline directly loads the file with llama-cpp-python.

Nice, thx. I supposed that as txtai wraps huggingface.pipeline the issue could arise from it and you confirmed. Appreciate it.
Is a path to a local model file the LLM.path argument? It can be a file system path?

That's correct. It first runs os.path.exists on the path and will use that if it does. Otherwise, it falls back to using the huggingface_hub library.

That's correct. It first runs os.path.exists on the path and will use that if it does. Otherwise, it falls back to using the huggingface_hub library.

Great, thx. I prefer to predownload models and then explicitly load them into RAM to keep my service controlable.
By the way, don't you know if it's alright just to delete a model variable, instance to release memory?
Let's say the concept is:
class Loader:
    def load(self, model):
        self.llm = LLM(model)

    def unload(self):
        del self.llm

You could also set self.llm = None.

Thx for help!


TimeLimitExceededError for LDAP

Expected Behavior
The ingestion works successfully

Current Behavior
I get this error
Processor LdapOrgReaderProcessor threw an error while reading ldap-org:ldap://ldap.jumpcloud.com:389; caused by Error: LDAP search at DN "ou=Users,o=xxxx,dc=jumpcloud,dc=com" failed, 3 TimeLimitExceededError: Time Limit Exceeded type=plugin
when ingesting data from LDAP to backstage.
This is only happening when the data is large. I have more than 3000 LDAP users data that need to be ingested. If the data is below 2000, it still works.
Possible Solution

Steps to Reproduce

by following this doc https://backstage.io/docs/integrations/ldap/org
Context

We have a large LDAP users, and all of them need to be inside backstage
Your Environment

NodeJS Version (v14):
Operating System and Version: MacOs Catalina
Browser Information: Chrome

For posterity and others searching for the same problem, did you enable the paged option to get this sorted?


Dart SDK version is 2.1.0-dev.0.0.flutter-be6309690f

I recently updated my version of Dart and when I run the app the console shows the next message

The current Dart SDK version is 2.1.0-dev.0.0.flutter-be6309690f.
Because kaptarapp depends on carousel >=0.1.0 which requires SDK version <2.0.0, version solving failed.
pub get failed (1)

thanks in advance for your help.

i got same error, after update flutter to new version.
temporary solution: copy carousel.dat to your project and disable this plugin.

I vote this up to the author, please upgrade flutter SDK version.

same error

Same error please fix this.


Use the driver pod IP address for spark.driver.bindAddress

What changes were proposed in this pull request?
This PR attempts to fix the issue reported in #523 that may happen if the driver tries to bind to the driver host name before the endpoint controller modifies the DNS configuration.
Changes:
the submission client stops setting spark.driver.host and spark.driver.bindAddress based on the name of the headless service for the driver in DriverAddressConfigurationStep that's renamed to DriverServiceBootstrapStep in this PR. Instead, the driver URL for the executors is constructed at runtime in KubernetesClusterSchedulerBackend based on the name of the driver service. This way, spark.driver.bindAddress is not set and therefore takes the default value that is the IP address of the driver pod. This allows the driver to bind to the address without needing a DNS resolution. The executors will still get the correct driver URL constructed from the driver headless service name in the format $serviceName.$namespace.svc.cluster.local.
@foxish @mccheah @kimoonkim

rerun integration tests please

Has this been tested in production clusters?

Particularly with SPARK-21642 also merged.

Actually I wanted to circle back to this and what we concluded from https://github.com/apache-spark-on-k8s/spark/issues/523.
It sounds like from the comments in the issue, the problem is a race condition when the Endpoints object for the driver's service is not created when the binding occurs.
I wonder if we can just fix the race condition itself. Can the scheduler backend's initialization have a Watch that blocks until the endpoint object is ready before attempting to bind to the given hostname? That seems more idiomatic and fixes the actual underlying problem, rather than working with IP address magic. But there's pros and cons either way.
If we use the IP address, is kube-dns a requirement for this code path? I think we still rely on kube-dns to resolve the K8s master hostname. But relying less on kube-dns seems beneficial anyways.

@mccheah Excellent questions.

Can the scheduler backend's initialization have a Watch that blocks until the endpoint object is ready before attempting to bind to the given hostname?

This might also work. However, it could be difficult to block the binding until the endpoint is ready. Depends on which Spark core classes are in charge of binding the ports. (I think there are actually two, the scheduler backend port and block manager port) Personally, I do not know which core classes handle the binding.

If we use the IP address, is kube-dns a requirement for this code path?

The IP address approach allows the driver to avoid kube-dns dependency. But executors still use the service name to connect to the driver. So I think we still need kube-dns for this feature to work. Note it is still possible for executors to come up before the service endpoint is created. But this race condition is very very unlikely.

I think we still rely on kube-dns to resolve the K8s master hostname

For the k8s master hostname, we are relying on the underlying bare-metal DNS, not kube-dns. kube-dns is only in charge of service to pod mappings.

it is still possible for executors to come up before the service endpoint is created. But this race condition is very very unlikely.

If we wanted, we could block this by having polling for the Endpoints resource's readiness in the scheduler backend - we know for sure that the scheduler needs to initialize before it requests for any executors, unlike with the general case where we don't know when the driver will attempt to bind to an address.
Having it bind to IP address instead seems fine, but I think we want to make sure this is tested with SPARK-21642 merged. If someone can custom build and test Spark with the appropriate patches then that would be fantastic. Something like what @ash211 did with https://github.com/apache-spark-on-k8s/spark/pull/484.

I'm testing a custom build with changes from SPARK-21642. Will report back later.

If we wanted, we could block this by having polling for the Endpoints resource's readiness in the scheduler backend - we know for sure that the scheduler needs to initialize before it requests for any executors, unlike with the general case where we don't know when the driver will attempt to bind to an address.

I agree the scheduler backend should block and wait for the Endpoints resource to become ready before launching executor pods.

That would require a minor and very subtle API break. We allow the driver to be provided specific credentials so that the driver can have only the minimum privilege to create/delete pods. Now, the driver will also need privileges to read the status of endpoints in its namespace. I don't see this as a significant concern but I am noting it here as a reference.

There seems to be an issue with changes from this PR and changes from SPARK-21642. I got the following exception when running the SparkPi example:
Exception in thread "main" java.lang.reflect.UndeclaredThrowableException
	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1713)
	at org.apache.spark.deploy.SparkHadoopUtil.runAsSparkUser(SparkHadoopUtil.scala:66)
	at org.apache.spark.executor.CoarseGrainedExecutorBackend$.run(CoarseGrainedExecutorBackend.scala:188)
	at org.apache.spark.executor.CoarseGrainedExecutorBackend$.main(CoarseGrainedExecutorBackend.scala:284)
	at org.apache.spark.executor.CoarseGrainedExecutorBackend.main(CoarseGrainedExecutorBackend.scala)
Caused by: org.apache.spark.SparkException: Exception thrown in awaitResult:
	at org.apache.spark.util.ThreadUtils$.awaitResult(ThreadUtils.scala:205)
	at org.apache.spark.rpc.RpcTimeout.awaitResult(RpcTimeout.scala:75)
	at org.apache.spark.rpc.RpcEnv.setupEndpointRefByURI(RpcEnv.scala:100)
	at org.apache.spark.rpc.RpcEnv.setupEndpointRef(RpcEnv.scala:108)
	at org.apache.spark.util.RpcUtils$.makeDriverRef(RpcUtils.scala:32)
	at org.apache.spark.SparkEnv$.registerOrLookupEndpoint$1(SparkEnv.scala:300)
	at org.apache.spark.SparkEnv$.create(SparkEnv.scala:314)
	at org.apache.spark.SparkEnv$.createExecutorEnv(SparkEnv.scala:201)
	at org.apache.spark.executor.CoarseGrainedExecutorBackend$$anonfun$run$1.apply$mcV$sp(CoarseGrainedExecutorBackend.scala:223)
	at org.apache.spark.deploy.SparkHadoopUtil$$anon$2.run(SparkHadoopUtil.scala:67)
	at org.apache.spark.deploy.SparkHadoopUtil$$anon$2.run(SparkHadoopUtil.scala:66)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.Subject.doAs(Subject.java:422)
	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1698)
	... 4 more
Caused by: java.io.IOException: Failed to connect to spark-pi-1508813143731-driver:7078
	at org.apache.spark.network.client.TransportClientFactory.createClient(TransportClientFactory.java:232)
	at org.apache.spark.network.client.TransportClientFactory.createClient(TransportClientFactory.java:182)
	at org.apache.spark.rpc.netty.NettyRpcEnv.createClient(NettyRpcEnv.scala:197)

The problem is when the executor started up, CoarseGrainedExecutorBackend tried to create a SparkEnv  and called RpcUtils.makeDriverRef somewhere. makeDriverRef constructs the driver endpoint using RpcAddress(driverHost, driverPort), where the driverHost gets its value from spark.driver.host. With the changes from SPARK-21642, spark.driver.host by default resolves to the hostname of the driver pod, which is by default the name of the pod, i.e., spark-pi-1508813143731-driver. That's why it failed with Failed to connect to spark-pi-1508813143731-driver:7078.
The hostname of the driver pod can be customized using the hostname field of the pod spec. We can definitely change it to the pod IP address in the scheduler backend, and by doing this  spark.driver.host takes the driver pod IP address and the issue will be solved. But I'm not sure if this is defeating the purpose of SPARK-21642.

Actually to solve the issue above, we can just set spark.driver.host in the scheduler backend to the fully-qualified driver service name before creating the executor pods. I will give it a try and report back.

After failing to make the approach above work, this landed onto a totally different approach that finally works. Testing the new solution on a GKE cluster with changes from SPARK-21642 merged. Please see the updated PR description.

I believe the main point of SPARK-21642 was to tie the driver to a hostname instead of an IP address. It seems like moving to set the host to an IP address is a regression in this behavior. Should we still be trying to make this work with the service hostname?

We are still setting spark.driver.host to the driver service DNS name. The only change is to set spark.driver.bindAddress to the actual pod IP address so it doesn't need a DNS resolution when the driver binds to that address.

I believe the main point of SPARK-21642 was to tie the driver to a hostname instead of an IP address.

I was curious why it does that. It is helpful to consider the behavior into two pieces:

Executors connect to the driver using a hostname instead of an IP address.
The driver binds to the service ports using a hostname instead of an IP address.

Is only (1) the point of SPARK-21642? Or (2) is also important for SPARK-21642?

@kimoonkim Very good points. IMO (1) is what SPARK-21642 really is all about. (2) is a side effect of it simply because spark.driver.bindAddress falls back to spark.driver.host if not set.

Looks ok apart from the minor comments.


Windows support?

Hey,
Does this work on Windows systems?
I tried to install it using luarocks install luatz an it actually did, but I can't find it anywhere.

Yes it should; but if you use the timezone functionality then you'll need to provide a path to zoneinfo files; there is no standard location for them on windows.

Well, first I just wanted to make the lua file itself.
Does it compile a dll or .lua?
Because it seems when I install it using luarocks, it doesn't appear anywhere.

Nevermind, did some research, now I just have to somehow get the DB working. I could find these so far.

Closing due to inactivity.
Let me know if your issue remains unsolved.


Add support for hidden session parameters --session-token and --master--token

Pre-review checklist

[ ] I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
[ ] I've added or updated automated unit tests to verify correctness of my new code.
[ ] I've added or updated integration tests to verify correctness of my new code.
[ ] I've confirmed that my changes are working by executing CLI's commands manually.
[ ] I've confirmed that my changes are up-to-date with the target branch.
[ ] I've described my changes in the release notes.
[ ] I've described my changes in the section below.

Changes description
Add support for the session parameters --session-token and --master-token, which can be used to share a connection created with the Python connector or the Node connector.
Notes about having the parameters hidden
I haven't found any public documentation for these parameters, and I think someone mentioned that this is not something that is usually exposed to customers (although it can be created and seen by users of the Node SDK). That is the reason why I believe that maybe this should be kept as a hidden parameter.

@sfc-gh-lmonteromarin should we add an integration tests that verifies this behaviour? I think it would be enough to:

Extract session tokens from snowpark session that we use in integration tests
Execute snow sql -q "set a = 42" -x ... with passing session parameters, the variable should be persisted in the session
Execute snow sql -q "select $a" -x ... to validate that we use the same session.

WDYT?

@sfc-gh-lmonteromarin should we add an integration tests that verifies this behaviour? I think it would be enough to:

Extract session tokens from snowpark session that we use in integration tests
Execute snow sql -q "set a = 42" -x ... with passing session parameters, the variable should be persisted in the session
Execute snow sql -q "select $a" -x ... to validate that we use the same session.

WDYT?

This sounds good to me, I will add it.


amplify codegen weird behavior

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v18.15.0
Amplify CLI Version
12.5.0
What operating system are you using?
Mac M1
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Describe the bug
codegen generates a folder with .swift extension

Expected behavior
config asks for a folder name and/or file names
or everything is in one file
Reproduction steps
amplify codegen
Project Identifier
36e9b7e0e0755079345e8c0297b42039
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

The fix has been released in v12.5.1.


test: enable coverage of crit unit/e2e tests

This pull request enables code coverage for CRIT's unit and e2e tests.

@snprajwal PTAL

Nice change. Moving the unit test to crit/ sounds like the right thing to do.

go test  -v ./...
=== RUN   TestGetDumpStats
--- PASS: TestGetDumpStats (0.00s)
=== RUN   TestGetRestoreStats
--- PASS: TestGetRestoreStats (0.00s)
PASS
ok  	github.com/checkpoint-restore/go-criu/v6/crit	0.004s
?   	github.com/checkpoint-restore/go-criu/v6/crit/cmd	[no test files]
?   	github.com/checkpoint-restore/go-criu/v6/crit/images	[no test files]

This is also a good indicator that we should add some more tests.

@adrianreber crit/images and crit/cmd are being refactored in the other PR, I'll add the tests there for the parts we currently aren't testing

@adrianreber crit/images and crit/cmd are being refactored in the other PR, I'll add the tests there for the parts we currently aren't testing

Sounds good.

One thing I am thinking about is that for unit tests we could always generate test coverage output while using go test. Just to reduce code in the Makefiles. @rst0git what do you think? We can also merge what we have in this PR. Works both for me.

We can have a unit-test target in the top level Makefile (or the Makefile in test) which simply runs go -coverprofile=$COVER_PROFILE_PATH/coverprofile-unit-test test ./... in the root.

We can have a unit-test target in the top level Makefile (or the Makefile in test) which simply runs go -coverprofile=$COVER_PROFILE_PATH/coverprofile-unit-test test ./... in the root.

Sounds like a good idea.

@rst0git works for me. There still seems to be one question open. What about always running unit tests with test coverage results? Unit test coverage does not depend on Go 1.20 and can always be created.

What about always running unit tests with test coverage results? Unit test coverage does not depend on Go 1.20 and can always be created.

I have added a commit to always run the unit tests with test coverage results.


Improve detection of home path. Also allow ~/.grav on Windows, drop ConsoleTrait::isWindows() method, used just for that.

Refs

https://github.com/getgrav/grav/issues/1203
https://github.com/getgrav/grav/issues/1202

i will test it on my windows machine asap.


[UBS Admin.Orders. Orders detailes] The 'Назад' bttn is hidden after zooming on the order details page on 110%,125%,150%

Environment:
Windows 10 Home (Version 22H2)
Chrome version 108.0.5359.71
MacOS version 12.6.1 (21G217)
Chromе version 107.0.5304.110
Reproducible: always
Build found: 25/01/2023
Preconditions

Go to https://www.testgreencity.ga/GreenCityClient/#/ubs
Sign in as Super Admin
Go to the Super Admin profile and choose the UBS-Admin item
Choose the 'Orders' item
Click on the Order's number in the Order table (except orders with 'Виконано'/ 'Скасовано' statuses)

Steps to reproduce

Provide zooming of page from 75% to 175%
Pay attention to the 'Назад' bttn which is situated near the title 'Замовлення №...'

Actual result
The 'Назад' bttn is hidden after zooming on the order details page on 110%,125%,150%
Expected result
All UI controls and elements of the order details page are displayed and adopted according to zoom (responsiveness)
User story and test case links
E.g.: "User story #(https://github.com/ita-social-projects/GreenCity/issues/2787)
"
Labels to be added
"Bug", Priority ("pri: "), Severity ("severity:"), Type ("UI, "Functional"), "API" (for back-end bugs).
https://user-images.githubusercontent.com/110603507/214665816-5bc0ba34-016a-48c1-9746-c9667762cbc2.mp4

The position of the button must match the new mockup


Redesign project details view

It should closely resemble Jonas' scratch design here:

Let's discuss if there are any ideas about a better way to represent the data. Feel free to bring it up.


Opening an evidence link results in oddly sized dialog

Open a model that has a resource.
Click on the first evidence (next to the (1))
A half window is opened

It is impossible to close that window.

Four errors:
react.development.js:209 Warning: Failed prop type: Invalid prop `className` of type `object` supplied to `ForwardRef(Avatar)`, expected `string`.
    at Avatar (

Warning: Failed prop type: Invalid prop `className` of type `object` supplied to `ForwardRef(CardContent)`, expected `string`.
    at CardContent (

Warning: Failed prop type: Invalid prop `className` of type `object` supplied to `ForwardRef(Card)`, expected `string`.
    at Card (

Warning: Failed prop type: Invalid prop `className` of type `object` supplied to `ForwardRef(Button)`, expected `string`.
    at Button (

Moved from https://github.com/Vertex-Labs/meme/issues/6

This warnings are in ResourceView.js, classes is being imported as a javascript object.  Each css style is an object key, and the object value is itself an object.  But each components' className attribute expects a string.
This is going to be a problem for pretty much every MUI component.
Theoretically we can use the styled utility to replace makeStyles and withStyles, but this doesn't help us disentangle ourselves from MUI.  In fact, we would end up spending time converting to MUI5 first.
According to ChatGPT:

The error Invalid prop 'className' of type 'object' supplied to 'ForwardRef(Chip)', expected 'string' typically arises because of a change in how class names are handled between MUI v4 and v5. The core cause is that in MUI v5, the styling system underwent significant changes, including how class names are passed and managed.

In MUI v4, it was common to use the makeStyles hook or withStyles HOC to create classes, which were then passed as objects. However, in MUI v5, the recommended approach is to use the new sx prop and the styled utility, and the class names need to be strings rather than objects.

We might be better off stripping all the MUI components and rebuilding it in pieces.

My gut feeling is to look one level up and look at the source style definitions in meme-styles that are propagating through the old styled-component transformation chain that produced the expected classname. If you don't know the mechanism of what it is doing, you might be missing out on an easier conversion path than if you're just concentrating on React errors on the component level.

Fixed with #25