Fix broken link

Add missing slash in URL which had a space instead and broke the URL.
The change in the last line of the document is unintended. I suspect a trailing newline being added by the GitHub editor. Is that a problem?

@ite-klass : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ite-klass thank you for the submission. Validating.

The update merged. I'm holding this open to see if it automatically closes after the merge in the private repository is pushed to the public repo


Provide descriptive error when chart dir is absent while updating deps

Fixes #1764
Explicitly check if the given chart directory does exist before trying to stat the requirements.yaml file and return a descriptive error if this is not the case. This provides users more guidance than the stat error we returned in the past.
ts=2019-02-26T17:58:36.52551703Z caller=chartsync.go:247 component=chartsync info="Start of releasesync"
ts=2019-02-26T17:58:36.566542344Z caller=chartsync.go:333 component=chartsync warning="Failed to update chart dependencies" namespace=default name=ghost error="chart path /tmp/flux-working475910449/charts/ghost does not exist"
ts=2019-02-26T17:58:36.566698882Z caller=chartsync.go:252 component=chartsync info="End of releasesync"

Can we have a similar message when the dep update is disable?

@stefanprodan this is already the case: https://github.com/weaveworks/flux/blob/193dff6ee957e12f48428edd586472793d366bc3/integrations/helm/release/release.go#L134


[QUERY][OpenTelemetry & Azure Monitor] Filtering Http requests

Library name and version
Azure.Monitor.OpenTelemetry.AspNetCore 1.2.0
Query/Question
Hi,
Prologue
We use built-in .NET Core authentication/authorization with multiple schemes for different OpenID providers. Each time I request my API, first call makes requests to all OpenID providers' ".well-known" endpoints. So far it's ok. But it creates request and dependency traces for each operation in Application Insights. That traces are totally irrelevant for us and we would like to filter them. I followed your guidelines and did something like this:
builder.Services.AddOpenTelemetry().UseAzureMonitor();
builder.Services.Configure<HttpClientTraceInstrumentationOptions>(options =>
{
    options.FilterHttpRequestMessage = req =>
        !req.RequestUri.ToString().Contains(".well-known");
});

Problems

When I do that it still creates "request" telemetry types, even though the condition above is correct. (picture below)
UseAzureMonitor has it's own configured Http instrumentation, which is overridden when I do that.

Questions

How I can fully filter them out? Give me some suggestions please.
Overriding Http instrumentation seems to me like a violation in the opposite to UseAzureMonitor, as it has its own purpose. I would see that those filtering as additive, instead of replacement. Am I doing something wrong or for know it's the only way to do that?
I created ActivityFilteringProcessor with setting up IsAllDataRequested = false but it does not totally filter out the traces.

BR
Environment

Windows 10

Visual Studio 2022 17.10.1

.NET SDK:
Version:           8.0.300
Commit:            326f6e68b2
Workload version:  8.0.300-manifests.4e5ea2d8
MSBuild version:   17.10.4+10fbfbf2e

Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19045
OS Platform: Windows
RID:         win-x64
Base Path:   C:\Program Files\dotnet\sdk\8.0.300\

It can be closed. Finally, I managed it.
internal class OpenIdFilteringProcessor : BaseProcessor<Activity>
{
    public override void OnEnd(Activity data)
    {
        if (data.Kind == ActivityKind.Client && data.GetTagItem("url.full") is string url && url.Contains(".well-known"))
        {
            data.ActivityTraceFlags &= ~ActivityTraceFlags.Recorded;
        }
    }
}

(...)

builder.Services.ConfigureOpenTelemetryTracerProvider(builder => builder.AddProcessor<OpenIdFilteringProcessor>());
builder.Services.AddOpenTelemetry().UseAzureMonitor();

Suggestion: I think you should change here from activity.IsAllDataRequested = false; to activity.ActivityTraceFlags &= ~ActivityTraceFlags.Recorded;


Intrested in more automation? AutoPkg 4 Win!

Hi Gorilla users,
Somebody interested in putting this one or two steps furter?
The past several months, i pushed AutoPkg for Windows to a usable level.
See: https://github.com/NickETH/autopkg
Nick

how will this function with the new autopkg 2 in python3?

Interesting! Will you be creating a PR to get it merged upstream or will this remain as a fork?

Hi erik and andrew,
The AutoPkg 4 Win Version 2.x with Python 3 compatibility will be released in the next few weeks. All the main things have been ported. But it needs some testing.
I cannot tell you, if there will ever be an upstream merge. But i will stay as close as possible with main branch, so all the new things can always make it with reasonable effort to the Windows release.
Nick

@NickETH Thanks for sharing!
Looking forward to trying it our!


Any way to expose whether a mesh bulb is currently displaying color or white?

I haven't been able to find anything in the provided bulb info that indicates whether a mesh bulb is currently in color mode or white mode. Wondering if there's anything the bulb can give you that would allow you to expose it via the API? It's something that would be useful to know for my application, if it's possible to do.

Hi John,
The mesh/color bulb has 2 fields related to color: temperature and color.
The logic in the Wyze app appears to toggle whether the bulb is in white or
color mode based on whether the temperature property is set and non-zero.
Give that a shot?
On Wed, Sep 1, 2021 at 7:09 PM John Torgerson @.***>
wrote:

I haven't been able to find anything in the provided bulb info that
indicates whether a mesh bulb is currently in color mode or white mode.
Wondering if there's anything the bulb can give you that would allow you to
expose it via the API? It's something that would be useful to know for my
application, if it's possible to do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/shauntarves/wyze-sdk/issues/41, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEDBMCN6IRMBNFSERMZ6VDT72XDLANCNFSM5DHTC6AQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hey, thanks for getting back to me, sorry about the delay responding to you. The python API seems to report the last used temperature and the last used color setting for each bulb regardless of which mode it is currently in, so it seems there's no way (currently) to tell which. Is it perhaps the case that the bulb itself is updating/erasing the temperature value when put into color mode but the API just isn't picking up on it somehow? Although I'm not sure how it would remember what the last value was if it isn't getting the info from the bulb every time...

This has been added as a new field in Bulb called control_mode (https://github.com/shauntarves/wyze-sdk/blob/master/wyze_sdk/models/devices/lights.py#L159) and is backed by a new enum LightControlMode (https://github.com/shauntarves/wyze-sdk/blob/master/wyze_sdk/models/devices/lights.py#L11-L31)


feat: port data.set.intervals.pi

I changed a single proof, Icc_diff_pi_univ_Ioo_subset because the simpa got lost somewhere along the way. It did produce an existential statement in the end but it was not the correct one it seems. Since the proof was easy enough to fix without simpa I just did that instead of figuring out what exactly is going wrong.

You don't need to change => to ↦ by the way. Most people don't, but I don't think it matters either way.
bors merge

I force pushed to make the simp proof a little better, you'll have to merge again /o\

bors merge


Fix for Manage HH Page when Undeliverable Address permissions are missing

Critical Changes
Changes

We fixed an issue with the Manage Household page where the page wouldn't load without permissions to Undeliverable Address fields.

Issues Closed
Fixes #6733
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

@lparrott I just pushed https://github.com/SalesforceFoundation/NPSP/pull/6749/commits/e6a06dbf68c78e8c8ba32192b33d49a40647e476 to address the spinner not clearing when the permissions error is thrown. FYI @bdvorachek I believed you flagged this when we first looked at this. This should now at least keep the page from being inaccessible whenever the user doesn't correct FLS.


log-backup: adapt user-defined TLS config

Signed-off-by: Yu Juncen<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #12668
What's Changed:

Added a new metastore type LazyEtcd, which supports connecting with TLS.
Modify the Endpoint::new, now it receives MetaStore instead of endpoints.

log-backup: adapt user-defined TLS config

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
I have tested it by:

Create a cluster by tiup.
Enable TLS by tiup cluster tls <cluster-name> enable.
Run log backup, there should not be errors or panic.

No code

Release note
Fix a bug that caused PiTR cannot work if some of `security.{ca-path, cert-path, key-path}` configured.

/merge


Blocks messed up when switching from Github view to blocks

Describe the bug

No consistent repro, but seems different from the other "code loss" issues seen so far so recording it here for tracking.
Other code loss bugs (for reference):
https://github.com/microsoft/pxt-arcade/issues/2841
https://github.com/microsoft/pxt-arcade/issues/1840

code loss when deleting extension https://github.com/microsoft/pxt-arcade/issues/776


Missing update after (un)staging a chunk in the diff viewer

After pressing the "Stage" button on a blue highlighted chunk in the diff viewer, the remaining text scrolls up so that the next chunk is placed exactly under the mouse cursor, but the blue chunk overlay with the buttons never shows until the mouse is moved or the scrollwheel is used.

There should be an extra check for new chunk highlights after staging, unstaging and dismissing a chunk.
Minimal Reproduction Project
Chunks.zip

It's because that Avalonia, the UI Framework this app is used, only allows user accessing mouse position in one of these event:

PointerEntered
PointerMoved
PointerPressed
PointerReleased
PointerExited
PointerPointWheelChanged

In anther word, without a mouse event, there's no way to get mouse position……
After you press the Stage/Unstage/Discard button, the text diff view will not update immediately.

a background task will be started to patch selected chunk to worktree/index
the file system watcher detects worktree/index changed, then it will updates current local changes
if selected file in unstaged/staged list is changed, viewmodel will reload the diff content
after diff content in viewmodels changed, the UI updates
now it's ready to update selected chunk, but there's no way to get mouse position without events.

I've tried to save the last mouse position, but it introduces more bugs……

Finally, adding a PointerEntered event solved this problem 😂.


Add parseGidWithParams, createComposeGidFunction and update composeGid to support params

Description
Following what was done in https://github.com/Shopify/quilt/pull/1524, I'm making a PR to fully support params in parseGidWithParams and also composeGid. I also added a factory function to create a custom composeGid with a specific namespace.

[x] admin-graphql-api-utilities: Minor

@BPScott @michenly @alexandcote - I've updated the PR to remove the usage of Object.fromEntries which requires TS to be enabled with ES2019 and the update to Node 12 since we're not ready yet to do these things here.

Can I get a new review on this please? :) @michenly @alexandcote @BPScott


Is it possible to limit the number of results that are been rendered?

Hi, I want to know if Is it possible to limit the number of results that are been rendered?

@sagomezza why did you close this issue without an answer? did you find a way to limit the results?

@supercamilo Yeah, I just gave the listView a defined height

Not a very valid answer... You just hide them, not restrict them


feat(CardLoader): new component

** Please provide as much detail as possible, but feel free to remove irrelevant sections **
Introduce generic card loader, to enable job details team create a job preview loader
http://seek-asia-style-guide--b6ad3fb777198b18641a1564ac76352c263eab74.surge.sh/CardLoader
BREAKING CHANGE:
{{ Description of breaking API change }}
RFC URL:
{{ URL of associated RFC for API change }}
MIGRATION GUIDE:
Before:
{{ Old code }}

After:
{{ New code }}

EXAMPLE USAGE:
{{ Code }}

http://seek-asia-style-guide--b6ad3fb777198b18641a1564ac76352c263eab74.surge.sh/CardLoader


Update vockinger.yml

Hi @vockinger it looks like you got this mostly right but the file was submitted to the root directory, and the automation to process this will only trigger if it is posted to the correct directory. Please repeat the steps but be sure to click add file from the following page to ensure it gets posted to the proper directory: https://github.com/ModernAppsNinja/vspheretanzu101_vt7301/tree/main/static/admin/userdata/registered_members. Thank you!

Hi, the vockinger.yml was in the directory, you wrote.......
Whenever I try to change something there, I get the answer:
@vockinger you have successfully registered for this course. A new member record card for this course has been posted to your member repository at https://github.com/modernappsninjas/vockinger/course/vspheretanzu101_vt7301.md. This PR will now be closed.
But this file still does not exist.....


Use interface instead of implementation for http.client.

In options there is the ability to pass in a http client. This currently has to be a *http.Client.
I have updated this to instead be an interface that satisfies the following:
type HttpClient interface {
	Do(req *http.Request) (*http.Response, error)
}

This makes it much easier to test code that uses this library as you can then use a mock http client that satisfies the interface.
I have run both linting and tests
Thanks!

Thank you for your contribution! I certainly can see the use case for an interface here.
I can't accept the PR as is, because it breaks backwards compatibility. But there are a couple ways that will not break backwards compatibility.
One such way is to add another field to keyfunc.Options. This new field would be the interface. I would imagine the http.RoundTripper would satisfy this use case.
After that field is added, there needs to be a way to select either Options.Client (of type *http.Client) or the newly added field, (probably of typehttp.RoundTripper). The *http.Client should be selected first, if not nil, it is the most common use case. The newly added field should be selected second, if not nil. If both are both given as nil, then http.DefaultClient should be assigned to the Options.Client field during setup.

Thanks for such a quick response :)
I'm still newish to Go and trying to get my head around the language and syntax :)
I believe that this isn't a breaking change - and should be safe to merge as a patch release.
At the moment the code requires that it is passed a *http.Client - and this will therefor contain the Do function.
With this change the code will accept any struct - as long as it implements the Do function - this includes http.Client. This must be safe for all existing uses of this  - everyone who is currently passing an *http.Client can continue to do so with no change from them.
This change will just allow people to pass other structs as long as they also implement the Do function.
I've validated this myself, with creating a http.Client and passing to both the old and new code and get no issues.
Happy to make the change as you've suggested, but not sure if it's needed - also feel it complicates the API and will lead to a breaking change in the future when support for the old option is dropped.
Thanks!!

That is correct. It's not a breaking change, sorry for the confusion and thank you for correcting me on that.
I wish that *http.Client implemented the http.RoundTripper interface or another interface from its own package. I'm hesitant to create and export an interface for something specific to the http package.
I'd prefer to keep the type of the Options.Client field as *http.Client. I feel that it's more explicit, but with a drawback of having to conform to the http package.
Now that I'm looking into this more, I'm thinking it may be best to leave it as is. However it may be helpful to have an example for this use case.
Here's a an example of a custom *http.Client. I believe a developer could accomplish the testing goal outlined in this PR by editing the RoundTrip method of the customRoundTrip data structure.
If this example accomplishes your goals, would you like to modify it, to make it more complete, and change the PR to contribute an example to the examples directory?
package main

import (
	"log"
	"net/http"

	"github.com/MicahParks/keyfunc"
)

type customRoundTrip struct{}

func (c customRoundTrip) RoundTrip(request *http.Request) (*http.Response, error) {
	log.Printf("%+v", request)
	// TODO Implement a custom round trip here.
	return &http.Response{}, nil
}

func main() {
	myRoundTrip := customRoundTrip{}

	client := &http.Client{
		Transport: myRoundTrip,
	}

	options := keyfunc.Options{
		Client: client,
	}

	_, err := keyfunc.Get("https://jwks-service.appspot.com/.well-known/jwks.json", options)
	if err != nil {
		log.Fatalln(err.Error())
	}
}

Amazing - that works perfectly thanks.
Will update the PR to remove the code change and just add an example - thanks!

There hasn't been any activity on this PR in two weeks. I'm closing it due to inactivity, but please feel free to reopen it or make another if there is future activity :slightly_smiling_face:


Maximum Width of Binary Tree

 I feel happy in contributing in this repo.
Have you read the [Contributing Guidelines on Pull Requests]
Yes
(https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTING.md#pull-requests)?
(Write your answer here.)
A binary tree is a tree-type non-linear data structure with a maximum of two children for each parent. Maximum Width of Binary Tree is the count of maximum number of nodes present at a level.
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)
This PR is made under issue #3655

I have formatted the code as suggested. Kindly review it.


[bug] v.17 video not starting

describe the bug
2024-12-14T05:26:52.317571Z  WARN screenpipe: screenpipe PATH check failed: the PATH is too long to persist using 'setx'. please shorten the PATH.
2024-12-14T05:26:52.317594Z  WARN screenpipe: please ensure screenpipe is installed correctly and is in your PATH
system info
win11

additional context

video not starting even after pressing start

please share more logs this is not helpful


Can this Extension be updated so that we can use it on https://vscode.dev which is just vs code in the browser.

I'm submitting this request so that this extension can be updated so that we can use it on https://vscode.dev which is just vs code in a browser.

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[x ] Feature request
[ ] Documentation issue or request
[ ] Other: <!-- Please describe: -->

right now, we can't use the live server extension on that site. hopefully, this can be fixed.

I just wanted to ask the same question🔥


How can I "unmaximise" after maximising window?

After upgrading to 2.1.3, I can no longer unmaximise the window in an Electron app. This worked in version 1.0.8.
To Reproduce

Instantiate a TitleBar with prop: onMaximize={ () => remote.getCurrentWindow().maximize() }
Run app and click on the Maximise button.
Click Maximise button again.
Nothing happens.

Expected behavior
After maximising, the button should change appearance, and clicking again should revert the window to its previous dimensions.
I could of course write my own logic in the onMaximize handler, but I still wouldn't get the right icon shown in the maximised state.
Desktop (please complete the following information):

OS: Windows 10

My current solution is:
componentDidMount() {
    const currentWindow = remote.getCurrentWindow();
    currentWindow.on("maximize", () => this.setState({ maximized: true }));
    currentWindow.on("unmaximize", () => this.setState({ maximized: false }));
  }

  componentWillUnmount() {
    const currentWindow = remote.getCurrentWindow();
    currentWindow.removeListener("maximize", () =>
      this.setState({ maximized: true })
    );
    currentWindow.removeListener("unmaximize", () =>
      this.setState({ maximized: false })
    );
  }

And then in the props do
onMaximize={() => {
              if (this.state.maximized) {
                currentWindow.unmaximize();
              } else {
                currentWindow.maximize();
              }
            }}

However, like you said, the buttons don't change icons. I think it was lost between v1.x to the newer versions. I would be down to  help re-implementing it though a PR if it's needed.

Thanks for posting a solution, @anqingchen.
Unforunately I don't really have time to work on a PR for this library at the moment, so I will revert back down to 1.0.8 for now as that version was working just fine for me.

@anqingchen the title bar component changed in v2 to call onMaximize, onMinimize, onClose props when the window control buttons are pressed to remove electron as a dependency. It allows apps to individually handle their own application logic. I just noticed that the maximize icon doesn't update once maximized to the restore icon. Working on a solution that will be released with v2.2. Thanks!

great project. any update on unmaximise?


Response: expose remove_header

From http_types::Response
Useful for e.g. compression middleware where content-length is normally stripped.

It occurs to me that this is probably using the old HeaderName signature, but that doesn't appear to be updated for header and remove_header in http_types::Response compared to inster_header: https://docs.rs/http-types/1.2.0/http_types/struct.Response.html

@Fishrock123 it'll change again with http-types 2.0, which the next release of Tide will be blocked on. I'm happy to merge this as-is to enable this functionality (:


change value to default value in edit sqlcmd variable prompt

Updating the string to make it more clear that it's the default value of the SQLCMD variable that will get updated

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.005%) to 41.741%

Files with Coverage Reduction
New Missed Lines
%

extensions/machine-learning/src/common/processService.ts
3
77.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
30502

Relevant Lines:
67681

💛  - Coveralls


Broken links in documentation

          Related, there are broken links to url for the weights here  https://bioimage.io/docs/#/guides/developers-guide?id=model-documentation

Originally posted by @esgomezm in https://github.com/bioimage-io/bioimage.io/issues/388#issuecomment-2147621959

This was solved some time ago. Thanks for pointing it out!


[Maven] Use predefined JAVA_HOME variable

Type: Feature
Enter Task Name: Maven
Issue Description
I'm running my Maven build inside a container with only one JDK and Maven installed. I already have a JAVA_HOME correctly set, so I don't need Maven Task to set it for me.
There is no optimal solution for me now: 1) I can change my Docker image to set a "JAVA_HOME__" variable that would be used only on Azure Devops; or 2) use "javaHomeOption: 'Path'" which is not as generic as a JAVA_HOME environment variable.
I propose the creation of a new "javaHomeOption" value that uses the predefined JAVA_HOME variable. Perhaps this should be the default option, as "JAVA_HOME" is default on a Java build environment.

The conventional method for selecting among installed Java versions, familiar to all java developers, is to set environment variable JAVA_HOME.
In selecting among Javas pre-installed on Azure pipelines, this approach is difficult because it requires an Azure pipeline developer to know the locations of the several Javas, or the several respective environment variables, which are not apparent in the UI and which are not documented.
Further, on Microsoft hosted agents, the currently active Java version is referenced in the PATH  without reference to the JAVA_HOME environment variable, so after setting JAVA_HOME you are not done.

script: |
echo "##vso[task.setvariable variable=JAVA_HOME]$(JAVA_HOME_11_X64)"
echo "##vso[task.setvariable variable=PATH]$(JAVA_HOME_11_X64)\bin;$(PATH)"
displayName: "Set java version"

The above circumvention is unsatisfying still since it merely tacks the selected Java on the front of the PATH, leaving the default Java later in the PATH, lengthening the PATH, thus increasing compute time for all program executions.
The Java Tool installer knows how to deal with this, and could accomplish the version selection more accurately and efficiently.


Badges

This adds badges to the app. They are displayed in the profile and are given for doing well in challenges and for having high scores.

after fixing conflicts, the code works and fits the task


feat: Kind Cluster with Config

Add a new function to be able to create a KinD cluster with image and config
Add a new testing file for the new cluster with Config (Image and kind-config.yaml)

Fixes: #72

Hi @helayoty 👋 This is a great contribution. I left some comments that suggest some code re-organization.
Basically, the go test and configuration you provided would be better in the examples directory. I would suggest to create directory examples/kind and place your Go test file and the kind config file. Take a look at other examples for guidance.

Thanks for the review. I've resolved all comments.

@helayoty you have lint check failing.
Run ./hack/verify-golangci-lint.sh on your local code to check.
Once fixed, ping me I will re-approve.

/retest

One last thing (sorry forgot to ask). Would you mind squashing your commits. Then I will approve.

Done :)


Test drpc delete on placementRule delete

When a placementRule is deleted, then we processDeletion() for the DRPC that has the PlacementRule as its placement object. However, we don't delete the DRPC itself.
This PR is to start the conversation on this topic and decide if we want to issue a delete for the DRPC itself in such cases.

Placement as the owner is already set with `updateAndSetOwner'
So when Placement is deleted DRPC is deleted as well.

The DRPC does get a deletion timestamp but because we rely on the placement obj to exist, we keep erroring out with the error
 2024-03-23T03:30:32.796Z	ERROR	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"drpc-name","namespace":"drpc-namespace"}, "namespace": "drpc-namespace", "name": "drpc-name", "reconcileID": "965fa8f4-de3c-47ce-a045-24c0b975109a", "error": "Placement.cluster.open-cluster-management.io \"user-placement-rule\" not found"}
  sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329
  sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266
  sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227

The question is if we want to process the deletion of DRPC completely or if it is better to be in this error state forever?

@raghavendra-talur is this still an issue to resolve?


Deployment

Deployment
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

ok, checked what the # is doing, getting there :D

Deployed!


implemented random_normal_wrapper to call np.random.Generator.standar…

Addressing the below error of unexpected kwarg dtype.
As np.random.randn does not accept keyword dtype, random.Generator.standard_normal(size=None, dtype=np.float64, out=None) is called instead. To create a random generator, an additional wrapper function, random_normal_wrapper, is implemented.
randn() got an unexpected keyword argument 'dtype```

Not sure whether I should correct python format failure in the checks above.

this is a good effort but the dtype here won't be the right kind (it's gonna be our dtype rather than np.dtype). also you don't need the factory pattern here since it's only going to be used for one function.


Could you please add a tutorial/example for the plugin.

Hello @troilus.
As per your suggestion, I've added an example to the repo's README.md file.


Configuring non root sudoer for molecule tests

Adding Redis config which I forgot in initial scenario PR for user_provided
Adding non-root sudoer configuration for our scenario tests to emulate a real user environment
Changed shell commands to ansible collections, such as lineinfile
(Waiting for tf access so I can personally snoop around our molecule scenarios on a tf vm before merge)

It seems that something is wrong with the way password is provided/used. From the failed task:
  fatal: [<IP_ADDRESS>]: FAILED! => {"msg": "Incorrect sudo password"}

OIDC instance down so CI won't pass + createtree container fails to spin up on centOS but is fine on RHEL. Will test again once identity instance is back to remove an outside factor in failure but all works as it should on a RHEL machine.

I constantly ran into the createtree issue before today, but after rebasing with the new Dex OIDC config + changing a small discrepancy it seems to work fine? Still not sure what the underlying issue was


[BUG] Baron Timer and Elder Timer not appear

When i click the Baron Timer and Elder Timer, nothing happened on the screen when the team kill the Baron and Elder .Is there anything i have to do before i click the Baron Timer and Elder Timer? or how can i fix it?
Another question is the dragon icon not appear under the score after the team kill it.

You can follow this instruction, all bug will be fixed. https://github.com/floh22/LeagueBroadcast/issues/8#issuecomment-839817187

Sorry, I am confusing that I should add the following to which file?
[LiveEvents]
Enable=1
Port=34243

I add it into Game\Config\game.
But when the match start,it stuck on loading screen.
After a minute, the game crash.

That help, thanks.


Few questions about the library regarding performance

I went through some of the code for PPO and it seems to be still using numpy arrays which are used in the observation spaces and actions spaces. So i'm guessing that the environments are still on the cpu and their steps also take place on the CPU...(correct me if I'm wrong). So does this mean that this library doesn't address the issue of CPU-GPU Data transfer. So all the speed up is basically just due to the optimization taking place using jax jit complied codes  only  for the policy optimization part... Am I right?... Could you guys please add support for  Custom environments created on the GPU? Maybe I could contribute? I currently have jitted jax environment entirely on GPU and i wanted to just use existing libraries to train the policy but apparently all the libraries use some sort of conventional environment library on which their code is based. My environment is build from scratch using jax and contains the main step() and reset() functions. But now i am stuck with the only option to implement the policy and optimization code all on my own. So I just want to know if there is anyway your library can be used on a custom Environment where all the functions are stateless.

So i'm guessing that the environments are still on the cpu and their steps also take place on the CPU.

yes

doesn't address the issue of CPU-GPU Data transfer.

for PPO, when not using images, (and when not using isaac sim), there is no need for GPU.
(see runtime reports from https://rlj.cs.umass.edu/2024/papers/Paper18.html and several issues about that on SB3 repo)

just due to the optimization taking place using jax jit complied codes only for the policy optimization part.

and for the policy/value prediction.

Could you guys please add support for Custom environments created on the GPU?

This is currently not planned (as SBX is based on SB3).
However, if you want no data transfer, you will need:

Custom vec env (with have some examples, including for isaac sim in SB3 doc)
Custom replay buffer (should not be too hard)
You might need to remove some calls to .numpy() in SB3 (I'm not 100% sure about that part)

if you do so, please open source your fork of SBX, it might be helpful for others.


Rename unifcv.txt to unicv.txt

The university domain just changed.

@RECOHA Thank you for your patience while waiting for a review and processing your request. Pull request merged.


fix: move @types/pino to devDependencies

Have you read why @types/pino was moved to dependencies? https://github.com/ydb-platform/ydb-nodejs-sdk/pull/36

Closing this one as merging it would bring to life previous problem solved in #36


Multiline events with blank lines missing in Splunk

What happened:
Multiline events containing blank lines do not show up in Splunk
What you expected to happen:
Multiline events with blank lines should show up in Splunk
How to reproduce it (as minimally and precisely as possible):
Configure multiline events:
splunk-kubernetes-logging:
  logs:
    default:
      from:
        pod: "*"
        container: "*"
      multiline:
        firstline: /\d{4}\-\d{2}\-\d{2} \d{2}\:\d{2}\:\d{2}[\.\,]\d{3}/

Log a multiline event with a blank line, such as:
2021-11-17 19:12:28.398 Line 1
Line 2

Line 3

The event does not show up in Splunk
Anything else we need to know?:
Events without blank lines show up correctly in Splunk. For example:
2021-11-17 19:12:28.398 Line 1
Line 2
Line 3

Environment:

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.4", GitCommit:"e87da0bd6e03ec3fea7933c4b5263d151aafd07c", GitTreeState:"clean", BuildDate:"2021-02-18T16:12:00Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.6", GitCommit:"8a62859e515889f07e3e3be6a1080413f17cf2c3", GitTreeState:"clean", BuildDate:"2021-04-15T03:19:55Z", GoVersion:"go1.15.10", Compiler:"gc", Platform:"linux/amd64"}

Ruby version (use ruby --version):
OS (e.g: cat /etc/os-release):

NAME="Oracle Linux Server"
VERSION="7.9"
ID="ol"
ID_LIKE="fedora"
VARIANT="Server"
VARIANT_ID="server"
VERSION_ID="7.9"
PRETTY_NAME="Oracle Linux Server 7.9"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:oracle:linux:7:9:server"
HOME_URL="https://linux.oracle.com/"
BUG_REPORT_URL="https://bugzilla.oracle.com/"
ORACLE_BUGZILLA_PRODUCT="Oracle Linux 7"
ORACLE_BUGZILLA_PRODUCT_VERSION=7.9
ORACLE_SUPPORT_PRODUCT="Oracle Linux"
ORACLE_SUPPORT_PRODUCT_VERSION=7.9

Splunk version: 8.2.2 Build 87344edfcdb4
Splunk Connect for Kubernetes helm chart version: splunk-connect-for-kubernetes-1.4.9

Hi @epernice ,
The same issue was raised #597 , which is resolved in the 1.4.10 release .
PR for the same : #664 .
Let us know if you're still facing the issue . Thanks!

Updating to 1.4.10 resolved the issue - thanks!


Selection border has high priority than focus border

Issue Type: Bug

Open endgame.github-issues
Set customized colors

            "notebook.cellBorderColor": "#899ba636",
            "notebook.cellInsertionIndicator": "#83afe5",
            "notebook.cellStatusBarItemHoverBackground": "#ffffff26",
            "notebookStatusErrorIcon.foreground": "#df8c8c",
            "notebookStatusRunningIcon.foreground": "#cccccc",
            "notebookStatusSuccessIcon.foreground": "#a8ce93",
            "notebook.focusedCellBorder": "#83afe5",
            "notebook.focusedEditorBorder": "#83afe5",
            "notebook.inactiveFocusedCellBorder": "#83afe599",
            "notebook.selectedCellBorder": "#a8ce93",
            "notebook.selectedCellBackground": "#6a7d89"

Click on the cell container, it shows the focus border

Click on the cell editor, it shows the selection border

VS Code version: Code - Insiders 1.55.0-insider (a6f6b4aa8e3a688d9a5cbcd5df14af511ce2bd8e, 2021-03-23T05:13:33.822Z)
OS version: Darwin x64 20.3.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
32.00GB (0.16GB free)

Process Argv
--enable-proposed-api ms-vscode.vscode-notebook-history --enable-proposed-api vscode.notebook-editing --enable-proposed-api vscode.vscode-test-resolver --crash-reporter-id 1a907bbd-fa02-4595-81e0-63e1648afb31

Screen Reader
no

VM
0%

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30263608
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvsnew554:30265444
pythontb:30258533
pythonvspyt943:30277000
wslfolderdoccf:30278406
vsc_aa:30263845
vspre833:30267464
vshan820:30276952

This is because your selection cell color is green:
"notebook.selectedCellBorder": "#a8ce93",
This is the color of the cell when it's selected and the focus is in the editor. My suggestions is to use a less strong color here like:
"notebook.selectedCellBorder": "#899ba636",

Will close this as as-designed but feel free to re-open if you disagree.


Test UPM support

Support is proven locally; however cosmetic errors may arise as metafiles are generated for empty directories which don't git.

This can be tested by just adding the package to a Unity project, either from disk or via URL

UPM support verified


Expose docs generation through make

The error is weird, went smooth for me.

@maxjacobson Could it be some local permission not allowing the user within docker to write to the directory?

@filipesperandio yeah I think so. Possibly a linux/mac difference.
@wfleming perhaps you know the docker magic invocation to make this work?

It's running as user id 9000 which doesn't exist on the host machine & doesn't have write permissions. My guess is it works for Filipe because of some weird Docker for Mac host-fs-virtualization magic to handle permissions between the host/the VM that actually hosts docker. I think the easy fix is to pass --user root to the docker run. (which might lead to people needing to sudo chown locally for some things, but we do that in other cases and it's fine.)

Cool, I can confirm that adding --user root helps for me on linux. Do things still work for you with that change @filipesperandio?

(Thanks @wfleming!)

@maxjacobson @wfleming That works on mac too! 👍


[Voting] Promoting @juzhiyuan as a member of Committer Team

Proposal
@juzhiyuan is a freelancer, who help us a lot:

Implemented dashboard of APISIX
Provide suggestions for docs

Please vote for promoting.  @iresty/pmc @iresty/committer-team
Voters can either respond "agree, yes, +1", "disagree, no, -1", or "abstain".

All contributors have the chance to join PMC or committer team, which depends on your contribution, and a proposal by one of the existing member.

+1

+1

+1

+1

all @iresty/pmc and @iresty/committer-team have voted. And we have 3 yes. So congrats @juzhiyuan to join the committer team. I will send the invitation to @juzhiyuan and update the team list.
Thanks, every one.


Appears advertising packet doesn't include ServiceIDList

Recently pulled up an old RFDuino demo and it no longer works w/ Android! When I put the same URL into an Eddystone beacon, everything worked. Here is a hex dump of both devices, each with the same compressed URL: tiny.cc/cp9000
RFDuino
0x0201061416AAFE10EE0274696E792E63632F636239303030
Simple Eddystone beacon
0x0201060303AAFE1416AAFE10DE0274696E792E63632F636239303030
Notice that the RFDuino has two differences:

It's missing 0303AAFE in front which is the ServiceIDList parameter w/ the Eddystone ID
Transmit powers are different (not relevant)

I'm assuming this is a simple change to the library to add this service list? Without this change, I'm afraid arduinos will no longer be found by the more picky Anrdoid Nearby scanner.

Hi @scottjenson,
Thanks for pointing this out, there was a missing call to set the advertised service UUID in Eddystone URL mode. I've added it in https://github.com/sandeepmistry/arduino-BLEPeripheral/commit/8c4b05415108635bd111d148d546a4407c30d7a8.
I'll create a new tag for the library shortly so the fix will be available in the Arduino IDE's library manager.

Thanks for that. About how long will this take? I currently don't see it in the Manage Library... dialog but that's clearly a bit TOO early ;-) The reason I'm asking is that I'm giving a demo in 2 days. I was hoping to test tomorrow. If you think it'll easily be out by tomorrow, great.

Somethings probably up with the Arduino library manager system, I don't see the new tag v0.3.1 tag in http://downloads.arduino.cc/libraries/library_index.json. I'll get someone to look at the system tomorrow.
In the meantime you can download https://github.com/sandeepmistry/arduino-BLEPeripheral/archive/0.3.1.zip and extract + replace the contents of ~/Documents/Arduino/libraries/BLEPeripheral.

got it!
On Mon, Oct 10, 2016 at 1:20 PM, Sandeep Mistry<EMAIL_ADDRESS>wrote:

Somethings probably up with the Arduino library manager system, I don't
see the new tag v0.3.1 tag in http://downloads.arduino.cc/
libraries/library_index.json. I'll get someone to look at the system
tomorrow.
In the meantime you can download https://github.com/sandeepmistry/arduino-
BLEPeripheral/archive/0.3.1.zip and extract + replace the contents of
~/Documents/Arduino/libraries/BLEPeripheral.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sandeepmistry/arduino-BLEPeripheral/issues/91#issuecomment-252735336,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAbukhefDmkE8ZoiyMXMb-h8Wu-JEoBks5qyp4ngaJpZM4KSPfx
.

Great, I forgot to mention that the Arduino library manager poller was fixed yesterday.


Cannot import since latest version

Seems like latest release broke the json import feature.
POST /import HTTP/1.1" 500 -
portall  | ERROR:app:Exception on /import [POST]
portall  | Traceback (most recent call last):
portall  |   File "/app/utils/routes/imports.py", line 184, in import_json
portall  |     data = json.loads(content)
portall  |   File "/usr/local/lib/python3.9/json/__init__.py", line 346, in loads
portall  |     return _default_decoder.decode(s)
portall  |   File "/usr/local/lib/python3.9/json/decoder.py", line 337, in decode
portall  |     obj, end = self.raw_decode(s, idx=_w(s, 0).end())
portall  |   File "/usr/local/lib/python3.9/json/decoder.py", line 353, in raw_decode
portall  |     obj, end = self.scan_once(s, idx)
portall  | json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 3 (char 2)
portall  |
portall  | During handling of the above exception, another exception occurred:
portall  |
portall  | Traceback (most recent call last):
portall  |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 1473, in wsgi_app
portall  |     response = self.full_dispatch_request()
portall  |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 882, in full_dispatch_request
portall  |     rv = self.handle_user_exception(e)
portall  |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 880, in full_dispatch_request
portall  |     rv = self.dispatch_request()
portall  |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 865, in dispatch_request
portall  |     return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
portall  |   File "/app/utils/routes/imports.py", line 44, in import_data
portall  |     imported_data = import_json(file_content)
portall  |   File "/app/utils/routes/imports.py", line 195, in import_json
portall  |     raise ValueError("Invalid JSON format")
portall  | ValueError: Invalid JSON format
portall  | INFO:werkzeug:<IP_ADDRESS> - - [12/Jul/2024 00:57:38] "POST /import HTTP/1.1" 500 -

Data:
[{'ip_address': '<IP_ADDRESS>', 'nickname': 'monitor-server-1', 'port_number': 9020, 'description': 'portall', 'order': 0, 'port_protocol': 'TCP'}]

Is that from an export using Portall?
Property values are single quoted in your data. JSON requires double quotes. All Portall exports use double quotes, but let me know if it somehow produced single quotes.
Here is your data, using double quotes. It should work.
[{"ip_address": "<IP_ADDRESS>", "nickname": "monitor-server-1", "port_number": 9020, "description": "portall", "order": 0, "port_protocol": "TCP"}]

Is that from an export using Portall?
Property values are single quoted in your data. JSON requires double quotes. All Portall exports use double quotes, but let me know if it somehow produced single quotes.
Here is your data, using double quotes. It should work.
[{"ip_address": "<IP_ADDRESS>", "nickname": "monitor-server-1", "port_number": 9020, "description": "portall", "order": 0, "port_protocol": "TCP"}]

No it wasnt using portal thanks for the pointer sorry.

No worries! Let me know if you encounter any more issues.
Thank you!


Restrict lines on edit

It would be gr8 to restrict the users not to add more or reduce lines while editing comments. This is our requirement and i found it not straightforward to implement a fix

It's definitely not very straightforward to implement due to the requirement of having to be responsive across different screen sizes, which basically means that the comment would have to be exactly identical in character count as the previous one, which isn't humanely possible if you want to  allow users to be able to edit their comments at all.
This is thus unfortunately something we're not planning to support.

Thanks for your comments. I tried and was almost there but it is
inconsistent.
On Thu, Jul 20, 2017 at 6:39 PM, Jesse Nieminen<EMAIL_ADDRESS>wrote:

It's definitely not very straightforward to implement due to the
requirement of having to be responsive across different screen sizes, which
basically means that the comment would have to be exactly identical in
character count as the previous one, which isn't humanely possible if you
want to allow users to be able to edit their comments at all.
This is thus unfortunately something we're not planning to support.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Viima/jquery-comments/issues/108#issuecomment-316697862,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH_jloIMvDpv42CtYttHW3Ejnzbgr-9Kks5sP1GjgaJpZM4NoOb9
.

--
Thanks,
Ramesh


Fix escaping in make target: setup-web-proxy

Before the fix it produced a wrong json:
$ make setup-web-proxy
echo "{\n  \"/api\": {\n    \"target\": \"http://localhost\",\n    \"secure\": false\n  }\n}" > /home/souz9/cyberok/soldr/web/proxy.conf.json
$ cat web/proxy.conf.json
{\n  "/api": {\n    "target": "http://localhost",\n    "secure": false\n  }\n}

@souz9 I think that you need return using of CURDIR var to avoid issue with changing current working directory in Makefile
Such as $(CURDIR)/web/proxy.conf.json

@souz9 I think that you need return using of CURDIR var to avoid issue with changing current working directory in Makefile
Such as $(CURDIR)/web/proxy.conf.json

Every line in Makefile always runs relatively to the base directory of the Makefile. Using $(CURDIR) this place looks to me redundant.

Simple example:

Yea, I know about it, tnx! But my case was different:
# /tmp/Makefile:
test:
        @pwd
        @echo `pwd`
        @echo $(PWD)
        @echo $(CURDIR)

$  CURDIR=/cwd PWD=/pwd make -C /home -f /tmp/Makefile
make: Entering directory '/System/Volumes/Data/home'
/System/Volumes/Data/home
/System/Volumes/Data/home
/pwd
/System/Volumes/Data/home
make: Leaving directory '/System/Volumes/Data/home'

As a bottom line, CURDIR variable can't be override outside, but we'll able to redefine it inside Makefile by one line, e.x.
# /tmp/Makefile:

CURDIR := $(PWD)

test:
        @pwd
        @echo `pwd`
        @echo $(PWD)
        @echo $(CURDIR)

$  CURDIR=/cwd PWD=/pwd make -C /home -f /tmp/Makefile
make: Entering directory '/System/Volumes/Data/home'
/System/Volumes/Data/home
/System/Volumes/Data/home
/pwd
/pwd
make: Leaving directory '/System/Volumes/Data/home'

But after your change we'd lose the ability to quick fix.

As a bottom line, CURDIR variable can't be override outside, but we'll able to redefine it inside Makefile by one line, e.x.

It does not seem to be a good idea to override $CURDIR this way. $CURDIR has a special meaning in make, it'd better to use -C flag for this.
# /tmp/Makefile:
test:
	@echo CURDIR: $(CURDIR)
	@echo PWD: $(PWD)

$ cd /tmp
$ make: Entering directory '/tmp/one'
CURDIR: /tmp/one
PWD: /tmp
make: Leaving directory '/tmp/one'

$ make -C /tmp/two -f /tmp/Makefile
make: Entering directory '/tmp/two'
CURDIR: /tmp/two
PWD: /tmp
make: Leaving directory '/tmp/two'

BTW, $PWD has a special meaning in shell so it's not a good idea to override it as well.
$PWD is an env variable managed by shell.
$CURDIR is an internal variable of make (not user defined variable).

@souz9 thank you for your example, I know it, but I see no one reason to change using of the variable in this line.
My example presents some case to change output directory for testing (in developer mode only).
Your output text shows this case:
$ make -C /tmp/two -f /tmp/Makefile
make: Entering directory '/tmp/two'
CURDIR: /tmp/two
PWD: /tmp
make: Leaving directory '/tmp/two'

So I ask you to return the variable and update your request.

@asdek Updated.


fix(client): use authorization header instead of basic auth

Basic authentication is not supported (anymore), therefore using Authorization header

Thanks 👍


Task: (Learning) Web development

What needs to be done?

Since for both our front-and backend we want to use javascript a good understanding of the language and how it works is advantageous.
Inside the javascript (and modern frameworks) world - there are probably thousands of tools that you can use to achieve your desired solution.
There are different toolings / languages etc that you want to learn / explore before deep diving into modern frameworks like vuejs.
Here is a list of subjects that are a good starting point.

A basic understanding of web development and how it works  - a good starting point are the mozilla documentations which includes multiple sections about html / javascript https://developer.mozilla.org/en-US/docs/Learn/JavaScript

A basic understanding of html https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML

Javascript in general https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide

(Advanced) Javascript reference https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference

(Advanced) Nodejs https://nodejs.org/en/about/

(Advanced) node package manager https://www.npmjs.com/

When is this task complete?

[ ] You have a basic understanding of web development

[ ] You can create a basic html website

[ ] You are familiar with javascript and how it works (You can use nodejs to play around with javascript without having any website running)

Additional Notes

This should be done by every team member in its own time to get a good understanding of how web development works. Personally I would skip on topics like jQuery...

Just added this since I forgot to mention it last week (My bad!) - Everyone should work on this task in the first week to have a basic understanding of the topic.


[MM-12738] Migrate OAuth app actions from user_actions.jsx and admin_actions.jsx to redux

Summary
Part of this issue. Moved

allowOAuth2
getOAuthAppInfo
getAuthorizedApps
deauthorizeOAuthApp

actions from webapp repo.
Ticket Link
MM-12738
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit tests passed
[x] Ran make flow to ensure type checking passed
[x] Added or updated unit tests (required for all new features)

Test Information
This PR was tested on: [Device name(s), OS version(s)]

Hi @enahum, thanks for having a look at PR. Yes it could be implemented in a webapp repo, but it was suggested to move them into this repo. Have a look please at the discussion

@enahum It is not a problem if it does not meet migration campaign goals. I can close it and update the webapp PR

@MirlanMaksv I see you point.. I don't really mind having it here. My only problem is that we are wrapping the client call that we had on the webapp with this bindClientFun that I get it does some other checks and that's fine but then we keep on using the data that was returned by the server without storing it in the redux store... no I don't really see the point. Maybe I'm wrong and that's fine but having a redux action that does not changes the redux state seems weird to me.

we keep on using the data that was returned by the server without storing it in the redux store
Why should we be using redux actions only when using data returned by the server into store?

That is perfectly fine. We don't need to store all the data in redux returned by API.
Redux actions should be used whenever unless there is a good reason not to and i don't see a reason
here not to use it.

When it doubt pick a solution which keeps the entropy of codebase low. For me having redux action sounds right

Using client4 calls directly does not seem like a good idea to me in broader sense of as we would be having few API calls going through client4 directly and few through the redux actions.
Why not just stick to one pattern at the risk of making a decision or having this discussion everytime we add an API call of should we call client4 directly? Are there any downside of having it as redux action?
I don't know the initial intention of  bindClientFun but nevertheless it looks like a good abstraction for making API calls.

When it doubt pick a solution which keeps the entropy of codebase low. For me having redux action sounds right

If you ask why it keeps the entropy low it is because we will be having one pattern
The reason why i would stick with redux actions is because we will have access to redux state.
It will let us do things uniformly across the app if we end up making new decisions on network handling or batching/queuing  of API's calls or even used by plugins to track an event of API call

After having discussed decision was made to leave actions in a web app repository as they are client specific. Closing the PR


Using a different payment method

Hi.
When login to buy with paypal i get this message...i use sandbox account.
We aren't able to process your payment using your PayPal account at this time. Please go back to merchant and try using a different payment method.
How to fix this?

what was the payment method you have used ?

PayPal...this message is get on paypal site when i login.


Update to TF 0.12, fix outputs when module is disabled, use for_each on the null resource

@aknysh I updated this if you guys would like it.
Changes:

Update to TF 0.12
fix outputs when the module is disabled
use for_each on the null resource

thanks @techfishio for contribution!
It is very helpful to have such PR, but we also have requirements to cover module with tests for all TF 0.12 modules. If you want to contribute it in a proper way (see [example] (https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/45)) you are most welcome! Give it a try, then ping me, so I could review and run tests. This will unblock us to merge your PR. Otherwise we all have to wait until it will be done as well as many other modules in queue.


next release

is there a plan on the next release for ARM CL?

Hi @peter197321,
The next release on github will be around the end of the month.
Anyway if you want already to check 19.02 out we have an open gerrit repository:
git clone https://review.mlplatform.org/ml/ComputeLibrary
Thanks,
Manuel


cmdheight=0 causes problems

When using cmdgheight=0, and activating zen-mode, there are parts of the status line left on the screen and also a wrong line above the its window.
It seems that zen-mode's window should be drawn one line above.

I have the same issue. When cmdheight is set to zero, lualine will remain under the main buffer.

@folke here's the screenshot

yeah this issue persists when used with https://github.com/folke/noice.nvim as cmdheight is always 0 there
@folke can you please look in to this thanks for your awesome work

Hi @folke
Do you have any plans for fixing this? Is this even fixable?

I fixed it like this
local lualine = require("lualine")

require("zen-mode").setup({
	on_open = function(win)
		lualine.hide()
		vim.o.statusline = " "
	end,
	on_close = function()
		lualine.hide({ unhide = true })
	end,
})

@eXvimmer well it is a work around and not a fix
 you can see the black bar still in the bottom

You can set config.plugins.options.laststatus = 0, but there's seems to be a bug in Neovim, that does not allow the height of the background window to be full height.

@folke Yes, :h cmdheight says that cmdheight=0 is considered experimental.
Thank you for creating this useful plugin.

@Rishabh672003 If it bothers you, then I think you can find the highlight group of the cmd and change it.

@eXvimmer that's not the problem. As I mentioned, there's a bug in Neovim nightly that can't display a window full height. A window can render over the bottom part, if you set row=1, so just a bug.

@folke OK. Thanks!

@folke Can you add an event listener like on_buffer_change (like on_open/on_close) that runs a function when zen-mode is active, and we run :bnext or :bprev?

BTW, the best solution for me is this.
local lualine = require("lualine")

require("zen-mode").setup({
	on_open = function(win)
		lualine.hide({})
		-- vim.o.statusline = ""
		vim.o.cmdheight = 1
	end,
	on_close = function()
		vim.o.cmdheight = 0
		lualine.hide({ unhide = true })
	end,
})

Fixed with nvim v0.9.0?

Yeah seems like this is fixed in nvim-0.9, other than the top having 3 blank lines but the bottom having 2

Yeap, 0.9 also fixes for me, thanks for this

BTW, the best solution for me is this.
-- local lualine = require("lualine")

require("zen-mode").setup({
	on_open = function(win)
		-- lualine.hide({})
		-- vim.o.statusline = ""
		vim.o.cmdheight = 1
	end,
	on_close = function()
		vim.o.cmdheight = 0
		-- lualine.hide({ unhide = true })
	end,
})

this worked for me!

For anyone that ends up here, I found setting laststatus to work much better than cmdheight
on_open = function(_)
    vim.o.laststatus = 2
    require("lualine").hide()
end,
on_close = function()
    vim.o.laststatus = 3
    require("lualine").hide { unhide = true }
end,


Update readme

Reviewed readme add new placeholder images and screnshoots.

Closed by dimas prasetyo cause prevent duplication PR for testing branch protected.


Stuck after entering password on 'kobodl user add'

Currently not moving past the point of adding a user in kobodl.
After entering the password for the account in the command 'kobodl user add' the program appears to hang indefinitely.

Just tested version 0.5.0, cannot reproduce.

After entering the password for the account in the command

That's not the last step.   Did you also open a browser and follow the instructions to get a captcha code?
Could you upload a screenshot of what it looks like when it gets stuck?  Could you also include details about your kobodl version and operating system?  Did you install from pypi?
Thanks.

Here's how a login should look.
brandon@varrock:~
~$ kobodl user add
Email: [REDACTED]
Password:
Repeat for confirmation:

    Open https://authorize.kobo.com/signin in a private/incognito window in your browser, wait till the page
    loads (do not login!) then open the developer tools (use F12 in Firefox/Chrome), select the console tab,
    and paste the following code there and then press Enter there in the browser.

    var newCaptchaDiv = document.createElement( "div" );
    newCaptchaDiv.id = "new-grecaptcha-container";
    document.getElementById( "grecaptcha-container" ).insertAdjacentElement( "afterend", newCaptchaDiv );
    grecaptcha.render( newCaptchaDiv.id, {
        sitekey: "6Le_Hc8ZAAAAAO6IMIG5zdDmANbljtXY4EHK0wzD",
        callback: function( response ) { console.log( "Captcha response:" ); console.log( response ); }
    } );

    A captcha should show up below the Sign-in form. Once you solve the captcha its response will be written
    below the pasted code in the browser's console. Copy the response (the line below "Captcha response:")
    and paste it here.

Captcha response: [REDACTED]
Login Success. Try to list your books with `kobodl book list`

Hi @subdavis
I am trying to login but I am getting this error
ERROR: Authenticated user URL can't be found. The page format might have changed.

Hi @subdavis
I am trying to login but I am getting this error
ERROR: Authenticated user URL can't be found. The page format might have changed.

Again, tested 0.5.0, cannot reproduce.  You can send me a copy of the page.  it should be saved to file in the same directory.

Again, tested 0.5.0, cannot reproduce.  You can send me a copy of the page.  it should be saved to file in the same directory.


rktlet: use seccompProfilePath for k8s 1.8

As Kubernetes 1.8 changed its API to handle seccomp profiles inside SecurityContext, we need to change rktlet to support the new API.
Also update vendor to upgrade Kubernetes from 1.7.5 to 1.8.0, clean up the vendor tree by excluding test files as well as documents. Also fix build issues resulted from the k8s upgrade.
Fixes https://github.com/kubernetes-incubator/rktlet/issues/143
(NOTE: I tested this PR via kube-spawn on top of both k8s 1.7.5 and 1.8.0, and I could not find any particular issue, or any regression. Though we should be carefully test this PR, as it touches various parts.)

I think we should fall back to checking the annotations if we can't find SecurityContext.SeccompProfilePath. I haven't tested it but I'm pretty sure this breaks seccomp profiles on v1.7.x clusters because we ignore the annotations.

However, the way it's implemented now we just set unconfined if there's no SecurityContext.SeccompProfilePath so it might be ok.
Also, I checked and it seems other implementations differ on defaults: cri-containerd uses the docker/default profile and supports k8s 1.8 style,  cri-o uses unconfined and supports k8s 1.7 style, and dockershim uses unconfined and supports k8s 1.8 style (which is normal because it's inside the k8s repo).

@iaguis Either way I'm fine, fallback to 1.7 or not.
BTW I discovered a regression w.r.t image names in this PR, so that every rkt app add fails with a strange error like must give only one app. I'm not sure why it happens, because the command-line options include only one app.
So please do not merge this PR until we could find out its reason.

It turns out, the failure must give only one app is a separate issue, which will be addressed via https://github.com/rkt/rkt/pull/3822.
Updated the PR to include fallback to the old annotations mechanism when there's no seccomp profile in SecurityContext.

Updated.

As reported by @iaguis, There were hidden build errors that were not recognized by running simple make. So I updated vendors including k8s.io/api, k8s.io/apimachinery, k8s.io/client-go etc.
Fixed build errors under tests/framework. Previously the tests were written based on k8s 1.6, while the current testing API of k8s 1.8 has changed a lot since then. Note that the test codes are still ugly, but I have just managed to only build without errors. Later we could improve the tests a little more.

This breaks tests in tests/ (make integ) because you just add a fake runtime service.
I just checked and they're also broken on master (for different reasons), so I think we can leave it like it is in this PR and file an issue to fix them in the future.

@iaguis Right, this PR just fixes build issues in the tests directory. It doesn't mean the tests work. For now I just don't have time to actually fix it. Hopefully we could do it later.


Ruby on Rails 路径穿越与任意文件读取漏洞（CVE-2019-5418）

docker-compose执行时出错
Traceback (most recent call last):
File "/usr/bin/docker-compose", line 11, in
load_entry_point('docker-compose==1.17.1', 'console_scripts', 'docker-compose')()
File "/usr/lib/python2.7/dist-packages/compose/cli/main.py", line 68, in main
command()
File "/usr/lib/python2.7/dist-packages/compose/cli/main.py", line 121, in perform_command
handler(command, command_options)
File "/usr/lib/python2.7/dist-packages/compose/cli/main.py", line 952, in up
start=not no_start
File "/usr/lib/python2.7/dist-packages/compose/project.py", line 431, in up
svc.ensure_image_exists(do_build=do_build)
File "/usr/lib/python2.7/dist-packages/compose/service.py", line 318, in ensure_image_exists
self.build()
File "/usr/lib/python2.7/dist-packages/compose/service.py", line 923, in build
shmsize=parse_bytes(build_opts.get('shm_size')) if build_opts.get('shm_size') else None,
TypeError: build() got an unexpected keyword argument 'stream'

请自行解决你的docker-compose的问题，与vulhub无关。


2.0 - button and link in form actions no longer line up

They worked in 1.x and 2.0WIP

<button class="btn btn-large btn-primary" tabindex="7" type="submit" value="register">Save</button>
Cancel

Screen Capture

Dupe #1543.

Closing as dupe.


[Bug Report] Deselect sub-item (make it inactive) from menu

Element UI version
2.4.7
OS/Browsers version
any
Vue version
2.5.17
Reproduction Link
https://jsfiddle.net/mmx38qxw/6399/
Steps to reproduce
by default selected one sub-menu. When click on any sub-menu - they become active as well. But now, there's no way to deactivate that sub-menu.
Regression issue here: https://github.com/ElemeFE/element/commit/6bb49b959013f3351bee9308b2e627d80d857cfd
What is Expected?
Code should be fixed (removed this.items[this.activeIndex]) in order to be able to control active sub-menu.
What is actually happening?
Due to regression in https://github.com/ElemeFE/element/commit/6bb49b959013f3351bee9308b2e627d80d857cfd it's impossible to control active sub-menu now

May be you can have a try like this:
Change attribute default-active  to 'placeholder' that produced by an invisible element <el-menu-item index="placeholder" v-if="false" />. It's not a final solution but seems to be 'unselected'.
It works to me.

@zhangyaoFkr that doesn't work for me at all. Could you please provide a jsfiddle with your working solution, that will be very helpful. Thanks!

Thanks! Works for me as well. Had to change a lot of code though.


implement the new header format

We should wait until https://github.com/quicwg/base-drafts/pull/2055 is resolved before merging.

Codecov Report

Merging #1630 into master will decrease coverage by 0.03%.
The diff coverage is 90.41%.

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
- Coverage   87.39%   87.35%   -0.03%
==========================================
  Files          98       97       -1
  Lines        6231     6246      +15
==========================================
+ Hits         5445     5456      +11
- Misses        560      562       +2
- Partials      226      228       +2

Impacted Files
Coverage Δ

internal/protocol/protocol.go
100% <ø> (ø)
:arrow_up:

internal/utils/byteorder_big_endian.go
100% <100%> (ø)
:arrow_up:

internal/wire/header.go
86.67% <100%> (+1.1%)
:arrow_up:

session.go
74.1% <100%> (+0.27%)
:arrow_up:

internal/protocol/packet_number.go
100% <100%> (ø)
:arrow_up:

internal/ackhandler/sent_packet_handler.go
75.76% <50%> (-0.07%)
:arrow_down:

internal/wire/extended_header.go
93.39% <86.05%> (-4.44%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd81dfd...04db31b. Read the comment docs.


chore: mark rpc state reader config create for testing for cfg

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.05%. Comparing base (78975d5) to head (06dcbb4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   46.05%   46.05%
=======================================
  Files          19       19
  Lines         634      634
  Branches      634      634
=======================================
  Hits          292      292
  Misses        328      328
  Partials       14       14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


docs: Improved mobile navigation

Resolves #173.
Mobile users were unable to browse table of contents of categories. This PR aims to resolve this issue by implementing a feature that lets users see all of the available subcategories and posts.

I was wondering whether we should entirely remove convolutedNav from individual pages' getStaticProps function, because it's already part of the merged navigation items.


[Chore] Update examples that use default Anvil + HTTP to on_anvil / on_anvil_with_signer

Already exposed through the node_bindings flag
We can use the (provider, anvil) = ProviderBuilder::new().on_anvil(); syntax
Related: https://github.com/alloy-rs/alloy/issues/578

@prestwich from the documentation it appears that this feature is specifically intended for tests. Just to be sure, this is not a pattern we would like to use in the examples, correct?

note that after the AnvilProvider PR, the interface is now just let provider = ProviderBuilder::default().on_anvil_with_signer()


MINOR: Exclude lerna.json from prettier

@harpgl-bot retest this please

@harpgl-bot retest this please


Downloading webp from https://i.ytimg.com fails with 404

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.01.21. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
America
Description
https://i.ytimg.com/vi_webp/5qap5aO4i9A/maxresdefault_live.webp can be accessed in a browser, but fails to be downloaded with yt-dlp.
Verbose log
[debug] Command-line config: ['https://i.ytimg.com/vi_webp/5qap5aO4i9A/maxresdefault_live.webp', '--verbose']
[debug] User config "/home/system/.config/yt-dlp/config": ['-f', 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/mp4', '--downloader', 'aria2c', '--downloader-args', '-j 16 -s 16 -x 16 -k 1M']
WARNING: --downloader-args given without specifying name. The arguments will be given to all external downloaders
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.01.21 [f20d607b0]
[debug] Python version 3.9.9 (CPython 64bit) - Linux-5.15.5-1-ARCH-aarch64-with-glibc2.32
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
[debug] [generic] Extracting URL: https://i.ytimg.com/vi_webp/5qap5aO4i9A/maxresdefault_live.webp
[generic] maxresdefault_live: Requesting header
WARNING: [generic] Could not send HEAD request to https://i.ytimg.com/vi_webp/5qap5aO4i9A/maxresdefault_live.webp: HTTP Error 404: Not Found
[generic] maxresdefault_live: Downloading webpage
ERROR: [generic] Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; see  https://github.com/yt-dlp/yt-dlp  on how to update. Be sure to call yt-dlp with the --verbose flag and include its complete output. (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; see  https://github.com/yt-dlp/yt-dlp  on how to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.
  File "/home/system/.local/lib/python3.9/site-packages/yt_dlp/extractor/common.py", line 730, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/home/system/.local/lib/python3.9/site-packages/yt_dlp/YoutubeDL.py", line 3526, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.9/urllib/request.py", line 523, in open
    response = meth(req, response)
  File "/usr/lib/python3.9/urllib/request.py", line 632, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.9/urllib/request.py", line 561, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.9/urllib/request.py", line 494, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.9/urllib/request.py", line 641, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

This is because it is a livestream -- thumbnails from non-livestream videos work.

yt-dlp is a video/audio downloader. It cannot handle URL to images


Add new audit log options (provisional)

Pull Request Etiquette

[ ] I have checked the PRs for upcoming features/bug fixes.
[ ] I have read the contributing guidelines.

Changes

[ ] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
Replace this sentence with general description of what your Pull Request does.

I assume this is based on this?
https://github.com/DJScias/Discord-Datamining/commit/0af5a21f1caba4a557fa082f3b11e4df65ea6048#commitcomment-36028498

We should add a AuditLogEntry#getTypeRaw for better forward compatibility. Right now we just provide getType() which returns UNKNOWN for new types.


Do not add double dot when $ORIGIN is `.'

A zone file containing $ORIGIN . would cause an extra `.' being added
on host names in that zone after parsing.
PowerDNS' pdnsutil tool produces such zone files by default.

Great pickup! Thanks for the PR!

Great pickup! Thanks for the PR!


define and implement permissions for editing content items according to rights concept (multi-site editor)

Rationale / Begründung
With respect to the implementation of an owner property for content items (#490) and a 'site-editor' role (#491), the rights and permissions should be checked and defined according to a concept of access rights for editors (we have a concept, it is, however, still open for discussion).
Affected
Users, Managers, Admins
Minimal functionality

define editor rights and permissions according to concept
define a 'multi-site editor' (or e.g. 'super editor', 'instance editor', 'main editor', etc.)

References / Verweise

#490
#491

Concept for permissions for Editors in a multi-site setting
The Role model gets an editor field, which is similar to the manager field, an m2m with sites.
A multisite Editor has all sites of the Instance, or it should be a checkbox.
A site Editor has usually only one site but can receive more.
The multisite Editor should have CRUD permissions for all element objects (ModelPermission level).
The site Editor needs more fine-graind Object-level permissions.
This requires that the element objects also receive an additional "owner-ship" field (can be done via the sites ?)
Catalogs

(update) Editor-rights per site, only an Editor of the site can edit Catalogs of their own site.

Editorrechte für Mandanten vergeben, d.h. ein Editor kann nur Inhalte seines Mandanten editieren

(read) An Editor sees only Catalogs from his site, or Catalogs shared from other sites as read-only.

Editor sieht nur Kataloge seines Mandanten (ggf. mit Möglichkeit, die anderen Kataloge "lesend" anzuzeigen)

(multisite editor role property) An Editor with rights for all sites inside the instance.

Supereditor, der alle Mandanten bearbeiten kann, kann alle Kataloge sehen

Domain

(read) Readable for all site Editors

Lesbar für Editoren

(create and update) ModelPermission Only for the multi-site Editor

ObjectPermissions per site by each site Editor

Optionsets

(read) Readable for all site Editors
site Editors can not update optionsets which are used in Catalogs (which are used) by other sites

Editoren solllten keine Sets bearbeiten könnnen, die Kataloge andere Mandanten betreffen

(create and update) multisite Editors has ModelPermissions

site Editors have Objectpermission

Conditions
same as Optionsets
Tasks
same as Optionsets
Views

all are CRUD-able for multisite Editor

site Editor can CRUD for their own site (can not delete shared views)

Import

multisite Editors can update Catalogs from each site at import.
site Editors can import new Catalogs for their own site.

can update own Catalogs at import

The rules for all the elements are in:
https://github.com/rdmorganiser/rdmo/blob/master/rdmo/management/rules.py

closed by 2.0.0


Adding swagger definition for firewall GET, PUT, PUT list and DELETE APIs. Adding examples for firewall APIs calls.

Adding swagger definition for firewall GET, PUT, PUT list and DELETE APIs.
Adding examples for firewall APIs calls.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Your change should be based on Azure/current branch, not Azure/master. Can you adjust this so that it's based on Azure/current? You will probably need to close and make a new PR to change what the target branch is. :)

@jaredmoo thanks for the comment. @jiahli once you re-target the PR, we'll review. comments will get lost otherwise, thanks!

@jiahli should we close this PR? are you planning on updating it or submitting a new one?

@veronicagg I have created another PR, will close this one now.

@veronicagg I have created another PR, will close this one now.


Compute: Firewall.config.protocols empty array means "everything"

Looking specifically at https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.34.0/compute?method=createFirewall
Consider the following flow:

I have a list of ports that I know I should allow (ports = [1,2]) and I store that somewhere.
For my script, I know I don't want port 2 available, so I remove that before creating my firewall: ports.pop(2)
Someone else has an interceptor after mine that says "I definitely don't want port 1" (ports.pop(1))

At this point, ports is an empty list, and the developer(s) think this means "I've removed all the ports I don't want, so if there were more, fine, but otherwise, nothing is open". Instead it means "all ports are open!" which is ... scary.
Can we be more explicit about what our empty states mean? In this case, I think empty list should mean "no ports are open" and some other special flag (maybe '*' ?) or maybe a special subclass of Array that contains every valid port? (ie, when checked if N is in the array, always returns true?)
To give an example of what I'm aiming for...
var ports = database.loadDefaultOpenPorts(); // [11211]
var portsToBlock = [11211, 8675];
ports = ports.filter(function(p) { return portsToBlock.indexOf(p) == -1 }); // []

gce.createFirewall('new-firewall-name', {
  protocols: { tcp: ports }, // [] here means "No ports are allowed"
  ranges: ['<IP_ADDRESS>/0']
}, cb);

If I want to explicitly say "all ports":
gce.createFirewall('new-firewall-name', {
  protocols: { // Explicitly ask for all ports (shown two different ways)
    tcp: gce.firewall.allPorts,
    udp: '*'
  },
  ranges: ['<IP_ADDRESS>/0']
}, cb);

I might just be wrong about what the API does.
See the description of allowed[].IPProtocol here: https://cloud.google.com/compute/docs/reference/latest/firewalls/insert --
  "allowed": [
    {
      "IPProtocol": "tcp"
    },
    {
      "IPProtocol": "17",
      "ports": [ "161" ],
    }
  ]

Are any ports opened for the TCP protocol? Whatever that does, that's all gcloud-node does when it receives an empty array.

I actually don't know. ports doesn't seem to be defined in the list (while IPProtocol -- redundantly named -- does). I'll have to ask...

Quoting from Firewalls docs:

ports
[Optional] An array of target ports allowed for this connection. This is only applicable for TCP and UDP connections. Each value is a string that is either a single port or a port range. If not specified, all ports are allowed. Example: ["80", "160", "300-500"]

Right, so it seems like it does... not what we want. That's kinda scary. To clarify what I'd expect...

Open all TCP ports to the world
gce.createFirewall('new-firewall-name', {
  protocols: {
    tcp: gce.firewall.ALL_PORTS // Or something like this
  },
  ranges: ['<IP_ADDRESS>/0']
}, cb);

Open no TCP ports to the world
gce.createFirewall('new-firewall-name', {
  protocols: { tcp: [] },
  ranges: ['<IP_ADDRESS>/0']
}, cb);

Check if port 350 is open
gce.createFirewall('new-firewall-name', {
  protocols: { tcp: ["300-400"] },
  ranges: ['<IP_ADDRESS>/0']
}, function(firewall) {
  console.log(firewall.protocols.tcp.contains(350)); // true
});

Fiest example, how about tcp: true?
Second example, how do I tell the API not to open ports?
Third example, if they just opened it, why are they checking? Or are you just illustrating that it should have been opened?

Fiest example, how about tcp: true?

SGTM.

Second example, how do I tell the API not to open ports?

Technically it should be just removing the TCP key... but @mziccard may know a bit more.

Third example, if they just opened it, why are they checking? Or are you just illustrating that it should have been opened?

Yea -- just an illustration. The idea though is that I set a range, and I'm checking a specific port. That's a bit trickier.

Technically it should be just removing the TCP key...

Yes by passing TPC you are saying "open all ports for TPC", by passing TCP + [port array] you are saying "open all ports in [port array] for TCP", if you don't pass TCP all TCP traffic is rejected.


Don't ignore entryPointName in d3d11 backend.

When compiling an hlsl shader on D3D11 currently the entryPointName is being ignored.
Description
Switched from the hardcoded "main" to using what was passed in to the function already from the user.

Looks right to me, will let @TheSpydog confirm.

Looks good, thanks for catching this! I think I just overlooked this when adding support for the HLSL shader format.


chore: v1.0.0 release

v1.0.0 release -> Type hinting support

thanks for the contributions @pedroimpulcetto


x86-64-gcc: Support passing structs in regs, per SysV.

The AMD64 SysV ABI allows most structures up to two QWORDs in size to be passed
in a pair of registers instead of on the stack. This patch handles the case(s)
where the fields are all INTEGER (int or pointer) types.
Limitation: In the event that a struct has floating-point members, those members are
allocated to the XMM registers if possible. A struct may contain both integral
types as well as floating-point types, meaning that a 16-byte struct may
feasibly be split into one GPR and one SSE register. metatype=float does not
examine structure fields, however, so structs with floating-point fields are not
correctly allocated by this patch.
The main use of this patch is to get correct function signatures in cases where
debug information is present; for example, with DWARF, parameter locations
are usually not specified, and are supposed to be resolved by running the SysV
argument-assignment algorithm.
This is related to the issue in #4052.

I've experimented with this PR a bit and I think the proper course of action is to reject it.  There is definitely an issue with how we handle passing structures in registers (thank you for bringing this to our attention!).  After discussing it with the team, we've decided that there should be a more general solution.  We should first do a bit more digging into what's going on with SysV on other architectures and possibly the __vectorcall calling convention in Windows.
As for accepting this PR as a temporary fix, when I tried it with a function taking four arguments, each of which was a structure containing two double fields, and compiled with DWARF, the only thing that appeared in the decompiler window was an error message (so you can't fix the signature in the decompiler window).  Possibly (probably?) this is a latent bug that this PR exposed, but there's more work to do before we could accept and we should direct that effort to handling the general case.

Good to know the issue is being looked at more broadly. #4052 is also worth looking at, if you haven't already, as it outlines some more of the difficulties seen with other architectures.
Agreed that a more generic solution would be great to have.


ImportError: No module named colormath.color_conversions

I have a script which uses the following:
from colormath.color_conversions import convert_color
but when I run the script it shows me the error:
ImportError: No module named colormath.color_conversions
the colormath version is 2.1.1

I think updating to 2.2 should fix your error
pip install git+git://github.com/gtaylor/python-colormath

Still have the same problem.
from colormath.color_objects import sRGBColor, LabColor
ImportError: No module named colormath.color_objects

I could not reproduce with 3.0.0, closing for now, feel free to add any comments.


sanoid: add options for frequent snapshots of datasets

Motivation for this change
Adds support for the options frequently and frequently_period in sanoid datasets and templates
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I'm using this as a module via the following snippet and can confirm it works as expected:
# in flake outputs
{
  nixosConfigurations."${hostname}" = lib.nixosSystem {
    modules = [
      ({ ... }: {
        # allow "frequent" setting in sanoid service
        disabledModules = [ "services/backup/sanoid.nix" ];
        imports = [ "${inputs.nixpkgs-sanoid}/nixos/modules/services/backup/sanoid.nix" ];
      })
      # ...
    ];
  };
}


Explicitly support Python 3.5

All tests pass on Python 3.5, so declare official support for it.

Coverage remained the same at 94.444% when pulling 980c92e6fe98f023a26334562964d4d41dfcd97b on jonafato:python3.5 into 345a275b3ad4b581c8cdfbee72b1612277c03d2f on bndr:master.


docs: document struct coded and add examples

document struct ABI codec and add examples to cast (sig, send)
ref https://github.com/foundry-rs/foundry/pull/2151

I think the struct encoding file needs to be in summary.md to be rendered

was the line indent lol

Can we also make it work so that people can copy/paste struct definitions in line? cast call 0x1234 struct Foo { address x; int256 y; }` or do we think it doesn't make sense?

Can merge when the base PR is merged


No external network connection in any WSL2 distro, but available in Docker Desktop WSL2 backed dev container

Environment

Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0

Version 1909 (OS Build 18363.1049)

Ubuntu Release:        20.04
Linux version 4.19.104-microsoft-standard (oe-user@oe-host) (gcc version 8.2.0 (GCC)) #1 SMP Wed Feb 19 06:37:35 UTC 2020
Hyper-V feature turned off

  NAME                   STATE           VERSION
* docker-desktop         Running         2
  Debian                 Running         2
  docker-desktop-data    Running         2
  Ubuntu-20.04           Running         2

Steps to reproduce
Notes

I have tried installing different distros, with same result
I have tried with Hyper-V feature enabled, with same result
I have tried with 1903.1049 before upgrading to 1909.1049 and had the same issue in the distro
I have no active VPN connection, but I have Check Point Endpoint Security installed
I have tried the resolve.conf and netsh suggestions found in other issues with no effect

Failing scenario in distro

Clean install of WSL2 distro
eth0 info

ip addr | grep eth0
5: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    inet <IP_ADDRESS>/28 brd <IP_ADDRESS> scope global eth0

Trying to ping host (WSL adapter IP from running ipconfig on host) or trying to ping <IP_ADDRESS> gives 100% packet loss

$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
2 packets transmitted, 0 received, 100% packet loss, time 1074ms

$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
2 packets transmitted, 0 received, 100% packet loss, time 1008ms

Successful scenario in Docker Desktop WSL2 backed dev container from VSCode

Docker Desktop Community

Version: <IP_ADDRESS> (47622)
Channel: edge
"Use the WSL 2 based engine" checked

VSCode 1.48.2

Start remote container configured repo: vscode-remote-try-python

eth0 info

vscode@a5b5a09f91a2:/workspaces/vscode-remote-try-python$ ip addr | grep eth0
5: eth0@if6: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global eth0

Ping <IP_ADDRESS> successful

vscode@a5b5a09f91a2:/workspaces/vscode-remote-try-python$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=37 time=15.3 ms

Ping Windows host WSL adapter interface IP successful

vscode@a5b5a09f91a2:/workspaces/vscode-remote-try-python$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=37 time=2.45 ms

Ping host.docker.internal successful

vscode@a5b5a09f91a2:/workspaces/vscode-remote-try-python$ ping host.docker.internal
PING host.docker.internal (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=1 ttl=37 time=2.63 ms

WSL logs:
https://aka.ms/AA9kazx
Expected behavior

Successful ping response to both windows host and <IP_ADDRESS>
Actual behavior

100% packet loss when pinging both windows host and <IP_ADDRESS> from within distro

Please collect WSL logs and post the backlink to the feedback item here.

@therealkenc : Added link to WSL logs sent via Feedback Hub.

I have the similar issue,  after waking up from sleep,  WSL2 occasionally lost network connection, It failed to ping <IP_ADDRESS> or connect to local X window server (VcXsrv),  but restarting the system can fix thing temporarily.

@luochen1990 : Hi, that seems like a (set) of issues already reported specifically regarding waking up from sleep. In this case it has never worked in a normal WSL2 distro, regardless of sleep or restart, also acted the same way in 1903.1049 and 1909.1049.

Installed a WSL1 backed distro(kali) in parallel and it has no network issues
wsl --list --verbose
  NAME                   STATE           VERSION
* Debian                 Running         2
  kali-linux             Running         1
  docker-desktop         Running         2
  docker-desktop-data    Running         2
  Ubuntu-20.04           Running         2

I have a fairly similar problem to you. I had everything working and suddenly found my distro completely screwed up, but restarting, setting nameserver, uninstalling/reinstalling, none of it seemed to matter. As soon as I used wsl --set-version  1 and tested it worked perfectly fine. Resetting this to version 2, complete failure again.

Pretty much same problem
$ ping google.com
PING google.com (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- google.com ping statistics ---
3 packets transmitted, 0 received, 100% packet loss, time 2045ms

$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
5 packets transmitted, 0 received, 100% packet loss, time 4140ms

$ traceroute <IP_ADDRESS>
traceroute to <IP_ADDRESS> (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  * * *
 2  * * *
 3  * * *
 4  * * *
 5  * * *
 6  * * *
 7  * * *
 8  * * *
 9  * * *
10  * * *
11  * * *
12  * * *
13  * * *
14  * * *
15  * * *
16  * * *
17  * * *
18  * * *
19  * * *
20  * * *
21  * * *
22  * * *
23  * * *
24  * * *
25  * * *
26  * * *
27  * * *
28  * * *
29  * * *
30  * * *
$ ifconfig
eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::215:5dff:fe87:dc04  prefixlen 64  scopeid 0x20<link>
        ether 00:15:5d:87:dc:04  txqueuelen 1000  (Ethernet)
        RX packets 651  bytes 163402 (163.4 KB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 152  bytes 11576 (11.5 KB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1000  (Local Loopback)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 0  bytes 0 (0.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
3 packets transmitted, 0 received, 100% packet loss, time 2094ms

$ traceroute <IP_ADDRESS>
traceroute to <IP_ADDRESS> (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  * * *
 2  * * *
 3  * * *
 4  * * *
 5  * * *
 6  *^C

Also some parts of host (windows) interface gets stuck.
Periodically, I start to kill "Service Host: DNS Client" and "Service Host: Network List Services". And things start for a moment be better.
Feedback was simply hung loading until I done that. It looks like there router infinite loop and some packet flood happening behind the hood.

it is same as https://github.com/microsoft/WSL/issues/5821 I guess

I still had the issue after update to 1909 and later to 20H2. Indicating that there is some firewall rules active after all (probably part of  Check Point Endpoint Security), just by having it installed, without actually having an active VPN connection. (These times of remote work did how ever not encourage experimenting further with de-installing)
Using https://github.com/sakai135/wsl-vpnkit successfully as a work around (seeing that containers in docker desktop via WSL2 worked and that they had running vpnkit processes led me to it)

I still had the issue after update to 1909 and later to 20H2. Indicating that there is some firewall rules active after all (probably part of  Check Point Endpoint Security), just by having it installed, without actually having an active VPN connection. (These times of remote work did how ever not encourage experimenting further with de-installing)
Using https://github.com/sakai135/wsl-vpnkit successfully as a work around (seeing that containers in docker desktop via WSL2 worked and that they had running vpnkit processes led me to it)

I have this issue with no third-party firewall, and it's not #5821 because the WSL adapter shows up as active with an IP address. I'm not going to restart my computer every time it goes to sleep if that's the cause.