[sw,crypto] Remove support for RSA with exponent 3.

After discussion, we've decided the performance improvements are not worth the security risks for sigverify, and e=3 is already off the table for the generic crypto library because it's not FIPS-compliant; therefore, this PR removes support entirely.
Note: this conflicts with https://github.com/lowRISC/opentitan/pull/10114 because I'll have to make similar changes to sigverify_mod_ibex_functest.c there as I did to sigverify_mod_exp_otbn_functest.c here. Will rebase whichever one gets merged last.
CC @moidx

Will probably conflict with #10219; I'll rebase the remaining one after one is merged. (Even if git doesn't think it conflicts, I think it would be a good idea to rebase and run the CI again.)


Is there a callback function for successful verification？

📚 What are you trying to do?
I don't quite understand the document
🔍 What have you tried?
No response
ℹ Additional context
No response

Yes, there is: https://github.com/nuxt-modules/turnstile/blob/main/src/runtime/types.ts#L25-L28

@danielroe what do you think about enabling discussions on this repository to split bug reports and questions?


[Dashboard] Error when duplicating shared dataset

Context
CARTO returns the error relation "datasetName" does not exist when we duplicate the shared dataset.
However, if a user copies the username.tableName from the SQL panel of the shared dataset , opens one of their own datasets (not a shared one) and writes SELECT * FROM username.tableName it can query the data from the shared dataset and then create a dataset from the query to duplicate the data.
Steps to Reproduce

Open the Shared with you menu from the Data panel
Duplicate any dataset
CARTO returns an error.

Current Result
CARTO returns an error.
Expected result
CARTO should be able to duplicate a shared dataset

Thanks for reporting this @oriolbx!

Fixed and merged!


[byteorder] Impl traits for byte arrays

Closes #1749

Codecov Report
Attention: Patch coverage is 22.58065% with 24 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (ea28664) to head (8398b2d).

Files with missing lines
Patch %
Lines

src/byteorder.rs
22.58%
24 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1785      +/-   ##
==========================================
- Coverage   87.46%   87.11%   -0.35%
==========================================
  Files          16       16
  Lines        6021     6048      +27
==========================================
+ Hits         5266     5269       +3
- Misses        755      779      +24

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


broken link in the readme

The link to time aware polyline repo is broken in the readme. You can replace it with this one: https://github.com/hypertrack/time-aware-polyline-js

Thanks, fixed. I'm pointing it to the blog as JS library might have the same fate as the python lib.


Upgrade reqwest

https://seanmonstar.com/blog/reqwest-v012/
Blockers

opentelemetry-http

https://github.com/open-telemetry/opentelemetry-rust/blob/936c46639aa1521bf49dbffba49bbd9795f8ea58/Cargo.toml#L29
https://github.com/open-telemetry/opentelemetry-rust/issues/1427

https://github.com/open-telemetry/opentelemetry-rust/pull/1674
otel have upgraded hyper 🎉

https://github.com/ymgyt/syndicationd/commit/b2def9c07c1dc2f50987831cdbac1bdc4be44791


Use the m4v extension for Dash video files

When downloading files I usually add a bunch of types, so i'm sure i'm at least downloading something.
youtube-dl --no-overwrites --restrict-filenames --ignore-errors -o "./%(uploader_id)s/%(upload_date)s %(uploader)s - %(title)s.%(ext)s" -f 137/136/135/134/133/38/37/22/18/17
youtube-dl --no-overwrites --restrict-filenames --ignore-errors -o "./%(uploader_id)s/%(upload_date)s %(uploader)s - %(title)s.%(ext)s" -f 141/140/139
The problem i'm running into is that I have to join the mp4/m4a Dash files to get a complete video, now in most cases this will produce a video only mp4 and a audio m4a.
In some cases this produces a lower quality "normal" mp4 file ( when Dash isn't available ), now i have no easy way to recognize Dash files.
so a simple change would be to change the extension of the Dash video files to mp4v
ps. My original suggestion would be m4v since we already got m4a but it seems Apple uses this format.

We need some way to tell youtube-dl to not use dash videos, I don't know of anyway currently but having the ext selector would do the job.
$ youtube-dl -f '18/best[ext=mp4]'

macOS treats m4v files differently than mp4 files for some reason. It will parse more metadata, such as the artist field, if the extension is .m4v. This is extremely important when searching for files, so I’ve changed my personal script to rename mp4 files to m4v after downloading them with youtube-dl.
For obvious reasons, I think it would be better to have the option in youtube-dl to use m4v from the start. Since the extension is identical to mp4, it should be trivial to change.
I’ve tried changing it myself, but I’m clearly missing something about the way the post-processing is coded. It should be easy for anyone that understands that though, from what I can tell.

@Saklad5 cant you just use:
--output '%(title)s.m4v'

or similar?

I’ve tried. Oddly enough, that ends up producing a file ending with .mp4.m4v. Not exactly what I’m looking for.

 The user should have control over the full filename, including the extension

@svnpenn Yeah, that clearly isn’t intended behavior. If it was, we wouldn’t have the %(ext)s. placeholder. Again, I suspect the post-processing code is to blame.

@Saklad5 you might want to check your version. I just tested this and it is not working as you say:
$ youtube-dl -f 140 --output example.m4v JkpT-xiSTBE
[youtube] JkpT-xiSTBE: Downloading webpage
[youtube] JkpT-xiSTBE: Downloading video info webpage
[youtube] JkpT-xiSTBE: Extracting video information
[download] Destination: example.m4v
[download] 100% of 5.25MiB in 00:00
[ffmpeg] Correcting container in "example.m4v"

Sorry, I may have forgotten to mention that I’m using the --recode-video mp4 argument. That’s the post-processing I’m talking about.

@Saklad5 sorry, I am done here. I dont deal with moving goalpost. You on your own.

@svnpenn Fair enough. Sorry for the confusion.

Issue should be closed, no example given


Fix bert_base_mrpc smoothquant check_shape issue

Type of Change
bug fix
Description
tensor.shape.dims is None and check_shape cause an issue
Expected Behavior & Potential Risk
check_shape return True when tensor.shape.dims is None
How has this PR been tested?
recipes={"smooth_quant": True, "smooth_quant_args": {'alpha': 0.5}} in PTQConfig, test bert_base_mrpc
Dependency Change?
None

Extension test pass.


Add updateBreadcrumbs hook to GridFieldDetailForm

Requires: https://github.com/silverstripe/silverstripe-admin/pull/291

There are some PHPCS issues. I'm looking at behat.

Linting issues? It's 1 line?

That'll make it easy to fix. :)


Transforms unit and cypress tests

Description
Adds Cypress tests and Jest unit tests to transforms. Does not fully cover transforms, but adds some bare minimum tests.
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c1b76de). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage        ?   61.93%
=======================================
  Files           ?      154
  Lines           ?     4335
  Branches        ?      665
=======================================
  Hits            ?     2685
  Misses          ?     1440
  Partials        ?      210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b76de...9e765a5. Read the comment docs.

Do we want to add "can successfully update transforms job" cypress test, too?

Testing for this is present in the "can be edited" test. Updates to transforms are limited. If you mean updating the data and rerunning the job, I think it's better to save tests like that for when we put out continuous transforms, since right now each run is discrete and separate.


Consider distributing a "binary" file?

Something that would easily allow downloading it and running it in CI, like https://github.com/indygreg/PyOxidizer or https://github.com/pantsbuild/pex

Nope


fix link to image

Description
This PR includes the following proposed change(s):

fix lint to image in readme
not sure if correct image but good for now

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

local readme

@alexjoybc  pls confirm later that this is the image you wanted, if not then you may update it :)


policy-controller: add custom labels

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

[x] Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
[x] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[x] JSON Schema generated.
[x] List tests pass for Chart using the Chart Testing tool and the ct lint command.

related to https://github.com/sigstore/helm-charts/issues/658


Ignore perl features prefix

perl_features_* will require a recompilation of all perl ecosystem,
and generally it doesn't work at all for random use flag compilation.
This should be controlled via tinderbox's own profile and ignored
when using pkg-testing-tools.

Thanks! I'll create a new release. (failing tests are a github hickup, i think)


"master" branch pyrobotlab protected

The master branch of pyrobotlab needs to be protected, now that I went through the process of merging "master" & "develop" branch.
The progression of changes is very simple.  All changes need to be done on the "develop" branch.  When we "release" code, these changes will be processed in a merge request against master.
This is a controlled and stable process which allows all the documentation, examples, and other material in pyrobotlab to stay in sync with myrobotlab.  Release are "always" done from master - changes "always" start on develop.

Branch is now protected.  All updates, deletions, and modifications can be done on "develop" branch !
Happy developing & happy releasing for all !


Sections/Group dropdown should only show groups TA can see

Split out from #1366:
Currently, the TA's section/group filter dropdown shows as "All Sections/Groups," regardless of which section(s) the TA has access to:

I think we had discussed the following:
If the TA does not have grade or view access to all sections/groups, this filter should reflect the sections/groups to which they do have access. So, for example, if a GB has 4 sections, and the TA has access to grade section 001 and view section 002, then the filter should default to "Available Sections/Groups" with the dropdown options showing the sections/groups. I think that'll clarify this a bit.
And, if the TA has grade/view access for only one section/group, I don't think there needs to be a dropdown at all. It can just say "Section 001 - Showing 7 Students". Does that make sense?

Reopening.. as hasn't been tested yet.

Fantastic. Confirmed!


Bump Gradle Wrapper from 8.2 to 8.2.1

Bumps Gradle Wrapper from 8.2 to 8.2.1.
Release notes of Gradle 8.2.1 can be found here:
https://docs.gradle.org/8.2.1/release-notes.html

@dependabot rebase

Merged as part of https://github.com/gradle/gradle-enterprise-build-validation-scripts/pull/465, not sure why this wasn't closed automatically.


I want to create the development environment locally, which branch should I use

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I'm using the master branch now

But I found that most people use 0.28

You should use master.
Not sure who are you referring to as people using 0.28.

thanks


[BUG] Social Media links not woking

Description of the bug
When we click on the twitter and discord logo it does not direct us to any link .
Please add screenshots (if applicable)

Add any other context about the problem here
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

you can use https://discord.webxdao.xyz/ & https://twitter.com/WebXDAO

you can use https://discord.webxdao.xyz/ & https://twitter.com/WebXDAO

can you please give me GSSOC'23 label?


Communication question

I am trying to write a program that runs both Motion and another MPC framework that uses emp-tools' NetIO, is it possible for both to use the same communication channel?

I briefly looked into the docs for NetIO and it seems to be just a wrapper over a network socket. So the answer is no unless the other framework serializes its communication.  Otherwise, you would need to kind of manually synchronize the communication in both frameworks, which is quite non-trivial.


Actual name is not showing on search if name contains any special character in Velocity theme

Bug report
Title
Actual name is not showing on search if name contains any special character
Preconditions
1. framework Version. Master

Steps to reproduce
1. step1 search product name(i.e. H&M)

Expected result:
https://prnt.sc/uvxhe1
Actual result
https://prnt.sc/uvx9wv

@bhanu-webkul
It is working fine

fixed in master


Update sec-scanners-config.yaml

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Added To-Do App (Flutter)

Description
Fixes #120
To-do App
A TO-DO list app using Hive local database
Flutter - Dart - Hive
Features of the app
Create new task
Delete the task
Storing the created task on local device
Alternate Features that can be added
Due date feature for tasks
Search feature for searching previously completed tasks

[X] My PR follows the style guidelines of this project
[X] I have performed a self-review of my own code or materials
[X] My branch is up-to-date with the Upstream development branch
[X] I have added necessary images/screenshots of my changes

Hey @Chirantan2 Great Work!
Thanks for your contribution into Androapps!


Added Aliyun storage adapter

Hi folks, I've worked out a tiny package to utilize Aliyun storage, which has the broadest coverage in China. It would be nice if we could put the links here. Thanks.

+1 will definitely accelerate the adoption of meteor in China as more and more such localized package being available. Great work!

+1


Add tests for CancellationToken handling for Query and rate limiting tests for Diagnostics

We are continuously addressing and improving the SDK, if possible, make sure the problem persist in the latest SDK version.

Describe the bug
We need tests that track 429 failure tracking and a framework for that in the SDK tests. we also need the ability to track CancellationToken
To Reproduce
Steps to reproduce the behavior. If you can include code snippets or links to repositories containing a repro of the issue that can helps us in detecting the scenario it would speed up the resolution.
Expected behavior
A clear and concise description of what you expected to happen.
Actual behavior
Provide a description of the actual behavior observed.
Environment summary
SDK Version:
OS Version (e.g. Windows, Linux, MacOSX)
Additional context
Add any other context about the problem here (for example, complete stack traces or logs).

Fixed in https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1584


Add filter option for subscribed issues

This pull request adds a filter option "subscribed" to the /issues overview and to the lists in in the repos (and to the API). Addresses https://github.com/go-gitea/gitea/issues/16111 (and closes the first part of it).
I know that the SQL command here is a very long and complex SQL command, but I didn't find another working way (I don't know enough about these xorm.Session conditions) and it works. The command just filters the issues if they are in the issue_watch table and is_watching is 1 or if they are in the comment table but not in the list of issues in issue_watch where is_watching is 0 or if they are in the issues table but not in the list of issues in issue_watch where is_watching is 0. If you know another way how to make this more readable, it would be nice if you could comment.

Probably, this is a very bad question, but how do I fix this test-pgsql integration test? Unfortunately, I don't know how to fix them. The errors are (in two different files):
GetUserIssueStats: operator does not exist: boolean = integer[0m pull_review_test.go:16: 	Error Trace:	integration_test.go:449 	 				integration_test.go:282 	 				pull_review_test.go:16 	Error: 	Not equal: 	 	expected: 200 	 	actual : 500 	Test: 	TestPullView_ReviewerMissed

Probably, this is a very bad question, but how do I fix this test-pgsql integration test? Unfortunately, I don't know how to fix them. The errors are (in two different files):
GetUserIssueStats: operator does not exist: boolean = integer
pull_review_test.go:16:
    Error Trace:	integration_test.go:449
        integration_test.go:282
        pull_review_test.go:16
    Error:
        Not equal:
            expected: 200
            actual : 500
Test: 	TestPullView_ReviewerMissed

I fixed it now. You can review this PR :)

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@10108b1). Click here to learn what that means.
The diff coverage is 28.57%.

@@           Coverage Diff           @@
##             main   #17053   +/-   ##
=======================================
  Coverage        ?   45.29%
=======================================
  Files           ?      773
  Lines           ?    86907
  Branches        ?        0
=======================================
  Hits            ?    39366
  Misses          ?    41175
  Partials        ?     6366

Impacted Files
Coverage Δ

routers/api/v1/repo/issue.go
47.40% <0.00%> (ø)

routers/web/user/home.go
58.33% <0.00%> (ø)

models/issue.go
57.99% <26.08%> (ø)

routers/web/repo/issue.go
38.57% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10108b1...8af218c. Read the comment docs.

Closing this as it's better solved by https://github.com/go-gitea/gitea/pull/17156


Don't inject headers if span context is zero

httptrace.Transport.RoundTrip should not call ToRequest on Formats if span.SpanContext().IsZero() (add IsZero() method)

This is an invalid case. We will always generate a new span context for the outgoing request. If sampling decision is false, we will already represent it as 0. We should inject the header, the next hop can still read the header and make a new sampling decision.


CONSENT FORM OPTIONAL

Looks all good to me. Make sure you add a comment in the form above the consent form field that it will be displayed/hidden by the JS and the reason.


label > input[type=checkbox] + span never checks

we use checkboxes and labels in the form:

  <input type="checkbox" />
  label contents

with fastclick, this setup doesn't work in iOS 8.1 (I haven't tested older versions). I've tried label > span { pointer-events: none; } which doesn't work either. interestingly, a div instead of a span works (with pointer-events: none).
please see my test cases at: http://codepen.io/visnup/pen/XJNvEq

as a workaround, I'm using display: block on the span along with pointer-events: none.

This actually appears to be a Webkit/Blink bug; it doesn't happen with touch emulation in Firefox (but does with Chrome). It seems when the synthetic click bubbles up to the label, it doesn't trigger the checkbox. What I'm seeing that's really weird is the checkbox's change event actually fires in this case, and checkbox.checked is what you'd expect. A hacky workaround is doing something like:
checkbox.addEventListener('change', function() {
  checkbox.checked = checkbox.checked;
});

which doesn't appear to retrigger the change event but does properly update the state.

Have the same issue.
The solution based on pointer-events: none does not resolve all our cases as it requires display: block  (or the like).
#354 resolves all our cases. Thank you, @quarterto.
+1 for #354 merge.

+1 for #354 merge

I had this issue after installing fastclick as well.
display:block and pointer-events:none on the span worked for me.

+1 for #354 merge

:+1: for #354


Speed / Volume ATR study data expected but not available at Shoreham Drive: Gosford Blvd - Hullmar Park Trail

What Happened
A user received a notification that their Speed / Volume ATR study request at Shoreham Dr: Gosford Blvd – Hullmar Park Trl was complete. When they go to that location in MOVE, no study data is available.
What Should Happen
Study data should be available at the specified location.
To Reproduce
Steps to reproduce the bug:

Go to Shoreham Dr: Gosford Blvd – Hullmar Park Trl
Scroll down to 'Studies'
See error (zero studies available at this location)

Screenshots
n/a
Additional Notes
Study requests at this location:

#214
#469

Confirmed that this data is available in FLOW at stations "SHOREHAM DR E/B W OF GOSFORD BLVD" (arterycode 41562) and "SHOREHAM DR W/B W OF GOSFORD BLVD" (arterycode 41563).
This appears to be a conflation issue:
flashcrow=> select * from counts.arteries_centreline where arterycode in (41562, 41563);
 arterycode | centreline_type | centreline_id | direction |                        geom
------------+-----------------+---------------+-----------+----------------------------------------------------
      41562 |                 |               |           |<PHONE_NUMBER>E6100000D498D2119DE153C0CEB63AE545E24540
      41563 |                 |               |           |<PHONE_NUMBER>E6100000D498D2119DE153C0CEB63AE545E24540
(2 rows)

Let's look closer at that geometry:
flashcrow=> select ST_AsEWKT('0101000020E6100000D498D2119DE153C0CEB63AE545E24540'::geometry);
                      st_asewkt
-----------------------------------------------------
 SRID=4326;POINT(-79.5252117687808 43.7677580391588)
(1 row)

This location does appear to be right on Shoreham - what's going on?
flashcrow=> select * from counts.arteries_double_node where arterycode = 41562;
 arterycode | ftype |  fnode   | ttype |  tnode   | n |                        geom
------------+-------+----------+-------+----------+---+----------------------------------------------------
      41562 |     2 | 13448119 |     2 | 13447983 | 2 |<PHONE_NUMBER>E6100000D498D2119DE153C0CEB63AE545E24540
(1 row)

flashcrow=> select * from counts.arteries_double_link where arterycode = 41562;
 arterycode | from_link_id | to_link_id | geo_id
------------+--------------+------------+--------
      41562 |     13448119 |   13447983 |
(1 row)

So we find both of its endpoints, but don't find a geo_id matching them.

Meanwhile: these requests were submitted on this midblock, which has centrelineId = 30054901.
flashcrow=> select from_inter, to_interse from gis.centreline where centreline = 30054901;
 from_inter | to_interse
------------+------------
   13447983 |   30054900
(1 row)

That other intersection is indeed in the centreline.intersections table:
flashcrow=> select * from centreline.intersections where "centrelineId" = 30054900;
 centrelineId | centrelineType | classification |          description           | featureCode |                        geom                        |     lat      |      lng
--------------+----------------+----------------+--------------------------------+-------------+----------------------------------------------------+--------------+---------------
     30054900 |              2 | LSRSL          | Shoreham Dr / Hullmar Park Trl |      504000 |<PHONE_NUMBER>E6100000EF9F2A83A3E153C0766417D242E24540 | 43.767664205 | -79.525605003
(1 row)

However, the arterycodes appear to be coded to the whole Gosford to Bamford section:
flashcrow=> select * from centreline.intersections where "centrelineId" = 13448119;
 centrelineId | centrelineType | classification |        description         | featureCode |                        geom                        |     lat      |      lng
--------------+----------------+----------------+----------------------------+-------------+----------------------------------------------------+--------------+---------------
     13448119 |              2 | MNRSL          | Shoreham Dr / Bamford Cres |      501300 |<PHONE_NUMBER>E610000097ACF70CC2E153C0AC6EA45535E24540 | 43.767252641 | -79.527468912
(1 row)

We have a couple of options here.
One is to add a manual override for these arterycodes (see this script for how those are managed).
Another is to try and detect cases like this, where the arterycodes match one endpoint of a midblock but not the other.  We don't yet handle that (see this script for steps), but broadly speaking this would entail:

list all candidate midblocks (i.e. where one of from_inter, to_interse matches);
find the best candidate according to some ranking / metric.

Here the best candidate could be the closest spatial match to geom (which should be efficient, as it can use spatial indexes).  There are quite a few arterycodes that could benefit from this:
flashcrow=> select count(*) from counts.arteries_centreline where geom is not null and centreline_id is null;
 count
-------
   763
(1 row)

Confirmed that these studies are visible in MOVE prod post-v1.6 release - closing out.


Preload set of docker verified images to speed up user 1

Suggestion details
Since Pyrsia can't accelerate any downloads without any content, preload docker images.
Suggested starting point:
alpine (very small)
ubuntu (very large)
That should be enough to get started, we can pursue the other 17,000 images more systematically in a future story
Additional details
No response

@sbtaylor15 I think we should close this. We are not going to pre-load any more images.

nginx
ubuntu
alpine


pbccs --by-strand chunking

I am running pbccs --by-strand (v 4.2.0) and wish to chunk. Will consensus reads belonging to a particular ZMW always be grouped in the same chunk or is it possible that, for example, the forward consensus sequence of ZMW A is in chunk 1 and the reverse consensus sequence of ZMW A is in chunk 2?

The atomic unit of chunking is a ZMW.


Raw code

Hi, Would be great to get a link to the raw code if that is possible?

Hi @cjrod - links to code have been posted in each folder


On the Step 2 of 3 page, Join the waitlist text offset

There's no more waitlist so we can close this. :)


Fix IndexOutOfBoundsException thrown in DefaultPassageFormatter by unordered matches

test: add unit tests to reproduce the IndexOutOfBoundsException in DefaultPassageFormatter
doc: clarify javadoc of MatchesIterator
fix: sort passages by offset if positions are missing

Fix #12431
Description
DefaultPassageFormatter may cause an IndexOutOfBoundsException in case matches of a passage are out of order.
This happens when term vectors are stored but not the positions.
The tentative solution consists in ordering matches according to offsets in DisjunctionMatchesIterator in case positions don't exist.
However, I wonder if it is correct to create such an iterator when positions are not available. Matches with no terms are explicitly removed, and the javadoc of MATCH_WITH_NO_TERMS mentions that it indicates a match with no term positions. Therefore, from that doc it shouldn't be possible to highlight text without positions. Is that javadoc correct ? Should it be updated ?
https://github.com/apache/lucene/blob/bc678ac67e32c55a27a4e8950c25144cc89cef66/lucene/core/src/java/org/apache/lucene/search/MatchesUtils.java#L67
https://github.com/apache/lucene/blob/bc678ac67e32c55a27a4e8950c25144cc89cef66/lucene/core/src/java/org/apache/lucene/search/MatchesUtils.java#L40-L44

What a fun and tricky corner case -- thank you @scampi for uncovering this, showing the bug with the added unit tests, and the tentative fix.
I think it is actually technically allowed to index term vectors with offsets only (no positions) and then hilite from there: Lucene is recording the character offsets of every occurence of each unique term, per document, and that's all that is needed to hilite.  So I like your fix -- I'll merge it soon unless anyone objects.
Could you maybe add a lucene/CHANGES.txt entry?
I think the intent of MATCH_WITH_NO_TERMS is different: that is for queries against Lucene index structures that fundamenally do not track positional information (doc values, points).  With term vectors, the positional information indeed exists, it's just that the user may choose to record only offsets.

@mikemccand @romseygeek thanks for the review!

What a fun and tricky corner case -- thank you @scampi for uncovering this, showing the bug with the added unit tests, and the tentative fix.

I actually just contributed the fix, @hossman found the issue and posted the test.

Could you maybe add a lucene/CHANGES.txt entry?

I have added a commit for this.

@dweiss thanks!


Suggestion: generate AWS Lambdas / Azure Functions that implement an OpenAPI spec

Suggestion
AWS Lambdas / Azure Functions stand up a single endpoint. To keep the magic of spec-first, it's possible to wrap an entire Flask app in a function, but that loses the point of Serverless.
It would be great to have a way to directly generate the functions in a project, based on an OpenAPI file.

I think this would be out of scope for this project (Connexion), but feel free to start a new project for serverless OpenAPI functions.

Closing as out of scope. Please reopen if I missed something!


PR - banana-i18n integration in simulator

Describe the changes you have made in this PR -

add banana-i18n as a npm dependency
Create configuration module for banana-i18n
Design mechanism for Asynchronous loading
handle fallbacks and current locale events
Json files for en and hi translations

Testing

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

cc @tachyons


Add a bg color to the selected tab in a client when it isn't focused

I think it would be really nice if there is a way to make the selected tab has a color when the client isn't focused, for example:
When the client isn't selected:

When the client is focused:

Valid and great request. Considering the current theme vars are called tabbar_fg_focus and tabbar_fg_normal, would that one just be called tabbar_fg_unselected? I can't come up with an intuitive name for that.

You are right, the name could be tabbar_bg_focused_inactive or just tabbar_bg_inactive, what do you think about these names?

@okaabe Don't close Issues until referenced PR isn't merged or closed.

Yea I think while we are at it, we can add the same variables for unfocused (and inactive) tabs. Otherwise it would be a little weird to only have that ability for focused tabs I think (ie probably tabbar_bg_focused_inactive and tabbar_bg_normal_inactive etc)


Failed to start - Exit Code -1073741515

Thank you for creating this plugin so swiftly to run Ascended, unfortunately it does not seem to run for me though, I've provided the error message from the console below.
If you are able to point me to where I can find the crash log files I'd be more than happy to provide those as well.
[#1] [ERROR] Exit Code: -1073741515
[#1] Server: Fail to start

Would love to get this working, thanks!

I had to install steam for it to work, no idea otherwise.

Could be also that you're missing some dependencies,like vcredist, directx etc. not sure.

Both seemed to be the case, thank you for the guidance!
Closing this issue now 😄


OCM-5079 | fix: allow cluster compute SG IDs to be computed and block updates

Related issue: OCM-5079
Allow cluster attribute AWSAdditionalComputeSecurityGroupIds to be computed by backend. So that on a state refresh it may be set to null if the API returns null. This scenario happens when removing the standard machine pool (named worker).
Also blocks further updates to any of the security groups attributes

/retest

/retest

/retest


update WS_EX_NOREDIRECTIONBITMAP to explain what it is used for and when

@ChrisGuzak : Thanks for your contribution! The author(s) have been notified to review your proposed change.


WIP operator-SDK update

What this PR does:
Note to @jsanda, if you merge this - you'll fix it! ;)
Updates the base of cass-operator to use operator-sdk 1.8 instead of the old pre-0.18.x line. This means new kubebuilder v3 layout as well as other controller-runtime changes.
Other changes include removal of Helm charts, reduction of mage use (intended to remove) and replaced with Makefile.
TODO Still:

[ ] Re-enable webhooks
[x] Re-enable dynamicSecrets (or replace with better approach)
[ ] Metrics (+prom) verification and Cassandra ServiceMonitor
[ ] ClusterRole / Role generation
[ ] Generate samples
[ ] openapi-gen / client-gen
[ ] Update & PSP tests can't be ran
[ ] Move operator/pkg to pkg/
[x] All the reconciliation logic (except ReconciliationContext) to controllers/
[ ] Rest of mage, migrate to Makefile and remove rest which are not used
[ ] Migrate crd.patch (x-kubernetes-keys removals) to Kustomize

Here or next PR:

[ ] Add envtest usage for tests, replace some integ tests with envtest
[ ] Merge integ-tests where necessary
[ ] Rewrite fakeclient tests with envtest instead
[ ] Fix bundle creation
[ ] UBI-image support

Which issue(s) this PR fixes:
Fixes #
Checklist

[ ] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[ ] CHANGELOG.md updated (not required for documentation PRs)
[x] CLA Signed:  DataStax CLA

@burmanm I realize that there is no way to avoid this being a massive PR, but it would be great if you are able to pull out anything into separate, smaller PRs. It will make reviewing a lot easier. Please let me know when you want me to start reviewing.

I'm not sure if separating to different PRs is easy (even if we accept that they won't compile / run tests until all of them are merged).

I'm not sure if separating to different PRs is easy (even if we accept that they won't compile / run tests until all of them are merged).

Wishful thinking on my part :)


Make the BotFrameworkAdapter behave like a true receiver of the incoming HTTP request

Looking at node, you can see we wire up the adapter as the listener for incoming HTTP POST messages. In .Net however, we (today) have this intermediary code in each controller:
[HttpPost]
public async Task<IActionResult> Post([FromBody]Activity activity)
{
    try
    {
        await _adapter.Receive(this.Request.Headers["Authorization"].FirstOrDefault(), activity);
        return this.Ok();
    }
    catch (UnauthorizedAccessException)
    {
        return this.Unauthorized();
    }
}

This code brings up a few questions:

Why do I need the Authorization header?
What happens if I want to pass other headers to my adapter?
What happens if the BotFrameworkAdapter requires additional headers later? Or removes the need for Authorization ones?
Why does UnauthorizedAccessException get thrown?

To alleviate this, just make the adapter act like it does in node - as a true recipient of the incoming request:
[HttpPost]
public Task Post() => _adapter.Receive(this.Request);

Now, BotFrameworkAdapter is free to change its usage/requirements under the hood and users don't need to care. It's also congruent with what developers in Node are doing by wiring up http listen to the adapter's receive method.
This PR accomplishes this ask & updates the samples accordingly.
cc @cleemullins @lynn-orrell

🕐

Brandon, I think this needs to be rethought in terms of #145 I am going to close this...if you want to refactor it based on 145, then you can reopen then.  Thanks for your input!


cdk: 5.0-20171209 -> 5.0-20190224

Motivation for this change
bump to 2019 :)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Only in-tree user is gtdialog which looks good AFAICT :)

Indeed, textadept pins an older one.
@GrahamcOfBorg build gtdialog


Doc Feedback:

Location : https://apim.docs.wso2.com/en/latest/Learn/APISecurity/APIAuthentication/AdvancedTopics/encrypting-secure-endpoint-passwords/
this documentation seems outdated since it refers to the previous version of the API manager i.e.  set the element  in the <APIM_HOME>/repository/conf/api-manager.xml file to true.

Reviewed and updated in https://github.com/wso2/docs-apim/pull/789
The updated page can be found in [1]
[1] https://apim.docs.wso2.com/en/latest/administer/product-security/logins-and-passwords/working-with-encrypted-passwords/#encrypting-secured-endpoint-passwords


Incomplete intellisense / dropdown method list

In Godot v3.1.1. GDScript, when typing some method name, for example "instance", it does not appear anywhere in the dropdown help list.

The instance() method will only appear if the object you're calling it on is a PackedScene. Can you post the script in which autocompletion fails?
Also, remember that if the script you're currently editing has errors, you must solve them before autocompletion appears again.

This is too vague, so closing. You can reopen if you have some particular example with reproduction steps. Also be sure to try 3.1.2.


Add support for thread name

Add optional support for including the thread name in the log output

Merged into version 2.0. Using the thread's address when no name is present. Thanks for the PR.


Option to change what keys are mapped to fix macros

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.clue
Description
Hello!
I have remapped q and Q so that I don't accidentally start recording a macro when mashing q to close some windows.
vim.keymap.set('n', 'Q', 'q')
vim.keymap.set('n', 'q', '', { remap = true })

However, now I cannot record macros at all because pressing Q now throws an error:
E354: Invalid register name: '^@'

I'm guessing this is because mini.clue remaps Q.
Is it possible to add options to change what keys mini.clue maps in order to solve issues with macros?

Thanks for the suggestion!
The 'mini.clue' module indeed does some things with macro recording. This is done so that it is possible to use keys with triggers inside macros.
It indeed remaps @ (default key for replaying macro from some register) and Q (default key for repeating the last recorded register). Those keys are not arbitrary and are there to make replaying possible (mostly because there is no automated way to do that; see neovim/neovim#24565).
If you want your own mapping for Q instead of what 'mini.clue' does, the suggestion is to make own mapping after require('mini.clue').setup().
Closing as not planned.


Missing Required Info - You Lose the User with a Directory Switch

Clearly written by someone who already knows where "stuff" is, also known as advanced knowledge not generally known to those just arriving.
Working through the process at "Creating a new application to store..." at the end of the steps (13) you move to the next topic "Modifying your custom policy...". You give no indication that we must switch from AAD to AAD B2C directory or where the "Relying Party" xml document is when you get there.  This is not clear to the reader.
This statement in step 1 of this section, "If you are starting out, it may be advisable to download your already configured version of the RP-PolicyEdit file directly from the Azure B2C Custom Policy section in the Azure portal." How is it already configured? Where is it?
This is not clear there is no menu or label for "Azure B2C Custom Policy" Where is this document? What is it called? How do I download it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29fb9816-df6a-6f60-35d0-c2a04732f295
Version Independent ID: ffc8b13a-b2c9-a502-1580-abea596194ab
Content: Azure Active Directory B2C: Add your own attributes to custom policies and use in Profile Edit
Content Source: articles/active-directory-b2c/active-directory-b2c-create-custom-attributes-profile-edit-custom.md
Service: active-directory-b2c
Product: unspecified
GitHub Login: @davidmu1
Microsoft Alias: davidmu

In the note: is this statement: The is referred to as "common" because its elements... Subject is missing from the sentence, what does "The" refer to in the sentence?

I found this in the Prerequisites section:
"Complete the steps in the article Getting Started with Custom Policies."
This has the missing information. It would be advisable to mention again that the reader will find the information in the Getting Started link from Prerequisites.  However the actual name in the left side menu is "Get Started" not Getting Started.

@laultman Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

Added text to clarify the files that are used when adding code snippets.
#please-close

@laultman We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Invocation of LC.exe in the LC Task

https://github.com/Microsoft/msbuild/blob/master/src/XMakeTasks/LC.cs#L184 states that when building against a framework > 4.0, lc.exe will accept an @response.rsp file.
This actually only works for the lc.exe in the v10.0A SDK for the 4.6.2 Tools. Seems like the version check should be against 4.6.2 instead of 4.0?

I confirm this bug.
I have spent the day trying to debug a license not being generated on the build server.

The command line logged worked when typed directly in the cli.
MSBuild invokation of lc.exe fails with the logo (the arguments seems not to be understood)
Further investigation show that msbuild launch lc.exe with a rsp temp file
copying this rsp temp file and launching lc as msbuild does reproduce the issue

I am using .NET 4.5.1 toolkit (sdk v8.0A).

Did some source-history spelunking today. lc.exe was taught to handle a response file in July 2014, and the task was changed to use response files unconditionally in January 2015. Later that month it was changed to the current form, using 4.0 as a cutoff.
On my current machine, I have many different lc.exes:
C:\Program Files (x86)\Microsoft SDKs>dir /s /b lc.exe
C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6 Tools\lc.exe
C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6 Tools\x64\lc.exe
C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\lc.exe
C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\x64\lc.exe
C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Bin\lc.exe
C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Bin\x64\lc.exe
C:\Program Files (x86)\Microsoft SDKs\Windows\v8.1A\bin\NETFX 4.5.1 Tools\lc.exe
C:\Program Files (x86)\Microsoft SDKs\Windows\v8.1A\bin\NETFX 4.5.1 Tools\x64\lc.exe

It looks like the real cutoff is at .NET 4.6:
C:\>"C:\Program Files (x86)\Microsoft SDKs\Windows\v8.1A\bin\NETFX 4.5.1 Tools\lc.exe" /?
Microsoft (R) .NET License Compiler
[Microsoft .Net Framework, Version 4.0.30319.42000]
Copyright (C) Microsoft Corporation.  All rights reserved.

Generates a .NET Licenses file and adds it to the manifest of the given assembly
Usage:
    lc /target:TargetAssembly /complist:filename [/outdir:path] [/i:modules] [/v] [/nologo]

Options:
    /target:<str>              Target assembly for the generated licenses file
    /complist:<str>            Licensed component list file
    /outdir:<str>              Output directory for the generated licenses file
    /i:<str>                   Specify modules to load
    /v                         Verbose output
    /nologo                    Suppress the display of the startup banner

C:\>"C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6 Tools\lc.exe" /?
Microsoft (R) .NET License Compiler
[Microsoft .Net Framework, Version <IP_ADDRESS>]
Copyright (C) Microsoft Corporation.  All rights reserved.

Generates a .NET Licenses file and adds it to the manifest of the given assembly
Usage:
    lc /target:TargetAssembly /complist:filename [/outdir:path] [/i:modules] [/v] [/nologo]

Options:
    /target:<str>              Target assembly for the generated licenses file
    /complist:<str>            Licensed component list file
    /outdir:<str>              Output directory for the generated licenses file
    /i:<str>                   Specify modules to load
    /v                         Verbose output
    /nologo                    Suppress the display of the startup banner
    @<file>                    Accept options from a response file

The targets use lc.exe from the target sdktools directory, so I think the right cutoff is 4.6.

Thank you Rainer, I did not have the energy to install the sdk and locate the real cutoff. I updated my PR to reflect your finding.

This was fixed a loooooong time ago by @bbaumann in #1414. Thanks again!


Add chown and xattr related operation to jnifuse

Codecov Report

Merging #12985 (c9c7c99) into master (797ece1) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master   #12985      +/-   ##
============================================
- Coverage     42.30%   42.26%   -0.05%
+ Complexity     8517     8511       -6
============================================
  Files          1351     1353       +2
  Lines         77809    77836      +27
  Branches       9493     9494       +1
============================================
- Hits          32920    32894      -26
- Misses        42057    42105      +48
- Partials       2832     2837       +5

Impacted Files
Coverage Δ
Complexity Δ

...va/alluxio/client/file/cache/DefaultMetaStore.java
92.45% <ø> (ø)
15.00 <0.00> (ø)

...java/alluxio/client/file/cache/QuotaMetaStore.java
74.35% <ø> (ø)
17.00 <0.00> (ø)

...lluxio/client/file/cache/evictor/CacheEvictor.java
100.00% <ø> (ø)
1.00 <0.00> (?)

...xio/client/file/cache/evictor/LFUCacheEvictor.java
80.95% <ø> (ø)
20.00 <0.00> (ø)

...xio/client/file/cache/evictor/LRUCacheEvictor.java
100.00% <ø> (ø)
7.00 <0.00> (ø)

...n/java/alluxio/jnifuse/AbstractFuseFileSystem.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../src/main/java/alluxio/jnifuse/FuseFileSystem.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...ava/alluxio/jnifuse/utils/NativeLibraryLoader.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...nt/file/cache/evictor/UnevictableCacheEvictor.java
50.00% <50.00%> (ø)
3.00 <3.00> (?)

...alluxio/client/file/cache/evictor/FIFOEvictor.java
83.33% <83.33%> (ø)
5.00 <5.00> (?)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797ece1...b971fa9. Read the comment docs.

alluxio-bot, merge this please


Test failure: ClosesAfterDataSent

This test fails occasionally with the following error:
Assert.Contains() Failure
Not found: Server: Microsoft-IIS/10.0
In value:  List<String> ["Transfer-Encoding: chunked", "Server: Microsoft-IIS/8.5", "Date: Wed, 19 Sep 2018 19:52:32 GMT", ""]
   at Microsoft.AspNetCore.Server.IntegrationTesting.TestConnection.ReceiveHeaders(String[] lines) in /_/test/Common.Tests/Utilities/TestConnections.cs:line 204
   at Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests.ResponseAbortTests.ClosesAfterDataSent() in /_/test/IIS.Tests/ResponseAbortTests.cs:line 57
--- End of stack trace from previous location where exception was thrown ---
------- Stdout: -------
| [0.002s] TestLifetime Information: Starting test ClosesAfterDataSent at 2018-09-19T19:52:30
| [2.047s] Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests.TestServer Debug: Method: GET, RequestUri: 'http://localhost:55814/start', Version: 2.0, Content: <null>, Headers:
|                                                                                {
|                                                                                }
| [2.052s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting starting
| [2.053s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting started
| [2.054s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Loaded hosting startup assembly IIS.Tests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60
| [2.054s] Microsoft.AspNetCore.Hosting.Internal.WebHost Information: Request starting HTTP/1.1 GET http://localhost:55814/start
| [2.055s] Microsoft.AspNetCore.Hosting.Internal.WebHost Information: Request finished in 0.6588ms 200
| [2.055s] Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests.TestServer Debug: StatusCode: 200, ReasonPhrase: 'OK', Version: 1.1, Content: System.Net.Http.HttpConnection+HttpConnectionResponseContent, Headers:
|                                                                                {
|                                                                                Transfer-Encoding: chunked
|                                                                                Server: Microsoft-IIS/8.5
|                                                                                Date: Wed, 19 Sep 2018 19:52:32 GMT
|                                                                                }
| [2.055s] Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests.TestServer Debug: Done
| [2.057s] Microsoft.AspNetCore.Hosting.Internal.WebHost Information: Request starting HTTP/1.1 POST http://localhost/  1
| [2.076s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting shutdown
| [302.076s] Microsoft.AspNetCore.Hosting.Internal.WebHost Information: Request finished in<PHONE_NUMBER>ms 200
| [303.352s] TestLifetime Information: Finished test ClosesAfterDataSent in<PHONE_NUMBER>s

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
This test failed on 2.2.
CC @muratg
This issue was made automatically. If there is a problem contact ryanbrandenburg.

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

Is this actually a flaky test?

No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
Yes, proceed below...

Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

[ ] File a bug against the product (TODO: Link to other bug)
Is it possible to change the test to avoid the flakiness?

Yes? Go to the "Change the test!" section.
No?

[ ] Disable the test (TODO: Link to PR/commit)
[ ] Wait for other bug to be resolved
[ ] Wait for us to get build that has the fix
[ ] Re-enable our test (TODO: Link to PR/commit)
[ ] Close this bug

Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

Is there is a way to change our test to avoid this flakiness?

Yes? Change the test!

[ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
[ ] Run the test 100 times locally as a sanity check.
[ ] Close this bug

No?

Is there any logging or extra information that we could add to make this more diagnosable when it happens again?

Yes?

[ ] Add the logging (TODO: Link to PR/commit)

No?

[ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

This comment was made automatically. If there is a problem contact ryanbrandenburg.

ClosesAfterDataSent failed with about the same error on 2.2.
This comment was made automatically. If there is a problem contact ryanbrandenburg.

cc @pakrym @jkotalik

This was fixed. Update universe is broken and change doesn't get propagated: http://aspnetci/viewType.html?buildTypeId=Releases_22xPublic_UpdateUniverse&tab=buildTypeHistoryList


graphene: fix darwin build

Motivation for this change
ZHF: #144627 @NixOS/nixos-release-managers
Only wrap introspection.py if present - it appears to only be installed on linux.
Passthru tests still work on linux.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 145493 run on x86_64-darwin 1

6 packages marked as broken and skipped:

gnome-hexgl
gtkmm4
helvum
mousai
vimix-gtk-themes
whitesur-gtk-theme

2 packages failed to build:

gssdp-tools
gthree

3 packages built:

graphene
gtk4
gtksourceview5


DllNotFoundException: System.Native when executing RuntimeInformation.IsOSPlatform on mono

I'm trying to run a basic ASP.NET Core application on Ubuntu 16.04 using mono 4.2.1 and .Net Core 1.0:

mkdir webapp, cd webapp, dotnet new -t web
in project.json, remove Microsoft.NETCore.App from dependencies, change frameworks to: "net451": { }, remove prepublish from scripts
dotnet restore, dotnet publish
mono bin/Debug/net451/ubuntu.16.04-x64/publish/webapp.exe

At the last step, I get an exception:
Unhandled Exception:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.DllNotFoundException: System.Native
  at (wrapper managed-to-native) Interop+Sys:GetUnixNamePrivate ()
  at Interop+Sys.GetUnixName () <0x40d02200 + 0x0000b> in <filename unknown>:0
  at System.Runtime.InteropServices.RuntimeInformation.IsOSPlatform (OSPlatform osPlatform) <0x40d02190 + 0x00023> in <filename unknown>:0
  at Microsoft.Extensions.Logging.Console.ConsoleLogger..ctor (System.String name, System.Func`3 filter, Boolean includeScopes) <0x40d01bb0 + 0x00153> in <filename unknown>:0
[snip]

Since there is no System.Native in the publish directory, I attempt to work around this by adding "runtime.ubuntu.16.04-x64.runtime.native.System": "1.0.1" to dependencies.
This copies System.Native.so (and System.Native.a) to publish, but I still get the same exception. Then, by setting MONO_LOG_LEVEL="debug", I figure out that mono is mostly looking for libSystem.Native (or libSystem.Native.so). So I run mv System.Native.so libSystem.Native and now the application finally executes.
Trivial console application trying to reproduce the issue behaves differently. dotnet publish publishes a different version of System.Runtime.InteropServices.RuntimeInformation.dll: it seems it's the one from runtimes/unix/lib/netstandard1.1 from the NuGet package for the ASP.NET Core application, and the one from lib/net45 for the trivial console application. I believe this is caused by referencing the libuv package, which forces the use of runtimes.
I'm not sure if this is an issue with corefx or dotnet publish, so I'm reporting it here.

Note: I didn't use dotnet run at first, because that encounters a a different bug. But the workaround for that (use dotnet run -c Release) throws the same DllNotFoundException as above.

@svick I believe we should move this to dotnet/cli. Can you please open up an issue there and close this one? Thanks!

@blackdwarf Done: https://github.com/dotnet/cli/issues/3939.


[Build break 1.0 / 1.1] Wrong Security Plugin branch

During CI builds there is a failure on Run integration tests, with the following
Error:  The goal you specified requires a project to execute but there is no POM in this directory (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/security). Please verify you invoked Maven from the correct directory. -> [Help 1]
From inspection it looks like the workflow is checking out the wrong branch.
Checking out the ref
  /usr/bin/git checkout --progress --force -B main refs/remotes/origin/main
  Switched to a new branch 'main'
  branch 'main' set up to track 'origin/main'.
/usr/bin/git log -1 --format='%H'
'fb70a751312af9ab9683aaff878c8b145dda7ac6'

This reference is pointed to main - I think we need to adjust the workflow to point to the correct branch for 1.0 and 1.1 builds that use maven.
See log for additional details https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/4348472586/jobs/7597042933?pr=1365

[Triage] Hi Peter, thank you for filling this issue. I know this is related to your work on backporting these changes for some contributors so I will be assigning this to you.

Closing as we have no plans of releasing 1.0/1.1 versions


Loading indicator not very visible

The small white spinning loading indicator is not very visible.

 VM438:2 # 14   Loading indicator not very visible   https://api.github.com/repos/cyclic-reference/ddlc-jetbrains-theme/issues/14


Update 90-Subsets-II.java

File(s) Modified: Update 90-Subsets-II.java
Language(s) Used: java
Submission URL: _https://leetcode.com/submissions/detail/756126226/_

File(s) Modified: Update 74-Search-A-2D-Matrix.java
Language(s) Used: java
Submission URL: https://leetcode.com/submissions/detail/756138664/

Thanks, @Basit-Imam!


chore: disable Grammarly on <textarea /> elements

Reported to break focus, cf. https://github.com/bpmn-io/bpmn-js-properties-panel/issues/810.
Related to https://github.com/bpmn-io/bpmn-js-properties-panel/issues/810.

I also disabled it for optional FEEL Textareas (only used in element templates): 7b870f1


Join GBdev and forums

https://forum.gbadev.org/
https://www.patreon.com/gbdev01
https://www.ticalc.org/account/signup.html

Waiting for ticalc and gbadev...


Support configurable seed for murmur32

Coverage decreased (-0.04%) to 78.038% when pulling b638f1cf7c116964e0a5406925db07e17080e424 on richardartoul:ra/support-murmur-seed into f5f7ec1d56d83ebe851f79a72ab5096fe4c56908 on m3db:master.

We also need to add this field to the client/Configuration struct too so that users using it to create clients have the ability to specify the seed.

@robskillington How do you feel about adding a check in m3dbnode/server.go to make sure that the hash seed for the client configuration and the hash seed for the node configuration are the same? The YAML configures them independently, but it seems like you would always want them to be the same right?

Coverage decreased (-0.05%) to 78.028% when pulling 7b4b604309300d4b5cded08ad2f45b41c2995fd4 on richardartoul:ra/support-murmur-seed into f5f7ec1d56d83ebe851f79a72ab5096fe4c56908 on m3db:master.

@richardartoul so the server actually uses whatever topology descriptions are present in the top level config and ignores the client level one so that what you described isn't possible:
// services/m3dbnode/server.go

// topo options are parsed from top level config
	topoOpts := topology.NewDynamicOptions().
		SetConfigServiceClient(configSvcClient).
		SetServiceID(serviceID).
		SetQueryOptions(services.NewQueryOptions().SetIncludeUnhealthy(true)).
		SetInstrumentOptions(opts.InstrumentOptions())

	topoInit := topology.NewDynamicInitializer(topoOpts)
	topo, err := topoInit.Init()
	if err != nil {
		logger.Fatalf("could not initialize m3db topology: %v", err)
	}

	hostID, err := cfg.HostID.Resolve()
	if err != nil {
		logger.Fatalf("could not resolve local host ID: %v", err)
	}

	m3dbClient, err := cfg.Client.NewAdminClient(
		client.ConfigurationParameters{
			InstrumentOptions: iopts.
				SetMetricsScope(iopts.MetricsScope().SubScope("m3dbclient")),
			TopologyInitializer: topoInit,
		},
		// ...
	)

So you can see that we explicitly pass the topoInit to the cfg.Client.NewAdminClient(...) method which will correctly ignore any settings they have on the client configuration itself:
// client/config.go

// NewAdminClient creates a new M3DB admin client using
// specified params and custom options.
func (c Configuration) NewAdminClient(
	params ConfigurationParameters,
	custom ...CustomAdminOption,
) (AdminClient, error) {
	// ... other stuff

	topoInit := params.TopologyInitializer
	if topoInit == nil {
		// ... use client level configuration for sharding/discovery settings
	}

@robskillington Oh wow nice, Ok I'm gonna go ahead and merge this then. Thanks!


Add min, max and default timeout to helptext

Hi,
nice tool :-)
I think it would be good to give the information what the min and max values for --timeout is. The default value and maybe a unit like s or ms would be nice to know, too.
Some attacks are throwing exceptions when the time runs out others don't. Maybe this could be unified.
Thanks for the tool!

Hi,
Timeout is a fixed value, seteable by command line.
You may want to know min/max/avg of the total elapsed time for each attack and maybe globaly for the whole.
I'm currently out of time to implement that but if you like to send a PR I'll be glad to merge.

I think is implemented now, i'm closing this.

Thank you for your work. The timing information you added are really interesting.
Sorry I could not make clear what I meant. I try to make it more clear.
When I type python RsaCtfTool.py -h there is this line --timeout TIMEOUT     Timeout for long attacks. in the helptext.
What I think would be useful is to know:
- What is the default value for TIMEOUT? (so one can raise or lower it)
- What is the minimum Value for TIMEOUT?
- What is the maximum Value for TIMEOUT?
- [optional] What is the unit for TIMEOUT? (µs, ms, or s or maybe something different)?
Thanks in advance for looking into this and for the tool itself. I really like it.

Timeout is 60 seconds and the unit is seconds, it's a global setting, there is no min/max, just one global value for every attack, when it's surpassed, the attack gets signaled (see timeout.py).
The time out will be global to keep simplicity.
If you want to know more I invite you to read the code.


Too munch Source of acid

The number of acid source per chunck seem to be a little too hight
I mean when i go to mine a big area i found very often a source of acid and always lost all my stuff not the mineral but my mese picaxe ans my mese showel :/
Other idea, don't generate acid in cave or other stuff because the fow go on you maybe 2 minutes after you generate the map.
PS: sorry for my english ... you know... i'm not an english prof ;)

[ ] Divided by 2 the acid sound mapgen spawn

Don't forgot tu update your finished issue @Gael-de-Sailly ;)
(I do it this time)

69e721c


⚠ Samsung has degraded performance

In af187d3, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2584 ms

Resolved: Samsung performance has improved in 6be4775.


Remove restore-keys from GitHub actions cache

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We do not require the restore keys for the cache so we can remove them and default to the key itself.
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #1162 (b92942b) into main (7cd33c2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   48.65%   48.65%
=======================================
  Files          43       43
  Lines        4779     4779
=======================================
  Hits         2325     2325
  Misses       2358     2358
  Partials       96       96


Release Candidate

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #13929 into main will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13929      +/-   ##
==========================================
- Coverage   59.86%   59.84%   -0.03%
==========================================
  Files         693      693
  Lines       38345    38345
  Branches     5514     5514
==========================================
- Hits        22957    22949       -8
- Misses      14208    14213       +5
- Partials     1180     1183       +3

Impacted Files
Coverage Δ

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/common/utils/platform.ts
60.00% <0.00%> (-4.00%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62890c...e3a31c1. Read the comment docs.


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit 746d658:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch 5f35ff8d-4f75-4163-a368-b213732842f8 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


If autodetect elevation is disabled, don't drop the token elevation to 0 if the token is elevated.

Added in v0.9.12.

I see, that's the reason for issue #148 as well.
However this is not solved in v0.9.12. I guess the parantheses are missing after Settings.useAutoMoveDetection in Ruler.js line 161.

I think this is fixed in v0.10.


[AutoPR apimanagement/resource-manager] [Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-01-01

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5824

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3106


iOS - Discussions - Text 'This post is visible to everyone/cohort' is missing in discussion post screen

@aleffert pl review

:+1: