TypeError

Hello
im having the following issue when trying to retrive users of an AD group, i have confirmed the existence of AD groups
activedirectory\lib\activedirectory.js:578
Array.prototype.push.apply(result[rangeAttribute.attributeName], result[rangeAttribute.toString()]);
^
TypeError: CreateListFromArrayLike called on non-object
at C:\server\nodejsProject\node_modules\activedirectory\lib\activedirectory.js:578:26
at Function..each..forEach (C:\server\nodejsProject\node_modules\underscore\underscore.js:186:9)
at ActiveDirectory.parseRangeAttributes (C:\server\nodejsProject\node_modules\activedirectory\lib\activedirectory.js:575:5)
at EventEmitter.onSearchEntry (C:\server\nodejsProject\node_modules\activedirectory\lib\activedirectory.js:421:26)
at emitOne (events.js:116:13)
at EventEmitter.emit (events.js:211:7)
at sendResult (C:\server\nodejsProject\node_modules\ldapjs\lib\client\client.js:1389:22)
at messageCallback (C:\server\nodejsProject\node_modules\ldapjs\lib\client\client.js:1411:14)
at Parser.onMessage (C:\server\nodejsProject\node_modules\ldapjs\lib\client\client.js:1089:14)
at emitOne (events.js:116:13)
at Parser.emit (events.js:211:7)
at Parser.write (C:\server\nodejsProject\node_modules\ldapjs\lib\messages\parser.js:111:8)
at Socket.onData (C:\server\nodejsProject\node_modules\ldapjs\lib\client\client.js:1076:22)
at emitOne (events.js:116:13)
at Socket.emit (events.js:211:7)
at addChunk (_stream_readable.js:263:12)
any idea whats wrong?

I got this error too, but I was able to get a workaround by changing
Array.prototype.push.apply
to
Array.prototype.push.call
BTW I have no idea what was happened. It was working fine until it unexpectedly stop working.

thanks @inkirby  i hope this get pushed

In my case, it would be happened when there is only exactly 1,500 * N + 1 users in a group (like 1,501, 3,001, 4,501).
Because result[rangeAttribute.toString()]  would return a String[], but when there is only one element, it would return String.
Array.prototype.push.apply([], String) would trigger this bug, and Array.prototype.push.call([], String) wouldn't.

I try to change
Array.prototype.push.apply(result[rangeAttribute.attributeName], result[rangeAttribute.toString()]);

to
let array = result[rangeAttribute.attributeName];
let object = result[rangeAttribute.toString()];
if (typeof(object) === 'string') {
    array.push(object);
} else {
    Array.prototype.push.apply(array, object);
}

It works good for me.


Baseball Game

I would like to contribute solution to this problem
https://leetcode.com/problems/baseball-game/
#please assign me this issue##

/assign


[question] Webinterface missing after update

I have update my Zwave2Mqtt from version 3.4.0 to 4.1.1 using these steps
cd /home/homeassistant/
mv Zwave2Mqtt Zwave2Mqtt.old

git clone https://github.com/OpenZWave/Zwave2Mqtt
cd Zwave2Mqtt
npm install
npm run build

cp /home/homeassistant/Zwave2Mqtt.old/store .

npm start

But now i`m missing the static files which seem to be needed for http://<IP_ADDRESS>:8091/ to be working.
/home/homeassistant/Zwave2Mqtt/dist/

@raymonvdm Could you try using https://github.com/zwave-js/zwavejs2mqtt?

@raymonvdm Could you try using https://github.com/zwave-js/zwavejs2mqtt?

@raymonvdm Could you try using https://github.com/zwave-js/zwavejs2mqtt?

What are the difference`s between these?

@raymonvdm Could you try using https://github.com/zwave-js/zwavejs2mqtt?

What are the difference`s between these?

https://zwave-js.github.io/zwavejs2mqtt/#/getting-started/why

https://zwave-js.github.io/zwavejs2mqtt/#/getting-started/why

Not really helping this rookie to understand :-) , but i have cloned the git in a new Zwave2MQTT folder to keep my local wiki relevant and it seems to be working. As i understand this is a new approach of getting Zwave to speak MQTT but with bypassing OpenZwave?
Maybe the approuch helps me to get rid of some strange Z-Wave issues with some devices, for example a not working FireAngel Z-Wave module.

Not really helping this rookie to understand :-) , but i have cloned the git in a new Zwave2MQTT folder to keep my local wiki relevant and it seems to be working. As i understand this is a new approach of getting Zwave to speak MQTT but with bypassing OpenZwave?
Maybe the approuch helps me to get rid of some strange Z-Wave issues with some devices, for example a not working FireAngel Z-Wave module.

@raymonvdm Sorry, the difference is that it doesn't require ozw and we are switching to that for the future

@raymonvdm Sorry, the difference is that it doesn't require ozw and we are switching to that for the future

I understand and i think it is a good way to go.
But now i`m still experiencing some issues

I`m missing the logging to file but i found that i should wait for https://github.com/OpenZWave/Zwave2Mqtt/issues/418
Restart of HomeAssistant leaves me with unavailble devices until i save a setting in the webinterface of ZwaveJS2MQTT
Notify from Fibaro Universal Binary Sensor is not picked on button press and neather is the temp sensor which is connected to it.
Notify from Fibaro FGS221 is working in most case (one unit is failing but might be unit related) so some notify from the endpoints is working

I understand and i think it is a good way to go.
But now i`m still experiencing some issues

I`m missing the logging to file but i found that i should wait for https://github.com/OpenZWave/Zwave2Mqtt/issues/418
Restart of HomeAssistant leaves me with unavailble devices until i save a setting in the webinterface of ZwaveJS2MQTT
Notify from Fibaro Universal Binary Sensor is not picked on button press and neather is the temp sensor which is connected to it.
Notify from Fibaro FGS221 is working in most case (one unit is failing but might be unit related) so some notify from the endpoints is working

@raymonvdm I don't plan to make those changes in this project, the logging has been improved in the last one I mentioned

@raymonvdm I don't plan to make those changes in this project, the logging has been improved in the last one I mentioned

I`m sorry, it is better to respond to the other project with my questions

I`m sorry, it is better to respond to the other project with my questions


False negative Sequel/ConcurrentIndex in some cases. Ignores options passed in hash.

Ignores options passed in an options hash along with gin_trgm_ops relevant with pg_trgm extension.
This way concurrently: true, though provided, is not detected by linter.
Sequel.migration do
  no_transaction

  up do
    DB.execute('CREATE EXTENSION IF NOT EXISTS pg_trgm;')
    alter_table(:foos) do
      opts = {
        name: :foos_bar_search_index,
        type: :gin,
        concurrently: true
      }
      add_index(Sequel.lit(" gin_trgm_ops"), opts)
    end
  end
end

Issue produced with the following version
GIT
  remote: git://github.com/rubocop-hq/rubocop-sequel.git
  revision: 99fc07d33c6dd4a2b38627316764ab2cc7ce750c
  ref: 99fc07d33c6dd4a2b38627316764ab2cc7ce750c
  specs:
    rubocop-sequel (0.1.0)
      rubocop (~> 1.0)

This is affecting our codebase as well. Folks have accidentally used ActiveRecord's algorithm: :concurrently in our codebae and no error was thrown by either rubocop-sequel or sequel.
Example:
Sequel.migration do
  no_transaction
  change do
    alter_table :foo do
      add_index :bar_id                           # ✅ `convention:Sequel/ConcurrentIndex` error thrown
      add_index :baz_id, concurrently: true       # ✅ No error thrown
      add_index :qux_id, algorithm: :concurrently # ❌ No error thrown
    end
  end
end

We should have better typing / linting for the options passed into the migration method


add language aliases to :LspInstall

Resolves #177.

One minor feedback: When there is only one option for the given language name, a popup window for vim.notify will appear (if using nvim-notify) but this will be hidden by the main LspInstall floating window.
The server "clangd" was automatically chosen for "c++" as no other options exist

One minor feedback: When there is only one option for the given language name, a popup window for vim.notify will appear (if using nvim-notify) but this will be hidden by the main LspInstall floating window. This might be z-index issues but would be good to improve nevertheless.

:+1: Changed to a simple message instead


Email sal

@xmonader can you please make sure you follow pep8 rules. for spacing and new lines.
You can set your editor to do the pep8 validation automatically. after that we can merge.

to which story or task does this pull request relate too?
please put link


issue fixed #1306 | Easy Issue 2 (C++)

Pull Request Type
What kind of change does this PR introduce?

Solved an issue/task

What is the current behavior?

Issue Number: https://github.com/fork-commit-merge/fork-commit-merge/issues/1306
What is the new behavior?

C++ program that will return the sum of two numbers to the console.

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Support for SVN ?

Is there a timeline when vscode will have support for svn ?
I use git with my open source projects, however at my company we use svn.
Thank you,
Ryan

The issue tracking that is here https://github.com/Microsoft/vscode/issues/206


Prettier applied to page-query static-query

Hi, I'm a big fan of Gridsome.
Prettier has parser 'graphql'.
page-query and static-query is GraphQL syntax.
So I want to format code in page-query and static-query block.

I see you are working on eslint rules for page-query :) Is it possible to test it locally somehow?

Thanks for the reply!!!
Please give me a moment. I'm almost ready to use my rule for gridsome😊

Awesome! Just tested it and it works very well! I really like this plugin and it could be the official ESlint plugin for Gridsome. So you can consider if you want to maintain the repository under the Gridsome organization instead :)

@hjvedvik
I’m glad to hear that😊
I made this ESlint plugin for Gridsome.
Could you transfer this package to gridsome official GitHub repository.
I wanna use yarn add @gridsome/eslint-plugin-gridsome😏

@hjvedvik
Please reply 😅👋

Hi 😅 Yes, we can move it to this organization. I'll accept and give you the necessary permissions if you transfer the ownership to gridsome :)

I haven't done this much myself, but I think you can follow this guide.

@hjvedvik
Um...
I tryed transfer follow the guide.
The following error message appears.

You don’t have the permission to create repositories on gridsome

Do I need to participate in the Gridsome organization?

I'll just create a new empty repository and give you access. You should then be able to push all your commits to that repository.

@hjvedvik
The following error message appears.😂

gridsome/eslint-plugin-gridsome already exists and You don’t have the permission to create repositories on gridsome

I've sent you an invite to the repository :) Accept it, edit your remote git address and push to that repository instead. I think that will work.

@hjvedvik
thanks.
I succeeded !! XD
https://github.com/gridsome/eslint-plugin-gridsome

@hjvedvik
How do I setup of Travis CI?
eslint-plugin-gridsome was deployed by Travis CI :(

@hjvedvik
When I had worked in tyankatsu0105/eslint-plugin-gridsome,
eslint-plugin-gridsome was deployed by Travis CI.
Now this npm package is don't deploy by my Travis CI account.
If you invite me to Gridsome organization,I may be able to setup Travis.
Or could you setup Travis CI?

@hjvedvik
I'm sorry, I misunderstood. :(
Please permission level admin of gridsome/eslint-plugin-gridsome for me.
https://help.github.com/articles/adding-outside-collaborators-to-repositories-in-your-organization/

Will you then be able to set up Travis CI again for that repo if you're an admin? I have added my email and a token in Travis. But You might have to add me as collaborators for the package on npm. Not sure how it works :)

Now I add you to npm owner.
https://www.npmjs.com/package/eslint-plugin-gridsome
I suppose Travis is work.
I'm try.

@hjvedvik
Yeah!!!
Thank you for all your help!!
Let's keep in touch :)


Support minikube --addons & --extra-config (dup)

Enable addons flag when setting up minikube
Upgraded actions/checkout

Added extra options commit from #33

is there anything blocking the merging of this PR?

bushwhackr thanks for this PR and sorry for the delay in the review


Just show file name in winbar

Is there a way to just show the file name in the winbar without the breadcrumbs at all?

symbol_in_winbar.folder_level = 0

@glepnir this only disables the folders. I meant to disable the other scopes as well...

only file name ?

disalbe lspsaga winbar then vim.opt.winbar='%f' should work

@glepnir oh I see... makes sense. thanks!


Patterns for structs with single unnamed field

For the following struct,
struct Thing(T);

I would like to restrict T using some of the options available for structs with named fields, such as restricting a String to a pattern, or a numerical type to a minimum and maximum. Is there a way to specify this using the #[schema(...)] macro?

In theory it could be possible for primitive types like str, String, i32 etc. But not for $ref types (Types that are a reference to another ToSchema type). Thus its is not implemented and supported at the moment.
Thing is that the validation rules are to be added on schema properties yet struct Thing(T) is not a struct with fields but will render a schema for T within the Thing struct. When T is a String it will render the schema for the String and validation rules are not exactly placed on a type but alongside of a type on a property. But unnamed field structs do not have properties.
This is something that could be explored in future but at the moment the priority for the support is not very high.

In theory it could be possible for primitive types like str, String, i32 etc.

FWIW that happens to be my use case, but I can understand the priority being low.
If I can follow up, though: in point of fact I am annotating it this way:
#[derive(ToSchema)]
#[schema(example = "mymommatoldme", value_type = String)]
struct Thing(T);
// a function exists to convert String to Thing(T)

Would some workaround like this allow me to define a pattern? I thought about defining a new type, but I couldn't work out anything specific, because patterns apply only to fields.

A lot of people use nutypes on primitives. Moreover, since the fields pattern, min, max, ... exist on named structures, wouldn't it be nice to add this feature to unnamed structures?

Such functionality could be evaluated in future.

Duplicate https://github.com/juhaku/utoipa/issues/1150


Error running notebook "RaySystemError: System error: buffer source array is read-only"

Describe the bug
I'm trying to run the example notebooks (in codeflare/notebooks), and came across this error. The error persisted thru attempts to restart my kernel, entire machine, and re-cloning the repo. Any help, or an explanation of the root cause, is much appreciated!
To Reproduce
Steps to reproduce the behavior:

Go to notebooks/plot_nca_classification.ipynb
Run 2nd code block. It uses Ray and Codeflare.
This line produces the error knn_pipeline = rt.select_pipeline(pipeline_fitted, pipeline_fitted.get_xyrefs(node_knn)[0])
See error: RaySystemError: System error: buffer source array is read-only

Full stack trace:
RaySystemError: System error: buffer source array is read-only
traceback: Traceback (most recent call last):
  File "/home/kastan/.pyenv/versions/3.8.6/lib/python3.8/site-packages/ray/serialization.py", line 268, in deserialize_objects
    obj = self._deserialize_object(data, metadata, object_ref)
  File "/home/kastan/.pyenv/versions/3.8.6/lib/python3.8/site-packages/ray/serialization.py", line 191, in _deserialize_object
    return self._deserialize_msgpack_data(data, metadata_fields)
  File "/home/kastan/.pyenv/versions/3.8.6/lib/python3.8/site-packages/ray/serialization.py", line 169, in _deserialize_msgpack_data
    python_objects = self._deserialize_pickle5_data(pickle5_data)
  File "/home/kastan/.pyenv/versions/3.8.6/lib/python3.8/site-packages/ray/serialization.py", line 157, in _deserialize_pickle5_data
    obj = pickle.loads(in_band, buffers=buffers)
  File "sklearn/neighbors/_dist_metrics.pyx", line 223, in sklearn.neighbors._dist_metrics.DistanceMetric.__setstate__
  File "stringsource", line 658, in View.MemoryView.memoryview_cwrapper
  File "stringsource", line 349, in View.MemoryView.memoryview.__cinit__
ValueError: buffer source array is read-only

---------------------------------------------------------------------------
RaySystemError                            Traceback (most recent call last)
/tmp/ipykernel_1251/3313313255.py in <module>
      9 test_input.add_xy_arg(node_scalar, dm.Xy(X_test, y_test))
     10
---> 11 knn_pipeline = rt.select_pipeline(pipeline_fitted, pipeline_fitted.get_xyrefs(node_knn)[0])
     12 knn_score = ray.get(rt.execute_pipeline(knn_pipeline, ExecutionType.SCORE, test_input)
     13                     .get_xyrefs(node_knn)[0].get_yref())

~/.pyenv/versions/3.8.6/lib/python3.8/site-packages/codeflare/pipelines/Runtime.py in select_pipeline(pipeline_output, chosen_xyref)
    381         curr_xyref = xyref_queue.get()
    382         curr_node_state_ptr = curr_xyref.get_curr_node_state_ref()
--> 383         curr_node = ray.get(curr_node_state_ptr)
    384         prev_xyrefs = curr_xyref.get_prev_xyrefs()
    385

~/.pyenv/versions/3.8.6/lib/python3.8/site-packages/ray/_private/client_mode_hook.py in wrapper(*args, **kwargs)
     87             if func.__name__ != "init" or is_client_mode_enabled_by_default:
     88                 return getattr(ray, func.__name__)(*args, **kwargs)
---> 89         return func(*args, **kwargs)
     90
     91     return wrapper

~/.pyenv/versions/3.8.6/lib/python3.8/site-packages/ray/worker.py in get(object_refs, timeout)
   1621                     raise value.as_instanceof_cause()
   1622                 else:
-> 1623                     raise value
   1624
   1625         if is_individual_id:

Expected behavior
Expected is selecting the pipeline and evaluating its score via a 'SCORE' pipeline.
Desktop

OS: Ubuntu 20.04 via WSL2 on Windows.
Python 3.8.6

Thank you for any help! I am a University of Illinois at Urbana-Champaign grad student trying to make the most of your work!

Hi @yuanchi2807, thank you for the detailed investigation with interesting results. I have no dependency to sklearn 1.0, so I will downgrade as you suggest.


Release as Python 3 source wheel on PyPI?

It seems one could install pycrs on Pyodide and hence JupyterLite using micropip if it would have a source wheel package on PyPI. Maybe worth a thought?

Currently, the pycrs package on PyPI (https://pypi.org/project/pycrs/#files) does not have a wheel. It would be great to add it so that it can support JupyterLite. Otherwise, all downstream packages of pycrs can't support JupyterLite. The wheel can be built using the instructions here.
https://github.com/giswqs/leafmap/issues/55#issuecomment-1325651699

I have built the gdown wheel here. It worked fine.


Indexer option to control ClassInfo sorting

SmallRye's OpenAPI implementation uses Jandex. Not only for annotation processing but also to get general reflective class info. Unfortunately object fields are sorted by Jandex: https://github.com/wildfly/jandex/blob/61d1115e0a0f15dcfb2b0bbd082100f847963529/src/main/java/org/jboss/jandex/ClassInfo.java#L557
This ultimately alters the field order of all objects appearing in the openapi file, though in most cases declaration order is desired.
It would therefore be great to have an Indexer option to configure ClassInfo's field sorting behavior. Maybe for completeness also for methods.
Thanks!

@n1hility any update about this topic? If it's out of scope (even though a simple flag :smirk:) it would be nice to know. In that case the linked issue will be more complex to fix, but at least we have clarity about it.

@neon-dev , can you please clarify what do you mean by "declaration order"?
Java specification has no guarantees that the fields and methods will appear in exactly the same order in the bytecode.
Then, Class#getMethods has the following javadoc:

The elements in the returned array are not sorted and are not in any particular order.

Sorting entries might help build reproducibility (see https://reproducible-builds.org/ ).
Then "storing original method positions" would make "index merging" slightly harder.

@neon-dev , can you please clarify what do you mean by "declaration order"?
Java specification has no guarantees that the fields and methods will appear in exactly the same order in the bytecode.
Then, Class#getMethods has the following javadoc:

The elements in the returned array are not sorted and are not in any particular order.

Sorting entries might help build reproducibility (see https://reproducible-builds.org/ ).
Then "storing original method positions" would make "index merging" slightly harder.

@vlsi correct, but in practice I've not yet seen the compiler shift methods and fields around. So it'd be great to have a way to tell Jandex to retain the original/input order, even if it may not be consistent over different bytecode versions. Meaning whatever getDeclaredMethods and getDeclaredFields returns, take it as is.

@vlsi correct, but in practice I've not yet seen the compiler shift methods and fields around. So it'd be great to have a way to tell Jandex to retain the original/input order, even if it may not be consistent over different bytecode versions. Meaning whatever getDeclaredMethods and getDeclaredFields returns, take it as is.


Package request: cameractrls

(I might get around to contributing this as a PR myself, but I'm opening for tracking purposes)
Project description
From the readme:

Camera controls for Linux
It's a standalone Python CLI and GUI (GTK3, GTK4, TK) and camera Viewer (SDL) to set the camera controls in Linux. It can set the V4L2 controls and it is extendable with the non standard controls. Currently it has a Logitech extension (LED mode, LED frequency, BRIO FoV, Relative Pan/Tilt, PTZ presets), Kiyo Pro extension (HDR, HDR mode, FoV, AF mode, Save), Systemd extension (Save and restore controls with Systemd path+service).

Metadata

homepage URL: None / same as source URL
source URL: https://github.com/soyersoyer/cameractrls
license: MIT
platforms: Linux

Add a :+1: reaction to issues you find important.

Whoops. Duplicate of https://github.com/NixOS/nixpkgs/issues/230167


Using CS#5 features to not break CI build

Adding language version to use C# 5 features.

@EMaher

Sorry. I did this on the wrong branch.


The example project gets stuck after a few times of data transmission test.

For iperf and echo test, after several times of runs, no response comes from VCU118. But it looks like “ping <IP_ADDRESS>” still gets feedback.

What is your setup?
How many times before the TCP gets stuck?
Are you using the same connection or opening new ones?

The test is between the VCU118 and MCX516A-CCAT.
For echo project, it will work for hundreds of times  (with python echo client).  ILA are added to monitor the bus m_TxPayload and s_RxRequestedData between echo_server_applicat and toe, no data is transmitted once it got stuck.
For iperf, looks like it will get stuck after one run. The same port is used. However if the first run is not finished yet, connections can still be open with different ports. Once it is finished, any port will not work.

Looks like an issue when the connection get closed, either because of a timeout or because of the FIN flag. I need to investigate, but I do not know when I can do it, I have very little time to debug.
Do you mind trying the ETH Zurich version, https://github.com/fpgasystems/fpga-network-stack?
They are actively working on it

I have fixed the problem. I am running further tests to confirm. I will update the results once everything looks ok.

@krvishal1 I appreciate if you can do a PR when you finish with the test.

Great. I will give a try once the change is committed.

Dear @krvishal1 ,
I am experiencing the same problem as the original question with the latest master branch.
If your tests are done, can you commit the fix, or can you share the problem that the project was suffering?

I have fixed the problem. I am running further tests to confirm. I will update the results once everything looks ok.

@krvishal1 I encountered this problem, IPERF will get stuck after the first test. could you share us how you solve this problem? I am also debugging, but unlucky there is no progress.


Fix the S3 form to allow the user to enter a custom region

Closes #2379.
Currently we say "Region (optional)", but it's actually required. The validation never fails, because we always compute the region. However, we always override the region from URL, which is too intrusive, I think showing a placeholder is a sane approach.
https://github.com/livebook-dev/livebook/assets/17034772/a39596e3-2adb-4c05-9259-b6312f2bf114

Should we have it as a default, if empty, instead of a placeholder? Or do you mean we show the placeholder and still compute the default?

With this approach they need to type it manually, we just make our best suggesting the value with a placeholder.
Setting automatically is also fine. A public function that takes the changeset and sets the region if empty, and we use it only on submit?

Yeah, that sounds good. We either set it directly in the form if none or we set it in the changeset later. Your call.

We don't want to set it on the form, because then it's going to be submitted on validate and if they are in the process of typing the URL, we would always take the first guess. I went with the changeset route, and added "(optional)" back to the label :)


[docs] Fix typo issue at Foundation_Build_Process.md

Fix typo issue at Foundation_Build_Process.md

@swift-ci please test


Fix LineLength violations in extensions

Is there a reasonable way to (probably will need a new story) to get rid of all the calls to html_safe?
E.g., could we somehow use sanitize?

I have reviewed this to remove extra spaces which caused LineLength to be > 80.

Is there a reasonable way to (probably will need a new story) to get rid of all the calls to html_safe?
E.g., could we somehow use sanitize?

That would be awesome.  Haven't dug into this stuff recently enough to be sure though.

Thanks for the continued work on this.  It's looking great!  I had one last comment for you to consider, then I think it can be merged.


Duplicate - Available Sources - Mangadex appears twice.

Describe the bug
Mangadex appears twice when looking in the "Available Sources" drop down when adding a manga per screenshot.

Reproduction steps
1.Select add new manga
2. Select the Available Sources
3. See duplicate entries
Expected behavior
Only see one name per source.
Additional context
No response

The first one is from mangal. The second is the one that I wrote. They work differently. But I will delete the one I wrote in the future.

Fair, reducing the workload on yourself by letting the Sources by from mangal makes sense. no point doubling up.


AWS detailed guardrails review by CP team

Describe the issue
Review of the work done in #213 by PO.
Which Sprint Priority is this issue related to?
The 'Milestone' should clearly list Sprint Priorities - which one is this issue related to?
Additional context
Summary done against multiple AWS sources for best practices against Cloud Security Schedule (CSS)
Definition of done

Review by PO

met with julian on Oct 14th
Request was to update to include columns:  1.) reference to GC controls 2.) shared responsibility owners (CSP/BC Gov Operations ( including ISB support), BC Gov ministry teams)

edits will be hosted on teams, forked work for higher level comparison for ISB.


Link to Microsoft.UI.Composition.Compositor. is broken

When clicking on the Microsoft.UI.Composition.Compositor link, this is the result.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 724827cf-15a5-d5d6-5679-b4712d2c03ee
Version Independent ID: cc05a8ff-4afb-bf61-fb81-fe02bf1bb7a0
Content: Compositor Class (Windows.UI.Composition) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.Composition/Compositor.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Thanks. This issue appears to be resolved.


OpenTelemetry Instrumentation with .AddAspNetCoreInstrumentation() covering all FastEndpoints cases?

https://opentelemetry.io/docs/instrumentation/net/manual/
specifically
builder.Services.AddOpenTelemetry()
  .WithTracing(b =>
  {
      b
      .AddSource(serviceName)
      .ConfigureResource(resource =>
          resource.AddService(
            serviceName: serviceName,
            serviceVersion: serviceVersion))
      .AddAspNetCoreInstrumentation()
      .AddConsoleExporter();
  });

Question is does AddAspNetCoreInstrumentation() cover all bases for FastEndpoints too, or eg might it be useful to mark running an endpoint specifically, or some other "added value" for FastEndpoints that is not in that "general" ASP.NET tracing instrumentation?

haven't tried it myself but theoretically it should as fastendpoints is doing those minimal api endpoint registrations such as app.MapGet(...) internally.
if .AddAspNetCoreInstrumentation() doesn't seem to work for you, please provide a minimalistic repro project we can debug and get to the bottom of why it's not detecting the minimal api endpoints mapped by fastendpoints. i don't see a reason why it shouldn't.
if anybody seeing this who's already using open-telemetry with FE, please chip in.
cheers!


Integrate with batch job backend

Proposed changes
Integrate with the batch job backend. Adds a (rushed) loading screen while files are being uploaded.
https://user-images.githubusercontent.com/53201250/131969717-b8376342-0c12-4b79-976e-29e189029481.mov
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] DevOps related

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the project guidelines doc
[x] I locally linted my code
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments

@Akshith-Patil Yeah not something I was able to fix in time unfortunately, I'll create a card to fix it


Select instrument per instrument not voice?

Hi, I'm not sure this title is right, haha... I'm bad at English

in this example above, first staff is for vocal and second, third staves are for piano part
and I don't think there are many people who need to change the piano part (second and the third) seperately.
because it was originally designated as one instrument (by writer)
So I think it's better to show select option per instrument, not voice
I came up with this idea, because of some writer's sheet gets more voices than staves in one instrument (for no reason),
and It doesn't look good.

I'm trying to do this myself but it's difficult for me
If you update this, it will be of great help
Thanks :)

Sorry for the late reply!
It's a good topic you're bringing up here. And I agree that in the example you posted it would really make sense to control playback per instrument and not per voice.
The reason to why I am currently not defaulting to that behavior (I actually tried that first) is because it can differ quite much how the instruments are specified in the Music XML. For example I had some coral pieces where piano was set as instrument for all for voices. Although it was set for a standard 4 voice SATB.
Which lead to the decision to make it per voice. But, I think a much a more sensible choice would be to default to selecting the playback instrument per "instrument". But offering individual control for all voices as an additional option.
The progress has been quite slow here lately, but I'd still like to address the previous issues you and some other persons have reported, as well as adjusting this. So I'll hopefully be able to look into it soon :slightly_smiling_face:  PR's are also welcome

Thank you for consideration, I'm looking forward to it!


Get Pulsar Chart Started

I'll be working in this pull request for the remainder of the hackathon.

xref: https://github.com/galaxyproject/galaxy/issues/6426

@dfornika Thanks for the PR! I've updated this issue to track additional todos: https://github.com/galaxyproject/galaxy/issues/6426. Feel free to edit.


Rename tests to avoid confusions

Please provide a description for what this PR is for: with the istiod related changes in Istio 1.5, rename tests to avoid confusions.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X ] Security
[X ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
a4d3955b793809ba00a10bf06a31c205c8cb2f00
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Please also cherrypick it to 1.5, thanks.

/cherrypick release-1.5

@myidpt: new pull request created: #21693

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Add Admin Space

Add admin space wherte you would configure data sources that woul would have to browse.
Make sure this admin space would also allow you to setyup auth and other configurations for the app

Is the idea here for those running their own instance of IQEngine, there is a way for the admin to go in and edit which blob storage accounts/containers are available on the home page?  And for auth and other configurations you are envisioning, do you think there's a way to leverage what Azure already offers (e.g. through portal or CLI) to reduce the complexity within IQEngine itself?  Thanks for the help!!

Excatly the idea it is that some of the functionallity that is corrent available as configuration in the environment variables can be done through an admin interface. These configurations would probably be stored in a dataabse that would them hadve its connection string setup as an environment variable.


Updated project requirements

Some of these were necessary for proper Django 4.2 support. Replaced linters with ruff and updated the pre-commit configuration to match upstream Wagtail for consistency.
bakerydemo does not appear to have its own test suite, but so far it appears to run correctly ;)

Just fired off the CI - it's failing so may need some tweaks.
Thanks for this @jsma - it will be nice to use the same linting tooling as Wagtail.

Apologies for missing that, I brought the Makefile in line with upstream for the relevant sections. 🤞it passes this time. Thanks!

This looks to be working now, and should address #421

Let me know your thoughts but perhaps #463 should be merged first and then I can rebase off of that to straighten out pre-commit-config.yaml. I also have WIP to introduce ruff format to match https://github.com/wagtail/wagtail/pull/11220 This PR intentionally kept ruff at the version currently used by Wagtail until my upstream PR is approved. If the upstream PR gets merged before this one, I could lump the ruff upgrade into this branch or just submit a follow up PR.

Good call @jsma  - I did not realise there would be a large overlap with #463 but if this one does get merged first, I am happy to rebase.

Merged locally as I’m not allowed to push to this fork


Refactor

Codecov Report

Merging #857 (55aacd3) into main (ae735ad) will increase coverage by 0.00%.
The diff coverage is 73.91%.

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   81.77%   81.77%
=======================================
  Files         363      363
  Lines       34150    34146    -4
=======================================
- Hits        27925    27923    -2
+ Misses       6225     6223    -2

Impacted Files
Coverage Δ

lib/ast-hir/src/module_compiler.rs
38.79% <0.00%> (ø)

lib/hir/src/analysis/try_operation_validator.rs
84.43% <0.00%> (ø)

lib/hir/src/analysis/type_transformer.rs
39.33% <0.00%> (ø)

lib/hir/src/analysis/variable_transformer.rs
49.64% <0.00%> (ø)

lib/ast/src/ast/if_list.rs
50.00% <50.00%> (ø)

.../hir-mir/src/transformation/if_list_transformer.rs
100.00% <100.00%> (ø)

lib/hir/src/analysis/expression_visitor.rs
74.76% <100.00%> (ø)

lib/hir/src/analysis/type_checker.rs
99.17% <100.00%> (+0.03%)
:arrow_up:

lib/hir/src/analysis/type_coercer.rs
95.13% <100.00%> (+0.05%)
:arrow_up:

lib/hir/src/analysis/type_extractor.rs
96.24% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae735ad...55aacd3. Read the comment docs.


Implement no_std Support

No std specific features are used, so this is a trivial change.

Optimally this should be verified on CI as well via cargo build --target thumbv6m-none-eabi.


enhancement: input_format_skip_unknown_fields default to true for external streams

PR checklist:

Did you run ClangFormat ?
Did you separate headers to a different section in existing community code base ?
Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
Closes #549 .

(Jove Github Bot) added it to the current sprint.

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).


bytecode to assembly

this seems like a nice idea!

https://github.com/abooishaaq/sahl/commit/d0ac58c7277890d28b355235f611cf52707f1106 compiles adding two constants and printing them.

instead doing ast to assembly


Add Crittercism support

This is not possible unless I add the INTERNET permission, and I think people will hate me if I do that.  So I'm going to avoid it for now.


Chrome tab not closing properly when using Nodemon

I have an issue where restarting my server through Nodemon does not close the tab, but instead renders this error message:

After looking through the source code I think I've isolated the problem to here. The catch for the HTTP request does not consider a valid case where the debug server is not down, but the ID of the debugger websocket changes.
A proposed solution would be to store the unique identifier for each devtools session, and check if that identifier is in the returned JSON from the localhost debug server. Requests coulda also be minimized by making the request only once and filtering $scope.devToolsSessions according to the returned identifiers.
I'd be willing to PR this in the next couple days with your OK @june07
Edit: Initial conversation about this issue can be found here.

First of all, good work on the detail provided thus far.  Thank you.  Can
you tell me more about your dev environment, including Node version.  I'm
trying to understand "where the debug server is not down, but the ID of the
debugger websocket changes."  I havent seen this behavior?  Why/how is the
websocket changing without a restart of the debugger/node process?
On Dec 18, 2016 1:06 AM, "Edward Bramanti"<EMAIL_ADDRESS>wrote:

I have an issue where restarting my server through Nodemon does not close
the tab, but instead renders this error message:
[image: screenshot 2016-12-17 21 19 28]
https://cloud.githubusercontent.com/assets/1921464/21292539/c9f6403a-c4bd-11e6-9ca8-5103d0c02992.png
After looking through the source code I think I've isolated the problem to
here https://github.com/june07/NIM/blob/master/background.js#L88-L113.
The catch for the HTTP request does not consider a valid case where the
debug server is not down, but the ID of the debugger websocket changes.
A proposed solution would be to store the unique identifier for each
devtools session, and check if that identifier is in the returned JSON from
the localhost debug server. Requests coulda lso be minimized by making the
request only once and filtering $scope.devToolsSessions according to the
returned identifiers.
I'd be willing to PR this in the next couple days with your OK @june07
https://github.com/june07
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/june07/NIM/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AK099m5GSM2DSR_A__-aTWXJvJSbCrfRks5rJPeegaJpZM4LQFWn
.

@june07 Dev environment is Node 6.9.1, I'm using [fly] and [fly-nodemon] to run Nodemon, and I pass inspect in as a nodeArgs option to Nodemon. Since the Fly process continues running the server hosting the websockets comes back up before the 3000ms check, I think that could be why your code is not detecting a change.
It might be easier if I show you in code... I have a PR ready that shows the solution I have in mind.

Edward,
Nice.  That's it!  I've merged the PR.
On Dec 18, 2016 3:37 PM, "Edward Bramanti"<EMAIL_ADDRESS>wrote:

@june07 https://github.com/june07 Dev environment is Node 6.9.1, I'm
using [fly] and [fly-nodemon] to run Nodemon, and I pass inspect in as a
nodeArgs option to Nodemon. Since the Fly process continues running the
server hosting the websockets comes back up before the 3000ms check, I
think that could be why your code is not detecting a change.
It might be easier if I show you in code... I have a PR ready that shows
the solution I have in mind.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/june07/NIM/issues/1#issuecomment-267855723, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AK099pS8eoW2Po0EJ-fFBQB_gyPFINrwks5rJcPAgaJpZM4LQFWn
.

Thanks @june07, let me know when you update this on the Chrome Web Store.

I'm having the same issue, is the new update pushed?
When i start my server, i have to goto the url manually, and when nodemon restarts from change, I just get the error.

The current version is 0.9.0.  Do you have the setting on manual or auto?
Also how is the auto close setting configured?
On Dec 25, 2016 10:57 PM, "Darryl Dexter"<EMAIL_ADDRESS>wrote:
I'm having the same issue, is the new update pushed?
When i start my server, i have to goto the url manually, and when nodemon
restarts from change, I just get the error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/june07/NIM/issues/1#issuecomment-269173050, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AK099rgHCApOmO1DskIiSAsETOlILt-Wks5rL2VdgaJpZM4LQFWn
.

Sorry, commented before I worked it out. Needed to update chrome apparently... Thx, awesome plugin!

No worries.  Glad to help.  And thank you for the positive feedback!  If
it's not too much trouble, a review and/or rating at the Web Store would
help out greatly.
On Dec 25, 2016 11:31 PM, "Darryl Dexter"<EMAIL_ADDRESS>wrote:
Sorry, commented before I worked it out. Needed to update chrome
apparently... Thx, awesome plugin!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/june07/NIM/issues/1#issuecomment-269176827, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AK099lT6OEK2n48hjRPQEp_l-l9uecPcks5rL21WgaJpZM4LQFWn
.

macOS sierra 10.12.2 . chrome  55.0.2883.95 (64-bit)
had the same problem

Are you using the current version?  Any additional information you can provide will be helpful in figuring out what is going on.  I'm sure you have already but in case not, please read through the entire thread as some information may be helpful.

it works now . thanks.
maybe my setting is not right !


Random level generation with ECS

Hey
I've met interesting problem with random levels.
Imagine you need to make a game like this

Which is an endless runner with heavy use of physics. You will need to somehow randomize level.
I see 2 routes to go:

Create a bunch of predefined chunks as prefabs and randomize how they are instanced one after another

Full randomization, everything (platform, coin, forcefield...) is separated element and is placed by an algorithm

And there a points to think about:

Customization

In first case designers can edit chunks however they want, place background elements, etc PLUS

In second case there is no ability for a designer to do it  MINUS

Linking to ECS

In first case there a few options

Create chunk entity -> chunk view instantiated ->interactive chunk child views (platforms, coins...) emit entities for themselves

We have configuration with positions and types of interactive elements. At start chunk views are instantiated and their interactive children are removed and chunk view are sent to pool, every interactive chunk element view is also pooled.
So we create chunk entity and a bunch of preconfigurated interactive entities -> views are pulled from pools for them.

(Also hardly customizable) Whole chunk configuration is just a JSON (not a prefab) and everything is set up in some editor tool. Then we create all entities from configuration with positions -> views are loaded for basic elements (platform, coin, forcefield...)

In second case there is nothing hard, we just emit entities when required like {Platform}{PlatformType}{Position}{Rotation}{Scale} or {Coin}{Position} and views are created without any workarounds

I implemented this Create chunk entity -> chunk view instantiated ->interactive chunk child views (platforms, coins...) emit entities for themselves
And after I wrote it down I will switch to full randomization, as it's way better organized from my point of view.
Do you have any suggestion how you would solve it?

Rather than having a "chunk entity" as you describe and load a prefab which have many children, I would see the simulation as a grid (where the camera is pointing at a slice of it), to me it only makes sense to create a chunk entity if you want to query or identify chunks. Otherwise you can create a bunch of classes like, class MapEntity(int type, int x, int y), class Map (MapEntity[] entities) into somekind of MapTemplateComponent with another component like an id/string you can index. then create entities out of that adding in the offset where you need it now. with that you can create an in-game map editor or just convert a unity scene into a map template file and then load them. you could then do something like core.GetMapTemplateWithName("theme_snow_chunk_1")

@T2RKUS
That's looks like the thing i described
(Also hardly customizable) Whole chunk configuration is just a JSON (not a prefab) and everything is set up in some editor tool. Then we create all entities from configuration with positions -> views are loaded for basic elements (platform, coin, forcefield...)
When I started doing that project that approach was first which came to me, but it would be more time consuming to do than the solution I choosed.
I have chunk editor, which has a collection of chunk names (resources path), their parsed widths and 3d preview now.
But it was created to be a full chunk editor, where I can place elements and then just load them all from a config. Probably I will make it that way, as full random is hard to make interesting

I noticed that now... I'll admit I skimmed it and ended up practically repeating one/more of your points. However, given the same problem that is how I would do it. not sure I'd make an editor of yours though since you can just create a new scene; place a bunch of objects from origin including the a player object to test the chunk (these objects could potentially create emit themselves as entities when you hit play - would need some setup though) and then click a menu item to save the scene as a chunk with/without the player.
Unity is already a level editor and chunk viewer so I'm not sure what the advantage of your tool is other than validating whether your chunk exported successfully, but then you could just load up the chunk in-game anyway?


removing parentheses

Removing parentheses from post.html, causing Liquid rendering error, see #141

Thanks for the PR @doka


[release-4.7] Handle failed InstallPlans in metering test installations

Cherry-pick of all of the e2e and deploy package changes needed to fix how we handle failed InstallPlan custom resources in the various metering test installations we created.

/lgtm

/verify-owners

Manually adding the group-lead-approved label as this only affects testing code.


The model gpt-3.5-turbo-0613 has been deprecated

error message:

The model gpt-3.5-turbo-0613 has been deprecated, learn more here: https://platform.openai.com/docs/deprecations

I will create pull request by using gpt-4o, and read the model_name from config file.

I fixed and created a pull request: https://github.com/neo4j/NaLLM/pull/91


cmd/go: inconsistent coverage when using -coverprofile with packages without tests

Go version
go version go1.23.3 linux/amd64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='local'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23.3'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/root/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2962845657=/tmp/go-build -gno-record-gcc-switches'

What did you do?
Given the following project, with pkg1 not containing any test, and pkg2 with 1 test that is calling pkg1, when using go test with the -coverprofile option, the cover file generated contains pkg1 as covered
$->> cov $ tree
.
├── go.mod
├── pkg1
│   └── file.go
└── pkg2
    ├── file.go
    └── file_test.go

3 directories, 4 files
$->> cov $ cat go.mod
module cov
$->> cov $ cat pkg1/file.go
package pkg1

func DoSomething() bool {
    return true;
}
$->> cov $ cat pkg2/file.go
package pkg2

func DoSomething() bool {
    return true;
}
$->> cov $ cat pkg2/file_test.go
package pkg2

import "testing"
import "cov/pkg1"

func TestSmth(t * testing.T) {
  pkg1.DoSomething()
  DoSomething()
}

What did you see happen?
Running go test with -coverprofile the output correctly shows 0% coverage on the package without tests, but the generated file info is marking pkg1 as covered
$->> cov $ docker run --rm -it -v .:/code -w /code golang:1.23.3 go test ./... -coverprofile cov.out
	cov/pkg1		coverage: 0.0% of statements
ok  	cov/pkg2	0.003s	coverage: 100.0% of statements
$->> cov $ cat cov.out
mode: set
cov/pkg1/file.go:3.25,5.2 1 0
cov/pkg1/file.go:3.25,5.2 1 1
cov/pkg2/file.go:3.25,5.2 1 1

What did you expect to see?
pkg1 should not be marked as covered in the cover file, as it does not have any test and I'm not using other params such as -coverpkg.
using GOEXPERIMENT=nocoverageredesign is currently a workaround we are using, but would stop being an option after: https://github.com/golang/go/issues/55953.
Another workaround would be to generate empty test files on all packages, but as far as I can tell, this shouldn't be the expected behavior.
$->> cov $ echo "package pkg1" >> pkg1/file_test.go
$->> cov $ docker run --rm -it -v .:/code -w /code golang:1.23.3 go test ./... -coverprofile cov.out
ok  	cov/pkg1	0.003s	coverage: 0.0% of statements [no tests to run]
ok  	cov/pkg2	0.003s	coverage: 100.0% of statements
$->> cov $ cat cov.out
mode: set
cov/pkg1/file.go:3.25,5.2 1 0
cov/pkg2/file.go:3.25,5.2 1 1

Related Issues and Documentation

cmd/go: should include packages without tests in cover profile file #27261 (closed)
cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument #65653 (closed)
Unintuitive behavior when using -coverpkg #23786 (closed)
Coverage incorrectly reported as 100% ( go test cover) #26760 (closed)
cmd/go: go test -cover & go test -coverprofile should always output a coverage #24570 (closed)
cmd/go: -coverpkg=all gives different coverage value when run on a package list vs ./... #23883 (closed)
cmd/cover: regression in 1.20, cover tool no longer includes packages without tests #58770 (closed)
cmd/go: coverpkg doesn't ignore directories starting with '.' #66038
cmd/go: improperly synchronized -coverprofile output for packages with no tests #63356 (closed)
cmd/covdata: percent does not support -coverpkg #66464

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@thanm we still list you as owner, maybe you still have background on this?
otherwise, @golang/compiler

Hi @NarcisDavins you wrote:

pkg1 should not be marked as covered in the cover file, as it does not have any test and I'm not using other params such as -coverpkg.

I'm confused about what you're asking here. In the contents of cov.out there is this line:
cov/pkg1/file.go:3.25,5.2 1 0

That indicates that package pkg1 has 1 statement and that it is not covered. When you say "marked as covered" do you mean that pkg should not be mentioned at all?

Hi @NarcisDavins you wrote:

pkg1 should not be marked as covered in the cover file, as it does not have any test and I'm not using other params such as -coverpkg.

I'm confused about what you're asking here. In the contents of cov.out there is this line:
cov/pkg1/file.go:3.25,5.2 1 0

That indicates that package pkg1 has 1 statement and that it is not covered. When you say "marked as covered" do you mean that pkg should not be mentioned at all?

@thanm pkg1 appears twice, the line you copied where it indeed shows as not covered, and the following one where it appears as covered. I'll paste again the "What did you see happen?" part of the issue:
$->> cov $ docker run --rm -it -v .:/code -w /code golang:1.23.3 go test ./... -coverprofile cov.out
	cov/pkg1		coverage: 0.0% of statements
ok  	cov/pkg2	0.003s	coverage: 100.0% of statements
$->> cov $ cat cov.out
mode: set
cov/pkg1/file.go:3.25,5.2 1 0
cov/pkg1/file.go:3.25,5.2 1 1
cov/pkg2/file.go:3.25,5.2 1 1

Right, of course. Somehow didn't pick up on that the first time.  Thanks for the clarification.


Add Bug Report page

Describe the feature you'd like
Adding bug report or feature request form to get bug reports or requests
Additional context
Dependent on #52 where Navigation Drawer will be added
Would you like to work on the issue?
Yes

Low priority. Please focus on moving forward the app through features first:
https://github.com/fossasia/badge-magic-android/labels/Priority%3A High

@yatri1609 @iamareebjamal this has been done. Could you please close this issue?

@iamareebjamal @mariobehling close this


fix: update gateway api crds in testdata for v0.7.0

/lgtm
should make these as part of in make generate?

good point


Feature Request: Add msg authz grant and revoke

till #129 is ready and can allow encoding of arbitrary types, we can have authz grant and revoke, so multisig participants can use UI for certain msg types by giving authz to any address ( for a day or so) and optionally revoking it if the address is corrupted.

It looks like CosmJS does not yet support signing those with ledgers https://github.com/cosmos/cosmjs/blob/main/packages/stargate/src/modules/authz/aminomessages.ts

Not yet solved, but added to #99


Update xsimd for Android support.

context: https://github.com/jatinchowdhury18/RTNeural/issues/80
This makes RTNeural just build on Android without disabling optimized exp and exp10.

Codecov Report

Merging #81 (fbdef19) into main (063810e) will decrease coverage by 2.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   96.63%   94.54%   -2.09%
==========================================
  Files          29       13      -16
  Lines        2437     1027    -1410
==========================================
- Hits         2355      971    -1384
+ Misses         82       56      -26

Impacted Files
Coverage Δ

RTNeural/common.h
100.00% <ø> (+6.10%)
:arrow_up:

RTNeural/ModelT.h
86.13% <0.00%> (-1.02%)
:arrow_down:

RTNeural/activation/activation_xsimd.h

RTNeural/dense/dense_xsimd.h

RTNeural/conv1d/conv1d_xsimd.h

RTNeural/activation/activation_eigen.h

RTNeural/lstm/lstm_xsimd.tpp

RTNeural/conv1d/conv1d_eigen.h

RTNeural/dense/dense_eigen.h

RTNeural/conv1d/conv1d_eigen.tpp

... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks for the PR!
This is a bit of a tricky one since the XSIMD folks removed xsimd::transform and xsimd::reduce without really offering a replacement. I'd rather not use the std:: replacements since that would force RTNeural to depend on C++17, and I'd definitely prefer to keep C++14 compatibility. Additionally, the std:: methods would likely be less performant in this context since they lose the explicit vectorization that the XSIMD methods provided.
Maybe the best option is to just copy this file to somewhere inside the RTNeural source tree (maybe RTNeural/RTNeural/xsimd-algorithms/algorithms.hpp), leave a comment saying why it's there, and then include it in common.h under the XSIMD section. Do you think that would work?

Yes, that sounds perfect. I will update this to make the changes later, but if you make it I appreciate that!

The changes are made as ^

Awesome, thanks! I decided to bump the XSIMD version up to 10.0.0, and use the `xsimd_api.hpp" header from within XSIMD, just to avoid having duplicates of any headers.
Once the CI is happy with everything, then I'll go ahead and merge this!


50% of property types in Austin marked "other"

interesting, will look into it tmw

Using an old version of HomeHarvest, try pip install -U homeharvest. You can verify that you have the latest version number with pip show homeharvest. The new field is style.
Austin, for_sale search,


chore(package): update local-repository-provider to version 1.2.18

:tada: This PR is included in version 7.4.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Second draft

Singleton/Interface -> Static methods

This mirrors the modern .NET Crypto API upon which these are built.
Completely eliminates the need for callers to think about lifetimes or threads at all.
Move ICask cross-language API to test project. Tests will implement this interface with some adapting to their target language's native API.

Add a strongly typed CaskKey struct.

This is just a string wrapper. No performance overhead vs. string after creation.
Guaranteed to be valid Cask unless default-initialized with null string.

Spanify

We no longer allocate any memory on the heap except to produce the string to back a new CaskKey.
We support UTF-16, UTF-8, and decoded byte inputs as spans now. You can still pass strings too.
We put limits on the sizes of key components so that we can stackalloc unconditionally and make strong assertions like above on how much we allocate.

Analyzers and formatting

Start fresh from dotnet new editorconfig.
Bump many "suggestions" to "warning" to make dotnet format fix them.
Turn on all .NET analyzers, opt-out of a few rules individually.
Enforce dotnet format --verify-no-changes in PR Validation.
It's very possible that we will decide to change .editorconfig for different style choices or to opt-out of more rules.

This PR does not come with strong opinions on these settings, only the strong opinion that whatever setting we choose should be enforced. I've opted for an aggressive starting point because it's always easier to dial this back than to dial it forward.
Establish patterns, principles, and guidelines for .NET Framework support
See lengthy comment in Polyfill.cs.
Also

Add more argument validation.
Rename "reserved" to "provider data".
Fix various issues found by analyzers.
Use .NET 9 SDK in PR validation.
Build and test debug and realse in PR validation (for Debug.Assert coverage, mainly)

I've taken this out of draft, but marked it with no-merge label to prevent it from merging. I added the action to check the no-merge label. The only reason I'm marking this no-merge is that I'd like to review the commit message and make sure it's not a concat of my mess of commits.


about EF 6.4

Can you tell us what's new in v6.4 or what's planned for this version ? Thanks.

Here are all closed issues for 6.4:
https://github.com/aspnet/EntityFramework6/milestone/14?closed=1

See https://devblogs.microsoft.com/dotnet/announcing-entity-framework-core-3-1-and-entity-framework-6-4/


Check if manifest file on server has proper CORS header

When checking Manifest based on website URL, we should check if the Manifest and the website have the same origin. If they haven't, we should check if the Access Control Headers are present in order to allow the cross origin request.

For info, I'll use https://ssl.gstatic.com/keep/manifest.json as working example.


add self-updater

Currently updates are done by hand, i.e. using curl to get a new version.
Further it would be nice to have at least a notification about a new version when running update-lockfile.
(Maybe update appenv here as well?)

This is #1


CompassApp option to write responses to file system

when batches are submitted to CompassApp, it keeps all incremental response objects in memory until the batch is completed. for very large batches, this may result in an out-of-memory error. to avoid this, we can immediately write the response to disk and then discard the object from RAM.
implementation will require adding functionality to the rust CompassApp that writes responses to disk and removes the response object. this can be done one of two ways:

add another run method to CompassApp that appends each response object from a chunk to some output file
create a "to disk" output plugin (rjf: i think i prefer this one, it doesn't require changes to the CompassApp Python or Rust API)

perhaps a refactor of OutputPlugins to perform a flat_map operation similar to InputPlugins, so we can flatten the result

serializing responses as JSON and appending them to a file is likely simplest if we stick to a newline-delimited JSON format, and if we serialize the JSON as a single row (no newlines) object.

create a "to disk" output plugin

Yeah I like this option as well, I'm wondering what the plugin should return the main application.. we could either:

return an empty json object
return a small json object with something like:

{
  "request": ...,
  "status": "Successfully wrote result to file my_output_file.json"
}

right, BUT! if we refactor OutputPlugin so that, instead of map ing over the responses, we instead flat_map, we can also return nothing. that will truly void out any memory accumulation. we can get to that by having OutputPlugins return a Vec similar to InputPlugin:
pub trait OutputPlugin: Send + Sync {
    fn process(
        &self,
        output: &serde_json::Value,
        result: Result<&SearchAppResult, SearchError>,
    ) -> Result<Vec<serde_json::Value>, PluginError>;
}

Great point, yeah returning nothing seems to be ideal. I guess we would still return a vector of any requests that resulted in an error.


wrong in the output

we can see the output and the code is not right in a line,
we donot know why it is narrow in the output line.

the plugin uses neovim's native terminal so this seems to be a terminal issue not the plugin

ok, how can I do for the terminal so that it can work well

pleace check http://vimdoc.sourceforge.net/htmldoc/term.html

@jiadsii It's not the terminal or the plugin , I think. Try fullscreening the terminal and trying. I don't think the width of the split is big enough

@CRAG666 what do you think?


Add Yocto Project

[Insert URL to the list here]
https://github.com/fkromer/awesome-yocto-project
[Explain what this list is about and why it should be included here]
The Yocto Project is the probably most used framework for creating custom embedded Linux distributions widely adopted in the industry.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
You have read and understood the instructions for creating a list.
This pull request has a title in the format Add Name of List.

✅ Add Swift
✅ Add Software Architecture
❌ Update readme.md
❌ Add Awesome Swift
❌ Add swift
❌ Adding Swift
❌ Added Swift

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.

✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
✅ - [Framer](…) - Prototyping interactive UI designs.
❌ - [iOS](…) - Resources and tools for iOS development.
❌ - [Framer](…)
❌ - [Framer](…) - prototyping interactive UI designs

Your entry should be added at the bottom of the appropriate category.
The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
Includes a succinct description of the project/theme at the top of the readme. (Example)

✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

It's the result of hard work and the best I could possibly produce.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
The repo name of your list should be in lowercase slug format: awesome-name-of-list.

✅ awesome-swift
✅ awesome-web-typography
❌ awesome-Swift
❌ AwesomeWebTypography

The heading title of your list should be in title case format: # Awesome Name of List.

✅ # Awesome Swift
✅ # Awesome Web Typography
❌ # awesome-swift
❌ # AwesomeSwift

Non-generated Markdown file in a GitHub repo.
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate. Please search for existing submissions.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.
To verify that you've read all the guidelines, please add comment with just the word unicorn.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.
Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

The list has not been around for at least 30 days yet. However it is officially supported by the Linux Foundation. Let me know in case you want to get contact information to get in contact with a representative or if you want to be contacted by the representative.

Closing as it has not been around for 30 days yet. The guidelines applies to everyone.


JVM & JS disagree whether \u00a0 matches /\s/

If you run 160.toChar.toString.matches("\\s") in both JVM and JS, you can that they return different results.

JVM = false
JS = true

I'm afraid that's just one of the zillion cases where the JS engine differs from the JVM one. The fact that they're different is already tracked as #1201, so I'm going to close this issue as a duplicate.

Ha! And raised by me nonetheless. I'd completely forgotten. Thanks @sjrd


proc/eval: Support type casts between basic types

Rebased on master at ad5097a8dc716e61992d5c7dd6213e58cb0a88b5

This commit was also on the interfaces pull request, closing.


[style]:  Enhance UI/UX of home page.

What's the style idea?
We need to improve
Add screenshots
Hey @codeaashu I want to make it more attractive and user friendly. I simply going to improve the design by adding some styling and color. I can add animation as well.

Could you assign this task, so that I can start working on it.
And Please make sure to add label (gssoc-ext, hactoberfest, Level1, Level2, Level3).
Code of Conduct

[x] I agree to follow this project's Code of Conduct

Start working on this features
but before that add your profile on DevDisplay
It's is the first priority of contribution in DevDisplay
if you don't assign in this you will not be able to contribute on this project

📢 Invitation to Join the DevDisplay WhatsApp Community!
We are excited to invite you to join the WhatsApp community of DevDisplay, where developers and contributors come together to collaborate and share their ideas.
Collaborative Support: If you are interested in working together with extensive support, we encourage you to join our community.
Open Source Contribution: If you would like to contribute to the DevDisplay open-source project, your participation is welcomed in our WhatsApp group.
By joining, you will have the opportunity to connect with like-minded individuals, discuss project developments, and contribute to our shared goals.
For more information and to join the community, please visit: Join DevDisplay WhatsApp Community.
We look forward to your participation!


Create Demo Driver

create a driver script that:

loads in the square poison data by calling the squarepoisson function
creates a mgm2d object from the data
calls the solve method to solve the problem
calls plot to show the plots of the levels data

created the demo file and imported the mgm2D class and the squarepoisson function
created the simple driver script to create the square poisson data from the function and create the mgm object and then create plots of the levels data. finally calling the solve function and printing out the results
played around with the matlab code to see if i could plot the banded data like Dr wright has in his presentation
brainstormed how we would present this demo. was thinking of having a podman container up and running so we could just call the demo script from the container's terminal. kind of difficult to present this since it doesnt have any UI and is just meant to be a pip installable package that is used as a python library

[t:60]


LanguageServerLauncherTemplete cannot be found.

I'm trying to develop a plugin to test a sample language server. I cannot find the LanguageServerLauncherTemplete.

Is this class available? How can i implement the plugin according to this source code?

This repository is about the specification. Looks like you want to get a language server running in IntelliJ. All I can recommend is to ask the question in the IntelliJ community.


Convert dm_control arm to use actuators

dm_control is built to use actuators to control position instead of mocap bodies, and MuJoCo plays much more nicely with actuators as well. Would definitely be worth converting the model and joints for future use

Keeping this as a mocap because it's closer to what the actual arm does, setting a target position and letting the arm figure it out


Bump default image for Azure to Ubuntu 14.04.3

The current image is segfaulting during apt-get update.

LGTM


repeating blocks?

One of my coders (Sara) says she has coded several blocks twice. Specifically, they came up last week when she said get blocks and again today.

That's a bug, thank you for reporting this. Fixing it right now. Please hold off on using idslabel until the updated code is put on the server. I'll send out an email.


web-ui: remove authentication logic from core and other zalando specifics

work in progress on #308
related to #294 #298
This PR removes all zalando specifics from the core: health endpoint, scm-source, specific docker build, authentication (all moved to another repo that use this package as the core an then extend it with zalando specifics)
@fmueller can we move the web-ui folder to another repo? this would help when using npm and git reference to install the package: npm install git+https://github.com/zalando-incubator/zally-web-ui

Codecov Report

Merging #334 into master will decrease coverage by 1.66%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   87.93%   86.27%   -1.67%
==========================================
  Files          38       28      -10
  Lines         373      255     -118
  Branches       24       23       -1
==========================================
- Hits          328      220     -108
+ Misses         39       30       -9
+ Partials        6        5       -1

Flag
Coverage Δ

#webui
86.27% <95.45%> (-1.67%)
:arrow_down:

Impacted Files
Coverage Δ

web-ui/src/client/app/containers/login.jsx
100% <ø> (ø)
:arrow_up:

web-ui/src/client/app/services/http-client.js
83.33% <ø> (ø)
:arrow_up:

web-ui/src/client/app/services/oauth-firewall.js
100% <100%> (ø)
:arrow_up:

web-ui/src/client/app/run.jsx
100% <100%> (+58.33%)
:arrow_up:

...eb-ui/src/client/app/services/oauth-interceptor.js
89.74% <100%> (-1.37%)
:arrow_down:

web-ui/src/server/window-env-handler.js
100% <100%> (ø)

web-ui/src/server/index.js
100% <100%> (ø)
:arrow_up:

...-ui/src/server/webpack-dev-server-proxy-handler.js
100% <100%> (ø)
:arrow_up:

web-ui/src/client/app/services/rest.js
88.88% <100%> (ø)
:arrow_up:

web-ui/src/client/app/services/oauth-util.js
70.58% <66.66%> (+2.58%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3593e51...f65ffa5. Read the comment docs.

👍

@rbarilani We stick with mono-repository approach. Otherwise we would have to separate cli as well.

@fmueller At least CLI and REST API server are based on the same stack.
The point here is that we have to publish the package on npm repository every time we have a change that we wanna test on our internal running instance and it's overkill (while if zally-web-ui it's another repo we can do "npm install git+ssh://...." and grab also unpublished/unstable version ) The other option is cloning the repository with a sparse checkout (to checkout just the web-ui folder) during the build and do some other tricks... basically not using npm to manage the dependency to the zally-web-ui core (not really optimal).
Just my 2 cents.

@rbarilani Let's discuss this offline. ;-)

👍

👍


Check for errors in loading tunable parameters.

For instance, if the number of parameters in the file is different from the number of current parameters.

We might also want to save the name of the tunable so we can provide a warning on loading if the loaded name differs from the current name (assigned in the example code).


Issue when compiling

Hi,
when compiling I am getting this error
I am running the latest IDE version of Arduino, any help would be appreciated :-)
I tried another install on a different laptop following the install step by step but still the same
1386 |   pAdve rtisementData->setManufacturerData(std::string(reinterpret_cast<char*>(payload), PAYLOAD_SIZE));
|   ^~~~
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In member function 'virtual void MyAdvertisedDeviceCallbacks::onResult(BLEAdvertisedDevice)':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1406:64: error: 'class String' has no member named 'data'
1406 |     rawdata = (uint8_t*)advertisedDevice.getManufacturerData().data();
|                                                                ^~~~
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In function 'void ble_scan()':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1627:48: error: conversion from 'BLEScanResults*' to non-scalar type 'BLEScanResults' requested
1627 |   BLEScanResults foundDevices = pBLEScan->start(BLE_SCAN_TIME, false);
|                                 ~^~~~~~~~
exit status 1
Compilation error: 'pAdve' was not declared in this scope
Compilation error: cannot convert 'std::string' (aka'std::__cxx11::basic_string'} to 'string'

"pAdve rtisementData" shouldn't have a space in it. delete that space and try recompiling.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Richs1077 @.>
Sent: Saturday, June 8, 2024 4:16:59 PM
To: ruthsarian/Droid-Toolbox @.>
Cc: Subscribed @.***>
Subject: [ruthsarian/Droid-Toolbox] Issue when compiling (Issue #7)
when compiling I am getting this error
I am running the latest IDE version of Arduino, any help would be appreciated :-)
1386 | pAdve rtisementData->setManufacturerData(std::string(reinterpret_cast<char*>(payload), PAYLOAD_SIZE));
| ^~~~
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In member function 'virtual void MyAdvertisedDeviceCallbacks::onResult(BLEAdvertisedDevice)':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1406:64: error: 'class String' has no member named 'data'
1406 | rawdata = (uint8_t*)advertisedDevice.getManufacturerData().data();
| ^~~~
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In function 'void ble_scan()':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1627:48: error: conversion from 'BLEScanResults*' to non-scalar type 'BLEScanResults' requested
1627 | BLEScanResults foundDevices = pBLEScan->start(BLE_SCAN_TIME, false);
| ~^~~~~~~~
exit status 1
Compilation error: 'pAdve' was not declared in this scope
—
Reply to this email directly, view it on GitHubhttps://github.com/ruthsarian/Droid-Toolbox/issues/7, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE3XHZ36V4RDTBDBEASISKDZGNRDXAVCNFSM6AAAAABJAH3UZ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DCOBRHA2TGNA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I am getting the same error Sent from my iPhoneOn Jun 8, 2024, at 3:29 PM, The Forgettable Mister Ruthsarian @.***> wrote:
"pAdve rtisementData" shouldn't have a space in it. delete that space and try recompiling.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Richs1077 @.***>
Sent: Saturday, June 8, 2024 4:16:59 PM
To: ruthsarian/Droid-Toolbox @.***>
Cc: Subscribed @.***>
Subject: [ruthsarian/Droid-Toolbox] Issue when compiling (Issue #7)
when compiling I am getting this error
I am running the latest IDE version of Arduino, any help would be appreciated :-)
1386 | pAdve rtisementData->setManufacturerData(std::string(reinterpret_cast<char*>(payload), PAYLOAD_SIZE));
| ^~~~
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In member function 'virtual void MyAdvertisedDeviceCallbacks::onResult(BLEAdvertisedDevice)':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1406:64: error: 'class String' has no member named 'data'
1406 | rawdata = (uint8_t*)advertisedDevice.getManufacturerData().data();
| ^~~~
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In function 'void ble_scan()':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1627:48: error: conversion from 'BLEScanResults*' to non-scalar type 'BLEScanResults' requested
1627 | BLEScanResults foundDevices = pBLEScan->start(BLE_SCAN_TIME, false);
| ~^~~~~~~~
exit status 1
Compilation error: 'pAdve' was not declared in this scope
—
Reply to this email directly, view it on GitHubhttps://github.com/ruthsarian/Droid-Toolbox/issues/7, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE3XHZ36V4RDTBDBEASISKDZGNRDXAVCNFSM6AAAAABJAH3UZ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DCOBRHA2TGNA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

thanks so much for the replies, I have removed the space but still no joy :-(
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In function 'void set_payload_from_beacon()':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1386:48: error: cannot convert 'std::string' {aka 'std::__cxx11::basic_string'} to 'String'
1386 |   pAdvertisementData->setManufacturerData(std::string(reinterpret_cast<char*>(payload), PAYLOAD_SIZE));
|                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|                                                |
|                                                std::string {aka std::__cxx11::basic_string}
In file included from C:\Users\Rich\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.0.1\libraries\BLE\src/BLEServer.h:22,
from C:\Users\Rich\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.0.1\libraries\BLE\src/BLEDevice.h:21,
from C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:184:
C:\Users\Rich\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.0.1\libraries\BLE\src/BLEAdvertising.h:31:35: note:   initializing argument 1 of 'void BLEAdvertisementData::setManufacturerData(String)'
31 |   void setManufacturerData(String data);
|                            ~^~
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In member function 'virtual void MyAdvertisedDeviceCallbacks::onResult(BLEAdvertisedDevice)':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1406:64: error: 'class String' has no member named 'data'
1406 |     rawdata = (uint8_t*)advertisedDevice.getManufacturerData().data();
|                                                                ^~
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino: In function 'void ble_scan()':
C:\Users\Rich\Dropbox\PC (2)\Documents\Arduino\Droid-Toolbox\Droid-Toolbox.ino:1627:48: error: conversion from 'BLEScanResults*' to non-scalar type 'BLEScanResults' requested
1627 |   BLEScanResults foundDevices = pBLEScan->start(BLE_SCAN_TIME, false);
|                                 ~^~~~~~
exit status 1
Compilation error: cannot convert 'std::string' {aka 'std::__cxx11::basic_string'} to 'String'

The immediate solution is to downgrade your ESP32 core to a 2.x version. The newly released ESP32 3.x core is incompatible with ESP32 2.x projects. At the moment I see no method in which I can resolve this issue in a manner that supports both ESP32 2.x and 3.x cores. I will continue to research this issue.

We've got a couple issues to contend with. ESP32 core 3.0 now uses the String object from the WString.h library to handle manufacturer's (beacon) data. ESP32 core 2.0 does not. I've found a way to support both 2.0 and 3.0. I am testing that now and will upload it shortly.
The second issue is the TFT_eSPI library also has an issue with the ESP32 3.0 core. The fix for that is either wait for a TFT_eSPI library update, or add the line #include "driver/gpio.h" to TFT_eSPI_ESP32.h and TFT_eSPI_ESP32_S3.h. That is something I cannot fix with my code, but I will add some if/else directives to detect ESP32 3.0 core with the old/unmodified TFT_eSPI library and error out the compilation.

I've published update 0.72. This should resolve the compatibility issues with ESP32 core 3.0.
Give it a test and let me know if it works for you.

fantastic thank you very much, its working great :-)

Completed my testing.  Everything is working great.TomSent from my iPhoneOn Jun 9, 2024, at 3:18 PM, The Forgettable Mister Ruthsarian @.***> wrote:
Closed #7 as completed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>


Make the action icons more unique

The action icons are way too similar. At this size I can only assume store owners are only going to click them

After checking the on-hover label every single time.
By using their order. I.e. I know the 2nd button is to print the label.

This is bound to cause mistakes.
Describe the solution you'd like
Give each functionality a unique color and possibly shape!

The icons have recently been replaced, but the version with that change hasn't been released yet. You can see the new icons here: #453
Please let me know what you think!

Looks better!


sendRevocationNotification should work without credentialRecordId.

To support sending revocation notification if the credential record has already been removed

IIRC, the main reason behind basing sendRevocationNotification on the credential exchange record is to get connection details from there. Probably we should think about using a dedicated record for the revocation itself, making the link between a given revocationId with a connectionId. This can be also useful to store more information, like the revocationFormat, so we can simplify the API to just specifying the revocationId. Do you think this would make sense?


Legal Documents

As a user, I want to understand my rights and responsibilities for EmpEmp.org .
AC:

Privacy Policy has been added to the website and social media accounts
EULA has been added
Users must accept Privacy Policy and EULA to create and edit account
Both documents have been approved by legal
Users can opt-out of email via editing their profile

I'm drafting this in Google docs.

Special thanks to Christina Baldovin for reviewing the documents.

Changes are now in prod.


PHP version req?

I'm getting the following:
[InvalidArgumentException]   Could not find package lubusin/laravel-decomposer at any version matching y   our PHP version <IP_ADDRESS>
Is this only supported on certain versions of php?

@sbramley It's minimum requirement is PHP 5.6 , as the support for PHP 5.* is officially ended we would advise you to atleast move to 5.6 atleast if possible. If you still can't upgrade to PHP 5.6 due to some reasons let us know, we would might lower the dependency for you to use the package, as we aren't using any PHP 7 specific feature yet.

I'm checking into it now, we're running on Elastic Beanstalk on AWS and I know it's a little behind in terms of versioning

@sbramley let us know the final call you make.