Feature - Pin dependencies - add support for gclient DEPS file

Is your feature request related to a problem? Please describe.
Yes, dart and flutter use gclient from chromium to manage third party dependencies. We would like to add Pin dependencies support for this type of files.
Describe the solution you'd like
Unfortunately parsing DEPS file without python may be challenging. We would like to run python in a subprocess to flatten up the third party dependencies from DEPS to identify dependencies that are not pinned.
Describe alternatives you've considered
An alternative would be to try to parse the file directly from go but it would be very difficult to cover all possible corner cases.
Additional context
N/A

Thanks for reporting this @godofredoc. I wonder if a Python parser like<EMAIL_ADDRESS>can be used here? If the code complexity of these DEPS files tends to be fairly simple we could get away with not being able to handle all corner cases.
I have added the needs discussion label to this issue so that we can bring this up during the Scorecard sync next week. If possible please do drop by so that we can get your inputs on this. You can find the details to the meet and our Slack channel here: https://github.com/ossf/scorecard#connect-with-the-scorecards-community

one way we get around this problem for other package managers is that we use detect the use of commands that fail unless the dependencies are pinned. For example for pip, we check for use of pip ... --require-hashes.
Is there something similar for gclient?

gclient does not support checking for pinned dependencies but I can try to contact the owners and see if there is interest on implementing that functionality.
Alternatively we can autogenerate a flattened DEPs file and only check for the pinned dependencies from scorecards using a plain text file with one dependency per line.

gclient does not support checking for pinned dependencies but I can try to contact the owners and see if there is interest on implementing that functionality.

that'd be really helpful. Let us know if there's something we can help with.

Alternatively we can autogenerate a flattened DEPs file and only check for the pinned dependencies from scorecards using a plain text file with one dependency per line.

what do you mean by autogenerate?

gclient does not support checking for pinned dependencies but I can try to contact the owners and see if there is interest on implementing that functionality.

that'd be really helpful. Let us know if there's something we can help with.

Alternatively we can autogenerate a flattened DEPs file and only check for the pinned dependencies from scorecards using a plain text file with one dependency per line.

what do you mean by autogenerate?
gclient supports hooks that run as part of the source code checkout process, here is an example. We can add an additional hook that writes a file with the list of dependencies. This will be committed to the repository as DEPS_list, pinned dependencies check can read files called DEPS_list and validate them using regular expressions.

pros:

Scorecards won't need a additional dependency on gclient depot_tools

cons:

Anyone that wants to use DEPS pinned dependencies validation will need to flatten their dependencies and commit the autogenerated file to the repositories under test

Alternatively we can autogenerate a flattened DEPs file and only check for the pinned dependencies from scorecards using a plain text file with one dependency per line.

I presume this is not a norm among the clients of gclient? If so, it might be a bit hacky to do this. How many repos would benefit from something like this? If its a reasonable number, we could consider this as a first step while working out a more general solution.

@azeemshaikh38 you are correct generating the flattened file is a work around and it won't be generic.
I've been thinking on other potential solutions and I believe I found one to make the DEPS implementation generic.
The overall workflow would look like:

A python script to flatten the deps can be checked into oosf/scorecards/scripts. The script is pretty simple <100 lines
The score cards pinned dependencies can look for all the DEPS files in the repository under test. If there is a DEPS file, scorecards can check if python is available in the host running the checks, if it is not available then we add an alert that a DEPS file was found and python is required to validate it.
The python script can run as a subprocess from scorecards to get the list dependencies and run the regular expressions on each line to check they are all pinned.

Some caveats given that the DEPS file is being parsed we won't be able to correlate failures with specific lines.
Please let me know what do you think about this potential solution.

Is there any update on this thread?

I finished implementing the python script part.  Here is the PR:
https://github.com/flutter/engine/pull/32135
I'll send the validation of pinned dependencies to scorecard the next week.

I finished implementing the python script part. Here is the PR:
flutter/engine#32135
I'll send the validation of pinned dependencies to scorecard the next week.

Is it going to be in python? We can't run Python.

The parser step in the actions workflow will generate a file called "deps_flatten.txt" and from scorecards side I was planning to just scan for deps_flatten.txt files and then run all the pinning analysis and report extending one of the existing pin checks.
Would that work or do you mean that it is not recommended to run python as part of the scorecards github actions workflow in the target repository?

The parser step in the actions workflow will generate a file called "deps_flatten.txt" and from scorecards side I was planning to just scan for deps_flatten.txt files and then run all the pinning analysis and report extending one of the existing pin checks.

Sorry, this is still not clear. Is actions workflow scorecard actions?

Would that work or do you mean that it is not recommended to run python as part of the scorecards github actions workflow in the target repository?

Do you want to run Python as part of scorecard actions?
Probably a design document/diagram can help visualize and clarify the understanding.

The parser step in the actions workflow will generate a file called "deps_flatten.txt" and from scorecards side I was planning to just scan for deps_flatten.txt files and then run all the pinning analysis and report extending one of the existing pin checks.

Sorry, this is still not clear. Is actions workflow scorecard actions?

Using https://github.com/flutter/engine/pull/32135 as an example .github/workflows/scorecards-analysis.yml is the workflow that will be running the python script to generate the deps_flatten.txt in the local checkout before the scorecard actions run.

Would that work or do you mean that it is not recommended to run python as part of the scorecards github actions workflow in the target repository?

Do you want to run Python as part of scorecard actions?

No, python will run as part of the workflow that runs the scorecard actions in the repository under test.

Probably a design document/diagram can help visualize and clarify the understanding.

Sure, please let me know if after the explanations above a design doc will still be required and I'll be happy to write it.

Sounds good. Thanks. Is there any work that would be required from the scorecard project with respect to this?

I believe only code reviews will be needed, I'm planning to send the PR.

(Adding the help wanted label, but note that is not prioritized by the maintainers, given the age)


Fix/workaround procedure loading on some windows machines

This change makes opengl stuff work on some windows machines.  It uses the same strategy (call GetProcAddress, then wglGetProcAddress) that pict3d used to workaround the same issue:
https://github.com/ntoronto/pict3d/issues/9
I believe this will solve the problem Leif was having:
https://github.com/stephanh42/RacketGL/issues/20
This fixed mode-lambda for me on one windows machine.  On a second windows machine that was always working, this did not cause any regression that I could see.
Please let me know if there's anything else I can do.  Thanks!
Dave

Hi David,
why not simply
(load-get-proc-address (ffi-lib "opengl32")

                                 '("wglGetProcAddress" "GetProcAddress"))

Is that what you meant?  Thanks for getting back to me so fast!

Hi David,
Yes, exactly.
Stephan
2017-12-07 15:49 GMT+01:00 david-vanderson<EMAIL_ADDRESS>
Is that what you meant? Thanks for getting back to me so fast!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/stephanh42/RacketGL/pull/21#issuecomment-349989011,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsR3n2KGxdkR90ZAWNhOht2FNsIRb3Eks5s9_sIgaJpZM4Q46If
.

Anything else I can do to help this get merged?

Thank you!


Feat: "Filter and Clear" Buttons Design Improvement

What feature?
The current design of the buttons is nice but it can be improved by some design adjustments. By working on the styling properties of the buttons, I can make them look even better.
Add screenshots
Current Design

Expected Updated Design

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

we will change the UI design so we currently we don't need


Passing request options to the request method

Problem
Following on from #506, please can we discuss a feature to allow passing request options to the underlying fetch requests. As Next’s new App Router is going to see increasing adoption, it’d be good to support this better. It’s also something I run into almost every time that I use the client.
Proposal
const client = new GraphQLClient(endpoint);

client.request(query, variables, {
  headers: {
    "X-Custom-Header": "Preview Token", // Allow for setting headers on the fly without touching the client
    ...client.requestOptions.headers, // Or similar
  },
  next: { revalidate: 10 }, // Passed directly to the underlying fetch
});

This would allow a far greater scope of control over each request versus the existing setHeaders, et al., but would necessitate the addition of getters (e.g. client.requestOptions or similar).

An alternative might be to use Request instances a little more literally, however, the naming convention is going to be an issue here (i.e. getRequest() vs request vs makeRequest vs rawRequest, etc.).
const request = client.getRequest(); // Returns a Request instance

request.next = { revalidate: 10 }; // Read and write as needed

const response = await client.fetch(request); // Make the request

Any update on this?

Our project is using a graphql codegen tool that makes it impossible to do something like this without modifying autogenerated code.
This solution feels pretty bad but it works.
const client = new GraphQLClient(`${WEB_URL}/graphql`, {
  fetch,
  requestMiddleware: (req) => {
    // append auth headers, etc
    // ...

    // if present, pull the next config out of the headers and hoist to the top level request config
    const { next, ...headers } = req.headers as HeadersInit & { next: { revalidate: number } };
    let nextConfig = {};
    if (next) {
      nextConfig = { next };
      req.headers = headers;
    }

    // append auth headers to all graphql requests
    return {
      ...req,
      ...nextConfig
    };
  }
});

// init sdk using `getSdk` command provided by codegen tool
export const sdk = getSdk(client);

Server component usage:
import { sdk } from '@/lib/sdk';

// in the page render method, pass next config where you would normally pass headers
export default async function Page() {
  const data = await sdk.MainNavContent({}, { next: { revalidate: 120 } });
  //...
}

Hi, I think even if we have this, Vercel won't cache your data if it's a POST request

Dynamic methods (next/headers, export const POST, or similar) are used and the fetch is a POST request (or uses Authorization or cookie headers)

@joshuabaker isn't GraphQL api call always a POST request? If so, how do we opt in caching if Vercel doesn't support that?

Only when the request uses "Dynamic methods" is caching not available (but you can still manually cache with the cache utility). Regular post requests are cached

This would be very useful. 🚀

One way to handle this is to utilize Route Segment Config instead.
This is basically the same thing, because

If you have multiple fetch requests in a statically rendered route, and each has a different revalidation frequency. The lowest time will be used for all requests. For dynamically rendered routes, each fetch request will be revalidated independently.
Source here: https://nextjs.org/docs/app/building-your-application/data-fetching/fetching-caching-and-revalidating#time-based-revalidation

@lynndylanhurley Yeah, it was a somewhat throwaway thought. I think just exposing access to the fetch options in the request method makes the most sense.
@zipme I double checked just now to be sure and Next definitely caches POST requests too. The below example is definitely cached, for instance.
fetch(apiUrl, {
  method: 'post',
  next: { revalidate: 5 },
});

@jasonkuhrt Do you have any thoughts on passing fetch options through and merging them?
request(url, document, variables, fetchOptions);

request({
  url,
  document,
  variables,
  requestHeaders, // Retained for backward compat
  fetchOptions, // Access to all fetch options
});

const client = new GraphQLClient(url);
client.request(document, variables, fetchOptions);

This approach would open up mode, credentials, etc. on top of Next’s proprietary next option.

@joshuabaker  indeed, it does cache the POST request as well, though I think with this new API we probably don't need to pass this extra options anymore? (thus the library is next/vercel agnostic?)

For posterity…
/app/page.jsx
import { gql, request } from "graphql-request";
import { unstable_cache } from "next/cache";

const url =
  process.env.NODE_ENV === "development"
    ? "http://localhost:3000/api/graphql"
    : `https://${process.env.NEXT_PUBLIC_VERCEL_URL}/api/graphql`;

// Fetch data with graphql-request
async function getNow() {
  const { now } = await request(
    url,
    gql`
      {
        now
      }
    `,
  );
  return now;
}

// Wrap the fetching function with Next’s cache
const getCachedNow = unstable_cache(
  getNow,
  ["now"], // Cache key
  { revalidate: 5 }, // { tags, revalidate }
);

export default async function Example() {
  const now = await getCachedNow(); // Get the data in the RSC using the wrapped function
  return <p>{now}</p>;
}

/app/api/graphql/route.js

import { createSchema, createYoga } from "graphql-yoga";

const schema = createSchema({
  typeDefs: /* GraphQL */ `
    type Query {
      now: String!
    }
  `,
  resolvers: {
    Query: {
      now: () => new Date().toISOString(),
    },
  },
});

const { handleRequest } = createYoga({
  graphqlEndpoint: "/api/graphql",
  schema,
  fetchAPI: {
    Request: Request,
    Response: Response,
  },
});

export { handleRequest as GET, handleRequest as POST };


ZUI-79

Currently component is using span but it should be using the heading of appropriate level for the specific page.
Changed to make it heading level 3 with styling of h6, with slightly more line spacing for readibility

:tada: This PR is included in version 5.40.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CVE’s in base Postgres image

I just ran this image through my company's blackduck container scan and the following CVE's were detected. Let me know what other information is needed to make this an effective issue report.
libidn2

CVE-2019-18224
CVE-2019-12290

runc

CVE-2019-5736
CVE-2019-16884

libsecomp

CVE-2019-9893

berkeleydb

CVE-2016-0694
CVE-2016-3418
CVE-2016-0682
CVE-2016-0692
CVE-2016-0689
CVE-2017-3606
CVE-2017-3605
CVE-2017-3604
CVE-2017-3607
CVE-2017-3608
CVE-2017-3613
CVE-2017-3615
CVE-2017-3617
CVE-2017-3611
CVE-2017-3616
CVE-2017-3610
CVE-2017-3612
CVE-2017-3614
CVE-2017-3609

kerberos

CVE-2000-0548
CVE-2000-0546
CVE-2000-0547

tar

CVE-2018-20990
CVE-2019-9923

glibc

CVE-2018-20796
CVE-2019-9192

shadow

CVE-2019-16110

gnupg

CVE-2019-13050

selinux

CVE-2011-3151

procps

CVE-2018-1121

See https://github.com/docker-library/faq#why-does-my-security-scanner-show-that-an-image-has-so-many-cves
And https://github.com/docker-library/postgres/issues/286#issuecomment-302512767 docker-library/openjdk#161, docker-library/openjdk#112, docker-library/postgres#286, docker-library/drupal#84, docker-library/official-images#2740, docker-library/ruby#117, docker-library/ruby#94, docker-library/python#152, docker-library/php#242, docker-library/buildpack-deps#46, docker-library/openjdk#185.
A CVE doesn't imply having an actual vulnerability, and often is even a false positive (given how most distributions handle versioning/security updates in stable releases). If there are actionable items we can resolve, we're happy to do so (and do so actively). We update all Debian based images to include any updates in apt packages at least monthly (we regenerate the base images and then rebuild all dependent images).

Thank you @wglambert that makes sense. Unfortunately my company doesn't allow any containers to be used that have any reported severe or high cve's. :(

Here, I linkified the CVE's to Debian's bug tracker (since postgres images are based on Debian). As @wglambert mentioned, all of these are not even applicable vulnerabilities since the package isn't installed or is already fixed, so you may want to report that to your scanner.
libidn2

https://security-tracker.debian.org/tracker/CVE-2019-18224 "libidn2-0  (Vulnerable code not present)"
https://security-tracker.debian.org/tracker/CVE-2019-12290 "Minor issue; intrusive to backport"

runc (ummm, runc or lxc are not installed in the postgres image)

https://security-tracker.debian.org/tracker/CVE-2019-5736
https://security-tracker.debian.org/tracker/CVE-2019-16884

libsecomp

https://security-tracker.debian.org/tracker/CVE-2019-9893 "No security issue by itself"

berkeleydb: "NOT-FOR-US: Oracle Berkeley DB (later closed source releases)"

https://security-tracker.debian.org/tracker/CVE-2016-0694
https://security-tracker.debian.org/tracker/CVE-2016-3418
https://security-tracker.debian.org/tracker/CVE-2016-0682
https://security-tracker.debian.org/tracker/CVE-2016-0692
https://security-tracker.debian.org/tracker/CVE-2016-0689
https://security-tracker.debian.org/tracker/CVE-2017-3606
https://security-tracker.debian.org/tracker/CVE-2017-3605
https://security-tracker.debian.org/tracker/CVE-2017-3604
https://security-tracker.debian.org/tracker/CVE-2017-3607
https://security-tracker.debian.org/tracker/CVE-2017-3608
https://security-tracker.debian.org/tracker/CVE-2017-3613
https://security-tracker.debian.org/tracker/CVE-2017-3615
https://security-tracker.debian.org/tracker/CVE-2017-3617
https://security-tracker.debian.org/tracker/CVE-2017-3611
https://security-tracker.debian.org/tracker/CVE-2017-3616
https://security-tracker.debian.org/tracker/CVE-2017-3610
https://security-tracker.debian.org/tracker/CVE-2017-3612
https://security-tracker.debian.org/tracker/CVE-2017-3614
https://security-tracker.debian.org/tracker/CVE-2017-3609

kerberos: "NOT-FOR-US: Data pre-dating the Security Tracker"

https://security-tracker.debian.org/tracker/CVE-2000-0548
https://security-tracker.debian.org/tracker/CVE-2000-0546
https://security-tracker.debian.org/tracker/CVE-2000-0547

tar

https://security-tracker.debian.org/tracker/CVE-2018-20990 "rust-tar  (Fixed with initial upload to archive)"
https://security-tracker.debian.org/tracker/CVE-2019-9923 "Crash in CLI tool, no security impact"

glibc

https://security-tracker.debian.org/tracker/CVE-2018-20796 "No[t] treated as vulnerability"
https://security-tracker.debian.org/tracker/CVE-2019-9192 "DISPUTED" "NOTE: the software maintainer disputes that this is a vulnerability because the behavior occurs only with a crafted pattern."

shadow

https://security-tracker.debian.org/tracker/CVE-2019-16110 "NOT-FOR-US: Blade Shadow"

gnupg

https://security-tracker.debian.org/tracker/CVE-2019-13050 "NOT-FOR-US: Conceptual weakness in PGP keyserver design"

selinux

https://security-tracker.debian.org/tracker/CVE-2011-3151 "NOT-FOR-US: Historic Ubuntu init script issue"

procps

https://security-tracker.debian.org/tracker/CVE-2018-1121 "unimportant"


Include + HasMany + column alias + order = incorrect query

First you need a model with a column alias:
@Column({type: DataType.DATEONLY, field: 'date_start'})
dateStart: Date;

And on the same model, a HasMany:
@HasMany(() => ImageModel, {foreignKey: 'userId'})
images: ImageModel[]

Then do a find like so:
UserModel.findOne<UserModel>({
    where: {id: 1}, order: [['dateStart', 'DESC']], include: [ImageModel]
})

This will create an inner query that grabs the user model and does the order by the non alias name date_start. Then it joins it with the images, and tries to order again with the same non alias date_start, which fails because it's been aliased to dateStart. This is the resulting query:
SELECT
"UserModel".*, "images"."id" AS "images.id",
"images"."user_id" AS "images.userId",
"images"."url" AS "images.url"
FROM
(
	SELECT
		"UserModel"."id",
		"UserModel"."date_start" AS "dateStart",
		"UserModel"."name",
	FROM
		"users" AS "UserModel"
	WHERE
		"UserModel"."id" = 1
	ORDER BY
		"UserModel"."date_start" DESC
	LIMIT 1
) AS "UserModel"
LEFT OUTER JOIN "images" AS "images" ON "UserModel"."id" = "images"."user_id"
ORDER BY
"UserModel"."date_start" DESC;

Hey @kingjerod sounds like a sequelize issue to me. Can you reproduce this with pure sequelize? If so, this should be reported to the sequelize team.
Which sequelize and sequelize-typescript version are you using?

I'll give it a go with regular Sequelize. Using sequelize 4.2.1, and sequelize-typescript 0.4.0

Yup, looks like a Sequelize issue. I have opened an issue with them.
https://github.com/sequelize/sequelize/issues/8100

@kingjerod Thank you


Implement DerefMut for Utf8PathBuf

With rust 1.68.0 DerefMut will be implemented for PathBuf (https://github.com/rust-lang/rust/pull/105018/) , so I assume it is desirable to mirror that change in camino.

This is now out as part of camino 1.1.4.


How to get slashes in routes working without dynamic nesting

Please. Anyone. Just one working example of how to route urls with more than one slash (for the route itself). I spent a Sunday on this but no luck.
I'm using Nuxt as a central part in building a customized and server side rendered MEVN stack (the N might as well stand for Nuxt).
For the sake of the future I would really like to keep a url structure with domain/route/category/subcategory/slug - the name of the controlling route being permlink.
Dynamic nested routes haven't been any success, though.
As an alternative some hacks with encodeURIComponent(someurl) and decodeURIComponent(someurl) have been tested. This seems closer, but still no breakthrough. Perhaps it's just a matter of putting the encodes and decodes right.
Works: http://localhost:8085/permlink/tyskland-baenkesaet-test-med-tags-jan
Works: http://localhost:8085/permlink/england%2Fjord%2Ftester-med-fast-ord-testord
404: http://localhost:8085/permlink/england/jord/tester-med-fast-ord-testord
404: http://localhost:8085/permlink/udvandrerne/baenke-drastisk-udrensning-fremhaever-vigtigt
Then I've tested the extendRoutes way. After the best of my abilities I've sucked a lot up up from 1592, 1542, 1234, 1032, 275, 112 among others.
Only result is still 404, when it comes to the urls including slashes after /permlink. Have also tested without the dynamic component \pages\permlink\_permlink.vue to give "more room" for the extended route - but same same.
Please take a look at one of all my tested configurations in nuxt.config.js:
    router: {
        extendRoutes (routes, resolve) {
          routes.push({
            name: 'permlinkindex',
            path: '*',
            component: resolve(__dirname, '~/pages/permlinkindex.vue')
          })
        }
      },

Is this simply caused by a bug with backslashes in windows?
My setup:

Windows 10
NPM 5.3.0
Node 8.1.2
Nuxt 1.0.0-rc11

Any help - or just a little push - would be much appreciated.

Hi @JLKM,
Have you tried with the page name: _.vue ?
It creates a route with the path as * and the name is all.

Thanks a lot for your fast advice, which I've tested right away - the best I could.
Unfortunately I'm not quite aware, where to put the _.vue file. So I tested various locations:
1. In permlink-folder hierachy
Files:
F:\data\fullstack\mean\pages\permlink.vue
F:\data\fullstack\mean\pages\permlink_permlink.vue
F:\data\fullstack\mean\pages\permlink__.vue
F:\data\fullstack\mean\pages\permlink___.vue
F:\data\fullstack\mean.nuxt\router.js:
		{
			path: "/permlink",
			component: _62527d7c,
			name: "permlink",
			children: [
				{
					path: ":?/:?",
					component: _d33c5bc8,
					name: "permlink--",
					children: [
						{
							path: ":?",
							component: _753511f3,
							name: "permlink---"
						}
					]
				},
				{
					path: ":permlink?",
					component: _70a2b506,
					name: "permlink-permlink"
				}
			]
		},

Result:
Bingo (0 subfolders): http://localhost:8085/permlink/tyskland-baenkesaet-test-med-tags-jan
Bingo (0 subfolders): http://localhost:8085/permlink/udvandrerne%2Fgenerelt%2Foverskrift-ordet-noget-tekst-skriver
404 (2 subfolders): http://localhost:8085/permlink/udvandrerne/generelt/overskrift-ordet-noget-tekst-skriver
2. Without hierarchy
Files:
F:\data\fullstack\mean\pages\permlink.vue
F:\data\fullstack\mean\pages\permlink_.vue
F:\data\fullstack\mean.nuxt\router.js:
		{
			path: "/permlink",
			component: _62527d7c,
			name: "permlink",
			children: [
				{
					path: ":?",
					component: _312c2a93,
					name: "permlink-"
				}
			]
		},

Result:
404 (0 subfolders): http://localhost:8085/permlink/tyskland-baenkesaet-test-med-tags-jan
404 (0 subfolders): http://localhost:8085/permlink/udvandrerne%2Fgenerelt%2Foverskrift-ordet-noget-tekst-skriver
404 (2 subfolders): http://localhost:8085/permlink/udvandrerne/generelt/overskrift-ordet-noget-tekst-skriver
3. The radical solution
Only one file at the /pages/-root:
F:\data\fullstack\mean\pages_.vue
F:\data\fullstack\mean.nuxt\router.js:
{
path: "/:",
component: _d096e886
}

*Result:*
404 (0 subfolders): http://localhost:8085/permlink/tyskland-baenkesaet-test-med-tags-jan
404 (0 subfolders): http://localhost:8085/permlink/udvandrerne%2Fgenerelt%2Foverskrift-ordet-noget-tekst-skriver
404 (2 subfolders): http://localhost:8085/permlink/udvandrerne/generelt/overskrift-ordet-noget-tekst-skriver

As you see: No * in the generated routes.js.
What did I miss? Is it something in my setup?

pages/permalink/_.vueshould be enough in your case.

Hello there.
I am trying to build a website where the route matches a json file on my server. Adding a JSON File would "create" another page.
Let say for instance that going to the page /rub1/article1 will try to load the json file "article1.json" in the folder "rub1" in the static folder.
Tried both solution with _.vue and extendRoutes.
Both solutions works great until I try to get a json file that doesn't exists.
Let say a user tries to load rub1/article666 that doesn't exists
The page calls the json file, which doesn't exists, but the route is being catched by the  nuxt "catchall" route, proceed to the same vue component, that now tries to load the article666.json.json according to the route, which doesn't exists... and so on
Crashes the server everytimes.
I struggle to find a way to prevent the router to loop more than once.
Any ideas ?
Thanks


Added remove_view and forget_view to act on instances of a named view style

Referencing issue #134, this PR adds the ability to remove and forget individual views that share an element_id.
So I can have
root :main do
  add UIButton, :button
  add UIButton, :button
end

and later
  remove_view(:button, first(:button))

I'm finding this indispensable when I add/remove a series of dynamic buttons to a horizontal scroll view at the top of my page. When you click on a button, it is removed and the layout constraints are re-linked with the remaining buttons.   Without this all(:button) would continue to return the old buttons, and I would need to check the superview of each. Not to mention the memory leak.
LMK what you think ... I added forget_view and specs too.

pinging this PR...

Thanks for the bump, didn't mean to pass this up!

Available in... 1.0.0!


Adding astar shiden and shibuya

Description

Checklist

[x] The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
[x] The box that allows repo maintainers to update this PR is checked
[x] I tested locally to make sure this feature/fix works
[ ] I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
[ ] This PR passes the Circle CI checks

If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/
Tests with demo app (injected)

[x] send transaction
[x] switch chains
[x] sign message
[x] sign typed message
[x] disconnect

Tests with demo app (SDK)

[ ] send transaction
[ ] switch chains
[ ] sign message
[ ] sign typed message
[ ] disconnect

Hello blocknatives, I'm curious to know why locally I can see the new icons working, while on versel github home page, it does not.

@gluneau thank you for submitting a PR! We appreciate your support.
In an effort to keep web3-onboard lean we are not adding further native chain support unless we are working closely with the chains team.
This is in an effort to keep onboard as light as possible and because speciality chain support can be added by the developer on a case-by-case basis.
For more information on adding specialty chains to your onboard initialization please see the chains section in our docs here https://onboard.blocknative.com/docs/modules/core#options


[executor][fix] Fix the bug of skipping a wrong number of txns when executing idempotent commit

Motivation
#1627 introduces a bug that the skipping logic is not correct, which can cause more skipping than expect and failed the commits. Fixed in the PR
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
Cluster_test
Related PRs
#1627

Test?

@bors-libra delegate+
tests would be nice

:v: @lightmark can now approve this pull request

FYI: We are crashlooping with this commit as well:
D1115 21:11:12.010241<PHONE_NUMBER>56640 consensus/src/chained_bft/event_processor.rs:327] Starting sync: current_hqc_round = 26072, sync_info_hqc_round = 26072, deadline = "1.491034858s"
D1115 21:11:12.010272<PHONE_NUMBER>56640 consensus/src/chained_bft/event_processor.rs:344] Caught up to HQC at round 26072
D1115 21:11:12.010322<PHONE_NUMBER>56640 executor/src/lib.rs:460] Received request to commit block 916a96a69c55a4c7c84f9d21dca26b34fb1a53948c57781d506d200690e2476a.
I1115 21:11:12.010345<PHONE_NUMBER>56640 executor/src/block_processor.rs:479] The lastest committed version: 1794007, the first version to commit: 1793908.Skipping the first 100 transactions and start committing from version 1794008
C1115 21:11:12.307996<PHONE_NUMBER>56640 common/crash-handler/src/lib.rs:36] details = '''
panicked at 'assertion failed: `(left == right)`
  left: `1794008`,
 right: `1794009`', executor/src/block_processor.rs:521:13'''
backtrace = '''

@bors-libra r+

:pushpin: Commit 4c0e5e8 has been approved by lightmark

:hourglass: Testing commit 4c0e5e86501a48e8d7db07cf803501f3eb209648 with merge 731cde9406d98ac1e7347f47d07ee47c28a79524...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: lightmark
Pushing 731cde9406d98ac1e7347f47d07ee47c28a79524 to master...


Added danish translation

Thank you for adding a danish translation!👍
I've added your strings.xml to the Lokalise-project: https://github.com/Ixam97/CarStatsViewer/issues/121
It will be merged with the next translation update PR. If you don't mind it would be nice if you join the Lokalise-Team to directly translate new strings over there 😉

I've invited @blixtdevelopment to Lokalise.


Doesn't work on macOS Catalina

Bug Summary 🐞
When calling workflow from extarnal trigger or keyword, I receive this window:

I have the Gatekeeper disabled.
macOS v10.15

That's not good. If you go to Security & Privacy and system prefs, it sometimes gets a prompt here you have to accept:

Let me know if that works. If it doesn't I have no idea.

It doesn't appear here, @nikitavoloboev
Moreover, I have "Allow apps downloaded from:" set to "Anywhere"

Posted on forum, perhaps someone has a solution.

If you go to Security & Privacy and system prefs, it sometimes gets a prompt here you have to accept

That’s for allowing blocked Kernel Extensions.

Moreover, I have "Allow apps downloaded from:" set to "Anywhere"

You really shouldn’t; App Store and identified developers is generally enough. Any app that doesn’t work with that, you can right-click and chose Open. I’m unsure if that works with compiled binaries in Catalina.

This fixed the issue for me. Thank you, @nikitavoloboev


Preserve JSDocs in *.d.ts files when stripping comments

Suggestion/Feature
When using the switch removeComments it will strip out all comments including the ones you may consider useful to the end consumer such as JSDocs. I'd like to strip out any internal comments but preserve any JSDocs comments. It seems that an option to preserve comments in types would be sufficient.
Existing functionality
"removeComments": true,
"declaration": true,

removes all comments including those in *.d.ts files.
Suggested functionality
"removeComments": true,
"declaration": true,

I would think by default you'd want to include the JSDocs in your type defs, so this would remove all comments from the code, but retain any comments associated with the types ie JSDocs.
If however, there is a need to remove all comments then an additional switch may be required to serve that purpose:
"removeCommentsIncludingDeclarations": true,
"declaration": true,

Would produce the same result we have today.

it makes no sense to remove the comments from declaration files, since they are mainly used during development and won't go into production, I was expecting too that removeComments would only remove them from transpiled .js files.

Legitimate question - why is anyone using removeComments? I would assume that you're using a minifier if you actually care about removing comments, but maybe I'm not aware of other scenarios.

unminified code not for the browser, mainly. split code base into composable components that will later become part of something bigger (but while in dev, useful being on the consumer part of it). comments in JS = not useful. Comments in .d.ts, uber useful.

Is this still on the horizon? This is a bit of a pain point with respect to my work-around for #21566 when generating declaration files. Fortunately in my case the declaration file is equivalent to the input source file so i can just replace the generated declaration file with a copied and renamed source file in automation.

UglifyJS strips all comments but those with @license or @preserve.

@DanielRosenwasser, I frequently publish bite-size packages using typescript as my only build step. I usually want my code minified, but my comments available in the declarations since they are doc comments. This is a wonderfully simple way for my to publish packages rather than incorporating a bundler with plugins.

HAPPY ONE YEAR ANNIVERSERY!!!!!
Its been exactly 1 YEAR today since this was opened. Are we any closer to having this resolved? This doesn't seem to be a lot of work to fix, but given we've had two duplicates since this was opened, it is something people want. I know I'd like to use it on my OSS projects...

On a related note: if/when this does get fixed, it would be nice to also adjust the .d.ts output slightly, so that there's a space between doc-blocks and declarations. Currently it's all crammed together.

@RyanCavanaugh why mark my reply with a thumbs down? I think its quite valid to ask what's going on with a feature that's been 'In Discussion' for over a year. It would have been more helpful to the community to have spent time replying with an actual update, rather than just being rude!

I'd suggest
comments: "never" = no comments
comments: "declaration" = comments are put into the .d.ts files
comments: "emit" = comments are put into emitted js files

hope can have this,
i don't think we should use another tool when we wanna remove comment on .js, but keep it on .d.ts

@DanielRosenwasser to answer your question:
I think there's a difference between comments used for development and comments used for API consumers.
Comments for development (Starting with // or JSDoc with @internal) live only in the source code and are to help future development easier. These commends do not need to be in the distribution files as they are of no use for the consumer.
Comments for API consumers (JSDoc) should live either in the declaration d.ts file or in the compiled distribution files. These comments provide explanations of functions, parameters and other things a consumer of the API can use.
My ideal situation:

Regular comments used for development and JSDocs with @internal are not outputted to the disctribution files.
The docstring or JSDoc is outputted to the d.ts file.
The docstring or JSDoc is optionally outputted to the .js file.

Since VSCode looks at the d.ts files for documentation, emitting the JSDoc to d.ts files should have priority.
This could use the tsconfig suggestion @championswimmer made.

I was looking at releasing a typescript library and was really surprised when my comments were either being stripped altogether or completely left in. Having intellisense would be really helpful to end users, but a lot of comments just makes the package size larger.
Though, it did help explain why so many of my third party libraries have nice types but no intellisense documentation.
Is there anything we can do as a community to move this forward? I see official comments, but no confirmation about how to resolve. Given that the proposed solutions are bigger (maybe) not backwards-compatible changes, maybe getting buy-in from one of the core team is important before starting work?

Question
Should JSDoc comments be stripped from public APIs of compiled output *.js files?

While I'd be happy with @championswimmer's suggestion, I don't see that as compatible with existing options. Based on one discussion that I've had with some on the TS team, one high priority is keep consistent non confusing compiler options. Therefore I'm betting that adding a comments option alongside the existing boolean removeComments option is a non-starter.
Backwards Compatible Solution
What if removeComments was expanded from boolean to boolean | 'none' | 'code' | 'internal' | 'all'?
if (removeComments === false) removeComments = 'none';
if (removeComments === true) removeComments = 'code';

none - Preserve all comments
code - Preserve copyright comments
internal - Preserve JSDoc and copyright comments
all - Remove all comments

Alternative
As the removeComments option does not remove /*! comment blocks, we could add an extra option like preserveJSDocComments that would preserve the appropriate comments when removeComments is set to true.

I was going to submit a separate issue, but I believe mine is related. Why can't TypeScript give us docstrings?

HAPPY TWO YEAR ANNIVERSARY.
@RyanCavanaugh (or anyone else at Microsoft): are you going to respond or just :-1: this too?
Looking at recent releases I'm getting tempted to look at Kotlin for JS now.  Building and using libraries in with Typescript is still way off from the simplicity and consistency of Java/Maven ecosystem.
Now that MS has control of NPM too, then isn't this an opportunity to bring the JS ecosystem up.
But until then... can we please have this simple feature to retain JSDoc... PLEASE!

hope one day something like this can be merge
https://github.com/microsoft/TypeScript/pull/31813

Official TypeScript documentation describes the implementation of JSDoc without mentioning this behavior. I think the implicit behavior should be something such as the solutions described above, but the documentation should explicitly describe the behavior.

I'm sure a pull request (with test-coverage and documentation) wouldn't be rejected by the team - this is one of those "duh, obvious" features no one can really object to.

The feature itself is probably something like changing the type of removeComments to something like true | false | "preserve-doc-blocks", then testing for that in the condition here - but also, the test-suite needs to be updated, and doesn't seem to have test-coverage for removal of comments in the first place, so that probably needs to be added first, the feature needs documentation, and so on.
Iterating on a codebase of this size and complexity is never quick or easy - there are only so many developers working on this, and I'm sure they have priorities, and yeah, sometimes apparently simple things take more than two years. If you think it's so easy, why don't you do it and submit a PR 😀

Currently, all comments are removed from d.ts when removeComments  is false. Am I missing anything?

playground

@Zzzen yes, you are
this is about JSDoc comments specifically

😕  Do you mean normal comments are never preserved by design?

in a declaration file?
of course they are not

So do you have any idea why // interface Foo is removed in .D.TS section? @thealjey

@Zzzen, because "// ..." is not a valid way for JSDoc to begin.
JSDoc must begin with /**.
From the JSDoc getting started guide:

Each comment must start with a /** sequence in order to be recognized by the JSDoc parser. Comments beginning with /, /**, or more than 3 stars will be ignored. This is a feature to allow you to suppress parsing of comment blocks.

My proposal: deprecate "removeComments", strip comments from output JS iff source maps are enabled.

My proposal: deprecate "removeComments", strip comments from output JS iff source maps are enabled.

Why not just unify the behavior of removeComments? If removeComments is false, preserve all comment in .d.ts and .js, otherwise strip all comment.

Why not just unify the behavior of removeComments? If removeComments is false, preserve all comment in .d.ts and .js, otherwise strip all comment.

There is a way to keep the comments in declaration files only and stripping them from the js files. But it's a little inefficient.
Basically, you'll need two tsconfig files.

tsconfig.json: Base tsconfig file
tsconfig.nocomments.json, which will have the following content

{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "declaration": false,
    "removeComments": true
  },
}

Now, while in development run the base tsconfig file, which will preserve the comments in .d.ts and .js files. But during production, run the base tsconfig file first, then the nocomments one. An example npm scripts could be:-
"scripts": {
  "build": "tsc",
  "build:nocomments": "tsc -p ./tsconfig.nocomments.json",
  "prod": "npm run build && npm run build:nocomments"
},

Running npm run prod, will first generate .d.ts and .js files with comments, then it will generate only .js files without comments since removeComments is set to true and no .d.ts files since declaration: false, thus keeping the same commented .d.ts files.
All thanks to this original post in dev.to.

End 2021 and nothing on this... still embarrassing.

hope this feature

jsdoc @deprecated gets stripped off from d.ts files. but this is quite important thing.

Is this going to be fixed

So this problem became something big? 😪
I thought I could fix it in 5 minutes of googling
If you are here searching for an answer to this issue, DONT typescript does not support it!

This suggestion has been in discussion for over half a decade (specifically: 2,041 days at the time of writing).
@RyanCavanaugh do you and your team plan to show an interest in features the community have actively wanted for 2041 days, or will you continue to ignore it for another five years?
This feature is simple, highly requested, and is actually a bug report (@deprecated gets removed from dist code, not good enough). Many people, myself included, are getting increasingly tired of the TS team ignoring their users, we don't want TC39 to make : string a comment, we want this extremely small and simple request to be completed by someone, it will take mere minutes to do yourselves, or even less time to click "merge" on an already submitted PR (this bug was fixed 3 years ago and is still not fixed in production, astounding!)

@willster277 A workaround using project references: https://github.com/webstrand/typescript-remove-comments-not-from-declarations
Running tsc --build causes the .js files to be generated with "removeComments": true and the generation of .d.ts files is deferred to a sub-project which then generates them without "removeComments": true.

@webstrand it's shocking that we have to use 3rd party libraries to fix a Microsoft product.
Actually, it's exactly what I expect from Microsoft, which is arguably even worse.

@willster277 Actually that's not 3rd-party. The repo's just an example of how to set the project up.

@webstrand my bad I'm on mobile, I thought you had sent a fork/project.
I have done this before, but it's not ideal. It would be much better if Typescript didn't destroy information.

I use TypeScript to generate definitions for my JS source files (for use in libraries), and the lack of carryover from JSDoc comments on functions was disappointing. Since it doesn't seem this will be supported any time soon, I built a post-build script that copies over the JSDoc comments (less redundant type info) for functions declare in the .d.ts type files.
If anybody is interested in trying this approach, I've dropped the script in a gist here: https://gist.github.com/coreyward/e70642a41e2181641a817a632a82cd2d

removeComments: true,
preserveJSDoc: true

Hope it can be implemented like this.

One helpful thing would also be to remove type declarations within the preserved JSDoc comments as they're redundant, and may cause issues sometimes.
Additionally, sometimes I use /** @typedef {import('./module.js').Type} Type */ to locally import types, and it's left in verbatim. Pseudo-imports like that should be turned into actual imports ideally.

A sane workaround:
tsc --removeComments && tsc --emitDeclarationOnly

With tsconfig.json options:
"removeComments": true,
"declaration": true,

This being wanted and not being implemented for about ten years is just sad. Classic Microsoft! 🎉🎉

A sane workaround:
tsc --removeComments && tsc --declaration --emitDeclarationOnly

With tsconfig.json options:
"removeComments": false,
"declaration": false,

Builds stripped JS, then emits declarations with JSDoc preserved.

Could you explain this workaround? I have many projects already underway and I really need the d.ts to gain the comments. It seems like this solution requires a deep understanding of how the tsconfig.json options actually interact with command line flags, which I was hoping to avoid as the idea should be that anything you could specify in cli flags should also be configurable via config file...

@unphased It is a simple 2-step build:

the actual build

removeComments strips all the comments from the code
declarations are not generated just yet (declaration: false in tsconfig)

declaration emission

declaration tells tsc to generate d.ts files
emitDeclarationOnly prevents javascript from rebuilding

Options passed via command line override the ones in tsconfig.json, there's not much more to this honestly

I figured it out. With my existing setup all I had to do was adjust my comments to Jason/javadoc style with /** and it works well.


Shortcuts to enable / disable profiles and key blocking

It would be cool if there were ways to start / stop a profile using shortcuts or keybinds. In addition, it would be nice to be able to just temporarily disable blocking globally. It's a feature I make use of now in MouseTovJoy when playing racing games so I can block mouse movements while driving but unblock while in menus.

Yes disable blocking globally through a keybinding shortcut would be awesome.


feat!: Add Function status

Related issue
# followed by the number of the issue
Summary
Notes
Please check if the PR fulfills these requirements

[ ] If necessary, the changelog has been updated
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] The commit message follows the conventional commit specification
For any breaking changes, companion PRs have been opened on the following repositories:

[ ] substra-tests
[ ] substrafl
[ ] substra-documentation

You most likely need to change the backend so it is returning the function status


Add the option to define project metadata

For proofreading projects. Fields include: language, publication year, editor, ...

Added in fdfe07fc297317105c81430275ed648f5c368b80.


Documentation: Organize commands in the reference alphabetically [userstudy]

I believe this has been fixed for a long while. Please reactivate if I am missing something:
e.g.:

http://googlecloudplatform.github.io/google-cloud-powershell/#/
http://googlecloudplatform.github.io/google-cloud-powershell/#/google-compute-engine
http://googlecloudplatform.github.io/google-cloud-powershell/#/google-compute-engine/GceImage


Kubernetes config and doc updates

@thompsonja

Tagging @michael-berlin since @thompsonja is sick today.

LGTM

Published.


Valid TLD Not Parsed

parseDomain(""xn--90abvrccwbp.xn--p1acf")
The above will return null.  .xn--p1acf is a valid TLD -> https://www.iana.org/domains/root/db/xn--p1acf.html

You will have to convert from punycode back to utf since the tld list is in utf. @jhnns correct?

Thanks for reporting this. Yes, with the current version, you will need to translate the Punycode to Unicode because the internal list of domain names is using Unicode.
However, this will change with the next major version bump (see #14). We will only accept sanitized hostnames (basically those from new URL(url).hostname).

Fixed with v3.0.0 🚀


Disabled packages are synced and activated

When I sync a new atom installation, all the packages are synced and installed as expected.
The only thing that bothers me is that they're all active, even the one that I have disabled on other computers (because they drop my PC performance a lot, and I activate them only when needed. i.e. atom-typescript)

Duplicate of #92.


Please upgrade to ugorji/go/codec v1.1.1 containing 32-bit fixes (when available)

Hello,
The upcoming release of ugorji/go/codec contains fixes for 32-bit architectures:

ugorji/go#232: Failed to use CBOR encoding when compili(n)g for GOARCH=386
#890886 - golang-github-ugorji-go-codec FTBFS on 32bit: constants overflow int - Debian Bug report logs

Also, ugorji/go/codec now supports time.Time natively as per latest MessagePack specification:

ugorji/go#224 and ugorji/go#225
ugorji/go@8badb25: codecgen: support time.Time natively, and handle omitEmpty for structs
https://github.com/msgpack/msgpack/blob/master/spec.md#timestamp-extension-type

though the following new errors may appear due to the change in codecgen generated code:
client/keys.generated.go:474:23: cannot use x.Expirat
ion (type *time.Time) as type time.Time in argument to r.encDriver.EncodeTime
client/keys.generated.go:494:23: cannot use x.Expiration (type *time.Time) as type time.Time in argument to r.encDriver.EncodeTime

And here is my suggested patch to client/keys.go and client/keys_test.go to match the changes to time.Time support in the latest ugorji/go/codec:
--- a/client/keys.go
+++ b/client/keys.go
@@ -301,7 +301,7 @@
 	ModifiedIndex uint64 `json:"modifiedIndex"`

 	// Expiration is the server side expiration time of the key.
-	Expiration *time.Time `json:"expiration,omitempty"`
+	Expiration time.Time `json:"expiration,omitempty"`

 	// TTL is the time to live of the key in second.
 	TTL int64 `json:"ttl,omitempty"`
--- a/client/keys_test.go
+++ b/client/keys_test.go
@@ -718,7 +718,7 @@
 					ModifiedIndex: 12,
 					CreatedIndex:  10,
 					TTL:           10,
-					Expiration:    &expiration,
+					Expiration:    expiration,
 				},
 				PrevNode: nil,
 			},

Many thanks!
P.S. In case you were wondering, we, the Debian Go Packaging Team, were trying to fix this bug that we encounter on Debian (and Ubuntu) #890939 - etcd FTBFS - Debian Bug report logs where vendoring is not used.

@anthonyfok Is *time.Time type change really necessary? I worry about backward compatibilities.

Oh, doesn't even compile. So that change has to happen...

@ugorji Is changing *time.Time to time.Time necessary? Is there anyway to make it work without changing it? I tried latest codecgen but our client cannot be compiled with *time.Time field.

I'm away celebrating Easter, and can look at this as early as April 5.

@gyuho please try again and let me know if this is fully fixed on tip. If it is, I will do some sanity testing and tag a<EMAIL_ADDRESS>release this weekend.

@gyuho please try again. Should be fixed now with ugorji/go@b4c50a2

@ugorji Could you release v1.1.1? We regenerated with https://github.com/ugorji/go/commit/f3cacc17c85ecb7f1b6a9e373ee85d1480919868, and it works (see https://github.com/coreos/etcd/pull/9494).
Thanks!


Default proxy target for dev server in webpack.config.js

Hello,
when I was setting up the dev env for the frontend, I needed to change the proxy target from 3001 to 1337 in webpack.config.js.
Here is the original setup for the devServer key in the file:
...
devServer: {
        static: {
          directory: path.join(__dirname, 'public'),
        },
        proxy: {
            '**': {
                target: 'http://localhost:3001',
                bypass: (req) => (req.headers.accept.includes("html") ? "/" : null)
            },
        },
        compress: true,
        hot: true,
        port: 3000,
    },
...

Link to the file:
https://github.com/twilio-labs/dev-phone/blob/ae08110f3d551b2fbd12c980268df7b2c65aa174/packages/dev-phone-ui/webpack.config.js#L21C9-L21C9
I suggest changing to 1337 permanently. This would be nice for newcomers like me, just to run the command without editing the original port.
Let me know, if it does make sense and I will do a pull request.

@hatealgebra yep, this makes sense. I think it's a missed detail from #138 - thanks for catching it!

Hi @ayyrickay,
I Iust wanted to push changes to the separate branch for this issue, but I get the permission denied error on the push. I need to be added to the team/repo right?
Thanks.

@hatealgebra You should be able to create a fork of this repository and open pull requests that way. It'll feel a bit clunky at first, but you can see how it works here: https://docs.github.com/en/get-started/quickstart/contributing-to-projects

Hello @ayyrickay thanks for the link! I've created and linked the PR to this issue. If I did not align with best practises, please let me know! :)

@ayyrickay
Hi, I've closed this issue since the PR is closed. Hope you don't mind


Send automated email when a project is successful

@26damb : is this closed, right? Is there any specific reason for having this PR open?


[ENH] Add option for both TOPUP and DRBUDDI

When there are full dwi acquisitions in both phase encoding directions, Eddy has trouble with replacing outliers. It will use the distorted images from the wrong PED and cause bright bands in the image.
Using TOPUP before Eddy will prevent this from happening. Using DRBUDDI afterwards will hopefully also fix and CST problems.

closed by #667


Author unable to see translations, even when linked directly

Usually an author cannot see one of my translations, but it can complete the approving process if I feed him/her the direct link.
This does not seem the case for this kata.
Translations are regularly visible, forkable and of course editable by me:

I am able to see both translations under the "+" tab but when I try to select either of them I get the 500 error. I also receive a 500 error when selecting the direct links provided by GiacomoSorbi in our discourse.
Uh oh! Something went wrong! (500)
We have taken note of the situation and will be looking into it. We are still a beta product.
If you would like to supply us with some details as to how this happened please Email Us. This will help us get things fixed faster.

This still has not been corrected and Giacomo worked hard on translating the Kata into Javascript and Ruby. Will someone please try to resolve the issue so the translations can go live?

Not really sure I understand what the issue was but I was able to approve both translations for you. Thanks for letting me know.

I'll leave this open so that I can investigate further later.

This does not appear to be happening anymore -- maybe close it?


Find Test messages for all possible Structure Profiles

We need test messages for:

Phin Spec 2.0
~Phin Spec 3.0~
~Phin Spec 3.1~
~GenV1 Summary~
GenV1 Case
Legacy MMGs. (Arbo for demo; tuberculosis and varicela later)
~lab template~

(We need to identify what's the correct MSH-21[1] for those message)

Test messages for various legacy MMGs can be found here (these TM's will not be inside MMGAT, but instead were hand-crafted):
Arboviral 1.2.0: https://ndc.services.cdc.gov/wp-content/uploads/2021/02/arbo_notification_test_cases_011413-1.xlsx
Arboviral 1.3.0: https://ndc.services.cdc.gov/wp-content/uploads/2021/02/Arboviral_V1.3_TS_F_R12_20171005.xlsx
Arboviral 1.3.1: https://ndc.services.cdc.gov/wp-content/uploads/2021/02/Arboviral_V1.3.1_TS_F_20200724.xlsx
Arboviral 1.3.2: https://ndc.services.cdc.gov/wp-content/uploads/2021/02/NMI_arboviral_test_case_scenario_worksheet_20200724.xlsx
Arbo also has a generic Test Message Package for testing messages across all 1.3.x:  https://ndc.services.cdc.gov/wp-content/uploads/2021/02/Arboviral_V1.3_TM_F_R9_20171005.zip
Tuberculosis 2.0.3:  https://ndc.services.cdc.gov/wp-content/uploads/2021/02/tb_v2.0_test_case_scenarios_03302009.pdf
Varicella 1.0:  can't find specific TMs on this unless embedded deep in doc on website where old stuff lives:  https://ndc.services.cdc.gov/mmgpage/varicella-message-mapping-guide/
Varicella 2.0:  https://ndc.services.cdc.gov/wp-content/uploads/2021/02/varicelladiseasespec-notification-test-cases.pdf
Varicella 2.0.1:  https://ndc.services.cdc.gov/wp-content/uploads/2021/02/varicelladiseasespec-notification-test-cases.pdf

Most links are for the Message Guides, not test messages.
I opened the arobviral_v1.3_TM_F_R9_20171005.zip and I see some example messages there...
All those messages have a MSH-21[1] of NND_ORU_2.0 (Phin Spec 2.0?) and a MSH-21[2] of Arbo_Case_Map_v1.0
So can we valdiate the arbo 1.3.x with PHIN Spec 2.0?
Also, where can we find actual test messages?

Make sure you are scrolling all the way over to the right side of the spreadsheet.  That's where the TMs live.  Marcia has done PHIN spec in 2.0 but we don't have machine readable versions of Arbo yet.

Gen v1 test messages based on the Test Scenarios worksheet for Gen v1 Case Notifications have been generated and added to resources folder.

Leslyn to contact programs to obtain Legacy and Gen v1 test messages.

Updated "Older MMGs" tab with values for MSH-21[2].1 as found in the spec spreadsheets/PDFs.
"MMGs in Prod" Spreadsheet

Karen Chung's team will be generating test messages during the Oct 6 - 19 sprint timeframe.

@manandappa I'm going to let you own this and update as you wish


Guard add_test calls with MFEM_ENABLE_TESTING

This came up in Serac where we are optionally using MFEM as a submodule and our CMake build system uses add_subdirectory to speed up co-development builds.
During our default development workflow, we do not want to build MFEM's examples or tests directly. However,  without this change, MFEM's tests are added to Serac's tests but they are not being built, which causes our tests to fail.
This PR guards all add_test calls with your already existing option MFEM_ENABLE_TESTING.

Thanks @white238 !
We're seeing the same problem in a library that I work on (tribol), which also has a CMake-based build system and uses mfem as a submodule.

@white238, when this is ready please mark with ready-for-review, see https://github.com/mfem/mfem/blob/master/CONTRIBUTING.md#quick-summary

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Merged in next for testing...


import vec into zenlink-protocol

Signed-off-by: Gregory Hill<EMAIL_ADDRESS>Seeing some compiler errors without this: https://github.com/interlay/interbtc/actions/runs/3712690400/jobs/6294498248

LGTM


.net/c# sdk for OpenFeature

Language
.net/c#
Willing to Implement

[X] I'm willing to help implement the Flipt Server SDK in this language if it's accepted. 🙌

Willing to Review

[X] I'm willing to review contributions to the Flipt Server SDK in this language if it's accepted.

Additional Notes
Hi!
We're looking to implement OpenFeature for a javascript and .net app we have in-house. We'd love to use flipt as our feature backend, but while OpenFeature supports .net, flipt currently does not. We'd love to contribute to help this project, if possible.

Would love help with a c# client!! We are pretty inexperienced with c# so would love someone who knows it better to get the ball rolling.

C# SDK https://www.nuget.org/packages/Flipt/
Now just need to wrap it in OpenFeature SDK

Done! https://github.com/open-feature/dotnet-sdk-contrib/tree/main/src/OpenFeature.Contrib.Providers.Flipt


Accessibility problem with code examples

The code examples on this page are all images of text, this is not accessible. The alt text also does not convey the information in the image, it's not helpful to know that the image is an example code block if you then can't read the image.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce15a28b-de8a-cbe1-a824-b16915cd21d2
Version Independent ID: 7e210e31-7eb8-f7ee-0dee-9978f2452e10
Content: Azure role assignment condition format and syntax (preview) - Azure RBAC
Content Source: articles/role-based-access-control/conditions-format.md
Service: role-based-access-control
Sub-service: conditions
GitHub Login: @rolyon
Microsoft Alias: rolyon

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

Hi @jfharden
Thanks for your feedback. We've added code blocks for the code that is used in the images.
https://docs.microsoft.com/en-us/azure/role-based-access-control/conditions-format
Let us know if you have additional feedback.
thanks

#please-close

That is excellent, thank you for the swift resolution.


Button Edges Not Vertically Aligned with Default Tile Features

Checklist:

[X] I updated to the latest version available
[X] I cleared the cache of my browser

Release with the issue:
v1.1.0
Last working release (if known):
NA
Browser and Operating System:
Windows 10 / Brave, Android / HA app

Description of problem:
Margins on edges are too large and do not match HA native tile features

Javascript errors shown in the web inspector (if applicable):
NA

Your Full Remote Config
features:
  - type: fan-speed
  - type: custom:service-call
    buttons:
      - service: fan.decrease_speed
        icon: mdi:fan-chevron-down
      - service: fan.increase_speed
        icon: mdi:fan-chevron-up
type: tile
entity: fan.lounge_ceiling
name: Ceiling Fan
vertical: false
card_mod:
  style:
    hui-tile-features$:
      hui-fan-speed-tile-feature$: |
        ha-control-select {
          {% if is_state("fan.lounge_ceiling", "off") %}
          --control-select-color: #484a4e !important;
          {% endif %}
          --control-select-background: #050505 !important;
        }

Additional information:
Current CSS margin was set to match the width between cover buttons. This margin is fine for the space between buttons but not the edge between the first/last button and the edges of the tile card.

Fixed in https://github.com/Nerwyn/service-call-tile-feature/releases/tag/v1.2.0


🐛 Voting transaction composition fails on certain cases

Area
Voting Pillar
Domain
preview.gov.tools
Which wallet were you using?
No response
Context
Sometimes the voting transaction composition fails citing bad specs when wrong UTXOs are selected to compose the transaction.
Steps to reproduce
Reproduction is a bit difficult.
This happens when there are multiple single Ada UTXOs and these are UTXOs are selected on transaction composition.

Go to any Gov Action that can be voted on
As a DRep vote on the Gov Action
If the transaction composition fails, you'll see an error message with bad specs error.

Actual behavior
The transaction composition fails thus failing the user to vote on the gov action.
Expected behavior
The transaction composition is successful and thus the voting

I can't reproduce that issue. Are you able to provide loom, or error log? Maybe some suggestion on the selection strategy that we should use based on the CIP-2

@spannercode any additional ideas?


Education: update Gremlin blog links

A couple of the links in Education had updated, two of them without re-directs. Thought it'd be easier to steer the traffic directly without the additional search :)

Thanks for your contribution!


[tool_crash] FileSystemException: Cannot copy file to 'C:\Users\JUN\Desktop\dart\new1\android\app\src\main\res\mipmap-hdpi\ic_launcher.png', OS Error: Access is denied., errno = 5

Command
flutter create new1

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot copy file to 'C:\Users\JUN\Desktop\dart\new1\android\app\src\main\res\mipmap-hdpi\ic_launcher.png', OS Error: Access is denied.
, errno = 5
#0      _File.throwIfError (dart:io/file_impl.dart:635:7)
#1      _File.copySync (dart:io/file_impl.dart:340:5)
#2      ForwardingFile.copySync (package:file/src/forwarding/forwarding_file.dart:30:50)
#3      ForwardingFile.copySync (package:file/src/forwarding/forwarding_file.dart:30:50)
#4      Template.render.<anonymous closure> (package:flutter_tools/src/template.dart:267:18)
#5      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:377:8)
#6      Template.render (package:flutter_tools/src/template.dart:190:24)
#7      CreateCommand._renderTemplate (package:flutter_tools/src/commands/create.dart:799:21)
#8      _rootRunUnary (dart:async/zone.dart:1198:47)
#9      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#10     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#11     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#12     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#13     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#14     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#15     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#16     Template.fromName (package:flutter_tools/src/template.dart)
#17     _rootRunUnary (dart:async/zone.dart:1198:47)
#18     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#19     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#20     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#21     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#22     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#23     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#24     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)

[✓] Flutter (Channel stable, 1.22.5, on Microsoft Windows [Version 10.0.19041.685], locale en-US)
    • Flutter version 1.22.5 at C:\flutter
    • Framework revision<PHONE_NUMBER> (4 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Android
    ✗ Flutter requires Android SDK 29 and the Android BuildTools 28.0.3
      To update the Android SDK visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.
    • All Android licenses accepted.

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] VS Code (version 1.52.1)
    • VS Code at C:\Users\JUN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.18.0

[!] Connected device
    ! No devices available

! Doctor found issues in 3 categories.

Flutter Application Metadata
No pubspec in working directory.

Closing this as duplicate of https://github.com/flutter/flutter/issues/69116

Closing this as duplicate of https://github.com/flutter/flutter/issues/69116


Kite plugin for pycharm does not show quick documentation and popular patterns.

Hello,
I am using Pycharm 2018.2.4 on Windows 10.
Kite version: 1.2018.1004.0
The quick documentation pop up for identifiers are not showing the Kite enhanced documentation (that includes function signature, parameters and popular patterns). On the invocation of view quick documentation, no documentation is popping up.
The IDE is configured so that quick documentation is enabled, so no problem on that side.

Hi @nombreinvicto
Thanks for your inquiry into this matter. This decision wasn't made lightly so I wanted to provide an in-depth explanation for the product change.
TL;DR - We made the tough decision to discontinue support for documentation inside the editor so that we could focus our efforts on providing the very best Python autocompletions.
As you might know, Kite integrates with 5 different editors. Getting any feature right in a single editor is hard enough, and getting it right in 5 editors is at least 5 times as hard. Given our small team size, we needed to figure out how to utilize our time more appropriately and when we thought about which features would create the most value for our users going forward, it became clear that developing smarter and more context-aware autocompletions would be much more transformative in the long run than maintaining documentation in the editor. We're currently investing a lot of resources into improving our static analysis and machine learning models, and we're very excited at the prospect of shipping more advanced autocompletions for our users.
In the meantime, documentation will still be available in the Copilot and in our Webdocs. While we've also poured a lot of time and effort into these 2 products, we realize that they may not be perfect replacements and we sincerely apologize for the inconvenience. However, we remain committed to our mission of building tools to help you code more efficiently and we're confident our increased investment in AI-powered autocompletions will prove to be useful to you in the coming months.

@dhung09
Thanks for the feedback!
Kite is awesome and I hope it comes with more awesome features in the future. In the meantime, it would be great if the github documentations were up to date. They still reflect some older features which could be misleading.

Thank you for the support! We're working hard to improve all of our plugins including UI/UX, new features and of course documentation. 🙂 Stay tuned!


[Feature] Add Greenmim Inference

Motivation
GreenMIM Support
Modification

backbone: add swintransformer with greenmim
head and neck: add some features

Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

Please do not forget to fix the lint.

Please remove mmselfsup/models/losses/greenmim_loss.py to ./project

Please add a README in projects/greenmim. You can refer to projects/fgia_accv2022_1st/README.md


I always get this error while trying to use laravel/ui with laravel 8, in "npm run dev" step while mixing, but it work fine with laravel 7

Laravel Mix Version: #.#.#<EMAIL_ADDRESS>Node Version (v14.16.1):
NPM Version (6.14.12):
OS: windows 10

Description:

@ dev D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister
npm run development

@ development D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister
mix

× Mix
Compiled with some errors in 257.38ms
ERROR in ../../../../../../#PROJECTS/Web developing/@Back-End Projects/<EMAIL_ADDRESS>Module build failed: Error: Cannot find module 'D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>Require stack:

D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\v8-compile-cache\v8-compile-cache.js:159:20)
at D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\ProgressPlugin.js:412:9
at Hook.eval [as call] (eval at create (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\tapable\lib\HookCodeFactory.js:19:10), :7:1)
at Hook.CALL_DELEGATE [as _call] (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\tapable\lib\Hook.js:14:14)
at NormalModule.doBuild (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\NormalModule.js:724:24)
at NormalModule.build (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\NormalModule.js:878:15)
at D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\Compilation.js:1311:12

ERROR in ../../../../../../#PROJECTS/Web developing/@Back-End Projects/<EMAIL_ADDRESS>Module build failed: Error: Cannot find module 'D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>Require stack:

D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>D:#PROJECTS\Web developing@Back-End Projects<EMAIL_ADDRESS>at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\v8-compile-cache\v8-compile-cache.js:159:20)
at D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\ProgressPlugin.js:412:9
at Hook.eval [as call] (eval at create (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\tapable\lib\HookCodeFactory.js:19:10), :7:1)
at NormalModule.doBuild (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\NormalModule.js:724:24)
at NormalModule.build (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\NormalModule.js:878:15)
at D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\Compilation.js:1311:12
at NormalModule.needBuild (D:#PROJECTS\Web developing@Back-End Projects@laravel@cloned\checklister\node_modules\webpack\lib\NormalModule.js:1143:32)

webpack compiled with 2 errors
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ development: mix
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ development script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\abdulbasit-dev\AppData\Roaming\npm-cache_logs\2021-04-26T14_11_33_148Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ dev: npm run development
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\abdulbasit-dev\AppData\Roaming\npm-cache_logs\2021-04-26T14_11_33_222Z-debug.log
Steps To Reproduce:

It looks like it can't find babel-loader. Not sure why that'd be.
I will note that, unfortunately, Windows paths with spaces and npm don't mix well. We tried to work around a few of these bugs but apparently there are still more. In the mean time my suggestion is to try a path that doesn't include any spaces in any folder all the way up to the D: drive. Let me know how that goes?

it still gives me error, even I moved the project to the htdoc in c drive some problem and I removed all the spaces in the path "/d/#PROJECTS/Web-developing/@Back-End_Projects/@laravel/@cloned/checklister"


fix: remove make recommendation from reval admin role

There are 3 roles in revalidation arena. They are "RevalApprover", "RevalAdmin" and "RevalObserver". Reval approver can read, write and make recommendation, Reval admin can read and write but should not be allowed to make recommendation. This fix will take care of that.
Reval Observer has only read permission, which has already been handled in the app.
For more info, please refer to this page
https://hee-tis.atlassian.net/wiki/spaces/NTCS/pages/1671495738/Revalidation+-+Access+Permissions
TIS21-2272

It looks good to me. Just a small discussion, the existing FE code is putting the role into the constants.ts so the permission setting can be shared to use in different places of the FE. https://github.com/Health-Education-England/TIS-REVALIDATION-V2/blob/master/src/environments/constants.ts. Just think do we consider doing in that way?

It looks good to me. Just a small discussion, the existing FE code is putting the role into the constants.ts so the permission setting can be shared to use in different places of the FE. https://github.com/Health-Education-England/TIS-REVALIDATION-V2/blob/master/src/environments/constants.ts. Just think do we consider doing in that way?

Thanks @DorisWongNHS I have made changes. Please have a look.


[Story] Explore security best practices for GitHub Actions

What product(s) is this story for?
Sage Monorepo
As a user, I want
No response
Description
Sage Monorepo is a public repo that accept PRs from outside of the organization. The goal of this PR is to explore the security risks associated with the use of GH secrets.
Acceptance criteria
No response
Tasks

[ ] Explore the security risks surrounding the Sonar secret: who can access the secret, should the security be tighten, if yes, how?

Anything else?
References:

This SO post that references different strategies
GitHub: Using environments for deployment
GitHub: Security hardening for GitHub Actions
https://github.com/step-security/harden-runner

Have you linked this story to a GitHub Project?

[X] I have linked this story to a GitHub Project and set its metadata.

About Sonar

On SonarQube, we now have analysis tokens (projects bound, or global) in addition to the standard user tokens

Source
Analysis tokens don't seem to be available for SonarCloud:

SCCOMM-11: Users should be able to create analysis token
Product Roadmap entry for analyzing external Pull Requests (you can also vote there for this feature)

Other projects are tracking the issue of not having access to analysis tokens:

https://github.com/junit-pioneer/junit-pioneer/issues/581

This repository is now using a Sonar token that only has the permission to execute analysis.


macvim: 8.2.319 -> 8.2.539

Motivation for this change
https://github.com/macvim-dev/macvim/releases/tag/snapshot-163
This also includes a fix for compatibility with Xcode 11.4. Xcode 11.4 has an updated sys/_types/_fd_def.h header that references a new symbol from libSystem. This is a problem because we're using /usr/bin/clang to compile the non-Xcode portion, and this
pulls in headers from Xcode's SDK. Somehow it's still linking to the Nix libraries. The end result is we get a linker error where this new symbol can't be found at link time, even though it's a weak import and isn't required at runtime.
Ideally we'd provide a full 10.12 SDK to /usr/bin/clang, but we can't do that because even the DevSDK package we use for our 10.12 SDK doesn't contain everything (in particular it's missing nearly all dylibs) so we just get linker errors if we do that.
Instead we'll just strip the LDFLAGS post-configure so it no longer references the Nix versions of OS libraries. This means we're not linking against Nix libSystem anymore, and that fixes the link error. This also prevents this issue from cropping up again in the future.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I took another look at the built product and the Vim binary links against Nix libSystem but the MacVim binary (compiled with Xcode) is linking against the OS-provided libraries. And I guess it's been this way all along.
I don't know if we should just give up and figure out how to make Vim use the system libSystem, or if we should fixup MacVim to link against Nix libSystem, or just ignore it since it doesn't really seem to matter.
Eventully we should look into using xcbuild to compile this stuff instead, now that we're no longer invoking ibtool, but I don't know if it will work.

I dug into xcbuild and I'm getting an opaque failure in actool. I don't know what's wrong, and xcbuild doesn't really seem to be actively developed anymore.

Since xcbuild has too many issues to use, I went ahead and pushed a commit that gets rid of the fake libSystem header and instead just strips all the Nix linker paths for OS libraries out of LDFLAGS. This means we're doubling down on using Xcode's SDK to compile, but that's what we've mostly been doing this whole time, and this should prevent future Xcode versions from breaking the package again.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/146

I changed the postConfigure error into a warning instead.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/152

@lilyball Sorry, can't really review this. Merging assuming this is working well for you.


Docked webctrl on a channel - Mouse Wheel Scroll Not Working

Hi,
as in the topic, I've created a docked webctrl on a channel, loaded a page and the mouse wheel scrolling on the page does not work. If I undock the control (dialog) mouse wheel scrolling starts to work.
I've skimmed through the xDock (UltraDock) code and noticed this:
"mIRCTEXT('s channel/query/status window')s scrollbar isnt a system scrollbar so these functions fail."
is that the reason scrolling does not work?
Is there a fix, or a workaround so the scrolling works in the docked webctrl?
I'm using DCX (XPopup) DLL 2.0.1120 Development Build23 UTF, mIRC v7.32, Win7 x64.
Thanks.

Please provide minimum code required to reproduce this bug.


Confused by  the "synthetic data" in your Data Pump code

Hi dear Brian,
I'm a bit confused by the " Synthetic Data" in your 01 - Data pump.ipynb file. If I'm not mistaken, in your 00 - Augmentation.ipynb file you have a separate directory for the audio files and another one for the corresponding annotations. In the 01 - Data pump.ipynb file you build two separate pumps, one for the original audio files and their annotations and one for the augmented audio files and their annotations and transform and save each of those two separately. But after that, there is a code snippet that deals with synthetic data that lies in a completely different folder!
Are these " synthetic data" midi-synthesized audio files ?? I assume I won't need them and having the audio files and their annotations is enough to keep me going?
Thanks in advance and with best regards,
H.F

But after that, there is a code snippet that deals with synthetic data that lies in a completely different folder!
Are these " synthetic data" midi-synthesized audio files ?? I assume I won't need them and having the audio files and their annotations is enough to keep me going?

Good catch!  This is a hold-over from some earlier experiments with synthetic chord templates (not even midi files) that we were trying to use to train the decoder.  This didn't make it into the final version of the paper, and it's safe to ignore this bit.

Thank you very much!


Not possible to close single Events Table

If the Events Table is the only open view, its 'X' button does not work so the view can't be closed.
https://user-images.githubusercontent.com/28311615/149538529-bf90ac86-b1d5-4113-9d88-583fcf69d0c2.mp4

It's actually possible to close the table. However, for some reason if only one view is open then the button is not active when hovering centered but only when hovering to the side (see video). This needs to be fixed so that it works better.

Not related to the hit area of the close box: I’m wondering if the blue selected state of the Events Table item in the left panel should go to black when the table is closed? It would help teach This is what’s selected and visible.
From: Bernd Hufmann @.>
Date: Wednesday, January 19, 2022 at 8:52 AM
To: theia-ide/theia-trace-extension @.>
Cc: Subscribed @.***>
Subject: Re: [theia-ide/theia-trace-extension] Not possible to close single Events Table (Issue #618)
It's actually possible to close the table. However, for some reason if only one view is open then the button is not active when hovering centered but only when hovering to the side (see video). This needs to be fixed so that it works better.
[close-single-events-table]https://user-images.githubusercontent.com/413424/150154750-61edf245-602d-4747-9628-cdb922099644.gif
—
Reply to this email directly, view it on GitHubhttps://github.com/theia-ide/theia-trace-extension/issues/618#issuecomment-1016540977, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAIOFFQVS66RTAXLGFDZJJ3UW3FV3ANCNFSM5L7BYWIA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Dragging tab also drag split icon

use tabs, open many such that it shows a scrollbar
scroll all the way to the right
move the last tab around

Interesting, looks like an issue with how Chrome decides to come up with a drag image.


bug: InjectedConnector produces different results with Coinbase Wallet after 0.12.x

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.2.1
Current Behavior
Not sure if this is an issue with wagmi's InjectedConnector or Coinbase Wallet. Apologies for the noise if this is out of your control!
With MetaMask and Coinbase wallet both installed, Coinbase wallet used to show a "Which wallet would you like to use" screen when connecting via an InjectedConnector but now it doesn't post 0.12.x
Expected Behavior
Coinbase Wallet should show the "Which wallet would you like to use" screen to select between Coinbase and MetaMask

Steps To Reproduce
Repro:

Install MetaMask and make sure it's unlocked
Install Coinbase Wallet  and make sure it's unlocked
Go to https://wagmi.sh/examples/connect-wallet and click "Injected"
Coinbase wallet used to show a "Which wallet would you like to use" screen but now it doesn't
Go to https://0.12.x.wagmi.sh/examples/connect-wallet and click "Injected"
Coinbase wallet shows the "Which wallet would you like to use" screen

https://github.com/wagmi-dev/wagmi/assets/4934193/60e38eea-b32a-472e-95dd-990f18684edc
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

This would indeed be an issue on the Wallet side.
Note that EIP-6963 will fix this issue of Wallets overriding each other, and wagmi will support it soon once Wallets have implemented it!

Thx for the context! Just curious if you have any idea why CB wallet would be broken in this way post 0.12.x? Like maybe they were relying on a side effect of the old code or something?

Are there workarounds until EIP-6963?


custom song support

idk if this is somethign you guys would want but it would be cool

Im Making Android Port

thats great man


Suggestion: Support for arrays and non-String lists

Currently, they sorta work (they show up in config):

... but they don't show up in-game.

Lists of other types than String sorta work both in-game and in config:
@Entry(category = "generating") public static List<Double> gourmaryllisList = new ArrayList<>(Arrays.asList(0.0, 1.0, 1.3, 1.5, 1.6, 1.7, 1.75, 1.8));

... but after changing a value, the value gets wrapped with quotation marks.

If the non-String types would be supported, it would save on parsing strings into doubles (or other arbitrary type) on the modder's end.

Added in 1.6.0 :)


implement valuable for Path

implement valuable for Path instead of &Path, in order to support types like Box

Thanks for the PR. IIRC, I implemented the Valuable for the reference to match the Valuable implementation of str.

the &str impl uses some specific optimization for slices:
impl Valuable for &'_ str {
    fn as_value(&self) -> Value<'_> {
        Value::String(self)
    }

    fn visit(&self, visit: &mut dyn Visit) {
        visit.visit_value(Value::String(self));
    }

    fn visit_slice(slice: &[Self], visit: &mut dyn Visit)
    where
        Self: Sized,
    {
        visit.visit_primitive_slice(Slice::Str(slice));
    }
}

Path is not a primitive type, so i guess it's different.
(btw, currently the implementation for Box in indeed missing. i guess it should either be added explicitly or the &str impl should be changed to str as well)


Closes #434 #463 - Wait for all notifications to be processed.  Stop exc...

...eptions from being logged when OracleClient is closed

what motivated all of the pom changes?

One reason for the pom changes was that I needed to to start up mini-accumulo in the fluo-cluster module for the new  MiniAppRunnerIT.  I also tried to use only logback in the fluo-cluster module.  However, mini-accumulo requires log4j.  Therefore, you really can't exclude one or the other.  Therefore, I removed the log4j exclusions from the pom.  These exclusion are not necessary any more as the maven assembly plugin (see bin.xml) separates log4j & logback jars into different directories.

+1


update_localizations.dart File

I'm carious about how update_localizations.dart file works. is the localization.g.dart file auto-generated? If so, how is it generated since build_runner package isn't used in this project. Because I want to use my own google translate sheet. Do I just manually write the localizations.g.dart file?
update_localizations.dart: https://github.com/delay/flutter_starter/blob/master/lib/helpers/update_localizations.dart
localization.g.dart: https://github.com/delay/flutter_starter/blob/master/lib/helpers/localization.g.dart

It runs from the command line.  It is basically a completely separate app self contained.

To handle the language translation you need to create a translation for your app in google sheets. Then open /helpers/update_localizations.dart and replace the docID and sheetId with your own documentId and sheetId. After doing that your will need to drop to the command line and go into the helpers directory. Then type: dart update_localizations.dart. This will create or overwrite the localization.g.dart file with your custom translation. There should not be a need to edit this file directly. Everytime you make changes to your translation you will need to re-run this generator.


Add .gitattributes

Closes #2197
This file tells git to check out files with particular line endings, regardless of how they are stored in the repo, or the OS.
Sets the line endings to:

CRLF for most VS files, C#, AS and Haxe source files
LF for .sh scripts

P.S. These changes apply to newly cloned repos. To normalize line endings in an already cloned repo, according to the new .gitattributes file, use these commands (make sure you commit or stash your current work first):
git rm --cached -r . && git reset --hard

Reference: https://stackoverflow.com/a/34089670/4377192

Good idea!

I followed GitHub's instructions which resulted in 170+ modified files (normalized line endings).

I know that the change is huge, but from my side it's also good to merge. Also, solving conflicts for this kind of breaking change is simple as there is no more change than just the line ending.


🐾 Providing a link to the vSphere UI of remote cluster.

Ref: https://github.com/kubev2v/forklift-console-plugin/issues/1106
Providing a link to remote cluster UI (vSphere):
Improve integration with the vSphere UI by providing a link to the vSphere UI of remote cluster.
Issue:
In providers details page, we show a information about the provider, in the case the provider is the a remote Openshift cluster we can add a link to the clusters console URL.

addressed by #1155


The double forward slash in a URL is interpreted as the start of a comment

The double forward slash in a URL is interpreted as the start of a comment and so is highlighted e.g.

Fixed


jsonc support

loadConfigFile cannot load a jsonc file, I want to rename the file name for security reasons (root is a root  of the drogon and  config.json file can be loaded as a static file from public)

You should place the config.json file outside the document root folder.

@marty1885
Thanks for the solution, it's interesting, but I need something platform independent.
The Drogon json config contains comments. This is not the correct json format. The json with comments has the file extension “jsonc”. Also the json config could potentially forget to add to the blacklist.
In my case, I added an additional extension to the sources
 std::vector<std::string> JsonConfigAdapter::getExtensions() const
{
    return {“json”, “jsonc”}
}

Translated with DeepL.com (free version)

You should place the config.json file outside the document root folder.

this is correct, in my case it is rest api, where with the executable file there is only docs folder with html. I didn't want the extra nesting for only one folder for the local distribution.


nvim-treesitter doesn't really install parsers right.

What do I mean about "right"? Well, it's simple. Installing parsers without any errors.
I haven't done some stuff about installing parsers, except for auto-installing them, so that might be the issue.
BUT, ensure_install'ing a parser isn't really performant nor, flexible.
So, I'll see what I can do.

Having tree-sitter-cli installed locally, it works perfectly! :+1: