link to specific puzzle

spaced repetition requires being able to jump straight to a specific puzzle, pass/fail it, then leave.
This can be done by linking to a website (in an iframe) or by assimilating enough of it to self-host a local functioning html page.
Anki has restrictions on media files (no folders, any file not directly referenced in a field or template must begin with an underline to avoid being deleted), so assimilation may require modification, and linking is easier if it's supported.
This puzzle solver doesn't seem to support #anchor nor ?querystring, and iframes don't allow running setPuzzle("puzzle_2") from outside.
♟ chess https://ankiweb.net/shared/info/2023846080 assimilated
🔴 connect four https://sites.math.rutgers.edu/~zeilberg/C4/ch2/P2.html linked then assimilated
⚫ go https://online-go.com/puzzle/2627 linked
☗ shogi https://playshogi.com/#Problems:7:1:null linked (https://lishogi.org/study/DVkrN1nl failed to link or assimilate)
🐘 xiangxi

xqienglish.com has multiple puzzles per page, would have to assimilate multiple pages
https://play.xiangqi.com/puzzle/1qGl3L must solve all puzzles up front to get all links to make cards from
https://maksimkorzh.github.io/wukong-xiangqi/apps/puzzle_solver/gui/puzzle_solver.html#puzzle_2?id=puzzle_2&setPuzzle=puzzle_2 shows all puzzles, ignores ?querystring, failed to link
https://maksimkorzh.github.io/interactive-xiangqi-apps/apps/puzzle_solver/gui/puzzle_solver.html?controls&puzzleId=puzzle_2&pickPuzzle=puzzle_2&mateIn=2 locked to first puzzle in mateIn category, ignores ?puzzleId, failed to link

https://github.com/maksimKorzh/interactive-xiangqi-apps/blob/097a56af1c44b4f57f42a8e3e6441a2c16c76baa/apps/puzzle_solver/gui/game/puzzle_solver.js#L591
It looks like the puzzle solver would have to be modified either way whether I tried to link or assimilate the puzzles.
This issue is an attempt to link to specific puzzles.

created xiangqi note type
renamed files to _xiangqi_wukong.js _xiangqi_puzzle_solver.js _xiangqi_puzzles.js _xiangqi_boards_board_ccbridge.bmp xiangqi_romanized_pieces.png xiangqi_sounds.wav xiangqi_misc_legal*.png
replaced ],[ with , in puzzles.js so all mate levels show up
pasted puzzle_solver.html as text of front side template
div {
display:inline-block;

}

#xiangqiboard {
zoom:2;
} so the board doesn't take the entire width
<button id="reset" onclick='setPuzzle("{{Front}}");'>⟲ Retry</button><br/> so I can make a mistake, go back and solve it, then mark it wrong
<script>setPuzzle("{{Front}}");
$("#context").text("xiangxi "+Puzzles["{{Front}}".split('_')[1]].title+" {{Front}}")</script> to (re)load specific puzzle
added cards from puzzle_0 to puzzle_3385

oh. The puzzle data doesn't include the right move sequence, so it can't reset the puzzle when I make a mistake.

Green feedback on mate without waiting 5 seconds to go the next puzzle, and red feedback on all moves spent. No feedback for wrong move.
$("#xiangqiboard").click(function(){
	setTimeout( function(){
		maxmoves = Puzzles["{{Front}}".split('_')[1]].title.match(/(\d+)/)[0];
    if ($("#pgn").val().endsWith(" mate")) {
			//$("#xiangqiboard")[0].style.border="1px solid green";
			$("#qa")[0].style.backgroundColor="green";
		} else if ($("#pgn").val().includes(maxmoves+". ")) {
			$("#qa")[0].style.backgroundColor="red";
		}
  }, 100 );
});

_xiangqi_puzzle_solver.js
    // load next position
    setTimeout(function() {
      currentPuzzleId++;
      if (currentPuzzleId >= Puzzles.length) currentPuzzleId = 0;
      setPuzzle('puzzle_' + currentPuzzleId);
      return;
    }, 5000);

If I pass card 1 and move to card 2 too fast, this function puts me on puzzle 3 so I had to disable it. I was grading pass/fail for the wrong puzzle.


Fix filesystem transactions in Windows

Codecov Report

Merging #15 (b978d5d) into main (a77fac9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          450       441    -9
=========================================
- Hits           450       441    -9

Flag
Coverage Δ

lang-python
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


chore(main): release 1.7.2

:robot: I have created a release beep boop
1.7.2 (2024-07-12)
Build System

update dependencies (0abd07c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Basalt-Lab/basalt-logger/releases/tag/v1.7.2 :sunflower:


Reduce buildBlock overloads with pairwise buildBlock(combining:into:)

This patch replaces O(2^arity) overloads of buildBlock with O(arity^2) overloads of buildBlock(combining:into:) with the language feature implemented in apple/swift#40799. This improves library compilation time, and fixes an issue where nested captures did not have a flattened type. Before this patch, fixing this would need O(arity!) overloads. This also allows us to switch back to native tuples for Match.
Also, rename renderAsPattern to renderAsBuilderDSL to work around a CI stale file issue.
This depends on swift-DEVELOPMENT-SNAPSHOT-2022-02-03 or later.

@swift-ci please test linux

@swift-ci please test

@swift-ci please test Linux

@swift-ci please clean test linux

/build/branch-main/swift-experimental-string-processing/Sources/PatternConverter/PatternConverter.swift:69:18: error: ambiguous use of 'renderAsPattern(maxTopDownLevels:minBottomUpLevels:)'
00:23:28     let render = ast.renderAsPattern(
00:23:28                  ^
00:23:28 /build/branch-main/swift-experimental-string-processing/Sources/_MatchingEngine/Regex/Printing/PrintAsPattern.swift:20:15: note: found this candidate
00:23:28   public func renderAsPattern(
00:23:28               ^
00:23:28 /build/branch-main/swift-experimental-string-processing/Sources/_StringProcessing/PrintAsPattern.swift:22:15: note: found this candidate
00:23:28   public func renderAsPattern(
00:23:28               ^

Such a strange error. There's only one func renderAsPattern in Sources/_StringProcessing/PrintAsPattern.swift.

@swift-ci please clean test Linux

@swift-ci please test Linux

@swift-ci please clean test linux

I suspect it's a stale file on the CI machine, and a clean test didn't fix it. I'll rename renderAsPattern to renderAsBuilderDSL to work around it.

@swift-ci please test Linux

Merging to unblock things. Additional feedback welcome.


Ensure we use the same filename for run_number

Fix #364

a test that the constant did not change would be appropriate.

Not sure, what kind of test you want here? It's a constant for a filename, not for a number. So for me this is in the style and best-practices realm: never spell out the filename, but always use the constant. Enforce on review.

If the constant is changed, it'll break backwards-compatiblity. The run number is used to generate wallets for nodes deterministically. So changing that constant at any point in time will result in unexpected behaviour.
While typically I would'nt request this, a test asserting the constant remains unchanged makes sense in this case IMO.  Think of it less as a unit test, and more as a sanity check.
def test_run_number_constant_remains_unchanged():
    assert RUN_NUMBER_FILENAME == "run_number.txt"

While typically I would'nt request this, a test asserting the constant remains unchanged makes sense in this case IMO. Think of it less as a unit test, and more as a sanity check.
def test_run_number_constant_remains_unchanged():
    assert RUN_NUMBER_FILENAME == "run_number.txt"

This isn't worth much, as any sane developer would refactor the name in both places. I added a heavy comment on top of the constant declaration. If you want more than this, I'm afraid you're on your own.
Also something I noticed: running make style consecutively applies changes every time, so it seems that some steps interfere with each other.


Can't deploy to Heroku:   python (no such package):

Can't deploy to Heroku:
Following error in the log during deployment:
Step 5/9 : RUN apk --update add --virtual build-dependencies python build-base && 	npm_config_user=root npm install -g n8n@${N8N_VERSION} && 	apk del build-dependencies
---> Running in 28471aa3149c
ERROR: unable to select packages:
python (no such package):
required by: build-dependencies-20211027.192635[python]
The command '/bin/sh -c apk --update add --virtual build-dependencies python build-base && 	npm_config_user=root npm install -g n8n@${N8N_VERSION} && 	apk del build-dependencies' returned a non-zero code: 2

Got the exact same error...
Step 5/9 : RUN apk --update add --virtual build-dependencies python build-base && 	npm_config_user=root npm install -g n8n@${N8N_VERSION} && 	apk del build-dependencies  ---> Running in 0ea89fbd8c88 ERROR: unable to select packages:   python (no such package):     required by: build-dependencies-20211030.153459[python] The command '/bin/sh -c apk --update add --virtual build-dependencies python build-base && 	npm_config_user=root npm install -g n8n@${N8N_VERSION} && 	apk del build-dependencies' returned a non-zero code: 2

Solved this issue by updating Dockerfile line 14 as follows :
RUN apk --update add --virtual build-dependencies python3 build-base && \
You have to specify python3 ;-)
If you run into an anonymousId or userId from the telemetry feature, just disable that feature in the start.sh file as follows :
export N8N_DIAGNOSTICS_ENABLED=false
Just add that line before the last one !


Update sbt-mdoc to 2.2.17

Updates org.scalameta:sbt-mdoc from 2.2.12 to 2.2.17.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-mdoc" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #185.


Improvements for RTL

Hello! I've made some enhancements for rtl layout and seems it works without problem.
Main changes would be:

removing dedicated '-rtl' layouts and merging rtl/ltr in same file.
making a modified copy of style.css for handling rtl in a separate style-rtl.css.
adding a new variable dir: rtl to front matter (beside lang:) of rtl content used for:

linking appropriate style[-rtl].css in default layout and
using appropriate classes in all layouts (.marginR / .marginL and .right / .left)

online demo: iriman.github.io
Please see if this follows your requirements, and if so I can prepare a pull request. thanks
This issue is edited after I found a cleaner way rather than mixing rtl/ltr styles in same css file.

Hello @iriman
suggestions are always welcome, particular for languages and writing systems we are not familiar with. Please make a pull request and we will consider it.

This should now be resolved on both the staging and the production site.


Null reference exception

I have this simple console program (.net 4.5.2)
Module1.vb:
Imports NLog

Module Module1
    Dim logger As Logger = LogManager.GetCurrentClassLogger()
    Sub Main()
        Console.WriteLine("What do you want to do:")
        Console.WriteLine("1. Write message")
        Console.WriteLine("2. Write message with exception")
        Console.WriteLine("3. Write message with properties")
        Console.WriteLine("4. Write message with exception and properties")
        Dim type As Char = Console.ReadKey().KeyChar

        Dim includeException As Boolean = (type = "2"c OrElse type = "4")
        Dim includeProperties As Boolean = (type = "3"c OrElse type = "4")
        Console.WriteLine()
        Dim properties As Dictionary(Of String, String)
        If (includeProperties) Then
            properties = New Dictionary(Of String, String)()
            While (True)
                Console.Write("Property name (Emtpy to stop):")
                Dim propertyName As String = Console.ReadLine()
                If (String.IsNullOrEmpty(propertyName)) Then
                    Exit While
                End If
                Console.Write("Property value: ")
                Dim propertyValue As String = Console.ReadLine()
                properties.Add(propertyName, propertyValue)
            End While
        End If

        Dim exception As Exception
        If (includeException) Then
            Try
                Throw New InvalidOperationException("Some sort of exception")
            Catch ex As Exception
                exception = ex
            End Try
        End If

        Console.Write("Message: ")
        Dim message = Console.ReadLine()

        Console.WriteLine("Level: ")
        For Each logLevel In NLog.LogLevel.AllLevels
            Console.WriteLine($"{logLevel.Ordinal} {logLevel.Name}")
        Next
        Dim levelChar As Char = Console.ReadKey().KeyChar

        Console.WriteLine()
        Dim selectedLogLevel As LogLevel = Nothing
        For Each logLevel In NLog.LogLevel.AllLevels
            If (logLevel.Ordinal = Integer.Parse(levelChar)) Then
                selectedLogLevel = logLevel
            End If
        Next
        Dim logEvent = New LogEventInfo(selectedLogLevel, logger.Name, message)
        If (exception IsNot Nothing) Then
            logEvent.Exception = exception
        End If
        If (properties IsNot Nothing) Then
            For Each key In properties.Keys
                logEvent.Properties.Add(key, properties(key))
            Next
        End If
        logger.Log(logEvent)

        Console.WriteLine("Press any key to close")
        Console.ReadKey()
    End Sub

End Module

NLog.config:
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" autoReload="true" throwExceptions="true">
  <extensions>
    <add assembly="NLog.Targets.Lumberjack" />
  </extensions>
  <targets>
    <target name="logstash" xsi:type="Lumberjack" host="<IP_ADDRESS>" port="5000" layout="${message}"/>
    <target name="console" xsi:type="ColoredConsole" />
  </targets>
  <rules>
    <logger name="*" minlevel="Trace" writeTo="logstash"/>
    <logger name="*" minlevel="Trace" writeTo="console"/>
  </rules>
</nlog>

When it closes it gets a
System.NullReferenceException was unhandled
Message: An unhandled exception of type 'System.NullReferenceException' occurred in NLog.dll
Additional information: Object reference not set to an instance of an object.

Stacktrace:
   at NLog.Targets.Lumberjack.LumberjackTarget.CloseTarget()
   at NLog.Targets.Target.Close()
   at NLog.Targets.Target.NLog.Internal.ISupportsInitialize.Close()
   at NLog.Config.LoggingConfiguration.Close()
   at NLog.LogFactory.set_Configuration(LoggingConfiguration value)
   at NLog.LogManager.TurnOffLogging(Object sender, EventArgs args)
   at NLog.Internal.Fakeables.AppDomainWrapper.OnProcessExit(Object sender, Even
tArgs eventArgs)

This only happens when i use Lumberjack.
NLog: 4.3.10
NLog.Targets.Lumberjack: 1.0.2
Also there is currently nothing listening on port <IP_ADDRESS>:5000 but that should not lead to a null reference exception when closing the program if it should crash then its when trying to log.

Thanks for an excellent and detailed bug report 👍
I'll have a look into it more as soon as I have time but at first glance it seems like a simple mistake on my part.
If you haven't sent any message to your logstash server, since there is no server listening, then there is no stream open when the target tries to close it on line 59. I'll try to push an update during the day.

The fix is now also updated on nuget, thanks again for the report.
https://www.nuget.org/packages/NLog.Targets.Lumberjack/1.0.4


Qt5/0.8.0: debian support

update debian packging in order to reflect changes in 0.8.0 (qt5 and xcb).
also add optional QT5LIBDIR flag to qmake (debian does not have qt5 at /usr/lib/qt5, but at /usr/lib/(multiarch)/qt5).

Looks good, thanks for sending that in!
You might want to put the QT5LIBDIR *.pro fix into all the other lumina *.pro files as well. I try to keep them all the same, and the way they all use the Qt5 lrelease utility is identical.


インスタンスを先に増やすようにする

既存の総リソースが足りずタスクの再分配ができない問題を回避

実行イメージ
handler.go:37: successfully initialize sessions
Assume Role MFA token code: XXXXXX
handler.go:50: Instance is found: i-xxxxxxxxxxxxxxx
handler.go:58: cap: 1
handler.go:64: waiting for a new instance to be registered
ecs_waiter.go:51: Still new instance isn't registerd
ecs_waiter.go:51: Still new instance isn't registerd
ecs_waiter.go:51: Still new instance isn't registerd
ecs_waiter.go:51: Still new instance isn't registerd
handler.go:78: increase desired capacity: 2
Continue?


Extended development, escape error when sending command in cmd.exe terminal

VSCode Version:1.22.1
OS Version: Windows10,Cmd.exe

I am trying to fix a jest debug problem
jest-issues
I found that powershell and cmd.exe seem to have different results when the terminal sends a command line.
powershell:

cmd.exe

The generation of command line results does not seem to be extended control.

How are you sending/generating the command line?

I'm very sorry, I need some time to read the source code.


Recursive include directory?

It would be nice if we could include entire directories (that contain other directories). This could be done by using fnmatch to do the pattern matching instead so something like exclude: directory/ or exclude: directory/* works as expected -- rather than just the files in a particular directory.

@kratsg Yeah the directory exclusion is not ideal, thanks for the suggestion. Will look into this for the next version.

@kratsg The new version 0.4.0 adds this feature thanks to @seppi91 ! Please upgrade via pip install mkdocs-exclude-search --upgrade. See the readme for how to apply the directory exclusions.
Let me know if you encounter any problems!

Looks like that broke my deploy:
10:16:30 AM: Traceback (most recent call last):
10:16:30 AM:   File "/opt/buildhome/python3.7/bin/mkdocs", line 8, in <module>
10:16:30 AM:     sys.exit(cli())
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/click/core.py", line 829, in __call__
10:16:30 AM:     return self.main(*args, **kwargs)
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/click/core.py", line 782, in main
10:16:30 AM:     rv = self.invoke(ctx)
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
10:16:30 AM:     return _process_result(sub_ctx.command.invoke(sub_ctx))
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
10:16:30 AM:     return ctx.invoke(self.callback, **ctx.params)
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/click/core.py", line 610, in invoke
10:16:30 AM:     return callback(*args, **kwargs)
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/mkdocs/__main__.py", line 152, in build_command
10:16:30 AM:     build.build(config.load_config(**kwargs), dirty=not clean)
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/mkdocs/commands/build.py", line 295, in build
10:16:30 AM:     config['plugins'].run_event('post_build', config=config)
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/mkdocs/plugins.py", line 96, in run_event
10:16:30 AM:     result = method(**kwargs)
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/mkdocs_exclude_search/plugin.py", line 211, in on_post_build
10:16:30 AM:     to_exclude = self.resolve_excluded_records(to_exclude=to_exclude)
10:16:30 AM:   File "/opt/buildhome/python3.7/lib/python3.7/site-packages/mkdocs_exclude_search/plugin.py", line 77, in resolve_excluded_records
10:16:30 AM:     excluded_entries[idx] = file_name, header_name
10:16:30 AM: TypeError: 'str' object does not support item assignment

Hi @Stanzilla
Your exclude config should bei a list, youve defined a string

@seppi91 thanks! Still a breaking change, should probably be in the release notes

Let me know if you encounter any problems!

Worked very nicely out of the box :) Thanks! (Sorry for what seemed like a drive-by issue at the time)

Perfect, thanks all for your help! Closing then.
@Stanzilla Added a note in the release note, thanks.


TypeScript and injections

Hello,
I'm trying to get started with ng-react and TypeScript 1.8, but I'm struggling with the component registration when I want to inject some dependencies into the React component. My current component looks like this:
interface Props {
    title: string;
    someService: any;
}

class HelloReactComponent extends React.Component<Props, {}> {
    render() {
        return

            Hello React: {this.props.title}
            {this.props.someService.getValue()}

;
    }
}

Now I'm not able to use the trivial registration using angular.module(x).value(...), but need to use angular.module(x).factory(...) and don't see any possibility how to use the HelloReactComponent class in this case. Do I really need to redesign my component not to be a class, but write the code in React.createClass without possibility to use the class?

@Buthrakaur thanks for raising this. So If you use React.createClass there is no problem ? Could you post an example of your use of angular.module(x).value(...) ?

Closed due to inactivity. Feel free to reopen.


Jest encountered an unexpected token

Hello!
Thanks for this project, looks super promising! I'm trying to use it in https://github.com/microcks/microcks-testcontainers-node to test some Keycloak integration use-case but I'm facing issues importing and using it.
I have done the following things:

Added "keycloak-testcontainer": "^0.0.6"  as a dev dependency in my package.json
Modify microcks-container.test.ts to import the needed dep:

import KeycloakContainer from 'keycloak-testcontainer';

Try starting a container within a test:

it("should start, load artifacts and contract test mock with OAuth2 context", async () => {
    const network = await new Network().start();

    // Start microcks container and other containers.
    const container = await new MicrocksContainer().withNetwork(network).start();
    const keycloak = await new KeycloakContainer()
        .withNetwork(network)
        .withNetworkAliases("keycloak")
        .withRealmImport(path.resolve(resourcesDir, "myrealm-realm.json"))
        .start();

   // [...]

   // Now stop the containers and the network.
    await container.stop();
    await keycloak.stop();
    await network.stop();
  });

but each time I launch a Jest test I've go the following error message:
 FAIL  src/microcks-container.test.ts
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /Users/laurent/Development/github/microcks-testcontainers-node/node_modules/keycloak-testcontainer/dist/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import { KeycloakContainer } from './container/container.js';
                                                                                ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      19 | import { MicrocksContainer, TestRequest, TestRunnerType, OAuth2GrantType } from "./microcks-container";
      20 |
    > 21 | import KeycloakContainer from 'keycloak-testcontainer';
         | ^
      22 |
      23 | describe("MicrocksContainer", () => {
      24 |   jest.setTimeout(180_000);

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)
      at Object.<anonymous> (src/microcks-container.test.ts:21:1)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.706 s
Ran all test suites matching /\/Users\/laurent\/Development\/github\/microcks-testcontainers-node\/src\/microcks-container.test.ts/i with tests matching "MicrocksContainer should start, load artifacts and contract test mock with OAuth2 context".

It looks like Jest complains about using a non-standard module or javascript thing.
I'm quite newbie on Jest and its configuration, I saw that there are many configuration options for Jest (including using stuff like babel and such).
Is there a workaround to this issue? Or is it due to my project configuration?
Thanks for the help!

Hey @lbroudoux, thanks for your report! :)
The package is written using ES module support. Jest also seems to notice this in the error you posted:
SyntaxError: Cannot use import statement outside a module

I'll take a deeper look later to see if I can do something about it, but can you try adding "type": "module" to your package.json in the mean time and see if it works? Depending on your jest version this could fix it (or you can try some of the solutions here). If this does not work, let me know and I'll see what I can improve

Hi,
Thanks for above comments. I tried several things from the links you mentioned above but got no luck so far:
1. Adding "type": "module" to my package.json
Produces the same error with jest 29.6.2 or 29.7.0
2. Adding "transform": {} to my jest.config.js and execute tests with node --experimental-vm-modules node_modules/jest/bin/jest.js
Produces a slightly different error (with or without "type": "module" in package.json):
><EMAIL_ADDRESS>test
> node --experimental-vm-modules node_modules/jest/bin/jest.js

 FAIL  src/microcks-container.test.ts
  ● Test suite failed to run

    Must use import to load ES Module: /Users/laurent/Development/github/microcks-testcontainers-node/node_modules/keycloak-testcontainer/dist/index.js

      19 | import { MicrocksContainer, TestRequest, TestRunnerType, OAuth2GrantType } from "./microcks-container";
      20 |
    > 21 | import KeycloakContainer from 'keycloak-testcontainer';
         | ^
      22 |
      23 | describe("MicrocksContainer", () => {

      at Runtime.requireModule (node_modules/jest-runtime/build/index.js:850:21)
      at Object.<anonymous> (src/microcks-container.test.ts:21:1)

3. Add my test environment to .babelrc and npm install --save-dev @babel/plugin-transform-modules-commonjs
Still produces the same error as in the initial message (with or without "type": "module" in package.json)
FAIL  src/microcks-container.test.ts
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /Users/laurent/Development/github/microcks-testcontainers-node/node_modules/keycloak-testcontainer/dist/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import { KeycloakContainer } from './container/container.js';
                                                                                ^^^^^^

    SyntaxError: Cannot use import statement outside a module

I also tried other suggestion using npm install --save-dev babel-jest but nothing seems to work.
Did you have some other suggestion?

Finally got something working by changing some other stuff!

Added "type": "module" to package.json
Changed my module in tsconfig.json file from commonjs to es2022:

{
  "compilerOptions": {
    "incremental": true,
    "target": "es2022",
    "module": "es2022",
    "declaration": true,
    "sourceMap": true,
    "strict": true,
    "moduleResolution": "node",
    "esModuleInterop": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true,
    "noImplicitOverride": true,
    "composite": true,
    "rootDir": "src",
    "outDir": "build"
  },
  "exclude": [
    "build",
    "jest.config.ts"
  ]
}

Changed my Jest preset to ts-jest/presets/default-esm and add empty transform in jest.config.ts file:

import type { Config } from "jest";

const config: Config = {
  preset: "ts-jest/presets/default-esm",
  resetMocks: true,
  restoreMocks: true,
  transform: {}
};

export default config;

Adapted my test command in package.json:

"test": "cross-env DEBUG=testcontainers* NODE_OPTIONS='--experimental-vm-modules' jest"

Then add global imports that are no longer available by default in proper ESM:

import { dirname } from 'path';
import { fileURLToPath } from 'url';

import { jest } from '@jest/globals'

Checking everything is working at the moment!

Great to hear! I used your repository and pretty much did the same steps to make it work. I also had to fix the __dirname issue with this:
const __filename = fileURLToPath(import.meta.url);

const __dirname = path.dirname(__filename);

I think the biggest issue here is that commonjs is not supported and that jest really requires a lot of configuration / support for es modules. Let me mark this as an enhancement and see if I can add support in the next version so you don't have to configure all this stuff.


feat(*): some auxiliary definitions for toAdditive

Define some extra functions about List, String, Name, Binder and Expr (ported from Lean 3)
Move some definitions about Expr from Tactic/Core to Lean/Expr.

Thanks for all the pointers! I'm not used to the idiomatic ways to do things in Lean 4 (and there are relatively few examples to learn from), so these are incredibly helpful! I will remove all the things that have better alternatives.

Thanks for the review!

bors r+


Respect max polling duration for instance operations set by the broker

This (OSBAPI specification change)[openservicebrokerapi/servicebroker#627] introduces a  timeout value (at the catalog level for a service) a broker to specify a polling duration other than what the platform would default to.
This commit implements that change on the Cloud Controller API for operations on service instances.  Operations on bindings will be done as part of a following PR.
More details in the following stories:
https://www.pivotaltracker.com/story/show/163861066
https://www.pivotaltracker.com/story/show/163861093
https://www.pivotaltracker.com/story/show/163861101
Aarti, @williammartin , @nmaslarski

We're don't think the codeclimate issues are relevant for this case. They don't seem to be compliant with our rubocop rules, which already pass, so we'll proceed with the merge.


Seems to break Cosmetic Armor Reworked mod

With transmog:

Without transmog:

Link to the mod in question
While transmog pretty much achieves the same results(and better), i like to have a 2nd set of armor in cosmetic slots, specifically to toggle cosmetic armor on the fly, without having to use transmog to change the look everytime if i want a different look

I've finally had some time to look at this issue, and I don't think I have a way to fix this unfortunately, at least not for version 1.21/1.21.1 (Currently working on porting it to the newer updates, so I'll try to see if I can actually fix it there).
The issue stems from the fact that Cosmetic Armor Reworked breaks the one assumption Transmog relies on: That no one modifies the inventory during rendering, they just check what's actually in it.  CAR changes the player's inventory (specifically the armor slots) for the entire duration that the player character is being rendered, and with Transmog installed it basically does that to a fake inventory that doesn't actually get used during future rendering. Since I can't check whether the inventory is being requested specifically by CAR without a huge performance impact, I don't think there's currently a way to fix it. Sorry :(


Edges towards nested Nodes are rendered behind the parent Node

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior
Edges to nested nodes are rendered behind the parent of the nested Node. If the parent node has a fill, the edge is hidden.
Expected behavior
Edges should be always rendered at the very front.
Minimal reproduction of the problem with instructions
Note, that the fill has some opacity to visualize the problem. This example will be in the storybook in the docs soon (#30).

Code to reproduce:
const nodeDimensions : any = {
    typeA: {
      width: 190,
      height: 150
    },
    typeB:{
      width: 80,
      height: 80
    }
  }

const nodes: NodeData[]= [
    {
      id: '1',
      text: '1',
    },
    {
      id: '2',
      label: 'A',
      name: 'Process XYZ',
      description: 'Description of XYZ',
      // describes padding for nested nodes
      nodePadding: [120, 50, 50, 50],
      ...nodeDimensions.typeA
    },
    {
      id: '2.1',
      parent: '2',
      label: 'B',
      name: 'Task 1',
      ...nodeDimensions.typeB
    },
    {
      id: '2.2',
      parent: '2',
      label: 'B',
      name: 'Task 2',
      ...nodeDimensions.typeB
    },
    {
      id: '3',
      text: '3'
    }
  ];`

const edges: EdgeData[] = [
    {
      id: '1-2.1',
      from: '1',
      to: '2.1'
    },
    {
      id: '2.1-2.2',
      parent: '2',
      from: '2.1',
      to: '2.2'
    },
    {
      id: '2.2-3',
      from: '2.2',
      to: '3'
    },
  ];

function prepareNode(node){
    const data = node.properties;
    switch (data.label){
      case 'A':
        return (
          <Node style={{fill: 'lightgreen', opacity: 0.8}}>

{data.name}

{data.description}

          </Node>
        )
      case 'B':
        return (
          <Node style={{fill: 'lightyellow'}}>

{data.name}

          </Node>
        )
      default:
        return (
          <Node/>
        )
    }
  }

return (

      <Canvas
        // required to enable edges from/to nested nodes
        layoutOptions={{'elk.hierarchyHandling':'INCLUDE_CHILDREN'}}
        direction='RIGHT'
        nodes={nodes}
        edges={edges}
        node={(node: NodeProps) => prepareNode(node)}
      />

  );

I think i fixed this in a recent PR. can you verify if it's still an issue in master?

Ya - this is resolved now but there is another issue i need to fix lol


Layout problem

Hi,
when I open the Favorites pane I got the following view.

As far as I know the first entry should be beneath the title, shouldn't it be?
Or could it be a problem with the "Ohmine Dark Theme" I use?
One time as I was investigating with the developer tools the favorites started beneath the title and I was curious why there was nothing else but the note title. Until I moved the cursor above the whole line and suddenly two icons appeared.
Is this behavior normal that the icons are not visible except one hovers with the cursor over them?

Hi,
the layout switches automatically from horizontal to vertical when a certain panel width is reached. You can change the panel width via the "Change application layout" command. See here how to do. Also here's a short screencast how it works detail. Its recorded for another plugin, but the behavior is the same for this plugin.
Showing the "edit" and "delete" button only when hovering of a favorite is a intended behavior. You can also open a edit dialog when right clicking on a favorite.


No matches found trying to add XVSUSDT, ADAUSDT and a lot others

Hi,
Thank you very much for sharing this great effort with us.
I can see from this screenshot on the readme a lot of coins added, but I can only add 6 pairs with USDT, BTC, ETH, BNB, LTC, TRX, XRP. Adding anything different results in 'no matches found' in the drop down.
https://user-images.githubusercontent.com/5715919/110196341-f7f32280-7e97-11eb-9aea-e645f678e185.png

I saved and reopened settings window and it was fixed!

Good, I will close the issue. :)


Add umicollapse and benchmark it against umitools dedup

Description of feature
umicollapse is a Java tool and nf-core module so far not used by any pipeline.
It was specifically written as a more performant tool, which supposedly produces output equivalent to umi-tools dedup, but with significantly shorter runtimes (minutes instead of hours).
Therefore, it might make sense to switch from umi-tools dedup to umicolllapse, or at least offer it as an alternative route, similar to the coexistence of TrimGalore / FastP in the future.
To advance this development, please:

Familiarize yourself with umicollapse and its settings.

Create a new branch of the pipeline in your fork and add the umicollapse module to it, replacing the umi-tools dedup step. Update the module config accordingly.

Benchmark the modified pipeline against version 3.12 when run on data with UMIs, comparing runtimes and quantification results. Possible benchmarking datasets are e.g. GSE207129 or GSE179992 with those parameters
with_umi: true
umitools_extract_method: "regex"
umitools_bc_pattern2: "^(?P<umi_1>.{8})(?P<discard_1>.{6}).*"
skip_markDuplicates: True

or Experiment 2 of Series GSE171427 when run with
   with_umi : true
  umitools_extract_method : 'regex'
  umitools_bc_pattern : "^(?P<umi_1>.{12}).*"
  skip_markDuplicates: true
  clip_r2: 9

I think, this is a suitable Hackathon task for a more advanced nf-core contributor. Thanks!

Hi there, I wrote the module! We are using it in our updated nf-core/clipseq pipeline (not released yet). It is able to handle much larger bams and I have benchmarked that it gives identical results. So hopefully this should be an easy issue.

Great work and thank you so much for the info!
So then this issue comes down to writing a respective subworkflow similar to bam_dedup_stats_samtools_umitools, but using umicollapse instead.
Maybe @drpatelh can give a hint, if he prefers replacing umi-tools dedup or leaving it to the user to choose in that case?

Be interested to see what your implementation looks like @CharlotteAnne ! But adding an independent subworkflow either way as you suggested @MatthiasZepper is a good idea. We can then decide how we slip it into the pipeline.

you can see in the https://github.com/nf-core/clipseq/tree/feat-2-0 branch
of clipseq. we dont used the subworkflow because the samtools stats
clutters up our pipeline output without giving any real useful information
On Wed, 11 Oct 2023 at 19:26, Harshil Patel @.***>
wrote:

Be interested to see what your implementation looks like @CharlotteAnne
https://github.com/CharlotteAnne ! But adding an independent
subworkflow either way as you suggested @MatthiasZepper
https://github.com/MatthiasZepper is a good idea. We can then decide
how we slip it into the pipeline.
—
Reply to this email directly, view it on GitHub
https://github.com/nf-core/rnaseq/issues/1087#issuecomment-1758260786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFVBH3PJ7VGHJLHY2VC3OPTX63QF3ANCNFSM6AAAAAA5UI7X3Y
.
You are receiving this because you were mentioned.Message ID:
@.***>

actually thats a lie lol at the moment we do
https://github.com/nf-core/clipseq/blob/feat-2-0/subworkflows/local/bam_dedup_samtools_umicollapse.nf
but im gonna refactor becuz of samtools stats clutter
On Wed, 11 Oct 2023 at 19:40, Charlotte Capitanchik <
@.***> wrote:

you can see in the https://github.com/nf-core/clipseq/tree/feat-2-0
branch of clipseq. we dont used the subworkflow because the samtools stats
clutters up our pipeline output without giving any real useful information
On Wed, 11 Oct 2023 at 19:26, Harshil Patel @.***>
wrote:

Be interested to see what your implementation looks like @CharlotteAnne
https://github.com/CharlotteAnne ! But adding an independent
subworkflow either way as you suggested @MatthiasZepper
https://github.com/MatthiasZepper is a good idea. We can then decide
how we slip it into the pipeline.
—
Reply to this email directly, view it on GitHub
https://github.com/nf-core/rnaseq/issues/1087#issuecomment-1758260786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFVBH3PJ7VGHJLHY2VC3OPTX63QF3ANCNFSM6AAAAAA5UI7X3Y
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello! After a conversation with @MatthiasZepper over Slack I decided I would get hands-on on this issue. I've already created a branch on a fork of the repo and added the functionality for the user to select whether they want to deduplicate using umitools or umicollapse.  Then I added the umicollapse module to the pipeline and @CharlotteAnne 's module from clipseq.
I have not made the pull request yet because I have not tested it and benchmarked, but feel free to "read" the changes in the code and give all the feedback you want. I'll keep you posted with the results once I have tested :)

The added umicollapse process is working correctly, but I had to comment out the line where the .command.log is copied to a file because I got an error about the file not existing... And also had to comment out the lines referencing that log file downstream. Maybe @CharlotteAnne has some idea about how to correctly generate the log for the process? I think a solution could be to pipe the STDOUT of the umicollapse command since it's very informative to the log file.
I'm testing only that it currently runs and completes with two samples of the first dataset linked, subsampled to 10k reads (I'm testing it locally :sweat_smile: ), but would love to really benchmark this implementation with more real data. Any suggestion or idea on how could we do this?

@ctuni : Thank you so much for all your work and effort! Greatly appreciated! We have some sequencing data from human XpressRef Universal Total RNA in different input concentrations and kits, which I could run with your pipeline for comparison.
It will take a couple of days, but then we have a relatively large dataset with a known ground truth to compare against. I could share e.g. the salmon quant files with you for your own analysis?

To give you a small update about my progress (or the lack thereof :grimacing:).
I fetched @ctuni 's modification to the pipeline based on @CharlotteAnne 's subworkflow, but felt that for evaluation purposes, it would be better to compare the tools on exactly the same BAM files instead of realigning the same reads again.
Therefore, I tried to .tap() the BAM transcriptome channel, modify the meta.id for the branched samples with an additional suffix, run both tools in parallel and later mix the output channels again.
With the same approach, I planned to also get a close comparison of the effects that the Prepare for Salmon process has, since the whole undertaking started in Slack with doubts about that script: #828.
Thus, essentially getting 4 quantifications (umitools, umicollapse) x (prepare for salmon, skip prepare for salmon) for the same BAM alignment. The pipeline modified for test purposes resides in my fork, but I keep getting out of memory errors for umicollapse.
Even 256GB heap doesn't seem to be enough for a single pass run:
Exception in thread "main" java.lang.OutOfMemoryError: Java heap space
  	at java.base/java.util.regex.Matcher.<init>(Matcher.java:248)
  	at java.base/java.util.regex.Pattern.matcher(Pattern.java:1134)
  	at umicollapse.util.SAMRead.getUMI(SAMRead.java:34)
  	at umicollapse.main.DeduplicateSAM.deduplicateAndMerge(DeduplicateSAM.java:109)
  	at umicollapse.main.Main.main(Main.java:221)

Therefore, I still have to play around with the Java Virtual Machine Memory settings for initial heap size, max heap size and stack size and probably set --two-pass as default argument in the module.config.

Thank you for this effort. Please let me know if I can help in some way. I would appreciate being able to finish the entire pipeline in under 2 hours, instead of nearly the whole day that it takes right now.

Of course, you can help! Much appreciated!
The subworkflow with umicollapse is done, but I was holding back with integrating it into the rnaseq pipeline, since it to me seemed that release 3.15 was immanent and more urgent tasks had to be done. But since the big refactor is done, you can probably now integrate it without the risk of building on top of a heavily changing foundation with many moving parts now (*hopefully)
Hoe about assigning yourself to this task and taking over?

Smrnaseq has it implemented too - if you're looking for insights how it was implemented there, have a look 👍

Thank you! I don't have permissions to change assignments. Please do so if you can. I will send a PR shortly.

Great! Please join the nf-core GitHub organization asap, so you can better interact with the different repos and issues! I think e.g. @drpatelh would be happy to send you an invitation, since you are contributing to the rnaseq pipeline.

Running a little behind on this, but still on my list, somewhere near the top.

Running a little behind on this, but still on my list, somewhere near the top.

Please don't stress yourself over it. I have been neglecting this for months and without your help, it would probably not make it anywhere soon either. So take your time, it will anyway not be included in the next release 3.15 anymore (for which a feature freeze is essentially in place) and the 3.16 release is still a few weeks ahead!

WIP PR at #1369. I think we definitely have to use --two-pass, and I am not sure how good umicollapse is with paired reads.

Crude benchmark results from processing GSE207129. Note that these are paired reads. Execution timeline reports attached.
Some notes:

--paired uses considerably more memory and time, and processing transcriptomes is much worse than with umitools. With --two-pass, it takes 9-10 hours for umicollapse instead of ~30 minutes for umitools. Processing genomes takes roughly half the time (but with 10x more memory).
--two-pass keeps memory requirements low. For a 3.2 GB transcriptome sorted BAM file with paired reads, --two-pass takes 15 GB instead of 75 GB RAM.

Does anyone have any thoughts on what I could be doing wrong here?
Execution Timeline.zip

I couldn't see easily - are you testing with data that has UMIs? how long
are the UMIs and what is the PCR deduplication ratio of the dataset? With
CLIP we found similar, that sometimes UMIcollapse can be comparably
inefficient but it works for tricky large BAM files where umitools just
gives up. Probably a question for the tool author.
On Tue, 3 Sept 2024 at 19:18, Siddhartha Bagaria @.***>
wrote:

Crude benchmark results from processing GSE207129
https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GSE207129. Note that
these are paired reads. Execution timeline reports attached.
Some notes:

--paired uses considerably more memory and time, and processing
transcriptomes is much worse than with umitools. With --two-pass, it
takes 9-10 hours for umicollapse instead of ~30 minutes for umitools.
Processing genomes takes roughly half the time (but with 10x more memory).
--two-pass keeps memory requirements low. For a 3.2 GB
transcriptome sorted BAM file with paired reads, --two-pass takes 15
GB instead of 75 GB RAM.

Does anyone have any thoughts on what I could be doing wrong here?
Execution Timeline.zip
https://github.com/user-attachments/files/16853028/Execution.Timeline.zip
—
Reply to this email directly, view it on GitHub
https://github.com/nf-core/rnaseq/issues/1087#issuecomment-2327145118,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFVBH3JFBKJ2GTZBW62K4FLZUX4PBAVCNFSM6AAAAABL6E574SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGE2DKMJRHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, the data has 8 bp long UMIs. This is what umi-tools says:
Reads: Input Reads: 44319354, Read pairs: 44319354
Number of reads out: 32494556
Total number of positions deduplicated: 30086237
Mean number of unique UMIs per position: 1.11
Max. number of unique UMIs per position: 147

Ah I see! These files have many more reads than we would typically process
from CLIP, but our PCR deduplication ratio is higher and the UMIs can be
longer, which both also impact the memory requirement. Perhaps the
smallRNASeq folk would be better able to advise and the tool author
himself on his github repo.
On Tue, 3 Sept 2024 at 21:13, Siddhartha Bagaria @.***>
wrote:

Yes, the data has 8 bp long UMIs. This is what umi-tools says:
Reads: Input Reads: 44319354, Read pairs: 44319354
Number of reads out: 32494556
Total number of positions deduplicated: 30086237
Mean number of unique UMIs per position: 1.11
Max. number of unique UMIs per position: 147
—
Reply to this email directly, view it on GitHub
https://github.com/nf-core/rnaseq/issues/1087#issuecomment-2327355503,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFVBH3KZYMFLRZQVIHWRVMDZUYKADAVCNFSM6AAAAABL6E574SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGM2TKNJQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Filed https://github.com/Daniel-Liu-c0deb0t/UMICollapse/issues/31 to get a response from the tool author.
If paired ends is indeed this slow, my suggestion would be to continue to keep umi-tools the default and provide UMICollapse only as an option manually selected, probably without integration with multiqc.

@apeltzer Have you ever run UMICollapse in paired end mode? It seems like the command line the pipeline would form is incorrect (--method should be --algo) and so maybe UMICollapse was never tested in paired mode?
https://github.com/nf-core/smrnaseq/blob/5901bea438cb719c186f883bb6e6a11f1de70a5b/conf/modules.config#L143

After fixing the issue in UMICollapse, in general, UMICollapse takes ~60% of the wall time of umi-tools. We will have to wait for the fix to be accepted and a new release in bioconda.

Smrnaseq only runs on SE data so the PE was never used. As smrnaseq data is so short, paired end protocols do not make any sense for smrna data. For SE data we saw quite substantially better performance than what we had with umitools.

@CharlotteAnne, looks like the conda recipe uses your forked repo. Would you be willing to update the recipe to use a released version from your or mine repo until the author merges the change?

@MatthiasZepper, created https://github.com/bioconda/bioconda-recipes/pull/51441.

Thanks a lot for all the work you are investing in that! Unfortunately, I could not approve your PR to Bioconda, but I found somebody who could!

Thank you. It is now merged. So I guess now we wait for the docker image generation and then finish this work. :-)

Thank you. It is now merged. So I guess now we wait for the docker image generation and then finish this work.

Updating the module is in progress...


[Improve] Improve streampark-flink module based on [6 Testing]

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
[Improve] Improve streampark-flink module based on 6 Testing
Usage Scenario
No response
Related issues
#2986
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

i pick it

@RocMarshal Please apply to close this issue. There may be other problems in scala test at present, and I may send a special proposal to discuss them in the future


allow curl options, such as "-k" or "--cacert ca.pem"

these paramters get picked up from the curl_options file, similar to method or url.

Thanks! Should we add this to the README as well?

Yes, valid point, i added it to the README.md and also changed the filename to be more similar to the others.


ACNA-290 - Runtime API calls should set user-agent

Is your feature request related to a problem? Please describe.
We cannot differentiate calls to the wsk rest api made by our client, and/or wsk/wskdeploy cli
Describe the solution you'd like
An adobe-runtime specific user agent

Holding off on this, while we see how long for https://github.com/apache/incubator-openwhisk-client-js/pull/183 to be published.


ETFE-2960 Duty paid user's access - feature

Ran against JT's and they fail

JT's have now been updated under https://jira.tools.tax.service.gov.uk/browse/ETFE-2967

One issue I spotted was that the page title doesn't have the usual suffix:

It matches the Unauthorised page title

Just waiting on JT's to be reviewed. There was one failure when running all the test suites (JT's)

I only ran run_tests_acc.sh
https://github.com/hmrc/emcs-tfe-journey-tests/pull/341 approved.


Feature Request: Ability to change GIF safety level.

I feel like I have a hard time finding GIFs that I think are still pretty work appropriate sometimes:
But then again I guess this is in here...


Run batch file for windows users

#27
Run batch file to support windows users without bash.

Can we also update the Reademe in quickstart, so that Windows user's also find it helpful?

Can we also update the Reademe in quickstart, so that Windows user's also find it helpful?

Changed this file to .md and have followed the restel-docs but added new section for windows. Check the new PR in restel-docs and advice on the best approach.


feat: manager applications in organization scope

Applications
Organization admin
1.Organization admin can manager own applications.

2.And they can't modify the organization of the application

Global admin
1.Same as before. The global admin can manager all application.

2.Can modify the organization of applications.

Providers
There is a kind of providers, their owner is "admin". They can be shared for all applications.
Organization admin
Manager their own provider

Global admin

Manager all providers.
Can modify the organzaition of providers.
What'more, setting the "admin" providesr.

What providers can be used by an application?

Providers belong to admin.

Provider belong to the organization of the application.

close: #1262

@hsluoyz  plz review


ng commands

Hi,
rtpengine supports play/stop media ng commands but it seems rtpengine-client does not support those.
Do you have any plans to support these commands?

thanks and good point.  I will add these in next few days (if you have aleady done feel free to give me a PR!)

Hi,
I added just playMedia / stopMedia commands to your client.js commands array for test and i have confirmed it works well. (using the rtpengine docker you've made)

can you give me a PR for those changes?  That would be great

thanks!  merged your PR


Refactor OrderContentsDecorator.add_to_line_item and bump version

Changes to OrderContentsDecorator.add_to_line_item

Separated incoming options hash into standard spree options, product_customizations, and ad_hoc-option_ids

set line_item.options using standard spree options

separated some logic into new flexi_variants method

flexi_variants method calls new line_item instance methods to assign options and get price adjustments

@acreilly @dhonig Any thoughts on this?

Looks good to me! Thanks for doing the work. @dhonig What do you think?

@kinduff merge it?

Ping on this. I'd like to keep working on some other parts of this gem as soon as we get this through.

Looks good to me, great work here


Issue#28

Description of changes

cleaned up the schema
flashcard sides now get validated for mutation operation
explicit declaration if side is an answer

Closes #28
Can be merged after review!
How has this been tested?
Please describe the test strategy you followed. If not tested, please explain why.

[X] automated unit test
[X] automated integration test
[ ] manual, exploratory test

Checklist before requesting a review

[X] My code is easy to understand
[X] My code follows the coding guidelines of this project
[X] My code fulfills all acceptance criteria
[X] The test coverage (line and branch) is reasonably high, especially on Service classes and other classes with complex logic
[X] I have made corresponding changes to the documentation or
the wiki/adr
[X] I made no breaking changes in the database schema or if so, I will perform a database migration

Checklist for reviewer

The code is easy to understand
The code follows
the coding guidelines of
this project
The code is tested or if not, the reason is documented or discussed
The added and existing tests reasonably cover the code change
The code has no breaking changes in the database schema or if so, the assignee is aware of it and
will perform a database migration

@BlueWaves2 You're not avoiding DB migration this way: "boolean" is a primitive type that cannot have a "null" value. When spring tries to read data from the DB this will lead to a NullPointerException!


styles(cascader): [cascader] add cascader types

PR
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our Commit Message Guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

cascader 组件有个 #1319 的PR，如何合并的话，我这边需要改一改


Update Skills for Business Administration for Ayom

Name
Ayom Ruei Ayom
Languages
English and Dinka
Skill 1
Financial literacy
Qualifications for Skill 1
Both certificate and degree in business administration, specializing in financial management.
Skill 2
No response
Qualifications for Skill 2
No response
Skill 3
No response
Qualifications for Skill 3
No response
Skill 4
No response
Qualifications for Skill 4
No response
LinkedIn
+211924097008
Other
No response

@wunbaai  should I put the telephone number you put under "linkedin" as your phone contact? And also as your whatsapp contact?

My region is Upper Nile.
Contact: +211924097008; it's the WhatsApp number as well.
Skills: I have a skill in business especially in financial management.
Qualifications: Degree in business administration

thank you! Profile Data has been updated

My region is Upper Nile. Contact: +211924097008; it's the WhatsApp number as well. Skills: I have a skill in business especially in financial management. Qualifications: Degree in business administration

should we apply the region Bor Town? → I'm thinking of a more close to location region to better find people with same region, but sure at some point a map is easier (future feature)

well Upper Nile is fine properly same size as Rhino Camp in Uganda probably :D

One of the skills; I had participated in ASKNET training in which I learned many things.

let's continue the dialogue here: https://github.com/ASKnetCommunity/LEAD/issues/126


Add statistics/historic data

Add historic data using csv files

[x] Each race should be represented by a row inside the csv file containing

[x] The odds of each horse
[x] The odds of the horse a bet was placed on
[x] The odds of the horse that won
[x] The payout/loss

[x] Once stopped, the program should add some information about the current session

[x] The winnings
[x] The time running
[x] The number of won/lost bets
[x] The number of bets skipped
[x] The amount of money spent on bets

[x] Add a button inside the ui for enabling/disabling the collection of historic data
[x] Add a reader for the horses that won

Still broken: csv separators


apply_fixes missing_deps discovery respects visibility

Followup to https://github.com/martis42/depend_on_what_you_use/issues/18
Currently the feature to automatically add missing direct dependencies does not consider if a discovered dependency is visible to the target under inspection.
Assuming we make no error in matching include statement to target, there are 2 cases we can resolve by implementing this:

If multiple targets in the dependency tree provide a given header we skip this right now with a warning. With visibility we could potentially decide which target to choose.
Even if we find only a single dependency, it might be invalid. If aliases are involved we might add a target which breaks the build, although the added dependency provides the required header.

https://bazel.build/query/language#visible


HDDS-3996. Missing TLS client configurations to allow ozone.grpc.tls.…

…enabled.
What changes were proposed in this pull request?
Adding proper TLS client configuration for Client to talk to SSL enabled GRPC server (Ratis).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3996
How was this patch tested?
Testing with real cluster and ensure the Ratis Three Pipeline can be created by SCM when ozone.grpc.tls.enabled=True.
This needs additional fix from HDDS-3997 to successfully pass SSL handshake between GRPC/Netty client/server.

+1 for the patch.

Thansk @jnp  for the review. I will merge it shortly.


Lint autocorrect fixes

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

We should consider running SwiftLint for our test files in CI as well, like we do for source code and the test apps.


Error: 500 update pools failed: VM XXX is already a pool member

Hi,
I have such a problem. After upgrading from proxmox 6.4 to proxmox 7.1-7 mi, terraform scripts discard this error when validating.
Error: 500 update pools failed: VM XXX is already a pool member
This bug occurs in terraform proxmox 2.7.4 as well as in the latest version 2.9.3
However, in the older version of proxmox 6.4, terraform proxmox 2.7.4 ran without problems and the error did not occur.
Please do not know what the problem might be?
Thanks

fixed, it was enough to add the rights of the proxmox account through which the terraform proxmox provider got to proxmox.
You needed to add the Pool.Audit right

fixed, it was enough to add the rights of the proxmox account through which the terraform proxmox provider got to proxmox.
You needed to add the Pool.Audit right


Ingestion from UI should throw better error when Airflow is not configured with OpenMetadata Instance

Affected module
Does it impact the UI, backend or Ingestion Framework?
UI bug when using Open Metadata Helm Charts and spinning up instance.
Describe the bug
Below are the steps I performed -

Install open metadata from helm charts
Add a service (example redshift)
Add ingestion without airflow configuration
UI Lets you add Ingestion for the first time
UI does not display appropriate error if ingestion fails

Screenshots or steps to reproduce

https://user-images.githubusercontent.com/15995028/155470405-d73f15aa-344e-4c6c-8c05-591ca31ac52d.mov
Expected behavior
UI should not let you add ingestions if no Airflow configuration is setup
Version:

OS: Linux
OpenMetadata version: 0.8.4

@pmbrull it would be good to support /status on the airflow APIs side. OpenMetadata can make this call and see if the Airflow that the user configured has our APIs, if not throw an appropriate error response.


仮想チャンネルを選択すると真っ白な画面になる

ChannelList.tsx:50
 Warning: Each child in a list should have a unique "key" prop.

Check the render method of `ChannelList`. See https://reactjs.org/link/warning-keys for more information.
    at ChannelList (http://localhost:3000/static/js/bundle.js:435:63)
    at RenderedRoute (http://localhost:3000/static/js/bundle.js:56385:5)
    at Routes (http://localhost:3000/static/js/bundle.js:57119:5)
    at div
    at ThemeProvider (http://localhost:3000/static/js/bundle.js:2725:50)
    at App (http://localhost:3000/static/js/bundle.js:55:88)
    at Router (http://localhost:3000/static/js/bundle.js:57053:15)
    at BrowserRouter (http://localhost:3000/static/js/bundle.js:54954:5)
ChannelList	@	ChannelList.tsx:50
history.ts:701
 Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at createURL (history.ts:701:1)
    at Object.encodeLocation (history.ts:729:1)
    at hooks.tsx:475:1
    at Array.map (<anonymous>)
    at useRoutesImpl (hooks.tsx:467:1)
    at useRoutes (hooks.tsx:344:1)
    at Routes (components.tsx:515:1)
    at renderWithHooks (react-dom.development.js:15486:1)
    at updateFunctionComponent (react-dom.development.js:19617:1)
    at beginWork (react-dom.development.js:21640:1)
history.ts:701
 Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at createURL (history.ts:701:1)
    at Object.encodeLocation (history.ts:729:1)
    at hooks.tsx:475:1
    at Array.map (<anonymous>)
    at useRoutesImpl (hooks.tsx:467:1)
    at useRoutes (hooks.tsx:344:1)
    at Routes (components.tsx:515:1)
    at renderWithHooks (react-dom.development.js:15486:1)
    at updateFunctionComponent (react-dom.development.js:19617:1)
    at beginWork (react-dom.development.js:21640:1)
react-dom.development.js:18704
 The above error occurred in the <Routes> component:

    at Routes (http://localhost:3000/static/js/bundle.js:57119:5)
    at div
    at ThemeProvider (http://localhost:3000/static/js/bundle.js:2725:50)
    at App (http://localhost:3000/static/js/bundle.js:55:88)
    at Router (http://localhost:3000/static/js/bundle.js:57053:15)
    at BrowserRouter (http://localhost:3000/static/js/bundle.js:54954:5)

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://reactjs.org/link/error-boundaries to learn more about error boundaries.
history.ts:701
 Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at createURL (history.ts:701:1)
    at Object.encodeLocation (history.ts:729:1)
    at hooks.tsx:475:1
    at Array.map (<anonymous>)
    at useRoutesImpl (hooks.tsx:467:1)
    at useRoutes (hooks.tsx:344:1)
    at Routes (components.tsx:515:1)
    at renderWithHooks (react-dom.development.js:15486:1)
    at updateFunctionComponent (react-dom.development.js:19617:1)
    at beginWork (react-dom.development.js:21640:1)

9cc32c8bf2a3e555064a12cb48104656dabc8521 で修正。


bootstrap collapse does not work in dynamic content

Bootstrap 4.3.1
from maxcdn.bootstrapcdn.com/bootstrap/4.3.1/js/bootstrap.min.js
and maxcdn.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css
bootstrap collapse does not work in dynamic content!((
I try to loading html
id=accorion.... from https://getbootstrap.com/docs/4.0/components/collapse/
by ajax and "collapse card" not expanding... and nothing not helped me :-(
p.s. https://github.com/twbs/bootstrap/issues/2274

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via CodePen/JS Bin or Stackblitz and report back with your link, Bootstrap version, and specific browser and OS details.
This is an automated reply

Closing due to lack of response. You can comment here and we can re-open the issue.
This is an automated reply


cog fails to use custom image

I'm trying to use this image:
nvidia/opengl:1.2-glvnd-runtime-ubuntu22.04
I've put this in my cog.yaml
image: docker.io/nvidia/opengl:1.2-glvnd-runtime-ubuntu22.04
However, cog is not picking up the new image and instead fallsback? to a base image without showing any error to the user. Here is the output when I run predict:
Building Docker image from environment in cog.yaml...
⚠ Stripping patch version from Python version 3.10.6 to 3.10
[+] Building 1.6s (13/13) FINISHED                                                                                docker:default
=> [internal] load build definition from Dockerfile                                                                                0.0s
=> => transferring dockerfile: 515B                                                                                0.0s
=> resolve image config for docker-image://docker.io/docker/dockerfile:1.4                                                                     0.8s
=> [auth] docker/dockerfile:pull token for registry-1.docker.io                                                                                0.0s
=> CACHED docker-image://docker.io/docker/dockerfile:1.4@sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94c4e84ced81e24ef1a0dbc               0.0s
=> [internal] load .dockerignore                                                                                0.0s
=> => transferring context: 2B                                                                                0.0s
=> [internal] load metadata for r8.im/cog-base:cuda11.8-python3.10                                                                             0.6s
=> [stage-0 1/5] FROM r8.im/cog-base:cuda11.8-python3.10@sha256:6e2e6a0e4539b9dae698489def51a84e1aca3edab7b47eb8a14e3186cac7b60f
Expectation: I can specify custom images
Actual: Specifying custom image doesn't do anything and it fallsback to the bolded base image

Hi @fewjative. Thanks for reporting, and sorry for any inconvenience there.
We recently introduced a change https://github.com/replicate/cog/pull/1778 to make use of Cog base images default, and that appears to have caused a regression in how explicit image values are interpreted. Can you try re-running with the option --cog-use-base-image=false?

Hi @fewjative. The image field in cog.yaml has to do with the name given to the resulting image, not the base image used.
We don't currently support specifying a custom base image. You can run cog debug to generate a Dockerfile and swap out the base image, but if you're deploying to Replicate, I'd advise against doing that if possible, as it won't be optimized for our infrastructure and isn't guaranteed to boot correctly.
Instead, you can install any additional system dependencies by listing them in system_packages or adding any custom configuration as run steps.

Ah I see. I think I would need to use a custom image in my case as from my own experience with deploying to replicate, the current base images used don't provide GPU acceleration. They'll use the GPU for ML tasks via cuda but if you want to do something like run OpenGL, then the current Replicate base image will fallback to software rendering. Closing but if you know how to otherwise get GPU accel working, please let me know!

@fewjative I haven't tried this myself, but I don't see any reason why you couldn't deploy a model to Replicate that uses the GPU to do accelerated rendering with OpenGL. This article from NVIDIA is old and maybe out of date, but mentions using EGL for headless rendering. You should be able to add libOpenGL and libEGL to the system_packages of your cog.yaml and use something like pegl in your predict function.


CA-229: Fix multi-region error in complete example of terraform-aws-tamr-config

Workaround for running scripts from an S3 bucket from outside of us-east-1 on the complete example.

Changed EMR bootstrap action.
Disable NatGateway as default value on complete example.

@souza-dan

Good that we have this workaround documented, but let's not make this the default behavior.


transmission-gtk: fixup build on darwin

Maybe the explicit linker flag isn't needed (anymore?) -
I'm not a darwin person; this might at least fix the build.
Things done

Built on platform(s)

[x] no rebuild  x86_64-linux
[x] no rebuild  aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I'm impatient
@ofBorg build transmission-gtk

Uh, still not found :-/

https://github.com/ofborg build transmission-gtk

Well, it builds again, but it would be nice of someone (with darwin) tried at least that it starts up and shows the GUI.  I'm hopeful, as commit that introduced it years ago (6695954d48ac) mentions building and not runtime problem.

@risicle @siraben can you help out?

cc @NixOS/darwin-maintainers

It builds correctly and it starts, but it has some issues, the icons aren't loading properly:
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.820: Error loading theme icon 'media-playback-pause' for stock: Icon 'media-playback-pause' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.821: Error loading theme icon 'list-remove' for stock: Icon 'list-remove' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.821: Error loading theme icon 'document-properties' for stock: Icon 'document-properties' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.825: Error loading theme icon 'system-run' for stock: Icon 'system-run' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.825: Error loading theme icon 'go-down' for stock: Icon 'go-down' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.826: Error loading theme icon 'go-up' for stock: Icon 'go-up' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.826: Error loading theme icon 'media-playback-pause' for stock: Icon 'media-playback-pause' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.827: Error loading theme icon 'view-refresh' for stock: Icon 'view-refresh' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.828: Error loading theme icon 'dialog-error' for stock: Icon 'dialog-error' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.829: Error loading theme icon 'system-run' for stock: Icon 'system-run' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.830: Error loading theme icon 'go-down' for stock: Icon 'go-down' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.830: Error loading theme icon 'go-up' for stock: Icon 'go-up' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.831: Error loading theme icon 'media-playback-pause' for stock: Icon 'media-playback-pause' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.832: Error loading theme icon 'view-refresh' for stock: Icon 'view-refresh' not present in theme Adwaita
(transmission-gtk:64552): Gtk-WARNING **: 22:11:44.833: Error loading theme icon 'dialog-error' for stock: Icon 'dialog-error' not present in theme Adwaita

but I think the bigger problem is that the gtk UI is not what macOS users would want anyway, this is the comparison of the transmission gtk build (left) and the transmission macOS build (right):

Note that even if the icons were loading properly, the chrome and the UI elements don't match. In particular the menu items are attached on the window like they usually are on linux and windows, instead of on the menu bar at the top of the screen like it usually is on mac.

Ah right, so missing icons is an independent issue that I can reproduce on Linux by env XDG_DATA_DIRS= transmission-gtk

The torrent functionality itself doesn't seem to work: opening a torrent file results in ** Message: 22:20:59.486: Skipping unknown torrent "/Users/uri/Downloads/Nixos Gnome 21.11.333 64bit ISO.torrent", and the torrent isn't added.
Opening a magnet link adds the torrent, but shows some errors:
(transmission-gtk:64646): Gtk-CRITICAL **: 22:24:38.316: gtk_icon_info_load_icon: assertion 'icon_info != NULL' failed
(transmission-gtk:64646): GLib-GObject-CRITICAL **: 22:24:38.316: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
(transmission-gtk:64646): GLib-GObject-CRITICAL **: 22:24:38.317: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
(transmission-gtk:64646): Gtk-CRITICAL **: 22:24:38.317: gtk_icon_info_load_icon: assertion 'icon_info != NULL' failed
(transmission-gtk:64646): GLib-GObject-CRITICAL **: 22:24:38.317: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
(transmission-gtk:64646): GLib-GObject-CRITICAL **: 22:24:38.320: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

and it doesn't seem to be downloading anything.

transmission-cli in the same package seems to be adding the torrent correctly (note that a torrent file was saved to the application data directory, which didn't happen from the GUI):
> /nix/store/636by7gjmq7r1q22hm8281awvgbg93if-transmission-3.00/bin/transmission-cli -w /Users/uri/Downloads/ 'magnet:?xt=urn:btih:9b4c1489bfccd8205d152345f7a8aad52d9a1f57&dn=archlinux-2022.05.01-x86_64.iso'
transmission-cli 3.00 (0)
[2022-05-09 22:28:09.026] Transmission 3.00 (0) started
[2022-05-09 22:28:09.027] RPC Server: Adding address to whitelist: <IP_ADDRESS>
[2022-05-09 22:28:09.027] RPC Server: Adding address to whitelist: ::1
[2022-05-09 22:28:09.027] DHT: Generating new id
[2022-05-09 22:28:09.079] Saved "/Users/uri/Library/Application Support/transmission/Torrents/9b4c1489bfccd8205d152345f7a8aad52d9a1f57.torrent"
[2022-05-09 22:28:09.359] Port Forwarding (NAT-PMP): initnatpmp succeeded (0)
[2022-05-09 22:28:09.359] Port Forwarding (NAT-PMP): sendpublicaddressrequest succeeded (2)
[2022-05-09 22:28:17.365] Port Forwarding: State changed from "Not forwarded" to "Starting"
[2022-05-09 22:28:17.865] Port Forwarding (NAT-PMP): readnatpmpresponseorretry succeeded (0)
[2022-05-09 22:28:17.865] Port Forwarding (NAT-PMP): Found public address "<IP_ADDRESS>"
[2022-05-09 22:28:17.865] Port Forwarding (NAT-PMP): sendnewportmappingrequest succeeded (12)
[2022-05-09 22:28:18.198] Port Forwarding (NAT-PMP): readnatpmpresponseorretry succeeded (0)
[2022-05-09 22:28:18.198] Port Forwarding (NAT-PMP): Port 51413 forwarded successfully
[2022-05-09 22:28:18.198] Port Forwarding: State changed from "Starting" to "Forwarded"
Progress: 0.0%, dl from 0 of 0 peers (0 kB/s), ul to 0 (0 kB/s) [None]

I retried torrent functionality now on x86_64-linux and that seems good.  I wonder if this brokenness is even related to any recent change (like now when it stopped building on darwin).

Result of nixpkgs-review pr 172138 run on aarch64-darwin 1

1 package marked as broken and skipped:

transmission-qt

2 packages failed to build:

libtransmission
transmission

1 package built:

transmission-gtk

How can I install an icon theme on macOS? I might have to test it again, because of the torrent not being added I had to try a magnet link with only a few seeds (most linux distros provide torrent files not magnet links).

I tested torrents even without icons, though UX is certainly worse.
I'd expect the installation would be like:

ensure $HOME/.nix-profile/share in $XDG_DATA_DIRS
nix-env -iA nixpkgs.tango-icon-theme (or some other one)
maybe you need to select the theme in some gtk settings?  (I've been using xfce4-appearance-settings for this on NixOS)

Oh, this actually isn't a channel blocker for nixpkgs-unstable, but it would become a channel blocker for 22.05-darwin (or whatever it will get called).

Thank you!


WIP: Web typography presets

What are you changing?
Implements updated typography presets for web. This is a draft and only includes presets for headline styles.
Each preset is defined as an individual token:
"headlineMedIta24": {
  "$value": {
    "fontFamily": "{typography.fontFamily.headline}",
    "fontSize": "{typography.fontSize.24}",
    "lineHeight": "{typography.lineHeight.tight}",
    "fontWeight": "{typography.fontWeight.medium}",
    "fontStyle": "italic"
  }
}

These can then be used via the typography export:
const headline = css`
  ${typography.headlineMedIta24};
`;

Each preset encapsulates a complete typographic style so there are no options.

Closing as this has served its purpose of being a place to try out ideas and get feedback. Now we've established an approach to implementing the new presets this will be done in a series of smaller, incremental PRs.


Transactions List should be able to clear all transactions#274

"Clear transactions" button is needed for this

On hover show tooltip
After click show the popover
Stays open until you click an action or away or close the sidebar

https://www.figma.com/file/DTJwC2mQ9kvyjM0171tqHR/airswap-web?type=design&node-id=16007-29110&mode=design&t=2LDzUbolpKfIvRVY-4

Demo of tooltip on light & dark mode. Not shown in demo, but clearing transactions also clears local storage of your transactions:
https://github.com/airswap/airswap-web/assets/90465420/7f4fe246-d4b1-4ea2-a48a-cee9c8821c8e

I worked on this issue and put my code in #797 . The video above should be in #797, I will also upload it there.
The reason I worked on it in that issue is because this issue calls to clear all transactions, and the other issue calls to clear failed transactions. Both issues rely on the same design that 2x posted, which is why I merged issues. When issue #797 gets merged into develop, I'll also close this issue


SCM view fails to reflect changes after committing changes to a GitHub repo on insiders.vscode.dev

The SCM View buttons also become unresponsive after the first attempt at staging and commiting. The changes are however commited to github.com
I also lose the branch picker.

@bhavyaus are there any error messages in the developer tools log when the branch picker disappears (and does it disappear after committing)?

This is a performance regression that is attributable to the rich nav endpoint taking upwards of a minute to return 404 responses when we request specific snapshots.
Workaround is to set "remoteHub.richNavigation.enabled": false.

Got fixed and merged into main.

@dbaeumer thank you!


Reference glossary terms in Pod Lifecycle documenttion

This PR also changes “Container” to “container” in quite a few places.
I'm recommending this change because there's no object named Container (as seen by Kubernetes' control plane).
The aim here is to emphasize Pod as the primary unit of deployment, and to signpost confused users towards further documentation.

Hugo is less happy with these changes than I'd realised. I'll close this, maybe resubmit in the future.


Update Github Action workflows follow Github Action team convention

Why
Our current Github Action workflows code style doesn't follow the team convention. So we need to update.
Here is the list of what we already follow and what we need to follow according to the convention

❌  Add a line break between each root-level block
✅  Add a line break between each job step
❌  Refactor workflows naming (should start with a verb)
❌  The name attribute for the job must be provided (some still missing)
❌  The name attribute jobs set must be provided and follow the pattern “Verb description”
✅  Command syntax, both single line (should be on the same line), and multiple lines (using |)
❌  Prefer to set a timeout for each job (currently there’s no job with a defined timeout)

Who Benefits?
@nimblehq/android-chapter

I thought we had already followed 🤔  perhaps you might want to point out some examples so that others can take care of the issue, @lydiasama

I thought we had already followed 🤔 perhaps you might want to point out some examples so that others can take care of the issue, @lydiasama

@sleepylee @lydiasama Updated 👍🏼


Not able to install from obsidian community plugin

When I click on the install button in obsidian then it shows a msg "No appropriate version found".

Hi @Gourav1910
1.7.0 needs to update Obsidian to 14.15 version witch is avaliable since monday

oh ok problem solved. Thanks.

Anytime!


Vagrantfile: Move inline provision script to a separate file

This script is long enough that it was significantly cluttering Vagrantfile, and may benefit from inclusion in our shell linting and formatting setup.
Testing plan: Tested vagrant destroy; vagrant up --provision.

Nice, merged, thanks for the cleanup @andersk!