TabNavigator: Customize onPress functionality for custom tabs?

Right now the TabNavigator has full control of the onPress functionality of what happens when you tap on a tab. All you can really do is specify a screen, and the TabNavigator takes care of the rest.
const Tabs = TabNavigator({
  ...
  SomeScreen: { screen: SomeScreen },
  ...
});

What if I want to render a tab, but with custom onPress functionality rather than pushing or jumping to a new screen? Consider yelp's "Add" tab:

Tapping the "+" doesn't push a new screen or jump to a new tab. It simply renders an overlay over the existing screen.

Is it possible to reacreate the Yelp example with the existing TabNavigator API? I've been scratching my head over this. Thanks!

Reddit is another example:

hi man, did you find some way to handle the custom events of tabs on TabNavigator?

Not yet, I'm also waiting to hear from the authors on possible ways we can achieve this

Me too!

I'm trying to a similar behaviour #1227

@joncursi you can create your own tab bar component quite easily. start by copying the source from TabBarBottom.js
Here is a super-stripped down version I created for my project, doesn't support animation, swipe or tab labels.
You can insert your own custom center button into the view hierarchy here.
import React from 'react';
import { View, StyleSheet, TouchableWithoutFeedback } from 'react-native';

const styles = StyleSheet.create({
  tabbar: {
    height: 49,
    flexDirection: 'row',
    justifyContent: 'center',
    alignItems: 'center',
    borderTopWidth: 1,
    borderTopColor: colors.border,
    backgroundColor: colors.bgLightGrey
  },
  tab: {
    alignSelf: 'stretch',
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center'
  }
});

const TabBar = React.createClass({
  render() {

    const {
      navigation,
      renderIcon,
      activeTintColor,
      inactiveTintColor,
      jumpToIndex
    } = this.props;

    const {
      routes
    } = navigation.state;

    return (
      <View style={styles.tabbar}>

        {routes && routes.map((route, index) => {
          const focused = index === navigation.state.index;
          const tintColor = focused ? activeTintColor : inactiveTintColor;
          return (
            <TouchableWithoutFeedback
              key={route.key}
              style={styles.tab}
              onPress={() => jumpToIndex(index)}
            >
              <View style={styles.tab}>
                {renderIcon({
                  route,
                  index,
                  focused,
                  tintColor
                })}
              </View>
            </TouchableWithoutFeedback>
          );
        })}

      </View>
    );
  }
});

export default TabBar;

and in your tabs navigator definition
const TabsNavigator = TabNavigator(
  {
      ...routeConfig
  },
  {
    tabBarComponent: TabBar,
    tabBarPosition: 'bottom'
  }
);

So what @ofairfoul posted should work? Im looking exactly for this 😮

@joncursi Did you get to recreate the yelp Example? Please IM Stucked!
I used @ofairfoul code but my middle button that opens more options is not overlaying.

No, I haven't gotten it yet either :/

have you checked where that overlay is in your view hierarchy? if its anything like other overlays, you need to actually do this elsewhere than the tab bar itself or utilize zIndex.

+1 (so I can search for this later)...

This use case should be solved by #1335 (will be merging soon)

+1

Pinging OP @joncursi since this issue is quite old and related to an old version of the lib (we merged #1335 so beta.13 has this feature). If no answer I'll close in 7 days.

Hi there @joncursi ,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue (especially if it's a bug report) please open a new issue that uses the new Issue Template to provide some more details to help us solve it.

No, I haven't gotten it yet either :/

Hey @joncursi did you get the solution for this? Please help if you resolve the issue I am tucked here. I want to show exactly the same UI on middle button click.


Hyperparameter tuning

Hello Bayesian Wizards,
I recently worked on something for which the client was not sure about the adstock decay rates.
They said it should be somewhere between 30 to 50% for each of the 5 channels.
As you can understand , selecting and starting with a good set of priors was non trivial.
Though I used optuna to figure out the best set of parameters based on my data, I would like to understand if there is any inherent way within pymc to achieve this?

Hello @wd60622 ,
This is really informative and useful. I will try to understand in detail and get this implemented. BDW, can you please provide a little more details about the pytensor graph from the adstock transformations?
below is the configuration being derived from within optuna based trials:
"""
import optuna
import numpy as np

# Define the objective function to minimize divergences
def objective_minimize_divergences(trial):
    # Suggest values for all parameters
    prior_sigma = trial.suggest_float('prior_sigma', 0.1, 10.0)
    mu_values = [trial.suggest_float(f'mu_{ch}', 0.1, 10.0) for ch in spend_cols]
    alpha = trial.suggest_float('alpha', 0.1, 5.0)
    lam_alpha = trial.suggest_float('lam_alpha', 0.1, 10.0)
    lam_beta = trial.suggest_float('lam_beta', 0.1, 10.0)
    likelihood_sigma = trial.suggest_float('likelihood_sigma', 0.1, 10.0)
    gamma_control_mu = trial.suggest_float('gamma_control_mu', -5.0, 5.0)
    gamma_control_sigma = trial.suggest_float('gamma_control_sigma', 0.1, 10.0)
    gamma_fourier_mu = trial.suggest_float('gamma_fourier_mu', -5.0, 5.0)
    gamma_fourier_b = trial.suggest_float('gamma_fourier_b', 0.1, 10.0)
    intercept_tvp_m = trial.suggest_int('intercept_tvp_m', 10, 50)
    intercept_tvp_ls_mu = trial.suggest_float('intercept_tvp_ls_mu', 50, 200)
    intercept_tvp_ls_sigma = trial.suggest_float('intercept_tvp_ls_sigma', 0.1, 5.0)
    intercept_tvp_eta_lam = trial.suggest_float('intercept_tvp_eta_lam', 0.1, 10.0)

    # Define the model config with the suggested parameters
    my_model_config = {
        'intercept': {'dist': 'HalfNormal', 'kwargs': {'sigma': 0.05}},
        'beta_channel': {
            'dist': 'LogNormal',
            "kwargs": {"mu": np.array(mu_values), "sigma": prior_sigma}
        },
        'alpha': {'dist': 'Beta', 'kwargs': {'alpha': alpha, 'beta': 3}},
        'lam': {'dist': 'Gamma', 'kwargs': {'alpha': lam_alpha, 'beta': lam_beta}},
        'likelihood': {'dist': 'Normal', 'kwargs': {'sigma': {'dist': 'HalfNormal', 'kwargs': {'sigma': likelihood_sigma}}}},
        'gamma_control': {'dist': 'Normal', 'kwargs': {'mu': gamma_control_mu, 'sigma': gamma_control_sigma}},
        'gamma_fourier': {'dist': 'Laplace', 'kwargs': {'mu': gamma_fourier_mu, 'b': gamma_fourier_b}},
        'intercept_tvp_kwargs': {
            'm': intercept_tvp_m,
            'L': None,
            'eta_lam': intercept_tvp_eta_lam,
            'ls_mu': intercept_tvp_ls_mu,
            'ls_sigma': intercept_tvp_ls_sigma,
            'cov_func': None
        }
    }

    # Define the model
    ollies_mmm = DelayedSaturatedMMM(
        model_config=my_model_config,
        target_column='R',
        date_column='Date',
        validate_data=True,
        channel_columns=spend_cols,
        adstock_max_lag=10,
        yearly_seasonality=2,
        time_varying_intercept=False
    )

    try:
        # Fit the model on the dataset
        idata = ol_mmm.fit(X, y, target_accept=0.95, chains=4, random_seed=43)
        # Check for divergences
        divergences = np.array(idata.sample_stats.diverging.values).sum()
        return divergences
    except Exception as e:
        return float('inf')

# Create and run the Optuna study for minimizing divergences
study_divergences = optuna.create_study(direction='minimize')
study_divergences.optimize(objective_minimize_divergences, n_trials=5)

"""

here the optuna study is designed to minimize the divergences within the trials.

I would think that there would be a more direct way of optimizing the adstock parameter directly then using this loop.
Also, not sure if divergences of the model would be a sign of meeting the client's requirements.
I would toy around with the different AdstockTransformation subclasses that we provide and see if the general shapes that they provide meet their expectations of ad decays based on the channel.

I would think that there would be a more direct way of optimizing the adstock parameter directly then using this loop.
Also, not sure if divergences of the model would be a sign of meeting the client's requirements.
I would toy around with the different AdstockTransformation subclasses that we provide and see if the general shapes that they provide meet their expectations of ad decays based on the channel.

Hi @shuvayan
Any follow ups here or good to close?

I am still using Optuna for the hyper parameter tuning. So if you could guide me towards the pytensor graph based approach you mentioned earlier, that would be great.
I think this is good to close for now.


By clicking on the create debate TOPIC button  the user will be directed to the page where they can enter the topic, description, and tag of the new debate topic they are creating. The user can select multiple tags for topics.

fc80fcf856746a8b06b49420354abf115a9a23e8


Support for ES 7.4.2

Bump to v7.4.2

This project dependency is no longer needed in 7.4.2. Closing this PR


DNS defunct for localtunnel at .focusaurus.com

The saucelabs builds are failing.
@focusaurus can you check your localtunnel/DNS?

I'm investigating. I switched DNS from namecheap to digitalocean but things should have kept working.

I think it's working now. I think the issue was I didn't have a wildcard DNS A record for *.focusaurus.com configured, but while troubleshooting I also updated to the latest defunctzombie/localtunnel-server:latest docker image as well. Can you confirm?

Works. Thanks.


Can Blizzard Account Generator still be used?

Can Blizzard Account Generator still be used?

How to download and use

How to download and use

It says what to do in the readme.


LabelExpression support

Hi,
Lot of our future query generation plans will need to support label expressions, such as :
MATCH (n:Person|Organization)

MATCH (n:(Person|Organization)&!Sanctioned)

I couldn't find this possible yet with the cypher-dsl, I would love to see this feature happen <3

We already support rendering them via LabelExpression, but you are right, there is no builder yet.

I am getting old: https://github.com/neo4j/cypher-dsl/blob/main/neo4j-cypher-dsl/src/test/java/org/neo4j/cypherdsl/core/LabelExpressionTest.java#L39
It is there already.

Thanks @michael-simons !


Fixing dead link

current link is dead. I Propose adding this link for getting Feast installed on Kubernetes: https://docs.feast.dev/v/v0.6-branch/getting-started/deploying-feast/kubernetes

@RFMVasconcelos here is the new PR. The CLA issue appears to have been resolved.

/assign @woop


[Bug] fn(a: u32, s: StreamSink<i32>) generates wiring function with wrong order, i.e. stream_sink is always the first parameter

Describe the bug
At https://github.com/fzyzcjy/flutter_rust_bridge/blob/fa7685afbe5971e347d688cdac85f6b3f534dafb/frb_codegen/src/generator/rust/mod.rs#L246
it does first the stream_sink parameter, then the function parameters.
So, for a function:
pub fn tick(a: u32, sink: StreamSink<i32>) -> Result<(), anyhow::Error> {
    todo!()
}

it generates

#[no_mangle]
pub extern "C" fn wire_tick(port_: i64, a: u32) {
    FLUTTER_RUST_BRIDGE_HANDLER.wrap(
        WrapInfo {
            debug_name: "tick",
            port: Some(port_),
            mode: FfiCallMode::Stream,
        },
        move || {
            let api_a = a.wire2api();
            move |task_callback| tick(task_callback.stream_sink(),api_a)
        },
    )
}

which does not compile. It should be

#[no_mangle]
pub extern "C" fn wire_tick(port_: i64, a: u32) {
    FLUTTER_RUST_BRIDGE_HANDLER.wrap(
        WrapInfo {
            debug_name: "tick",
            port: Some(port_),
            mode: FfiCallMode::Stream,
        },
        move || {
            let api_a = a.wire2api();
            move |task_callback| tick(api_a, task_callback.stream_sink())
        },
    )
}

I changed to
let inner_func_params = [
            func.inputs
                .iter()
                .map(|field| format!("api_{}", field.name.rust_style()))
                .collect::<Vec<_>>(),
            match func.mode {
                IrFuncMode::Normal | IrFuncMode::Sync => vec![],
                IrFuncMode::Stream => vec!["task_callback.stream_sink()".to_string()],
            },
        ]
        .concat();

and it works but obviously it generates errors if
pub fn tick(sink: StreamSink<i32>, a: u32) -> Result<(), anyhow::Error> {
    todo!()
}

but I think it's better for sink to be the last argument because then I can do things like
fn my_object_set_stream_sink(my_object_opaque: MyObjectOpaque, sink: StreamSink<i32>)

it makes sense for the sink to be last, because the object (which is the "self"), should be the first.
Does it make sense?
Codegen logs with RUST_LOG=debug environment variable
_

To Reproduce
No response
Expected behavior
No response
Generated binding code
No response
OS
No response
Version of flutter_rust_bridge_codegen
No response
Flutter info
No response
Version of clang++
No response
Version of ffigen
No response
Additional context
No response

it makes sense for the sink to be last, because the object (which is the "self"), should be the first.

Hmm that sounds reasonable.
But on the other hand, I am thinking sink as a special argument so it is placed always at the first place (a bit like "self" being first).
So, what about modifying the code such that it allows sink to be anywhere
Feel free to PR!

https://github.com/fzyzcjy/flutter_rust_bridge/pull/542


Some errors in style or pattern (ChangeLogTest)?

Failed asserting that '- no changes in this release.' matches PCRE pattern "/- (Bug|Enh|Chg|New)( #\d+(, #\d+)*)?: .*[^.] \(.*\)$/".
 /var/www/html/tests/framework/ChangeLogTest.php:52
 /repo/vendor/phpunit/phpunit/phpunit:53

Failed asserting that '- Bug #14711 (CVE-2018-6010): Fixed `yii\web\ErrorHandler` displaying exception message in non-debug mode (samdark)' matches PCRE pattern "/- (Bug|Enh|Chg|New)( #\d+(, #\d+)*)?: .*[^.] \(.*\)$/".
 /var/www/html/tests/framework/ChangeLogTest.php:52
 /repo/vendor/phpunit/phpunit/phpunit:53

Failed asserting that '- Enh #15496 (CVE-2018-6009): CSRF token is now regenerated on changing identity (samdark, rhertogh)' matches PCRE pattern "/- (Bug|Enh|Chg|New)( #\d+(, #\d+)*)?: .*[^.] \(.*\)$/".
 /var/www/html/tests/framework/ChangeLogTest.php:52
 /repo/vendor/phpunit/phpunit/phpunit:53

Additional info

Q
A

Yii version
2.0.14

PHP version
7.2.2

Operating system
alpine

Already fixed by https://github.com/yiisoft/yii2/commit/a01a67c81cd0ca233653891603c52694ff5135a7

Thanks!


React Native

Can I install it in React Native?

Not sure, but if you give it a try and let me know the results, that would be cool. If it doesn't work out of the box I can add this as a feature request to the backlog.


[BUG] Test test_plus_one_twice (ufunc) fails with NumPy 2.2.x

Describe the bug
We see one test failing when building Cython with NumPy 2.2.x. First seen with NumPy 2.2.0 and still present when building with NumPy 2.2.1.
I searched through issues and saw #6072, which mentioned the same error among many others. We only see this one issue with np.complex128 mentioned below.
======================================================================
FAIL: test_plus_one_twice (ufunc)
Doctest: ufunc.test_plus_one_twice
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.13/doctest.py", line 2327, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for ufunc.test_plus_one_twice
  File "/builddir/build/BUILD/Cython-3.0.11-build/cython-3.0.11/TEST_TMP/36/run/c/ufunc/ufunc.cpython-313-x86_64-linux-gnu.so", line unknown line number, in test_plus_one_twice
----------------------------------------------------------------------
File "/builddir/build/BUILD/Cython-3.0.11-build/cython-3.0.11/TEST_TMP/36/run/c/ufunc/ufunc.cpython-313-x86_64-linux-gnu.so", line ?, in ufunc.test_plus_one_twice
Failed example:
    plus_one_twice(1.j)
Expected:
    ((1+1j), (1+1j))
Got:
    (np.complex128(1+1j), np.complex128(1+1j))
======================================================================
FAIL: test_plus_one_twice (ufunc)
Doctest: ufunc.test_plus_one_twice
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.13/doctest.py", line 2327, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for ufunc.test_plus_one_twice
  File "/builddir/build/BUILD/Cython-3.0.11-build/cython-3.0.11/TEST_TMP/36/run/cpp/ufunc/ufunc.cpython-313-x86_64-linux-gnu.so", line unknown line number, in test_plus_one_twice
----------------------------------------------------------------------
File "/builddir/build/BUILD/Cython-3.0.11-build/cython-3.0.11/TEST_TMP/36/run/cpp/ufunc/ufunc.cpython-313-x86_64-linux-gnu.so", line ?, in ufunc.test_plus_one_twice
Failed example:
    plus_one_twice(1.j)
Expected:
    ((1+1j), (1+1j))
Got:
    (np.complex128(1+1j), np.complex128(1+1j))

Code to reproduce the behaviour:
No response
Expected behaviour
No response
OS
Linux
Python version
3.13.1
Cython version
3.0.11
Additional context
No response

Fixed in 852286242.
It's only an issue with how the tests are displayed though - you don't need to treat it as a "real" failure.


(FACT-2580) Updated tests to use specific methods

In order to be platform flexible when running tests we need to have methods to be able to run chmod and update the modified date on files on hosts.
These requirements were found in Facter acceptance tests.
-chmod - change permissions on files/dirs
-modified_at - updating the modification date on a file
-rm_rf - for deleting files/dirs
-mkdir_p - create directory structure
At the moment these were used running linux based commands (chmod, touch, mkdir, rm) that are not compatible with windows cmd or powershell.

@sebastian-miclea are all those host methods implemented in beaker? if not we'll have to set a minimum beaker version(that contains those methods).

CLA signed by all contributors.

@sebastian-miclea are all those host methods implemented in beaker? if not we'll have to set a minimum beaker version(that contains those methods).
Good catch. Not all of them, some are added with a PR opened on beaker.
I'll updated the PR with beaker version restriction after the one on beaker is merged and released.

Passing build:
https://jenkins-master-prod-1.delivery.puppetlabs.net/view/Adhoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/

jenkins please test this on debian9-64a,debian10-64a,fedora30-64a,osx1014-64a,redhat5-64a,centos7-64a,centos8-64a,redhat7-64a,redhat7-POWERa,sles12-64a,sles15-64a,solaris114-64a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1804-64a,windows10ent-64a,windows2012r2-64a,windows2016-64a,windows2019-64a

jenkins please test this on debian9-64a,debian10-64a,fedora30-64a,osx1014-64a,redhat5-64a,centos7-64a,centos8-64a,redhat7-64a,redhat7-POWERa,sles12-64a,sles15-64a,solaris114-64a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1804-64a,windows10ent-64a,windows2012r2-64a,windows2016-64a,windows2019-64a

jenkins please test this on debian9-64a,debian10-64a,fedora30-64a,osx1014-64a,redhat5-64a,centos7-64a,centos8-64a,redhat7-64a,redhat7-POWERa,sles12-64a,sles15-64a,solaris114-64a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1804-64a,windows10ent-64a,windows2012r2-64a,windows2016-64a,windows2019-64a

jenkins please test this on debian9-64a,debian10-64a,fedora30-64a,osx1014-64a,redhat5-64a,centos7-64a,centos8-64a,redhat7-64a,redhat7-POWERa,sles12-64a,sles15-64a,solaris10-64a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1804-64a,windows10ent-64a,windows2012r2-64a,windows2016-64a,windows2019-64a

jenkins please test this on debian9-64a,debian10-64a,fedora30-64a,osx1014-64a,redhat5-64a,centos7-64a,centos8-64a,redhat7-64a,redhat7-POWERa,sles12-64a,sles15-64a,solaris10-64a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1804-64a,windows10ent-64a,windows2012r2-64a,windows2016-64a,windows2019-64a


Setting diagonal values in the affinity matrix

Hi,
Thanks a lot for your great work! I have a question regarding the diagonal values in the affinity matrix. The function CLIPPER::setMatrixData sets to zero all of the values in the diagonal entries of M and C matrices. However, in the paper it is explicated that those values measure the similarity of the data points that association. As I have that information, I'd like to be able to use it.
I have tried commenting those lines and making clipper work with my forced values in M_ and C_. However, I'm getting wrong results. Could you please let me know how should I set those values? Thanks in advance!

Hi @JoseAndresMR thanks for the question.
Yes, the latest code is heavily optimized to take advantage of sparsity and so the diagonal elements of M are hard-coded to be 1. It may be easiest to try running CLIPPER with your data in MATLAB (https://github.com/mit-acl/clipper/blob/main/matlab/clipper.m).
As a quick example of how the c++ code is optimized and assumes 1s on the diagonal of M (and C), consider
https://github.com/mit-acl/clipper/blob/b66b329fe0cf51ee2fdc6f2812612d2b16fc6487/src/clipper.cpp#L170
By assuming that M = (M_ + I), we can write M*u = M_*u + u. This simple trick saves memory and further reduces the number of elements in the sparse matrix M_. It has the greatest impact in calculations involving the gradient, e.g.,
https://github.com/mit-acl/clipper/blob/b66b329fe0cf51ee2fdc6f2812612d2b16fc6487/src/clipper.cpp#L184
If you really can't use MATLAB to test your data, you might consider using an older (slower) version of the code: https://github.com/mit-acl/clipper/blob/f4e67ec575a2d4d505971ac2ab15fd2208b3a193/src/find_dense_cluster.cpp
In my experience I have seen more benefit in preprocessing the initial set of putative matches -- i.e., using the weights that you would have put on the diagonal to threshold which matches are no good, allowing you to throw them out early on, thus speeding up and making the consistent measurement selection step easier.

closing for now, but feel free to re-open / continue the discussion


promtool: Support some kind of “lint” for rules

promtool check rules currently is documented as a way to syntax check rules. However it also checks for duplicate rules, which is closer to a lint check.
There are some features in PromQL that are potentially problematic to use in recording rules now:

Negative offset is likely incorrect in recording rules (I mentioned some kind of lint then)
Subqueries are often not a good idea (noted on the blog post)

I propose something like a --lint flag where the default is “duplicate-rules” to match current behaviour, but could also accept --lint=all, etc.
(Some overlap with #8607)

This was planned was part of #7779 but that's inactive at the moment for the reviewing process. If we can resume work there, then I can extend the pretty process as described here.

This sounds like a good idea.


Update doc supported .NET 6 runtime

Resolves #1563
I updated only .NET 6 features; I would add .NET 7 when the full list of features is ready.

I would add .NET 7 when the full list of features is ready.

It's fine to document .NET 7 features that are already available. That way we don't forget about them.


Add Alex-Welsh to Release Train team

Terraform Format and Style 🖌success
Terraform Initialization ⚙success
Terraform Validation 🤖success
Validation Output

Success! The configuration is valid.

Terraform Plan 📖success
Show Plan

undefined

Pusher: @markgoddard, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

:partying_face:


add Provide credential for private OCI registry authentication guide

related issue: https://github.com/kyma-project/module-manager/issues/201

I suggest to move the guide to the user guides, other than that will have to do a detailed review next

moved to docs/user


Make defined check for null as well

Having definedNotNull and defined seems silly in hindsight and has been the source of bugs when someone uses defined when definedNotNull is needed.  This simply makes defined check for null as well and deprecated definedNotNull.
There were only two objects in the code that relied on defined returning true for null GeoJsonDataSource and Fullscreen.  Both only required minimal changes and they were for edge cases.
Also ran sortRequires
I still want to run some performance numbers against the built Cesium to see if this has any affect (but I doubt it will).

Have you considered deprecating defined and keep definedNotNull instead?

Have you considered deprecating defined and keep definedNotNull instead?

Talking with some of the other devs offline, most people prefer the shorter defined and feel that it makes reading the code easier.  definedNotNull is both wordy and longer to type.

@mramato looks great!
My only comment is that there are a few places in the code that do if (whatever !== null) { ...
Do you think those should be updated to use defined instead?

Please profile as we discussed offline.

Please profile as we discussed offline.

Yes, I said tha tin my PR description, I just didn't get to it yet.

Profiled the combined file with pragmas removed and a CZML file loaded and animating, performance was identical in both cases.  So this is ready.

Did you check the profiler or just the frame rate?  In the profiler, how much did defined show up before and after?

Also, don't test with the CZML example; it has bottlenecks elsewhere that could hide if there is an issue here.  Test with a full-screen horizon terrain view in the steady state (no new tiles being loaded).  That is worse-case-ish.  I expect the different will be insignificant, but it will be good to know since we've put a lot of effort into not burning CPU cycles in the low-level code.

Of course I checked the profiler.  The results were negligible in both cases and defined doesn't always even show up.
I feel CZML is a better test case here because anything time-dynamic using data sources ends up calling defined a lot in the visualizer and those checks can't be inside a pragma so they don't get taken out at build time.  I also think it's more of a real world test case since most users use the Entity API.
That being said,  I ran the case that you asked for and the results were unchanged.  defined only shows up in the profile sometimes and when it does it was  ~0.01% to ~0.03% of the overall time.

Ah, excellent!

Merged in master, this is ready unless anyone has any additional feedback.

@hpinkos please merge when you are happy with this.

Looks good. Thanks @mramato!


Preview Cleanup + Seperating Components

This PR seperates out feature components from the screen file. It's actually a bit cumbersome to leverage previews when there are a BUNCH of previews in the same file. Also discoverability suffers, so I moved a bunch of things out into their own component files. This also makes it easy to see the various states of each component.
It also isolates the screen files to only have previews at the screen level.

#120  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Rahkeen and the rest of your teammates on  Graphite


Can texts be using as a work?

MW23703_3874 only exists as texts like this one, should we use one of these IDs to create the work or is there a way to create a new work ID?

I'm not sure I understand, if I follow your first link, I see it's already associated to a work, WA0RT3219, why would you want to use another one?

this was a misunderstanding


update api part

This PR resolves #195
PR Checklist
Please ensure that you have done the following:

[x] PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.
[ ] If you're not on the contributors list, add yourself to AUTHORS.rst.

Quick Check
To do a very quick check that everything is correct, follow these steps below:

[x] Run the command make check from pyjanitor's top-level directory. This will automatically run:

black formatting
pycodestyle checkin
running the test suite
docs build

Code Changes
If you are adding code changes, please ensure the following:

[x] Ensure that you have added tests.
[x] Run all tests ($ pytest .) locally on your machine.

[ ] Check to ensure that test coverage covers the lines of code that you have added.
[ ] Ensure that all tests pass.

Documentation Changes
If you are adding documentation changes, please ensure the following:

[x] Build the docs locally.
[x] View the docs to check that it renders correctly.

PR Description
Please describe the changes proposed in the pull request:

Added examples for API part in Readme.rst

Relevant Reviewers
Please tag maintainers to review.

@ericmjl

@Rajat-181, this is a great PR! Thanks for the contribution!


dead link

The link http://sachaschmid.ch/bookmarklets/ is dead.

Yeah, it has been moved to http://sacha.me/bookmarklets/
Thanks for letting me know!


Swagger-UI template does not includes oauth2-redirect.html

Hi,
OAuth2 flows requiring a redirect (such as authorization code) are not working because Swagger-UI will request the token to be received on oauth2-redirect.html, and this file does not exists:

Looking at the new plugins repository that you introduced with the future version 4, it looks like a new endpoint will be added (not sure if it will serves the .html though as it seems to be on /oauth2-redirect and not /oauth2-redirect.html).
Can you confirm that this is a known issue with v3 and v4 will fix it? Or should we expect a fix in v3?
Thanks again
Environment:

Python version: 3.11.8
Operating system: Linux
Flask version: 2.2.5
flask-openapi3 version: 3.1.3

This feature is indeed implemented in the v4 release, using the route /openapi/swagger/oauth2-redirect.
The v4 (v4.0.0rc2) version is initially available, but there are some breaking updates, and the documentation is not ready. Here's how to use this feature:
from flask_openapi3 import Info
from flask_openapi3 import OpenAPI

info = Info(title='oauth API', version='1.0.0')

# https://spec.openapis.org/oas/v3.1.0#implicit-oauth2-sample
oauth2 = {
    "type": "oauth2",
    "flows": {
        "implicit": {
            "authorizationUrl": "/openapi/swagger/oauth2-redirect",
            "scopes": {
                "write:pets": "modify pets in your account",
                "read:pets": "read your pets"
            }
        }
    }
}
security_schemes = {"oauth2": oauth2}

app = OpenAPI(__name__, info=info, security_schemes=security_schemes)

# https://github.com/swagger-api/swagger-ui/blob/0ce792c9d0965a8b6b5d75f5e1341ff6936a4cb0/docs/usage/oauth2.md
oauth_config = {
    "clientId": "xxx",
    "clientSecret": "xxx"
}
app.config["OAUTH_CONFIG"] = oauth_config

# https://spec.openapis.org/oas/v3.1.0#oauth2-security-requirement
security = [
    {"oauth2": ["write:pets", "read:pets"]}
]

@app.get("/", security=security)
def oauth():
    return "oauth"

if __name__ == '__main__':
    app.run(debug=True)

Thanks for the quick reply,
I think we are mixing concerns here.
The authorization URL is a parameter related to the OAuth2 flow, this is not something you can really tweak as this is supposed to be related to your identity provider.
Looking at Swagger-UI documentation, there is a oauth2RedirectUrl parameter that can be provided to the SwaggerUI constructor, and I assume the same applies to the SwaggerUIBundle parameter that you are using in the plugins.
Meaning this parameter can be provided via the SWAGGER_CONFIG flask configuration key.
It looks like no default value for this setting is set by flask-openapi3, so it could in theory be provided. My only concern is that this URL will have to be a full one, and not a path that would be appended afterwards. You can see that this is what is done for the default value in Swagger-UI.
To sum this up, I think it should be the responsability of either flask-openapi3, either the flask-openapi3 swagger-ui plugin to set this value properly.
In the meantime I will see if I can try this out on my end by providing a https://my_server/openapi/swagger/oauth2-redirect type of URL.

An other solution (and maybe a cleaner one) would be to serve the redirect page in the expected Swagger-UI default route. I created a PR for this.

The PR above has been merged, now please upgrade flask-openapi3-swagger to the latest version

I confirm the redirection works now !
Thanks again for the reactivity


BraceWrapping is uneditable

BraceWrapping is set as "Default" and is uneditable. The frontend should be able to handle the nested configuration options.

Same here. I tried a workaround by uploading, however, it throws the error "The file you uploaded does not appear to be a valid YAML file"
It appears to throw the exception when the following lines below are present. It's a shame too because these lines are critical to our formatting rules.
A good example for a .clang-format file that throws these false-positive errors can be found at https://github.com/intel/parameter-framework/blob/master/.clang-format
# Configure each individual brace in BraceWrapping
BreakBeforeBraces: 'Custom'

# Control of individual brace wrapping cases
BraceWrapping: {
    AfterClass: 'true'
    AfterControlStatement: 'false'
    AfterEnum : 'true'
    AfterFunction : 'true'
    AfterNamespace : 'true'
    AfterStruct : 'true'
    AfterUnion : 'true'
    BeforeCatch : 'false'
    BeforeElse : 'false'
    IndentBraces : 'false'
}

@DamianSuess
In your case the reason for the error is because you're using curly braces.
From what I gather, YAML only allows curly braces for inline lists.
Also you've quoted what are supposed to be boolean values.

Either way, this bug is still a valid issue.

@DamianSuess I just double checked the spec and it seems that YAML does permit braces to be used in such a way and has done for some time.
(However the lack of commas in intel's example appears to be non-standard, so it's possible that their parser either has a bug or a non-standard feature.)
The spec for YAML versions 1.0, 1.1 and 1.2 all give the following as example 2.6:
Mark McGwire: {hr: 65, avg: 0.278}
Sammy Sosa: {
    hr: 63,
    avg: 0.288
  }

In light of this I decided to test:
# Configure each individual brace in BraceWrapping
BreakBeforeBraces: 'Custom'

# Control of individual brace wrapping cases
BraceWrapping: {
    AfterClass: true,
    AfterControlStatement: false,
    AfterEnum: true,
    AfterFunction: true,
    AfterNamespace: true,
    AfterStruct: true,
    AfterUnion: true,
    BeforeCatch: false,
    BeforeElse: false,
    IndentBraces: false
  }

With clang-format configurator it didn't work, so I believe you have indeed found a bug related to YAML parsing.
However, I dug into it a bit more and it seems the issue is actually with Jérémy Faivre's (@jeremyfa) yaml.js.
It has been raised as issue #28.
So rather than raising an issue here, it would be better to bring attention to the issue on yaml.js, get it fixed there, and then clang-format configurator can just update its library and the problem should be fixed.


Ads playlist like VMAP

Hi,
I want to make a ads playlist like this:
1 preroll linear
1 midroll nonlinear (10 sec. on content video)
1 midroll linear (60 sec. on content video)
1 postroll linear
Normally, html5 ima sdk handle this with VMAP, but it is not support overlays in VMAP yet. So, how can I handle ads playlist with videojs-ima?

Hi there,
The videojs-ima plugin uses the IMA SDK under the hood, so we won't have support for this until the IMA SDK does.
Thanks,
Shawn


AstInfo: define implicit explicitly for each tree

@tgodzik ptal, this seems to work with scala3 as well. i tried it with your tgodzik/scalameta/cross-publish2 branch.


RFlink immediately disconnects upon receiving messages

Home Assistant release (hass --version):
0.39.1
Python release (python3 --version):
Python 3.5.2
Component/platform:
PINE64 on Ubuntu 16.04 (ARM64)
Description of problem:
Hi @aequitas, first off, thanks for the RFlink implementation effort! Unfortunately currently it doesn't work for me at all.
I've just received an RFlink and upgraded it to the latest firmware (R45) which went ok. I can see incoming messages in RFLinkLoader program as well. On home-assistant nothing seems to arrive though, even thought the device is reported as connected.
After installing rflink through pip, I can confirm those errors:
stefan@pine64:~$ rflink -vv -p /dev/ttyACM0
DEBUG:asyncio:Using selector: EpollSelector
DEBUG:rflink.protocol:connected
ERROR:rflink.protocol:disconnected due to exception
NoneType

This happens after every message I send with a KAKU remote or from a pilight installation with another 433mhz transmitter. Output also stops here. Have any idea how I can gather more information on what exactly is going wrong?
Problem-relevant configuration.yaml entries and steps to reproduce:
rflink:
  port: /dev/serial/by-id/usb-Arduino__www.arduino.cc__0042_55639313533351F0B1B0-if00

Nevermind, rebooted my PINE64 and it immediately started working... 😓


Offline tutorial: sorting tracks for selecting by highest bandwidth is incorrect in the code sample

Have you read the FAQ and checked for duplicate open issues?: Yes
What version of Shaka Player are you using?: v2.5.0-beta-master
Can you reproduce the issue with our latest release version?: yes
Can you reproduce the issue with the latest code from master?: yes
Are you using the demo app or your own custom app?: n/a
If custom app, can you reproduce the issue using our demo app?: n/a
What browser and OS are you using?: Chrome/Windows 10
What are the manifest and license server URIs?: https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd

What did you do?
Modified a bit the sample code from the Offline tutorial, to select the lowest bandwidth track.
You can see an example here: https://jsbin.com/tejutojuvu/2/edit?html,js,console,output
(download the asset to see the issue).
I logged to the console the correct sorting (bandwidths sorted from
189957 to 1544182), as opposed to the current wrong one (bandwidths run from
863227 to 1544182).
What did you expect to happen?

Expected to be able to select the highest or lowest bandwidth track.
Expected to see in the log the selected track bandwidth

What actually happened?
Got tracks sorted by lexicographic rather than numeric order
Saw in the log [object object] instead of selected track's bandwidth.

Fix cherry-picked to v2.4.5.


Handle HTTP errors and raise Graphlient::Errors::HTTP on failure.

 There're twenty ways of making a request but all HTTP failure code don't automatically translate into an exception.

Im down to switch to faraday or typhoeus but we can totally do that later if this becomes more problematic.
thanks! 🙌


Change bitrate to 2mbps

Change bitrate to 2mbps
Summary:
Test Plan:

Ugh. Apologies. I didn't mean to send a PR :)


Add explicit any type to rpc type def

This is necessary if you want to configure "noImplicitAny": true, in your tsconfig.

Why this PR is not merged yet? This is very annoying issue for me

Sorry for the late action, merged, patched and published.


fixed small typo

What:
fixed a small typo

Why:
I have OCD

How:
By the power vested in me via my keyboard

Checklist:

[x] Documentation
[ ] Tests N/A
[x] Ready to be merged
[ ] Added myself to contributors table N/A

Awesome! I'm glad! Have you seen this? https://github.com/timdeschryver/ngx-testing-library#readme

Haven't heard about it, looks nice!
There is also Spectator which uses your lib.
Both look similar.
I'm aiming to solve the same problem from a different angle.
Also have a different approach on how to test more "smarter" components without paying the cost of rendering and setup but without the need to shallow render (to be able to break my tests on a child component mismatch), and without going full integration.
I'm considering using this lib with the within function to decorate my object with its functionality.
Currently experimenting with it, will update.

Interesting! The within function is definitely the intended composition mechanism for libraries that build on top of dom-testing-library. I'd love to have a *-testing-library for every framework considering they're generally fairly small and easy to write and because the philosophy is to not care about implementation details almost all frameworks can be tested in almost exactly the same way which I think is a very good thing :)
Good luck!

Thanks brother!
Yeah, as I said, I like the simplicity.
Keep up the good work!

:tada: This PR is included in version 3.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


enhance sync when s3 file writer early quits

Proposed changes
Issue Number: close #xxx
Before this pr, if the s3 file writer's task is failed then it would immediately return when call close(). Unfortunately if there are some task queuing in threadpool and if the threadpool schedules this task after the file writer is destroyed it would result chaos.
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.5 seconds
stream load tsv:          433 seconds loaded<PHONE_NUMBER>9 Bytes, about 164 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          60 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230508101941_clickbench_pr_140199.html


Not able to start AudioVideoPlaybackBot

I registered the calling bot, provided correct permissions, created a classic cloud service,  applied a cert, configured the CNAME entry (and validated that it resolved to xxx.cloudapp.net), ran the configure_cloud script with the app ID, secret, etc. and published to the cloud service.  However, when trying to start the app I get the following error:
Recycling (Recovering role... Application startup task 0 is running. [2021-11-10T13:14:50Z] Last exit time: [2021/11/10, 13:14:36.172]. Last exit code: 0. Last role exception: (System.UriFormatException)|>Process ID: 4256 Process Name: WaWorkerHost Thread ID: 4 AppDomain Unhandled Exception for role AVPWorkerRole_IN_0 Exception: Invalid URI: The hostname could not be parsed. at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind) at Sample.AudioVideoPlaybackBot.WorkerRole.AzureConfiguration.Initialize() in C:\Bot\microsoft-graph-comms-samples-master\Samples\V1.0Samples\LocalMediaSamples\AudioVideoPlaybackBot\WorkerRole\AzureConfiguration.cs:line 295 at Sample.AudioVideoPlaybackBot.WorkerRole.WorkerRole.OnStart() in C:\Bot\microsoft-graph-comms-samples-master\Samples\V1.0Samples\LocalMediaSamples\AudioVideoPlaybackBot\WorkerRole\WorkerRole.cs:line 95 at Microsoft.WindowsAzure.ServiceRuntime.RoleEnvironment.InitializeRoleInternal(RoleType roleTypeEnum) at Microsoft.WindowsAzure.ServiceRuntime.Implementation.Loader.RoleRuntimeBridge.b__0() at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() , Details: Exception: Invalid URI: The hostname could not be parsed. at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind) at Sample.AudioVideoPlaybackBot.WorkerRole.AzureConfiguration.Initialize() in C:\Bot\microsoft-graph-comms-samples-master\Samples\V1.0Samples\LocalMediaSamples\AudioVideoPlaybackBot\WorkerRole\AzureConfiguration.cs:line 295 at Sample.AudioVideoPlaybackBot.WorkerRole.WorkerRole.OnStart() in C:\Bot\microsoft-graph-comms-samples-master\Samples\V1.0Samples\LocalMediaSamples\AudioVideoPlaybackBot\WorkerRole\WorkerRole.cs:line 95 at Microsoft.WindowsAzure.ServiceRuntime.RoleEnvironment.InitializeRoleInternal(RoleType roleTypeEnum) at Microsoft.WindowsAzure.ServiceRuntime.Implementation.Loader.RoleRuntimeBridge.b__0() at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() '.)

It seems like the ServiceDnsName is not a correct URI

In ServiceConfiguration.Cloud.cscfg I have ServiceDNSName configured with my domain (example.com) and it is resolvable. For ServiceCNAME I have botname.example.com which is also resolvable and resolves back to my cloud service public IP.  I have a cert generated and the thumbprint is correct that lists example.com, *.example.com and botname.example.com as SAN's.    Any thoughts on what I can try next? Thanks!

Can you please verify that your code in execution receives your settings from environment variabels, correct cname etc


There are only 20 messages I can read.

Why does IGDM cannot load more than 20 messages in a conversation?

closing this as duplicate of this https://github.com/ifedapoolarewaju/igdm/issues/89


PS Term Mapping and KeepPageCreationModification not working

Category
[X] Bug
[ ] Enhancement
Problem Area
[ ] Page Transformation: Error during the setup/use of the Page Transformation UI solution (did you check our troubleshooting guide?)
[X] Page Transformation: Error during the use of page transformation from PnP PowerShell
[ ] Page Transformation: Error during the use of page transformation from .Net
[ ] Page Transformation: Page is not looking correct after transformation
[ ] Modernization Scanner: something went wrong...
When running command
ConvertTo-PnPClientSidePage -Identity "Quality-Cherry-Cake.aspx" -PublishingPage `
    -TargetConnection $spOnlineConn -Connection $sp13Conn `
    -Overwrite `
    -PageLayoutMapping C:\temp\Demo\custompagelayoutmapping-f3629db3-3e4d-48c4-b904-6fffab6dbb65-quality-cherry-cake.xml `
    -UserMappingFile C:\temp\Demo\usermapping.csv `
    -UrlMappingFile C:\temp\Demo\urlmapping.csv `
    -TermMappingFile C:\temp\Demo\termmapping.csv `
    -PostAsNews `
    -DisablePageComments `
    -KeepPageCreationModificationInformation `
    -LogType File `
    -LogVerbose -LogFolder C:\temp\Demo\

you get in the console/file:
15/03/2020 20:41:39  |  Article page handling  |  There was a non critical issue during page update/publish. Returned error message: Object reference not set to an instance of an object.

@pkbullock : testing this from spo to spo does not result in an error (see #454), now checking on-prem to spo. Would be good if you could attach a debugger at your side to see where things go wrong and/or share the verbose log of the failed transform

@pkbullock : no repro so far when testing from sp2013 to SPO

Argh, sorry wasting time, I double checked this, the source page didn't have the field in the first place for the metadata. Closing.


Merge fix for stryker dashboard reporter

This PR only tests the part of the workflow that would be run for pull requests only.

Codecov Report

Merging #3 (3d20485) into main (a7d5493) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   80.50%   80.50%
=======================================
  Files           8        8
  Lines         159      159
  Branches       27       27
=======================================
  Hits          128      128
  Misses         30       30
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d5493...3d20485. Read the comment docs.


feat: update outputs

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


DioError [DioErrorType.other]: TlsException: Failure trusting builtin roots (OS Error: CERT_ALREADY_IN_HASH_TABLE(x509_lu.c:356), errno = 0)

New Issue Checklist

[x]  I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
flutter

Platform Version
2.0.5

Dio Version
4.0.0

Android Studio / Xcode Version
Android Studio 4.0 / Xcode 12.4

Repro rate
all the time (100%)

Issue Description and Steps
In my app I am using API, which requires .pem certificates to work properly. They are set when my http client is initialized (method definition on a screenshot below).

Dio works fine with this client, but, when I am trying to provide CancelToken to my API Query, I am always getting an error DioError [DioErrorType.other]: TlsException: Failure trusting builtin roots (OS Error: CERT_ALREADY_IN_HASH_TABLE(x509_lu.c:356), errno = 0)

This error doesn't appear, when I am sending POST or GET queries to any other URLs, which don't require certificates to work.
What can I do about that? Is there a way to fix this error myself?

@Nickkorol Did you fixed it?


feat: add fallback TableProvider to FederatedTableProviderAdaptor

Adds a fallback TableProvider that can be used in DataFusion contexts without the federation optimizer in-use, which provides a graceful fallback mechanism.

LGTM. One thing I'd like to explore is if we can disable the fallback if the optimiser is registered. Just to avoid confusion where one (wrongly) assumes the federation is done but in reality the fallback is being used. But this can be picked up in a follow-up.

This should be possible, since we are passed the SessionState into scan and insert_into - and SessionState has the optimizer rules. Unfortunately there isn't an accessor method to get the currently loaded optimizer rules (there is for physical_optimizers, but not the logical ones). I'm guessing a PR into DataFusion would be accepted to add those methods, and then we could check here if the federation rule is present - and return the error regardless of a fallback table provider.


Confusing behaviour after amending labels.

This is because GitHub Actions create a separate new instance of the check for some different
event types, e.g. the labeled event creates a new check instance
separate from the push event checks[1].  So if, for instance, a consumer:

pushed a commit when there is no required label
added the required label
then the lableled instance of the check would pass, but the push would
still show the initial failure.

The current workaround is to rerun the GitHub action job after applying the label, but that’s both manual and unituitive.  A proper fix would be to have a new GitHub action which uses the GitHub Actions API to rerun the job,  triggered by the labeled and unlabeled events.
NB We can also then get our label checker GitHub Action to just trigger on the standard pull request events, i.e. remove the labeled and unlabeled event triggers for it.
[1] https://github.community/t5/GitHub-Actions/Action-ran-on-pull-request-edited-labeled-unlabeled-doesn-t/m-p/44019/highlight/true#M5606

This post indicates GitHub have now fixed this issue.

[ ] Test again to see if this issue has indeed been fixed by GitHub

Tested and it appears that GitHub have indeed fixed this issue 😄
Closing.


[Documentation request] Fastlane scan without parameters default behaviour

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues
[x] I googled like hell.

Issue Description
I would like to know how exactly scan behaves when no parameters are given and no Scanfile initialised.
especially when I run just fastlane scan I do not know what to expect with simulators/devices on which the scan should be ran.
Could you please  provide some more to the scan documentation how this behaves without Scanfile initialised?
From logs I see it finds first simulator and runs the tests on it. But:

How can I be sure it won't find as first real device which is connected and doesn't start the tests on it?I do not believe in the identifiers and running this line: fastlane scan --device "iPhone 7 is bit unsafe for me...
What if for some unknown reason the simulator is not in there? Or if somehow the simulator chosen got stuck, will it ignore it and start another one? If I use --devices
Will the scan continue even if one of five simulators is stuck?

When I read the log, my assumption is it will by default take the first simulator it hits and start tests on it, am I correct?
There is more to it
This might be not so related... or this should be separate ticket, but I will post it in here..
When you call fastlane scan --device [devices]  You get warning that using devices should be avoided and that user should check out scan --help for other options... Which option should be best?
By example:
I want to run tests everytime on simulator, I don't mind running it on iPhone or iPad, because these are just unit tests. should I run scan --device "iPhone 7" or just scan or put --devices to use? Or something completely different?
The first one is obviously wrong from reasons I described above, the second is what I am asking for and apparantly devices shouldn't be used directly...
Thanks for any clarification!
Environment

🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.13.4

Ruby
2.4.1

Bundler?
false

Git
git version 2.14.1

Installation Source
~/.rvm/gems/ruby-2.4.1/bin/fastlane

Host
Mac OS X 10.13.4 (17E199)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.4.1/lib

OpenSSL Version
OpenSSL 1.1.0h  27 Mar 2018

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
9.3

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
```
Fastfile, which is irrelevant right now.
```

`./fastlane/Appfile`
app_identifier ENV["APP_IDENTIFIER"]
apple_id "🙈🙈🙈" # Your Apple email address

team_id "🙈🙈🙈"  # Developer Portal Team ID

# you can even provide different app identifiers, Apple IDs and team names per lane:
# More information: https://github.com/fastlane/fastlane/blob/master/docs/Appfile.md

fastlane gems

Gem
Version
Update-Status

fastlane
2.92.0
🚫 Update available

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
2.3.2

atomos
0.1.2

CFPropertyList
3.0.0

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.5

xcodeproj
1.5.7

rouge
2.0.7

xcpretty
0.2.8

terminal-notifier
1.8.0

unicode-display_width
1.3.0

terminal-table
1.8.0

plist
3.4.0

addressable
2.5.2

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

tty-screen
0.6.4

tty-cursor
0.5.0

tty-spinner
0.8.0

babosa
1.0.2

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.62.0

faraday
0.14.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.1

gh_inspector
1.1.3

mini_magick
4.5.1

multi_json
1.13.1

multi_xml
0.6.0

rubyzip
1.2.1

security
0.1.3

xcpretty-travis-formatter
1.0.0

dotenv
2.2.2

bundler
1.16.1

faraday_middleware
0.12.2

naturally
2.1.0

simctl
1.6.4

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.1

mime-types-data
3.2016.0521

mime-types
3.1

little-plugger
1.1.4

logging
2.2.2

jwt
2.1.0

memoist
0.16.0

os
0.9.6

signet
0.8.1

googleauth
0.6.2

httpclient
2.8.3

google-api-client
0.13.6

emoji_regex
0.1.1

openssl
2.1.0

io-console
0.4.6

mini_portile2
2.3.0

nokogiri
1.8.2

json
2.1.0

generated on: 2018-04-20

Thanks for clarification! :)


$location.search() does not work when there is no hash in the url

Hey there,
I am suffering with # in url. I used HTML5 mode true statement but whole site is not working properly. After removing that statement this site is running well.
By Using of HTML5 mode true statement, when i click on any menu the url is showing something like this.
http://orangemantra.co.in/dummy#%2Fportfolio
and showing an error in angularjs, that is:
"Error: $rootScope is not defined".
how we can overcome this issues.


[BUG/Help] <在mac上运行chatglm-6b-int4 报错：copying a param with shape torch.Size([12288, 2048]) from checkpoint, the shape in current model is torch.Size([12288, 4096])>

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
ize mismatch for transformer.layers.0.attention.query_key_value.weight: copying a param with shape torch.Size([12288, 2048]) from checkpoint, the shape in current model is torch.Size([12288, 4096]).
size mismatch for transformer.layers.0.attention.dense.weight: copying a param with shape torch.Size([4096, 2048]) from checkpoint, the shape in current model is torch.Size([4096, 4096]).
size mismatch for transformer.layers.0.mlp.dense_h_to_4h.weight: copying a param with shape torch.Size([16384, 2048]) from checkpoint, the shape in current model is torch.Size([16384, 4096]).
size mismatch for transformer.layers.0.mlp.dense_4h_to_h.weight: copying a param with shape torch.Size([4096, 8192]) from checkpoint, the shape in current model is torch.Size([4096, 16384]).
size mismatch for transformer.layers.1.attention.query_key_value.weight: copying a param with shape torch.Size([12288, 2048]) from checkpoint, the shape in current model is torch.Size([12288, 4096]).
size mismatch for transformer.layers.1.attention.dense.weight: copying a param with shape torch.Size([4096, 2048]) from checkpoint, the shape in current model is torch.Size([4096, 4096]).
size mismatch for transformer.layers.1.mlp.dense_h_to_4h.weight: copying a param with shape torch.Size([16384, 2048]) from checkpoint, the shape in current model is torch.Size([16384, 4096]).
size mismatch for transformer.layers.1.mlp.dense_4h_to_h.weight: copying a param with shape torch.Size([4096, 8192]) from checkpoint, the shape in current model is torch.Size([4096, 16384]).
Expected Behavior
No response
Steps To Reproduce

clone 了 chatglm-6b-int4 项目
修改代码   modeling_chatglm.py
 #    from .quantization import quantize, QuantizedEmbedding, QuantizedLinear, load_cpu_kernel
#   self.transformer = quantize(self.transformer, bits, use_quantization_cache=use_quantization_cache, empty_init=empty_init, **kwargs)
修改代码 cli_demo.py
`tokenizer = AutoTokenizer.from_pretrained("../chatglm-6b-int4", trust_remote_code=True)
model = AutoModel.from_pretrained("../chatglm-6b-int4", trust_remote_code=True).float()

#tokenizer = AutoTokenizer.from_pretrained("THUDM/chatglm-6b", trust_remote_code=True)
#model = AutoModel.from_pretrained("THUDM/chatglm-6b", trust_remote_code=True).half().cuda()`
Environment
- OS:
- Python:
- Transformers:
- PyTorch:
- CUDA Support (`python -c "import torch; print(torch.cuda.is_available())"`) :

Anything else?
No response

我也遇到同样的问题
Windows11
Python3.9
torch2.0.0 or torch1.13.1 都有问题
Transformers    (compiled from latest git source)
CPU：AMD R7-6800H

chatglm-6b-int4是量化后的权重，必须使用量化后的模型结构加载
#    from .quantization import quantize, QuantizedEmbedding, QuantizedLinear, load_cpu_kernel
#   self.transformer = quantize(self.transformer, bits, use_quantization_cache=use_quantization_cache, empty_init=empty_init, **kwargs)
```
注释掉这段代码之后，模型结构依然是量化之前的，因此会发生加载错误。可以尝试加载chatglm-6b的权重


Validation of invalid schema

Adds full validation support while reading in Table Schema, along with unit tests. This is done in code as discussed in #6.

@loleg
I'm not able to review at the moment but in high-level it looks good. Python also validates PK/FK in the lib code - you could check the rules.

@roll thanks, I'm merging as it was a rather straightforward port of the Python unit tests, and making myself a note to compare the validation code again.

@loleg
Great!


CFRunLoopSource does not convert

Im running off of main branch, and when I try and build an xcode ipa, im getting this feedback:
Swift Compiler Error (Xcode): Cannot convert value of type 'Unmanaged' to expected argument type 'CFRunLoopSource?'
/Users/runner/.pub-cache/git/flutter_system_proxy-a2ebbf5f93b2f2b35aa72fbc591d97cc4244a832/ios/Classes/SwiftFlutterSystemProxyPlugin.swift:107:44

using 0.1.1 worked.

same here


Programmatically set environment variables

When deploying things and running tests, it'd be nice if we could specify environment variables to be used on all remote machines. For example, we might wish to set JAVA_HOME to some specific path (e.g. if we want to run integration tests against Java 7). We might want to set YARN_HOME to some deployment directory, as well. Zopkio doesn't seem to provide a mechanism for me to do this.

This feature is added. It can be passed to the ssh deployer by setting the env config.
For the zookeeper example , we can set the environment variable JAVA_HOME as follows.
env_dict = {'JAVA_HOME':'/export/apps/jdk/current'}

zookeper_deployer = adhoc_deployer.SSHDeployer("zookeeper",
{'pid_keyword': "zookeeper",
'executable': runtime.get_active_config('zookeeper_exec_location'),
'env':env_dict,
'extract': True,
'post_install_cmds':runtime.get_active_config('zookeeper_post_install_cmds'),
'stop_command':runtime.get_active_config('zookeeper_stop_command'),
'start_command': runtime.get_active_config('zookeeper_start_command')})
runtime.set_deployer("zookeeper", zookeper_deployer)


Fixes #88 Support code cells

Fixes #88 Support code cells
Adds support for marking code cells with "#%%", including collapsing them and sending the entire cell to the REPL when pressing Ctrl+Enter on the cell header.
Also fixes some threading issues.
See #88 for a screenshot of how it looks.

👍


ImageRepository not populating Last Scan in additionalPrinterColumns

The additionalPrinterColumn for LAST SCAN is not populating.  I believe it was #56 that introduced this.  I have confirmed that updating the CRD as follows populates the field:
https://github.com/fluxcd/image-reflector-controller/blob/main/config/crd/bases/image.toolkit.fluxcd.io_imagerepositories.yaml#L20
should instead read
.status.lastScanResult.scanTime

Thank you for reporting!


Create a new release

I'd like to include it in the Solus repos: https://dev.solus-project.com/T2459

Absolutely, this is long due. I'm moving to a new place these days so kinda busy but I'll do it soon.

I've just release v3.1.0. You can download it from here.


Accept expected response Content-Type "text/html"

Computers are hard... :man_shrugging:

Fixes: #7

Ok, now I think I've got it right :smile:
It seems that newer aiohttp refuse to parse JSON if the MIME type isn't JSON. From what I understand, the API always returns (and did already in the past) text/html for weather forecasts, despite asking for application/json. IMHO that's wrong/weired, but it is what it is. For other requests or error cases, the API seems to return application/json. Make sure to check Content-Type depending on API used.

It seems that newer aiohttp refuse to parse JSON if the MIME type isn't JSON.

I'm pretty sure this has been aiohttp's default behavior for quite some time. At least I remember struggling with this in the past :)

Awesome, thanks a lot!


(doc) Add client on-boarding guide for the Chocolatey for Business QDE Azure Environment

Chocolatey for Business QDE Azure Environment is slightly different than regular QDE in terms of client on-boarding.
This is mainly because of the change to the URL for Nexus, but also the fact that it is always internet enabled.
This PR includes the new doc page and supporting images.

@pauby Can we get your review on this please. Otherwise looks like team has approved the changes put forward in this PR.


feat: use fastify v5

Hey there,
All tests are passing locally.
Please let me know if you need more from me.
Best.

Hey, any news about this one ?


Proper sentence-transformers ONNX export support

As reported in https://github.com/huggingface/optimum/issues/1519, simple mapping sentence-transformers to transformers library allows to use only a subset of sentence-transformers library.
This PR adds the support of the export of sentence_embedding for sentence-transformers models.
Examples:
optimum-cli export onnx -m sentence-transformers/clip-ViT-B-32-multilingual-v1 clip_vit_multilingual_onnx
optimum-cli export onnx -m sentence-transformers/all-MiniLM-L6-v2 minilm_onnx

Can those extra outputs be supported directly in transformers? Just find the changes a bit hacky, and this is causing errors in optimum neuron subpackage: https://github.com/aws-neuron/aws-neuron-sdk/issues/808

standardizing model attributes made it a bit misleading for debug, eg. it was surprising to get sentence-transformers-transformer as model_type from a config where the model_type is marked as bert:

I kind of doubt this is feasible, as sentence-transformers adds quite a few features on top of transformers. For example, the sentence embeddings.


Implement Browserify module bundler and Components Library

Use Browserify to load and bundle modules by default. Still provide the option to switch to RequireJS through configuration for large projects.
Also Implement a component library in the static docs to document individual components
Improve Frontend Bootstrap

Change template engine from Swig to Nunjucks.
Change css minifier from minify-css to clean-css.
Include components library in documentation
Move the js task helper functions to a util file
Add migration guide

Changing the contents of a .yml file isn't watched at this moment.

No gulp errors using Node v6.7.0 & v6.9.1
Do we want sub directories with multiple components rendered as seperate list items in the documentation index, or as a list nested within it's parent item? Per example, now we render:

folder

component1
component2

sub-folder-of-folder

component3
component4

Instead of:

folder

component1
component2
sub-folder-of-folder
-component3
-component4

@peeke I think the second option is a better representation of what is actually happening. Folders are nested, so connected in some way. This should be visible in the tree view. However, I'm wondering in which case you would nest folders with components?

Result after testing fixes:

Changing the contents of a .yml file isn't watched at this moment. FIXED
The .yml file contains a preview instead of a demo option. Tested it with demo and this works. FIXED
Documentation for the .yml file structure is missing. For instance how to make component variants.
Components overview (index.html) is rendered incorrect when a component folder contains multiple .yml files.
Component names in overview (index.html) are now just the file names minus the extension. Please use the component title from the .yml file. FIXED
component-detail.html contains word Overzicht while everything is written in English. Fixed
Add list of component variants to component-detail.html page. OUT OF SCOPE
Template overview (index.html) contains a list of file names of the templates. Please prettify this by replacing - & _ with spaces and capitalize the first word. PARTIALLY FIXED
Make overview title <h1> (index.html) and template layout <title> (layout/default.html) 'Front-End Library' configurable via config.js instead of static text. OUT OF SCOPE
When bundling with browserify the main.js sourcemap is placed in the wrong folder: dist\static\js\dist\static\js FIXED

New issues:

/ vs \ issue with template overview name prettify. On Windows the slash formatting doesn't work.
After updating docs files no browsersync refresh is triggered

@awolkers the following issues are fixed:

Documentation for the .yml file structure is missing. For instance how to make component variants.
Components overview (index.html) is rendered incorrect when a component folder contains multiple .yml files.
/ vs \ issue with template overview name prettify. On Windows the slash formatting doesn't work.

In my opinion refreshing the page after a docs page is updated is not necessary, because the docs pages are for documentation purposes.

Tested and everything look ok except one thing. The component overview doesn't match the purposed layout by @peeke

folder

component1
component2
sub-folder-of-folder

component3
component4

@awolkers unfortunately this tree view requires a significant rework of the code, so I think this should be done in a new pull request after this one got accepted.

ok fine for now. Might want to create a new issue on this repo so it won't be forgotten.

Question; why are there multiple times an absolute path to my computer in the dist/static/js/main.js output?
/dist/static/js/main.js:
},{"_process":"/Users/wkroes/Projects/frontend-bootstrap-sanjaytwisk/node_modules/process/browser.js","buffer":"/Users/wkroes/Projects/frontend-bootstrap-sanjaytwisk/node_modules/buffer/index.js"}]},{},["/Users/wkroes/Projects/frontend-bootstrap-sanjaytwisk/src/static/js/bundle.js"])

@wouterkroes this was part of the browserify config and is now fixed

1
The css-lint & js-lint task both say, in jsdoc comment, xxx-test instead of xxx-lint.
Should be 'lint' in my opinion.
2
typo's:

// Create a task(space)list wit(h) an entry for each bundle


[Feature Request] Custom icons state for md-switch

The current implementation of md-switch use only the close and check icon as seen in the source code.
On Icon

https://github.com/material-components/material-web/blob/0ab5fd595d8c163065860a2e0deec8b77c8c9d77/switch/lib/switch.ts#L173-L179
Off Icon

https://github.com/material-components/material-web/blob/0ab5fd595d8c163065860a2e0deec8b77c8c9d77/switch/lib/switch.ts#L184-L190
It would be great if this component <md-switch /> implements this custom icon feature!

I think I remember when design added icons into switch, I was like yo someone's gonna wanna change them sometime 😂

That's me then 😂

@asyncLiz Any news for this?

This is likely low on our priority right now, but I think this could be a good community contribution if you want to take a stab at it!
<md-switch>
  <md-icon slot="on-icon">...</md-icon>
  <md-icon slot="off-icon">...</md-icon>
</md-switch>

Inside the component we can use a slot with the current icons as fallbacks.
<slot name="on-icon">
  <svg>...</svg>
</slot>


PR: Default file directory set to working directory

Description of Changes

[x] Included a screenshot or animation (if affecting the UI, see Licecap)

Earlier on creating a new file, its default directory was set as the directory of previous file, which doesn't seems so logical.
Now, if its not a project, a new file's default directory is set as the current working directory.
Before

After

Issue(s) Resolved

Fixes #9162
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Thanks for reopening :-)
Things seem to be in order now with the commits. Will review today.
Cheers

@spyder-ide/core-developers should this be an option? Is this something that makes sense as the new default?

I think this makes a lot of sense but I'm not sure to include it in our next release because it'll change a UX feature that has been working like this for years.
@bcolsen, @jnsebgosselin, @jitseniesen, what do you think?

My feeling is to postpone to Spyder 5. For me, the PR is probably an improvement, but I am not convinced that it is; there is also something to be said for the current situation, which assumes (if I understand it correctly) that you want new files to appear in the same directory as the file that you are currently looking at.
It seems a pretty small detail to make an option for. If we still want to keep the number of options in check, then I'd recommend for now not to have a configuration option.

It seems a pretty small detail to make an option for. If we still want to keep the number of options in check, then I'd recommend for now not to have a configuration option.

If we don't to completely break expectations with respect to the previous behavior, we'd definitely need to add an option for this.


Can you add updates to an Office ISO?

Can you add updates to an Office ISO?
It is my question with great respect

Hi~   you could Create a Updates Directory in ISO Root. then copy the updates in  this Directory.
Best


Error on first exercise Unable to spawn 001_hello: FileNotFound

From a fresh checkout of this repo, after correcting the error in the first exercise and running zig build, I am given the following error output:
Compiling 001_hello.zig...
Checking 001_hello.zig...
Unable to spawn 001_hello: FileNotFound

HINT: DON'T PANIC!
Read the error above.
See how it has something to do with 'main'?
Open up the source file as noted and read the comments.
You can do this!
Edit exercises/001_hello.zig and run this again.
To continue from this zigling, use this command:
    zig build -Dn=1
error: the following build command failed with exit code 1:
/Users/mikowitz/Code/ziglings/zig-cache/o/ff08cd9d949daaad044fdbd333fd6718/build /Users/mikowitz/.asdf/installs/zig/master/zig /Users/mikowitz/Code/ziglings /Users/mikowitz/Code/ziglings/zig-cache /Users/mikowitz/.cache/zig

The executable 001_hello does exist in the root of the ziglings checkout, and I can run it via ./001_hello and get the correct output, but I have not been able to figure out why the build command is failing.
I'm running:
zig version: zig 0.11.0-dev.2560+602029bb2, installed via ASDF
OS: macOS 12.6 on an M2 chip

We are working on the new build system because of the changes in Zig. I checked in a new version a few minutes ago. Can you please try it again, because I can't find the error.

@perillo fyi

Having pulled the latest and running zig build I'm now getting a different error:
error: unrecognized parameter: '--enable-cache'
001_hello.zig: The following command exited with error code 1:
/Users/mikowitz/.asdf/installs/zig/master/zig build-exe /Users/mikowitz/Code/ziglings/exercises/001_hello.zig --cache-dir /Users/mikowitz/Code/ziglings/zig-cache --enable-cache

Commenting out the line that adds that parameter, I'm still seeing the same behaviour as originally reported. I'll be able to test this on a different laptop a bit later this afternoon just in case there is something wonky about the one I'm on currently.

@mikowitz Could you try zig build -Dn=1 this should produce the right error.

Having pulled the latest and running zig build I'm now getting a different error:
error: unrecognized parameter: '--enable-cache'
001_hello.zig: The following command exited with error code 1:
/Users/mikowitz/.asdf/installs/zig/master/zig build-exe /Users/mikowitz/Code/ziglings/exercises/001_hello.zig --cache-dir /Users/mikowitz/Code/ziglings/zig-cache --enable-cache

--enable-cached was removed in ziglang/zig@c96cb98ad.
I missed it.  I need to investigate how to update the code in build.zig

When --enabled-cached is set, the compiler prints to stdout the path to the generated executable.
Now it is no longer possible, so the code should be update.

zig build -Dn=1 repeats the same thing except without the ziglings logo. I fixed 001_hello.zig and did run .\exercises\001_hello.zig and it works fine, printing hello world.

I just started learning Zig, so this may be wrong, but removing the --enabled-cache argument and adding the cwd to the executable path works for me:
diff --git a/build.zig b/build.zig
index 4ccf9c2..b6a0594 100644
--- a/build.zig
+++ b/build.zig
@@ -728,7 +728,7 @@ const ZiglingStep = struct {

         const cwd = self.builder.build_root.path.?;

-        const argv = [_][]const u8{exe_file};
+        const argv = [_][]const u8{std.fs.path.join(self.builder.allocator, &[_][]const u8{ cwd, exe_file }) catch unreachable};

         var child = std.ChildProcess.init(&argv, self.builder.allocator);

@@ -823,8 +823,6 @@ const ZiglingStep = struct {
         zig_args.append("--cache-dir") catch unreachable;
         zig_args.append(builder.pathFromRoot(builder.cache_root.path.?)) catch unreachable;

-        zig_args.append("--enable-cache") catch unreachable;
-
         const argv = zig_args.items;
         var code: u8 = undefined;
         const output_dir_nl = builder.execAllowFail(argv, &code, .Inherit) catch |err| {

After MrMarble's fix (above), I added these .gitignore patterns to avoid committing the binaries:
[0-9][0-9][0-9]_*
![0-9][0-9][0-9]_*.zig

The solution is to use Zig IPC (https://github.com/ziglang/zig/blob/master/lib/std/zig/Client.zig) to send a command to the compiler to get the path to the executable.
See https://github.com/ziglang/zig/blob/master/lib/std/Build/Step.zig#L278.
I'm working on this issue.


Bundling causes it to try bring in fs, jsdom

When used as a dependency and then bundled w/ Webpack (and probably Rollup), the bundler tries to rope in fs and jsdom.  Since the bundle is for a browser, these dependencies are invalid.
The mocks in the browser directory only seem to help with creating a browser distro, but not when used as a dependency via npm and then bundled for a browser distro.
As such, I might need to rethink how to use those dependencies.
As a workaround for Webpack, use the IgnorePlugin:
plugins: [
  new webpack.IgnorePlugin(
    /(fs|jsdom)/,
    /thymeleaf/
  )
]

I'm sure it's roughly the same workaround with Rollup and rollup-plugin-ignore.

Some useful resources:

https://nolanlawson.com/2017/01/09/how-to-write-a-javascript-package-for-both-node-and-the-browser/
https://github.com/defunctzombie/package-browser-field-spec


Directory public to public_html

Because I am working with share hosting. Of course you know it used a public_html instead of public. So How do I change this default to public_html.
I've trying to change in the config/lfm file to public_html. But still. Not working. No comin' errors, The image is still not uploaded.
Anyone ever got it or something ?

Are the files and images direcories inside public_html writable?
If they are and it's still not working, make sure sure your shared hosting provider is at least running php 5.4.
If that doesn't work, can you check what status code the xhr request after you try to upload a file is and post that error here.

I had said. no errors. But this has been solved. I check all of the php module.

Thanks @gwleuverink. Closing issue.

Hi! Thank you for this great package!
I am continuing this thread because the issue is on a shared hosting, so I wouldn't open a new one.
My issue is when using the package on a shared hosting; i've set up the file structure, and when I directly place images on the folder I selected, the image is shown on the file manager window.
The problem is when uploading (I get a xhr ok), but the image isn't uploaded. Also when, trying other things like rename a file I hand placed, I get this error:
rename(/home/rally/public_html/project/storage/photos/thumbs/3.jpg,/home/rally/public_html/project/storage/photos/thumbs/23.jpg): No such file or directory
I've also set the storage and subfolder permissions to 777 (just for testing), but it still doesn't work...
Can you help?

@anaisabel19886 Please upgrade to v1.8.2-alpha. And please you folder structure here.


Update scheduling framework page with latest changes

This is a Feature Request

What would you like to be added

In v1.26, we introduced a new extension point in scheduling framework named PreEnqueue, see https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3521-pod-scheduling-readiness, but this page hasn't been updated https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/scheduling-eviction/scheduling-framework.md, we should populate this.
Why is this needed
Keep the document up-to-date.
Comments

/sig scheduling
/kind help

/help

/kind documentation

/assign

/triage accepted

@kerthcet could you make elaborate on what I need to change since I am unable to understand the feature request?

I mean we should add another extension point named PreEnqueue, which is new introduced in last release v1.26.

@YashPimple are you still working on this issue ??

Thanks @haripriya9647 for your attention, but I think we have updated the document. See https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/scheduling-eviction/scheduling-framework.md#preenqueue-pre-enqueue
So I'd like to close it.
/close


Programatic Install

What does an install look like from say command line? Are there other methods to deploy this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a304f1aa-ac44-7831-2f2c-f827238fc50e
Version Independent ID: 6610a9cc-2a03-5305-3378-392c4a1227ac
Content: Azure Functions Runtime Installation
Content Source: articles/azure-functions/functions-runtime-install.md
Service: functions
GitHub Login: @apwestgarth
Microsoft Alias: anwestg

@LeoStack Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Hi,
there is no command line installation option supported for the Azure Functions Runtime preview at present. Should we make this possible in a future release we will be sure to include it in our documentation.
Thanks
Andrew

Thanks for the quick reply @apwestgarth!
@LeoStack you can leave this feedback here if you are interested:
https://feedback.azure.com/forums/355860-azure-functions

I have already installed Azure Functions Runtime and created some functions. I wonder why the HTTP trigger is not available when selecting a template.
For V1 functions I can choose between: Timer trigger, Queue trigger, Service Bus Queue trigger, Blob trigger, Event Hub trigger and SQL Queue trigger
For V2 Functions there are just three templates available: Timer trigger, Queue trigger and Blob trigger.
So my question is, do I have to install more templates manually as needed?
Thanks in advance.


added Troublshooting section

Adds a work around to resolve the error "Error was sequence item 0: expected string, dict found"

@jhaals can we merge this please?

Absolutely!
Would you please be so kind and update the markdown format for your links. It should be [text](http://url)

Done. I am a little confused as most of the links in the content you created are formatted as [link comment]...

👍


[Bug]: Vite build not hermetic? Imports escape sandbox

What happened?
A Vite build succeeds, even if not all dependencies are provided in the BUILD.bazel file.
Version
Development (host) and target OS/architectures:
Output of bazel --version: bazel 6.0.0rc2
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: rules_js-1.8.0
Language(s) and/or frameworks involved: Javascript, Vite
How to reproduce
A git repo with instructions how to reproduce this bug is available at:

https://github.com/henkerik/repro_rules_js_362

Any other information?
This repo started as a fork of https://github.com/gregmagolan/repro_rules_js_362 because I suspected I ran into the same bug. However, I think this bug is different. It looks like a regular JS import escapes the Bazel sandbox as well:
https://github.com/henkerik/repro_rules_js_362/blob/main/vite.config.js#L2
Fund our work

[ ] Sponsor our open source work by donating a bug bounty

Possibly a symptom of https://github.com/aspect-build/rules_js/issues/362?

@gregmagolan I though so at first, that's why I forked your repo :). However, I build node from source with your patch (https://github.com/aspect-build/node/commit/6616ddd629f9417e0ac2826910ff9756b01cfe34) but this didn't fix it.

seeing the same issue. Seems like that the the bazel target (i.e. vite) is using the node_modules in the bazel-out repository


/rank with no arguments throws internal error message

Not entirely true, but I fixed another bug because of this issue


Semantic Tabs

I swapped out the dl and dd's for a ul and li's for the tabs to make them more semantic. Per the spec, the dl element must contain one or more dt element, each followed by one or more dd elements.
Using list items (li's) allows the tabs to be used with unordered and ordered lists, as well as in a menu element if necessary.

I could have sworn I did this already :) Thanks!

The <li>'s need a tab-title class I've also added.


Tell RtcToNet the user ID so it can enforce quotas.

Fixes https://github.com/uProxy/uproxy/issues/1568

:+1:


nsls2 sandbox h5py import error

Import error here (from try.nsls2.bnl.gov, file named "Welcome to the NSLS-II Data Acquisition and Analysis Sandbox"). As an aside, is this still generally used? I'd just like to use it to show it as an example to colleagues in my group who will also be performing measurements. (It's easily accessible which makes it convenient)
from databroker import DataBroker as db, get_table

---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-2793aa6e4b98> in <module>()
----> 1 from databroker import DataBroker as db, get_table

/opt/conda/lib/python3.4/site-packages/databroker/__init__.py in <module>()
     12                          restream, process)
     13 from .pims_readers import get_images
---> 14 from .handler_registration import register_builtin_handlers
     15
     16 # register all built-in filestore handlers

/opt/conda/lib/python3.4/site-packages/databroker/handler_registration.py in <module>()
      1 from filestore.api import register_handler
----> 2 from filestore import handlers, HandlerBase
      3 import logging
      4
      5

/opt/conda/lib/python3.4/site-packages/filestore/handlers.py in <module>()
      4
      5 import logging
----> 6 import h5py
      7 import numpy as np
      8 import os.path

ImportError: No module named 'h5py'

Thanks for the report. I'm aware of the issue. We have recently updated the sandbox to include actual simulated EPICS IOCs -- you can caget/caput and practice installing motors and area detectors! -- but we broke some minor things in the process. When were you hoping to share this with colleagues?

It's not pressing. I can also just log on and use the CHX kernel to demonstrate in person if needed for now. But it is a nice website to quickly share as an intro via email when someone asks about it. Thanks!

Actually fixing it wasn't so hard. I believe it is now fixed. Please let me know if it works for you now.

yep, works now, thanks! (closing)


Add an option to use a different tsconfig.json file

It's quite common for projects to use environmentally specific file such as tsconfig.prod.json and tsconfig.dev.json instead of the default tsconfig.json.
Would be great to have a CLI option to specify which file should be considered.
Love this tool BTW.

Thanks, PR welcome!

:tada: This issue has been resolved in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove CustomConversation class and replace with Bukkit Conversation API

The sole purpose of the CustomConversation class seems to be to allow the setting of the modal field. This is unnecessary though, as this is meant to be done using the ConversationFactory.
I assume whoever made this class didn't actually read up on the Conversation API. Unless there is a problem with the Conversation Factory?

Yeah, but then we have to make a new factory for every single conversation, which breaks the pattern as well

Which pattern?
Also the API says you're meant to instantiate a new factory for each distinct conversation so I don't see how that's a problem?

Hmm I'd assume that the factory here is implementing a variation of the factory pattern, where one factory instance is used to create many similarish products. The fact that the official documentation says you're supposed to create a new factory every time makes me think that that's wrong though, maybe it's just naming coincidence or used wrong.
Anyway, if you make a PR to change it, I'll merge it, but as long as it's working and the end result is the same, I dont really care too much tbh.

@tyrothalos I'd support that PR. I had previously directed Max to the API you reference as I use it in EasyHelpOp and it's quite simple.
@Maxopoly The factory pattern is just a formalism for "Using a tool to create objects"; there are several implementations of the factory pattern. In this case its just useful for safely exposing all the Conversation features in a consistent way. It's also pretty easy to read: https://github.com/DevotedMC/EasyHelpOP/blob/master/src/com/bigbrainiac10/easyhelpop/viewmenu/ViewMenu.java#L114

Yeah the name is misleading since it actually uses the builder pattern and not factory.
I can make a PR later and fix it. What is the Dialog class used for anyway?

builder pattern

There we go. Couldn't remember it.

Easy API for reading a single line of text from chat, for example when creating groups via namelayer gui

Example:
https://github.com/Civcraft/NameLayer/blob/master/NameLayerMain/src/vg/civcraft/mc/namelayer/gui/MainGroupGUI.java#L877
You only need to specify the actual logic and dont need to care about any of the dialog stuff behind it. It also adds configurable tab completion as a feature to them.


"Some older messages are unavailable" on self-hosted instance

We've recently migrated our Zulip cloud instance to a self-hosted server.
Some streams show the Some older messages are unavailable warning.

Is this maybe related to the fact that our cloud instance had 10k+ messages already, and showed that warning too, and it has somehow been migrated?
Or is this simply an issue that doesn't take self-hosted instances into account?

@xpac1985 well, I think the problem is that the field for what type of plan you're on in the cloud instance came along for the migration.  You can likely fix this in a manage.py shell with:
realm = get_realm("")
do_change_plan_type(realm, Realm.SELF_HOSTED)

That said, I'm puzzled how you ended up in this state.  The data import tool runs the following code at the end:
    if settings.BILLING_ENABLED:
        do_change_plan_type(realm, Realm.LIMITED)
    else:
        do_change_plan_type(realm, Realm.SELF_HOSTED)

Can you see if settings.BILLING_ENABLED is somehow true on your instance?  scripts/get-django-setting BILLING_ENABLED will work for that.

Oh, actually, I have another theory -- before you do change the plan type, can you print:
print(realm.plan_type, realm.first_visible_message_id, realm.message_visibility_limit)

That may be very helpful in debugging how this happened.

Ha, it looks like you're on the right path:
In [3]: print(realm.plan_type, realm.first_visible_message_id, realm.message_visibility_limit)
1 8381 10000

afaik, 1 means SELF_HOSTED, but the other two seem to suggest that the visibility limit hasn't been raised during the migration.
zulip@zulip:~$ deployments/current/scripts/get-django-setting BILLING_ENABLED
False

If you want to repro the steps - I set this up by the book and added the data export you sent me last Saturday...
I haven't made any changes yet in case you need some more info - will wait for your confirmation to make the change, it's not super urgent.

@xpac1985 I think you can go ahead with the change; it sounds like this should be reproducible with just doing an import into a BILLING_ENABLED=False server (or re-doing the import into a new, empty server).  @hackerkid can you try figuring out why this isn't working properly?

I think I found a fix for this - change file zerver/lib/actions.py as follows in lines 3474pp:
    if plan_type == Realm.SELF_HOSTED:
        realm.max_invites = Realm.INVITES_STANDARD_REALM_DAILY_MAX
        realm.message_visibility_limit = None
        realm.upload_quota_gb = Realm.UPLOAD_QUOTA_STANDARD
    elif plan_type == Realm.STANDARD:
        realm.max_invites = Realm.INVITES_STANDARD_REALM_DAILY_MAX
        realm.message_visibility_limit = None
        realm.upload_quota_gb = Realm.UPLOAD_QUOTA_STANDARD
    elif plan_type == Realm.STANDARD_FREE:
        realm.max_invites = Realm.INVITES_STANDARD_REALM_DAILY_MAX
        realm.message_visibility_limit = None
        realm.upload_quota_gb = Realm.UPLOAD_QUOTA_STANDARD
    elif plan_type == Realm.LIMITED:
        realm.max_invites = settings.INVITES_DEFAULT_REALM_DAILY_MAX
        realm.message_visibility_limit = Realm.MESSAGE_VISIBILITY_LIMITED
        realm.upload_quota_gb = Realm.UPLOAD_QUOTA_LIMITED

The first block was missing, maybe you didn't assume that you would ever change to self hosted?
However, the result looks like this:
In [2]: print(realm.plan_type, realm.first_visible_message_id, realm.message_visibility_limit)
1 8486 10000

In [3]: do_change_plan_type(realm, Realm.SELF_HOSTED)

In [4]: print(realm.plan_type, realm.first_visible_message_id, realm.message_visibility_limit)
1 0 None

You may decide if this was the right thing to do, however I can now see the old messages. Looks good. ;)

@xpac1985 That looks like the correct fix to me. Thanks for debugging. If you are interested in creating a PR feel to create one. I would suggest some additional changes as well.

Add test for the case plan_type ==  Realm.SELF_HOSTED in function test_change_plan_type present in the file zerver/tests/test_realm.py

If you open the file zerver/tests/test_import_export.py you can see the following two lines in the function test_plan_type
realm.plan_type = Realm.STANDARD
realm.save(update_fields=['plan_type'])

I would replace them with the following line
do_change_plan_type(realm, Realm.STANDARD)

Also make sure to export do_change_plan_type from zerver.lib.actions.
I would also add tests checking that the realm.max_invites, realm.message_visibility_limit and realm.upload_quota_gb is correctly set in the following two cases.
   with patch('logging.info'):
          with self.settings(BILLING_ENABLED=True):
              realm = do_import_realm(os.path.join(settings.TEST_WORKER_DIR, 'test-export'),
                                      'test-zulip-1')
              self.assertTrue(realm.plan_type, Realm.LIMITED)
              self.assertTrue(RealmAuditLog.objects.filter(
                  realm=realm, event_type=RealmAuditLog.REALM_PLAN_TYPE_CHANGED).exists())
          with self.settings(BILLING_ENABLED=False):
              realm = do_import_realm(os.path.join(settings.TEST_WORKER_DIR, 'test-export'),
                                      'test-zulip-2')
              self.assertTrue(realm.plan_type, Realm.SELF_HOSTED)
              self.assertTrue(RealmAuditLog.objects.filter(
                  realm=realm, event_type=RealmAuditLog.REALM_PLAN_TYPE_CHANGED).exists())

If you have don't have time or have any issue to personally create a PR that is fine as well. I will take care of this :)

Hey @hackerkid,
thanks for the confirmation.
I actually was about to create a PR for this, but wasn't willing to read the whole CONTRIBUTING stuff for a few lines of code fix, also I've never worked with test suites before and didn't feel comfortable messing with your tool ;-)
Therefore, I'd prefer if you could add this PR. Thanks in advance!

@xpac1985 I have created #14024 :)
I also made the following changes on top of your fix.

Setting realm.max_invites to Realm.INVITES_STANDARD_REALM_DAILY_MAX instead of Realm.INVITES_STANDARD_REALM_DAILY_MAX.

Setting realm.upload_quota_gb to None instead of Realm.UPLOAD_QUOTA_STANDARD.

@hackerkid thanks :)
what's the proper default now? INVITES_STANDARD_REALM_DAILY_MAX or INVITES_DEFAULT_REALM_DAILY_MAX ;)
I just went with the bigger number, but I admit I didn't fully understand the implications :)
I changed my code accordingly and updated again to make sure I get the proper upload limit. 👍

@xpac1985 I realized that the best way to do this is to set the value of max_invites to None. In that case the value defined in settings.INVITES_DEFAULT_REALM_DAILY_MAX would be used as the limit. So if you want to increase the limit you can change the value of INVITES_DEFAULT_REALM_DAILY_MAX in settings file.
I have updated the code and previous comment as well to reflect the change.