Run custom rules on Android

Hi. I am trying to run my custom rules on Android project, but it seems not working.
Here is my project build.gradle file
buildscript {
    ext.kotlin_version = '1.3.61'
    repositories {
        mavenCentral()
        jcenter()
        google()
        maven { url "https://plugins.gradle.org/m2/" }

    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.5.3'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
        classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.4.0"
    }
}

allprojects {
    repositories {
        mavenCentral()
        jcenter()
        google()
        maven { url "https://plugins.gradle.org/m2/" }
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

Here is the app level build.gradle file
...
dependencies {
    ...
    implementation "io.gitlab.arturbosch.detekt:detekt-api:1.4.0"
}

apply plugin: 'io.gitlab.arturbosch.detekt'

detekt {
    toolVersion = "1.4.0"
//    buildUponDefaultConfig = true
    input = files("src/main/java/demo/detekt")
    config = files("$rootDir/custom-config.yml")
    reports {
        xml { enabled = false }
        html {
            enabled = true
            destination = file("build/reports/detekt.html")
        }
        txt { enabled = false }
    }
//    ruleSets = "$rootDir/app/libs/detekt-rules-1.4.0.jar"
}

dependencies {
    detekt "io.gitlab.arturbosch.detekt:detekt-api:1.4.0"
    detekt "io.gitlab.arturbosch.detekt:detekt-cli:1.4.0"
    detekt "io.gitlab.arturbosch.detekt:detekt-rules:1.4.0"
    detektPlugins(project(path: ':detekt-rules-1.4.0'))
}

My custom config is:
config:
  validation: true
  # 1. exclude rule set 'sample' and all its nested members
  # 2. exclude every property in every rule under the rule set 'sample'
  excludes: "test.*,test>.*>.*"
test:
  TooManyFunctions:
    active: false

My custom rule provider is:
class CustomRulesProvider : RuleSetProvider {
    override val ruleSetId: String = "test"

    override fun instance(config: Config): RuleSet {
        return RuleSet(
            ruleSetId, listOf(
                TooManyFunctions()
            )
        )
    }
}

TooManyFunctions() I took from your example.

Hi! I have similar issue. In my case when I try to add my custom ruleset block inside config.yml, detekt fails with message:
> Task :detekt FAILED
Property 'customrules' is misspelled or does not exist.
io.gitlab.arturbosch.detekt.cli.InvalidConfig: Run failed with 1 invalid config property.

I used mozilla example and it does not works in my project. My detekt version was 1.4.0. After several hours I tried to downgrade detekt version like in mozilla repo (1.0.0-RC16) and it works!! No other changes was made. I suppose something is broken in new detekt versions. Or maybe there are undocumented changes for detekt custom rules integration.
I've tried several different detekt versions:
1.0.0-RC16 - works
1.1.0 - works
1.1.1 - works
1.2.0 - does not work
1.2.1 - does not work
1.4.0 - does not work
1.5.1 - does not work

@SergJ4
Please take a look at the last paragraph of https://arturbosch.github.io/detekt/extensions.html#custom-rulesets.
The config validation was introduced to "protect" users from misspelling property names.
Having the need to manually add some excludes for custom rule sets is indeed inconvenient.
We could automatically add a generic [custom_ruleset]>.*...

@arturbosch, thanks a lot! It works now. I saw this paragpraph, but I misunderstood it. I thought that if it uses exclude keyword, then it should exclude something from config, not include. But anyway, it's my fault. I will read more carefully in the future.

Closed with d0d41cf and 94b89b3

This problem is still going on. Like @robertpicsart mentioned, i created my Rule and Provider. I write the package name of Provider to resources/META-INF/services/io.gitlab.arturbosch.detekt.api.RuleSetProvider. I added config with excludes param and i added my own provider id and rule. Everything is exactly matching with documents. I also tried tasks.withType { dependsOn(":my-rules:assemble") } in the pitfalls section.
The problem is detekt working successfully but it can not find my custom rule issues. The things i saw is:

If i change a random rule name in detekt.yml, build is failing. But if i change the ones that i wrote than it builds successfully. (If i change provider name to something else rather than the name i mentioned in config excludes then build fails. But this is not valid for rules)
And for debugging purposes i put a line that will throw exception in the RuleSetProvider class's method named 'instance' before returning list of rules. And it builds successfully.
Plus it is still giving error even though i copied detekt implementation in mozilla-fenix project that @arturbosch mentioned.
Also SampleConfigValidator is not working just like RuleSetProvider


[REQ] Add Tenant functionality - change Property status 'vacant' to 'occupied'

 Update the property status to 'occupied' when a tenant is added


chore(events): Clamp batchSize between [min, max]

labels: mergeable
Fixes: #issue
Motivation and Context
Make sure we enforce a sane batch size for event ingestion
Description
batchSize will be always between 100 and 10k
How has this been tested?
Wrote test

Follow up from https://github.com/Eppo-exp/js-client-sdk/pull/125


fix: clear localStorage and sessionStorage

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #5326

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

https://user-images.githubusercontent.com/734428/227542183-8b46f52f-d0bb-4453-9826-5dd6ab464699.mov

pay 15 usd

😍 Perfect, I’ve sent the payout
💵 $15 @ 33.83 USD/KSM ~ 0.443 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x15d1a7c482df78fd3b5bcf9df7766f42cad7c7fbd7e79eee28994a3b3a6e91c6
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Ruby ugrade

Description
Ruby version upgrade -> 2.7.2
update gems
Closes

#43
#63
#62
#51
#52
#53
#65

closed by 67 renamed PR branch for azure pipeline


PATECTGAN: dragan_penalty and PAC property

This commit here seems to have erroneously modified the dragan penalty code from 'c' (which is a hyperparameter for the dragan penalty) to be 'pac'.
Reviewing that commit it seems as if there's something strange happening at the intersection of the pac methodology and the implementation of the dragan penalty. I'm a little mystified by the approach of transposing the array as a fix to make the tensors the right size.
For a pac=1 value this should be just fine (as is the default for PATECTGAN, which I'm curious about the motivations for?), but increasing pac to something else (e.g. 10, as ctgan) seems problematic as it there doesn't seem to be a good reason for the transpositions.
Am I missing something?

I also ran into this error when investigating https://github.com/opendp/smartnoise-sdk/issues/489.  It's likely a bug that was introduced in removing the dependency on the unsupported dev release of ctgan.  I'm not as familiar with this code, so I have hesitated to fix it until I have time to really understand what's going on.  Perhaps @lurosenb or @AprilXiaoyanLiu can remember.


Metric LastSuccessfulResponse is updated even if API returns error

The Fastly exporter updates the metric lastSuccessfulResponse even if the Fastly API returns an error. In our case, I noticed that the Fastly token was revoked from the log messages:
level=error component=rt.fastly.com service_id=_reducted_ status_code=403 response_ts=1712674340 err="invalid authentication" msg="token may be invalid"

The metric description suggests that the metric shouldn't be updated:
"last_successful_response", Help: "Unix timestamp of the last successful response received from the real-time stats API."

I tracked it to a specific branch of the code related to retrieving origin metrics as an example:

The function NewMetrics (mentioned above) is called here.
The function MetricsFor is called here from within the spawn function.
Inside the spawn function, the RunOrigins function is called.
Inside the RunOrigins function queryOrigins is called, which returns the API result/error as the second return value, but it is ignored. A few lines down, the metric lastSuccessfulResponse is updated.

Related questions:

Is this the desired behaviour?
If yes, should another metric be introduced?

If necessary, I can take a look at the code adjustments once we agree on the next steps.

I believe the intent of the lastSuccessfulResponse was to indicate that the http request to rt.fastly.com succeeded, regardless of the response status code. If, however, this was the intended behavior I'm not sure I see a use case where you'd want the metric to be set from a 403.
I see two options:

add a label to the metric for the status code. This could retain the existing metric but allow clients to filter where status=200.
only Set LastSuccessfulResponse when the response status code == 200.

I believe the intent of the lastSuccessfulResponse was to indicate that the http request to rt.fastly.com succeeded, regardless of the response status code. If, however, this was the intended behavior I'm not sure I see a use case where you'd want the metric to be set from a 403.
I see two options:

add a label to the metric for the status code. This could retain the existing metric but allow clients to filter where status=200.
only Set LastSuccessfulResponse when the response status code == 200.

I agree with your proposal. Any of those would be helpful. However if we go with the first, there is still the question if the metrics lastSuccessfulResponse should report differently for 4xx and 5xx. From my POV 4xx and 5xx aren't successful responses from the client point of view.


Custom download - error "ENOENT: no such file or directory ..."

What should happen?
On https://foundation.zurb.com/sites/download.html/#customizeFoundation , when choosing options and clicking "download custom build", the zip should download
...
What happens instead?
otherwise blank page shows an error of "ENOENT: no such file or directory, stat '/tmp/tmp.<IP_ADDRESS>a3c3740ed4d405350aba3b87dd5ade3.zip' "

...
Possible Solution

...
Test Case and/or Steps to Reproduce (for bugs)

Test Case:

How to reproduce:

go to https://foundation.zurb.com/sites/download.html/#customizeFoundation

choose these options :

click "download custom build"

Context

Trying to download a minimal build with the components shown to get started on a project
...
Your Environment

Foundation version(s) used: 6
Browser(s) name and version(s): Firefox 70.0.1 (64-bit)
Device, Operating System and version: Mac OS 10.14.6
Link to your project:

Checklist

[X ] I have read and follow the CONTRIBUTING.md document.
[ ] There are no other issues similar to this one. - there are #10826 and #10826 but both are closed . What should I do in this case? Contributing.md doesn't provide guidance for that case, so I'm creating a new issue.
[ X] The issue title and template are correctly filled.

Hi @mrengy,
Please see https://github.com/foundation/foundation-sites/issues/11826
Closing as duplicate.


try out repo-infra git submodule

it includes fork of repo-infra as a submodule

This is great. I tend to avoid submodules at any cost, even if it means vendoring the entire code (given a suitable tool).

But since this is not Go depedency it makes absolute sense to do it this way.

awesome! we'll try to get your changes merged upstream today so we can get this cleaned up and merged!

/cc @linki @mikkeloscar @eparis @iterion will submodule my fork first and then change it to upstream later. Can we merge this?

👍


Remove line to use in Browser

Hi, I've been using card-validator in a learning project and I've noticed that to use it in browser, with dist/validator.js is necessary to delete the last line in the file mentioned:
 module.exports = cardValidator;

Please check and update it.
Thanks.

@jonalxh bower itself is being phased out and they recommend alternatives like yarn or webpack. https://bower.io
I think for npm, yarn etc, this line is required.

Thanks.


docs: add further snippets with new infrastructure

Related to #2399
Related to #2503
Closes #2948
Closes #2947
Closes #2957
Closes #2956
Closes #2953
Closes #2952

Release notes
In this release, we:

Revised our code snippets to use a WYSIWYG format

Summary

This PR builds on the work @arboleya did in https://github.com/FuelLabs/fuels-ts/pull/2651 by introducing some more snippets that have been migrated to the new infra. Once this is merged into that branch then the docs can be refactored to use the folder structure in https://github.com/FuelLabs/fuels-ts/issues/3205
Checklist

[x] All changes are covered by tests (or not applicable)
[x] All changes are documented (or not applicable)
[x] I reviewed the entire PR myself (preferably, on GH UI)
[x] I described all Breaking Changes (or there's none)

This test had the gasLimit bumped here but front ran you, so I'm going to bump it here also to fix CI.


feat(client): delete squash_and_merge in VersionMixin

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 85.914%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
7667

Relevant Lines:
8924

💛  - Coveralls


Plugin installation error

Hi
Can anyone solve my problem?
I am facing error when i am going to install plugin.
Error:Error: Registry returned 404 for GET on https://registry.npmjs.org/cordova-plugi
n-opentok
Is there any solution to install plugin ?

I am facing same problem  since tow days. Can anyone help on it ?


URL schema standardized

Uses standard url schema for sockets, querystring to allow for cache
arguments and an optional redis database url component.
Related to ghickman/django-cache-url#16 and ghickman/django-cache-url#14
I broke backwards compatibility so I'm not sure whether you'll want to accept this. I wrote it after noticing that the Heroku RedisToGo urls that I was getting were redis://user:pass@jack.redistogo.com:10364/ - notice no db number is specified so the existing parsing broke.
I think there are a few problems with the existing url schema though as alluded to in the referenced issues:

When specifying a socket, the url is not a standard file url. The current parsing also relies on the socket name ending in .sock or .socket.
For redis, what I already said about the database not necessarily being specified and needing to be optional. Using the redis://host:port/db[/prefix] format doesn't make much sense since db and prefix are not subordinate resources and writing parsing code to match the format is cumbersome. I think the format of optionally specifying the database as redis://host:port:db makes much more sense and also matches the format of the django-redis location field.
It's not possible to pass cache arguments, using the query string seems like a good candidate for this.

@russelldavies – thanks for making those changes and sorry it's taken me so long to get around to reviewing them. I'm hoping to push a 1.0 release very soon which your changes will be the basis of. You can see this shaping up on the 1.0-release branch.
Thanks for sorting out the url parsing of options -> Django cache options here too, I think that's a really elegant solution.

Sorry for not chiming in before, but this looks a lot cleaner; I love it! I installed the latest in a couple projects and haven't noticed any regressions yet.

@mjumbewu – thanks for your feedback, this is really good to know =)

@russelldavies – thanks for your work on these changes, they're really appreciated!
I've just pushed the 1.0.0 release to the PyPI which your changes make up the lions share of, thanks again =)

@ghickman - Nice one, thanks for the new release.


add property to set 'WithStartTime' on change feed

Adds an option on ChangeFeedOptions used to set ChangeFeedProcessorBuilder.WithStartTime

@allcontributors please add @stormbringer766 for code and tests.


[BLE SNIFFER] BLE sniffer 抓包工具

https://github.com/JiaoXianjun/BTLE

https://github.com/azure-rtos/threadx


GUI for entities

Acceptance Criterias:

[x] List all entities
[x] Add new or delete an entity (ask confirmation before deleted)
[x] Modify entity name
[x] Choose an entity
[ ] Show which intents chosen entity has been used in (i.e. asukoht entity is used in intent: - intent: common_teenus_ilm)
[ ] Go to each intent entities have been described

@vmugra Prototype updated according to AC-s.

@vmugra Prototype updated with last 2 AC-s.

@ceirowe one entity can be mapped in several intents, current view does not allow this.

all good, views updated, in review!

Entities view accorping to the prototype:
List of entities:

Add new/edit an entity:

Display (and go to) entities in the intents:

@ceirowe marked done according to the prototype!

@Kristjan259 I believe this need to be developed also, maybe we could groom this?


⚠ Thumbnails API Endpoint has degraded performance

In a685eb1, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1009 ms

Resolved: Thumbnails API Endpoint performance has improved in c93da41 after 9 minutes.


ConfigSchemaGenerator should ignore casing of configuration keys

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When using ConfigSchemaGenerator, the casing of segments in the config path should be ignored. This is because configuration keys in .NET are case-insensitive.
For example, the following entries should be merged into a single subtree:
[assembly: ConfigurationSchema("Management:Endpoints:Health", typeof(HealthEndpointOptions))]
[assembly: ConfigurationSchema("management:endpoints:Actuator", typeof(HypermediaEndpointOptions))]

I would expect the difference in casing to be ignored, so that the JSON fragment below is produced:
{
  "type": "object",
  "properties": {
    "Management": {
      "type": "object",
      "properties": {
        "Endpoints": {
          "type": "object",
          "properties": {
            "Actuator": {},
            "Health": {}
          }
        }
      }
    }
  }
}

The actual behavior is that no unification takes place:
{
  "type": "object",
  "properties": {
    "Management": {
      "type": "object",
      "properties": {
        "Endpoints": {
          "type": "object",
          "properties": {
            "Health": {}
          }
        }
      }
    },
    "management": {
      "type": "object",
      "properties": {
        "endpoints": {
          "type": "object",
          "properties": {
            "Actuator": {}
          }
        }
      }
    }
  }
}

The same problem possibly applies to the class properties.
Expected Behavior
No response
Steps To Reproduce
No response
Exceptions (if any)
No response
.NET Version info
No response
Anything else?
This should be easy to fix, because JsonObject has a constructor that takes a JsonNodeOptions, which contains the boolean property PropertyNameCaseInsensitive.

/cc @eerhardt I'd be happy to work on a PR to address this.

Thanks. That would be appreciated!


ImageSource is logging forever

Current behavior

This keeps being logged forever.
Repro project: https://github.com/Youssef1313/issues10285
Expected behavior
No response
How to reproduce it (as minimally and precisely as possible)
No response
Workaround
No response
Works on UWP/WinUI
None
Environment
No response
NuGet package version(s)
No response
Affected platforms
No response
IDE
No response
IDE version
No response
Relevant plugins
No response
Anything else we need to know?
No response

Does https://github.com/unoplatform/uno/pull/13459 fix the issue?

Yes, I think. Though we need the changes around unloading the ProgressRing when it's not in the visual tree. Not sure what is the status of it, but the logging itself should be better now with being debug level.


Switch blocks should only register once if multiple are hit at the same time

Just a thing I want you to know that if two players or more hit the on/off block at the same time, the on/off block just change the color once time in SMM2

This is incredibly unimportant

Something like this would be needed for thwomps to be able to hit mutliple switch blocks at the same time, and some smm2 puzzles may require it, but its pretty unimportant as it is.

Implemented only for when the blocks are hit on the same frame. Works with thwomps but may be hard to do in multiplayer 742c9bf222e4f6a306a29df0314b20893a858af7

This is incredibly unimportant

I know 🙃

This is incredibly unimportant

I know 🙃

Since you've been making a lot of issues try to stick to the important ones.


Link Back to SLI Provider in Keptn's Bridge

Is it possible to provide a link back to your SLI provider in the Evaluation Events on Keptn's bridge?, eg the performance signature plugin provides a link back to Dynatrace's  Diagnostic tools--> Top Web requests for the evaluation period.
I have found this to be a great context provider for testers and developers, it encourages them to log into Dynatrace directly from the results and get going with the diagnostics of the performance problem

Hi Leon,
great idea and many thanks for the issue!
We already started a discussion around this idea in the following Keptn Enhancement Proposal: https://github.com/keptn/enhancement-proposals/pull/4.
I will reference your issue at the discussion of the proposal.

The Dynatrace-SLI Service now gives you the option to use a dashboard for SLI/SLO validation. If this option is chosen, the dynatrace-sli-service will add the link back to that dashboard with the correct timeframe to the SLI-done event as a label.
To make this integration even better the link should be clickable as right now you have to copy/paste the link from the cloud native event. An RFE for this "clickable label links" has already been created in the keptn/keptn project: https://github.com/keptn/keptn/issues/2061

With the new feature of having clickable links (see https://github.com/keptn/keptn/issues/2061) this issue can be closed.


Node type assignment

Pods for some core services have migrated over to high-memory nodes, which have a much higher cost that the general nodes.  I tried killing the pod hoping it would restart on a different node, but usually it just restarts on the same node.
I was able to temporarily correct the issue with the following command:
kubectl drain <pod> --ignore-daemonsets
These services need Node-Selectors to ensure proper assignment to general nodes:

conda-store
nfs server
dask-gateway

Fixes for conda-store and nfs-server are available in #323 and https://github.com/Quansight/qhub-terraform-modules/pull/39
Fix for dask-gateway is available in https://github.com/Quansight/qhub-terraform-modules/pull/37

This happens daily due to prefect jobs spinning up resources and causes increased costs of the cluster at rest since an extra high-memory node stays running until I run the command above.
In addition to the suggested fixes above, I think the proper fix is to set a taint on the nodes to prevent other workloads from being scheduled on them, as seen in 2i2c's terraform setup here.
@dharhas, any chance we can get this added to the next release?

Added to the upcoming release milestone. @brl0 if you feel confident in adding another PR to set the taints go for it.

@brl0 closing this issue. Let us know if merging that PR and the new release does not fix the issues.


aurbuild: provider selection

Does --noconfirm choose the default (1) when multiple providers are available?

@rmarquis Thoughts? I'm hoping to avoid a separate mechanism for this...

Yeah, think so.

via 6b733688d445d5046d21ef7228a551fb0b71f20e


GenerateResourcesandImage failing with parsing JSON file for Linux and windows builds

Description
Running the generate script with tags for linux and windows build fails with the following error :
Failed to parse file as legacy JSON template: if you are using an HCL template, check your file extensions; they should be either *.pkr.hcl or *.pkr.json; see the docs for more details: https://www.packer.io/docs/templates/hcl_templates.
Original error: Error parsing JSON: invalid character 'ÿ' looking for beginning of value
At line 1, column 1 (offset 1):
    1: �
      ^
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[X] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Failed to parse file as legacy JSON template: if you are using an HCL template, check your file extensions; they should be either *.pkr.hcl or *.pkr.json; see the docs for more details: https://www.packer.io/docs/templates/hcl_templates.
Original error: Error parsing JSON: invalid character 'ÿ' looking for beginning of value
At line 1, column 1 (offset 1):
    1: �
      ^
Is it regression?
NO
Expected behavior
Build to proceed
Actual behavior
Failed to parse file as legacy JSON template: if you are using an HCL template, check your file extensions; they should be either *.pkr.hcl or *.pkr.json; see the docs for more details: https://www.packer.io/docs/templates/hcl_templates.
Original error: Error parsing JSON: invalid character 'ÿ' looking for beginning of value
At line 1, column 1 (offset 1):
    1: �
      ^
Repro steps
run the generate script with -tags parameter

@vpolikarpov-akvelon  can you pls help with this? It appears you resolved it in https://github.com/actions/runner-images/issues/6946 but it is back again :-(

Hi @vamshisiram. Could you provide the whole command you are trying to run so we can test it?

Here is the command
GenerateResourcesAndImage -SubscriptionId {MySubscriptionId} -ResourceGroupName "myTestResourceGroup" -ImageGenerationRepositoryRoot "C:\runner-images-main" ImageType Ubuntu2004 -AzureLocation "centralus" -tags @{id="126759764897437896gjfy87";environment="prod"}
Repeat for windows os, just change the images type.
Result is same for both Linux and windows.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Vasilii Polikarpov @.>
Sent: Thursday, May 4, 2023 1:22:30 PM
To: actions/runner-images @.>
Cc: vamshisiram @.>; Mention @.>
Subject: Re: [actions/runner-images] GenerateResourcesandImage failing with parsing JSON file for Linux and windows builds (Issue #7534)
Hi @vamshisiramhttps://github.com/vamshisiram. Could you provide the whole command you are trying to run so we can test it?
—
Reply to this email directly, view it on GitHubhttps://github.com/actions/runner-images/issues/7534#issuecomment-1535362989, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVU36WTNM6MQVFE52DU52QDXEQFYNANCNFSM6AAAAAAXWBL7VU.
You are receiving this because you were mentioned.Message ID: @.***>

Hey @vamshisiram. The issue should be fixed now. Could you please sync your local main branch and try again?

Thanks, I will give it a try.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Vasilii Polikarpov @.>
Sent: Tuesday, May 9, 2023 9:55:04 AM
To: actions/runner-images @.>
Cc: vamshisiram @.>; Mention @.>
Subject: Re: [actions/runner-images] GenerateResourcesandImage failing with parsing JSON file for Linux and windows builds (Issue #7534)
Hey @vamshisiramhttps://github.com/vamshisiram. The issue should be fixed now. Could you please sync your local main branch and try again?
—
Reply to this email directly, view it on GitHubhttps://github.com/actions/runner-images/issues/7534#issuecomment-1540533404, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVU36WSXRB7PLUSJWJ4H4TTXFJZGRANCNFSM6AAAAAAXWBL7VU.
You are receiving this because you were mentioned.Message ID: @.***>


Is this repo dead?

I see there have been no new activity from the maintainer recently on GitHub and I'm wondering if this project has been abandoned by him?
It is very useful project and a lot of people are using it.
I had few ideas about improvements to the project, and I'm thinking about making a fork and continue maintaining it my self.

I know it might be a stupid question, giving that every thing points to the death of this rope, and I'm free to fork it at any time, but it might be a great thing if the current maintainer give his though about this or if any other user want to say something.

Unfortunately, it's most likely dead. As far as I am aware, the maintainer hasn't touched this project since around August 2021.
I don't mean to shamelessly promote my own project, but about a year ago, I found myself in a similar position as you (#60) and I created my own fork: https://github.com/Anomalocaridid/handlr-regex. Issues and PRs are welcome if you or anyone else reading this would like to share your ideas there.


More Supported Platforms

Component to Improve
Core Engine
Describe Your Suggestion
Windows, Linux, and macOS are nice platforms to work on, but it's always nice to run on as many platforms as possible.

[ ] Run on Android devices

[ ] Run on a Quest headset (blocked by #75)

[ ] Run in a web browser (emscripten)

For any of these to become feasible, the engine must own the main loop.

More and more GPUs are beginning to let OpenGL fall to the wayside support wise as Vulkan becomes more popular. Something I noticed way back in the SRB2 community where issues with OpenGL and AMD were very common in fact.
Additionally, OpenGL fragmentation is extremely bad on Android. We should add Vulkan to this list.


Specifying plasmusicToolbar without any conf installs Plasma 5 version

Hello, I have added plasmusicToolbar  to my Plasma 6 panel based on the example in https://github.com/nix-community/plasma-manager/blob/trunk/examples/home.nix#L169.
If I don't specify any config for it, it installs the Plasma 5 version on Plasma 6 and doesn't work.
If I add config (as in the example) or if I specify it as "plasmusic-toolbar", it also works.
WORKS
panels = [
  {
    location = "bottom";
      "org.kde.plasma.panelspacer"
      {
        "plasmusicToolbar" = {
          panelIcon = {
            albumCover = {
              useAsIcon = true;
            };
          };
        };
      }
      "org.kde.plasma.marginsseparator"
      "org.kde.plasma.systemtray"
      "org.kde.plasma.digitalclock"
      "org.kde.plasma.showdesktop"
    ];
  }
];

DOESN'T WORK, no error displayed when doing home-manager switch
panels = [
  {
    location = "bottom";
      "org.kde.plasma.panelspacer"
      "plasmusicToolbar"
      "org.kde.plasma.marginsseparator"
      "org.kde.plasma.systemtray"
      "org.kde.plasma.digitalclock"
      "org.kde.plasma.showdesktop"
    ];
  }
];

WORKS, but cannot add config
panels = [
  {
    location = "bottom";
      "org.kde.plasma.panelspacer"
      "plasmusic-toolbar"
      "org.kde.plasma.marginsseparator"
      "org.kde.plasma.systemtray"
      "org.kde.plasma.digitalclock"
      "org.kde.plasma.showdesktop"
    ];
  }
];

It doesn't install the plasma 5 version. It doesn't install the package.
It is because if the specified widget is a simple string, it is converted is converted into:
{
  name = "plasmusicToolbar";
  config = {}
}

And for setting widgets, we need to set the correct widget id in name. That is why "plasmusic-toolbar" works, and "plasmusicToolbar" doesn't

If you want to use without setting any configuration using the widget-specific options, you can just use
{
  plasmusicToolbar = {};
}

I assume this is about me not fully understanding the behind-the-scenes details and not an actual bug, then :slightly_smiling_face: Thanks!


How to set checkbox border color?

How can I set border-color or outline of a checkbox?

Ah I see. Can I apply a custom outline color only to a specific checkbox, instead of setting outline color globally?

Hi Abed,
this Codepen shows you how


Mnemonic seed encryption and storage lib

What kind of PR is this?:

/kind feature
What this PR does / why we need it:
dependency of #344
this is actually worked backward, trimming down code done in 344 to ease review process
Which issue(s) does this PR fixes?:

Fixes #
Additional comments?:
wait for #331 and #369

Conflicts


Fix get namespace public command

Current dependencies on/for this PR:

main

PR #183   👈

This stack of pull requests is managed by Graphite.


WoW 3.3.5a Crash on Debian - NVidia 510.85.02

Please describe your issue as accurately as possible.
If you use Windows, please check the following page: https://github.com/doitsujin/dxvk/wiki/Windows
Software information
Name of the game, settings used etc.
World of Warcraft 3.3.5a
Any help would be greatly appreciated. Running native is trash and I'd very much like to get this operating. Vulkan is running properly on my GPU AFAIK, I attached my vulkaninfo output.
System information

GPU: NVidia Quadro K620M
Driver: 510.85.02
Wine version: wine-7.0
DXVK version: 2.0-async (I've also tried using winetricks)

Apitrace file(s)

Put a link here

For instructions on how to use apitrace, see: https://github.com/doitsujin/dxvk/wiki/Using-Apitrace
Log files

d3d9.log:
d3d11.log:
dxgi.log:

Here's the output when I run "wine wow.exe", I have tried editing various settings in dxvk.conf to no avail.
This is on a fresh wine32 prefix as well. I have tried using both winetricks as well as manually downloaded 32-bit dxvk dlls.
wow_d3d9.log
2022-12-10 00.08.28 Crash.txt
vulkaninfo.txt

NVM - I was running wine stable at 7.0 and needed 7.1 minimum. My bad. Thank you!

Hello.
Do i understand correctly that you solved your issue? 🙂

I think he resolved the issue yes. But he is also using async dxvk it seems, so that should be removed from here anyway


Task parameter not recognized in BiCV_factor

While running the BiCV_factor module, following error occurs:
INFO: Running fake_vcf:
ERROR: [fake_vcf (fake_vcf)]: [fake_vcf]: Failed to execute process
"R(fr"""library("dplyr")\nlibrary("readr")\n## Add fake header\n...output[0]}.stdout')\n"
name 'walltime' is not defined

When replacing the walltime with a string as "24h", following error occurs:
INFO: Running fake_vcf:
ERROR: [fake_vcf (fake_vcf)]: [fake_vcf]: Failed to execute process
"R(fr"""library("dplyr")\nlibrary("readr")\n## Add fake header\n...output[0]}.stdout')\n"
name 'mem' is not defined

However, the task line is completely copy-pasted and the parameter mem/ walltime definitly defined, as followed
task: trunk_workers = 1, walltime = walltime, mem = mem, cores = numThreads, tags = f'{step_name}_{_output:bn}'

[global]
# The output directory for generated files. MUST BE FULL PATH
parameter: cwd = path
# The molecular phenotype matrix
parameter: phenoFile = path
# The covariate file
parameter: covFile = path("./")
# For cluster jobs, number commands to run per job
parameter: job_size = 1
# Wall clock time expected
parameter: walltime = "5h"
# Memory expected
parameter: mem = "16G"
# Number of threads
parameter: numThreads = 8
# Software container option
parameter: container = ""
parameter: name = ""
# N PEER factors
parameter: N = 30

# Default values from PEER:
## The number of max iteration

parameter: iteration = 10

This module can be ran the day before yesterday. And other module, namely PEER, can be ran with the exact code today.
The module will work if removing the -J -q -c option (not involving the task statement).

Progress: It is highly likely that the issue is caused by output_from("") statement. Verifying.

Verified the following behavior:
invoking other step by output_from , named_output , and provides will cause the task statement not being able to recognize the global statement. What I am confuse is that why it works previously.
[global]
# The output directory for generated files. MUST BE FULL PATH
parameter: cwd = path("./")
# For cluster jobs, number commands to run per job
parameter: job_size = 1
# Wall clock time expected
parameter: walltime = "5h"
# Memory expected
parameter: mem = "16G"
# Number of threads
parameter: numThreads = 8

[A]
output: file = f'{cwd:a}/test_file'
task: trunk_workers = 1, walltime = walltime, mem = mem, cores = numThreads, tags = f'{step_name}_{_output:bn}'
bash: expand= "$[ ]", stderr = f'{_output}.stderr', stdout = f'{_output}.stdout'
    touch $[_output]
[B]
input: output_from("A")
task: trunk_workers = 1, walltime = walltime, mem = mem, cores = numThreads, tags = f'{step_name}_{_output:bn}'
bash: expand= "$[ ]", stderr = f'{_output}.stderr', stdout = f'{_output}.stdout'
    touch $[_input]

For this particular probelm, I think what make sense is to remove the task statement in fake_vcf step, as it will by no means require a lot of resouce. For future usage, this should be addressed.


fixfix cdc failed to synchronize datetime type in mysql, and added JsonDebeziumSchemaSerializer

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run build all

run buildall


watch() on a ref obtained through toRefs() is not a deep watch

Vue version
3.3.4
Link to minimal reproduction
https://play.vuejs.org/#eNrtVclu2zAQ/ZWBLnYRR3Yc9KLaAdoghxTogrS3qgdFGklMaFIgKS8w/O8dktqcDUXRAjnUF4nDN8M3o/foffC+qsJ1jUEULAyuKp4YvIgFwOKyZDyDSGGOCkWKyzhIRFpKFQcwHUDmL2AW00FNWupUscrQO1tVUhnYQ4Y5E3gpaS1QmAkoTFLD1ggHyJVcwYjIjd51GZ6V3wmnbmXpP0TMjyHzFhML3DoUnZvU3D2H54/3trG0XeqIKLoKk7buYWKrAGg0dTV+Ay7BpghtwDcPy64LX8/+thHMKNUvdv3i8MbRsq9U8loYVOuEj6ny8qItDk3hcEulu9cTOKNUV2MCZ7PZrK+kiJwSxL0hdHBAS90dt5h2HyKYBEYT+ZwV4Z2WgnTgDo0DOwTGUX2pDKPm4oBm4avTR+Zcbj66mFE1Nq1QTonp/RPxO721sTj4qlBTgxgH3Z5JVIHGb199+4xbeu82VzKrOaFf2LxBLXltOXrYh1pkRHuAc2yvnTqYKL7rq61BodumLNF2OhZNSrFyeK71nu55eO7yaKg0xU6K1kmPdG6BD6VuY+Qc95Tik6zp22dutUlMWvZvV3mOaYv3unILI28w1/ajHlvl90ReKVmRvn+MOveOfh5p2wEeCHxvGXs0GXTZUGigjRo9cqUL54N8PLoWzIx6cXI0hLHdWqfMurjrddwqvjunM82YfHHsCn+W5BhyWbjthoLfckecnAxiRCokWI10cN83pGUiCswiGJGpmrwuy+vC/qZTqAVHrYHmy1nKDN/BKlH3YEr09CHRNG2s7PMWSXYTGGT3MKZBSEPaY0VBJDISwGCyns8g0d6TWHmtWsHZ8BNutzN/3uq0OL7hM7aGlCda07WdWvnGwcW+qXJYTGn7qSvc7DgCXRkVZhQJXaL/JLdJel8oGh9NknpyRFLJpYpgUzKDLlAiK0oT2Qur2rrIhmWmjOBtF8iYpgPpjsw5+kjCWSFOqcSKFJuShJvvc1drw/LdKcmALE1VdZWkeJo4EoSgUdEALGN/1fV/Bv9d+ldc6kqGr8er/8wa8z/2xvyxOQqFKF6dPQ6/AO9LUTE=
Steps to reproduce
In the reproduce setup, the parent component (App.vue) creates a reactive state, called anchor, and passes the state to two child components: Child.vue and Child2.vue.
These two child components are supposed to watch the changes on the anchor property, and update the text whenever anchor state has a change:

Child (red) is the one with the bug, the text is not updating unless the watch made explicitly { deep: true }
Child2 (green) is the correct one, wired up exactly the same as Child except the stuff being watched is props.reference instead of the reference in const { reference } =  toRefs(props);

What is expected?
According to the documentation, this watch in Child.vue should be deep by default, and the text driven by msg should update every second:
   const { reference } = toRefs(props);

    watch(
      reference,
      (val) => {
        counter++;
        msg.value = 'reference changed: ' + counter;
      }
    );

What is actually happening?
The Child.vue watch is not deep, and does not trigger when the parent component updates the anchor state. You have to explicitly make the watch deep in order to get it triggered properly.
System Info
No response
Any additional comments?
No response

According to the documentation, this watch in Child.vue should be deep by default

It should not be deep, which part of the documentation are you referring to?

I was referring to this: https://vuejs.org/guide/essentials/watchers.html#deep-watchers
But on a second look, it says “if you call watch directly on a reactive object” - does this mean the behavior literally applies only to things created using reactive(), not ref() of an object, or ref whose value is set to a reactive object?
Xinchao
On 26 Jul 2023, at 2:51 PM, Jacek Karczmarczyk @.***> wrote:

According to the documentation, this watch in Child.vue should be deep by default
It should not be deep, which part of the documentation are you referring to?
—
Reply to this email directly, view it on GitHubhttps://github.com/vuejs/core/issues/8847#issuecomment-1651081852, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIUJUJGJDQH62UVOXPV5RTTXSC46LANCNFSM6AAAAAA2YCYQ3U.
You are receiving this because you authored the thread.Message ID: @.***>

Yes, see https://github.com/vuejs/core/blob/main/packages/runtime-core/src/apiWatch.ts#L208

I see, thanks. Mystery solved then, I will close this.


Bug: RSMM does not support logging in through browser

Studio may prompt the user to log in through the browser. When this occurs, RSMM does not handle it gracefully:
https://gfycat.com/ColorlessQuarrelsomeLeafcutterant
(this can be worked around by uninstalling RSMM, logging in, and then reinstalling)

Oof. I'll see what I can do.

Not 100% sure if this is fixed in the latest patch, but the data passed to the mod manager shouldn't be ignored. If it still appears to be happening let me know.

Can confirm this is fixed now.


TableAid.ObjectComparerOne fails if there are no tablerows

Title.
Unless I can be convinced otherwise, I think it's a bug. I feel like ObjectComparerOne should take 0 or 1 rows, not exclusively 1 row.

Celluj34,
Thanks for the comment.  ObjectComparerOne by design only takes 1 row, as it intends to compare an object with a tablerow.  Consider the following:
•	Object is not null, TableRow exists: compare properties.
•	Object is null, TableRow exists: throw Assert.
•	Object is not null, TableRow does not exist: throw Assert.
•	Object is null, TableRow does not exist: should this be valid or throw Assert?
A cucumber example would be most helpful to determine expected behavior.
Regards


Select input not opening in dragable item

There seems to be a problem when using a select input field in a dragable container of dragula.
Check the following fiddle https://jsfiddle.net/97o72b1t/

can submit a PR for this.

Check PR #234 fixed focus for select inputs

Published as 3.5.2


Add ButtonIcon

According figma files.
But it's kinda not super at focus but work

In general not all requested changes are mandatory. But forward ref, some props changes and reuse code from Button i guess would be helpful.

Don't be actual


Decrease external_sorter memory consumption when sorting few elements

In #98 we intend to template all algorithms to only use the external memory data structures we use now, if we cannot guarantee they could live entirely in internal memory. The main idea is to derive (as tight as possible) upper bounds on the number of elements placed within these data structures.
This worst-case estimate has to be given to the internal memory alternatives for them to initialise. Yet, we can also use these to improve performance of the current external memory variants. Specifically, if we know the number of elements are very few, then we can limit the amount of memory they initialise (see this comment on #98) and so especially improve performance in the levelized priority queue even for the external memory case.
The computations involved in this should be placed in the constructor of external_sorter.

The current bounds on each phase are used as a maximum on each phase.
The magic number of ~5 MiB is a lower bound on phase 1 and ~10 MiB on phase 2 and 3.
The bound from #98 can be placed in the max_elem variable. All three phases are decreased to the space needed for all elements or maybe the closest power of two larger than it.

This is first relevant when we have solved #170


Add clang-format target

Hi,
In working on my PR for cage, I realized that many of the problems which had occurred in my first suggestion were style issues. These could easily be caught automatically using a tool such as the clang-format target provided by the meson build system (meson automatically creates a ninja target clang-format when a .clang-format file is present in the root directory and clang-format is installed. One can then write the .clang-format file to one's liking and simply require that PRs be processed accordingly. I think this would lead to less work for everyone and enhance the uniformity of the coding style.
cheers,
project-repo

Yes, absolutely. I was thinking the same while reviewing your PR.


Add workaround and update for intel-bootc

Added workaround for libdnf,hl-smi binary and ilab wrapper.

LGTM


[Feature]: Expand slider to fill container

Is your feature request related to a problem?
When I use the horizontal layout mushroom cards leave a lot of space which the slider could expand into (towards "stue" and the icon) to make it easier to use on a touch screen:

Describe the solution you'd like
It would be great if it was possible to toggle a setting that would expand the slider.
Alternatively the icons could be moved in the space between title and slider to make it possible to expand the slider further to the right
Describe alternatives you've considered
Previously I used the following code to achieve a wider slider, but this stopped working:
card_mod:
  style: >
    .container.horizontal > ::slotted(:not(:last-child)) {margin-right:
    -55%!important;}

Additional context
No response

Hello, if multiple cards are displayed one below the other. The control sizes will be different because entity name and different. The interface will be less clean. I didn't find acceptable solution for this problem.

But if the user could select the percentage split that would solve the problem with multiple
Cards as the user could select e.g 70% for all cards

I do not prefer to offer options like this.
Here's the fix :
card_mod:
  style: |
    ha-card > mushroom-card > .actions { margin-left: -55% }


Dump test report to xml file for CI

Dump test report to xml file for CI parsing

Need to make sure nested exceptions are caught in high level and test doesn't end with raised exception, but reported as a test failure itself


Renovate Option Collision

Hi there!
If I'm misunderstanding at all in the below, please feel free to close this issue without response. I recognise the release of 24.11 effectively makes this redundant also
Currently the renovate definition may be broken on systems utilising an unstable input (0fcb98acb6633445764dafe180e6833eb0f95208 in my instance) - as the use of nixosModule will my design include all options on the host, any host utilising the modules and an unstable input will likely encounter evaluation errors (example) as the option also has existed for a while via https://github.com/NixOS/nixpkgs/pull/318384
My solve for this is just to pin to 70d3b88b52af86098b7e008622871265ec39c800 - but I'd love to assist if possible in resolving this so the pin can be removed, conceptually the current code should be fine, but I may be lacking coffee :grinning:

Again, thanks for these modules! :heart: :1st_place_medal:

thanks! should be fixed by #157


Extension for code completion

I am looking for a very light-weight code editor for a new language. prism-code-editor is very attractive because of the small size and the use of prism for easily defining syntax highlighting - especially compared to CodeMirror which has a very high bar to support new languages.
However there is a key feature I need which is code completion - i.e. a downdown list of possible completions at the current point in the code. I don't see any examples like that. Would such an extension be possible?

This is something I've thought of adding in the past, but have never gotten around to. There's the addTooltip() utility (example on StackBlitz) that would make it easy to display the dropdown list itself. But there's obviously much more to handle than just placing the dropdown. Here's a list for simple code completion. You would need to:

conditionally display the dropdown when the user types
handle opening the dropdown anytime with Ctrl+Space
hide the dropdown when the selection is changed or when pressing Escape
handle selecting a completion with the Tab or Enter keys or by clicking
handle navigating up/down with arrow up/down and page up/down
filter and sort the completions based on the word before the cursor
handle inserting the completion with the insertText() utility and scrolling the cursor into view afterwards

None of these problems are hard to solve, but you might want something more sophisticated. For example returning no completions when inside a string or comment.
I am currently busy practising for exams, so I won't have any time to work on this before next month. What I'm thinking about making in the future is an extension that handles displaying, filtering, sorting and selecting the completions, where each language can define its own function that returns a list of completions based on the current state of the editor. It likely won't support tab stops initially.
If you want to implement code completion in your own projects, I hope this description helps. If not, would the proposed extension be sufficient for your needs?

Thanks for the thoughtful response. As you point out there are a lot of little behaviors to get right for completions to work well.
Starting with an extension that can display a list of completions, and leaving it to the application developer to determine what completions are currently relevant, seems like the best first step.
For my application I have my own parser and the document parse-tree available so I would want to use the application code to completely determine the list of available completions.

For my application I have my own parser and the document parse-tree available so I would want to use the application code to completely determine the list of available completions

This would be no problem with the proposed extension. I'll begin working on it next month.

@FIameCaster I am looking forward to having the feature as well. Let me know if you need someone to test it.

Maybe there is some value to be taken from LSP completion item logic. Of course something much more simpler, but some basic expectations:

Trigger characters (i.e, ", . etc)
Completion List (i.e, datasets used for completions)

The work done here https://github.com/yuku/textcomplete may also be of value.

@k1w1 @dmitrijsc
Good news, I have released a beta version with an experimental autocomplete extension. Check out the StackBlitz demo. It shows you how to add the extension and allows you to try it. If you want to try it locally, install the 3.4.0-beta.1 version from NPM.
It's somewhat lacking in features currently, but I am satisfied with what's implemented.
The following is planned for future beta versions:

Icons for different completion types
Allowing completions to insert text other than their label
Completion for SVG tags and attributes (maybe)

Since this is a pre-release, everything is still subject to change. Any feedback would be appreciated.

@FIameCaster Looks great! I'll try it out during the week.
P.S. I'm planning to implement language support and completion for JSONata, probably by the end of August or September.


Include a static type checker?

Since pyiron_workflow uses type hints we should include a static type checker like (https://mypy.readthedocs.io/en/stable/index.html)[mypy] in the CI.

This is exclusively for static typing though, in which case we still need our existing type checking? Then for me including it vs recommending it is just a matter of how big the extra set of dependencies is. I didn't look at the whole tree, but the dependency list for the main package is non-trivial, so I'm neither closed to this nor immediately convinced.

This is for our code base of pyiron_workflow not the the workflow graphs. For the workflow graphs we have to do it ourselves. The dependencies do not really matter as it is only used in the CI during development.

For example:
pyiron_workflow/nodes/composite.py:390: error: Item "str" of "Node | str" has no attribute "inputs"  [union-attr]
It tells you, if the type is str, the statement xxx.inputs will fail, because str does not have an attribute inputs.

Not a great example -- this is a false positive. Check right above this in line 355.

No, it is not. It is a static type checker. You will get runtime type checking by the python interpreter.

Ah, sorry, I had misunderstood the strictness of "static". It's not merely that it doesn't guarantee runtime behaviour, but it isn't parsing any of the transformation operations. Totally fair.

The question is: Do you want the type hints to be a auto-completion helper for the user/IDE or a typing system?

 My only question is at what cost of cons? For instance,
def replace_child(
    self, owned_node: Node | str, replacement: Node | type[Node]
) -> Node:
    if isinstance(owned_node, str):
        owned_node = self.children[owned_node]
    ... # Proceed as though `owned_node` is a `Node` _in the scope of this function_

Is perfectly readable. Perhaps it's lack of imagination on my part, but if I am understanding correctly then to get the static linter happy with this would require something like
def _make_sure_its_a_node(self, node: Node | str) -> Node:
    if isinstance(node, str):
        node = self.children[node]
    return node

def replace_child(
    self, owned_node: Node | str, replacement: Node | type[Node]
) -> Node:
    self._replace_child(
        self._make_sure_its_a_node(owned_node),
        replacement
    )

def _replace_child(
    self, owned_node: Node, replacement: Node | type[Node]
) -> Node:
    ...

And in general this is the pattern whenever we have type overloading for user convenience. I'm just not convinced that the pros of maintaining IDE hints inside the scope of the function is worth the con of extra misdirection.
With that said, mypy (or similar) is still a nice idea. It may highlight places where we can get the static typing benefits at zero additional cost. I'm just not currently convinced it's something we should be strictly enforcing, i.e. I don't want to see the CI having ❌ because mypy complains.

Fair enough, I would also not want to make the code essentially complexer by this. Does mypy allow/parse special comments like # mypy var:type to make it aware of a overloaded variable converted to a specific type internally? Then it could stay the same code :)

I just had a quick look at the documentation
There is # type: ignore to ignore an error from a specific line.
Otherwise one can use type-narrowing-expressions
If I understand this correctly both of the following snippets should work fine:
def replace_child(
    self, owned_node: Node | str, replacement: Node | type[Node]
) -> Node:
    if isinstance(owned_node, str):
        owned_node = self.children[owned_node]
    assert isinstance(owned_node, Node)
    ... # Proceed as though `owned_node` is a `Node` _in the scope of this function_

def replace_child(
    self, owned_node: Node | str, replacement: Node | type[Node]
) -> Node:
    if isinstance(owned_node, str):
        owned_node_used: Node = self.children[owned_node]
    else:
        owned_node_used: Node = owned_node
    ... # Proceed as though `owned_node_used` is a `Node` _in the scope of this function_

Nice! I find the second one a little clunky, but the assert version is pretty slick

Frankly speaking, I am not too familiar with mypy and what possibilities it offers. I have to read the documentation and see. I just know large projects that want to have strong typing use it.
Generally, I think everything not enforced and automatically checked is not existent. It might work for the first year and first few thousand lines of code, but in the long run it will get unreliable. It is a decision of general principle. Do we want to put the effort in and have the advantage of a strongly typed language, or are we ok with hints that will be correct most of the time but might also be incorrect.
Since my background is in strongly typed languages I favour this approach. :)

I should have spent more time in preparing the example. In fact, mypy is smarter than I thought and takes into account runtime type narrowing, like @niklassiemer already pointed out. The following code is correct and does not trigger any warnings:
from typing import List

def func(a: List[int]|int):
    if isinstance(a, int):
        a = [a]
    a.append(5)

Not a great example -- this is a false positive. Check right above this in line 355.

This is a type violation.
        if isinstance(owned_node, str):
            owned_node = self.children[owned_node]

returns Semantic not Node. And Semantic is not a Node. But owned_node: Node | str.
    def children(self) -> bidict[str:Semantic]:
The real problem is:
pyiron_workflow/mixin/semantics.py:191: error: "bidict" expects 2 type arguments, but 1 given  [type-arg]
pyiron_workflow/mixin/semantics.py:191: error: Invalid type comment or annotation  [valid-type]
bidict[str:Semantic] is an incorrect type bidict[str, Semantic] would be correct. And then, the assignment is flagged as incorrect.
I think this is a very good example illustrating my previous point of hints being only hints that cannot be trusted if they are not checked and enforced.

The real problem is: ...

Indeed, that's a typo and mypy would catch it. I think the more important problem here is rather:

And Semantic is not a Node

But then, I think the solution from @niklassiemer with assert isinstance(owned_node, Node) is  the best way to go. Because as is, Composite.children is directly inherited from SemanticParent.children where it is hinted as Semantic. Since Node is Semantic, the type hint is not wrong, but Composite narrows this in practice without explicitly re-defining the hint for .children. It then comes down to this:

Generally, I think everything not enforced and automatically checked is not existent. It might work for the first year and first few thousand lines of code, but in the long run it will get unreliable. It is a decision of general principle. Do we want to put the effort in and have the advantage of a strongly typed language, or are we ok with hints that will be correct most of the time but might also be incorrect.

I totally agree that if it's not in the CI it's not reliably there. But honestly it's not reliably there to begin with -- a decent amount of stuff has no type hint to start with. In some places, like adding an assert(thing, isinstance(SomeType), I find the fix very palatable. In other places, e.g. in Composite(SemanticParent).children where we narrow the scope in SemanticParent.children from Sematic to Node(Semantic), it seems to me like we probably need to have a bunch of extra boiler plate like
@property
def Composite.children(self) -> bidict[str, Node]:
    return super().children

And honestly I'm just not sure I want to commit to imposing a bunch of boiler plate on the python code. I definitely see the appeal and benefit of having the types be testably reliable, but, oof, I have flat zero desire to go around writing code like the snippet immediately above. Also, like you, I have very little (none in my case) experience with mypy, so I don't feel I have a super clear picture of exactly how steep the price to pay will be, and thus am not ready to come down super hard on either side here.

Letting it percolate more, and with the examples from @niklassiemer suggesting to us that mypy may let us accomplish it without making the code insanely ugly, I'm moderately in favour of the change.
@XzzX, in addition to ruff, would you be interested in getting a mypy suite running in pyiron/actions behind a flag? We can turn it on in a PR here and discuss the results. It is also probably easier to use from the get-go, so I imagine the impact is even better in greenfield projects. (It doesn't have to be you that does this, I'm just picking on you because you opened the issue. @mbruns91 and @samwaseda have both played in the centralized actions so maybe they are interested in doing/watching this.)

I did a first test run of mypy in pyfileindex. https://github.com/pyiron/pyfileindex/pull/161 I think it is an helpful addition and a great step to improve our code quality. Still it might take some time to update all repositories to have strict type hints.

Letting it percolate more, and with the examples from @niklassiemer suggesting to us that mypy may let us accomplish it without making the code insanely ugly, I'm moderately in favour of the change (as long as we can continue to find reasonably aesthetic routes accomplish it).

Well, you cannot blame mypy for doing its job. It enforces a strong type guarantee whenever type hints are present. That's its job. If your code is incorrect from this perspective you can either not use mypy (we could run it selectively on just a subset of files), you could change your code to provide a strong type guarantee or you can find a multitude of workarounds in between.
assert isinstance(owned_node, Node) is just a silence mypy error. It delegates the type check back to runtime. If this line does not catch the error then the illegal access in the following lines will. Apart from a different runtime error message we have not gained anything.
In my opinion the correct solution would be to make the code strongly typed (assuming we want it to be like that). If the current class hierarchy is to be preserved, it means making children a generic container
https://docs.python.org/3/library/typing.html#generics
and providing the correct type at inheritance level.
Composite(SemanticParent[Node])
Of course, this introduces more complexity and burden for those not familiar with strongly typed languages.

Another remark about unnotated stuff:
def foo(a: int, b) -> int:
    return a+b

Is correct. If no type is specified, no check will happen. If you use the result of foo type checking will continue since the return type is known.

In other places, e.g. in Composite(SemanticParent).children where we narrow the scope in SemanticParent.children from Sematic to Node(Semantic), it seems to me like we probably need to have a bunch of extra boiler plate like
@property
def Composite.children(self) -> bidict[str, Node]:
    return super().children

This is wrong and not an option. Consider the following:
class A(Semantic): #<- this is not a Node
    pass

def add(container: SemanticParent):
    a = A(...)
    container.children.append(a) #<- valid according to type definitions

foo: Composite = ...
add(foo) #<- incorrect, due to redefition of children

The redefinition of Composite.children is incompatible with Composite being derived from SemanticParent!

This is a good benchmark. If the typical developer immediately sees the problem pointed out we can enforce strong typing. If not, and the typical developer thinks this is rather strange and complicated, we should not do it.

Another remark about unnotated stuff:
def foo(a: int, b) -> int:
    return a+b

Is correct. If no type is specified, no check will happen. If you use the result of foo type checking will continue since the return type is known.

Yes, this is exactly how the runtime checking works too -- if one side of a connection has no type hint at all, the type checking is simply skipped.


Fix flaky test issue

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes Flaky test: Queue controller Should update status when workloads are created.
Uses util.ExpectResourceFlavorToBeDeleted to make sure that ResourceFlavors were deleted completely.
Put the deletion of ClusterQueue before the deletion of ResoueceFlavors to avoid the ResoueceFlavors deletion failure.
Which issue(s) this PR fixes:

Fixes #1015
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/ok-to-test

Track link: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1018/pull-kueue-test-e2e-main-1-26/1684507556703113216

/retest

/test pull-kueue-test-e2e-main-1-26

Seems another flaky test, you can take time to fix it if you like @BinL233 anyway, this pr looks good to me.

Seems another flaky test, you can take time to fix it if you like @BinL233 anyway, this pr looks good to me.

Sure. I will check it these days.

/cherry-pick release-0.4


WIP: Add TParameter class

Add ability to read TParameters without resorting to peaking at private members.

Before accepting this, we'll have to add logic to hasmethods that equates "TParameter" with "TParameter_3c_.*_3e_". We'd want a class name without template specialization to count as the same class name with any template specialization (_3c_ is mangled < and _3e_ is mangled >; anything not [A-Za-z0-9] are hex-ascii between underscores).
It would go here:
https://github.com/scikit-hep/uproot-methods/blob/2e2089748d4ece2a573cd6fa8cb84782ebb8cb15/uproot_methods/classes/__init__.py#L5-L12
and the verification that this is working would be that Uproot picks up your code, producing TParameter objects that are subclasses of your TParameter.Methods. Right now, it shouldn't be because the class name isn't exactly equal to your new module name. We can make this change entirely in uproot-methods. (That was the design; to decouple uproot-methods versioning from uproot versioning.)
You could do that or wait for me to cycle around to it.

Done. This now reads my test file correctly.

I was writing a detailed solution to a problem that I expected when you said

Done. This now reads my test file correctly.

I don't know how it works in your case because of the problem below. Can you elaborate on your test?

Ah, crud: it won't work without a change in Uproot. Uproot checks hasmethods to see if the methods exist, but doesn't take the shortened name when it wants to load it:
https://github.com/scikit-hep/uproot/blob/773b6ef0eb96c03b355897b5e92aee4b9a98c37a/uproot/rootio.py#L925-L926
Uproot will still be trying to inherit from uproot_methods.classes.TParameter_3c_double_3e_.Methods, which doesn't exist. To do this "right," we'd have to change Uproot to say to uproot-methods, "I have a "TParameter_3c_double_3e_", what is the most specialized class you have for it?" and uproot-methods would respond, ""TParameter"".
The problem with that is that we'd have to update both uproot-methods and Uproot together, which means coordinating new minor version numbers with synchronized updates to both and setting the pip dependencies with the right restrictions. That happens in several places only because there's documentation that has to agree.
Alternatively, we could do it in a slightly "hacky" way, but one that I'm okay with if you are. In the elif clause that you just introduced, if bare_name in hasmethods.loaders, then we know that there isn't an exact match but there is a bare name match. At this point, we could create a new module and assign it in the right place so that Uproot finds it (Uproot always asks hasmethods before attempting to inherit from a mixin):
# name is "TParameter_3c_double_3e_" in this case
setattr(uproot_methods.classes, name, types.ModuleType(name))
getattr(uproot_methods.classes, name).Methods = getattr(uproot_methods.classes, bare_name).Methods
if hasattr(getattr(uproot_methods.classes, name), "ArrayMethods"):
    getattr(uproot_methods.classes, name).ArrayMethods = getattr(uproot_methods.classes, bare_name).ArrayMethods

When you get one of your TParameter objects as tparam, can you paste here the result of
print(tparam._pycode)

so that we can see the class definition it generated? I'm particularly interested in what its superclasses are. I expected its superclass to be uproot_methods.classes.TParameter_3c_double_3e.Methods, which doesn't exist, but if it's working for you, it must somehow be uproot_methods.classes.TParameter.Methods, which does exist. I don't know how it would get the latter because
https://github.com/scikit-hep/uproot/blob/773b6ef0eb96c03b355897b5e92aee4b9a98c37a/uproot/rootio.py#L925-L926

Ah, beautiful! That effectively does what I was describing a manual procedure to do, but in a better way: it creates a new uproot_methods.classes.TParameters_3c_double_3e_ reference pointing to uproot_methods.classes.TParameters without creating a new module. (It's a new reference to the existing module, which is more lightweight and certain to get all contents than creating a new module and filling it, as I was starting to suggest.)
That's an unexpected consequence of code that was written to delay loading these modules until necessary. (I didn't want Python versions of the whole ROOT ecosystem to be defined whenever Uproot imports; I wanted only the classes used in the ROOT files you have open to be defined.) By setting globals()[name] to the result of load_module(bare_name), it also adds a name for each template specialization defined by your open ROOT files that don't also have specialized Python definitions (because we entered your elif).
So this is, intentionally or unintentionally, a great solution to the problem and I'll merge it. As a final sanity check, can you show me that attempting to
import uproot_methods.classes
import uproot_methods.classes.TParameter_3c_double_3e_

fails before opening your ROOT file and succeeds after opening your ROOT file? You also shouldn't have to extract the TParameter: the assignment should happen when the ROOT file is opened, not when the relevant objects are pulled out of it.

Great! Thanks!


Resolves #161 by fixing the failing tests

Just get the most recent controllers for a user
Fix scope of comparison bills to allow rendering of bill comparison table
Fix test to reflect updated sign up page copy
Make invitation fix pending for future fix

This should also fix #175


Volume below a plane

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Adds a  VolumeBelow(Plane<T> &_plane) function to some of the shapes. This is useful for simulating surface behavior when the vehicle is buoyant. It also introduces a CenterOfVolumeBelow(const Planed &_plane) which is useful for calculating the center of buoyancy. This is to support ignitionrobotics/ign-gazebo#818.
Summary
Currently the following shapes have a VolumeBelow:

Box
Sphere

The sphere calculation is relatively simple formula can be found here.
The box calculation is relatively difficult. However the essence of it is we find out the points at which the plane intersects with the plane itself. We then reconstruct a triangle mesh using the resulting vertices. Subsequently we use the generic triangle mesh volume formula.
TODO:

Cylinders
Cylinder slices are relatively simple to calculate using Cylinder wedges.

Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[x] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

I can do that later in a separate PR after the fortress release.

This is for tracking my own progress:

Function Name
Unit Tested

Box::VolumeBelow
Yes

Box::CenterOfVolumeBelow
No

Box::Intersections
No

Line::Distance
No

Plane::PointOnPlane
Yes

Plane::Intersect
Yes

Plane::Volume
No

Sphere::VolumeBelow
Yes

Sphere::CenterOfVolumeBelow
Yes

Vector3::Project
No

To be honest, for the project this is targeting, the box method is higher priority than the sphere method.

@chapulina Windows is fixed!! I recommend one more glance at 20d66b1. We have a weird issue with std::set and the fact that Vector3<T>::operator< is not actually strictly ordered. I've added a WellOrderedVector function object.
W.r.t VectorProjectionLength while we could wrap it with an optional, I don't actually want to copy it everywhere, cause it is used quite a bit. I do feel that a warning in the documentation should suffice. Afterall, we do not check if there are NaNs when we do basic operations.

We have a weird issue with std::set and the fact that Vector3::operator< is not actually strictly ordered.

Thank you for the workaround, LGTM. The only concern I have is that a detail struct would be part of the public API, but users shouldn't be interacting with it, so I think it's ok.
Ticketed https://github.com/ignitionrobotics/ign-math/issues/244 to keep track of this.

@scpeters I've addressed your feedback and removed the controversial function.


Add wild card support for $InterfaceAlias.

Description
This is re-create PR from https://github.com/PowerShell/xNetworking/pull/56 to be merged to dev branch.
There used to be support Wildcard for InterfaceAlis, but degraded with commit https://github.com/PowerShell/xNetworking/commit/89a9d95b611782a1848f7c9a3a66d550ab0a4afa#diff-da1b602b4060c5ac9213c9b402ca75aaR178
This PR add Wildcard support for InterfaceAlias.
There are many cases that user couldn't know or promise interface alias. Something like it is  "Ethernet" or "Ethernet 2" or "Enternet n..." in Cloud Infrastructure. Thus Wildcard support is useful and should be better supported.
Reproduce Procedure
configuration Hoge
{
    Import-DSCResource -Module xNetworking
    xDNSServerAddress Test
    {
        Address = "<IP_ADDRESS>"
        InterfaceAlias = "Etthernet*"
        AddressFamily = "IPv4"
    }
}

Hoge
Start-DscConfiguration -Verbose -Wait -Path Hoge -Force
Test-DscConfiguration
Get-DscConfiguration

It will fail with previous psm1, but success in this PR as following.
Address        : {<IP_ADDRESS>}
AddressFamily  : IPv4
InterfaceAlias : Ehternet*
PSComputerName :

Hi @guitarrapc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

hmmmm..... Test failure is not relates to this PR change.

I found that in #51 and will get it merged in within the next day or two.
Couple of things.

Could you move the comment above the if statement?

<#
    -Like means support wildcard for InterfaceAlias.
    InterfaceAlias doesn't need to be exact name,
   as uniqueness is proved with Get-DnsClientServerAddress.
#>
 if ( -not (Get-NetAdapter | Where-Object -Property Name -Like $InterfaceAlias ))

Would it be possible for you to write a test in our Unit\xDNSServerAddress file so we don't regress this functionality? Hate to lose it once we've fixed it. :+1:

Hi @guitarrapc , @tysonjhayes has fixed the problem causing the AppVeyor failure so once his PR has gone in this will be resolved (although you'll need to merge the updated Dev branch with your fork).
Now, onto the change:
one thing to consider here is that the InterfaceAlias is changed to support wildcard names, you'd need to change other code as well.
For example, at the moment, Line 165 is:
$currentAddress = (Get-DnsClientServerAddress `
        -InterfaceAlias $InterfaceAlias `
        -AddressFamily $AddressFamily `
        -ErrorAction Stop).ServerAddresses

which at the moment will only ever return a single result. If Wildcards are supported then the code following this would need to be adjusted to manage more than one set of server addresses being returned. E.g. you'd need a Foreach loop wrapping it.
The same goes for the code in Set-TargetResource and Get-TargetResource. The changes are definitely possible though!
So there are a few more changes that you'll need to make on this one.
Thanks for doing this!

Thinking about this, one thing you could do is actually wrap all the code in something like this:
$InterfaceAliases = @(Get-NetAdapter -Name $InterfaceAlias)
foreach ($InterfaceAlias in $interfaceAliases) {
...existing code here...
}

Just a possible solution.

Sorry for late response, I will do it right now.

[ ] Move Comment
[ ] Write Unit Test : Unit\xDNSServerAddress
[ ] Adapt DNSServer change to multiple Adaptor with foreach loop.

Awesome! :+1: Thank you!

I figure out why Unity Test was failed with https://github.com/guitarrapc/xNetworking/commit/fb9ffac876cba5d0d25c3a27789c5bb2a648fbb6.
This is because Get-NetAdapter sat Mock with Name = 'Ethernet'
https://github.com/PowerShell/xNetworking/blob/d43b2f6bda9a7bbb63bd1ff7db40191a22e8c64d/Tests/Unit/MSFT_xDNSServerAddress.Tests.ps1#L328
As of Cmdlet output will be limit to what MockWith has passed, InterfaceAlias detected null in UnitTest. This is no matter on real code, but only issue in MockWith.
I think there are two workaround.

Change InterfaceAlias to Name Property for Get-NetAdapter result.
Because it seems always Name == InterfaceAlias, I choose this.
Comment out UnitTest for Get-NetAdapter using MockWith https://github.com/PowerShell/xNetworking/blob/d43b2f6bda9a7bbb63bd1ff7db40191a22e8c64d/Tests/Unit/MSFT_xDNSServerAddress.Tests.ps1#L328

Which do you prefer, or is there any good idea for it?

All test passed:) I think it works fine and already working in my production.
Please have a kind review, thanks.

Thanks for the PR, I'll be reviewing this a little later, glancing through it it looks pretty good.

The new code looks great! :+1: I can't see any issues.
One request: is it possible to add some tests where the Get-NetAdapter mock returns more than one record (as would occur when a wild card was specified and more than one adapter exists)? For example:
Mock Get-NetAdapter -MockWith { @(
[PSObject]@{ Name = 'Ethernet 1' }
[PSObject]@{ Name = 'Ethernet 2' }
) }

I don't think this isn't critical though. @tysonjhayes - what are your thoughts? Worth adding these tests?

 I also think it should read for multiple interface card with Mock. I will do it.

Todo

[ ] 100 char line limitation :  https://github.com/PowerShell/xNetworking/pull/57#discussion_r46199922
[ ] Standardize the code style for regardless # line.
[ ] Multiple Interface Card Mocking Unit Test : https://github.com/PowerShell/xNetworking/pull/57#issuecomment-160759384

Alright, all todo had been completed without test failure.

Awesome! Thank you so much for working on this. :+1:

Ok for some reason the tests aren't showing the diff which is making it hard to review. @PlagueHO I know you've run into that at some point, what did you do to fix it?

Ah, right. From memory (I couldn't find the PR) I actually closed the PR and actually remade the changes to the tests file and then reissued the PR. That might be difficult here though as my changes were fairly trivial compared to these. There must be a reason for this odd behavior from GitHub. I'll take a dig around today and see if I can find a solution that doesn't involve closing the PR.

May be this? http://stackoverflow.com/questions/9702795/large-github-commit-diff-not-shown

It does look like an issue (or limitation) with GitHub. Although I'm fairly certain your Diff is well within the 100KB limit. Might have to revert to doing a manual Git Diff directly from your repo.

Sorry about the delay here, I've pulled it locally and will be looking a it as I have time. Unfrotunately I've been a bit busy today and haven't had time yet.

OK in regards to the unit tests.
Couple of notes.

Let's remove the ####### lines and replace them with regions.
Can we change all of the "Describe 'Function' {" to "Describe 'MSFT_xDNSServerAddress\Function' {" so we know which one is failing in our stream of tests. h/t @PlagueHO
Given I actually had a problem running the code on my machine but the unit tests are passing would it make since to throw a redumentary integration test along with this so we can validate everything is working as expected?

Unit Tests - as I can't comment on a diff.
Get-TargetResource

        Context 'invoking with an IPv4 address' {
            It 'should return true' {

                $Splat = @{
                    Address = '<IP_ADDRESS>'
                    InterfaceAlias = 'Ethernet'
                    AddressFamily = 'IPv4'
                }
                $Result = Get-TargetResource @Splat
                $Result.IPAddress | Should Be $Splat.IPAddress
            }
        }

This test is passing because IPAddress is null in both cases, I believe this should be:
        Context 'invoking with an IPv4 address' {
            It 'should return true' {

                $Splat = @{
                    Address = '<IP_ADDRESS>'
                    InterfaceAlias = 'Ethernet'
                    AddressFamily = 'IPv4'
                }
                $Result = Get-TargetResource @Splat
                $Result.Address | Should Be $Splat.Address
            }
        }

The same goes for
        Context 'invoking with Wildcard InterfaceAlias and an IPv4 address' {
            It 'should return true' {

                $Splat = @{
                    Address = '<IP_ADDRESS>'
                    InterfaceAlias = 'Ether*'
                    AddressFamily = 'IPv4'
                }
                $Result = Get-TargetResource @Splat
                $Result.IPAddress | Should Be $Splat.IPAddress
            }
        }

In fact you can pretty much do a find/replace for IPAddress and replace it with Address.
Set-TargetResource
Around the following code (Line 346)
Context 'invoking with Wildcard InterfaceAlias && single IPv4 Server Address that is the same as current'

You start calling Get-NetAdapter. From what I can tell in current scoping you haven't mocked Get-NetAdapter so you'd be calling the machines' Get-NetAdapter, however you do Mock it in other tests. Let's add the mock everywhere so we don't call the machines adapters.
Test-TargetResource
Later on (line 1439-1457) we have cases like this:
        Mock Get-NetAdapter -MockWith { [PSObject]@{ Name = 'Ether*' } }
        Mock Get-DnsClientServerAddress -MockWith {

            [PSCustomObject]@{
                ServerAddresses = @('fe80:ab04:30F5:002b::1')
                InterfaceAlias = 'Ether*'
                AddressFamily = 'IPv6'
            }
        }
        #endregion

        Context 'invoking with Wildcard InterfaceAlias && Multiple interface && single IPv6 Server Address that is the same as current' {
            # Mock should capsul inside script block scope
            Mock Get-NetAdapter {
                return @(
                    [PSCustomObject]@{ Name = 'Ethernet 1'; InterfaceAlias = 'Ethernet 1' },
                    [PSCustomObject]@{ Name = 'Ethernet 2'; InterfaceAlias = 'Ethernet 2' }
                )
            }

Correct me if I'm wrong here but I don't think we need to call the first Mock and honestly is kind of confusing anyway.

Please resolve merge conflicts.  For more information see GitHowTo - 30. Resolving Conflicts

If there is no update of the pull request within 7 days, we will close the pull request.  After that, if you have an update, feel free to reopen the pull request or a new pull request.

oh.... Sorry for no response. I will review.

@guitarrapc No problem,
We appreciate the contribution.
We just try to manage the number of PR's we are reviewing.  So we closing them after there are no code updates for 21 days.  I'll give you a little more time, but please update, or close this and re-open when you are ready for it to be reviewed.
Thanks, Travis

OK, I'm in busy for moment, let's close for a while and open again. Thanks.


Hide the filter bar when no filters are added

Hi, thank you for the amazing library!
I have a small white gap on top of the table when I don't pass any filters to the table, is it possible to remove it when I don't want my table to be filterable?
Thank you!

This is an issue. Will be solved in the next release. Thank you for reporting that!


error: manifest parse error(s): The manifest file at https://github.com/IBM-Swift/CommonCrypto.git (0.1.3) is empty

I cleaned up the last build. the following is my package.swift
let package = Package(
name: "openActivity",
dependencies: [
.package(url: "https://github.com/IBM-Swift/Kitura.git", .upToNextMinor(from: "2.0.0")),
.package(url: "https://github.com/IBM-Swift/HeliumLogger.git", .upToNextMajor(from: "1.0.0")),
.package(url: "https://github.com/IBM-Swift/BlueCryptor.git", .upToNextMajor(from: "0.8.0")),
.package(url: "https://github.com/IBM-Swift/Kitura-Session.git", .upToNextMinor(from: "2.0.0")),
.package(url: "https://github.com/IBM-Swift/Swift-Kuery.git", .upToNextMajor(from: "1.0.0")),
.package(url: "https://github.com/IBM-Swift/SwiftKueryMySQL.git", .upToNextMajor(from: "1.0.0")),
],
targets: [
.target(
name: "openActivity",
dependencies: ["Kitura", "KituraSession", "HeliumLogger", "Cryptor", "SwiftKuery", "SwiftKueryMySQL" ]),
]
)
but I still get the same error:
error: manifest parse error(s): The manifest file at https://github.com/IBM-Swift/CommonCrypto.git (0.1.3) is empty

Try switching from
.package(url: "https://github.com/IBM-Swift/BlueCryptor.git", .upToNextMajor(from: "0.8.0")),

to this
.package(url: "https://github.com/IBM-Swift/BlueCryptor.git", .upToNextMinor(from: "0.8.0")),

That's what Kitura-Session is using and its having no problems...  Re-open if this doesn't work for you.  Thanks.


Fix to the "Search with Query Task" select element issue

Just needed to set up the event listener before it was used by the API. Now it works fine.

thx @banuelosj! can you push up one more commit to sync the same change in the lab.md?

Just pushed the commit with the updated lab.md!

🙌


Bugfix Notify component / Use voluptuous for file

Description:

Bugfix notify they want check PLATFORM_SCHEMA
Use notify file to voluptuous

:dolphin:

I have a new commit for that with new file types


Reduce dependency on tendermint version detection

Auto-detecting Tendermint versions is a nice idea in general, but is not that important anymore. We know the Tendermint version for each Cosmos SDK version.
This is an attempt to work around https://github.com/cosmos/cosmos-sdk/issues/7963 by not having to rely on the value in the version field in cases where we know what version the backend has.

Okay, two more commits addressing the comments


Update DigitalOcean Cloud Controller Manager to v0.1.21

What this PR does / why we need it:
Update the DigitalOcean Cloud Controller Manager to v0.1.21.
Does this PR introduce a user-facing change?:
Update the DigitalOcean Cloud Controller Manager to v0.1.21.

/assign @kron4eg

/retest

/retest

/retest

/retest

/retest


How do you install this?

I'm not extremely new to Laravel (read: I just finish Jeffrey's 100-episode forum series) but I have no idea how to install this. Maybe I'm missing something but I don't see installation instructions...

Sorry if this isn't the right place.

I was holding off in case I could come up with a cooler name 😄

Maybe like nothingworks/breakwind-preset 😛
Can the php artisan preset nothingworks be added to the "scripts" composer block?

I'm getting this error:
[InvalidArgumentException]
Could not find a version of package adamwathan/laravel-preset matching your minimum-stability (stable).
Require it with an explicit version constraint allowing its desired stability

{
    "name": "adamwathan/laravel-preset",
    "description": "Adam Wathan's Laravel Frontend Preset",
    "keywords": ["laravel", "preset"],
    "license": "MIT",
    "require": {
        "laravel/framework": "^5.7"
    },
    "repositories": [
	    {
	        "type": "vcs",
	        "url": "https://github.com/adamwathan/laravel-preset"
	    }
	],
    "autoload": {
        "psr-4": {
            "NothingWorks\\LaravelPreset\\": "src/"
        }
    },
    "extra": {
        "laravel": {
            "providers": [
                "NothingWorks\\LaravelPreset\\PresetServiceProvider"
            ]
        }
    }
}

Composer version 1.8.6 2019-06-11 15:03:05


UninstallDisplayIcon bug fixing

UninstallDisplayIcon bug fixing

Thanks for fixing this. May I ask you kindly to re-issue this PR against the develop branch? I like to follow this Git branching model. I'll add a clarifying note about this to the README.


Example for Big Message please

Example for Big Message please

It's on the wiki
BigMessageThread.MessageInstance.ShowMissionPassedMessage("yo");

i tried this:
ShowSimpleShard(string title, string subtitle, int time = 5000)

but its not working.

Do other ones work? Is there anything in the logs?

i not tested yet, btw #OFFTOPIC how did to show a message (like in community races) after the game properly loaded? because I got an error if i put the code in:
Public Sub New()

Error: something.something..ctor()
like spawn vehicles and/or objects, but no problem while reload scripts

@Guad seeee

@qiangqiang101 What exactly are you trying to accomplish with that? You don't give us much information and your Error is useless - please post the full error message and a better explanation on what you're trying to accomplish and i might be able to help you :-)

@frodzet what i mean is to spawn ped or object or vehicle on Public sub New() will cause an error, i think its because the game is not properly loaded
but if press insert key to reload the scripts, will not have problem like that.

@qiangqiang101 Did you try putting in a while loop that will wait for the game to fully load before spawning the objects?

@frodzet how can i do that?

        // Create a campfire model
        var model = new Model("prop_beach_fire");
        model.Request(250);

        // Check the model is valid
        if (model.IsInCdImage && model.IsValid)
        {
            // Ensure the model is loaded before we try to create it in the world
            while (!model.IsLoaded) Script.Wait(50);

            // Create the prop in the world
            World.CreateProp(model, Game.Player.Character.GetOffsetInWorldCoords(new Vector3(0, 5, 0)), true, true);
        }

        // Mark the model as no longer needed to remove it from memory.
        model.MarkAsNoLongerNeeded();

This is from the ScriptHookVDotNet How To's section, as you can see there is a while(!model.IsLoaded) Script.Wait(50); This basically forces the script to wait processing any further until that specific model is available for usage and once it is it spawns the prop in this case. You can do it with vehicles, peds, etc aswell.

@frodzet OWH, that the problem...
I always use
Dim campfire as Prop = World.CreateProp("hashes", Vector3, True, True)

The problem is you can't call Script.Yield or Script. Wait while the game is loading. You can load them in the tick event as it starts after the player has spawned.

@Guad You can't? So how would he approach what he is trying to accomplish? :-)

private bool _hasLoaded;
void OnTick(object sender, EventArgs e)
{
    if (!_hasLoaded)
    {
        World.CreateProp(...);
        _hasLoaded = true;
    }
}

thank you very much @Guad  @frodzet


MSMExplorer 0.3.0

Not sure why OSX builds but Linux doesn't.

Retriggered builds.
We had a spate of those PyQT4 errors before. I'm not sure exactly which upstream dependency was the cause.

Seems to happen consistently (I had retriggered before). The error is coming from matplotlib but it built perfectly fine in the MSMExplorer Travis tests, which uses the same version of matplotlib and pyqt.

Merging. Hopefully this won't cause issues!

Looks like it worked on master! Weird!

Did it really build all the versions? I think there are some missing versions:
===== testing package: msmexplorer-0.3.0-py35_0 =====
import: 'msmexplorer'
Traceback (most recent call last):
  File "/anaconda/conda-bld/msmexplorer_1477676714197/test_tmp/run_test.py", line 27, in <module>
    import msmexplorer
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/msmexplorer/__init__.py", line 1, in <module>
    from .plots import *
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/msmexplorer/plots/__init__.py", line 1, in <module>
    import seaborn
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/seaborn/__init__.py", line 6, in <module>
    from .rcmod import *
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/seaborn/rcmod.py", line 8, in <module>
    from . import palettes, _orig_rc_params
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/seaborn/palettes.py", line 12, in <module>
    from .utils import desaturate, set_hls_values, get_color_cycle
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/seaborn/utils.py", line 12, in <module>
    import matplotlib.pyplot as plt
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/matplotlib/pyplot.py", line 114, in <module>
    _backend_mod, new_figure_manager, draw_if_interactive, _show = pylab_setup()
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/matplotlib/backends/__init__.py", line 32, in pylab_setup
    globals(),locals(),[backend_name],0)
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/matplotlib/backends/backend_qt5agg.py", line 16, in <module>
    from .backend_qt5 import QtCore
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/matplotlib/backends/backend_qt5.py", line 31, in <module>
    from .qt_compat import QtCore, QtGui, QtWidgets, _getSaveFileName, __version__
  File "/anaconda/conda-bld/msmexplorer_1477676714197/_t_env/lib/python3.5/site-packages/matplotlib/backends/qt_compat.py", line 137, in <module>
    from PyQt4 import QtCore, QtGui
ImportError: No module named 'PyQt4'
TESTS FAILED: msmexplorer-0.3.0-py35_0
ERROR: File does not exist: /anaconda/conda-bld/linux-64/msmexplorer-0.3.0-py35_0.tar.bz2
[conda-build-all] Error: one or more packages failed to build (linux-64)
  msmexplorer-0.3.0-py34_0.tar.bz2
  msmexplorer-0.3.0-py35_0.tar.bz2


[Color Picker - Editor]: Screen Reader is not announcing 'Copied to Clipboard' message which appear on Screen when user activate 'Copy to clipboard' button.

Microsoft PowerToys version
"0.44.1"
Running as admin

[ ] Yes

Area(s) with issue?
ColorPicker
Steps to reproduce
Test Environment:
OS: Windows 10 Version Dev
App version: 0.41.1
App name: PowerToys
Screen Reader: Narrator
Tool: Accessibility Insight for Windows
Repro Steps:

Launch 'PowerToys' application.
Turn on the narrator.
Navigate to 'Color Picker' tab.
Then Open 'Color Picker' using defined Shortcut key.
Pick any color.
Inside Color Picker Editor, Navigate to 'Copy to Clipboard' button.
Then activate and Observe the issue.

User Impact: -> Priority 1
Screen Reader user are impacted here as they are not informed about the message which appear on screen.
WCAG Reference:
https://www.w3.org/TR/WCAG21/#status-messages
Observation: Same issue repro with NVDA Screen Reader.
Attachment:
Screen Reader is not announcing 'Copied to Clipboard' message which appear on Screen when user activate 'Copy to clipboard' button..zip
✔ Expected Behavior
Screen Reader should announce 'Copied to Clipboard' message which appear on Screen when user activate 'Copy to clipboard' button.
❌ Actual Behavior
Screen Reader is not announcing 'Copied to Clipboard' message which appear on Screen when user activate 'Copy to clipboard' button. Screen Reader remain silent when message appear on screen.
Other Software
No response

Resolved with the release of v0.45.


android build target does not take into account -D__ANDROID_API__

Build rules for android are changed recently :"
Configurations/*.conf: overhaul Android targets.
Move Android targets to separate file, automate sysroot setup and
add support for NDK 16.

Reviewed-by: Rich Salz<EMAIL_ADDRESS>(Merged from https://github.com/openssl/openssl/pull/5589)"

The issue is that updated configuration script is not able to parse properly existence of preprocesor flag -D__ANDROID_API__=...
If CROSS_SYSROOT is defined system default for API version 14
If is not defined :
...
Config target attributes:
...
cppflags => "-D__ANDROID_API__=28 -isystem ...
...
cxxflags => "-std=c++11 -pthread -Wa,--noexecstack -mandroid --sysroot=$(ANDROID_NDK)/platforms/android-28/arch-arm",
...
Recorded environment:
CPPFLAGS =  -D__ANDROID_API__=15
...
Makevars:
CPPFLAGS        =  -D__ANDROID_API__=15
...
Issue is not about the fact that build system is able to parse valid preprocessor flag like D__ANDROID_API__=ANDROID_API_J.
It is about definition with numeric argument.
Tested with NDK r17-beta1.

change title - added missing "not"

I'm adding a note (in #5613) that setting CROSS_SYSROOT and passing -D__ANDROID_API__ are incompatible and unsupported. Since the API level does appear in CROSS_SYSROOT value, it would be likely inappropriate to try to override it.

I guess the issue here is that passing -D__ANDROID_API__=XX to ./Configure works but not if the macro is specified in $CPPFLAGS (I didn't test myself). Supporting both usages would be a nice feature.

You can pass cpp flags via $CPPFLAGS, but only if you don't pass any compiler / linker flags on the configuration command line. The following doesn't work (CPPFLAGS is ignored):
CPPFLAGS=-DFOO ./config -lextra

This works:
CPPFLAGS=-DFOO LDLIBS=-lextra ./config

This is addressed in #5613. It was some misunderstanding, sorry about that. Closing.