restore SDPA in gpt neo after 4.45

What does this PR do?
bettertransformers is not compatible with gpt-neo starting 4.45, but transformers only provide eager and flash_attn attention implementations, this PR adds sdpa for gpt_neo

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

I am ok with the changes but I am thinking that next time we can just drop the support of this model as it is the legacy one.

failed tests are not related to changes, it is issue with nonbackward compatible changes in openvino (should be passed in next nightly)

diffusers tests fixes are covered by https://github.com/huggingface/optimum-intel/pull/1094

Merging as a hotfix


Use latest rocket hash

Use latest rocket hash, removing old rocket hash from routing spec template.
Could you please review @brynary ?

Thanks!
Are you up to do the same with the rest of templates?

I do not check yet, let me check.


[FEATURE] - New metadata modules

⚠ Call to Open Source comunity!
This is a call to the community to get help implementing modules for multiple file formats.
As we describe here:

Creating a Plugin for Goca

It's a step by step guide on how to create new plugins.
Missing plugins:

[x] Adobe Encapsulated PostScript (.eps)
[x] Adobe Flash (.swf)
[x] Adobe Illustrator (.ai)
[x] Adobe Photoshop (.psd)
[x] Adobe Portable Document Format (.pdf)
[x] Adobe PostScript (.ps)
[ ] Autodesk Design Web Format (.dwf)
[x] DS_Store (.DS_Store)
[ ] Google Earth (.kml, .kmz)
[x] GPS eXchange Format (.gpx)
[ ] Hancom Hanword (.hwp)
[x] Image files (.jpeg, .png, .gif, .webp)
[x] Microsoft Excel 2007+(.xlsx)
[ ] Microsoft Excel 2003 (.xls)
[x] Microsoft PowerPoint 2007+(.pptx)
[ ] Microsoft PowerPoint 2003 (.ppt)
[x] Microsoft Word 2007+(.docx)
[ ] Microsoft Word 2003 (.doc)
[x] MP3 (.mp3)
[x] MP4 (.mp4)
[x] OpenOffice presentation (.odp)
[x] OpenOffice spreadsheet (.ods)
[x] OpenOffice text (.odt)
[ ] Rich Text Format (.rtf)
[ ] Scalable Vector Graphics (.svg)
[ ] TeX/LaTeX (.tex)

Pull requests are welcome!

Work in progress on KML parser 😄

We still need to work on this plugins for future releases.

Let's open an issue for each plugin and assign it to a milestone.


feat: Add typography components

Codecov Report

Merging #212 (a87807f) into main (656188b) will increase coverage by 0.71%.
The diff coverage is 86.55%.

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   82.70%   83.42%   +0.71%
==========================================
  Files          65       71       +6
  Lines         659      760     +101
  Branches      113      140      +27
==========================================
+ Hits          545      634      +89
- Misses        107      117      +10
- Partials        7        9       +2

Impacted Files
Coverage Δ

components/app/EventMarker/EventMarker.tsx
91.42% <ø> (ø)

components/ui/Modal/Window.tsx
100.00% <ø> (ø)

components/app/ActiveLivers/ActiveLivers.tsx
73.91% <66.66%> (+2.48%)
:arrow_up:

components/ui/Typography/Typography.tsx
77.77% <77.77%> (ø)

components/app/Imprint/Imprint.tsx
100.00% <100.00%> (ø)

components/app/Imprint/index.ts
100.00% <100.00%> (ø)

components/app/Navigation/Navigation.tsx
100.00% <100.00%> (ø)

components/app/Tutorial/Tutorial.tsx
96.87% <100.00%> (+0.20%)
:arrow_up:

components/ui/Button/Button.stories.tsx
100.00% <100.00%> (ø)

components/ui/Button/Button.tsx
100.00% <100.00%> (+6.25%)
:arrow_up:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656188b...a87807f. Read the comment docs.


Some K8S resources do not get deleted after 'helm delete'.

Hello,
I would like to report an issue (I believe). After trying to delete the deployed helm chart, I can see that there are job pods remained. Here is an example of kubectl get po after helm delete --purge stackstorm on Helm 2 or helm delete stackstorm on Helm 3:
❯ kubectl get po
NAME                                                              READY   STATUS                       RESTARTS   AGE
stackstorm-job-st2-apikey-load-j8rkv                              0/1     Completed                    0          6d21h
stackstorm-job-st2-key-load-wbdxp                                 0/1     Completed                    0          6d21h
stackstorm-job-st2-register-content-l6rmh                         0/1     Completed                    0          6d21h

Not only these pods, but also the jobs remain as well. on kubectl get jobs, I can see:
❯ kubectl get job
NAME                                   COMPLETIONS   DURATION   AGE
stackstorm-job-st2-apikey-load         1/1           45s        6d21h
stackstorm-job-st2-key-load            1/1           9s         6d21h
stackstorm-job-st2-register-content    1/1           25s        6d21h

There are also PV,PVC objects remained but I believe that is desired?
Thanks!
Edit: I believe that the reason is related to this. I think both jobs and pods should be deleted on helm delete and also, at least, pods of jobs should be deleted after they have been successful.

Yes, that's caused by the fact that hooks are not managed by Helm and there is no garbage collector for them yet: https://helm.sh/docs/topics/charts_hooks/#hook-resources-are-not-managed-with-corresponding-releases
The only workaround is adding "helm.sh/hook-delete-policy": hook-succeeded annotation, https://helm.sh/docs/topics/charts_hooks/#hook-deletion-policies which is not desired. We want to keep the job for the informational reasons so the user could grab the logs and know which content was registered via jobs, otherwise this Helm magic would remain unnoticed. Sadly, Helm doesn't delete them once the release was removed.
It's actually a good topic to discuss and I'm inviting others to provide their feedback.
Depending on results it might be a good idea to change the behavior until Chart reaches stable state.

Alternative is using ttlSecondsAfterFinished (https://kubernetes.io/docs/concepts/workloads/controllers/jobs-run-to-completion/#clean-up-finished-jobs-automatically) and TTLController https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/ to clean-up the job automatically after some reasonable delay.
However this feature looks like still in alpha state.

Alternative per Helm doc advice is trying ttlSecondsAfterFinished (https://kubernetes.io/docs/concepts/workloads/controllers/jobs-run-to-completion/#clean-up-finished-jobs-automatically) and TTLController https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/ to clean-up the job automatically after some reasonable delay.
However this feature looks like still in alpha state.

It looks like this hit beta state in k8s v1.21 - so it's probably safe to start adding something like this.
I'm guessing the ttl would need to be defined in values.yaml (perhaps in jobs.ttlSecondsAfterFinished), probably with a large default like 604800 (1 week).

Quick follow-up if anyone wants to work on this. The TTL-after-finished Controller feature hit stable in k8s v1.23.
NOTE: This feature will only clean up the old jobs. The only other hook we have is used for running tests though (a Pod), so it is unlikely to be (and probably should not be) in any production clusters. That test Pod is only deleted automatically if it succeeds - if there's a failure, it has to be cleaned up manually (or just use a disposable cluster for testing).

k8s 1.22 was EOL on 2022-10-28, so we can safely use ttlSecondsAfterFinished now. A PR to implement this would be welcome!


Get-PNPSiteCollectionAppcatalogs slower in 1.11.0 and later

Reporting an Issue or Missing Feature
I recently noticed that calling the Get-PNPSiteCollectionAppcatalogs command used to take a few seconds and now seems to run forever. I tracked it down to it working fine in 1.10.0. In 1.11.0, it errors out. This was the same time you introduced Get-PNPSiteCollectionAppcatalog (singular) and started throwing a warning to stop using Get-PNPSiteCollectionAppcatalogs. I am assuming it is related to this. In 1.12.0, the error with it crashing seems to be fixed, but now it does not run quickly anymore. The results are the same whether you use Get-PNPSiteCollectionAppcatalog or Get-PNPSiteCollectionAppcatalogs
Expected behavior
Get-PNPSiteCollectionAppcatalog should return all sites with an app catalog in a reasonable amount of time.
Actual behavior
Works fine in 1.10.0. Crashes in 1.11.0. Takes forever in 1.12.0 and later. See screenshot

Steps to reproduce behavior
Load PnP module 1.12.0 or later. Connect to tenant. Run Get-PNPSiteCollectionAppcatalog.  Our tenant is very large with 108,457 sites and 4,554 sites have app catalog. Not sure if you will be able to repro this is a small environment.
What is the version of the Cmdlet module you are running?
Works fine in 1.10.0. Crashes in 1.11.0. Takes forever in 1.12.0 and later.
Which operating system/environment are you running PnP PowerShell on?

[ ] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[x] Azure Functions
[ ] Other : please specify

Thanks for reporting this @Ambergahill . I did some digging into this scenario. I can trace the reason for what you are experiencing back to June 29, 2022, this commit specifically. We had an issue reported to us that this cmdlet would return the old URLs if the URL had been changed. To fix that, what we're doing now, is for every result, we are actively checking one by one if the URL that is passed back is still the actual one or if it has been renamed.
What I could do is add an optional new flag to the cmdlet to bypass this extra validation check which we've added last year. With that though, it would happen again that it returns URLs that have been renamed and no longer exist, but it would be back at the speeds you have experienced before. Would that help you out?

Yes, that would be great. Thank you!
From: Koen Zomers @.>
Sent: Friday, April 14, 2023 9:36 AM
To: pnp/powershell @.>
Cc: Ambergahill @.>; Mention @.>
Subject: Re: [pnp/powershell] Get-PNPSiteCollectionAppcatalogs Broken in 1.11.0 and later (Issue #2986)
Thanks for reporting this @Ambergahillhttps://github.com/Ambergahill . I did some digging into this scenario. I can trace the reason for what you are experiencing back to June 29, 2022, this commithttps://github.com/pnp/powershell/commit/9e6f99117d7ae23c4f8613247e47e214968120fd#diff-8b81d2f40d6ca9db2404bf4a869eee1e08fd4aa452dfb6f13506937fe930b9fb specifically. We had an issuehttps://github.com/pnp/powershell/issues/2041 reported to us that this cmdlet would return the old URLs if the URL had been changed. To fix that, what we're doing now, is for every result, we are actively checking one by one if the URL that is passed back is still the actual one or if it has been renamed.
What I could do is add an optional new flag to the cmdlet to bypass this extra validation check which we've added last year. With that though, it would happen again that it returns URLs that have been renamed and no longer exist, but it would be back at the speeds you have experienced before. Would that help you out?
—
Reply to this email directly, view it on GitHubhttps://github.com/pnp/powershell/issues/2986#issuecomment-1508515492, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWBIXFKMKW6KLWE566CB5GLXBFHDHANCNFSM6AAAAAAWVR6GKM.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

The option will be added through PR https://github.com/pnp/powershell/pull/3025


Fix plugin name

This code is wrong:
postcss.plugin('flexbox',

You should use same name as in npm:
postcss.plugin('postcss-flexbox',

BTW, you should use postcss-plugin-boilerplate to avoid this small mistakes.

Thanks. I just saw the plugin boiler plate. Fixed the plugin name


one click Copy

It is suggested to add a function, one click Copy. We can copy the preview bibliography when we click a button or the preview.

for my reference: https://groups.google.com/g/zotero-dev/c/ZSF3yRYUQeI/m/4UsJN3s-BQAJ

Done


Avoid retaking all screenshots on publish unless strictly necessary

Deploy will take half an hour because it's going to need to rebuild all 450 screenshots due to an (invisible) change to the entry HTML.

Originally posted by @simonw in https://github.com/simonw/til/issues/81#issuecomment-1685012429

Changes to the content of a TIL should generate a new screenshot of that TIL.
But, right now, even the tiniest tweak to the base or entry templates (including changes that wouldn't visibly affect the shots at all) triggers a 450+ screenshot generation process.

Easiest fix: instead of incorporating the hash of the HTML templates themselves, switch to a SCREENSHOT_VERSION constant. I can then manually change that any time I want to trigger a full re-render.

I could set the first version of that to the current hash, to avoid recalculating all 450 existing shots when I deploy this change.

https://github.com/simonw/til/blob/b8ab160caf7201b4f4738c1eba4c15d3fcafd97c/generate_screenshots.py#L57-L60
Since those hashes are added in sequence, the constant wild need to be a list in order to capture the current state.

If I got this right, the deploy should not recreate any screenshots.

Yes that worked:


cups-browsed.c: Fix several memory leaks

Hi,
we got an issue in Fedora - cups-browsed accumulates memory when it is run for long time (up to 1.3GB after a day of running).
This memory report was collected by attaching to the process by gdb and leak check was run.
The log showed several CUPS arrays weren't freed at all (or its pointer was rewritten by another allocation in next loop iteration), several non-freed char arrays and non-freed ipp_t structures.
The pull request was tested by reporter and he didn't report any significant leakage after a day.
Would you mind adding the pull request to the project?
Thank you in advance,
Zdenek

Thanks for merging it, Till!

Could you fix these warnings in a new Pull Request. Thanks.
  CC       utils/cups_browsed-cups-browsed.o
utils/cups-browsed.c: In function ‘generate_cluster_conflicts’:
utils/cups-browsed.c:2798:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
 2798 |       if (i == 0)
      |       ^~
utils/cups-browsed.c:2837:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
 2837 |  cupsArrayDelete(printer_first_options);
      |  ^~~~~~~~~~~~~~~
utils/cups-browsed.c: In function ‘get_printer_uuid’:
utils/cups-browsed.c:3787:10: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 3787 |     uuid = ippGetString(attr, 0, NULL) + 9;
      |          ^
utils/cups-browsed.c: In function ‘update_cups_queues’:
utils/cups-browsed.c:8521:4: warning: ‘default_pagesize’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 8521 |    free(default_pagesize);
      |    ^~~~~~~~~~~~~~~~~~~~~~
utils/cups-browsed.c:8523:4: warning: ‘make_model’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 8523 |    free(make_model);
      |    ^~~~~~~~~~~~~~~~
  CCLD     cups-browsed

Sorry about that, I'll create a fix today.


Provide properties "insecure" + "clearDataAtBootstrapTime" so that it's unncessary to use a custom compiler

Done.
        if (!context.isProduction() && clearAllCollectionsBeforeMocking) {
            log.info("Start clearing collections...");
            clearAllCollections();
            log.info("All collections are cleared");
        }

Done.
        if (!context.isProduction() && clearAllCollectionsBeforeMocking) {
            log.info("Start clearing collections...");
            clearAllCollections();
            log.info("All collections are cleared");
        }


fix: need both uids to match

UID was still too big and the jailer was not selecting the correct UID, so runs were failing.

bors try

bors r+


My deposit is not there my BTC address also just changed

My BTC address was 3KJz2wwHVjTPcTFSTsWrY6muqPBMqtfS7V  I sent money to this address before you guys froze the exchange
than just now it switched to 3LpHJJRC3WEv3GXS9JtqbDLtb7Pxj2UfED
My money didn't come through and now I have a different address.
Please address and let me know what I should do.
Don't know why I have a different address now and where my money is now.

3KJz2wwHVjTPcTFSTsWrY6muqPBMqtfS7V
71254a748983a585cede902e71d4940c10595d0f8e4ca175e41b3559a8ce3a0b
That is my deposit address which was changed when you fixed deposits and also the transaction Id of the money I sent over a hour and half ago. It already is confirmed. Please credit my account.
My new wallet which was changed is 3LpHJJRC3WEv3GXS9JtqbDLtb7Pxj2UfED

@2themoonandback should be resolved

Thank you very much.


[SPARK-48714][SPARK-48794][FOLLOW-UP][PYTHON][DOCS] Add mergeInto to API reference

What changes were proposed in this pull request?
Add mergeInto to API reference
Why are the changes needed?
this feature was missing in doc
Does this PR introduce any user-facing change?
yes, doc change
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No

Merged to master.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/1093 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 826835f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_main_2022-05-25-12-06-06 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Disable adding Deposit Transactions to Txpool

Specification
According to the execution engine spec:

Deposited transactions MUST never be consumed from the transaction pool. The transaction pool can be disabled in a deposits-only rollup

Therefore we must ignore deposit transactions when

exec engine received local deposit transactions when eth_sendRawTransaction RPC is called
exec engine received remote deposit transactions using p2p tx pool gossiping.

Implementation
We can safely drop deposit transactions from above cases by patching validateTx method. If method receives deposit transactions, make it throw TxTypeNotSupported error. validateTx method is wrapped by validateTxs method.
There are three control flows which results in calling validateTx method before actually promoting transactions. Here, the word promote means adding transaction to actual queue of txpool(TxPool.queued SubPool).

Local TX: pool.go::AddLocalTxs() method handles local transactions received by RPC. It first calls validateTxs method to sanitize transactions and call pool.go::addTxs() to promote transactions.
Remote Tx: pool.go::processRemoteTxs() method handles remote transactions gossiped by p2p. It first calls validateTx method to sanitize transactions and call pool.go::addTxs() to promote transactions.
OnNewBlock: pool.go::OnNewBlock() method updates TxPool when new block is added. If new block is added, it must update TxPool by removing already mined transactions. If reorg occurred and unwind needed, reinsert transactions included at reorg blocks to the TxPool. It first calls validateTxs method to sanitize transactions and call pool.go::addTxsOnNewBlock() to promote transactions.

By patching validateTx method, we can explicitly drop deposit transactions in every case, never making deposit transactions enter a TxPool.
The error message "transaction type not supported" is consistent with op-geth's ErrTxTypeNotSupported error message. Also, error message declaration of ErrTxTypeNotSupported was already defined at erigon. This duplication is intended because erigon intentionally separated txpool implementation, at different repository erigon-lib.
After this PR is merged, will update op-erigon to apply erigon-lib changes.

Decided to test by resyncing from genesis because this may affect state transition logic. After that, will merge and roll.


create_api_docs.dart: correct command logging

The tool currently prints that the dart command is run, and does not include the 'pub' sub-command. Something like:
/private/var/folders/72/ltck4q353hsg3bn8kpkg7f84005w15/T/flutterzXpww6/bin/dart \
    global run --enable-asserts dartdoc

(newline mine)
But this is incorrect; the runPubGet function runs the flutter command, and prepends pub to the list of arguments.

Looks like the analyzer warning is legit. getDartBinaryPath isn't used anymore and can be removed, I suspect.


Allow drop of PDF page to create @PDF link

Intercept a drop of a JournalEntryPage that contains a PDF to create a @PDF link instead of the usual @UUID link

Man I'd really love it if you would use backticks around @pdf instead of pinging me constantly in this repo....

I'll try and remember that :)

Possibly intercepting TextEditor::_onDropEditorData
Or TextEditor::getContentLink for JournalEntryPage with a type of 'pdf'

JournalEntryPage.prototype.link() creates the actual string.

When #9 is implemented, prefer to use the CODE (if defined) rather than the NAME in the link.

Implemented in V0.9.0


Can't install pytorch-directml with Poetry

I use Poetry for dependency management.
I've created a new environment with Python 3.8 and installed torchvision==0.9.0, but poetry won't allow removing torch as the readme suggests, because it's a requirement of torchvision.
Some questions:

Is install with Poetry possible?
Is it likely that pytorch-directml will always be a few versions behind for torch, torchvision and Python itself? It's rather difficult to take an established app on Python 3.10 and the latest version of a bunch of packages and make it all work with old versions. I don't mean to sound pushy, I just want to get my expectations right; if there will always be a lag I'll look for other ways to get PyTorch + Windows + AMD working.
The MSDN docs say that "only" torch version 1.8 is supported, this seems to contradict the readme which says 1.8 will cause collisions. Which is correct?

Try recreating env by first installing pytorch-directml & then torchvision
You havent mentioned the exact error you see.

Hi @davidgilbertson, torch-directml has moved to a plugin model. Check out the latest release here: torch-directml. The plugin model resolved many of the dependency issues that could cause issues like you saw above. Please take a look and reactivate if you still face any issues using torch.nn with DirectML.
Thanks!


more tweaks

Codecov Report

Merging #343 into experimental will increase coverage by 0.16%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##           experimental     #343      +/-   ##
================================================
+ Coverage         82.49%   82.65%   +0.16%
================================================
  Files                23       23
  Lines              1028     1026       -2
================================================
  Hits                848      848
+ Misses              180      178       -2

Impacted Files
Coverage Δ

vent/core/rq-worker/file_watch.py
3.7% <0%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3a6bf...5e797d8. Read the comment docs.


BRD, DRG, BLM, MNK, SMN as of patch 6.48

Bard (Level 80):
-Quick Nock (AoE) performs single-target rotation instead.
Dragoon (Level 80):
-Single-target combo lets both DoT and personal buff drop.
Black Mage, Monk, and Summoner:
Do not function.

Bard works fine for me, checked in Zadnor.
Monk works until level 50-something only, Summoner until around level 30? With the Black Mage I'm not sure.

Are there any known plugins that are incompatible with bossmod? because i don't know why this would be happening.
Video of Black Mage and Bard Auto Rotation issues

Black Mage doesn't work past like level 50 or something, summoner doesn't work past level 30.

Only WAR and BRD are well supported for now. DRG should kinda work, but I expect bugs there - I'm planning to fix that at some point, once I level it up and play a bit at cap. Others are really not in a usable state, at least above 30/50.
Judging from the comments, I assume that BRD works fine? Closing on that assumption, please reopen if there are issues with BRD.


Updated The Created By Button as well as the Download Button

Updated the created by tbtton to add more colors and effects.
Added the icon of user before the text.

Added the functionality to go the github of the creator by clicking the button.
Updated the download button to add more focus to it. added some extra effects.

A better way would be to move the createdBy tag to the top right of the card as a small alert like thing. currently its taking a huge portion of the user focus.

Heyy @Spyware007
Everything seems to be fine now. Have a look & let me know if there is any fault.

Cool! @Souravvmishra .
You are doing a great job.
Looking forward to more contributions from you! 🧑💻
Thank you so much for your contribution.🌟
Make sure to ⭐ and follow me.

I would love to connect with you all ❤

https://www.linkedin.com/in/om-gawande/

Towards Greatness Brother ⚡


[graphene] Build error

Package: graphene[core]:x64-windows -> 1.10.8
Host Environment

Host: x64-windows
Compiler: MSVC 19.33.31630.0
vcpkg-tool version: 2022-06-17-9268e366206712e38102b28dbd1617697a99ff2e
vcpkg-scripts version: 2de7f388c 2022-10-27 (16 hours ago)

To Reproduce
vcpkg install graphene
Failure logs
-- Downloading https://download.gnome.org/sources/graphene/1.10/graphene-.tar.xz -> graphene-.tar.xz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'manifests' = off
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] Downloading https://download.gnome.org/sources/graphene/1.10/graphene-.tar.xz
Error: Failed to download from mirror set:
https://download.gnome.org/sources/graphene/1.10/graphene-.tar.xz: failed: status code 404

[DEBUG] D:\a\_work\1\s\src\vcpkg\base\downloads.cpp(788):
[DEBUG] Time in subprocesses: 0 us
[DEBUG] Time in parsing JSON: 7 us
[DEBUG] Time in JSON reader: 0 us
[DEBUG] Time in filesystem: 3114 us
[DEBUG] Time in loading ports: 0 us
[DEBUG] Exiting after 331.7 ms (317083 us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):

      Failed to download file with error: 1
      If you use a proxy, please check your proxy setting. Possible causes are:

      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.

      2. You are using Fiddler. Currently a bug (https://github.com/microsoft/vcpkg/issues/17752)
         will set HTTPS_PROXY to `https://fiddler_address:port` which lead to problem 1 above.
         Workaround is open Windows 10 Settings App, and search for Proxy Configuration page,
         Change `http=address:port;https=address:port` to `address`, and fill the port number.

      3. Your proxy's remote server is out of service.

      In future vcpkg releases, if you are using Windows, you no longer need to set
      HTTP(S)_PROXY environment variables. Vcpkg will simply apply Windows IE Proxy
      Settings set by your proxy software. See (https://github.com/microsoft/vcpkg-tool/pull/49)
      and (https://github.com/microsoft/vcpkg-tool/pull/77)

      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:273 (z_vcpkg_download_distfile_show_proxy_and_fail)
  ports/graphene/portfile.cmake:1 (vcpkg_download_distfile)
  scripts/ports.cmake:147 (include)

Additional context
This commit may be the problem:  https://github.com/microsoft/vcpkg/pull/27398/commits/cb3f98c21949389140940f8cabb33056cd455d19
It is failing to populate the version variable in the portfile and thus generating an invalid URL

Please make sure you have installed the latest version of vcpkg by running bootstrap-vcpkg.bat on Windows/ bootstrap-vcpkg.sh on UNIX.

Thanks @Thomas1664.  That was indeed the problem.


Dropdown Close Issue

Hi Team
I just noticed one issue and following are the steps to replicate it/:

When a value is already selected then by expanding the dropdown that selected option is shown highlighted which is perfectly right.
Now I move my mouse to any other option(except already selected) on the expanded dropdown and click outside anywhere on the webpage(the selected option is still it is in step 1) without performing any click on dropdown..
Now when i expand the dropdown then some other option is highlited(on which mouse is hovered) instead of selected option.

Please review and suggest the suitable change.
Thanks.

Hi and thanks alot. We'll look into this asap!
Kindly
Jógvan


fix: add missing files module

We add a convenience module for file and path operations.
Tests included.
Change-Type: patch

Ref #2333

Thanks guys, I've updated it now.

Just out of curiosity, how come the files module being missing wasn't picked up by #2157 ?

Good question. Reason is that it's required from JSX, and that wasn't being linted – see https://github.com/resin-io/etcher/pull/2358


⚠ Bofrost.lu has degraded performance

In 0664782, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 921 ms

Resolved: Bofrost.lu performance has improved in b95363e after 6 minutes.


Fix Review app Sass compile after error

This PR fixes Gulp "Did you forget to signal async completion?" when Sass compilation errors occur in:

https://github.com/alphagov/govuk-frontend/issues/4237

The issue
Spot my missing await in https://github.com/alphagov/govuk-frontend/commit/8f74d0265903b199b91f21425e7bb357d55bee39 🤦♂
Error logging
I've made sure all "watch + reload" tasks use Gulp's new PluginError() for consistent output, as currently:

Sass tasks via scripts.compile() throw new PluginError()
Rollup tasks via styles.compile() throw new PluginError()
npm tasks via npm.script() log console.error(error.message) without error

But Gulp is now aware of npm task errors too, without interrupting watch tasks:

Thanks @romaricpascal
Just need to confirm those error codes etc in Windows before merging

To avoid unnecessary error logging on Windows I've silenced { code:<PHONE_NUMBER> } as shown:

https://github.com/microsoft/vscode/issues/107501
https://github.com/open-cli-tools/concurrently/pull/359

Don't want to make Ctrl + C too noisy on Windows if we can avoid it there too


Request: Add License

Could you add licensed in this repo? I'd like to use this in my application, but being unlicensed is problematic.

Hi there, sorry for the delay. I've added an MIT license file to the root of the project. If that solves your problem, feel free to make use of this library.


Segmentation fault error

No matter what I do, I get a "Segmentation fault (core dumped)" when it tries the 2nd model. For example, I tried adding CUDA_VISIBLE_DEVICES=0 and CUDA_VISIBLE_DEVICES=-1 but that did not help. I am using a totally new AWS server just for this program, and I tried both the Ubuntu and Amazon Linux Deep Learning AMIs (such as https://aws.amazon.com/marketplace/pp/B077GCZ4GR ). I pip installed Tensorflow-GPU and Keras.
I will use whatever server configuration is needed to get this working. Everything runs fine for the first model, see below:
Model #1 / #36
Predicted actions :  [0, '3x3 dconv', 0, '3x3 dconv']
2018-06-25 15:13:07.805285: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1435] Adding visible gpu devices: 0
2018-06-25 15:13:07.805332: I tensorflow/core/common_runtime/gpu/gpu_device.cc:923] Device interconnect StreamExecutor with strength 1 edge matrix:
2018-06-25 15:13:07.805347: I tensorflow/core/common_runtime/gpu/gpu_device.cc:929]      0
2018-06-25 15:13:07.805359: I tensorflow/core/common_runtime/gpu/gpu_device.cc:942] 0:   N
2018-06-25 15:13:07.805497: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1053] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 10763 MB memory) -> physical GPU (device: 0, name: Tesla K80, pci bus id: 0000:00:1e.0, compute capability: 3.7)
Train on 50000 samples, validate on 10000 samples
Epoch 1/1
50000/50000 [==============================] - 10s 201us/step - loss: 1.8916 - acc: 0.3220 - val_loss: 1.8114 - val_acc: 0.3520
Epoch 00001: val_acc improved from -inf to 0.35200, saving model to weights/temp_network.h5
10000/10000 [==============================] - 0s 37us/step
Manager: Accuracy =  0.352
Final Accuracy :  0.352
Finished 1 out of 36 models !
Actions :
inputs :  [(0, 1.0), (1, 0.0), (2, 0.0), (3, 0.0), (4, 0.0)]
ops :  [('3x3 dconv', 1.0), ('5x5 dconv', 0.0), ('7x7 dconv', 0.0), ('1x7-7x1 conv', 0.0), ('3x3 maxpool', 0.0), ('3x3 avgpool', 0.0)]
inputs :  [(0, 1.0), (1, 0.0), (2, 0.0), (3, 0.0), (4, 0.0)]
ops :  [('3x3 dconv', 0.0), ('5x5 dconv', 2.0), ('7x7 dconv', 0.0), ('1x7-7x1 conv', 0.0), ('3x3 maxpool', 0.0), ('3x3 avgpool', 0.0)]
Model #2 / #36
Predicted actions :  [0, '3x3 dconv', 0, '5x5 dconv']
2018-06-25 15:13:19.862650: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1435] Adding visible gpu devices: 0
2018-06-25 15:13:19.862695: I tensorflow/core/common_runtime/gpu/gpu_device.cc:923] Device interconnect StreamExecutor with strength 1 edge matrix:
2018-06-25 15:13:19.862710: I tensorflow/core/common_runtime/gpu/gpu_device.cc:929]      0
2018-06-25 15:13:19.862717: I tensorflow/core/common_runtime/gpu/gpu_device.cc:942] 0:   N
2018-06-25 15:13:19.862840: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1053] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 10763 MB memory) -> physical GPU (device: 0, name: Tesla K80, pci bus id: 0000:00:1e.0, compute capability: 3.7)
Segmentation fault (core dumped)
ubuntu@ip-172-31-17-27:~/pnas$ ^C

Keras 2.2.0 and TF 1.8 Seg fault when you use K.clear_session() and then fit another model.
I don't know any current solution other than downgrading Keras to 2.1.6 or TF to 1.7

Yes, that fixed it!


Updated for Zeit Now V2

Thank you Natalia for the hint!
Sadly I couldn't find any better way than this one and I'm not quiet sure if that's something that should be added directly to the docs/guide? As it might make it very long. What do you think?
{
    "name": "my-example-app",
    "version": 2,
    "builds": [
        {
            "src": "dist/**",
            "use": "@now/static"
        }
    ],
    "routes": [
        {
            "src": "/(js|css|img)/(.*)",
            "dest": "/dist/$1/$2"
        },
        {
            "src": "/favicon.ico",
            "dest": "/dist/favicon.ico"
        },
        {
            "src": "/(.*)",
            "dest": "/dist"
        }
    ],
    "alias": "vue-example"
}

@ivansieder I think I've seen the same approach on other PRs for Now 2. It seems to be the only possible way for now (please correct me if I am wrong)

@NataliaTepluhina I've added it now as an additional config, but that way it's clearer what can be left out, if the router mode is not set to history mode.

Thank you Natalia, I didn't even see that error 🙊


CI: Fix up deploy workflow

Finish fixing up deploy script (artifact names)
Fix up archive names in deploy script
Deploy Windows-msvc-generic rav1e.exe

Codecov Report
Base: 86.86% // Head: 86.86% // No change to project coverage :thumbsup:

Coverage data is based on head (d5b9f40) compared to base (011cce2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3065   +/-   ##
=======================================
  Coverage   86.86%   86.86%
=======================================
  Files          83       83
  Lines       33064    33064
=======================================
  Hits        28720    28720
  Misses       4344     4344

Impacted Files
Coverage Δ

src/asm/x86/lrf.rs
93.48% <0.00%> (-0.64%)
:arrow_down:

src/api/internal.rs
97.79% <0.00%> (-0.23%)
:arrow_down:

src/rdo.rs
85.72% <0.00%> (+0.04%)
:arrow_up:

src/partition.rs
77.74% <0.00%> (+0.15%)
:arrow_up:

src/context/transform_unit.rs
90.49% <0.00%> (+0.71%)
:arrow_up:

src/tiling/tile_state.rs
89.13% <0.00%> (+0.72%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Verified with a short-lived tag before squashing and rebasing:
https://github.com/xiph/rav1e/actions/runs/3533328645/jobs/5929299149


Set up isssues with semi annotation with deep learning model.

i am facing some issues regarding deploying serverless for the annotation and have two issues.

Magic Wand not appearing

Model tab does not show the nuctl deployed models.

The Magic wand, i unable to get it appearing. i follow the discussion but unable to find the cause.
https://github.com/opencv/cvat/issues/5987

At this point, i had been following the guides on checking the nuctl deployed and have successfully deployed and verified through the nuctl dashboard and get functions. Based on this guide (https://opencv.github.io/cvat/docs/manual/advanced/serverless-tutorial/) i am following up to the deployment of the siamese mask. However i dont see it in the model and my running of the container is ok and no error.

And if i get docker-compose yml from the github and run i will encounter "service "cvat" has neither an image nor a build context specified: invalid compose project" why is it so?
Appreciate help in these issues. Thanks in advance

I followed this tutorial page and it worked for me
https://opencv.github.io/cvat/docs/administration/advanced/installation_automatic_annotation/

@lchunleo
Please, provide all steps you did and logs you have. Also fill the issue template as possible.

Thanks . i noted the issues arised because i am using a old version of cvat and thus the newer functions such as SAM can't work. i have to reinstall the new cvat to make it work


Bound the rank calculation to avoid corner cases when quantile = 1.0

Fixes #1

@divinerapier Any chance you can give this a review?


Generators produce duplicate variable names

When generators are converted to JS, there ends up being both a var _step and a function _step, which breaks some strict-mode engines (e.g. recent versions of Chrome).

This is fixed in my community repo, since I now have Gorillascript compiling to ES6 generators.


Bootstrap's examples customization

Examples are a great way to get projects started. However in v4, they weren't maintained on the Boosted side and pretty much unusable as-is.
We definitely should make them accurate from a brand perspective.
As a bonus, they may use our custom component at some point? Or would this be too much to maintain?

Snippets (examples) to "unbootstrapize" :

[ ] Headers (replace Bootstrap svg by Orange logo)
[ ] Heroes (mentions Bootstrap)
[ ] Features (make everything more squared)
[ ] Sidebars (replace Bootstrap svg by Orange logo)

Some more examples identified during beta3 merge

[ ] Starter-template
[ ] sign-in
[ ] pricing
[ ] jumbotron


Support stats retrieval from a network namespace

This change enables the exporter to run in the default network namespace and retrieve the statistics from Jool running in an isolated namespace.
Introduces a new argument, -n (--namespace), followed by the name of the namespace.

Let's put this on hold. I have verified it works as expected when run as root, however when run as nobody the ip netns exec <namespace> fails with jool failed: setting the network namespace "<name-of-the-namespace>" failed: Operation not permitted, as the nobody user doesn't have the rights to access the namespace.
Another alternative is to add NetworkNamespacePath=/var/run/netns/<name-of-the-namespace> to jool-exporter.service (working since systemd ~242) and collect the metrics using the IP within the namespace.

Strange, I would have thought the NET_ADMIN capability would have helped here for the service trying to jump into a different netns. Might be a different capability?
You're running:
AmbientCapabilities=CAP_NET_ADMIN

in your unit file yes?
But probably the NetworkNamespacePath keeps the code simpler and works without any capability, so is probable the better way to go.


Explain the efficiency in docs

Is your feature request related to a problem? Please describe.
I don't see anywhere in the docs an explanation on how structured outputs that interleave prompt and generation actually works, and what is the efficiency implications. For instance, the first example given:
# define a guidance program that adapts a proverb
program = guidance("""Tweak this proverb to apply to model instructions instead.

{{proverb}}
- {{book}} {{chapter}}:{{verse}}

UPDATED
Where there is no guidance{{gen 'rewrite' stop="\\n-"}}
- GPT {{gen 'chapter'}}:{{gen 'verse'}}""")

To someone who doesn't know better, this might seem like a standard GPT prompt that gets executed in 1 pass. But if you dig deeper, you'll see that this example requires 3 GPT calls (makes sense, no other way to do it currently). Every call requires all of the context before it, so this is essentially 3*N in terms of compute time and price. This is a bad idea if you have a very long agent type prompt. I can imagine someone having a 6k long prompt that requires a json object at the end, and putting in their own keys and requesting 10 filled in fields. That would be very slow and expensive!
Describe the solution you'd like
Better documentation on how everything works under the hood. Which models are able to achieve actual speedups, and which models would be a bad idea to structure prompts like this.

I have the same question like u. I am also wondering how does "gen" works.

If each time guidance use "gen" , and it calls LLM and put all the text before "gen" into LLM, then it would be really costy.
And if so, it seems like a linear progress. How do guidance achieve "Guidance Acceleration"? (From Readme: This means Guidance only asks the LLM to generate the green text below, not the entire program. This cuts this prompt's runtime in half vs. a standard generation approach.)

@Tom-0727 from what I guess, if you have access to the underlying model (i.e its an open source model run through Transformers library) you can cache the prompt more or less and then you get a "speedup" where it becomes something closer to just straight generation. But for API based models you cant, and thus this library seems like not such a good idea for those.

Great questions and we will expand docs when we can to cover this.
Basically you get the same performance you normally get for API endpoints that don't yet support guidance (and yes, chaining lots of calls to gen is clean and easy, but comes with the same performance impacts you get with any other library). But for endpoints that do support guidance directly (currently just transformers open models, soon llama.cpp, ...) then we can reuse and smartly batch the KV cache. This is actually much faster than straight generation since you can pay "prompt token cost" for all the known parts of the prompt (which are much faster than generation tokens).
If you are using traditional endpoints then you mostly just get nice select forcing, stop_regex support, streaming development in your notebook, etc. Not performance acceleration (and be careful about making long chains of calls or you will end up with a performance hit).

Do you have some inside knowledge that API based LLMs will support something like this in the future? That would definitely change prompting techniques. While there is no technical reason why it couldn't be done, there may be practical reasons that OpenAI for instance never supports this. But I'd be very interested to understand whether this is the direction that they will likely take.

Do you have some inside knowledge that API based LLMs will support something like this in the future? That would definitely change prompting techniques. While there is no technical reason why it couldn't be done, there may be practical reasons that OpenAI for instance never supports this. But I'd be very interested to understand whether this is the direction that they will likely take.

Technically, I think it's because the API backend computes all prompt requests in bulk simultaneously, making it difficult to implement pauses and interruptions in between; But openAI will definitely charge less for doing this...

But for endpoints that do support guidance directly (currently just transformers open models, soon llama.cpp, ...) then we can reuse and smartly batch the KV cache.

@slundberg  could you elaborate what "support guidance directly" means?

In the new release, we try to explain this here. Hopefully it's more clear now, if not please reopen :)


Fixed offloading for PyT version/ Added Attention activation offloading support/ Native FP8 support

PR does the following:

Offloading was breaking for the latest PyTorch versions because torch.compile tried to save some stray tensors which shouldn't be considered for offloading. Added that filter and fixed the issue.

Flash Attention and Fused attention can have it's input activations offloaded which wasn't supported before. Added support for that.

Native FP8 doesn't use transposed FP8 weights in a cache. Added None guards so that this doesn't break.

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch


Add an example java project for produce and consume with REST proxy

Crete and publish a project that shows how to use a REST proxy client to produce to and consume from a kafka topic.

o

o


[Impeller] Make coverage testable in EntityPass.

Coverage computation has become very compex in EntityPass, and it desperately needs a comprehensive suite of tests that can cover all the cases (and more rigidly define its intended behavior) -- some cases are theoretical and don't show up with real entities (yet), and so we can't always rely on goldens for stuff like this. Self-contained pieces like GetSubpassCoverage() don't require any render state.

@bdero I unassigned you because I don't think you are working on this.

For entities themselves we use the display list computed values. For RT sizes we refactored the computation into a testable method in https://github.com/flutter/engine/commit/7cfef4b05c652e34972f6bcd1413b14f01cb8d2e


🐛 fix of useShorthandFunctionType does not work correctly

Environment information
CLI:
  Version:                      1.6.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v21.4.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "bun/1.0.30"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?
Biome suggests the following correction:
- interface Foo<T> {
- (value: T): boolean;
- };
+ type Foo = (value: T) => boolean

However, this is an error as the generic has been removed.
https://codesandbox.io/p/devbox/boring-dew-kjtvgk
Expected result
The correct modification should be as follows:
- interface Foo<T> {
- (value: T): boolean;
- };
+ type Foo<T> = (value: T) => boolean

Code of Conduct

[X] I agree to follow Biome's Code of Conduct

I'll work on this.


Add ansible-core on C10S and ansible on Fedora and C9S

Add ansible-core on C10S and ansible on Fedora and C9S

/test
[test]


refactor: missing accessories system

Description
Uses /items endpoint to get accessories instead of hard coding every one of them
Also thanks to @MattTheCuber for code

Also fixes inactive accessories not being shown

Before

After

Found bug, cba to fix it today

Found bug, cba to fix it today

Fixed

Also fixes inactive accessories not being shown

Before

After

Made it better, now it shows accessories which aren't in accessory bag or aren't unique as well

Before

After

Added Location field to inactive accessories so players can see where the accessory is located at

Made it better, now it shows accessories which aren't in accessory bag or aren't unique as well

What about accessories you don'teet requirements for like Reaper Orb?

Made it better, now it shows accessories which aren't in accessory bag or aren't unique as well

What about accessories you don'teet requirements for like Reaper Orb?

Good idea, gonna add that. Most likely tomorrow


Port tests in displayable.rs to sqllogictest

Part of https://github.com/apache/arrow-datafusion/issues/6195. We are trying to

keep the DataFusion code base clean and easy to contribute to and modify
Understand what features are covered and what are not

Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily
Describe the solution you'd like
Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/displayable.rs to
displayable.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files
Note you can create catalogs and schema via SQL now
Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema
Notes:

Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest

Describe alternatives you've considered
No response
Additional context
I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.

I actually think this test may be covered by explain.slt already

Hi @alamb, I looked into this and it seems displayable.rs was already migrated with #8246, there is no such file anymore in the test folder. I think this issue can be closed.

Hi @alamb, I looked into this and it seems displayable.rs was already migrated with #8246, there is no such file anymore in the test folder. I think this issue can be closed as resolved.

Thank you @simicd  -- I think you are right. Closing!


use 24h values; convert stroops to lumens; small bug cleanup

Preview is available here:http://amm-demo-pr51.previews.kube001.services.stellar-ops.com/

Preview is available here:http://amm-demo-pr51.previews.kube001.services.stellar-ops.com/


feat: Added trigger grouping methods to indexers

Description
Added indexer method to support to grouping triggers by property.
Supports 3 ways to determine the properties associated with a trigger:

$designer: { "propertyGroups": ["", "<name2", ... ]
has "property": ""
has condition : ""

This association spans the trigger and its actions.
The grouping algorithm supports

single/multi parent of triggers in groups, choosing the first property in the case of single.
providing a list of valid properties to exclude any discovered properties that are not part of the schema

Added indexer method to support extracting the schema property names from a dialog with a schema property.  This prefers the properties under $public, but falls back to all properties.
Task Item
#minor
#4150
Screenshots
While the project tree isn't in main yet, this demonstrates that a form with a schema can be identified as a form dialog, and the triggers can be grouped by property.

Coverage remained the same at 55.694% when pulling 1af7cfd9a7dba7091cbadf6e916618a13d7f82a4 on gcox/groupTriggers into 20efe392de64d17c62e905cd0199a082c1a75fe4 on main.


Replace "re-use" with "reuse"

This replaces "re-use" with "reuse", which was flagged on #38 for some reason. That PR didn't touch those files, but I figured I'd fix them anyway.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
~Added tests.~
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
~Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.~
~If this is a new cop, consider making a corresponding update to the Rails Style Guide.~

I don’t think I have merge rights in this repo. Cc @koic


Event pub/sub between components?

given 2 components:
function View1(vm) {
         return function() {
             return el("div", "View 1");
         };
     }
function View2(vm) {
         return function() {
             return el("div", "View 2");
         };
     }

     // VM 1
     var vm1 = domvm.createView(View1);
     vm1.config({
         onemit: {
             myEvent: function() {
                 console.log('VM 1 reporting');
             }
         }
     });

     // VM 2
     var vm2 = domvm.createView(View2);
     vm2.config({
         onemit: {
             myEvent: function() {
                 console.log('VM 2 reporting');
             }
         }
     });
  vm1.mount(document.body);
  vm2.mount(document.body);

 vm1.emit("myEvent"); // Not a global event

How can I make one component, in this example , vm1, broadcast an event that all subscribed components would react to? Thanks

I saw this in the docs, what would be the correct signature then?
onevent: {}

the emit system bubbles up within the same view tree (similar to native dom events). if you need a global pub/sub it's easy enough to DIY or BYO - there are plenty to pick from.
in general i'm not a fan of pub/sub or multiple subscribers since it makes tge system less predictable because order of registration matters (and is often out of your control) and dictates the order of execution. this makes things quite fragile. it's also why domvm does not support multiple event handlers for the same event type on the same node. you can read more about this here: https://github.com/leeoniya/domvm/issues/177
the way for components to "communicate" is through a shared state that both have access to.

Ok @leeoniya , I would have to implement my own messaging bus then. There still something that I don't understand
var vm2 = domvm.createView(View2);
     vm2.config({
         onemit: {
             myEvent: function() {
                 console.log('VM 2 emitting');
             }
         },
         onevent: function(e, node, vm, data, args) {
             console.log('VM 2 reporting');

         }
     });
     vm2.mount(document.body);

     vm2.emit("myEvent");
 ````
" console.log('VM 2 emitting');"  works as expected, but the "onevent" callback is never triggered, can you point me to a code example using this? Thanks

Ok @leeoniya , I would have to implement my own messaging bus then.

the one caveat with this is possible memory leaks when holding onto vm instances if you subscribe but forget to unsubscribe them. also, if you use eg didMount and didUnmount lifecycle hooks to auto-register/deregister subscribers into a global bus, you may run into perf concerns with huge component counts. i dunno if you were only planning on doing this selectively, but certainly something to keep in mind.
onemit is for emit events
onevent is for dom events and will fire for any fancy listeners: https://github.com/leeoniya/domvm#event-listeners

@kokujin
here's a pub/sub implementation that should be leak-free (except the roots, which should be quite manageable). it works by walking the full vtree during pub() calls and invoking anything that matches the registered event names under vm.subs. this design prevents and dynamic registration/unregistration that's mount-dependent.
https://jsfiddle.net/3gr1cmfh/

Great @leeoniya, I will try your code out asap. Actually, I have tried out a very simple way to maintain state and pub/ sub events using baoba.

i prefer the smaller Freezer ;)


Fix broken line in cutter script.

Solution from @protodonuts and @asmitaw.
Note that there are additional issues in #241, this is a partial fix. Please test before merging.

Fixed stray semicolon.

Looks good, but I'll test it out before doing the final merge

Looks like @tst-awankhede verified the changes, so merging this


mxnet.image.imdecode crash if input a empty buffer

Description
mxnet.image.imdecode() will crash and python process will die if pass a empty bytes buffer to the function.
This looks like a opencv bug, but we should do validation to avoid crash the process.
Environment info (Required)
----------Python Info----------
('Version      :', '2.7.15')
('Compiler     :', 'GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-9<IP_ADDRESS>)')
('Build        :', ('default', 'Oct  2 2018 12:50:38'))
('Arch         :', ('64bit', ''))
------------Pip Info-----------
('Version      :', '18.0')
('Directory    :', '/usr/local/lib/python2.7/site-packages/pip')
----------MXNet Info-----------
objc[37046]: Class CaptureDelegate is implemented in both /usr/local/opt/opencv/lib/libopencv_videoio.3.4.dylib (0x1179ed9d8) and /usr/local/lib/python2.7/site-packages/cv2/cv2.so (0x1257b02d0). One of the two will be used. Which one is undefined.
('Version      :', '1.3.1')
('Directory    :', '/Users/lufen/source/mxnet/python/mxnet')
Hashtag not found. Not installed from pre-built package.
----------System Info----------
('Platform     :', 'Darwin-16.7.0-x86_64-i386-64bit')
('system       :', 'Darwin')
('node         :', 'f45c89cb5707.ant.amazon.com')
('release      :', '16.7.0')
('version      :', 'Darwin Kernel Version 16.7.0: Thu Jun 21 20:07:39 PDT 2018; root:xnu-3789.73.14~1/RELEASE_X86_64')
----------Hardware Info----------
('machine      :', 'x86_64')
('processor    :', 'i386')
machdep.cpu.extfeatures: SYSCALL XD 1GBPAGE EM64T LAHF LZCNT PREFETCHW RDTSCP TSCI
machdep.cpu.leaf7_features: SMEP ERMS RDWRFSGS TSC_THREAD_OFFSET BMI1 AVX2 BMI2 INVPCID SMAP RDSEED ADX IPT FPU_CSDS
machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH DS ACPI MMX FXSR SSE SSE2 SS HTT TM PBE SSE3 PCLMULQDQ DTES64 MON DSCPL VMX EST TM2 SSSE3 FMA CX16 TPR PDCM SSE4.1 SSE4.2 x2APIC MOVBE POPCNT AES PCID XSAVE OSXSAVE SEGLIM64 TSCTMR AVX1.0 RDRAND F16C
machdep.cpu.brand_string: Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
----------Network Test----------
Setting timeout: 10
Timing for MXNet: https://github.com/apache/incubator-mxnet, DNS: 0.0190 sec, LOAD: 0.5909 sec.
Timing for PYPI: https://pypi.python.org/pypi/pip, DNS: 0.0169 sec, LOAD: 0.5069 sec.
Timing for FashionMNIST: https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/dataset/fashion-mnist/train-labels-idx1-ubyte.gz, DNS: 0.0214 sec, LOAD: 0.1385 sec.
Timing for Conda: https://repo.continuum.io/pkgs/free/, DNS: 0.0166 sec, LOAD: 0.0696 sec.
Timing for Gluon Tutorial(en): http://gluon.mxnet.io, DNS: 0.0540 sec, LOAD: 0.2254 sec.
Timing for Gluon Tutorial(cn): https://zh.gluon.ai, DNS: 0.0357 sec, LOAD: 0.0770 sec.

Build info (Required if built from source)
MXNet commit hash: 815f36ce8b4ed16fe27d500f5c8c930cd10cee5c
Error Message:
libc++abi.dylib: terminating with uncaught exception of type cv::Exception: OpenCV(3.4.3) /tmp/opencv-20181001-10090-v5zhfq/opencv-3.4.3/modules/imgcodecs/src/loadsave.cpp:737: error: (-215:Assertion failed) !buf.empty() && buf.isContinuous() in function 'imdecode_'

Abort trap: 6

Minimum reproducible example
>>> from mxnet import image as img
>>> buf = b''
>>> img.imdecode(buf, 1, True, None)
libc++abi.dylib: terminating with uncaught exception of type cv::Exception: OpenCV(3.4.3) /tmp/opencv-20181001-10090-v5zhfq/opencv-3.4.3/modules/imgcodecs/src/loadsave.cpp:737: error: (-215:Assertion failed) !buf.empty() && buf.isContinuous() in function 'imdecode_'

Abort trap: 6

Steps to reproduce
What have you tried to solve it?
I have to validate buffer is not empty before pass to image.imdecode()

@frankfliu @anirudhacharya is also facing this issue before, looks like we need a better backend handling there.
@mxnet-label-bot [python, openCV, bug]

but how to solve this bug?


Numba RC 0.49

This pull request prepares RBC for the next numba release. They will also launch a new version of llvmlite but I think we are safe.
@pearu, can you test this with the latest Omnisci server version?
Issue #53

My idea was to wait until Numba releases 0.49 to merge this PR.

Test results:

numba 0.48, omnscidb-internal 5.2: one failure #55
numba 0.50.0dev0, omnscidb-internal 5.2: one failure #55
numba 0.50.0dev0, omnscidb-internal 5.1.2: two failures: test_getitem_bool and test_even_sum, the cause is fixed in omnscidb-internal 5.2

None of the above failures are related to this PR


Inline multiplexer calls writability mgr directly

Motivation:
The HTTP2StreamChannel keeps track of how many bytes have been written and how many are buffered for use in evaluating the 'writability' of the stream channel. Bytes are considered 'written' or at least no longer buffered when the write is completed (successfully or errored).  Creating and attaching these promises requires costly allocations.
Modifications:
We can remove the need to create these promises for the new inline stream multiplexer because the multiplexer and man HTTP2 channel operations are now all within the HTTP2ChannelHandler. This change calls the writabilityManager directly when writes are completed.
Result:

Fewer allocations are required for HTTP2 writes.
Writes are considered 'complete' when they leave the HTTP2ChannelHandler

This change reduces the allocations for the test_client_server_request_response many (1000) requests allocation test from 1.3M to 1.0M.

It should be noted that the 9 byte frame header does not count against the flow control windows, so we do not need to consider it here.

It should be noted that the 9 byte frame header does not count against the flow control windows, so we do not need to consider it here.
RFC 9113 § 6.9.1:

For flow-control calculations, the 9-octet frame header is not counted.

Oh great! We just need to update estimatedFrameSize or the value we provide to wroteBytes to ignore that then.

Yeah I think the fix is to drop the use of estimatedFrameSize altogether, tbh. I don't really know what I was thinking when I proposed it. Might be worth writing a separate patch to replace this with a flowControlledSize that correctly only covers that question.

I've opened a PR for changing that estimatedFrameSize https://github.com/apple/swift-nio-http2/pull/387


Bluetooth: Mesh: Added support for application access to mesh messages

Added bt_mesh_msg_send() which can be used by the application to
directly send model layer messages without local instantiation of
related models. Also added bt_mesh_msg_cb_set() which allows the
application to recieve mesh model layer messages without local
instantiation of related models.
Added bt_mesh_has_addr() which returns a bool. For unicast addresses,
this returns whether or not bt_mesh_elem_find() was successfull. If the
above mentioned bt_mesh_msg_cb_set() has been used by the application to
set a message callback, this returns true so that the stack attempts to
push every model message up to the application via the callback. If no
callback has been set, group addresses are searched to see if the stack
should pass the message up the stack to an instantiated model.
These changes allow applications that do not or can not instantiate
models to interface with models in a mesh network. This is applicable to
applications which act as a Bluetooth mesh gateway, sniffer, debugger,
network monitoring, non-mesh relay/extender, etc.
In app_keys.c friend.c net.c bt_mesh_elem_find() is used only to
determine the existance of an address. The full return value of
bt_mesh_elem_find() is unecessary and so was replaced by the above
mentioned bt_mesh_has_addr() function in these instances.
Simplified bt_mesh_elem_find() by removing the search through group
address. Since the above mentioned bt_mesh_has_addr() function handles
instances where group addresses must be searched, it was no longer
necessary to preform this search in this function.
Signed-off-by: Bud Wandinger<EMAIL_ADDRESS>

Sorry for breaking into your PR... But I thought it might be worth sharing my suggestion here. This addition now looks like a freestanding piece of code and a bit like a hack. However I see how it can be part of main code so that we don't need yet another Kconfig option and rarely used code:

Use bt_mesh_msg_send() in between bt_mesh_model_send()/bt_mesh_model_publish() and bt_mesh_trans_send(). Or even better to makebt_mesh_trans_send() more user-friendly as it was suggested in one of the comments above.
Don't call bt_mesh_model_recv() from transport layer, but instead add a section to a linker script to register listeners for received SDUs (for example: https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/mesh/subnet.h#L81). Use Z_STRUCT_SECTION_FOREACH to iterate through all listeners in sdu_recv() in transport.c (with resetting  net_buf between each call). Thus we don't need bt_mesh_msg_cb_set().

Having user-friendly bt_mesh_trans_send() and listeners registration at the transport layer will make a single entry point for sending and receiving messages for the upper layer(s).

Don't call bt_mesh_model_recv() from transport layer, but instead add a section to a linker script to register listeners for received SDUs (for example: https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/mesh/subnet.h#L81). Use Z_STRUCT_SECTION_FOREACH to iterate through all listeners in sdu_recv() in transport.c (with resetting  net_buf between each call). Thus we don't need bt_mesh_msg_cb_set().

Not sure if I'm a big fan of this, it'll make the code flow on rx harder to follow for 99.9% of users who only care about access. If we do it this way, I suggest we treat access specially, and call that directly, like we do today, then call listeners in a loop afterwards. It'll weaken the concept a bit, but it wouldn't obfuscate the normal case

@BudkoEmbedded the unrelated changes are still in here now. To get rid of these, you can do the following:
# undo the commit:
git reset HEAD~1
# add the files you actually want:
git add -u subsys/bluetooth/mesh
# commit with the same message as before:
git commit -c ORIG_HEAD --no-edit
# push them to your github repo again:
git push --force

Afterwards, you may want to clean up your local folder, removing the files we don't want. git clean -f scripts will forcibly remove all files in the scripts folder. You can do similar calls for other files.


modify log => klog

What this PR does / why we need it:
using klog instead of log
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Change the places you used log.Fatal(not klog.Fatal) to panic

Why

Because you are still using log here.

Because you are still using log here.

so what？

Because you are still using log here.

so what？

So if you are using log, please use a proper logger like klog, otherwise don't use it.

It is generally a bad practice to mix use of print and log
I believe print out the full stacktrace for tools like tag and generate Cert would help both users and developers to debug and develop.


Improve the aperture mask plotting style (feedback welcome!)

The style we currently use to visualize aperture masks using tpf.plot(aperture_mask=mask) is somewhat difficult to see because it uses faint pink transparency.  I would like to propose to change it to a less ambiguous red hatching style.  See the example below!
Is anyone against this change?
Current style:

Proposed new style

👍

I think it's a great idea to change the hatching style! Would it be possible to switch to diagonal lines or crosses for the shading? This style would be hard to look at for people who suffer from trypophobia (fear of clusters of dots/holes).

I think I just become trypophobic by entering the term into Google Images, so I'm happy to change it.
Shall we go with this instead?

Looks great!

Yes! Hatched looks good.

Thanks everyone!  I went ahead and merged this change, but happy to revise in the future if someone can think of a better style!


Add http status code on exceptions

This changeset makes the HTTP status code available on the exception message. Right now there is no way to distinguish between different HTTP errors that could happen except for a string match on exception message, it results in code like
if (stristr($exception->getMessage(), '404 - Not Found')) {
   //... Logic here
}

which is not really scalable. After this change will be possible to write code like
if ($exception->getCode() == 400) {
   //... Logic here
}

Thanks for your work on this new feature!


Fix some ExecutorService leaks

Motivation
Some tests don't close all ExecutorServices created in tests. There were also a few issues in production code where ExecutorServices weren't closed.
Modifications

consistently close ExecutorServices created in tests
prefer the usage of Lombok's @Cleanup("shutdownNow") for calling the .shutdownNow() method.


Update mono path to reflect el capitan

This fixes the mono path resolution on El Capitan+ OS X machines which have system integrity enabled so you have no write access to /usr.

Thanks Therzok !!!  Have not run into that myself.


vscode crash on startup

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  1.82.2
OS Version:  nixos unstable - hyprland / wayland

These options gets added somewhere as well
Warning: 'ozone-platform-hint' is not in the list of known options, but still passed to Electron/Chromium.
Warning: 'enable-features' is not in the list of known options, but still passed to Electron/Chromium.
Steps to Reproduce:

Run: code --verbose --log trace --disable-extensions --disable-gpu --crash-reporter-directory=/home/istasi/vscode/
crashes when mousemove i think?, seems to be able to run if i keep the mouse out of it

Not sure if this belongs here, tested very shortly but seems to be able to run fine on kde/wayland (startplasma-wayland), although 1.81.1 runs fine on hyprland
7fe5e543-e14a-4a09-9af9-62b4f8dcb2bc.zip

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Ah, mistyped versions, failing version is 1.82.2, working version is 1.81.1

nvm, guess its related to the other wayland issue, as one of the solutions there work for this as well
https://github.com/microsoft/vscode/issues/184124#issuecomment-1717650430


Conda package is broken for Python 3.9

On Linux Mint 20.2 with Python 3.9.7 trying to import package
33908 illegal hardware instruction (core dumped)  python -c 'import IPython; IPython.terminal.ipapp.launch_new_instance()'
Not sure if the Python 3.8 work around applies to this situation, but will I need to update some flags to get this to work?

Hi @oobie2142 thanks for playing with PyAbel.
I run Ubuntu 21.10, python 3.9.7, and have not experienced any PyAbel installation issues:
Gibbo:/home/stg121]$ which python
/usr/bin/python
[Gibbo:/home/stg121]$ python -V
Python 3.9.7
[Gibbo:/home/stg121]$

Using the install command:  python setup.py install --user
I have also tried using the latest conda, also python 3:
/home/stg121/anaconda3/bin/python
(base) [Gibbo:.+l/PyAbel-master]$ python -V
Python 3.9.7

PyAbel install also without error.
From the error message, there may be something wrong with your conda installation. Perhaps, try removing it and reinstall?
@MikhailRyazanov is more knowledgeable on these matters, and will probably provide a definitive solution.

I guess, it's the same error as in #320, so we probably should close this issue as a duplicate and continue the discussion there.
My understanding is that the problem appears when user's CPU is different from the CPU on the server that builds the Conda package, so some users (like @stggh) don't see it at all, but for some users it completely breaks the whole package. And because this is caused by an optimization flag that is merely supposed to hopefully speed up just one slow (an thus perhaps not very popular) method, I'm inclined to simply remove that flag. I'm cleaning up our pending PRs and then will try to see what can be done with this...

Thanks @MikhailRyazanov I will close and move over to comment in #320


Unable to get plex - times viewed rule to work

I have the following rule configured and i'm unable to get it to work.  Looking for assistance on finding items that have never been watched.
1st value - Plex - Times Viewed
Action - Smaller
2nd Value - Number
Custom Value - 1
This is returning items that have been watched as identified in Plex.
I have also tried:
1st value - Plex - Times Viewed
Action - Equals
2nd Value - Number
Custom Value - 0
1st value - Plex - Times Viewed
Action - Contains
2nd Value - Number
Custom Value - 0
Can you please assist with where i am going wrong.  I have verified in Plex that the Movies have indeed been watched so they would have a times viewed greater than 0.
thank you.

Maintainerr will pull the views from Plex’s view history. You can verify in Plex Web if your items have view history records, but they probably don’t.
A recent Plex change impacts this feature. You can read more about it here: https://forums.plex.tv/t/view-history-change-in-1-40-0-x-server-version/863316
Because of this change, this approach isn‘t as reliable as it used to be anymore.
A Tautulli integration will become available in a future version, hopefully that’ll bring a better way to determine the watch state of a media item.

Thank you for the fast response.  Looking forward to the Tautulli integration.  Is there a rough ETA?

@jorenn92  Now that you have mentioned it, I'm very much looking forward to the Tautulli integration.  Is that expected any time soon?

@jorenn92 Now that you have mentioned it, I'm very much looking forward to the Tautulli integration. Is that expected any time soon?

I'm dedicating most of my time to a home renovation project lately, which has left me with limited availability for Maintainerr development. However, once I have more time, the Tautulli integration is one of the first tasks I plan to tackle. I can't say a time frame though.

@jorenn92 any updates on the tautulli integration for view history?  I just moved some things around between libraries to clean things up, and plex wiped out all the history whereas tautulli still has the accurate view history so now the counter on my rules pretty much starts over.
Here is an example:
After moving this, plex acts like it's never been watched before (even though I did the plex move dance).

@jorenn92 any updates on the tautulli integration for view history? I just moved some things around between libraries to clean things up, and plex wiped out all the history whereas tautulli still has the accurate view history so now the counter on my rules pretty much starts over.
Here is an example: After moving this, plex acts like it's never been watched before (even though I did the plex move dance).

Yes, there’s an active PR currently in draft status https://github.com/jorenn92/Maintainerr/pull/1280

Yes, there’s an active PR currently in draft status #1280

If you need a tester for this integration, I would be glad to test :)

Yes, there’s an active PR currently in draft status #1280

If you need a tester for this integration, I would be glad to test :)

Once it reaches the dev image you're very welcome to report any issue you find!

This is currently available in the dev branch. Reports so far are looking good. Re-open if anything else is needed.


export 'KetcherLogger' (imported as 'KetcherLogger') was not found in 'ketcher-core'

Steps to Reproduce

react-script run start
build is success, but compounent throw following errors

Actual behavior
ERROR in ./node_modules/ketcher-react/dist/index.modern.js 177:4-23
export 'KetcherLogger' (imported as 'KetcherLogger') was not found in 'ketcher-core' (possible exports: ARROW_MAX_SNAPPING_ANGLE, Action, AlignDescriptors, Atom,
 AtomAdd, AtomAttr, AtomDelete, AtomList, AtomMove, AttachmentPoints, Bond, BondAdd, BondAttr, BondDelete, BondMove, Box2Abs, CalcImplicitH, CanvasLoad, Chemical
MimeType, CoreEditor, DefaultStructServiceOptions, ElementColor, Elements, EnhancedFlagMove, FormatterFactory, Fragment, FragmentAdd, FragmentAddStereoAtom, Frag
mentDelete, FragmentDeleteStereoAtom, FragmentSetProperties, FragmentStereoFlag, FunctionalGroup, FunctionalGroupsProvider, Generics, HalfBond, Highlight, KetSer
ializer, Ketcher, KetcherAsyncEvents, KetcherBuilder, LayerMap, Loop, LoopMove, MolSerializer, MonomerCodeToGroup, MonomerGroupCodes, MonomerGroups, OperationPri
ority, OperationType, Pile, Pool, RGroup, RGroupAttachmentPoint, RGroupAttachmentPointAdd, RGroupAttachmentPointRemove, RGroupAttr, RGroupFragment, ReAtom, ReBon
d, ReEnhancedFlag, ReFrag, ReObject, ReRGroup, ReRGroupAttachmentPoint, ReRxnArrow, ReRxnPlus, ReSGroup, ReSimpleObject, ReStruct, ReText, RemoteStructService, R
emoteStructServiceProvider, Render, RenderStruct, RestoreDescriptorsPosition, RestoreIfThen, RxnArrow, RxnArrowAdd, RxnArrowDelete, RxnArrowMode, RxnArrowMove, R
xnArrowResize, RxnArrowRotate, RxnPlus, RxnPlusAdd, RxnPlusDelete, RxnPlusMove, SGroup, SGroupAddToHierarchy, SGroupAtomAdd, SGroupAtomRemove, SGroupAttachmentPo
int, SGroupAttr, SGroupBracketParams, SGroupCreate, SGroupDataMove, SGroupDelete, SGroupForest, SGroupRemoveFromHierarchy, SaltsAndSolventsProvider, Scale, SdfSe
rializer, SgContexts, ShowHydrogenLabelNames, ShowHydrogenLabels, SimpleObject, SimpleObjectAdd, SimpleObjectDelete, SimpleObjectMode, SimpleObjectMove, SimpleOb
jectResize, SmiSerializer, StereLabelStyleType, StereoColoringType, StereoFlag, StereoLabel, StereoValidator, Struct, SupportedFormat, Text, TextCommand, TextCre
ate, TextDelete, TextMove, TextUpdate, UpdateIfThen, Vec2, atomForNewBond, atomGetAttr, atomGetDegree, atomGetPos, atomGetSGroups, b64toBlob, bondChangingAction,
 calculateCanvasExtension, checkAtomValence, checkOverlapping, defaultBondThickness, emitEventRequestIsFinished, expandSGroupWithMultipleAttachmentPoint, findSte
reoAtoms, formatProperties, formatSelection, fromAromaticTemplateOnBond, fromArrowAddition, fromArrowDeletion, fromArrowResizing, fromAtomAddition, fromAtomMerge
, fromAtomsAttrs, fromAtomsFragmentAttr, fromBondAddition, fromBondStereoUpdate, fromBondsAttrs, fromBondsMerge, fromChain, fromDescriptorsAlign, fromFlip, fromF
ragmentDeletion, fromFragmentSplit, fromHighlightClear, fromHighlightCreate, fromItemsFuse, fromMonomerAddition, fromMultipleMove, fromNewCanvas, fromOneAtomDele
tion, fromOneBondDeletion, fromPaste, fromPlusAddition, fromPlusDeletion, fromPresetAddition, fromRGroupAttachmentPointAddition, fromRGroupAttachmentPointDeletio
n, fromRGroupAttachmentPointUpdate, fromRGroupAttrs, fromRGroupFragment, fromRotate, fromSeveralSgroupAddition, fromSgroupAction, fromSgroupAddition, fromSgroupA
ttrs, fromSgroupDeletion, fromSimpleObjectAddition, fromSimpleObjectDeletion, fromSimpleObjectResizing, fromStereoAtomAttrs, fromStereoFlagUpdate, fromTemplateOn
Atom, fromTemplateOnBondAction, fromTemplateOnCanvas, fromTextCreation, fromTextDeletion, fromTextUpdating, fromUpdateIfThen, getColorFromStereoLabel, getDirecti
ons, getHoverToFuse, getItemsToFuse, getPropertiesByFormat, getPropertiesByImgFormat, getRelSGroupsBySelection, getSnappedArrowVector, getStereoAtomsMap, getStru
cture, identifyStructFormat, ifDef, isAttachmentBond, isCloseToEdgeOfCanvas, isCloseToEdgeOfScreen, ketcherProvider, makeCircleFromEllipse, mergeFragmentsIfNeede
d, mergeMapOfItemsToSet, mergeSgroups, radicalElectrons, removeAtomFromSgroupIfNeeded, removeSgroupIfNeeded, runAsyncAction, sGroupAttributeAction, scrollByVector, selectionKeys, setExpandSGroup, shiftAndExtendCanvasByVector, structSelection, tfx, vectorUtils)

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS] win11
Browser [e.g. chrome, safari] chrome
Version [e.g. 22]

Ketcher version [e.g. v2.4.2].
"ketcher-core": "^2.20.0",
"ketcher-react": "2.20.0",
"ketcher-standalone": "^2.20.0",
"react": "^18.2.0",

Hi @Pandaaaa906
Could you please create example which reproduces the issue on github and provide the link? So that we will be able to investigate the root cause.

turn out that, an older version of ketcher-core appear in my lock file.
i'm closing this.


Hidden entries using MacPass

Hi @perfectapi
Thanks a lot for this useful extension.
I've added new entries in my .kdbx file by using MacPass 0.6 and since that, all my DB is hidden in CKP:

Any ideas?

Looks like base64 encoding.  Will have to investigate more...


supercompact AI crafting is broken

Description
it requires two separate inventory slots to be taken by capacitors, and after crafting, it will consume all the capacitors in both slots, be it 1 or 10
Reproduction

try craft supercompact AI chip with 2 or more capacitors in one slot (will fail)
try craft with 1 capacitor each in 2 slots (will succeed)
try craft with more than 1 capacitor each in 2 slots (will succeed but will consume all the capacitors)

using tag in crafting graphs is broken with stacks or something would be better name for the issue

should just be updated to use material instead of tags

I think this is the same as #29797 except the new part about it consuming all capacitors in both slots.


npm install -g firebase-tools

What does this PR do?
Which problem(s) does it fix and how? What does this PR add?
Where should the reviewer start?
Explain what should be set-up first in order to get the review started. Which page has to be viewed etc.
How should this be manually tested?

[ ] Write down all
[ ] the steps a person
[ ] needs to take to test it.

Documents
Screenshots (if appropriate)
If this PR changes something that concerns UI changes, please post before and after screenshots here.
Other documents
If you have any documents that have anything to do with this PR.
Who should be notified?

[ ] Write down the name/department this branch needs
[ ] to be communicated to
[ ] Check the box(es) to indicate that it has been
[ ] communicated (add the label)

What should happen on deployment? (check all that apply)

[x] The usual steps.
[ ] There are database changes, which should be run.
[ ] There are files that should be manually uploaded.

Questions:

Does this require a blog post?
Does this require a knowledge base update?
Does support need training for this?
Does this has to be communicated to partners?

close


Don't .unwrap() on invalid proxies

ack 3568b60612eecaa6c9e531132fe997d07cefb540

I'm going to apply this commit on top of 0.12.0 and release it as 0.12.1. Then also probably make a 0.13.0 release since it's been a while since we've merged the other stuff


Swift Support?

Are you in preparation or currently working on the RestKit for Swift variation?

Nope, but RestKit should work just fine in swift!


[release-1.8] Use consistent scope name in envoy json logs

This is an automated cherry-pick of #30793

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio_release-1.8
ee0bd7e685f9a7d45cbc8c08a621b30c2a1e8485
link
/test integ-pilot-multicluster-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio_release-1.8
ee0bd7e685f9a7d45cbc8c08a621b30c2a1e8485
link
/test integ-pilot-multicluster-tests_istio_release-1.8

integ-telemetry-mc-k8s-tests_istio_release-1.8
ee0bd7e685f9a7d45cbc8c08a621b30c2a1e8485
link
/test integ-telemetry-mc-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio_release-1.8


Inappropriate resource

hi folks
there's uri in your readme file which leads to a photo of a guy with a beer stored on a personal account. Looking weird and looking like a hidden try of a spam as orijtech appears to be a company. Should be changed probably to a thing more neutral, Storage logo or smth.

Thank you for the report! We'll get it removed.


[PE-D][Tester C] Incorrect notation in logic component in developer guide

Detail:
Association labels should not be use double angle brackets like <<call>>
Screenshot:

Labels: severity.Low type.DocumentationBug
original: hweinian/ped#7

is this true? potentially an inherited bug from AB3?


Custom texture resource with server/headless build does not load

Godot version
3.4.2-stable
System information
Ubuntu 20.04, AMD Radeon RX 6700 XT (21.40.1), Dummy
Issue description
A project with a custom resource that loads into an stex fails to load the resource with the server and headless binaries, blocking the program from running. Should custom resource loaders be used by the server binaries and if not, it should at least not block the program from running.
Error message seen:
$ ./Godot_v3.4.2-stable_linux_server.64 --main-pack packed_tex_test.pck -v
Godot Engine v3.4.2.stable.official.45eaa2daf - https://godotengine.org

CORE API HASH: 0
EDITOR API HASH: 0
Loading resource: res://default_env.tres
Loading resource: res://PackedTexTest.tscn
Loading resource: res://texture_data/HterrainServer_slot0_albedo_bump.packed_tex
ERROR: Failed loading resource: res://texture_data/HterrainServer_slot0_albedo_bump.packed_tex. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:270)
ERROR: res://PackedTexTest.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://texture_data/HterrainServer_slot0_albedo_bump.packed_tex
   at: poll (scene/resources/resource_format_text.cpp:412)
ERROR: Failed to load resource 'res://PackedTexTest.tscn'.
   at: load (core/io/resource_loader.cpp:206)
ERROR: Failed loading resource: res://PackedTexTest.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:270)
ERROR: Failed loading scene: res://PackedTexTest.tscn
   at: start (main/main.cpp:2011)
WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
     at: cleanup (core/object.cpp:2064)
Leaked instance: ViewportTexture:1291 - Resource path:
Leaked instance: BulletPhysicsDirectSpaceState:1293
Leaked instance: Image:1300 - Resource path:
Leaked instance: Environment:1297 - Resource path: res://default_env.tres
Leaked instance: Physics2DDirectSpaceStateSW:1290
Leaked instance: Image:1301 - Resource path:
Leaked instance: MultiplayerAPI:1294
Leaked instance: SceneTree:1287
Leaked instance: Viewport:1288 - Node name: root
Leaked instance: World2D:1289 - Resource path:
Leaked instance: World:1292 - Resource path:
Leaked instance: ProceduralSky:1296 - Resource path: res://default_env.tres::1
Hint: Leaked instances typically happen when nodes are removed from the scene tree (with `remove_child()`) but not freed (with `free()` or `queue_free()`).
ERROR: Resources still in use at exit (run with --verbose for details).
   at: clear (core/resource.cpp:417)
Resource still in use: res://default_env.tres (Environment)
Resource still in use: res://default_env.tres::1 (ProceduralSky)
Orphan StringName: tree_changed
Orphan StringName: _server_disconnected
Orphan StringName: network_peer_connected
Orphan StringName: _vp_unhandled_input1288
Orphan StringName: World2D
Orphan StringName: BulletPhysicsDirectSpaceState
Orphan StringName: _network_peer_connected
Orphan StringName: ProceduralSky
Orphan StringName: _network_peer_disconnected
Orphan StringName: node_added
Orphan StringName: World
Orphan StringName: Viewport
Orphan StringName: network_peer_disconnected
Orphan StringName: node_removed
Orphan StringName: Physics2DDirectSpaceStateSW
Orphan StringName: root
Orphan StringName: MultiplayerAPI
Orphan StringName: Environment
Orphan StringName: _vp_gui_input1288
Orphan StringName: _connection_failed
Orphan StringName: SceneTree
Orphan StringName: _vp_input1288
Orphan StringName: connected_to_server
Orphan StringName: node_renamed
Orphan StringName: connection_failed
Orphan StringName: Image
Orphan StringName: _vp_unhandled_key_input1288
Orphan StringName: _connected_to_server
Orphan StringName: ViewportTexture
Orphan StringName: server_disconnected
StringName: 30 unclaimed string names at exit.
ERROR: There are still MemoryPool allocs in use at exit!
   at: cleanup (core/pool_vector.cpp:63)

Steps to reproduce
In this particular case, it requires a custom resource that imports as a stream texture being applied as the material on a model. The project will run correctly until a server or headless binary is used to run the pck. It seems this has something to do with the Dummy video driver but am not sure how to track that down.
Minimal reproduction project
https://github.com/kruffin/packed_tex_test
packed_tex_test-master.zip

This likely occurs because Godot does not actually load texture data in headless/server builds. Methods that return texture size will typically return a size of (0, 0) and pixel data will always be considered fully black. Texture data is generally not needed in server exports, so this is done to save memory usage when running a dedicated server.
Having a way to read texture data in a server export would need to be implemented in a selective manner, as described in https://github.com/godotengine/godot-proposals/issues/2756.

Thanks for taking a look at this. Is there a way to mark this custom resource so that it doesn't try to load in headless/server builds?

Thanks again Calinou. I put together a small workaround for this here (https://github.com/kruffin/packed_tex_test/tree/workaround) The gist is I had to save the custom resource as a tres and optionally load it if not running on a server binary:
onready var mesh = $MeshInstance

func _ready():
	if !OS.has_feature("Server"):
		var mat = load("res://PackedTexTest.tres")
		mesh.mesh.surface_set_material(0, mat)


Replicate project error message is not correct

Problem description:
when user try to new a replication rule, he need to input source project name.
In this case, if user input a project name not exist. The error message will be:"Please add a project name",
this is not accurate.
Fix:
Modify the error message to "This project is not exist".
Plus:Modify the error popup using standard tooltip component.

Pull Request Test Coverage Report for Build 7791

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.05%) to 63.635%

Files with Coverage Reduction
New Missed Lines
%

src/common/scheduler/scheduler.go
2
81.29%

src/common/scheduler/policy/alternate_policy.go
3
80.29%

src/common/utils/utils.go
4
85.5%

Totals

Change from base Build 7790:
-0.05%

Covered Lines:
11908

Relevant Lines:
18713

💛  - Coveralls


Issue building f3d-git from AUR

Describe the bug
f3d-git AUR package fails to build in a clean chroot
System Information:

OS: Arch Linux
GPU and GPU driver: N/A

F3D Information
https://aur.archlinux.org/packages/f3d-git
Additional context
This was found due to a request to add it to Chaotic-AUR: https://github.com/chaotic-aur/packages/issues/1760
Build log after applying a missing dependency via https://github.com/chaotic-aur/interfere/commit/0096f72366a7e695423a3c7bdc7ded8ed47244b8:
f3d-git.log

Thanks for your reports. I've seen the other one on the f3d package. Would you be interested to be a co maintainer on both package ? TBH we are hardly using the package as we develop F3D, so it would make sence to have advanced users of F3D maintaining imo. Wdyt ?

Thanks, but I don't have any interest in using or maintaining this. I just want to make it available via Chaotic. Happy to help report any issues though. Once it's functional in a routine, you're welcome to utilize the automated build logs to ensure any updates you push to the AUR go smoothly within an hour of commit.

the automated build logs to ensure any updates you push to the AUR go smoothly within an hour of commit.

Could you elaborate on that ?

In the linked issue above, I committed this: https://github.com/chaotic-aur/packages/commit/5f9b1b333b8afb7debe1b7d0335224283c598e8f. It adds f3d to an hourly routine which checks if the AUR package has changed, which then does a rebuild if it has.
Once f3d-git is added, it will check for updates to both the AUR package and the git repo, and rebuild if there are changes to either. Packages are not added to a routine until they're building successfully.
You can find all the logs here: https://builds.garudalinux.org/repos/chaotic-aur/logs/
You can see more about Chaotic-AUR on the homepage: https://aur.chaotic.cx

I updated the AURs

There is a comment from @Technetium1 on f3d-git but I dont see it in the new PKGBUILD:

Missing utf8cpp in makedepends to build in clean chroot.

It is probably missing in f3d package too.

@mwestphal @Meakk utf8cpp is not required for f3d, but it definitely is for f3d-git, or else this:
-- Could NOT find utf8cpp (missing: utf8cpp_INCLUDE_DIR)
-- Plugin: assimp 5.2.4 found
CMake Warning at plugins/assimp/CMakeLists.txt:9 (message):
Plugin: assimp: Animations are not working with assimp 5.1.0 and newer, use
assimp 5.0.X for animation support with assimp formats.

-- Could NOT find utf8cpp (missing: utf8cpp_INCLUDE_DIR)
CMake Error at /usr/share/cmake/draco/draco-targets.cmake:83 (message):
The imported target "draco::draco_static" references the file

"/usr/lib/libdraco.a"

but this file does not exist.  Possible reasons include:

* The file was deleted, renamed, or moved to another location.

* An install or uninstall procedure did not complete successfully.

* The installation package was faulty and contained

"/usr/share/cmake/draco/draco-targets.cmake"

but not all the files it references.

Call Stack (most recent call first):
/usr/share/cmake/draco/draco-config.cmake:27 (include)
plugins/draco/CMakeLists.txt:3 (find_package)

-- Configuring incomplete, errors occurred!
See also "/home/main-builder/pkgwork/src/f3d/build/CMakeFiles/CMakeOutput.log".
==> ERROR: A failure occurred in build().

We can fix that in f3d-git but this is a draco package issue imo
https://archlinux.org/packages/community/x86_64/draco/

@mwestphal I agree, in the meantime it would be good to have it manually specified. :)

@svenstaro is the draco maintainer

It looks like there is a few other issues with draco, looking at it.

https://bugs.archlinux.org/task/76873
https://bugs.archlinux.org/task/76874

@svenstaro

f3d-git has been fixed but I had to add a compat package to make draco work

in case someone find this, f3d is now in community and draco has been fixed.


NcpBase: Ensure the sNcpContext is set.

This commit fixes issue where sNcpContext was NULL and the callbacks
to otNcpStreamWrite() would cause a crash.

Current coverage is 73.03% (diff: 100%)

Merging #1038 into master will decrease coverage by 0.19%

@@             master      #1038   diff @@
==========================================
  Files           126        125     -1
  Lines         18209      17961   -248
  Methods        2547       2522    -25
  Messages          0          0
  Branches       2220       2186    -34
==========================================
- Hits          13335      13118   -217
+ Misses         4183       4179     -4
+ Partials        691        664    -27

Powered by Codecov. Last update 917fd1d...b528386


Sync npm-shrinkwrap.json file

Fixes #122
This PR commits required changes to the npm-shrinkwrap.json file, allowing npm ci to produce a correct install.

Codecov Report

Merging #123 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop   #123   +/-   ##
======================================
  Coverage      100%   100%
======================================
  Files           21     21
  Lines         1432   1432
  Branches       194    194
======================================
  Hits          1432   1432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcdf82f...042362c. Read the comment docs.


[Documentation] Add documentation for DbOperationProvider.

This has been checked-in to the master branch and is now broadcasted to the actual documentation.