Generated connect.go package seems to have faulty imports

I'm pretty sure I'm doing something here, but I'm trying to swap out grpc-go with connect in a new service and the generated code seems to not be able to import the package that it's in.  The error screenshot is attached below:

The contents of the buf.gen.yaml are as follows:
version: v1
managed:
  enabled: true
  go_package_prefix:
    default: github.com/harshpreet93/1000x/backend/internal/gen
plugins:
  - name: go
    out: gen
    opt: paths=source_relative
  - name: connect-go
    out: gen
    opt: paths=source_relative

The contents of the buf.work.yaml:
version: v1
directories:
  - proto

The contents of the service.proto file is:
syntax = "proto3";
package buf.connect.thousandx.v1;
option go_package = "thousandx.v1";

service ThousandXService {
    rpc Login(LoginRequest) returns (LoginResponse) {}
    rpc RegisterProvider(ProviderRegistrationRequest) returns (ProviderRegistrationResponse) {}
    rpc RequestTask(TaskRequest) returns (TaskResponse) {}
}

message LoginRequest {
    string username = 1;
    string password = 2;
}

message LoginResponse {
    string token = 1;
}

message ProviderRegistrationRequest {
    string username = 1;
    string password = 2;
    string name = 3;
    string email = 4;
    string phone = 5;
    string address = 6;
    string city = 7;
    string state = 8;
    string zip = 9;
    // string country = 10;
}

message ProviderRegistrationResponse {
    string token = 1;
}

message TaskRequest {
    string token = 1;
    string task_id = 2;
}

message TaskResponse {
    string task_id = 1;
    string task_name = 2;
}

Do you know what would cause this problem? Please let me know if you need any other information.
PS: I love the idea of this project!

Thanks for all the detailed information - detailed bug reports are always appreciated.
Connect generates to a different package than the base types - the package will be at /GOPACKAGEconnect. See  https://connect.build/docs/faq/#why-generate-connect-specific-packages for why we do this. Let us know if you find it, and if this is sufficient.

It looks like you're generating to a different path than go_package_prefix. One is prefixed by internal/, the other is not. You may want either:
 managed:
   enabled: true
   go_package_prefix:
-    default: github.com/harshpreet93/1000x/backend/internal/gen
+    default: github.com/harshpreet93/1000x/backend/gen

or
 plugins:
   - name: go
-    out: gen
+    out: internal/gen
     opt: paths=source_relative
   - name: connect-go
-    out: gen
+    out: internal/gen
     opt: paths=source_relative

@lrewega @bufdev that worked! thanks for the quick help!!


Feature: Added Number-to-Words Transformation

Description
I have added the functionality to perform number-to-words transformation using the num2words library. I have added the unit test cases and dependency to the pdm.lock file.
Related Issue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[x] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[x] I've read the CODE_OF_CONDUCT.md document.
[x] I've read the CONTRIBUTING.md guide.
[ ] I've updated the code style using make codestyle.
[x] I've written tests for all new methods and classes that I created.
[ ] I've written the docstring in Google format for all the methods and classes that I used.

Hey @sagar118, unless you’ve already started looking into this, we can have someone from the team to take over and do the final changes :)

Hey @mattbit, I apologize for the delay. I have worked on it a bit. If it's okay with you I can continue working on it and get back to you ASAP. Is there a timeline you're looking for to wrap up this issue?

Some extraneous code that maybe you should check @kevinmessiaen (problems with the automatic merge?)

Fixed this, it was a merge issue indeed

Some extraneous code that maybe you should check @kevinmessiaen (problems with the automatic merge?)

Fixed this, it was a merge issue indeed


KAFKA-4869: Update <IP_ADDRESS> upgrade notes

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3775/
Test PASSed (JDK 7 and Scala 2.10).

Merged to 0.10.2, please close the PR.


we can deal with JSON_VERSION 11

Opening this to take a look.

@josiahseaman I think this is ready to merge. We should start the GO for version 11 here, as it won't break Schematize anyhow.

Ok, we will move all versions to 12.


[SPARK-49734][PYTHON] Add seed argument for function shuffle

What changes were proposed in this pull request?
1, Add seed argument for function shuffle;
2, Rewrite and enable the doctest by specify the seed and control the partitioning;
Why are the changes needed?
feature parity, seed is support in SQL side
Does this PR introduce any user-facing change?
yes, new argument
How was this patch tested?
updated doctest
Was this patch authored or co-authored using generative AI tooling?
no

merged to master


Hugo Error .Site.IsMultiLingual during npm run dev

Description
$ npm run dev

<EMAIL_ADDRESS>dev
hugo server --disableFastRender --noHTTPCache

Watching for changes in C:\Users\user123\Documents\Thulite\thulite-project{assets,content,layouts,node_modules,package.json,static}
Watching for config changes in C:\Users\user123\Documents\Thulite\thulite-project\config_default, C:\Users\user123\Documents\Thulite\thulite-project\config_default\menus
Start building sites …
hugo v0.136.4 windows/386 BuildDate=unknown
ERROR deprecated: .Site.IsMultiLingual was deprecated in Hugo v0.124.0 and will be removed in Hugo 0.137.0. Use hugo.IsMultilingual instead.
Built in 556 ms
Error: error building site: TOCSS: failed to transform "/scss/app.scss" (text/x-scss). Check your Hugo installation; you need the extended version to build SCSS/SASS with transpiler set to 'libsass'.: this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
Steps to reproduce
(I'm using Git Bash)

npm create thulite@latest

Follow all the guides until
Output:
Scaffolding project in C:\Users\user123\Documents\Thulite\thulite-project

Done. Now run:
cd thulite-project
npm install
npm run dev

Open new window (Already in thulite-project dir.)
npm install
npm run dev
Error come out

Expected result
Not Sure
Actual result
ERROR deprecated: .Site.IsMultiLingual was deprecated in Hugo v0.124.0 and will be removed in Hugo 0.137.0. Use hugo.IsMultilingual instead.
Environment
Paste the information here as shown by:
hugo -v
ERROR deprecated: --verbose was deprecated in Hugo v0.114.0 and will be removed in Hugo 0.137.0. use --logLevel info
Total in 2 ms
Error: Unable to locate config file or config directory. Perhaps you need to create a new site.
Run hugo help new for details.
$ node -v
v20.18.0
$ npm --version
8.19.4

Thanks! See also https://github.com/thuliteio/doks/discussions/1302 — expect a new release in about an hour

Fixed with @thulite/doks-core v1.8.0 and create-thulite v1.7.3


[Community poll] Hellish dependencies and a possible breaking change to fix it all

Due to the structure of Rust, and the still missing feture in stable of default impls that would allow to fix this issue entirely, this crate is constrained on many levels.
In theory for everything to be nice and easy, users should be able to implement OperationInput and OperationOutput on types as needed. This is no issue for types in one's own crate, however as soon as a dependency like axum and its many utility crates like axum-sqlx-tx need one of those traits it needs to be implemented either in this crate, or their crate.
Since only one version of crates can be implemented at once i am forced to use a fork of this library. It's possible quite a few of you do too.
Many of those types simply have no implementation for generating docs, and those who do need one must be implementable by the user's crate even on foreign types
I am proposing two new structs: NoDoc<T>(pub T) and WithDoc<T, D>(pub T, PhantomData<D>).
NoDoc<T>(pub T) simpy wraps a type and implements the traits like IntoResponse or FromRequestParts, etc... as is if T implements them and adds no doc, so it would be very useful for axum-sqlx-tx
async fn get_axum_request(NoDoc(mut tx): NoDoc<Tx<Postgres>>)  {}

WithDoc<T, D>(pub T, PhantomData<D>) is the same, but has D which is a user provided struct that proxies OperationInput and OperationOutput for T.

struct MyDoc;

impl OperationInput for Mydoc {
 ...
}

async fn get_axum_request(WithDoc(mut tx, _): WithDoc<Tx<Postgres>, MyDoc>)  {}

Other utilities like Deref Into AsRef, etc... will be provided, please tell me if there are any you with to see.
This will allow the separation and or deletion of the many unmaintainable feature gates into separate crates that can allow for better multi-version support
Thanks to @tamasfe i can make these changes, however such a fundamental change in how the dependencies are managed this is completely breaking for everyone and as such i would like the input of as many people that use this crate as possible.
@tamasfe i know you don't have the time, but since this is your crate i don't want to make big changes without your approval.

Other possible naming scheme: NoAPI and WithAPI
I tend to prefer this one, but seems less correct of a name.

I'm in favor of this change

Thank you @Wicpar! I'm perfectly fine with this, it definitely helps with libraries that are not aware of aide and makes overriding/hiding parameters easier in some cases.

Other possible naming scheme: NoAPI and WithAPI

I prefer these as well, since we have api_route, if we're fine with them not being symmetric, we could also go with something like Hidden<T>.
One more thing to note, I'd prefer following Rust's naming convention (e.g. NoApi).

All that remains now with the merge done is determine what to do with dependencies.
for axum-sqlx-tx i successfully used it like this:
use aide::NoApi;
use axum_sqlx_tx::Tx as BaseTx;

pub type Tx<T> = NoApi<BaseTx<T>>;

#[debug_handler(state = ServerState)]
async fn get_api_keys(
    mut tx: Tx<Postgres>, // previously defined tx
    session: Session,
) -> Result<Json<Vec<ApiKey>>, StatusError> {
    Ok(Json(
        query!("blablabla")
        .fetch_all(&mut *tx) // deref mut
        .await?,
    ))
}

the type definition could be made a crate, one for each version of axum-sqlx-tx as not all are compatible with the latest sqlx versions.


refactor: Remove outdated commands

Please examine this pull request carefully! I am not sure if I caught every single part of unused code and I am not sure if everything I deleted can be deleted safely. If I forgot something, please let me know.


Add dummy key cert for SDS server.

What's this for
For SDS, to follow gRPC compliance, we need a TLS key cert for transporting call credentials. This is a workaround, the final solution is gRPC relaxing the restrictions when transporting over a unix domain socket.
How I generate this cert
go run security/cmd/generate_cert/main.go  -host="spiffe:/istio.io/nodeagent-k8s/dummy"  -self-signed=true
Other changes:

Update the docker.node-agent-k8s to add these key cert into the Docker image.
Update the node agent default flag value.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
Assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JimmyCYJ @wattli

@justinburke

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
Assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly, quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
Assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly, quanjielin, wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


#282 Add strict po loader

Hi @oscarotero!
I did some initial updates to cover my needs.

I saw it was missing support for the "previous translation comment", so I've added the needed parts to the translator, generator and the StrictPoLoader.
About the strictness, I've tried to follow the rules of msgfmt -c (e.g. line break/whitespace is optional almost everywhere) 🫠
I was going to enhance the PoLoader, but it became too polluted with my checks and I decided to write a new parser...
I barely changed code to handle the comments and the headers.
I've tried to avoid using regexps, as the performance drops severely with large texts

I've tested some weird combinations, but forgot to move them to the unit test 🤦

Hi.
Thanks for this work!!
I'm not familiarized with the strict mode. What's the difference between strict mode and regular po? This will help me to understand the need to create a new different Po loader.

Hi!
There's no "strict" syntax, I just mimicked the behavior of the GNU tools, which I think is a good guide (given the documentation is missing details) :)
For example, the msgfmt works fine with this syntax (the new lines are required just to break comments):
msgctxt"context"msgid"message"msgstr"translation"

But it fails if you try to parse things in the wrong order, with an invalid msgstr index (out of order/out of bounds), bad escaping, etc.
So in theory this could replace the current PoLoader class, but it will introduce surprises (exceptions) for your users.
So I'll wait for your feedback. In order to decrease the pain, I could just add a flag, to swallow the exceptions by default, and continue to the next translation... But the input vs output of a defective file won't be the same as the current class.

Ok @oscarotero, I'm done with the performance fixes.
In a small dataset with 22 files (564KB) the time went from 4s to .47s, while the PoLoader is taking .25s.

Thanks @jonasraoni

If you think it's helpful, I could rebase the commits to mark the tests/BasePoLoaderTestCase.php as a file rename from tests/PoLoaderTest.php, just to improve the code history.

Yeah, it makes sense. But I think it's not so important, so whatever you want :)
One think that I would like is update the README.md file to include this new loader and explain the differences between both PO loaders (including also the difference in performance). As this info is more in your head, could you please add this latest change before merging?
Thanks so much!

@oscarotero I've updated the README and the CHANGELOG 👌

Thank you! 👍


Fail to build target with develop branch

I got the following issue when building with tip of the tensile branch develop@7e0f2dc5e5219d3af32a76857d4e8272e28068bf:
“
CMakeFiles/copy_kernels_miopentensile.dir/build.make:59: *** target pattern contains no '%'.  Stop.
CMakeFiles/Makefile2:105: recipe for target 'CMakeFiles/copy_kernels_miopentensile.dir/all' failed
make[2]: *** [CMakeFiles/copy_kernels_miopentensile.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs...
“

@ce1adon can we get a little more context please?
Is this coming from a clean build?
If so, can you please provide the full log?
Also, which docker image are you working with? Recent changes to targetid might have upset a few things.

@cgmillette Sure, I was building in MIOpenTensile with the tip of develop@7e0f2dc5e5219d3af32a76857d4e8272e28068bf.
To replay this issue,
git clone https://github.com/ROCmSoftwarePlatform/MIOpenTensile -b develop
cd MIOpenTensile
vi CMakelists.txt
find line 74 and change the tensile tag to 7e0f2dc5e5219d3af32a76857d4e8272e28068bf. Save and quit.
mkdir build
cd build
export HIPCC_LINK_FLAGS_APPEND='-O3 -parallel-jobs=4'
export HIPCC_COMPILE_FLAGS_APPEND='-O3 -Wno-format-nonliteral -parallel-jobs=4'
CXX=/opt/rocm/hip/bin/hipcc cmake ..
make -j check
Then you will observe this error.

This might have something to do with the targetid stuff that was checked in not too long ago. I will forward you an email about it.

@ce1adon does the new targetid docker base image fix the issue?

@cgmillette No, issue still there with the new docker image.

@ce1adon Apologies for the lack of response.  Can you please test with the latest ROCm 6.1.2? If issue is resolved, please the ticket. Thanks!

Hi @ce1adon,
I was able to build Tensile successfully on the latest ROCm version (6.2) using the below steps:

Install the dependencies available here: https://github.com/ROCm/Tensile/wiki/Dependencies
Clone the Tensile repository:

mkdir Tensile
cd Tensile
git clone https://github.com/ROCmSoftwarePlatform/Tensile repo
cd repo
git checkout master

I had to make a few edits to the ./Tensile/Configs/rocblas_sgemm_example.yaml file for it to be compatible with the latest version of Tensile, which you can find here:

GlobalParameters:
  MinimumRequiredVersion: 4.4.0
  PrintLevel: 1
  ForceRedoBenchmarkProblems: True
  ForceRedoLibraryLogic: True
  ForceRedoLibraryClient: True
  CMakeBuildType: Release
  EnqueuesPerSync: 5
  SyncsPerBenchmark: 3
  LibraryPrintDebug: False
  NumElementsToValidate: 128
  ValidationMaxToPrint: 4
  ValidationPrintValids: False
  ShortNames: False
  MergeFiles: False
  Platform: 0
  Device: 0
  KernelTime: True
  SleepPercent: 0
  DataInitTypeBeta : 0
  PrintSolutionRejectionReason: True # Route rejected configs to std out.
  PrintWinnersOnly: 0

BenchmarkProblems:
  ########################################
  # NN - standard
  ########################################
  -
    - # ProblemType
      OperationType: GEMM
      DataType: s
      TransposeA: False
      TransposeB: False
      UseBeta: True
      Batched: True

    - # BenchmarkProblemSizeGroup - standard
      BenchmarkCommonParameters:
        # Specify parameters that are to take a single value that is
        # the same for every solution.
        - KernelLanguage: ["Assembly"]
        - EdgeType: ["ShiftPtr"]
        - LoopTail: [True]
      ForkParameters:
        # Specify parameters with a set of values, yielding a
        # solution space spanning the cartesian product of all
        # parameter sets.
        - PrefetchLocalRead: [False, True]
        - PrefetchGlobalRead: [False, True]
        - ThreadTile:
          - [2, 2]
          - [4, 4]
        - WorkGroup:
          - [16, 16, 1]
          - [8, 8, 4]
        - WorkGroupMapping: [1, 4]
        - TransposeLDS: [0, 1]
        - LdsBlockSizePerPadA: [-1, 0, 64]
        - DepthU: [4, 8]
        - StoreVectorWidth: [-1, 1, 2, 4]
      BenchmarkFinalParameters:
        - ProblemSizes:
          # Specify the dimensions of the problems that the solutions
          # should be evaluated on.
          - Exact: [2048, 2048, 1, 4096]
          - Range: [ [128, 128, 128, 1408], [128, 128, 128, 1408], [1], [256, 512, 512, 2048] ]

# Specify appropriate parameters for your target device.
LibraryLogic:
  ScheduleName: "navi31"
  ArchitectureName: "gfx1100"

LibraryClient:

Build as follows:

mkdir build
cd build
../Tensile/bin/Tensile ../Tensile/Configs/rocblas_sgemm_example.yaml ./

Execute client as

./0_Build/client/tensile_client --config-file ./4_LibraryClient/source/ClientParameters_Cijk_Ailk_Bljk_SB.ini

Please edit the LibraryLogic with the appropriate ScheduleName and ArchitectureName for your target device.


do compile, ct runs the compilation step twice

should be a noop, but still it's a waste of time.

Eh.... not really possible.
compile runs only in the default profile when on its own. While ct runs compile in the default, test and ct profiles to make sure test deps are installed.

ah, I forgot about test deps, I guess.  still not fully on board with end to end build tools.


Permission denied (publickey). fatal: Could not read from remote repository.

💬 Question
This command npx react-native init JETAcademy --template @ui-kitten/template-js is giving the below error.
It sometimes gives. sometimes works.
Help me,

UI Kitten and Eva version

Package
Version

@eva-design/eva

@ui-kitten/components
4

ok, if i create react native project and install this later, it works. but for a new project creation it would. it gives me this error.

You're using an outdated react-native-cli package. See https://github.com/react-native-community/react-native-template-typescript/issues/80


Fix console spinner

Testing of the deployment hook can be removed from the CI file for now
Please fix grammar in console messages: "Compiling has started" -> "Compilation has started" and "Compiling finished" -> "Compilation finished"


Incorrect generic inference with "inherited" types

Bug Report
🔎 Search Terms
Generics, inheritance, nested.
🕗 Version & Regression Information
All versions tested, up to 5.1.0-dev.
⏯ Playground Link
Playground link with relevant code
💻 Code
type ParentType<T extends number> = unknown;
type ChildType = ParentType<5>;
type GetT<T> = T extends ParentType<infer U> ? U : never;

type Test = GetT1<ChildType1>;

🙁 Actual behavior
Type Test is equal to number rather than 5.
However, if T isn't unused in ParentType:
type ParentType<T extends number> = T;
// or
type ParentType<T extends number> = Array<T>;
...

–then Test becomes 5.
🙂 Expected behavior
Test should be 5 in all cases.

Working as intended.  Inference is done by working backwards structurally.  If you don’t use the type parameter then TS won’t be able to recover it through inference and you’ll just get the constraint, as you see here.
I should note that from TS point of view any ParentType<T> is also assignable to any ParentType<U>, for all T and U.  This is the nature of structural typing.

I see. Is there a way to include T in ParentType such that it does exist as a valid constraint? I can't think of a way to work around this, assuming that ParentType is actually independent of T.
From what you're saying, it seems like passing T up through (potentially many cascading types) and including it in the base type is the only way to do this. Is that right?

If ParentType is actually independent of T then the type parameter may as well not exist.  It won’t affect the type.  Think of it like the type equivalent of (x: number) => 0.  Once you’ve called the function, you can’t recover x - but it doesn’t really matter because the results are all interchangeable anyway.


[lz4] Update to version 1.10.0 and use the official CMake build system.

[X] Changes comply with the maintainer guide.
[X] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[X] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

libarchive stumbles over -llz4::lz4. Either it imports from a now-invalid pc file, or from now-invalid CMake package variables.

/azp run

The cmake namespace change (lz4::lz4 to LZ4::lz4, very unfortunate given the case-sensitive lz4package name) will also affect vcpkg user projects. Does it make sense to keeplz4::lz4` for a while to facilitate migrations?
Before starting and finishing this comment, I did https://github.com/lz4/lz4/issues/1179#issuecomment-2245364741.

Superseded by #40052. Thanks @dg0yt!


Importer

diff is too long, but aim already achieved : the importer has been extracted and is used only in tests.
Travis tests are passing for py2.
Merging.
Other problems (py3 problems) will be resolved in the original PR.


Add len and is_empty methods to Fields

There are a few situations where I've been using fields.iter().len(). This works, but having inherent len() and is_empty() methods would make things feel more idiomatic.

Why was this put into a patch release and not in a minor release if it's a new API? 😕


go over how we control admin privs on the bouncer

take stock of this, how we store whether users are admin or not, making sure there's always one admin user available, etc.
maybe we should have a cli command that just adds an admin user to the existing db for if the db gets a bit stuffed or if someone forgets their admin creds?

What would admin/regular user separation look like?
I think that the same method that 'The Lounge' uses could be appropriate here - start with no users by default, but expose a command that allows for user addition - something like bnc user add biox would feel right to me.


refactor: conversion button text styles

Is your request related to a problem? Please describe.

Yes, small problem.
Describe the solution you'd like

Text styles on button conversion wasn't the good one.
The change is:
contentPrimary -> contentAccent

duplicate #30


Look into different ways to substitute a bbox and zoom token

Tokens are well-established, with Mapnik making use of them too. All the same, they're still a hack that relies on parsing SQL as text and writing SQL carefully. SQL injection isn't a security worry here, since it's intentional the style author can write arbitrary SQL, but the same flaws with manipulating SQL as text lead to bugs when writing queries.
My inclination is towards prepared statements
The server would execute something like
PREPARE water (geometry(polygon, 3857), int) AS
  SELECT geom FROM foo WHERE geom && $1
;

This would be generated by taking the middle line from the style and surrounding it with the PREPARE and ;. water would be something derived from the layer and provider names and be unique.
A prepared statement could be made with pgx's func (*Conn) PrepareEx but requires knowing the oid of the geometrytype and might not allow specifying typmods.
func (*Conn) Exec can take a prepared statement name, e.g.
p.pool.Exec("water", bboxForTile, zoom)

Issues with prepared statements might be

Cached query plans. These are normally good, but a query used over the range of zooms where it goes between sequential and index scans would have problems. It might be necessary to prepare a query for each zoom.

Interactions with pgbouncer and pgpool. These can work with prepared statements, but something like PostGIS data type OIDs might change across them, leading to problems with PrepareEx.

This is related to #275

I did some more thinking and investigations. I started from a few assumptions

Users need to be able to input named parameters, not positional ones which will be hard to remember.
We don't have to maintain full backwards compatibility if we're dropping ST_AsBinary anyways
Syntax errors and missing tables need to be found on startup or config loading, not the first time a particular zoom is requested

Some background information

pg itself only supports positional parameters, but some client interfaces allow :foo parameters. pgx isn't one of them.
With nearly all style queries, using NULL for a bounding box will return zero results, and in geom && NULL is false, so exits quickly. It's also semantically correct, as the bounding box is either unknown or does not exist.

I recommend the following:
On startup do the following per layer
sql := strings.Replace(l.sql, ":bbox", "$1", -1)
sql := strings.Replace(sql, ":zoom", "$2", -1)
// etc for any other tokens in the future

prepare := `PREPARE "tegola_` + strings.Replace(l.name, `"`, `\"`, -1) + `(geometry(polygon, ` + l.srid + `), int) AS`
sql := prepare + "\n" + sql
// SQL instead of PrepareEx to allow for typmods
p.pool.Exec(sql);

Then for type sniffing, if required
// Not sure how to handle nulls in Go - pgtype is probably what's needed.
rows, err := p.pool.Query("tegola_" + strings.Replace(l.name, `"`, `\"`, -1), NullGeom, NullZoom)
if err != nil {
    return err
}

Then do magic with FieldDescription
Later, when running the query, run p.pool.Query("tegola_" + strings.Replace(l.name, ", ", -1), RealBbox, RealZoom)
The following seem relevant for PostGIS types:
https://github.com/cridenour/go-postgis
https://godoc.org/github.com/mc2soft/pq-types
But I figure others know Go + PostGIS better than I do, so I didn't dig extensively ;)


[SPARK-11117] [SQL] Makes PhysicalRDD aware of whether underlying data source produces UnsafeRow

This PR tries to address [this PR comment] 1. Changes made here:

Adds a new data source interface method BaseRelation.outputsUnsafeRows.
Overrides PhysicalRDD.outputsUnsafeRows to avoid unnecessary ConvertToUnsafe operator
Makes ParquetRelation always produce UnsafeRows.

In addition,  BaseRelation.needsConversion is deprecated by BaseRelation.outputsInternalRow. The reason is that I constantly find needsConversion confusing, and always need to double think what kind of conversion is actually needed.

Merged build triggered.

Merged build started.

Test build #43748 has started for   PR 9125 at commit 91c27be.

Merged build triggered.

Merged build started.

Test build #43749 has started for   PR 9125 at commit f236ce9.

Test build #43748 has finished for   PR 9125 at commit 91c27be.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43748/
Test FAILed.

Merged build finished. Test FAILed.

Test build #43749 has finished for   PR 9125 at commit f236ce9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43749/
Test FAILed.

Merged build finished. Test FAILed.

Oh, actually this PR depends on PR #9104, since #9104 makes partitioned Parquet table scans produce UnsafeRows while this one makes non-partitioned Parquet table scans produce UnsafeRows. That's the reason why the last Jenkins build failed. Will trigger again once #9104 gets merged.

retest this please

Merged build triggered.

Merged build started.

Test build #44057 has started for PR 9125 at commit f236ce9.

Test build #44057 has finished for PR 9125 at commit f236ce9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44057/
Test PASSed.

Closing this one since it's superseded by #9305.


Multi-Picture and Video Processing in Qwen2-VL (qwen2-vl-7B-instruct未来是否支持多图输入？)

I noticed in the Qwen2-VL blog that the model is capable of processing multiple pictures and videos in a single request. However, when I tried to use this feature with the customized VLLM and on the Tongyi.aliyun.com client website, it seems that this functionality is not supported.

Details

Blog Reference: The blog mentions that Qwen2-VL can handle multiple images and videos in a single request, as shown in the model architecture diagram. https://qwenlm.github.io/blog/qwen2-vl/
Customized VLLM: When using the customized VLLM, I was unable to find any documentation or examples on how to input multiple images or videos.
when try to send two pic at once we get:

{'object': 'error', 'message': 'At most 1 image(s) may be provided in one request.', 'type': 'BadRequestError', 'param': None, 'code': 400}

Tongyi.aliyun.com Client Website: Similarly, the client website does not seem to support the input of multiple images or videos in a single request.

Questions

Is the multi-picture and video processing feature currently supported in the customized VLLM and on the Tongyi.aliyun.com client website? If not, are there any plans to add this functionality in the future?
If the feature is supported, could you provide guidance on how to properly input multiple images and videos?

Additional Information

Model Version: Qwen2-VL-7B-Instruct-GPTQ-Int4(https://www.modelscope.cn/models/qwen/Qwen2-VL-7B-Instruct-GPTQ-Int4)
Environment: Customized VLLM(https://github.com/fyabc/vllm/commit/6f3116c9dad0537b2858af703938aa9bf6c25bcf), 网页版 通义千问2.5

Thank you for your attention to this matter. I look forward to your response. @fyabc

@ericzhou571 Hi, our latest version of vllm and docker image already support multiple images in a single prompt (add --limit-mm-per-prompt image=10 argument to vllm.entrypoints.openai.api_server).
vllm OpenAI API server does not support video input now, we are developing on it. You can run vllm locally to process videos.
You can see README for more details.

Hi, I am trying to use more than one image in a prompt and using this argument makes me run out of memory. Could you provide some insight in how to avoid this issue @fyabc ?
Thank you!


Make cloze field a little more obvious?

It's obvious in the documentation which field is a cloze, but not so much in the editor.
{{cloze:★ Key point (code block or image)}} could be made more obvious as to which field is a cloze in the editor. It might also be worthwhile adding an optional cloze to some other fields too?


VIP not released when service stopped

When the vip-manager service is stopped, the IP is not removed from the node.  Is there a way to make this happen?

As a temporary workaround, you could add a call to ExecStopPost in the service file...Test if the IP is still registered on the device, if true ip addr del...
ExecStopPost=-/usr/bin/ip addr del <IP-address>/<netmask> dev <interface>
``
(with a `-` to ignore failures) would probably be enough...

Making this idea more generic requires more thought.
The deregistering routine (for whichever configurer is used) could be called whenever a SigTerm is encountered.
But we don't always want to deregister the IP when stopping the process, for example during upgrades of the vip-manager.
So something like a maintenance mode (really similar to patroni) would be needed then

This workaround won't work for us, as we are using a systemd target file to allow for multiple instances, as indicated here: https://github.com/cybertec-postgresql/vip-manager/issues/18
I suppose that the systemd target could somehow read in the IP & netmask from the yml file based on the target name, but I'm not really sure how feasible that is.
I think that by default vip-manager should bring down the IP when stopped, as that would be the normal expectation for a service managing a resource.  Perhaps it could leave it up if killed via a specific signal?

Hi,
we use the vip-manger (together with patroni and consul) since november 2017 and where also a bit involved in vip-managers development.
We thought about that before as well but came to the conclusion that the vip-manager should only remove the IP by itself when it can reach the consensus (etcd/consul) and see that this specific node should not have the VIP anymore.
For cases like (accidential) shutdown or a process crash, the IP of the master should remain (in the case that the server with postgres still runs fine and only vip-manager crashed.
We also thought that vip-manager should not remove the IP when stopped so you can easily upgrade vip-manager without moving VIPs around.
Nevertheless i'm also open for a way (though a SIG) to tell vip-manager to remove the ip manually and then to stop it or create something like sysctl fullstop vip-manager which in contrast to stop would also remove the VIP.
What do you think?

I'd ultimately prefer systemctl stop<EMAIL_ADDRESS>to release the VIP.  If there's a way to make it send a custom signal on stop, that would work.  It could also work to have a startup flag to indicate that when stopped normally, the VIP should be released.

I think we shouldn't complicate this matter any more with special modes.
I agree with Martin that the current behaviour (not dropping the VIP) is a good baseline for the average user.
We may however implement the option to discern the signals sent to the process.
For SIGTERM (the default signal sent by systemd), the VIP will not be released.
For a SIGINT, the VIP would be remove if it had been registered. (Maybe making sure that it has actually been registered by this very process).
The vip-manager could track "have I added a VIP during my runtime" and if true, remove the VIP upon SIGINT.
This could also be helpful when trying to test something locally, where you might call the program directly on the shell. Pressing Ctrl+C would then make sure that the interface is also cleaned up.
On the other hand, it would be bad - if there is another vip-manager running - if somebody could remove the VIP registered by the other vip-manager just by calling vip-manager on the shell and then interrupting it. That's why I think we'd need to track if the IP has been added by the process itself.

vip-manager would be able to recover from that, since it checks if the VIP is still registered during each loop as long as it reads from DCS that it still should be registered...

Then, if you whish that the VIP is removed by default, you can set the KillSignal and RestartKillSignal accordingly in the service file.
Please let me know what you think about this approach and if you forsee any possible problems (especially considering that SIGINT is sent when running the program in a shell and then pressing Ctrl+C)...

Is this issue still need our attention?

I guess markwort’s question may have been directed at me?  I think it would be a good approach.  Setting KillSignal in the service file would be an easy workaround, and I could place a modified unit file when installing vip-manager.  In my workplace, the behavior of the IP staying up when vip-manager is up surprises everybody - everyone who has encountered this unusual behavior asks me about it and wants it to behave as expected.


refactor(node): simplify node controller's code

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @whalecold

Release note:

NONE

/lgtm

/cherrypick release-0.5


[HBASE-25536] Remove 0 length wal file from logQueue if it belongs to…

… old sources.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.


Rename undescriptive name suda#nopass to more descriptive name like suda#...something...

From https://github.com/lambdalisue/suda.vim/issues/61#issuecomment-1990924321
First of all, we need to clarify the behavior of suda#nopass to find a good name for it.

I wonder if we should change suda#nopass to force suda to give up if saving without a password doesn't work?
now we have the check if sudo true works, and then we try without a password, which removes much of the requirement for the current behavior of suda#nopass

The only notable issue I could see with this approach would be using different values for suda#executable, where this would then mean that suda will always ask for a password if suda#nopass isn't set, and will never ask if suda#nopass is set.
this would eliminate support for commands that cache credentials, like sudo does; but our support for other values of suda#executable is extremely rudimentary anyways.

suda#nopass adds the flag --non-interactive (or rather its short form -n) to the call to sudo. So it could be called that: suda#noninteractive.
Or, since it introduces a risk to cause non-working setups, you could call it suda#forcenoninteractive

suda#noninteractive (or suda#non_interactive) sounds good to me.


rename to denyH2cUpgrade

Please provide a description of this PR:
@howardjohn

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
5f65361432e7885da63e511a1f88c3f7b2158b07
link
unknown
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
5f65361432e7885da63e511a1f88c3f7b2158b07
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster


Make the menu  the labelled and controlled element in the header, rather than the
 within it

This brings the use of aria-label and aria-controls in the menu navigation in the header in line with other 'best practise' examples and guidance from W3C.
However, it's not as clear cut as I expected – notably it seems to stop 'Move to controlled element' working in JAWS/Chrome and means that the label is no longer announced in Safari on macOS and iOS. See 'Summary of changes to AT experience' for more details.
On balance, I think we should still make these changes as I don't believe any of these 'regressions' are major issues, but we should consider raising bug reports for them.
Move the label from the
 to the
Move the 'Navigation menu' label from the
 to the parent  element - this has previously been flagged as a 'possible misuse of aria-label'.
According to WAI ARIA Practises 1.2, it's recommended to label navigation regions, especially as 'if a page includes more than one navigation landmark, each should have a unique label'.
Lists can optionally be labelled, but this is only 'potentially beneficial for users of screen readers that support both list names and navigation among lists on a page'.
Applying the label to both the list and the parent navigation could be noisy – "Potentially a source of distracting or undesirable screen reader verbosity, especially if nested within a named container, such as a navigation region."
The provided examples also apply the label consistently to the navigation region (albeit using aria-labelledby).
Remove redundant 'navigation' from the nav label
In line with the section 'Composing Effective and User-friendly Accessible Names' in WAI-ARIA Authoring Practices 1.2, remove the word navigation from the aria-label on the navigation.

'Do NOT include a WAI-ARIA role name in the accessible name. For example, do not include [..] the word "navigation" in the name of a navigation region. Doing so would create duplicate screen reader output since screen readers convey the role of an element in addition to its name.'

Without this change, assistive technologies report this as 'Navigation menu navigation'.
Also remove the word 'navigation' from the button that shows or hides the menu, as it also seems redundant – the word 'menu' should be descriptive enough for users to understand what it represents, especially when encountered inside a header landmark.
Associate the menu button with the  rather than the

The menu button is currently associated with the list inside the menu's navigation element through the use of aria-controls.
However, it's really the navigation itself that is being controlled, so it makes more sense to apply the navigation id to the nav than the list.
Because of the way the JavaScript uses aria-controls to find the toggled element, this also means that the govuk-header__navigation--open modifier class is being applied to the , so we also need to move the govuk-header__navigation and any navigationClasses passed to the component's macro to the .
Because we're now toggling the visibility of the navigation region itself, rather than the list within it, this also avoids having an empty nav region present on the page when on a mobile viewport with the menu closed.
Add a new govuk-header__navigation-list class to the list, and move the CSS required to reset the default user-agent list styles to this new class.
The margins can be simplified slightly – there was previously a margin: 0 in the same ruleset as the call to govuk-responsive-margin which meant that the margin was always 0 on mobile and 2 spacing points only on tablet and above, rather than being 'responsive'.
The extra margin being applied on tablet also appears to be a mistake, so switch to applying just applying the margin on desktop and above.
Summary of changes to markup
Before
<button type="button" class="govuk-header__menu-button govuk-js-header-toggle" aria-controls="navigation" aria-label="Show or hide navigation menu" aria-expanded="false">Menu</button>

        Navigation item 1

        Navigation item 2

        Navigation item 3

        Navigation item 4

After
<button type="button" class="govuk-header__menu-button govuk-js-header-toggle" aria-controls="navigation" aria-label="Show or hide menu" aria-expanded="false">Menu</button>

        Navigation item 1

        Navigation item 2

        Navigation item 3

        Navigation item 4

Summary of changes to AT experience
JAWS / Chrome
Changes are as expected, except move to controlled element no longer seems to work.
I don't think this should be a blocker, for three reasons:

aria-controls is poop
The navigation follows immediately after the menu button, so where 'Move to controlled element' does not work I'd expect the user to be able to find it immediately as they continue to navigate through the page. The menu is also marked up as a navigation region with a label that associates it with the button they just pressed.
The menu button and hidden menu are only used on mobile and tablet viewports, and on a laptop/desktop running JAWS I'd expect the majority of users to be seeing the site at a desktop viewport size. However, there may still be a higher than average number of users seeing the site at mobile/tablet viewport as partially-sighted users may be using JAWS in combination with zooming in to the page enough that it reflows to mobile/tablet.

We should consider investigating further and writing up a bug report with Freedom Scientific though.

Before
After

Behaviour when focusing menu button (mobile viewport)
Show or hide navigation menu button collapsed, to activate press enter
Show or hide menu button collapsed, to activate press enter

Behaviour when entering navigation region (by tabbing to first link)
Navigation region, navigation menu list with 8 items. Departments same page link.
Menu navigation region, list with 8 items. Departments same page link.

Behaviour when jumping to controlled element (Insert + Alt + M)
Move to controlled element, list, tab [visible focus                                             moves to the list inside the menu]
Move to controlled element, show or hide menu [visible focus remains on the menu button]

Appearance in list of navigation landmarks (Ctrl + Insert + R)
Banner -> Navigation
Banner -> Menu Navigation

Appearance in list of navigation landmarks with nav closed (mobile viewport)
Does not appear in list of landmarks
Does not appear in list of landmarks

Appearance in list of navigation landmarks with nav open (mobile viewport)
Banner -> Navigation
Banner -> Menu Navigation

NVDA / Firefox
Changes are what you'd expect.

Before
After

Behaviour when focusing menu button (mobile viewport)
Show or hide navigation menu button collapsed
Show or hide menu button collapsed

Behaviour when entering navigation region (by tabbing to first link)
navigation landmark Navigation menu list with 8 items Departments link
Menu navigation landmark list with 8 items Departments link

Appearance in list of navigation landmarks (Insert + F7)
Banner -> Navigation
Banner -> Menu; navigation

Appearance in list of navigation landmarks with nav closed (mobile viewport)
Does not appear in list of landmarks
Does not appear in list of landmarks

Appearance in list of navigation landmarks with nav open (mobile viewport)
Banner -> Navigation
Banner -> Menu; navigation

VoiceOver / Safari
The fact that the user has entered the navigation region is not announced when tabbing to the first link, so the label is no longer announced.
This might be something the user can customise through their verbosity preferences, but this seems in line with the rest of the behaviour – the fact the user has entered the navigation landmark is not announced, so it's expected that the label would not be announced either.

Before
After

Behaviour when focusing menu button (mobile viewport)
Show or hide navigation menu, collapsed, button
Show or hide menu, collapsed, button

Behaviour when entering navigation region (by tabbing to first link)
link, Departments, list Navigation menu 8 items
link, Departments, list 8 items

Appearance in list of landmarks rotor (VO + U)
Navigation
Menu navigation

Appearance in list of landmarks rotor with nav closed (mobile viewport)
Does not appear
Does not appear

Appearance in list of landmarks rotor with nav open (mobile viewport)
Navigation
Menu navigation

VoiceOver / Safari (iOS)
Although 'landmark' is announced – presumably referring to the navigation landmark – the label for it is not announced. Less sure about this one.

Before
After

Swiping to menu button
Show or hide navigation menu, button, end banner, collapsed. Double tap to expand.
Show or hide menu, button, end banner, collapsed. Double tap to expand.

Swiping to first link in navigation region
Departments, link, list start, navigation menu, landmark
Departments, link, list start, landmark

Swiping by landmark (rotor set to landmarks, swiping up/down)
Departments, link, list start, navigation menu, landmark
Departments, link, list start, landmark

Voice Control / Safari (iOS)
More or less what you'd expect, although it's worth noting that the user cannot trigger the menu using only the visible label ("Show menu") which appears to be a general limitation of VoiceOver where an element's accessible name does not exactly match the visible label. But this is an existing issue and I'm reasonably confident that a user would be able to work around it using either 'show names' or 'show grid'.

Before
After

Responds to 'Tap menu'
No. Only 'Tap show or hide navigation menu'
No. Only 'Tap show or hide menu'

Name shown when 'Show names'
Show or hide navigation menu
Show or hide menu

Summary of changes to design
The design should remain the same, except:

on tablet, remove the margin after the navigation list to match the lack of a margin mobile.
on mobile and tablet, remove the bottom border from the last item in the menu.

Before

After

Closes #1340

Raised as a draft for now – still need to do testing and write up an entry for the release notes.

Still needs testing with Android / TalkBack.

Tested Talkback / Chrome (Android) with a Google Pixel 3 running Android 12
Before you cannot navigate to the menu navigation using the landmarks control unless the menu is already open.
Note also that by default Talkback doesn't give you the option to navigate by landmarks, the user has to enable it in the Talkback settings (see note on Deque university page starting "some ... reading controls are hidden by default").

Before
After

Swiping to menu button
Collapsed, "Show or hide navigation menu", button. Double tap to activate, actions available, use tap with three fingers to view.
Collapsed, "Show or hide menu", button. Double tap to activate, actions available, use tap with three fingers to view.

Swiping to first link in navigation region
"Departments", link. Double tap to activate, links available, use tap with three fingers to view.
"Departments", link. Double tap to activate, links available, use tap with three fingers to view.

Swiping by controls (reading controls set to 'controls', swiping up/down)
Collapsed, "Show or hide navigation menu", button. Double tap to activate, actions available, use tap with three fingers to view.

Swiping by landmark with menu collapsed (reading controls set to 'landmarks', swiping up/down)
Navigation.
Does not appear in list of landmarks

Swiping by landmark with menu expanded (reading controls set to 'landmarks', swiping up/down)
Navigation, "navigation menu", list.
"menu", navigation, list.

Testing commit Move button inside navigation region with Talkback / Chrome (Android)

Before
After

Swiping to menu button
Collapsed, "Show or hide navigation menu", button. Double tap to activate, actions available, use tap with three fingers to view.
Collapsed, "Show or hide menu", button. Double tap to activate, actions available, use tap with three fingers to view.

Swiping to first link in navigation region
"Departments", link. Double tap to activate, links available, use tap with three fingers to view.
"Departments", link. Double tap to activate, links available, use tap with three fingers to view.

Swiping by landmark with menu collapsed (reading controls set to 'landmarks', swiping up/down)
Navigation.
"menu", navigation.

Swiping by landmark with menu expanded (reading controls set to 'landmarks', swiping up/down)
Navigation, "navigation menu", list.
"menu", navigation, list.

This change looks really good! Think we just need to add something to the Changelog about the classes change?

Think we just need to add something to the Changelog about the classes change?

I've added a section to the changelog entry which I think should cover it?

Any additional classes passed using the navigationClasses Nunjucks option are now applied to the  rather than the
. Check that the additional classes are still doing what you expect.

@EoinShaughnessy are you happy with that latest addition to the release notes?


Properly formatted time column (hh:mm) displays as 1900-01-01 hh:mm

https://dex.edirepository.org/https%3A%2F%2Fpasta-s.lternet.edu%2Fpackage%2Fdata%2Feml%2Fedi%2F748%2F2%2Fe7209e56ec3548d0f5e5b7d4939018d
There are missing values in the tables, but they are correctly noted in the metadata

e

I forgot to mention, this is edi.748.2 in staging environment


Feature Request: Introduce annotation for request and limiting CPU and RAM

The sidecar container of the GCS FUSE CSI Driver can be configured using annotations in the pod:

gke-gcsfuse/cpu-limit
gke-gcsfuse/memory-limit

Applying those annotations will set the requests and limits to the same value. It would be nice, to be able to set both independently, so like:

gke-gcsfuse/cpu-request
gke-gcsfuse/memory-request
gke-gcsfuse/cpu-limit
gke-gcsfuse/memory-limit

That way it would make resource planning for our ML workloads much easier, because we could define what amount of memory will be pre allocated and what amount of memory can be used at maximum.

Hi @robert-ulbrich-mercedes-benz ,
Actually, we do support the pod annotations gke-gcsfuse/[cpu|memory|]-request.
Please make sure your cluster version is equal to or higher than the following versions:

1.25.16-gke.1268000
1.26.12-gke.1111000
1.27.9-gke.1092000
1.28.6-gke.1095000
1.29.0-gke.1381000

I am going to document this feature on the GKE documentation soon.
Please note that if you want to set the request but leave the limit unset, you need to explicitly set both annotations, for example:
gke-gcsfuse/memory-request: "512Mi"
gke-gcsfuse/memory-limit: "0"

Hi @songjiaxun,
thanks a lot for that information :). It makes sizing our workloads much easier if we can set the limit independent from the request :)


framework: fix crashes in gvr-shadows and gvr-simplephysics

there is a case where a rendertarget passes null as a rendertexture;
added a check for it

@apjagdale Please review

@liaxim Both demos now don't crash. But I noticed that in simple-physics the ball is not animated/thrown, it just sticks at the start position.

Planning to merge on Tuesday.

I tested with gvr-simplephysics and it works great. Thanks.


Add Catppuccin themes

Upstreams the https://github.com/catppuccin/giscus themes.

I'd like to make note that having to add a locale translation for even unsupported languages is a bit redundant. Would it be possible to update the i18n implementation to default to English if a key doesn't exist for a different language?

I'd like to make note that having to add a locale translation for even unsupported languages is a bit redundant. Would it be possible to update the i18n implementation to default to English if a key doesn't exist for a different language?

I'd love to but I don't think the library we use has an easy way to do it, or maybe I missed it.

Thanks, I tweaked the opacity/lightness of some of the colors to improve the contrast to meet accessibility requirements, hope that's OK.

That's fine, ideally you could make those changes in our template https://github.com/catppuccin/giscus/blob/main/src/base.css though and then update them here.


Add batch_size input to to_dense_batch

to_dense_batch doesn't work quite as expected if batches can also have 0 elements.  Add a param to handle this case.
Also adds a note about batch needing to be ordered.

Super. Thanks a lot!


Update sql-database-automated-backups.md

Removed the word "a" in first sentence: "SQL Database automatically creates a database backups..."

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@lpodkaminer : Thanks for your contribution to the Azure documentation! The author, @CarlRabeler, has been notified to review your proposed change.

@lpodkaminer
Great catch - thanks for the PR.
#sign-off


uncaught error crashes node-red

Received this initially, when having trouble discovering/registering my 2.0 bridge:
22 Dec 03:03:12 - [info] Starting flows
22 Dec 03:03:19 - [info] Started flows
22 Dec 03:03:56 - [red] Uncaught Exception:
22 Dec 03:03:56 - Error: ETIMEDOUT
at null._onTimeout (/home/pi/node-red/node_modules/node-red-contrib-hue/node_modules/node-hue-api/node_modules/request-util/node_modules/request/request.js:919:15)
at Timer.listOnTimeout (timers.js:92:15)

I found this when I upgraded nodejs from 0.12 to 4.2.3. I uninstalled both node-red and node-red-contrib-hue and the problem went away after reinstall.

Whilst this fixed a different issue, I found after a few minutes I received the same timeout error. Turns out what I had to do was delete the hue.config file in my .node-red folder and resync my bridge. After a diff I noticed the username had changed.

Ok, so for me this seems to have resolved by upgrading to nodejs v4.2.6, no other changes other than that! (of course rebuilt all node modules where applicable)


Build release failed

Im going to build the app for production, when I change the scheme to release I got the following error:

but when I build it to debug I dont have any errors

You'll need to add -lc++ to your projectTests target. See https://github.com/facebook/react-native/issues/11861

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


"Control Panel -> Configuration" License database URL is showing the password rather than URL

fixed in d92bd31 (as part of #1)


Use IMDSv2 to fetch instance hostname

Description
When attempting to install Calico for Windows on AWS instances that have no access to IMDSv1, a 401 Unauthorized error is logged when the script tries to fetch the hostname from the IMDSv1 endpoint.
This change means the installation script will now fetch instance metadata from the IMDSv2 endpoint.

/sem-approve


[dBTCH-438] [Maulik] change statsd gauge metrics to count for throughput

Looks good to me, we need to unify the naming conventions of metrics, we can do it as a separate fix.


Error 404 when setting wrong values

When first installing and setting wrong account info, the app doesn't show any error message nor the torrent list.
When debugging you got a 404 error code.

There is an issue when adding your account the first time, if by mistake you set your account wrongly (username or password), the app tries to connect several times without showing any error or message. Because these authentication failures the qBittorrent server bans your device's IP address. To check if you have been banned, try to reach your qBittorrent WebUI from your Android device browser.
To remove the ban and get connected, the workaround is the following:

Check your account settings (specially the password that is hidden)
Close the Android app completely. Even remove it from the recent app list.
Restart the qBittorrent WebUI interface (by disable/enabling or by closing/opening qBittorrent) to remove the ban.
Launch the app one more time. It

Fixed!


[DO NOT MERGE] Title of participant and serial for review app

Closing in favor of https://github.com/bm-sms/daimon-news/pull/601 and https://github.com/bm-sms/daimon-news/pull/602


Implement targets deps API's

Currently Forma supports dependencies in form of String's and projects.
However, project function name does not correspond to internal Forma terminology as well as using Gradle API's directly which should be minimized.
Solution here is to design and implement target(...) function to replace project.
Options:

Keep Gradle projects notation :parent:sub:project
Replace with Bazel-like notation \parent\sub\project
Support both, possibly with flags to favor one over another

May be you wanna to say \parent\sub\**target** for Bazeд-like notations? :)
For my opinion, we should move away from Gradle terms about project structures, "modules", dependencies. It will be better for development Forma abstraction concepts, structures, which not depends from any build systems and for better understanding too)
In that case, implementation by target(...) is good

Exactly my thinking, but since we are Gradle-only for now - my favorite option is 3 since it's less confusing for devs.
For Gradle tasks, you'll still need to use :parent:sub:project in the console, and for now there is not much we can do about it. Unless we'll have our own gradle wrapper🤪

@michaem thanks for a great idea. Started new discussion so we can work on it later https://github.com/formatools/forma/discussions/57


ID minter should only ever be running one instance at once

This is potentially problematic:
$ python dashboard.py
service      release ID                                           date started
-----------  ---------------------------------------------------  -------------------
api          0.0.1-0c173ef7de73afe5000629633c1e22fa81a53ffb_prod  2017-05-12 10:39:34
ingestor     0.0.1-0c173ef7de73afe5000629633c1e22fa81a53ffb_prod  2017-05-12 10:39:36
id_minter    0.0.1-1b3dac30850e1674f2b25b2568164f2068ecb087_prod  2017-05-12 09:22:46
id_minter    0.0.1-0c173ef7de73afe5000629633c1e22fa81a53ffb_prod  2017-05-12 10:47:07
transformer  0.0.1-0c173ef7de73afe5000629633c1e22fa81a53ffb_prod  2017-05-12 10:39:08

If the same item arrives at both ID minters, we could assign it two distinct “canonical” identifiers.

It would be better to ensure that if multiple ID minters are running at once, only one can do table updates. Perhaps we should do locking instead?
We have a special key __lock__ in the identifiers table. When the ID minter starts, it looks for the presence of this key:

If absent, it sleeps for 60 seconds and tries again
If present, it inserts the key and starts processing the event stream

When it shuts down, it goes in and deletes the key (if it was able to write one before being stopped).

Superseded by #358.


lmk points predictions is very bad.

i meet that the lmk points is hard to predict well. i want to konw do u train from scartch ?

The mirror augmentation might be wrong!


simulation consistency and viewing with multiple run and add

Hi,
I have an issue with mechanics_hdf5 simulation with multiple run and adding object into the scene
In the attached zip file multirun.tar.gz there are two python scripts that enable a simulation in two steps:

first step: a soup of primitives is deposed on the ground
second step : a new object is added as a projectile onto the soup of primitive.

Depending on the name of projectile,  the visualization of the scene is curious. It seems that the relation between the body and the shape are broken.
My guess is that if we add new object into the scene when a simulation is already into the hdf5, the numbering of the ds is not consistent with the position that have been read into the hdf5 file.

#448 is a first step to fix the issue

Fix and merge in a PR #448


[HIGH] Showing the paid invoice in the invoice room

Part of the Invoicing payments project
Main issue: https://github.com/orgs/Expensify/projects/114
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.drd9tmsdkoix
Project: https://github.com/orgs/Expensify/projects/114
Feature Description

Once an invoice is paid it should show accordingly in the UI
Manual Test Steps
Create an invoice, pay it and make sure it displays correctly
Automated Tests

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

Actively working on the issue. I've opened a draft PR (https://github.com/Expensify/App/pull/48014).

I've opened the PR (https://github.com/Expensify/App/pull/48014) for review 🙂

Awesome, thank you! Please let us know if you need any help!

Hey!
I will be OOO from 04.09 (afternoon) till 09.09. I will continue to work on this one once I am back.

I reviewed the related PR #48014. It was deployed to production on 9-Sep. Payment is due today.
@madmax330 Can you please assign a BZ for payment? Thanks!

@dylanexpensify  👋🏽  We only need to make the payment for the review here.
@c3024 do you get paid in upwork or expensify?

Payment summary:
Contributor+: @c3024 $250 via Upwork!
Please apply/request!

@c3024 apply here! 🙇♂

@dylanexpensify Thanks. Applied!

@dylanexpensify  I have applied

📣 @mitul69! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/mitulpatel116

@dylanexpensify, gentle bump on payment for this. Thanks!

On it - apologies!

Offers are waiting for acceptance @Krishna2323 @mitul69

Accepted @dylanexpensify. Only I need to be paid here for the reviewer role. The PR was handled by an external agency and no payment needs to be made for contributor role to anyone. Thanks!

nice paid!


Validations for new domains are disabled in the V1 API

What happened: Created new route and tagged it with the acme annotation, the openshift acme container says it can't register because the V1 API is now disabled.
What you expected to happen: Route to be updated with Let's encrypt cert
How to reproduce it (as minimally and precisely as possible): Create route, tag with acme annotation
I0710 14:16:24.017481       1 route.go:385] Started syncing Route "redirect/trymellowmag.com" (2020-07-10 14:16:24.017476622 +0000 UTC m=+276776.197613352)
Error syncing Route redirect/trymellowmag.com: failed to authorize domain "trymellowmag.com": 403 urn:acme:error:unauthorized: Error creating new authz :: Validations for new domains are disabled in the V1 API (https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430 )
--
Environment: All (prod/dev/auxiliary services)

OpenShift/Kubernetes version (use oc/kubectl version): o
c v3.9.0+ba7faec-1
kubernetes v1.9.1+a0ce1bc657
features: Basic-Auth GSSAPI Kerberos SPNEGO

@tnozicka

Redeployed from git and this resolved the issue.


Tabbar Items show More even though enough space is available when there are more than 7 Items

Hi,
We are using Sabbar on iPad and it shows more even though there is space available
Please find the attached screenshot for your reference

Hello,
that is caused by the number of tabs you add: we simply mirror the tabs present in the original UITabBar. On iPad no more than 7 tabs are show by iOS without the presence of more button. On iPhone the limit is 5.
It would make a great addition supporting more tabs, but it will require quite of work. If you have a proposal don't hesitate to send a pull request.
Thanks!


Cannot select in column after line 310

I'm using atom-sublime-select and I noticed that I cannot select in column after the line 310. Does anybody have this problem to ?
I use atom 1.13.1 on linux mint 18 cinnamon edition.

Possible duplicate https://github.com/bigfive/atom-sublime-select/issues/122

Yes it may be the same problem


Fix "/Schemas" endpoint; configurable default resources

Fixes https://github.com/RIPAGlobal/scimitar/issues/117
Implements https://github.com/RIPAGlobal/scimitar/issues/118
Drive-by README.md updates that were overlooked after some prior enhancements
Drive-by update to use standard Ruby debugger instead of byebug during development

great work here @pond, thanks for taking it on!


Requests to the path endpoint not working

The API is including the toString of the SzEntityIdentifiers instead of using their contents.
To Reproduce
Use any of the EntityGraphService.findPathByEntityId methods

Pull Requests:

https://github.com/Senzing/rest-api-client-ng/pull/10
https://github.com/Senzing/rest-api-client-ng/pull/11


Add ERCLC

Adding Eleanor Roosevelt Community Learning Center to the org folder.

@ddamko First stage of verification passed, official domain is erclc.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

Just checking the status on this. Thanks for your work on this.

@ddamko Regrettably, this organization seems to not be eligible for this repository. It is more like a training center, not a college, nor a university. Please ensure that you are familiar with this repository rules located at the bottom of this page.
Depending on the actual teachers' and students' needs we may suggest different free licensing options. Adding the domain does not seem the best on the first glance. Would you please send an email to<EMAIL_ADDRESS>referring to this request?
Besides please notice that PyCharm Community Edition and IntelliJ IDEA Community, which do not require any subscription regardless of what they are used for. They may be sufficient for your teachers and students needs.
You may also find better licensing option (which may also be free) at https://www.jetbrains.com/community/education/#courses.
I have to close this request without merging.  Thank you for your understanding!


Rifeljm/#622 walletconnect bypass readonly commands

[ ] Can we move the new "Skip Confirmation For All Readonly Commands" into the same box as "Skip Confirmation for Commands"?
[ ] Let's be consistent with the "readonly"/"read-only" wording. In the pairing dialog we use "read-only" but here it's "readonly". Let's go with "read-only".
[ ] If "Always Skip" is selected, we should hide the commands that are listed under the "Skip Confirmation for Commands" section.

The new bypass-readonly-commands localStorage item needs to be cleaned up properly when Disconnect, Restore, or Reset buttons are pressed:
⚠ NOTE: The Disconnect and Restore buttons should only remove the selected dapp's topic from bypass-readonly-commands. The Reset button should completely delete the localStorage item. ⚠

I'm seeing issues with the latest changes. Setting the checkbox to bypass readonly commands during pairing doesn't seem to take effect -- the walletConnectPreferences localStorage item isn't updated.


feat(Enterprise Billing Units): add start and limit parameters to billing unit APIs

PR summary

Adds start and limit parameters to support pagination for certain Enterprise Billing Units APIs
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Results can now be optionally paginated using the start and limit parameters.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Test results
Ran 56 of 64 Specs in 1.330 seconds
SUCCESS! -- 56 Passed | 0 Failed | 0 Pending | 8 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/enterprisebillingunitsv1        1.709s

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: Jdatechong:white_check_mark: swcolley:x: semantic-release-botYou have signed the CLA already but the status is still pending? Let us recheck it.

@Jdatechong Looks like the build for this PR also had lint errors. You can run make lint in the project root to run the linter on the code.  After fixing the issues, just commit and push to your branch.

Results from go test -tags=integration
••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 56 of 66 Specs in 1.168 seconds
SUCCESS! -- 56 Passed | 0 Failed | 0 Pending | 10 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/enterprisebillingunitsv1        1.998s

Results from go test -tags=examples
Ran 56 of 62 Specs in 1.179 seconds
SUCCESS! -- 56 Passed | 0 Failed | 0 Pending | 6 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/enterprisebillingunitsv1        1.456s

My guess is that the 10 int tests and 6 examples that were skipped are due to a missing config file for your service (i.e. enterprise_billing_units.env).  You can find this in the examples file:
//
// This file provides an example of how to use the Enterprise Billing Units service.
//
// The following configuration properties are assumed to be defined:
//
// ENTERPRISE_BILLING_UNITS_URL=<service url>
// ENTERPRISE_BILLING_UNITS_AUTHTYPE=iam
// ENTERPRISE_BILLING_UNITS_APIKEY=<your iam apikey>
// ENTERPRISE_BILLING_UNITS_AUTH_URL=<IAM token service URL - omit this if using the production environment>
// ENTERPRISE_BILLING_UNITS_ENTERPRISE_ID=<id of enterprise to use for examples>
// ENTERPRISE_BILLING_UNITS_BILLING_UNIT_ID=<id of billing unit to use for examples>

Results from the integration tests:
Ran 60 of 60 Specs in 36.241 seconds
SUCCESS! -- 60 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/enterprisebillingunitsv1        37.562s

Results from the examples:
Ran 57 of 57 Specs in 8.205 seconds
SUCCESS! -- 57 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/enterprisebillingunitsv1        9.537s

:tada: This PR is included in version 0.35.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Allow configuration via command-line

This would simplify many of the examples, especially for the common use case of the filesystem provider with no authentication.

This is possible via system properties as the Dockerfile demonstrates.  However we could better document this.


[sonarqube/stable] 8.4.2 - recommendations (kernel resources)

sonar-8.4.2 is out and has the following recommendations:
vm.max_map_ count is greater than or equal to 524288
fs.file-max is greater than or equal to 131072
the user running SonarQube can open at least 131072 file descriptors
the user running SonarQube can open at least 8192 threads
currently only the vm.max_map_count is supported by the init_container and has hard coded value to half of the recommended. The other ones are not currently supported in that init container.
more info -> https://docs.sonarqube.org/latest/setup/upgrade-notes/

@peppe77 These values are set in values.yaml and then used via init-sysctl.yaml:
initSysctl:
  vmMaxMapCount: 524288
  fsFileMax: 131072
  nofile: 131072
  nproc: 8192

I believe this can therefore be closed.


Add a mini-experiment that checks the runtime overhead in a tight loop

On my machine (very not-representative, Windows WSL) running run.sh returns:
bash:                                    0.005
PaSh_no_daemon:                          11.284
PaSh_daemon_bash_mirror:                 30.938
PaSh_daemon:                             5.447
PaSh_daemon_fifos:                       5.095
PaSh_daemon_par_pipelines:               2.702
PaSh_daemon_par_pipelines_fifos:         2.701

@tammam1998 check this out :)


⚠ Fetchers has degraded performance

In 849c7b0, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 275 ms

Resolved: Fetchers performance has improved in 448afc8.


Persist data using JS cookies, localStorage or any other mechanism that you deem appropriate.

This issue has been solved in 159a2f5e150bb8cc9d4150907a47d637732782c5 .


move manpages to subfolders

Any reason why hasn't been merged?

Sorry I haven't commented about this yet. I'm on the fence about this change. Let me think about it some more.

Sure, just wasn't sure if you noticed it. Take your time.


groupBy tests

should merge https://github.com/dmateusp/fs2-aws/pull/7 first

Pull Request Test Coverage Report for Build 35

43 of 57 (75.44%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+17.9%) to 65.263%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/scala/fs2/aws/kinesis/CommittableRecord.scala
6
7
85.71%

src/main/scala/fs2/aws/kinesis/KinesisSettings.scala
7
10
70.0%

src/main/scala/fs2/aws/kinesis/kcl.scala
12
22
54.55%

Totals

Change from base Build 19:
17.9%

Covered Lines:
62

Relevant Lines:
95

💛  - Coveralls


Move spdlog::logger to gz-utils

Draft of moving https://github.com/gazebosim/gz-common/pull/615 here.

add libspdlog-dev dependency inpackage.xml?

I just merged https://github.com/osrf/homebrew-simulation/pull/2729
@osrf-jenkins run tests please

PRs to add spdlog dependency in:

gz-utils3-release: Add libspdlog-dev dependency gazebo-release/gz-utils3-release#4
homebrew-simulation: gz-utils3: Add spdlog dependency osrf/homebrew-simulation#2729

also:

for windows https://github.com/gazebo-tooling/release-tools/pull/1163

add libspdlog-dev dependency inpackage.xml?

Do we need to add it even if it's a component? I don't see any dependency related with CLI11.

CI is not able to find spdlog. Do we need to add it to .githbub/ci/packages.apt?

Added.

add libspdlog-dev dependency inpackage.xml?

Do we need to add it even if it's a component? I don't see any dependency related with CLI11.

in my opinion we should add optional dependencies to package.xml

If we want to build a dependency from source in a colcon workspace, then the package.xml information should help with proper package build order (assuming the package name matches what we use in package.xml, see https://github.com/dartsim/dart/pull/1389)
I think we could eventually install dependencies using rosdep with the package.xml information instead of package.apt, so I think it's worth having there

Discussed this on a video call with Carlos, but the reason we don't have CLI11 in package.xml is that there was no binary package for it on Ubuntu Focal, which is also why we vendored it. I've created #135 to unvendor it and I think as part of that we should also add it to package.xml. We'll also need to add it to rosdep since there's no cli11 key there yet.
All of our platforms have system versions of spdlog available and there's already a rosdep key for it, so I think we should add it to package.xml.


feat: suggest the license to a repository from the license page

This PR implements #401 by adding a new "Suggest this license" feature in the sidebar of the license page. The user can input/search for a repository and, upon selecting it, open a PR for the inclusion of the license. The UI uses a autocomplete field with data from all unlicensed repositories in Github made via an XHR to the Search API.
This PR is based on the idea by @mlinksva in the comments of the issue, although a bit different.

Thanks @felubra! Glad to see this basically works.
The project selection/autocomplete seems a little finicky to me. I think maybe because it is only searching repo name, not the user/owner. I guess it would be possible to search by name and/or owner depending on what is typed in, and combine results when searching both, but it's probably hard to get exactly right.
Another way might be to not do any realtime lookup, but just take what user enters, do something with it upon hitting enter (initially only supporting full URL even), where something might be check that it is not licensed (glad you thought to filter for that, BTW) before sending on to the github.com license chooser?

@mlinksva thank you for the feedback!

Another way might be to not do any realtime lookup, but just take what user enters, do something with it upon hitting enter (initially only supporting full URL even), where something might be check that it is not licensed (glad you thought to filter for that, BTW) before sending on to the github.com license chooser?

I think this workflow is a better option, I will do something based on this. Thank you!

This is great @felubra! If it can avoid a popup (see my review comment) I think it just needs a tiny bit of documentation, which I can suggest.

@mlinksva after making the change you requested, I've noticed that the URL to suggest a license to a third-party repo is restricted to logged-in Github users. Any logged-out attempts to access it would result in a 404 error. I've prefixed it with the https://github.com/login?return_to=, so the user can log-in before going to the restricted page. Not sure if this is the right way to do this 😊

Hmm, 404 is definitely not a great experience. I don't think there's any way to detect if a visitor to choosealicense.com is logged into github.com, so guess the solution will have to be more up-front context, warning that one has to be logged into github.com?
Maybe in the case of a valid URL for a non-licensed repo, present a click-through that explains you need to be logged in -- in place of an error if you provide a non-valid URL or a licensed repo?

@felubra apologies, I failed to notice 2d3c449 or realize that return_to is a solution, I obviously did not read your comment closely, or think. 😳
Your suggestion for an explanation looks good to me. Thanks!

No problem 😊
I've added the explanation. Let me know if you need anything else.
Thanks!

Great, thanks @felubra! I'm pretty happy with this now. I'm going to leave it open a few days to give others a chance to give feedback, since this is in a way a pretty big feature for choosealicense.com, though it didn't take much code or UI real estate.

Just want to say thanks for taking action on this, @felubra!

Well I look forward to working with you more @felubra!


[ZEPPELIN-1003] Refactoring visualization

What is this PR for?
As one of task of https://issues.apache.org/jira/browse/ZEPPELIN-1003, refactoring visualization code in the front-end side.
This patch try to abstract visualization in OOP style, and want to provide the same API for Helium package in the future.
Please feel free to leave any feedback about the implementation.
What type of PR is it?
Refactoring
Todos

[x] - Abstract visualization

What is the Jira issue?
this resolves part of https://issues.apache.org/jira/browse/ZEPPELIN-1003
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

I have created following issue https://issues.apache.org/jira/browse/ZEPPELIN-1619 for further work.
This patch refactor build-in visualizations. Now most of codes for rending visualization took out from paragraph.controller.js and placed under zeppelin-web/src/app/visualization. And i think it's much more organized than before.
Please review this change

Merge if there're no further discussions.


[Update Request]:

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
SiarheiKuchuk.BUtil
Package Version
2024.10.25
Please describe the changes you would like to see
Changes

Old task format tasks are automigrated during load to the latest format.
After half a year old format version support will be dropped. Automigrate of old all tasks happens on load of UI apploication and on executing any task.
Old storage format will be upgraded to the latest. Format upgrade is repacking of 7-zip files in the storage.
During upgrade Storage Quota setting will be disregarded.
Upgrade is done by chunks by 50 files. It might take some time.
During uppgrade you can stop it at any moment but except during state upload (which might damage the backup index).
Upgrade is started on any task execution.
Old storage format will be dropped after half a year. You will need to use previous app version to open it.
If you have huge backup on slow remote NAS, consider recreating backup from scratch.
AvaloniaUI was updated to 11.1.4

Removed Features

Synchroniпzation mode subdirectory parameter is removed.
It is removed because in secure scenarios you need to create a separate account and separate storage for such tasks.
If you were using this parameter - edit and save sync task given that this param will be empty.

New Features

Possibility to specify minimum last write time for import of pictures.
Supported case: user moved to new PC and needs to import files he created after some point in the time.

Bug Fixes

SHA 512 hashes were not calculated.
! Hashes cache was inproperly calculated on adding new files.
If hashes cache had incorrect JSON, application failed to start task.

[!NOTE]
Close with reason: Resolved.

Resolved by #185745

CC @drweb86 @stephengillie