vscode shows any for types that are not any

VSCode Version: 1.40.2 (also tried 1.39 and insider)
OS Version: OSX 10.15.1

Steps to Reproduce: Unfortunately I have not yet been able to repo in an isolated test case.  It seems to be related to something in our private code base.

Does this issue occur when all extensions are disabled?: Yes
Basically, what we observe is that sometimes types in vscode are displayed as any when they should be some other type. This has been happening more frequently as our project has grown, and now happens often enough that developing in this code base is becoming quite painful.  It does not appear to be deterministic, and restarting vscode will often resolve these issues.   I am not sure if there is some timeout behavior that is causing this (I have not been able to find anything any documentation for this).

The above images show that the field function is displayed as any, but one of the properties of the first arguments has a type error.  This arg does not have any explicit types, and is inferred from the function that is reported as any in vscode.

Please share a minimal, reproducible example. Unfortunately we can't investigate this without one

One other thing to check: run the Developer: Toggle developer tools command in VS Code and look in the developer console. Are there any typescript related errors printed in there?

Good call on checking dev tools, it looks like there was an error:
ERR <semantic> TypeScript Server Error (3.7.2)
this.fileExistsWithCache is not a function
TypeError: this.fileExistsWithCache is not a function
    at Object.Project.fileExists (tsserver.js:134568:29)
    at Object.ConfiguredProject.fileExists (tsserver.js:135681:49)
    at tryGetModuleNameAsNodeModule (tsserver.js:99470:43)
    at tsserver.js:99306:88
    at Object.mapDefined (tsserver.js:565:30)
    at Object.getModuleSpecifiers (tsserver.js:99306:29)
    at getSpecifierForModuleSymbol (tsserver.js:37087:62)
    at tsserver.js:36953:39
    at Array.map (<anonymous>)
    at getSymbolChain (tsserver.js:36951:58)
    at lookupSymbolChainWorker (tsserver.js:36935:52)
    at lookupSymbolChain (tsserver.js:36928:24)
    at symbolToTypeNode (tsserver.js:37094:29)
    at typeReferenceToTypeNode (tsserver.js:36594:40)
    at typeToTypeNodeHelper (tsserver.js:36328:95)
    at addPropertyToElementList (tsserver.js:36741:59)
    at createTypeNodesFromResolvedType (tsserver.js:36687:25)
    at createTypeNodeFromObjectType (tsserver.js:36517:35)
    at visitAndTransformType (tsserver.js:36487:34)
    at createAnonymousTypeNode (tsserver.js:36442:36)
    at typeToTypeNodeHelper (tsserver.js:36367:28)
    at symbolToParameterDeclaration (tsserver.js:36884:41)
    at tsserver.js:36829:101
    at Array.map (<anonymous>)
    at signatureToSignatureDeclarationHelper (tsserver.js:36829:67)
    at createTypeNodeFromObjectType (tsserver.js:36506:49)
    at createAnonymousTypeNode (tsserver.js:36447:32)
    at typeToTypeNodeHelper (tsserver.js:36367:28)
    at addPropertyToElementList (tsserver.js:36741:59)
    at createTypeNodesFromResolvedType (tsserver.js:36687:25)
    at createTypeNodeFromObjectType (tsserver.js:36517:35)
    at createAnonymousTypeNode (tsserver.js:36447:32)
    at typeToTypeNodeHelper (tsserver.js:36367:28)
    at tsserver.js:36156:106
    at withContext (tsserver.js:36201:37)
    at Object.typeToTypeNode (tsserver.js:36156:28)
    at Object.getTypeNodeIfAccessible (tsserver.js:104180:27)
    at annotate (tsserver.js:121297:31)
    at annotateParameters (tsserver.js:121252:25)
    at doChange (tsserver.js:121201:25)
    at tsserver.js:121102:109
    at Function.ChangeTracker.with (tsserver.js:119320:17)
    at Object.getCodeActions (tsserver.js:121102:64)
    at tsserver.js:120361:121
    at Object.flatMap (tsserver.js:468:25)
    at Object.getFixes (tsserver.js:120361:23)
    at tsserver.js:131044:35
    at Object.flatMap (tsserver.js:468:25)
    at Object.getCodeFixesAtPosition (tsserver.js:131042:23)
    at IOSession.Session.getCodeFixes (tsserver.js:140677:64)
    at Session.handlers.ts.createMapFromTemplate._a.<computed> (tsserver.js:139462:61)
    at tsserver.js:140870:88
    at IOSession.Session.executeWithRequestId (tsserver.js:140861:28)
    at IOSession.Session.executeCommand (tsserver.js:140870:33)
    at IOSession.Session.onMessage (tsserver.js:140893:35)
    at Interface.<anonymous> (tsserver.js:142208:27)
    at Interface.emit (events.js:200:13)
    at Interface._onLine (readline.js:314:10)
    at Interface._normalWrite (readline.js:459:12)
    at Socket.ondata (readline.js:170:10)
    at Socket.emit (events.js:200:13)
    at addChunk (_stream_readable.js:294:12)
    at readableAddChunk (_stream_readable.js:275:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17): Error: <semantic> TypeScript Server Error (3.7.2)
this.fileExistsWithCache is not a function
TypeError: this.fileExistsWithCache is not a function
    at Object.Project.fileExists (tsserver.js:134568:29)
    at Object.ConfiguredProject.fileExists (tsserver.js:135681:49)
    at tryGetModuleNameAsNodeModule (tsserver.js:99470:43)
    at tsserver.js:99306:88
    at Object.mapDefined (tsserver.js:565:30)
    at Object.getModuleSpecifiers (tsserver.js:99306:29)
    at getSpecifierForModuleSymbol (tsserver.js:37087:62)
    at tsserver.js:36953:39
    at Array.map (<anonymous>)
    at getSymbolChain (tsserver.js:36951:58)
    at lookupSymbolChainWorker (tsserver.js:36935:52)
    at lookupSymbolChain (tsserver.js:36928:24)
    at symbolToTypeNode (tsserver.js:37094:29)
    at typeReferenceToTypeNode (tsserver.js:36594:40)
    at typeToTypeNodeHelper (tsserver.js:36328:95)
    at addPropertyToElementList (tsserver.js:36741:59)
    at createTypeNodesFromResolvedType (tsserver.js:36687:25)
    at createTypeNodeFromObjectType (tsserver.js:36517:35)
    at visitAndTransformType (tsserver.js:36487:34)
    at createAnonymousTypeNode (tsserver.js:36442:36)
    at typeToTypeNodeHelper (tsserver.js:36367:28)
    at symbolToParameterDeclaration (tsserver.js:36884:41)
    at tsserver.js:36829:101
    at Array.map (<anonymous>)
    at signatureToSignatureDeclarationHelper (tsserver.js:36829:67)
    at createTypeNodeFromObjectType (tsserver.js:36506:49)
    at createAnonymousTypeNode (tsserver.js:36447:32)
    at typeToTypeNodeHelper (tsserver.js:36367:28)
    at addPropertyToElementList (tsserver.js:36741:59)
    at createTypeNodesFromResolvedType (tsserver.js:36687:25)
    at createTypeNodeFromObjectType (tsserver.js:36517:35)
    at createAnonymousTypeNode (tsserver.js:36447:32)
    at typeToTypeNodeHelper (tsserver.js:36367:28)
    at tsserver.js:36156:106
    at withContext (tsserver.js:36201:37)
    at Object.typeToTypeNode (tsserver.js:36156:28)
    at Object.getTypeNodeIfAccessible (tsserver.js:104180:27)
    at annotate (tsserver.js:121297:31)
    at annotateParameters (tsserver.js:121252:25)
    at doChange (tsserver.js:121201:25)
    at tsserver.js:121102:109
    at Function.ChangeTracker.with (tsserver.js:119320:17)
    at Object.getCodeActions (tsserver.js:121102:64)
    at tsserver.js:120361:121
    at Object.flatMap (tsserver.js:468:25)
    at Object.getFixes (tsserver.js:120361:23)
    at tsserver.js:131044:35
    at Object.flatMap (tsserver.js:468:25)
    at Object.getCodeFixesAtPosition (tsserver.js:131042:23)
    at IOSession.Session.getCodeFixes (tsserver.js:140677:64)
    at Session.handlers.ts.createMapFromTemplate._a.<computed> (tsserver.js:139462:61)
    at tsserver.js:140870:88
    at IOSession.Session.executeWithRequestId (tsserver.js:140861:28)
    at IOSession.Session.executeCommand (tsserver.js:140870:33)
    at IOSession.Session.onMessage (tsserver.js:140893:35)
    at Interface.<anonymous> (tsserver.js:142208:27)
    at Interface.emit (events.js:200:13)
    at Interface._onLine (readline.js:314:10)
    at Interface._normalWrite (readline.js:459:12)
    at Socket.ondata (readline.js:170:10)
    at Socket.emit (events.js:200:13)
    at addChunk (_stream_readable.js:294:12)
    at readableAddChunk (_stream_readable.js:275:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)
	at Function.create (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:63732)
	at h.dispatchResponse (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:56670)
	at h.dispatchMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:55568)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:55044
	at l.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:47:207)
	at t.Reader.onLengthData (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:61946)
	at Socket.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:61594)
	at Socket.emit (events.js:200:13)
	at Socket.EventEmitter.emit (domain.js:471:20)
	at addChunk (_stream_readable.js:294:12)
	at readableAddChunk (_stream_readable.js:275:11)
	at Socket.Readable.push (_stream_readable.js:210:10)

So far I have not been able to create a repo, spent some time on it, but have not found a small subset of our code base that exhibits the same behavior.  But I may have some more time to get a smaller repo next week.

I am not sure the above error is related, reloading the editor, I don't see the same error, but I do still see that same behavior.  I'll update here if I find out anything else.

Same stack trace as https://github.com/microsoft/TypeScript/issues/35035 but I'm not sure it would cause this issue


Rename "Здраве на пациента" to "Анамнеза"

the title is clear enough.
also add new field called "Забележки"


fix: Improve parsing hyperlink like text

This PR should slightly improve performance issues reported in #550 and #570.

Thanks a lot, this fix made a huge difference on my system. I am using Orgmode to manage habits which produces a lot of state changes with timestamps, Neovim could freeze up for a long time (like 10 s or even more) before, but now such tasks are relatively quick to edit (typically below 0.5 s).


License ?

Hello, under what license is this project released under ? Thank-you.

It is under MIT license. I will update the repo to reflect that.


urbit play: updated with working batch size / loom settings

Updated #210. A few things still need to be unclobbered and I haven't tested the pill issue discussed in #157, but the play subcommand now works with custom batch sizes and loom (which was missing in  #192)  Needed this to speed up ~littel-wolfur's replay, and I'm running it on a copy now.

Superseded by #420


Suggestion: make sure the time remaining is always visible

A student complained that since the time remaining is shown below the list of questions in the nav bar, it's not visible in an exam with a lot of questions when you're scrolled to the top.
What can we do to make sure the timer is always visible?

This is a duplicate of #652


[dv] Fix 2 issues in top-level mem seq

limit the number of mem access
wait until all outstanding items are done

Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

CI hangs, but this should not affect it.
Merged it as I need this to fix top-level mem running extremely long in nightly regression.


Compiling the library with docker image fails. Cannot delete /project/src: Directory not empty

Issue template

Hardware description: Teensy 4.0
Installation type: Docker
Version or commit hash: foxy

I am trying to compile the library to use with custom messages. Following the tutorials I did the following:

Cloned the repository of the micro_ros_arduino
cd into micro_ros_arduino and added my custom message package into /extras
Used following docker commands to start the compilation
sudo docker run -it --rm -v $(pwd):/project --env MICROROS_LIBRARY_FOLDER=extras microros/micro_ros_static_library_builder:foxy -p teensy40

sudo docker pull microros/micro_ros_static_library_builder:foxy
However, it seems that it cannot overwrite files present in /src folder. I tried to manually removing files inside the /src, the whole folder altogether, but it seems to not work at all. Am I doing something wrong, or it is a bug in the compilation commands inside the docker image?
 Done
Building dependency tree
Reading state information... Done
184 packages can be upgraded. Run 'apt list --upgradable' to see them.
Creating firmware for generate_lib platform generic
.......
=== ./ament/ament_cmake (git) ===
Cloning into '.'...
=== ./ament/ament_index (git) ===
Cloning into '.'...
=== ./ament/ament_lint (git) ===
Cloning into '.'...
=== ./ament/ament_package (git) ===
Cloning into '.'...
=== ./ament/googletest (git) ===
Cloning into '.'...
=== ./ament/uncrustify_vendor (git) ===
Cloning into '.'...
=== ./ros2/ament_cmake_ros (git) ===
Cloning into '.'...

Resolving deltas: 100% (10160/10160), done.
=== ./control_msgs (git) ===
Cloning into '.'...
find: cannot delete ‘/project/src/’: Directory not empty

The error can be actually ignored, the problem is the docker builder argument -p teensy40.
You should use -p teensy4 instead:
https://github.com/micro-ROS/micro_ros_arduino/blob/cace9cc291359e6b2221bac3b0d11c250c885c2e/extras/library_generation/library_generation.sh#L14

@Acuadros95 Thank you and sorry for such a silly mistake. Everything works fine! Issue can be closed now.


The BitToggle component demo page issue

Toggles with custom label

What is the issue here?
I'm not seeing any issues 🧐

In the first example label, "Inline" is written incorrectly, when it is not

oh I see, the Inline is not written incorrectly but the label itself is misleading.
the label should be something like this: Custom Label for non-inline sample.


[AppConfig] Add aka.ms links from SDK exception messages to anchors in the TSG

1, Create an aks link to represent the TROUBLESHOOTING(TSG) guide
2. Use the new aks link in the common Exception type, and add it to the message.
You will find an example in Identity:
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientBase.java#L479
Should be similar in JS/TS language.

We've merged the PR to add troubleshooting link and released it last week. Closing the issue


Support Get External Task Error Details request

Camunda 7.13 have new API request - Get External Task Error Details
Please add it's support

Added https://github.com/jlucansky/Camunda.Api.Client/pull/66/


Revert "Issue 2001 - Upgrade DataSketches to 6.1.1"

Reverts gchq/sleeper#3488

Closing, as there are a number of changes we can keep to make it easier to change the version of DataSketches in the future.


Render listing buttons as components

For the first step described in https://github.com/wagtail/wagtail/issues/11915#issuecomment-2093342399.
Instead of manually rendering them via the parent dropdown component and a custom template, delegate each button's rendering to itself by making use of the default Button template added in 2274a44572b6b3d8a19bd4a1d4c893ab2b0d51ca and the {% component %} tag.
This allows the buttons inside the dropdown to have their own markup, e.g. to use a <button> element inside a <form> instead of <a>.
Remove the button button-small button-secondary CSS classes from the base ListingButton class. We'll assume instances of this class is rendered inside a dropdown, and hence do not need the extra CSS. If people still do need it, advise them to add it to the classname themselves.

Just saying I think this is a nice approach, I haven't run the code locally though but a bit more flexibility but also avoiding hard-coding links as buttons is helpful.
This may also lead to a pattern we can use for https://github.com/wagtail/wagtail/issues/11770 - currently we have no way to easily make the button component render a button, it will only ever render a (link). Aside from the naming and accessibility issues it makes it hard to provide a HTML solution where we could avoid a lot of JavaScript.

I don't know for sure what the better API is, but it could be something like: introduce a new MenuItem component to be the preferred thing to use as children of ButtonWithDropdown. and give ListingButton an as_menu_item method that returns a plain URL-with-label MenuItem. Then, as a deprecation path, ButtonWithDropdown will check if it's been passed a ListingButton instead of a MenuItem, and call as_menu_item on it if so.

@gasman There's a few challenges to this approach that ultimately I decided it's not worth pursuing. I did a different approach in #12211, which hopefully isn't as disruptive as this PR's original approach.


NestedScrollView.body with a Scaffold wrapped CustomScrollView disconnects outer from inner scroll view

Version
Flutter: 1.19.0-2.0.pre.83
Android: 8.0
Problem
I use NestedScrollView, CustomScrollView and SliverList in my ui. If I add controller to CustomScrollView, the nested scroll don't work correctly. (If it is no controller, the SliverAppBar will be scrolled)
Here is my code:
NestedScrollView(
  headerSliverBuilder: (c, s) => [
    SliverAppBar(
      forceElevated: true,
      pinned: true,
      expandedHeight: 200,
      title: Text(''),
      flexibleSpace: Padding(
        padding: EdgeInsets.only(left: 20, right: 20, top: kToolbarHeight + MediaQuery.of(context).padding.top, bottom: kToolbarHeight),
        child: Row(xxx),
      ),
      bottom: TabBar(
        controller: _controller,
        tabs: ['tab1', 'tab2', 'tab3'].map((t) => Tab(child: Text(t))).toList(),
      ),
    ),
  ],
  body: TabBarView(
    controller: _controller,
    children: [
      // tab1
      // tab2
      // tab3
    ],
  ),
);

// tab1:
Scrollbar(
  child: CustomScrollView(
    controller: ScrollController(),
    shrinkWrap: widget.shrinkWrap ?? false,
    physics: widget.physics,
    reverse: widget.reverse ?? false,
    slivers: [
      widget.topSliver ?? SliverToBoxAdapter(),
      SliverPadding(
        padding: widget.padding,
        sliver: SliverList(
          delegate: SliverChildBuilderDelegate(
            (c, idx) => widget.itemBuilder(c, widget.data[idx]),
            childCount: widget.data.length,
          ),
        ),
      ),
      widget.bottomSliver ?? SliverToBoxAdapter(),
    ],
  ),
);

flutter doctor -v:
$ flutter doctor -v
[√] Flutter (Channel master, 1.19.0-2.0.pre, on Microsoft Windows [Version 10.0.17134.1130], locale ja-JP)
    • Flutter version 1.19.0-2.0.pre at E:\Android\flutter
    • Framework revision 8abf0a6d8c (7 weeks ago), 2020-05-16 15:07:34 -0700
    • Engine revision aaf9e79f1d
    • Dart version 2.9.0 (build 2.9.0-9.0.dev<PHONE_NUMBER>)
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at E:\Android\sdk
    • Platform android-29, build-tools 28.0.3
    • ANDROID_HOME = E:\Android\sdk
    • Java binary at: E:\Program Files\Android\Android Studio 3.3.2\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[!] Android Studio
    • Android Studio at E:\Program Files\Android\Android Studio 3.3.2
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • android-studio-dir = E:\Program Files\Android\Android Studio 3.3.2
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] Connected device (3 available)
    • Google Nexus 5X Android 8 • <IP_ADDRESS>:5555 • android-x86    • Android 8.0.0 (API 26)
    • Web Server                • web-server           • web-javascript • Flutter Tools
    • Chrome                    • chrome               • web-javascript • Google Chrome 83.0.4103.116

! Doctor found issues in 2 categories.

Screenshot
Some ui is changed, but main framework is same with upper code
With controller: (appbar don't scroll)

Without controller: (scrolled nestly)

Other
By the way, I want to add fab to each TabBarView, but if I wrap CustomScrollView with Scaffold, this nest scrolling can't work all the time, include no controller. How could I implement this?
TabBarView(
  children: [
    Scaffold(
      body: CustomScrollView(xxx),
      floatingActionButton: xxx,
    ),
  ],
)

Reproduced with current master 1.20.0-3.0.pre.130.
Complete code sample
import 'package:flutter/material.dart';

void main() => runApp(MaterialApp(home: MyApp()));

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> with SingleTickerProviderStateMixin {
  TabController _controller;

  @override
  void initState() {
    _controller = TabController(
      vsync: this,
      length: 2,
    );
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return SafeArea(
      child: Scaffold(
        body: NestedScrollView(
          headerSliverBuilder: (c, s) => [
            SliverAppBar(
              forceElevated: true,
              pinned: true,
              expandedHeight: 200,
              title: Text('Title'),
              flexibleSpace: Padding(
                padding: EdgeInsets.only(
                    left: 20,
                    right: 20,
                    top: kToolbarHeight + MediaQuery.of(context).padding.top,
                    bottom: kToolbarHeight),
                child: Row(),
              ),
              bottom: TabBar(
                controller: _controller,
                tabs: ['tab1', 'tab2'].map((t) => Tab(child: Text(t))).toList(),
              ),
            ),
          ],
          body: TabBarView(
            controller: _controller,
            children: [
              Scrollbar(
                child: CustomScrollView(
                  controller: ScrollController(),
                  slivers: [
                    SliverList(
                      delegate: SliverChildBuilderDelegate(
                        (c, idx) => Text(idx.toString()),
                        childCount: 100,
                      ),
                    ),
                  ],
                ),
              ),
              Scrollbar(
                child: CustomScrollView(
                  slivers: [
                    SliverList(
                      delegate: SliverChildBuilderDelegate(
                        (c, idx) => Text(idx.toString()),
                        childCount: 100,
                      ),
                    ),
                  ],
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

SliverAppBar will be collapsed when scrolling second tab, where CustomScrollView doesn't have controller, but will not be collapsed when scrolling first tab, where CustomScrollView has controller.

@VladyslavBondarenko Thanks for your sample code. I think this code is already completed.
I have try it in 1.20.0-3.0.pre.142 and it also has this problem.

/cc @Piinks

NestedScrollView.body: CustomScrollView with its own ScrollController

This will not work with a NestedScrollView. Giving the inner scroll view (or the NestedScrollView.body) its own scroll controller will not work with a NestedScrollView. This is because the NestedScrollView creates and coordinates the scroll controllers on the inner and outer scroll views to keep them in sync and aligned correctly. See https://github.com/flutter/flutter/issues/11271. If you scroll the header directly, it will collapse, while the body scrolls independently. They have been disconnected by overriding the scroll controller. If you need to access these inner and outer controllers, the NestedScrollView.State documentation has an example.

NestedScrollView.body: Scaffold wrapping a CustomScrollView

This I haven't seen before. Will definitely investigate. I'm going to make this the primary issue here.

Any updates on this issue?

I think this issue has been resolved by https://github.com/flutter/flutter/pull/69795
OP had two issues

In the first tab, the inner scrollable was a CustomScrollView that was being provided its own ScrollController.

This breaks the NestedScrollView as it needs to create and manage the inner/outer scroll controllers. If you want to access the scroll controllers of the NestedScrollView creates, you can provide one to NestedScrollView.controller for the outer, or follow the sample code here to access the inner: https://api.flutter.dev/flutter/widgets/NestedScrollViewState-class.html

In the second tab, the inner scrollable was wrapped in a Scaffold.

I now believe that this was caused by the PrimaryScrollController that the Scaffold used to create. Any vertical scroll view that is not provided a ScrollController will attempt to use the PrimaryScrollController, so it effectively cut off the inner from the NestedScrollView, similar to the first tab. We moved the PrimaryScrollController out of the Scaffold in #69795, and running it today there appeared to be no issue.

The third tab did not have an issue and demonstrated the expected behavior.

There are more examples of the NestedScrollView in the API docs here: https://api.flutter.dev/flutter/widgets/NestedScrollView-class.html
Since I think this is resolved, I am going to close it for now, but if not feel free to re-open for further investigation. Thank you!


Use ResizeImage in ColorScheme._imageProviderToScaled and remove timeout

The timeout case should be handled by the caller of ColorScheme.fromImageProvider.
Note: the current impl where the listener is removed multiple times might result in the error Bad state: Stream has been disposed., as the stream attempts to remove the listener twice (once during image resolution and once when the timer expires)
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
https://github.com/flutter/flutter/issues/124806
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hey @gawsfbet can you sign the cla? This will likely need a test as well. Thank you for contributing!

Hey @gawsfbet can you sign the cla? This will likely need a test as well. Thank you for contributing!

Already done it, thanks!
This PR mainly consists of refactoring a private method, and I have modified existing tests according to the new behavior. Do I need to write additional tests as well?

This PR mainly consists of refactoring a private method, and I have modified existing tests according to the new behavior. Do I need to write additional tests as well?

Thanks a lot for the contribution! Yes, if there are any new behaviors, please add unit tests to cover that:) Please let me know once this PR is ready to review! I saw it's still a draft, so not sure whether I should start reviewing😄

Hi @QuncCccccc , the PR is ready for review now, thanks! With regards to the failing Google test, that particular test case that is failing is owned by my team so I will raise a fix for that before this PR is merged.

Hey @gawsfbet checking in from PR triage! Is this still waiting on resolving some Google failures?

I am going to close this PR, since we have not heard back in a while. Please do not hesitate to reopen it so we can land it if you'd like to come back! Thanks!


Disable seg-rep for fuzzy filter postings upgrade IT

Description
Test is flaky as seg-rep is causing issues during lucene codec upgrade. There is a separate test for seg-rep and upgrade. Disabling seg-rep in the fuzzy filter tests
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mgodwan with your change also, the integ test is failing.

@mgodwan with your change also, the integ test is failing.

Yes, I hadn't removed the assertion which verified all nodes have same segments in seg-rep mode. Verifying the doc count now only similar to other indexing tests with doc-rep mode.
Tests passed locally over 50 times.
Will monitor the ongoing checks on the PR

Failing test:
Tests with failures:
 - org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

This is marked flaky here: https://github.com/opensearch-project/OpenSearch/issues/9191

Test modified in this PR has passed: https://build.ci.opensearch.org/job/gradle-check/33366/testReport/org.opensearch.upgrades/IndexingIT/

@mgodwan am not opposed to this change but would like to understand more on the failure and where this differs with the segrep specific test. Do you have a link to a failed check due to codec upgrade with segrep? I would expect the segrep test to have similar flakiness then as the test is not currently setting the shard movement strategy to ensure primary shards move last.

@mch2 you can use this gradle check run to see the failure: https://build.ci.opensearch.org/job/gradle-check/33349/console
Essentially, the failure was due to primary shard writing segments with Lucene99Codec and replica on the older OS version node being unable to read the same
»  Caused by: java.lang.IllegalArgumentException: An SPI class of type org.apache.lucene.codecs.Codec with name 'Lucene99' does not exist.  You need to add the corresponding JAR file supporting this SPI to your classpath.  The current classpath supports the following names: [Lucene95, Lucene80, Lucene84, Lucene86, Lucene87, Lucene70, Lucene90, Lucene91, Lucene92, Lucene94]


Right side on ubuntu

I am on ubuntu and it looks like this. Right side of the terminal. It should display the hash code i suppose.

Are you still facing this issue? If yes, can you share your OS version and the terminal you are using?

@halfo No, i don't use it.


chore: test cleanup

This removes a file which should have been removed in #6611, and moves some tests to their own files in modules which are already too long, mostly to avoid having huge files.

Benchmark results
Metrics with a significant change:

protocol_circuit_witness_generation_time_in_ms (root-parity): 49.0 (-31%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256
5,604 (-1%)
1,544
707
767 (-1%)
774 (+1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,452
9,476
9,464

l1_rollup_execution_gas
616,093
616,117
616,105

l2_block_processing_time_in_ms
1,381 (+2%)
5,103
10,152

l2_block_building_time_in_ms
46,653 (-2%)
185,380 (-1%)
370,802

l2_block_rollup_simulation_time_in_ms
46,484 (-2%)
184,755 (-1%)
369,560

l2_block_public_tx_process_time_in_ms
25,543 (-2%)
104,187 (-2%)
213,893 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
10,067 (+2%)
15,246

node_database_size_in_bytes
14,491,728
21,352,528

pxe_database_size_in_bytes
18,071
29,868

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
protocol_circuit_simulation_time_in_ms
protocol_circuit_witness_generation_time_in_ms
protocol_circuit_proving_time_in_ms
protocol_circuit_input_size_in_bytes
protocol_circuit_output_size_in_bytes
protocol_circuit_proof_size_in_bytes
protocol_circuit_num_public_inputs
protocol_circuit_size_in_gates

private-kernel-init
160 (+1%)
3,685 (+2%)
21,983 (-2%)
19,990
61,798
86,720
2,643
1,048,576

private-kernel-inner
605
4,270 (+2%)
49,077 (+1%)
88,862
61,798
86,720
2,643
2,097,152

private-kernel-tail
531 (+1%)
2,876 (+2%)
35,227 (+1%)
86,653
76,438
10,624
265
2,097,152

base-parity
6.53
1,229
2,888 (-1%)
128
64.0
2,208
2.00
131,072

root-parity
49.6
:warning: 49.0 (-31%)
43,806
27,084
64.0
2,720
18.0
2,097,152

base-rollup
782 (-2%)
2,298
73,841
119,578
756
3,648
47.0
4,194,304

root-rollup
114 (-2%)
66.1 (+2%)
19,304
25,297
620
3,456
41.0
1,048,576

public-kernel-app-logic
525
2,911 (+2%)
47,769 (+3%)
103,405
84,766
116,832
3,584
2,097,152

public-kernel-tail
1,195
26,304 (+2%)
155,234
393,850
7,490
10,624
265
8,388,608

private-kernel-reset-small
581 (+1%)
2,408 (+8%)
24,700
118,173
61,798
86,720
2,643
1,048,576

merge-rollup
28.8
N/A
N/A
16,534
756
N/A
N/A
N/A

public-kernel-setup
630 (+1%)
N/A
N/A
103,405
84,766
N/A
N/A
N/A

public-kernel-teardown
535 (+2%)
N/A
N/A
103,405
84,766
N/A
N/A
N/A

private-kernel-tail-to-public
N/A
9,602 (+2%)
81,621
N/A
N/A
116,832
3,584
4,194,304

Stats on running time collected for app circuits

Function
app_circuit_proof_size_in_bytes
app_circuit_proving_time_in_ms
app_circuit_size_in_gates
app_circuit_num_public_inputs

SchnorrAccount:entrypoint
16,128
46,136
2,097,152
437

Token:transfer
16,128
43,158 (+1%)
2,097,152
437

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.3
18.4
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.661
0.566
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
52.4 (-1%)
81.2
263
504
992
1,961
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.536 (-1%)
0.501
0.477
0.471
0.469
0.468
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
62.7
119
379
741
1,475
2,936
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.544
0.535
0.514
0.510
0.509
0.510
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
66.9

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
107

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.594

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
82,705
664,768

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
11,122
4,216
70,003

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
3,227
2,135
6,078 (+1%)
2,303 (+1%)
2,603 (+1%)


Demonstrate unexpected timeout behaviour when sources are slow

Hello! I'm raising this to highlight an error that took me several days to debug, as it didn't seem to make any sense. I'm more than happy to work on a fix for this, but wanted to raise this PR to give a starting point for any discussions about it, as it's a bit of a weird one :)
The test here results in the following test error:
$ mix test
Compiling 1 file (.ex)
.................

  1) test fails silently and returns an empty map of sources if things timeout (DataloaderTest)
     test/dataloader_test.exs:22
     Assertion with == failed
     code:  assert dataloader == new_dataloader
     left:  %Dataloader{options: [timeout: 1], sources: %{test: %Dataloader.TestSource{batches: [], opts: [], results: %{}}}}
     right: %Dataloader{options: [timeout: 1], sources: %{}}
     stacktrace:
       test/dataloader_test.exs:31: (test)

Finished in 0.6 seconds
18 tests, 1 failure

Randomized with seed 153869

This demonstrates the fact that if a Source times out, we don't return
an error but rather just drop it from the map of sources in our
dataloader. The problem with this is that it leads to unexpected
behaviour when we hit a timeout.
Using the example from the moduledoc:
    # Normal setup
    source = Dataloader.Ecto.new(MyApp.Repo)
    loader = Dataloader.new |> Dataloader.add_source(:db, source)
    loader =
      loader
      |> Dataloader.load(:db, Organization, 1)
      |> Dataloader.load_many(:db, Organization, [4, 9])

    # It's entirely possible that the `Source` will timeout here, and if
    # so then this returns a loader that looks like `%Dataloader{sources: %{}}`
    loader = Dataloader.run(loader)

    # This call raises an error: `Source not found: :db`. This is
    # because there is no `:db` source anymore
    organizations = Dataloader.get_many(loader, :db, Organization, [1,4])

There are two issues to resolve here as I see it:

We shouldn't be silently dropping sources if they timeout, we should
handle that case in pmap and either raise or return an appropriate
error tuple
The default timeout for Dataloader should be slightly higher than
the maximum default of all its sources, and it should be documented that
if you set the timeout option, it must be higher than all sources,
possibly even enforced

This PR is irrelevant since #36, closing


Probe system for custom cfitsio location

Use the pkg-config crate

Coverage remained the same at 1.57% when pulling 2f15eb52dd7097bca457790759452239e1954a8e on pkg-config-for-compiling into 137c04b671a05829ca339c38a24052d77dc12b1b on master.


Use parameters in routes

Is it possible to use parameters in the routes just like iron-router provides {{pathFor 'profilePage' _id=userId}}?

For this {{isActiveRoute 'home'}} syntax I don't think I support that right now, one thing you could do is this {{isActiveRoute name='home' _id=userId}}.
I'll look into supporting that kind of syntax you talked about and see what I can do.

I'll keep this open until I've had a look at supporting the syntax you talked about, because I've actually been thinking about that before.

So thinking about this, did you mean that support for parameters that would match against the route's parameters and only return the active class if they also matches? or did you mean for the helpers settings parameters like class and regex? or maybe both?

How was it implemented?
In my case I want to check if the route parameters match against the specified parameters. Is this possible right now?

Oooh, my bad. I only solved half the issue. I now support adding parameters to the syntax you talked about, but I don't check if any of the parameters match the route's parameters and use that to do specific matching.
I've been thinking about implementing this, but as you can use {{isActivePath pathToMatch}} where pathToMatch is a template helper which returns the specific route's uri with the _id to match against.
I didn't implement parameter specific matching with isActiveRoute, but enough people have been asking about it so I'll re-open this issue and track the feature here.
Here's another way of doing the same thing.

{{linkTo route='profilePage'}}

Template.<name>.helpers({
  path: function() {
    return 'user/' + this._id;
  }
});

I never ran into this problem because I usually have 2 routes, profile and showUser, which uses the same templates to show a users profile. The difference here is that when I wanna link to the "me" page I just match against profile with isActiveRoute instead of needing to match against a specific user.
But I can see the need to this convenience functionality.

I see... In my case I have a "iPad-like" Master-Detail view with a list on the left side. On the right side is the content of the active item in the list. Each item have the same route but a different _id parameter.
With iron router's pathFor it's very easy to create a link to the item's route
{{name}}

pathFor automatically match the parameters of the route with the properties of this. It would be very cool to have the same behaviour with isActiveRoute.

So, I actually implemented the data context inheritance, but as a lot of people had objects in the data context which had class and route properties. So I realized that this wasn't a good fit for this package.
But when I'm implementing the specific matching part with parameters, I'll look into inheriting from the data attribute like so. {{isActiveRoute 'item.detail' data=this}}, where this have _id which will be used for specific matching.
However, after this is implemented and you feel that you really want the data context inheritance we can open a new issue to track that. I could most likely add that again but as an opt-in feature. i.e. ActiveRoute.config({ inheritData: true });

This should be possible now with version 2.3.3-rc.1
{{isActiveRoute 'showUser' _id='1241251'}}
{{isActiveRoute 'showUser' data=currentUser}}

Zimme I've updated to 2.3.3-rc.1 and tried to match the route /profile/:position and url /profile/test
{{isActiveRoute 'profile' position="test"}}  returns empty
{{isActiveRoute 'profile'}} returns "active"
Is there something I need to do more?

Hmm, should work with the latest rc, can't really reprod now as Im on vacation. Ill try to get to it as soon as possible

There is actually an optional language route group over this. so real url is /:lang/profile/:position maybe this breaks something?

Most likely
On Wed, Mar 16, 2016, 9:17 PM ipa1981<EMAIL_ADDRESS>wrote:

There is actually an optional language route group over this. so real url
is /:lang/profile/:position maybe this breaks something?
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/zimme/meteor-active-route/issues/31#issuecomment-197269369

hey, what if i use iron router and my url has query like achievements?type=differentType,
how do i make it "active"

hey, what if i use iron router and my url has query like achievements?type=differentType,
how do i make it "active"

Use the isActivePath helper.

Hi, i would like to be able to use {{}} in class attribute like so:
			ul.nav.navbar-nav 				li.(class="{{isActiveRoute regex='quickform'}}") 					a(href='/quickform') quickForm Playground
How to make it work? Thanks

There's a problem with the latest stable version of this package and Meteor 1.4+ versions where template helpers for blaze don't seem to be working properly.
See issue #52.

You could try the new activeroute:core, activeroute:iron-router/activeroute:flow-router and activeroute:blaze packages that I'm created which are more modular and should work properly with Meteor 1.4+.


Update README.md

Closes https://github.com/azat-co/expressworks/issues/35#issuecomment-68567182

@morenoh149 thank you!


Remove the temporary README.rst

During docs generation we copy README.rst to doc/ and clean it up
a bit. Lets delete afterwards.

Magic.


<EMAIL_ADDRESS>

organization#reviewing-and-revoking--fine-grained-personal-access-tokens">Reviewing fine-grained personal access tokens" and "Managing requests for fine-grained personal access tokens".
]]></content:encoded>
	<post-id xmlns="com-wordpress:feed-additions:1">68429</post-id>	</item>
	<item>
	<title>Dependabot alerts enterprise-level REST API</title>
	<link>https://github.blog/changelog/2022-11-01-dependabot-alerts-enterprise-level-rest-api</link>

	<dc:creator><![CDATA[Kevin Duck]]></dc:creator>
	<pubDate>Tue, 01 Nov 2022 17:54:52 +0000</pubDate>
			<guid isPermaLink="false">https://github.blog/changelog/2022-11-01-dependabot-alerts-enterprise-level-rest-api</guid>

				<description><![CDATA[Dependabot alerts enterprise-level REST API]]></description>
									<content:encoded><![CDATA[
You can now retrieve all your Dependabot alerts at the GitHub enterprise level via the REST API. This new API endpoint supplements the recently introduced Dependabot alerts REST API, Dependabot alerts org-level REST API, and Dependabot alerts webhook.

For more information, see Dependabot alerts in the REST API reference or learn more about Dependabot alerts in our documentation.
]]>
	<post-id xmlns="com-wordpress:feed-additions:1">68390</post-id>	</item>
	<item>
	<title>GraphQL APIs for creating a branch linked to an issue</title>
	<link>https://github.blog/changelog/2022-10-31-graphql-apis-for-creating-a-branch-linked-to-an-issue</link>

	<dc:creator><![CDATA[Kevin Duck]]></dc:creator>
	<pubDate>Mon, 31 Oct 2022 16:11:22 +0000</pubDate>
			<guid isPermaLink="false">https://github.blog/changelog/2022-10-31-graphql-apis-for-creating-a-branch-linked-to-an-issue</guid>

				<description><![CDATA[GraphQL APIs for creating a branch linked to an issue]]></description>
									<content:encoded><![CDATA[
We've added GraphQL API support for creating a branch linked to an issue. Learn more about creating a branch for an issue in the UI in the documentation.

The GraphQL API supports:

Creating a branch linked to an issue
Removing the link between a branch and an issue
A linkedBranches field on the Issue Object

]]>
	<post-id xmlns="com-wordpress:feed-additions:1">68343</post-id>	</item>
	<item>
	<title>Dependabot alerts organizational-level REST API</title>
	<link>https://github.blog/changelog/2022-10-18-dependabot-alerts-organizational-level-rest-api</link>

	<dc:creator><![CDATA[Kevin Duck]]></dc:creator>
	<pubDate>Tue, 18 Oct 2022 17:46:00 +0000</pubDate>
			<guid isPermaLink="false">https://github.blog/changelog/2022-10-18-dependabot-alerts-organizational-level-rest-api</guid>

				<description><![CDATA[Dependabot alerts organizational-level REST API]]></description>
									<content:encoded><![CDATA[
You can now retrieve all your Dependabot alerts at the GitHub organization level via the REST API. This new API endpoint supplements the recently introduced Dependabot alerts REST API<

[ ]<EMAIL_ADDRESS>


Add documentation around Tabs vs Navigation Item

@mikearildbrown yes, this would be to fold in when to use which tabs (as we will have main and inline versions) and we will need to fold this into the navigation pattern.


Support XCM SENT Notifications

Notify when an outbound XCM message is detected. User should be able to configure in the subscription if they want to receive notifications for this event type.

Subscriptions now expect a field events to indicate the type of XCM events for notification.
Example:
{
    "id": "polkadot-transfers",
    "origin": 0,
    "senders": "*",
    "destinations": [
      2000,
      1000,
      2004,
      2034,
      2104
    ],
    "events": ["xcm.sent", "xcm.received"],
    "channels": [{
      "type": "webhook",
      "url": "https://en785006d7bvj.x.pipedream.net"
    }, {
      "type": "websocket"
    }]
  }

A wildcard value "*" can also be passed to receive all event types.


Update the public URL and model name

Hello, I am a PR summary agent on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Quantum CNN

What should we add?
I wanted to contribute a new tutorial on Quantum CNN using Pytorch Lightning. I am following this  approach using jupyter notebooks.
The implementation uses sklearn 'blobs dataset to perform binary classification of 2-dimensional data points. It features Quantum convolution and pooling layers. Shall I create a pull request for this?

Hi, we already have code written with Qiskit for generating quantum circuits for the exact same tutorial referenced. But it is not published anywhere. Let think what's the best way to proceed.

@dlasecki I'd love see some progress on this topic, I don't have time to work on this on my own or in a collaboration with anybody.

@dlasecki I tried to follow the code of the referenced tutorial in qiskit and used TorchConnector to train it, but the model does not seem to converge and it takes a lot of time to finish even a single epoch. Using GPU is not beneficial as the number of samples are less (~100) and even when I used GPU the per cent utilization was negligible.
In the torch connector tutorial, the authors use only 2 qubits when here using 16 qubits (images resized to 4 x 4) is taking quite a time.

@Gopal-Dahale may we help somehow?

@dlasecki I tried to follow the code of the referenced tutorial in qiskit and used TorchConnector to train it, but the model does not seem to converge and it takes a lot of time to finish even a single epoch. Using GPU is not beneficial as the number of samples are less (~100) and even when I used GPU the per cent utilization was negligible.
In the torch connector tutorial, the authors use only 2 qubits when here using 16 qubits (images resized to 4 x 4) is taking quite a time.

Hi, if your code is in a good shape for us to follow, you might open a draft PR and we might have a look. Perhaps some things could be optimized or improved.

Closed in #462


Authenticating With Amazon EC2 Container Registry

I've recently installed The Canonical Distribution of Kubernetes into AWS and I'm to the point where I want to launch pods with containers that live in Amazon's EC2 Container Registry. The Kubernetes docs gives guidance on how to do that.  I've done the following:

given the EC2 instances the proper IAM rights
used juju ssh kubernetes-worker/0 to log into each worker, run the proper docker login command and successfully docker pulled an image from ECR.
ran ps auxw | grep kubelet and noticed that the required --cloud-provider=aws is not found.
journalctl -t kubelet | grep -i aws shows no lines with aws

I did as much research as I could but I could not find the proper steps for configuring kubelet to work properly with ECR.  I think the community would appreciate instructions specific to the Canonical distribution that details exactly how to set this up.

Thank you for filing this bug @kurron! We haven't used the amazon container registry on this team, but this is certainly a valid use case. Once we're done with our 1.6.2 release duties I'll try to get some time scheduled to get this done and issue a pull request with the information. I tagged this issue as feedback-needed to earmark this for further follow up if I have questions.
You are correct that the --cloud-provider=aws is not set, as that has other implications with cloud provider specific integrations (such as storage, load balancers, and other provider specifics). We have some work in progress relating to this, however, its very alpha level quality and not ready for public consumption. CDK modeled Kubernetes as a bare-metal first provider, and have been releasing more functionality as we cycle.
Rest assured that we do have plans to integrate with the cloud providers and model it in a safe manner with the charms, but I don't have an ETA on that work at this time.

Thanks, @chuckbutler .  If I find a suitable workaround in the meantime, I'll be sure to leave a note here for others who might be in my situation.

Experiencing the same issue,

EC2 instances are not created with an IAM role
aws cli is not installed on workers, so could not run the login command to test if it works

Hi!,
Some update about this issue? i cant pull from ECR

I'm having the same issue after installing the core Kubernetes Core distribution.
Does anyone have a workaround? Thanks!


Feature: localstack gives 80 char limit for writing messages, but aws limit is 100

Feature description
As described, there's some inconsistency going on. This currently limits the destination implementation to not accept record keys longer than 80 chars.

Nevermind, I got confused with another id, the SendMessageBatchRequestEntry. According to the aws sdk:
	// An identifier for a message in this batch used to communicate the result.
	//
	// The Id s of a batch request need to be unique within a request.
	//
	// This identifier can have up to 80 characters. The following characters are
	// accepted: alphanumeric characters, hyphens(-), and underscores (_).
	//
	// This member is required.
	Id *string

That's the batch id, not the message id. Localstack properly emulates this behaviour, so there's no issue.


gst-plugins-good: add openssl dependency

Description of changes
This adds OpenSSL as a dependency to gst-plugins-good, which enables hls-crypto AKA streaming things over HTTPS. This is needed by the monophony package to work.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Also, would this mean that libsoup would no longer be a needed dependency for monophony?

Appears to be that way. Weird that the presence of libsoup didn't make it work before for me.

Odd, it works for me. If it doesn't, try clearing gstreamer cache.

...of course that works. WHY IS THERE A CACHE FOR THIS??? Thanks for pointing it out. I'll change the PR description. Maybe some other application can benefit from having https support in the regular gstreamer plugins?

...of course that works. WHY IS THERE A CACHE FOR THIS??? Thanks for pointing it out. I'll change the PR description. Maybe some other application can benefit from having https support in the regular gstreamer plugins?

Well I could remove libsoup as a dep which would he nice.


One pull request per challenge

Please note that every submission to every challenge should have it's own pull request or in other words, one pull request per challenge. As each challenge has a limited number of rewards and we use the first-come-first-serve principle, we need to see the time stamps of each single challenge submission.
In other words,
one pull request for each challenge (Ci) , where C = {B, ID, T, EI} and i = {1,2,...}, i.e.
one pull request for challenge (B1),
one pull request for challenge (B2),
...
one pull request for challenge (X17).
The wording might not have been crystal clear everywhere in the descriptions, so we have tried to smoothened that out by now.

I wasn't aware of this when I started.  You can see complation times on my pull request. Do I need to close the request and open another one for last import-export section, or is it too late? I've done all the task so far my only task left is B1 which is 30 day node task. This is my pull request: https://github.com/Concordium/Testnet3-Challenges/pull/92 You can see exactly when I've commited and done the tasks.
Is this going to faul my work, am I still eligible for rewards?
Thanks,
Best regards.

I did them as supermario said in this answer https://github.com/Concordium/Testnet3-Challenges/issues/364#issuecomment-712198555


Support aarch64-darwin

Your issue may already be reported!
Please search on the issue tracker before creating one.
Describe the solution you'd like
Define aarch64-darwin system doesn't work for now, I get
A definition for option `nixos.hosts.mbp-m1.system' is not of type `system defined in `supportedSystems`'.

But I cannot find supportedSystems defined any where in digga or devos, maybe it's from nixpkgs?
        hosts = {
          "mbp-m1" = {
            system = "aarch64-darwin";
          };
        };

Describe alternatives you've considered
For now, only have to manually import pkgsM1 to use any native packages.
  pkgsM1 = import <nixpkgs> { localSystem = "aarch64-darwin"; };

supportedSystems is a top-level argument in digga. It can be set in your flake.nix, just add a supportedSystems = [ ... ] line anywhere inside the attribute set thats passed to mkFlake.

Th default comes al the way from: https://github.com/numtide/flake-utils/blob/f7e004a55b120c02ecb6219596820fcd32ca8772/default.nix#L3-L8

supportedSystems is a top-level argument in digga. It can be set in your flake.nix, just add a supportedSystems = [ ... ] line anywhere inside the attribute set thats passed to mkFlake.

Works like a charm.
Is there any way in digga I can define two pkgs(one for native and one for x86_64-darwin) to pass to my m1 host config? I have to use --impure to build homeConfigurations.

Is there any way in digga that I can define two nixpkgs(one for native and one for x86_64-darwin) to pass to my m1 host config? I have to use --impure to build homeConfigurations.

Could you clarify what you are trying to do? Do you want to have different {pkgs, ... } as module inputs? Something doesn't sound right, though. Or most probably: I'm missing most of the context.

Is there any way in digga that I can define two nixpkgs(one for native and one for x86_64-darwin) to pass to my m1 host config? I have to use --impure to build homeConfigurations.

Could you clarify what you are trying to do? Do you want to have different {pkgs, ... } as module inputs? Something doesn't sound right, though. Or most probably: I'm missing most of the context.

Yes, I wish to have something like {pkgs, pkgsM1, ...}. As some package are still not working under aarch64-darwin, I would like to use pkgsM1 for packages that are working natively and pkgs for some package like ghc.
What I do to archive this for now is just importing another pkgs on top of every module file, which looks ugly and cannot use devos packages defined in pkgs folder.
pkgsX86 = import <nixpkgs> { localSystem = "x86_64-darwin"; };


Fixed unexpected undo behavior (temporary quick fix)

Overview

When paste (Ctrl + v) in editor form, it couldn't undo (Ctrl + z).
Support undo and redo
The function of Markdown helper is planning to port to React.

So, this pull request is temporary fix.

Related pull request

https://github.com/crowi/crowi/pull/148

Great! @suzuki
I checked the behavior on the review app, and confirmed that the UNDO behavior was completely fixed.
But, I found another odd behavior that the pasted strings always appears at the end of the line.
Repro:

Write some string e.g. Hello World,
Copy some string into the clipboard e.g. Suzuki,
Paste with cursoring anywhere on the line e.g. H[CURSOR HERE]ello World,

Expected:

HSuzukiello World

Actual:

Hello WorldSuzuki

But, I found another odd behavior that the pasted strings always appears at the end of the line.

This is bug.
I used wrong cursor position to insert paste text.
I fixed by this commit: https://github.com/crowi/crowi/pull/151/commits/6e149fc46dc40ce0227ea42aadd938a7d51c173b

I confirmed that the bug was fixed, thanks!


resize textbox for new tasks

New task textbox should automatically grow with the content.

Tested this morning on 0.16.51 it is working as intended.

Uh nice. I have to test that as well again.

Yep, works.


Fix minor typo (s/varaibles/variables/) in Problem 3

Thanks a ton! I swear, half the prs on this thing is gonna be typos


Add a standalone data generator for Kafka

Data model and generator classes in nexmark-flink mostly don't have flink dependency. Having a standalone data generator without streaming engine dependency to send data to Kafka would make this usable in other places.
This can be done in two ways.

Adding another main class that directly sends to Kafka in the nexmark-flink project. This can be run and it will use the datagen classes to directly send to Kafka.
Refactor the datagen out as a separate project, and add a dependency to this in nexmark-flink project. We can then add another project called nexmark-kafka sender that is a thin wrapper to send to Kafka.

Having a standalone Kafka sender sounds good to me.


Expose cobra flags as structured data

It would be cool to introspect the cobra flags and commands and output them as structured data. Make it pretty meta, but also very useful to bootstrap systems like cliopatra.

This probably needs to be replaced by showing the ParameterDefinitions and registered flags through introspection.


Bring signature of RichTextEditor more inline with normal TextFields

Hi,
We are looking into your library to integrate in our app, and use it in our forms. The library looks great and seems to support all our needs.
However there is one thing now that we are struggling with a bit.
Our use case is that the editor is in a form with other textfields, and the content of the form input fields is controlled somewhere else (a ViewModel)
This works great for normal Compose inputs, like the TextField where we have a value and onValueChange.
In the current setup of the library we need to use rememberRichTextState and then manually call setHTML in a LaunchedEffect, which already feels strange. And I don't see a way to continuously update the state in the view model, since I do not see an equivalent of onValueChange. I only see the method toHTML which needs to be called manually on the state object.
I see you had something like this before in the pre-v1.0 versions but you deprecated this.
Our ideal structure would be to be able to do something like this:
OurCustomizedRichTextEditor(value, onValueChange) {
  RichTextToolbar(richTextState) //to show the buttons
  val richTextState = rememberRichTextState(value, onValueChange) //somehow set HTML as input, and get it as output
  RichTextEditor( richTextState)
}

Where the input and output would HTML (or other options depending on what the someone wants, our use case is HTML). This way it can be more or less a drop-in replacement for normal Compose TextFields
What do you suggest? Is something like this already possible?
I think this is similar to #66

Hi,
You are right, I'm thinking of adding some public APIs to register a listener. There's something similar but it's internal, for now there's a possible workaround.
LaunchedEffect(state.annotatedString) {
    // This is going to be called after any change of the text
    val html = state.toHtml()
}

Give it a try and let me know if it works and I'll work on providing a better approach ASAP

Thanks for the quick reply. We'll give the workaround a try.

Hi,
Is this still a thing you plan to add?
We currently have the following structure with the work around mentioned above:
OurCustomizedRichTextEditor(value, onValueChange) {

  val richTextState = rememberRichTextState()

 LaunchedEffect(value) {
      richTextState.setHtml(value ?: "")
  }

  LaunchedEffect(state.annotatedString) {
     val html = richTextState.toHtml()
     onValueChange(html) //propagate new value back up
  }
  RichTextEditor( richTextState)
}

However this results in very buggy behavior. Things I noticed:

The textfield now grows indefinitely. I think because of #191 where an empty string is turned into a line break, which triggers onValueChange, which rerenders our component, which calls setHTML again, etc. I have add a check to only call onValueChanged if the value is not empty to prevent this behavior.
Lists don't work anymore, going to the next line loses the context so the next line is no longer a list element. (I assume there is something in setHtml that resets things

The above things don't happen when I don't call onValueChange.

FYI I fixed my issues in the comment above by not always calling setHTML, only doing it when the incoming value differs from the one in the state.
OurCustomizedRichTextEditor(value, onValueChange) {

  val richTextState = rememberRichTextState()

 LaunchedEffect(value) {
      //preventing buggy behavior in the rich text editor,
      //basically we try not to touch the richTextState
      if (richTextState.toHtml() != value) {
            richTextState.setHtml(value ?: "")
        }
  }

  LaunchedEffect(state.annotatedString) {
     val html = richTextState.toHtml()
     onValueChange(html) //propagate new value back up
  }
  RichTextEditor( richTextState)
}

Hello,
Hopefully this will be added soon. I'm still thinking of the type of data that will be passed with the onValueChange, either AnnotatedString or a tree representation of the rich text.


Remove the redundant null check expression of a non-null value lastRe…

…sult.
The expression "lastResult != null" is a redundant check of a known non-null value because lastResult is non-null.
http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

Coverage decreased (-0.002%) to 89.961% when pulling 436f289a8ab79ed0c25eaa1b3acf67db6d2707d6 on BruceKuiLiu:master into eafb16c711d5cd79edad5fbb2055252acdb3825e on apache:master.

Coverage decreased (-0.007%) to 89.956% when pulling 87abd8c27ba0405663abd0df209baee0b2148db7 on BruceKuiLiu:master into eafb16c711d5cd79edad5fbb2055252acdb3825e on apache:master.

Coverage decreased (-0.002%) to 89.961% when pulling 87abd8c27ba0405663abd0df209baee0b2148db7 on BruceKuiLiu:master into eafb16c711d5cd79edad5fbb2055252acdb3825e on apache:master.

Coverage remained the same at 89.963% when pulling 87ae52374d0a3fe149db4c4e02c83224f7f5ecc3 on BruceKuiLiu:master into eafb16c711d5cd79edad5fbb2055252acdb3825e on apache:master.

Coverage remained the same at 89.963% when pulling d7f49057eb149e30dc77ed8286f7cfb32475f412 on BruceKuiLiu:master into eafb16c711d5cd79edad5fbb2055252acdb3825e on apache:master.

Coverage decreased (-0.002%) to 89.961% when pulling d7f49057eb149e30dc77ed8286f7cfb32475f412 on BruceKuiLiu:master into eafb16c711d5cd79edad5fbb2055252acdb3825e on apache:master.


⚠ ClamAV has degraded performance

In ea22d6d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in a626938 after 5 minutes.


MacOS checks failing

Started today. See https://github.com/quantumlib/Cirq/actions/runs/3092172859/jobs/5003479363

fatal: unable to access 'https://github.com/tensorflow/docs/': The requested URL returned error: 429

Seems that the CI is getting rate-throttled by GitHub?

@MarkDaoust @lamberta Is tensorflow-docs on Pypi? I can't find it.

@vtomole No, not on PyPi but you can pip install it from the Git repo, see https://github.com/tensorflow/docs/tree/master/tools/tensorflow_docs/tools

you can pip install it from the Git repo,

@lamberta That's what our CI does now, but apparently Github might be rate throttling us. Hence this issue.

fatal: unable to access 'https://github.com/tensorflow/docs/': The requested URL returned error: 429

I think we can install tensorflow_docs from its git archive tarball,
that should have lower demands than cloning a git repo.
Let me prepare a PR for that ...

I think using github tarball as a dependency is causing CI failures?
https://github.com/quantumlib/Cirq/actions/runs/3095026537/jobs/5009016923

Fixed https://github.com/quantumlib/Cirq/actions/runs/3099583511/jobs/5018890923


BUG: The title "Some Frequently asked questions" is situated in testimonals part.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
To my observation, I observed that the title " Some Frequently asked questions" is situated at testimonal part. I would like to place it in the down part.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Can you please assign me this issue?

Is there an existing issue for this?

[x]  I have searched the existing issues

What happened?
To my observation, I observed that the title " Some Frequently asked questions" is situated at testimonal part. I would like to place it in the down part.
Record

[x]  I agree to follow this project's Code of Conduct
[x]  I'm a GSSOC'24 contributor
[x]  I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!

@huamanraj
Can you assign the issue to me , You can see my results in previous works


Update Adobe Source Code Pro

Current Brew Cask Version: version '2.010R-ro-1.030R-it'
Latest Adobe version: Roman fonts version 2.030 and Italic fonts version 1.050
Which I think would make the new required version: version '2.030R-ro-1.050R-it'
Links:
• https://github.com/caskroom/homebrew-fonts/blob/master/Casks/font-source-code-pro.rb
• https://github.com/adobe-fonts/source-code-pro/releases/latest
• https://github.com/adobe-fonts/source-code-pro/releases/tag/2.030R-ro/1.050R-it
• https://github.com/adobe-fonts/source-code-pro/archive/2.030R-ro/1.050R-it.zip

Thanks @vitorgalvao 👍


graph structure

Hello author, I have observed that the graph structure you created in the code is a fully connected graph mechanism, and did not use the construction method of the graph mechanism you mentioned in your paper. May I ask where this part of the code is or if my understanding is incorrect.
I see that the function you are using is  “get_fc_graph_struc ” ， function "get_prior_graph_struc" seems to be inconsistent with the graph mechanism construction method you mentioned in your paper. Is there any mistake in my understanding?

We use "get_fc_graph_struc" in the code to first build the fully connected graph and later select the top-k edges based on the sensor embeddings' similarities. The "get_prior_graph_struc" is something experimental, that is we have tried to use prior information about the sensors to build a graph, and it is not used in the paper or code.

Thank you very much for your answer. I have another question. Did you use an MLP when you finally output the results?


Jinja2 template from STDIN?

I've searched through the code but it doesn't seem to allow output to STDOUT independent of input. Can we add this feature? The use case would be to pass param via -D but render to jinja2 template of config without having to generate a file.

I'm not sure what you mean. It only writes to stdout: https://github.com/mattrobenolt/jinja2-cli/blob/master/jinja2cli/cli.py#L234

Hi Matt again! :)
Pardon me if I wasn't being clear. I am just having some hard time understanding the syntax of the parameters. In particular, there is no way to take j2 template from STDIN and/or using the -D only as the input data.
Here are the logs of me fiddling around without luck to get it to work. Python 2.7.11, Jinja 2.8, jinja-cli 0.5.0. Any pointers would be helpful.
$ cat test.j2
apiVersion: batch/v1
kind: Job
metadata:
  name: a_job
spec:
  template:
    metadata:
      name: foo
    spec:
      containers:
        - name: foo
          image: https://registry.hub.docker.com/_/testco/foo:{{ tag }}
          command: ['/bin/bash', 'run.sh', {{ tag|safe }}]
$ cat test.j2 | jinja2 -D tag=9562f6b3770a -
^D
Traceback (most recent call last):
  File "/usr/local/bin/jinja2", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/jinja2cli/cli.py", line 287, in main
    cli(opts, args)
  File "/usr/local/lib/python2.7/site-packages/jinja2cli/cli.py", line 205, in cli
    raise formats[format][2](u'%s ...' % data[:60])
jinja2cli.cli.MalformedYAML: apiVersion: batch/v1
kind: Job
metadata:
  name: a_job
spec: ...
$ jinja2 test.j2 -D tag=9562f6b3770a --format=yaml
^D
Traceback (most recent call last):
  File "/usr/local/bin/jinja2", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/jinja2cli/cli.py", line 287, in main
    cli(opts, args)
  File "/usr/local/lib/python2.7/site-packages/jinja2cli/cli.py", line 216, in cli
    data.update(parse_kv_string(opts.D or []))
AttributeError: 'NoneType' object has no attribute 'update'

PS: will update the issue title.

Oh, you're right. You can't load a template from stdin. This is fundamentally because stdin is already reserved for actual variable context.
I think it'd be confusing to overload what stdin is used for. I'm just thinking of the situation where someone is wanting to do both variables and template over stdin, which, obviously won't work.

I guess I'd be ok with explicitly allowing - as the input template target.
And if - is passed, variables can't be accepted over stdin as well.

Ok, I got it now. I forgot the jinja2 template context is required as well :(
In a of the command line usages of jinja2 templates, I would think a quick & dirty taking the j2 template from STDIN, with a bunch of -D key-value pairs and then output something to the STDOUT. But it's a shame that context occupies the STDIN. Jinja2 templates will have to be specified as a file. Wouldn't it actually be better if we swap the places between context and jinja2 template? That way, STDIN for jinja2 template, no argument for context means it's empty or else specify it as a file. STDOUT for rendered content unchanged. In my use case described above, jinja2 will perform as a true unix pipe utility :)

I think it'd be confusing to overload what stdin is used for. I'm just thinking of the situation where someone is wanting to do both variables and template over stdin, which, obviously won't work.

Apparently that someone was me! :)

I'm aware this is an ancient issue and I've read the comment on design decisions, but I'm still wondering:
How do you then use jinja with no files involved at all and only passing template variables using -D ?

I've never personally needed that, I've always had the templates on disk.
If we want to support this, we'd need some new flag to toggle what STDIN means. Since we can have two STDINs.
But I'm not sure of any precedent of tools that would behave this way.


Add a Prometheus exporter

Currently there's no observability in the system. Exposing some important request level metrics like total http requests, request latency, etc compatible with prometheus will allow more visibility into the system

Fixed by #12


update grpc default server client

update grpc default server client

It's currently a discussion point, we're not actually actively doing it. @xpunch and I are discussing the right long term approach in an issue which you can comment in.

目前这是一个讨论点，我们实际上并没有积极地去做。@xpunch和我正在

Any suggestions? Remove the default rpc implementation? And then make the grpc implementation the default rpc?

We are discussing what a v5 looks like. Otherwise we may borrow from what Micro does and define the notion of a "profile" which can group plugins and introduce the notion of profile loading for that.

We are discussing what a v5 looks like. Otherwise we may borrow from what Micro does and define the notion of a "profile" which can group plugins and introduce the notion of profile loading for that.

Stai parlando del micro profilo [https://github.com/micro/micro/blob/master/profile/profile.go](https://github.com/micro/micro/blob/master/ profilo/profilo.go)? Non ho familiarità con il micro, ma sono disposto a guardare nel porting su di esso

// default the profile for the server
	prof := ctx.String("profile")

	// if no profile is set then set one
	if len(prof) == 0 {
		switch ctx.Args().First() {
		case "service", "server":
			prof = "local"
		default:
			prof = "client"
		}
	}

	// apply the profile
	if profile, err := profile.Load(prof); err != nil {
		logger.Fatal(err)
	} else {
		// load the profile
		profile.Setup(ctx)
	}

Simile a qui? Profili di microservizi, giusto? E poi grpc come implementazione rpc predefinita, giusto?

Something like that yea. Named profiles for different environments and purposes. local, dev, production, or different tech stacks like aws, hashicorp, google, etc.

OK

Vede come questo risponde alle sue aspettative? Non so quali modifiche debbano essere apportate a kubernetes, service e test, quindi lo lascerò vuoto di default e lo vorrà in seguito

We won't be copying profiles verbatim and it won't happen in this PR. It will likely go throw a design discussion first. Feel free to open an issue to discuss.


tidal-hifi: patch out Exec's absolute path in .desktop file

Description of changes
This allows desktop environments (like KDE) to use the .desktop file.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Hm.. it seems maybe this approach doesn't work.

Hm.. it seems maybe this approach doesn't work.

So it's working, but the included icon set is weird 0x0.

Adding the following fixes the icons for me:
            for size in 48 64 128 256 512; do
              mkdir -p $out/share/icons/hicolor/''${size}x''${size}/apps/
              convert $out/share/icons/hicolor/0x0/apps/tidal-hifi.png \
                -resize ''${size}x''${size} \
                $out/share/icons/hicolor/''${size}x''${size}/apps/tidal-hifi.png
            done

Thoughts? Adds imagemagick as a dep.

obsidian uses graphicsmagick, which has a slightly smaller closure size, if you want to give that a try:
: ~/w/v/n/master on master ; nix path-info -Sh .#graphicsmagick
/nix/store/frzi8wipqj8wp2pxdy6q2jdhdfll97da-graphicsmagick-1.3.38        295.5M
: ~/w/v/n/master on master ; nix path-info -Sh .#imagemagick
/nix/store/g61z8zksfsg4d4qnzilslql5nfnhnd2g-imagemagick-7.1.0-46         441.0M

https://github.com/NixOS/nixpkgs/blob/12b0f8840fafedbfa498d56e41d1f31d434ede31/pkgs/applications/misc/obsidian/default.nix#L61

Mk, adding both seemed crazy so I wrote a small utility to resize pngs: https://github.com/qbit/imrsz
It clocks in at 3.7M:
qbit@europa[0]:~/src/imrsz(main); nix path-info -Sh .#imrsz
/nix/store/baz74avhjhaq0jg0vgipnvsy6xyiblvv-imrsz-0.1.1    3.7M
qbit@europa[0]:~/src/imrsz(main);

Currently it only does PNG, but I can add other formats if needed. @alternateved if you are OK using imrsz for this, i'll create a PR to add it to nixpkgs. If not, should I go with graphicsmagick?

It clocks in at 3.7M
That size is much better, though I question the need to create and maintain separate package just for resizing tidal-hifi icons.

I do not use tidal-hifi with icons, since most of the listening I do with window manager, so I never noticed that those are broken.
I wonder if this could be fixed upstream as developer of tidal-hifi is pretty active and helpful. If not, then maybe lets use imagemagick as this is a popular dependency of many packages (not confirmed, just a hunch).

Anyway, fixing icons should be a separate PR. Let's merge this one first.


improve versioning

The current version string necessarily always lags behind and can be easily overwritten via different commits. To have the correct version displayed a user is forced to run the script after every git clone or git pull.

MolSSI recommends https://github.com/warner/python-versioneer

👍 +1

Works for me.
Cheers
Nigel

Nigel W. Moriarty
Building 33R0349, Molecular Biophysics and Integrated Bioimaging
Lawrence Berkeley National Laboratory
Berkeley, CA 94720-8235
Phone :<PHONE_NUMBER>     Email<EMAIL_ADDRESS>Fax   :<PHONE_NUMBER>       Web  : CCI.LBL.gov
On Fri, Apr 26, 2019 at 5:34 AM Mark Waller<EMAIL_ADDRESS>wrote:

👍 +1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/qrefine/qrefine/issues/24#issuecomment-487040792, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAHYQPFKGGA3OTDAURIIAULPSLZDRANCNFSM4GRGCQ6A
.

@hokru what is the status on this?

I didn't investigate further.


Proposal 6 for a logo ;)

BEGINRELEASENOTES

Added a 6th proposal in the call for logos

ENDRELEASENOTES

I like it :)


Removed extra quote in the Extensions Doc page

Looks like we do have an extra quote in the Extensions Doc page here:
https://arturbosch.github.io/detekt/extensions.html#pitfalls

Codecov Report

Merging #1722 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1722   +/-   ##
=========================================
  Coverage     46.87%   46.87%
  Complexity        8        8
=========================================
  Files             8        8
  Lines            64       64
  Branches          3        3
=========================================
  Hits             30       30
  Misses           32       32
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6ebbd...0413b2b. Read the comment docs.


extract timestamptz with milliseconds

Proposal
Improve reported timestamp precision, as naive_datetime_to_pg_timestamptz() precision ends at seconds.
Additional Links
Here https://github.com/VADOSWARE/pg_idkit/blob/main/src/uuid_v7.rs#L54C31-L54C31 we respect nanos, but here https://github.com/VADOSWARE/pg_idkit/blob/main/src/common.rs#L41 do not.

Hey @dvv thanks for the idea -- note that the highest resolution of postgres timestamp types is microseconds, so the best we can do here is microseconds!
That said, the nanos should be converted to micro seconds at least rather than leaving it at second granularity.


RUM and Traces not working with package Dio

Thanks for taking the time for reporting an issue!
Describe what happened
When using datadog_tracking_http_client, I can't make requests made with Dio be tracked. I currently use Dio interceptors for this, but I can't do Trace using the interceptor to pass the parameters through the header.
Steps to reproduce the issue:

Using the packages versions informed below
I run the application and make two requests, one using the http package and the other using dio package
In Datadog RUM, only the request made by HTTP is displayed

Describe what you expected:
I hope that when using datadog_tracking_http_client and o dio the requests are captured in the RUM and that the trace can be performed too
Additional context

Dart/Flutter version: 3.7.11
Android/iOS OS version: Android 13
Device Model: POCO F3
Datadog SDK version: 1.3.2
Versions of any other relevant dependencies:

datadog_tracking_http_client: 1.2.1
dio: 5.1.1

Hi @rodrigopequeno,
The tracking_http_client should be compatible with Dio so far as I know. Are you doing anything when setting up Dio that would make it not use the default dart:io HttpClient? By default, both http and dio use the same dart:io requests.
One thing to double check is your tracing sampling rate. By default it's set to 20%, so it's possible you've just gotten unlucky with Dio on the sampling.

I don't think I did any specific configuration that makes dio not use dart:io.
I ran the tests passing 100 in tracingSamplingRate.

Hi @fuzzybinary
I made a demo application and it is working correctly in it. I'm going to look deeper into the app that's having the problem to try to identify the problem.

@rodrigopequeno Would you be able to send over a sample that reproduces the issue? I'm not able to replicate with a simple case.
Another possibility to check, are you seeing the resources in Datadog, but not the traces? If that's the case, double check that your firstPartyHosts parameter is being set correctly.

Hello @fuzzybinary,
Sorry for the delay, got very busy. I'm going to close this issue because I've updated the versions and it's working correctly now and I couldn't pinpoint the reason, being very project specific.
I didn't dig too deep, but my guess was around APIM and authentication, as unauthenticated endpoints were tracked.
Finally, thanks for the help.
Updates:

Dart/Flutter version: 3.10.0
Datadog SDK version: 1.4.0
Versions of any other relevant dependencies:

datadog_tracking_http_client: 1.2.1
dio: 5.1.2


Speech recognition

If there was another "Book using my voice" button which turn on a microphone, we could use speech recognition and langchain to book rooms using our voice.

Hint: How to use langchain to execute a function using human language. https://haesleinhuepf.github.io/BioImageAnalysisNotebooks/07_prompt_engineering/20_langchain.html


Remove username from AuthZ logging

Fixes https://github.com/aspnet/Security/issues/1259
@Tratcher

@HaoK,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

It's a start, but @blowdart had a laundry list of things we should remove beyond this item.

Also removed token logging, @blowdart what else did you want us to stop logging?

If you had to debug real world apps having authentication issues every day, you'd never dare remove that... :trollface:

I know, but GPDR says no personal identifying information without protecting it, and we cannot know how logs are protected.
However I will email the lawyers just to check.

I can see the other side "Microsoft software helped my company get fined 10% of our global income". I'm going to leave this up to legal :D

@blowdart what's the call here?

Still waiting. In theory, "if we do not retain the data it is our customers responsibility to service DSR requests."
Now we'd have to then add something into logging to allow us to search in the templates. Which is a challenge.

Move it to trace logging - that can by definition (aka according to your docs) contain "sensitive" data.

@leastprivilege you're a little late to the party... this was discussed in the main thread :sweat_smile:
https://github.com/aspnet/Security/issues/1259#issuecomment-335627995


No Review - Jaap pipeline

Description
Updates to the devel / master deployment pipeline
Related Issue
Resolve # issue to be created
Motivation and Context
Upgrading our deployment pipeline
How Has This Been Tested?
Existing unit tests run successfully
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTION document.
[ ] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Will reopened when I need to run online tests vs the pipeline


Option to use nameid as the user lookup attribute

I can't see any way to use the name id from the SAMLResponse as the lookup value for users in Django, so if the IDP doesn't supply this as a separate attribute, there is no way to match the user in Django.
Is this something that I've missed, or something that could be added through the settings? If nameid was added to the lookup map then it would make this simple, and would still provide support for custom user models in Django.

@davehs sorry for the delay in responding. To make sure I understand thing correctly, you want the name id to be leverage-able outside of the 'typical' attributes section of the SAMLResponse? Akin to parsing this line
     <saml:NameID SPNameQualifier="http://sp.example.com/demo1/metadata.php" Format="urn:oasis:names:tc:SAML:2.0:nameid-format:transient">_ce3d2948b4cf20146dee0a0b3dd6f69b6cf86f62d7</saml:NameID>
Correct?
If my understanding of your ask is correct, then you too are correct. We dont currently check that. I don't think it would be that difficult to add. My plate is quite full to deal with enhancements at the moment but I am totally open to a PR otherwise I can likely get to this within a month or two.

@davehs friendly ping, when you're able could you confirm that I understood your ask correctly?

@defionscode yes, I think you've got what I'm getting at. I'll put together a PR.
Thanks

Putting this on the docket since we need for our internal use now as well.

Fixed in #38


[AIRFLOW-2231] Fix relativedelta DAG schedule_interval

Fixes issues when specifying a DAG with a schedule_interval of type relativedelta.
JIRA
AIRFLOW-2231

Commented, and please add unit test and follow the PR guideline. Thanks!

Codecov Report

Merging #3174 into master will increase coverage by 1.68%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
+ Coverage   74.21%   75.89%   +1.68%
==========================================
  Files         193      197       +4
  Lines       14433    14706     +273
==========================================
+ Hits        10711    11161     +450
+ Misses       3722     3545     -177

Impacted Files
Coverage Δ

airflow/models.py
86.68% <100%> (-0.64%)
:arrow_down:

airflow/operators/redshift_to_s3_operator.py
95.45% <0%> (-4.55%)
:arrow_down:

airflow/executors/base_executor.py
93.75% <0%> (-1.42%)
:arrow_down:

airflow/config_templates/airflow_local_settings.py
83.33% <0%> (-0.88%)
:arrow_down:

airflow/utils/log/file_processor_handler.py
86.11% <0%> (-0.56%)
:arrow_down:

airflow/configuration.py
82.04% <0%> (-0.54%)
:arrow_down:

airflow/executors/dask_executor.py
2% <0%> (-0.33%)
:arrow_down:

airflow/www/views.py
71.39% <0%> (-0.32%)
:arrow_down:

airflow/jobs.py
82.83% <0%> (-0.26%)
:arrow_down:

... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15bd80...b026479. Read the comment docs.

Can you please squash commits, resolve conflicts and rebase on the master please?

@kaxil Squashed, resolved and rebased.  Thank you.

@kaxil This was brought up in gitter by @brookskd .  Any reason this hasn't been merged?  Last activity was in May...

@brookskd You had mentioned earlier that we should make dateutil > 2.7 as dependency for relativedelta hashable. This hasn't been done yet. Can you please do that?

@kaxil I did mention that as an alternative to line 3090.  If we are OK with keeping this line in then, the dependency is not necessary because the code will work with all versions of dateutil.  I also think checking if schedule_interval is hashable instead of putting in another dependency is the right thing to do anyways.

@Fokko Any comments?

@kaxil It there anything else I can do for now to move this along?

Hi @brookskd , Sorry for the delay in getting this PR merged. I wanted the guys who initially reviewed the PR to have a look as well. According to me, this looks ready.


Update Readme.md

Exporting a const still produced the same AOT error for me (I'm running Angular 5.2.3, Angular CLI 1.6.7, and TypeScript 2.4.2), but switching to exporting a function eliminated that error.

Good catch, I mean't to say that actually.


samples: boards/stm32/backup_sram : needs backup sram enabled in DT to properly display memory region

Describe the bug
A clean build of boards/stm32/backup_sram shows some sign of bug:
Displaying wrong info:

region name, falls back to *default*:
size gibberish val

To Reproduce
Steps to reproduce the behavior:

west build -b nucleo_h723zg samples/boards/stm32/backup_sram/

Expected behaviour
Suppose to be 4KB
Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper)
Logs and console output
Memory region         Used Size  Region Size  %age Used
           FLASH:       15756 B         1 MB      1.50%
            SRAM:        4288 B       128 KB      3.27%
            DTCM:          0 GB       128 KB      0.00%
        IDT_LIST:          0 GB         2 KB      0.00%
       *default*:        4952 B<PHONE_NUMBER>3709551615 B      0.00%

Solution:
Have a generic overlay file with enabled backup_sram
PR : #37659
Environment (please complete the following information):

OS: (Ubuntu 20.04.2 LTS)
Toolchain (zephyr-sdk-0.13.0)
Commit SHA or Version used (zephyr: 7b9fbcd3b7e932996)

Closing as this was not a bug but rather a board without backup_sram enabled in DT. Related PR https://github.com/zephyrproject-rtos/zephyr/pull/37666


Objection to similar crate names: Camino & Camigo?

Hi Saoirse @withoutboats,
Thank you for starting Camino & for your articles, especially on async.
I'm working on a crate tentatively called "Camigo" = (CPU-)Cache Friendly (https://github.com/peter-kehl/camigo). All suitable names (that I could think of) are already taken (and actually active, surprisingly).
"Camigo", "Cami" and "Camie" come to mind, but "Cami" and "Camie" need to be spelled & explained to non-French speakers.
Tangentially related: While "Camigo" has nothing to do with Path, and it's not primarily/specifically for String/&str/UTF-8, it does implement its traits (two traits, so far: CPartialEq & COrd) for &str & String.
I expect that's where the highest benefit for most users may be. (To be seen: I've only started writing benchmarks;, and then comes real world usage.)
Would you prefer that I don't call it "Camigo"? You don't need to give me any reason, and I'll honor your preference. (And any tips on a name would be welcome.)
Otherwise, I'd publish it under that name. I'd add a "Disambiguation" part to its README, like "Are you searching for a UTF-8-friendly alternative to Path? See Camino."

Not applicable anymore - instead, I'm calling this cami.
Thank you.


Volume values must depends on the last value and outliers probability

The new volume value should differ from the old value by no more than the outlier value

Implemented in v1.4

Full implemented since v1.4.dev91
Build: https://app.travis-ci.com/github/Tim55667757/PriceGenerator/builds/266425024
PyPI dev build for testing: https://pypi.org/project/pricegenerator/1.4.dev91/
pip install pricegenerator==1.4.dev91


[Bug][MapboxV10] Map not showing on simulator on IOS 12.4

Mapbox Implementation
Mapbox
Mapbox Version
default
Platform
iOS
@rnmapbox/maps version
10.0.0-beta.57
Standalone component to reproduce
import React from 'react';
import {
  MapView,
  ShapeSource,
  LineLayer,
  Camera,
} from '@rnmapbox/maps';

const aLine = {
  type: 'LineString',
  coordinates: [
    [-74.00597, 40.71427],
    [-74.00697, 40.71527],
  ],
};

class BugReportExample extends React.Component {
  render() {
    return (
      <MapView style={{flex: 1}}>
        <Camera centerCoordinate={[-74.00597, 40.71427]} zoomLevel={14} />
        <ShapeSource id="idStreetLayer" shape={aLine}>
          <LineLayer id="idStreetLayer" />
        </ShapeSource>
      </MapView>
    );
  }
}

Observed behavior and steps to reproduce
I have simulators and devices running different IOS versions.
On simulator IOS 16, the map is displayed.
On device IOS 15, the map is displayed.
On simulator IOS 12.4, the map isn't displayed (but the scale is).
Expected behavior
Map is displayed for IOS 11+ (it's the min version required on the native IOS SDK)

Notes / preliminary analysis
No response
Additional links and references
No response

Sounds like an upstream issue, we're happy to accept patches for this, but sorry we don't have time to investigate