Add AWS Cloudformation Deployment file for minecraft-new stack

This pull request commits a CloudFormation stack deployment file to your repository. AWS CloudFormation uses the minecraft-prod-deploy.yml file to locate, track, and automatically update a stack that belongs to the minecraft-new template. When this pull request is merged, AWS CloudFormation tracks changes to this repository and applies updates to the stack and parameters that are defined in the file.

:warning: When this change is merged, AWS CloudFormation tracks and syncs changes from this repository to the stack defined in minecraft-prod-deploy.yml. Make sure to review it. You can disable syncing at any time in the AWS CloudFormation console.

How does it work?
Your minecraft-prod-deploy.yml file contains the path from the root of your Git repository to your CloudFormation template as well as the parameters and tags for your stack. When changes are committed to your repository, CloudFormation automatically updates the stack, its parameters, and tags.
How do I update the minecraft-prod-deploy.yml file?
Edit your minecraft-prod-deploy.yml file and commit the changes to your repository. Make sure that you commit the changes to the path and branch in the repository that are specified in the deployment file.

This commit updates a branch tracked by AWS CloudFormation GitSync. Below is a summary of the changes that would be generated if you merged the change in:
Stack : arn:aws:cloudformation:us-east-2:061355996891:stack/minecraft-new
Summary: Change set creation failed with message Failed to create changeset.

This commit updates a branch tracked by AWS CloudFormation GitSync. Below is a summary of the changes that would be generated if you merged the change in:
Stack : arn:aws:cloudformation:us-east-2:061355996891:stack/minecraft-dev
Summary: Change set creation failed with message The submitted information didn't contain changes. Submit different information to create a change set.


missing "palette" in create-react-app-with-jss example

There's a mistake in the theme object of the create-react-app-with-jss example. "primary" and "secondary" properties are not nested in "palette".
https://github.com/mui-org/material-ui/blob/master/examples/create-react-app-with-jss/src/withRoot.js#L17

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

purple/green theme colors.
Current Behavior

The example uses default primary & secondary colors (indigo/pink) instead of the specificied purple/green.
Steps to Reproduce (for bugs)

https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/create-react-app-with-jss
look at the "Super Secret Password" button
Context

Your Environment

Tech
Version

Material-UI
v1.0.0

React

browser

etc

Also light / main / dark keys aren't needed when using the default shades. This is sufficient:
  palette: {
    primary: purple,
    primary: green,
  },

Would you like to fix it?


The blog logo doesn't appear in front page if the SVG doesn't integrate width and height properties

Issue Summary
The SVG file set as "Publication logo" will have null-size in the front page if the SVG doesn't contain width and height properties (Adobe Illustrator default export doesn't include them).
To Reproduce

Export an illustration as SVG from Adobe Illustrator (or other), make sure it doesn't have width and height
Set a SVG file as Publication logo
Check the front page

Example of SVG header:
<?xml version="1.0" encoding="utf-8"?>
<!-- Generator: Adobe Illustrator 24.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
<svg version="1.1" id="Calque_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
	 viewBox="0 0 604 204" style="enable-background:new 0 0 604 204;" xml:space="preserve">

More details
If you manually add width and height to the SVG file, the logo appears correctly.
Example of SVG header:
<?xml version="1.0" encoding="utf-8"?>
<!-- Generator: Adobe Illustrator 24.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
<svg version="1.1" id="Calque_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
	 viewBox="0 0 604 204" style="enable-background:new 0 0 604 204;" xml:space="preserve">

Technical details:

Ghost Version: 3.13.1

@DarthJahus this is down to theme-specific styling. Please open an issue on the relevant theme (Ghost's default theme Casper is here https://github.com/TryGhost/Casper), contact your theme developer, or adjust the styles in your theme to work with the SVGs you are using.


inline nmea checksum calculator; use bootstrap style for button

This was probably not planned that bootstrap breaks the line before and after the input field. Also the button was missing bootstrap style.

Looks like we could get get rid of the leading "$" and trailing "*checksum" as it says so in the label?

@fichtner the "checksum" string will be replaced by the checksum after the button is pushed so it cannot be removed.

now looks like this:

and the advanced button has been formatted too:

Thanks, I'll take a look on the offset of text and button in the morning.


Update CSharpSymbol.ts

Fixes the second issue mentioned in #2 where nested classes would be moved outside of their parent by correcting regex expression that only allowed deeply nested classes to be detected. :3

Will you provide code example of before and after change? I know this was reported but I've never been able to reproduce it. Would like to see what code causes this. Thanks.

Here is a video demonstrating the before and after of the change I implemented.


Cannot display thumbnails

Issue description:
I am unable to get thumbnails to display. If I add a navContainer value no thumbnail images are are added but the DOM shows other elements relating to teh thumbnail navigation.
If I don't specify a container, the navAsThumbnails option is just ignored and the dots remain. Presumably this is the desired fallback behaviour?
I'm using the Grav CMS and outputting content using Twig.
Demo link/slider setting:
HTML/Twig mark-up

                {% for image in page.media.images %}

                        {{ image.cropResize(600,600).html(page.title , page.title )|raw }}

                {% endfor %}

                {% for image in page.media.images %}

                {% endfor %}

        var slider = tns({
            container: '#pin-gallery',
            items: 1,
            slideBy: 'page',
            autoplay: false,
            controls: false,
            navContainer: '#thumbnails-nav',
            navAsThumbnails: true,
            navPosition: 'bottom',
            mouseDrag: true,
            arrowKeys: true,
        });

Tiny-slider version:
2.9.3

in #thumbnails-nav need place images  . as main and as many as main. example as you code.

                 {% for image in page.media.images %}

                 {% endfor %}

Ah, thanks, I managed to get it working. It wasn't clear from the instructions I had to specifiy the thumbnails myself, I had assumed it was automated by the plugin.


Is this implementation affected by this chrome bug?

First discovered here:
https://stackoverflow.com/questions/47524205/random-high-content-download-time-in-chrome/47684257
Caused by this chrome feature:
https://www.chromestatus.com/feature/5745543795965952
More detail:
https://github.com/TryGhost/Ghost/issues/7934

Anyone who knows?


Use <... template={...}> for named children

This changes the syntax for named children. Two main ways are supported:

template={...} attribute

This allows dynamic values to be used easily.
<Text template={:label}> ... </Text>

Shorthand # boolean attribute

This can be preferred when the value is constant.
<Text #label> ... </Text>

Comparisons
Left is current syntax, right is new syntax.

<Menu>
  <Menu:label>
    Open Me
  </Menu:label>
  <Menu:content>
    <Button>Option 1</Button>
    <Button>Option 2</Button>
    <Button>Option 3</Button>
  </Menu:content>
</Menu>

<Menu>
  <Text #label>
    Open Me
  </Text>
  <Group #content>
    <Button>Option 1</Button>
    <Button>Option 2</Button>
    <Button>Option 3</Button>
  </Group>
</Menu>

Here's one case where this is very beneficial: dynamically changing what part of the content a template represents.

<Gauge>
  <Gauge:label>Value</Gauge:label>
  <%= content_tag :"Gauge:#{@min_or_max_label}" do %>
    This is either the minimum-value-label or maximum-value-label
  <% end %>
</Gauge>

<Gauge>
  <Text #label>Value</Text>
  <Text template={@min_or_max_label}>
    This is either the minimum-value-label or maximum-value-label
  </Text>
</Gauge>

According to the docs, the use of content_tag is discouraged. However I believe this is the only way that could be implemented with the current syntax. The new syntax makes this easy as you just pass the id of the template like a normal attribute.

Just for tracking purposes, I'm :+1: on this proposal. I would just like to ensure that on the Elixir side we can use <t> in addition to <template> which would look like this:
<Menu>
  <t id={:label}>
    Open Me
  </t>
  <t id={:content}>
    <Button>Option 1</Button>
    <Button>Option 2</Button>
    <Button>Option 3</Button>
  </t>
</Menu>

Personally, I have a slight preference for having a <template> element, since it's closer to the Web Components and Vue.js style—and it indicates the same thing: that the contents will be placed somewhere deeper within the parent element's internal structure. It is less concise, but I think it adds some clarity. But that's not a strong preference, and I'm fine with the attribute style.

@shadowfacts agreed, I retract my previous request

Option 2 is a bit shorter in many cases (even if we don't include the shorthand), which was the main concern with <template>. But I also see the benefit of forcing that extra nesting level with <template>.

The attribute method is more like how WebComponents work than the <template> element which is similar to Vue.

Do either of you have a strong preference between these @bcardarella @supernintendo?
@Kashif-E & @KronicDeth: would one of these options be better for Jetpack Compose?
Option 1

Requires a <template> element with an id.

<Menu>
  <template id={:label}>
    <Text>Open Me</Text>
  </template>
  <template id={:content}>
    <Button>Option 1</Button>
    <Button>Option 2</Button>
    <Button>Option 3</Button>
  </template>
</Menu>

Option 2

No need for a <template> element, as the template attribute can be applied to any element.

<Menu>
  <Text #label> <!-- this # attribute is shorthand for template={:label} -->
    Open Me
  </Text>
  <Group template={:content}> <!-- use the Group view to put multiple elements in this part of the menu -->
    <Button>Option 1</Button>
    <Button>Option 2</Button>
    <Button>Option 3</Button>
  </Group>
</Menu>

Equivalent SwiftUI View
Menu {
  Button("Option 1") {}
  Button("Option 2") {}
  Button("Option 3") {}
} label: {
  Text("Open Me")
}

@carson-katri in jetpack compose attributes or modifiers are chained together, hence, my personal preference will be option 2 because of the same reason you mentioned above

I've removed the # shorthand for now. It could be re-added if we determine it cannot be done from the backend.


smaller base images

minimal debian image
deriving from the minimal debian image rather than ubuntu:14.04 for nodejs-0.12 and nodejs-ruby images
scripts to build, squash and push selected images to DockerHub directly (without using their built-in mechanism) - we will need to disable the automated DockerHub builds for these

Maybe a stupid question but why we need minimal dev images? I think we should have minimal production images and start using them where appropriate, now we use *-dev even in more production focused envrionments. Well I actually think that the -dev and production doesn't really work for us ... we could happily use just base and be done with it.

@w-vi problem is with images about 1GB. It's look ECR have problem with correct download theses images.

@w-vi agreed that it does not make much sense, I just kept the naming consistent... I'd rename in a separate PR, though...

Well images over 1GB are bloated that's true :)
@nadade Cool, I think it will make life easier

@abtris comments addressed, can you take one more look?


ECTS Progress bar

Adding a progress bar that shows how many ECTS you'll need and how many you already have and with a colorscheme that represents the grade

Progress Bar möglicherweise durch Plot ersetzen?


Add TransIP (transip.nl) as dns provider

Description
Add a dutch dns provider (TransIP) as an option
Checklist/ToDo's

[x] Added documentation?
[-] Added release note entry? (  docs/release-notes.md )
[x] Tested?

Thanks for your contribution, I will have look.

Merged into devel tree, will be merged later into master.


Retrieve user's data from the POD

Feature description
It will consist of being able to retrieve data from the user's POD as well as the user friends POD.
Acceptance criteria

[x] Retrieve the user's name.
[x]  Retrieve the user's friend.
[x] Retrieve the data of the user's friends.

Closing the issue in pull request #101

Closing the issue in pull request #101


Add Biography and make AC editable

Hi, I LOVE the way your mod makes the monster sheets look. I have 2 suggestions:

Add a biography button: the way Some monsters are imported (specially from Roll20) have all the info from the MM in the BIography. Being able to quickly check it is something I miss when using the monster sheets. It could be at the top bar or a small link near the portrait.

If you are just going to make a couple of stuff editable please make AC one of them.  I use  a lot Foundry's targetting system with autoapply damage, and sometimes an enemy may pickup a shield, or have Magic armor cast... stuff like that where I need a quick AC edit so the calculations are correct.

Both of these are planned. The next big focus I'm working on editing, so AC is already possible to edit on the v2.x branch (very alpha). The bio is something I need to figure out how best to deal with, but it's something I do intend to make available.

This is required for supporting "Limited" access previews, which show the Bio but not the stat block. Very useful for NPCs where you want the players to see some details about the sheet but not others. Limited access should also hide "Secret" blocks inside of the bio.


Adjust watering frequency depending on season

Adjust watering frequency depending on the season and temperature, especially important for the lawn.

Wrong project.


Logic for displaying student stdOut.

Should be merged in after PR #588 .
Handles both client and server side logic for print although not currently displayed anywhere.

Thanks for the detailed pass @seanlip ! I'll be sure to go through and address them today.

@eyurko @seanlip  I have fixed the logic structure as per suggestions -- your review would be greatly appreciated. Thanks for all the help along the way, and let me know what further changes could be implemented to improve the code!

@kchen05 please make sure to reply to all open comment threads. I think some of the open comment threads don't have a response yet. Thanks!

Sorry must have missed some comment threads. Should have replied to all now!

Well, almost. Looks like you have some test failures...
I restarted the tests; you might also need to merge master into your branch.


Geth logs do not work

Problem details

Start a geth node and try to view the logs. It shows a pm2 error.
This is a tricky one to fix.

This will be fixed in upcoming releases which change Geth to using docker.

fixed in latest pre-release


create_surfaces is unsound

Bevy version
0.15
What went wrong
In create_surfaces, the underlying create_surface_unsafe is called under the assumption that any surface target inside of ExtractedWindows is guaranteed to be valid.
This isn't true, however. The fields on RawHandleWrapper are public, so any user could insert garbage data and cause the call to create_surface_unsafe to use invalid data.
Propose solution
Make RawHandleWrapper's fields private, replacing them with accessors and unsafe constructors.

I think that solution is good.


Refactor of NamespaceMap CRD

Description
This PR adds new features to NamespaceMap CRD, new DesiredMapping field in Spec and new CurrentMapping field in Status.
Fixes
STEP 3 #572

/rebase

/ok-to-test

/merge

/rebase

/merge

/merge

/merge


Refactor SceneTreeDock context menu separators

This started as a simple change to hide "Rename Node" option in Scene Tree dock for foreign nodes (since it results in an error, so there is no reason to show it).
However I was faced with separator spaghetti, so I made an attempt to make it easier to separate sections in that context menu. idk if it makes sense this way though, it's supposedly easier to use.

There's still an unexpected separator if "Scene Tree Editing" feature is disabled and multiple nodes are selected.

Can't reproduce this 🤔


Add logic to the deployer to decide which clusters/hubs require a helm upgrade

This PR adds a series of functions to the deployer that will analyse a set of filepaths (ideally that have been added/changed by a GitHub PR, this input is not provided in this PR) and decide which hubs/clusters require a helm upgrade and whether that upgrade is for the *hub helm charts or the support helm chart
It's logic works like so:
Hubs:

If a *.values.yaml file has been added/changed, upgrade the appropriate hub on the appropriate cluster
If a cluster.yaml file has been added/changed, upgrade all hubs on that cluster
If the basehub or daskhub charts have been changed, upgrade all hubs on all clusters

Support:

If a support.values.yaml or cluster.yaml file has changed, upgrade support for that cluster
If the support helm chart has changed, upgrade support on all clusters

Some extra filepaths are also watched to maintain the functionality we have currently, such as the deployer and the files under .github/actions/deploy.
The output is two lists of dictionaries that each represent a set of matrix jobs to be read by a second GitHub Actions job that will run each dictionary in parallel. One dictionary represents all the support upgrade jobs, the other all the hub upgrade jobs. A --pretty-print flag has been provided that will print these jobs in a human-readable format by using tables from the rich package. It is intended to run this logic in PRs using the pretty print option so engineers can check which jobs will be run before merging.
The support jobs have the keys provider (the cloud provider) and cluster_name (the name of the cluster). The hub jobs have the same keys plus an additional hub_name key (the name of a hub). These will be fed to the deployer deploy command to begin a deployment.
I have also added some tests to ensure all this new logic is behaving how we expect it to. I've added an environment variable that is set to True when we run the tests via pytest this allows us to ignore cluster.yaml files nested under tests/ when we are doing live deployments, and exclusively consider them when we are running the test suite. I have added a new GitHub Actions workflow file to run these new tests when changes are made to the deployer.
NOTE: This PR is not yet implementing the changes in GitHub Actions to actually deploy hubs in parallel. This is only the Python logic that will underpin such a workflow.

This is super exciting, thanks @sgibson91 !! It would be great if we can get more thoughts from the @2i2c-org/tech-team since this will be a big change to our CI/CD setup.
A few guiding principles thoughts from me:

I like @consideRatio's comments about choosing function names that are tightly scoped and convey the most important information about what a function does
If there are places where we might optimize behavior about the upgrade logic, I suggest that (unless it is an obvious and easy fix) we create issues to tackle them in follow-up PRs, and make sure this PR isn't making it impossible to make those improvements in the future.

A quick question, I noticed:

This PR is not yet implementing the changes in GitHub Actions to actually deploy hubs in parallel

Is the plan to build the GitHub Action that runs these commands in this PR as well, or is that a follow-up PR?

Is the plan to build the GitHub Action that runs these commands in this PR as well, or is that a follow-up PR?

My intention was for it to be a follow-up

If there are places where we might optimize behavior about the upgrade logic, I suggest that (unless it is an obvious and easy fix) we create issues to tackle them in follow-up PRs, and make sure this PR isn't making it impossible to make those improvements in the future.

Absolutely agree! I think @sgibson91 has done wonders breaking apart a very large kind of change into a sequence of changes in PRs. Feel free to proceed as needed so that work doesn't get stuck as large changes often can get when trying to address everything all at once!
Thank you @sgibson91 for running this ultra-marathon!!

Folks, I tried to do a git rebase to drop a commit which was causing a merge conflict(and didn't really need to be in this PR, related to broken links in the docs) but the rebase has brought in other commits from https://github.com/2i2c-org/infrastructure/pull/1092, see below 😭

I apologise for this faux pas and would appreciate any learning resources to help me actually use git rebase effectively without me messing up PRs like this 😢

@sgibson91 I think git rebase has been tricky to learn more about, and I feel that I've only managed to incrementally add understanding over time - but, the biggest increments of understanding came from watching two amazing video-focused courses:

https://www.pluralsight.com/courses/how-git-works
https://www.pluralsight.com/courses/master-git

Thanks for clarifying what was part of this PR and what wasn't!

I'm closing this PR in favour of https://github.com/2i2c-org/infrastructure/pull/1112 I've done my best to copy across unresolved conversations


Updated for Xcode 12, Swift 5, iOS 14, and copyrights to 2020.

 7. Unit Testing

 7. Unit Testing


Add Japanese translations for v3.0-beta.4

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes
I added Japanese translations for v3.0-beta.4.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl @knolleary Thank you!


[YAML] Trader: Estimate gas failed

Summary
In yaml-cli2 branch. Using VPS with barge-predictoor-bot.
(venv) trentmc@tlm-macbook: ~/code/pdr-backend $ pdr trader 1 ppss.yaml barge-predictoor-bot
...
1 filtered feeds:
  [Feed 0xe0b2e BTC/USDT|binance|5m]
Purchasing new subscription for feed: [Feed 0xe0b2e BTC/USDT|binance|5m]
Estimate gas failed
HTTPConnectionPool(host='<IP_ADDRESS>', port=8545): Read timed out. (read timeout=10)
before:<PHONE_NUMBER>.954389
      [Feed 0xe0b2e BTC/USDT|binance|5m] has a new prediction: 0.0 / 0.0.
  There's no stake on this, one way or the other. Exiting.
---------------------------------------- Processing [Feed 0xe0b2e BTC/USDT|binance|5m] ----------------------------------------
Epoch 5674268
Seconds remaining in epoch: {epoch_s_left}

Full log
log.txt

It's working now.
It's also working in sapphire-testnet.


Setup basic websocket connection logic

Added code to connect to websocket. Currently this only supports sending strings via the websocket connection between the frontend and the springboot backend.

LGTM, this can be merged


Auto rotate tunnel sats configs

The loop node gets a new IP every few hours. Looks like fun.

out of scope for this repo


Move ReadonlyFilesystem Node Condition to a new configuration file

We're enhancing NPD to support detection of various read-only scenarios (e.g., boot disk, local SSDs, network-attached drives). To support this, the ReadonlyFilesystem configuration is being moved from the kernel monitor into a dedicated plugin configuration file that will take over this new functionality.

/ok-to-test

/retest
/lgtm

You need to add your new plugin config file to https://github.com/kubernetes/node-problem-detector/blob/dc4200d805c9554d6585dba8d1a566fb20b6869b/config/systemd/node-problem-detector-metric-only.service#L11 (and potentially other files).

/cc @wangzhen127
/assign @wangzhen127

To make sure it is backward compatible for people using the OSS config file directly, we need to add the new file to all the locations where kernel-monitor.json is invoked: https://github.com/search?q=repo%3Akubernetes%2Fnode-problem-detector kernel-monitor.json&type=code

@DigitalVeer please rebase and squash the commits.

/retest

@wangzhen127 There's a problem with the failing tests. Seems to be something broken in some other related repo. Any ideas?

/retest

/retest


Make feature_request label configurable

I'm already using "Enhancement" as label for feature requests plus don't personally like the look of the _ in the name as it does not match other label's style. Searching the codebase for feature_request didn't return any results- would be great to understand where this comes from plus make it configurable.

We are deprecating this bot in production, noted on the README.

We are deprecating this bot in production, noted on the README.


Move immutable to peerDependencies

Before submitting a pull request, please make sure the following is done...

Fork the repo and create your branch from master.
If you've added code that should be tested, add tests!
If you've changed APIs, update the documentation.
Ensure that:

The test suite passes (npm test)
Your code lints (npm run lint) and passes Flow (npm run flow)
You have followed the testing guidelines

If you haven't already, complete the CLA.

Please use the simple form below as a guideline for describing your pull request.
Thanks for contributing to Draft.js!

Summary
Move "immutable": "~3.7.4" from dependencies to peerDependencies in package.json
Closes #1237
Test Plan
NA

Should it be? What if I use another package with older immutable version? My app will be completely broken and I won't be able to fix it.
What problem are you trying to solve here? It's not clear from the issue.

@TrySound it was reported issue so I made the changes, it this change not required?
@niveditc I will make the changes and update my commit

@niveditc I am getting this error on running yarn
`const missingModule = e.toString().match(EXTRACT_MODULE_NAME_REGEX)[1];
^
TypeError: Cannot read property '1' of null
at files.forEach (/Users/arshad/Arshad/workspace/opensource/hacktoberfest/draft-js/node_modules/fbjs-scripts/node/check-lib-requires.js:30:76)
at Array.forEach ()
at fs.readdir (/Users/arshad/Arshad/workspace/opensource/hacktoberfest/draft-js/node_modules/fbjs-scripts/node/check-lib-requires.js:22:9)
at FSReqWrap.oncomplete (fs.js:135:15)`

Thanks for commenting on #1237 - let's wait to see if this change is needed, since I don't have much context.

Closing since we weren't able to come up with rationale for this change. Apologies for the mislabeled issue!


chromium, google-chrome: add commandLineArgs

Motivation for this change
It is convenient to be able to .override chromium package in a way so it is always start with given command line arguments, e.g --disable-gpu irregardless of how chromium is launched: by clicking on a toolbar icon, via xdg-open, or from a some shell script.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Maybe it should be a string? In the current state it is not escaped anyway (if it contains spaces, for example).

@7c6f434c you are right, string is simpler.
I just went to see how configureFlags is implemented (it allows both string and list-of-strings), there is simple toString configureFlags with the same space problem. Some packages do escaping with sed and handcrafted regexp. It would be useful to have lib.bashEscape which could accept string or list as input and produce a properly escaped string.

This strikes me as somewhat ad hoc. I mean, you might want to add global flags to just about any application in the system, e.g. Emacs, vim, Firefox, Thunderbird... I'd hate to see commandLineArgs arguments appearing all over Nixpkgs.

most of those apps could be globally configured via environment variables in /etc/profile

I think the fact that we even want to have a configurable wrapper for Chromium at all, together with the fact that some options cannot be set persistently do make Chromium/Chrome a bit of a special and more annoying case.


How to update all columns on conflict

Discussed in https://github.com/go-jet/jet/discussions/237

Originally posted by rsmidt May 17, 2023
I'm trying to implement a basic upsert where I want to update all fields as soon as I hit a constraint, e.g.
Users.
	INSERT(Users.AllColumns).
	MODEL(user).
	ON_CONFLICT(Users.ID).
	DO_UPDATE(
		SET(Users.AllColumns.SET(Users.EXCLUDED.AllColumns)),
	)

Unfortunately, this doesn't compile. Am I doing something wrong here? Is there maybe a better way to achieve the upsert?

@go-jet Bump :) Can you take a look at this? Having a MODEL() for updating all columns besides the primary key would be super useful. Or something similar to the implementation above.


[iOS] Loading closes before finishing asynchronous method

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[X] iOS
[] Android
[] UWP
[] NET Standard 2.0

Version of OS(s) listed above with issue (if android - please include version of Xamarin.Android.Support.* you are using)
iOS 11.2
Version of ACR UserDialogs Library
6.5.1
Expected Behaviour
using (_dialogs.Loading("message"))
{
//asynchronous method
...
}
Loading should wait for the asynchronous method to finish to disappear from the screen.
Actual Behavior
If applicable, please include entire exception - type, message, stacktrace
Loading disappears quickly from the screen after starting. Do not wait for the end of the asynchronous method.
Code of Conduct

No Library Update Requests - THIS ESPECIALLY MEANS ANDROID SUPPORT LIBRARIES
No Timeline Requests
Please read through the documentation and FAQs
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

This is the complete method. And none of the options mentioned in your answer

public async Task AprovarSimulacao()
        {
            if (_isAprovando) return;

            _isAprovando = true;

            var tarefas = default(DataResults<BPMTarefaResponseDto>);

            using (_dialogs.Loading(Message.Simulacao_Aprovando))
            {
                tarefas = await _bpmTarefaDataAgents.TratarTarefaBPM("APPROVE", Simulacao.IdTarefaBPM.ToString(), "Sem Justificativa", Guid.Empty, Settings.UsuarioLogin);
            }

            if (!tarefas.IsSuccess)
            {
                _dialogs.ShowError(Messages.Message.Simulacao_Aprovacao_TarefaBPM, 3000);
                _isAprovando = false;
            }
            else if (tarefas.Entity.Erros != null && tarefas.Entity.Erros.Codigo != 0)
            {
                _dialogs.ShowError(Messages.Message.Simulacao_Aprovacao_TarefaBPM, 3000);
                _isAprovando = false;
            }
            else
            {
                _dialogs.ShowSuccess(Message.Simulacao_Aprovada);
                await _navigationService.GoBackToRootAsync();
            }
        }

By end-to-end sample, you need to submit a full reproducible app causing the issue that I can compile and run.  This method is used by a ton of people, if there was an issue here - there would be a lot of complainers.  Wrap the loading with the async in a try/catch.  Also, run a timer around it.

No response from user.


Bot doesn't reply to any commands despite being online

Fixed by https://github.com/Epictek/tldr-Discord/commit/28ab2142038a8ca9668f5feb223b29ab77de7751


activation: update NIPostBuilder to use state DB instead of files

Motivation
Closes #5206
Changes

Migrations for localsql were extended

All migrations are now in code to ensure that data is moved from disk into DB when migrating, failing to do so will result in the DB migration not completing
All Go Migrations now have a SQL migration that does the same DB changes, but doesn't migrate data from disk into the DB. This is helpful for when no data needs to be migrated (e.g. in tests). Additionally the Go Migrations can just be deleted in the future when most people are running v1.3.0 or newer versions.
Go migrations have tests to ensure data is migrated properly and SQL migrations match the Go Migrations (produce the same Schema after migrating)

NIPostBuilder now stores its state inside the local database instead of on disk

Added new nipost localsql functions that allow to store and fetch the data

Deflake some tests in the activation/e2e package by avoiding the spawned PoET from having slightly different timings than the component under test.

Test Plan

existing tests have been updated to work with new code
added tests for new code

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors try

bors try

bors try

bors merge


Test button in map editor

Send a level-to-test via broadcast channel api to an already open game instance.
if not open already:
Open the game in a separate tab and request/receive the map via broadcast channel.

sending & receiving on open tab implemented.
opening new tab with map nyi.

opening a game from the mapeditor and loading the current map there is now implemented


189 duplicated inputs

Updated features

Update default value for shooting

Fixed features

Rename clock variable in shoot action
Use action parameter to know if a key is pressed or released

Codecov Report

Merging #210 (12e883c) into master (0f91f18) will increase coverage by 0.02%.
The diff coverage is 0.00%.

:exclamation: Current head 12e883c differs from pull request most recent head 01f59cc.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


misspellings, it's/its

If this PR is accepted, please label it as "hacktoberfest-accepted" or classify the repository with the "hacktoberfest" topic. Thanks!
https://hacktoberfest.digitalocean.com/hacktoberfest-update

@ReQ6W7rFnaBxyfb Thanks for catching this mistake. I'm not sure if we can add a custom label as we keep a strict set of labels to use for repo management. #sign-off


Merging common code bases DbConnectionStringCommon

Common types:

DbConnectionStringDefaults
DbConnectionStringKeywords
DbConnectionStringSynonyms
DbConnectionStringBuilderUtil

What s the reason for a dedicated ReadOnlyCollection<T> type? Can we not use the standard bcl provided one? https://apisof.net/catalog/9ff7feaa-ce3f-c2d6-3b5d-4cf21ce96643 and if not can there be a comment explaining the behaviour we need from our own version in the code?

What s the reason for a dedicated ReadOnlyCollection<T> type? Can we not use the standard bcl provided one? https://apisof.net/catalog/9ff7feaa-ce3f-c2d6-3b5d-4cf21ce96643 and if not can there be a comment explaining the behaviour we need from our own version in the code?

Thank you for bringing it up. I didn't find any reason for using ReadOnlyCollection<T> too. Just brought it here for more discussion.
cc @cheenamalhotra

What s the reason for a dedicated ReadOnlyCollection<T> type? Can we not use the standard bcl provided one? https://apisof.net/catalog/9ff7feaa-ce3f-c2d6-3b5d-4cf21ce96643 and if not can there be a comment explaining the behaviour we need from our own version in the code?

Thank you for bringing it up. I didn't find any reason for using ReadOnlyCollection<T> too. Just brought it here for more discussion.
cc @cheenamalhotra

I agree we could use the standard BCL type already available.


Multiple Express Servers does not send socket.io message

I have 2 express servers running socket.io and using redis to store the socketIDs.  I have a device1 connected to express server 1 and another device2 connected to express server 2.  When i try to send a message from device1 to device2 I notice that the socket.io server does pick up the correct socket id but when it tries to emit the message I get this error: TypeError: Cannot read property 'emit' of undefined
I am not sure how to send messages when using multiple nodes.  Here is my code below:
var socketIO = require('socket.io');
var io = socketIO(server);
var client;

// Create a Redis client
const redisPort = redisConfig.redisPort,
    redisHostname = redisConfig.redisHost,
var redis = require('redis');

var RedisStore = require('socket.io-redis');
var adapter = RedisStore({  host: redisHostname, redisPort });
io.adapter(adapter);
client = adapter.pubClient;

// When a client connects
io.sockets.on('connection', function (socket) {
    // Log in a user with their provided username
    socket.on('login', function (data) {

 var timerCount = 0;
        var login = function () {
client.get('user:' + data.rec, function (err, socketId) {
                        try {
                            io.sockets.connected[socketId].emit('message', data);
                        } catch (err) {
                            if (timerCount === 100) {
                                console.log("Waiting for user to join chat timed out!");
                            }
                            // Cant find user - user has not joined yet
                            console.log(err);
                            timerCount++;
                            setTimeout(login, 2000);
                        }
                    });

}
├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>deduped
│ └─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>deduped

With your code you are trying to send data to a socket on same io server instead sending to cluster.
It's not a socket.io-redis issue.
You have this error (error: TypeError: Cannot read property 'emit' of undefined) because socketId is not a socket connected on the io server.
So try to change
io.sockets.connected[socketId].emit('message', data); // sending on local io server
by
io.to(socketId).emit('message', data); // sending through cluster

ok thanks for that and i made that change.  Now I am not getting that error but the messages are not getting received by the device now

Do the express nodes have to be clustered?

@olivier37520 is there something that I am missing?

Of course you connect the same redis server.

@olivier37520  Yeah I am connected to the same redis server.  When it first starts there is no problem and it communicates fine.  Then when i try to restart the socket.io server the communication stops working.  I am not sure why, its connecting to the same socket.io server and its emiting to the correct socketID but the client doesnt seem to be getting the event. Any idea why even sending to the correct socketID the client does not pick up on the event?

@svarughese91 first can you compare the socketId retrieved by redis and the socket.id on the second server . if they are identical and code above still don't work, you can try a workaround like this:
just after connection event
socket.join('room_'+socket.id);
and in the emit part
io.to('room_'+socketId).emit('message', data);
As this you have a room by socket.


Fix run type switch link in createRunPage and RunPage

closes: https://issues.redhat.com/browse/RHOAIENG-4739
Description

switching from triggered run to scheduled run and vise versa now directs to the create form and not the list
doing this from a clone will direct to a non clone route

How Has This Been Tested?

create a run, switch run to scheduled
create a schedule, switch run to triggered
clone a run, switch to non clone route schedule
clone a schedule, switch to non clone triggered

Test Impact

added tests for the redirects in both directions
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/retest

tested over again
/approve


hubble:Add unit test for Pop with closed stop chan

Signed-off-by: Jianlin Lv<EMAIL_ADDRESS>Related: #12178

Awesome, thanks! I assume this requires https://github.com/cilium/cilium/pull/12257 to be merged first?

Awesome, thanks! I assume this requires to be rebased on #12257 first?
Yes, I should submit this PR based on #12257

Travis fails as expected :tada: Once #12257 is merged, this needs a rebase on master.

Travis fails as expected 🎉 Now that #12257 is merged, this needs a rebase on master.

okay

test-me-please

Coverage increased (+0.006%) to 37.182% when pulling dc4cd6720774eaeab5489b81708c99b3f5f1c6e6 on Jianlin-lv:pr-add-pop-unit-test into c75df255a733739350324c35bffa3e67be52cea2 on cilium:master.


[protocol] Implement Get Host State

Add serializer, deserializer, and fuzz tests for Get Host State request
and response messages (6.22 in the Cerberus Protocol). This message is
used to query the host processor reset state.
Fixes #44
Signed-off-by: Kesavan Yogeswaran<EMAIL_ADDRESS>

Ah. It appears a recent refactor I did broke you, sorry. =P
Should be a matter of s/(To/From)WireError/wire::Error/g, plus or minus appropriate use statements.

Definitely was largely a copy-paste-rename job, but it helped to get a (little) better feel for the codebase.
I've rebased to include the latest wire error changes and fixed the feedback. @mcy looks like you have to re-approve the CI workflow for the latest push.

LG. Will merge once CI finishes.


Fix issue#170 value method definition changes as per Rails version

Fix issue #170 value method definition changes as per Rails version
Solution Applied
I have done changes to define method differently as per Rails versions

See my latest change and check that works. Haven't added Rail 5.2 tests yet. Don't want to muddy the waters for now. From now any 5.1 or 5.2 changes I will leave until we have 5.0 support stable.

Closing this PR in favour of PR #172


[T3A2][T11-A3]Shailesh Nahata

Ready for review

@nahata-shailesh Some comments added. Please close the PR after reading comments.


openpilot Longitudinal Control not working anymore with 2021 Hyundai Sonata N Line on comma 3

Describe the bug
Installed master (c01e622e828c1c2e41ac9708a74e4209811ad07b) on the comma three and went into /data/params/d/DisableRadar to saved with 1. The car does not seem to have openpilotLongitudinalControl enabled, no lead car indicator (triangle), cruise control SET/RES does not increment/decrement speed by 5 MPH, etc. After multiple reboots it is still the same. Verified that DisableRadar stays consistent with 1 after multiple reboots. Radar points were previously enabled on the car with /data/openpilot/selfdrive/debug/hyundai_enable_radar_points.py.
How to reproduce or log data

Install master (c01e622e828c1c2e41ac9708a74e4209811ad07b) on comma three
Create /data/params/d/DisableRadar and save with 1.
Reboot comma three
No lead car indicator (triangle) or SCC/ACC with SET/RES to perform 5 MPH increment/decrement cruise set speed change.

Device/Version information (please complete the following information):

Device: comma three
Dongle ID: 36e10531feea61a4
Route: 36e10531feea61a4|2021-09-22--09-39-27
Timestamp: Entire drive
Version: master (c01e622e828c1c2e41ac9708a74e4209811ad07b)
Car make/model: Hyundai Sonata N Line 2021

You wrote 1\n into the param, that doesn't work. Use echo -n "1" > /data/params/d/DisableRadar


DEVPROD-7857: Send Sentry alerts for 422 errors in Parsley

DEVPROD-7857

Description
Copies Spruce's configuration for logging GraphQL errors. I would move some stuff up to the lib level but I think it'd make more sense to move utils/errorReporting up first.
Testing

Sample issue

Do you think the GQL client creation code can be shared? Not suggesting for this PR but curious what you think.

good question... I think it would be good if we could share it. The only thing that might make it tricky is how each app has its own set of queries so we can't seem to really "share" the SecretFields query. ☹ I feel like that might be the first obstacle.


Icon request: Shopify

URL of the site or app: https://www.shopify.com
Logo resources for the icon: https://www.shopify.com/brand-assets
Hex color of the main brand color: #95bf47

ps: Happy to help make icons if you'd like. I've made an SVG myself, but I can't attach it here.

If you mean icons, yeah sure (as long at it uses template downloaded from repo, "ai_icon_template.ait"). I haven't done guidelines or anything like that (yet), only guideline is using template and its guides. Sorry if that sounds confusing. 😅
Github doesn't like SVGs as attachments for some reason, you need pack the file into ZIP folder in order to upload it.
Anyways, here's the icon: https://github.com/krisu5/aegis-icons/blob/master/PNG/Shopify.png


Document installation on vSphere

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When installing cilium on a recent enough VMware hardware compatibility version (i.e >=15 or maybe >=14), cilium connectivity breaks because of hardware segmentation offload.
Symtoms:
cilium-health status has ICMP connectivity working, but not TCP connectivity. cilium-health status may also fail completely.
This can be fixed with:
$ sudo ethtool -K ens192 tx-udp_tnl-segmentation off
$ sudo ethtool -K ens192 tx-udp_tnl-csum-segmentation off

NB: This is similar to Anthos.
Cilium Version
v1.12.2
Kernel Version
5.10.106
Kubernetes Version
1.24.6
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@sathieu it looks that all you are suggesting is to add documentation on how to deploy Cilium on vSphere. Would you like to submit a PR? Thank you

Hi
Just to mention I've spent 3 days trying to get this working until I came across this post which has fixed the issue.
We have master nodes on VMWare, so the same underlying issue. It would have been really helpful to see this in the documentation!

@dangoscomb I'll write a doc. Can you give me more info on your setup? Which distro and which kernel version?
I suspect recent kernels are not affected (this kind of commit: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/net/vmxnet3?h=linux-6.0.y&id=6f91f4ba0).

Can someone reopen this issue? @aanm ?

Sure thing.
The guest VM is Ubuntu 22.04.2 LTS, kernel 5.15.0-72-generic using VMXNET3 and HW version 15.
The underlying stack is vcloud 1, NSX-V 6.4 and ESXi 6.7.

We have the same problem using Talos Kubernetes. Tested with Linux Kernel version 5 and vSphere 7, using compatibility version 15.

Good morning,
we have the same problem. We are using plain Kubernetes in version 1.26.4 on Ubuntu 22.04.2 LTS & Kernel 5.15.0-73-generic.

cross reference for vsphere, it seams the VMXNET3 network adapter is the problematic one https://github.com/cilium/cilium/issues/13096#issuecomment-723901955

As someone tested a newer kernel (> 6.x)?

As someone tested a newer kernel (> 6.x)?

Yes same VMXNet driver version on the version 6 kernel we ran. It was on vsphere 7.

I don't know how to reopen, trying:
/reopen
This is still relevant.

I ran into this issue with the following stack:
Ubuntu 22.04.3 LTS (Kernel 5.15.0-79-generic), CNCF Kubernetes v1.25 / v1.26, Cilium 1.14.1, VMware ESXi 7.0.3 Build 21424296

$ sudo ethtool -K ens192 tx-udp_tnl-segmentation off
$ sudo ethtool -K ens192 tx-udp_tnl-csum-segmentation off

There you go, I just spent three days debugging the stack before finding out this.
Everything was running fine while all the vms  (three master nodes and three workers) were placed on the same esxi host; adding a new vm created on a new host with a gpu caused the problems. The node join went fine, but no intra-cluster communication was working.
Running the commands on all the nodes fixed the issue.
Stack:

Ubuntu 22.04.3 5.15.0-86-generic
vSphere 7.0U2
k3s v1.26.8 +k3s1
Cilium 1.14

Hi,
for persist the configuration you can use:
nmcli connection modify ens192 ethtool.feature-tx-udp_tnl-segmentation off ethtool.feature-tx-udp_tnl-csum-segmentation off

how there: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_and_managing_networking/configuring-ethtool-settings-in-networkmanager-connection-profiles_configuring-and-managing-networking

We are facing this issue too
Stack:

Kubernetes: v1.26.8+rk2k14 (RKE2)
Oracle Linux Server 8.8
kernel 5.15.0-<IP_ADDRESS>.el8uek.x86_64
Cilium 1.14
vSphere 8.0.2

Hi @dzanto,
unfortunately we don't have nmcli installed on the nodes.

We hit the same issue and spent ~3 days to figure out what was wrong. Thank you so much for creating this issue.
Our setup:
Kubernetes: v1.24.12
Linux: Flatcar 3602.2.1
vSphare: 7.0.3
Cilium: v1.13.6

Hi everyone! I got the same issue.
My environment:
Kubernetes: v1.24.3
Linux: RHEL 8.7
vSphere: 7.03.0140
Cilium: v1.14.5 (before upgrade v1.12.0, both versions are affected to the issue)

So the main problem this fix doesn't help.
sudo ethtool -K ens192 tx-udp_tnl-segmentation off
sudo ethtool -K ens192 tx-udp_tnl-csum-segmentation off

Thanks to this Issue: https://github.com/orange-cloudfoundry/paas-templates/issues/2062
So the full fix that helps is:
sudo ethtool -K ens192 tx-udp_tnl-segmentation off
sudo ethtool -K ens192 tx-udp_tnl-csum-segmentation off
sudo ethtool --offload ens192 rx off tx off

And the permanent fix will look like:
nmcli connection modify ens192 ethtool.feature-tx-udp_tnl-segmentation off ethtool.feature-tx-udp_tnl-csum-segmentation off ethtool.feature-tx-checksum-ip-generic off ethtool.feature-tx-tcp-segmentation off ethtool.feature-tx-tcp6-segmentation off
Thanks to everyone, it was really hard to find and fix 🙏

Another VMware specific issue: If you're using NSX-T, DSR (Direct Server Return) won't work for virtual IP (with MetalLB or L2 annoncements), unless you add exceptions.
This can be done following https://docs.vmware.com/en/VMware-NSX-T-Data-Center/3.2/administration/GUID-3B3C278D-4E35-4CE9-A4E2-ED6B1F25ABCE.html

This seems to be a common problem, adding a reference to this issue as a temporary measure here seems like a good idea: https://docs.cilium.io/en/stable/operations/troubleshooting/
The troubleshooting article has lots of informations about how to SEE things aren't working well, but none about how to actually fix the problems.
Granted this isn't a problem with cilium per se, there's no effective way to debug what's wrong at a glance. Especially considering communication between nodes is never broken.

Not stale.
I don't have the time to work on this. I think keeping this issue opened can help people.

Thanks for creating this issue. I also spent three days trying to figure out where the heck traffic to pod-on-other-node is disappearing into.

Talos v1.7.x (kernel 6.6.x)
Cilium v1.15.3+
VMware ESXi v7.0.3

Running the mentioned ethtool-commands works for me.

Hi everyone, still seeing this. The ethtool commands worked in this case too. Unsure if relevant but it looks like in this case this was only triggered after a K8s version rolling upgrade, which ended-up placing 2 nodes on the same Host. Before that, all nodes were on different hosts and there were no issues whatsoever.

K8s 1.29.0
Ubuntu 22.04 (kernel 5.15.0-97-generic)
VMware ESXi 7.0.3
Cilium v1.15.1

Thanks for creating this issue. I also spent three days trying to figure out where the heck traffic to pod-on-other-node is disappearing into.

Talos v1.7.x (kernel 6.6.x)
Cilium v1.15.3+
VMware ESXi v7.0.3

Running the mentioned ethtool-commands works for me.

How did you execute the command in Talos?

@rgomezceis We run a static pod on all nodes with ethtool installed and used hostNetwork: true in the pod spec: kubectl explain pod.spec.hostNetwork.

@rgomezceis We run a static pod on all nodes with ethtool installed and used hostNetwork: true in the pod spec: kubectl explain pod.spec.hostNetwork.

But when a node reboots, tx-udp_tnl-segmentation tx-udp_tnl-csum-segmentation will be on again

If you have a static pod the pod will start with the node, the commands will run again if you have in the startup script of the container in the pod. Static pods are per node. So in Talos you need to have the static pod configuration for every node in the machine configuration.

If you have a static pod the pod will start with the node, the commands will run again if you have it in the startup script of the container in the pod. Static pods are per node. So in Talos you need to have the static pod configuration for every node in the machine configuration.

Ok, thank you mate.

@YutaroHayakawa , could you maybe weight in on this, considering your recent and very excellent post on this?
I think a lot of Cilium users would benefit from knowing for certain this is not a Cilium issue (if that is the case)

Hi,
Get the same issue (and make the same times... for found and fix...)
The setup

K8S 1.29(.9) via RKE2 (v1.29.9+rke2r1)
Cilium 1.16.1 (from RKE2...)
Ubuntu 22.04 LTS HWE kernel (6.8)
VMware vSphere and ESXi 7.0 U3
Using VSS (vSwitch Standard) and VMNet3 and VM hardware 19

i will make more test for try to reproduce on some other vSphere environnement...

Hi,
Get the same issue (and make the same times... for found and fix...)
The setup
* K8S 1.29(.9) via RKE2 ([v1.29.9+rke2r1](https://github.com/rancher/rke2/releases/tag/v1.29.9%2Brke2r1))

* Cilium 1.16.1 (from RKE2...)

* Ubuntu 22.04 LTS HWE kernel (6.8)

* VMware vSphere 7.0.U3 (<IP_ADDRESS>00) and ESXi  7.0.3 (20842708)

* Using VSS (vSwitch Standard) and VMNet3 and VM hardware 19

i will make more test for try to reproduce on some other vSphere environnement...

try with VM on the same host or different host -> same issue
try using VDS (vSwitch Distributed) -> same issue

Hi everyone,
I'm one of the Cilium committers and taking a look at this issue.
I'm wondering if there is something about how we setup our VXLAN overlay in Cilium that could trigger this bug in ESXi. Google does mention a similar issue on Anthos, but only for GENEVE encapsulation.
ESXi has had a similar issue in the past, but it should be fixed with ESXi 7.0 Update 3 for the standard VXLAN ports (8472 in Cilium's case, by default). Even if we were not using one of the standard ports, the issue was also fixed in the vmxnet3 driver in Linux v5.14. Yet, we have several reports here with ESXi 7.0 Update 3 and Linux v5.15.
If anyone has a reproduction, would you be able to switch Cilium's VXLAN port to 4789 (the other standard port) to check if that makes a difference? You can do that with --tunnel-port 4789 (Cilium agent) or tunnelPort=4789 (Helm).
In addition, could anyone check errors from the vmxnet3 driver? You can do that with the two following commands (by replacing the value between brackets with your specific values):
# net-stats -l | grep [Your_VM]
2100663515          4       0 DvsPortset-1     00:50:56:01:03:9f  [Your_VM]

# vsish -e get /net/portsets/[DvsPortset-1]/ports/[100663515]/vmxnet3/txSummary
stats of a vmxnet3 vNIC tx queue {
   [...]
   failed to split a giant tso pkt:0
   giant non-tso pkts requiring more than 1 pkt handle:0
   encap (outer) header errors:228
   encap (inner) tso header errors:0
   number of memory region lookup pass in Tx.:0
   [...]

The output of the second command is what matters here, specifically the error counters.

Hi @pchaigno
Thanks for the idea about NSX issue
Yes, i have NSX(-T) on this cluster ! (i update the message)
I try with the same VM on multiple cluster

ESXi 7.0.3 (22348816 - 7.0 U3o) with DVS -> no issue
ESXi 8.0.2 (22380479 - 8.0 U2) with DVS -> no issue

But with ESXi 7.0.3 (21313628 - 7.0 U3k) with DVS and NSX-T (3.x) -> get the same issue
but the vsish don't get encap (outer) header errors...
i will continue my test with change port...


GPIOViewer v1.0.5

I am sorry to say: earlier this week it worked perfectly (using ESP Board 2,0,11.
As a test I left the power on for 24hours.
Now i get this:

I have updated the library to 1,0,5: but the same result.
My test code is:
const int ledPin = 2;
#include <gpio_viewer.h> // Must me the first include in your project
GPIOViewer gpio_viewer;
void setup() {
Serial.begin(115200);
// Comment the next line, If your code already include connection to Wifi
gpio_viewer.connectToWifi("", "*******");
gpio_viewer.setPort(5555);
pinMode(ledPin, OUTPUT); // Initialize GPIO 2 as an output
gpio_viewer.setSamplingInterval(250);
gpio_viewer.begin();
}
void loop() {
digitalWrite(ledPin, HIGH); // Turn on the LED
delay(1000); // Wait for 1 second
digitalWrite(ledPin, LOW); // Turn off the LED
delay(1000); // Wait for 1 second
}
I am very fond to integrate this GPIOVIEWER in many of my projects but I must be sure that it is stable,

I am also confused: On the Github it is said "Latest Version" = 1.0.5 but when I install that it seems to be 1.0.4!!!

1.0.5 I also encountered the same problem, the webpage cannot be displayed and remains in an incomplete open state

Is there a message on the Serial Monitor like "GPIOViewer >> Connected, sampling interval is" that appears when you refresh your browser window ?


[Bug] Correct the FAQ  open and close issue and also private routes

Fixes Issue #1821
Closes #1821

Changes proposed

Screenshots
https://github.com/user-attachments/assets/a163bb79-1085-4bcc-bfd3-90bac502f4c7

Note to reviewers

Summary by CodeRabbit

New Features

Improved FAQ section with expandable/collapsible items for better navigation.

Bug Fixes

Corrected routing hierarchy for the Return and Cancellation page to ensure proper navigation.

Style

Updated FAQ question text to display as a question.

hello @codervivek5
please review this PR and merge it


[FR] Add tracing support

This PR adds OpenTelementry to support a host of APM services for tracing, logging and metrics collection.
Fixes #6208

I have tested this now with Elastic, New Relic, Grafana Cloud and Datadog and man, this format/standard is great. You can basically just switch metrics/tracing vendor by changing just endpoint and header

@matmair looks pretty good to me - can you please add some information to the docs also?

@SchrodingersGat I added docs for the settings. Is this enough?

Yeah, LGTM

@matmair sorry I meant to loop back to this. Are you happy now to merge in? I'd like to discuss offline how we set this up for the demo instance

@SchrodingersGat yes, certainly!


Fix DragAndDropHandler to properly support hands over the gaze pointer

Overview
The original issue with DragAndDropHandler was that the gaze pointer was sending its own input source across the Pointer events, instead of the input source that originally sent the event.
This updates the pointer event methods to allow for an input source that's different from the pointer's input source. This allows matching position events to pointer events, and vice versa.
This change also adds support for moving objects with the tip of a controller's pointer ray, instead of with the source's position. Over the gaze pointer, the position is used.
Changes

Fixes: #2960

Blocked By

[ ] #3301

Is there a reason why we merged a PR that had change requests?

Since when did we merge pull requests that are blocked or have change requests?
This is absolutely unacceptable.

I would have to agree, we cannot be in a position where changes proposed by the community are refused to be accepted until SM staff are finally happy, and then merge a change that the community has severe objections too.  This change introduces more risk as highlighted by @StephenHodgson above, these comments just seem to be ignored by consensus internally.

This change solved a customer usability issue on HoloLens. We have heard feedback from our partners that previous behavior was confusing and unintuitive.


Can't set single worded directory for AEM instances

I would like to create my AEM instances under single worded directory e.g. author, publish to be consistent with the existing approach in my company.

closed as released and available in 3.1.0

type name will be directory name, constraint is that it must begin with author or publish e.g author-master, author1 etc


Stub for methods

Description
Added stub for methods.
Checklist
The following items should be checked before the pull request can be merged.

[X] Code follows existing style.
[X] Unit tests added (if applicable).

Made a similar PR (#1137) that fixed the issue, without seeing it was a duplicate of this, LGTM


Docs: add coverage badge

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (5585298) compared to base (acc5c92).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          125       125
  Branches        34        34
=========================================
  Hits           125       125

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Optimize SQLite schema and queries

With lots of different URIs being stored, the underlying SQLite database is becoming significantly slower.
My knowledge about DB optimization is limited, but I feel like defining an index column for the uri.value column would be a good first step. Database schema and queries are defined here:
https://github.com/kellnerd/snap_storage/blob/653a8c9e8123d6c25ae3f11832bf318266b19f88/src/snap_storage.ts#L65-L90

EXPLAIN QUERY PLAN
SELECT timestamp, content_hash FROM snap
JOIN uri ON snap.uri_id = uri.id
WHERE uri.value = 'https://api.deezer.com/track/2729047191' AND timestamp <=<PHONE_NUMBER>
ORDER BY timestamp DESC;

id	parent	notused	detail
5	0	0	SEARCH uri USING COVERING INDEX sqlite_autoindex_uri_1 (value=?)
9	0	0	SCAN snap
26	0	0	USE TEMP B-TREE FOR ORDER BY

If I interpret this query plan correctly, the uri.value column is unproblematic as it is already indexed (because of its unique constraint). Scanning all snaps for snap.uri_id is the expensive part which has to be optimized.

The single query that seems to be done is:
SELECT timestamp, content_hash FROM snap
JOIN uri ON snap.uri_id = uri.id
WHERE uri.value = ? AND timestamp <= ?
ORDER BY timestamp DESC
LIMIT 1;

I looked at the execution plan with:
EXPLAIN SELECT timestamp, content_hash FROM snap
JOIN uri ON snap.uri_id = uri.id
WHERE uri.value = '' AND timestamp <= 1
ORDER BY timestamp DESC
LIMIT 1;

The following index seems to result in an optimized query:
CREATE INDEX IF NOT EXISTS idx_snap_uri_id_timestamp ON snap (uri_id, timestamp DESC);

This improves the request on the timestamp and also seems to help with the join. Creating the index on uri.value instead seems not to get used by sqlite, it resulted in the same execution plan.
But needs testing and benchmarking with a full database, I only checked quickly with a nearly empty one.
Other candidates would be timestamp and uri_id but in reversed order, but this seems to be a bit less efficient.

CREATE INDEX IF NOT EXISTS idx_snap_uri_id_timestamp ON snap (uri_id, timestamp DESC);

EXPLAIN QUERY PLAN SELECT timestamp, content_hash FROM snap
JOIN uri ON snap.uri_id = uri.id
WHERE uri.value = '' AND timestamp <= 1
ORDER BY timestamp DESC
LIMIT 1;

Gives:

6
0
0
SEARCH uri USING COVERING INDEX sqlite_autoindex_uri_1 (value=?)

10
0
0
SEARCH snap USING INDEX idx_snap_uri_id_timestamp (uri_id=?  AND timestamp<?)     (cycles=38892 [16%] loops=1 rows=2)

Cycles (which is apparently a good proxy for wall clock time) is reduced by ~77x reduction once the index suggested by @phw is created.

Thank you both, I have now added this index in https://github.com/kellnerd/snap_storage/commit/161f02201d2e4ec613d17e07a86d431acf0416ac and released v0.6.2.


runtime: consider using batched shuffle in selectgo

This is a minor optimization opportunity. runtime.selectgo typically does a shuffle of a fairly small number of channels. https://lemire.me/blog/2024/08/17/faster-random-integer-generation-with-batching/ introduces an optimization for such shuffles. It might be worth incorporating the technique into selectgo. (math/rand/v2 is probably not possible due to backwards compat.)

In triage, I don't think we have the bandwidth to look into this now, but patches welcome. :)

@josharian  Do you know how we might benchmark this?

Something like BenchmarkSelectSync* in package runtime. Maybe add some benchmarks with more cases.


Customizable Label class

A customizable label class is needed to help control and allow customization of labels on tracks
Editor:

WPF ListView where new label elements can be added via Factory behavior on Label Element base class
Subsequent plain elements or groups will be organized on subsequent lines
Groups for multiple label elements - organizes them on a single line with a separator ("/" or "|" in most cases, this can be tweaked)

Label Element:

Generic/Abstract base class with factory behavior
Derived classes will reference a single value/property on the target class - will need Reflection
Each element will only retrieve the ToString() value of each property

If a property is null, the output will be a hyphen "-"

Label class structure is functioning! Needs UI assembled to make it useful alongside some Bullseye-handling LabelItems, but it's working.


Panic in HugrView::linked_inputs/linked_outputs

This testcase seems "reasonable" to me:
    #[test]
    fn unconnected_outputs() {
        use crate::builder::test::simple_dfg_hugr;
        let hugr = simple_dfg_hugr();
        let mut it = hugr.linked_inputs(hugr.root(), 0);
        assert_eq!(it.next(), None);
    }

(it is quite legal to have no inputs linked to a Copyable output)
However linked_inputs panics in this unwrap: (https://github.com/CQCL/hugr/blob/24125995fc624579924f3a629d09a3e8ce372563/hugr-core/src/hugr/views.rs#L615-L621)
The same problem occurs usinglinked_outputs where one could perhaps argue that there should always be some outputs, but either way, surely we should return an empty iterator rather than panic?

I wonder if it's time to drop the associated types in HugrView and use RPTIT?

The root node of the hugr is a special case that does not have any ports, hugr.linked_inputs(hugr.root(), 0) is asking for an invalid port.
I see a couple options here:

Leave things as-is
Make linked_outputs return an empty iterator for invalid ports`
Add unconnected ports to the hugr root. This will break validation.

I wonder if it's time to drop the associated types in HugrView and use RPTIT?

And yes, there's an old TODO to replace the context_iterators dependency. It's an annoying refactor, but should help clear up things.

Add unconnected ports to the hugr root. This will break validation.

This seems a little odd to me - ATM the ports of the root node do not match its Signature. Seems reasonable not to have any ports at the portgraph level (there are no legal endpoints), but I'd have said they should exist at the Hugr level (as described by the Signature, so at least we could be consistent there). I think this is roughly your second option, although I think it'd be fair to panic (rather than return empty) for a port not described by the node's Signature (e.g. linked_outputs(hugr.root(), 10) in my example above)

Thanks for the fix @aborgna-q ! :)


Avoid cropping of text?

Is it possible or would it be possible to specify the text width to avoid cropping? I have quite short polylines and the text gets cropped to the lenght of the polyline. I would like to see the full text even if it not fits on the polyline.
Screenshot:

Hi
For anyone else who has this question.
I solved my problem creating one more polyline, invisible, with enough length to don't crop the text.

Is it possible or would it be possible to specify the text width to avoid cropping? I have quite short polylines and the text gets cropped to the lenght of the polyline. I would like to see the full text even if it not fits on the polyline.
Screenshot:

Somebody knows how to fix this?


Allow to specify port ranges for outgoing NAT.

This allows to specify port ranges for NAT which is a valid pf configuration. With this change I can add 3000:3100 in the UI and see this in the ruleset:
pfctl -sn
no nat proto carp all
nat on pppoe0 inet proto tcp from any to <API_Endpoints> -> (pppoe0:0) port 3000:3100
nat on pppoe0 inet from (bridge0:network) to any port = isakmp -> (pppoe0:0) static-port
nat on pppoe0 inet from (lo0:network) to any port = isakmp -> (pppoe0:0) static-port
nat on pppoe0 inet from <IP_ADDRESS>/8 to any port = isakmp -> (pppoe0:0) static-port
nat on pppoe0 inet from (bridge0:network) to any -> (pppoe0:0) port 1024:65535
nat on pppoe0 inet from (lo0:network) to any -> (pppoe0:0) port 1024:65535
nat on pppoe0 inet from <IP_ADDRESS>/8 to any -> (pppoe0:0) port 1024:65535
no rdr proto carp all
no rdr on bridge0 proto tcp from any to (bridge0) port = ssh
no rdr on bridge0 proto tcp from any to (bridge0) port = http
no rdr on bridge0 proto tcp from any to (bridge0) port = https
rdr-anchor "miniupnpd" all

@nikolay-te looks reasonable, thanks!


feat(atomic-swap-erc20): implemented plugin and test

Resolve #568
Depends on #586

@jordigiam Just checking to make sure: is this still being worked on or is it ready to review? Just checking because it doesn't show up on my personal PR filter 1 but it looks like you addressed everything I was saying.

@jordigiam

You can make the tests pass if you rebase onto https://github.com/hyperledger/cactus/pull/915
Please squash all the commits together into one.


[5.6][CSClosure] Support empty return when closure result is optional Void

Source compatibility workaround.
func test<T>(_: () -> T?) {
  ...
}

A multi-statement closure passed to test that has an optional
Void result type inferred from the body allows:

empty return(s);
to skip return nil or return () at the end.

Implicit return () has to be inserted as the last element
of the body if there is none. This wasn't needed before SE-0326
because result type was (incorrectly) inferred as Void due to
the body being skipped.
Resolves: rdar://85840941
(cherry picked from commit f287f7e6e458586fcb9fafa2248a130ec82d5ded)
(cherry picked from commit 5700516f2d81458a74c3db811f39ec992436bab4)

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test macOS platform

@swift-ci please test Linux platform


Why does readMap return an array?

first of all, I'm extremely new to golang, so sorry in advance if what I'm saying doesn't make much sense
func readMap(i *bufio.Reader) (m RedisMessage, err error) {
	length, err := readI(i)
	if err == errChunked {
		m.values, err = readE(i)
	} else {
		m.values, err = readA(i, int(length*2))
	}
	if err != nil {
		return RedisMessage{}, err
	}
	return
}

IIUC readMap will assign m.values, which is an array.
shouldn't RedisMessage have a map member?

Hi @guybe7,
The RedisMessage is just an intermediate container. Reusing the values field is enough for holding map response temporary.
The RedisMessage could have a map member of course, but that would make it a bigger struct.

hi @rueian thanks for the quick reply.
i guess my question is: if I execute Hgetall, will the returned reply be of type map?

You can use RedisMessage.AsStrMap to get a map:
c, _ := rueidis.NewClient(rueidis.ClientOption{InitAddress: []string{"<IP_ADDRESS>:6377"}})
defer c.Close()

m, _ := c.Do(context.Background(), c.B().Hgetall().Key("key").Build()).AsStrMap()

for key, value := range m {
	fmt.Println(key, value)
}

Error handling is omitted.


[mxnet-R] More high-level APIs?

It would be nice to have some high level APIs that users can just  plug in and play with, e.g. RNN/LSTM since I don't think most R users would be able to implement it themselves. Imagine rewriting this Python implementation in R - https://github.com/dmlc/mxnet/tree/master/example/rnn

I am thinking about proposing this as a GSOC project. At least we can have someone to work on this.

Sounds good. KK can you lead this issue?
On Sat, Feb 13, 2016 at 3:49 PM Qiang Kou (KK<EMAIL_ADDRESS>wrote:

I am thinking about proposing this as a GSOC project. At least we can have
someone to work on this.
—
Reply to this email directly or view it on GitHub
https://github.com/dmlc/mxnet/issues/1420#issuecomment-183773064.

I have post a drat at https://github.com/rstats-gsoc/gsoc2016/wiki/Deep-learning-with-mxnet
We can add more details later.

Looks good. Thanks!

@terrytangyuan BTW, are you willing to be a co-mentor?

Sure. :-)

Here linked is a RNN model learning 8-digit binary addition, which is implemented in Rcpp. Though not high-level implementation, it might be helpful for some others who want to participate in this GSOC project, as Cpp/Rcpp is much involved.
See: https://gist.github.com/Puriney/072a37ea8a181f0b6168
I have great interest in GSOC. If possible, could your mentors list easy->medium->hard tests?

Maybe you can try an easy/medium/hard issue.

@thirdwing Looks like we are not registered as a organization for GSoC. We cannot co-mentor for one project.

We are under R project.
On Mar 25, 2016 10:24 AM, "Yuan (Terry) Tang"<EMAIL_ADDRESS>wrote:

@thirdwing https://github.com/thirdwing Looks like we are not
registered as a organization for GSoC. We cannot co-mentor for one project.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/dmlc/mxnet/issues/1420#issuecomment-201308098

Oh I missed your last email. I will communicate with you there then.

@ziyeqinghan Any status update?

Sorry I missed the communications. I think I can close this now. Thanks! @ziyeqinghan


Removed wrong sentence about more that 3-months-old clients in teams-client-update.md

I tested and:

Related to https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/7098.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


fix: 🐛 error on IE while running native findIndex

Closes https://github.com/diogofcunha/react-virtualized-tree/issues/58

Coverage remained the same at 94.972% when pulling 0162e97ecb799b3e7348aeb6d0e8a76edfdea7a9 on find-index into 2671fbdb4a1d0b415160ba876ab307dce90d06b2 on master.

:tada: This PR is included in version 2.3.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


This script needs OSFmount to run. Please install it.

Im running the HiyaCFW.exe with Administrator, but its just giving me all the time this error: (This script needs OSFmount to run. Please install it.) I already installed it and restarded my pc 3 times, but it doesent work. I reinstalled it, I tried everything but nothing works. HELP!

Im using the newest Version of Windows 10 by the way.

So I found an fix myself, you need to install the 2.0 Version of OSFmount and not the newest than it should work!


map bitmaps through a bounded window to avoid excessive disk pressure…

Description
Having discussed the problem with @suddendust and @subintp, the memory mapping error observed in #7476 appears to be correlated with very high disk usage, rather than high tmpfs usage as I initially suspected. They are using inverted and range indexes. The assumption behind BitmapInvertedIndexWriter is that there is a lot of disk space available, and that it's ok to overmap and truncate in order to avoid syscall overhead, but this results in high disk usage. Allocating file space for the serialised inverted indexes as it is needed feels like a good usability tradeoff.
The strategy builds on some knowledge about how the bitmaps get serialised: a single bitmap never needs more than 256MB, so we never map more than 256MB at a time. Bitmaps should be fairly sparse most of the time, so we guess that we need numBitmaps * 64KB but if this estimate proves to be too small, the pessimistic 256MB is used for the next section.
An alternative approach I considered is to just build the bitmaps all at once on heap, compute their sizes, then map the space needed once, which would be optimal in terms of disk usage and syscalls, but may lead to a little extra medium lifespan garbage.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Thanks for the quick fix Richard.

Codecov Report

Merging #7535 (1c12485) into master (6969b38) will decrease coverage by 2.75%.
The diff coverage is 95.83%.

@@             Coverage Diff              @@
##             master    #7535      +/-   ##
============================================
- Coverage     72.64%   69.88%   -2.76%
+ Complexity     3412     3340      -72
============================================
  Files          1524     1129     -395
  Lines         75699    53495   -22204
  Branches      11039     8061    -2978
============================================
- Hits          54988    37383   -17605
+ Misses        17021    13462    -3559
+ Partials       3690     2650    -1040

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
69.88% <95.83%> (+0.01%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...nt/creator/impl/inv/BitmapInvertedIndexWriter.java
90.00% <95.83%> (+3.63%)
:arrow_up:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...g/apache/pinot/common/metrics/ControllerMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/pinot/common/messages/SegmentReloadMessage.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pinot/core/data/manager/realtime/TimerService.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...not/common/exception/HttpErrorStatusException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...t/core/startree/plan/StarTreeDocIdSetPlanNode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ot/common/restlet/resources/TableMetadataInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 599 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6969b38...1c12485. Read the comment docs.


Pre-training code

Thank you for sharing. Can you please give me a package project code pre-trained on the ImageNet dataset?My email is<EMAIL_ADDRESS>Thank you!

Sent.

OK, I have received it, thank you!

I also want a copy of the pre-trained code. Can you send me one?My email is<EMAIL_ADDRESS>Thank you!

I also want a copy of the pre-trained code. Can you send me one?My email is<EMAIL_ADDRESS>Thank you!

Okay, can I add your WeChat account?

I also want a copy of the pre-trained code. Can you send me one?My email is<EMAIL_ADDRESS>Thank you!

Okay, can I add your WeChat account?I have a question I want to discuss with you.

Sent to your email

I also want a copy of the pre-trained code. Can you send me one?My email is<EMAIL_ADDRESS>Thank you!

Okay, can I add your WeChat account?I have a question I want to discuss with you.

Sent to your email

QQ mailbox cannot be logged in at the moment. I will send you the pre-training code tomorrow.

I also want a copy of the pre-trained code. Can you send me one?My email is<EMAIL_ADDRESS>Thank you!

Okay, can I add your WeChat account?I have a question I want to discuss with you.

Sent to your email

QQ mailbox cannot be logged in at the moment. I will send you the pre-training code tomorrow.

My wechat account is wu517130415

I want a copy of pre-training code, too. My email<EMAIL_ADDRESS>Thank you in advance!

Hi @Shaw-Way , I have sent you a copy.

Hi @Shaw-Way , I have sent you a copy.

Thank you so much! Have a nice day.

Thank you for your research work @noahzn. I would like to reproduce your work, so could you please send me the code for pre-training the DepthNet on ImageNet dataset? My email is<EMAIL_ADDRESS>Thank you for your help!


Filesystem based cache

Nginx provides a filesystem+memory hybrid cache which is useful for serving largeish static files.
This would be a nice addition here because it fits nicely with Kubernetes emptyDir type volume which allows a pod to get a temporary writable filesystem mount which is alive as long as the pod is alive. It would mean it could locally store and serve large-ish files without polluting memory and the distributed store (like Redis) with it, and the cache not persisting a reboot is not a big deal.

Hello, you could use the nuts storage provider that supports the filesystem stored data IMHO.

@darkweak ah interesting, would you mind creating a minimal example of that, maybe we could add it to the docs? I'd imagine it would be a common pattern for this specific use case. I did go through their docs about it, but seem to have missed it.

I can see it's already documented such as
        nuts {
            path /tmp
        }

I've checked why it doesn't work for me and it's actually because of https://github.com/darkweak/souin/issues/345 which is unrelated, closing here.


Q: trisurf with controlable transparency color

Is it possible to have transparent colors for surfaces, e.g.
alpha = [0., 1., .5, ...]
colors = np.c_[rgb, alpha]
p3.plot_trisurf(x, y, z, triangles=tris, color=colors)

duplicate of #56

indeed 👍


Add GPT-4 support (when we get access to the API)

I am on the waitlist, so either once I am accepted into it, or when it is released publicly. GPT-4 should allow for drastically larger input documents, and when GPT-4's image understanding model gets released, we can add support for including images to summarize as well. This would also mean that we could maybe do some things with video processing as well, like for lecture slides. This may be beyond our scope, but it would be really cool so we can keep it in mind.

GPT-4 is now generally available, so this can be implemented


[Bug]: section_navigation highlighting

What happened?
Using the section_navigation macro there is an issue where multiple nav options get highlighted when specifying a currentPath where one path is an extended url of another path
What was the expected outcome?
Only the current page nav option gets highlighted
How is this problem impacting your service?
Minor annoyance - I have got around it by changing my urls slightly
What list of steps can be followed to reproduce the bug or issue?
Use the section_navigation macro.
Set option 1 url = response/historic-responses
Set option 2 url = response/historic-responses-adjusted
Set currentPath to option 2 url
When on option 1 page the current tab is highlighted as option 1, but when on option 2 page options 1 and 2 are highlighted
I think this is because the test uses an 'in' and as option 1 is in option 2, both get highlighted
Example
No response
What version of the ONS Design System are you using?
45.2.2
What devices are you seeing the problem on?

[ ] Desktop
[ ] Mobile
[ ] Tablet

Device details
No response
What operating systems are you seeing the problem on?

[ ] Windows
[ ] macOS
[ ] Android
[ ] iOS
[ ] Other

Operating system details
No response
What browsers are you seeing the problem on?

[ ] Firefox
[ ] Chrome
[ ] Safari
[ ] Microsoft Edge
[ ] Microsoft Internet Explorer
[ ] Other

Browser details
No response

Duplicate of #2206


Simplify tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (362672d) 79.48% compared to head (31c1ea1) 79.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   79.48%   79.48%
=======================================
  Files           3        3
  Lines         195      195
=======================================
  Hits          155      155
  Misses         31       31
  Partials        9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Encapsulate shape building, hiding complexities from callers, and

enhance shape file saving to allow fro specified file format and type.

Greg,
I think the BaseShape constructor should not take arguments because the arguments, such as angle, don't make sense for a general base shape object.
The rest looks good.
Thanks.

Greg,
Also, It's easier to derive from a class that takes no argument in the constructor...
--Alex


Cannot access ROOT url on fresh instance

I am getting browser console errors when starting a fresh instance of Soverign:

Uncaught TypeError: Cannot read property 'analytics' of undefined (global-imports.js:18)
Uncaught ReferenceError: meteorInstall is not defined (app.js:1)

I would like to set up a local development environment, but cannot get past this error. I have followed the instructions in README.

I followed the README instructions as well, and I cannot reproduce your issue. I tried Mozilla Firefox 50.1.0, Chrome 55.0.2883.87, and even Chromium for good measure.
The only error I can find is when I'm logged out the console shows:
Exception in callback of async function: TypeError: Cannot read property 'username' of null

What's your output of meteor npm version ?
$ meteor npm version
{ npm: '3.10.9',
  ares: '1.10.1-DEV',
  http_parser: '2.7.0',
  icu: '56.1',
  modules: '46',
  node: '4.6.2',
  openssl: '1.0.2j',
  uv: '1.9.1',
  v8: '<IP_ADDRESS>',
  zlib: '1.2.8' }

$ meteor --version
Meteor <IP_ADDRESS>

$ meteor npm version
{ npm: '3.10.9',
  ares: '1.10.1-DEV',
  http_parser: '2.7.0',
  icu: '56.1',
  modules: '46',
  node: '4.6.2',
  openssl: '1.0.2j',
  uv: '1.9.1',
  v8: '<IP_ADDRESS>',
  zlib: '1.2.8' }

$ meteor --version
Meteor <IP_ADDRESS>

Here is a screencast showing steps I take to reproduce:

Perhaps try again after disabling the script blocker ? (the red shield, top right)

Ah, that is interesting. It is also related to the request to remove third party tracking software and dependencies from Sovereign.

OK, it appears that uBlock Origin is blocking analytics.js:

How difficult would it be to remove the hard dependency on tracking software in Sovereign?


Development planning, Milestone 1

This is the initial major step of the entire project. It lays ground for all following steps. It consists of these points:

[x] Translate all source files from the ANTLR4 Java runtime to Typescript
[x] Clean up all generated files and make them build.
[ ] Replace the currently used antlr4ts runtime with the new one in antlr4-c3 and make the c3 library work.
[ ] Publish a new ANTLR4 runtime Node.js package.

Oh! There would be a different distributed antlr4 runtime? That's pretty awesome. Are you testing with https://github.com/antlr/antlr4/releases/tag/4.12.0 since that's primarily a TypeScript release? Having e2e TypeScript would be rad af.

This is probably a bonkers idea, but another thing to consider is AssemblyScript, would allow both a TypeScript-compatible build AND a WASM runtime.

Yes, the first step is a complete TS runtime, not just type definitions over a JS runtime (like what is currently in ANTLR4). Pretty much like antlr4ts, but for ANTLR 4.12.
AssemblyScript is something I have in my head for quite some time already, but it has some limitations yet, like no union types, only simple interface support, no promises...

@mike-lischke What about just updating the JavaScript runtime to a TypeScript one in the Antlr project itself? Or a type-checked JSDoc? It already gets transpiled / packed with Webpack. You don't think they'd be open to it?

Doing that would mean to live with its limitations. That runtime is not complete and since it is JS, there's no type checking within the runtime. I prefer a full TS runtime, not just typings.

You can type-check within a JS source with JSDoc. There are some popular packages that do so, but I guess yeah, if there are other limitations and places where its incomplete, that makes sense.
In what ways is it incomplete? Is it documented? I do know that the majority of the .d.ts files are incorrect, and so TypeScript will complain if you try to import one of the .js files directly.

For the differences just compare the two runtime folders of Java and JavaScript. I haven't yet pushed the new TS runtime, as I'm in the middle of porting antlr4-c3, but it will look exactly like the Java runtime, just with Typescript files.
The JS runtime contains only the minimal required number of files, to allow parsing input. And the type definitions are an even smaller layer on top of that. Parsing something is possible, but that's it. Tools which need more of the support classes (like the vocabulary) cannot use it.
About tree-shaking: I'm not sure how much the structure influences bundling here, but the runtime is not very big. Though for me the bundle sizes are not of very high interest. Todays machines and connections are fast enough to transport megabytes easily. Functionality weighs more IMO. In another project I work on I have bundles with such sizes:

build/assets/rdbms-info-4348324e.js                               13.24 kB │ gzip:     2.86 kB
build/assets/keywords-1d566755.js                                 23.47 kB │ gzip:     3.85 kB
build/assets/builtin-functions-6a8e8352.js                        33.98 kB │ gzip:     8.80 kB
build/assets/system-functions-f32d6e43.js                         75.58 kB │ gzip:    16.37 kB
build/assets/tabulator-tables-906d6f2f.js                        387.27 kB │ gzip:    89.51 kB
build/assets/system-variables-a8dea4ec.js                        822.19 kB │ gzip:    94.68 kB
build/assets/index-6d8dd2b8.js                                   893.82 kB │ gzip:   223.70 kB
build/assets/monaco-editor-84b8038e.js                         3,357.21 kB │ gzip:   836.85 kB
build/assets/dependencies-45be8b40.js                          4,199.15 kB │ gzip: 1,108.13 kB

but I have yet to see how much the new TS runtime and the JREE end up when bundling. They will go into that mentioned app to replace antlr4ts there (which is located in that dependencies bundle).

@mike-lischke

it will look exactly like the Java runtime, just with Typescript files

That is really great news! Let me know if there are ways others can contribute. I'm currently working on a more robust and complete CSS parser using Antlr, and pre-processor grammars that properly extend it, and after I built the grammar and was trying to build tests, I immediately was running into problems with incomplete / missing types in the JavaScript runtime. I proposed this solution to fix the mess of types, but I think yours is a much better one, so I closed it.

The current focus is not so much on the TS ANTLR4 tool, but on the new TS runtime. I'm currently converting some of the JDK tests to verify that the JRE emulation works well. While debugging the antlr4-c3 package I found a few problems, which I have to fix first. After that I can continue to make parsing work (the lexer already works).
There are so many areas in this group of projects which need improvement. Just pick something you like and file PRs. Filing bugs is probably not a good idea, as this is too early in the process. These are the current main topics:

JREE testing and bug fixing.
New runtime testing and bug fixing.
antlr4-c3 conversion to the new runtime.

Note: I have not yet uploaded the new runtime, as there's no node package yet, but I can create the repo in Github if you want to spend some time porting your CSS parser to it and debug the issues. The new TS runtime builds fine already and is complete, but needs some fine tuning. Or maybe rather the JREE that provides the runtime for the runtime ... :-)

I can create the repo in Github if you want to spend some time porting your CSS parser to it and debug the issues

If the TS runtime is feature-complete (albeit with possible bugs), I'm happy to try it out and do that. I'd only just started with the JS/TS-API side of my parser(s) i.e. I hadn't gotten very far with the JS/TS runtime in the Antlr repo (mostly because I immediately ran into roadblocks like the DefaultErrorStrategy neither being exported at the root nor having correct TS types when I tried to import it from source).

OK, I just pushed the latest code, but don't expect this to fully build. I really need to update the jree Node package for that, which in turn requires that I finish the JDK tests I have converted.

Hmm, what do you mean, JRE emulation? The TS runtime runs a Java emulator? 🤔

For this project I decided to follow a different idea. Instead of porting the code and implementing the necessary Java infrastructure (lists, file system etc.) in a way that is only usable in the TS runtime, I provide a JRE emulation layer, which implements the Java APIs as TS classes. This provides a generally usable TypeScript "J"RE, not just one that can be used in the ANTLR4 runtime.
In parallel I'm working on a Java to TypeScript converter, which I used to machine-translate the ANTLR4 Java runtime to TS. When translating between languages, the biggest problem is the runtime used by the source language, which is not available for the target language. For converted Java code I created the JREE. And because this is a clean-room implementation (read there what that means), I heavily rely on JDK tests (I also converted using java2ts).
Of course it is out of scope to convert the entire JRE. Instead I only convert what I need for the ANTRL4 TS runtime (+ plus a few things needed by the tests). This approach has matured for a while and I'm now in the process to integrate the JREE and the new TS runtime in a real project (antlr4-c3. While doing that I found a number of problems, which I handled by adding the associated JDK tests to the JREE tests and fixing the issues found by them.
Yes, this means to juggle with 4 projects at the same time, but the java2ts project is meanwhile in a good shape, so that I don't need much extra work for it. And the other ones clearly depend hierarchically on each other: finish the ported JDK tests (and fix issues found by that) -> use the new TS runtime and fix issues found in it -> fix the library in which the runtime is used (here antlr4c3). You could instead use your CSS parser.

@mike-lischke I did try the TS runtime and yeah, it doesn't build yet.
Meanwhile, though, the "official" TS runtime doesn't work either. 😞

To be honest, I haven't pushed the latest code yet, as I'm using it in an isolated fashion for another project. I'm in the middle of porting my antlr4-c3 to the new ANTLR runtime and have made quite some progress. Only the very large C++ grammar fails currently to parse (has a stack overflow). So I think I'm pretty close to having a full ANTLR4 TypeScript runtime.
Tbh. I'm not sure if I should publish the new TS runtime as part of the ANTLR4 tool or separately. Currently I'm leaning towards an own node package, as that is how the TS runtime will be consumed anyway.

@mike-lischke Fair enough! I'll be eager to try it when it's published!

Hi,
@mike-lischke ; Is there any rough estimates when you will publish a package (beta for that matter)? I am in a situation where I would like to use the antrl4-cs package, but I can't use the current antlr4ts package because it depends on a outdated antlr4 version.
Your project seems like a perfect fit.

hi @trmjoa, estimates are always difficult to give. It would be easier if there were more people working in the project. However, I'm pretty sure there will be nothing usable in June (and probably July) yet.

@trmjoa In case you didn't see it: the new ANTLR4 TS runtime is now available as antlr4ng on NPM.
With that in place this milestone is finished.