Retrying insert bundle into with a threshold

Signed-off-by: myan<EMAIL_ADDRESS>Add a new bundle status implementation that supports retry handling.

/retest

When the bundle process failed, we need to wait some seconds(30s) then process it next time.

When the bundle process failed, we need to wait some seconds(30s) then process it next time.

The current process queue is not suitable for the deploy case, if it is a very important scenario. we should re-design its mechanism. Cause it needs to change a lot.

/lgtm


Bug 2127098: A check for ODF operator version to its corresponding ODF-MCO operator version

Signed-off-by: Gowtham Shanmugasundaram<EMAIL_ADDRESS>

/approve
/lgtm

/retest ci/prow/odf-console-e2e-aws

/test odf-console-e2e-aws

/test odf-console-e2e-aws


Does this project follow semantic versioning?

Can i use this project with ~= operator?
elasticsearch-async~=6.2.0

Does it follow Semantic versioning?

This project follows the Elasticsearch major and minor which do follow semantic versioning. Breaking changes will only be introduced on new majors. You should probably use ~=6 if your Elasticsearch cluster is v6
Does that answer your question?

Yes, thank you.


Better README

We need to update the README to be instructions on how to make calls with an API client, and move the build instructions to a different doc or wiki.

Addressed in #30


@ts-nocheck and @ts-ignore should also disable suggestions

Suggestion

🔍 Search Terms

@ts-ignore tsserver disable
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

The // @ts-nocheck and // @ts-ignore directive should, also, disable tsserver providing suggestions
📃 Motivating Example

When writing code ,it's nice that we get real time compile & linting errors & warnings (i.e. suggestion). TSSERVER, the language server for typescript, dose the heavy-lifting for your favorite IDE and fills your screen with all those wiggly lines you hate (& love).
Sometime, though, the language server can get it wrong.  You depend on a library unknown to the server. Or that you are writing buggy code intentionally. To our rescue, we can use directives to tell typescript (and its language server) that "it's ok, I know, roll with it". Directives such as
// @ts-nocheck: ignore this file
// @ts-ignore: ignore next line

are very handy.
Unfortunately, these directives didn't work with suggestions. Things like
'foo' is declared but its value is never read. [6133]
File is a CommonJS module; it may be converted to an ES module. [80001]

Still populated your IDE, and you jump through them like hoops trying to reach the error you want to fix. They are not ignored by placing the directives.
Released with typescript X.X, these directives can now be used to switch off suggestions as well.
💻 Use Cases

This is a capture from Emacs' lsp-mode. For conventional reasons, we still want to continue using the commonjs style require and module.exports in js projects.

Not to render the original suggestion moot, but this seems like a bug in the editor. VS Code, for example, will not navigate to a Suggestion diagnostic when you invoke the "Go to next error" command.

this seems like a bug in the editor. VS Code, for example, will not navigate to a Suggestion diagnostic when you invoke the "Go to next error" command.

Yes, in Emacs (Flycheck) we can set a minimum error level too. But that is opting out of all suggestions. Some suggestions are useful and (by choice) treated as errors - goto & fix.
We should be able to selectively switch off suggestions, like we can do with errors.
Even better, a way to switch of specific suggestions for the entire project (i.e. via tsconfig) either by code or by class. But with directives is a good start.


chore: add some unit tests that are touched by incoming CINE dispatch actions

@allcontributors please add @dannyrb for code


Filter for datetime (or year) won't accept numpy arrays

Filter will not accept numpy arrays of timelike values. This seems odd, given that if one extracts the unique elements of the date or year, it is in this format. Here's a minimal case replication:

import pyam
import pandas as pd
import datetime as dt
_msa = ["model_a", "scen_a"]
db_dt = pd.DataFrame(
[
_msa + ["World", "Emissions|HFC|C5F12", "kt C5F12/yr", 2, 3],
_msa + ["World", "Emissions|HFC|C2F6", "kt C2F6/yr", 0.5, 1.5],
],
columns=[
"model", "scenario", "region", "variable", "unit", dt.datetime(year=2010, day=1, month=1),
dt.datetime(year=2015, day=1, month=1)],
)
db_dt = pyam.IamDataFrame(db_dt)
db_dt.filter(time=db_dt["time"].unique()[0])

This seems to fail similarly with years (won't accept int64 arrays either), although the error message is more cryptic. It works normally if  I convert the numpy array to a standard array. Is this desired behaviour?

This is definitely not desired behaviour...
The type you are passing is numpy.datetime64, which triggers this consistency check here.

Solved by #370 370


Fix msd, varteleport examples

Closes https://github.com/Qiskit/openqasm/issues/174, https://github.com/Qiskit/openqasm/issues/173 by updating these examples.

@hhorii this addressed two of your issues...


SUGGESTION for JS change.

Hei,
First: nice template. Create job :)
I do have one suggestion due to fact how Silverstripe CMS handles certain things. In js/creative(.min).js file
Row 8:
scrollTop: ($($anchor.attr('href')).offset().top - 50)
I would replace with
scrollTop: ($($anchor.attr('href').substring($anchor.attr('href').indexOf("#"))).offset().top - 50)
Or to make it more simple, Row 6 I would change from
var $anchor = $(this);
to
var $anchor = $(this).attr('href');
and then  row 8 would be:
scrollTop: ($($anchor.substring($anchor.indexOf("#"))).offset().top - 50)
The reason is to make sure the anchor+name (for example #about) is forced to use. In Silverstripe all hrefs automatically get / in front of ANY URL. Meanwhile, it will work on any system anyways, due to the fact that return is always #+name (#about).
Of course - second option is to change template and js to use some other custom attribute, like data-value or any other similar.

This is a pretty specialized change for a single case use scenario. This is a good addition or fix for people using Silverstripe and other similar CMS solutions, but I am going to keep it as is for now.


Re-organize System/Device class interface for plugins and applications

Header system.h gets installed along with dronecore.h and plugin header files.
DroneCore apps do:
System &system = dc.system();
...
// have access to entire System interface

This implies, we're letting applications access to System interface as well. In other words, applications can even compose MAVLink messages and send it across!
I think thats not right. We may decide to export minimal interface like, has_camera(1), has_gimbal(), etc;
As I understand, we insist DroneCore apps to use plugins rather than System interface. Please correct me.
On the other hand, System interface is needed for plugins. So, one possible way is to expose:
class MAVLinkSystem {
// Current Device contents which are required by plugins goes here.
};

to plugins.
Note: I chose name MAVLinkSystem here because its internal to DroneCore and not exposed to public. I am fine with any suitable name that makes sense.
For DroneCore applications, lets provide
class System {
// Minimal interface needed for DroneCore apps
};

Kindly share your thoughts.

I tend to agree with you. I don't mind that app authors can use it, I mind that if they do so an this is a "public interface" we're gong to effectively be making compatibility promises about that interface going forward.

@julianoes @JonasVautherin @hamishwillee
I've got these changes (on top of #310) right now (Tested). I shall submit.

Current design: (Details omitted)

Proposed design: (Details omitted)


Add CI testing for i386

message_test currently fails on i386, which exposed a gap in the CI
testing.  Convert the shadowdir job to one that runs on i386 so we get
32-bit test coverage.
Since the GHA runners are x86_64, we can enable the i386 architecture
in dpkg and install i386 packages for the i386 CI jobs.  However, this
can't currently be done with features=huge since that would require
installing python3-dev:i386, which breaks the CI environment.

Merging this would temporarily break the shadowdir job, but the shadowdir infrastructure is less affected by day-to-day changes, so maybe it's worth merging this to help debug the message_test failure.

so do we still need this one? And if yes, since this is in conflict with the shadowdir job, can we make those two work together?

so do we still need this one?

I would say yes, so we catch problems like this in the future before the changes get merged.

since this is in conflict with the shadowdir job, can we make those two work together?

It's not in conflict with it.  I just figured that we could make the shadowdir job run with i386 to avoid adding a new item to the matrix.  The shadow functionality is orthogonal to the architecture, so we can get two tests in one.

okay thanks!


pre-alpha: SDK build and readme

Description

fix node sdk build to 2017, avoid unused dependencies such as tslib
split the readme to docs
updated core-js to minor
export cookie names

@jeff-descope please take a look at the language additions around oauth if you can

@nirgur Can you review ? we need to deliver this tomorrow to a customer


Feat#86 credentials

Add various credentials loading methods in the Auth class, all centralized in the Auth.from_credentials method, which is then called by the earthdaily.earthdatastore.EarthDataStore function. The idea is to stop users from importing the Auth class directly and propose a consistent and simple way of loading credentials.
A few notable points:

No breaking change, but a deprecation warning for people that use the Auth constructor to load credentials from a JSON file
The new authentification methods are tested in tests/test_auth.py
Examples now use the new EarthDataStore function
Unit tests now use the new EarthDataStore function
Remove the Venus example, after a discussion with @nkarasiak
More information in the README for credentials handling

What a great commit ! I merge it on dev.
We need to talk a bit about the  copy-credentials-template before merging to main.


Add battery readings to MQTT stream

I set up this add-on because I want the live data from Enphase in Home Assistant. For the production/meter readings this is working just fine, but I don't see an option for battery storage. From the code it seems as if the data from /ivp/livedata/status is used, but in the MQTT packets no readings for storage are available. Also the structure of the JSON payload in the MQTT packets is not the same as the data on /ivp/livedata/status.
Since the official Enphase integration in Home Assistant offers no live readings for batteries I was hoping maybe this add-on could solve that. I'd be happy to help develop/test it.
/ivp/livedata/status has the following properties:
"meters": {
"pv":{}
"storage":{},
"grid":{},
"load":{},
"generator":{}
}
All with the following data:
"agg_p_mw": 339626,
"agg_s_mva": 534524,
"agg_p_ph_a_mw": 83880,
"agg_p_ph_b_mw": 128396,
"agg_p_ph_c_mw": 127350,
"agg_s_ph_a_mva": 117432,
"agg_s_ph_b_mva": 223298,
"agg_s_ph_c_mva": 193793

I'm not able to help sorry - I have V5 firmware with no batteries - all I can suggest is to use mqtt explorer https://mqtt-explorer.com/ and point it to your homeassistant broker. You can then see the json as created by this addon and from that, create a template to extract the required data using the examples I provided as a guide. This is what I see on version 5

I have changed the code slightly and used the scrape_stream_livedata() function for firmware version 8 now. It had a bug where the is_json_valid() function would fail because the data stream was encoded as a byte string. By updating the is_json_valid() function I solved this issue and it works.
Because the JSON result is different I added that bit to the README.md.
My code editor was complaining about the Callback API version 1 being deprecated (in the paho-mqtt). I ignored this for now, but this should probably be looked into. They now use function decorators but I couldn't get this fixed in the short time I tried.
Hope this helps!

Thanks for the work on this - I've merged it into the main. I might need to look into the deprecated Callback, although I've super busy with my day job so may not have a chance for a long time - if you have any luck I'd welcome any suggestions.
Cheers
Ian


Add hamiltonian path and hamiltonian cycle finders

Ham cycle is done
Ham path is awaiting.
I will add it someday too i guess


Autofix errors reported from the linter

Task linked: QF-4428 Switch to ruff instead of black, isort, flake8 and autoflake


help with the 4bind.asi error

so basically it happens this when i open the game, i really don't know what's causing this, and apparently my friend got this error too, so yeah

have you tried using the dxgi.dll file?

have you tried using the dxgi.dll file?

yeah, it works. but i want the keybind to be on 4 to change the legend
but when i put only that file which is the Y0LSF_4BIND, it gives me that error

ah, so you wanted to change the keybinding?  I'll update the mod once I get home in a few hours so you can use a custom keybinding

yep, that's what i want, if possible

hey, can you help me to test this? I don't have the game installed at the moment, downloading it would take too much time.

Extract Y0LSF with custom keybind.zip then put both file inside your game directory
Check and report back to me

also, don't forget to delete your old .asi file

it worked without any issues, thank you so much my man <3

glad it worked! also, thank you for testing it for me, I'll push the update now 😃


Port amiitool to an includable function?

Hi,
I'm trying to write code that incorporates Amiitool. It would be amazing if it's functionality could be ported to a function, so I could just #include "lib/amiitool/amiitool.h and then do something like
decrypted_dump = amiitool( DECRYPT, key_variable, dump);
modified_dump = dosomestuff(decrypted_dump);
encrypted_dump = amiitool( ENCRYPT, key_variable, modified_dump);

I'm trying to do it myself, but unfortunately I'm very new to C, so any help would be appreciated immensely. To tell you the truth, I'm not even sure my example there doesn't have some glaring error. But I think it should be pretty self explanatory.
Thanks!

(Let's pretend decrypted_dump, modified_dump, encrypted_dump, and key_variable are all arrays of the appropriate size)

There already are - there is nfc3d_amiibo_unpack for decryption and nfc3d_amiibo_pack.
I wanted to make this into a static or dynamic library, but I never got around it.

Okay, so let's get started. Poking also @ToolsDevelopper which may be interested in this. @HiddenRamblings is possibly relevant to this since he's the only so far which has used this library in a finished product.
Before I start converting this into a library, I need to know exactly what functions should be exposed, ie what this library should do automatically and what should be left to the developer.
For now, I was thinking in exposing the following functionality:

nfc3d_amiibo_create(const nfc3d_master_keys *): creates a new amiibo instance
amiibo_from_tag(ctx *, uint8_t *): decrypts the given data into the context, in internal format
amiibo_to_tag(ctx *, uint8_t *): encrypts this amiibo into the given buffer
amiibo_sign(ctx *): shortcut for amiibo_sign_tag followed by amiibo_sign_data
amiibo_sign_data(ctx *): signs the data so it's picked up as data being valid by the 3DS
amiibo_sign_tag(ctx *): signs the UID so it's picked up as original amiibo by the 3DS
amiibo_check(ctx *): shortcut for amiibo_check_data and amiibo_check_tag
amiibo_check_data(ctx *): checks the data signature
amiibo_check_tag(ctx *): checks the tag signature
amiibo_get_uid(ctx *): returns a pointer to the UID
amiibo_get_data(ctx *): returns a pointer to the data

I'm not sure if amiibo_sign_* should be exposed, or be done automatically as part of the amiibo_to_tag call. I'm not sure either if data would be more useful in the format the 3DS uses (so-called "internal format" in amiitool) or as it's stored in the tag ("tag format"

@socram8888 its been 4 years so i doubt it, but any updates on this? i was looking into using rust's bindgen to use amiitool in rust, but didnt have any luck since it requires a built library iirc

@jozz024 I've not looked any further. Packing up libraries in C is something I'm pretty terrified of and have stayed as far as possible from it.
The encryption is pretty basic, so if you're using Rust maybe it could be easier to just port it entirely and benefit from Rust's dependency manager.

that was my next thought, have just been debating how to do it.

I've never developed for Rust so I'm sorry but can't help you with the implementation.
However, if you need any aid in understanding the algorithm, or maybe the design of the API, let me know.

sure, i appreciate it

hey @socram8888 if its not too much trouble, can you explain what you use mbedtls for? i've found a rust port of that, but i'm still a tad confused as to what it's used for

@jozz024 mbedTLS is used for:

Calculating a HMAC-SHA256 as part of the DRBG
Checking and generating the fixed part HMAC-SHA256
Checking and generating the user content's HMAC-SHA256
Decrypting and encrypting the user contents using AES

There's no reason why to use mbedTLS. I used that because it was pretty small and I did not have to deal with the hassle of compiling against a dynamic library such as OpenSSL.

wow it's been 6 months alr
i finally have a semi working rust amiibo library (https://github.com/jozz024/amiibo-rs) but atm i'm facing issues with lock 💀
i think i'm doing something with the hmac calculation wrong, but i just thought i'd update since i came to check the repo if i did anything wrong


Support Windows 7

This crate defines the needed Rust version as 1.77 while it not being necessary. Why not downgrade to 1.75 and have Windows 7 supported as a plus? :)
I am suggesting this because I was trying to build SurrealDB for Windows 7 and I couldn't because of reblessive. I forked both crates and modified them to get my build and it worked without any issues.

https://github.com/DelSkayn/reblessive/pull/2

It seems strange to me that this crate works on an earlier version as it depends on the support for async recursion introduced in rust 1.77, furthermore the lowest rust version supported by surrealdb is 1.80 so that also shouldn't build.

It built and worked perfectly 🤔

I can share the code and executable with you, maybe I missed something


Repository description is wrong (Not kustomize build but kubectl diff)

I'm sorry if I'm misunderstanding, but I suspect the repository description A CLI command to parse kustomize build result and notify it to GitLab is wrong.
I guess the correct description is A CLI command to parse kubectl diff result and notify it to GitLab.

@suzuki-shunsuke Oh!  I'll fix this shortly.

Fixed. Thanks for your suggestion!


Pooling + delete require.cache = connection leak

Environment
Knex version: 0.20.13
Database + version: PostgreSQL 12.2
OS: alpine
"Bug"
1. Explain what kind of behaviour you are getting and how you think it should do
Hi there, I am using knex with Next.js and noticed that my used connections from pg_stat_activity was always going up to a point where I would get an error message about them being exhausted.
It turns out this is caused by the way Next.js does server side hot module reloading: using delete require.cache means (cc @timneutkens do you confirm?). When the require cache is deleted and the module is re-required then the connection just leaks and will never be collected/terminated.
The interesting bit is that node-postgres pooling is not impacted by this issue and works fine.

Error message

error: sorry, too many clients already
    at Connection.parseE (/Users/vvo/Dev/knex-pool-require-cache-issue/node_modules/pg/lib/connection.js:600:48)
    at Connection.parseMessage (/Users/vvo/Dev/knex-pool-require-cache-issue/node_modules/pg/lib/connection.js:399:19)
    at Socket.<anonymous> (/Users/vvo/Dev/knex-pool-require-cache-issue/node_modules/pg/lib/connection.js:115:22)
    at Socket.emit (events.js:310:20)
    at addChunk (_stream_readable.js:286:12)
    at readableAddChunk (_stream_readable.js:268:9)
    at Socket.Readable.push (_stream_readable.js:209:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:186:23) {
  name: 'error',
  length: 85,
  severity: 'FATAL',
  code: '53300',
  detail: undefined,
  hint: undefined,
  position: undefined,
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'proc.c',
  line: '361',
  routine: 'InitProcess'
}

Reduced test code

I have created an example here: https://github.com/vvo/knex-pool-require-cache-issue.
The interesting part being:
test-knex.js
const http = require("http");
const path = require("path");

const server = http.createServer(async (req, res) => {
  const db = require("./lib/db-knex");
  try {
    await db.query("SELECT 1;");
  } catch (e) {
    console.error(e);
    res.writeHead(500, { "Content-Type": "text/plain" });
    res.end("not ok, check the terminal of your Node.js server\n");
    return;
  }

  res.writeHead(200, { "Content-Type": "text/plain" });
  res.end("okay\n");
  delete require.cache[path.join(__dirname, "lib/db-knex.js")];
});

server.listen(3000);

lib/db-knex.js
const knex = require("knex");

const pg = knex({
  client: "pg",
  connection: process.env.DATABASE_URL,
});

module.exports = {
  query(sql) {
    return pg.raw(sql);
  },
};

Let me know what you think. It took me some time to pinpoint this but not sure we can do something about it. 🙏

Maybe you can override Next.js's NextJsRequireCacheHotReloader https://github.com/zeit/next.js/blob/31b3106a32779527ff937582149c6af72eea69dc/packages/next/build/webpack/plugins/nextjs-require-cache-hot-reloader.ts#L15
to allow writing some teardown method for deleted modules.
Anyways AFAIK there is nothing that knex can do to avoid that. If you can figure out why pg-pool doesn't leak connections in this case it could be helpful though.

@elhigu I am not expert in pooling systems, but the code from pg pool is a single JavaScript file of 400 lines. I had a look and I would say the major difference and the one I would investigate is that somehow their pool is not relying on any timer/setInterval, thus when the module cache is cleared there's no leak left behind.
They release connections immediately it seems to the pool here: https://github.com/brianc/node-postgres/blob/2ef55503738eb2cbb6326744381a92c0bc0439ab/packages/pg-pool/index.js#L353-L362
I can live with it, this is only happening in dev, at least people with the same issue will now google it and might found this issue! Thanks for your hard work again 🙏

Just in case, maybe @brianc has any idea as for this issue (sorry for bringing you here, if you reach this, read the original issue and let us know what you think!)

@vvo mongoose also seems to close after a timeout.
👇
https://github.com/Automattic/mongoose/blob/master/lib/drivers/node-mongodb-native/connection.js#L169-L178
May be we should discuss this at nextjs repo? 😅

@harisvsulaiman You can comment on the linked issue yep!

For anyone reaching this issue and having connection leaks in dev mode of Next.js or any other situation where your db.js file is reloaded and connections are lost using Knex, you can solve it this way:
const knex = require("knex");
let pg;

if (process.env.NODE_ENV === "development") {
  global.pg =
    global.pg ||
    knex({
      client: "pg",
      connection: process.env.DATABASE_URL,
    });

  pg = global.pg;
} else {
  pg = knex({
    client: "pg",
    connection: process.env.DATABASE_URL,
  });
}

Had the same issue for the past 10 months while working on a large project with Next.js + Objection.js/Knex + PostgreSQL. Finally managed to solve it by implementing a similar hack:
/**
 * @returns {import('knex')}
 */
const getConnection = () => {
  if (PRODUCTION) return knex(DB);
  /**
   * This `global` hack solves a long-standing issue appearing in development more,
   * when successive hot-reloads lead to connections being leaked and eventually produce
   * an unrecoverable error
   */
  /* eslint-disable no-underscore-dangle */
  if (!global.__KNEX_DB_CONNECTION__) global.__KNEX_DB_CONNECTION__ = knex(DB);
  return global.__KNEX_DB_CONNECTION__;
  /* eslint-enable */
};

const db = getConnection();

export default db;


suggested improvements to README.md

Let's start the README.md with a short paragraph about what the scripts in this repo do.  The ingest video files and generate annotations needed for the TV news viewer (should probably link to that repo)

Odd that the README says all videos must show a particular naming convention, and then the video file in the subsequence example does not have a filename matching that convention.

The "tree" of output is a nice figure, but I think we should briefly summarize the content of each generated file.  (i.e., this is all the face detections)

Are the embeddings really stored in plaintest json?  Ouch!  That's going to be really large in file size.

Updates to the README have been made that address these concerns.


Smarter formatting of comment lines

One thing I've noticed is that auto-formatting the document always results in comments being pushed to the "comments" column as specified, but typically, this is only desirable for an inline comment, i.e. one that follows an operand. Oftentimes, there is a line containing only a comment that is desirable to keep either left-aligned, or aligned with the mnemonic below it.
A few suggestions on possibly good ways of handling this:

Do not format lines that contain only a comment, or only whitespace and a comment
Add a separate align setting for lines that contain only comments
Add a format setting to always align comment-only lines with the mnemonic column, or even the column of choice (mnemonic/operands/operator/value). This would solve the problem of comments losing their alignment if an extra-long symbol name pushes the mnemonic column back a tab.
Have different behaviors or settings for comments prepended with either ; or *, giving the user control over formatting based on comment character used (maybe not ideal if not all assemblers interpret both these characters as comments)

What do you think about these?

Yeah I have thought about this. As you've seen, the current behaviour is to ignore lines where the comment is on the first character, otherwise align to comment position.
One additional option I'd considered was to snap to the nearest element position (i.e. label, mnemonic, operands or comment), based on the comment's current position. I might give this a try.
I agree all of this should be configurable. Options could be:

ignore (don't align)
nearest element
label
mnemonic
operands
comment

Thanks for your continued improvements! Let me know if there's any way I can be more accommodating with the way I share issues or suggestions in the future.

No problem. Keep the feedback/suggestions coming!


No dist folder or minified files when installed with Bower

Correct. This only is supported in bower afaik (but pull requests for fixes are welcome). Download the latest zip from the releases instead, e.g. https://github.com/collab-project/videojs-record/releases/download/1.6.2/videojs-record-1.6.2.zip


OOM even when reducing batch size!

Hello and congrats on the excellent work!
I am trying to train the model with 2 gpus:
CUDA_VISIBLE_DEVICES=0,1 bash ./scripts/dist_train.sh 2 13232
--config ./cfgs/PCN_models/PoinTr.yaml
--exp_name example
I am using two Nvidia 1080Tis, it would give me the error of running out of memory. I tried reducing the batchsize from 48 to 24 and even 12, but still the problem remains. do you have any solutions in mind?
thnx

Sorry, i have no idea what's the problem now. Did you use the default config file provided by this repo? Are other networks work well in your server?

No there are no other networks and yes at first I used the default configs and then I just change d the batch size and reduced it

That's weird. Could you successfully train a PCN (change --config ./cfgs/PCN_models/PoinTr.yaml to --config ./cfgs/PCN_models/PCN.yaml？

Close it since no response. Feel free to re-open it if problems still exist


fix: do not log about re-referencing when no such thing is done

This came up on gitter: https://gitter.im/mne-tools/mne-python?at=5f92ad30c990bb1c39277c8d
When users add a previously unknown reference channel using add_reference_channels, the channel is initialized as a vector of zeroes. No actual re-referencing takes place, however the log messages confusingly print:

EEG channel type selected for re-referencing Applying a custom EEG reference

This PR suppresses that confusing log message.

Travis is really the odd one out in terms of speed :)

Travis seems to be totally broken today. We'll move on without it, we can trust the coverage of Azure. Thanks @sappelhoff


'install' generates binary file with wrong permission

$ xmake create test_install
create test_install ...
create ok!
$ cd test_install
$ xmake --version
XMake v<IP_ADDRESS>703272012, The Make-like Build Utility based on Lua
Copyright (C) 2015-2016 Ruki Wang, tboox.org, xmake.io
Copyright (C) 2005-2015 Mike Pall, luajit.org
$ xmake
# some build output
build ok!
$ xmake i
[100%]: linking.release test_install
error: installation failed, may permission denied!
note: try continue to install with administrator permission again?
please input: y (y/n)
y
install ok!
$ ls -l build
total 8
-rwxr-xr-x 1 ts ts 5580 Mar 27 20:25 test_install
$ ls -l /usr/local/bin/test_install
-rw-r--r-- 1 root root 5580 Mar 27 20:25 /usr/local/bin/test_install
$ test_install
bash: /usr/local/bin/test_install: Permission denied

Couldn't even run it after installing

Ok, I will fix tbox's tb_file_copy  api to solve this problem.

I have fixed it, please update xmake from master.
Thanks!

:smile:

Please update xmake to master a51c06d23ad40e8a1c626ca0d56e65387fcca551.
I fixed a new serious path bug, otherwise creating some directories may fail when building program.
Thanks!

I'm having a look at it:smiley:

Seems great:+1:


⚠ Young Discoverers has degraded performance

In 4bfa342, Young Discoverers (https://youngdiscoverers.org.au) experienced degraded performance:

HTTP code: 200
Response time: 5675 ms

Resolved: Young Discoverers performance has improved in 1deadaa.


Add missing rxjs filter operator dependency

Codecov Report

Merging #1836 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #1836   +/-   ##
============================================
  Coverage        85.95%   85.95%
============================================
  Files               78       78
  Lines             2101     2101
  Branches           273      273
============================================
  Hits              1806     1806
  Misses             202      202
  Partials            93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d287d64...b37a51d. Read the comment docs.

Awesome! Thank you!


Would like the ability to copy error messages

What happened?
Analysis errors from DartPad can be selected, but once the mouse button is released, the selected text becomes deselected, preventing people from easily copying and pasting the error message.  This hinders searching for specific error messages on StackOverflow, and it encourages some StackOverflow users to use non-searchable screenshots of error messages.
Steps to reproduce problem

Enter some code that triggers an analysis complaint.  For example:void main() {
  String s = 4;
}

Observe that DartPad shows an analysis error in a pop-up in the bottom-right corner.
Select the text from the error message.

Result: The selection is lost once the mouse button is released.
Browser

Firefox 88.0.1 (64-bit) on Linux
Chrome 91.0.4472.77 (Official Build) (64-bit) on Linux

Hello dartpad team. I would like to contribute to this issue. I am thinking of adding a clipboard button to the analysis widget. I believe the main file to be changed is analysis_results_controller.dart.
Please let me know if I am on the right track and can contribute this.

This seems like a good feature to add, though I'll defer to @johnpryan, since he takes the lead on DartPad's front-end.
@rahulv4667, one way to start would just be mocking up the change to the UI. Try adding the HTML/CSS (without worrying about actually wiring it up to events and Dart code), and then paste a screenshot into this issue so we can talk it over.

Try adding the HTML/CSS (without worrying about actually wiring it up to events and Dart code), and then paste a screenshot into this issue so we can talk it over.

Sure. Will do.

@RedBrogdon @johnpryan Please have a look at following screenshots and let me know what you think.

Interesting! I had imagined a single copy button that would get all the error messages.
With this approach, though, I'd probably recommend moving the copy icon out of the tag and either placing it before the tag or adding it as almost an extra character at the end of the message.
@rahulv4667, @johnpryan: WDYT?

Suggestion1:

Suggestion2:

Personally, I find the previous one(suggestion zero) better. In suggestions 1 and 2, the icon color and text color are same. So, it might be a bit hard to differentiate between icon and text in some cases for beginners. We could avoid that by coloring the icon gray or blue(docs link color).  But then again, I still feel it appears cluttered. Suggestion 2 has another problem of the icon's purpose not being clear with view docs link adjacent to it. The above suggestion of icon along with the label feels a lot cleaner.
Your thoughts? @RedBrogdon @johnpryan

Suggestion 1 looks good to me. We might want to add some padding so it's visually separated from the text.
Most of the time these buttons give the user some feedback after they click it - like showing a snackbar ("Copied to clipboard") There's already some code for snackbars that we use when a new snippet is created.
It might also be useful to add a copy button to the console panel for runtime errors.

Cool. Will add the padding and snackbar.
About adding copy button to console panel, should it be similar to above where each error gets its own copy button or should it have a single copy button at the top right corner?
If it is a single button, should it take into account all errors when copying or the last element?

Hello, I added the copy button and the snackbar. You can view the demo here. You can check the code change here. I have tried three approaches.

Creating a clipboard event and dispatching it.
Adding text to window's Selection.
Using window's navigator.

Third approach was the simplest and the only one working. Please let me know what you think of the change and also about how to add the copy button for console panel(what information should it copy and all, as asked above).
I had a couple of questions while working on this:

Does the project, or dart web in general, have hot reload capability? I had to stop the server and restart it after every change. As a result, it took at least a minute for to see my changes.
Was there any change in build in recent commits? Initially, I made changes on the commit that was there 10 days ago. It worked fine without requiring anything else except dart sdk. But today, when I fetched the new changes and merged, generate-protos stopped working. I had to install protobuf-compiler and run. So, if there are any changes in how to build the project, is it documented anywhere?

Also, shall we append the string 'dart' to the error message so that search engine shows results related to dart instead of other languages?

The clipboard API seems like it has broad support for the use case we're talking about here (copying to the clipboard, rather than reading from it):
https://caniuse.com/?search=clipboard
Interestingly, we're using an older, deprecated API elsewhere:
https://github.com/dart-lang/dart-pad/blob/master/lib/embed.dart#L737
To answer your questions:

It was at one point possible to use webdev with DartPad, but I don't know for a fact whether that's still the case.
@johnpryan or @domesticmouse would be the best resources there.

At this point, I think you can go ahead and put together a pull request with your changes. You've made some great progress.

You can use webdev serve. Flutter compilation doesn't work with webdev, though.
Can you check that you're using the latest version of protoc_plugin (pub global activate protoc_plugin)?

Can you check that you're using the latest version of protoc_plugin (pub global activate protoc_plugin)?

Yes. That seems to have been the problem.
Thank you, @johnpryan @RedBrogdon .


Create Docker for macOS

Using our Docker setup on my macOS machine would be convenient. This branch introduces the necessary changes to make this possible, including adding the ros_docker repo as a submodule.

This didn't work and I gave up. I'll merge the changes under a different branch.


Fix NPE when add previously filled adapter to new FastAdapter instance

Why not calling it inside addAdapter for the newly added adapter only, instead of running it on all adapters again that are already added?

@FabianTerhorst sorry, I don't understand your idea. Can you please describe it more detailed?

@mikepenz @FabianTerhorst can someone please help me with this pr? I don't quite understand what should I do?


Pure.DI not compatible with .NET 9

.NET 9 will be released soon and it looks like Pure.DI is not compatible with it yet.
Repo:

Try to build any app (samples included) with .NET 9, the generator will fail with an error:

6>CSC: Error DIE999 : An unhandled error has occurred.,
Message: "Index was outside the bounds of the array.",
Stack Trace:
at System.Linq.PartialArrayEnumerator`1.get_Current()
at Pure.DI.Core.Variator`1.TryGetNextVariants(IEnumerable`1 variations, Predicate`1 hasVariantsPredicate, IReadOnlyCollection`1& variants)
at Pure.DI.Core.VariationalDependencyGraphBuilder.Build(MdSetup setup)
at Pure.DI.Core.CodeBuilder.Build(MdSetup setup)
at Pure.DI.Core.Generator.BuildCode(MdSetup setup)
at Pure.DI.Core.ExceptionHandler.SafeRun[T](T state, Action`1 action)"

Thank you for letting me know about this. Fixed in version 2.1.37


Temperatur Values are more like RAW Values as they need to be devided by 10

Describe the bug
Temperature values are shown without seperator. For example "exhaustAirTemp" is shown 226 for 22,6°C. So you have to always process the values after they have been saved/or replicate all items, so that they can be stored as °C.
To Reproduce
Is allways active.
Expected behavior
All Temp(erature) Values should be converted to °C so that they can be used straight away either in IOBroker or wherever.
Screenshots & Logfiles
Just look at the objects section.
Versions:

Adapter version: 0.0.6

Additional context
n/a

Thanks a lot for the adapter anyway. It is great, as now, I can also read the Ground Heat Exchange values, that was not possible with other adapters!!

I adjusted this in the GitHub version. Reinstall via GitHub. delete alle states. restart instance

Please try again the same steps

ok, great now it works. I can see the new values. Would it also make sense to apply this to the temperature values of the properties? Like coolProfileTemp etc. I think then only 2 more would be left, that are temperature, but not falling into the same namingconvetion you used in the new code ("endswith temp"): limitRMOTCooling and limitRMOTHeating. Thanks a lot in any case for the change!!!

I added limitRMOT


Added centralized logging via ELK

 Bank: Create logging aggregator for docker

 Bank: Create logging aggregator for docker

 Bank: Create logging aggregator for docker


Date not sorting

You could use Unix epoch to sort it better (I think)

You're right :) Definitely worth doing

This has been fixed in Version 2.


Allow parsing URLs and input ports

Given a URL, we naturally do an HTTP GET request for it. (No
security checks.) Input ports are naturally supported, since
parse is already set up to transform its argument into an
input port.

closes #2


[Feature Request] SPELLFLAG_ONLYSELF

There is a spell flag for SPELLFLAG_TARG_NOSELF, in addition to spells that will only be allowed to be cast on ourselves, another flag like SPELLFLAG_TARG_ONLYSELF can be added.
Note: Note: When we remove all the spell flags of the spell, the target does not appear in the spell and we can only apply it directly to ourselves, but then the spell effects do not appear.

Honestly we already have that, if you don't give any targ flag, the spell automatically cast on yourself directly,
eq;
[SPELL 44]
// NOTE: Used primarily to regain mana while fighting or cast helpful spells without incurring attack. Duration should reflect the non-offensive use of this spell
DEFNAME=s_invisibility
NAME=Invisibility
SOUND=snd_spell_invisibility
RUNES=ALX
CAST_TIME=1.8
RESOURCES=i_reag_blood_moss,i_reag_nightshade
RUNE_ITEM=i_rune_invisibility
SCROLL_ITEM=i_scroll_invisibility
FLAGS=spellflag_dir_anim|spellflag_good
EFFECT_ID=0
EFFECT=0
LAYER=layer_spell_invis
DURATION=3*60.0,5*60.0
MANAUSE=20
SKILLREQ=MAGERY 60.0
INTERRUPT=100.0,100.0
ON=@Effect
   FLAGS &= ~statf_hidden

If you cast invisibilty with that flags, you can see it cast on itself directly. You just need to remove targ flags from spells to make it only self-cast.

This may be possible for spells without effect_id, but for spells with effect_id, removing all flags will cause the spell effect to not occur at all.

Couldn't this be solved by using effect_id also if there's not a target flag?

Couldn't this be solved by using effect_id also if there's not a target flag? Edit, to be more clear: i mean, making sphere consider and use effect_id also if there's not a target flag

Honestly I haven't deeply checked this, but effect id not trigger when you don't have targ flag, but if you think flag is unnecessary, I could take a look on it more deeply in couple of hours.

Okay as I tested a bit and take a look for it, seems like SPELLFLAG_FX_TARG flag enough for effect. We don't need spellflag_targ_onlyself, I revert back the update and update the pr.


⚠ SceneTime has degraded performance

In db63591, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1610 ms

Resolved: SceneTime performance has improved in 4b99002 after 12 minutes.


Assistive technology testing

Hi all,
Thank you all for creating such an awesome map and working diligently to provide an accessible map option to the mapping community! :world_map:
Some colleagues at my organization had a few questions regarding the testing you've been able to conduct, and are wondering if you have been able to test some of the items below, including:
1. Has there been testing with text-to-speech software? :loudspeaker:
2. Does the "speech" button (that appears when a user tabs into the app) that triggers audio interfere with screen reader assistive technology? :speaking_head:

3. Do the keyboard navigation buttons (←, ↑, →, and ↓) interfere with the screen reader keyboard commands? :keyboard:

4. Are the popups keyboard accessible once a screen reader is running and the screen reader takes over the keyboard? :bell:

Thank you for your hard work on this project!! :muscle:
Best,
Kitty

Hi Kitty,
I'll do my best to answer your questions although my experience with screen-readers is limited.

I've tested the app using VoiceOver on Mac, but I haven't had the chance yet to test with JAWS or another screen-reading software.

The speech button shouldn't interfere with a screen reader in any way. It takes priority in the tab-index which a screen=reader shouldn't have problems with, then shows hidden fields to help navigate the map. These fields should provide more context and direction when using the app and shouldn't interfere with the screen-reader.

We used the arrows bc they seemed intuitive. I'm not sure if they interfere with other screen readers but they seem to work fine with VoiceOver. We will need to test to make sure that they don't overwrite functions that are assigned by screen-readers.

Yes the pop-ups are screen reader accessible. They exist as an empty element prior to being populated with content so they aren't breaking the html that the screen reader uses. Rather, the pop-up element is populated with the relevant content, then focus is moved to it.

Let me know if you have any other questions and please let us know how you like using the app and if you have any other feedback.
Thanks,
Nick

Thanks @nwisehart! :+1:
I'm checking in with my colleagues in the next few days and will report back by early next week with a follow-up (if any).
Thank you for the quick reply, and nice work on this project!! :muscle:

Apologies for the delay in a reply, @nwisehart. Thank you again for your insights and work on this effort! :muscle:
A few items in response to your reply based on some internal discussions...
1. Text-to-speech: :speaker:
In response to the text-to-speech testing, we're specifically wondering about speech recognition assistive technology (AT) testing, such as Dragon speech recognition used for individuals with low vision and mobile/dexterity impairments. Dragon's company, Nuance, has a good background on Dragon's accessibility.
Sorry about the confusion, there was a translation lost in my initial post. Has there been any testing with Dragon speech recognition software, or a similar product?
2. Speech button: :speaking_head:
The WCAG 2.0 guidelines, 1.4.2 (Audio Control) mentions:

"If any audio on a Web page plays automatically for more than 3 seconds, either a mechanism is available to pause or stop the audio, or a mechanism is available to control audio volume independently from the overall system volume level. (Level A)"

Since the audio is activated by a button, this may fit the WCAG guidelines, but once activated is the button given focus so users can deactivate it within 3 seconds?
The verbalized information would also need to be made available to all users, including screen reader users, which if they use VoiceOver works, but not sure if that translates to screen readers (e.g., JAWS and NVDA) in the same manner.
However, this functionality is really useful for users with cognitive disabilities, so really appreciate this feature!
3. Keyboard navigation and screen readers: :keyboard:
We did some testing with JAWS and found the navigation arrows interacting with the map navigation conflict when JAWS is open and activated on the users machine, as the arrows interfere with the screen reader commands. This functionality is across the Esri JS v4 API, not limited to this specific application. (We have not conducted testing with NVDA at this time).
We're not sure what solution could be implemented to avoid the issue, other than possibly adding a dialog that screen readers could read as the web mapping application loads (e.g., a sr-only class, or similar)?
4. Pop-ups: :bell:
Awesome, thank you! Since the :focus is being posted to the pop-up dialog window once its opened, we agree, it's a great enhancement in the v4 API. Nice work! :+1:
5. Miscellaneous comments: :speech_balloon:
We noticed a great deal of support for visually impaired users (which is great!), however we're also also wondering about support for all/other users, such as: auditory disabilities, motor disabilities, cognitive disabilities (e.g., memory, problem solving, attention, reading, etc.)
We're also working on providing alternatives to these audiences. There isn't as much documentation out there, but we're using the WCAG 2.0 guidelines to guide us along the way.


server-side caching?

I'm considering using next.js for an application where we want to render markdown files.
However, rendering a markdown file + syntax highlighting + all the rest for each client request is quite intensive on the server, and on the client more so as each client has to load the markdown and syntax highlighting libraries to perform the operation.
Is there a way with next.js for the server to cache a request's render result somewhere, such that a future request can just serve the rendered HTML. This would move rendering of markdown and syntax highlighting to the server, but that seems like a good idea to me.
Or is such an approach antithetical to the react + next.js way?

There is already an example of server side rendering with cache in the repo:
https://github.com/zeit/next.js/tree/master/examples/ssr-caching

@sergiodxa okay cool - so does that avoid client-side rendering completely for pages that are inside the cache?

No, what that it's going to do is that if the user access a page for the first time (or reload a page) the first time that page it's rendered in the server as usual, but after the first server render it's going to return the cache.
If the user transition to that page in the client, then it's always going to render in the client.
If you want to avoid that at all I think you can use a normal anchor tag to change pages to the only-server rendered page instead of using the Next.js Link component

Thanks @sergiodxa for answering the question.


Self-guided Tour

Cute animal pic

Link to Trello card (if applicable)
https://trello.com/c/oC0djduX/273-as-a-new-user-i-want-to-view-the-self-guided-tour-for-the-project-detail-page
Description
The commit messages say what you did; this should explain why and/or how.

[x] Description is in Trello card

Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).
Show me
Provide screenshots/animated gifs/videos if necessary.

 As a new user, I want to view the self-guided tour for the Project Detail page.

@dvdherron A new endpoint has been added to persist the user's preferences related to self-guided tours. It is available to actions as window.api_urls.current_user_guided_tour().
POST /api/user/guided-tour/ HTTP/1.1

{
  "enabled": false,
  "state": ["a", "b", "c"],
}

Whatever you send in the enabled and state fields will be saved to the user instance and made available as self_guided_tour_enabled and self_guided_tour_state in the User model.

Not sure if I need to do this as the PR author, but I will mark as "ready for review" so others can review and merge when ready 😊

@dvdherron This is looking good! I think since some of the tooltip body's contain bold text, we could modify the TourPopover component to accept body as a string | JSX.Element, so that we can pass in markup.
I agree with Sondra's comment from the mtg last Thursday about the value of showing which steps have been viewed... but that can be added in a new PR. So let's focus on styles (is that you or @stacyk?) and test coverage here.

@jgerigmeyer Sounds good. We can convert the popover to show which ones have been viewed in a separate story.
Made changes based on your comments here. I'd like to give testing a shot. I'll tag you about a pairing time for tomorrow.
I can continue with styles if @stacyk doesn't get to the rest first. I think it's just a matter of getting all of the popover triggers where we want them to be and fine-tuning some of the text inside of the actual popovers.

@dvdherron For what it's worth, I can't see the "overflow in the header when viewing the Metecho-Test project" that you referred to. Can you post a screenshot?
I'm assuming the positioning of the tooltip icons is still not finished, right? The mockup has them in the "top-right" of the relevant piece of info -- is that something we're planning to do?

Positioned most of the popovers to be offset to the top-right. still working on fixing the ones next to the metecho link and the project name/github link.
This is what the alert overflow looks like for me in FF/Windows:

In Chrome:

It looks different for you? Weird.

It looks different for you? Weird.

@dvdherron I see, probably relates to scroll bars. This is what I see in FF on Mac OS:

And Chrome:

Seems like this probably isn't related to this PR, or really to Metecho specifically? If there's a quick fix that's great, but I'm guessing the same issue occurs elsewhere where SLDS is used?

It looks different for you? Weird.

@dvdherron I see, probably relates to scroll bars. This is what I see in FF on Mac OS:

And Chrome:

Seems like this probably isn't related to this PR, or really to Metecho specifically? If there's a quick fix that's great, but I'm guessing the same issue occurs elsewhere where SLDS is used?

Aha, yeah, it must be something with the scrollbars. I'll leave that alone for now and work on wrangling those last two popovers in the header.

@jgerigmeyer Changed the icons and finally put the remaining popover visible.
I think these icons stand out a bit more but I'm happy to switch these if @SondraE prefers something else.

I'll mark this as ready for a style review from @stacyk and @mirisuzanne

@jgerigmeyer Something happening here seems to be causing a lot of tests to fail. Can the title value not be nested inside of other elements?

@jgerigmeyer Something happening here seems to be causing a lot of tests to fail. Can the title value not be nested inside of other elements?

@dvdherron Oops, yeah -- good catch. That DetailPageLayout component is used for projects, epics, and tasks. We only want this popover for projects, but we're not being careful enough about that. I'll fix that and see if it helps the tests...

I'll fix that and see if it helps the tests...

@dvdherron It was failing because when title isn't a string then it doesn't automatically get added as a title attribute. Fixed in https://github.com/oddbird/Metecho/pull/994/commits/afaeef73848943ff7b7b33a1d6501f4ed0a5c140

@stacyk I think all of your style changes were made. Tagging you for a another brief re-review.

Safari:

so close! I can take a look it it helps since I don't think you (@dvdherron) have Safari.
@jgerigmeyer @dvdherron Also, forgot to mention this yesterday, but LDS states that in order for the popover to be accessible, you have to move the focus to the first focusable element in the modal ... so in the menu it would be the first tour item, or in a tour item it would be that next button or the close button.

@stacyk Sounds like you're already on it but if you could look at what's happening with Safari that would be great.
I'm going to try to write this last test and I'll look into that accessibility issue.

Also, forgot to mention this yesterday, but LDS states that in order for the popover to be accessible, you have to move the focus to the first focusable element in the modal ... so in the menu it would be the first tour item, or in a tour item it would be that next button or the close button.

Ugh, that's a bug in the React-SLDS Popover implementation then. @dvdherron I can take a quick look; if it looks difficult, I'll propose breaking out into a new story.

I know there's probably going to be some changes here, but it feels good to see this on this PR:

That was a silly Safari issue. It's looking good now.


New Version WhatsApp

Hello people! We're testing the new BETA version of WhatsApp for Multi-device and we've noticed that this library doesn't work anymore, has anyone seen this?

https://github.com/Rhymen/go-whatsapp/issues/598


mat-table laggy behavior with large number of elements

Bug, feature request, or proposal:
The mat-table component with selection suffers in performance when the number of elements gets decently large. Selecting a single row or the select all buttons shows a lot of lag that increases as the number of columns increases.
What is the expected behavior?
mat-table should be able to support good performance for large number of rows.
What is the current behavior?
Slow, laggy animations from clicking on single row checkbox or checkbox for select all
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
https://stackblitz.com/edit/angular-vyv97t
Update table with 100 rows, click a few checkboxes.
Update table with 1,000 rows, click a few checkboxes.
Update table with 10,000 rows, click a few checkboxes.
The performance gets significantly worse.
What is the use-case or motivation for changing an existing behavior?
Creating a table which contains lot of entries from the some backend API service. The user should be able to experience smooth UI and user experience.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 6, Material 6.4.7, Chrome
Is there anything else we should know?

Relates to #10122

I have a similar problem with mat-select. It takes about 3 seconds to show the panel if you have a large number of options. I'm looking forward to the virtual scroll getting into place within those components in #10122.

The order of setting up your sorting and pagination on a mat-table can have a large impact on performance.
Only including your data AfterVIewInit can speed this up significantly.
https://stackoverflow.com/questions/50283659/angular-6-mattable-performance-in-1000-rows#answer-51296374

Any update on this issue?
I'm facing the exact same issue using Angular 10, Material 10 and Chrome 96.
In my case, I use mat-table with expandable rows, and the slowness is very evident with 100 items on screen.
In addition, I noticed than in early versions of Chrome, this issue did not happened. It started to happening just a couple of months ago, with my Angular app staying the same all the time (no deployments in between). Another thing I noticed is, my exact same app does not show as much lag as with MS Edge (Chromium), which actually surprised me a lot. Even when MS Edge consume more CPU and RAM than Chrome, it feels kind of faster in comparison.
Could it be that Chrome updates are making this navigator slower and slower every time?

Hello,
Still facing this issue on the latest version of Angular in 2023 is there going to be any attempt for better performance of large table data (i.e. larger than 20 columns and multiple data rows)?
Seems odd this is still persistent issue.

Adding to the thread here as we too are experiencing a lack of performance on large data sets.

Example contains function call in attribute value (hasValue(), isAllSelected(), etc.) :
  <ng-container matColumnDef="select">
    <th mat-header-cell *matHeaderCellDef>
      <mat-checkbox (change)="$event ? masterToggle() : null"
                    [checked]="selection.hasValue() && isAllSelected()"
                    [indeterminate]="selection.hasValue() && !isAllSelected()">
      </mat-checkbox>
    </th>
    <td mat-cell *matCellDef="let row">
      <mat-checkbox (click)="$event.stopPropagation()"
                    (change)="$event ? selection.toggle(row) : null"
                    [checked]="selection.isSelected(row)">
      </mat-checkbox>
    </td>
  </ng-container>

Function calls in template expressions is a very bad practice for performance (cf. https://medium.com/showpad-engineering/why-you-should-never-use-function-calls-in-angular-template-expressions-e1a50f9c0496)


STS-135 Launch and Landing

Personal photographs of Space Shuttle Atlantis on the final flight of the Space Shuttle fleet.

Close pull_request


Force to update CurrentIndex before scroll ended (during scroll)

CurrentIndex is only updated when scroll finishes. It is probably done this way for performance, but for our specific case we need it to be constantly updated. We have added the possibility through a boolean property which is false by default.

missing ios implementation


DOCS: Update text

Description
This text should be updated as We can have mutliple abbreviations for a single word

Screenshots
No response

What I meant by this, was that if someone entered the full meaning of a slang, it won't give them the abbreviation. That is, you can only get full meanings, and not the other way round.

Ohh, ok thanks Emy! ;)


[macOS] Fix aws-sam-cli installation by rolling back brew formula

Description
The latest aws-sam-cli is broken with the error after the PR https://github.com/aws/homebrew-tap/pull/138:
==> Pouring aws-sam-cli-1.4.0.sierra.bottle.tar.gz
🍺  /usr/local/Cellar/aws-sam-cli/1.4.0: 4,154 files, 85.8MB
thebestmbpever:~ mikhail.timofeev$ sam --version
dyld: Library not loaded: @executable_path/../.Python
  Referenced from: /usr/local/Cellar/aws-sam-cli/1.4.0/libexec/bin/python3.7
  Reason: image not found
Abort trap: 6

As a workaround, we can use the previous formula version.
Related issue:
n\a
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run macos1015


remove string related config

I missed removing some of the the string metrics related properties from our CoreConfig
This PR removes:

TENANTIDS_TO_KEEP
STRING_METRICS_DROPPED
properties

@usnavi @ChandraAddala @izrik @drenalin23 , please review

Coverage decreased (-0.1%) to 74.497% when pulling 36ce45fc9d13d9b30956b8876ad97eefff25e933 on shintasmith:rm_tenantids into 1f3f23edb5427dea074a46eb14b61f6f90db3720 on rackerlabs:master.


Refactoring

Move all the React components into separate files so as to make everything easier to understand.

This got implemented before. Forgot to mention the issue in the commit. Woopsie. :-1:


Add health checks for builder services

This is probably optional. Builder doesn't have any healthcheck hooks from what i can tell

Sprint Planning Notes:

there are currently no health check in the bldr services
the only way to know they're not working is that the services could be cycling and have low uptimes
if there's a status endpoint for the services, we should call it
memcached should also have a status endpoint
we'll have a converstaion w/ the bldr team on getting a status endpoint into the bldr-api if it doesn't exist

[ ] automate-minio
[ ] automate-builder-api-proxy
[ ] automate-builder-api
[ ] automate-memcached


[Bugfix] release request memory before instance_mem_tracker desctructed (backport #8473)

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/StarRocksTest/issues/703.
Problem Summary(Required) ：

This is cherry-picked from #8473.

run all


Purchases and Sales Filters Don't Stay Set After Browsing

Not sure if we want to implement this, but the filter boxes on these two tabs eventually get cleared when you start browsing around. Should these stay remembered for when you eventually come back?

Those filters are embedded in the url, so if you are navigating around using the back / forward buttons your filters are restored.
Are you asking if the filters should be remembered even when navigating to the page using the navigation menu?


Fix acquire semaphore initialization in quad example

Fixes a small error in the quad example that would cause problems for when frames_in_flight < frame_images.len(). Aligns the code with what the comments say.

Thank you!
bors r+


Can we rename a Public IP name once created?

Can we rename a public IP address to some meaning full name once created? One way is I can delete and create a new IP but in that case I will loose the IP already associated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 19d6d70c-eed7-8fdc-e04b-995cabf0a902
Version Independent ID: a33391e9-3023-8212-6246-d64071efc2b5
Content: Create, change, or delete an Azure public IP address
Content Source: articles/virtual-network/virtual-network-public-ip-address.md
Service: virtual-network
GitHub Login: @KumudD
Microsoft Alias: kumud

@moirf Thanks for the question. We are investigating the issue and will update you shortly.

@moirf , as of today rename option is not available for any resources in Azure. You need to delete and recreate it.

For most resources that's pretty simple. For public IP address, they might change. Is it possible to ensure that the same IP address be assigned to the re-created address object?

I am in the same boat. Someone in my org erroneously named the IP address using an IP address, but they are different. So I have a scenario like this:
Name: <IP_ADDRESS>
IPv4 Address: <IP_ADDRESS>
This hosts a production resource and we cannot lose this static IP address.
How can I rename this resource so that the name isn't set to "<IP_ADDRESS>"?

is there any news about this problem ?
i have the same issue. i need to keep the same Ip of my VM but with a different name !!

@moirf , as of today rename option is not available for any resources in Azure. You need to delete and recreate it.

is this still the case today?

@moirf , as of today rename option is not available for any resources in Azure. You need to delete and recreate it.

is this still the case today?

UP :)

@moirf , as of today rename option is not available for any resources in Azure. You need to delete and recreate it.

is this still the case today?

Yes, this is true as of today!

@moirf , as of today rename option is not available for any resources in Azure. You need to delete and recreate it.

is this still the case today?

Yes, this is true as of today!

Thanks. If it is then why the case was closed?

up

This would be a nice feature to have especially when spinning up AKS. Any reason why this can't be a future feature? I see this issue was closed.

up

up

This thread is only for Microsoft Docs (docs.microsoft.com) - the product team is not going to hear your feedback here. You'll need to do one of the following:

Find a GitHub repo for Azure Networking and submit an issue
Find a Microsoft Feedback forum and submit an issue/suggestion
File a support ticket within the Azure Portal and ask them to rename it - when they tell you it isn't possible, ask that they submit the feedback to the Azure Networking team to add the feature.

I also suggest frequent use of the feedback button to remind that people really care about being able to rename things in Azure.

@moirf , as of today rename option is not available for any resources in Azure. You need to delete and recreate it.

is this still the case today?

Yes, this is true as of today!

Thanks. If it is then why the case was closed?

i dont think thats true, ie application insights can be renamed


I was going to clean it up, I promise!

I don't know if there is much we can do about this, but it would be very cool if this didn't throw an error.
var loudRejection = require('loud-rejection')

loudRejection()

var myp

setTimeout(function () {
  myp = new Promise(function (resolve, reject) {
    setTimeout(reject, 100, new Error('Silence me'))
  })
}, 100)

setTimeout(function () {
  myp.catch(function (err) {
    console.log('Catched!')
  })
}, 300)

I think that it has to go into the Promise implementation thought, and I guess that that ship has sailed.
My idea was to do this when the promise is thrown away by the garbage collector, if it hasn't been handled by then it won't ever be. But maybe this has problems as well?

Hmm, since this is for CLI tools, I could defer the console.error and exiting until process.on('exit').
See the docs: https://nodejs.org/api/process.html#process_event_unhandledrejection
Could probably do something like the example in https://nodejs.org/api/process.html#process_event_rejectionhandled and keep track of unhandled rejection that are not eventually caught.

Hmm, yes that could possible work actually. Nice find!

Pseudo code:
var unhandledRejections = [];
process.on('unhandledRejection', function(reason, p) {
    unhandledRejections.push(p);
});
process.on('rejectionHandled', function(p) {
    var index = unhandledRejections.indexOf(p);
    unhandledRejections.splice(index, 1);
});

process.on('exit', function () {
  if (unhandledRejections.length > 0) {
    unhandledRejections.forEach(function (x) {
      console.error(x.reason);
    });
    process.exitCode = 1;
  }
});

Wanna do a PR?

Sure! Might take a day thought :rocket:

@LinusU Any progress? No worries if not. Just asking as I'd like to include this in AVA, but it's blocked by this issue.

None yet, I'm on the airport going home now so if I'm not too tired I'll fix it tonight...

Closed via #5


Add Back On Track (JamAttack Cover) by DJVI

Song Name
Back On Track (JamAttack Cover)
Artist Name
DJVI
Source
Youtube
Youtube Link
UTBXVCyLU28
Direct File Link
No response
Song ID
522654
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 12561472

accept


Fix GLSL and HLSL preprocessor line continuation

Both shading languages allow their preprocessor to use line continuation with backlashes \, if they are the last character on a line before newline or carriage return. This PR adds support for that:
// Multiline replacement using backslashes for continuation:
#define SAMPLE(param1, param2, param3, param4) long_function_call( \
        param1, \
        param2, \
        param3, \
        param4 \
)

Noticed this problem when generating Godot's documentation for its shader preprocessor (which is very similar to GLSL and HLSL preprocessor). Notice how the first shader code block in https://docs.godotengine.org/en/latest/tutorials/shaders/shader_reference/shader_preprocessor.html does not get syntax highlighting at all as the current lexer produces an error because of \ characters. This PR fixes the issue and the code block is highlighted correctly.

Thanks! Could you please add/extend an example file with this so we can capture future regressions? You'll need to run pytest --update-goldens afterwards.

Thanks for the feedback! Removed "\r?" and added some tests, let me know if I missed something.


The SAS attached storage account name displays '(Unknown)' in the copied table activity log

Storage Explorer Version: 1.18.1
Build Number: 20210309.6
Branch: main
Platform/OS: Windows 10/ Linux ubuntu 18.04/ MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression
Steps to Reproduce

Select one storage account.
Use SAS connection string to attach the storage account with full permissions.
Expand the SAS attached storage account -> Tables.
Select one table then right click it -> Click 'Copy Table' -> Paste the table.
Check whether the SAS attached storage account name shows well in the activity log.

Expected Experience
The SAS attached storage account name shows well.
Actual Experience
The SAS attached storage account name shows '(Unknown)'.

Additional Context
This issue doesn't reproduce for one file share/ blob container.

This is due to a legacy SasUri class not supporting the new endpoint. Since the connect dialog has been rewritten, we should migrate things depending on it to use the new StorageUrl class.

@JasonYeMSFT
Verified this issue on build 20210313.6. Are the below behaviors expected?
There is a 'https://' that precedes the SAS attached storage account name in the copied table activity log.

There is no 'https://' precedes the SAS attached storage account in the copied blob container/ file share activity log.


THIS PAGE MUST BE REMOVED IMMEDIATELY

There is no longer a team at Azure Dedicated to support Oracle workloads on Azure BareMetal Infrastructure (BMI).  They have either left the company, retired, or been re-assigned.  As a result, it is misleading and confusing to customers for this documentation to continue to be exposed publicly, so all mention of Oracle on BMI must be removed immediately.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b662a46a-a5e7-f1ec-dc7d-2f7fbccf81cc
Version Independent ID: 7ab536ca-f265-d5f1-8bda-356ac6f7cfb5
Content: BareMetal SKUs for Oracle workloads - Azure Baremetal Infrastructure
Content Source: articles/baremetal-infrastructure/workloads/oracle/oracle-baremetal-skus.md
Service: baremetal-infrastructure
Sub-service: baremetal-oracle
GitHub Login: @dineshga
Microsoft Alias: dineshga

@tigormanmsft Thank you for reporting this. We will work on this internally with the team and update.

@tigormanmsft Thanks for pointing this out.
We are working internally to get these docs removed.
Closing all the issues now.
We can connect internally if there are any further questions on this.

@VikasPullagura-MSFT - please hold off on removing these pages.  Kalyan Kaki of the Azure Dedicated product group has stepped up to take responsibility for the pages, so please do nothing without his authorization.  Thank you!


feat(sidebar): update bridge icon

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

Issue Number: Closes #398
What is the new behavior?
non-active

active

Does this PR introduce a breaking change?

[x] No

Other information
Hello!

Excellent! Thank you for your contribution!


Simple log message changes

Sometimes when you want to index logs, keys with "_________________________" make the process unpleasant.
This commit removes the excessive underscore usage

@jbguerraz will you look at this simple change please?


no associated item named Down found for struct MouseEvent

bk (master)$ cargo install --path .
  Installing bk v0.5.1 (/home/roman/personal_projects/vendor/bk)
    Updating crates.io index
   Compiling bk v0.5.1 (/home/roman/personal_projects/vendor/bk)
error[E0599]: no associated item named `Down` found for struct `MouseEvent` in the current scope
   --> src/view.rs:136:25

fixed with https://github.com/aeosynth/bk/commit/f20adc60a3dcc744a3adbd40ba6aa6917f06d9c7

fixed with https://github.com/aeosynth/bk/commit/f20adc60a3dcc744a3adbd40ba6aa6917f06d9c7

thanks, btw. it's odd that the lockfile doesn't prevent this.

thanks, btw. it's odd that the lockfile doesn't prevent this.

Cannot see the new version here https://crates.io/crates/bk

Cannot see the new version here https://crates.io/crates/bk

published

published


2to3 but still not working :(

I started to write my own persistent connector for CS/Splunk and found this script. I am new to Python but I managed to get logged-in and set cookies and maintain a session for 2 days with bash ;) the next part is setting up the script to perform Splunk searches ...
CS_BADGER_WIP.txt

The issue am having is with spluruk.py does not matter what I put in the sample-toruk-cfg.cfg so I don't think thats the issue.
python3 spluruk.py -c sample-toruk-cfg.cfg -q bannan                                                                   ✔  ⚡  678  03:03:35
Traceback (most recent call last):
File "spluruk.py", line 139, in
f = FalconAuth(args.config_file)
File "spluruk.py", line 41, in init
self.falcon_auth()
File "spluruk.py", line 65, in falcon_auth
fh_2fa = totp.now()
File "/usr/local/lib/python3.5/dist-packages/pyotp/totp.py", line 44, in now
return self.generate_otp(self.timecode(datetime.datetime.now()))
File "/usr/local/lib/python3.5/dist-packages/pyotp/otp.py", line 33, in generate_otp
hasher = hmac.new(self.byte_secret(), self.int_to_bytestring(input), self.digest)
File "/usr/local/lib/python3.5/dist-packages/pyotp/otp.py", line 50, in byte_secret
return base64.b32decode(self.secret, casefold=True)
File "/usr/lib/python3.5/base64.py", line 232, in b32decode
raise binascii.Error('Non-base32 digit found') from None
binascii.Error: Non-base32 digit found

needs a rewrite in python but it works:
https://github.com/freeload101/SCRIPTS/tree/master/Bash/CS_BADGER


Event types description

Hi,
When we installed our first free_rasp enabled app from the Apple App Store on an iPhone 7, the app would show a "Device ID" RASP event.
Is this expected?
We also noticed that there was a "Passcode" RASP event during what we presume to be the Apple tests. Is this also expected?
Is there a document explaining the various events so that we can understand their severity and relevance?

Also, the same app got the "Tamper" RASP event while installed on our Android devices from the Google Play Store.

During their tests of the Android release, the Google Play store apparently got the "Untrusted installation" RASP event.

Hello,

The deviceID event is expected. When an application is reinstalled, the identifierForVendor changes (if other application from the same vendor using freeRASP is not installed). We do not recommend terminating reactions to this event (and also for device binding event)

In regards to passcode events: Apple tests may use devices without passcode turned on, therefore the event happens. It is expected.

However, in terms of Android tampering, we can see multiple appIntegrity (tamper) incidents in Kibana. All of them are cases when the application was signed using debug signing keys (C=US,O=Android,CN=Android Debug). It could be caused by using debug signing config in your release build type. If you want more detailed information about these incidents, please contact us at<EMAIL_ADDRESS>

There is a possibility of "Untrusted Installation Source" events during the Google app verification process.

We will update the documentation explaining the various events so that the severity and their relevance is properly explained. Thank you for your feedback.

Thank you very much for those explanations.


HTMLCanvasElement.toBlob() is no longer patched in 0.9.1

I noticed the following issue in bumping one of my projects to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>It seems that when using HTMLCanvasElement.toBlob(), the callback function no longer runs in the original zone. This caused problems when using toBlob within an Observable stream.

Minimal reproduction
Broken in ng8 (0.9.1):
https://stackblitz.com/edit/angular-toblob-8
Working in ng7 (0.8.29)
https://stackblitz.com/edit/angular-toblob-7

Is this a known regression that this is no longer patched when importing zone.js/dist/zone ?

@zbream, this is a bug, I will push the canva back the default bundle of zone.js in the next version, for now, please add the following line in src/polyfills.ts.
import 'zone.js/dist/zone'; // Included with Angular CLI.
import 'zone.js/dist/zone-patch-canvas';

@zbream, this is a breaking changes from 0.9.1, you can
import 'zone.js/dist/zone-patch-canvas';

to resolve this issue, sorry for the lack of documentation. I will close this one for now.


The JWT plug-in verifies if there is a problem with the maximum tolerated expiration time

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
2.5
Current Behavior
Whether this function is used to verify that when the token expires, it is considered legal as long as it is within the specified range, and then the time threshold is specified by maximum. If so, is there a problem with the writing of this expression? For example, if the threshold is 5 minutes and the token expires at 2021-12-01 12:00:00, then the expression exp - time() > maximum is illegal, Then the time before 11:55:00 on December 1, 2021 is illegal, which is inconsistent with the expectation.
Reference source code location plugins/jwt/jwt_parser.lua
--- Check that the maximum allowed expiration is not reached
-- @param maximum_expiration of the claim
-- @return A Boolean indicating true if the claim has reached the maximum
-- allowed expiration time
-- @return error if any
function _M:check_maximum_expiration(maximum_expiration)
if maximum_expiration <= 0 then
return true
end
local exp = self.claims.exp
if exp == nil or exp - time() > maximum_expiration then
return false, { exp = "exceeds maximum allowed expiration" }
end
return true
end
Expected Behavior
No response
Steps To Reproduce
No response
Anything else?
No response

This is used to check expiry by default:
https://github.com/Kong/kong/blob/master/kong/plugins/jwt/schema.lua#L28
https://github.com/Kong/kong/blob/master/kong/plugins/jwt/jwt_parser.lua#L346-L348
The maximum expiration checks that expiration of a non-expired token is not too far in a future.
exp - time() = how much there is left in token lifetime
maximum_expiration = that that there isn't more lifetime left than this value
I didn't check if it should be > or >= but there can be only one second difference with that, which can be compensated with maximum_expiration setting. So I am not sure I understand the issue. Can you elaborate a bit more. There might be something that I just cannot see.

@liuyunlong1229 any feedback on ^

Hi @bungle , I already using kong 3.4, but still, jwt maximum_expiration doing wrong.
or maybe i produce wrong token.


[typescript][11.qnamaker] Sample doesn't run following the README instructions

Sample information

Sample type: \samples\
Sample language: typescript
Sample name: 11.qnamaker

Describe the bug
The sample doesn't run after configuring the .bot file following the README.md. Instead the following error is thrown
Error reading bot file. Please ensure you have valid botFilePath and botFileSecret set for your environment.
 - The botFileSecret is available under appsettings for your Azure Bot Service bot.
 - If you are running this bot locally, consider adding a .env file with botFilePath and botFileSecret.

To Reproduce
Steps to reproduce the behavior:

Follow the prerequisites instructions
Fill the .bot file with the required data
botFileSecret in .env file remains empty since it was filled with plain data
Run npm start
Error reading bot file gets thrown.

Expected behavior
Sample should run correctly.
[bug]

Closed because this error is caused by a syntax error in the .bot file.


Quick workaround for Gmail IMAP access issues without 2FA if you have Office 365

As mentioned in other issues (#1081, #1082) it is no longer possible to log in to Gmail via normal password.
One solution is to use app passwords but these require enabling 2-factor authentication.
Another one I found is to use Outlook.com as a IMAP-to-Gmail proxy. This requires any Office 365 license.

Add your other email accounts to Outlook.com

You don't need to open Outlook account, you can just sign in with any Microsoft account (including one created for<EMAIL_ADDRESS>Once you do this, your Gmail account with show up as a folder named like your gmail login (including over IMAP)

Configure SMS Backup+ to use Outlook IMAP server - outlook.office365.com and your Microsoft account credentials
In backup settings update Gmail labels to be prefixed with the name of your account and /, e.g<EMAIL_ADDRESS>
That's it. It should work now. Outlook syncs emails back to Google with few minutes of delay so may need to wait a bit for them to show up on Gmail side.

Closing as nothing to do here as this is informative only but this repo doesn't have discussions.


Use telegram-api instead of curl

Switch to telegram-api library instead of calling system's curl
Start using stack
Remove modules other than Main
Relax version constraints of dependencies


fixed comment tag

if the space before --> is not there, it creates problem for other jekyll tools, like jekyll compress by https://github.com/penibelst/jekyll-compress-html. Tools like this depends on specifically --> and removes necessary html elements in case a --> is  found.

Also,
it is incorrect by definition anyway
https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/The_Importance_of_Correct_HTML_Commenting

I support this as long as jekyll-compress compatibility depends on it. I also agree that it looks better with the space in there.
Instead of linking to a wall of text, quote the part of the standard that express the "definition" you refer to. I don't think it is invalid HTML 5.

Ah, ok.

Comments must start with the four character sequence U+003C LESS-THAN SIGN, U+0021 EXCLAMATION MARK, U+002D HYPHEN-MINUS, U+002D HYPHEN-MINUS (<!--). Following this sequence, the comment may have text, with the additional restriction that the text must not start with a single ">" (U+003E) character, nor start with a U+002D HYPHEN-MINUS character (-) followed by a ">" (U+003E) character, nor contain two consecutive U+002D HYPHEN-MINUS characters (--), nor end with a U+002D HYPHEN-MINUS character (-). Finally, the comment must be ended by the three character sequence U+002D HYPHEN-MINUS, U+002D HYPHEN-MINUS, U+003E GREATER-THAN SIGN (-->).

Without the space, --> becomes part of the text. Additionally, none of the declared valid examples in w3 documentation shows usage of --> without space after text.

OK... Maybe the "nor end with a U+002D" is what you really wanted to highlight (this seems to be the only thing the text is possibly violating here). However, I am still unsure whether or not that is an invalid HTML 5 comment.
Anyway, the plugin compatibility issues are enough of a reason already.

I would like to share just one more example from https://www.w3.org/TR/html4/intro/sgmltut.html:
HTML comments have the following syntax:

<!-- this is a comment -->
<!-- and so is this one,
    which occupies more than one line -->

Do note that this is taken fro html4 documentation.
I am sharing this because I do not want to have any misconception. Please do let me know if I misunderstood something. I am willing to learn and correct myself :smile:
Thank you for letting me know about your confusion.

I think you're both agreeing with one another but just confused about it? @lordamit is saying that it's part of the HTML5 standard to have a space before -->, which is right 😆.

Yes, I just don't find that on the standard. I see the examples, but the rules are not explicit about it.
I am not exactly confused, just trying to refute this point (mostly because I am unsure whether or not it is actually part of the standard and simply saying that it is part of the standard is not enough) but agree with the pull request as it fixes an issue.

Removed all these comments in #238.


Fixing temp directory path for assetDest

temp directory for assetDest was wrongly being created in project root, instead of tmp.
Fix for #519

@apexskier can you check that?

Ah, I must have messed up when testing this. Thanks for the fix! I've confirmed it works.


Making own middleware - a bit unclear how to do so…

It is possible to figure out how to make your own middleware looking at existing ones.
But it is not clear why AbstractMiddleware is used as a base class in some cases and in others I can see interfaces are used like MiddlewareInterface and MiddlewareLogicInterface.

Middleware
"Base"

AbstractMiddleware
MiddlewareInterface, MiddlewareLogicInterface

CaseConversion
AbstractMiddleware

Debugger
AbstractMiddleware

DocBlockAnnotations
AbstractMiddleware

FinalCallback
MiddlewareInterface

NamespaceResolver
AbstractMiddleware

TypedProperties
AbstractMiddleware

AbstractMiddleware
AbstractMiddleware

Maybe if there was a dedicated docs page on how to start on building your own middleware it would help?
Just a few pointers as a starter, e.g.

to get started writing your own middleware, use xyz
for more details, look into existing middleware and e.g. link to source code

Thanks for you input @alexkuc given you looking for answers I guess making the PR will be difficult. I’ll see when I have time available to sort it. Any specific question that is blocking you now?

@DannyvdSluijs thank you for the fast response. I am currently going over source code of the existing middleware. I'll let you know if I get stuck with something. Thank you again.

@DannyvdSluijs I managed to put something myself together. I think I got the general gist of the approach. Would you be open to PR to update docs?

PR are more than welcome. That is the power of open source.

@DannyvdSluijs I was about to start writing new README page but I just realised something so wanted to double check with you:
https://github.com/JsonMapper/JsonMapper/blob/54ac9f7b1d21c54d934ab288189752d6f9f02194/src/JsonMapperInterface.php#L11
As far as I can tell JsonMapperInterface does not really enforce middleware type, it's purely by convention that middleware should use MiddlewareInterface and MiddlewareLogicInterface?

@alexkuc I wanted to check with you if you still need any help, either in understanding JsonMapper or in opening a PR?

@DannyvdSluijs all is good


Can not Align each column of words by using TAB.Proof of IMG

VSCode Version:1.21.1
OS Version:WIN 10

Steps to Reproduce:
1.Type words in first row and next,BUG occurs when trying Align them to same column.
show the issue

Does this issue occur when all extensions are disabled?: Yes

@netldds Please use a font (e.g. Inconsolata) where CJK characters are always rendered with the width of two latin characters.


NoSuchElementException on get_users_following()

I'm trying to run the Example.ipynb file and I'm encountering this error once I try to run the get_users_following code cell.

I've adjusted my .env file to reflect an active Twitter account already. Any ideas on what I should debug? I'm running this on Python 3.9 on a Jupyter notebook.

Did some debugging, it seems that it works if I specify the username to be NAgouzil, but if I use the default one provided in the notebook, it returns the error. It seems that the href element has to match the exact current username of the profile to be scraped.

Did some debugging, it seems that it works if I specify the username to be NAgouzil, but if I use the default one provided in the notebook, it returns the error. It seems that the href element has to match the exact current username of the profile to be scraped.


refactor: Break subs dependency in stream_data.

We move remove_deactivated_user_from_all_streams
into stream_events.js.  There were some minor changes
to rename variables and also to not rely on using
stream_info.

Testing Plan:
GIFs or Screenshots:

Looks good, merged, thanks @showell!


Do something reasonable with string literals

OQ3 supports neither a string type nor string literals. (It does support bit string literals, eg "1001")
Currently a string literal will cause a panic in syntax_to_semantics.rs here
here
https://github.com/Qiskit/openqasm3_parser/blob/b9e9ae8bf46de94be57f719aba1d1b4e4897ee66/crates/oq3_semantics/src/syntax_to_semantics.rs#L702
The lexer tokenizes string literals (eg "abc") as token STRING. The parser then constructs the variant SyntaxKind::Literal
https://github.com/Qiskit/openqasm3_parser/blob/b9e9ae8bf46de94be57f719aba1d1b4e4897ee66/crates/oq3_parser/src/grammar/expressions/atom.rs#L11-L30
I'm pretty sure that everywhere a string literal is encountered in the code above it is a string literal that is not part of the language (ie bit string literals, pragmas, etc. have been filtered out). So we could record a parse error here. Since we currently do not proceed with semantic analysis if there are parse errors, the panic mentioned above would not occur. But we'd still want to do something reasonable in place of the todo!.
I should also note that you can get a string literal at the level of the AST (really CST) although this should not be part of the language:
https://github.com/Qiskit/openqasm3_parser/blob/b9e9ae8bf46de94be57f719aba1d1b4e4897ee66/crates/oq3_syntax/src/ast/expr_ext.rs#L288-L297
version/commit
b9e9ae8b

With #123 a parse error is recorded.
So the panic mentioned in the opening comment no longer occurs.


What is the recommended way to wait for descendant custom elements to be upgraded?

Reading the docs:

ready (callback)
Executes callback when all components are loaded and all elements are upgraded. This comes in handy inside a component when it requires descendants to be upgraded before it uses them.

This seems to be the only way? By "all elements" is it meant all descendant elements or all elements on the page?
My usecase: I'm must take a measurement of the dimensions of an descendant custom element in order to apply some css workarounds on parent.

You should be able to do that in attached. In fact, in order for something to have layout it must be attached so you'd need to do it there anyways.

I'm assuming this related to #296 so closing. If not, feel free to reopen.

Cool, attached works. It wasn't related to #296 but it is now :) . I was going even to reference it here myself for future reference to other people reading.

:+1:


Extension considerations

This pull request introduces some initialization options to FLAnimatedImage that allow clients to configure it in a way that consumes less memory than the default. These settings are:

Specify number of frames to keep in memory: https://github.com/Flipboard/FLAnimatedImage/commit/0b4886003f34d1b89cd1b5ec9552852c08891c15
Disable frame predrawing: https://github.com/Flipboard/FLAnimatedImage/commit/4e78f71102a824d831b1b3aa348706b5640985fd

I took some instruments in different configs

ConfigurationMemory Used ("All Heap & Anonymous VM" in instruments)Delta from Default
Default47.8MBN/A
Disable frame preloading30.9MB16.9MB
Disable frame predrawing33.9MB13.9MB
Disable frame preloading and predrawing28.2MB19.6MB

The reason that the memory savings in the final row isn't the sum of both disabled frame preloading and disabled frame predrawing is that predrawing only impacts loaded frames, and when there are fewer frames preloaded disabling predrawing doesn't have as large of an effect.
I also made the designated initializer take a CGImageSource rather than NSData because of a PR recently closed on FLAnimatedImage requesting it for more flexibility.

@lukescholefield would love it if you reviewed this since you and I talked through much of this in person.

@kdubb https://github.com/Flipboard/FLAnimatedImage/commit/f769407ecdbe1e90aa5732cae12cbffdc95b5cff in here satisfies https://github.com/Flipboard/FLAnimatedImage/pull/94#issuecomment-171048183.

Looks fine, except for the NSData issue, which is significant.
As mentioned in person, I do wonder if we could be smarter about when we load frames, so that we only cache frames "just in time" rather than a preset number of frames. But this is definitely a sold start to reducing the footprint.

@lukescholefield I've force pushed over the old branch here, now data is untouched.

Great, I am now fine with this.  What was the memory impact of retaining data?

I believe there wasn't one, would need to double check that though.

Another method we're using on our internal branch to reduce memory usage is via CGImageSourceCreateThumbnailAtIndex(). Memory is quite constrained in extensions, and using that provided a huge boost.

THANK YOU, good to know!

We're working on shipping this in an extension now.


ModuleNotFoundError when using uv pip install in GitHub Actions

Hi there! I'm using uv in a GitHub action but ran into ModuleNotFoundError when importing click and tqdm.
I'm using the latest version of uv. When I use uv pip install, I get several import errors, but when I use vanilla pip install, the action runs without issue. An example run: https://github.com/kevinhu/uv-gh-action/actions/runs/8032491324/job/21941942800
Here is a minimal example that reproduces these errors on Python 3.9 through 3.12: https://github.com/kevinhu/uv-gh-action. I've set up two jobs, uv and pip, that differ only in their install command: uv pip install ... vs pip install ...

As far as I'm aware the virtual environment won't remain activated across steps in GHA since the shell reloads per step. In your pip workflow you end up installing dependencies outside the virtualenv, hence why you can import them. uv defaults to installing them on the .venv which is why you see uv failing.

Thanks! I thought the PATH modification would work but I guess not.

Thanks @samypr100!


Refactor Code

Right now the code is super efficient, but very much spaghetti.  I'll make it just slightly less efficient to simplify the code, increase its readability, and maintainability.

Progress with https://github.com/nabakin/drop/commit/ac411fca39422ab008802ce8116c01fc6ec9ead2.

Finished with https://github.com/nabakin/drop/commit/634b2b1ef33c624033968228d8d44b014cefb935.


docs/bun: Add link to external installation guide

This makes it easy to look for the homebrew installation steps for example.

Hey @tordans , see my comment from the other PR: we entirely rewrote this page today for the new Bun 1.0, so this PRs an old version of the page. You're absolutely welcome to check out the new version of this page live in the docs and see if this is still something you'd suggest. 🙌