Clean up old certificates

Currently, old certificates are left on the endpoint because it's easier and less error-prone.
Look into deleting unwanted certificates:

must be issued by Let's Encrypt (IssuerName = /C=US/O=Let's Encrypt/CN=R3)
must not be used for any services
must also clean up certificate chain (R3 and ISRG Root X1)

There is also the possibility that Cisco will automatically delete expired certificates, but I can't test this yet because the oldest certificate on any of my endpoints is going to expire on Jun 09 03:34:01 2023 GMT.

Chains are automatically cleaned up when the leaf certificate is deleted because they're from the same PEM file I guess.
Given the elided list of certificates:
xcommand Security Certificates Services Show

OK
*r ServicesShowResult (status=OK):
*r ServicesShowResult Details 1 Fingerprint: "bcce6f83762eebea9daea4dab31f1a419fce96dc"
*r ServicesShowResult Details 1 HashingAlgorithm: "sha256WithRSAEncryption"
*r ServicesShowResult Details 1 IssuerName: "/C=US/O=Let's Encrypt/CN=R3"
*r ServicesShowResult Details 1 PublicKeySize: 2048
*r ServicesShowResult Details 1 SerialNumber: "04B88B3FE1BFB801A42F22F39917E0DEC509"
*r ServicesShowResult Details 1 SignatureAlgorithm: "rsaEncryption"
*r ServicesShowResult Details 1 SubjectName: "/CN=roomkit.aldaviva.com"
*r ServicesShowResult Details 1 UsedFor: ""
*r ServicesShowResult Details 1 Version: 3
*r ServicesShowResult Details 1 notAfter: "Jun 15 05:15:31 2023 GMT"
*r ServicesShowResult Details 1 notBefore: "Mar 17 05:15:32 2023 GMT"
...
*r ServicesShowResult Details 5 Fingerprint: "346931a18c97b47ea4e51e1ab10410693194b5f1"
*r ServicesShowResult Details 5 HashingAlgorithm: "sha256WithRSAEncryption"
*r ServicesShowResult Details 5 IssuerName: "/C=US/O=Let's Encrypt/CN=R3"
*r ServicesShowResult Details 5 PublicKeySize: 2048
*r ServicesShowResult Details 5 SerialNumber: "03B18087C65DFD40E71DF5DDD9BA44914BC3"
*r ServicesShowResult Details 5 SignatureAlgorithm: "rsaEncryption"
*r ServicesShowResult Details 5 SubjectName: "/CN=roomkit.aldaviva.com"
*r ServicesShowResult Details 5 UsedFor: "SIP, HTTPS server"
*r ServicesShowResult Details 5 Version: 3
*r ServicesShowResult Details 5 notAfter: "Aug 22 16:46:44 2023 GMT"
*r ServicesShowResult Details 5 notBefore: "May 24 16:46:45 2023 GMT"
...
*r ServicesShowResult Format: Text
** end

Certificate 1 should be deleted because its IssuerName is /C=US/O=Let's Encrypt/CN=R3 and is not used for anything because UsedFor is "". Certificate 5 should not be deleted because, even though it's also from Let's Encrypt, it is currently used for SIP, HTTPS Server.
This deletion can be accomplished with
xcommand Security Certificates Services Delete Fingerprint: "bcce6f83762eebea9daea4dab31f1a419fce96dc"

OK
*r ServicesDeleteResult (status=OK):
** end

After activating the new certificate, all Let's Encrypt certificates which aren't being used for any services will be deleted before restarting the web server, including ancestor certificates in the issuer chain.


task list

Please provide a task list to make this component production ready. I think I could help to achieve it.

Done


Misplaced timer

On the keeper card on keeper device side which was set using QR Nan Nan is showing. This is place for OTP timer but for keeper OTP does not come in picture (by Arpan sir).

Tested on version 1.1.2(107)


allow backslash in string, fixes issue #45

This pull request fixes the issue reported in #45 by adding the literal \ (backslash) to the definition of the type STRING. I could not find specifically if "port_instance" in the spec allows for this, but commerical EDA tools support it across the board (and generate such files), thus this library should support it as well.
I have added a testcase in the escaped_name.sdf file, which has crashed before, but has been fixed by the change.
Signed-off-by: Christian Lanius<EMAIL_ADDRESS>

Hi!
Thank you for your contribution! You will need to rebase this change before we can merge it.
Tim @mithro Ansell

Yeah, I am currently attempting to figure out what to do with them. They are not empty (as they exist in the repo), but their mode has changed. I'll ping you once I have figured it out.

@kgugala Alright, I fixed the string definition and fixed the file mode for the two scripts which I did not touch.


I, as a PR creator, should be able to backport PRs with a source branch in a forked repo

A backport isn't working if we try to backport a PR with a branch in a forked repo. See https://github.com/camunda/zeebe/pull/9383#issuecomment-1141223647.
I think that this is a must-have feature for popular repositories, that accept PRs from different forks 😅.

Thanks for raising this @aivinog1 👍 (and sorry for my late reply, I've been on a vacation 🏖)
I believe others have solved this by using pull_request_target instead of pull_request. camunda/zeebe should switch to this to support backporting PRs from forked repos.
This is not an issue with this action, but with the defined workflow. Therefore, I'll close this issue.
There's an existing issue to clarify the documentation:

https://github.com/zeebe-io/backport-action/issues/41.


v1.2.0 is not available on grafana labs plugins store

Hi @digrich,
Version 1.2.0 of bubblechart-panel is not published on grafana labs plugin store. Also, just wanted to understand if we are signing this plugin as grafana is now verifying the identity of each plugin.

I have published the latest version of plugin and waiting for the grafana team to verify it. And I am not sure if grafana is enforcing the signature at this point for community plugins.

v1.2.0 is available on grafana plugin store.


Add aerial photos to map_reach_overview

The map_reach_overview function must have an aerial photo background to allow the user to identify the context of each cross section. The tmap::read_osm that was used to display aerial photos is no longer working. Find a replacement.

Used the ceramic package to get aerial photos from Mapbox. 86e64300cfefdc223cd8bbae198e486dcddb46c1


No train.py

Thanks for your interest in this project, please refer to https://github.com/hustvl/MMIL-Transformer/issues/1.

@y1192310785  Thanks for your interest in this project. Please refer to #1.

ok thank you


feat: RTL support

pretty small fix for RTL support by just enforcing it to be LTR as numbers anyway always written left to right.

hi @vitansky i would love to add support to RTL, still I don't know what's a good example for this. this PR does not achieve the expected behavior as the CSS attribute is not enough to affect input's behavior.

Hi, I've added an example to switch to RTL/LTR in the demo website.
Also, I've added the style in the right place, my bad :)
before:
https://share.cleanshot.com/9mpvmwsr
after:
https://share.cleanshot.com/yX8bjvt8
it should behave just the same as LTR.

hi @vltansky I'm still not sure how to achieve the behavior you mentioned.
can you provide me with a preview/link?


Redis: listen on localhost by default

The redis service module listens on all interfaces by default (I found it via simple-nixos-mailserver which inherits nixpkgs' default):
https://github.com/NixOS/nixpkgs/blob/10acf9ae002563b1bc6519eb50a4d65c6c684e98/nixos/modules/services/databases/redis.nix#L88-L93
I think that is bad, because that is an insecure configuration. Because many people get owned by that, Redis has a protection against it; without further configuration, connecting to the listening port via TCP, it outputs:

-DENIED Redis is running in protected mode because protected mode is enabled, no bind address was specified, no authentication password is requested to clients. In this mode connections are only accepted from the loopback interface. If you want to connect from external computers to Redis you may adopt one of the following solutions: 1) Just disable protected mode sending the command 'CONFIG SET protected-mode no' from the loopback interface by connecting to Redis from the same host the server is running, however MAKE SURE Redis is not publicly accessible from internet if you do so. Use CONFIG REWRITE to make this change permanent. 2) Alternatively you can just disable the protected mode by editing the Redis configuration file, and setting the protected mode option to 'no', and then restarting the server. 3) If you started the server manually just for testing, restart it with the '--protected-mode no' option. 4) Setup a bind address or an authentication password. NOTE: You only need to do one of the above things in order for the server to start accepting connections from the outside.

But it's still listening on the port.
This has been that way for 7 yeas since the module was added in https://github.com/NixOS/nixpkgs/commit/6b4d76c2c217a706baf8006b7f1b3f38049b7a52 by @zefhemel.
I think many NixOS modules that define services which are usually used unauthenticated by now make them only listen to <IP_ADDRESS> by default.
So I think we should do that with the redis module as well.

CC recent service module committers @Mic92 @JJJollyjim @flokli @peti @bjornfor @polynomial @offlinehacker
CC simple-nixos-mailserver contributors @r-raymond @phdoerfler @nlewo @eqyiel

Evindence that pretty much all other DB servers listen to <IP_ADDRESS> by default in NixOS:
memcached
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/memcached.nix#L28-L31
postgresql
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/postgresql.nix#L184-L192
neo4j
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/neo4j.nix#L154-L156
couchdb
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/couchdb.nix#L108-L110
mongodb
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/mongodb.nix#L48-L51
influxdb
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/influxdb.nix#L10
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/influxdb.nix#L176
cassandra
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/influxdb.nix#L176
cockroachdb
https://github.com/NixOS/nixpkgs/blob/7badbf18c45b7490d893452beb8950d966327831/nixos/modules/services/databases/cockroachdb.nix#L36-L41

Fix in PR #100195.


Fix regression of renderer

Unfortunately, #15175 missed a feature that csv or external renderer could ignore PostProcess to make the render speed up which introduced at #15153. This PR will fix that.
This PR also fixed another bug which external renderers will load twice when settings reload. From https://discord.com/channels/322538954119184384/323701541297192961/851123308321046538 thanks @KN4CK3R

Codecov Report

Merging #16091 (24f049d) into main (ee5e1c4) will increase coverage by 0.11%.
The diff coverage is 70.00%.

:exclamation: Current head 24f049d differs from pull request most recent head 99197e2. Consider uploading reports for the commit 99197e2 to get more accurate results

@@            Coverage Diff             @@
##             main   #16091      +/-   ##
==========================================
+ Coverage   44.06%   44.18%   +0.11%
==========================================
  Files         683      683
  Lines       82358    82367       +9
==========================================
+ Hits        36295    36396     +101
+ Misses      40176    40071     -105
- Partials     5887     5900      +13

Impacted Files
Coverage Δ

modules/markup/renderer.go
67.00% <70.00%> (-5.53%)
:arrow_down:

modules/git/repo_base_nogogit.go
82.85% <0.00%> (-2.86%)
:arrow_down:

modules/git/utils.go
62.50% <0.00%> (-2.78%)
:arrow_down:

models/error.go
39.84% <0.00%> (+0.31%)
:arrow_up:

services/pull/pull.go
43.37% <0.00%> (+0.45%)
:arrow_up:

routers/api/v1/repo/pull.go
28.74% <0.00%> (+0.59%)
:arrow_up:

modules/markup/markdown/markdown.go
63.43% <0.00%> (+0.74%)
:arrow_up:

models/notification.go
66.07% <0.00%> (+0.88%)
:arrow_up:

modules/queue/unique_queue_disk_channel.go
48.63% <0.00%> (+1.36%)
:arrow_up:

modules/process/manager.go
75.30% <0.00%> (+2.46%)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ef6a6...99197e2. Read the comment docs.


[WFLY-9777] clean testsuite debris in git-trackable directories.

https://issues.jboss.org/browse/WFLY-9777 clean testsuite debris in git-trackable directories.

retest this please

Retest this please

Retest this please

failed ConcurrentCoarseWebFailoverTestCase.testGracefulSimpleFailover in Windows CI does not seem related.


Banner Ad not shown until leaving then returning to page (Android only)

Banner Ad not shown until leaving then returning to page.  This happens in Android only, iOS working as expected. On iOS I see the banner ads immediately on page load.
The banner does not appear on the page’s initial load, but when I navigate to a page ‘down the stack’ and then return to the page via the ‘move back’ button, the Ad then appears.  I have tried this on three different pages and get the same result.
I do see the following debugger message upon first loading the page with banner:
[Ads] JS: The jsLoaded GMSG has been sent …
…
[FA-Ads] Analytics storage consent denied; will not get app instance id
If I then advance to the next page and return back, the page is shown with the banner, and I get the following:
[Ads] This request is sent from a test device.
[Ads] Invoke Firebase method getInstance error.
[Ads] The Google Mobile Ads SDK will not integrate with Firebase. Admob/Firebase integration requires the latest Firebase SDK jar, but Firebase SDK is either missing or out of date
[Ads] JS: The jsLoaded GMSG has been sent …
I have not had Firebase in my project, as I don’t need its measurements.  I have Xamarin.Firebase.iOS.Core in the project as a transitive package.  I added Xamarin.Firebase.Core to the project, but this didn’t change anything.
I have the following Ad-related NuGet packages in my project (as transitive packages):
Xamarin.Google.iOS.MobileAds
Xamarin.GooglePlayServices.Ads.Base
Xamarin.GooglePlayServices.Ads.Identifier
Xamarin.GooglePlayServices.Ads.Lite
Here is some info about my code:
I am using the MTAdView declared in XAML.  I do not have a plug-in license.  My MTAdView has the x:Name=”bannerAd”.
In my xaml code-behind, I have:
protected override void OnAppearing()
{
base.OnAppearing();
bannerAd.LoadAd();
}
I’ve tried placing this LoadAd() call in other locations but get the same results.
Android::MainActivity.cs
public class MainActivity : MauiAppCompatActivity
protected override void OnCreate(Bundle savedInstanceState)
{
base.OnCreate(savedInstanceState);
CrossMauiMTAdmob.Current.Init(this, "My publisher id here");
}
protected override void OnResume()
{
base.OnResume();
CrossMauiMTAdmob.Current.OnResume();
}
}
My AndroidManifest.xml contains the following lines:
meta-data android:name="com.google.android.gms.ads.APPLICATION_ID" android:value="My publisher id here"
meta-data android:name="com.google.android.gms.ads.DELAY_APP_MEASUREMENT_INIT" android:value="true"
meta-data android:name="com.google.android.gms.ads.flag.OPTIMIZE_INITIALIZATION" android:value="true"
meta-data android:name="com.google.android.gms.ads.flag.OPTIMIZE_AD_LOADING" android:value="true"
I’ve tried eliminating the final three lines here, but nothing changed.
Thanks for the help!

With the new version (because of the Consent required before showing any ads) it's expected that you call LoadAd the first time, then it should work.
If it doesn't, try to subscribe to these events:
AdsClosed="MyAds_AdVClosed"
AdsFailedToLoad="MyAds_AdFailedToLoad"
This should tell you if the banner has been loaded or if the loading failed.
Let me know how it goes.
Meanwhile I'll see if there is an issue in the plugin and if so, I'll fix it

I definitely have been calling LoadAd(). I've tried placing that call in the page's constructor and in OnAppearing(), but it doesn't change the behavior.  What I have performs correctly on iOS.
I'll subscribe to those events and see what I see.

I've tested it and it with the sample and it works.
My current idea is that you might call the loadAd before the Mobile ads has
been actually initialised.
Out of curiosity, while we identify a proper solution...could you add a
delay of 4-5 seconds before loading the ads?
I'm working on a new version, and I'll probably add an event for when the
mobile ads has been initialised.
On Wed, 7 Feb 2024, 23:46 AntHillOracle, @.***> wrote:

I definitely have been calling LoadAd(). I've tried placing that call in
the page's constructor and in OnAppearing(), but it doesn't change the
behavior. What I have performs correctly on iOS.
I'll subscribe to those events and see what I see.
—
Reply to this email directly, view it on GitHub
https://github.com/marcojak/MauiMTAdmob/issues/64#issuecomment-1933060689,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUIPIRYRCSRZTFRR4I64C3YSP75DAVCNFSM6AAAAABC6RXJW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGA3DANRYHE
.
You are receiving this because you commented.Message ID:
@.***>

Adding a delay before (or after) the call to LoadAds() didn't have any effect.  I still don't get a banner until I leave the page and come back to it.
Thanks, Marco.

It's not clear to me what events you wished me to subscribe to.  There doesn't appear to be an available AdsClosed or AdsFailedToLoad event.  The closest name is OnAppOpenFailedToLoad.  In your sample it doesn't appear that your MyAds_AdVClosed or MyAds_AdFailedToLoad handlers are wired to anything?
I turned my Interstitial Ad code back on, and I am getting Interstitials as expected and those event are firing into my handlers.

If you look at the sample code, you'll see the events in the MainPage in the MTAdView control

If you look at the sample code, you'll see the events in the MainPage in the MTAdView control

Ok, I see the events in the xaml.  All of the event wiring for interstitials in the code-behind fooled me into expecting it there.
So I wired up the events -- On Android, no event is fired until leaving the page and returning, upon which "AdsLoaded" is fired and the banner appears. "AdsFailedToLoad" or "AdsClosed" events are not received by my handlers.
On iOS, the banners are working fine, but events on banners are never caught, including "AdsLoaded" and "AdsOpened" for live banners that are clicked on.  Interstitial events are working on iOS.
This is a MAUI .NET 8 project.

Question: How is one intended to show a banner ad without requiring the user to click on a 'load banner' button?
I've been messing with the MMTAdmobSample.  I added the 'myAds.LoadAd()' call from the 'load banner' button event handler to the MainPage constructor.  No ad appears, I tried some other things, but it seems the only way to get a banner to appear is to use the button click interaction.
Next, I added a new ContentPage and repurposed your 'Next Page' button to perform an 'await Navigation.PushModalAsync(new NextPage());' to the new page.  My NextPage has a banner ad control, a button to PopModal, and a button to Push another NextPage.
On the NextPage, the banner ad appears with the page load on iOS, but does not appear on Android.

I still believe that when you call the loadAd in the constructor, the MobileAds hasn't been initialized yet but to be sure,
let me do a test on the MMTAdmobSample and I'll update you on what's happening. It should work on both Android and iOS. If it doesn't it might be a bug.
I'm currently working to add the NativeAds but I'm planning to bring back the auto load for the banners doing automatically the check on the consent.
Anyway, for now, let me see what's going on with the banner

Ok, I've identified the issue.
I'll add it to the guide to explain how it should work, however in the next version, I'll also try to automatically load the banner.
Coming back to the issue. There are actually 2 issues here (not with the plugin but with how MAUI works):

If you call "myAds.LoadAd();" in the constructor, the related handler is not initialised yet, so nothing can happen.
if you delay the call but don't call it from the MainThread it will not work and will block any future call to LoadAds.

There are 2 options you can use, according to your preferences:

In your OnAppearing method you can add this code:
```
Task.Run(async () =>
{
Device.BeginInvokeOnMainThread(() =>
{
myAds.LoadAd();
});
});

At that time the Handler SHOULD (not certain but from my quick tests on a Pixel 7PRO it always was) be initialized and the BeginInvokeOnMainThread forces the call on the MainThread. This should work and you'll be able to see the Banner.

2) You subscribe (IN XAML or C#) to the event _HandlerChanged_

`HandlerChanged="myAds_HandlerChanged"`

and in your C# you can simply load the banner:

private void myAds_HandlerChanged(object sender, EventArgs e)
{
myAds.LoadAd();
}

In this case the Handler has been initialised and the load will happen correctly.

Thanks for the update/info!  Using the event handler as per option #2 works for me.
It would be cool if banners automatically loaded, just so we don't need to spread this boilerplate code around (notably this code isn't needed on iOS).

Yesterday I've released version 1.3.0.
This version automatically loads the banner after checking the consent (for the licensed version) or after the mobile ads initialisation for the non licensed version.
Closing it for now but feel free to open it again if you are having issues with it

This is still not working ideally with 1.3.0.  The ‘front page’ of my app works fine – it gets its banner loaded without any bannerAd.LoadAd() or HandlerChanged event code.  But upon navigating to a page down the stack, the banner will not load on the first appearance of the page without implementing a handler for the HandlerChanged event and there calling bannerAd.LoadAd().  On these subsequent pages a banner will eventually load without the extra code if you navigate down from the page and then return back to it – which is how version 1.2 performed.
I'm not seeing how to re-open the issue, so I'll leave that to you.
Thanks for the effort.

Thinking about it, you are right.
The code works for the first page but the loading doesn't happen in the others as the events I've used to see if we can actually load the banner are not invoked anymore.
I'll fix it in the next version.

I've just released version 1.3.1 which should fix this issue.
It should be available soon

That did the trick.  All is working now.  Thanks much!


koffi.call() is missing in index.d.ts

koffi.call() is documented at https://koffi.dev/functions#call-pointer-directly. However, it is missing in index.d.ts, https://github.com/Koromix/rygel/blob/master/src/koffi/index.d.ts.
koffi: v2.7.0
node: v18.19.0

Thanks for the report, I've added this in the latest commit :)


Run and colorpicker not working

ℹ Computer information

PowerToys version: 0.21.1
PowerToy Utility: ?
Running PowerToys as Admin: y
Windows build number: [run "winver"] 2004 Build:49041,508

✔ Expected result
Both should work
❌ Actual result
They dont
📷 Plz provide me with further data gathering instructions

Rebinding the colour picker fixed the colour picker.
I was unable to fix Power Toys Run

@NicTanghe
this week we are releasing 0.23 that has a fix for opening PT Run.

dup'ing against #6060.
@NicTanghe what was your CP keystroke before?


refactor: simplify ZapController

Description:

simplify ZapController
remove used dependencies

Motivation and Context:
Cleaning code whilst trying to debug e2e test issues
How Has This Been Tested?
Manually
Types of changes:
Refactor
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 20.119% when pulling 7d284aca3e1edd6fe3c667b61f5dd4e4dddbb91d on mrfelton:chore/remove-unused-deps into 01c467c17cb4793c4b85f7b0d2e2b45e4b5a107a on LN-Zap:next.


License?

What license is this released under?  Could you include a LICENSE file with the code?

Added BSD style license: https://github.com/SocialExplorer/FastDBF/blob/master/LICENSE
Does this work for you?


Add the shark compile downstream due to https://github.com/pytorch/py…

…torch/pull/104185#issuecomment-1615110613
The registration can be done downstream and can be maintained there.

@powderluv Due to https://github.com/pytorch/pytorch/pull/104185#issuecomment-1615110613 I have added the registration downstream.


Moved from IPC to RPC

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/ThunderClientLibraries/89/rdkcentral/ThunderClientLibraries

Commit: 108f0e17ee41fbc0505891b93ab2f3f33d9a002b

Report detail: gist

Copyright scan failure
Commit: 8a70164f55a390d41b8b776445a2d95b5ab92518
Report detail: https://gist.github.com/1e083605136c095a020e57ffaa34a951

Copyright scan failure
Commit: c72738266593c18e8a83d5210fb7bc9971e11757
Report detail: https://gist.github.com/16cd6096d9057163aa3f3a2cbe94a30c


Internationalization (i18n)

The software is internationalized, so if you know any other language than Portuguese or English add a new string bundle in  resources/bundles.
If you don't know how internationalization works in java, click here.
Feel free to improve translations too.

Hi, can I add the spanish translation?

Hi, can I add the spanish translation?
Yes, of course :D

Done! Please tell me if I missed something :D

I can add it for German and French

I can add it for German and French

That would be really nice!

Hi, I can add Romanian translations :)

#48 added for the de, fr translations

I can do for Russian and Estonian

I can do it for Telugu which is one of the Indian languages

@pedrogneri I can do it for Hindi.

@pedrogneri, I have raised a pull request.

#57 Created translations for Tamil language

Let me add for turkish :)

Let me add for turkish :)

https://github.com/pedrogneri/gereco/pull/70

I can do Hungarian translation :)

I can do Hungarian translation :)

#76 :)


CapabilityTagSet added

Rick, Alina: is this in line with your requirements?
Rick: note that I did not incorporate phenomenon/position in this tag structure, rather, I extended the existing generic properties on capability.

Note: this is possibly incomplete, I lifted the design from the Willow models, but as I recall some additional tags were needed, for, e.g., markers, stage, etc.

Hi,
I will look at the open matters later tonight CET or tomorrow:

Re. phenomenon and position: suggest these stay on Capability for the time being, to reduce upstream OWL model impact. Would that be acceptable?
I will remove capability prefix on the tag properties.
Re. the externalIds thing, @alinamstanciu, that seems orthogonal to this PR. For which relationships in the ontology should this be a thing? Surely not ALL of them? But if a subset, then which?
Will copy stage/effective/demand from Willow models
Custom (user defined) marker tags: adds a bit of complexity to translation code. Could we push this forward until there is a verified need?

Karl

Hi Karl,
I feel pretty strongly that phenomenon and position belong with the others. If they are treated differently, this will be very difficult to explain.
Agree with all of your other replies.

OK, I'll check position/phenomenon w/ upstream REC colleagues and see what I can get everyone on board with. In the interim proceeding with the other choices.
Could I ask for some descriptive texts for the tag properties, e.g., "demand", "effective", etc.? A sentence for each of these new properties would be sufficient. To be used w/ rdfs:comment and DTDL description tags, respectively? I think it would be useful for clarifying their intended usage to some categories of users.

effective: Current control setpoint in effect taking into account other factors (Project Haystack)
demand: Rate required for a process. For a setpoint, this sets the required rate for a process such as cooling, heating, air flow, or water flow. For a sensor, this measures the rate of a process over a given interval such as electrical power demand or cooling energy demand.
stage: Stage number of a control loop for an equipment, equipment group, or system that is defined by the process controller. The first stage is 1, second stage 2, etc. (Project Haystack)
assetComponent: The component that is part of an asset which the capability is associated with.
hvacMode: Operational mode for HVAC equipment (Project Haystack)
occupancyMode: Mode which defines how to control a space based on occupancy status
electricalPhase: Phase measurement in a three-phase electrical system (Project Haystack)
limit: Parameter that places and upper (maximum) or lower (minimum) bound on permitted values of another capability.

@hammar  and @rszcodronski , could we please close on this, we are behind with this delivery? Thanks a lot!

@hammar and @rszcodronski , could we please close on this, we are behind with this delivery? Thanks a lot!

If I don’t hear back from Erik/Per on this by Monday I’ll proceed w/ moving phenomenon/placement as suggested by Rick (Friday is a public holiday and Thursday is a de-facto holiday for many/most white collar workers).
Beside that, all that is missing is to add the comments that Rick provided (thanks!) and to get clarification on your comment re. the assetComponent tag property (did you oppose this?) and the external IDs (the latter could be punted).

@alinamstanciu - I think your "i would say no comment" on assetComponent was an error? I assume we are keeping this.

@alinamstanciu - I think your "i would say no comment" on assetComponent was an error? I assume we are keeping this.

No, it wasn't an error, I was responding to your comment on having "capability" as a prefix which is not desired.
@rszcodronski , could you please send Karl the latest definitions so we can include them here or are we doing a new PR for that?
In order to create a new version 1.1, we need to have definitions which I've done 80%, Rick you were supposed to finish them.
Thanks

Ok, yes I think we are all saying the same thing in different ways:

Karl has removed the "capability" prefix on all of these tag properties.
All of the tags properties that were in the original commit will remain
Pending Idun feedback, phenomenon and position will move into the tags to sit alongside the other tags.

@alina - Let's get this PR merged and then we can do the dtmi descriptions. I started but have not been able to finish.

Ok, yes I think we are all saying the same thing in different ways:

Karl has removed the "capability" prefix on all of these tag properties.
All of the tags properties that were in the original commit will remain
Pending Idun feedback, phenomenon and position will move into the tags to sit alongside the other tags.

@alina - Let's get this PR merged and then we can do the dtmi descriptions. I started but have not been able to finish.

I got go-ahead from REC-OWL and will proceed with all of this on Sunday or early Monday CEST. Now time for the traditional Midsummer celebrations. Have a great weekend!


Fixed invalid attempt to destructure non iterable

this could sometimes affect interpage communication

Coverage decreased (-0.05%) to 79.274% when pulling 52ad693d8d4aaf49649c6151ff5bcdd2ed5a99cb on vxsx:bugfix/invalid-attempt-to-destructure-non-iterable into b5e344f9ed8b142c99754d627472a76a6c395f0b on divio:develop.


Issue #635: remove unused controltypes from common_controls module

This pull request introduces 1 alert when merging 87286a46f176ae066def8069023e684bfba29ae9 into b00af57da4e0f748f2bd71b514c27928363245aa - view on LGTM.com
new alerts:

1 for Unused import

Comment posted by LGTM.com


testing issue

![uploads/6f12f142-510b-4b1a-865d-1b2c4bde071b/ljtax.png](https://s3-us-west-2.amazonaws.com/prod.huboard.com/uploads%2F6f12f142-510b-4b1a-865d-1b2c4bde071b%2Fljtax.png

testng synch

testing image once again


Dense feature extraction

Great Work!
I am hoping to use dinov2 to get pixel level dense feature extraction. I believe I should be doing this using the tutorial here
I realize that the images are automatically resized to be 256x256. I am thinking of bilinear interpolation to retrieve a dense pixel level feature extraction. However, I was wondering if it will be better to not resize as much so that there are less degradation due to the interpolation. Should I try to prevent the image reshaping in the postprocessing by changing the AutoImageProcessor parameters? Any suggestions as to how I can get the best dense features without losing detail from interpolation? Thank you!!

@qasfb I see, that makes a lot of sense. Do you know if this will affect model results? I suppose the model was trained on cropped square images. If I want to extract dense features for non-cropped rectangular frames, I am thinking this might not be ideal? Just curious if anyone has any thoughts on this!!

the model is expected to behave well up to at lease resolution 518x518. Rectangular might be a bit more touchy depending on the aspect ratio but you should give it a try, or maybe try a windowed approach. Only experiments will tell !

Sharing with you how I handled it. When extracting remote sensing image features, I found that when the input image is not larger than 2072x2072, the model still gets good features after direct input to the network and positional coded interpolation, and after further increasing the input, I feel that the effect becomes worse after feature clustering. I use the sliding window approach, the window size is 518, each slide 259, the overlap part of the average of the feature values, to extract the feature map of any size image. I refer to the mmsegmentation sliding window test code. Currently mmsegmentation supports dinov2, feature extraction is easy to implement.

Thank you very much! I really appreciate it. : )


Ignore missing dependencies in browserify build

This was the problem with pngjs when node-zlib-backport was unavailable.

Thanks! Merged and will be in the next release.


Operations for SPC aggregation and subdivision

Hello!
Firstly thanks a lot for creating this super-useful framework.
I am trying to downsample/upsample a given spc via aggregation/subdivision (fixed window size: 2x2x2), but I am unable to find this functionality out-of-the box in the framework. The conv3d and transpose_conv3d operations achieve part of what I am trying to do by aggregating and upsampling features of a predefined spc. However upsampling beyond the current max_level of the spc errors in Level + jump must be lower or equal than the depth of the octree.
How can we subdivide the spc with all_occupied_leaves in the next_heirarchy and then prune based on some feature->occupancy function.
Would appreciate some help on this issue.
Cheers!
@akanimax

Hi,
Glad to hear you are finding the framework useful. I think I know what you want, but not quite sure what you want the API to look like. If you could provide more context and a code sample that would be helpful.
In the mean time, I think the following may be helpful:
def subdivide(points_in):
    #create level 1 (2x2x2) grid
    mort = torch.arange(8, dtype=torch.long, device='cuda')
    pts0 = kaolin.ops.spc.morton_to_points(mort).reshape(-1)
    #double input grid, add level 1 grid
    pts1 = (2*points_in).repeat(1, 8)
    return (pts1 + pts0).reshape(-1,3)

This takes as input a morton ordered tensor of points (voxels) of shape (3xN int16) and returns the corresponding tensor of 8 to 1 subdivided voxels of shape (3x(8*n)). For a given Spc, you would need to input the points from some level of the point hierarchy
subdiv_points = subdivide(point_hierarchies[pyramids[0,1,level]:pyramids[0,1,level+1]])
You could then create the octree for this by
subdiv_octree = kaolin.ops.spc.unbatched_points_octree(subdiv_points)
Admittedly, this is somewhat low level but I think close to what you want. LMK if you have thoughts for a higher level API, or if I'm way off the mark.
Good luck!

@charlesloop,
Thanks a lot for this code snippet, this is exactly what I was trying to achieve for the subdivision part. Regarding a higher-level API, I was thinking something like this:
kaolin.ops.spc.subdivide(spc: SPC, mode:str = "random_zeros", subdiv_indices:Optional[Tensor]= None) -> SPC
Where, the SPC can have a batch > 1 and the subdivision routine will loop over all the points in the SPC batchwise to perform the subdivision. The mode  can be one of three:

"random_zeros" puts the feature randomly in one of the 8 cells in the next hierarchy.
"zeros" puts the features at the subdiv_indices for the next level of hierarchy (rest locations being zeros). The subdiv_indices can be provided by the aggregator op similar to pooling and unpooling operations in 2D.
"nearest" copies the feature for all cells 8 times in the next hierarchy.

Nevertheless, thanks a lot for your help.
Cheers!
@akanimax

Thanks again for your help with this.
Cheers!


#512 add metainfo for lambda plugin

add function name in metainfo

:+1:

:+1:

Codecov Report

Merging #518 into master will decrease coverage by <.01%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master     #518      +/-   ##
============================================
- Coverage     55.13%   55.12%   -0.01%
- Complexity      528      529       +1
============================================
  Files           136      136
  Lines          3087     3091       +4
  Branches        208      208
============================================
+ Hits           1702     1704       +2
- Misses         1303     1305       +2
  Partials         82       82

Impacted Files
Coverage Δ
Complexity Δ

...ndo/stups/fullstop/plugin/lambda/LambdaPlugin.java
74.28% <71.42%> (-3.14%)
7 <3> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49af67...ea12e57. Read the comment docs.


Protect functions not to be accessed by user

What does this PR do?
Addresses this comment, related to #4193, cc @Borda
PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Seems there was an unrelated error in the doc tests regarding github actions, will merge and see if this persists...


WIP eden Virtual Box support

Signed-off-by: Ruslan Dautov<EMAIL_ADDRESS>

Hi, @dautovri. Please, make rebase onto upstream (git fetch upstream;git rebase upstream/master).
Also, you need to sync comments and code inside vbox.go (the first word in comment must match the variable name).

Hi, @dautovri. Please, make rebase onto upstream (git fetch upstream;git rebase upstream/master).
Also, you need to sync comments and code inside vbox.go (the first word in comment must match the variable name).

Please update README

Please update README


RD2: Swap the Installment Period & Frequency fields on the unpackaged page layout

Critical Changes
Changes

In Enhanced Recurring Donations, swap the Installment Period and Installment Frequency fields on the page layout.

Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

**lurch: attach W-039424

Tracking W-039424


Fix comments formatting in function definitions; squiggle parse CLI command

Fixes #708. Fixes #1805.

Codecov Report

Merging #1806 (2a764d9) into develop (20b8ba3) will decrease coverage by 0.08%.
The diff coverage is n/a.

:exclamation: Current head 2a764d9 differs from pull request most recent head d0a481e. Consider uploading reports for the commit d0a481e to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop    #1806      +/-   ##
===========================================
- Coverage    70.56%   70.49%   -0.08%
===========================================
  Files           98       98
  Lines         4906     4918      +12
  Branches       933      935       +2
===========================================
+ Hits          3462     3467       +5
- Misses        1418     1425       +7
  Partials        26       26

see 1 file with indirect coverage changes


Store all the sample events in a Graph structure

#15
The Hermes Profile consists of three properties (in the JSON Object Notation) in it's profile, namely:

traceEvents
samples
stackFrames

The idea of the Graph is to isolate the events with the same stack number (events here correspond to fields in the samples array and the corresponding element in the stackFrame refers to the stackFrame corresponding to the sf property of the event under consideration)
Each node of the graph can be uniquely identified by its id property, which is the stackFrame number. The nodes additionally have an events array (which contains all the events from the samples array where event.sf === node.id), and a children property (which consists of all the nodes/stackFrames which have listed the stackFrame with node.id as their parent).
We do this in a two fold way for each process, namely

Uniquely creating all the nodes in this data structure
Populating the locations property of each node's events (where event.sf === node.id)

The samples are exactly what they sound like, they are sampled regularly at different time stamps, now to get the duration of each event, we can get the first and last timestamp, equivalently converting all our events to complete events.
Complete events is a better event type to follow than duration events, eliminate the hassle to find end events, can simply update duration


Updates to extension based on team feedback

WIP

https://linear.app/unstoppable-domains/issue/UDM-160/force-remember-me-option-when-using-the-extension
https://linear.app/unstoppable-domains/issue/UDM-162/add-password-reveal-for-the-recovery-kit-password

/gcbrun


Simplify error handling and restructure runner.rs

The Miri (spec) job experienced a time-out despite the recent increase in time.


use crypto directly inside deku

Problem
we use Tezos_interop address types for plain ed25519 types.
Edit:
Address.t and wallet.t are represented as ed25519 internally, but use tezos_interop module, which only had ed25519 previously, now that we will have support for tz2 and tz3 it will introduce redundant pattern matching into those modules and modules that call functions defined there.
Solution
use ed25519 directly
Related

#22

This seems like a regression to me, why would we use Ed25519 directly? Please write a better description for the problem.

Updated


Document federation version endpoint

Signed-off-by: Max Dor @ Kamax.io

looks good, thanks

This was added to synapse in https://github.com/matrix-org/synapse/pull/990, fwiw


Multiple files support for foresight intercept

It's nice to have multiple files support, I don't know why would someone need it, but it's simple enough to support it, so why not!

foresight intercept /dev/input/event1 /dev/input/event2 now works.


Jitter when entering tags in IE11

Using ngTagsInput on IE11, the text "jitters" when entering a tag into the control.  By that I mean that the text shakes around a bit as I type, making it hard to read.  This is a significant concern for our team, as it negatively affects the user experience, and given our customer base consists of enterprise users, IE11 is necessarily a prime browser for us to support.
I've seen this on both my code and on the control demo site, though the demo site is currently not showing it due to a JS error.
A previous issue covered this problem but was closed by the originator after a week with no action or comment, so I'm creating a new issue to cover it.

I'm experiencing the same jittery behavior while using this component in a large-scale web app. What is the ETA for resolving this issue?

I know a workaround. It minimises the jittering. In your tags-input just add this spellcheck ="false" attribute. So what it does is it does not do the spell check and the jitter is reduce to more than 80 percent. Just try and see if it works.

I tried adding the spellcheck ="false" attribute and it did reduce the jittery effect by a lot. I'm only seeing the jittery effect when I enter space. That is very odd. Is there other ways that we could further reduce the effect?

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.

@mayankkalbhor
Thank you so much. I just tried spellcheck ="false" attribute and it works like charm.


AC of party members were +4

For example, AC of #4-6 members members were 14 instead of 10.  I don't know how this happened.  Maybe ran from a battle when party AC was +4 temporarily??

Fixed to add temporary acplus instead of permanent ac for 'kyofu' and 'kanashibari'.  Will be in the next push.


Add example notebook for training and inference on Sagemaker

This PR adds an example notebook that demonstrates how to use Merlin container for training and inference on the AWS Sagemaker platform. It can be roughly split into three sections:

Test the training script locally to make sure that the script runs as expected,
Train the model on Sagemaker by calling sagemaker.Estimator.fit(entry_point='train.py'), and
Create an endpoint with Triton, and test it by sending a request.

Note:

The notebook builds a custom image (built from merlin-tensorflow image) and uploads it to ECR. This step can be simplified/removed by installing the sagemaker-training library directly in the Merlin image, so I opened a separate PR: https://github.com/NVIDIA-Merlin/Merlin/pull/707.

Steps for testing (NV-specific):

Ask Ben to give you access to the AWS account. After he adds to you to the group, wait a couple of hours for permissions to propagate.
If permissions have propagated, you will see AWS NVIDIA Account on https://myapps.microsoft.com/. This can be used to access the console.
Install aws-azure-login and run aws-azure-login --mode=gui to authenticate. This will create the credientials in $HOME/.aws. More details here: https://gitlab-master.nvidia.com/kaizen-efficiency/wiki/-/wikis/Guides/aws-cli-sso
As described in README, add -v $HOME/.aws:/root/.aws to your usual docker run command.

@edknv is there a manual or readme file that a user can follow (step-by-step instructions) when running the notebook based on the code you shared? Thanks...

@edknv is there a manual or readme file that a user can follow (step-by-step instructions) when running the notebook based on the code you shared? Thanks...

@bbozkaya I added a README and wrote down some steps in the PR description. Hope that helps.


AttributeError: 'tuple' object has no attribute 'shape'

I am using wsl Ubuntu 22.04.4 LTS and I am facing this problem:
The config attributes {'center_input_sample': False, 'out_channels': 4} were passed to UNet2DConditionModel, but are not expected and will be ignored. Please verify your config.json configuration file.
Some weights of the model checkpoint were not used when initializing UNet2DConditionModel:
 ['conv_norm_out.bias, conv_norm_out.weight, conv_out.bias, conv_out.weight']
INFO:hallo.models.unet_3d:loaded temporal unet's pretrained weights from pretrained_models/stable-diffusion-v1-5/unet ...
The config attributes {'center_input_sample': False} were passed to UNet3DConditionModel, but are not expected and will be ignored. Please verify your config.json configuration file.
Load motion module params from pretrained_models/motion_module/mm_sd_v15_v2.ckpt
INFO:hallo.models.unet_3d:Loaded 453.20928M-parameter motion module
loaded weight from  ./pretrained_models/hallo/net.pth
Traceback (most recent call last):
  File "/mnt/s/aiprograms/hallo-1.0.0/scripts/inference.py", line 424, in <module>
    inference_process(
  File "/mnt/s/aiprograms/hallo-1.0.0/scripts/inference.py", line 300, in inference_process
    audio_emb = process_audio_emb(audio_emb)
  File "/mnt/s/aiprograms/hallo-1.0.0/scripts/inference.py", line 109, in process_audio_emb
    for i in range(audio_emb.shape[0]):
AttributeError: 'tuple' object has no attribute 'shape'

also I've got the same problem on anaconda env in windows aswell.

Please recheck the usability of the driving audio. If you find no issues with the audio, please upload more runtime logs.

Hi! Thank you for respond. Actually there is no problem with audio at all. I did generated videos with this audio before I reinstalled the env. Also with different audio I get the same error. I managed to fix it by downloading the hallo-windows portable version and I replaced the site-packages in my env with the one in the hallo-win-portable zip file. After that I reinstalled the pytorch and onnxruntime and it worked. So I assume it has to do something with the packages in my env, some newer packages doesn't work with hallo. I couldn't find which one are causing this. I want to add that I used "requirements.txt" to install all of necessary dependencies but still it installed something in different version that doesn't work with hallo script.
Do you need full log of it? I can still provide it with wsl because I didn't fix it there...

I am having the same issue, running with LightingAi on Ubuntu. Is the portable version only available for Windows? I wonder if I could use a similar solution in Ubuntu.


Add support for uploading arbitrary artifacts to wheel workflows

Similarly to #51, this PR adds support for uploading arbitrary artifacts for wheel workflows.

@ajschmidt8 now that it is working can we merge this PR?

@ajschmidt8 now that it is working can we merge this PR?

@galipremsagar, done. I will delete the feature branch. Can you update your PR accordingly?


icons are overlapped in comparison page for RTL

Bug report
Title
icons are overlapped in comparison page for RTL
Issue Description
icons are overlapped in comparison page for RTL
Preconditions
Please provide as detailed information about your environment as possible.
1. framework Version- 1.1.0

Steps to reproduce
1. step1- add items in compare list
2. step2- go to comparison page in RTL

Expected result
icons should n't overlapped
Actual result

fixed


prevent rbenv segment from spamming errors

rbenv local returns non-zero return code, as well as prints rbenv: no local version configured for this directory for directories which do not have rbenv configuration.
Including rbenv in segments caused this error message to be printed each time PS1 was evaluated. This change prevents rbenv local stderr from being printed out.

I guess this project is abandoned, I've switched to powerlevel10k instead.


Tdunn/20160920 snippets

Added snippet tags to sample code.
@ldanzinger - Please review and merge. Thank you.

looks good


PlayerHater is not loaded yet or has been shut down

Steps to reproduce:

Set the PlayerHater to start in onResume() and to release in onPause();

In a button click event, call play() on a Song being streamed from the web (I haven't tested with any other data source);

Press back button just after the notification ticker slides in.

It doesn't happen every time, but i's fairly easy to reproduce. Digging through the source code I could notice that this happens because the plugin tries to start the player service:
getBinder().startForeground(NOTIFICATION_NU, getNotification());

In the code above, getBinder() tries to access a reference to the PlayerHater instance, which has been destroyed, since the Activity has run onPause() when back was pressed.
Stack trace:
java.lang.IllegalStateException: PlayerHater is not loaded yet or has been shut down.
        at org.prx.playerhater.plugins.AbstractPlugin.getPlayerHater(AbstractPlugin.java:157)
        at org.prx.playerhater.plugins.NotificationPlugin.getBinder(NotificationPlugin.java:138)
        at org.prx.playerhater.plugins.NotificationPlugin.onChangesComplete(NotificationPlugin.java:124)
        at org.prx.playerhater.plugins.PluginCollection.onChangesComplete(PluginCollection.java:299)
        at org.prx.playerhater.plugins.BackgroundedPlugin.handleMessage(BackgroundedPlugin.java:361)
        at org.prx.playerhater.plugins.BackgroundedPlugin$HandlerPair.handleMessage(BackgroundedPlugin.java:504)
        at org.prx.playerhater.plugins.BackgroundedPlugin$HandlerPair$OtherHandler.handleMessage(BackgroundedPlugin.java:519)
        at android.os.Handler.dispatchMessage(Handler.java:102)
        at android.os.Looper.loop(Looper.java:137)
        at android.app.ActivityThread.main(ActivityThread.java:5062)
        at java.lang.reflect.Method.invokeNative(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:515)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
        at dalvik.system.NativeStart.main(Native Method)

Interesting - I think I know how to address this and will give it a shot.


Background GUI process can not receive mouse event

Your Windows build number:  (Type ver at a Windows Command Prompt)

Microsoft Windows [版本 10.0.19631.1]

And I'm using WSL2 Ubuntu 20.04, with VcXsrv <IP_ADDRESS> (7 Apr 2020)

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

run xeyes or some other GUI application.
move mouse, and confirm that the xeyes works well (the eyes follows our mouse)
press ctrl+z to switch it to background
move mouse, and confirm that the xeyes not works  (the eyes doesn't follow our mouse)

What's wrong / what should be happening instead:

The xeyes works (the eyes follows our mouse) when the process is running in background.

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

https://gist.github.com/luochen1990/cb704cf46b524c33ca4c66d3b49e5ec5

Ctrl+Z suspends a process. You need to run bg to resume it in the background. I did not see this in your reproduction steps.


Import/Include path

Im having an issue where i import a file using import "somefile.proto";
In protoc i can provide the -I someincludedir to tell it where it can look for imports, but CodeGenerator does not have this.

This should be quite easy to add.

I've had a quick jab at this feature on my fork, but the issue is a bit less trivial then though.
As you are generating code for the imported message class.
Say i have a Info message which i import in 2 different proto files, then i run the code generator twice to create the files for these 2 messages.
Both generated files will now have a partial class of Info, causing the compiler to complain.

Can you run the code generator only once?
Try give both proto files as argument.

I can try in a bit.
In my case both proto files are in different directories and packages, so generating this list before running CodeGenerator.exe instead of my current for loop will be much more work (on windows).

I see it's not so easy.
It looks like we also need a way import without generating code for the imported files.
It's doable.
My only concern is that using the tool like this put a lot of responsibility on the user to call the tool on every imported .proto.

Let me know how this works.

+1


QuestHelper / LevelingGuide missing

It's just not implemented, the Files are there (UI: ka_levelguide_us, Datatable: tbl_help_us).
There's no interaction with the server. This is a client-side feature.

[ ] Load and show the UI from the "Q" Button (defined in UIStateBar)
[ ] on search-press, filter the datatable according to the level and update the UI with the info
[ ] make paging work

Should the Q-Button be hidden if the client can't load the UI or the help-table?

Should the Q-Button be hidden if the client can't load the UI or the help-table?
No, because that case is exceptional. Those cases won't (or shouldn't) happen when it's implemented and such behaviour is implemented. No real reason to (temporarily?) hide it.


Is resource usage being monitored?

Context
Last December we had an unauthorized access incident with the Openscapes hub and I was wondering if there are alerts in place in case one of our users gets hacked and starts mining bitcoin (hypothetical). A little related to this, it would be neat if in the admin dashboard we could see the instance type each user is running and maybe this already exist but another thing it would be nice is a weekly/monthly report on usage statistics like CPU/memory/network (inbound/egress) per user.
Proposal
No response
Updates and actions
No response

Hey @betolink! Yes we keep a look out, and we are also implementing more active alerts now (see https://github.com/2i2c-org/infrastructure/issues/1804). Sorry we missed this issue - we're mostly looking for support questions and what not from<EMAIL_ADDRESS>Perhaps we can give you access to the grafana instance for openscapes and that would help?

Perhaps we can give you access to the grafana instance for openscapes and that would help?

I've just given access to @betolink (https://grafana.openscapes.2i2c.cloud).

@consideRatio maybe a dummy question but.. how do I login or set my password for the first time?

@consideRatio maybe a dummy question but.. how do I login or set my password for the first time? (since there is no "sign with Github" button)

Arrrgh sorry, the state got reset. @yuvipanda do you have time to consider #2178 which includes the openscape changes and more?

@consideRatio approved

@betolink @yuvipanda merged
I think in 10 minutes, it should work again @betolink !

This is weird, the OAuth redirect didn't work for some reason. @consideRatio

Yep, I thought it was linked to my Github user and I just noticed it needs the Openscapes read access, since I'm not an admin there I just requested it. Thanks @consideRatio !!

@betolink ah so the organization must allow the GitHub OAuth application to read whom are members so it can determine if you are part of it. I was thinking it was you that would grant the GitHub OAuth application permission to know if you are part of the organization.
Thank you @betolink for figuring this out and helping me understand this part as well!

@consideRatio great news! I can access the dashboard but I don't think I'm an admin so I can't add more users, would it be possible to add @BriannaLind and @amfriesz
Thanks!

@betolink from user activity in the grafana instance, I see that this seems resolved on your end - presumably by adding @BriannaLind and @amfriesz to the nasa-openscapes organization?
Thanks for sorting it out yourself! For anything further, please refer to https://docs.2i2c.org/en/latest/support.html.


When I use ⌘+SHIFT+4 to do a screenie of a window on Mac OS, the Pade Phone appears

Pade keyboard short cuts are clashing with Mac OS system shortcuts. Change the default keys to use ⌘+SHIFT 6,7,8&9 instead of 1,2,3&4

Fixed in version 0.5.4


Fix #208 and #209

When we migrated to get_/set_annotations in #202, we had to handle converting the result to an R list ourselves since that is no longer returned automatically as with getAnnotations. This wasn't clearly realized since there was a missing test that would have revealed this. For now, I updated copy_annotations to handle downstream usage in derive_annotations that was affected.
Reran the non-working code in https://github.com/nf-osi/nfportalutils/issues/209#issue-2743368378 and manifests were generated (thanks for the clear doc in issue and checking different versions).
Update: should no longer need to manually modify sample names with
o$Strelka2 <- o$Strelka2 %>%    dplyr::mutate(sample = stringr::str_remove(sample, "_vs_.+"))

Thanks!! This worked great - approved!


Fullcalendar 3.3.1

Thank you @basitshaikh! Version 3.4.0 was just uploaded - do you specifically need 3.3.1 (then I'd merge and push this version as well) or can you use 3.4.0?

I'll close this issue in favor of version 3.4.0 then. Please let me know if that doesn't work for you!


[5.1] SwiftSyntax Parser: expose parser diagnostics via C API.

This allows SwiftSyntax to listen to emitted diagnostics during
parsing.
rdar://48439271

@swift-ci please test


New package: BackedUpImmutable v0.1.1

Registering package: BackedUpImmutable
Repository: https://github.com/wherrera10/BackedUpImmutable.jl
Created by: @wherrera10
Version: v0.1.1
Commit: 63a0b3406f5d2d5c7d43d11f31356293b6fd982e
Reviewed by: @wherrera10
Reference: https://github.com/wherrera10/BackedUpImmutable.jl/commit/63a0b3406f5d2d5c7d43d11f31356293b6fd982e#commitcomment-34075106

Please add (at least)
[compat]
julia = "1"

to your project file and retrigger the bot.

Bump.


Images are not displayed properly

SUMMARY
Thorium Reader v1.1.1 does not display images properly (when the image does not fit the window), cropping part of the image.
STEPS TO REPRODUCE

Open a light novel EPUB file.
Adjusting the settings does not help.

OBSERVED RESULT

EXPECTED RESULT
(Readium Chrome app is being used in the below screenshot.)

OTHER INFORMATION
OS: Linux
EPUB used in the above examples: 痛いのは嫌なので防御力に極振りしたいと思います。８ (Wikipedia article)

Thank you for the bug report!
Are you able to share the EPUB (privately, with Thorium devs), so we can test/debug at our end?

@danielweck
Okay.
Is this Keybase account yours? Can I send you the file through Keybase?

Yes, that's me on KeyBase. Thank you!

Using r2-testapp-js (which is based on the same rendering/layout engine as Thorium / readium-desktop), the initial image / chapter looks weird:

Actually, all images look "corrupted", and it varies from time to time, for example I also get the following:

Note that RTL (Right To Left) + VWM (Vertical Writing Mode) text rendering "works", but page/CSS-column navigation is broken, see:
https://github.com/readium/r2-navigator-js/issues/42

The issue of corrupted images was fixed via https://github.com/readium/readium-desktop/commit/f1251186bd99cd7f9c6bca5fe9f3563f548a9d31

Image resizing is a broader issue that is discussed in ReadiumCSS (object-fit: contain and other authoring practices to prevent image breaking across page boundaries)

Thanks!
Where can I track the image resizing discussion? readium/readium-css/55 seems to be related but it has been closed.

(BTW Is 1.2.0 released? I see the tag here but it has no summary or installation files.)

Official release (version 1.2.1):
https://github.com/readium/readium-desktop/releases/tag/v1.2.0
Latest builds:
https://github.com/readium/readium-desktop/releases

Where can I track the image resizing discussion? readium/readium-css/55 seems to be related but it has been closed.

I wonder if this is related to https://github.com/readium/readium-css/issues/50 ?


Release Version 2.2.0

This is a component issue for 2.2.0.
Coming from opensearch-build#2271. Please follow the following checklist.
Please refer to the DATES in that post.
How to use this issue

This Component Release Issue
This issue captures the state of the OpenSearch release, on component/plugin level; its assignee is responsible for driving the release. Please contact them or @mention them on this issue for help.
Any release related work can be linked to this issue or added as comments to create visiblity into the release status.
Release Steps
There are several steps to the release process; these steps are completed as the whole component release and components that are behind present risk to the release. The component owner resolves the tasks in this issue and communicate with the overall release owner to make sure each component are moving along as expected.
Steps have completion dates for coordinating efforts between the components of a release; components can start as soon as they are ready far in advance of a future release. The most current set of dates is on the overall release issue linked at the top of this issue.
The Overall Release Issue
Linked at the top of this issue, the overall release issue captures the state of the entire OpenSearch release including references to this issue, the release owner which is the assignee is responsible for communicating the release status broadly.  Please contact them or @mention them on that issue for help.
What should I do if my plugin isn't making any changes?
If including changes in this release, increment the version on 2.0 branch to 2.2.0 for Min/Core, and <IP_ADDRESS> for components. Otherwise, keep the version number unchanged for both.

Preparation

[x] Assign this issue to a release owner.
[x] Finalize scope and feature set and update the Public Roadmap.
[x] All the tasks in this issue have been reviewed by the release owner.
[x] Create, update, triage and label all features and issues targeted for this release with v2.2.0.
[x] Cut 2.2 branch

CI/CD

[x] All code changes for 2.2.0 are complete.
[x] Ensure working and passing CI.
[x] Check that this repo is included in the distribution manifest.

Pre-Release

[x] Update to the 2.2.0 release branch in the distribution manifest.
[ ] Increment the version on the parent branch to the next development iteration.
[x] Gather, review and publish release notes following the rules and back port it to the release branch.git-release-notes may be used to generate release notes from your commit history.
[x] Confirm that all changes for 2.2.0 have been merged.
[ ] Add this repo to the manifest for the next developer iteration.

Release Testing

[x] Find/fix bugs using latest tarball and docker image provided in parent release issue and update the release notes if necessary.
[ ] Code Complete: Test within the distribution, ensuring integration, backwards compatibility, and performance tests pass.
[ ] Sanity Testing: Sanity testing and fixing of critical issues found.
[ ] File issues for all intermittent test failures.

Release

[ ] Complete documentation.
[ ] Verify all issued labeled for this release are closed or labelled for the next release.

Post Release

[ ] Prepare for an eventual security fix development iteration by incrementing the version on the release branch to the next eventual patch version.
[ ] Add this repo to the manifest of the next eventual security patch version.
[ ] Suggest improvements to this template.
[ ] Conduct a retrospective, and publish its results.

Executed benchmark script part of k-NN perf-tool with nmslib-sift-hnsw/test.yml:
python knn-perf-tool.py test /home/ec2-user/k-NN/benchmarks/perf-tool/sample-configs/nmslib-sift-hnsw/test.yml output.json

Results
INFO:root:Finished running tests.
{
  "metadata": {
    "test_name": "nmslib_sift_hnsw",
    "test_id": "Test workflow for nmslib hnsw",
    "date": "08/10/2022 23:27:33",
    "python_version": "3.8.13 (default, Mar 28 2022, 11:38:47) \n[GCC 7.5.0]",
    "os_version": "Linux-5.10.130-118.517.amzn2.x86_64-x86_64-with-glibc2.17",
    "processor": "x86_64, 36 cores",
    "memory": "737492992 (used) /<PHONE_NUMBER>4 (available) /<PHONE_NUMBER>8 (total)"
  },
  "results": {
    "test_took": 1781505.458917499,
    "create_index_took_total":<PHONE_NUMBER>0076406,
    "ingest_took_total": 85910.8443339992,
    "refresh_index_store_kb_total": 1501464.1430664062,
    "refresh_index_took_total": 1615729.6513039982,
    "force_merge_took_total": 4327.72677650064,
    "query_took_total": 75281.0,
    "query_took_p50": 7.5,
    "query_took_p90": 8.5,
    "query_took_p99": 10.0,
    "query_memory_kb_total": 652864.5,
    "query_recall@K_total": 0.9983885,
    "query_recall@1_total": 1.0
  }

Executed benchmark script part of k-NN osb (https://github.com/opensearch-project/k-NN/tree/main/benchmarks/osb):
export PARAMS_FILE=/home/ec2-user/k-NN/benchmarks/osb/params/no-train-params.json
export PROCEDURE=no-train-test
opensearch-benchmark execute_test --target-hosts $URL:$PORT --workload-path ./workload.json --workload-params ${PARAMS_FILE} --test-procedure=${PROCEDURE} --pipeline benchmark-only

[INFO] Executing test with workload [workload], test_procedure [no-train-test] and provision_config_instance [‘external’] with version [2.2.0].
Running delete-target-index                                                    [100% done]
Running create-target-index                                                    [100% done]
Running wait-for-cluster-to-be-green                                           [100% done]
Running custom-vector-bulk                                                     [100% done]
Running refresh-target-index                                                   [100% done]
Running knn-query-from-data-set                                                [100% done]
------------------------------------------------------
    _______             __   _____
   / ____(_)___  ____ _/ /  / ___/_________  ________
  / /_  / / __ \/ __ `/ /   \__ \/ ___/ __ \/ ___/ _ \
 / __/ / / / / / /_/ / /   ___/ / /__/ /_/ / /  /  __/
/_/   /_/_/ /_/\__,_/_/   /____/\___/\____/_/   \___/
------------------------------------------------------
|                                                         Metric |                    Task |       Value |   Unit |
|---------------------------------------------------------------:|------------------------:|------------:|-------:|
|                     Cumulative indexing time of primary shards |                         |     3.95175 |    min |
|             Min cumulative indexing time across primary shards |                         |    0.193517 |    min |
|          Median cumulative indexing time across primary shards |                         |     1.10467 |    min |
|             Max cumulative indexing time across primary shards |                         |     2.65357 |    min |
|            Cumulative indexing throttle time of primary shards |                         |           0 |    min |
|    Min cumulative indexing throttle time across primary shards |                         |           0 |    min |
| Median cumulative indexing throttle time across primary shards |                         |           0 |    min |
|    Max cumulative indexing throttle time across primary shards |                         |           0 |    min |
|                        Cumulative merge time of primary shards |                         |           0 |    min |
|                       Cumulative merge count of primary shards |                         |           0 |        |
|                Min cumulative merge time across primary shards |                         |           0 |    min |
|             Median cumulative merge time across primary shards |                         |           0 |    min |
|                Max cumulative merge time across primary shards |                         |           0 |    min |
|               Cumulative merge throttle time of primary shards |                         |           0 |    min |
|       Min cumulative merge throttle time across primary shards |                         |           0 |    min |
|    Median cumulative merge throttle time across primary shards |                         |           0 |    min |
|       Max cumulative merge throttle time across primary shards |                         |           0 |    min |
|                      Cumulative refresh time of primary shards |                         |     19.3742 |    min |
|                     Cumulative refresh count of primary shards |                         |          34 |        |
|              Min cumulative refresh time across primary shards |                         |     5.59155 |    min |
|           Median cumulative refresh time across primary shards |                         |     6.69072 |    min |
|              Max cumulative refresh time across primary shards |                         |     7.09188 |    min |
|                        Cumulative flush time of primary shards |                         |     2.17767 |    min |
|                       Cumulative flush count of primary shards |                         |           3 |        |
|                Min cumulative flush time across primary shards |                         |     0.00215 |    min |
|             Median cumulative flush time across primary shards |                         |     0.53525 |    min |
|                Max cumulative flush time across primary shards |                         |     1.64027 |    min |
|                                        Total Young Gen GC time |                         |       0.362 |      s |
|                                       Total Young Gen GC count |                         |          21 |        |
|                                          Total Old Gen GC time |                         |           0 |      s |
|                                         Total Old Gen GC count |                         |           0 |        |
|                                                     Store size |                         |     2.87628 |     GB |
|                                                  Translog size |                         | 3.07336e-07 |     GB |
|                                         Heap used for segments |                         |           0 |     MB |
|                                       Heap used for doc values |                         |           0 |     MB |
|                                            Heap used for terms |                         |           0 |     MB |
|                                            Heap used for norms |                         |           0 |     MB |
|                                           Heap used for points |                         |           0 |     MB |
|                                    Heap used for stored fields |                         |           0 |     MB |
|                                                  Segment count |                         |          43 |        |
|                                                 Min Throughput |      custom-vector-bulk |     1889.24 | docs/s |
|                                                Mean Throughput |      custom-vector-bulk |     28058.3 | docs/s |
|                                              Median Throughput |      custom-vector-bulk |     33319.6 | docs/s |
|                                                 Max Throughput |      custom-vector-bulk |     55595.4 | docs/s |
|                                        50th percentile latency |      custom-vector-bulk |     13.1439 |     ms |
|                                        90th percentile latency |      custom-vector-bulk |     18.1077 |     ms |
|                                        99th percentile latency |      custom-vector-bulk |     69.8484 |     ms |
|                                      99.9th percentile latency |      custom-vector-bulk |     11960.3 |     ms |
|                                       100th percentile latency |      custom-vector-bulk |      240019 |     ms |
|                                   50th percentile service time |      custom-vector-bulk |     13.1439 |     ms |
|                                   90th percentile service time |      custom-vector-bulk |     18.1077 |     ms |
|                                   99th percentile service time |      custom-vector-bulk |     69.8484 |     ms |
|                                 99.9th percentile service time |      custom-vector-bulk |     11960.3 |     ms |
|                                  100th percentile service time |      custom-vector-bulk |      240019 |     ms |
|                                                     error rate |      custom-vector-bulk |        0.04 |      % |
|                                       100th percentile latency |    refresh-target-index |      240014 |     ms |
|                                  100th percentile service time |    refresh-target-index |      240014 |     ms |
|                                                     error rate |    refresh-target-index |         100 |      % |
|                                                 Min Throughput | knn-query-from-data-set |        0.01 |  ops/s |
|                                                Mean Throughput | knn-query-from-data-set |       13.04 |  ops/s |
|                                              Median Throughput | knn-query-from-data-set |       12.48 |  ops/s |
|                                                 Max Throughput | knn-query-from-data-set |       30.15 |  ops/s |
|                                        50th percentile latency | knn-query-from-data-set |     12.8036 |     ms |
|                                        90th percentile latency | knn-query-from-data-set |     15.4179 |     ms |
|                                        99th percentile latency | knn-query-from-data-set |     21.7585 |     ms |
|                                      99.9th percentile latency | knn-query-from-data-set |      397.06 |     ms |
|                                     99.99th percentile latency | knn-query-from-data-set |      155948 |     ms |
|                                       100th percentile latency | knn-query-from-data-set |      155950 |     ms |
|                                   50th percentile service time | knn-query-from-data-set |     12.8036 |     ms |
|                                   90th percentile service time | knn-query-from-data-set |     15.4179 |     ms |
|                                   99th percentile service time | knn-query-from-data-set |     21.7585 |     ms |
|                                 99.9th percentile service time | knn-query-from-data-set |      397.06 |     ms |
|                                99.99th percentile service time | knn-query-from-data-set |      155948 |     ms |
|                                  100th percentile service time | knn-query-from-data-set |      155950 |     ms |
|                                                     error rate | knn-query-from-data-set |           0 |      % |
[WARNING] Error rate is 0.04 for operation ‘custom-vector-bulk’. Please check the logs.
[WARNING] Error rate is 100.0 for operation ‘refresh-target-index’. Please check the logs.
[WARNING] No throughput metrics available for [refresh-target-index]. Likely cause: Error rate is 100.0%. Please check the logs.
---------------------------------
[INFO] SUCCESS (took 878 seconds)
---------------------------------


Cluster file generator should produce valid json

This way, if the ${KAFKA_NUM_CONTAINERS} is changed in docker/run_tests.sh, the json is still valid

LGTM. Sorry, I thought I fixed that during commit.


[-] Failed to create printer: Microsoft XPS Document Writer v4

Test on windows 2016 :
why error ?

Windows Server 2019 same problem


[Optimizate] offsetMap incremental build

When the current RIP-30 does compaction, it needs to build an offsetMap. Currently, it needs to scan all message constructions, but in fact, it only needs to scan the last end point to the latest compaction position.

It is necessary to set a certain threshold for the storage of offset in memory, and build a secondary index after arrival

At this time,  base on  CopyAndWriteList, if there is a request to read the offset, it will be refreshed according to the secondary index

FEATURE REQUEST

Please describe the feature you are requesting.

Provide any additional detail on your proposed use case for this feature.

Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task:

sub-task1-issue-number: sub-task1 description here,
sub-task2-issue-number: sub-task2 description here,
...

cc @ltamber @duhengforever


Make app strict TypeScript + linting (and add a shared project)

Sequel to #1223 . Now the whole repo should be strict!

Let me know if there's anything else you'd like done here @ronjouch :)

Letting you merge this before/after https://github.com/nativefier/nativefier/pull/1235 as you want

Tell me if you want a release before you merge this. Right now, the only code commit since strict CLI (44.0.4) is https://github.com/nativefier/nativefier/pull/1229 .

Let's merge 1235, cut a release, merge this, then cut another. As well there's a new Electron 12.

Let's merge 1235, cut a release, merge this, then cut another. As well there's a new Electron 12.

@TheCleric I just released 44.0.5 with the recent tray/zoom/externalurl fixes, and an Electron bump. Letting you rebase & merge this whenever convenient, and I'll cut a release.

Merged!

Merged!

:tada: ! Released as 44.0.6.


On kubernets, Ingress behaves differently when deployed via istioctl (1.5.1)

I have a system which running for about an year, composed of multiple services / virtual services / gateways and ingressgateway components.
Until now I was using a "helm template" deployment method (default profile) - everything was worked as expected.
When released 1.5.1, first I deployed Istio as always using "helm template" method. Everything worked.
Then I noticed a statement that "helm" method deprecated and "istioctl" method should be used instead. I removed everything and redeployed Istio from scratch using "istioctl" (again, used "default" profile). I used exactly the same all my yamls which I used previously. This time, although all pods are up & ready, I was not able to perform any https request from the outside (via ingress gateway). When I was trying to access any of exposed URLs via Chrome, I getting "unexpectedly closed the connection" error.
Performing same call via curl gets me:
curl: (35) schannel: failed to receive handshake, SSL/TLS connection failed
I removed everything again and redeployed again using "helm template" method (same istio version, same system yamls) - everything works back again.
So, despite same Istio version (1.5.1) and despite that all deployment yamls are exactly the same - there is a difference in deployed Istio using "helm" (which deploys old style multipod deployment) and Istio deployed using "istioctl" method (which deploys new style "istiod" pod).
I checked everything I could, everything looks well - but yet there is an issue with ingress. Inside mesh, communication between pods works as expected (I have a sidecar injected in each of my pods). Accessing system from the outside via NodePort works as well.
Looks like the issue isolated to Ingress only.
Any idea? What could be the difference? Where I should look for troubleshooting this?
P.S. Maybe somehow helpful: this is my development environment, and I using a self signed certificate which expires at 19/04/2029 (exactly 9 years from today). Is it coincidence or maybe self signed certificates treated differently in new istiod deployment? Maybe there is a hard 1 year limit for certificate duration which ignores an actual valid period? I really lost here..
Kubernetes 1.18 on local Microk8s, Ubuntu 18.04, Istio 1.5.1

I figured it out.
When ingress deployed via helm, its TLS port is 31390, however when it deployed via istiod its port is 31360...

I think you should update documentation, since it still says that the default is 31390
https://istio.io/docs/reference/config/installation-options/#gateways-options

That options list refers to the helm install method, not istioctl

@howardjohn
According to documentation:

For backwards compatibility, the previous Helm installation options, with the exception of Kubernetes resource settings, are also fully supported. To set them on the command line, prepend the option name with “values.”.

Therefore, it was logical to assume (at least for me), that the default values are the same as well.
Where I can find documentation about options / default values for istioctl-based deployment?

Thats true, that page caused a lot of confusion. In 1.6 we are planning to remove it to help make things a bit simpler. The istioctl docs are at https://istio.io/docs/reference/config/istio.operator.v1alpha1/#IstioOperatorSpec. We are working a bit to make the format of this a bit easier to consume as well (it is auto generated)

Thats true, that page caused a lot of confusion. In 1.6 we are planning to remove it to help make things a bit simpler. The istioctl docs are at https://istio.io/docs/reference/config/istio.operator.v1alpha1/#IstioOperatorSpec. We are working a bit to make the format of this a bit easier to consume as well (it is auto generated)

Closing as this is a documentation issue and the confusing doc has since been removed in 1.6. Please try this out, thanks!


ebnf: support raw string tokens as used by EBNF in the Go spec

The EBNF in the Go specification uses raw strings for tokens that
contain double quotes or backslashes. This change adds support
for raw string tokens to the ebnf package, so that go_spec.html
is validated successfully.
This change also re-enables the ebnflint test, which validates the
Go spec.
Fixes golang/go#37290

@googlebot I signed it!


Was looking for capability attributes example for Alexa skill

Can you please post sample capability attribute for Alexa skill ?

Currently, best source is the Github project of the Alexa botium connector. There are some instructions and sample code included as well.


0 Based Internal Vectors for Fibers

0-based languages will have sparse arrays represented internally by 0 based vectors. While Fibers should always use getindex starting with 1, support for internal 0 based representation is key for workloads that are, for instance, solver-centric.

I agree we should implement this, there's a question of how much parameterization we should expose.
Most of the levels are parameterized with a Tp argument, specifying the integer type of positions in the fiber. However, the user probably doesn't want to change this property on a per-level basis (it would cause type instability). We can default Tp to be the same position type as that used by the sublevel (it currently just defaults to Int, so you have to set it for every level if you want to deviate).
The next challenge is of course 0 or 1 indexing. We can change the starting position to 0 with the same mechanism as above, no problem. However, for indices it's a different story. People might want to index their tensor with BigInt starting at -7, a different problem than the kind of "starting index isn't 1" that we talk about here. When we store to a binary format or reinterpret for another language, we do need to shift the stored values of the indices. Perhaps the answer to this problem is more granular, and should involve interpreting 0-indexed arrays as 0-indexed in julia, then shifting them by one in julia as well. I'm open to other suggestions.

so the operation to read a 0-indexed vector from memory would look like
A_raw = fbrread("A.fbr")
A_raw::Fiber{SparseListLevel{Int, 0, ElementLevel{0.0, Float64, 0}}}
A = Fiber!(SparseListLevel{Int, 1, ElementLevel{0.0, Float64, 1}}}
@finch @loop j i A[i] = A_raw[i-1]

Alternately, we can say that fibers always start at one(Ti) or zero(Ti), and this is determined by whether the positions start at one or zero as well.

I currently have a Bi parameter which isn't really constrained but is assumed to be 1 or 0. So that seems to match up well?

Two things need to work:1. Fibers indexed from 1, 0, or -72. Fibers indexed from 1 that subtract one internally (storage looks 0 indexed, semantics look 1 indexed)I am trying to figure out if I can do both at once or if these need to be separate concepts.On Mar 9, 2023, at 12:01 PM, Will Kimmerer @.***> wrote:
I currently have a Bi parameter which isn't really constrained but is assumed to be 1 or 0. So that seems to match up well?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Why -72? Note this is strictly for internal Vectors, I only intend to support 1 based indexing right now for getindex and setindex

What I'm saying is that I'd like Finch to support overloaded implementations of base.axes, and I'm starting to understand this as a separate concern from whether Finch stores zero or one indexed.
As a related concern, Finch may one day support a C backend, and so would need to write code which is zero-indexed for zero-indexed arrays.

I think that the way forward on this issue is to do one of the following 3 options:

Define an integer wrapper number type that stores the value it represents off by one, and promotes with other integers as +1.
Define a vector type that stores integers off by one
Add some parameter to Fibers to do the +1 and -1 in the code that Finch generates.

consider the following:

struct CIndex{T} <: Integer
    val::T
end

cindex_types = [Bool, Int8, Int16, Int32, Int64, Int128, UInt8, UInt16, UInt32, UInt64, UInt128, BigInt]
for S in cindex_types
    @eval begin
        @inline Base.promote_rule(::Type{CIndex{T}}, ::Type{$S}) where {T} = CIndex{promote_type(T, $S)}
        Base.convert(::Type{CIndex{T}}, i::$S) where {T} = CIndex(convert(T, i - true))
    end
end
Base.promote_rule(::Type{CIndex{T}}, ::Type{CIndex{S}}) where {T, S} = CIndex{promote_type(T, S)}

cindex_binops = [:*, :+]

for Ti in cindex_types, op in cindex_binops
    @eval @inline Base.$op(a::CIndex{T}, b::CIndex{T}) where {T} = CIndex($op(a.val + true, b.val + true)-true)
end

Base.to_index(i::CIndex) = Base.to_index(i.val + true)

http://willowahrens.io/Finch.jl/dev/fibers/#Index-Compatibility


Would you please provide a sync version of parseString

It is strange to provide only async functions without providing sync versions of them. :-)

While what I find I am wrong is that the "async" version is not async at all.
Strange behavior, indeed.
I am going to close this issue,
but try this please,
and you will find the behavior of this function is strange:
(() => {
    var a;
    new require('xml2js').Parser().parseString('<xml>asdf</xml>', (e, r) => { a = r });
    console.log(a);
})();

I agree, but you can make the function async by setting the async param. The not-really-async behaviour was reported before but when I fixed it, much code broke becaus it just assumed that the function would be sync at heart, so I had to make it opt-in.

very confused!

Why are you very confused? I can attempt to explain my reasoning in other words it that clears it up for you.


Added type definitions

I've added some type definitions based on the coffee code and the docs. It will enable type safety for TypeScript usage. If you're familiar with Typescript could you please check the validity of my interpretation? Thanks in advance!

It could be really useful to merge this, I'm working on a TS project and I'd like to have the types available! Thank you for your work ;)

Done and done. Thanks, @markopostma!

Done and done. Thanks, @markopostma!

No problem m8! 👍


Cannot scale down a AKS nodepool

This is autogenerated. Please review and update as needed.
Describe the bug
Could not scale down a nodepool (that is in state Failed)
Command Name
az aks nodepool scale
Errors:
'AgentPoolsOperations' object has no attribute 'create_or_update'
Traceback (most recent call last):
python3/dist-packages/knack/cli.py, ln 233, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 659, in execute
    raise ex
cli/core/commands/__init__.py, ln 722, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
...
azure/cli/core/__init__.py, ln 786, in default_command_handler
    return op(**command_args)
cli/command_modules/acs/custom.py, ln 3390, in aks_agentpool_scale
    return sdk_no_wait(no_wait, client.create_or_update, resource_group_name, cluster_name, nodepool_name, instance)
AttributeError: 'AgentPoolsOperations' object has no attribute 'create_or_update'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az aks nodepool scale --node-count {} -n {} --cluster-name {} -g {}

Expected Behavior
Environment Summary
Linux-5.13.0-23-generic-x86_64-with-glibc2.34
Python 3.9.7
Installer: DEB

azure-cli 2.18.0 *

Extensions:
azure-devops 0.19.0

Additional Context

route to service team

You have a fairly out of date version of Azure CLI; please follow the instructions here to upgrade and see if the issue continues. If it does, please post a new error message; if not, please let us know and close the issue. Thanks!


Editor: crop story poster image and publisher logo upon selection

Context

Summary
Use the build media view to crop image that need to of a size.
This link was specially useful - https://stackoverflow.com/questions/48082713/wordpress-plugin-using-wp-media-to-crop-images
Relevant Technical Choices
I also force the size of the poster image for videos, as this makes sense to do at the same time.
Also force the images be allowed poster image types as it doesn't make sense to try and edit an svg for example.
To-do

User-facing changes
https://user-images.githubusercontent.com/237508/123123741-fba6b700-d43e-11eb-92a3-44c1c7958201.mov
Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:
Upload poster / publisher logo

Create a new story.
Go to documents tab.
Click in edit icon for poster / publisher logo.
Upload image.
Select image.
Crop image.
Select image.

Try different file types, sizes and even videos here.
Upload poster for video

Create a new story.
Insert video into page.
Accessibility panel.
Click on Edit image icon. Then Edit.
Select / upload image.
Crop image
Select image.

Upload poster for multiple videos

Create a new story.
Insert multiple video into page.
Select multiple video elements.
Accessibility panel.
Click on Edit image icon. Then Edit.
Select / upload image.
Select image.

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #7744

Should we add the cropping to assets/src/edit-story/components/panels/design/link/link.js as well? I think the link icon should be a square, but not sure.

Added some tests.

@googlebot I consent

Pushed a couple of small fixes to address feedback from QA