Final paper peer review

Summary
The repository "Determinants-of-Wage-Variation-in-Canada" investigates the impact of education levels on the average hourly wage rates of Canadians aged 25-54, utilizing data from 2000 to 2019. The study employs a linear regression model to analyze the correlation between educational attainment and earnings, aiming to provide insights for economic and educational policy-making.
Strong positive points:
Comprehensive analysis of a significant demographic over a substantial time frame.
Clear methodology with the transformation of educational levels into numeric values for regression analysis.
Well-structured repository with organized directories for data, models, scripts, and documentation.
Critical improvements needed:
Data Source Clarification: The repository should provide explicit references to the datasets used, including direct links or DOIs. This ensures transparency and allows for reproducibility.
Modeling Details: While a linear regression model is mentioned, the repository lacks detailed explanations of the modeling approach, assumptions, and potential limitations. Including a comprehensive methodology section would enhance the study's credibility.
Discussion Depth: The current discussion is brief and does not fully explore the implications of the findings. Expanding this section to include potential impacts on policy, comparisons with existing literature, and considerations of external factors influencing wage variation would add significant value.
Suggestions for improvement:
Abstract Enhancement: Expand the abstract to succinctly summarize the main findings and their significance.
Code Comments: Add inline comments in the scripts to explain key steps, particularly in data preprocessing and analysis.
Visualization Descriptions: Include descriptive captions for visualizations to guide readers in interpreting the results.
Literature Review: Incorporate a brief literature review in the introduction to contextualize the study within existing research on wage determinants in Canada.
Policy Implications: Discuss potential policy implications of the findings, such as recommendations for educational programs or labor market interventions.
Evaluation:
R/Python cited (0.5/1 pts): The repository uses R scripts but does not explicitly cite the language or specific packages used.
Data cited (0.5/1 pts): The data source is mentioned but not clearly specified or cited.
Class paper (1/1 pts): Not applicable.
LLM documentation (0/1 pts): No explicit documentation on leveraging LLMs for the analysis.
Title (2/2 pts): The title accurately reflects the content of the repository.
Author, date, and repo (2/2 pts): Author information and repository details are provided.
Abstract (3/4 pts): Provides an overview but lacks specific findings.
Introduction (3/4 pts): Introduces the topic but could benefit from more context.
Estimand (1/1 pts): Clearly defined.
Data (8/10 pts): Comprehensive dataset but lacks clear citation.
Measurement (3/4 pts): Measurements are appropriate but not fully detailed.
Model (7/10 pts): Models are present but lack detailed explanations.
Results (7/10 pts): Results are presented but not thoroughly interpreted.
Discussion (6/10 pts): Limited discussion on findings and implications.
Prose (5/6 pts): Generally well-written with minor areas for improvement.
Cross-references (1/1 pts): Not applicable.
Captions (1/2 pts): Captions are present but could be more descriptive.
Graphs/tables/etc (3/4 pts): Visualizations are useful but lack detailed explanations.
Surveys, sampling, and observational data appendix (8/10 pts): Data is well-documented but could include more methodological details.
Referencing (3/4 pts): References are included but not exhaustive.
Commits (2/2 pts): Commits are regular and well-documented.
Sketches (2/2 pts): Sketches are included in the 'other' directory.
Simulation (4/4 pts): Simulation scripts are present and functional.
Tests (3/4 pts): Some testing is evident but could be more comprehensive.
Parquet (1/1 pts): Not applicable.
Reproducible workflow (3/4 pts): Workflow is mostly reproducible with minor improvements needed.
Enhancements (3/4 pts): Incorporates modern tools but could further enhance documentation.
Miscellaneous (2/3 pts): Overall, a solid project with room for minor improvements.
Estimated overall mark:
80 out of 100.
Any other comments:
The project demonstrates a commendable effort in analyzing wage determinants in Canada. Solving the critical improvements and suggestions will enhance the clarity, reproducibility, and impact of the study.

Thank you for the feedback and suggestions. We have noted the areas for improvement, including clarifying the data sources, expanding the discussion section, enhancing the abstract, and providing detailed explanations of the modeling approach and visualizations. We will work on incorporating these improvements in the next revision of the project. Closing this issue as we move forward with the updates.


update Outlook.NameSpace.OpenSharedItem.md

quick fix to table formatting (there was a missing line of dividers)

Docs Build status updates of commit 4e36c9a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Outlook.NameSpace.OpenSharedItem.md
:bulb:Suggestion
View
Details

api/Outlook.NameSpace.OpenSharedItem.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Include all categories that a user follows in the home feed

Right now we only pull in one category that a user follows, we should pull in all of them.

I’m going to limit this to 100 genes, because that’s the max that Gravity will return per page.


App crash when pressing back-button twice

Reported on a forums.
Fuse 1.7
The App is crashing when pressing the back button (or back in preview mode on PC) twice when there is nothing to go back to. First time nothing happens, second press the App crashes with stacktrace:
[Viewport]: System.NullReferenceException: Object reference not set to an instance of an object.
   at Fuse.Navigation.Router.GoUp() in C:\Users\nicolai\AppData\Local\Fusetools\Packages\Fuse.Navigation\1.7.2\Router.uno:line 278
   at Fuse.Navigation.Router.GoBack() in C:\Users\nicolai\AppData\Local\Fusetools\Packages\Fuse.Navigation\1.7.2\Router.uno:line 263
   at Fuse.Navigation.Router.OnKeyPressed(Object sender, KeyEventArgs args) in C:\Users\nicolai\AppData\Local\Fusetools\Packages\Fuse.Navigation\1.7.2\Router.uno:line 157
   at Fuse.Input.KeyPressed.Invoke(KeyPressedHandler handler, Object sender, KeyPressedArgs args) in C:\Users\nicolai\AppData\Local\Fusetools\Packages\Fuse.Nodes\1.7.2\Input\Keyboard.uno:line 63
   at Fuse.VisualEvent`2.InvokeInternal(THandler handler, Object sender, TArgs args) in C:\Users\nicolai\AppData\Local\Fusetools\Packages\Fuse.Nodes\1.7.2\Event.uno:line 149

This is on Fuse 1.7. In 1.6 the exact same code works without a crash. Code example of minimum App that recreates the crash:
<App>
	<Router ux:Name="router"/>

	<ClientPanel>
		<Navigator DefaultPath="home">
			<Page ux:Template="home">
				<PageControl ux:Name="containerControl">
					<Page>
						<Text Value="Page 1" />
					</Page>
				</PageControl>
			</Page>
		</Navigator>
	</ClientPanel>
</App>

This issue is still exist in Fuse 1.7.1

The issue still exists in Fuse 1.7.3, but only on Android 6.0 device.
Got this error:
Uno.NullReferenceException: Object reference was null


Feature suggestion: Redirect from exceptions

Since Olive can print errors, a cool thing to have would be to
A good thing to have would be to:

Click on the filenames in the stacktrace and it opens that file in a pane in Olive, possibly directly on the given line number
If the file is already open, just point to the appropriate cell and line number

Since Olive can print errors, a cool thing to have would be to A good thing to have would be to:

Click on the filenames in the stacktrace and it opens that file in a pane in Olive, possibly directly on the given line number
If the file is already open, just point to the appropriate cell and line number

Ooooo, I like this, this would go nicely with the new Project/environment (and sub-projects which would go perfectly with this). I will milestone it!

Here is my idea for an approach to this, here is the StackFrame documentation:
https://docs.julialang.org/en/v1/base/stacktraces/
We simply create a stack frame inside of the evaluation module, should be really straightforward :)


Added support for complete path localization

The full path is now localized by build_resource, this is useful with subfolders, eg: /my/great/page -> /mon/super/site

Would this have any regressions against users expecting the old functionality?

Ping @splebel

There shouldn't be any regression as I don't see the use case of a half translated url, eg: /my/great/page -> /mon/great/page


upload csv style guide

implement style guide for Upload CSV pages

Address the comments about Upload CSV on the FYA Change Log

typography/button placement for the csv preview page (desktop)
Upload CSV Preview: “Go to Page: _” as an input instead of default 1

closes #173

Looks good for the most part. There are some buttons where you can use colorScheme="whatever" instead of bg="" and color="" (The places where I commented are not extensive) but since it's this close to the deadline imo you don't have to replace those but let's wait for Mo-Megha's review

Yes, please change all the buttons to use the colorScheme instead of color and bg!

Looks good for the most part. There are some buttons where you can use colorScheme="whatever" instead of bg="" and color="" (The places where I commented are not extensive) but since it's this close to the deadline imo you don't have to replace those but let's wait for Mo-Megha's review

Yes, please change all the buttons to use the colorScheme instead of color and bg!

Does this mean you want me to create new themes? I kept some of the buttons with the bg and color properties because there weren't any themes that matched them.

Looks good for the most part. There are some buttons where you can use colorScheme="whatever" instead of bg="" and color="" (The places where I commented are not extensive) but since it's this close to the deadline imo you don't have to replace those but let's wait for Mo-Megha's review

Yes, please change all the buttons to use the colorScheme instead of color and bg!

Does this mean you want me to create new themes? I kept some of the buttons with the bg and color properties because there weren't any themes that matched them.

If there's a new button that hasn't been defined in ChakraTheme.jsx, then you can add a new colorScheme there.


AD Connect Cloud Sync and Password Writeback with multiple agents in separate sites?

Hi, AD Connect Cloud Sync sounds like a great solution to our problem of password writeback replicating to AD remote sites.
We currently use the good old AD Connect installed in one of our 2 sites (site 1) and the password writeback takes long to internally replicate to our second site (site 2), so users on that site have to wait a long time before their new password can be used with resources on site 2. We tried lowering the inter-site replication schedule but the link between the sites is not very good.
Could you please explain how would this work if having a CAD Connect Cloud Sync Agent installed in each site? is the password writeback sent to both agents simultaneously? or is there a way to setup some kind of affinity?
Thanks,
G

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2ca26ebb-5558-75b9-7394-862bbd22b120
Version Independent ID: e84b2a95-67ad-7e54-d4c7-977e01a0d3ea
Content: Enable Azure Active Directory Connect cloud sync password writeback
Content Source: articles/active-directory/authentication/tutorial-enable-cloud-sync-sspr-writeback.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@Lumute
Thanks for your feedback! We will investigate and update as appropriate.

@Lumute
Thank you for your time and patience!
Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our support team via an Azure support request. Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.

Thanks, I'll do that...


Support connecting to remote apps over SSL +.+

Is your feature request related to a problem? Please describe.
Should be able to connect to SSL endpoints
Describe the solution you'd like
Connect to apps via SSL endpoints

[Nest] 54  - 02/08/2023, 5:28:15 PM    WARN [PlexApiService] Plex api communication failure.. Is the application running

Fixed in PR https://github.com/jorenn92/Maintainerr/pull/442.

:tada: This issue has been resolved in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(instrumentation-winston): add log sending to Logs API

Fixes #1558
Winston instrumentation will emit recordLog using Logs API whenever configured on, adding similar configuration options as the ones added for Bunyan in #1713

I think it would be better to implement this as a Winston transport rather than an instrumentation, similar to how it has been implemented for Bunyan as a stream. The Logs Bridge API was intended for log appenders, not instrumentations.

@martinkuba my initial approach was using Winston transports, and the problem I found was related to having a direct dependency to winston 3x and 2x to make it work, transports require to extend a specific class in winston is not just to follow some interface, so that would mean people installing @opentelemetry-instrumentation-winston will get winston 3x and winston 2x installed as well, I believe this is undesirable and that is why I decided to use existing patch in write/log methods instead. Related to log appenders or instrumentations, there was some discussion about this, we can create another new appender package just for Winston, Bunyan and others, but I believe the agreement was to use the instrumentation instead, I don't have a problem creating a new appender project here, but is just some maintenance overhead in my opinion and possible causing users confusion.

@hectorhdzg That makes sense. I just wanted to highlight that the Logs API was not intended to be used in instrumentations (per my interpretation of the spec). Maybe it's fine to approach it this way, but I am also thinking in terms of allowing (or encouraging) instrumentations to generate logs. The PR linked below is related.
https://github.com/open-telemetry/opentelemetry-js/pull/4314
I see that Java has different packages for different versions of Log4j appenders
https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/log4j

@martinkuba I understand appender term makes sense as is what the specification mentions, I created a discussion issue to talk about this in a single place, as this conversation has been happening in several places. I don't have strong opinions about one or the other, I just want to allow this functionality and move this forward.
https://github.com/open-telemetry/opentelemetry-js/issues/4355

@trentm, @pichlermarc, @seemk, @Flarna I updated the code according to @pichlermarc suggestions, created a new package for Winston OpenTelemetry Transport, only version > 3 are currently supported as it rely on winston-transport not available in winston 1 and 2. Added code to dynamically load the package and log an error if not available but it will not throw any error if not there,  customer will need to install 2 packages to have auto generation of logs in Winston now. We can follow up with winston 2 support in the future, PR is quite long now because of 2 different projects being involved, I can split this in 2 PRs if preferred, let me know.

Thanks @Flarna and @pichlermarc for taking another look at this PR, hopefully we are getting close to merge this one, I moved the winston transport project to packages folder and try to address your feedback, there are some open discussions that hopefully we can resolve soon.

@pichlermarc @Flarna @trentm this one is ready for another round, all feedback should be addressed now.

Here is a small test where it looks like the OTel LogRecord traceId and spanId values are not getting set correctly:
% pwd
/Users/trentm/tm/opentelemetry-js-contrib5/plugins/node/opentelemetry-instrumentation-winston

% cat foo.js
const otel = require('@opentelemetry/api');
const winston = require('winston');

const logger = winston.createLogger({
  level: 'info',
  transports: [
    new winston.transports.Console(),
  ]
});

logger.info('hi');

const tracer = otel.trace.getTracer('example');
tracer.startActiveSpan('manual-span', span => {
  logger.info('in a span', {foo: 'bar'});
  span.end();
});

% cat telemetry.js
// Setup telemetry for tracing and Winston logging.
const { NodeSDK, tracing, logs, api } = require('@opentelemetry/sdk-node');
// api.diag.setLogger(new api.DiagConsoleLogger(), api.DiagLogLevel.DEBUG);
const { WinstonInstrumentation } = require('./');
const sdk = new NodeSDK({
  serviceName: 'winston-example',
  spanProcessor: new tracing.SimpleSpanProcessor(new tracing.ConsoleSpanExporter()),
  logRecordProcessor: new logs.SimpleLogRecordProcessor(new logs.ConsoleLogRecordExporter()),
  instrumentations: [
    new WinstonInstrumentation({
      enableLogSending: true
    }),
  ]
})
process.on("SIGTERM", () => {
  sdk.shutdown().finally(() => process.exit(0));
});
sdk.start();

% node -r ./telemetry.js foo.js
{"level":"info","message":"hi"}
{"foo":"bar","level":"info","message":"in a span","span_id":"6d5b98c69a377354","trace_flags":"01","trace_id":"99820eddd6eeebaa99d46badf4f37b77"}
{
  timestamp:<PHONE_NUMBER>304000,
  traceId: undefined,
  spanId: undefined,
  traceFlags: undefined,
  severityText: 'info',
  severityNumber: 9,
  body: 'hi',
  attributes: {}
}
{
  traceId: '99820eddd6eeebaa99d46badf4f37b77',
  parentId: undefined,
  traceState: undefined,
  name: 'manual-span',
  id: '6d5b98c69a377354',
  kind: 0,
  timestamp:<PHONE_NUMBER>306000,
  duration: 1259.054,
  attributes: {},
  status: { code: 0 },
  events: [],
  links: []
}
{
  timestamp:<PHONE_NUMBER>311000,
  traceId: undefined,
  spanId: undefined,
  traceFlags: undefined,
  severityText: 'info',
  severityNumber: 9,
  body: 'in a span',
  attributes: {
    foo: 'bar',
    trace_id: '99820eddd6eeebaa99d46badf4f37b77',
    span_id: '6d5b98c69a377354',
    trace_flags: '01'
  }
}

Two issues with that last LogRecord:

traceId, spanId, and traceFlags are not set to the span context.
attributes has the trace-context fields, and I think records sent to the Logs SDK should not have those. At least for the Bunyan instrumentation I explicitly masked those out: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/39c34df61f0e60a93fc787dcfceca9782341b837/plugins/node/opentelemetry-instrumentation-bunyan/src/OpenTelemetryBunyanStream.ts#L130-L143

A weird thing here is that if I remove that first log.info('hi') -- which I would think would be unrelated -- then the "in a span" LogRecord does have the span context fields:
% cat foo.js
const otel = require('@opentelemetry/api');
const winston = require('winston');

const logger = winston.createLogger({
  level: 'info',
  transports: [
    new winston.transports.Console(),
  ]
});

// logger.info('hi');

const tracer = otel.trace.getTracer('example');
tracer.startActiveSpan('manual-span', span => {
  logger.info('in a span', {foo: 'bar'});
  span.end();
});

% node -r ./telemetry.js foo.js
{"foo":"bar","level":"info","message":"in a span","span_id":"44b045902e82a7cb","trace_flags":"01","trace_id":"d091897572a459199de5867f13e16ff9"}
{
  timestamp:<PHONE_NUMBER>006000,
  traceId: 'd091897572a459199de5867f13e16ff9',
  spanId: '44b045902e82a7cb',
  traceFlags: 1,
  severityText: 'info',
  severityNumber: 9,
  body: 'in a span',
  attributes: {
    foo: 'bar',
    trace_id: 'd091897572a459199de5867f13e16ff9',
    span_id: '44b045902e82a7cb',
    trace_flags: '01'
  }
}
{
  traceId: 'd091897572a459199de5867f13e16ff9',
  parentId: undefined,
  traceState: undefined,
  name: 'manual-span',
  id: '44b045902e82a7cb',
  kind: 0,
  timestamp:<PHONE_NUMBER>003000,
  duration: 3241.446,
  attributes: {},
  status: { code: 0 },
  events: [],
  links: []
}

As far as I remember transports in winston are not sync always. They are even batched in some scenarios like high load or transport chain setup,... because internal streams are used.
So the traceId/spanId added by transport is not that one from log writing in user app - it's that one from transport.
Not sure what the log spec wants here as both might have a valid usecase.
If the traceId/spanId from actual log statement is needed the enrichment by log sdk using getCurrentSpan can't work as it is too late.

@trentm let me know if there is any concern pending

@hectorhdzg I see you resolved a number of the conversations above, but I don't see any new commits pushed to your feature branch. Did you perhaps forget to push up your local changes? (Sorry if I'm jumping the gun. I'm trying to not be the slow reviewer here again. :)

@trentm sorry I usually start resolving whenever I update locally, and push changes after, everything should be up to date now.


Add an minimize button to ActionsSelection

I'm completely new to React, tailwind and pulling a request on GitHub, hope I didn't mess things up!
I want to add some features to sc2-planner, let's see how it goes with this small first one ^^

Hey, thank you for spending time on how I set up the project, and thanks for adding the feature.
I added the feature in https://github.com/BurnySc2/sc2-planner/pull/25 because I wanted to apply npx prettier before merging, however I was unable to push my commit to this PR.
So instead I'm going to merge the other PR - I hope that is fine with you.

Whatever works ^^
From now on I'll apply npx prettier before pushing.


Encountered "Failed" message while installing 2020.3.32f1 using Install Editior on Unity Hu 3.1.1

Problem encountered on https://dotnet.microsoft.com/en-us/learn/games/unity-tutorial/install
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

We won't be able to help you with that specific issue. Please go to https://support.unity.com/ to try to get Unity support.


DVC Cheat Sheet

Added Cheat Sheet for DVC (Data Version Control)

I've got 404s at:

https://github.com/FavioVazquez/ds-cheatsheets/blob/master/General/DVC/DVC_cheatsheet.pdf
https://github.com/FavioVazquez/ds-cheatsheets/blob/master/General/Git/DVC/img/DVC_cheatsheet.png

Thanks @cwallaceh !


[decompiler] automatically label things when possible

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

61 of 287 (21.25%)  changed or added relevant lines in 19 files are covered.
43 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.2%) to 64.858%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/ObjectFile/ObjectFileDB.cpp
0
1
0.0%

goalc/compiler/StaticObject.cpp
2
3
66.67%

game/system/newpad.cpp
0
2
0.0%

decompiler/IR2/AtomicOp.h
0
3
0.0%

decompiler/analysis/static_refs.cpp
0
3
0.0%

decompiler/IR2/Form.cpp
0
4
0.0%

decompiler/config.cpp
0
8
0.0%

decompiler/IR2/AtomicOpTypeAnalysis.cpp
5
15
33.33%

test/offline/offline_test_main.cpp
0
10
0.0%

decompiler/IR2/FormExpressionAnalysis.cpp
5
17
29.41%

Files with Coverage Reduction
New Missed Lines
%

decompiler/analysis/static_refs.cpp
1
0%

decompiler/ObjectFile/LinkedObjectFile.cpp
1
5.98%

decompiler/util/data_decompile.cpp
1
53.37%

game/system/newpad.cpp
1
0%

decompiler/IR2/AtomicOpTypeAnalysis.cpp
3
72.82%

decompiler/IR2/AtomicOpForm.cpp
6
71.65%

decompiler/IR2/FormExpressionAnalysis.cpp
6
70.12%

decompiler/IR2/Form.cpp
24
69.21%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
39776

Relevant Lines:
61328

💛  - Coveralls


Add menu link for LMM Genetic Diversity vignette

Need to add menu link for new LMM Genetic Diversity vignette, see #182. @panastheod suggests "Comparing genetic diversity using mixed models" as the menu text.

There's also the matter of copy-editing, which I will include here as well.


Harvester: Generate the clusterRoleBinding for harvester-csi-driver

Proposed changes

Add role name for Harvester CSI driver
Types of changes

New feature (non-breaking change which adds functionality)

Linked Issues

https://github.com/harvester/harvester/pull/3357#issuecomment-1381252772
https://github.com/harvester/harvester/issues/3052

Further comments

Hi, @mantis-toboggan-md. There have a PR that needs you to review, Thx!


Add Mutation to Kill Jobs

Add a new mutation in the GraphQL API to kill pending or running jobs.

Done


Option value

Re-creation of #252

@limira Your updates lives here now. I've squashed to_uppercase commit into eq_ignore_ascii_case to keep changes structured.

bors r+


Build errors (Cannot find module '/out/src/browser.js' )

steps to reproduce
clone repo
yarn install
I get that error(build docs would also be nice):
cp -r src/static/ out/src/static
./node_modules/.bin/coffee ./scripts/compileLessCss.coffee
./node_modules/.bin/browserify ./out/src/browser.js > ./out/src/browser.all.js
Error: Cannot find module '/home/m/chrome-vs-code/out/src/browser.js' from '/home/m/chrome-vs-code'
at /home/m/chrome-vs-code/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:21
at load (/home/m/chrome-vs-code/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
at onex (/home/m/chrome-vs-code/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
at /home/m/chrome-vs-code/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
at FSReqWrap.oncomplete (fs.js:166:21)
Makefile:7: recipe for target 'all' failed
make: *** [all] Error 1

OK, no idea if yarn will work here (it should, I know, I know). You could try npm install instead.

npm install not worked for me too, but with less clear error output. This is why I like simple instruction how it is build, at least on creator machine (because other could know when they do something not as expected).


Maximum Binary Tree

Problem Link

Put it under the Leetcode problem section under the Tree section.

Put it under the Leetcode problem section under the Tree section.

Sure.


Proposal to relax kfp sdk dependency

What changes were proposed in this pull request?
Relax kfp requirement in elyra releases as described in #2033
How was this pull request tested?
Change is trivial and should be noop until there's a new kfp sdk release.
May be worth considering how often to bump kfp top constraint as well.
Closes #2033

@tomlyn I remember there was some correlation between the KFP and Tekton versions, Is the range being proposed here ok?

Seems so - https://github.com/kubeflow/kfp-tekton/blob/master/sdk/python/setup.py#L57
That said, pip should resolve this nicely. I would recommend making the dep less strict here.
Also, is there a way we can move kfp-tekton to an extra instead of install_requires?

Ideally, if we move kfp-tekton out of the required dependency, we would need to better handle the possible runtime-related issues such as a user trying to submit a pipeline to a tekton runtime, but the package is not installed.

I would think it should not be an issue, extras is exactly for those cases, where some stuff may break if you try to use X feature but dont install X corresponding extra. Adding correct documentation with this explaining that you need extra tekton for those times you want to use kfp on tekton should probs work. It's a backwards incompatible change so I understand the reticency.
However, this would make it easier to consume elyra specially for those who are not using kfp-tekton. As we can upgrade kfp to newer version as it's a more stable package with garanteed forward compatible API.
Having all those deps in a single package makes it hard to use in monorepos or large requirements environments. Airflow, Beam, and others splitted it up similarly for similar reasons.

#2036
Does this work?

@Tomcli I remember there was some correlation between the KFP and Tekton versions, Is the range being proposed here ok?

This range should be mostly fine, we have this strict kfp version for kfp-tekton because there were new bugs introduced back in the kfp 1.3.0 release when using func_to_container_op. So we decided to force users to install the tested stable version to minimize the possible bugs that might be introduced in the newer releases.

We should try to relax a bit to allow users to upgrade KFP between minor releases when possible here as well, but can be done as a separate commit after KFP releases 1.7

Just FYI, KFP SDK releases not longer follow their github releases. So they already have the kfp 1.7.0 sdk release despite their github is still having pre-release.

Damn, well, if the changes are not backwards incompatible (aka Elyra doesnt use any new method introduced by KFP 1.7) we should be good to add it in the accepted range

(aka Elyra doesnt use any new method introduced by KFP 1.7)
Not yet.

we should be good to add it in the accepted range
I would agree if 1.7.0 passes a smoke test.

Would running the tests using GitHub actions be enough? If so, I can solve run it quickly :D (just need to upgrade it on the setup.py I imagine)

What are the next steps here? Are we relaxing the kfp-tekton dependency and merging this while we discuss other changes that would come in other prs? or are we waiting for a 1.7 discussion/smoke test before merging this?

Would running the tests using GitHub actions be enough?

The tests currently do not exercise the kfp API, so 1.7 support should be manually verified at this time.

What are the next steps here?

We should make the appropriate updates that would include the tolerance of minor kfp versions (assuming manual testing via 1.7 is successful) and go ahead and relax the kfp-tekton version to tolerate patches and security fixes as suggested here:  https://github.com/elyra-ai/elyra/pull/2034#discussion_r687907376
Since it sounds like we're going to tolerate minor kfp versions, I guess we'd want 'kfp>=1.6.3,<2.0' so as to still prevent major release inclusion.  Else we could remove the cap altogether.
Does that sound right?

The tests currently do not exercise the kfp API, so 1.7 support should be manually verified at this time.

I confirmed that the example pipelines work as expected using kfp==1.7.0 and kfp-tekton==0.8.1. I've also inspected the change log for that kfp release and didn't notice anything related to features we are using.
It should therefore be okay to go with
'kfp-tekton~=0.8.1'
'kfp>=1.6.3,<2.0'

Updated! Thanks for testing!


New prop defaultValue doesn't fire onPhoneNumberChange on mount

Hi,
I was using this lib as an uncontrolled component, and since this PR: https://github.com/patw0929/react-intl-tel-input/pull/166 onPhoneNumberChange is not fired on mount. Why would that be useful? I need the parameters of the function to handle the value changes (status, countryData, ...).
Could you please fire it at mount like it used to?
Thanks in advance.
@chris-verclytte

Created a PR: https://github.com/patw0929/react-intl-tel-input/pull/171

merged and published as v4.1.0.

Thanks to you! I close this issue as it is now resolved :)


Window Title set to Electron when running on Windows

Title looks fine when building for Mac. However after building for Windows, the window title shows: Electron instead of html title.
Tried the following:

Set using browserwindow.setTitle().
Set using index.html <title> tag.

Strange thing is if browser window loses focus then regains focus, the title magically changes once the window is visible again.

Can you provide an example app? I'm unable to reproduce this.

I'll try to create a new project I can share when I get a chance. This person is having the same issue: http://stackoverflow.com/questions/31882538/window-title-not-showing-correctly-electron

Issue occuring with plain project started with get started instructions
https://www.dropbox.com/s/a7gh6xsyx2ug7qa/electron.zip?dl=0

Do you have DWM closed on your machine? Seems that the titlebar failed to repaint.

Refs #1821.

I believe so. I only saw the issue when using Remote Desktop. If a fix is not easy, why not change the default window title bar from Electron to be empty? This would be much better for end users rather than confuse them with the Electron name.

I'm merging this to #1821. To set default title, you can set the title option of BrowserWindow.


Documentation on using CSP for statically generated sites

Hello,
I'm having some trouble understanding how to use the CSP generation feature of this project with a statically generated website. I believe the docs only specify how to use them for an SSR website where you can inject the headers via a server middleware, which is not present for statically generated websites.
I looked through the dist folder to see if the CSP values were output anywhere.
Is there a way to save the generated CSP as an output of the build step or a generated file that I can reference when I deploy my static site to a CDN?
Thanks!

Hi @SeanPollock , @keke1210 , please excuse me for my super late response.
Astro-Shield does not provide this feature yet, but we have it in our roadmap. The way to do it today is not too complicated, though, although it requires some extra scripting:

Run the build process, and generate the "hashes module" (you can wee how in the documentation)
After the build, you can run a script that loads the "hashes module", and based on its content changes the configuration for your provider of choice (Vercel, Netlify, etc.)

The related issues are:

#64
#65

Closing because we already have more specific issues covering the same problem exposed here.


MessageInfo.Status doesn't work correctly

All messages received from other accounts via HandleTextMessage() have the error status, regardless of their actual status. However, messages in which FromMe = true receive the correct status (read, delivered, etc.)

i use latest github.com/Rhymen/go-whatsapp/ and latest WhatsApp app from playstore, working fine

Do you was able to see why the status is incorrect when receiving?
Thanks in advance!

HI @codenoid , I'm always receiving status ERROR (0)  in some messages from remoteJids , I'm using the latest version.

On the latest version, all messages not from the owner have the Error(0) status. How do I get the status of a message?

Actually, I'm stopped using this project. And because nobody else experienced same issue, I'm considering that this issue should be closed.

Actually, I'm stopped using this project. And because nobody else experienced same issue, I'm considering that this issue should be closed.

Are there any alternatives to this project?

@ftomza I stopped using WhatsApp all together. I don't know if where are projects that has similar functionality


Build contributing page script

Issue FINOS Project Blueprint Docusaurus content to include .github/CONTRIBUTING.md
I created a script as @maoo  suggested. In his implementation he added the script only to docusaurus.yml so I did the same. But for testing locally I try this in package.json
"build": "cd .. && bash build-contribute-page.sh && cd ./website && docusaurus-build"
Also I had to modify sidebars.json beacause it has an error and was breaking the build.
This is the end result:

Thank you for your contribution and Welcome to our Open Source Community!
To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement.
Having reviewed our contributor list, we require a CLA for the following people : (@agustinmessina).
If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email<EMAIL_ADDRESS>with your questions.
Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request.
cc @finos-admin

LGTM! Thanks @agustinmessina !
I wonder if we may want to either:

remove the first line from CONTRIBUTING.md (to skip the h1 title)
use hide_title feature to hide the Docusaurus page title ; see https://docusaurus.io/docs/en/doc-markdown

So far, I used the first option, though the second may be cleaner. Thoughts?
Before merging, @agustinmessina , could you please review https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Contribution+Compliance+Requirements ? We require our contributors to have a CLA in place with FINOS, either signed by you or by your employer.
Thank you for your PR!

Work is done on master branch. Closing issue.


fix: Change the QR value based on server

Change the QR code based on server.
I have tested so that even though the QR image mobile app is not the same as the QR image in the pdf file, the value given after scanning is still the same.
Fixes: #1706

Great, can you check if it works in the Orga App? If it does not, can you create an issue there?

@iamareebjamal Yes i'll do it now

@anhanh11001 Status?


refactor: use macros to derive merge_right

Currently MergeRight implementation is implemented by hand and is quite verbose. Let's use macro to reduce verbosity.
Technical Requirements

Create a new project tailcall-macros to implement this procedural macro.
Move trait MergeRight into tailcall-macros.
Drop existing hand written implementation of merge_right.

Additional Information
You could start with something like:
[lib]
proc-macro = true

[dependencies]
syn = { version = "1.0", features = ["derive", "full"] }
quote = "1.0"
proc-macro2 = "1.0"

Then, in lib.rs, you can start implementing your macro:
extern crate proc_macro;

use proc_macro::TokenStream;
use quote::quote;
use syn::{parse_macro_input, Data, DeriveInput, Fields};

#[proc_macro_derive(MergeRight)]
pub fn merge_right_derive(input: TokenStream) -> TokenStream {
    let input = parse_macro_input!(input as DeriveInput);

    let name = input.ident;
    let gen = match input.data {
        // Implement for structs
        Data::Struct(data) => {
            let fields = if let Fields::Named(fields) = data.fields {
                fields.named
            } else {
                // Adjust this match arm to handle other kinds of struct fields (unnamed/tuple structs, unit structs)
                unimplemented!()
            };

            let merge_logic = fields.iter().map(|f| {
                let name = &f.ident;
                quote! {
                    #name: self.#name.merge_right(other.#name),
                }
            });

            quote! {
                impl MergeRight for #name {
                    fn merge_right(self, other: Self) -> Self {
                        Self {
                            #(#merge_logic)*
                        }
                    }
                }
            }
        },
        // Implement for enums
        Data::Enum(_) => quote! {
            impl MergeRight for #name {
                fn merge_right(self, other: Self) -> Self {
                    other
                }
            }
        },
        // Optionally handle or disallow unions
        Data::Union(_) => unimplemented!(),
    };

    gen.into()
}

/bounty 100$

/attempt

Drop existing hand written implementation of merge_right.

From my findings, we'll need to keep the manual implementations for external types (HashSet<T>, Vec<T>, Option<T>, etc) and use the macro on our internal types. Makes sense @tusharmath?

Yes.

I have a draft locally but forgot to declare my attempt.
In the queue 🤚🏽


Document how to connect to the SFTP server

Thanks to @WichadaLMK and @chinandrew for screenshots.
Preview: http://rosmarus.refsmmat.com/delphi-epidata/symptom-survey/server-access.html

Now the whole world can see that I misspelled my own name for the user on my computer.


ERROR:/Users/han/Desktop/bao_im_client/build/photo_manager/intermediates/runtime_library_classes_jar/debug/classes.jar: R8: com.android.tools.r8.internal.Hc: Unsupported class file version: 62

Version
3.0-3.6
Platforms
Android
Device Model
31
flutter info
: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':app:minifyDebugWithR8'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.R8Task$R8Runnable
   > Compilation failed to complete, origin: /Users/han/Desktop/bao_im_client/build/photo_manager/intermediates/runtime_library_classes_jar/debug/classes.jar:com/flutterandies/photo_manager/BuildConfig.class

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
java.lang.StackOverflowError (no error message)

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 5m 31s

┌─ Flutter Fix ──────────────────────────────────────────────────────────────┐
│ [!] The shrinker may have failed to optimize the Java bytecode.            │
│ To disable the shrinker, pass the `--no-shrink` flag to this command.      │
│ To learn more, see: https://developer.android.com/studio/build/shrink-code │
└────────────────────────────────────────────────────────────────────────────┘
Error: Gradle task assembleDebug failed with exit code 1

How to reproduce?
各种手段都用了。换java  gradle   和饿photo_manage
Logs
/Users/han/Desktop/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, 3.24.0, on macOS 13.7.1 22H221 darwin-x64, locale zh-Hans-CN)
    • Flutter version 3.24.0 on channel stable at /Users/han/Desktop/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 80c2e84975 (5 months ago), 2024-07-30 23:06:49 +0700
    • Engine revision b8800d88be
    • Dart version 3.5.0
    • DevTools version 2.37.2
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/han/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Users/han/Library/Java/JavaVirtualMachines/corretto-18.0.2/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 18.0.2+9-FR)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.16.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915915-b509.11)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.3.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

Example code (optional)
1

Contact
No response

I am in the process of upgrading from Flutter3.12 to 3.24

AI Summary: 该用户在使用 photo_manager 库时，Android 构建失败。原因是 R8 无法处理版本号为 62 的 class 文件，导致编译无法完成。

Duplicate of https://github.com/fluttercandies/flutter_photo_manager/issues/1248


WIP: Aligned load Sum aggregation

This adds aligned load instruction to the SIMD aggregation of arrays without null values. This implementation works on any alignment, and does not require an aligned allocator, and also works on sliced arrays.
Benchmark is a bit mixed on small data sizes. It seems to improving with more data, I want to run one on more data later.
Gnuplot not found, using plotters backend
sum 2^10 f32            time:   [101.38 ns 101.41 ns 101.45 ns]
                        change: [+1.5061% +1.5401% +1.5774%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
  2 (2.00%) high mild
  7 (7.00%) high severe

sum 2^12 f32            time:   [284.72 ns 285.05 ns 285.44 ns]
                        change: [+0.4929% +0.6963% +0.9300%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 7 outliers among 100 measurements (7.00%)
  4 (4.00%) high mild
  3 (3.00%) high severe

sum 2^14 f32            time:   [1.0246 us 1.0246 us 1.0247 us]
                        change: [-4.1159% -3.6418% -3.1975%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  4 (4.00%) high mild
  3 (3.00%) high severe

sum 2^16 f32            time:   [4.0764 us 4.0773 us 4.0783 us]
                        change: [+1.4638% +1.6504% +1.7873%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
  3 (3.00%) high mild
  6 (6.00%) high severe

sum 2^18 f32            time:   [19.596 us 19.600 us 19.606 us]
                        change: [+0.2075% +0.2434% +0.2801%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
  2 (2.00%) high mild
  7 (7.00%) high severe

sum 2^20 f32            time:   [67.890 us 67.909 us 67.931 us]
                        change: [-6.5180% -6.4803% -6.4365%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
  11 (11.00%) high mild
  1 (1.00%) high severe

An update on the benchmarks:
Gnuplot not found, using plotters backend
sum 2^10 f64            time:   [151.72 ns 152.40 ns 153.21 ns]
                        change: [-3.5650% -3.1521% -2.7679%] (p = 0.00 < 0.05)
                        Performance has improved.

sum 2^10 i64            time:   [113.88 ns 113.91 ns 113.94 ns]
                        change: [+4.6575% +4.7503% +4.8275%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
  2 (2.00%) high mild
  6 (6.00%) high severe

sum 2^12 f64            time:   [526.64 ns 527.46 ns 528.31 ns]
                        change: [-2.1437% -1.9416% -1.7502%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  5 (5.00%) high mild
  2 (2.00%) high severe

sum 2^12 i64            time:   [348.69 ns 348.94 ns 349.20 ns]
                        change: [-22.641% -21.575% -20.855%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

sum 2^14 f64            time:   [1.9927 us 1.9929 us 1.9930 us]
                        change: [-3.1503% -2.7050% -2.3456%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

sum 2^14 i64            time:   [1.7309 us 1.7317 us 1.7325 us]
                        change: [-8.9944% -8.9284% -8.8592%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

sum 2^16 f64            time:   [8.3187 us 8.3202 us 8.3222 us]
                        change: [-5.6838% -5.3678% -5.0664%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
  6 (6.00%) low severe
  3 (3.00%) high mild
  6 (6.00%) high severe

sum 2^16 i64            time:   [9.2400 us 9.2499 us 9.2608 us]
                        change: [-7.9995% -7.8217% -7.6153%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 16 outliers among 100 measurements (16.00%)
  5 (5.00%) low severe
  2 (2.00%) low mild
  3 (3.00%) high mild
  6 (6.00%) high severe

sum 2^18 f64            time:   [35.474 us 35.487 us 35.504 us]
                        change: [-9.2037% -9.1425% -9.0746%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  6 (6.00%) high mild
  4 (4.00%) high severe

sum 2^18 i64            time:   [35.166 us 35.174 us 35.182 us]
                        change: [-10.221% -10.140% -10.061%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  7 (7.00%) high mild
  1 (1.00%) high severe

sum 2^20 f64            time:   [188.31 us 188.55 us 188.80 us]
                        change: [-2.2460% -1.7823% -1.2743%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  2 (2.00%) low mild
  5 (5.00%) high mild
  3 (3.00%) high severe

sum 2^20 i64            time:   [207.85 us 209.90 us 212.52 us]
                        change: [-8.0797% -6.7231% -5.2968%] (p = 0.00 < 0.05)
                        Performance has improved.

It seems to be consistent ~5-10% improvement.


vi.mock breaks live bindings

Describe the bug
If vi.mock is used in a test module, live bindings break. I've included an example reproduction below, using "latest" version of vitest.
It doesn't matter what format you do the vi.mock in or if it mocks another module or an external package.
I've tried (using file-saver as an example):

vi.mock('file-saver');
vi.mock('file-saver', () => ({}));
vi.mock('file-saver', async (importOriginal) => {
const mod = await importOriginal();
return mod;
});
...etc. All to the same effect

Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-bq5brv?file=test%2Fbasic.test.ts
Simply comment out line 5 in basic.test.ts to see the tests pass, then uncomment it and one test (the live bindings one) will fail because the live binding no longer works.
System Info
Stackblitz, but this is reproducible elsewhere as well.

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Yeah, it's a known issue. There is an open issue already, but I can't find for now.

@sheremet-va yikes! That impacts me pretty significantly (I provided a tiny repro, but essentially I rely on live binding all over my tests for a number of reasons). Is there any kind of expectation of when this could be fixed, or should I stick with jest for the time being?

Workaround is described here: https://github.com/vitest-dev/vitest/issues/3300


Remove unimplemented APIs from README

The TPM and TSS specifications are complicated enough. No need to overload users with information about APIs that aren't implemented in this repo. The README should be cleaned up to remove references to these APIs. We can add documentation back if / when we implement them.

resolved in #352


Some Translated Links are Broken

Some translated links are broken. For example, compare this:
https://github.com/kas-catholic/confessit-web/blob/757929d70ae7bd913ee007238f6666861a0692ed/src/About.js#L17-L22
To the page at https://confessit.app/about.
The link is being set to the empty string.
It took some trial and error to debug this, but I figured out what's happening. Our translations use indexes to nest elements inside the string.
https://github.com/kas-catholic/confessit-web/blob/757929d70ae7bd913ee007238f6666861a0692ed/public/locales/en/translation.json#L46
Some of these indexes changed when I ran prettier. Prettier injected some {" "} elements to allow newlines in the source (which does make it look nice) while preserving spacing around elements. Because these are also nested elements, it changed the indexing. (https://github.com/kas-catholic/confessit-web/pull/28)

@JohnRDOrazio I have a solution for this - see https://github.com/kas-catholic/confessit-web/pull/40 as a proposed solution. (I'll have to do a similar thing in a few more places.) Wanted to give you a heads up since this will affect some translations. Based on translation systems I'm familiar with, I'd assume we can commit the new strings in the en (source) translation, but will need to fix the others using weblate? (I can commit fixes in weblate too, just want to make sure I understand the workflow correctly.)

Fixed by #40


adding Parabola automation tool

Hope it's helpful!

Will need to review that. Thx for the proposal!


Is it possible to get a custom HeaderTemplate per tab item/entry

Hi Wiesław,
Thanks for the library.. been playing around with it and it is really great so far. I have been trying to get a function set up so that each of the tab items has a different icon. So far I've been failing beyond miserably. I've tried registering a custom HeaderTemplate function, and have also tried using style selectors to select sub elements with no luck. I've seen some references to a tabstrip, but looking at the code briefly for this it doesnt seem like it would be possible there either.
I was hoping to use one of the demo projects where you can pin/unpin icons to try and debug/check myself, but other than the web assembly project (which I cant find the code for, sorry) I can't see any uses where icons change dynamically. So far in the mvvm demo version we have like the below:

Is it possible to have some form of handler where I could change the icon dynamically as a new menu item is added? So (in this example) I could have 1 with a file icon, and 1 with a nuclear warning symbol or something, continuing to change each time?
Any pointers/advice would be massively appreciated. Thanks again.

Not sure this is easy to do in current 0.10.x version, in the preview version 11.0.0-preview4 should be much easier you can try  doing custom https://github.com/wieslawsoltes/Dock/blob/master/src/Dock.Avalonia/Controls/DocumentTabStripItem.axaml

Only thing missing in preview4 is context menu customisation, you can probably update using this
https://github.com/wieslawsoltes/Dock/blob/062582509816da86a7e48228a226767940cad874/src/Dock.Avalonia/Controls/DocumentTabStripItem.axaml#L15

Thanks so much for the quick reply! I'll take a look tomorrow. Thanks again and have a great weekend.
20 Jan 2023 21:06:52 Wiesław Šoltés @.***>:

Only thing missing in preview4 is context menu customisation, you can probably update using this
https://github.com/wieslawsoltes/Dock/blob/062582509816da86a7e48228a226767940cad874/src/Dock.Avalonia/Controls/DocumentTabStripItem.axaml#L15
—
Reply to this email directly, view it on GitHub[https://github.com/wieslawsoltes/Dock/issues/265#issuecomment-1398935514], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAQRPW4WRCXB4EP3VLAG4L3WTL46XANCNFSM6AAAAAAUB6AAYE].
You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AAQRPW5CJ7H5WILRI5VHFI3WTL46XA5CNFSM6AAAAAAUB6AAYGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSTMIH5U.gif]

Thanks very much for pointing me in the right direction. Was able to sort this out and it is working fine. I've yet to figure out how to dynamically replace things (for example having a toggleable/clickable pin icon like JetBrains do in their IDEs) but this is definitely the correct route. Many thanks again.


Extension causes high cpu load

Issue Type: Performance
Extension Name: yuml
Extension Version: 3.5.1
OS Version: Windows_NT x64 10.0.19042
VSCode version: 1.53.2

:warning: Make sure to attach this file from your home-directory:
:warning:c:\Users\ztome\AppData\Local\Temp\JaimeOlivares.yuml-unresponsive.cpuprofile.txt
Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

I am not receiving such report with vscode 1.68

Not reproduced on 1.70.2


Missing data for 2023

Hey Odi
Trying to query data for 2023, but nothing is being returned[1].
Cheers
Patrick
[1] https://openerz.metaodi.ch/api/calendar.ics?zip=8055&types=cardboard&types=paper&lang=de&start=2023-01-01

I'm working on it, hope I can release tomorrow.

Thanks 👍🏻

I guess this one is still pending? When I try to fetch data, nothing is returned:
http://openerz.metaodi.ch/api/calendar.json?zip=8047&start=2023-01-05&end=2023-01-12
Thanks !

Hi Odi
Thank you so much for providing this API! Awesome to see that you are still maintaining it. I am among the crowd waiting for 2023 data :). No pressure though.
Cheers!

So the new data is now available, let me know if anything is broken, but it should work now with the 2023 data.

Just checked. Some dates for 8055 seem to be off. Paper and cardboard collection in 8055 happens to be on Tuesdays.

API call: https://openerz.metaodi.ch/api/calendar.json?zip=8055&types=cardboard&types=paper&lang=de
Reference: https://www.stadt-zuerich.ch/content/dam/stzh/ted/Deutsch/erz/abfall/eu23/eu23-barrierefrei/221116_ERZ_Entsorgungskalender_2023_55_ba.pdf

Just checked your data source and it's clearly wrong on their side.

I will check with ERZ and try to get the data fixed.

The data was fixed and I just loaded it, looks good to me.

Confirmed. That was quick, thanks for caring!


RSVP API

Create RSVP endpoints
Features

RSVP for a event

Working on the branch rsvp-event.

Backend tested in Postman and it works. Started a rsvp-event branch for the frontend part and have currently only implemented the PUT method for RSVP. Need to add a button or something for the RSVP to connect in both EventPage.tsx and Landingpage.tsx.


To spark1 4

I have changed the code to adapt this project to  Apache Spark SQL 1.4.

@josegom Thanks for the 2 PRs. They are important work I believe. In particular, the adoption of Spark 1.4 is something we have been pondering over past weeks but haven't found bandwidth to do so yet. I'll review them later.
Please also note that for historical reasons, the mainstream development work is actually at the "hbase" branch of https://github.com/Huawei-Spark/spark, and not here. Later the work will be merged here. In the future (probably a couple of months later) we will solely use this repo as the dev point.

@josegom I realize that the adoption of 1.4 is better to be performed after the merge from the "hbase" branch to this repo which is planned to be after the branch is stable, probably in around one or two months. Would you mind to create a PR then for the adoption of 1.4?
For your commit of 9375503, could you summarize what are the key changes and your thoughts behind the changes?  Thanks.

I don't have any problem to make the PR when this repo will be stable but I am using Apache Spark SQL 1.4 and Apache Hbase now. For this reason I need to use my PR and I would like to know if there exist any problem to use it or to publish it (for example in a public maven repository) until the final version will be released.
On the other hand I would like to know if you are planning the continuous adaptatation to Apache Spark, because  it's probably that a new Spark version will be published in three or four months.
Finally the main changes in the PR have been as follows:

Turn NativeType into AtomicType
Turn JvmType into InternalType
Two or three methods with new parameters.
Turn apply methods into specific methods

In my opinion the adaptation is easy and the impact to Hbase is only cosmetics.
Thanks.

@josegom Yes, we will adapt to the latest Spark release. During the past few months, due to the hectic activity on our dev branch, we have not been able to follow the practice yet. Good news is, thanks to our boosted efforts, we are very close (in a few days hopefully) to merge the dev branch to this place and support 1.4. You're welcome to follow the progress here, test it and give out comments/fixes/..., etc.

We have created a "Stratio-ToSpark1_4" branch for the merge work. We'll appreciate if you can test and even contribute PRs against the branch. In particular, Python and Java API tests have not been executed.
We are rushing to conclude the work as soon as possible, but feel short of hands at the moment.
Thanks.

@josegom my last comments were addressed to you.

I close this PR and test the branch. If I find any bugs or improvements I will report it in stratio-ToSpark1_4 branch.
Thanks.

@josegom Thanks！


chore: Update from template

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 8.891%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
218

Relevant Lines:
2452

💛  - Coveralls


【MAC】Building Filament for Desktop failed

⚠ Issues not using this template will be systematically closed.
Describe the bug
Hi, i upgrade my osx version to Ventura recently and i found that filament can't be compiled successfully. Here is the log:
[1/987] Generate extended instruction tables for spv-amd-gcn-shader.
FAILED: third_party/spirv-tools/spv-amd-gcn-shader.insts.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/spv-amd-gcn-shader.insts.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --extinst-vendor-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.spv-amd-gcn-shader.grammar.json --vendor-insts-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/spv-amd-gcn-shader.insts.inc --vendor-operand-kind-prefix=
env: python: No such file or directory
[2/987] Generate extended instruction tables for spv-amd-shader-explicit-vertex-parameter.
FAILED: third_party/spirv-tools/spv-amd-shader-explicit-vertex-parameter.insts.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/spv-amd-shader-explicit-vertex-parameter.insts.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --extinst-vendor-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.spv-amd-shader-explicit-vertex-parameter.grammar.json --vendor-insts-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/spv-amd-shader-explicit-vertex-parameter.insts.inc --vendor-operand-kind-prefix=
env: python: No such file or directory
[3/987] Generate extended instruction tables for spv-amd-shader-trinary-minmax.
FAILED: third_party/spirv-tools/spv-amd-shader-trinary-minmax.insts.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/spv-amd-shader-trinary-minmax.insts.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --extinst-vendor-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.spv-amd-shader-trinary-minmax.grammar.json --vendor-insts-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/spv-amd-shader-trinary-minmax.insts.inc --vendor-operand-kind-prefix=
env: python: No such file or directory
[4/987] Generate extended instruction tables for spv-amd-shader-ballot.
FAILED: third_party/spirv-tools/spv-amd-shader-ballot.insts.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/spv-amd-shader-ballot.insts.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --extinst-vendor-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.spv-amd-shader-ballot.grammar.json --vendor-insts-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/spv-amd-shader-ballot.insts.inc --vendor-operand-kind-prefix=
env: python: No such file or directory
[5/987] Generate extended instruction tables for debuginfo.
FAILED: third_party/spirv-tools/debuginfo.insts.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/debuginfo.insts.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --extinst-vendor-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.debuginfo.grammar.json --vendor-insts-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/debuginfo.insts.inc --vendor-operand-kind-prefix=
env: python: No such file or directory
[6/987] Generate extended instruction tables for opencl.debuginfo.100.
FAILED: third_party/spirv-tools/opencl.debuginfo.100.insts.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/opencl.debuginfo.100.insts.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --extinst-vendor-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.opencl.debuginfo.100.grammar.json --vendor-insts-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/opencl.debuginfo.100.insts.inc --vendor-operand-kind-prefix=CLDEBUG100_
env: python: No such file or directory
[7/987] Generate extended instruction tables for nonsemantic.clspvreflection.
FAILED: third_party/spirv-tools/nonsemantic.clspvreflection.insts.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/nonsemantic.clspvreflection.insts.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --extinst-vendor-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.nonsemantic.clspvreflection.grammar.json --vendor-insts-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/nonsemantic.clspvreflection.insts.inc --vendor-operand-kind-prefix=
env: python: No such file or directory
[8/987] Generate language specific header for OpenCLDebugInfo100.
FAILED: third_party/spirv-tools/OpenCLDebugInfo100.h /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/OpenCLDebugInfo100.h
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_language_headers.py --extinst-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.opencl.debuginfo.100.grammar.json --extinst-output-path=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/OpenCLDebugInfo100.h
env: python: No such file or directory
[9/987] Generate enum-string mapping for SPIR-V vunified1.
FAILED: third_party/spirv-tools/extension_enum.inc third_party/spirv-tools/enum_string_mapping.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/extension_enum.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/enum_string_mapping.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --spirv-core-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/spirv.core.grammar.json --extinst-debuginfo-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.debuginfo.grammar.json --extinst-cldebuginfo100-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.opencl.debuginfo.100.grammar.json --extension-enum-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/extension_enum.inc --enum-string-mapping-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/enum_string_mapping.inc
env: python: No such file or directory
[10/987] Generate language specific header for DebugInfo.
FAILED: third_party/spirv-tools/DebugInfo.h /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/DebugInfo.h
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_language_headers.py --extinst-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.debuginfo.grammar.json --extinst-output-path=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/DebugInfo.h
env: python: No such file or directory
[11/987] Generate info tables for SPIR-V vunified1 core instructions and operands.
FAILED: third_party/spirv-tools/core.insts-unified1.inc third_party/spirv-tools/operand.kinds-unified1.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/core.insts-unified1.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/operand.kinds-unified1.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_grammar_tables.py --spirv-core-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/spirv.core.grammar.json --extinst-debuginfo-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.debuginfo.grammar.json --extinst-cldebuginfo100-grammar=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/unified1/extinst.opencl.debuginfo.100.grammar.json --core-insts-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/core.insts-unified1.inc --operand-kinds-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/operand.kinds-unified1.inc
env: python: No such file or directory
[12/987] Generate tables based on the SPIR-V XML registry.
FAILED: third_party/spirv-tools/generators.inc /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/generators.inc
cd /Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/source && /Users/danding/du/filament/third_party/spirv-tools/utils/generate_registry_tables.py --xml=/Users/danding/du/filament/third_party/spirv-tools/external/SPIRV-Headers/include/spirv/spir-v.xml --generator-output=/Users/danding/du/filament/out/cmake-release/third_party/spirv-tools/generators.inc
env: python: No such file or directory
ninja: build stopped: subcommand failed.

To Reproduce
Steps to reproduce the behavior:

upgrade osx version
run ./build.sh -i -p desktop release

Expected behavior
filament compiled successfully
Desktop (please complete the following information):

OS: [MAC M1, OSX Ventura 13.6.3]

Additional context
I found there is only python3 in my mac after i upgrade the osx version.  Maybe these error is happened due to the lost python script in /usr/bin ? Here is the screenshot of   /usr/bin:

By the way the filament version is 1.12.5.

I think if you have brew you can try brew install python, which will symlinkpython to python3.  Or you could try doing the symlink yourself.  (It's worked for me in the past.) Or try something like pyenv for something that does not require root.

I think if you have brew you can try brew install python, which will symlinkpython to python3. Or you could try doing the symlink yourself. (It's worked for me in the past.) Or try something like pyenv for something that does not require root.

Doesn't work~  However, I found the reason why filament can't be compiled successfully is PYTHON_EXECUTABLE can't be correctly identified in third_party/spirv-tools/source/CMakelist:
    COMMAND ${PYTHON_EXECUTABLE} ${GRAMMAR_PROCESSING_SCRIPT}
      --spirv-core-grammar=${GRAMMAR_JSON_FILE}
      --extinst-debuginfo-grammar=${DEBUGINFO_GRAMMAR_JSON_FILE}
      --extinst-cldebuginfo100-grammar=${CLDEBUGINFO100_GRAMMAR_JSON_FILE}
      --core-insts-output=${GRAMMAR_INSTS_INC_FILE}
      --operand-kinds-output=${GRAMMAR_KINDS_INC_FILE}


[DOC]: What is the difference between colossal.utils.get_dataloader and colossal.utils.data_sampler.get_dataloader

📚 The doc issue
(This issue is collected from user feedback)

There is no difference, check the call path and you will find that the actual call is to get_dataloader of data_sampler. the first one is exposed to the user, the specific implementation is in data_sampler.


Add block reconcile annotation

Is your feature request related to a problem? Please describe.
In our business process, we need to block the resources from reconciling, if we add an annotation as "block-reconcile": "true", the reconciler will ignore this CR.
Describe the solution you'd like
Add a if logic in reconciler, if the CR is marked as block-reconcile, ignore it.
Describe alternatives you've considered
Optional. A clear and concise description of any alternative solutions or features you've considered.
Additional context
Optional. Add any other context or screenshots about the feature request here.

@zamsong123 your enhancement is interesting, are you aware of other operators with a similar feature?

@brusdev  yes, we are user of the Confluent operator and the operator is using the feature, that is very helpful in our daily operation of the clusters (e.g. when we upgrade the clusters, we will block reconcile during the process)
and the setup is very simple: add an annotation in CR (in Confluent, it's "block-reconcile": "true")

@gtully thanks for your info, this also works,
however, if the value is already set as a semantic version, the block reconcile process will be more complex, and after unblock, we need to set the value back?
I would suggest we add a new comprehensive feature for this, I tried to make some changes and it's easy and simple, tested without issue.

great, I think we can close this issue. thanks for the feedback.

Hi, hope you are well! - I would like to provide a potential solution to this issue and present an annotation based solution on the CR for blocking reconcile.
I have this solution tested and would like to show this in a feature branch?

Hi @lishanley, sure contributions are always welcome, feel free to share your feature branch.


integrations: Separate issue milestoned events in GitHub Integration.

This PR now gives the control to the end user to opt-in for issue milestoned notifications in GitHub Integration. This is done by adding an event issue_milestoned_or_demilestoned.
It also improves the notification; now they have information related to the added/removed milestone.
Below are the sample messages:

sbansal1999 added the some_random_milestone milestone to issue #6 This is a sample issue to test GH Integration Func.

sbansal1999 removed the some_random_milestone milestone from issue #6 This is a sample issue to test GH Integration Func.

Fixes: #25793

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@zulipbot add "mentor review"

Updates:

Change the message format slightly as per this comment.

Before : sbansal1999 added the some_random_milestone milestone to issue #6.
After    : sbansal1999 added milestone some_random_milestone to issue #6.

Thanks! All LGTM.

Merged, thanks @sbansal1999!
I kinda wonder if we should be trying to work the issue titles into these notices -- the descriptions were excessive, but titles are pretty short and would often save a click to see what the changed issue was.

I kinda wonder if we should be trying to work the issue titles into these notices

@timabbott I'm not sure what you mean by this. Can you please clarify?
When the topic parameter is passed in the webhook URL the issue title is present in the message.
Sample Messages:

sbansal1999 added milestone  some_random_milestone to issue #6 This is a sample issue to test GH Integration Func.
sbansal1999 removed milestone  some_random_milestone from issue #6 This is a sample issue to test GH Integration Func.

Although when the parameter is not given the title is ignored; it's due to the fact that the title is now present in the topic name.


Close icon re-appears after drag-dropping a tab

one-dark-ui 1.10.6 on atom 1.20.1

Drag tab C, drop it on tab B, B takes C's place and its close icon appears.

This issue was moved to atom/atom#17992


Update index.md

Regions and zones.

@msftjit : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ckittel: I'm sorry - only the author of this article, @EdPrice-MSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


mola: 1.0.2-1 in 'iron/distribution.yaml' [bloom]

Increasing version of package(s) in repository mola to 1.0.2-1:

upstream repository: https://github.com/MOLAorg/mola.git
release repository: https://github.com/ros2-gbp/mola-release.git
distro file: iron/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.0.1-1

kitti_metrics_eval

No changes

mola
* Add new mola_relocalization as dependency of the metapackage mola
* Contributors: Jose Luis Blanco-Claraco

mola_bridge_ros2
* update docs
* Contributors: Jose Luis Blanco-Claraco

mola_demos

No changes

mola_imu_preintegration

No changes

mola_input_euroc_dataset

No changes

mola_input_kitti360_dataset

No changes

mola_input_kitti_dataset
* Add docs on expected KITTI dataset layout
* Contributors: Jose Luis Blanco-Claraco

mola_input_mulran_dataset

No changes

mola_input_paris_luco_dataset

No changes

mola_input_rawlog

No changes

mola_input_rosbag2

No changes

mola_kernel

No changes

mola_launcher
* BUGFIX: mola_launcher will not autoregister .so modules if installed via apt
* Contributors: Jose Luis Blanco-Claraco

mola_metric_maps

No changes

mola_navstate_fuse

No changes

mola_pose_list

No changes

mola_relocalization
* Implement SE(2) relocalization grid method
* New package mola_relocalization
* Contributors: Jose Luis Blanco-Claraco

mola_traj_tools

No changes

mola_viz

No changes

mola_yaml

No changes

@jlblancoc changes from here are causing regressions in the buildfarm. See https://build.ros2.org/view/Ibin_uJ64/job/Ibin_uJ64__mola__ubuntu_jammy_amd64__binary/
Do you see a quick fix? Else we may need to revert this PR to unblock the Iron sync. See announcement.

@Yadunund let me check it....

@Yadunund Ok, I found the actual issue is not mola, but a collision in a duplicated file shipped by both:

mola-metric-maps
mp2p-icp

I'll fix it asap and ping you in he PR.
'Unpacking ros-iron-mp2p-icp (1.3.1-1jammy.20240419.222648) ...'
08:30:38   3619 'dpkg: error processing archive /tmp/apt-dpkg-install-SP4JOE/780-ros-iron-mp2p-icp_1.3.1-1jammy.20240419.222648_amd64.deb (--unpack):'
08:30:38   3620 ' trying to overwrite '/opt/ros/iron/include/tsl/robin_growth_policy.h', which is also in package ros-iron-mola-metric-maps 1.0.2-1jammy.20240419.222647'


Improve route spec generation for controller generators

If you use the Rails generator to create a controller with some actions, it will automatically add basic routes for it. This feature would need to do two things:

Automatically add passing specs for the generated routes
If no actions / routes were specified, include our default filler message

From #1155 (see discussion)

Looks like @glittershark gave up on this? I'd be happy to take it on!

@b-lambert go ahead! As far as I'm aware we've not seen any further action on this pull request :)

I'm not sure I quite understand what the request is - rspec already generates a controller test for any route specified in the generator. What's an example of an improved test?
For example, if you run rails g controller Delete test, it generates a controller spec file with the content:
require 'rails_helper'

RSpec.describe DeleteController, type: :controller do

  describe "GET #test" do
    it "returns http success" do
      get :test
      expect(response).to have_http_status(:success)
    end
  end

end

If the test route is removed from the generated command, this is what you get instead:
require 'rails_helper'

RSpec.describe DeleteController, type: :controller do

end

What do we want instead?

@siakaramalegos I believe the idea is to generate routing specs: https://www.relishapp.com/rspec/rspec-rails/v/2-4/docs/routing-specs

Oh interesting! I'll wait a bit to see if @b-lambert picks it up.

I had actually done this (two years ago D:) but gave up when I couldn't manage to make the tests pass. Maybe I can see if I can dredge it up from a backup on whatever computer I had then

@glittershark see what you can dredge up!

@cupakromer @b-lambert @glittershark If you guys don't I would like to work on this one :)

I'm no longer working on it so it's up to @glittershark

@cupakromer This PR should cover the requested feature.
CC  @b-lambert

Seems like this issue can be closed with https://github.com/rspec/rspec-rails/pull/2134, right?


Fix the list of projects that 'develop' installs

It's "doc", not "docs".

Looks like we've caught sporadic test failures on Windows :disappointed:

Thanks


allow mutation with regex key

resolve #761
Description
allow mutation with RegExp as a key
Etc
enable downlevelIteration in tsconfig for using for .. of statement with Map iterator

I think we should handle this with the new createCache API in user-land, and provide some snippets in our docs (under advanced). CC @huozhi We should work on docs 😬.

Sorry for my poor English
Which one do you mean?

The feature doesn't need to be implemented inside library. Instead, it should be implemented in user side with createCache API
or
The feature(PR) should also support custom cache layer by createCache

hi @j-jiseophan we're working on documentation and examples with option 1 given above, by using createCache API from swr@beta.

The feature doesn't need to be implemented inside library. Instead, it should be implemented in user side with createCache API

the approach can be:

user gets returned mutate from createCache API with custom provider (can be a Map instance, or any other user preferred storage)
wrap the mutate into custom function that can receive regex or glob pattern string as keys
access keys from the provider,  detect the matching ones and schedule mutations

We'll update it into swr docs and examples later and let people acknowledged in the issue, hope these information can help close this PR.


Don't include a protocol in the base context path

What
Forcing a protocol onto resource paths causes issues when terminating SSL downstream. Just return protocol agnostic resource paths so that we can use https everywhere.

lgtm


Updated the REST & Graphql clients to allow for TypeScript typings, a…

WHY are these changes introduced?
Fixes issue #193 - Adding Typescript types for REST & Graphql API Clients.
WHAT is this pull request doing?

Added Types for all API Endpoints (extracted from the documentation site) and added namespaces for each endpoint with their individual requests.
Updated the http_client, graphql_client and rest_client to accept the use of Generics.
Updated the documentation to explain how types can easily be added to any request.
Updated Typescript version for the package (required) to make typescript path matching work for mixed types (i.e. path: products/${number} for Product.GetById)
Added a mergeQuery function that allows for merged Graphql queries, explained in the updated docs.

Type of change

[ ] Patch: Bug (non-breaking change which fixes an issue)
[x] Minor: New feature (non-breaking change which adds functionality)
[ ] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have added a changelog entry, prefixed by the type of change noted above
[x] I have added/updated tests for this change
[x] I have documented new APIs/updated the documentation for modified APIs (for public APIs)

I've completed the CLA, please re-run the checks.

Thank you for looking further into it. Let me know if I can be of any assistance in this. I've had a further look into the existing types that have been added to the package recently for each of the API versions. Currently, the types that I extracted from the Shopify.dev documentation site were based on the 2022/01 version.

+1 to this PR
Having to manually cast the body after the client returns the response is clunky, this goes a way into improving the DX around using the provided client library.

+1 we are also manually casting body everywhere

+1 for PR.
This PR would rapidly increase the DevX. Casting body is a no go.


feat(core): allow passing the index and the initial model for FieldArrayType::add method.

fix #866

This change is

Codecov Report

Merging #869 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
+ Coverage   93.51%   93.53%   +0.02%
==========================================
  Files          22       22
  Lines         940      944       +4
  Branches      264      266       +2
==========================================
+ Hits          879      883       +4
  Misses         61       61

Impacted Files
Coverage Δ

src/core/src/templates/field-array.type.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5463c3...21b59dd. Read the comment docs.


Add headers support on queue publish

What is this PR for?
Adds headers support for the queue publish command.
Partially resolves https://github.com/grafana/xk6-amqp/issues/18
Signed-off-by: Andraz Cuderman<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @acuderman! Thank you for your contribution.
If you would, please add to the example in the README to show the use of custom headers when publishing messages.


Add redirects (and update nomad deployment settings)

What

Add redirects for surveys
Restrict deployment to non-mount instances

How to review
Check redirects and nomad config
Who can review
Anyone except @ian-kent

fixed the first one, and yeah a 404 for the mystudy one is correct


missing WebXR Incubations on HoloLens Edge

Dear developer team,
I wonder why there is no inclusion of the WebXR Incubations (experimental features) on the HoloLens Edge browser.
It would be very nice to include these features from the chromium distribution. There is no possibility yet to test these features (e.g., the experimental image-tracking feature) on HMD. Do you know more about why this is not included?
Best regards,
Fabian

Thank you for the feature request.
Great news, WebXR should be enabled to use in Edge starting with September 2023 release:
https://learn.microsoft.com/en-us/hololens/hololens-release-notes#windows-holographic-version-23h1---september-2023-update


Provide default values to unbound variables

This commit provides default values to unbound variables in setup.sh.in.
This change makes source setup.sh work with set -u.

fix #904

@dirk-thomas Thank you for your review.
The error on Travis is that cmake is not installed.
And the same error occurred on master branch (https://github.com/ros/catkin/commit/df957b419939e47cf5ed017b3654f5f27fa23430).
I guess it might be related to the recent update of Trusty environment of Travis (https://blog.travis-ci.com/2017-12-12-new-trusty-images-q4-launch).

https://github.com/ros/catkin/pull/905#issuecomment-351978988

The error on Travis is that cmake is not installed.

CMake seems installed but not available from python test script.

I addressed the problem with Travis in #906. Please rebase your patch on top of the updated kinetic-devel branch to make CI pass for this PR.

tracked in #907

In the future you can simply rebase the branch of the PR and force push it which avoids the need of a separate PR.


POC for generating API endpoints using code generation, take 2

This PR is a second proof-of-concept for generating API endpoints using the Jennifer code-generation module. It generates endpoints for Brotli compression and NGWAF as examples. For NGWAF, it includes configuration-during-enablement of the 'workspace_id', and configuration of 'workspace_id' and 'traffic_ramp' after enablement.

Closing this as I've opted for a radically different approach which does not use code generation.


Provide account details in certificate provider attributes for already registered accounts

I have multiple domains on the same node, so I want to use separate ACME accounts for each domain,
but that doesn't seem possible now, since it's set as node attribute.
I can see why it's needed for private_key to be set on node so it can be registered and stored,
but for already registered accounts, it would be useful to provide separate credentials.
Would you be interested in a PR?

Why would you want to use multiple accounts for that?
I'd say it could be an optional attribute for the provider to override the default from the node attribute. Pull request for that would be welcome.

I (wrongly) assumed that account email is used in certificate info, but since that is not the case, it's not really needed.


Cosmos DB: Spark CI for Databricks pipeline

The current pipeline (java cosmos tests) involves tests for the Java SDK besides the Spark Databricks ones.
The pipeline takes several hours to complete due to the Java SDK related tests.
Spark connector, being a separate entity, does not require running all those tests, so separating them would yield a better turn around time.
This PR creates ci.spark.yml to map to a new pipeline that will coordinate Spark integration tests. The pipeline currently has 1 stage for the current version azure-cosmos-spark_3-1_2-12 but it can be extended for new versions by adding new stages with a different version parameter and reuse the same pipeline.

/azp run java - cosmos-spark – ci

/azp run java-cosmos-spark–ci

/azp run java - cosmos-spark - ci

/azp run java - cosmos-spark - ci


tracker-miners: switch to meson, some tweaks

Motivation for this change
After this commit, GNOME Music will properly display FLAC tracks.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks a lot for your thorough review! I've sent all patches upstream. LIBRARY_PATH workaround still remains, but I've opened https://github.com/NixOS/nixpkgs/issues/39547 and linked to it.

$out/share/tracker/miners/org.freedesktop.Tracker1.Miner.RSS.service probably should not be installed.

Could you please report it and add a comment with the link?

Done. Can I squash and merge this?


Add Encoder::fenced_flush_no_reset

Allows to actually use Device::fenced_submit.

Thanks!
@homu r+

:pushpin: Commit 3d635b7 has been approved by kvark

:sunny: Test successful - status


Diverging on getsentry/relay

$ git clone https://github.com/getsentry/relay.git
$ cd relay && git reset --hard 135222b7a36672bbde3be2dcbec67260e9f5de0b
$ rust-analyzer analysis-stats .

The analyzer seems to be stuck in a memory-consuming infinite loop during item collection phase. I think this has something to do with macros most likely.

Yup, I think this is the infinite loop in macro expansion, you can see this by running
$ env RA_LOG=warn rust-analyzer analysis-stats .

[WARN  ra_hir_expand::db] fail on macro_parse: (reason: BindingError("expected subtree") macro_call: __lazy_static_internal!(@MAKETY, ,(), $N);) parents: __lazy_static_internal!(@MAKETY, ,(), $N);
    __lazy_static_internal!(@TAIL, $N: : = =);
    __lazy_static_internal!(@TAIL, $N:()= $);
    __lazy_static_internal!(@MAKETY, ,(), $N);
    __lazy_static_internal!(@MAKETY, ,(), $N);
    __lazy_static_internal!(@TAIL, $N:()= $);
    __lazy_static_internal!(@MAKETY, ,(), $N);
    __lazy_static_internal!(@MAKETY, ,(), $N);
    __lazy_static_internal!(@TAIL, $N: : = =);
    __lazy_static_internal!(@TAIL, $N: : = =);
    __lazy_static_internal!(@TAIL, $N:()= $);
    __lazy_static_internal!(@MAKETY, ,(), $N);
    __lazy_static_internal!(()staticref$N:("\x00")=unwrap(););
    lazy_static!(Regex::new("\x00").unwrap(););
    __lazy_static_internal!(()staticrefNULL_SPLIT_RE:Regex= # ;Regex::new("\x00").unwrap(););
    lazy_static! {
        static ref NULL_SPLIT_RE: Regex = #[allow(clippy::trivial_regex)]
        Regex::new("\x00").unwrap();
    }

The fix here should be two-fold:

first, add a fuel so that we don't have such runaway macro expansions
then, fix the specific issue.

cc @edwin0cheng

cc #4152 , though that's closed by the author

People here keep running into this. Does anyone know if there are workarounds other than disabling rust-analyzer entirely?

I don't think there's a workaround, I'll try to look into this "soon". If anyone can come up with a reproducible example that doesn't depend on external crates, that would be helpful!

Hm, well, one work-around for lazy-static specifically is to replace it with https://lib.rs/crates/once_cell :-)

MInimized to
macro_rules! a {
    ($e:expr; $($t:tt)*) => {
        b!($($t)*);
    };
    () => ()
}

macro_rules! b {
    (static = $e:expr; $($t:tt)*) => {
        a!($e; $($t)*);
    };
    () => ()
}

b! {
    static = #[] ();
}