Declaring a contract causes "Requested contract address is not deployed"

Create a new project by following the Getting Started steps
Compile the example contract with nile compile
I noticed that I cannot setup an account using setup due to https://github.com/OpenZeppelin/nile/issues/299, because the Account contract is not declared yet.  So instead, I created a script with the following:

from nile.core.account import Account

async def run(nre):
    signer = "PRIVATE_KEY"
    account = await Account(signer, nre.network)

and ran that script with nile run <script>
4. Try to declare the contract contract with nile declare PRIVATE_KEY contract
5. The following error occurs:
🚀 Declaring contract
⏳ Successfully sent declaration of contract as 0x399998c787e0a063c3ac1d2abac084dcbe09954e3b156d53a8c43a02aa27d35
🧾 Transaction hash: 0x7217575b1175f78ff6201490887019448f5af5e20715e3513aef86d4d168112
📦 Registering 0x399998c787e0a063c3ac1d2abac084dcbe09954e3b156d53a8c43a02aa27d35 in localhost.declarations.txt
⏳ Querying the network for transaction status...
❌ Transaction status: REJECTED
🧾 Found contracts: ['0x01de4967d751b8f23da1129659357191f634c3d451a235d0dd5b2bcb9c7b1ae5:/Users/eric/git/nileproj4/env/lib/python3.9/site-packages/nile/artifacts/Account.json']
⏳ Querying the network with identified contracts...
🧾 Error message:
Requested contract address 0x1de4967d751b8f23da1129659357191f634c3d451a235d0dd5b2bcb9c7b1ae5 is not deployed.

Note that the error message's address 0x1de4967d751b8f23da1129659357191f634c3d451a235d0dd5b2bcb9c7b1ae5 is the same as the account address 0x01de4967d751b8f23da1129659357191f634c3d451a235d0dd5b2bcb9c7b1ae5 but missing a leading 0.

Additional info:
localhost.accounts.json contains:
{
  "0x7e52885445756b313ea16849145363ccb73fb4ab0440dbac333cf9d13de82b9": {
    "address": "0x01de4967d751b8f23da1129659357191f634c3d451a235d0dd5b2bcb9c7b1ae5",
    "index": 0,
    "alias": "PRIVATE_KEY"
  }
}

localhost.deployments.txt contains:
0x01de4967d751b8f23da1129659357191f634c3d451a235d0dd5b2bcb9c7b1ae5:/Users/eric/git/nileproj4/env/lib/python3.9/site-packages/nile/artifacts/abis/Account.json

thanks for reporting this. the devnet is supposed to come with the latest Account interface already declared, maybe they haven't updated it  yet.
what happened here is that since the account is not declared, it cannot be deployed nor used for nile functions (nile declare ...). but the real problem is that the deployment process is not properly catching this and registering the account nevertheless. i think this should be resolved with/immediately after the refactor in #242 which will provide a better interface to transaction statuses, including failure.
what you can do in the meantime is to use predeployed accounts:
# script.py
async def run(nre):
  accounts = await nre.get_accounts(predeployed=True)
  declarer_account = accounts[0]
  print(await declarer_account.declare("contract"))

This issue is fixed as part of #320


Note page contains link to itself in the header

Does not make much sense and adds inconvenience while trying to select text from the title.

Agree, I will get rid of this.


access feature properties in leaflet

Hi,
I have below table in postGIS , and want to get fields r,g,b in browser side.
CREATE TABLE public.cleantech
( name character varying,
geom geometry,
r double precision,
g double precision,
b double precision )
so I add query fields at end of url , but r,g,b is zero and function pbfStyle only trigger once?

var pbfSource = new L.TileLayer.PBFSource({
    url: 'http://localhost:3001/services/postgis/cleantech/geom/vector-tiles/{z}/{x}/{y}.pbf?fields=r,g,b',
    debug: false,
    clickableLayers: [],
    getIDForLayerFeature: function(feature) {
        return "";
    }
});

pbfSource.styleFor = pbfStyle;
function pbfStyle(feature) {
    var style = {};
    var type = feature.type;
    console.log(feature.properties);
    return style;
}

works with table column type is character, double has problem


bug: kcp.io is used on some of our api, should be kubestellar.io

Describe the bug
when I look at the api used in the yaml definitions for objects in our examples, I see some of our api uses kcp.io instead of kubestellar.io
Steps To Reproduce

open any example on kubestellar.io
view yaml definitions for objects like Customizer and edgeplacement
note the use of customizer.kcp.io and edgeplacement.kcp.io

Expected Behavior
would like to move to kubestellar.io for all kubestellar related apis
Additional Context
No response

@clubanderson would an example of this be replacing the edge.kcp.io api-group with a new api-group named edge.kubestellar.io?

Yes indeed. That is one of them.

@clubanderson That's a lot of changes then. Shouldn't this be a feature rather than a bug?

Well, at this point carrying partial KCP and partial non-KCP is a liability and might break several aspects of our project. We don't want to be in this mixed mode for very long if we can avoid it

@clubanderson @MikeSpreitzer Andy yes I understand, but so far the replacements have all been assigned to the edge.kcp.io api group. It's not just my stuff. I think it's all the stuff that's distinct from KCP. So EdgePlacements, etc. @MikeSpreitzer what's your opinion, bug or feature?

I'm fine with feature. To me it isn't really a difference. Either way we have to tackle it over the coming weeks and months.

@clubanderson @MikeSpreitzer Maybe I'm misinterpreting this? Do you actually mean completely severing the relationship with kcp, and replacing all xxx.kcp.io api groups with xxx.kubestellar.io api groups? Maybe I'm off base but that sounds like a very big change.

Well, that's where we are headed. Yes. We are severing our dependency and making it so Kubestellar can stand alone and can be combined with KCP as a client, but not as part of the core.

looks like there are 401 instances of '.kcp.io' in our code base across 142 files at present.  Yes, indeed, lots of work.  This is the difference between kubestellar as an opensource project that uses kcp to do interesting things that kcp could not do on its own, yet, and KubeStellar as an opensource project that does something unique and does not rely on kcp, but can use kcp, kind, kubeflex, and other kubernetes distributions in a flexible way.  I think that is the place where we want to be.  Renaming API's is not going to get us there entirely, but it is a good step in a) identifying our interdependencies, and b) replacing or renaming those dependencies over time with technology that either replaces or abstracts kcp.

this was closed with PR #901


ld: library not found for -lRNSVG-tvOS

ld: library not found for -lRNSVG-tvOS
clang: error: linker command failed with exit code 1 (use -v to see invocation)
HOW TO RESOLVE???

I believe this is resolved by using latest version of react-native-svg.


Update ocean to commit f2eba7b6fb3f68bbc-ish

This massively reduce the diff with upstream.
Our new approach use a (long) list of excluded files,
but makes the actual diff much easier to reason with.
This will also make future upgrade much simpler,
as rebases will only conflict with code we actually modified.

The diff between v5.x.x and our fork is visible here

This triggers an LDC bug. Great..

This is green at last


cannot install plugin

Failed to install 'cordova-plugin-ms-azure-mobile-apps': CordovaError: Using "requireCordovaModule" to load non-cordova module "q" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.
Failed to install 'cordova-sqlite-storage': CordovaError: Using "requireCordovaModule" to load non-cordova module "q" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.
Platform:
   Ionic CLI                     : 5.2.3
   Ionic Framework               : @ionic/angular 4.6.2
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

@nationdata-it Thank you for sharing this with us, but we haven’t tested our plugins on Ionic as Ionic is not a supported platform for us. If you add the plugin to plain Cordova app and it doesn’t work, please let us know.

I'm having the same error
Using "requireCordovaModule" to load non-cordova module "q" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.
[ERROR] An error occurred while running subprocess cordova.

        cordova plugin add cordova-plugin-ms-azure-mobile-apps exited with exit code 1.

Thanks for the clarification that it doesn't work with Ionic @jwargo
Is there any work around? I didn't realize Cordova could be used without Ionic (forgive my ignorance on this part).
Is it possible to use this plugin cordova-plugin-ms-azure-mobile-apps without the cordova-sqlite-storage component? I am really just wanting to use it for authentication, to authenticate with Azure AD.
Thank you!

I actually got this to work using "cordova": "8.1.1", per this post: https://stackoverflow.com/questions/55302204/cordova-failed-q-is-not-supported

I didn't realize Cordova could be used without Ionic (forgive my ignorance on this part).

Apache Cordova is a is a hybrid apps framework (you can read about it in one of my Cordova books: https://cordova4programming.com/) that enables you to package web apps in a native app container. Cordova has no UI capabilities at all. Ionic is a UI framework that works with Cordova - adding tooling and a UI layer to Cordova apps. Ionic built a replacement for Cordova called Capacitor.

Thank you for the response, I'll check out that book! I found a work around using an older version of cordova :) thanks again!


improved SubscriptionController

Coverage decreased (-0.8%) to 75.962% when pulling 8a17ae5f2b1e62b1958aa255b93b23ccbe15a4c1 on ljbergmann:master into d34d587ab8495ae00bbb148d6c9e7ada93465df2 on Alpha-Trader:master.


Add hashed untl elements

@ldko @somexpert
This PR adds functionality to compare two records to see if they have changed.
This addresses #25

So I don't normally recommend something like this, but I'm wondering if maybe we should also add more of an integration type test to show the comparison process from start to finish? That way we can show that something like an added space does actually get picked up as a change and is shown in the comparison results? What do you both think, @ldko, @madhulika95b?

I wonder, @somexpert, if you don't normally recommend something like this, what makes this case different than somewhere you would not recommend it? Though, I think it would be fine to add such a test.

@ldko I think it's because we don't have a function or method that pulls all the new stuff together to show the full workflow for this new functionality. Most of the time when we're adding something new, we'll have several new pieces and then another new function that calls them all, where we can check that the whole process is accomplishing the goal. But this is a bit different since the new operation is a comparison involving two objects. I don't think we strictly need to do this type of test. I think it's probably just a hangup on my part. I'd like to see an a=c test, not just a=b and b=c. But I won't press for it. I'll be fine without it.

Also to note, per the issue #25, this PR will not close out the hashed elements work; there is still more to come regarding:

After we get the basics in place we can walk through how we want to identify and communicate what has changed between two elements where we have identified change.

As @ldko mentioned, we shall continue after this PR, on tracking the changes, so we can add an integrated test there if you think we still need it then.

Yeah that's fine, we can move on and add an extra test later if needed.

I'm also fine with us closing this issue and then I can open up a new issue with clear ideas on the next steps for things.  That might be easier than just having this one hanging out without any specifics.
Whatever is easiest for you all.

I think opening a new more specific issue would be helpful @vphill . Thank you :)


App is stuck in a loop if the inventory is full

The app will run in a loop if this screen pops up:

It should exit if this screen is detected.

We'll have to check this where we check for apples

So somewhere around here: https://github.com/MathewSachin/Fate-Grand-Automata/blob/master/FateGrandAutomata.Core/AutoBattle.cs#L116

Right before this line:
https://github.com/MathewSachin/Fate-Grand-Automata/blob/5ffea3e91bdb8533356ddf63f1319ff40a9329a0/FateGrandAutomata.Core/AutoBattle.cs#L123

For now, should I implement this as an NA only thing?
@reconman I think it will be difficult for you to get your inventory full on a new account.

I have 500 inventory spaces in JP....

Someone was so nice to provide a screenshot:

https://community.gamepress.gg/t/request-screenshot-of-an-inventory-full-message/72978/3

Still doesn't work

Can you check if it is a timing problem or the region is coming out wrong using Debug mode?

Here's a video: https://i.imgur.com/LFJNlFS.mp4

I think making the region bigger should solve this problem.
It never missed on my phone. So, the reason should probably be it going off by a pixel when scaling.
And, we made that change to not match if the target region is smaller than what we want to match:
https://github.com/MathewSachin/Fate-Grand-Automata/blob/bac369a11316d806567d956b19a4b16466fb554b/app/src/main/java/com/mathewsachin/fategrandautomata/imaging/DroidCvPattern.kt#L65


Combine headers + trailers into ConnectError.metadata

As described by @jhump:

Currently, users may need to check both headers and trailers when looking for metadata in an error response for an operation with a unary reply (unary and client-stream RPCs). The reason they may have to look in two places is because where the metadata shows up isn't straight-forward - it depends on if the protocol being used and, if gRPC or gRPC-Web, whether the server used a trailers-only response or not. In a trailers-only response, all metadata would show up in the same bag of metadata (which are technically HTTP response headers, but may be classified as "trailers" since they include the status and there will be no subsequent HTTP response trailers in the reply).

This PR updates ConnectError's initialization to combine both headers + trailers into its metadata so that it's easier for consumers to query for the keys they need. This also matches connect-go and connect-es.

@eseay would you mind taking a look at this as well? 🙏🏽


ReferenceError: FilesetResolver is not defined at initializeObjectDetector

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
No
OS Platform and Distribution
Windows 11
MediaPipe Tasks SDK version
tried multiple
Task name (e.g. Image classification, Gesture recognition etc.)
Object detection
Programming Language and version (e.g. C++, Python, Java)
js
Describe the actual behavior
im trying to use this example: https://codepen.io/mediapipe-preview/pen/vYrWvNg locally but i get the error

Describe the expected behaviour
should work without errors

Standalone code/steps you may have used to try to get what you need
i tried many cdn links but none worked. this is the html: https://pastebin.com/19wSdzTF and this is the js: https://pastebin.com/9q8JNnxG

Other info / Complete Logs
No response

UPDATE i managed to fix it, prolly had made something wrong while setting it up

Hi @stojanni
can u please mention the way u have fixed it


Iai

TITLE
Description
Description of the pull request changes and motivation.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #583 (381ee9a) into main (4f36aaf) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 381ee9a differs from pull request most recent head 881323b. Consider uploading reports for the commit 881323b to get more accurate results

@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   94.83%   94.83%
=======================================
  Files          60       60
  Lines        4144     4144
=======================================
  Hits         3930     3930
  Misses        214      214

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Allow & notation to be used with constants

Right now, we support the notation X & Y, where X and Y are RVs. We should also support the notation 0 & X and t & X, where t is a TimeFunction.

0 & X is supported.
But t & X is still not supported.


enhancement safe exist

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.02 seconds
load time: 489 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221212114639_clickbench_pr_62122.html

pls add description for this patch.


missing /etc/openvpn/easy-rsa/pki directory

fatal: [2.com]: FAILED! => {"changed": false, "msg": "Error while linking: [Errno 2] No such file or directory: b'/etc/easy-rsa/openssl-easyrsa.cnf' -> b'/etc/easy-rsa/pki/openssl-easyrsa.cnf'", "path": "/etc/easy-rsa/pki/openssl-easyrsa.cnf"}

  roles:
    - role: ansible-openvpn # ansible-galaxy collection install --requirements-file collections.yml
      openvpn_directory: /etc/openvpn
      openvpn_diffie_hellman_keysize: 2048
      openvpn_mtu: 1500
      openvpn_mssfix: 1360
      openvpn_keepalive:
        interval: 10
        timeout: 120
      # server or client
      openvpn_type: "server"
      openvpn_service:
        state: started
        enabled: true

      openvpn_systemd:
        requires_services:
          - sshd.service

      openvpn_logging:
        directory: /var/log/openvpn
        file: openvpn.log
        status: status.log
        verbosity: 4
        mute: 10
        append: true

      openvpn_easyrsa: {}

      openvpn_certificate:
        req_country: USA
        req_province: Hamilton
        req_city: Eastvilage
        req_org: ACME Inc.
        req_email<EMAIL_ADDRESS>        req_ou: Special Forces
        req_cn_ca: 'Open VPN'
        req_cn_server: '{{ ansible_fqdn }}'

      openvpn_server:
        # network interface connected to internal net
        interface: eth0
        # external IP of VPN server (EIP)
        external_ip: ansible_default_ipv4.address|default(ansible_all_ipv4_addresses[0])
        # Which local IP address should OpenVPN
        # listen on? (optional)
        listen_ip: ''
        # valid: 'udp' or 'tcp'
        proto: udp
        # Which TCP/UDP port should OpenVPN listen on?
        port: 1194
        # valid: 'tun' or 'tap'
        # "tun" will create a routed IP tunnel,
        # "tap" will create an ethernet tunnel.
        device: tun
        max_clients: 10
        tls_auth:
          enabled: true
        cipher: AES-256-GCM
        user: nobody
        group: nogroup

      openvpn_persistent_pool: []

      openvpn_mobile_clients: []

      openvpn_config_save_dir: ""

      openvpn_subnet:
        ip: <IP_ADDRESS>
        mask: <IP_ADDRESS>

      openvpn_iptables:
        enabled: false

      openvpn_push:
        routes: []
        route_gateway: ""
        dhcp_options:
          domains: []
          dns: []
        sndbuf: 393216
        rcvbuf: 393216

  vars:
    ansible_python_interpreter: /usr/bin/python3

Thank @rmalenko !
I will have a look at it.
What operating system (type and version) are you using for it?

Hi @rmalenko !
I found out that the pki directory is not created in an Ubuntu distribution.
Therefore, I assume that you are using an Ubuntu.
So far this distribution has not been supported!
I have created a PR that implements this support.

Thank you a lot!

Please try the latest release!


Change end offset to use position element

e.g. String::from("") is valid because there is colon out side of
string. This commit now checks position's element.

Codecov Report

Merging #40 into master will increase coverage by 0.25%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master     #40      +/-   ##
===========================================
+ Coverage      9.09%   9.34%   +0.25%
  Complexity        8       8
===========================================
  Files            20      19       -1
  Lines           110     107       -3
  Branches         14      14
===========================================
  Hits             10      10
+ Misses          100      97       -3

Impacted Files
Coverage Δ
Complexity Δ

.../shiraji/yaemoji/domain/EmojiCompletionProvider.kt
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...moji/contributor/RustEmojiCompletionContributor.kt

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484e12c...738a5ad. Read the comment docs.


screenshot GUI button doesn't always work?

seems to be taking screenshot, but not sure where they are getting written to

fixed by 34cee3a55434ec43c2e94f916103eb26c161bcfb


Add packet multiplexer.

contributes to fixing https://github.com/dotnet/SqlClient/issues/593
Background
Asynchronous reads in this library use a retry mechanism. A context object is created a snapshot of the current state object is taken and the process of reading the data begins. As each data packet is received the packet data is appended to a list of packets, the state object is reset to the snapshot and all of the packets in the list are read from the first to the last. There can be two outcomes of the processing and specified by the return values allowed from the parsing functions that are used to read the data, success or failure. If the process fails without causing an exception the snapshot state is restored and more data is requested and it goes around again.
The complexity of this method is factorial because every packet must be processed once a new packet is received. This makes the time required to fetch a any data which spans multiple packets is factorial with N depending on the number of packets required to contain the data. A 20Mib string using the default packet size of 4K occupies over 2500 packets. Large amounts of time and computation resources are expended copying the same data over and over gain.
Parsing Changes
This PR changes all parsing functions so that they no longer return bool and now return a TdsOperationStatus enum value. This is modelled after the System.Buffers.OperationStatus but omits one value that we don't need.
internal enum TdsOperationStatus : int
{
    Done = 0,
    NeedMoreData = 1,
    InvalidData = 2
}

Every parsing function which calls another now checks for Done indicating success and if the value is not Done the result of the call is returned.
This means that an example callsite like this:
if (!TryReadTwoStringFields(env, stateObj))
{
    return false;
}

changes to this:
result = TryReadTwoStringFields(env, stateObj);
if (result != TdsOperationStatus.Done)
{
    return result;
}

This accounts for the bulk of the changes in this PR. These changes allow safe detection of the third state at the end of the packet replay, the state where more data is needed.
Snapshot Changes
With the ability to detect when a snapshot can continue functionality has been added to the snapshot mechanism which allows a continue point to be saved. When a snapshot is active and the parsing functions run to the point where all packets have been processed end at a rsult of NeedMoreData the current state of the stateobject can now be saved as the continue point. When as new packet arrives and the replay is about to be started instead of going all the way back to the starting point we can now pick up from the continue point and avoid a lot of reprocessing.
To allow us not to need to reprocess all the packets up to the continue point the existing plpBuffer saved in the snapshot is augmented to store the total amount of data that has been written into the temporary buffer so that new data can be appended to the buffer at the correct point.
Snapshot changes and support for them account for most of the non-parsing changes in the TdsParserStateObject files.
Reliability
With all these changes performance of async reads improves to scale similarly to synchronus operations. Reliability is vastly reduced with random seeming errors occuring regularly during testing making it impossible to finish any lengthy benchmark run. Investigating this took several months and showed an underlying incorrect assumption in the networking handling code which was difficult to encounter in previous versions of the library because speed was limited by the replay mechanism.
The TryProcessHeader function makes sure that enough data is available to contain the packet header. Once that data is available it extracts the spid, status and packet length from the header. Crucially it does not check that the number of bytes received from the network matches the number of bytes that are in the packet. The code trusts that the buffer that we passed to the sni layer now contains the number of bytes reported by the packet header. This is not always true. This is observable in managed and native sni modes.
In situations where 1) there is some latency 2) the code is able to run very fast (meaning not debug mode), 3) enough data is being trasferred that a rare event can happen, it is possible to observe events where a part of a packet is received which contains the header data but not the complete rest of the packet. In this situation the existing code can react in many ways depending on the exactl location of the end of the correct data in the packet. Most of them produce an error condition but it is possible that some zero data could be copied into the pllBuffer. On the next packet recepit the remainder of the partial packet will be recieved, it will not contain a correctly formed packet header and will cause an exception.
Partial Packet Changes
Code has been added which detects the receipt of a partial packet and stores the data. The partial packet is set aside and another network read is initiated. Once the second read has completed the newly received data has to be combined with the existing partial packet. It is possible that the newly received data will contain the remainder of the partial packet data that we already hold and if there is more data being sent it can contain the start of another packet. To deal with all the complexity involved in sorting out the packets i have added a packet multiplexing function which reconstructs correctly formed packets from the incoming data and partial packet that are held and then releases those packets for the library to deal with normally.
Once a partial packet has occurred it is not possible to get back into sync with full packets unless another partial packet read of exactly the remainder number of bytes occurs. This is very unlikely. Sync will only return once the existing response stream has completed.
the multiplexing function has full test coverage by being split into a separate file which is then included in the functional tests with a test harness allowing fake packets sequences to be constructed processed and the results validated.
Outcome
All of these changes result in adding the ability to use the use of an appcontext switch to turn on async with continue mode. The library defaults to async-retry mode which is the current method of operation. If we can validate that the changes are reliable and mergable in retry mode then we can turn on continue mode and validate that functionality.
The changes applied to net(core) and netfx builds. I originally stated that i did not want to do this because I thought that we should merge the codebases and implement the changes only once. Realistically the rate of merging of the codebase in the time since I made that decisions means that this bug would not be fixed for more years. So I've changed my mind and implemented everything again on the current codebase.
Performance changes are inline with previous expectations:

BenchmarkDotNet v0.13.12, Windows 10 (10.0.19045.4529/22H2/2022Update)
Intel Core i9-9900K CPU 3.60GHz (Coffee Lake), 1 CPU, 16 logical and 8 physical cores
.NET SDK 8.0.302
  [Host]     : .NET 8.0.6 (8.0.624.26715), X64 RyuJIT AVX2
  DefaultJob : .NET 8.0.6 (8.0.624.26715), X64 RyuJIT AVX2

Method
UseContinue
Mean
Error
StdDev
Gen0
Gen1
Gen2
Allocated

Async
False
1,980.28 ms
25.645 ms
22.734 ms
6000.0000
3000.0000
1000.0000
101.49 MB

Sync
False
64.00 ms
0.135 ms
0.126 ms
750.0000
750.0000
750.0000
60.04 MB

Async
True
72.58 ms
1.394 ms
1.549 ms
6285.7143
3714.2857
1142.8571
101.49 MB

Sync
True
63.37 ms
0.167 ms
0.148 ms
750.0000
750.0000
750.0000
60.04 MB

Speed of async operations in retry mode are unaffected.
Speed of async operations in continue mode are slightly slower than sync and have roughly the same memory profile as adync in retry mode
Speed of sync operations is unaffected.

Feedback
If you think that there is a better way to do this then please implement it and open a PR allowing your method to be tested. In all the time that this issue has been open no-one else has come up with any other method of fixing it. If you don't like how this works do better please don't just complain and nitpick.

@ErikEJ is there any chance you you could pick up the ci artifact (or compile your own version) of this PR and run any EF type testing you do on it? The more realistic scenarios with the capacity for network latency I can get the better I'll feel about it.
@panoskj you're knowledgeable about the async machinery. Could I ask you to have a look at the code changes and give a general opinion? I know there's still some cleanup to do so no need to nitpick style/naming.

@Wraith2 Sure, but exactly what are you asking for? Test timing, failures? The EF Core tests run against a local engine by default.

Test failures primarily, test timing would be interesting particularly async strings. Even locally partial packets can happen if your machine is capable of running both test and server fast enough.

@Wraith2 Could you point me to the artifact location?

probably....
yes, https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=91816&view=artifacts&pathAsName=false&type=publishedArtifacts
always have problems finding this stuff
If you find then click on the item which is just "CI-SqlClient (Build NuGet) ", then from there click on the link on the right hand pane "View more details on Azure Pipelines" it'll take you to the build log and there is an underlinked "artifacts" link. the Artifacts entry in the list on the next page is the zip with the nuget packages in.

I didn't realize the artifact experience was different for anonymous users. This is unfortunate.
Anonymous view:

Logged in users can expand the artifact folders:

I don't see a way to change it. 😞

@David-Engel Not a problem, I can just download the whole artifact.zip

Meh
EFCore.SqlServer failed with 1 error(s) (12,9s)
error CS8002: Referenced assembly 'Microsoft.Data.SqlClient, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have a strong name.

Odd that it wants a strong name. Is that net8?

Odd that it wants a strong name. Is that net8?

CI pipelines are currently not generating StrongName as packages are not signed. For local testing you can use delay signed, but that will need a snk file.

Odd that it wants a strong name. Is that net8?

CI pipelines are currently not generating StrongName as packages are not signed. For local testing you can use delay signed, but that will need a snk file.

So how are we supposed to test things outside the CI? This seems like an unhelpful restriction.

This is ready for review now. It fixes a long standing performance issue and a reliability issue which users may have been facing but would be almost impossible to trace. Can this have some review priority please @David-Engel ?

FYI: @saurabh500 @cheenamalhotra @mdaigle @benrr101

@Wraith2 If you merge from main, CI should be able to run cleanly now.

Rebased.

It looks like there is a bug somewhere that is causing intermittent failures in MoveToContentAsyncTest. 6 of the CI jobs hung on that test, causing the job to timeout (example), and 1 failed on CancelAsyncConnections. I re-ran the failed jobs and they may pass, but there's definitely an issue there.

There was a bug that I worked through and resolved on saturday. It was stopping the multipacket test completing on netfx.
The failures I saw after that looked like infra issues. I'll wait on the CI completing and look at any errors that occur.
This PR requires careful review and the CI coverage alone isn't going to be sufficient. It'll need some big chunks of data to be run through it to validate that it is steady under sustained load. Both in the default/current retry mode and in the experimental continue mode. The combination of running the consuming process fast and having some latency on the network is needed to make the partial packet recombination kick in.

The same two tests are still showing intermittent hangs (MoveToContentAsyncTest) and failures (CancelAsyncConnections) in the CI on managed SNI on Windows and Linux.

I think the tests are bad. If I run them in debug mode I will always get an exception created (not thrown) related to an ERR_DONE status code from the server. If I run the tests through the test explorer they succeed. Every time. I think the error being created is somehow hidden or ignored in the normal running of the test and you can only see if if the timing is disturbed. That would explain why it only happens on some runs.

Can I get some code review please. I'm sure everyone is busy but this isn't a PR that I want to spend the next 6 months keeping up to date with main.
/cc @saurabh500 @cheenamalhotra @mdaigle @benrr101

@Wraith2 we dont intend to make you wait for 6 months. This PR is valuable to us.
Please allow us sometime. We are trying to line up the effort for JSON support, which has a lot shorter runway and lot of work involved.
I will post comments as I go over the PR.
I have been looking at it and have spent time on it. But in all honesty I don't understand the full picture as well as you do. So it's a matter of re-learning some stuff I have forgotten, putting your PR in perspective so that I don't waste anyone's time with wasteful comments.

If you'd like a teams call to discuss it just let me know. I can probably still talk people through most of the changes effectively. As you can appreciate the longer it takes the harder it will be to remember.
Hopefully if continue mode can be enabled it will help performance with json support in async mode.

Thats a good idea.
Do you want to email me? [firstname].[lastname] @ microsoft.com
My profile for my first and last name. I will delete this message after you acknowledge reading it with some kind of reaction on the comment.
We could setup time over email. Also it will be great to catch up.

also @Wraith2 JSON is a good point. It relies on PLP data, which follows varchar(max) read patterns.
XML will also improve automatically.
I have some hidden gems for perf improvement in these areas. Will need more help with allocations. I will open some discussions and tag those problem areas.

Hidden gems? I'm intrigued. I thought I'd got almost as much performance from the driver as I could in many places.
Email sent.

@Wraith2  for other things I would like to take the conversation to this discussion. https://github.com/dotnet/SqlClient/discussions/2672

@Wraith2  Do you have the test names handy for the tests that are hanging in the CI?
I can go look in the CI later, but if the information is readily available, it would be good.

MoveToContentAsyncTest and CancelAsyncConnections as David mentioned earlier in the discussion. I'm very suspicious of MoveToContentAsyncTest for reasons cited above.

Thanks. I will read through the test code. Sorry completely missed the mention of the test names

@cheenamalhotra  @Wraith2  and I met over a teams call. Thanks for offering to bring us to speed.
Following are the decisions and next steps:

SqlClient project would definitely benefit from this PR. And we want to take steps to take the changes.
There may be a chance (inspite of thorough code reviews), that this PR may break some functionality in SqlClient, due to the inherent complexity of the code. In those cases, we don't want to revert the commit, but instead be able to help customers go back to unchanged behavior without code change, and we want to reduce cognitive complexity of review of this PR. At the same time, we want to bisect the changes so that we can look at the relevant changes in isolation while debugging support issues.
The PR is in the right direction, and has sound technical foundation.

Next steps:

Breakdown this PR in at least 2 parts. This PR should be left open, and will be a reference PR.
1.1. Bring in the Tri-state instead of a boolean return. Essentially bring in internal enum TdsOperationStatus and incorporate its usage. This means that the true gets replaced by the value Done and false is replaced by InvalidData. This will be a very low risk change, but will account for most of the lines of code modified.
1.2. Bring in the functional changes of packet multiplexing and continuations.
1.3. The changes in 1.2. will be enabled by default. However, App Context switches will be added to disable the behavior in a customer faces issues due to the changes.

@cheenamalhotra has offered to look at the failing tests to understand what is going on. Based on her investigation, we may have additional decisions taken.

@Wraith2 has offered to break this PR down in the above-mentioned logical PRs.
Also @Wraith2 the Packet class can use some summary docs, along with new methods, even though these are internal. You took an hour to explain your thoughts to us and you took a few months debugging and formalizing this approach. It would help to have some Property/method/class summary docs to capture how you have modeled these types/methods etc.
@Wraith2 @cheenamalhotra let me know if I have faithfully captured the outcome of our discussions. Else please comment with edits/additional comments.
I am looking forward to subsequent PRs and moving this effort to completion.

Part 1 posted in https://github.com/dotnet/SqlClient/pull/2690

If you really want to. There is still part 3 to come. Waiting for conclusion on part 2.

No worries, we can keep this open, while all changes are extracted.


Change remaining len() call into input_len() in multi.rs

This should fix https://github.com/fflorent/nom_locate/issues/8
I assumed that it's an oblivion from this commit:
https://github.com/Geal/nom/commit/b13eb4e06623c9991bf3f803c6b856651ca187e5#diff-14efff2f3aefda9c3e6c71ed4a391280R80
If not, don't hesitate to reject the PR :).
Cheers!
Florent

Coverage remained the same at 87.092% when pulling 47ec4ef6847f553f74be3c5442d2a731c2245336 on fflorent:master into 3dd66729973f4ade748cfb2f2a4b49e0583e1aae on Geal:master.

good catch, thanks!

Thanks Geal!
Florent


Unable to open a notebook, getting error `Cannot read property 'Code' of undefined

Version: 1.54.0-insider
Commit: 5e74ad5430203eadf89fd8e99695f4ebdb0e62ad
Date: 2021-02-16T10:28:35.712Z
OS: Darwin x64 20.3.0

Steps to Reproduce:

Use Jupyter Extension
Update to the latest notebook API (fyi - this is still WIP)
Open a notebook & you get an error message popping up Unable to open 'abcd.ipynb': Cannot read property 'Code' of undefined
FYI - This worked in the last insiders, on Friday. The latest insiders seems to break this.

@rebornix @jrieken /cc

Does this issue occur when all extensions are disabled?: Yes/No

FYI - the content provider is returning the necessary information.

Noticed the proposed API has changed today, will update and check again.


Fix for issue #56.

If a StarPort's desired position overlaps another port, adjust the desired position. Simple solution for now, can improve if desired.

Can one of the admins please verify this patch?

@GooeyHub ok to test

@GooeyHub: ok to test
@Rulasmur: added you to the admin list in Jenkins, should work now :-)
@askneller: thanks!

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/DestinationSolPRs/22/
Hooray Jenkins reported success with all tests good!

Tested out and merged! Didn't think I'd be able to easily replicate a situation where starports would have overlapped (seems rare) but the second world I tried placed a pair about as close together as could be without overlap, so I'm thinking that might have been a "fixed" pair :-)
Also to my surprise while testing ran into two big boss ships right by a station - and they killed it ! Whole station popped and dropped more loot than I've ever seen. I didn't think they were destructible!
Then the bosses proceeded to murder me quite thoroughly in my newbie ship.

Sorry probably should have said in the pull request, if you seed the RNG with the long 8 it will place two starports over each other near one of the planets.


RFC: Emacs 27 derivation

Motivation for this change
Emacs 27 has a few desirable changes, like early-init.el and a native json parser (50x speed up). Unfortunately, it won't be released for a few months minimum, probably a year. I need help testing emacs, as it is so big. I also haven't checked if there any new compile options, etc, etc. This is all pretty overwhelming, so if you spot anything please let me know.
I am also wondering how we should version the release, because at a guess we can't ask for master revision because the sha256 will fail. Right now my plan was to just periodically update the rev and sha, but there's gotta be a better waaaaaaaaaaay.
You can build it with nix-build -A emacsHead
Changelog: https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I am also wondering how we should version the release, because at a guess we can't ask for master revision because the sha256 will fail. Right now my plan was to just periodically update the rev and sha, but there's gotta be a better waaaaaaaaaaay.

Perhaps you could do something similar to https://github.com/colemickens/nixpkgs-wayland

This version of clean-env.patch applies on emacs master:
Dump temacs in an empty environment to prevent -dev paths from ending
up in the dumped image.

diff --git a/src/Makefile.in b/src/Makefile.in
index fd05a45df5..13f529c253 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -570,7 +570,7 @@ emacs$(EXEEXT): temacs$(EXEEXT) \
                 lisp.mk $(etc)/DOC $(lisp) \
                 $(lispsource)/international/charprop.el ${charsets}
 ifeq ($(DUMPING),unexec)
-	LC_ALL=C $(RUN_TEMACS) -batch $(BUILD_DETAILS) -l loadup --temacs=dump
+	env -i LC_ALL=C $(RUN_TEMACS) -batch $(BUILD_DETAILS) -l loadup --temacs=dump
   ifneq ($(PAXCTL_dumped),)
 	      $(PAXCTL_dumped) emacs$(EXEEXT)
   endif

And as a quick aside, this expression works without duplicating the entire file:
{ pkgs ? import <nixpkgs> {}
, lib ? pkgs.lib
}:

let
  rev = "dfb0ba79b5f41ca6fed25a03d2a5cd6996ec4753";
  sha256 = "0cr8mlcxyib4rd8xj65hb1wxwlmppgg4823z7h3dbbxi273gz5b0";

in (pkgs.emacs.override { srcRepo = true; }).overrideAttrs(old: rec {
  name = "emacs-${version}";
  version = builtins.substring 0 7 rev;

  src = pkgs.fetchFromGitHub {
    owner = "emacs-mirror";
    repo = "emacs";
    inherit sha256 rev;
  };

  patches = [
    ./clean-env.patch
    (lib.elemAt old.patches 1)
  ];

})

FYI I've pushed an auto-updating emacs to mine and @etu`s overlay https://github.com/adisbladis/exwm-overlay.

@ar1a I'd actually like to close this PR, if a user wants bleeding edge emacs we now have the emacs overlay: https://github.com/nix-community/emacs-overlay.

works for me
On Fri, Nov 1, 2019, 10:07 PM adisbladis<EMAIL_ADDRESS>wrote:

@ar1a https://github.com/ar1a I'd actually like to close this PR, if a
user wants bleeding edge emacs we now have the emacs overlay:
https://github.com/nix-community/emacs-overlay.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/65300?email_source=notifications&email_token=ACALSJ7ERB3P45PALOKAF5LQRQEX7A5CNFSM4IGDVO7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC2UOIQ#issuecomment-548751138,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACALSJ3UNOHXNDNUHWETT5LQRQEX7ANCNFSM4IGDVO7A
.

No love in emacs-overlay for macOS users :(

@rcorrear I happily accept patches for macOS in the overlay.
If you are thinking about emacsMacport upstream ( ftp://ftp.math.s.chiba-u.ac.jp/emacs/ ) does not yet have a mac port for Emacs 27.

@adisbladis I was hoping no one would comment before I was finished building it, but I'll take back my comment, I didn't understand overlays well enough :)
Took me a little while to figure out how to use them since the instructions (in your repo and almost everywhere else I found) are more tailored to NixOS users but not for (standalone) Nixpkgs users (which is what you get in macOS).
If I do find anything I can contribute to emacs-overlay I will, I'm slowly learning about Nix and overlays are something I just came across.
And yeah, I'm aware of emacsMacport not being ported yet to Emacs 27. Thanks for pointing that out though.


Optionally include JSON directly in state parameter.

This PR adds an optional argument (public_data) to createSigninRequest and a function (getCallbackPublicData) to OidcClient. Together these changes allow users to include JSON directly in the state parameter without relying on browser-side storage or knowledge of callback type. This is needed if the user handles callbacks from a different origin. This PR does not allow arbitrary state encoding.
To preserve backwards compatibility, the behavior of oidc-client only changes if public_data is given.
Alternatively, a setting could be added to give direct control of the state parameter's exact value. I decided against this because the dependence of *Request and *Response on the client settings greatly complicated the class structure of the library. I believe that public_data solves the problem without sweeping modifications.

This would mean the nonce is also round tripped via the state param?

No. This does not override the browser storage. It binds additional data to the state. For example, if I provide public_data='foo', the redirect uri will have state={"id": abcde, "data": "foo"} instead of state=abcde.

So then how would nonce be read if your redirect uri is cross domain?

In our particular case, we have a single endpoint for all OAuth2 callbacks from all of our various origins. We can redirect the user to the correct domain before firing the relevant oidc-client callback method but we need to do some work before then. The parameters have to be included in the state parameter somehow, so I came up with this PR.
Its a bit of an obscure use case, I admit. I think a more general process for custom state encoding might be preferable but it complicated things a lot.

In short, this doesn't change the overall operation of oidc-client. It does give users the ability to talk to middlemen between signin/out and callback.

@brockallen Ping. Does this make sense?

I'd need to understand it better. I'll review the PR when I have time (but it's not anytime soon, sorry).

I started to look at this. I don't quite follow the intent. Also, this statement:

This is needed if the user handles callbacks from a different origin.

Makes me really uncomfortable. Trusting custom state cross-origin is not a security hole I want to open in this library.

Closing since we won't be doing this. Thanks.


ACF-12 # update to<EMAIL_ADDRESS>

update dependency
bump version number for npm

I tend to bump the package version in the same commit that I update the CHANGELOG.md. And what I put in the change log is what I copy-paste into the GitHub Releases area.
The other thing I've noticed here is the SemVer version range permitted for @jokeyrhyme/appcache-fetcher. My current thinking is:

always have permissive version ranges for devDependencies e.g. "^1.2.3"

packages that are libraries should also be permissive

to avoid having multiple compatible versions of the same dependencies being installed

it's also more convenient for us and anyone using the library

packages that are the deliverables themselves (e.g. HTTP services, CLIs, etc) like this package should be strict e.g. "1.2.3"

so that it's easier for us to reproduce bug reports, because we'll be installing exactly what the user installed

That said, I haven't investigated npm shrinkwrap, and perhaps that is what we should be using to cover the reproducibility angle. /shrug
Also, I've restarted the AppVeyor builds multiple times now and they always fail. Not sure what to do there. Maybe we should just disable AppVeyor?

As always, this is very much a discussion. I'm not saying you MUST change anything you've done here first. Just that there are a few things we SHOULD consider together.

makes sense, I'll make the changes and resubmit

LGTM 👍
You cool with tagging, pushing the tags, and publishing to NPM?

yeah sure


xpd cycle 2 2018

I have one more on the way but I'll most likely get it in first thing tomorrow.

Attn: @chiahaoliu

I think this is ready to go! @licode @mrakitin

Looks good to me, thanks.

@CJ-Wright, any ideas?

What version of conda build are you using?

Tried 3 times on different machines, same failure.
Conda build's version is conda-build-3.1.6


Bugfix/pint optional dependency

Make 'pint' a truly optional dependency.
Previously, import pdtable would fail when pint wasn't installed.
Now it doesn't fail. To achieve this, I had to drop the idea of a convenience top-level pdtable.pint_converter singleton instance of PintUnitConverter, as this necessarily triggered an import of pint, which would fail. Maybe there's a way to offer such a singleton without triggering the import eagerly, but I'll have to punt that to later.
Also, the optional dependency behaviour is now tested, by mocking the disappearance of 'pint' and 'openpyxl', respectively.

In the interest of getting this bug fix published ASAP, I'm going to merge this right away. It's currently blocking the creation of a conda-forge feedstock.


starting account support

add account support so users can track what they have read.

since google uses profile firstname, should use google as after thought and make username and pass default.


:seedling: Fix some typos

Signed-off-by: Zou Yu<EMAIL_ADDRESS>

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/ok-to-test

/test-integration

/cc @kashifest


TabView brushes update

Description

This PR only updates the brushes used in TabView.
Separate PR will come with the rest of layout updates.
How Has This Been Tested?

Manually.
Screenshots (if appropriate):

Will attach them in a bit.

/azp run

would be nice to have screenshots/short video

Currently, TabViewHeaderPadding is set to 8,8,4,0, which causes the rightmost corner to be cut. Maybe it could be fixed in this PR.
Also, the effective left padding is 7 because all tabs are moved 1px to the left, so it should be 9,8,8,0 to look equal.

@ranjeshj yes, I'll do that :)


Issue 1281: Vividus integration

https://github.com/jdi-testing/jdn-ai/issues/1281

please fix codacy issues

please fix codacy issues

All of these issues were from the legacy code, not mine.
I’ve fixed almost all of them, but now the only issue is left which seems to be a discrepancy between codacy and our linter settings (which is strange because it should apply our linter rules). So I believe we just need to fix settings.

LGTM, давай мерджить и начинать релиз :)


Bug report: Use CLI programmatically -> "login --authType password" -> Command not found

Description
I want to execute the "login" command programmatically, with --authType password - unfortunately, I get a message that the command was not found.
Steps to reproduce
const { executeCommand } = require('@pnp/cli-microsoft365');

const username = 'YOUR USERNAME'
const password = 'YOUR PASSWORD'
executeCommand(`login --authType password --userName ${username} --password ${password}`, { output: 'text' }).then(res => console.log(res)).catch(e => console.log(e))

Expected results
Successful login
Actual results
Command not found: login --authType password --userName XXX --password XXX
Diagnostics
No output
CLI for Microsoft 365 version
5.2.0
nodejs version
15.7.0
Operating system (environment)
macOS
Shell
bash
cli doctor
{   stdout: 'authMode       : Password\n' +     'cliAadAppId    : 31359c7f-bd7e-475c-86db-fdb8c937548e\n' +     'cliAadAppTenant: organizations\n' +     'cliConfig      : {}\n' +     'cliEnvironment : \n' +     'cliVersion     : 5.2.0\n' +     'nodeVersion    : v15.7.0\n' +     'os             : {"platform":"darwin","version":"Darwin Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64","release":"20.6.0"}\n' +     'roles          : []\n' +     'scopes         : ["AllSites.FullControl","AppCatalog.ReadWrite.All","ChannelMember.ReadWrite.All","ChannelMessage.Send","ChannelSettings.ReadWrite.All","Directory.AccessAsUser.All","Directory.ReadWrite.All","Group.ReadWrite.All","IdentityProvider.ReadWrite.All","Mail.ReadWrite","Mail.Send","Reports.Read.All","Tasks.ReadWrite","Team.Create","TeamMember.ReadWrite.All","TeamsApp.ReadWrite.All","TeamsAppInstallation.ReadWriteForUser","TeamSettings.ReadWrite.All","TeamsTab.ReadWrite.All","TermStore.ReadWrite.All","User.Invite.All","User.Read.All","profile","openid","email"]\n',   stderr: '' }
Additional Info
No response

Sorry for the trouble, and I appreciate you reaching out to us. We'll see if we can reproduce it asap, and we'll get back to you as soon as we know more.

Looking closer at your code, you're passing the command and its arguments as a string. If you look at the documentation of the executeCommand function, you can see that the first argument should contain only the command name, and the second argument is an object of key value pairs with options.

@waldekmastykarz Thank you very much for your reply, it's appreciated!

My pleasure!


SPIKE: Develop a pattern for preventing teams from doing irreversible expensive actions

Describe the issue
Teams are asking for things like reservations because reservations allow much cheaper usage rates. The problem with reservations is that they can be expensive and are essentially permanent. We wish to create a barrier that prevents teams from performing these kind of actions while allowing Cloud Pathfinder to perform these actions for them.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context

Stu and Gen are working on the financial implications of reserved instances wrt financial thresholds

Definition of done

Create a set of well-defined tickets with a technical solution

We are not pursuing Reserved instances at this moment. A new ticket will be created if this changes.


pipelines: JIRA data provider/plugin connection test failed

Describe the bug
It appears that the JIRA Data Provider is providing a Failed Connection Test even though the Authentication credentials used are properly generated per DevLake README instructions. This maybe specific to development environment or local database state.

Please verify if the token worked with tools like postman first.

@klesh Will conduct a Postman test to verify.


Chart Editor Memory Leak

Describe your bug here.
The memory goes up alot if you scroll in the chart editor for some reason
It also just goes up over time
https://user-images.githubusercontent.com/49110074/186961957-abcae473-f0c4-4205-817e-ee839c6af75d.mp4
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no because i'm not using source

Disable vsync from your driver settings

disable vsync on your GPU driver settings
alternatively, it's a flixel problem, as scrolling through grids increases memory, even on the base game

disable vsync on your GPU driver settings
alternatively, it's a flixel problem, as scrolling through grids increases memory, even on the base game

I have intel integrated graphics, where do i change this

how does disabling vsync fix a memory leak in the charter what

i literally don't even have an option to disable vsync, also i agree with leather

It's either a haxe or driver issue, it just doesn't like vsync on
It also doesn't just affect charting

but why is the actual allocated memory of the game affected by a gpu driver of all things?

I don't get how it would be a driver issue
It seems more likely that it would be a flixel issue (which would be stupid)

but it would make more sense

It seems more likely that it would be a flixel issue (which would be stupid)

grids just take THAT much memory, so much so that Kade Engine had an option to hide the grid

It seems more likely that it would be a flixel issue (which would be stupid)

grids just take THAT much memory, so much so that Kade Engine had an option to hide the grid

I find it strange that HaxeFlixel has troubles with a grid of 2d pixel squares

it renders and updates said grid every single frame, that's why it uses that much memory

That's a weird issue (the vsync thing you guys said)

I have no idea why it happens, the reason I suggest it's a driver issue is because this only started happening to me after some recent AMD updates, it worked fine with vsync on before them


a cascade replication slave  did not sync data as expected by redisShake

My preperation
There are three redis instance:redis:6379 redis:6380 redis:6381.Redis:6380 is the slave of redis:6379, and redis:6381 is a normal master-role instance.In addition my redis version is 5.0.7.
I want sync  redis:6380 db0 to redis:6381 db1 by redisShake，so I configed  target.db = 1,source.address and target.address and so on.
source.address = <IP_ADDRESS>:6380
target.address = <IP_ADDRESS>:6381
target.db = 1

My operation
Then I started redisShake like :
 nohup  ./redis-shake.linux -conf redis-shake.conf -type sync &

The process didn't have any problem util full sync. But when an incremental sync started , I set a key in redis:6379 db0 .
<IP_ADDRESS>:6379> set water 123

Then I found the key was writen in redis:6381 db0 not as I expected in db1.

<IP_ADDRESS>:6381>  info keyspace
# Keyspace
db0:keys=1,expires=0,avg_ttl=0
db1:keys=1,expires=0,avg_ttl=0
<IP_ADDRESS>:6381> keys *
1) "water"

The reason why the target.db isn't work is that in cascade replication, the proxy redis which also means the redis:6380 won't replicate the select command to the downstream. But in master-slave scenario, the select command will be produced.
This bug has been fixed since v2.0.2, please checkout and retry. Let me know if you have any questions.

I have already made a test , and it worked.
Thanks.


Implement RFC 10: Move Repl to Value.replicate

RFC text

[ ] Add Value.replicate

[ ] Update documentation

[ ] Deprecate Repl in 0.4
[ ] Remove Repl in a later version

o/ Would be happy to put together if desired.

That would be great!

Sweet, on my list for tomorrow! ✌

This wasn't actually completed--Repl is still there in main.


Smath v1.9.2

I realize I probably could have done this at the same time as #129 , since t6 is a devDependency. Oh well, try again next time.

Yes - my theory was correct. You can publish dependent-packages, as long as A is a DEV dependency of B. The reason? In the examples, you do an npm install. That only installs the package itself and dependencies. (It doesn't care about dev dependencies.)


Can i use useRef in react-chessboard?

i tried using the clearPremoves() function but it said chessBoardRef is not defined although i defined it properly.
  useEffect(() => {
    const handleOutsideClick = (event) => {
      console.log("Event target:", event.target);
      console.log("Chessboard ref:", chessBoardRef.current);

      // Check if board exists
      if (chessBoardRef.current) {
        console.log("Chessboard ref is valid");
      } else {
        console.log("Chessboard ref is null or undefined");
      }

      // Check if the target is inside or outside the board, buttons, or aside elements
      if (
        chessBoardRef.current &&
        !chessBoardRef.current.contains(event.target) &&
        !event.target.closest("button") &&
        !event.target.closest("aside")
      ) {
        console.log("Clicked outside chessboard, button, and aside");

        // Check the board width condition
        if (boardWidth < 700) {
          console.log("Board width is less than 700, clearing premoves");
          chessBoardRef.current.clearPremoves();
        } else {
          console.log(
            "Board width is greater than or equal to 700, no premove clearing"
          );
        }
      } else {
        console.log(
          "Clicked inside chessboard or ignored element (button/aside)"
        );
      }
    };

    document.addEventListener("mousedown", handleOutsideClick);

    // Clean up event listener
    return () => {
      document.removeEventListener("mousedown", handleOutsideClick);
    };
  }, []);```

please provide a full minimum reproduction, this code does not provide enough information to work out what is happening

closing due to no activity