[BUG] remove duplication between _distutils.sysconfig and stdlib sysconfig

setuptools version
Any
Python version
Mainly PyPy, but implementing this would benefit the entire ecosystem
OS
Any
Additional environment information
No response
Description
Over at PyPy, we extend the sysconfig._INSTALL_SCHEMES, exposed from sysconfig as get_scheme_names(), get_paths() and get_path(), with implementation-specific schemes. Copying the changes to distutils/command/install.py failed, as evidenced in issue 3436. While we can make our changes work via something like PR 817 I think it would make more sense to remove the duplicate code.
Expected behavior
Code in sysconfig should not be duplicated in distutils
How to Reproduce
The minimum reproducer is to create a setup.py and then call it with develop --user which fails on PyPy. Here is a Dockerfile that will error out:
FROM pypy:3.7-7.3.4-slim

RUN echo 'from setuptools import setup; setup(name="foo", packages=[])' > setup.py

RUN pypy setup.py develop --user

Output
Traceback (most recent call last):
  File "/opt/pypy/lib-python/3/distutils/util.py", line 192, in subst_vars
    return re.sub(r'\$([a-zA-Z_][a-zA-Z_0-9]*)', _subst, s)
  File "/opt/pypy/lib-python/3/re.py", line 194, in sub
    return _compile(pattern, flags).sub(repl, string, count)
  File "/opt/pypy/lib-python/3/distutils/util.py", line 189, in _subst
    return os.environ[var_name]
  File "/opt/pypy/lib-python/3/os.py", line 681, in __getitem__
    raise KeyError(key) from None
KeyError: 'implementation_lower'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "setup.py", line 1, in <module>
    from setuptools import setup; setup(name="foo", packages=[])
  File "/opt/pypy/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/opt/pypy/lib-python/3/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/opt/pypy/lib-python/3/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/opt/pypy/lib-python/3/distutils/dist.py", line 984, in run_command
    cmd_obj.ensure_finalized()
  File "/opt/pypy/lib-python/3/distutils/cmd.py", line 107, in ensure_finalized
    self.finalize_options()
  File "/opt/pypy/site-packages/setuptools/command/develop.py", line 52, in finalize_options
    easy_install.finalize_options(self)
  File "/opt/pypy/site-packages/setuptools/command/easy_install.py", line 260, in finalize_options
    self.expand_dirs()
  File "/opt/pypy/site-packages/setuptools/command/easy_install.py", line 395, in expand_dirs
    self._expand_attrs(dirs)
  File "/opt/pypy/site-packages/setuptools/command/easy_install.py", line 377, in _expand_attrs
    val = subst_vars(val, self.config_vars)
  File "/opt/pypy/lib-python/3/distutils/util.py", line 194, in subst_vars
    raise ValueError("invalid variable '$%s'" % var)
ValueError: invalid variable '$'implementation_lower''

Code of Conduct

[X] I agree to follow the PSF Code of Conduct

I amended the title. It would be better to deprecate get_config_vars, get_config_var, get_python_inc and anything else already provided by sysconfig from _distutils.sysconfig.


Onboarding slide order change + copy updates

What's this PR do?

Changes the order of onboarding slides
Updates the copy on all of them

How should this be reviewed?
Do the copy updates look ok? Dynamic variables fill in properly?
Is the new slide order correct?
Any background context you want to provide?
no
Relevant tickets
Fixes #7038
Fixes #7037

¡OLÉ! :sheep: it!


Http://github.com/cendoldawet369/cendol.py

Cendol.py### Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

###cendol.py Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/cendoldawet369/cendol.py

Please replace this line with an explanation of why you think this topic or collection should be curated.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Sa b i ???;,

Attach files by selecting or pating them.

Http://gitub.com/cendoldawet369/cendol.py

@!!+×

Ai

****

Fuum requests

HI @cendoldawet369! I've closed this PR since it doesn't seem to propose a realistic change. If you need help, please see our contribution guidelines for how to contribute. Thank you!


Composite Chebyshev grid for imaginary-time

Polynomial interpolation based on Chebyshev nodes provides interpolation polynomial minimizes the effect of Runge's phenomenon.
In the DLR module, the composite Chebyshev grid has been used to discretize the kernel in the Lehmman representation. The same grid can be used to fit generic imaginary-time correlators.

When calculating G0W0, the half-life of the current tau grid is inconsistent between rs=1 and rs=4.


fix(Nav): Avatar should light up brownie #10581

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ ] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #10581

Description

What's happened?

It has 2 commits, one for a different user. I'll rebase and PR


[BEAM-14415] Exception handling tests and logging for partial failure BQIO

…s in BQ IO
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

I commented here with regards to the changes you're making in this PR

Run Python 3.8 PostCommit

r: @johnjcasey

@Firlej @pabloem could we fix the test in a separate PR? I'd rather not have getting PostCommits green blocked on reviewing this PR.

Run Python 3.8 PostCommit

Postcommit: https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/476/

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

@Firlej - I added instead a new output PCollection - what do you think about this?

@pabloem Nice! I guess this approach isn't breaking for implementations made using previous versions.

Yeah - I figured the performance cost is small enough that we can accept it.
On Wed, May 11, 2022 at 1:55 PM Oskar Firlej @.***>
wrote:

@pabloem https://github.com/pabloem Nice! I guess this approach isn't
breaking for implementations made using previous versions.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/17584#issuecomment-1124286759, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ5Z3FUVHVDOXKXOJ63QXLVJQNE5ANCNFSM5VJXMX2A
.


Ostream helpers

Refinements, tests and extra features for ostream helpers. Most of these imported and updated from Gerrit submission.

Hey @MeatBoy106 : This isn't a harder requirement but it would help us a little bit if you could add tags to the PR title as well. We're still, for now, enforcing the use of tags and github, by default, uses the PR title as the merge commit header, so it's nice to have that setup for us (when a Maintainer squashes and merges the commit they can choose to edit the header, but that means they choose what the tags are. It's nice if the contributor can do that).

@BobbyRBruce Sure! Is it better that way?

@BobbyRBruce Sure! Is it better that way?

Yes. Thank you!

I'll merge this when @giactra has approved.


Doesn't recognize correctly pretty much any barcode

I've tried getting quagga to work, but none of the EAN in consumer products, managed to get properly decoded. Here is an image that doesn't get recognized, pretty much anywhere (even quagga alternatives): https://imgur.com/a/SDnrR

Yep, I'm experiencing the same issue.

same here, at most i can get some green boxes to show up with debug visualizations, but even those are completely in the wrong place.

I was struggling this as well. I think it's very sensitive to your camera quality. I can hold a barcode in front of my laptop's webcam for a minute or two, adjusting it throughout, and it will eventually detect it. When using my phone's camera, it was still very finicky, but recognized the barcode quicker.

To reduce number of false positives, use a buffer and sensitivity threshold. For example, increase frequency to 20 and save all barcode scans. If a specific barcode is scanned at least 5 times return this barcode.

increase frequency to 20 and save each code in array

Could you please show some code example of this in action?

let detectionHash = {};
function onDetected(result) {
    detectionHash[result.codeResult.code]++;
    if(detectionHash[result.codeResult.code] >= 5) {
        detectionHash = {};
        call_success_function(result.codeResult.code);
    }
}

not a bad idea, might consider doing that, if it doesn't exhibit speed issues.

Thanks @ericblade, I decided to use Qr codes instead because it provides more reliable results but will definitely try this next time I have to implement barcode scanning.

@GIOkafor how do select QR code?
I can confirm EAN barcode scanning on iOS 11 Safari. very cool!

totally untested, but this is what nitinsbuzz is thinking of GIOkafor
let detectionHash = {};
function onDetected(result) {
    detectionHash[result.codeResult.code]++;
    if(detectionHash[result.codeResult.code] >= 5) {
        detectionHash = {};
        call_success_function(result.codeResult.code);
    }
}

not a bad idea, might consider doing that, if it doesn't exhibit speed issues.

This is a great fix! Thanks. I have near 100% accuracy now by setting it to 5. 4 and 3 seem to work pretty well too. Keep in mind the higher the buffer the slower it is.

For sure.  It works pretty well, but I eventually went for something that does a quick checksum validation on it, and if the barcode appears to be valid then accept it the first time, otherwise if it scans the same code several times with a high confidence, then accept it.   I wrote a checksum checker some time ago here https://github.com/ericblade/barcode-validator .. i just realized i never documented it, but there are some tests at the bottom that are pretty self-explanatory on how to operate it.


nodejs-12_x: 12.12.0 -> 12.13.0

Motivation for this change
Changelog: https://github.com/nodejs/node/releases/tag/v12.13.0
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Ran nix-review wip without failures


Documented Cisco ACI Plugin Deployment Instructions

Drafted instructions for deploying Cisco ACI plugin in the readme.

Feature requests and bugs are created and tracked on https://wiki.odim.io/. Closing this issue because https://jira.lfnetworking.org/browse/ODIM-19 is created for tracking the pending work.


Improve documentation of stable graph behaviour

fixes #356
The behaviour of node indices being reused after deletion is documented in both PyGraph and PyDiGraph.

Pull Request Test Coverage Report for Build 935980672

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 96.815%

Files with Coverage Reduction
New Missed Lines
%

src/astar.rs
9
91.74%

Totals

Change from base Build 935371297:
-0.04%

Covered Lines:
8815

Relevant Lines:
9105

💛  - Coveralls


ACTUALLY detected

Removed like half the features and vmp'd with virtualization+mutation and injected with randoinjector with asm emit junk. Got vac ban. NO OVERWATCH. Just vac.

Close the issue. We already have a lot of these.

pls check other issues, this is your own problem

We know about it already.

close this, theres so many multiple issues like this

OML Your INJECTOR is detected!! Please close this issue and use Process Hacker 2 as it uses a Kernel Driver for process management and most importantly injection.

OML Your INJECTOR is detected!! Please close this issue and use Process Hacker 2 as it uses a Kernel Driver for process management and most importantly PE injection.

isn't process hacker 2 detected? If it isn't then why doesn't anyone recommend PH2 and they recommend rando-injector?

idk i honestly think it is detected i used two different injectors i even continued to use my rando injector paste with other cheats and not get banned. then after getting banned using osiris i used a c# injector that is is barely known i added junk code still got banned

OML Your INJECTOR is detected!! Please close this issue and use Process Hacker 2 as it uses a Kernel Driver for process management and most importantly PE injection.

isn't process hacker 2 detected? If it isn't then why doesn't anyone recommend PH2 and they recommend rando-injector?

I've actually switched to PH2 many months ago from my own modified version of RandoInjector and I have received no bans at all on 6 accounts so far.

Why would you use rando injector ? people have been using that injector since 2017 without any changes .

Can vouch. I have done the exact same thing as stated above and got vac'd on 4 accounts.

i've been using this cheat for like 3 months it didn't get detacted once

Consider the Injector causing the detection.
As I have done some misstakes in my injector I received gamban -> VAC Ban
https://steamcommunity.com/id/imguiX64/
https://steamcommunity.com/id/SorenBecker/
Both Accounts detected same day the VAC Ban issue was different. Look at the days!

Consider the Injector causing the detection.
As I have done some misstakes in my injector I received gamban -> VAC Ban
https://steamcommunity.com/id/imguiX64/
https://steamcommunity.com/id/SorenBecker/
Both Accounts detected same day the VAC Ban issue was different. Look at the days differense nearly 40 days!!! So the VAC Ban could lay quiet a while in the past. I used the injecotr only once on both accounts same day for testing. And then don't play this Accounts anymore. After sometime one Account got Game Ban issued and 24 hrs later VAC Ban same for the Account that was banned later on.

Gameban then vac is vacnet, nothing is detected, ur just too blatant

@xavier124 It was 100% injector, I know what I am doing. ;-)

Just make your own injector, there should be enough tutorials online to make one yourself.

@ruminyan If you go back to the old hooking methods, you'll also get banned as now it's the hooking methods that are detected and not your injector.

Of course it's detectable, if you don't want to get VAC banned, play legit, make your own cheat, or buy a private cheat

Osiris isn't ACTUALLY detected, so please close this issue thread thanks.


ejabberd: 20.03 -> 20.04

Motivation for this change
This is a simple version bump. "In addition to various bugfixes and improvements, this release massively improves audio and video calls support."
I have the new version deployed here and it works fine, but I just started hosting my own xmpp server yesterday so am not really qualified to judge.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

The test (in nixos/tests/xmpp/ejabberd.nix) doesn't seem to work anymore, but that's true on master with or without this PR.
So if you want to fix it, that would be really cool. We can probably merge this either way.

Thank you for your feedback and for pointing me to the failing test (for any onlookers, here is the log of the failing test). :-) I had a quick look. The test looks reasonable enough and I cannot really fathom why it should fail.
Perhaps it's just because ejabberd is too slow to create the .erlang.cookie file? If so, we should give it some more slack by adding directly after line 253 of the test the following instruction:
server.sleep(15)

Unfortunately I cannot test this proposal, as I don't have access to any machine on which the flavor of qemu used by the test suite works.

Ah, that's a different unrelated failure. Which might be fixed by a sleep in there, yes.
What I'm talking about is the client failing like this.
What's weird is that it works in the prosody test, which calls the exact same client code.
Aha! 8aea5288725688f7f71bf12c8ee1bb83147b22c6 is probably at fault then. The test works again when reverting it at least. @NinjaTrappeur could you maybe look into this? Seems like the ejabberd test might not be configured for some of the features this is trying to test now.

Hey!
The test does not seems to enable mod_disco nor mod_upload_http. The issue is coming from there.
I'm having a look at it.
PS: Ofborg can now run the VM tests, you probably want to setup passthru.tests for this package to let the CI run those. It'll be simpler to see stuff breaking in the future. See https://github.com/NixOS/nixpkgs/blob/ec618a9120acb298e69afe9d02478722978781ec/pkgs/servers/xmpp/prosody/default.nix#L77

After quite a bit of mud fighting with Ejabberd, I did not managed to setup mod_upload_http for this test. I suspect we'd need a proper TLS setup for the test. I'm not 100% sure about that though, the logs are pretty scarce. I guess somebody actually using Ejabbered would be a better candidate to fix that: I never used this software.
In the meantime, I wrote a small patch allowing us to disable the http_upload check for the Ejabbered test. I took advantage of this to add the passthru attribute I was talking about in the previous post.
I can't push anything to this branch, @iblech, you can apply the patch by running:
curl "https://github.com/NinjaTrappeur/nixpkgs/commit/deb1bcf3b221d2e626085b36d7da7e4647880448.patch" | git am

Thanks to both of you for picking up this issue! :-) NinjaTrappeur, I applied your patch, thanks for the taking the effort and making it extra-convenient for me!

You're welcome :)
Interesting, looks like ofborg is experiencing the same cookie issue you were seeing on hydra: https://logs.nix.ci/?key=nixos/nixpkgs.90462&attempt_id=4491813c-4b62-4904-8daf-4cf3ef7ec73e. That's weird, I do not experience that on my machine.
You can now run the test on ofborg by pushing to this branch (see the ejabberd.passthru.tests check), I'll let you find a workaround for that :)

Hm, very interesting!
First I just pushed sleep(15), to see whether this actually makes the issue go away.
Then regarding a more robust solution: I was under the impression that wait_for_unit waits till the unit is in "active" state. But apparently ejabberd creates the cookie file only after systemd believes the unit to be active... Perhaps the correct fix would actually amend the systemd unit to create a placeholder cookie file before starting up ejabberd?

Hey Ingo,

Then regarding a more robust solution: I was under the impression that
wait_for_unit waits till the unit is in "active" state. But
apparently ejabberd creates the cookie file only after systemd
believes the unit to be active...

Systemd will consider the unit active once the ExecStartPre script has
been executed and until the ExecStart script is running.
Without any further tweaking, systemd won't know anything about the
internal state of the application. IE. whether the service finished its
initialization procedure and is able to process incoming requests. The
Erlang VM-based apps are well known for having a pretty long boot time,
that's probably the issue we're hitting here.

Perhaps the correct fix would actually amend the systemd unit to
create a placeholder cookie file before starting up ejabberd?

I don't think this is the solution we're looking for. I think we should
rather make sure the Ejabberd is indeed responsive before quering it.
I see two solutions here.

We accept the fact the service might take some time to boot and fail
to respond for a brief amount of time. In that case, we could replace
the server.succeed here [1] with wait_until_succeeds.
We create a ejabberd-wait-online oneshot service that'll be triggered
once the service gets online first. Something similar to [2]. You can
then wait for this unit in the test. The question then is what's the
condition to consider Ejabberd online. I can't really answer that :)

The solution 1 would be a nice way to fix the test. The solution 2 would
take that a step further and would create a new target you could
potentially use in some real world deployments; at the cost of being a
bit more costly to implement. I have no idea whether it worth the
trouble or not.
[1] https://github.com/NixOS/nixpkgs/blob/b20f9112d263e574672c004d6e2775d06ebb1fb7/nixos/tests/xmpp/ejabberd.nix#L255
[2] https://github.com/NixOS/nixpkgs/blob/b20f9112d263e574672c004d6e2775d06ebb1fb7/nixos/modules/system/boot/networkd.nix#L1207

20.07 is out now + the fix in #97526 seems nicer than just disabling upload. The other parts of this PR, e.g. the passthru.tests and bump are still relevant, though.


Docs: brew audit --strict is not enough when renaming a formula

brew audit --strict does not catch all the issues. The CI/CD uses "brew audit --online --new-formula" and is more thorough, catching e.g. "New formulae in homebrew/core should not have a 'bottle do'" which brew audit --strict does not.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
(not applicable)
[x] Have you successfully run brew style with your changes locally?
(not applicable)
[x] Have you successfully run brew typecheck with your changes locally?
(not applicable)
[x] Have you successfully run brew tests with your changes locally?
(not applicable)

I got got today when renaming a formula. Even though brew audit --strict passed, the CI/CD uses brew audit --online --new-formula, which caught an issue that the former did not. Since the CI/CD uses the latter, the renaming docs should suggest the same.

Thanks so much for your first contribution to Homebrew/brew!  You rock, @wrobelda!


Normalize default report path

Gulp tasks generate reports in a folder by default.
The plugin searches for reports in another folder.
The default behavior should simplify use of the plugin by using same defaults.
Normalize application paths and use it by default

Done


Detailed tx summaries

for debugging and advanced zingo-cli users
currently, detailed tx summary only adds nullifiers but there may be other things that will be useful to add in the future such as the notes spent in a tx etc.

i will test it out in zingocli when i get a chance

@Oscar-Pepper it seems that there's a CI fail.


Consider automatic releases

Originally posted by @MichaelDeBoey in https://github.com/eslint-community/eslint-plugin-eslint-plugin/issues/300#issuecomment-1243013325
We currently use release-it to perform releases via a CLI command. I'm personally open to setting up the package to automatically release based on semantic commits. Any thoughts or recommendations on common/standard ways to do this?

In most of the projects I worked on, semantic-release was used to automatically create releases based on commits.

release-it does support ci mode, sematic-release is more popular tho.


Done basically Nothing

:white_check_mark: Build TimeHACK AppVeyor-208 completed (commit https://github.com/TimeHACKDevs/TimeHACK/commit/65b7fc5e50 by @Alex-TIMEHACK)


Weird errors thrown in terminal periodically

This happens randomly but it doesn't seem to be having any negative effects. So far it's just extra noise in my terminal. What's causing this?

You can mostly ignore this. It shouldn't cause major issues, at most the voice connection might die, where you can just use the reconnect or restart command. These issues should be mostly negated in the next stable version of the bot (code changes are in review branch, but isn't recommended to use it currently)


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #688 (c1fee70) into main (9c17850) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #688   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17


add target_height as an option and rename saves to .buf

Thanks; I have added those changes in the main branch (outputs files are now called ".model.proto").


For issue #231, force column size to be determined

Issue #231: When binding params, in the function determine_column_size_or_precision(), column size is set to SQL_SS_LENGTH_UNLIMITED (0). Then later in resize_output_buffer_if_necessary() when calculating the required size, the buffer length is smaller than required, which results in truncation error. This affects not only varchar(max), but also nvarchar(max), varbinary(max), and xml types

Coverage increased (+1.9%) to 46.369% when pulling 909bcfee6d2e46205582ab4fd5a953267521d64d on yitam:GH231 into ff25f2987f737a7f81306a7c70206080fbc9fa05 on Microsoft:dev.

Coverage increased (+1.7%) to 46.129% when pulling aec1c83490d52959eb8ef00ae0e0f5ce2aded240 on yitam:GH231 into ff25f2987f737a7f81306a7c70206080fbc9fa05 on Microsoft:dev.

Coverage increased (+1.7%) to 46.137% when pulling aec1c83490d52959eb8ef00ae0e0f5ce2aded240 on yitam:GH231 into ff25f2987f737a7f81306a7c70206080fbc9fa05 on Microsoft:dev.

The problem described in issue #231 also affects InOut parameters, and for varbinary(max), the encoding is not set properly. The new test will test both output and inout parameters plus these data types with unlimited sizes

Coverage increased (+0.5%) to 46.661% when pulling 0705d9b1a88e2d83267cf13cdaa8d4cf0bf24a98 on yitam:GH231 into cc925ad9b3e986e82011dc6f8d4f78fc55b12d95 on Microsoft:dev.

Coverage increased (+0.5%) to 46.661% when pulling f7a1c7296ba0bda934ba5c3be59b22f1b02bb45a on yitam:GH231 into e448281049c845ac1163feb25a538b5b3f9e467e on Microsoft:dev.


Merge Branch jj <IP_ADDRESS> into Master

Changes proposed in this pull request

Bump up the versions Store 1.5.4, Spark 2.0.3-3 and Jobserver 0.6.3-3
Use gemfirexd URL from shell in rowstore mode
Set the "client connect" URL to use jdbc:gemfirexd:// in rowstore mode (or when thrift is set to false explicitly)
Updated the C++ driver for latest thrift IDL
Updated the code to use accessor method instead of reading/updating the USE_THRIFT_AS_DEFAULT static directly (which is now private)
Code changes to bring ODBC Driver in working state.
Code changes to make ODBC Driver working with Tableau Desktop Application
ODBC related Bug Fixes

Patch testing

Precheckin yet to run

ReleaseNotes changes
(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?)
Other PRs

SnappyData : https://github.com/SnappyDataInc/snappydata/pull/598
Spark : https://github.com/SnappyDataInc/spark/pull/49
Spark-jobServer : https://github.com/SnappyDataInc/spark-jobserver/pull/11
AQP : https://github.com/SnappyDataInc/snappy-aqp/pull/146

Will create new PRs for jj branch merges.


[3.x] - Make Jaeger Tracer OpenTelemetry Agent aware.

Resolves #6174 for Jager Tracer

Could I suggest this AgentDetector class instead? @dalexandrov  @tomas-langer
package io.helidon.tracing.jaeger;

import java.util.logging.Logger;

import io.opentelemetry.context.Context;

class OpenTelemetryAgentDetector {

    private static final Logger LOGGER = Logger.getLogger(OpenTelemetryAgentDetector.class.getName());
    private static final String AGENT_CLASS_NAME = "agent";
    private static final String AGENT_PROPERTY_PREFIX = "io.opentelemetry.javaagent";

    private OpenTelemetryAgentDetector () {
        // Empty constructor for a utility class.
    }

    static boolean isOpenTelemetryAgentPresent() {
        if (isAgentInCurrentContext() || isAgentInSystemProperties()) {
            LOGGER.info("OpenTelemetry Agent detected.");
            return true;
        }

        return false;
    }

    private static boolean isAgentInCurrentContext() {
        return Context.current().getClass().getName().contains(AGENT_CLASS_NAME);
    }

    private static boolean isAgentInSystemProperties() {
        return System.getProperties().stringPropertyNames()
                .stream()
                .anyMatch(property -> property.contains(AGENT_PROPERTY_PREFIX));
    }
}

Nice, but do we really want to use this type of detection. I would consider it as a temporary solution.

True - it still isn't the best.
Using something like this isn't much better either
OpenTelemetryAgentDetector.class.getClassLoader().getResource("io/opentelemetry/<...>") // Not sure what the resource path is :)

I'll think on a better solution, and should I come up with one I'll post it here.

Depends on #6493  for the Agent Detector

I have been out of the office and am catching up on this PR now.
@dalexandrov Did you ever try the approach I described in my 31 March comment?
That would avoid any implementation details (such as the name of the agent class, expressed either as a class name or a resource name) which could change from one release to another. It would also support any way that the global tracer might be set--not just by the agent but by any code--before the Helidon code runs and Helidon would then properly work with the established global tracer.

Hello @tjquinno,
After a lot of investigation we found out, that unfortunately your proposed approach is not possible. OpenTelemetry SDK does not allow it, since all getters there also do setting to no-op, and they do it only once. There is no way to check before setting, as checking momentarily sets the object to no-op. Other ways like checking for secondary exceptions also did not work. We have explored the code with @tomas-langer and came to the conclusion, that the proposed in this PR approach is the most suitable compromise.

@dalexandrov We already knew that the Otel API did not permit a get-without-set, as I described in my earlier comment.
The OTel code simply throws an IllegalStateException if the caller attempts to invoke #set(OpenTelemetry) a second time. It seems that it would be straightforward for Helidon to catch that and then invoke #get to obtain the previously-set instance, or if no exception was thrown then Helidon's attempt to set the value was successful.
Can you please explain why checking for the exception when invoking #set when it had been already invoked did not work? If you still have the code where you tried this a pointer would be great.

Mitia walked me through some code that shows my suggestion about catching the exception does not work. The exception is thrown not from the thread which invokes the set method but from elsewhere where Helidon cannot easily catch it and respond.


Fix CI Build

Remove portia/slyd/tests and add portia/slyd/orm/tests to slyd/tests.
Remove npm test from Travis to be replaced by tests in the portia/portiaui based ember app once it has non trivial tests.

Fix ORM tests regarding start_urls, and a Sample's body and rendered_body.

Instead of ensuring ordering in a @post_dump hook, opted for fixing the non-passing tests by changing the start_urls key orders.


feat: onboard unleash

Summary

Onboard https://github.com/pluralsh/plural-artifacts/issues/294
Added OIDC

Test Plan

Deployed helm chart + terraform locally

Checklist

[x]  No images hosted from dockerhub
[x]  Are dashboards present to understand the health of the application.  There must be at least 1 of these

[x]  all databases should have dashboards
[ ]  ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
[ ]  you can use plural from-grafana to convert a grafana dashboard found via google to our CRD

[x]  Are scaling runbooks present

[x]  all databases must have scaling runbooks
[ ]  you can use the charts in pluralsh/module-library to accelerate this

[ ]  do you need to add config overlays?

[ ]  inputing secrets
[ ]  configuring autoscaling

[x]  If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
[x]  All major clouds must be supported

[x]  Azure
[x]  AWS
[x]  GCP

I suspect using the oauth proxy might also require oauth for the feature flag apis and some workaround will be needed there, probably w/ adding a dedicated ingress path for them

I suspect using the oauth proxy might also require oauth for the feature flag apis and some workaround will be needed there, probably w/ adding a dedicated ingress path for them

Good catch, I'll fix it
Should we always have OIDC support? Unleash has a auth system already

I don't think it's necessary to always enable oidc, what you can do is have a dedicated path for the flag apis that are exposed publicly that routes to a service that is directed to the regular unleash container ports instead of the oauth proxy ones


Add tracking of membership points to SweetRewards

Replaces Membership with MembershipPoints

Stores in value the total points which a member has accumulated
List of TIERS with points to achieve them are stored in the MembershipPoints class

e.g. {"SILVER", "200"} means it takes a minimum of 200 points to reach silver tier

Contains a function getTier() which calculates the tier based on accumulated points

addmship -> addmempoints

Now gives a specified no. of membership points to a given member

Updated GUI to show both tier and points

(Additional) Minor addition to add labels for each detail on the contact's PersonCard:

End result:

Closes #56 #64

LGTM! Good effort thank you

There seem to be a few Codecov errors with regard to code coverage. Do check it out to see if you need more testcases


Custom imgae in template

Details
Ask your question:
Hi! I have a task to "hide" image from values to inside template, is it possible?

I'm not sure if I understand the question. If you fill out the values.yaml file, the image and tag is required. However, you can do a an install from the command line in which you can set certain parameters and exclude the image tag. If you post your values.yaml, I can help you figure out the command line.


Error: secret "mlpipeline-minio-artifact"/"mysql-secret" not found in some deployments

Describe the bug
Error: secret "mlpipeline-minio-artifact" not found in the following deployments:

ml-pipeline-ui
kubeflow-pipelines-profile-controller
minio

Error: secret "mysql-secret" not found in the following deployments:

metadata-grpc-deployment
ml-pipeline
cache-server

It seems that these secrets are removed in file disable-default-secrets.yaml in commit 6fdcc9b0d8206c00b9fa1e6491aeab310bd47df4 but still got used in a lot of deployments.
Steps To Reproduce

Deploying with distributions/aws/examples/rds-s3 templates.
kubectl describe pod -n kubeflow $(kubectl get pod -n kubeflow -l app=ml-pipeline-ui -o jsonpath="{.items[0].metadata.name}")

Expected behavior
Above deployments run successfully.
Environment

Kubernetes version: 1.19
Using EKS (yes/no), if so version?  Yes, EKS version: eks.7
AWS service targeted (S3, RDS, etc.) -> s3-rds

Screenshots
None
Additional context
I deploy with this custom kustomization.yaml which is based on distributions/aws/examples/rds-s3 but is modified to use only necessary services based on my own need
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
# Istio
- ../common/istio-1-9/istio-crds/base
- ../common/istio-1-9/istio-namespace/base
- ../common/istio-1-9/istio-install/base
# OIDC Authservice
- ../common/oidc-authservice/base
# Dex
- ../common/dex/overlays/istio
# Kubeflow namespace
- ../common/kubeflow-namespace/base
# Kubeflow Roles
- ../common/kubeflow-roles/base
# Kubeflow Istio Resources
- ../common/istio-1-9/kubeflow-istio-resources/base

# Central Dashboard
- ../apps/centraldashboard/upstream/overlays/istio
# Profiles + KFAM
- ../apps/profiles/upstream/overlays/kubeflow
# User namespace
- ../common/user-namespace/base

# Configured for AWS RDS and AWS S3

# AWS Secret Manager
- ../distributions/aws/aws-secrets-manager/base
# Kubeflow Pipelines
- ../apps/pipeline/upstream/env/aws

I found an error for kubeflow-secrets-pod:
MountVolume.SetUp failed for volume "s3-secret" : rpc error: code = Unknown desc = failed to mount secrets store objects for pod kubeflow/kubeflow-secrets-pod, err: rpc error: code = Unknown desc = Invalid JSON used with jmesPath in secret: rds-secret.
There're any thing wrong with jmesPath? at kubeflow-manifests/distributions/aws/aws-secrets-manager/base/secrets-manager.yaml
Environment:
Kubernetes version: 1.21
EKS version: eks.4
AWS service targeted: cognito-s3-rds
Branch: v1.3-branch

@bankbiz  I don't believe there is any issue, have you created the secrets in AWS-secrets manager and have not modified the secrets-manager.yaml in anyway?

@bankbiz  Perhaps the issue "Invalid JSON" might suggest the json you sent to the secrets manager was not in the format accepted by the  kubeflow-secrets-pod ?
I got a similar issue once when I had one field in my json as "port" : 123 instead of "port" : "123".
The secrets manager accepts it but when came time for the db pod to read it then it screamed at me for the wrong json. Maybe your issue is something similar.
If so then maybe this PR could help you set it up automatically to avoid any manual entry error

@bankbiz I ran into the same issue today and realized the secret values were not getting set properly as Alex mentioned. Can you check the Secret value in rds-secret and s3-secret from Secrets manager?
In my case the s3 secret values were null:

Yeah! I found that the secret is not set properly. Alex PR cloud help for future release.
Thanks.

@lnguyen46 Closing this issue since we haven't heard back since the issues was opened. Please re-open if you still need assistance.


Problem with mariadb

Hello,
Mariadb won't start.
I went into the docker and mariadb was stopped and it's impossible to start.
Cordialy,
AM

@dcma95 i'm using this container with the database, and mariadb work, it may need sometime to start

@manish-ip I am experience the same, as soon there is a volume mounted on the host availble mysql will not start!

I think this is related to the ownership of /var/lib/mysql when mounting a volume. When mounting this becomes root:root, while if not using a volume this is mysql:mysql.

I think found a solution to this issue. It is more of trick actually but it gets the job done.
Assuming you have two local directories: PHP_DIR and MYSQL_DIR (empty)

Initially you should run the container without mapping the /var/lib/mysql data directory at all but instead you should map the /var/www/html to MYSQL_DIR
docker run -it -v MYSQL_DIR:/var/www/html fauria/lamp bash

Copy all files from /var/lib/mysql to /var/www/html
cp -a /var/lib/mysql/. /var/www/html/
now the MYSQL_DIR should contain all required files

Stop and restart the container normally
docker run --rm -p 8080:80 -v MYSQL_DIR:/var/lib/mysql -v PHP_DIR:/var/www/html fauria/lamp

Using host volumes can be tricky, specially when they don't contain user generated content. Please, refer to https://docs.docker.com/storage/volumes/ for more information.


Cherrypick callstacks and source locations

The issue describes desired future midterm development of ghcvm.
https://downloads.haskell.org/~ghc/8.0.1/docs/html/users_guide/glasgow_exts.html#hascallstack

Closing as this is a language change, this should follow the Eta Proposal Process:
https://github.com/typelead/eta-proposals


Noughty Haldwani Call Girls<PHONE_NUMBER> HIFI Call Girls In Haldwani Escorts Service

Dial Maya ❤<PHONE_NUMBER> "Call "Girls In Haldwani Call Girl In Haldwani || Call Girl Near Me || Call Girl Number In Haldwani || Haldwani Call Girl || Escort Service In Haldwani || Call Girls In Haldwani || Call Girl Service In Haldwani || Escort Service Haldwani || Prostitute in Haldwani || Call Girl Haldwani || Haldwani Escorts || Haldwani Escort Service || Haldwani Call Girls || Call Girl Contact Number Haldwani || Call Girl Price Haldwani || Call Girl Rate Haldwani || Call Girl No In Haldwani || Call Girls Near Me || Indian Call Girl Haldwani || Haldwani Escort || Escorts Service In Haldwani || Call Girl Contact Haldwani || Low Price Call Girl in Haldwani || Call Girls Haldwani || Escort Service Near Me || Call Girls Number Haldwani || Call Girl Low Price Haldwani || Indian Call Girls Haldwani || Escort In Haldwani || Escorts In Haldwani || Low Rate Call Girl Haldwani || Call Girl Pics Haldwani || Escort Girl In Haldwani || Call Girls Service Haldwani || Call Girls Contact Number Haldwani || Call Girls Rate Haldwani || Cheap Call Girls Haldwani || Call Girl Service Haldwani || Call Girls Pics Haldwani || Indian Escort Service Dehradun

Dial Maya ❤<PHONE_NUMBER> "Call "Girls In Haldwani Call Girl In Haldwani || Call Girl Near Me || Call Girl Number In Haldwani || Haldwani Call Girl || Escort Service In Haldwani || Call Girls In Haldwani || Call Girl Service In Haldwani || Escort Service Haldwani || Prostitute in Haldwani || Call Girl Haldwani || Haldwani Escorts || Haldwani Escort Service || Haldwani Call Girls || Call Girl Contact Number Haldwani || Call Girl Price Haldwani || Call Girl Rate Haldwani || Call Girl No In Haldwani || Call Girls Near Me || Indian Call Girl Haldwani || Haldwani Escort || Escorts Service In Haldwani || Call Girl Contact Haldwani || Low Price Call Girl in Haldwani || Call Girls Haldwani || Escort Service Near Me || Call Girls Number Haldwani || Call Girl Low Price Haldwani || Indian Call Girls Haldwani || Escort In Haldwani || Escorts In Haldwani || Low Rate Call Girl Haldwani || Call Girl Pics Haldwani || Escort Girl In Haldwani || Call Girls Service Haldwani || Call Girls Contact Number Haldwani || Call Girls Rate Haldwani || Cheap Call Girls Haldwani || Call Girl Service Haldwani || Call Girls Pics Haldwani || Indian Escort Service Dehradun


Sometimes a ghost isn't spectated when I click on it in the leaderboard.

I click on a ghost in the leaderboard and sometimes I don't see it.
A workaround is to manually change the time in the ghost scrubber.
Replay: https://youtu.be/0Z7n89U9LBc

Another streamer (Lars) with the same bug: https://clips.twitch.tv/TemperedDiligentLouseAMPEnergy-CF7yCxcvYmaerMk3
Also another issue: clicking on eyes of enabled ghosts in the leaderboard on the left doesn't remove them. (That's why they talk about map resets in the clip.)

I am having trouble replicating the not-auto-spectating bug (where you have to restart the run or change the scrubber time to show the ghost). Not sure if it still exists in the current version.
WRT toggling ghosts, this should work much better in the latest version.
Can you let me know if the latest version has solved the not-auto-spectating thing for you?

I still have the not-auto-spectating problem. But I only need to fix it once per session now. Looking at the log though, I have some information:
I'm getting this yellow message:

when the bug appears.
I'm getting this yellow message:

when the bug gets fixed.

I can confirm that 0.3.3 has fixed this for me.


How to resetOnHide and refresh/rebuild form to clear values before i save

Question
As stated in title, before i save a form, im setting the field.resetOnHide = true but the fields are already hidden so i have 3 options, hope either of the first two have an answer.

i need a way to rebuild to form that take the new resetOnHide value to strip them out,

 public postPutForm() {
    this.msgSvc.broadcast('clearHiddenInput', '');
    this.fields.forEach((field) => {
      field.resetOnHide = true;
    });
    //trying to deep clone in hopes it will rebuild
    this.fields = JSON.parse(JSON.stringify(this.fields));

Im aleady emitting out the fields and fieldGroups that i want to clear hidden values, and I've tried patch value but no luck

export class TwWrapperBaseComponent extends FieldWrapper implements OnInit {
  constructor(
    public msgSvc: MessageSubjectService,
  )

  ngOnInit(): void {
    this.msgSvc.subscribe('clearHiddenInput', () => {
      this.field.resetOnHide = true;
      if (this.field.hide) {
        this.field.fieldGroup?.forEach((c) => {
          c.formControl?.patchValue(null);
        });
      }
    });

export class twFieldInputComponent extends FieldType<FieldTypeConfig> implements OnInit {
  constructor(public msgSvc: MessageSubjectService) {
    super();
  }
  ngOnInit(): void {
    this.msgSvc.subscribe('clearHiddenInput', () => {
      this.field.resetOnHide = true;
      if (this.field.hide) {
        this.field.formControl.patchValue(null);
      }
    });
  }
}

if none of the first two are valid options i can recursively search and match model and field hidden values but hope there's a more native way

Try do update the fields like this this.fields = [...this.fields]; that should rebuild and detect changes (based on https://github.com/ngx-formly/ngx-formly/issues/3827).

@DavWe thanks for the reply, i did try that originally, no luck, then the tried deep clone that you see above, also no luck, I've gone ahead with my third approach for now (recursive search) from what I've read everything i did try should have worked, may of been an issue with needing fresh render cycle to start rather than synchronously (since I'm saving right after) so I'm unsure.


Is this github also related to "MediaInfo.Native"?

Is this github also related to "MediaInfo.Native"?
https://www.nuget.org/packages/MediaInfo.Native/

This GitHub is the official repository for the development of MediaInfo(Lib).
The link you have is a (non official, not maintained by us, no support) nuget package of this GitHub repository content.


Make Camunda Version configurable

Currently, 7.12 is hard coded. Please make this configurable. We might need a compatibility matrix.

Issue is obsolete with commit 472f27b3fa3f00b872aa704e1d7f8e69c4f34b35
A newer version can be used by adding:
implementation("org.camunda.bpm:camunda-engine:7.14.0")


(refactor) some opportunities to use diamond operator

All the error caught by travis are due java 1.7 not be recognized

Hi @desmorto
The source code compatibility of agent is JDK 1.6.


Clip Name is a hybrid of clip name and its file extension

Issue
I spotted an odd behavior in the logic.
https://github.com/TheAcharya/MarkersExtractor/blob/b14a8d02ffa6323a006589dd324c6d87278cb470/Sources/MarkersExtractor/Extractors/FCPXMLMarkerExtractor.swift#L222-L224
The Clip Name field in the CSV output is neither the clip name nor the clip filename. It's actually a custom Frankenstein of both which is odd.
Consider:

if the clip uses a video file called "Test video.mp4", and
in the FCP timeline the clip is renamed to "My Clip", then
the CLI will output a Clip Name of "My Clip.mp4"

Proposal
There are a few possible solutions:

We should drop the appended file extension in the Clip Name field.

We could then add a Clip Filename field that actually contains the full filename on disk of the video asset. Or just keep the Clip Name field.

We could retain the file extension but enclose it in parentheses after the clip name so the entire field doesn't look like a filename

ie: "My Clip (mp4)"

The Clip Name field in the CSV output is neither the clip name nor the clip filename. It's actually a custom Frankenstein of both which is odd.
Consider:
if the clip uses a video file called "Test video.mp4", and
in the FCP timeline the clip is renamed to "My Clip", then
the CLI will output a Clip Name of "My Clip.mp4"

In FCP, users can rename their source clips.

There are a few possible solutions:
We should drop the appended file extension in the Clip Name field.
We could then add a Clip Filename field that actually contains the full filename on disk of the video asset. Or just keep the Clip Name field.
We could retain the file extension but enclose it in parentheses after the clip name so the entire field doesn't look like a filename
ie: "My Clip (mp4)"

I think the best approach would be to only utilise the source clip filename. Which means, it would be Test video.mp4. That way users can search and locate the exact source file in their drive if need.

So you suggest the CSV "Clip Name" field would be renamed "Clip Filename" and would contain the filename of the clip's asset on disk.
Wouldn't Clip Name be a useful field though? I'm thinking clip name is whatever a user is used to seeing as the name of the clips on their timeline when working in FCP.

So you suggest the CSV "Clip Name" field would be renamed "Clip Filename" and would contain the filename of the clip's asset on disk.

When you rename a clip in FCP, it is only metadata that is stored in FCP's Library. Hence, FCP never renames the source clips for obvious reasons.
Actually, I am somewhat trying to follow the output "style" of Producer's Best Friend app. Here is the demo of the app. In the demo, you can see that "Clip Name" column means the source filename.

Wouldn't Clip Name be a useful field though? I'm thinking clip name is whatever a user is used to seeing as the name of the clips on their timeline when working in FCP.

I rarely rename my clips in FCP. I might rename Compound Clips or Multi-Cam Clips. But never source clips in FCP. Even if I did, I would also rename the source as well. I usually rename my clips in finder before I import them in FCP. But I can only speak for myself. Most FCP users I know don't rename their source clips once in FCP. This is to ensure, what is their drive directory matches with FCP's browser list.

you can see that "Clip Name" column means the source filename

Except that Clip Name and Clip Filename are both actual things that we have metadata for, so they are not the same thing. It would be more clear to name the field "Clip Filename" in the CSV. Because the field contents are not the clip name, it is the filename.

But I can only speak for myself.

That's why I am bringing this topic up because some users may rename clips either intentionally or unconsciously during editing their FCP project. At least "Clip Filename" makes it plainly obvious what it is if we only output filename.

That's why I am bringing this topic up because some users may rename clips either intentionally or unconsciously during editing their FCP project. At least "Clip Filename" makes it plainly obvious what it is if we only output filename.

Okay we change the column name to "Clip Filename". 👍

Done. Will be in next alpha build.
Both Clip Name and Clip Filename columns are included. This covers all bases. Generators won't have filenames of course so Clip Filename will be blank for those.


[mui-codemod] mui-replace does not update package.json as documented

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://github.com/backstage/demo
Steps:

Run git clone https://github.com/backstage/demo
Run yarn install
Run npx @mui/codemod@latest v5.0.0/mui-replace .

Notice: the package.json is not changed though the documentation indicates it should be: https://github.com/mui/material-ui/blob/master/packages/mui-codemod/README.md#mui-replace:~:text=mui/lab/Mansory'%3B-,Dependencies,-// package.json
-
Current behavior 😯
All the code files are updates as expected but the package.json file is not
Expected behavior 🤔
The package.json file should be updated with the proper changes as per the documentation: https://github.com/mui/material-ui/blob/master/packages/mui-codemod/README.md#mui-replace:~:text=mui/lab/Mansory'%3B-,Dependencies,-// package.json
-
Context 🔦
We are slowly working on migrating Backstage to Material UI v5 from v4 and would like to use as much automation as possible. Ideally we want to be able to tell our adopters to use npx @mui/codemod v5.0.0/preset-safe which includes mui-replace but until this issue is fixed we can't do so.
Your environment 🌎
I've included this as asked but it's not listing the right versions as we are still using packages from @material-ui/*:
https://github.com/backstage/demo/blob/084c8181fe7a1100dff458ef2ae87f290792edbe/packages/app/package.json#L36-L38
Also, I have not included browser details as that doesn't come into play with this issue.

npx @mui/envinfo
  System:
    OS: macOS 14.2.1
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: 3.5.0 - ~/.nvm/versions/node/v18.18.2/bin/yarn
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
  Browsers:
    Chrome: 120.0.6099.129
    Edge: 120.0.2210.91
    Safari: 17.2.1
  npmPackages:
    @emotion/react:  11.11.1
    @emotion/styled:  11.11.0
    @mui/base:  5.0.0-beta.24
    @mui/core-downloads-tracker:  5.14.18
    @mui/material:  5.14.18
    @mui/private-theming:  5.14.18
    @mui/styled-engine:  5.14.18
    @mui/system:  5.14.18
    @mui/types:  7.2.9
    @mui/utils:  5.14.18
    @types/react:  17.0.71
    react:  18.2.0
    react-dom:  18.2.0
    typescript: ~5.2.0 => 5.2.2

Thanks for looking into this and submitting a PR to fix it @ZeeshanTamboli. Would you be able to give me a rough timeline as to what the process is like for this to be reviewed, merged, and published, please? I can understand that you can't give me exact dates, just estimates works for me 👍

@awanlin t#The merge will happen upon approval, and the publication will occur during our weekly release. I'll make an effort to expedite this PR with the reviewers, but I cannot provide a guarantee.

Thanks, that works for me, I know these things take time but it looks like it got merged! When do the weekly releases happen? Excited to test this out on my end 🚀

When do the weekly releases happen?

It will happen at the start of this week. Might be today or tomorrow.

Finally got time to test this out and I'm hitting an error:
~/repos/forks/backstage/plugins/azure-devops (master)> npx @mui/codemod@latest v5.0.0/preset-safe .
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y
Executing command: jscodeshift<EMAIL_ADDRESS>--transform<EMAIL_ADDRESS>--extensions js,ts,jsx,tsx,json --parser tsx --ignore-pattern **/node_modules/** /Users/awanlin/repos/forks/backstage/plugins/azure-devops
Processing 86 files...
Spawning 11 workers...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 8 files to free worker...
Sending 6 files to free worker...
 ERR /Users/awanlin/repos/forks/backstage/plugins/azure-devops/package.json Transformation error (Missing semicolon. (2:8))
SyntaxError: Missing semicolon. (2:8)
    at toParseError (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parse-error.ts:81:19)
    at TypeScriptParserMixin.raise (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/tokenizer/index.ts:1487:19)
    at TypeScriptParserMixin.semicolon (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/util.ts:141:10)
    at TypeScriptParserMixin.parseExpressionStatement (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:1313:10)
    at TypeScriptParserMixin.parseExpressionStatement (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/plugins/typescript/index.ts:3044:28)
    at TypeScriptParserMixin.parseStatementContent (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:659:19)
    at TypeScriptParserMixin.parseStatementContent (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/plugins/typescript/index.ts:2887:20)
    at TypeScriptParserMixin.parseStatementLike (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:416:17)
    at TypeScriptParserMixin.parseStatementListItem (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:365:17)
    at TypeScriptParserMixin.parseBlockOrModuleBlockBody (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:1394:16)
    at TypeScriptParserMixin.parseBlockBody (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:1367:10)
    at TypeScriptParserMixin.parseBlock (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:1335:10)
    at TypeScriptParserMixin.parseStatementContent (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:563:21)
    at TypeScriptParserMixin.parseStatementContent (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/plugins/typescript/index.ts:2887:20)
    at TypeScriptParserMixin.parseStatementLike (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:416:17)
    at TypeScriptParserMixin.parseModuleItem (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:353:17)
    at TypeScriptParserMixin.parseBlockOrModuleBlockBody (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:1393:16)
    at TypeScriptParserMixin.parseBlockBody (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:1367:10)
    at TypeScriptParserMixin.parseProgram (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:212:10)
    at TypeScriptParserMixin.parseTopLevel (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/statement.ts:194:25)
    at TypeScriptParserMixin.parse (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/parser/index.ts:45:10)
    at TypeScriptParserMixin.parse (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/plugins/typescript/index.ts:3999:20)
    at Object.parse (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@babel/parser/src/index.ts:66:38)
    at Object.parse (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@mui/codemod/node_modules/jscodeshift/parser/tsx.js:24:22)
    at Object.parse (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/recast/lib/parser.js:23:30)
    at fromSource (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@mui/codemod/node_modules/jscodeshift/src/core.js:82:25)
    at core (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@mui/codemod/node_modules/jscodeshift/src/core.js:44:5)
    at j (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@mui/codemod/node_modules/jscodeshift/src/core.js:142:12)
    at transformer (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@mui/codemod/node/v5.0.0/adapter-v4.js:13:16)
    at transformer (/Users/awanlin/.npm/_npx/2aacf93ee2439f59/node_modules/@mui/codemod/node/v5.0.0/preset-safe.js:63:38)
All done.
Results:
1 errors
71 unmodified
0 skipped
14 ok
Time elapsed: 3.574seconds

Steps to reproduce:

Clone: https://github.com/backstage/backstage
Naigate to /plugins/azure-devops
Run npx @mui/codemod@latest v5.0.0/preset-safe .

Notice you get the error above

@awanlin I reproduced the issue, and it seems to be related to jscodeshift - either https://github.com/facebook/jscodeshift/issues/559 or https://github.com/facebook/jscodeshift/issues/539. Running the following command works for me:
npx @mui/codemod@latest v5.0.0/preset-safe ./package.json --parser=flow

I'm uncertain about any actions we can take on our side.

Thanks for taking a look into this @ZeeshanTamboli, I'll try that command as well and report back. I think in our case that should be satisfactory 👍

Just got around to trying this out and though it works without errors the versions aren't updated so running yarn install fails. This screenshot should explain what I mean:

It simply changes the names but what it should be doing is also updating the package versions. Not sure how that would work, perhaps this feature should juts be removed? 🤔

The mui-replace codemod only updates package names, not the version. You'll need to handle the version update manually.

Thanks for confirming, should the docs be updated to clarify that? I feel like others would have made that assumption as  well. 🤔


[$1000] Text input label is moving while adding a bank account to a workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/18468
Action Performed:

Open the App
Login
Open Settings > Workspaces
Open any existing workspace or create a new one if you don't have one
Open Connect Bank Account > Connect Bank Manually or with Plaid
Complete the 1st and 2nd step
From the 3rd step, go back
Verify the text input birthdate label is not moving

Expected Result:
The text input label is not moving
Actual Result:
The text input label is a little moving compared to other environments.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native (example device:  SG M52)
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/22010baa-12e8-48c0-84aa-bb287265c910
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f18692795ade1d13
Upwork Job ID:<PHONE_NUMBER>664945152
Last Price Increase: 2023-05-17

@kbecciv Can you list what devices this was reproducible on? It seems to only affect a few specific devices. Samsung Galaxy S10 seems to be a device that we can get reproductions on

@alex-mechler Issue reproduced on SG M52

Thanks @kbecciv !

Not overdue, the job was just created yesterday.

Hi I'm Fábio from Callstack - expert contributor group - I would like to take a look at this issue

Update: I wasn't able to reproduce this issue on the emulator, as stated before it seems to be very device-specific. I asked a team member which has a Galaxy A32 (Android 11) to test and he wasn't able to reproduce it.
https://github.com/Expensify/App/assets/20051562/daaea6d0-0890-4814-9d2f-a0371dae2514
Tomorrow I'll ask another team member that has a Galaxy S9 to try to test and reproduce the issue.

Note: It's not related to this issue and I'm not sure if it was already reported, but the checkbox text is "broken".

@fedirjh @fabioh8010 please be sure to apply to the Upwork posting here.

Update: We tried another device, Samsung Galaxy S9 SM-G960F (Android 10), but again we weren't able to reproduce this issue.
https://github.com/Expensify/App/assets/20051562/329d7de0-e132-4f1a-9dd1-e25c52ca8790
I'm afraid that I won't be able to work on a fix for this issue, as I don't have the means to reproduce it. I also would like to reinforce that this kind of minor visual glitches that are very device-specific are usually not worth fixing it, as it can be a issue with a specific custom OS version or a range of devices of a specific brand. In most of these cases, the issue is with the custom OS / device itself and probably are not solvable.

@fabioh8010 @fedirjh @mountiny Should we just close this one then?

Yes completely agree, thanks for digging into this Fabio.
I will close this out as there seems to be no payments due here, thanks!


Fixed example.cpp when argument is specifying different host

Fixes #9

Why not just accept the connection string as the lone argument and be done with it?

Closed using alternate solution


ci: update mergify rules for e2e tests

as we have added v1.19.0 in CI for E2E tests and also removed the v1.17.x from CI updating the mergify rules for the same.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

Need Manual Merge once CI passes

See #1480 for an improvement that does not require the patch component from the Kubernetes releases to be included anymore.

Merging this one manually


processes.go: Test interactive

Currently this function is completely untested
// the actual implementation of Process.Interactive
func interactive(p Process, in io.Reader, out, err io.Writer) error {
        // Make it interactive
        go io.Copy(p.Stdin, in)
        go io.Copy(out, p.Stdout)
        go io.Copy(err, p.Stderr)

        // Wait for the process to exit
        return p.Wait()
}

Good unit tests would be very helpful.

Fixed by #3


amcl_pose option next to GPS coordinates

The Fields2Cover package works with GPS, and the open_nav_coverage package I think is an adaptation with navigation. Do you plan to integrate with amcl_pose or odom in the future?

Fields2Cover can take any type of input polygon data, including cartesian, today! You can see that in the demo package, we define a cartesian map framed field that is used to generate the path and the robot is routed along that path in map frame.
Done!

Thank you!


Option to hide gear icon

It would be nice to be able to hide to the ⚙ icon in the lower left corner. Optionally it could unhide during a build.

You should create an issue on atom-busy.


Document to Handwritting

Related Issue

I have created Document to Handwriting.

Closes: #679
Describe the changes you've made
This is a Document to Handwriting a website using HTML, CSS, JS and Google font API. We type our work in the text box and our work will be converted to handwriting. On this site, we can change 10 different types of font. On this site we can change the font width On this site, we can upload our own font. our work will be downloaded into a png Format. This site also available in Dark Mode.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

@Priyadarshan2000 Squash your commits into one commit

@Vishal-raj-1 sir I change any commit?

@Priyadarshan2000 Follow the file structure.
HTML file in public
JS,CSS in assets
Add the project to script.js
Why there is readme file

sir any changes

You have to follow the structure. In current codebase.
Add whatever files necessary to run the your project.
Readme is not required.

ok sir I deleted the readme file or any changes sir..?

Follow the file structure please, yours rightnow having a another folder name /Document to Handwritting
Just fix the structure.
And add project to script.js.

@991rajat sir I have done my changes

Thanks for this awesome contribution. 🤩
Keep Contributing.

thank you, @991rajat sir..


Let the user override the call options by extending SIPUAHelper

The method buildCallOptions was already there but not used and instead _options was used directly so that I cannot override the default options by extending the SIPUAHelper class in a custom class and use the custom class instead.
This will affect #169 as the sdpSemantics property cannot be set currently. After this merge we can modify the pcConfig key-value pair in the options map returned from buildCallOptions.

LGTM


update: README.md fixing status badge

Related Issue

Proposed Changes
This just fix status badge on readme cause travis-ci was not used at now

LGTM!
It's better now. 🙂


[Feature Request] Snippet enhancement - Automatic CDN retry logic

When the snippet detects that it has failed to load the main SDK from the CDN, add the ability for the snippet to automatically attempt loading the main SDK script from the available CDN endpoints.

Added in SDK Loader (Snippet) v7 - Sept 20th 2023


Implement Integration Tests for Enhanced Reliability

To ensure the SPIRE Controller Manager operates reliably, this issue proposes the implementation of a suite of integration tests. Adapting the existing demo to run automatically serves as an excellent starting point. This approach will help systematically validate the system's functionality, laying the foundation for a robust testing framework.

In a way, we're doing some of that already in the helm-chart-hardened repo as well. Would it make sense to team up between projects?

I'm customizing the Dockerfile to incorporate specific internal images for our use case. To ensure these adjustments don't inadvertently cause regressions, having integration tests within the same repository would be extremely useful. This approach avoids the complexity of relying on another repo, streamlining the testing process.

Fair. Depends on how far you want to take the tests i guess. Could introduce complexities of trying to integrate it with all the other bits by yourself. Like, does it work properly when configured to deploy a working mysql with k8s -> spire-controller-manager -> spire -> agent syncing the dnsname to allow authentication. We're already doing some of those type of tests, and being able to 'helm install spire --set spire-server.controllerManager.image=customimage  may be relatively easy.

Indeed, the tests you've described seem well-suited for the helm charts repository, focusing on end-to-end functionality including deployment and interaction with Kubernetes. For the spire-controller-manager, I'm advocating for integration tests that concentrate on the core functionality — particularly, the creation and verification of entries in the spire-server under diverse controller manager configurations.

This is very much desired and a prerequisite for the project seeking the "Production" badge from the SPIFFE organization.
While it would be nice to not have repeated effort, I feel like the integration tests for this repo should be independent of the helm chart and target specific features to the controller.


Use new .component() syntax

Fixes #70. It uses angular 1.5.0-rc.0 so maybe you might want wait until 1.5.0, but I think it should be pretty ok to go.

I rather use the component polyfill than 1.5 assuming most users aren't using 1.5

Maybe we should use this? https://github.com/toddmotto/angular-component
With this we can rollback to angular 1.4 before stable 1.5 release.

I added the polyfill.


Call resize to preallocate for memory does not work

I have a large number of key/value pairs, say twenty million, to
insert into the dense_hash_map. I noticed that there are several
times of re-allocation happens in the process of inserting, and
the peak value of memory allocation is double than required.
In order to reduce the total times of re-allocation and gain more
efficiency, I'm considering about preallocation.

So I wrote:

dense_hash_map<k, v> m;
m.resize(20000000);
m.set_empty_key(0);
m.set_deleted_key(-1);

to do the preallocation, and after set_empty_key, I saw a big
700MBytes allocation in the memory, so far so good.

But, after first few(say 4 to 5) insert/erase calls, the big memory
block will be freed, and dense_hash_map repeats the re-allocation
until 1.2GBytes (peak value is 2.3GBytes).

What should i do please ?

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 25 Jun 2014 at 5:43

Confirmed. Until fixed consider using
m[i] = m.deleted_key();
This does not appear to cause reallocation;


Create a Camel VM extension

[https://github.com/apache/camel/tree/master/components/camel-vm]

Fixed by https://github.com/apache/camel-quarkus/pull/320


wasm-pack test --node fails to compile due to use of sys in errno dependency.

🐛 Bug description
In my Rust/wasm project, the wasm-pack test --node command fails during compilation.
🤔 Expected Behavior
I expect wasm-pack test --node to compile the wasm target and run my tests.
👟 Steps to reproduce
Running the wasm-pack test --node gives the following output:
[INFO]: 🎯  Checking for the Wasm target...
[...]
error[E0583]: file not found for module `sys`
  --> /home/mvernacc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/errno-0.3.8/src/lib.rs:26:1
   |
26 | mod sys;
   | ^^^^^^^^
   |
   = help: to create the module `sys`, create file "/home/mvernacc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/errno-0.3.8/src/sys.rs" or "/home/mvernacc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/errno-0.3.8/src/sys/mod.rs"
   = note: if there is a `mod sys` elsewhere in the crate already, import it with `use crate::...` instead

error[E0425]: cannot find function `with_description` in module `sys`
  --> /home/mvernacc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/errno-0.3.8/src/lib.rs:47:14
   |
47 |         sys::with_description(*self, |desc| {
   |              ^^^^^^^^^^^^^^^^ not found in `sys`

error[E0425]: cannot find function `with_description` in module `sys`
  --> /home/mvernacc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/errno-0.3.8/src/lib.rs:58:14
   |
58 |         sys::with_description(*self, |desc| match desc {
   |              ^^^^^^^^^^^^^^^^ not found in `sys`

error[E0425]: cannot find value `STRERROR_NAME` in module `sys`
  --> /home/mvernacc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/errno-0.3.8/src/lib.rs:64:22
   |
64 |                 sys::STRERROR_NAME,
   |                      ^^^^^^^^^^^^^ not found in `sys`

error[E0425]: cannot find function `errno` in module `sys`
  --> /home/mvernacc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/errno-0.3.8/src/lib.rs:95:10
   |
95 |     sys::errno()
   |          ^^^^^ not found in `sys`

error[E0425]: cannot find function `set_errno` in module `sys`
   --> /home/mvernacc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/errno-0.3.8/src/lib.rs:100:10
    |
100 |     sys::set_errno(err)
    |          ^^^^^^^^^ not found in `sys`
[...]
Some errors have detailed explanations: E0425, E0583.
For more information about an error, try `rustc --explain E0425`.
error: could not compile `errno` (lib) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Compilation of your program failed
Caused by: Compilation of your program failed
Caused by: failed to execute `cargo build`: exited with exit status: 101
  full command: cd "[...]" && "cargo" "build" "--tests" "--target" "wasm32-unknown-unknown"

[...] indicates parts of the output I have omitted for brevity or privacy.
It appears that the errno create uses the sys module, which I guess is not available in wasm?
My project does not depend on errno directly. Running cargo tree --target wasm32-unknown-unknown indicates that errno is an indirect dependency of wasm-pack
[...]
└── wasm-pack v0.12.1
[...]
    └── which v4.4.2
        ├── either v1.10.0
        └── rustix v0.38.31
            ├── bitflags v2.4.2
            ├── errno v0.3.8
            └── libc v0.2.153

🌍 Your environment
Include the relevant details of your environment.
wasm-pack version: 0.12.1
rustc version: 1.78.0
OS: Ubuntu 22.04 on WSL2 within a Windows 10 host.

I have found the solution to my problem.
I had wasm-pack listed within the [dev-dependencies] of my project's Cargo.toml. Thus, compile step seems to attempt compiling wasm-pack itself into the wasm build. However, this is not possible because wasm-pack indirectly depends on the errno crate, which uses sys.
I believe the correct usage is to only install wasm-pack via its installer, and not to add it as a dev dependency of the project. wasm-bindgen-test is what belongs in the dev dependency list. At least that works for me now.

I hope it's ok that I made and closed my own issue. Perhaps this will be helpful to someone else who makes the same setup mistake I did.


create target pest group vocabulary

@F3RR3T and @Simo-climb
lets define the use case and then build stub vocab and contents

This actually already present, see (https://github.com/AGLDWG/phs-ont/vocabularies/pestTypes.ttl)


Support for Azure Blob Storage Target

Azure Blob Storage backend for Target. Transparently uploads and downloads text and binary objects to Azure Blob Storage
Description
Provides a AzureBlobTarget and AzureBlobClient. When reading, ReadableAzureBlobFile is used and when writing AtomicAzureBlobFile is used.
Use account name + account key for authentication or use shared-access-signatures (like an OAuth token). For saving/loading file, provide the azure blob container and azure blob name. There is an option to not download the file and just get the specific bytes in memory including specific bytes range (advanced usage).
Motivation and Context
While working on a project, I noticed that S3Target exists, but no such exists for Azure Blob Storage and I wanted to implement it since I wanted all my artifacts to remain under single cloud subscription (Azure)
Have you tested this? If so, how?
I have written united tests which is test/contrib/azureblob_test.py. It requires azure account name + key or a SAS token to run. The values can be passed or can be exported as environment variables
ACCOUNT_NAME - this is the actual name of your azure blob storage account.
ACCOUNT_KEY - this is the key (password) for the storage account. It has root like privileges, so not always a good idea to use it everywhere. (Documentation)
SAS_TOKEN - A shared access signature (SAS) provides you with a way to grant limited access to objects in your storage account to other clients, without exposing your account key. (Documentation)

The Azure tests, denote that there were 17 tests run, 11 of them skipped. So 6 actually ran which were the Azure tests. Do you know why the other 11 were attempted?

Those 11 tests were skipped as they did not satisfy the NOSE_ATTR value of azureblob. You can check that many tests are skipped even in case of py37-aws

Got it - Thanks @manish


update user-agent for qnamaker

update user-agent for qnamaker

Sets (or appends) the user-agent for QnAMaker as follows:
package-name/package-version (os-platform; node-platform)
for example on my machine I would get:
'qnamaker/1.0.33 (x64-Windows_NT-10.0.17763; Node.js,Version=v10.9.0)'

fixes #742

Pull Request Test Coverage Report for Build 1986

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.469%

Totals

Change from base Build 1980:
0.0%

Covered Lines:
4053

Relevant Lines:
5612

💛  - Coveralls


Enable renovate

Signed-off-by: Gábor Lipták<EMAIL_ADDRESS>https://github.com/marketplace/renovate

Thanks @gliptak. I've not used renovate before, but it looks very useful. I need to review with our internal open-source office to ensure we can use this. @brianwarner is this something we can use?


Remove tweedledum as a core dependency

Summary
Maintenance on tweedledum has stagnated in recent months, and is no longer stable enough on our Tier-1 (and other) supported platforms, especially as further Python versions are released.  This work was heralded by gh-8738, which contains more context on the change.

Details and comments
Fix #6981 (indirectly).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
251 unchanged lines in 12 files lost coverage.
Overall coverage decreased (-0.3%) to 84.416%

Files with Coverage Reduction
New Missed Lines
%

qiskit/algorithms/amplitude_amplifiers/amplification_problem.py
1
84.51%

qiskit/algorithms/amplitude_amplifiers/amplitude_amplifier.py
1
93.75%

qiskit/visualization/circuit/_utils.py
2
93.24%

qiskit/circuit/classicalfunction/types.py
4
0%

qiskit/circuit/classicalfunction/exceptions.py
8
0%

qiskit/circuit/classicalfunction/classical_element.py
9
0%

qiskit/circuit/classicalfunction/init.py
9
0%

qiskit/circuit/library/phase_oracle.py
16
36.36%

qiskit/circuit/classicalfunction/utils.py
25
0%

qiskit/circuit/classicalfunction/boolean_expression.py
35
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
61687

Relevant Lines:
73075

💛  - Coveralls

Fixed merge conflicts.

Apparently I must have fixed the merge in some way that didn't invalidate the review.  The conflict was really very minor, but pretty odd.


Use ABC for the forward model

The forward models are now inheriting from a ForwardModelBaseClass which implement some common tooling
needed by any forward model within TAMS:

handling of the source of noise
a step counter

Other common features can be added in the future if needed.
Only a few @abstractmethod are needed by the concrete forward models, all of which are private with the BaseClass handling the public methods:

_init_model()

_advance()

_make_noise()

[x] Add a time counter in baseclass

[x] Finish decorating the abstractmethod

Address #2


[editor] Fix Model Search to Ignore Casing

[editor] Fix Model Search to Ignore Casing
Previously, the model search was doing exact match, including capitalization. So, searching 'hu' would not show the "HuggingFaceTextGenerationParser".
Fix by making both search and model names lowercase when filtering:

Stack created with Sapling. Best reviewed with ReviewStack.

-> #756
#755
#754

Landing to unblock bug bashing, will fix forward as needed


fix: Better error for @pipe without step()

This problem was shared by a user.
Problem
The issue is caused by this node where @pipe_output does contain step() but the use of .when() (which interacts with the config) may mean no step is provided (relates to #1213)
@pipe_output(
    step(_foo).when(key="foo"),
    step(_bar).when(key="bar"),
)
def filtered_data(raw_data: pd.DataFrame) -> pd.DataFrame:
    return ...

This leads to this unhelpful error (trimmed). It indicates IndexError: list index out of range because the list of step is empty.
IndexError                                Traceback (most recent call last)
    354 builder = base_builder.copy()
--> 355 dr = builder.with_config(config).with_modules(cell_module).build()
    357 # determine final vars

File ..., in Builder.build(self)
-> 2153 return Driver(
   ...
   2161 )

File ...\hamilton\driver.py:466, in Driver.__init__(self, config, adapter, allow_module_overrides, _materializers, _graph_executor, _use_legacy_adapter, *modules)
    464     error = telemetry.sanitize_error(*sys.exc_info())
    465     logger.error(SLACK_ERROR_MESSAGE)
--> 466     raise e
    467 finally:
    468     # TODO -- update this to use the lifecycle methods
    469     self.capture_constructor_telemetry(error, modules, config, adapter)

File ..., in Driver.__init__(self, config, adapter, allow_module_overrides, _materializers, _graph_executor, _use_legacy_adapter, *modules)
    438 self.graph_modules = modules
    439 try:
--> 440     self.graph = graph.FunctionGraph.from_modules(
   ...
    445     )

File ...\hamilton\graph.py:726, in FunctionGraph.from_modules(config, adapter, allow_module_overrides, *modules)
    707 @staticmethod
    708 def from_modules(
    ...
    713 ):
   ...
--> 726     nodes = create_function_graph(
    727         *modules, config=config, adapter=adapter, allow_module_overrides=allow_module_overrides
    728     )

File ...\hamilton\graph.py:170, in create_function_graph(config, adapter, fg, allow_module_overrides, *modules)
    168 # create non-input nodes -- easier to just create this in one loop
    169 for _func_name, f in functions:
--> 170     for n in fm_base.resolve_nodes(f, config):
    171         if n.name in config:
    172             continue  # This makes sure we overwrite things if they're in the config...

File ...\hamilton\function_modifiers\base.py:833, in resolve_nodes(fn, config)
    831 except Exception as e:
    832     logger.exception(_resolve_nodes_error(fn))
--> 833     raise e

File ...\hamilton\function_modifiers\base.py:826, in resolve_nodes(fn, config)
    824 node_transformers = function_decorators[NodeTransformer.get_lifecycle_name()]
    825 for dag_modifier in node_transformers:
--> 826     nodes = dag_modifier.transform_dag(nodes, filter_config(config, dag_modifier), fn)
    827 function_decorators = function_decorators[NodeDecorator.get_lifecycle_name()]
    828 for node_decorator in function_decorators:

File ...\hamilton\function_modifiers\base.py:515, in NodeTransformer.transform_dag(self, nodes, config, fn)
    513 nodes_to_keep = self.compliment(nodes, nodes_to_transform)
    514 out = list(nodes_to_keep)
--> 515 out += self.transform_targets(nodes_to_transform, config, fn)
    516 return out

File ...\hamilton\function_modifiers\base.py:498, in NodeTransformer.transform_targets(self, targets, config, fn)
    496 out = []
    497 for node_to_transform in targets:
--> 498     out += list(self.transform_node(node_to_transform, config, fn))
    499 return out

File ...\hamilton\function_modifiers\macros.py:1317, in pipe_output.transform_node(self, node_, config, fn)
   1308 transforms = transforms + (step(__identity).named(fn.__name__),)
   1309 nodes, _ = chain_transforms(
   1310     target_arg=original_node.name,
   1311     transforms=transforms,
   (...)
   1314     fn=fn,
   1315 )
-> 1317 last_node = nodes[-1].copy_with(name=f"{node_.name}", typ=nodes[-2].type)
   1319 out = [original_node]
   1320 out.extend(nodes[:-1])

IndexError: list index out of range

Proposed solution
Have an helpful error message that says "@pipe_output is improperly defined and received no step. If you're using step(...).when(), make sure that your config enables at least one step() in the pipe"

Do we want to raise an error here or would it be better to return only the original node? So, in case no config_when conditions are met, pipe_output gets skipped?

Do we want to raise an error here or would it be better to return only the original node? So, in case no config_when conditions are met, pipe_output gets skipped?

I like the idea of "passthrough" when using @pipe and no config is specified. It would work with both @pipe_input and @pipe_output. It would be valuable to manage train/test implementation skew, for example, by adding processing steps when doing inference.
The main questions we have to answer:

Is this behavior intuitive and clear to the user?
Are there risks for it to fail silently?
Is it hard to debug?

I think this feature passes these assessments. The decorated function is intuitively the "default" implementation with step() being additive, and the visualization represents that clearly.
Side note: Currently, visualizing a @pipe will produce several nodes using the .with_step suffix, and changing configurations will modify how many .with_step nodes are present. Would it make sense to have an option to always display all of the step node and simply grey out which one were skipped for a given run?

I like the idea of "passthrough" when using @pipe and no config is specified. It would work with both @pipe_input and @pipe_output. It would be valuable to manage train/test implementation skew, for example, by adding processing steps when doing inference.
The main questions we have to answer:

Is this behavior intuitive and clear to the user?

That should be the case since it is the same as config. But, I'll put on my TODO. to add to docs/newexample.

Are there risks for it to fail silently?
Is it hard to debug?

Yeah, but that is on the user -- since you get to see the dag in the ui, should not be hard to debug / comes with the usual dev pittfalls as config.

I think this feature passes these assessments. The decorated function is intuitively the "default" implementation with step() being additive, and the visualization represents that clearly.
Side note: Currently, visualizing a @pipe will produce several nodes using the .with_step suffix, and changing configurations will modify how many .with_step nodes are present. Would it make sense to have an option to always display all of the step node and simply grey out which one were skipped for a given run?

uuuu, I like that idea, but I think that's an upstream feature on the level of config and potentially making this a toggle option for the ui / visualise api.


Assignment 3 Completion - Anton Rasmussen

Submission for Assignment 3, thanks!!

Please add the HTTP responses for A3.

@phonedude They were all in the README.md -- because you noted "But all of the data that I will read to grade your assignment will be contained in README.md" I put them in the README
Please let me know if you do not see them.


🐛 Fix generated C# clients using base URL

I do believe that the following PR introduced a typo in the #pragma directive.
https://github.com/RicoSuter/NSwag/pull/4634/files#diff-65b33706483249f53a8138451372e3d3276b904d815dcb71d0ed0c8786ea2e70R8
I think it slipped through testing because it only concerns generated C# clients generated using the UseBaseUrl=true option.
When trying to generate my client with this option enabled (unfortunately, I can't do without it), I'm getting the following compiler error on the #pragma restore disable 8618 line: error CS1633: Unrecognized #pragma directive.
I'm by no means an expert on these directives, but I do believe that the correct syntax is #pragma warning restore 8618.
This PR should fix the issue, introduced in NSwag 14.0.0.
Fixes: https://github.com/RicoSuter/NSwag/issues/4673

Is there an expected release date for this fix?


Database [wordpress] not configured.

My settings look like this, and still I can't get it to work...
'wordpress' => [
'driver'    => 'mysql',
'host'      => 'localhost',
'database'  => '',
'username'  => '',
'password'  => '********',
'charset'   => 'utf8',
'collation' => 'utf8_unicode_ci',
'prefix'    => 'blei_',
'strict'    => false,
'engine'    => null,
],

Hi @Thovalot are you using Laravel, right? Did you configure your models to use wordpress connection?

Yes, sorry there was something wrong with the server, locally it worked, I deleted everything and git pushed again and it worked, thanks.

you're welcome @Thovalot! any problem just ask :-)


Update Koala dependency

Hi!
Could you please update the dependencies to use the most recent version of Koala?
Bundler could not find compatible versions for gem "koala":
  In Gemfile:
    zuck (~> 1.0.0) ruby depends on
      koala (~> 1.6.0) ruby

    koala (1.10.1)

Zuck's now on the current koala :)


Migrate to operator-sdk 1.x

Fixes here: https://github.com/jaegertracing/jaeger-operator/pull/1623


PyBridge 1.3.0 not loading on Apple Silicon

I'm seeing this:
% dotnet run
Loading Phi2 from huggingface model weight folder
Unhandled exception. System.BadImageFormatException: Could not load file or assembly 'TorchSharp.PyBridge, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. An attempt was made to load a program with an incorrect format.

File name: 'TorchSharp.PyBridge, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
   at PhiForCasualLM.FromPretrained(String modelFolder, String configName, String checkPointName, ScalarType defaultDType, String device)
   at Program.<Main>$(String[] args) in Torchsharp-phi/Program.cs:line 28
%

Great catch! The package wasn't targeting the arm64 platform and therefore wasn't being recognized.
Should be fixed with https://github.com/shaltielshmid/TorchSharp.PyBridge/commit/00d739e374e257989bdfb6da0be43e5426c68a1e, uploaded to NuGet as version 1.3.1

Fix verified.