pull from private registry returns 404 when not logged in.

pulling from a privately hosted registry instead should ask me to login if I am not.
instead it says the image is not present.
spent last 4 hours to discover this :(

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

This is common behavior, as it makes sure to not leak information about private things.
If it returned something like a 401 Unauthorized, then this tells someone (ie, someone trying to skim information) that there is indeed an image there, where as 404 does not leak this information.

as a corollary, if the user is not authenticated - irrespective of whether the file is there or not -> return a 401 ...
so the server says authenticate yourself and then ask me if I have the file.

This sound like an issue that's better discussed in the https://github.com/docker/distribution repository, or in the #docker-distribution IRC channel.
Could you reopen this issue there, or discuss it on IRC?
I'm going to close the issue here, because this is not something that can be resolved in the docker client. Thanks for reporting though!

Still on docker-registry 1.0 - would need to migrate to Distribution (registry 2.0) first, to check if issue can be reproduced there too.

@sslavic I don't think registry 1.0 is still actively maintained, so if you want this changed, then registry 2.0 is the best choice. It will need to be discussed with the maintainers of that repository though, because this is by design (see the discussion above)

Strange design - not return 401 because that may signal image is there?! For me 401 means I do not have access to server, not to image. I authenticate myself to server, not to image.
After successful authentication, if I do not have privileges to access specific image/resource - then return 403.
Server/design should differentiate authentication and authorization.

I think this should possibly be reopened, unless it is a duplicate of #15759. The registry (v2.5) returns status 401 when querying /v2. The problem is that Docker Engine then tries again on /v1, gets a 404 error for that (since the private registry doesn't support v1), and reports that error.

@bmerry can you open a new issue, and exactly describe what you think needs to be fixed in the docker engine?


Update Rust.gitignore

Reasons for making this change:
This echoes changes proposed in https://github.com/rust-lang/rustfmt/pull/3919 - and includes editor/OS specific conditions that are already added in that file.
Links to documentation supporting these rule changes:
The rustfmt .gitignore was originally generated via https://github.com/toptal/gitignore, (as mentioned in the first line of https://github.com/rust-lang/rustfmt/blob/master/.gitignore)
That tool uses this repo as a source (See section 2 Patch in https://github.com/toptal/gitignore#files).
This is just to keep things consistent.

Updated to just include the differences already shown with https://github.com/rust-lang/rustfmt/blob/master/.gitignore - comment on https://github.com/rust-lang/rustfmt/pull/3919 states the other files aren't needed here.

@lazysoundsystem thanks for the contribution, but these rules overlap with existing templates in the Global directory:

Global/macOS.gitignore
Global/JetBrains.gitignore
Global/VisualStudioCode.gitignore
Global/Vim.gitignore

I've been declining PRs like this in the past because the other templates are more complete, and the duplication of rules, while convenient for users, has become a maintenance burden that I'm not interested in supporting currently...

@shiftkey - fair enough! Thanks for the explanation and sorry for the noise.


Codespace install web app installs a corrupted app

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: August 2022
OS Version: Android 12

Steps to Reproduce:

Create a new codespace from your github account
When you open the codespace in the browser you can click on install app icon to install a web app of this codespace
Opening the web app will show a blank page with the words "Not found"
Try to debug the app or get the link you will see an extra ˋ/staticˋ keyword added to the url which makes it a not found page

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Duplicate of https://github.com/microsoft/vscode/issues/159800


Support all aliased RSpec expectations

RSpec expectation is supported, but not all their aliases:
require 'rspec/json_expectations'

describe 'sample' do
  it 'passes with original matcher' do
    json = '{"foo":"bar"}'
    expect(json).to include_json(
      foo: be_a_kind_of(String)
    )
  end

  it 'should have succeeded' do
    expect('bar').to a_kind_of(String)
  end

  it 'fails' do
    json = '{"foo":"bar"}'
    expect(json).to include_json(
      foo: a_kind_of(String)
    )
  end
end

Here a_kind_of is an alias of be_a_kind_of. I find the noun-phrase aliases fit better here. Notably be_kind_of, another alias of be_a_kind_of, is supported. Any reason to reject the noun-phrase?

Also finding this a bit annoying, small hack around it
In json_traverser.rb
12: RSPECMATCHERS = defined?(RSpec::Matchers) ? [RSpec::Matchers::BuiltIn::BaseMatcher, RSpec::Matchers::AliasedMatcher] : []
99: return nil unless expected.is_a?(RSpec::Matchers::BuiltIn::BaseMatcher) ||
            expected.is_a?(RSpec::Matchers::AliasedMatcher)

Seems to work fine now


Question: Grafana Cloud like dashboards for Grafana on-prem

https://github.com/kubernetes-monitoring/kubernetes-mixin is mentioned as the base of the dashboards used in Grafana Cloud, but is it the best way to get similar dashboards to Grafana on-prem? I tried some dashboards from kubernetes-mixin and I get mostly "no data", so either the dashboards need tweaking and/or rules, labels whatnot need changes.
In other words, what would be the most effortless way to have working dashboards like in Grafana Cloud related to this project?

Thanks @skl for the answer, I'll check the fork out!


Add comment to remind develop if config updated

Shall we also add this note to the PR template?

Shall we also add this note to the PR template?

It's better ti make a PR template. This can be a part of it.

It's better ti make a PR template. This can be a part of it.

please follow this https://docs.github.com/cn/free-pro-team@latest/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository to create one?

please follow this https://docs.github.com/cn/free-pro-team@latest/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository to create one?


Add WCH Highschool

add student.wchcs.org

@Jinthium Please provide us with:

the school official website URL
the school street address, including city and country
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@Jinthium You might miss my previous comment. Please react.

@Jinthium I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!

URL: https://www.wchcs.org/washingtonhighschool_home.aspx
Address: 400 S Elm St, Washington Court House, OH 43160
Proof:


Create an API util file to dynamically manage headers and JWT based upon env

Feature
Extend API architecture with a util/config file that utilizes async / await with Axios.
Why is this feature being added?

This solves a potential DRY issue with utilizing API calls in local state. As it stands, we're redefining a lot of things like URLs and Endpoints while failing to utilize thinks like tokens and JWT. By conglomerating API configuration to a single file, people can import the utility and use it as simply as
import API from 'api/util`;

API.ACTION(endpoint, payload);

What should your feature do?
First draft of code to be posted soon.

Moved to low priority since this won't really matter until we have a development API.

Edited the issue after conversation with @sethbergman - this will be a good move!

Dupe #329


Blog page added click "create a blog " for blog menu and 6 sample templates is present

there's a small mistake can you make in index.html { please change href="/blog.html"  href="./blog.html" ] just add a dot and on blog.html [please change href="/blogs/blog{number}.html" to href="./blogs/blog{number}.html"]  wont take much time

its showing 404 not found

Please fix this issue ASAP @hilalsidhic

yeah i'm fixing it

#69


fix(#267): nodewatcher memory leak(s)

#267

[x] : in main loop, use let instead of const, set reference to null when out of scope
[x] : in each task, clean up any intermediate references
[ ] : make sure to remove event listeners once they go out of scope if there are any
[ ] : make sure only just as many network connections are opened as needed
[ ] : eliminate any accidental global variables
[ ] : test locally

to test locally:

in back/nodewatcher, run yarn build
in back/nodewatcher/lib run PRISMA_ENDPOINT=http://<IP_ADDRESS>:4466 START_FROM=2058228 node --inspect --expose-gc ./index.js
in browser, go to about:inspect
click Open dedicated DevTools
take heap snapshot

see also:

https://medium.com/@_lrlna/garbage-collection-in-v8-an-illustrated-guide-d24a952ee3b8
https://auth0.com/blog/four-types-of-leaks-in-your-javascript-code-and-how-to-get-rid-of-them/
<EMAIL_ADDRESS>https://developer.mozilla.org/en-US/docs/Web/JavaScript/Memory_Management
https://nodejs.org/en/docs/guides/debugging-getting-started/
https://www.ibm.com/developerworks/web/library/wa-memleak/

Did you get some noticeable improvements with this already?

it's 4-5k fewer references but that could be attributable to non-determinsm in the garbage collection. will test again after i finish the second checkpoint.

it looks...slightly better. but not enough.
Retained Size:
Before
Object: 46%
Array: 43%
closures: 36%
After
Object: 37%
Array: 38%
closures: 34%

not going to waste more time on this approach for now, will reassess after https://github.com/paritytech/Nomidot/pull/324 which is probably the better solution.


Add Kubernetes to the bash script

Signed-off-by: navendu-pottekkat<EMAIL_ADDRESS>Description
Running the command shown below will ask the user for prompt on which platform to deploy Meshery. It also supports Kubernetes platform now.

[x] Yes, I signed my commits.

I'm not able to commit changes to your PRs for some reason.


window.open doesn't support all standard functionality

We have made several changes to the window.open functionality to use the native blink/chromium code, but we are always working with embedded views so I'm looking for a little help to upstream this without breaking other use cases
Starting from https://github.com/brave/electron/commit/6ee28c3927a34495fb0a059ac3071e6e14358743 to https://github.com/brave/electron/commit/9dc98b1448f1efa1f2898fb714643df2b3474b12
We are working on getting the remaining electron tests passing and I'm happy to create a pull request as the basis for this, but some help/feedback would be welcome. Thanks!

also have new tests that we can move from https://github.com/brave/browser-laptop to electron for the currently unsupported or incomplete functionality

This looks great - I assume you're talking about some of the strWindowFeatures? If so, I can really see how a bunch of other developers will rejoice if support is improved.

for us it was mostly about complete cross-window scripting support with the correct security restrictions, but it comes with other benefits as well

I'm afraid we can not merge it.
Currently we have to guarantee that each WebContents maps to exact one renderer process, however your change would make the two WebContents share one renderer process.
We do this because:

Many settings of webPreferences are process wide;
Node is not perfectly safe when creating two Node environments in one process;
Node leaks resources when a Node environment is destroyed (e.g. when a WebContents is destroyed);
Chromium leaks memory when reloading/navigating/closing page;
The renderer process has to be restarted when reloading/navigation happens, so we can make Node happy and assure not leaking resources.

Therefore as long as you are creating two WebContents in one renderer process, you are never going to fix all the failing specs of Electron. It also means we can never support window.open with normal ways.
I'm closing this as a duplicate of #1865.

There is definitely another render process created when we open a child window using this code. When would they end up in the same process?

There is definitely another render process created when we open a child window using this code. When would they end up in the same process?

It is probably because the URL passed to window.open is in a different origin, in this case Chromium would choose to create a new renderer process.

The original issue we were targeting was Feedly login through Google. The child window is same origin and runs in it's own renderer process.

We have tests for both same and different origin and both work correctly with correct origin-based access to parent/child

@bridiver Does the contentWindow property work? And can you print the process.pid in each window and see whether they are same.

I'm not sure exactly what you are looking for with the contentWindow property. Can you give me an example you expect to fail?

I did verify that process.pid is different in each and also by ps

I can verify the postMessage, close, focus, blur and eval all work in both directions (eval only in same origin per http://www.w3.org/TR/html5/browsers.html#security-window)

@bridiver I have built your fork and opened the default app but following code doesn't seem to work in devtools console?
var w = window.open('http://github.com', 'nodeIntegration=true');

I can verify the postMessage, close, focus, blur and eval all work in both directions (eval only in same origin per http://www.w3.org/TR/html5/browsers.html#security-window)

Can you try whether the contentWindow property works?

Blocked by popup blocking. Has to be user initiated

contentWindow? From an iframe? Are you looking to see if you can establish bi-directional communication from different origins (postMessage)? Is there a test case in Electron I can run it against?

I created a local main.html:
<html>
<head>
  <title>Electron</title>
</head>
<body>
<button onclick="doclick()">open</button>
<script type="text/javascript" charset="utf-8">
  function doclick() {
    console.log('click');
    window.w = window.open('http://github.com', 'nodeIntegration=true');
  }
</script>
</body>
</html>

Load it in a BrowserWindow, click the button, program crashed.

Sorry, I should be clear that the current code only supports guest -> guest, but that is not a limitation of the code itself, that is just the only part we have implemented because that is all that we needed. Obviously we have to support all use cases before it can be upstreamed and that's what this issue was opened for. We are working on that portion of it, but any help is welcome. This code is working in our browser and we have several test cases for it there that we will move to Electron.

Here's what I propose: we have a working implementation that I believe satisfies your requirements (separate renderer process/access to all properties by origin policy), but it needs to be expanded to cover window <-> window. Can we reopen this ticket pending those updates? If for some reason it can't cover all use cases we can implement it to only be used in the cases it does cover or only by flag.

This issue is closed because it is a duplicate of #1865.
I don't think we should ever add a flag that only solves one special use case while breaking all other apps, no one except you will use it and we are not able to maintain it.

Fair enough, I think we can make it work for all cases anyway. I'll make a quick reference to our code in the other ticket in case anyone else wants to take a look.

I have a few questions about your original comment so I can understand your concerns a little better and hopefully improve Electron for everyone:

Many settings of webPreferences are process wide
If the child window is in the same browsing context then shouldn't it have the same web preferences? If not it definitely wouldn't be in the same process and would have limited access to the child/opener

Node is not perfectly safe when creating two Node environments in one process;
If they are in the same process then wouldn't this only matter if node integration is enabled?

Node leaks resources when a Node environment is destroyed (e.g. when a WebContents is destroyed);
The webContents live in the main process, so why would this be an issue for the renderer process?

The renderer process has to be restarted when reloading/navigation happens, so we can make Node happy and assure not leaking resources
I did notice that the child window loses the opener reference on reload (this doesn't happen in Chrome or Safari). This appears to be because webcontents.reload is actually implemented in Electron as a load of the current url. Either way wouldn't we just have to re-attach the webcontents to the renderer after restart?

Thanks!

I made a mistake earlier, I was looking at the pid for the window, not the embedded webview. The two webviews do indeed share the same renderer process. I also see the memory issue you are referring to, but I have an almost complete fix for that. The issue is that a new node environment is created for every new script context in addition to the "global" environment that is created but never loaded. That isn't a problem right now because almost every navigation forks so you effectively end up with a process per page load. Destroying the node environment leaks memory, but a single node environment can have multiple contexts associated with it that can be sandboxed. My only remaining issue is the preload script, but I a proof of concept for that and just need to finish the implementation. The only time a node environment will be shared between more than one JS context is when they are connected through a scriptable opener. In cases of page navigation one associated JS context is swapped out for the next and different origin windows will be in different processes as normal.


[cxx-importer] Disable some tests on windows only on 5.4

Just noticed these failed when I was trying to land a different change to 5.4.
Trying to keep the PR test green.

#37379 actually fixes the tests on all the platforms.


After setting powerline font, air line has a font dislocation.

If using a double width char, the font dislocation can be solved, but there is another problem which is that there are white spaces between the special font and content in airline.

I have did with it by myself.
"if v:lang =~? '^(zh)|(ja)|(ko)'
"    set ambiwidth=double
"endif
Comment these and everything all right.
Sorry.


Erroneous "Your recent uploads have no location"

Steps to reproduce

Uploaded many pictures without EXIF location.
Uploaded one picture WITH EXIF location (via Nearby, not sure whether it matters).

Not sure whether reproducible every time.
Expected behaviour
This message should not appear, as the picture being uploaded has location.
Actual behaviour

Android version
8
Commons app version
master
Would you like to work on the issue?
Prefer not

i would like to work on this issue

@Aman16-ai It is yours, thanks!

Hi @nicolas-raoul, it's been some time since this issue was assigned and I'd like to try my hand with it if that's alright.

@chan-j-d It is yours now, thanks!


Make sure timeline page not broken

Goal

Fix broken page https://bestofjs.org/timeline

After some investigation, the reason this page is broken is the data in src/components/timeline/featured-projects.json, which has angular-1 and vuejs. But data get from https://bestofjs-static-api.vercel.app/projects.json (state.entities.projects) does not have angular-1 and vuejs (but have angular, vuejs-2, vuejs-3). Then, logic in useTimelineProjects make the page broken.
function useTimelineProjects() {
  const projects: BestOfJS.Project[] = useSelector(
    findProjectsByIds(featuredProjects.map(({ slug }) => slug))
  ); // CONTAIN `null`
  return featuredProjects.map(({ slug, date, comments }) => {
    const project: BestOfJS.Project | undefined = projects.find(
      (project) => project.slug === slug // CANNOT FIND slug of null
    );
    if (!project) return null;
    return {
      comments: comments || [],
      date: date || new Date(project.created_at),
      ...project,
    };
  }); // CONTAIN null project
}

This PR tries to make the page not broken. It just doesn't render the project which is missing data. However, the root cause is the data from the server is missing/ inconsistent. We still need to update the data since data inconsistency is the root cause. (But unluckily, I haven't found where to update, please help with that).
How to test

npm run start then head to http://localhost:3000/timeline. We should be able to see the page rendered (without Angular and Vue, have 18/20 projects).

Screenshots
See above

@michaelrambeau Could you please look at this? https://bestofjs.org/timeline is currently broken in production. Thanks.

@nvh95 it's live, thank you again!
Among the other things I have to fix,  we need a better error handling (using "ErrorBoundary") to avoid showing the default error page (that sometimes shows up after the site is updated, because of code splitting).
I will take a look at this and "restore" the missing projects.

@michaelrambeau Ah it makes sense to me now. Let me see if I can improve it.
The idea is still show the default error page, but with a box contains more error info (which can toggle on or off?). So it's easier to locate the bug faster.

@nvh95  About the error handling, the main thing is to avoid breaking the whole user experience if something minor breaks.
For now there is only one level of error handling, it's better than nothing because we show an error page with a message, and navigation links to let the user "escape".
If there was no error handling, it would be just a white page with nothing displayed since everything is displayed.
However the current error handling is not great, because some parts in the app are more fragile but should not lead to the error page if they break.
For example in the top page, there is a kind of carousel that shows the featured projects.
If it breaks, we don't want to show the whole error page, we only want to either remove the broken part of show something that says the feature is not available.
Actually https://remix.run/ top page explains well how applications should be resilient, check their feature called "route error boundaries".
But don't worry if you don't have time, there are so many things to improve 😄 !

I have just rebuilt Best of JS data to include the projects that were missing.

@michaelrambeau

However the current error handling is not great, because some parts in the app are more fragile but should not lead to the error page if they break.

We can add more Error Boundaries to the fragile parts of the app, with customize fallback UI in each part:

https://github.com/bestofjs/bestofjs-webui/blob/bb662931fe8e965e74575ebb036727436f85cd2f/src/components/home/home.tsx#L70
Do you have a list of fragile parts in the app. I can help to add more Error Boundaries there.
Remix with react-router v6 is very promising. But I think that's the story of the near future, not immediately.

Thank you for your help on this topic too @nvh95
The first step is to identify what is the shell of the application and not what are the extra features, non essential, especially the ones that seem to be more fragile.
The goal is: if an extra feature breaks, we don't want the shell to be broken.
To me the shell is made of the features implemented by processing the huge JSON data: basically all project and tag lists, including search features.
We should start with the most important page, the top page:

shell: "Hot Projects", "Popular Tags", "Recently Added"
extra: "Featured Projects", "Monthly Rankings"

And I'd start by ensuring that the "featured projects" block can break without damaging the user experience because it's has a combination of dangerous elements: timeouts, animations, intersection, observer (used to detect when the element is not visible).
Another interesting page to check is the "Project Details" page because there are 2 extra API calls to get project statistics and README data. I think there is already some error handling related to the API calls but it would be safer to ensure that the page's  shell (basically the block at the top with the project links) can be displayed even if an error occurs when processing data.
The next step is to go "one lever deeper" and to investigate for any given element, what is essential, what can break... but I'm not sure we need to go so far, we may have other priorities.
Note: I mentioned Remix because they explain well the concept on their home page, I was not advocating using their router in our current application.


[Event Request] codeunit 6500 "Item Tracking Management" - OnRetrieveInvoiceSpecificationOnAfterTrackingSpecificationFilterSet

Please add new event in codeunit 6500 "Item Tracking Management"
[IntegrationEvent(false, false)]
local procedure OnRetrieveInvoiceSpecificationOnAfterTrackingSpecificationFilterSet(SourceSpecification: Record "Tracking Specification"; var TrackingSpecification: Record "Tracking Specification")
begin
end;

procedure RetrieveInvoiceSpecification(SourceSpecification: Record "Tracking Specification"; var TempInvoicingSpecification: Record "Tracking Specification" temporary) OK: Boolean
var
    TrackingSpecification: Record "Tracking Specification";
    ReservEntry: Record "Reservation Entry";
    TempTrackingSpecSummedUp: Record "Tracking Specification" temporary;
begin
    OK := false;
    TempInvoicingSpecification.Reset();
    TempInvoicingSpecification.DeleteAll();

    ReservEntry.SetSourceFilter(
        SourceSpecification."Source Type", SourceSpecification."Source Subtype", SourceSpecification."Source ID",
        SourceSpecification."Source Ref. No.", true);
    ReservEntry.SetSourceFilter(SourceSpecification."Source Batch Name", SourceSpecification."Source Prod. Order Line");
    ReservEntry.SetFilter("Reservation Status", '<>%1', ReservEntry."Reservation Status"::Prospect);
    ReservEntry.SetFilter("Item Tracking", '<>%1', ReservEntry."Item Tracking"::None);
    SumUpItemTracking(ReservEntry, TempTrackingSpecSummedUp, false, true);

    OnRetrieveInvoiceSpecificationOnAfterTrackingSpecificationFilterSet(SourceSpecification, TrackingSpecification);
    if TrackingSpecification.FindSet then

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 48444.


not support indexTitle?

New issue checklist

[x] I have reviewed the README and documentation
[x] I have searched existing issues and this is not a duplicate
[ ] I have attempted to reproduce the issue and include an example project.

General information

IGListKit version:
iOS version(s):
CocoaPods/Carthage version:
Xcode version:
Devices/Simulators affected:
Reproducible in the demo project? (Yes/No):
Related issues:

Debug information
# Please include debug logs using the following lldb command:
po [IGListDebugger dump]

Hi @OtsoTieto!
I'm afraid we don't have enough information to help here. Please make sure to fill out the issue with as much information as you can.
I'll close this for now, but once you've updated the issue, please feel free to re-open. Thanks!


A  modal (Popup) is required during "Export as CSV" operations

A modal with a short message "Export in progress..." or a small spinner. The modal will not have header and footer, and the closing of the modal will be made by the controller which does the export.


Rules' error handling

An error occurs when the user enters rules and requests with different keys set.
An error occurs when the user enters an empty set of rules for some field(s).
both of these cases should be handled.

@iko1133, if you haven't started yet, I could take this issue :)

@mateuszz0000 sorry, i have already started working on it :) will probably done today or tomorrow


document "classic" properties

Style guide states:
When relying on properties that are implemented by the widget host control, such as the classic color and pattern properties, include metadata definitions to display them in the PI, but do not include a property definition.

Because there is no property definition, the documentation for the host control property must be placed in the top-level documentation block comment before the start of widget definition.

So we should have a page for these

https://github.com/macMikey/LCB-missing-manual/wiki/properties
needs some documentation, i think.

Also needs to include things like scroll (and the alias vscroll)

I found other keywords, like "margins" (which I'm trying to implement in the navBar) that aren't mentioned...SURPRISE.


Add policyID param to CompleteOnboarding API

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/48745
https://github.com/Expensify/App/issues/50637
PROPOSAL: https://github.com/Expensify/App/issues/48745#issuecomment-2345255157
Tests

Login with a new account
Select Manage my team's expense
Select any company size
Verify a WS is created after selecting the company size
Select any integration or select None of the above
If the user selects any integration verify that an integration task is created in  the Concierge chat
Click on the task to verify that the title and description are correct with the selected integration
Click on the accounting link
Verify that the accounting feature is enabled and the accounting page is opened
If the user selects None of the above verify that no integration task is created and the accounting feature of the WS is not enabled.

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Login with a new account
Select Manage my team's expense
Select any company size
Verify a WS is created after selecting the company size
Select any integration or select None of the above
If the user selects any integration verify that an integration task is created in  the Concierge chat
Click on the task to verify that the title and description are correct with the selected integration
Click on the accounting link
Verify that the accounting feature is enabled and the accounting page is opened
If the user selects None of the above verify that no integration task is created and the accounting feature of the WS is not enabled.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/e00bc057-4ab3-4e5c-a261-3e444c00e9a2

Android: mWeb Chrome
https://github.com/user-attachments/assets/c0a29be3-c365-4fb6-9f61-b50a2eb9bfcd

iOS: Native
https://github.com/user-attachments/assets/bc073cef-d57f-4f81-8ed3-2a49d0a98512

iOS: mWeb Safari
https://github.com/user-attachments/assets/7b318c1e-b867-4c8d-b3ee-bd34897c903a

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/f2994cd0-231c-4add-b1de-23757834ee90

MacOS: Desktop
https://github.com/user-attachments/assets/4aeccd33-b2a0-4704-acc6-09fb003457b9

Is this ready yet? ETA please @nkdengineer ! Thanks!

@marcaaron Yes, all is done, only need to update the type of accounting task.

@s77rt Please help to check again.

https://github.com/Expensify/App/issues/50637 is not fixed yet. cc @marcaaron Can you please double check if we are actually enabling the accounting feature in the CompleteGuidedSetup API level? and if policyID is the right param to send the policy id over
https://github.com/user-attachments/assets/5f079be6-1016-4eef-a0f2-500857a98306

Yes, I made the change a long time ago and it is live. We need to pass policy and the correct task addAccountingIntegration and it should update the policy.areConnecionsEnabled value to true. What does it look like?

Oh, I see the problem now after testing. We do need one more PR. Sorry, let me look into this.

Backend change we need is merged. Sorry, about the delay @nkdengineer @s77rt. I should have caught this small detail sooner. It should be deployed very soon!

We should be good to proceed now 🤞

Just tested again and it works well now. All yours @s77rt.

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/8248dcd9-a94c-4e3e-beda-ba17aa521ef4

Android: mWeb Chrome

https://github.com/user-attachments/assets/2568b249-3dd3-4620-8340-effa807bb191

iOS: Native

https://github.com/user-attachments/assets/85437ced-4e0d-4b2b-8c2b-657dca8d41c2

iOS: mWeb Safari

https://github.com/user-attachments/assets/64e8402f-569d-4caa-bdb1-edf6fb5646ec

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/c98bfb58-3bb3-4c66-b86f-a7272db24fa3

MacOS: Desktop

https://github.com/user-attachments/assets/3efb26ba-1082-45f7-84f4-6a362e2238ac

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Document configuration file

The search paths for tex-fmt.toml along with what fields are defined should be documented.
My feeling is that as a first shot at this, it should go into the README, but longer term, rustdoc might be a better approach for documentation as a whole.

The search paths for the configuration file are currently listed in the README under the "Configuration" section. I might look into rustdoc, or similar documentation hosting, soon.


Add the rest of the DOME functionality

Starting with dodecahedron-based geodesics

Torus geodesics would be cool too, to create structures like the Changi Jewel

Implement rotation and spherical-to-cartesian coordinate conversion in a separate class from the pure geodesic math


When will be the full code made available?

Hello there, loved reading your paper and am very keen to test your code. Can you tell when will be the complete code made available?
Thanks!

Hi, I have uploaded the models and scripts. I would close this issue, and please re-open it if necessary.


As a new user I want to have the application provide a user-friendly tutorial

so that I can understand its features

Not implemented.


Change 'resolveCustomEditor' to 'resolveCustomTextEditor' [typo]

Testing #99003
Under lifecycle docs: https://code.visualstudio.com/api/extension-guides/custom-editors#custom-text-editor-lifecycle
Change:

Once resolveCustomEditor returns, our ...

to:

Once resolveCustomTextEditor returns, our ...

Fixed by https://github.com/microsoft/vscode-docs/commit/05ecfcaa24ed7fcfe5d450da4a74ab95055ba4d8 (in vnext branch of docs)


Disable cops for offensive files only (Issue #1696)

This patch provides solution for issue #1696. When run with option --auto-gen-config, instead of setting Enable: false for the cop, it sets Exclude: for the list of files where offense happened.
bin/rubocop -V
0.29.1 (using Parser <IP_ADDRESS>, running on ruby 2.1.5 x86_64-darwin14.0)

@wired9 I think you should run ./bin/rubocop --auto-gen-config and include the changes to .rubocop_todo.yml in the pull request.

@wired9 Any chance you could finish up this PR? Seems like a really useful feature.

Closing this issue since #1980 has been merged.


🐛 [firebase_storage] Object not found exception

Bug report
When trying to get file reference from downloadUrl, firebase storage throws object not found exception while the object is present in the storage.
Describe the bug
Previously raised issue #4218, the crash was not caused due to downloading the file but the refFromUrl method was throwing the exception
Steps to reproduce
Steps to reproduce the behavior:
1.Upload a file to firebase storage with file name (eg: audio session.mp3)
2.Get the download url
3.Now from app, try this  FirebaseStorage.instance.refFromURL(downloadUrl)
4.This throws storage exception (attached crash logs)
Expected behavior
It should return the firebase storage reference to that file

Additional context
Crash Logs
E/StorageException(15412): StorageException has occurred.
E/StorageException(15412): Object does not exist at location.
E/StorageException(15412):  Code: -13010 HttpResult: 404
E/StorageException(15412): {  "error": {    "code": 404,    "message": "Not Found.  Could not get object",    "status": "GET_OBJECT"  }}
E/StorageException(15412): java.io.IOException: {  "error": {    "code": 404,    "message": "Not Found.  Could not get object",    "status": "GET_OBJECT"  }}

Flutter doctor
Click To Expand
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.1 20C69 darwin-x64, locale en-GB)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
[✓] Xcode - develop for iOS and macOS (Xcode 12.4)
[✓] Android Studio (version 4.1)
[✓] Connected device (1 available)

Flutter dependencies
Click To Expand
Dart SDK 2.10.5
Flutter SDK 1.22.6
teal 2.4.7+42

dependencies:
- agora_rtc_engine 3.2.1 [flutter flutter_web_plugins json_annotation]
- animations 1.1.2 [flutter]
- app_settings 4.0.4 [flutter]
- apple_sign_in 0.1.0 [flutter]
- audio_service 0.16.2 [audio_session rxdart flutter_isolate flutter_cache_manager sqflite js flutter flutter_web_plugins]
- audio_session 0.0.11 [flutter flutter_web_plugins rxdart]
- audioplayers 0.17.0 [uuid path_provider flutter flutter_web_plugins]
- camera 0.7.0+1 [flutter camera_platform_interface pedantic quiver]
- chewie 0.12.2 [cupertino_icons flutter video_player wakelock]
- cloud_firestore 0.16.0 [flutter meta quiver firebase_core firebase_core_platform_interface cloud_firestore_platform_interface cloud_firestore_web]
- cloud_functions 0.9.0 [meta flutter firebase_core firebase_core_platform_interface cloud_functions_platform_interface cloud_functions_web]
- connectivity 2.0.2 [flutter meta connectivity_platform_interface connectivity_macos connectivity_for_web]
- crypto 2.1.5 [collection convert typed_data]
- device_apps 1.2.0 [flutter]
- dio 3.0.10 [http_parser path]
- extended_image 1.5.0 [flutter extended_image_library meta]
- firebase_analytics 7.0.1 [meta flutter firebase_core firebase_analytics_web firebase_analytics_platform_interface]
- firebase_auth 0.20.0+1 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- firebase_core 0.7.0 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_crashlytics 0.4.0+1 [flutter stack_trace firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface]
- firebase_database 6.0.0 [flutter firebase_core]
- firebase_dynamic_links 0.7.0+1 [flutter firebase_core]
- firebase_messaging 8.0.0-dev.14 [meta flutter firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web]
- firebase_performance 0.5.0+1 [flutter firebase_core]
- firebase_remote_config 0.6.0 [flutter firebase_core]
- firebase_storage 7.0.0 [flutter firebase_core firebase_core_platform_interface firebase_storage_web firebase_storage_platform_interface quiver]
- fit_kit 1.1.2 [flutter]
- flushbar 1.10.4 [flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_conditional_rendering 1.1.1 [flutter]
- flutter_date_pickers 0.1.10 [flutter intl flutter_localizations]
- flutter_document_picker 4.0.0 [flutter]
- flutter_facebook_login 3.0.0 [flutter collection]
- flutter_icons 1.1.0 [flutter]
- flutter_image_compress 0.7.0 [flutter]
- flutter_local_notifications 4.0.0 [flutter flutter_local_notifications_platform_interface platform timezone]
- flutter_phone_state 0.5.9 [flutter url_launcher logging uuid stream_transform]
- flutter_rating_bar 3.2.0+1 [flutter]
- flutter_swiper 1.1.6 [flutter transformer_page_view flutter_page_indicator]
- flutter_widget_from_html_core 0.5.1+4 [flutter html]
- flutter_youtube_view 1.1.9 [flutter]
- google_sign_in 4.5.9 [google_sign_in_platform_interface flutter meta google_sign_in_web]
- http 0.12.2 [http_parser path pedantic]
- image_picker 0.6.7+22 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- intl 0.16.1 [path]
- just_audio 0.6.9 [just_audio_platform_interface just_audio_web audio_session rxdart path path_provider async uuid crypto meta flutter]
- launch_review 2.0.0 [flutter]
- liquid_progress_indicator 0.3.2 [flutter]
- loading_indicator 1.2.0 [flutter async]
- open_file 3.0.3 [flutter ffi]
- path_provider 1.6.27 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- permission_handler 5.0.1+1 [flutter meta permission_handler_platform_interface]
- popup_menu 1.0.5 [flutter]
- provider 4.3.3 [collection flutter nested]
- razorpay_flutter 1.2.3 [flutter eventify]
- rxdart 0.24.1
- sembast 2.4.8+1 [meta path synchronized]
- share 0.6.5+4 [meta mime flutter]
- url_launcher 5.4.11 [flutter url_launcher_platform_interface url_launcher_web url_launcher_macos]
- uuid 2.2.2 [crypto convert]
- video_player 1.0.1 [meta video_player_platform_interface video_player_web flutter]
- wakelock 0.2.1+1 [flutter meta wakelock_platform_interface wakelock_web]
dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.5.0-nullsafety.1 [collection]
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- camera_platform_interface 1.5.0 [flutter meta plugin_platform_interface cross_file stream_transform]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- clock 1.1.0-nullsafety.1
- cloud_firestore_platform_interface 3.0.1 [flutter meta collection firebase_core plugin_platform_interface]
- cloud_firestore_web 0.3.0+1 [flutter flutter_web_plugins http_parser meta firebase_core firebase_core_web cloud_firestore_platform_interface js]
- cloud_functions_platform_interface 4.0.1 [flutter meta firebase_core plugin_platform_interface]
- cloud_functions_web 3.1.3 [firebase_core firebase_core_web cloud_functions_platform_interface flutter flutter_web_plugins http_parser meta js]
- collection 1.15.0-nullsafety.3
- connectivity_for_web 0.3.1 [connectivity_platform_interface flutter_web_plugins flutter]
- connectivity_macos 0.1.0+1 [flutter]
- connectivity_platform_interface 1.0.3 [flutter meta plugin_platform_interface]
- convert 2.1.1 [charcode typed_data]
- cross_file 0.1.0 [flutter http meta]
- csslib 0.16.1 [source_span]
- cupertino_icons 1.0.0
- eventify 0.1.4
- extended_image_library 0.3.0 [flutter path_provider http_client_helper crypto path]
- fake_async 1.2.0-nullsafety.1 [clock collection]
- ffi 0.1.3
- file 5.2.0 [intl meta path]
- firebase 7.3.0 [http http_parser js]
- firebase_analytics_platform_interface 1.0.3 [flutter meta]
- firebase_analytics_web 0.1.1 [flutter flutter_web_plugins firebase firebase_analytics_platform_interface meta]
- firebase_auth_platform_interface 3.0.1 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.2+6 [flutter flutter_web_plugins meta http_parser intl firebase_core firebase_core_web firebase_auth_platform_interface js]
- firebase_core_platform_interface 3.0.1 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.1+3 [firebase_core_platform_interface flutter flutter_web_plugins meta js]
- firebase_crashlytics_platform_interface 1.1.6 [flutter meta collection firebase_core plugin_platform_interface]
- firebase_messaging_platform_interface 1.0.0-dev.10 [flutter meta firebase_core plugin_platform_interface]
- firebase_messaging_web 0.1.0-dev.5 [flutter flutter_web_plugins meta firebase_core firebase_core_web firebase_messaging_platform_interface js service_worker]
- firebase_storage_platform_interface 1.0.4 [flutter meta collection firebase_core plugin_platform_interface]
- firebase_storage_web 0.1.1+3 [async crypto firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- flutter_cache_manager 1.4.2 [flutter path_provider uuid http path sqflite pedantic clock file rxdart]
- flutter_isolate 1.0.0+14 [flutter uuid]
- flutter_local_notifications_platform_interface 2.0.0+1 [flutter plugin_platform_interface]
- flutter_localizations 0.0.0 [flutter intl characters collection meta path typed_data vector_math]
- flutter_page_indicator 0.0.3 [flutter]
- flutter_plugin_android_lifecycle 1.0.6 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- google_sign_in_platform_interface 1.1.2 [flutter meta quiver]
- google_sign_in_web 0.9.1 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- html 0.14.0+3 [csslib source_span]
- http_client_helper 0.2.1 [http]
- http_parser 3.1.3 [charcode collection source_span string_scanner typed_data]
- image_picker_platform_interface 1.1.0 [flutter meta http plugin_platform_interface]
- import_js_library 1.0.2 [flutter html flutter_web_plugins js]
- js 0.6.2
- json_annotation 3.1.1
- just_audio_platform_interface 2.0.0 [flutter meta plugin_platform_interface]
- just_audio_web 0.2.3 [just_audio_platform_interface flutter flutter_web_plugins meta]
- logging 0.11.4
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- mime 0.9.7
- nested 0.0.4 [flutter]
- path 1.8.0-nullsafety.1
- path_provider_linux 0.0.1+1 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 0.0.4 [flutter]
- path_provider_platform_interface 1.0.3 [flutter meta platform plugin_platform_interface]
- path_provider_windows 0.0.4+1 [path_provider_platform_interface meta path flutter ffi win32]
- pedantic 1.8.0+1
- permission_handler_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- platform 2.2.1
- plugin_platform_interface 1.0.3 [meta]
- process 3.0.13 [file intl meta path platform]
- quiver 2.1.5 [matcher meta]
- service_worker 0.2.4 [js]
- sky_engine 0.0.99
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- sqflite 1.3.2+1 [flutter sqflite_common path]
- sqflite_common 1.0.2+1 [synchronized path meta]
- stack_trace 1.10.0-nullsafety.1 [path]
- stream_channel 2.1.0-nullsafety.1 [async]
- stream_transform 1.2.0
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- synchronized 2.2.0
- term_glyph 1.2.0-nullsafety.1
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timezone 0.6.1 [path]
- transformer_page_view 0.1.6 [flutter]
- typed_data 1.3.0-nullsafety.3 [collection]
- url_launcher_macos 0.0.1+4 [flutter]
- url_launcher_platform_interface 1.0.6 [flutter meta plugin_platform_interface]
- url_launcher_web 0.1.1+1 [url_launcher_platform_interface flutter flutter_web_plugins meta]
- vector_math 2.1.0-nullsafety.3
- video_player_platform_interface 2.2.0 [flutter meta]
- video_player_web 0.1.4+1 [flutter flutter_web_plugins meta video_player_platform_interface]
- wakelock_platform_interface 0.1.0+1 [flutter meta]
- wakelock_web 0.1.0+3 [flutter flutter_web_plugins import_js_library js wakelock_platform_interface]
- win32 1.7.3 [ffi]
- xdg_directories 0.1.0 [path process flutter]

@santosh-2095 Could you confirm the file name on your bucket? I suspect there might be an issue with the name being resolved.

@santosh-2095 Could you confirm the file name on your bucket? I suspect there might be an issue with the name being resolved.

"Test" is the folder name and "Balance Vinayasa-Camatkarasana- One leg plank- Side plank leg lift - Vinayasa - left .mp4" is the file name

@santosh-2095 Could you confirm the file name on your bucket? I suspect there might be an issue with the name being resolved.

I am able to stream the video, download video using the downloadUrl but when i try to get the the reference from downloadUrl I am getting the exception

Reproducible on the latest master 1.26.0-18.0.pre.156.

flutter doctor -v
[√] Flutter (Channel master, 1.26.0-18.0.pre.156, on Microsoft Windows [Version 10.0.19041.746], locale et-EE)
    • Flutter version 1.26.0-18.0.pre.156 at C:\Development\flutter_master
    • Framework revision 45508985b1 (6 hours ago), 2021-02-02 22:46:04 -0500
    • Engine revision 2c144c3eeb
    • Dart version 2.12.0 (build 2.12.0-282.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\201.7042882\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30621.155
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\201.7042882
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (4 available)
    • SM G950F (mobile) • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
    • Windows (desktop) • windows            • windows-x64    • Microsoft Windows [Version 10.0.19041.746]
    • Chrome (web)      • chrome             • web-javascript • Google Chrome 88.0.4324.104
    • Edge (web)        • edge               • web-javascript • Microsoft Edge 88.0.705.56

• No issues found!

Minimal reproducible code sample
import 'dart:async';
import 'package:firebase_core/firebase_core.dart' as firebase_core;
import 'package:firebase_storage/firebase_storage.dart' as firebase_storage;
import 'package:flutter/material.dart';

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await firebase_core.Firebase.initializeApp();
  runApp(StorageExampleApp());
}

class StorageExampleApp extends StatefulWidget {
  @override
  _StorageExampleAppState createState() => _StorageExampleAppState();
}

class _StorageExampleAppState extends State<StorageExampleApp> {
  String download;
  TextEditingController ctr;

  @override
  void initState() {
    ctr = TextEditingController(text: "test/audio session.wav");
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Storage Example App',
      theme: ThemeData.dark(),
      home: Scaffold(
        body: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          crossAxisAlignment: CrossAxisAlignment.stretch,
          children: [
            TextFormField(controller: ctr),
            Text("$download"),
            ElevatedButton(
              child: const Text("Get link"),
              onPressed: () async {
                String downloadTemp = await firebase_storage.FirebaseStorage.instance.ref(ctr.text).getDownloadURL();
                setState(() => download = downloadTemp);
              },
            ),
            ElevatedButton(
              child: const Text("Check download link"),
              onPressed: () async {
                String tempDownload = await firebase_storage.FirebaseStorage.instance.refFromURL(download).getDownloadURL();
                print(tempDownload);
                setState(() => download = tempDownload);
              },
            ),
          ],
        ),
      ),
    );
  }
}

It does seem to be caused by a space in the filename.

I have the same issue on stable channel 1.22.4 with firebase_storage: ^5.2.0
and i can't upgrade dependencies because of different firebase dependencies, i tried a lot but could not figured out whats getting wrong and why this is happening.
i also tried removing all spaces from reference as suggested but it still returns the same response.
earlier it was working perfectly with same code and everything but it just suddenly started giving this issues and exceptions from nowhere.

Storage Exception
StorageException has occurred.
E/StorageException(12947): Object does not exist at location.
E/StorageException(12947):  Code: -13010 HttpResult: 404
E/StorageException(12947): {  "error": {    "code": 404,    "message": "Not Found.  Could not get object",    "status": "GET_OBJECT"  }}
E/StorageException(12947): java.io.IOException: {  "error": {    "code": 404,    "message": "Not Found.  Could not get object",    "status": "GET_OBJECT"  }}
E/StorageException(12947): 	at com.google.firebase.storage.network.NetworkRequest.parseResponse(NetworkRequest.java:434)
E/StorageException(12947): 	at com.google.firebase.storage.network.NetworkRequest.parseErrorResponse(NetworkRequest.java:451)
E/StorageException(12947): 	at com.google.firebase.storage.network.NetworkRequest.processResponseStream(NetworkRequest.java:442)
E/StorageException(12947): 	at com.google.firebase.storage.network.NetworkRequest.performRequest(NetworkRequest.java:272)
E/StorageException(12947): 	at com.google.firebase.storage.network.NetworkRequest.performRequest(NetworkRequest.java:286)
E/StorageException(12947): 	at com.google.firebase.storage.internal.ExponentialBackoffSender.sendWithExponentialBackoff(ExponentialBackoffSender.java:70)
E/StorageException(12947): 	at com.google.firebase.storage.internal.ExponentialBackoffSender.sendWithExponentialBackoff(ExponentialBackoffSender.java:62)
E/StorageException(12947): 	at com.google.firebase.storage.GetDownloadUrlTask.run(GetDownloadUrlTask.java:76)
E/StorageException(12947): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
E/StorageException(12947): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
E/StorageException(12947): 	at java.lang.Thread.run(Thread.java:923)

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.4, on Mac OS X 10.15.7 19H114 darwin-x64, locale en-IN)
    • Flutter version 1.22.4 at /Volumes/Tecocraft [A]/FLUTTER_SDK/flutter_1.22.4/flutter
    • Framework revision 1aafb3a8b9 (3 months ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4

Upload file and get download url method code
Future<Map<String, dynamic>> uploadImageToStorage(File imageFile, String fileName) async {
    try {
      Reference _storageReference = FirebaseStorage.instance.ref(fileName);
      UploadTask uploadTask = _storageReference.putFile(imageFile);

      var url = await (uploadTask.snapshot).ref.getDownloadURL();

      var name = _storageReference.name;
      print("image name ======>> $name");
      print("image url ======>> $url");

      return {"url": url, "name": name};
    } catch (e) {
      print("uploadImageToStorage exception ======>> $e");
      return null;
    }
  }

Unfortunately getting the error too :
[firebase_storage/object-not-found] No object exists at the desired reference.
I tried
final Reference fileRefFromUrl = FirebaseStorage.instance.refFromURL(fileUrl);
await FirebaseStorage.instance.ref(fileRefFromUrl.fullPath).delete();

also
final Reference fileRef = FirebaseStorage.instance.refFromURL(fileUrl);
await fileRef.delete();

I have been stuck for hours and can't find any solution. Any idea please ?

I actually finally found a fix for this. The issue is from the non alphanumeric caracters in the file name.
Here is a way to clean the name if it can help anyone :
final String fileName = "yourFile|#“Ç[Ç#“.pdf";
String fileNameClean = fileName.split('.')[0];
fileNameClean = fileNameClean.replaceAll(RegExp('[^a-zA-Z0-9 ]'),"");
fileNameClean = fileNameClean.replaceAll(" ","-");

Hi,
FirebaseStorage.instance.refFromURL() does not handle %20 delimiters in URLs, resulting in truncating the returned string
Is there a way to handle this special characters with refFromURL() ?
firebase_storage: ^8.0.1
flutter version: 2.0.3

For example, with this URL containg a %20 delimiter : https://firebasestorage.googleapis.com/v0/b/appmighty-3dfd7.appspot.com/o/groupFiles%2FiRrBzTMUbRXe5UZSoQQ1%2FRecordFile-Thierry Family-iRrBzTMUbRXe5UZSoQQ1-AUD-20190924-WA0000.mp3
Notice the filename : RecordFile-Thierry%20Family-iRrBzTMUbRXe5UZSoQQ1-AUD-20190924-WA0000.mp3
Try with raw Url String (trackFile) and decoded String (_decodeduri )
String trackFile= https://firebasestorage.googleapis.com/v0/b/appmighty-3dfd7.appspot.com/o/groupFiles%2FiRrBzTMUbRXe5UZSoQQ1%2FRecordFile-Thierry%20Family-iRrBzTMUbRXe5UZSoQQ1-AUD-20190924-WA0000.mp3;
String _decodeduri = Uri.decodeFull(trackFile);

Good raw URL :
print("trackFile : ${trackFile}");
trackFile : https://firebasestorage.googleapis.com/v0/b/appmighty-3dfd7.appspot.com/o/groupFiles%2FiRrBzTMUbRXe5UZSoQQ1%2FRecordFile-Thierry%20Family-iRrBzTMUbRXe5UZSoQQ1-AUD-20190924-WA0000.mp3

Good decoded URL :
print("_decodeduri : ${_decodeduri}");
_decodeduri : https://firebasestorage.googleapis.com/v0/b/appmighty-3dfd7.appspot.com/o/groupFiles/iRrBzTMUbRXe5UZSoQQ1/RecordFile-Thierry Family-iRrBzTMUbRXe5UZSoQQ1-AUD-20190924-WA0000.mp3?alt=media&token=72d2b5ea-d712-4dca-8173-06ec08e58aa8

BUT TRUNCATED RESULT AFTER %20 IN BOTH CASES WITH refFromURL :
print("refFromURL(trackFile).fullPath : ${FirebaseStorage.instance.refFromURL("$trackFile").fullPath}");
refFromURL(trackFile).fullPath : groupFiles/iRrBzTMUbRXe5UZSoQQ1/RecordFile-Thierry

print("refFromURL(trackFile).name : ${FirebaseStorage.instance.refFromURL("$trackFile").name}");
refFromURL(trackFile).name : RecordFile-Thierry

print("refFromURL(_decodeduri).fullPath : ${FirebaseStorage.instance.refFromURL("$_decodeduri").fullPath}");
refFromURL(_decodeduri).fullPath : groupFiles/iRrBzTMUbRXe5UZSoQQ1/RecordFile-Thierry

print("refFromURL(_decodeduri).name : ${FirebaseStorage.instance.refFromURL("$_decodeduri").name}");
refFromURL(_decodeduri).name : RecordFile-Thierry

print("refFromURL(trackFile) : ${FirebaseStorage.instance.refFromURL("$trackFile")}");
refFromURL(trackFile) : Reference(app: [DEFAULT], fullPath: groupFiles/iRrBzTMUbRXe5UZSoQQ1/RecordFile-Thierry)

print("refFromURL(trackFile) : ${FirebaseStorage.instance.refFromURL("$_decodeduri")}");
refFromURL(trackFile) : Reference(app: [DEFAULT], fullPath: groupFiles/iRrBzTMUbRXe5UZSoQQ1/RecordFile-Thierry)

And subsequent delete() fail, obviously:
await FirebaseStorage.instance.refFromURL("$_decodeduri").delete();
await FirebaseStorage.instance.refFromURL("$trackFile").delete();

Is this going to be fixed on the firebase side or do we handle this ourselves? I saw this issue happened with a react native firebase package too.

Is this going to be fixed on the firebase side or do we handle this ourselves? I saw this issue happened with a react native firebase package too.

Seems like this PR should fix it:
#5682


RT-4: implement password and email checking

Implement password and email checking for registration process
Acceptance criteria:

add second password input to compare with the first one
it must send the email with verification link to given address

implemented in #10 and #13


python interpreter state is not initialized

I am getting this error after generating a sound of the current epoch:
W tensorflow/core/kernels/data/generator_dataset_op.cc:107] Error occurred when finalizing GeneratorDataset iterator: Failed precondition: Python interpreter state is not initialized. The process may be terminated.
[[{{node PyFunc}}]]
i am having difficulty troubleshooting this myself.

Hi there, what branch was this on? That looks like it might be caused by a bug in the fix/generated branch - I have a fix for that which I haven't published yet but I can do so today.

i believe it is on the master branch

yes i am led to believe it is indeed tensorflow/keras related. however some fixes were mentioned that is beyond my understanding of the codebase.

OK, are you running this on Colab? If not what is your TF version, and what GPU?

Might be GPU RAM related.

No i am running this on my own rig. GPU is GeForce RTX 2060. TF is the one your script installs into Conda

not 100% sure about TF since i was fiddling about to get CUDA working.

OK, it should just install the latest TF, which is 2.5 I believe. What is your batch size, and also setting for dim in the config json file? And also number of rnn layers?

Batch size is 64. dim is 1064. RNN layers is 4.

Also just to be 100% clear. The error is when generating sound example during the running of the train.py script.

Did you mean 1024 or 1064 for dimensionality? I'd certainly stick with 1024.

1024, typo my bad

I have it generating a sound of 5 seconds after every epoch. This is the only params I have changed from your defaults. I dont know if that is relevant?

OK, thanks for clarifying. What is the sample rate of the dataset, and what do you have as the sample rate for generated output?

You could try running it again with the following lines at the top of the train.py script commented out:
os.environ["KMP_AFFINITY"] = "noverbose" <==
os.environ['TF_CPP_MIN_LOG_LEVEL'] = '3' <==

import tensorflow as tf
tf.get_logger().setLevel('ERROR') <==
tf.autograph.set_verbosity(3) <==

Comment out the lines pointed to by the arrows. It switches of TensorFlow logging and errors, although not more general Python errors (the scripts need better logging). Perhaps that will tell us something.

i allready did this:
Epoch: 65/100, Total Steps: 375, Loss: 3.075, Accuracy: 23.603, Val Loss: 6.028, Val Accuracy: 7.534 (5 min 45.650 sec)
2021-06-16 16:23:33.807538: W tensorflow/core/kernels/data/generator_dataset_op.cc:107] Error occurred when finalizing GeneratorDataset iterator: Failed precondition: Python interpreter state is not initialized. The process may be terminated.
[[{{node PyFunc}}]]
2021-06-16 16:23:34.382642: W tensorflow/core/kernels/data/generator_dataset_op.cc:107] Error occurred when finalizing GeneratorDataset iterator: Failed precondition: Python interpreter state is not initialized. The process may be terminated.
[[{{node PyFunc}}]]
that is the final traceback.
2021-06-16 15:33:12.648294: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cudart64_110.dll
2021-06-16 15:33:15.999735: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library nvcuda.dll
2021-06-16 15:33:16.028416: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1733] Found device 0 with properties:
pciBusID: 0000:02:00.0 name: NVIDIA GeForce RTX 2060 computeCapability: 7.5
coreClock: 1.755GHz coreCount: 30 deviceMemorySize: 6.00GiB deviceMemoryBandwidth: 312.97GiB/s
2021-06-16 15:33:16.028573: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cudart64_110.dll
2021-06-16 15:33:16.039857: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cublas64_11.dll
2021-06-16 15:33:16.039984: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cublasLt64_11.dll
2021-06-16 15:33:16.043212: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cufft64_10.dll
2021-06-16 15:33:16.044589: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library curand64_10.dll
2021-06-16 15:33:16.047156: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cusolver64_11.dll
2021-06-16 15:33:16.050340: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cusparse64_11.dll
2021-06-16 15:33:16.051338: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cudnn64_8.dll
2021-06-16 15:33:16.052552: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1871] Adding visible gpu devices: 0
2021-06-16 15:33:16.053117: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX AVX2
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2021-06-16 15:33:16.053513: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1733] Found device 0 with properties:
pciBusID: 0000:02:00.0 name: NVIDIA GeForce RTX 2060 computeCapability: 7.5
coreClock: 1.755GHz coreCount: 30 deviceMemorySize: 6.00GiB deviceMemoryBandwidth: 312.97GiB/s
2021-06-16 15:33:16.053585: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1871] Adding visible gpu devices: 0
2021-06-16 15:33:16.514842: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1258] Device interconnect StreamExecutor with strength 1 edge matrix:
2021-06-16 15:33:16.514977: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1264]      0
2021-06-16 15:33:16.515735: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1277] 0:   N
2021-06-16 15:33:16.515951: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1418] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 3961 MB memory) -> physical GPU (device: 0, name: NVIDIA GeForce RTX 2060, pci bus id: 0000:02:00.0, compute capability: 7.5)
2021-06-16 15:33:16.813201: I tensorflow/core/profiler/lib/profiler_session.cc:126] Profiler session initializing.
2021-06-16 15:33:16.813330: I tensorflow/core/profiler/lib/profiler_session.cc:141] Profiler session started.
2021-06-16 15:33:16.814033: I tensorflow/core/profiler/internal/gpu/cupti_tracer.cc:1611] Profiler found 1 GPUs
2021-06-16 15:33:16.814927: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'cupti64_112.dll'; dlerror: cupti64_112.dll not found
2021-06-16 15:33:16.815736: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'cupti.dll'; dlerror: cupti.dll not found
2021-06-16 15:33:16.815851: E tensorflow/core/profiler/internal/gpu/cupti_tracer.cc:1661] function cupti_interface_->Subscribe( &subscriber_, (CUpti_CallbackFunc)ApiCallback, this)failed with error CUPTI could not be loaded or symbol could not be found.
2021-06-16 15:33:16.815971: I tensorflow/core/profiler/lib/profiler_session.cc:159] Profiler session tear down.
2021-06-16 15:33:16.816054: E tensorflow/core/profiler/internal/gpu/cupti_tracer.cc:1752] function cupti_interface_->Finalize()failed with error CUPTI could not be loaded or symbol could not be found.
2021-06-16 15:33:16.825143: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cublas64_11.dll
2021-06-16 15:33:17.384904: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cublasLt64_11.dll
2021-06-16 15:33:18.237943: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cudnn64_8.dll
2021-06-16 15:33:18.737955: I tensorflow/stream_executor/cuda/cuda_dnn.cc:359] Loaded cuDNN version 8201
2021-06-16 15:33:27.860653: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:176] None of the MLIR Optimization Passes are enabled (registered 2)
Corpus length: 192 files.
that is the library loader messages at the beginning of the execution.

some more logs:
2021-06-16 15:33:43.059888: I tensorflow/core/profiler/lib/profiler_session.cc:126] Profiler session initializing.
2021-06-16 15:33:43.060008: I tensorflow/core/profiler/lib/profiler_session.cc:141] Profiler session started.
2021-06-16 15:33:43.060700: E tensorflow/core/profiler/internal/gpu/cupti_tracer.cc:1661] function cupti_interface_->Subscribe( &subscriber_, (CUpti_CallbackFunc)ApiCallback, this)failed with error CUPTI could not be loaded or symbol could not be found.
Epoch: 57/100, Step: 2/375, Loss: 2.472, Accuracy: 35.133, (0.748 sec/step)
2021-06-16 15:33:43.810836: I tensorflow/core/profiler/lib/profiler_session.cc:66] Profiler session collecting data.
2021-06-16 15:33:43.811027: E tensorflow/core/profiler/internal/gpu/cupti_tracer.cc:1752] function cupti_interface_->Finalize()failed with error CUPTI could not be loaded or symbol could not be found.
2021-06-16 15:33:43.818109: I tensorflow/core/profiler/internal/gpu/cupti_collector.cc:673]  GpuTracer has collected 0 callback api events and 0 activity events.
2021-06-16 15:33:43.820746: I tensorflow/core/profiler/lib/profiler_session.cc:159] Profiler session tear down.
2021-06-16 15:33:43.825934: I tensorflow/core/profiler/rpc/client/save_profile.cc:137] Creating directory: logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43
2021-06-16 15:33:43.828514: I tensorflow/core/profiler/rpc/client/save_profile.cc:143] Dumped gzipped tool data for trace.json.gz to logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43\JORMUNDGANDR.trace.json.gz
2021-06-16 15:33:43.864496: I tensorflow/core/profiler/rpc/client/save_profile.cc:137] Creating directory: logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43
2021-06-16 15:33:43.871302: I tensorflow/core/profiler/rpc/client/save_profile.cc:143] Dumped gzipped tool data for memory_profile.json.gz to logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43\JORMUNDGANDR.memory_profile.json.gz
2021-06-16 15:33:43.881919: I tensorflow/core/profiler/rpc/client/capture_profile.cc:251] Creating directory: logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43Dumped tool data for xplane.pb to logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43\JORMUNDGANDR.xplane.pb
Dumped tool data for overview_page.pb to logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43\JORMUNDGANDR.overview_page.pb
Dumped tool data for input_pipeline.pb to logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43\JORMUNDGANDR.input_pipeline.pb
Dumped tool data for tensorflow_stats.pb to logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43\JORMUNDGANDR.tensorflow_stats.pb
Dumped tool data for kernel_stats.pb to logdir\t5/16.06.2021_15.33.15\train\plugins\profile\2021_06_16_13_33_43\JORMUNDGANDR.kernel_stats.pb

"OK, thanks for clarifying. What is the sample rate of the dataset, and what do you have as the sample rate for generated output? I doubt sample rate setting would be the cause, though."
16000 and 16000.

Thanks. OK, those logs look like what I'd expect.

My understanding is that its a Tensorflow or Keras memory leak. at least from reading on the generator_dataset_op.cc:103 error. However we are getting a generator_dataset_op.cc:107 error, so I am not completely sure. Some fixes mentioned elsewhere on the net involves setting "workers" to 1 and downgrading TF to a earlier version, not sure if you can make sense of that.
One last thing, the audio is generated and plays, so that is nice. Its annoying to have to keep manually retriggering the training is all. Especially with a RNN network that takes so long to condition.

Oh i just got the error when just training, NOT when generating.
Epoch: 65/100, Total Steps: 375, Loss: 3.075, Accuracy: 23.603, Val Loss: 6.028, Val Accuracy: 7.534 (5 min 45.650 sec)
2021-06-16 16:23:33.807538: W tensorflow/core/kernels/data/generator_dataset_op.cc:107] Error occurred when finalizing GeneratorDataset iterator: Failed precondition: Python interpreter state is not initialized. The process may be terminated.
[[{{node PyFunc}}]]
2021-06-16 16:23:34.382642: W tensorflow/core/kernels/data/generator_dataset_op.cc:107] Error occurred when finalizing GeneratorDataset iterator: Failed precondition: Python interpreter state is not initialized. The process may be terminated.
[[{{node PyFunc}}]]
the error appeared after 9 epochs.

The error happens reliably at step 375/375. So its when finalizing the Epoch it gets into trouble.

My understanding is that its a Tensorflow or Keras memory leak. at least from reading on the generator_dataset_op.cc:103 error. However we are getting a generator_dataset_op.cc:107 error, so I am not completely sure. Some fixes mentioned elsewhere on the net involves setting "workers" to 1 and downgrading TF to a earlier version, not sure if you can make sense of that.

Yes, it looks like that. I'll look into it. I'll run it with the latest TF and nightly build later.

One last thing, the audio is generated and plays, so that is nice. Its annoying to have to keep manually retriggering the training is all. Especially with a RNN that takes so long to condition.

What I tend to do is actually swith in-training generation off, and watch TesnorBoard. Then, when I see a nice loss/val_loss I'll stop training and generate some material manually, using the generate.py script. You can always resume training from the same place, perhaps with adjusted learning rate.
By the way, have you tried the generate.py script to see if you get the error with that?

Also your val loss and val accuracy are not great, I generally get better results with the following params:
{
    "seq_len": 1024,
    "frame_sizes": [16,64],
    "dim": 1024,
    "rnn_type": "gru",
    "num_rnn_layers": 4,
    "q_type": "mu-law",
    "q_levels": 256,
    "emb_size": 256
}

Next release with have those params as defaults. Also temperature of 0.95 (current default is 0.75, which is too low I think).

What I tend to do is actually swicth in-training generation off, and watch TesnorBoard

Could i tempt you to writeup a small guide on how to use TensorBoard with your provided repository? That would be an immense help!

By the way, have you tried the generate.py script to see if you get the error with that?

I tried starting a training session earlier with checkpoints every 10 epochs and i got the error when at step375/375 in the 9th epoch. So I fear the error is in the training, not in the generation.

Also your val loss and val accuracy are not great, I generally get better results with the following params

Will try this, thx. And thx for maintaining the repository and being helpfull. Much appreciated!

Started from scratch with your new model JSON params. its training faster now, will let you know if/when problems arise.

Could i tempt you to writeup a small guide on how to use TensorBoard with your provided repository? That would be an immense help!

Sure no problem, although it's very easy, just run tensorboard with:
--tensorboard --logdir path/to/training/logdir
where path/to/training/logdir points to the directory containing checkpoints and the train and validation directories (these latter directories are created by tensorboard).

I tried starting a training session earlier with checkpoints every 10 epochs and i got the error when at step375/375 in the 9th epoch. So I fear the error is in the training, not in the generation.

OK, it looks like that's the case - I'll investigate more tomorrow. Will update here.

And thx for maintaining the repository and being helpfull. Much appreciated!

Thanks, not a problem at all.

I have been running the training with checkpoints every 5 epochs and it reached 30. Now it keeps crashing before reaching 35. So changing model params did not help the error. And it really does smell like a memory leak.

Thanks for the update. A few additional questions, if that's OK. What platform are you on (Windows, Linux)? Also could you tell me the version of TensorFkow you have - you can find out by starting Python, then execute:
import tensorflow as tf
tf.__version__

That should print the version you have. I assume you are using Anaconda, or an equivalent virtual environment?

Yeah sure no problem. I am on Windows and Anaconda.
Running tf.version gets me this:
2021-06-18 21:46:56.011229: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library cudart64_110.dll
And nothing else

oh my bad, i just figured it out. Printing (tf.__version) nets me:
2.5.0

Sorry, haven't had a chance to test this with 2.5.0 yet, both my machine are running production jobs that I can't interrupt. I'll have a chance early next week.
Just a thought, did you use the chunking script to create your dataset? I know that when someone used Audacity to create the chunks some were not of the same duration as the others, and the training choked, although I don't think it was that message.


2.2.0 Chat component

Refer to html template if Semantic UI isn't loaded yet.
Integrate Semantic UI. Make an area with 6 vacant fields where new users are gonna join.
Next to it ideally is a select checkbox button.
Admin button at the bottom left.
CLI for writing messages between the members. At the very bottom of the page.Left half of the page is for messages to appear for users to see.

This ticket has been split into multiple tickets to better represent the work breakdown in MVP Sprint


tweak error message format

Just a small issue. The convention for the ODM is [table]_[part] not  [table].[part]. We do that because using _ generates a valid name in all programming languages. (.) does not.
Originally posted by @DougManuel in https://github.com/Big-Life-Lab/PHES-ODM-Validation/issues/21#issuecomment-1236329240

I'm assuming this is about the error message format. I'll see if I can make it more proper. Maybe I can add another rule before this, with a different kind of error message, so that I can get a better idea of how to structure the code?

Yes. The message could read more in a human-readable format for the error report. Error found on table [table] in part [part].
The format of combining tables and variables in how to name parts in "wide" table format, which doesn’t apply to the validation tools at this point. We are only validating 'long' tables.


What is BOT_URL?

Hello!
I'm trying to run this project and I can't figure out what the parameter means BOT_URL.
I use a tg bot @Switch_library_bot, but url "https://t.me/Switch_library_bot" does not work.

Hi! Sorry for too late. I added answer to your question in FAQ on Wiki

This is a special URL, which Lord of the Bots ask not to share in this repo. You can ask this in a Telegram Group and ping a Chat Admin or you can ask this in my DM :)


Clear unused dependecies

Changelog
Changed

Exclude org.liquibase:liquibase-core:jar:4.5.0 old version from org.eclipse.dirigible:dirigible-bpm which is comming with org.flowable:flowable-engine. Will be using org.liquibase:liquibase-core:jar:4.12.0 which is coming from org.eclipse.dirigible:dirigible-database https://github.com/SAP/xsk/pull/1638/commits/70eeefc41abb671710f6749f933c100985ed7684

Removed

copy-dynamic-data-source https://github.com/SAP/xsk/pull/1638/commits/3bb0b308b4bd460d38354af4a3d65dd67a1d3aea
Exclude com.ibm.icu:icu4j from all releng/folders https://github.com/SAP/xsk/pull/1638/commits/fd6881586a990339f5b00f5b4d6fa3f735ef4c4e https://github.com/SAP/xsk/pull/1638/commits/510e81a42f0bc8f7b242c64d105bd8fd51f23825
Exclude dirigible-templates https://github.com/SAP/xsk/pull/1638/commits/096a26f2026df173665422548524bf2b764ea0d7
Exclude dirigible-templating-all https://github.com/SAP/xsk/pull/1638/commits/cc5aadc596770f91ad46a14573fa88a28b31805c
Exclude dirigible-resources-mxgrap https://github.com/SAP/xsk/pull/1638/commits/053eeb980de1ae230232f4354ceede805e70d616

Fix #1491

This pull request is closed as the project is no longer maintained


Add support for Files.createFile

This commit adds a Files.createFile method that handles the
AccessDeniedException thrown from java.nio.file.Files.createFile
when the target file is just marked for deletion and not yet
deleted (Windows).
To support testing of this method, InterprocessCyclicBarrier is added
to permit test coordination among Java processes.
This commit resolves #50.

@chrisdennis A follow-on to our conversation about this -- I moved InterprocessCyclicBarrier back into the test root of the module.  If we decide at some point in the future to make this more broadly available, we can.


(PUP-9290) puppet facts upload always uses environment "production"…

… ignoring setting from puppet.conf

Can one of the admins verify this patch?

Thanks for your contribution @eugen-prokhorenko! After I made the comment in the ticket, we reworked some of the environment handling, see 430f22be04c8d888e6a85b4095a33a2fe0e3f7f2 and 184991a3789. As a result, there will always be a current_environment set in the context for the application.  So you should be able to do:
Puppet::Node::Facts.indirection.save(facts, nil, environment => Puppet.lookup(:current_environment))

Looks good!

Thanks for your contribution @eugen-prokhorenko! I'm going to add a commit for a test. I'm going to close this PR and create a new one, but I'll keep you as the author on your commit. Thanks again!

Superseded by #https://github.com/puppetlabs/puppet/pull/7614


vm.args is only copied from release once

At the moment it seems that vm.args is (intentionally?) copied from the release directory to running-config only the first time. After that, it is no longer copied regardless of whether or not you upgrade, switch to a new version, etc. This is a surprising behavior because conform config copies every time boot is run (which actually wasn't the case). Should we treat vm.args the same way?

Yes, vm.args should be treated the same way. We'll need to make sure the boot script does that.

Per our conversation on IRC, here's my findings/suggested fix for this in exrm:

Currently, sys.config in running-config is always overwritten when generate_config is called. This is not how I want running-config to operate. This isn't an issue with conform, as config changes are made in the .conf. We want running-config to be persistent so that custom configuration can be done there.
vm.args in running-config is only created the first time, and other than deleting it, there's no way to get the vm.args from the release package there. The persistence is desired, but there needs to be an escape hatch.

My suggested/planned fix for this: Define a new environment variable PERSISTENT_RUNNING_CONFIG. When set, sys.config and vm.args in running-config will never be overwritten with versions in the release package, with the exception of when using conform, where sys.config will still be overwritten. When unset, sys.config and vm.args will always be overwritten by their counterparts in the release package (basically the current behaviour, except vm.args will also be overwritten after this change).
Any feedback on this proposed change is welcome from all :)


update windows-10-enterprise-subscription-activation.md

issue #1448

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

Dear @JohanFreelancer9 , @nenonix ,
the sentence was updated, thank you very much!

@greg-lindsay - Can you please assist to check, approve and merge the content of this PR based on issue #1448?
Thank you.


Documentation is missing license page

The git repo has license information, the packages do, but the docs don't. That should be fixed.

Committed a fix to the docs today; forgot to tag the bug.


Golangci-lint

Coverage: 68.576%. Remained the same when pulling 72c359fe0340368a488109b234ae1fcf24978a34 on golangci-lint into 125378981a6ed246774b5d2033273b567ea4797f on main.


Add empty dist folders to packages

Build:packages fails due to an issue with rollup not creating the folders automatically so I added them to the repo.

I do not like to have dist folders in the repository. I've updated the build script so missing dist folders will be created for builds.


Call not receiving after kill the app

Integrated swift callkit in my app, it was all working fine. After that call is not receiving after killing the app. if app killed, again want to initiated with access Token to get the call. only change i made is removed background fetch from the app configuration. but then I added again still its not working. removed and added certificate again(same old VoIP) and created new push credentials. tried sandbox on and off
Testflight

Hi @hasgar
Thanks for reaching out to the team.
Assuming the call push notifications are delivered successfully, the application will be woken up by the system and guaranteed with enough time to present the call to the user. One thing you will have to make sure is that the implementation of PkPushRegistry has to be in AppDelegate (or the frontmost app-delegate object in your app) or the entry view-controller. We've seen applications that keep PkPushRegistry object behind a sign-in view and the session has expired so that it could fail to initialize the PkPushRegistry and respond to the PushKit callbacks.

@bchen-twilio thank you.. it works.. but when initializing on UI is hanging for few seconds..

Cool! I'll suggest maybe you can move the initialization to app-delegate then the impact will be less noticeable.
I'll close this issue for now but feel free to open a new ticket.
-bobie