Possible data loss when connecting a new device to ensembles

I use Ensembles with the iCloud file system in my app Tyme which is available for iOS & OSX.
And every once in a while a customer reports data loss when initially connecting his iPhone to iCloud after he already worked with the Mac app.
A few database entries are created on the Mac and synced. Then the iPhone connects and syncs. After the sync there are only entries left which were created on the iPhone. All other entries seem to be deleted.
I did not implement the "didFailToSaveMergedChangesInManagedObjectContext" delegate and try to repair or delete corrupt entries. So I'm wondering where the data loss occurs.
Did anyone experience this also? I could never reproduce the issue ...
Cheers,
Lars

Is it possible that you have an autoincrementing integer unique ID? Perhaps you're creating items with ID 1, 2 and 3 on the iPad, then creating items with ID 1, 2 and 3 on the iPhone, and when you sync, the iPhone items are overwriting the iPad items.
If that's the issue, I solved it by using UUIDs for the ID column.

All entities have a uid property that's set once in awakeFromInsert: [[NSProcessInfo processInfo] globallyUniqueString];
And I use the persistentStoreEnsemble:globalIdentifiersForManagedObjects: delegate. So every ID should be unique. What do you mean by autoincrement ID, in the SQL database itself?

I vaguely remembered reading something in the past about awakFromInsert could be called multiple times so I googled it. Could this cause your problem?
http://stackoverflow.com/questions/19856122/why-is-awakefrominsert-called-twice

Thanks! If the UID's would be not unique (set again), it would double entries not delete them right? I just got a log from a user and all globalidentifier's seem to be ok. My guess is that somehow a new baseline is created that overwrites the existing one? Can that happen?

Dug deeper, but couldn't reproduce the issue here in any case. So thanks for the ideas. Will add some checks / logs and see if that happens again.


bucket policy for ssm log bucket not being applied

Describe the Bug
The S3 bucket created by the ssm_patch_log_s3_bucket module does not have a policy after creation.

Fixed by #22


Support version 3.X of Traefik

After upgrading to v3.0.0-beta2, we encounter panics

This problem could come from Traefik or the plugin might need some adaptation.

This enhancement would be really appreciated

This enhancement would be really appreciated

Hello @ashuio, Thanks for your interest, we'll give it another try soon, and take you updated!
Best,
Mathieu

Hey, after somes tests we have'nt reproduced this error.
We have a version of the plugin working with v3.0.0-beta2
I will close now, and reopen if new error arrise


fix(redis): gcs备份上报修复

关联研发信息
dev_branch: fix/gcs_backup_records_upload_fix/#2983
target_branch: v1.3.0


fix(compliance): remove unnecessary Optional attributes

Description
Remove unnecessary Optional attributes in Compliance models for a correct validation.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

What's the purpose of this change?

So Pydantic can know which Compliance Model have to choose, if all attributes are optional, Pydantic will choose randomly a model since all of them match.


model_dump() shows Pydantic serializer warnings after call @cached_property field

Initial Checks

[X] I confirm that I'm using Pydantic V2 installed directly from the main branch, or equivalent

Description
I found strange behavior in Pydantic V2 with specific conditions.
How to reproduce

the model field has a union field, and the union type has a self-class.
the model has @cached_property
initiate the model
call the @cached_property method in the nested model
call model_dump()
Show Pydantic serializer warnings

Please check the example code.
Example Code
from __future__ import annotations
from functools import cached_property

from pydantic import BaseModel

class Model(BaseModel):
    nested: Model | str = 'default'

    @cached_property
    def name(self) -> str:
        return 'dog'

m = Model(nested=Model())

# This line doesn't; show any warning.
m.model_dump()

# call cached_property method
m.nested.name

# Show warning
m.model_dump()

# /home/koudai/PycharmProjects/pythonProject/venv11/lib/python3.11/site-#packages/pydantic/main.py:292: UserWarning: Pydantic serializer warnings:
#  Expected `Union[definition-ref, str]` but got `Model` - serialized value may not be as #expected
#  return self.__pydantic_serializer__.to_python(

Python, Pydantic & OS Version
pydantic version: 2.0
        pydantic-core version: 2.0.2 release build profile
                 install path: /home/koudai/PycharmProjects/pythonProject/venv11/lib/python3.11/site-packages/pydantic
               python version: 3.11.4 (main, Jun  7 2023, 12:45:48) [GCC 11.3.0]
                     platform: Linux-6.0.6-060006-generic-x86_64-with-glibc2.35
     optional deps. installed: ['email-validator', 'typing-extensions']

Selected Assignee: @samuelcolvin

@Kludex
I have created this issue for https://github.com/koxudaxi/datamodel-code-generator/issues/803

This is a neat one. @adriangb if I can't figure it out shortly, I think you might be able to figure it out faster than me

Okay, I think the issue is that @cached_property puts the value in model.__dict__ and in various places we assume that only fields are in there. It's definitely weird to me that this only affects the nested field though..

Okay I think I made some progress. It's hitting this line in pydantic-core and I think that's bubbling up into the definitions ref validator and it's not realizing it should do the standard validation approach.
Note that there's something going on specifically with the definitions reference validator because it doesn't error if you just use a union validator with a Model and str..

Okay think I figured it out — we need to implement retry_with_lax_check for a DefinitionRefSerializer, so that it checks what the returned value is for the referenced serializer, and I think that will resolve it.
I don't think I'll be able to do that today, and I think it may require a bit of modification to DefinitionRefSerializer to make it store that since the retry_with_lax_check doesn't have the necessary information to look it up. But I might be wrong about that, or it might not be that hard. I defer to @samuelcolvin or @adriangb on this, happy to keep trying though if you guys can't resolve this quickly.

@dmontagu
Thank you for investigating the warning.
Does the warning affect  .model_dump() result?
datamodel-code-generator uses model_dump() to dump nested objects like this.
https://github.com/koxudaxi/datamodel-code-generator/blob/1cb7609288bc8dc32895c3e0459eef8e33318f98/datamodel_code_generator/parser/jsonschema.py#L220
The repo passed all unittest tests the same as pydantic v1.
I guess the behavior of model_dump() is not changed v1 by the waring :thinking:

I'll also just note that (as discussed this morning) there will be an issue with strict validation of unions of basemodels when @cached_property is used since it will look for the presence of the exact right fields in the __dict__, and we probably should give it a way to know that there might be some items that can be ignored if present (i.e., at least any @cached_property attributes).

@koxudaxi for the majority of cases I don't think it will affect the result. The main thing I'd be concerned about is, I think it might be possible to produce a union of model types with the same fields but different serialization behavior, and it might choose to serialize it as the wrong one. That said, currently, I think it would be hard to actually hit misbehavior though without going out of your way to try. That said, definitely want to get rid of the warning (and fix the underlying possibility for misbehavior), it's just a bit complicated..

Looks like this is now fixed on main, I'm guessing due to the union serializer fixes included in v2.9!


Make DiagnosticsCollector work for containers as well

Today it only works for projects run directly. Make it work for applications running in containers as well.

All progress will be moving to https://github.com/dotnet/tye


IUCA.KG

Added iuca.kg (International University of Cental Asia)

@sharton I am sorry for the delay with processing your request. Now the pull request merged. Thank you!


Allow for a few 404s on status polling for cases where they're not in…

… metadata yet

This feels kinda yucky to me but it works

:+1: eventual consistency whadda ya gonna do

👍


HTML Build not working

final bytesData =
await result!.uiImage.toByteData(format: ImageByteFormat.png)
/// bytesdata == null (true)

Hi! Could you provide more information as to what is going wrong? Thanks a lot.

Could you please try to build the app in the latest version (1.2.0)? It includes WASM support so things might be fixed.
If the issue still perists, feel free to reopen this.


[BEAM-362] Move state-oriented remnants of OldDoFn to runners/core-java

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This moves WindowingInternals, StateInternals, and TimerInternals out of the Java SDK and into runners/core-java. This is motivated by code health and user-facing API health but also easy first steps towards easing alterations to WatermarkHoldState's relationship with OutputTimeFn, which is going away.
Kudos to @jkff for moving OldDoFn which made all of this trivial.
This will require a Dataflow worker image.

(needs checkstyle touch ups)

R: @tgroh pushed new worker image, expect to see green

https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2195/

Changes Unknown when pulling 3d660ebeccedc414cd5a0b01eb641dd0dd21a59c on kennknowles:StateInternals into ** on apache:master**.

I'm happy with this (LGTM); any idea why Jenkins Harness seems to be misbehaving?

Unsure. I'll investigate and be sure there's no build breakage before I merge. If it is a real failure, it was introduced over the weekend. This PR was green on Friday and resolving conflicts was just another PR touching its imports.

retest this please

Coverage decreased (-0.09%) to 69.595% when pulling fd7e6149a038a6480b6d2f4f76a738bb83c47476 on kennknowles:StateInternals into 7564486f57a34aa5e9049b6ed995626ac251f172 on apache:master.


Testability issues

I don't mean to flood this repo with issues, but I cloned needle to try make some fixes myself and I'm having a hard time testing as it does not work out of the box.
Could you provide some basic instructions on setting up the local environment for testing? It would be great to have out-of-the-box testabilty as it makes it easier for contributors to submit good PRs, lowers the risk of merging bad code and allows you to add CI integration (which also helps a lot as it rejects PRs right away when tests are not passing).
I see that you are running a local server to test needle, you think this could be replaced by an http mocking library?

$ git clone https://github.com/tomas/needle.git
$ npm install
$ npm test

What error are you getting?

Welp, it tries to load some cert files which are not present in the repo

Oh, yes, I forgot. You need to generate the SSL keys inside test/keys.
$ mkdir -p test/keys
$ openssl genrsa -out test/keys/ssl.key 2048
$ openssl req -new -key test/keys/ssl.key -x509 -days 999 -out test/keys/ssl.cert

Ok, I just updated the documentation. Thanks for the heads up.

any time!


[BUG] menu GraphQL query does not return localised response when passing @inContext directive

Describe the bug
menu GraphQL query does not return localised response when passing @inContext directive
To Reproduce
Using the Shopify Translate & Adapt app, take the following main-menu content: https://i.imgur.com/xED6QXe.jpg
Then query the menu using the following GraphQL:
query @inContext(language: FR) {
	menu(handle: "main-menu") {
    title
  }
}

Note the following response:
{
  "data": {
    "menu": {
      "title": "Main menu"
    }
  },
  "extensions": {
    "context": {
      "country": "FR",
      "language": "FR"
    }
  }
}

Expected behaviour
The response should include the FR translation of "Main menu", i.e.:
{
  "data": {
    "menu": {
      "title": "Menu"
    }
  },
  "extensions": {
    "context": {
      "country": "FR",
      "language": "FR"
    }
  }
}

I can confirm this behavior using the hydrogen-preview store as a test.

I've been informed that menu isn't a translatable resource yet.


How to authorize first request with bearer token?

I am storing user's jwt token in the localStorage and I have added an interceptor to axios to attach the correct bearer token to the request.
import axios from 'axios';

import store from '~store';
import config from '../config';

const methods = ['get', 'post', 'put', 'patch', 'delete'];

function formatUrl(path) {
  const adjustedPath = /^\/.*$/.test(path) ? path : `/${path}`;
  const inBrowser = typeof window !== 'undefined';
  const protocol = config.isProduction ? 'https' : 'http';

  if (!inBrowser) {
    return `${protocol}://${config.apiHost}:${config.apiPort}${adjustedPath}`;
  }

  return `/api${adjustedPath}`;
}

axios.interceptors.request.use((cfg) => {
  try {
    // const token = store.state.userSession.token;
    const token = localStorage.getItem('token');

    if (token) {
      cfg.headers.common.Authorization = `Bearer ${token}`;
    }
  } catch (ignore) {
    // ignore
  }

  return cfg;
}, error => Promise.reject(error));

class ApiClient {
  constructor() {
    methods.forEach((method) => {
      this[method] = (path, ...args) => axios[method](formatUrl(path), ...args);
    });
  }
}

const client = new ApiClient();

export default client;

This works fine when a certain page is rendered on the client, but it doesn't work on the initial request, because server doesn't have access to localStorage (of course) :-). Is there a way to get the token before fetch method of some page is trying to get some data?

You can use the cookies to access them on server-side (and client-side).
In your nuxtServerInit action, you can get the cookie in req.headers.cookie and then extract the token to set it in the store.

Thanks @Atinux! Yes, I have found out that I can use cookies, but it's kind of a limitation in my opinion. There are several reasons to store jwt tokens just in local storage rather than cookies and the local storage. I understand that localStorage is not available in node environment, but maybe it would make sense to pass as much as possible to server, so programmer could use things like window, document localStorage etc at least in the middleware function. If your target audience are creators of simple blog pages and writers of documentation pages, then you are fine, but if you want to bean alternative to vue-cli than you should offer more :angel:
However thanks for doing Nuxt, it's a great framework!


iOS. Processing is taking too long if a user closes the Amazon payment page

Describe the bug
After rn-stripe update from 0.35.0 to 0.40.0 I noticed that processing is taking too long if the user closes the Amazon payment page (see video). As for 0.35.0 version it works fine (see video)
To Reproduce
Steps to reproduce the behavior:

presentPaymentSheet
Click on Amzaon
Proceed to the Amazon payment page
Tap the Close button to close the page

Actual behavior
Processing is taking too long if a user closes the Amazon payment page
Expected behavior
Processing stops after a user closes the Amazon payment page.
Video
rn-stripe v. 0.40.0
https://github.com/user-attachments/assets/af59f0af-01f5-4f88-9f9b-dbbf0854d74f
rn-stripe v. 0.35.0
https://github.com/user-attachments/assets/6fd5a3df-3312-481c-94eb-cf05a3bf675d
Smartphone (please complete the following information):

Device: [e.g. iPhone 11 Pro Max]
OS: [e.g. iOS 18.1.1]

Additional context
Add any other context about the problem here.

Hi @aleks-khomenko thanks for opening this! This is unfortunately expected behavior for now. The payment should cancel out after about 10-15 seconds. We are looking into improving this, but there is nothing on our roadmap in the near term. Going to close this out and will post an update here if anything changes.


Error occurs when URL contains URL encoded values.

Try a URL like this:
http://www.whatever.com/something?json=%7B%0A%20%20%20%22Ids%22%3A%20%5B16036%2C1%5D%0A%7D

The CreateDictionaryKey method is erroring, presumably because of the string.Format not liking the braces...

Fixed in #7.

👍 ETA on new NuGet release?

It's there now : https://www.nuget.org/packages/WorldDomination.HttpClient.Helpers/


aerospike_ycsb run failed

Got this error message:
RemoteCommandError: Got non-zero return code (1) executing scp -P 22 -pr -2 -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -o IdentitiesOnly=yes -o PreferredAuthentications=publickey -o PasswordAuthentication=no -o ConnectTimeout=5 -o GSSAPIAuthentication=no -o ServerAliveInterval=30 -o ServerAliveCountMax=10 -i /tmp/perfkitbenchmarker/run_b4c9c699/perfkitbenchmarker_keyfile (home_dir)/PerfKitBenchmarker/perfkitbenchmarker/data/ycsb/workloada perfkit@<IP_ADDRESS>:/tmp/pkb/workloada
STDOUT: STDERR: Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.^M
Connection closed by <IP_ADDRESS>^M
lost connection

Looks like a problem copying files to the VM - a simple retry may fix this. It's also possible that the VM was already stopped because we set --maintenance-policy TERMINATE when we create them. A similar run passed, so this is just a flakiness issue.

Same thing happened with cassandra_ycsb

@cmccoy  - Can you see if there is a quick fix?

Sure. The instances weren't terminated. I'll add a retry.

Opened #699. Testing now.

Closed by #699.


Allow importing Battlefy tournament data from full URL

Instead of having to manually extract the tournament ID out of a Battlefy tournament's URL, the dashboard should be able to do that automatically.

Done in 3.2.0.


[Issue-3920] Show well-known tokens on top

🚀 Deployed on https://pr-3934--sw-web-runner.netlify.app


Memory leak: REST client metrics capture grows unbounded

The URLs were unique by namespace and query parameter value, which means
an infinite number of metrics counters could be created.
Fixes part of #9581

@bprashanth can you review

LGTM

LGTM
Travis is complaining that you need to run 'gofmt -s'

Sorry I mean shippable, not Travis.

Nit: a test would be really nice...

Will add one

On Jun 12, 2015, at 8:34 PM, Daniel Smith<EMAIL_ADDRESS>wrote:
Nit: a test would be really nice...
—
Reply to this email directly or view it on GitHub.

Test added, verified original request was unchanged.
----- Original Message -----

Will add one

On Jun 12, 2015, at 8:34 PM, Daniel Smith<EMAIL_ADDRESS>wrote:
Nit: a test would be really nice...
—
Reply to this email directly or view it on GitHub.


Bump to 1.2.1

[x] Cythonize on python3 only (cython tried to process external python3 code)
[x] Fix execute_through_host
[x] implement keepalive work

Pull Request Test Coverage Report for Build 106

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.687%

Totals

Change from base Build 105:
0.0%

Covered Lines:
955

Relevant Lines:
958

💛  - Coveralls


Add support for analysis of C# based cmdlets

At this point we do not see a strong requirement to add this feature.


Bug in `padl/dumptools/inspector::cut' function

I get the following error when I add an Unbatchify in the following model:
mod = (to_tensor
>> Batchify()
>> embedding
>> Unbatchify()
)

If I don't add the Unbatchify everything works properly.

This works
mod = (
    to_tensor
    >> Batchify()
    >> embedding
    >> Unbatchify()
)```

this doesn't:

mod = (to_tensor
>> Batchify()
>> embedding
>> Unbatchify()
)

Thanks Alex

fixed


wazevo(regalloc): prioritizes rematerializable values first

This didn't make noticeable difference as-is as only 10-20 values out of the entire Zig stdlib tests turned out to be the targets. Just opened here for the future reference.

maybe this brings better result for amd64 as it has less registers available, but yeah we should wait until it's done

with this opt
# With this opt
took 1m18.610553792s
took 1m18.445228875s
took 1m18.489545833s
took 1m18.450797083s
took 1m18.485565625s
took 1m18.546167458s
took 1m19.028374208s
took 1m18.491444333s
took 1m18.441225333s
took 1m18.462568708s
took 1m18.4160175s
took 1m18.716863167s

# Without
took 1m18.945682625s
took 1m18.385542917s
took 1m18.458998916s
took 1m18.626495292s
took 1m19.512397208s
took 1m18.707789625s
took 1m18.489273125s
took 1m18.479153834s
took 1m18.580437542s
took 1m18.63090975s


Editor - It's not easy/natural to write out of a link

Bug Report
What is the current behavior?
If I select the last words to be a link to something, if I continue to write on the same line, the texts keeps being wrapped up within the link title. The only way to make it go out of the link is hitting enter, writing something, then doing a backspace and keep on writing from the previous not link letter.
What is the expected behavior?
Something more natural, like either clicking an arrow, or double space or something to tell the editor that I want to close the link wrapping.
For GitBook Editor

Operating System?
OSX 10.11.6
(Desktop) Editor version?
6.2.1
Was the bug present in previous versions?
Fist version I tried.

This is fixed for usual cases


Scaling Problem

I have set a higher DPI in Windows, which makes the program/tool also bigger. Then I'm unable to see the bottom of the left site with the information of the card. As a workaround I repositioned the monitors in Windows, but this is not really user-friendly. I think an easy way to resolve this is to add a scroll bar for the left site as well - or let me set a different size via config.

I added a scroll bar to the bottom-left section. Let me know if that wasn't what you meant.


Authorization error response is missing State property value.

Hi,
In case of error the authorisation error response is missing state parameter value.
OpenID documentation clearly explains that if state was present as part of request then it should be included in auth error response as well.
link:  https://openid.net/specs/openid-connect-core-1_0.html#AuthError
I think this needs to be fixed in https://github.com/IdentityServer/IdentityServer4/blob/c50458957cab9d39b2ad4938a77d38aa27f36dd7/src/IdentityServer4/src/Endpoints/AuthorizeEndpointBase.cs#L129
Please clarify.
Thanks
Dinesh

It is:
https://github.com/IdentityServer/IdentityServer4/blob/18897890ce2cb020a71b836db030f3ed1ae57882/src/IdentityServer4/src/Extensions/AuthorizeResponseExtensions.cs#L53

@brockallen : yes the condition is there but the value is always not passed. look below.
return new AuthorizeResult(new AuthorizeResponse
{
Request = request,
Error = error,
ErrorDescription = errorDescription,
SessionState = request?.GenerateSessionStateValue()
});
This is taken from the CreateErrorResultAsync method. my previous comment points to the exact line number. State is missing but SessionState is being added. It is definitely a bug. State should also be added while constructing the AuthResponse.

Also we are using version 2.3.2 of the library where request object validation happens much later in the flow. so if basic validations fails then it skips setting state value. Do you think the issue is only in that specific version?


Python Versioning Install Error

I have Python 3.7 installed, but when I go to pip install oura-ring, I receive the error:
ERROR: Could not find a version that satisfies the requirement oura-ring (from versions: none)
ERROR: No matching distribution found for oura-ring
I also tried installing via zip, but the following error came:
ERROR: Package 'oura-ring' requires a different Python: 3.7.12 not in '<4.0,>=3.10'
Note: you may need to restart the kernel to use updated packages.
Can you please let me know what I can do to fix this?

This library requires Python 3.10 or newer, is there any reason you can't upgrade to 3.10?


Password Variable Not Working

Is there an existing issue for this?

[X] I have searched the existing issues

Used image version
Latest
Used docker compose file or docker command
docker run -d --name enshrouded
--hostname enshrouded
--restart=unless-stopped
-p 15637:15637/udp
-v ./game:/opt/enshrouded
-e SERVER_NAME="My Server Name"
-e SERVER_PASSWORD="My Password"
-e UPDATE_CRON="*/30 * * * *"
-e PUID=4711
-e PGID=4711
mornedhels/enshrouded-server:latest
What you expected to see, versus what you actually saw
I used the suggested commands, and the json shows the password and password variable, but does not ask for one when joining the server.
Logs from the container
mornedhels-enshrouded-server-1.csv

After much searching you have to put a password for the roles as well for it to work.

Hey! I have the same error using the docker-compose example, can confirm that the server_password variable is not written in enshrouded_server.json
I made sure that all files are owned by my user (1000:1000) and the PUID and PGID are correct.
Following what said @Nitrocrusher , I tried to login using the userGroups password (wich is not the same as server_password) and it worked.
Is it supposed to work like this?


Add check that .DirIcon must be png

In https://github.com/AppImage/pkg2appimage/blob/master/appdir-lint.sh, add check that .DirIcon must be png
References:

https://github.com/AppImage/appimage.github.io/issues/1546
AppImage/libappimage#104 (comment)

Something like this?
DIR_ICON_MIME=$(mimetype $(readlink -f ${APPDIR}/.DirIcon) | awk '{print $2}')

if [[  ! "$DIR_ICON_MIME" = "image/png"  ]] ; then
  echo "Icon isn't a PNG file"
fi

Yes, I think that would be doing it; although we should use warn instead of echo. What to send a PR?

although we should use warn instead of echo

Sorry, I didn't pay attention to that detail

Done in https://github.com/AppImage/pkg2appimage/pull/385. Thank you :+1:


SpringBoot 3.0

Scenario

camunda-platform-7-rest-client-spring-boot version: 7.19.0
Camunda BPM version: 7.19.0
Description of your use case: (detailed description or executable reproducer, e.g. GitHub repo)
Hello!
I try to use your rest client in a SpringBoot 3.0 application, but my application doesn't start, because of the following error message:
""***************************
APPLICATION FAILED TO START

Description:
Parameter 9 of constructor in org.camunda.community.rest.impl.RemoteRuntimeService required a bean of type 'org.camunda.bpm.engine.ProcessEngine' that could not be found.
Action:
Consider defining a bean of type 'org.camunda.bpm.engine.ProcessEngine' in your configuration.""
Is your client working with SpringBoot 3.0, or should I downgrade my project to SpringBoot 2.7.x?
Additional info:
I use only the starter dependency (see below), but as I see, it contains org.camunda.bpm:camunda-engine dependency. I haven't got any of org.camunda.bpm dependency in my pom

org.camunda.community.rest
camunda-platform-7-rest-client-spring-boot-starter
7.19.0

Current Behaviour
Wanted Behaviour
Possible Workarounds

Hi @szabon007,
officially, Camunda 7.19 doesn't work with Spring Boot 3 and only 7.20 is planned to support it. For this reason, we decided to mirror the decision of Camunda Core team and are currently only support Spring Boot 2.7.x.
Sorry for that,
Cheers,
Simon


Groovy task accessors should/could be lazy

Expected Behavior
Groovy task accessors should be changed to be lazy.
Current Behavior (optional)
When using Groovy task accessors in ways like
test {
    useJUnit {
        includeCategories 'org.gradle.junit.CategoryA'
        excludeCategories 'org.gradle.junit.CategoryB'
    }
}

you end up (too) eagerly creating tasks.
Context
There are lazy alternatives, but as long as people can find code snippets like the above by searching (which most likely will be forever), they will use them and inadvertently use eager task creation.
Equivalent Kotlin accessors are already lazy; Groovy should be brought in line with them.

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team, but this area of Gradle is currently not a focus one, so it might take a while before it gets implemented.

This should happen around one or more major versions. It's unlikely 9.0 is one of these versions.


DynamoDb backend is polluting logging handlers

Hi guys,
could you please remove the logging.warning logs? It is using a basic configuration which automatically creates undesired logging handlers and causes duplicate logs in projects with their own logging. This issue was here before, but it was conditional, now it happens for everyone who does not have boto3 library installed.
Replication:
Simply import the library and see handlers in root logger.
Expectation:
There should be no handlers in root logger.
Environment:

Python version: 3.8.16
CacheLib version: 0.10.0

Thank you for considering fixing this.

Thanks for letting us know. I'll release a hotfix this weekend 👍

Hello!
It seem's like 0.10.1 has dropped to PyPI with the fix, but it is still Unreleased on the Changes page, and the pollution still happens.
$ mkdir /tmp/iss216 && cd /tmp/iss216
$ virtualenv venv && . venv/bin/activate
$ pip install -U cachelib
Collecting cachelib
  Using cached cachelib-0.10.1-py3-none-any.whl (18 kB)
Installing collected packages: cachelib
Successfully installed cachelib-0.10.1
$ python -c 'import cachelib'
WARNING:root:no boto3 module found

I checked sources on both PyPI and GitHub releases, and it looks like the release on GitHub has the changes included, but the boto3 import code is still present in PyPI release.

Thanks a lot for letting me know @senpos, just did a new release and checked the files. Everything seems in order now. Could you please double check and let me know if the issue is solved this time? Thanks

Yup, it works great now, no warnings were raised if I don't use the new DynamoDB storage!
Thanks!


Use batch mode

maven doesn't know whether it prints to a terminal or not, printing terminal escape sequences to the log (e.g. updating a single line X times ends up as X lines in the log).


fix(FA): Support pointer stream error

What does this PR do?
Supports pointer stream error for retries, to tentatively avoid flakes in the CI
Motivation
Try to avoid flakes by cleanly retrying on stream error. Next step is retrying on the error message itself.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


TestAutoscaling: Fix to work on platforms other than AWS

The zone suffix is only correct for AWS clusters, on other platforms
like Azure this test fails because no nodepool of that name exists.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/cc @csrwng

can we align the naming though?

/hold
This doesn't actually fix the test

/lgtm


DOCS-6003: Make CloudHub deployment example work

Without the context of the plugin many customers have problems applying this configuration. It should be added to all the examples.
Specifically for CloudHub deployments, it will fail without the  element.

This is being addressed in PR #845


patch TemplateError to remove cause.name in message

Hi—sorry, quick patch here on the error subclass.
I'd like to revert part of #89 by removing the lines that add (via ErrorName) to the error message. I got the idea to include that from Eleventy, but since Eleventy already includes that as a feature, you get error messages that duplicate the (via ...) text, like so:
[11ty] Error in template src/vento.vto:1:61
[11ty]
[11ty] <empty file>
[11ty]
[11ty] (via TemplateError) (via TemplateError)

[11ty] Error in template src/_includes/include.vto:1:1
[11ty]
[11ty] {{ hello.hello }}
[11ty]
[11ty] (via TypeError) (via TemplateError)

Is it better to leave the error handling (including cause chains, and the like) up to the implementation, like Eleventy, Lume, and others?
Sorry for the confusion!

fair.
Thanks


Event order form doesn't record number of tickets

If the number of tickets is selected on the event page and isn't changed in the createOrder page, the order sent to the server is always for one ticket.

Hello, I don't know if that's the same issue but hello I've created tickets for an event https://opencollective.com/make-it-sound/events/repair-cafe-100-audio-make-it-sound-18-11-16878ev#tickets > I defined "5" as booking limit but it does seem to appear anywhere or have any effect.. can you help me? Cheers Thanks

That's a different issue. I'll create a new one.


Not getting autoprefixer to work with extract-text-webpack-plugin

Hi,
I have a working dev config for my scss like this:
var autoprefixer = require('autoprefixer');

  module: {
    loaders: [
      {
        test: /\.scss$/,
        loaders: ['style-loader', 'css-loader?sourceMap', 'postcss-loader', 'sass-loader?sourceMap']
      }
    ]
  },
  sassLoader: {
    includePaths: ['node_modules/normalize.css'],
    precision: '8',
    outputStyle: 'nested'
  },
  postcss: [ autoprefixer({ browsers: ['last 10 versions'] }) ]

Now I wanted to extract the css to a file when I build for production. I get a file with the config below. The problem is that the options for postcss (for instance autoprefixer) doesn't get applied.
var autoprefixer = require('autoprefixer');
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var extractCSS = new ExtractTextPlugin('bundle.css');

  module: {
    loaders: [
      {
        test: /\.scss$/,
        loader: extractCSS.extract('style-loader', 'css-loader!postcss-loader!sass-loader')
      }
    ]
  },
  sassLoader: {
    includePaths: ['node_modules/normalize.css'],
    precision: '8',
    outputStyle: 'compressed'
  },
  postcss: [ autoprefixer({ browsers: ['last 10 versions'] }) ],
  plugins: [
    extractCSS
  ]
};

Can anyone see what I'm doing wrong?
Thanks

Seems like it is problem of css-loader CSS minifier. Please check Autoprefixer FAQ for details (sorry I am in the train in the middle of Kazakhstan) - you should move browser requirements to browserslist config.
Also last 10 versions is very lame config. I am sure, that you don't care about IE 3 or old Chrome 😉. Be responsible developer, talk with your client and set actual browser requirements (it should be equal to browsers where you test your website).

I'm not sure what you mean :)
First you point me to css-loader and then to autoprefixer?
And yes, thats just a test config with the last 10 browsers so that I can see if it's working or not.

Please check Autoprefixer FAQ section in Autoprefixer README. It contains question "No prefixes in production", answer will contain explanation and solution.
Sorry, I can't give you a direct link.

Ahh, now i see. Thanks!

@badtant You should disable the Minification option of css-loader with css?-minimize.
minification

@badtant - would love to see an example of your final working config

Webpack fixed a Autoprefixer issue, so we could just remove this section!

@donpinkus right now:
extractTextInstance.extract('style-loader', ['css-loader?-autoprefixer', 'postcss-loader')

Thanks @JounQin and @badtant ! Both are work!
    loader: ExtractTextPlugin.extract(
      'style-loader',
      'css-loader?-autoprefixer!postcss-loader'
    )

or
    loader: ExtractTextPlugin.extract(
      'style-loader',
      'css-loader?-minimize!postcss-loader'
    )

@hugojing please write +1 in this issue https://github.com/webpack/css-loader/issues/281
This is very important

Tried everything but still nothing. :
 module: {
        rules: [
            {
                test: /\.css$/,
                exclude: path.join(__dirname, '/angular2App/app/'),
                use: ExtractTextPlugin.extract({
                    fallback: ['style-loader'],
                    use: ['css-loader?-autoprefixer&sourceMap=true&importLoaders=1', 'postcss-loader']
                })
            },
       ...
      ]

postcss.config.js
module.exports = {
  plugins: [
    require('autoprefixer')
  ]
}

package.json
  "browserslist": [
    "> 1%",
    "last 2 versions"
  ],

No change, it doesn't add prefixes....

@szykov
Just for getting started, but could you please use try using webpack 2 loader syntax inside ExtractTextPlugin.extract() ?
webpack.config.js
ExtractTextPlugin.extract({
   fallback: 'style-loader',
   use: [
     {
        loader: 'css-loader',
       options : { autoprefixer: false, sourceMap: true, importLoaders: 1 }
     },
     'postcss-loader'
   ]
 })

postcss.config.js
plugins: [
- require('autoprefixer')
+ require('autoprefixer')()
]

@michael-ciniawsky well, I tried and it didn't help.
In readme of  autoprefixer it says that you don't need to self-execute library in postcss.config.js file:
https://github.com/postcss/autoprefixer

And create a postcss.config.js with:

 module.exports = {
   plugins: [
     require('autoprefixer')
   ]
 }

Anyway I tried exactly how you said, and haven't noticed changes. In my css map there's still the same code:
As an example it remained untouched:
.example {
 display: flex;
}

But should be:
.example {
    display: -webkit-box;
    display: -ms-flexbox;
    display: flex;
}

@michael-ciniawsky is there a way to disappear that postcss.config.js and push it into the webpack.config.js file? sorry to abuse you on this one 👴

webpack.config.js
ExtractTextPlugin.extract({
   fallback: 'style-loader',
   use: [
     {
       loader: 'css-loader',
       options : { importLoaders: 1 }
     },
     {
        loader: 'postcss-loader',
        options: {
          ident: 'postcss',
          plugins: () => [ require('autoprefixer')({...options}) ]
        }
     }
   ]
 })

👍

I find the real reason of no prefix, it's not the problem of extract-text-webpack-plugin. when build we use optimize-css-assets-webpack-plugin normally, optimize-css-assets-webpack-plugin use cssnano as default processor, and cssnano removed all prefix, so autoprefixer seemed  not work in production.
we can config like this:
new OptimizeCssAssetsPlugin({
    cssProcessorOptions: {
      safe: true,
      autoprefixer: { disable: true },
      discardComments: {
        removeAll: true
      }
    }
  });

the option of autoprefixer: { disable: true } will disable cssnano's autoprefixer and saved prefixer that already exist by ourselves.
also see the issue optimize-css-assets-webpack-plugin/issues/51
maybe some brother need this so I copy and attach this although this issue closed a long time ago.


Bump to v6.0.0

Let pypy be even more awesome.

Sorry for the delay, but now we've handed this snap up to upstream, I'm going to close this one. Thanks though.


Update to include MSSQL as a supported DB

Add MSSQL as a supported database in the intro paragraph to be consistent with the other MSSQL related changes to index.html. :smile:

@justinhhorner Cheers for this, should have been done a while ago. :+1:
Would you mind doing the same to the `README.md´ file so we don't need a seperate PR?

Yeah, no problem!


Example Request: Portfolio-independent, single-instrument tutorial (i.e. use_internal=False example)

The current implementations incorporate portfolio information into agents' training as part of the environment observation data (and hence is required later in live operation). This approach is very specific and I believe it would require frequent retraining to adopt to small changes that are likely to occur frequently for fine tuning such as changing trade_sizes in ManagedRiskOrders.
My suggestion is to create an implementation (or tutorial if it doesn't require changes in the codebase) that depends only on the market (exchange) data. This aims to answer the question "is it best now to buy, sell, or do nothing?". The actual fund and order management part (order size calculations, order type, real or simulated, ...etc) would be moved out of the agent's scope to the developer's own functionality to decide what to do with the received signals, whether using TensorTrade or other functionality.
I imagine that can be done by calculating the reward based on the instrument price difference between the buy and sell points.

The above suggestion aims to generate buy/sell signals at major price change points on the chart regardless of the actual position.
Another variation is adding the current position status as a flag (not actual position size) and P/L to the model inputs. Position status could be:

Holding / Not Holding (True/False) for full position buy/sell trading scenarios. The possible outputs are: Buy, Sell, Do Nothing.
Holding / Not Holding / Partial Position for the partial buy/sell scenarios. The possible outputs are: Buy / Sell (all) / Add to Position / Decrease Position.

yes .. the agent should not observe actual price .. or other specific levels .. Instead, it must be aware of relative or binary data of the targeted values. this way we can decouple the agents from specific levels and will avoid  re-training or dangerous trade situations

@123mitnik yes, price difference - if included - should be relative. Cumulative percentage change may even be better. Either way, that change should be part of the reward calculation.

I'm reopening this as a reminder of the example.

I'm reopening this as a reminder of the example.

This is possible now because it is no longer required that the portfolio needs to be included into the observation space. That can be done by the user and not internally.


Remove duplicate endpoint from explorer.md

the endpoint /output/<OUTPOINT> appeared twice in the list.

Nice, LGTM!


Issue#70 bug report template

fixex#70
This PR gives a detailed and precise BUG report template .
Henceforth a much detailed issue that could be understood by PAs , and whoever who tries to solve that particular issue.
Let's together make efforts to make TALK-IN app great!!

Hello , you didn't assign me this issue before merging?and there is no label at all . May i know why sir?


Why would meshes have the same number of vertex and triangles?

In the collision_utils.py
There is this condition:
       if not len(self.params['verts']) == len(self.params['tris']):
       raise TypeError(bc.FAIL + 'ERROR: number of tris must equal the number of verts in collision mesh.' + bc.ENDC)

As far as I know, unless you reuse some vertices you are going to get 3 times the amount of triangles. I doubt that all of them are going to be reused.
In case I am wrong, how can I convert a mesh to have the same numbers of vertices and triangles?

Yes, good catch!  You should be able to remove this equality check, and I'm guessing the underlying fcl model should be able to successfully initialize.  If not, just let me know.  Thanks!

Hi djrakita,
I tried as you suggested, I get a WARNING
WARNING: Mesh collision object not supported in rviz visualization
To verify It was just a matter of visualization I played with the urdf_viewer_with_collision_info.py.
However, I don't see the collision detected on the mesh.
Will it still be detected by the sample generator?
Cheers!

Yeah, at the time this code was written a few years ago, rviz didn't have a way to easily render arbitrary meshes (it looks like there are better ways of doing this now).  I would recommend either extending the relaxedIK to rviz pipeline to include mesh rendering options (specified here http://wiki.ros.org/rviz/DisplayTypes/Marker#Mesh_Resource_.28MESH_RESOURCE.3D10.29_.5B1.1.2B-.5D) or just calculate and display a bounding volume of your mesh just to verify that your object is transformed to where you want it to be.

Hi guys,
I update the mesh visualization for collision objects in rviz. Now, I'm able to visualize the mesh of the collision object but the urdf_viewer_with_collision_info.py doesn't show collisions between the robot and the object. How can I solve this problem?
Thank you!


Click house/v1.53.2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 17 committers have signed the CLA.:white_check_mark: rschu1ze:x: veblush:x: markdroth:x: HannahShiSFB:x: drfloob:x: sanjaypujare:x: sergiitk:x: apolcyn:x: comius:x: yijiem:x: matthewstevenson88:x: gankineri:x: ctiller:x: XuanWang-Amos:x: gnossen:x: eugeneo:x: jtattermuschYou have signed the CLA already but the status is still pending? Let us recheck it.


Vulnerability roundup 108: cups-2.3.3op2: 1 advisory [3.3]

search, files

[ ] CVE-2021-25317 CVSSv3=3.3 (nixos-unstable)

CVE details
CVE-2021-25317
A Incorrect Default Permissions vulnerability in the packaging of cups of SUSE Linux Enterprise Server 11-SP4-LTSS, SUSE Manager Server 4.0, SUSE OpenStack Cloud Crowbar 9; openSUSE Leap 15.2, Factory allows local attackers with control of the lp users to create files as root with 0644 permissions without the ability to set the content. This issue affects: SUSE Linux Enterprise Server 11-SP4-LTSS cups versions prior to 1.3.9. SUSE Manager Server 4.0 cups versions prior to 2.2.7. SUSE OpenStack Cloud Crowbar 9 cups versions prior to 1.7.5. openSUSE Leap 15.2 cups versions prior to 2.2.7. openSUSE Factory cups version 2.3.3op2-2.1 and prior versions.

Scanned versions: nixos-unstable: 942eb9a335b.
Cc @matthewbauer

Fixed:

nixos-unstable: cups-2.4.2


Please review my project :)

Items we can review on a live stream:

GitHub profile: SamDev98
Open source project: Password Manager - Python

You can also join the discord community here

Done! :)

Feel free to check out other cool repositories of EddieHub here

And done! :))

Little suggestion from my end:

Add Screenshots of your project in the readme
Add a working demo of your Project in the readme

Thanks for the suggestions,

The screenshots are present in the documentation.
As for the working demo, it being a desktop application, I cannot deploy it.

I mean you can record a video of your application working and then make a gif which you can show in the readme

Will do, thanks!

The link to your GitHub Profile in this issue does not work :(
Profile
Find it a little bit confusing that you pin the project in the readme and in your pinned repositories.
Maybe you can do only one of those things.
Project
Like the others submitted a gif / demo of the application would be nice in the readme.
I love the style of your documentation. But its little bit hidden and should be more present in the main readme.
Think there is a little styling issue.

Maybe you can also add a link on where to install Python3 (https://www.python.org/download/releases/3.0/) in the documentation.

@schmelto  Thanks for the detailed review!

I fixed the link, I didn't know it wasn't working before.
I pinned the repo because I will be adding a lot more soon and I wanted this one to be on top separately so I've added it in my readme.
The reason why the documentation seems a little hidden is because this repo will have multiple implementations and so I will have multiple docs linked to the main one soon, but I will keep this in mind for sure.
About the styling issue, It's just how the tkinter grid system scales. I don't like the idea of absolute positioning. The search button is to search based on the tag selected so that was the workflow there. Tag -> Search. But I'm no UI/UX expert, i will see if there is something I can do here.
I will add the link to install python3 for sure. Thanks!

Thank you for all your suggestions!
Also, if you want to contribute by fixing any of these code or documentation issues you are welcome to create an issue and PRs on them.

I fixed the link, I didn't know it wasn't working before.

🚀🚀🚀

About the styling issue, It's just how the tkinter grid system scales. I don't like the idea of absolute positioning. The search button is to search based on the tag selected so that was the workflow there. Tag -> Search. But I'm no UI/UX expert, i will see if there is something I can do here.

Yeah with this explanation this looks correct for me 🙈

Also, if you want to contribute by fixing any of these code or documentation issues you are welcome to create an issue and PRs on them.

I will do that

@schmelto Can you check out my repo now? I merged some beta updates to main and changed the documentation as well. :)

Thanks for sharing 👍 , I will review on a live stream / video soon 🤓 - looks like you got great community feedback already 💥

Hey @eddiejaoude thanks so much, I'd really appreciate your review! And yes, I've love that people had suggestions for me :) I had one small favour to ask, would you please just take a quick look at my new portfolio website as well? I would really like suggestions on that as well, if you have some time. It is very basic and won't take long to have a quick look!

And thanks again @schmelto for checking my repo out! :D


Bump Ohai / Cheffish to the latest

Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Looks like new Ohai broke ip address detection. I'll look into this before merging.


Unexpected behaviour of tf.image.convert_image_dtype

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): tf-nightly
Python version: 3.6.9
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
Convert a tf.int32 tensor to tf.float32 seems underflow. As shown in the below code, I think c should be the right result, correct me if I am wrong.
Describe the expected behavior
The tf.int32 tensorf should be scaled to [0, 1], as documented.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
a = tf.reshape(tf.range(0, 12), shape=(3, 4))
print(a)
print(tf.reduce_mean(a), '\n')

b = tf.image.convert_image_dtype(a, dtype=tf.float32)
print(b)
print(tf.reduce_mean(b), '\n')

c = a / tf.reduce_max(a)
print(c)
print(tf.reduce_mean(c))

# output
tf.Tensor(
[[ 0  1  2  3]
 [ 4  5  6  7]
 [ 8  9 10 11]], shape=(3, 4), dtype=int32)
tf.Tensor(5, shape=(), dtype=int32)

tf.Tensor(
[[0.0000000e+00 4.6566129e-10 9.3132257e-10 1.3969839e-09]
 [1.8626451e-09 2.3283064e-09 2.7939677e-09 3.2596290e-09]
 [3.7252903e-09 4.1909516e-09 4.6566129e-09 5.1222742e-09]], shape=(3, 4), dtype=float32)
tf.Tensor(2.561137e-09, shape=(), dtype=float32)

tf.Tensor(
[[0.         0.09090909 0.18181818 0.27272727]
 [0.36363636 0.45454545 0.54545455 0.63636364]
 [0.72727273 0.81818182 0.90909091 1.        ]], shape=(3, 4), dtype=float64)
tf.Tensor(0.5, shape=(), dtype=float64)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

I think you are correct. Can you compare the behavior on 1.15, 2.0, 2.1 and 2.2 releases so we can know the range where the regression was introduced?

I think you are correct. Can you compare the behavior on 1.15, 2.0, 2.1 and 2.2 releases so we can know the range where the regression was introduced?

It seems the behaviour is all in this way from 1.15-2.2... I tried all 1.15-2.2.
# !pip install tensorflow==1.15
import tensorflow as tf
print(tf.__version__)
# >>> 1.15.0

sess = tf.Session()

a = tf.reshape(tf.range(0, 12), shape=(3, 4))
print(sess.run(a))

b = tf.image.convert_image_dtype(a, dtype=tf.float32)
print(sess.run(b))

c = a / tf.reduce_max(a)
print(sess.run(c))

[[ 0  1  2  3]
 [ 4  5  6  7]
 [ 8  9 10 11]]
[[0.0000000e+00 4.6566129e-10 9.3132257e-10 1.3969839e-09]
 [1.8626451e-09 2.3283064e-09 2.7939677e-09 3.2596290e-09]
 [3.7252903e-09 4.1909516e-09 4.6566129e-09 5.1222742e-09]]
[[0.         0.09090909 0.18181818 0.27272727]
 [0.36363636 0.45454545 0.54545455 0.63636364]
 [0.72727273 0.81818182 0.90909091 1.        ]]

In this case, this likely is not a regression but a failure on the API.
Can you try passing in saturate=True?

In this case, this likely is not a regression but a failure on the API.
Can you try passing in saturate=True?

I tried saturate=True with TF 1.15 and 2.2. The issue exists in both version:
# ---tf 1.15
sess = tf.Session()

a = tf.reshape(tf.range(0, 12), shape=(3, 4))
print(sess.run(a))

b = tf.image.convert_image_dtype(a, dtype=tf.float32, saturate=True)
print(sess.run(b))

c = a / tf.reduce_max(a)
print(sess.run(c))

# --- tf 2.2
a = tf.reshape(tf.range(0, 12), shape=(3, 4))
print(a)

b = tf.image.convert_image_dtype(a, dtype=tf.float32, saturate=True)
print(b)

c = a / tf.reduce_max(a)
print(c)

The outputs are the same with attached above.

Thank you for the triage. This is then a bug that we will have to fix, though we also need to make sure we don't break users that depend on the existing behavior

Thank you for the triage. This is then a bug that we will have to fix, though we also need to make sure we don't break users that depend on the existing behavior

Can you explain the expected behavior? It seems the API only works when the conversion belongs to the same family (e.g. int -> int, float -> float). I also tried something below:
In [26]: x = [1, 2, 3]

In [27]: tf.image.convert_image_dtype(x, dtype=tf.float32, saturate=True)
Out[27]: <tf.Tensor: shape=(3,), dtype=float32, numpy=array([4.6566129e-10, 9.3132257e-10, 1.3969839e-09], dtype=float32)>

In [28]: x = [1.0, 2.0, 3.0]

In [29]: tf.image.convert_image_dtype(x, dtype=tf.int32, saturate=True)
Out[29]: <tf.Tensor: shape=(3,), dtype=int32, numpy=array([-2147483648, -2147483648, -2147483648], dtype=int32)>

I'll have to look through documentation and code history to get more details than what's already included in the comments.

The values are normalized by the MAX value of the input data type (as opposed to the MAX pixel value). In the example you've provided, the values are being normalized by int32's max value (2^32/2-1) which is huge, and therefore the output values are tiny.
I will update the function's API doc with better explanation and examples to help minimize confusion. I will loop back once it lands.

Here is the commit that adds better explanation and examples for convert_image_dtype function: https://github.com/tensorflow/tensorflow/commit/f577e5a128324f8708f9925d7035560e72bfb98f
It will be officially available on tensorflow.org with v2.4.0 API doc. (For now, please refer to the docstring.)
I will go ahead and close the issue.


Improve search colors

Change color of search text instead of only applying underline to make them more visible.

Thanks @viniciusban !


reorder setup

Guys, i still have problems with the reorder feature.
I have setup strict to false in the mysql config, but i also saw something about some parent_id, lft, rgt, depth fields added to the model?!

Hi @AurelDragut ,
Could you be more specific, please? What's the problem you're facing?
Cheers!

Sure, @tabacitu,
I made a fresh install of backpack, i added a CRUD for "sections", i changed "strict" from true to false (i remembered you once told me about it) and i tried to reorder the sections (not before setting those two lines about item to reorder, level and access). I have received the same error regarding the "item_id" that i wrote about here before.
So i went on the documentation site to see if maybe i missed something and so i have seen this...

so i did something like this

(i even added my self "order" data but with no luck - the page column is empty because of missconfigured select column but that's another story)

That all sounds good to me. That's the correct procedure. But you forgot to say what the error/problem is. Again :-))
So Here's a shot in the dark - have you used the CrudTrait on the model?
<?php

namespace Backpack\MenuCRUD\app\Models;

use Illuminate\Database\Eloquent\Model;
use Backpack\CRUD\CrudTrait;

class MenuItem extends Model
{
    use CrudTrait;

    protected $table = 'menu_items';
    protected $fillable = ['name', 'type', 'link', 'page_id', 'parent_id'];

When i push Save after reordering i get the alert (Your order nas not been saved) and in the logs i see this:
[2016-11-06 18:33:39] local.ERROR: exception 'ErrorException' with message 'Undefined index: item_id' in /home/menduit/public_html/vendor/backpack/crud/src/PanelTraits/Reorder.php:25

Hmm... item_id is the input name used by NestedSortable (the js plugin). Without that, no way it would work.

Do you have any javascript errors in your console?
Have you modified the reorder.blade.php in any way?
Have you modified the saveReorder() method in your CrudController in any way?

Cheers!

i get this in the console:

2)i didn't modify any of the reorder.blade.php or CrudController

Okaaay. Now we're onto it. So it's an error in the saveReorder() method or when trying to call it.  And if you click the URL what does the error say?

I think it might be a server security issue, let me check with the hosting company and i will get back to you. (I see something about a xhr error when i click there)

Wow, it seems it was a problem with the PHP version (i guess i had a previous version configured that they changed to 5.6)


[videoAPI] fast seek implementation

🚀 Feature
Seek that seeks to the closest keyframe before requested timestamp
Motivation
At the moment, seek function is restricted to a precise seek which under the hood finds the closest keyframe, and decodes frames until we reach our targeted frame. This is a convenient, however potentially slower operation. We want users to be able to decide if they want to seek to keyframes only (for the fastest possible version), we should allow it for them.
Pitch
Imagine we have a video with keyframes at 0s and 8.3s. Then the precise seek (current implementation) works as follows:
video.seek(2)
data = next(video)
print(data['pts'])
>> 2.002

video.seek(5)
data = next(video)
print(data['pts'])
>> 5.005

video.seek(9)
data = next(video)
print(data['pts'])
>> 9.009

And the imprecise seek (keyframes only):
video.seek(2, keyframes_only=True)
data = next(video)
print(data['pts'])
>> 0.0

video.seek(5, keyframes_only=True)
data = next(video)
print(data['pts'])
>> 0.0

video.seek(9, keyframes_only=True)
data = next(video)
print(data['pts'])
>> 8.341667

Additional context
This is a function provided in pyav already, so I think it would be useful to have it as an option.
Note:
This requires changes in the decoder C++ API which is IIUC used internally in FB; before accepting the PR, @fmassa should probably look into importing it and testing it internally. The default values and operations are kept the same, but nevertheless, there could be regressions not caught by our current tests.
cc @bjuncek

closed via #3179


feat: support Kroma Deposited Transaction

Description
This PR adds features to support Kroma Deposited Transaction.
You can run tests related to this PR by running
cargo test --package ethers-core --lib --features kroma -- types::transaction::kroma_deposited::tests --nocapture

This is a re-opened PR of #1, since the target branch to merge is changed.
The changes made in this PR was thoroughly reviewed in #1.

I wasn't aware that I could change base branch to merge. I will merge these changes in #1 after changing the base branch to merge.


feat: file soure support batch

file soure support batch reading multiple files at the same time

Thanks @L-607. Please follow the link in DCO check to pass it.
Do you encounter a scenario to read files simultaneously?
What about adding a parameter to switch this behaviour?


Disburse status with sub accounts

Currently there is no option for GET disburse status API to be called with sub-account status. This PR handles that case.

Hi @mantishK, thank you so much for the contribution. Would you mind bringing in latest changes from master so integration tests pass?

@stanleynguyen Done!

Thanks for the contribution @mantishK 👍


Database Writing Functionality

Work in progress functionality to write poseData to Firebase's Realtime Database.

Sorry, didn't realize that the PR updated until I closed it but the latest code is up


Numba-PyDPPL failure in PCA due to missing support for numpy.dot

PCA jit version makes calls to numpy.dot which is currently not supported in Numba-PyDPPL.

@adarshyoga Can you please retest with latest release. Support for numpy.dot was added using dpnp.

@adarshyoga Can you please retest with latest release. Support for numpy.dot was added using dpnp.

Works with the latest release

Works with the latest release


Improve Shopify logo

Quick update for the Shopify logo, sourced from https://www.shopify.com/brand-assets.
Before (master) and after (this branch). New is much higher quality/more accurate while still relatively small.

Hi @larouxn, thanks for the improvement! Sorry I'm not using the one from the brand assets.
One thing though, right now the repository is still using the markdown syntax for the image, and AFAIK there's no way to set the image to a set width. So I decided just to resize all the logo to 128px.
If you don't mind, could you resize the width of the logo to be 128px? I could also do it using the image from this PR.
I should've used the image tag from the beginning.
<img src="url" alt="" width="128">

👋 @fikrikarim, understood and no worries. I've updated the improved logo to be maximum 128px.

Thank you! I never imagined someone that work at the company would open a PR to improve the logo. Pretty cool Shopify!


resourceId() has return value that changes with the scope

resourceId - can be used at any scope, but the valid parameters change depending on the scope.
https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-functions-resource#resourceid

Closing for now, will re-open if interests comes in.


Update to fsnotify 0.2

The fix needed is simple. I don't know the dependencies policy of the project, if you prefer to add upper bounds instead or to keep compatibility with older versions (e.g. by removing sendHotSwap's type signature), feel free to disregard this.

Cool — what is different in this version of fsnotify?

They dropped system-filepath, see https://github.com/haskell-fswatch/hfsnotify/issues/57

Cool, fewer dependencies seems nice. Thanks!


Request had insufficient authentication scopes.

Environment Information

geemap version: 3.7.13 & 3.9.12
Python version: 0.13.10
Operating System: Colab & Win10

Description
I want to export image to Google Drive.However, When I enter Request had insufficient authentication scopes. It seems that I don't have enough authentication.
All the code is below
And after ee.Authenticate(), I got Successfully saved authorization token. callback. In my opinion, I have successfully authticated, but geemap.ee_export_image_to_drive give me this callback really confuses me.
What I Did
import ee
import geemap
ee.Authenticate()
ee.Initialize()
Map = geemap.Map()
Map.add_basemap()
region = ee.FeatureCollection(random feature collection)
Map.centerObject(region)
ukrian = region.geometry()
start_date = '2021-02-26'
end_data = '2022-03-04'
landcover = geemap.dynamic_world(region,start_date,end_data,return_type='hillshade')
Map.addLayer(landcover,{},'Land Cover')
Map
geemap.ee_export_image_to_drive(landcover,description='test',folder='export',scale=100)

Request had insufficient authentication scopes.

Make sure you check the two boxes during authentication.

我也遇到了同样的问题，请问你解决了吗


The translate button and coror mode button on the document's FocusLock does not work.

Which package has an issue?
Package Version
1.4.4
Description
When I try to select a language by pressing the translate button on the FocusLock of the document, the menu disappears.
However, this could not be confirmed on other pages.
PS: The color mode button did not work either.
Link to Reproduction
https://yamada-ui.com/ja/components/other/focus-lock
Steps to Reproduce

Go to https://yamada-ui.com/ja/components/other/focus-lock
Click on Open language switching menu.
Move the cursor.
Menu disappears

Browser
Chrome
Operating System

[ ] macOS
[X] Windows
[ ] Linux
[ ] iPadOS
[ ] iOS
[ ] Android

Do you know how to fix the issue?
No
Are you willing to participate in fixing this issue and create a pull request with the fix?
None
Additional Information
My apologies if this bug is due to my environment.

@Haru-0001
This is a specification.If it is FocusLock, anything in the area outside of it will not be focused, so this is the correct behavior.


[WIP] Secure HDFS Support

What changes were proposed in this pull request?
This it the on-going work of setting up Secure HDFS interaction with Spark-on-K8S.
The architecture is discussed in this community-wide google doc
This initiative can be broken down into 4 stages.
STAGE 1

[x] Detecting HADOOP_CONF_DIR environmental variable and using Config Maps to store all Hadoop config files locally, while also setting HADOOP_CONF_DIR locally in the driver / executors

STAGE 2

[x] Grabbing TGT from LTC or using keytabs+principle and creating a DT that will be mounted as a secret

STAGE 3

[ ] Driver + Executor Logic

STAGE 4

[ ] Service Pod that handles renewals

How was this patch tested?

E2E Integration tests

[x] Stage 1
[x] Stage 2
[ ] Stage 3
[ ] Stage 4

Unit tests

[ ] Stage 1
[ ] Stage 2
[ ] Stage 3
[ ] Stage 4

Docs and Error Handling?

[ ] Docs
[ ] Error Handling

Moved to #414


make an arch example

make ignition region in a popcon

FYI, this addition is being developed on a forked repository here: https://github.com/aarooshgr/cfspopcon/tree/aarooshgr_working
The initial goal is to provide a few more examples for new users, likely covering ARC or ARC variants like ARCH and MANTA.
I'm keeping an eye on initial development and will be the first point of contact for any added coded in this PR.


Add prop to enable or not bouncing on TabBar

I suggest adding this little property allowing users to enable or not bouncing (its highly desirable on iOS for example) on TabBar's ScrollView when scrolling is enabled.

@fantattitude . I'm trying to help the maintainer of this repo. If you can fix conflicts, that would help getting this merged. Thanks.

@fantattitude bump, can we get this through


Helm Task in ADO Pipeline

Required Information
When I use the Helm task to deploy a Helm chart to AKS I receive an error message.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: Helm Deploy
Environment

Server - Azure Pipelines
Agent - Hosted

Issue Description
- task: HelmDeploy@0
  inputs:
    connectionType: 'Kubernetes Service Connection'
    kubernetesServiceEndpoint: '$(AKS_SC)'
    namespace: '$(k8sNamespace)'
    command: 'upgrade'
    chartType: 'FilePath'
    chartPath: '$(Build.ArtifactStagingDirectory)/dso/Helm'

Running this pipeline task gives the following Helm command:
/usr/local/bin/helm upgrade --namespace default --install --wait 20201126.10 /home/vsts/work/1/a/dso/Helm
And results in the following error:
Error: unable to build kubernetes objects from release manifest: unable to decode "": resource.metadataOnlyObject.ObjectMeta: v1.ObjectMeta.Labels: ReadString: expects " or n, but found 2, error found in #10 byte of ...|nstance":20201126.1,|..., bigger context ...|etadata":{"labels":{"app.kubernetes.io/instance":20201126.1,"app.kubernetes.io/managed-by":"Helm","a|...
The issue seems to be that the automatically generated Release Name containing a "period" is not allowed in the default Helm templates. I get the same issue when running this on my command line.

On a side note, In the documentation the Parameter "chartPath" is not present but it is used in the example. This should be added here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/helm-deploy?view=azure-devops#upgrade-command

@StephanZaat did this helm chart work out locally for you?
Also side note; could you supply the debug logs as well as the chart for us to help debug it.

Well it seems to be an issue with running the out-of-the-box Helm commands.
➜  helm create test
Creating test
➜  helm upgrade --namespace default --install 2020.101231 test --debug
history.go:53: [debug] getting history for release 2020.101231
Release "2020.101231" does not exist. Installing it now.
install.go:172: [debug] Original chart version: ""
install.go:189: [debug] CHART PATH: /home/stephan/code/ams/helm/test

Error: unable to build kubernetes objects from release manifest: unable to decode "": resource.metadataOnlyObject.ObjectMeta: v1.ObjectMeta.Labels: ReadString: expects " or n, but found 2, error found in #10 byte of ...|nstance":2020.101231|..., bigger context ...|etadata":{"labels":{"app.kubernetes.io/instance":2020.101231,"app.kubernetes.io/managed-by":"Helm","|...
helm.go:81: [debug] unable to decode "": resource.metadataOnlyObject.ObjectMeta: v1.ObjectMeta.Labels: ReadString: expects " or n, but found 2, error found in #10 byte of ...|nstance":2020.101231|..., bigger context ...|etadata":{"labels":{"app.kubernetes.io/instance":2020.101231,"app.kubernetes.io/managed-by":"Helm","|...
unable to build kubernetes objects from release manifest
helm.sh/helm/v3/pkg/action.(*Install).Run
        /home/circleci/helm.sh/helm/pkg/action/install.go:257
main.runInstall
        /home/circleci/helm.sh/helm/cmd/helm/install.go:241
main.newUpgradeCmd.func2
        /home/circleci/helm.sh/helm/cmd/helm/upgrade.go:114
github.com/spf13/cobra.(*Command).execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
github.com/spf13/cobra.(*Command).Execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
main.main
        /home/circleci/helm.sh/helm/cmd/helm/helm.go:80
runtime.main
        /usr/local/go/src/runtime/proc.go:203
runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1373

You could use HelmInstaller task to fix the version in your runtime

Closing this issue, feel free to reopen if this problem still persists.


Refresh repository doesn't work

Rancher versions:
rancher/server: v2.0.0_223
Steps to Reproduce:

Setup Pipeline at the cluster level
Click Add Pipeline at project level
Click Refresh repository on the right of the filed Repository.

Results:
The Repository is still empty, nothing can be selected.
Expected Results:
The list of User Repository shows up.

Version - 2.0 master 2/27
Verified fixed


Can't click the remove all button from the file type

Reproduction
https://formkit.link/1b0f2c7fd04f3664669a180f7430c32b
Describe the bug
When click the Remove All inside the file type, the file input opens instead of removing the items.
Environment
• OS: PopOS 22.04
• Browser: Chrome 106.0.5249.91
• Version: @formkit/vue:1.0.0-beta.11

Hmm, looks like some styles got jacked on genesis here 😬

I'm going to adjust the genesis theme to better account for this, but the real issue here is that the multiple attribute is not creating a data-multiple="true" attribute on the outer section for the file input if you don't set it as multiple="true" in your template.
🚫 Broken
<FormKit
  type="file"
  multiple
/>

✅ Working
<FormKit
  type="file"
  multiple="true"
/>

https://formkit.link/d2c9187242bde934810e6283041dd751


Bluetooth: Mesh: Thread competition leads to failure to open or close the scanning.

Describe the bug
Bluetooth Mesh unable to start scanning or disable scanning, as a result, the provisioning procedure failed.
Use NRF52DK as Controller attach to Linux OS, Run Zephyr Bluetooth Host on Qemu.
To Reproduce
Steps to reproduce the behavior:
/* Controller */

west build -b nrf52dk_nrf52832 zephyr/samples/bluetooth/hci_uart/
west flash
sudo btattach -B /dev/ttyACM1 -S 115200 -R and Expecting Manufacturer: 1521.
sudo btproxy -u -z -i 1

/* Host */

west build -b qemu_cortex_m3 zephyr/tests/bluetooth/tester/
west build -t menuconfig -> enable console to uart print, enable logging, enable mesh debug and disable pb-gatt & proxy.

	struct bt_le_scan_param scan_param = {
			.type       = BT_HCI_LE_SCAN_PASSIVE,
			.filter_dup = BT_LE_SCAN_OPT_NONE,
			.interval   = MESH_SCAN_INTERVAL,
			.window     = MESH_SCAN_WINDOW };
	int err;

	BT_INFO("");

I adjusted the scanned log in the adv.c file in the mesh directory from DEBUG to INFO
west build

/* auto-pts */

./autoptsclient-zephyr.py "PATH\NAME.pqw6" ~/zephyrproject/build/zephyr/zephyr.elf -i <IP_ADDRESS> -l <IP_ADDRESS> -c MESH/NODE/PROV/BV-12-C

Logs and console output
Attachment has been submitted, see iut-zephyr.zip
iut-zephyr.zip
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK
Commit SHA or Version used : zephyr-v2.4.0-1367-g7d16ab50d738

Additional context
Add any other context about the problem here. relate or similar to #30808

Based on the log information, it is preliminarily inferred that it is a competition issue caused by the ADV thread and the HCI RX thread simultaneously enabling or closing scanning.
https://github.com/zephyrproject-rtos/zephyr/blob/380528676960d0fb57fae48d8616154a5e06705c/subsys/bluetooth/host/hci_core.c#L8563-L8574
ADV Thread will also operate scanning when closing the broadcast. At this time, this kind of competition problem may occur when the HCI RX thread calls bt_mesh_start-->bt_mesh_scan_start
[00100050] <dbg> bt_hci_core.bt_buf_get_cmd_complete: sent_cmd 0x2000ab28
[00100050] <dbg> bt_hci_core.hci_cmd_complete: opcode 0x200c
[00100050] <dbg> bt_hci_core.hci_cmd_done: opcode 0x200c status 0x00 buf 0x2000ab28
[00100050] <dbg> bt_hci_core.bt_hci_cmd_send_sync: rsp 0x2000ab28 opcode 0x200c len 1
[00100050] <dbg> bt_hci_core.set_random_address: 37:6c:ea:5b:ea:45
[00100050] <dbg> bt_hci_core.bt_hci_cmd_create: opcode 0x2005 param_len 6
[00100050] <dbg> bt_hci_core.bt_hci_cmd_create: buf 0x2000ab28
[00100050] <dbg> bt_hci_core.bt_hci_cmd_send_sync: buf 0x2000ab28 opcode 0x2005 len 9
[00100050] <dbg> bt_hci_core.send_cmd: Sending command 0x200c (buf 0x2000ab40) to driver
[00100050] <dbg> bt_hci_core.bt_send: buf 0x2000ab40 len 5 type 0
[00100050] <inf> bt_driver: 0c20020000
[00100050] <dbg> bt_hci_core.process_events: ev->state 0
[00100050] <dbg> bt_hci_core.hci_tx_thread: Calling k_poll with 2 events
[00100050] <dbg> bt_hci_core.process_events: count 2
[00100050] <dbg> bt_hci_core.process_events: ev->state 4
[00100050] <dbg> bt_hci_core.send_cmd: calling net_buf_get
[00100050] <dbg> bt_hci_core.send_cmd: calling sem_take_wait
[00100050] <dbg> bt_hci_core.bt_buf_get_cmd_complete: sent_cmd 0x2000ab40
[00100050] <dbg> bt_hci_core.hci_cmd_complete: opcode 0x200c
[00100050] <dbg> bt_hci_core.hci_cmd_done: opcode 0x200c status 0x0c buf 0x2000ab40
[00100050] <dbg> bt_hci_core.send_cmd: Sending command 0x2005 (buf 0x2000ab28) to driver
[00100050] <dbg> bt_hci_core.bt_send: buf 0x2000ab28 len 9 type 0
[00100050] <inf> bt_driver: 05200645ea
[00100050] <dbg> bt_hci_core.process_events: ev->state 0
[00100050] <dbg> bt_hci_core.hci_tx_thread: Calling k_poll with 2 events
[00100050] <wrn> bt_hci_core: opcode 0x200c status 0x0c
[00100050] <err> bt_mesh_adv: stopping scan failed (err -5)

This test item(MESH/NODE/PROV/BV-12-C) will repeatedly provision and reset nodes, the problem is in the reset process so that capture the problem.

https://github.com/zephyrproject-rtos/zephyr/blob/380528676960d0fb57fae48d8616154a5e06705c/subsys/bluetooth/mesh/cfg_srv.c#L1967-L1998
I think if it is possible to put the bt_mesh_reset operation in bt_mesh_send_cb::end to execute, there will be no such problem.
But the problem now is that the sending of the proxy does not implement the real callback. I think it is meaningful to implement the callback at this time.This will remove the concept of bt_mesh_proxy_on_idle because it is too obscure, which will fix the current problem and also optimize the existing network (for example, the publish operation will be based on periodicity when proxy used). @jhedberg @trond-snekvik  Any thoughts to this ?
Finally: https://github.com/zephyrproject-rtos/zephyr/blob/380528676960d0fb57fae48d8616154a5e06705c/subsys/bluetooth/mesh/pb_gatt.c#L121-L131
This is also a potential problem, because the callback is not implemented. As a result, certain specific provision procedure method cannot be performed normally.

From the log:

[00081960]  bt_hci_core: opcode 0x200c status 0x0c

So Set Scan Enable is failing with Command Disallowed, which is different from what is seen in #30808, where it was a Set Scan Parameters command that failed.
@cvinayak how can Set Scan Enable fail with command disallowed at all?

From the log:

[00081960]  bt_hci_core: opcode 0x200c status 0x0c

So Set Scan Enable is failing with Command Disallowed, which is different from what is seen in #30808, where it was a Set Scan Parameters command that failed.
@cvinayak how can Set Scan Enable fail with command disallowed at all?

@carlescufi The controller does not return success if scanning is already disabled. This is kept so, because the Zephyr Host maintains flags and it should not go out of sync w.r.t the state of scanning. This can be fixed in controller to ignore disables on already disabled scanning, but if host is maintaining incorrect state, then enabling an already started scanning by incorrect host state would fail with command disallowed.
As the host sets the BT_DEV_SCANNING flag [1] before the command complete in set_le_scan_enable_legacy  and set_le_ext_scan_enable, if there is a bt_le_scan_stop call made by another thread (while waiting for command complete), which in turn calls bt_le_scan_update, would there be incorrect flags state for BT_DEV_SCANNING and also based on the race condition as to which thread gets the hci_cmd buffer from bt_hci_cmd_create, controller may be asked to disable [2] a non-started scanning state?
[1] https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/host/hci_core.c#L1086
[2] https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/host/hci_core.c#L4202

@carlescufi The controller does not return success if scanning is already disabled. This is kept so, because the Zephyr Host maintains flags and it should not go out of sync w.r.t the state of scanning. This can be fixed in controller to ignore disables on already disabled scanning, but if host is maintaining incorrect state, then enabling an already started scanning by incorrect host state would fail with command disallowed.
As the host sets the BT_DEV_SCANNING flag [1] before the command complete in set_le_scan_enable_legacy  and set_le_ext_scan_enable, if there is a bt_le_scan_stop call made by another thread (while waiting for command complete), which in turn calls bt_le_scan_update, would there be incorrect flags state for BT_DEV_SCANNING and also based on the race condition as to which thread gets the hci_cmd buffer from bt_hci_cmd_create, controller may be asked to disable [2] a non-started scanning state?
[1] https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/host/hci_core.c#L1086
[2] https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/host/hci_core.c#L4202

@trond-snekvik will reproduce and try to find out what sequence in the code is causing a second Set Scan Enable to be sent.

@trond-snekvik will reproduce and try to find out what sequence in the code is causing a second Set Scan Enable to be sent.

I think Lingao's proposed fix in #31038 will resolve the issue for this specific case in the mesh, but there's still an issue in the general bluetooth.h interface.
The mesh is not using the bluetooth.h API wrong, and this can still occur in other bluetooth applications even after the mesh change is merged:
As Lingao proved in the comment above, the problem happens because the mesh is disabling advertising from one thread, then disabling scanning from another, before the advertising disable has exited.
The sequence of events is:

The controller receives an advertisement, and enqueues it for host processing.
In the host, the Mesh Adv Thread calls bt_le_adv_stop()

hci_core calls set_le_adv_enable_legacy(DISABLE), which waits for the controller to respond by pending on its sync_sem.
The controller handles the command, and enqueues the response for host processing

hci_core starts processing its event queue

It finds the advertisement from step 1, and passes it up to the mesh stack.

The mesh stack realizes that this is a reset() message, and calls bt_mesh_reset(), which disables the scanner
The mesh stack calls bt_le_scan_stop(), which calls a bt_le_scan_update(), which calls set_le_scan_enable(DISABLE).
hci_core sends the 0x200c scan disable HCI command, then pends on its sync_sem for the response
The controller handles the command, and enqueues the response for host processing

hci_core processes the adv_disable response from step 2.

It resumes processing of bt_le_adv_stop(), which checks the BT_DEV_SCANNING flag, which is still set.
It calls set_le_scan_enable(DISABLE) to regenerate the private addr.
This fails in the controller, since it is already disabled. The controller enqueues the failure response.

hci_core processes the first scan_disable response and clears the BT_DEV_SCANNING flag.
hci_core processes the second scan_disable response, and reports the error.

TL;DR: in the end of bt_le_adv_stop(), we're not checking if a scan command is already pending, and we end up doing a double disable.
This is the same sort of issue we've seen in hci_core multiple times before, where the flag state is only changed after a successful command, but someone tries to read the flag and send the same command while the controller is processing the first command.

I think Lingao's proposed fix in #31038 will resolve the issue for this specific case in the mesh, but there's still an issue in the general bluetooth.h interface.
The mesh is not using the bluetooth.h API wrong, and this can still occur in other bluetooth applications even after the mesh change is merged:
As Lingao proved in the comment above, the problem happens because the mesh is disabling advertising from one thread, then disabling scanning from another, before the advertising disable has exited.
The sequence of events is:

The controller receives an advertisement, and enqueues it for host processing.
In the host, the Mesh Adv Thread calls bt_le_adv_stop()

hci_core calls set_le_adv_enable_legacy(DISABLE), which waits for the controller to respond by pending on its sync_sem.
The controller handles the command, and enqueues the response for host processing

hci_core starts processing its event queue

It finds the advertisement from step 1, and passes it up to the mesh stack.

The mesh stack realizes that this is a reset() message, and calls bt_mesh_reset(), which disables the scanner
The mesh stack calls bt_le_scan_stop(), which calls a bt_le_scan_update(), which calls set_le_scan_enable(DISABLE).
hci_core sends the 0x200c scan disable HCI command, then pends on its sync_sem for the response
The controller handles the command, and enqueues the response for host processing

hci_core processes the adv_disable response from step 2.

It resumes processing of bt_le_adv_stop(), which checks the BT_DEV_SCANNING flag, which is still set.
It calls set_le_scan_enable(DISABLE) to regenerate the private addr.
This fails in the controller, since it is already disabled. The controller enqueues the failure response.

hci_core processes the first scan_disable response and clears the BT_DEV_SCANNING flag.
hci_core processes the second scan_disable response, and reports the error.

TL;DR: in the end of bt_le_adv_stop(), we're not checking if a scan command is already pending, and we end up doing a double disable.
This is the same sort of issue we've seen in hci_core multiple times before, where the flag state is only changed after a successful command, but someone tries to read the flag and send the same command while the controller is processing the first command.

For clarification, according to the spec both enabling the scanning when already enabled and disabling the scanner when already disabled shall return success:
If the LE_Scan_Enable parameter is set to 0x01 and scanning is already
enabled, any change to the Filter_Duplicates setting shall take effect.
Disabling scanning when it is disabled has no effect.

For clarification, according to the spec both enabling the scanning when already enabled and disabling the scanner when already disabled shall return success:
If the LE_Scan_Enable parameter is set to 0x01 and scanning is already
enabled, any change to the Filter_Duplicates setting shall take effect.
Disabling scanning when it is disabled has no effect.

Plan forward:

@cvinayak fix the controller so it complies with the spec as per my comment above
@trond-snekvik and @joerchan to analyze if other instances of the sequence described here are potentially present in the Host.

Plan forward:

@cvinayak fix the controller so it complies with the spec as per my comment above
@trond-snekvik and @joerchan to analyze if other instances of the sequence described here are potentially present in the Host.

@LingaoM Please verify if #31532 works around the failure to enable/disable scanning.

@LingaoM Please verify if #31532 works around the failure to enable/disable scanning.

Plan forward:

@cvinayak fix the controller so it complies with the spec as per my comment above
@trond-snekvik and @joerchan to analyze if other instances of the sequence described here are potentially present in the Host.

PR is posted, @trond-snekvik will verify that #31532, and then 2. is still remaining.

Plan forward:

@cvinayak fix the controller so it complies with the spec as per my comment above
@trond-snekvik and @joerchan to analyze if other instances of the sequence described here are potentially present in the Host.

PR is posted, @trond-snekvik will verify that #31532, and then 2. is still remaining.


Update script to support coreLibraryDesugaring, detektPlugins and ksp dependency declarations

Partial follow up to #45 to support converting the coreLibraryDesugaring dependency declaration.
I also added ksp and detektPlugins for projects that make use of the KSP and Detekt plugins.

The test seem to be failing

Yeah looks like my changes in #48 break this 🙃
I'll look into it now and try and find a fix


FEAT : Add increment using += support for ValueTracker

Closes #507
List of Changes

Add the __iadd__ method for ValueTracker

Motivation
Ease of use like tracker += 3.0
Explanation for Changes
The __iadd__ method in Python is used for overloading the operator +=
Acknowledgement

[x] I have read the Contributing Guidelines

Could add an unit test for this ? Thanks.

Should we add a depreciation warning for the old increment_value ? @ManimCommunity/core

Could add an unit test for this ? Thanks.

I would need some help with this. This is the class for ValueTrackerTest
https://github.com/ManimCommunity/manim/blob/16e18b26e5e2e230aa46c85fc04fdebf9f2fe1bf/tests/test_graphical_units/test_updaters.py#L19-L24
As far as I can see, increment_value hasn't been tested, right? So am I correct to say that I'll have to add 2 tests -- one for increment_value and the other for +=?

I think we should get rid of this function for add
ValueTracker does not have __add__. Do you mean __iadd__?

Defining __iadd__ in terms of __add__ (which happens automatically if you define the latter without defining the former) has the problems I described above:

creates a new object so references to the old one stop receiving updates
less efficient

On the other hand, using __add__ instead of __iadd__ makes it much more general, and means you only have to make changes to the implementation in one place. I'm not familiar with the project or how ValueTracker is used, so I don't know which option is better.

Also, AFAIK, += won't work when passed to play like self.play(tracker += 4.0), so in those cases, we'll have to use the plain increment_value.

@nilaybhatia increment_value doesn't return anything though. To clarify, if you want e.g. self.play(tracker + 4.0) to work (without mutating the tracker), then you can define __add__.

But yes, if we do decide to create at least one of __add__ or __iadd__, it is a good idea to (re)move increment_value.

Could add an unit test for this ? Thanks.

I would need some help with this. This is the class for ValueTrackerTest
https://github.com/ManimCommunity/manim/blob/16e18b26e5e2e230aa46c85fc04fdebf9f2fe1bf/tests/test_graphical_units/test_updaters.py#L19-L24
As far as I can see, increment_value hasn't been tested, right? So am I correct to say that I'll have to add 2 tests -- one for increment_value and the other for +=?

No no no, this is a graphical test. Please add a unit test, as for example test_container.py

increment_value doesn't return anything though. So you'd have to do it like this:
tracker.increment_value(4.0)
self.play(tracker)

No, this works and has been used by quite a lot of people in their projects:
self.play(tracker.increment_value,4.0)

I think this PR is getting a bit side-tracked. If the current purpose is to just implement iadd, then I think this could be merged after adding a quick test.
BUT there's many other things left to do. For example, get_value and set_value should all go away in favor of a property. And increment_value should be changed to also make use of that property, such that the code self.play(tracker.increment_value, 4.0) doesn't break.
AND THEN, there's the question of whether we even want self.play(tracker.increment_value, 4.0) to continue working at all. It's always been a mystery to me why sometimes you need ApplyMethod and not at other times.
But still, I think these all can/should be broken up into multiple PRs.

Please review the tests carefully. I want to double-check whether they are correctly written and are at the right place.

AND THEN, there's the question of whether we even want self.play(tracker.increment_value, 4.0) to continue working at all. It's always been a mystery to me why sometimes you need ApplyMethod and not at other times.

Yep. I think ValueTracker needs a refactor, to implement these features.


add EnsureWithSuccess

I would also like to replace all EnsureRootWithSuccess to use EnsureWithSuccess but that doesn't need to happen in this PR.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2080485

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2081452

bot rebase

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2082838

bot merge


feat(metrics): use MetricDescriptor to determine aggregator #989

Currently the batcher interface define the following:
export abstract class Batcher {
  // [ ... ]
  abstract aggregatorFor(metricKind: MetricKind): Aggregator;
  // [ ... ]
}

Which is spec compliant but from a user perspective it only possible to use a specific aggregator for each kind of metricKind. Some might want to configure that on a more granular level using the metric name or labels for example.
The go implementation already use MetricDescriptor instead of MetricKind i believe for the same reason: https://github.com/open-telemetry/opentelemetry-go/blob/master/sdk/export/metric/metric.go#L100
More details here: https://github.com/open-telemetry/opentelemetry-js/issues/989#issuecomment-622970316

Codecov Report

Merging #1014 into master will decrease coverage by 24.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1014       +/-   ##
===========================================
- Coverage   95.00%   70.86%   -24.14%
===========================================
  Files         212       61      -151
  Lines        8806     1119     -7687
  Branches      796      190      -606
===========================================
- Hits         8366      793     -7573
+ Misses        440      326      -114

Impacted Files
Coverage Δ

packages/opentelemetry-core/test/utils/url.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...ckages/opentelemetry-core/test/platform/id.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...s/opentelemetry-core/src/platform/node/sdk-info.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...pentelemetry-core/src/platform/node/performance.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...pentelemetry-core/test/internal/validators.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...ntelemetry-core/test/trace/NoRecordingSpan.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...telemetry-core/test/platform/hex-to-base64.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...elemetry-core/test/trace/spancontext-utils.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...lemetry-core/test/trace/ProbabilitySampler.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...try-core/test/trace/fixtures/test-package/index.js
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 152 more

@legendecas Will do a quick example in a seperate PR. You are right, this system would be replaced by the View API later on


Improve logic for computing thermal expansion factors

What is the change?
The logic within axialExpansionChanger.py::ExpansionData::computeThermalExpansionFactors was prone to computing the wrong thermal expansion factors for some corner cases. This PR aims to address these use cases by adding an optional parameter that specifically calls out if the temperature change for computing the thermal expansion factors should use c.inputTemperatureInC and c.temperatureInC (i.e., if coldHeightsToHot is True) or between the "component reference temperature" and c.temperatureInC (i.e., if coldHeightsToHot is False).

Why is the change being made?
The logic for computing thermal expansion factors was error prone and could be misinterpreted.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify that the new/changed code works.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[ ] The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in setup.py.

Converting to draft while I figure out downstream merge dependencies.


can't npm install with iojs 2.2.1

I dont' know if this is due to using iojs, but npm install -g rally-app-builder fails unless I manually install the following packages first:
npm install -g brace-expansion
npm install -g wrappy
npm install -g concat-map
npm install -g balanced-match
npm install -g core-util-is

Only after i install those 5 dependencies globally can I install and rab build

I'll try to look into this a bit.  I haven't used io.js yet.  I heard that it's going to be merging back with the main node project at some point in the future too, so that will be interesting.  Does this issue still happen with the latest release (3.3.1)?

Wow, node has all come a long way since I last looked into it...  I just did a test with version 4.1.2 and it installed globally without issues (on OSX).  What platform are you using?

I honestly don't remember. That was a long time ago. I haven't run into it in awhile so ill close this.


sample1

Please provide any additional information, record a screencast with http://quickcast.io or http://screenr.com and attach a screenshot if possible.
JS Bin info

http://jsbin.com/edit
Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.132 Safari/537.36
Databoom

See other issue


Fix strong mode issue in _PosixUtils._which.

ProcessResult.stdout has static type dynamic so for
inference to infer proper type argument for the map
invocation we need to cast stdout to String explicitly.
Fixes #17163

@tvolkert FWIW flutter-build line says "Be careful when merging". Maybe it should be changed to "Don't merge" to communicate the policy?

@mraleph I never noticed that text - thanks for pointing it out!
Filed https://github.com/flutter/cocoon/issues/196


Layout state management

every time a layout is run, do the following things:

reset data to default state which means:
- remove any scratch data
- perform the same operations independent of whenever a layout is run (e.g make sure all nodes are collapsed)

https://github.com/PathwayCommons/pathways-search/commit/3634e97729239076d3d70e06b020f05bb22e1040


[stable/prometheus-mysql-exporter] to enable/disable collector flags …

What this PR does / why we need it:
to enable/disable mysql-exporter collector flags from the value file.
Signed-off-by: Kilhyun Jun<EMAIL_ADDRESS>@Juanchimienti
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @sameersbn

@paulczar What's the status with this? Would you accept a new PR with the changes you request? I want to get the process list so I can alert on long running queries.


with-latest-from doesn't take multiple others.

withLatestFrom in RxJS and RxJava can take multiple others.
https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/withlatestfrom.md
https://github.com/ReactiveX/RxJava/pull/3966
http://reactivex.io/RxJava/javadoc/rx/Observable.html#withLatestFrom(java.lang.Iterable, rx.functions.FuncN)

We are not using rxjs 4.x,  the 5.x does not allows multiple observables (http://reactivex.io/rxjs/class/es6/Observable.js~Observable.html#instance-method-withLatestFrom)
I know that the jvm allows it, but it is normalized to one observable for bot impl.


Download queueing not working

When there is a game downloading if you try to install another game it will say it is queued to download but never starts.

Thanks for reporting! It will be fixed in v1.0.4.