Still incorrect steps.

Already had an issue for this #1076.  So I will create a new one and reiterate to get it fixed as the old one is closed.
Section, "What does an illicit consent grant attack look like in Office 365?"
Sub section, "Steps for finding signs of this attack"
Step 4 is not correct.

First you must click a "Filter Results" button.
Next you must put something into one of the columns

Column choices are: Date, IP Address, User, Activity, Item, Detail.
Clarify what is to be typed in what field.

The results will then filter based on what you type into the filter.
Existing page specifies none of this and what should be used to filter is unintelligible.
If whomever updates the document would actually open the page it would be painfully obvious.
I will enter more tickets so as not to confuse anyone for other issues still existing that have not been fixed.
Thanks.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d66854a7-7556-9b2a-0a33-886e3d881047
Version Independent ID: 7ce3d8d5-cece-0b6f-68d5-143e12a3fff8
Content: Detect and Remediate Illicit Consent Grants in Office 365 - Office 365
Content Source: microsoft-365/security/office-365-security/detect-and-remediate-illicit-consent-grants.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

Hello @agoldenlife James 👍 how are you?
I will take a look and get back.

Hello @MSFTTracyP How are you?
Tried to follow the steps currently outlined in the article in my lab tenant.
It is true that the steps need a correction, as @agoldenlife James kindly says here, once you get to step 4, you need to Click on "Filter Results" button,  and next, you have to type something on a column. (Which I can suspect is Activity.). That is something I can fix thru a PR easily.
However, on my lab tenant, I consented an app to force an event of type consent grant or similar to appear, and, I could not recognize a oAuth2PermissionGrant event, only a User Logged in activity appeared and in ExtendedProperties an OAuth2:Authorize RequestType, this was the most closed I could get.
Can you kindly shed some light here on the exact type of activity that should we filter for on the audit log? I appreciate.

Hi there. Thanks for your feedback, and for the valuable testing that's rendering that feedback. That's very useful for articles like these. I'd like to let you know, @agoldenlife and @get-itips, that I'm looking into your questions right now. Please let me know if you notice any other inaccuracies, and I'll update the thread when I have answers for each of these!

Hi there. Thanks for your feedback, and for the valuable testing that's rendering that feedback. That's very useful for articles like these. I'd like to let you know, @agoldenlife and @get-itips, that I'm looking into your questions right now. Please let me know if you notice any other inaccuracies, and I'll update the thread when I have answers for each of these!

Hello Tracy, I could finally log the Consent to application. event in my demo tenant, it is indeed of type activity, I will propose a Pull Request into the article for your to review. Thank you!

@get-itips Thank you for letting me know! I would think, as it took a bit of work to sort out how this was done, that entering how to find this in the PR is valuable knowledge. Testing like yours is how we keep this information useful for everyone. Thank you so much for coming in here and letting me know how your testing was going! Please keep in touch!


add laravel 7.0 support

How did you get past the removal of the PresentsCommand in Illuminate/Foundation?

I think there's a little more to it than just bumping the version constraint for this one.
I'm going to use #88 and tag a new major version that supports 7.x.


Add a new API to get DMA map of memory

Add a new API to get the DMA memory or the Physical Address of the peer mapped memory.
This will allow NIC devices to use the physical addresses directly instead of using the CUDA provided Unified Memory Address.

Hi @ajitkhaparde,
If my understanding is correct, gdr_p2p_dma_map_buffer is the same as gdr_pin_buffer. However, it also returns paddr of the cudaMalloc'd VA. Why do you need this information? Will you pass this paddr to your NIC stack?
At least for NVIDIA NICs, nvidia-peermem driver is used to provide this functionality. That PA and the corresponding DMA addresses are exchanged inside the kernel space. You can also use DMABUF instead of nvidia-peermem driver.

Yes. That is correct.
I am using that in the DPDK gpudev library.
At the end of it all, the PA is passed to the NIC driver for direct DMA to
the GPU memory.
Here is the patchwork link.
https://patches.dpdk.org/project/dpdk/list/?series=32920
Thanks
Ajit
On Thu, Sep 5, 2024 at 9:24 PM Pak Markthub @.***>
wrote:

Hi @ajitkhaparde https://github.com/ajitkhaparde,
If my understanding is correct, gdr_p2p_dma_map_buffer is the same as
gdr_pin_buffer. However, it also returns paddr of the cudaMalloc'd VA.
Why do you need this information? Will you pass this paddr to your NIC
stack?
At least for NVIDIA NICs, nvidia-peermem driver is used to provide this
functionality. That PA and the corresponding DMA addresses are exchanged
inside the kernel space. You can also use DMABUF instead of nvidia-peermem
driver.
—
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA/gdrcopy/pull/304#issuecomment-2333208109, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5LBLEMC7OGIEWGVMIBQMLZVEVBRAVCNFSM6AAAAABNXYQGM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZTGIYDQMJQHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

FYI exposing phys addresses to user space is considered a security risk, hence this MR would not pass a security review.
Depending on your use case, it might still be usable for you.

Exposing PA to user space is considered a security risk. We cannot accept this change.
Closing it.


Fix editLink plugin + add plugin example

fix EditLink
createLink override - Inset Link button now inserts new link, and modifies existing link
unlink override - if no text is selected and cursor is "inside" link, selection expands and removes whole link
editlink.html example
fixes #224

Since the code is less heavy, I think to add it in Trumbowyg core. I need to test it asap.
Thanks for your involvement in this project :)

I merge it, but I need to change some things to be OK with jshint and maybe fix your workaround if it's possible :)

Seems I'll have to tweak my jshint and beautify settings, so there is no need to fix formatting in the future.

As you cas see on develop I've merge your plugin in core. I've also fix some bugs in my code and fix your workaroud (it was my fault).
Thanks for your PR!

Awesome.


Pointers to native classes should not be dereferenced by C#

Actual behavior
The GdipDeleteRegion method gets a friendly overload that takes ref GpRegion instead of GpRegion*.
This might be fine, except that GpRegion* should never be dereferenced, since it's a pointer to a class on the C++ side. The struct defined in the metadata has an IntPtr field, but unlike HWND where that is just a copyable opaque value, GpRegion (and other GDI+ structs) actually represent C++ classes, and the 'field' in these structs is misleading. What would really be at that memory location is the first field in the C++ class, so copying around the struct in C# would lead to data corruption as anyone that re-takes the pointer to the struct would expect the full class fields where the struct is, and they wouldn't be there.
Expected behavior
Any extern methods that take a pointer to a native object should not have friendly overloads that replace the pointer with ref or other modifiers.

Blocked on microsoft/win32metadata#1821


This re-adds the build version of the "qx serve" website

It wasn't a good idea after all to gerate the built version on demand since it can get out of sync and we have no auto-update mechanism in place

This problem was only showing when using a git checkout, which would not update the build files. NPM version did not have the problem.


send cookies for client side ajax request

I observed that it does not send cookies for client side request , also req obj comes undefined in apiclient for client side ajax request.

What is your issue ?
The auth cookie, only used, is defined here:
https://github.com/bertho-zero/react-redux-universal-hot-example/blob/903c2ca1cff433d830b68964bc941330ea3d2959/src/redux/modules/auth.js#L112-L119

Hey, thanks for nice repository, I was doing wrong, checking on subdomain.


[in_app_purchase] Feature request: Google Play application licensing for testing billing

Hi, to my knowledge there is currently no way to setup google play application licensing on a flutter app. This means I have to launch my app to the public before I can test my in_app_purchase integration and my 'Real-time developer notifications' via pub/sub & Cloudrun which is not ideal.
https://developer.android.com/google/play/billing/test
I found this repo that looks like someone had this working but 2 years out of date no longer maintained. It would be great to have an official package that enables this functionality.

There have been similar questions raised on support platforms but there doesn't seem to be a concrete solution or a package which offers this feature currently.
https://stackoverflow.com/questions/55204380/google-play-license-verification-library-with-flutter
https://stackoverflow.com/questions/71698672/how-do-i-implement-flutter-play-license
https://www.reddit.com/r/FlutterDev/comments/jiv9jn/google_play_license_verification_library_with/
https://github.com/flutter/flutter/issues/29470
Also, don't see any package on pub.dev for same.
Keeping it open and labeling as proposal and for further insights from the team on feasibility of this request.

Hi, to my knowledge there is currently no way to setup google play application licensing on a flutter app. This means I have to launch my app to the public before I can test my in_app_purchase integration and my 'Real-time developer notifications' via pub/sub & Cloudrun which is not ideal.
https://developer.android.com/google/play/billing/test
I found this repo that looks like someone had this working but 2 years out of date no longer maintained. It would be great to have an official package that enables this functionality.

I forked that and try to maintain my own now
https://github.com/salgut408/flutter_play_licensing


can't download video with contentProtection tag

I'm trying to download video with this mpd:
https://level3-usp-dash-arch.cmore.se/live/3201122.isml/3201122.mpd
youtube-dl raised error:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'https://level3-usp-dash-arch.cmore.se/live/3201122.isml/3201122.mpd?t=2017-09-06T16:55:00.000-2017-09-06T18:40:00.000', u'--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.09.02
[debug] Python version 2.7.11 - Darwin-16.7.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2.2, ffprobe 3.2.2
[debug] Proxy map: {}
[generic] 3201122.mpd?t=2017-09-06T16:55:00.000-2017-09-06T18:40:00: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 3201122.mpd?t=2017-09-06T16:55:00.000-2017-09-06T18:40:00: Downloading webpage
[generic] 3201122.mpd?t=2017-09-06T16:55:00.000-2017-09-06T18:40:00: Extracting information
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 776, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 434, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2134, in _real_extract
    self._sort_formats(info_dict['formats'])
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1072, in _sort_formats
    raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

This mpd file contain ContentProtection tags, and haven't SegmentList tags. Is it possible to download video with manifest contained this tags?

Not possible.


PHOENIX-6181 IndexRepairRegionScanner to verify and repair every glob…

…al index row

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
8m 39s
4.x passed

+1 :green_heart:
compile
0m 53s
4.x passed

+1 :green_heart:
checkstyle
1m 13s
4.x passed

+1 :green_heart:
javadoc
0m 45s
4.x passed

+0 :ok:
spotbugs
2m 54s
phoenix-core in 4.x has 957 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 54s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

-1 :x:
checkstyle
1m 21s
phoenix-core: The patch generated 542 new + 1433 unchanged - 372 fixed = 1975 total (was 1805)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 41s
the patch passed

-1 :x:
spotbugs
3m  3s
phoenix-core generated 1 new + 956 unchanged - 1 fixed = 957 total (was 957)

_ Other Tests _

-1 :x:
unit
1m 12s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

34m 35s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.coprocessor.GlobalIndexRegionScanner.shouldVerify(IndexTool$IndexVerifyType, byte[], Scan, Region, IndexMaintainer, IndexVerificationResultRepository, boolean) may expose internal representation by storing an externally mutable object into GlobalIndexRegionScanner.indexRowKeyforReadRepair  At GlobalIndexRegionScanner.java:IndexVerificationResultRepository, boolean) may expose internal representation by storing an externally mutable object into GlobalIndexRegionScanner.indexRowKeyforReadRepair  At GlobalIndexRegionScanner.java:[line 328]

Failed junit tests
phoenix.index.ShouldVerifyTest

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/915

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux b294a7ca6906 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 3008ca9

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/testReport/

Max. process+thread count
487 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
32m 47s
4.x passed

+1 :green_heart:
compile
0m 58s
4.x passed

+1 :green_heart:
checkstyle
1m  0s
4.x passed

+1 :green_heart:
javadoc
0m 49s
4.x passed

+0 :ok:
spotbugs
3m  8s
phoenix-core in 4.x has 956 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
29m  2s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

-1 :x:
checkstyle
1m  3s
phoenix-core: The patch generated 575 new + 1421 unchanged - 385 fixed = 1996 total (was 1806)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

-1 :x:
spotbugs
3m 21s
phoenix-core generated 1 new + 955 unchanged - 1 fixed = 956 total (was 956)

_ Other Tests _

-1 :x:
unit
1m 26s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

77m 59s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.coprocessor.GlobalIndexRegionScanner.shouldVerify(IndexTool$IndexVerifyType, byte[], Scan, Region, IndexMaintainer, IndexVerificationResultRepository, boolean) may expose internal representation by storing an externally mutable object into GlobalIndexRegionScanner.indexRowKeyforReadRepair  At GlobalIndexRegionScanner.java:IndexVerificationResultRepository, boolean) may expose internal representation by storing an externally mutable object into GlobalIndexRegionScanner.indexRowKeyforReadRepair  At GlobalIndexRegionScanner.java:[line 328]

Failed junit tests
phoenix.index.ShouldVerifyTest

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/915

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 23e85e95bce0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 264310b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/2/testReport/

Max. process+thread count
442 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
32m 29s
4.x passed

+1 :green_heart:
compile
1m  1s
4.x passed

+1 :green_heart:
checkstyle
0m 59s
4.x passed

+1 :green_heart:
javadoc
0m 47s
4.x passed

+0 :ok:
spotbugs
3m  9s
phoenix-core in 4.x has 956 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
28m 50s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

-1 :x:
checkstyle
1m  3s
phoenix-core: The patch generated 582 new + 1420 unchanged - 386 fixed = 2002 total (was 1806)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 46s
the patch passed

-1 :x:
spotbugs
3m 23s
phoenix-core generated 1 new + 955 unchanged - 1 fixed = 956 total (was 956)

_ Other Tests _

-1 :x:
unit
1m 25s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

81m 51s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.coprocessor.GlobalIndexRegionScanner.shouldVerify(IndexTool$IndexVerifyType, byte[], Scan, Region, IndexMaintainer, IndexVerificationResultRepository, boolean) may expose internal representation by storing an externally mutable object into GlobalIndexRegionScanner.indexRowKeyforReadRepair  At GlobalIndexRegionScanner.java:IndexVerificationResultRepository, boolean) may expose internal representation by storing an externally mutable object into GlobalIndexRegionScanner.indexRowKeyforReadRepair  At GlobalIndexRegionScanner.java:[line 333]

Failed junit tests
phoenix.index.ShouldVerifyTest

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/915

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 1e8a21fbdd5a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 2359f54

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/3/testReport/

Max. process+thread count
447 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Add hats and berets to the uniform printer

About the PR

Added some hats and berets to the uniform printer
Why / Balance

Some maps don't have dressers for command roles yet. And if there's a bureaucratic error event that all the new heads can wear the same hat.
 In this case, something about the YAML file you changed is not matching with the style guide set by the maintainers.

Syndie pajamas are contraband...

Syndie pajamas are contraband...


Selected Item Highlight Text

The highlightedFont is set to bold. However, when you select another item the previous item remains bold and the new item's font does not become bold. When the first item is scrolled off the screen it is redrawn and the font is set to the system font rather than the bold font.
It would appear that the issue is with the selected implementation of the AKCollectionViewCell. Changing this from _selected to selected removing the initialisation to false and updating the setting in the cellForRowAtIndexPath fixed the issue for me.
Has anyone else had this issue? Could it be the way I am initialising the picker or is this a genuine issue others have experienced?

Hey.
I've had the same struggle, that's why I came to the thread.
There was a notice in the readme file, that you have to call pickerView.reloadData() whenever you change its settings. Solved the issue for me.
Still has a problem like all the reload methods do. The view blinks to redraw. This blink also takes away the swiping animation so I guess calling the reload method is not the best solution here.
Can you please show your solution?

Came here for the same issue.
Based on Scott mentioned, I think I manage to replicate his solution...
In the 'AKPickerView.swift' file, find the 'private class AKCollectionViewCell : UICollectionViewCell' initialisation (line 57 for me)
Where you see 'var _selected : Bool = false {...}I changed it tooverride var selected: Bool  {
didSet(selected) {
let animation = CATransition()
animation.type = kCATransitionFade
animation.duration = 0.15
self.label.layer.addAnimation(animation, forKey: "")
self.label.font = self.selected ? self.highlightedFont : self.font
}
}`
Then further down in the 'public func collectionView( cellforItemAtInexPath)' you will see an error with 'cell._selected = (indexPath.item == self.selectedItem)'.
I just then update 'cell._selected' with the new 'cell.selected'
Built the code, and now it seems to be behaving as expected. :)

Same problem here, @simonarcher your solution worked!

Also note: call .selectItem(index, animated: false) in viewDidLoad. This including changes mentioned above did the trick for me.

I've not used highlighted font anywhere. But still, by default the title is set with a bold system font!! But after scrolling back and forth, it returns to the normal one. Any one experienced anything similar? It happens only at the beginning.
I'm not sure if my issue can be mentioned here. Let me know if I need to raise a separate one for this.

Please find the code used. This is from your example.
override func viewDidLoad() {
	super.viewDidLoad()
	self.pickerView.delegate = self
	self.pickerView.dataSource = self
	self.pickerView.pickerViewStyle = .flat
	self.pickerView.maskDisabled = false
            self.pickerView.selectItem(5, animated: true)
	self.pickerView.reloadData()
}

The selected item is displayed in Bold. :(
After scrolling it off the screen, if it's scrolled back, it displays in the expected way. :)
Any idea why this happens?
Also, attached is a gif of this behaviour.

this is still not fixed, i am struggling on finding a fix


cabal-gild discovers no extra-source-files

I am using cabal-gild like this:
cabal-version: 1.12
-- This file has been generated from package.yaml by hpack version 0.36.0.
--
-- see: https://github.com/sol/hpack
name: site
version: 0.0.0
build-type: Simple
-- cabal-gild: discover assets content style templates
extra-source-files:

But no extra-source-files are being filled in.
Am I doing something silly?

Which version of Gild are you using?

$ cabal-gild --version
<IP_ADDRESS>

It's just what's in https://github.com/cachix/pre-commit-hooks.nix

Using the discover pragma to discover extra-source-files was added in version <IP_ADDRESS> via #86. However it's buggy until version <IP_ADDRESS> because of #93 (which was fixed by #95).
Can you try with the latest version to see what happens?

@tfausak thanks for the response! Using a newer version would require an override that will be complex to maintain so I'll wait until the newer version is in the latest stable release that I use, which is in December.
Closing this until then.

Ok, sounds good. Please do let me know if it doesn't work or behaves unexpectedly.


Document the /directory/list/room/{roomID} route

FTR a GET on this route shows the visibility of a room (i.e. if the room is listed on the public rooms directory) and a PUT changes this setting.

dup https://github.com/matrix-org/matrix-doc/issues/417


Theme Inheritance does not work correctly

Moved from (exclusively related to Quark theme): https://github.com/getgrav/grav/issues/2527#issue-450850604
I want to use the Quark theme, but I need to customize it (logo, footer, colors, etc.), and of course it needs to be updated without overriding user changes.
So, I created an inherited theme Quark Inherit. However, the page does not appear the same as when it is set as the default Quark theme.
The only difference found is that the Quark theme uses the styles:
<link href="/user/themes/quark/css-compiled/spectre.min.css" type="text/css" rel="stylesheet">
<link href="/user/themes/quark/css-compiled/theme.min.css" type="text/css" rel="stylesheet">

but Quark Inherit theme uses the styles:
<link href="/user/themes/quark/css-compiled/spectre.css" type="text/css" rel="stylesheet">
<link href="/user/themes/quark/css-compiled/theme.css" type="text/css" rel="stylesheet">

It should not have any effect, but probably the compiled version of CSS is different. It is also strange why an inherited theme uses uncompiled CSS. But it is possible that the error is somewhere else.
Next, the Custom logo is replaced by the default Grav logo.

This 'issue' occurs when the theme has specific settings, as in the case of Quark theme, because this setting is not automatically inherited. It is not really an issue, but a logical behavior.
Solution:

Copy /user/themes/quark/quark.yaml to /user/config/themes/quark-inherit.yaml and you can adjust the necessary settings manually

or

Copy the 'form' part from /user/themes/quark/blueprints.yaml to /user/themes/quark-inherit/blueprints.yaml and you can adjust the necessary settings (/user/config/themes/quark-inherit.yaml) via the Admin Plugin (Menu => Themes => Quark Inherit)

Alternatively, you can use a copy of the theme instead of inheriting, but that is a different approach.
Special thanks: @rhukster, @ricardo118


Using UTC

Hi,
I'm using this as follows:
{{moment-calendar drawing.updated_at locale='nl'}}
However, drawing.updated_at is a UTC time string. It is displayed as the UTC time, but I would like it to be displayed in the user's time zone. How can I tell moment that the input time is UTC rather than local time, so that it is converted? From the moment docs it seems that it is possible to call moment.utc() for this. Is this implemented in ember-moment or is there a work-around?

Something like the follow may work.
// app/helpers/moment-utc.js
import moment from 'moment';

export default Ember.Helper.helper(function([time]) {
  return moment.utc(time);
});

{{moment-calendar (moment-utc drawing.updated_at) locale='nl'}}

Reopen if this doesn't address your question.

Thanks, this works with:   return moment.utc(time).local();

It would be nice if this was a default, or configurable option. The helper with local() seems verbose for a common use case (displaying times in the local timezone).

Feel free to propose an API that you think would make it easier.  Happy to implement it.

{{moment-format-local time}}

I wouldn't want to combine the helpers like that.  But there is nothing stopping you from adding this helper within your own project if it's useful and saves typing over composition:
{{moment-format (local (utc dateTime))}} I would prefer this.


RGB values calculating incorrectly?

The plugin exports all RGB values as percentage. For example red (#ff0000) is expressed as
rgba(: rgba(100%,0%,0%,1.00);
I believe it should be something like:  rgba(: rgba(255,0,0,1.00);

🍻 Fixed in v1.3.3


4331 set academic cycles on create

Context
We need to set the academic cycles when trainees are created if we know the course details. This can happen from the create from hesa service or the create from apply service. Start and end academic cycles should be set from these services now.
Changes proposed in this pull request
Add parameter to the two services to assign start and end academic cycles for which there is a course.

 Set academic cycles on create


[Feature] Get Element Attributes without the whole Tree

Hi, thank you for the great package. Its very fast and the only one that works for me.
I would appreciate to have an opinion to have access to an element attributes without load the whole Tree.
In my case, I have a "root" tag with important attributes and all other tags is its Childs, so it will load the whole file on memory.
I will be happy to make a PR if with give some directions.

Hi, glad that it works for you.
have you tried the SkipElements right? not fitting your use case?
If not PR would be fine. This require a new function something like SkipAllElements which set a bool variable  and in the parse function instead of getting element tree it should call the existing skipElement function. Test case also needed for this new functionality.

See is my example above.
I have a 1Gb file with many "Cli" tags and I need the "Doc" tag attributes.
If I use like that: parser := xmlparser.NewXMLParser(bufio.NewReader(xml), "Doc" ,"Cli")  it will try to load the whole file.
Now i'm using this: parser := xmlparser.NewXMLParser(bufio.NewReader(xml), "Cli") and works perfect and very fast, but I need also the "Doc" attributes.
<?xml version="1.0" encoding="UTF-8"?>
<Doc COD="123456" DtBase="2019-06" DtGeracao="2019-08-13 08:43:22" PercDocProcess="97.30" Protocolo="183107896" VolPercProcess="99.99">
    <Cli Cd="987654321" CoobAss="0.00" CoobRec="0.00" IniRelactCli="1996-07-05" QtdIf="7" QtdOpManif="0" QtdOpJud="0" QtdOp="29" RespTotManif="0.00" RespTotJud="0.00" RiscoIndVendor="0.00" Tp="1">
        <Op Mod="0202" VincME="N">
            <Venc v110="1539.13" v120="1495.77" v130="1453.64" v140="4124.82" v150="6146.99" v160="11665.43" v165="8332.77" v170="5952.33" v175="4136.92"/>
        </Op>
        <Op Mod="0203" VincME="N">
            <Venc v220="652.00" v110="1180.68" v120="420.00" v130="323.22" v140="612.13"/>
        </Op>
        <Op Mod="0204" VincME="N">a
            <Venc v110="4120.03"/>
        </Op>
        <Op Mod="0210" VincME="N">
            <Venc v260="3424.56"/>
        </Op>
        <Op Mod="0213" VincME="N">
            <Venc v110="7.59" v130="3.71" v140="10.88" v150="20.81" v160="38.05" v165="33.77" v170="29.95" v175="26.60" v180="60.51"/>
        </Op>
        <Op Mod="0218" VincME="N">
            <Venc v110="173.65" v130="84.74" v140="249.23" v150="476.59" v160="872.00" v165="773.88" v170="686.75" v175="609.46" v180="1379.38" v255="1870.84" v260="76.59"/>
        </Op>
        <Op Mod="0299" VincME="N">
            <Venc v110="3041.08" v120="557.46" v130="1758.50" v140="5161.27" v150="9338.00" v160="17893.71" v165="15698.76" v170="10190.19" v175="8690.20" v180="19667.23"/>
        </Op>
        <Op Mod="0401" VincME="N">
            <Venc v220="186.75" v110="2037.26" v130="991.11" v140="2867.14" v150="5288.14" v160="8998.07" v165="3294.93" v230="591.18" v240="1027.72" v245="1027.72" v250="157.11"/>
        </Op>
        <Op Mod="0901" VincME="N">
            <Venc v220="2717.77" v110="3476.04" v120="2562.20" v130="2555.44" v140="7376.33" v150="14060.32" v160="25467.68" v165="22285.38" v170="19477.54" v175="17002.25" v180="81603.60" v190="17106.54" v210="4998.51" v230="2724.85"/>
        </Op>
        <Op Mod="1304" VincME="N">
            <Venc v110="42.22"/>
        </Op>
        <Op Mod="1901" VincME="N">
            <Venc v20="199.05"/>
        </Op>
    </Cli>
</Doc3046>

so to confirm 1 Doc tag and many Cli tags right in your file?
Then thats not possible I guess without loading all.  And also following  not working because it expects independent Cli and Doc tags.

parser := xmlparser.NewXMLParser(bufio.NewReader(xml), "Doc" ,"Cli")

As a workaround if you can just read the following doc line from the file and create a strings.NewReader and parse it seperately
<Doc COD="123456" DtBase="2019-06" DtGeracao="2019-08-13 08:43:22" PercDocProcess="97.30" Protocolo="183107896" VolPercProcess="99.99">

I mean not possible without reading the file twice otherwise you can parse first for Doc with skipping the Cli tags which will not load everything and then parse again for the Cli tags

so to confirm 1 Doc tag and many Cli tags right in your file?

Yes! Exactly this.
I was thinking in two options:

More elegant but breakthrough compatibility
a) Specify on NewXMLParser the tags of interest independent of the hierarchy
b) on stream loop, you have two functions: GetAttrib and GetChilds . On that moment the function getElementTree will run.
Less elegant but not breakthrough compatibility.
a) like SkipOuterElements, create a new function GetOuterAtrribs without run getElementTree.

Let me know if it make sense to you.

Hi,
you suggestions sounds good to me. For the first one how about implementing without breaking compability? For instance by default works as it is parsing the childs.  But if extra settings passed for each tag parse GetAttrib or GetChilds as you suggested.

I spent a couples of hours on it and it’s not that easy.
Loop through goroutine channels is very smart.
As implemented, the channel queue is push based on hierarchy and because of the buffer its not possible to lazy run the getElementTree.
So, I dont know how to do it.
Can you give me some ideas ?

Lets start with simple way, each tag can be flagged for attribute only parsing with new function something like ParseAttributesOnly(loopElements ...string)
Then when looping for each tag in here if the attribute only flag true it will add directly to the channel without getting element tree otherwise it will load the element tree as it is.
With this way I assume first it will parse the Doc with attributes only and then it will continue to Cli with childs and then lets see if it is breaking something.

Works great!  This is more like the second approach.
p := getparser("examples", "tag1").ParseAttributesOnly("examples")
What do you think?

All right maybe I didn't get your first idea completely but compatibility is required for me. Your changes looks good to me if the tests are passing. I added a minor comment. If you can also reflect this new feature in the README in a simple way that would be great.

Thanks for your prompt reply! :)


Steps to Reproduce:
Try to run and install on AMD GPU
Expected Behavior:
Should work normally
Actual Behavior:
Gives Nvidia error
Environment

GPU: AMD RX7800XT
CPU: Ryzen 5 5600X
OS: Windows 11

Reproduction Details
Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[ ] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.

Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots (if applicable):
[Attach any relevant screenshots to help illustrate the issue]
Installation Method
[Describe the method you used to install the project, e.g., manual installation, Docker, package manager, etc.]
Additional Information
[Include any additional details that may help in understanding and reproducing the issue. This could include specific configurations, error messages, or anything else relevant to the bug.]
Note
If the bug report is incomplete or does not follow the provided instructions, it may not be addressed. Please ensure that you have followed the steps outlined in the README.md and troubleshooting.md documents, and provide all necessary information for us to reproduce and address the issue. Thank you!

Our :ollama tagged images are only supported on Nvidia GPUs.

@justinh-rahb  Is there any other command I can use?

No official support for our container image. Ollama themselves do have a :rocm version, but we aren't using it as of right now.

Can we reopen this? Looking for AMD GPU support of the bundled image too

@kilrau, you should have a look at this:  https://dev.to/berk/running-ollama-and-open-webui-self-hosted-4ih5
To be clear, I never got this working on Windows, only a few days ago I switched to Arch Linux and that worked.


Smoke tests should test hiding/unhiding a workflow version

Is your feature request related to a problem? Please describe.
The smoke tests don't test hiding and unhiding a workflow version, so when we are testing a new deployment, we have to manually run that test.
Describe the solution you'd like
Add a test that hides and unhides a version.
Describe alternatives you've considered
Continue the painstaking, laborious process of manually testing the feature when we deploy a new release.
Additional context
We already have a smoke test for hiding and unhiding a tool version; should be easy to use as a base for workflows.
┆Issue is synchronized with this Jira Story
┆fixVersions: Dockstore 1.13
┆friendlyId: DOCK-2202
┆sprint: 93- Ursula
┆taskType: Story

Created this PR with some (hopefully) helpful comments https://github.com/dockstore/dockstore-ui2/pull/1601. Unfortunately it is unfinished.


Change link in Readme.md

In Readme.md
Replace this: hashirshoaeb/star_book with this: Blocship/star_book

Hi, I would like to work on this issue.

Hi, I would like to work on this issue.

Hey, I would love to work on this issue.


Fix when add new objects in existing json

We couldn't add any new object when we were using an editable.json as the state.
This check prevents the browser to crash if we add new elements on top of the json.
Example :

@AndrewPrifer I also added a security in the editor: "If an object is selected and we change the component and we sync the editor again, it will return an error" (in ProxyManager.tsx)


I added @agramfort! It should be run with ruff, but I don't know why it is not working, so I added an extra black hook for pre-commit.

Hi @agramfort,
I saw this mne PR 12261, and I changed here for ruff format, now we are using the ruff properly


filling in a number fails in chrome

When filling in a NUMBER as answer to the question fails (incorrect answer) in chrome on live site. (ss3.5.3)
On my mamp-server, it does work though.
I even tried to use older version like this, but no luck
"silverstripe/spamprotection": "~2.0.2",
"silverstripe/userforms": "3.1",
"silverstripe/mathspamprotection":"*",
Does anybody have a clue on how to fix this.?

It has never been a problem until now. I've got several clients who reported this issue. Has anybody had this too?

Perhaps this setting is off? https://github.com/silverstripe/silverstripe-mathspamprotection/blob/master/code/MathSpamProtectorField.php#L30

no, it's on and it's happening only in chrome.


[Test] add unit test for RedirectToPreferredLocaleListener

Hello,
Here is the addition of a new cover test with Prophecy.
Regards

Are we ok on returns?

Closing this for the same reasons explained in https://github.com/symfony/symfony-demo/pull/542#issuecomment-318288240  Let's wait a bit until we re-add these tests to the updated app. Thanks!


Bridge request for ...https://www.theguardian.com/uk

Bridge request

General information

Host URI for the bridge (https://www.theguardian.com/uk):

Which information would you like to see?
Full article including pictures

How should the information be displayed/formatted?
In paragraphs as per the original

Which of the following parameters do you expect?

[X] Title
[X] URI (link to the original article)
[ ] Author
[X] Timestamp
[X] Content (the content of the article)
[X] Enclosures (pictures, videos, etc...)
[X] Categories (categories, tags, etc...)

Options

[X] Limit number of returned items

Default limit: Unlimited

[ ] Load full articles

Cache articles (articles are stored in a local cache on first request): yes
Cache timeout (max = 24 hours): 24 hours

[X] Balance requests (RSS-Bridge uses cached versions to reduce bandwith usage)

Timeout (default = 5 minutes, max = 24 hours): 5 minutes

I see it has been pointed out that such a feed already exists, but...
Would it be an idea to add a generic 'pass through' bridge? So (should the client app/user want) they can go through rss-bridge which can just return an existing RSS feed (maybe  normalised in someway), but then also have the multiple output formats available? RSS/JSON etc?

Would it be an idea to add a generic 'pass through' bridge? So (should the client app/user want) they can go through rss-bridge which can just return an existing RSS feed (maybe normalised in someway), but then also have the multiple output formats available? RSS/JSON etc?

A format converter bridge. That would be a new feature, so a new issue.

This is supported, have a look at FeedExpander. Of course, full articles need to be parsed by normal means. You'll find quite a few examples in the bridges folder (simply search for FeedExpander).

FeedExpander looks pretty cool... in my own code I use the mercury parser  (previously 'readability') to extract the real content from a web page. FWIW I also have a filter to add an audio (text to speech) attachment to an RSS feed, a few tags for itunes etc... so every feed can become a podcast... I love RSS(!).


Image Analysis Lab Readme files are not sync with Azure.AI.Vision.ImageAnalysis 1.0.0-beta.1 sdk.

I tried to follow this - https://github.com/MicrosoftLearning/mslearn-ai-vision/blob/main/Instructions/Exercises/01-analyze-images.md, but the namespace 'Azure.AI.Vision.Common' not resolving with Azure.AI.Vision.ImageAnalysis 1.0.0-beta.1 sdk, and hence not able to complete the exercise.
Can you please update?

This has now been addressed to use beta.1


[z3 tracer] make the demo tool create charts

The charts are similar to Jupyter notebooks.
Code is (mostly) shared between the tool and the notebook(s).

z3 trace=true proof=true path/to/file.smt2
cargo run --release -p z3tracer -- --plot-all z3.log
# Creates several z3.log.*.png files

@wrwg We can discuss the details but as a start, I created an experimental feature report in the library z3tracer in order to expose useful reporting functions.


s3: set session token when using STS

This is useful when using federated tokens in AWS

Can you add a config option for this too please (see how the other ones are done in s3/s3.go) assuming that makes sense?  Or is it something that you'd always pass in an environment variable?
Can you update the docs docs/content/s3.md too please?

@ncw Thanks for the review. I had added it to the docs. Since STS tokens are temporary, they are usually not useful to be stored in config files. I have verified that the session_token can be passed as environment variable using the RCLONE_* env variables.

Super - thank you very much :-)


Astroport PCL pool

This PR improves transmuter handling and serves as a reference for Astroport adding their custom cosmwasm pool.
For now, Astroport's pool will only be included in router but not in pools query.
Their code ID will need to be added once they deploy their contract to mainnet.

Closing for now, and can reopen, but I think by January we'd like sidecar to support routing through cosmwasm pools via wasm execution. cc @p0mvn . In near term we'd like to deprecate our off chain TypeScript routing/simulation logic in favor of the sidecar implementation.


--advanced CL option not working

the --advanced CLI option does not bring any menu for selecting features.
The readme should be updated.

yo kibana-plugin --advanced

just produces the plugin structure.

I believe this happens because the addition of the command-line option was done after version 1.0.1 which is installed via npm. On the front page the readme is from master, which includes it.


add apollo-codgen gradle tasks

@martijnwalraven @felipecsl @sav007 please take a look.
It's a lot of text but I just wanted to keep those points for the record. Also please check the comments on the diff.
ApolloPlugin now performs the following actions:

Adds a dependency on gradle-node. This handles installing node nicely under .gradle and npm dependencies.

The Apollo plugin starts off by adding the node plugin. This creates 5 gradle tasks (3 npm, 2 yarn) under the node group. Those won't have to be used.

The Apollo plugin then creates an ApolloCodegenInstall task. This task basically executes npm install apollo-codgen and depends on nodeSetup task.

Adds an ApolloExtension to every sourceSet in the project. This essentially allows to have configurable options through the Gradle DSL. For example, let the user decide whether they want to have an Rx Observable returned, etc. Here, it's used to allow the user to define custom sourceSet directories.

For every variant in the android project, register an ApolloIRGenTask. This would execute apollo-codgen generate [...]. Variants can have multiple sourceSets so that's the reason for having a List of ApolloExtensions in each ApolloIRGenTask.

It also creates a top-level apolloIRGenTask which depends on the variant ones. Thus, running this will basically run the ones on all registered variants.
Thus for apollo-sample project, you'll end up with the following tasks:
Apollo tasks
------------
generateApolloClasses
generateApolloIR
generateDebugApolloClasses - Generate Android classes for Debug GraphQL queries
generateDebugApolloIR - Generate IR files using apollo-codgen for Debug GraphQL queries
generateReleaseApolloClasses - Generate Android classes for Release GraphQL queries
generateReleaseApolloIR - Generate IR files using apollo-codgen for Release GraphQL queries
installApolloCodegen - Runs npm install for apollo-codegen

Node tasks
----------
nodeSetup - Download and install a local node/npm version.
npmInstall - Install node packages from package.json.
npmSetup - Setup a specific version of npm to be used by the build.
yarn - Install node packages using Yarn.
yarnSetup - Setup a specific version of Yarn to be used by the build.

Running the snapshot jar.
For now, to run on the apollo-sample project:

Add the following under the apollo-sample gradle build script:

buildscript {
    // needed for apollo-compiler dependencies
    mavenCentral()
    jcenter()
    maven { url "https://jitpack.io" }
  repositories { flatDir name: 'libs', dirs: "../apollo-gradle-plugin/build/libs" }
}
  dependencies {
    classpath project(':apollo-compiler')
    classpath 'test-plugin:apollo-gradle-plugin:0.0.1-SNAPSHOT'
    classpath dep.gradleNodePlugin
}
apply plugin: 'com.apollostack.android'

Create a src/main/graphql/ folder with a schema.json and some .graphql query files. You can find some here. (Ensure that no naming conflicts exist in the files you're using from apollo-codgen)

Run ./gradlew apollo-sample:generateApolloIR. This has a dependency on the node install task so it should install all dependencies if they don't exist.

Discussion Points:
ApolloClassgenTask
I think we should add some sort of a Validator class that ships as part of the compiler that validates the JSON IR before attempting to generate the classes and handles exceptions nicely. This should be relatively simple since it would only validate JSON files. Open to discussions on that point.
Testing
We might need some integration tests once all the components are ready.
Closes #43

I don't think we need to validate the IR, but we may want to think about compatibility between apollo-codegen versions. On iOS we've added a check to make sure the runtime Apollo framework is compatible with the version of apollo-codegen installed. For now, we just rely on the major and minor version to be the same (so all patch versions are considered to be compatible).
We probably won't have to introduce backwards incompatible changes on Android as often, because we don't do the code generation from apollo-codegen, but there could still be cases where we make changes to the tool interface or IR.

@martijnwalraven Interesting. Since we'd be adding apollo-runtime as a dependency in apollo-gradle, we have more control over compatibility.
We can modify the NpmInstall task to install a particular version of apollo-codgen. That way, everything moves together.

@marwanad did you try to test it with apt? Maybe we need to update our sample project to use this plugin with apt, to see how it works?

@sav007 I haven't tried it with apt. I was leaving this part to the integration tests. But yeah I'll try it with apt and update the sample project or start writing integration tests as part of the gradle-plugin module.

@marwanad Maybe it better to make it as separate PR.

@sav007 @felipecsl addressed the comments above and allowed for a configurable schemaPath which led to some changes in how the lookup for files works, etc.
I left the comments here and this basically sums it up.
I feel that this should be good enough for the scope of this PR, we can add the integration tests and sample-app changes in another PR.

@marwanad sorry my PR was the first :)

@felipecsl any other comments/concerns?


use multi Font Family for multi language at same time just like css

Use case
Use multi Font Family for multi language at same time just like CSS.

Proposal
I have problem when I use some font family of different language, When I write in English English font become bad so I need some thing like CSS make me use font family for English and another font family for different language works together at same time

Hi @AbdallahR99
Can you please explain the proposal in more detail and give us some examples and use cases?
For the issue, you facing with font
Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample including google link for fonts
Thank you

Hi @AbdallahR99
Can you please explain the proposal in more detail and give us some examples and use cases?
For the issue, you facing with font
Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample including google link for fonts
Thank you

@TahaTesser
flutter doctor -v

[√] Flutter (Channel stable, 1.20.4, on Microsoft Windows [Version 10.0.19041.450], locale
ar-EG)
• Flutter version 1.20.4 at C:\flutter
• Framework revision fba99f6cf9 (10 days ago), 2020-09-14 15:32:52 -0700
• Engine revision d1bc06f032
• Dart version 2.9.2
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
• Android SDK at C:\Users\xGameR99\AppData\Local\Android\Sdk
• Platform android-30, build-tools 30.0.0
• ANDROID_HOME = C:\Users\xGameR99\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
! Some Android licenses not accepted.  To resolve this, run: flutter doctor
--android-licenses
[√] Android Studio (version 4.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 49.0.2
• Dart plugin version 193.7547
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] VS Code (version 1.49.1)
• VS Code at C:\Users\xGameR99\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.14.1
[!] Connected device
! No devices available
! Doctor found issues in 2 categorie

flutter run --verbose

[  +92 ms] executing: [C:\flutter/] git -c log.showSignature=false log -n 1
--pretty=format:%H
[  +60 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] fba99f6cf9a14512e461e3122c8ddfaa25394e89
[        ] executing: [C:\flutter/] git tag --contains HEAD
[ +169 ms] Exit code 0 from: git tag --contains HEAD
[  +15 ms] 1.20.4
[  +10 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +25 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [C:\flutter/] git ls-remote --get-url origin
[  +22 ms] Exit code 0 from: git ls-remote --get-url origin
[   +5 ms] https://github.com/flutter/flutter.git
[  +54 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref HEAD
[  +24 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[  +34 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping
update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping
update.
[   +4 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.[  +10 ms] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping
update.
[  +17 ms] executing: C:\Users\xGameR99\AppData\Local\Android\Sdk\platform-tools\adb.exe
devices -l
[  +27 ms] List of devices attached
[   +4 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping
update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +8 ms] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[  +38 ms] No supported devices connected.
[   +8 ms] "flutter run" took ١٣٨ms.
[  +17 ms]
#0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
#1      RunCommand.validateCommand
(package:flutter_tools/src/commands/run.dart:343:7)

#2      FlutterCommand.verifyThenRunCommand
(package:flutter_tools/src/runner/flutter_command.dart:836:11)

#3      FlutterCommand.run.
(package:flutter_tools/src/runner/flutter_command.dart:741:33)

#4      FlutterCommand.run.
(package:flutter_tools/src/runner/flutter_command.dart)
#5      AppContext.run.
(package:flutter_tools/src/base/context.dart:150:29)
#6      _rootRun (dart:async/zone.dart:1190:13)
#7      _CustomZone.run (dart:async/zone.dart:1093:19)
#8      _runZoned (dart:async/zone.dart:1630:10)
#9      runZoned (dart:async/zone.dart:1550:10)
#10     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#11     FlutterCommand.run
(package:flutter_tools/src/runner/flutter_command.dart:730:20)
#12     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#13     FlutterCommandRunner.runCommand.
(package:flutter_tools/src/runner/flutter_command_runner.dart:332:21)
#14     _rootRunUnary (dart:async/zone.dart:1198:47)
#15     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#16     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#17     Future._propagateToListeners.handleValueCallback
(dart:async/future_impl.dart:696:45)
#18     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#19     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#20     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#21     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#22     FlutterVersion.checkFlutterVersionFreshness
(package:flutter_tools/src/version.dart)
#23     _rootRunUnary (dart:async/zone.dart:1198:47)
#24     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#25     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#26     Future._propagateToListeners.handleValueCallback
(dart:async/future_impl.dart:696:45)
#27     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#28     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#29     Future._asyncCompleteWithValue.
(dart:async/future_impl.dart:567:7)
#30     _rootRun (dart:async/zone.dart:1190:13)
#31     _CustomZone.run (dart:async/zone.dart:1093:19)
#32     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#33     _CustomZone.bindCallbackGuarded.
(dart:async/zone.dart:1037:23)
#34     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#35     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#36     _runPendingImmediateCallback
(dart:isolate-patch/isolate_patch.dart:118:13)
#37     _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:169:5)
[ +284 ms] ensureAnalyticsSent: 253ms
[   +1 ms] Running shutdown hooks
[   +7 ms] Shutdown hooks complete
[        ] exiting with code 1

Hi @AbdallahR99
Can you please explain the proposal in more detail and give us some examples and use cases?
For the issue, can you please provide a complete reproducible minimal code sample including google link for fonts
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


DCAT : ModuleNotFoundError: No module named 'dcat.dcat_time_models'

Error when running this notebook : https://github.com/Health-RI/SeMPyRO/blob/main/docs/Usage_example_time_models.ipynb

References to dcat.dcat_time_models need to be changed to sempyro.time.dcat_time_models
Class Temporal is now called PeriodOfTime
Class GeneralDateTimeDescription has mandatory property hasTRS (see here). Would need to investigate what the correct range is for this.
Unfortunately time on our end to work on this is limited in the short-term but we're open to pull requests.

Thanks for the update. I will try and workout, how I can help you , by fixing this.

Thanks. It works now !!!


Spinning icon is not centered correctly

When an icon (in particular the spinner) is spinning, the center of the icon has an offset that makes the animation look wrong:

You can see a live demo here:
https://codesandbox.io/s/vigilant-dubinsky-ywl8q?file=/index.html
It is caused by this line:
https://github.com/thomas-lowry/figma-plugin-ds/blob/e1acbac7a56937b784b34366bcd7ca7386280253/src/styles/components/_icon.scss#L11
which I have no idea why it was introduced. Looks a strange declaration to me, probably should just be:
background-position: 50% 50%;

Do you think we can fix this? Happy to open a PR for this.

Just hit this one myself, if you don't feel like making a PR I will?

@taitems you can try but I can't see much activity on the repo, so I suspect it will not be picked up (that's why I didn't). if you want to try, more than happy (in that case I'll submit other PRs for other issues).

I just updated this! thank you for flagging.


SAK-48876 Lessons-Assignment: mainContentbug in spinner.js

The DOM within the iframe does not contain a "main" element (with id="content"). In such cases, the proposed fix returns the first element with class="portletBody".

This PR can be cancelled. Apparently, the fix for SAK-48901 will resolve SAK-48876 also.


vip host also needs principals (fix for #997)

FIX for #997
as we no longer store vip hosts in cluster.txt we need to tell keytabs.rb about the vip host explicitly

This change is required in upload_keytabs.rb as well.

Done


turns geonorm into an Eidos Finder

This gets rid of the use of .norms for geo-locations, simplifies EidosDocument, and makes some grammar rules and custom actions unnecessary.
I think these changes may also allow us to remove from EidosDocument:
var geolocs: Option[Array[Seq[GeoPhraseID]]] = None

But because that would also require some serialization changes, I have not tried to do that in this pull request.

@bethard: there is a build error here.

@MihaiSurdeanu Looks more like a Jenkins error to me, since the log shows that it never finishes checking the repository out. Not sure how to debug Jenkins. I don't seem to have access to river.

@kwalcock, @EgoLaparra: it seems Jenkins runs out of space:

This happens on the /partition because of an over enthusiastic use of the /var directory by the Jenkins docker:

Any ideas how to fix this?

It looks like the admin interface to Jenkins includes the ability to delete
things.  Some things could be deleted manually now in order to reclaim
space.  Perhaps there is a Configure option that helps this happen
automatically.  It was working until recently, so we might just have to
learn how it works and what maintenance it requires.
https://stackoverflow.com/questions/7995079/delete-a-jenkins-build-via-gui
On Mon, Jun 24, 2019 at 11:50 AM Mihai Surdeanu<EMAIL_ADDRESS>wrote:

@kwalcock https://github.com/kwalcock, @EgoLaparra
https://github.com/EgoLaparra: it seems Jenkins runs out of space:
[image: Screen Shot 2019-06-24 at 9 47 53 PM]
https://user-images.githubusercontent.com/1179342/60043888-d0f7bb80-96c9-11e9-9e0e-ad1133bf1c64.png
This happens on the /partition because of an over enthusiastic use of the
/var directory by the Jenkins docker:
[image: Uploading Screen Shot 2019-06-24 at 9.49.13 PM.png…]
Any ideas how to fix this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/610?email_source=notifications&email_token=ACCHCOXYRSD6I3QLZXUXP4DP4EJODA5CNFSM4H3AYSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYN3UYI#issuecomment-505133665,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCHCOTJ26PAVI6WBUWAKZTP4EJODANCNFSM4H3AYSIA
.

Maybe someone with admin privileges (e.g., @MihaiSurdeanu) can enable the "Discard Old Build plugin" https://github.com/jenkinsci/discard-old-build-plugin

I think that, for Multibranch Pipelines, this can be configured in Orphaned Item Strategy:
https://jenkins.io/doc/book/pipeline-as-code/#orphaned-item-strategy

There is at least enough room now to retest and it passed.

So does this approach look good? Should I go ahead and do the same thing for timenorm?

Ok. I will create a separate pull request for that, so @kwalcock can merge this one whenever he has time.

Thanks!  Separating geo and time seems like a good idea.

I like it, the design, staying out of the norms.  A few insignificant changes have been made.  That's really clever how you assigned to eidosDoc.geolocs before the sentenceBuffers were supplied with the phrases.  That it works surprised me.
      val sentenceBuffers = eidosDoc.sentences.map(_ => mutable.Buffer.empty[GeoPhraseID])
      eidosDoc.geolocs = Some(sentenceBuffers.map(_.toSeq))

I was wondering if we could get rid of EidosDocument.geolocs entirely, but since that would require a bunch of changes to serialization, I decided not to try in this pull request.

Yes, this sounds like a good plan. Maybe @kwalcock can tackle this?

As maybe implied above, does this mean that in the jsonld the Sentence.geolocs should be removed (https://github.com/clulab/eidos/wiki/JSON-LD#user-content-sentence)?
Alternatively and maybe more likely, it might just mean that EidosDocument.geolocs be kept more or less internal to the jsonld code.  It would not appear in EidosDocument but be reconstituted for serialization without changes to the output.
In the first case, when the jsonld changes, then in the state table (https://github.com/clulab/eidos/wiki/JSON-LD#user-content-statetype) instead of

State type
Value type
Notes

LocationExp
{@id(GeoLocation)}
This is an ID referring to a geographic location.

where a reference is made to a GeoLocation (https://github.com/clulab/eidos/wiki/JSON-LD#user-content-geolocation), the actual GeoLocation is used?
TimeNorm will probably need a similar change and it might be good to do both at once.
I also wonder whether it would be best to batch it up with other changes in the output for the migration events so that consumers don't have to sync up so often with our changes.

I was assuming JSON-LD would not change, you would just retrieve the geolocs directly, in the same way you retrieve any other TextBoundMention, rather than keeping an extra .geolocs attribute on EidosDocument.

Thanks.  "JSON-LD doesn't change" pretty much answers it.  When the serialization code gets ahold of the locations, I think they are already converted from TextBoundMentions to Location attachments.  This probably requires me to go back through all mentions and retrieve their attachments and group them based on their sentences, similarly to what you have done.  If for some reason they aren't there, because they were never used in an attachment of a surviving Mention, they wouldn't appear in the list with each sentence.  Is that correct, @BeckySharp?  I wonder if that would be a problem.  Debugging might be made more difficult.  A couple of classes use the locations in EidosDocument.  I wouldn't be surprised to see a couple of changes in the output.

yeah, I think that sounds about right... I know that @maxaalexeeva and @zupon are using them currently for their migration stuff, but I also think they have determined a likely alternate route (which may well be cleaner).  IDK what other classes use EidosDoc locations...?

Thanks!  It didn't occur to me to look at that branch.  I'll check it out just in case.

We use geolocs and Timex in the linkingMigrations branch. That hasn't been merged into migration_schema-zupon yet, but it will be soon.

It seems like it would be better to wait on removing EidosDocument.geolocs until at least the migration is ready so that not so many things are changing at the same time, creating moving targets, etc.  If more parts of Eidos than just the jsonld is wanting to use the locations, then the code might belong somewhere else that has not yet been identified.  I'll file an issue.  How's that?

Yes, definitely file an issue, and we can wait on this until it makes sense.

Sound like a good plan, thanks all!
On Thu, Jun 27, 2019 at 1:22 PM Steven Bethard<EMAIL_ADDRESS>wrote:

Yes, definitely file an issue, and we can wait on this until it makes
sense.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/610?email_source=notifications&email_token=ABJCPCO6BUKX6LLD3UOHUMTP4UOPXA5CNFSM4H3AYSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYILJQ#issuecomment-506496422,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJCPCKHXMWTYSYI3HGHW4TP4UOPXANCNFSM4H3AYSIA
.


Question about loading weights in demo.py

Hi Mr. Liu,
Thanks for sharing the implementation of DIM. I met an issue when loading the weights (trained in an 8 GPUs machine) in demo.py. Seems the checkpoint has several layers more than the model built, saying 'ValueError: You are trying to load a weight file containing 47 layers into a model with 33 layers.' Reaaly appreciate it if you please hint how to deal with this error.
Thanks

Found the problem, there's "import segnet" in train.py, but "import model" in demo.py. Seems another round of training is needed, lmao.


Code fix: DoNotPlaceRegionsWithinElements

Implement code fix for #56.

grabbed. The batch fixer screws this up too.


There should be a way to view the logs that bwa emits

Interaction with BWA is implemented using ExecutableRunner.
By default, all IO channels are set to PIPE:
https://github.com/fulcrumgenomics/prymer/blob/70f684086feb5f204e1f8fd659e7b7443cd4e845/prymer/util/executable_runner.py#L42-L44
BWA doesn't override any of them.
https://github.com/fulcrumgenomics/prymer/blob/70f684086feb5f204e1f8fd659e7b7443cd4e845/prymer/offtarget/bwa.py#L285
To interact with the PIPEs BWA will read and write to the private subprocess:
https://github.com/fulcrumgenomics/prymer/blob/70f684086feb5f204e1f8fd659e7b7443cd4e845/prymer/offtarget/bwa.py#L296
https://github.com/fulcrumgenomics/prymer/blob/70f684086feb5f204e1f8fd659e7b7443cd4e845/prymer/offtarget/bwa.py#L298
I think there is a small memory use bug here in that stderr will be written to a pipe that will never be read from. A buffer may be created and only increase in size. Regardless, I think that stderr should be redirected to a logging stream (perhaps with DEBUG level) so that a user has a way of reading them.
Originally raised in: https://github.com/fulcrumgenomics/prymer/pull/32#issuecomment-2362821429

Sister issue for Primer3:

https://github.com/fulcrumgenomics/prymer/issues/15


Question: nodeSelector for redis sub-chart

Hi everyone,
We have a deployment on a specific nodepool. Oauth2-proxy we can deploy with the recommended annotation from values.yml without problems to this pool. But I don't understand how to deploy redis-subchart to the specific node. We tried the following annotation without success.
'''
Enables and configure the automatic deployment of the redis subchart
redis:
provision an instance of the redis sub-chart
enabled: true
redisPort: 6380
replica:
replicaCount: 0
for own nodepool
Tolerations for pod assignment
Ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
tolerations:

key: "role"
operator: "Equal"
value: "mynodepool"
effect: "NoSchedule"

Node labels for pod assignment
Ref: https://kubernetes.io/docs/user-guide/node-selection/
nodeSelector:
role: "mynodepool"

'''
can anyone help us in this case ?
many thanks

At this moment, we use the Redis chart maintained by Bitnami.
Specifically, this version:
https://github.com/bitnami/charts/pull/11019
https://github.com/bitnami/charts/blob/d4dba2b393167d79b8c8f65b46c48b70ee3a9662/bitnami/redis/
According to the values.yaml file of this version (https://github.com/bitnami/charts/blob/d4dba2b393167d79b8c8f65b46c48b70ee3a9662/bitnami/redis/values.yaml) you have to use these parameters to add the annotations:
https://github.com/bitnami/charts/blob/d4dba2b393167d79b8c8f65b46c48b70ee3a9662/bitnami/redis/values.yaml#L40
If you want to use NodeSelectors and Tolerations instead:

Master
https://github.com/bitnami/charts/blob/d4dba2b393167d79b8c8f65b46c48b70ee3a9662/bitnami/redis/values.yaml#L342
https://github.com/bitnami/charts/blob/d4dba2b393167d79b8c8f65b46c48b70ee3a9662/bitnami/redis/values.yaml#L346

Replica
https://github.com/bitnami/charts/blob/d4dba2b393167d79b8c8f65b46c48b70ee3a9662/bitnami/redis/values.yaml#L724
https://github.com/bitnami/charts/blob/d4dba2b393167d79b8c8f65b46c48b70ee3a9662/bitnami/redis/values.yaml#L728

Thank you very much, problem solved.


[BUG] hardtime.nvim defaults cannot be removed in Nixvim

Field
Description

Plugin
hardtime

Nixpkgs
doesn't matter

Home Manager
doesn't matter

[x] I have read the FAQ and my bug is not listed there.

Description
Hardtime has default disabled keys (the arrow keys). To remove them (so allow them again), the user is supposed to pass an empty list (see https://github.com/m4xshen/hardtime.nvim/issues/20 for an example). But nixvim strips out the empty lists etc.
I think setting either/both "removeEmptyAttrValues" or "removeEmptyListEntries" when calling helpers.toLua in the module might be enough? (or rather, not using the default toLuaObject but toLua'?)
https://github.com/nix-community/nixvim/blob/main/plugins/utils/hardtime.nix#L236
Minimal, Reproducible Example (MRE)
programs.nixvim = {
  plugins.hardtime.disabledKeys = {
    "<Up>" = [];
  };
}

As a workaround for now, you should be able to set "<Up>".__raw = "{}".
I'd personally like to get rid of the "empties filtering" completely, across nixvim but that's challenging because a) we currently need it to remove undefined sub-options and b) some users may be relying on the behaviour in their own configs.

As a workaround for now, you should be able to set "<Up>".__raw = "{}".

Thanks, will try that!
Yeah I figured the filtering is some legacy thing which probably was a good idea at the start but now bites in the back ^^


Test rollback

Description
This PR should cover testing rollback execution with TestRollbackGateway contract.
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist

[ ] I have assigned this PR to myself
[ ] I have added at least 1 reviewer
[ ] I have added the relevant labels
[ ] I have updated the official documentation
[ ] I have added sufficient documentation in code

Testing

[ ] I have tested this code with the official test suite
[ ] I have tested this code manually

Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it

Like @oliverbundalo said. I would remove this isTestGateway flag from the deploy command, and just do everything in the test framework. Basically, you can do whatever in it. Once a bridge is deployed and started in test cluster, you can deploy a test gateway to it in the test cluster itself. Then, you can override the genesis file in the test cluster, to use that address of the test contract, instead of the actual that was deployed in the bridge deploy command. After you modify the genesis with the new address, you can start the blade cluster, and continue with the test.
You can use the WithTestRollback function to know when to do this logic in code in the test cluster.

Let me share my perspective on this topic, as it seems like the optimal way to approach the solution.

Ideally, the bridge deploy command should be extended to include the addresses for the internal and external gateway contracts. If the provided addresses are different from 0x0, in that case, it would not be necessary to deploy the gateway contracts. Instead, those addresses could be used for initializing other contracts and filling out the bridge configuration in the genesis.json file.

This would also mean that, within the test itself, it would be necessary to "manually" deploy custom implementations of the gateway contracts, save their addresses, and then pass those addresses to the bridge deploy command.

It appears (though this needs to be analyzed in more detail) that the L1 network should be launched separately (by running the bridge server command) and that the blade should initially be started without the bridge. Only at runtime, after the custom gateway contracts have been deployed, should the bridge deploy command be executed, enabling the bridge. A cluster restart may be necessary, but that remains to be seen...

Ideally, the bridge deploy command should be extended to include the addresses for the internal and external gateway contracts. If the provided addresses are different from 0x0, in that case, it would not be necessary to deploy the gateway contracts. Instead, those addresses could be used for initializing other contracts and filling out the bridge configuration in the genesis.json file.

I agree with this. We already had something similar with the stake token. But we have two cases here:

You have blade already running, as well as external chain. In this case, you would need to deploy manually your custom Gateway implementations to both chains, and then pass the addresses to the bridge deploy command.
You have external chain running, but blade is just being bootstrapped. This means you can not deploy your custom implementation of Gateway contract on blade, only to the external chain. In this case, we need to use the genesis predeploy command, but it needs to be changed to predeploy the custom contract on the address of the internal gateway contract that was generated by the bridge deploy command.

It appears (though this needs to be analyzed in more detail) that the L1 network should be launched separately (by running the bridge server command) and that the blade should initially be started without the bridge. Only at runtime, after the custom gateway contracts have been deployed, should the bridge deploy command be executed, enabling the bridge. A cluster restart may be necessary, but that remains to be seen...

This is too complicated and to hard for deployment. It makes the whole process of bootstrapping the blade with custom bridge contracts difficult in the second case I've mentioned. We need to exploit the genesis predeploy command for this.

Additionally, I believe this approach could have benefits even later in production (and not just in testing) because a future client may want to extend or modify the implementation of the gateway contract. With this approach, we provide them with that flexibility.

I agree.


Allow picking a different Nextcloud folder

I would like to use this app to show my existing image gallery I have stored in my Nextcloud, limiting the app to only use the /lespas folder seems needlessly restrictive.

agree. an option to customize home folder can be a useful feature. and
cosidering sharing to other Nextcloud user, this folder might need to be a group
filer too. all these are in the planned roadmap. but right now, i'm working on
integrating with Snapseed for photo editing. so stay tuned.
On dim., 27 déc. 2020 à 9:30 AM Robin Appelman a écrit :

I would like to use this app to show my existing image gallery I have stored in
my Nextcloud, limiting the app to only use the /lespas folder seems needlessly
restrictive.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
[https://github.com/scubajeff/lespas/issues/3], or unsubscribe
[https://github.com/notifications/unsubscribe-auth/AADP2MDB7GTM5RWZPBFJIBTSWYVNJANCNFSM4VKD2G2A]
.[https://github.com/notifications/beacon/AADP2MGAI4ODWVHAPPGT3E3SWYVNJA5CNFSM4VKD2G2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LRQJNWQ.gif]
[https://api.criptext.com/email/open/<1609032952099.890441%40criptext.com>]

Any updates to this feature?

This one is pretty outdate. By using some other APIs, Les Pas now support sharing albums within Nextcloud users and groups, and even offer feature like joint album for a group of users to edit simutaneously.
As for preference of home folder name, one can use symlink.

Hi @scubajeff! Actually I don't think you can use symlinks with Nextcloud,  all the threads I could find mentionned that it was disabled for security reasons..
Personnally I'm still waiting on this to try LesPas, as I have all my photos stored in other nested dirs that are already shared with different people (so that they can share theirs and see the others'). So unfortunately, using lespas dir or a symlink is not an option here for me :/

Same for me, I am waiting for this functionality to be implemented before I can use LesPas. Looking forward to it.

That's weird. In my testing environment, self-hosted Nextcloud 21.0.4 on Raspberry Pi 3B, I symlink Photos/ folder to lespas/nextcloud/ without any problems.
Can anybody give me some more hints of why symlink is not possible? No root access? Files in another partition?

are you using the external storage app?  I use that to define directories.
On Tue, Aug 31, 2021, 4:46 PM scubajeff @.***> wrote:

That's weird. In my testing environment, self-hosted Nextcloud 21.0.4 on
Raspberry Pi 3B, I symlink Photos/ folder to lespas/nextcloud/ without any
problems.
Can anybody give me some more hints of why symlink is not possible? No
root access? Files in another partition?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/scubajeff/lespas/issues/3#issuecomment-909735234, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AANUKZTL3RW4ZYVUILVAYH3T7VSUBANCNFSM4VKD2G2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

TBF I haven't personally tested symlinks, I only read that it wasn't (supposed to be ?) supported in the forums. I'll check when I have time how it behaves in my system :)

Hi @scubajeff , I am discovering Les pas and its

As they said, impossible is nothing. Although I'm still not convinced this is such a show stopper. And yes, it needs some careful and time consuming code refactoring.

I understand. if you don't have/see the interest, it's would be painfull to rewrite your app. But still, it was the second issue raised and the most discuted. Whatever you choose is fine tho.

For me, while symlinks are possible, I would like to keep the remote root folder as clean as possible. I looked at the code a bit, would making the lespas_base_folder_name a setting under the Storage category be enough? (no folder selector, just type the path). Or is it more complex than just doing that? (e.g. would it break sharing?)

This can not be a setting that user can change all the time, things like published album and sync might break.

Hello, the app looks really amazing but I'm in the same boat as many here, I don't think I will use it if I cannot select the target folder on my Nextcloud. I have already a Photos folder shared with other Nextcloud users as well as some album folders shared with external and it would be great if we can continue to use them without a complete migration and new sharing of links.
By the way is it intended for multiple users? If we are 2-3 to sync to a shared folder (let's say I share the folder "lespas" with another users on my Nextcloud, can he setup Les Pas and it will get photos from the shared folder already with the name "lespas"?

@ElucGeek Lespas manages three folders on server

DCIM/for backup of your phone's camera
lespas/ the place to store your albums
shared_with_me folder which actual name is specified in your NC config for all the share you get from other users
Lespas follows NC's rules to do sharing on server. NC dumps all your received shares in the same folder, and as you may already know, if you shared a file and then rename the file, the receiver will not see the name change. That why allowing app root folder name change is kind of tricky, especially in a multi-user environment.

Thanks for the details. Until now I have a photos folder shared with other users and they can edit any files, including names, within the folder and sub folder. Only the share name can be changed and is not reflected.
According to your answer, I guess Lespas is only a solution for single user environment. Too bad.
-------- Original Message --------
On Jun 5, 2022, 10:12, scubajeff wrote:

@.***(https://github.com/ElucGeek) Lespas manages three folders on server

DCIM/for backup of your phone's camera
lespas/ the place to store your albums
shared_with_me folder which actual name is specified in your NC config for all the share you get from other users
Lespas follows NC's rules to do sharing on server. NC dumps all your received shares in the same folder, and as you may already know, if you shared a file and then rename the file, the receiver will not see the name change. That why allowing app root folder name change is kind of tricky, especially in a multi-user environment.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Well, LesPas is far from perfect. It can't fit in all use cases. I can't say I feel bad if it doesn't work out for yours. Wish you every luck of finding a perfect alternative. Meanwhile, I'm sharing photos with my family in my not so multiuser environment, and I'm really enjoying it.

Well, LesPas is far from perfect. It can't fit in all use cases. I can't say I feel bad if it doesn't work out for yours. Wish you every luck of finding a perfect alternative. Meanwhile, I'm sharing photos with my family in my not so multiuser environment, and I'm really enjoying it.

I understand that you are making it work for your use case and I am sure a lot of other people find it very useful as well. It is just odd to me that you would hard-code the folder name and not just let the user set the path and then you go with that instead.
A third-party add-on requiring the user to change their data directory path instead of configuring the add-on  is just bad style IMO. Especially since the hard-coded path is not the default Nextcloud path for photos but add-on specific.
Having said that, although I will not use it myself dur to this issue I am very grateful for the work you have put into this. It looks great on the screenshots and fills a niche that is left open by the very lacking Nextcloud photo app.

@ruffson As you might notice, Lespas doesn't have any server end app (the reason is simply that I don't have skill on php). So all I can do is to strictly use file system folder structure to organize photos (though this happen to be one of my intents too) and follow NC api to do everything on server.
When it comes to sharing, NC dump every shares a user got to a single folder, so Lespas needs to find out those belongs to it among them. And the way to do this is by matching folder name. When user change the root folder to something else, NC won't populate the name change to those share receivers, and if user create a new share, that new share will carry the new root folder name. Now Lespas will have a hard time finding out which is which.
Tracking changes like this require a lot of change to the code base than merely adding a setting preference, and probably won't happen without a server end app.

Another obvious use case for being able to select the upload folder is when your Nextcloud uses external storage. I have my Nextcloud setup to use an Amazon S3 bucket as external storage and I want to backup my photos and videos to that. The actual server the Nextcloud s running on only has about 10GB free space, whereas the Amazon S3 bucket capacity is essentially unlimited.
Unfortunately it's another "me too" here.  I was excited to discover Les Pas, after being frustrated with the official Nextcloud app where photo sync doesn't work at all. But with no option to set the destination folder for uploads, I can't use it.

@madranet I see your review on google play too. Thank you for reporting here, since this is a much comfortable place to follow up issues. Your case sounds very reasonable. But I don't have any experience with external storage. Is it a mounted folder in your home folder, and you want lespas/ and DCIM/ sit in there?

@scubajeff   I must admit I don't have much experience of NextCloud's 'external storage' myself either. I only happen to have a NextCloud running as it comes bundled with a MIAB server I set up  and I only configured 'external storage' yesterday, to see if I could use my NextCloud as a conduit to backup my photos to Amazon S3 [trying to move all my 'stuff' off Google].
Assuming you're  an Admin on your NextCloud, look under 'Apps'  in the menu under your username...

And you'll find an option for 'External Storage Support'.  I had to enable it on my NextCloud setup. It wasn't enabled by default...

Once enabled in Apps, go back to your user settings and you'll see an 'External Storages' option...

There you'll find several options for types of external storage you can add...

Now you can spend many a happy hour trying to make sense of NextClouds piss-poor documentation to try and get it successfully configured [or was that just me?]...

When [if!] you eventually get it setup properly, the external storage [in my case Amazon S3] appears as another folder in the root of your NextCloud...

As I said above, I think this would be a pretty common use case for Les Pas / NextCloud. If you could enable us to choose our own destination folder on the NextCloud server. Many people run NextCloud instances on small servers or hardware such as Raspberry Pis, with limited storage, so availing of external storage is pretty much essential.

@madranet Are you using that folder just like the others? Do you need to enter credential when you access it? What's the path name of it? Is  'AmazonS3' a fixed default name or just so happen you created it like that? Can you change it after you created it?

Are you using that folder just like the others?

Well, I'm not using it at all at the moment, as I only created it with a view to backing up my Android photos to S3 but...

Do you need to enter credential when you access it?

No. The credentials are filled in on the setup dialogue [see above screengrab]  They're the two boxes just below where it says 'Legacy (V2) Authentication'.  In Amazon S£'s case with an Access Key and Secret Access Key.  Once connected. I can access the folder without having to fill in any credentials

What's the path name of it?

I get a URL of  <my iNextCloud domain>/index.php/apps/files/?dir=/AmazonS3

Is 'AmazonS3' a fixed default name or just so happen you created it like that?

That was the default name, but I could have changed it during setup. Again in the setup dialogue screenshot above, you can see it to the right of the green tick. I just left it as the default.

Can you rename it after you created it?

No. Which makes sense as I'm sure that would really mess up the syncronisation.
External Storage folder...

Normal folder...

This

/index.php/apps/files/?dir=/AmazonS3
makes me uncomfortable.

If you have root access to your nc instance, can you find out what is now in your home folder? Is that S3 storage being mounted there? Can you simply cd into it?

@madranet I read some documents on External Storage and from the screenshot you posted, there is a 'Folder Name' field in the external storage creation screen, can you help to confirm that there really is a folder named 'AmazonS3' in your home directory after you linked this external storage? And when you cd into it, you can list all the files you stored in it?

I can see the created directory when I browse my NextCloud through the web GUI or the NextCloud app. and interact with it like any other folder [except, as above, I can't move/rename or delete it].  However I can't even see that directory when I ls my  NextCloud files in a terminal...

So I don't know what that means.  Is NextCloud presenting it as a directory in the GUI but internally treating it as something else?.... or is the External Storage directory stored elsewhere than in my user folder?
I'm not familiar with NextCloud's directory structure to know where else to look and [as I said above] this NExtCloud instance came bundled with a MailInABox install. So it may not even follow a default layout.

If it's not in ls result list, that would make thing really complicated. File access needs to go through some fancy virtual file system of NC. I will do some math first, see if NC provides WebDAV access to it.

I added a SFTP external storage and confirmed that it can be read/updated with WebDAV just like the other folders. So setting up lespas's home folder and camera backup folder in external storage home folder CAN be done. I need some more time to check out the file sharing API compatibility, but pretty sure that it will work too.
So this is what to be expected in future version:
After authenticating lespas against NC server, a dialog will be shown for user to choose a folder from the server. The choice will be used as the base directory when lespas/ and DCIM/ will stay in. Once this choice has been made, user will have no way to change this location.

Sounds Good. I'll look forward to that.

Depends on the link speed to your external third party storage, it might be pretty slow for graphic app like lespas.

True, external storage tends to be less responsive

I added a SFTP external storage and confirmed that it can be read/updated with WebDAV just like the other folders. So setting up lespas's home folder and camera backup folder in external storage home folder CAN be done. I need some more time to check out the file sharing API compatibility, but pretty sure that it will work too as long as Enable sharing option has been ticked
So this is what to be expected in future version: After authenticating lespas against NC server, a dialog will be shown for user to choose a folder from the server. The choice will be used as the base directory when lespas/ and DCIM/ will stay in. Once this choice has been made, user will have no way to change this location.

Very happy this is finally happening. It's basically the only reason why I don't really use lespas.