MagIC GUI Locations table KeyError

Hey @moonshoes87, I've been debugging the new Python3 merged master branch and ran into a number of errors when running test_new_builder and test_magic_gui. I've solved most of these, but I can't seem to get rid of this error:
-I- Trying to propagate ['lithologies', 'geologic_classes'] columns from sites table into locations table
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/pandas/indexes/base.py", line 2134, in get_loc
    return self._engine.get_loc(key)
  File "pandas/index.pyx", line 132, in pandas.index.IndexEngine.get_loc (pandas/index.c:4433)
  File "pandas/index.pyx", line 154, in pandas.index.IndexEngine.get_loc (pandas/index.c:4279)
  File "pandas/src/hashtable_class_helper.pxi", line 732, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:13742)
  File "pandas/src/hashtable_class_helper.pxi", line 740, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:13696)
KeyError: 'lithologies'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "programs/magic_gui.py", line 290, in make_grid_frame
    'locations', 'sites')
  File "/home/kevin/Code/Paleomag/PmagPy/pmagpy/new_builder.py", line 733, in propagate_cols_up
    res = grouped.apply(func, col)
  File "/usr/local/lib/python3.4/dist-packages/pandas/core/groupby.py", line 694, in apply
    return self._python_apply_general(f)
  File "/usr/local/lib/python3.4/dist-packages/pandas/core/groupby.py", line 698, in _python_apply_general
    self.axis)
  File "/usr/local/lib/python3.4/dist-packages/pandas/core/groupby.py", line 1611, in apply
    res = f(group)
  File "/usr/local/lib/python3.4/dist-packages/pandas/core/groupby.py", line 685, in f
    return func(g, *args, **kwargs)
  File "/home/kevin/Code/Paleomag/PmagPy/pmagpy/new_builder.py", line 726, in func
    lst = group[col_name][group[col_name].notnull()].unique()
  File "/usr/local/lib/python3.4/dist-packages/pandas/core/frame.py", line 2059, in __getitem__
    return self._getitem_column(key)
  File "/usr/local/lib/python3.4/dist-packages/pandas/core/frame.py", line 2066, in _getitem_column
    return self._get_item_cache(key)
  File "/usr/local/lib/python3.4/dist-packages/pandas/core/generic.py", line 1386, in _get_item_cache
    values = self._data.get(item)
  File "/usr/local/lib/python3.4/dist-packages/pandas/core/internals.py", line 3543, in get
    loc = self.items.get_loc(item)
  File "/usr/local/lib/python3.4/dist-packages/pandas/indexes/base.py", line 2136, in get_loc
    return self._engine.get_loc(self._maybe_cast_indexer(key))
  File "pandas/index.pyx", line 132, in pandas.index.IndexEngine.get_loc (pandas/index.c:4433)
  File "pandas/index.pyx", line 154, in pandas.index.IndexEngine.get_loc (pandas/index.c:4279)
  File "pandas/src/hashtable_class_helper.pxi", line 732, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:13742)
  File "pandas/src/hashtable_class_helper.pxi", line 740, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:13696)
KeyError: 'lithologies'

Any thoughts?

I should be able to fix these tomorrow.  This is certainly related to changes I made recently and should be simple to handle.

On Apr 29, 2017, at 1:37 PM, Kevin Gaastra<EMAIL_ADDRESS>wrote:
Hey @moonshoes87 https://github.com/moonshoes87, I've been debugging the new Python3 merged master branch and ran into a number of errors when running test_new_builder and test_magic_gui. I've solved most of these, but I can't seem to get rid of this error:
-I- Trying to propagate ['lithologies', 'geologic_classes'] columns from sites table into locations table
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/pandas/indexes/base.py", line 2134, in get_loc
return self._engine.get_loc(key)
File "pandas/index.pyx", line 132, in pandas.index.IndexEngine.get_loc (pandas/index.c:4433)
File "pandas/index.pyx", line 154, in pandas.index.IndexEngine.get_loc (pandas/index.c:4279)
File "pandas/src/hashtable_class_helper.pxi", line 732, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:13742)
File "pandas/src/hashtable_class_helper.pxi", line 740, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:13696)
KeyError: 'lithologies'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "programs/magic_gui.py", line 290, in make_grid_frame
'locations', 'sites')
File "/home/kevin/Code/Paleomag/PmagPy/pmagpy/new_builder.py", line 733, in propagate_cols_up
res = grouped.apply(func, col)
File "/usr/local/lib/python3.4/dist-packages/pandas/core/groupby.py", line 694, in apply
return self._python_apply_general(f)
File "/usr/local/lib/python3.4/dist-packages/pandas/core/groupby.py", line 698, in _python_apply_general
self.axis)
File "/usr/local/lib/python3.4/dist-packages/pandas/core/groupby.py", line 1611, in apply
res = f(group)
File "/usr/local/lib/python3.4/dist-packages/pandas/core/groupby.py", line 685, in f
return func(g, *args, **kwargs)
File "/home/kevin/Code/Paleomag/PmagPy/pmagpy/new_builder.py", line 726, in func
lst = group[col_name][group[col_name].notnull()].unique()
File "/usr/local/lib/python3.4/dist-packages/pandas/core/frame.py", line 2059, in getitem
return self._getitem_column(key)
File "/usr/local/lib/python3.4/dist-packages/pandas/core/frame.py", line 2066, in _getitem_column
return self._get_item_cache(key)
File "/usr/local/lib/python3.4/dist-packages/pandas/core/generic.py", line 1386, in _get_item_cache
values = self._data.get(item)
File "/usr/local/lib/python3.4/dist-packages/pandas/core/internals.py", line 3543, in get
loc = self.items.get_loc(item)
File "/usr/local/lib/python3.4/dist-packages/pandas/indexes/base.py", line 2136, in get_loc
return self._engine.get_loc(self._maybe_cast_indexer(key))
File "pandas/index.pyx", line 132, in pandas.index.IndexEngine.get_loc (pandas/index.c:4433)
File "pandas/index.pyx", line 154, in pandas.index.IndexEngine.get_loc (pandas/index.c:4279)
File "pandas/src/hashtable_class_helper.pxi", line 732, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:13742)
File "pandas/src/hashtable_class_helper.pxi", line 740, in pandas.hashtable.PyObjectHashTable.get_item (pandas/hashtable.c:13696)
KeyError: 'lithologies'
Any thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/177, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwGInKU8BDJQjyqf6QuH_fkGOHja5Oqks5r059tgaJpZM4NMX_5.


Visual Studio Code - Project Manager: Fixes undefined property access when checking project tags.

Closes #264
Description

Fixed a bug when accessing project tags
Type of change

Bug fix / improvement for somebody else's extension. Extension author: @GH-handle

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I checked that extension's icon has size of 512x512

Interesting, it happens to me because my project config file did not have a tag property at all.

If I manually remove the tags line from a project in the config file, then there is an error.

Yeah, I didn't check for any other usage of the tag property and didn't debug it after my changes, so I missed this, sorry.

Maybe add something like accessoryTitle={tags?.join(", ")} to handle this scenario.

Done.

Are you also okay with this @MarkusLanger

Sorry, I'm not used to PR's, so I updated my main, which was the branch I made the changes, with upstream, so I just reset it back to the last commit I made. If there is anything wrong or if I need to change anything just let me know.
Again, sorry about that @pernielsentikaer.

See also PR #258

@rybertm We have enabled package.json linter, could you please look into the error and correct it (preferences now needs a label)


Proposal to override pubspec.yaml in flavor dedicated yaml

I propose the possibility to override the pubspec.yaml from a flavor yaml. (Something similar to dotenv files)
Some examples :
pubspec.yaml
pubspec_prod.yaml
pubspec_client_a.yaml
pubspec_client_b.yaml

Inside sub yaml file, we will have possibility to override pubspec properties like version, assets etc.
Pubspec flavor file should depend on the flutter flag '--flavor' or depend of a dedicated flag to manual specify a yaml.
Flavor file override the original one.

Hi @EArminjon, Thanks for filing the issue. I will leave this for the team members to decide.
cc: @christopherfujino

Poor man's version would be having a parameter for specifying custom pubspec file.

If we did implement this, I suspect we would want to go this route. pubspec.yaml is the first entrypoint for the tool parsing a project's config, so we would have no way of knowing where else to look, and I feel like a magic filename pattern (e.g. first search the working directory for /pubspec_[a-zA-Z_-]\.yaml/) is a bad idea.

so we would have no way of knowing where else to look, and I feel like a magic filename pattern (e.g. first search the working directory for /pubspec_[a-zA-Z_-]\.yaml/) is a bad idea.

Based on the flavor flag, something like ./pubspec_flavor.yaml is really bad ?

Android flavors work in the same Gradle file, not gradle_flavor
https://developer.android.com/studio/build/build-variants
android {
  buildTypes {...}

  flavorDimensions "api", "mode"
  productFlavors {
    demo {...}
    full {...}
    minApi24 {...}
    minApi23 {...}
    minApi21 {...}
  }
}


Suggestion: Allow command line option to specify how far to migrate

It would be nice to be able to specify a stopping point when migrating.  For instance, suppose we have 3 migrations.
0001.create_users
0002.add_profile_pic
0003.add_birthday
If none of them have been applied, we could apply just the first two like so:
dbmigrate -u <DATBASE_URL> -p <MIGRATION_FOLDER_PATH> up 0002

Similarly, if we had migrated all 3 and realized we wanted to roll back only the last one, we could do:
dbmigrate -u <DATBASE_URL> -p <MIGRATION_FOLDER_PATH> down 0002

IMHO, the selective rollback is something that really needs to exist before I'd want to use something like this in production.
What do you think?

sigh I just noticed the revert command line option.  That is functionally what I was asking for - the above would perhaps be nice syntactic sugar, but hardly necessary.
Sorry for the noise!


1.12 odd crash

OceanFloor-1.12-1.0.1
forge-1.12.2-<IP_ADDRESS>73-installer-win
It seems fine when I leave the config as is, but I don't just want a few small patches of clay and sand, but want a lot of sand in the oceans.  So I changed the config to:
I:clay_chance=65
I:clay_size=32
I:dirt_chance=30
I:dirt_size=18
I:sand_chance=85
I:sand_size=200

And it's crashing:
crash-2018-05-10_11.41.12-server.txt

Revisiting this and it's still crashing if I push the numbers too high.
I:sand_chance=128
I:sand_size=128
crash-2019-02-28_17.56.44-server.txt

Hey sorry i never checked this issue tracker ill be more frequent.  i never fixed it since because theres no one number that is a hard limit, just if its "too big" then some chunks sometimes overflow.
If size 32 crashes for some people then it wont crash for others so i kinda got stuck and walked away.  1.14 will be a whole new world though


Bug which adding a duplicate request does not throw the duplicate request message

It throws an exception in the logs

refer to #162


Added support for multithreaded decompression

hi. I merged your changes except updated ref to nokogiri. Thanks!.


initial support for custom root ca.

depends on pivotal-cf/go-pivnet#24
Pivotal has a lot of enterprise customers who have proxies which perform SSL re-encryption, which is like an authorized man-in-the-middle (MITM). Most companies do this to ensure their employees aren't downloading viruses, browsing illegal content, etc., so it's a common use case.
This was an easily solvable problem when the CLI had support for --skip-ssl-validation, but then created a new security risk. This PR adds a new flag in pivotal-cf/pivnet-cli, --root-ca, which allows for a customer to pass in their company's root CA, so the SSL connection is validated.
Signed-off-by: Mike Lloyd<EMAIL_ADDRESS>

This is related to https://github.com/pivotal-cf/go-pivnet/pull/24

blocked on https://github.com/pivotal-cf/go-pivnet/pull/24 being merged first


User roles are reset to AUTH_LDAP_SENTRY_ORGANIZATION_ROLE_TYPE after logout

Steps to reproduce

Configure Sentry 23.7.1 with this plugin
Set AUTH_LDAP_SENTRY_ORGANIZATION_ROLE_TYPE = 'member' in sentry.conf.py
Login with user A
Use a local admin account to assign user A the role owner
Logout with user A
Re-login with user A

Actual result
The role of user A is reset to member.
Expected result
The role of user A is kept as whatever has been assigned after initial creation.
Please let me know if you need any further information. Thanks for your continued maintenance of this integration.

Thanks for your feedback. I've understood this issue and found out how it occurred.
https://github.com/PMExtra/sentry-auth-ldap/blob/41fcbc0175edd53a3b2b32583eb34aea63213da0/sentry_auth_ldap/backend.py#L80-L93
Maybe we should add a precondition before line 85.
But I've been busy with my work recently. So, it's welcome for a pull request, or I will dig and fix it over the weekend.


Allow scales >1.001 in AffineCouplingTransform (fixes #49)

I've run unit tests. On my first attempt there was one failure (see below) which didn't seem relevant to this change, and I couldn't reproduce this on rerunning the tests (i.e. on trying the unit tests again they all passed)
FAIL: test_forward_inverse_are_consistent (transforms.nonlinearities_test.TestPiecewiseCDF) (transform=PiecewiseLinearCDF())
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dennis/git/nflows/tests/transforms/nonlinearities_test.py", line 63, in test_forward_inverse_are_consistent
    self.assert_forward_inverse_are_consistent(transform, inputs)
  File "/home/dennis/git/nflows/tests/transforms/transform_test.py", line 25, in assert_forward_inverse_are_consistent
    self.assertEqual(logabsdet, torch.zeros(inputs.shape[:1]))
AssertionError: The tensors are different!

----------------------------------------------------------------------

Thanks for the suggestions, I've tried to incorporate them into the new commits. Let me know what you think.

Yep, this look great to me, thanks a lot!


Envoy: demote initial fetch timeout warning

Revert #36032 as it did not resolve the issue with Envoy initial fetch timeout warnings. Demote those warnings in the inlined logs from the embedded cilium-envoy instead.
Start waiting for Envoy acknowledgements as soon as endpoints have regenerated, rather than only when the first request on the xDS stream has been received.
Note that any proxied DNS requests will not wait for acknowledgements if issued before endpoints have regenerated, and even if they did, the maximum delay for passing the DNS response to the source pod is shorter than the time span allowed for endpoint regeneration.
We could start serving xDS resources sooner if we computed policies for the regenerated endpoints first, after which we could start serving xDS resources to envoy. Then the endpoints could take the time to recompute their bpf programs etc.
Fixes: #36032
Fixes: #35984
Envoy "initial fetch timeout" warnings are now demoted to info level, as they are expected to happen
during Cilium Agent restart.

/test


User.findById only returns radiksType in attrs

When I do a findById on the User model I only get the radiksType in the attrs as shown below.

Where as if I do findOne it returns

An odd bug but should work both ways!

Ah my own fault.  the findByID works fine :)


finished webchat1998 ui

:white_check_mark: Build TimeHACK AppVeyor-65 completed (commit https://github.com/TimeHACKDevs/TimeHACK/commit/6bcc24e62b by @lempamo)


UPC: Add probe IP support for TiDB,PD,TiKV

Description
Add probe IP support for TiDB,PD,TiKV.
When set --host=<IP_ADDRESS> for TiDB, TiDB Dashboard cannot get the real IP, we should let TiDB probe and report its real IP.
Score

605

Mentor(s)

@Deardrops

Contact the mentors: #tidb-challenge-program channel in TiDB Community  Slack Workspace
Recommended Skills

Golang
Rust

Here is a complex problem that I can not find out which IP is "real IP" with many network interfaces.
Or just report every IP?

Here is a complex problem that I can not find out which IP is "real IP" with many network interfaces.
Or just report every IP?

@STRRL We deal with the simple case only:
Only one network interface and a unique real IP.
The complex problem you mentioned could not be handled.

I have a bad experience about this problem. It occurs in the self-written operating/monitoring system for my company.
This system pick up the first IPv4 address that not owned by loopback as node's IP.  It rarely bring the expected result. In the end, we take all IPs.
I think it might meet same problem.

@STRRL How about this way? https://stackoverflow.com/a/23558495
if an unexpected IP address returned, we could use the origin <IP_ADDRESS>.

How about this way? https://stackoverflow.com/a/23558495

I know how to fetch all IP of my machine. In fact, IPs from this way are sorted in a stable order.

if an unexpected IP address returned, we could use the origin <IP_ADDRESS>.

The problem is to found out the EXPECTED IP from IPs.
I suggest use all IP, do not contains any "pick one" logic.

@STRRL The demand of probe IP are:

Try to provide only 1 external IP if --host=<IP_ADDRESS>.

Because TiDB Dashboard need know the IP of every components (TiDB, TiKV, PD), display IP + port as its name in UI, also, Dashboard back-end server uses the IP to send request to specific components. We do not use all IPs here because both in UI and backend-server, 1 IP indicates 1 component is enough.

Otherwise, use the --host=<IP_ADDRESS> parameter as probe IP.
If these are multiple network interface, pick the expected one from them is not an easy task. So for simplify this task, we do not deal with this case.

@Deardrops Can not help me to check the logic?

if --host is not setted by <IP_ADDRESS>, report this parameter
if there is ONLY ONE valid IPv4 address( no loopback ), report this IP.
elsewise fallback to <IP_ADDRESS>

@STRRL Right. But one more thing, TiDB has a parameter --advertise-address to indicates its external IP, so the logic should be:

if --advertise-address is not empty, report this advertise-address.
if --host is set to <IP_ADDRESS>, but --advertise-address is empty, there is ONLY ONE valid IPv4 address(no loopback), report this IP.
elsewise fallback to <IP_ADDRESS>

@Deardrops Thanks! I will pick up this issue after earning enough score. LOL

/pick-up-challenge

/pick-up-challenge

We now have ways to assign IP directly in our deployment tools. I'm going to close this issue.


Replace HPU with external implementation

What does this PR do?
The HPU Strategy moves to an external repo where it will be maintained: https://github.com/Lightning-AI/lightning-Habana/pull/1. A corresponding package was published to PyPi from which users can install the integration.

[x] Replaces the implementation with the one in the lightning-habana package.
[x] Registeres the accelerate="hpu" as a strategy if the package is installed
[x] Produces an error message if you request the strategy but don't have the package installed

Before:
trainer = Trainer(accelerator="hpu")

# OR

from lightning.pytorch.accelartors import HPUAccelerator
trainer = Trainer(strategy=HPUAccelerator(...))

Now:
pip install lightning-habana

trainer = Trainer(accelerator="hpu")  # only works if  `lightning-habana` is installed.

# OR

from lightning_habana import AcceleratorHPU
trainer = Trainer(strategy=AcceleratorHPU(...))

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @borda @justusschock @awaelchli

Why is this error now suddenly showing up:

Should not import standalone package, all imports should be redirected to the unified package

😠

Why is this error now suddenly showing up:

Should not import standalone package, all imports should be redirected to the unified package

good question and it shall be already appearing with #16921

The strange error only seems to occur in this group of tests 🤔
Test PyTorch / pl-cpu (macOS-11, pytorch, 3.8, 1.13)
Test PyTorch / pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)
Test PyTorch / pl-cpu (windows-2022, pytorch, 3.8, 1.13)

Which is anything outside the lightning meta package. I think it might be because the lightning-habana repo does not support importing things from pytorch_lightning, only from lightning. Fixing this is beyond my skills.

Which is anything outside the lightning meta package. I think it might be because the lightning-habana repo does not support importing things from pytorch_lightning, only from lightning. Fixing this is beyond my skills.

addressing it in afa0b92bd09669f7f659ccefd0699af9fdaa112f

some of the failures above are addresses in #17170

Is this meant to be in the 2.0.1 release?


Unable to import swiper module from script.js

Hello,
I am unable to import swiper from script.js or from a subfile in folder like import Swiper, { Pagination } from 'swiper' webpack error says Can't resolve 'swiper' in [wordpress_path]/src/js/modules and i don't find any ways of debug this issue.
How can i make webpack not care about node_modules being outside of src folder ? i guess this is why ?
Thank you for your time and great work !

Ok it seems that it is a Swiper issue. I close the issue


Use buttons for Log in and Sign up

Use the button tag for login and sign up, it will enhance the site.

please add label1 or label2 ..


Ethan: Watch thetopbestblogger.com

Ethan requests the watch of the watch_keyword thetopbestblogger\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

thetopbestblogger\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Bottom part is not scrollable or clickable

I guess it's related to this fix #129 but now when I want to scroll up/down I can't do it in the bottom part where's the overlay. Also, if an time slot is positioned in that area, I can't tap on it to edit.
Bottom fade/overlay shouldn't disturb gestures.

'Add' button works, just in case mention that.


Message passing neural network determinism thwarted by tf.math.segment_sum and tf.gather

Hi @duncanriach,
First of all, thank you for the in depth overview of randomness on GPU and your work in improving them.
I am unfortunately unable to provide code for my issue but I was hoping to see what ideas you could possibly have.
Setup: Running tensorflow 2.2.0 with TF estimators on g4dn AWS instances. Not using keras models (although we do use tf.keras.regularizers.l2), but mostly tf.compat.v1.layers.dense and tf.matmul, tf.math.segment_sum. I am using a MPNN model if that helps haha. I set os.environ['TF_DETERMINISTIC_OPS'] = '1' as you suggest. I also have np.random.seed and tf.estimator.RunConfig(tf_random_seed) set.
What I've tried: Running it 3 times each on CPU for 5 epochs with 0.001 learning rate, on GPU for 5 epochs with 0.001, 0.0001, 0.00001 learning rate.
What I've found: All 3 runs on CPU are the same. All 3 runs on GPU are different, except 0.001 learning rate diverges much faster than 0.0001 which diverges much faster than 0.00001 learning rate. You can see the results here:

I don't expect GPU to be fully deterministic, but in order to compare changes to my models/featurizations, the amount of variation for 0.001 learning on GPU is far too much. The variance for 0.00001 learning rate is very acceptable, and I was wondering if you have any ideas on what is causing this and how to mitigate this. Since CPU is fully deterministic, I would expect this to be purely a GPU issue. Does that seem correct?

Thanks for the appreciation, @dangthatsright.
Without being able to run your code, it's impossible to provide a definitive answer. However, if you're seeing prefect (bit-exact) reproducibility when running on a CPU but not when running on a GPU then it suggests that there is an op that is running on the GPU that is injecting non-determinism. More specifically, it suggests that (a) your trainable variables are being initialized reproducibly (i.e. before training they match between runs), that (b) your pseudorandom number generators are being reproducibly reset (seeded), and that (c) there is not some other non-GPU source of non-determinism involved.
One reason for a larger learning rate leading to more divergence could be that the difference between runs at each step is being amplified, increasing the chance of a divergence in the high-level path taken through the optimization space.
Regarding, "I don't expect GPU to be fully deterministic": it should be possible for the operation on the GPU to be perfectly (bit-exact) reproducible, and we've achieved, and witnessed, this for many models. You probably have one op that is injecting non-determinism either in the forward or backward direction and it's likely an op for which deterministic functionality has not yet been provided.
In the list of ops you mentioned, the one that stands out to me is tf.math.segment_sum. We have confirmed that tf.math.unsorted_segment_sum operates nondeterministically (in the forward direction) and this is now reported in Confirmed Current GPU-Specific Sources of Non-Determinism (With Solutions). I'm almost certain that both the sorted and unsorted versions rely on the same underlying nondeterministic CUDA kernels (segment_reduction_ops.h and segment_reduction_ops_gpu.cu.cc).
For the next step, please will you run your system with the tf.math.segement_sum only on CPU and confirm that you get deterministic functionality, as follows:
with tf.device("/cpu:0"):
  sum = tf.math.segment_sum(data, segment_ids)

Update: I just confirmed that tf.math.segment_sum does indeed currently inject nondeterminism in the forward direction when running on a GPU.

Thank you for the suggestion! That helped but it didn't fix it completely. I am currently in process of finding the other sources of non determinism in my dataset and estimator spec functions. I'll let you know which functions are cause in case they aren't documented already!

Cool. Thank you.

You might want to double-check that the sum of all of your trainable variables is exactly the same before starting training, on each run. Also, make sure that an ops that use PRNGs and take seed parameters have those seed parameters set.

Here's the update, I thought it might have been some dataset map issues (from your guide) but it seemed like those were actually fine. I also thought that it had something to do with the estimator spec since removing the with cpu stuff makes not deterministic.
Between the final layer and the backprop is the loss function which uses tensorflow.python.ops.math_ops.to_float and squared_difference and tensorflow.python.ops.losses.losses_impl.compute_weighted_loss. This is good, I thought the bug would be in here. Unfortunately wrapping this loss_op didn't seem to work.
Instead I had to wrap
with tf.device("/cpu:0"):
         with tf.control_dependencies(update_ops):
                minimize_op = optimizer.minimize(
                    loss_op, global_step=tf.compat.v1.train.get_global_step()
                )

which allowed it to work. This makes me think that the backprop itself is not deterministic? Is this possible? I haven't seen anything with this except for something about cross entropy loss but I am just using a mean squared error loss.
Additionally, when I am adding the with cpu device, I notice a pretty good slowdown. Which makes sense because you have to copy stuff back and forth between gpu and cpu.
Unfortunately for my model I ran into
2020-07-24 02:04:17.789852: W ./tensorflow/core/common_runtime/gpu/gpu_host_allocator.h:44] could not allocate pinned host memory of size:<PHONE_NUMBER>
^C^C2020-07-24 02:04:19.582345: W tensorflow/core/framework/op_kernel.cc:1753] OP_REQUIRES failed at cwise_ops_common.cc:82 : Resource exhausted: OOM when allocating tensor with shape[4060,166,166] and type float on /job:localhost/replica:0/task:0/device:CPU:0 by allocator cpu

which seems like I ran out of RAM. This is suboptimal but I can switch to a larger instance - is there a general way you suggest I be using these with cpu without harming performance (memory and training time) that much?
I appreciate any thoughts you may have!

In most cases, nondeterminism is injected by an op's backward path (because backprop tends to involve large reductions). tf.math.segment_sum, discussed above, is an unusual case where the nondeterminism is injected in the forward path. So if you're using another op that is injecting nondeterminism, then it's most likely to be doing that as part of the backprop calculations.
At least half of the DL compute is in the backprop, which is why running all the backprop on the CPU will slow the training down a lot. Also, backprop requires the presence of the forward activations (forward outputs) to calculate the back-propagated gradients (as well as the intermediate gradient values themselves), so it does tend to put an extra load on a memory compared with just the forward path. With the copying (duplication) between CPU and GPU memory, the overall memory footprint would likely also be even larger.
minimize both calculates the gradients and then also applies them to the trainable variables. It's possible to split minimize into compute_gradients followed by apply_gradients and hopefully you will find that you only need to run the compute_gradients on the CPU to get bit-exact reproducibility. That will rule out nondeterminism in the gradient application (which is unlikely in any case).
The nondeterminism debug tool, which I have not yet gotten time to release publicly, can be inserted into the path of grads_and_vars between compute_gradients (running on GPU) and apply_gradients (also running on the GPU) to isolate the op who's GPU backprop kernel is injecting the nondeterminism. If you were able to provide me with easy-to-use repro code then I would use to the tool on it, limited time permitting.
For now, I would like you to try setting (one-by-one) the following parameters on minimize or compute_gradients (whichever you're using) while running everything except segment_sum on GPU to see if they happen to resolve the issue: gate_gradients=GATE_GRAPH, aggregation_method=tf.AggregationMethod.EXPERIMENTAL_TREE, colocate_gradients_with_ops=True

Thank you so much for all your help. Unfortunately, it would probably take me quite a while to condense the code but even then it would quite a headache because of the tf.estimator archetype. Alas, thanks to your hints, I was able to figure it out!
There was one tf.gather that I didn't wrap with cpu device originally. Since things worked without wrapping tf.gather with cpu and using cpu for the backwards pass, it makes me believe that tf.gather is non deterministic on the backward pass/ gradient computation but not the forward pass (or could be both and I got lucky?) (Also kinda strange that tf.gather uses non deterministic operations, haha), therefore setting colocate_gradients_with_ops=True did it! Unfortunately, it still slows down the code by quite a bit.
Edit to above: I realized you linked this issue and the very first thing they mention is that tf.gather is non deterministic during backprop, I am a fool!
Note it may also be that segment_sum is also non deterministic in the backwards pass.
One last question if you don't mind: If I have an op that uses cpu, then a couple ops then another op that uses cpu, is this better or worse than wrapping all those ops with cpu? I'm guessing this is a tradeoff between the speed of the op on cpu vs gpu and the time it takes to copy the memory?
Thanks again for the help on this non deterministic ride. Having learned a lot more about how tensorflow works and how to debug non determinism, I appreciate your work even more!
Also, some hints for others who are debugging non deterministic issues:
Edit:
0. Do your research and read Github issues thoroughly before you begin

After you change something, always run it twice because the deterministic process changed. I spent a long while thinking something was still non deterministic when in fact it was because it differed from the established non deterministic model.
Always look at all significant digits. Usually it's the 8th or 9th digit that is different. (I was looking at metrics cause it's a bit annoying with graph mode and tf.estimator)
Confirm that CPU is deterministic. Then set the minimize op to cpu only, before binary searching your code for the non deterministic forward pass. Then hopefully setting the minimize op to gpu just works, otherwise try the colocating gradients.

Great that you got it working! So happy for you.
Could you give me your first and last name so that I can add it to the credits? (or I can add your handle if you prefer). It would also be great to know what company you represent (if any) so that I can add it to my list.
Regarding tf.gather: its backprop nondeterminism is actually already reported here in the main README.md. I'm now considering moving the names of those dependent ops up into the main tables. Those tables should be compact and comprehensive in terms of GPU-nondeterministic ops.
Regarding potential segment_sum nondeterminism in the backward direction: I've made a note to double check for that. I think it's very unlikely though.
Regarding mix-and-match of ops between CPU and GPU: you're correct about the trade-off. The question can only be answered for a specific case by comparing run-times each way.

Thanks again for the help on this non deterministic ride. Having learned a lot more about how tensorflow works and how to debug non determinism, I appreciate your work even more!

You're welcome. It's been fun.
Regarding your hints/tips: these are all very useful. I intend to add a guide for getting-your-model-to-deterministic at the top of the main README.md. I may include some or all of your tips to that.
Closing.

Haha great title change!
Sure, my name is Hao Shen and I'm working at Reverie Labs.
I've also found that you can use the trick from the issue above (https://github.com/tensorflow/tensorflow/issues/39751) to wrap tf.segment_sum calls to get deterministic behavior with GPU. This led to comparable performance as the non deterministic version before!

Excellent. Thank you, @dangthatsright. I added your name to the credits.
Thanks for adding more info to TF issue 39751. I'm going to look into developing a framework-determinism patch and/or a temporary upstream solution.

Hey @dangthatsright, I think that this comment on issue 39751 may answer your question. Note also that stock TF 2.7 will likely have fully-deterministic segment reduction ops, assuming that the rollback of PR 51392 get resolved.


Landing page layout change

Description
Change landing page layout to better match used by Aura Console and allow for some copy that describes what the toolbox does.  Tests / github workflow updated to reflect the changes.
Complexity
Complexity: Low
It's mostly UI changes with some CSS change
Issue
Closes:  N/A
Checklist
The following requirements should have been met (depending on the changes in the branch):

[ ] Documentation has been updated
[ ] Tests have been updated
[ ] New files have copyright header
[ ] CLA (https://neo4j.com/developer/cla/) has been signed

Made some changes to the Neo4j GraphQL Toolbox? Or made some changes to the core library perhaps?
Check out your changes at https://neo4j-graphql-toolbox-197.surge.sh
Use for instance a local dbms hosted on Neo4j Desktop or a cloud-hosted Aura Free dbms.

omg , another eslint issue.  Closing & re-submitting.


Add /shard command to switch between shards

Excellent! Does console output already coalesce all shards into the same stream?

Yes, if you're connected to a server you get all output for all shards on that server. A console event is emitted separately for each shard with the shard name in event.data.shard. We just need to be able to select where to send the input.


Set hvac mode in presets (such as away)

How can the hvac mode be set in a preset mode? For example, I'd like to set the thermostat to off when in away mode. Thanks!

The off-state and the preset modes are independent, meaning that turning the thermostat off requires the same effort as setting it to away mode.

The use case is as follows:

Thermostat changes are triggered by automation (mostly time-based)
When in away mode, a script toggles them to regular mode, sets the desired params, and toggles back to away mode.
When back in normal mode, the thermostats are all configured correctly (based on the automation)

In away mode, I generally want the device to be off. For stand-alone heat or cool devices, that can be mimicked by setting the temp arbitrarily high or low. The issue is in heat/cool mode because they are always a range and setting the temps to extremes is likely to trigger the "other" mode (i.e. a/c in the winter, heat in the summer).
Sorry if this is a bit long, happy to clarify if needed.

I mean that instead of setting it to away mode with automation, you could just turn it off completely with automation.

Right, but that doesn't lend itself to easily being turned back on when returning from away

Can this functionality be added?

@mbrevda It cannot. You can do this with automation.

It cannot

Do you mind elaborating on the issue?

You can do this with automation.

AFAIK, automation cannot keep state. Meaning when the state is no longer away, there is no way to know what to set the state to in an automation

I assume you manually set the preset mode to away or use automation.
You can turn the thermostat off with the same effort. If you prefer to use away mode, set up the away preset to a target that ensures no activity.


Temporarily skipping a couple of tests to work around Url encoder bug

https://github.com/aspnet/HttpAbstractions/issues/231
@GrabYourPitchforks

Talked with @GrabYourPitchforks on this PR and @GrabYourPitchforks is okay to do this.


backup support for SQL2022 with DDBoost EMC agent <IP_ADDRESS>

Description of the issue
DDBoost backup failed for SQL2022 via the Ola backup script.
The direct call to dbo.emc_run_backup for SQL DB backup is running fine from the SQLAgent.
I am wondering if the Ola's script has been tested against the EMCAgent <IP_ADDRESS> on window 2019/SQL2022?
SQL Server version and edition
Microsoft SQL Server 2022 (RTM-CU5) (KB5026806) - 16.0.4045.3 (X64)   May 26 2023 12:52:08   Copyright (C) 2022 Microsoft Corporation  Developer Edition (64-bit) on Windows Server 2019 Datacenter 10.0  (Build 17763: ) (Hypervisor)
Version of the script
Check the header of the stored procedure
/*
SQL Server Maintenance Solution - SQL Server 2008, SQL Server 2008 R2, SQL Server 2012, SQL Server 2014, SQL Server 2016, SQL Server 2017, SQL Server 2019, and SQL Server 2022
Backup: https://ola.hallengren.com/sql-server-backup.html
Integrity Check: https://ola.hallengren.com/sql-server-integrity-check.html
Index and Statistics Maintenance: https://ola.hallengren.com/sql-server-index-and-statistics-maintenance.html
License: https://ola.hallengren.com/license.html
GitHub: https://github.com/olahallengren/sql-server-maintenance-solution
Version: 2022-12-03 17:23:44
You can contact me by e-mail at<EMAIL_ADDRESS>Ola Hallengren
https://ola.hallengren.com
*/
**What co
What command are you executing?
EXECUTE [dbo].[DatabaseBackup]
@Databases = 'SYSTEM_DATABASES'
,@BackupType = 'FULL'
,@CheckSum = 'Y'
,@BackupSoftware = 'DATA_DOMAIN_BOOST'
,@DataDomainBoostHost =
,@DataDomainBoostUser =
,@DataDomainBoostDevicePath =
,@DataDomainBoostLockboxPath =
,@CleanupTime = 48
,@LogToTable = 'Y';
What output are you getting?
Msg 50000, Sev 16, State 1, Line 1 : Error performing Data Domain Boost backup. [SQLSTATE 42000]
Msg 0, Sev 16, State 1:  [SQLSTATE 01000]
Outcome: Failed [SQLSTATE 01000]

User error due to typo


Late binding of type

Is it somehow possible to do a late binding of socket? For example when having server and client code in one expert.
As example this does not work:
Context context("myContext");
Socket socket(context,ZMQ_REQ);
void OnInit(){
      if(isServer)
            socket = Socket(context,ZMQ_REP);
...
}

Maybe you can use a global pointer to store the socket?

Yes sure but if I want to decide on the type of socket based on EA settings (isServer) it requires late binding :-)

I think I didn't make myself clear.
Context context("myContext");
Socket *socket;
void OnInit(){
      if(isServer)
            socket = new Socket(context,ZMQ_REP);
            // server init
      else
           // client init
...
}

This way, you can create either a server or client based on EA settings.


Automated cherry pick of #2387: fix: cloud-provider-region add cloudaccount_domain_id

Cherry pick of #2387 on release/2.12.
#2387: fix: cloud-provider-region add cloudaccount_domain_id

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@9dd2245). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #2390   +/-   ##
==============================================
  Coverage                ?   7.08%
==============================================
  Files                   ?     454
  Lines                   ?   71603
  Branches                ?       0
==============================================
  Hits                    ?    5075
  Misses                  ?   66111
  Partials                ?     417

Flag
Coverage Δ

#aFlag
7.08% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/snapshots.go
1.88% <ø> (ø)

pkg/cloudcommon/db/fetch.go
0% <0%> (ø)

pkg/compute/models/cloudproviderregions.go
0.38% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd2245...62f72e8. Read the comment docs.

/approve
/lgtm


Ensure sqlcmd query doesn't return error after sqlcmd start

Right now sqlcmd start does not block waiting for SQL Server to be running and ready for client connections.
So if sqlcmd  query is immediately run, it will fail with:
C:\src\go-sqlcmd\cmd\modern>sqlcmd query
EOF
Error: EOF

We either need to make sqlcmd start have a blocking option so it doesn't return until SQL is ready for connections, or sqlcmd query and sqlcmd open ads etc. all block waiting for connection to succeed (up to timeout)
As part of testing, I have tried blocking sqlcmd start until the errorlog prints "recovery complete" which is the last entry in a normal successful start up, and sqlcmd query still fails with the above error message for a few seconds.

Can we have 'sqlcmd status' command which attempts to establish connection and returns if sql server is ready to accept connection or not?
That way even applications can use this command to check sql server status and then decide accordingly whether to execute their workload or not.

the answer to the question "is sql server available" is only valid at the point in time you ask it. It could go down a second later.
I'd expect the connection timeout to be a value of the config entry for a connection with our typical default of 30 seconds.


Handling dynamic version codes for ABI-specific APKs

When different APKs are generated for each ABIs, these must have different version codes in order to be published to the Play Store as multiple APKs for a single application.
With the previous DSL, this could be easily accomplished using such task:
// map for the version code
project.ext.versionCodes = ['armeabi': 1, 'armeabi-v7a': 2, 'arm64-v8a': 3, 'mips': 5, 'mips64': 6, 'x86': 8, 'x86_64': 9]

android.applicationVariants.all { variant ->
    // assign different version code for each output
    variant.outputs.each { output ->
        output.versionCodeOverride =
                project.ext.versionCodes.get(output.getFilter(com.android.build.OutputFile.ABI), 0) * 1000000 + android.defaultConfig.versionCode
    }
}

or by modifying the version code from a flavor declaration:
x86 {
       ndk.abiFilters = "x86"
       versionCode = project.ext.versionCodes.get(output.getFilter(com.android.build.OutputFile.ABI), 0) * 1000000 + defaultConfig.versionCode
    }

This behavior should be part of the samples whether they're using splits or abiFilters to generate arch-specific APKs.
However, I couldn't find a way to do the same with the new DSL, could you look into implementing this with the new DSL ?

Thanks @ph0b
If that's not available with the new DSL, we should file a feature request on tools.android.com, if this is available we should update our sample to use it.
Let's keep this issue open to track the latter.

// You can modify  configuration for each variant.
components.android {
binaries.afterEach { binary ->
//.........
}
}

Thanks for the pointer.
Unfortunately, I've looked at binary.targetAbi but it's currently empty when using abiFilters and splits aren't adding any flavors.
I couldn't find how to read the version code from there either.

/cc @rschiu

seems to be experimental related, closing


Update gems

Coverage remained the same at 97.549% when pulling 20ecbe4343cc7136bd1f51de5812973f4f453ed1 on update-gems into 82d866992f5823f7e54b390c5b4ca8c4eb03f768 on master.


Using shift buttons on the left gearshift.

Hi,
I read that with the latest version, Ki2 is supporting 4 channels, right?
Would it then somehow be possible to use the buttons on the left gearshift also? would be great to be able to navigate pages and zoom while even being in the drops. As I am using synchro shift, I never manually shift the front derailleur anyways..
Thanks
Paul

Great! Thanks so much!! Works just fine!
Paul


Feature Request support of python functions

I am storing my invoices with the following convention
YYYY-MM-DD_name of the invoice.
To process the date I have written the following  python filter that
      - python: |
          import textract
          import datetime

       #check valid date string beginning of filename
          date_string = path.stem[0:10]
          format = "%Y-%m-%d"
          result=True
          try:
            datetime.datetime.strptime(date_string, format)
          except ValueError:
            print("This is the incorrect date string format. It should be YYYY-MM-DD")
            result=False

       #calculate billing periode. New period is starting at April
          startofperiode = 4
          if (result):
            if ( int(path.stem[5:7]) >= startofperiode):
              period = (path.stem[0:4] + '-' + str(int(path.stem[0:4]) + 1))
            else:
              period = ( str(int(path.stem[0:4]) - 1) + '-' + path.stem[0:4] )

       #remove blanks
            content = str(textract.process(str(path), errors="ignore")).replace(" ","" )

       #put further search logic here and calculate result
           if (........  );
              result = {"filter": filter,
                            "year":path.stem[0:4],
                            "period":period,
           else:
               result = False

          return result

This results into a pretty 'lengthy' python script that needs to be repeated for each rule.
It would be great if such scripts could be defined as functions that can be called in the python filter.

You can already do this:
my_python_script: &script |
  print("Hello World!")
  print(path)

rules:
  - folders:
      - ~/Desktop/
    actions:
      - python: *script

  - folders:
      - ~/Documents/
    actions:
      - python: *script

Wow. This is great.
It seems I have not read the documentation properly.

Is it possible to pass a parameter to the script, e.g.
'''
my_python_script: &script(test) |
print("Hello World!" + test)
print(path)
rules:

folders:

~/Desktop/
actions:
python: *script(30)

folders:

~/Documents/
actions:
python: *script(50)
'''


Add build variants for libnetcdf

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

PVI @tlvu

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

I needed to manually add libnetcdf 4.8.1 as a build variant here, since all the documented approaches were not working.
@conda-forge/help-python
I need to be able to offer this package built against libnetcdf 4.8.1 and 4.9.x. How do I properly configure that here?


The document is outdated ？

webpack 4 removes the CommonsChunkPlugin in favor of two new options (optimization.splitChunks and optimization.runtimeChunk).  However, in the offical document page, the CommonsChunkPlugin is still here, and no splitChunks and runtimeChunk found.

+1

The documentation is outdated. We are doing our best to update it. You could track our progress in the webpack/webpack.js.org repository.

Upgrade document please. I'm stuck in Code splitting section.


chore: only bind socket without listening

This PR cleans up the port assignment code to only bind the socket without listening.

seems reasonable; does this pass our tests?
@darkrift do you want to give this a spin on your repo as well?

Hmm tested and it doesn't work. I will close.


Added type update when entity fields are updated

Changes
Added type update when entity fields are updated
Tests
[x] Made sure SDK is generated correctly
[x] Made sure CLI is generated correctly

let me test it...


VR Roadmap

[ ] Change the world ray cast to the right hand instead of the Main Camera
[ ] Add watch to show/hide the 2D UI
[ ] When the scene is loading, you can see the emissive materials, and it should be dark
[ ] Fix Player Physics to match the Mobile version
[ ] Add layouts to know which meta quest input does what in the world
[ ] Emotes are not being played
[ ] Add a virtual keyboard for when you need to text (there is one in the godot-xr-tools)
[ ] Other players see VR players "flying" (the broadcasted position is a bit "high", there are some centimetres from the floor)
[ ] When you go to Genesis Plaza, it teleports you to -9,-9, but sometimes you're at -10,-10 and it doesn't load Genesis Plaza (looks like it's the offset of the VR room position)
[ ] Discuss removing the teleport and allowing walking, or having a "cooldown" to walk at the same speed as other clients

try this
https://bit.ly/4gwC82r
I put the necessary dlls in the archive


PR table isn't formatting properly

When loading the Pull Requests page (where it lists out all the PRs that are open), it no longer succeeds at styling the table.
I receive the following error in the console:
not able to load plugin PR filter table Error: No bitbucket/internal/feature/pull-request/table/pull-request-table
This error is produced from a try/catch found on line 2117 in the stash_page.js.
Not really sure what's missing, but I wonder if it's my BitBucket enterprise version being either too up to date, or too old? Seems like a bitbucket source file it uses to parse out the table isn't available or being served by my BitBucket server anymore.

What's the version of your Bitbucket?

v4.14.4
I think this version is actually kind of old, given it's an enterprise setup. Though, the plugin worked all up until about 2-3 weeks ago before the plugin version error issue came about (Issue #54)

That actually is very likely, that's the issue. As with latest update of extension, new bitbucket api is used (in PR list)

Ah... yeah, I see it now in the latest commits.
Are there plans to keep the back support? I wonder if it's broken simply because /table was added in the require() call?

That might be it can you try to checkout repo, remove table/ and load extension from folder? Then there could be try-catch block around that require, if it fails with "table" then try without

Yep, that was going to be my first check. Turns out it fixes it!
I could try to make a PR in a bit with a conditional require check to see if one or the other loads?

I won't be able to check it sooner that in 12hrs. So if you create PR by then, I can check.

#56 PR is up :) I'm a little weak with JS, but I can confirm this resolves the issue. It'd be nice if there's a way to check bitbucket version < 5.0 or something, but not immediately familiar with all the stuff going on in that script. Feel free to make any suggestions to improve the solution.


UnicodeDecodeError while converting name table entries with record.toUnicode()

reproducible with standaard Helvetica.ttc
proposal: fallback to the record.toUnicode("backslashreplace")
a PR is coming
from fontTools.ttLib import TTFont

path = '/System/Library/Fonts/Helvetica.ttc'
source = TTFont(path, fontNumber=1)

for record in source["name"].names:
    print(record.nameID, record.platformID, record.platEncID, record.langID, str(record))
    print(record.toUnicode("backslashreplace"))    # proposal fallback to a backslashreplace version
    print(record.toUnicode())    # <---- UnicodeDecodeError

It looks like this issue should have been closed when the fix landed.

Yes, thanks, closing


feat: add deprecation error handling for session.sid_length and session.sid_bits_per_character for PHP 8.4

Description
See #9116
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

If we don't support PHP 8.4 in v4.5.x, we don't need this PR.

We do not support PHP 8.4 in v4.5.x.


Implemented optional language change feature

Implemented optional language change feature for Internationalization and Localization contributors. Contributors don't have to sign out to change the App's language. Changing language inside app and restarting changes App's language.
PR Type
What kind of change does this PR introduce?
Feature

Great, I am ok with DEBUG only. Thanks!


Linting should not run during Build by default

What problem does this feature solve?
Linting is a development-time task. The output of warnings are useful to devs at a time when they can be inspected, addressed or logged elsewhere to be addressed.
Developers run vue-cli-service lint explicitly? obviously the exact right time to run the linter.
Developers running local development server? also a great time to lint! The lint-warnings overlay is fantastic.
However, running the linter during vue-cli-service build? Not good. The documentation implies that only lint errors fail the build. However, this isn't strictly true when using additional eslint plugins and configs (like prettier). So the end result is that linting during a production build can prevent the build entirely.
lintOnSave to the rescue!? Not so fast. Firstly, the configuration setting is misnamed. It does not control whether linting occurs on save but whether linting occurs during a build. There are a plethora of issues and comments regarding lint errors/warnings during build that indicate the lintOnSave option is not well known nor understood. Indeed, it took days for me to track down why linting was running during our build at all; and even longer before I discovered this option. Had the option been named lintOnBuild, a quick scan of the docs would have uncovered this behavior much quicker.
But back to the point: why is lintOnSave insufficient? The common recommendation is to have lintOnSave be based on NODE_ENV !== production. This seems reasonable except npm's own prepare script (which exists specifically to be hook for running builds/compilation) is not run under "production". So the very environment variable that would be used to disable linting during the build; is precisely what prevents the build from even occurring in the first place. What's more, vue-cli-service build defaults to running a "production" build, so in that same spirit, it should also disable the linting process.
What does the proposed API look like?
My proposal is that lintOnSave should be driving by vue's "mode" (not NODE_ENV). In which case:

vue-cli-service serve would continue to run the linter as its default mode is development
vue-cli-service build would not run the linter as its default mode is production.

My own opinion
if (!isProd || isProd && lintOnBuild) {
// set eslint-webpack-plugin or eslint-loader
}


Update server based on latest OpenAPI spec

The OpenAPI of the Date Annotator has been updated this week following a discussion with George.
https://sage-bionetworks.github.io/nlp-sandbox-schemas/date-annotator/develop/openapi.yaml

Just updated the API to edge


Remove unused pin-utils dep

pin-utils is no longer used. This removes it from our dependency tree.

Ah dang, pin_utils with underscore didn't show up in search. We do this PR tho. Going to file an issue for this instead.


Add Sports namespace

Checklist

[x] Deprecate ::Football
[x] Separate v1.9.3 deprecations from current version deprecations
[x] Add missing Faker::Construction documentation

@vbrazo should the unreleased README and. CHANGELOG be mentioned in the contributing guide? That way, community contributors can make those changes themselves, rather than the core maintainers doing it as a chore.

I think it's a good idea, but some contributors won't change these files because they're lazy or busy.
Notice that I moved doc/sports/basketball.md to doc/unreleased/sports/baskeball.md because users usually go inside the doc folder and they get confused with the features that are released in current version/v1.9.3 versus the ones that are only on master.


Mythic/- Shatter Defense and Kinetic Blast

Kinetic Blast currently does not proc shatter defense. But it does benefit from the Shatter Defense (Mythic) proc-ced by others
Incidentally, Rays are the same

This should be fixed in the next release, I had this tagged with AttackWithWeapon instead of just Attack


cherry-pick #961 for 1.0 removes authconfig from info log

Signed-off-by: Mike Brown<EMAIL_ADDRESS>

/lgtm


fix(): Fix nil pointer panic in verification example

After completing challenge Account at root structure stayed to be nil. That cases panic.
Assign Account from Challenge to root Account

Could you please review @ahmdrz ?

@ahmdrz
Or maybe it will be better to refactor login with verification challenge case logic?
Nevertheless, now it works without panic.

@ahmdrz
Or maybe it will be better to refactor login with verification challenge case logic?
Nevertheless, now it works without panic.

I tried it but didn't work


inrupt.net's picture is unavailable

The picture that inrupt.net has in this list (https://static1.squarespace.com/static/5b3e3ef4ec4eb767a0513abb/t/5b900a3c4ae237882d673b18/1540234254934/) is down.
Would be great if somebody could fix it or update the picture url. Maybe https://design.inrupt.com/atomic-core/img/inrupt.svg could work?

was fixed in #20


[FLOC 2128] Add installing Vagrant/VirtualBox step to tutorial

Fixes 2128
The Using Vagrant to Create Virtual Machines tutorial provides no details about installing the products. This PR adds an installation section with links to Vagrant and VirtualBox docs, but also adds a useful example for OS X users of installing using brew cask

Definitely +1 on the installation section. I'm sort of meh-y on the cask lines (and the virtualbox one didn't work for me, but I think that's because I already have virtualbox installed).
But... they do seem rather convenient, so let's keep them.
Otherwise 1 question, I'll defer to you on the answer and let you address and merge when you get a chance.

thanks @sarum90 - I should have used alice@mercury so I made this amendment!


App sometimes gets cut when maximized

Describe the bug
App sometimes gets cut in left top corner when maximized.
Steps to reproduce the bug

Create window like this https://github.com/NotroDev/SkEditorPlus/blob/main/SkEditorPlus/MainWindow.xaml.cs
Minimize it
Maximize it by moving it to screen's top

Expected behavior
No response
Screenshots

NuGet package version
HandyControls (Custom version) 3.4.0
IDE
Visual Studio 2022
Framework type
.Net 6.0
Windows version
Windows 11 (22000)
Additional context
HandyControls' version is 3.4.4, not 3.4.0

3.4.4 非官方版本

WindowStyle="None" worked for me


Fix typo in JS Yeoman generator

Issue
There's a typo in the default description in the generator (generator-botbuilder).

Logging the issue here, since it's the one the npm package points to.

Repo steps

Start the generator and look at the default text for the description.
Error: there's a missing i in the word capabilities in the description.? What will your bot do? Demonstrate the core capabilties of the Microsoft Bot Framework

https://github.com/MicrosoftDX/generator-botbuilder/blob/dcfe1fddb8efb304de3529ff6299ee8b44fff285/generators/app/index.js#L13
Here's the line with that message, but trying to find where the default text resides.

This line is correct in the readme:
--description, -D | Demonstrate the core capabilties of the Microsoft Bot Framework
But I am having trouble finding the typo in the generator itself.


Publish wheels for musllinux

On Alpine linux running:
pip install 'ziglang==0.10.0'

Fails with:
ERROR: Could not find a version that satisfies the requirement ziglang==0.10.0 (from versions: 0.0.0)
ERROR: No matching distribution found for ziglang==0.10.0

I think this is because the publishing script only releases manylinux wheels and not musllinux wheels
https://github.com/ziglang/zig-pypi/blob/8d37e955e3af0c0d88851e8283081b89b074e3bc/make_wheels.py#L115-L122
Since the linux- binaries published on the zig website are statically linked I think changing
    'linux-x86_64':   'manylinux_2_12_x86_64.manylinux2010_x86_64',

to
    'linux-x86_64':   'manylinux_2_12_x86_64.manylinux2010_x86_64.musllinux_1_1_x86_64',

to the publishing script should work.
I tested this out locally by downloading ziglang-0.10.0-py3-none-manylinux_2_12_x86_64.manylinux2010_x86_64.whl and renaming it to  ziglang-0.10.0-py3-none-manylinux_2_12_x86_64.manylinux2010_x86_64.musllinux_1_1_x86_64.whl and then running python3 -m ziglang worked fine.
Publishing this wheel means running pip install maturin[zig] on Alpine linux will work as well.

Done: https://pypi.org/project/ziglang/0.10.0.post1/


Add link to root directory

Currently, the htmlPath function correctly returns a series of links to child directories of a resource, but it does not provide a link to the "root" folder.
For example. Given you have navigated to "/foo/bar", the following html is created:

    /
    foo
    /
    bar

Would you guys be open to a PR that would simply prepend the following "~" to what is being returned by htmlPath so as the generated html would look like this:

    ~
    /
    foo
    /
    bar

This way there is a quick link back to the root folder of the directory that is being served.

Published as 1.6.0


ShB(KR) replacement order problem fixed and about this issue

Replacement order problem is not only here though. I've finished rearranging for Ultimates.
I think this is very important problem. When making replacement texts, everyone should keep in mind that replacement order MATTERS. I think most timeline replacer are made automatically, letters were ordered by 'abc' order. We need replacement order verification part.
for example,
If 'Burst' is earlier replaced than 'Downburst', 'Downburst' is not correctly changed.
'Burst' changes not only exact 'Burst', but 'Downburst' or 'Vulcan Burst' too.
'Burst' changes to '대폭발' in Korean.
So, 'Downburst' become 'Down대폭발', 'Vulcan Burst' become 'Vulcan 대폭발' in Korean.
So, even if there's 'Downburst' or 'Vulcan Burst' replacer after that, replacement does not happen. javascript can't find those.
This is not a critical problem for timeline texts, but it's very critical when timeline synchronization part is not translated well.
I though this was important issue, so I've made webpage to test replacement. But my programming skill sucks, I couldn't make it perfect, some are not replaced (I think this is regular expression problem).
Test page link and Code repo
If someone can help with this code, thank you for your help.
Example image, you can easily find something is not translated.

I think it's good to add replacement tester inside cactbot repository. I didn't add here, in the repository, because I couldn't make it perfect.

Fixing the order would just temporarly solve the problem. There are already test implemented in another branch which catch these and new replacements are already in process which should catch these issues (https://github.com/quisquous/cactbot/tree/timeline_tests)
Also these changes should already be covered here: https://github.com/quisquous/cactbot/pull/987

Oh, there's regular expression which does not catch others with more characters!
thanks for (?<![\\w| ]) information.
I think I should resolve this collision after that pull request is accepted.
I'll not close this since this contains ShB timeline fixes.

#987 has no open replacement issues based on the tests implemented in (https://github.com/quisquous/cactbot/tree/timeline_tests)

yes, I mean, UCU and UWU change from this branch will be removed after #987 is accepted. Github will show conflicts and I'll change there.

@quisquous please accept #987 first before accepting this pull request.

@quisquous finished resolving conflicts

Ah, I should start again from latest master branch closing this request.


[CoppeliaSim:error]   External call to simCallScriptFunction failed (isRunning@HTC_VIVE): Failed calling script function.

Hi!
First of all, great work, thank you so much!
I'm running into a small bug here, I get this error flooding CoppeliaSim's console window, while not running the simulation.
The error stops once I'm running the simulation, and resumes once simulation is stopped.
However, the VR simulation works just fine.
(btw, I'm using WMR headset and controllers through SteamVR, so you can add WMR to the tested platforms if you wish.)
CoppeliaSim edu V 4.1.0 rev.1 64bit
installed in the default folder (C:\Program Files\CoppeliaRobotics\CoppeliaSimEdu)
(btw, you have the correct path written in copyToVREP.bat: SET vrepLocation=C:\Program Files\CoppeliaRobotics\CoppeliaSimEdu, but the readme.md is wrong: C:\Program Files\CoppeliaSim3\CoppeliaSim_PRO_EDU)
no debug.log file is being created in the VR interface folder,
CoppeliaSim VR Toolbox 2.2
since the VR interface console window writes 'Simulation started' - seems like the vr interface must be getting correct values from isRunning function in HTC_VIVE.lua, so it could be that the bug is in coppeliaSim.
output from VR interface console window:
Trying to connect with V-REP ...

Connected to V-REP, clientID number : 0
Connected to V-REP port number : 19997
Wait for simulation start ...
Simulation started

Loaded geometry with handle 14 with 6 vertices and 2 faces vrep name : Plane Visibility layer : 1
    Added texture to shape
Loaded geometry with handle 16 with 984 vertices and 1988 faces vrep name : IRB4600_visible Visibility layer : 1
Loaded geometry with handle 19 with 2118 vertices and 4163 faces vrep name : IRB4600_link1_visible Visibility layer : 1
(...I removed similar 'Loaded geometry' lines before posting)

Number of objects loaded : 131
Added light, angle : 90.0027
Added light, angle : 90.0027
Added light, angle : 90.0027
Added light, angle : 90.0027
Everithing loaded succesfully
Connected to VREP path
fps: 96     Scale: 100%

Wait for simulation start ...

Same question there.And my steam VR stuck on the start scene of the VREPVIVE.But sometimes it works when I just use one model.So I think maybe my graphic card is not enough to handle it.（NIVIDA GTX 1050ti）

I use Discrete graphics card and it works. Hope it can help you.

@lyl1999923, your steam vr being stuck is not related to this.
@BorisBogaerts , one way to solve the issue I mentioned above, ('External call to simCallScriptFunction failed' flooding coppeliasim's console window) would be to create an addon script in coppeliasim's installation folder, named simAddOnScript_(script name).lua , the simAddOnScript_ prefix means it will auto-run when coppeliasim starts. that script can have the isRunning function (that is currently in HTC_VIVE.lua), and another test should be added to that script - making sure that there is an HTC_VIVE object present in the current simulation.
I haven't tried compiling your code yet, if I did I would make a pull request.

Hi everyone,
did anyone come up with a solution to this? I have the same problem. I tested the CoppeliaSim VR Toolbox 2.2 with different versions of CoppeliaSim (4.2, 4.0, 3.6.2).  The tools doesn't seem to load up with SteamVR, it's stuck at the loading screen.
Any help on this?
Thanks!

Hi,
Normally out of the box the interface should work. Can you give more details about your setup, and the steps you did to install the interface? Are you using the EDU version of coppeliasim? If I find the time I will check with the latest version of coppeliaSim if some things changed that break the installation procedure. It's been a while since I last worked on this.

Hi,
My setup:

CoppeliaSimEdu (4.2, 4.0, 3.6.2)
CoppeliaSim VR Toolbox 2.2 (using executables)
HTC Vive (2016)
RTX 3060
SteamVR 1.20.4

I installed following your youtube instructions and I set the vrepLocation and ran the script under admin. I first start the simulation in CoppeliaSim and then the VR Toolbox, where I can see it fetching the geometries from CoppeliaSim.
When I put on the headset, it seems to be stuck at the loading screen as shown by a previous poster https://github.com/BorisBogaerts/CoppeliaSim-VR-Toolbox/issues/8#issuecomment-699937191.
I appreciate you looking into it!
Cheers
Haichao

Hi,
As before I cannot reproduce this issue. If I install everithing the interface just works. I also noticed that the license of coppeliasim changed, so I cannot use it anymore. Are you sure that you use the educational version of coppeliasim, that's the only thing I can think off that might be wrong? Otherwise I would look for issues in your steamVR setup.
Sorry I cannot help you more
Kind regards,
Boris

Hi @BorisBogaerts ,
thanks for looking into that. Yes, I'm using the educational version. So far I had no luck, but I will post it if a solution comes up.
Cheers
Haichao


python: keep stream and engine alive for callbacks

Description: Modifies the ownership model of objects so that callbacks keep their relevant parent alive (EngineCallbacks -> Engine; StreamCallbacks -> Stream) instead of the other way around.
This PR assumes that one of StreamCallbacks terminal callbacks will be called exactly once (on_complete, on_error, on_cancel) and that on_exit will be called exactly once. If these are called more than once there will be a double free, if they are not called once we'll leak memory. This is obviously not good 🙂
Risk Level: Low
Testing: bazel test //test/python/integration:test_lifetimes
Docs Changes: N/A
Release Notes: N/A

Marking as ready for review because I want feedback on this strategy. I'm kind of fumbling around in the dark, so I'm sure there's a better way.


css: Size stream recipient box for small screens.

This allows the recipient box to take 100% of the available horizontal space, up to 175px. The effect is that the compose-box buttons are available to users at mobile scales (viewports of 400px wide or less).
See CZO discussion; this also relates to #24889 and the work @shameondev has in progress (who should just remove the max-width: 175px declaration).

Screenshots and screen captures:

Before, 325px viewport
After, 325px viewport

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Looks good to me in manual testing!

Looks great, merged, thanks @karlstolley!


Puree artifact jar is empty

4.1.3 is released, but the artifact delivered from maven server is empty, so we can't use any classes and library.

Thanks for reporting, and PullRequest.
When I was investigating this issue, I found the problem that classes.jar moved other directory.

before

puree/build/intermediates/classes/release/classes.jar

after

puree/build/intermediates/packaged-classes/release/classes.jar

So the problem will be fixed when the path fixed(below code). You don't need to make aar publishing.
https://github.com/cookpad/puree-android/blob/af20eb635a0a17e11e35bd5e8f4972979360ebec/puree/build.gradle#L91

Why do you not use AAR?
AAR is a standard library format for Android. It brings some benefit like including AndroidManifest to restrict SDK version.
In my opinion, if the library is scoped only Android, aar is better than jar.
Of course, if you prefer jar than aar, I respect it.

直ったと思ったら直ってなかった。 ごめんなさい近い内に直します。aarにするかは検討させてください


Update frontend code components to use new tables

event-data-provider.tsx needs to be updated to use the new CloudSQL-backed graphql queries

Done here as part of the fix to Hasura configs
https://github.com/opensource-observer/oso/pull/861/files


whitelisting Github Enterprise repo

I'm having some trouble whitelisting a GH Enterprise repo.
I've deployed Atlantis using the terraform-aws-modules/atlantis/aws tf module, configured the github hook in one of the test repos I want to whitelist. Ping webhook requests to Atlantis are working.
When I create a test PR, webhook requests get a 403 Repo not whitelisted or Ignoring pull request event from non-whitelisted repo "github.example.com/test/test-repo"
I assume I need to set the GH hostname with an env var for the ECS task, however I see that's not exposed via a tf var (similar to atlantis_gitlab_hostname)
I've though of setting the env var with custom_environment_variables, however I'm not sure what the env var name should be (i couldn't find it in atlantis docs)
I have tried both below ways of doing the whitelisting, I get the same error message:
atlantis_repo_whitelist = "github.example.com/test/test-repo"

atlantis_repo_whitelist = "test/test-repo"
  custom_environment_variables = [
    {
      name  = "GH_HOSTNAME"
      value = "github.example.com"
    }
  ]

Any help appreciated

Ah, I found the documentation
https://www.runatlantis.io/docs/server-configuration.html#environment-variables


New version: Tauri.create-tauri-app version 3.13.6

Created by 🥟 Dumplings in Run #3477.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run

Hi @SpecterShell,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 813.)

Automatic Validation ended with:

Installation failed with exit code -1978335187 2024-02-25 22:51:20.182 [CLI ] Installer [X64,portable,Unknown,] not applicable: Machine is not compatible with X64 2024-02-25 22:51:20.182 [CLI ] Installer [Arm64,portable,Unknown,] not applicable: Machine is not compatible with Arm64 2024-02-25 22:51:25.146 [FAIL] Installer failed security check. Url: https://github.com/tauri-apps/create-tauri-app/releases/download/create-tauri-app-v3.13.6/create-tauri-app-i686-pc-windows-msvc.exe Result: 0x80004005 2024-02-25 22:51:25.146 [CLI ] Terminating context: 0x8a15002d at D:\a_work\1\s\external\pkg\src\AppInstallerCLICore\Workflows\DownloadFlow.cpp:1e6

(Automated response - build 813.)

@wingetbot run

@wingetbot run

@wingetbot run

Hi @+Validation-Defender-ErrorBinary-Validation-ErrorError-Analysis-TimeoutError-Hash-MismatchError-Installer-AvailabilityInternal-ErrorInternal-Error-Dynamic-ScanInternal-Error-ManifestInternal-Error-URLManifest-AppsAndFeaturesVersion-ErrorManifest-Installer-Validation-ErrorManifest-Validation-ErrorPossible-DuplicatePullRequest-ErrorURL-Validation-ErrorValidation-DomainValidation-Executable-ErrorValidation-Hash-Verification-FailedValidation-Missing-DependencyValidation-Merge-ConflictValidation-No-ExecutablesValidation-Installation-ErrorValidation-Shell-ExecuteValidation-Unattended-FailedPolicy-Test-1.2Policy-Test-2.3Validation-CompletedValidation-Forbidden-URL-ErrorValidation-Unapproved-URLValidation-RetryNeeds-Author-Feedback[0],
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 843.)

Automatic Validation ended with:   Installation failed with exit code -1978335187  > 2024-02-27 22:27:54.516 [CLI ] Installer [Arm64,portable,Unknown,] not applicable: Machine is not compatible with Arm64  > 2024-02-27 22:27:58.834 [FAIL] Installer failed security check. Url: https://github.com/tauri-apps/create-tauri-app/releases/download/create-tauri-app-v3.13.6/create-tauri-app-x86_64-pc-windows-msvc.exe Result: 0x80004005 Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Packages\Tauri.create-tauri-app__DefaultSource\create-tauri-app.exe returned exit code: 1 Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\create-tauri-app.exe returned exit code: 1   (Automated response - build 843.)

@wingetbot run

@wingetbot run


Introduce archinfo to quickly retrieve architectural properties

So far, collection of architectural properties was horribly scattered over multiple modules (some in __init__.py, some in dle.utils.py, ...). Now everything lives under (the more general) devito/archinfo.py.
Also, calling cpuinfo takes, on my machine, between 1 and 1.5s. The function was memoized, but anyway this was introducing a non-negligible overhead each time one wanted to run a single, quick test. So as a workaround for Linux systems, with this PR we first try to gather the information directly reading from /proc/cpuinfo, which is much faster, while cpuinfo is used as fallback.
~This is based on #783 , hence the big diff ATM, otherwise the PR is quite small~

May need some reorga at some point for GPU support too (or ARM or whatever)

Absolutely. This is intended to be a first step in that direction

Codecov Report

Merging #787 into master will decrease coverage by <.01%.
The diff coverage is 88.4%.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   88.69%   88.68%   -0.01%
==========================================
  Files         104      104
  Lines       11070    11063       -7
  Branches     2203     2199       -4
==========================================
- Hits         9818     9811       -7
- Misses        968      969       +1
+ Partials      284      283       -1

Impacted Files
Coverage Δ

devito/dle/__init__.py
100% <ø> (ø)
:arrow_up:

devito/__init__.py
87.27% <100%> (-2.95%)
:arrow_down:

devito/dle/rewriters.py
80.59% <71.42%> (+0.11%)
:arrow_up:

devito/archinfo.py
92.15% <92.15%> (ø)

devito/yask/wrappers.py
86.38% <0%> (-0.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6602b2a...09082d0. Read the comment docs.

merged


Adding iPhone 11 and friends

Work In Progress:

still needs iPad 7th gen
still needs tests
still needs update Identifier

Codecov Report

Merging #39 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   93.44%   93.49%   +0.05%
==========================================
  Files          12       12
  Lines         900      907       +7
==========================================
+ Hits          841      848       +7
  Misses         59       59

Impacted Files
Coverage Δ

Sources/DeviceModel.swift
99.21% <100%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fadbfa...e18a080. Read the comment docs.

LGTM

will you be updating/incrementing the version in the podspec so this can be pulled using Cocoapods? ty!

@jminutaglio will do so aft i finish up identifiers ok?


'RMDateSelectionViewController' does not have a member named 'setLocalizedTitleForSelectButton'

Maybe I'm not getting something, but I can't use the setLocalized* methods.

It's a static method. So you need to write RMDateSelectionViewController.setLocalizedTitleForSelectButton() ;)

Oh okay. Shouldn't this be an instance method like hideNowButton() and others? (I could have multiple RMDateSelectionViewController with different purposes)

Actually, this property should be settable via a Proxy API, very much like the UIAppearance API. But this is something for a future version ;)


Trace id is lost when switchIfEmpty is used with WebClient

Trace is lost when switchIfEmpty is called on empty response.
When switchIfEmptyTest endpoint from sample code is called for the first time, trace id is preserved.
In subsequent calls trace id is not coherent per request.
First request:
2018-09-28 16:00:43.285  INFO [-,db4e155b1bdc3754,7093aac868959aea,false] 26719 --- [server-epoll-19] com.example.demo.SwitchIfEmptyTest       : Returning empty response
2018-09-28 16:00:43.318  INFO [-,db4e155b1bdc3754,7d0721310fe138e5,false] 26719 --- [server-epoll-20] com.example.demo.SwitchIfEmptyTest       : Returning normal response

Second request:
2018-09-28 16:00:46.007  INFO [-,c9acddb5c538e4c5,ef211d3920189fec,false] 26719 --- [server-epoll-20] com.example.demo.SwitchIfEmptyTest       : Returning empty response
2018-09-28 16:00:46.022  INFO [-,db4e155b1bdc3754,abeff0c843922132,false] 26719 --- [server-epoll-19] com.example.demo.SwitchIfEmptyTest       : Returning normal response

Sample code to reproduce an issue:

@RestController
public class SwitchIfEmptyTest {

    private final Logger log = LoggerFactory.getLogger(getClass());

    @Autowired
    private WebClient webClient;

    @GetMapping("switchIfEmptyTest")
    Mono<String> switchIfEmptyTest() {
        return request("empty")
            .switchIfEmpty(request("notEmpty"));
    }

    @GetMapping("empty")
    Mono<String> empty() {
        log.info("Returning empty response");
        return Mono.empty();
    }

    @GetMapping("notEmpty")
    Mono<String> notEmpty() {
        log.info("Returning normal response");
        return Mono.just("ok");
    }

    private Mono<String> request(String uri) {
        return webClient
            .get()
            .uri(uri)
            .retrieve()
            .bodyToMono(String.class);
    }

}

@Configuration
public class WebConfig {

    @Bean
    WebClient webClient() {
        return WebClient.create("http://localhost:8080");
    }
}

Which version of Sleuth is it?

Actually, you're sending a request to yourself. Can you verify that the same problem is still there if you have 2 separate applications?

Can you check if it's also broken using Greenwich.M1 ?

Ok. Will find some time next week.

Issue seems to be resolved in Greenwich.M1

Great, thanks!


Cross Origin and Data Clone errors on client(browser) side -> see console section on the right in screenshots

Describe the bug
When running in a browser (including Canary) - it fails to perform the tasks - see the crossed red tasks. But no error from the DEBUG or any message.

Link to the Bolt URL that caused the error
localhost
Steps to reproduce
Just request a new ToDo List app from the list of examples at the bottom of the Bolt.new front screen
Expected behavior
should perform the tasks on the list
Screen Recording / Screenshot
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

@msfreud you need to run over https
Check Issue #57


The resources for the frequency is not in the package

have to add it to setup.py in the package_data

fixed in the release 0.2.2


how do you download visual studio 2019 i need it for fnf mod

Describe your problem here.
i cant download visual studio 2019 without it saying setup failed
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
I changed HScript from teacall to tea

Try this https://visualstudio.microsoft.com/ru/thank-you-downloading-visual-studio/?sku=community&rel=16&utm_medium=microsoft&utm_campaign=download+from+relnotes&utm_content=vs2019ga+button

Try this https://visualstudio.microsoft.com/ru/thank-you-downloading-visual-studio/?sku=community&rel=16&utm_medium=microsoft&utm_campaign=download+from+relnotes&utm_content=vs2019ga+button

alr thanks


fix x1dints reader to better handle having only some segments available

In addressing #242 , this updates the from_x1dints reader to do a better job loading x1dints files that have been split into multiple segments, even if some segments are missing. In most cases, it should offer a warning if it can detect that some segment files are missing.

OK, I actually found a previous warning that I had put in that should cover the case of the last segment(s) being missing, so I'm slightly more confident that warnings will be raised when needed if not all segments are included.


refactor: improve items selection

:white_check_mark: Build TheIdServer 1.0.0-export-import1-0086 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/67f21b39ae by @aguacongas)


How to execute a policy ( yaml ) file as a lambda function

Hi,
I have created a policy document as .yaml file and it works very well when i execute from command line
custodian run -c my_first_polict.yaml -s /home/ec2-user/custodian/output -r us-west-2
Howvever i want to run this as a lambda function with below addition
mode:
  type: periodic
  schedule: "rate(1 hour)"
  role: lambda_start_stop_role

When i try to execute it lambda log say as below
{
"errorMessage": "Syntax error in module 'lambda_function'"
}
Could you please advice how could i execute this as a lambda func? ( it supports only python, node.js and java )

syntax error sounds quite strange.
what os are you using?, what version of python, what version of custodian? what's the output of running custodian?

oh are you trying to copy and paste the the yaml file as a lambda policy? that won't work, you use custodian to deploy the yaml file, after adding the mode information to the policy.

yes i am copied the yaml file content and pasted into "Code"  block of AWS Lambda
Do i have to create a python script and call the below command in that ?
custodian run -c my_first_polict.yaml -s /home/ec2-user/custodian/output -r us-west-2
and make that python script as lambda function ?

can you please tell me what command should i use to achieve the below ?
"you use custodian to deploy the policy as a lambda function, after adding the mode information to the policy"

if your policy yaml specifies a mode and events to subscribe to running the custodian command line will provision the lambda for you and hook up the event sources. ie. the output of a custodian run -c config.yml is a provisioned lambda and its event source.

complete but contrived example
policies:
   - name: ec2-tag-compliance
     resource: ec2
     mode:
      - type: config-rule
         role: insert_your_lambda_role_arn
     filters:
      - "tag:appname": absent

now run the policy
custodian  run -c policy.yml
and the lambda is deployed, as a custom config rule to validate that ec2 instances have the required tag else they are marked non compliant by config

thanks Kapil

Hi kapil,
Is it possible to invoke custodian run command from lambda function?
or is there any way to get output of custodian run command into lambda function ?

@kapilt
Hi kapil,
Is it possible to invoke custodian run command from lambda function?
or is there any way to get output of custodian run command into lambda function ?


[Incubator][VC]Update ClusterVNodePodMap when vPod is deleted

Since DWS logic is restructured, we cannot track vPod delete event from dws. This change ensures ClusterVNodePodMap is updated when vPod is successfully deleted from tenant master.

/lgtm
/approve


Added RubyConf Portugal

Great. Thanks. Cheers. Note: Will add it "by hand" because there's a merge conflict. Thanks again.


vocal after region speed change

synthesis button gets stuck.

@Dard-Neuman I think I have fixed this(at least in the case of pressing "escape" to exit this mode). Can you confirm if it is now working properly?

I'm unable to recreate this bug.


0.0 is not considered an integer in draft-04 schemas

I discovered this oddity working on a hypothesis-jsonschema upgrade:
from jsonschema import validate
validate(0.0, {"type": "integer"})  # passes
validate(0.0, {"type": "integer", "$schema": "http://json-schema.org/draft-04/schema#"})  # fails

The first behaviour is correct, because the "integer" 'type' is defined by having a zero fractional part, rather than by the Python type of the value.  (a surprise which my planned feature will introduce to users...)

Hi hi!
The zero fractional part was new in draft 6 (or 7, I forget). In draft 4, using the language-level type was the expected behavior.

from jsonschema import validate
validate(0.0, {"type": "integer"})  # passes
validate(0.0, {"type": "integer", "$schema": "http://json-schema.org/draft-04/schema#"})  # fails

About validate function, when no schema is passed in, the latest validator  Draft7Validator  is used for verification by default, and if a schema is passed in, the incoming validator Draft3Validator Draft4Validator Draft6Validator or Draft7Validator is used for verification.
In jsonschema\_types.py:
draft4_type_checker = draft3_type_checker.remove(u"any")
draft6_type_checker = draft4_type_checker.redefine(
    u"integer",
    lambda checker, instance: (
        is_integer(checker, instance) or
        isinstance(instance, float) and instance.is_integer()
    ),
)
draft7_type_checker = draft6_type_checker

The float in the type_checker of draft6 and draft7 have been redefined integer, while draft3 and draft4 haven't been redefined. So your code above, the first  behaviour was correct, the second failed.

Huh, https://json-schema.org/draft-06/json-schema-release-notes.html#q-what-are-the-changes-between-draft-04-and-draft-06 does indeed note this change.
I'd only looked at https://tools.ietf.org/html/draft-zyp-json-schema-04#section-5.5 vs https://tools.ietf.org/html/draft-handrews-json-schema-02#section-6.3, which as the changelog notes both say that integer-valued numbers SHOULD be encoded without fractional part, i.e. libraries had better support both :roll_eyes:
So I guess I either have to abandon this "helpful feature", or track the schema version down into subschemas...
Anyway, thanks heaps for your quick response, and thanks again for the wonderful library :heart:

So I guess I either have to abandon this "helpful feature", or track the schema version down into subschemas...

Yeah you can imagine implementing it was similarly fun :D, might as well share the pain with downstream folks too hooray!

Anyway, thanks heaps for your quick response, and thanks again for the wonderful library ❤

Of course, and thanks for being great!


[3.x] Fixes delete objects with empty string

Summary
Reopened PR that prevents empty strings to be passed as an objectId when using index.deleteObject. The last PR was introducing a breaking change throwing an error when someone gaves a 0 as an objectId (and this was not valid). As explained in this comment: https://github.com/algolia/algoliasearch-client-javascript/pull/789#issuecomment-542104709
Related issue: https://github.com/algolia/algoliasearch-client-javascript/issues/755
Result

Breaking change fixed. Now 0 is a valid object id.
Also I've took the opportunity to test some uncovered cases: (https://github.com/algolia/algoliasearch-client-javascript/commit/c740877137240cc688b6fec36db557b338c0fd2d#diff-7f406cf06aa9340c5d564bde813b50f2)

When deleteObject('id') with a valid object id
When deleteObject('id', cb) with a valid object id and a callback

@Haroenv Now that we have the v4 out, I would prefer to freeze the v3 completely. I was thinking about not merging this pull request as there is no actually bug on the method.

I'm not sure if this isn't a bug, since v3 does have safe programming. I'm ok with closing it though (definitely thank @alexhoma for your time making this PR), since it's fixed in v4

Yes - thanks @alexhoma !


Correct composer vendor folder and autoload location

I dont know if this is correct because of this problably not

Enabling this setting will tell CodeIgniter to look for a Composer
package auto-loader script in application/vendor/autoload.php.

but when i run composer install vendor directory is created in root directory
or add in composer.json
"config": {
    "vendor-dir": "application/vendor"
},

"config": {     "vendor-dir": "application/vendor" },
sounds more logical then the other changes which you have made.
Another option is to leave the vendor folder outside the App folder which is not so bad idea specially when there is a Public folder containing the index.php..

This is not needed. Yes, I need to modify the path that is listed in the docblock, but the config file continues, saying that you can specify the exact location of the autoload file:

Or if you have your vendor/ directory located somewhere else, you can opt to set a specific path as well:
$composerAutoload = '/path/to/vendor/autoload.php';

So, no need for another variable to do the same thing. I'll update that comment to point to the correct location, though.
Good catch!


Default row and column spacing is undocumented

The default row and column spacing are each 6. However, this important detail is undocumented. It should be documented here and on the pages for the RowSpacing and ColumnSpacing properties.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c0902f8-eb40-4c56-958a-f13f064c8293
Version Independent ID: 1e930440-f312-6301-d786-262b98f9ce2f
Content: Xamarin.Forms Grid - Xamarin
Content Source: docs/xamarin-forms/user-interface/layouts/grid.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @breyed
Fixed in a PR that will go out later.