Clarify assignment for subroutines

Small clarification that either -> or = can be used in subroutine/kernel assignment.

Out of curiosity: why have two syntaxes that mean the same thing?

Out of curiosity: why have two syntaxes that mean the same thing?

I would prefer to remove the -> syntax for return values and keep = only. Originally -> was kept for measurement assignment for OpenQASM2.0 backwards compatibility but we should not have two ways of doing the same thing. -> is reserved for signature declarations.
Are you ok with this @awcross1?

I would prefer to remove the -> syntax for return values and keep = only. Originally -> was kept for measurement assignment for OpenQASM2.0 backwards compatibility but we should not have two ways of doing the same thing. -> is reserved for signature declarations.
Are you ok with this @awcross1?

I actually like the arrow but I agree we need to have one. My preference for this is why change I dont see enough reasons

I actually like the arrow but I agree we need to have one. My preference for this is why change I dont see enough reasons

I prefer = as it is more common (c/python/...). Most modern languages have assignments on the LHS and this can be interpreted as let x = y. This approach also reserves -> for the signature definition.

I prefer = as it is more common (c/python/...). Most modern languages have assignments on the LHS and this can be interpreted as let x = y. This approach also reserves -> for the signature definition.

Ok,  I think we go with only one and if we go with '=' and either have a note for backward somewhere that only measurement supports '->' (not in the main text everywhere) or we remove. Otherwise we are making it complicated for no good reason, I would prefer remove if we go with '=' so I guess I support you @taalexander.

Ok,  I think we go with only one and if we go with '=' and either have a note for backward somewhere that only measurement supports '->' (not in the main text everywhere) or we remove. Otherwise we are making it complicated for no good reason, I would prefer remove if we go with '=' so I guess I support you @taalexander.

Or use '->' solely for measurement operations, to indicate that a quantum -> classical operation has occurred.
Definitely agree though that the results of kernels and subroutines should use '=' which is much more common for assignments.

Or use '->' solely for measurement operations, to indicate that a quantum -> classical operation has occurred.
Definitely agree though that the results of kernels and subroutines should use '=' which is much more common for assignments.

Or use '->' solely for measurement operations, to indicate that a quantum -> classical operation has occurred.

This is an interesting concept. The interface between the quantum and classical computation is special and perhaps it is useful to have a special notation to signify this. I think I would still prefer LHS assignment result <- measure q; for consistency when reading. This is also related to #102, WRT to output from defcals.

Or use '->' solely for measurement operations, to indicate that a quantum -> classical operation has occurred.

This is an interesting concept. The interface between the quantum and classical computation is special and perhaps it is useful to have a special notation to signify this. I think I would still prefer LHS assignment result <- measure q; for consistency when reading. This is also related to #102, WRT to output from defcals.

Based on this, I will only allow = for assignment in the ANTLR grammar, except in the case of measure where we can continue to have the -> for backwards compatibility.
I don't think a special notation for quantum to classical is necessary. Also some subroutines contain this bridge while others will not and we shouldn't use two different notations for subroutine assignment.

Based on this, I will only allow = for assignment in the ANTLR grammar, except in the case of measure where we can continue to have the -> for backwards compatibility.
I don't think a special notation for quantum to classical is necessary. Also some subroutines contain this bridge while others will not and we shouldn't use two different notations for subroutine assignment.

PR has been updated

PR has been updated

Updated

Updated


Feature Request: Advertise ACL Tags

I'd love to be able to configure ACL tags to the GitHub runner machines with the tailscale up command by adding the flag --advertise-tags.
There would be an optional input specifying the tags you want to advertise.
Ref: https://tailscale.com/kb/1068/acl-tags/#applying-a-tag-to-a-device-with-the-cli

At this point we'd generally advise adding the tags to the authkey: https://tailscale.com/kb/1068/acl-tags/#using-an-acl-tag-with-an-auth-key
Is there a reason the CLI would be preferred?
To use the CLI one could set the environment variable: ADDITIONAL_ARGS="--advertise-tags=tag1,tag2"

@DentonGentry Apologies, I actually missed that part. Thanks for the direction!


Dede dev

@emdedeval Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


select2.min.js:1 Uncaught TypeError: c.ajax is not a function

I got this error from Inspect Element of Google Chrome's dev console.
The error is:

select2.min.js:1 Uncaught TypeError: c.ajax is not a function
at Object.transport (select2.min.js:1)
at d (select2.min.js:1)
transport @ select2.min.js:1
d @ select2.min.js:1
setTimeout (async)
d.query @ select2.min.js:1
a.query @ select2.min.js:1
j @ select2.min.js:1
(anonymous) @ select2.min.js:1
d.invoke @ select2.min.js:1
d.trigger @ select2.min.js:1
e.trigger @ select2.min.js:1
(anonymous) @ select2.min.js:1
d.invoke @ select2.min.js:1
d.trigger @ select2.min.js:1
c.handleSearch @ select2.min.js:1
j @ select2.min.js:1
(anonymous) @ select2.min.js:1
dispatch @ jquery-3.1.1.slim.min.js:3
q.handle @ jquery-3.1.1.slim.min.js:3
There is nothing about this on any issues or forum or in the documentation page

This issue does not appear to conform to our contributing guidelines.
Please re-read the contributing guidelines carefully and then edit your question.  Once your issue complies with the guidelines, we can reopen it.

Hello,
The thing is I couldn't find anything about this problem in your Documentation, Forums, nor in any closed or open issues.
Could you kindly take a look?

Right, so that doesn't necessarily mean that the next step is to open a new issue.  And, if you do open a new issue, you need to follow the rules:
Asking for Help
In general, the Github issue tracker should only be used for bug reports and feature requests.  If you're just having trouble getting something to work, you should ask in the forums or on Stack Overflow instead.
...

When possible create and link to a minimal, complete, and verifiable example by cloning our JSBin template. Code dumps, zip files, etc are NOT acceptable.
Include relevant screenshots or animations, if possible. Drag your screenshots directly into the forums or issue tracker text box. They will automatically be uploaded and the Markdown to display them will be generated.  Avoid third-party image hosts, or links which require extra clicks to view the image (except IRC, where this is unavoidable).


Whirlwind fury cost per second isn't correct

I'm pretty sure this wasn't like that in 2.3, but the fury cost for Whirlwind seems to have changed in very weird way in 2.4.
I tested a lot of different setups to try and figure out the formula, but I didn't manage to do it in 100% of the case.
What I'm sure so far is that the fury cost is based on the current whirlwind breakpoint : changing your AS while keeping the same breakpoint does not change the fury cost at all.
I also test with 37.4% RCR, but numbers are simply the same multiplied by (1-RCR/100)
The closest formula I found is :
10 * (1-RCR/100) * SQRT(20/(WW_FRAMES+1))
It matches quite closely for anything ranging from 9 to 15 frames. between 16 and 20, it's a little off, and quite off for 8 frames and lower.
There must be some rounding behavior in the actual formula, but I can't figure it out.
I also test the Bul Kathos set, and it seems there is a special condition for it : it simply multiplies the theorical fury cost without the attack speed bonus by 1.3. It means that it now actually cost more to use the BK set that to simply have more AS and hit at the same speed (but the BK set also gives 10 rage/s so that's ok).
The istvan's set has nothing special as it simply adds 6% per stack attack speed to the character sheet.
Here are a sample of the data I gathered for those who'd want to try and figure out the formula :

frames
fury cost per s (+/-0.1) with 0 RCR
formula

20
10.1
9.75

18
10.6
10.25

15
11.4
11.18

13
12
11.95

11
12.8
12.91

9
14.2
14.14

8
14.5 (tested multiple times)
14.91

7
16.4 (also tested a lot)
15.81

6
17.6
16.9

At the 6 frames breakpoint, the in game fury cost with no RCR is only at 17.6 per s, while the sim would calculate 33.33 per s. So even a dirty fix is very much needed :)

According to game data (http://www.d3planner.com/powers/Barbarian_Whirlwind#Continual Resource Cost):
Formula seems to be 7/(APS*3)+1 per tick, which fits your data pretty well. It does, however, seem to indicate that the cost can actually vary within the same breakpoint, unless there is some rounding involved somewhere.

It's perfect ! thank you again :)


Better support for executable "methods"

Methods that call external MPI codes are likely to be commonly used in Colmena.
We currently require packing all pre- and post-processing steps (e.g., reading output files) into a single task with the executable, which means many nodes from a multi-node task could sit idle while pre-/post-processing are completed.
Many workflow systems adopt a model describing executing such tasks as a combination of preprocessor + executable + postprocessor subtasks (e.g., Fireworks, Balsam). We could develop a similar approach by allowing users to assign pre- and post-processing tasks with a "method" and using Parsl to execute them on different resources.

@yadudoc @kylechard I figure to put this on our radar, even though running into the issue described here sounds like a "good problem to have"


Got 0 tweets

I have the same issue. "twitterscraper Trump --limit 1000 --output=tweets.json" gives an empty json file.

same issue :(

Same issue, getting 0 tweets.

Yes, I'm having the same problem, getting the following error message when "getting 0 tweets"
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='twitter.com', port=443): Max retries exceeded with url: /search?f=tweets&vertical=default&q=%23Harami%20since%3A2020-08-22%20until%3A2020-08-24&l=en (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7f5a3decb510>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))

I have the same issue, 0 tweets using query_tweets...

It looks like there is a pull request that addresses this issue. Here is the link. I cloned the repo, and just edited query.py with what @sm-ghavami changed on the pull request and it seems to work just fine. There's likely a better way to do this though.

It doesn't work and return 0 tweet again. please help.

ooh bad, doesn't work function query_tweets from_user() nor query_tweets(), since yesterday. please help.

0 Tweets again. Please help.

ooh bad, doesn't work function query_tweets from_user() nor query_tweets(), since yesterday. please help.
maybe here is information https://blog.twitter.com/developer/en_us/topics/tips/2020/understanding-the-new-tweet-payload.html

The same error.
I agree with you.

Easy Twitter enabled Javascript and shut down the backdor this code used
In detail:
Twitter has been developing since beginning of 2020 a new HTML Frontend with Randomly generated HTML Description Tags.
The scoll mechanism to load new tweets was already changed to work with javascript and unique session ID's in january 2020.
The URL "https://twitter.com/i/search/ with the &max_position=cursor" has been disabled in twitter.

So as i said in April, the software is probably dead.

ooh bad, doesn't work function query_tweets from_user() nor query_tweets(), since yesterday. please help.
maybe here is information https://blog.twitter.com/developer/en_us/topics/tips/2020/understanding-the-new-tweet-payload.html

This doesnt work with the Twitter API not even close.
They changed the HTML Page to avoid non conscented web scrapping.

So is this library just donzo? It's over?

So is this library just donzo? It's over?

Temporarily. Yeah.
Hope it will be back soon

Thought I'd use this for my project. Guess that's not gonna happen anytime soon :(

I think this man found a solution: https://github.com/Foo-Manroot/tweet-feed/issues/1

Same here. Trying the branch of selenium alternatively.

Is there another good similar library that people are using?

same to me

same issue ，twitter disgust,

Even I got 0 Tweets count. I posted a new tweet and still got Zero tweets.  I spent a lot of time understanding the workflow and got 0 !

just use tweepy instead
import tweepy as tw
#Importing twitter access keys from a separate file in this project folder:
from credentials import * #Using keys as a variable
#Setting up Twitter API connection:
def twitter_creds():
"""
Connects to Twitter API.
For confidentiality purposes the access keys are in a separate file in the project folder.
Credential file is saved as credentials.py.
"""

#Authenticate credentials using keys:
auth = tw.OAuthHandler(CONSUMER_KEY, CONSUMER_SECRET) #tells twitter I am valid user
auth.set_access_token(ACCESS_TOKEN, ACCESS_SECRET)

#Connect with API and authenticate:
api = tw.API(auth) #speaks to twitter
return api

#Finding some AI Tweets
search_words = "artificial+intelligence"
date_since = "2020-1-1"
#2020-3-12 outputted 669 tweets
#For fun let's see if we can get a little closer to 1000
#2020-3-12 gives me 673 tweets. 4 tweets in 3 months??? I don't know...
#2020-1-1 gets us to the limit set below of 1000
tweets = tw.Cursor(api.search,
q=search_words,
lang="en",
since=date_since).items(1000)
#for tweet in tweets:
print(tweet.text)

As twitterscraper is (temporarily) dead, I thought I'd share my favorite alternative scraper. @mattwsutherland your solution requires an API-key (which is super hard to get) so unfortunately it's useless to most people here.
Simply go for TweetScraper - for me its working perfectly.
Also see this medium article  providing a useful pandas snippet to set up a nicely formatted dataframe.
Installation for Ubuntu is straightforward as described. For Windows just do the following:
git clone https://github.com/jonbakerfish/TweetScraper.git
conda create -n tweetscraper python=3.7.7 -y
conda activate tweetscraper
conda install -y -c conda-forge scrapy ipython ipdb
pip install scrapy-selenium

Change to directory "TweetScraper" and test with
scrapy crawl TweetScraper -a query="foo,#bar"

Thanks I will definitely 👍 try that
On Wed, Nov 11, 2020, 1:40 AM do-me<EMAIL_ADDRESS>wrote:

As twitterscraper is (temporarily) dead, I thought I'd share my favorite
alternative scraper. @mattwsutherland https://github.com/mattwsutherland
your solution requires an API-key (which is super hard to get) so
unfortunately it's useless to most people here.
Simply go for TweetScraper https://github.com/jonbakerfish/TweetScraper

for me its working perfectly.
Also see this medium article
<EMAIL_ADDRESS>providing a useful pandas snippet to set up a nicely formatted dataframe.

Installation for Ubuntu is straightforward as described. For Windows just
do the following:
git clone https://github.com/jonbakerfish/TweetScraper.git
conda create -n tweetscraper python=3.7.7 -y
conda activate tweetscraper
conda install -y -c conda-forge scrapy ipython ipdb
pip install scrapy-selenium
Change to directory "TweetScraper" and test with
scrapy crawl TweetScraper -a query="foo,#bar"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/taspinar/twitterscraper/issues/344#issuecomment-724939061,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4DDQIMFDUXIU7TEKI5O73SPGM4HANCNFSM4REYB7DQ
.

still, the issue is continuing, Anyone finds a solution or another work around?

@lavarthan
@qarampage
All twitter scrapers dont seem to work anymore. I tried to use selenium to simply scrap maximum tweets between two chosen dates for given quiries. Check my work on : Scweet. let me know if you need any clarification.

I think this scrapper is dead and may not be able untill somebody make changes.

I think this scrapper is dead and may not be able untill somebody make changes.

@Guolin1996  Yes unfortunately ...

@Guolin1996  Yes unfortunately ...

I have the same issue. "twitterscraper Trump --limit 1000 --output=tweets.json" gives an empty json file.

where to set Author API in this code?

I have the same issue. "twitterscraper Trump --limit 1000 --output=tweets.json" gives an empty json file.

where to set Author API in this code?

Commenting to watch, same issue here

I guess it's still dead. Just tried, got 0 tweets.

Still 0 tweets

sad. still 0 tweets. is this related to Elon Musk?


Small button UI fix

Hi @yitongzhang here is the preview link: https://agora-next-qf4mnhbej-voteagora.vercel.app/
Before

Now (it will be the same when cast vote is displayed too)

PR-Codex overview
This PR reduces the max-height of elements in OPProposalPage and OPProposalApprovalPage modules to improve layout consistency.
Detailed summary

Reduced max-height from calc(100vh - 188px) to calc(100vh - 162px) for better layout consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Perfect, thanks!


Improvement: Use npm extend module

Looks like extend is equivalent to the Extend function you have hard-coded in snackbar.js - you could just import that instead; but maybe you're deliberately avoiding external module dependencies?

What's the point on having a dependency only for that matter? I recommend you to read this article about npm dependencies. 😄


DRILL-3855: Added tests to verify filter pushdown and partition pruni…

…ng with UNION operator.
Also, reorganized and standardized the tests within the corresponding folders.

I reverted a commit - which may have been a pre-requisite for your PR. Lets wait until that's put back

@agozhiy, can you please rebase your branch with the latest master, verify if tests are running okay and update here? I'll then have it merged.

Rebased on master. Tests are passing within two updated folders. Couldn't run full Functional regression due to the cluster problem.
@Agirish, could you please review?


build-scaleway-ubuntu1604-armv7-1 connection issue

Build job hung, looks like connectivity problem:
https://ci.adoptopenjdk.net/view/Failing Builds/job/build-scripts/job/jobs/job/jdk14u/job/jdk14u-linux-arm-hotspot/97/console
22:17:34  Cannot contact build-scaleway-ubuntu1604-armv7-1: java.lang.InterruptedException

Duplicate of https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1357


Set a custom color by note

I Would like to set a custom color on the note, to make my cluster notes
I select the color on note screen and a piece of that color appears in the list item
if possible, I would like to create this feature

Hi, can u please give a working diagram, representation of the same so that I can take reference?

Let me show a sample about the colors

Currently someone else is working on updating the UI, not specifically this feature though. I'll reopen this issue once other PR gets merged.

ok, great

Hi, there are a lot of UI enhancements going on in the currently, hence I'll not open this issue currently. You are free to open any other issue of your liking :)

Ok i will look for other things, i found a crash on my emulator when i try to sort by endline, i believe the Date Patterns is different

https://user-images.githubusercontent.com/31870695/194328273-56ca761d-2537-44b9-88c4-2dcf127c0fef.mp4
The branch is up to date with 'origin/master'
I could translate the app to Portuguese if you find it interesting

Really, my branch was not up-to date
https://user-images.githubusercontent.com/31870695/194333116-50aab5b9-1846-46dc-a865-348cd0805784.mp4

I believe the DATE_FORMAT = "E, d MMM yyyy" expects a date like Thursday, 6 October 2022
but the calendar is retuning something like "Thursday, October 6, 2022"


obj-186 ammended landng page text

Simple display wording change

Changes look ok, but unit tests now failing

Test to fix.


Allow charset to be defined in connect string / c'tor

I can't define an initial charset for my connection, instead I need to do for example SET CHARACTER SET 'utf8mb4' as the very first sql instructions. When this is used in combination with mysql pools, it becomes non-trivial as I can't easily hook into when a new connection is created

Good catch. It would be nice for the connection string to support this.
However, it does make me think though, between this and prepared statments (and god knows what else) it would seem that any connection pool, in general (whether mysqln or otherwise), should ideally offer a generic ability to hook into any "connection created/ended" event.
Ultimately, mysqln's connection pools are provided by vibe.d, so I'll check into what vibe.d may (or may conceivably) offer and go from there.  At the very least, mysqln could offer it as an enhancement.

On latest master, the connection pool now supports custom "onNewConnection" callback. So once that's released, this issue (and any similar needs) can at least be worked around easily enough.

Now available in v2.0.0

Seems like this is resolved.

Seems like this is resolved.


fix: Synchronize access to lastPingTime in Ticker struct

Modified the Ticker struct to include a mutex for synchronizing access to the lastPingTime property. This change ensures that the lastPingTime property is accessed safely by multiple goroutines concurrently.

Added lastPingTimeMutex to Ticker struct
Introduced SetLastPingTime and GetLastPingTime methods to safely set and get lastPingTime
Updated readMessage function to use SetLastPingTime to update lastPingTime
Updated checkConnection function to use GetLastPingTime to access lastPingTime

Resolves: Data race issue in Ticker methods
Closes #98

t.triggerError(fmt.Errorf("Error reading data: %v", err)) --
I have also noticed Some the way errors are formatted. It's a convention in go to not use Capital letters in error

I have done all the changes expect (using RWMutex) that was specified. It's better to use sync.Mutex in this specific case.

diff --git a/ticker/ticker.go b/ticker/ticker.go
index 246a6eb..a10361c 100644
--- a/ticker/ticker.go
+++ b/ticker/ticker.go
@@ -9,6 +9,7 @@ import (
 	"math"
 	"net/url"
 	"sync"
+	"sync/atomic"
 	"time"

 	"github.com/gorilla/websocket"
@@ -28,7 +29,7 @@ type Ticker struct {

 	url                 url.URL
 	callbacks           callbacks
-	lastPingTime        time.Time
+	lastPingTime        atomicTime
 	autoReconnect       bool
 	reconnectMaxRetries int
 	reconnectMaxDelay   time.Duration
@@ -39,8 +40,22 @@ type Ticker struct {
 	subscribedTokens map[uint32]Mode

 	cancel context.CancelFunc
+}
+
+// atomicTime is wrapper over time.Time to safely access
+// an updating timestamp concurrently.
+type atomicTime struct {
+	v atomic.Value
+}
+
+// Get returns the current timestamp.
+func (b *atomicTime) Get() time.Time {
+	return b.v.Load().(time.Time)
+}

-	lastPingTimeMutex sync.Mutex
+// Set sets the current timestamp.
+func (b *atomicTime) Set(value time.Time) {
+	b.v.Store(value)
 }

 // callbacks represents callbacks available in ticker.
@@ -313,7 +328,7 @@ func (t *Ticker) ServeWithContext(ctx context.Context) {
 			t.reconnectAttempt = 0

 			// Set current time as last ping time
-			t.lastPingTime = time.Now()
+			t.lastPingTime.Set(time.Now())

 			// Set on close handler
 			t.Conn.SetCloseHandler(t.handleClose)
@@ -341,12 +356,6 @@ func (t *Ticker) handleClose(code int, reason string) error {
 	return nil
 }

-func (t *Ticker) getLastPingTime() time.Time {
-	t.lastPingTimeMutex.Lock()
-	defer t.lastPingTimeMutex.Unlock()
-	return t.lastPingTime
-}
-
 // Trigger callback methods
 func (t *Ticker) triggerError(err error) {
 	if t.callbacks.onError != nil {
@@ -378,12 +387,6 @@ func (t *Ticker) triggerNoReconnect(attempt int) {
 	}
 }

-func (t *Ticker) setLastPingTime(time time.Time) {
-	t.lastPingTimeMutex.Lock()
-	defer t.lastPingTimeMutex.Unlock()
-	t.lastPingTime = time
-}
-
 func (t *Ticker) triggerMessage(messageType int, message []byte) {
 	if t.callbacks.onMessage != nil {
 		t.callbacks.onMessage(messageType, message)
@@ -415,7 +418,7 @@ func (t *Ticker) checkConnection(ctx context.Context, wg *sync.WaitGroup) {

 			// If last ping time is greater then timeout interval then close the
 			// existing connection and reconnect
-			if time.Since(t.getLastPingTime()) > dataTimeoutInterval {
+			if time.Since(t.lastPingTime.Get()) > dataTimeoutInterval {
 				// Close the current connection without waiting for close frame
 				if t.Conn != nil {
 					t.Conn.Close()
@@ -445,7 +448,7 @@ func (t *Ticker) readMessage(ctx context.Context, wg *sync.WaitGroup) {
 			}

 			// Update last ping time to check for connection
-			t.setLastPingTime(time.Now())
+			t.lastPingTime.Set(time.Now())

 			// Trigger message.
 			t.triggerMessage(mType, msg)
@@ -771,4 +774,3 @@ func convertPrice(seg uint32, val float64) float64 {
 		return val / 100.0
 	}
 }
-

I think it might be better to do it like this.

I observed that we missed replacing the setter in one place (as well as missed by me in the previous review). This is because the getter/setter were not on the field but on the ticker struct
It might be better to just use atomic here.

I think so too. Go forward with that 👍

Would you like to update the PR? @abhinandkakkadi
@vividvilla can you also review this once if it seems ok?

I have done the updates you specified and have given as PR.


[GH-685] - JNLP slave is configured to not use all the groups of the jenkins user

…jenkins user

Add attribute 'runit_groups' to jenkins_jnlp_slave resource to configure any of the user's groups defined in this attribute with the runit_service.

Signed-off-by: Jonathan An<EMAIL_ADDRESS>Description
Allows the jenkins_jnlp_slave resource to configure the user's groups as part of the runit_service. Any groups defined in this new resource attribute runit_groups will be configured as long as the user is already part of the group.
This was fixed awhile back for the master resource as part of this issue:
https://github.com/chef-cookbooks/jenkins/issues/205
This is a similar fix for the jnlp slave resource.
Issues Resolved
https://github.com/chef-cookbooks/jenkins/issues/685
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Thanks for putting this together @jonathanan


Correction to sample dpinger command

I think this sample command needs to mention <IP_ADDRESS> as well as <IP_ADDRESS>

Thanks Phil


⚠ Bofrost.be has degraded performance

In a298290, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 975 ms

Resolved: Bofrost.be performance has improved in 5d61b0b after 19 minutes.


Fix crash when using tile atlas merge with recreated alt tile

If u delete an alt tile and re-add it it gets a new id.
Merging calls create_alternative_tile for each tile that recycles old unused ids / packs ids.
Was crashing when trying to get data from an alt tile that did not exist anymore.
Closes: https://github.com/godotengine/godot/issues/77381

Please amend the commit message to make it a meaningful description of what it does (e.g. the same as the PR title which seems fine).

Thanks!

Cherry-picked for 4.0.4.


Dupe with Anti-Barrel

Anti-barrel placed inside of a barrel interface that is connected to an AE2 system via a storage bus, duplicates items by replacing an already existing item stack.

Fixed in 1.1.4


chore: partial revert of 180f5a96 to restore methods for binary compatibility

Methods in CollectionReference, DocumentReference and UpdateBuilder need to keep their Map<String, Object> variants to preserve binary compatibility with any project that was compiled against a version of google-cloud-firestore prior to this change.
Original feature commit: 180f5a96

@schmidt-sebastian please review (I can't assign to you in this new repo yet)

Hm. I thought Java did not have this problem (but after reading http://praitheesh.blogspot.com/2014/09/compatibility-and-api-evolution-in-java.html now disagree with my earlier assessment).


[VL] Close pidBatch after composed in range partitioning

What changes were proposed in this pull request?
In range partitioning we create a batch and offloaded as pidBatch, but no place to close it.
Add batchHolder empty check in VeloxExecutionCtx dtor will find this issue.

@marin-ma could you help take a look?

Thanks for the catch. Is this issue related memory leak? @zhztheplayer

Before ExecutionCtx lifecycle management it's an issue which may cause process memory increase slowly and released when process exit, after newly lifecycle management, it will be released normally.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3220_time.csv
log/native_master_09_20_2023_c721acec6_time.csv
difference
percentage

q1
44.10
43.74
-0.362
99.18%

q2
24.16
24.76
0.592
102.45%

q3
36.35
36.95
0.600
101.65%

q4
41.77
41.94
0.163
100.39%

q5
70.54
70.07
-0.471
99.33%

q6
5.01
6.73
1.721
134.31%

q7
83.54
87.08
3.538
104.24%

q8
81.79
79.39
-2.405
97.06%

q9
117.79
116.92
-0.872
99.26%

q10
47.25
46.95
-0.297
99.37%

q11
19.35
19.26
-0.087
99.55%

q12
26.46
26.14
-0.319
98.80%

q13
50.12
49.26
-0.854
98.30%

q14
15.71
14.99
-0.719
95.42%

q15
28.67
29.01
0.346
101.21%

q16
15.70
15.98
0.280
101.78%

q17
120.59
120.85
0.262
100.22%

q18
162.96
162.91
-0.049
99.97%

q19
12.08
13.36
1.279
110.58%

q20
25.13
31.10
5.963
123.73%

q21
232.98
244.65
11.668
105.01%

q22
15.26
15.41
0.151
100.99%

total
1277.32
1297.44
20.128
101.58%


Template10 1.0.9 on NuGet

When will Template10 1.0.9 will be published on NuGet?

+1.

I've been waiting for two months....Behavior is not compatible with others in 1.0.8.

Yeah, what's the plan for this?

How is Nuget 1.0.9 coming along? I've been using the Github sources since early January without issues, and there appear to be very few issues slated for the 1.0.9 milestone. My personal opinion is that 1.0.9 is as ready as it will ever be, and holding off any longer is counter-productive. There are thousands of fixes in Github sources that are well worth having, and I for one can't live without them.

Yeah! 1.1.0 is on Nuget. Because it has breaking changes to the previous Templates, we had to skip 1.0.9 since all the current templates use 1.0.* in their Project.JSON. If you want the new func, just upgrade to 1.1.0. Make sense?


[Event Request] Create Put-away - OnCodeOnBeforeSearchBin

Describe the request
We need a publisher before the search of a bin is startet
Function:
local procedure "Code"()
MakeCrossDockPutAway();

LineNo := LineNo + 10000;
if Location."Directed Put-away and Pick" then begin
    BinType.CreateBinTypeFilter(BinTypeFilter, 2);
MakeCrossDockPutAway();

 LineNo := LineNo + 10000;
IsHandled := false;
OnCodeOnBeforeCreateBinTypeFilter(PostedWhseReceiptLine, CurrWarehouseActivityLine, CurrWarehouseActivityHeader, CurrLocation, LineNo, BreakbulkNo, BreakbulkFilter, QtyToPutAwayBase, RemQtyToPutAwayBase, BreakPackage, Breakbulk, CrossDockInfo, PutAwayItemUnitOfMeasure, DoNotFillQtytoHandle, EverythingHandled, IsHandled);
if not IsHandled then
  if CurrLocation."Directed Put-away and Pick" then
    BinType.CreateBinTypeFilter(BinTypeFilter, 2);

+ IsHandled := false;
+ OnCodeOnBeforeSearchBin(PostedWhseReceiptLine, CurrWarehouseActivityLine, CurrWarehouseActivityHeader, CurrLocation, LineNo, BreakbulkNo, BreakbulkFilter, QtyToPutAwayBase, RemQtyToPutAwayBase, BreakPackage, Breakbulk, CrossDockInfo, PutAwayItemUnitOfMeasure, DoNotFillQtytoHandle, EverythingHandled, IsHandled);
+ if not IsHandled then
+   repeat

+ [IntegrationEvent(false, false)]
+ local procedure OnCodeOnBeforeSearchBin(PostedWhseRcptLine: Record "Posted Whse. Receipt Line"; var WhseActivLine: Record "Warehouse Activity Line"; var WhseActivHeader: Record "Warehouse Activity Header"; var Location: Record Location;  var LineNo: Integer; BreakbulkNo: Integer; BreakbulkFilter: Boolean ;var QtyToPutAwayBase:Decimal; var RemQtyToPutAwayBase: Decimal; BreakPackage: Boolean; Breakbulk: Boolean; CrossDockInfo: Option; PutAwayItemUOM: Record "Item Unit of Measure"; DoNotFillQtytoHandle: Boolean;var EverythingHandled: Boolean; var IsHandled: Boolean)
+ begin
+ end;

Additional context
We need to skip the Bin Search in some constelations.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14041.


Unclear why there is no location for this request

http://oab.test.cottagelabs.com/request/9wXFSWMcTLaFeWE2W

To be clear, it's unclear because others had it!

Unknown, it just worked for me. We know that sometimes the browser fails to find your location - there is nothing we can do about that, but we now have it coded so at least that does not cause a failure, we just don't get location. This is the first one I have seen on the new plugin where we did not get it though. But I think we should close this issue as there does not seem to be any ongoing problem. Re-open if you think otherwise.

Fine to close. Have suggested we monitor it here #367.


Renaming project

I am working on point-query as an abstraction layer for the data access of pnext. I thought the name was self-explanatory but had to learn that it isn't. How about changing it to pnext-api?

I will go with pnext-io as it makes more sense.


Online documents down

https://docs.angularjs.org/

Uncaught Error: [$injector:modulerr] http://errors.angularjs.org/1.4.0-rc.1/$injector/modulerr?p0=docsApp&p1=Err…pis.com%2Fajax%2Flibs%2Fangularjs%2F1.4.0-rc.1%2Fangular.min.js%3A18%3A381)

Silly me clicked the link and was disappointed to not be able to see what error :dancer:

@mattoz0 maybe you should "Disable cache" and try Ctrl+R ?

Same error for me as well.
Uncaught Error: [$injector:modulerr] http://errors.angularjs.org/1.4.0-rc.1/$injector/modulerr?p0=docsApp&p1=Err…pis.com%2Fajax%2Flibs%2Fangularjs%2F1.4.0-rc.1%2Fangular.min.js%3A18%3A381)

no dice. emptied the cache and hard refreshed. Error persists.

@LearnShare I think what @mattoz0  meant is clicking on the error link ie. http://errors.angularjs.org also pointing to the same doc site which is down.  That is funny :-)

Thats exactly what i meant :) Yes it is quite funny! Except all angular error messages point through this system, so sorry for anyone currently debugging :+1:

@jintoppy @mattoz0  yeah, I got that now, really funny :laughing:

The docsApp has a dependency on ngMaterial but that script isn't there.

I don't think any human deployed the materialize branch, but yes, it looks like jenkins pushed it up to the docs site. That's not ideal :( The weird thing is that the materialize branch has been around for a while and hasn't broken anything yet, so what changed?

@caitp I get the feeling nobody runs the materialize branch in prod mode :)

Blegh. Ci job that updates docs hadn't been running for over a week, so when I brought the ci server back online, it built again and broke something. Working on restoring now

Temporarily fixed by restoring 1.4.0-rc.1 on all instances, and disabled the ci job that re-builds the docs. I'm not sure what went wrong in the build process, but I'll discuss with @petebacondarwin in the morning, so we can re-enable the build to have latest docs.

This is strange. The materialize branch is lying there for months. How come it didn't cause problems before ?

Someone duplicated the angular master jenkins job that automatically pushes build artifacts to docs.*, with the only change being that it built from the material branch :/. So it was building from material branch and then pushing assets to the docs production endpoint. I've disabled this job as well.

I'm looking at the update script now, and it should never pull from a workspace other than the master job, so I'm a little confused. But the snapshot folder is definitely from this build: https://ci.angularjs.org/job/materialize-angular/9/
The zip file from the old snapshot folder in production is angular-1.4.0-build.9+sha.e203264.zip, which is the build number and revision from the materialize-angular job.
I'll have to look at it with fresh eyes in the morning :)

When Jenkins was not available externally, I changed the build scripts to push directly to the code.angularjs.org repository.

That makes sense

This is resolved, right?


Update option passing to reflect the move from tar-stream to archiver

Pass options to the Archiver constructor rather than to its append method, which doesn't support them.

append takes these options https://archiverjs.com/docs/global.html#TarEntryData.

@kevva They're passed as the second argument (data). It doesn't take a third argument.

opts is used in the objectAssign call here, notice the )) at the end. But I don't know if it's intended, it seems to me like the constructor takes a lot more useful options.

opts is used in the objectAssign call here, notice the )) at the end.

D'oh, yes. You're right.
I'd actually prefer to be able to supply both (I wanted to supply prefix today), but, like you say, the constructor seems like the most natural target if we can only supply one.

Closed in favour of #22.


NodesInfoNode struct should include roles field

Including the roles field would allow us to use the SetSnifferCallback to exclude nodes that were say master only.
Which version of Elastic are you using?
6.x
Please describe the expected behavior
The roles would be included in the NodesInfoNode
Please describe the actual behavior
Not There
Any steps to reproduce the behavior?

Create Pull #745

Merged with #745


setAutoChoices(AutoChoices.Enum) does not work

(Original issue 14 created by None on 2011-04-04T18:11:03+00:00)
On a table with adaptive choices, setting autoChoices as Enum is equivalent to AutoChocies.ENABLED.
On a table without adaptive choices, setting autoChoices as Enum is equivalent to AutoChocies.DISABLED.

Original issue reported on code.google.com by luismpena on 2011-04-04 18:11:03

(Original issue 14 last updated on 2015-04-26T00:24:35.205624+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by None on 2011-04-04T18:16:00+00:00)
In addition, if the table is AutoChoices.DISABLED (no adaptive choices), setting a filter
editor as AutoChoices.ENUMS doesn't work either.

Original issue reported on code.google.com by luismpena on 2011-04-04 18:16:00

(Original comment by {u'display_name': u'coderazzi coderazzi', u'account_id': u'557058:790eb198-2ae4-49b4-b920-8d654aa86b3f'} on 2011-04-06T00:21:52+00:00)
The behavior of AutoChoices.ENUMS seems definitely wrong when adaptive choices is enabled
(it is effectively equivalent to AutoChoices.ENABLED).

However, if adaptive choices is disabled, the behavior is fine (only booleans and enumerations
will show choices): the added comment and the second sentence on the initial issue
are therefore wrong.

Original issue reported on code.google.com by coderazzi on 2011-04-06 00:21:52

(Original comment by {u'display_name': u'coderazzi coderazzi', u'account_id': u'557058:790eb198-2ae4-49b4-b920-8d654aa86b3f'} on 2011-04-07T05:35:54+00:00)
Solved on version 4.1.3: on a table with adaptive choices, setting autoChoices as Enum
will only produce choices on columns with boolean or enumeration types.

Original issue reported on code.google.com by coderazzi on 2011-04-07 05:35:54

(Original comment by {u'display_name': u'coderazzi coderazzi', u'account_id': u'557058:790eb198-2ae4-49b4-b920-8d654aa86b3f'} on 2011-11-14T23:13:05+00:00)
(No text was entered with this change)

Original issue reported on code.google.com by coderazzi on 2011-11-14 23:13:05

(Original comment by {u'display_name': u'coderazzi coderazzi', u'account_id': u'557058:790eb198-2ae4-49b4-b920-8d654aa86b3f'} on 2015-04-26T00:24:35.216452+00:00)
Already resolved (previously, before migrating to BitBucket)


Adjust the character's gaze so that it does not peek into blocks above

Fixes #2138

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/406/
Hooray Jenkins reported success with all tests good!

Is there a one-line-explanation on why this does the trick?

Thank you for calling this out.
The bug #2138 was caused by a taller eyeball height introduced with the camera entity.
This PR increases the character physics capsule to 1.8 so that there is some padding around the eyeball height when bonking into the ceiling.  Also, decrease the eyeball height back to 1.6... I think (the character location seems to be 0.9 above ground. So 0.9+0.7=1.6).


PDP: Working with data and schema

Describe this PR
Add 4 new pages related to working with the Data Browser, Query Builder, and Schema tabs in PDP.
Changes

Several renames of files and folders and moving of files are necessary to support a navigation with more entries (basically, high impact on file and folder numbering)
New content

Data BRowser
Query Builder
Schema
Team members
Troubleshooting

It's mostly looking great!
One thing to follow along about the DataBrowser is that we're currently changing the way filters work (tickets CP-2160 and CP-2162). Once they get deployed, sometime next week probably, the filter bit of the DB page will need to be updated a bit.

@martzoukos - one of the tickets has now been dropped? and the other one is still in progress. I'll address the changes when back on Jul 25.

Thanks for the review and for pushing the correct terminology here @janpio . I've fixed what I think to be all incorrect instances. And as mentioned above, added admonitions for my own needs which I think might be useful for novices jumping into Prisma through the Prisma Data Platform.


setupCapabilities.sh and teardownCapabilities.sh do not work anymore

The scripts setupCapabilities.sh and teardownCapabilities.sh do not work in an environment with a bash version 4.1. (RHEL/CentOS 6.x). The following error output is generated:
./setupCapabilities.sh: line 37: conditional binary operator expected
./setupCapabilities.sh: line 37: syntax error near "STREAMS_ZKCONNECT"
./setupCapabilities.sh: line 37: `[[ -v STREAMS_ZKCONNECT ]] && step "using zookeeper at $STREAMS_ZKCONNECT ..."'
and
./teardownCapabilities.sh: line 23: conditional binary operator expected
./teardownCapabilities.sh: line 23: syntax error near "STREAMS_ZKCONNECT"
./teardownCapabilities.sh: line 23: `[[ -v STREAMS_ZKCONNECT ]] && step "using zookeeper at $STREAMS_ZKCONNECT ..."'
The setupCapabilities script also does not work when a Streams domain is already existing which uses the default jmx and sws ports.

The new scripts solve the above mentioned problems.


Adding Docker Registry

This depends on a custom registry image.

@gogodi91  thanks for this PR!  @anton-kasperovich I heard you are working on merging it.  How's it going?

Also does this PR need merging with this: #91

First of all, i want to say @gogodi91 thank you, your pull request gave as great opportunity to start thinking and talking about Docker Registry as part of ADOP. Unfortunately solution from this Pull Request was built on top of custom docker image which is totally fine for specific project needs, but we found a bit different way how to implement Docker Registry via official Docker image without any changes in that area basically. We moved generation of SSL certificates out of the image and made it as part of external bash script, just yesterday i pushed latest version (for now) in my fork - https://github.com/anton-kasperovich/adop-docker-compose/commit/777a9da254cde978bec8841439c1d428238b0ccf
I think we can close both pull requests (as for #91 person can't continue his work on that pull request) in prior of my which i will create today as well.

As Docker Registry and Certbot script was implemented in https://github.com/Accenture/adop-docker-compose/pull/123 PR, i'm closing this one.
Again, thank you @gogodi91 !


Fix shots argument of local_readout_mitigator

Summary

The LocalReadoutMitigator.quasi_probabilities method has an argument shots which is not used in the method. The docstring us updated for this
The method returns an object of type QuasiDistribution. The number of shots is set on that object
The documentation on the return type of counts_probability_vector is updated.

Fixes #9154
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 84.565%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
62422

Relevant Lines:
73815

💛  - Coveralls

I'm not an expert here, but I'm not sure this makes sense: in QuasiDistribution the number of shots is provided as integer. Here it is a boolean? It seems like either the argument type here should also be an integer, otherwise it cannot be safely passed to the QuasiDistribution.

The argument shots of the quasi_probabilities method is annotated as a boolean, but it is was not used at all. In the base class it is indeed annotated as an int. I modified the PR to set the number of shots as an int.
If the value of shots is not None, then it is used as is, otherwise it is calculated as:
probs_vec, shots = counts_probability_vector(
            data, qubit_index=self._qubit_index, clbits=clbits, qubits=qubits
        )

I am not sure what the value of a non-default value for the shots argument is. @ShellyGarion You introduced this code in #6485. Why do we need the shots argument in the quasi_probabilities method?

The shots are needed to calculate the stddev of the mitigated expectation value.
https://github.com/Qiskit/qiskit-terra/blob/4a1a2d0a79ba8cac77275326a32da117e9663c05/qiskit/result/mitigation/local_readout_mitigator.py#L277
https://github.com/Qiskit/qiskit-terra/blob/4a1a2d0a79ba8cac77275326a32da117e9663c05/qiskit/result/mitigation/local_readout_mitigator.py#L163
It's not necessary, hence it's type should be optional.

I think that one should fix this: https://github.com/Qiskit/qiskit-terra/blob/4a1a2d0a79ba8cac77275326a32da117e9663c05/qiskit/result/mitigation/local_readout_mitigator.py#L172
to shots: Optional[int] = False

I'm not sure I understand what user-supplied shots actually mean in this context. The number of shots can be computed (as you do) from the counts data; passing other shots value not consistent with the count data cannot yield meaningful results, unless I'm missing something.
Currently I think the parameter should simply be omitted.

@gadial @ShellyGarion I will remove the shots argument, as it can be calculated from the data and any other value would not make sense.
Should we remove it altogether, or add a deprecation warning?

If you remove shots then it will require a deprecation warning, since it's part of the API:
https://qiskit.org/documentation/stubs/qiskit.result.LocalReadoutMitigator.quasi_probabilities.html#qiskit.result.LocalReadoutMitigator.quasi_probabilities
However, I am not sure if the number of shots can always be calculated from the counts, as the Counts object does not necessarily have to be a dictionary of integers (it can also contain probabilities or quasi-probabilities, I think).

If you remove shots then it will require a deprecation warning, since it's part of the API: https://qiskit.org/documentation/stubs/qiskit.result.LocalReadoutMitigator.quasi_probabilities.html#qiskit.result.LocalReadoutMitigator.quasi_probabilities
However, I am not sure if the number of shots can always be calculated from the counts, as the Counts object does not necessarily have to be a dictionary of integers (it can also contain probabilities or quasi-probabilities, I think).

Ok, in that case I will leave keep the argument (just update the typing from bool to int)

@peendebak - thanks for fixing this!
Perhaps it's worth to add a test to check that shots is handled OK now?
The tests are located here: https://github.com/Qiskit/qiskit-terra/blob/main/test/python/result/test_mitigators.py


Command line args are not correctly parsed

Expected behavior
$ poold --lnd.tlscertpath /some_dir/.lnd/tls.cert

The command above is acceptable.
ref: https://pool.lightning.engineering/install#running-poold
Actual behavior
[hoge@ip-10-0-0-39 ~]$ poold --lnd.tlscertpath /some_dir/.lnd/tls.cert
unknown flag `lnd.tlscertpath'
unknown flag `lnd.tlscertpath'

lnd.tlscertpath option is not accepted.
then I tried:
[hoge@ip-10-0-0-39 ~]$ poold --tlscertpath /some_dir/.lnd/tls.cert
2021-03-17 13:50:43.144 [INF] LLMD: Version: 0.4.1-alpha commit=
2021-03-17 13:50:43.144 [INF] LNDC: Creating lnd connection to localhost:10009
unable to start server: open /home/hoge/.lnd/tls.cert: no such file or directory

The cert file location seems to be passed,  but poold may not use it.

To reproduce
download 0.4.1-alpha arm64binary and boot it with the command above.
System information

Not using lightening terminal. I use it as standalone app.

LND 0.11.1-beta

OS: amazon linux
CPU: AWS Graviton2
binary: ARM64 0.4.1-alpha

The correct flag for setting lnd's TLS certificate path is --lnd.tlspath not --lnd.tlscertpath as is pointed out in the docs you linked and also when using poold --help.


updated p4rt and gribi process names

as part unified grpc server support gribi and p4rt services are moved as service inside grpc server instance.Also,restart of grpc_server will result to restart associates services as well.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Pull Request Functional Test Report for #2794 / 5a190e3d4b1602b0ae66524e50dfe6881e77968f
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Cisco 8000E

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Cisco XRd

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Juniper ncPTX

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Nokia SR Linux

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Openconfig Lemming

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Cisco 8808

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Juniper PTX10008

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Nokia 7250 IXR-10e

TE-8.1: DUT Daemon FailureP4RT-1.2: P4RT Daemon Failure

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.484%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1847

Relevant Lines:
3390

💛  - Coveralls

@NishaSadhasivam-work this PR will work only with the next build in your environment; up to you if you want to merge it now or  wait a week


reduce test warnings

What does this PR do?
Try to ignore all these warnings...
tests/models/test_cpu.py::test_early_stopping_cpu_model | 318s
-- | --
1700 | /drone/src/pytorch_lightning/utilities/distributed.py:23: RuntimeWarning: 2.5854711532592773 is supposed to be a torch.Tensor. Saving checkpoint may not work correctly. HINT: check the value of val_loss in your validation loop | 318s
1701 | warnings.warn(*args, **kwargs)

but it would be better to fix them instead
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

but it would be better to fix them instead

I agree, I don't think we should hide the warnings as it will decrease the motivation to actually fix the problem.

Let's fix the actual problems instead of hiding warning.


Allow docker_sd_configs to optionally discover targets with no network

Proposal
Prometheus' SD config is used by non-Prometheus projects, including Promtail and Grafana Agent. Recently, a Grafana Agent user noticed that they couldn't discover all of their Docker containers for log collection, as a subset of them don't have attached networks.
I think this is an unfortunate side effect of service discovery originally only being intended for metric collection.
Can we identify a way to allow docker_sd_configs (and other SD mechanisms) to discover a broader set of targets so Prometheus' service discovery can be used in more scenarios?
See grafana/alloy#381 for the original discussion.

Hey @roidelapluie,
I am one of those pesky people who have stumbled across this issue in the Grafana agent. We (the company I work for) are open to helping with this if we can. None of us have worked in the Prometheus code base before though.
As you have indicated you're open to having the option, would you be able to offer some quick guidance on where this work needs to be done and how you would like to see it solved?
The relevant code appears to be around here: https://github.com/prometheus/prometheus/blob/main/discovery/moby/docker.go#L207

Hello, any updates on this ? We are really waiting for this feature at our company, is this in your backlog ?

I'm another one of "those pesky people who have stumbled across this issue", first in Promtail and now in Alloy.  My "undiscoverable" container is running as a sidecar in Tailscale.
Docker "inspect" does not report a network for this container.  In comparison, the tailscale container (which does report a network) is discoverable.   (All I want to do is forward the container's logs to loki.)   Are there any workarounds or updates on a fix?
Thanks!


Carousel crossfade doesn't fade-out if text is used instead of image

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
The official documentation uses svgs in crossfade animation, but in real project when we use text, there is a different behaviour observed. In official docs, when one slide is changed to another, the first slide fades out and the second slide fades in. Instead when we use text in slides, the first slide doesn't fade out, but the second slide still fades in.
There is a css rule transition: opacity 0s $carousel-transition-duration, this adds a delay to the opacity transition on first slide and makes the transition-duration 0. I don't know why it doesn't affect the svgs used in the official docs, but I have reproduced the bug on my private server: http://sikhwarriors.xyz/docs/5.2/components/carousel/#crossfade-no-svg -- I am using $carousel-transition-duration: 8s;, and recompiled bootstrap 5.2 scss, you'll see the text 1111111 not fading out and after 8s it just goes to display none and the second slide text 2222222 fades in.  Strangely enough, the example on top using svgs still have the fade out: http://sikhwarriors.xyz/docs/5.2/components/carousel/#crossfade
P.S: I tried to use github pages for the demo, but I was not able to correctly sync root to my reponame:
https://anupamkhosla.github.io/bootstrapCarouselFadeBug/
https://github.com/AnupamKhosla/bootstrapCarouselFadeBug
Reduced test cases
http://sikhwarriors.xyz/docs/5.2/components/carousel/#crossfade-no-svg
What operating system(s) are you seeing the problem on?
Windows, macOS, Android, iOS, Linux
What browser(s) are you seeing the problem on?
Chrome, Safari, Firefox, Microsoft Edge, Opera
What version of Bootstrap are you using?
v5.2

I need to update the variable scss again to 6s transition duraion, please wait. atm the demo is using .6secs instead.

Looking at http://sikhwarriors.xyz/docs/5.2/components/carousel/#crossfade-no-svg i can see the fade behaviour working as expected. Note that for your text examples, you should define an solid background colour for your slides, as it says in the description for crossfades...

Depending on your carousel content (e.g., text only slides), you may want to add .bg-body or some custom CSS to the .carousel-items for proper crossfading.

Note: crossfades work by displaying the next slide on top of the currently active slide, making that next slide progressively more opaque. Once the next slide is fully opaque, the underlying slide gets flipped to display:none. They don't crossfade by making the current slide less opaque.


Make sure to flush styles and head

Fixes https://github.com/zeit/next.js/issues/439

Coverage increased (+0.1%) to 60.885% when pulling 5e4e6ba76850e8e2e0a736ac65cdc81c70f21d5d on fix/flush into 4faa281f238309b8060602cdebcadca7a9d12b02 on master.


Questions about the replication image.

1)Version of docker engine and docker-compose
Docker version 1.10.3, build 9419b24-unsupported
docker-compose version 1.8.1, build 878cff1
2)Config files of harbor, you can get them by packaging "Deploy/config" directory
 The configuration file is the default, I just changed a hostname parameter. (My IP) and execute the command ./prepare  to generate configuration files
3)Log files, you can get them by package the /var/log/harbor/
ignore
++++++++++++++++++++++++++++++++++++++++++++++++++
The above content is the basic information.
I have two Harbor, one within the company, another in the data center.
Container components of the Harbor is OK, login / pull /push is ok!
The Harbor in the data center, use the haproxy to reverse proxy,
haproxy configure
acl repo hdr(host) -i 111.222.333.444
use_backend images_backend if images
backend images_backend
        mode http
        server server01 harbor_ip:80
111.222.333.444 is public IP.
There is no problem of access to111.222.333.444,I can login\create project\create user.....
PS:The Harbor in the data center, In the configuration file, I write the hostname parameter is <IP_ADDRESS>
now,I think from the company's harbor replication image to the data center.
company -->HAproxy -->dataCenter's Harbor
company's harbor :
I added a new remote Destination URL:   http://111.222.333.444 , user,password
Connetion test failed, please check your settings.:Internal Server Error
Now ,I ignore the error.
I added a new replication image policy,Choose the Destination URL,
Error Logs:
2016-11-04T05:10:50Z [INFO] initializing: repository: test/alpine, tags: [], source URL: http://registry:5000, destination URL: http://, insecure: false, destination user: admin
2016-11-04T05:10:50Z [INFO] initialization completed: project: test, repository: test/alpine, tags: [latest], source URL: http://registry:5000, destination URL: http://, insecure: false, destination user: admin
2016-11-04T05:10:50Z [WARNING] the status code is 409 when creating project test on http:// with user admin, try to do next step
2016-11-04T05:10:50Z [INFO] manifest of test/alpine:latest pulled successfully from http://registry:5000: sha256:e0516ccc5c1049100edb6c065cff06175a67a53011f88e946bf449bb70a006db
2016-11-04T05:10:50Z [INFO] all blobs of test/alpine:latest from http://registry:5000: [sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f sha256:baa5d63471ead618ff91ddfacf1e2c81bf0612bfeb1daf00eb0843a41fbfade3]
2016-11-04T05:10:50Z [ERROR] [transfer.go:338]: an error occurred while checking existence of blob sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f of test/alpine:latest on http://: Head http:///v2/test/alpine/blobs/sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f: Get http://<IP_ADDRESS>/service/token?scope=repository%3Atest%2Falpine%3Apull%2Cpush%2C*&service=token-service: dial tcp <IP_ADDRESS>:80: getsockopt: connection refused
2016-11-04T05:10:50Z [INFO] waiting for retrying...
ok,I finished the problem description, thank you very much.
Why do I replication image will go wrong?
Please help me, thank you very much!

Configure the hostname with the public IP 111.222.333.444.


how to download the final pth?

I will release the final pth within one week. Sorry for the late update due to the CVPR deadline.

We have released the Rec-Ling Version of C3-STISR:
https://github.com/zhaominyiz/C3-STISR/releases


feat(datasets): REST API bulk delete

SUMMARY
New REST API endpoint for bulk deleting datasets
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11237 into master will decrease coverage by 5.78%.
The diff coverage is 85.88%.

@@            Coverage Diff             @@
##           master   #11237      +/-   ##
==========================================
- Coverage   65.51%   59.73%   -5.79%
==========================================
  Files         831      394     -437
  Lines       39303    24693   -14610
  Branches     3592        0    -3592
==========================================
- Hits        25751    14750   -11001
+ Misses      13443     9943    -3500
+ Partials      109        0     -109

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
59.73% <85.88%> (-0.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/datasets/dao.py
86.48% <76.47%> (-1.82%)
:arrow_down:

superset/datasets/commands/bulk_delete.py
87.23% <87.23%> (ø)

superset/datasets/api.py
91.87% <88.88%> (-0.38%)
:arrow_down:

superset/datasets/commands/exceptions.py
92.45% <100.00%> (+0.29%)
:arrow_up:

superset/datasets/schemas.py
94.36% <100.00%> (+0.08%)
:arrow_up:

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
31.91% <0.00%> (-59.58%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.32%)
:arrow_down:

... and 461 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e647286...d920fbf. Read the comment docs.


Fix onLayoutChange call

It should be called on the first layout computation too.

no, it shouldn't


Error during installation

Following the instructions and trying to install with python setup.py install --user raises the following error;
Traceback (most recent call last):
  File "/Users/rodrigo/repos/HADDOCK-antibody-antigen/src/ANARCI/build_pipeline/./FormatAlignments.py", line 480, in <module>
    main()
  File "/Users/rodrigo/repos/HADDOCK-antibody-antigen/src/ANARCI/build_pipeline/./FormatAlignments.py", line 454, in main
    jalignments = format_j_genes(jalignments)
  File "/Users/rodrigo/repos/HADDOCK-antibody-antigen/src/ANARCI/build_pipeline/./FormatAlignments.py", line 179, in format_j_genes
    pr = Popen( [ "muscle_macOS", "-in", ffile, "-gapopen", "-10", "-out", al_filename, ], stdout=PIPE, stderr=PIPE )
  File "/Users/rodrigo/software/anaconda3/envs/haddock-antibody/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Users/rodrigo/software/anaconda3/envs/haddock-antibody/lib/python3.9/subprocess.py", line 1821, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'muscle_macOS'
Alignment input open failed.
   couldn't open ./curated_alignments/ALL.stockholm for reading

Error: File existence/permissions problem in trying to open HMM file ./HMMs/ALL.hmm.
HMM file ./HMMs/ALL.hmm not found (nor an .h3m binary of it)

Traceback (most recent call last):
  File "/Users/rodrigo/repos/HADDOCK-antibody-antigen/src/ANARCI/setup.py", line 61, in <module>
    shutil.copy( "curated_alignments/germlines.py", ANARCI_LOC )
  File "/Users/rodrigo/software/anaconda3/envs/haddock-antibody/lib/python3.9/shutil.py", line 427, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/Users/rodrigo/software/anaconda3/envs/haddock-antibody/lib/python3.9/shutil.py", line 264, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: 'curated_alignments/germlines.py'

I guess this issue might be a duplicate of: https://github.com/oxpig/ANARCI/issues/16

~/Programme/ANARCI$ sudo python setup.py install
running install
running build
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/anarci
copying lib/python/anarci/init.py -> build/lib.linux-x86_64-2.7/anarci
copying lib/python/anarci/anarci.py -> build/lib.linux-x86_64-2.7/anarci
copying lib/python/anarci/germlines.py -> build/lib.linux-x86_64-2.7/anarci
copying lib/python/anarci/schemes.py -> build/lib.linux-x86_64-2.7/anarci
running build_scripts
creating build/scripts-2.7
copying and adjusting bin/ANARCI -> build/scripts-2.7
changing mode of build/scripts-2.7/ANARCI from 644 to 755
running install_lib
byte-compiling /usr/local/lib/python2.7/dist-packages/anarci/anarci.py to anarci.pyc
File "/usr/local/lib/python2.7/dist-packages/anarci/anarci.py", line 123
print(">%s"%name, file=f)
^
SyntaxError: invalid syntax
running install_scripts
copying build/scripts-2.7/ANARCI -> /usr/local/bin
changing mode of /usr/local/bin/ANARCI to 755
running install_data
running install_egg_info
Removing /usr/local/lib/python2.7/dist-packages/anarci-1.3.egg-info
Writing /usr/local/lib/python2.7/dist-packages/anarci-1.3.egg-info
'module' object has no attribute 'util'(base)

~/Programme/ANARCI$ sudo python setup.py install running install running build running build_py creating build creating build/lib.linux-x86_64-2.7 creating build/lib.linux-x86_64-2.7/anarci copying lib/python/anarci/init.py -> build/lib.linux-x86_64-2.7/anarci copying lib/python/anarci/anarci.py -> build/lib.linux-x86_64-2.7/anarci copying lib/python/anarci/germlines.py -> build/lib.linux-x86_64-2.7/anarci copying lib/python/anarci/schemes.py -> build/lib.linux-x86_64-2.7/anarci running build_scripts creating build/scripts-2.7 copying and adjusting bin/ANARCI -> build/scripts-2.7 changing mode of build/scripts-2.7/ANARCI from 644 to 755 running install_lib byte-compiling /usr/local/lib/python2.7/dist-packages/anarci/anarci.py to anarci.pyc File "/usr/local/lib/python2.7/dist-packages/anarci/anarci.py", line 123 print(">%s"%name, file=f) ^ SyntaxError: invalid syntax
running install_scripts copying build/scripts-2.7/ANARCI -> /usr/local/bin changing mode of /usr/local/bin/ANARCI to 755 running install_data running install_egg_info Removing /usr/local/lib/python2.7/dist-packages/anarci-1.3.egg-info Writing /usr/local/lib/python2.7/dist-packages/anarci-1.3.egg-info 'module' object has no attribute 'util'(base)

I face a different install error, wondering if anyone knows what is the issue and any solutions?

Your issue might be related to importlib and the deprecated way it is implemented in anarci.
Maybe try running your command without sudo. If that does not help maybe try user installation: https://github.com/oxpig/ANARCI/blob/master/INSTALL

This is indeed a duplicate of #16, thanks @awesome-crab.
@chewyalvin your issue seems to be a different one, maybe best to open a separate issue for it.


L2 Regularization

This is something that was added in 0.6.   Need to confirm that it's better or make it a hyperparam.

0.5 has l2 regularization on z_lin_proj

This definitely breaks D with wgan.  We should probably just not use it if we can get away with that.


As Portal User, I want to select a pre-built action plan for dealing with a legal situation (e.g. Eviction) so that I can review the steps quicker.  (Not part of MVP)

From @czdiana2321 on June 4, 2018 21:59
USER-> Directory/Topic
Acceptance Criteria:

The system is able to provide a pre-built action plan for dealing with a legal situation
Portal User is able to select a pre-built action plan for dealing with a legal situation

Copied from original issue: Microsoft/Access2Justice#132

@KellyeDC - This is new functionality that is not needed for pilot.


Create Matlab.gitignore

Reasons for making this change:
Adding matlab gitignore
Links to documentation supporting these rule changes:
http://www.mathworks.com/matlabcentral/answers/85619-what-is-asv-file-in-matlab-and-how-to-open-it
If this is a new template:

Link to application or project’s homepage: TODO

Closing as trivial. Please reopen if there are further rules that would benefit Matlab users.


How to quote IN-clause values

https://github.com/begriffs/postgrest/pull/854

Think this should've been closed by https://github.com/begriffs/postgrest-docs/commit/e8cdd4463b8fc74811d25cd3aa3472eb5b777a02.


⚠ Bofrost.lu has degraded performance

In a845caa, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1724 ms

Resolved: Bofrost.lu performance has improved in bae14d4 after 9 minutes.


Connections sometimes auto. delete

According to #65:
Third is a bit harder to explain: http://i.imgur.com/RycNoE5.jpg
For some reason sometimes when it adds a new system it creates and suddently delete the connection. I can add it manually but whenever I touch the system icon to drag it around it becomes red and I didn't find any way to remove that background. It's as if someone selected the systems but they are not. In the pic above I haven't dragged or moved around only two system: C3 J164034 and HS Vahunomi. Hope it's clear.

Should be fixed in v1.0.0RC1. Please provide feedback if there are still any problems.


updateSchedule method does not refresh recurrenceRule and attendees fields

Hi! I am trying to use updateSchedule method to refresh recurrenceRule and attendees fields, but it does not work. Could you fix it?

@AlenaPliusnina
Please write detailed information about the issue, following the issue template.
Closing this issue due to lack of information.


Dependency of dependencies

I'm not sure if this is supported, but we have the following directory structure:
├───deployment-stamps
│   ├───eu1
│   │   ├───dev
│   │   │   └───aa
│   │   │       └───my-service
│   │   └───test
│   │       ├───aa
│   │       └───ab
│   └───na1
│       └───dev
│           └───ac
└───global
    ├───dev
    └───prod

And we basically want to call terragrunt from each level of the hierarchy, so from within eu1/dev, from eu1/dev/aa and even from  eu1/dev/aa/my-service. However, it only works from the first two directories described. If I want to run terragrunt validate in the my-service folder, then we hit the bug that it doesn't not correctly resolve recursive dependencies. Dependencies are as follows:

global/dev does not have any dependencies
eu1/dev has dependency on global/dev
eu1/dev/aa has a dependency on global/dev and  eu1/dev
eu1/dev/aa/my-service has a dependency on eu1/dev/aa and eu1/dev, but NOT global/dev

Still, whenever we try to run terragrunt inside that module (and I have tried a lot, running terragrunt run-all from one level above, directly running inside that directory, etc), we get this error:
time=2021-06-04T09:46:55Z level=error msg=Module /home/vsts/work/1/s/deployments/deployment-stamps/eu1/dev/aa/my-service has finished with an error: /home/vsts/work/1/s/deployments/deployment-stamps/global/dev does not exist prefix=[/home/vsts/work/1/s/deployments/deployment-stamps/eu1/dev/aa/my-service]
time=2021-06-04T09:46:55Z level=error msg=Encountered the following errors:
/home/vsts/work/1/s/deployments/deployment-stamps/global/dev does not exist
time=2021-06-04T09:46:55Z level=error msg=Unable to determine underlying exit code, so Terragrunt will exit with error code 1

The error is pretty obvious, it uses the wrong pathes to resolve the dependency, so my question is: Is that something that is not supported? Or do I do something wrong here?
As said, running terragrunt from other levels of the hierarchy does work, so I expect the dependency definitions itself are correct.

eu1/dev has dependency on global/dev

This part doesn't make sense to me. How are you linking the dependencies in this case? From my understanding of the folder structure, eu1/dev is a parent folder and thus it doesn't quite make sense to me how the dependencies are linked there.
Can you add terragrunt.hcl files to your folder hierarchy and a brief description of how they are linked, as well as where the dependency blocks are defined?

@yorinasub17 Thanks for your answer and sorry for my bad bug report. The problem was a configuration error on my end I think.
Basically each of the layers had a custom remote_state definition except the my-service layer which includeed the backend from the terragrunt.hcl in aa. For whatever reason, that doesnt work, as you get this issue if you want to trigger terrragrunt apply from the deepest level - in this case aa - of the hierarchy. Now we defined the remote_state block at the root of our folder structure and everything works as expected.

Thanks for closing the loop!


remove incorrect use of 'scope'

This is a blocker for https://github.com/dlang/dmd/pull/5903

This is a blocking issue for progress on scope. Please don't delay pulling it.

Auto-merge toggled on

Thanks!


[PAAS-250]Add zkPath like param in decision sink

Thanks @eruizgar

:shipit:

Comment accepted. Will treat it ASAP.


On reading QR go directly to profile if a single result returned

Describe the feature request.
Extend the search by barcode register option to support

[optional] profile-launch to define the profile to open if a single result is returned

After reading a QR code

If profile-launch is defined and there is 1 result, open the result using the profile defined in profile-launch
If there are 0 or >=2 results

show the results in the register
place the value read from the QR code as the text in the search query field

Update register docs to add a description of this option

Additional context
Blocked by https://github.com/opensrp/fhircore/issues/3351
Acceptance criteria

[ ] After reading a QR code it

[ ] Goes to the profile of whatever is specified in the profile-launch field with that QR code if there is one result
[ ] Goes to the register and shows the QR code in the search field and no results if there are no results
[ ] Goes to the register and shows the QR code in the search field and multiple results if there are >1 results

Area path

Modify the register config to enable the QR code reader and add a profile-launch key and value
Open the register
Read QR codes using the button in the register search bar

Implementation plan (For Engineers)

[ ] Figure out how to define the profile to load when the search returns a single result

The new properties -> RegisterContentConfig.searchByQrCode and RegisterConfiguration.onSearchByQrResultActions

@Serializable
data class RegisterContentConfig(
  val separator: String? = null,
  val display: String? = null,
  val rules: List<RuleConfig>? = null,
  val visible: Boolean? = null,
  val computedRules: List<String>? = null,
  val searchByQrCode: Boolean? = null
)

// RegisterConfiguration

@Serializable
data class RegisterConfiguration(
  override var appId: String,
  override var configType: String = ConfigType.Register.name,
  val id: String,
  val registerTitle: String? = null,
  val fhirResource: FhirResourceConfig,
  val secondaryResources: List<FhirResourceConfig>? = null,
  val searchBar: RegisterContentConfig? = null,
  val registerCard: RegisterCardConfig = RegisterCardConfig(),
  val fabActions: List<NavigationMenuConfig> = emptyList(),
  val noResults: NoResultsConfig? = null,
  val pageSize: Int = 10,
  val activeResourceFilters: List<ActiveResourceFilterConfig> =
    listOf(
      ActiveResourceFilterConfig(resourceType = ResourceType.Patient, active = true),
      ActiveResourceFilterConfig(resourceType = ResourceType.Group, active = true),
    ),
  val configRules: List<RuleConfig>? = null,
  val registerFilter: RegisterFilterConfig? = null,
  val filterDataByRelatedEntityLocation: Boolean = false,
  val topScreenSection: TopScreenSectionConfig? = null,
  val onSearchByQrResultActions: List<ActionConfig>? = null
) : Configuration()

The new properties -> RegisterContentConfig.searchByQrCode and RegisterConfiguration.onSearchByQrResultActions
@Serializable
data class RegisterContentConfig(
  val separator: String? = null,
  val display: String? = null,
  val rules: List<RuleConfig>? = null,
  val visible: Boolean? = null,
  val computedRules: List<String>? = null,
  val searchByQrCode: Boolean? = null
)

// RegisterConfiguration

@Serializable
data class RegisterConfiguration(
  override var appId: String,
  override var configType: String = ConfigType.Register.name,
  val id: String,
  val registerTitle: String? = null,
  val fhirResource: FhirResourceConfig,
  val secondaryResources: List<FhirResourceConfig>? = null,
  val searchBar: RegisterContentConfig? = null,
  val registerCard: RegisterCardConfig = RegisterCardConfig(),
  val fabActions: List<NavigationMenuConfig> = emptyList(),
  val noResults: NoResultsConfig? = null,
  val pageSize: Int = 10,
  val activeResourceFilters: List<ActiveResourceFilterConfig> =
    listOf(
      ActiveResourceFilterConfig(resourceType = ResourceType.Patient, active = true),
      ActiveResourceFilterConfig(resourceType = ResourceType.Group, active = true),
    ),
  val configRules: List<RuleConfig>? = null,
  val registerFilter: RegisterFilterConfig? = null,
  val filterDataByRelatedEntityLocation: Boolean = false,
  val topScreenSection: TopScreenSectionConfig? = null,
  val onSearchByQrResultActions: List<ActionConfig>? = null
) : Configuration()

Some questions:

Can we rename this to be clear it is only when a single result is returned?

onSearchByQrSingleResultAction: ActionConfig? = null

Also, can you explain why it needs a list? It is not clear to me how we could perform more than 1 action

Some questions:

Can we rename this to be clear it is only when a single result is returned?
onSearchByQrSingleResultAction: ActionConfig? = null

Also, can you explain why it needs a list? It is not clear to me how we could perform more than 1 action

On the first question, I agree with the new name it's more descriptive. On the second question, conventionally we have been providing a list of actions, in anticipation that an event would trigger more than one workflow (which might be the case for particular use cases; but not on this one).

On the list of actions, I'm strictly against that but I want to understand the use case, can you give some example use cases?

An example use case is when you'd want to copy the text extracted by the barcode scanner to the clipboard via the COPY_TEXT action and then launch the profile via the LAUNCH_PROFILE action.

OK got it, makes sense


trigger mouse event on cluster marker

I have map and inside a polygon i have some markers as cluster. now my problem is how i can add mouse ebvent to each cluster ?
I need to get markers information in a cluster (by mouseOver or click) and show detail of markers inside infoWindow, do you have any suggestion?
I tried but i am not successful.

Please use the chat for development support questions. Github is mainly for bugfixes and feature requests. Thank you!


Add desired state changed event filter to all controllers

What problem are you facing?
With https://github.com/crossplane/crossplane-runtime/pull/372, we have introduced a DesiredStateChanged to the xp runtime, which would filter out status update events.
We need to add this as an event filter to all controllers. Similar to https://github.com/crossplane-contrib/provider-aws/pull/1705
How could Crossplane help solve your problem?
Add desired state changed event filter to all controllers.

@turkenh may I work on this one?

@turkenh may I work on this one?

Sure, that would be great 👍


Cleanup build configuration

Coverage remained the same at 73.272% when pulling 9327258ece4138614a6cd23bbe0017e1c8419f07 on clean-build-config into 5a758c4906e76c2ba38e3a494ebfa7b0c08ac27a on master.

Superseded https://github.com/kishikawakatsumi/UICKeyChainStore/pull/135


[Bug] Unable to use "Report or Give Feedback" button

A community member has reported the that the "Report or Give Feedback" button on the nearCatalog application details page fails to work.
Issue 1:

go to https://near.org/nearcatalog.near/widget/Index?id=daorecords
Click Website - this takes you to an invalid site.  Perhaps this URL needs to be updated or this application removed.

Issue 2:

Click the Action menu dropdown -> Report or Give Feedback
This reload the same page in a new tab.  What should happen here?

Awesome, thanks so much for fixing!!


Add canExecuteSu

Fixes #2
Code provided by @eenchev

Thanks for the contribution!

@beast Is this issues tested and executed in NPM?


Adding timeout for OpenTsdbSender

This prevents blocking forever on trying to send data to tsdb.
We can't make the timeout configurable without breaking binary compatibility, so we'll just hard-code it now for a minute and schedule configurability (along with possibly a bigger refactoring) for 0.7

Current coverage is 80.22%

Merging #281 into master will decrease coverage by -2.49% as of 92ccdc7

@@            master    #281   diff @@
======================================
  Files           54      70    +16
  Stmts         2973    3534   +561
  Branches         0     441   +441
  Methods
======================================
+ Hit           2459    2835   +376
  Partial          0       0
- Missed         514     699   +185

Review entire Coverage Diff as of 92ccdc7

Powered by Codecov. Updated on successful CI builds.

:+1:

:+1:

as a temp solution, i think this is fine :+1:


Ruby: Update gemspec homepage org from google to grpc

grpc.gemspec and grpc-tools.gemspec homepage link is outdated (was google org).
So, I fixed it.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @euglena1215 isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

Signed CLA.

I signed it

I signed it

Why was this PR not merged?
homepage links are still outdated.
https://github.com/grpc/grpc/blob/1630efd8ab3d2ff4b006f1288fde1be5c29dc651/grpc.gemspec#L11
https://github.com/grpc/grpc/blob/1630efd8ab3d2ff4b006f1288fde1be5c29dc651/src/ruby/tools/grpc-tools.gemspec#L9
This change reduces unnecessary redirection when someone visits this gem's homepage
via https://rubygems.org/gems/grpc and https://rubygems.org/gems/grpc-tools,
or some tools or APIs that use the gem's metadata.
Would you consider merging this PR? Thanks!

@apolcyn Sorry for direct pin, could you please consider merging this PR?


Version 1.2.1 Causes Crash

Not sure why, but can share how to reproduce easily with docker
Base uses contourpy==1.2.0
docker run --rm -it --entrypoint bash quantconnect/lean:16466
git clone --depth 1 --branch 16466 https://github.com/QuantConnect/Lean.git && cd Lean && dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 QuantConnect.Lean.sln && dotnet test ./Tests/bin/Release/QuantConnect.Tests.dll --filter "FullyQualifiedName=QuantConnect.Tests.Python.PythonPackagesTests" --blame-hang-timeout 120seconds --blame-crash --verbosity detailed

Install 1.2.1
pip install contourpy==1.2.1

Re run tests boom
dotnet test ./Tests/bin/Release/QuantConnect.Tests.dll --filter "FullyQualifiedName=QuantConnect.Tests.Python.PythonPackagesTests" --blame-hang-timeout 120seconds --blame-crash --verbosity detailed

Can you provide information (log files perhaps) on what python packages and versions you have installed, and what code you are running when the crash occurs?

Hey!
pip freeze output: packages.txt
The code being run is this one https://github.com/QuantConnect/Lean/blob/master/Tests/Python/PythonPackagesTests.cs

Just fyi sorry I'm not 100% convinced contourpy 1.2.1 is to blame here yet, there might be something else off, it's just the new version started reproducing the issue,