HBASE-23636 Disable table may hang when regionserver stop or abort.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 48s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
8m  7s
master passed

+1 :green_heart:
compile
1m 10s
master passed

+1 :green_heart:
checkstyle
1m 50s
master passed

+1 :green_heart:
shadedjars
6m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 55s
master passed

+0 :ok:
spotbugs
6m 27s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
6m 24s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 55s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

-1 :x:
checkstyle
1m 49s
hbase-server: The patch generated 4 new + 11 unchanged - 0 fixed = 15 total (was 11)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
6m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
21m 47s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 42s
the patch passed

+1 :green_heart:
findbugs
6m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
164m 35s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

245m 17s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/982

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4553cfcc868c 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-982/out/precommit/personality/provided.sh

git revision
master / 85ecdd10a9

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/1/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/1/testReport/

Max. process+thread count
5370 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 59s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
checkstyle
1m 31s
master passed

+1 :green_heart:
shadedjars
4m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

+0 :ok:
spotbugs
5m  6s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m  5s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 37s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
checkstyle
1m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 59s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 37s
the patch passed

+1 :green_heart:
findbugs
5m 15s
the patch passed

_ Other Tests _

-1 :x:
unit
184m 22s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

250m  9s

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestRegionReplicasWithRestartScenarios

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/982

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 7cf05c83e51d 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-982/out/precommit/personality/provided.sh

git revision
master / ab9766599d

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/2/testReport/

Max. process+thread count
5488 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
7m 37s
master passed

+1 :green_heart:
compile
1m 19s
master passed

+1 :green_heart:
checkstyle
1m 53s
master passed

+1 :green_heart:
shadedjars
6m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
master passed

+0 :ok:
spotbugs
6m  6s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
6m  3s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 52s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
checkstyle
1m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 34s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 35s
the patch passed

+1 :green_heart:
findbugs
4m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
156m 54s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

228m  1s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/982

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 09f5ab03e091 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-982/out/precommit/personality/provided.sh

git revision
master / ab9766599d

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/3/testReport/

Max. process+thread count
5342 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

We have some special logics in DisableTableProcedure...
Let me take a look on why these logics do not work...

Oh, I know. The problem here is that, if we just skip the region in SCP, the region will remaining in OPEN state so we will try to close it in DTP and it will never succeed...
Let me see the patch again...

@Apache9 @virajjasani  Thanks for the reviewing.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 57s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
checkstyle
1m 31s
master passed

+1 :green_heart:
shadedjars
5m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

+0 :ok:
spotbugs
4m 52s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 51s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 31s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
checkstyle
1m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 34s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 35s
the patch passed

+1 :green_heart:
findbugs
4m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
158m 35s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

224m 35s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/982

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux adb96e356770 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-982/out/precommit/personality/provided.sh

git revision
master / ab9766599d

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/4/testReport/

Max. process+thread count
5415 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


cmake: fix Findspdlog.cmake

Refactor/fix the macro to find spdlog.

Use pkg-config --cflags-only-I to get include paths to use as hints
when finding the .h file.
Use pkg-config --cflags-only-other to get compile definitions
required by the distro, for example:

fedora >=32 needs -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL
(SPDLOG_FMT_EXTERNAL is used when fmt library needs to be linked
ubuntu 20.04 needs only -DSPDLOG_COMPILED_LIB

Use cmake variables set by pkg-config for libraries needed to link
with

pkgcfg_lib_PC_SPDLOG_spdlog will be path to libspdlog.so
pkgcfg_lib_PC_SPDLOG_fmt will be path to libfmt.so (if used)

Coverage decreased (-0.03%) to 68.179% when pulling 66fd43fd28ad16c5fdd512a88a2ca8c5f6e55292 on rrojo/fix-find-spdlog into 31d1db6c30590b87d28ae746d044866df8b8dcc0 on master.


Onboarding Designs (initial implementation)

The implementation steps for creating the onboarding UI flow are as follows:

First launch checks (can happen in parallel with other issues)

Add preference infrastructure #13
Configure UI to display during first launch

Add splash screen (this can happen in parallel with other issues) #14
Add launcher icon (this can happen in parallel with other issues) #20
Add preference infrastructure #13 (blocks #28)
Add SDK integration #28 (blocks #16 and #17)
Unstyled onboarding flow — To speed initial implementation, the flow will have the correct layouts but will use default Material components

Introduction #15
Import a wallet (this is being implemented first, because it'll get us a functional wallet faster) #17
Create a wallet (this will be a medium to large effort and can be broken down into multiple tasks) #16

Style onboarding flow #18

@ccjernigan Where should we look to view this build so we can approve this ticket?

@geffenz
Immediately: Each linked issue should have a linked pull request, and each pull request should generally have screenshots attached.
Upcoming: We're working on automated builds that you should be able to install #176 although all the parts aren't completely hooked up yet.

Moved this to the corresponding epic "onboarding flow"


Use "Lem" variable modding improvements

Self-explanatory, we should keep improving the calculation using the new variable modding interface.

This has been done in release 2.9.0


NTR: ubiquinone biosynthetic process

Hi GO,
while updating the ubiquinone biosynthesis pathway in human based on PMID:38425362, I realized that some terms are missing and that another term would need some update.
PMID:38425362 provides good evidence for missing steps in the pathway.
Thanks
Sylvain

First, I would like to update the name and definition of GO:0106364. Ubiquinone can have different chain length, and this term is specific for n=6, the S.cerevisiae ubiquinone. I would propose to make a generic reaction for polyprenyl, which is not species specific
FROM:
GO:0106364; F:4-hydroxy-3-all-trans-hexaprenylbenzoate oxygenase activity
4-hydroxy-3-all-trans-hexaprenylbenzoate + 2 H+ + O2 + 2 reduced [2Fe-2S]-[ferredoxin] = 3,4-dihydroxy-5-all-trans-hexaprenylbenzoate + H2O + 2 oxidized [2Fe-2S]-[ferredoxin]
TO:
GO:0106364; F:4-hydroxy-3-all-trans-polyprenylbenzoate oxygenase activity
4-hydroxy-3-all-trans-polyprenylbenzoate + 2 H+ + O2 + 2 reduced [2Fe-2S]-[ferredoxin] = 3,4-dihydroxy-5-all-trans-polyprenylbenzoate + H2O + 2 oxidized [2Fe-2S]-[ferredoxin]
Xref:
Rhea:81195
PMID:38425362

2 papers show the activity of COQ4 and I would need a new GO term

Name: 4-hydroxy-3-methoxy-5-polyprenylbenzoate decarboxylase
Definition: Catalysis of the reaction: a 4-hydroxy-3-methoxy-5-(all-trans-polyprenyl)benzoate + H(+) = a 2-methoxy-6-(all-trans-polyprenyl)phenol + CO2
Child of GO:0016831 carboxy-lyase activity
Child of GO:0006744; P:ubiquinone biosynthetic process
Xref
PMID:38295803
PMID:38425362
EC <IP_ADDRESS>
Rhea:81179

PMID:38425362 shows a second activity for COQ6 and I would need a new GO term
Name: 2-methoxy-6-polyprenolphenol 4-hydroxylase
Definition: Catalysis of the reaction: 2-methoxy-6-(all-trans-polyprenyl)phenol + 2 reduced [2Fe-2S]-[ferredoxin] + O2 + 2 H(+) = 2-methoxy-6-(all-trans-polyprenyl)benzene-1,4-diol + 2 oxidized [2Fe-2S]-[ferredoxin] + H2O

Child of GO:0016713 oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, reduced iron-sulfur protein as one donor, and incorporation of one atom of oxygen
Child of GO:0006744; P:ubiquinone biosynthetic process
Xref
EC=<IP_ADDRESS>
Rhea:81183
PMID:38425362

PMID:38425362 shows a new activity for COQ3 and I would need a new GO term

Name:  3-demethylubiquinone 3-O-methyltransferase
Definition: Catalysis of the reaction: a 3-demethylubiquinone + S-adenosyl-L-methionine = a ubiquinone + S-adenosyl-L-homocysteine
Child of GO:0006744; P:ubiquinone biosynthetic process
Child of  GO:0008171 O-methyltransferase activity
Child of  GO:0008757 S-adenosylmethionine-dependent methyltransferase activity
Xref
Rhea:81215
PMID:38425362

Thanks @sylvainpoux I've recently updated other terms in this pathway, so I'll deal with this ticket too.

Note: EC:<IP_ADDRESS> and EC:<IP_ADDRESS> are not yet available on https://enzyme.expasy.org, so these will have to be added as xrefs later.

+[Term]
+id: GO:0120537
+name: 3-demethylubiquinone 3-O-methyltransferase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: a 3-demethylubiquinone + S-adenosyl-L-methionine = a ubiquinone + S-adenosyl-L-homocysteine." [PMID:38425362, RHEA:81215]
+xref: RHEA:81215 {source="skos:exactMatch"}
+is_a: GO:0008171 ! O-methyltransferase activity
+is_a: GO:0008757 ! S-adenosylmethionine-dependent methyltransferase activity
+relationship: part_of GO:0006744 ! ubiquinone biosynthetic process
+property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/29459" xsd:anyURI
+created_by: sjm
+creation_date: 2024-12-18T09:25:15Z
+
+[Term]
+id: GO:0120538
+name: 2-methoxy-6-polyprenolphenol 4-hydroxylase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: 2-methoxy-6-(all-trans-polyprenyl)phenol + 2 reduced [2Fe-2S]-[ferredoxin] + O2 + 2 H+ = 2-methoxy-6-(all-trans-polyprenyl)benzene-1,4-diol + 2 oxidized [2Fe-2S]-[ferredoxin] + H2O." [PMID:38425362, RHEA:81183]
+xref: RHEA:81183 {source="skos:exactMatch"}
+is_a: GO:0016713 ! oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, reduced iron-sulfur protein as one donor, and incorporation of one atom of oxygen
+relationship: part_of GO:0006744 ! ubiquinone biosynthetic process
+property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/29459" xsd:anyURI
+created_by: sjm
+creation_date: 2024-12-18T09:30:52Z
+
+[Term]
+id: GO:0120539
+name: 4-hydroxy-3-methoxy-5-polyprenylbenzoate decarboxylase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: a 4-hydroxy-3-methoxy-5-(all-trans-polyprenyl)benzoate + H+ = a 2-methoxy-6-(all-trans-polyprenyl)phenol + CO2." [PMID:38295803, PMID:38425362, RHEA:81179]
+xref: RHEA:81179 {source="skos:exactMatch"}
+is_a: GO:0016831 ! carboxy-lyase activity
+relationship: part_of GO:0006744 ! ubiquinone biosynthetic process
+property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/29459" xsd:anyURI
+created_by: sjm
+creation_date: 2024-12-18T09:36:09Z
+

Updated term:
id: GO:0106364
name: 4-hydroxy-3-all-trans-polyprenylbenzoate oxygenase activity
namespace: molecular_function
def: "Catalysis of the reaction: 4-hydroxy-3-all-trans-polyprenylbenzoate + 2 H+ + O2 + 2 reduced [2Fe-2S]-[ferredoxin] = 3,4-dihydroxy-5-all-trans-polyprenylbenzoate + H2O + 2 oxidized [2Fe-2S]-[ferredoxin]." [PMID:38425362, RHEA:81195]
synonym: "4-hydroxy-3-all-trans-hexaprenylbenzoate oxygenase activity" NARROW []
xref: MetaCyc:RXN3O-58 {source="skos:narrowMatch"}
xref: RHEA:81195 {source="skos:exactMatch"}
is_a: GO:0016713 ! oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, reduced iron-sulfur protein as one donor, and incorporation of one atom of oxygen
property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/27952" xsd:anyURI
property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/29459" xsd:anyURI
created_by: hjd
creation_date: 2021-02-09T15:52:26Z

pinging myself @ValWood for after the hols!

@sjm41  could you also align with this ticket opened by @Argoudpuy currently assigned to @raymond91105 and close the older one if necessary, it looks redundant
https://github.com/geneontology/go-ontology/issues/29305

ignore previous comment. that one is waiting for EC number

Thanks @ValWood  and @sjm41
That was quick
Val, I will make the GO-CAM model early January when GO terms are available in Noctua.
Sylvain

GO:0036169 3-methoxy-4-hydroxy-5-decaprenylbenzoic acid decarboxylase activity has a solo Reactome TAS annotation. @deustp01 Could it be move to GO:0120539 4-hydroxy-3-methoxy-5-polyprenylbenzoate decarboxylase activity?

@raymond91125 @sjm41 @deustp01
I think it makes senses to only create generic reaction for polyprenyl, then we can specifiy the precise substrate using ChEBI in annotation extensions or GO-CAM models.
Thanks
Sylvain

@sylvainpoux yes, fully agree we should only have the polyprenyl term here. The GO:0036169 deca term already exists, so needs to be merged into the new poly term we created.

GO:0036169 3-methoxy-4-hydroxy-5-decaprenylbenzoic acid decarboxylase activity has a solo Reactome TAS annotation. @deustp01 Could it be move to GO:0120539 4-hydroxy-3-methoxy-5-polyprenylbenzoate decarboxylase activity?

@raymond91125 I believe Peter is now on vacation, but (automatically?) having this TAS annotation moved to the new GO:0120539 term should be fine.

Please let me know if there is more to be done or this is ready to be closed. Thanks.


Add precisions about Zone Redundant support per plan

The article is great but didn't mention as prerequisite to have the right plan.
For instance Premium V3 P0 doesn't propose the feature while P1/P2/P3 does and all the PmV3 does not.
Exhaustive list is available within the Azure portal when you create a plan and select a plan viewing by "Feature view".

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: af3abb96-1944-58ae-2476-f347b854477a
Version Independent ID: 91d8fc2a-4ee2-7b5b-5ce9-de05d30ef4e2
Content: Reliability in Azure App Service
Content Source: articles/reliability/reliability-app-service.md
Service: app-service
GitHub Login: @anaharris-ms
Microsoft Alias: anaharris

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Hi @olileger,
Thanks for submitting this issue. I've contacted the PG to see if we can add that info.

@RyanHill-MSFT @olileger. From the product team: All of the Premium v3 SKUs, including P0v3 and Pmv3 support ZR. This looks to be just a portal bug. They've reached out to our UX team to get this fixed.


Compilation issues inside radio_spinel_impl.hpp

The compilation issues seems to be caused by commit id 33f15fac2faad5aa31920a24cbbc8b2fc49dbe08
Compilation issues:
../openthread/src/lib/spinel/radio_spinel_impl.hpp: In member function 'otError ot::Spinel::RadioSpinel<InterfaceType, ProcessContextType>::RestoreDatasetFromNcp()':
../openthread/src/lib/spinel/radio_spinel_impl.hpp:420:19: error: no matching function for call to 'ot::Instance::Get()'
  420 |     Instance::Get().template Get<SettingsDriver>().Init();
      |                   ^
In file included from ../openthread/src/lib/spinel/radio_spinel_impl.hpp:45,
                 from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
                 from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/core/common/instance.hpp:298:43: note: candidate: 'template<class Type> Type& ot::Instance::Get()'
  298 |     template <typename Type> inline Type &Get(void);
      |                                           ^~~
../openthread/src/core/common/instance.hpp:298:43: note:   template argument deduction/substitution failed:
In file included from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
                 from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/lib/spinel/radio_spinel_impl.hpp:420:19: note:   couldn't deduce template parameter 'Type'
  420 |     Instance::Get().template Get<SettingsDriver>().Init();
      |                   ^
../openthread/src/lib/spinel/radio_spinel_impl.hpp:420:48: error: expected primary-expression before '>' token
  420 |     Instance::Get().template Get<SettingsDriver>().Init();
      |                                                ^
../openthread/src/lib/spinel/radio_spinel_impl.hpp:420:50: error: expected primary-expression before ')' token
  420 |     Instance::Get().template Get<SettingsDriver>().Init();
      |                                                  ^
../openthread/src/lib/spinel/radio_spinel_impl.hpp:429:19: error: no matching function for call to 'ot::Instance::Get()'
  429 |     Instance::Get().template Get<SettingsDriver>().Deinit();
      |                   ^
In file included from ../openthread/src/lib/spinel/radio_spinel_impl.hpp:45,
                 from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
                 from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/core/common/instance.hpp:298:43: note: candidate: 'template<class Type> Type& ot::Instance::Get()'
  298 |     template <typename Type> inline Type &Get(void);
      |                                           ^~~
../openthread/src/core/common/instance.hpp:298:43: note:   template argument deduction/substitution failed:
In file included from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,

@doru91 , thanks for raising this issue. Can you provide more details on your toolchain? This may be due to a toolchain issue not supporting this use of template key word.
As FYI - our continuous integration currently includes build checks against arm-gcc versions (4, 5, 6, 7, 9), gcc (5, 6, 7, 8, 9, 10), and clang (6, 7, 8, 9).

doru@ubuntu:~/Desktop/private_repos/ot-nxp$ /usr/local/bin/arm-none-eabi-g++ -v
Using built-in specs.
COLLECT_GCC=/usr/local/bin/arm-none-eabi-g++
COLLECT_LTO_WRAPPER=/opt/gcc-arm-none-eabi-9-2020-q2-update/bin/../lib/gcc/arm-none-eabi/9.3.1/lto-wrapper
Target: arm-none-eabi
Configured with: /mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/src/gcc/configure --target=arm-none-eabi --prefix=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/install-native --libexecdir=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/install-native/lib --infodir=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/install-native/share/doc/gcc-arm-none-eabi/info --mandir=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/install-native/share/doc/gcc-arm-none-eabi/man --htmldir=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/install-native/share/doc/gcc-arm-none-eabi/html --pdfdir=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/install-native/share/doc/gcc-arm-none-eabi/pdf --enable-languages=c,c++ --enable-plugins --disable-decimal-float --disable-libffi --disable-libgomp --disable-libmudflap --disable-libquadmath --disable-libssp --disable-libstdcxx-pch --disable-nls --disable-shared --disable-threads --disable-tls --with-gnu-as --with-gnu-ld --with-newlib --with-headers=yes --with-python-dir=share/gcc-arm-none-eabi --with-sysroot=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/install-native/arm-none-eabi --build=x86_64-linux-gnu --host=x86_64-linux-gnu --with-gmp=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/build-native/host-libs/usr --with-mpfr=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/build-native/host-libs/usr --with-mpc=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/build-native/host-libs/usr --with-isl=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/build-native/host-libs/usr --with-libelf=/mnt/workspace/workspace/GCC-9-pipeline/jenkins-GCC-9-pipeline-200_20200521_1590053374/build-native/host-libs/usr --with-host-libstdcxx='-static-libgcc -Wl,-Bstatic,-lstdc++,-Bdynamic -lm' --with-pkgversion='GNU Arm Embedded Toolchain 9-2020-q2-update' --with-multilib-list=rmprofile,aprofile
Thread model: single
gcc version 9.3.1 20200408 (release) (GNU Arm Embedded Toolchain 9-2020-q2-update)

@doru91 , is it possible for you to provide the build command and any additional details so that we can reproduce?
The latest build checks passed using arm-gcc-9 - https://github.com/openthread/openthread/actions/runs/614628402. Are you aware of any differences that may trigger this build issue?

@doru91 , one theory/guess is that somehow the radio_spinel_impl.hpp is being compiled in a build config without either OPENTHRED_FTD or OPENTHREAD_MTD being defined. The Instance::Get<SettingsDriver>() (which seems to be causing the compile error) is under the check #if OPENTHREAD_MTD || OPENTHREAD_FTD.

This is the compilation command:
2/8] Building CXX object src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj
FAILED: src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj
/usr/local/bin/arm-none-eabi-g++  -DOPENTHREAD_CONFIG_ASSERT_ENABLE=1 -DOPENTHREAD_CONFIG_BACKBONE_ROUTER_DUA_NDPROXYING_ENABLE=0 -DOPENTHREAD_CONFIG_BACKBONE_ROUTER_MULTICAST_ROUTING_ENABLE=0 -DOPENTHREAD_CONFIG_ENABLE_BUILTIN_MBEDTLS=1 -DOPENTHREAD_CONFIG_ENABLE_BUILTIN_MBEDTLS_MANAGEMENT=1 -DOPENTHREAD_CONFIG_FILE="openthread-core-rt1060-config.h" -DOPENTHREAD_CONFIG_IP6_SLAAC_ENABLE=1 -DOPENTHREAD_CONFIG_NCP_UART_ENABLE=1 -DOPENTHREAD_CONFIG_THREAD_VERSION=OT_THREAD_VERSION_1_1 -DOPENTHREAD_CORE_CONFIG_PLATFORM_CHECK_FILE="openthread-core-rt1060-config-check.h" -DOPENTHREAD_PROJECT_CORE_CONFIG_FILE="openthread-core-rt1060-config.h" -DOPENTHREAD_SPINEL_CONFIG_OPENTHREAD_MESSAGE_ENABLE=0 -DOPENTHREAD_SPINEL_CONFIG_RCP_RESTORATION_MAX_COUNT=0 -DPACKAGE_NAME="OPENTHREAD" -DPACKAGE_VERSION="0.01.00" -I../openthread/examples/platforms -I../openthread/third_party/mbedtls/repo/include -I../openthread/include -I../openthread/src -I../openthread/src/core -Iopenthread/third_party/mbedtls -I../src/imx_rt/rt1060 -Iopenthread/etc/cmake -I../openthread/etc/cmake -mthumb -fdata-sections -ffunction-sections -mcpu=cortex-m0plus -mfloat-abi=soft -fno-exceptions -fno-rtti -Os -DNDEBUG   -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-function -Wno-unused-parameter -Wno-empty-body -std=gnu++11 -MD -MT src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj -MF src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj.d -o src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj -c ../src/imx_rt/rt1060/radio.cpp
I tried to manually add -DOPENTHREAD_FTD=1 in the compilation command but I still get the error.

How to reproduce the issue:
doru@ubuntu:~/Desktop/public_repos/$ git clone https://github.com/doru91/ot-nxp.git
doru@ubuntu:~/Desktop/public_repos/$ cd ot-nxp
doru@ubuntu:~/Desktop/public_repos/ot-nxp$ git submodule update --init
doru@ubuntu:~/Desktop/public_repos/ot-nxp$ export NXP_RT1060_SDK_ROOT=/home/doru/Desktop/private_repos/ot-nxp/third_party/rt1060_sdk/RT1060_SDK/
doru@ubuntu:~/Desktop/public_repos/ot-nxp$ touch /home/doru/Desktop/private_repos/ot-nxp/third_party/rt1060_sdk/RT1060_SDK/SW-Content-Register.txt
doru@ubuntu:~/Desktop/public_repos/ot-nxp$ touch /home/doru/Desktop/private_repos/ot-nxp/third_party/rt1060_sdk/RT1060_SDK/TODO.c
doru@ubuntu:~/Desktop/public_repos/ot-nxp$ ./script/build_rt1060

@doru91 , I get an error "Could not found a valid SDK package!" Is doru91/ot-nxp/third_party supposed to include some additional submodules? Or what are the steps necessary to obtain a valid SDK package?

@jwhui, NXP_RT1060_SDK_ROOT is supposed to reference a valid SDK. This is still work in progress so for the moment we are simulating an SDK inside third_party/rt1060_sdk/RT1060_SDK/ by creating TODO.c file and SW-Content-Register.txt. I copy-pasted the above instructions in my Ubuntu 20 terminal and the compilation process starts:
doru@ubuntu:~/Desktop/public_repos/ot-nxp$ ./script/build_rt1060

OT_CMAKE_NINJA_TARGET=
++ pwd

readonly OT_SRCDIR=/home/doru/Desktop/public_repos/ot-nxp

OT_SRCDIR=/home/doru/Desktop/public_repos/ot-nxp

OT_OPTIONS=("-DCMAKE_TOOLCHAIN_FILE=src/imx_rt/rt1060/arm-none-eabi.cmake" "-DCMAKE_BUILD_TYPE=MinSizeRel" "-DOT_PLATFORM=external" "-DOT_SLAAC=ON")

readonly OT_OPTIONS

main

'[' -z /home/doru/Desktop/private_repos/ot-nxp/third_party/rt1060_sdk/RT1060_SDK/ ']'

'[' -f /home/doru/Desktop/private_repos/ot-nxp/third_party/rt1060_sdk/RT1060_SDK//SW-Content-Register.txt ']'

SDK_RELEASE=ON

echo 'NXP_RT1060_SDK_ROOT set to ' /home/doru/Desktop/private_repos/ot-nxp/third_party/rt1060_sdk/RT1060_SDK/
NXP_RT1060_SDK_ROOT set to  /home/doru/Desktop/private_repos/ot-nxp/third_party/rt1060_sdk/RT1060_SDK/

options=("${OT_OPTIONS[@]}")

local options

options+=("$@")

options+=' -DSDK_RELEASE=ON'

build '-DCMAKE_TOOLCHAIN_FILE=src/imx_rt/rt1060/arm-none-eabi.cmake -DSDK_RELEASE=ON' -DCMAKE_BUILD_TYPE=MinSizeRel -DOT_PLATFORM=external -DOT_SLAAC=ON

local builddir=build

mkdir -p build

cd build

cmake -GNinja -DOT_APP_NCP=OFF -DOT_BUILD_RT=ON -DOT_BUILD_RT1060=ON -DOT_COMPILE_WARNING_AS_ERROR=ON -DCMAKE_TOOLCHAIN_FILE=src/imx_rt/rt1060/arm-none-eabi.cmake -DSDK_RELEASE=ON -DCMAKE_BUILD_TYPE=MinSizeRel -DOT_PLATFORM=external -DOT_SLAAC=ON /home/doru/Desktop/public_repos/ot-nxp
-- The C compiler identification is GNU 9.3.1
-- The CXX compiler identification is GNU 9.3.1
-- Check for working C compiler: /usr/local/bin/arm-none-eabi-gcc
-- Check for working C compiler: /usr/local/bin/arm-none-eabi-gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/local/bin/arm-none-eabi-g++
-- Check for working CXX compiler: /usr/local/bin/arm-none-eabi-g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
-- CMake build type: MinSizeRel
-- Version: 0.01.00
CMake Warning (dev) at openthread/third_party/mbedtls/repo/CMakeLists.txt:5 (project):
Policy CMP0048 is not set: project() command manages VERSION variables.
Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
command to set the policy and suppress this warning.
The following variable(s) would be set to empty:
PROJECT_VERSION
PROJECT_VERSION_MAJOR
PROJECT_VERSION_MINOR
PROJECT_VERSION_PATCH
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found PythonInterp: /usr/bin/python (found version "2.7.18")
-- Found Perl: /usr/bin/perl (found version "5.30.0")
-- Configuring done
-- Generating done
-- Build files have been written to: /home/doru/Desktop/public_repos/ot-nxp/build

[[ -n '' ]]
ninja
[15/558] cd /home/doru/Desktop/public_repos/ot-nxp/b...public_repos/ot-nxp/openthread/etc/cmake/print.cmake
OPENTHREAD_CONFIG_ASSERT_ENABLE=1
OPENTHREAD_CONFIG_BACKBONE_ROUTER_DUA_NDPROXYING_ENABLE=0
OPENTHREAD_CONFIG_BACKBONE_ROUTER_MULTICAST_ROUTING_ENABLE=0
OPENTHREAD_CONFIG_ENABLE_BUILTIN_MBEDTLS=1
OPENTHREAD_CONFIG_ENABLE_BUILTIN_MBEDTLS_MANAGEMENT=1
OPENTHREAD_CONFIG_IP6_SLAAC_ENABLE=1
OPENTHREAD_SPINEL_CONFIG_RCP_RESTORATION_MAX_COUNT=0
PACKAGE_NAME=OPENTHREAD
PACKAGE_VERSION=0.01.00
OPENTHREAD_CONFIG_THREAD_VERSION=OT_THREAD_VERSION_1_1
OPENTHREAD_CONFIG_NCP_UART_ENABLE=1
OPENTHREAD_CONFIG_FILE=openthread-core-rt1060-config.h
OPENTHREAD_PROJECT_CORE_CONFIG_FILE=openthread-core-rt1060-config.h
OPENTHREAD_CORE_CONFIG_PLATFORM_CHECK_FILE=openthread-core-rt1060-config-check.h
OPENTHREAD_CONFIG_NCP_UART_ENABLE=1
[552/558] Building CXX object src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj
FAILED: src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj
/usr/local/bin/arm-none-eabi-g++  -DOPENTHREAD_CONFIG_ASSERT_ENABLE=1 -DOPENTHREAD_CONFIG_BACKBONE_ROUTER_DUA_NDPROXYING_ENABLE=0 -DOPENTHREAD_CONFIG_BACKBONE_ROUTER_MULTICAST_ROUTING_ENABLE=0 -DOPENTHREAD_CONFIG_ENABLE_BUILTIN_MBEDTLS=1 -DOPENTHREAD_CONFIG_ENABLE_BUILTIN_MBEDTLS_MANAGEMENT=1 -DOPENTHREAD_CONFIG_FILE="openthread-core-rt1060-config.h" -DOPENTHREAD_CONFIG_IP6_SLAAC_ENABLE=1 -DOPENTHREAD_CONFIG_NCP_UART_ENABLE=1 -DOPENTHREAD_CONFIG_THREAD_VERSION=OT_THREAD_VERSION_1_1 -DOPENTHREAD_CORE_CONFIG_PLATFORM_CHECK_FILE="openthread-core-rt1060-config-check.h" -DOPENTHREAD_PROJECT_CORE_CONFIG_FILE="openthread-core-rt1060-config.h" -DOPENTHREAD_SPINEL_CONFIG_OPENTHREAD_MESSAGE_ENABLE=0 -DOPENTHREAD_SPINEL_CONFIG_RCP_RESTORATION_MAX_COUNT=0 -DPACKAGE_NAME="OPENTHREAD" -DPACKAGE_VERSION="0.01.00" -I../openthread/examples/platforms -I../openthread/third_party/mbedtls/repo/include -I../openthread/include -I../openthread/src -I../openthread/src/core -Iopenthread/third_party/mbedtls -I../src/imx_rt/rt1060 -Iopenthread/etc/cmake -I../openthread/etc/cmake -mthumb -fdata-sections -ffunction-sections -mcpu=cortex-m0plus -mfloat-abi=soft -fno-exceptions -fno-rtti -Os -DNDEBUG   -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-function -Wno-unused-parameter -Wno-empty-body -std=gnu++11 -MD -MT src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj -MF src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj.d -o src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj -c ../src/imx_rt/rt1060/radio.cpp
In file included from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/lib/spinel/radio_spinel_impl.hpp: In member function 'otError ot::Spinel::RadioSpinel<InterfaceType, ProcessContextType>::RestoreDatasetFromNcp()':
../openthread/src/lib/spinel/radio_spinel_impl.hpp:420:19: error: no matching function for call to 'ot::Instance::Get()'
420 |     Instance::Get().template Get().Init();
|                   ^
In file included from ../openthread/src/lib/spinel/radio_spinel_impl.hpp:45,
from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/core/common/instance.hpp:298:43: note: candidate: 'template Type& ot::Instance::Get()'
298 |     template  inline Type &Get(void);
|                                           ^~~
../openthread/src/core/common/instance.hpp:298:43: note:   template argument deduction/substitution failed:
In file included from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/lib/spinel/radio_spinel_impl.hpp:420:19: note:   couldn't deduce template parameter 'Type'
420 |     Instance::Get().template Get().Init();
|                   ^
../openthread/src/lib/spinel/radio_spinel_impl.hpp:420:48: error: expected primary-expression before '>' token
420 |     Instance::Get().template Get().Init();
|                                                ^
../openthread/src/lib/spinel/radio_spinel_impl.hpp:420:50: error: expected primary-expression before ')' token
420 |     Instance::Get().template Get().Init();
|                                                  ^
../openthread/src/lib/spinel/radio_spinel_impl.hpp:429:19: error: no matching function for call to 'ot::Instance::Get()'
429 |     Instance::Get().template Get().Deinit();
|                   ^
In file included from ../openthread/src/lib/spinel/radio_spinel_impl.hpp:45,
from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/core/common/instance.hpp:298:43: note: candidate: 'template Type& ot::Instance::Get()'
298 |     template  inline Type &Get(void);
|                                           ^~~
../openthread/src/core/common/instance.hpp:298:43: note:   template argument deduction/substitution failed:
In file included from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/lib/spinel/radio_spinel_impl.hpp:429:19: note:   couldn't deduce template parameter 'Type'
429 |     Instance::Get().template Get().Deinit();
|                   ^
../openthread/src/lib/spinel/radio_spinel_impl.hpp:429:48: error: expected primary-expression before '>' token
429 |     Instance::Get().template Get().Deinit();
|                                                ^
../openthread/src/lib/spinel/radio_spinel_impl.hpp:429:50: error: expected primary-expression before ')' token
429 |     Instance::Get().template Get().Deinit();
|                                                  ^
In file included from ../openthread/src/lib/hdlc/hdlc.hpp:42,
from ../openthread/src/lib/spinel/spinel_interface.hpp:38,
from ../openthread/src/lib/spinel/radio_spinel.hpp:41,
from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/lib/spinel/radio_spinel_impl.hpp: In member function 'otError ot::Spinel::RadioSpinel<InterfaceType, ProcessContextType>::ThreadDatasetHandler(const uint8_t*, uint16_t)':
../openthread/src/lib/spinel/radio_spinel_impl.hpp:734:41: error: no matching function for call to 'ot::Instance::Get()'
734 |     SuccessOrExit(error = Instance::Get().template Get().Set(
|                                         ^
../openthread/src/core/common/code_utils.hpp:107:14: note: in definition of macro 'SuccessOrExit'
107 |         if ((aStatus) != 0)
|              ^~~~~~~
In file included from ../openthread/src/lib/spinel/radio_spinel_impl.hpp:45,
from ../openthread/src/lib/spinel/radio_spinel.hpp:1015,
from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/core/common/instance.hpp:298:43: note: candidate: 'template Type& ot::Instance::Get()'
298 |     template  inline Type &Get(void);
|                                           ^~~
../openthread/src/core/common/instance.hpp:298:43: note:   template argument deduction/substitution failed:
In file included from ../openthread/src/lib/hdlc/hdlc.hpp:42,
from ../openthread/src/lib/spinel/spinel_interface.hpp:38,
from ../openthread/src/lib/spinel/radio_spinel.hpp:41,
from ../src/imx_rt/rt1060/radio.cpp:39:
../openthread/src/lib/spinel/radio_spinel_impl.hpp:734:41: note:   couldn't deduce template parameter 'Type'
734 |     SuccessOrExit(error = Instance::Get().template Get().Set(
|                                         ^
../openthread/src/core/common/code_utils.hpp:107:14: note: in definition of macro 'SuccessOrExit'
107 |         if ((aStatus) != 0)
|              ^~~~~~~
../openthread/src/lib/spinel/radio_spinel_impl.hpp:734:70: error: expected primary-expression before '>' token
734 |     SuccessOrExit(error = Instance::Get().template Get().Set(
|                                                                      ^
../openthread/src/core/common/code_utils.hpp:107:14: note: in definition of macro 'SuccessOrExit'
107 |         if ((aStatus) != 0)
|              ^~~~~~~
../openthread/src/lib/spinel/radio_spinel_impl.hpp:734:72: error: expected primary-expression before ')' token
734 |     SuccessOrExit(error = Instance::Get().template Get().Set(
|                                                                        ^
../openthread/src/core/common/code_utils.hpp:107:14: note: in definition of macro 'SuccessOrExit'
107 |         if ((aStatus) != 0)
|              ^~~~~~~
ninja: build stopped: subcommand failed.

@doru91 , I think your last comment adds more confidence in the theory/guess from https://github.com/openthread/openthread/issues/6224#issuecomment-789116593, i.e. the OPENTHREAD_FTD or OPENTHREAD_MTD are not in the list of defines when building some file that is including "radio_spinel.hpp" (which itself includes "radio_spinel_impl.hpp").
Here is the flow I see:

This file that is being compiled: src/imx_rt/rt1060/radio.cpp
Here is the compiler call to arm-none-eabi-g++ (I wrapped the lines at 100 chars so we can see all lines more easily).

/usr/local/bin/arm-none-eabi-g++  -DOPENTHREAD_CONFIG_ASSERT_ENABLE=1
/-DOPENTHREAD_CONFIG_BACKBONE_ROUTER_DUA_NDPROXYING_ENABLE=0
/-DOPENTHREAD_CONFIG_BACKBONE_ROUTER_MULTICAST_ROUTING_ENABLE=0
/-DOPENTHREAD_CONFIG_ENABLE_BUILTIN_MBEDTLS=1
/-DOPENTHREAD_CONFIG_ENABLE_BUILTIN_MBEDTLS_MANAGEMENT=1
/-DOPENTHREAD_CONFIG_FILE=\"openthread-core-rt1060-config.h\" -DOPENTHREAD_CONFIG_IP6_SLAAC_ENABLE=1
/-DOPENTHREAD_CONFIG_NCP_UART_ENABLE=1 -DOPENTHREAD_CONFIG_THREAD_VERSION=OT_THREAD_VERSION_1_1
/-DOPENTHREAD_CORE_CONFIG_PLATFORM_CHECK_FILE=\"openthread-core-rt1060-config-check.h\"
/-DOPENTHREAD_PROJECT_CORE_CONFIG_FILE=\"openthread-core-rt1060-config.h\"
/-DOPENTHREAD_SPINEL_CONFIG_OPENTHREAD_MESSAGE_ENABLE=0
/-DOPENTHREAD_SPINEL_CONFIG_RCP_RESTORATION_MAX_COUNT=0 -DPACKAGE_NAME=\"OPENTHREAD\"
/-DPACKAGE_VERSION=\"0.01.00\" -I../openthread/examples/platforms
/-I../openthread/third_party/mbedtls/repo/include -I../openthread/include -I../openthread/src
/-I../openthread/src/core -Iopenthread/third_party/mbedtls -I../src/imx_rt/rt1060
/-Iopenthread/etc/cmake -I../openthread/etc/cmake -mthumb -fdata-sections -ffunction-sections
/-mcpu=cortex-m0plus -mfloat-abi=soft -fno-exceptions -fno-rtti -Os -DNDEBUG   -Wno-unknown-pragmas
/-Wno-sign-compare -Wno-unused-function -Wno-unused-parameter -Wno-empty-body -std=gnu++11 -MD -MT
/src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj -MF
/src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj.d -o
/src/imx_rt/rt1060/CMakeFiles/openthread-rt1060.dir/radio.cpp.obj -c ../src/imx_rt/rt1060/radio.cpp

We don't seem to have OPENTHREAD_MTD or OPENTHREAD_FTD among the defines listed here.
The specialization of template Instance::Get<> for Instance::Get<SettingsDriver>()) is available under #if OPENTHREAD_MTD || OPENTHREAD_FTD check.

I think @jwhui  and I found the root-cause here. 😃
The error is actually with the non-template static Instance &Instance::Get(void) method. This method is available under single OT instance config and the build here seems to be enabling OPENTHREAD_CONFIG_MULTIPLE_INSTANCE_ENABLE in its config.
In addition to this, I think we still need to have OPENTHREAD_FTD (or OPENTHREAD_MTD) defined in the config build as well (to ensure that we can get to Get<SettingsDriver>() specialization).
@doru91, for a quick fix, you can consider disabling OPENTHREAD_CONFIG_MULTIPLE_INSTANCE_ENABLE (do you need/use the multi instance behavior?)
We will also submit a change to make the implementation work under multi-instance config in addition single instance case.

Thanks a lot for your help. Disabled OPENTHREAD_CONFIG_MULTIPLE_INSTANCE_ENABLE for the moment and the code compiles.

@doru91 , can you please help provide more info on your use-case and if/why you may need the MUTILPLE_INSTANCE feature?
In general, would recommend not using MULTIPLE_INSTANCE feature:

Enabling this, requires all OT core objects to track the ot::Instance they belong to.
This adds a lot of memory and code overhead.

Agree, we don't need the MULTIPLE_INSTANCE feature. So this issue can be closed from my side.


Largest Rectangle in Histogram

Given an array of integers heights representing the histogram's bar height where the width of each bar is 1, return the area of the largest rectangle in the histogram.
Example 1:

Input: heights = [2,1,5,6,2,3]
Output: 10
Explanation: The above is a histogram where width of each bar is 1.
The largest rectangle is shown in the red area, which has an area = 10 units.
Example 2:

Input: heights = [2,4]
Output: 4
Constraints:
1 <= heights.length <= 105
0 <= heights[i] <= 104

Nikita Miraje, SY ENTC
Can you plz assign this issue to me???

@NikitaMiraje l you have already been assigned an issue. You can work only on 1 issue at a time. Once you complete it you may work on this issue if no one else comments on it

I Shreeya Barge , SY IT would like to work on this issue

Pranoti Patil
S Y Comp
I would like to work on this issue.

@NikitaMiraje pls go ahead, upload solution in solutions folder, deadline 25 March, 11:59pm

This is how you create a proper PR by mentioning the issue no. in description and not in title of PR. @NikitaMiraje . PLease take care next time


Cover "Identities" item

The "Identities" item on the API-M menu doesn't seem to be explicitly covered in the docs anywhere.
We have the docs for the AAD and B2C options and it seems like the Facebook, Google, Microsoft, Twitter options are maybe just preset versions of the delegation presented here, but that needs to be covered if possible.
Also I'm pretty sure the "Username and password" default option is just describing what you can setup for developers per the following link, if not please clarify.
https://docs.microsoft.com/en-us/azure/api-management/api-management-howto-create-or-invite-developers
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ca841cb-5a8f-ca9a-ec92-d088f43e0401
Version Independent ID: a56f0f32-4fb5-55b5-54d4-d26b39384316
Content: How to delegate user registration and product subscription
Content Source: articles/api-management/api-management-howto-setup-delegation.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

@dcbrown16 Thanks you for posting your question. We will review this and provide an update as appropriate.

@dcbrown16 Yes. You are right.
The Identities tab is for handling authentication of developers (users of your API). The various options like Username/Password, AAD, AAD B2C, Facebook, etc. are all different ways you can have developers wanting to use your APIs to login and subscribe.
Alternatively, you can also delegate this responsibility to your own system as mentioned in this doc.
I believe the steps for the public OAuth providers should be pretty straight forward but would probably be best to cover at least one of them in the docs.
We will assign this issue to the content author for review.

Thanks @PramodValavala-MSFT ! My customer was just looking for a straightforward list of all the ways you can set up authentication for the dev portal, and it was surprisingly difficult to gather these methods, as they are sort of distributed in the ToC under Secure your API, Customize Developer Experience, and Manage Production at least.
If I may make a suggestion, a Concepts page about authentication covering both front-end and back-end options with relevant links would be fantastic.

@dcbrown16 That sounds like a good idea. Thanks for the feedback!

Thanks @dcbrown16 - that's a good idea. I have created a work item on our side and we will triage and track it offline.
#please-close

Ok, thanks for planning on that @mikebudzynski!


v2_routeConvention - routes/_index/route.tsx not rendering

What version of Remix are you using?
1.13.0
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce

Create a new Remix project ("Just the basics + Remix App Server")
Enable v2_routeConvention
Move routes/index.tsx to routes/_index/route.tsx

Expected Behavior
When running locally (npm run dev), accessing http://localhost:3000 renders the routes/_index/route.tsx route.
Actual Behavior
When running locally (npm run dev), accessing http://localhost:3000 doesn't render the routes/_index/route.tsx route.
Here is a repo reproducing the issue: https://github.com/mccuna/routes-v2-index-folder

The same issue can be experience with any route folder name, aka. app/routes/tracks/route.tsx also doesn't work. It doesn't need to be named _index.

In my case those two commands yield the following:
path\to\APP\ROUTES
└───tracks

This is the windows output. The actual tree structure is:
├───tracks
│   └───route.tsx
├───_index.tsx
├───_users.auth.apple.tsx
├───_users.auth.facebook.tsx
├───_users.auth.google.tsx
├───_users.auth.spotify.tsx
├───_users.login.tsx
├───_users.logout.tsx
├───_users.profile.tsx
├───_users.register.tsx
├───_users.secret.edit.tsx
├───_users.secret.new.tsx
├───auditions.tsx
├───competitions.tsx
├───oauth.callbacks.$provider.tsx
├───oauth.callbacks.apple.tsx
├───oauth.callbacks.facebook.tsx
├───oauth.callbacks.google.tsx
├───oauth.callbacks.spotify.tsx
├───oauth.delete.facebook.tsx
└───oauth.wait-for-session.tsx

<Routes>
  <Route file="root.tsx">
    <Route path="auditions" file="routes\\auditions.tsx" />
    <Route path="competitions" file="routes\\competitions.tsx" />
    <Route path="oauth/callbacks/:provider" file="routes\\oauth.callbacks.$provider.tsx" />
    <Route path="oauth/callbacks/apple" file="routes\\oauth.callbacks.apple.ts" />
    <Route path="oauth/callbacks/facebook" file="routes\\oauth.callbacks.facebook.ts" />
    <Route path="oauth/callbacks/google" file="routes\\oauth.callbacks.google.ts" />
    <Route path="oauth/callbacks/spotify" file="routes\\oauth.callbacks.spotify.ts" />
    <Route path="oauth/delete/facebook" file="routes\\oauth.delete.facebook.ts" />
    <Route path="oauth/wait-for-session" file="routes\\oauth.wait-for-session.tsx" />
    <Route index file="routes\\_index.tsx" />
    <Route path="auth/apple" file="routes\\_users.auth.apple.ts" />
    <Route path="auth/facebook" file="routes\\_users.auth.facebook.ts" />
    <Route path="auth/google" file="routes\\_users.auth.google.ts" />
    <Route path="auth/spotify" file="routes\\_users.auth.spotify.ts" />
    <Route path="login" file="routes\\_users.login.tsx" />
    <Route path="logout" file="routes\\_users.logout.ts" />
    <Route path="profile" file="routes\\_users.profile.tsx" />
    <Route path="register" file="routes\\_users.register.tsx" />
    <Route path="secret/edit" file="routes\\_users.secret.edit.tsx" />
    <Route path="secret/new" file="routes\\_users.secret.new.tsx" />
  </Route>
</Routes>

This can be simplified to:
├───tracks
│   └───route.tsx
├───_index.tsx
├───_users.login.tsx
└───auditions.tsx

<Routes>
  <Route file="root.tsx">
    <Route path="auditions" file="routes\\auditions.tsx" />
    <Route index file="routes\\_index.tsx" />
    <Route path="login" file="routes\\_users.login.tsx" />
  </Route>
</Routes>

As you can see I followed the docs to migrate to v2, which is why I barely have any folders, because it only tells you you can use folders at the end of the article.

Yes, v2 routing is flat routes.
The entire route is either the filename .tsx or the foldername /index.tsx
Nesting is denoted by . separators where the child route has a matching prefix with the parent route.
Like users.edit.tsx would nest under users.tsx because of the common prefix users
Anyway, with that being said, it looks like you're missing some of the layout routes.
You should have a _users.tsx route, the parent layout for all the _users.* routes. Pathless layouts (ones with _ prefix), should have a layout file.

Hey there, I just had the same issue:
This works
app/routes
├── _index.tsx
├── app.profile._index.tsx
├── app.profile.edit.tsx
├── app.profile.tsx
├── app.tsx

This doesn't work
app/routes
├── _index.tsx
├── app.profile
│   └── route.tsx
├── app.profile._index
│   └── route.tsx
├── app.profile.edit
│   └── route.tsx
├── app.tsx

Looks like a bug in Remix v2 routes. My remix-flat-routes package handles this correctly.
❯ tree app/routes-5490
app/routes-5490
├── _index.tsx
├── app.profile
│   └── route.tsx
├── app.profile._index
│   └── route.tsx
├── app.profile.edit
│   └── route.tsx
└── app.tsx

❯ npx remix routes
<Routes>
  <Route file="root.tsx">
    <Route path="app" file="routes-5490/app.tsx">
      <Route path="profile" file="routes-5490/app.profile/route.tsx">
        <Route path="edit" file="routes-5490/app.profile.edit/route.tsx" />
        <Route index file="routes-5490/app.profile._index/route.tsx" />
      </Route>
    </Route>
    <Route index file="routes-5490/_index.tsx" />
  </Route>
</Routes>

Yes, I believe that's exactly what the issue described as v2_routeConvention is not related to your flat routes package, right?

I might be mistaken, but I believe the issue has been solved as part of https://github.com/remix-run/remix/pull/5459 . I've upgraded the repo reproducing the issue to the nightly version (0.0.0-nightly-aecf731-20230222) and the issue seems to be solved.
Not sure if I should close the issue now, or wait for the next stable version to be released.

You should have a _users.tsx route, the parent layout for all the _users.* routes. Pathless layouts (ones with _ prefix), should have a layout file.

FYI, not that it matters for this issue, but these routes are only written the way they are because they were a folder in v1, and they don't render anything, so they don't need a layout. Adding a layout also doesn't change the outcome.
The bug indeed seems to be fixed with #5459. As far as I am personally concerned @mccuna , I generally close tickets when they are fixed, not when they are published, so I think this can be closed?

@SleeplessByte ok... hard to say what the intent was. I'm just not sure why have a pathless layout without an actual layout file.

They are loader / action oauth redirection paths. They don't render, they always redirect :)


[REF] rename from pax to usdp

needs https://github.com/bitpay/bitcore/pull/3422 and bwc bump
Fixes:

show correct name and symbol when creating a wallet

Rate not found for currency: usdp

possible duplicated key error if wrong pax wallet is created

need to rebase


Fixates WeekPicker calendar month/year dropdown positions

Also slightly changes the logic of pagination's next/previous buttons appearance and refactors weekly rate formatting.

@MadOPcode the code for work Work Periods refactored in a nice way. But regarding 2 other changes, I'm not sure what was improved.

I'm not sure what changed for pagination from the UI/UX side.

Regarding the month/year selector the only one change I see is that month selector is now not centered:

Before it was centered:

1. I'm not sure what changed for pagination from the UI/UX side.

Before, the "previous" button appeared when current page number was > 1. Now it appears when current page number is > 2. Also, now the button for current page is the central button with a number. Before it was the left button with a number.

2. Regarding the month/year selector the only one change I see is that month selector is now not centered

Previously the month/year dropdown lists only appeared to be centered. Selecting the month with a long name in calendar caused year dropdown list not to be centered with respect to year dropdown button. Also selecting different months caused dropdown buttons to move around.

@MadOPcode got it, thanks!


pip install error

I use pip install lie_learn and here is the error message:
It seems that the longintrepr.h file is not found.
Building wheels for collected packages: lie_learn
  Building wheel for lie_learn (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [101 lines of output]
      /tmp/pip-install-426uqter/lie-learn_cada3dbe4ee348f6bac846d3d3dd79a5/setup.py:19: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
      !!

              ********************************************************************************
              Requirements should be satisfied by a PEP 517 installer.
              If you are using pip, you can try `pip install --use-pep517`.
              ********************************************************************************

      !!
        dist.Distribution().fetch_build_eggs(setup_requires_list)
      /home/server/miniconda3/envs/torch20/lib/python3.11/site-packages/setuptools/__init__.py:84: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
      !!

              ********************************************************************************
              Requirements should be satisfied by a PEP 517 installer.
              If you are using pip, you can try `pip install --use-pep517`.
              ********************************************************************************

      !!
        dist.fetch_build_eggs(dist.setup_requires)
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.linux-x86_64-cpython-311
      creating build/lib.linux-x86_64-cpython-311/lie_learn
      copying lie_learn/broadcasting.py -> build/lib.linux-x86_64-cpython-311/lie_learn
      copying lie_learn/__init__.py -> build/lib.linux-x86_64-cpython-311/lie_learn
      creating build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/SO3FFT_Naive.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/T2FFT.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/S2_conv.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/__init__.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/FFTBase.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/PolarFFT.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/T1FFT.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/SO3_conv.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/SE2FFT.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/S2FFT_NFFT.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/fourier_interpolation.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      copying lie_learn/spectral/S2FFT.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spectral
      creating build/lib.linux-x86_64-cpython-311/lie_learn/representations
      copying lie_learn/representations/__init__.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations
      creating build/lib.linux-x86_64-cpython-311/lie_learn/spaces
      copying lie_learn/spaces/rn.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spaces
      copying lie_learn/spaces/S2.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spaces
      copying lie_learn/spaces/__init__.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spaces
      copying lie_learn/spaces/Tn.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spaces
      copying lie_learn/spaces/S3.py -> build/lib.linux-x86_64-cpython-311/lie_learn/spaces
      creating build/lib.linux-x86_64-cpython-311/lie_learn/groups
      copying lie_learn/groups/__init__.py -> build/lib.linux-x86_64-cpython-311/lie_learn/groups
      copying lie_learn/groups/SO3_tests.py -> build/lib.linux-x86_64-cpython-311/lie_learn/groups
      copying lie_learn/groups/SO2.py -> build/lib.linux-x86_64-cpython-311/lie_learn/groups
      copying lie_learn/groups/SE2.py -> build/lib.linux-x86_64-cpython-311/lie_learn/groups
      creating build/lib.linux-x86_64-cpython-311/lie_learn/probability
      copying lie_learn/probability/S1HarmonicDensity.py -> build/lib.linux-x86_64-cpython-311/lie_learn/probability
      copying lie_learn/probability/HarmonicDensity.py -> build/lib.linux-x86_64-cpython-311/lie_learn/probability
      copying lie_learn/probability/S2HarmonicDensity.py -> build/lib.linux-x86_64-cpython-311/lie_learn/probability
      copying lie_learn/probability/SO3HarmonicDensity.py -> build/lib.linux-x86_64-cpython-311/lie_learn/probability
      copying lie_learn/probability/__init__.py -> build/lib.linux-x86_64-cpython-311/lie_learn/probability
      creating build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/test_spherical_harmonics.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/indexing.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/test_SO3_irrep_bases.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/spherical_harmonics.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/__init__.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/test_wigner_d.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/wigner_d.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/clebsch_gordan_numerical.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      creating build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3/pinchon_hoggan
      copying lie_learn/representations/SO3/pinchon_hoggan/pinchon_hoggan_parsing.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3/pinchon_hoggan
      copying lie_learn/representations/SO3/pinchon_hoggan/download.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3/pinchon_hoggan
      copying lie_learn/representations/SO3/pinchon_hoggan/__init__.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3/pinchon_hoggan
      copying lie_learn/representations/SO3/pinchon_hoggan/pinchon_hoggan_dense.py -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3/pinchon_hoggan
      running egg_info
      writing lie_learn.egg-info/PKG-INFO
      writing dependency_links to lie_learn.egg-info/dependency_links.txt
      writing requirements to lie_learn.egg-info/requires.txt
      writing top-level names to lie_learn.egg-info/top_level.txt
      reading manifest file 'lie_learn.egg-info/SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      adding license file 'LICENSE'
      writing manifest file 'lie_learn.egg-info/SOURCES.txt'
      copying lie_learn/spaces/spherical_quadrature.c -> build/lib.linux-x86_64-cpython-311/lie_learn/spaces
      copying lie_learn/groups/SO3.c -> build/lib.linux-x86_64-cpython-311/lie_learn/groups
      copying lie_learn/representations/SO3/irrep_bases.c -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3
      copying lie_learn/representations/SO3/pinchon_hoggan/J_block_0-150.npy -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3/pinchon_hoggan
      copying lie_learn/representations/SO3/pinchon_hoggan/J_dense_0-150.npy -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3/pinchon_hoggan
      copying lie_learn/representations/SO3/pinchon_hoggan/pinchon_hoggan.c -> build/lib.linux-x86_64-cpython-311/lie_learn/representations/SO3/pinchon_hoggan
      running build_ext
      building 'lie_learn.representations.SO3.irrep_bases' extension
      creating build/temp.linux-x86_64-cpython-311
      creating build/temp.linux-x86_64-cpython-311/lie_learn
      creating build/temp.linux-x86_64-cpython-311/lie_learn/representations
      creating build/temp.linux-x86_64-cpython-311/lie_learn/representations/SO3
      gcc -pthread -B /home/server/miniconda3/envs/torch20/compiler_compat -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /home/server/miniconda3/envs/torch20/include -fPIC -O2 -isystem /home/server/miniconda3/envs/torch20/include -fPIC -I/home/server/miniconda3/envs/torch20/lib/python3.11/site-packages/numpy/core/include -I/home/server/miniconda3/envs/torch20/include/python3.11 -c lie_learn/representations/SO3/irrep_bases.c -o build/temp.linux-x86_64-cpython-311/lie_learn/representations/SO3/irrep_bases.o
      lie_learn/representations/SO3/irrep_bases.c:209:12: fatal error: longintrepr.h: No such file or directory
        209 |   #include "longintrepr.h"
            |            ^~~~~~~~~~~~~~~
      compilation terminated.
      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for lie_learn
  Running setup.py clean for lie_learn
Failed to build lie_learn
ERROR: Could not build wheels for lie_learn, which is required to install pyproject.toml-based projects

Any help?

Might be worth a shot, to try:
$ python -m pip install git+https://github.com/AMLab-Amsterdam/lie_learn

Also, look at the instructions that @kalekundert gave in #26


Populate document metadata and autogenerated keys

Codecov Report

Merging #90 (4436508) into main (bac76c1) will increase coverage by 0.26%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   79.17%   79.43%   +0.26%
==========================================
  Files          16       16
  Lines        1426     1454      +28
==========================================
+ Hits         1129     1155      +26
  Misses        231      231
- Partials       66       68       +2

Impacted Files
Coverage Δ

schema/schema.go
88.25% <ø> (ø)

tigris/collection.go
74.78% <66.66%> (-1.91%)
:arrow_down:

tigris/model.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac76c1...4436508. Read the comment docs.


Remove hard-coded constants

Some model quantities are currently hard-coded (e.g. the number of PSF and galaxy components).  Others have global constants defined but hard-coded values are sometimes still used (e.g. the mu values in the VB parameters object).  With two of us making changes, it'll be less error prone to go through the code and encode all these as global constants.

This was fixed in 94aeee35e882279f318056c95c0f3481021b3ba8


chore: update SECURITY.md

As title says

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.67%. Comparing base (c44b130) to head (1fb6d28).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   90.67%   90.67%
=======================================
  Files          94       94
  Lines        7078     7078
=======================================
  Hits         6418     6418
  Misses        660      660

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


iOS Binaries

Hi!
i get an error msg that an ios binary is not found
i moved the binaries in scrounger bin folder to /usr/bin/ on the iphone
i tried running the binary in terminal to check but i get: bad cpu type in executable
any sugs?
Thank you

Looks like you're probably using an older iOS device.
The binaries were compiled for x64 devices only.
Would you be able to tell me what device you're using?

is there a way i can find the source files for the binaries?

Unfortunately no. I don't think we're going to support armv6/7 devices either, I'm sorry.


Adjustment of Board Dimensions for Calibration

The process below describes the steps of modifying calibration_utils.py to use a different chessboard size during calibration. Note that width and height are the number of internal corners per a chessboard row and column. A useful link for creating custom chessboards can be found here: https://calib.io/pages/camera-calibration-pattern-generator.
Navigate to the location of the calibration_utils.py and make a copy of the original script if interested in comparing
cd <INSTALLDIR>/depthai-python-extras/depthai_helpers/
cp calibration_utils.py calibration_utils_py.bak

Use the stream editor sed to replace the desired values of the script
sed -i  '/self.objp\|Chessboard/{
  N
  s/9/<WIDTH>/g
  s/6/<HEIGHT>/g
}' calibration_utils.py

Compare the results to confirm the correct lines are replaced
diff -u calibration_utils.py.bak calibration_utils.py
The calibration.py script should now work for the new board size.  Alternatively, the StereoCalibration class could incorporate the board dimension as an argument.

Hi @RileyKenyon ,
Meant to say earlier thanks a ton for writing this up for us!
Thanks again,
Brandon


Reduce io in ClasspathCache

I noticed in a flame graph that we were calling Files.exists and
Files.readAttributes in the same place. It should be unnecessary to call
Files.exists because Files.readAttributes will throw a
NoSuchFileException if it doesn't exist. This would be probably be a bad
change if we were checking files that frequently didn't exist but I
doubt that's the case. We also probably should have had the catch of
NoSuchFileException regardless of whether we did the existence check
because it's always possible albeit unlikely that the file is deleted in
between the existence check and reading the attributes.
I also saw that we could avoid computing the last modified time with
IO.getModifiedTimeOrZero when using jdk > 10 since newer jdks have
millisecond timestamp precision.

To validate this pull request against other sbt modules, please visit this link.

My assumption was that even though filling a stack trace is expensive, performing io is even more expensive. If that's true, dropping the existence check would be a slight performance hit in the unhappy path but it should be about a 2x speedup for the happy path and less than a 2x hit in the unhappy path. On my test project, I saw pretty much the exact speedups that I expected in flamegraphs but it's certainly possible that non-existent files are more common in other projects (I think they all existed in my project).
The only clue I had about the use case was the comment // readAttributes needs to be guarded by file.exists(), otherwise it fails which made me think that the existence check was to avoid having readAttributes throw a NoSuchFileException since that is the failure mode for readAttributes for a file that doesn't exist. Unfortunately, the comment says nothing about when and why the file wouldn't exist so I don't know how common the failure mode is.
This issue is also further strengthens my opinion that it was/is a design mistake in scala that checked exceptions from java are ignored. Even if scala itself didn't want checked exceptions for its own apis, I think it should enforce checked exceptions in java code. At a minimum, there should be a compiler flag for this. Because it doesn't, I can basically never be sure if code in scala is going to throw or not unless I have written all of it myself which makes scala feel mildly unsafe at all times. I know checked exceptions are not a widely loved feature in java but I really don't understand why scala just ignores them given the consequence of doing so.


Add support for Galcon GL8000B

Hi,
Can you please add support for Galcon GL8000B model ?
Tried using the GL9001A type, but it is not working.
ref:

https://www.galconc.com/product/8000-series/

Just for reference # https://github.com/suborb/GalconController/issues/1#issuecomment-2294993030


Can not get localized string in swift files using genstrings.py

I am using Swift 2 and have already import Localize to do i18n.
Everything works well, but i can not use genstrings.py to get the localized source string in swift files:
In swift file( test.swift):
label.text = "Name".localized()
after i run genstrings.py, nothing in the terminal, i suppose it could be like this:
/*

./test.swfit
*/

"Name" = "Name";
I am not familiar with RE and Python, after i tried many times, it still can not work as i hope.
can you help to fix it?

Thanks for finding this issue. Looks like there was a bug in the regular expression I was using. Fixed in the latest commit. Will do a cocoapods release too.

👍


LUN-269: Feedback for a word logic

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword LUN.

Tested on android +1 When is it possible to give feedback for a discipline?

Currently it is only possible via the api, but not in the app. No designs or feature request for this yet.

Suggest alternative word does not work

Fixed it.


[webview_flutter_android] Implementation of Android WebView widget using pigeon

Replaces MethodChannelPlatformController with WebViewAndroidPlatformController and WebViewAndroidWidget.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Adding @mvanbeusekom for a second review, since this is a substantial rewrite, so would benefit from more eyes.

Is this ready for re-review?

@stuartmorgan This is ready for another review!


Rewrite code for multiple-monitor support

Felt like having a single issue to track this progress. I'll keep updating here regarding the current status of this.
So in commit 23c77d4ee0f8cfa2e0b9f564816ca40ce8bdb2aa I have been able to have the active space identifier update properly upon a screen transition. This should allow for actually being able to use multiple monitors properly without the annoyance of having the window-trees reset all the time.
In an earlier commit (812e64af2313259d92c52d4f0c0c4f7e2975d9e3) the space-transition code was rewritten to use the NSWorkspaceDidActiveSpaceChange notification.
The issues remaining I would think are having Kwm properly handle disconnection of monitors, awake from sleep and similar. See #123, #127

Even without second display connected window-trees reset quite often on focus on window-tree's space. Not on every unfocus/focus, but often. I'm not sure what's causing this though, it happens kinda randomly.

It should be stable in the latest commit. During the re-write there were a lot of things I didn't think of at first, that were done at a later time.

I have a suspicion that the current best solution for #123, #127, and #108 is to not react to display changes until a timeout has expired, and keep resetting that timeout every time a display change is noticed.
After the timeout has expired then kwm reads the display state and adjusts accordingly.
Unless there is some API to help you, I'm not sure how else the "fake" displays can be solved. As they appear to be "real" displays that get removed. They are only there for a short time during the transition.
Switching the iGPU, waking from sleep with a 4k external monitor, and changing displays should be covered by that approach?

I'll probably have to give something like that a try. I really have no idea what to do regarding these, as there are indeed on APIs available (that I have been able to find at the very least).

Looks like refresh issue is fixed, but it's replaced by another: now when I refocus on some space, kwm ignores everything (it's running, but it doesn't spawn windows, ignores all keybindings, tree restore doesn't work etc), so I have to kwmc quit to make it responsive again.

You sure that is not connected to #131 ?

You sure that is not connected to #131 ?

I just updated kwm from master, restarted osx and tried to go to non-existent space. Kwm runs fine, so I guess it's not it. After restart I noticed that my bindings kwmc screen -f [id] don't work, but after a 5 minutes they were back w/o kwm restart. Now everything works fine, I'll write back here if the issue will appear again.

Well, here is what's happening:

my system keybindings to switch spaces are getting broken and after some movements through the windows/screens they work again
same happening for kwmc screen -f [id] bindings

Looks like it's happening when I open some very new window of some app (but not every). But it's just a guess.

I don't really see how that would be connected to earlier changes tho. Could you try and revert back to Kwm Version 1.1.1 and see if these issues still happen?

Sure, will do a bit later today :+1:

Hah, I just switched to iTerm to revert back to prev version and kwm ignores everything again, so this issue still appears on master branch.
Should I switch to 1.1.1 and check screen -f there?

Make sure that "Secure keyboard entry" is not enabled for iTerm.
If that does not fix it, try re-enabling accessibility access for Kwm.

Make sure that "Secure keyboard entry" is not enabled for iTerm.
It's disabled.

If that does not fix it, try re-enabling accessibility access for Kwm.
I did it right after kwm update -> osx restart.

BTW it's not only iTerm related, all spaces / windows ignored, as well as all of the keybindings.

It's disabled.
I did it right after kwm update -> osx restart.

Not sure what would be causing it then. Everything works fine for me (better than it used to).

A new issue I have discovered in the last day: Sometimes kwmc screen -f does not seem to actually give focus to the other screen. Kwm thinks it did because kwmc read tag updates appropriately, but no commands work until screen -f is used to "bring" focus back to the previous screen.

not sure if this is related, or it's already been discussed, but the top half of my screen flickers when switching gpus.

A new issue I have discovered in the last day: Sometimes kwmc screen -f does not seem to actually give focus to the other screen. Kwm thinks it did because kwmc read tag updates appropriately, but no commands work until screen -f is used to "bring" focus back to the previous screen.

I know this happens when the screen that is supposed to get focus,  has no windows on it. (which is a bug). Have not come across it in other situations tho.

A new issue I have discovered in the last day: Sometimes kwmc screen -f does not seem to actually give focus to the other screen. Kwm thinks it did because kwmc read tag updates appropriately, but no commands work until screen -f is used to "bring" focus back to the previous screen.

Issue with switching between GPUs have been mentioned, but it is not something I can work on as I do not have a macbook with a dGPU.

Have not come across it in other situations tho.

This didn't start until very recently, and has the same behavior as if a display has no windows on it. It was in monocle if it makes any difference?
In any case it's not super common, and using the mouse fixes it. So it seems keyboard-centric?

Pretty sure it broke in  this commit: 86c453af72b7d75311413adff499e1a04fd919b0
The exact line of code that was removed, that could impact this:
CGWarpMouseCursorPosition(CGPointMake(FocusFirstNode->Container.X + FocusFirstNode->Container.Width / 2,

Which was only handled upon using keyboard to give focus.

That does indeed sound pretty likely

I have very limited time to spend on Kwm these days, and will not be able to have any real progress on this issue before summer, at the very least.
The logic that needs to be revisited, is how Kwm handles the following scenarios:

(dis)connection of display
enter / leave sleep
enter / leave clamshell mode
switching active GPU
(dis)connection of display while already in clamshell mode

At this moment, I have no idea how to respond if the Main/Primary display is changed as a result of the actions listed above.
The core of the changes for the above behaviour as far as I know at the moment, would have to be in "DisplayReconfigurationCallback()" function @ kwm/display.cpp
If anyone is interested in taking a look at this, that would be very much appreciated.
The following are links to some apple dev documentation that could be useful:

Quartz Display API
Display Notifications

Any (detailed) insight into how OSX behaves during these actions could also be helpful for solving these issues when I finally do get time to take a proper look at this.

Are there things in particular you are looking for / would be of great use? I'm very willing to collect any information you need about the behavior. I have a setup that checks all the problem boxes: 4k monitor, discrete graphics card, etc...
Let me know what data would be useful and I'll collect it.

Are there things in particular you are looking for / would be of great use?

Uh, more or less the messages that OSX reports to the DisplayReconfigurationCallback() when it performs any of the actions listed above, or when only a single monitor enters or awakes from sleep.
Basically, any information that lets us tell the difference between which action actually happened is valuable.

Are the debug logs in place that would provide that information? I can spend some time in debug mode adding and removing a display, switching the graphics card, sleeping and waking. Then supply the logs associated with the actions for later examination?

There are logs for when a display is  detected, removed, and enters sleep I believe.

Some other flags that is probably worth tracking, which Kwm does not atm.

Throw in any logs that might help you track down odd behavior and I will collect data later this week / this weekend.

Throw in any logs that might help you track down odd behavior and I will collect data later this week / this weekend.

Will get to this when I have time, hopefully before this weekend.

Will get to this when I have time, hopefully before this weekend.

Ping me when you do, and I'll start the testing.

Is this issue resolved with the latest patch from @cHoco ?

Resolved for me!

I'm gonna close this for now. Feel free to open new issues if necessary.


Set as default index stub with background image

https://github.com/orlovmax/front-end-scaffold/commit/bc6a11050b64a00f0ef75de33e4c372ec86b37a5


[HELP] After fresh install of k3s local-path-provisioner and metrics-server keep on crashing

Environmental Info:
K3s Version:

root@aura:/home/hmo# k3s --version
k3s version v1.19.3+k3s3 (0e4fbfef)
Node(s) CPU architecture, OS, and Version:

2 cores, Linux Ubuntu 20.04, 2 Gb ram.
Cluster Configuration:

1 server (no workers)
Describe the bug:

After fresh install of k3s with: curl -sfL https://get.k3s.io | sh -
I notice that local-path-provisioner and metrics-server keep on crashing.
NAMESPACE     NAME                                     READY   STATUS             RESTARTS   AGE
kube-system   coredns-66c464876b-pxzp6                 0/1     Running            0          5m10s
kube-system   helm-install-traefik-vjzqh               1/1     Running            2          5m10s
kube-system   local-path-provisioner-7ff9579c6-hjc5m   0/1     CrashLoopBackOff   4          5m10s
kube-system   metrics-server-7b4f8b595-ck4cs           0/1     CrashLoopBackOff   4          5m10s
Steps To Reproduce:

Installed K3s:
Just apply a fresh install with root user on a Linux Ubuntu 20.04 2 cores 2 Gb ram.

Expected behavior:

It shouldn't show errors.
Additional context / logs:

root@aura:/home/hmo# kubectl describe pods local-path-provisioner-7ff9579c6-hjc5m -n=kube-system
Name:         local-path-provisioner-7ff9579c6-hjc5m
Namespace:    kube-system
Priority:     0
Node:         aura/<IP_ADDRESS>
Start Time:   Sat, 14 Nov 2020 00:30:55 +0000
Labels:       app=local-path-provisioner
pod-template-hash=7ff9579c6
Annotations:
Status:       Running
IP:           <IP_ADDRESS>
IPs:
IP:           <IP_ADDRESS>
Controlled By:  ReplicaSet/local-path-provisioner-7ff9579c6
Containers:
local-path-provisioner:
Container ID:  containerd://94a0968fcdcf12b4e46a03a07324c35323c283b0759c3b489ee1a9e3eba82f9f
Image:         rancher/local-path-provisioner:v0.0.14
Image ID:      docker.io/rancher/local-path-provisioner@sha256:40cb8c984c1759f1860eee088035040f47051c959a6d07cdb126e132c6f43b45
Port:
Host Port:
Command:
local-path-provisioner
start
--config
/etc/config/config.json
State:          Waiting
Reason:       CrashLoopBackOff
Last State:     Terminated
Reason:       Error
Exit Code:    1
Started:      Sat, 14 Nov 2020 00:40:05 +0000
Finished:     Sat, 14 Nov 2020 00:40:35 +0000
Ready:          False
Restart Count:  6
Environment:
POD_NAMESPACE:  kube-system (v1:metadata.namespace)
HELPER_IMAGE:   rancher/library-busybox:1.31.1
Mounts:
/etc/config/ from config-volume (rw)
/var/run/secrets/kubernetes.io/serviceaccount from local-path-provisioner-service-account-token-64jn4 (ro)
Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
config-volume:
Type:      ConfigMap (a volume populated by a ConfigMap)
Name:      local-path-config
Optional:  false
local-path-provisioner-service-account-token-64jn4:
Type:        Secret (a volume populated by a Secret)
SecretName:  local-path-provisioner-service-account-token-64jn4
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     CriticalAddonsOnly op=Exists
node-role.kubernetes.io/master:NoSchedule op=Exists
node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
Type     Reason       Age                  From               Message

Normal   Scheduled    11m                  default-scheduler  Successfully assigned kube-system/local-path-provisioner-7ff9579c6-hjc5m to aura
Warning  FailedMount  11m                  kubelet            MountVolume.SetUp failed for volume "local-path-provisioner-service-account-token-64jn4" : failed to sync secret cache: timed out waiting for the condition
Warning  FailedMount  11m                  kubelet            MountVolume.SetUp failed for volume "config-volume" : failed to sync configmap cache: timed out waiting for the condition
Normal   Pulling      11m                  kubelet            Pulling image "rancher/local-path-provisioner:v0.0.14"
Normal   Pulled       11m                  kubelet            Successfully pulled image "rancher/local-path-provisioner:v0.0.14" in 21.729800615s
Normal   Pulled       7m44s (x4 over 10m)  kubelet            Container image "rancher/local-path-provisioner:v0.0.14" already present on machine
Normal   Created      7m44s (x5 over 11m)  kubelet            Created container local-path-provisioner
Normal   Started      7m44s (x5 over 11m)  kubelet            Started container local-path-provisioner
Warning  BackOff      99s (x29 over 10m)   kubelet            Back-off restarting failed container
root@aura:/home/hmo# kubectl describe pods metrics-server-7b4f8b595-ck4cs -n=kube-system
Name:         metrics-server-7b4f8b595-ck4cs
Namespace:    kube-system
Priority:     0
Node:         aura/<IP_ADDRESS>
Start Time:   Sat, 14 Nov 2020 00:30:55 +0000
Labels:       k8s-app=metrics-server
pod-template-hash=7b4f8b595
Annotations:
Status:       Running
IP:           <IP_ADDRESS>
IPs:
IP:           <IP_ADDRESS>
Controlled By:  ReplicaSet/metrics-server-7b4f8b595
Containers:
metrics-server:
Container ID:   containerd://01fdbcfb737bd82ca3cd9be303d7c8d299a292739103512112fc0650e795270f
Image:          rancher/metrics-server:v0.3.6
Image ID:       docker.io/rancher/metrics-server@sha256:b85628b103169d7db52a32a48b46d8942accb7bde3709c0a4888a23d035f9f1e
Port:
Host Port:
State:          Waiting
Reason:       CrashLoopBackOff
Last State:     Terminated
Reason:       Error
Exit Code:    2
Started:      Sat, 14 Nov 2020 00:40:16 +0000
Finished:     Sat, 14 Nov 2020 00:40:47 +0000
Ready:          False
Restart Count:  6
Environment:
Mounts:
/tmp from tmp-dir (rw)
/var/run/secrets/kubernetes.io/serviceaccount from metrics-server-token-gkghl (ro)
Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
tmp-dir:
Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
Medium:
SizeLimit:
metrics-server-token-gkghl:
Type:        Secret (a volume populated by a Secret)
SecretName:  metrics-server-token-gkghl
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     CriticalAddonsOnly op=Exists
node-role.kubernetes.io/master:NoSchedule op=Exists
node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
Type     Reason       Age                   From               Message

Normal   Scheduled    13m                   default-scheduler  Successfully assigned kube-system/metrics-server-7b4f8b595-ck4cs to aura
Warning  FailedMount  13m                   kubelet            MountVolume.SetUp failed for volume "metrics-server-token-gkghl" : failed to sync secret cache: timed out waiting for the condition
Normal   Pulling      13m                   kubelet            Pulling image "rancher/metrics-server:v0.3.6"
Normal   Pulled       12m                   kubelet            Successfully pulled image "rancher/metrics-server:v0.3.6" in 22.390258711s
Normal   Pulled       9m23s (x4 over 12m)   kubelet            Container image "rancher/metrics-server:v0.3.6" already present on machine
Normal   Created      9m23s (x5 over 12m)   kubelet            Created container metrics-server
Normal   Started      9m23s (x5 over 12m)   kubelet            Started container metrics-server
Warning  BackOff      3m23s (x28 over 11m)  kubelet            Back-off restarting failed container

If things are crashing, pod logs would be useful to have.

No luck, I'm trying for now with k3d.


ARROW-7315: [Python] Remove unused cmake flag from wheel scripts

Aside: why is the macos wheel script under dev/tasks but manylinux* are under python/?

It's used in FindOpenSSL.cmake provided by CMake: https://cmake.org/cmake/help/latest/module/FindOpenSSL.html#hints
I think that we can't use libssl.so in manylinux wheel because it's not in whitelist https://www.python.org/dev/peps/pep-0571/#the-manylinux2010-policy .

So the warning from cmake is spurious? Or is there a more correct place to define it?

How about this?
diff --git a/python/manylinux1/build_arrow.sh b/python/manylinux1/build_arrow.sh
index bf12da56c..a4971be32 100755
--- a/python/manylinux1/build_arrow.sh
+++ b/python/manylinux1/build_arrow.sh
@@ -66,11 +66,13 @@ PIP="${CPYTHON_PATH}/bin/pip"
 # Put our Python first to avoid picking up an antiquated Python from CMake
 PATH="${CPYTHON_PATH}/bin:${PATH}"

+CMAKE_ARGS=""
 if [ "${PYTHON_VERSION}" != "2.7" ]; then
   export PYARROW_WITH_FLIGHT=1
   export PYARROW_WITH_GANDIVA=1
   export BUILD_ARROW_FLIGHT=ON
   export BUILD_ARROW_GANDIVA=ON
+  CMAKE_ARGS="${CMAKE_ARGS} -DOPENSSL_USE_STATIC_LIBS=ON"
 else
   # Flight and Gandiva are not supported on Python 2.7
   export PYARROW_WITH_FLIGHT=0
@@ -114,7 +116,7 @@ cmake -DCMAKE_BUILD_TYPE=Release \
     -DARROW_GANDIVA_JAVA=OFF \
     -DBoost_NAMESPACE=arrow_boost \
     -DBOOST_ROOT=/arrow_boost_dist \
-    -DOPENSSL_USE_STATIC_LIBS=ON \
+    ${CMAKE_ARGS} \
     -GNinja /arrow/cpp
 ninja
 ninja install
diff --git a/python/manylinux2010/build_arrow.sh b/python/manylinux2010/build_arrow.sh
index a6ce49ac0..34ea25229 100755
--- a/python/manylinux2010/build_arrow.sh
+++ b/python/manylinux2010/build_arrow.sh
@@ -65,11 +65,13 @@ PYTHON_INTERPRETER="${CPYTHON_PATH}/bin/python"
 PIP="${CPYTHON_PATH}/bin/pip"
 PATH="${PATH}:${CPYTHON_PATH}"

+CMAKE_ARGS=""
 if [ "${PYTHON_VERSION}" != "2.7" ]; then
   export PYARROW_WITH_FLIGHT=1
   export PYARROW_WITH_GANDIVA=1
   export BUILD_ARROW_FLIGHT=ON
   export BUILD_ARROW_GANDIVA=ON
+  CMAKE_ARGS="${CMAKE_ARGS} -DOPENSSL_USE_STATIC_LIBS=ON"
 else
   # Flight and Gandiva are not supported on Python 2.7
   export PYARROW_WITH_FLIGHT=0
@@ -115,7 +117,7 @@ PATH="${CPYTHON_PATH}/bin:${PATH}" cmake -DCMAKE_BUILD_TYPE=Release \
     -DARROW_GANDIVA_JAVA=OFF \
     -DBoost_NAMESPACE=arrow_boost \
     -DBOOST_ROOT=/arrow_boost_dist \
-    -DOPENSSL_USE_STATIC_LIBS=ON \
+    ${CMAKE_ARGS} \
     -GNinja /arrow/cpp
 ninja install
 popd

FindOpenSSL.cmake is used only when we enable Flight.
I think that we always need this flag on macOS. Because we always enable Flight on macOS.
Did you see the warning on macOS?

Ah I see. I was only doing manylinux2010 with python 2.7 (primarily to avoid building gandiva and flight). When I saw the warning, I grepped our code and didn't find the flag mentioned anywhere other than the wheel scripts, so that's why I believed the warning was correct and proceeded to rm.
I'll try your way, though in reality we'll probably have to wait to advance this until the crossbow wheel jobs are fixed, otherwise we won't know that the change is working.

@nealrichardson the macOS/windows wheel scripts are heavily CI configuration dependent (see the corresponding crossbow CI templates) whereas the manylinux* scripts are reusable thanks to docker.

Closing this since it's 2020 and this is about Python 2.7


libpdbg: fix build with system libfdt

drop superfluous include
include libfdt.h from include directory, not from libfdt subdirectory,  which means the local copy due -I.

Signed-off-by: Dan Horák<EMAIL_ADDRESS>

Merged