Incomplete alias table definition potentially resulting in FW hole

Aliases containing only fqdns are defined as table <foobar> persist (without {}), which could lead to stalled entries in table in case it existed before the change (editing existing alias scenario)
from man pf.conf(5):

The contents of a pre-existing table defined without a list of addresses to initialize it is not altered when pf.conf is loaded.
A table initialized with the empty list, { }, will be cleared on load.

create new alias of type host, fill some IP and save
reference that alias from at least one fw rule (as IP only aliases declared w/o persist flag and will be dropped by kernel if unreferenced)
check actual table contents with pfctl -t _name_here_ -T show, it should be correct
edit your alias, change IP to some FQDN (resolving to different IP), save-aplly
check table contents again, now both old IP and new entry(ies) for FQDN are all there

@kernins this indeed looks buggy, it looks like this was supposed to flush the contents of the alias after loading, but wasn't triggered.
It looks to me that we should initialise it with an empty list {} and drop the the flush, this commit should fix it https://github.com/opnsense/core/commit/067f0982b7c91a52fcfc3cbf7a3c4a210ff2a7cb.
@fichtner can you double check if I'm not missing something here?

I refactored this at least twice, trying to keep the original intent in place. It's good to see this workaround being removed finally as I was unable to wrap my head around it before. If it works, all the better. No objections.

Indeed, your commit fixes the issue, and the code also looks much cleaner now
Btw, it also fixes potential race condition between filterdns reloading and table-flush statements being executed)

Nah, its not that simple. It also clears the table on FW rules reload, but filterdns doesn't then refill it, probably due to aliases aren't "dirty" in this case.
It seems  {} should only be added when aliases are "dirty" (edited)

but if it only flushes when dirty, it would have the same issue for other dns entries already in the list if I'm not mistaken.
We probably have to invalidate the entries in filterdns for these situations, but I'll have to look into this further.

Ok, tested some more, the problem is that this only "kind of works" when there are addresses or fqdn's in the alias.... but when fqdn's are used, they will never cleanup the way it's build.
In my opinion we should either restart filterdns with the filter and flush the alias or reset the alias on load with the proper content, because there is no way of knowing that the contents of the alias are still sane.
The question is what the time needed for filter reload will be when aliases contain a large amount of fqdn entries, pf does resolve, but I'm not sure about the speed there.
It would be good to loose more garbage from the code here, this whole area unfortunately is still quite messy.

but if it only flushes when dirty, it would have the same issue for other dns entries already in the list if I'm not mistaken
Why? The issue here seem to be in filterdns thinking it is already done its job (contents of its conf not changed) and so not reloading. Keeping table contents intact in fw-only reload scenario should be safe, if I'm not missing something.

In my opinion we should either restart filterdns with the filter and flush the alias or reset the alias on load with the proper content, because there is no way of knowing that the contents of the alias are still sane.
The question is what the time needed for filter reload will be when aliases contain a large amount of fqdn entries, pf does resolve, but I'm not sure about the speed there.

As you already mentioned, re-resolving all fqdns on each filter reload is sort of brute-force approach and may have noticeable impact with large lists. Local unbound cache could help here, but first-timers still could be lengthy to resolve. Also with filterdns I think it could still be possible to encounter some new border cases leading to inconsistency, the whole multiple-loose-writers design with configurator and filterdns both altering table contents while knowing nothing about each other's data seem fundamentially wrong to me. Feeding fqdns directly to pf looks much more robust in that sense, however this would be one-time resolve lacking periodic updates capability to catch possible changes in dns records.
I think, to do it properly, first we need some custom fqdn-dictionary service, which would maintain fqdn->ip map, handle periodic refreshes to keep it up to date, send out update events and provide API to query its map. So when alias containing fqdn is created/edited, that service gets notified, reloads fqdn list and immediately starts resolving new entries, possibly with feedback for user in UI. Existing entries are all periodically refreshed on schedule basis. After all new entries are resolved or scheduled update detected some changes, it should send out fqdn-map-updated event to notify any concerned parties.
PF management and table reloads should be exclusive right and responsibility of another entity, which among other things will listen to and act upon that fqdn-map-updated events.
While doing full filter reload it could actively query fqdn-dictionary service to instantly get fqdn->ip map containing all currently resolved entries, and then build pf table defs based on alias list and fqdn-map superposition. If all fqdns were resolved at that moment, this will result in complete table definitions and atomic pf reload. Otherwise remained entries will be pushed into table by means of receiving and handling fqdn-map-updated event.
Optionally dictionary service could implement sort of max-wait-time policy for its API, so client could specify how much time it is willing to wait in case not yet all fqdns are resolved.
However, all this is a bit out of bugfixing scope)
What do you think?

Why? The issue here seem to be in filterdns thinking it is already done its job (contents of its conf not changed) and so not reloading. Keeping table contents intact in fw-only reload scenario should be safe, if I'm not missing something.

It doesn't seem to cleanup old values, so any change in the list automatically seems to result in more items in the list. (for example, when changing www.nu.nl to www.ad.nl both will end up in the list)
There are more issues in this whole area, which eventually could justify building a new services to keep track of the table contents. The way it is now, on initial boot the filter would try to fetch the initial contents on load, which also is not a good idea in terms of architecture.
Writing the proper solution is indeed too big to do at the moment in terms of time and the coding quality in the current setup.
Pushing the initial values in the ruleset might break loading (I tested that to be sure),  so for the short-term we have two options:

revert to what it was
reload filterdns on changes

I would vote for two, because it will lead to a cleaner ruleset, but will cost more time for all entries to flow into the table again.
Eventually we should make sure the administration of the table contents is separated, but that's more of a longer term goal (first cleanup what's there and then add a new service).

It doesn't seem to cleanup old values, so any change in the list automatically seems to result in more items in the list. (for example, when changing www.nu.nl to www.ad.nl both will end up in the list)

Of course, but I was talking about aliases-unchanged case. When they are changed, yes, tables need to be fully reset.

I would vote for two

Agreed, it is still better than possibility of having incorrect table contents virtually indefinitely.
It might also be a good idea to change WAN-related rules to use tables, and reload only that tables when IP changes, not the whole ruleset. This could help to keep full reloads at minimum even on instances with dynamic WAN connection.


Deprecate and ignore global.tls.enabled flag

The flag is actually useless and it only adds noise while setting up tls.
I won't remove it since I don't want a breaking change in the custom resource

Fixes #135


Feature/add to project

Just setting up this PR for adding in the addtoproject and removefromproject endpoints.
Hoping for some initial feedback but don't pull it in yet

Where we at with this shizzle?

@mat-mcloughlin is this change still needed?

@troydai I think the code is a bit outdated (and is possibly incomplete), but the change was to add/remove files to/from an MS Build based project. I think this is something users are still using MS Build projects are likely to still want.

@mat-mcloughlin hey Matt now that there is a dev branch (see here) this PR will need to be re-opened against dev branch instead of master
so closing this one and once you rebase please re-open against dev, thanks


Panic with headless build

Description:
Bevy provides a MinimalPlugins plugin bundle for headless bevy applications. Headless applications can be used to implement a game server for example. When trying to add the default Avian PhysicsPlugins Plugin Bundle Bevy a panics.
Minimal Example:
Here is a minimal example for a simple headless bevy application.
use avian3d::prelude::*;
use bevy::{app::ScheduleRunnerPlugin, prelude::*};
fn main() {
    App::new()
        .add_plugins(MinimalPlugins.set(ScheduleRunnerPlugin::run_once()))
        .add_systems(Update, hello_world_system)
        .add_plugins(PhysicsPlugins::default())
        .run();
}

fn hello_world_system() {
    println!("hello world");
}

Which results in the following error.
Resource requested by avian3d::collision::collider::backend::init_collider_constructor_hie
rarchies does not exist: bevy_asset::assets::Assets<bevy_render::mesh::mesh::Mesh>
Encountered a panic in system `hello world
avian3d::collision::collider::backend::init_collider_constructors`!
Encountered a panic in system `avian3d::collision::collider::backend::init_collider_constr
uctor_hierarchies`!
Encountered a panic in system `bevy_app::main_schedule::Main::run_main`!

Is this a bug?
Does PhysicsPlugins::default() include plugins that can not be used without bevy_window::WindowPlugin maybe? If yes, would it make sense to also provide a MinimalPlugins bundle for avian physics? What plugins would I need to exclude?
Thanks!

The panics do not seem to be related to WindowPlugin.
Info for you and anyone else who lands here trying to do the same in the future:
There's a few things missing when launching with MinimalPlugins that cause a panic:

AssetPlugin
ScenePlugin
Assets<Mesh> resource

Also missing but doesn't cause a panic:

TransformPlugin

These requirements are implicitly codified in tests.rs::create_app here, but this information isn't easy to find.
With the following changes I was able to get your code above running:
  fn main() {
      App::new()
          .add_plugins(MinimalPlugins.set(ScheduleRunnerPlugin::run_once()))
+         .add_plugins((
+             TransformPlugin,
+             bevy::asset::AssetPlugin::default(),
+             bevy::scene::ScenePlugin,
+         ))
+         .init_resource::<Assets<Mesh>>()
          .add_systems(Update, hello_world_system)
          .add_plugins(PhysicsPlugins::default())
          .run();
  }

If you don't need mesh colliders, you can avoid the need for Assets<Mesh> resource and ScenePlugin if you disable the bevy_scene and collider-from-mesh features.
I don't see a way that it could be possible to remove the reliance on TransformPlugin since so much of Avian works with GlobalTransform.

I see, thanks a lot!


OnePlus One right eye field of view

I have a customer with a OnePlus One reporting seeing double, or a blurry image in my game End Space VR.
Here is a screenshot he sent me (OnePlus One):

And here is a screenshot I made using my Samsung S3,

You can see the right eye has a much different field of view. I asked the customer to reset his data and cache of the cardboard app, but the problem persists.

For OnePlus One, the first thing we tell people is to change to phone's DPI from the factory default (and incorrect) value of 480 to the correct value if 401.  That practically always solves this issue.

Yep that solved the issue, thanks!


Atteched Files problem

Hi,
I just tried this tool as it appeared as the solution to my challenge: as Evernote export to HTML has been broken for over 2 years now and the company doesn't fix it (it is worse: I tried to report it several times, once the ticket is opened they close it immediately with the remark: fixed) I cannot export to HTML. The problem is that all attachments in a note are titled "Untitled Attachment" and the hot-links of them do not point to the attached files in the subfolder. Thus, the generated HTML index file is useless.
I tried this tool, but what I get is an index/overview file without attachment links / icons etc. Just as if they were no attachments in notes in ENEX. The files of the attachments are in a subfolder though, as they should be.
Am I doing it wrong?

I can't say for sure.
Since I created my tool without any official documentation, it is not surprising that there are enex files that cannot be analyzed as expected.

If your enex file itself contains the attachment files, I migit be able to fix the unenex to link the correct URL .
Could you send me the enex file that causes the problem ?
@Juelicher-Trainee

I will close this issue. If you can tell me new information, please re-open.

I am sorry, this was during the Christmas days and I could not react.
I can provide more information:

The attachments do not appear in the output HTML file generated by unenex (go-enex) at all. The HTML file generated simply does not have a reference to them (they are not listed or shown in any way).
The attached files are present in a subfolder though, as usual with HTML files.
They can be opened and viewed.
BUT they don't have the correct file names: they names start correctly but get some numbers appended to them. This is a problem, the files should have the names as the attachments were called in the Evernote note. However: it is possible that Evernote messes up these names. It may even be, that not just the current attachments are exported into the ENEX file but former versions, deleted (from the note) attachments ae also included. This reflects the sad state of Evernote: exporting is a royal mess currently.
The original note in Evernote looks like this:

The ENEX file is attached (as a ZIP file, I could not upload ENEX):
HTML-Test.zip
Thank you for your time.

I found that unenex had a problem.
Non-images attachments were embedded with <img> tags into output html as if they were images.
I modified unenex to use <a> to link attachments.
Could you please to try the new version: v0.2.1 ?

A big step forward, thank you!
With that "Unenex" has become a lot more useful.
If you feel like it,, there are a few ways you could improve it:

The HTML files generated do not retain the original formatting of the note. This information is in the ENEX file, because when I import it back to Evernote it has the original formatting.
The attachment files in the subfolders get renamed by Unenex. It seems to me that an index number 0…n get added to the filename. This is a problem, as for archive purposes the exact original file name of the attachment is needed.
Just as in 2): The spaces in the file names are replaced by "_" (underscore). This leads to  the same issue as 2).

You could make Unenex very useful, if you could change 2)-3) above. These have a priority over 1) (which would be nice, too).
I hope you are still interested in this project. A tool like Unenex is needed, because Evernote is broken and has been for over two years. The new owner (Bending Spoons) is not interested of fixing existing bugs, the only thing they do is introducing a bunch of untested new glitzy features. While basic functions, such as HTML export is badly broken.
Thus, currently the only way to export in functioning HTML format is to export as ENEX an convert it back to HTML.
I thank you for your effort. Unenex can be very useful for Evernote users.

I have addressed the 2nd, 3rd, and 5th requests.
The updated executable v0.3.0 (preview) can be downloaded on https://github.com/hymkor/go-enex/releases/tag/v0.3.0 .
For the remaining ones, I’ll handle them step by step as far as I’m able.

The 1st and 4th requests are difficult to implement.

The HTML files generated do not retain the original formatting of the note. This information is in the ENEX file, because when I import it back to Evernote it has the original formatting.

I disagree. I could not find this information in the ENEX file. Most of the formatting data might be stored on Evernote's servers.

It would be nice to have icons for the various file types, so that the HTML note looks like in Evernote (as depicted two messages above).

I believe the images for the icons are not license-free.

As you mentioned, I use Go's standard library function to encode URLs for attached files.
I will consider making changes.

The logic you described has already been implemented in v3.0.0. However, it seems not to work as expected with your data.
Below is the output from my test data. The current specification assigns a serial number starting with "(2)".

I will investigate.

> (1)
I understand what you mean. I’ve fixed it. → v0.3.1
> (2)
I found and fixed some bugs. However, I couldn’t find any issues exactly matching what you reported.
If you try v0.3.1 and your problem is not resolved, could you please send me the ENEX file?

Both issues are fixed now.

There is a slight problem with spurious attachment files appearing "Untitled" and "Untitled (2)". Note that they do not have filename extensions. But looking into them, it is clear that they are *.png files, like the other attachments, too (which are treated properly now).
The other issue is with line spacing. The Evernote note looks like this

Whereas the generated HTML file displays like this:

I'd like to send you the enex file, but not publish it here. How can I do that? Is there a PM (private message) capability here? Or do you have an e-mail address I could use?
Thank you.

> 1. There is a slight problem with spurious attachment files appearing "Untitled" and "Untitled (2)". Note that they do not have filename extensions. But looking into them, it is clear that they are *.png files, like the other attachments, too (which are treated properly now).
Can I consider this issue(1) resolved?
> 2. The other issue is with line spacing. The Evernote note looks like this
To create a layout similar to the HTML exported directly by the Evernote desktop client, it is necessary to use Evernote's stylesheet.
However, this stylesheet is copyrighted material owned by Evernote Corporation and cannot be included with this tool.
Therefore, I have provided a method for users to extract the stylesheet themselves and import it into the output of Unenex.
Could you please refer to the release note of v0.3.2?

Hello,
thank you the original issue (1) is resolved, as far as I can judge. I did send you my enex file, if yiu unenex it, you will find those two spurious "Untitled" files without filename extensions in the subdirectory.
I am testing the style sheet workaround. It works in that I cloud extract the CSS. But when I use unenex with the -sf option, I do not see an difference in the HTML files. The file is identical whether I use the -sf option or not.
Just another quick comment: my browser always offers me to translate the page if I open the  "index.html" file. This probably means that the language setting for that file is Japanese.

I am testing the style sheet workaround. It works in that I cloud extract the CSS. But when I use unenex with the -sf option, I do not see any difference in the HTML files. The file is identical whether I use the -sf option or not.

I will follow up on this matter via email shortly. Please kindly check your inbox.

Just another quick comment: my browser always offers me to translate the page if I open the "index.html" file. This probably means that the language setting for that file is Japanese.

That was my mistake. I will fix it right away.


Float power of two

Custom Math.scalb() can be really faster than original version. Very strange, that huge performance impact was caused by use int instead of long when it is used as parameter to Double.longBitsToDouble(). For more details see created benchmark. There is a little mess, I can resolve it If the change accepted.

Closing this. I have integrated your code in main. Thank you very much! 🙂


[3.x] Update to Bot Api 6.6

https://core.telegram.org/bots/api#march-9-2023

There are a lot of BCs by Telegram 🥲


NodeJS MN: update subscribe/unsubscribe message format according to spec.

instead of "body.subscribe" or "body.unsubscribe" the latest spec uses "body.resources" for all types of subscribe/unsubsribe messages. (see spec. )
The NodeJS MN shall be updated accordingly.

This issue is relevant for D6.4. If not solved then the conformance tests will report missing features for the NodeJS node.

I'm documenting the situation for D6.4 as it is

Hi,
From WP-6 perspective, I am fine with this as we have to only assess the work in WP-6 and provide feedback to the technical WPs.
But from an overall perspective, this will raise issues in the final review, i.e.,

that a technical issue, that features having had worked before, were not working any more,
that this situation had been reported to the technical WPs, and
that a solution was not found within a month, nor was there a documented follow-up discussion.

Just my two cents.

Fixed, re-open if needed

not tested and confirmed yet --> re-opening


Add margin prop for TextField

The margin prop should be usable.
Its description is here: https://material-ui.com/api/text-field/
It can be useful to add vertical margins.

@alexplumb please commit :)

Thanks for the PR - I've decided to go in a different direction and instead add support for all remaining TextField props all at once.


common: Move Intel generation-specific config from cpu to gpu

Description of changes
These modules only included gpu configuration, so they belong in that location.
Things done

[ ] Tested the changes in your own NixOS Configuration
[ ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

@mergify queue


adds logging, adds min PHP version, adds Datastore to index.php

LGTM. The build is failing because it can not read the secret environment variables. How about to push a branch in this repo and create a PR from there?

closing in favor of #21


feat: Remove dev names for powerups

We are no longer in need of the dev names we have been using for the powerups as we have used the "string" words available in forge to create new names for them. They are now accurate and up to date.

Great job. Added up-to-date info about the Speed Boost powerup while looking over the changes.


How to fix OpenEphys .continuous with time discontinuities

Hey,
We have a similar issue to https://github.com/open-ephys/open-ephys-python-tools/issues/26, where some of the .continuous files have gaps during the recording. Since not all channels have gaps, I was wondering if the solution of @jsiegle still applies here:

Hi Nick – You can use the same method I posted previously to trim both the beginning and end of the recording: https://github.com/open-ephys/open-ephys-python-tools/issues/25#issuecomment-1764962078

We need to ensure that the recording data is continuous (no gaps) after trimming, so would it work if

iterate over all channels that have gaps
find the longest continuous part that works for these channels
trim all channels to this length
save each channel into a new .continous file

Yes, that should work! Make sure to take the file header into account (see the note I just added to #26)


Kudos: the app that complements annotation

Hi guoc,
many thanks for the app. It's doing a great job. As I see it from my point of view it complements what ZotFile for Zotero is doing. Especially useful is the option to extract all annotations using the macOS service menu and then saves every single highlight and note in a separate markup file.
Only it throws an error. Once I found out what it exactly is I'll let you know.
Again, thanks.
wolf

Hi stoettner,
Thank you for your nice words.
Could you give me some details of the error? Hope I can help.

Hi guoc,
thanks for getting back.
Please find an excerpt of the crash message below. I skipped the usually very lengthy crash thread. Hope this helps. Should you need more details let me know.
Process:               Excerptor [3667]
Path:                  /Applications/Excerptor.app/Contents/MacOS/Excerptor
Identifier:            name.guoc.excerptor.Excerptor
Version:               1.2 (4)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Excerptor [3667]
User ID:               501

Date/Time:             2017-04-19 10:01:24.382 +0200
OS Version:            Mac OS X 10.12.4 (16E195)
Report Version:        12
Anonymous UUID:        1373ECF1-C70E-AD77-83DA-F401758A6ED3

Sleep/Wake UUID:       61EB2B12-0C79-4FF7-8A1D-FECC0025F6DE

Time Awake Since Boot: 7800 seconds
Time Since Wake:       900 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_INSTRUCTION (SIGILL)
Exception Codes:       0x0000000000000001, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Illegal instruction: 4
Termination Reason:    Namespace SIGNAL, Code 0x4
Terminating Process:   exc handler [0]

Application Specific Information:
fatal error: /Users/stoettner/Library/Mobile Documents/com~apple~CloudDocs/ED-annotation/Lind et al. - 2015 - Statistical Techniques in Business and Economics/Parameter A characteristic of a population..md exists: file /Users/guoc/Developer/excerptor/Excerptor/Helpers/error-helper.swift, line 27

reg,
wolf

It looks like the annotation file had been created so that Excerptor found it existed already and reported this as an error.
In this report, the path is /Users/stoettner/Library/Mobile Documents/com~apple~CloudDocs/ED-annotation/Lind et al. - 2015 - Statistical Techniques in Business and Economics/Parameter A characteristic of a population..md, you can go to this path by:

Open Finder
In its menu, Go -> Go to Folder...
Copy and paste this path and Go
If the file is there, move it (perhaps the enclosing folder as well), and try again.

Excerptor is intended to stop when it finds the target file already exists. It seems inconvenient, but it can avoid data loss in some cases. This means you can export a PDF file's annotation only once. If you need export again, the annotation files generated before should be removed first.
If this does not fix the issue, please attach a screenshot of Extract Annotations as Files tab in your Excerptor preferences. Thank you.

Hi guoc,
found the issue. The error message
fatal error: /Users/stoettner/Library/Mobile Documents/com~apple~CloudDocs/ED-annotation/Lind et al. - 2015 - Statistical Techniques in Business and Economics/Parameter A characteristic of a population..md exists: file /Users/guoc/Developer/excerptor/Excerptor/Helpers/error-helper.swift, line 27```
is apparently correct since there are two annotation of identical phrasing - one in the text and identical one in the glossary of the book. Since I configured excerptor preferences to create file names according to the annotation's text you would get two identical files which the code correctly refuses.

All ok. Thanks again and keep up!
wolf

Excerptor should give users a notification about existent files rather than just crash. I'll keep this issue open until I fix it.


Fix controller RBAC permissions for leader election ConfigMap

This was broken with multi-nginx support.
Previously hardcoded/default election ID was since then made dynamic (for multi-nginx support), based on App i.e. helm release name, while RBAC permission/rule wasn't adjusted.

================================================================================
---- Global Information --------------------------------------------------------
> request count                                      50000 (OK=50000  KO=0     )
> min response time                                      0 (OK=0      KO=-     )
> max response time                                   2063 (OK=2063   KO=-     )
> mean response time                                   132 (OK=132    KO=-     )
> std deviation                                        153 (OK=153    KO=-     )
> response time 50th percentile                         89 (OK=89     KO=-     )
> response time 75th percentile                        189 (OK=189    KO=-     )
> response time 95th percentile                        423 (OK=423    KO=-     )
> response time 99th percentile                        699 (OK=699    KO=-     )
> mean requests/sec                                2083.333 (OK=2083.333 KO=-     )
---- Response Time Distribution ------------------------------------------------
> t < 800 ms                                         49730 ( 99%)
> 800 ms < t < 1200 ms                                 243 (  0%)
> t > 1200 ms                                           27 (  0%)
> failed                                                 0 (  0%)
================================================================================


CBS OData V4 is acceptable

What
Allowing the new OData version (V4) to be read. For further information:

https://www.cbs.nl/-/media/statline/documenten/odata4-overstappen-odata3.pdf
https://www.cbs.nl/nl-nl/onze-diensten/open-data/open-data-v4/snelstartgids-odata-v4

How

[ ] Create a parallel function for V4 to ingest datasets
[ ] Combine with existing V3 functions, to allow both scenarios

Belongs to nimbletl - issue should be deleted


move_base not working since using teb instead of base_local_planner

Hi,
after switching from base_local_planner to teb I get the following error message every time I give a new 2D navigation goal through rviz (similar to #125. If my new Issue is unwanted I can comment under #125, but I thought this might be a bit long for a comment in a somewhat dead Issue).
/home/moro01/catkin_ws/devel/lib/move_base/move_base: symbol lookup error: /opt/ros/kinetic/lib//libteb_local_planner.so: undefined symbol: _ZNK10costmap_2d12Costmap2DROS12getRobotPoseERN2tf7StampedINS1_9TransformEEE
[move_base-3] process has died [pid 4897, exit code 127, cmd /home/moro01/catkin_ws/devel/lib/move_base/move_base __name:=move_base __log:=/home/moro01/.ros/log/332d6ccc-b246-11e9-82f4-94c691a5aba3/move_base-3.log].
log file: /home/moro01/.ros/log/332d6ccc-b246-11e9-82f4-94c691a5aba3/move_base-3*.log

One warning that didn't show up with base_local_planner when launching move_base.launch is
[ WARN] [1564435799.756196141]: The inscribed radius of the footprint specified for TEB optimization (0.000000) + min_obstacle_dist (5.000000) are smaller than the inscribed radius of the robot's footprint in the costmap parameters<PHONE_NUMBER>86231570814527423731704356798070567525844996598917476803157260780028538760589558632766878171540458953514382464234321326889464182768467546703537516986049910576551282076245490090389328944075868508455133942304583236903222948165808559332123348274797826204144723168738177180919299881250404026184124858368.000000, including 'footprint_padding'). Infeasible optimziation results might occur frequently!

I have yet to find a solution since no changes in either my teb file or my costmap_common_params file fixed this warning.
My robot's footprint is 0.65 m x 0.485 m so I want to use the line footprint. If I want 0.20 m distance between the robot and obstacles my min_obstacle_dist has to be 0.485/2 + 0.20 = 0.4425 and the line ends at +-0.0825 (0.65/2 - 0.485/2 ) right?
Here are my files:
move_base.launch
<launch>

   <master auto="start"/>
   <!--master auto="start"/-->
 <!-- Run the map server -->
    <!--node name="map_server" pkg="map_server" type="map_server" args="$(find moro_2dnav)/mymap03.pgm 0.05"/-->
    <node name="map_server" pkg="map_server" type="map_server" args="$(find moro_2dnav)/buero_georg_map.pgm 0.050000"/>

 <!--- Run AMCL -->
    <include file="$(find amcl)/examples/amcl_diff.launch" />

   <!--node pkg="move_base" type="move_base" respawn="true" name="move_base" output="screen"-->
   <node pkg="move_base" type="move_base" respawn="false" name="move_base" output="screen">
    <rosparam file="$(find moro_2dnav)/costmap_common_params.yaml" command="load" ns="global_costmap" />
    <rosparam file="$(find moro_2dnav)/costmap_common_params.yaml" command="load" ns="local_costmap" />
    <rosparam file="$(find moro_2dnav)/local_costmap_params.yaml" command="load" />
    <rosparam file="$(find moro_2dnav)/global_costmap_params.yaml" command="load" />
    <rosparam file="$(find moro_2dnav)/base_local_planner_params.yaml" command="load" />

    <param name="base_local_planner" value="teb_local_planner/TebLocalPlannerROS" />
    <param name="controller_frequency" value="10.0" />

 </node>

</launch>

base_local_planner_params.yaml (teb file)
TebLocalPlannerROS:

 odom_topic: odom
 map_frame: /odom

 # Trajectory

 teb_autosize: True
 dt_ref: 0.3
 dt_hysteresis: 0.1
 global_plan_overwrite_orientation: True
 max_global_plan_lookahead_dist: 3.0
 feasibility_check_no_poses: 5

 # Robot

 max_vel_x: 0.4
 max_vel_x_backwards: 0.2
 max_vel_theta: 0.3
 acc_lim_x: 0.5
 acc_lim_theta: 0.5
 min_turning_radius: 0.0
 footprint_model: # types: "point", "circular", "two_circles", "line", "polygon"
   type: "line"
   radius: 0.2 # for type "circular"
   line_start: [-0.0825, 0.0] # for type "line"
   line_end: [0.0825, 0.0] # for type "line"
   front_offset: 0.2 # for type "two_circles"
   front_radius: 0.2 # for type "two_circles"
   rear_offset: 0.2 # for type "two_circles"
   rear_radius: 0.2 # for type "two_circles"
   vertices: [ [0.25, -0.05], [0.18, -0.05], [0.18, -0.18], [-0.19, -0.18], [-0.25, 0], [-0.19, 0.18], [0.18, 0.18], [0.18, 0.05], [0.25, 0.05] ] # for type "polygon"

 # GoalTolerance

 xy_goal_tolerance: 0.2
 yaw_goal_tolerance: 0.1
 free_goal_vel: False

 # Obstacles

 min_obstacle_dist: 0.4425
 include_costmap_obstacles: True
 costmap_obstacles_behind_robot_dist: 1.0
 obstacle_poses_affected: 30
 costmap_converter_plugin: ""
 costmap_converter_spin_thread: True
 costmap_converter_rate: 5

 # Optimization

 no_inner_iterations: 5
 no_outer_iterations: 4
 optimization_activate: True
 optimization_verbose: False
 penalty_epsilon: 0.1
 weight_max_vel_x: 2
 weight_max_vel_theta: 1
 weight_acc_lim_x: 1
 weight_acc_lim_theta: 1
 weight_kinematics_nh: 1000
 weight_kinematics_forward_drive: 1
 weight_kinematics_turning_radius: 1
 weight_optimaltime: 1
 weight_obstacle: 50
 weight_dynamic_obstacle: 10 # not in use yet
 alternative_time_cost: False # not in use yet

 # Homotopy Class Planner

 enable_homotopy_class_planning: True
 enable_multithreading: True
 simple_exploration: False
 max_number_classes: 4
 roadmap_graph_no_samples: 15
 roadmap_graph_area_width: 5
 h_signature_prescaler: 0.5
 h_signature_threshold: 0.1
 obstacle_keypoint_offset: 0.1
 obstacle_heading_threshold: 0.45
 visualize_hc_graph: False

costmap_common_params.yaml
obstacle_range: 2.5
raytrace_range: 3.0
footprint: [[-0.325, -0.2425], [-0.325, 0.2425], [0.325, 0.2425], [0.325, -0.2425]]
#robot_radius: ir_of_robot
inflation_radius: 0.62

observation_sources: laser_scan_sensor

laser_scan_sensor: {sensor_frame: base_laser, data_type: LaserScan, topic: scan, marking: true, clearing: true}

Hi,
I am no expert in TEB (yet), but it seems you have configured the robot footprint as a box/polygon in costmap_common_params.yaml, but in base_local_planner_params.yaml (teb file) you define the footprint_model as "line". In TEB, try and define your robot as "polygon" with the same values as in costmap_common_params.yaml.
Alternatively you can try and set both to a circle, just for testing. That would be robot_radius in costmap_common_params.yaml, and type: "circular", and set the same radius.

The linker error is probably due to different versions for move_base and the teb_local_planner.
Are you mixing kinetic and melodic?
Refer to this question and answers.

Hi,
yes it seams as the issue was due to different versions, although I used kinetic for both and both should have been up to date.  Building move_base from src fixed it anyway.
Thank you for your help.


Frontend - Search Events/Home Feed - Build event details card components

Build card components to display event details for search events page and home feed.
Details should include:

Date/Time
Location
Event Title
Brief Description???

********TESTING

event Details card on profile page & event details page are rendering proper information
needs testing on search Events page
@ReginaFera13 i believe this would be a good one for you to test on searchEvents page


[BUG] Cannot execute Deploy SAP workload zone if deployer is behind a proxy

Describe the bug
A clear and concise description of what the bug is.
My deployer VM is behind a proxy solution. So I adjusted the environment variables of the deployer to reflect the proxy is used. I also added the proxy's certificates and updated the certificate store.
sudo cp *.crt /usr/local/share/ca-certificates/
cd /usr/local/share/ca-certificates/
ls -la
sudo update-ca-certificates
sudo -i
vi /etc/environment
and insert
# to support proxy
export http_proxy=http://proxy.contoso.com:8080
export https_proxy=http://roxy.contoso.com:8080
export NO_PROXY=localhost,<IP_ADDRESS>,*.contoso.com,<IP_ADDRESS>

The problem with the Pipeline "Deploy SAP workload zone" is, that it is generating a script which is then executed with /bin/bash --noprofile basically ignoring all environment variables.
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/azureadm/agent/_work/_temp/ade1759d-30ba-4616-a2a9-3ab03e72ea75.sh

--- Install Terraform ---
##[error]Unable to download Terraform version 1.2.6.
##[error]Bash exited with code '2'.

To reproduce
Steps to reproduce the behavior:
Use --noprofile --norc:

   --noprofile
          Do  not  read either the system-wide startup file /etc/profile or any of the personal initializa‐
          tion files ~/.bash_profile, ~/.bash_login, or ~/.profile.  By default,  bash  reads  these  files
          when it is invoked as a login shell (see INVOCATION below).

   --norc Do  not  read  and  execute the system wide initialization file /etc/bash.bashrc and the personal
          initialization file ~/.bashrc if the shell is interactive.  This option is on by default  if  the
          shell is invoked as sh.

Expected behavior
A clear and concise description of what you expected to happen.
Proxy variables should be used or somehow handed over in the variable group.
Additional context
Add any other context about the problem here.

try to put the settings in here: /etc/environment

also set the required settings in the .env file from the devops agent and restart the agent

Hi @enterprise-1701-d , OK to close this one?

The workaround is ok. Issue will be closed.


proposal: push error map onchain and show abort reason when txn failed.

Proposal Details
Fow now, if a txn fails, the output message is like:
    "status": {
      "type": "moveabort",
      "location": "0x2::module_store",
      "abort_code": "2"
    }

or
    "vm_error_info": {
      "error_message": "VMError with status ABORTED with sub status 2 at location Module ModuleId { address:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000002, name: Identifier(\"module_store\") } and message 0x0000000000000000000000000000000000000000000000000000000000000002::module_store::publish_package_entry at offset 62 at code offset 62 in function definition 25",
      "execution_state": []
    }

The developer need to check the source file for the reason or use rooch move explain to expain framework's abort reason. And what's more to auto explain the reason to end user.
Proposal
Can we store error map onchain when publishing modules, and then add an abort reason field in the transation output?

We can explain the error code in the vm_error_info


Add support for jest snapshots

Language name
Jest snapshots
URL of example repository
https://github.com/typescript-eslint/typescript-eslint/blob/132c0780f2b155e8a7355c449b2e98ed3fec2c6d/packages/parser/tests/lib/__snapshots__/services.ts.snap
URL of syntax highlighting grammar
https://github.com/jest-community/vscode-jest/blob/master/syntaxes/jest-snapshot.tmLanguage
Most popular extensions

.snap
.ts.snap
.js.snap
.tsx.snap
.jsx.snap
Detected language

None.

current github highlighting
highlighting in vscode using the above grammar

Thanks so much for adding this so quickly! This will be a huge win for the entire JS community :)


[ ] I have added a relevant changelog to CHANGELOG.md
[ ] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.
[ ] I have updated API documentation client/docs/swagger-ui/swagger.yaml

You should apply new interface for module which implement BeginBlock or EndBlock (e.g. capability)


Update font for chips

should use bodyS

oups it is good, nothing to do, can be closed

oups it is good, nothing to do, can be closed


Can provide accent control settings

As a home cook, I can listen to video tutorials out loud in my own accent so that I can cook at the same time.


Option to force-open a device

Dear all,
it would be great if this library would optionally allow one to force-open an I2c device (I guess, using I2C_SLAVE_FORCE) similar to what the i2cget and i2cset tools do with the -f option. I know this is very dangerous but there are situations where one does not have many other options, so it would be great to be able to do this!
Best,
Michael
Background: what I would use this for: Basically, a dirty hack.. I want to change the exposure of the camera of the device I'm working with (custom ARM board using an NXP iMX8M Mini SoC). Normally, one would do this using the Video4Linux2 API (basically an ioctl call). However, even though the camera driver supports this (I wrote it:) NXP's low-level V4L2 stack seems to not forward the ioctl calls correctly. This is a known problem and NXP refuses to do anything about it. As a dirty work-around, I just directly write to the camera's registers using i2cset and would now like to transfer this to our Rust application. Since the camera's I2c address is already associated with the camera driver in the device tree I need to force-open it from userspace.

Any reason why this hasn't been implemented yet? I'd also like to use this, and looking at the source, the changes seem minimal enough.


Fix to have length guard

Summary
If it isn't broke, don't fix it.
I reverted back to the original guard since the type hasn't changed and it was an ugly nest of conditions.
Test plan
Added a new test case.

fixes #9792

@SimenB @nfantone sorry again - I've reverted the check and added a test for the future.

Codecov Report

Merging #9796 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9796   +/-   ##
=======================================
  Coverage   64.87%   64.87%
=======================================
  Files         288      288
  Lines       12206    12206
  Branches     3023     3025    +2
=======================================
  Hits         7919     7919
  Misses       3646     3646
  Partials      641      641

Impacted Files
Coverage Δ

packages/expect/src/matchers.ts
96.86% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff87b43...dcb561b. Read the comment docs.

Thanks! 😃

Thanks indeed!


bytes 0.4

It would be great if dev-dependency bytes would be upgraded to 0.4.
Thanks in advance!

And the env_logger to 0.5 or 0.6 too :)

Great idea! PRs accepted :)


How to use with ShardingManager

https://discordjs.guide/sharding/#when-to-shard

Why was this closed? I'm curious as to how you would use this with sharding? Is it just supported out of the box?

Its not support sharing

@xKamaiL I wrote up a small guide on how to get sharding to work with this package here.


No sound Need to restart Kodi

Hello
Thanks for this app, i have a problem with sound.
After start android kodi launch with no sound i quit and restart kodi to have sound.
Thanks for help

I think its need a delay added to start sound before KODI

need a delay added? at startup android?

I don't think a delay is the proper solution. Instead, it should likely wait for the BOOT_COMPLETED broadcast.

Yes!!

I'm pretty sure this is a duplicate of #7

Yep -:)

Please try version 2.4 that was just pushed to the Play Store (it should show up within a few hours). I'm not sure if it will solve your specific problem as Kodi will still launch before the BOOT_COMPLETED broadcast is sent but the broadcast should at least be sent in the background.


acme-sh: 2.8.8 -> 2.8.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/acme.sh/versions.
meta.description for acme-sh is: "A pure Unix shell script implementing ACME client protocol"
meta.homepage for acme-sh is: "https://acme.sh/"
meta.changelog for acme-sh is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/4m4fpv2ymlkwifikijx8bwidi8dxfiz3-acme.sh-2.8.9/bin/acme.sh passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 2.8.9 with grep in /nix/store/4m4fpv2ymlkwifikijx8bwidi8dxfiz3-acme.sh-2.8.9

found 2.8.9 in filename of file in /nix/store/4m4fpv2ymlkwifikijx8bwidi8dxfiz3-acme.sh-2.8.9

directory tree listing: https://gist.github.com/eefee93aa72d790637073889d754d36f

du listing: https://gist.github.com/9b441643dc5bdac255a4ae9ab1911a07

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
acme-sh

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4m4fpv2ymlkwifikijx8bwidi8dxfiz3-acme.sh-2.8.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A acme-sh https://github.com/r-ryantm/nixpkgs/archive/af9787542caa780ca73844e281872a14e5995ae9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4m4fpv2ymlkwifikijx8bwidi8dxfiz3-acme.sh-2.8.9
ls -la /nix/store/4m4fpv2ymlkwifikijx8bwidi8dxfiz3-acme.sh-2.8.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

acme-sh

Maintainer pings
cc @yorickvp for testing.

Result of nixpkgs-review pr 121665 at af978754 run on x86_64-linux 1

1 package built successfully:

acme-sh

2 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/admin/acme.sh/default.nix:15:3:
   |
15 |   installPhase = ''
   |   ^

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/tools/admin/acme.sh/default.nix:33:5:
   |
33 |     license = licenses.gpl3;
   |     ^


KOGITO-9463: Create a new guide describing the Job Services Quarkus Extensions

JIRA:

Description:

Please make sure that your PR meets the following requirements:

[x] You have read the contributions doc
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[x] The nav.adoc file has a link to this guide in the proper category
[x] The index.adoc file has a card to this guide in the proper category, with a meaningful description

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Great! The drawio files are intended to be in this PR? thinking As backup to regen the pngs?

Exactly, let's try to keep them for future doc updates, etc.

@radtriste I think all the suggestions are addressed.

@ricardozanini feel free to merge


Fix rewind data index

Rewind Data Index was indexing too much (new UTXO as well as spent UTXO) and it was overwriting UTXO that where not spend but still pulled from disk (this is due to the nature of how coinview works where all the UTXOs of a trx are loaded even though not all inputs are spent n the block)

@dangershony , does this also fix the ConsensusManager_Fork_Occurs_When_Stake_Coins_Are_Spent_And_Found_In_Rewind_Data test case? I believe this was the cause for the test to fail.

Synced stratis testnet this is now good to push


Swap deprecation flag with comment in Program proto.

Until we get RunContexts plumbed through Cirq, we'll rely on implementers to handle deprecation warnings, as the current compile-time deprecations are causing hard errors in our build system.

Berore you merge, can you check that the deprecated proto option doesn't affect generated code?

That's a great point, @viathor -- checking now

Chatted with @lindmarkm -- we no longer need this :)


Added new changes in BinarySearchTree

Riyad,
I have added the following things

ValidateTree - Gives the whole tree is valid or not (check whether
child's parent has that as child in either Left or Right.)
PreOrderTraversal - Helps to get the all the nodes in PreOrder. This
helps to get the overall Tree Structure
Corrected the Re-Orient functionaly in Transpose
Added Test for the above changes

Thanks for your time. Let me know if you got any queries regarding the above changes.
Regards,
Mohan Prasath S J

Converted NullNode to Singleton and changed List to IList. You can merge to your code. Let me know if there is any change.
Thanks. :)

Thanks for the PR!
Can you add a travis build for this project? I don't use Windows anymore, so it's hard for me to see if the code is compiling.

HI Riyad,
I haven't tried travis build before. I will check on that this weekend.
Thanks:)


Paimon is down. Cannot get short-term dev free token.

I cannot get WECHATY_PUPPET_SERVICE_TOKEN as described here.

Please refer to the official Paimon documentation at https://wechaty.js.org/docs/puppet-services/paimon

I think you can get a short term token.


Completed Anagram Checker assignment

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Implementing an Anagram Checker function with two variations:

A case-insensitive version that checks if two words are anagrams
An enhanced version that allows optional case sensitivity

What did you learn from the changes you have made?

How to manipulate strings using .lower() method
Using sorted() to compare character sequences
Implementing boolean logic for case-sensitive comparisons

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Manually counting letter occurrences with a dictionary

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Understanding the precise definition of an anagram
Ensuring case-insensitive comparisons work correctly
Maintaining code simplicity while adding functionality

How were these changes tested?
Tested with provided examples:

anagram_checker("Silent", "listen") → True
anagram_checker("Silent", "Night") → False
anagram_checker("night", "Thing") → True
anagram_checker("Silent", "Listen", True) → False

A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

you did a great job here!
Please go ahead and close this pull request now. Thanks!


Intl round doubles wrong

Bug
When the last decimal to round is a 5:

If there are 2 decimals (ex: 10.45 ) it will round wrong if the first decimal is 8 or 9 (10.85 -> 10.8, 10.95 -> 10.9)
If there are 3 decimals (ex: 10.495 ) it will round wrong if the first decimal is >=2 (10.295 -> 10.29, 10.495 -> 10.49)

To Reproduce
void main(List<String> arguments) {
  // Correct: Round 12.5 -> 13 expected 13
  print(
      NumberFormat.simpleCurrency(name: 'USD', decimalDigits: 0).format(12.5));
  // Correct: Round 12.75 -> 12.8 expected 12.8
  print(
      NumberFormat.simpleCurrency(name: 'USD', decimalDigits: 1).format(12.75));
  // Inorrect: Round 12.85 -> 12.8 expected 12.9
  print(
      NumberFormat.simpleCurrency(name: 'USD', decimalDigits: 1).format(12.85));
  // Inorrect: Round 12.95 -> 12.9 expected 13.00
  print(
      NumberFormat.simpleCurrency(name: 'USD', decimalDigits: 1).format(12.95));
  // Correct: Round 12.195 -> 12.20 expected 12.20
  print(NumberFormat.simpleCurrency(name: 'USD', decimalDigits: 2)
      .format(12.195));
  // Inorrect: Round 12.295 -> 12.29 expected 12.30
  print(NumberFormat.simpleCurrency(name: 'USD', decimalDigits: 2)
      .format(12.295));
  // Correct: Round 12.29500000001 -> 12.30 expected 12.30
  print(NumberFormat.simpleCurrency(name: 'USD', decimalDigits: 2)
      .format(12.29500000001));
}

System info
Dart SDK 3.3.0
Flutter SDK 3.19.0
intl 0.19.0

Same question with more precision.
// Got 1.123 expected 1.124
NumberFormat("#.###").format(1.1235)

I believe this is working as intended, see the example in the docs.

Okay, but this really looks strange.
In the following example, I make the pattern one character shorter than the input each time to test the round function, and the last digit is sometimes 6 and sometimes 5.
  print('#       ${(NumberFormat("#") as dynamic).format(5.5)}');
  print('#.#     ${(NumberFormat("#.#") as dynamic).format(5.55)}');
  print('#.##    ${(NumberFormat("#.##") as dynamic).format(5.555)}');
  print('#.###   ${(NumberFormat("#.###") as dynamic).format(5.5555)}');
  print('#.####  ${(NumberFormat("#.####") as dynamic).format(5.55555)}');
  print('#.##### ${(NumberFormat("#.#####") as dynamic).format(5.555555)}');

  print('#.#     ${(NumberFormat("#.#") as dynamic).format(5.550001)}');

Output：
#       6
#.#     5.5
#.##    5.55
#.###   5.556
#.####  5.5556
#.##### 5.55556
#.#     5.6

In my understanding, regardless of whether mathematical rounding or banker's rounding(IEEE 754) is used, the result should be the same, either all 5s or all 6s.

 This is not true. For example:
void main() {
  print(5.5.toStringAsFixed(20)); // 5.50000000000000000000
  print(5.55.toStringAsFixed(20)); // 5.54999999999999982236
  print(5.555.toStringAsFixed(20)); // 5.55499999999999971578
  print(5.5555.toStringAsFixed(20)); // 5.55550000000000032685
  print(5.55555.toStringAsFixed(20)); // 5.55555000000000021032
  print(5.555555.toStringAsFixed(20)); // 5.55555500000000002103
  print(5.5555555.toStringAsFixed(20)); // 5.55555549999999964683
  print(5.55555555.toStringAsFixed(20)); // 5.55555555000000023114
}

The reason why the floating point value (using a representation that is specified in IEEE 754) cannot precisely represent a value like 5.55 is that it uses the binary rather than the decimal number system. There is simply no finite sequence of binary digits that yields the value 5.55. In contrast, 5.5 decimal is exactly 101.1 binary.
It's somewhat similar to the situation with the decimal number system and a value like a third: values like 0.3, 0.33, 0.333 are better and better approximations of one third, but there is no finite sequence of digits that encodes one third exactly.
Using the number system with base 3 it would be trivial: 0.1 (as a "ternary" number) is exactly one third.
When you don't start out with precisely 5.55 but rather have 5.54999999999999982236 (approximately, because we are now looking at a decimal encoding of a value which was given in binary ;-), rounding will behave differently.
So it is still working as specified. ;-)

OMG!
I can't believe I was so foolish to forget about the precision loss issue with float/double.
@mosuem You're absolutely right, this is working as intended.
@eernstg Thank you so much for clarifying this for me.


osx系统 3.6 pip安装失败

ERROR: Could not install packages due to an EnvironmentError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/3d/28/e74af1f93e5b4efdd79ddf4363f689bd0801a3037ba3741c9a5d85954a2c/tqsdk-1.1.0-py3-none-any.whl (Caused by NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x104b72b00>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',))

问题未重现


Thrown error

Just wanted you to inform you about an error being thrown:

Error
73050.ed28c446e39c70b0c6c0.js:1 [BetterDiscord] [Patcher] Could not fire after callback of renderAttachments for ECBlocks TypeError: res.props.attachments is not iterable
    at Object.eval [as callback] (EnhanceCodeBlocks.plugin.js:976:47)
    at eK.<anonymous> (renderer.js:5:23163)
    at eK.render (8ffaad5d94980deea02d.js:1:306846)
    at o_ (44076.b5f9426088ebaff2b53a.js:12:914886)
    at og (44076.b5f9426088ebaff2b53a.js:12:914684)
    at u (44076.b5f9426088ebaff2b53a.js:12:956156)
    at sB (44076.b5f9426088ebaff2b53a.js:12:938190)
    at 44076.b5f9426088ebaff2b53a.js:12:938056
    at sF (44076.b5f9426088ebaff2b53a.js:12:938064)
    at sT (44076.b5f9426088ebaff2b53a.js:12:933101)
    at x (44076.b5f9426088ebaff2b53a.js:12:1125228)
    at A (44076.b5f9426088ebaff2b53a.js:12:1125758)
    at D.<computed> (44076.b5f9426088ebaff2b53a.js:1:500866)
    at M (44076.b5f9426088ebaff2b53a.js:1:500631)
    at MessagePort.k (44076.b5f9426088ebaff2b53a.js:1:500690)
t.<computed> @ 73050.ed28c446e39c70b0c6c0.js:1
(anonymous) @ VM10476 43455.8c79ce3e1753b38de4a4.js:23
_log @ renderer.js:5
err @ renderer.js:5
(anonymous) @ renderer.js:5
render @ 8ffaad5d94980deea02d.js:1
o_ @ 44076.b5f9426088ebaff2b53a.js:12
og @ 44076.b5f9426088ebaff2b53a.js:12
u @ 44076.b5f9426088ebaff2b53a.js:12
sB @ 44076.b5f9426088ebaff2b53a.js:12
(anonymous) @ 44076.b5f9426088ebaff2b53a.js:12
sF @ 44076.b5f9426088ebaff2b53a.js:12
sT @ 44076.b5f9426088ebaff2b53a.js:12
x @ 44076.b5f9426088ebaff2b53a.js:12
A @ 44076.b5f9426088ebaff2b53a.js:12
D.<computed> @ 44076.b5f9426088ebaff2b53a.js:1
M @ 44076.b5f9426088ebaff2b53a.js:1
k @ 44076.b5f9426088ebaff2b53a.js:1

I pushed a fix couple days ago, you just need to download it from github

Awesome!
Sorry for wasting your time then xd


[#1] Create initial Infrastructure

Adding the draft of an shared lib, binary, test and docs.

Dúvida: qual versão do CPP eu preciso pra rodar isso aqui? Chances de colocar o quickstart no readme?

There is an issue to it, please check out #2


there're errors because of whatsappweb.js and puppeteer updates

the bot crached since the latest updates . I hope you'll fix it soon

the bot crached since the latest updates . I hope you'll fix it soon

It would be helpful if you could provide error logs.


Include the number of observations in the levels when using groups in dotplot.

Format legend items as "Level Name (n=XX)".

Bumped from #25


Feature/frontend

Merging the first chunk back to master. Doesn't interfere much with anything else anyway.


System unavailable: DTK: test-macstadium-macos11-arm64-1

Please put the system name in the title of this issue.

Link to any log file showing the problem:

Please describe the issue:
Unable to connect to the machine over ssh although the jenkins script conols still seems live and able to respond to commands. -2 is ok.

Latest output in the ssh -vvv (it somehow locks up my terminal at this point so I can't abort the ssh client) is:
debug3: Ignored env COLORTERM
debug3: Ignored env _
debug2: channel 0: request shell confirm 1
debug3: send packet: type 98
debug2: callback done
debug2: channel 0: open confirm rwindow 0 rmax 32768

The machines were sent back to Apple because the DTK program has ended.


Checkboxes are not getting updated in Live Preview

Hi! I looked at the existing issues and I'm not sure if this is related to this: https://github.com/valentine195/obsidian-admonition/issues/9
The problem is that ticking a checkbox doesn't update the source / doesn't get saved in Live Preview. It works in Reading mode though, so it's not a big deal - I just thought to report it in case it's something simple :)

Is this for blockquote style or codeblock style?

Codeblock style - thanks for looking into it and good luck!

I just ran into the same issue.
Apart from not retaining the "checked" status, it also doesnt seem to apply the "normal" checkbox css (in this case strikethrough).
I would really be awesome if it was possible to fix this, as admonitions is awesome with multiple columns for large amounts of checkboxes.

I recommend using the new Obsidian Callout core feature available in the insider build if you need checkboxes inside callout boxes. Because it is tightly integrated, it does not have some of the issues that Admonitions has to work around.

Why was this closed?
Checkboxes still do not work in callout admonitions.
Was this tested / confirmed that checkboxes would work in callout boxes before closing?

If checkboxes do not work in callouts, you need to submit a bug report on the Obsidian forums.


⚠ Bofrost.at has degraded performance

In faa3eda, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2244 ms

Resolved: Bofrost.at performance has improved in 6ebeb5f.


GH-35754: [CI][GLib] Don't build static C++ libraries

Rationale for this change
GLib doesn't use static C++ libraries.
What changes are included in this PR?
Disable building static C++ libraries.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Closes: #35754

@github-actions crossbow submit c-glib


Git tag aliases

There aren't any git tag aliases. If you use git, you probably use tags. If you don't use aliases, you're inefficient.
This PR will make you more efficient.

If you can rebase this against master, these seem like a worthwhile addition.

Merged in 4325f74f9dfc83d01409c78fd126a5d29f0a3a55. Thanks for your contribution!


bug in cURLUploader.ps1

If you are using wildcards in a cUrl task, the cURLUploader.ps1 generates a command like:
curl --stderr - -T {"file1","file2"} destination
This is not correct, curl will give an error saying Couldn't resolve host "file2"
the appropriate command should be:
curl --stderr - -T "{file1,file2}" destination
If you change line 54 in  cURLUploader.ps1 from
$uploadFiles = '{"' + [System.String]::Join('","', $foundFiles) + '"}'
to
$uploadFiles = '"{' + [System.String]::Join(',', $foundFiles) + '}"'
it works fine.

Thanks!  Want to do a PR?

It turns out this is fixed in the TypeScript version of this task and the .ps1 version no longer exists.  StijnVA, are you able to update to the new version of the task?  Can I help you do that?
Example I see with the TypeScript version of the task:
curl -T {C:/a/1/s/Tractionware.Services/Accounts/AccountsService.cs,C:/a/1/s/Tractionware.Services/Accounts/AccountsServiceDataSql.cs,C:/a/1/s/Tractionware.Services/Accounts/ApplicationConstants.cs,C:/a/1/s/Tractionware.Services/Accounts/AuthTokenDecoding/IAuthTokenDecoder.cs....

@DavidStaheli yes please. If you could point me to a guide for doing so I would be great-full.

Sorry for the delay, @StijnVA.  Here are the instructions.  Please let me know if you encounter any trouble.

Ensure that your username is in the top-level “Agent Pool Administrators” group to manipulate build tasks.
If your client machine does not already have it, install Node.js 4.x and npm 2.14.20 or later.
If your client machine does not already have it, install the TFS Cross-platform Command Line Interface: npm install -g tfx-cli
Extract the attached ZIP to a local directory: cURLUploader.zip
Login and upload the extracted directory to TFS:

tfx login --service-url https://yourTFSServer/tfs
tfx build tasks upload --task-path myExtractedFolderName
You should see output similar to this:

TFS Cross Platform Command Line Interface v0.3.22
Copyright Microsoft Corporation
Task at /home/myUsername/myExtractedFolderName uploaded successfully!


Version 5.0.4 -> 5.1.3 does not convert tsx element when element is deconstructed behind condition

Bug Report
Hello Typescript team!
I found this bug when changing versions from 5.0.4 to 5.1.3. I have a work around but thought I'd let you know!
🔎 Search Terms
webpack typescript v5.1.3 react
🕗 Version & Regression Information

No crash occurs, only when webpack parses the converted typescript (javascript) files did I spot this bug
This changed between versions 5.0.4 and 5.1.3

💻 Code
The following code would not convert the 'html' behind the deconstructed conditional object to javascript (i.e. React.createElement)
<Accordion
      label={
        <AccordionLabel
          heading={'Names'}
          info={`${routingTableChangesSummary.nameChanges} name${routingTableChangesSummary.nameChanges > 1 ? 's' : ''} changed`}
        />
      }
      {...(routingTableChangesSummary.nameChangesDetails
        ? {
            expandedContent: (
              <ChangeDetailsTable
                totalChanges={routingTableChangesSummary.nameChanges}
                changeDetails={routingTableChangesSummary.nameChangesDetails}
                emptyCellText="(empty)"
              />
            )
          }
        : undefined)}
    />

🙁 Actual behavior
The code snippet above would convert to:
React.createElement(Accordion, Object.assign({ label: React.createElement(AccordionLabel, { heading: 'Names', info: `${routingTableChangesSummary.nameChanges} name${routingTableChangesSummary.nameChanges > 1 ? 's' : ''} changed` }) }, (routingTableChangesSummary.nameChangesDetails
                ? {
                    expandedContent: (<ChangeDetailsTable totalChanges={routingTableChangesSummary.nameChanges} changeDetails={routingTableChangesSummary.nameChangesDetails} emptyCellText="(empty)"/>)
                }
                : undefined)))

You can see it leaves the ChangeDetailsTable as html
🙂 Expected behavior
It should convert to the code below (it did in 5.0.4 but changed in 5.1.3):
React.createElement(Accordion, Object.assign({ label: React.createElement(AccordionLabel, { heading: 'Names', info: `${routingTableChangesSummary.nameChanges} name${routingTableChangesSummary.nameChanges > 1 ? 's' : ''} changed` }) }, (routingTableChangesSummary.nameChangesDetails
                ? {
                    expandedContent: (React.createElement(ChangeDetailsTable, { totalChanges: routingTableChangesSummary.nameChanges, changeDetails: routingTableChangesSummary.nameChangesDetails, emptyCellText: "(empty)" }))
                }
                : undefined)))

Work around
Replacing the use of the deconstructor ...({}) with && allowed typescript to pick up the html correctly.
<Accordion
      label={
        <AccordionLabel
          heading={'Names'}
          info={`${routingTableChangesSummary.nameChanges} name${routingTableChangesSummary.nameChanges > 1 ? 's' : ''} changed`}
        />
      }
      expandedContent={
        routingTableChangesSummary.nameChangesDetails && (
          <ChangeDetailsTable
            totalChanges={routingTableChangesSummary.nameChanges}
            changeDetails={routingTableChangesSummary.nameChangesDetails}
            emptyCellText="(empty)"
          />
        )
      }
    />

Honestly this is a cleaner way to code this so we'll be continuing with our change, probably low priority but again might as well let you know. If you need anything else just drop me a reply and I'll get back to you when I can!
Thanks for your time,
Joe

Duplicate of https://github.com/microsoft/TypeScript/issues/54411.
My search terms were jsx in:title.


Fix start-up bug in start.sh

The quit parameter was in a new line. That results
in idling of the steamcmd. Now it'll quit

:+1:


Last release version has broken Signed Cookie

This commit https://github.com/flowplayer/flowplayer-hlsjs/commit/3471d29a74882bc5e7530103f045a2f5a37be3bd#diff-94f13f3a9cd67338f3d3e142b0a9708dL310 has broken Signed Cookie for CloudFront.
We use following settings:
params.hlsjs = { xhrSetup: function(xhr, url) { xhr.withCredentials = true; } };
Which is no more used with latest release. This is a big problem as well as you do not provide any tags to rollback on previous version, we have to use last version from online repository.

Very sorry about that. Reverted that change.
Should be ok now. Unless it was actually caused by a breaking change in hls.js v0.6.2-7. Will check that now.

@DrySs - I checked with loader, pLoader and other functions, but overlooked https://github.com/dailymotion/hls.js/issues/697


Update status badges

Fix for none gitlab repos

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Enable encryption at host on RP

Which issue this PR addresses:
Fixes https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/8971765
What this PR does / why we need it:
Enable encryption at host on RP VMs, as they handle crypto.
Test plan for issue:
I have manually validated that all our RP regions have the EncryptionAtHostSupported feature flag set.
Manual deploy to INT worked but I needed to do the following on the subscription - wonder if this will need to go into the deployer?
az feature register --namespace Microsoft.Compute --name EncryptionAtHost
...wait...
az provider register -n Microsoft.Compute

Is there any documentation that needs to be updated for this PR?
No.

az feature register --namespace Microsoft.Compute --name EncryptionAtHost
...wait...
az provider register -n Microsoft.Compute

Currently we never do any provider registrations on any of our subs. And we will be re-using existing subs from service tree.
I think we should not retrofit this and just do JIT, bash via all subs and enable this.
When we build Gov cloud, we can add this into the deployer. Now, this would be like duct taping something in without full feature.

az feature register --namespace Microsoft.Compute --name EncryptionAtHost
...wait...
az provider register -n Microsoft.Compute

Currently we never do any provider registrations on any of our subs. And we will be re-using existing subs from service tree.
I think we should not retrofit this and just do JIT, bash via all subs and enable this.
When we build Gov cloud, we can add this into the deployer. Now, this would be like duct taping something in without full feature.

I think we should not retrofit this and just do JIT, bash via all subs and enable this.

@mjudeikis I disagree:

Who wants more TOIL?
We have some regions where the feature doesn't appear to be available (yet?), so keeping track of this automatically is the way to go.

I've updated the PR to automate this - PTAL.  Ihink this is worth merging and debugging as we go.  WDYT?

I think we should not retrofit this and just do JIT, bash via all subs and enable this.

@mjudeikis I disagree:

Who wants more TOIL?
We have some regions where the feature doesn't appear to be available (yet?), so keeping track of this automatically is the way to go.

I've updated the PR to automate this - PTAL.  Ihink this is worth merging and debugging as we go.  WDYT?


fix(KFLUXBUGS-1156): only publish when publish flag is true

we first need to inspect the publish-on-push flag before we actually try to publish the image.
this gives Product Owners the ability to hide content.

/retest release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

@scoheb the task version and README needs to be updated before we merge.

@scoheb the task version and README needs to be updated before we merge.

good catch! updated!


Option to disable logging of stopwatches (2nd try)

[Issue #1067 - Marc Stern]

Same concerns of #1403. Working on it.

Merged. thanks!


require() local script with additionalContextRoots works differently in pre-request and post-request code

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
I'm building a small shared module for cross cutting needs that will be used in all my collections.
But when I try to include file from additionalContextRoots - require() behavior is different in pre-request and post-response steps:

pre-request - everything works as expected
post-response -  Error invoking remote method 'send-http-request': VMError: Cannot find module '../_bruno-scripts/foo.js'

Reproducing it should be quite straightforward. Repro collection attached.
What I'm trying to do is to have a common library with log() in foo.js file above collection. And I want to require it in both - collection pre-request and post-response scripts (so I have Log statement invoked before and after  any call )
Dev Console :

Expected to see : LOG post-response as a last message, but getting
Error invoking remote method 'send-http-request': VMError: Cannot find module '../_bruno-scripts/foo.js'

in main window.
Hardware :
 CPU Arch: M1
 OS: MacOS Sonoma 14.6.1 (23G93)
 Bruno v1.26.2
  electron	: 31.2.1
  chrome	: 126.0.6478.127
  node	: 20.15.0
  v8	: <IP_ADDRESS>-electron.0

.bru file to reproduce the bug
bruno.json
{
  "version": "1",
  "name": "Example Bruno collection",
  "type": "collection",
  "ignore": [
    "node_modules",
    ".git",
    ".vscode"
  ],
  "scripts": {
    "additionalContextRoots": [
      "../_bruno-scripts"
    ],
    "moduleWhitelist": [
      "form-data"
    ],
    "filesystemAccess": {
      "allow": true
    }
  }
}

collection.bru
auth {
  mode: none
}

script:pre-request {
  console.log("-------------- PRE-REQUEST:")
  var tools = require('../_bruno-scripts/foo.js')
  tools.log("LOG pre-request")
}

script:post-response {
  console.log("-------------- POST-RESPONSE")
  var tools = require('../_bruno-scripts/foo.js')
  tools.log("LOG post-response")
}

TestCall.bru (can be anything):
meta {
  name: TestCall
  type: http
  seq: 2
}

get {
  url: https://webhook.site/0d6eeef8-c745-4895-a566-65e9f6ef0bef
  body: none
  auth: none
}

_bruno-scripts/foo.js (above collection folder) :
const helpers = {
  log: function (str) {
    var now = new Date();
    var res = str
    if (typeof str === 'object')
      res = JSON.stringify(str)

    console.log(`${now.toISOString()} > ${res}`);
  },

}
module.exports = helpers;

Screenshots/Live demo link
https://github.com/user-attachments/assets/59f02912-b57f-4fc1-be86-a24ae987f971

#1397 fixes this, it's been unmerged for a long time


Multiple row/colTrees: fix functions

https://github.com/microbiome/mia/issues/286

I'm not sure where this comes from; I'm not able to reproduce it
https://github.com/microbiome/mia/runs/7951632999?check_suite_focus=true#step:20:262

I do not immediately recognize the source either... what should we do about it? If it works otherwise well.

The error occurs here https://github.com/vegandevs/vegan/blob/fab100aa42dd10c1a780f654b6718926ff556d3b/R/ordConstrained.R#L357
Not 100% sure, but it looks that the if is not as strict as it should be

Good? This should be merged next

good as far as I can see - !


Fixed delete duplicate user button

I rule and have completed some work on Case Manager that's ready for review!
Changed from button to link_to
This pull request makes the following changes:

Fixed delete duplication patient to not fire on update.

It relates to the following issue #s:

Fixes #1407

Codecov Report

Merging #1415 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1415   +/-   ##
=======================================
  Coverage   94.51%   94.51%
=======================================
  Files          63       63
  Lines        1440     1440
=======================================
  Hits         1361     1361
  Misses         79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04898c9...2ac68c7. Read the comment docs.


Fix handling of corrupted contact

Ref : https://github.com/cozy/cozy-sync/issues/78
Simply ignore the datapoints when they have no key or no value.
Also changed line endings to unix-style in src/index & test/index

continue is not classy but whatever thank you!


Bugfix: Q model and target model used the same weights

DQN keeps two copies of the weights (a normal Q model for exploration and a target model for computing the target Q values during training).
The code before this pull-request didn't create the two copies properly. Instead, the Q model and the target model always shared the same weights.

some minor fixes (instantiation of the Huber loss, variable update_target_network not used)

@jacoblchapman please review these changes.


Alternatives for non-SPA login/signup pages

This article is aimed at authentication for Single Page Apps.  Is there more detail on why the template requires non-SPA pages for login/signup etc? I understand that these default login/signup pages are provided by the Identity package - and that you can scaffold them out automatically if you wish to then customise/alter them - but these are still then hosted as Razor pages.  I would like to know what options there are for actually implementing this within a SPA - and if not, why is that the case?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 21cb7455-3305-9316-5440-bdc22947a82d
Version Independent ID: 137d4b94-7b26-3911-b22d-42c754a95fc1
Content: Introduction to authentication for Single Page Apps on ASP.NET Core
Content Source: aspnetcore/security/authentication/identity-api-authorization.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @javiercn
Microsoft Alias: scaddie

Moved to master issue: Authentication and authorization for SPAs #16406


Fix small regression in kubeadm gce startup script

Follows up #451
Even though the kubelet version was stable, we should download the right kubeadm CLI version
/assign @pipejakob @jessicaochen

Even though there are so few lines changing, I've read through the diff over and over again and am still scratching my head about the actual regression (and how this fixes it). Can you describe the scenario this fixes in a little more detail? Thanks!

I was about to start writing what I was thinking when I sent this patch, but realized I was fooled by the logic myself. Basically, we need to fixup this so the code becomes readable ;)
I now realized there is no case where kubelet version would be sth from GCS and kubeadm version would be stable as kubeadm version >= kubelet version.
Now noticed that the problem (all e2es failing) is in test-infra, because of my falsy late night review comment to @jessicaochen :(
https://github.com/kubernetes/test-infra/blob/master/kubetest/anywhere.go#L122 should indeed be /bazel/ as /ci/ has no debs. Gah.
Will fixup that instead.
The code here should probably be refactored as:

Install all debs from APT repo or GCS using kubelet-version
Override /usr/bin/kubeadm if kubeadm-version is a GCS URL
Setup cluster with control plane version == kubernetes-version

Other than adding a comment to make why the stable logic is not needed clear, it looks fine.


fix mypy failures in newly merged code

fixes mypy v1.1.1 failures in code newly merged around the same time as mypy v1.1.1 was merged.

Checklist

[x] No CHANGELOG update needed

[x] No new tests needed

[x] No documentation update needed

what happened with the close here?

no, i must have hit the close button by mistake 🤦🏼
and since the branch got deleted i'll have to recreate the changes and attribute them to @manasghandat
sorry about that!

oh no, @manasghandat if you still have the changes handy please open a new PR

@mr-tz @williballenthin Can you please create a branch so that I can commit to or should I commit to the main branch?

Sorry for the mistake here. I’ll reconstruct the code proposed by @manasghandat and find a way to reopen this PR or create a new one.

@williballenthin  I do have to code and I have made the recommended changes too. It will be great if you could just make a branch for me to commit to.

please see the new PR in #1412 and continue work there.  i think outstanding are a few mypy override comments and reverting changes to autogenerated files.


[CWS] Restore ability to trigger dump over gRPC

What does this PR do?
Restore the ability to trigger an activity dump using the gRPC API.

Motivation
PR https://github.com/DataDog/datadog-agent/pull/27030 removed complete support for on-demand activity dump generation.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


crc.exe status does not work on running instance

Environment

CRC version - 0.90.0-alpha-4.1.9+b2559b5
Windows 10 Pro 1903, Hyper-V

If I start CRC and then try to determine it's state with crc.exe status, I get the following error:
PS C:\Users\Tomáš Sedmík\Downloads\crc-0.90.0-alpha-windows-amd64> .\crc.exe status --log-level=debug
DEBU Unexpected operator status for authentication: Upgradeable
DEBU Unexpected operator status for console: Upgradeable
DEBU Unexpected operator status for kube-apiserver: Upgradeable
DEBU Unexpected operator status for kube-controller-manager: Upgradeable
DEBU Unexpected operator status for kube-scheduler: Upgradeable
DEBU Unexpected operator status for openshift-apiserver: Upgradeable
DEBU Unexpected operator status for openshift-controller-manager: Upgradeable
DEBU Unexpected operator status for service-ca: Upgradeable
DEBU Unexpected operator status for service-catalog-apiserver: Upgradeable
DEBU Unexpected operator status for service-catalog-controller-manager: Upgradeable
ERRO Error occurred: strconv.ParseInt: parsing "df:": invalid syntax

This fails somewhere in:
https://github.com/code-ready/crc/blob/f3edeb8afb9732c88a716ab6e6092fde04919074/pkg/crc/cluster/cluster.go#L43-L63

https://github.com/code-ready/crc/blob/f3edeb8afb9732c88a716ab6e6092fde04919074/pkg/crc/cluster/cluster.go#L54
https://github.com/code-ready/crc/blob/f3edeb8afb9732c88a716ab6e6092fde04919074/pkg/crc/cluster/cluster.go#L58

Hmm, there's a difference in the block device's name, in case of windows the device mounted in /sysroot is /dev/sda3 but in case of linux it is /dev/vda3. I had hard-coded the device name to be /dev/vda3 :(

It seems you are using the device path as an arg to df, I think you can use the mountpoint instead, which should be the same on all platforms.


Optional additional sync'd folders

I think it would be useful if we could specify additional folder(s) to sync over along with cordova.js,cordova_plugins.js and plugins/ when using options.copyCordovaAssets: true
A zipped www/ folder will often contain assets that don't often require updating, so unnecessary to keep including these in the zipped folder.
(e.g fonts, large JS libs such as ionic )
As an example, my built (and minified) www/ folder zips to ~3mb, however, removing the lib directory and zipping reduces this down to 200k
I will be looking at using https://github.com/braddenver/preen to reduce lib/ down further as a lot of this size is due to unnecessary files, but for me, best option would be to have it synced and not part of the remote zip.
Would this be feasible / sensible?

Yes. We will be adding an option to copy over the whole app (not only cordova assets) to newly synced folder before applying update.

@hicksy https://github.com/phonegap/phonegap-plugin-contentsync/tree/init
This will make it to master soon

Great
Does this copy the root app into the synced folder prior to unzip? And therefore we will be able to overwrite folders by including in the zip?
Also, assuming the root is always the original root of app as opposed to pointing to last synced folder?

@hicksy Yes and Yes. You can try it out now. It's in master and npm (1.1.3). iOS only for now.

@hicksy @imhotep Android works too.

ah cool so I guess I can close this :)


Warning: EventBus conflicts with imported type EventBus

I have a fresh Monogame project with Arch and all Arch.Extended plugins:
<ItemGroup>
    <PackageReference Include="Arch" Version="1.2.7" />
    <PackageReference Include="Arch.AOT.SourceGenerator" Version="1.0.0" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
    <PackageReference Include="Arch.EventBus" Version="1.0.2" />
    <PackageReference Include="Arch.LowLevel" Version="1.1.0" />
    <PackageReference Include="Arch.Persistence" Version="1.0.3" />
    <PackageReference Include="Arch.Relationships" Version="1.0.1" />
    <PackageReference Include="Arch.System" Version="1.0.2" />
    <PackageReference Include="Arch.System.SourceGenerator" Version="1.1.2" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
    <PackageReference Include="MonoGame.Framework.DesktopGL" Version="<IP_ADDRESS>3" />
    <PackageReference Include="MonoGame.Content.Builder.Task" Version="<IP_ADDRESS>3" />
  </ItemGroup>

I try to dispatch an event exactly like in the sample project:
var @event = (Main.World, key);
EventBus.Send(ref @event);

I get a warning on compilation:
warning CS0436: The type 'EventBus' in 'Arch.EventBus\Arch.Bus.QueryGenerator\EventBus.g.cs' conflicts with the imported type 'EventBus' in 'Arch.EventBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'Arch.EventBus\Arch.Bus.QueryGenerator\EventBus.g.cs'.

It compiles and works fine but I like it when there is no warning. I've tinkered with the .csproj without success.
Did I fail to configure something ?

Hey, thanks for the issue!
I actually have no idea where the warning comes from, I'm gonna check that out!

I had a different issue where EventBus.Send wasn't being detected at all. After changing to Arch.Bus.EventBus.Send I start to get the same warning described here, but code was now working. My packages are all newer than the OP, but all the Arch packages are there
<ItemGroup>
    <PackageReference Include="Arch" Version="1.2.8" />
    <PackageReference Include="Arch.AOT.SourceGenerator" Version="1.0.1" />
    <PackageReference Include="Arch.EventBus" Version="1.0.2" />
    <PackageReference Include="Arch.LowLevel" Version="1.1.0" />
    <PackageReference Include="Arch.Persistence" Version="1.0.4" />
    <PackageReference Include="Arch.Relationships" Version="1.0.1" />
    <PackageReference Include="Arch.System" Version="1.0.5" />
    <PackageReference Include="Arch.System.SourceGenerator" Version="1.1.4" />
    <PackageReference Include="MonoGame.Framework.DesktopGL" Version="<IP_ADDRESS>3" />
    <PackageReference Include="NUnit" Version="4.1.0" />
    <PackageReference Include="Utf8Json" Version="1.3.7" />
  </ItemGroup>


Create info modal when create backup is clicked

https://i.imgur.com/F5TZoPg.png

Does this happen before the backup API call completed or after? It should be after.
Also, can we add this modal to the backup from clicking snapshot->backup as well?


Fix String.rsplit to return splitted list with correct order

With PR below code (copied from documentation) finally works as expected:
https://docs.godotengine.org/en/3.2/classes/class_string.html#class-string-method-rsplit
var some_string = "One,Two,Three,Four"
var some_array = some_string.rsplit(",", true, 1)
print(some_array.size()) # Prints 2
print(some_array[0]) # Prints "Four"
print(some_array[1]) # Prints "Three,Two,One"

Fixes: #36898

I think the output of the example is wrong, the correct output should be:
print (some_array [0]) # Prints "Four"
print (some_array [1]) # Prints "One, Two, Three"

or am I wrong?

I think the output of the example is wrong, the correct output should be:
print (some_array [0]) # Prints "Four"
print (some_array [1]) # Prints "One, Two, Three"

or am I wrong?

I agree because:

The splits in the returned array are sorted in the same order as the original string, from left to right.

With PR below code (copied from documentation) finally works as expected:
https://docs.godotengine.org/en/3.2/classes/class_string.html#class-string-method-rsplit
var some_string = "One,Two,Three,Four"
var some_array = some_string.rsplit(",", true, 1)
print(some_array.size()) # Prints 2
print(some_array[0]) # Prints "Four"
print(some_array[1]) # Prints "Three,Two,One"

It shouldn't work like that. This PR shouldn't be merged as is.
It should work either as @dankan1890 suggested (without the additional spaces):
print (some_array[0]) # Prints "Four"
print (some_array[1]) # Prints "One,Two,Three"

or as @Anutrix suggested (without the additional spaces), that's how it works currently (the docs are just wrong):
print(some_array[0]) # Prints "One,Two,Three"
print(some_array[1]) # Prints "Four"

Superseded by #59547.


add nexus publishing due to bintray shutdown

We already use gradle maven-publish plugin to generate artifacts and the signing plugin to sign. now we need the nexus publish plugin [1] to upload and release instead of manually producing the bundle jar and uploading.
[1] https://plugins.gradle.org/plugin/io.github.gradle-nexus.publish-plugin
[2] https://github.com/gradle-nexus/publish-plugin
[3] https://grails.org/blog/2021-04-07-publish-grails-plugin-to-maven-central.html

wrong repo :)


Image on Docker Hub don't seem to work

Summary
docker run tiredofit/freepbx-latest don't seem to work, but eats up tons of RAM(~44GB in my case) and stall
Environment

Image version / tag: :latest and :15
Host OS: Debian 11

Possible fixes

Something is broken, or potentially image or resource fetched from URL is compromised
Current implementation downloads external installation files, having known-good prebuilt on the hub might help

@numpad0 ,
I'm not familiar with that partiular version, but that is over 2 years old. I would suggest you use the version here, which would be tiredofit/docker-freepbx:latest. I've been playing with it for a couple of weeks, and it works very well.

The hub image latest doesn't work for me either.
I think the first problem is in the freepbx dist download. Is it the case that they deleted all the releases? I'm new to the community, so I don't know the history.
It seems like it would at least download something if changed to https://github.com/FreePBX/framework/archive/refs/tags/release/<version>.tar.gz. This is probably already fixed in other versions, since nobody else is complaining.


Dummy Python message classes contain extraneous data, imports

What
A proto message is "transitively referenced" by an API if there is some method of the API whose request or response message contains a field whose type is, or whose type transitively references that proto message. ProtoFileView compiles the proto files containing all such transitiviely referenced proto types.
However, the proto files may also contain other messages and imports that are not transitively referenced by the API. We should not generate Python docs or imports for these messages.
Why
The imports are broken if they point to files that are not contained in the ProtoFileView (since we do not generate their corresponding dummy Python module), causing Sphinx doc generation to fail.
The extraneous messages don't break anything, but they're irrelevant and may themselves contain broken links (if they link to files not contained in the ProtoFileView), so they should be excluded as well.

@lukesneeringer

Closing because these classes do not appear to exist any longer.


Syntax highlighting is not working for return types

As you can see depending on space the code looks totaly broken. Please fix asap.
':Matrix' and ': Matrix' <--

@62316e (if that's your real name) you should consider posting information on the version of the package, atom, and apm you are using, as well as your operating system info.

apm  1.10.0
npm  2.13.3
node 6.2.2
atom-typescript 10.1.6
And yes, sixty-two thousand, three hundred sixteen-e is my real name.