Fix Computation Breaking when selecting Electricity, at consumer

...presumably because this process is relevant when building the dataframes displayed with the tabular widget.
2024-09-15 11:26:50,990 error handling message
 message: Message 'PATCH-DOC' content: {'events': [{'kind': 'MessageSent', 'msg_type': 'bokeh_event', 'msg_data': {'type': 'event', 'name': 'button_click', 'values': {'type': 'map', 'entries': [['model', {'id': 'p21725'}]]}}}]}
 error: KeyError('[0] not found in axis')
Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/server/protocol_handler.py", line 94, in handle
    work = await handler(message, connection)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/server/session.py", line 94, in _needs_document_lock_wrapper
    result = func(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/server/session.py", line 286, in _handle_patch
    message.apply_to_document(self.document, self)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/protocol/messages/patch_doc.py", line 104, in apply_to_document
    invoke_with_curdoc(doc, lambda: doc.apply_json_patch(self.payload, setter=setter))
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/document/callbacks.py", line 453, in invoke_with_curdoc
    return f()
           ^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/protocol/messages/patch_doc.py", line 104, in <lambda>
    invoke_with_curdoc(doc, lambda: doc.apply_json_patch(self.payload, setter=setter))
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/document/document.py", line 391, in apply_json_patch
    DocumentPatchedEvent.handle_event(self, event, setter)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/document/events.py", line 244, in handle_event
    event_cls._handle_event(doc, event)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/document/events.py", line 279, in _handle_event
    cb(event.msg_data)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/document/callbacks.py", line 400, in trigger_event
    model._trigger_event(event)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/util/callback_manager.py", line 111, in _trigger_event
    self.document.callbacks.notify_event(cast(Model, self), event, invoke)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/document/callbacks.py", line 262, in notify_event
    invoke_with_curdoc(doc, callback_invoker)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/document/callbacks.py", line 453, in invoke_with_curdoc
    return f()
           ^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/bokeh/util/callback_manager.py", line 107, in invoke
    cast(EventCallbackWithEvent, callback)(event)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/panel/reactive.py", line 572, in _server_event
    self._comm_event(doc, event)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/panel/reactive.py", line 559, in _comm_event
    state._handle_exception(e)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/panel/io/state.py", line 464, in _handle_exception
    raise exception
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/panel/reactive.py", line 557, in _comm_event
    self._process_bokeh_event(doc, event)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/panel/reactive.py", line 494, in _process_bokeh_event
    self._process_event(event)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/panel/widgets/button.py", line 242, in _process_event
    self.clicks += 1
    ^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/param/parameterized.py", line 528, in _f
    instance_param.__set__(obj, val)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/param/parameterized.py", line 530, in _f
    return f(self, obj, val)
           ^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/param/parameters.py", line 543, in __set__
    super().__set__(obj,val)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/param/parameterized.py", line 530, in _f
    return f(self, obj, val)
           ^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/param/parameterized.py", line 1552, in __set__
    obj.param._call_watcher(watcher, event)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/param/parameterized.py", line 2525, in _call_watcher
    self_._execute_watcher(watcher, (event,))
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/param/parameterized.py", line 2505, in _execute_watcher
    watcher.fn(*args, **kwargs)
  File "/Users/michaelweinold/github/brightway-webapp/app/app.py", line 551, in button_action_scope_analysis
    perform_graph_traversal(event)
  File "/Users/michaelweinold/github/brightway-webapp/app/app.py", line 527, in perform_graph_traversal
    panel_lca_class_instance.perform_graph_traversal(event)
  File "/Users/michaelweinold/github/brightway-webapp/app/app.py", line 454, in perform_graph_traversal
    self.df_graph_traversal_edges: pd.DataFrame = edges_dict_to_dataframe(self.graph_traversal['edges'])
                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelweinold/github/brightway-webapp/app/app.py", line 116, in edges_dict_to_dataframe
    return pd.DataFrame(list_of_row_dicts).drop(0)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/pandas/core/frame.py", line 5581, in drop
    return super().drop(
           ^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/pandas/core/generic.py", line 4788, in drop
    obj = obj._drop_axis(labels, axis, level=level, errors=errors)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/pandas/core/generic.py", line 4830, in _drop_axis
    new_axis = axis.drop(labels, errors=errors)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/panel_dev_macos/lib/python3.11/site-packages/pandas/core/indexes/base.py", line 7070, in drop
    raise KeyError(f"{labels[mask].tolist()} not found in axis")
KeyError: '[0] not found in axis'

...this problem is not specific to electricity. Instead, the error occurs when there are no nodes in the dataframe - meaning that the graph traversal at a set cut-off did not return any relevant upstream nodes.


Remove JRuby from supported platforms

Saw that in the latest commit e34971024b850541 it was stated that JRuby was no longer supported (which is sad) but I guess then it also shouldn't be part of the supported platforms.
Thanks for cucumber!

We might be able to support JRuby if https://github.com/cucumber/cucumber/pull/813 is completed and merged.
Let’s hold off on this PR and give it some time.

Might be obsolete now that https://github.com/cucumber/cucumber/pull/813 is merged?

Obsolete! We can support JRuby :-)


EXC_BAD_ACCESS in QM_createEntityWithDescription: inContext:

Environment details
Currently inspectableon IOS 10.2,

QMServices (0.4.5):

Bolts (>= 1.5.0)
QuickBlox (>= 2.6.5)
QuickBlox (2.9.2)

Did this work before?
YES
Expected behavior
Not to have Crash
Actual behavior
Crash
Logs
We opened a ticket #47222 and I added my logs (Not sure if I opened it under correct Department).
I prefer not to attach any logs here as it expose too much.
Steps to reproduce the behavior
It happened sometimes currently to one user (which have pretty much dialogs around 100 I think)
Any others comments?

Any updates?

Fixed in QMServices v.5.0.


DTMF ID setting doesn't work on K5Web

The DTMF ID always shows 102 after write config to device.
https://k5.vicicode.com/#/chirp/settings
K5Web - V0.1.202406100220
Information
Current Firmware Version: LOSEHU129
Write Configuration: LoseHu 118+
EEPROM Size: 8KB (64Kbit) (Official firmware can only detect 8KB/64Kbit)

sorry, I created the issue on k5web repo: https://github.com/silenty4ng/k5web/issues/25


How can i change the cursor color in insert

the color of beam same as block. how can i change it?

@taigacute can you elaborate? Do you want different colors for the different cursors?

@kchibisov   use neovim .  i think the different color between normal mode and insert mode is good.
now . i set the cursor color yellow . when use neovim .  i want cursor color is green in insert mode
normal

insert

@taigacute Neovim can handle this by default :help guicursor. However it seems like the cursor color changing with escape sequence is broken atm.
@chrisduerr This command changes the cursor on alacritty v0.3.0 printf '\033]12;#333333\007' , but doesn't work at all on the latest master. So apps like neovim can't change cursor color anymore. I guess this was introduced by cursor rework.

@kchibisov  thanks for your reply. got it.

Bisect might be useful on this, I suspect that you're right @kchibisov and this is about the cursor change, however the parsing for this escape has also changed recently. But I think that is less likely to be the problem.


Deep Parallax causes artifacts when not using with TAA/FSR2

Tested versions

Reproducible in any version

System information
Godot v4.4.dev unknown - Windows 10.0.26100 - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated Radeon (TM) RX 480 Graphics - AMD Ryzen 5 PRO 4650G with Radeon Graphics (12 threads)
Issue description
This issue present when using Deep Parallax with detailed textures
using low roughness makes it look even worse, Roughness Limiter doesn't make this any less visible
TAA and FSR2 disabled

TAA

FSR2

Steps to reproduce

Use Deep Parallax with any detailed PBR textures

Minimal reproduction project (MRP)
N/A

This is specular aliasing made more prominent with deep parallax, which can't be fixed without temporal antialiasing (or supersampling, but it's very slow). See 3D antialiasing in the documentation.


Move to 8.0.0

Hi Dev Team
After the experiences of removing endpoint_inventory, I found out this
strategy is successful.
Especially, we totally get rid of register, so I want to do more.
SkyWalking 8.0.0
First, it is already unexpected for me, we have to move to 8.0.0 so
quickly, but after the discussion with @hanahmily, and thinking about this for several days, I think
we have to.
The key chances are following

Remove service, service instance, and network address register. The old
register protocols are totally going to be removed.
The agent doesn't need to do register anymore. Service name and Service
Instance name are generated by the agent itself, but the extra information,
such as IP, hostname, language, should report to backend separately.
Service Traffic should be added just like the endpoint traffic but keep
the time bucket as we need accurate service name in the given duration
Service Instance Traffic should be added too, with external information,
such as language, hostname.
Trace context propagation context should be changed to accept string in
service instance name, endpoint name and network address. This could ease
the agent logic, but also, requires changes in all language agent and
plugin test tool,
Trace report protocol requires to change too, in order to adopt the
string.
e2e tests have to ignore PHP and LUA at first, and remove the 6.x
compatibility test(doesn't support anymore). @heyanlong @moonming @dmsolr

The benefits we will get are

Don't worry about the inventory(s) that has been deleted randomly by end
users. (We received a lot of issue reports about this)
The upgrade could be easier erasing the whole storage and reboot the new
one. (Users don't feel comfortable about upgrade)
No hot-reboot case in the agent side
No cache of network address register information in the agent.
No service and service instance cache in the OAP
No register lock in the OAP
No file buffer mechanism in the OAP too, same as no register happens.

In my mind, I think this totally break upgrade is super meaningful and will
be good change. Even we break many things, they are easy to follow.
@mrproliu  I think by following this, we need
to change the collaboration header to sw8 :) As no 7.1.0 release will
happen.
Mail list, https://lists.apache.org/thread.html/rda36fa8d191fc5750fc793993c69e14a917138bf97f9c2a461b72811%40<dev.skywalking.apache.org>

Codecov Report

Merging #4597 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4597      +/-   ##
==========================================
- Coverage   26.93%   26.92%   -0.01%
==========================================
  Files        1256     1256
  Lines       28968    28968
  Branches     3958     3958
==========================================
- Hits         7802     7800       -2
- Misses      20454    20455       +1
- Partials      712      713       +1

Impacted Files
Coverage Δ

.../agent/core/context/SW8CorrelationCarrierItem.java
100.00% <ø> (ø)

...walking/apm/agent/core/context/ContextCarrier.java
72.41% <100.00%> (ø)

.../skywalking/apm/plugin/spring/patch/MatchUtil.java
37.50% <0.00%> (-12.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54fb6e7...503fd9d. Read the comment docs.


add github-action-benchmark to ci

Description of changes
Updates CI to use github-action-benchmark for continuous benchmarking. The addition to build_and_test.yaml will run the benchmarks on each PR and fail if there is significant performance regressions (default is 200% but this is customizable). The addition to nightly_build.yml will make pretty pictures like this.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[X] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

[X] Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

[X] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

Closing per recommendation here. We'll use an internal server for benchmarking.


Type error in v14.0

Describe the bug
../../node_modules/.pnpm/twemoji@14.0.0/node_modules/twemoji/index.d.ts:32:1 - error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

32 const twemoji: {

To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/Saul-Mirone/milkdown
git checkout renovate/all
pnpm install && pnpm build --filter=@milkdown/plugin-emoji
See error

Expected behavior
Typescript compile can pass with no error.
Screenshots
If applicable, add screenshots to help explain your problem.

Environment
For web, specify your OS and browser version.  For mobile, specify device, OS
and version.  For libraries, what version of build tools are you using?
Additional context
Add any other context about the problem here.

In addition to the above, we're getting an error when calling Twemoji.parse() as it is incorrectly typed as returning void here, when it actually returns a string. See scripts/build.js examples, which all return strings. The fix for this bit, at least, is to just change the : void; on 37to: string;`.

I made PR #533 to address this issue feedbacks.
If you need quick fix you can update tsconfig.json with "twemoji": ["src/twemoji.d.ts"] in compilerOptions.paths and use the following content for twemoji.d.ts.
declare interface TwemojiOptions {
  /**
   * Default: MaxCDN
   */
  base?: string;
  /**
   * Default: .png
   */
  ext?: string;
  /**
   * Default: emoji
   */
  className?: string;
  /**
   * Default: 72x72
   */
  size?: string | number;
  /**
   * To render with SVG use `folder: svg, ext: .svg`
   */
  folder?: string;
  /**
   * The function to invoke in order to generate image src(s).
   */
  callback?(icon: string, options: TwemojiOptions): void;
  /**
   * Default () => ({})
   */
  attributes?(): void;
}

export const twemoji: {
  convert: {
    fromCodePoint(hexCodePoint: string): string;
    toCodePoint(utf16surrogatePairs: string): string;
  };
  parse(node: HTMLElement | string, options?: TwemojiOptions): string;
};

export default twemoji;

I had some weird issue with that tsconfig.json, where module types was ignored on Linux (GitHub CI) but not on macOS, in the end I just added skipLibCheck as a temporary workaround for the workaround.

Fix is merged now; FWIW I'm happy to merge whatever typescript fixes there are relatively quickly in the future – we don't use TS at Twitter, so there's always a chance that whatever exists for TS types in master is somehow broken or incorrect. Thanks for catching it.

Thank you @jdecked for quick merge, i have tested 14.0.1 with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>following syntax works as expected now.

const twemoji = await import('twemoji').then((m) => m.default);

OR

import twemoji from "twemoji";

@Saul-Mirone and @BenjaminNolan all good on your side now using 14.0.1 ?


armeabi-v7a support?

Just a reminder,, you have not forgotten the armeabi-v7a support you promised earlier on. By the way the version you posted earlier (app-staging.zip) for the armv7 worked. Thanks

Please be patient. I want to update AppVerifier's targetSdk before I do new release since Android 15 is very close.


text2image fails to generete box file when enable --find_fonts, not supported on multilingual text

Environment

Tesseract Version:
tesseract 4.00.00alpha
leptonica-1.74.4
libjpeg 8d (libjpeg-turbo 1.4.2) : libpng 1.2.54 : libtiff 4.0.6 : zlib 1.2.8

Found AVX2
Found AVX
Found SSE

Commit Number:
Platform:
ubuntu 16.04
Linux <my_container_id> 4.4.0-97-generic # 120-Ubuntu SMP Tue Sep 19 17:28:18 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Current Behavior:
I first tried
training/text2image --font='Microsoft Sans Serif' --text /data/dataset/tha+eng/txt/0.txt --outputbase /data/dataset/tha+eng/0 --max_pages=1 --box_padding=2 --ptsize=10  --underline_continuation_prob=0.1  --fonts_dir=/usr/share/fonts  --min_coverage 0.9

It gives both tif and box files.
Because my text file is a mixture of 2 different languages, I enable the --find_fonts to find the fonts that are available for rendering. So I tried
training/text2image --find_fonts  --text /data/dataset/tha+eng/txt/0.txt --outputbase /data/dataset/tha+eng/0 --min_coverage 0.9 --max_pages=1 --box_padding=2 --ptsize=10  --underline_continuation_prob=0.1  --fonts_dir=/usr/share/fonts

Then it only gives one output, 0.Microsoft Sans Serif.tif, which means it only renders for 1 font and has no output for box file.
I also tried on english-only text using the same --find_fonts flag, and it has the same problem.
Another problem is when I tried to render for a file with 3 languages, using --find_fonts, it returns
Stripped 1 unrenderable words
Microsoft Sans Serif : 276 hits = 96.50%, raw = 85 = 89.47%
Rendered page 0 to file /data/dataset/tha+eng+zho/0.Microsoft_Sans_Serif.tif

When I tried with --fonts=Microsoft Sans Serif, it returns:
Stripped 1 unrenderable words
Rendered page 0 to file /data/dataset/tha+eng+zho/0.tif
Null box at index 0
Error: Call PrepareToWrite before WriteTesseractBoxFile!!

Expected Behavior:
Give multiple tif.box pairs in different fonts
Suggested Fix:
It is hard to find fonts which support 3 languages from different writing system. Any chance to provide a function which can render on whatever fonts available on each language text?

You have to do it as two steps.
Use findfonts to get a list of fonts.
Then use that list for making box/tiff pairs.
I have found with using multiple languages that sometimes a page may have no text in a language, the process fails for that font then.

I  tried using --find_fonts --render_per_font=false for an English text file, it only returns one font that is available, which is the first available font the program finds.
The current solution to multilingual text is just to get a font that works for both languages right?

Arial Unicode MS, Noto Sans etc may have multiple language support.
For multilingual text, you can also create box/tiff/lstmf separately for each language also. Then train with all three - lang1, lang2 and lang1+lang2. That way you can get support for more fonts.
You will need to modify the training_files.txt to have links to all the .lstmf files.

I use the following command to get a list of fonts. Change the directory and file names.
nice text2image --find_fonts \
--fonts_dir ./.fonts \
--text ./langdata/ara/ara.diacritics.training_text \
--min_coverage 0.99975 \
--render_per_font=false \
--outputbase ./langdata/ara/ara \
|& grep raw \
 | sed -e 's/ :.*/@ \\/g' \
 | sed -e "s/^/  '/" \
 | sed -e "s/@/'/g" > ./langdata/ara/ara.diacritics.fontslist.txt

Thanks for your explanation.
The find_fonts issue is still not solved. I cannot automatically get the tiff/box files for all available fonts via one command. It did not return a list of fonts.

Thanks! It's really helpful.

tesseract 4.00.00alpha
You should upgrade to latest version.

I'm upgrading to tesseract beta version (master branch). I found that text2image does not give good box output sometimes. How does tesseract 4.0.0beta generate the box/tiff pairs? I look into the tesstrain.sh, then combine_lang_model, but could not find the command that actually generate the pairs.
If putting txt files in the langdata directory, will tesseract generate multiple tiff/box files from each txt files?

UPDATE: I figured out why the text2image doesn't work. It's because of the version issue (Thanks for your advice! @Shreeshrii ). Now my question remain is for a new image, how to generate the box file to pass into the lstm model?

Please see https://github.com/tesseract-ocr/tesseract/wiki/TrainingTesseract-4.00---Finetune
The scripts at wiki.wareya.moe are modified to use multiple text files as input.

@Shreeshrii How should I get the preprocessing (page layout) result for the lstm model when taking in a new image for recognition? I tried batch.nochop makebox, the box file didn't give good bounding box for each character.

Why does the input of the training data for LSTM is character-based?
LSTM is line-based. Does it mean during the training, it takes the whole line as input to the model? From my understanding, the input should have some windows moving along the textline, which means the segmentation of the textline is involced. What would be the ground truth for each of the LSTM node?

See  https://github.com/tesseract-ocr/tesseract/issues/1276

Sorry, I do not know about the internal processing regarding LSTM to answer your questions. You will have to look at the code.
The tesstrain.sh script calls text2image, the box files created by it have the spaces/tabs and are used to further generate the lstmf files.
jtessboxeditor can be used to put tabs for EOL in makebox generated box files, but it does not have a facility to add interword spaces.
Another alternative is the ocrd-train project, But that handles one line images only and creates box files based on ground truth.

Why does the input of the training data for LSTM is character-based?

For some scripts (e.g. Devanagari) the basic unit of training may contain more than one character.


applying clone-patch0.0.1 - git_scr_up.sh

DUUUUDE im to done tonight, may someone see some issues here.

im beholding rights to reopen but for first the test seemed fine...

Mhpf.


SDK meeting APIView link update doesn't update the table

When a user adds an APIView link into the language option, the table view is not updated even though the data was correctly updated.
Also, the Update button is not clickable so the user needs to update any other field (like description) to be able to update the meeting.
Some screeshots:
When link updated:

Table not updated:

Fixed:

Domain - APIView link table is refresh when a link is added, updated, or removed
Update meeting button is enabled when a link was added, updated, or removed


Example merchants with order decision

The example merchant can now order more than one item.
This PR brings back the 'two bound' strategy.
The merchant's strategy can be configured with the start parameter.
Example: python3 merchant.py --port 5001 --strategy Cheapest
Same functionality of the example merchants was moved into the base class (in pricewars_merchant.py).
Strategies currently differ in settings they use and their pricing function (calculate_price())
I also simplified the directory structure by one level:
pricewars/api/... moved to api/...
pricewars/models/... moved to models/...
pricewars/MerchantServer.py moved to server.py
pricewars/PricewarsMerchant.py moved to pricewars_merchant.py
Here is an example of the cheapest merchant running against the two bound merchant:

I won't be able to look at all the changes before March 26, but I don't want to block this PR.
Can I blindly trust you and merge? :)

Sure.
A docu update for the new changes comes next.


Feedback regarding model performance

You model is good but like all models could use improvement.
Is there a way provide feedback about the model to help you improve it? I know there's the option in the chat console, But I am using it through the api so I can't really submit feedback through that. Maybe I can drop you an email.

Hi @avin-kavish. Any feedback is welcome through<EMAIL_ADDRESS>


smartthings integration issue

Hi, Just went through all the steps fromthe guide but it is still not working.
even the {"pingData": {"challenge": "00000000-0000-0000-0000-000000000000"}} is working !

but I still get the error:

2020-01-27 00:55:07 DEBUG (MainThread) [homeassistant.components.smartthings.smartapp] Setup endpoint for [https://my_webhook_url]
2020-01-27 00:55:07 ERROR (MainThread) [homeassistant.components.smartthings.config_flow] API error setting up the SmartApp: {'requestId': '2D46978A-2338-4637-8BDE-73B6C64D0734', 'error': {'code': 'ConstraintViolationError', 'message': 'The request is malformed.', 'details': [{'code': 'TargetTimeoutError', 'target': '[https://my_webhook_url]', 'message': 'Upstream target timed out', 'details': []}]}}
Traceback (most recent call last):
  File "C:\Programs\Python\Python38\lib\site-packages\homeassistant\components\smartthings\config_flow.py", line 107, in async_step_user
    app, client = await create_app(self.hass, self.api)
  File "C:\Programs\Python\Python38\lib\site-packages\homeassistant\components\smartthings\smartapp.py", line 142, in create_app
    app, client = await api.create_app(app)
  File "C:\Users\[myuser]\AppData\Roaming\.homeassistant\deps\Python38\site-packages\pysmartthings\smartthings.py", line 99, in create_app
    entity = await self._service.create_app(app.to_data())
  File "C:\Users\[myuser]\AppData\Roaming\.homeassistant\deps\Python38\site-packages\pysmartthings\api.py", line 172, in create_app
    return await self.post(API_APPS, data)
  File "C:\Users\[myuser]\AppData\Roaming\.homeassistant\deps\Python38\site-packages\pysmartthings\api.py", line 386, in post
    return await self.request('post', self._api_base + resource,
  File "C:\Users\[myuser]\AppData\Roaming\.homeassistant\deps\Python38\site-packages\pysmartthings\api.py", line 359, in request
    raise APIResponseError(
pysmartthings.errors.APIResponseError: Unprocessable Entity (422): {"requestId": "2D46978A-2338-4637-8BDE-73B6C64D0734", "error": {"code": "ConstraintViolationError", "message": "The request is malformed.", "details": [{"code": "TargetTimeoutError", "target": "[https://my_webhook_url]", "message": "Upstream target timed out", "details": []}]}}
2020-01-27 00:57:50 ERROR (MainThread) [homeassistant.core] Error doing job: Exception in callback _ProactorBasePipeTransport._call_connection_lost(None)
Traceback (most recent call last):
  File "C:\Programs\Python\Python38\lib\asyncio\events.py", line 81, in _run
    self._context.run(self._callback, *self._args)
  File "C:\Programs\Python\Python38\lib\asyncio\proactor_events.py", line 162, in _call_connection_lost
    self._sock.shutdown(socket.SHUT_RDWR)
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host

up

up

up

up


Platform Near Edge Support - PoC

This is a tracker for all the various bits we will need to track to complete the feature work for Edge PoC
The PoC will cover using ODH to build and push self contained model servers to edge clusters that are managed by Open Cluster Manager (Red Hat Advanced Cluster Management).  We will use ACM Observability to monitor the performance with the edge clusters and any running models
Individual Efforts

UX: N/A

Lead: N/A

UI: N/A

Lead: N/A

Dev: https://github.com/opendatahub-io/ai-edge/issues/19

Lead: @LaVLaS

QE: (add link)

Lead: TBD

Doc: (add link)

Lead: TBD

Closing this out since the Near Edge PoC work has been completed.  This will be replaced by additional tracker(s) for Edge initiatives related to Far Edge and Edge Model Serving projects


Stack Overflow when attempting to compile jaq on Windows

Hi,
I've installed rust via rustup, and attempted to compile jaq by doing cargo install jaq, and even building from GitHub by cargo install --git https://github.com/01mf02/jaq but both of those commands fail while compiling jaq-std and jaq. Here's the output:

Hi @ibelieveinwhatileaveinthewaybehind,
to diagnose your issue, can you clone the jaq repository, go to the directory jaq-parse, and run cargo build as well as cargo build --release? If both succeed, can you run the same two commands as well as cargo build --release --no-default-features in jaq-std?
Could you please post the output of the failing commands? Thanks!

I just changed a component that might have been responsible for the stack overflow. Would you try compiling jaq again?

I just changed a component that might have been responsible for the stack overflow. Would you try compiling jaq again?

Installing from Git seems to have worked. Thanks! :)

Great to hear that! :)


Build Flutter ios module for iphone-simulator mac apple silicon failed. Error Architectures in the fat file: /Debug-iphonesimulator/Flutter.framework/Flutter are: x86_64 arm64

Is there an existing issue for this?

[X] I have searched the existing infra issues

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
I have cordova app with flutter module. Right now i try build debug for iphone simulator on mac apple silicon
Steps to reproduce
Step 1. pod install
Step 2. open App.xcworkspace
Step 3. cmd + B
Expected results
I expect to see X when Y is finished.

[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'LegacyCanvasKitRemover' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +52 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'LegacyCanvasKitRemover' is not required, skipping update.
[        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[  +21 ms] Initializing file store
[   +9 ms] Done initializing file store
[  +45 ms] debug_unpack_ios: Starting due to {}
[  +19 ms] Skipping target: gen_localizations
[   +2 ms] Skipping target: gen_dart_plugin_registrant
[ +830 ms] Skipping target: kernel_snapshot
[   +3 ms] Persisting file store
[   +8 ms] Done persisting file store
[   +6 ms] "flutter assemble" took 1 012ms.
[ +116 ms] ensureAnalyticsSent: 111ms
[        ] Running 0 shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 1
error: [   +7 ms] Target debug_unpack_ios failed: Exception: Binary /Library/Developer/Xcode/DerivedData/App-fjinoychyzteltcydtyvsdavkuzi/Build/Products/Debug-iphonesimulator/Flutter.framework/Flutter does not contain . Running lipo -info:
           Architectures in the fat file: /Library/Developer/Xcode/DerivedData/App-fjinoychyzteltcydtyvsdavkuzi/Build/Products/Debug-iphonesimulator/Flutter.framework/Flutter are: x86_64 arm64

           #0      UnpackIOS._thinFramework (package:flutter_tools/src/build_system/targets/ios.dart:348:7)
           #1      UnpackIOS.build (package:flutter_tools/src/build_system/targets/ios.dart:297:5)
           #2      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:853:27)
           <asynchronous suspension>
           #3      Future.wait.<anonymous closure> (dart:async/future.dart:525:21)
           <asynchronous suspension>
           #4      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:791:32)
           <asynchronous suspension>
           #5      Future.wait.<anonymous closure> (dart:async/future.dart:525:21)
           <asynchronous suspension>
           #6      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:791:32)
           <asynchronous suspension>
           #7      FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:620:16)
           <asynchronous suspension>
           #8      AssembleCommand.runCommand (package:flutter_tools/src/commands/assemble.dart:315:32)
           <asynchronous suspension>
           #9      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27)
           <asynchronous suspension>
           #10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #11     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
           <asynchronous suspension>
           #12     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:9)
           <asynchronous suspension>
           #13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #14     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:285:5)
           <asynchronous suspension>
           #15     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:115:9)
           <asynchronous suspension>
           #16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #17     main (package:flutter_tools/executable.dart:90:3)
           <asynchronous suspension>

[   +2 ms]
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      AssembleCommand.runCommand (package:flutter_tools/src/commands/assemble.dart:332:7)
           <asynchronous suspension>
           #2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27)
           <asynchronous suspension>
           #3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #4      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
           <asynchronous suspension>
           #5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:9)
           <asynchronous suspension>
           #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:285:5)
           <asynchronous suspension>
           #8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:115:9)
           <asynchronous suspension>
           #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #10     main (package:flutter_tools/executable.dart:90:3)
           <asynchronous suspension>
Failed to package /Desktop/Work/App.Mobile/APP.

[   +7 ms] Target debug_unpack_ios failed: Exception: Binary /Library/Developer/Xcode/DerivedData/App-fjinoychyzteltcydtyvsdavkuzi/Build/Products/Debug-iphonesimulator/Flutter.framework/Flutter does not contain . Running lipo -info:

@EgorShiryaev
From above log, I see below entry:
export EXCLUDED_ARCHS\=i386 and you seem to be building on iOS simulator which seems to have this arch, and hence it could be conflicting and throwing the error.
I am not sure if you manually excluded above arch or not. If so, but I suggest you completely remove all EXCLUDED_ARCHS from that file, and let Flutter manage the allowed architectures for you based on what plugins you're using and what simulator types are available.

It’s unlikely that this is an error, the module itself is assembled and launched on the emulator, and when I start assembling the entire application I catch this error, perhaps the problem is in the script
set -e
set -u
source "${SRCROOT}/../flutter_bpmsoft/.ios/Flutter/flutter_export_environment.sh"
export VERBOSE_SCRIPT_LOGGING=1 && "$FLUTTER_ROOT"/packages/flutter_tools/bin/xcode_backend.sh build

Can you attach ios/Runner.xcodeproj/project.pbxproj and a screenshot of the same build settings, but the Runner target (not project).

i use flutter how ios module, i haven't Runner target
project.pbxproj.zip

Thanks for the update. I couldn't find anything unusual in pbxproj shared above. Is there a way for you to provide us repo link of your app or just trimmed down demo app that shows the error, so that we can clone it and verify further ?

can’t provide it yet, we’ll try to figure it out ourselves, if anything comes back

Keeping the issue open and labeling for team's tracking and attention.

From the error logs it appears that there isn't an ARCHS build setting, which I believe is causing the issue. However, I'm not sure why your project doesn't have that, and probably can't help much further without a reproducible example.

perhaps the problem is in the script
set -e set -u source "${SRCROOT}/../flutter_module/.ios/Flutter/flutter_export_environment.sh" export VERBOSE_SCRIPT_LOGGING=1 && "$FLUTTER_ROOT"/packages/flutter_tools/bin/xcode_backend.sh build

It's not clear to me where this script came from.
Without a repro case, information about what commands you are running and what documented add-to-app path you are following, information about your Flutter environment, etc. there's really no way for us to investigate further, so I'm going to close this as non-actionable. If you would like to raise this again, please file a new issue and use the normal issue template (rather than the Flutter Team infrastructure template), providing all requested information.


RSE in NFDI and NFDI4Ing

Prepared some text for NFDI4Ing and EduTrain.
Still waiting for an answer if RSE is somehow specifically considered within EduTrain. In the section concept they explicitly refer to The Carpentries (https://zenodo.org/record/6475541 , page 6, Aufgabenpaket 3)
@jlinx Please feel free to directly push changes to the branch...

The people I know related to NFDI couldn't tell me more specific details about RSE in EduTrain. Only that there are "many developments that have not yet been properly consolidated"...

DALIA (GitLab) is strongly connected to NFDI and its section EduTrain.
Implements knowledge-base as semantically linked knowledge graph.
Any specific relation to RSE?

@braunms : there is an entire section in the NFDI working on RSE:
https://docs.google.com/document/d/1sfevW3Qbh8jcAwMRYkNTD8PstEy-MBqn2xbQH2ogYzU/edit#heading=h.w2secxckj3tq
since it's part of common infrastructures it's not yet that visible.

I actually asked Bernd Flemisch about RSE-related teaching materials within NFDI. But maybe because of my too specific question he haven't told me about other RSE developments :-P ...


Editing ranks

Another small feature request: is it possible to let us edit ranks using wb update-claim or wb add-claim?
It would be really useful to be able to change ranks for specific claims using their guid - for example, when adding newer data, to add a new claim, set the new claim to preferred, and set the old preferred one to normal.
(& thanks! wb-cli remains a really useful tool all the time)

so it was already possible to edit ranks using wb edit-entity:
wb edit-entity '{"id": "Q4115189", "claims":{"P6089": { "rank": "preferred", "value": 123}}}'

but now (v14.1.0) it's also possible from wb add-claim and wb update-claim with the --rank parameter:
# Add a statement with a preferred rank
wd ac Q4115189 P527 Q34679 --rank preferred
# Update both the claim rank and value
wd uc 'Q4115189$F00E22C2-AEF7-4145-A743-2AB6292ABFA3' Bulgroz --rank preferred
# Only update the rank
wd uc 'Q4115189$F00E22C2-AEF7-4145-A743-2AB6292ABFA3' --rank preferred

It is now also possible with the object interface:
wb uc '{ "guid": "Q1$EB704042-9821-44FB-96CB-7E1D7B7741C5", "rank": "deprecated" }'

meaning that it can also be used in batch with different ranks:
echo '
{ "guid": "Q1$d941fe74-4a76-a143-6766-a24d2ef2ddad", "newValue": "foo", "rank": "preferred" }
{ "guid": "Q1$63ef3ef4-4499-110a-3f66-33b352b61520", "newValue": "bar" }
{ "guid": "Q1$aaa3162d-4faa-6761-a8e6-f5e6a639afd5", "rank": "deprecated" }
{ "guid": "Q1$b1a0d905-4f20-065d-4aa7-787ea29c5af1", "rank": "normal" }
' | wb uc --batch


Always depends on std when built with cargo

The following lines mean that libc always depends on std when built with cargo...
#![cfg_attr(not(feature = "cargo-build"), no_std)]

...
#[cfg(feature = "cargo-build")] extern crate std as core;
#[cfg(not(feature = "cargo-build"))] extern crate core;

... which doesn't work when using cargo with a no_std crate and an alternative target (without a cross-compiled std crate, but that's ultimately not what I want anyway).
In an attempt to hack around this, I added the following to my Cargo.toml:
[dependencies.libc]
version = "0.1"
features = []
default-features = false

But this is the build command line:
rustc /home/jdub/.cargo/registry/src/github.com-0a35038f75765ae4/libc-0.1.8/rust/src/liblibc/lib.rs --crate-name libc --crate-type lib -g --cfg feature="default" --cfg feature="cargo-build" -C metadata=ef5cbad4ef5c7a1e -C extra-filename=-ef5cbad4ef5c7a1e --out-dir /home/jdub/src/derp/acpica/target/i686-unknown-linux-gnu/debug/deps --emit=dep-info,link --target ../derp/i686-unknown-linux-gnu.json -L dependency=/home/jdub/src/derp/acpica/target/i686-unknown-linux-gnu/debug/deps -L dependency=/home/jdub/src/derp/acpica/target/i686-unknown-linux-gnu/debug/deps -Awarnings

Part of the challenge here is that the libc crate is just a slim wrapper around the Rust's liblibc, so changing things is probably difficult.
Thoughts or suggestions, though? Should I not use the libc crate at all?

Unfortunately this crate isn't really intended to be used in the #![no_std] use case

Gah sorry hit the button too soon.
To elaborate, this crate isn't intended to be used as part of the #![no_std] use case, and because Cargo unions features then if anything else depends on this crate without saying default-features = false then the feature will be activated (and this will depend on std).
Stay tuned though, with https://github.com/rust-lang/rfcs/pull/1184 implemented we'll definitely mark this as #![no_std]!

Thanks for being so helpful with difficult freestanders like me, @alexcrichton. :smile:


More tests of compiled output

There are too few tests for the compiled output. We need a lot more.

printTerm x @?= "something"

With golden testing in place, this is now straight forward to do -- just add the Plutarch programs with pgoldenSpec and @|:
https://github.com/Plutonomicon/plutarch/blob/9c163c80b3df7eac3b6d2e5ab936b36584ce5316/plutarch-test/src/Plutarch/ByteStringSpec.hs#L11-L17


tests/drivers/watchdog/wdt_basic_api failed on sam_e70_xplained board with v1.14 branch.

Describe the bug
Running tests/drivers/watchdog/wdt_basic_api test case on sam_e70_xplained board with v1.14 branch, it will loop to report the message below.
This test has been skipped on sam_e70_xplained board in master branch.
To Reproduce
Steps to reproduce the behavior:

west build -b=sam_e70_xplained  tests/drivers/watchdog/wdt_basic_api
west flash
See error

Screenshots or console output
Running test suite wdt_basic_test

starting test - test_wdt
Testcase: test_wdt_no_callback
Waiting to restart MCU
Running test suite wdt_basic_test

starting test - test_wdt
Testcase: test_wdt_no_callback
Waiting to restart MCU
Running test suite wdt_basic_test

starting test - test_wdt
Testcase: test_wdt_no_callback
Waiting to restart MCU
Running test suite wdt_basic_test

starting test - test_wdt
Testcase: test_wdt_no_callback
Waiting to restart MCU

Environment (please complete the following information):

OS: Fedora28
Toolchain: zephyr-sdk-0.10.3
Commit ID: ff682926

it's still an issue, reopened it

We are going to fix this for 1.14. If the bug exists in master, we will fix it there.


Eng 2733 implement v2 list workflow route

Describe your changes and why you are making these changes
Implement the list workflow route
Related issue number (if any)
ENG 2733
Loom demo (if any)
Passed the test added to integration_tests/backend/test_reads.py
Sample output:
[{'id': '74cde64b-1c4c-42f9-8c47-93c88f0a71a8', 'user_id': '18b349cf-8c40-4efa-89a6-666ea64aa801', 'name': 'Churn Prediction', 'description': '', 'schedule': {'trigger': 'manual', 'cron_schedule': '', 'disable_manual_trigger': False, 'paused': False, 'source_id': '00000000-0000-0000-0000-000000000000'}, 'created_at': '2023-04-07T11:00:41.184375-07:00', 'retention_policy': {'k_latest_runs': -1}, 'notification_settings': {'settings': None}}, {'id': '8f8db27f-7885-4156-a90e-f40742753fc3', 'user_id': '18b349cf-8c40-4efa-89a6-666ea64aa801', 'name': 'review_strlen', 'description': '', 'schedule': {'trigger': 'manual', 'cron_schedule': '', 'disable_manual_trigger': False, 'paused': False, 'source_id': '00000000-0000-0000-0000-000000000000'}, 'created_at': '2023-04-07T11:01:00.326198-07:00', 'retention_policy': {'k_latest_runs': -1}, 'notification_settings': {'settings': None}}]

Checklist before requesting a review

[x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[x] I have performed a self-review of my code.
[x] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[x] If this is a new feature, I have added unit tests and integration tests.
[x] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[N/A] All features on the UI continue to work correctly.
[x] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Code here looks good on my end. I'll defer to @likawind if there are any backend concerns that he may have.

List_StorageMigration, which is what I was referencing, doesn't seem to follow the naming convention of  so we may want to make a task for that.
I've updated the naming. I am a little confused when to use Workflows GetWorkflows WorkflowsGet but I tried to follow the WorkflowGet example as closely as possible. Would appreciate a review to check I am using the correct convention everywhere.


Reset connection when turning off TLS

Jira: OSPRH-10415

The code looks correct. Should we add a kuttl test to validate that tls disabled removes the records? (Not sure it affects more than that. Does the service still start successfully if these records are left lingering?)

The code looks correct. Should we add a kuttl test to validate that tls disabled removes the records? (Not sure it affects more than that. Does the service still start successfully if these records are left lingering?)

Basic tests work for me at least -  Disabling podLevel TLS on the controlplane and dataplane succeeds, previously neutronapi would fail to connect the the sb db.

/cherry-pick 18.0.0-proposed

/hold


TensorBoard Callback never updates internal step counter

Using the TensorBoard callback to generate time series data is currently not possible, since the internal self._train_step counter is never updated. Instead, looking at the time series tab only ever yields a single data point instead of a graph. This is caused by the fact that every call to self.summary.scalar(...) is given the same step value.
The simplest fix that comes to my mind is adding this line to keras.callbacks.TensorBoard.on_train_batch_end(), but it is likely that a better fix exists that I am not aware of:
def on_train_batch_end(...):
    ...
    self._train_step += 1

Below, you may find what this fix looks like, running multiple steps (despite what the screenshot says, multiple steps are logged).
Without the fix:

With the fix:

That fix seems reasonable to me. @grasskin looks like you might original author here, any thoughts?
I think we might need the same fix for _val_step as well.

I recently switched from 2.12 to 3.* and noticed this bug. This has a number of downstream effects besides the plotting error

if update_freq is not "epoch" then every batch is logged, because the check is always 0 % update_freq == 0
profiling is partially broken because every step is labeled as 0, e.g. overview page, input_pipeline, op profile, etc

It seems like the bug comes from the fact that _train_step is hard coded to zero during set_model , whereas in 2.12 it was set to model._train_counter.
starting and ending profiling works fine so why not use the same batch count for summary logging?
UPDATE: As I am looking around I see that this appears to be fixed in master. I will see if updating fixes my issue

Any idea when a new version will be released?

the fix in master works for batch level summaries but does not work for profiling.


Sink configuration

LGTM

please fix
md5sum: extpoints/extpoints.go: No such file or directory

Fixed

Thanks. Feel free to merge on green.


Doesn't load things like balances in Firefox

cloudflare eth node caching is messing everything up is the issue

It also doesn't work in Firefox when using MetaMask (which means Ethereum requests are routed through MetaMask rather than CloudFlare).

when's last time you tried? Have you tried after today's release?

Yes, failing with 2.0.5 release.


Support for collapsible markdown

Hello!
I use this technique a lot: https://gist.github.com/joyrexus/16041f2426450e73f5df9391f7f7ae5f
For example here!

yes, even hidden code blocks!
phpinfo();

Unfortunately leptons gist viewer does not support that.
Are there any plans of adding it?

Thanks for the suggestion! Lepton use markdown-it for markdown rendering which has a plugin system. Let me know if there is any plugin would support this feature. I'm more than happy to integrate it.

Unfortunately they do not plan to add it: https://github.com/markdown-it/markdown-it/issues/510#issuecomment-434395177
So this can be closed?


obs4MIPs dataset and version are outdated in recipes

Many of the recipes in ESMValTool use "legacy" names for the dataset and version number of obs4MIPs datasets. The obs4MIPs specification is from 2017, so the naming scheme in those recipes is considered "legacy" for over 5 years now. I think it's time we update those recipes so they are in line with the current specification. Updating has the advantage that downloading the data automatically from ESGF will actually work.

@ESMValGroup/esmvaltool-coreteam I could make a pull request to update those recipes, if there are no objections?

Thanks for opening the discussion @bouweandela. I think it would be good to align our recipes with the current specifications. Do I understand it correctly that we would not necessarily specify the obs4MIPs dataset versions (i.e. vYYYYMMDD) in our recipes but assume the latest version will be downloaded if not available locally? I'm not sure how important it is to get the dataset versions that were used at the time the recipes were developed. For example, the most used data in recipes is dataset: CERES-EBAF,  project: obs4MIPs,  level: L3B,  version: Ed2-7 which is no longer available on ESGF but version: Ed2-8 is. The bottom line is: we may need to ask recipe maintainers if their recipes need special care w.r.t the input obs4MIPs datasets, especially if no data are available on ESGF (which I suspect will occur in a few cases...)

Do I understand it correctly that we would not necessarily specify the obs4MIPs dataset versions (i.e. vYYYYMMDD) in our recipes but assume the latest version will be downloaded if not available locally?

Yes

I'm not sure how important it is to get the dataset versions that were used at the time the recipes were developed. For example, the most used data in recipes is dataset: CERES-EBAF,  project: obs4MIPs,  level: L3B,  version: Ed2-7 which is no longer available on ESGF but version: Ed2-8 is.

Our broken recipe policy states that recipes can use only data that is publicly available, so recipes that use data that is not or no longer publicly available will need to be updated or marked as broken. To get a better overview of the issue, I created the following table.
Here is a mapping table from datasets and versions currently used in recipes to ESGF datasets:

recipe dataset
recipe version
ESGF dataset
notes

AIRS
RetStd-v5
AIRS-2-1
guess based on the available variables, but the filenames on ESGF differ from those on Levante so there might be some differences

AIRS-2-0
v2
AIRS-2-0
already up to date

ATSR
ARC-v1.1.1
ARC-SST-1-1

CERES-EBAF
Ed2-7

not available on ESGF

CERES-EBAF
Ed2-8
CERES-EBAF
for variables rlut, rlutcs, rsdt, rsut, rsutcs

CERES-EBAF
Ed2-8
CERES-EBAF_Surface
for variables rlds, rldscs, rlus, rsds, rsdscs, rsus, rsuscs

GPCP-SG
v2.2
GPCP-V2.2

GPCP-SG
v2.3
GPCP-V2.3

ISCCP
V1.0
ISCCP

MODIS
C5
MODIS-1-0

SSMI
RSSv07r00
RSS-v7
filenames on ESGF differ from those on Levante so there might be some differences

SSMI-MERIS
v1-00
SSMI-MERIS
already up to date

TRMM-L3
7A
TRMM

@remi-kazeroni Would you prefer a single pull request with all updates, or a pull request per recipe? And what about the outdated level facet, do we want to keep it or remove it?

@remi-kazeroni Would you prefer a single pull request with all updates, or a pull request per recipe?

I would prefer to have one pull request per recipe or group of recipes. There are 26 recipes in this list. I think that if we have a single PR for all recipes and need to wait for all recipes to be reviewed by their maintainers/experienced users, this would probably take too long for the release. It would be a good start if we could change a few of these recipes for v2.8.
Also, I now realize that this could potentially have a large impact on our obs4MIPs data pool at DKRZ which has more than 3000 files (90 GB) and which are shipped to JASMIN. Given that these data pools can be used by recipe developers or users of previous versions of the ESMValTool modules, I do not plan to make changes to these data pools. Instead, I am thinking to benefit from the auto-download feature of the Tool to generate a new pool of obs4MIPs data at DKRZ. This could be in our shared download_dir and be later shipped to JASMIN in order to minimize the issues for our users.

And what about the outdated level facet, do we want to keep it or remove it?

I'm not really knowledgeable about this facet and would suggest to ask advice from the Scientific Lead Development Team.

It looks to me that it is getting a bit late in the release process to start a major update of the OBS4MIPs entries in our recipe. I would prefer to focus on fixing broken recipes, properly documenting the release and retesting recipes, rather than this work.
I think it would be great to "ESGFize" our recipes so that ESMValTool could download more data automatically and the tool could be more easily ported on different clusters and data pools. But this would take more than the one week we have left for v2.8. I'd be happy to contribute to these efforts once the release is finished. @bouweandela, would it be agreeable to bump this issue and related PRs to v2.9?

Hi All,
I encountered that issue trying to set up ESMValTool on our system here at ACCESS-NRI.
@remi-kazeroni I would like to set up a pool of Obs4mip datasets. Can we work on this together?

Hey @rbeucher , I assume you're aware of qv56? the only problem is it isn't maintained, so as with CREATE-IP we may also need to ask NCI to update their data holdings... using a central ESMValTool pool of obs4MIPs data might be better though!

Hi @hot007, Yes I am. I think that using a pool of data aligned with the ESMValTool group is probably easier to get for now...

@bouweandela @remi-kazeroni . What do you do for derived variables like lwcre? Do you derived the variable and save it to a netCDF file?
Example is recipe_perfmetrics_CMIP5 that queries ESGF for lwcre in my case.

Hi @rbeucher, thanks for your interest in the Tool. My recommendation to set up an pool of obs4MIPs data would be to create it by using the automatic download from ESGF.
The problem here is that quite a few of our obs4MIPs entries in recipes do not follow ESGF standards but older, outdated ESGF ones. In many cases, that can be fixed by changing the dataset name (as explained in this https://github.com/ESMValGroup/ESMValTool/issues/2974#issuecomment-1372136192) and removing the version facet completely. I would recommend to continue opening issues for each problematic recipe or dataset and then try a fix in a PR. I do not really have the capacity to work on that myself at the moment. I could help reviewing PRs. There we would try to make sure that recipes are runnable using obs4MIPs data from ESGF only and also in our testing facility at DKRZ.
But I suspect we may first need to clarify drs issues on your side, please see this https://github.com/ESMValGroup/ESMValTool/issues/3293#issuecomment-1642305543

Happy to help with this. It affects quite a lot of recipes so I think it is important we solve the issue.

Sure. I'll submit PRs. I'm looking into it.

Thanks to @rbeucher, we have a huge update. I'm closing this issue as resolved, though it's not impossible that further instances surface in the future. If that happens, we'll address it in a new issue.
:tada: Thanks, @rbeucher! :tada:

Thanks for the massive effort @rbeucher!
With these changes, there are 10 recipes remaining that are still affected by this issue. I'll re-open the issue so we can keep track of it. @ESMValGroup/esmvaltool-recipe-maintainers If your recipe is listed in this comment, could you please update your recipes according to the table above? https://github.com/ESMValGroup/ESMValTool/issues/2974#issuecomment-1372136192
esmvaltool/recipes/recipe_schlund20esd.yml:1401:          - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-7, tier: 1}
esmvaltool/recipes/recipe_wenzel16jclim.yml:306:          - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-7, tier: 1, start_year: 2001}
esmvaltool/recipes/recipe_autoassess_landsurface_surfrad.yml:45:          - {dataset: CERES-EBAF,  project: obs4MIPs,  level: L3B,  version: Ed2-7,  start_year: 2001,  end_year: 2012, tier: 1}
esmvaltool/recipes/recipe_autoassess_landsurface_surfrad.yml:53:          - {dataset: CERES-EBAF,  project: obs4MIPs,  level: L3B,  version: Ed2-7,  start_year: 2001,  end_year: 2012, tier: 1}
esmvaltool/recipes/ipccwg1ar5ch9/recipe_flato13ipcc_figure_96.yml:217:      - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-7, tier: 1, start_year: 2003, end_year: 2011}
esmvaltool/recipes/ipccwg1ar5ch9/recipe_flato13ipcc_figure_96.yml:303:      - {dataset: GPCP-SG, project: obs4MIPs, level: L3, version: v2.2, tier: 1}
esmvaltool/recipes/ipccwg1ar5ch9/recipe_flato13ipcc_figure_96.yml:385:      - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-7, tier: 1, start_year: 2003, end_year: 2011}
esmvaltool/recipes/ipccwg1ar5ch9/recipe_flato13ipcc_figures_92_95.yml:495:      - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-7,
esmvaltool/recipes/ipccwg1ar5ch9/recipe_flato13ipcc_figures_92_95.yml:599:      - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-7,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_42_a.yml:347:      - {dataset: GPCP-SG, project: obs4MIPs, level: L3, version: v2.3, tier: 1}
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_42_a.yml:465:      - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-8,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_42_a.yml:506:      - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-8,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_42_a.yml:550:      - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-8,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_42_a.yml:623:      - {dataset: CERES-EBAF, project: obs4MIPs, level: L3B, version: Ed2-8,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_43.yml:263:      - {dataset: GPCP-SG, project: obs4mips, level: L3, version: v2.2, tier: 1}
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_43.yml:336:      - {dataset: CERES-EBAF, project: obs4mips, level: L3B, version: Ed2-8,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_43.yml:370:      - {dataset: CERES-EBAF, project: obs4mips, level: L3B, version: Ed2-8,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_43.yml:404:      - {dataset: CERES-EBAF, project: obs4mips, level: L3B, version: Ed2-8,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_43.yml:437:      - {dataset: CERES-EBAF, project: obs4mips, level: L3B, version: Ed2-8,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_atmosphere.yml:928:      - {dataset: GPCP-SG, project: obs4MIPs, level: L3, version: v2.3,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_atmosphere.yml:957:      - {dataset: GPCP-SG, project: obs4MIPs, level: L3, version: v2.3,
esmvaltool/recipes/ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_atmosphere.yml:1031:      - {dataset: GPCP-SG, project: obs4MIPs, level: L3, version: v2.3,
esmvaltool/recipes/recipe_smpi_4cds.yml:241:      - {dataset: GPCP-SG, project: obs4MIPs, level: L3, version: v2.2, tier: 1}
esmvaltool/recipes/recipe_ocean_quadmap.yml:59:       - {dataset: ATSR,  project: obs4MIPs,  level: L3,  version: ARC-v1.1.1,  start_year: 2001,  end_year: 2003, tier: 1}

massive massive good work from @rbeucher - very many thanks! This can moved to M2.11 since there are still a few open PRs - even though those are nearly ready, am fairly sure the release boys @zklaus and @bouweandela would prefer to release this week before :santa: comes along

Hi, we are currently working on the ESMValTool release for v2.11.0. We're wondering if you'd be able to finalise this issue by the end of next week (Friday 10th May).
If we don't hear anything from you by then we'll move this into the next milestone.


IDs falsely reported in attribute selectors

These two selectors have the same specificity (jsFiddle):
[href="#main"] {
    color: red;
}

.link {
    color: green;
}

However, I think Parker is reporting [href="#main"] as being an ID. When running Parker over a stylesheet containing only the above CSS (abridged for brevity):
PARKER-JS
Total Stylesheets: 1
Total Stylesheet Size: 64
Total Rules: 2
Total Selectors: 2
Total Identifiers: 3
Total Declarations: 2
Selectors Per Rule: 1
Identifiers Per Selector: 1.5
Specificity Per Selector: 55.5
Top Selector Specificity: 101
Top Selector Specificity Selector: [href="#main"]
Total Id Selectors: 1
...

@csswizardry I guess you didn't get a notification for this, but I just submitted a fix for this (among with a fix for my own bug) in #35.


Support for Microsoft.EntityFrameworkCore.InMemory?

Hi,
Is somehow possible to unit test app with entities using HierarchyId type properties?
I have added a prop of HierarchyId  type to one my entitties, running project and I got error:
System.InvalidOperationException : No suitable constructor found for entity type 'HierarchyId'. The following constructors had parameters that could not be bound to properties of the entity type: cannot bind 'value' in 'HierarchyId(SqlHierarchyId value)'.
I have tried to use .UseHierarchyId() with memory database configuration but the method is supposed only for SqlServerDbContextOptionsBuilder, as expected.
Similar to this issue: https://github.com/bricelam/EFCore.SqlServer.HierarchyId/issues/2
Project to demonstrate this issuse: https://github.com/saliksaly/aspnetcoreapp-efcore-inmemory-EFCore.SqlServer.HierarchyId
Just get and run.
Thanks for your help...

This may be fixed in EF Core 5.0. I seem to remember some work in this area. I'll try it and see.

Oh wait, we need to implement a value comparer. There are probably bugs around change tracking even in SQL Server because we don't.

I take it back, we don't have bugs in change tracking because HierarchyId is immutable.

Actually, the EF Core InMemory uses different service interfaces.
I made a local version that is working and I was thinking to make a PR for that, but considering it targets the InMemory, then I was thinking it would be more suited to have a new repository or at least NuGet package for that: EFCore.InMemory.HierarchyId.

Hello! Is there any progress for this issue?

There is working solution for this, but it requires some unit tests: #33

Finished with the PR, it just requires approval.

Resolved by PR #33


Update line abbreviations from RL, OL, BL to line-red, line-orange, line-blue

Companion to https://github.com/transitmatters/t-performance-dash/pull/459

@johnbrussell @PatrickCleary is there anything else we need here? Or could we make this + https://github.com/transitmatters/t-performance-dash/pull/459 ready to review?

I think it's good to go. We just need to go into dynamo and delete all the existing entries and repopulate the tables.


fix(remix): Add support for Root Layout feature for v4

Description
This PR addresses a couple problems for Remix:

Adds root Layout feature that was introduced in Remix v2.7
Fixes a Cloudflare Worker specific error, see the error reported to the Wrangler repo here
Updates @clerk/remix dependencies to the latest minor version

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

!snapshot

Hey @octoper - the snapshot version command generated the following package versions:

Package
Version

@clerk/remix
3.2.0-snapshot.vfdf2700

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/remix
npm i<EMAIL_ADDRESS>--save-exact


Improve CircleCI workflow and fix bug w/migrations running when app build is broken

Split out pre-commit tests into it's own job
Split migration job into build and deploy jobs
Run pre-commit and all build jobs in parallel

This has the following effects:

Fixes bug where migrations could run against DB even if the app build was broken
Runs migration build on branches (so errors are caught before master)

[Finishes #154821541]

Branch builds now ~20% faster!

Looks pretty good. I'm wondering if we should get rid of install_dependencies

Removed install-dependencies.sh in 62f7fdf9680fe34b04f167c24d39054469bda529.


feat: add assign to project with fields

Add action to assign new issues and pull requests to a project
Add docs and licenses

@luizstacio Would it make sense to mock the GH api and have some basic unit tests to ensure the values are set correctly from the action inputs?

@luizstacio Would it make sense to mock the GH api and have some basic unit tests to ensure the values are set correctly from the action inputs?

I think it makes sense, I was looking to have tests in the CI level also, can we implement it on a next issue?

@luizstacio Would it make sense to mock the GH api and have some basic unit tests to ensure the values are set correctly from the action inputs?

I'm going to add some tests in this way


Randomized SVD

Randomized SVD is the default, more efficient SVD solver in scikit-learn when the input data is large.

Halko, N., Martinsson, P. G., and Tropp, J. A. (2011). “Finding structure with randomness: Probabilistic algorithms for constructing approximate matrix decompositions”. SIAM review, 53(2), 217-288.
Martinsson, P. G., Rokhlin, V., and Tygert, M. (2011). “A randomized algorithm for the decomposition of matrices”. Applied and Computational Harmonic Analysis, 30(1), 47-68.

Added in 0.2.0.


implement declare_property

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>Implements declare_property FFI.
Fixes #479
The following is a canonical example:

root context: declare_property(x, { serialized schema })
request context: set_property({"x"}, { serialized content })
request context: get_property({"x", "y"}, &value)

Changes:
Getting a filter state property requires using the same path used in set_property. This is simpler, and cleaner.

Will need to cherry pick on istio/envoy after merge.

@PiotrSikora do you have any comments?


Possible to add other markdown pages beside overview.md?

I'd like to add a changelog as a second page in the styleguide. Easy to do or hack required?

At the moment you can have only one overview page.

Forgot I created this issue, thanks for following up.

+1 - this is also something I'd be interested in doing.

+1 me too


WIP: complete swarm stacks

What do these changes do?

[x] provide traefik as reverse proxy
[x] provide portus as docker registry with S3 storage
[x] provide grafana as monitoring stack
[x] provide minio as S3 stack
[x] provide graylog as log aggregator stack
[x] provide deployment-agent as auto-deployer stack to deploy simcore

Related issue number

Checklist

[ ] I think the code is well written
[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes
[ ] Runs in the swarm
[ ] If you design a new module, add your user to .github/CODEOWNERS

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #30   +/-   ##
======================================
  Coverage    85.1%   85.1%
======================================
  Files          20      20
  Lines         685     685
======================================
  Hits          583     583
  Misses        102     102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad863b...7d96999. Read the comment docs.


JSON.stringify: Return type should include undefined

Thanks a lot for fixing #5.
By the way, after the fix of #5, JSON.stringify can receive undefined, symbol, and more.
When JSON.stringify receives them, it returns undefined. So its return type should be string | undefined, isn't it?

Thank you, fixed in 2.1.0.


AWS Lambda Dockerfile

This is not functioning yet. This is just the skeleton.
Need to test if I can get OpenJDK to install on AWS Linux or try AWS Coretta. Or perhaps see if the OpenJDK is already available on Amazon Linux.

Ended up using Amazon Coretto. Works. Might be able to use a less heavy version of Coretto (See here: https://docs.aws.amazon.com/corretto/latest/corretto-17-ug/amazon-linux-install.html).
By running:
docker run --env-file .env -p 9000:8080 ssync

I'm able to pass in the environment variables, then run ./test_lambda.sh to see that the Files are successfully being listed in the Lambda.


⚠ ClamAV has degraded performance

In 4c2553d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 75 ms

Resolved: ClamAV performance has improved in db22a1c.


Log even when we're not the group leader

fixes #65

Coverage remained the same at 73.333% when pulling 546adda927c18fd3777f2899b8b1f3d7b2308c4f on SophisticaSean:master into 8e4290a7377a3624b3eaab9db1889d7e9c537bb7 on Nebo15:master.

Coverage remained the same at 73.333% when pulling 546adda927c18fd3777f2899b8b1f3d7b2308c4f on SophisticaSean:master into 8e4290a7377a3624b3eaab9db1889d7e9c537bb7 on Nebo15:master.


removing sentry

This removes sentry as a default ... we don't really use it, from my experience. Let know if you have different view on this.
For the server side:
Google cloud can handle all error monitoring we need via Error reporting (with the latest update to instrumentation)
For the client side:
We never really look at sentry because there is too much noise so we don't.
If we need it for the client side it's not a huge problem to add back, ad hoc.

For browser monitoring https://github.com/GoogleCloudPlatform/stackdriver-errors-js/ could be used ... but i doubt its a good fit for browsers... you need filters to avoid too much noise ... but depending on usecase it could be be a candidate.
I think i would want to use sentry if we need clienstside tracking

Maybe good to list up what sentry provides that GCP cannot... from a preliminary look:

GCP can create alerts for different log levels ... I can't do it now because the permissioning is obtuse and annoying, however it could potentially created alerts or more granular context than sentry could
Do we get stack traces on errors? If we don't it's something we could probably send up to GCP but no doubt the interface won't be as slick as sentry
latency/performance?
"breadcrumbs" or tracing of events that lead to the error? (this is in sentry, probably not in GCP)

sorry actually I did set it up recently for API as well

I am just gonna close it, i think ... there might be tiny tweak to optimize that sentry isnt loaded unless there is a dns key set (browser)


Adding elements to the map via table

I'd like to add elements (we'll just say points for now, but in the future, this will include polys/paths) to the visualized map via input to the dynamic table. What would be the process for accomplishing that?
My initial thinking is that I'll need a button to "add row". But how that button should link into the table stream is not clear. The table stream self.poly_table = DynamicMap(self.load_table, streams=streams) is linked to the load_table callback. If I force an entry, won't that break the dynamic mapping?
Its almost like the current setup is that the dynamic table linkage is a one way street, always listening for more information from the the map. But I need this to be a two-way street. I need the table to listen for information from the map and I need the map to listen for information from the table. Does that make sense? Is that possible?

This may be further complicated by the fact that when we add a new row, it should be empty. I'm not sure if an attempted drawing of an empty element will cause problems.

Its almost like the current setup is that the dynamic table linkage is a one way street, always listening for more information from the the map. But I need this to be a two-way street. I need the table to listen for information from the map and I need the map to listen for information from the table. Does that make sense? Is that possible?

In future we can probably have a widget button to add rows to the Table yes, but that work will probably have to wait on the simplified PolyAnnotator.

So the required work is at a level deeper than the annotators themselves? i.e. this isn't something that could be done for the point annotator (only) in its current state? I'm ok with waiting, I just want to make sure I understand.

No, the work is likely at the Annotator level, but as discussed elsewhere, it doesn't make much sense to build stuff on PolyAnnotator which we've already decided should be hugely simplified. That simplification is waiting on changes/features in HoloViews though.

Can an update on this? Seems like it was waiting on something in Bokeh?

We had an internal issue about this on the private repo, which references the relevant bokeh issues: https://github.com/ContinuumIO/EarthSim/issues/137

I can do this with panel using a button to add a row and redrawing the table.
@philippjfr Unless there were plans to implement this at a deeper level, then I suggest closing.

We did discuss adding this functionality directly to bokeh tables and opened an issue https://github.com/bokeh/bokeh/issues/7988. No progress on that front though and it's unlikely to happen unless we explicitly prioritize it.

I see this as necessary functionality for many workflows for recieveing input. We will need the ability copy and paste data into the bokeh table also -- automatically expand (add the necesary rows) to contain the new data.
Some applications (i.e. polygons) will require the table order to indicate relationship of the data entries.  Therefore, being able to insert an empty row at the beginning, in the middle, or the end is necessary. Likewise, deleting specific rows or multiple rows, is necessary also.
+1

From the internal issue:

[ ] Bokeh #7988: Add ability to insert new row in DataTable
[ ] Bokeh #7762: Add support for copy and paste into DataTable


Status on PCB

What's the status on the PCB boards of the remote?

No recent progress.  I ordered a few ESP32-S3 modules intended for use with this project but haven't worked on it.

Ok. Where would I get the PCBs when they’re ready?
On Fri, Nov 24, 2023 at 16:11 mulcmu @.***> wrote:

No recent progress. I ordered a few ESP32-S3 modules intended for use with
this project but haven't worked on it.
—
Reply to this email directly, view it on GitHub
https://github.com/mulcmu/Modernize-Harmony-880/issues/1#issuecomment-1826086740,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5HHCWJVJXWQMQIU56VXYHTYGEEOTAVCNFSM6AAAAAA7YLEIDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGA4DMNZUGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I ordered the originals from jlcpcb.com as bare boards.

Can you remind me when the PCBs are done and mail one to me? Thanks
On Fri, Nov 24, 2023 at 16:39 mulcmu @.***> wrote:

I ordered the originals from jlcpcb.com as bare boards.
—
Reply to this email directly, view it on GitHub
https://github.com/mulcmu/Modernize-Harmony-880/issues/1#issuecomment-1826098682,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5HHCWNTVEEUBCBQFKQFW33YGEH2RAVCNFSM6AAAAAA7YLEIDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGA4TQNRYGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sure.  I'll reach out when they are ready.


Windows versions (and others) are missing for v1.18.0

Describe the bug
Unless this is on purpose, it looks like the windows binaries are missing from the latest release, and there also seems to be a lot less files than before.

You need to wait for the CI builds to finish :)

Oh ok :D sorry


where can we download Open-Sora 1.1 checkpoint weights?

You can download here: https://github.com/hpcaitech/Open-Sora/tree/main?tab=readme-ov-file#open-sora-11-model-weights


[ADAP-474] [Feature] Accept users, groups, or roles in grants config on resource

Is this a new bug in dbt-redshift?

[X] I believe this is a new bug in dbt-redshift
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
After specifically creating the group finance_department in Redshift, I cannot use it as a grantee in the grant config.
I can see the group when I run SELECT * FROM pg_group
models:
  - name: specific_model
    config:
      grants:
        select: ['finance_department']

Error: user "finance_department" does not exist
Expected Behavior
Grantee syntax says groups, not just users, should be accepted: https://docs.getdbt.com/reference/resource-configs/grants#common-syntax
Steps To Reproduce

Create a group in redshift
Add to a grants config on a model

Relevant log output
No response
Environment
- OS:
- Python:
- dbt-core:
- dbt-redshift:

Additional Context
No response

Thanks for following up @stevenayers-tvx !
Only granting to (and revoking from) Redshift users was explicitly covered in the original implementation of grants in https://github.com/dbt-labs/dbt-redshift/pull/131  -- granting/revoking for Redshift groups and roles was not.
This deserves clarification in the docs, and I've opened https://github.com/dbt-labs/docs.getdbt.com/pull/3245 accordingly.
I'm going to convert this into a feature request to add support for grants for Redshift groups and roles.

We use this extensively, and intentional or not it seems that just using group <group_name> works perfectly fine. @stevenayers-tvx does it work if you just do this?
models:
  - name: specific_model
    config:
      grants:
        select: ['group finance_department']

Reopening as the PR that relates to it is still open


Modify Longest Palindromic Substring [CPP]

The Algo can be implemented in a better way like the python implementation consuming less space.

[ ] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[ ] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

@aviaryan @singhpratyush Please assign me this one.


[Segment Replication] Add setting to enable segment replication as default replication type.

Description
This PR adds setting for users to enable segment replication as default replication strategy.
-> This setting is a static setting and can only be enable through configuration and not by REST API's.
-> When this setting is enabled it makes all new indices in cluster use segment replication as default replication type. But users can still create an index using document replication by passing replication type as DOCUMENT during index creation. As Index level settings always override cluster level settings.
-> Not only during index creation but also if users set "index.replication.type" in configuration file, as it is an index level setting it will override the new setting of default segment replication.
-> This setting is not applied for system indices. By default all system indices in opensearch will still use document replication even if this setting is enabled.
-> This setting is still behind a Segment Replication Feature flag. So, users have to still enable feature flag for this setting to work. Once feature flag is removed users can set this setting directly.
Issues Resolved
Resolves #6656
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/12778/
CommitID: 7b3e333
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Looks like a legit failure.
REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.replication.SegmentReplicationDefaultIT.testReplicationWithDefaultSegmentReplicationSetting" -Dtests.seed=A834E113C4F1CF78 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=de-DE -Dtests.timezone=Australia/Queensland -Druntime.java=19

org.opensearch.indices.replication.SegmentReplicationDefaultIT > testReplicationWithDefaultSegmentReplicationSetting FAILED
    java.lang.AssertionError: expected null, but was:<[SegmentReplicationPerGroupStats{replicaStats=[SegmentReplicationShardStats{allocationId=s2L3gNsbQUei809hRc-pOg, checkpointsBehindCount=0, bytesBehindCount=0, currentReplicationTimeMillis=0, lastCompletedReplicationTimeMillis=45, currentReplicationState=org.opensearch.indices.replication.SegmentReplicationState@2e66ad62}], rejectedRequestCount=0}]>
        at __randomizedtesting.SeedInfo.seed([A834E113C4F1CF78:92D0663D70F53C93]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotNull(Assert.java:756)
        at org.junit.Assert.assertNull(Assert.java:738)
        at org.junit.Assert.assertNull(Assert.java:748)
        at org.opensearch.indices.replication.SegmentReplicationDefaultIT.testReplicationWithDefaultSegmentReplicationSetting(SegmentReplicationDefaultIT.java:106)

Codecov Report

Merging #6791 (81da78b) into main (4d78bbf) will increase coverage by 0.15%.
The diff coverage is 53.33%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #6791      +/-   ##
============================================
+ Coverage     70.65%   70.80%   +0.15%
- Complexity    59184    59240      +56
============================================
  Files          4810     4810
  Lines        283487   283498      +11
  Branches      40877    40882       +5
============================================
+ Hits         200299   200740     +441
+ Misses        66761    66274     -487
- Partials      16427    16484      +57

Impacted Files
Coverage Δ

.../main/java/org/opensearch/index/IndexSettings.java
85.30% <20.00%> (-0.91%)
:arrow_down:

...org/opensearch/cluster/metadata/IndexMetadata.java
84.66% <50.00%> (+0.30%)
:arrow_up:

...rg/opensearch/common/settings/ClusterSettings.java
92.50% <100.00%> (+0.19%)
:arrow_up:

...in/java/org/opensearch/indices/IndicesService.java
63.76% <100.00%> (-0.04%)
:arrow_down:

... and 527 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Currently, when user set cluster setting "cluster.indices.replication.strategy" in opensearch.yml, all the newly created indices will use segment replication as default replication strategy. But when user tries to fetch index settings GET /<index>/_settings the response does not show replication type as SEGMENT. So this is a bug and it might be confusing for users. I am currently looking for any other workarounds to fix this issue, I will update here as soon as I find something. Any other thoughts are much appreciated please.