WIP: :add bytes add, contain, getitem

TODO at #736

Codecov Report

Merging #738 into master will increase coverage by 0.06%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage    45.9%   45.96%   +0.06%
==========================================
  Files          81       81
  Lines       16164    16170       +6
  Branches     3966     3959       -7
==========================================
+ Hits         7420     7433      +13
+ Misses       6945     6938       -7
  Partials     1799     1799

Impacted Files
Coverage Δ

vm/src/obj/objbytes.rs
50.64% <90.9%> (+6.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4666a09...017a9ef. Read the comment docs.

@jgirardet thank you for your time contributing to this project! I left some review comments, but the change looks good to me.

a more general question : should we use args_cjeck! or type_check! every time it's possible or is the if statement : if objtype::isinstance(&needle, &vm.ctx.bytes_type()) acceptable ?

What you did is good, because NotImplemented wouldn't be returned if you used arg_check.

@jgirardet I think this work is good. Is it still a work in progress, or is it ready for merging?

Some tests are disabled due to #746

ARgh I broke everything with git in the rebase/merge...
I'm gonna start a new clean PR to clean things


python310Packages.eventlet: 0.33.0 -> 0.33.1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 175795 run on x86_64-linux 1

2 packages marked as broken and skipped:

python310Packages.zake
python39Packages.zake

1 package failed to build:

pgadmin4

63 packages built:

appdaemon
gdbgui
home-assistant-component-tests.ambient_station
onionshare
onionshare-gui
openstackclient (python39Packages.python-openstackclient)
patroni
python310Packages.aioambient
python310Packages.cassandra-driver
python310Packages.eventlet
python310Packages.flask-socketio
python310Packages.kazoo
python310Packages.keystoneauth1
python310Packages.openstacksdk
python310Packages.osc-lib
python310Packages.oslo-concurrency
python310Packages.oslo-db
python310Packages.oslo-log
python310Packages.oslo-serialization
python310Packages.oslo-utils
python310Packages.python-cinderclient
python310Packages.python-engineio
python310Packages.python-glanceclient
python310Packages.python-heatclient
python310Packages.python-ironicclient
python310Packages.python-keystoneclient
python310Packages.python-manilaclient
python310Packages.python-novaclient
python310Packages.python-openstackclient
python310Packages.python-socketio
python310Packages.python-swiftclient
python310Packages.subunit2sql
python310Packages.swift
python310Packages.tago
python310Packages.tempest
python39Packages.aioambient
python39Packages.cassandra-driver
python39Packages.eventlet
python39Packages.flask-socketio
python39Packages.kazoo
python39Packages.keystoneauth1
python39Packages.openstacksdk
python39Packages.osc-lib
python39Packages.oslo-concurrency
python39Packages.oslo-db
python39Packages.oslo-log
python39Packages.oslo-serialization
python39Packages.oslo-utils
python39Packages.python-cinderclient
python39Packages.python-engineio
python39Packages.python-glanceclient
python39Packages.python-heatclient
python39Packages.python-ironicclient
python39Packages.python-keystoneclient
python39Packages.python-manilaclient
python39Packages.python-novaclient
python39Packages.python-socketio
swiftclient (python39Packages.python-swiftclient)
python39Packages.subunit2sql
python39Packages.swift
python39Packages.tago
python39Packages.tempest
zk-shell

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 175795 run on x86_64-linux 1

2 packages marked as broken and skipped:

python310Packages.zake
python39Packages.zake

64 packages built:

appdaemon
gdbgui
home-assistant-component-tests.ambient_station
onionshare
onionshare-gui
openstackclient (python39Packages.python-openstackclient)
patroni
pgadmin4
python310Packages.aioambient
python310Packages.cassandra-driver
python310Packages.eventlet
python310Packages.flask-socketio
python310Packages.kazoo
python310Packages.keystoneauth1
python310Packages.openstacksdk
python310Packages.osc-lib
python310Packages.oslo-concurrency
python310Packages.oslo-db
python310Packages.oslo-log
python310Packages.oslo-serialization
python310Packages.oslo-utils
python310Packages.python-cinderclient
python310Packages.python-engineio
python310Packages.python-glanceclient
python310Packages.python-heatclient
python310Packages.python-ironicclient
python310Packages.python-keystoneclient
python310Packages.python-manilaclient
python310Packages.python-novaclient
python310Packages.python-openstackclient
python310Packages.python-socketio
python310Packages.python-swiftclient
python310Packages.subunit2sql
python310Packages.swift
python310Packages.tago
python310Packages.tempest
python39Packages.aioambient
python39Packages.cassandra-driver
python39Packages.eventlet
python39Packages.flask-socketio
python39Packages.kazoo
python39Packages.keystoneauth1
python39Packages.openstacksdk
python39Packages.osc-lib
python39Packages.oslo-concurrency
python39Packages.oslo-db
python39Packages.oslo-log
python39Packages.oslo-serialization
python39Packages.oslo-utils
python39Packages.python-cinderclient
python39Packages.python-engineio
python39Packages.python-glanceclient
python39Packages.python-heatclient
python39Packages.python-ironicclient
python39Packages.python-keystoneclient
python39Packages.python-manilaclient
python39Packages.python-novaclient
python39Packages.python-socketio
swiftclient (python39Packages.python-swiftclient)
python39Packages.subunit2sql
python39Packages.swift
python39Packages.tago
python39Packages.tempest
zk-shell

pgadmin4.tests pass, too


How to send commands to a vehicle?

I was wondering if it will soon be possible to send commands to the vehicle via fleet-telemetry, for example to open or close doors or to enable engine start.
Is there already a plan when this will be available?
Thank you for the help!

No, there is no plan for this


Fix exception on scripted value using variable as value

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 5 (80.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 93.82%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

commonItems/ScriptValueCollection.cs
4
5
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
3204

Relevant Lines:
3380

💛  - Coveralls


core: remove node sdk startup logic

This is causing issues with the dial in worker, so let's instead add
polyfills on that side to make it work more like the browser, rather
than altering the sdk behaviour

Description
Summary:

Related Issue:

Testing

Screenshots/GIFs (if applicable)

Checklist

[ ] My code follows the project's coding standards.
[ ] Prefixed the PR title and commit messages with the service or package name
[ ] I have written unit tests (if applicable).
[ ] I have updated the documentation (if applicable).
[ ] By submitting this pull request, I confirm that my contribution is made
under the terms of the MIT license.

Additional Information

/canary


publish standalone snark worker

Publish "src/lib/snark_worker/standalone/run_snark_worker.exe" in mina-daemon debian package. App will be built using two profiles (mainnet,devnet) and  placed in mina-devnet and mina-mainnet debian packages.
App will be automatically added to dockers (daemon and rosetta) as we are installing debian while building docker

!ci-build-me

Deployment for https://github.com/MinaProtocol/mina/pull/16406


Partial header shadow from search bar

The search bar contained in the header on the "find loops" page and home page has a drop shadow but the rest of the header does not, resulting in an odd-looking grey line that does not span the full width of the header

shadow has been removed


Need to specify the version in the VS user agent

To be able to track what version of the extension is sending the requests.

This is fixed as of d435c6f


Bug: Drag and scroll manually leads to incorrect behavior

How to reproduce this issue:

build GridView with mulitple children, so that you can scroll
drag one child at the bottom
then scroll manually (not with the dragged child) to the top
then the children are not changing their positions even when the dragged child is above them

Can be closed with the release of 5.0.0


SPInstallPrereqs: Microsoft Visual C++ 2017 x64 Additional Runtime wrong check for SP2019

Details of the scenario you tried and the problem that is occurring
SPInstallPrereqs for SP2019 check test search for:
Microsoft Visual C++ 2017 x64 Additional Runtime - 14.14.*
and it return false because the installed version is Microsoft Visual C++ 2017 x64 Additional Runtime - 14.13.26020
Verbose logs showing the problem
Suggested solution to the issue
Please check for "Microsoft Visual C++ 2017 x64 Additional Runtime - 14." and not "Microsoft Visual C++ 2017 x64 Additional Runtime - 14.14."
The DSC configuration that is used to reproduce the issue (as detailed as possible)
 SPInstallPrereqs SPPrereqs
        {
            IsSingleInstance = "Yes"
            InstallerPath        = $SharePointBinaryPath + "\prerequisiteinstaller.exe"
            OnlineMode           = $true
                    Ensure               = "Present"
            PsDscRunAsCredential = $Credssp_admin
        }

The operating system the target node is running
Microsoft Windows Server 2016 Datacenter
Version of SharePoint that is used (e.g. SharePoint 2016)
SharePoint 2019
Version and build of PowerShell the target node is running
Name                           Value

PSVersion                      5.1.14393.2430
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.2430
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
Version of the DSC module that was used ('dev' if using current dev branch)
3.0

We have detected this issue as well and are working on fixing this


Routing key is stripped

Publishing to a remote x-recent-history exchange removes the routing key of messages :(

Actually, the routing_key is there for new messages delivered while the queue is bound, but all old messages that are put into the queue on bind don't have a routing_key.

Maybe bump the version number (1.2.1?) and release a new version to https://www.rabbitmq.com/community-plugins.html ? I can do it, is it just to post the .ez file to the mailing list?

No, it doesn't work like that, we have a build system for community plugins. I'll ask @dumbbell

A new version of the plugin should we up on our community plugins page
On Fri, May 22, 2015 at 9:33 AM Carl Hörberg<EMAIL_ADDRESS>wrote:

Maybe bump the version number (1.2.1?) and release a new version to
https://www.rabbitmq.com/community-plugins.html ? I can do it, is it just
to post the .ez file to the mailing list?
—
Reply to this email directly or view it on GitHub
https://github.com/videlalvaro/rabbitmq-recent-history-exchange/issues/13#issuecomment-104548961
.

@carlhoerberg, to answer your question, to publish new or updated plugins to the community page, we run the build-community-plugins.py script in rabbitmq-public-umbrella/release-build. Once done, the script deploy-community-plugins.py uploads the artifacts to www.rabbitmq.com. Finally, one has to re-deploy the website so the community-plugins.html page is updated (the website is static).
Not very straightforward or community-oriented :-)


Crash on Tiptoe

Thanks for your work. It works great except i get crashes when i get the tiptoe round. I tried changing injectors but it doesn't solve the problem. Any idea where the problem could be?
Game log shows:
(UnityPlayer) (function-name not available)
ERROR: SymGetSymFromAddr64, GetLastError: 'Attempt to access invalid address'

I've tried building with virtual studio 2019 and I'm getting an error, do you know how to solve this?

Next time attach debugger from visual studio it will show more informations which will help to solve it

This time it happened on match fruit round but usually happens on tiptoe. This is the exception and the callstack
Exception thrown: read access violation.
i was nullptr.
Callstack

FlyGuys.dll!update() Line 467	C++
FlyGuys.dll!dxgi_present::hooked(IDXGISwapChain * p_swap_chain, unsigned int sync_interval, unsigned int flags) Line 621	C++

Line 467 render.cpp:
auto current_object = i->object;
Hope this helps

I added nullptr check let me know if crash still occurs


CAMEL-12246 Fix broken links

@davsclaus and @oscerd, here are the changes to the AsciiDoc linking that we discussed. Here's a summary of what was done:

Resolve the duplicate IDs (can't do any harm, and is actually required for our downstream builds)
Take into account the -eip suffix, which might reduce the number of unresolved links.
All resolvable links to be transformed to AsciiDoc cross-reference format, as follows:

link:LINKNAME.html[Text of Link]  =>  <<LINKNAME, Text of Link>>

Where, in some cases, LINKNAME might be augmented by a -component, -dataformat, -language, or -eip suffix.

Identify the broken EIP links and leave them alone. These will continue to show up as broken links, but we can easily fix them later.
All other unresolved links will be removed. Probably do this by replacing:

link:LINKNAME.html[Text of Link]   =>  Text of Link

Thanks for the PR :-)

This will work once the docs will be generated, but actually with this the link won't work in Github.
@davsclaus do we have to revert?

@oscerd yes, but I have the impression that most links were already broken in GitHub anyway. For example, if you look at the camel-http doc page in the commit before this PR was merged:
https://github.com/apache/camel/blob/ee26d31bcc10fad113fa46cbf0bf4b36f9f0cfbc/components/camel-http/src/main/docs/http-component.adoc
Search for the link to "Jetty Component". When you click on it, you get a 404. My impression is that this is fairly typical of the links that were already there.

Yeah, true. You're right.


Selectively disable minutes in AM/PM in 12 hour timepicker

Is there any way to set disabled minutes separately in AM/PM? My use case is that I'm using two timepickers side-by-side to select a start and end time. I need to disable all hours and minutes in the second timepicker prior to the start time in the first. For example, if the start time is, say, 5:35PM, I can properly disable all hours prior to that in the second timepicker (i.e. all AM hours are disabled and 12-4 disabled in PM) but the current behavior will still show minutes 0-34 as selectable in the AM timepicker.

I'd like to bump this up. I also have an issue where we have time ranges and need to disable midnight and only allow users to select 11:59pm.


[v2] ssh-agent from oh-my-zsh is loaded twice

  source ~/.zplug/init.zsh

  zplug 'plugins/ssh-agent', from:oh-my-zsh

  zplug check || zplug install

  zplug load --verbose

yields:
  Loaded robbyrussell/oh-my-zsh/plugins/ssh-agent/ssh-agent.plugin.zsh
  Loaded robbyrussell/oh-my-zsh/plugins/ssh-agent/ssh-agent.plugin.zsh

The plugin is also added twice to $ZPLUG_CACHE_FILE.
I dug a bit deeper and found that __load__ registers the plugin both as having a custom handler (by calling __zplug::core::core::is_handler_defined) which causes the path to be added to load_plugins but then goes on and adds it a second time.

Is this change (branch: fix-163) what you desired?

Now it's loaded once, but still put in the cache twice.

Have you tried zplug clear?

I deleted the cache file before updating the issue.
Alex
http://therightstuff.de/
Tiny phone, tiny mail
On Apr 28, 2016, 11:39, at 11:39, BABAROT<EMAIL_ADDRESS>wrote:

Have you tried zplug clear?

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/b4b4r07/zplug/issues/163#issuecomment-215368260

OK, I'll fix it later.

Try it out please!
branch: fix-163

:shipit: Looking good now, thanks!

Hi, I've just tried the branch for the fix but it still seems to double (and even tripple) list some oh-my-zsh plugins in the cache file.
It only loads them more than once when the have a nice value (the once without nice are loaded once now with the fix-163 branch), to load after compinit. For example my zplug plugins sections lists:
zplug "plugins/gradle", from:oh-my-zsh, nice:10
zplug "plugins/brew-cask", from:oh-my-zsh, nice:10

Resulting output in cache file:
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/brew-cask/brew-cask.plugin.zsh"
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/brew-cask/brew-cask.plugin.zsh"
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/brew-cask/brew-cask.plugin.zsh"
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/gradle/gradle.plugin.zsh"
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/brew-cask/brew-cask.plugin.zsh"
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/brew-cask/brew-cask.plugin.zsh"
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/brew-cask/brew-cask.plugin.zsh"
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/gradle/gradle.plugin.zsh"
source "/Users/dries/.zplug/repos/robbyrussell/oh-my-zsh/plugins/gradle/gradle.plugin.zsh"

Notice the brew-cask plugin even appears 6 times.

Please try out the fix-duplicates branch and see if this fixes the problem.

Hi, I've just tried the branch and it fixes the duplicates, thanks!

@NigoroJr I am having this issue, this is the whole setup https://github.com/yordis/.dotfiles


Update jenkinsfile to accept parameters

Tested with openjdk8-linux/mac, openjdk-openj9:linux
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

When merged will update all related with sdk build to trigger parameterized test build. Leave windows as in until window build is stable.


Added average on HORIZONTAL, VERTICAL, and QUARTER skins.

I've forgot AMP... so please wait before merging this pull request.

Too late ;-)

:)

I've not started codit it, so not a big problem, I'll do another pull request


[Update Snap] hedera-wallet-snap

Checklist
All items in the list below needs to be satisfied.

[x] Is the summary of the change documented in this ticket?
[x] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted?
[x] If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue.
[ ] The corresponding pull request in this repo has been merged.

Summary of changes:

Added new APIs to interact with additional functionalities of Hedera such as transferring fungible and non fungible tokens and added more optimization and some bug fixes as well.

Added a new API to associate fungible/non-fungible tokens to an account
Added support to be able to transfer any kind of tokens including hbar, fungible and non-fungible tokens
Added a new API to stake/unstake Hbar to and from Hedera Network nodes
Added a new API to approve/delete an allowance for Hbar, tokens and NFTs
Added a new API to delete a Hedera account from the ledger permanently.

The full diff between the last published version and the new one is here:
https://github.com/hashgraph/hedera-metamask-snaps/compare/v0.1.5...v0.2.4
For this update, the request was to remove all previous whitelisted versions and list only the new one.
New Version to be allowListed: v0.2.4
Prev. versions being removed: 0.1.3, 0.1.5


It would be nice if --proxy / ETCD_PROXY would support boolean arguments

It would be nice if --proxy / ETCD_PROXY would support boolean arguments. I.e. if it would support the string "readonly" or a boolean "on/off", "yes/no", "true/false" argument.
Why I think this way: I wrote a bootcfg YAML file where I put etcd_proxy: on in the metadata section. The metadata file generated by bootcfg contains ETCD_PROXY=true (well, modulo bugs: coreos/coreos-baremetal#85). Thus I assume that bootcfg's YAML parser interprets "on" as "true", which requires me to use string quoting for that particular value. If etcd would be a bit more relaxed, I would never have noticed about this.

@urzds Proxy flag has three values, so boolean is not enough. We do not want to introduce more flags and make one flag (proxy needs to support the old string and the boolean you proposed) accept multiple set of values at this point.


Delete the message requesting the spongemock

Delete the message/comment that is requesting the spongemock. It gives the spongemock a more natural feel and it reduces unnecessary spam.
Should be possible: https://stackoverflow.com/questions/35269776/telegram-bot-how-to-delete-or-remove-a-message-or-media-from-a-channel-or-group/43965602#43965602

If the original message is deleted the bot should start the new message with the nickname of the original messages sender.
MyNickname:
mEsSaGeBoDy

I think that kinda ruins the purpose of spongemocking as it normally gets projected on the retard spongebob. The spongemock in DankTimesBot should probably feel the same way as the DankTimesBot is mocking your text.

How about we delete the /spongemock message and have DankTimesBot reply to the original author with the spongemocked message?


failed to read packet: Network is down

I'm trying to capture using an Intel Wireless-AC 9260 (iwlwifi kmod)
06:00.0 Network controller: Intel Corporation Wireless-AC 9260 (rev 29)

and run into the following issue, without the tool finding anything usable.
$ sudo ./hcxdumptool/hcxdumptool -o test.pcapng -i wlp6s0 --enable_status

start capturing (stop with ctrl+c)
INTERFACE:...............: wlp6s0
FILTERLIST...............: 0 entries
MAC CLIENT...............: fcc23399c311 (client)
MAC ACCESS POINT.........: 11111141b95a (start NIC)
EAPOL TIMEOUT............: 1000000
DEAUTHENTICATIONINTERVALL: 20 beacons
GIVE UP DEAUTHENTICATIONS: 10 tries
REPLAYCOUNTER............: 61654
ANONCE...................: 43d3a6696159fbcca67531e333d7946b0e8c9a914ce90137613211cea69d43e9

INFO: cha=13, rx=0, rx(dropped)=0, tx=7, powned=0, err=0
failed to read packet: Network is down
INFO: cha=9, rx=0, rx(dropped)=0, tx=70, powned=0, err=1
failed to read packet: Network is down
INFO: cha=5, rx=0, rx(dropped)=0, tx=133, powned=0, err=2
failed to read packet: Network is down
INFO: cha=1, rx=0, rx(dropped)=0, tx=196, powned=0, err=3
failed to read packet: Network is down
INFO: cha=10, rx=0, rx(dropped)=0, tx=259, powned=0, err=4
failed to read packet: Network is down
INFO: cha=6, rx=0, rx(dropped)=0, tx=322, powned=0, err=5
failed to read packet: Network is down
INFO: cha=2, rx=0, rx(dropped)=0, tx=385, powned=0, err=6
failed to read packet: Network is down
INFO: cha=11, rx=0, rx(dropped)=0, tx=448, powned=0, err=7
failed to read packet: Network is down
INFO: cha=7, rx=0, rx(dropped)=0, tx=511, powned=0, err=8
failed to read packet: Network is down
INFO: cha=3, rx=0, rx(dropped)=0, tx=574, powned=0, err=9
failed to read packet: Network is down
INFO: cha=12, rx=0, rx(dropped)=0, tx=637, powned=0, err=10
failed to read packet: Network is down
INFO: cha=8, rx=0, rx(dropped)=0, tx=700, powned=0, err=11
failed to read packet: Network is down
INFO: cha=4, rx=0, rx(dropped)=0, tx=763, powned=0, err=12
failed to read packet: Network is down
INFO: cha=13, rx=0, rx(dropped)=0, tx=826, powned=0, err=13
failed to read packet: Network is down
INFO: cha=9, rx=0, rx(dropped)=0, tx=889, powned=0, err=14
failed to read packet: Network is down
INFO: cha=5, rx=0, rx(dropped)=0, tx=913, powned=0, err=15
[...]

I put the device into monitor mode beforehand:
$ iw dev
phy#0
	Unnamed/non-netdev interface
		wdev 0x4
		addr 30:24:32:**:**:**
		type P2P-device
		txpower 0.00 dBm
	Interface wlp6s0
		ifindex 2
		wdev 0x1
		addr 7e:0b:f7:**:**:**
		type monitor
		txpower 22.00 dBm

And made sure that the admin state is up.
2: wlp6s0: <NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state DORMANT group default qlen 1000
    link/ieee802.11/radiotap 7e:0b:f7:**:**:** brd ff:ff:ff:ff:ff:ff

What could be the issue?

Does hcxdumptool have full and only access to the interface?
All services with access to the device must be disabled.
For example:
NetworkManager
wpa_spupplicant

hcxdumptool running a raw socket. Is this supported by the driver? Does packet injection work?

Does tcpdump work on Intel Wireless-AC 9260 (iwlwifi kmod)?
sudo tcpdump -i wlp6s0 -w test.cap

I disconnected WiFi in NetworkManager so it probably wouldn't interfere.
When I previously used tcpdump on the WiFi interface I only so the probe requests sent out by hcxdumptool. That probably means that monitor mode isn't working properly, right?
#  sudo tcpdump -i wlp6s0
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on wlp6s0, link-type IEEE802_11_RADIO (802.11 plus radiotap header), capture size 262144 bytes
13:32:37.839587 fragmented [bit 15] Probe Request () [1.0* 2.0* 5.5* 11.0* 6.0* 9.0* 12.0* 18.0* Mbit]
13:32:42.839576 fragmented [bit 15] Probe Request () [1.0* 2.0* 5.5* 11.0* 6.0* 9.0* 12.0* 18.0* Mbit]
13:32:47.839794 fragmented [bit 15] Probe Request () [1.0* 2.0* 5.5* 11.0* 6.0* 9.0* 12.0* 18.0* Mbit]
13:32:52.839962 fragmented [bit 15] Probe Request () [1.0* 2.0* 5.5* 11.0* 6.0* 9.0* 12.0* 18.0* Mbit]
13:32:57.840173 fragmented [bit 15] Probe Request () [1.0* 2.0* 5.5* 11.0* 6.0* 9.0* 12.0* 18.0* Mbit]
13:33:02.840392 fragmented [bit 15] Probe Request () [1.0* 2.0* 5.5* 11.0* 6.0* 9.0* 12.0* 18.0* Mbit]
13:33:07.840558 fragmented [bit 15] Probe Request () [1.0* 2.0* 5.5* 11.0* 6.0* 9.0* 12.0* 18.0* Mbit]
13:33:12.840744 fragmented [bit 15] Probe Request () [1.0* 2.0* 5.5* 11.0* 6.0* 9.0* 12.0* 18.0* Mbit]

Yes, that looks like a driver issue.
tcpdump doesn't receive packets from outside, so hcxdumptool will fail, too.
The shown proberequests are loopback's.

Generally iwlwifi seems to support both monitor mode and packet injection, I'll retry later tonight on a AC-7260 and if that doesn't work I'll close this issue for lack of driver support.

For your forum post: ath9k and ath10k cards usually work pretty well on linux. I tried this on a Compex WLE600VX (QCA9882, https://www.compex.com.sg/product/wle600vx/) and capturing it just worked.

Thanks,
That is good to know, because we have some really ugly issues with ath9k_htc:
https://hashcat.net/forum/thread-6661-post-41311.html#pid41311
are the transmitted ack frames damaged?

ath9k_htc are 11n usb sticks, can't recommend any, nor their driver. For WiFi MiniPCIe is still king.
That being said, after ~20 minutes I don't seem to have found any PMKID on the ath10k card.
INFO: cha=116, rx=24274, rx(dropped)=147, tx=1901, powned=0, err=0

file name....................: test.pcapng-1
file type....................: pcapng 1.0
file hardware information....: x86_64
file os information..........: Linux 4.9.0-6-amd64
file application information.: hcxdumptool 4.2.0
network type.................: DLT_IEEE802_11_RADIO (127)
endianess....................: little endian
read errors..................: flawless
packets inside...............: 306
skipped packets..............: 0
packets with FCS.............: 0
WDS packets..................: 60
beacons (with ESSID inside)..: 70
probe requests...............: 4
probe responses..............: 9
association requests.........: 1
association responses........: 76
reassociation responses......: 63
authentications..............: 8
authentications (OPEN SYSTEM): 3
authentications (SHARED KEY).: 8

Looking into the pcapng with Wireshark I can see alot of malformed (re)association responses, is that the issue you're seeing with ath9k_htc as well?

Yes, I think so. Maybe I'm able to find a solution for that Frame CheckSum (FCS) issue.
Not all packets are affected. I noticed it on many frames, but not on all.
It seems that they are doing their own thing:
ATH_TX_RADIOTAP_PRESENT(
(1 << IEEE80211_RADIOTAP_TSFT) |
(1 << IEEE80211_RADIOTAP_FLAGS) |
(1 << IEEE80211_RADIOTAP_RATE)  |
(1 << IEEE80211_RADIOTAP_DBM_TX_POWER)  |
(1 << IEEE80211_RADIOTAP_ANTENNA)  |
(1 << IEEE80211_RADIOTAP_XCHANNEL)  |
0)
struct ath_tx_radiotap_header
{
struct ieee80211_radiotap_header wt_ihdr;
uint64_t	wt_tsf;
uint8_t	wt_flags;
uint8_t	wt_rate;
uint8_t	wt_txpower;
uint8_t	wt_antenna;
uint32_t	wt_chan_flags;
uint16_t	wt_chan_freq;
uint8_t	wt_chan_ieee;
int8_t	wt_chan_maxpow;
} __packed;

Added hardware handshake support (instead of software handshake). Now ATHEROS driver should work, too.
https://github.com/ZerBea/hcxdumptool/commit/750f870492b8e79f75fb8e4fbdb8f92374a5e86e
Please test.

This shrunk the amount of malformed packets from 50% to around 25%.
start reading from ../hcxdumptool/test.pcapng-3
failed to read packet

summary:
--------
file name....................: test.pcapng-3
file type....................: pcapng 1.0
file hardware information....: x86_64
file os information..........: Linux 4.9.0-6-amd64
file application information.: hcxdumptool 4.2.0
network type.................: DLT_IEEE802_11_RADIO (127)
endianess....................: little endian
read errors..................: yes
packets inside...............: 5038
skipped packets..............: 0
packets with FCS.............: 0
WDS packets..................: 121
beacons (with ESSID inside)..: 2083
probe requests...............: 209
probe responses..............: 122
association requests.........: 23
association responses........: 390
reassociation responses......: 134
authentications..............: 13
authentications (OPEN SYSTEM): 182
authentications (SHARED KEY).: 20
authentications (BROADCOM)...: 152
EAPOL packets................: 275
best handshakes..............: 2 (ap-less: 0)

No PMKID found yet :(

root@kali:~/Desktop/hcxdumptool# ./hcxdumptool -o hash -i wlan0mon --filterlist=filter.txt --filtermode=2 --enable_status=1
start capturing (stop with ctrl+c)
INTERFACE:...............: wlan0mon
FILTERLIST...............: 1 entries
MAC CLIENT...............: fcc233dbee6a
MAC ACCESS POINT.........: 000e2a01d37a (incremented on every new client)
EAPOL TIMEOUT............: 150000
REPLAYCOUNT..............: 65532
ANONCE...................:<PHONE_NUMBER>5444cf835c4c9215bb75c3cc679b819230856875b12ec384750c0e
INFO: cha=7, rx=3695, rx(dropped)=930, tx=72, powned=0, err=0
failed to read packet: Network is down
INFO: cha=5, rx=3695, rx(dropped)=930, tx=72, powned=0, err=753
terminated...
anyone can solve this problem? i wll use Alfa wireless device and airmon-ng check kill all process!

Are you running hcxdumptool an the physical interface or on a virtual interface created by airmon-ng?
What type of Alfa do you use awus....?
$ lsusb | grep Wire
output should look like this:
Bus 001 Device 004: ID 0bda:8187 Realtek Semiconductor Corp. RTL8187 Wireless Adapter
What is the output of
$ iw dev wlan0mon info
Please read this:
https://hashcat.net/forum/thread-6661-post-41821.html#pid41821

ALFA
802.11g High Power
Wirelwss USB Adapter
Model: AWUS036H
Bus 001 Device 003: ID 0bda:8187 Realtek Semiconductor Corp. RTL8187 Wireless Adapter
this out info
Interface wlan0mon
ifindex 5
wdev 0x100000002
addr 00:c0:ca:30:0e:fb
type monitor
wiphy 1
channel 10 (2457 MHz), width: 20 MHz (no HT), center1: 2457 MHz
txpower 20.00 dBm
But use another two wireless adapter using same error message failed to read packet: Network is down?

I assume, you use the latest version of hcxdumptool. If not, please do git pull or git clone.
Do you use the latest version of KALI?
Do not use airmon-ng to set monitor mode. hcxdumptool creates its own monitor mode.
Frome README.md:

do not run hcxdumptool on logical interfaces (monx, wlanxmon)
do not use hcxdumptool in combination with other 3rd party tools, which take access to the interface
airmon-ng is designed to run with aircrack-ng tools and not with hcxdumptool
aircrack-ng is know to work on many platforms, but it fails sometimes on KALI.
https://null-byte.wonderhowto.com/how-to/fix-network-is-down-airodump-ng-0166996/
Identify all(!) services that take access to the device and stop them (NetworkManager, wpa-supplicant)
https://docs.kali.org/installation/troubleshooting-wireless-driver-issues
KALI is designed for penetration testers and neither easy to configure nor easy to use!!!
Check your KALI configuration (is wireless-regdom configured).
https://kali.training/lessons/5-configuring-kali-linux/

Please read this:
https://unix.stackexchange.com/questions/399626/why-is-kali-linux-so-hard-to-set-up-why-wont-people-help-me


Controller::$request and $response

This PR sets $request and $response objects on yii\base\Controller, adding support for those objects to be dependency-injected (e.g. with a mock object when testing).

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Tests pass?
✔

@brandonkelly there's #18032 that is more general fix. It's still missing console support (that's why it is not merged yet) but web is fine.

@samdark That PR seems more focused on DI for controller actions; I don’t see anything about request & response in that one. Am I missing something?

Oh, sorry. You're right. It's different.

@xepozz Those changes don’t seem consistent with other DI components in Yii, e.g.
https://github.com/yiisoft/yii2/blob/60a39654dd2d425a24c64d6c1d641a0754b015bc/framework/caching/DbCache.php#L42-L48
https://github.com/yiisoft/yii2/blob/60a39654dd2d425a24c64d6c1d641a0754b015bc/framework/filters/AccessControl.php#L59-L64
https://github.com/yiisoft/yii2/blob/60a39654dd2d425a24c64d6c1d641a0754b015bc/framework/filters/PageCache.php#L69-L75
If their initial values are null, then Instance::ensure() won’t know what to assign them to by default.

w00t!

Thanks!

@samdark , @brandonkelly , we have a problem right after composer update.
Call to a member function validateCsrfToken() on string in yiisoft/yii2/web/Controller.php : 203.
Exactly here $this->request in a string "request"!

@justSinner What’s the stack trace? Yii’s built-in CSRF validation is in beforeAction() which is called after init(), so not a problem there.

@brandonkelly The request is not an object there at all
Stack trace:
2020-06-18 12:42:05 [...][33][ojh39gvi4b5brbqr68bjainrqp][error][yii\base\UnknownPropertyException] yii\base\UnknownPropertyException: Getting unknown property: frontend\controllers\ApiController::request in /.../vendor/yiisoft/yii2/base/Component.php:154
Stack trace:
#0 /.../vendor/yiisoft/yii2/web/Controller.php(203): yii\base\Component->__get('request')
#1 /.../frontend/controllers/ApiController.php(109): yii\web\Controller->beforeAction(Object(yii\base\InlineAction))
#2 /.../vendor/yiisoft/yii2/base/Controller.php(155): frontend\controllers\ApiController->beforeAction(Object(yii\base\InlineAction))
#3 /.../vendor/yiisoft/yii2/base/Module.php(528): yii\base\Controller->runAction('notifications-g...', Array)
#4 /.../vendor/yiisoft/yii2/web/Application.php(103): yii\base\Module->runAction('api/notificatio...', Array)
#5 /.../vendor/yiisoft/yii2/base/Application.php(386): yii\web\Application->handleRequest(Object(common\components\core\Request))
#6 /.../frontend/web/index.php(21): yii\base\Application->run()

Hm, I’m guessing your frontend\controllers\ApiController has an init() method, which is not calling parent::init() like it should.
@samdark do you think I should move the Instance::ensure() calls over to the constructor to work around that? Or just put something in the upgrade notes letting people know that their controllers need to be calling parent::init()?

http://prntscr.com/t23jnr - ApiController extends yii\web\Controller and has no init() method at all.

Actually, looking at your actual error message, it looks like PHP isn’t seeing the new $request property on yii\base\Controller at all. Otherwise yii\web\Controller::beforeAction() wouldn’t be invoking the __get() method (step #0 in your stack trace).
Make sure that those new properties are actually defined on yii\base\Controller for you. If not, maybe something went wrong with the Composer update. Or if they are, maybe OPcache or some other type of caching (sshfs, etc.) could be preventing PHP from seeing the new file.

@justSinner it would likely be helpful to start with a clean basic project template and reproduce it.

I'm sorry, wrong stack trace, a lot of logs...
There is stacktrace for this error:
2020-06-18 14:01:28 [<IP_ADDRESS>][43][fpbvg0s72ul95c4epfsge8nel5][error][Error] Error: Call to a member function validateCsrfToken() on string in /.../vendor/yiisoft/yii2/web/Controller.php:203
Stack trace:
#0 /.../frontend/controllers/BaseController.php(69): yii\web\Controller->beforeAction(Object(yii\base\InlineAction))
#1 /.../vendor/yiisoft/yii2/base/Controller.php(177): frontend\controllers\BaseController->beforeAction(Object(yii\base\InlineAction))
#2 /.../vendor/yiisoft/yii2/base/Module.php(528): yii\base\Controller->runAction('index', Array)
#3 /.../vendor/yiisoft/yii2/web/Application.php(103): yii\base\Module->runAction('site/index', Array)
#4 /.../vendor/yiisoft/yii2/base/Application.php(386): yii\web\Application->handleRequest(Object(common\components\core\Request))
#5 /.../frontend/web/index.php(21): yii\base\Application->run()
#6 {main}

There wasn't init() method in yii\web\Controller previously. We've found, that our BaseController has init() method without parent::init(). Thx for quick reply.

Have you checked if frontend\controllers\BaseController is overriding init() ?

Thanks, figured. So @samdark thoughts on this question? https://github.com/yiisoft/yii2/pull/18083#issuecomment-646020002
We added some logic to Craft’s base web controller’s init() method at one point and there were a couple plugins/modules that were affected by it and needed to add their own parent::init() calls, so I suspect this isn’t the last time we’ll hear about this. So I could either move the code to the constructor (inconsistent with the rest of Yii, but will save some people from errors like this), or just mention in the upgrade notes that they need to make sure they are calling parent::init() (which I think is already the expectation, per https://www.yiiframework.com/doc/guide/2.0/en/concept-components).

I think UPGRADE is better.

PR submitted: #18119

So I ran composer update on July 08, and my application crashed.

Access level to app\modules\v1\controllers\AuthController::$request must be public (as in class yii\rest\Controller)
I changed the access level from protected to public and got the following (attached):

yii-error.log
I don't have an init() method on my controller,
I rely a lot of my application on using the variable $request (on child controller)
And my Controller extends yii\rest\Controller
Solution on my end has been changing the variable $request to something else, but since when $request became a reserved word? Is that the plan? or is this a different issue and I am looking at it the wrong way.

Error line:
https://github.com/yiisoft/yii2/blob/700ac0270644f8c7fe7a52f67ecfe8546ef86f37/framework/di/Instance.php#L126
@jdprime yii\base\Controller and subclasses now expect $request to be an instance of yii\base\Request; and $response to be an instance of yii\base\Response. Sounds like maybe you are setting $request to something else.
There’s a risk of this happening any time a new property is added to a base class. Sorry you got bit by it.

Good to know. Thank you for replying.
However I was setting my $request variable like this $request = Yii::$app->request;  - and reading on the documentation this should have inherited from yii\web\Request - right?  or is Yii::$app->request something else?

The issue probably is that it is set to null from the property definition, but it needs to be set to either a yii\base\Request instance or the ID of a request component (e.g. 'request'); otherwise Instance::ensure() won’t know how to resolve it.
The good news is, it sounds like all you really need to do is remove your own public $request; property – all of the rest of your controller code referencing $this->request will continue to work.

* @since 2.0.36...
$this->request = Instance::ensure($this->request, Request::className());

 * @deprecated since 2.0.14. On PHP >=5.5, use `::class` instead.
public static function className()

🤦♂🙂

@DmLapin yes, that's fine since Yii 2 still works fine on 5.4.

Yii::$app->getResponse() changed to $this->response
and because of it $this->response->redirect is causing error of providing string as url
where Yii::$app->getResponse()->redirect was working just fine
I have tried providing array to $this->response->redirect but still same error

@azzi907 if you believe there is an error here please report a new issue about it with steps to reproduce it.


Added stop headsign

Checklist

[ ] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[ ] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[ ] The description lists all applicable issues this PR seeks to resolve
[ ] The description lists any configuration setting(s) that differ from the default settings
[ ] All tests and CI builds passing

Description
Added stop headsign. The fun I've had with git to get here. Not sure why the tests are failing.

Because this PR would merge unwanted changes in to dev-flex and other changes around stop head sign are need, I'm closing this PR.


Fight Cave Prayer

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
The Fight Cave Jad Fight prayer switch plugin is not on the list of available plugins as of 1.5.3
To Reproduce
Re installed client
Looked for the plugin
Expected behavior
Fight cave prayer plugin to be available
Environment (please complete the following information):

OS: Windows
RuneLite version: 1.5.3
Launcher version:1.6.0

It was removed, read the blog post: https://runelite.net/blog/show/2018-12-06-1.5.3-Release

yeah the removed something useful because to many people wanted to whine about it and think this script is bad even though to me it was super useful for slayer i had my fire cape but i have to go to a public internet source to do it because i live out in the mountains with bad inet this script allowed me to do jad for slayer incase i had lag spikes but not any more....thats why i dont donate to scripts that was the only reason i used runelite lol


Support Swift？

can you write a swift Version？ It is very good ，Best wish

I'm sorry, now don't consider writing.


Document that dask.array.rechunk expects the output shape to match the input shape

It is not documented anywhere that dask.array.rechunk expects the output to have the same shape as the input and does not allow reshaping. The validation step is also quite hidden. This has led to some confusion (https://github.com/dask/distributed/pull/7897#discussion_r1234169191), so I think it would be good to add a remark about this in the documentation.

+1 I was initially confused by this as well

Hello,
I am interested in working on this issue. I have gone through the problem description and would like to contribute by providing the necessary documentation improvements for the dask.array.rechunk function.
Could this issue be assigned to me? I am excited to work on it and believe I can provide a clear and concise update to the documentation.
Thank you!

@fjetter Thank you. I've submitted the pull request and I'm looking forward to any feedback or suggestions you may have.


Refactor Old Code

This pull request contains major refactors for better code quality. Still, it can be improved.

closes #112


Fix typed dict error with uninitialized padding bytes

Fix #6570
The issue was that some data type requires padding bytes to be properly addressable. The alloca in Numba does not fill the initialize the padding bytes and the typed dict implementation key comparison is a simple byte comparison. Since the padding bytes could have garbage data, the key comparison was failing unexpectedly and non-deterministically depending on the values that happen to be in the paddings.

Something in here, guessing the memset, has broken various optimisations.

CI failing because of https://github.com/numba/numba/issues/6590

/azp run


Fixed RA setup of tracked interfaces which should be handled by the s…

…econd foreach loop, not the first one

Whatever PSR style is, but it was probably just like common habit.

Boring details: https://www.php-fig.org/psr/psr-2/
Anyway, merged, thanks!


{Keyvault} az keyvault update-hsm: --secondary-location not supported

Description

Service has not yet implemented multi-region HA for hsm yet. They asked us to disable --secondary-locations temporarily
Testing Guide

az keyvault update-hsm --hsm-name --secondary-locations

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Keyvault


[ EPIC] Add open source related information to "Additional resources" tab

Because of the time crunch of the last milestone we never got round to finding a good home in docs for some of the open-source related information including:

version strategy
operating system support
contributing guidelines + maintainer guidelines
deprecation policy

some of these pages were added to https://docs.quantum.ibm.com/start/install, others were just added as markdown files in the qiskit repo. But the current placement doesn't feel like it exactly "fits" so we should come up with a better place.
Terris also started looking into designs for a "contributing" section of the docs, I think it would be good to re-open this discussion now that things have calmed down a bit
### Tasks
- [ ] #796
- [ ] #716

Just so we don't lose it, mentioning here that another place where the open-source info got placed is on the Support page: https://docs.quantum.ibm.com/support#open-source-governance

related #716

We plan to have a new "Additional resources" section in the top nav bar. Open source will live here. We can use this epic to plan creation of the content for that folder.

Right now the Error Code Registry is under the API reference menu - is it a candidate for "Additional resources"?

Right now the Error Code Registry is under the API reference menu - is it a candidate for "Additional resources"?

We were thinking that stays under API references since it's very API-like, but it could be moved if we want. Migration guides would move, though, since they never really belonged in API reference.

This is now live. The ecosystem documentation is tracked by https://github.com/Qiskit/documentation/issues/1711, and citations / FAQs by https://github.com/Qiskit/documentation/issues/716 and https://github.com/Qiskit/documentation/issues/1699


Common questions - Risk Levels

I think we can add a [!NOTE] that risk detections are continuously improving. Risk level calculations and detection frequency for a particular risk may fluctuate based on these changes. We recommend using risk to inform access decisions, not make decisions. Prefer tight grant and session controls vs 'block' for a risk level to avoid user disruption due to false positives.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 81a1385f-b90a-e7b4-8cbd-f25aeb8b3c49
Version Independent ID: d468eb75-88a9-b1aa-7fb3-19ebb4faa179
Content: What are risks in Microsoft Entra ID Protection - Microsoft Entra ID Protection
Content Source: docs/id-protection/concept-identity-protection-risks.md
Service: entra-id-protection
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@amasse3
Thanks for your feedback! We will investigate and update as appropriate.

@amasse3
Thank you for bringing this to our attention.
I've delegated this to content author @MicrosoftGuyJFlo, who will review it and offer their insightful opinions.

@amasse3 thanks! We are working on multiple docs updates for ID Protection. Passed the feedback to the PG so they can review and we can add it in.
#please-close


Hardfault on STM32 chip

Hi,
I'm did a prototype for a STM32 chip using the ardiuno example as a basis. I have the same LedCommend
// Enum to represent commands and subcommands that can be issued to control LEDs.
// Tripple slash comments are used for generating the help for the CLI.
// Contains two subcommands and their functionality is defined inside on_led()
#[derive(Debug, Command)]
pub enum LedCommand {
    /// Get current LED value
    Get,

    /// Set LED value
    Set {
        /// LED brightness
        value: u8,
    },
}

/// Function to process LED commands, This function is called once the Base CLI detects an LED command.
pub fn on_led<I: embedded_io::Write>(
    cli: &mut CliHandle<'_, Writer<I>, CliError>,
    state: &mut AppState,
    id: u8,
    command: LedCommand,
) -> Result<(), CliError> {
    state.num_commands += 1; // Increment command count for state tracking

    if id as usize >= state.led_brightness.len() {
        uwrite!(cli.writer(), "{}{}{}\n", "LED", id, " not found")?;
        // print command error
        cli_print_error_code(cli, type_name::<LedCommand>(), CliError::CommandError)?;
        return Ok(());
    } else {
        match command {
            LedCommand::Get => {
                uwrite!(
                    cli.writer(),
                    "{}{}{}{}\n",
                    "Current LED",
                    id,
                    " brightness: ",
                    state.led_brightness[id as usize]
                )?;
            }
            LedCommand::Set { value } => {
                state.led_brightness[id as usize] = value;
                uwrite!(
                    cli.writer(),
                    "{}{}{}{}\n",
                    "Setting LED",
                    id,
                    " brightness to ",
                    state.led_brightness[id as usize]
                )?;
            }
        }
    }

But this causes a hardfault, look at the call stack i can this

token.rs:125 - if let Some(pos) = self.tokens.as_bytes().iter().position(|&b| b == 0) {
arguments.rs:108 - let raw = self.tokens.next()?;
cli.rs:365 - let res = handler.process(&mut handle, command);

The CLI com
The interesting thing is, if we clone mainline locally and compile it this hardfault goes away. Want to see if you have any insight into this issue or its an issue fixed already and just need to make a new release.

Hi! That's interesting, can you provide some more info? At what moment does it hard fault? After any input and pressing enter, or some specific input?

Sorry i see the original post the CLI command is cut off, it is led --id 1 set 3. The crash happens when it process CR character.
Another interesting observation to point out is that when I remove value: u8 from the Led Set command. and call led --id set the program doesn't crash anymore.

Can you also include base command (that has id flag) and how you provide bytes to cli instance?
And what buffer sizes do you use?

This is the base command and how we provide the buffer for CLI.
/// Defines CLI Commands and reference to subcommands, args and options.
/// Triplle slash comments above command names are used to define command names
/// and help documentation for the command directly from the comments.
#[derive(Debug, Command)]
pub enum BaseCommand<'a> {
    /// Control LEDs
    Led {
        /// LED id
        #[arg(long)]
        id: u8,

        /// Subcommand for LED control
        #[command(subcommand)]
        command: LedCommand,
    },

    /// Control ADC
    Adc {
        /// ADC id
        #[arg(long)]
        id: u8,

        /// Subcommand for ADC control
        #[command(subcommand)]
        command: AdcCommand<'a>,
    },

    /// Show some status
    Status,
}

--- main loop that feeds data to CLI ---

    // Creating static buffers for command history to avoid using stack memory
    let (command_buffer, history_buffer) = unsafe {
        static mut COMMAND_BUFFER: [u8; CMD_BUFFER_SIZE] = [0; CMD_BUFFER_SIZE];
        static mut HISTORY_BUFFER: [u8; HISTORY_BUFFER_SIZE] = [0; HISTORY_BUFFER_SIZE];
        (COMMAND_BUFFER.as_mut(), HISTORY_BUFFER.as_mut())
    };

    // Setup CLI with command buffer, history buffer, and a writer for output
    let mut cli = CliBuilder::default()
        .writer(writer)
        .command_buffer(command_buffer)
        .history_buffer(history_buffer)
        .build()
        .ok()
        .expect("Failed to build CLI");

    // Setting the CLI prompt
    let _ = cli.set_prompt("main$ ");

    // Global state used throughout the application
    // This is used for the status command and the led simulation command
    let mut state = AppState {
        led_brightness: [0; 4],
        num_commands: 0,
    };

    let _ = cli.write(|writer| {
        // storing big text in progmem
        // for small text it's usually better to use normal &str literals
        uwrite!(
            writer,
            "{}",
            "Cli is running.
        Type \"help\" for a list of commands.
        Use backspace and tab to remove chars and autocomplete.
        Use up and down for history navigation.
        Use left and right to move inside input."
        )?;
        Ok(())
    });

    // Loop continuously processing incoming bytes from UART and executing corresponding CLI commands
    loop {
        freertos_rust::CurrentTask::delay(freertos_rust::Duration::ms(2));

        // Single byte buffer to read one byte at a time
        let mut buffer: [u8; 1] = [0; 1];
        // Single byte buffer to read one byte at a time
        let bytes_read = embedded_io::Read::read(uart_rx, &mut buffer).unwrap();
        defmt::dbg!("cli bytes read: {}", bytes_read);

        let result = cli.process_byte::<BaseCommand<'_>, _>(
            // byte_read,
            buffer[0],
            &mut BaseCommand::processor(|cli, command| match command {
                BaseCommand::Led { id, command } => on_led(cli, &mut state, id, command),
                BaseCommand::Adc { id, command } => on_adc(cli, &mut state, id, command),
                BaseCommand::Status => on_status(cli, &mut state),
            }),
        );
       ...
   }

We've did some testing on which commit after the v0.2.1 fixed the hardfault and the we found the last "utf8 short support" a83b84efa0a6faa062f724e063d9f096974b9197 fixes the hardfault.
Would it be possible to cut a release with the latest commit?

Thanks for the sources, I want to investigate first what was the problem before publishing a release. Can you for now use main branch using patch directive in your Cargo.toml?

Look at the commit a83b84e, I think the chagne from use a [u8] to &str in ArgsIter probably fixed the problem? I don't understand the code enough to understand the root cause yet.
I did do more debugging, and stepped through the code a bit. I tried to look through the logic but haven't determine the root cause for the crash yet. Wanted to share screenshots of the call stack.
CLI command tested: "led --id 1 set 1"
There are 9 calls to the suspect function ArgsIter.next(). In the screenshots we can see the process buffer have the correct ASCII codes.

1st call
2nd call
3rd call
4th call
5th call
6th call
7th call
8th call
9th call
9th call's hardfault line

Thanks for the debug screenshots. From them it actually seems like it's not error in library but somewhere else.
This is because self.tokens is 100% valid byte slice (on last screen we see that it is 1 byte long and starts at 15th position in COMMAND_BUFFER, which is expected. But somehow calling iter().position(..) on this slice causes a hard fault.
Can you provide more details about environment?

What mcu do you use?
What history buffer size?
Do you upload optimized binary or not?
What optimizations are used (size or speed)?

Ideally - upload somewhere whole project that can be flashed to mcu.


Add Installation section to README

As titled, this section should note the minimum required Python version and link to Python downloads before providing a quick guide as to how to set up a venv and install the requirements into it.

Fix typo in Potential Future Work here
Add some colour


feat: add Bun to System apps

Signed-off-by: Engin Diri<EMAIL_ADDRESS>
Description

Adding Bun to System Apps as alternative to Node.js
Motivation and Context

[ ] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

docker container run --rm -v $(pwd):/workspace -ti golang:1.17 bash
root@371d64b6de21:/go# cd /workspace/
root@371d64b6de21:/workspace# go mod tidy && go run .
go: downloading github.com/spf13/cobra v1.5.0
go: downloading github.com/alexellis/go-execute v0.5.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/morikuni/aec v1.0.0
go: downloading github.com/olekukonko/tablewriter v0.0.5
go: downloading github.com/cheggaaa/pb/v3 v3.1.0
go: downloading github.com/Masterminds/semver v1.5.0
go: downloading github.com/otiai10/copy v1.7.0
go: downloading github.com/sethvargo/go-password v0.2.0
go: downloading golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d
go: downloading golang.org/x/mod v0.5.1
go: downloading github.com/VividCortex/ewma v1.2.0
go: downloading github.com/mattn/go-runewidth v0.0.13
go: downloading github.com/fatih/color v1.13.0
go: downloading github.com/mattn/go-colorable v0.1.12
go: downloading github.com/mattn/go-isatty v0.0.14
go: downloading github.com/inconshreveable/mousetrap v1.0.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/rivo/uniseg v0.2.0
go: downloading golang.org/x/sys v0.0.0-20220627191245-f75cf1eec38b
go: downloading github.com/otiai10/mint v1.3.3
            _             _
  __ _ _ __| | ____ _  __| | ___
 / _` | '__| |/ / _` |/ _` |/ _ \
| (_| | |  |   < (_| | (_| |  __/
 \__,_|_|  |_|\_\__,_|\__,_|\___|

Open Source Marketplace For Developer Tools

Usage:
  arkade [flags]
  arkade [command]

Available Commands:
  completion  Output shell completion for the given shell (bash or zsh)
  get         The get command downloads a tool
  help        Help about any command
  info        Find info about a Kubernetes app
  install     Install Kubernetes apps from helm charts or YAML files
  kasten      Sponsored Apps for kasten
  system      System apps
  uninstall   Uninstall apps installed with arkade
  update      Print update instructions
  venafi      Sponsored Apps for Venafi
  version     Print the version

Flags:
  -h, --help   help for arkade

Use "arkade [command] --help" for more information about a command.
root@371d64b6de21:/workspace# ./arkade system install bun
Installing Bun to /usr/local/bin
Installing version: bun-v0.1.8 for: x64
Downloading from: https://github.com/oven-sh/bun/releases/download/bun-v0.1.8/bun-linux-x64.zip
31.66 MiB / 31.66 MiB [-------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00%
Downloaded to: /tmp/bun-linux-x64.zip
Unpacking binaries to: /tmp/bun3489873688
Copying binaries to: /usr/local/bin
root@371d64b6de21:/workspace# bun
bun: a fast bundler, transpiler, JavaScript Runtime and package manager for web software.

  dev       ./a.ts ./b.jsx        Start a bun Dev Server
  bun       ./a.ts ./b.jsx        Bundle dependencies of input files into a .bun

  init                            Start an empty Bun project from a blank template
  create    next ./app            Create a new project from a template (bun c)
  run       test                  Run JavaScript with bun, a package.json script, or a bin
  install                         Install dependencies for a package.json (bun i)
  add       @compiled/react       Add a dependency to package.json (bun a)
  link                            Link an npm package globally
  remove    webpack               Remove a dependency from package.json (bun rm)
  unlink                          Globally unlink an npm package

  upgrade                         Get the latest version of bun
  completions                     Install shell completions for tab-completion
  discord                         Open bun's Discord server
  help                            Print this help menu

Are you a GitHub Sponsor yet (Yes/No?)

[ ] Yes
[x] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[x] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[x] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

[ ] I have tested this on arm, or have added code to prevent deployment

Bun is 🔥 and, if it goes like this soon the alternative to node. I would have it as an alternative to node on system apps level.

Can you try it out as a regular CLI app lease?
I want the system apps to be kept to an absolute minimum due to their maintenance overheads.

Can you try it out as a regular CLI app lease?
I want the system apps to be kept to an absolute minimum due to their maintenance overheads.

I also back this!
It is waaay easier to maintain and refactor regular CLI tools when breaking changes come to the target tool, which is likely to happen with bun since it isn't hit 1.0.0 yet.

HI @alexellis,
np -> https://github.com/alexellis/arkade/pull/735


Sphinx

Codecov Report

Merging #123 into master will increase coverage by 2.42%.
The diff coverage is 72%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   56.51%   58.94%   +2.42%
==========================================
  Files          20       11       -9
  Lines        1665     1174     -491
==========================================
- Hits          941      692     -249
+ Misses        724      482     -242

Impacted Files
Coverage Δ

src/problemgenerator/series.py
92.85% <ø> (ø)
:arrow_up:

src/problemgenerator/radius_generators.py
86.36% <ø> (ø)
:arrow_up:

src/utils.py
35.38% <ø> (-29.24%)
:arrow_down:

src/ml/utils.py
0% <ø> (-57.7%)
:arrow_down:

src/runner_.py
0% <ø> (ø)
:arrow_up:

src/problemgenerator/array.py
81.08% <ø> (ø)
:arrow_up:

src/problemgenerator/node.py
97.22% <ø> (ø)
:arrow_up:

src/plotting/utils.py
25.61% <0%> (ø)
:arrow_up:

src/problemgenerator/utils.py
100% <100%> (ø)
:arrow_up:

src/problemgenerator/filters.py
77.93% <88.23%> (+9.08%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee92af...bb6d0b6. Read the comment docs.


Slider issue on click

When clicking inside the slider (instead of drag and dropping) there is a js error

What I found is that clicking in the slider should add a class to the handle but fails because the reference to the handle (data.handles[0]) is undefined.
As this is using a forked version of nouislider, wrapped in our own React component widget I kind of lost the track of the origing of it. Maybe someone more used to the slider could have a look?

Yes I will issue should be in my nouislider fork I guess

@pixelastic I know it feels weird but we should let opened issues opened until they are part of a release (and they will be auto closed when merged on master). That's ok for this one yes

Oh, ok, I wasn't aware of that.


Update discipline-munit to 1.0.4

Updates org.typelevel:discipline-munit from 1.0.3 to 1.0.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "discipline-munit" } ]

labels: library-update, semver-patch

Codecov Report

Merging #1612 (27a66a6) into master (853f39d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1612   +/-   ##
=======================================
  Coverage   85.08%   85.08%
=======================================
  Files          58       58
  Lines        2219     2219
  Branches      105      105
=======================================
  Hits         1888     1888
  Misses        331      331

Impacted Files
Coverage Δ

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
91.66% <0.00%> (-8.34%)
:arrow_down:

...les/core/shared/src/main/scala/io/circe/Json.scala
79.32% <0.00%> (-0.56%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
85.32% <0.00%> (ø)

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
85.96% <0.00%> (+0.58%)
:arrow_up:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
93.97% <0.00%> (+1.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853f39d...27a66a6. Read the comment docs.


ImageNet 3DCC benchmark

Task Description
We introduce a set of image transformations that can be used as corruptions to evaluate the robustness of models. The primary distinction of the proposed transformations is that, unlike existing approaches such as Common Corruptions [1], the geometry of the scene is incorporated in the transformations – thus leading to corruptions that are more likely to occur in the real world. We apply these corruptions to the ImageNet validation set to create 3D Common Corruptions (ImageNet-3DCC) benchmark. Some examples are shown below.

Dataset Creation
Most of the corruptions require an RGB image and scene depth, except the noise ones that can be generated from RGB image directly. As ImageNet images do not have depth labels, we generate depth predictions using a state-of-the-art depth estimator [2,3]. We described the methods used to generate the corruptions in the main paper and in [3].
Evaluation Metrics
We use the mean Corruption Error as defined in [1]. It is relevant as we also defined five levels of shift intensities for each corruption.
Expected Insights/Relevance
3DCC incorporates 3D information to generate corruptions that are consistent with the scene geometry. This leads to shifts that are more likely to occur in the real world. We expect to gain insights to model vulnerabilities under real-world plausible corruptions that are not captured by 2D corruptions.
Access
Data
Instructions for downloading the entire dataset can be found here. Alternatively, to download individual corruptions, the link is given by https://datasets.epfl.ch/3dcc/imagenet_3dcc/x.tar.gz where x is the name of the corruption i.e. x=[near_focus,far_focus,fog_3d,flash,color_quant,low_light,xy_motion_blur,z_motion_blur,iso_noise,bit_error,h265_abr,h265_crf].
License
Yes, we have the permission to release the images.

[1] Hendrycks et al., Benchmarking Neural Network Robustness to Common Corruptions and Perturbations, ICLR'19.
[2] Eftekhar et al., Omnidata: A scalable pipeline for making multi-task mid-level vision datasets from 3d scans, ICCV'21.
[3] Kar et al., 3d common corruptions and data augmentation, CVPR'22.

Hi, Teresa!
My name is Alexander Panfilov; I am a student research assistant working on supporting the project. I reviewed the PR, and since it requires only tiny fixes, I'd like to offer you that I will fix these issues myself (if you are OK with suggested changes).
What do you think?

Hi Alexander,
Yes, you can go ahead and fix them. The changes looks good. Thanks for offering! :)
Teresa

Hi @kotekjedi, I think you made some changes to this PR. Could you resolve all comments you already addressed, and report what the status on this PR is?

Hi!
This is an automated report for the documentation coverage of your PR. To provide good user experience for the benchmark, we aim to cover most functions with doc strings, using the Google docstring format.
We would greatly appreciate your help in assuring that docstring coverage is sufficiently high for your contribution.
The current coverage is:

Name
Total
Miss
Cover
Cover%

examples/imagenet_3dcc.py
17
15
2
12%

shifthappens/models/torchvision.py
4
0
4
100%

--------------------------------------
---------
--------
---------
----------

TOTAL
21
15
6
28.6%

RESULT: FAILED (minimum: 80.0%, actual: 28.6%)

You can reproduce this result by running
interrogate -v --ignore-nested-functions --ignore-private --ignore-semiprivate --ignore-init-method

on the files you added to your PR.

Hi @stes @kotekjedi  is there anything else needed from our side? @aserety made the requested changes, please let us know if it looks good to you. Thanks!


Rename to "team" or "staff"

Replace "admin" with team/staff

DNS update done: staff.imamopravoznati.org


TouchableNativeFeedback doesn’t render its direct child

Hi,
References aren’t working for the TouchableNativeFeedback direct child. The following snippet demonstrates the issue:
const MyComponent = React.createClass({
  onPress() {
    console.log(this.refs.myView); // undefined!
  },

  render() {
    return (
      <TouchableNativeFeedback onPress={this.onPress}>
        <View ref="myView">
          <Text>Touch me</Text>
        </View>
      </TouchableNativeFeedback>
    );
  }
})

I also provided a minimal reproduction with RNPlay: https://rnplay.org/apps/lJXLPw. The problem happen with React Native v0.29 on Android.

What if you use callback refs?

Not callback refs aren’t called either.

It looks like TouchableNativeFeedback doesn't render the direct child at all: https://github.com/facebook/react-native/blob/65ff8192dd6a542485d1ea0647eadee44d76a55b/Libraries/Components/Touchable/TouchableNativeFeedback.android.js#L208
@mkonicek would you happen to know who authored TouchableNativeFeedback and could explain why not rendering the direct child was necessary (or if it can be changed)? The blame history goes back to the first RN Android commit: https://github.com/facebook/react-native/blame/42eb5464fd8a65ed84b799de5d4dc225349449be/Libraries/Components/Touchable/TouchableNativeFeedback.android.js#L200

is there any progress here? I'm stuck at a use case here.

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


Circular progress in Firefox and Safari

Problem description

Problem lies in the use of stroke-dasharray css property. Will see if I have time too look at fixing this myself at some point.
Versions

Material-UI: v1.0.0-beta3
React: v15.6.1
Browser: Firefox 54.0.1 (64-bit)/Safari Version 10.1.1

It's a duplicate of #5524, if anyone else wonders.


python inference.py but output [ all zeros result]

HI:
after building the env on docker, I run the inference.py with :

img : demo.jpg from mmdetection
config : faster_rcnn_r50_fpn_1x_coco.py
ckg : faster_rcnn_r50_fpn_1x_coco_20200130-047c8118.pth

demo# python inference.py ../image.jpg ../../mmdet/configs/faster_rcnn/faster_rcnn_r50_fpn_1x_coco.py ../faster_rcnn_r50_fpn_1x_coco_20200130-047c8118.pth 1.trt
INFO:root:load model from config:../../mmdet/configs/faster_rcnn/faster_rcnn_r50_fpn_1x_coco.py
INFO:root:model warmup
INFO:root:convert model
Warning: Encountered known unsupported method torch.Tensor.new_zeros
Warning: Encountered known unsupported method torch.Tensor.new_tensor
Warning: Encountered known unsupported method torch.Tensor.new_tensor
Warning: Encountered known unsupported method torch.Tensor.new_zeros
INFO:root:convert take time 44.59940958023071 s
TRTModule()
TRTModule()

however, the output of classification and box is incorrect  as follow
trt_bbox:
tensor([[0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.],
        [0., 0., 0., 0.]], device='cuda:0')
trt_classfication_result:
tensor([-1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1.,
        -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1.,
        -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1.,
        -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1.,
        -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1.,
        -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1.,
        -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1., -1.,
        -1., -1.], device='cuda:0')

The inference.py below ( i did not change anything ):
from mmdet2trt import mmdet2trt
import torch
from argparse import ArgumentParser

from mmdet2trt.apis import inference_detector, init_detector
import cv2,logging

def main():
    parser = ArgumentParser()
    parser.add_argument('img', help='Image file')
    parser.add_argument('config', help='mmdet Config file')
    parser.add_argument('checkpoint', help='mmdet Checkpoint file')
    parser.add_argument('save_path', help='tensorrt model save path')
    parser.add_argument(
        '--device', default='cuda:0', help='Device used for inference')
    parser.add_argument(
        '--score-thr', type=float, default=0.3, help='bbox score threshold')
    parser.add_argument("--fp16", type=bool, default=False, help="enable fp16 inference")
    args = parser.parse_args()

    cfg_path = args.config

    trt_model = mmdet2trt(cfg_path, args.checkpoint,log_level = logging.INFO, fp16_mode=args.fp16, device=args.device)
    print(trt_model)
    torch.save(trt_model.state_dict(), args.save_path)

    trt_model = init_detector(args.save_path)
    print(trt_model)
    image_path = args.img

    result = inference_detector(trt_model, image_path, cfg_path, args.device)
#    print(result)
    num_detections = result[0].item()

    trt_bbox = result[1][0]
    trt_score = result[2][0]
    print('trt_bbox:')
    print(trt_bbox)
    trt_cls = result[3][0]
    print('trt_classfication_result:')
    print(trt_cls)
    image = cv2.imread(image_path)
    input_image_shape = image.shape
    for i in range(num_detections):
        scores = trt_score[i].item()
        classes = int(trt_cls[i].item())
        if scores < args.score_thr:
            continue
        bbox = tuple(trt_bbox[i])
        bbox = tuple(int(v) for v in bbox)

        color = ((classes>>2 &1) *128 + (classes>>5 &1) *128,
                (classes>>1 &1) *128 + (classes>>4 &1) *128,
                (classes>>0 &1) *128 + (classes>>3 &1) *128)
        cv2.rectangle(image, bbox[:2], bbox[2:], color, thickness=5)

    if input_image_shape[0]>1280 or input_image_shape[1]>720:
        scales = min(720/image.shape[0], 1280/image.shape[1])
        image = cv2.resize(image, (0,0), fx=scales, fy=scales)
    cv2.imwrite('image.jpg', image)

if __name__ == '__main__':
    main()

Hi
I have tested on your enviroment in last issue. And the error did exists.
Thanks for the bug report, I will fix it this weekend. Please allow me some time.
By the way, can you share the dockerfile that you used?

Hi
I have tested on your environment in the last issue. And the error did exist.
Thanks for the bug report, I will fix it this weekend. Please allow me some time.
By the way, can you share the dockerfile that you used?

sorry, for the last issue, I run on my local computer with conda instead of docker.

Hi
Guess I have fix the bug.
The error is caused by uncontiguous input tensor. It is a good point to accelerate pytorch, but failed on my repo.
I have update the torch2trt/amirstan_plugin and this repo. please pull the latest repo and try again, see if it works.

cool~, I will try ASAP

Hi
Guess I have fix the bug.
The error is caused by uncontiguous input tensor. It is a good point to accelerate pytorch, but failed on my repo.
I have update the torch2trt/amirstan_plugin and this repo. please pull the latest repo and try again, see if it works.

hi， I pull the lastest repo of amirstan_pluing, torch2trt_dynamic, mmdetection-to-tensort )and rebuild,  reinstall.
But, the output of inference.py is the same as before, all result is zero.
BTW, I use torch1.5.0 and torchvison0.6.0 and there is a bug shown below in delta_xywh_bbox_coder.py
File "/home/cefengxu/pyProjects/grimoire/mmdetection-to-tensorrt/mmdet2trt/core/bbox/coder/delta_xywh_bbox_coder.py", line 34, in delta2bbox_custom_func
    scores = scores.view(1,-1, num_classes)
RuntimeError: view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Use .reshape(...) instead.

so , I change the code  scores.view(1,-1,numclasses) to sores.contiguous().view(1,-1,num_class) to fix this case.

hi
I have tested on pytorch1.5 and 1.6. everything is fine besides the uncontiguous bug you mentioned. (on ubuntu18.04)
As long as you change the pytorch version,could you provide the enviroment detail again?
here is the model I created on 2080ti, please try inference on it.
https://drive.google.com/file/d/16bKyAj4bWgcem6iatMLf6etUJL83Tm_i/view?usp=sharing
And If you are using 2080ti, would you mind share the created engine(1.trt in your case) with me?

hi, compute of the model ( 7.5 )  you support higher than mine ( 6.5 ), so I can not load it for testing.
the model I build from my env as below but I do not 2080ti:
https://drive.google.com/file/d/1hLjhzB-J0aLpbPPgWdQTsx1vH7D374Xl/view?usp=sharing
on the other way, maybe I can debug via IDE. or which info you want to take a look at, I can running the inference.py and print them using my enviroment  for you

Ok, I will check the model you provided later.
Could you check the value and shape of the input tensor in inference.py? It is contiguous?
you can also add return_warp_model to mmdet2trt like below:
    trt_model, torch_model = mmdet2trt(cfg_path, model_path, opt_shape_param=opt_shape_param, fp16_mode=False, max_workspace_size=1<<30, log_level=logging.INFO, return_warp_model=True)
this will give you both tensorrt model and pytorch model(warp of the mmdetection detector).
try return some Intermediate results in forward() of mmdet2trt/models/detectors/two_stage.py   mmdet2trt/models/dense_heads/rpn_head.py   and   mmdet2trt/models/roi_heads/standard_roi_head.py . See if there are large gap between the result of tensorrt model and pytorch model.
for example:
    def forward(self, x):
        model = self.model
        rpn_head = self.rpn_head_warper

        # backbone
        feat = model.extract_feat(x)
        return feat
        rois = rpn_head(feat, x)

        result = self.roi_head_warper(feat, rois)
        return result

force the model return the feature of backbone. Check the return value of both trt_model and torch_model.

@grimoire
i following  your step and  output feat, roi via trt_model and torch_model respectivly.
feat output from each other are the same but roi are different.
my test code as follow :
opt_shape_param=[
    [
        [1,3,320,320], # min shape
        [1,3,1280,1280], # optimize shape
        [1,3,1344,1344], # max shape
    ]
]
max_workspace_size=1<<30 # some module need large workspace, add workspace size when OOM.
trt_model, torch_model = mmdet2trt(cfg_path, weight_path , opt_shape_param=opt_shape_param, fp16_mode=False, max_workspace_size=1<<30, log_level=logging.INFO, return_warp_model=True)
x = torch.ones([1,3,320,320])
x = x.cuda()

y1 = trt_model(x)
y2 = torch_model(x)

output from  trt_model
tensor([[  0.0000,   0.0000, 320.0000,  48.9743],
        [  0.0000,   0.0000, 320.0000,  73.2971],
        [  0.0000,   0.0000, 199.6483,  35.7175],
        ...,
        [  0.0000, 168.7068,  30.9094, 192.4857],
        [  0.0000, 136.8175,  30.7680, 160.5707],
        [307.3548, 235.0510, 320.0000, 277.6660]], device='cuda:0')

output from torch_model
tensor([[  0.0000,   0.0000, 320.0000,  48.9742],
        [  0.0000,   0.0000, 320.0000,  73.2970],
        [  0.0000,   0.0000, 199.6483,  35.7174],
        ...,
        [230.9487,   0.0000, 249.8271,  14.0494],
        [  0.0000, 168.7068,  30.9094, 192.4857],
        [  0.0000, 136.8175,  30.7680, 160.5708]], device='cuda:0',
       grad_fn=<IndexBackward>)

BTW , As mentioned in the previous command ， the feat and roi are no zeros , but throught the  self.roi_head_warper(feat, rois) in forward() on two_stage.py , the result will be  all zero.

Hi.
the different of output of rpn_heads is not a big deal. low score proposals might have different topk and nms result when using tensorrt. I have tested on my side, same result as you.
Seems feature extractor and rpn_head works.
Feed dummy input such as  x = torch.ones([1,3,320,320]) to network will give you zero results. because in mmdetection config file, test_cfg['rcnn']['score_thr']=0.05, any predict with score lower than this will be filtered out( I set the value to zero instead of remove them to make the graph fix).
Try use real image data as input , see if pytorch model and tensorrt model can give you the right predict. Also try output Intermediate results in mmdet2trt/models/roi_heads/standard_roi_head.py see if roi_head works.
And BTW, I can't download the model you provided, could you open the access?

pls, try again.
https://drive.google.com/file/d/1hLjhzB-J0aLpbPPgWdQTsx1vH7D374Xl/view?usp=sharing

i tried returning the torch_model from mmdet2trt()  directly
def mmdet2trt(  config,
                checkpoint,
                device="cuda:0",
                fp16_mode=False,
                max_workspace_size=1<<25,
                opt_shape_param=None,
                log_level = logging.WARN,
                return_warp_model = False):

    device = torch.device(device)

    logging.basicConfig(level=log_level)

    logging.info("load model from config:{}".format(config))
    torch_model = init_detector(config, checkpoint=checkpoint, device=device)

    return  torch_model  # return the torch model init. via mmdet directly

and then using mmdet code belown witch can get the  right predict
result = inference_detector(torch_model, img)
show_result_pyplot(torch_model, img, result, score_thr=0.3)

however, when i use the warp_model from mmdet2trt() and using
result = inference_detector(torch_model, img)
and error output as shown as follow:
INFO:root:convert take time 34.86320662498474 s
Traceback (most recent call last):
  File "/home/cefengxu/pyProjects/grimoire/mmdetection-to-tensorrt/test_mmdet2trt.py", line 27, in <module>
    result = inference_detector(torch_model, img)
  File "/home/cefengxu/cETOOL/mmdetection/mmdet/apis/inference.py", line 86, in inference_detector
    cfg = model.cfg
  File "/home/cefengxu/anaconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 594, in __getattr__
    type(self).__name__, name))
AttributeError: 'TwoStageDetectorWarper' object has no attribute 'cfg'

errr...I mean do inference on warp_model with mmdet2trt.inference_detector(...) , see if the result is zero or not.
The mmdetection model convert to the warp model (a pytorch model with different implementation) first, then convert to tensorrt model. I want to know whether the warp_model works as I expect, and whether the warp_model give the same ( near enough) results as the
tensorrt model.

got the right result using warp_model , using demo.jpg from mmdetection ,  num_detections = 57 , 'chair' and 'car'

Nope, I rarely read it.
As long as the warp_model is OK. Either the input is different or the conversion failed.
Check if the input tensor are the same, try add .contiguous() to the input tensor.
add intermediate result in mmdet2trt/models/roi_heads/standard_roi_head.py , see if there are any gap between warp and tensorrt (with real image data)
for example:

    def forward(self, feat ,proposals):
        zeros = proposals.new_zeros([proposals.shape[0], 1])
        rois = torch.cat([zeros, proposals], dim=1)

        roi_feats = self.bbox_roi_extractor(
            feat[:len(self.bbox_roi_extractor.featmap_strides)], rois)
        return roi_feats   # check the roi_feats
        if self.shared_head is not None:
            roi_feats = self.shared_head(roi_feats)
        # rcnn
        cls_score, bbox_pred = self.bbox_head(roi_feats)

        if isinstance(cls_score, list):
            cls_score = sum(cls_score) / float(len(cls_score))
        scores = F.softmax(cls_score, dim=1)
        bboxes = delta2bbox(proposals, bbox_pred, self.bbox_head.bbox_coder.means,
                    self.bbox_head.bbox_coder.stds)

        num_bboxes = bboxes.shape[0]
        scores = scores.unsqueeze(0)
        bboxes = bboxes.view(1, num_bboxes, -1, 4)
        bboxes_ext = bboxes.new_zeros((1,num_bboxes, 1, 4))
        bboxes = torch.cat([bboxes, bboxes_ext], 2)
        num_detections, det_boxes, det_scores, det_classes = self.rcnn_nms(scores, bboxes, num_bboxes, self.test_cfg.max_per_img)

        return num_detections, det_boxes, det_scores, det_classes

Got it ~!!!
updating code in mmdet2trt.apis.inference_detector,  add .contiguous() to the input tensor
# tensor = data['img'][0].unsqueeze(0).to(device)
tensor = data['img'][0].unsqueeze(0).contiguous()
tensor = tensor.to(device)

and then the  warp_model and trt_model can output the same right predict !
if no add .contiguous() , just  warp_model can output right predict ~!
why ????

Bingo!
Just like what you said.
Pytorch use "stride" to manage the tensor memory(you can access stride by tensor.stride() ), some operation such as permute() don't have to change the real memory block(memory copy might take a lot of time), just need to update stride.
This might cause incontiguous memory. I can feed the memory block to tensorrt, but not the layerout information.
I add bindings[idx] = inputs[i].contiguous().data_ptr() to torch2trt.torch2trt line 387 to fix this, don't know why it doesn't works on your side.

http://blog.ezyang.com/2019/05/pytorch-internals/

errr... i known because  the torch2trt_dynamic updated unsuccessfully,  my  code  is  torch2trt is bindings[idx] = inputs[i].data_ptr() actually.
BTW , how to update the torch2trt_dynamic ? just run the comand below again ??
sudo python setup.py install

Thanks~ at least the inference.py can be running now.


Issue and Pull Request templates

See:

https://github.com/blog/2111-issue-and-pull-request-templates
https://help.github.com/articles/creating-an-issue-template-for-your-repository/
https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/

Example of issue template:
### Subject of the issue
Describe your issue here.

### Your environment
* version of `jquery-validate`
* which browser and its version

### Steps to reproduce
Tell us how to reproduce this issue. Please provide a working demo
in [JSFiddle](https://jsfiddle.net) or [JSBin](https://jsbin.com/).

### Expected behaviour
Tell us what should happen

### Actual behaviour
Tell us what happens instead

Example of PR template:
### Checklist for this pull request

Before you submit a pull request, please make sure you have to following:

* Your code should contain tests relevant for the problem you are solving
* All new and existing tests passed
* Your commits messages format follows the jQuery [git commit message format](http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines)

#### Description
Please describe your pull request.

Thank you!

We should also mention the famouse email problem and how one can handle it / like in the readme

Ha, I don't know how I forgot about this.
I think we need only to link to the notice in README, not replicating it. wdyt ?
By the way, I updated my comment about issue template, please check it.

I think we need only to link to the notice in README, not replicating it. wdyt ?

I am ok with copying the text over instead of only linking. a lot of people are to lazy to follow a link.
I like the templates so far, feel free to PR them

I am ok with copying the text over instead of only linking. a lot of people are to lazy to follow a link.

I agree.

I like the templates so far, feel free to PR them

Will do, but what should I use as component of the commit ? Chore maybe ?

See #1728


NodeJS script does not work on Linux due to Environment Variables not being preserved

It appears that both kdesudo and pkexec don't pass through environment variables, which makes ELECTRON_RUN_AS_NODE=0 not work. This leads to the script trying to launch as a graphical command, which is obviously blocked.

Here is a fork with a working method of passing environment variables through options.env
https://github.com/jafri/sudo-prompt/commit/a066105d54d180eeffdf7b86cb814a0dee811f3a

@jafri I'd like to see this working too for the same reason as you. Do you know if the environment variables are being preserved on other OSes?

You can try the async port at exec-root, it works on Windows and Linux with
{
      env: `ELECTRON_RUN_AS_NODE=0`
    }

@jafri thanks! I'm just curious about how it works on Windows. I haven't seen any mention of options.env on Windows-related code.


option for setting uninstall gif?

I was wondering if it would there would be any appetite (assuming its technically feasible) to specify a different gif for installing and uninstalling?

There is no uninstall GIF - even for large applications, uninstall is very very fast

oh well that side steps an issue then.


Display errors in styled-jsx

If there is an css error, styled-jsx just silently swollen it, which cause very difficult to fix the issue. Anyway to make it explicit?  See examples below
import css from './css.js'
export default () => <div className="pp">
    <style jsx>{css}</style>
</div>)

css.js
export default `
    .pp {
               error error /*intended introduced an error here*/
        background-color: red;
        width: 100px;
        height: 100px;
    }

I had conversation with @giuseppeg in slack, he recon two possible ways:

annotate the css

export default `
  /* @styled-jsx */

 div { color }

always inform when a string didn't pass css validation with a message like
possible invalid css: filename:line

see the scripts below:
g [10 minutes ago]
@ron do you mean if it is invalid css?
g [10 minutes ago]
or rather valid css but with some errors?
ron [9 minutes ago]
I just edited the question :slightly_smiling_face:
ron [9 minutes ago]
invalid css, I mean
g [8 minutes ago]
mm that's kinda hard because the exported literal can be anything .. so when it doesn't pass css validation we just ignore it
ron [7 minutes ago]
I see, thanks. :slightly_smiling_face:
g [7 minutes ago]
we could ask developers that care about that to annotate the css
g [6 minutes ago]
in that case we could display errors
g [6 minutes ago]
eg.
export default `
  /* @styled-jsx */

 div { color }
`

ron [5 minutes ago]
sounds good.
g [5 minutes ago]
another option would be to always inform when a string didn't pass css validation with a message like:
possible invalid css: filename:line

ron [4 minutes ago]
Do you think I should log this issue to styled-jsx github?
ron [4 minutes ago]
Yes, just give any helping hints
g [4 minutes ago]
yea maybe add what I just told you
ron [4 minutes ago]
even just console.log

Just had the same problem! Damn typos.
AFAIK errors are not detected by the transformer, rules are just passed "as is" and included in the build for the browser to handle.
I think the best option would be to try and use stylelint as described here:
https://github.com/zeit/styled-jsx/issues/106
Or wait until a linter plugin is available on stylis:
https://github.com/thysultan/stylis.js/issues/8

in v2 i am going to remove autodetection and force people to tag styles so that there is no magic and it won't fail silently

Fixed by #288


Question: type names.

sorry but why are type names so horrible  ༎ຶ‿༎ຶ

Ah, those are intermediary names to allow you to redefine your own types in the mix. It's a bit complicated, but if you look around you should find something like
when not declared(structwllistener):
  type structwllistener = structwllistener_18485576

So you can use structwllistener without the numbers

Yep Rika over on the discord server told me the same. Thank you!


Make sure that Backward Sync does not run when Snap Sync is happening

Description
It does not make sense to run two different syncs (e.g. snap and backward sync)
We found an issue in 24.1.1 RC1, where we receive a engine_forkChoiceUpdate containing a head block hash that get's reorged. This happened during initial sync, which means that we have not imported this block when we received the engine_newPayload containing that block hash. Eventually we would trigger
backwardSyncContext .syncBackwardsUntil(headHash) (in MergeCoordinator).
PR #6455 fixes this for the initial sync, but there might be other cases where we want to make sure that backward sync is not running, or where we have to kill running backward syncs, e.g. when we are starting a snap sync for some other reason than intial sync.
Acceptance Criteria

Make sure that only one kind of sync can run at a time

implemented via #6545