Tagged Version

We're using your code in an Firefox Extension and their guidelines ask to link to specific tagged version of third party libraries, if you could add a tag for the latest version we'd appreciate it very much, thank you.

Hi, I have made tagged version. Thanks.

Thank you for the quick response. You can find more information about the extension we're developing at https://bittubeapp.com/

Great work. Need some assistance in development, I can offer my services?


[BUG] Cannot save query to a new collection

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When defining a new query and saving it to a new collection, it does not appear to save.  The new collection never appears in the left panel that shows the list of collections and their queries.
Expected Behavior
No response
Steps To Reproduce
Define a new query in a new tab, then click "Add to Collection".  In the modal that appears, specify to add to a new collection and define the new collection's name.  Upon saving it, it never appears in the list of collections in the left panel.
Environment
- OS: MacOS
- Browser: Brave
- Platform:
- Version: 7.2.0

Additional context
No response

This issue should be fixed in v7.2.1. Please can you verify?

Chrome / Brave extension is still showing 7.2.0 in the chrome web store.  I'll test it when it bumps to 7.2.1.

I believe this issue is still present in version 7.2.1.

This is working as expected per testing in 7.2.4.  Thank you!


Update this Repo to use a newer version of firebase

I want to use newer features(FCM) that firebase offers. However I cannot do this if I want to use angularfire2 as well. Since the firebase.initialize can only happen once. Current solution was fork this repo update package.json to use newer firebase repo. Then change my projects dependency to the forked repo. I tried npm-shrinkwrap but that got old fast, since you have to specify every dependency.

@jeremiahgibson91 It's coming in next release. You can use the next tag to try it out npm i angularfire2@next.
Also, you can always initialize another Firebase App, it doesn't just happen once at bootstrap.

It's out!

Thanks!


[5.2] Alias View as ViewContract

Alias View as ViewContract

👍

Is a breaking change to change the type hint.

True dat.


[BUG/FEATURE] - Feedback

Hi Mark,
I took this for a spin on a project recently, thanks for sharing!
Couple of ideas/issues:

In my testing I found it didn't play nicely with a sticky element at the very top of the browser viewport. It would always trigger the x-sticky classes even if I was yet to scroll down the page, perhaps this was just my project though (I was hoping to find the time to setup a minimal test case). FWIW I had a play with both the root margin and threshold settings but I wasn't able to resolve it.

It would be nice to be able to configure some classes that get applied in the non-sticky state (and removed when sticky) and then some classes that are applied when the element is sticky, just so that I don't need to use !important classes to override existing ones.

Hi Matt 👋 Sorry for the delay, this slipped through the net while I've been focusing on HyperUI.
Thanks for the feedback, I'll start looking into the issue you highlighted.
I like the idea of non-sticky state classes, it should be easy enough to add.
I'll keep you updated on the progress.

Hey, @mtwalsh here's PR #3 which adds the functionality, be good to get your thoughts, but no pressure.

@markmead Wanted to test the new version, but there 1.1.1 version on NPM.

Hey, @Lazerproof that's odd... I've re-published 1.1.2.


Shell variable bugs in supervisord.conf

The supervisord.conf files had an incorrect colon in the default for the variable expansion of $CONFIG_PATH. This was most likely due to the adjacent variable $BIND having a default that starts with a colon (:8000). It's also confusing because it looks similar to the alternate ${var:-val} syntax for expanding a variable with a default.
To reduce confusion in the future I changed both variables to use the ${var:-val} syntax which is slightly more robust in this case (it uses the default when the variables is defined as an empty string).

Thank you for submit the patch.


Olive requires an old version of torchmetrics ~= 0.10.0

Proposal Summary
Hello,
Thanks for your great work!
The latest torchmetrics version is 1.2.0. Imposing a version < 1 seems to be a bit limiting, especially when working with latest versions of lightning. What is blocking the update of the requirement?
Best,
Nico
What component(s) does this request affect?

[ ] OliveModels
[ ] OliveSystems
[ ] OliveEvaluator
[ ] Metrics
[ ] Engine
[ ] Passes
[X] Other

Thanks for you suggestion! https://github.com/microsoft/Olive/pull/773 The pr is merged, feel free to have a try.

Sweet, this was fast! Thanks


dependencies version updated to latest version

Thank you for your contribution! However I already updated the web package, so this PR isn't needed anymore.


Unsanitized filenames

Provide environment information
Python 3.11.5 on windows
What OS are you using?
Windows 11
Describe the Bug
When downloading a folder, if any of the filenames in the folder contains an asterisk, gdown attempts to create a tempfile without changing it's base name to remove invalid characters such as /:?<>|
This is the error message
OSError: [Errno 22] Invalid argument: 'C:\Users\....filename.pdfo9gwxp5ltmp'
I'm specifying the tempfile because that's where the error pops up, not sure if the final file would have the same problem.
Expected Behavior
No response
To Reproduce
No response

Another note, google drive allows slashes in file names, meaning by the time the download function receives the output path it is impossible to tell whether that slash is part of a file name or represents a folder, so atleast some part of the sanitization would need to happen in the download_folder file. (The error raised here is related to trying to write to a nonexistant folder)

@OmarAHex Can you give me an example so that I can reproduce?

https://drive.google.com/drive/folders/12cQ4ltgbkBhltqylzSg7g0n7lcTV8zew


SAK-32280: Deleting h1 does not remove it from the page

Thanks @ottenhoff

Yes thanks very much @ottenhoff


Issue about the pointcloud created

Hi, I got a issue about the pointcloud I created after processing register_scene.py.
Here is the model I got:

The rgb data I used in ./JPEGImages are like below:

The whole textures and other things seem reasonable. I guess that is because some planes are caculated wrong when generating the whole point cloud, but I can't tell why exactly. Can you please help me work it out?Will it be possible that I didn't use the colorprint of makers?
My intrinsics.json is as below:
{"fx":<PHONE_NUMBER>9,  "fy":<PHONE_NUMBER>4,  "height": 512, "width": 704,  "ppy":<PHONE_NUMBER>2,  "ppx":<PHONE_NUMBER>4,  "ID": "620201000292", "depth_scale": 0.001}

@hxm1150310617
Hello，I met the same problem. Have you solved it?
你好，我也用的是纸箱来做测试，请问您最终效果如何，方便交流一下吗？


CORS enabling for NYPL image server

I am trying to use the NYPL DIgital Collections API in an Alexa Skill I am building. This skill searches what a user says over the public domain and returns an item image in a card inside the Alexa app. Amazon requires that the server hosting the images should be CORS-enabled. Right now I have trouble displaying the images using the image links provided in the API response. Is the NYPL image server CORS enabled?

Unfortunately, it is not CORS-enabled, and it is unlikely to be changed in the near future.

Hi Kristopher
Thanks for replying so promptly and letting me know. I will probably just
use a link that redirects to the NYPL Digital Collections website on the
Alexa card.
Thanks
Anshika
On Aug 28, 2017 2:35 PM, "Kristopher Kelly"<EMAIL_ADDRESS>wrote:
Unfortunately, it is not CORS-enabled, and it is unlikely to be changed in
the near future.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NYPL-publicdomain/data-and-utilities/issues/9#issuecomment-325440003,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFl8RmQPLyxZAGZUCrpPxisVBPTyqNOoks5scwhogaJpZM4PEWlh
.


Wrong update of markdown file

Since a couple of days ago scala-steward does not update my repositories properly. Instead of updating the version in build.sbt it changes the title of an old PR in the CHANGELOG.md file, as you can see in this PR.

Other examples:

https://github.com/alejandrohdezma/sbt-fix/pull/72
https://github.com/alejandrohdezma/sbt-github/pull/123
https://github.com/47degrees/memeid/pull/171

Thanks for the report @alejandrohdezma! Other PRs that only updated Markdown files are:

https://github.com/tmtsoftware/csw/pull/194
https://github.com/typelevel/cats-tagless/pull/128
https://github.com/RCMartins/blinky/pull/61
https://github.com/erikvanoosten/metrics-scala/pull/241

Scala Steward updates Markdown files since https://github.com/fthomas/scala-steward/pull/1380. Although it works for some repositories, these examples make a good case for not modifying Markdown files by default. I think I'm going to revert #1380.
/cc @erikerlandson

Great! Thank you!
Although that same functionality can be achieved by using mdocVariables from Mdoc like:
//build.sbt

object V {

	//This will be the version updated by scala-steward
	val specs2 = "4.9.1"

}

//This will enable using `@specs2@` variable in your Markdown files
mdocVariables += "specs2" -> V.specs2


Fix Endpoint type for Container.Application capability

Since Simple Profile version 1.1 the tosca.nodes.Container.Application type has a misspelled capability type in the network requirement. There is no EndPoint type in the simple profile, so all the node.yaml files could be considered invalid since the standard states:

Case sensitivity - TOSCA Type URI, Shorthand and Type Qualified names SHALL be treated as case sensitive.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mikhail Shishatskiy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

+1

Thanks Mikhail, not sure how we missed that. Pull request has been merged.
Chris
From: Mikhail Shishatskiy @.>
Sent: Saturday, March 19, 2022 6:07 AM
To: oasis-open/tosca-community-contributions @.>
Cc: Subscribed @.***>
Subject: [oasis-open/tosca-community-contributions] Fix Endpoint type for Container.Application capability (PR #96)
Since Simple Profile version 1.1 the tosca.nodes.Container.Application type has a misspelled capability type in the network requirement. There is no EndPoint type in the simple profile, so all the node.yaml files could be considered invalid since the standardhttps://docs.oasis-open.org/tosca/TOSCA-Simple-Profile-YAML/v1.3/os/TOSCA-Simple-Profile-YAML-v1.3-os.html#_Toc26969464 states:
Case sensitivity - TOSCA Type URI, Shorthand and Type Qualified names SHALL be treated as case sensitive.

You can view, comment on, or merge this pull request online at:
https://github.com/oasis-open/tosca-community-contributions/pull/96
Commit Summary

0456858https://github.com/oasis-open/tosca-community-contributions/pull/96/commits/045685877a2ffd3350eb0e86ace097844b1e4bfe Fix Endpoint type for Container.Application capability

File Changes
(4 fileshttps://github.com/oasis-open/tosca-community-contributions/pull/96/files)

M profiles/org.oasis-open/simple/1.1/node.yamlhttps://github.com/oasis-open/tosca-community-contributions/pull/96/files#diff-2d5b89441621d71f0dc6740a37c63adce0a5e4b751ec5baa140dadf4f85daf0d (2)
M profiles/org.oasis-open/simple/1.2/node.yamlhttps://github.com/oasis-open/tosca-community-contributions/pull/96/files#diff-bf37790f24693276c52d7cda99fe8510b9518b78647c12b89a35d4aa51c58727 (2)
M profiles/org.oasis-open/simple/1.3/node.yamlhttps://github.com/oasis-open/tosca-community-contributions/pull/96/files#diff-5a0338be506b8db25c79336bfc879767480c8c8e438cac6f4db2fffc6d20ee98 (2)
M profiles/org.oasis-open/simple/2.0/node.yamlhttps://github.com/oasis-open/tosca-community-contributions/pull/96/files#diff-c2045382ffea927edaedbf066ef64e56e20e84053d0ee18c51416ad5d44b4ea1 (2)

Patch Links:

https://github.com/oasis-open/tosca-community-contributions/pull/96.patch
https://github.com/oasis-open/tosca-community-contributions/pull/96.diff

—
Reply to this email directly, view it on GitHubhttps://github.com/oasis-open/tosca-community-contributions/pull/96, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASPLIN2T2SCXO6FRKDGPTTVAXGRDANCNFSM5READY7A.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>


doc-gen: migrate scalar functions (crypto) documentation

Which issue does this PR close?

part of #13671.
Rationale for this change

What changes are included in this PR?

As discussed in #13671, this PR will migrate the builtin hashing functions documentation that currently support migration.
Are these changes tested?

Are there any user-facing changes?

Thanks @Chen-Yuan-Lai for working on this
It seems the CI failure can fixed through the following command
- Run # If you encounter an error, run './dev/update_function_docs.sh' and commit
  # If you encounter an error, run './dev/update_function_docs.sh' and commit
  ./dev/update_function_docs.sh

Same as other related PRs.

Thanks @Chen-Yuan-Lai and @Omega359 for the reviews.
By the way, I modified the description close #13671 to part of #13671 because I think there are other remaining PR waiting for reviewing. We shouldn't close #13671 by this PR.


Follow-up of #516 issue

#516  - follow up
hey thanks a lot! it is working now.
@tricknotes but i think you have missed adding initializers directory too.
can you provide an option so that devs can mention which directory they would want to add to ember modules, just in case devs create their own factory type.
Also, how do i add a bower_component into my ember_rails app?
UPDATE
Couldn't reopen, so creating a new issue.

Thanks for mention, @yogiv88

can you provide an option so that devs can mention which directory they would want to add to ember modules, just in case devs create their own factory type.

That's right.
It is already landed however it is not documented yet.
So I updated readme in https://github.com/emberjs/ember-rails/commit/d43a1a11524e935e1ab92ccb832d42ec6791dfea
Please see https://github.com/emberjs/ember-rails#configuration-options .
Now you can add your own module type as the following:
# config/application.rb
config.ember.prefix_dirs << %w(you own module type)

Although having said that I think common module types should be supported by ember-rails such as initializers & instance-initializers.
So there will be landed by https://github.com/emberjs/ember-rails/pull/522

Also, how do i add a bower_component into my ember_rails app?

Are there any use-case?
In short answer, no for now.

thanks a lot @tricknotes.

Also, how do i add a bower_component into my ember_rails app?

Are there any use-case?
In short answer, no for now.

i would want to add socket.io(socket.io-client) for my websocket connection.
it is available as a bower_component, but i am not able to add this in ember-rails.
Can you help me with this, if there is any alternate way?

There are some way for this use-case.

Adding path to bower_component to assets path: assets.path << 'path/to/bower_component'
Copy the file you want to vendor/assets/javascript
Using https://rails-assets.org

You can choice the one of them.


Add stack dumping and performed a few renames

Pull Request Test Coverage Report for Build 637

45 of 49 (91.84%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 99.729%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

source/Cosmos-API-Triggers-Tests/TriggersRESTfulWebServiceTest.class.st
17
21
80.95%

Totals

Change from base Build 635:
-0.08%

Covered Lines:
5146

Relevant Lines:
5160

💛  - Coveralls


How to config mutil email cc , bcc and replyto_mail in this package

How to config mutil email cc , bcc and replyto_mail in this package

@quochieuhcm this is not an issue within this package, you should only open an issue when you find a problem or bug with this package.
Anyway you can use the config file to set all options you need, take look at this sample:
https://github.com/adrianorsouza/codeigniter-phpmailer#sample-mail_configphp
To enable the ability to send cc/bcc you must set mail_setBcc or mail_setCc to true beyond define your email address.


Can't see the scripts being inserted...

So basically, i respond correctly with head, foot and body like:
foot:"<script type="text/javascript" src="/jp/js/p/videos.js" name="videos"></script>↵" head:"<link rel="stylesheet" type="text/css" href="/jp/css/pages/video.css" name="videos" />↵" body: 'something'
I can see the stylesheet being inserted into the head but no matter what i do i can't see into the console the script being inserted aswell. If i view source page, i can see the script being loaded there at the verry bottom after the other scripts.
I tried to put the script into the head, i tried with no name, tried other browsers, tried everything, nothing works.
Why is that?

Anyone please?!


[WW-5080] Defines a new result type plain to use directly with Java code

Implements WW-5080

Coverage increased (+0.08%) to 49.306% when pulling f15d85b496d7723cd8dfbe984ea48ad1363806e9 on WW-5080-plain-result into dbd2f283dad418f0e5856f3c5d7deea0349b10fa on master.

Shouldn't we do something in configs, allowing developer to define this result via struts.xml as well?
Already there is a PlainTextResult, shouldn't we amend it to extend this result?

Shouldn't we do something in configs, allowing developer to define this result via struts.xml as well?

No, this result is a plain code-based-result, you cannot define it in struts.xml and it can only be returned directly from an action. DefaultActionInvocation supports returning results directly from actions for a long time.

Already there is a PlainTextResult, shouldn't we amend it to extend this result?

No, the PlainTextResult result returns content of a file as a plain text. This new result allows output any type of content (text, JSON, html) but you must build it by a hand. That's why I decided to name it a PlainResult and with Java 8 you can use lambdas to construct the output:
    public PlainResult execute() {
        return response -> response.write("ok");
    }

LGTM thanks!


Running smoke test as the very first command fails because the PDK_ROOT dir is created as root:root

When launching it from scratch on a brand new system, the PDK_ROOT dir not created yet, it will be created but as belonging to root:root  event though I'm running openlane as normal user (not even sure how/why ... I'm assuming through some docker magic or something), and then them volare try to do the actual install ... wel it can't write to it as normal user so it fails with a permission error.

Are you using --dockerized, perchance?


[Question] Possible to join over dynamic resources

I use specs as the data store and compute scheduler for a server side simulation and it works great. There's also a front-end that acts as a view of that simluation with communication over websockets. Following the dynamic system data example its definitely possible to get the storages dynamically and cast them to a particular trait, but I would ideally like to join over dynamic storages specified by the query. Does anyone know if this is possible?

This is possible, but it's not too pretty.
You can retrieve resources dynamically, as you mentioned, using dynamic system data. When you want to use any functionality of such storages, you'll have to cast them to a trait somehow.
There is a utility for this in shred, called MetaTable. However, the Join trait is not object-safe, which means you'll have to create your own dynamic wrapper for Join, which then yields its components as some sort of trait object.
So yes, it is technically possible, but it's definitely not very nice.

Thanks for the info! What do you mean by a dynamic wrapper exactly? I understand that Join isn't object safe because it references the Self type, but how does a wrapper circumvent this?


Allow folding html tags with blank new lines

Tracks enabling folding of html in markdown  such as:
<details>

Some text

</details>

This is currently not foldable because it is (correctly) tokenized to two html elements instead of a single html block

This is currently not foldable because it is (correctly) tokenized to two html elements instead of a single html block

Oh, interesting: yeah, it looks like that tokenizer represents the structure with the help of the nesting and level attributes? I do see a single HTML node in the rendered DOM:

Although, this makes me a little suspicious of the token stream:
<details>

<details>

some text

</details>

</details>

does get rendered as I'd expect:

but I can't see a way from the tokens to determine that the second <details> is inside of the first <details> (they both have level/nesting 0).


🔥 Remove Automatically Apply Repository Standards

👀 Purpose

As described in our Projects Sheet in regards to Remove Automatically Apply Repository Standards.

We want to remove, we shouldn't be amending peoples repository settings via a opaque opt-in mechanism. Uptake of the feature is very low.

✅ Definition of Done

[ ] Remove Automatically Apply Repository Standards and any associated code has been removed
[ ] Update User Guide
[ ] Remove KPI from dashboard

Risk

What is the impact on repositories where this automation has been applied.
Do we need to communicate this change to impacted users/teams?

📓 Notes

Burning of bridges complete.


Allow listeners to stop an event's propagation

While working on #126, I realized that it's currently not possible for listeners to stop the propagation of events, so I added it.
In my implementation, a listener can stop propagation by returning false (compared with ===). Tests and doc updates are included in the PR.
Let me know if you have any thoughts about this either way.
Cheers,
Mike

@0x00A Does the bechmarks look good enough to you?

This would be a nice addition.

@elmatou If you're up for fixing the conflicts and testing that it works, I'm down for getting it in. :)


Parse only selected sections in NormalizeSeparators

Closes #116

Codecov Report

Merging #123 (b505aa1) into main (2053b2d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   97.00%   97.08%   +0.07%
==========================================
  Files          24       24
  Lines        1237     1270      +33
==========================================
+ Hits         1200     1233      +33
  Misses         37       37

Impacted Files
Coverage Δ

robotidy/transformers/NormalizeSeparators.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2053b2d...b505aa1. Read the comment docs.


Stressnet

Hey @hundehausen, did you mean to PR this to my repo or to your own?
From what I can tell I definitely don't want to merge this into my main, so I assume it's an accidental PR but please let me know the context here if not!

Hey @sethforprivacy this was a mistake! Thank you for noticing


🐛 Bug Report: Azure build definition fails when multiple builds are in the annotation

📜 Description
When specifying multiple build definitions with the dev.azure.com/build-definition, I'm getting and error message:

Error
400: InputError
Message
Invalid entityRef, not a string

👍 Expected behavior
According to the documentation, the plugin supports multiple build definitions separated by comma. I would expect the plugin to retrieve the builds for all the definitions.
👎 Actual Behavior with Screenshots
Returns an error 400 on the second build definition. The first build definition is retrieved correctly, but it looks like on the request for the second build definition, the entityRef is duplicated:

http://localhost:7007/api/azure-devops/builds/{Org}?definitionName={build-definition}&top=25&entityRef=component%3Adefault%2F{component-name}&entityRef=component%3Adefault%2F{component-name}

👟 Reproduction steps
On cataolg-info.yaml add

dev.azure.com/build-definition: build-definition1,build-definition2.
Navigate to the CI/CD tab for the given component

📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Alright, now that we have this in the right place I wanted to follow up that this has been fixed by https://github.com/backstage/community-plugins/pull/564 and is just pending release. Plan to do that soon, by the end of next week ideally.

I am curious, you found the documentation about this plugin in the Community Plugins repo but you logged the Issue in the main Backstage repo, why did you do that? I'm wondering if maybe we need to update our docs somewhere 🤔

I was looking at the code in https://github.com/backstage/backstage/blob/dbde3fa79fdc7bd57ee456c222b320ee39d871b0/plugins/azure-devops/src/api/AzureDevOpsClient.ts to try to understand where the bug is. This was a miss on my side.

No worries, I hadn't considered that you might have looked up the historical code from when it was in the main repo 👍


Docker image for version 0.9.9

Couldn't find docker image for version 0.9.9.
Latest one seem as 0.9.8 in the docker repository

@derekjn Thank you for the fast response! Also could you fix the latest tag? I didn't want to open a new issue for it. If i remember correctly, it serves 0.9.6 version.

@ayZagen we don't really use the latest tag anymore as it has caused a lot of confusion in the past. We recommend explicitly choosing a version to use.


Circular Relationships analysis

Find circular ancestral relationships

Tarjan's Strongly Connected Components Algorithm looks like a good approach

Doesn't consistently give correct results

Fixed using v3.0.3-SNAPSHOT of gedcom4j.


Crowbar machines list cleanup

moves the call of
crowbar machines list | sort | grep | something
to a function and replaces all usages of crowbar machines list.
This does not save code, but it becomes more readable.

+1

:+1:


Allow sorting grouped table rows and reverting to ungrouped state

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#1064 Sorting has no effect when used with row grouping
Summary:

sorts and column header sorting do not change the order of grouped rows in any way
Once grouped, table rows cannot be ungrouped

What is the new behavior?
Grouping is applied to the sorted internalRows rather than the raw rows input so any changes to sorting can affect the order of groups and of rows within groups.
Setting groupRowsBy to null will remove all row grouping. Care has been taken to allow the ngx-datatable-group-header markup shown in examples to not throw errors when rows are not grouped.
Rows are sorted lazily via accessors, so rapid changes to sorts and groupRowsBy may not incur as much overhead since they now just invalidate the sorted rows. Once sorted and grouped the rows are cached for subsequent access until invalidated.
Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Tables with grouped rows for which sorting should not be allowed will need to set externalSorting to true as rows will now automatically sort in response to user interaction with the column headers. Perhaps someone noticed and wanted this behavior.
Setting the groupRowsBy input to null will immediately remove any information about grouped rows, including anything set by the groupedRows input. Previously, it may have been possible to set both groupedRows and groupRowsBy then remove the latter, retaining the original groupedRows. However, this seems like a strange use case.
Other information:
This addresses the question of how sorting should be handled when rows are grouped in only the most basic fashion. Grouped rows are always derived from the result of sorting the rows according to sorts. Therefore, changing the sort order of columns can change the order of groups since group order is determined by the position of the first row exhibiting that group trait.
A few alternate sort methods when rows are grouped:

Set groupRowsBy = null to disable row grouping when sorting on other columns (this PR makes this possible) so that the sort applies to all rows without groups.
Set externalSorting when sorting on other columns and sort rows with respect to the groups.
Set externalSorting = true and ignore sorting events to disable sorting

Any news about it?

@lautarobock, I had to move away from actual row grouping and just use a custom rowClass and sort to make certain records look like group headings. After working around the inability to sort I was faced with additional features that did not work quite as expected against grouped data. For example, paging applies to the number of groups on the page rather than the number of results and filtering results by a keyword can be extremely latent due to extra layout overhead when groups are enabled (in my case with non-debounced filtering the browser froze for about 800ms between each keystroke).

I've created another PR trying to solve the merge conflicts

hi guys, any news on this PR ?

Any news on this guys?

Any news on this PR ?

Alguma novidade sobre esse PR?

Any solution for this case?


Crash when first line is empty and -L is specified with a one character separator.

Crash when first line is empty and -L is specified with a one character separator.
# File with empty first line.
$ printf '\n1\t2\t3\n4\t5\t6\n'

1       2       3
4       5       6

# Get first 2 columns with regex "\t".
$ printf '\n1\t2\t3\n4\t5\t6\n' | hck -d '\t' -f 1,2 -

1       2
4       5

# Get first 2 columns with regex code using a real TAB character (created by bash).
$ printf '\n1\t2\t3\n4\t5\t6\n' | hck -d $'\t' -f 1,2 -

1       2
4       5

# Get first 2 columns with literal separator option using a real TAB character (created by bash).
$ printf '\n1\t2\t3\n4\t5\t6\n' | hck -L -d $'\t' -f 1,2 -
thread 'main' panicked at 'attempted to index slice up to maximum usize', /software/hck/src/lib/core.rs:528:59
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

# Will print all columns as "\t" is not treated as a regex.
$ printf '\n1\t2\t3\n4\t5\t6\n' | hck -L -d '\t' -f 1,2 -

1       2       3
4       5       6

# With one space as delimiter, we get a crash too when using the literal separator option.
$ printf '\n1\t2\t3\n4\t5\t6\n' | hck -L -d ' ' -f 1,2 -
thread 'main' panicked at 'attempted to index slice up to maximum usize', /software/hck/src/lib/core.rs:528:59
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

# With two spaces as delimiter, it works.
$ printf '\n1\t2\t3\n4\t5\t6\n' | hck -L -d '  ' -f 1,2 -

1       2       3
4       5       6

Something like this probably will fix it.
diff --git a/src/lib/core.rs b/src/lib/core.rs
index dc45f43..476dfdc 100644
--- a/src/lib/core.rs
+++ b/src/lib/core.rs
@@ -520,7 +520,11 @@ where
                     line.push((start, index - 1));
                     start = index + 1;
                 } else if bytes[index] == newline {
-                    line.push((start, index - 1));
+                    if (index != 0) {
+                        line.push((start, index - 1));
+                    } else {
+                        line.push((0, 0));
+                    }
                     let items = self.fields.iter().flat_map(|f| {
                         let slice = line
                             .get(f.low..=min(f.high, line.len().saturating_sub(1)))

Although for performance reasons it might be better to check before the for index in iter loop if the first byte is a newline character, so this condition does not have to be checked in each iteration.

I closed it too soon. v0.6.5 is adding an extra line when there is a blank line at the start.

Okay, see v0.6.5 release which should be building now.

@ghuls also, again, thanks for taking the time to make a detailed issue! You make these really easy to fix 👍


bearssl: init at 0.6 & s6-networking bearssl backend

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117136 at 1f1c0a61 run on aarch64-linux 1

2 packages built successfully:

bearssl
s6-networking (skawarePackages.s6-networking)

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/libraries/bearssl/default.nix:21:3:
   |
21 |   installPhase = ''
   |   ^


More stuff

Add support for on('event', callback), #14 (do we have any other curry functions?)
Changed text to be a function call instead of a bind to allow V8 to inline it.
Removed String and Number support from mount❗ They are now handled entirely within expand, this avoids logic duplication and doing unnecessary work where a text node would be checked for mount, child elements, etc. Feel free to object here, although I didn't think mount(document.body, 'foo') is something someone would want to do 🤔.

Benching REDOM <div> with el()
7686ns per iteration (130107 ops/sec)

Benching REDOM <div> with precached elements
6861ns per iteration (145746 ops/sec)

Starting to wonder where we can remove some code...

Text support is not needed in mount, agreed! ⚡


How to recharge a device?

I can't figure this out, sorry if it's obvious and I can't see it. I hold the device in my right hand (e.g. the scanner) and I press the left controller [A] button, I see the old battery and a new battery I have in my inventory. But I can't click on any of them, I can't figure out how to select it for it to be replaced.

You should be able to use the left joystick to cycle in the menu and then click A on the right controller to swap them.
There is no laserpointer or touch UI for that yet.

Tried just that, doesn't seem to work. I am using Valve Index knuckles. The left controller works correctly for turning, when I have the seaglider at my hand and press the left controller A button it shows a "X" at the left, my depleted battery at the center and a charged battery at the right. I tried pressing the left controller joystick in all directions, nothing happens, nothing is selected and pressing left A again just turns off the battery overlay. Also tried using the right controller joystick or other controls but nothing seems to select the battery to replace. I can send a screenshot if it would get easier to understand.

Will do, thanks. I'm using Linux, maybe that did something different. Nevertheless, will check the bindings.

Oh, you have success running Subnautica on Linux? That's awesome.
For me I got really bad reprojection errors due to a VSync bug and ALVR.
I would love to test and develop on Linux too.
Feel free to reach out on Discord: I'm Okabintaro#4177 on there.

Hey, you were right. The left stick was set only to "work as left stick" and no extra binding. I understand what you said to map joystick left to "left+previous tool" and joystick right to "right+next tool" (I don't recall the wording on the input setup screen) but I though better to map left joystick click to "left+previous tool" and right joystick click to "right+next tool", everything works nice on this configuration and that solved my problem. I was also able to better understand the bindings, e.g. right controller touchpad south as "deconstruct" which was something I wasn't able to do so far.

Glad you got it working 👍🏼


Issue with consecutive mesh.sendBroadcast()

First of all thank you for this code.
I'm running into some issues using the mesh.sendBroadcast() function when trying to send 2 strings through my webSocket. It looks like only one of them is arriving to my js code, for example if I use yerpCb() from the demoToy example shown in easyMesh https://github.com/Coopdis/easyMesh/tree/master/examples/demoToy :
What I added to the c code after line 95 here https://github.com/Coopdis/easyMesh/blob/master/examples/demoToy/demoToy.ino :
String ping("ping"); broadcastWsMessage(ping.c_str(), ping.length(), OPCODE_TEXT); //sendWsControl(); String pong("pong"); broadcastWsMessage(pong.c_str(), pong.length(), OPCODE_TEXT);
When I open my webpage and connect to my device I only get:
ping ping ping
For some reason the pong string is never received. Any idea why ?

no idea i am also confuse...
Why broadcastWsMessage() are not working...


Hiperlinks Fail

Some links are lost, like the "Use the Web API with web resources" and "Blog: Debugging JavaScript code in CRM using browser developer tools"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9bced49b-2382-2334-73fa-aec7cbae904e
Version Independent ID: 664c42e7-0cc3-388b-82ca-a0a4b0d725d7
Content: Use JavaScript with Dynamics 365 Customer Engagement (Developer Guide for Dynamics 365 Customer Engagement (on-premises))
Content Source: ce/customerengagement/on-premises/developer/use-javascript.md
Service: crm-online
GitHub Login: @JimDaly
Microsoft Alias: jdaly

@KumarVivek
Please locate a new Author/Owner for these topics. Also, these topics should really just direct people to the current docs: Apply business logic using client scripting in model-driven apps using JavaScript
@javiercheke : Unless you are working on an on-premises environment, I recommend you use the current docs.

@javiercheke Thanks for the feedback. We have removed the links, that are no longer working. I recommend you to use the current docs: Apply business logic using client scripting in model-driven apps using JavaScript. Closing the issue.


cmorize_obs does not work when installing ESMValTool with conda

Hi,
I find the cmorize_obs program simply does not work. It it my first time to use it, so sorry I made sth silly.
$ cmorize_obs
Traceback (most recent call last):
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 584, in _build_master
    ws.require(__requires__)
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 901, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 792, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (matplotlib 3.2.1 (/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages), Requirement.parse('matplotlib<3'), {'ESMValTool'})

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/projects/NS9252K/conda/esmvaltool/bin/cmorize_obs", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3258, in <module>
    @_call_aside
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3242, in _call_aside
    f(*args, **kwargs)
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3271, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 586, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 599, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/projects/NS9252K/conda/esmvaltool/lib/python3.7/site-packages/pkg_resources/__init__.py", line 787, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'ESMValTool==2.0.0b3' distribution was not found and is required by the application

softeware and system information
$ esmvaltool --version
2.0.0b8

$ python --version
Python 3.7.6

Any suggestions?
Please let me know if you need further information to diagnose this.
Thanks in advance!
Yanchun

You need to actually install esmvaltool in the ESMValTool source via pip install -e .[develop] - you have installed only esmvalcore in development mode, but the cmorization module is part of esmvaltool

Did you follow the installation instructions? As @valeriupredoi suggests, it looks like you may have missed a step somewhere.

Hi @valeriupredoi @bouweandela , thanks a lot for the replies, and sorry for the late response.
Both esmvaltool and ESMValCore are installed by the system admin, so that I don't have permission to install extra package by e.g., pip to the system path.
$ conda list esmval*
# packages in environment at /conda/esmvaltool/2.0.0b3:
#
# Name                    Version                   Build  Channel
esmvalcore                2.0.0b8                    py_0    esmvalgroup
esmvaltool                2.0.0b3                    py_0    esmvalgroup

$ cd /conda/esmvaltool/2.0.0b3/lib/python3.7/site-packages
$ ls esmval*
esmvalcore:
cmor/                 _config.py       __init__.py    _provenance.py     _recipe.py         utils/
config-developer.yml  config-user.yml  _main.py       __pycache__/       recipe_schema.yml  _version.py
config-logging.yml    _data_finder.py  preprocessor/  _recipe_checks.py  _task.py

esmvaltool:
cmorizers/             diag_scripts/  install/            __pycache__/  references/
config-references.yml  __init__.py    interface_scripts/  recipes/      utils/

$ which cmorize_obs
/conda/esmvaltool/2.0.0b3/bin/cmorize_obs

I don't understand what is the development mode, and how to proceed with the pip install for the missing step?

OK I see your sysadmin has installed esmvaltool from conda via the conda install -c conda-forge -c esmvalgroup esmvaltool which is fine; I confirm that currently the package installs fine and the import works fine too but the command line call raises the same traceback as you are reporting. This is because the package is built with matplotlib<3 (2.2.5) and the environment is created with matplotlib>3 (3.2.1). We have two options:

@bouweandela creates a new conda package with restrictions to matplotlib relaxed in the package meta
your sysadmin downgrades matplotlib=3.2.1 to 2.2.5 via conda install -c conda-forge matplotlib=2.2.5

Thanks a lot figuring this out!
I will try to ask our sysadmin to downgrade matplotlib to circumvent this.
And please update me here once you release a new package with fix.

I'll make a new conda package and also try to run the unit tests as part of the package creation, so this doesn't happen again.

Many thanks! @bouweandela

The latest release and conda package (ESMValTool v2.0.0b4) should work, could you ask your system administrator to install it and check if your problem is solved?

@bouweandela Thanks a lot!
Our HPC system is under maintenance this week, so I will ask our sysadmin to upgrade the ESMValTool.
Hopefully it will fix this, and I will update you afterwards.

Hi, we have upgrade ESMValTool to 2.0.0b4, and the cmorize_obs works perfectly now. Thanks again and this issue can be closed.


PLNSRVCE-382: Enhance s2i-java and buildah tasks to support jvm-build…

…-service

removing hacbs-java-builder
adding jvm-build-service proxy
merging steps to avoid quota issues
getting sbom from image dir instead of pushing to oci

Todo:

[x] enhance buildah builder - detect java and set mirror in dockerfile

Regarding the changes to the SBOM generation, it LGTM.


Noticable rendering errors when using a projector texture with an OmniLight.

Tested versions
v4.2.1.stable.official [b09f793f5]
v4.3.dev4.official [df78c0636]
System information
Tested on 2 seperate systems:
Godot v4.2.1.stable - Fedora Linux 39 (KDE Plasma) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 580 Series (RADV POLARIS10) - Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz (8 Threads)
Godot v4.3.dev4 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 Ti with Max-Q Design (NVIDIA; <IP_ADDRESS>52) - AMD Ryzen 7 4800HS with Radeon Graphics (16 Threads)
Issue description

The same thing happens when I use a pure white texture for the projection.
Both Forward+ and Mobile are affected.
MRP Screenshot:

Steps to reproduce

Open the MRP
Open the main.tscn scene if godot doesn't open it on load.
Select the OmniLight node and switch between the two different projector textures provided.
Observe results, using the 8x8 white.png texture results in bigger rendering errors.

Minimal reproduction project (MRP)
projector_bug.zip

I can confirm this on 4.3.dev 40b4130c9 (Linux, GeForce RTX 4090 with NVIDIA 550.78).

This looks like a filtering artifact. It can likely be resolved by dilating the image a bit when copying it to the atlas, or we can contract the UVs used for reading from the atlas a little bit

This looks like a filtering artifact. It can likely be resolved by dilating the image a bit when copying it to the atlas, or we can contract the UVs used for reading from the atlas by 0.5 pixels

I discovered this problem in a project that does not use filtering for decal textures, so that may not be related.

This looks like a filtering artifact. It can likely be resolved by dilating the image a bit when copying it to the atlas, or we can contract the UVs used for reading from the atlas by 0.5 pixels

Indeed it is, when I set the projector filtering to nearest in the project settings the artifacts dissapear.


Testing a Redux-connected component using Enzyme

Enzyme
i) What is the least error-prone way to test a Redux-connected Componet using Enzyme?
I have checked many links and articles but haven't found a satisfactory answer. It's confusing me a lot.
ii)How can I test whether my component is getting certain props or not using Enzyme?
Versions

React-Boilerplate : Current Version
Node/NPM: ^6
Browser: Chrome
Enzyme: Current Version

const wrapper = shallow(<ConnectedComponent />).dive();

and then make your assertions on the wrapped component.

Any update to this? I secondly this very strongly. Everything I have tried does not work.
I set the context like shown in the docs -- http://airbnb.io/enzyme/docs/api/ReactWrapper/setContext.html
This also looked promising
https://stackoverflow.com/questions/37798741/nested-components-testing-with-enzyme-inside-of-react-redux
But usually everything leads me back to:
Invariant Violation: Could not find "store" in either the context or props of "Connect(DatePicker)". Either wrap the root component in a <Provider>, or explicitly pass "store" as a prop to "Connect(DatePicker)".
😢

There's no update needed; wrap your connected component and use .dive().

Two things:

This is not working for me.

const wrapper = shallow(<ConnectedDatePicker />).dive();
I still get the same ole error:
Invariant Violation: Could not find "store" in either the context or props of "Connect(DatePicker)". Either wrap the root component in a <Provider>, or explicitly pass "store" as a prop to "Connect(DatePicker)".

I need to use mount anyways. If I try something like:

const wrapper = shallow(<ConnectedDatePicker store={store}/>).dive();
I get
Method “props” is only meant to be run on a single node. 0 found instead.
when my test tries to use the API method find.  (wrapper.find('#startDate').simulate('focus');)
I am assuming it cannot find it,  because it is trying to find an grandchild element of my DatePicker component.

I'd generally recommend using only shallow as much as possible, and only making assertions on which components your thing renders - in other words, if A renders B which renders C, your A tests shouldn't know anything about C, and should only be asserting that A renders B with the right props. Your B tests should be asserting things about C.

Right. Makes sense. What I am trying to do is more of an integration test.
I am sort of new to making tests. Would this thinking be more correct:
If my DatePicker component has child components that send events up to my DatePicker Component (for example, when a user selects July 21, 2017 a
 is clicked & the event bubbles up and eventually is handled by my DatePicker component's onDateChange function).
For my test, rather than simulating that click event. I should be directly testing my onDateChange function with mock data under various circumstances.
(I apologize if this got off scope a little bit, just trying to understand).

Yes, you definitely should be unit-testing your onDateChange.
It's your date picker component's tests' job to ensure that onDateChange is called at the proper time.

thank you, this has been very helpful

@ljharb Is there any way to mock the inner component? Instead of shallow/dive.

@shakiba Mocks make tests more brittle; but shallow rendering is kind of like automocking. Can you elaborate on what you're trying to achieve?

@ljharb The reason that shallow does not work for me is that there are other nested components which I want to be rendered, such as bootstrap-react layout components.  Basically instead of including specific components in rendering using dive, I want to exclude few components from being rendered. I solved it using jest.mock, but if you have any other idea please let me.

enzyme v3 and React 16 will provide an API for that; short of that, that's probably the best option.

Maybe it will be helpful for someone:
If you want to find if connected component is rendered you can find it by Connect(Component) selector.
Example (StylePicker is connected with the store):
index.js
render() {
        return (

                Choose style


switched to using local storage to store pathways for now

Switched from using graphql calls and mockpathway calls to using local storage + added very basic no pathways page.

also i know that the pathway components now dont show any text, this will be fixed once i push the new pathway components


Add pluginName to  Plugin

A Plugin should know its own name.
If use
ctor.prototype.name = pluginName;

The name is too common , there may be conflict in Plugin. So I used pluginName.

Can you explain why this is necessary? What's the use case?

if ( sprite.pluginName === plugin.pluginName ) {
 // do something
}

No, we still don't see it :(

@ivanpopelyshev  , I real code :
if (sprite.pluginName !== render.currentRenderer.pluginName)
{
      render.currentRenderer.start();
      // ......
}

When I customize PIXI.js , I need this feature. Though , I could add it in my fork version ,
but I think  One named object should know its own name.
Another reason  is  it should know its own name, though never been used.
That's like :

Transform has uploadLocalTransform, though never been used.
FilterManager has shaderCache, though never been used.

I still don't see the utility beyond this very specific use-case.

done with https://github.com/pixijs/pixi.js/commit/dcaf8ffe1f5d1ab02e09dc76fcc5522744f18af9


Force specific config options system-wide

There should be an option to force the window_size to be 3 in the pam module. Otherwise users can reduce security of their account by setting a high window_size.

The same for forcing a step_size, which apparently is also configurable in the user's .google_authenticator file.

This seems like a general issue where I can imagine sysadmins also wanting to force HOTP over TOTP, or the other way around.


Debian 11 Support

Hello, the script looks really great. I would be happy to use it. Unfortunately I can't run it on Debian 11, it references Debian 10. Is support for Debian 11 planned?

define "i can't run on debian 11", i.e. what is your actual problem?

I get the answer from line 39 in the script.
"Your version of Debian (${VERSION_ID}) is not supported. Please use Debian 10 Buster or later"

Could you run the script with bash -x ./wireguard-install.sh?
It should not happen, because the script checks if the version is <10, so >=10 should be supported.

For the record, I just installed wireguard on Debian 11 without a problem
the values for ID and VERSION_ID from my os-release are as follows.
ID=debian
VERSION_ID="11"

If yours are different you might want to check if it is really Debian 11 you have installed.

Install on a virtual private machine with a public internet address then connecting from an android client worked very smoothly for me. On the server:
$ cat /etc/debian_version
11.8


Avivl/issue-38

Implemented reconnection logic with exponential backoff for better resilience.
Replaced deprecated grpc calls

@CodiumAI-Agent /review
auto_approve
--pr_reviewer.extra_instructions="
In the possible issues section, emphasize the following:

Is the code logic efficient?

"
--pr_reviewer.inline_code_comments=true
-i
--pr_reviewer.require_score_review=true
--pr_reviewer.require_can_be_split_review=true
--pr_reviewer.require_soc2_ticket=true
--pr_reviewer.num_code_suggestions="0"

Auto-approval option for PR-Agent is disabled. You can enable it via a configuration file

@CodiumAI-Agent /describe

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review
Redundant DelayThe retry.Delay function is set twice with different values (line 243 and 247). This could lead to confusion or unintended behavior. Consider removing or consolidating these settings.
Error HandlingThe error from grpc.NewClient is not checked before using the conn object (line 282). This might lead to a runtime panic if conn is nil due to an error.


Insights Outlook add-in

Hi
I have trouble with Insights Outlook add-in! Keeps getting the following error message:

It works fine in web-version!
#Outlook #Insights #Windows10 #MyAnalytics
Regards
Robert Eriksson

@robaxm --MyAnalytics doesn't work on older versions of Internet Explorer, please upgrade to Microsoft Edge and try again. I've asked the team to confirm that's the likely problem. If you need faster, more efficient help in troubleshooting your issues with the add-in, please reach out to Microsoft Support. Thanks for your question! I'll add browser support to our MyAnalytics FAQ doc for future reference.

But I don't use Internet Explorer and this is in the Outlook Windows 10 app.

@robaxm --Ok. I'll ask the team what else might be causing your error.

@robaxm --The Insights Outlook Add-In uses Internet Explorer v11, so you need to enable IE11, which is automatically installed as part of Windows 10, and have the applicable privacy settings. For more details, see Browsers used by Office Add-ins.

@robaxm --Hey, I found you also need to confirm you have Enhanced Protection Mode ENABLED in your Internet Explorer 11 settings. Thanks again for asking!

Hi
I managed to solve it myself ! It's was the same issue as presented by you, with Internet Explorer 11 disabled in Windows 10.
Thanks for the help.👍😃


rework pgbackrest

I took a shot at re-working the pgbackrest role to incorporate it into the postgresql role along with the pg_standby role (which was mostly backup related).
The goal here is to be able to merge this now even though we don't have pgbackrest rolled out everywhere.
This should also make it less prone to errors if someone doesn't include the right tags.
I still need to test this.

Tested this locally and looking good. Will do check tests on other envs next week before merging.

ran on enikshay, going to merge now


Issue/details page pt2

Title
Issue/details page pt2
Summary
This updates the styling for the display page. Makes it look snazzy!
Type of change

[x] New feature (non-breaking change which adds functionality)

How To Test
Checklist:

[x] My code follows the style guidelines of this project and has no linting errors
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation, including any applicable ADRs
[x] My changes generate no new warnings
[x] I have added tests that fail without these changes
[x] New and existing tests (unit, integration, accessibility) pass locally
[ ] Documentation updated
[ ] If there are security concerns they are addressed or ticketed after being discussed

super appreciate you doing this! do we want an apply button on the details page?

We do want an apply button


How to include POST actions' object info in swagger's web page

I have a class like the following one that will be submitted to my HTTP-triggered function by POST action:
internal class MyPOCO
{
	public int Id { get; set; }
	public string Name { get; set; }
}

How can it be defined as the open api input parameter like the following example? It simply does not work as I think this kind of parameter definition applies to GET requests.
[OpenApiParameter(name: "name", In = ParameterLocation.Query, Required = true, Type = typeof(MyPOCO), Description = "The **Name** parameter")]

Closing it as I just realized OpenApiRequestBody is meant for this purpose.


Perform retries on azure bulk deletion

This adds retries to the bulk deletion, because if there is a certain chance n that a request fails, the chance that at least one of the requests in a chain of requests fails increases exponentially.
We've had similar issues with the S3 DR tests, which in the end yielded in adding retries at the remote_storage level. Retries at the top level are not sufficient when one remote_storage "operation" is multiple network requests in a trench coat, especially when there is no notion of saving the progress: even if prior deletions had been successful, we'd still need to get a 404 in order to continue the loop and get to the point where we failed in the last iteration. Maybe we'll fail again but before we've even reached it.
Retries at the bottom level avoid this issue because they have the notion of progress and also when one network operation fails, only that operation is retried.
First part of #7931.

multiple network requests in a trench coat

:-D


Introduce credentials command

Refactor secret management to leverage it in this new operation.
Fixes #817.

I would prefer to follow the namespace init command and have the namespace be a required argument like:
riff namespace add-credentials default --secret new-creds ...

I thought about it and concluded that allowing an argument would be ambiguous.
In the case of namespace init, it is clear that the main argument is the namespace.
In the case of namespace add-credentials, the main argument could either be the credentials to add or the target namespace.
Because of the ambiguity, I tried to avoid the problem altogether by not allowing any argument and passing everything as an option.

@trisberg should we allow the equivalent of namespace init's --no-secret? That would allow users to create secrets on their own and bind it to the riff build service account.

Answering other comments here.

how do I see what secrets are installed?
I would say this is kubectl job. If we really want to and choose to move the current logic to riff credentials add/set, then we could have riff credentials list. Should be done in another PR, I think.
how do I remove a secret?
That should be done via a separate issue and another command. This will be easier if we opt for a riff credentials top-level command.
what if there is more than one secret for the same registry?
Hmmm, I do not see the issue with that in the current impl. What am I missing?
why can't I update a secret
We could repurpose the current add-only command.
which secret is used to default the image prefix? How do I change the default?
The one specified when running namespace init. Changing the default means re-running namespace init. We could introduce a separate standalone command, but that may be confusing to users and should be done in another PR, imo.

If we could preserve @badrfoot commit before merging that PR, it would be nice!

Ideas have been folded into #1266


Port new api GC.GetAllocatedBytesForCurrentThread() to CoreRT.

And reenable the tests ActiveIssued for this in System.Runtime.Tests

Now tracked as TFS 451285

ActiveIssue, reopen it, test method: GetAllocatedBytesForCurrentThread
https://github.com/dotnet/corefx/blob/master/src/System.Runtime/tests/System/GCTests.netcoreapp.cs#L16

Already tracked in TFS.


docs: first round of comment correction and extensions

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Took the liberty to change functions that call Stack.pop multiple times to Stack.pop_n

Going to merge this PR as first part of clarification of codebase and integration of comments


Enable ShowDebugMenu on master

master version of the patch for #1108 (which AFAICT is identical; mac-release patch was #1110).

It seems like this patch might re-enable automatic reloading on debug builds, which as I understand it was specifically disabled there, but I'm not sure.


Checking Credentials During Navigation

I'm a bit confused by the documentation in https://marmelab.com/admin-on-rest/Authentication.html#checking-credentials-during-navigation
if (type === AUTH_CHECK) {
    return localStorage.getItem('username') ? Promise.resolve() : Promise.reject();
}

The username item comes out of nowehre. Shouldn't it be localStorage.getItem('token')? If the token item isn't set, that means you haven't logged in (or have logged out).
This is most likely a typo, but I just wanted to check I'm not misunderstanding anything.

Yes, it's a typo. Would you like to open a PR fixing it?


Minor restructuring

Made the function for diagonalizing quadratic Hamiltonians a method of QuadraticHamiltonian, renamed it diagonalizing_bogoliubov_transform, and updated its description.
Moved the function majorana_operator to ops/_fermion_operator.py and exposed it to users.
Minor changes to QuadraticHamiltonian and Slater determinant preparation code.
Edited the description of get_sparse_operator.

Also, do you have any idea why it now says "docs failing?" I sort of assume this is a mistake as they seem to be fine...

Weird, it does not say "docs failing" when I view the GitHub page. Anyway, I noticed some Sphinx warnings and fixed them, perhaps that will resolve the issue.
I put the testing functions in tests/_testing_utils.py.

Try reloading the page with shift, command, R or opening incognito. The reason you likely don't see it is because of caching.

You're right, it says "docs failing" for me now too. Perhaps it's due to the Sphinx warnings that I fix here? If it's not I'll look into it further.
By the way I moved the test functions to utils. To keep it in tests I think we would have to add an __init__.py there to satisfy Python 2.7 and I'm not sure that's appropriate.


[Deprecate] allowCustomStyle/full Container style support from AdaptiveCards

Platform
What platform is your issue or question related to? (Delete other platforms).
Refer to https://github.com/Microsoft/AdaptiveCards/issues/940 and all platforms the feature was added onto and ensure it gets released off of all those platforms.

Android
iOS
JavaScript
UWP

Author or host
Neither. Feature Dev
If you're an author, who are you sending cards to?
Version of SDK
What version are you using? Ex: NuGet 1.0.2, or latest master, etc...
Issue
Subject: allowCustomStyle and card-level style
Hey folks,
In .NET we never implemented the card-level “style” property. Presumably because it was never documented in the schema.
https://adaptivecards.io/explorer/AdaptiveCard.html <- no “style” property there.
As I understand it, this and allowCustomStyle in HostConfig were added for Outlook card authors in order to create an “emphasis” style card without the default padding applied. This caused a bit of fragmentation in our ecosystem given that all host configs except Outlook have allowCustomStyle set to false, meaning the style property would be ignored.
So now as of 1.2 with Bleed, it’s possible to achieve the same visual appearance, by adding a Container as the first element in the body and setting “bleed”: true.
Since this was never documented my vote would be to remove/deprecate the card-level style in the SDKs which it was added in, and we can officially support this appearance using a Container+Bleed and it will work everywhere.
@David Claux does this sound ok to you?

Still open to debate here. @matthidinger / @andrewleader / @dclaux   please add the action items here for follow up in 1.3


Update can-i-use extension

Description

Update the Can I Use package to the latest version

Fix #11401

Update (dev)dependencies

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@thomaslombart I checked the build log... It only fails on the contributor kidonng, cannot find this user
...Invalid contributor "kidonng". Error: Not found (RequestID: da466030-907b-4d2f-9827-6652041a41e9)

The code itself works. Do I need to remove the contributor from package.json?


Map not loading on a flutter web app which loaded from a secure (HTTPS) connection due Mixed Content blocking in Chrome

The web app does not show map when the method MapPickerTemplate.dialogAddressPicker(context: context) is called, but instead show circular progress indicators. When checking the web the console, The request for map images were blocked due to mixed content because the website was loaded from a secure (HTTPS) connection and the call made for map images was through unsecure (HTTP) connection. Upon checking the plugins files I came across this url                       'http://mt1.google.com/vt/lyrs=m@129&x=$x&y=$y&z=$z';,
in the

map_picker.dart

This url is actually causing the issue. And it is a simple fix, the above mentioned url just have to be converted to a secure link exactly like this one 'https://mt1.google.com/vt/lyrs=m@129&x=$x&y=$y&z=$z';
Please try to fix and update the plugin as soon as possible. Thank you

Thanks for the suggestion, I made the correction and uploaded version


Fix jvm_gc_overhead metric name

It seems jvm_gc_overhead_percent was renamed to jvm_gc_overhead.

Thanks, it seems it was fixed here: https://github.com/micrometer-metrics/micrometer/pull/4765/files


Correct documentation for C99 comments

From the 'Microsoft extensions to C and C++' article:

C99 comments are unaffected by /Za and cause no diagnostic at any level.

https://learn.microsoft.com/en-us/cpp/build/reference/microsoft-extensions-to-c-and-cpp?view=msvc-170#single-line-comments

Learn Build status updates of commit 445cda5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/c-language/c-comments.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@corob-msft,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


add pause button

In other words, let the user temporarily view all languages without losing their selected language preferences.

Closed with 9bcab9a648eca5a50be15deb9d5f0fbdc314461d


Update reference-powershell.md

Adding description for the new command:
Disable-AADCloudSyncToolsDirSyncAccidentalDeletionPrevention

@billmath
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

#sign-off


Test

for some reason babel core failed on master branch with export is not defined error.

Ops I meant to open PR on my repo that I forked to build an SSR solid project can someone close it?
Sorry still learning about Git.


Reddy FMC - Make County Optional

Problem statement
Non-USA patient results fail because the Patient Zip is blank or invalid.
One provider was added and two providers had name changes and ReddyFMC didn't notify us, so Provider Info going to LADOH was incomplete.
Acceptance criteria

[x] Results should not fail if the Patient County is blank or invalid.
[x] New Provider: Raveen Coon FNP-C  -  NPI:<PHONE_NUMBER> should be populated correctly in the ORC.12 and OBR.16
[x]  Existing Provider: Wanda Jefferson Wilson FNP-C should now be Wanda Jefferson FNP-C in the ORC.12 and OBR.16
[x]  Existing Provider: De Anna Dark FNP-C should now be DeAnna Dark FNP-C in the ORC.12 and OBR.16

To do

[x] Change the cardinality on patient_county to ZERO_OR_ONE.

Deployed on 12/27/2021.  Closing issue.


Kernel 6.6 and Kernel 6.6.1 or latest release

Describe the bug
I am not exactly sure but everytime I upgrade my kernel through configuration
boot.kernelPackages = pkgs.linuxPackages_latest;
Once succesfully rebooted into new kernel, (verified through uname -r)
My system will hang nor wont respond anymore if I open thunar or any gui file manager (pcmanfm, dolphin) and try to access root file system just by clicking the file system partition.
However, if I have an opened tty, for say I am using a web browser, nor I have a gui file manager opened, I can still use those apps until I close again and it will not relaunch anymore.
So my system will not completely hang.
However, I wont experience this "phenomenon" if I access the root file partition using tty (cd, ls etc) or if I use a tty based file manager like ranger.
I started experiencing this with Kernel 6.6 and now, I am back to latest LTS kernel.
I have experienced this issue on 3 different systems

Laptop with AMD-Nvidia
Desktop with full AMD
mini PC with Intel

Steps To Reproduce
Steps to reproduce the behavior:

Upgrade to latest kernel 6.6 or 6.6.1
Open thunar
Click on the file system or root file system
Launch new apps (any apps) - system will not launch anything

Expected behavior
To be able to just access the root file system without making my system unable to launch anything.
Screenshots
Ill be happy to send a video if not clear above
Additional context
NIL
Notify maintainers
I dont know who to notify

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

system: "x86_64-linux"
host os: Linux 6.1.62, NixOS, 23.11 (Tapir), 23.11pre550515.e4ad989506ec
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.1
channels(root): "nixos"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

It's hard to action this type of issue as we are not kernel developers neither we have an idea of your system.
It would be nice to produce logs from the kernel log, e.g. dmesg and journalctl -b and post them here when such things happen.

Thanks for your reply.
Attached here are dmesgs, journalctl for the last 20 mins
dmesg.txt
dmesg_2.txt
dmesg_3.txt
journalctl.txt


Fix records?.map is not a function bug in XataVectorStores

This pull request fixes a bug in the XataVectorStores module where the records?.map function was throwing an error. The bug was caused by incorrect usage of the records variable. This PR updates the code to destructure the records variable correctly before calling the map function. This ensures that the map function is only called when records is not null or undefined. This fix resolves the bug and improves the stability of the XataVectorStores module.
This was previously attempted to be fixed by the PR #3425
This ultimately fixes issue #3418

This looks like it breaks the method signature?

CC @tsg

I have made this change, as requested by Phillip from Xata team. This is happening as in v 0.27.0 they have changed how vectorSearch method returns records.

In version 0.27.0 we made a breaking change to the search endpoints in @xata.io/client; the shape of the records returned is now nested in an object.
Since we're at 0.x.x, only @xata.io/client versions at0.25.x are valid with the specified peer dependency range of ^0.25.1. Depending on the package manager, the user would see an error or a warning that the dependency is not met, so I'm not sure "Fix records?.map is not a function error" is a bug per se, because when the peer dependency is actually met at 0.25.x the error does not occur.
That being said, we probably want to bump the  @xata.io/client version eventually. I'll let @tsg chime in here. Note that making this code change would also require bumping all @xata.io/client dependencies inside langchain/package.json to ^0.27.0 and modifying any other Xata search calls to handle the new shape.

Ah I see. Yes, we will also need to bump the Xata peer dependency as well then to avoid people on the old versions from experiencing breaking changes.

Thanks everyone, especially @codenameakshay for raising this! I've opened https://github.com/langchain-ai/langchainjs/pull/3553 which includes also the xata client upgrade.
@codenameakshay if you prefer to bring the upgrade in this PR, you basically need to set the new version in package.json, and run yarn install.

Fixed in #3553!


xchtmlreport is not exiting when xcresult file is in NFS server

steev-Mac:rid steev$ xchtmlreport1 -r report/testreport.xcresult
XCTestHTMLReport 2.0.0
nfs server <IP_ADDRESS>:/nfs/raid-data: lockd not responding
nfs server <IP_ADDRESS>:/nfs/raid-data: lockd not responding
nfs server <IP_ADDRESS>:/nfs/raid-data: lockd not responding
in case we are passing xcresult  file  which is present in nfs server
In that case, it's not responding  and not exiting
This is working fine in  System drive data.

Hi
Any idea on this issue is this related to NFS or something else.

I need to make some kind of NFS server. Then will be able to test this. Sorry, but it might take some time to do all this.
I think xchtmlreport is just using standard swift APIs to access files. Maybe problem inside swift library? If that is the case it will not be easy to solve this.
In the short term I would suggest to move the file from the mounted directory to a local directory and then execute xchtmlreport.


How to properly remove dxwrapper

I've removed the 3 required files from the game folder: ddraw.dll, dxwrapper.dll, dxwrapper.ini
Now every time I open the game, it shows this message: Could not find Dxwrapper.dll functions will be disabled!

The game can still start but this message keeps appearing when launching the game.

My apology,
I think I copied an extra file to the game folder: d3d9.dll
And that triggered the message.
I deleted the .dll and it stopped showing the message box.

No problem.  I'll close out the ticket.


Revert "[Token Detection V2] Always pull from dynamic token list"

This reverts commit 6a69849687e15c118f101b4a776c63ebb2e43fdd. (PR: #806)
This is being reverted pending further discussion about how to address the significant resource costs of using a dynamic token list.

Resolved via #836 instead


Learning the different platforms

Different Platforms
We are looking for a platform to create experiences on. There are a lot of different virtual worlds with different tradeoffs.
Web based VR platforms have performance issues but are easier to access. In the future there should be cloud gaming services that help to fix the performance issues.
Altspace
Pros

works on the widest number of VR headsets (and Windows PCs)
good moderator tools for events
Supports large groups (50+)

Cons

not open source

Decentraland
Pros

Open source, permissively licensed
Works in a web browser
Can run our own server

Cons

No VR headset support (yet)
Some performance issues
Requires Metamask, very focused on the marketplace
No audio support (yet) so need to use with Discord/Zoom/whatever

VRChat
Pros

Full time company developing the platform
Developer tools
Memey
Great avatar selection

Cons

Closed source
Doesn't work on some VR headsets, only partial support on others

Mozilla Hubs
Pros

Open source
Can run our own server
Works on basically every device, including phones and VR headsets
Good for streaming content

Cons

We couldn't get it to work in VR in our testing
Performance issues supporting > ~10 ppl in a space, hard limit at ~40

Cryptovoxels
A web based VR world based on Ethereum.
Pros
Cons

This should eventually go in a wiki, but we discuss this each call so I'm going to try to scribe as this topic comes up.


How to reproduce NR_CLOSED error and How to handle the NR_CLOSED error?

Issue

We are using redis node module for Redis client to communicate with Redis server. We are facing NR_CLOSED error intermediately and failing to reproduce the issue. Due to failing in reproducing the issue we could not find mechanism to handle this error.

Also, the status of the redis client from connected and ready is not changing even after facing NR_CLOSED error.

Please advise how to reproduce on NR_CLOSED error and how to handle in client implementation when this error occurs.

Environment

Node.js Version: 8.0.0

Redis Version: 3.0.2

Platform: Node JS

Even I am also facing the same issue. Can some please help we are having production outage because of this

Has this issue resolved?
I am still facing the same issue.

Also having same issue. Redis ping comes back fine, so my health check is giving a false positive.

Did anyone figure this out? We're having the same issue. It's intermittent and started happening in the last 6 months or so


feat(module): Add a new module "secret" for managing a single secret

This Pull Request adds a new module ./modules/secret, which allows to create individual secrets and their versions.
The module is self-contained and could be used directly:
module "secret-manager" {
  source  = "<path-to>//modules/secret"

  project_id  = var.project_id
  name        = "secret-1"
  secret_data = "secret information"
}

The purpose is to have a simple module with a straightforward and well-documented interface (variables).
Here I also updated the examples kms, pubsub and simple to demonstrate the simplicity of managing a single secret using a new module.

To maintainers:
This PR doesn't affect the root module and is safe to merge. But if you are interested, I can submit another PR which updates the root module to use this new ./modules/secret (wrapping it with for_each). That will remove a code duplications between these two modules.  You can see how it might look in this branch: link
But that introduces a breaking change for all existing users of a root module, that's why I didn't include it here.

/gcbrun

From the test:
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1;
        	            	Error: Output "project_number" not found

        	            	The output variable requested could not be found in the state file. If you
        	            	recently added this to your configuration, be sure to run `terraform apply`,
        	            	since the state won't be updated with new output variables until that command
        	            	is run.}
        	Test:       	TestSimpleSecret

@apeabody Oh, I didn't notice that "simple" example module was used in the integration tests.
I updated it now. Could you please re-run the test?

/gcbrun

/gcbrun

# github.com/terraform-google-modules/terraform-google-secretmanager/test/integration/simple [github.com/terraform-google-modules/terraform-google-secretmanager/test/integration/simple.test]
simple/simple_test.go:32:3: projectDescribe declared and not used
simple/simple_test.go:33:17: undefined: proj
FAIL	github.com/terraform-google-modules/terraform-google-secretmanager/test/integration/simple [build failed]

/gcbrun

Thanks @legal90 - My current thought is it would make sense to merge this new module/PR first, and then after the next release entertain a breaking PR to migrate the main module.  The PR does somewhat reduce the test coverage of the main module, but the later PR would basically restore that.
@bharathkkb WDYT?

/gcbrun

/gcbrun

@bharathkkb WDYT?

Thank you for the review, @bharathkkb !
P.s.
Actually, wrapping the module into for_each works fine (as shown here: https://github.com/GoogleCloudPlatform/terraform-google-secret-manager/commit/a11dcee366f276a569cf5f0fbc17696e4d34f6a4#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR48-R65).  tarraform plan in examples/multiple from that branch compiles successfully.
Anyway, I applied the changes which you suggested. Is it good now?

/gcbrun

Thank you for the review, @bharathkkb !
Actually, wrapping the module into for_each works fine (as shown here: a11dcee#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR48-R65). tarraform plan in examples/multiple from that branch compiles successfully.
Anyway, I applied the changes which you suggested. Is it good now?

Thanks @legal90 @bharathkkb! - I plan to do a final review today.

Actually, wrapping the module into for_each works fine (as shown here: a11dcee#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR48-R65). tarraform plan in examples/multiple from that branch compiles successfully.

Ah reverse should be fine! I misread the proposal as we could create a single instance of the root module within this new simple module to create a single secret. Still let's defer this to a future PR due to the migration concern you pointed out.

/gcbrun


Error running tests

Hello everyone!
If I run the tests both from the command line:
make test
And from the Xcode project (scheme MullUnitTests) I get the following error:

: CommandLine Error: Option 'rewrite-map-file' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options
Program ended with exit code: 1

Can you help me running the tests?
Thanks in advance!

Hi @tiagomartinho.
Thank you for reporting this issues, I have hit it recently as well.
For now, you may consider one of these to options:

Switch to an older compiler to compile Mull: anything before AppleClang <IP_ADDRESS>20039 should work.
Ignore failing tests (🙈) and continue using mull-driver, since it's not affected by the issue.

Allright! Thanks a lot @AlexDenisov !

Hi @tiagomartinho, just a follow up: the issue was (partially) fixed, you can now run the tests with any compiler :)

Thanks @AlexDenisov !


hub create fails to set the remote origin to the newly created repository, despite claiming to do so

When I create a repository with git create, hub fails to set the remote origin to the newly created repository, despite claiming to do so.
Is this an error-checking mechanism? Either don’t claim to set remote origin or actually change the origin. It might also be worthwhile to print the old origin URL if applicable.
Example:
$ mkdir test
$ cd test
$ git init
Initialized empty Git repository in C:/Users/arvensis/Documents/projects/test/.git/
$ git create
Updating origin
created repository: 9999years/test
$ git remote -v
origin  https://github.com/whatever/test.git (fetch)
origin  https://github.com/whatever/test.git (push)
$ git remote set-url origin https://example.com/
$ git remote -v
origin  https://example.com/ (fetch)
origin  https://example.com/ (push)
$ git create
9999years/test already exists on github.com
origin  https://example.com/ (fetch)
origin  https://example.com/ (push)
set remote origin: 9999years/test
$ git remote -v
origin  https://example.com/ (fetch)
origin  https://example.com/ (push)

Thank you for reporting. Which hub version do you have?
A more recent version will not overwrite the origin remote if it exists. It would stay at https://example.com, but it will also not print set remote origin: 9999years/test. To me, this is the desired behavior (i.e. not overwriting URLs of existing remotes). What do you think?

It’s good that a newer version doesn’t erroneously print that it’s setting the origin. I think that’s a good default, but I would like an option to overwrite urls; I suppose I could git remote rm origin && git create — but something like git create -f seems slightly more ergonomic.
Anyways:
$ hub version
git version 2.18.0.windows.1
hub version 2.2.9

One of my least favorite things about Git is how difficult working with branches and remotes is; I don’t quite understand why git branch -u origin/master master isn’t the default case since I’m absolutely positive that’s almost every use of Git — all branches track branches from the same name on remote origin; usually there’s even only one branch! But perhaps that’s out of scope here — see #1848.

One of my least favorite things about Git is how difficult working with branches and remotes is

It can be a pain, yes. Out of curiousity, what is your git config push.default setting (if any)?

$ git config push.default
current

Which explains why pushing but not pulling works. Perhaps a pull.default setting is warranted? Maybe something like setting branch.master.remote to origin will cover most of my cases? I’ll update if I learn anything new.

@9999years I think the best setting to learn git with is the default since Git 2.0: simple. https://git-scm.com/docs/git-config#git-config-pushdefault

I just noticed the same error.
I'm moving two projects from GitLab.
For the first one, I created the GitHub repo manually (through the GH website). I then ran git remote add vfonic/the_bestest_project_evah (while I still had origin remote pointing to GitLab). This created a new remote vfonic pointing to GitHub.
I then realized there's hub create command and I ran git create in another repo. This created an empty repo on GitHub and didn't create any remotes (since origin is already pointing to GitLab).
Ideally, there would be -f option, or the CLI might prompt user which remote name to use, when origin is already taken (and not pointing to the same GH "correct" repo.
Since documentation is saying the remote will be created, but nothing happens in this case, at least an error message could be printed to the command line. Something similar to the one when GH remote repo already exists: https://github.com/github/hub/blob/24fefa3dcf4ee4a2589d28366bd2fa3975a8bb0c/commands/create.go#L120
Thanks!


Session storage?

Hi there, any chance that session storage could be added to this library
I think you are based on Localforage, that supports it https://github.com/localForage/localForage-sessionStorageWrapper
Would be helpful for web based Ionic usage as has slighty more secure ways of dealing with removing authorisation credentials on session close, easily.....
Thanks
Alex

I dont really see the value here, you can just use the native localstorage api which is very similar.

Fair enough!


f-fix gwammar uwu

I don't think this needs a good reason as to why I'm closing it

I don't think this needs a good reason as to why I'm closing it

im gonna sue u to death :3


Nix2 on 17.09

Motivation for this change
Wanted to play with Nix 2.0 on 17.09. In case anybody else wants to, just need to add this to your NixOS configuration.nix
{
  nix.package = pkgs.nixStable2;
}

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Partial log (click to expand)
running test tests/fetchGit.sh... [SKIP]
running test tests/fetchMercurial.sh... [SKIP]
running test tests/signing.sh... [PASS]
running test tests/run.sh... [PASS]
running test tests/brotli.sh... [PASS]
running test tests/pure-eval.sh... [PASS]
running test tests/check.sh... [PASS]
All tests succeeded
/nix/store/8bn6hwb4i7qb77mglv627xqwlz01rwql-nix-1.11.16
/nix/store/5srnd5qynsq4af1z95y14cxlb138qmsj-nix-2.0pre5889_c287d731

Success on x86_64-linux (full log)
Partial log (click to expand)
running test tests/fetchGit.sh... [SKIP]
running test tests/fetchMercurial.sh... [SKIP]
running test tests/signing.sh... [PASS]
running test tests/run.sh... [PASS]
running test tests/brotli.sh... [PASS]
running test tests/pure-eval.sh... [PASS]
running test tests/check.sh... [PASS]
All tests succeeded
/nix/store/ny62xjh4jysdnw0pfpk52d1crvrr92vd-nix-1.11.16
/nix/store/n1zz8cx0c1mv7qdm9bfm29p2xmx50h2f-nix-2.0pre5889_c287d731


File/folder selection dialog fails to examine the existence/permission of users' input

We use many file/folder selection dialogs to take user's input to specify various files and directories. For example, to specify a captured image, or an autosave session file.
However, we don't examine if the user's input is valid. Then you can do a number of crazy things:

you can choose a file that you don't have read/write permission.
you can choose a directory that you don't have read/write permission.

Update on 4/24/2018:
The selection dialog doesn't even seem to work in at least one occasion:


Visualize backend error reporting

We report everything currently to intentionally brick calls that have issues. Let's trap and visualise this ok the front end

https://www.webcomponents.org/element/@polymer/iron-ajax/elements/iron-ajax
there appears to be a verbose flag which would be really useful for these backend calls into the console in editor builder


md reference files from plugdata

<3

i put them on the outside i hope that's okay

maybe i'll create a new 'documentation' folder and put this inside with the help files.
you now need to delete 3 objcts and add 4 new ones for the next release :) can you figure it out?

oh lol i forgot to delete lua and canvas.name
wait i thought there was just plaits and beat, what's the other 2?

https://github.com/porres/pd-else/wiki/Developments-currently-in-progress-for-the-next-release

see other changes fromthe changelog that also need to be incorporated into the md files  please

i can try and take of it later on for the next times

canvas.name was also very useful in making sends and receives that are local to subpatch btw ;)

see other changes fromthe changelog that also need to be incorporated into the md files please

yeah i'm not sure whether to try doing those changes to the md files now or wait till we have the final new objects/help files in plugdata
but i'm actually glad you have a list of changes, this makes everything easier <3

do it now :)

yeah i wanna have some fun with them tomorrow :3


[Feature request]: change doorbell tune

Describe the solution you'd like
It would be nice to be able to change the doorbell tune on homebase. My usecase is to change the tune to "silent" during the night.
As of today you can change the volume but you can’t set it to 0.
Thanks for the huge work you’ve done, set the volume to 1 is already a big first solution.

To implement what you ask, i need access to the device. Could you please share your device with me (i need admin rights):

<EMAIL_ADDRESS>(for EU)
<EMAIL_ADDRESS>(for US)

Thanks!

stale