Data not saved after Insert

Whilst attempting to create a test database using version 5 (commit 0eb8940), I add a number of rows using Collection.Insert, yet when I use FindAll(), no documents are returned.
(See #1259 for sample code)
The query is this:-
foreach (var e in col.FindAll())
{
	Debug.WriteLine($"{e.DateTime}");
}

When I create the data, I get a test.litedb file (which is the nominated filename) and a test-log.litedb.
test.litedb is only 8KB, whereas the test-log.litedb is 3,976KB (or larger, depending on how many documents I insert)

To clarify, I'm using the public int Insert(IEnumerable<T> docs) overload of Insert.
Here is the debug log whilst for the insert run:-
1|ENGINE: start initializing
1|CACHE: extending memory usage: (segments: 1 - used: 7.8MB)
1|DISK: creating new database: 'test.litedb'
1|ENGINE: initialization completed
1|CACHE: extending memory usage: (segments: 2 - used: 15.6MB)
1|CACHE: extending memory usage: (segments: 3 - used: 23.4MB)
1|TRANSACTION: commit transaction (2885 pages)
1|DISK: disposing disk writer queue (with 2266 pages in queue)
1|ENGINE: engine disposed

Files after insert:-

Debug output from running FindAll:-
1|ENGINE: start initializing
1|CACHE: extending memory usage: (segments: 1 - used: 7.8MB)
1|ENGINE: initialization completed
1|TRANSACTION: commit transaction (0 pages)
1|ENGINE: engine disposed

Can you paste your code so I can test local here?

To write:-
static void Main(string[] args)
{
	var file = @"test.litedb";

	using (var db = new LiteDatabase(file))
	{
		var col = db.GetCollection<Event>("event");

		var tmp = new List<Event>();

		for (var i = 0; i < 100_000; i++)
		{
			tmp.Add(new Event()
			{
				Data = "the quick brown fox jumps over the lazy dog",
				DateTime = DateTime.Now
			});
		}

		col.Insert(tmp);
	}
}

public class Event
{
	public Guid Id { get; set; }

	public DateTime DateTime { get; set; }

	public string Data { get; set; }
}

To read:-
static void Main(string[] args)
{
	var file = @"test.litedb";

	using (var db = new LiteDatabase(file))
	{
		var col = db.GetCollection<Event>("event");

		foreach (var e in col.FindAll())
		{
			Debug.WriteLine($"{e.DateTime}");
		}
	}
}

So I've just tested using Checkpoint(), and the data is now available when I call FindAll().
Is this expected? I have run other different tests (where I was inserting individual documents) without Checkpoint() and the results were still available via FindAll().

Ok, maybe was fixed when I fix last issue. With or without checkpoint you must can read data

@omfgicbf Were you able to verify it using the latest commits? If it works, could you close the issue?

@JensSchadron unable to re-test per #1270

As of v5 (master 203edef) this issue is no longer occurring.
Data saved via the public int Insert(IEnumerable<T> docs) overload is retrievable irrespective of whether Checkpoint is called.

Here same thing happend. First table with is primary did not insert records but giving Id=1 then when i  am going to insert in second table second table inserted with ref id 1. but in primary table there is no record. after that in second hit all good.
item.CreatedDate = DateTime.Now;
collection.Insert(item);
collection.EnsureIndex(x => x.Id);
collection.EnsureIndex(x => x.ItemName);
collection.EnsureIndex(x => x.ItemCode);
collection.EnsureIndex(x => x.ItemType);
BsonMapper.Global.Entity().DbRef(x => x.Item, "Items");
var itemStock = new ItemStock
{
CreatedDate = DateTime.Now,
Item = item,
Quantity = item.OpeningStock
};
switch (stockType)
{
case StockType.OpeningStock:
itemStock.TransactionType = StockType.OpeningStock;
break;
case StockType.AddStock:
itemStock.TransactionType = StockType.AddStock;
break;
case StockType.ReduceStock:
itemStock.TransactionType = StockType.ReduceStock;
break;
}
        this.ItemStocks.Insert(itemStock);
        this.ItemStocks.EnsureIndex(x => x.Id);
        this.ItemStocks.EnsureIndex(x => x.TransactionType);
        this.ItemStocks.EnsureIndex(x => x.Quantity);
        this.ItemStocks.EnsureIndex(x => x.Item);


[Feature]: Add readiness endpoint /ready and return /health earlier (vLLM on Kubernetes)

🚀 The feature, motivation and pitch
I am running vLLM instances on Kubernetes, as likely are others. Currently there only is the /health endpoint https://github.com/vllm-project/vllm/blob/15aba081f33e6d048422df6dcdb94301d08d13e6/vllm/entrypoints/openai/api_server.py#L88
When defining health checks for workload on Kubernetes there are Liveness and Readiness probes (https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes). While the liveness check determines if a process is still alive (extending on taking only the sheer existence of a process as health indication), the readiness check is used to determine if a pod is ready to receive requests.
The first issue with the health endpoint in the case of vLLM is that it only becomes available and returns HTTP 200 after the API server is started up. If you look at the example in the additional section, this is ~16 seconds after the vLLM was spawned, even without a model download and with a relatively small model only using one small GPU.
A liveness check is hard to configure properly with an unknown time it takes for a service to start providing the corresponding endpoint. If the timeouts are too tights (or the initialDelaySeconds are not high enough) the container will be restarted by the Kubelet. The Kubernetes way of dealing with this is the so called startup probe (https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes). This is a probe that can have different intervals and timeouts and is used to cover the initial startup phase of a process. While this works somewhat, in practice there still are timeouts to define, so worse-cases to consider for vLLM pods to start up and then to move to their next lifecycle phase in which the other checks become active.
My feature request therefore is twofold:

Introduce a /ready endpoint which indicated vLLM is ready for requests. This avoids having any particular timeouts, but allows Kubernetes to natively determine when vLLM is ready. Since this check is then done continuously, vLLM can also indicate at runtime when it's not ready anymore, e.g. in case of full queues or other tasks.

Return the /health as early as possible and don't have it be influenced by a lengthy startup phase (such as larger model downloads, loading tensors into GPUs, ...). This enables Kubernetes to properly determine if vLLM is alive or needs a respawn.

Alternatives
No response
Additional context
INFO 07-02 15:27:33 api_server.py:177] vLLM API server version 0.5.0.post1
INFO 07-02 15:27:33 api_server.py:178] args: Namespace(host=None, port=8000, uvicorn_log_level='info', allow_credentials=False, allowed_origins=['*'], allowed_methods=['*'], allowed_headers=['*'], api_key=None, lora_modules=None, chat_template=None, response_role='assistant', ssl_
/usr/local/lib/python3.10/dist-packages/huggingface_hub/file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.
  warnings.warn(
INFO 07-02 15:27:34 config.py:1197] Casting torch.float32 to torch.float16.
INFO 07-02 15:27:34 config.py:1218] Downcasting torch.float32 to torch.float16.
INFO 07-02 15:27:34 llm_engine.py:161] Initializing an LLM engine (v0.5.0.post1) with config: model='REDACTED', speculative_config=None, tokenizer='REDACTED', skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, rope_scaling=None
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
INFO 07-02 15:27:37 weight_utils.py:218] Using model weights format ['*.safetensors']
INFO 07-02 15:27:41 model_runner.py:160] Loading model weights took 123.4567 GB
INFO 07-02 15:27:42 gpu_executor.py:83] # GPU blocks: 1234, # CPU blocks: 512
INFO 07-02 15:27:43 model_runner.py:889] Capturing the model for CUDA graphs. This may lead to unexpected consequences if the model is not static. To run the model in eager mode, set 'enforce_eager=True' or use '--enforce-eager' in the CLI.
INFO 07-02 15:27:43 model_runner.py:893] CUDA graphs can take additional 1~3 GiB memory per GPU. If you are running out of memory, consider decreasing `gpu_memory_utilization` or enforcing eager mode. You can also reduce the `max_num_seqs` as needed to decrease memory usage.
INFO 07-02 15:27:49 model_runner.py:965] Graph capturing finished in 6 secs.
[...]
INFO:     Started server process [1]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
INFO:     <IP_ADDRESS>:5000 - "GET /health HTTP/1.1" 200 OK

This is a good idea.
Do you have capacity to implement it?

@robertgshaw2-neuralmagic Note that a previous PR for this functionality was rejected, see https://github.com/vllm-project/vllm/pull/1244.
I'm not sure if the goal of api_server is just "demo ware you should fork", as suggested in that PR, or if it should be "simple, but production-ready".

entrypoints/api_server is demoware
entrypoints/openai/api_server is production

In any case, a simple wiring of /health AND /ready also for the demoware doesn't hurt. It does not have to do much in the sense of actually determining some ready state.
Getting to the openai API server:
If we agree that this feature should be implemented somehow, what would be a good sources / starting point to determine vLLM is ready to receive requests? So to follow my initial thoughts, how do I determine if the model is downloaded and loaded / imported into the GPU, KV is setup?
Coming to your question (https://github.com/vllm-project/vllm/issues/6073#issuecomment-2205941456) @robertgshaw2-neuralmagic, I might be able to come up with a PR, but would love some more discussion on the implementation and "quality" of the reported status (be it vLLMs health or readiness). As for health, I'd like to expose as much of a proper health check as possible. Round-tripping a static API endpoint is nice, but does not go much beyond taking the existence of a running process as health check. What about running out of CUDA memory or other issues at runtime? Do they always ultimately cause the process to crash / end itself? Or would some more internal checking help to see if vLLM is actually still alive?

In any case, a simple wiring of /health AND /ready also for the demoware doesn't hurt. It does not have to do much in the sense of actually determining some ready state. But having those "stub" endpoints and handlers implemented, is somewhat of an interface or blueprint for derived implementations to #put some code here#
Getting to the openai API server:
If we agree that this feature should be implemented somehow, what would be a good sources / starting point to determine vLLM is ready to receive requests? So to follow my initial thoughts, how do I determine if the model is downloaded and loaded / imported into the GPU, KV is setup?
Coming to your question (#6073 (comment)) @robertgshaw2-neuralmagic, I might be able to come up with a PR, but would love some more discussion on the implementation and "quality" of the reported status (be it vLLMs health or readiness). As for health, I'd like to expose as much of a proper health check as possible. Round-tripping a static API endpoint is nice, but does not go much beyond taking the existence of a running process as health check. What about running out of CUDA memory or other issues at runtime? Do they always ultimately cause the process to crash / end itself? Or would some more internal checking help to see if vLLM is actually still alive?

Regarding your question "So to follow my initial thoughts, how do I determine if the model is downloaded and loaded / imported into the GPU, KV is setup?", I have tried to used in this PR https://github.com/vllm-project/vllm/pull/7078  the "model_memory_usage" variable in model_runner object to determine the readiness once the model weights are loaded in the GPU memory.

any updates on this? would love to see this go through!


FTickFunction which is used by AActor.PrimaryActorTick and UActorComponent:PrimaryComponentTick is currently a struct as mentioned. This may change in the future to be a class. It was designed to be a struct to avoid an additional C# object from being created per actor/component.
It can be modified by creating a local variable (this is essentially just a pointer):
FTickFunction tick = TickPrimaryComponentTick;
tick.CanEverTick = true;

It may be changed to a class in the future and may also be a pooled class which is returned to the pool once an actor / component is destroyed. This would ensure that there wouldn't be any GC overhead but there would still be the overhead of the cached FTickFunction instance in each AActor / UActorComponent.


✨ Enable to use hosted storage on S3

https://github.com/laminlabs/lamindb-setup/pull/630
https://github.com/laminlabs/lamindb-setup/pull/626

I don't know. I added it to s3://lamindb-ci. Maybe, before, it was silently ignored. Right now, there is a hard error if one can't infer the region.
But it should work according to how the bucket is configured.
I'll figure this one out another time.


Is there any way to set source request ip of Locust

Is your feature request related to a problem? Please describe.

The virtual machine which run locust has multiple network cards
Is there any way to set source request ip of Locust?
Describe the solution you'd like

https://docs.locust.io/en/stable/configuration.html#command-line-options
command-line has parameter to set source request ip?
Describe alternatives you've considered

Additional context

I havent done it myself, but maybe try the solution mentioned here: https://stackoverflow.com/questions/12585317/requests-bind-to-an-ip

Double posted to SO: https://stackoverflow.com/questions/62206926/locust-how-to-set-source-request-ip/62235261#62235261


Parsing for > and such in test output

I have some tests that, when run, produce the following detail lines in the xml:
TestName (TestSuiteName > ParticularTestSuite) failed

These are generated by MATLAB and pushed to GH as-is by this action.
I think that perhaps, before pushing to the GitHub API, it would be nice if the control characters could be unencoded so that the output is prettier.

You are right, such XML entities should get resolved before sending them to the GitHub API. I think this should be done by the used JUnit parsig library junitparser, which in turn uses the Python XML API.
I am looking into how to fix this and where to fix this best.

This is explicitly done by the used junitparser lib, though this design decision is questionable. I have raised https://github.com/weiwei/junitparser/issues/71 to elaborate on this decision. With #185, this "feature" is circumvented so the publish action shows the expected behaviour.
Thanks for raising this.

Wow, well done! You guys don't muck around 😄

Merged into master. Please test with
uses: EnricoMi/publish-unit-test-result-action/composite@master

Looks good, thanks! Is it possible to get an immutable @tag for a release that has this feature, but not master?

You guys don't have a way to tip you a coffee or anything like that in the README.

You guys don't have a way to tip you a coffee or anything like that in the README.

There will be a release soon. I recommend to use tag @v1, which is not immutable but will point to the latest (non-breaking) version. And for the tip: you are welcome, just spread the word and use this action where ever you can.

Just released as v1.24.


Add graphite cli to Nix env

What
Add Graphite to Nix env
How
Added graphite-cli to flake.nix
Breaking Changes
No

Mmm, I'm not sure about putting optional workflow tools in the devshell for these public projects. It makes sense for our monorepo where we're standardizing on internal workflows/process, but public projects feel like they should include just the things necessary for building and running that specific project.

Yeah, I wasn't entirely sure if we should do it. I didn't think it'd hurt a whole lot, but I suppose keeping the criteria for selecting Nix packages makes sense.

Something like this sounds like a way we could pull it off. But perhaps not enough bang for buck here. 🤷🏼


WIP: Move firebase settings to cloud run environmental variables

Fixes #128
TODO:

Implement SED replace regex.
Re-locate UI_CONFIGURATION from API vars to UI vars.

All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[X] Does your submission pass tests?

Hey @mservidio, Even though the 'config.json' example files (cds-demo) are public credentials, from a privacy standpoint, I do not think we should include them in the revision.


How to generate SMPL-XL?

Thanks for your great work!
As you mentioned in https://github.com/openxrlab/xrfeitoria/issues/11#issuecomment-1801441338, I would like to know if the automated script generated to add the garment to SMPL-X will be released.

To be more specifically, I would like to know any plan to release code related to human model creation to generate layered
human models.

Appreciate your interest in generating SMPL-XL (layered human model). This section significantly relies on the license of digital assets for secondary publishing, which in turn influences the design of our proprietary code that is not intended for open-source distribution.
Nevertheless, we are diligently preparing to pick some more 1,000 SMPL-XL models to release soon.

🥳 We are thrilled to announce the release of 1,000+ new SMPL-XL models! You can download them here.
I'm gonna close this issue. Feel free to reopen it.

That is awesome!


CHIANTI and ChiantiPy

This is a very interesting project! Much of my research (coronal loop physics) involves calculating NEI states for impulsively heated loops so I was excited to find another Python project with this same goal.
I noticed that you're storing and maintaining your own set of atomic data. Have you considered using the CHIANTI atomic database via ChiantiPy? (full disclosure: I am one of the maintainers of this project). It is still a bit rough around the edges, but would really benefit from more users, feedback, and contributions!
Do you have any documentation/notebooks/scripts showing how to use SunNEI?

Your research also sounds very interesting as well!  We are very familiar with CHIANTI as that is the database that my collaborator Chengcai Shen has been using for his non-equilibrium ionization calcuations, which have mostly been taking MHD simulations of the solar wind or CMEs (e.g., Shen et al. 2013) and doing a post-processing NEI analysis on them using a Fortran code that he wrote (see Shen et al. 2015) to make predictions about observables.  We ported some of his Fortran code to Python for use by a student who worked on a project last summer.  Chengcai got his atomic data using the CHIANTI IDL interface, so that is what we used to generate the data rather that re-write code with ChiantiPy.  I wasn't able to find any NEI routines within ChiantiPy, and the Python inferface for AtomDB is in a very early stage of development, so we went ahead and wrote our own.  I've learned a lot of Python in the last year, so if I had to do this over I would have taken a more object-oriented approach (inspired by the approach taken by Dedalus) and improved the way data was stored since it's a little clunky.  I have had to focus on different projects lately so I haven't been able to make these improvements, unfortunately.  I'll try to put together some examples/better documentation in the next couple of days.
Just in case I'm missing something...does ChiantiPy have any built-in non-equilibrium ionization modeling capabilities?  If not, would it be within the scope of the project to add NEI capabilities to it?  That would be great functionality to make sure is included.  I personally think ChiantiPy would be a better place to include it rather than a standalone package.  What would you think of the possibility of collaborating and incorporating the functionality of SunNEI and/or your NEI codes into ChiantiPy?

The Shen 2013 paper you attached is very interesting. We're doing some similar work, but with loops in AR cores instead of CMEs. I was also not aware of the Shen 2015 paper. Our group maintains a similar code, the details of which can be found in this paper. I've also implemented a version of this algorithm in Python, using Numba, as a part of another package I am working on. It is not well documented and still needs a bit of work.
Neither the IDL interface to CHIANTI nor ChiantiPy provide NEI routines. However, ChiantiPy does provide the interface to the ionization and recombination data needed for the NEI calculation. So in principle, with a package like sunNEI, you could have the CHIANTI database and ChiantiPy as dependencies rather than maintaining your own set of atomic data. I do like the  idea of having an easy to use NEI solver in Python and I agree with your point about the standalone package versus ChiantiPy. It does seem a bit strange that this calculation has not been standardized in some package since it is a fairly routine thing to do.
While I do think an NEI solver is in the scope of ChiantiPy, right now we are mainly focusing on fixing and maintaining the features we already have. That being said, I think this should be on the roadmap of things to implement in the future...
Either way, I would be interested in pooling our efforts to create a common NEI solver in Python, perhaps using something like Numba or Cython for speed and ChiantiPy for the data. There's just the question of where this code would live.


Merge rustc into rmc - 2021 week 38 (#501)

Description of changes:
Weekly synchronization between RMC and its upstream rustc repo. The last commit is for implementing ShallowBoxInit which was recently introduced to rustc.
Resolved issues:
Resolves #501 and #528
Call-outs:
Since this is a merge PR, please do not merge squash it. Once it is approved I'll push it via command line.
Testing:

How is this change tested?
Regression

Is this a refactor change?
No

Checklist

[ ] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[ ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Please ignore the format-check since this is checking for copyright header on rustc files.
Please review https://github.com/model-checking/rmc/pull/530/commits/fdd9d9e92970c6e1d13cfc056ed6cc9e2a35eaaf

LGTM modulo our discussion about documentation


Structure of the README does not align with RAMP Standard

There is no LICENSE file at the root of the repo. Please add an Apache-2.0 licence and add your company name to the copyright in the file.
Amend the license badge to point to your license

e.g.
[![License: Apache](https://img.shields.io/github/license/itti-pl/depalletization-agent-rose-ap.svg)](https://www.apache.org/licenses/LICENSE-2.0.html#redistribution)

Ensure that the final section of the README explicitly repeats the information as shown:

## License

[Apache2.0](LICENSE) © 2021 <Company Name>

You can follow the example here

Register on read the docs and re-add the mkdocs.yml and .readthedocs.yml files to generate the documentation. More info here:

Sample files: .readthedocs.yml,  mkdocs.yml
The documentation badge can then be re-added:
[![Documentation Status](https://readthedocs.org/projects/****/badge/?version=latest)](https://****.readthedocs.io/en/latest/?badge=latest)

where **** is the name of your readthedocs project.

License file added. License section/footer added. Readthedocks ready. Thx.

You could add a link to https://depalletization-agent-rose-ap.readthedocs.io/ in the info box here as well:


Take Advantage of Google's Go-To Actions (for Gmail and Inbox)

By adding the code snippet below to HTML-formatted emails, users can see a "View Ticket" link in their inbox, without even having to open the email.  Also include snippets for "View PM", "Reset password", and "Verify email"
<script type="application/ld+json">
{
  "@context": "http://schema.org",
  "@type": "EmailMessage",
  "description": "ViewTicket",
  "action": {
    "@type": "ViewAction",
    "url": "%%TICKET_URL%%",
    "name": "View Ticket"
  }
}
</script>

Unable to do this due to Google's restrictions.


Multiple, rapid submits causes multiple drafts and data does get recorded in the database

We encountered a situation this morning with our first Pilot Study participant. The "start here" form (aka pre-screener) is not allowing us to submit this first person's information. We think it's because he got a little click happy and hit the submit multiple times. His applicant ID is 209514 and we are stuck on the review page. Other's have tested the start here form back in the office and it's working for them. This may be a one-off, but we would like to know what caused it so that we can either fix it or prevent it from happening again in the future.
The applicant was logged into Login.gov and we were testing on a Mac in Chrome. He was having trouble with the mousepad and accidentally highlighted multiple items on the page. The highlights were in blue and covered the blue submit button so he couldn't tell that he had clicked it. Consequently he clicked it multiple times. We logged him out of the Mac and moved to a PC. He logged into Login.gov again on the PC and he was returned to this page, https://myarciviform.arkansas.gov/applicants/209514/programs/377/review, with all of his data still apparently cached somehow. However, there is no entry in the admin for this program for this applicant and we still could not submit his form data.
Would it be possible to add have some visual indication for the user to show that they have successfully clicked the submit button? IBM uses a blue, revolving circle to indicate that the page is loading (see attachment).
I've attached a screen capture of the logs, the error message that appeared on the page when this occurred, and a screenshot of the IBM swirling, page load icon.

Leslie Taylor, State of Arkansas, ARData

I've since logged him out of Civiform on my PC, so we're not able to get back to the review page with his cached data.


Improved_README.md

Hey there!!!
I Improved some Grammer errors in README.md.
Thank you!
Check it out.

Checklist

[ ] You have read the Contribution Guidlines before creating this PR.
[ ] You created a branch from dev branch
[ ] Blog follows Blog Guidelines.
[ ] Checked for all grammatical errors in the blog.
[ ] Checked for any duplicate blog entry.
[ ] You PR is raised on dev branch and not onmaster.

Description of change

Author Details for Blog Post Entry

These are some new line changes which are not really required. Sorry, but I will have to close this PR.


Version 5.8.0 release

Changed

Added support for version v2.1-<IP_ADDRESS> of the DocuSign ESignature API.
Updated the SDK release version.

AppVeyor build and test pass.

AppVeyor build and test pass.


Malformed formKey string

Started Getting this when I tried it. I wouldn't know where to start, but I know its not working.
error.txt

User Error

Synth's code has been improved to handle this a bit better, too, but hasn't been released with the new code included yet


No way to configure cassandra schema and table in docs

The only configuration step for cassandra according to docs is running tools/heroic-shell -P cassandra -X cassandra.seeds= -X cassandra.configure, but it fails with "Keyspace heroic does not exist".
It works only after importing keyspace.cql and tables.cql manually.

Potential bug in the autoconfiguration code, will investigate.

Confirm I had the same problem.

This seems to have been a documentation mistake. The name of the switch is -X datastax.configure, or alternatively just -X configure.
This has been fixed in the documentation for getting started.

Confirm that 9aa9e28 fixed the problem!  Thanks so much, @udoprog!


18821341  dropdown hidden behind soft keyboard IOS

Task

Modal redesign
Create a ticket > Customer dropdown is not behaving properly

DO NOT MERGE until this has been tested integrated into deskclient https://github.com/Teamwork/deskclient/pull/5307  and package version has been bumped to non beta
Description
This PR fixes some issues with the dropdown area being hidden behind the software keyboard and not accessible, especially in IOS safari.
More info about the problem here:

https://blog.opendigerati.com/the-eccentric-ways-of-ios-safari-with-the-keyboard-b5aa3f34228d
https://developpaper.com/ios-keyboard-puzzle-and-visual-view-port-api/

Other features:

Adds a close button when the dropdown is full screen so user can close easily
Can pass a class when initialising the dropdown on which touch scrolling gets prevented. this is to solve issues when the dropdown is opened and the user scrolls the page.

Implementation details.
To fix this issue an interval is created while the dropdown is opened (only while it is opened) to listen to some changes in the visualViewport,  scrollPosition and page height, IOS does not have any event listeners for some of these properties so we need to use an interval.
Before
https://user-images.githubusercontent.com/2648215/154648804-c6237102-30b9-4faf-a522-7b16d1a39766.mp4
After
https://user-images.githubusercontent.com/2648215/154648793-2f3e8af7-8b11-4a7e-bcf8-0b4d8b039fa5.mp4
Safari is the new IE !!!

🎉


chore: implement eq_var in AcirContext to take advantage of optimizations

Description

Problem*

Resolves
Summary*
This PR inlines GeneratedAcir::is_equal into AcirContext::eq_var and implements it in terms of AcirVars so that we can take advantage of optimisations better.
Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Unsure whether this does anything past the changes which I broke off into #2380.

Closing as this increases circuit sizes if anything. Can maybe revisit this idea after #2137


Predefined color palette

Having many webmin copies on different systems it's hard to not confuse one with each other. So I think it will be usefull to have feature to quickly select primary color for a current copy instead of the standard blue.
It may be done simply by selecting a color from a palette in the theme configuration panel. It may be enough 8 colors like in the Google Keep.

Great point. Was planning to do this a while ago. Will try upon 16.02 update.

Oh, that'll be awesome! Thank you so much for your great work!

It will be there in version 17.00 actually, not 16.02.. Also pretty soon. Thanks for advising!

How about something like that:

It will be there in version 17.00 shortly.

About the color palette theme: Why not just offer the hex color field (#123456) ?

Well, it's not that easy to do. There are many elements with different shades and colors. Its not only about the main color. However it's doable. I'm just not sure it will be used by many.

Awesome!

qooob

I'm not really feel comfortable trying to correct you, but in my opinion the colors must be more distinctive. Because it's not a matter of decoration, but of a color coding. I mean, user must unambiguously recognize each server by just its color. So having too similar colors is not good from this point of view. I tried to make my variant of the pallette by tuning only hue and saturation.

The first colour in the palette is the current (default) color. The next four colours are made by changing only the hue, so they are completely coincide with each other and the first one by contrast. The sixth is made by dropping saturation to zero. Others are made by changing hue and saturation, they are contrast versions of previous colours. Please ignore the color of a pointer aside a selected item in the menu: it must be choosed individually.

kimful

I don't think the hex color is useful for the task we are solving. Theme must have all colors predefined, so that they match its style. Hex codes may be easly specified individually with CSS.

Thanks, nice example, will improve by next release!

Version 17.01 will have extra predefined sea green color and ability to set ten custom color themes. I think it will satisfy all picky users! ;)

I have an idea for autogenerated theme from one main color. Both navigation menu color and content page color.
May be you add options like this.
http://paletton.com/

Maybe, one day. Thanks.


Pip installation is broken

>>> import pymonero
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.5/site-packages/pymonero/__init__.py", line 1, in <module>
    from . import core
  File "/usr/local/lib/python3.5/site-packages/pymonero/core.py", line 2, in <module>
    from . import bitmonerod as _bitmonerod
ImportError: cannot import name 'bitmonerod'

Installed via pip3 install git+https://github.com/Monero-Monitor/pymonero.git
Python 3.5.1, OS X 10.11.
Looks like using absolute imports will fix this.

Thanks for the issue. I need to do some work on this package with the new Monero version release anyway, and have been needing to get things working correctly with pip.


added cost floats to fix rounding errors again

Untested? Yup.
Unnecessary? Yup.
Worth it? Totally.
(sillies aside this introduces a new CostFloat64 struct that allows for more precise floating point calculations for previously integer-only costs. Functions will be ported over on a case-by-case basis, though it seems unlikely given that they are intended to be converted back into Costs before being passed into other major functions.)

Ok i might be a tad bit obtuse... i'll need to review the code changes once I have the time.
(Some of the test results seem cut in 2, idk why, needs testing)


Fixer update PHP annotation (SF2 routing)

Here is the diff before / after:
 /**
  * @Route("/account")
  * @Template()
+ *
  * @Method("GET")
  */
 class UserController extends Controller

I think this is the same root cause than #1147: The fixer treats @Method("GET") as if it was the @method phpdoc rather than a complex annotation.

@lyrixx Please see #1204 ;)

Closing due to merge of #1204

Thanks


chore(main): release 1.17.0

:robot: I have created a release beep boop
1.17.0 (2024-02-08)
Features

update sharp (c9a0533)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/devoteam-se/devolunch/releases/tag/v1.17.0 :sunflower:


Move inilialized flag to struct member from bit flag in struct RRange

BTW, I just realized, I misunderstood that mrb_value size is 1 word with NaN boxing. If NaN boxing is enabled, mrb_value size is always 8 byte (same as double size), so 2 word on 32-bit CPU.
Therefore, the condition to embed edges was wrong originally, so struct RRange size exceeded 6 word with NaN boxing on 32-bit CPU.
I will create a separate PR about this.

I close this pull-request.


Ship first token2 crate and upgrade the monorepo with it

Replace the token1 usage in master/v1.3/v1.2 with token2.   We don't need to retain backwards compatibility with token1

Steps remaining:

[ ] Upgrade monorepo
[ ] Tag SPL release
[ ] Deploy program to clusters

Still needs deployment to devnet and testnet, when they are up

oops 👍

devnet is up now, for now...

Devnet is deployed! https://explorer.solana.com/address/TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA?cluster=devnet

Testnet is deployed: https://explorer.solana.com/address/TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA?cluster=testnet


add feature set custom component's render type. there is five render …

…type factory in weex engine, such as RenderCommonFactory,RenderTextFactory,RenderListFactory,RenderMaskFactory,RenderScrollerFactory,RenderAppBarFactory...
once your code need extension with wxText，but it will be render in RenderCommonFactory because the engine hardcode RenderTextFactory with text tag...

Brief Description of the PR
Checklist

Demo:
Documentation:

Rebase your code on master branch, thanks


Incorrect report?

I see this modules listed that are mismatched;
|   ⨉    | magento/module-bundle                           | 101.0.6     | D4DED34CE8057AA8 | 773E9097D362FE84 |     4%     |       No       |
|   ⨉    | magento/module-catalog-graph-ql                 | 100.4.6     | 4DA8F553B307EF1E | 4CCCD8B580769DA6 |     5%     |       No       |
|   ⨉    | magento/module-catalog-search                   | 102.0.6     | 0CC44559B51259B6 | 43B4A3611F12E768 |     4%     |       No       |
|   ⨉    | magento/module-catalog-widget                   | 100.4.6     | 323627DDBB3FC7B4 | A501A94E3F212CE1 |     4%     |       No       |
|   ⨉    | magento/module-checkout                         | 100.4.6     | D6F1DD5B129D6114 | 0FB6D1F089913564 |     4%     |       No       |
|   ⨉    | magento/module-directory-graph-ql               | 100.4.4     | 9FD0061629AF1A32 | 8D44305C732BE059 |     0%     |       No       |
|   ⨉    | magento/module-eav                              | 102.1.6     | 6AED23DB20C51665 | F7D8330F33A07B25 |     0%     |       No       |
|   ⨉    | magento/module-elasticsearch                    | 101.0.6     | 8157285B3E2C0A79 | D313E325B8F9BFCB |     4%     |       No       |
|   ⨉    | magento/module-elasticsearch-7                  | 100.4.6     | 85BA211B8AA3DD6E | D6FAAEE4D086FE3D |     4%     |       No       |
|   ⨉    | magento/module-graph-ql                         | 100.4.6     | AE16963F6D69039B | 390A36E2F3339E05 |     5%     |       No       |
|   ⨉    | magento/module-import-export                    | 101.0.6     | 2E117BC0BB1C2C9F | 2F65898970E9B77F |     0%     |       No       |
|   ⨉    | magento/module-message-queue                    | 100.4.6     | 1DABE71D03907454 | F9DF76EEC3662133 |     0%     |       No       |
|   ⨉    | magento/module-mysql-mq                         | 100.4.4     | 9F7A4DB5DD7ECF91 | E35F959FCFC40FDA |     0%     |       No       |
|   ⨉    | magento/module-product-alert                    | 100.4.5     | 1465355D8E610DFB | C6C2FFEC27A78877 |     4%     |       No       |
|   ⨉    | magento/module-quote-graph-ql                   | 100.4.6     | 96EDF305535226C1 | 17F30AA09A9FD0CA |     5%     |       No       |
|   ⨉    | magento/module-reports                          | 100.4.6     | 36D9348DA9C6E81D | 5907444B5E828498 |     4%     |       No       |
|   ⨉    | magento/module-review-graph-ql                  | 100.4.2     | BAB5B226681F548D | 15F9CF4C08CDAD87 |     5%     |       No       |
|   ⨉    | magento/module-store                            | 101.1.6     | 3146DA303469ABA9 | 714E8EE70A1329EF |     0%     |       No       |
|   ⨉    | magento/module-store-graph-ql                   | 100.4.4     | A91424DDC84DA5A1 | 8CBDD61F8830F633 |     0%     |       No       |
|   ⨉    | magento/module-ui                               | 101.2.6     | CC28F53B71A481AC | 5DB3707A3D8A640C |     4%     |       No       |
|   ⨉    | magento/module-url-rewrite                      | 102.0.5     | C349A2F39B8A46F5 | 60F230241E2F7129 |     0%     |       No       |

These come straight from the Magento repository, and I manually verified some of them. Why is there a mismatch on these with such a low percentage?

Could you zip one of these up? I want to check whether this is a bug in the hashing algo, or if there's another issue (actual difference in files/structure)

Thanks. So in my clean install of 2.4.6 I get:
|   ✓    | magento/module-elasticsearch-7                                    | 100.4.6   | 85BA211B8AA3DD6E | 802BBF85D3AA12C3 |    94%     |

While you get:
|   ⨉    | magento/module-elasticsearch-7                  | 100.4.6     | 85BA211B8AA3DD6E | D6FAAEE4D086FE3D |     4%     |       No       |

diff -qr ~/Downloads/vendor/magento/module-elasticsearch-7 vendor/magento/module-elasticsearch-7
Files /Users/daniel/Downloads/vendor/magento/module-elasticsearch-7/Model/Client/Elasticsearch.php and vendor/magento/module-elasticsearch-7/Model/Client/Elasticsearch.php differ
Files /Users/daniel/Downloads/vendor/magento/module-elasticsearch-7/SearchAdapter/Adapter.php and vendor/magento/module-elasticsearch-7/SearchAdapter/Adapter.php differ

diff /Users/daniel/Downloads/vendor/magento/module-elasticsearch-7/Model/Client/Elasticsearch.php vendor/magento/module-elasticsearch-7/Model/Client/Elasticsearch.php
382,403d381
<
<     /**
<      * Open point in time
<      *
<      * @param array $params
<      * @return array
<      */
<     public function openPointInTime(array $params = []): array
<     {
<         return $this->getElasticsearchClient()->openPointInTime($params);
<     }
<
<     /**
<      * Close point in time
<      *
<      * @param array $params
<      * @return array
<      */
<     public function closePointInTime(array $params = []): array
<     {
<         return $this->getElasticsearchClient()->closePointInTime($params);
<     }

My composer.lock contains:
https://repo.magento.com/archives/magento/module-elasticsearch-7/magento-module-elasticsearch-7-<IP_ADDRESS>.zip
$ curl -H "User-Agent: Composer/2.0.7 (Linux; 4.15.0-20-generic; PHP 7.2.24; curl 7.58.0)" --user USERNAME:PASSWORD https://repo.magento.com/archives/magento/module-elasticsearch-7/magento-module-elasticsearch-7-<IP_ADDRESS>.zip -o /tmp/elastic/elastic.zip

$ diff -qr ~/Downloads/vendor/magento/module-elasticsearch-7 /tmp/elastic
Files /Users/daniel/Downloads/vendor/magento/module-elasticsearch-7/Model/Client/Elasticsearch.php and /tmp/elastic/Model/Client/Elasticsearch.php differ
Files /Users/daniel/Downloads/vendor/magento/module-elasticsearch-7/SearchAdapter/Adapter.php and /tmp/elastic/SearchAdapter/Adapter.php differ

So I'm still convinced your elastic is different from the offical Magento Repo. I also tried mage-os repo and similar story.

That is weird, since this comes from the mage-os repo; https://mirror.mage-os.org/#magento/module-elasticsearch-7
This file comes straight out of our Private Packagist;
magento_module-elasticsearch-7_<IP_ADDRESS>_.zip

I also can't seem to find any mention of openPointInTime in the Magento codebase https://github.com/search?q=repo%3Amagento%2Fmagento2 openPointInTime&type=code

That is weird, since this comes from the mage-os repo; https://mirror.mage-os.org/#magento/module-elasticsearch-7
This file comes straight out of our Private Packagist; magento_module-elasticsearch-7_<IP_ADDRESS>_.zip

Is there a way to evict packages from your private packagist, so that it gets re-cached?
It wouldn't be the first time Magento released a package and then quietly changed it under the same version afterwards

I removed & reinitialized it, here's the download;
magento_module-elasticsearch-7_<IP_ADDRESS>_ (1).zip

At least we know the integrity check is doing its job...


[Multi-Cluster Discovery] Pilot Starts Regardless of Failure to Load Multi-Cluster Context

Bug Description
Background:

Rolling out a canary version update from 1.10.3 (with XDS_PROXY disabled) to 1.12.4 (with XDS_PROXY enabled)
Encountered a scenario where 1.12.4 control planes eventually get into a state where they push empty endpoints to proxies. Restarting Istiod-1-12-4 mitigates the issue but it is not clear how to discern a cluster that truly has no healthy endpoints from one that has healthy endpoints but is encountering a bug.
Running a multi-cluster setup with one local cluster and ~20-40 remote clusters being managed and setup via istio-remote-secret-. It previously appeared that this but only occurs when network connectivity is lost between the control plane and remote api server. We then encountered this bug when remote cluster count via istiod_managed_clusters{cluster_type="remote"} remains steady over the past 7d window.
1.12.4 pilots running in the same cluster with the same remote secrets setup can have different state. Since this bug is non-deterministic we have observed one affected pilot with the same remote cluster count missing all endpoints for a given remote cluster in localhost:8080/debug/endpointz while another pilot with the same setup will return the expected endpoints from the remote cluster when checking the debug endpoint.
We have a test workload that is restarted every 10 minutes and should generate an EDS PUSH as such; however, it seems that the remote cluster is no longer watched at all.

EDS: PUSH request for node:<POD_NAME>.<NAMESPACE_NAME> resources:200 size:<SIZE>kB empty:4 cached:<N-4>/<N>

Update:
It turns out this issue actually occurs on pilot start and is related to multi-cluster secret loading. Affected pilots are timing out while establishing communication to a remote API server and yet are still marked as healthy and never try to load the cluster context.
failed creating config configStore for cluster <CLUSTER_NAME> context deadline exceeded

This causes incorrect/asymmetric routes to be pushed to be pushed depending on which pilot a proxy connects to. It seems that a pilot should not be able to start without completely loading any multi-cluster configurations.
Version
$ istioctl-1.12.4 version
client version: 1.12.4
istiod version: 1.12.4
$ kubectl version --short
Client Version: v1.21.0
Server Version: v1.20.15-gke.1000

Additional Information
No response

Found in 1.9.4 change notes:
Fixed istiod never becoming ready when it fails to read resources from clusters configured via remote secrets. After a timeout configured by PILOT_REMOTE_CLUSTER_TIMEOUT (default 30s), istiod will become ready without syncing remote clusters. The stat remote_cluster_sync_timeouts will be incremented when this occurs. ([Issue #30838](https://github.com/istio/istio/issues/30838))

along with https://github.com/istio/istio/issues/30838
Although it is not clear having asymmetric pilots is a better state at least the behavior is configurable. Two other issues have come to light as a result.

Multi-cluster state is not auto-recovering. When connecting to a remote cluster it is not retried at any point in time and requires a pilot restart to converge on the expected state.
The istiod_managed_clusters and debug endpoint /debug/clusterz marks remote clusters as "synced" even when a timeout has occurred. https://github.dev/istio/istio/blob/1.12.4/pkg/kube/multicluster/secretcontroller.go#L137

@stevenctl

This behavior is intentional. The assumption was that istiod should only block startup for the "local" cluster/kube client.
If the clients for the remote clusters can't be created or we fail to sync with their apiserver, we wait up to PILOT_REMOTE_CLUSTER_TIMEOUT and after that the server marks itself as ready. This avoids the connectivity to one cluster completely blocking istiod startup across clusters.
There may be an improvement we can make here to fine tune this a bit.

Are these two issues exist?

Multi-cluster state is not auto-recovering. When a timeout occurs connecting to a remote cluster it is not retried at any point in time and requires a pilot restart to converge on the expected state.
The istiod_managed_clusters and debug endpoint /debug/clusterz marks remote clusters as "synced" even when a timeout has occurred. https://github.dev/istio/istio/blob/1.12.4/pkg/kube/multicluster/secretcontroller.go#L137

Yeah its understood the behavior is intentional, but as described in the above post, its really unscrupulous default behavior especially for meshes which operate replicas across clusters. Especially once connectivity is restored in a network partition there is no convergence upon the expected state.
The second point is that debugging the behavior is not so clear other than going back to the logs and finding that a multi-cluster secret was not loaded. The managed cluster count does not decrease and additionally the debug endpoint shows a "hacky" synced state when that is clearly not the case.

Found in 1.9.4 change notes:
Fixed istiod never becoming ready when it fails to read resources from clusters configured via remote secrets. After a timeout configured by PILOT_REMOTE_CLUSTER_TIMEOUT (default 30s), istiod will become ready without syncing remote clusters. The stat remote_cluster_sync_timeouts will be incremented when this occurs. ([Issue #30838](https://github.com/istio/istio/issues/30838))

along with #30838
Although it is not clear having asymmetric pilots is a better state at least the behavior is configurable. Two other issues have come to light as a result.

Multi-cluster state is not auto-recovering. When a timeout occurs connecting to a remote cluster it is not retried at any point in time and requires a pilot restart to converge on the expected state.
The istiod_managed_clusters and debug endpoint /debug/clusterz marks remote clusters as "synced" even when a timeout has occurred. https://github.dev/istio/istio/blob/1.12.4/pkg/kube/multicluster/secretcontroller.go#L137

Are these two issues exist?

Multi-cluster state is not auto-recovering. When a timeout occurs connecting to a remote cluster it is not retried at any point in time and requires a pilot restart to converge on the expected state.
The istiod_managed_clusters and debug endpoint /debug/clusterz marks remote clusters as "synced" even when a timeout has occurred. https://github.dev/istio/istio/blob/1.12.4/pkg/kube/multicluster/secretcontroller.go#L137

I'm happy to file a separate issue for cataloguing if it helps.

Especially once connectivity is restored in a network partition there is no convergence upon the expected state.

@hzxuzhonghu looks like we totally swallow errors that occur during init
https://github.com/istio/istio/blob/53ae9db2d3595aa31d170d134701f6a05319fc3a/pkg/kube/multicluster/secretcontroller.go#L366-L369
I think we should bubble this error up to get it to retry. But I guess we need to make sure 1. we don't block the queue and 2. we don't retry over and over too quickly.
if err {
(or just time.After)
delayQueue.Add(30 seconds, fn () { add back to controller queue )
}
WDYT?

make sense


license conflict

Hello, yukuku. I suggest that you could replace trove4j library, because it is LGPL and not compatible with Apache license which is used for your project.

Thank you @yangshulin2019 for raising this issue. I was not aware of it.
I have removed the trove4j dependencies in commit 8ba8921724b426734de43963a8869ba336a364c2. I think it is possible that the performance degrades a bit, but I don't think it will be significant, with the recent device performance.


[OpenAI-Assistant] Make new package Assistant build successfully

This is a new sibling OpenAI - Assistant package we are trying to have the first beta in 2024/01
This PR aim to make the feature branch feature/openai/assistant/bete.1 to build without failure.
Next Steps:
Add tests and samples and correct the implementation on the way.

API change check
API changes are not detected in this pull request.

Will merge this PR to feature branch with ci (build Analyze) failure (Verify TypeSpec generated code). It is a typo overriden introduced in TypeSpec, https://github.com/Azure/azure-rest-api-specs/pull/27076/files#r1447968324. This failure will be gone after the typo fixed.
So it is safe to merge this PR without this failure.


Add files via upload

Fixed a major string formatting issue. All strings, if valid spelling, will be formatted to be searched for correctly with no issues

Automatic string formatting issue fix


[md-subheader] What's point of margin-top for first child?

Bug, feature request, or proposal:
(Bug? Request?) Not sure.
I didn't find the specs of material subheader that contains following style:
@mixin md-subheader-base($top-padding, $secondary-size, $base-height) {
   ...
   ...
  &:first-child {
    margin-top: -$top-padding;
  }
}

Couldn't see much difference for normal use cases.
However, if user created some md-subheader using *ngIf, the md-subheader would be wrapped inside extra

. Thus styles for first-child would be effective and we could notice inconsistent behaviors for md-subheaders.
Check the plunker link below (different margins for md-subheader)
What is the expected behavior?
Consistent margin behavior for all md-subheaders
What is the current behavior?
See above
What are the steps to reproduce?
http://plnkr.co/edit/I1kueZi21gdktAGLIupS?p=preview
What is the use-case or motivation for changing an existing behavior?
Use-case: md-subheader is created using ngIf
Which versions of Angular, Material, OS, browsers are affected?
Angualr 2.1.0
Material: master branch
OS: Mac OS 10.11.6
Browsers: Chrome, Firefox, Safari
Is there anything else we should know?
Nope

https://material.google.com/components/lists.html#lists-specs
"Add 8dp of padding at the top and bottom of a list, except for lists with subheaders, which have their own padding."
So I guess the margin-top is supposed to offset the padding of list if md-subheader is the first child of md-list.


Fix security vulnerabilities in dependencies

This pull request addresses several security vulnerabilities that were identified in our project's dependencies.
'prettier/react', 'prettier/@typescript-eslint' was integrated to prettier by default. Not needed more
'babel-eslint' was deprecated and now calls '@babel/eslint-parser'

@0xTheProDev would you have capacity to publish a new version of this package with the updated dependencies? I too require these security fixes, in particular https://security.snyk.io/vuln/SNYK-JS-LOADERUTILS-3043105


Create a firefox-app-launcher based on chromium-app-launcher

Turns out that firefox is a pain to support this: https://bugzilla.mozilla.org/show_bug.cgi?id=1283670
Closing.


Changing the Every(1).[second, minute, etc] interface

I was thinking about changing the single time frames interface.
So basically, it would be removing the single time frame s.Every(1).Second().do(...) (et al) methods, and adding a new interface like s.EverySecond().do(...) for single seconds, and other unit time frames. Or maybe s.EverySecondDo(...).
My motivation is that informing informing a time unit for a mandatory time window seems quite redundant.
Of course this has low priority and would make breaking changes. What do you guys think about this? Any feedback?

personally i think s.Every(1).Second().do(...) is more modular and a user doesn't have to use different code for single time frame and different code for other timeframes

@codingsett those are good points. I'll be closing this issue as I've changed my mind since its opening. It's not much of an issue to keep the API as it is. Thanks for your feedback!


Pingplotter

Can you please add appNewVersion. I can at least see the version on this page:
https://www.pingplotter.com/download
Thank you!

Thank you!


Cannot convert the "c50a4bf0-db51-4ad2-88d5-fe2287da0eb8" value of type "Deserialized.Microsoft.Dynamics.Nav.Apps.Types.AppId" to type "System.Guid"

Describe the issue
Starting this week we get this error in our NextMajor pipelines, one week ago all was fine.
Cannot bind parameter 'Id'. Cannot convert the "c50a4bf0-db51-4ad2-88d5-fe2287da0eb8" value of type "Deserialized.Microsoft.Dynamics.Nav.Apps.Types.AppId" to type "System.Guid".

Since this error was thrown inside a dynamically created .ps1 (caused by Get-BcContainerAppInfo) file that was executed in the container, it was bit a challenging to hunt down.
This line in the script in the container causes this error
$apps = Get-NAVAppInfo @inArgs | Where-Object { (!$installedOnly) -or ($_.IsInstalled -eq $true) } | ForEach-Object { Get-NAVAppInfo -id $_.AppId -publisher $_.publisher -name $_.name -version $_.Version @inArgs }

with $inArgs being:
Name                           Value
----                           -----
ServerInstance                 BC
Tenant                         default
TenantSpecificProperties       False

These two lines (executed in the container) reproduces the issue
$apps = Get-NAVAppInfo @inArgs
Get-NAVAppInfo -id $apps[0].AppId @inArgs

While this works:
$apps = Get-NAVAppInfo @inArgs
Get-NAVAppInfo -id $apps[0].AppId.Value @inArgs

It seems like the result from Get-NAVAppInfo has changed from previous versions. The Id is not a guid or string, but the type Microsoft.Dynamics.Nav.Apps.Types.AppId.
Full output of scripts
BcContainerHelper version 6.0.6
Version: 24.0.16561.0

Additional context

does it happen all the time

Yes, for NextMajor containers. Starting sometime in the last week

did it use to work?

Yes, one week ago (BC v24.0.16336.0)

Please try BcContainerHelper preview - should be fixed there

Ok, thanks!

6.0.7-preview1150 did indeed solve this issue.

While I can also confirm that the preview did solve the problem for us, wouldn't it be better if the ticket stays open until a stable release with the solution is available?

Sure, I was just happy that I solved the issues in our pipeline. I cannot wait on the stable release with this... :)
Anyway, reopened as requested!

Even with the work-around in place, we keep getting the following error for NextMajor build pipeline runs (see screenshot): "The tenant default is not accessible"

We have a Retry Count on the task and it only fails the first attempt, while the second attempt it works just fine.
This only happens with the NextMajor (24.x) build pipeline runs, not with builds against the stable releases (23.x).
Anyone else experiencing these issues and/or know what to do about it?

@rvanbekkum your problem looks to be different - maybe caused by something else.
please create a new issue with this and repro steps for this.
In 24.x, all CmdLets are now running PowerShell 7 and use a bridge from PS5.

BCContainerHelper 6.0.7 has shipped with a fix for this (with generic images <IP_ADDRESS> or above)
Also note that generic images <IP_ADDRESS> for the latest Windows versions has shipped.


Please include a license file (repo + PyPI)

Please include a license file for the repository and the PyPI package python-codon-tables. On PyPI it only mentions about a Public Domain license, but I don't see a physical license document.
https://pypi.org/project/python-codon-tables/

cc: @veghp What kind of license would it be?

CC0: https://spdx.org/licenses/CC0-1.0.html
SAX-PD: https://spdx.org/licenses/SAX-PD.html

This is related to another PR: https://github.com/conda-forge/staged-recipes/pull/17283

@veghp and @Zulko can I ask, for the Public Domain license, would CC0 work? I am getting inspiration from this url.

Hi, thanks for the interest in this package. It was released into the public domain, hence no license. This is one of the valid license specifications for PyPI, is that not suitable for conda also?
In any case I merged the license PR.
As for the package being on conda, perhaps we'd prefer it to be named something else than codon-usage-tables or python_codon_tables (perhaps with a little added note), so that it's clear we are not the maintainers of the package. Would that be suitable?

Thank you, for merging the PR. "Public Domain" alone could be a little open to interpretation. So, it's safe and better to provide a license file and package that with the software.
About the package name, python-codon-tables is preferable as the source of the conda-forge package is the source you maintain at PyPI. It's understood that you may not be maintaining the conda-forge recipe and you can mention that in the readme in this repository (making it clear that it is not maintained by you).
However, given how minimal effort is necessary typically in maintaining the conda-forge package (once it is created), you could also push a PR to update the package there, and the maintainer of the conda-forge feedstock will merge it. You only have to may be change a few fields in a YAML file. That's it.

@veghp wanted to echo what @sugatoray is mentioning. Also, there are bots that help keep the conda-forge-distributed packages up-to-date with the PyPI releases, so the maintenance level actually drops to near-zero. In any case, I'm happy to be the maintainer of the recipe with @sugatoray, thereby keeping your inboxes free of clutter, if that's preferable to you. :smile:

@veghp Did you push the LICENSE file to PyPI as well?

I've done it now, PyPI has the latest version: https://pypi.org/project/python-codon-tables/0.1.11


Handle CPU single threaded with updated driver and taskset.

IREE recently introduced new driver dylib-sync which is used for
single threaded. After discussion, this should be run with taskset 80.
This is a step towards https://github.com/google/iree/pull/5582

Tested in https://buildkite.com/iree/iree-android-benchmark/builds/2361
I will apply the update of mako configs before merging the PR.


feat(curriculum): adding boilerplate workshop to cert

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes https://github.com/freeCodeCamp/CurriculumExpansion/issues/570

@Dario-DC
If I reverse the UI changes made in this PR here it works as expected
https://github.com/freeCodeCamp/freeCodeCamp/pull/56090/files

so we should leave those fixes to the open PR here
https://github.com/freeCodeCamp/freeCodeCamp/pull/56101/files


cannot backup SCB to USB from the blitz menu

when trying to backup the static channel backup to usb drive from the blitz menu this error is received.

drive is available and formatted to FAT32.

When there is no extar USB device attached the following command:
sudo /home/admin/config.scripts/blitz.backupdevice.sh status

Should show:
### blitz.backupdevice.sh ###
backupdevice=0
backupCandidates=0

Is it the case for you?

with device removed i receive the following:
### blitz.backupdevice.sh ###
backupdevice=0
backupCandidate[0]='zram0 4 GB zram0'
backupCandidates=1

even after rebooting, patching, etc.
i'm guess it is the zram issue afterall...
do you still recommend syncing with dev or v1.9??

yes, it is fixed there. See #3436.

okay. ^.^
went ahead and flashed an SD with v1.9.
i'll have to wait until i get a clear-ish day before i upgrade (have a bit of added software --  wireguard, charge-lnd, etc.).
i'm sure it'll work since it's already been an issue, but i'll report back afterward to confirm.
ty again for the support~!!

device added for backup -- as expected.
^.^


Roefem bugfix/82 wildcards postprocessing

Coverage remained the same at 100.0% when pulling 8ed9b01a5ffbebca2c524b17f990bab4ac0c4ba3 on roefem-bugfix/82_wildcards_postprocessing into f51948ade0c2dfa82d42471d6d55cf40d07aa209 on develop.

Coverage remained the same at 100.0% when pulling 8ed9b01a5ffbebca2c524b17f990bab4ac0c4ba3 on roefem-bugfix/82_wildcards_postprocessing into f51948ade0c2dfa82d42471d6d55cf40d07aa209 on develop.


fix: validation should be skipped if undefined is returned

Codecov Report

Merging #5 (b305824) into main (ca6d60e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines          349       349
  Branches        63        63
=========================================
  Hits           349       349

Impacted Files
Coverage Δ

src/index.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4c43b...b305824. Read the comment docs.


Missing release.md

Let's make sure to add a release.md on this so my buddies @szepeviktor and others can perform release by themselfs.

can perform release by themselfs

No way I'll make a release. I am just a 1-bit guy.

@szepeviktor You can do it buddy, it's release straightforward.


Add The MovieDB sensor

Description:
Sensor allows you get a list of upcoming, now playing, popular, and top rated movies and television shows from The MovieDB api.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): https://github.com/home-assistant/home-assistant.io/pull/8928
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: tmdb
    api_key: !secret api_key
    movie_lists:
      - upcoming
      - now_playing
      - popular
      - top_rated
    television_lists:
      - upcoming
      - now_playing
      - popular
      - top_rated

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

⚠ I was unable to find a documentation PR (matching this code change) in our documentation repository.
Please, update the documentation and open a PR for it (be sure to create a documentation PR against the next branch) and link 🔗 this PR and the new documentation PR by mentioning the link to the PR's in both openings posts/descriptions.
🏷 I am adding the docs-missing label until this has been resolved.

Added docs

Thanks for adding that @ljmerza 👍

Please fill out the missing fields of the PR template, especially the description and config example.

Please fill out the missing fields of the PR template, especially the description and config example.

done

There's still a typo in your attribute poster_apth

There's still a typo in your attribute poster_apth

fixed thanks.


Add MDN issue to PR template

https://github.com/whatwg/spec-factory/blob/main/PULL_REQUEST_TEMPLATE.md.template should be updated with a new checklist item like:
- [ ] [MDN Issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed (if applicable): …

Then we need to update https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests to give the right instructions for documentation.
@sideshowbarker maybe you could work on the whatwg/meta changes first?

@sideshowbarker did this drop of your radar?

I merged that, do you want to PR spec-factory? I can probably review today and merge and deploy tomorrow (generates 17 PRs and I'm not sure I want to deal with that today).


[llvm] fix issue #11916

Fixes #11916

Thanks for the PR!

@yurybura
add -DLLVM_ENABLE_PROJECTS=flang
Select Flang in the build system as usual by environment variable:
FC=flang
Build Flang
If you it necessary to build Flang, follow the LLVM build procedure with flag -DLLVM_ENABLE_PROJECTS=flang

Some Common options:
    -DLLVM_ENABLE_PROJECTS='...' — semicolon-separated list of the LLVM subprojects you’d like to additionally build. Can include any of: clang, clang-tools-extra, libcxx, libcxxabi, libunwind, lldb, compiler-rt, lld, polly, or debuginfo-tests.
    For example, to build LLVM, Clang, libcxx, and libcxxabi, use -DLLVM_ENABLE_PROJECTS="clang;libcxx;libcxxabi".


The first imagine in a track is over exposed

I've noticed that for the tracks I've recorded recently, the first imagine is always over-exposed. See attachment. That didn't happen in the past (see the older tracks in the "my tracks" view).

@alexandrui-telenav have we seen this more often?

Fixed.


Hide Promoted not working

Describe the bug
The current version does not hide promoted
To Reproduce
Steps to reproduce the behavior:
Installed extension, enabled it,
Checked settings was Enabled and Feed/Hide-promoted was enabled
Expected behavior
Expected promoted items in feed not to be visible.
Screenshots
There seems to be no difference in the feed, promoted content is still showing (clearly marked Promoted).
Environment (please complete the following information):

OS: Mac OSX 11.6
Browser [e.g. chrome, safari] Firefox 94.0.2
Version [e.g. 22] 1.2.1 (current from the search in Firefox Add Ons)

Additional context

Tested with latest version on Macbook air, with firefox, working fine now.


Cant find the transcribed note. Is their a default how it will be labeld after transcription?

Recording works fine. Audio file in attachments. Running command "transcribe and summarize". the assistant is the default one. open AI key generated and included in settings.

Hey @aaronmaas, it'll be titled Magic Mic - ${date.format('yyMMDDHHmmss')}.
Let me know if you're not able to find it. I have a suspicion about what could be going wrong.

Hey there @drewmcdonald thanks for your answer. I searched again for the specific notes as you outlined above, but they do not exist :) so whats your suspicion?

Can you share a little more about the audio files you've seen created? I'm wondering if we're allowing a file type that OpenAI does not.

And is there anything exceptional about the audio files or your settings?

I think some filetypes were not playing nice with a little optimization I had to skip processing on smaller files. Version 1.0.5 might fix it! Give it a shot.

This is almost perfect and what I have been searching for. Just one thing: can it just paste the transcription (or whatever my assistant does with it) at the cursor or just stick it in the clipboard? I like to dictate into notes. I don't want to create a new note for every piece and have to keep copy/pasting into the note that I'm writing. Fantastic work. Thank you. If this one thing is fixed I'll be using it daily.

Can you share a little more about the audio files you've seen created? I'm wondering if we're allowing a file type that OpenAI does not.

Yes of cource. It is a .webm file type. Your updated version startet to do process the transcibing but still there is no outcome. Is there any file type you would recommend? I think the .webm is the default when I use magic mic or the obsidian audio recorder. Thanks for the effort :)

Hello,
I'm having the exact same issue as aaronmaas. When I try to transcribe, I get the message: Magic Mic: transcribing (which stays on screen until I close Obsidian), but no transcription is created. Thanks for any help you can give me.


Enter the world and Build terrain takes +2m when moving from overwold to neither

On Bedrock Dedicated Server running in a docker container itzg/minecraft-bedrock-server:latest
Version: <IP_ADDRESS>
Ubuntu 22.04.4 LTS (GNU/Linux 6.5.0-45-generic x86_64)
Docker version 24.0.7, build 24.0.7-0ubuntu2~22.04.1
The time to enter load in to world or nether portal takes very long(+2) and cpu usage is very high.
I tried this on two machines. One is a dual xeon et-2699 v4 with 2400Mhz 128 DDR4 and raid nvme and the other is a AMD EPYC 75F3 with 3600MHz 256gb and dual pcie 4 nvme raid.
This is with no players
I set the cpu threads to 64 and even tried ram drive but it has no effect.
Is this normal? Anyway to keep nether in memory?
Nothing else on servers so ram and cpu is free

I'm not sorry, I can't provide support for the bedrock server itself. The container image simply sets it up and runs it. Please ask on the Mojang forums about this.

Ok. Just wanted to know if this is normal

Oh no, I meant to say "I'm sorry" originally.
No, it doesn't seem normal so it's definitely worthwhile to look into their issues system.

I think im going to try to run this bare metal and see if it has the same behaviour


Introduce the object stores in datafusion-contrib as optional features in the datafusion core

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently when we utilize the datafusion core as a library, it's possible to do the remote object store registration manually in the script code. However, for a long running standalone system, like Ballista, there's no place to do the registration manually. And in general, the remote object stores supported will not be changed. Therefore, it's better to provide a mechanism to register some object stores automatically rather than manually do the registration.
Describe the solution you'd like

With #2065, the object store extensions will no longer depend on the datafusion core. And now the datafusion core can depend on them. We can set those object stores as optional features in the datafusion core and let users decide whether to introduce them at the compilation time.
And since those extensions are maintained in their own crates, there's not much maintenance effort for the datafusion.
Describe alternatives you've considered

Additional context

It's blocked by #2076

An implementation example is https://github.com/yahoNanJing/arrow-datafusion/tree/dev


refactor: rename taproot utxo

Try out this version of Leather — Extension build, Test report

TaprootUtxo is wrong naming here, since we use it for both ns utxos and taproot utxos, also added derivation path to the interface as it is in BitcoinInputSigningConfig

Would be great if we could remove addressIndex from this entirely and use extractAddressIndexFromPath with derivation path instead (otherwise it's dupe info).


Add Rust -> Python logging bridge

This closes #1099

Codecov Report

Merging #1100 (13d688f) into main (bbcdc77) will decrease coverage by 2.51%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
- Coverage   80.90%   78.39%   -2.51%
==========================================
  Files          78       78
  Lines        4384     4384
  Branches      787      787
==========================================
- Hits         3547     3437     -110
- Misses        666      770     +104
- Partials      171      177       +6

see 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Best way to make it auto startup of start.sh

Hi,
I'm using the following init.d on debian:
so do:
sudo nano /etc/init.d/homebridge and paste the code below you might need to change the path and user
#!/bin/sh
### BEGIN INIT INFO
# Provides:
# Required-Start:    $remote_fs $syslog
# Required-Stop:     $remote_fs $syslog
# Default-Start:     2 3 4 5
# Default-Stop:      0 1 6
# Short-Description: Start daemon at boot time
# Description:       Enable service provided by daemon.
### END INIT INFO

dir="/root"
cmd="DEBUG=* /usr/bin/homebridge"
user="root"

name=`basename $0`
pid_file="/var/run/$name.pid"
stdout_log="/var/log/$name.log"
stderr_log="/var/log/$name.err"

get_pid() {
    cat "$pid_file"
}

is_running() {
    [ -f "$pid_file" ] && ps `get_pid` > /dev/null 2>&1
}

case "$1" in
    start)
    if is_running; then
        echo "Already started"
    else
        echo "Starting $name"
        cd "$dir"
        if [ -z "$user" ]; then
            sudo $cmd >> "$stdout_log" 2>> "$stderr_log" &
        else
            sudo -u "$user" $cmd >> "$stdout_log" 2>> "$stderr_log" &
        fi
        echo $! > "$pid_file"
        if ! is_running; then
            echo "Unable to start, see $stdout_log and $stderr_log"
            exit 1
        fi
    fi
    ;;
    stop)
    if is_running; then
        echo -n "Stopping $name.."
        kill `get_pid`
        for i in {1..10}
        do
            if ! is_running; then
                break
            fi

            echo -n "."
            sleep 1
        done
        echo

        if is_running; then
            echo "Not stopped; may still be shutting down or shutdown may have failed"
            exit 1
        else
            echo "Stopped"
            if [ -f "$pid_file" ]; then
                rm "$pid_file"
            fi
        fi
    else
        echo "Not running"
    fi
    ;;
    restart)
    $0 stop
    if is_running; then
        echo "Unable to stop, will not attempt to start"
        exit 1
    fi
    $0 start
    ;;
    status)
    if is_running; then
        echo "Running"
    else
        echo "Stopped"
        exit 1
    fi
    ;;
    *)
    echo "Usage: $0 {start|stop|restart|status}"
    exit 1
    ;;
esac

exit 0

and now run:
sudo chmod 755 /etc/init.d/homebridge
sudo update-rc.d home bridge defaults
If everything goes well you should be able to do /etc/init.d/homebridge start/stop/restart and  it will upon boot

Another way is to start the bridge when openHab starts:
rule "system startup"
when
  System started
then
  executeCommandLine("/opt/OpenHAB-HomeKit-Bridge/start.sh");
end

Currently working on a systemd script, but could not figure out how to get it running.
Unfortunately I had nothing to do with all this nodejs and npm stuff. Here is what I got so far:
`[Unit]
Description=homebridge
After=network.target
[Service]
ExecStart=/usr/local/bin/node /opt/OpenHab-HomeKit-Bridge/lib/index.js start --name "myOpenHAB-Bridge" --server localhost:8080 --sitemap test
Restart=always
StandardOutput=syslog
StandardError=syslog
User=nobody
Group=nobody
Environment=PATH=/usr/bin:/usr/local/bin
[Install]
WantedBy=multi-user.target`


Update apt dependency

Update apt module dependency to <5.0.0

@cdenneen Don't forget to repin .fixtures.yml.  I wonder how angry Travis-CI will get with the newer puppetlabs/apt...

@razorsedge I've done a larger update. apt version 2.x was last supported version for Puppet 3.
3.x and 4.x releases are for Puppet 4 only.
Therefore this is a breaking release and probably should be a major version release.
I've updated the metadata, fixtures, repo code, and tests to account for this upgrade.

@cdenneen I appreciate the work you have put into this PR.  Unfortunately, I do not find dropping support for Puppet 3 to be acceptable at this time.  At least not until EPEL and various Long Term Support platforms stop shipping Puppet 3.

@razorsedge Understood that's why I was recommending a new release of 2.x
that is a breaking change release. Between the apt dependency being 2
revisions behind, Puppet dropping all support and patches for <=3. I think
the 1.x release of your module will continue to work for anyone still using
Puppet 3. Anyone using Puppet 4 now (or even 5) and trying to stay up to
date with either of the last 2 major apt releases results in this being
completely broken and would have to use a self-maintained fork in order to
stay even remotely current. Most environments will be running modules that
now require apt >=3 so any sort of Puppetfile or puppet module install
would now have dependencies that can't be resolved.
This provides your users a legacy version to use while trying to stay
current.
There are a lot of Puppet 4 and 5 changes that can still be made to this
module but for now this was the minimum change in order to remove the
deprecated pieces.
Also I don't expect EPEL to be too far behind removing puppet 3 whenever
they get around to their next cleanup.
http://smoogespace.blogspot.com/2016/12/puppet-not-coming-back-to-epel-el-6.html?m=1
On Tue, Jul 18, 2017 at 11:16 PM Mike Arnold<EMAIL_ADDRESS>wrote:

@cdenneen https://github.com/cdenneen I appreciate the work you have
put into this PR. Unfortunately, I do not find dropping support for Puppet
3 to be acceptable at this time. At least not until EPEL and various Long
Term Support platforms stop shipping Puppet 3.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/razorsedge/puppet-vmwaretools/pull/65#issuecomment-316261007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAr84R-MaCJRrZWAv69enJn-CYV32B1wks5sPXUZgaJpZM4OaX-2
.

@razorsedge I've opened #66 to allow for Puppet3/4/5 to work and allow the dependency to be updated to 3.x.x or 4.x.x
When you decide to deprecate Puppet 3 support it should be as simple as removing the Puppet 3 travis tests and updating the fixture version.


add recovery no_op

real release environment have no use for recovery

Thank you for your pr, but need to consider more, your suggestions will be implemented.


Test version unique identifikator

Jira: SOX-8
KBC: https://github.com/keboola/connection/pull/4427
Before asking for review make sure that:
Checklist

[x] New client method(s) has tests
[ ] Apiary file is updated

Release

[x] I gave the PR a proper label:

major (BC break)
minor (new feature)
patch (backwards compatible fix)
no release (just test changes)

Este cakam na snapshot db aby som skusil, ze ten stlpec pojde naozaj pridat. Davam teda na predbezne review, upravim pak este doc.


Cache duplicate information with javascript to save render time and bandwidth

Show static properties in the same place with dynamic ones
Class definition and documentation, links to online APIs, methods and constants should only be printed once (click to open in another window?)
Parent classes of displayed ones are saved separately in case different inherited ones are displayed on the page.

Partial dupe of #39
I think only printing methods and constants once would be great but I also think it'll need some javascript magic because of the access paths (They definitely aren't the same even if the contents are)

pretty much superceded by #242


Is there any way to differentiate return codes for warnings vs diffs?

Skeema appears to use the same return code of 1 for warnings and when differences are detected.  We would like to have our pipeline that uses Skeema fail on warnings because we don't want the pipeline to proceed on most warnings.
Is there any way to split out diffs vs warnings?  Is there any planned change to modify the return codes to separate these?
see exit.go

That'll get you closer but you may need to tweak it further. It really depends on what you're aiming to do with that initial skeema diff, and which specific cases you want to abort on.
One problem is that some types of warnings don't affect the exit code of either skeema diff or skeema push, at all:

linter warnings
unparseable statements in *.sql files: usually this means INSERTs that are tracked alongside the table definitions, but not supported at all by Skeema yet... but in some cases it means someone typo'ed a critical keyword like CREATE or TABLE. (other SQL syntax errors/typos generally won't cause this to trip; Skeema just needs to parse enough to tell what type of object it is, and the object's name)
dir skipped because it doesn't map to any hosts (the situation you encountered earlier) or schema names in this environment

Most of the other "something was skipped" cases bump the exit code to 2+. Of the ones that do impact exit code, in terms of log level, some of those are ERROR and some are WARN; there's not a 1:1 match between log level and exit code. This is admittedly inconsistent, as it grew organically. So far the general prevailing principle has been "if some legit use-case may involve hitting this situation regularly, it's a warning and doesn't impact the exit code". I'm definitely open to making this more consistent in a future release, it just hasn't been high-pri compared to other pressing needs.
The other thing to be aware of is that diff and push have different exit code=1 behavior from each other: see the exit code descriptions in the help text for diff and push. More specifically, regarding exit code 1 in particular:

skeema push (without --dry-run) only returns exit code 1 if at least one modified table was unsupported for diff operations, and aside from that, nothing fatal happened.
skeema diff (or equivalently skeema push --dry-run) only returns exit code 1 when differences were found, and nothing fatal happened.

You probably want to fail the CI/CD pipeline if skeema push returns nonzero.

Closing, but feel free to reopen (or open separate issues) if you hit cases where the inconsistency between log level and exit code is problematic, situations where there's a clear case for making the behavior more configurable, etc.
Maybe it could be useful to eventually have an option or subcommand that validates your skeema configuration for a given environment, to catch those "no host defined" or "no schema defined" cases explicitly.


Cannot add a srcDir including precompiled script plugins

Expected Behavior
It should be possible to add a srcDir("src/main/kotlin2") or wherever to add additional source directories. If precompiled script plugins exist in this directory as well, they should be treated the same as if they were in src/main/kotlin.

Current Behavior

Currently, src/main/kotlin seems to be treated specially - the compiler for those is somehow configured differently to other srcDirs in the project. This causes them to fail compilation on basic things such as the allprojects {} block.
Context

The thing we're actually trying to do is apply a plugin to itself. However, the issue appears to be wider than this admittedly somewhat niche requirement, as I later discovered it happened no matter where I put the source files.

Steps to Reproduce

This small test project reproduces it.
Alternatively, you can do this:

Take some currently-working project using precompiled script plugins.
Rename src/main/kotlin to src/main/kotlin2
Add this to build.gradle.kts:kotlin {
    sourceSets["main"].kotlin.srcDir("src/main/kotlin2")
}

(the same happens if you use setSrcDirs instead.)
Try to build

Your Environment

Build scan URL: https://scans.gradle.com/s/yla5icptgcms6

Is the issue that this line is eagerly getting the compile classpath?
https://github.com/gradle/gradle/blob/9033c66b107f95d8bc21225c1166e496555d74a2/subprojects/kotlin-dsl-provider-plugins/src/main/kotlin/org/gradle/kotlin/dsl/provider/plugins/precompiled/DefaultPrecompiledScriptPluginsSupport.kt#L200

Thanks for the report, @hakanai.
My hunch is that it might be related to gradlePlugin.pluginSourceSet not including those  plugins:
https://github.com/gradle/gradle/blob/9033c66b107f95d8bc21225c1166e496555d74a2/subprojects/kotlin-dsl-provider-plugins/src/main/kotlin/org/gradle/kotlin/dsl/provider/plugins/precompiled/DefaultPrecompiledScriptPluginsSupport.kt#L400

So I threw in a println to see what value gradlePlugin.pluginSourceSet has, and it is:
source set 'main'

Which at least has the same name as the source set I'm adding this source dir to...

I guess collectScriptPluginFiles too is being called eagerly, some time before I added the source dir.

According to the documentation

You write these as *.gradle files in src/main/groovy directory or *.gradle.kts files in src/main/kotlin directory.

There's no promise for precompiled script plugin source directory configurability.

If you're going to take that attitude then you might as well remove srcDirs from the API entirely, because the docs also say things like Java sources have to be in src/main/java, etc. :)

Agreed this can be considered a bug. The kotlin-dsl plugin should defer reading from the source set.


[Neo4j] Incubator -> Stable

@unguiculus as per your suggestion here - https://github.com/kubernetes/charts/pull/2114#issuecomment-342567141

/ok-to-test

Rebased this against the currenr master

CI failed as always for this chart. Test run successfully on my cluster.

/lgtm


Use oxipng instead optipng

Oxipng began as a complete rewrite of the OptiPNG project, which was assumed to be dead as no commit had been made to it since March 2014.
The core goal of rewriting OptiPNG was to implement multithreading, which would be very difficult to do within the existing C codebase of OptiPNG. This also served as an opportunity to choose a more modern, safer language (Rust).

Good to know, thanks!


Make Sentry integration more obvious in-repo

Please explain the problem/why you would want to see a change and any workarounds you might have in place.

For v0.9.0 or even v0.8.0, it may be good to have Rollbar working. It would also be good to have robust logging for debugging and local development.
EDIT: I'll start using Sentry since it has an on-prem solution. I need to set that up and make it clear for local dev that it is not required to send in a Sentry URI or DSN for development.

Implicitly, this means removing Sentry support. In general, developer documentation should be improved to make it clear this is for production and nothing else.

The scope of this ticket is simply to get the distribution working as per #26 and therefore it has been solved by that PR.


Markdown: Fix readme.md links.

Changed the url_to_a function to check if there is a readme.md url. If found the href tag points to "http://github.com/zulip/zulip/blob/master/README.md" rather than "http://readme.md". Apologies for multiple commit messages for such a small change.

Automated message from Dropbox CLA bot
@mahim97, it looks like you've already signed the Dropbox CLA. Thanks!

@mahim97 you should rebase to squash your commits.
Check out our GitHub guide for details on how to do this.
Also, I think we probably want to just not automatically linkify foo.md to be a link to a .md domain, rather than linking to the Zulip README; that's a simpler solution and will address similar issues for e.g. contributing.md.

@mahim97 I'm not sure you understood my last comment; I think we should just disable auto-linkification of the .md TLD, and not do anything special when someone mentions things ending with .md.

I misunderstood you. But other than that its working fine, so if by any chance later on there is any possibility of using this feature, we can use this. I will look for some other issue to work on.

@mahim97 well we still need to change Zulip to not linkify the .md TLD, right?

@timabbott How about just unlinking these special foo.md links rather than unlinking the complete .md TLD?

I have removed the links for the Zulip .md links. Now these will be returned as plain text. And any other .md link will still be hyperlinked to its appropriate url. Something of this sort. Please tell me  if any changes are required.

We're not going to merge a version that has a bunch of special links; it's a maintainability pain.  We just want to not auto-linkify the .md domain.

Fixed via b36e94c95451e497cbea4b9603923beaf4d47f08


Implement support for downloading a remote plugin from an arbitrary HTTPS location

This would mainly be to support loading plugins directly from a public GitHub release and to dramatically simplify the initial getting started experience.

I think this should also support some form of passing an Authorization header, which would need to read secrets from somewhere. Future improvements might include checking a signature?

Initial implementation doesn't read secrets but does check a sha256 hash.


Remove one pixel shift from PNeo parser

There was a one pixel shift relevant for Pleiades, that seems to have been copied over to PNeo.
For PNeo, the top-left pixel was again set to (0, 0), making this correction unnecessary: https://github.com/OSGeo/gdal/blob/master/gcore/mdreader/reader_pleiades.cpp#L411

@mnhrdt @carlodef , can someone please have a look at this?

looks alright to me, but I don't know if this will break something downstream

It only shifts everything by one pixel, so should improve georeferencing by one pixel.
Was speaking to someone from Airbus/GDAL maintainer and he pointed out this bug as well.


generate dist version files

As title says, how can I generate/compile the dist version of the files?

npm run dist
You can see that it calls rollup -c by finding its reference in package.json. Then you can see that rollup.config.js holds all the config for generating everything in the dist directory.

npm run dist
You can see that it calls rollup -c by finding its reference in package.json. Then you can see that rollup.config.js holds all the config for generating everything in the dist directory.


chore(ci): revert ci changes to use pull_request

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (363a3b9) 86.80% compared to head (9cbb0b2) 86.80%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2406   +/-   ##
=======================================
  Coverage   86.80%   86.80%
=======================================
  Files          85       85
  Lines        9328     9328
  Branches      489      489
=======================================
  Hits         8097     8097
  Misses       1231     1231

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add simple vorpal example

If this looks good, I can proceed to replicate all existing shell commands. vorpal can help enforce required arguments, but the existing shell seemed to use optional arguments as required. I defaulted them to make them optional, but they could also be made required, and no additional error handling logic would be needed.
https://github.com/dthree/vorpal/wiki/api-|-vorpal.command#vorpalcommandcommand-description
Since this tool is initially for testing, I recommend not making arguments required and picking reasonable defaults so the flow can be quickly run through, like so:
› npm run truebit

><EMAIL_ADDRESS>truebit /Users/orie/Desktop/tech-spikes/truebit-os
> node ./cli/index.js basic-client/config.json

  _____                         _       _   _
 |_   _|  _ __   _   _    ___  | |__   (_) | |_   _
   | |   | '__| | | | |  / _ \ | '_ \  | | | __| (_)
   | |   | |    | |_| | |  __/ | |_) | | | | |_   _
   |_|   |_|     \__,_|  \___| |_.__/  |_|  \__| (_)

  _            _                _                            _  __
 | |_ __ _ ___| | __  ___  ___ | |_   _____  __   _____ _ __(_)/ _|_   _
 | __/ _` / __| |/ / / __|/ _ \| \ \ / / _ \ \ \ / / _ \ '__| | |_| | | |
 | || (_| \__ \   <  \__ \ (_) | |\ V /  __/  \ V /  __/ |  | |  _| |_| |
  \__\__,_|___/_|\_\ |___/\___/|_| \_/ \___|   \_/ \___|_|  |_|_|  \__, |
                                                                   |___/
🎲   $ 2018-06-04 22:05:21 [console] info: Truebit OS has been initialized with config at basic-client/config.json
🎲   $ start task
2018-06-04 22:05:26 [console] info: Task Giver initialized
🎲   $ start solve
2018-06-04 22:05:29 [console] info: Solver initialized
🎲   $ task
🎲   $ 2018-06-04 22:05:34 [console] info: Task submitted 0xbfdf4d4185cf59347a6014a6054b83767a901d14fd6b70e4ebbbeaec6bfbbe75
🎲   $ skip
🎲   $ Error: VM Exception while processing transaction: revert

I recommend not reusing words for commands / agents, such as task. For example:
start task-submitter -a 0
submit-task -a 0 -t testTask.json

The vorpal stuff seems very reasonable.
In terms of commands, I agree that the task stuff seems confusing. I think we should do this:
start task -a 0
submit-task -a 0 -t testTask.json

Cool, I will continue, and use that approach.

Leaving this here for reference: https://github.com/dthree/cash/tree/master/test
Testing CLI's is difficult. The functions can be tested, on the full tool can be tested.
I think the best approach is to have vorpal call a library function, and then write tests for each of those functions. This saves you from needing to handle stdout/stderr.

Testing stdout would be fancy, but probably not necessary for the time. The functions that the cli's should be calling are mostly in the tests now, so I think that will be sufficient.
In terms of the UI, manually going through to check isn't too bad since there aren't too many commands at the moment.

I've taken some stylist liberties here, happy to remove them (the dice). Just want to show what can be done.

travis is so picky... this passed on my side. https://travis-ci.org/OR13/truebit-os/builds/389775141
I need to add the tests that I have written and test again.

Objective here is to get the cliLib tests to pass along side the os tests. I'm seeing some revert failure when running os-challenge.
This is caused by the addition of the verifier. The os-challenge test does not actually test the verifier, and its presence causes failure.
I'm happy to tackle fixing that test in a separate pr.

If we are happy with travis tests passing in this form:
https://travis-ci.org/TrueBitFoundation/truebit-os/builds/390175190#L914
I suggest we merge this PR, and I can tackle the verifier (os-challenge) bit next.
I can also remove reference to the old shell and cleanup a bit, but I don't want to do that unless its requested.

Great work! Yes please remove any references of old shell, we have no use for it anymore.

Now we know why the builds were failing... If i had a penny for every-time truffle / testrpc / ganache / web3 version slipped and broke my stuff... I'd have lots of pennies....
https://travis-ci.org/TrueBitFoundation/truebit-os/jobs/391048018#L461

I'd say this is safe to merge now.

Looks good! Really appreciate the effort on this!


[main] Remove go install from build image

What this PR does / why we need it:

Fixes build issues we have with go 1.22 image combined with upstream vendorless changes
Full discussion here
Tested with https://github.com/openshift-knative/serving/pull/781 and https://github.com/openshift-knative/serving/pull/783

Does this PR needs for other branches:
No, will break for 1.15, which is not cut yet

/assign @skonto

/lgtm
/approve
Do we need those tools?

Seems no, or better said they are installed on demand anyway. No idea why they were there during build time in the first place.


Shell Script Highlighting

The highlighting for shell scripts seems to be a bit off, partially random. Is it just me?

This is under development yet? I can help you to understand bash (zsh) language. But I know almost nothing about the themes sintax. I have a project for hilight spice sintax but I am not a wizzard.


PHP 8

Hey there,
The current composer dependencies state php version ^7.0, are there any plans to make this package commpatible with PHP 8 in the future?
Thanks,

Hi @AndrewHaine,
We certainly plan to make this package compatible with PHP8. However, due to our current workload I cannot say when this will happen. A PR addressing this issue would help.
Have a great day.

Hi @AndrewHaine,
We certainly plan to make this package compatible with PHP8. However, due to our current workload I cannot say when this will happen. A PR addressing this issue would help.
Have a great day.

Thank you everybody. @Wirone's PR has been released under version 1.1.0.

Thank you everybody. @Wirone's PR has been released under version 1.1.0.

Thank you all! :)