Unable to route towards/over tailscale from UDM LAN (UDM Pro v3.0.20)

UDM Pro, running OS v3.0.20 (Kernel 4.19.152 SMP)
Installed Tailscale with install script
Configured with:
#tailscale up --advertise-routes=<IP_ADDRESS>/23,<IP_ADDRESS>/24 --advertise-exit-node --advertise-tags=tag:udmpro --accept-routes
#tailscale ip -4
<IP_ADDRESS>
Issue:
Cannot ping local IP nor any other IPs.
'traceroute -n <IP_ADDRESS>' goes to WAN port and the next hop router, then dies.
'traceroute -n <IP_ADDRESS>' (<IP_ADDRESS>/24 is an advertized LAN behind another tailscale router) goes to WAN port and the next hop router, then dies.
Obviously the UDM Pro does NOT see the tailscale network, and thus has no idea how to route across the tailscale connection...

Based on Discussion  #51, I was able to get the daemon up and running in TUN mode, and now I can:

ping remote tailscale IPs and the networks behind them from the UDM Pro shell,
ping the local tailscale IP from my hosts,
not ping the remote tailscale IPs from my hosts, let alone the networks behind them.

@FearNaBoinne FWIW, I also had same problem as you, but I figured it out. Leaving my comments here, as it took me a very long time to figure out, and hopefully it can help others.
First off, you absolutely need ip rule add priority 5225 fwmark 0x80000 lookup 201 but you knew that already. And remove --tun userspace-networking from the tailscaled options.
Then, do tailscale up  --exit-node-allow-lan-access --exit-node=YOUR_EXIT_NODE this is the vital step. Also, using a exit node like this will temporarily knock your UDM off the internet, so it is VITAL that you don't forget --exit-node-allow-lan-access or you'll be in a world of pain trying to recover your UDM, probably via factory reset if you don't have a console cable.
tailscale puts its routes in table 52 (ip route show table 52)
you'll need to remove the default route, and if you are doing any sort of split networking (https://github.com/peacey/split-vpn) then also remove the the subnet from the throw route. (if using split-vpn script, be sure to add a route to the exit node before running the updown.sh script.)
All put together
cat /etc/default/tailscaled
# Set the port to listen on for incoming VPN packets.
# Remote nodes will automatically be informed about the new port number,
# but you might want to configure this in order to set external firewall
# settings.
PORT="41641"

# Extra flags you might want to pass to tailscaled.

Btw, apparently 'exit node' is not just a simple routing rule. It appears that the exit node is saved into a preference file, and uploaded to the control plane. I wasn't able to make this work by NOT running it in --exit-mode.
Note - instead of exit node, you could try to just advertise default routes --advertise-routes=<IP_ADDRESS>/0 but I haven't tried this.
Now, after all that work, I might not use tailscale after all because a tailscale node act as both an exit node and use an exit node. :-( Probably going to end up using straight wireguard.

tailscale up --exit-node-allow-lan-access --exit-node=YOUR_EXIT_NODE

My UDM Pro is my exit-node, but when I used it's name in the --exit-node parameter, it tells me invalid value "YOUR_EXIT_NODE" for --exit-node; must be IP or unique node name


Uncaught TypeError: Ei is not a function

Hello,
Since few weeks I decided to localize my website based on the the browser culture and since that decision i start to face the following error. Uncaught TypeError: Ei is not a function.
The weird thing is that when i change the language of my chrome(Version 47.0.2526.106 m) to English US and i set up the APIversion to 1  (google.load('visualization', '1', { packages: ['controls'], callback: createCpuRamChart });) my charts are shown.
When i change the browser language to Danish i am getting the error i mentioned before.
I have tried also to use the API version 1.1. The result was that with the browser language set up to English US, the charts are not shown but when i change to Danish the chart works..
I have even changed the way how i load the data like:
var cpuData = new google.visualization.DataTable();
             cpuData.addColumn('date', 'Date');
             cpuData.addColumn('number', 'CPU');
             cpuData.addRow([new Date(1252152000000),4])
             cpuData.addRow([new Date(1252152000123),5])
             cpuData.addRow([new Date(1252152000456),6])

But unfortunate I am getting the same error....

Problem solved for the moment. Instead of using the 'controls' package i used line and did something similar like here https://jsfiddle.net/api/post/library/pure/


Amplify pull - pushing with a custom profileName - incorrect AWS Account ID

Describe the bug
We have a CI/CD script before building the app that pulls the Amplify code (aws-exports, queries, mutations etc), we use a custom profile name for each environment, this is the pull script -
REACTNATIVECONFIG="{\
\"SourceDir\":\"src\",\
\"DistributionDir\":\"/\",\
\"BuildCommand\":\"npm run-script build\",\
\"StartCommand\":\"npm run-script start\"\
}"
AWSCLOUDFORMATIONCONFIG="{\
\"configLevel\":\"project\",\
\"useProfile\":true,\
\"profileName\":\"$PROJECT_NAME-$ENV\",\
\"region\":\"$REGION\"\
}"
AMPLIFY="{\
\"projectName\":\"$PROJECT_NAME\",\
\"appId\":\"$APP_ID\",\
\"envName\":\"$ENV\",\
\"defaultEditor\":\"code\"\
}"
FRONTEND="{\
\"frontend\":\"javascript\",\
\"framework\":\"react-native\",\
\"config\":$REACTNATIVECONFIG}"
PROVIDERS="{\
\"awscloudformation\":$AWSCLOUDFORMATIONCONFIG}"

echo -e "no\n" | amplify pull \
  --amplify $AMPLIFY \
  --frontend $FRONTEND \
  --providers $PROVIDERS

The pull fails with this error -
User: USER_ARN is not authorized to perform: amplify:GetApp on resource: arn:aws:amplify:REGION:INCORRECT_ACCOUNT_ID:apps/APP_ID

Version 4.37.1 and below works, I have tried 4.38.0 and 4.39.0 both do not work
Amplify CLI Version
Anything 4.38.0 and above
To Reproduce
Create a script like the one I pasted above, have correct credentials for a custom AWS profile, you will not be able to pull your app from that profile.
Expected behavior
Custom profiles should work

Hi @idanlo, I wasn't able to reproduce this. The pull script you provided worked for me on 4.39.0. Are you still seeing this issue on version 4.40.1?

Closing due to lack of response.

Closing due to lack of response.


Pipeline / Build / Error authenticating: exit status 1

What kind of request is this (question/bug/enhancement/feature request):
question or possible bug
Steps to reproduce (least amount of steps as possible):
Install a fresh cluster, with RKE
Install a fresh Rancher 2.1.1 ( 2.1.0 have the same problem )
Result:
If I add a private repository ( docker-registry from Catalog or from Helm-incubator ), or even if I try to use the DockerHub private repository, each time the Pipeline fail on the build part, about an « Error authenticating »:

11:05:34 [pipeline_p-bvz7d-5] Running shell script
11:05:36 + /usr/local/bin/dockerd-entrypoint.sh /bin/drone-docker
11:05:36 + /usr/local/bin/dockerd -g /var/lib/docker
11:05:55 EXITCODE   0time="2018-10-21T11:05:52Z" level=fatal msg="Error authenticating: exit status 1"

Other details that may be helpful:
I never used Rancher before, so may be I've missed something. But after 3 days of multiples tests, and search in the issues, I've found there is multiple bugs around private registry. One bug have been fixed in 2.1.1, so I've tried to remove everything (reformat all my cluster disks) and re-install the 2.1.1, but I get the same issue. I've found a ticket about registry that should be fixed in 2.1.2, I'm not known if it's really related.
Is it a bug, do I need to wait the version 2.1.2 ?
Environment information

Rancher version: 2.1.1
Installation option (single install/HA): single on a HA cluster v1.12 installed with RKE

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom, Imported
Machine type (cloud/VM/metal) and specifications (CPU/memory): metal, 11 nodes 32Go RAM / 8vCPU
Kubernetes version (use kubectl version): 1.12.0

Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.1", GitCommit:"4ed3216f3ec431b140b1d899130a69fc671678f4", GitTreeState:"clean", BuildDate:"2018-10-05T16:46:06Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.0", GitCommit:"0ed33881dc4355495f623c6f22e7dd0b7632b7c0", GitTreeState:"clean", BuildDate:"2018-09-27T16:55:41Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

Docker (use docker info):

Containers: 28
 Running: 18
 Paused: 0
 Stopped: 10
Images: 12
Server Version: 18.06.1-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 468a545b9edcd5932818eb9de8e72413e616e86e
runc version: 69663f0bd4b60df09991c08812a60108003fa340
init version: fec3683
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.15.0-34-generic
Operating System: Ubuntu 18.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.3GiB
Name: cp1.readact.page
ID: RJJU:SN4M:6G2H:HL2D:UL6S:UF5Y:WOFD:YJEL:TBT5:RYEF:U7DV:5IZI
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support

( installed from get.docker.com, channel stable, 18.06.x seems to be the new references for k8s on v1.12.x )

Thanks for the report.
@lakano Can you provide the detailed reproduce steps?
It will be great if you can provide the .rancher-pipeline.yml file

@lakano Basically when the docker login fails you will see this error. We've found users hitting the same error message due to different causes, like dns issue/improper configs of registry.
To diagnose you can enable debug mode of dockerd to get more information, e.g.:
stages:
- name: build
  steps:
  - publishImageConfig:
      dockerfilePath: ./Dockerfile
      buildContext: .
      tag: myproject
      pushRemote: true
      registry: index.docker.io
    env:
      PLUGIN_DEBUG: "true"

Ok I'll check that ASAP. Currently, we doesn't need to push outside, so if we uncheck "push" option, the build is correctly completed.

@iwin4aids You can give additional envvars to tweak the build image step:
stages:
- name: build
  steps:
  - publishImageConfig:
      dockerfilePath: ./Dockerfile
      buildContext: .
      tag: myproject
      pushRemote: true
      registry: index.docker.io
    env:
      PLUGIN_DEBUG: "true"
      PLUGIN_INSECURE: "true"

You can check more in the docs(clicking on By Yaml tab of Build and Publish Images) https://rancher.com/docs/rancher/v2.x/en/tools/pipelines/configurations/#build-publish-image

Hi,
I can't continue to debug my initial issue, because my Rancher crash in loop on each build. Each time I need to restart the rancher docker, to reconfigure logging, recreate all secrets, configure Gitlab.com and retry. This bug have been fixed but will be fixed in 2.2 (planned firstly for 2.1.2 and moved to 2.2 ... )
Do you have an idea of how many days I need to wait for the 2.2 version please? To known if we keep trying to uses Rancher or not.
Thanks

@lakano which issue causes your Rancher crash in loop?

@loganhz The issue #16187

@lakano
You are using ECR on AWS with IAM and you don't need to input the username and password for the registry. But it will cause your rancher server crash in loop. Is it correct?
Can you try this workaround https://github.com/rancher/rancher/issues/16187#issuecomment-431038011 , please?

Not exactly, I'm not using AWS, but docker-registry with empty username/password, and this crash in loop when I try to push on the registry.
Yes I've tried the workaround, and this doesn't crash anymore, but there is surely another problem, because after this workaround, I have another error;

08:59:19 Get http://<IP_ADDRESS>:5000/v2/: dial tcp <IP_ADDRESS>:5000: getsockopt: connection refused
08:59:19 time="2018-10-28T08:59:19Z" level=fatal msg="exit status 1"

I don't known why there is a /v2/ in the URL. When I've installed docker-registry, I've set a NodePort on port 5000. So the URL is good until the /v2/ ... but why there is a /v2/ I don't known :-/

@lakano You see a /v2/ because it is the docker distribution API specification.
The publish step does not use docker socket on the host, so it does not work in this way...
You are not able to access the registry in a pod using the loopback address. You need to use nodeIP:nodePort to access the registry for your case.

Ok, thanks @gitlawr
But, I've just tried with the DNS name, this is now a different response:

15:13:59 Get https://docker-registry-docker-registry.default:5000/v2/: http: server gave HTTP response to HTTPS client

But can't see anything else because there is again a crash loop of rancher... even with the workaround used previously.

Thanks @gitlawr
Now, I've removed the manually installed Helm chart docker-registry, and now I use the auto-generated docker-registry when the Rancher pipeline is triggered.
In my .ranche-pipeline.yaml I have set:

registry: docker-registry.p-fs5p6.pipeline

and in my deployment.yaml, my docker image is prefixed by the same hostname.
Now, there is a auth problem:

16:17:58 Successfully built e679aa5e3887
16:17:58 Successfully tagged 00000000:latest
16:17:58 + /usr/local/bin/docker tag 00000000 docker-registry.p-fs5p6-pipeline/readact/upload:latest
16:17:58 + /usr/local/bin/docker push docker-registry.p-fs5p6-pipeline/readact/upload:latest
16:17:58 The push refers to repository [docker-registry.p-fs5p6-pipeline/readact/upload]
16:17:58 d0f08e0aa672: Preparing
16:17:58 30a0582be6f3: Preparing
16:17:58 5ba1448b4861: Preparing
16:17:58 2ee25a145bbc: Preparing
16:17:58 47de5ef441f1: Preparing
16:17:58 2839211f95e7: Preparing
16:17:58 89099b8fbac6: Preparing
16:17:58 cb18274b2dd1: Preparing
16:17:58 df64d3292fd6: Preparing
16:17:58 89099b8fbac6: Waiting
16:17:58 2839211f95e7: Waiting
16:17:58 cb18274b2dd1: Waiting
16:17:58 df64d3292fd6: Waiting
16:17:58 no basic auth credentials
16:17:58 time="2018-10-28T16:17:58Z" level=fatal msg="exit status 1"

This seems to be related to issues #15554 / #13339 , but the workaround to add imagePullSecrets in my deployment.yaml doesn't seems to help. Or may be I don't refer to the good secret, i've used the secret named "p-fs5p6-pipelinedockerregistrydefault".
If you have any idea to help, this will be really appreciated!

If you use the auto-generated docker registry,

remove pushRemote & registry field for publish step
add imagePullSecrets with pipeline-docker-registry secret name in deployment

This works! Thanks a lot !

@gitlawr Please, could you tell me if I need to put a special host in the field template.spec.containers.image ? I've got ErrImagePull errors currently.

This works for me. https://github.com/rancher/rancher/issues/16624#issuecomment-440213383

I'm having the very same problem even the pipeline I'm trying to run is from Rancher examples.
https://github.com/rancher/pipeline-example-go
stages:

name: Build
steps:

runScriptConfig:
image: golang:1.11
shellScript: |-
mkdir -p /go/src/github.com/rancher
ln -s pwd /go/src/github.com/rancher/pipeline-example-go
cd /go/src/github.com/rancher/pipeline-example-go
go build -o bin/hello-server
go test -cover

name: Publish
steps:

publishImageConfig:
dockerfilePath: ./Dockerfile
buildContext: .
tag: example-helloserver:${CICD_EXECUTION_SEQUENCE}

name: Deploy
steps:

applyYamlConfig:
path: ./deployment.yaml

The error I get is "Got FAILED status in 'Publish' stage"
22:02:58 [pipeline_p-7g8b6-10] Running shell script
22:03:01 + /usr/local/bin/dockerd-entrypoint.sh /bin/drone-docker
22:03:01 + /usr/local/bin/dockerd -g /var/lib/docker
22:03:07 EXITCODE   0time="2019-06-23T22:03:06Z" level=fatal msg="Error authenticating: exit status 1"

add up max-concurrent-uploads in /etc/docker/daemon.json

everybody，how to fix this bug?


Request failed with status code 500:258: txn-mempool-conflict

node . mint DMzXnN3NdgCK5EvN7uvzLVSCeQWhHEuCRJ "text/plain;charset=utf8" 776F6F66
broadcasting tx 1 of 2
broadcasting tx 2 of 2
Request failed with status code 500:258: txn-mempool-conflict
any suggestions?!

How did you manage to fix your previous error? Connect ECONNREFUSED

How did you manage to fix your previous error? Connect ECONNREFUSED

saved a file with wrong extension.

Same. Windows 10 did me dirty. Added an invisible .txt extension to the dogecoin.conf file

@suiAKT can you tell me how to fix the ECONNEREFUSED error and where can i find my rpc url

how did you fix Request failed with status code 500:258: txn-mempool-conflict?


Browserify support to match superagent

Are there any plans to match superagent in the browser? That way I would be able to write tests for HTTP in the server and XMLHttpRequest in the browser seamlessly.
The actual requests already work across the stack thanks to recent changes to superagent, but the mocking structure for the browser isn't there yet. So.

Are there any plans to match superagent in the browser?

+1

+1

+1

+1, if it did I could perform integration tests based on unit tests. I guess I will have to rewrite all the tests to use superagent instead.

+1

fwiw, I use nets nowadays which is both simpler & does play ball with browserify.


[FR] Auto allocate stock to a sales order

Problem
If you have a large sales order (with a lot of items) from a customer, there are no Auto-Allocate / Unallocate / Allocate Stock functions like in the case of a build order:

Suggested solution
It would be nice if we can use the same functions here what we have on the build order page.
Describe alternatives you've considered
Now you have to click on each "allocate stock" button line-by-line.

@rkalman nice idea, would represent a fair amount of work! I'll tag is for the next-but-one release

Thank you!

I didn't realise there was an FR on this.. but the inventree-python binding has the function allocateToShipment for a SO line item, which does automatic allocation (if you let it): see it here

This could enhance the workflow well. Now if you has a sales order with lots of items you have to do this:

add the item to the sales order
add the same item to a purchase order
after received the PO items:
allocate items one by one to a SO

Maybe instead of duplicating the automatic allocation it will be nice if we can import items to a PO/SO from a file.
So you fill a SO with items, export it and import to a SO.
Or even do the opposite, export a PO items (already present) and import these to a SO (missing).

Oh wait, on the demo server there is a PO import.... I'll check this


Add support for ARM architecture for CLI binaries

Problem

Currently the CLI binary targets are: windows, linux and darwin. We should also build for targets such as node12-linux-arm64
Suggested solution

We do not currently have control over CLI binary building as this is handled and published by Prisma themselves. We will need to submit a PR in the Prisma Client Go repository.
The list of possible targets can be found here: https://github.com/vercel/pkg#targets.
Additional context

https://github.com/RobertCraigie/prisma-client-py/issues/195#issuecomment-1001350680
This is also more relevant now that we are adding support for ARM engine binaries in #233

I ran into this trying to generate the prisma client in the docker container on a M1 macbook. Surprisingly, it does build outside docker on my M1 (not sure how to explain that, but maybe something to do with the darwin target)
Workarounds I can think of:

generate the prisma package on mac and version control it
build the docker images using the --platform flag to target x86. This won't run locally on my M1 macbook, but will run in my production environments.

Any other ideas? I do see that vercel has arm targets so I'm not sure what's missing to get this unblocked. Also-- the prisma client go package has a deprecation notice so does it make sense to submit PRs there?

generate the prisma package on mac and version control it

This doesn't work since the container still relies on the binaries in the current design of the python client

Surprisingly, it does build outside docker on my M1

@tday It builds outside of docker because of Rosetta 2 which enables some cross-compatibility https://github.com/prisma/prisma-client-go/issues/717#issuecomment-1025063113

Any other ideas? I do see that vercel has arm targets so I'm not sure what's missing to get this unblocked.

There is nothing that I'm aware of that is blocking this, the work just needs to be done.

Also-- the prisma client go package has a deprecation notice so does it make sense to submit PRs there?

Yes, the Go Client has been deprecated but the binaries will still be updated: https://github.com/prisma/prisma-client-go/tree/main/binaries#community-members
A better solution would be to roll our own binaries however I don't want to have to pay for any hosting costs.

generate the prisma package on mac and version control it

This doesn't work since the container still relies on the binaries in the current design of the python client

Currently, ARM engine binaries are not downloaded, however that is going to be fixed by #233.
You could download these binaries using the following script which should work:
set -eux

mkdir -p bin

curl https://binaries.prisma.sh/all_commits/34df67547cf5598f5a6cd3eb45f14ee70c3fb86f/darwin-arm64/prisma-fmt.gz -o bin/prisma-fmt
curl https://binaries.prisma.sh/all_commits/34df67547cf5598f5a6cd3eb45f14ee70c3fb86f/darwin-arm64/introspection-engine.gz -o bin/introspection-engine
curl https://binaries.prisma.sh/all_commits/34df67547cf5598f5a6cd3eb45f14ee70c3fb86f/darwin-arm64/migration-engine.gz -o bin/migration-engine
curl https://binaries.prisma.sh/all_commits/34df67547cf5598f5a6cd3eb45f14ee70c3fb86f/darwin-arm64/query-engine.gz -o bin/query-engine

chmod +x bin/prisma-fmt
chmod +x bin/introspection-engine
chmod +x bin/migration-engine
chmod +x bin/query-engine

You could then copy these binaries into the docker image and configure Prisma Python to use them by setting env variables:
PRISMA_QUERY_ENGINE_BINARY=bin/query-engine
PRISMA_MIGRATION_ENGINE_BINARY=bin/migration-engine
PRISMA_INTROSPECTION_ENGINE_BINARY=bin/introspection-engine
PRISMA_FMT_BINARY=bin/prisma-fmt

Also another potential solution is to use the Node CLI through npx however I don't know how well this would work within a docker container.

I was able to get this working using the --platform flag on M1, actually. I like the npx idea though, that would be less hacky. I may give that a try if I have time to come back to this to clean up.
Here's what my dockerfile looks like in case others stumble onto it:
FROM --platform=linux/amd64 python:3.9

# Copy code
RUN mkdir /data-service
WORKDIR /data-service
COPY Pipfile .
COPY Pipfile.lock .
COPY prisma .
COPY src src/

# Install dependencies
RUN curl https://raw.githubusercontent.com/pypa/pipenv/master/get-pipenv.py | python
RUN pipenv install --system --deploy --ignore-pipfile
RUN prisma generate

# Start service
CMD ["python3", "src/app.py"]

Side note: Thanks so much for being so responsive and helpful. This package has so much potential and it inspires confidence to see how you have structured and maintained it! I'm looking to get a production app running with this to see if it performs well at scale. I hope I can have time to contribute enhancements as I get further along, but right now I'm in prototyping stage for my company.

Side note: Thanks so much for being so responsive and helpful. This package has so much potential and it inspires confidence to see how you have structured and maintained it! I'm looking to get a production app running with this to see if it performs well at scale.

Thank you so much! That means a lot to me :)

I hope I can have time to contribute enhancements as I get further along, but right now I'm in prototyping stage for my company.

Your contributions would be more than welcome and that is really exciting! Please let me know how it goes for you and if there are any improvements I could make!
Also feel free to join the community discord server if you have any questions / need any additional support :)


Reworking logging.

This PR rewords how the logging works due to a regression in which the root logger rather than a named "datashuttle" logger was used. I am quite confused as to what happened here as fancylog has never created a named logger. It happened to work because "datashuttle" logger was propagating through the FileHandler stream on the root logger that fancylog had setup.
Anyway, this PR:

Is based on recent fancylog changes (v0.4.2) which allow starting a named logger (i.e. logger=getLogger("some_name") rather than logger=getLogger() which gets the root).
Now all interaction with the logger in datashuttle is ensured to be through this named logger. This is supported by a number of convenience functions in ds_logger.py.
Add tests that the logger is setup and logging as expected.

This PR requires #387 for tests to pass, as new version of fancylog requires >=Python3.9. It requires no further tests or documentation changes.

Yes @niksirbi I was quite surprised as to how it happened, I am still finding new ways for the logging module to confuse me.  I think in this case the the take home message was to always use a named logger!


[Bug] Cantrips don't show up in actions list at all

even toggling "limit actions to cantrips" which i don't think would hide them one way or another anyways, doesn't change anything. there are jsut no cantrips being shown in the quick actions list for anybody

I see cantrips in FoundryVTT version 10 build 291 and version 6.0.4 of Character Actions List dnd5e.


Plan out proof-of-concept for hackday

Should include at least #10, maybe #5?

Proof of concept now mapped out in this HackMD document


Seperate sorbet sigs from rb files

This separates the sorbet sigs from rb files so sorbet runtime won't affect the lib code.
Test Plan

ci

You can extends T::Sig::WithoutRuntime to keep the sig in the same file as the file.

You can extends T::Sig::WithoutRuntime to keep the sig in the same file as the file but skip the runtime checks.

Actually, I think we're moving way from sorbet-runtime completely; and only use sorbet for static tc

Note - to deal with the merge conflicts, I went through each merge file and moved T::sig changes to the private_rbi folder, trying to contextually understand what happened by looking at prior PRs. Think it's also now up to me to port over the rest of the changes to master.

Hey @donaldong, just wanted to ask - what was the original purpose of this PR / how should I continue it, if at all? Katy and I were considering also completely removing sorbet from the project.
Alternatively, I can port over the original remove-sig logic to the new code that were introduced to master since this PR was opened! If that's the case, should I be:

removing all instances of sorbet in runtime code, including TypeCoerce, T::Struct, etc.?
or, just removing sigs, but keeping general runtime code


Parliament demo update, CANDOR corpus conversion notebook

Description
Updated Parliament-demo from expected context by manually going over all the clusters and re-ordering the name list to match original works from the paper and the thesis by Justine.
Added a notebook under /examples/dataset-examples/CANDOR/candor_to_convokit.ipynb which converts CANDOR corpus to ConvoKit format

merged, no version bump needed since it's only examples, and documentation.


Simplification: merge AvroJsonProp to AvroProp

Currently, @AvroProp("text") is translated to a text node containing text. This is also the behavior of AvroJsonProp when it is not a valid json.
Let's unify AvroJsonProp and AvroProp to simplify the avro4k api, and now support json in AvroProp

Released in v2.0.0


HTTP Request took too long to complete

Successfully built 96c39d4de2a8
Successfully tagged workbench_deposit_coin_address:latest
workbench_db_1 is up-to-date
workbench_rabbitmq_1 is up-to-date
workbench_redis_1 is up-to-date
Creating workbench_geth_1 ...

Creating workbench_deposit_collection_1 ...
Creating workbench_matching_1           ...
Creating workbench_trade_executor_1     ...
Creating workbench_pusher_member_1      ...
Creating workbench_slave_book_1         ...
Creating workbench_global_state_1       ...
Creating workbench_deposit_coin_address_1 ...
Creating workbench_pusher_market_1        ...
Creating workbench_withdraw_coin_1        ...
Creating workbench_deposit_collection_fees_1 ...
Creating workbench_order_processor_1         ...
Creating workbench_market_ticker_1           ...
Creating workbench_withdraw_audit_1          ...
ERROR: for workbench_deposit_collection_fees_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_order_processor_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_pusher_market_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_pusher_member_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_withdraw_coin_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_market_ticker_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_deposit_coin_address_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_global_state_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_slave_book_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_withdraw_audit_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_blockchain_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_matching_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_deposit_collection_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for workbench_trade_executor_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for order_processor  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for deposit_collection_fees  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for withdraw_coin  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for deposit_coin_address  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for global_state  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for market_ticker  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for pusher_member  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for slave_book  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for withdraw_audit  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for pusher_market  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for blockchain  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for matching  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for deposit_collection  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for trade_executor  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: An HTTP request took too long to complete. Retry with --verbose to obtain debug information.
If you encounter this issue regularly because of slow network conditions, consider setting COMPOSE_HTTP_TIMEOUT to a higher value (current value: 60).
Makefile:36: recipe for target 'daemons' failed
make: *** [daemons] Error 1
This is the error it's throwing

@xcelr can you move issue to workbench ?


Idl: Limit account size to 60kb, allow closing idl accounts

Originally by @microwavedcola1

This looks nice, thanks for adding. @microwavedcola1 I don't know if you would mind adding a typescript test demonstrating the new close functionality to the existing set of IDL tests.
https://github.com/coral-xyz/anchor/blob/master/tests/anchor-cli-idl/tests/idl.ts

I played around with adding accounts larger than 10kb and it seems like adding bytes to write buffer causes a memory issue before it can even reach account sizes above 10kb. So unless someone wants to switch over all the old IDL code to using zero copy accounts, this is probably as big as the account can be for now.
Not to mention, one issue with updating the IDL code to newer account types is that account types like Account rely on having the owner attribute implemented. But because the IDL accounts structs have their macros expanded while still in the anchor crate, then there's no way to know what the program ID to use is. Again, unless someone wants to port all of this code to being stored in a quote stream that only gets executed at the downstream program's compile time.
Anyway, I just need to

[x] Add the test (already done)
[ ] Fix the clippy errors
[ ] update the change log
And then it's ready to merge i think

Weird compile error happening with some programs but not others. It's possible that it's linked to the use of try_into() that was added in a number of places. Maybe there's a more explicit casting we can do instead? I read through a couple of the passing vs. failing programs and it's not clear what differences there are between them that could be causing this (i.e. they were both essentially empty/placeholder programs).
error[E0599]: no method named `try_into` found for type `u32` in the current scope
   --> programs/multiple-suites-run-single/src/lib.rs:5:1
    |
5   | #[program]
    | ^^^^^^^^^^ method not found in `u[32](https://github.com/coral-xyz/anchor/actions/runs/3840033520/jobs/6538648897#step:10:33)`

    error[E0599]: no method named `try_into` found for type `usize` in the current scope
   --> programs/multiple-suites-run-single/src/lib.rs:5:1
    |
5   | #[program]
    | ^^^^^^^^^^ method not found in `usize`
    |
    ```


Documentation/github-connector: warn user that GitHub email id should be public.

Looks like a lot of users are trying the GitHub connector with private email ids.

Made changes according to the feedback.

Note that you should be able to get non-public emails with user:email scope, but you need to explicitly query api.github.com/user/emails
e.g. see https://github.com/thephpleague/oauth2-client/issues/9#issuecomment-20653139


Catching GeoTiff/WebGL errors doesn't work

Describe the bug
I'm trying to catch errors when rendering a GeoTiff source via a WebGLTile layer, e.g. CORS issues.
The error is shown in the console, but it seems there's no way to catch / handle it.
To Reproduce
Example: https://codesandbox.io/s/cog-forked-492cf3?file=/main.js
Expected behavior
The fallback gets called due to the error.

There are no errors.  EPSG:32610 is not defined so the tiles are rendered at those coordinates in the view projection (over North Africa).

Interesting, my Firefox reports a CORS error / AggregateError.
In Chrome it "works" (as in: no error, but of course there's still the projection issue).
I'd still expect that the error is handled in FF...

Firefox is sensitive to server setup, see #14817
To check for errors listen for source change events then check source.getState().

Thanks, that works. That is somewhat unintuitive though.
I'd expect that if the source.getState() returns error, that it should trigger an error event, right?
Is that something worth creating a PR for?

I'd expect that if the source.getState() returns error, that it should trigger an error event, right?

No, the TileJSON and BingMaps sources also set the state to error with only a change event if they fail to become ready.

Firefox is sensitive to server setup, see #14817

I have just checked the new https://openlayers.org/en/main/examples/cog-projection.html example and it was not working on Firefox.  Adding Header set Access-Control-Allow-Headers "range" to the server's .htaccess fixed it.

Thanks, but as a user, I'm completely confused. What is the error event for and when does it apply? If the change event thing is intentional, then it at least needs better documentation.

I think that is a separate issue.  A large number of classes inherit the error event from ol/Observable but it is rarely used (all I can find is ol/layer/MapboxVector, which will be removed by #14870).  The API for ol/Geolocation shows two error events, its own and the inherited one.  If not used it should be removed.


Submit github.js to cdnjs

This should happen after v1.0.0 is released.

This was fixed by pointing out npmcdn.com in 66d504f05661eedb8ad507dbd931d8c2d26b4b4d


refactor: Separation of Concerns && code refactoring

Pull Request
Description
Décrivez brièvement l'objectif de cette demande d'extraction.
Changements Effectués
Fournissez un aperçu concis des changements que vous avez effectués.
Liste de Vérification

[ ] Tester les changements localement.
[ ] Le code respecte les normes du projet.

Merci !

I've done some components separation of concerns like ( ArticleForm, ArticleView, Top Africa)
I've add fetchloation API result form separation of concern.
I've refactor some css style and the top Africa page style and functionalities

@blessingtutka thank you for your PR. I noticed that you don't have the latest version of the app. Can you make sure you have it locally?
This is how it looks like

Your version is like this (you still have underscore in the titles)

Update your PR and let me know.

Some titles are not displaying when I pull the latest change that's why I remove the function that remove the underscore but I'll try to find another that do it better.
This is what I found: {article?.includes('_') && (article = article.replace(/_/g, ' '))}
(please look at the first article)

Fix it with this :
{article?.includes('_') ? article.replace(/_/g, ' ') : article}
Now everything is fine

@blessingtutka thank you for the update. Can you send me the screenshot of the hero section? It's written in Français "Veillez remplir..." not "Fill all fields".

@Bam92
I'm update but for some pages, I accept my change on the merge editor.


Preferences - Values changed more than 2 times are not correctly applied across devices

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to https://staging.new.expensify.com/
on 2 devices with the same account
Go offline on main device
Change any value 3 or more times on main device (Notification toggle, Priority mode or Language)
Go online on main device

Expected Result:
Values on both devices should be the same, and value should be equal to the last one selected.
Actual Result:
On main device value is not equal to the last one selected. On secondary device value could be different from main device (not always)
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/229247162-b9a50cac-4857-4f99-bbe3-475666db35e8.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ce5fe355e26e1100
Upwork Job ID:<PHONE_NUMBER>107428864
Last Price Increase: 2023-04-06

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

Hey @tgolen! As you are closest to offline first just want to double check this is in fact a bug. I'm pretty sure it is but figured checking is best

I think it is, yeah. It's not totally expected behavior. What I think is happening is that when the device comes back online, all of the requests are made in quick succession, and there is nothing to guarantee the order that the second device will get the pusher updates in. The second device is probably getting them out-of-order sometimes.
I guess one of the ways we could fix it is by doing something that we've long discussed, which is while the device is offline, we would try to de-duplicate the API requests that are queued (for example, we would see the same setting getting toggled 20 times, and combine all those requests into a single request). We've really held off on doing that though until there was a clear and specific problem it would fix.
cc @jasperhuangg @marcaaron

Maybe a possible way to manage these concurrency issues is to start lumping them together somewhere. When looked at in isolation it's a bit hard for me to get motivated enough to do anything about it.
I know there is some ideal solution to all of this, but it might require some heady discussions and my gut tells me to punt it for now.

Thank you both! This seems like a good internal candidate based on the backend considerations

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@MitchExpensify, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MitchExpensify, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Scouted for an internal volunteer here: https://expensify.slack.com/archives/C03SSAQ7P/p1681158567602319

Bumped scouting message https://expensify.slack.com/archives/C03SSAQ7P/p1681158567602319

@MitchExpensify I replied to you in the slack thread.
I think we need a pre-design and even a light design doc for this as this involves a change to the Onyx queue logic.
When I'm done with the Bug Report project I started this week, I can take this one.  I think I can start on this by the end of this month at the latest. It doesn't seem to be urgent.

Sounds good, flipping to weekly as no one has suggested this is super urgent 😄

assigning myself will get to this issue once I have a bandwidth seems to be a nice opportunity to be familiar with Onyx

This issue is fairly nuanced. I would suggest we put it on HOLD and start a wider conversation before doing any coding or refactors to try and fix it so it can be resolved thoughtfully.

This Slack convo and tracking issue might be related


Change layout of Additional AWS Resources

As outlined in issue #915, addons templates currently don’t support Conditions.
For completeness, users can’t write Description, Metadata, Mappings, Conditions, and Transform sections into their addons template.
The only supported sections are Parameters, Resources, and Outputs.
Proposal
We propose changing the addons/ directory structure to be one CFN template per addon.
For example, if a user wants to add a DDB table and an S3 bucket addon, the file structure will be:
my-svc/
  manifest.yaml
  addons/
    mytable-ddb.yaml
    mybucket-s3.yaml

Where mytable-ddb.yaml and mybucket-s3.yaml can be full CloudFormation templates.
Behind the scenes, we will merge these two templates into one.
This should allow customers to add all the missing sections, and make it easier to write a new addon on their own.

@efekarakus Is there any specific reason we are spitting this into multiple file ?

@FarmaanElahi  They can all be in a single file :) Sorry, that wasn't clear enough from the description.
We're working on adding a new command storage init (https://github.com/aws/amazon-ecs-cli-v2/pull/990#issuecomment-637866124) that will generate CF templates under "addons/" for you. These addon commands will create a separate file each time it's run, so that we don't mess with your existing templates. Afterwards, you can move the contents to a single file if you'd like or split them up it won't matter.


Bump hugo, NodeJS and ubuntu versions

Bump:

hugo version to latest release: https://github.com/gohugoio/hugo/releases/tag/v0.104.3
ubuntu used in actions to ubuntu-latest as 18.04 is no more supported
No more specify current LTS version, use the alias

So deploy of pull request preview is currently broken: https://github.com/EGI-Federation/documentation/actions/workflows/deploy_pr_preview.yml :/

and obviously update of the deploy.yaml are not taken into account and need to be merged in the main branch to be tested. Will see what I can do with my fork/a test repo

@enolfc, can you please have a look, it seems ready/working now. Thanks!


This player support  MPEG-TS by UDP/RTP?

Is it possible to play MPEG-TS (UDP/RTP) on samsung smart tv using this player?
Is there an example if it is.

Maybe YES => theoreticaly is the same solution as in example connect stream put MPEG-TS to ffmpeg demuxer and pass output to Player => but MPEG-TS is only container not format look to TV table to support inner content and i dont know if exist example or udp/rtp stream downloader here? can write more about your project ?


Release 0.4.0

Version 0.3.0 is one year old and a lot of improvements have been made since then.
It would be very useful to have them in the CDN.

All set!


112 author doc

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs (without age check):

Before: https://main--sazerac-wheatleyvodka--hlxsites.hlx.page/?noAgeCheck=yes
After: https://112-author-doc--sazerac-wheatleyvodka--hlxsites.hlx.page/?noAgeCheck=yes

Test URLs (with age check):

Before: https://main--sazerac-wheatleyvodka--hlxsites.hlx.page/
After: https://112-author-doc--sazerac-wheatleyvodka--hlxsites.hlx.page/

Issues found:
For the cocktail detail page (receipe)
I added a proposal for the missing creator information to the receipes.md. Use the flatiron flip cocktail for details: https://adobe.sharepoint.com/:w:/r/sites/HelixProjects/_layouts/15/Doc.aspx?sourcedoc={6090EA25-73A7-48BF-824B-7599FC820F44}&file=flatiron-flip.docx&action=default&mobileredirect=true

add the creator information to the documentation
update the three screenshots with the flatiron flip instead
describe the templating mechanism, showing the content of the template, where the template is stored, how to change it. The template needs to be published individually to reflect any changes online.

different ways of describing
Various ways on how content shall be structured found. This may confuse the reader, i.e if he needs to put special characters. Stick to one consistent way of notation across all documentation.

(img) vs image vs [image]
list vs (ul)(li)entry(li)entry vs (List with links)
(a) vs [links] vs (embed link) vs link
text vs [text]
(h1) vs title


Include environment in the NPC sheet

Since it is still an attribute of NPC actors and can be used by other modules, I think the environment should be visible somewhere on the NPCs' character sheet. Perhaps the ideal would be a window with pre-established values, but which would allow entering custom values (something like the damage resistance configuration window).

Feels like it should be a text field with a datalist like source books

Monsters can be in multiple environments. Have to keep that in mind as well.


ProfileProvider::parse_credentials_file() truncates secrets that contain '='

ProfileProvider::parse_credentials_file() will truncate any secrets that contain a '=' character.  It appears that unwrapped_line.split('=').collect() is assuming that there's only one '=' on a line (i.e. from the key = value).
I happened to have a secret that contained a '=' character which was failing to work when fetched from the ProfileProvider but worked fine when used with a StaticProvider.

Note that the secret that fails came from Oracle Cloud Object Storage
Customer Secret Keys --> Generate Secret Key


Validate image version

Reopening this PR: https://github.com/cilium/cilium-cli/pull/196
Fixes: #187

Thanks for the PR. Some comments below.
* Why only Hubble and Clustermesh are calllng `validateParams()`? What about the others?

* In commit `Validate image version `, please write what changed and why in the commit body rather than the current list in there now.

Thanks for adding the unit tests btw 🚀

What do you mean others for validateParams(). I only added to Hubble and Clustermesh as cilium main install already has it:https://github.com/cilium/cilium-cli/blob/d73fbfe058356e23c2cc4cf01b773233f31b0da2/install/install.go#L1058
I couldn't name the same as there is already validate() in https://github.com/cilium/cilium-cli/blob/d73fbfe058356e23c2cc4cf01b773233f31b0da2/hubble/hubble.go#L102 and https://github.com/cilium/cilium-cli/blob/d73fbfe058356e23c2cc4cf01b773233f31b0da2/clustermesh/clustermesh.go#L612

@GoGstickGo What is meant is that if we are going to validate the images for Clustermesh and Hubble, then why not do it for everything else like the agent and the operator images: https://github.com/cilium/cilium-cli/blob/d73fbfe058356e23c2cc4cf01b773233f31b0da2/install/install.go#L1037

In commit Validate image version , please write what changed and why in the commit body rather than the current list in there now.

The above item is not addressed. While the list in useful, it would be better if we separated out fixes into their own commits. Not every item in the list corresponds to a commit, so some things can be combined together. For example, the change that adds the Clustermesh arg for an image can be separated. This is useful in case we have regressions and we need to revert the change. Instead of reverting unnecessary code, we only revert the code that potentially causes issues.

@christarazi  , 1.Changes break into commits.  2. Image validation for agent and operator can be found https://github.com/cilium/cilium-cli/pull/219/commits/37aba765ef648a0af6f6b5633ab7f79ff306aecf

https://github.com/cilium/cilium-cli/actions/runs/927870806 hit flake fixed by #302:
📋 Test Report
❌ 1/9 tests failed (2/69 actions), 0 warnings, 0 tests skipped, 4 scenarios skipped:
Test [echo-ingress]:
  ❌ echo-ingress/pod-to-pod/curl-1: cilium-test/client2-657df6649d-zc7vr (<IP_ADDRESS>) -> cilium-test/echo-other-node-646f4f6797-ztgp6 (<IP_ADDRESS>:8080)
  ❌ echo-ingress/pod-to-pod/curl-2: cilium-test/client2-657df6649d-zc7vr (<IP_ADDRESS>) -> cilium-test/echo-other-node-646f4f6797-ztgp6 (<IP_ADDRESS>:8080)

I think we're good :)

Thanks @nbusseneau !
@joestringer @christarazi, can we move forward with it ?


Fix start error for asciidoctorj tool on OpenJDK 10

As reported by Russel Winder on Twitter the AsciidoctorJ tool crashes right after the start on OpenJDK 10 due to the JVM option -XX:+UseFastAccessorMethods.
This PR simply removes this flag.
While it might make AsciidoctorJ a bit slower when started from the command line, it's still better than not starting at all.
And it shouldn't hurt, because this flag isn't set anyway when running for example as part of the Maven plugin.

I'm totally fine with this change. While that flag made sense at the time, it no longer makes sense. :wave:

Thanks for reporting @russel!

There's a few things that I want to get in first for example support for loggers, where I am waiting for some feedback.
When that is in I'll do a new release.


2024-10-08_01-35-04_master-next_aws-c-mqtt

Automatically created.

Successfully created backport PR for kirkstone-next:

#9838

Successfully created backport PR for scarthgap-next:

#9839

Successfully created backport PR for styhead-next:

#9840


[Question] How can it be used to serialize error?

I wonder how can I use it to return an error message with HTTP error?

JSONAPI only requires that a top level errors array be returned and has many optional member attributes that you may or may not find useful:
http://jsonapi.org/format/#error-objects
Therefore you should just be able to make an error serializer with as much of the spec that you find useful (code, title, detail, for instance)

@DVG thanks for chiming in and I agree with your approach. This library does not take an opinionated approach for serializing errors. You could optionally do something as simple as the below (untested) and still be within the json api spec.
data = { errors: [] }
data[:errors] << {id: "movie", title: "invalid title"}
render json: data, status: :unprocessable_entity

I feel like this question has been answered. I'm going to close this for now, please feel free to re-open if you disagree!

For anyone else reaching here like i did... i ended up implementing the following serializer. It supports nested model errors indexed. Manually tested, no rspec, so no guarantees
class ErrorSerializer
  def initialize(model)
    @model = model
  end

  def serialized_json
    errors = @model.errors.messages.map do |field, errors|
      errors.map do |error_message|
        {
          source: {pointer: "/data/attributes/#{field}"},
          detail: error_message
        }
      end
    end
    @model.class.reflect_on_all_associations.each do |relationship|
      @model.send(relationship.name).each_with_index do |child, index|
        errors << child.errors.messages.map do |field, errors|
          errors.map do |error_message|
            {
              source: {pointer: "/data/attributes/#{child.model_name.plural}[#{index}].#{field}"},
              detail: error_message
            }
          end
        end
      end
    end
    errors.flatten
  end
end

Additionally, if you like the JSONAPI error spec and want it for general use beyond errors within a model. You can drop something like this right in application_controller.rb
    # CUSTOM GENERAL EXCEPTION HANDLING
    # NOTE: This MUST come before any more specific exception handling. The order of definition is relevant!
    rescue_from StandardError do |e|
        logger.error "ApplicationController: GENERAL ERROR caught #{e}\n #{e.backtrace[0..5].join("\n")}"
        respond_to do |format|
            format.html { raise(e) }
            format.json {
                error_struct = {:errors => [
                    :status => '500',
                    :code => e.class.to_s,
                    :detail => e.message,
                ]}
                render json: error_struct, status: :internal_server_error
            }
            format.pdf { Rails.env.development? ? raise(e) : redirect_to(root_path, :flash => { :error => "Error rendering page as PDF file" }) }
        end
    end

(I threw in PDF to demonstrate the env conditional which I often find useful during dev)

It would be awesome to have an implementation of the errors in json api format!

module Api::V1
  class ApiController < ActionController::API

    around_action :handle_errors

    def handle_errors
      yield
    rescue ActiveRecord::RecordNotFound => e
      data = { errors: [] }
      data[:errors] << {code: 404, details: e.message}
      render json: data, status: :not_found
    rescue ActiveRecord::RecordInvalid => e
      data = { errors: [] }
      data[:errors] << {code: 422, details: e.message}
      render json: data, status: :unprocessable_entity
    rescue JWT::ExpiredSignature => e
      data = { errors: [] }
      data[:errors] << {code: 401, details: e.message}
      render json: data, status: :unauthorized
    end

  end
end

This was the pattern we used for rendering errors for this gem, compliant with the JSON API spec.

Alternatively consider using the jsonapi.rb gem which provides error handling for validation errors and other generic cases you can encounter:
https://github.com/stas/jsonapi.rb#error-handling
Since the work is heavily based on the fast_jsonapi and the feedback I could find here (hence the small codebase), it should be easy to start using it.
Let me know if you have feedback as well :bowing_man:
Related issues #102 #408

I come up with my own serializer
class ErrorSerializer
  attr_reader :resource, :errors
  alias_method :serializable_hash, :as_json
  alias_method :serialized_json, :to_json

  def initialize(resource, options = {})
    @resource = resource
    @errors = errors_for(resource).flatten
  end

  def id
    resource.id.to_s
  end

  def type
    resource.class.name.downcase
  end

  def serializable_hash(options = nil)
    {}.tap do |hash|
      hash[:id] = id if has_id?
      hash[:type] = type if has_id?
      hash[:errors] = errors
    end
  end

  def serialized_json(options = nil)
    serializable_hash.to_json(options)
  end

  private

  def has_id?
    @resource.respond_to?(:id)
  end

  def errors_for(resource)
    resource.errors.messages.map do |field, errors|
      build_hashes_for(field, errors)
    end
  end

  def build_hashes_for(field, errors)
    errors.map do |error_message|
      build_hash_for(field, error_message)
    end
  end

  def build_hash_for(field, error_message)
    {}.tap do |hash|
      hash[:source] = {pointer: "/data/attributes/#{field}"}
      hash[:detail] = error_message
    end
  end
end

@DVG thanks for chiming in and I agree with your approach. This library does not take an opinionated approach for serializing errors. You could optionally do something as simple as the below (untested) and still be within the json api spec.
data = { errors: [] }
data[:errors] << {id: "movie", title: "invalid title"}
render json: data, status: :unprocessable_entity

This is not JSON:API compatible actually
From https://jsonapi.org/format/#errors-processing

Error objects MUST be returned as an array keyed by errors in the top level of a JSON:API document.

Sorry for chiming it this late

This is not JSON:API compatible actually From https://jsonapi.org/format/#errors-processing

Error objects MUST be returned as an array keyed by errors in the top level of a JSON:API document.

I think this is exactly why this library should implement errors.


Right nav width on dynamic menu

Hello.
I am setting up my application menu via database using the ServiceProvider below:
public function boot(Dispatcher $events)
    {
        $events->listen(BuildingMenu::class, function (BuildingMenu $event) {

            $event->menu->add("modules");

            $menus = Pdr_Menu::whereNull("pai_id")->with("submenus")->get();

            foreach($menus as $menu){
                $event->menu->add([
                    "text" => $menu->nome,
                    "url" => $menu->url,
                    "icon" => $menu->icone,
                    "submenu" => $this->hasSubmenu($menu)
                ]);
            }
        });
    }

    private function hasSubmenu(Pdr_Menu $menu){
        $array = [];

        if($menu->submenus !== null){
            foreach($menu->submenus as $submenu){
                $array[] = [
                    "text" => $submenu->nome,
                    "url" => $submenu->url,
                    "icon" => $submenu->icone,
                    "submenu" => $this->hasSubmenu($submenu)
                ];
            }
        }

        if(empty($array)){
            return null;
        }

        return $array;
    }

My menu can have several submenus, in case I needed to do a recursive method to solve this, but that's beside the point.
I noticed that when setting up the menu like this, the menu size gets smaller, as shown in the images:
https://prnt.sc/ptse06
https://prnt.sc/ptse7f
Somebody can help-me?
Thanks! :)

@potreco is the issue actual or solved and can be closed?

From your images I would say you missed to load the OverlayScrollbars js/css files.


Improve backlogSize stats in the topic.

Motivation
When all subscriptions have no backlogs, but the backlog size of the topic stats is not 0. So this PR improves the backlog size calculation of the managed ledger.
Modifications
If all entries are consumed, return the ledger size as the consumed size.
Verifying this change
A new unit test added.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

Add label release/2.5.1 and remove label release/2.5.2


Small 'x' button for clear input text

How can we add the 'clear text input' button at the right side of text input? Is there an option for this or must be manually made?
Thanks!

Hi @brascene
Did you try to search on stackoverflow yet?

Check out clearButtonMode prop on <TextInput>.
You can pass this props to the component using textInputProps prop.


[User Management] User Profile

Is your feature request related to a specific problem?

Demonstrate that a user can see a profile page with all relevant information information about their own user.
To display on the user profile page: username, first/last name, a way to reset their password, a summary of the privileges assigned to them.
Demonstrate that the user has the ability to reset their password

Clarifying questions:


support run spoke agent outside of managed cluster

Signed-off-by: zhujian<EMAIL_ADDRESS>The registration-agent pod can be deployed on a separate cluster from the managed cluster, and the hub-kubeconfig-secret will be stored in the cluster where the registration-agent pod resides.
related issue: https://github.com/open-cluster-management-io/registration-operator/issues/158

todo:

[ ] add description and script to deploy registration agent in Hosted mode. (not contained in this PR)

cc @xuezhaojun @qiujian16

/assign @skeeey

/lgtm


NIFI-539 and  NIFI-3698: Add SCP and SSH Processors

Combination of NIFI-539 and NIFI-3698. Adds functionality for SCP and SSH remote execution processors.
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

I think this PR is a little big for testing/reviewing right now. Going to split it up into a few separate tasks.

Hi @patricker , Can we expect to have this added soon?
Not be be able to use SCP will be a blocker for us to adopt nifi.
Thanks for your involment.


[CSL-1968] Implement GET /api/v1/user-profile

This PR implements what was called /api/v1/profile in the old API.
@DominikGuzei you will see I have made a precise choice: the default in case no locale is set is en-US, as taken from:
https://github.com/input-output-hk/daedalus/blob/master/translations/translation-runner.js#L7
I hope that's correct! This is how it looks like in Swagger:

@adinapoli-iohk to be honest: i don't think we are using any profile server endpoint in Daedalus as we are saving that locally on the user's machine 😟
@nikolaglumac that's right isn't it?

If that's the case guys, even better -- the best code is the one you don't have to write 😉
Just let me know, and will scrap these for good!

@DominikGuzei that is correct. The problem was that saving or fetching info such as user locale from the backend was too slow - e.g. when application is starting we need to have this information straight away in order to show loading message in user's locale so we decided to save all profile info to the local storage layer.

Even better guys. Case closed 😉
Cheers!

@nikolaglumac that's even better.
Can we improve this communication in future for request removal if Daedalus UI decides not to use some endpoints (or features). That would help us maintain clean codebase

@akegalj of course we can and of course we should 👍


create sections for the OpenFloodAI website!

We are building an one-page website!
//create a section on upper left-corner name it as OpenFloodAI
//create a 5 section on upper right-corner
Home About Contribute Connect Community[slack-logo]

Wanted to contribute, but sas this been assigned to @emrizkiem already?

Hi @randydaniel Sure, Please check out the latest issue!


Add express / koa wrapper

Create a server.js file which allows running a standalone server.
Motivation: Not all of our users want to run their instance using lambda on AWS. Some just want a well-known express/koa server that they can run in their favourite environment.
Work needed: Create server.js file which allows running a standalone server with node server.js. The file must include the ./src/api_handler.js so is just a wrapper around existing functionality. If the routes can be read from serverless.yml even better, but not really a requirement
Acceptance criteria: A running server with the same functionality as the lambda version, so I can run it locally (with node server.js or npm start)

@mahim23 let me know if you run into any issue.

@ajunge was caught up in exams. Will try to send a PR by the weekend.

@ajunge Hey, so I ran into a few issues. eventMgr.js and uPortMgr.js use ES6 import which is not supported by Node LTS version. So should I change them to ES5 (require) imports to make it consistent throughout the project?
I thought of updating the current webpack config to transpile the files so that the ES6 imports can be used with the express server. So, would it interfere with the AWS Lambda setup (or launch process)?
Also, I'm having trouble with the KMS secret. I tried following the instructions in SECRETS.md but not sure if I'm on the right track as I'm not getting any output from these commands. Could you help me out with this?

Hi @mahim23

So should I change them to ES5 (require) imports to make it consistent throughout the project?
The current workflow transpile ES6 to be used in lambda (which is node6.10). So I prefer if you don't change that

I thought of updating the current webpack config to transpile the files so that the ES6 imports can be used with the express server. So, would it interfere with the AWS Lambda setup (or launch process)?
I think this won't interfere but we need to test

Also, I'm having trouble with the KMS secret. I tried following the instructions in SECRETS.md but not sure if I'm on the right track as I'm not getting any output from these commands. Could you help me out with this?
KMS secrets are for lambda only. Basically injects env vars in to the s3Mgr (in https://github.com/uport-project/lambda-caleuche/blob/master/src/api_handler.js#L61-L70 ).  So when the user runs express / koa, it should first setup the env var SECRETS to something like this:

 {"BUCKET":"caleuche-objects"}

Sorry for didn't make it clear earlier

@ajunge Since I'm not that familiar with the aws-sdk in node, I'm having some trouble integrating that part.
The AWS object needs the IAM credentials (Access Key ID and Secret Access Key), so should I take those as input from a separate aws-secrets.json file which is supposed to be made by the developer?
Also, since I'm supposed to pass the bucket name as SECRETS env variable in encrypted form (as its getting decrypted here), should I take the encrypted version of the SECRETS variable (similiar to what is present in secrets.SECRETS) from the same aws-secrets.json file? Or should I take the plain-text name of the bucket (again expected from the secrets file) and encrypt it inside server.js explicitly?

Hey, I've submitted a WIP PR and waiting for it to be reviewed to go further :)

Hi. Reviewing it now. Sorry for the delay

@mahim23 I need you to click on "Submit Work" on Gitcoin : https://gitcoin.co/issue/uport-project/lambda-caleuche/18/1801

Great work @mahim23 !


TST: cache predictions and features

To speed up tests, we cache the predictions of the model and the features extracted with openSMILE.

It indeed speeds up the test by a factor of ~10: https://github.com/audeering/w2v2-how-to/actions/runs/4540904472/jobs/8003545454


Update requirement for traderinteractive/filter-arrays

What does this PR do?

Add array-copy as an alias for TraderInteractive\Filter\Arrays::copy
Add array-copy-each as an alias for TraderInteractive\Filter\Arrays::copyEach
Add array-pad as an alias for TraderInteractive\Filter\Arrays::pad

Checklist

[  ] Pull request contains a clear definition of changes
[  ] Tests (either unit, integration, or acceptance) written and passing
[  ] Relevant documentation produced and/or updated

Coverage remained the same at 100.0% when pulling b04d835cacc2f37d3c1571a27ff36c03b36115a3 on chadicus:master into 2252d5eaca7a714b33cd977a98d0672b067240f0 on traderinteractive:master.


feat(dateFilter): add ordinal suffix option to date filter

I added the S character option for ordinal date suffixes, which lets you output dates with the "st", "nd, "rd" or "th". For example September the 3rd or December the 15th. (It seems like quite a few other people wanted it too.)
Cheers, Dave.

Closing as this can be implemented outside the core and it would require additional effort to get it to work with multiple locales effectively.


✨ Confirm dialog when opening URLs

This PR adds a confirmation dialog (in the form of a bottom sheet) that pops up when the user taps a URL, see screenshot below:

Confirmation dialog
Settings page

The user is given several options:

Cancel -- The URL will not be opened.
Confirm -- The URL is opened.
Trust this domain -- The app will not ask again for this particular domain.
Don't ask again -- The app will never ask again.

Remaining stuff to do:

[x] 💬 Show the dialog in all places a user-defined URL can be tapped.
[x] ⚙ Add a page in Application Settings to view and delete trusted domains.
[x] ♻ Better way of storing the trusted domains (currently using a single string, but should probably use a list).
[x] 🐛 Don't save the trust/don't ask status if the dialog is dismissed.
[x] 🕵♂ Improve the domain detection to only include the root domain (e.g. www.images.google.com -> google.com).
[x] ❓ Maybe mark some domains as always trusted (e.g. okuna.io). Wait until the Okuna trusted proxies list is available.

@lifenautjoe I've marked this as ready for review. I haven't pushed the license update yet, but all the code should be here.
One question: We talked about clearing the trusted domains list when logging out. This is currently not in since the user preferences in general aren't cleared on log out. Losing your list of trusted domains, and thus having to go through the "trust this domain" thing again for each, when logging out and then back in might be annoying. At the same time I can see why we don't want another person logging in to "inherit" the domain list.
Clearing it on log out isn't difficult so I can add that if we want. Another, slightly more difficult, option would be to prefix the preference namespace with the user's ID (unless that is a security issue for some reason), so that the app remembers each user's settings separately.
Of course, it does not feel very likely that multiple people keep logging in and out on the same phone, so maybe this is a non-issue in the first place?

Generated localisation files and LICENSE-3RD-PARTY. For the license, the full license text is too long to include in the file itself (IMO). I left a note with a link to the license, but we can of course add the full license to the repo instead if we wish.
Also, my previous comment on this PR still holds so don't forget to read that one.

I like the idea of preventing clicking on a suspicious domain, but if i understand i right the preferred domains are stored local on the device?
It's okay for the moment and until now. But I know that the lifetime of my current device will end and I will use okuna on multiple devices. Then I would be perfect if these settings will be synced in the future.

I like the idea of preventing clicking on a suspicious domain, but if i understand i right the preferred domains are stored local on the device?
It's okay for the moment and until now. But I know that the lifetime of my current device will end and I will use okuna on multiple devices. Then I would be perfect if these settings will be synced in the future.

Yeah, it's all stored locally at the moment. There are two reasons for this:

Massive server changes and re-factorings are coming up, so it's better to wait until after that.
Most settings will be synced eventually, so it will be easier to write the architecture for everything at once.

If I select, "Never ask again", I cannot tap "Trust this domain" or "Cancel" but if I have selected trust this domain, I can tap never ask again but not cancel.
This should allow tapping anywhere at all times, so people should be able to switch between the two choices and even cancel if they change their minds, this added friction might be annoying.

I did the "disable Trust this domain when Never ask again is selected" thing to make it consistent with how the filter pages work (select the Connections circle -> all other circle checkboxes are selected and disabled). Can see how it can cause friction here, though. Will change.

I also think we should clear the trusted domains list on logout, since its an edge case that people will use multiple accounts on a single device anyway, so if the edge case happens we should err on the safe side.

Makes sense 👌

@uiboy About clearing prefs on exit, I can either clear all user prefs (trusted domains, "never ask again" and comment order) or only the prefs added by this PR (trusted domains and "never ask again").
The former is a simple preferenceService.clear() call in UserService.logout(), the latter would require specialised code (either as preferenceService.clear(onlyUrlPrefs: true) or preferenceService.clearUrlPrefs()) to clear only what we change here.
What would be the preferred option?

I just updated this against develop. Doing so I noticed a couple of things that are missing and should be added before this is done:

[ ] The Trusted Domains list doesn't show a "nothing here" prompt when the list empty (no domains, or nothing matching the search phrase).
[ ] The Trusted Domains list should probably use "slide right to delete" list items to be consistent with other lists (@lifenautjoe @uiboy, opinion on this? See the screenshot in the PR description for current design of the list).


new config loader options

connects to #66

Coverage remained the same at 71.212% when pulling 8b83d08ed8ce6ff8063458efea4b966a4547acf7 on lholmquist:66-new-config-loader-options into f5b88c3e4267b81992d81f0f24cd9edda28dc2fb on bucharest-gold:master.


Remove support for TLS 1.1

Chrome and Firefox have recently removed TLS 1.1 (and 1.0) from their builds, in accordance with their announcement in 2018 to remove support in March 2020.
https://www.fxsitecompat.dev/en-CA/docs/2020/tls-1-0-1-1-support-has-been-removed/
https://www.chromestatus.com/feature/5759116003770368

Thanks!


UI of Searching screen has major design issues.

Upon hitting search, the app goes into "Searching" state. The screen for this looks like this,

The loading message appears at the bottom of the screen. The screen also seems to scroll down further.
Again, major whitespace on the app. Pickup and Drop location fields taking up huge amount of real-estate on the screen (almost 30%).
While searching, there should be a map with the pickup marker shown as an animated beacon.

While searching, there should be a map with the pickup marker shown as an animated beacon.
Above is a feature request. We will be implementing above in the search page


fix: escape html correctly

This unreverts #191. See the last commits for the fix, relating to not escaping the content of <script> tags.
Tested on a build on the Batteries docs

I see. That's why I suggested removing Coe String Html as this will reveal all such potentially buggy implicit conversion from String to Html.

I was a little conflicted before because it would be quite a burden to add this all over the place, but now that we have two different constructors and see the effect I do agree that it might be a good idea.

The problem is that removing that coercion effectively removes the <tag>text</tag> syntax. The   issue here is because the custom notation doesn't support escape sequences (it should). The script issue is because HTML is not XML, and so script tags don't contain text nodes; they contain some type of CDATA. Besides teaching the custom syntax to treat <script> differently I don't know a good fix for this.


I get this ominous error when trying to execute

Some more info about your setup? Python/Torch/ExllamaV2 versions? Did you install a wheel or compile yourself? Portable ComfyUI or not? What's in the model folder?

Windows
Python 310
torch                     2.3.0+cu121
exllamav2                 0.0.20+cu12
Installed a wheel
pip install https://github.com/turboderp/exllamav2/releases/download/v0.0.20/exllamav2-0.0.20+cu121-cp310-cp310-win_amd64.whl
Loads fine according to comfyui.
It is nested, as the readme says to clone in the models/llm folder.
Anyway I just made it the same structure as you said, so but I get the same error. Usually nested models are not an issue in comfy, I nest all my checkpoints in different folders depending on what they are for (1.5, turbo etc)

Sorry I totally forgot to just check the damn console when this message appeared, it has more info, some kind of "Memory error"?

Looking at your model folder, your output.safetensors file is only 1 KB while it should be around 6 GB, meaning the model wasn't downloaded correctly. Make sure your git is up to date and that you have lfs enabled, and that the download wasn't interrupted.
Try cloning again with:
git lfs clone https://huggingface.co/turboderp/Llama-3-8B-Instruct-exl2 -b 6.0bpw models/llm/Llama-3-8B-Instruct-exl2-6.0bpw

Also, make sure your card has enough VRAM to load this model, 6bpw with 8192 context and FP16 cache requires about 8 GB, 2048 context with Q4 cache ~ 6 GB. You can get lower bpw quants on HF if that isn't the case.

VRam isn't a problem but you're right about LFS! Mabye change that command in the readme? I am not a newbie to git but I just blindly expect readme's to work. Thanks!
Downloading now....

It is my understanding git lfs clone has been deprecated for a while and git clone downloads lfs objects by default now so this should be some configuration difference on your side.

I see, so perhaps I disabled it some time in the past.
It worked great, thanks so much!


Incompatibility with Cocoapods >= 1.0

Hello,
Some of my private pods use Smartling. And them stop working after update of cocoapods to 1.0.1. I'm unable to push podspec. It didn't pass the validation. The error is:
xcodebuild:  Smartling.i18n/Smartling.i18n/SmartlingLib.h:32:9: fatal error: 'SmartlingLib/SLLocalization.h' file not found

So, I've tried to validate Smartling podspec with cocoapods 1.0.1. And it fails.
pod spec lint https://raw.githubusercontent.com/Smartling/ios-i18n/master/Smartling.i18n.podspec

 -> Smartling.i18n (1.0.11)
    - ERROR | xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | xcodebuild:  /Users/alex/Library/Developer/Xcode/DerivedData/App-diyqsuoeckugulbyqokvsklkqffn/Build/Products/Release-iphonesimulator/Smartling.i18n/Smartling_i18n.framework/Headers/SmartlingLib.h:32:9: fatal error: 'SmartlingLib/SLLocalization.h' file not found
    - NOTE  | xcodebuild:  /var/folders/t0/tq3q_d5x2874hby2xtwswzjw0000gn/T/CocoaPods/Lint/App/main.m:3:9: fatal error: could not build module 'Smartling_i18n'
    - NOTE  | [OSX] xcodebuild:  /Users/alex/Library/Developer/Xcode/DerivedData/App-diyqsuoeckugulbyqokvsklkqffn/Build/Products/Release/Smartling.i18n/Smartling_i18n.framework/Headers/SmartlingLib.h:21:9: fatal error: 'UIKit/UIKit.h' file not found

Analyzed 1 podspec.

[!] The spec did not pass validation, due to 1 error.

I think it's related to 'dot' in library name. But I'm not sure.

I've fixed it. Please, check out the pull request


chore: Add CSI Migration support to the scheduler extender

What type of PR is this?
/kind chore

What this PR does / why we need it:
Enables CSI Migration when the scheduler extender is used by passing the proper feature gates flags to kube-scheduler and enabling required permissions on the scheduler extender service account.
Adds a e2e migration test pipeline to the Github actions.
Which issue(s) this PR fixes:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build 936726447

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+14.9%) to 52.029%

Totals

Change from base Build 936647790:
14.9%

Covered Lines:
2257

Relevant Lines:
4338

💛  - Coveralls


typo(MODEL_CARD): 'amateur' -> 'amateurs'

Thanks for publishing your research!

Accepted.

Thanks for catching this! As we released v1.0.0 we directly edited the changes.


chore(RingTheory.Polynomial.Basic): clean up porting notes

Lean is so much more ergonomic now.

maintainer merge

bors merge


[kdreports] new port

[x] Changes comply with the maintainer guide.
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

I got the following error when testing usage locally.
Severity	Code	Description	Project	File	Line	Suppression State	Details
Error		CMake Error at F:/kdp/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
  By not providing "FindQtCore.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "QtCore", but
  CMake did not find one.

  Could not find a package configuration file provided by "QtCore" (requested
  version 6.0.0) with any of the following names:

    QtCoreConfig.cmake
    qtcore-config.cmake

  Add the installation prefix of "QtCore" to CMAKE_PREFIX_PATH or set
  "QtCore_DIR" to a directory containing one of the above files.  If "QtCore"
  provides a separate development package or SDK, be sure it has been
  installed.		F:/kdp/scripts/buildsystems/vcpkg.cmake	859

  Could not find a package configuration file provided by "QtCore" (requested
  version 6.0.0) with any of the following names:

    QtCoreConfig.cmake
    qtcore-config.cmake

That's weird, QtCoreConfig.cmake should be in the qtbase package, which is an explicit dependency, and it is normally found automatically (I don't see any other port doing anything strange to find Qt6). I tried adding an explicit dependency on the widget component, perhaps that was the problem since I set "default-features": false. @jimwang118 Could you please try again?

That's weird, QtCoreConfig.cmake should be in the qtbase package, which is an explicit dependency, and it is normally found automatically (I don't see any other port doing anything strange to find Qt6). I tried adding an explicit dependency on the widget component, perhaps that was the problem since I set "default-features": false. @jimwang118 Could you please try again?

Still reporting the same error.

The documented CMake usage for Qt6 is:
find_package(Qt6 REQUIRED COMPONENTS Core)

https://doc.qt.io/qt-6/cmake-get-started.html
This is what is supported in vcpkg.

The documented CMake usage for Qt6 is:
find_package(Qt6 REQUIRED COMPONENTS Core)

https://doc.qt.io/qt-6/cmake-get-started.html
This is what is supported in vcpkg.

This is what the package is already doing, see https://github.com/KDAB/KDReports/blob/master/CMakeLists.txt#L118
It looks more like a problem in Qt6 port than in this... @jimwang118 Perhaps you are building on some untested platform/triplet? CI is passing on all tested platforms... Can you tell me what architecture are you building on, so that I can try reproducing it? Thanks

I just created a cmake project on VS, and then called usage to compile it, and the above problem was reported.

Does kdsoap work for you ? It's an existing port which is similar to kdreports

The kdsoap test is normal and can be used.

Found the bug, it should be fixed now, I'll fix it upstream as well

You found the typo in the right file now.
I still think that dependency lookup up in the project and in the exported config should follow the same pattern, i.e.
find_package(Qt6 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Core Widgets PrintSupport Xml)

should be paired with
find_dependency(Qt6 @QT_MIN_VERSION@ CONFIG COMPONENTS Core Widgets PrintSupport Xml)

which maps to exactly the same config lookup and targets, instead of requesting a different set of packages.
(Note that find_dependency is not to be used with REQUIRED.)

Usage test passed with x64-windows triplet.

Please resolve the code conflict.

Please resolve the code conflict.

Done. I also fixed the copyright file like I have done in #42671 for kdsoap


fix(client): export ResolveRoute

This type is returned by resolveRoute, so we'd better export it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.733%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
685

Relevant Lines:
1683

💛  - Coveralls


Update docker-compose.yml

I need only configurations to be persisted at each restart

HI,
We just released a full rebuild of our docker image 🎉
We are closing the issues and open PRs to start fresh.
If you feel like something is missing or want to add things feel free to open new PRs ! 💯


immer Dependency - Moderate Severity

Describe the bug
Based on CVE-2021-23436, immer dependency version can lead to a bypass of CVE-2020-28477 when the user-provided keys used in the path parameter are arrays. In particular, this bypass is possible because the condition (p === "proto" || p === "constructor") in applyPatches_ returns false if p is ['proto'] (or ['constructor']). The === operator (strict equality operator) returns false if the operands have different type. This issue is patched on version 9.0.6, it would be great to update the dependency to a more recent version to prevent this vulnerability.

This severity has been solved on the latest commit which update the dependency. Thanks!


A user can interact with time-series data about the artifact

Describe the feature you'd like to request
/artifacts/namespace/type/name, let the user browse time-series data about the artifact
Describe the solution you'd like
There's Plasmic widget already that we can connect to data providers and chart components.
Describe alternatives you've considered
N/A

https://github.com/hypercerts-org/oso/pull/143
Start dynamic routes here

Middleware proxying here
https://github.com/hypercerts-org/oso/pull/146

Functionality as of here
https://github.com/hypercerts-org/oso/pull/184


Traces dashboard view freeze/crash when viewing large span

When pressing View on the span I would like to look at:

The dashboard freezes and then after less than a minute I get the following stack-trace in the aspire console window.
warn: Microsoft.AspNetCore.Components.Server.Circuits.RemoteRenderer[100]
      Unhandled exception rendering component: An item with the same key has already been added. Key: f44344300
      System.ArgumentException: An item with the same key has already been added. Key: f44344300
         at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
         at Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.InternalGridContext`1.Register(FluentDataGridRow`1 row)
         at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()
fail: Microsoft.AspNetCore.Components.Server.Circuits.CircuitHost[111]
      Unhandled exception in circuit 'FYrVbbEoe_KzOf0rV5XKofGa7KRmaeLgNyH1iQ9uODQ'.
      System.ArgumentException: An item with the same key has already been added. Key: f44344300
         at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
         at Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.InternalGridContext`1.Register(FluentDataGridRow`1 row)
         at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()
warn: Microsoft.AspNetCore.Components.Server.Circuits.RemoteRenderer[100]
      Unhandled exception rendering component: A task was canceled.
      System.Threading.Tasks.TaskCanceledException: A task was canceled.
         at Microsoft.JSInterop.JSRuntime.InvokeAsync[TValue](Int64 targetInstanceId, String identifier, Object[] args)
         at Microsoft.JSInterop.JSRuntimeExtensions.InvokeVoidAsync(IJSRuntime jsRuntime, String identifier, Object[] args)
         at Microsoft.JSInterop.Implementation.JSObjectReference.DisposeAsync()
         at Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1.DisposeAsync()
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.<ProcessDisposalQueueInExistingBatch>g__GetHandledAsynchronousDisposalErrorsTask|79_0(Task result)
fail: Microsoft.AspNetCore.Components.Server.Circuits.CircuitHost[111]
      Unhandled exception in circuit 'FYrVbbEoe_KzOf0rV5XKofGa7KRmaeLgNyH1iQ9uODQ'.
      System.Threading.Tasks.TaskCanceledException: A task was canceled.
         at Microsoft.JSInterop.JSRuntime.InvokeAsync[TValue](Int64 targetInstanceId, String identifier, Object[] args)
         at Microsoft.JSInterop.JSRuntimeExtensions.InvokeVoidAsync(IJSRuntime jsRuntime, String identifier, Object[] args)
         at Microsoft.JSInterop.Implementation.JSObjectReference.DisposeAsync()
         at Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1.DisposeAsync()
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.<ProcessDisposalQueueInExistingBatch>g__GetHandledAsynchronousDisposalErrorsTask|79_0(Task result)

Aspire.Hosting version 8.0.0-preview.1.23557.2

cc @JamesNK

That's a lot of spans.
The span graph is displayed in a fluent data grid. Perhaps its virtualization could be used here.

Hmm, FluentUI randomly generates row IDs. It's a lottery every time it renders whether there is a conflict and error. The more rows the more tickets to the lottery 😬
https://github.com/microsoft/fluentui-blazor/blob/0536a0b78fd4e87dd58320a96ef0dfc6a00c997f/src/Core/Identifier.cs#L35
I'll log a bug with them.

I've implemented a fix for the grid where it will now use sequential numbers as row and cell ids. It is part of the preview packages we publish.

We need to update to the latest Fluent UI version to resolve this issue.

@adamint  please confirm if the package is upgraded and the fix works.

This appears not to reproduce anymore with the updated packages. @ThomasCronholm please tag me if you run into this again


[stdlib] Fix coding style of AdditiveArithmetic

Use explicit access modifiers instead of public extension inheritance.

@swift-ci Please smoke test


Updating bug for fields with no Name nor Id

When using some WYSIWYG like summernote, by default, contenteditable area has not Id nor Name, in this cases the script generates error in "escapeCssMeta()" when trying to do replace on undefined because the string arg is the result of "idOrName()" on line #1009.
PS : I dont know how the tests work nor how to create one... If you can send me some info about it I could do it.
DEMO ERROR : http://jsfiddle.net/3bpnw7uo/8/

@staabm This can be closed as it duplicates https://github.com/jquery-validation/jquery-validation/pull/2154 which has now been merged?

Good point, thx


BackgroundGeolocation.onProviderChange() not triggered on Android after increasing permission level

Your Environment

Plugin version: 4.9.3
Platform: Android
Device OS version: Android 13
Device manufacturer / model: Google Pixel 4a
XCode version: Version 14.1 (14B47b)
Capacitor info (npx cap doctor)

💊   Capacitor Doctor  💊

Latest Dependencies:

  @capacitor/cli: 4.5.0
  @capacitor/core: 4.5.0
  @capacitor/android: 4.5.0
  @capacitor/ios: 4.5.0

Installed Dependencies:

  @capacitor/core: 4.5.0
  @capacitor/cli: 4.5.0
  @capacitor/android: 4.5.0
  @capacitor/ios: 4.5.0

[success] iOS looking great! 👌
[success] Android looking great! 👌

Plugin config provided to #ready:

desiredAccuracy: BackgroundGeolocation.DESIRED_ACCURACY_HIGH,
distanceFilter: 10,
stopTimeout: 5,
debug: false,
logLevel: BackgroundGeolocation.LOG_LEVEL_ERROR,
stopOnTerminate: false,
startOnBoot: true,
url: environment.locationEndpoint,
locationAuthorizationAlert: {
	titleWhenNotEnabled: text1,
	titleWhenOff: text2,
	instructions: text3,
	cancelButton: 'no',
	settingsButton: 'yes'
},
locationAuthorizationRequest:'always',
backgroundPermissionRationale: {
	title: text4,
	message: text5,
	positiveAction: text6,
	negativeAction:text7,
},
extras: {
	...
},
schedule: this.schedule,
scheduleUseAlarmManager: true,

Expected Behavior
BackgroundGeolocation.onProviderChange() should trigger, with a status = 3 ( as in iOS is happening )
Actual Behavior
BackgroundGeolocation.onProviderChange() is NOT triggered at all.
Steps to Reproduce

1: On first use, user ( having location services ON ) chooses to NOT grant any kind of permission for location or physical activity.
2: Later on, they go to Android settings -> Apps -> My app -> permissions -> location and select "Allow all the time".
Context

To act upon permission level increasing.
Debug logs

Logs
no errors, no logs as the method is not triggered.

Unfortunately, Android does not trigger an event when user modified permissions in Settings.

@christocracy it does though when using the "backgroundPermissionRationale" flow. Couldn't the same apply to the other scenarios ( like from "Don't allow" or "Allow only while using the app" to "Allow all the time" )?

People have asked this question dozens of times in the past.
No, Android does not fire events when user changes permission level in Settings.

Thanks!

You are free to call getProviderState() as desired, to query the current permission state.


Cirrus: Support special-case modes of testing

Previously libpod CI was fairly straight-forward, run unit and
integration tests in a standard set of 3 VMs.  Off on the side was a
single special case of running tests as an ordinary user.  There is a
desire to stop using the PAPR system to support testing inside of a
container.
Since having two special cases potentially invites more
down the road, make provisions to handle them more gracefully.  This
commit introduces an environment variable:  $SPECIALMODE.  It's
value has the following meanings within the CI scripts:
Mode 'none': Nothing special, business as usual (default)
Mode 'rootless': Rootless testing
Mode 'in_podman': Build container, run integration tests in it.
This will make adding additional special-cases later easier, as well as
extending the special cases in a Matrix across multiple OS's.
Signed-off-by: Chris Evich<EMAIL_ADDRESS>

LGTM

LGTM!

/approve

/lgtm

/hold

Ref: first attempt passing tests

/lgtm

/hold cancel

/lgtm