Create a Bloom Filter from an iterator

This PR simply adds the option of creating a Bloom Filter directly from an iterator. I found this useful in my own code, so perhaps someone else will also find it useful.

Codecov Report

Merging #637 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #637      +/-   ##
===========================================
+ Coverage    82.09%   82.14%   +0.04%
===========================================
  Files          111      111
  Lines         5156     5157       +1
  Branches       457      468      +11
===========================================
+ Hits          4233     4236       +3
+ Misses         923      921       -2

Impacted Files
Coverage Δ

.../main/scala/com/twitter/algebird/BloomFilter.scala
94.34% <100%> (+0.89%)
:arrow_up:

.../main/scala/com/twitter/algebird/Applicative.scala
61.29% <0%> (-3.23%)
:arrow_down:

...c/main/scala/com/twitter/algebird/MapAlgebra.scala
76.69% <0%> (-0.98%)
:arrow_down:

...src/main/scala/com/twitter/algebird/Interval.scala
69.04% <0%> (ø)
:arrow_up:

.../main/scala/com/twitter/algebird/Approximate.scala
90.32% <0%> (+1.61%)
:arrow_up:

.../main/scala/com/twitter/algebird/Successible.scala
91.66% <0%> (+4.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cacc4...976386a. Read the comment docs.

looks great!

Thanks for this, @johandahlberg, and thanks for the test!


Changes Supporting The Create Subtraction Workflow

Run the create subtraction workflow in k3s

:tada: This PR is included in version 0.5.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update stable version in repo from 1.0.0 to 2.0.1

Think about update stable version to 2.0.1
Version: stable=1.0.0 (2150 days old) => latest=2.0.1 (15 days old)
Installs: stable=467 (89.12%), latest=36 (6.87%), total=524
Click to use developer portal
Click to edit
Note: This is an automatically generated message and not personally authored by bluefox!

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 2.0.1 but the current stable version is already 2.0.1.
So this issue should be closed.


Add more to MvcCoreServiceCollectionExtensionsTest

2nd half of #5554
follow-on to #5540 PR

Includes @danroth27's changes from #5540 but I've rebased his commit. Ignore that bit.

/to @javiercn
@Eilon is this the type of testing you wanted to see?

To answer the main question: yes, this is pretty much what I had in mind!

:up::date:

48546db


Pion WebRTC v4 doesn't work with sfu-ws on Firefox

I'm not sure where to file this bug, so I'm filing it here.
If you try running the sfu-ws sample here and change it to use Pion WebRTC v4 instead:
import (
//...
"github.com/pion/webrtc/v4"
)
It will work on Chrome, but not Firefox. Specifically, it works with 2 participants but not more for some reason. It worked with v3.
Your environment.

Version: v4
Browser: Firefox 129.0.2 on macOS
Other Information - Report below.

What did you do?
Try using Pion WebRTC v4 with sfu-ws or any other SFU-like app.
What did you expect?
I expected 3 participants to work. Instead, one participant successfully connect, but others just freeze or slow down significantly.
What happened?
Taking a look at about:webrtc-internals shows this:

As you can see, only one participant is able to both send and receive VP8 when we have 3 participants.
A full report from a peer who froze is below:
debug.json
Thanks!

Sorry I didn't solve this sooner @okyanusoz!
pion/webrtc@v4 enables Simulcast by default. Pion uses different default values for extension headers. This meant that Pion was sending packets with invalid receiever feedback and breaking FireFox's bandwidth estimation


User/default/vsix split

This splits the VSIX extension into C++ and C# components.
Doing this improves the developer experience, because it relaxes the requirement to have both the C# and C++ toolsets installed. This is also a requirement for us to get included as a Visual Studio component. (Hence, the Component subfolders).
At the moment, I'm leaving the original VSIX intact, because I want to have a discussion about what to do with it. I favor deprecating it for 1.0 and directing devs towards the new language-specific extensions. This also allows us to shed the original extension's baggage where its Id and Url still had "ProjectReunion" and couldn't be changed.
One other thing, with this extension, I've been battling a weird MSBuild issue that I can't quite root-cause. Using MSBuild's binary logging, and determined that all the *.vsixmanifest files in subfolders of the project file are being indiscriminately added as items to the project. Or to put another way, given this structure:
+- extension.csproj
   +- Component
      |- source.extension.vsixmanifest
   +- Standalone
      |- source.extension.vsixmanifest

Both the Component and Standalone files are being added as Project Items (verified in the binlog). This can cause another part of the build process to simply pick one of the files as "the" manifest for some subset of the build process. I've combed through our project/props/targets files to find and explanation and I've come up empty. It's worth noting that we're using this same pattern in both cppwinrt and (Single-Project MSIX)[https://docs.microsoft.com/en-us/windows/apps/windows-app-sdk/single-project-msix?tabs=csharp-vs2019], where it apparently works.
I've gotten past it for the moment in the C++/C# split by putting each proj into its own subfolder (before that, all the projs were in the Extensions folder, and they were all grabbing each others vsixmanifest, which would break the build).
I'll continue to debug that issue as I work on adjusting the Component versions, but I'm sending up the Bat Signal in case somebody has seen a similar issue and can help me figure it out.

/azp run

One other thing, with this extension, I've been battling a weird MSBuild issue that I can't quite root-cause. Using MSBuild's binary logging, and determined that all the *.vsixmanifest files in subfolders of the project file are being indiscriminately added as items to the project.

My bet is that this is an intersection of:

The VSIX project is a .NET SDK-style project
The glob pattern for the None default include used by .NET SDK-style projects
The fact that the invocation of the FindSourceVsixManifest task passed in the None itemgroup as the set of items to consider, and the task itself simply returns the first item named source.extension.vsixmanifest.

  <Target Name="FindSourceVsixManifest"
      Condition="'$(CreateVsixContainer)' == 'true' or '$(CopyVsixManifestToOutput)' == 'true'">
    <FindVsixManifest ItemsToConsider="@(None)"
              ProjectName="$(MSBuildProjectName)">
      <Output TaskParameter="VsixManifest" ItemName="SourceVsixManifest"/>
    </FindVsixManifest>
  </Target>

Given your (necessary) changes to the repository ID used by the C++ templates, there's not much point in keeping this project... any new VSIX you create with it is going to be unable to create C++ projects.

Refers to: dev/VSIX/Extension/Original/WindowsAppSDK.Extension.csproj:1 in 3af171d. [](commit_id = 3af171d23f9fe1c4929823008a43d7fa385aa2e1, deletion_comment = False)

One other thing, with this extension, I've been battling a weird MSBuild issue that I can't quite root-cause. Using MSBuild's binary logging, and determined that all the *.vsixmanifest files in subfolders of the project file are being indiscriminately added as items to the project.

My bet is that this is an intersection of:

The VSIX project is a .NET SDK-style project
The glob pattern for the None default include used by .NET SDK-style projects
The fact that the invocation of the FindSourceVsixManifest task passes in the None itemgroup as the set of items to consider, and the task itself simply returns the first item named source.extension.vsixmanifest.

  <Target Name="FindSourceVsixManifest"
      Condition="'$(CreateVsixContainer)' == 'true' or '$(CopyVsixManifestToOutput)' == 'true'">
    <FindVsixManifest ItemsToConsider="@(None)"
              ProjectName="$(MSBuildProjectName)">
      <Output TaskParameter="VsixManifest" ItemName="SourceVsixManifest"/>
    </FindVsixManifest>
  </Target>

I wasn't aware of the glob pattern for .NET projects. That's another nice bit of evidence to build up a better picture, but it doesn't help me understand why this issue isn't afflicting the cppwinrt or single-project MSIX VSIXs.
I don't watn to waste much more time digging into this, so unless somebody has some inspiration, I'll probably just continue separating the Component/Standalone projects into their own subfolders with

Given your (necessary) changes to the repository ID used by the C++ templates, there's not much point in keeping this project... any new VSIX you create with it is going to be unable to create C++ projects.
Refers to: dev/VSIX/Extension/Original/WindowsAppSDK.Extension.csproj:1 in 3af171d. [](commit_id = 3af171d, deletion_comment = False)

I'm going to remove all the templates and content from that project, but keep it around a little longer. Just long enough to decide if we're deleting, deprecating, or abandoning the existing extension (and finalizing the deprecation text).

Neither of those projects is an SDK-style project, so they don't have the globbing pattern. Your two options are:

Place the individual .csprojs low enough in the directory hierarchy that there is only single sibling/descendant source.extension.vsixmanifest
Add the following property to disable the default None globbing (note that you'll have to manually specify all None items yourself): <EnableDefaultNoneItems>false</EnableDefaultNoneItems>

In reply to: 904136891

Neither of those projects is an SDK-style project, so they don't have the globbing pattern. Your two options are:

Place the individual .csprojs low enough in the directory hierarchy that there is only single sibling/descendant source.extension.vsixmanifest
Add the following property to disable the default None globbing (note that you'll have to manually specify all None items yourself): <EnableDefaultNoneItems>false</EnableDefaultNoneItems>

In reply to: 904136891

Thanks, that helped me get it working. Got the new updates pushed.

/azp run


Aqara QBKG03LM - Warning message on ZHASwitch at Homebridge-Hue initialization

Issue
Warning message for lumi.ctrl_neutral2 for an AQARA QBKG03LM (Double rocker wall switch no neutral)
Is this warning message caused by a problem on DeconZ end (e.g. incomplete support of Aqara device) or on homebridge-hue end with the querying of the deconz api?
Log Messages
Dec 16 20:19:39 homebridge homebridge[5944]: [12/16/2019, 8:19:39 PM] [Hue] Phoscon-GW: /sensors/26: ZHASwitch "lumi.ctrl_neutral2"
Dec 16 20:19:39 homebridge homebridge[5944]: [12/16/2019, 8:19:39 PM] [Hue] Phoscon-GW: /sensors/26: warning: ignoring unknown ZHASwitch sensor {"config":{"on":true,"reachable":true,"temperature":3300},"ep":4,"etag":"b39b5d878a1976ce8a4722abd1664a4f","manufacturername":"LUMI","mode":1,"modelid":"lumi.ctrl_neutral2","name":"lumi.ctrl_neutral2","state":{"buttonevent":1002,"lastupdated":"2019-12-16T16:02:29"},"swversion":"04-25-2018","type":"ZHASwitch","uniqueid":"00:15:8d:00:03:a2:d2:29-04-0006"}

homebridge-hue does not support the wireless switch function of the lumi.ctrl_neutral switches.  The wired switch function is supported as a light.
Are you using the switch with the buttons decoupled from the wired output?

Thank you Erik for your switft reply.
I did not decouple the buttons, I only paired the switch with DeconZ and moved on.

Then there doesn’t seem a need to expose the wireless switch function to HomeKit?

So all in all this warning message is justified by the unsupported wireless switch function, I should therefore move the sensors/26 to the blacklist to avoid such warning message in the future or is there a better way?

Or simply ignore the warning.


Add status indicator to transfer modal

This PR addresses this issue: link
This PR will query for the IBC status of a chain and display if the chain is congested or not, informing the user at the step it becomes relevant to them if they will experience delays in the transfer or not.
Currently this PR is a draft.

[ ] Add query
[ ] update view based on status

Also seems like there's build errors rn

Each map store would have these as the query URLs:
withdraw => https://api-osmosis.imperator.co/ibc/v1/source/counterPartyChainID/destinationosmosis-1?minutes_trigger=-1
deposit => https://api-osmosis.imperator.co/ibc/v1/source/osmosis-1/destinationcounterPartyChainID?minutes_trigger=-1
You'd just replace counterpartyChainID with whatever the caller passes.

@etian511
I made a branch with what I was thinking regarding a single store:
https://github.com/osmosis-labs/osmosis-frontend/blob/5533a57672af62301d02abb3085e091d0fa6e7bf/packages/stores/src/queries-external/ibc-status/index.ts#L9-L44

@etian511
I made a branch with what I was thinking regarding a single store:
https://github.com/osmosis-labs/osmosis-frontend/blob/5533a57672af62301d02abb3085e091d0fa6e7bf/packages/stores/src/queries-external/ibc-status/index.ts#L9-L44

ah ok this makes much more sense! Thanks Jon!


More support for macOS

Thank you for the great tool!!
Currently:

Release x86 macOS binary.
Tested on arm64 (ci). (macos-latest is macOS 14 Arm64, ref: actions/runner-images#available-image)

This PR allows testing on x86 and adds arm64 releases.
I have tested this on both x84 and arm64.

Thanks for the PR! Only the latest version of Go needs to be supported, if it makes things easier.

Thank you for your quick response!
I have updated the dependency versions.
I could not understand why CI was failing. I hope this update will solve the problem...

I'm sorry, I didn't know that macos-14-large needs to payment.
I will remove it.

I wasn't aware of the macos-14-large payment either.
Thanks for the work on this PR. :+1:

Merged, thanks!


NullReferenceException?

I'm getting a null reference exception on trying to access UserDialogs.Instance with Xamarin.
Things were working before, so I'm not sure what happened (maybe related to OS 10.1.1 update + Xcode update - 8.2).
Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

X iOS
[] Android
[] UWP
[] PCL

Version of OS(s) listed above with issue
10.1.1
Version of ACR UserDialogs Library
6.3.1.
Expected Behaviour
UserDialogs.Instance.ShowLoading();
should not crash...
Actual Behavior
If applicable, please include entire exception - type, message, stacktrace
crash.
Stack:
System.NullReferenceException: Object reference not set to an instance of an object
at BigTed.ProgressHUD.PositionHUD (Foundation.NSNotification notification) [0x000cf] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.iOS\ProgressHUD.cs:788
at BigTed.ProgressHUD.ShowProgressWorker (System.Single progress, System.String status, BigTed.ProgressHUD+MaskType maskType, System.Boolean textOnly, BigTed.ProgressHUD+ToastPosition toastPosition, System.String cancelCaption, System.Action cancelCallback, System.Double timeoutMs, System.Boolean showContinuousProgress, UIKit.UIImage displayContinuousImage) [0x0023f] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.iOS\ProgressHUD.cs:327
at BigTed.ProgressHUD+<>c__DisplayClass18_0.b__0 () [0x00000] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.iOS\ProgressHUD.cs:109
at Foundation.NSActionDispatcher.Apply () [0x00000] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/src/Foundation/NSAction.cs:57
at at (wrapper managed-to-native) ObjCRuntime.Messaging:void_objc_msgSend_IntPtr_IntPtr_bool (intptr,intptr,intptr,intptr,bool)
at Foundation.NSObject.InvokeOnMainThread (System.Action action) [0x00007] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/src/Foundation/NSObject2.cs:560
at BigTed.ProgressHUD.Show (System.String status, System.Single progress, BigTed.ProgressHUD+MaskType maskType, System.Double timeoutMs) [0x0002a] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.iOS\ProgressHUD.cs:109
at BigTed.BTProgressHUD.Show (System.String status, System.Single progress, BigTed.ProgressHUD+MaskType maskType) [0x00000] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.iOS\BTProgressHUD.cs:11
at Acr.UserDialogs.ProgressDialog+<>c__DisplayClass17_0.b__0 () [0x00012] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.iOS\ProgressDialog.cs:108
at Foundation.NSActionDispatcher.Apply () [0x00000] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/src/Foundation/NSAction.cs:57
at at (wrapper managed-to-native) ObjCRuntime.Messaging:void_objc_msgSend_IntPtr_IntPtr_bool (intptr,intptr,intptr,intptr,bool)
at Foundation.NSObject.InvokeOnMainThread (System.Action action) [0x00007] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/src/Foundation/NSObject2.cs:560
at Acr.UserDialogs.ProgressDialog.Refresh () [0x00091] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.iOS\ProgressDialog.cs:104
at Acr.UserDialogs.ProgressDialog.Show () [0x00007] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.iOS\ProgressDialog.cs:64
at Acr.UserDialogs.AbstractUserDialogs.Progress (Acr.UserDialogs.ProgressDialogConfig config) [0x0001c] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.Interface\AbstractUserDialogs.cs:114
at Acr.UserDialogs.AbstractUserDialogs.Loading (System.String title, System.Action onCancel, System.String cancelText, System.Boolean show, System.Nullable1[T] maskType) [0x00000] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.Interface\AbstractUserDialogs.cs:82   at Acr.UserDialogs.AbstractUserDialogs.ShowLoading (System.String title, System.Nullable1[T] maskType) [0x0000e] in C:\dev\modules\userdialogs\src\Acr.UserDialogs.Interface\AbstractUserDialogs.cs:69
at ClimbTag.DialogService.ShowLoading () [0x00010] in /Users/shayo/Projects/ClimbTag/Services/DialogService.cs:11
at ClimbTag.GymSelectPage..ctor () [0x0003d] in /Users/shayo/Projects/ClimbTag/Views/GymSelectPage.xaml.cs:69
at ClimbTag.App..ctor () [0x0001e] in /Users/shayo/Projects/ClimbTag/App.xaml.cs:62
at ClimbTag.iOS.AppDelegate.FinishedLaunching (UIKit.UIApplication app, Foundation.NSDictionary options) [0x0006d] in /Users/shayo/Projects/iOS/AppDelegate.cs:78
at at (wrapper managed-to-native) UIKit.UIApplication:UIApplicationMain (int,string[],intptr,intptr)
at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/src/UIKit/UIApplication.cs:79
at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x00038] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/src/UIKit/UIApplication.cs:63
at ClimbTagApp.iOS.Application.Main (System.String[] args) [0x00008] in /Users/shayo/Projects/iOS/Main.cs:19

Read the FAQ.  This question has been answered many times and nothing has changed

Wow. Super fast response. You are right. Sorry. Completely missed the FAQ page

I Also have this error. I've read the FAQ. No problems in Android and get this exception in iOS. I'm using MvvmCross so in my App.cs I have the
Mvx.RegisterSingleton(() => UserDialogs.Instance);
and in the debugger I see it's called before the call to the UserDialogs.Loading().
No clue what is wrong here.


Filter out by attribute in a related entity.

Hi,
I just wondering (maybe exists and I can see it in the doc). Is there a way to filter out by an attribute in a entity related to the main one? e.g. Articles and Comments. I want to do something like Articles->Comments->where('title','Hello world')->get(). So this should return the articles where the tittle of the comment says "Hellow world".-
Thanks!!

You can create in model Articles like
class Articles extends Elegant\Model {
  protected $table = "article";

  function comments()
  {
    return $this->belongsToMany('Comments');
  }
}

Controller
$comments = $article->comments()->where('title', 'Hello World')->get();
foreach($comments as $comment)
{
  echo $comment->title;
}

reff


After model.fit(para default), the model.predict() uses the last updated model weights to perform predicting?

When the model.fit() performed, I didn't save model, then using predict(), the weight used in predict() is the last epoch in fit() or not? Or the fit() will auto save a best model to perform predict()?

Yes, it uses the weight from the last epoch. If you want to use the best weights, use SaveModelCallback() where you can set save_best_only=True and you can define the best model based on any metrics included in .compile or just simply the loss function.
After training, you should be able to see the weights file saved based on the file path defined by you when you instantiate that callback. Load the model with those weights and you can perform predict() with the best weights after that.

@Eadith Moving this issue to closed status as there has been no recent activity, in case you still face the error please create a new issue.Thanks!


cmd/go: module mode doesn't work without go.mod

What version of Go are you using (go version)?
$ go version
go version go1.10.3 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
Debian Stretch
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/${USER}/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/${USER}/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build573429602=/tmp/go-build -gno-record-gcc-switches"

What did you expect to see, what did you see instead?
$ go build -o bin/thing cmd/hello-world/main.go
$ vgo build -o bin/thing cmd/hello-world/main.go
go: cannot determine module path for source directory /home/${USER}/work/tools (outside GOPATH, no import comments)

Maybe I'm wrong here, and I've just missed some bit of documentation. But I was originally expecting the following to work:
$ vgo build cmd/hello-world/

Is there currently no implementation to specify a directory beyond the cwd? As shown above, even the behavior of the old go build path/to/main.go no longer works with vgo. Is there a plan for the top level directory or specifying go.mods to build from an outside directory?

@rsc @bcmills @ianlancetaylor

We haven't worked out the story for what to do when no go.mod can be found. There will probably need to be a mop-up go.mod somewhere like GOPATH/src/go.mod.

Related to #24250 in that go get and go run working outside of a module are being defined in that issue.

go build some/directory/ can't work without a module definition: the package path is observable at run-time (e.g. using the reflect package), and the package path depends on the module path.
go build some/file.go can and probably will, since that already synthesizes a fake package (and hence doesn't care about paths). (See the current draft behavior in CL 148517.)
Closing as a duplicate of #24250: it's not precisely the same issue, but shares the same fix.


Api simplification

Add some API simplification for test_lib and their documentation.

grade_function : same as test_function except texts for report headers and set_progress texts are pre-built. Enables shorter graders.

remove test_function_against: useless now since solution.ml need to contain every graded functions.

@lyrm Can you rebase your branch please?

@lyrm There seems to remain a conflict to solve.


Help wanted

I am having trouble with this library, i used it in my previous project and it worked perfectly.
But in my current project,  when i open location intent, it is lagging and cause not responding error, this is being when internet connection is on, when i switch off internet connection, it work well. Can you help me what's the cause of this?

Hi @RegisSaffi !
Sorry for replying late. Please could you send me more info about how are you using the library?

Which version of play services are you using?
Version of the library?
Version of Support library?
What kind of internet connection? Wifi? or 4g?
How are you initializing the library? Are you sending any parameter?

Many thanks!

Hey sir,
The version of library i am using is 5.0.0
Version of play services is 16.0.0
Version of support library is 16.1.0
Connection is either WIFI or cellular ,
I have initialized the library correctly
Device i am using for test is TECNO spark k7 with android 7.0
The issue: When i open location picker activity without internet connection, it lags and cause the whole system to lag until i make "force stop" or switch off internet.
When internet is switched off, it work well(using cached data i think)
When i open it without internet connection, it work well and use cached data perfectly.
Problem is when internet is ON, either WIFI or cellular data connection

@RegisSaffi let me check it. Thanks for the info!


Refactor build system

Main goals would be to speed up and simplify.
Python is already used to detect dependencies, instead of generating a lot of files in .deps it could just write out the dependencies and build rules from python. I think this would remove a lot of redirection and speed up build time.
Another idea would be to put all generated files in a separate results directory to remove the need of exclude generation.

Options to consider;

Custom Python scripts which just generate Makefiles
Custom Python scripts which generate Ninja
meson
waf

I attempted to create a meson build script here -> https://github.com/mithro/symbiflow-arch-defs/blob/meson/meson.build

I /really/ want to use waf -- but my spider sense is saying that we will regret that choice 6 months from now.

I think we should also consider cmake as it is used by Verilog-To-Routing and the prjxray -- but I really dislike it...

We should also consider using conda environments for doing the env / conda stuff too...


Upgrade to 1.25.0-8.1.pre beta version, when debug mode is turned on, the app will crash

Upgrade to 1.25.0-8.1.pre beta version, when debug mode is turned on, the app will crash
flutter version:
Flutter 1.25.0-8.1.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 8f89f6505b (7 days ago) • 2020-12-15 15:07:52 -0800
Engine • revision 92ae191c17
Tools • Dart 2.12.0 (build 2.12.0-133.2.beta)

exception info:
Build fingerprint: 'OnePlus/OnePlus7Pro_CH/OnePlus7Pro:10/QKQ1.190716.003/2007240000:user/release-keys'
Revision: '0'
ABI: 'arm64'
Timestamp: 2020-12-23 18:12:44+0800
pid: 7906, tid: 8088, name: 1.ui  >>> com.tomato.flutter_module.host <<<
uid: 10796
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
Cause: null pointer dereference
    x0<PHONE_NUMBER>000000  x1<PHONE_NUMBER>000000  x2<PHONE_NUMBER>5df980  x3<PHONE_NUMBER>5df990
    x4<PHONE_NUMBER>5df950  x5<PHONE_NUMBER>5df890  x6<PHONE_NUMBER>5df910  x7  6c6b6a62ff776463
    x8<PHONE_NUMBER>000000  x9  00000075af25ecc0  x10 00000075af37c810  x11<PHONE_NUMBER>00001a
    x12<PHONE_NUMBER>00001a  x13<PHONE_NUMBER>270000  x14<PHONE_NUMBER>000108  x15 0000aab286e992ff
    x16 00000075af2adc00  x17 000000769fce1350  x18 00000075ab2aa000  x19 00000075ab72da88
    x20 00000075ab72d6d8  x21<PHONE_NUMBER>000000  x22<PHONE_NUMBER>000000  x23 00000075ab72d6f8
    x24<PHONE_NUMBER>5df980  x25<PHONE_NUMBER>5df750  x26 000000759b551800  x27<PHONE_NUMBER>3b40c0
    x28<PHONE_NUMBER>000000  x29<PHONE_NUMBER>00003d
    sp  00000075ab72d680  lr  00000075aef5a3dc  pc  00000075aef5a3e0
backtrace:
      #00 pc<PHONE_NUMBER>7183e0  /data/app/com.tomato.flutter_module.host-uoKI7rG4ePdoIeWh5sLZow==/lib/arm64/libflutter.so (BuildId: 9749f3c368c80b9282d5ea8491b15a9c229ed312)
      #01 pc<PHONE_NUMBER>1df98c  [anon:libc_malloc]

Hi @stoneLee81
This seems to be https://github.com/flutter/flutter/issues/72627
Can you please upgrade to the latest  dev and try again
flutter channel dev
flutter upgrade --force
flutter doctor -v
If the problem persists, Can you please provide your flutter doctor -v with the upgrade and flutter run --verbose logs, and a minimal complete reproducible code sample?
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Context Propagation: use simpler words and better examples

URL
https://opentelemetry.io/docs/concepts/context-propagation/
Description
Still  there is room for using the simple words and better examples

thank you for your feedback @srinivasulu-N

In general, anything to do with Contexts is super confusing, even after having read some of the sdk impmentations.

In general, anything to do with Contexts is super confusing, even after having read some of the sdk impmentations. maybe concrete examples with nothing implicit.

thanks for the additional feedback, @jdougan

Thinking about it some more, a skeletal implementation in C89 (or something at a similar semantic level), where you have to implement contexts manually and pass them around explicitly would probably give a better idea of the desired data flow.
/* C89 implementation */

// initialized elsewhere
TracerProvider tpRoot;

void exampleApiCall(ApiResult *apiResult)
{
	// fns have output on the left of the empty comment, input on the
	// right.
	Tracer tr;
	Context trCtx, innerCtx, outerCtx;
	Span spanOuter, spanInner;
	ApiQuery apiQuery;

	getTracer(&tr, &trCtx,/**/ &tp, "example:ApiCall:");

	startSpan(&spanOuter, &outerCtx,/**/ trCtx, "outer-span-apicall");

	setupApiCall(&apiquery, "queryString", &outerCtx);

	startSpan(&spanInner, &innerCtx,/**/ outSpanCtx, "inner-span-apicall");

	someApiCall(apiResult, /**/ apiQuery, &innerCtx);

	endSpan(&spanInner);
	cleanupSpan(&spanInner);

	teardownApiCall(&apiQuery, /**/ &outerCtx);

	endSpan(&spanOuter);
	cleanupSpan(&spanOuter);

	cleanupTracer(&tr);
}

We have some example code in the language specific documentation:
https://opentelemetry.io/docs/languages/js/propagation/#manual-context-propagation
We could copy from that, or link to it


Sprite ButtonsNew extension:

Description
Changes your sprites depending on weather you hover over them or press them.
Easy even condition: find out weather a sprite is clicked or being pressed.
The extension is fully customizable!
Define how much the button moves when clicked, weather it changes animation when clicked, if it responds only to Left mouse clicks or other Mouse clicks etc. ...
How to use the extension
No response
Checklist

[X] I've followed all of the best practices.
[X] I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
[X] I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?
Reviewed
Example file
Sprite Button Sample Project.zip
Extension file
Sprite_Buttons.zip

Closing as duplicate of #540


How to subscribe from replayId ?

I am getting "400::The replayId {1553783} you provided was invalid.  Please provide a valid ID, -2 to replay all events, or -1 to replay only new events."  I am trying to subscribe topic from a replayid when server restarts. I am storing replayid in another database to maintain the state.

Never mind. Its working fine now. Not sure why its failed earlier. Thanks


move_to_map_pokemon.py was broken in the last 24 hrs

I just did a dev pull this morning and now I get this issue when using
"type": "MoveToMapPokemon",
I have yet to switch to the new walk speed Min/Max settings,but doubt that is the issue
also pulled latest  PokemonGo-Map after this error
Traceback (most recent call last):
File "pokecli.py", line 626, in
main()
File "pokecli.py", line 104, in main
bot.tick()
File "/DATA/PokemonGo-Bot/pokemongo_bot/init.py", line 498, in tick
if worker.work() == WorkerResult.RUNNING:
File "/DATA/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_map_pokemon.py", line 248, in work
pokemon_list = self.get_pokemon_from_map()
File "/DATA/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_map_pokemon.py", line 147, in get_pokemon_from_map
if pokemon['dist'] > ((pokemon['expire'] - now) * mean_walk_speed) and not self.config['snipe']:
KeyError: 'expire'
2016-08-17 00:12:46,012 [sentry.errors] [ERROR] Sentry responded with an error: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128) (url: https://app.getsentry.com/api/90254/store/)
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/raven/transport/threaded.py", line 174, in send_sync
super(ThreadedHTTPTransport, self).send(data, headers)
File "/usr/local/lib/python2.7/dist-packages/raven/transport/http.py", line 47, in send
ca_certs=self.ca_certs,
File "/usr/local/lib/python2.7/dist-packages/raven/utils/http.py", line 66, in urlopen
return opener.open(url, data, timeout)
File "/usr/local/lib/python2.7/dist-packages/future/backports/urllib/request.py", line 494, in open
response = self._open(req, data)
File "/usr/local/lib/python2.7/dist-packages/future/backports/urllib/request.py", line 512, in _open
'_open', req)
File "/usr/local/lib/python2.7/dist-packages/future/backports/urllib/request.py", line 466, in _call_chain
result = func(*args)
File "/usr/local/lib/python2.7/dist-packages/raven/utils/http.py", line 46, in https_open
return self.do_open(ValidHTTPSConnection, req)
File "/usr/local/lib/python2.7/dist-packages/future/backports/urllib/request.py", line 1284, in do_open
h.request(req.get_method(), req.selector, req.data, headers)
File "/usr/lib/python2.7/httplib.py", line 1057, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python2.7/httplib.py", line 1097, in _send_request
self.endheaders(body)
File "/usr/lib/python2.7/httplib.py", line 1053, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 895, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128)
2016-08-17 00:12:46,017 [sentry.errors.uncaught] [ERROR] [u"KeyError: 'expire'", u'  File "pokecli.py", line 626, in ', u'  File "pokecli.py", line 104, in main', u'  File "pokemongo_bot/init.py", line 498, in tick', u'  File "pokemongo_bot/cell_workers/move_to_map_pokemon.py", line 248, in work', u'  File "pokemongo_bot/cell_workers/move_to_map_pokemon.py", line 147, in get_pokemon_from_map']

Same for me.
config is http://pastebin.com/JTUPEe98
call pile is http://pastebin.com/nQPhRc8V

#4115

Duplicate of #4113


Remove lock files [Fixes #136]

Description
Removed yarn.lock and package-lock.json files to fix #136
Related issues

#136

Update package.json .
Right now, npm users have to force the install npm i --force. this should be fixed once we upgrade all the packages and we move to hardhat toolbox


Add SnailMan Mode Plugin

Adds a deranged snail that chases you across the map in an attempt to "kill" you

Use ImageUtil.loadImageResource() instead of ImageIO: https://github.com/IdylRS/snailman/blob/9ef25a5b233914d0f8d91052bd5caf8c50c8e88d/src/main/java/com/idyl/snailman/SnailManModeMapOverlay.java#L51 and https://github.com/IdylRS/snailman/blob/9ef25a5b233914d0f8d91052bd5caf8c50c8e88d/src/main/java/com/idyl/snailman/SnailManModeOverlay.java#L115
Your navbar  button must be removed on plugin shutDown(): https://github.com/IdylRS/snailman/blob/9ef25a5b233914d0f8d91052bd5caf8c50c8e88d/src/main/java/com/idyl/snailman/SnailManModePlugin.java#L147

Thanks for the feedback @Nightfirecat ! Changes have been made. LMK if I missed anything.


Update docs for chore(pyo3_backend): Print bundle Python interpreter version

A document change request is generated from
https://github.com/GreptimeTeam/greptimedb/pull/3118

outdated


fix:spacing tokens

Closes #https://github.com/carbon-design-system/carbon-website/issues/1300
Updated the tokens in the spacing example
Old (broken)

New (fixed)

I posted a question on $spacing-auto in https://ibm-studios.slack.com/archives/GCPF37GEB/p1552666045016800 . It might not exist coz i can't find it in both carbon-component and carbon-elements. When we hear back, if it doesn't exist, we can just remove it, and merge this PR!


[Request]: Add "Do not show again" to "Media Feature Pack cannot be found!" for Honkai Impact 3rd

Is your request related to a problem?
No
How is the feature request related to the problem?
No response
Describe your proposed solution
Add a button/selection to not show the Media Feature Pack cannot be found! prompt again when launching Honkai Impact 3rd. There could be a checkbox in Collapse's setting which reverts the Do not show again setting.
I don't want to keep pressing Skip as I haven't had any issues without having the Media Feature Pack installed.
Describe alternatives you've considered
Installing the Media Feature Pack, but apparently that doesn't make the message go away on my computer. Either way, I haven't had any issues playing without the pack installed.
Additional context
No response

Hi~ Thanks for submitting enhancement feedback for Collapse!
The fix is up in the main branch, but it will take a bit until it releases into Preview branch and eventually into Stable. Though, if you want to try it, you can go to this workflow run (https://github.com/CollapseLauncher/Collapse/actions/runs/6608244797) and once it's done you can download its artifact. You can apply it by simply overwriting your current Collapse preview branch installation in app-1.72.5 folder with the contents of that run's artifact.


typescript binding issue when calling API in nextjs

Describe the bug
Typescript error when importing the package in an API script for nextjs. It seems the API can't be triggered.
To Reproduce
Steps to reproduce the behavior:

working on my project chatGPT prompt minting tool - repo
I have a script for minting NFT under the pages/api with the nextjs framework
launch the app with npm dev run and then click the create a prompt to get the Prompt modal view

after filling some dummy data, clicking the mint NFT button on the UI which should trigger the handleMintPrompt function in the index.tsx. Got the API error from the server side showed in the terminal

error - node_modules/ipfs-utils/src/http.js (6:0) @ <unknown>
error - __webpack_require__(...).bind is not a function

Expected behavior
I had made sure all the credentials working and added in the .env under the root. The expected outcome is to be able to mint the prompt text as NFT. (it seems image url is required (not sure why?) but just put dummy link there)
Screenshots or code block
I also tested the api logic with the following script under the project root, it's working fine -
import { config as loadEnv } from 'dotenv';
import { SDK, Auth, Metadata, TEMPLATES } from '@infura/sdk';

loadEnv();

const name = 'test'
const description = 'testing'
const prompt = 'testing'
const walletAddress = '...'

try {
        const auth = new Auth({
            projectId: process.env.INFURA_API_KEY,
            secretId: process.env.INFURA_API_KEY_SECRET,
            privateKey: process.env.WALLET_PRIVATE_KEY,
            rpcUrl: process.env.RPC_URL,
            chainId: 80001, // Mumbai
            ipfs: {
              projectId: process.env.INFURA_IPFS_PROJECT_ID,
              apiKeySecret: process.env.INFURA_IPFS_PROJECT_SECRET,
            }
          });

        const sdk = new SDK(auth);

        console.log(sdk)

        const contractAddress = '0xDA7358Ba86b51A6C7FE7033F9400F0fdFa356c5d'

        const contract = await sdk.loadContract({
         template: TEMPLATES.ERC721Mintable,
         contractAddress
        })

        // CREATE Token Metadata
        const tokenMetadata = Metadata.openSeaTokenLevelStandard({
            name: `${name}`,
            description: `${description}`,
            external_url: 'https://d2q0omy5xtz2zh.cloudfront.net/hero/prompt-builder-v0-2-0.webp',
            image: 'https://res.cloudinary.com/practicaldev/image/fetch/s--a9dULhJ6--/c_limit%2Cf_auto%2Cfl_progressive%2Cq_auto%2Cw_880/https://dev-to-uploads.s3.amazonaws.com/i/8ww354qlpdypw5ohs7s2.png',
            attributes: [{
                "trait_type": "Prompt",
                "value": `${prompt}`
              }],
        });

        console.log(tokenMetadata)

        // mint a NFT
        const mint = await contract.mint({
            publicAddress: process.env.WALLET_PUBLIC_ADDRESS ?? walletAddress,
            tokenURI: tokenMetadata,
        });

        const minted = await mint.wait();
        console.log(minted)
        return new Response(minted, { status: 200 })
    } catch (error) {
        console.log("testing")
        console.log(error);
      return new Response(JSON.stringify(error), { status: 500 });
    }

Additional context
I have a script and ran it before to deploy the contract with the SDK which returns the contract address - 0xDA7358Ba86b51A6C7FE7033F9400F0fdFa356c5d so the app logic only needs to handle the minting logic.I deployed on the Polygon Mumbai testnet.

hello @jpzhangvincent
thank you for reporting this problem, we will start working on its resolution and keep you informed

hey @jpzhangvincent
after a quick investigation , i noticed that the issue is related to the package ipfs-http-client ( a dependency that we are using in our package ).but it seems that this problem is known and that there is already an open issue for it here
i'm going to open another one and try to push them for a solution

hey @jpzhangvincent ,
the version 2.4.1 was just published , the issue was resolved


Add Snap (snapcraft) Maker

See: http://snapcraft.io/
I would rather not have code that calls snap inside of Electron Forge, but rather it should be a separate package like the ones for .deb, .rpm, and Flatpak. (electron-installer-snap?)

electron-installer-snap

Agreed, if this is done it should be made in a similar manner to all the other electron-installer-* modules and then utilised here 👍

Issue can be closed (electron-forge-maker-snap)?


navbar not responsive in sticky navbar template

assign me i will work on it

Best of luck 🤞

https://github.com/Diptenusarkar/Website-Template/pull/71 merge the PR with hactoberfest tag ;)


when preprocess data and load data using "lazy" mode

Describe the bug
Using "lazy" mode to process enwik8 data, when I got .bin and .idx file, using these file to pretrain, but I got error.
To Reproduce
Steps to reproduce the behavior:

python tools/preprocess_data.py
--input ./data/enwik8/enwik8.zip
--output-prefix ./data/enwik8/enwik8
--vocab ./data/gpt2-vocab.json
--merge-file gpt2-merges.txt
--dataset-impl lazy
--tokenizer-type GPT2BPETokenizer
--append-eod

modify local_setup.yml > "data-path": "data/enwik8/enwik8_text_document"

modify 125M.yml > "data-impl": "lazy"

run pretrain

Expected behavior
running.
Proposed solution
I don't know why.
Screenshots
Loading checkpoint and starting from iteration 0
[2023-04-25 16:08:08,311] [WARNING] [engine.py:2769:load_checkpoint] Unable to find latest file at checkpoints/latest, if trying to load latest checkpoint please ensure this file exists or pass an explicit checkpoint tag when loading a checkpoint.

building train, validation, and test datasets ...
dataset split:
train:
document indices in [0, 29311866) total of 29311866 documents
validation:
document indices in [29311866, 30219354) total of 907488 documents
test:
document indices in [30219354, 30249604) total of 30250 documents
WARNING: could not find index map files, building the indices on rank 0 ...
elapsed time to build and save doc-idx mapping (seconds): 11.041577
Traceback (most recent call last):
File "/mnt/home/gpt-neox/train.py", line 27, in
pretrain(neox_args=neox_args)
File "/mnt/home/gpt-neox/megatron/training.py", line 203, in pretrain
) = build_train_valid_test_data_iterators(neox_args=neox_args)
File "/mnt/home/gpt-neox/megatron/data/data_utils.py", line 400, in build_train_valid_test_data_iterators
train_ds, valid_ds, test_ds = build_train_valid_test_datasets(
File "/mnt/home/gpt-neox/megatron/data/data_utils.py", line 139, in build_train_valid_test_datasets
train_dataset = build_dataset(0, "train")
File "/mnt/home/gpt-neox/megatron/data/data_utils.py", line 127, in build_dataset
dataset = GPT2Dataset(
File "/mnt/home/gpt-neox/megatron/data/gpt2_dataset.py", line 52, in init
self.doc_idx, self.sample_idx, self.shuffle_idx = _build_index_mappings(
File "/mnt/home/gpt-neox/megatron/data/gpt2_dataset.py", line 176, in _build_index_mappings
assert sizes.dtype == np.int32
AssertionError
[2023-04-25 16:08:21,601] [INFO] [launch.py:318:sigkill_handler] Killing subprocess 3065
[2023-04-25 16:08:21,602] [INFO] [launch.py:318:sigkill_handler] Killing subprocess 3066
[2023-04-25 16:08:21,816] [ERROR] [launch.py:324:sigkill_handler] ['/usr/bin/python3.10', '-u', 'train.py', '--local_rank=1', '--deepspeed_config', 'eyJ0cmFpbl9iYXRjaF9zaXplIjogOCwgInRyYWluX21pY3JvX2JhdGNoX3NpemVfcGVyX2dwdSI6IDQsICJvcHRpbWl6ZXIiOiB7InR5cGUiOiAiQWRhbSIsICJwYXJhbXMiOiB7ImxyIjogMC4wMDA2LCAiYmV0YXMiOiBbMC45LCAwLjk1XSwgImVwcyI6IDFlLTA4fX0sICJmcDE2IjogeyJlbmFibGVkIjogdHJ1ZSwgImxvc3Nfc2NhbGUiOiAwLCAibG9zc19zY2FsZV93aW5kb3ciOiAxMDAwLCAiaHlzdGVyZXNpcyI6IDIsICJtaW5fbG9zc19zY2FsZSI6IDF9LCAiZ3JhZGllbnRfY2xpcHBpbmciOiAxLjAsICJ6ZXJvX29wdGltaXphdGlvbiI6IHsic3RhZ2UiOiAxLCAiYWxsZ2F0aGVyX3BhcnRpdGlvbnMiOiB0cnVlLCAiYWxsZ2F0aGVyX2J1Y2tldF9zaXplIjogNTAwMDAwMDAwLCAib3ZlcmxhcF9jb21tIjogdHJ1ZSwgInJlZHVjZV9zY2F0dGVyIjogdHJ1ZSwgInJlZHVjZV9idWNrZXRfc2l6ZSI6IDUwMDAwMDAwMCwgImNvbnRpZ3VvdXNfZ3JhZGllbnRzIjogdHJ1ZX0sICJ3YWxsX2Nsb2NrX2JyZWFrZG93biI6IHRydWV9', '--megatron_config', '/mnt/home/gpt-neox/megatron_config.json'] exits with return code = 1

Environment (please complete the following information):

GPUs:2
Configs:

Why do you think this has to do with lazy mode? Have you verified that the checkpoints specified are in fact where you've pointed the program?

Why do you think this has to do with lazy mode? Have you verified that the checkpoints specified are in fact where you've pointed the program?

Thank you for your reply！
I have used mmap mode to precess and load enwik8 data, and I have run pretrain process.
when I use lazy mode to process and load enwik8 data, and I got this error, there is no other chang.

@haileyschoelkopf it looks like the core issue here is a failed assertion about data types for the index mappings… could this have snuck in when you were dealing with the dataset size overflowing?
File "/mnt/home/gpt-neox/megatron/data/gpt2_dataset.py", line 176, in _build_index_mappings assert sizes.dtype == np.int32 AssertionError

Might be--after looking through @Quentin-Anthony 's overflow fix it seems that even when sample_idx is built in int64 the dtype of sizes should still be np.int32 though. I've never used the "lazy" impl so it could be that this has been broken for longer, would need to look into it by running it locally

I find Megatron-LM issues: https://github.com/NVIDIA/Megatron-LM/issues/170
It seems that Megatron-LM no longer support lazy dataloader?

The concatenation functionality they describe as a replacement is also supported in our code, so I’m going to make a minor PR to remove the "lazy" option in preprocessing and close this as completed


LARGEST RECTANGULAR AREA IN A HISTOGRAM PROBLEM IMPLEMENTATION USING STACK IN PYTHON[swoc21]

Finding the largest rectangular area possible in a given histogram where the largest rectangle can be made of a number of contiguous bars using stack data structure.

I would like to work on this under SWOC

I would like to work on this under SWOC

@spursbyte please get started

@spursbyte please get started

Yes sir our sem exams just got over yesterday..i will start working soon..sorry for the delay

Yes sir our sem exams just got over yesterday..i will start working soon..sorry for the delay


Cluster defaults should not be overridden by swarm init

swarm init creates a ClusterSpec and overwrites the cluster's object spec with this one. This means defaults such as certificate validity period and task history retention are under the client's control. They should be under SwarmKit's control instead.
swarm init should only change values from the defaults when a value is given through a flag. Currently, it appears to overwrite the whole spec with the client-side defaults when no flags are specified.
cc @aluzzardi @tonistiigi

Note that as a consequence of this, it's impossible to set the task retention limit to 0. 0 is a valid value, but the engine replaces 0 with the default value.

@aaronlehmann I created a pull request #25697 yo try to address this issue.


[FEATURE] Test for buffered stdout

Affected project(s)

[ ] documentation
[ ] examples
[ ] wasmCloud host
[X] wasmCloud CLI (wash)
[ ] wasmCloud dashboard UI (washboard)
[ ] capability providers
[ ] provider bindgen
[ ] control interface client
[ ] other / not sure

Is your feature request related to a problem? Please describe.
After the work that @michelm did on in  https://github.com/wasmCloud/wasmCloud/pull/3680 , it would be great to have a follow up test (which is somewhat involved) to try and replicate the broken pipe behavior and make sure that we cover the behavior under test.
Describe the solution you'd like
Add a test (mostly laid out in this comment) for the buffered stdout addition
Describe alternatives you've considered
N/A
Additional context
No response

:+1: Thanx Vados, I'll start on it today.


Inconsistent naming of module pins

Describe the bug
While working on the physical implementation I discovered that some pins (buses) in CLB and SB are inconsistently named.
On the attached picture I highlighted in red pins that (in my opinion) have incorret names:

grid_clb: bottom_*_upper and bottom_*_lower
sb: left_top_grid* and  right_top_grid

Which part of OpenFPGA is buggy

[ ] Documentation
[x] FPGA-Verilog
[ ] FPGA-Bitstream
[ ] FPGA-SDC
[ ] FPGA-SPICE
[ ] VPR
[ ] Yosys

To Reproduce
Steps to reproduce the behavior:

Clone OpenFPGA repository and checkout commit id: 5029688bcf13c8b1301d7be62edd877e6cd39016 (current master)
Execute OpenFPGA task to generate netlist:

openfpga_arch: k6_frac_N10_adder_chain_40nm_openfpga.xml
vpr_arch: k6_frac_N10_tileable_adder_chain_40nm.xml

Review: SRC/fpga_top.v, SRC/lb/grid_clb.v, SRC/routing/sb_1__1_.v

Expected behavior
I would expect names:

grid_clb.bottom_*_upper ->grid_clb.left_*_upper
grid_clb.bottom_*_lower -> grid_clb.left_*_lower
sb.left_top_grid* -> sb.top_right_grid*
sb.right_top_grid -> sb.bottom_right_grid*

Additional context
The observed behaviour could be an edge case and therefore related to https://github.com/lnis-uofu/OpenFPGA/issues/322.

After reviewing the architecture preview in VPR, I realized that my preconception about the routing architecture was wrong. For reference I attach the drawing:

There is no problem with the OpenFPGA and everything is as expected. Sorry for generating noise.


ref: simplify test callback

What does this PR do?
simplify the test for a general callback so now we can also see the order
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

I would prefer to do this with unittest.Mock, and then for example:
callback.on_batch_start.assert_called_with(...)
or
callback.on_batch_start.assert_called_once()
or
callback.on_batch_start.call_count == ...

it is quite elegant

it is quite elegant and opens a lot more options for rigorous testing. we can even test for the order in which these are called, or with which arguments etc.

can we also see in which order the methods were called? I know that we can be easily counted, but each mock is independent, right?

Yes, absolutely!
See my example here: https://github.com/PyTorchLightning/pytorch-lightning/issues/4049#issuecomment-706598291

it is quite elegant and opens a lot more options for rigorous testing. we can even test for the order in which these are called, or with which arguments etc.

mind share example how would you test the order of calling?  @awaelchli :]

with assert_has_calls, see example here: https://github.com/PyTorchLightning/pytorch-lightning/issues/4049#issuecomment-706598291

with assert_has_calls, see example here: #4049 (comment)

ok, I needed to find a way around their native asserts but shall be fine now :] @awaelchli


fix: const enums + isolatedModules emit invalid code

In isolatedModules mode, the compiler does not inline const enums, but also decides not to import them, leaving invalid code that throws a ReferenceError at runtime.
This code:
import { SomeEnum } from './bar';
sink(SomeEnum.VALUE);

..should compile to either:
var { SomeEnum } = require('./bar');
sink(SomeEnum.VALUE);

..or (with const enum inlining):
sink(1 /* VALUE */);

..but actually compiles to:
sink(SomeEnum.VALUE);

..with no imports, which throws a ReferenceError at runtime.

The compiler has already realised that the symbol is a referenced const enum, it just doesn't use this information when it comes to deciding whether to emit an import. This commit additionally checks that information, if we are compiling in isolatedModules mode.

In my opinion, this is not the correct fix, but it is the simplest. In isolatedModules mode, const enum should probably be a compile error (because there are no benefits and the complexity is high, and, apparently, buggy). If not, the compiler should not be checking whether something is a const enum, and should just be treating it as a regular enum, and checking as if it was?
Fixes #40499.

I think it’s worth considering adding an error too, but that can be done separately. I see no reason not to take this fix regardless of whether we add an error in the future.

That test is simple enough, and does what I expect (the import, which is only used in type context, is deleted). It doesn't even run the new code. Added.

@andrewbranch @sheetalkamat is this ready to go in? From the comment history, it looks like @sheetalkamat 's comments were addressed and @andrewbranch reviewed them, but I want to make sure before merging.

I believe it’s ready, just wanted another team member to review.

Thanks @FauxFaux! Sorry this ended up being more complicated than you bargained for 😅

Thanks @FauxFaux! Sorry this ended up being more complicated than you bargained for 😅


Handle SSO redirect errors on login page in platform

We need to handle the errors returned from the SSO callback. They are propagated using an error query parameter, and could look like this:
http://localhost:5050/auth/login?error=already_exists:+user+already+exists.+Login+using+email+and+password.

@Munklinde96 - This is now fixed, and will go into next release


Error in test_select

gitpod /workspace/deepclient (main) $ ( cd python && python -m unittest discover -s tests -v )
test_initialization (test_deep_client.TestDeepClient.test_initialization) ... ok
test_methods_raise_not_implemented (test_deep_client.TestDeepClient.test_methods_raise_not_implemented) ... /workspace/deepclient/python/tests/test_deep_client.py:38: DeprecationWarning: There is no current event loop
  loop = asyncio.get_event_loop()
ok
test_select (test_deep_client.TestDeepClient.test_select) ... ERROR
test_serialize_where (test_deep_client.TestDeepClient.test_serialize_where) ... ok

======================================================================
ERROR: test_select (test_deep_client.TestDeepClient.test_select)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/workspace/deepclient/python/tests/test_deep_client.py", line 144, in test_select
    loop.run_until_complete(test_async_methods())
  File "/home/gitpod/.pyenv/versions/3.11.1/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/workspace/deepclient/python/tests/test_deep_client.py", line 141, in test_async_methods
    await self.client.select(1)
  File "/workspace/deepclient/python/deepclient/deep_client.py", line 419, in select
    q = await self.client.execute(generate_query({
                                  ^^^^^^^^^^^^^^^^
  File "/workspace/deepclient/python/deepclient/query.py", line 62, in generate_query
    called_queries = [m(alias, i) if callable(m) else m for i, m in enumerate(queries)]
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/deepclient/python/deepclient/query.py", line 62, in <listcomp>
    called_queries = [m(alias, i) if callable(m) else m for i, m in enumerate(queries)]
                      ^^^^^^^^^^^
  File "/workspace/deepclient/python/deepclient/query.py", line 9, in inner
    defs.append(f"${field + index}: {field_types[field]}")
                    ~~~~~~^~~~~~~
TypeError: can only concatenate str (not "int") to str

----------------------------------------------------------------------
Ran 4 tests in 0.003s

FAILED (errors=1)

Unable to fix the issue using AutoPR.


⚠ Bofrost.at has degraded performance

In f75d507, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1045 ms

Resolved: Bofrost.at performance has improved in 84aa514 after 6 minutes.


enclave secrets are protected with MRSIGNER instead of MRENCLAVE key policy

Currently, we're using SgxFs for persisting the enclave's secrets:
https://github.com/scs/substraTEE-worker/blob/15f83244c1d7904f4b95f3fbbc63530b7831b2f2/enclave/src/io.rs#L58
This, however, uses MRSIGNER to auto-derive an encryption key, as explained here:
https://software.intel.com/en-us/articles/overview-of-intel-protected-file-system-library-using-software-guard-extensions
What we would like to have is key_policy SGX_KEYPOLICY_MRENCLAVE, as explained here:
https://software.intel.com/en-us/blogs/2016/05/04/introduction-to-intel-sgx-sealing
This means we should not use SgxFs, but rather this here:
https://github.com/apache/incubator-teaclave-sgx-sdk/blob/15b8470dd50e9628e1cb7a0fdb08989f0b5ecc35/sgx_tseal/src/seal.rs#L276
Reasoning: As SusbtraTEE is an unpermissioned open source project, there can be no SIGNER authority. Everyone can build their own enclave and sign it with an ephemeral key

It would be possible to supply a key to SgxFs:
https://github.com/apache/incubator-teaclave-sgx-sdk/blob/8d9f05abd2ebe0a3f1db901f2280513c36325553/sgx_tstd/src/sgxfs.rs#L121
however, it seems more elegant to use SgxSealedData instead and then just writing it to standard Fs

Tests:
In order to test that this bug is fixed, do:

make all mrsigner mrenclave remember output for MRSIGNER and MRENCLAVE
run substraTEE-worker getsignkey
remember output of xxd ed25519_key_sealed.bin |head -2
remember the output of xxd ecc_pubkey.bin
now change the enclave signer key

cd enclave
`openssl genrsa -3 -out Enclave_private.pem 3072

make all mrsigner mrenclave. MRENCLAVE should stay the same as above. MRSIGNER should've changed
run substraTEE-worker getsignkey (it would be better if this fails, but it will just overwrite the key if it can't read it)
xxd ecc_pubkey.bin
now, change the binary by modification of code
rerun the above

Here's a dump of what happens todaxy, with MRSIGNER policy:

Succeed.
MRSIGNER: d11b71385c1225466236e6c6539d4b2a27a48121f4bfb48a69810191841af53c
Succeed.
MRENCLAVE: 7921acf80f13619ba553f8678b151c25c91552fdc61ae611518dfd33e763da83

xxd ed25519_key_sealed.bin |head -2
00000000: 454c 4946 5f58 4753 0100 f553 a266 0f95  ELIF_XGS...S.f..
00000010: a823 4560 0cf6 5d0d aa87 84ae 0f90 7c5e  .#E`..].......|^
xxd ecc_pubkey.bin
00000000: 310c 5c47 60e5 418b 7c6c 564a 9520 6e16  1.\G`.A.|lVJ. n.
00000010: b049 ba32 6f2b 0369 0dcb 7223 2568 739c  .I.2o+.i..r#%hs.

openssl genrsa -3 -out ../enclave/Enclave_private.pem 3072

make all mrsigner mrenclave

Succeed.
MRSIGNER: eb01b00b426a371758effbd62205381537cf453452437d2fd7cbb17e60ffdcc8
Succeed.
MRENCLAVE: 7921acf80f13619ba553f8678b151c25c91552fdc61ae611518dfd33e763da83

xxd ed25519_key_sealed.bin |head -2
00000000: 454c 4946 5f58 4753 0100 fb69 3ca3 c491  ELIF_XGS...i<...
00000010: e046 bd9b fd29 d59e aed1 14b2 44d4 f9d3  .F...)......D...

-> has been overwritten! (now fixed, it would panic now

With MRSIGNER policy, the key can't be retrieved because MRSIGNER changed
With MRENCLAVE policy, the key can be retrieved because MRENCLAVE didn't change

change binary

Enclave is in Development Mode
Succeed.
MRSIGNER: eb01b00b426a371758effbd62205381537cf453452437d2fd7cbb17e60ffdcc8
Succeed.
MRENCLAVE: 04bee684d3813bed654e37ae90b15b8601f01bae518b081620f1e467bd2b2c66

xxd ed25519_key_sealed.bin |head -2
00000000: 454c 4946 5f58 4753 0100 fb69 3ca3 c491  ELIF_XGS...i<...
00000010: e046 bd9b fd29 d59e aed1 14b2 44d4 f9d3  .F...)......D...
abrenzikofer@devsgx02:~/substraTEE-worker/bin$ xxd ecc_pubkey.bin
00000000: 7a0f 7cb8 feb3 9ff4 9df5 2335 27e9 023b  z.|.......#5'..;
00000010: 6682 8003 d759 d805 68cc 3618 a8ac 225e  f....Y..h.6..."^

this should not work if MRSIGNER key policy. it should panic:
thread '<unnamed>' panicked at '[Enclave] Keyfile ed25519_key_sealed.bin exists but can't be opened. has it been written by the same enclave?', src/ed25519.rs:44:4
note: Call backtrace::enable_backtrace with 'PrintFormat::Short' for a backtrace.
Illegal instruction (core dumped)

With MRSIGNER policy, the key can be retrieved because MRSIGNER didn't change
With MRENCLAVE policy, the key can't be retrieved because MRENCLAVE changed

We should wait with fixing this until we can build the enclave deterministically. Until then, SCS shall act as the vendor and distribute enclave builds through github releases


Support private npm packages

I trialled this Github Action, but am unable to pass the yarn install stage since we can't access our private npm packages.
Does this action support any way of passing this token, or, is there a complimentary Github Action that can be used to make this available?

We have made it work by adding this step before:
- name: Setup Github Package Repository access token
  run: echo ${{ secrets.GITHUB_NPM_TOKEN_FULL }} > ~/.npmrc

And add a secret GITHUB_NPM_TOKEN_FULL that looks like this:
//npm.pkg.github.com/:_authToken=MY_TOKEN

The same would work, I presume, with a private npm registry.

Thanks for the suggestion @mydea. That works out for us.
I should've done some more research to understand how Github Action steps can be composed. They're somewhat new to me, and the other JS actions I'd used would take NPM_TOKEN in env, so I was wondering if this action did too.
I'll close this, since it can be solved without adding code to this repo.


Fixed expiration maks regex.

The pattern for expiration was on security code. Now is correct.

Are you sure? Unfortunately I don't have the time to test it but it looks good to me.

Yes, I'm sure. If you could create a new version out of this I'd appreciate.


Features/cu 86drqw198 get coinsid get current data name price market  including exchange tickers for a coin

PR for fetch Coin By ID

Task linked: CU-86drqw198 GET /coins/{id} Get current data (name, price, market, ... including exchange tickers) for a coin


Issue #177: DokanFileInfo.Context leaks GCHandle if not set null.

DokanFileInfo.Context allocates a GCHandle if it's set to anything
that isn't null. However, that GCHandle is only ever freed if it
is set to null thereafter. This patch ensures that the GCHandle
is proprly freed before the DokanFileInfo goes out of scope,
without calling anything on the object the Context points to.

Thank you @kyanha for the quick PR and change !


PHONE VALIDATION action not working

Good day and thank you for your great work!
I am using the SMS authentication plugin together with Twilio and and works well to enforce 2FA via SMS.
However, when PHONE VALIDATION is active as required action, users cannot login anymore "Sorry, something went wrong"
The logs show this error message:
java.lang.NullPointerException: Cannot invoke "String.startsWith(String)" because "phone_number" is null

I activated "Set Phone Number as User attribute", but no attribute is created when a user creates the SMS 2FA via "update Mobile Number" required action.
Maybe I am doing something wrong ? I would really love to have the validated phone number inside the user attributes...
Kindly assist, thank you in advance !

Thank you for your report. But I think there is a misunderstanding in the use of the Required Action Phone Validation. So you try to assign this Required Action to users manually, right?
This is unfortunately not supported. Please do not assign this Required Action at any time. This action should only be triggered by Required Action Update Mobile Number.
If you want users to validate their existing numbers, you could only use the Required Action Update Mobile Number. There sits all the logic for proper number format validation: https://github.com/netzbegruenung/keycloak-mfa-plugins/blob/39152432bcbfdefb39c869d0ec88b2087209b8ac/sms-authenticator/src/main/java/netzbegruenung/keycloak/authenticator/PhoneNumberRequiredAction.java#L149
Downside is that they have to enter the phone number again. But that is the only supported option in the moment.

Closing this for now. Feel free to reopen if the issue persists.


subete is extremely noisy

For the sample-programs-website, about 100K+ lines are output. It would be nice if this were reduced to only what is necessary to show the progress is being made. I think one way to do this would be to remove logging from the getter methods.

Makes sense to me! Another option would be to use the logging levels appropriately, so the noisy bits can be hidden from the output but switched on if needed.

Makes sense to me! Another option would be to use the logging levels appropriately, so the noisy bits can be hidden from the output but switched on if needed.

Yeah, that's probably easier. Just have the automation set it to WARNING instead of INFO and have the automation log appropriate messages.


Suppress npm audit failure

Build is failing due to https://github.com/advisories/GHSA-rqff-837h-mm52. This is a deeply nested dependency to something used in one of our test apps, suppress the failure to allow the build to pass.

@mergifyio backport release/2.19.x

@mergifyio backport release/3.0.x

Is this actually affecting master??  I don't see this vuln when I run rush audit locally, and it looks like the latest CI built fine: https://github.com/iTwin/itwinjs-core/runs/5238754284

Just looked at the CVE details a bit more - I'm fine suppressing this one for now given how the test app uses it.


[Event Request] Table 36 "Sales Header" - OnBeforeCopySellToAddressToBillToAddress

Please add new Event OnBeforeCopySellToAddressToBillToAddress in the table 36:
procedure CopySellToAddressToBillToAddress()
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeCopySellToAddressToBillToAddress(Rec, IsHandled);
    if IsHandled then
        exit;

[IntegrationEvent(false, false)]
local procedure OnBeforeCopySellToAddressToBillToAddress(var SalesHeader: Record "Sales Header"; var IsHandled: Boolean)
begin
end;

Handled pattern here would break calling onaftercopy, so instead there will be a regular OnBefore, you can use that to store the values and restore in onafter if you so wish.

Not sure that I understand. There are a lot of instances in the base app that have both OnBefore and OnAfter in the same function and the OnBefore is handled.
Restoring it in OnAfter would be a bit hacky  but doable.

Here it is hidden under the condition, so it's not called all the time, but some of the times, when we implement ishandled we still want to call the onafter and it is possible if it is called unconditionally as the last line. Technically it is possible to obsolete current onafter, create a new one one line lower, but not doing that for such a small function is a preferrable alternative.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 42636.


Joins() doesn't respect soft deletes

GORM Playground Link

https://github.com/go-gorm/playground/pull/412
Description
If you soft-delete a Has-One relationship, the deleted association won't be loaded if you use Preload(). If you use Joins(), though, it won't respect the soft deletion.
  var account Account{Number:"77"}
  DB.Create(&account)
  user := User{ Name: "jinzhu", Account: account}
  DB.Create(&user)

  DB.Delete(&account)

  // Works, no account in User
  DB.Preload("Account").First(&result, user.ID)

  // Doesn't work, account is hydrated even though it's been soft-deleted
  DB.Joins("Account").First(&result, user.ID)

seems correct, there is a typo in your demo.

seems correct, there is a typo in your demo.

That code you pasted isn't in my playground or in any of the code I submitted.
func TestGORM(t *testing.T) {
	account := Account{Number: "77"}
	DB.Create(&account)

	user := User{Name: "jinzhu", Account: account}

	DB.Create(&user)

	var result, result2, result3, result4 User
	if err := DB.Preload("Account").First(&result, user.ID).Error; err != nil {
		t.Errorf("Failed, got error: %v", err)
	}
	if result.Account.ID != account.ID {
		t.Fatalf("Failed using preload, Account should be valid")
	}
	if err := DB.Joins("Account").First(&result2, user.ID).Error; err != nil {
		t.Fatalf("Failed, got error: %v", err)
	}
	if result2.Account.ID != account.ID {
		t.Fatalf("Failed using joins, account should be valid")
	}

	// Delete the account
	DB.Delete(&account)
	if err := DB.Preload("Account").First(&result3, user.ID).Error; err != nil {
		t.Fatalf("Failed, got error: %v", err)
	}
	if result3.Account.ID != 0 {
		t.Errorf("Failed using preload, Account should be 0 got: %v", result3)
	}

	if err := DB.Joins("Account").First(&result4, user.ID).Error; err != nil {
		t.Fatalf("Failed, got error: %v", err)
	}
	if result4.Account.ID != 0 {
		t.Errorf("Failed using joins, account should be 0, got: %v", result4)
	}

}

Sorry, seems I relied on a wrong thread...

Ah yes, sorry, I submitted two issues right next to each other!

Fixed in latest master, thank you for your report.

is this functionality still on master?


True infinite scrolling

Both pagination and virtualization feel clunky and dated in comparison to true infinite scrolling (à la Facebook or Twitter). Or so I've been told, at least.
I wonder if it might be possible to render only the top n rows at first, and a Load more button below, which adds more rows at the bottom. The add-more function could alternatively be triggered just by scrolling to the bottom of the page, or even by the componentDidMount callback on the first n rows.
React's re-rendering model makes this challenging, because Load more would have to render only the additional rows, without re-rendering the existing ones – otherwise, what's the point?
Before I try to build a prototype, what are your thoughts on this? Is this feasible, and if yes, where should I start? (Or is it already possible and I just haven't found out about it?)

Check the example. I pushed the concern outside of the core to user space.
It gets trickier with virtualization as you still need things like row counts to do the math.
Please note that I'm heavily considering dropping support for this project as community has no interest in supporting the maintenance effort and it's costing me money/time. So you may want to start looking into alternatives. Just a friendly warning. 😄

Thank you. How did I miss that!? Weirdly enough it only works in Firefox, not in Chrome. Must be a thing with the scroll event; probably easily fixable. I will use that as a starting point for my own implementation (and maybe submit a PR depending on how reusable it turns out).
Also, I'm sad to hear you're considering giving up on reactabular. Tell ya what, this is by far the best React table component out there, and it's in tremendously good shape thanks to your superhuman effort to keep everything so clean and well-organized. You've put in so many hours over the last year, and you've been so responsive to questions and bugs ... I think nobody would hold it against you if you were to take a well-deserved break. Maybe a compromise would be to limit your involvement to comments and PR merges, so as not to kill the project completely? Anyways, I just chipped in ten bucks – have a beer on me, focus on other stuff, and we'll all be happy to have you back when you have less on your plate. :beers:

Thank you. How did I miss that!? Weirdly enough it only works in Firefox, not in Chrome. Must be a thing with the scroll event; probably easily fixable. I will use that as a starting point for my own implementation (and maybe submit a PR depending on how reusable it turns out).

Ok, PR welcome. As you can see, the implementation is trivial. To combine with virtualization, I think you may want to generate mock data (empty rows) to fix scroll. Then, as you scroll, you would load the data as you need it.

Also, I'm sad to hear you're considering giving up on reactabular. Tell ya what, this is by far the best React table component out there, and it's in tremendously good shape thanks to your superhuman effort to keep everything so clean and well-organized. You've put in so many hours over the last year, and you've been so responsive to questions and bugs ... I think nobody would hold it against you if you were to take a well-deserved break. Maybe a compromise would be to limit your involvement to comments and PR merges, so as not to kill the project completely? Anyways, I just chipped in ten bucks – have a beer on me, focus on other stuff, and we'll all be happy to have you back when you have less on your plate. 🍻

Thanks. I have to put May into business development. Once things are sustainable again, I'll likely have more time for side projects. Any new features are unlikely to happen until I get things straightened up, though.


Ludwig -> Mate app name

I copied a line and didn't change the link name in the previous update, when adding Mate to translation tools. Fixed now.
NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[ ] New addition to list
[x] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
Describe each of your changes here to communicate to the maintainers why we should accept this pull request.
I copied an existed line to add a new product, but forgot to change the name. Fixed.
PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[x] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@chernikovalexey thx!


Add "Views" to OSF for Meetings Conference Pages [#OSF-4999]

Purpose
Change the meeting page's project download count to project view and downloads count.
Changes
Now the meeting's page's download counts on each post and talk should include not only the download number of the file but also the file page visit count.
Side effects

This pr relies on keen to get the data of the page view count of the file page.
Ticket

https://openscience.atlassian.net/browse/OSF-4999

Changes have been made. Still need to wait for @felliott 's pr to add in the public read_key for keen in website.settings.default


Backport some of 1.20.4  changes to 1.20.1

Description
Title. also make sure to squash this when merging!!
Breaking Changes
ICapacitorScalable changes: NonNullSupplier -> Supplier
Conduit save data changed from packed xyz to saving xyz in a compound (just as 1.20.4)
addTranslation lang util
RenderHighlightEvent explicitly targets Block
Checklist

[x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
[x] I have made corresponding changes to the documentation.
[x] My changes are ready for review from a contributor.

While we are not against backports, ideally everything should be backport and not just parts, as we do not want to release an update that is not feature complete with our latest dev branch.


heat_demand with chunked datasets

@coroa pointed out that the heat_demand might have problems when chunking (at least there were some issues with windows). A time shift in the time coordinates might lead to loosing values at the border of chunks. This seems to be no problem for dask arrays:
When looking at the results of chunked and non-chunked datasets, the result for heat_demand is exactly the same.

Here is the code, for reproducibility:
import atlite
import matplotlib.pyplot as plt
import geopandas as gpd
from pathlib import Path
import xarray as xr

pypsa_eur_dir = Path('/home/fabian/vres/py/pypsa-eur/')

chunked = atlite.Cutout('pypsa-eur.nc', chunks={'time':100})
non_chunked = atlite.Cutout('pypsa-eur.nc', chunks=None)

layout = xr.ones_like(chunked.data.height)
kwargs = dict(layout=layout, hour_shift=3)
heat_demand = xr.Dataset(dict(chunked = chunked.heat_demand(**kwargs),
                              non_chunked = non_chunked.heat_demand(**kwargs)))

fig, (ax1, ax2) = plt.subplots(2,1, sharex=True)
heat_demand.to_array(name='Total Heat Demand Europe').plot.line(x='time', ax=ax1)
(chunked.data.temperature.mean(['x', 'y']).resample(time='1D').mean() - 273)\
        .rename('T [°C]').plot.line(ax=ax2)
fig.tight_layout()
fig.savefig('heat_demand_chunked.png')

Just a small note to clarify: Atlite v0.0.2 or v0.2 before merging the dask compatibility PR by Fabian had the problem that when they were averaging over days with a active time-shift of f.ex. 2hrs, they would in each window see a day with only 22hrs at the beginning and additional day of 2hrs and computed averages over those. This introduced non-unique indices at the boundary as described in #6. One would have had to postprocess these manually by averaging the duplicate entries with the correct weights, ie. use (2*left + 22*right) / 24 at each boundary.
The dask chunks know their neighbours and they seem to be combined correctly automatically, so that no postprocessing is necessary, anymore!


Chore/update "types/jest" to v29

Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[ ] tests are included
[ ] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
This PR adds the code changes required by @types/jest v29.

I just saw this from the build output.
thrown: "Exceeded timeout of 5000 ms for a test.

I just saw this from the build output.
thrown: "Exceeded timeout of 5000 ms for a test.

Interesting, it was in MyResourcesPage.test.tsx which had changes, but I wouldn't have expected it to cause that. (It also had some other failures.)

I just saw this from the build output.
thrown: "Exceeded timeout of 5000 ms for a test.

Interesting, it was in MyResourcesPage.test.tsx which had changes, but I wouldn't have expected it to cause that. (It also had some other failures.)

I wouldn't either. This test became a bit flaky now. The second run was passed.

Oh well, merge on and let's observe.


fake_quant_min_max_args/vars works unexpected

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): 1.10
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: -
GPU model and memory: NVidia 1080 Ti

Describe the current behavior
import tensorflow as tf
s = tf.Session()
s.run([tf.fake_quant_with_min_max_args(123, 12, 123, narrow_range=False)])
OUTPUT: [111.0]
Describe the expected behavior
OUTPUT: [123.0]
Code to reproduce the issue
import tensorflow as tf
s = tf.Session()
s.run([tf.fake_quant_with_min_max_args(123, 12, 123, narrow_range=False)])

Nagging Assignee @suharshs: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


[bug] spatial props for bundle atlas not calculated correctly

as of v0.3a11
the spatial props calculated for regions such as lh_PoCi-PrCu_1 can be misleading, due to the concaved geometry of the probabilistic map:

This is not suprising, since we just compute the mean. The mean is certainly not a very good choice for fibrre bundles - we might choose the closest point to the mean which is inside the structure.


Allow agents to drain their job before exiting without signal propagation

Is your feature request related to a problem? Please describe
EC2 offers two early notification systems for instances which are about to  be terminated:

EC2 Spot Instance Termination notices which arrive 2 minutes before the instance is terminated
EC2 Capacity Rebalancing notifications which are sent to the instance when the risk of being terminated is elevated. These arrived at least 2 minutes before the instance is terminated, usually more. They only fire if capacity balancing is enable.

We run over 2000 agents AWS EC2 Spot instances. We do not run in spawn mode, so we run multiple agent processes per machine. Our Buildkite jobs on this fleet take ~3 minutes from start to finish. The instance types we have chosen (m6i/r6i) are subject to high rates of churn. This churn has a large impact on our stability and results in jobs exiting mid-way through because right now our listener for these EC2 notices uses systemd to stop the agent with a SIGTERM signal but this sends a SIGTERM to the running job. This which is something we want to avoid.
Describe the solution you'd like
Sending a SIGUSR1/2 to the agent will result in the agent acknowledging the signal, stop polling for new jobs, disconnecting and exiting after all running jobs are finished. If no jobs are being run on receipt of the signal the agent should immediately disconnect and exit.
Describe alternatives you've considered
Run in disconnect-after-job mode:
I have considered running all of our agents with disconnect-after-job enabled and leveraging systemd to restart the agent process. When we receive a notice we can just unload the systemd service, and the next time the agent finishes a job it'll disconnect, exit and not restart. I chose not to do this for two reasons, all around time delays:

Right now as soon as a job is finished the agent will request the next job from the queue without waiting for a ping interval but in this solution the agent needs to terminate, restart, reconnect and then ask for a job.
There is a race condition I reported to Buildkite support where after an agent connects it takes the Buildkite Dispatcher time to realise there's a new agent available. This can result in the first ping from a newly started agent not receiving a job, even though there is work on the queue. The agent then waits for the next ping interval (10s) before trying again which is another delay we're trying to avoid.

Trap the SIGTERM ourselves in our code
I have considered not making this the responsibility of the agent and instead trying to trap the SIGTERM sent by the agent to the in the command it's running. With this solution we need to make every command we run in our pipeline aware that if it gets a SIGTERM or some other cancellation signal from the agent that it may need to be swallowed without action in the case of the cause of the signal being an EC2 notice. This doesn't feel like it should be the concern of the pipeline's commands/scripts though, since we're trying to make the agent drain existing jobs without taking new ones.

This feature is so great you already built it. And the reason it doesn't work for us is because we aren't using an updated systemd service configuration that include the fix from https://github.com/buildkite/elastic-ci-stack-for-aws/pull/521. What a brutal discovery after I spent the time to write this up. Still, a happy result so maybe next time I'll land on a winning feature!

what a shame to see such a good issue go to waste! very glad past buildkite solved this problem for you ^_^

Is there a way to do this in the buildkite agent docker image? We're seeing similar behavior with the agent just sending on the SIGTERM to the jobs which kills them before they can gracefully complete.

Created https://github.com/buildkite/agent/issues/1758 actually to track it, think I narrowed down the issue


on Query it hangs

everything is working but
It gets hanged here:
   **Dim queryResult = QueryCommandBuilder.Instance.BuildQueryCommand.From(queryAudioFile).UsingServices(modelService, audioService).Query.Result**

I have the same problem too in the same line ,Why?

I am having the same problem too.. Kindly Advise! Thanks

I have the same problem too in the same line ,Why?
my code:
using System;
using System.Windows.Forms;
using SoundFingerprinting;
using SoundFingerprinting.Audio;
using SoundFingerprinting.Builder;
using SoundFingerprinting.DAO.Data;
using SoundFingerprinting.Data;
using SoundFingerprinting.InMemory;
namespace WindowsFormsApp3
{
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
}
    private readonly IModelService modelService = new InMemoryModelService(); // store fingerprints in RAM
    private readonly IAudioService audioService = new SoundFingerprintingAudioService(); // default audio library

    public void StoreAudioFileFingerprintsInStorageForLaterRetrieval(string pathToAudioFile)
    {
        var track = new TrackInfo("GBBKS1200164", "Skyfall", "Adele", 290d);

        // create fingerprints
        var hashedFingerprints = FingerprintCommandBuilder.Instance
                                    .BuildFingerprintCommand()
                                    .From(pathToAudioFile)
                                    .UsingServices(audioService)
                                    .Hash()
                                    .Result;

        // store hashes in the database for later retrieval
        modelService.Insert(track, hashedFingerprints);
        textBox2.Text = modelService.ReadTrackById("GBBKS1200164").Title.ToString();
    }

    public TrackData GetBestMatchForSong(string queryAudioFile)
    {
        int secondsToAnalyze =10; // number of seconds to analyze from query file
        int startAtSecond = 0; // start at the begining

        // query the underlying database for similar audio sub-fingerprints
        var queryResult = QueryCommandBuilder.Instance.BuildQueryCommand()
                                             .From(queryAudioFile, secondsToAnalyze, startAtSecond)
                                            // .UsingServices(modelService, audioService)
                                             .UsingServices(modelService, audioService)
                                             .Query()
                                             .Result;

        return queryResult.BestMatch.Track;
    }

    private void button1_Click(object sender, EventArgs e)
    {
        StoreAudioFileFingerprintsInStorageForLaterRetrieval(@"D:\prueba\original\Skyfall - Adele1.wav");
        TrackData oTrackData= GetBestMatchForSong(@"D:\prueba\test\Skyfall - Adele1.wav");
        textBox1.Text = oTrackData.Artist;
    }
}

}

Have you got any solution ?

Since you are updating the UI components you can't just access Result from a Task that completes asynchronously. You should take care of tasks current synchronization context when updating the UI with the result generated by an async library. Here you will find explanations of how to properly use Tasks within an application that updates the UI.
Specifically this line:

With that in mind, consider this (faulty) reimplementation of button1_Click:

private void button1_Click(object sender, RoutedEventArgs e)
{
Task s = LoadStringAsync();
textBox1.Text = s.Result; // warning: buggy
}
There’s an exceedingly good chance that this code will hang your application.  The Task.Result property is strongly typed as a String, and thus it can’t return until it has the valid result string to hand back; in other words, it blocks until the result is available.  We’re inside of button1_Click then blocking for LoadStringAsync to complete, but LoadStringAsync’s implementation depends on being able to post code asynchronously back to the UI to be executed, and the task returned from LoadStringAsync won’t complete until it does.  LoadStringAsync is waiting for button1_Click to complete, and button1_Click is waiting for LoadStringAsync to complete. Deadlock!
You need to make your method async and wait for the result with await keyword. Do not access Result directly if you are using it on UI thread.

Thank you!..
My code works with the following changes :
using System;
using System.Threading.Tasks;
using System.Windows.Forms;
using SoundFingerprinting;
using SoundFingerprinting.Audio;
using SoundFingerprinting.Builder;
using SoundFingerprinting.DAO.Data;
using SoundFingerprinting.Data;
using SoundFingerprinting.InMemory;
namespace WindowsFormsApp3
{
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
}
    private readonly IModelService modelService = new InMemoryModelService(); // store fingerprints in RAM
    private readonly IAudioService audioService = new SoundFingerprintingAudioService(); // default audio library

    public async  Task StoreAudioFileFingerprintsInStorageForLaterRetrieval(string pathToAudioFile)
    {
        var track = new TrackInfo("GBBKS1200164", "Skyfall", "Adele", 290d);

        // create fingerprints
        var hashedFingerprints = await FingerprintCommandBuilder.Instance
                                    .BuildFingerprintCommand()
                                    .From(pathToAudioFile)
                                    .UsingServices(audioService)
                                    .Hash();
                                    //.Result;

        // store hashes in the database for later retrieval
        modelService.Insert(track, hashedFingerprints);
      // textBox2.Text = modelService.ReadTrackById("GBBKS1200164").Title.ToString();
    }

   // public TrackData GetBestMatchForSong(string queryAudioFile)
    public  async Task<TrackData> GetBestMatchForSong(string queryAudioFile)
    {
        int secondsToAnalyze =10; // number of seconds to analyze from query file
        int startAtSecond = 0; // start at the begining

        // query the underlying database for similar audio sub-fingerprints
        var queryResult = await QueryCommandBuilder.Instance.BuildQueryCommand()
                                             .From(queryAudioFile, secondsToAnalyze, startAtSecond)
                                             // .UsingServices(modelService, audioService)
                                             .UsingServices(modelService, audioService)
                                             .Query();
                                             //.Result;

        // return  Task.FromResult(queryResult.BestMatch.Track);
        return  queryResult.BestMatch.Track;
    }

    private async  void button1_Click(object sender, EventArgs e)
    {

        await StoreAudioFileFingerprintsInStorageForLaterRetrieval(@"D:\prueba\original\testaudio1.wav");
        TrackData oTrackData = await GetBestMatchForSong(@"D:\prueba\test\testaudio1.wav");
        textBox1.Text = oTrackData.Artist.ToString();

    }

}

}

Thanks for help, it worked.
But I was using it for speaker recognition, but I think it doesn't find
track even if track slightly differs. Any suggestion?
Thanks
On Tue, Apr 23, 2019 at 12:21 PM Sergiu Ciumac<EMAIL_ADDRESS>wrote:

Closed #118 https://github.com/AddictedCS/soundfingerprinting/issues/118
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AddictedCS/soundfingerprinting/issues/118#event-2293079996,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACR32AIISOMSPU6MSTDPQETPR2WXXANCNFSM4HBLQM5Q
.

Try using HighPrecisionQueryConfiguration and HighPrecisionFingerprintConfiguration for query and insertion. It will analyze a different spectrum range and depending on your setup may work better.


Rust colors have very little contrast

Im using Rust with nvim-lsp and tokyonight but the syntax highlighting doesnt seem to be working well. There is very little contrast between keywords, variable names, functions, etc.  Screenshot below.  I am using night mode.

Is there a way to fix this?

@folke thanks for quick response!
I have the below set in my init.vim
if (has("termguicolors"))
    set termguicolors
endif

I thought my terminal support true colors ( i use warp [https://github.com/warpdotdev/warp]) but maybe it doesnt, ill  need to look into it more.  when i use iterm2, which i think uses it by default, it looks like the below:

Do I need to use treesitter to get better syntax highlighting?  For example, on parameter names.

The screenshot shows the true colors are working, but you don't have treesitter enabled for that buffer indeed. Adding treesitter will make it like my screenshot.

This seems to have fixed it! thank you again for the quick feedback


Add black dependency and configure tools to avoid conflicts.

Added black and flake8-bugbear. Fixed one file where bugbear found an error.

Configured tools to avoid conflicts with each other. This included disabling checks for D202 and E231 because black does not enforce these.

This is the PR with all the substantive changes to the code; I do not intend to merge this PR since it will not ever pass tests. Instead, I will make all substantive changes here for your review, and then merge it into #685 where I will apply the automatically-generated consequences of lint decisions made here. If you are happy with the substance of this PR, let's merge #685.

Merged via #685.


Coveralls integration for monorepo

What's done
Combine coverage reports of multiple packages into one single lcov file, and then send it to coveralls.

Changes Unknown when pulling d5a79683003ff2bf5614a63e9eb70c15ba8fce97 on next-coveralls into ** on next**.

Lowered the threshold to 97% from 100% on coveralls.io settings.


Support for ordinal indicators in English?

Ordinal numbers, but not ordinal indicators, seem to not be supported (they are not supported in the native Date.parse() either). I came here looking for a library that would support those, wondering if it would be in scope of the project to add it?
Example:
> var d = moment('May 1st, 2010'); // date with ordinal indicator
> d.toString();
'Invalid date'
> var d = moment('May first, 2010'); // date with ordinal number
> d.toString();
'Sat May 01 2010 00:00:00 GMT+0100'

Passing a non-ISO string into Moment like that is just using the underlying Date() constructor. To get Moment to parse an arbitrary format, do this:
> moment('May 1st, 2010', 'MMMM Do, YYYY').toString();
"Sat May 01 2010 00:00:00 GMT-0400"

That doesn't solve the issue as we don't know what format we'll be getting
ahead of time.  (It's for a web scraper.) We'd like to be able to input a
string of that format, or any of the other accepted formats, in the style
of Date.parse().
I guess we could try Date.parse, and if it fails, do
moment('May 1st, 2010', 'MMMM Do, YYYY').toString();
and then maybe moment('May 1st, 2010', 'MMMM Do YYYY').toString();
etc., but it would be nice for this to be handled by moment.
Is extending the functionality of Date.parse() to accept other formats
within scope?
On Thu, Sep 8, 2016 at 6:33 PM, Isaac Cambron<EMAIL_ADDRESS>wrote:

Passing a non-ISO string into Moment like that is just using the
underlying Date() constructor. To get Moment to parse an arbitrary
format, do this:

moment('May 1st, 2010', 'MMMM Do, YYYY').toString();"Sat May 01 2010 00:00:00 GMT-0400"

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/moment/moment/issues/3423#issuecomment-245675844, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVbQO1egpkuViee0NBvcnMqjhCpcfNCks5qoEbpgaJpZM4J4HdF
.

Moment doesn't do any natural language parsing at all. When you pass a string with no formats, it checks to see if it's an ISO8601 string and if not just hands it to Date.parse() to see if it knows what to do (and we've even deprecated that handoff!). So just at a sort of fundamental scoping level we're not going to start adding code of the "figure out what this string means" variety.
One thing you can do is pass an array of strings and Moment. So if you tried Date.parse() and didn't get anything, you can do:
moment(str, ['MMMM Do, YYYY', 'MMMM DD YYYY', etc]


Typescript support?

Heya, would you be interested in typescript support?
I could make a PR for you if you wanted?

Thank you for your interest and support! Regarding the library, it's designed to be small and doesn't necessarily require TypeScript. Currently, we're utilizing JSDoc to provide type suggestions. If you have any further questions or feedback, feel free to share!


Update version strings for 1.4.0rc1

Jenkin's, test this please.

@tensorflow-jenkins test this please