TypeError: Cannot read property 'script' of undefined

Why do I have this error?
  4 | React = require('react');
  5 |
> 6 | script = React.DOM.script;
  7 |
  8 | if (typeof window !== "undefined" && window !== null) {
  9 |   if (window.GoogleAnalyticsObject == null) {

import ga from 'react-google-analytics'

const GAInitiailizer = ga.Initializer

  componentDidMount(){
    ga('create', 'UA-XXX', 'auto')
    ga('send', 'pageview')
  }

Because you are using a newer version of React where React.DOM is a separate package, and that's why it fails.


Earthly for builds?

Hi, I'm wondering if https://github.com/earthly/earthly could be beneficial to Kong's build. It might help with standardizing the build as container-based. There's a lot of complexity in this repo, which might require some effort, but I'm happy to put together a demo PR to show what Earthly can do, if this is interesting.

Hi @vladaionescu,
It would be very interesting to see a POC. Could be minimal, only building a single package.
Cheers!

Hi @gszr - I got the .deb packaging to work in this demo PR: https://github.com/vladaionescu/kong-build-tools/pull/1. (This also requires this kong/Earthfile https://github.com/vladaionescu/kong/pull/1).
Curious what you think!

Hi @vladaionescu! I will take a look as soon as I have some time. Thanks for putting this together!

Closing for inactivity and the sunset of this repository, please reopen if needed : )


libfreetds.a not built for OS X anymore

Hi Martin
Your SQLClient wrapper has been very useful so far. Thanks!
I know it is "for iOS" but until libfreetds.a was updated a month ago, things built fine on OS X.
However now: "URGENT: building for OSX, but linking in object file libfreetds.a(dblib.o) built for iOS. Note: This will be an error in the future."
Earlier you indicated you built freetds using a build.sh here: https://github.com/patchhf/FreeTDS-iOS
But that repo is gone (and ... for iOS).
Do you have a libfreetds.a build for OS X?
Dennis

I have a fork at https://github.com/martinrybak/FreeTDS-iOS. Can you submit a PR for updating it for OS X?

Hi Martin

I have a fork at https://github.com/martinrybak/FreeTDS-iOS https://github.com/martinrybak/FreeTDS-iOS. Can you submit a PR for updating it for OS X?

I finally got that to run, but it builds libsybdb.a. I can see why it does, but I had expected this to build libfreetds.a.
Obviously I am missing something here. Any pointers would be hugely appreciated
Dennis

That's what the FreeTDS binary is normally called. In SQLClient I simply renamed it to libfreetds. I'll rename it there for consistency.

Hi Martin
Thanks for responding to my GH issue ;-)
I wish I could submit a pull request, but whatever I try I cannot get freetds to compile on osx ;-(
Dennis

On 22 Oct 2016, at 23:08, martinrybak<EMAIL_ADDRESS>wrote:
I have a fork at https://github.com/martinrybak/FreeTDS-iOS https://github.com/martinrybak/FreeTDS-iOS. Can you submit a PR for updating it for OS X?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/martinrybak/SQLClient/issues/32#issuecomment-255554176, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOiTPIXb0D7n46xZRfxt_4VBe5D1fvKks5q2ntmgaJpZM4Kd3u2.

Hi Martin
Thanks for clearing that up.
Still no joy in getting freetds to build for OS X, let alone a universal binary as before.
Did fwaddle have anything to offer?
Thanks for your continued interest!
Dennis

On 25 Oct 2016, at 20:26, martinrybak<EMAIL_ADDRESS>wrote:
That's what the FreeTDS binary is normally called. In SQLClient I simply renamed it to libfreetds. I'll rename it there for consistency.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/martinrybak/SQLClient/issues/32#issuecomment-256126374, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOiTCkZJmXXw2CBkrsjAv6IOs6dG4O8ks5q3km-gaJpZM4Kd3u2.

Hi Dennis,
The issue is that since Xcode 7 (I think), Apple wants you to build a specific version for OSX whereas you used to be able to use the binary that was built for the simulator - that is no longer allowed. The build script needs to be updated to handle that.
Fwaddle.

Hi Martin / Fwaddle
Spent two hours trying to patch lib_build.sh with what seems needed from the openSSL macosx example script... and failed.
My experience with this amounts to zero, making this quite hard. I am sorry.
Dennis

On 26 Oct 2016, at 23:31, Mof<EMAIL_ADDRESS>wrote:
Hi Dennis,
The issue is that since Xcode 7 (I think), Apple wants you to build a specific version for OSX whereas you used to be able to use the binary that was built for the simulator - that is no longer allowed. The build script needs to be updated to handle that.
Fwaddle.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/martinrybak/SQLClient/issues/32#issuecomment-256483139, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOiTAbc-0hAvKfxMNhP1Ijd-AviejRrks5q38afgaJpZM4Kd3u2.

Hi Dennis,
I've had a crack at the build script (see my pull request) but it's not well tested. I ran it here and it seems to work but I don't have much time to plug the lib file into my project and seeing if it's actually correct.

Hi @fwaddle many thanks for that! Please see my response here: https://github.com/martinrybak/FreeTDS-iOS/pull/2#issuecomment-257823671


Could Hue oozie job submit not to force the time zone as UTC+0000?

Hue oozie force set default time zone as UTC+0000.
while oozie now support other timezone, could Hue maintain a config setting of personal time zone?
by benefit of it, we would not need to manual change the timezone for each job submit?

As I ready config oozie time zone as GMT+08:00, by hue oozie default time zone submit, it run into error.

now, we have to manual change the timezone before submit,e.g. change 2015-08-03T11:20Z to 2015-08-03T11:20+0800
ps.. we do not want to using UTC+0000 timezone, we want using local customerized timezone, together with all job time display.

Yes, currently Hue is hardcoded to use UTC
We should support https://issues.cloudera.org/browse/HUE-1910
We could pickup the timezone:

from the hue server configuration, and provide a way to override it in the liboozie section of the hue.ini.
from the browser of the client

Side question, how come do you have a '1' in the first screenshot next to the 'Do a dryrun...'?

Thanks for quick response:)
"Side question, how come do you have a '1' in the first screenshot next to the 'Do a dryrun...'?"
I add it into src code just debugging to find the template for this page.
And I added following code into the file apps/oozie/src/oozie/templates/editor2/submit_job_popup.mako
for temperately use, which I did not need to change anything before commit job for most usage cases.
 <script type="text/javascript">
   if($("#id_form-3-value").length<=0){
       $("#id_form-1-value").val(moment().format("YYYY-MM-DD[T]HH:mm") + '+0800');
       $("#id_form-2-value").val(moment('2020-01-01',"YYYY-MM-DD").format("YYYY-MM-DD[T]HH:mm") + '+0800');
    }else{
       $("#id_form-1-value").val(moment().format("YYYY-MM-DD[T]HH:mm") + '+0800');
       $("#id_form-2-value").val(moment().format("YYYY-MM-DD[T]HH:mm") + '+0800');
       $("#id_form-3-value").val(moment('2020-01-01',"YYYY-MM-DD").format("YYYY-MM-DD[T]HH:mm") + '+0800');
    }
</script>

vote for this  issue.  I 'am also using hue in china.

https://issues.cloudera.org/browse/HUE-1910 was done by @sai-krish


wasmparser: Make it possible to reuse FuncValidator

Current State & Problem
Currently users of wasmparser have to instantiate a FuncValidator for every Wasm function in a Wasm module that they want to validate. For larger Wasm modules such as spidermonkey.wasm the number of Wasm function is equal to 11518. FuncValidator itself build on top of OperatorValidator which houses multiple Vec-based buffers that may be resized multiple times for each of those functions.
Proposal
What we could do instead is to make it possible to reuse a single FuncValidator for all of those 11518 Wasm functions and thereby avoiding re-allocating heap memory over and over.
In wasmi we did something similar with the wasmi translation engine and got pretty good results from it.
Requirements
This proposal requires a slight redesign of the FuncValidator API. The new requirements are:

The underlying state of the FuncValidator (namely OperatorValidator) or the FuncValidator itself must be constructible without pre-assigning it with a Wasm function. fn new(resources: impl WasmModuleResources, features: WasmFeatures) -> Self could be a potential constructor.
The FuncValidator then requires an API to turn it into "assigned" state where it is actually assigned to a function for validation purposes. fn func(&mut self, index: u32, ty: u32, offset: usize) -> Result<()>;
An assigned FuncValidator just operates the same way a FuncValidator works nowadays.
The finish method on FuncValidator implicitly unassigns the FuncValidator again to allow it to be used for the next function.

Error Handling
This API should return an Err if an unassigned FuncValidator is used as if it was assigned or if an assigned FuncValidator is reassigned before finishing validation of the currently assigned function.
The above API proposal could also be formulated into a more strongly typed implementation where it is impossible to enter the aforementioned state transitions guarded by the type system. This has to be explored.
Parallel Validation
For parallel validation of Wasm functions another requirement to the new API is that it should ideally be possible to create pools of reusable FuncValidators.

I think the best way to solve this would probably be some sort of opaque struct FuncValidatorAllocations { ... } which can be extracted and inserted into a validator. That way a validation thread could have a single set of the allocations which it uses to create the validator and then extracts from the validator when finished. This gets a little tricky with how function validators are created by the main validator and things like locals are allocated on creation of the validator. One possibility there would be to return state which can be used to create a function validator from the main validator instead of the function validator itself, deferring pairing with the allocation resource until it's time to run the actual validator.

As a reference point the wasmi PR that introduces reusable allocations provided roughly 10% performance boost: https://github.com/paritytech/wasmi/pull/411

I think the best way to solve this would probably be some sort of opaque struct FuncValidatorAllocations { ... } which can be extracted and inserted into a validator. That way a validation thread could have a single set of the allocations which it uses to create the validator and then extracts from the validator when finished. This gets a little tricky with how function validators are created by the main validator and things like locals are allocated on creation of the validator. One possibility there would be to return state which can be used to create a function validator from the main validator instead of the function validator itself, deferring pairing with the allocation resource until it's time to run the actual validator.

How about just feeding a &mut FuncValidatorAllocations instead of taking ownership?
That will cause an indirection but it will be less painful for the API.
This is what we did in wasmi and while it is not perfect compared to the ownership-taking variant we still managed to receive a 10% win.
I will experiment with both versions and look what works better.

Sure yeah that also seems reasonable to me. Wasmtime has a perhaps different use case than what wasmi may be exercising which is what I'm trying to handle which is that validation of the module produces a FuncValidator-per-function which is then, concurrently on many threads, validated afterwards. In that sense the time of creation of the FuncValidator isn't connected to where the allocations would be stored, which is instead some sort of thread-local data structure or something like that during the parallel validation.
That being said I'm not wed to any particular shape of API so long as it fits the constraints, I'm happy to defer.

Sure yeah that also seems reasonable to me. Wasmtime has a perhaps different use case than what wasmi may be exercising which is what I'm trying to handle which is that validation of the module produces a FuncValidator-per-function which is then, concurrently on many threads, validated afterwards. In that sense the time of creation of the FuncValidator isn't connected to where the allocations would be stored, which is instead some sort of thread-local data structure or something like that during the parallel validation.
That being said I'm not wed to any particular shape of API so long as it fits the constraints, I'm happy to defer.

Is the compilation of Wasm function lazy in Wasmtime? Like, Wasmtime only validates AND/OR compiles a function if and only if it is actually used? That's something we are exploring with a newer engine for wasmi that uses register machine based bytecode with a heavier compilation phase.
Obviously this unfortunately adds slight overhead upon calling functions.

Nah it's just deferred to later. The module's "spine" is first validated which produces type information and a bunch of functions to validate, and then later in the compilation process all those functions are, in parallel using rayon, compiled to machine code.

Sure yeah that also seems reasonable to me. Wasmtime has a perhaps different use case than what wasmi may be exercising which is what I'm trying to handle which is that validation of the module produces a FuncValidator-per-function which is then, concurrently on many threads, validated afterwards. In that sense the time of creation of the FuncValidator isn't connected to where the allocations would be stored, which is instead some sort of thread-local data structure or something like that during the parallel validation.
That being said I'm not wed to any particular shape of API so long as it fits the constraints, I'm happy to defer.

Is the compilation of Wasm function lazy in Wasmtime? Like, Wasmtime only validates AND/OR compiles a function if and only if it is actually used? That's something we are exploring with a newer engine for wasmi that uses register machine based bytecode with a heavier compilation phase.
Obviously this unfortunately adds slight overhead upon calling functions.

Sure yeah that also seems reasonable to me. Wasmtime has a perhaps different use case than what wasmi may be exercising which is what I'm trying to handle which is that validation of the module produces a FuncValidator-per-function which is then, concurrently on many threads, validated afterwards. In that sense the time of creation of the FuncValidator isn't connected to where the allocations would be stored, which is instead some sort of thread-local data structure or something like that during the parallel validation.
That being said I'm not wed to any particular shape of API so long as it fits the constraints, I'm happy to defer.

Is the compilation of Wasm function lazy in Wasmtime? Like, Wasmtime only validates AND/OR compiles a function if and only if it is actually used? That's something we are exploring with a newer engine for wasmi that uses register machine based bytecode with a heavier compilation phase.

Wasmtime has a perhaps different use case than what wasmi may be exercising

Yeah definitely, in wasmi we cannot really use multi-threading since wasmi is primarily executed as Wasm that has no multi-threading. So we have to make single threaded compilation as efficient as possible.
However, I am sure we can find an efficient reusable API that profits both, Wasmtime and wasmi use cases. :)


Video on iOS Safari not playing

Library Affected:
workbox v6.1.5
Browser & Platform:
iOS Safari (only)
Issue or Feature Request Description:
This is my config and the video is working in all browsers, except iOS Safari (without SW the video plays well, or just excluding with exclude: [/\.mp4$/].
        new WorkboxPlugin.GenerateSW({
          swDest: 'sw.js',
          cleanupOutdatedCaches: true,
          inlineWorkboxRuntime: true,
          clientsClaim: true,
          skipWaiting: true,
        }),

When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.

Hello @artola!
There's guidance at https://developers.google.com/web/tools/workbox/guides/advanced-recipes#cached-av for playing back cached media. It's a little more involved than what you could accomplish with your basic GenerateSW config that uses the default precaching behavior.
Switching to using the InjectManifest plugin along with a handwritten swSrc, and adding in the code specific to your media playback route would be your best best.
Let us know if that doesn't put you in the right direction.


Export incorrectly squashes the env path

It appears as though some commands, like tk export, try to wrongly make the path absolute, by squashing ../<something>/ into ./, which is not correct. Most other commands, like show, do work.
Env info
Using tanka v0.20.0 (latest at the time of writing)
Reproduction script

Reproduction script
#!/usr/bin/env bash
set -euo pipefail

TMP_PATH="/tmp/tanka_export_path"
MAIN="$(cat - <<EOF
{
  "namespace": {
    "apiVersion": "v1",
    "kind": "Namespace",
    "metadata": {
      "labels": {
        "kubernetes.io/metadata.name": "default"
      },
      "name": "default"
    }
  }
}
EOF
)"

if [ -e "${TMP_PATH}" ]; then
  echo "The TMP Path already exist at ${TMP_PATH}" >&2
  echo "Please delete it to run the script again" >&2
  exit 1
fi

mkdir "${TMP_PATH}"
cd "${TMP_PATH}"

set -x

mkdir something
cd something

echo "##### Preparing env #####" >&2
tk init
cat - <<<"${MAIN}" >| environments/default/main.jsonnet

echo "##### Showing from something dir #####" >&2
tk show environments/default --dangerous-allow-redirect | cat -
echo "##### Showing export from something dir #####" >&2
tk export ../something_export environments/default
ls ../something_export
cat ../something_export/*.yaml

mkdir ../other
cd ../other

echo "##### Showing from other dir #####" >&2
tk show ../something/environments/default --dangerous-allow-redirect | cat -
echo "##### Showing export from other dir #####" >&2
tk export ../other_export ../something/environments/default
ls ../other_export
cat ../other_export/*.yaml

echo "##### DONE #####" >&2

Reproduction script logs
./reproduce.sh
+ mkdir something
+ cd something
+ echo '##### Preparing env #####'
##### Preparing env #####
+ tk init
GET https://github.com/grafana/jsonnet-libs/archive/98c3060877aa178f6bdfc6ac618fbe0043fc3de7.tar.gz 200
GET https://github.com/jsonnet-libs/k8s-libsonnet/archive/4be83346f2c5b06a03cb8ee726ec66aab33a60bb.tar.gz 200
Directory structure set up! Remember to configure the API endpoint:
`tk env set environments/default --server=https://<IP_ADDRESS>:6443`
+ cat -
+ echo '##### Showing from something dir #####'
##### Showing from something dir #####
+ tk show environments/default --dangerous-allow-redirect
+ cat -
apiVersion: v1
kind: Namespace
metadata:
  labels:
    kubernetes.io/metadata.name: default
  name: default
+ echo '##### Showing export from something dir #####'
##### Showing export from something dir #####
+ tk export ../something_export environments/default
Loading environments/default from /tmp/tanka_export_path/something/environments/default/main.jsonnet
Loaded environments/default from /tmp/tanka_export_path/something/environments/default/main.jsonnet, time elapsed: 5.195276ms
+ ls ../something_export
manifest.json  v1.Namespace-default.yaml
+ cat ../something_export/v1.Namespace-default.yaml
apiVersion: v1
kind: Namespace
metadata:
  labels:
    kubernetes.io/metadata.name: default
  name: default
+ mkdir ../other
+ cd ../other
+ echo '##### Showing from other dir #####'
##### Showing from other dir #####
+ tk show ../something/environments/default --dangerous-allow-redirect
+ cat -
apiVersion: v1
kind: Namespace
metadata:
  labels:
    kubernetes.io/metadata.name: default
  name: default
+ echo '##### Showing export from other dir #####'
##### Showing export from other dir #####
+ tk export ../other_export ../something/environments/default
Error: finding root: stat /tmp/tanka_export_path/other/environments/default/main.jsonnet: no such file or directory

Reproduction description
To reproduce, simply create tanka environment, then create a new, empty folder and from within it try to export your environment.
Having following structure:
$ tree . -L 2
.
├── other
└── something
    ├── environments
    ├── jsonnetfile.json
    ├── jsonnetfile.lock.json
    ├── lib
    └── vendor

5 directories, 2 files

Running the tk export from something works as expected, but running tk export exportdir ../something/environments/default results in tanka trying to export $PWD/environments/default (as if ../ caused ../something/ to be deleted and appended to $PWD).:
Exporting from something:
$ tk export ../something_export environments/default
Loading environments/default from /tmp/tanka_export_path/something/environments/default/main.jsonnet
Loaded environments/default from /tmp/tanka_export_path/something/environments/default/main.jsonnet, time elapsed: 5.195276ms

Exporting from other:
$ tk export ../other_export ../something/environments/default
Error: finding root: stat /tmp/tanka_export_path/other/environments/default/main.jsonnet: no such file or directory

Can still reproduce 🙂


Change comment

Keeping things consistent.

Thanks! 👍

No, thank you! I've learned so much from this example project.


Is this possible to run decode.py in Mac OS 10.14 | Query

Hi there,
I haven't looked at this code in literal ages, but decode.py is very linux specific (it uses the alsaaudio package to open the audio stream for the microphone).
There's some facility for opening pre-recording WAV files but that was used for interactive testing and debugging, and thus the code flow doesn't actually do any decoding.
If you're handy with python it wouldn't be super hard to fix. I'm a bit busy these days with $dayjob so I can't commit to any specific timeframe to fixing it myself.


Translation Strings are missing!

In Minecraft 1.19.4 on My language I have this situation:

Is it Mod-side or Vanilla-side trouble?

I didn't add any translation strings yet as that would have made the toolbar layout way more complicated, and I didn't think there was much demand for it since commands are written in english anyways and the command block interface really isn't something that non-technical players will see very often. I'll have to overhaul parts of the code anyways so I'll add translation strings then, but translations for a given language will have to be submitted by people who speak it.

I didn't add any translation strings yet as that would have made the toolbar layout way more complicated, and I didn't think there was much demand for it since commands are written in english anyways and the command block interface really isn't something that non-technical players will see very often. I'll have to overhaul parts of the code anyways so I'll add translation strings then, but translations for a given language will have to be submitted by people who speak it.

Thank You for the answer!

Translation strings have been added. The mod currently supports english and german, if you want to submit your own translation for another language you can open a pull request


codec/context: Defer ticks_per_frame-calculation

Current hard-coded 1 ticks_per_frame assumes that framerate = 1/time_base. This is most often fine, except when re-encoding a source with frames in non-fps intervals. Explicitly setting higher time base works out OK for some codecs (libx264), but not with libvpx, which uses ticks_per_frame and time_base to measure time for rate-control. The net effect is that encoding with high-precision frame-timing for VP8 and VP9 does not work in PyAV.

Not sure about the failing test. It fails on "doc" generation, and I'm not how my change could have caused this error.

This looks like an interesting PR, could you rebase it on top of main to see if that shakes out the CI issue?
@mikeboers any opinion on this PR?

@rawler I've rebased your PR on top of the latest code. Could you explain a bit more where this logic is coming from, is there perhaps some equivalent code in the ffmpeg command line code?

The code was devised when we were transcoding to VP9, and noticed that the rate-control did not seem to work at all according to expectations. It seems the encoder uses the ticks_per_frame-field to figure out how much time has passed, and when encoding 25fps for webm (for example), the ticks are typically in ms, so 40 for each frame. With setting this field, we got it working.
Looking at ffmpeg, I'm not sure how it's solved there. I can't see ticks_per_frame being set anywhere. I believe it may work by using avcodec_open2 for all new encoder-contexts, which does not set ticks_per_frame but seems to rather adjust time_base to match the default ticks_per_frame.
In either case, we've been running with this proposed patch in production for a while now. A colleague have found a corner-case in very large time-bases leading to int-overflow. Asking him now for permission to share.

See my comment in #789 : would it be sufficient to make ticks_per_frame writable?

Sorry for very slow feedback. Had some time to look at this again today, and I now fail to repro the original case that failed for me. (Basically, bitrates going off the scales when encoding to VP9 and WebM, and incoming frames had high-precision time-stamps carried over.)
Not sure why, either this only happened for specific content (I've been testing with noise), or maybe newer versions of libvpx has stopped relying on the frame-duration so much. (ticks-per-frame is transparently forwarded as frame-duration to VPX)
In any case I guess we can close this PR, in favor or the alternate one (allowing setting ticks-per-frame would also allow different durations per-frame)

Thanks for reporting back!


Failed to connect to Navidrome

Hello,
i have this error when i start asknavidrome :
2022-12-06 22:05:04,713 - asknavidrome.subsonic_api - DEBUG - Connected to Navidrome
2022-12-06 22:05:04,713 - asknavidrome.subsonic_api - DEBUG - In function ping()
2022-12-06 22:05:04,841 - asknavidrome.subsonic_api - ERROR - Failed to connect to Navidrome
My url and user/password are ok, i test it.
I have no log in navidrome for this error.
Operating System
Unraid/docker
Logs
2022-12-06 22:05:04,712 - root - INFO - AskNavidrome 0.6!
2022-12-06 22:05:04,712 - root - DEBUG - Getting configutration from the environment...
2022-12-06 22:05:04,712 - root - INFO - Skill ID set to: amzn1.ask.xxxxxxxx
2022-12-06 22:05:04,712 - root - INFO - Minimum song count is set to: 50
2022-12-06 22:05:04,712 - root - INFO - The URL for Navidrome is set to: https://navidrome.xxxxxx.fr
2022-12-06 22:05:04,712 - root - INFO - The Navidrome user name is set to: xxxxxxx
2022-12-06 22:05:04,712 - root - INFO - The Navidrome password is set
2022-12-06 22:05:04,712 - root - INFO - The Navidrome port is set to: 443
2022-12-06 22:05:04,712 - root - INFO - The Navidrome API path is set to: /rest
2022-12-06 22:05:04,712 - root - INFO - The Navidrome API version is set to: 1.16.1
2022-12-06 22:05:04,712 - root - DEBUG - Configuration has been successfully loaded
2022-12-06 22:05:04,712 - root - DEBUG - Log level set to DEBUG
2022-12-06 22:05:04,712 - root - DEBUG - MediaQueue object created...
2022-12-06 22:05:04,713 - asknavidrome.subsonic_api - DEBUG - Connected to Navidrome
2022-12-06 22:05:04,713 - asknavidrome.subsonic_api - DEBUG - In function ping()
2022-12-06 22:05:04,841 - asknavidrome.subsonic_api - ERROR - Failed to connect to Navidrome
2022-12-06 22:05:04,964 - root - INFO - AskNavidrome Web Service is ready to start!
2022-12-06 22:05:04,965 - root - WARNING - AskNavidrome debugging has been enabled, this should only be used when testing!

Cloudflare block request, it's ok now ;)


add goimports as a go fixer

ALEFixSuggest only shows gofmt as a suggested fixer, but it would be good to have goimports as a fixer to automatically import packages.
I can take a stab at adding it, but would like to know if there are any gotchas that I can't see, because it seems like an obvious fixer that would have been added for go.
Thanks

Sounds like a good idea.

Fixed with #1123


Refactor trader bot and get working with datanode / wallet V2 APIs

In order to have stable bots on our networks we need to refactor the bots and get working with V2 datanode APIs

[ ] run bots locally against Devnet1
[ ] integrate into the infra
[ ] get running on all networks (dev,stag3&1,testnet)

to be done in conjunction with:

https://github.com/vegaprotocol/traderbot/issues/201

Closing as completed.
Any new bugs/issues found during integration with networks / VC should be raised as new issues


V1.26.0

merge otel V1.26.0
add instrumentation
#1
#2
#3
#4
#5
新增guance change log

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 15 committers have signed the CLA.:x: siyuniu-ms:x: sfriberg:x: heyams:x: laurit:x: dependabot[bot]:x: opentelemetrybot:x: mateuszrzeszutek:x: ericsyh:x: shuwpan:x: rahuldimri:x: niteshs7:x: kaibocai7:x: trask:x: dmarkwat:x: liurui859liurui859 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


instance in js_methods missing model variables

Consider this MWE where an image is continuously updated in the background and continuously queried by the client:
module App

using JpegTurbo
using ColorTypes
using GenieFramework

@genietools

snap() = rand(RGB, 100, 100)

img = Ref(snap())
Threads.@spawn while true
    img[] = snap()
    sleep(0.1)
end

route("/frame") do
    respond(String(jpeg_encode(img[])), :jpg)
end

@app MyApp begin
    @out imageurl = "/frame"
end

ui() = Html.div([
                 imageview(src=:imageurl, basic=true, style="max-width: 100px")
                ])

Stipple.js_methods(::MyApp) = """updateimage: async function () { this.imageurl = "frame#" + new Date().getTime() }"""

Stipple.js_created(::MyApp) = "setInterval(this.updateimage, 100)"

@page("/", ui)

end

The resulting window is empty:

although, if I navigate to  frame manually I can see the frame:

and the console states that:
[Vue warn]: Property or method "imageurl" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

(found in <Root>) vue.js:634:17
    VueJS 11

versions:
pkg> st
Status `~/tmp/Project.toml`
  [3da002f7] ColorTypes v0.11.4
  [a59fdf5c] GenieFramework v1.26.11
  [b835a17e] JpegTurbo v0.1.5

Well, if you use an explicit app, you should also call it in thepage macro

How exactly, is it in the docs somewhere, apologies if so.
help?> @page
  @page(url, view)

  Registers a new page with source in view to be rendered at the route url.

  Usage

  @page("/", "view.html")

It's a general pattern:
All New Reactive API macros can be called with an explicit model type in the first position
@methods "
    f1: function() {console.log('Hello')}
    f2: function(name) {console.log(name)}
"

@methods MyApp "
    f1: function() {console.log('Hello')}
    f2: function(name) {console.log(name)}
"

there's one exception with the @page macro:
@page("/", ui)
@page("/", ui, model = MyApp)

I think we can close this now.


How to override default media queried component styles?

Hey there,
so the only way i could find to do it in createMuiTheme() is:
overrides: {
  MuiToolbar: {
      gutters: {
        '@media (min-width: 600px)': {
          paddingLeft: 0,
          paddingRight: 0,
        },
      },
    },
  }

Problem here is that i need to come up with my own breakpoint values while it should rather use the [theme.breakpoints.up('sm')] approach of makeStyles(), using the default themes' breakpoint presets as values.
Is something like this or equivalent possible? If not, could this maybe be put on the ToDo list. I noticed a lot of people requiring this.
Thanks in advance.

Possibly related: when using overrides and responsiveFontSizes, I'm having a hard time apply font-size overrides because each automatically created breakpoint must be overriden manually.
I may go for a naughty !important to avoid adding a lot of code to handle this, but this isn't ideal.
One possible solution would be for the responsiveFontSizes function to apply to the overrides equally. Or else, if you have access to the theme context (as discussed in this issues) at least this would be easier.

Possibly related: when using overrides and responsiveFontSizes, I'm having a hard time apply font-size overrides because each automatically created breakpoint must be overriden manually.
I may go for a naughty !important to avoid adding a lot of code to handle this, but this isn't ideal.
One possible solution would be for the responsiveFontSizes function to apply to the overrides equally. Or else, if you have access to the theme context (as discussed in this issues) at least this would be easier.

Rereading the original issue of @robations, it looks like we were covering #21757.
@robations Bootstrap has a responsive-font-size() function to generate custom values. If Material-UI was exposing a lower-level method, would it help? Maybe something to do:
components: {
  MuiToolbar: {
    styleOverrides: {
      gutters: {
        ...responsiveFontSize({ fontSize: 17 }),
      },
    },
  },
}

We have faced a similar issue in https://github.com/mui-org/material-ui/blob/e0b10d72d9e530dca56eefd08b49fe6141c523cf/docs/src/modules/branding/BrandingRoot.tsx#L185-L195 to implement the new branding: https://next.material-ui.com/branding/about/.
In any case, I'm closing as we are going off-topic.

Rereading the original issue of @robations, it looks like we were covering #21757.
@robations Bootstrap has a responsive-font-size() function to generate custom values. If Material-UI was exposing a lower-level method, would it help? Maybe something to do:
components: {
  MuiToolbar: {
    styleOverrides: {
      gutters: {
        ...responsiveFontSize({ fontSize: 17 }),
      },
    },
  },
}

We have faced a similar issue in https://github.com/mui-org/material-ui/blob/e0b10d72d9e530dca56eefd08b49fe6141c523cf/docs/src/modules/branding/BrandingRoot.tsx#L185-L195 to implement the new branding: https://next.material-ui.com/branding/about/.
In any case, I'm closing as we are going off-topic.

@oliviertassinari there's rarely a situation where I'm not happy to add more functions... But this could help. I have a niggling feeling about how very non-atomic the overrides are in this scheme, but I imagine changing this would involve rearchitecting how the responsive font sizes are applied.
For my use case, I eventually found another solution entirely (a new theme), but I could imagine the question coming up again.

@oliviertassinari there's rarely a situation where I'm not happy to add more functions... But this could help. I have a niggling feeling about how very non-atomic the overrides are in this scheme, but I imagine changing this would involve rearchitecting how the responsive font sizes are applied.
For my use case, I eventually found another solution entirely (a new theme), but I could imagine the question coming up again.

Hey there,
so the only way i could find to do it in createMuiTheme() is:
overrides: {
  MuiToolbar: {
      gutters: {
        '@media (min-width: 600px)': {
          paddingLeft: 0,
          paddingRight: 0,
        },
      },
    },
  }

Problem here is that i need to come up with my own breakpoint values while it should rather use the [theme.breakpoints.up('sm')] approach of makeStyles(), using the default themes' breakpoint presets as values.
Is something like this or equivalent possible? If not, could this maybe be put on the ToDo list. I noticed a lot of people requiring this.
Thanks in advance.

Did you find solution how to override ?

Hey there,
so the only way i could find to do it in createMuiTheme() is:
overrides: {
  MuiToolbar: {
      gutters: {
        '@media (min-width: 600px)': {
          paddingLeft: 0,
          paddingRight: 0,
        },
      },
    },
  }

Problem here is that i need to come up with my own breakpoint values while it should rather use the [theme.breakpoints.up('sm')] approach of makeStyles(), using the default themes' breakpoint presets as values.
Is something like this or equivalent possible? If not, could this maybe be put on the ToDo list. I noticed a lot of people requiring this.
Thanks in advance.

Did you find solution how to override ?

I would also like to know:)

I just used !important in the sx parameter to override the CSS and it seemed to work.
<Toolbar  sx={{ justifyContent: 'space-between', minHeight: '64px !important', pl: '16px !important', pr: '16px !important' }}>

I actually want to verride this class,
@media

I was fixed this ,
You can add another props direct to imported Tabs like this ,
scrollButtons="on"
It better works for mobile devices .
<Tabs
className={classes.tabs}
// variant="fullWidth"
value={value}
onChange={handleChange}
indicatorColor="primary"
textColor="primary"
variant="scrollable"
scrollButtons="on"
aria-label="scrollable auto tabs example"
        >

--
Đorđe Nikitović
Avantech Electronics doo
Živojina Žujovića 14
11050 Beograd, Srbija
mob. +381 (65) 4329-077
mob. +381 (69) 3102-661
web: www.avantech-qms.com
mail: @.***
On Thu, Aug 18, 2022 at 3:54 PM fratelo 98 @.***> wrote:

I actually want to verride this class,
@media


When I zoom to the markercluster, my application closes

I'm submitting a ...  (check one with "x")

[x] question
[x ] any problem or bug report

OS:  (check one with "x")

[ ] Android
[ x] iOS

cordova information:
com.googlemaps.ios 2.7.0 "Google Maps SDK for iOS"
cordova-android-play-services-gradle-release 1.4.2 "cordova-android-play-services-gradle-release"
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-facebook4 2.1.0 "Facebook Connect"
cordova-plugin-geolocation 4.0.1 "Geolocation"
cordova-plugin-googlemaps 2.3.2 "cordova-plugin-googlemaps"
cordova-plugin-inappbrowser 3.0.0 "InAppBrowser"
cordova-plugin-ionic-keyboard 2.1.2 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.2.1 "cordova-plugin-ionic-webview"
cordova-plugin-request-location-accuracy 2.2.3 "Request Location Accuracy"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova.plugins.diagnostic 4.0.8 "Diagnostic"
Current behavior:
I am using  IONIC V1.
I initially use a web service to obtain some locations, and this same web service returns me some routes with my icons. When the web service has been received, I use the markercluster and the icons of my bookmarks will be the icons that I receive from my web service.
I am trying to add to the makrers images that is hosted on my server. I'm using markercluster. Initially everything is going well, and the number 3 appears, since there are 3 nearby places. but when zooming, the application stops.

Expected behavior:
when doing the respective zoom, it should show the images that I am loading from my server, without any problem. this does not happen on android

            //I build this variable with the result of the web service
             $scope.aCoordenasSW=[

              {
                "position":{
                  "lng":lng,
                  "lat":lat
                },
                "icon":"http:\/\/tin.domovida.com\/Tin-Developer\/Images\/Tiendas\/Icon-TiendaVilladelRio2018-07-13.png",
                "distancia":distancia,//custom field
                "nit":data[i].nit,//custom field
                "nombre":data[i].name//custom field
              },
              {
                "position":{
                  "lng":lng,
                  "lat":lat
                },
                "icon":"http:\/\/tin.domovida.com\/Tin-Developer\/Images\/Tiendas\/Icon-Tiendalosyarumos2018-07-23.jpg",
                "distancia":distancia,//custom field
                "nit":data[i].nit,//custom field
                "nombre":data[i].name//custom field
              },
              {
                "position":{
                  "lng":lng,
                  "lat":lat
                },
                "icon":"http:\/\/tin.domovida.com\/Tin-Developer\/Images\/Tiendas\/Icon-TiendaManizales2018-07-14.png",
                "distancia":distancia,//custom field
                "nit":data[i].nit,//custom field
                "nombre":data[i].name//custom field
              }
          ]

            markerCluster= map.addMarkerCluster({
            boundsDraw: false,
            zoomOnClick: false,
            markers:$scope.aCoordenasSW,
            icons: [
                {min: 2, max: 100, url: "./img/i1.png", anchor: {x: 16, y: 16}},
                {min: 100, max: 1000, url: "./img/i2.png", anchor: {x: 16, y: 16}},
                {min: 1000, max: 2000, url: "./img/i3.png", anchor: {x: 24, y: 24}},
                {min: 2000, url: "./img/i4.png",anchor: {x: 32,y: 32}}
            ]
            },function(){
            });

I would really appreciate it if you can help me please.

Thank you very much for wanting to help me. It is difficult for me to modify my code since it works with geolocation, but I will try to have something to try. thank you very much.

@wf9a5m75  While I try to adapt my code, do you know what it can be? I suspect that the problem is the images.

@YeisonVelez11 how many markers have you added?
Performances are very poor with the plugin implementation of cluster when you got a lot of markers.
I recommend using https://github.com/mapbox/supercluster instead. I'm using it and is so much more efficient!

@YeisonVelez11 Thank you for sharing your project files.
Well, v2.3.2 is old.
https://github.com/YeisonVelez11/errormaps/blob/5c5f197e3e1d25e8ac31d4e990d6f33c0ada7c17/config.xml#L105
Using v2.3.8, I can't confirm your issue.

I recommend you use put icon files in your app or, put them on faster static serve servers, such as CDN or github pages. It seems your http server is bit slow.

@wf9a5m75  Within 4 hours I will be at my house. and I will try again.

now, I am using the latest version 2.3.8 and I am getting this error:
2018-07-31 01:02:01.004625-0500 TIN[8908:170493] [fail] url = http://tin.domovida.com/Tin-Developer/Images/Tiendas/Icon-TiendaVilladelRio2018-07-13.png
2018-07-31 01:02:01.006368-0500 TIN[8908:170617] Task <63CC78D5-5FF1-4904-AF81-AC09ED6682E1>.<1> HTTP load failed (error code: -999 [1:89])
2018-07-31 01:02:01.069009-0500 TIN[8908:170493] *** Terminating app due to uncaught exception 'GMSThreadException', reason: 'The API method must be called from the main thread'

ok, please update the repository.
You must commit the same code as you tested.

@wf9a5m75 Thanks. This problem only occurs on ios. your screenshot is taken by a phone with android( I believe) and I could try to share the code but it would have to be private, because for legal reasons I could go to jail. I would also need you to tell me your location when you use it to generate locations near you. But for now see if this error occurs in ios, maybe this is a clue to the problem.

Oh, I didn't notice you specify ios. I see, let me check out tomorrow.
If you need private support, please read here.
https://github.com/mapsplugin/cordova-plugin-googlemaps/blob/master/.github/ISSUE_TEMPLATE/private-support.md

@wf9a5m75 for now maybe if you try it on an ios device, you can reproduce the error. in my past comments the problem appears for an image.

I got the reason.
You specify http://tin.domovida.com/.../Icon-TiendaVilladelRio2018-07-13.png, but the server replies 301 Moved Permanently.
Then, redirected to https://tin.domovida.com/.../Icon-TiendaVilladelRio2018-07-13.png.

Because of this, cache mechanism does not work as intended.
That's why the app crashes.

I fixed the plugin, please reinstall from the multiple_maps branch.
$> cordova plugin rm cordova-plugin-googlemaps

$> cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#multiple_maps --variable ...

And you also need to modify your code https://tin.domovida.com instead of http://tin.domovida.com

@wf9a5m75  thanks, it solve my problem! you are the best


Conflict with React inside the content script

Hi,
i have a problem when i try to load the content script (with 'react' and 'react-dom' imported) when i'm in other websites that are developed also with React. It seems that rerenders the website after the content script is loaded and it causes a "conflict" with the current page and that makes that the page looks different (I mean, different when my extension is disabled).
I tried with dynamic imports but it is impossible because the dynamic imports code ran it the browser.
It is possible to isolate my React modal (rendered in the content script) to avoid the conflict with other React websites?
The content script code is similar to this (simplified):
import React from 'react';
import { render, unmountComponentAtNode } from 'react-dom';
import AddWebsiteModal from '../components/AddWebsiteModal/AddWebsiteModal';

function existsModalDivTag() {
  return document.getElementById('myapp-modal-webadd');
}

export function createProductModal(authData, websiteData) {
  console.log(websiteData);

  if (!existsModalDivTag()) {
    const element = document.createElement('div');
    element.setAttribute('id', 'myapp-modal-webadd');
    document.body.appendChild(element);

    return render(<AddWebsiteModal auth={authData} websiteData={websiteData} />, document.querySelector('#myapp-modal-webadd'));
  } else {
    unmountComponentAtNode(document.getElementById('myapp-modal-webadd'));
    document.getElementById('myapp-modal-webadd').remove();
  }
}

Thanks.

I forgot to share the solution. In the manifest.json i had to add the "run_at" property with the value "document_end".
Now "content_script" in manifest.json is like this:
{
    ...,
    "content_scripts": [{
        "matches": ["http://*/*", "https://*/*", "<all_urls>"],
        "js": ["contentScript.bundle.js"],
        "css": ["content.styles.css"],
        "run_at": "document_end"
    }],
    ...
}


TextEdit window blurred due to different offset on alternate frames.

Describe the bug
TextEdit window renders with different offset on alternate frames.
It takes a 60FPS video to see this. At 30 FPS, there's no jitter. So something is happening differently on alternate frames.

To Reproduce
Steps to reproduce the behavior:

Write application using egui/Rend3/wgpu.
Add a TextEdit box set to scroll upwards from the bottom.
Add lines to the text box.

Expected behavior

Should render identically at each frame.
Screenshots
https://user-images.githubusercontent.com/942608/224792416-a5abd95a-cc51-436e-b314-5d90503686d4.mp4

Desktop (please complete the following information):

OS: Linux 20.04 LTS
Version: 20.04 LTS

Additional context
Here's the code rendering that box:
            window.show(ctx, |ui| {
                //  Scroll area
                //  Ref: https://docs.rs/egui/latest/egui/containers/struct.ScrollArea.html#method.show_rows
                let text_style = egui::TextStyle::Body;
                let row_height = ui.text_style_height(&text_style);
                let total_rows = self.message.len();
                if total_rows == 1 {
                    //  Single-line message, center it.
                    ui.vertical_centered(|ui| {
                        ui.label(self.message[0].as_str());
                    });
                } else {
                    //  Multi-line message, can become scrollable.
                    egui::ScrollArea::vertical().show_rows(
                        ui,
                        row_height,
                        total_rows,
                        |ui, row_range| {
                            for row in row_range {
                                if row >= self.message.len() {
                                    break;
                                } // prevent scrolling off end
                                ui.label(self.message[row].as_str());
                            }
                        },
                    );
                };
                //  Dismiss button, if present
                if let Some(s) = &self.dismiss_button {
                    ui.vertical_centered(|ui| {
                        if ui.add(egui::Button::new(s)).clicked() {
                            dismissed = true; // dismiss
                        }
                    });
                };
            });
            if dismissed {
                self.is_open = false;
            } // do here to avoid borrow clash
        }

It looks like this bug is very sensitive to the height of the window. If I drag the window to a slightly different height, I can make the bug appear or disappear.

Found out what causes the problem. If the text is too wide for one line in a text edit window, the line wraps to multiple lines. When this happens, scrolling gets confused about window height.
To reproduce:
git clone https://github.com/John-Nagle/ui-mock.git
cd ui-mock
cargo build --release --examples
cd target/release/examples
./ui-mock

Now you're in a GUI program that doesn't do much. But click on the "Replay" bar, which gets you a file open dialog.
Find some JSON file. (It doesn't matter what the file is, its contents are ignored.)
There's a "message" box. Click on its arrow so it opens, and narrow it to minimum width. Down at the bottom of the screen,
there are some navigation arrows. They don't do much, but they display "Rotation: Left" and such in the message box.
Fool around with generating messages and dragging the bottom of the message box to adjust the height. With messages long enough to wrap, and for some message box heights, you get the blur effect.
So that's the bug.

Turns out that a Label long enough to need line wrap confuses the ScrollArea's height calculation. So, don't do that. As a workaround,  put .wrap(false) on the Label and .both on the ScrollArea. Long lines will then cause a horizontal scroll bar to appear.


Update documentation

Prevent infinite load of PlatformTabs. These were trying to use router.isReady which shouldn't be used outside of useEffect (link). This causes a progress bar to appear until the user navigates to a different page and then navigates back (e.g. for the Asset Provide Plugin), so remove that.
The validations objects link under the Cross-field Validation section in Content/Assets & Views was broken. Add a link to a relevant validations page.

@KVSRoyal when you get a chance, rebase against main, fork build should work after #97


SSH-dependent Packer provisioners not working with schedmd-v5-slurm images.

Describe the bug
When using the image-builder.yaml, if I supply custom shell_scripts arguments to packer build (or an Ansible conf, or anything that needs SSH) I get SSH connection failures. If I replace the schedmd-v5-slurm-22-05-8-hpc-centos-7 image family, with something like ubuntu-2210-amd64 SSH works fine. If I don't use SSH-dependent commands, the image build also works fine.
Steps to reproduce
Steps to reproduce the behavior:

Generate the image-builder.yaml build files with ghcp.
touch echo.sh and modify the packer/custom-image/defaults.auto.pkrvars.hcl to contain

shell_scripts = ["echo.sh"]

Follow the docs to build the image.

Expected behavior
I expect SSH to work and run the shell Packer provisioners.
Actual behavior
SSH does not work.
Version (ghpc --version)
Blueprint
image-builder.yaml
Output and logs
Build 'image-builder-001.googlecompute.toolkit_image' errored after 2 minutes 40 seconds: Packer experienced an authentication error when trying to connect via SSH. This can happen if your username/password are wrong. You may want to double-check your credentials as part of your debugging process. original error: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

Screenshots
If applicable, add screenshots to help explain your problem.
Execution environment

OS: [macOS]
Shell: [zsh]
go version: go version go1.20.2 darwin/arm64

Additional context
Before using hpc-toolkit, I was just using Packer independently but could not get Ansible provisioning + these slurm images to work. I get the same on a very minimal Packer+shell_scripts+schedmd-v5-slurm repo, too (where it also just goes away with plain ubuntu). Any pointers appreciated. Thanks.

Digging into this, I noticed when specifying ssh_username=packer in my config that I see GCP instance metadata ssh-keys for the packer user in the GCP UI. When I ssh to the Packer builder, the packer user did exist but sshd couldn't find the authorized_keys file for this user (and the user had a home dir listed in /etc/passwd, /home/packer, but it didn't exist). I gave wait_to_add_ssh_keys  incase there was some race, but had no luck. So, I decided to not figure this packer-ssh stuff out and just use use_os_login = true instead and it worked.
But it bothered me, so I dug through the slurm-gcp repo a bit and saw it is using ssh_clear_authorized_keys = true, and I remembered the weirdness about having no home dir, so I tried ssh_username=packer2 (different from the slurm-gcp default) and it worked.
I'm pretty deep into 'just try things and see what happens' and pretty far from 'I actually understand Packer', but it feels like there is some weirdness with chained Packer builds and the way ssh_clear_authorized_keys cleans up the user and how GCP ssh_keys metadata gets provisioned.
Anyway, maybe it makes sense to default user here and add a comment in the description explaining  why choosing 'packer' is probably a bad idea seems like an improvement. Also, maybe opening an issue in Packer with an even more minimal reproduction is nice - even if it just becomes a docs ticket. I may do that later.

The SSH issues are interesting and require some internal discussion and investigation.
I am wondering if your use case is blocked on having SSH access. Generally SSH access can be problematic for several reasons and so the HPC Toolkit is designed to support most use cases without needing SSH by using the startup_script input variable.
For more complex scenarios (staging large amounts of data, running multiple scripts, ansible playbooks) you can use the custom-image packer module in concert with the startup-script terraform module. This will stage all data and scripts in a GCS bucket and then provide vm metadata with instructions to download and execute each script. This will all happen without needing SSH access. This would entail defining additional runners on L45 for your other scripts and ansible and then following the command line instructions for that example to pass the script from the terraform deployment to the packer module.

The startup-script module probably solves my issues too, but I have other Packer builds using Ansible over SSH and I didn't want this one to be so special.
As I mentioned in my comment, I've changed the ssh_username to packer2 and unblocked myself. use_os_login also worked. The only thing that doesn't is using the user packer.

@stoksc, Thank you for this report. We have updated the default username in the HPC Toolkit image-builder module to be hpc-toolkit-packer which side steps this issue. I have also alerted the Slurm team to the behavior witnessed in this issue.
I am going to mark this bug as fixed upon our next release, which will have the updated username. Please follow up if you feel that it has not been addressed.

This fix is now on our develop branch which is periodically merged into our main branch and tagged with an official release. As each step in the process is taken, the information immediately below the commit description will automatically update with each branch and tag that contains the fix.


feat: endpoint for bot up status

Is your proposal related to a problem?
I'm trying to monitor my bot using Grafana, but using the bot main page as the checking endpoint puts unnecessary load on the bot itself.
Describe the solution you'd like
Can we make something like a /status endpoint, maybe just a JSON with status OK and an HTTP 200 response code, which we will call with monitoring services?
That can be a nice touch :)
Additional context
That can be useful when you are hosting in an untrusted cloud provider, or checking if your selfhosted at home bot is currently online or not.

Indeed if it's something well accepted upstream I'll try and do the implementation myself 👍

Ah yap, good point. I will add in later.

Actually, can you give me more idea what kind of information to be included rather than just ok?
I would say, following information is to be cached by trailing trade indicator job and show with /status

last processed time
current monitoring symbols
last buy time
last sell time
total orders per quote assets
total buy amount per quote assets
total sell amount per quote assets

I'm thinking also about uptime too, but the ones suggested are also good indeed :)

Just to be sure, anything fast to check possibly, so we can call it frequently without making any degradation of the bot's service.
I'd see also something with not private data like how much the bot is holding as such, or if you want that, make two separate endpoints, one with /status and the other with maybe /status/<TOKEN_STATUS_PRIVATE_DATA> (added via .env file) for private data, so we can catch both cases and handle both of them properly.

Just implemented the basic endpoint, for the more "private" endpoint (with mandatory token access in the endpoint itself) I'll let you decide on how to implement it, I'm still learning the tech stack and don't wanna mess it up more than I can add :P


refactor!: cleanup types

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.98%. Comparing base (3d289dc) to head (5daf14e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   98.98%   98.98%
=======================================
  Files           7        7
  Lines         295      295
  Branches       80       80
=======================================
  Hits          292      292
  Misses          3        3

Flag
Coverage Δ

unittests
98.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SW-313 Update content metdata in public.html with Terraware info

I don't think there's anything else in there needing an update.

Hooray!


I keep getting "socket disconnected" message

Description
Hi all, I am new to code-server, but I just can't seem to get it to work. I am hosting on a basic DigitalOcean droplet with ubuntu linux. I can run the ide and I can log in to it, and even view the folder contents. However, opening any code file will cause a "socket disconnect" message and then I can't do anything else. Is there a fix for this, or does code-server simply require more bandwidth than my droplet has?

Are you running through a reverse proxy on NGINX?

I have the same problem on a Bitnami server every 10 minutes it disconnects.

Will you copy the terminal output for code server?

Are you using the latest release? Sockets should reconnect

Oh Sorry I got  "Lost connection to socket" broken pipe
I solved it with this code:
Host *
ServerAliveInterval 120
Thanks

Hey mates, I think that this is because of resource requirements.
I had spun up a tiny AWS Lightsail instance ($3.50), and it had the same effect.
I think that we should specify some minimal VPS specs within the README.

Oh Sorry I got "Lost connection to socket" broken pipe
I solved it with this code:
Host *
ServerAliveInterval 120
Thanks

pls share more details where this code should be applied. typing terminal or anywhere else?

@maithoi That looks like SSH client configuration, which only makes sense if you're using sshcode or something similar.

thanks @deansheather, I know where the problem came from, I just make disconnect with coder-server to use the terminal of my local machine ==> this lost connection to socket error.

Since there has been zero response I will mark this as closed.


[WIP] Fix east asian width issue

Some characters (ex. ①: aka "Ambiguous" width characters) are cut in half.

This PR adds "editor.useEastAsianWidth" option. (The default value leaves false)
Enabling this option fixes the issue. (You also need "set ambiwidth=double" in init.vim)

This PR adds "editor.useEastAsianWidth" option

What's the purpose of that, instead of just letting ambiwidth control the decision?

Even with ambiwidth=double, those ambiguous characters are cut in half.
Oni uses wcwidth() under the hood to get the character width. It returns 1 for those ambiguous characters.
This option uses eaw.getWidth() (https://github.com/mysticatea/eaw) instead of that. It returns 2 for those ones.

My question is why add another setting? In other words, let the fixes you made be controlled by ambiwidth instead of a new Oni setting?
I'm not quiet sure about Oni's position regarding new settings. Is it typical to add Oni settings even if a Nvim setting already exists?

Oh, now I understand the meaning of your question.
Yes, the idea to use existing Nvim's setting seems to be good 🙂
I don't know the method now, but I will try to find it.

@ackey I think there are few issues that currently surround rendering of ambiwidth characters including #2427 so definitely appreciate the PR.
Re. re-implementing nvim features @justinmk cant speak for everyone but I think we've avoided re-implementing anything nvim already provides and stuck to just nice to have gui things, or non-native features and is something I personally think is v. important since that will just bloat and overcomplicate oni needlessly.
@ackey do you know whether setting ambiwidth resolves the issue? (or improves it the canvas renderer is know to clip text due to a very involved issue I cant find), note though re this PR and that solution anyway that the canvas renderer is a strategy we are trying to eventually move away from in favour of the webgl renderer so this will only solve the problem there.

@Akin909 setting ambiwidth doesn't resolve the issue.
The cursor is next to the character in the bellow.
Oni: ambiwidth=double

Oni: ambiwidth=single

Nvim: ambiwidth=double

Nvim: ambiwidth=single

These are all ok except that the character is clipped in Oni.
This is not the canvas rendering issue. The character isn't actually clipped but the program code fills the right-hand side of the character with the background color rectangle.

@ackey thanks for looking into it and the images, I wonder if the results are the same if you set editor.renderer: "webgl", re. solution that wouldn't involve oni taking control of this setting, we can read via the nvim api the value of a setting such as ambiwidth

nvim_get_option({name})                                    nvim_get_option()
Gets an option value string
           Parameters:
               {name}  Option name

           Return:
               Option value (global)

from the docs,
we could then use that as the boolean to check, currently at work but can flesh out when I'm free when and how you could get access to the variable in both of the renderers

See also the option_set redraw event in :help ui-global. Since Nvim 0.3.0, 'ambiwidth' and other UI-related options are published in the option_set event.

@Akin909 @justinmk Thank you for the information 🙂
@Akin909 webgl looks perfect without this solution 😍
webgl: ambiwidth=double

webgl: ambiwidth=single

@ackey since the issue seems to relate to the canvas renderer vs. the webgl one its known issues is it alright to close this PR with the definitive fix being eventually fully migrating to the webgl renderer

I'm using the webgl renderer now and it seems it's perfect to me. I close this PR. Thanks 🙂


Fix test file name

nothing to add to the title 😎

/lgtm

/retest

/retest

/retest

I don't see how renaming the test file could cause the failures which seem to be coming from must-gather. Is it appropriate to merge anyway?

I don't see how renaming the test file could cause the failures which seem to be coming from must-gather. Is it appropriate to merge anyway?

yep, just double checked that the actual e2e tests run successfully
/override ci/prow/e2e-test


Add dmca.json and check if post contains a banned author or id

Fixes #1662 .
Changes:

Check post to see if it contains a banned author or post id

changed post_ids to post_urls, and changed check to check for the url that you mentioned.
....
const postURL = `${post.author}/${post.permlink}`;

return _.includes(bannedAuthors, post.author) || _.includes(bannedPostURLs, postURL);

@bonustrack


fix: fix Cannot find name 'CredentialCreationOptions'

node_modules/@dfinity/identity/lib/cjs/identity/webauthn.d.ts:24:47 - error TS2304: Cannot find name 'CredentialCreationOptions'.

24     static create(credentialCreationOptions?: CredentialCreationOptions): Promise<WebAuthnIdentity>;

@krpeacock Hmm, I think only you can merge this.

Oh yeah, forgot to check back after I started the CI


convert old script test to new script test

Converted the local test to a new test style which is more succinct.
Also noticed that dependabot needs to run in the temporary working directory that's created for these kinds of tests so had to make a few adjustments.

I'm going to rewrite this using the dummy updater so it runs faster and isn't network sensitive.


NullReferenceException in VS 2015 CTP6 in InstallPackages against local NuGet repo

This is the error I see (below).  Our ASP.NET MVC web site is hosting NuGet.Server 2.8.3.  I do not see an update for this package.  Perhaps this is a mismatch between the 3.0 client and the server that will get fixed when someone drops an update for NuGet.Server?
Error occured:\nSystem.NullReferenceException: Object reference not set to an instance of an object.
   at NuGet.PackageManagement.UI.PackageLoader.<>c__DisplayClass1a.<<SearchInstalled>b__10>d__21.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at NuGet.PackageManagement.UI.PackageLoader.<SearchInstalled>d__2a.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NuGet.PackageManagement.UI.PackageLoader.<Search>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NuGet.PackageManagement.UI.PackageLoader.<LoadItems>d__51.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NuGet.PackageManagement.UI.InfiniteScrollList.<<LoadWork>b__7>d__9.Move

The latest update (version <IP_ADDRESS>.100)  just fixed the same issue for me.

this is not a gallery issue, will move to NuGet/Home


Add Mergify to this project

Configure mergify to auto-merge the PR when CI is passing and PR is having the required approvals.
details about  mergify at https://github.com/Mergifyio/mergify-engine

I am happy to look into this. What kind of rules for approval should be considered?

is there a (GitHub) team of members that are required for reviewing PRs?
could PRs be labelled as documentation so that fewer reviews are needed?
passing all current available CI jobs are a requirement before merging

I am happy to look into this. What kind of rules for approval should be considered?

Thanks @nixpanic

is there a (GitHub) team of members that are required for reviewing PRs?

Currently, we don't have separate team for this one, i can create one for the core spec reviews

could PRs be labelled as documentation so that fewer reviews are needed?

Yes it's acceptable as it's just a doc change

passing all current available CI jobs are a requirement before merging

Yes, we need to make sure the current CI job passes to merge it.
below is the criteria I was looking at

All CI passes
Has required approval from team
atleast 2 approvals for any  spec change

could PRs be labelled as documentation so that fewer reviews are needed?

May be design instead of documentation make sense @nixpanic @Madhu-1


raw_keyboard errir

hen the exception was thrown, this was the stack:
#2      RawKeyboard._synchronizeModifiers (package:flutter/src/services/raw_keyboard.dart:663:14)
#3      RawKeyboard._handleKeyEvent (package:flutter/src/services/raw_keyboard.dart:587:5)
#4      BasicMessageChannel.setMessageHandler.<anonymous closure> (package:flutter/src/services/platform_channel.dart:76:49)
#5      _DefaultBinaryMessenger.handlePlatformMessage (package:flutter/src/services/binding.dart:267:33)
#6      _invoke3.<anonymous closure> (dart:ui/hooks.dart:282:15)
#10     _invoke3 (dart:ui/hooks.dart:281:10)
#11     _dispatchPlatformMessage (dart:ui/hooks.dart:156:5)
(elided 5 frames from class _AssertionError and dart:async)
════════════════════════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by services library ══════════════════════════════════════════════════════
The following assertion was thrown during a platform message callback:
Platform key support for android is producing unsupported modifier combinations.
'package:flutter/src/services/raw_keyboard.dart':
Failed assertion: line 663 pos 14: 'et<PhysicalKeyboar'

@zeuscode
Just providing the exception is not enough to properly address your issue. Please provide details like flutter doctor -v, platform on which the issue is occuring and a complete minimal reproducible code sample that we can directly use to verify this issue.
Thanks.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


no preview of changes when noPrompt is true

Hi,
I noticed that when running drive non-interactive or when using -no-prompt,
the preview of changes is not sent to stdout.
Not sure if this was intended or not, but I would expect that no-prompt to only have impact on the reading of stdin for continuing or not, and not have impact on what is printed to stdout.
I changed this behavior in my fork (branch always_previewing). Not sure if you're interested and/or if I'm not breaking anything.
best regards,
Raf

Hello @rafmeeusen, welcome to drive and thank you for reporting this issue as well as working on it!
Yes in deed, this sounds like reasonable behaviour to have and you are onto something. The only twist is that if say you are piping output to a non-tty or so, you don't need to provide a preview. Also currently --no-prompt couples with method

func (opts *Options) canPrompt() bool {
    if opts == nil || !opts.StdoutIsTty {
        return false
    }
    if opts.Quiet {
        return false
    }
    return !opts.NoPrompt
}

So a possible way to get this behaviour in correctly would be to add a similar method say canPreview() and then couple that in the way that canPrompt is used.
Please let me know if this makes sense.

I'm also running into this.
I run drive as part of a nightly cron job, and it would be nice to see what happens even if I'm passing -no-prompt.

Hi @odeke-em, sorry had no time yet to look at your proposal, but I already can point out that I have the same use case as pefoley2 : auto-running drive / would like to have a log (i.e. stdout/stderr) saved to file.

Hello folks, thanks for the patience and for reporting this bug. I've fixed it in https://github.com/odeke-em/drive/pull/439. Please get the latest from master, it should be fixed.


windows 11 24h2 26100.2314 not support

termsrv.zip

Duplicate of https://github.com/stascorp/rdpwrap/issues/3285.


set up a cluster in your assigned AWS machine.

Based on Installing a Kafka Cluster and Creating a Topic - Hands-on Labs | A Cloud Guru,

ensure everyone can access kafka


questions about "ndim" parameter

Hi,
Fristly thank you for you good job. I am now trying to run inference using automatic_mask_generator with one of your fintuned model, but I am confused about the "ndim" parameter and "i" parameter in the class AutomaticMaskGenerator. My input image is a RGB image with a shape of 2048x2048x3. When I set ndim=3, it can run properly with no error but it produced nothing. I haved tried ndim=2, it could produce 64 instances. Could you please give me a detailed  description about it？
Do the RGB images is treated as 2 dimensions?

Hi @JIBSN,
ndim refers to the spatial dimension, so if you have an RGB image you indeed need to set it to 2.
It would need to be set to 3 only for data with an extra spatial or time dimension, i.e. 3D or 2D + time data.
Regarding i; this is only needed for ndim=3, so you can ignore it.

with one of your fintuned model

Note that you may need different settings for pred_iou_thresh and stability_score_thresh compared to the default values in the function. If you let me know which model you are using I can tell you which parameters should work well.
(We are in the process of  automating setting these parameters.)

Thank you for your quickly reply. I use the "vit_b_lm" model. Could you please give me some advices on setting  these parameters?

These parameters should work well:
pred_iou_thresh = 0.65, stability_score_thresh = 0.75

and you can set them in the generate method: https://github.com/computational-cell-analytics/micro-sam/blob/master/micro_sam/instance_segmentation.py#L479


#774 expose package version to bundle

reads current package version in a bundler-detectable way.

thanks!


Replace custom CSS with prime-react tailwind on

Fixes Issues
Closes #940 & #941
Changes proposed

Replaces custom CSS for <Chip> component in favor of prime-react Tailwind
Replaces span.p-chip-text in favor of prime-react Tailwind

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Main <Chip> styles:

span.p-chip-text

Note to reviewers
First ever PR to a public project (albeit teeny tiny)! 🎉 Let me know if you have any feedback.

Looks good to me but we try to keep PRs as specific as possible so, can you please separate These changes into two PRs as profile addition and removal of custom CSS . Please let us know if you need any help.

Thanks, both! eoinmurphy.json has been removed and PR description updated. I'll submit it in another PR later today. :)

Thanks @emmalearnscode! How does one go about merging, then? Do I just wait for someone with write access to process the PR?

Thanks @emmalearnscode! How does one go about merging? Do I just wait for someone with write access to process the PR?

We usually try to wait for at least 2 maintainers to approve the PR and then a maintainer will merge it

Currently only at my phone can some other maintainer merge it :)


Make golangci-lint a no-op if unconfigured

golangci-lint only make sense in projects with Go files; attempting to
run it on projects without any Go content causes errors. In
Submariner, all projects which rely on golangci-lint contain explicit
configuration for it, so this uses .golangci.yml's presence as an
indicator that golangci-lint should run. If it doesn't exist, skip it.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

What's the purpose of this change?

Thanks, the purpose wasn’t very clear in my commit message. Hopefully the updated commit message and PR description explain things better!

What's the purpose of this change?

Thanks, the purpose wasn’t very clear in my commit message. Hopefully the updated commit message and PR description explain things better!

Thanks for clarifying, I think a better approach is to find go files and if none found skip the action. This should be more robust as the file seems not to be necessary in all the projects, and if its removed we don't want this linting to generate false negatives.


[PDI-19132] JSON Input step behavior changes when the order of the fi…

…elds is changed
@bcostahitachivantara @smmribeiro @moraesvc

:white_check_mark: Build finished in 7m 27s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/json/core

:ok_hand: All tests passed!
Tests run: 85, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 7m 26s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/json/core

:ok_hand: All tests passed!
Tests run: 85, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


Remove IPSec tunnel limitation

I was trying to enable IPSec with VxLAN tunnel, after verify the traffic in real cluster, it turns out Antrea can actually support all tunnel modes now without much code changes.
I verified all tunnel modes with IPSec in a local Cluster, it all works fine now, so I remove the limitation on our docs and the check in the code.
resolves #2468

Codecov Report

Merging #2489 (fa00c64) into main (d0d377e) will decrease coverage by 3.40%.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##             main    #2489      +/-   ##
==========================================
- Coverage   42.02%   38.62%   -3.41%
==========================================
  Files         148      278     +130
  Lines       18131    21358    +3227
==========================================
+ Hits         7620     8250     +630
- Misses       9828    11923    +2095
- Partials      683     1185     +502

Flag
Coverage Δ

kind-e2e-tests
38.62% <6.25%> (?)

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...gent/controller/noderoute/node_route_controller.go
40.26% <0.00%> (+5.90%)
:arrow_up:

pkg/agent/util/net.go
51.28% <50.00%> (+15.38%)
:arrow_up:

pkg/agent/controller/egress/id_allocator.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/controller/networkpolicy/crd_utils.go
0.00% <0.00%> (-89.16%)
:arrow_down:

pkg/controller/networkpolicy/endpoint_querier.go
2.85% <0.00%> (-88.58%)
:arrow_down:

pkg/controller/egress/controller.go
0.00% <0.00%> (-87.21%)
:arrow_down:

pkg/controller/egress/ipallocator/allocator.go
0.00% <0.00%> (-82.98%)
:arrow_down:

pkg/apis/controlplane/v1beta1/conversion.go
1.20% <0.00%> (-82.33%)
:arrow_down:

pkg/agent/util/iptables/lock.go
0.00% <0.00%> (-81.82%)
:arrow_down:

pkg/agent/controller/networkpolicy/priority.go
8.49% <0.00%> (-77.78%)
:arrow_down:

... and 261 more

/test-all

/test-ipv6-all

/test-ipv6-only-all

@jianjuns  e2e test failed on CI testbed with IPsec+Geneve mode , after double check in my local clusters, it turns out it's kernel version issue, I test in one cluster with ubuntu 18.04.3 which has kernel version 4.15.0-66 failed, but another one with 4.15.0-143 passed. I suppose we need to update docs to point out the kernel version to support different tunnel mode. any other suggestion for this kind of requirement?

I think we need to figure out from exact what kernel version or with what kernel change Geneve can pass. I am surprised it can change from 4.15.0-66 to 4.15.0-143.

@jianjuns yes, I will figure out what's changed or required, I was actually running 'apt-get upgrade', so I suspect maybe it's some software upgrades fix it. but I need time to check.

Hi @jianjuns the change or fix is introduced in this commit: https://kernel.ubuntu.com/git/ubuntu/ubuntu-bionic.git/commit/?id=be556894e8eaefd5d21690d56614d76e45786ecb, I verified it on my local cluster, for ubuntu 18.04, it has to be a version after 4.15.0-124. if we use Geneve as default tunnel for IPSec, we have to upgrade the e2e environment to pass it. do you think it's OK to still keep the old setting to use IPSec+GRE so we can run e2e without testbed change?

@luolanzone: thanks for the update! Given Geneve and others are not supported by earlier kernel version, I think still better to keep GRE to be the default for antrea-ipsec.yml, and test GRE in CI. I first thought we should update CI testbed to support Geneve + IPsec, but even we update testbed do we want to run tests for both GRE and Geneve? @antoninbas : thoughts?

@luolanzone: thanks for the update! Given Geneve and others are not supported by earlier kernel version, I think still better to keep GRE to be the default for antrea-ipsec.yml, and test GRE in CI. I first thought we should update CI testbed to support Geneve + IPsec, but even we update testbed do we want to run tests for both GRE and Geneve? @antoninbas : thoughts?

I feel like it's ok to test a single transport (GRE) since the code is the same on the Antrea side. Just like we run pretty much all of our testing with Geneve (there are some leftover tests for VXLAN, but it won't necessarily always be the case). We should document the kernel version requirements for using IPsec + Geneve though.

Hi @antoninbas @jianjuns , I change the manifest back to use GRE with IPSec, and update the doc ipsec-tunnel.md with kernel requirement. please help to review again, thanks!

/test-all /test-ipv6-all /test-ipv6-only-all

/skip-all


EventHandler: change check method for custom events, avoiding regex

looks good, it seems to me that the merge needs to be forced.


development -> main

On the functions that converted to async, one is returning Task, the other two are still returning void. Should still work, so not demanding change, just being ultra pedantic in case it sparks a realization of something else (that I am not seeing).

Yeah those are the event functions so they need to be void.


Add cwd to terminal options

Adds the option cwd to the terminal widget.  Also updates the documentation accordingly.

This should fix #176.

:+1:


PATCH method for update

What do you think about copying new functionality of rails - patch method HTTP verb for updating record? I can prepare a commit for that.

Definitely want to include something like this, need to look into it a bit more first.  I'll take a look at the commit if you have something.


SDKVersion doesn't reflect the exact sdk version being used

Fixed already, and added framework setup in: https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/145


Automatic error report

What steps will reproduce the problem?

I changed the theme of Spyder using the preferences

Thanks for reporting. This is a duplicate of issue #6519, which will be fixed in our next version.


Improve styling for segmented "big" button group

~Merges to (blocked by) #356~
Why? LGDS styles default button stroke width as 1px, and has custom styles to override stroke width to 2px for big buttons. USWDS button group styles use the stroke width, but are not aware of our customizations to double the width for big buttons, so we need to manually override these styles.
In practice, this makes a small difference on the appearance of a borders buttons.

Before
After

Live preview URL: https://federalist-340d8801-aa16-4df5-ad22-b1e3e731098e.sites.pages.cloud.gov/preview/18f/identity-design-system/aduth-button-groups-border/components/button-groups/
Related IdP usage: https://github.com/18F/identity-idp/pull/8542
LGDS big button customizations:
https://github.com/18F/identity-design-system/blob/1a488efdb6ff4ca1f0a05873440d60be93ec8c5e/src/scss/packages/_usa-button.scss#L4
Relevant USWDS styles: https://github.com/uswds/uswds/blob/8736f9305ee7547b7828fc1d625d83f458c6b44c/packages/usa-button-group/src/styles/_usa-button-group.scss#L80-L99

@aduth - I have an item to run by you
In the screenshots below, the "button extra" button is misaligned with others because of the length of its button content, extending the vertical height.
We could provide a caveat or text guidance to it, mitigating this kind of misalignment scenario. Or, If it is possible, for buttons to be vertically aligned, regardless of text length. Open to ideas.

When on mobile (less than 440px width)
When zoomed more than 400% on Chrome

Build failure is from visual regression, partially expected from the addition of the new "Button Groups" documentation preview page.
Looks like there's also some strange text encoding in one of the versions' content for accordions, hoping it's just a flakey issue.


Bugfix/intl polyfill devel

Great 1st PR, thank you :) Can you solve the "package-lock.json" conflict though ? Try merging devel into your bugfix branch, remove package-lock.json and recreate it, and then push.  This should solve the conflict.

Hi Eric, thank you :) I solved the conflict, and I'm going to merge :)