Proposal: Add 'Opened' event to InfoBar

Proposal: Add 'Opened' event to InfoBar

Summary

Add an 'Opened' event to InfoBar that would fire immediately after an InfoBar opened. See ContentDialog.Opened and ToolTip.Opened for similar events.
Rationale

Would let the developer to account for any layout shifting that may need to occur due to the addition of an InfoBar.

Important Notes
Due to accessibility concerns, we do not recommend that a developer use this event to auto-close an InfoBar. Transient inline content, especially when the content is intended to be read/acknowledged, is not usable. See W3 links on predictability and time for more information.
Open Questions

Is this a baseline requirement for the InfoBar control?
How would you take advantage of the 'Opened' event in your application? Could you include a description of your application and intended situation of use?

Is an 'Opening' event also valuable for your usecase?

Note: I will do my best to keep up with community insights and contributions and add them to this proposal.

Agree that adding this would help with folks transitioning from the InAppNotification in the Toolkit to InfoBar.
I know InfoBar isn't mean to fully encompass those scenarios currently, but it should in the future. This would be an initial step at least making it easier to use InfoBar for a more fully-featured InAppNotification wrapper if it never fully reaches parity.
Seems like TeachingTip is missing Opening / Opened as well.

Opening and Opened
Closing and Closed
IsOpen
These seem to be a basic structure for most of these kinds of Controls.  What devs do with these basic states and actions doesn't matter all that much - but they should be overridable even if they probably do nothing by default.

IMO it should be considered base behavior that a control communicates it's state. It does not really matter what this will be used for. While I agree that normal end user apps / store apps should try to comply with W3 standards as far as possible, it is not absolutely neccessary, and even Microsoft does not follow these guidelines strictly. Plus, the majority of software is developed in companies for internal use. If you only have a few, well known users for your app, it does not make sense to annoy them with accessibility stuff they don't even need.
A control should be designed to allow easy compliance with accessiblity standards, out-of-the-box. But we should not prohibit functionality, just because it could allow implementing behaviors that are not compliant with accessibility standards.

An 'Opened' event would be indeed an appropriate place for adapting layout, updating a counter, and/or starting a timer. The -already defined- 'Closed' event could then host the opposite action. Currently the API is unbalanced in this domain, with several events around closing ('CloseButtonClick', 'Closing', and 'Closed'), and not a single event on opening (although PropertyChanged could be used here).


Inverted_index now defaultdict

Converted inverted_index to use defaultdict. Now no need to make a check if term not in inverted_index.

Thank you! :+1:


Why isInitialized is added back in 1.3.1

Hi,
Wanted to understand the meaning of isInitialized flag in loader/index.js. As per my understanding you wanted it to not to initialized monaco again if already it was initialized.
But I guess that was get handled perfectly with check if(monaco) itself.
The reason why I am saying this. I have a use case if some how monaco-editor js didn't get loaded by this loader (could be any reason eg: js not present there) then I am calling loader.init() method again.
But because of isInitialized flag's value is already true. It never goes to load monaco-edtior js again. Which is a bug here.
After upgrading to 1.3.0 it was working perfectly fine. But this flag added back in 1.3.1.
If loader.init() failes then isInitialized should be marked as false.

@Aayush04 could you please check the latest version?


Fix restore-cache issue on CircleCi

Summary
Should fix #5687 and fix #5526.

Test plan

put the CircleCi build to broken state
fix it

Codecov Report

Merging #5688 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5688   +/-   ##
=======================================
  Coverage   63.16%   63.16%
=======================================
  Files         216      216
  Lines        7913     7913
  Branches        4        3    -1
=======================================
  Hits         4998     4998
  Misses       2914     2914
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303c078...425fba7. Read the comment docs.

PR is finished.

broken cache in https://circleci.com/gh/facebook/jest/16391

now the cache is stored with proper path in the problematic test-browser build job - https://circleci.com/gh/facebook/jest/16404

Ok, so the test-browser's docker image had different home dir set up and we need to adjust that. Makes sense 👍


Fix interests page styling issues

Strava widget is identifying the wrong day as today
Strava detail widget does not left-pad seconds to two digits with 0s

Turns out the issue with identifying today was an error with the Fly.io machine. Logs were showing a data two days in the past. Unsure why this was...


Added grafana oauth2-proxy secret from vault

We should have access to one grafana (connected to all the prometheus and logging) per env

/lgtm


Add missing cdi-client for cdi-server tests

@csadilek, @mbarkley please take a look. This is currently breaking all PR builds as we build Errai from sources.

Thanks @psiroky !


[WIP] Rounding numbers with many decimals in tests

This PR is a test to see if rounding numbers to 8 decimal places (assertAlmostEqual defaults to 7) fixes issues reported in #1009
I used the following code to round all numbers with many decimal places.
import re
simpledec = re.compile(r"\d*\.\d{8,20}")
def mround(match):
    return "{:.8f}".format(float(match.group()))
def round_in_file(filename):
    with open(filename, "r+") as file:
        filetext = file.read()
        filetext = re.sub(simpledec, mround, filetext)
        file.seek(0)
        file.write(filetext)
        file.truncate()

Codecov Report

Merging #1025 (87fd015) into master (0a0daf8) will increase coverage by 1.56%.
The diff coverage is 87.41%.

@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   70.85%   72.41%   +1.56%
==========================================
  Files          62       66       +4
  Lines        9028     9865     +837
==========================================
+ Hits         6397     7144     +747
- Misses       2631     2721      +90

Impacted Files
Coverage Δ

HARK/ConsumptionSaving/tests/debug.py
0.00% <0.00%> (ø)

HARK/datasets/load_data.py
100.00% <ø> (ø)

HARK/estimation.py
0.00% <0.00%> (ø)

HARK/simulation.py
100.00% <ø> (ø)

HARK/tests/test_HARKutilities.py
100.00% <ø> (ø)

HARK/ConsumptionSaving/ConsIndShockModelFast.py
51.05% <44.89%> (ø)

HARK/datasets/life_tables/us_ssa/SSATools.py
60.86% <50.00%> (+60.86%)
:arrow_up:

HARK/datasets/SCF/WealthIncomeDist/SCFDistTools.py
78.04% <66.66%> (ø)

HARK/interpolation.py
41.52% <67.50%> (+0.46%)
:arrow_up:

HARK/dcegm.py
49.62% <69.23%> (+0.37%)
:arrow_up:

... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879ec7f...87fd015. Read the comment docs.


Responsive redesign

Hello.
I redesigned some parts of the layout of site, so it can be fully responsive when seen it on a mobile device. I didn't touch any part of the design, only, the layout.
There aren't actually a lot of changes, just removed the fixed sizes of some elements, and update and remove some classes. That's everything. Also, I tried to put some indentation, but it looks pretty bad on the github editor, i don't know why.
If you can give any kind of feedback i'll be happy.

@soruly what about this?


Deadlocks on target server when more than 1 dbt thread

Expected Behaviour
dbt can run many tests in parallel without causing database deadlocks.
dbt can query information_schema and do DDL on separate threads without deadlocks.
Actual Behaviour
Intermittent deadlocks.  So far only observed on dbt build (with tests) and dbt test.
('40001', '[40001] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Transaction (Process ID 62) was deadlocked on lock resources with another process and has been chosen as the deadlock victim. Rerun the transaction. (1205) (SQLFetch)')

An example deadlock log, showing implicated queries/ddl,  is pasted at the end of this issue.
Steps to reproduce
dbt test --threads 8

or
dbt build--threads 8

Yesterday I could reliably get it to fail with 2 threads.  Today it's running fine with 8 sometimes.   Oooouch!    Seems slightly easier to recreate when there are some bigger relations (10M+ rows) to test.
Configuration
A set of small generic dbt tests - I have ~50 tests
DAG does not affect dbt test. For dbt build I have ~4 paths through the DAG.
dbt 1.0.0
SQL Server 2019
ODBC Driver 2017
Possible causes
The "what changed recently " cause is that from dbt 0.21.1 test creates a lot more tables, as a workaround for there being no nested CTE functionality in SQL Server.
Cause in SQL Server.  Not sure, but seems the engine has it's own means of ensuring integrity when querying INFORMATION_SCHEMA and making DDL changes at the same time.  In DML, the query would simply get blocked (delayed) while the write completes, not cause a deadlock, except in some edge cases involving index updates.   Things were fine pre 0.21.1 probably because of lower volume of operations per second - most tests are quick, and they can take advantage of parallelism.
A root cause is that there's not nested CTE in SQL Server.  dbt-core tests and packages like dbt-expectations increasingly use nested CTEs.
Other information
Current workaround: limit dbt threads to 1.
Some discussion of possible causes and solutions on dbt slack
Concern in back of my mind is that we could also see this error then doing dbt run, given a busy enough DAG. I don't know the inner workings of dbt, but if they involve querying INFORMATION_SCHEMA and making DDL changes at the same time on another thread then there is cause for concern. No symptoms so far though :)
Have also been getting SQL engine errors that the name of some test tables exceed SQL Server's maximum of 128 characters. Also intermittent, and only surfaces if there was some other error in the SQL that caused the test run to fail.
Resources
Extract from a deadlock log from SQL Server:
<deadlock>
...
      </executionStack>
      <inputbuf>
select
      table_catalog as [database],
      table_name as [name],
      table_schema as [schema],
      case when table_type = 'BASE TABLE' then 'table'
           when table_type = 'VIEW' then 'view'
           else table_type
      end as table_type

    from [dw2].information_schema.tables
    where table_schema like 'dbt_test__audit'
     </inputbuf>
...
      <inputbuf>

  USE [dw2];
  if object_id ('"dbt_test__audit"."source_not_null_relation_column"','U') is not null
      begin
      drop table "dbt_test__audit"."source_not_null_relation_column"
      end
   </inputbuf>
</deadlock>

The log was found using:  (credit to credit )
DECLARE @xelfilepath NVARCHAR(260)
SELECT @xelfilepath = dosdlc.path
FROM sys.dm_os_server_diagnostics_log_configurations AS dosdlc;
SELECT @xelfilepath = @xelfilepath + N'system_health_*.xel'
 DROP TABLE IF EXISTS  #TempTable
 SELECT CONVERT(XML, event_data) AS EventData
        INTO #TempTable FROM sys.fn_xe_file_target_read_file(@xelfilepath, NULL, NULL, NULL)
         WHERE object_name = 'xml_deadlock_report'
SELECT EventData.value('(event/@timestamp)[1]', 'datetime2(7)') AS UtcTime,
            CONVERT(DATETIME, SWITCHOFFSET(CONVERT(DATETIMEOFFSET,
      EventData.value('(event/@timestamp)[1]', 'VARCHAR(50)')), DATENAME(TzOffset, SYSDATETIMEOFFSET()))) AS LocalTime,
            EventData.query('event/data/value/deadlock') AS XmlDeadlockReport
     FROM #TempTable
     ORDER BY UtcTime DESC;

Run it in SSMS and you'll get nice links to the xml for each deadlock.

Maybe this should be optional? Perhaps set in profiles.yml.

Isn’t part of the problems with the temporary creation of tables in Test that different tests create the same temporary table? That’s how I read the get_relation part of it


TimeOut issue when try to get all messages

Hi, @Webklex
Thanks for your great work
$oClient = Client::account('default');
$oClient->connect();

//Get all Mailboxes
/** @var \Webklex\IMAP\Support\FolderCollection $aFolder */
$aFolder = $oClient->getFolders();

//Loop through every Mailbox
/** @var \Webklex\IMAP\Folder $oFolder */
foreach ($aFolder as $oFolder) {
    dd($oFolder->messages()->all()->get());
    //Get all Messages of the current Mailbox $oFolder
    /** @var \Webklex\IMAP\Support\MessageCollection $aMessage */
    $aMessage = $oFolder->messages()->all()->get();

    /** @var \Webklex\IMAP\Message $oMessage */
    foreach($aMessage as $oMessage){
        echo $oMessage->getSubject().'
';
        echo 'Attachments: '.$oMessage->getAttachments()->count().'
';
        echo $oMessage->getHTMLBody(true);

        //Move the current Message to 'INBOX.read'
        if($oMessage->moveToFolder('INBOX.read') == true){
            echo 'Message has ben moved';
        }else{
            echo 'Message could not be moved';
        }
    }
}

I wrote this code in my controller. So connetcteing is right and also I can see my folders.
But when I try to get  all messages from any folder I got time out issue.
Please help .

Hi @Gevorg618 ,
please keep in mind that you are fetching your whole inbox including all attachments etc. This might take longer then 30sec. You could consider to use the "search"  https://github.com/Webklex/laravel-imap#search-for-messages to reduce the amount of mails you are fetching.

Or maybe paginate results
$paginator = $oFolder->search()
->since(\Carbon::now()->subDays(14))->get()
->paginate($perPage = 5, $page = null, $pageName = 'imap_blade_example');


Closes issue #4394

Fixes two small typos in Waypoint: Make Instances of Objects with a Constructor Function:
"To use a constructor function we call it with the new keyword in front if it like:" ->
"To use a constructor function we call it with the new keyword in front of it like:"
"javascript" -> "Javascript"

Thanks! :+1: Please remove the issue number from the PR title and in the future following the branch naming conventions outlined in Pull Request Contribute.
As soon as you've got the PR title changed I can merge this right now :smile:

Got that taken care of ltegman. Thanks for the link to the PR Contribute guidelines. This is my first PR to the FCC repo, so I wasn't sure that I had done it correctly.
I'll read these outlines and keep them in mind for future PRs.
Thanks!


TODO - session record dates in listing

90_session_record.sh
TODO: include date/time in output of __list_avail_sessions?

the whole Session Record functionality is better met by asciinema session recording/playback infrastructure.


Add Atari support

This is purely an idea if you wish and I understand how much work it is to get this working.
Thankfully, https://github.com/mttga/purejaxql has shown this to be possible achieving 200 million frames in 1 hour with EnvPool XLA support.
Therefore, would be cool to do hyperparameter search, etc over Atari environments

I've added preliminary Envpool support on the envpool_compat branch (see train_envpool.py). As far as I can see, you can already run any Rejax algorithm on any Envpool environment, and initial experiments on Pong suggest that training is successful.
Unfortunately, the XLA interface of Envpool is limited, as it does not support vmap (which makes sense looking at its basic architecture). Even creating a separate envpool for each algorithm instance (or training seed) that is vmapped fails. It might be possible to create a single envpool and take a lot of care that vmapped instances only access specific environments, but this is out of my scope for now. This means that training in Envpool environments requires not only environment wrapping but also some modification of the training algorithm, which is implemented in rejax.compat.envpool2gymnax. Still, Rejax might be faster than other implementations even on one seed, so I'll continue adding support for Envpool.


Reprdouce results

Hello,
I'd like to reproduce the results.
I just want to make sure what are the correct params: how can I know what are the exact params to be used for each scenrio? are the default ones in scripts/classification.sh are the ones to use?

also, with how much seeds are the results I the paper?

scripts
To reproduce the results, the most important params are learning rate, synthetic_prob and $gamma$. Basically, you can reproduce using the script run.sh.

For conventional classification, set a smaller synthetic_prob (e.g., 0.1 across all datasets). For imbalance and few-shot classification, synthetic_prob should be greater (e.g., 0.3 for 5-shot and 0.3 for IF=0.01 imbalance classification).
Strength should be set larger, and 0.7 is good across various scenarios.
$gamma$ should be set smaller than 1, and 0.5 is a safe choice (or 0.8, we alternatively choose between them).
The function get_learning_rate() in scripts/classification.sh automatically handles the learning rate setup for all datasets (under conventional and few-shot classification). Please check spelling and errors.
We use seeds 2020, 2021, 2022 in all experiments.

Will the batch_size in training stage be the factor influencing the translation quality?
Can I set a larger batch_size like 8 or 16?

Will the batch_size in training stage be the factor influencing the translation quality? Can I set a larger batch_size like 8 or 16?

I don’t think this factor matters much. However, a larger batch size with a fixed number of iteration steps may lead to better customization.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3096

Questions ?
Please refer to the Backport tool documentation


fix(curriculum): specifies the cafe's street address

Checklist:

[x ] I have read and followed the contribution guidelines.
[ x] I have read and followed the how to open a pull request guide.
[x ] My pull request targets the main branch of freeCodeCamp.
[ x] I have tested these changes either locally on my machine, or GitPod.

Closes #49595

Used suggested disambiguation.

The actual street address also needs back ticks around it.


Link Parsing Behavior

Expected Behavior
www.google.com => says like that
link => behavior depends on format needed
Actual Behavior
does not parse urls with percent signs correctly.
does not recognize urls correctly
Specifications

Version: development
Platform:

solution
either
remove all link parsing from QnABot and let the client handle it
or
improve current behavior
my opinion: remove link parsing behavior, QnABot is responsible for content/format and the client is responsible for the representation of the content.

fixed in v2, better support when markdown comes


Support setting the complete JAAS configuration in a property

I've noticed it can be done for Kafka:
 mp.messaging.connector.smallrye-kafka.sasl.jaas.config=com.sun.security.auth.module.Krb5LoginModule required useKeyTab=true storeKey=true debug=true serviceName="kafka" keyTab="src/test/resources/client.keytab"<EMAIL_ADDRESS>So we can support something similar with quarkus.kerberos.jaas-config

That said, JAAS config is already auto-generated and the service principal name, key tab are already configurable which affect this generation, so I'll close this issue for now


Decouple Protocol-Def from Common-Def

The only dependency between protocol-def and common-def was for eventing. I've re-implemented this without the need for importing the common types. This is type compatible, illustrated by the type tests.

No real objection from me, but not sure I understand the motivation? Are you saying it should be forbidden for protocol-definitions to depend on common-definitons (and if so, why is that)?
If so, probably remove the dependency allowance from layerInfo.json too.

@ChumpChief  the comment was around odsp client, it was consuming a deprecated type from common-def. odsp client should not consume any deprecated types. i'm surpised the lint rule to prevent referencing deprecated types are not enabled.

No real objection from me, but not sure I understand the motivation? Are you saying it should be forbidden for protocol-definitions to depend on common-definitons (and if so, why is that)?
If so, probably remove the dependency allowance from layerInfo.json too.

@ChumpChief the comment was around odsp client, it was consuming a deprecated type from common-def. odsp client should not consume any deprecated types. i'm surpised the lint rule to prevent referencing deprecated types are not enabled.

No I get that one, my comment is that I don't understand why it matters if protocol-def depends on common-def for eventing.


No such file or directory: 'default_images/tmp.PNG'

i tried to run the code and i got this error
Mask_RCNN_Detect.py", line 53, in init
np.array(Image.open('default_images/tmp.PNG'))[:, :, :3])])
File "/usr/local/lib/python3.6/dist-packages/PIL/Image.py", line 2543, in open
fp = builtins.open(filename, "rb")
FileNotFoundError: [Errno 2] No such file or directory: 'default_images/tmp.PNG'
thank you

Hi,
Whoops I forgot to manually add that file after ignoring all .pngs in the .gitignore. It should work now.


⚠ ClamAV has degraded performance

In e41b425, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 196 ms

Resolved: ClamAV performance has improved in c71e019 after 5 minutes.


Consolidate some of the E2E logic

Which issue this PR addresses:

Fixes
What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

https://github.com/Azure/ARO-RP/pull/3392


Do not allow to delete tenant which has children

Two changes in this PR:

if tenant created from mapped CloudTenant then destroy this tenant and all children when cloud manager destroyed
do not allow to destroy all other tenants which has sub-tenants or sub-projects.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1860097
@miq-bot add-label bug

@miq-bot add-label ivanchuk/yes, jansa/yes?

@agrare @Fryguy
rspec failing in cloud_manager_spec#"cleans up created tenant tree when the ems is destroyed",
should we  allow to delete tenant when subtenant present by deleting all subtenants first ?

I am not sure what next step for this PR should be.
Should we make sure that deleting tenant will delete all subtenants first, or not permit to delete tenant which has subtenants, or just close this PR and leave everything as is?

@yrudman should deleting a tenant with subtenants just turn into a normal cascade delete?  It seems like the original issue is deleting a tenant doesn't dependent destroy/nullify child tenants correct?

@agrare correct,  root cause of original issue - we are not destroying subtenants when parent tenant destroyed and I was wondering what is intended behavior: recursive deleting of tenants/subtenants or manual deleting subtenants first before deleting parent tenant(since recursive deleting is very destructive operation)

I'm not sure what the right answer is here... Assigning to @gtanzillo

another BZ with the same issue : https://bugzilla.redhat.com/show_bug.cgi?id=1891131

I'm good with this PR as is as it prevents the bug and clearly explains to the user how to deal with it.  @yrudman can you make the PR go green?

Seems this PR changed?  I thought we were not allowing destroying child tenants (even the PR title is the opposite of what's happening here).

Walking the children in two separate method calls seems like a lot of overhead given that this class participates in ancestry.  We should be able to construct a delete clause in a single query...something like...
def destroy_subtree
  descendants.sort_by { |d| -d.depth }.each(&:destroy)
end

@Fryguy i guess I am missing something sine do not understand where overhead coming from - , those recursive method checking each node (either tenant or project) only once and invoking destroy

The recursion itself creates the overhead by executive 2 queries (subtenants and subprojects) at each level of recursion (so this is effectively a log2(N)+1- not quite N+1, but still very inefficient). However, divisibility (the property that differentiate tenants and projects) is not important from a delete perspective, so those 2 queries can be made into 1, however that's still 1 at each level.  You can eliminate the recursion altogether by querying the entire subtree in a single query, and then delete them from them leaves up (that's what the the reverse depth sorting is for).
Ideally it would be nice to delete the entire subtree in a single query as well, but I have a feeling you are going to run into the validation issue your are trying to avoid.

thank you @Fryguy

I still feel :orphan_strategy =>:destroy is a viable option. That handles all the callback logic optimizations that jason mentioned.
Yes we are following a pattern we use else where, but having a model say "I don't want to go away" has always felt strange to me.

@kbrock When you are happy with this one feel free to merge.


Merge topics "test" and "testing"

and remove "unit-testing" from aliases

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created the topic or collection I'm changing.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

To topics for the same subject so I merged them.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Looks fine

Anytime.


implement cosine similarity

We'd like to have a function measure of cosine similarity between terms, e.g.
pub fn cosine_similarity(
    embeddings: &DataFrame, // probably a Polars DF
    entity1: &str,
    entity2: &str,
) -> f64 {
    /* Returns cosine similarity between the two terms */
    let entity1_embedding = get_embedding(entity1, embeddings);
    let entity2_embedding = get_embedding(entity2, embeddings);
    let cosine_sim = calculate_cosine_similarity(&entity1_embedding, &entity1_embedding);
    cosine_sim
}

I'd suggest we let the caller bring their own embeddings in GRAPE (i.e. Pandas) format, then we can calculate cosine sim efficiently in Rust (possibly using Polars?)
Obviously we'd want to build cosine similarity into all_by_all_similarity() too eventually
per discussion with @iQuxLE
cc @cmungall @julesjacobsen @matentzn

Also Luca/Tommy have implemented an efficient cosine sim function that we possibly could crib

Let's be careful to distinguish two things:
1 the similarity/distance metric
2 what the metric is operating over
- e.g one hot vector of ancestors (i.e what we have now)
- embeddings
- kg embeddings
- nl embeddings e.g. openai
On Fri, May 26, 2023 at 9:24 AM Justin Reese @.***>
wrote:

Also Luca/Tommy have implemented an efficient cosine sim function
https://github.com/AnacletoLAB/ensmallen/blob/master/graph/express_measures/src/cosine_similarity.rs
that we possibly could crib
—
Reply to this email directly, view it on GitHub
https://github.com/monarch-initiative/semsimian/issues/56#issuecomment-1564635018,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMMONHVZ37EU7DL5F5NHLXIDKLHANCNFSM6AAAAAAYQNS3CU
.
You are receiving this because you were mentioned.Message ID:
@.***>

I think 2 would be handled entirely on the Python side by filling out the appropriate entries in a TermPairwiseSimilarity right? this issue is just to implement (hopefully efficiently) the calculation of cosine similarity


Roll Engine from c2ffafea35ef to 7c731649ad0f (1 revision)

https://github.com/flutter/engine/compare/c2ffafea35ef...7c731649ad0f
2021-07-16<EMAIL_ADDRESS>Roll Skia from 763be55a9ed7 to e2a9bdfba448 (1 revision) (flutter/engine#27467)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Deprecate old shell syntax

Unified slash syntax was added in sbt 1.1.0 in 2017 (https://github.com/sbt/sbt/pull/3434).
This deprecates the older shell syntax: proj/cofing:intask::key that's been around since sbt 0.9.
(sbt 0.7 had a key for test-compile)
Example
sbt:hello> it:compile
[warn] sbt 0.13 shell syntax is deprecated; use slash syntax instead: IntegrationTest / compile
[info] compiling 1 Scala source to /private/tmp/hello/target/scala-2.13/classes ...

sbt:hello> compile:console::scalacOptions
[warn] sbt 0.13 shell syntax is deprecated; use slash syntax instead: Compile / console / scalacOptions

fwiw, I would also like to see scalacOptions in (Compile, console) deprecated


Module 4 exercises [Ebenezer Ntsiful]

Exercise 1.xlsx
Exercise 2.xlsx
Ebensway_Module4_Assignment3_rank reciprocal.pdf
Ebensway_Module4_Assignment3_rank sum.pdf

Great work on the Rank Sum Method, Ebenezer. Although I see that there is a file labeled for the Rank Reciprocal Method, it appears to be the same file as the Rank Sum Method. Could you please resubmit your Rank Reciprocal Method file? Thank you!

Well done, Ebenezer. Thank you for your participation! Please be sure to fill out the post-Module survey.


Add checks to HTTP status codes for NSURLSession requests

Status codes [200, 300) are accepted and their body data are used.
Resolves https://github.com/tangrams/tangram-es/issues/409.

This looks good.
We might have to do the same for libcurl for linux and rpi platforms.

I thought so too, but the linux platform code does a similar check already https://github.com/tangrams/tangram-es/blob/master/linux/src/urlWorker.cpp#L51

Sure. thanks for pointing to the code. Can we use the same status code range in linux then? Currently it seems it considers downloaded data valid only when status code is 200.

After some IRL discussion with @bcamper it's starting to sound like we should "accept" the response body for all status codes and perform any content checks at the next step when we're trying to use the data. Essentially, this is because it is a common practice to provide a meaningful response body in the event of errors (e.g. a 404 on an image resource can result in an "error image"). At the platform networking layer, we'll just issue a warning for status codes that are likely errors.
I'll comment again here after adjusting this behavior.

Ideally we should probably try to process the response if it has the expected content type for the resource (e.g. images for raster tiles, protobuf for MVT tiles, etc.). This does involve some guesswork though. And throw a warning on any resources that can't be processed successfully. Of course this is problematic if protobuf decoding is segfaulting on invalid data. Stability should take priority here.

So this means error check needs to be done on parsing end?

After a bit more poking around, I'm now feeling more like we should not be processing response bodies with "unsuccessful" status codes.

The example code from OkHTTP checks status codes using the isSuccessful() method to decide whether to read a response body, and our Android SDK has behaved this way since the initial release.
The HTTP request handling in mapbox gl goes further and only uses response body data when the status code is 200.

It makes sense for a browser to attempt to process response bodies for "failure" status codes, but since tangram-es is not a browser (yet) I think we should process only "successful" responses until both:

we find a use case requiring the engine to process response bodies with "failure" status codes, and
we make certain that all code paths that receive HTTP responses are robust to malformed data.

Looks good. Merging.


Some nodes unavailable for scheduling

Here you can see I have three nodes that are currently available for scheduling containers.

But, if I look at the list of nodes, I see all five.
➜  rails_app git:(gem_update) ✗ kon node ls

Name                                                                   Status     Initial    Labels
misty-bush-85                                                          online     yes        region=sfo1,az=sfo1,provider=digitalocean
black-snow-30                                                          online     yes        region=sfo1,az=sfo1,provider=digitalocean
long-firefly-44                                                        online     yes        region=sfo1,az=sfo1,provider=digitalocean
late-water-57                                                          online     no         -
proud-sun-11                                                           online     no         region=sfo1,az=sfo1,provider=digitalocean

I first saw one node popping on and off. I had no idea why, but I decided to try removing it and adding another to take its place. While removing it, another node dropped off. But, the new node joined and started scheduling as expected. Now the nodes list reports that all nodes are online, but they never show up when I'm looking at the monitor.
I just SSH'd into one of the missing nodes and was greeted by this:
Last login: Mon Jan  9 06:28:33 UTC 2017 from <IP_ADDRESS> on pts/0
Container Linux by CoreOS stable (1235.4.0)
Failed Units: 3
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
This is on a system provisioned by the digital ocean plugin, with no manual modifications.
And, when I'm on the host and check the running containers, I see containers that I expect to be running.  I've got about 300Mb of free memory.
A few notes about context:

I was playing with scaling up and down  around the time that this happened.
I just updated to 1.0.4 today.

Please let me know if any service logs in particular would help and i'll pull them.

I've been tinkering with this for a bit. I tried rebooting nodes initially. Suddenly one of them popped back up. I removed and replaced it. Everything seems to be running fine now. I don't know what happened. I would love to understand a bit better, just to help me trust the system.

I managed to reproduce this again. I tried to scale down my my web service using kontena service scale rails_app/web 7 and all of a sudden, all of my nodes disappear. As mentioned above, I was also tinkering with the scale command when the problem originally occurred.
Here's are some snippets from the logs as i'm not entirely sure what piece is the problem:
weave | INFO: 2017/01/10 03:52:05.465750 Discovered local MAC 26:67:18:c5:01:a3
weave | INFO: 2017/01/10 03:52:05.459417 Discovered remote MAC 26:67:18:c5:01:a3 at 52:2b:96:f2:4c:87(silent-wind-84)
weave | INFO: 2017/01/10 03:52:05.460508 Discovered remote MAC 26:67:18:c5:01:a3 at 52:2b:96:f2:4c:87(silent-wind-84)
weave | INFO: 2017/01/10 03:52:05.462994 Discovered remote MAC 26:67:18:c5:01:a3 at 52:2b:96:f2:4c:87(silent-wind-84)
weave | INFO: 2017/01/10 03:52:05.458226 Discovered remote MAC 26:67:18:c5:01:a3 at 52:2b:96:f2:4c:87(silent-wind-84)
kontena-cadvisor | E0110 03:52:05.482415    2430 fsHandler.go:106] failed to collect filesystem stats - du command failed on /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a with output stdout: 53524	/rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a
kontena-cadvisor | , stderr: du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/1435/task/1640/fd/104: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/1435/task/1640/fdinfo/109: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/1435/task/2206/fdinfo/41: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/1435/task/3350/fdinfo/115: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/1435/task/3471/fdinfo/115: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/1435/task/3608/fdinfo/92: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/1435/task/3808/fd/92: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/8239: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/8245: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/8252: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/8262: No such file or directory
kontena-cadvisor | du: /rootfs/var/lib/docker/overlay/722ac85b904d4dd91b94e8a7ba5df38be74d1db2e66d4e3e0cd38a54e975930a/merged/proc/8274: No such file or directory
weave | INFO: 2017/01/10 03:52:05.552526 [nameserver 52:2b:96:f2:4c:87] adding entry for 41f08e5a8f5f2a54b340377b4194540186d8080f1204f66b28e7534fb7d9d77c: web-9.rails_app.production.kontena.local. -> <IP_ADDRESS>
kontena-agent | I, [2017-01-10T03:52:36.944142 #1]  INFO -- Kontena::Workers::NodeInfoWorker: publishing node information
kontena-agent | I, [2017-01-10T03:52:43.087114 #1]  INFO -- Kontena::Workers::StatsWorker: starting collection

I decided to try restarting nodes again. After restarting all of them, they register as online after about 30 seconds, then about 2-3 minutes later they go back to offline.
Name                                                                   Status     Initial    Labels
misty-bush-85                                                          offline    yes        region=sfo1,az=sfo1,provider=digitalocean
black-snow-30                                                          offline    yes        region=sfo1,az=sfo1,provider=digitalocean
silent-wind-84                                                         offline    yes        -
late-water-57                                                          offline    no         -
hidden-snow-91                                                         offline    no         region=sfo1,az=sfo1,provider=digitalocean

TBH I'm not exactly sure how the agent errors (systemd coredumps and the cadvisor errors) relate, but the last part about the nodes being online for a minute or two does sound very much like #1626, which is about error handling on the server side.

Can you SSH in to your kontena-master node and take a look at docker logs kontena-master-api, if it's logging anything interesting when or before this happens?

@SpComb Thanks for the response. I actually hopped on slack, and some Jussi helped me get up and running by rebooting the master. I left my logs there in general. And there's a bit of conversation around all of this. The master log didn't seem particularly interesting, but rebooting the master did bring my nodes back.

Closed by #1626, which will let the master log an error and restart in these kinds of situations.
Re-open/comment if you still see similar behavior or interesting error messages and server restarts in similar situations with 1.0.5 once released.


reference keyvault instead of PFX in Terraform

appgateway cert type (custom vs. selfsigned)
s_local_certificate          = var.certificate_path != null && var.certificate_password != null

Stale and no longer relevant due to refactoring. Terraform implementation for V2 planned soon.


Updated to 5.2

Updated gradle version
updated the billing verison
Addresses (in theory) #43 #35

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

Still can't test, but the code looks good to me

Thanks!


Add configuration for automatic changelog generation

In order to facilitate the creation of new releases, we should use a tool to automatically generate changelogs based on the commit history.
We should use the git-chglog tool because it nicely integrates into GitHub actions, see for example this workflow.
This is related to #410.

@ebma is this required for the next released that comes in with rewards and vault fixes?

@annatekl no it's not required. It's a nice-to-have feature but I haven't found the time yet to work on it yet. It just removes a little overhead when creating the changelogs but we can do that manually for now, no problem.


debug peer-reliability test

the peer reliability test is currently consistently failing.  the test brings up a 3 node testnet, and tests to make sure that each node is connected to the other 2 nodes, however always at least 1 node is only connected to 1 other node.  in a 3 node testnet, every node should connect to every other node
i believe that this test failure is the fault of the daemon's networking stack, and not of the test implementation, integration test framework, nor test standards or test logic, but we'll see after investigation.
the test is removed from CI atm, after it gets sorted it the test needs to be put back in

we speculate this PR may be responsible
https://github.com/MinaProtocol/mina/pull/9895


Changes proposed for navbar-mobile

Changes proposed for navbar-mobile template

[ ] add comments in HTML code
[ ] add comments in JavaScript code
[ ] add CSS variables

You are good to  go.


infer cache image from controller image; remove cache image k/v from system config map

In working through some of the infra deployment kcp changes for jvm build service and reconciling with our dev / ci flow kustomization it dawned on me that via consistent naming conventions we should be able to infer from the controller image the names (including sha/tag) of the other image references managed by the controller.
So far, this is just the cache image.
After a CI sanity check, I'll move on to the others, and update this description accordingly.
Ultimately, this should both aid the kcp work (and help minimize our infra deployments footprint) as well as reduce the amount of kustomize overlay we do in the dev/ci flows.

On Tue, Sep 13, 2022 at 4:21 PM openshift-ci[bot] @.***>
wrote:

@gabemontero https://github.com/gabemontero: The following test failed,
say /retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e f9bf828
https://github.com/redhat-appstudio/jvm-build-service/commit/f9bf828631c5240119a09b1090e9caefc0710b10
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/redhat-appstudio_jvm-build-service/258/pull-ci-redhat-appstudio-jvm-build-service-main-jvm-build-service-in-repo-e2e/1569777588174327808
true /test jvm-build-service-in-repo-e2e

Ok will have to dev/test locally first 😀
Full PR test history

https://prow.ci.openshift.org/pr-history?org=redhat-appstudio&repo=jvm-build-service&pr=258.
Your PR dashboard
https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:gabemontero
.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
Reply to this email directly, view it on GitHub
https://github.com/redhat-appstudio/jvm-build-service/pull/258#issuecomment-1245915243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3NU5FRRKL4H6ZEY2LIR7TV6DO3HANCNFSM6AAAAAAQLYPFYU
.
You are receiving this because you were mentioned.Message ID:
@.***>

hmm ... related to my pr, or did the rehearsals on the pivot from infra-deps miss something?
    types.go:25: time: 2022-09-13 20:16:17.551324812 +0000 UTC m=+137.651567488: pod logs for container jvm-build-workspace-artifact-cache in pod jvm-build-workspace-artifact-cache-6d6f89db76-h4ddq:  1.6631000583786278e+09	INFO	main	The apis.kcp.dev group is not present - creating standard manager
        1.6631000583806536e+09	INFO	controller	get of taskrun CRD failed with: customresourcedefinitions.apiextensions.k8s.io "taskruns.tekton.dev" is forbidden: User "system:serviceaccount:jvm-build-service-test-namespace-cx2pd:jvm-build-workspace-artifact-cache" cannot get resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope

creating a test pr to make sure it is this PRs changes

hmm ... related to my pr, or did the rehearsals on the pivot from infra-deps miss something?
    types.go:25: time: 2022-09-13 20:16:17.551324812 +0000 UTC m=+137.651567488: pod logs for container jvm-build-workspace-artifact-cache in pod jvm-build-workspace-artifact-cache-6d6f89db76-h4ddq:  1.6631000583786278e+09	INFO	main	The apis.kcp.dev group is not present - creating standard manager
        1.6631000583806536e+09	INFO	controller	get of taskrun CRD failed with: customresourcedefinitions.apiextensions.k8s.io "taskruns.tekton.dev" is forbidden: User "system:serviceaccount:jvm-build-service-test-namespace-cx2pd:jvm-build-workspace-artifact-cache" cannot get resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope

creating a test pr to make sure it is this PRs changes

hmmm works for me locally running openshift-ci.sh

On Tue, Sep 13, 2022 at 4:45 PM Gabe Montero @.***> wrote:

On Tue, Sep 13, 2022 at 4:21 PM openshift-ci[bot] <
@.***> wrote:

@gabemontero https://github.com/gabemontero: The following test
failed, say /retest to rerun all failed tests or /retest-required to
rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e f9bf828
https://github.com/redhat-appstudio/jvm-build-service/commit/f9bf828631c5240119a09b1090e9caefc0710b10
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/redhat-appstudio_jvm-build-service/258/pull-ci-redhat-appstudio-jvm-build-service-main-jvm-build-service-in-repo-e2e/1569777588174327808
true /test jvm-build-service-in-repo-e2e

Ok will have to dev/test locally first 😀

The image names from Ci break the pattern a bit but I think I may be able
to handle and still simplify

Full PR test history

https://prow.ci.openshift.org/pr-history?org=redhat-appstudio&repo=jvm-build-service&pr=258.
Your PR dashboard
https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:gabemontero
.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
Reply to this email directly, view it on GitHub
https://github.com/redhat-appstudio/jvm-build-service/pull/258#issuecomment-1245915243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3NU5FRRKL4H6ZEY2LIR7TV6DO3HANCNFSM6AAAAAAQLYPFYU
.
You are receiving this because you were mentioned.Message ID:
@.***>

seeing different but equally weird failures in my test PR https://github.com/redhat-appstudio/jvm-build-service/pull/259
still investigating

seeing different but equally weird failures in my test PR #259
still investigating

test pr is now green .... weird flakes before

/retest

OK I think I understand how this PR is messing things up (it does pertain to my earlier comments)
It is using the controller image as the cache image.  Then the controller image tries to do stuff that the cache SA does not have permissions for.
OK now on to reconcile the CI env var image override form of bootstrap with the simplification I want to do with the use of quay.io/redhat-appstudio images as well as quay.io/ images

error ^^ expected again
I will push change to openshift-ci.sh shortly that sets the env vars on deployment, but without needing kustomize;
then, in the non-ci case, we can infer images names from naming patterns, consistent sha/commit level

ok e2e is passing now
types.go:25: time: 2022-09-14 16:02:21.608930095 +0000 UTC m=+631.749917382: number of dependencybuilds: 4
--- PASS: TestExampleRun (631.73s)
--- PASS: TestExampleRun/pipelinerun_completes_successfully (150.20s)
--- PASS: TestExampleRun/artifactbuilds_and_dependencybuilds_generated (15.27s)
--- PASS: TestExampleRun/some_artfactbuilds_and_dependencybuilds_complete (390.27s)
--- PASS: TestExampleRun/contaminated_build_is_resolved (0.26s)
--- PASS: TestExampleRun/make_sure_second_build_access_cached_dependencies (73.08s)
--- PASS: TestExampleRun/Correct_JDK_identified_for_JDK11_build (0.07s)
PASS
ok github.com/redhat-appstudio/jvm-build-service/openshift-with-appstudio-test/e2e 631.754s
? github.com/redhat-appstudio/jvm-build-service/openshift-with-appstudio-test/main [no test files]

and image used for cache is pulled from env var
1.6631707115791934e+09	INFO	configmap	GGM cache image 	{"request": "jvm-build-service-test-namespace-fgv6q/jvm-build-config", "cluster": ""}
1.6631707115792418e+09	INFO	configmap	GGM img registry.build01.ci.openshift.org/ci-op-tc15i6z9/pipeline@sha256:022f73e432c748bad684d4af796b85fb78b508cc5d75b58a65e655a7feccd1c5	{"request": "jvm-build-service-test-namespace-fgv6q/jvm-build-config", "cluster": ""}
1.663170711579248e+09	INFO	configmap	GGM cache img registry.build01.ci.openshift.org/ci-op-tc15i6z9/pipeline@sha256:bc240d2487cefdbb2d67f7ba64ce39c3629aee4af085cc4ffdf5c1bc35c68272	{"request": "jvm-build-service-test-namespace-fgv6q/jvm-build-config", "cluster": ""}

will fix lint and do other images in next update

hmmm .. unrelated compile fail in our java code

hmmm .. unrelated compile fail in our java code

but since ci java builds worked, did not affect our e2e's
will have another update with further consolidation / simplification in a bit

this is ready for your review @stuartwdouglas

aside form the passing ci run here, I was able to use the openshit based dev flow locally; based on the changes, I think the minikube based flows should work as well, but I did not actually run the dev flow against minikube

this is going to ease / facilitate my re-introduction of jvm-build-service in infra-deployments per https://github.com/redhat-appstudio/infra-deployments/pull/727/files
I'll try a
/test jvm-build-service-in-repo-apicurio-e2e
for comparison

yeah the overall service registry pain I mentioned in @stuartwdouglas 's PR, including my attempt using main branch, appears to be happening here too

                "message": "Pipeline jvm-build-service-test-namespace-g6nnk/sample-component-build can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task \"maven\": rpc error: code = Unknown desc = malformed header: missing HTTP content-type"

That is an interesting failure, it does not look like it is something from our end though.

/test jvm-build-service-in-repo-apicurio-e2e

and now apicurio is passing for me :-) ... I think that lines up with your comment https://github.com/redhat-appstudio/jvm-build-service/pull/258#issuecomment-1247395398 @stuartwdouglas
so yeah, must have been "upstream" issues yesterday; though it does seem like maybe we lost some debug data with the artifact gathering @stuartwdouglas ? .... admittedly, I'm not 100% sure about that.
That orthogonal observation aside, this seems functionally good to go.  In fact higher numbers that previously (though I don't think that is related to these changes, but are more timing related and upstream churn):
types.go:25: time: 2022-09-15 01:37:11.047507537 +0000 UTC m=+3755.869278112: dependencybuild FINAL created count: 141 complete count: 101, failed count: 33, contaminated count: 6
getting this merged is a prereq for the kcp work, and given its priority, and your approval at https://github.com/redhat-appstudio/jvm-build-service/pull/258#pullrequestreview-1108324297 I am hitting the merge button (I  don't think it will force you to rebase in your PR, but that one is big enough I may have missed something).


Bug: selecting "I already have a secret key" sends to "generating secret key" state

@markmhx are you indicating this is still a bug?

Ah no, I just re-opened assuming it was still unresolved. But based on the history it seems it was, so closing again.


fix: properly handle disabled state in NumberInput

disabled was undefined so the active/disabled classes were not being properly set.
Before:

After:

Included in this PR the translation labels that were missing as well.


[WIP] Coregistration

@jona-sassenhagen the function is mne.coreg.coregister_fiducials. It currently has a scale parameter to use it with fsaverage, but this does not lead to satisfactory results and should be removed before merge.
The PR also contains some other small modifications.

Allow viz.plot_trans to plot fiducials
Allow scaling MRI without label files

Current coverage is 86.54% (diff: 33.33%)

Merging #3466 into master will decrease coverage by 0.22%

@@             master      #3466   diff @@
==========================================
  Files           337        337
  Lines         58693      58746    +53
  Methods           0          0
  Messages          0          0
  Branches       8930       8881    -49
==========================================
- Hits          50928      50844    -84
- Misses         5079       5208   +129
- Partials       2686       2694     +8

Powered by Codecov. Last update f28a3d5...0c36c5f

@christianbrodbeck is this worth resurrecting? It seems like at the very least the MRI fiducials would be cool.

Sure! I can rebase or split it up if you think some features require more work than others.

This could use a rebase (might be easier to start from scratch?) then should be good hopefully

Well the only thing that's left is the actual coregistration which as you indicated should be rewritten with the analytic approach...

For now I think we can keep that. I think that we'll want to write a separate "mode" entirely, e.g. coordinate-frame-center-based instead of nasion-based. It's what I would have expected going in.

Rebased and added a test; This is not nasion based, it just finds a transform to minimize points distances.

Looks  like numpy.int32 does not qualify as Integral in one configuration? https://travis-ci.org/mne-tools/mne-python/jobs/204443245#L2868

Argh, probably an old numpy issue :( Not sure the best way to handle it. Maybe isinstance(..., (Integral, np.int32)) for backward compatibility. We really shouldn't get anything other than int, np.int32, or np.int64 (maybe) anyway.

Actually I get an error in this test (https://github.com/mne-tools/mne-python/blob/master/mne/tests/test_coreg.py#L67) and I am not sure how it could run without error?
    src = mne.read_source_spaces(path)
    mne.add_source_space_distances(src)
    src.save(path)

Looks like you fixed it already, yes?

yes :)

Okay great. This looks pretty simple so I'll merge once the CIs come back happy

Travis is unhappy with style
https://travis-ci.org/mne-tools/mne-python/jobs/205022035#L3106

Thanks @christianbrodbeck


Validation through JavaScript doesn't work

Button clicks are not registering validations for feedback form. Working on it.

Server-side validation has been applied.


⚠ Bofrost.be has degraded performance

In 3c020b5, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1343 ms

Resolved: Bofrost.be performance has improved in fef2160.


False Positives?

Describe the bug :
Camera Indicator triggered by app with no permissions for camera only files.
Expected Behaviour :
Only trigger when camera is accessed not when media files are. Altho it could perhaps be a feature.
Steps to reproduce it :
 Privacy indicator app download from F-droid, AnySoftKeyboard from F-droid, Infinity (Alt Reddit Client) from F-droid. Also OneUI Home this could be non false positives due to it being proprietary.
Smartphone Info :
|Device         || Samsung S22U Exynos
|Android Version|    | Android 13
Would you like to work on the issue?
Yes, but I have no knowledge of programming.

I had the samsung keyboard log a camera alert while I was using another keyboard and when I do use it I have it set to always ask." I have no idea if it was a false alarm or if "they're" watching (I feel like a conspiracy nut just writing this.)


Feature Request - Exclusions within version catalog

Expected Behavior

I'd like to be able to exclude within the dependency resolution management.
Something like this:
dependencyResolutionManagement {
    versionCatalogs {
        libs {
            library('commons-lang3', 'org.apache.commons', 'commons-lang3').exclude {
                group: "org.x.y", module: "z"
            }
        }
    }
}

Current Behavior

Its impossible. The only customization option is within a strict version.
Context

See the stackoverflow question to support this issue.

Version catalog is about declaring versions, not about any kind of metadata level customization. This is to be done where using the catalog entries.


Bug: JSON body parsing with "qouted" JSON-keys

Prism is unable to parse JSON bodies that have quiotation marks "..." around the JSON keys. The JSON specs clearly state that JSON has strings as keys, not plain text.
Current Behavior

Prism logs that the following body is "not an object":
{"current_l1":1000,"current_l2":1000,"current_l3":1000,"voltage_l1":230000,"voltage_l2":230000,"voltage_l3":230000}

For more details, see the full log:

full prism log of that request

2023-10-16 10:23:55 [8:23:55 AM] › [HTTP SERVER] post /████████████/██████-██/██████ ℹ  info      Request received
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     < Headers:
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     <      cookie:
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     <      user-agent: pistache/0.1
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     <      host: host.docker.internal:4014
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     <      content-length: 115
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     < Body: {"current_l1":1000,"current_l2":1000,"current_l3":1000,"voltage_l1":230000,"voltage_l2":230000,"voltage_l3":230000}
2023-10-16 10:23:55 [8:23:55 AM] ›     [VALIDATOR] ⚠  warning   Request did not pass the validation rules
2023-10-16 10:23:55 [8:23:55 AM] ›     [VALIDATOR] ✖  error     Request body must be object
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     Unable to find a 422 response definition
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     Unable to find a 400 response definition
2023-10-16 10:23:55 [8:23:55 AM] ›     [NEGOTIATOR] ⬤  debug     Unable to find a 'default' response definition
2023-10-16 10:23:55 [8:23:55 AM] › [HTTP SERVER] post /████████████/██████-██/██████ ✖  error     Request terminated with error: https://stoplight.io/prism/errors#UNPROCESSABLE_ENTITY: Invalid request

http reponse from prism, CODE 422

{"type":"https://stoplight.io/prism/errors#UNPROCESSABLE_ENTITY","title":"Invalid request","status":422,"detail":"Your request is not valid and no HTTP validation response was found in the spec, so Prism is generating this error for you.","validation":[{"location":["body"],"severity":"Error","code":"type","message":"Request body must be object"}]}

Expected Behavior

The above json is valid json (check for example with https://jsonlint.com/).
Therefore, the request should succeed or at least fail in the verification stage, not the JSON parsing stage.
Possible Solution

Allow quoted json keys, so that both {key: value} and {"key": value}are okay.
Environment

Version used: Docker image :latest
Environment name and version (e.g. Chrome 39, node.js 5.4): Custom C++ Code that queries the server, using the pistache library.
Operating System and version (desktop or mobile): Linux (docker)
Link to your environment/workspace/project: closed source

Nevermind, it was because I did not set the ContentType header to "application/json".


Indian Game vs Indian Defense

What is the standpoint on this? Wikipedia says "Indian Defense" and the sublines have "Defense" in their name as well (Queen's Indian Defense, Nimzo-Indian Defense...)

Yeah, let's go with Defense.


Improve test startup time

Currently lots of tests create test cases by making instances in the following way

@fixture(
    params=(
        Something(),
    ),
)
def some_fixture(request):
    return request.param

this is a problem for two reasons:

if Something() breaks, it breaks before any tests are done and the pytest output doesn't actually tell us much about the error
There is a long test collection time because all the test cases are getting initialized as part of test collection. This makes it really slow run pyest on specific tests, because the collection time takes up so much time

Solution, defer creation of fixture instances until after test collection

@fixture(
    params=(
        lambda: Something(),
    ),
)
def some_fixture(request):
    return request.param()

Note to self: in the upcoming PR, remember  to check that the total number of tests is the same and that if you've added fixtures, that there are no name conflicts between the added fixtures. Also check if there is a way to report if there is a fixture name conflict.


Your repo is so awesome

Please continue to improve your repo.
BTW, what does "actionItem" do? :))
UIBarButtonItem *actionItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemAction target:nil action:nil];
        actionItem.enabled = NO;

        self.editingToolbarItems = @[actionItem, spaceItemLeft, labelItem, spaceItemRight, self.chooseButton];

Haha thanks so much @hungntv! I'll try! I need to paint some more icons for it soon.
My idea for actionItem is so you can insert your own button and attach your own custom logic to it. I put it there because for the app I'm building this for, I want to be able to perform custom actions on any files the user taps. :)
In the demo app, it's just there as an example, so it doesn't do anything when it is tapped. :)


Handle change to binary scanner API for RuntimeException

Issue https://github.ibm.com/was-migration-tools/wamt/issues/4975 requests that the RuntimeException thrown when binary scanner input features are invalid be changed to something like the FeatureConflictException so we can get the features from the exception with getFeatures(). When this issue is addressed we need to update the Liberty plugins to handle the new behaviour.
Note from migration team:
"Note that we also moved the exceptions to a com.ibm.websphere package, so their package is now: com.ibm.websphere.binary.cmdline.exceptions. Initially we were going to keep the old API around for compatibility, but moving the exceptions meant we were already making a breaking change to the old api so we decided to just remove it, although we can add it back if that causes problems for you all.
The ProvidedFeatureConflictException is now thrown in place of a RuntimeException when there is a conflict in the provided features - it has the same API as FeatureConflictException but we used a different exception class so you could tell where the feature conflict occurred."

Fixed by #1449


Add New Account Screen UI changes

Add New Accounts > Description
-we can remove the second line altogether. The reduced size of the logos is not looking good.
-Make it fit in one line.

Use the text same as in the buy menu for services.
Watch Only: View a non-Hexa wallet as an account
Full Import: Fully import a non-Hexa wallet

The UX needs to be done properly to support two lines here. Plus the alignment and size is not correct.
Please see the design here: https://xd.adobe.com/view/91d3b24d-96da-420e-adc7-a7115884db1c-c480/screen/0f336575-dd6a-40e5-9303-f9d21b0f6ca1

Specs Link: https://xd.adobe.com/view/be4bd2ea-118c-4aff-959f-e3243e25ca8f-eb18/screen/f0acbfc5-2ee6-4b2d-9277-dbb02fb313a6/

We should use the same screen as Account Selection during initialisation

Verified this issue on dev app v1.8.0(322)


Disable os specific user keys after enabling root

👍

👍 , just needs a version bump

Has this been tested with centos 7 and ubuntu images?

Its being tested now. PR was sent first for sanity check reasons.

👍


Incorrect indices of matched characters

Is there an existing issue for this?

[X] I have searched the existing issues

Description of the bug
indices returned in below example contains overlapped positions
const Fuse = require('fuse.js')

const list = [
  {
    title: '/images/payment/select-payment-icon.png',
  },
]

const fuse = new Fuse(list, {
  includeMatches: true,
  keys: ['title'],
})

const result = fuse.search('images-payment-select-payment-icon')

console.log(result[0].matches[0].indices)
// Output:
// [
//   [1, 6],
//   [8, 14],
//   [16, 32],
//   [34, 34],
//   [36, 38],
//   [1, 6],
//   [8, 14],
//   [16, 34],
//   [36, 38],
// ]

The Fuse.js version where this bug is happening.
6.6.2
Is this a regression?

[ ] This is a regression bug

Which version did this behavior use to work in?
None
Steps To Reproduce
Run the script in the description
Expected behavior
indices should be matched characters starting from the first one like this:
console.log(result[0].matches[0].indices)
// Output:
// [
//   [1, 6],
//   [8, 14],
//   [16, 34],
//   [36, 38],
// ]

Screenshots
No response
Additional context
No response

I also have fuse highlighting like tons of letters that I havent even typed...

+1


Vibrant capacitor dupe bug

I can see that there are some similar issues open but I'm not sure if they're directly relevant. My apologies if this ticket is unnecessary..
I have a capacitor bank consisting of 96 vibrant capacitors arranged in a simple 7x7x2-high cuboid with tesseracts occupying 2 corner slots. The entire system is within a single chunk, none of the sides touching the chunk boundary. The area is covered by my chunk loader which should unload the chunks when I go offline.
I'm finding that if Items left in the charging slots, the capacitor bank is periodically shedding duplicates of these items. I haven't been able to determine the exact circumstances under which is happens though. I logged off the server last night and when I logged in this morning, my magnet picked up 37 of each of the items I'd left in to charge. While writing this report, I disconnected from the server for a couple of mins to see if that would trigger it, but it didn't.
It would seem that the dupe works for anything that'll go in the slots. So far I have duped resonant energy cells, resonant exchangers, Tier 5 Jetpacks and TiCo picks.
ChickenChunks-1.7.10-<IP_ADDRESS>-universal
EnderIO-1.7.10-<IP_ADDRESS>1
EnderCore-1.7.10-<IP_ADDRESS>_beta
Forge <IP_ADDRESS>2
Forgemodloader <IP_ADDRESS>
If there's anything I can do to help track down this issue, please let me know.

These issues should be fixed in the beta, can you try that?

I'm playing on a server where I don't have control over mod versions. I'll suggest that to the boss. Thanks for the snappy reply!

I'm playing with:
-EnderIO 1.7.10-<IP_ADDRESS>7_beta
-EnderCore 1.7.10-<IP_ADDRESS>_alpha
-Forge <IP_ADDRESS>8-1.7.10
and I have the same issue with the basic capacitor bank. Although it's not chunkloaded, copies of the items in the charging slots spawn on the ground near the capacitor bank. It looks like the amount of the spawned copies is based on the time the capacitor bank was unloaded (I was the only player during tests), these copies don't spawn while I am online.

EnderIO 1.7.10-<IP_ADDRESS>7_beta

@TheUltimateHose current version is 417! please update first and test again!

Now I have updated to the newest version and now the Items in the charging slots disappear and only the copies on the ground remain.

wait what?
the "copy" drop to the ground and the original items in the slot disappear?
so what you meant to say, your issue is now that the items just become dropped(which is not really an issue) but they do not get duplicated are they ?

So the Situation with the new version is:

I put Items in the charging slots
I log off
After some time, I log back on
Depending how long I was offline, multiple copies of the items which were in the charging slots spawn on the ground. The "original" items disappear, so only the duped items remain.

@tterrag1098 this sounds like a cross chunkboundary issue to me
@TheUltimateHose can you verify the whole battery is within one chunk boundary and if not, does the number of copys anyway aproximate to the count of blocks inside any  chunk?

Closing this issue now. Having a related problem but the dupe appears gone.


Add Pydantic People Section to Our Docs

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
@sydney-runkle should work on adding a Pydantic People or Pydantic Contributors section to the docs that encourages open source contributions and highlights the work of regular contributors 😄.
Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

It could be cool to add a section that specifically highlights first time contributors every month 👍


Provide vendor dependences

To have reproducable builds in Go the common pattern is to use Go's vendor experiment.
Please consider placing a copy of the current supported libraries at a "vendor" subdirectory.

As stated in #200, we're looking into this, but we're not yet ready to vendor dependencies.
How we do this affects the build server as well so it's not as simple as you might think.


maigret: 0.3.1 -> 0.4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for maigret is: "Tool to collect details about an username"
meta.homepage for maigret is: "https://maigret.readthedocs.io"
meta.changelog for maigret is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/xwyzifa5ix31xqxks07dgb8v3swhlcc1-maigret-0.4.0/bin/maigret passed the binary check.
/nix/store/xwyzifa5ix31xqxks07dgb8v3swhlcc1-maigret-0.4.0/bin/.maigret-wrapped passed the binary check.
2 of 2 passed binary check by having a zero exit code.
2 of 2 passed binary check by having the new version present in output.
found 0.4.0 with grep in /nix/store/xwyzifa5ix31xqxks07dgb8v3swhlcc1-maigret-0.4.0
found 0.4.0 in filename of file in /nix/store/xwyzifa5ix31xqxks07dgb8v3swhlcc1-maigret-0.4.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
maigret

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xwyzifa5ix31xqxks07dgb8v3swhlcc1-maigret-0.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A maigret https://github.com/r-ryantm/nixpkgs/archive/312587909d37db323a08d73bf130e4d0a9eeb845.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xwyzifa5ix31xqxks07dgb8v3swhlcc1-maigret-0.4.0
ls -la /nix/store/xwyzifa5ix31xqxks07dgb8v3swhlcc1-maigret-0.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

maigret

Maintainer pings
cc @fabaff for testing.

Builds and works properly but it's trying to self update a resources file at every run which can't happen because it's inside the Nix store:
$ /nix/store/ff0f344l8mbm094zz6w1g0xbcxhl7qkc-maigret-0.4.0/bin/maigret foobar --tags dating
[-] Starting a search on top 8 sites from the Maigret database...
[!] You can run search by full list of sites with flag `-a`
[*] Checking username foobar on:
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 8/8 [00:01<00:00,  4.70it/s]
[*] Short text report:
Search by username foobar returned 0 accounts.
Extended info extracted from 0 accounts.
Traceback (most recent call last):
  File "/nix/store/ff0f344l8mbm094zz6w1g0xbcxhl7qkc-maigret-0.4.0/bin/.maigret-wrapped", line 9, in <module>
    sys.exit(run())
  File "/nix/store/ff0f344l8mbm094zz6w1g0xbcxhl7qkc-maigret-0.4.0/lib/python3.9/site-packages/maigret/maigret.py", line 723, in run
    loop.run_until_complete(main())
  File "/nix/store/rppr9s436950i1dlzknbmz40m2xqqnxc-python3-3.9.9/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
    return future.result()
  File "/nix/store/ff0f344l8mbm094zz6w1g0xbcxhl7qkc-maigret-0.4.0/lib/python3.9/site-packages/maigret/maigret.py", line 717, in main
    db.save_to_file(db_file)
  File "/nix/store/ff0f344l8mbm094zz6w1g0xbcxhl7qkc-maigret-0.4.0/lib/python3.9/site-packages/maigret/sites.py", line 304, in save_to_file
    with open(filename, "w") as f:
OSError: [Errno 30] Read-only file system: '/nix/store/ff0f344l8mbm094zz6w1g0xbcxhl7qkc-maigret-0.4.0/lib/python3.9/site-packages/maigret/resources/data.json'

@fabaff is there a way to change this behavior?


"get_penalty_model" in stitch-function does not allow graph size larger than 8

Description
Using dwavebinarycsp.stitch() , if a graph with more than 8 nodes is entered into the function and max_graph_size is extended to 9 an error occurs in the "generate"-function included in the "get_penalty_model"-function. This allows to only build BQMs with small number of connections between variables.

Steps To Reproduce
Execute the Jupyter Notebook below using the sample data provided in the repository. As input enter for example:
departure: Hamburg
destination: Kiel
https://github.com/annaehhh/Quantum-Computing/blob/main/ferrylines.ipynb
Expected Behavior
Build a BQM like the method does for smaller graph sizes. (in the above code, enter departure: Hamburg, destination: Bremerhaven)
Environment

OS: macOS Big Sur Version 11.4
Python version: 3.10.1

Additional Context
Problem seems to be known already, as in the code of generation.py the following comment was found. (Line 178)

Using the following the solution, the maximum graph size can be extended to 32.
in generation.py modify the function as follows:
def all_possible(num_variables: int) -> np.ndarray:
"""Create an array of all possible spin configurations."""
assert 0 <= num_variables < 1 << 32
#changed: now max graph size of 32
a = np.unpackbits(np.arange(1 << num_variables, dtype=np.uint32).reshape(1 << num_variables, 1).view(np.uint8),
axis=1, count=num_variables, bitorder='little').astype(np.int32)
a *= 2
a -= 1
return a
in addition, change dtype of matrix A to np.int32 (as below):
A = np.empty((1 << len(graph), len(indexer)), dtype=np.int32)


Split up node selection

Describe the feature
Per the discussion in #2203, we should split the current test selection into parts:

node selection
DAG construction

This solution must account for ephemeral nodes!
This will be the basis for a few interesting future changes:

dbt run+test
enforce only running a test where all its dependencies have been selected
#2052 - N-child selection
advanced node selection

Describe alternatives you've considered
We can try to bolt those onto our existing framework.
We can avoid changing how node selection works.
Additional context
Not database specific
Who will this benefit?
This is mostly useful for whoever ends up implementing the dependent features.

That's a bummer!
Maybe we should switch current logic to tokenization/grammar preprocessor and AST-based logic? I'm thinking about providing a formal grammar for node selection syntax and work around processing the tree of operations instead of mixing selection logic/tokenization etc. Then just apply it to nodes or tests with different semantics. At the top are tools like lex and yacc.

more info about Yacc and Lex in Python (David Beazley :rocket:): https://www.dabeaz.com/ply/ply.html
series about simple AST: https://ruslanspivak.com/lsbasi-part1/

hey @Raalsky - cool idea! I think it could be sensible to use a proper parser in the future, but in general, I don't think the use-case requires it. The command line is a constrained programming environment, and it's probably not an ideal place to define deeply nested sets of selectors.
I'm happy to keep this in mind for the future -- maybe something like this would make more sense if we added new operators with complex precedence/associativity rules in the future?


Add more github issue templates

question
documentation
cleanup

cc @fisherxu @kevin-wangzefeng

Users need to fill in these charts?

Which charts do you mean? I think the users just choose which category he wants to file.

/lgtm
/approve


The random move mobile button should have a different icon

Using the icon for flip board is confusing

Implemented in v2.3.70


cuda 10

adding support for cuda 10 would be nice.

This has been available for a while now (I think?) Thanks for the suggestion and sorry about the radio silence! :)


Commenter not working

Hi,
I have recently migrated to using full lua with my nvim. In my previous vimscript i was using https://github.com/tpope/vim-commentary
I added this to my plugins.lua
  use {
      'numToStr/Comment.nvim',
      config = function()
          require('Comment').setup()
      end
  }

Installed and restarted
tried the command gcc, gc11j ... etc
Is there a way to debug this?
Regards

Try https://github.com/numToStr/Comment.nvim/issues/115#issuecomment-1032290098

@numToStr thanks but i found an issue from my default config. It is working great now


Get Voltage and current on POWR2 device

There is no method to get device wattage, Voltage and current.

const connection = new ewelink({
email: '',
password: '',
region: '',
});
const device = await connection.getDevice(deviceId);
if (device.online) {
console.log(Power: ${device.params.power}W, Voltage: ${device.params.voltage}V, Current: ${device.params.current}A)
}

Hi @baugp
Installing your fork npm install https://github.com/baugp/ewelink-api would enable me to retrieve Power, Voltage & Current from POW ELITE? Or it requires other modifications as well?
Thank you.


Replace deprecated np.product with np.prod

In NumPy 1.25.0, np.product was deprecated in favor of np.prod and was removed entirely in NumPy 2.0. This PR substitutes np.product with np.prod, allowing xpartition to work with the latest version of NumPy.

Thank you, @spencerkclark!

The v0.2.2 release is up on PyPI now—thanks again for this.

Awesome, thanks for creating the new release so quickly!


Improve and simplify authentication

The current implementation requires callers to write some boiler-plate code, plus it's not very intuitive in some cases.  We should retool how authentication works so it's easier to use.

+1 for this. Some docs or examples/ would go a long way, but a client constructor which handles auth would certainly be the least-surprise way to address this issue.


Pal 642 data service prepopulation

Update to the readers for the data-service prepopuolation

Yes you can change the contents but as far as sonarqube is concerned you can't change the variable. therefore it is a constant pointer to the same map object. It just happens the object is mutable. Therefore I would suggest we leave it as is.


[Question] Can basic-thread-border-router with USB_SERIAL_JTAG work without serial terminal? (TZ-646)

Hi,
I would like to use USB  SERIAL CONFIG_OPENTHREAD_CONSOLE_TYPE_USB_SERIAL_JTAG=y.
However, I must connect basic-thread-border-router to serial terminal(e.g. minicom) for working border router.
Can basic-thread-border-router work without connection serial terminal(e.g. minicom)?

@mmt-10 It should work as is, you don't need to connect serial terminal.
There was a bug in old IDF version, but it has been fixed long ago, please try with IDF 5.1.2, let us know if you see any issue.

Thank you for your reply.
I will try with IDF 5.1.2.


Autocompletion spams errors on invalid get_child() index

Godot version:
3.2.1
Steps to reproduce:

Create a new scene with root node
Add script to root node
Type get_child(1). in the script and press Ctrl + Space
The console gets spammed with errors

This is because the Script Editor tries to get the node from get_child() method, but the node doesn't exist. The editor should check index before calling get_child() and ignore it if it's invalid.

Seems fixed in master, but not sure if due to some refactor or a bug.


[FEAT] Add ability to insert distributed columns at pandas query compiler

Signed-off-by: Dmitry Chigarev<EMAIL_ADDRESS>
What do these changes do?

[ ] commit message follows format outlined here
[ ] passes flake8 modin
[ ] passes black --check modin
[ ] signed commit with git commit -s
[ ] Resolves #1772
[ ] tests added and passing

@devin-petersohn I've implemented distributed insert for pandas query compiler, it allows to insert multiple columns in a scalable way by broadcasting parts with columns to insert to partitions, that specified in locs. This is a draft implementation and I believe that there's a lot of places where it could be optimized, but for now I've got this times:
inserting 6 columns with `_insert_qc`: 0.8802017914131284
inserting 6 columns with `insert`: 7.764727934263647
inserting 1 columns with `_insert_qc`: 0.33948098309338093
inserting 1 columns with `insert`: 1.643635481595993

Script that measured it
import numpy as np
import string
import csv
import os
from timeit import default_timer as timer

IS_PANDAS = True
RAND_LOW = -100
RAND_HIGH = 100
N = 5000
M = 128
TEST_FILENAME = os.path.abspath(f"int_dataset-{N},{M},{RAND_LOW},{RAND_HIGH}.csv")

def generate_data_file(filename, row_n, col_n):
    letters = list(string.ascii_letters)
    columns = [
        f"col{i}"
        for i in np.arange(col_n)
    ]

    with open(filename, "w") as file:
        writer = csv.writer(file, delimiter=",")
        writer.writerow(columns)
        for _ in np.arange(row_n):
            writer.writerow(np.random.randint(RAND_LOW, RAND_HIGH, col_n))

if __name__ == "__main__":
    import modin.pandas as pd

    if not os.path.exists(TEST_FILENAME):
        generate_data_file(TEST_FILENAME, N, M)

    md_df = pd.read_csv(TEST_FILENAME)

    cols = ["col0", "col1", "col2", "col50", "col64", "col90"]
    locs = [0, 1, 2, 3, 50, 51]

    def measure_time(cols, locs):
        src = md_df.drop(columns=cols)
        to_insert = md_df[cols]

        t1 = timer()
        result = src._query_compiler._insert_qc(locs, to_insert._query_compiler)
        print(f"inserting {len(locs)} columns with `_insert_qc`:", timer() - t1)

        src = md_df.drop(columns=cols)
        t1 = timer()
        for i in range(len(locs)):
            src.insert(loc=locs[i], column=to_insert.columns[i], value=to_insert[to_insert.columns[i]])
        print(f"inserting {len(locs)} columns with `insert`:", timer() - t1)

    measure_time(cols, locs)
    measure_time(cols[:1], locs[:1])

@devin-petersohn I need your brief review and ideas how it could be integrated at the API level, because in a current implementation all query compilers are supposed to obtain column as a value, not query compiler. But I believe that even at query compiler level this could a useful feature, for example, I'm going to use it in a pivot_table implementation (#1669), when inserting multiple columns with margins at the resulting frame.

closing in glory of #2443


builtin: execute app whose filename is longer than NAME_MAX

Summary
We should can run app when app's name is longer than NAME_MAX.
Impact
Testing
daily test

This looks simple enough, but are there any other ramification.
What happens in ps and top, , bin files etc?

apps/builtin/Makefile will generate builtin_list.h by collecting all builtin app,  and run these builtapp by their PROGNAME. Sometimes the front NAME_MAX character of multiple files is the same, so an error will occurss, this patch will fix this issue.


Exit Code 1 on attempted Catalysm install

Hi all —
I'm having an issue trying to install Cataclysm (any version, even Bright Nights) through Catapult. I'm running it on a Windows 10 Parallels VM on a Mac with a freshly downloaded copy of the latest version of Catapult, in a folder on my desktop called "Cataclysm." Here's the exit code 1 error I get. When it's downloading the archive, I can watch it download to the folder, but it always fails and deletes itself after trying to extract. Any ideas on how to fix?
`[15:59:03.240] Loading settings from catapult_settings.json.
[15:59:03.276] Welcome to Catapult!
Tip of the day:
Getting unhelpful error messages? Try enabling debug mode under Settings for more verbose output.
[15:59:03.277] Unpacking unzip.exe...
[15:59:03.280] Fetching releases for BN Experimental...
[15:59:05.358] Got 10 releases.
[15:59:11.725] Installing Cataclysm-BN experimental build 2022-10-05-1956...
[15:59:11.725] Downloading cbn-windows-tiles-x64-msvc-2022-10-05-1956.zip...
[15:59:12.248] Downloading: 5.2 MB (6.6%) at 9.9 MB/s
[15:59:12.463] Downloading: 10.3 MB (13.0%) at 23.8 MB/s
[15:59:13.056] Downloading: 15.3 MB (19.3%) at 8.4 MB/s
[15:59:13.325] Downloading: 20.3 MB (25.6%) at 18.6 MB/s
[15:59:13.594] Downloading: 25.4 MB (32.1%) at 19.1 MB/s
[15:59:13.822] Downloading: 30.5 MB (38.5%) at 22.2 MB/s
[15:59:14.063] Downloading: 35.6 MB (44.9%) at 21.0 MB/s
[15:59:14.313] Downloading: 40.7 MB (51.4%) at 20.5 MB/s
[15:59:14.561] Downloading: 45.8 MB (57.8%) at 20.7 MB/s
[15:59:14.797] Downloading: 50.9 MB (64.2%) at 21.5 MB/s
[15:59:15.059] Downloading: 56.0 MB (70.7%) at 19.6 MB/s
[15:59:15.328] Downloading: 61.1 MB (77.1%) at 18.8 MB/s
[15:59:15.611] Downloading: 66.1 MB (83.4%) at 17.7 MB/s
[15:59:15.866] Downloading: 71.1 MB (89.7%) at 19.6 MB/s
[15:59:16.080] Downloading: 76.1 MB (96.0%) at 23.4 MB/s
[15:59:16.390] Finished downloading cbn-windows-tiles-x64-msvc-2022-10-05-1956.zip.
[15:59:16.391] Extracting cbn-windows-tiles-x64-msvc-2022-10-05-1956.zip...
[15:59:21.663] [error] Archive extraction command exited with an error (exit code: 1)
[15:59:30.599] Installing Cataclysm-BN experimental build 2022-10-05-1956...
[15:59:30.599] Downloading cbn-windows-tiles-x64-msvc-2022-10-05-1956.zip...
[15:59:31.124] Downloading: 5.0 MB (6.3%) at 9.5 MB/s
[15:59:31.303] Downloading: 10.1 MB (12.7%) at 28.3 MB/s
[15:59:31.572] Downloading: 15.1 MB (19.1%) at 18.8 MB/s
[15:59:31.786] Downloading: 20.3 MB (25.6%) at 23.9 MB/s
[15:59:32.096] Downloading: 25.4 MB (32.0%) at 16.5 MB/s
[15:59:32.386] Downloading: 30.5 MB (38.5%) at 17.7 MB/s
[15:59:32.821] Downloading: 35.5 MB (44.8%) at 11.5 MB/s
[15:59:33.083] Downloading: 40.6 MB (51.3%) at 19.6 MB/s
[15:59:33.297] Downloading: 45.6 MB (57.6%) at 23.4 MB/s
[15:59:33.725] Downloading: 50.6 MB (63.9%) at 11.7 MB/s
[15:59:33.939] Downloading: 55.6 MB (70.2%) at 23.4 MB/s
[15:59:34.270] Downloading: 60.7 MB (76.6%) at 15.3 MB/s
[15:59:34.498] Downloading: 65.8 MB (83.1%) at 22.5 MB/s
[15:59:34.795] Downloading: 70.9 MB (89.6%) at 17.3 MB/s
[15:59:35.174] Downloading: 75.9 MB (95.9%) at 13.2 MB/s
[15:59:35.339] [debug] HTTPRequest info:
Result: 0
Response code: 200
Headers: [Connection: keep-alive, Content-Length: 83045342, Content-Type: application/octet-stream, Content-MD5: ktHSU9oJ/BjeLN+EDT5baw==, Last-Modified: Wed, 05 Oct 2022 20:35:43 GMT, ETag: "0x8DAA7112CCA06A9", Server: Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0, x-ms-request-id: 2073d206-301e-003f-24e2-dceac6000000, x-ms-version: 2020-04-08, x-ms-creation-time: Wed, 05 Oct 2022 20:35:43 GMT, x-ms-lease-status: unlocked, x-ms-lease-state: available, x-ms-blob-type: BlockBlob, Content-Disposition: attachment; filename=cbn-windows-tiles-x64-msvc-2022-10-05-1956.zip, x-ms-server-encrypted: true, Fastly-Restarts: 1, Accept-Ranges: bytes, Age: 327, Date: Mon, 10 Oct 2022 19:59:30 GMT, Via: 1.1 varnish, X-Served-By: cache-bos4663-BOS, X-Cache: HIT, X-Cache-Hits: 0, X-Timer: S1665431971.888260,VS0,VE22]
[15:59:35.561] Finished downloading cbn-windows-tiles-x64-msvc-2022-10-05-1956.zip.
[15:59:35.563] Extracting cbn-windows-tiles-x64-msvc-2022-10-05-1956.zip...
[15:59:35.700] [error] Archive extraction command exited with an error (exit code: 1)
[15:59:35.700] [debug] Failed command: {args:[/C, "//Mac/Home/Desktop/Cataclysm/utils/unzip.exe" -o "//Mac/Home/Desktop/Cataclysm/cbn-windows-tiles-x64-msvc-2022-10-05-1956.zip" -d "//Mac/Home/Desktop/Cataclysm/bn/tmp"], name:cmd}
[15:59:35.700] [debug] Output:`

//Mac/Home/Desktop/Cataclysm/bn/tmp

This probably has to do with the launcher being in a network folder. It wasn't tested in this scenario. Perhaps the extractor exe is not interpreting the paths correctly. Try using a local folder instead.


Fix orc structural tests

Tests are also less brittle since equality is performed on structural types converted to normal Java collections.  Also, failures are easier to read since we are comparing with normal Java object (and I convert Slice to String)

looks good