Add Refresh Token grant support

Just a draft for now, to run tests and discuss implementation.

Hey @jgrandja, this one is ready for your review. A couple of things I'd like to discuss before implementing are:

Should refresh token be re-issued when a new access token is requested? The spec says "The authorization server MAY issue a new refresh token" and I see this is quite common behaviour for other authorization servers. Should I make it default behaviour or add a configuration option for that?
Refresh token expiration - kind of the same question, should this be configurable? I see a comment that configuring access token expiration is a TODO item, if there'll be a separate story refresh token can also be included there.

Also there is a bit of code repetition in *Provider classes when issuing an access token, I'm not changing that for OAuth2RefreshTokenAuthenticationProvider, I believe you have refactoring in mind?

Thanks @jgrandja, all done now. Feel free to review whenever you are ready.

Thanks for review @jgrandja, I think I addressed all your comments now. Also to recap what we discussed privately: enableRefreshTokens flag stays, refreshTokenTimeToLive is enforced to be greater than Duration.ZERO so that refresh tokens always have expiry date.

Thanks for all the updates @alek-sys ! This is now in master.


color-themes-for-google-code-prettify deleted/made private

color-themes-for-google-code-prettify is currently pointing to https://github.com/dpgowan/color-themes-for-google-code-prettify, which is no longer available.

I've re-registered it to https://github.com/jmblog/color-themes-for-google-code-prettify


Willow demo broken in Safari

Willow doesn't display in Safari (there is only a grayed square) until hovered over, when the normal unprocessed image appears.
Screenshot

From Can I Use
Partial in Safari refers to not supporting the hue, saturation, color, and luminosity blend modes.
That would explain the solid grey colour

I don't see that comment in Can I Use anymore; have a live demo please?

Closing due to this showing browser capabilities


translated into many languages question

I want to translated language in ['zh-CN','en'], when choose 'en' use 'en' language and other use 'zh-CN' language, but I found Only one language effective, i look up the source and found code:
    $.extend($.fn.select2.defaults, $.fn.select2.locales['en']);

pls help me how solve it? (select2 version: 3.5.2)

Any version of Select2 before 4.0.0 can only support one active language at a time. This isn't something that will be changed in the foreseeable future.
Select2 4.0.0 allows you to specify the language with the language option during initialization, which is slightly better.

I know this issue is old as balls but I had this exact same issue and the solution was quite simple... For anyone like me stuck in super old software, you need to include the JS files for the locales you want (except for english, that one is pre-loaded) and then do this when your app changes language:
          $.extend($.fn.select2.defaults, $.fn.select2.locales['en']); // set the language files
          $('select[data-select-search]').select2(); // restart select2.


[Doc] Update TOC.md

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.0 branch-3.1 branch-3.2


[Tests] Fix self-signed SSL Certification generation

Due to the usage of JDK 16, we're forced to use the Bouncy Castle library which is used by netty as a fallback impl for generating self-signed certifications.
See https://openjdk.java.net/jeps/396.
But BouncyCastle has an issue when used with random locales as their date/time string parsing isn't fixed to a locale and some locales produce unsupported date/time strings.
See https://github.com/bcgit/bc-java/issues/405.
To workaround this, the locale is forced to english at the related tests.
Follow up of https://github.com/crate/crate/commit/d61b7873cb8.
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

🥇


Paused fullscreen video activates Hyprlock but overlays it

Hello,
When watching Youtube on my laptop I noticed if I pause the video while in fullscreen and walk away it triggers hyprlock. When I get back the video is overlaying hyprlock, I can still get in by typing my password and pressing enter but it doesn't seem like optimal behavior as there is no indication other than that I cant move my cursor or use keyboard that hyprlock is active.
Hyprlock 0.3.0
Hyprland 0.40.0

fixed in hyprland git


The layer block is missing in generator.py

I tried to reproduce the results in the paper, but there is no definition for ConvEncoderSkipConnectionBlock.
I guess it was missing.

Hello, @hjdw2.
I accidentally happened to land on this today and read your comment for the first time. It is pity that I didn't get to read and address your issue. I have updated the code with the latest comment. https://github.com/IBM/gfmn/commit/2cdfb13d82d1fad483fd746b29317cfae671daea


Add pull request template

Description
Add pull request templated
What types of change is it?

Internal

Reference ticket / issue
Issue: #579
Checklist

[x] CHANGELOG updated

It'd be good to add something about what testing has been done on the work. I stole the below from https://github.com/alphagov/govuk-frontend/pull/569
The below might be too much for every single small change but maybe we could establish what our minimum testing criteria is?
Testing

Inverse colours ✅

Cross browser testing ✅
Known issues:

Note that some of the older browser have centered crest logo, this is now left aligned to fix an issue and section break. Has been tested with my eyes but not re-screenshotted.

IE8

Fixed (html5 shiv):

IE9

IE11 (IE10 looks similar)

Edge

Windows, Chrome

Windows, Firefox

Mac, Safari

Mac, Chrome

Mac, Firefox

iPhone 6s

After fix:

iPhone X

Android, Chrome

Android, Firefox

Windows phone

After fix:

Operating system
Browser
Tested

Windows
Internet Explorer 8-10
✅ Windows 7, IE 8 - 10

Internet Explorer 11
✅ Windows 7, IE 11

Edge (latest versions)
✅ Windows 10, Edge 16

Google Chrome (latest versions)
✅ Windows 10, Chrome 64

Mozilla Firefox (latest versions)
✅ Windows 10, Firefox 58

macOS
Safari 9+
✅ macOS High Sierra, Safari 11- macOS El Capitan, Safari 9.1

Google Chrome (latest versions)
✅ macOS High Sierra, Chrome 61

Mozilla Firefox (latest versions)
✅ macOS High Sierra, Firefox 57

iOS
Safari 9.3+
✅ iPhone 6S, iOS 9, Safari - iPhone 6, iOS 8, Safari - iPhone 7, iOS 10, Safari

Google Chrome (latest versions)
✅(see Safari iPhone 6s) iPhone 6s, iOS 8, Chrome

Android
Mozilla Firefox (latest versions)
✅ Samsung Galaxy S8, Firefox

Google Chrome (latest versions)
✅ Samsung Galaxy S8, Chrome

Windows Phone
Internet Explorer (latest versions)
✅ Windows Phone, Lumia 930 8.1

Assistive technology testing ✅(see notes below)

Software
Version
Type
Browser
Tested

JAWS
15 or later
screen reader
Internet Explorer 11
✅Jaws 18 works fine, Jaws 17, Jaws 16, Jaws 15

ZoomText
10.11 or later
screen magnifier
Internet Explorer 11
✅Right most column could be missed, however underlines in headings could help lead people but that's not guaranteed.

Dragon NaturallySpeaking
11 or later
speech recognition
Internet Explorer 11
✅Clicking on links and images works

NVDA
2016 or later
screen reader
Mozilla Firefox (latest versions)
✅headings can be read out, lists are announced as expected, images have accessible names, passes criteria

VoiceOver
n/a
screen reader
Safari 10 (or higher) on Mac OS X 10.10, and iOS 10.3 (or higher)
✅headings and lists can be tabbed through and make sense.

I'm worried that external contributors will be put off if they need to fill in lots of details at this stage. If we want additional information should we mark it as optional?

That's true. Maybe we could do it the other way around and ask them to confirm what testing they've done? I would maybe be a bit worried if a UI change had only been tested in Chrome so it'd be good to know that when the PR comes in?

closing this. we need to decide what goes into the template


How I can get title from result without js(just with your lib param)?

Now I get
city:[{
$$hashKey:"object:24",
description:undefined,
image:"",
originalObject:Object,
title:"Москва",
__proto__:Object}]

But I want get just city:"Москва"
Your lib is perfect but this is big problem for me.
Thanks

Here is how:
[your selectedObject].title

nope, not in controller. I want set to selectedObject not object, only title from this object.

Use callback.
https://ghiden.github.io/angucomplete-alt/#example7


Cielo control unreliable within automation

@bodyscape I have been using your custom integration for a while now - it is truly great!
One issue I wonder if you can help with? I have noticed when I include Cielo commands in automations they often do not work. Using the Cielo controls in a dashboard always works. Using Cielo commands in a script works if the script is run from the dashboard, but often they don’t work if the script is called from within an automation. The automations clearly run (lights on, etc) but the Cielo calls don't make any changes on the Cielo device.
Any thoughts / trouble shooting?

The cielo command execute the same code of the ui button

I would expect the same… however I get 100% reliability sending commands within the HA UI, but maybe 50% reliability when a command is within an automation. I will try changing my automations (perhaps to only issue one heat pump command per automation) to see if that makes any difference….

maybe this will help. I notice about a two second delay for the cloud to respond.  So try sending just one command and then a wait delay... then the next command

That's a good idea, put a little delay between the call. Fast back to back call can cause problems, i'll check on it.

Not sure if it's related but the integration stopped working for me a couple of days ago (it's spotty at best).
It picks up the state changes from the A/C app but HA UI and integrations don't work anymore.

Recently UI commands also stopped working for a few days - started working again after yesterdays update to 1.7.6 (coincidence?).
Here is an example of an automation that does not turn down the heat pump. I do receive the notification to my phone - so overall, it is 'working', just not the Cielo Home part.... No errors on Trace.
Here I am calling a script to set the temp. The script works fine from the UI, but not within the automation. Does not work calling the temp change directly either (I was testing using the script in case it worked).
`alias: "Heatpump: Left turned up at 2300hrs!"
description: ""
trigger:

platform: time
at: "23:00:00"
condition:
condition: and
conditions:

condition: state
entity_id: switch.heat_pump_power
state: "on"
type: is_temperature
condition: device
device_id: b4049f004387b4ef17e5bdxxxxxxxxxx
entity_id: 64fafd3df23808984530bcxxxxxxxxxxx
domain: sensor
above: 16
action:

service: climate.set_hvac_mode
target:
device_id:
- b4049f004387b4ef17exxxxxxxxxx
data:
hvac_mode: heat
enabled: false
delay:
hours: 0
minutes: 0
seconds: 10
milliseconds: 0
enabled: false
service: number.set_value
data:
value: "16"
target:
device_id: b4049f004387b4ef17xxxxxxxxxxxx
enabled: false
service: script.set_heat_pump_to_heat_16_degrees
metadata: {}
data: {}
service: notify.mobile_app_arp_iphone
data:
message: Heat pump was left turned up! Heat pump now set to 16
title: Heat Pump
mode: single
`

`alias: Set heat Pump to Heat, 16 Degrees
sequence:

service: climate.turn_on
metadata: {}
data: {}
target:
device_id: b4049f004387b4ef17xxxxxxxxxxx
delay:
hours: 0
minutes: 0
seconds: 10
milliseconds: 0
service: climate.set_hvac_mode
metadata: {}
data:
hvac_mode: heat
target:
device_id: b4049f004387b4ef17xxxxxxxxxxxxx
enabled: true
delay:
hours: 0
minutes: 0
seconds: 10
milliseconds: 0
service: number.set_value
target:
entity_id: number.heat_pump_target_temperature
data:
value: "16"
mode: single
icon: mdi:heat-wave
`

@andypnz  do you still have problems?

@bodyscape Yes, issue persists…
Within the automation I have a delay, then command
Then actually repeat the sequence - doing this, it works 95% of the time
Other bits of the automation work - it seems to only be the Cielo part that sometimes does not… no error, etc….

I've experienced something very similar and I suspect it's related to some sort of server-side load or rate-limiting condition.
I'd see this frequently over the summer with an automation I had running at 7:00am - it'd appear to run successfully in HA but silently fail at least a couple of times a week.  Other automations triggering on non-time-based circumstances didn't seem to have this issue, or at least not as much (ie. a temperature threshold-based trigger).
That's anecdotal, but if your automations are configured to fire at round numbers (ie. 7:00), consider offsetting them a little bit - if that substantially improves the behavior it might help us identify a condition with Cielo server load that causes issues during intervals of high usage.

Interesting thought… and the automation is at ‘round hour’ times… it is summer here, so the heat pump is off… but will keep this in mind as winter approaches!


Llvm int support

Added llvm int support
split the dtype tests so that int tests are now run for llvm runtime

Hmm, conflicts with your last PR (which I merged)

rebased and pushed

Sweet, thanks. You interested in a $200 int8 LLaMA bounty? Would also involve a quality check on LLaMA for both float16 and int8.

Sure, is there a issue or pr with more info on the task ?

Nope, it's just what's described:

Get LLaMA 7B running with uint8 weights (leave float16 support too)
Evaluate both the float16 one and uint8 one with ARC+HellaSwag+MMLU+TruthfulQA and confirm they match https://huggingface.co/spaces/HuggingFaceH4/open_llm_leaderboard
Bounty created and locked to you.


Not finished yet. Wanted to get advice.

I'm having a  hard time on chaining methods. Maybe you can give me some pointers :)

Sure thing.

What's it doing?
What did you expect it to do? Why?


fix the dashboard toolbar not load issue

I noticed in latest insider build, when you have sql-database-project extension installed, the dashboard's toolbar doesn't have all the expected items with error messages in the console.

turns out this is caused by the recent vscode merge, we added a class in the vscode's file, and in the recent vscode merge, we changed the implementation of how to add css classes to the node (the old addClass method is deprecated)
old:
https://github.com/microsoft/azuredatastudio/blob/release/1.26/src/vs/platform/actions/browser/menuEntryActionViewItem.ts#L359
new:
https://github.com/microsoft/azuredatastudio/blob/main/src/vs/platform/actions/browser/menuEntryActionViewItem.ts#L292
the new one doesn't allow empty css class names, and caused the error above.
the fix is to check whether the class is empty and only add it to the list if it is not empty.
with the fix, the toolbar is loading as expected:

more information on this class:
this was added here by Chris for notebook toolbar (it passes in a default class name 'notebook-button', but I couldn't find the definition of it in our code base) @chlafreniere , if the class name doesn't actually exist, could you please remove it?
https://github.com/microsoft/azuredatastudio/blob/main/src/sql/workbench/contrib/notebook/browser/notebook.component.ts#L512
currently only dashboard and notebook are using this class.

Pull Request Test Coverage Report for Build 591938561

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.001%) to 43.269%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
1
73.46%

Totals

Change from base Build 591325649:
0.001%

Covered Lines:
25007

Relevant Lines:
52979

💛  - Coveralls

@alanrenmsft Thanks - looks like this fixes https://github.com/microsoft/azuredatastudio/issues/14281


CollectionView can't add a footer to display an ActivityIndicator for infinite scrolling

Marking this as out of scope because UIKit doesn't support this behavior out of the box for UICollectionView.


When SSR: false, color-mode not working

Version
@nuxtjs/color-mode: 3.0.2
nuxt: 3.0.0-rc.2
Reproduction Link

Steps to reproduce
What is Expected?
What is actually happening?
Cannot read properties of undefined (reading 'preference')
at http://localhost:3000/_nuxt/node_modules/@nuxtjs/color-mode/dist/runtime/plugin.client.mjs:8:24
at useState (http://localhost:3000/_nuxt/node_modules/nuxt/dist/app/composables/state.mjs:7:26)
at http://localhost:3000/_nuxt/node_modules/@nuxtjs/color-mode/dist/runtime/plugin.client.mjs:7:21
at fn (http://localhost:3000/_nuxt/node_modules/nuxt/dist/app/nuxt.mjs:106:27)
at callWithNuxt (http://localhost:3000/_nuxt/node_modules/nuxt/dist/app/nuxt.mjs:111:12)
at applyPlugin (http://localhost:3000/_nuxt/node_modules/nuxt/dist/app/nuxt.mjs:68:29)
at applyPlugins (http://localhost:3000/_nuxt/node_modules/nuxt/dist/app/nuxt.mjs:77:11)
at async initApp (http://localhost:3000/_nuxt/entry.mjs:44:7)

I am also experiencing this issue.

I believe this is related to a change in Nuxt shortly before the RC where a Nitro hook was removed.  It is mentioned in the PR #139 but there's not any code to fix it yet.


Create a fuzz test that randomizes topology changes, cluster actions, and CQL operations

fixed all feedback or asked for more details (also poked you in slack)
you have 2 similar / related feedbacks, so trying to address here (GH isn't letting me reply...)
https://github.com/apache/cassandra/pull/3486#pullrequestreview-2263041945 - I tested out a CommandsBuilder and it made the test RouteIndextTest in cep-15-accord easier to read, but I don't see how it helps in this case due to 2 variables that I am not sure how to handle (without making the builder specific to this class)
final List<Runnable> preActions = new CopyOnWriteArrayList<>();
final List<Runnable> onError = new CopyOnWriteArrayList<>();

The State has a preActions and onError actions... these kinda distort the model and are plugged into the Commands functions... if I move to a CommandsBuilder model I think onError doesn't really change much, but preActions gets funky.  Personally I feel the preActions is a hack... it would be great to return Command so the history does reflect those steps... but that would kinda require each Command returned to be a MultiCommand... and what about actions that don't mutate anything and just update the State's bookkeeping?  those don't change the history and would just clutter up the error message...
https://github.com/apache/cassandra/pull/3486#discussion_r1732701880
I don't see how a builder works in this specific case.  We are creating a single Command and this command has 3 behaviors: if topology changed do read, 20% of the time do reads, 80% of the time do writes.... the builder would need to handle the if topology changed bit... which seems funky... and doing a builder for the 20%/80% case seems more verbose than the current logic

ok pushed to using the new CommandsBuilder... the test is now
statefulBuilder.check(commands(this::stateGen)
                              .preCommands(state -> state.preActions.forEach(Runnable::run))
                              .add(2, (rs, state) -> {
                                  EnumSet<TopologyChange> possibleTopologyChanges = possibleTopologyChanges(state);
                                  if (possibleTopologyChanges.isEmpty()) return ignoreCommand();
                                  return topologyCommand(state, possibleTopologyChanges).next(rs);
                              })
                              .add(1, (rs, state) -> repairCommand(state, rs.pickInt(state.topologyHistory.up())))
                              .add(7, (rs, state) -> state.statementGen.apply(rs, state))
                              .destroyState((state, cause) -> {
                                  TopologyMixupTestBase.this.destroyState(state, cause);
                                  state.close();
                              })
                              .build());

still not a fan of preCommands but also not a fan of what I am doing now... at least this interface doesn't make things worse...
one thing that is nice with this builder is I flip Gen<Command>, Weight, I personally prefer weight first then the command, always found the gen first harder to read (its an impl detail, we store the Gen in the map as the key)

also removed onError as that is an accord thing... I added that for better debugging of timeout... it doesn't need to be in the base interface and can be done in AccordTopologyMixupTest.destroyState, so moving it there


Import - TypeError: fn is not a function when chai.use(chaiJsonPattern)

Hello,
See the following code:
import 'mocha'
import chai, { expect } from 'chai'

import chaiJsonPattern from 'chai-json-pattern'
chai.use(chaiJsonPattern)   // <== TypeError: fn is not a function

I tried import { default as chaiJsonPattern } from 'chai-json-pattern' with the same result.
The require('...').default won't work in this context (ES6 Module). What's the right way?
Thank you.

Try this:
import 'mocha'
import chai, { expect } from 'chai'

import chaiJsonPattern from 'chai-json-pattern'
chai.use(chaiJsonPattern.default)

Works like a charm!
Thank you, @WhiteAutumn


A way to hide markdown formatting.

Right now if I were to bold some text, I would get **Hello!**. It would be bold, and also include the ** around it. This is odd to me, and I think would confuse my users. I'd like to have it one way or the other:

Hitting bold simply makes the text bold
Hitting bold simply puts ** around the word. (exactly like posting on github)

Of course I am talking about all formatting, not just bold. Is this possible?

I think that this is one of the main features of SimpleMDE, and the very thing that makes it Simple. It makes it crystal clear to users exactly what each bit of Markdown markup does, and allows them to modify the formatting with ease. It augments the editable text with Markdown formatting rather than replaces it.

My goal is to provide a box in which my users can chat with one another; it is not my goal to teach people Markdown. SimpleMDE is a beautiful, minimal editor and I'd like to use it, so long as either of my issues could be resolved in some way. I'd like to see #1, but I expect #2 shouldn't be too hard to implement. If this goes against the purpose of simpleMDE, then I must move on, it seems.

See prior discussions in #281 and #232

RIP. Sorry I missed these two, especially when they're so recent.

I need to disable the character formatting.
E.g
Same to GitHub editor "** Bold **".

I will add the underline button. So how to apply the formatting in a new underline button.


Support osx-arm64

Hi, I have issues installing cyvlfeat on my Mac M1 (osx-arm64).
Do you intend to provide a (condo) build for this system?

https://anaconda.org/conda-forge/cyvlfeat/files


binding "alt-'" does not work

OS: Arch-Linux x64 (kde)
version: 1.0.2 https://aur.archlinux.org/packages/atom-editor-bin/
When i try to bind to "alt-'" it shows up in the keybindings menu but does not function.
however "ctrl-'" does work (both in the menu and the binding actually works.
For clarification, I am using a fairly obscure keyboard layout (programmer-dvorak)
In my layout, the ' is where z is in qwerty. So I would like to bind
"alt-'": 'core:undo' or 'alt-'': 'core:undo
but that does not work. As in pressing the keys does not actually undo
"ctrl-'": 'core:undo' and 'ctrl-'': 'core:undo'
both work. As in pressing the keys does actually undo
I also tried binding it to other commands
'ctrl-'': 'command-palette:toggle'
does not work
I also tried changing keyboard layouts, and in qwerty I could not seem to make the binding work either.
My unsubstantiated theory is something is not properly reading the ' character even when escaped.

I think this is a duplicate of https://github.com/atom/atom-keymap/issues/35 and https://github.com/atom/atom-keymap/issues/37 – let's keep the discussion there.


Automated Package Upgrade

:tada: This PR is included in version 7.7.135 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update ReadOnlyTransaction test to correctly fail and use the rollback

Disclaimer
The test is deprecated since 4.3.0, but still left in the suit.
Problem
Test failing for SQLite database.
I couldn't figure out why would the rollback event be triggered in the catch section of the try/catch block. So I introduced a read-only object to intentionally fail the write. With that mechanism, the rollback is triggered and the rest of the test works.
Questions

Is there a better way to enforce an object to be read-only (non-writable) that the test could leverage? One way is to return false from onBeforeWrite hook, but that would require an extension anyway. Open to suggestions.
Should the test be removed completely?

@sminnee thoughts on this? You wrote the test initially. Thanks

This update addresses one of the failing tests in https://github.com/silverstripe/silverstripe-framework/issues/9235

Thanks for the PR @michalkleiner! It sounds like this isn't the approach we'd like to take at the moment, so I'm going to close this PR. Feel free to open a new one with @sminnee's suggestions in mind if you'd like to 😄

Thanks @sminnee, I looked at what the READ ONLY param might be doing but didn't find anything within SQLite, and apart from the test also nowhere in the code base, so I assumed it was just a dummy string for dev code guidance rather than an actual db feature. I'll provide an updated PR. Thanks for the direction.


feat: Add object-property-list component

This PR adds the object-property-list component.
One important consideration: I have removed any whitespace-trimming logic from this PR, which means that the spacing between items is currently larger than the designs, because there are extra spaces being rendered. I will make a separate PR to add a TrimWhitespace mixin which removes all unwanted whitespace - this will also involve updating the visual-diff goldens.
I have also included one small typo fix for the menu readme.
Rally: https://rally1.rallydev.com/#/?detail=/userstory/638301646821&fdp=true

Okay, I think I've tracked down the cause of the visual-diff failure (Error: Expected options.clip.width not to be 0.) - something to do with its display CSS. I've fixed it by putting the ID on the parent div instead.
Still investigating the Webkit unit test error.

Question: I want to add an rtl test, but I'm having difficulty getting it to behave correctly. This is what I get when I put dir="rtl" on the visual-diff div (note that the list and individual items don't get RTL applied):

And this is what it looks like in the demo (which is what I want):

Any advice?

Also, I'm unable to reproduce the Webkit problem locally:
https://github.com/BrightspaceUI/core/runs/7240437975?check_suite_focus=true#step:8:124
It seems to be happening consistently though on the PR. I'm adding await elem.updateComplete to see if it fixes things, but it shouldn't be necessary (the update is purely CSS, doesn't depend on Lit).

Question: I want to add an rtl test, but I'm having difficulty getting it to behave correctly. This is what I get when I put dir="rtl" on the visual-diff div (note that the list and individual items don't get RTL applied): ...
Edit: I could just add dir="rtl" individually onto each component, if that's the right approach...

The RtlMixin only looks at the document element when it checks whether or not to sprout dir="rtl" on itself, so ignoring the fact that a page reload takes more time, the best way to test this is to render the page with dir="rtl" applied to that element. Sometimes we will set up the test like this, and the corresponding fixture like this so that the environment matches exactly what we expect in our app. If taking this approach, we ideally still try to minimize the page reloads, so we would try to do all the LTR tests, reload the page, then do all the RTL tests.
Having said that, the "cheater" way to do this without any page reloads is to just stick dir="rtl" on all the components that require it - in effect hard-coding what RtlMixin does. We do have components that do it that way, but if the test involves multiple components that would need it, I'd be inclined to do it as described above.

If there are no objections, I'll merge before EOD today 😄.


Allow "login" without having to integrate with an external active directory.

this will be solved in https://github.com/open-metadata/OpenMetadata/issues/6894

@harshach is this resolved with 0.12?

only backend, UI will be landing in 0.12.1. We have a duplicate ticket https://github.com/open-metadata/OpenMetadata/issues/6894 . Closing this. @Arturo-Penas-Rial please follow the updates in #6894


Consider supporting custom architectures

https://github.com/kornelski/cargo-deb/blob/0a0598027d36a56c5357d5bb00e22f5c62c339d9/src/manifest.rs#L1179-L1197
In debian, there are mipsel and mips64el, but not mipsr6el and mips64r6el as above.
By the way, on some distributions, if you use dpkg to install deb packages, it will require the musl-amd64 architecture instead of amd64.
I don't think relying on automated detection architecture will necessarily make everyone happy.
It will be even better, if we can configure architectures in [package.metadata.deb].

My philosophy with cargo deb is to work by default with just running cargo deb, so I'd prefer to fix or expand this list as necessary instead of adding manual configuration steps. There's a limited slow-changing list of architectures that both Rust and Debian support, so it shouldn't be too hard to keep up.

In rust 1.71.0, the target triple loongarch64-unknown-linux-gnu has been promoted to tiger2.
However, different deb distributions correspond to different deb architectures for this target.

In loongnix, it is loongarch64.

In debian-ports, it is loong64.

They are the same target, but they correspond to different deb architectures.
You might say, I don't have a loongarch CPU, why should I be concerned about this issue?
All right. In fact, I don't have one either.
I'm just curious about how to solve this issue.

What a mess with the naming. It looks like loong64 will eventually win, so I've picked that.


BlockGraph -> Computation

Is your feature request related to a problem? Please describe.
There is currently a missing piece in the chain of data-structures we use to go from a .dae file to a stim circuit: we cannot build a Computation instance from a BlockGraph instance.
Describe the solution you'd like
It is necessary for the tool to be able to build a Computation from a BlockGraph instance.
Additional context
It may be interesting for #287 to change the data stored in the Computation data-structure and also include a graph-like representation of the blocks, to avoid having to re-compute block neighbouring information when calling Computation.to_circuit. As such, in accordance with the person on #287, it is entirely possible to re-write the Computation class from scratch.

I'll have a look at this!


add mutagen to docker requirements

Motivation for changes:
support metadata editing via python in exec plugin
Detailed changes:

add mutagen package in docker image

https://github.com/python-poetry/poetry/pull/7637 this change in poetry 1.5.x  removed the category from the lock file. does it cause any issues?

I think the poetry changes to the lock file are fine. Not sure how I feel about more deps that aren't even part of included plugins. Starting to think we need some sort of easier solution for users to add deps more easily to their container.

good point, shouldn't include stuff that isn't used by flexget. I can get by with either a custom entrypoint script to install it on run or a custom image using this as a base image.

I was thinking about entry point scripts, but I think custom Dockerfiles end up being a bit simpler. Perhaps we should add a wiki page with instructions for this, as well as instructions for how to update. (Like reminding people to do a build --pull to grab the latest base image when upgrading.)

I was thinking of updating the wiki page for it.

https://flexget.com/InstallWizard/Docker#custom-dockerfile

Awesome! There was more info already in there than I realized. I added a bit to your custom image section about --pull to do an upgrade to the latest flexget version.


gramma fix at line 188

From: An example of a for the ADO.NET provider ...
To: An example of the ADO.NET provider ...

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thank you for your time. Merging...


Fix/bm 545 Rtc client call fixes

Task

JIRA

Description

Move RxWebSocketClient from service to viewModel and delete service
to simplify the process since service isn't required here.
Check if RxWebSocketClient is open before connecting again
Check if recording is in process before starting it. This handles
case when user is clicking NavDeepLink while being in app.
Also fixed memory leak in RtcClient

          2 Warnings

:warning:
app/src/main/AndroidManifest.xml#L0 - The project references RTL attributes, but does not explicitly enable or disable RTL support with android:supportsRtl in the manifest

:warning:
app/src/main/AndroidManifest.xml#L20 - On SDK version 23 and up, your app data will be automatically backed up, and restored on app install. Your GCM regid will not work across restores, so you must ensure that it is excluded from the back-up set. Use the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html

          1 Message

:book:
:link: BM-545

JaCoCO Code Coverage 3.16% :white_check_mark:

Class
Covered
Meta
Status

co/netguru/baby/monitor/client/feature/client/home/ClientHomeViewModel
0%
0%
:white_check_mark:

co/netguru/baby/monitor/client/feature/client/home/SendFirebaseTokenUseCase
0%
0%
:white_check_mark:

co/netguru/baby/monitor/client/feature/client/home/ClientHomeActivity
0%
0%
:white_check_mark:

co/netguru/baby/monitor/client/feature/machinelearning/MachineLearningService
0%
0%
:white_check_mark:

co/netguru/baby/monitor/client/feature/communication/webrtc/base/RtcCall
0%
0%
:white_check_mark:

co/netguru/baby/monitor/client/feature/communication/websocket/RxWebSocketClient
0%
0%
:white_check_mark:

co/netguru/baby/monitor/client/feature/server/ChildMonitorViewModel
0%
0%
:white_check_mark:

co/netguru/baby/monitor/client/feature/client/home/livecamera/ClientLiveCameraFragment
0%
0%
:white_check_mark:

co/netguru/baby/monitor/client/feature/firebasenotification/FirebaseInstanceManager
0%
0%
:white_check_mark:

APK file size

size

21.9MB

Number of method references

Dex file
count

classes.dex
35020

  Generated by :no_entry_sign: Danger


Update aws-java-sdk-dynamodb to 1.12.666

About this PR
📦 Updates com.amazonaws:aws-java-sdk-dynamodb from 1.11.1034 to 1.12.666
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #547.


Update one-click-ingestion-existing-table.md

@TzviaGT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TzviaGT Closing due to migration. We will pick these up post migration


defineReplyBot.js - build function to define reply bot

IgnoreReplies: boolean, default true, tells it to only reply to mentions and not replies to its posts
replyResponse: function to determine content to post in replies to your tweets, if ignoreReplies set to false and this not entered, will run normal content function
Function that returns content you want to post or just content string
Function needs to take optional done argument and the tweet that triggered it
Callback to run when complete
This will call the tweet method on the content that it's given to post

flag to tell it whether to use rest or streaming, default streaming.


Getting to know about build struct of PostgreSQL and Apache AGE

Hello Eya, I will be the OM for this project.

Getting to know the PG build system would help in creating directory structure for AGE extension
Following are the official repositories for PG RPM and Debian packages
https://salsa.debian.org/postgresql/postgresql
https://git.postgresql.org/gitweb/?p=pgrpms.git;a=summary

I'm really excited to work on this project.

I'd like to work on this project. Really exited.

Steve here for back up my interns. Good luck guys.

Thank you @Steves452 😀

@Steves452 Thanks 😄!

@eyab please close this ticket as project was completed.


Screenshot broken

Hi @Lissy93
Awesome tool you created!
Deployed my own, but sadly the screenshot tool is not working correctly?
I'm running the latest docker and getting the following error:
Failed to load resource: the server responded with a status of 500 (Internal Server Error)
instrument.ts:132 Fetch Error - screenshot[13:40:32] The screenshot job failed after 582ms, with the following error:Failed to launch the browser process![108:108:0419/114031.894572:ERROR:ozone_platform_x11.cc(239)] Missing X server or $DISPLAY[108:108:0419/114031.894782:ERROR:env.cc(257)] The platform failed to initialize.  Exiting.[108:132:0419/114031.896153:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directoryTROUBLESHOOTING: https://pptr.dev/troubleshooting

In Docker, it looks like the web-check app may not be able talk with Chromium for the following reasons:

dbus isn't started
chromium may not be able to start if the user is root
chromium cannot start if there is no X server running

I think the solution would be to modify the Dockerfile to first start xvfb and dbus.


chore: Update deprecations in instrumentation-express/examples

Which problem is this PR solving?

The example code for instrumentation-express is out of date.

Short description of the changes

This updates the README to make the install work
the opentelemetry library versions to the latest
and the tracing code to switch all deprecated imports to their replacement.

Here are a few attempts of my steps to get the express example built and working with a fresh git clone.
I think it might be nice to pick one of these and add some of these exact commands to the README to help newer users get the example working.
attempt 0
I didn't actually play with and try to get the npm install --workspaces=false way. I don't think it is necessarily a bad way to do it, but I think it will end up fighting the workspaces setup a bit.
attempt 1
Getting example working with a full build of all packages in the repo. This
unfortunately takes a long time.
# Get a build of the Express example and its dependencies.
git clone git@github.com:open-telemetry/opentelemetry-js-contrib.git
cd opentelemetry-js-contrib
npm ci
npm run compile
cd plugins/node/opentelemetry-instrumentation-express/examples
npm run compile

# Start an Zipkin to use viewing traces.
docker run --name example-zipkin --rm -d -p 9411:9411 openzipkin/zipkin

# Run the express server, configured to export to Zipkin.
npm run zipkin:server

# In a separate terminal, run the client that calls the express server.
npm run zipkin:client

Visit the Zipkin UI to search for spans for the client requests.
When finished then clean up:
docker kill example-zipkin

attempt 2 (requires a patch)
I was able to reduce the build time, somewhat by trying to install (via npm ci) and compile only in the required subdirs:
git clone git@github.com:open-telemetry/opentelemetry-js-contrib.git
cd opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-express
npm ci
npm run compile
cd examples
npm ci
npm run compile

However, that requires this patch to work:
diff --git a/plugins/node/opentelemetry-instrumentation-express/package.json b/plugins/node/opentelemetry-instrumentation-express/package.json
index 91065940..edfb4477 100644
--- a/plugins/node/opentelemetry-instrumentation-express/package.json
+++ b/plugins/node/opentelemetry-instrumentation-express/package.json
@@ -12,7 +12,7 @@
     "clean": "rimraf build/*",
     "lint": "eslint . --ext .ts",
     "lint:fix": "eslint . --ext .ts --fix",
-    "precompile": "tsc --version && lerna run version:update --scope @opentelemetry/instrumentation-express --include-dependencies",
+    "precompile": "tsc --version && npm run version:update",
     "prewatch": "npm run precompile",
     "version:update": "node ../../../scripts/version-update.js",
     "compile": "tsc -p .",

and I'm not yet sure of the implications of doing this in general. Doing this probably should be done on a separate PR that looks at doing it generally for all the packages in this repo.
attempt 3
This installs all deps at the top-level (npm ci), but only runs the compile step in the express instrumentation and examples subdir. This is much faster and works:
git clone git@github.com:open-telemetry/opentelemetry-js-contrib.git
cd opentelemetry-js-contrib
npm ci
cd plugins/node/opentelemetry-instrumentation-express
npm run compile
cd examples
npm run compile

What do you think about documenting these steps in the README?

Hm looks like the updated merge from main failed some status checks, think we should be able to run npm ci to fix it. @jessitron let me know if this is something you can update or if you want any assistance in updating.

Not entirely sure why but I'm unable to push to this PR from my local env.
I think I fixed this with a merge commit over here if you want to cherry-pick it (ae10db5). Alternatively if anyone else has access to push to this branch (@trentm ) can you help with this? I just did Accept Combination on the merge conflict for the example package.json, and another npm install at the root.

can you help with this?

Hopefully that should do it. I pulled your earlier merge, sync'd the package-lock.json file (npm install --package-lock-only), then merged from main again (which had some conflicts), then sync'd package-lock again (not sure why this last small change). The ways of package-lock are mysterious (and not a little frightening).


Workloads menu item on Insights Advisor UX

Description
Workloads menu item on Insights Advisor UX
Fixes (partially) https://issues.redhat.com/browse/CCXDEV-11372
Type of change

New test scenario added into existing feature file
Configuration update

Testing steps
N/A
Checklist

[ ] Pylint passes for Python sources
[ ] sources has been pre-processed by Black
[ ] updated documentation wherever necessary
[ ] new tests can be executed both locally and within docker container

/retest


[RLMRealm] Create in-memory realms in a temporary directory

Closes #2032.
\c @jpsim @bdash

Closing because this change doesn't work.


Pull request for v1.0.1 hotfix release

It looks like the order for the EE patches differs slightly from dev.  I'm not sure if that's why you were seeing issues with the tests.  It should be c0e463b first, then 7ee72fi, 7bbd882.

https://help.github.com/en/articles/why-are-my-commits-in-the-wrong-order

Abandoning hotfix


Session "Proboscus"

random bugs found when running eth-faucet in the new version

dude looks good
thanks


[BUG] Poor handling of the dot operator in math expressions

Describe the bug
When asked to produce a mathematical formula, Discord cannot correctly parse the character of the dot operator(multiplication), leading to messy and difficult to interpret output.
To Reproduce
Steps to reproduce the behaviour:

Ask GPT to produce a formula or math expression which contains multiplication. In Discord, this will be formatted as '\cdot'
See screenshot for comparison between ChatGPT Web(left) and Discord(right)

Expected behaviour
I do not believe Discord can handle the native formatting, so a way to convert it to readable symbols would be nice. I'm not fully sure what the best method for this would be for Discord's Markdown.
Screenshots

Is this fixed yet? I can look into it. Keen to make some contributions to this project

@ObiAU Hey! It hasn't been looked into yet, would be great if you can take a look! This is something I think could be solved with some sort of latex formatting system?


Takes very long to start

I'm looking to simulate S3 locally. On debian stretch amd64 (a Thinkpad X1 Gen 6 Carbon), it takes about 98s from typing
docker run -p <IP_ADDRESS>:1234:8080  ianbytchek/riak-cs

till the final output
2018-09-10 11:37:15,595 INFO success: riak-cs entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)

Until that final output, riak is not usable, and the CPU load is 100%.
In contrast, competing projects take about 0.1s to start.
If there is any compilation needed, it should be done as part of the build process, not during spin-up of the container.

This is a low-maintenance repo and was created due to lack of adequate solutions back at the time. Riak was one of the few options with S3 compatibility, it's a super-heavy and fairly complex setup with loading time being just the tip of the iceberg. If you have an alternative solution – just stick with it.


Fix for typo in SempahoreExecutor

Closes #24
Changed static methods in ExecutorTools as well as tests and README doc
Tested mvn clean install working both with OpenJDK 17.0.11 and OpenJDK 21.0.3.

thanks!


Are there any plans for an updated Pytorch version?

Hi Tang,
Are there any plans for an updated Pytorch version > 1.0?
Thanks!

Hi, I have an internal version which supports PyTorch 1.6. I will update the codes soon.

Thanks very much！
Can't wait to see.

Hi @anonymousiccv , please check the master branch for updated codes.

Hi @anonymousiccv , please check the master branch for updated codes.


Create README.md

This pull request has been made at the behest of GitHub enterprises. It will unlock a glorious achievement.


fixes startup issue on win7

when this symbol is not defined, the error occurs on win7 system

thanks for the fix

eh ;)


Investigate performance regression in recent releases

I was too late to the draw but it looks like there's been a severe degradation in scrolling and navigation performance somewhere around the 1.36.0 release. Bisection might be necessary.

I think there's a bigger problem at play regarding pagination...

Alright I think I have a handle at the situation here
The root cause of this performance degradation only I seem to have experienced is SQLite queries. I have over 500 saved posts, and that table is queried by every item shown on the screen. Since #394 was implemented, there is now another, albeit smaller table that is queried by the post to determine its "read" status. 2 database queries times 7-10 posts adds up quite quickly to introduce significant overhead during scrolling which becomes very apparent when either or both of the tables becomes large enough to be an issue.
For now I've opted to export my saved posts, wipe the app data and start anew to restore performance for my day to day use.
I don't know what the solution is, maybe indices on these tables?

Converting ClawViewModel#isPostSaved to look up in a cached List<String> significantly improved scrolling performance, doing the same to ReadPostsRepository should resolve this problem at the cost of slightly elevated memory usage.


Settings Field For Telemetry Opt-In

Feature Description
For enabling anonymous user tracking in the product we need a way for users to opt in to (and out of) tracking.
The most suitable place for this is the global settings page which is currently in the works.
Product Brief draft -- includes an opt-in in the settings page, and a message to new users in the other dashboard pages (my stories, explore templates) where the user can opt-in or dismiss.
Alternatives Considered

Additional Context
Mock:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

New opt-in checkbox on the settings page that works per-user.
There is a link to https://policies.google.com/privacy, and the URL is translatable (e.g. uses __( 'https://policies.google.com/privacy', 'web-stories' )
Field should be hidden behind enableInProgressViews flag.

Implementation Brief

The api list in get_dashboard_settings() in Dashboard.php is extended to include /wp/v2/users/me
A GET request to /wp/v2/users/me is made to retrieve the current user's opt-in status from meta.web_stories_tracking_optin
Whenever the checkbox is toggled, a POST request to /wp/v2/users/me is made to update the value of meta.web_stories_tracking_optin to true/false

See API reference for that endpoint.

@swissspidy Should I move this into Product brief/UX needed? Looking through quickly, I don't think this has been designed, but let me know if I missed something.

@BrittanyIRL @carlos-kelly @pbakaus @samitron7 @swissspidy @dvoytenko would love your reviews on the product brief, tried to keep it simple, but with an opt in throughout so that users have a chance to quickly discover the opt-in bit and opt in.
Brief

@o-fernandez - My initial feedback: adding this to the settings view is straight forward and can easily be done!
The "new user considerations" where

We prompt new users to share their data by showing them the opt-in message at the top of the dashboard pages (My Stories and Explore Templates) and giving users the option to Opt-in or Dismiss the message.

would be outside of the settings view and should be its own thing. It will also need some design love. Could we separate these two things into their own stories so that it's more manageable?
Right now, the settings page is set up to be available to users who are admin only - with the canManageSettings config being true. This brief suggests that settings should be readable to everyone, but only updatable by admin.  Either one is doable, but I wanted to bring it up so that we can get it right. The settings page has had a lot of iterations and I just don't want anything to get lost.
Before we implement opt in I think it's important that the existing settings view gets QA'd and UAT'd since it hasn't gotten a chance to go through that yet. (#4132 )

Got it, let me file a quick ticket for the banner. FYI @pbakaus @samitron7

UX for telemetry opt-in on settings and dashboard are here

Some notes/thoughts:

The wording needs to be changed for the final implementation, e.g. not using he word "anonymous".

How can the opt-in banner on the dashboard be dismissed? I don't think it should be permanent, so maybe add an X icon in the top right corner?

For the opt-in banner on the dashboard, can we add the checkbox right there? It's cumbersome having to got to the Settings page just to opt-in. We might lose lots of valuable opt-ins with this additional step
It could work like this:

Display checkbox in the banner
When checked, a toast/snackbar message appears, saying that the selection has been updated
Banner is closed (with some delay, in case the user undoes their selection)

This opt-in checkbox could also be displayed in the plugin activation message, so that we get as many users as possible to opt-in
Here's how Site Kit does it, for context:

@samitron7 WDYT?

@swissspidy - all sound feedback. I updated the banner in the dashboard to reflect the checkbox but instead of using the toast let's inline the feedback.
@oef to assist with messaging (ie use of word anonymous and do we need a ticket for a congrats banner after plugin activation?

@swissspidy - all sound feedback. I updated the banner in the dashboard to reflect the checkbox but instead of using the toast let's inline the feedback.
@OEF to assist with messaging (ie use of word anonymous and do we need a ticket for a congrats banner after plugin activation?

Connected with @samitron7 on this yesterday, she's updating.

There are about 7 of us on the assignees but I will take the development on this one.

Updates has already be completed. Let me know if you all catch anything else.

Verified in QA

On the settings screen, how do I know my selection has been saved when toggling the "Data Sharing Opt-in" checkbox? @samitron7 This is not defined in Figma.

Will close out, can do follow-up ticket for UI indicator of "saved" as needed, but I think this pattern is OK if 90%+ of the time settings successfully save without the user having to redo it. SiteKit seems to use the same pattern, though the checkbox doesn't change until the setting is fully saved, it seems.


Create a contribution guide

See also https://github.com/toxicFork/react-three-renderer/issues/35

[ ] processes / workflows
[ ] basic coding style
[ ] how to define new descriptors
[ ] how to:

[ ] build
[ ] test

🤕


Fix typo in helm documentation

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.1 please.


refactor(ofctrl): update max retry times to 100

Codecov Report

Merging #347 (b18d9ca) into main (0433246) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   63.85%   63.66%   -0.20%
==========================================
  Files          41       41
  Lines        7188     7188
==========================================
- Hits         4590     4576      -14
- Misses       2209     2221      +12
- Partials      389      391       +2

Impacted Files
Coverage Δ

pkg/controller/group/group_controller.go
69.85% <0.00%> (-2.89%)
:arrow_down:

plugin/tower/pkg/controller/policy/controller.go
82.26% <0.00%> (+0.23%)
:arrow_up:


Vagrantfile: update box to version 2.7 for VirtualBox

Use new VM image that contains all of the Docker images used for testing packaged in.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>Fixes: #2011
Use version 2.7 of developer box, which contains commonly-used Docker images for tests pre-packaged

Build time for runtime tests with / without Envoy has been reduced by 8 and 10 minutes respectively with this change.


Scale of depth in demo datasets

Hi!
I was checking the values of depth maps in the scannet dataset and I found it strange: the max value is never more than 0.04. I checked for a scale up in the dataparser but I found nothing. Is it possible to know by how much the depth is scaled down ? (if it is scaled down)
Thanks in advance

Hi, the provided depth map is predicted from omnidata model and it's up to scale. You need to use some scale-invariant loss if use it as supervision.

Ohh okay I see, that's why the depth loss is scale and shift invariant. But what I don't get is why we need to do *50 + 0.5 on the ground truth depth before giving it to the depth loss. The loss should remove those from my understanding


Fix NodeJS page-streaming method

As with https://github.com/googleapis/gax-nodejs/pull/14, callback
for page-streaming methods are ignored. So callback parameters
should be removed, and it should always return stream.
Update the comment of stream to mention per-page streaming feature.
Transfer the 'end' event. So it can finish repeating API calls
when the user wants to end the stream.

LGTM


Adding dynamicvoronoi to documentation index for distro

Please add dynamicvoronoi to documentation index for distro

actually, sorry: could you please call it dynamic_voronoi ? Thx

Yes, I can. But I want to publish catkinized version of http://wiki.ros.org/dynamicvoronoi which I use in another package. Could I do it?

ah ok, it already exists, sorry. Please re-open a pull request. My bad


Raj/bad pv/trim dates

Pull Request
Description
An incoming xarray dataset contains time_utc coordinate values with contiguous time intervals. The type of time_utc coordinate intervals can be 5min or 15minor 30min. The trim dates function takes in xarray dataset and trims the time_utc coordinate values to the 12th hour only if the total number of time_utc values is greater than the given intervals
Fixes #
How Has This Been Tested?
This function has been tested with passiv_datapipe, pvoutput_datpipe, and a constructed xarray data array. The constructed xarray has three different time_utc ranges with different configurations. The function trims the dates to the 12th hour and does not do anything if time_utc values are not sufficient.

[ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

Codecov Report

Merging #130 (669bddb) into main (427b8ee) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   80.76%   80.88%   +0.12%
==========================================
  Files         111      112       +1
  Lines        4356     4385      +29
==========================================
+ Hits         3518     3547      +29
  Misses        838      838

Impacted Files
Coverage Δ

ocf_datapipes/select/__init__.py
100.00% <100.00%> (ø)

...tapipes/select/trim_dates_with_insufficent_data.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Clustering and early stopping

Adding clustering option to the MAF script as described in arXiv:2305.02930. Clustering can be turned on by setting clustering=True or cluster_number=<int> when initialising the MAF function.

[ ] Need to add in tests
[x] Run flake8
[x] Add documentation
[x] Larger range of allowed cluster number
[ ] Bump version number to 0.5.0
[ ] Add a tutorial on how to use the clustering code

Also added early stopping as per the description in Chapter 4 in "Hands-on Machine Learning with Scikit-Learn, Keras & TensorFlow".

Encountering some issues with test_stats.py when running on GitHub actions that do not happen locally. Intending to simplify the test example by generating samples with np.random.normal (doing something similar in test_clusters.py) rather than using samples from polychord.
Also encountering issues when testing the statistic calculations in test_clusters.py but will have to come back to this.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1617a57). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   88.76%
=========================================
  Files             ?        4
  Lines             ?      454
  Branches          ?        0
=========================================
  Hits              ?      403
  Misses            ?       51
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


K8SPS-54 update go version to 1.18

Test name
Status

config
passed

init-deploy
passed

monitoring
failed

semi-sync
passed

service-per-pod
passed

scaling
passed

sidecars
passed

users
passed

demand-backup
passed

We run 9 out of 9

commit: https://github.com/percona/percona-server-mysql-operator/pull/93/commits/60908d3fea5a5d57e6d9c06b66b65e12f66445fc
image: perconalab/percona-server-mysql-operator:PR-93-60908d3


fixed iPhone and iPad

Apple mobiles don't have event.touches prop when touch event ends, so plugin was crashing.
event.changedTouches are much more reliable!
Tested for web, android, iPhone and iPad. I was using a fork with similar fix in production for quite a while.

@Fuzzyma thanks for merging! Could you please update it on bower?

at work atm. Will do it at home


Update build.yml to sync with latest bart version being used

Signed-off-by: tpmccallum<EMAIL_ADDRESS>We recently updated to Bartholomew 0.8.0 and removed the common folder etc. This PR is to just update/sync the version of Bart in the GH workflows with what is being used in the developer site's module section.

Closes https://github.com/fermyon/developer/issues/410

Just FYI, this is the only Bartholomew version that requires updating:
developer % grep -rl "v0.7.0"
./.github/workflows/build.yml


NPE when using sampler's HeaderManager in a loop

Expected behavior
Using sampler.getHeaderManager() in a JSR223 PreProcessor attached to a HTTP Sampler returns current manager.
When using this in a loop it should work.
Actual behavior
Using this in a Loop controller leads to retrieving a null manager from sampler upon 2nd iteration:
2023-08-17 21:29:16,832 INFO o.a.j.m.J.JSR223 PreProcessor: sampler=class org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy
2023-08-17 21:29:16,832 INFO o.a.j.m.J.JSR223 PreProcessor: headerManager=org.apache.jmeter.protocol.http.control.HeaderManager@6e58c5cf
2023-08-17 21:29:16,851 INFO o.a.j.p.h.s.HTTPHC4Impl: HTTP request retry count = 0
2023-08-17 21:29:16,950 INFO o.a.j.m.J.JSR223 PreProcessor: sampler=class org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy
2023-08-17 21:29:16,950 INFO o.a.j.m.J.JSR223 PreProcessor: headerManager=null

Steps to reproduce the problem
Attached sample JMX to prove the point.
jmeter_loop_http_header_manager.zip
JMeter Version
5.6.2
Java Version
Oracle JDK 11.0.17+10-LTS-269
OS Version
Windows 11

@KingRabbid , the issue is caused by headerManager.clear() in the preprocessor.
Currently, TestElement.clear() clears all the data, including "system" properties like "test_class", "gui_class", "name", and so on. I believe it causes the failure.
If you want to clear the headers instead, you might try headerManager.getHeaders().clear().
However, I would suggest to refrain from modifying the headers dynamically, and use variables instead.


GetTrigger() and Filter()? (Dummy FAQ - Please contribute)

Why do I have to do this and that?
The main intent of X is to do Y. If you do Z then 😢  That's why it's recommended to do this, because then 😆
Example
(using a ```csharp code block)

public sealed class Xyz {

    // Will do this, that's why.
    public void Abc() {
    }
}

This is a dummy faq issue, see #333
This will appear in the FAQ project
https://github.com/sschmid/Entitas-CSharp/projects

Yeah, a proper FAQ probably makes more sense. Waiting for the forum. Will close


ci: add dependency tree to step summary of optional-dependencies job

Description
Promise: This is my last PR to dev-2.1.0.
This PR proposes to add a new step summary to the optional-dependencies job.
The summary makes use of pipdeptree to show to installed python packages and their transitive dependencies. This way we can make sure, that packaging  for example is installed and see where it comes from.
What do you think?
See the summary in: https://github.com/rdmorganiser/rdmo/actions/runs/7104483723
Types of Changes

[x] Other (please describe): CI

Checklist

[x] I have read the contributor guide.
[x] My code follows the code style of this project.
[x] All new and existing tests passed.

Very nice, especially "Outdated dependencies". We could add pipdeptree to the dev dependencies, btw., along with build and twine.

Should I add those to the dev group in this PR then?
Outdated dependencies were already reported, but hidden in the logs.
See e.g. here: https://github.com/rdmorganiser/rdmo/actions/runs/7104146786/job/19338462519
This PR makes it more visible.

Yes, just add it here and merge. Thanks!

All done, merging now.


Update Curation Concerns

Uses CC's nested works.
Closes #657

Coverage remained the same at 100.0% when pulling 191144f4c2046e490785ffa0acd5a19058b74fe7 on update_cc into 350962341a10cf55ba6c69a3ea5ee0906d81576d on master.


Update README with koa body parser dependency

small docs change, might help other users realize what dependencies there are

@matteodem thanks!


h5p pack h5p-ndla-timeline misses the dist files

On my local dev drupal 7 set up I fail to pack h5p-ndla-timeline correctly. I do h5p pack h5p-ndla-timeline h5p-ndla-timeline.h5p -r (using the -r parameter to add the dependencies).
In the resulting h5p-ndla-timeline.h5p archive there is no sign of the dist folder. Which means installing this library to another environment results in this Error message
The file "dist/bundle.js" is missing from library: "H5P.NDLATimeline-0.0"
The file "dist/bundle.css" is missing from library: "H5P.NDLATimeline-0.0"
The uploaded file was not a valid h5p package
Note.-
Given all the various issues with h5p-ndla-timeline that I have come across when trying to use it recently I wonder if this library has actually been tested on the various platforms where H5P libraries can be installed, e.g. WP, Moodle, Drupal... That's a pity because it has some useful elements which are missing from the current h5p timeline library. Or am I missingn some important information?

@rezeau I just tried, but I don't see any problem. The distribution files get built just fine when running npm run build. Have you forgot to build the distribution files maybe?
Furthermore, there's no need to test an H5P content type on all kinds of platforms (unless you do a handful of special things), because content types are running on an abstraction layer.

@otacke "The distribution files get built just fine when running npm run build." Yes, they do, but that's not the problem. The problem I have is that, once I've run npm run build the h5p pack h5p-ndla-timeline h5p-ndla-timeline.h5p command does not insert the dist folder in the packed library. I hope I make myself clear. Have you tried to pack?


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1861

Questions ?
Please refer to the Backport tool documentation


Set backgroundColor Transparent for webview_flutter.

Hi, is it possible to set the backgroundColor of the webview window to be transparent? Thanks

cc @amirh

Is there a workaround for this issue?
To get a transparent background without your changes?

@insinfo I had to use https://pub.dev/packages/flutter_webview_plugin. The problem with this one is that it's making a layer on top of your flutter app instead of being inside.
This might help: https://github.com/fluttercommunity/flutter_webview_plugin/issues/113

This bug exists and is tracked here #29300 . There have a discussion about this and possible solutions.
Please close this problem if it is duplicated.
@mlanteigne @amirh

Closing as a duplicate.


Path problems

Dear all,
We (with @agricolamz) discovered a problem with paths on Windows. The notion of upper level with two dots seems not to work on Windows. I currently use Windows 10 and Praat version  6.1.32.
Recently we tried to extract formants using a Textgrid and an audio (around 10 minutes length) and got the following error message:

Hi, it definitely works on Windows, I wrote it in Windows. In general, the functions work without issues as of right now. Its hard for me to tell why you got that error. Is it possible that the file is open somewhere or something like that?

Hi, it definitely works on Windows, I wrote it in Windows! Its usually the only operating system that I am confident things work in. In general, the functions work without issues as of right now. Its hard for me to tell why you got that error. Is it possible that the file is open somewhere or something like that?

Were you able to resolve the issue? Can I close this?

Were you able to resolve the issue? Can I close this?

Thank you for your answer!
No we didn't, we will check it this week.

Thank you for your answer!
No we didn't, we will check it this week.

Dear Santiago, we solved our problems thank you for FastTrack!

Dear Santiago, we solved our problems thank you for FastTrack!

I'm glad you found it useful!

I'm glad you found it useful!

I saw this issue, and upgrading Praat fixed it.


404 Error when loading Fonts

Hi.
looks like the site's fonts are not loading properly. Error 404 can be seen in the network tab of the browser...

Ctrl + f5 does not solve the problem
Tracker Protection of firefox has no effect on this
There is also a problem in Chromium-based browsers.

anyone know what the problem is?

problem solved. I don't know how but anyway


Condition alias duplicates

Describe the bug
When editing an experiment with condition aliases, sometimes duplicate condition aliases will get created with different ids, resulting into multiple copies of condition aliases inserted into database and also therefore attached to the experiment object.
To Reproduce
Not exactly known yet, will put steps when I can make it happen.
Expected behavior
This should not happen, but also some extra validation on front and/or backend to ensure that experiment object isn't malformed when being created or modified (like for instance, a count of condition aliases would ensure that only the expected number are sent).
Both simple and factorial should be checked.

@danoswaltCL since we closed this, can we move it to "Done" rather than "QA"? Or is this something we still want to look into? I don't see attached pull requests or related commits in the commit history

yeah this is just done

This is potentially happening again, or something like it. Will look into this.

@danoswaltCL can you provide more details on this, I have tried to look into it but not able to recreate it. let me know if you have specific scenario when this issue was coming.

@Yagnik56 I recreated this by creating a new experiment in staging with payloads and exporting the json. Them I imported the experiment in production. The import removed all the payload values (issue #1074) and also duplicated the existing (incorrect) values. Here's an example json from one such created experiment -- it has 6 payload values where there should be only 3.
test payloads.json

will it be possible for you to share video of same, I tried myself but not able recreate same following the way you suggested.

Did you delete the experiment before importing that, I am not able to see wrong value added in payload but not able to see duplicate values. Also I think this issue might be resolved when we resolve issue #1074. I will look into it deeper but I think this PR will fix this issue as well.

Yes, I deleted the experiment before re-importing. Note that the duplication doesn't happen in the UI, only the raw json. @danoswaltCL do you have any additional detail to add?

Here's what we saw -- the error appears to be in the conditions array

@zackcl I need to test this.

I can confirm that this issue has been resolved; I have not observed any duplicated payload values.
    "conditions": [
        {
            "createdAt": "2023-11-07T13:38:24.876Z",
            "updatedAt": "2023-11-07T13:38:24.876Z",
            "versionNumber": 1,
            "id": "f7e5cb8d-b644-4c58-973f-f9074840eede",
            "twoCharacterId": "VQ",
            "name": "",
            "description": null,
            "conditionCode": "variant",
            "assignmentWeight": 50,
            "order": 2,
            "conditionPayloads": [
                {
                    "createdAt": "2023-11-07T13:38:24.876Z",
                    "updatedAt": "2023-11-07T13:38:24.876Z",
                    "versionNumber": 1,
                    "id": "757794ff-1108-4895-8c1f-337ce91d9631",
                    "payloadValue": "my_alias2",
                    "payloadType": "string"
                }
            ],
            "levelCombinationElements": []
        },
        {
            "createdAt": "2023-11-07T13:38:24.876Z",
            "updatedAt": "2023-11-07T13:38:24.876Z",
            "versionNumber": 1,
            "id": "1e6de8a1-86ab-4a26-aa0a-b1c1296d79a5",
            "twoCharacterId": "V6",
            "name": "",
            "description": null,
            "conditionCode": "control",
            "assignmentWeight": 50,
            "order": 1,
            "conditionPayloads": [
                {
                    "createdAt": "2023-11-07T13:38:24.876Z",
                    "updatedAt": "2023-11-07T13:38:24.876Z",
                    "versionNumber": 1,
                    "id": "2c4b36d1-f0bd-45ad-85dc-426b60a83b93",
                    "payloadValue": "my_alias1",
                    "payloadType": "string"
                }
            ],
            "levelCombinationElements": []
        }
    ],

Here are the exported JSON experiment files from the dev branch:
Simple:
alias-duplicate-test.json
Factorial:
fact_alias_test.json

QA Check Completed: All tests have passed successfully.


Suggestion. Make it one liner.

Instead of
if (param == null)
{
     throw new ArgumentNullException(nameof(param));
}

I like this better:
if (param == null) throw new ArgumentNullException(nameof(param));

I don't think braces are necessary here, but this is not the correct way to make a single-line validation. If you want validation without a control flow block in code, use a helper method. This form is not only shorter than a single-line conditionally-thrown exception, but it is also much easier to read.
Requires.NotNull(param, nameof(param));


DOC: replace example for "np.select" with the one from numpy docstring

Current one is a confusing one, since 0 is the choice for x>3 condition
which is never satisfied, but also it is what np.select has as a default
value.  I think that numpy has a reasonably good example, so why not to use it?

Makes sense, thanks @yarikoptic


What should I do if I need to extend ArrayAdapter instead of BaseAdapter

so that you can put what every Object at place of . Java Generics :+1:


Home - Target List - Sort by

In section Target List, in Home page, option Sort by will display a menu with the following options:

Name
Last added

Each option will have the sort functionality in place

Working as expected


Getting 408 Request Timeout error frequently.

Please provide a simple reproducible example (with all 3rd party packages omitted).


Battery Low Warning never really shows up

I've always had issues with the Low battery warning showing up, unless its set way high, e.g. 3.6 volts or so.
Would it be possible to have the battery warning based off the filtered voltage, rather than the 'fuel tank voltage'

i guess the underlying issue is that the fuel gauge value is not very useful as it is right now in general.
i will have a dig if there is anything wrong with its implementation.
If there is, let's give the fixed version another chance.
If there is not, i guess we might as well drop it all together.

Would it be possible to add option in configuration to use filtered voltage instead of fuel gauge voltage ? It's a good idea but some of mine batteries don't show warning even if it's set to 3.7V and I loose video before I see warning.  It worked quite well for new tattu batteries.

The same issue.
Happymodel SuperX HD 1S (F411).

The same issue. Happymodel Diamond F4. At the beginning I set to 3.3, then 3.5 (default), now 3.7 and even close to 3.0 does not show anything... unless I disarm.

switch landed in https://github.com/BossHobby/QUICKSILVER/releases/tag/v0.11.0-rc2


Spin session on empty wait

Related: https://github.com/eProsima/Micro-XRCE-DDS-Client/pull/316

Codecov Report

:exclamation: No coverage uploaded for pull request base (galactic@51942f6). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head e308776 differs from pull request most recent head 16c2c15. Consider uploading reports for the commit 16c2c15 to get more accurate results

@@             Coverage Diff             @@
##             galactic     #233   +/-   ##
===========================================
  Coverage            ?   50.08%
===========================================
  Files               ?       43
  Lines               ?     1687
  Branches            ?      480
===========================================
  Hits                ?      845
  Misses              ?      619
  Partials            ?      223

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51942f6...16c2c15. Read the comment docs.

@mergify backport main foxy


Support GraalVM Reachability Metadata to Simplify Native Compilation

Describe the feature
Please see https://github.com/oracle/graalvm-reachability-metadata
The Vert.x project could submit the metadata required for all Vert.x projects to build out of the box with GraalVM, no reflection config required per https://how-to.vertx.io/graal-native-image-howto/.
Use cases
GraalVM Native Image compilation.
Contribution
Vert.x team.

java11 binary also has the same problem


A way to specify getter/setter logic.

It'd be nice to have a way to implement custom prop handling. I do this in my non-Skate elements with custom getters/setters. It's not possible with Skate because Skate defines the getters/setters.
Problem:
There's the coerce API, but that is limited because this can not be accessed inside the coerce function to work with the instance that is receiving a property value.
example of solution in a non-SkateJS way:
First, let me explain what these custom elements of mine do. In those elements, I'm using attributeChangedCallback directly and manually creating accessors so that I can do the following:
el.rotation = {x:30, z:45}

What this actually does behind the scenes is takes those values, and applies them to a private object that has event listeners and other useful features that I want to preserve across setter invocations. F.e. a simple summary implementation of the above rotation setter may look like this:
set rotation(val) {
  if (typeof val.x != 'undefined') this._rotation.x = val.x
  if (typeof val.y != 'undefined') this._rotation.y = val.y
  if (typeof val.z != 'undefined') this._rotation.z = val.z
  // Updating `this._rotation.x` causes an event to be fired, etc.
}

I do the same thing when processing attributes (f.e. serialize into an object, then set values with the setters).
It'd be great to have a way to achieve this with a SkateJS-based components, but due to the fact that SkateJS defines the setters/getters, there isn't a non-monkey-patch way to do it.
A solution?
Maybe there can be some way to configure the setup of the props cache, as well as defining get/set behavior somehow. I'm not really sure what the API would be like, but in the end, I'd like to do as little as possible just like how currently we can define attributes that map to properties without having to wire it up.
Even in the latest v6-branch API (at time of writing this), the call to propertyFunc(newValue) doesn't seem to provide a way to work with this, but maybe it doesn't really make sense to work with it there.
Maybe, we need a way to define where values get saved to. Right now (v6), values get saved to Symbols (seems cool) by default, and maybe that's a good default. Maybe there can be some way to configure this?
It's hard to imagine a generic and clean solution...

Why not just set the prop: rotation: props.object, and then override the setter set rotation(obj) and do your thing there?

Why not just set the prop: rotation: props.object, and then override the setter set rotation(obj) and do your thing there?

It also doesn't seem possible to do it inside a class definition because the SkateJS observedAttribute static getter will run after the class has already been defined when passed to customElements.define, so it will override the user's defined getters/setters.
Plus, the overriding developer would have to make sure to patch the SkateJS functionality back in, which is hacky.
Maybe, conversely, SkateJS can patch the end-developer's getters/setters in, so
idea
After thinking about the Symbols functionality, maybe it can be used to allow getters/setters to be defined for props.
This would be advantageous because this inside the getters/setters would be the instance of the class, unlike if getters/setters were placed into a _props sub-object.
The functionality that we'd be taking advantage of is this (try it in console):
var f = Symbol('f')
var o = {
  get [f](){ return this._val },
  set [f](val) { this._val = val },
}
o[f] = 5
o[f] // 5

Possible API
It could possibly look like follows, with the advantage being that the getters/setters generated by SkateJS would still be able to do their thing:
class MyEl extends WithUpdate(HTMLElement) {
    static get props() {
        return {
            rotation: {
                ...props.object,
                get: function() {
                    return this._val
                },
                set(val) {
                    this._val = val
                }
            }
        }
    }
}

implementation idea 1
The relevant part of with-update.js would look like this:
    Object.defineProperty(constructor.prototype, name, {
      configurable: true,
      get() {
        const val = normalised.get.call(this); // <--- RIGHT HERE
        return val == null ? normalised.default : val;
      },
      set(val) {
        const { attribute: { target }, serialize } = normalised;
        if (target) {
          const serializedVal = serialize ? serialize(val) : val;
          if (serializedVal == null) {
            this.removeAttribute(target);
          } else {
            this.setAttribute(target, serializedVal);
          }
        }
        normalised.set.call(this, normalised.coerce(val)); // <--- AND HERE
        this.triggerUpdate();
      }
    });
  };

A downside to this is that getters/setters would be defined inside the static props getter, which isn't as clean and semantic as defining them inside the class.
implementation idea 2
Maybe the defineProps(this) call could first scan the class prototype, save the class' defined getters/setters, and then do the same thing as above (somewhat like a decorator would modify a class).
I tested to be sure, and super works as expected:
{
class Bar {
 get foo() {return this._foo}
}
class Foo extends Bar {
 get foo() {return super.foo}
 set foo(v) {this._foo = v}
}

const { get:getFoo, set:setFoo } = Object.getOwnPropertyDescriptor(Foo.prototype, 'foo')

Object.defineProperty(Foo.prototype, 'foo', {
 configurable: true,
 get() {
  console.log('get foo')
  return getFoo.call(this)
 },
 set(v) {
  console.log('set foo')
  setFoo.call(this, v)
 }
})

const foo = new Foo

foo.foo = 5 // outputs "set foo"
foo.foo // outputs "get foo"
}

Implementation idea 2 is better, because super doesn't work in idea 1 and requires pre-ES6 verbosity to make super-like functionality.

normalised.set can default to setting this._props[name] = val in the default case, and similar with get.

Example usage of implementation idea 2:
import { props } from 'skatejs'

class MyEl extends withUpdate(HTMLElement) {
  static props = {
    rotation: props.object,
  }

  get rotation() { /* ... custom getter logic, then wrapped by SkateJS ... */ }
  set rotation(val) { /* ... custom setter logic, then wrapped by SkateJS ... */ }
}

Otherwise, if the user leaves out the getter/setter,
import { props } from 'skatejs'

class MyEl extends withUpdate(HTMLElement) {
  static props = {
    rotation: props.object,
  }
}

then SkateJS can normalize to using this._props like before.

Option 2 is an interesting idea. Similar to what you've done, you can basically do this internally:
Object.defineProperty(proto, propName, {
  configurable: true,
  ...propDefinition,
  ...Object.getOwnPropertyDescriptor(proto, propName)
})

Similar to what you've done, you can basically do this internally

Yes, but that doesn't let Skate be able to do custom things during get/set, which is what I was trying to preserve. F.e. Skate was removing an attribute if it found the value to be null.

Yes, but that doesn't let Skate be able to do custom things during get/set, which is what I was trying to preserve. F.e. Skate was removing an attribute if it found the value to be null.

Wouldn't ...Object.getOwnPropertyDescriptor(proto, propName) do that? Maybe I missed something.

That will override the get/set definitions that are defined in ...propDefinition right? So those ones defined by Skate will not do anything special because they are replaced by the user's.

Yeah, I think that's the idea. Unless it's replaced with null or something, then that'd be unwanted. There'd have to be an order of precedence no matter what.

Yeah, I think that's the idea.

But it will break how SkateJS works. Anywho, I think the use case for this is basically covered by the PR I linked in #1493.
I experimented with implementing this, but I found it to be redundant when paired with the changes in https://github.com/skatejs/skatejs/pull/1509, which allows me to cover the use case.
Basically, coerce is called in the same place we'd call a set function, which I found to be redundant if coerce can already access this. The withUpdate getter will already be able to return the cache location that is used in coerce as I've shown in #1509.

Just for posterity, v6-trey now has a changed callback (does not change the value, but is called post change). This should be able to satisfy this use case.

I would love to try our the new get/set, etc, but at the moment I can't because I am heavily relying on withUpdate being a mixin with no DOM APIs.

I'm using withUpdate on both Custom Elements as well as non-DOM objects.

Can you open a separate issue to discuss this specifically? It's definitely not meant to be used this way.


Trigger Pipeline script throws error - when you Input "STAGE" parameter

Describe the issue
Trigger Pipeline script throws an error - when you Input "STAGE" parameter.
To Reproduce
Steps to reproduce the behavior:
Goto - https://github.com/maikvandergaag/msft-extensions/blob/main/azuredevops/triggerpipeline-new/triggerpipeline/run-release.ps1
Input -   [Parameter(Mandatory = $false)][String]$Stage = "DEV" ,
And run the script, and it throws - ConvertFrom-Json : Invalid JSON primitive: Page.
The Input -      [Parameter(Mandatory = $false)][String]$Stage, -- works with no issues by triggering to a default stage.
Thanks,

Could you share the logs?

Hey Maik,
Its pretty simple - Just add a specific stage to "trigger release pipeline" script - like below
[CmdletBinding()]
Param (
[String]$OrganizationUrl ="https://dev.azure.com/xyz",
[String]$ReleaseUrl = "https://vsrm.dev.azure.com/xyz",
[String]$AzureDevOpsProjectName = "Agile-Test",
[String]$DevOpsPAT = "Key",
[Parameter(Mandatory = $false)][Bool]$UseSystemAccessToken,
[String]$PipelineName = "CT",
[Parameter(Mandatory = $false)][String]$BuildNumber,
[Parameter(Mandatory = $false)][String]$Stage = "DEV",
[Parameter(Mandatory = $false)][String]$Description = "Automatically triggered release"
)
Errors out --

With out stage - it works fine,
[CmdletBinding()]
Param (
[String]$OrganizationUrl ="https://dev.azure.com/xyz",
[String]$ReleaseUrl = "https://vsrm.dev.azure.com/xyz",
[String]$AzureDevOpsProjectName = "Agile-Test",
[String]$DevOpsPAT = "Key",
[Parameter(Mandatory = $false)][Bool]$UseSystemAccessToken,
[String]$PipelineName = "CT",
[Parameter(Mandatory = $false)][String]$BuildNumber,
[Parameter(Mandatory = $false)][String]$Stage,
[Parameter(Mandatory = $false)][String]$Description = "Automatically triggered release"
)
Maybe, have to look if the stage is getting rightly filtered out. ??

@ab1234567 : I get your point. But to really see the issue you should be able to share the logs. I have looked into my demo environment and my test case still works.
The additional info would be helpful to check your case. Could you share the below info:

Logs with the variable system.debug set to true.
Image of your release
Can you start that specific stage by using the UI?

@maikvandergaag  Sorry for not getting back to you on this. To replicate this issue in the UI.
Assume that your target stage has 2 Stages - DEV & QA with no pre-approvals
And on the source pipeline - in the stages section input - "QA" (only) and trigger the source pipeline. And the problem is -
IT QUEUES - BOTH DEV & QA STAGES.
Is it working in your scenario?

doesn't work for me alse

Please share more info


Remove TraceContext.shared()

In hindsight TraceContext.shared() does not actually need to be in the TraceContext. Shared is only set in Tracer.joinSpan, so could be recorded then and there. It isn't propagated across hops, so doesn't make sense to be in the propagation context.

+1


operator-sdk: 1.37.0 -> 1.38.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/operator-framework/operator-sdk/releases.
meta.description for operator-sdk is: SDK for building Kubernetes applications. Provides high level APIs, useful abstractions, and project scaffolding
meta.homepage for operator-sdk is: https://github.com/operator-framework/operator-sdk
meta.changelog for operator-sdk is: https://github.com/operator-framework/operator-sdk/releases/tag/v1.38.0
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.38.0 in filename of file in /nix/store/swnbxpjjqam6g41jrp56k5yy52kl4bda-operator-sdk-1.38.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

operator-sdk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/swnbxpjjqam6g41jrp56k5yy52kl4bda-operator-sdk-1.38.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A operator-sdk https://github.com/r-ryantm/nixpkgs/archive/7eac7962100ea534cf13211c6ba302542f596034.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7eac7962100ea534cf13211c6ba302542f596034#operator-sdk

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/swnbxpjjqam6g41jrp56k5yy52kl4bda-operator-sdk-1.38.0
ls -la /nix/store/swnbxpjjqam6g41jrp56k5yy52kl4bda-operator-sdk-1.38.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

operator-sdk

Maintainer pings
cc @arnarg for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 357679 run on aarch64-darwin 1

1 package built:

operator-sdk


Flaky test: c8y_mapper_ext  custom_operation_timeout_sigkill

The test  custom_operation_timeout_sigkill is flaky (see here where the second attempt is green).
This is not a timing issue, which is concerning.

Would the check be too impatient (i.e. expecting an outcome before the mapper triggers a sigkill), the error would be panicked at 'Channel closed while expecting: ...
Actually, the test is failing with an assertion failure: i.e. another unexpected message has been received.

Fixed by https://github.com/thin-edge/thin-edge.io/commit/6d6c38dbf891de2c830d1c772b5cd3d26e21561d


validation=True failing with HTTP 500 and "no data to validate"

validation=True parameter does not seem to work properly.

These lines are to blame:
https://github.com/rochacbruno/flasgger/blob/0ee67a755121000dad5b4405f2dd2bcb50c8ad51/flasgger/utils.py#L294-L295
For example, I have empty list as a data. That's valid data in my case, but validate function fails with error 500.

Submitted PR: https://github.com/flasgger/flasgger/pull/328


Objective evaluation

F0 RMSE
MCD or LSD

It would be great if we have objective evaluations in our recipes. In particular, F0 RMSE will be very useful to check the F0 modeling accuracy.

Done

https://r9y9.github.io/nnsvs/tips.html#monitoring-traing-progress-via-tensorboard


Can't get this to return anything but undefined

I've been trying to follow your example. IO will always return undefined. Can you tell me if I'm doing something wrong?
The code is pretty short:
var _session = require('express-session');
var FileStore = require('session-file-store')(_session);
var session = _session({
	store : new FileStore({path: __dirname+'/tmp/sessions'}),
	secret: 'cvavqaiowwaodwa96969vAW9ac8wua9c8w7a',
	resave: true,
	saveUninitialized: true
});

// creating new express app
var app = require('express')();
app.set('views', __dirname);
app.set('view engine', 'jade');
app.use(session);

// Creates a session and sets the UID to 1
app.get('/login', function (req, res){
  req.session.uid = 1;
  console.log("UID set");
  res.send("Session created: "+req.session.uid);
});
// Outputs session ID
app.get('/', function (req, res) {
	console.log("Session ID:", req.session.uid);
});

// Start server
var server = require('http').createServer(app);
server.listen(3000, function(){
	"Server online!"
});

// IO
var ios = require('socket.io-express-session');
var io = require('socket.io')(server);
io.use(ios(session));
io.on('connection', function(socket){
	// Log the session UID, always returns undefined
	console.log("Session id: " + socket.handshake.session.uid);
	// Try to set it from socket io, doesn't matter, it's not saved
	socket.handshake.session.uid = 1;
});

Versions:

Express: 4.13.14
Node: 5.9.1
Socket.io 1.4.5
socket.io-express-session 0.1.3

Ok I think I've found the issue, basically if you're proxying connections to node (which I assume is the standard practice), it will not work unless the client supplies IO with with the port such as var socket = io("http://domain.com:8080");
I'll do some more testing to verify that it's resolved.

It's this package issue. I guess you are fighting against crossdomain policy or similar.


When two monitors are used, page.window_center () is displayed in the wrong position

Description

I have two monitors in use, and the resolution of the two monitors is not the same, the left is 2560x1440, the right is 1920x1080, page.window_center () is displayed in the wrong position, it is displayed on the right side of the monitor, but only the left side of the program window is displayed
Code example to reproduce the issue:
# -*- coding: utf-8 -*-

import flet as ft

def main(page: ft.Page):
    page.add(ft.Text('hello'))
    page.window_center()
    page.update()

if __name__ == "__main__":
    ft.app(target=main)

Describe the results you received:

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):
Flet version (pip show flet):
Name: flet
Version: 0.18.0
Summary: Flet for Python - easily build interactive multi-platform apps in Python
Home-page:
Author: Appveyor Systems Inc.
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Location: C:\Python311\venv311\Lib\site-packages
Requires: cookiecutter, flet-runtime, packaging, qrcode, watchdog, websocket-client, websockets
Required-by:

Operating system:

windows 11
Additional environment details:
attention: the resolution of the two monitors is not the same, the left is 2560x1440, the right is 1920x1080

I tried this on my setup and it works normally. I have two screens with different resolutions.
Nevertheless, I havent found any opened or closed issue on the window_manager repo (used by flet).

me too. @vrix

I have two screens with different resolutions, but the window_center() works normally. The window is centered with respect to the currently active/used screen. Nevertheless, I havent found any opened or closed issue on the window_manager repo used by flet. - we should perhaps open one?

Maybe you are running on the main monitor, try running on another monitor.