Use a more robust logging solution

I am not aware of the infrastructure that runs, but to me it seems that a more robust logging solution, i.e. log4net or NLog would be a nice to have feature for the engine.
Any thoughts?

That would be great; perhaps to kick it off you could implement a log4net/nlog which matches the ILogHandler and submit it? @bdilber defined this interface so people could add their own logging systems: https://github.com/QuantConnect/Lean/blob/master/Logging/ILogHandler.cs

In the meantime, I have added
public class FileLogHandler : ILogHandler
which creates a log file in the  Assembly.GetExecutingAssembly().Location directory.
the algo replaces the ConsoleLogHandler when it starts with
QuantConnect.Logging.Log.LogHandler = (ILogHandler)new FileLogHandler();
a few messages still show up in the Console.  I can get you the source if you like.
Nick

The FileLogHandler has already been committed. See
https://github.com/QuantConnect/Lean/blob/master/Logging/FileLogHandler.cs
-Michael
On Mon, Apr 6, 2015 at 8:44 PM, Nicholas Stein<EMAIL_ADDRESS>wrote:

In the meantime, I have added
public class FileLogHandler : ILogHandler
which creates a log file in the Assembly.GetExecutingAssembly().Location
directory.
the algo replaces the ConsoleLogHandler when it starts with
QuantConnect.Logging.Log.LogHandler = (ILogHandler)new FileLogHandler();
a few messages still show up in the Console. I can get you the source if
you like.
Nick
—
Reply to this email directly or view it on GitHub
https://github.com/QuantConnect/Lean/issues/54#issuecomment-90298518.

Awesome Michael.  I am upgrading to the latest source now..  Your implementation is very similar to mine. I wish there was a way to have both logging to the console and to a file.  It would be convenient for capturing intermediate variables within an algo.
Nick

Great idea Nick!  I was actually implementing this today.  See ba9f2b4 just
pushed to master.
-Michael
On Tue, Apr 7, 2015 at 2:11 PM, Nicholas Stein<EMAIL_ADDRESS>wrote:

Awesome Michael. I am upgrading to the latest source now.. Your
implementation is very similar to mine. I wish there was a way to have both
logging to the console and to a file. It would be convenient for capturing
intermediate variables within an algo.
Nick
—
Reply to this email directly or view it on GitHub
https://github.com/QuantConnect/Lean/issues/54#issuecomment-90683680.


groq-builder Make slice(0) nullable by default

Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Feature Request
Since we are not really reading validation on "min" for arrays, doing slice(0) should always infer to be nullable.

Also with document queries, i.e:

`const pageQuery = q.star.filterByType("page").filter("slug.current == $slug").slice(0)`

groq will return null if the document doesn't exist. I feel like this should be the default.

We can add .nullable() but I think it is more correct to make it default nullable in this scenario and perhaps add a .nonNullable() if necessary.

This is a great point.   I like the idea of adding a .notNull() assertion too!


Enhancing UI Responsiveness - Hero Section of the Landing Page

Hi Team,
I would like to work on the responsiveness of the hero section.
It is not well aligned on smaller devices.
Kindly check the screenshot

Level will be given based on the work. Please go ahead.

@aslams2020 The whole website is not responsive can you assign me so that I can make this whole website responsive?
like

Already resolved and merged


IDependencyResolver.GetServices() implementation improperly returns null when no services of the type have been registered

The IDependencyResolver implementation in the MVC project for GetServices simply calls GetService passing in the IEnumerable<> closed over the initial requested service type.  However, it appears that Microsoft dependency injection returns null for this case when no individual services of the given type have been registered.  This differs from the default IDependencyResolver implementation, which returns null for GetService, and an Enumerable.Empty<object>() for GetServices.  This becomes an issue within the MVC infrastructure, as it assumes it is always safe to enumerate the value returned from IDependencyResolver.GetServices.  I believe this can easily be remedied by returning Enumerable.Empty<object>, or even new object[0] when the inner call to GetService returns null.
If I have time later this week, I will submit a pull request.

Upon looking further into this, I see this is a duplicate of #17, and there is already a pull request open.


Changed JSON-LD format

The wiki page (https://github.com/clulab/eidos/wiki/JSON-LD) has been updated to show the format of the current master branch as of the merge of pull request #295.  Changes are highlighted and relate to support of multiple groundings.  This issue is so that @adarshp and @bgyori are sure to know about it and have a place to comment.  There are lots of other changes in the pipeline pending discussions with BBN.  If there are too many or they are too fast, maybe we'll have an internal format where you determine the adoption rate.

I'm hoping that most of these changes are transparent to you, but probably not.  The document text is now included and documentCharPositions is part of the provenance.  Positions in provenance are arrays.  They were supposed to have been before.  If any of this looks temporarily problematic, I can comment out code.

I may get the attachment/state provenance added, but that may be the limit.  The bigger changes (e.g., merge of Entity, DirectedRelation, UndirectedRelation) have not been ironed out.

Thanks, I'm working on updating the input processor in INDRA for these changes, will post if I run into any issues.

I'm halfway through, the changes are really straightforward and I like the new format!


Supporting sandbox

Hello. Does javet supports some sort of sandboxes? I know that sandoxes exits for rhino and nashorn engines.

I'm not sure what you are looking for because Javet brings something different.

Javet V8 mode is a pretty good sandbox because there is no net/fs/timer, etc.
Javet Node.js mode has vm or vm2 which are the standard sandbox solution.

Please let me know if I misunderstood your question.

Thanks a lot. Its enough for me. You have done a good description of available options.


Gaming mode doesn't work after upgrade

Describe the bug
After upgrade that brought along fedora 40 gaming mode no longer works. KDE boots after system start up and icon "Go back to gaming mode" tries to open gaming mode and then falls back to KDE.
What did you expect to happen?
Gaming works when using the gaming edition for hometh
Output of rpm-ostree status
Ostree was to update.

State: idle
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable
                   Digest: sha256:67bb1f9dd52a420f080fd67e71a60bb6f732c12bacab7d27476dfbdca601c757
                  Version: 40.20240427.0 (2024-04-27T22:36:59Z)
          LayeredPackages: sunshine
                Initramfs: '"-I /etc/crypttab /etc/modprobe.d/amdgpu.conf /etc/modprobe.d/deck-blacklist.conf" '

  ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable
                   Digest: sha256:f87d5dd11724f35cf8f47a1d22e38777d22160412737ad8d8a288fe23758eb1d
                  Version: 39.20240419.0 (2024-04-19T17:09:55Z)
          LayeredPackages: sunshine
                Initramfs: '"-I /etc/crypttab /etc/modprobe.d/amdgpu.conf /etc/modprobe.d/deck-blacklist.conf" '
                   Pinned: yes

Hardware
Bazzite edition:
Home theater PC
KDE
AMD
Gamig mode - yes
System hw:
AMD Ryzen 5 5600X
AMD RX 7900XT
32gb ram
2tb ssd
Extra information or context
Tried running system update, didn't help.
Tried running Bazzite portal to initialize everything along with gaming mode, didn't help.
After rolling back to previous deployment, everything works correctly.

Same problem on Gnome

I also got this issue when upgrading from deck-39 to deck-40. steam (game mode) errors out with "Unable to open a connection to X", then it fallbacks to the kde session.
Had to rollback to deck-39 for the time being.

Tried again and still broken. Here are all the logs.
[bazzite40-os
bazzite40-neofetch.txt
tree.txt](http
bazzite39-ostree.txt
s://github.com/ublue-os/bazzite/files/15175019/bazzite40-ostree.txt)
bazzite39-neofetch.txt
I've noticed neofetch thinks I have 5700X instead of 5600X, but that's most probably unrelated to the issue with gaming mode.

Try our :testing branch, there's a known issue with HDR on 7xxx GPUs we're trying to get fixed in stable ASAP.

I can confirm switching to testing branch and updating fixed the issue.
However it created a new one: black screen on multiple reboots. I rolled back immediately once I could get display output after boot screen.
Gonna wait for next stable update and then hopefully close this issue.

Not in a hurry or anything but wanted to ask if stable release is coming? I am still on bazzite based on fedora 39 and still got that issue with black screen after upgrading to what used to be "testing branch".
Should I file a new bug report? But I don't know how to log black screen after boot (but I've tested I can ssh into it).

3.5.0 (2024-06-30) Resolved everything, closing


bug: unix_addr check is useless

[ x] I have looked at the documentation here first?
[ x] I have looked at the examples provided that may showcase my question here?

Package version eg. v9, v10:
v10.23.0
Issue, Question or Enhancement:
The unix_addr check is useless. I looked into the src:
https://github.com/go-playground/validator/blob/6c3307e6c64040ebc0efffe9366927c68146ffba/baked_in.go#L2564C16-L2564C31
func isUnixAddrResolvable(fl FieldLevel) bool {
	_, err := net.ResolveUnixAddr("unix", fl.Field().String())

	return err == nil
}

and in stdlib net:
https://cs.opensource.google/go/go/+/refs/tags/go1.23.4:src/net/unixsock.go;l=57
func ResolveUnixAddr(network, address string) (*UnixAddr, error) {
	switch network {
	case "unix", "unixgram", "unixpacket":
		return &UnixAddr{Name: address, Net: network}, nil
	default:
		return nil, UnknownNetworkError(network)
	}
}

effectivly this will never throw an error since you're always passing "unix".
If fact, ResolveUnixAddr is itself useless to check if the socket actually exists.
You need something that checks if the file exists and if that file is a socket:
func IsSocket(filePath string) (err error) {
	stats, err := os.Stat(filePath)
	if err != nil {
		err = fmt.Errorf("check file existence: %w", err)
		return
	}
	if stats.Mode().Type() != fs.ModeSocket {
		err = fmt.Errorf("not socket file: %v", filePath)
		return
	}
	return
}

I'm not entirely sure about the original design intention for this validator. It might have been intended to validate input values exclusively for the 'Unix' network. However, it would be beneficial to extend its functionality to also handle unixgram and unixpacket networks.
We always welcome pull requests with improvements or fixes.
I suggest creating a new socket validator and implementing it with the approach you provided.


Create a way to make CM Nvidia docker container handle dependencies of all the benchmarks so that the docker remains the same for all the benchmarks

Done


Add college

Add Rotherham College

@Vantadaga First stage of verification passed, official domain is rotherham.ac.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://ucr.rotherham.ac.uk/information/useful-links/google-classroom/

@Vantadaga Pull request merged. Thank you.


[ENH] Implement joint_plot

Add a viz function for a joint topo and butterfly plot, EEGLAB style.
Try it with mne.viz.evoked.joint_plot(evoked).
Edit: now also with a method, evoked.plot_joint()

Can I get some feedback? @jaeilepp @kingjr @agramfort ..?

That looks good. I would use continuous gray lines to minimize the number
of edge (and this visual complexity) increase the topo size (the butterfly
time course is generally mainly readable in terms of GDP although with your
new coloring style you can be a bit more informative) and add a white
background to the title so that the lines don't strike the text.
On Tuesday, 22 December 2015, jona-sassenhagen<EMAIL_ADDRESS>wrote:

Can I get some feedback? @jaeilepp https://github.com/jaeilepp @kingjr
https://github.com/kingjr @agramfort https://github.com/agramfort ..?
—
Reply to this email directly or view it on GitHub
https://github.com/mne-tools/mne-python/pull/2738#issuecomment-166724291
.

The figure is a bit off for me:

The picks argument doesn't seem to work for me.

@jaeilepp can you show me the command you tried?

picks = mne.pick_types(evoked.info, meg='mag')
joint_plot(evoked, picks=picks)

Anything with picks fails for me.

And you didn't use the times kwarg, this is with auto picks? Maybe I did something wrong with sampling rate ...

The problem seems to be that evoked.pick_channels only accepts channel names and by passing indices as picks it fails.

Oh well :) will fix. But what about the times, that seems strange. You're not setting times?

No, I'm not setting times. I'm not sure what you mean by it.

Ah, sorry, my fault, I misunderstood the plot.
You can set the times to show topomaps at with topomap_args={times=[0., .2, .35]} or so.

@kingjr I think I'll just remove the title string (or join it with the figure title).

I see... I wonder if we could avoid dicts to pass kwargs to topomap. I know matplotlib uses a lot of hidden kwargs and it's really annoying.
I would just condense the amount of parameters to the minimum and expose them to the user as optional params. Otherwise I'm afraid the users never bother going through the docs to find out all the possible options.

I'm considering that. But my idea would be to instead have good defaults so you rarely have to touch them.
The thing is, I don't want to support only a subset of plot_evoked and plot_topomap params, but the full joint set is a LOT of params.
Using kwarg dicts is the seaborn way of doing things.
But I agree, it's a problematic topic.

http://nbviewer.ipython.org/gist/jona-sassenhagen/1533861e529110aa2fbc
Here is an example gist.

Note: EEGLAB also has these for Time-Frequency plots, power spectra, and even ERPimages. But this is just for Butterfly ERPs for now.

I've addressed the comments.
@jaeilepp I think I got everything you had noted.
@agramfort what do you think of the kwarg dict call signature? See gist: http://nbviewer.ipython.org/gist/jona-sassenhagen/1533861e529110aa2fbc
It's Seaborn's way of exposing the full arg set of two joint functions.
@kingjr IMO straight connection lines don't look as good. They actually feel more salient to me.

I prefer continuous but it's your call, it's a detail. Also, I would put the line behind the butterfly (or is it the case already? there seems to be some kind of a transparency?)

No, you're right, I had accidentally only set the z order for half of the lines.
The gray connection lines are indeed slightly transparent, but they'll all be set to the lowest z order.
Any other opinions on continuous/dashed lines?
Maybe this is just my very subjective preference - they're dashed in EEGLAB ...

Maybe I would expose times param to joint_plot separately since it feels more like a feature of joint_plot. In addition you could have topomap_args where you could set rest of the parameters for topomap. Wdyt?

Otherwise LGTM.

Maybe I would expose times param to joint_plot separately since it feels more like a feature of joint_plot.

I actually had it like that originally - under the hood, it would be more naturally.
Do interactive plots look good for you now?

I'm not sure what you mean by interactive, but it renders much better now. Maybe I would lift the title a little bit. With y=98 it looks better to my eye.

Okay will do.

Just noticed that with weird picks the sensor positions are not correct. You can try picks = mne.pick_types(evoked.info, meg='grad')[:10] with sample dataset. The same problem exists with spatial_colors so maybe we'll tackle it in different PR. I'll open an issue

Good. I'll push the latest fixed (including continuous connection lines, unless you think dashed looks better) and set to MRG.

If the title is lifted, there is more room for the topomaps to be bigger. I think in there is room in the horizontal dimension too, since no one is expected to draw more than three topomaps. Right?

Or is it somehow dynamically sized? Anyway, I think the topomaps should be a little bit larger.

I sometimes plot a lot of topomaps, like 7. But yes, Jean-Remi also wanted the topoplots bigger, I'll see what I can do.

Okay, Travis should come back green now and all comments are addressed.

Sorry I didn't get this done in time for HBM :(

According to my source, It's still open until 3pm
On 8 January 2016 at 12:13, jona-sassenhagen<EMAIL_ADDRESS>wrote:

Sorry I didn't get this done in time for HBM :(
—
Reply to this email directly or view it on GitHub
https://github.com/mne-tools/mne-python/pull/2738#issuecomment-170060836
.

Yeah but I doubt Alex wants to first merge this, and then redo the submission today ...

Travis should come back green ...

Done! Any other comments?

naive question but why are the field maps of the topoplot outside the head?

Because I'm defaulting to 'skirt' for the outlines. If you don't want that, you can pass 'outlines'='head' in the topomap_args.

that's it for me now.
nice work @jona-sassenhagen

@agramfort , is it okay if refactoring picking types is set for another time, and I just adjust plot size/border defaults and then it's merged?

Comments addressed, Travis is good.
Nice, coverage is up.

+1 for merge

great merging !

thanks @jona-sassenhagen !

Thanks for reviews everyone.

@agramfort  can I make a PR for whats_new? I think I forgot that for a few contribs of mine ...

@jona-sassenhagen can just send a PR to update what's new?

Yes, that's what I meant. Will do.


Files API add example has a bug

In the example here, content wouldn't be defined.
const files = [{
  path: '/tmp/myfile.txt',
  content: 'ABC'
}]

for await (const result of ipfs.add(content)) {
  console.log(result)
}

Thanks for pointing it out - it'll be fixed by #597


"Folder" facet  "childCount" always returns zero

Invoking GET "https://tenant-my.sharepoint.com/personal/user/_api/v2.0/drive/root/view.delta" always retuns folder.childCount as zero.
eg:
"folder": {
"childCount": 0
}
For all folders, even if there are files and sub folders inside all folders.
Also GET "https://tenant-my.sharepoint.com/personal/user/_api/v2.0/drive/root/view.delta/expand=children" gives out "General exception"

Hi @praveenmb9752000, this issue should now be resolved - please let us know if you're setting seeing problems.


Set Database Dialect for Connections

Hi Volkan,
I renamed this thread after resolving problem.  I had incorrectly added a Key to the web.config that did not produce an error. Upon reexamining the dialect topic I have discovered that code example is missing the final curly-bracket .
Thank you,
Trent

Sorry @thesnide1, where does it miss curly-bracket? In guide? Could you give a link?

The missing curly bracket is in the guide topic "Set Database Dialect for Connections". https://serenity.is/Docs/setting-connection-dialect
The picture associated with web.config example has unbalanced curly brackets. There are 3 left brackets and only 2 right brackets.

Thanks @thesnide1


docs: ask for the involved chart at the top

What this PR does / why we need it:
Here I offer a way to get the chart related to an issue or a pull request prominently at the top of the template.
Special notes for your reviewer:
Until we can enforce having the chart name in the issue / pull request title this can help.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[ ] ~Chart Version bumped~
[ ] ~Variables are documented in the README.md~

/assign anyone

Dear @viglesiasce or @unguiculus
This should be a quick one. I think it'll help in triage.
Or just reject it.
It'll be okay.


Font Size Validation

Can we get some validation on the font sizes? IMO: The fonts seem quite large and limit the information density on a given page. Are we supposed to be using 16-20px fonts on the page?

Also, I just picked a page this is really a global issue.

Maybe we can also reduce some of the whitespace to show more rows?


GFLOPs of models is different

Hello!
I use your code to compute flops , but find the result is different, why?
Of course, parameters results is same, I get GFLOPs in the following ways：
macs, params = profile(model, inputs=(dummy_input,))
GFLOPs = macs/10**9
for examples in CPU:
in ConvTasnet ：your GFLOPs is 5.23， my test is 20.5
in SudoRM-RF 1.0x:  your GFLOPS is 2.52, my test is 9.87
my test is almost four times to your result
As I realised, The GFLOPs is same in different CPU

The code measuring FLOPs under each model is using 32000 samples
dummy_input = torch.rand(1, 1, 32000).cuda()

If you take a look at the reported numbers in the paper, the caption specifes:
"Table 1: SI-SDRi separation performance for all models on both separation tasks (speech and non-speech) alongside their computational requirements for performing inference on CPU (I) and a backward update step on GPU (B) for one second of input audio or equivalently 8000 samples"
I will update the instructions for getting all the numbers for the computational requirements soon.

The code measuring FLOPs under each model is using 32000 samples
dummy_input = torch.rand(1, 1, 32000).cuda()

If you take a look at the reported numbers in the paper, the caption specifes:
"Table 1: SI-SDRi separation performance for all models on both separation tasks (speech and non-speech) alongside their computational requirements for performing inference on CPU (I) and a backward update step on GPU (B) for one second of input audio or equivalently 8000 samples"
I will update the instructions for getting all the numbers for the computational requirements soon.

Thank you for your help!


module-level incompatibility

Both case 1 and case 2 work in GAS context, but not in node.js with gas-local:
Case 1:
// app.gs --------
function initApp(options) {
  initLibraries();
}
initApp(); // <-- called here, "not defined" error in node.js

// libraries.gs --------
function initLibraries() {
   Logger.log("inited");
}

Case 2:
// app.gs --------
function initApp(options) {
  initLibraries();
}

// libraries.gs --------
function initLibraries() {
  Logger.log("inited");
}
initApp();  // <-- called here, both contexts no error

For case 1 with node.js, you end up with "initLibraries is not defined". However, this is perfectly fine in GAS.
Please advise if this is, as I expect, an unresolvable incompatibility (due to collisions with the global context) or is there perhaps something that can be resolved cleanly?

Hi @brainysmurf, sorry for late answer and thanks for first issue reporting :) Just fore sure -  are the app.gs and libraries.gs in same GAS module?

They are different "files" in the front-end on Google, created via New->Script, and different files on disk in the local stack. Those therefore are different "modules"... or am I mixing up the terminology?
In any case, Case 1 can be mitigated by putting the initApp() in the "libraries" file, at the end, or in a file that comes alphabetically after "libraries".
So I'm thinking it has to do with the context being created, for the vm, in which files are read in alphabetically and variables are available one file at a time. Google must be doing something more complex than that.

ah, now understand :) Thanks for explanation!
Yes, you are right - order of loading matters. node vm executes function's call on file load (in this case initApp) and if file with the implementation was not loaded yet, then it will be error as you described.
So this is unresolvable incompatibility in current implementation, indeed.
Maybe vm have options for deferred function call?

If that's the case then we have two different run-times with an important caveat. Or is there a way to simulate — with the node stack — Google's way of deferring execution of top-level code until all functions in all the files have been loaded? I'm no vm expert, but at least we understand what we are looking for.

Yes, this is the difference.
i have one idea here: what if combine all files into one before load somehow? In other hand this looks too complicated.
if you will solve this, then pull request will be very welcome. i close the issue for now.
Appreciate for your contribution to my humble project 👍

I found a repo that hoists function declarations; we can probably use that. I'll send a pull request whenever I get around to it.
https://www.npmjs.com/package/hoister


variant_label returned the enum name instead of variant name

I love your crate, it does exactly what I needed, but I believe this is a bug.
variant_label now returns the name of the variant instead of the name of the enum

Yup. That's a bug. Thanks for the fix!


FALCON-1954 : Document enabling Oozie JMS for Falcon

Steps to enable Oozie JMS notification for Falcon.

Thanks for fixing merge conflicts. 👍 , will commit tomorrow if there are no further comments.

+1 for the doc changes.   Can we create a separate JIRA if required for fixing these tests
==
org.apache.falcon.lifecycle.FeedExportIT.testSqoopExport
org.apache.falcon.lifecycle.FeedImportIT.testSqoopImport
org.apache.falcon.lifecycle.FeedImportIT.testSqoopHCatImport
org.apache.falcon.lifecycle.FeedImportIT.testSqoopImportUsingDefaultCredential

@vrangan There is a JIRA (https://issues.apache.org/jira/browse/FALCON-1958) to figure out the intermittent IT test failures start happening since yesterday 5/11/16.
But the IT test failure is a separate issue from this pull request.

+1 thank you very much for doing this, will commit shortly.


Updaters tests

We're missing tests for those - I'll add at least those we know that work.
Some related issues found: #239 #243

I'm trying to add a test case for working (well I'm using that scenario!) case with dotnet add against a "classic" csproj and PackageReference and I'm failing to create a working test case :-)

@AnthonySteele I'd like to merge this - please let me know if the style is ok?


Fix races in mesos scheduler plugin test

Fixes #10795

/cc @tsenart for review

Code looks ok, but shippable is failing (on both test permutations):
W0711 10:30:47.486131 13715 cmd.go:137] -p POD is DEPRECATED and will be removed in a future version. Use exec POD instead.
W0711 10:30:47.486436 13715 cmd.go:137] -p POD is DEPRECATED and will be removed in a future version. Use exec POD instead.
W0711 10:30:47.486515 13715 cmd.go:137] -p POD is DEPRECATED and will be removed in a future version. Use exec POD instead.
W0711 10:30:47.487168 13715 cmd.go:137] -p POD is DEPRECATED and will be removed in a future version. Use exec POD instead.
W0711 10:30:47.490081 13715 cmd.go:137] -p POD is DEPRECATED and will be removed in a future version. Use exec POD instead.
--- FAIL: TestRunExposeService (0.05s)
expose_test.go:173: expose-external-service: unexpected output: &api.Service{TypeMeta:api.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:api.ObjectMeta{Name:"foo", GenerateName:"", Namespace:"", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:util.Time{Time:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*util.Time)(nil), Labels:map[string]string{"svc":"test"}, Annotations:map[string]string(nil)}, Spec:api.ServiceSpec{Ports:[]api.ServicePort{api.ServicePort{Name:"default", Protocol:"UDP", Port:14, TargetPort:util.IntOrString{Kind:0, IntVal:14, StrVal:""}, NodePort:0}}, Selector:map[string]string{"func":"stream"}, ClusterIP:"", Type:"LoadBalancer", DeprecatedPublicIPs:[]string(nil), SessionAffinity:""}, Status:api.ServiceStatus{LoadBalancer:api.LoadBalancerStatus{Ingress:[]api.LoadBalancerIngress(nil)}}}
FAIL
coverage: 55.3% of statements
FAIL	github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd	0.846s

I don't think we changed that, but it might be affected by the testify update... I can triage on Monday, unless you get to it first, @sttts

That's #11105.

Rebased to re-enable test.

LGTM.
Need a google approval, since this bumps test dependencies used by non-mesos tests.
/cc @davidopp

Reassigned to @davidopp for review.
This should fix a contrib/mesos unit test that was skipped for being flakey.

LGTM

@k8s-bot ok to test


add toggle for using the delta tree via cli

Does this PR need a docs update or release note?

[x] :no_entry: No

Issue(s)

#4690

Test Plan

[x] :zap: Unit test

I see this and agree we'll need at least a flag in control.Options so we can test this. I'm a little unsure about the need for a CLI flag in main since we don't need to expose this to users at all (I do realize it would make testing easier)
I'd also like to hold off approving/merging this PR out of an abundance of caution until we feel we're more ready to flip the switch. It feels a bit premature right now since we don't have any of the wiring or a full implementation of the delta tree right now

I'd also like to hold off approving/merging this PR out of an abundance of caution until we feel we're more ready to flip the switch. It feels a bit premature right now since we don't have any of the wiring or a full implementation of the delta tree right now

@ashmrtn I understand the concerns, but I think you're being overly conservative about the situation.  Precautions will be taken through deployment to ensure that this cannot put users' backups into a bad state.
While I personal consider alternatives like env vars to have the same level of risk as hidden flags, I'm open to using that implementation (or any similar) instead of a flag if it eases concerns.


Allow websocket client node to send pings

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Proposed changes
This adds a new option to the Websocket Client config node to enable automatic sending of ping messages as-per the websocket spec.

If enabled, the client will send ping messages each interval. If the previous ping has not been acknowledged by a pong, the client terminates the connection (triggering status node etc) and attempts to reconnect.

Coverage decreased (-0.04%) to 67.566% when pulling d8ee7668608e08687add8db55f39d18a7a6e8e97 on ws-ping into 46c4e2d21220e03bd5334432a9053533780043f3 on dev.


HelpCommand.java:35: Implement help command.

The puzzle 1-9ca74a96 from #1 has to be resolved:
https://github.com/shiruka/shiruka/blob/164f6c45595aa8890232ef9427d108cd58e11016/src/main/java/net/shiruka/shiruka/command/commands/HelpCommand.java#L35-L35
The puzzle was created by Hasan Demirtaş on 24-Feb-21.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 1-9ca74a96 has disappeared from the source code, that's why I closed this issue.


[release-0.11] Plumbing external loggers into cloudstack provider for improved debugging

Issue #, if available:
Description of changes:
Manual cherrypick of https://github.com/aws/eks-anywhere/pull/3529 into release branch
Testing (if applicable):
Unit tests pass
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


[Chore] Move mandatory variables to the top of configuration file

As a preliminary step to the goal of creating the configuration file during container startup, move mandatory variables to the top of configuration file.
We will then have a clear reminder of which variables must be written regardless of the user-specified environment variables

Available in release 2022-12-16


remote-ssh: cannot start interactive window

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

Ubuntu 20.04 (local) remote-ssh to a Ubuntu 18.04 machine (remote)
crtl + shift + P and Python: Show Python Interactive Window
Received the error message

Now, I can still use ssh to start jupyter server and use Python: Specify local and remote jupyter server...
and then start interactive window normally. But it is inconvenient and might generate a lot of testing ipynb files.
It was ok before to directly use Python: Show Python Interactive Window that automatically start jupyter server and run the interactive window.
Maybe something changed after the update? Or I made some mistakes?
Actual behavior
cannot directly start interactive window
Expected behavior
everything is ok few times ago...
I doubt there's something wrong

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Remote
Extension version: 2020.3.71659
VS Code version: 1.44.0
Setting python.jediEnabled: true | false
Python and/or Anaconda version: 3.6.9
OS: Windows | Mac | Linux (distro): Linux (Ubuntu 20.04)
Virtual environment: virtualenv

Developer Tools Console Output

log files
-1586924127296.log
Thanks!

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

The interpreter we're using to start jupyter doesn't have jupyter installed. Try running 'Select interpreter to start Jupyter' and pick a python interpreter that has jupyter installed (not the 3.6.9 64-bit ('venv': virtualenv) one)

The interpreter we're using to start jupyter doesn't have jupyter installed. Try running 'Select interpreter to start Jupyter' and pick a python interpreter that has jupyter installed (not the 3.6.9 64-bit ('venv': virtualenv) one)

Thanks! This resolved the problem.
But the error message seems to be misleading? At the beginning, I thought the problem came from remote machine (virtualenv).
The actual problem is, I freshly install a new local machine and forget to install jupyter in local.

If you're using remote-ssh, and the file you're running the interactive window is on the remote box, it should be using a remote python. Are you saying it isn't?


tsnet: open tsstate/tailscaled.state: permission denied

For some reason tsnet can't create files in the default state folder: tsnet: open tsstate/tailscaled.state.tmp1170394514: permission denied
It still panics with both named volumes and a local binding
However, if you try to use the home folder for the state (TS_SIDECAR_STATEDIR: . & - tsstate:/home/nonroot), it works nicely
A part of the docker-compose.yml
  sidecar:
    image: "ghcr.io/markpash/tailscale-sidecar"
    environment:
      TS_AUTHKEY: tskey-ke9WLg5CNTRL-jdE98Dyg8KiRrrBjnzLQZR
      TS_SIDECAR_NAME: proxima-main
    volumes:
      - ./bindings.json:/etc/ts-sidecar/bindings.json
      # both these don't work
      #- tsstate:/home/nonroot/tsstate
      #- ./state:/home/nonroot/tsstate

Logs
tgs-sidecar-1  | 2022/09/30 15:48:28 [v1] using fake (no-op) tun device
tgs-sidecar-1  | 2022/09/30 15:48:28 [v1] using fake (no-op) OS network configurator
tgs-sidecar-1  | 2022/09/30 15:48:28 [v1] using fake (no-op) DNS configurator
tgs-sidecar-1  | 2022/09/30 15:48:28 dns: using dns.noopManager
tgs-sidecar-1  | 2022/09/30 15:48:28 link state: interfaces.State{defaultRoute=eth0 ifs={eth0:[<IP_ADDRESS>/16]} v4=true v6=false}
tgs-sidecar-1  | 2022/09/30 15:48:28 magicsock: disco key = d:86b7c08b46a052b2
tgs-sidecar-1  | 2022/09/30 15:48:28 Creating wireguard device...
tgs-sidecar-1  | 2022/09/30 15:48:28 Bringing wireguard device up...
tgs-sidecar-1  | 2022/09/30 15:48:28 [v2] UDP bind has been updated
tgs-sidecar-1  | 2022/09/30 15:48:28 [v2] Interface state was Down, requested Up, now Up
tgs-sidecar-1  | 2022/09/30 15:48:28 Bringing router up...
tgs-sidecar-1  | 2022/09/30 15:48:28 [v1] warning: fakeRouter.Up: not implemented.
tgs-sidecar-1  | 2022/09/30 15:48:28 Clearing router settings...
tgs-sidecar-1  | 2022/09/30 15:48:28 [v2] Routine: receive incoming v4 - started
tgs-sidecar-1  | 2022/09/30 15:48:28 [v1] warning: fakeRouter.Set: not implemented.
tgs-sidecar-1  | 2022/09/30 15:48:28 Starting link monitor...
tgs-sidecar-1  | 2022/09/30 15:48:28 [v2] Routine: receive incoming v6 - started
tgs-sidecar-1  | 2022/09/30 15:48:28 Engine created.
tgs-sidecar-1  | 2022/09/30 15:48:28 [v2] Routine: receive incoming receiveDERP - started
tgs-sidecar-1  | 2022/09/30 15:48:28 tsnet: open tsstate/tailscaled.state.tmp23198575: permission denied
tgs-sidecar-1 exited with code 0

Seeing the same when using a volume. If i mount it over /home/nonroot it has no permission issues, but mounted on any other path it shows permission denied. I'm assuming it's because the process runs as user ID 65532 and there is no way to change ownership/access permissions of the mounted volume.

After a bit of digging -
Bind mounts use the permissions of the host: the sidecar is running non-root (user 65xxx) so cannot create/change the permissions
Volume mounts default as root owned and 755 permissions: as above sidecar is non-root so cannot do the necessary
I see other images including some unix tools so you could tweak permissions on entrypoint, i'm sure there's a more elegant solution..


Published .d.ts files don't type-check

If you try to consume the ecmarkup package via the API, it will fail to type-check because Clause is marked /* @internal */...
https://github.com/tc39/ecmarkup/blob/05d05f71e1bc8cf151da65d34e9105eff3e7d465/src/Clause.ts#L26-L27
but maybeAddClauseToEffectWorklist still uses the non-existent default export publicly.
https://github.com/tc39/ecmarkup/blob/05d05f71e1bc8cf151da65d34e9105eff3e7d465/src/Spec.ts#L254-L258
This results in the error:
node_modules/ecmarkup/lib/Spec.d.ts:49:84 - error TS2709: Cannot use namespace 'Clause' as a type.

Should maybeAddClauseToEffectWorklist be marked internal as well?

@DanielRosenwasser I can remove /* @internal */ from Clause, but ideally I'd like to figure out how to prevent this category of issue in the future - is there a way I can write a test which ensures the published TS definitions typecheck? I didn't realize TS would let me publish invalid .d.ts files from a well-typed project, given that it's the thing generating them in the first place...

/* @internal */ is a long-standing "undocumented" feature that I've wanted to redo since 2015 into something actually baked into the language. It was a bit of an expert-level workaround for trimming things from your public API and unfortunately hasn't received much attention since TS 1.0.


Fix wording around specification samples

I also validated the sample code looking for errors, none found.

Aside from the minor nitpick of files needing to be plural in this case, all renders fine on staging. Does this require technical review by someone else?

Should be fine without technical review.

Ok, thanks. I'll merge once the builds are green.

--no-rebase


Allow GitHub IDP type in FederationDomains

This PR gets GitHub IDPs listed by the FederationDomain and allows a configured GitHub IDP to appear in the IDP Discovery Document:
# find the IDP endpoint in discovery
https://pinniped-supervisor-clusterip.supervisor.svc.cluster.local/some/path/.well-known/openid-configuration
{
  "issuer": "https://pinniped-supervisor-clusterip.supervisor.svc.cluster.local/some/path",
  "authorization_endpoint": "https://pinniped-supervisor-clusterip.supervisor.svc.cluster.local/some/path/oauth2/authorize",
  "token_endpoint": "https://pinniped-supervisor-clusterip.supervisor.svc.cluster.local/some/path/oauth2/token",
  "jwks_uri": "https://pinniped-supervisor-clusterip.supervisor.svc.cluster.local/some/path/jwks.json",
  "response_types_supported": [
    "code"
  ],
  "response_modes_supported": [
    "query",
    "form_post"
  ],
  "subject_types_supported": [
    "public"
  ],
  "id_token_signing_alg_values_supported": [
    "ES256"
  ],
  "token_endpoint_auth_methods_supported": [
    "client_secret_basic"
  ],
  "scopes_supported": [
    "openid",
    "offline_access",
    "pinniped:request-audience",
    "username",
    "groups"
  ],
  "claims_supported": [
    "username",
    "groups",
    "additionalClaims"
  ],
  "code_challenge_methods_supported": [
    "S256"
  ],
  "discovery.supervisor.pinniped.dev/v1alpha1": {
    "pinniped_identity_providers_endpoint": "https://pinniped-supervisor-clusterip.supervisor.svc.cluster.local/some/path/v1alpha1/pinniped_identity_providers"
  }
}

# GitHub in the list
https://pinniped-supervisor-clusterip.supervisor.svc.cluster.local/some/path/v1alpha1/pinniped_identity_providers
{
  "pinniped_identity_providers": []
}

Release note:

Once the FederationDomainWatcher & FederationDomainListerFinder have both been updated a GitHubIdentityProvider can be created and attached to a FederationDomain without error.

It feels like there's a lot of TODOs here, I are we sure that this PR is "just enough" to compile and add GitHubIdentityProviders to FederationDomains and have them listed under the v1alpha1/pinniped_identity_providers endpoint?

I'm happy to do either:

review, polish & merge this (with some todos for next stories)
pull the next story & keep working on it on this branch to address the todos


🚀 [REQUEST] - source from cwd or from sourced script

just to share my thoughts, having a folder structure like that:
├── bin
│   └── main.sh
            source templates/test/a.sh
└── templates
    └── test
        ├── a.sh
                echo this is a
                source templates/test/b.sh # required for regular bash script usage
                vs
                source b.sh # required with inline.sh
        └── b.sh
                echo this is b

and running main.sh from the root dir leads to an error like:
bash bin/main.sh
...
[FATAL] Unable to resolve source file path ...
[FATAL] Error inlining file ...

it works if source is used without path but then the usage breaks if i want to run it with a native bash call and vice versa.
some option like --relative-sourcing vs --source-from-cwd could be helpful

You can use shellcheck source=PATH/TO/SCRIPT on the line just before source templates/test/a.sh" in main.sh. Because they could lead to misunderstandings, I do not want to include relative sourcing or cwd.
Additionally, since shellcheck is well known and widely used, I wish to utilize a similar approach (static analysis or something similar).
Update main.sh:
# shellcheck source=../templates/test/a.sh
source templates/test/a.sh

However, if you believe that cwd sourcing is utilized a lot and is a truly useful feature, we can discuss it.
I don't want my opinion to take precedence over others simply because I am the keeper.

i haven't used shellcheck in that way. i will give it a try but i am not sure i understand how the shellcheck annotation will help the source command find the correct path if i call the script normally via bash.

source
Tell ShellCheck where to find a sourced file (since 0.4.0):

https://www.shellcheck.net/wiki/Directive
if i assume that my dir tree shown above is in ~/test-project:
cd ~/test-project
bash bin/main.sh

to make this call work i would need to  use source templates/test/a.sh in main.sh. how would the shellcheck annotation help?
or did you mean you think about integrating such a feature with the shellcheck annotation?
in my bash scripts i often use this hack to allow calls from everywhere to the script:
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "${DIR}/lib/functions.sh"
source "${DIR}/lib/colors.sh"

in this case all of the following works:
cd ~ && bash bin/main.sh
cd / && bash bin/main.sh
cd ~/test-project && bash bin/main.sh
cd ~/test-project/bin && bash bin/main.sh

Yes. However, both my script and shellcheck are static tools that do not execute your script to evaluate dynamically what is ${DIR} in source. Therefore, you can continue using your approach. Update source (that fails) with a simple comment before source. Whenever inline finds a # shellcheck source=PATH_TO_SCRIPT before source, save PATH_TO_SCRIPT to a temporary variable. If it fails to resolve source PATH_TO_SCRIPT as a normal import, it falls back to shellcheck's PATH_TO_SCRIPT.

Simpler: If I try to resolve a path with a variable it fails (if not in PATH) because the value (Dynamic) is unknown. Therefore, you need to add a hint to correctly resolve the source path.


Incorrect path to create and activate python virtual environment

Docs mention to run ./python-virtual-env.sh.  This path doesn't exist.
Correct path should be ./.devcontainer/scripts/python-virtualenv.sh

Fixed by #4


Handling asynchronous initialization and promises

Asynchronous initialization presents a problem for many node modules. One common pattern for ensuring initialization is only done once is to wrap initialization in a promise that is "thened" on each module operation:
var initialize = new Promise(function(resolve, reject) {
  resolveMetadata(function(err, response) {
    if (err) reject(err);
    resolve(response.metadata);
  });
});

function foo(callback) {
  initialize.then(function(metadata) {
    doOperation(metadata, callback);
  });
}

module.exports = foo;

Because continuation-local-storage propagates context from a promise's creation context into the then function, this will cause each call to foo made from inside a namespace#run to lose context. This is problematic if a modules is trying to handle each incoming request to a web server in a separate namespace and foo is invoked per request.
This small test case demonstrates the issue:
var cls = require('continuation-local-storage');
var ns = cls.createNamespace('foo');

var p = new Promise(function(res, rej) {
  res(5);
});

ns.run(function() {
  ns.set('a', 'b');
  p.then(function() {
    console.log(ns.get('a')); // prints undefined but should print 'b'
  });
});

It would be great if then only ran in p's context if there was a context at the time p was created. To play around with this issue, I tried this async-listener patch:
diff --git a/index.js b/index.js
index e634ac4..51649bd 100644
--- a/index.js
+++ b/index.js
@@ -490,14 +490,14 @@ function wrapPromise() {
       // continuations of the accept or reject call using the __asl_wrapper created above.
       function bind(fn) {
         if (typeof fn !== 'function') return fn;
-        return function (val) {
+        return wrapCallback(function (val) {
           var result = (promise.__asl_wrapper || propagateAslWrapper)(this, fn, val, next);
           if (result.error) {
             throw result.errorVal
           } else {
             return result.returnVal
           }
-        };
+        });
       }
     }
   }

This patch will result in the above code snippet printing 'b' without clobbering context if then is called at point with no active namespace:
var cls = require('continuation-local-storage');
var ns = cls.createNamespace('foo');

var p2;

ns.run(function() {
  ns.set('c', 'd');
  p2 = new Promise(function(res, rej) {
    res(6);
  });
});

ns.run(function() {
  ns.set('c', 'e');
  p2.then(function() {
    console.log(ns.get('c')); // prints 'd' with and without patch
  });
});

While this change (or similar) will not address all issues CLS has with promises, it will reduce the amount of patching APM vendors need to do for this relatively common pattern. What do others think about a change like this? /cc @Qard @watson @ofrobots

Thanks for the ping. We don't use the CLS module in the Opbeat node agent, so we are not directly affected by this (though I can't rule out that we're not affected by something similar).
I'm interested in the discussion nonetheless, though I can't really say much about this scenario off the top of my head - so I'll look forward to hear feedback from others.

Seems reasonable.
When I was still at AppNeta, I was actually considering a slightly different change of tracking context at both internal promise resolution and at the point then() is called. Then the context set inside the callback given to then() would use one of the two potential contexts but instead prioritizing the then() call context over the internal resolution context, that way it'd tend toward following the user code over the internals.
This seems like an easier change though with less chance of breaking things.

I also played around with tracking both the resolution and chaining context but found that approach to be more error prone and susceptible to "but given user intent the other context is better" issues. I tried running the async-listener tests with this change and there seemed to be many failures as the tests expect a particular trace of async events to have occurred. Even though this change will only introduce context where there was previously none, it does modify these traces causing tests to fail. Would you be open to changing the expected traces in these tests? If so, I can open a pr with this patch + test changes.

I'm fine with that. Not sure if @othiym23, @hayes or @watson have any concerns.
I've never really liked the tests in async-listener--too much emphasis on testing of internal behaviour over how it should actually work from the user perspective.

I think for most cases this would be fine, the place where I would be concerned about this would if there are things that someone would want to explicitly exclude from a namespace by wrapping them with "no state".  In those cases things that were previously excluded would now potentially be included again.  That being said, I can't come up with a compelling example of user code that would actually include things one would expect to be excluded.  I think this proposal is reasonable, and would be a net positive.
I don't really have a stake in this anymore since I don't work on node apm these days

Yeah...it seems like very few of us do. 😕

also I apologize for the state of those tests, I always hated them as well, but was too lazy/busy to come up with something better.  In the long run, I think that the instrumentation around promises will need to be rethought entirely to support async/await, but for now, I don't think there should be much resistance to just updating the tests to match the new semantics

No worries. It's a hard and constantly evolving problem.
I just want things to keep moving forward. 😸

Fixed by https://github.com/othiym23/async-listener/pull/105. Thanks all!


Kernel Management issues and improvements

Feature: Notebook Editor
Description

Jupyter Notebook tree shows active kernels. It'd be nice if I could monitor active kernels on the workspace.
Notebook editor shows only option for Restart and interrupt kernel. I'm not sure if closing the notebook window actually quits the kernel - if not, it'd be nice to have options to either temporarily close the window or quit the kernel completely. Kernel management will probably make this feature obsolete though.

being able to kill a kernel without having to close the window would be very nice. A lot of the time, the interrupt button just doesn't actually kill the kernel even after minutes.

please implement this feature. I'm working on a cython extension and when I want to compile it I must kill the kernel, otherwise I get a permission error when compiling the new cython extension:
PermissionError: [Errno 13] Permission denied: './jupyter/ext.cp37-win_amd64.pyd'

In https://github.com/microsoft/vscode-jupyter/issues/7189#issuecomment-901259010, @rchiodo said:

Thanks for the suggestion. Kernels should be killed when:

You close VS code
You close the notebook/interactive window that had the kernel selected.

Do you need another way to kill a kernel? Maybe while VS code is still open?

Unless I'm misreading, when I close a notebook (i.e. close its tab in the VS code window), its kernel should be killed. That's not the behavior I'm seeing. For example, right now, I have a notebook that has been closed for a couple of days, and it's still holding ~48GB of RAM. If I reopen it (i.e. name italicized in the tab as a preview), I still see the green checks and execution times suggesting that the kernel is still running (and verified in Activity Monitor).
Ideally, I'd like to be able to kill kernels much like I can in the Jupyterlab interface, whether that's by a panel (see #7598), visibility in the file browser with a right-click option (see Jupyterlab), or something else. I work on a lot of (research) projects with a mix of documents, .py files, notebooks, CSVs, and the like. So, I may have a project window open for weeks, even though any given notebook is only in use for a short amount of time (and, thus, shouldn't have a running kernel holding on to lots of RAM).
I'm pretty new to the Jupyter functionality in VS Code, but I like it a lot. This is probably my top usability issue so far.

@jtkiley the kernel should die on notebook close (unless you're using remote where kernels would be handled by the remote server).
You might be hitting this bug though:
https://github.com/microsoft/vscode-jupyter/issues/5225

@rchiodo Thanks!
If I close the notebook's tab within the VS code window, it continues to live forever. But, if I close the interactive window (what #5225 appears to be having an issue with), it does appear to kill the kernel.
Am I right that both cases should kill the kernel, and not just the second?
FYI: Mac, Intel, 11.6.1, current stable VS code

Yes both cases should kill the process. Daemon failure may be happening on Mac M1 as well.

@rchiodo I'm on an Intel Mac in this case, but I went exploring a bit.
If I create a test notebook, it kills on tab close like you'd expect. So, I went back to the big notebook I was working with, and I managed to cut until I have a small reproducible test case. It's pretty obscure, but it goes like this: If I run through a notebook and display a %matplotlib inline figure, close it (proper kernel kill), reopen it and run through to df.head() in pandas, and then close the tab, the kernel persists. Oddly enough, I need to run that df.head(); importing pandas and mocking up a data frame won't do it.
With that in mind:

This is probably a bug apart from this issue. I'll see if I can find it already reported (pointers appreciated).
The possibility for a strange bug like this is probably a good reason to expose kernel management controls.

The daemon failure I mentioned was likely timing related so it may be that the kernel has to be just slow enough to not respond to a request from the daemon in order for it to not die.

Closing this issue as the functionality requested in the original comment of this issue has been provided by the Jupyter Power Toys extension, see here https://github.com/microsoft/vscode-jupyter-powertoys#kernel-management-panel

@DonJayamanne I feel strongly like this should be a core Jupyter feature, and not in some extension.

having to close and restart kernels reliably is just a bread and butter thing that should be a core feature

@rchiodo please don't kill this

@DonJayamanne: I would love to have this feature moved into the main Jupyter VS Code extension as well. I didn't know about Jupyter PowerToys as an option until I came across this thread, and until now, I've been reluctantly relying on JupyterLab to manage my Jupyter kernels.
While the Jupyter VS Code extension description on the VSCode marketplace currently references Jupyter PowerToys, it doesn't actually list what features PowerToys supports and simply says that PowerToys adds "experimental features." I personally would not have thought that kernel management would be considered an "experimental feature," so I didn't even think to look at PowerToys. Perhaps this is a personal issue, but I would love to see either:
a) directly adding the kernel management feature into the Jupyter extension, OR
b) enhancing the discoverability of the Jupyter PowerToys features.

list what features PowerToys supports and simply says that PowerToys adds "experimental feat

Thank you for this suggestion, we're planning on moving some of this into the core jupyter extension, however this hasn't been prioritized. But that is the goal.


GitHub sync

@alorenzen We should probably blacklist the source_gen golden tests :-/

This actually looks like a legit failure to me. The golden files are not actually importing angular/angular.template.dart.

OK, I found the issue with the golden files. When we made usePlaceholder the default again, we didn't change it for the generate.dart script (literally the one place that it's intended to not use the default :stuck_out_tongue: )
It's an easy enough fix, so we can include it in this PR.

Great!
On Thu, Jul 13, 2017, 2:25 PM Andrew Lorenzen<EMAIL_ADDRESS>wrote:

OK, I found the issue with the golden files. When we made usePlaceholder
the default again, we didn't change it for the generate.dart script
(literally the one place that it's intended to not use the default 😛 )
It's an easy enough fix, so we can include it in this PR.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/angular/pull/518#issuecomment-315206612,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKQ7sJN058dSZE2RHgraPvNZMTEeuEzks5sNos_gaJpZM4OXg0x
.

@alorenzen We need to ignore dartfmt for dev, otherwise LGTM.


[BBC.co.uk] "No Video Formats Found"

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.06.21
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

D:\Video\Downloads>youtube-dl "https://www.bbc.co.uk/iplayer/episode/p01fj
94w/peaky-blinders-series-1-episode-1" -v
[debug] System config: []
[debug] User config: ['--all-subs', '--sub-format', 'srt', '--convert-subs', 'sr
t', '--embed-subs', '--merge-output-format', 'mkv', '--recode-video', 'mkv', '--
format', 'bestvideo[width=1280]+bestaudio/best', '-o', 'D:/Video/Downloads/%(ser
ies)s/%(series)s - %(season_number)sx%(episode_number)02d - %(title)s [%(height)
s] [%(id)s].%(ext)s', '--prefer-ffmpeg', '--ffmpeg-location', 'D:\\Video\\FFMPEG
\\bin', '--download-archive', 'D:/Video/Downloads/Archive.txt', '--exec', 'D:\\V
ideo\\FFMPEG\\bin\\ffmpeg.exe -i {} -map 0 {}_+.mkv']
[debug] Custom config: []
[debug] Command-line args: ['https://www.bbc.co.uk/iplayer/episode/p01fj94w/peak
y-blinders-series-1-episode-1', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.06.21
[debug] Python version 3.4.4 (CPython) - Windows-8.1-6.3.9600
[debug] exe versions: ffmpeg N-90771-g5079e96bcc, ffprobe N-90771-g5079e96bcc
[debug] Proxy map: {}
[bbc.co.uk] p01fj94w: Downloading video page
[bbc.co.uk] p01fj94w: Downloading playlist JSON
[bbc.co.uk] b03b3c95: Downloading media selection XML
[bbc.co.uk] b03b3c95: Downloading MPD manifest
WARNING: Failed to download MPD manifest: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading MPD manifest
WARNING: Failed to download MPD manifest: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] b03b3c95: Downloading captions
[bbc.co.uk] b03b3c95: Downloading captions
WARNING: Unable to download XML: HTTP Error 403: Forbidden
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug
 . Make sure you are using the latest version; type  youtube-dl -U  to update. B
e sure to call youtube-dl with the --verbose flag and include its complete outpu
t.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmppgbwk_
g4\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmppgbwk_
g4\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmppgbwk_
g4\build\youtube_dl\extractor\bbc.py", line 577, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmppgbwk_
g4\build\youtube_dl\extractor\common.py", line 1327, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issu
e on https://yt-dl.org/bug . Make sure you are using the latest version; type  y
outube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and
include its complete output.

Description

Until this past week, the BBC site was working without any major issues. Now however, since updating the software, every file returns an error message stating that there are "No Video Formats Found."  This includes for videos that were working normally last week. These videos still work within the browser without issue.
URL of video tested above: https://www.bbc.co.uk/iplayer/episode/p01fj94w/peaky-blinders-series-1-episode-1

For any work on this you must provide working GB proxy/vpn.

For any work on this you must provide working GB proxy/vpn.

How am I expected to provide a working proxy/vpn if I don't have one and none is required for me to access this content here in the UK?

I just came to the issue as I was about to log one for the same problem, as I have been having issues with BBC iPlayer links since last week also (I'm in Aus using a VPN).
However, I've just attempted to replicate and to my surprise, this one actually started downloading for me --
>youtube-dl.exe -v -c -w "https://www.bbc.co.uk/iplayer/episode/p01fj94w/peaky-blinders-series-1-episode-1" -o "%(title)s.%(ext)s" --sub-lang en --write-sub --convert-subtitles srt --embed-subs --ignore-errors --add-metadata [debug] System config: [] [debug] User config: []                                                                                [debug] Custom config: [] [debug] Command-line args: ['-v', '-c', '-w', 'https://www.bbc.co.uk/iplayer/episode/p01fj94w/peaky-blinders-series-1-episode-1', '-o', '%(title)s.%(ext)s', '--sub-lang', 'en', '--write-sub', '--convert-subtitles', 'srt', '--embed-subs', '--ignore-errors', '--add-metadata']                                                                                [debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252 [debug] youtube-dl version 2019.06.21 [debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134 [debug] exe versions: ffmpeg 4.1.1, ffprobe 4.1.1 [debug] Proxy map: {} [bbc.co.uk] p01fj94w: Downloading video page [bbc.co.uk] p01fj94w: Downloading playlist JSON [bbc.co.uk] b03b3c95: Downloading media selection XML                                                                                [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information                                                                                WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading MPD manifest                                                                                WARNING: Failed to download MPD manifest: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading MPD manifest                                                                                [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden                                                               [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden                                                               [bbc.co.uk] b03b3c95: Downloading m3u8 information                                                                                WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information                                                                                WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information                                                                                WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden                                                               [bbc.co.uk] b03b3c95: Downloading MPD manifest WARNING: Failed to download MPD manifest: HTTP Error 403: Forbidden                                                                   [bbc.co.uk] b03b3c95: Downloading MPD manifest [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information                                                                                WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information                                                                                WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information                                                                                WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden                                                               [bbc.co.uk] b03b3c95: Downloading captions                                                                                [bbc.co.uk] b03b3c95: Downloading captions WARNING: Unable to download XML: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading captions                                                                                WARNING: Unable to download XML: HTTP Error 403: Forbidden                                                                            [debug] Default format spec: bestvideo+bestaudio/best [info] Writing video subtitles to: Peaky Blinders, Series 1, Episode 1.en.ttml [debug] Invoking downloader on 'https://vod-dash-uk-live.bbcfmt.hs.llnwd.net/usp/auth/vod/piff_abr_full_hd/88b0e4-b03b3c95/vf_b03b3c95_aab2d8c5-3f73-41d1-95a7-26f1ff871eed.ism.hlsv2.ism/iptv_hd_abr_v1_dash_master.mpd?s=1561669611&e=1561712811&h=43f47f9dc00ad921fdde08ff15288310'                                                                                [dashsegments] Total fragments: 892                                                                                [download] Destination: Peaky Blinders, Series 1, Episode 1.fstream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash_https-video=5070000.mp4 [download]   0.3% of ~1.21GiB at 142.46KiB/s ETA 01:09:33

youtube-dl.exe -v -c -w "https://www.bbc.co.uk/iplayer/episode/p01fj94w/peaky-blinders-series-1-episode-1" -o "%(title)s.%(ext)s" --sub-lang en --write-sub --convert-subtitles srt --embed-subs --ignore-errors --add-metadata [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', '-c', '-w', 'https://www.bbc.co.uk/iplayer/episode/p01fj94w/peaky-blinders-series-1-episode-1', '-o', '%(title)s.%(ext)s', '--sub-lang', 'en', '--write-sub', '--convert-subtitles', 'srt', '--embed-subs', '--ignore-errors', '--add-metadata'] [debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252 [debug] youtube-dl version 2019.06.21 [debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134 [debug] exe versions: ffmpeg 4.1.1, ffprobe 4.1.1 [debug] Proxy map: {} [bbc.co.uk] p01fj94w: Downloading video page [bbc.co.uk] p01fj94w: Downloading playlist JSON [bbc.co.uk] b03b3c95: Downloading media selection XML [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading MPD manifest WARNING: Failed to download MPD manifest: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading MPD manifest [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading MPD manifest WARNING: Failed to download MPD manifest: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading MPD manifest [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading m3u8 information WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading captions [bbc.co.uk] b03b3c95: Downloading captions WARNING: Unable to download XML: HTTP Error 403: Forbidden [bbc.co.uk] b03b3c95: Downloading captions WARNING: Unable to download XML: HTTP Error 403: Forbidden [debug] Default format spec: bestvideo+bestaudio/best [info] Writing video subtitles to: Peaky Blinders, Series 1, Episode 1.en.ttml [debug] Invoking downloader on 'https://vod-dash-uk-live.bbcfmt.hs.llnwd.net/usp/auth/vod/piff_abr_full_hd/88b0e4-b03b3c95/vf_b03b3c95_aab2d8c5-3f73-41d1-95a7-26f1ff871eed.ism.hlsv2.ism/iptv_hd_abr_v1_dash_master.mpd?s=1561670493&e=1561713693&h=1faffa102329694a62f4dc43194ab426' [dashsegments] Total fragments: 892 [download] Destination: Peaky Blinders, Series 1, Episode 1.fstream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash_https-video=5070000.mp4 [download]   0.3% of ~1.21GiB at 142.46KiB/s ETA 01:09:33

@darthhaggis hopefully this is working for you now again also. I actually tried to resume a partially downloaded file when it first stopped working; initially with the 'no video formats found' error, which was then replaced by a 503 a day or two later.
Guessing something may have changed on the BBC site.


Failed to resolve entry for package "@hocuspocus/provider".

Description
i great job, , i've already used hocuspocus on https://github.com/scenaristeur/tiptap-yjs
https://scenaristeur.github.io/tiptap-yjs/
but here trying to test the playground, i've got an error :
just git pull and npm install, npm run start missing a link or something ?
[plugin:vite:import-analysis] Failed to resolve entry for package "@hocuspocus/provider". The package may have incorrect main/module/exports specified in its package.json.

/home/smag/dev/hocuspocus/playground/frontend/src/pages/Index.vue

same with node v16.19.0 or v18.16.0 on linux mint

hey @scenaristeur, thanks for the report! Indeed we were missing instructions for this. You need to run npm run build in the repo root to build the packages first.
I've just pushed a change to add this to the README.

thxs ;-)


Error

[16:46:29 INFO]: [ChunkSender] [STDOUT] error: java.io.IOException: Broken pipe
[16:46:29 WARN]: Nag author(s): '[HimmelKreis4865]' of 'ChunkSender v1.2' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).
[16:46:29 INFO]: [ChunkSender] [STDOUT] error station 1: java.util.concurrent.CompletionException: java.lang.RuntimeException: java.io.IOException: Broken pipe

hello, I am aware of this bug right now, but yet I dont have a solution for it because I can't reproduce it....what os are you running on, and what hardware is available? + maybe what did you do that caused the error?

OS: Debian 12, teleport to some point

are you using code to teleport to a random point, if so please share it with me.
Also, are there any server overload messages before the errors?
And please check the overall performance of your server (vps or whatever) so we can be sure that this is no hardware-limited error


Update via Update-Notification is not working

Describe the bug
See title.
To Reproduce
Steps to reproduce the behavior:

Have an outdated version installed
Restart your mac
Open Lens
Try to update via the update notification

Expected behavior
It updates
Environment (please complete the following information):

Lens Version: 4.1.2
OS: macOS Big Sur
Installation method: via .dmg

This is fixed in upcoming 4.2 release

fixed by #2232


Release please  branches  main  components  core

What ❔

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via zk spellcheck.

{
}

Hello i want to help to recover my account old


Added batch support and APS config

Hey @sanath-2024, I added batching with a maybe slow implementation, but it works.

You may want to run clippy on your branch.

Batching is deprecated so I guess this is not useful anymore


Removed duplicate slash / in source path

I noticed there's an extra / in some components/hooks source path URL, which is not good for the environment, so I removed them.

You can check it out, by hovering over the View Source Code link in this page for example

Perfect 💯


Version 0.10.0 missing on crates.io

I saw you bumped the version of picoserve to 0.10.0 yesterday and marked a release date in the changelog. However, I cannot find the new version on crates.io. Is that intentional or an oversight?

Ooops, it's an oversight. Thanks for the heads up :)


Support Go 1.18

Fix:

containerd/nerdctl#900

$ cd nerdctl
$ go mod tidy
github.com/containerd/nerdctl/pkg/dnsutil/hostsstore imports
        github.com/jaytaylor/go-hostsfile tested by
        github.com/jaytaylor/go-hostsfile.test imports
        ../go-hostsfile: "../go-hostsfile" is relative, but relative import paths are not supported in module mode

@jaytaylor Could you take a look?

This is a bug I have embedded.
I'm sorry.
@jaytaylor Can you check it out?

I'm not entirely clear, can you help me understand what the compatibility issue with newer versions of go versus pre-1.17 is?

Can you make the code changes and still retain the travis.yml support for
testing older versions of go?
On Mon, Apr 25, 2022, 21:02 Akihiro Suda @.***> wrote:

@.**** commented on this pull request.
In hosts_test.go
https://github.com/jaytaylor/go-hostsfile/pull/9#discussion_r858247477:

import (
"testing"

h "../go-hostsfile"

@jaytaylor https://github.com/jaytaylor
I'm not entirely clear, can you help me understand what the compatibility
issue with newer versions of go versus pre-1.17 is?
This form is no longer supported:
github.com/containerd/nerdctl/pkg/dnsutil/hostsstore imports
github.com/jaytaylor/go-hostsfile tested by
github.com/jaytaylor/go-hostsfile.test imports
../go-hostsfile: "../go-hostsfile" is relative, but relative import paths are not supported in module mode
—
Reply to this email directly, view it on GitHub
https://github.com/jaytaylor/go-hostsfile/pull/9#pullrequestreview-952721568,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADKLRBNOLNNFHXN4XFISJLVG5TDZANCNFSM5Q2NZCMA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you make the code changes and still retain the travis.yml support for
testing older versions of go?

Which versions have to be retained?
Go 1.16 and older versions have reached EOL and they no longer receive security updates.
https://endoflife.date/go

Alright, got you, let's get this baby merged then!
Thank you!
On Mon, Apr 25, 2022, 21:23 Akihiro Suda @.***> wrote:

Can you make the code changes and still retain the travis.yml support for
testing older versions of go?
Which versions have to be retained?
Go 1.16 and older versions have reached EOL and they no longer receive
security updates.
https://endoflife.date/go
—
Reply to this email directly, view it on GitHub
https://github.com/jaytaylor/go-hostsfile/pull/9#issuecomment-1109314818,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADKLRGKNSD3NODVGYBTW3TVG5VTXANCNFSM5Q2NZCMA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Made changes to the explanation of the 'await' keyword for async method calls.

Removed an unnecessary example as well as changed the description for the usage of the 'await' keyword. Also added an example for async method declarations.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.


atlas2parc

This should help clarify the terminology - we will simply replace all instances of atlas with parc. This is a breaking change.
We will wait until the BIDS spec defines atlas or parc as an entity https://github.com/bids-standard/bids-specification/issues/1281
(Discussed in June 4 2024 Hippo Meeting)

I don't recall what the discussion was, but replacing atlas with parc doesn't make sense to me..
Our current instances (bigbrain, multihist7) are described more clearly as an atlas rather than a parcellation.. anyways, I can't recall where we landed on this, but maybe we should close this if no action is going to be taken in the near future @jordandekraker


Update Advisor TOC.md with link to CLI documentation

Advisor recently added CLI support.  Updating the Reference section of the TOC to include a link to the CLI documentation.  I also changed the name of the 'REST' link to 'REST API' to be a bit more clear.

#sign-off

@mattwag : Thanks for your contribution to the Azure documentation! The author, @azdocprs, has been notified to review your proposed change.

Hello @mattwag
Your proposed changes to the Advisor TOC require additional input from what we normally provide for requests in the public repo. Changes such as these should be made in the private repo, as described in our Contributor Guide, see Repository conventions and best practices and Private repositories.
Please see this process to move the content to the private repo.
Thank you

#sign-off


IPv6 support

Hi, it seems that http://polyfill.io websites no longer reachable via IPv6 connections.
Is there any issue regarding IPv6 support?
Thank you.

Yes, Fastly are not yet offering ipv6 support on the new setup we had to migrate to. It is something they are working on to enable :+1:

What new Fastly offering are you using that has the issue?
The following Fastly Anycast IPv6 addresses seem to work fine when forced through my hosts file:
2a04:4e42::282
2a04:4e42:200::282
2a04:4e42:400::282
2a04:4e42:600::282

We are using their new tls certificate offering and it does not come with ipv6 addresses unfortunately

Did you specifically ask Fastly support to enable IPv6 and they said it isn't possible?
To me it seems they moved you to a customer-specific hostname. Per my experience you specifically need to ask support to enable IPv6 for those.
All Fastly CDN offerings (sans old or specific offerings/features I might not be aware of) support IPv6 and it can't be disabled. The formula with 151.101.x.y is x * 256 + y for the customer ID, which you can suffix to any of their Anycast or POP prefixes.
Having them "enable" IPv6 only does one of the following:

They manually give you the Anycast IPv6 addresses to add to DNS.
They add them to your customer-specific hostname or create a separate one.

One can calculate that and test it manually:
root@deb:~# curl https://[2a04:4e42::282]/v3/ -H "Host:polyfill.io" -k
<!doctype html>
<html class="no-js" lang="en">

<head>

                <meta charset="utf-8">
                <meta http-equiv="x-ua-compatible" content="ie=edge">
                <meta name="description" content="Polyfill.io">
                <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
...

Did you specifically ask Fastly support to enable IPv6 and they said it isn't possible?
I did, but I will ask again now 👍

Hi all, IPV6 support has been added and released to production now 🎉

While the AAAA records for polyfill.io seem to have been added, they're still unfortunately missing for cdn.polyfill.io (really polyfill.map.fastly.net).

@tambry the cdn.polyfill.io aaaa records will be going out later today 👍

@tambry we will be moving from polyfill.map.fastly.net to dualstack.polyfill.map.fastly.net.


Enhanced meshing workflow interface enhancements

I propose to make further improvements to the new, enhanced meshing workflow interface by augmenting the back-end data model and extending higher-level code to take advantage of the data model changes. Those data model changes should not affect any current definitions.
1. Representing logical parameters
The data model defines such parameters as strings because that is convenient for direct consumption into the GUI, but this is not ideal for an API. E.g.,
Current definition:
STRING: AddChild
    allowedValues = yes, no

Proposed change:
STRING: AddChild
    allowedValues = yes, no
    logicalMapping = True, False

Automatic API conversion:
LOGICAL: AddChild

There are 116 examples like this in the Meshing.fdl data model. The specifics vary; i.e. Yes/No and yes/no.
2. Representing numerical parameters
This is similar to the issue for logical parameters
Current definition:
STRING: JtLOD
    allowedValues = "1", "2", "3", "4", "5", "6", "7", "8", "9", "10"
    default = "1"

Proposed change:
STRING: JtLOD
    allowedValues = "1", "2", "3", "4", "5", "6", "7", "8", "9", "10"
    default = "1"
    isNumerical = True

Automatic API conversion:
INTEGER: JtLOD
    min = 1
    max = 10
    default = 1

3. Deactivation of Settings:
The problem here is that the workflow applications interpret the isActive attribute only to toggle GUI visibility whereas more generally it is interpreted to control availability in a more absolute sense.
Current definition:
LOGICAL: ShowVolumeMeshPreferences
    default = False
    isActive = $../ShowVolumeMeshPreferences

This can perhaps be somewhat mitigated at the API level by assuming that everything is always active, although that would not be rigorous. The application should employ a separate attribute to control GUI visibility,
Proposed change:
LOGICAL: ShowVolumeMeshPreferences
    default = False
    isVisible = $../ShowVolumeMeshPreferences

This change would require mwf team to update their GUI logic to respect the attribute name change.
4. Enumeration String Parameters
A string parameter with a fixed set of allowed values can be thought of as an enumeration. To be usable in an API, the enumerated values should be succinct.
Current definition:
STRING: SetupType
    allowedValues = "The geometry consists of only solid regions", "The geometry consists of only fluid regions with no voids", "The geometry consists of both fluid and solid regions and/or voids"
    default = "The geometry consists of only solid regions"

Proposed change:
STRING: SetupType
    allowedValues = "The geometry consists of only solid regions", "The geometry consists of only fluid regions with no voids", "The geometry consists of both fluid and solid regions and/or voids"
    default = "The geometry consists of only solid regions"
    enum = solid, fluid, fluid_solid_voids

Automatic API conversion:
STRING: SetupType
    allowedValues = solid, fluid, fluid_solid_voids
    default = solid

Current definition:
STRING: BiasMethod
    allowedValues = "_ ___ _______ _______________", "_______________ _______ ___ _", "_________ ___ _ ___ _________", "_ _____ _____________ _____ _"

Proposed change:
STRING: BiasMethod
    allowedValues = "_ ___ _______ _______________", "_______________ _______ ___ _", "_________ ___ _ ___ _________", "_ _____ _____________ _____ _"
    enum = <whatever that means>

5. Naming Issues:
Some names cannot be interpreted easily.
Current definition:
VIQualityMinAngle VI can be deduced with some effort, but is not clear enough
BlLabelList Bl stands for boundary layer, but this is BL for other settings
JtLOD
Proposed change:
Add an APIName attribute. If APIName is absent, we default to using helpString or else the item's name (essentially the same as we are doing now). This also allows us to add APIName wherever we don't like the helpString. Use snake-case values.
6.	Structuring of Data:
Current definition:
    meshing.workflow.TaskObject["Update Boundaries"].Arguments = {
        "BoundaryLabelList": ["wall-inlet"],
        "BoundaryLabelTypeList": ["wall"],
        "OldBoundaryLabelList": ["wall-inlet"],
        "OldBoundaryLabelTypeList": ["velocity-inlet"],}

Consider revising the structure to enhance API interaction patterns.
Categories of issue

Choice of data types
Structuring of argument data
Lack of separation of concerns (GUI logic in the data model)
Naming of data model items

We (@prmukherj and I) met on this topic with MH and agreed on these points. Updating the main part above.


Fix Linux Python 3.12 wheel build

The Python 3.12 on Linux wheel build process appears to need an additional libffi install. The cibuildwheel docs just happen to use yum install -y libffi-devel as an example, and that works well to solve the issue.
This makes Python 3.12 wheels work on all three platforms supported by cibuildwheel (macOS and Windows worked already).
See example run: https://github.com/alugowski/python-suitesparse-graphblas/actions/runs/6388570568/job/17338631246
(The PyPy 3.9 fails are fixed by #100)

OMFG, thanks so much @alugowski!!!
I'm sorry I just now saw these PRs. They look good to me... should we go ahead and merge all three?
Also, any thoughts on my recent PR https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/99? Can we undo this?
I was just taking a stab in the dark due to failures here:
https://github.com/GraphBLAS/python-suitesparse-graphblas/actions/runs/6385412971

Yes, I think all three are worthwhile.
I think what happened is that cibuildwheel has added some new platforms since we last went through the wheel build process, and they broke the process a little. Hence this PR; just last month they turned on Python 3.12 builds.
#100 should resolve the issue you're seeing in that Actions run. I don't think #99 broke anything because it's the same error messages I saw that prompted me to make that PR. Basically oldest-supported-numpy would fetch a numpy version that does not work with PyPy. I don't know what the best solution is, but that PR is what SciPy does so it can't be too bad. The main downside of that PR is to remember to re-enable PyPy 3.10 wheels when numpy starts supporting it in future versions. I don't know of a clean way to tell cibuildwheel to just match whatever numpy supports.
#101 is because I noticed some false workflow green checkmarks when checking into the PyPy issues, but only because the tests simply weren't run. It seems the GraphBLAS issue is fixed now and the tests pass.

If you'd like I can make a PR to use the cibuildwheel Action instead of the pip install in the current system. That way the cibuildwheel version can be managed by dependabot. It can get noisy since they release a version about once a month, but the changelog will tell you what versions they add/drop so you won't get surprised by such changes. You could run the wheel workflow for those PRs to ensure that the update doesn't break anything.

I'm happy to defer to your judgement here @alugowski, so I'll go ahead and merge all three. I do closely read the changes and your comments, b/c I want to get better at this stuff.

If you'd like I can make a PR to use the cibuildwheel Action instead of the pip install in the current system. That way the cibuildwheel version can be managed by dependabot. It can get noisy since they release a version about once a month, but the changelog will tell you what versions they add/drop so you won't get surprised by such changes.

I think we can live with this noise, and testing regularly is probably a good thing. Your call.

You could run the wheel workflow for those PRs to ensure that the update doesn't break anything.

Good idea, I need to get in the habbit of running the wheel workflows before I tag a release. Actually, can we always run wheel builds for all PRs and commits to main? These should be the fast versions of wheels with no pre-compiled types.
One more thing...
Would you like to add yourself as an author and/or maintainer to this project? I really can't express enough how much I/we appreciate your contributions :)

Good idea, I need to get in the habbit of running the wheel workflows before I tag a release. Actually, can we always run wheel builds for all PRs and commits to main? These should be the fast versions of wheels with no pre-compiled types.

That's a better idea. See #105.

One more thing...
Would you like to add yourself as an author and/or maintainer to this project? I really can't express enough how much I/we appreciate your contributions :)

Sure, it would be an honor :) What's the best way to do so?

Would you like to add yourself as an author and/or maintainer to this project? I really can't express enough how much I/we appreciate your contributions :)

Sure, it would be an honor :) What's the best way to do so?

In the [project] section of pyproject.toml, simply add yourself to "authors" and/or "maintainers".
If you want to be a "maintainer" in the metadata, I will add you to PyPI https://pypi.org/project/suitesparse-graphblas/ too. I should ask before adding you to the GraphBLAS github org to give you access to this repo, but I want to give you write access.

Would you like to add yourself as an author and/or maintainer to this project? I really can't express enough how much I/we appreciate your contributions :)

Sure, it would be an honor :) What's the best way to do so?

In the [project] section of pyproject.toml, simply add yourself to "authors" and/or "maintainers".
If you want to be a "maintainer" in the metadata, I will add you to PyPI https://pypi.org/project/suitesparse-graphblas/ too. I should ask before adding you to the GraphBLAS github org to give you access to this repo, but I want to give you write access.

Sounds good! PR to add to pyproject.toml: #108
This is my PyPI account: https://pypi.org/user/alugowski/


File does not exist

@ctcampbell can you help me pls? during the installation of "veracode_api_signing-17.0.0-py2.py3-none-any.whl" has displayed this error:
[root@srv ~]# pip install veracode_api_signing-17.0.0-py2.py3-none-any.whl
Requirement 'veracode_api_signing-17.0.0-py2.py3-none-any.whl' looks like a filename, but the file does not exist
Processing ./veracode_api_signing-17.0.0-py2.py3-none-any.whl
Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: '/root/veracode_api_signing-17.0.0-py2.py3-none-any.whl'
tks for your help!!
snk

@diegoromano , Look in the README.md because you will have to ask your contact source for the correct .whl file to be sent to you. That file you tried is for demo purposes. I am not affiliated with veracode, just another user.

I've removed this dependency now. You can also install directly from PyPi as per the readme.


[HOLD for payment 2023-10-12] [$500] Web - Request money currency search URL is case sensitive

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
. Open the app
2. Click on plus and click request money
3. Click on currency
4. Change currency value in URL to all small letters eg: change USD in URL to usd
5. Visit that URL and observe that now USD or any other currency is not selected
6. Search USD in small letters in search and observe that it works fine in search
Expected Result:
Request money currency search URL should not be case sensitive like currency search
Actual Result:
Request money currency search URL is case sensitive
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/fa1bae21-05b8-4c4f-9f45-accfae8f2fb5
https://github.com/Expensify/App/assets/93399543/5a2ccc9e-c82b-4b16-85ec-a8a6f390cf8e
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694771973390599
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01918097e3b35e3a7c
Upwork Job ID:<PHONE_NUMBER>025066496
Last Price Increase: 2023-09-16
Automatic offers:

c3024 | Contributor | 26919726
dhanashree-sawant | Reporter | 26919730

Proposal
Please re-state the problem that we are trying to solve in this issue.
Request money currency search URL is case sensitive not set the initial currency
What is the root cause of that problem?
The root cause is we compare the currencyCode and selectedCurrencyCode with case sensitive here
https://github.com/Expensify/App/blob/76c1559fb3fbee1d07c8f210b522b63edd03920e/src/pages/iou/IOUCurrencySelection.js#L97
https://github.com/Expensify/App/blob/76c1559fb3fbee1d07c8f210b522b63edd03920e/src/pages/iou/IOUCurrencySelection.js#L113
What changes do you think we should make in order to solve the problem?
we need to use toLowerCase or toUpperCase when we get the initial value here  and here
in the two places above, we need to apply this change
currencyCode.toUpperCase() === selectedCurrencyCode.toUpperCase()
// or
currencyCode.toLowerCase() === selectedCurrencyCode.toLowerCase()

What alternative solutions did you explore? (Optional)
we can also fix the search text by remove "i" from the searchRegex

Thank you all, @ahmedGaber93 and @c3024, for the proposals! 🙇🏼
Both of you correctly pointed out the root cause of the problem. After comparing your solutions, I believe the go-to should be from @c3024. This solution calculates the upper-case only once per render, not for every comparison.
Selected Proposal: https://github.com/Expensify/App/issues/27583#issuecomment-1722264133
Contributor: @c3024
🎀 👀 🎀 C+ reviewed

Assigning @c3024 :)

PR #28382 ready for review @robertKozik

@robertKozik please complete the checklist

[X]  [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: It was unsupported edge-case so no PR introduced it.
[X]  [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[X]  [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X]  [@robertKozik] Determine if we should create a regression test for this bug. I think we don't need regression test for this case
[X]  [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A


Crash on start due to JS Module Error

VS Code crashes on startup after using for a long time for editing, then closing and trying to open again. It has only been used to edit Markdown files, and the issue began when the Preview panel refused to open, thus I tried closing and opening the app. When trying to open the app is when I faced the bug.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.94.2
OS Version: Windows 11

Steps to Reproduce:

No unique steps were taken that can be reproduced; main difference would be it was being used to edit Markdown files.

During normal startup:

After trying disabling extensions on PowerShell:

App was reopened after updating to 1.95.1