Line wrapping problem in bash on ubuntu on windows

When the line is full, terminal doesn't start a new line, instead of starting at the same line and eating the chars.

VSCode Version: 1.8.1
OS Version: Windows 10 Pro Insider Preview Version 1607 Build 14986.1000

Steps to Reproduce:

Config "terminal.integrated.shell.windows": "C:\\Windows\\sysnative\\bash.exe"
Open integrated terminal
Input something long to make the line wrap

The problem magically disappeared when I restarted VS Code...

It appears to me that this only happens when maximizing the window. The point where it Incorrectly wraps is the previous width of the terminal while the window was not maximized.

Much work has happened in the next build, could you try this out again on the Insiders build?

@Tyriar I'm on 1.9.0-insider and I can confirm that it still happens there.

Not sure if this is directly related to VSCode, I found this Issue while trying to figure out why the Bash on Ubuntu on Windows was failing to properly wrap lines.  Don't believe I had this issue three weeks ago, cropped up for me in a recent Windows update.  I'm on Version 1607, OS Build 15017.1000, and am running into this bug.

I am still experiencing this issue, and it is very annoying. I'm running VS 1.9.1 on Build 14986.rs_prerelease.161202-1928. Bash on Windows does not have the line wrapping issue. Please consider prioritizing this, as it reduces the terminal's usefulness significantly.

I'm now on 1.12.0-insider and Windows build 15063.13 and the issue is still there and still very annoying. This issue is labeled as "needs more info" - what info is needed? How can I provide it to help resolving the problem?

@CherryDT you're likely seeing https://github.com/Microsoft/vscode/issues/19665 which is being looked at by another team.

I'm not so sure, because actually #19665 sounds like the same as #25133 and #25126 (causing text to shift to the left and the cursor to stay), and this problem instead causes lines to wrap before they reached the end and then overwrite the text on the same line from the left (not shifting anything and not separating the text from the cursor). Also it would appear that #19665/#25133/#25126 are triggered by specific characters or other similar things which happen inside the console, while this issue is triggered by maximizing VSCode (regardless of what happens in the console).

@CherryDT ah ok, I was wondering if this one was still happening. I assumed you were seeing the other one due to the flood of reports I was going through after Creator Update started going out.

@Tyriar OK so the question remains what "more info" is needed for you to get to the bottom of this? I will be glad to help where I can...

@Tyriar A little update, I investigated a bit more. It is not only limited to maximizing. The issue happens as soon as the window width is increased rapidly.
When I use the window border to resize it, it gets a WM_SIZE on every few pixels and this appears to work fine. However when I maximize the window or when I use the MoveWindow API to increase the window size by 50 pixels at once or so, it doesn't work and this problem starts appearing.

@CherryDT so it looks like there's 2 issues here:

The terminal is not resizing when you maximize, I would think these bugs are all squashed at this point but to check this you can try ls to see if the output expands beyond the width you're expecting. You can also inspect the terminal in devtools (Help > Toggle Developer Tools) and screenshot the DOM. I'm interested in the contents of .xterm-rows
The line isn't being wrapped, this is likely an upstream problem in https://github.com/rprichard/winpty

Hm, in fact it behaves very strangely because things like ls do expand correctly, however other things (like nano) do not. What I also found now is that opening vim fixes the problem, and so does nano (but for nano it is fixed only after it is closed again), but it's not 100% fixed because it will then still overwrite itself in some cases even though the width is fixed.
Also I noticed that after the maximizing, it can be possible to add more characters at first but then it starts wrapping and "looping" to a smaller width. All kinda hard to explain.
Here you have an illustration of what is happening: http://recordit.co/npWkMirE0r

@Tyriar Sorry forgot the devtools before - here is a screenshot: https://i.imgur.com/LeazsIQ.png

@CherryDT thanks for the follow up 😃
@rprichard any idea what's going on in the screencast/screenshot above? It looks like the terminal width is correctly bring set but there's some really weird wrapping behavior happening in WSL. AFAIK there has always been weird prompt wrapping behavior like this.

"always been weird prompt wrapping behavior": What do you mean by "always"?
The prompt wraps just fine if I start with a small width, before changing the size:

@CherryDT by always I mean since the integrated terminal was introduced, I noticed oddities like this when I was playing with WSL many months ago.

I'm able to reproduce this issue.  I see problems both with wrapping the bash command-line and with vim.  I also notice that the $LINES and $COLUMNS variables in bash aren't always updated.  I see that the variables are wrong even with the normal Windows console -- the variable represents the size of the console window (rows x cols), but it isn't updated until the console buffer size changes.  If you resize the integrated VSCode terminal vertically, $LINES won't be updated at all, because the console buffer is always fixed at 3000 lines.
Aside: winpty's window-resize code is sadly complicated because Windows doesn't provide an API that Just Works.  It provides one API that changes the window size (subject to various constraints), another API to change the buffer size (subject to other constraints), and a final API that (supposedly?) changes both, as well as a bunch of other things that applications want to change (e.g. the current text color), so winpty can't use it.
I'll dig into this more.  The fix is probably, "do something that triggers another resize notification".
...
There isn't a console input event for a changed window size, but there is one for a changed buffer size.
WINDOW_BUFFER_SIZE_RECORD.
If nothing else, I bet winpty could synthesize WINDOW_BUFFER_SIZE_RECORD events.  The most important thing about that event isn't the buffer size field, but the fact that it arrives after the window size has changed.

I created a winpty issue, https://github.com/rprichard/winpty/issues/110.

Cool, thanks for looking into it! I just wonder why it will then wrap without going to the next line...

My guess: The line-editing system (e.g. readline) thinks the terminal has advanced to a new line when it really hasn't, and maybe when readline alters a line, it redraws a whole line.  To do that, it first returns to the start of the line with CR.

Is there any ETA when this fix (which is already closed in winpty) will make it into VSCode?

I could release the next winpty version if that helps.

Cool, I hope it will aid in getting this released in VSCode soon.
By the way, is "needs more info" still applicable here?

If a winpty release goes out, provided there are no regressions this should make it into the May release.

I published winpty 0.4.3, which contains the fix for this issue.
If anyone wants to test it before VSCode updates its winpty, it should be possible by replacing the winpty.dll and winpty-agent.exe files in VSCode (in %ProgramFiles(x86)%\Microsoft VS Code\resources\app\node_modules\node-pty\build\Release) with the corresponding two files from ia32\bin of winpty-0.4.3-msvc2015.zip.  (VSCode is always a 32-bit program, even on 64-bit Windows, so you want the ia32\bin directory, not x64\bin.)
FWIW: this winpty release has fixes for three other issues that affected VSCode (arrow keys in the Ruby REPL, AltGR keys, and the 5px console font height).

Anyone experiencing the issue could you test in tomorrow's Insiders build? It seemed to work fine on my machine with the update.

VSCode Version: Code - Insiders 1.13.0-insider (f977399d58f7b64db35047fafe0c6e59e15f11d5, 2017-06-02T10:45:30.209Z)
OS Version: Darwin x64 15.6.0

Seeing this on Linux and Mac (haven't tried Windows) with the first terminal in a new window.

@chrmarti there's another issue tracking that, this one is strictly about Windows.

Looks solved for me :)

I see this in Windows in the first terminal of a new window, the width is not measured correctly but wrapping is ok. If I resize anything, it lays itself out correctly. Expected or new issue?

@roblourens I'm aware of it, and it's related to https://github.com/Microsoft/vscode/issues/20505. I don't think there's an issue yet so created https://github.com/Microsoft/vscode/issues/28138

Hello, I am running VSC Version 1.18.0 on OSX High Sierra. I am experiencing this same behavior - text overwrites the bash shell command prompt - upon having added an emoji to my command prompt. This happens no matter the window size and also on multiple terminal tabs.


(bug) web provider infinitive loop trying to connect to websocket

Observed behaviour
If evaluation apiKey is set to wrong one it enter to infinite loop while trying to reconnect.
Expected Behavior
Stops after specified amount of retries or stops immediately for this specific error (since there is not way it will be fixed).
Steps to reproduce
config eval apiKey to gff service
set wrong one on web provider

With the websocket we don't have access to the status code of the query so the only option I see is to have a max number of retries before failing.
I will open a PR for this one.


stake out - update screenshots

Replace screenshots in /docs/field/stake-out/ when https://github.com/lutraconsulting/input/issues/1948 is resolved.

should be fixed in input 1.4.0

similarly to https://github.com/MerginMaps/docs/issues/48 , we may want to wait until second half of May so we do not need to do it twice


WIP: Clean up Forward and SourceSpaces

Needs https://github.com/numpy/numpydoc/pull/415. Removes super class stuff we don't want to document.
Perhaps we want this for Info, too, but there it's not so simple because we want the methods from some subclasses but not others.

Looks much better! Still seeing some duplicated elements though; was that supposed to be fixed?

That duplication is standard, there is the list of methods then below it their actual definitions. See for example
https://mne.tools/dev/generated/mne.io.Raw.html

That duplication is standard

right, of course, sorry.  Do we merge this, or wait for the upstream numpydoc fix?


Add search command support

It is similar to cargo's install command
cargo search ripgrep

corral search jylis
corral search pony-tags

This issue isn't very helpful. It assumes that someone knows what cargo's search command does (also you seem to have copy and pasted this from another as it says similar to cargo's install command).
What does cargo's search do? How does it work? How would that translate to the pony ecosystem? Why is this needed?

I first searched through Carl's design, QA, and dep management docs here however I was unable to relocate the old issue thread that was started well before corral came to be so I do not know if some wisdom was in there.

Corral having a searching is potentially a much larger discussion than cargo having similar functionality. Cargo has the benefit of https://crates.io/ -- a central repository of Rust packages -- meanwhile Corral has no such repository to query. As such, I propose  there are two "good" options for seeing this through:

central package distribution
decentralized  package distribution

Central package distribution
Create a https://crates.io/ Pony equivalent.
Central package distribution has its benefits and Crates is certainly a strong example on how to do it well.
Distributed package distribution
Create a https://conda.io/ Pony equivalent.
Distributed package distribution has its benefits and Conda is certainly a strong example on how to do it well.

I think a corral search is best done in a distributed setting. I imagine Pony packages being shared in "channels" rather than a central repository.
First we need to have a discussion about how deep this would need to run for all the edges to line up without creating a mess. No matter how packages are distributed, eventually they need to be pulled down to a single location for ponyc to make sense of them.
I would love to see a distributed, multi-master ecosystem of Pony packages but this would take some rather serious conversation on how this is done. I have dreams of an almost CouchDB-style synchronization where as long as a server "speaks" the API it can be added to a network of potential package distributors to synchronize where a package is available from. This would be unlike Conda where if a package is not in any of the channels a user has set the pacakge is not found -- rather servers would forward requests in a decaying pattern so that, by only "searching" the central proxy, a user can perform a deep search of the Pony ecosystem. (Important to note that this has a huge potential for busy communication, cache invalidation, and many more problems with even one user who attempts the semantic equivalent of corral search --depth=Inf package-that-does-not-exist while the query bounces around the ecosystem.)
Package naming clashes would best be solved by the user where if the name is not unique in the network the user get a table of what is available and from what sources along with a short description of the package so a user can choose.

Last point I want to make, search is a potentially huge security hole. With a central server, if that server is compromised then security is breached. With decentralization, if there is a rouge server compromised in the network then security is breached. As well there are all the problems of phishing not matter what if a user is able to search, fetch, and install/compile a package with a similar name, but malicious source.

re: crates.io. see https://www.main.actor/

https://ponyhub.bali.io is a proof-of-concept of crawling and indexing Pony projects.

The Pony committers agree that search would be a great feature to add to corral, however, the hard part of this is the service that provides the search index and ability to search it.
When someone in the Pony community provides a service to that which starts to get community traction (traction as well as existence is important), then we would look to move forward with this issue.

Awesome


Removal of XML parser?

I was surprised to see the XML parser being removed , can it be put back?

@vonj It was removed becuase it was incomplete but It can be added at a future release. I primarily see JSON format for CycloneDX SBOMs with most users saying that JSON is much less problematic than XML. Note that the XML format for SPDX is still experimental with no officially released schema.

I would also be happy to see a feature to generate CycloneDX files in XML.

I would also be happy to see a feature to generate CycloneDX files in XML.

@rhaley-starfish It is on my todo list - it just hasn't made it to the top yet! However I don't see as much demand for CycloneDX XML documents as much as JSON formatted documents which is why the library has currently focused on JSON rather than XML.


add link for backup checksums documentation

This PR fixes #
Supplement requirement for creating backups with checksum by adding a link to the official documentation on how to accomplish this.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 42.359%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
29392

Relevant Lines:
64565

💛  - Coveralls

Not needed.


How to Move/Position Window Buttons on macOS?

Hey, first thanks for this great package and your effort!
How can I achieve moving the window-buttons on macOS with your plugin? I would like them to be a little bit more to the right & the bottom (see attached screenshot).

@bitsdojo would be great to get a little hint here :) thanks in advance!!

@bitsdojo You would make my day by helping me out 🙃

Hey. Try wrapping the widgets in a container and adding a margin.

I tried doing that first but unfortunately, the macOS window buttons are not part of the widget tree but added through swift/objective-c instead..

Does anybody have enough Swift/Objective-C/macOS experience to tell me how to do so manually via Xcode :) Would be awesome

This is on my list. Just need to find some time after work to implement it.

So just to confirm, the current recommended implementation is to show WindowButtons() on Linux/Windows, but on MacOS, we just leave a gap in place for the native ones to render?

@esDotDev yes, that is the currently recommended implementation.
Ability to move/position window buttons on macOS is also coming with the next update.

How long this is gonna take @bitsdojo.

waiting since months still no update .

@bitsdojo bump 💯

Any updates?
Same issue to me： https://github.com/bitsdojo/bitsdojo_window/issues/111 .
I finally solved the problem by following these steps: https://medium.com/flutter-community/transparent-title-bar-on-macos-with-flutter-7043d44f25dc

Now its working for me.

@bitsdojo any updates after 2 year ?

In case somebody is still looking for a solution, replacing the tool bar with a custom one does work for me:
import Cocoa
import FlutterMacOS
import FlutterMacOS
import bitsdojo_window_macos

class MainFlutterWindow: BitsdojoWindow {
  override func bitsdojo_window_configure() -> UInt {
    return BDW_CUSTOM_FRAME | BDW_HIDE_ON_STARTUP
  }

  override func awakeFromNib() {
    let flutterViewController = FlutterViewController()
    let windowFrame = self.frame
    self.contentViewController = flutterViewController
    self.setFrame(windowFrame, display: true)

    let customToolbar = NSToolbar()
    customToolbar.showsBaselineSeparator = false
    self.toolbar = customToolbar

    RegisterGeneratedPlugins(registry: flutterViewController)

    super.awakeFromNib()
  }
}

In case somebody is still looking for a solution, replacing the tool bar with a custom one does work for me:

in full screen it leaves a view/frame or whatever that doesn't go away


Organise & fix README

Organise in the order people usually want (e.g. description first)
Remove the top image
Add some buttons
Fix all linting issues (e.g. should use * for bullets)

Leaving here for a bit - @neelnanda-io let me know if you have any other takes (I've kept the sections you wanted now).

Looks good to me!


How to use other datasets to training?

Hi, it's me again.
If I want to use other datasets (e.g. ACDC or some private dataset) for training and testing, does the program have any other requirements for these? Are there changes need to be made to the preprocessing steps?
I tried the ACDC dataset but ACDC is 4D data, I extracted arbitrary frames but found it can't start training.

Yes, you’ll need to extract frames from 4D data. Were you able to run data
augmentation on the data?
Arjun Narayanan
On Wed, Aug 14, 2024 at 4:36 AM shihe407 @.***> wrote:

Hi, it's me again.
If I want to use other datasets (e.g. ACDC or some private dataset) for
training and testing, does the program have any other requirements for
these? Are there changes need to be made to the preprocessing steps?
I tried the ACDC dataset but ACDC is 4D data, I extracted arbitrary frames
but found it can't start training.
—
Reply to this email directly, view it on GitHub
https://github.com/ArjunNarayanan/LinFlo-Net/issues/8, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACSMYZPDRRDO5UXUEYLKFMTZRMJIPAVCNFSM6AAAAABMP3CKJ2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DKMRTGI3DMMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks for your quick reply.
I couldn‘t to use ACDC to run data augmentation.
Do I need to use the project's preprocessing code to preprocess the data before augmentation?

There’s a section in the Readme for data augmentation, did you try that?
You don’t need to do data aug to train the model, but it usually produces
better results.
Arjun Narayanan
On Wed, Aug 14, 2024 at 7:04 AM shihe407 @.***> wrote:

Thanks for your quick reply.
I couldn‘t to use ACDC to run data augmentation.
Do I need to use the project's preprocessing code to preprocess the data
before augmentation?
—
Reply to this email directly, view it on GitHub
https://github.com/ArjunNarayanan/LinFlo-Net/issues/8#issuecomment-2288457906,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACSMYZKRYCVDWSECV3UZCNDZRM2UDAVCNFSM6AAAAABMP3CKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBYGQ2TOOJQGY
.
You are receiving this because you commented.Message ID:
@.***>

I have tried the MMWHS dataset to data augmentation and I have trained the model with MMWHS.
Now I want to use other dataset but I meet some problems.
One more thing, I find the ACDC images' view is a little different with MMWHS's, will this work rightly?

Yes the view matters so I would try to get the ACDC images consistent with
what you see in MMWHS.
Arjun Narayanan
On Wed, Aug 14, 2024 at 8:41 AM shihe407 @.***> wrote:

I have tried the MMWHS dataset to data augmentation and I have trained the
model with MMWHS.
Now I want to use other dataset but I meet some problems.
One more thing, I find the ACDC images' view is a little different with
MMWHS's, will this work rightly?
—
Reply to this email directly, view it on GitHub
https://github.com/ArjunNarayanan/LinFlo-Net/issues/8#issuecomment-2288637445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACSMYZL7SLHU4UGUXAN2VILZRNGARAVCNFSM6AAAAABMP3CKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBYGYZTONBUGU
.
You are receiving this because you commented.Message ID:
@.***>

Thank you, I also tried but found it difficult to align the MMWHS perspective with the ACDC perspective.
Thanks for your trying.


Update the MSRV to 1.65 and remove MIPS from CI.

The code uses cast_mut, which was introduced in Rust 1.65, so bump the MSRV to Rust 1.65.
Also, Rust Nightly does not currently have MIPS builds, so remove MIPS from CI for now.

@jordanisaacs Would you be able to take a look at this?

@jordanisaacs I have some projects I'm exploring using this crate for, however they need this crate to be updated. Would you be open to adding me as a maintainer of this crate?

@sunfishcode I merged your commits and also added you as a maintainer/invited you to the crates.io. Currently have been to busy to keep it updated but still interested in its future as pure rust programs/io_uring are still topics of interest to me. so thanks!


Blocker: Form field is in view only when I start typing on keyboard and not on focus; keyboard takes over the form when tap on field, Ionic 3.7.1

Ionic version:
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ...
[x] bug report
[ ] feature request
Current behavior:
Form field is in view only when I start typing on keyboard and not on focus; keyboard takes over the form when tap on any field;
Expected behavior:
The focused field should be in view and scrolled automatically and forced to manually scrolled
Steps to reproduce:

Ionic info: :
cli packages:

    @ionic/cli-utils  : 1.12.0
    ionic (Ionic CLI) : 3.12.0

global packages:

    cordova (Cordova CLI) : 7.0.1

local packages:

    @ionic/app-scripts : 3.0.0
    Cordova Platforms  : android 6.2.3 ios 4.4.0
    Ionic Framework    : ionic-angular 3.7.1

System:

    Android SDK Tools : 25.2.5
    ios-deploy        : 1.9.1
    ios-sim           : 5.0.8
    Node              : v6.11.3
    npm               : 3.10.10
    OS                : macOS Sierra
    Xcode             : Xcode 8.3.3 Build version 8E3004b

Misc:

    backend : legacy

I have used below but no help:
IonicModule.forRoot(MyApp, {
            scrollPadding: false,
            scrollAssist: true,
            autoFocusAssist: false

    })

Happens to me too. Somehow the scrollassist code in ionic-angular for ion-input component is not working properly. I fixed it by fixing the source code in ionic-angular/component/input/input.js in my working copy. I will be submitting a pull request soon and see if it can fix this issue for everyone else. No guarantee though.


Documentation and expanded readme

As per the upcoming assignment requirement I'd like to expand the README with information about downloading releases and running them on different platforms.
We're also required to create a documentation about our app and how to use it, Because we are still working on new features, I'll only merge the associated branch once we are ready to submit the assignment.
I'd also like to ask someone owning a windows machine to try running one of the releases using the ELME.bat file.

Works like a charm on my Win10


[CUR-453] Added fieldset/legend to group thread/year radio buttons in curriculum unit sequence page

Description
Added <fieldset/>/<legend/> to group thread/year radio buttons in curriculum unit sequence page improving the accessibility.
We've also added a new <SimpleRadio/> as the existing radio input components don't play well with a <fieldset/>
Issue(s)
CUR-453
How to test

Go to https://deploy-preview-2504--oak-web-application.netlify.thenational.academy/teachers/curriculum/science-secondary-edexcel/units (any subject applicable)
Use voice over to check accessibility of the page

:tada: This PR is included in version 1.463.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Forward HTTPS request

It would be better to indicate that SF ReverseProxy could only forward HTTPS request when itself is configured with HTTPS.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e634b7f-2c67-2081-7bc1-f4bcc18ae50c
Version Independent ID: dcbaae68-ea97-0972-f021-e1520430f2ea
Content: Azure Service Fabric reverse proxy secure communication - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-reverseproxy-configure-secure-communication.md
Service: service-fabric
GitHub Login: @kavyako
Microsoft Alias: kavyako

@lilx-ms


feat: add dependency analyzer for Gradle

This PR refactors the build tools and dependency analyzer and adds a feature to automatically detect Gradle dependencies and map them to their SCM repositories.
As part of the refactoring, this PR also fixes related issues to dependency analyzer and adds back two skipping dependencies.
For now the integration test for Gradle dependency analysis is disabled due to a non-deterministic behavior of CycloneDX Gradle plugin. This issue will be addressed separately in https://github.com/oracle-samples/macaron/issues/60.

@tromai addressed comments in 78c34e891acd6ede6c5bfad51a2405eef43e4283.

@tromai addressed comments in b72bde3

LGTM


mxx:bcast

Currently there's no corresponding function for MPI_Bcast in mxx.

this was implemented a while ago


Ambiguos redirection on nutanix-guest-tools-reporting-v_1.0.sh

on bash (GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu) the redirection of output to $file return the error "$file: ambiguous redirect" and doesn't write to file
use double quota  "$file" to fix

Ok, thanks for letting me know. "" works on MacBook as well, where I tested without the "" so I'll change and upload a new version.

Great job! i continue the testing.... ;D


If you rename a file in the db and drop it in the view, old name is displayed

(in the layers settings toolbox and in the view)
After closing the app, good name is displayed.

Hum, not on my computer @LoicCadour. Strange!


How does namingFunction in Constructor exactly work?

Hello,
I am using the latest Meteor build (v1.7) with Ostrio:Files. Everything is running great, but I have troubles understanding how exactly are the files named using the namingFunction.
I used a simple naming function, which reads:
namingFunction(file){
        return file.name;
    }

However, the physical file.name doesn't get saved correctly:
instead of expected P1320985.jpg, I am getting this P1320985-jpg.jpg
I would like to know how exactly does the namingFunction work, so that I can save the uploaded file with the following name composed of: objectid_in_database + original_filename + extension? I tried looking for an example but couldn't find any.
Many thanks for your help!

@dr-dimitru Thank you very much for your answer Dimitru, it helped a lot.


Connect-by-name has no vpiHighConn

module sub (
  input logic clk,
  input logic data_in,
  output logic data_out
);
endmodule

module test;

logic clk;
logic data_in_wire;
sub sub_i (
  .clk,
  .data_in (data_in_wire),
  .data_out (/* no connect */)
);

endmodule

Dumping the UHDM for that shows this (instance only):
  |vpiRefModule:
  \_ref_module: work@sub (sub_i), line:12:5, endln:12:10
    |vpiParent:
    \_module_inst: work@test (work@test), file:/home/pieter/work/pieter3d/simview/build/test.sv, line:8:1, endln:18:10
    |vpiName:sub_i
    |vpiDefName:work@sub
    |vpiActual:
    \_module_inst: work@sub (work@sub), file:/home/pieter/work/pieter3d/simview/build/test.sv, line:1:1, endln:6:10
    |vpiPort:
    \_port: (clk), line:13:3, endln:13:7
      |vpiParent:
      \_ref_module: work@sub (sub_i), line:12:5, endln:12:10
      |vpiName:clk
    |vpiPort:
    \_port: (data_in), line:14:3, endln:14:26
      |vpiParent:
      \_ref_module: work@sub (sub_i), line:12:5, endln:12:10
      |vpiName:data_in
      |vpiHighConn:
      \_ref_obj: (work@test.sub_i.data_in.data_in_wire), line:14:13, endln:14:25
        |vpiParent:
        \_port: (data_in), line:14:3, endln:14:26
        |vpiName:data_in_wire
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_net: (work@test.data_in_wire), line:11:7, endln:11:19
    |vpiPort:
    \_port: , line:15:3, endln:15:31
      |vpiParent:
      \_ref_module: work@sub (sub_i), line:12:5, endln:12:10

So at least two things look wrong to me:

There appears to be no connection to clk but it's a valid connect-by-name construct
The floating data_out output is totally missing, the port has a blank name.

pieter3d this is working just fine:
|uhdmtopModules:
\_module_inst: work@test (work@test), id:61, file:/home/alain/Surelog/tests/ScratchPad.sv, line:8:1, endln:18:10
  |vpiName:work@test
  |vpiVariables:
  \_logic_var: (work@test.clk), id:7, line:10:7, endln:10:10
    |vpiParent:
    \_module_inst: work@test (work@test), id:61, file:/home/alain/Surelog/tests/ScratchPad.sv, line:8:1, endln:18:10
    |vpiTypespec:
    \_ref_typespec: (work@test.clk), id:8
      |vpiParent:
      \_logic_var: (work@test.clk), id:7, line:10:7, endln:10:10
<EMAIL_ADDRESS>      |vpiActual:
      \_logic_typespec: , id:6, line:10:1, endln:10:6
    |vpiName:clk
<EMAIL_ADDRESS>    |vpiVisibility:1
  |vpiVariables:
  \_logic_var: (work@test.data_in_wire), id:10, line:11:7, endln:11:19
    |vpiParent:
    \_module_inst: work@test (work@test), id:61, file:/home/alain/Surelog/tests/ScratchPad.sv, line:8:1, endln:18:10
    |vpiTypespec:
    \_ref_typespec: (work@test.data_in_wire), id:11
      |vpiParent:
      \_logic_var: (work@test.data_in_wire), id:10, line:11:7, endln:11:19
<EMAIL_ADDRESS>      |vpiActual:
      \_logic_typespec: , id:9, line:11:1, endln:11:6
    |vpiName:data_in_wire
<EMAIL_ADDRESS>    |vpiVisibility:1
  |vpiDefName:work@test
  |vpiTop:1
  |vpiTopModule:1
  |vpiModule:
  \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
    |vpiParent:
    \_module_inst: work@test (work@test), id:61, file:/home/alain/Surelog/tests/ScratchPad.sv, line:8:1, endln:18:10
    |vpiName:sub_i
<EMAIL_ADDRESS>    |vpiDefName:work@sub
    |vpiDefFile:/home/alain/Surelog/tests/ScratchPad.sv
    |vpiDefLineNo:1
    |vpiNet:
    \_logic_net: (work@test.sub_i.clk), id:22, line:2:15, endln:2:18
      |vpiParent:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
      |vpiTypespec:
      \_ref_typespec: (work@test.sub_i.clk), id:23
        |vpiParent:
        \_logic_net: (work@test.sub_i.clk), id:22, line:2:15, endln:2:18
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_typespec: , id:21, line:2:9, endln:2:14
      |vpiName:clk
<EMAIL_ADDRESS>      |vpiNetType:36
    |vpiNet:
    \_logic_net: (work@test.sub_i.data_in), id:25, line:3:15, endln:3:22
      |vpiParent:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
      |vpiTypespec:
      \_ref_typespec: (work@test.sub_i.data_in), id:26
        |vpiParent:
        \_logic_net: (work@test.sub_i.data_in), id:25, line:3:15, endln:3:22
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_typespec: , id:24, line:3:9, endln:3:14
      |vpiName:data_in
<EMAIL_ADDRESS>      |vpiNetType:36
    |vpiNet:
    \_logic_net: (work@test.sub_i.data_out), id:28, line:4:16, endln:4:24
      |vpiParent:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
      |vpiTypespec:
      \_ref_typespec: (work@test.sub_i.data_out), id:29
        |vpiParent:
        \_logic_net: (work@test.sub_i.data_out), id:28, line:4:16, endln:4:24
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_typespec: , id:27, line:4:10, endln:4:15
      |vpiName:data_out
<EMAIL_ADDRESS>      |vpiNetType:36
    |vpiInstance:
    \_module_inst: work@test (work@test), id:61, file:/home/alain/Surelog/tests/ScratchPad.sv, line:8:1, endln:18:10
    |vpiPort:
    \_port: (clk), id:63, line:2:15, endln:2:18
      |vpiParent:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
      |vpiName:clk
      |vpiDirection:1
      |vpiHighConn:
      \_ref_obj: (work@test.clk), id:64, line:13:4, endln:13:7
        |vpiParent:
        \_port: (clk), id:63, line:2:15, endln:2:18
        |vpiName:clk
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_net: (work@test.sub_i.clk), id:22, line:2:15, endln:2:18
      |vpiLowConn:
      \_ref_obj: (work@test.sub_i.clk), id:65, line:13:4, endln:13:7
        |vpiParent:
        \_port: (clk), id:63, line:2:15, endln:2:18
        |vpiName:clk
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_net: (work@test.sub_i.clk), id:22, line:2:15, endln:2:18
      |vpiTypedef:
      \_ref_typespec: (work@test.sub_i.clk), id:66
        |vpiParent:
        \_port: (clk), id:63, line:2:15, endln:2:18
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_typespec: , id:13, line:2:9, endln:2:14
      |vpiInstance:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
    |vpiPort:
    \_port: (data_in), id:67, line:3:15, endln:3:22
      |vpiParent:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
      |vpiName:data_in
      |vpiDirection:1
      |vpiHighConn:
      \_ref_obj: (work@test.data_in_wire), id:68, line:14:13, endln:14:25
        |vpiParent:
        \_port: (data_in), id:67, line:3:15, endln:3:22
        |vpiName:data_in_wire
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_var: (work@test.data_in_wire), id:10, line:11:7, endln:11:19
      |vpiLowConn:
      \_ref_obj: (work@test.sub_i.data_in), id:69, line:14:4, endln:14:11
        |vpiParent:
        \_port: (data_in), id:67, line:3:15, endln:3:22
        |vpiName:data_in
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_net: (work@test.sub_i.data_in), id:25, line:3:15, endln:3:22
      |vpiTypedef:
      \_ref_typespec: (work@test.sub_i.data_in), id:70
        |vpiParent:
        \_port: (data_in), id:67, line:3:15, endln:3:22
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_typespec: , id:16, line:3:9, endln:3:14
      |vpiInstance:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
    |vpiPort:
    \_port: (data_out), id:71, line:4:16, endln:4:24
      |vpiParent:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3
      |vpiName:data_out
      |vpiDirection:2
      |vpiHighConn:
      \_operation: , id:72, line:15:30, endln:15:31
        |vpiParent:
        \_port: (data_out), id:71, line:4:16, endln:4:24
        |vpiOpType:36
      |vpiLowConn:
      \_ref_obj: (work@test.sub_i.data_out), id:73, line:4:16, endln:4:24
        |vpiParent:
        \_port: (data_out), id:71, line:4:16, endln:4:24
        |vpiName:data_out
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_net: (work@test.sub_i.data_out), id:28, line:4:16, endln:4:24
      |vpiTypedef:
      \_ref_typespec: (work@test.sub_i.data_out), id:74
        |vpiParent:
        \_port: (data_out), id:71, line:4:16, endln:4:24
<EMAIL_ADDRESS>        |vpiActual:
        \_logic_typespec: , id:19, line:4:10, endln:4:15
      |vpiInstance:
      \_module_inst: work@sub (work@test.sub_i), id:62, file:/home/alain/Surelog/tests/ScratchPad.sv, line:12:1, endln:16:3

You need to look at the elaborated tree

Are you sure that's right? the port "clk" has both the the HighConn and LowConn vpiActual as the inner net of the sub module -<EMAIL_ADDRESS>But data_in has HighConn as<EMAIL_ADDRESS>(the net in the top) and LowConn as<EMAIL_ADDRESS>the net in the submodule.

So either the elaborated module gets replaced, or I am not looking at the right elaborated tree somehow. I don't think the High_conn itself is getting overwritten later, based on some debug prints and watching addresses in a debugger, but I am not 100% sure.
So - not quite sure yet where the issues lies.

Ok, making some progress. The High_conn's Actual_group is getting overridden when UHDM is being written out. This is either a bug in UHDM, or a bug in how it's being used.
Culprit line: https://github.com/chipsalliance/UHDM/blob/b918b5d5c82cfbaf71e04f87ab69fc7e182e41aa/templates/ElaboratorListener.cpp#L907
During write-out, if the net name matches any local nets, it gets replaced.

The instStack_ has to be popped temporarily while binding high_conn so is skips the current module scope.

Yeah that's kinda what I figured, but the Listener classes need some new state to know to do that, i.e. when they are processing a High_conn

Set a bp in the bind function, check the stack, you should see the high conn relation traversal, the python code generator in scripts/ needs to change to pop and push back the context before and after the traversal of that particular relation

Yes, but that's all c++ code... Where does python come into this?

Most of the C++ code is auto generated by Python


count and max_entries parameters need to be passable to init method of all classes that inherit from Search

Right now there are some subclasses of Search that don't have a count or max_entries parameter. For example, ScopusSearch automatically sets max_entries to 5,000 and count to either 25 or 200, depending on the value of view (see code snippet below). This is problematic b/c the 5,000 document limit no longer applies to Scopus subscribers, but subscribers are nevertheless still forced to use 5,000 as max_entries b/c it's hard-coded in the constructor. Meanwhile, non-subscribers can't use ScopusSearch b/c they only have access to the "Standard" view, which means that count is set to 200 in the __init__() method (resulting in an error b/c their access level requires that count be <= 25  - https://dev.elsevier.com/api_key_settings.html).
https://github.com/scopus-api/scopus/blob/d8791c162cef4c2f830d983b435333d9d8eaf472/scopus/scopus_search.py#L143-L148

Also, happy to work on a PR for this

Oh, this is wonderful news! The 5k cap always annoyed me. Also, there must have been changes behind the scenes, both on the architecture and the documentation.
So, it's the max_entries that we need to purge and the count that we need to make less restrictive, right?
Probably we should also remove the default for the view: It would become more flexible as it caters to both subscribers and non-subscribers.
A PR would be amazing! In the meantime I'd update the documentation.

Actually, you can just  modify the "search" class to use the new "cursor" parameter instead of "start" and "count". I'll find some time this week to arrange my code for sharing. It is completely free of record count limitations and I've used it for some time now and it seems to work

Yes, that would be amazing, from one of the two of you. This and the next week I am completely unavailable.

Hi @Michael-E-Rose , I think you're going to want to keep the max_entries param in the Search class, but add that param to ScopusSearch to address the issue I mentioned. The reason why you want to keep max_entries is b/c non-subscribers still have a 5,000 doc limit, so you'll want to have a check that max_records isn't exceeded for them. The count param is a little different. My first thought was to deprecate count by making the default value be None, and throwing a warning whenever the user specifies a none-None value for it, saying something along the lines of "we're no longer passing the count param to the API. Rather, the default value for count will be used depending on your access level" or something like that.

Opps, meant to address that last comment to @gilad1bl . @Michael-E-Rose , I noticed you assigned this issue to yourself. Were you or @gilad1bl planning on putting together a PR for this? If not, I'd be happy to give it a shot.

Hey, @crew102  and @Michael-E-Rose !
Just sent a PR - hope its good enough to use.
Though I've played it cool so far, this is my first real GitHub contribution so thanks for the motivation!

Hey @gilad1bl , as far as I can tell your PR simply uses a different way to iterate over an entire result set (i.e., it uses a cursor instead of using the start parameter). Unfortunately this won't solve the issues mentioned in this thread. I would suggest you open up a separate issue for refactoring scopus to use a cursor param, as it's not quite related to the max_entries and count issues discussed here (though its still probably a good idea).

@crew102  thanks! as far as I can tell, this is the only way to iterate over a set of results that contains more than 5,000 entries. using the start parameter would result in an error from Elsevier's side if it is set to more than 5,000. Am I wrong?

I'm not entirely sure what would happen if you set the start parameter to above 5,000. It definitely should throw an error if you're not a Scopus subscriber, as only subscribers can download result sets larger than 5,000 (trying to download these large result sets with a cursor parameter for non-subscribers would throw an error too). For subscribers (i.e. those users that have a paid subscription), I image that the API doesn't care if you use the start or cursor parameter to iterate over large result sets, though I think the scopus package should be using a cursor parameter since the API docs started to recommend it.

The university I work from is a paid subscriber and I get errors trying to use start that is over 5,000. You are right though, that it does not completely address the issue that you raised. Do you want me to try and add the option to pass start and count directly?

Ah, you're right, start can't be above 5,000, regardless of the user's access level. But yes, I'd be great if you could add the option to pass count and max_entries in ScopusSearch and other classes that inherit from Search (I guess you could add the option to pass in start as well, though note the first item below). A few things:

There are a ton of parameters like start that could theoretically be passable to the APIs (e.g., take a look at the parameters you can pass to the Search API - https://dev.elsevier.com/documentation/ScopusSearchAPI.wadl). For a more general solution, the scopus package may want to consider using **kargs instead of specifying all of these parameters one by one. In other words, it may be better to pick a few of the most important parameters like query and make those explicit parameters in the classes, but allow the user to pass in arbitrary keyword args using the **kargs parameter.
I would keep an eye on making sure any change you make in the parameters is backwards compatible, so it doesn't break people's code.
If you'd want to take a shot at a PR for this issue, I would suggest keeping it seperate from your existing PR. In other words, I would suggest opening a new PR for "refactoring API parameters."

Good evening guys!  I couldn't follow your discussion until now.  I thank both of your for the all the contributions, much appreciated!
I agree with @crew102 that backwards compatibility is key.  Also, there should be a more flexible approach to the Search classes (via kwargs) for the more experienced users. Also, I think we don't need the max_entries in the search class as a pre-capture: There will be an error anyways.  The pre-capture as introduced very early and should be deprecated.
However I have not fully understood how the cursor works.  Should it completely replace start and end?  Can you please enlighten me?
PS: The fact that I am assigned just means that I, and not John, will be responsible for this issue.

K, a few things here:

I agree with @crew102 that backwards compatibility is key.

K, we'll need to keep all params that exist in the classes (even if they won't be used) to achieve backwards compat, at least in the short term. Do you have a a preferred pattern for deprecating paramters? For example, let's say we want to deprecate the start parameter, how do you want to go about doing that? My first thought is to follow the pattern used in scikit-learn, where we would first soft-deprecate the parameter in the next few releases of the package and then later remove that param completely in future versions. The user would get a warning in the next release if they use a deprecated param. For example, take a look at these code snippets that should how pooling_func was deprecated:
https://github.com/scikit-learn/scikit-learn/blob/7b136e92acf49d46251479b75c88cba632de1937/sklearn/cluster/hierarchical.py#L753-L756
https://github.com/scikit-learn/scikit-learn/blob/7b136e92acf49d46251479b75c88cba632de1937/sklearn/cluster/hierarchical.py#L780-L784

Also, there should be a more flexible approach to the Search classes (via kwargs) for the more experienced users.

K, I can add this functionality. Will the Retrieval classes need this as well? If so, let's put that on the back-burner and concentrate on Search classes for now.

Also, I think we don't need the max_entries in the search class as a pre-capture: There will be an error anyways. The pre-capture as introduced very early and should be deprecated.

I actually think we want to keep the ability to error when the results exceed some user-defined threshold like max_entries. For example, consider this hypothetical situation that could occur if max_entries is totally removed: A non-subscriber calls ScopusSearch and their query results in 10,000 entries (i.e., 10,000 entries match their query). ScopusSearch then starts downloading the data and when it gets up to 5,000 entries downloaded the API throws an error saying "you've exceeded the amount your can download in a single result set." The user had to A) wait a long time to realize that they can't actually get all the results b/c the API won't throw that error immediately and B) they've now eaten up 5,000 of the 20,000 of their weekly download limit (https://dev.elsevier.com/api_key_settings.html). It would be a lot better if we could avoid this situation by just erroring after a check on max_entries is performed. I suggest we keep the default value of max_entries equal to 5,000 but allow the user to set max_entries=None, which would basically amount to not performing the check that max_entries is not exceeded.

However I have not fully understood how the cursor works. Should it completely replace start and end?

I'll add some more thoughts on this in #87.

Deprecation: Yes, the way sklearn is doing this is quite good. We are already following a similar approach: https://github.com/scopus-api/scopus/blob/master/scopus/scopus_search.py#L9 or https://github.com/scopus-api/scopus/blob/master/scopus/abstract_retrieval.py#L577. In version 2.0, everything that has a future deprecation warning will be removed.

kwds: Maybe we can do this first in a separate PR. It's relatively easy to implement and does not depend on other issues. I think the retrieval classes don't need this, because they do not have header params that we are not already using.

Many results: I am 75% sure that an error of having to many results comes immediately, i.e. on the first run where we try to get the number of results: https://github.com/scopus-api/scopus/blob/master/scopus/classes/search.py#L82. We should verify this. If not, and the error is thrown only when we reach the end of the search results, then we still need that parameter. We could implement it in two ways: We define a global variable equal to 5000. A new boolean parameter, that non-subscribers should set to True, will check that the number of results is less than or equal to that global variable. Alternatively, we keep it the way it is, but set it to None as default.

I implemented the kwds-functionality for ScopusSearch via d7f203ada237ebf6f6312359982a3f3fe4f53f51 because it was a quick thing to do. I did so only for the ScopusSearch class because the other two searchers classes don't have fields that are not already implemented and which at the same time could be used w/o breaking the code.
A quick testing showed no difference in the number and kind of results returned, though.

Hey @Michael-E-Rose , I was thinking that **kwds would be used for the query params, not the header. There are potentially a lot of query params that the user may want to specify - https://dev.elsevier.com/documentation/ScopusSearchAPI.wadl

Yes you are right, I put it in the wrong dictionary.  d079f93be99102a9d649035587521ab8c24f2f0c fixes this: ScopusSearch now features keywords that go in to the query parameters.
I am testing a bit more now.

To me this issue seems resolved.
ScopusSearch() uses the cursor for subscribers and the count-check for non-subscribers, AuthorSearch() and AffiliationSearch() will deprecate their max_entries and start parameters.
Thanks to both of you!


Improve debugging experience

Make last log be rotated so we can have the previous run log be saved.
Made dev environment use portable config mode!

What? FileHandler already keeps 2 logs, if you need more you can just increase the number.


Deleting Embedded entities doesn't trigger changes in Instance composer

deleting embedded entities doesn't get recognize as an update by the composer (doesn't trigger isDirty, and won't trigger proper behaviour in deploying)


New GPT 774M model + TPU

They released a new model - https://openai.com/blog/gpt-2-6-month-follow-up/
And I think we will need TPU to use that model.
I'm trying to use the 345M with TPU using Colab, but when I change to TPU the code uses CPU.

Hey there, thanks for the issue. I'll look into bringing the 774M model onboard. Will keep you updated.
Cheers

Hello there! gpt2-client is now compatible with the 774M model! Thank you so much for waiting :)


Begin migration of bonnyci.org to using .bonnyci/run.sh

This is the first step in moving the actual test execution out of hoist's
zuul layout and into the repo.  A follow up patch will need to land in
hoist to update the project to run the bonnyci-run-check/gate jobs instead
of bonnyci.org tests.

Build failed.

http://logs.bonnyci.com/check_github/BonnyCI/bonnyci.org/5/1486590273.89/bonnyci.org : FAILURE in 24s

gate-recheck


Update bug-report.yml

As I'm no longer actively working on optimum, perhaps it makes sense to remove me from the default issue tags?
Of course, happy to help if something in particular is needed on my end!
What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Actually we should update this list since we have TFLite also now.


influx v0.9rc32, regression, restore/backup command not found and version is not correcty displayed

Updated the latest rc32 available on download page for debian
in rc31
/opt/influxdb/influxd version
[srvr] 2015/06/07 13:24:00 InfluxDB v0.9.0-rc31 (git: 8ade485b5865e642b128a7cc6eb20c9da73d1b48)

In rc32
/opt/influxdb/influxd version
InfluxDB v0.9 (git: unknown)

For the restore command ( also backup command is the same)
In rc31:
/opt/influxdb/influxd restore
2015/06/07 13:27:40 influxdb restore, version 0.9.0-rc31, commit 8ade485b5865e642b128a7cc6eb20c9da73d1b48
[srvr] 2015/06/07 13:27:40 No config provided, using default settings
[srvr] 2015/06/07 13:27:40 restore: snapshot path required

In rc32
/opt/influxdb/influxd restore
unknown command "restore"
Run 'influxd help' for usage

@dtouzeau backups will be re-enabled in the next release. you can track #2812 for the status of that. i've renamed this issue to track the missing version info.

@dtouzeau This is fixed with #2842 and will be included in RC33 - thanks!


Turbulence model

This update add the turbulence model based on Suganami paper (Suganami, T., & Szeri, A. Z. (1979). A thermohydrodynamic analysis of journal bearings).

Hi @elyqg.
Tests were not running for previous commits. Don't know exactly what was the error here on github.
After running the tests, we have some errors:
======================================== short test summary info =========================================
FAILED ross/fluid_flow/cylindrical.py::ross.fluid_flow.cylindrical.THDCylindrical
ERROR ross/tests/test_cylindrical.py::test_cylindrical_parameters - AttributeError: 'THDCylindrical' ob...
ERROR ross/tests/test_cylindrical.py::test_cylindrical_equilibrium_pos - AttributeError: 'THDCylindrica...
ERROR ross/tests/test_cylindrical.py::test_cylindrical_coefficients - AttributeError: 'THDCylindrical' ...
============== 1 failed, 440 passed, 2 skipped, 414 warnings, 3 errors in 111.09s (0:01:51) ==============

Hi @raphaeltimbo. I will check the tests files.

Hi @elyqg and @marcusfilipesr Thank you for fixing the tests. My only comment is regarding the main.py file in the project folder. Could you please remove it before we merge the PR? Thanks

Good morning @raphaeltimbo,
We'll do this right away.


Remove ref to box-cutter/* images in .kitchen.yml

These boxes no longer exist, and kitchen now just takes the OS version and downloads a standard opscode box.
I verified that it is able to map a url for each box, happy to run a full converge once I finish up some other things.

These boxes do exist and are updated regularly. https://atlas.hashicorp.com/boxcutter/

Hum, when I run something like 'kitchen converge openjdk-ubuntu-1404', it says it can't find the image, and downloads an opscode image for ubuntu 14.04:
juryan@paradox:~/src/bitmonk/chef-java$ kitchen converge openjdk-ubuntu-1404
-----> Starting Kitchen (v1.4.0)
-----> Creating ...
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Box 'box-cutter/ubuntu1404' could not be found. Attempting to find and install...
default: Box Provider: virtualbox
default: Box Version: >= 0
==> default: Adding box 'box-cutter/ubuntu1404' (v0) for provider: virtualbox
default: Downloading: https://opscode-vm-bento.s3.amazonaws.com/vagrant/virtualbox/opscode_ubuntu-14.04_chef-provisionerless.box
It stll works, though, this is just something I've run into with a number of projects, if you pref that it stays, I was just trying to help. :)


Update TS definitions

Adds TS definition for getParts and new overload for req.getQuery  added in v18.7.0.
I've noticed that previous updates to index.d.ts didn't make it to the binaries branch and was thinking about adding it to copy_files in build.c, but I also see that you usually copy these files manually so :shrug:
Should I also regenerate HTML docs?

Hey @alexhultman, what do you think about automating the step of copying index.d.ts? The new version was published and it still contains old version of the file. I think it would be better to make it automatic, unless there's a reason why you prefer to copy those files manually.

Sure, there's no reason


fix(electrumx.getBalance()): Allowing ecash addresses to pass through

:tada: This PR is included in version 2.3.7 :tada:
Your semantic-release bot :package::rocket:


Volsync short vars

Do the  namespace env vars in *.tmpl.yaml files  need to be changed to ns to keep up with the change to short variable names in the Volsync taskfile?

Thanks for pointing that out, I updated it here
https://github.com/onedr0p/home-ops/commit/d62807fd56083544f4662ee33d2583a142f2042c


#899 page designed

closes #899

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.

@MonalikaPatnaik please review this one

LGTM !
However, you could align the text and image to center of the page and place the paragraph This page is currently under development. Please check back later above the image and below the heading Umatter development.
Also, you could redirect this page to Careers, Investors and Terms of Services in footer section.

Okay will do the needful

@MonalikaPatnaik now check
done everything you said
also i can design the careers and other pages for your project
you can give me some reference website and i will do the needful
Do let me know :)

@MonalikaPatnaik now check done everything you said
also i can design the careers and other pages for your project you can give me some reference website and i will do the needful Do let me know :)

Yes sure..if u could find something good, you could raise a new issue and share the link/ss/video of the same..If we find it good, will assign it to you!


Doubt in logic of metrics exporting

Hi Luke,
Correct me if am wrong, for metrics collection using az monitor command we have option to look back for max 30/90 days to analyse utilisation.
Then why we are exporting daily utilisation to log analytics workspace and analysing average utilisation using kql and variable (look back period).

Hi @rasselmaliyekkal. Metrics are being ingested into Log Analytics so that we can 1) easily correlate, with a single KQL query, metric data with other dimensions, such as cost and resource properties, and 2) easily present graphical evidence supporting the recommendation at the tip of a link to a KQL query.


Updated README.md

added Haptik to list of apps using FLAnimatedImage

Not going to merge this for now since it's an outdated PR. Feel free to create a new PR if you still want to do it.


Risen 3 - random black flicker

The whole screen sometimes turns black for a few milliseconds, seems to happen rather randomly when moving the camera or walking around.
I've noticed that sometimes the volumetric fog volumes or fog shadows show some "popping" with native D3D9, maybe there is a corelation (well, or maybe not ;) )?
The black flicker though only occurs with D9VK (with any AMD driver).
D9VK log:
Risen3_d3d9.log
Windows D3D9 apitrace:
https://drive.google.com/open?id=1mJEY-ZjNyGWxFI6pAR5-3b7uNQwvwfdK
D9VK RenderDoc capture:
https://drive.google.com/open?id=1kdx3rph61M8Zwc4gbBCtFc-nm4RHn_5H

That's weird.
So you made the apitrace with Windows D3D9.
When I now use Windows D3D9 to replay it, it shows the issue.
Sorry but I just gotta ask: are you sure you made that trace with Windows D3D9?
Otherwise this may just be a weird game bug. Although I dont remember seeing this when I played throught the game on Windows.

I let it create the apitrace by throwing the d3d9.dll into its folder on Windows, so it's basically impossible that D9VK was used. ;)
If I recall it correctly, the issue isn't there either with wined3d. Will recheck.

As expected, no random black flicker with wined3d.

The flicker/flashing can also be white. Perhaps this indicates an issue with the eye adaptation shader?

I didn't see flicker when replaying with Windows D3D9, saw some broken geometry. I'm gonna take another look at this.

I'm seeing some geometry that goes crazy which might be whats causing your flicker.
That's also happening with D3D9 though which as I said is pretty weird. Probably some kind of apitrace bug.
The issue could be related to nested locking of buffers. That's something the game does that we don't support yet. Apitrace probably trips over that as well.
I do have the game so I'm probably just gonna test it myself.

Please retest.

It seems dark and bright flashing is still unchanged with 9cb88bae7b7130d00c61ebfe7efe9b82fd7d6979 .

You didn't just replay the apitrace to test it, did you? The actual game seems to work fine for me now.

Actual game capture showing the issue with 1h old D9VK build:
https://www.youtube.com/watch?v=_HFfd36c2DM&feature=youtu.be

Meh. As you can see, this is hard to reproduce. I have no idea how to even fix this. Apitrace doesn't work with the game and hitting that one frame window with renderdoc isnt gonna happen.

Can you try this build?
risen 3 test.zip

Thanks for your efforts. With your build, it seems to happen only directly after loading a savegame, but not otherwise.
It btw. seems to be fully reproducible that it happens directly after loading a savegame for the first time. I wonder if that is really 100% artifact free with d3d9/wined3d, going to recheck..

I can reproduce the 1 frame flickers at the spot in the video. But only at that spot.

With native d3d9, there can be a short flicker directly after loading a savegame, but it never occurs afterwards when moving the camera.

I played this on my 1080TI when it was alive, and didn't see any black flicker on it.
I was even able to get reshade working which was nice, however several times I did get some sort of startup issue or blackscreen happening due to the movie intro files not working well under D9VK, also once or twice I had a corrupt shader file which causes everything to render black (or dark).
D9VK should probably put the shader file in the exe folder for easier finding. (rather then digging through the prefix folders)

D9VK however did have a bit of stutter going on thanks to crap shader caching or something

Shaders need to get compiled once before they can be cached.

D9VK should probably put the shader file in the exe folder for easier finding. (rather then digging through the prefix folders)

If you mean the state cache: that's what it does by default unless you change the path in the config file.

If you mean the state cache:

Well this game had stutters whenever you encountered something new like a new NPC or area. (eventually it reduced however).
Also I never really messed with a config file, d9vk was dumping the cache file into the wine prefix automatically (can't remember specifics, but it wasn't the exe folder).

Good news: I can't reproduce it anymore with 23f4ac020568609ba07dd15ec4806b991111fd18 .

@Joshua-Ashton and others:
Is there anything known about Risen 2 inventory issues? I can't find anything on the tracker.
The issue is that in the inventory/charachter menu, the picture is cropped with black bars to the left and right, making the game basically unplayable.
I can open a new issue (hopefully) with renderdoc capture if required.

That isn't a known issue. Please make a bug report over at dxvk.


Bolt working for other things other than the basic use of page('uri') ?

I have been wondering if Bolt is also working for pages which are called by other means other than page('uri')
For example i am having a route which is doing a minor task and it's also basically getting a page by the uri in this case a multi-language setup. Anyhow, would i be able to increase the lookup/rendering in this kind of case as well?
        'pattern' => '(?:(^[a-z]{2})//?)?(:all)/(:alpha)',
        'action' => function ($language, $link, $key) {
            if($page = site()->visit($link,$language)){ // as you can see we basically do a similar thing here...
                    $data = [
                        'key' => $key,
                    ];
                    return $page->render($data);
            }
        }

site->visit can take a pageobject as param. so that should indeed work.
https://github.com/getkirby/kirby/blob/c77ccb82944b5fa0e3a453b4e203bd697e96330d/src/Cms/Site.php#L642
        'pattern' => '(?:(^[a-z]{2})//?)?(:all)/(:alpha)',
        'action' => function ($language, $link, $key) {
            $page = bolt($link);
            if($page = site()->visit($page, $language)){ // as you can see we basically do a similar thing here...
                    $data = [
                        'key' => $key,
                    ];
                    return $page->render($data);
            }
        }


82 successfull registration throws error but still logs in

Intermediate Bug Fix, will fix it nicely soon, but it should work now

I have now fixed it. There should be no more configuration needed now.


Job.prototype.schedule doesn't add job into scheduledJob

Job wasn't added to scheduledJob object when being scheduled with job.schedule. Is there a reason for this behavior? Or you missed this out?

@spinosae Probably we missed it. Let me think a little about it. Thanks for the report!

oh, it is something we missed here- https://github.com/tejasmanohar/node-schedule/blob/master/lib/schedule.js#L139
only jobs scheduled via scheduleJob() are being added right now, oops

Fix already landed https://github.com/tejasmanohar/node-schedule/commit/1e7e09bfd8cf3a1538be803e10f29e795603602c


JOSS paper review responses

In response to https://github.com/openjournals/joss-reviews/issues/2352#issuecomment-666381389:

Adding link to governance document to CONTRIBUTING.md
Adding notes that we welcome pull requests
Referring to governance document from HPX docs

@msimberg thanks, I have applied your suggestions.


Implement async/eventloop support for Windows

See https://stackoverflow.com/a/5037981 for a possible integration with other windows event loop techniques

We should probably go with the overlapped io option, I think that is what the event loop is using on windows already (?)

Works since some time now \o/


I have tried to use illustra in colab but it gives me the following error

ModuleNotFoundError                       Traceback (most recent call last)
 in ()
73 get_ipython().system('git clone https://github.com/eps696/aphantasia')
74 get_ipython().magic('cd aphantasia/')
---> 75 from clip_fft import to_valid_rgb, fft_image, slice_imgs, checkout
76 from utils import pad_up_to, basename, file_list, img_list, img_read, txt_clean, plot_text
77 from progress_bar import ProgressIPy as ProgressBar
/content/aphantasia/clip_fft.py in ()
16 os.environ['KMP_DUPLICATE_LIB_OK']='True'
17 from sentence_transformers import SentenceTransformer
---> 18 import lpips
19
20 from utils import pad_up_to, basename, img_list, img_read, plot_text, txt_clean
ModuleNotFoundError: No module named 'lpips'

should be fixed now

Thank you very much brother. By the way, the project is incredible to me, I
do poetry and I was very interested in using illustra to bring my poems
into visual art. I am from the Dominican Republic if one day you come here
you have a friend, very lucky
On Tue, May 4, 2021 at 6:43 PM vadim epstein @.***>
wrote:

Closed #21 https://github.com/eps696/aphantasia/issues/21.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/eps696/aphantasia/issues/21#event-4686028766, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AT5E7UF6AKC6UTFBZTBQWVDTMB2C5ANCNFSM436SBZYA
.

thanxxx, glad to hear ::]


Haven't used this script in a while but want to confirm it does work on a playbulb comet

title

Many thanks for your feedback.


Figure out user accounts system

Need a simple way to track user's progress especially for the badges system. Since the app will be used by children login with username and password may be too complex.

Create a unique QR code on sign-up and scan it from the app to sign in? Magic links emailed?

They were kind of tipping between wanting to restrict access to only schools that had signed up for it and allowing access to everyone but I think we decided on allow access for everyone so students could use it at home as well as streamlining the setup process for schools.
Basically once you have the url to the app you can "Sign-up" with just a basic username and no password so kids don't forget it and lose their progress. If they lose their username thats kinda on them. We could also restrict access by making them enter their birthday as a type of verification which would help limit kids brute forcing other peoples saves.


Can't build twice

What happened?
I am exploring buildpacks. I wanted to build my image again, but the second build breaks.
$ curl -G https://start.spring.io/starter.zip\?type=gradle-project -d dependencies=web -d javaVersion=11 -o demo.zip
$ unzip demo.zip -d .
$ pack config default-builder paketobuildpacks/builder:base # according to https://paketo.io/docs/buildpacks/language-family-buildpacks/java/#about-the-examples
$ pack build demo --path $PWD. # this one works as expected
$ pack build demo --path $PWD
# ...
Paketo Maven Buildpack 5.3.0
  unable to create application layer
  failed to generate expected metadata
  unable to determine java version
  error executing 'javac -version':
   Combined Output: :
  unable to start PTY
  exec: "javac": executable file not found in $PATH
ERROR: failed to build: exit status 1
ERROR: failed to build: executing lifecycle: failed with status code: 145

Forgive me. I have just begun to use buildpacks. I assume that the build is run in complete isolation. The fact that I am using sdkman to install and select the Java version on the host should not get in the way of buildpacks, should it? The first build works as advertised though. 🤔
$ pack version
0.19.0+git-360dbae.build-2550

The fix for this has been picked up in the builders. If you're on the latest builder at the time of writing, 0.1.115-base, you should have the fix.


added remote-env arg

Added parser argument --remote-env with alias -R when calling retro-contest run to allow for any docker image to be used for the remote container, instead of only openai/retro-env.  The default remote image is still openai/retro-env.
I wanted to be able to create a dockerfile from openai/retro-env without having to tag over it in order to use retro-contest run.

Thanks!

@TheAggregator thanks for collaboration!


Backup  pwa ilt style corrections

Style edits to PWA-ILT

style folders, files, and url's as code instead of bold
minor content fixes, mostly spacing/punctuation

If this passes review, it is ready to merge (no breaking changes).

[x] This has been reviewed and approved by (dscales)
[x] I have run npm test locally and all tests pass.
[x] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

:+1:

FYI @jpmedley many of the changes you requested from me in #6510 were merged in on #6547, but I've finished some of your other requests in this PR.
Thanks for your review! 👍
Some remaining notes on your feedback (cc: @petele too):

Remove the extra space between 'some' and '[push'.

Looks like there are multiple instances where an extra space is inserted before a link and I can't see anything wrong with the source docs so I must suspect it could be an issue with the claat or cleanup? Doesn't appear to be a regression though.

Why not rename the directory in the zip file?

My understanding is that GitHub names all zip downloads with the pattern repo-branch.zip. So I don't think I can change it myself. That said, I don't think I actually need the "Rename the folder to pwa-training-labs so that the name is consistent with the lab instructions." line here since this is the only doc that actually references the top-level directory. I've reworded this section, and it was merged in with #6547 but I can revise.

This is a note not a key point.

We had been using the Codelab style, where notes are inside a single cell table with a light
green background. From experimentation it looks like the green background causes the "key point" conversion by claat, and that the single cell tables cause issues if there is code inside. We've adjusted the note formatting in the source docs and they were correct as of #6547.
Thanks again!

Many of the changes I asked for, particularly the formatting ones, were a pretty big ask. Thank you for doing all that. I know how tedious it was.
I had issues with the way file names were used as headings. What happened with that?

Heh, it was a bit of work but it looks much better and more consistent now.
Yes! Thanks for catching that. I had actually forgotten. I've pushed another commit that removes them as requested.

:+1:

:tada: This has been pushed live to https://developers.google.com/web/


p2p: Ensure peers are on the same side of chain splits as us

Closes: #865

@carver any thoughts on the best way to have HeaderChain.import_header() check fork rules?  ISTM we'd need to move (or duplicate?) vm_configuration and a bunch of other things from Chain to HeaderChain and then implement the validation in the fork-specific create_header_from_parent() or something like that?  Just trying to figure out whether we should go with this as an interim solution or try to go straight with the solution you suggest

Not a complete answer but I think that Chain should define a header_chain_class and that the vm_configuration from the Chain class should be passed down to the HeaderChain.  This gets us VM awareness in the HeaderChain to be able to do this type of validation.

@gsalgado I think it might be worth jumping straight into the new HeaderChain changes. I'll take a look now.

Although 883 is not complete, I still think it is proving out the idea: that we can keep all the forking logic in the VM, separate from the p2p module.

Sounds good to me! Do you plan to finish up #883?

Should this now be closed since #883 is merged?

Once we agree on the best way to tackle #865 I can update this accordingly

Seems like a good sign that we both came up with the same approach. :+1:  I'd say that's good enough to take a swing at it now

We could try and apply this validation to other places that receive headers, but it won't be so straightforward as they don't have the request params, and yeah, it should be in a separate PR because this one is only about ensuring peers are on the same side of the DAO fork as us

Tracked here: https://github.com/ethereum/py-evm/issues/944

I cannot find it in the code. Do you check only the header hash of the dao hf header?

Check happens here:
https://github.com/ethereum/py-evm/blob/master/p2p/peer.py#L819-L865
Specifically here: https://github.com/ethereum/py-evm/blob/master/p2p/peer.py#L861
I think we may be missing validation enforcement on the extra_data field for the first 10 headers.

link https://github.com/ethereum/py-evm/issues/1086

Nevermind, here it is: https://github.com/ethereum/py-evm/blob/master/eth/chains/mainnet/init.py#L36

Is the extra data check needed? Header hash is not enough?

It may not be needed but it is part of the spec so we do it.


Fix 'attempt to call method 'ClearControls' (a nil value)'

The ClearControls method does not exist anywhere, and would prevent you from opening the spawn menu after running spawnmenu_reload.
Also fixed some other errors I encountered afterwards, the menu is a cursed rabbit hole to go down.

I didnt know isvalid could be used on panel things. Good to know for the next time


Add files via upload

Your checklist for this pull request
Author name
Author:Aaron lei

Aaron
About your game
This game is called:Echoing_horsea(I forgot to change the name)
What is your game about?
Making the player get to a portal without getting choped by the moving knife

How do you play your game?
Press WASD to move. The trees will block your way to getting to the portal, so u will have to go around them, there will be a knife that moves when you move so you have to get to the portal strategically.

Code
Check off the items that are true.

[x ] The game was made using the Sprig editor.
[x ] The game is placed in the in the /games directory.
[x ] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[ x] The game runs without errors.
[x ] The name of the file/game contains only alphanumeric characters, -s, or _s.
[ x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

@grymmy I am trying to resubmit a different commit so let me know if you saw the new file

Okay I am satisfied after you've made this update.  Please fill in this form to receive a Sprig device (if you're a teenager, and haven't received one, that is).  Also, join us in Hack Club's Slack and share your creation in the #sprig channel!

Thank you so mucb


Add github action to publish lambda layer

Currently I am publishing a manual workflow that can be triggered from UI to publish new lambda layer. We can automate it later depending on the usecase.

@pshanmukrao is this still something we're pursuing?  if so, please rebase to pick up the latest GH status checks.  Otherwise let's close it out.


FixFix some issues in the Insert job.

What problem does this PR solve?

The job does not account for tasks in the Canceled state.
When a job is canceled, its status is marked as FAILED, and a NullPointerException (NPE) occurs because resources have already been released.

java.lang.NullPointerException: Cannot invoke "org.apache.doris.qe.ConnectContext.getState()" because "this.ctx" is null
	at org.apache.doris.job.extensions.insert.InsertTask.run(InsertTask.java:200) ~[classes/:?]
	at org.apache.doris.job.task.AbstractTask.runTask(AbstractTask.java:167) ~[classes/:?]
	at org.apache.doris.job.executor.DefaultTaskExecutorHandler.onEvent(DefaultTaskExecutorHandler.java:50) ~[classes/:?]
	at org.apache.doris.job.executor.DefaultTaskExecutorHandler.onEvent(DefaultTaskExecutorHandler.java:33) ~[classes/:?]
	at com.lmax.disruptor.WorkProcessor.run(WorkProcessor.java:143) ~[disruptor-3.4.4.jar:?]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]15e8716a7ab9">

The RESUME job does not immediately schedule the job.

Release note
None
Check List (For Author)

Test

[x] Regression test
[ ] Unit Test
[x] Manual test (add detailed scripts or steps below)

 mysql> select STATUS  from tasks('type'='insert') where JobName='test'\G
*************************** 1. row ***************************
STATUS: CANCELED
*************************** 2. row ***************************
STATUS: FAILED
*************************** 3. row ***************************
STATUS: CANCELED
3 rows in set (0.02 sec)

mysql> select * from jobs("type"="insert") where name='test' \G
*************************** 1. row ***************************
               Id:<PHONE_NUMBER>340
             Name: test
          Definer: root
      ExecuteType: RECURRING
RecurringStrategy: EVERY 1 SECOND STARTS 2024-11-25 16:02:54
           Status: PAUSED
       ExecuteSql: INSERT INTO orders.image select * from orders.image
       CreateTime: 2024-11-25 16:02:53
 SucceedTaskCount: 0
  FailedTaskCount: 1
CanceledTaskCount: 2
          Comment:
1 row in set (0.02 sec)

mysql>

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run cloud_p0

run external


Latest Debian (debian-10.9.0-amd64-netinst.iso) does not include can-j1939 module by default

Hello,
I have tried below image for virtual box environment and it does not seem to include the can-j1939 modules by default.
debian-10.9.0-amd64-netinst.iso
More details on J1939 is here https://www.kernel.org/doc/html/latest/networking/j1939.html
In order to use this, module I will have to rebuild the kernel with can-j1939 module included with below steps:
https://github.com/linux-can/can-utils/blob/master/can-j1939-install-kernel-module.md
Is that something that was supported to be by default in recent kernel images ?
Is there any other Debian image version that includes it by default?
Please suggest. Thank you in advance.
Thanks,
Manish K

You’re in the wrong place. This is a repository for an internal program used in Debian.
Please see https://www.debian.org/support instead.


How to determine the best training epochs and loss?

Hi,
I'm using deepar model to predict. The loss being optimized is negative log-likelihood, so the loss I got is negative. I'm wondering how to determine whether the value of loss is good enough? Is it  the case that the smaller the absolute value of loss is, the better the training is?

The sHort answer is yes, lower values of the negative log-likelihood are better. More details can be found here.

The sHort answer is yes, lower values of the negative log-likelihood are better. More details can be found here.


CPack: Include latest CPackDeb for building IPKs

Replaced CPackDeb.cmake with the latest version which supports naming
the debian packages with a .ipk suffix.  Included CMake's 3-Clause
License for redistribution.
Signed-off-by: Noel Eck<EMAIL_ADDRESS>

ipk generation is throwing a segmentation fault. Should this change fix that?

The CPack binary segfaults on various string methods (usually in cmCPackDebGenerator.cxx where GetOption returns a NULL to a string constructor).  This version of CPackDeb creates an IPK and does not cause the segfault.


Add missing "type": "module" to package.json for Vite resolution

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
latest
Link to runnable example
No response
Steps to reproduce

import { toHtml } from 'hast-util-to-html' in a JS file
Run with Vite (e.g. dev server)

Expected behavior
Some developer tools assume any module is a CommonJS module unless "type":"module" is specified in package.json.
I don't particularly agree with that approach and I'm not sure why the Vite maintainers decided to be more "dumb" about it in their resolution logic versus what they had before, but it seems to me that providing this meta information doesn't hurt and helps tools understand more clearly what format a module is.
Expected: "type": "module" in package.json
Actual behavior
Missing "type": "module" in package.json, results in tools thinking the module is CommonJS format.
Affected runtime and version
<EMAIL_ADDRESS>Affected package manager and version
<EMAIL_ADDRESS>Affected OS and version
No response
Build and bundle tools
Vite

https://github.com/syntax-tree/hast-util-to-html/blob/fa187494263aa1087ba1c307abce72b2413e452e/package.json#L28
Update your dependencies and built tools

Ah sorry, I read over it completely. 👍

no problem!


Complete dynamic properties for tests/Zend/**

Fix bug PHP 8.2: Dynamic Properties are deprecated' for test suite tests/Zend/**
Don't worry about this PR make mistake on tests/Zend/** suite, everything verified by github action task phpunit for php 8.2 , php 8.1, php 8.0, php 8.4 (Everything success)
Work Done

Removed #[AllowDynamicProperties] attribute added by me in tests/Zend/** at PR  #275
Used rector to add real properties needed by test case class tests/Zend/** because i concerns #AllowDynamicProperties will removed in php >=  8.3$ ./bin/rector --no-diffs tests/

This config help complete dynamic properties to class https://github.com/Shardj/zf1-future/blob/1f1cc46bda2f1b2451a80d7663bfd1d94bcab343/rector.php#L16-L17

What next
After this PR merged into master, i will do the same thing for library/Zend to eliminate issue Creation of dynamic property xxx  is deprecated in library/Zend
For Reviewer
Please keep my git commit signing by merge branch, please don't use rebase ^^

For Reviewer
Please keep my git commit signing by merge branch, please don't use rebase ^^

Then you have to move those unrelated commits to separate PR. Remove rector changes from this PR and submit as a separate PR. You could submit them after this is merged if that makes a more logical order.
also noticed some commits have same title, these probably could be joined or the title is wrong? PHP 8.2: Add missing properties to classes tests/Zend/Queue/*
Also, remove "PHP 8.2: "prefix from messages to make them shorter (some are still wrapped over 72 chars), if someone wants to know if they are PHP 8.2 related they can see that from PR or from merge commit.

Don't worry about this PR make mistake on tests/Zend/** suite, everything verified by github action task phpunit for php 8.2 , php 8.1, php 8.0, php 8.4 (Everything success)

what does this sentence mean? what mistake?

I mean something bad like

syntax error
change test spec  but don't have anything to verify

Syntax errors will be caught by CI:

https://github.com/Shardj/zf1-future/blob/29a05ff5ee7e375e5b35e8926dc5f607a05c6a98/.github/workflows/lint.yml#L12

still, that sentence doesn't make any sense to me. remove it?

btw, all properties were added as public. probably doesn't matter at all for tests what their visibility is. so not worth putting time into fixing t hem, unless you have clever way of doing that.

btw, all properties were added as public. probably doesn't matter at all for tests what their visibility is. so not worth putting time into fixing t hem, unless you have clever way of doing that.

Oh it's done by run ./bin/rector --no-diffs tests/ not take much time

Oh it's done by run ./bin/rector --no-diffs tests/ not take much time

so, rector can figure out which property needs to be public, which one can be private/protected?

that's why I said for tests/*.php they can all stay public.

Mr. @glensc I followed your advice

Square 2 commit  PHP 8.2: Add missing properties to classes tests/Zend/Queue/*
Removed "PHP 8.2: "prefix from messages

@Jimbolino thanks you, a good trick for test suite ^^

Too many changes to manually review. But as tests pass, this should be good enough.


Investigate using the bank module to track ownership of scopes (or any nfts).

Summary
Investigate what it would take, and what the repercussions would be if we used the bank module to track the value_owner of scopes. Or, alternatively, evaluate storing the value_owner in state outside the scopes (so we don't have to read the whole scope when all we need is that part).
Problem Definition
In the metadata module, we have duplicated logic involving the transfer of scopes to/from marker accounts. As we prepare to make scopes tradable in the exchange module, we will currently need to include more custom logic (this time in the exchange probably) to identify when scopes are being bought/sold and correctly change the value_owners (instead of doing a bank send).
However, if we use the bank module to convey ownership of scopes (e.g. send 1nft/<scope id> to the value_owner), we can probably get rid of duplicated/external logic between the exchange, marker, bank, metadata and nft modules.
Proposal
Investigate wrapping the nft module around the metadata module and then making the nft module use the bank module for keeping track of who owns what. Or maybe have the metadata module use the bank module directly for the value_owner stuff (instead of storing it in the scope anymore).
Ultimately, we'd want the bank balances queries to also list any nfts (e.g. scopes) the account owns. And we want it possible to use a bank transfer stuff (e.g. MsgSend, MsgMultiSend, func SendCoins, andfunc InputOutputCoins) to change the owners of nfts/scopes. This in turn would allow the exchange module to facilitate the purchase/sale of nfts/scopes too.
For this issue, we just want to research what that might look like, how much effort it might take, and what the risks are.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

I've decided to go with using the bank module to track the value owner.
The denom for a scope will be nft/<scope id>.
Benefits:

Gas reductions for endpoints that manage value owners.
Doing this should allow us to simplify the metadata module to not have to specially check when a marker is involved (the bank send restrictions will do that now).
Scopes will be tradable with the exchange module.
Slightly simpler metadata module because it no longer needs to check with the marker module sometimes.
Quarantine and Sanction stuff now applies to scope value owners.

Drawbacks:

More complex metadata module since it'll now be using/managing bank state too.
There's room for a bug where two accounts get listed as the value owner.
Slightly larger overall state, less than 60 extra bytes per scope.

For now, we'll hold off on the nft module for now though.

I'm going to close this now.
I've created this issue:

#2137

Adding the NFT  module will still fall under this one:

#956


x/tools/cmd/goimports: format is not the same

What version of Go are you using (go version)?

$ go version
go version go1.12.5 darwin/amd64

Does this issue reproduce with the latest release?
Yes in 1.12.5
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN="/Users/tomocy/Codes/bin"
GOCACHE="/Users/tomocy/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/tomocy/Codes"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.12.5/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.12.5/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/19/1v1v30rd7fn4vzqt6xf_2g580000gn/T/go-build769896193=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

When one package is imported in one line
import "error"

I imported a package
import (
    "log"
    "error"
)

but, I stopped using the package after all and format with goimport.
What did you expect to see?
Import the first package in one line.
import "error"

What did you see instead?
Import the package with parenthesis.
import (
    "error"
)

Thanks for the report.
This is an intentional goimports feature. It was introduced to fix #18051; essentially for two reasons: the fact that it minimizes diff noise when committing, and the fact that switching to the one-line format can misplace comments when there are commented lines between the lines with the packages names in the grouped version, if that is converted to the single-line version.
I'm closing here, since this is WAI.


Live preview for Markdown

It looks like markdown-preview-mode provides this functionality. For reference, it is incorporated into kpurdon/.emacs.d. Adding this would completely obviate the need for something like MacDown (and would obviously increase cross-platform compatibility).

Use grip.


Is there any event to notify when aurelia finished dynamic DOM operation or binding changed?

I use material-design-lite css style in Aurelia.
As description in GETTING STARTED/Use MDL on dynamic websites
Material Design Lite will automatically register and render all elements marked with MDL classes upon page load. However in the case where you are creating DOM elements dynamically you need to register new elements using the upgradeElement function.
code like below, mdl-js-ripple-effect  in
<button... will not work when after click on Add button after page load. mdl-js-ripple-effect ** need to call  componentHandler.upgradeElement or componentHandler.upgradeDom()** after <button id='Add' clicked and aurelia finished dynamic DOM operation .
Is there any event to notify when aurelia finished dynamic DOM operation or binding changed?
    <button id='Add' type='button' click.delegate='nextButtonEffective()' class="mdl-button mdl-js-button mdl-button--raised mdl-button--colored mdl-js-ripple-effect" >Button ${iButtonEffective} Got Effect, Click to Next Button</button>

        <button href='' class="mdl-button mdl-js-button mdl-button--raised ${i==$parent.iButtonEffective?'mdl-button--colored mdl-js-ripple-effect':''}">${i}</button>

export class Welcome{
  iButtonEffective = 1;

  nextButtonEffective()
  {
    this.iButtonEffective ++;
    if(this.iButtonEffective >= 10)
    {
    this.iButtonEffective %= 10;
    }
  }

reply by EisenbergEffect jdanyow on https://gitter.im/Aurelia/Discuss
EisenbergEffect
@liuyuanhuo There is no event that fires every time there is a dynamic dom update. The easiest way to handle this is to create custom elements or custom attributes that encapsulate the UI library you are using. Then they can leverage the attached and detached hooks directly.
@liuyuanhuo That said, you could set up a MutationObserver yourself that watched for dom updates and triggered the library.
More or less, that is what web components polyfills do.
jdanyow
@liuyuanhuo you could also create a custom attribute that calls the necessary "upgrade" code in it's "attached" method. This can be a pain because you need to remember to add the custom attribute on every element that needs upgrading. I used this approach here (look for the materialize attributes throughout the html).

Is this still the case with Aurelia? I am using slick and need to refresh or update slick when a new item is added to it's children. This is bound to a VM through the repeat.for method.

You could easily create a custom attribute that you could place on the repeat item template that would fire the event you want.

But is there ANY best practices in Aurelia to handle such cases?
I'm using kendo.ui and initialization of such controls could be started only after the DOM was generated. Have you some good approaches, practices to do it good?
I'm also wondering if it could be just an app architectural case. If we want to do it this way we should create a custom component initializing the dropDown or other kendo control, and then there are no problems at all.

I had this issue today with masonry which applies it's layout after the DOM has loaded. As suggested, I just created a custom attribute and attached it to the repeating element:

        <card class="drag-source" title="${row.title}" customer="${row.customer}" project-attribute.bind>   </card>

Then, in the custom attribute bind method of the custom attribute checked to see if the DOM element being added was the last, and if so applied the masonry layout.
bind(bindingContext, overridingContext) {
    if (overridingContext.$last === true) {
        // masonry stuff here
    }

At first seemed a bit odd, but on reflection it's much nicer not to clutter the view model with DOM manipulation stuff which is basically what masonry is doing.


solve TypeError: mainWindow.restart is not a function

I click view>reload, but there is error mainWindow.restart is not a function, so I think maybe restart is reload.

@tzmanics could you take a look at this please? It's the desktop integration and I'm unsure of the benefit. On the original seed, this is unchanged

Hi @Joeycz I know this is old PR - I just went ahead and added your fixes to master - thank you 👍


fix: infinitely get pieces when piece num is invalid

Signed-off-by: Jim Ma<EMAIL_ADDRESS>
Description

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[ ] Code compiles correctly.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #926 (890b2d1) into main (4a4debd) will decrease coverage by 0.64%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   43.27%   42.63%   -0.65%
==========================================
  Files         106      113       +7
  Lines        8273     8604     +331
==========================================
+ Hits         3580     3668      +88
- Misses       4232     4470     +238
- Partials      461      466       +5

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
42.63% <40.00%> (-0.65%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/config/peerhost.go
35.29% <ø> (ø)

client/daemon/daemon.go
5.57% <0.00%> (ø)

client/daemon/rpcserver/rpcserver.go
33.64% <0.00%> (-0.65%)
:arrow_down:

client/daemon/storage/local_storage.go
25.47% <0.00%> (+0.28%)
:arrow_up:

client/daemon/peer/peertask_manager.go
19.28% <15.38%> (-0.86%)
:arrow_down:

client/daemon/peer/peertask_base.go
45.38% <44.64%> (-3.12%)
:arrow_down:

client/daemon/peer/peertask_stream.go
53.58% <68.75%> (-2.05%)
:arrow_down:

client/daemon/peer/peertask_file.go
52.86% <100.00%> (+0.15%)
:arrow_up:

cdn/supervisor/cdn/downloader.go
48.38% <0.00%> (-4.95%)
:arrow_down:

cdn/supervisor/cdn/storage/disk/disk.go
14.49% <0.00%> (-3.56%)
:arrow_down:

... and 29 more


Update changelog for release.

Should we wait for https://github.com/CQCL/pytket-pyquil/pull/89 ?

Should we wait for #89 ?

Happy to wait for that. Could it be merged today?

I think we can merge this without the other PR and I will make a new release after the other PR is merged.