Involving Database

Hey it was great if you could involve database in this example.
I'm following your course on Pluralsight and it's not clear to me where I should put database update If I would like to persist my store.
At first I thought it should be in the reducers but you said we should keep it pure and use only for states updates.
I'm a newbie in react.

A database would traditionally be handled on the server, and accessed via HTTP calls to an API that's hosted on the server and calls the DB. You can store data on the client via localStorage, but you probably want a real database. Since a database is a server-side concern, it's deliberately left out of Slingshot.

K make sense.
So this a pure question if you may. Where an API call for DB updating should be located in the Redux model. Should I just make in the component? how are we involving the state? I saw some examples off any connection with a backend, where the sate only manage call status.
I would like to hear you opinion on what is the best practice.
Anyway amazing course cheers.

API calls are traditionally made from your actions, using Redux-thunk or an alternative middleware.

And thanks for the kind feedback!


Roll Flutter Engine from d5690468da0f to 047b6754b7d4 (2 revisions)

https://github.com/flutter/engine/compare/d5690468da0f...047b6754b7d4
2022-11-30<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974)
2022-11-30<EMAIL_ADDRESS>Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gF3YVyOjqNbz to ECusE22sNK6I
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Fix: dnSpy is opened with reference assemblies for .net framework code

How about this to fix #2
Testet with mscorlib 4.0 on Windows 10 with VS2017

Thanks for contributing
I will test on my machine and then pull request will be merged.

@medoni , I've prettified your solution and merge it into a master.
Thanks for your contribution.


Whitepaper

I'm working on app for whitepapers and wanted to include cardano. Have you got whitepaper in html or md.
Regards,
PJ

https://iohk.io/research/papers/ this is the best you've got AFAIK


Load email template from file

The current email config is in notifier.go as a blob of text.
This can pretty obviously be loaded up from a file specified as a configuration option, since email is one of those things you'd want to pretty heavily customize.
I'm just dropping this here so I can reference it later when I get a chance to have a poke at it.

More generally, all notifications should be configurable via a templating language. I'm thinking inline in the config, as many will be brief.

The new alertmanager supports this.


Support .NET 7.0 RTM

@jmezach @jeffrosenberg  I do not understand versioning - where do I set it? Or it it set by magic 🧙 ?
fixes #353

Also, how do I get the sqltools module down locally?

@ErikEJ We're using https://github.com/dotnet/Nerdbank.GitVersioning for versioning. Basically we can merge a set of changes to master and then when we're ready to release we run the nbgv prepare-release command which will create a release branch for that release and then bumps the version number on master.
sqltools is a submodule, so you should be able to get that by running:
git submodule init
git submodule update

This test step failing:
Build the project using exact version number
- name: build project (exact version / MSBuild resolution)
  run: dotnet build ./test/TestProjectWithSDKRef/TestProjectWithSDKRef.csproj /bl /p:DependencyVersion="$Env:NBGV_NuGetPackageVersion" /warnaserror:SQL71502
  shell: pwsh

I have no clue where it gets the 5.0 version number from?

It looks like the macOS and Windows runners have the .NET 5 SDK installed by default or something? We are installing the 3.1 version, but of course 5.0 is newer so it will pick that. Kinda weird though that those runners still have an unsupported version installed?

@jmezach I also updated the Ubuntu runner, as 18.04 was deprecated

@jeffrosenberg Could you have a look at this?

@jmezach Hmm.. any clues tom why deploy.sqlpackage failed?

@jmezach  I was not using 20.04 everywhere!

@jeffrosenberg Looks like SqlPackage doesn't work on that Ubuntu version: https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/actions/runs/3436079040/jobs/5729274646#step:5:8.
I guess it's fine for now and not something we can fix anyway. So I'll go ahead and merge this and release a new version so that folks can start using this with .NET 7.

@jeffrosenberg Yes, I think something extra needs to be done (or maybe use 22.04) - but it seems out of scope for this change


Rename the BoundAttributeDescriptor builder.

ITagHelperBoundAttributeDescriptor => TagHelperBoundAttributeDescriptorBuilder

#1306
@ajaybhargavb @rynowak do we even want to PR these changes or just get them in? Thought I'd do a dry run to ask.

IMO simple renames can be FYI only PRs

👍

It's not bad to have a paper trail that's easily searchable


Update DBRD dataset card and download URL

I've added the Dutch Bood Review Dataset (DBRD) during the recent sprint. This pull request makes two minor changes:

I'm changing the download URL from Google Drive to the dataset's GitHub release package. This is now possible because of PR #1316.
I've updated the dataset card.

Cheers! 😄

not sure why the CI was not triggered though

not sure why the CI was not triggered though


Answer Q about genome build (web interface, only, really)

Closes #137. I added a question "How can I find out what genome build and release were used to process RNA-seq data?" immediately after "Why do the genes included in RNA-seq experiments change between experiments from the same organism?" where we discuss different releases. This comes before "How can I find out what versions of software/packages were used to process the data?" which uses a GIF from a microarray examples that doesn't necessarily give folks context about where the sample processing link is.

Let's see what happens 📷 🚀


Clear buttonTextAfterSelection

I want to clear buttonTextAfterSelection after an event (user will select an item in select dropdown and after button confirmation the text in select dropdown should be reset to default or empty string.
Thank you.

Resolved thanks to other comments

How did you resolve it can you give me solution please


Missing required parameters on path "/admin/:collection_name". The missing params are: ["collection_name"]. The params object passed in was: {"name":"journals"}.

url.js:376 Uncaught Error: Missing required parameters on path "/admin/:collection_name". The missing params are: ["collection_name"]. The params object passed in was: {"name":"journals"}.Url.resolve @ url.js:376Handler.resolve @ handler.js:108Route.path @ route.js:163Router.go @ router_client.js:236Houston._go @ router.coffee:28Template._houston_document_view.events.click #houston-delete @ document_view.coffee:33(anonymous function) @ template.js:483Template._withTemplateInstanceFunc @ template.js:457(anonymous function) @ template.js:482(anonymous function) @ view.js:884Blaze._withCurrentView @ view.js:538(anonymous function) @ view.js:883(anonymous function) @ events.js:47jQuery.event.dispatch @ jquery.js:4665elemData.handle @ jquery.js:4333triggerMouseEvent @ driftyco_ionic.js:2866tapClick @ driftyco_ionic.js:2855tapTouchEnd @ driftyco_ionic.js:2978
debug.js:41 Exception in template helper: TypeError: Cannot read property '_id' of undefined
    at Object.Template._houston_document_view.helpers.document_id (http://localhost:3000/packages/houston_admin.js?fa4c5890c5721b087f1bd2d45df4247d70e4fe64:1789:25)
    at http://localhost:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2986:16
    at http://localhost:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:1650:16
    at http://localhost:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3038:66
    at Function.Template._withTemplateInstanceFunc (http://localhost:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3671:12)
    at http://localhost:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3037:27
    at Spacebars.call (http://localhost:3000/packages/spacebars.js?1aedcc2aa3ae9ff5d860d73516110cedd77c033e:167:18)
    at Spacebars.mustacheImpl (http://localhost:3000/packages/spacebars.js?1aedcc2aa3ae9ff5d860d73516110cedd77c033e:104:25)
    at Object.Spacebars.mustache (http://localhost:3000/packages/spacebars.js?1aedcc2aa3ae9ff5d860d73516110cedd77c033e:108:39)
    at null._render (http://localhost:3000/packages/houston_admin.js?fa4c5890c5721b087f1bd2d45df4247d70e4fe64:436:22)

this happens when a document is deleted !


invalid use of void

compiling the sketch in Arduino the compiler returns with the following message:
ESP32-Serial-Bridge:101:5: error: invalid use of 'void'
.onEnd( {    <--- here it stops
I have no clue to solve this.
Can anybody show me a way?

I'm pretty much sure you have mistake in syntax.
https://github.com/AlphaLima/ESP32-Serial-Bridge/blob/f6c6ada6aa9a437e4c4a2436d45f98551cd9d6fe/ESP32-Serial-Bridge.ino#L104

I'm pretty much sure you have mistake in syntax.
https://github.com/AlphaLima/ESP32-Serial-Bridge/blob/f6c6ada6aa9a437e4c4a2436d45f98551cd9d6fe/ESP32-Serial-Bridge.ino#L104


Restrict account registration with similar IP/connection limits similar to the automated connect limits

tl;dr don't let people register a million accounts one after the other (from one client connection or multiple).

#21 would help reduce that.


Can I combine multiple wav files into one?

Can I combine multiple wav files into one?
I want to combine multiple wav files into one.
ffmpeg is way too big, so I'm looking for another way.
var wav = await Wav.readFile("$path/tmp0.wav");
var wav1 = await Wav.readFile("$path/tmp1.wav");

wav.channels.addAll(wav1.channels);
await wav.writeFile("$path/all.wav");
print(">>>>>>>>>>>>>>>>>");

I coded like this. The two voices are mingling.
Can I merge files from this library?

You're on the right track, your code is just a bit wrong in the details. channels is a 2D array. It's a list of channels, and each channel is a list of samples. What you want to do is append each channel of the second wave to the end of the first wav's corresponding channel. But what you've actually done is just add more channels to an existing wav.
A mono wav file will have 1 channel, and a stereo wav file will have a left and right channel. So I'm guessing what happened is your 2 input wavs are mono, and you combined them into a stereo wav. So one of them will come out of your left speaker, and the other will come out the right.
Instead you should construct a new Wav, and for each channels of the input wavs, make a new Float64List that concatenates the corresponding channel from the 2 inputs.
Something like this (phone coding, may have mistakes ;)
final chan = [];
for (int i = 0; i < wav.channels.length; ++i) {
  chan.add(Float64List.fromList(wav.channels[i] + wav1.channels[i]));
}
final out = Wav(chan, wav.samplesPerSecond, wav.format);

All this assumes that the 2 input wavs have the same number of channels, and the same sample rate, so you might want to add an assert to verify both those things too.

thank you
I was able to combine multiple wav files using the logic you gave me.


Update stale.yml

Add necessary label to ignore list

Maybe "help wanted" should also be added?

Makes sense. Will do when I'm back at a computer.

@ahopkins are you going to add help wanted label as well ?

Yes. Tomorrow morning.

Added


fix(checkboxgroup): fix a bug when checkboxgroup set the min props

set the min props in checkboxgroup. And checkboxgroup will add value in checkList when repeatedly click the selected checkbox

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@5a8f3cf). Click here to learn what that means.
The diff coverage is 100.00%.

@@          Coverage Diff           @@
##             dev     #705   +/-   ##
======================================
  Coverage       ?   92.34%
======================================
  Files          ?      142
  Lines          ?     3109
  Branches       ?      504
======================================
  Hits           ?     2871
  Misses         ?      131
  Partials       ?      107

Impacted Files
Coverage Δ

src/components/checkbox-group/checkbox-group.vue
100.00% <100.00%> (ø)

src/components/checkbox/checkbox.vue
81.81% <100.00%> (ø)

src/common/mixins/scroll.js
100.00% <0.00%> (ø)

src/components/switch/switch.vue
100.00% <0.00%> (ø)

src/common/mixins/basic-picker.js
100.00% <0.00%> (ø)

src/modules/slide/index.js
100.00% <0.00%> (ø)

src/components/upload/ajax.js
89.06% <0.00%> (ø)

example/data/cascade.js
100.00% <0.00%> (ø)

src/components/index-list/index-list-item.vue
87.50% <0.00%> (ø)

src/components/scroll-nav/scroll-nav-panel.vue
100.00% <0.00%> (ø)

... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8f3cf...5c613ed. Read the comment docs.


Feature/fe 115/list damage on vehicle

What's done

The damaged parts data got passed to the vehicle, and displaying the damage.
Fixed some incorrect ids from the vehicle SVG file.

Blocking

There are some parts id, doesn't exist in our vehicle illustration or are in different spell (e.g we get rockerPanel from the backend but we have rockerPanelLeft and rockerPanelRight in our vehicle SVG, logo doesn't exist in our illustration.
If there is no damages/parts yet in an inspection and we try to go to damageLibrary we'll get this error:

rockerPanelRight


emby app on samsung tv is not working now

How can i use this version . Or can it be added to apps on samsung tv as the emby verions will not work with latest jellyfin version 10.2.2.I am willing to test .I use linux but am not a coder.

Official Emby apps will not be supported since the Emby team explicitly blocks Jellyfin.

How do i use this version.if i put it in developer mode is there a way to test

This repo is really outdated, more info here: https://github.com/jellyfin/jellyfin/issues/451
As for running some older Emby app - I don't know if there's a way, plus we don't have this version of older Emby app anywhere (and they didn't release the source).


"exec: "src.lambda_function.lambda_handler": executable file not found in $PATH"

Hi, after I execute "make docker-run" I get the following error:
my_lambda aburkov$ make docker-run
docker-compose run lambda src.lambda_function.lambda_handler
Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: \"src.lambda_function.lambda_handler\": executable file not found in $PATH": unknown
make: *** [docker-run] Error 1

lambda_function.py with method "lambda_handler" is in the "my_lambda/src" directory. I have "Dockerfile", "Makefile" and "docker-compose.yml" in the "my_lambda" directory. I run "make docker-run" from the "my_lambda" directory.
What should I change to make it work?

I've never seen this error show in my computer, maybe it's a problem with your docker installation or configuration? Could you purge your docker system and try again?

Closing due to inactivity


[tests-only] use new json schema assertion lib that supports latest schema drafts

Description
Moving from helmich/phpunit-json-assert to swaggest/json-schema for json schema assertion.
Why swaggest/json-schema?

supports JSON Schema Draft 7, JSON Schema Draft 6, JSON Schema Draft 4
reports invalid schema
Example: https://drone.owncloud.com/owncloud/ocis/32272/15/6"required": [
  "opaque_id"
],
<-- ❌ INVALID -->
"properties": {
  "type": "object",
  "pattern": "^%user_id_pattern%:%user_id_pattern%:%user_id_pattern%$"
}

"required": [
  "opaque_id"
],
<-- ✔ VALID -->
"properties": {
  "opaque_id": {
    "type": "string",
    "pattern": "^%user_id_pattern%:%user_id_pattern%:%user_id_pattern%$"
  }
}

❌ INVALID
"enum": ["%user_id_pattern%"]

✔ VALID
"pattern": "%user_id_pattern%"

How to debug with error message?
Taking this invalid schema as an example:

Invalid schema
{
  "type": "object",
  "required": ["event"],
  "properties": {
    "event": {
      "type": "object",
      "required": ["ShareID"],
      "properties": {
        "ShareID": {
          "type": "object",
          "required": ["opaque_id"],
          "properties": {
            "type": "object",
            "pattern": "^%user_id_pattern%:%user_id_pattern%:%user_id_pattern%$"
          }
        }
      }
    }
  }
}

Then error message will be:
Object, boolean expected, "object" received at
#->properties:properties->additionalProperties:event->properties:properties->additionalProperties:ShareID->properties:properties->additionalProperties:type (Swaggest\JsonSchema\Exception\TypeException)

From the above error message, we can find out that the problem is in this validation:
[properties]event->[properties]ShareId->[properties]type
i.e.
{
  "properties": {
    "event": {
      "properties": {
        "ShareID": {
          "properties": {
            "type": "object" <-- ❌ INVALID
          }
        }
      }
    }
  }
}

Related Issue

Part of https://github.com/owncloud/ocis/issues/8333

Motivation and Context
How Has This Been Tested?
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

I have to look over to some other details. so converting it to draft

Most of our json schemas are invalid. Tests are passing because we are not validating actual things. Looks like I have to make a large refactor in the schema.

How using const:
"name": {
  "const": "alice"
}

previously we had to do
"name": {
  "enum": ["alice"]
}


Object store release

Which part is this question about
Release cycle
Describe your question
How often fixes are being released in object_store? Can I ask that for a release?
I'm waiting on a fix that is already merged to the main branch.
Thanks!
Additional context

I hope to cut a release in the next two weeks once support for non-contiguous payloads is merged


buildHttpStatusChartData Cannot read property 'forEach' of null

This Bug Report affects these Traffic Control components:

Traffic Portal

Current behavior:
The ds charts view in TP has an error if the api returns no values. Example:
https://tp.domain.tld/#!/delivery-services/42/charts?type=HTTP <-- this view calls GET /api/4.0/deliveryservice_stats
If the api endpoint returns no values (series.values = null), it will throw this error:
Cannot read property 'forEach' of null

Expected behavior:
Handle the empty value without throwing an error.
Steps to reproduce:
See current behavior

IMO a set of no results in the series is best represented by the empty set ([] in JSON, which is actually an Array not a Set) instead of null. But also that's partly coming from InfluxDB's enthusiastic use of null, so idk how much we want to do about that. Though it would also solve the issue by just not needing to handle that case.
In any case, I think this is probably a three-line fix wherever it gets implemented, so I think this is probably a good first issue.

IMO a set of no results in the series is best represented by the empty set ([] in JSON, which is actually an Array not a Set) instead of null. But also that's partly coming from InfluxDB's enthusiastic use of null, so idk how much we want to do about that. Though it would also solve the issue by just not needing to handle that case.
In any case, I think this is probably a three-line fix wherever it gets implemented, so I think this is probably a good first issue.

yeah, should be a simple null check

@mitchell852 - Is the work related to this issue completed?

Can I pick this up? What files would I need to look at?

@mitchell852 I created a PR, please take a look!


Fix custom workspace avatar for public rooms

Details

Auth changes: https://github.com/Expensify/Auth/pull/9612
Fixed Issues

$ https://github.com/Expensify/App/issues/33470
QA Steps

[X] Verify that no errors appear in the JS console

[X] Launch app

[X] Tap fab--start chat

[X] Tap room

[X] Enter room name and select a workspace with custom avatar

[X] Tap create room

[X] Tap header

[X] Tap members---Invite

[X] Invite user X to room

[X] 9 .Navigate to LHN and note avatar of room chat

[X] Go to https://staging.new.expensify.com/

[X] Login as user X

[X] Note avatar of room chat is custom avatar ✅

[X] Repeat with workspace with default avatar ✅

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

custom

default

@grgia the avatar of the room is not being updated when i change the avatar of the workspace.
https://github.com/Expensify/App/assets/75031127/6bb6ff56-d09a-40d0-ab01-551ecdbf48f9

the avatar of the room is not being updated when i change the avatar of the workspace.

@getusha that seems like a different bug, does that happen on main?

@grgia Not able to reproduce on staging, the avatar updates when the account is a member of the workspace.

@chrispader I'm not sure if you're interested in one more theme PR, but I am going OOO and wont be able to restart this PR until I'm back if you feel like taking a stab at it (no pressure though!)

@chrispader I'm not sure if you're interested in one more theme PR, but I am going OOO and wont be able to restart this PR until I'm back if you feel like taking a stab at it (no pressure though!)

yea, i can work on it 👍 @grgia

@grgia is this PR something still to be considered?

If so, @getusha can you please review ASAP?

https://github.com/Expensify/App/issues/33470#issuecomment-1920871952

Cool! Closing


Fix cargo-miri with disabled isolation

Related issue: https://github.com/rust-lang/miri/issues/933
I'm not sure if that's the better place to blacklist TERM, @RalfJung let me know if there is a less hacky place to put it.

The file test-cargo-miri/test.stderr.ref3 that you added is unused.
Also, please add a note in the README saying that TERM is always ignored.

Ok, we are good to go!

Thanks!
@bors r+

:pushpin: Commit 814fe9951637bc965f072c3d6b7d0386c33e90ae has been approved by RalfJung

:hourglass: Testing commit 814fe9951637bc965f072c3d6b7d0386c33e90ae with merge 9fbe719e858ed4daba626f29615d730b8c3476b2...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 9fbe719e858ed4daba626f29615d730b8c3476b2 to master...


Add Sprite Effects (More Sprite AND Canvas Effects)

Introducing Sprite Effects
This extension adds many new visual effects that can be applied to the Sprite and THE CANVAS!
Ever wanted to put fisheye on the canvas? Maybe even a ripple effect? Maybe BOTH? Well, this extension does it for you...
This is WAY faster than Image Effects, supports custom svg filters, and more!!!

I would recommend using https://prettier.io/playground/ to make your code pass the format test.

I would recommend using https://prettier.io/playground/ to make your code pass the format test.

Isn’t there a command for lint or format that automatically prettifies all your files for you?

We need this 😢

We need this 😢

Yes

new blocks:


HttpClientFactory doesn't respect lifetime of custom message handlers

Here is example of code i use:
            services.AddHttpClient(serviceName.ToLowerInvariant(), client =>
                {
                    client.BaseAddress = new Uri(serviceEndpoint.BaseAddress);
                    client.Timeout = TimeSpan.FromSeconds(serviceEndpoint.Timeout);

                    client.DefaultRequestHeaders.Accept.Clear();
                    client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue(MessagePackSerializer.ContentType));
                    client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
                })
                .AddHttpMessageHandler<CorrelationIdHandler>()
                .AddHttpMessageHandler<RequestResponseLoggingHandler>()
                .AddHttpMessageHandler<TrustedClientAuthenticationHandler>();

Handlers are registered as follows:
            services.AddTransient<CorrelationIdHandler>();
            services.AddTransient<RequestResponseLoggingHandler>();
            services.AddTransient<TrustedClientAuthenticationHandler>();

When first request is sent by HttpClient whole processing pipeline is created. When second request is sent neither of handlers is created. Handlers are already created as part of first request processing. After two minutes (e.g. default lifetime of handler) handlers are recreated.
Current behavior causes problem when handlers resolve dependencies from container. These transient dependencies become "locked" by handler instances. For example this may cause issue if handler injects authentication headers based on ASP.NET Core request principal. E.g. ClaimsPrincipal of first request is used for subsequent requests.

Yes. The factory manages the lifetimes of all handlers that get created. I wouldn't suggest trying to use per-request services to share state.
I'll follow up on improving the documentation in this area.
You can use use IHttpContextAccessor if you want to register a handler that has access to the current ASP.NET Core request. Does this help?

@rynowak to my mind current design significantly limits possible use cases for message handlers. As workaround i'm going to create HttpClient explicitly and specify all message handlers as constructor parameters and use instance of client to handle single request.  As result I'm not going to benefit from described improvements.
I think it would be beneficial if HttpClientFactory could work as follows:

Continue to manage lifetime of HttpMessageHandler as it does now. E.g. reuses it for two minutes by default in order to manage connections efficiently.
Create custom handlers per each request.
Create pipeline using cached HttpMessageHandler and newly created custom handlers.

I  think this behavior would be in sync with current documentation and would not surprise developers. On other hand it might be difficult to implement it because handlers are provided as constructor parameter of HttpClient and there is no way to find out lifetime of this object (it may be used for more than one request).

@rynowak after some thinking about IHttpContextAccessor I came to the following solution which may work only when IHttpContext is available:
Before:
    public class TrustedClientAuthenticationHandler : DelegatingHandler
    {
        private readonly ITrustedClientAuthenticationTokenBuilder tokenBuilder;
        private readonly IMyClaimsPrincipal principal;

        private const string AuthType = TrustedClientAuthenticationOptions.AuthType;

        public TrustedClientAuthenticationHandler(ITrustedClientAuthenticationTokenBuilder tokenBuilder, IMyClaimsPrincipal principal)
        {
            this.tokenBuilder = tokenBuilder;
            this.principal = principal;
        }

        protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
        {
            var dateSent = DateTime.UtcNow;
            request.Headers.Date = dateSent;

            var authParams = tokenBuilder.Build(dateSent, principal.Claims);
            if (authParams == null)
            {
                var task = new TaskCompletionSource<HttpResponseMessage>();
                task.SetResult(new HttpResponseMessage(HttpStatusCode.Unauthorized));

                return task.Task;
            }

            request.Headers.Authorization = new AuthenticationHeaderValue(AuthType, authParams);
            return base.SendAsync(request, cancellationToken);
        }
    }

After
    public class TrustedClientAuthenticationHandler : DelegatingHandler
    {
        private readonly IHttpContextAccessor httpContext;

        private const string AuthType = TrustedClientAuthenticationOptions.AuthType;

        public TrustedClientAuthenticationHandler(IHttpContextAccessor httpContext)
        {
            this.httpContext = httpContext ?? throw new ArgumentNullException(nameof(httpContext));
        }

        protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
        {
            var tokenBuilder = GetService<ITrustedClientAuthenticationTokenBuilder>();
            var principal = GetService<IMyClaimsPrincipal>();

            var dateSent = DateTime.UtcNow;
            request.Headers.Date = dateSent;

            var authParams = tokenBuilder.Build(dateSent, principal.Claims);
            if (authParams == null)
            {
                var task = new TaskCompletionSource<HttpResponseMessage>();
                task.SetResult(new HttpResponseMessage(HttpStatusCode.Unauthorized));

                return task.Task;
            }

            request.Headers.Authorization = new AuthenticationHeaderValue(AuthType, authParams);
            return base.SendAsync(request, cancellationToken);
        }

        private T GetService<T>()
        {
            return (T)httpContext.HttpContext.RequestServices.GetService(typeof(T));
        }
    }

In other cases:

Background workers
Message queue handlers
This solution will not work because there might be no way to get access to scoped service provider. E.g. you might not be able to use anything similar to IHttpContextAccessor.

I think it would be beneficial if HttpClientFactory could work as follows:

Thanks, we've gotten this feedback from a few others well. This will not change for 2.2 but we will consider this in the future. Doing a change like this will involve a lot more technical complexity both inside and outside the HttpClientFactory library, and will come with a few more 'gotcha' things that users have to know.

I think this behavior would be in sync with current documentation and would not surprise developer

As a personal note, it's a much safer bet to assume that a library does not provide guarantees that are not listed.  We're going to update the docs to make this super clear.

Background workers
Message queue handlers
This solution will not work because there might be no way to get access to scoped service provider. E.g. you might not be able to use anything similar to IHttpContextAccessor.

For these cases, if this worked the way you want with unit of work-scoped-services you'd still be responsible for setting up the context you want - ie, defining what the unit of work is and managing a DI scope.
If you want the ability to flow 'ambient' data into a message handler without any direct code calling into it you could also use your own async local for IMyCustomClaimsPrincipal, which is what [HttpContextAccessor](https://github.com/aspnet/HttpAbstractions/blob/master/src/Microsoft.AspNetCore.Http/HttpContextAccessor.cs#L8) and CultureInfo.CurrentCulture` use

@rynowak i was thinking about injecting custom context accessors into containers for message handler and background worker cases. This is still doable but looks like a lot of extra work just to use message handlers for HttpClient. It doesn't look like any other code in our infrastructure needs it.
Thank you for your feedback! Looking forward to see changes in IHttpHandlerFactory which simplify development of custom message handlers.


effective date query parameter for getOne is used as the end date in the PL/SQL call.

          I also discovered that the effective date query parameter for getOne is used as the end date in the PL/SQL call. Effectively, any date provided that is after the effective date of the target locationLevel will work to find that locationLevel. This also results in the returned effective date being set to the provided value, not the DB value.

Not sure about the impact of this, maybe it should get its own issue? @MikeNeilson
Originally posted by @zack-rma in https://github.com/USACE/cwms-data-api/issues/908#issuecomment-2405706676

I vaguely remember this being intentional  but that may have been a related concept. Something doesn't seem right about the behavior your describing but I can't quite put my finger on it.


what does it mean by "menu-shader.fsh"

the title explains itself - I'm confused.

read the first line of the usage section. you have to create a texture pack with a file with that name
here is how to create such a file https://answers.microsoft.com/en-us/windows/forum/all/how-do-i-make-a-new-file-with-my-own-extension-in/9142b57d-919c-47f7-a623-a7df4faa7ea1


Migrate to use the Fragment Support Library

It seems as if the Android SDK's fragment classes will become deprecated with the upcoming release of Android P (see Javadoc, e.g. here https://developer.android.com/reference/android/app/Fragment.html). Therefore we should migrate this library's example app to use the Fragment Support Library.

The example app has been migrated to use the Fragment support library in version 4.3.4.


Mining script for Atitd 10

Mining Ore and Mining Gem Scripts will not find main chat

The scripts for mining ore and mining gems have not been ported across to T10 yet, so the ones you are using are written for T9 in which case, no they wont :).
I will look at this later today.

Tyvm
Get Outlook for iOShttps://aka.ms/o0ukef

From: atitdRhaom @.>
Sent: Saturday, June 12, 2021 6:59:33 AM
To: DashingStrike/Automato-ATITD10 @.>
Cc: AlaricRa @.>; Author @.>
Subject: Re: [DashingStrike/Automato-ATITD10] Mining script for Atitd 10 (#121)
The scripts for mining ore and mining gems have not been ported across to T10 yet, so the ones you are using are written for T9 in which case, no they wont :).
I will look at this later today.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/DashingStrike/Automato-ATITD10/issues/121#issuecomment-860037213, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUOQOXRSKHJWTRAZPLBEGBDTSM4ZLANCNFSM46ST2KVA.

Scripts ported to 10


Updated url

Updated url and metadata. Cleaned up markdown.

Docs Build status updates of commit 2fc64ad:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/publish/create-dev-account.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/manage-settings.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/publish-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/update.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/upload-video.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/developer-policies.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[BUG][v1.8.0-rc1] v2 qcow2 backing image checksum no consistent

Describe the bug
The checksum of the backing image located at https://longhorn-backing-image.s3-us-west-1.amazonaws.com/parrot.qcow2 is bd79ab9e6d45abf4f3f0adf552a868074dd235c4698ce7258d521160e0ad79ffe555b94e7d4007add6e1a25f4526885eb25c53ce38f7d344dd4925b9f2cb5d3b. However, when downloaded using the v2 engine, the calculated checksum changes to 304f3ed30ca6878e9056ee6f1b02b328239f0d0c2c1272840998212f9734b196371560b3b939037e4f4c2884ce457c2cbc9f0621f4f5d1ca983983c8cdf8cd9a, which matches the checksum of https://longhorn-backing-image.s3-us-west-1.amazonaws.com/parrot.raw. This issue cannot be reproduced when using the v1 data engine.
To Reproduce

Install Longhorn master/v1.8.0-rc1
Enable v2 data engine
Deploy backing image v1-qcow2, success

apiVersion: longhorn.io/v1beta2
kind: BackingImage
metadata:
  name: v1-qcow2
  namespace: longhorn-system
spec:
  dataEngine: v1
  minNumberOfCopies: 3
  sourceType: download
  sourceParameters:
    url: https://longhorn-backing-image.s3-us-west-1.amazonaws.com/parrot.qcow2
  checksum: bd79ab9e6d45abf4f3f0adf552a868074dd235c4698ce7258d521160e0ad79ffe555b94e7d4007add6e1a25f4526885eb25c53ce38f7d344dd4925b9f2cb5d3b

Deploy backing image v2-qcow2, the checksum calaulated not consistent, creation fail

apiVersion: longhorn.io/v1beta2
kind: BackingImage
metadata:
  name: v2-qcow2
  namespace: longhorn-system
spec:
  dataEngine: v2
  minNumberOfCopies: 3
  sourceType: download
  sourceParameters:
    url: https://longhorn-backing-image.s3-us-west-1.amazonaws.com/parrot.qcow2
  checksum: bd79ab9e6d45abf4f3f0adf552a868074dd235c4698ce7258d521160e0ad79ffe555b94e7d4007add6e1a25f4526885eb25c53ce38f7d344dd4925b9f2cb5d3b

can see spec.dataEngine = v2 but status.diskFileStatusMap.dataEngine = v1
and message
message: 'failed to process sync file: the expected checksum bd79ab9e6d45abf4f3f0adf552a868074dd235c4698ce7258d521160e0ad79ffe555b94e7d4007add6e1a25f4526885eb25c53ce38f7d344dd4925b9f2cb5d3b
        doesn''t match the file actual checksum 304f3ed30ca6878e9056ee6f1b02b328239f0d0c2c1272840998212f9734b196371560b3b939037e4f4c2884ce457c2cbc9f0621f4f5d1ca983983c8cdf8cd9a'

Expected behavior
checksum correct
Support bundle for troubleshooting
N/A
Environment

Longhorn version: master-head, v1.8.0-rc1
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:  v1.31.1+k3s1

Number of control plane nodes in the cluster:
Number of worker nodes in the cluster:

Node config

OS type and version: sles 15 SP6

Additional context
did not see this symptom if using raw https://longhorn-backing-image.s3-us-west-1.amazonaws.com/parrot.raw checksum = 304f3ed30ca6878e9056ee6f1b02b328239f0d0c2c1272840998212f9734b196371560b3b939037e4f4c2884ce457c2cbc9f0621f4f5d1ca983983c8cdf8cd9a on  v2 backingimage.
Not sure if related to https://github.com/longhorn/longhorn/issues/9876
Workaround and Mitigation
N/A

cc @ChanYiLin

I think this is expected because we convert qcow2 to raw. Let @ChanYiLin elaborate more on this.

Hi @chriscchien @derekbit
Yes, this is expected, in v2 engine, there is no qcow2 format.
We convert the image to raw and store the data into the v2 engine llogical volume.

@derekbit
Should we close the issue?

Close this ticket as this is expected


#167700483 load profile details if empty

I think the bug is caused by the store registering to profile updates only after isLoggedIn is set to true in signup. while the profile is updated before this flag is set, so the store isn't updated with the initial value.
This PR closes #167700483, by:
checking in profile screen + profile edit that store is not empty
if it is then it sets the store data with current profile from userstorage

@sirpy, check the video. Now there's no error, but profile information is not loaded except until I refresh the page.


Update to libtmux 0.4

Coverage remained the same at 50.397% when pulling 33900954a768e8062900a9da95bac52940bbcbb9 on libtmux-0.4 into ecc990d12eaed658fb104a20087c03f2e961efbf on master.

Coverage remained the same at 50.397% when pulling 33900954a768e8062900a9da95bac52940bbcbb9 on libtmux-0.4 into ecc990d12eaed658fb104a20087c03f2e961efbf on master.

Coverage remained the same at 50.397% when pulling ba99c54ea34d9e864bb2820795e764c18048f031 on libtmux-0.4 into ecc990d12eaed658fb104a20087c03f2e961efbf on master.


LAB_06-Implement_Network_Traffic_Management.md

"Note:" should be translated as "Nota:", this might happen also in other labs, please check globally. These kind of issues may be related to ICE matches in translation.
Current Translation (If its  a translation issue)
Note:
Suggested Translation (if it’s a translation issue)*
Nota:
LAB_06-Implement_Network_Traffic_Management.md

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team


Completed A/D2

Sorry for the dot comments :')

It would be better if you format your code too

All good thanks for contributing , have a great day


8_1 Test Case No

Hi all,
Im facing an error Exception in thread "main" java.util.NoSuchElementException for 8_1 however all my previous test cases have passed.

Noted that there have been a few threads on this before but I have already tried those methods namely:

Double checking that Ive updated server & shop w every event
Checking my arrival class to ensure that new customers are sent to the correct event e.g. go to Leave instead of accidentally waiting...

I have also attached my Arrival execute method if anyone would like to help me double check if i did not make any mistakes!

Could it be possible if you had use orElseThrow() somewhere in Simulatete8 when the Optional is Optional.empty()?

judging from the thread tracing the error in your first screenshot, you probably called for the service times in the input too many times (more than the number of times provided) which led to the NoSuchElementException? not sure how you implemented the variable service times but you should probably check the parts of your code where you accessed the service time!
this is what worked for me: make sure you only get the service time when executing the serve event rather than when you're scheduling the serve event!

The error says orElseGet(), meaning it was probably called just a tad bit too many times. You can check the logic around there, why it gets called more than necessary.


Added google play button blue

Description
Since the google play button black already exists in the repository I have added a google play button blue as given in the issue image.

@RavindraP04  I have created the google play button blue please review my PR.

Congrats @AshutoshSingh2021 🎉, your PR got merged. To be eligible for the swags from ClueLess.
Don’t forget to star this repository. ⭐


V8b2 - error when upgrade from v8b1 to v8b2

I dont know if this important (beacuse v8b1 is beta) but:
I Replacing the original concrete Directory (from v1 to v2) --> go to this url: http://www.yoursite.com/ccm/system/upgrade. --> run update --> get message "Upgrade to 8.0.0b2 complete!"
 If not you will be missing the vendor folders and it will fail...

Hey. I do this steps of this tutorial. I dont know how to "composer install".
http://documentation.concrete5.org/tutorials/how-to-manually-upgrade-concrete5-5-7

The develop version here on github does not include the vendor libraries. You have to run the php command (command prompt on your server) "composer install". You have to do this in the root of your site folder where the composer.json is placed. That will build the vendor folder containing the vendor libraries.
Alternatively you can down a fully build version of concrete5 beta on http://c5.krasnow.me/ (with thanks to @Mnkras).

For the record, I don't think we care to support beta -> beta upgrades what-so-ever or even rc - rc upgrades. Instead we are focused on v7 -> beta or v7 -> rc.


[SPARK-19234][MLLib] AFTSurvivalRegression should fail fast when any labels are zero

What changes were proposed in this pull request?
If any labels of 0.0 (which are invalid) are supplied, AFTSurvivalRegression gives an error straight away rather than hard-to-interpret warnings and zero-valued coefficients in the output.
How was this patch tested?
Verified against current test suite. (One test needed to be updated as it was providing values of zero for labels so was failing after this patch)
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Yes, the version in MLUtils had labels of zero in the test cases, so was causing test cases to fail after my patch. It didn't look like there was a way to fix this, so I thought it better to make a patch that didn't affect potentially dozens of other packages. Any other thoughts on how to achieve this? I could add a 'minLabel' param to the MLUtils methods but that seems overly specific for this one package.

I imagine there's a better way to do this without copying code. Do you mean the common test code assumes 0 labels are permitted? then maybe it should just not do that, because it's just using any old value to test.
If it doesn't actually assume 0 labels are permitted, then its logic should still work. It's just that this test would need some additional logic to verify that 0 labels cause an exception.

Yes that’s right, in MLUtils it supplies zero-labels as test cases (ie assumes they’re allowed, which for other regression algorithms would be true). More than happy to patch that instead though if you think that’s OK – it’ll just affect presumably a lot of other test cases.
Verifying the 0-labels cause exceptions isn’t yet covered, but probably should be (separately to MLUtils). (I’ll just need to find out how to assert thrown errors in the Spark testing)
On 22 Jan 2017, 01:07 +1100, Sean Owen<EMAIL_ADDRESS>wrote:

I imagine there's a better way to do this without copying code. Do you mean the common test code assumes 0 labels are permitted? then maybe it should just not do that, because it's just using any old value to test.
If it doesn't actually assume 0 labels are permitted, then its logic should still work. It's just that this test would need some additional logic to verify that 0 labels cause an exception.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.((

It looks like there is no particular reason that ("0", Vectors.dense(0, 2, 3), 0.0) really needs to set a 0 value as the label. You could make it 1 and see that it still passes all tests.

Test build #3544 has started for PR 16652 at commit b07c281.

Test build #3544 has finished for PR 16652 at commit b07c281.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

I've addressed all the problems I think – code style now fixed, MLTestingUtils patched (and verified all MLLib test cases still pass), and added a test case for zero-valued labels

This is looking OK to me, but it needs a (squash, optionally, and) rebase now before it can test again.

Test build #3551 has started for PR 16652 at commit cfdd286.

Test build #3551 has finished for PR 16652 at commit cfdd286.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

looks good to me too.  I just added a small suggestion.  Thanks!

Test build #3552 has started for PR 16652 at commit c855976.

Test build #3552 has finished for PR 16652 at commit c855976.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #3554 has started for PR 16652 at commit c855976.

Test build #3554 has finished for PR 16652 at commit c855976.

This patch fails PySpark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

The core change is looking OK @admackin but seems like it fails Python tests? if you have a moment to look at that, could be all that's needed to get this over the line.

gentle ping @admackin


Made OrderProcessor extendable

Made OrderProcessor handle extension hooks, i added updateGatewayData because the transactionId set here includes special characters (dash). The payment gateway i'm currently using was only accepting alphanumeric characters. Now i can simply add and extension and update the transactionId to a format workable for my case.

The reason why the transaction-id gets updated there is, that a failed attempt must have a new transaction-id.
I think you should already be able to achieve what you want by adding an extension to PurchaseService and AuthorizeService (of the silverstripe-omnipay module) where you update the id via onBeforePurchase and onBeforeAuthorize…
May I ask what gateway you're using?

Thanks for reviewing! Alright, i'll look into that option! I'm using is the Rabobank gateway.

Adding extensions to the PurchaseService and AuthorizeService works as you suggested, so i'll close this PR.
I did need to make an alteration to the data passed to the onBeforePurchase method though, it was cast into an array that could not be modified. Casting it into an ArrayData object makes it editable. I'll scan trough the PaymentServices and summit a PR there 👍


get_forward_data is deprecated with no suggestion of replacement

warnings.warn("get_forward_data() is deprecated", FutureWarning)

refere to pandas-datareader package


Support pydantic 110

Codecov Report
Base: 96.84% // Head: 96.65% // Decreases project coverage by -0.19% :warning:

Coverage data is based on head (e674783) compared to base (d0e491e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   96.84%   96.65%   -0.20%
==========================================
  Files          12       12
  Lines        1046     1046
==========================================
- Hits         1013     1011       -2
- Misses         33       35       +2

Impacted Files
Coverage Δ

sphinxcontrib/autodoc_pydantic/events.py
93.33% <0.00%> (-6.67%)
:arrow_down:

...xcontrib/autodoc_pydantic/directives/directives.py
97.34% <0.00%> (-0.89%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How to install version  5

installed via npm install telegraf-inline-menu
but the system instal version 4
How to install version 5

you can specify the version at the end like this: npm install telegraf-inline-menu@latest
If you do not specify it, it will default to latest.
in order to get v5 you can use npm install telegraf-inline-menu@next as next is a tag which currently points to the latest v5 version.
you can see more about the available versions and tags here: https://www.npmjs.com/package/telegraf-inline-menu?activeTab=versions

Thanks,
With npm install telegraf-inline-menu@next v5 was installed


ListView inside SlidingUp Panel

I added listview as the second view in the layout then the following issues are happening

Listview is taking up all the touch events.
When Panel is in full mode then event Listeners are arbitrarily chosen

Dupe of https://github.com/umano/AndroidSlidingUpPanel/issues/116. Work in progress.


Duplicated tests

Hey, 'removeProperties' tests are duplicated.

I will delete it after the task deadline.


Bugfix: recursive resolveCfImportValue() fails

Hotfix for an issue that is triggered if the CF value you want to import is not on the 1st page returned by AWS. (First page returns 100 records)
The recursive call to resolveCfImportValue() did not use the right parameters, which led to the following error:
TypeError: provider.request is not a function

TODO:

[ ] Testing

Codecov Report

Merging #62 (5101bce) into main (87b034d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   75.45%   75.45%
=======================================
  Files           3        3
  Lines         383      383
  Branches       31       31
=======================================
  Hits          289      289
  Misses         80       80
  Partials       14       14

Impacted Files
Coverage Δ

src/utils/utils.js
13.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b034d...5101bce. Read the comment docs.


Allow authentication using IAM EC2 instance profile or environment variables

Driver version
2.0.900
Redshift version
PostgreSQL 8.0.2 on i686-pc-linux-gnu, compiled by GCC gcc (GCC) 3.4.2 20041017 (Red Hat 3.4.2-6.fc3), Redshift 1.0.33595
Client Operating System
Ubuntu 20.04
Python version
Python 3.8.10
Problem description
When using IAM authentication, the driver does not seem to delegate to boto3. It doesn't pick up environment variables (AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN) or use the EC2 instance metadata service like boto3 normally would.
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html#configuring-credentials
What do I need to pass to connect() to have it delegate to boto3?
Python Driver trace logs
>>> conn = redshift_connector.connect(
...     iam=True,
...     database='xxx',
...     db_user='xxx',
...     cluster_identifier='myredshift',
...     region="us-west-2",
...  )
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/venv/lib/python3.8/site-packages/redshift_connector/__init__.py", line 327, in connect
    IamHelper.set_iam_properties(info)
  File "/tmp/venv/lib/python3.8/site-packages/redshift_connector/iam_helper.py", line 123, in set_iam_properties
    raise InterfaceError(
redshift_connector.error.InterfaceError: Invalid connection property setting. Credentials provider, AWS credentials, Redshift auth profile or AWS profile must be provided when IAM is enabled

Hey @rectalogic, thanks for the heads up.

When using IAM authentication, the driver does not seem to delegate to boto3. It doesn't pick up environment variables (AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN)

A fix will be made in our next release.

or use the EC2 instance metadata service like boto3 normally would.

The team will work on implementing this, I'll keep this issue updated with the status.

@rectalogic , v2.0.901 has been released. Please try using this version

Thanks, this seems to work.


Use docker for all CI tests and images

Previously we were somewhat half-Docker, half-Travis, half apt-get, etc. This
commit alters the CI infrastructure to use Docker images for each target. This
should make it much easier to update the images and tweak various bits and
pieces of installed software. Additionally, it's also much clearer now what's
needed for each suite of tests!
Some images were updated a bit (e.g. musl is now 1.1.14), but other images
encountered failures when updating so they're not getting updated just yet.

@alexcrichton: no appropriate reviewer found, use r? to override

@bors: r+

:pushpin: Commit d9c66fe has been approved by alexcrichton

:hourglass: Testing commit d9c66fe with merge 19bf9c7...

:broken_heart: Test failed - travis

@bors: r+

:pushpin: Commit 3eb4a48 has been approved by alexcrichton

:hourglass: Testing commit 3eb4a48 with merge ee6613d...

:sunny: Test successful - status-appveyor, travis


bug: guard against decrypting assets twice fixes #482

Implementation of a simple guard to prevent decrypting the TLS assets twice.

Not the preferred solution for good reasons! Closing this PR.


Update for Nx v17 is needed

nx-firebase v2.1.2 has problemes with Nx v17.
Building functions creates a gigantic main.js file. And the deployment command fails.
Works fine with Nx v16.
main.js sample (191524 lines)
var __create = Object.create;
var __defProp = Object.defineProperty;
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
var __getOwnPropNames = Object.getOwnPropertyNames;
var __getProtoOf = Object.getPrototypeOf;
var __hasOwnProp = Object.prototype.hasOwnProperty;
var __require = /* @__PURE__ */ ((x) => typeof require !== "undefined" ? require : typeof Proxy !== "undefined" ? new Proxy(x, {
  get: (a, b) => (typeof require !== "undefined" ? require : a)[b]
}) : x)(function(x) {
  if (typeof require !== "undefined")
    return require.apply(this, arguments);
  throw Error('Dynamic require of "' + x + '" is not supported');
});
var __esm = (fn, res) => function __init() {
  return fn && (res = (0, fn[__getOwnPropNames(fn)[0]])(fn = 0)), res;
};
var __commonJS = (cb, mod4) => function __require2() {
  return mod4 || (0, cb[__getOwnPropNames(cb)[0]])((mod4 = { exports: {} }).exports, mod4), mod4.exports;
};
var __export = (target, all) => {
  for (var name in all)
    __defProp(target, name, { get: all[name], enumerable: true });
};
var __copyProps = (to, from, except, desc) => {
  if (from && typeof from === "object" || typeof from === "function") {
    for (let key of __getOwnPropNames(from))
      if (!__hasOwnProp.call(to, key) && key !== except)
        __defProp(to, key, { get: () => from[key], enumerable: !(desc = __getOwnPropDesc(from, key)) || desc.enumerable });
  }
  return to;
};
var __toESM = (mod4, isNodeMode, target) => (target = mod4 != null ? __create(__getProtoOf(mod4)) : {}, __copyProps(
  // If the importer is in node compatibility mode or this is not an ESM
  // file that has been converted to a CommonJS file using a Babel-
  // compatible transform (i.e. "__esModule" has not been set), then set
  // "default" to the CommonJS "module.exports" for node compatibility.
  isNodeMode || !mod4 || !mod4.__esModule ? __defProp(target, "default", { value: mod4, enumerable: true }) : target,
  mod4
));
var __toCommonJS = (mod4) => __copyProps(__defProp({}, "__esModule", { value: true }), mod4);

my main.ts
/**
 * Import function triggers from their respective submodules:
 *
 * import {onCall} from "firebase-functions/v2/https";
 * import {onDocumentWritten} from "firebase-functions/v2/firestore";
 *
 * See a full list of supported triggers at https://firebase.google.com/docs/functions
 */

import {onRequest} from 'firebase-functions/v2/https';
import * as logger from 'firebase-functions/logger';
import {setGlobalOptions} from "firebase-functions/v2";
import {getAuth, UpdateRequest} from "firebase-admin/auth";

initializeApp();
setGlobalOptions({ region: 'europe-west9' });

// Start writing functions
// https://firebase.google.com/docs/functions/typescript

 export const updateAuthUser  = onRequest(async (req, res) => {
   try {
     const body = req.body as {uid: string, data: UpdateRequest};
     const userRecord = await getAuth().updateUser(body.uid, body.data);
     res.status(200).send(userRecord);
   } catch (e) {
     logger.error(e);
     res.status(500).send(e);
   }
 });

Blerg - this is esbuild bundling external dependencies. It shouldn't do this, but I've see it do it sometimes with some Nx versions.
Please can you share which Nx version you were using?
I'll try and look at this soon.

Hello, it was nx v17.1.3

Quick update on this: @nx/esbuild executor option [thirdParty=false](https://nx.dev/nx-api/esbuild/executors/esbuild#thirdparty) tells Nx esbuild to NOT include external dependencies in the bundle.
I've got a compatibility test suite here that generates an Nx workspace for every Nx version, installs the plugin and generates/builds a firebase + function app project to verify compatibility.
Guess what, it passes in Nx version 17.3.1 (the version you are having problems with) but generates the faulty mega-bundle in versions 16.1.4, 16.2.2, 16.3.2, 16.4.3, 16.5.5, 16.6.0, 16.7.4.
Nx version 16.8.1 onwards is fine.
This is highly suspect, because it didn't do this for me before. Some fragile code somewhere in Nx is my hunch right now.
I will keep digging a bit now I have a repro.

Ran the same test suite again in a different output directory and now all of the output bundles are correct 🤔

Another update, I went back to the original test suite folder and ran npx nx reset followed by npx nx build functions manually (rather than from my automated test suite) and this time that also builds the correct bundle.
@pfpoujol if you get a chance, please could you try the same cmd line sequence:

npx nx reset
npx nx build functions (or whatever your function app project above is called)

And see if the bundle still contains external dependencies?
I dont see why the behaviour would change since the esbuild options are the same, but trying to home in on the problem here.

Hi @simondotm sorry for the late reply.
I tried the same cmd line sequence and the bundle still contains external dependencies.

The problem seems to lie here in the Nx esbuild plugin: https://github.com/nrwl/nx/blob/f1849a792d477c287841900bf1657fb73d6ad80b/packages/esbuild/src/executors/esbuild/esbuild.impl.ts#L64
In my local setup where esbuild bundles external deps even when thirdParty is false, Nx does not seem to be detecting there are external dependencies at all (thirdPartyDependencies array is empty)
I dont know yet why this happens. :/

As a workaround i use my custom esbuild config and set packages: 'external' which since<EMAIL_ADDRESS>correctly understand local aliased packages and packages from node_modules. You can pass this configuration either in the esbuildOptions: {} in project.json or in the separate config "esbuildConfig": "{projectRoot}/build.cjs", which i choosed because wanted to use esbuild plugins:
const { swcPlugin } = require('esbuild-plugin-swc');

/** @type {import('esbuild').BuildOptions}  */
module.exports = {
  plugins: [
    swcPlugin({
      jsc: {
        parser: {
          syntax: 'typescript',
          decorators: true,
        },
        transform: {
          decoratorMetadata: true,
          legacyDecorator: true,
        },

        externalHelpers: true,
        target: 'esnext',
      },
    }),
  ],
  treeShaking: true,
  packages: 'external',

  tsconfig: '../../tsconfig.base.json',
  logLevel: 'info',
};

Any updates here? I'm seeing the same errors
nx reset did not work for me either..

I'm starting to wonder if the plugin should generate an esbuild config for firebase functions in the workspace root, which all function projects use.
This way, it is easier to customise function builders for plugins, and control behaviour externally to Nx.

Another possibility is that issue #191 is causing problems with @nx/esbuild plugin versions.
I've been running & tweaking my compatibility tests the past two days, and versions since Nx 16.8.1 are reliably passing the esbuild mega bundle check, whereas prior versions are unreliable on this test.
I'm going to fix 191 and then see if it resolves this issue too.

I'm reasonably confident that the changes in plugin release v0.2.2 combined with use of Nx versions >=16.8.1 no longer manifests this issue.
The next plugin release will require a minimum Nx version of 16.8.1 to help ensure this.
Closing for now.


Options object are ignored

Hello, i just investigated that in index.js you are parsing "options" from gulp but in file index.js on line
https://github.com/hard8candy/gulp-angular-translate-extractor/blob/master/index.js#L89
var _translation = new Translations({
        "safeMode": options.safeMode,
        "tree": false,
        "nullEmpty": false
      }, results),

You are overriding options, should not be
var _translation = new Translations(otpions), results)

Or it is there on purpose ? Please let me know if i am correct , then i can make PR.

Hello,
sorry for a log delay with an answer!
'options' object contains not only Translations settings (safeMode, tree,...), but also some other options (startDelimiter, endDelimiter, dest,...).
And I prefer this way (in the repository now):
var _translation = new Translations({
        "safeMode": options.safeMode,
        "tree": options.tree,
        "nullEmpty": options.nullEmpty
      }, results),

Thanks.


Galaxy roles should be prefixed with organisation

The dependencies of galaxy roles have the form openmicroscopy.basedeps, however the playbooks in this repository expect a role name without a prefix (just basedeps). As a result some roles are installed twice, with and without the prefix.
Proposed fix: all playbooks using Galaxy roles should use the prefix.

What are the alternatives? e.g. using name: aggressively to not have duplicates?
- src: openmicroscopy.basedeps
  version: ...
  name: basedeps

Questions that this raises for me:

will users want to overwrite with updating playbooks (i.e. swap to someuser.basedeps in requirements.yml`)
if we use openmicroscopy.basedeps everywhere, should we also prefix the variable names further?

What are the alternatives? e.g. using name: aggressively to not have duplicates?

That might work, but most galaxy roles/examples seem to use PREFIX. in playbooks.

will users want to overwrite with updating playbooks (i.e. swap to someuser.basedeps in requirements.yml`)

Do you mean always use the prefix in playbooks?

if we use openmicroscopy.basedeps everywhere, should we also prefix the variable names further?

Don't know, other galaxy roles that I've looked at don't, and chances are if you're running two roles with the same name in the same playbook you're asking for trouble.

Do you mean always use the prefix in playbooks?

No, that would point to not prefixing.

if you're running two roles with the same name in the same playbook you're asking for trouble.

Doesn't that also suggest not prefixing?

Doesn't that also suggest not prefixing?

That was in response to your comment about prefixing variables with the galaxy org. My proposal is to prefix the roles when they're d playbooks, but not the variables since I don't think you're likely to want to use two roles with the same name from different organisations.


[10.x] Possible fix for unexpected column in SQL Server offset

Looking for feedback on this PR for resolving this issue:
Currently, if offset is used for SQL Server:

You cannot use row_num as a column name or alias
An unexpected column row_num is included in the results

This PR helps reduce query select conflicts and removes unexpected data generated by laravel.
Changes:

Renamed temporary column row_num to temp_row_num to help reduce conflicts
Removes the temp_row_num column from the results if offset used

Fixes https://github.com/laravel/framework/issues/44354
Examples
Scenario 1
If you have a row_num column or alias, SQL Server will throw:
SQLSTATE[42000]: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The column 'row_num' was specified multiple times for 'temp_table'

Scenario 2
If you try to insert the offset results into the same table by using chunk:
db()->connection('db_1')->table('example')->chunk(500, function($chunk){
    db()->connection('db_2')->table('example')->insert($chunk);
});

row_num is added to the results and is an unexpected column, causing SQL server to throw:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'row_num' in 'field list'

Original PR: https://github.com/laravel/framework/pull/44355

Hi @staudenmeir, @yansern and @garygreen -- do you both have any input on this issue and solution?
Or should we instead use OFFSET and FETCH instead of the current row_number() implementation?
This should remove the need for a row_num column as well.
From the community:

https://github.com/laravel/ideas/issues/1006
https://github.com/laravel/framework/issues/20814 - Same issue given in example "Scenario 2".
https://github.com/staudenmeir/laravel-cte/issues/35 - soultion it so only select columns from the table the person is trying to query so row_num will not be returned
https://github.com/laravel/framework/issues/7568 -

HI @dunhamjared,

Renamed temporary column row_num to temp_row_num to help reduce conflicts
Removes the temp_row_num column from the results if offset used

Renaming the column definitely makes sense. Not sure if we do it consistently, but we use laravel_ as a prefix for internal columns in other places.
I would say that this is a breaking change and needs to go into the next major release. There could be people that actually use the row_num in their applications. Definitely an edge case, but we can't rule it out completely.

Or should we instead use OFFSET and FETCH instead of the current row_number() implementation?

What's the minimum required SQL Server version for that?

@staudenmeir

I would say that this is a breaking change and needs to go into the next major release. There could be people that actually use the row_num in their applications. Definitely an edge case, but we can't rule it out completely.

Completely agree, I will create a new PR to master.

What's the minimum required SQL Server version for that?

2012 (source), below our minimum support version. Woo!

Renaming the column definitely makes sense. Not sure if we do it consistently, but we use laravel_ as a prefix for internal columns in other places.

Good to know, thanks!
It also seems that OFFSET/FETCH is generally faster and less expensive than row_number() - source

2012 (source), below our minimum support version. Woo!

That's good. Laravel only supports 2017+, but I’m sure that quite a few people use Laravel with older versions (since almost all query features still work there). So Laravel is technically “allowed” to rely on 2017+ features, but it still needs to be considered that people aren't happy when pagination no longer works on their SQL Server 2008/2012 app (even though it happened because of a major update).

Working on new PR for master branch.


refactor: update the block production race

Motivation
Simplify the implementation of race promise
Description

Simplify the promise race implementation
Remove the event handling of the promise race
Improve the block production race

Steps to test or reproduce

Run all tests

please remove promise race changes and only add body optimization

This PR is just for the promise optimization. The PR for block body will come separate.

early return has not been implemented, events have not been implemented, recommended using switch to be more typesafe

@g11tech The major concern of this refactor is to remove the events from the async call, as it's anti-pattern to mix async code with callbacks. And also the exact same behavior is achieved without events in much simple way.

early return has not been implemented, events have not been implemented, recommended using switch to be more typesafe

@g11tech The major concern of this refactor is to remove the events from the async call, as it's anti-pattern to mix async code with callbacks. And also the exact same behavior is achieved without events in much simple way.

events serve an important debugging tool, i would even go to the extend of calling it a feature, if there is no other way to add event, i suggest adding back the callback and events

events serve an important debugging tool, i would even go to the extend of calling it a feature, if there is no other way to add event, i suggest adding back the callback and events

If we want event based logic, then it should be pure event based logic with an emitter rather a callback. And the whole ecosystem moved away from such event based flows, where ever possible and I believe this is one of the use case where we don't need events.
I don't see any debugging information which is left in current implementation, if think so please suggest what further logging can help you debug the flow.

events serve an important debugging tool, i would even go to the extend of calling it a feature, if there is no other way to add event, i suggest adding back the callback and events

If we want event based logic, then it should be pure event based logic with an emitter rather a callback. And the whole ecosystem moved away from such event based flows, where ever possible and I believe this is one of the use case where we don't need events.
I don't see any debugging information which is left in current implementation, if think so please suggest what further logging can help you debug the flow.

can you add back the previous events in the test and let see if they match up
in case you want to emit events and then log them i am fine.

It is probably quite subjective but I find it harder to reason about how we choose block now (see other comments below)

I also feel the same, the entire refactor should have been bound off the race function itself with may be changes to the calling fn to compy with the new function

I also feel the same, the entire refactor should have been bound off the race function itself with may be changes to the calling fn to compy with the new function

I found it difficult to understand that point. The conditions are exactly the same as were earlier.

If engine produces, builder failed we select engine
If engine failed, builder produces we select builder
If both failed we throw error
If both pending we throw error
If both produces, we select based on a defined logic.

Earlier this flow was buried under 5-6 levels of indented code blocks, now these conditions are procedural and clear conditions on same indentation level.
If you found some conditions are not clear suggest the changes.

How else we can make the code flow more clear? See comparison of two images below.

The edge cases where one of the blocks failed should be handled later as those are much less common.

I don't disagree to you but that's a very subjective approach.
You may find it clear flow, I found it difficult. Those edge cases are guard conditions, and guard conditions always appear in start to make flow more clear.

The refactoring should ideally also not change the behavior of the code (this also includes logs), which it does in case of builder override (see #6241 (comment))

Any refactoring may change the behavior, but not the outcome, which is true in this case as well. Related that log message, I found it wrong to earlier so why updated it. If both produces block and then we choose engine because of shouldOverrideBuilder only then we should log that censorship message, otherwise it will be misleading for user.

hmm, the indentation seems to be the same before and after (8 spaces)

You didn't saw the indentations after opening up those braces.

This makes me wonder if such a big refactor is even worth it if we have to change it again anyways.

I would never think it a big refactor, just removing the event callbacks from async code and making flow more linear is still an improvement in the code.

This refactor appears because of a general discussion I had with @wemeetagain over racePromisesWithCutoff code mixing of async code with callbacks. Let's get his opinion for the second time.

Does this change to the promise race make it easier to return early? i.e. if we receive a boost factor of 0 we know that we will always pick the engine block, hence we should not wait for the builder block and return early to reduce risk of orphaning the block.

Using @nazarhussain 's approach here, it was pretty easy to address https://github.com/ChainSafe/lodestar/pull/6241#discussion_r1462947877
We return early if shouldOverrideBuilder is true or if the boost factor is 0.
Also took the opportunity to normalize the log metadata.
Take a look and see what you think.

@wemeetagain I didn't noticed you pushed a commit to this branch. I added the early abort behavior in a different way. Please review.
Related to boostFactor zero, in that case I would not even consider to run builder flow at all, instead of early aborting.

Related to boostFactor zero, in that case I would not even consider to run builder flow at all, instead of early aborting.

This is not correct as engine block might fail in which case we should produce a builder block.
See apis/validator/block.v3.yaml#L63-L64

builder_boost_factor=0: prefer the execution node payload unless an error makes it unviable.

There is also a 3rd scenario, if validator passes executionalways which is currently not implemented but we discussed adding this in the next release (https://github.com/ChainSafe/lodestar/issues/6305).

@wemeetagain @g11tech @nflaig The promise implementation is re-implemented to make it type-safe. Hope remaining concerns will also be addressed now.

I don't think we do, to support better readability I think we should avoid to add suffixes to arleady long variable names.

That's just the matter of approach, add eth to key or ETH to value. I will leave it to @wemeetagain preferences here.

I don't think we do, to support better readability I think we should avoid to add suffixes to arleady long variable names.

That's just the matter of approach, add eth to key or ETH to value. I will leave it to @wemeetagain preferences here.

Let's revisit this topic in another PR, we should reuse the prettyWeiToEth in validator as well

@g11tech If you still have any feedback, will be happy to cover in separate PR.

:tada: This PR is included in v1.16.0 :tada:


implement rand for WH/BH

Issuing an sfpmov from register 9 using mod value 8 creates a random int
This isn't exposed through the sfpi wrapper
This may work easily in the wrapper, but not sure w/o looking if compiler/assembler support mod value 9 or need to be updated.
Code would look something like the following (as an API level workaround):
vInt rand_gen = l_reg[LRegs::LReg 9];
vInt rand = __builtin_rvtt_sfpmov(rand_gen.get(), 8);

fyi @amahmudTT

We have to model this in the compiler, so that it knows multiple calls can produce different values -- i.e. CSE doesn't apply.
vint __builtin_rvtt_sfprand() __attribute__((volatile));

It'd be nice to not be quite that volatile -- so memory objects don't have to be synced, and dead calls can be eliminated.  Perhaps that's possible
expose this in an inline:
sfpi_inline vint vec_rand() {
  return __builtin_rvtt_sfprand();
}


Test and fix for multidicts' .items(), .keys() and .values() repr

abc.ItemsView / KeysView / ValuesView has __repr__ method but it expects that data is stored in ._mapping attribute.

Also fixed a typo in _multidict.pyx

Thanks!


ignore dependabot branches from triggering workflow

This should fix the problem in #256 by disabling the workflow for dependabot actions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 90.336%

Files with Coverage Reduction
New Missed Lines
%

sed/binning/binning.py
1
96.62%

sed/binning/utils.py
1
83.93%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
4917

Relevant Lines:
5443

💛  - Coveralls

We could also limit this from only running on the main branch.


Ignore with reason or fix failing tests in CI

Many tests are failing in CI and have been for quite some time, some of which are actively being worked on while others should be ignored.

@andrewvious

vrrb_grpc was actually removed but the CI test still remains, could you remove that as well as part of this issue?


ModuleNotFoundError: No module named 'deepcompressor.backend'

I can import deepcompressor but not to use T5

Could you provide more error information?

Could you provide more error information?

I have solved this issue; it was mainly due to duplicate paths in the library.And I have another important issue: the current model only supports inference for aspect ratios of 65536. How can I modify the model to support multiples of 8 to accommodate the sizes I need?


Cannot reproduce this experiment

Hi,
I tried to run this code to reproduce the accuracy of 85%. But I have executed 3 times and got only 53% accuracy each time.
Could you please tell me some tips about the instructions to run this code or set parameters?
I did't change any code and used the command python train.py --dataset rocstories --desc rocstories --submit --analysis --data_dir [path to data here] in readme.
Thanks

I get accuracy of ~85% on ROC 2016 without having to change any parameters aside from --n_gpu, which I set to 1, just because I wanted to use only 1 GPU (if --n_gpu 2, then the default training batch size is 8x2=16, which caused out of memory issues on my GTX 1080).

Thank you so much for your reply.
I got 87% after I set n_gpu to 1. I think there may be a problem in implementation of multi-gpu. I test default n_gpu = 4 on a server with 8 Tesla K80 4 times but only get 53%.

i got 53% in python2.7 with tensorflow 1.2，while 87% with python 3.6 and tensorflow 1.6.maybe you should check the version of tensorflow

This looks to have been due to an implementation difference between python 2 and python 3. Only python 3 is supported but I've removed the code that was likely causing this issue as discussed in #21


Create upgrade_installer transformer

This transformer will be used to update Ubuntu packages to test proposed repositories in a new pipeline.

@squirrelsc based on our discussions, I think I will simplify the transformer. It will be a package upgrade transformer with an option for upgrading from proposed. Then to achieve the different test scenarios, we will have to add functionality to LISA to be able to optionally run the transformer for every VM deployment.
Please let me know if you have any comments on this approach.

@squirrelsc based on our discussions, I think I will simplify the transformer. It will be a package upgrade transformer with an option for upgrading from proposed. Then to achieve the different test scenarios, we will have to add functionality to LISA to be able to optionally run the transformer for every VM deployment.
Please let me know if you have any comments on this approach.

LGTM


Add a new phase for enrichers

So enrichers can

addDefaultResources() when there are resources missing in a KubernetesList
adapt() add the end of the processing to do some fine tuning on the generated list (not yet used yet)

Maybe one should detangle the 'enriching' and the 'defaulting' into two separate interfaces. But lets wait for now how this evolves.

[merge]


Modify the Set-AzureRmVMDiagnosticsExtension cmdlet to improve the ability to automate the install/config of diagnostics extension

BACKGROUND
The cmdlet Set-AzureRmVMDiagnosticsExtension is touted as a way to automate the installation/configuration of the diagnostics configuration on an Azure VM as described here:
Use PowerShell to enable Azure Diagnostics in a virtual machine running Windows
https://docs.microsoft.com/en-us/azure/virtual-machines/extensions/diagnostics-windows#sample-diagnostics-configuration
A review of the Set-AzureRmVMDiagnosticsExtension documentation indicates you need to create virtual machine specific XML file defined by the "-DiagnosticsConfigurationPath" switch for each VM you want to configure.  There is a single line in the file that makes it unique for each virtual machine you want to configure:
           <Metrics resourceId="(Update with resource ID for the VM)" >
PROBLEM
If you want to automate the installation of the diagnostics extension for hundreds of virtual machines you would need to customize an XML file for each virtual machine. For a hundred virtual machines you would need a 100 XML config files.  This cumbersome requirement makes automation via PowerShell more labor intensive than using the portal to point and click.
RECOMMENDATION
Remove the dependency to have the virtual machine resource ID ( <Metrics resourceId="(Update with resource ID for the VM)" >) in the XML file and add virtual machine resource ID as a switch on the cmdlet.  Doing this would let a person use the same XML config file for hundreds of extension deployments.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1004d268-8e8b-a08c-f31d-5b099cb38132
Version Independent ID: 732f5f54-eb4b-97f3-a46a-d07825bd3e34
Content: Use Azure PowerShell to enable diagnostics on a Windows VM
Content Source: articles/virtual-machines/extensions/diagnostics-windows.md
Service: virtual-machines-windows
GitHub Login: @sbtron
Microsoft Alias: saurabh

Thanks for this.
Please file your product feedback on this feature on the Azure Powershell GitHub or you can also provide feedback from the command line using the Send-Feedback cmdlet.


Gravity readings on LCD display

Is it possible to show the gravity readings on the LCD display?

Working on it (but as a firmware feature)


Test basic paradigms for all "declinable" parts-of-speech

Fixes #127

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   79.36%   79.36%
=======================================
  Files          53       53
  Lines        1856     1856
=======================================
  Hits         1473     1473
  Misses        383      383

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae0dce...5a7d78b. Read the comment docs.


Placing an Anvil results on a temporal null block

Version: <IP_ADDRESS>
It appears on singleplayer, and the block is useless until the error dissapears.
The error dissapears on chunk reload.
May be a server-side error, because i tried to do a 'testforblock  anvil' and didn't match.

Please provide me with your latest debug.log file and a complete mod list.

It stopped happening, probably because some mods updated.

Thanks for information. For future reference, check back on your created issues and close them yourself when they are fixed.

I just noticed that the anvil worked about an hour ago.


cardano-node always using 100% CPU in Daedalus

I'm not sure if this is the right place. But I've noticed that when running cardano-node from Daedalus - it always uses 100% CPU.
cardano-node has ghc-options set to disable idle GC. But I suspect that since cardano-node is launched through cardano-launcher it inherits the GHC options set (just RTS -N). Is there anyone that knows more about GHC and RTS inheritance to confirm and perhaps fix this?

@ksaric Sorry for tagging, but you seem to have been the top contributor to this project. Do you know if cardano-launcher could be the cause?

@weebl2000 I'm no longer with IOHK, but having said that, I really doubt this is the case. You should provide more data and information for the folks at IOHK to be able to provide you with an answer.

I can confirm this for 4.9.0 on Linux. Minimum one core, but most of the time all cores are under full load of the cardano-node.


files.restoreUndoStack no longer works

Type: Bug
Since the latest VSCode update the disabled files.restoreUndoStack setting has no actual effect on the Undo stack when I close a file and reopen it. The Undo stack is preserved, but it shouldn't be.
VS Code version: Code 1.94.0 (d78a74bcdfad14d5d3b1b782f87255d802b57511, 2024-10-02T13:08:12.626Z)
OS version: Linux x64 5.15.0-122-generic snap
Modes:

/duplicate of #230453 which is slated for 1.94.2 recovery


Injecting factory itself

Described here.
Can be implemented by adding property provider as in PDI. This property will return a factory object which must be called without args.
Opened question: should this factory be callable or awaitable. If callable, than async resources must be preinitialized

Opened question: should this factory be callable or awaitable. If callable, than async resources must be preinitialized

We can add both: .provider and .sync_provider.

Rhymes with resolve() and sync_resolve().