search bar placeholder is cut off incorrectly

Current Behavior

placeholder text is not shown correctly in search bar
Desired Behavior
correctly configure placeholder dimensions
Environment

Browser:  Firefox
Host OS: Linux
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Screenshot? // @sudhanshutech

I can work on this

@leecalcote can I work on this issue ?

Can I work on this issue @EraKin575

@EraKin575 i don't see any cut off of placeholder in any where will you please confirm this issues still exist

I think its a device problem. On my device,the upper part of placeholder text seems cut off . Please refer to screenshot

Could you please assign the issue to me ?

Could you please assign this issue to me?
Helen

Lets get Helen assign this as discussed in meet. Let get you folks assign other issues

Hi All,
I dont find the placeholder to be cut off in search bar. I checked with chrome, firefox and mobile phone. I haven't found this issue.


Update available environment variables so the user does not need to restart their terminal

Description of the new feature / enhancement
Some software that is installed adds itself to the PATH environment variable. These changes are not surfaced to the current terminal session and requires the user to close the terminal and open it again. I consider this to be a huge blocker for creating fully automated software installations as the environment variables it added are often needed in the next step.
Consider NVM as per the docs here: https://learn.microsoft.com/en-us/windows/dev-environment/javascript/nodejs-on-windows
winget install --id=CoreyButler.NVMforWindows  -e

Followed by another line in the same script (again, as per the docs):
nvm install latest

Results in:
PS C:\Users\User\AppData\Roaming\nvm> nvm install latest
nvm : The term 'nvm' is not recognized as the name of a cmdlet, function, script file, or operable program.

Proposed technical implementation details
WinGet or Terminal should update the user environment variables in order to unblock automated installations of software

@stephengillie - Area-Path also

Duplicate of #3067

Duplicate of #222

I had the same problem.
This solution seems to work for me.
winget install --id=CoreyButler.NVMforWindows  -e --silent

$env:NVM_HOME = [System.Environment]::GetEnvironmentVariable("NVM_HOME", "User")
$env:NVM_SYMLINK = [System.Environment]::GetEnvironmentVariable("NVM_SYMLINK", "User")
$env:Path = [System.Environment]::GetEnvironmentVariable("Path", "Machine") + ";" + [System.Environment]::GetEnvironmentVariable("Path", "User")

nvm install 18.6.0
nvm use 18.6.0

@denelon

Totally agree that PATH should be reloaded after installing package so i can use it right away, similar feature request for chocolatey https://github.com/chocolatey/choco/issues/2458

We're currently working on the dependency flow:

https://github.com/microsoft/winget-cli/issues/2939

You may also want to take a look at:

https://github.com/microsoft/winget-cli/issues/549

We're looking at a few scenarios related to the path, and there is discussion and a possible workaround as well as some design work on how we might achieve this.

Has there been any advancements regarding this issue?


Unused import false positive when using unnamed imports

Sometimes, the extension will highlight an unnamed import (eg `import "../src/Contract.sol") as unused even though it is used. In my case, this happens when the file importing from has multiple contracts but I don't know whether this is actually the issue. If this is useful, I can experiment and try to find the root cause of the issue

Sorry for the delayed response.
The issue arises if you have use an imported contract from other file.
For ex, you have 2 contracts: Contract A and Contract B. If Contract B tries to use imports from contract A, it will not be detected by this extension. For now, it only detects unused imports in the current file to keep things simple.  I agree it would be more useful to detect unused imports across different files.
If you can add the feature, PRs are more than welcome :) I'm happy to review!

Another false positive is happening with free functions, if you don't use named imports the extension will mark the whole import as unused.

Agreed. Currently, highlighting unused imports works best for named imports.
I believe named imports should be adopted by default so that readers know what contracts are being used from the imported file. It also helps to make the imports consistent. Unfortunately that's not the case now.
One way to fix this is to index the contract names in each of the files and check if the contract has been used in the current file. I wanted to keep it simple, but this change looks quite complex and I also suspect it might have some perf issues for larger projects. Other option is to ignore unused import highlights for unnamed imports.


Visualize cell delimiters

E.g. add a Matlab-like line over ##s.

Even nicer would be to have cell-delimiters on the minimap. This would greatly simplify navigation through a long file.


355 execute command in terminal returns wrong output on windows

Not sure if it's possible to somehow get log.html out of runner, if not then maybe it would be good enhancement to more easily debug those kind of errors.

that is being done here: https://github.com/Dasharo/open-source-firmware-validation/pull/410

Maybe there is no windows installed on runner QEMU?

It is not. @JanPrusinowski This test should not be executed in CI right now, as there is no OS in what we have right now.

@macpijan I have excluded this test from run if run on qemu.

Replaced with: https://github.com/Dasharo/open-source-firmware-validation/pull/429/files


DTLS fixes for TinyDTLS client

Description
I need to support clients that use a very old DTLS implementation from TinyDTLS
https://projects.eclipse.org/projects/iot.tinydtls
There are two problems:

The client does not advertise any extensions, and currently if there are no extensions, the handshake is dropped.  This was an easy fix to allow for 0 extensions.

The second problem is that the client establishes two connections using the same source IP:Port, so it will perform a full handshake and exchange some app data, then it will begin a new handshake on the same IP:Port combination.  This currently breaks the library because once a session is started it can't be re-created.  The fix for this is more dirty, it is specifically checking for ClientHello packets, and if detected, it closes the session, which will clean out the DTLS server's session and allow another ClientHello to be sent successfully.

The fix for no extensions seems fin to me, but I really don't like the second one. I'm not sure I want to support that. Is there some reference in TLSv1.2 RFCs about this behaviour?

For the second one, I have no problem wrapping the bypass for ClientHello in a config parameter, but for IoT use cases in general, I have seen this behavior from many devices.  Most of the devices bind to a fixed port meaning that from client to server all clients are bound to 5684, connecting to the server on 5684 so even acts like rebooting the client device cause problems because they boot and send a new ClientHello and it gets dropped because of the replay window.
I'm open to other ways to address this issue, the main problem is that a client tries to connect (by sending a ClientHello) on an IP:Port that the server already has a session for.
The "fix" itself to close the connection is definitely not right, the appropriate handling would be to start a new handshake, but it appears that this is difficult at the point in the callstack when the code determines that it needs to re-handshake.


Create publishing chapter

This finishes the empty publishing chapter. cargo-packager is the tool used, but alternatives are mentioned.

I will soon get back to https://github.com/marc2332/freya/pull/390, so maybe you can leave some reference in the docs?

Sure. The link to the example doesn't work now though, because I changed the fork branch to the main branch. So #390 needs to be merged first (unless you're fine with a broken link...).

It would be nice to also mention winresource in the instructions
the crate lets you apply a custom icon to the executable, I have updated the example with the new winresource usage
https://github.com/marc2332/freya/pull/390/files#diff-814556d4ee71407537d0eebc7e55bb0a378c7948b755d02c0bf2ce62fb89dabf

It would be nice to also mention winresource in the instructions
the crate lets you apply a custom icon to the executable, I have updated the example with the new winresource usage
https://github.com/marc2332/freya/pull/390/files#diff-814556d4ee71407537d0eebc7e55bb0a378c7948b755d02c0bf2ce62fb89dabf

Doesn't cargo-packager do this?

It would be nice to also mention winresource in the instructions
the crate lets you apply a custom icon to the executable, I have updated the example with the new winresource usage
https://github.com/marc2332/freya/pull/390/files#diff-814556d4ee71407537d0eebc7e55bb0a378c7948b755d02c0bf2ce62fb89dabf

Doesn't cargo-packager do this?

No, not for Windows. Installer icon != executable icon

It would be nice to also mention winresource in the instructions
the crate lets you apply a custom icon to the executable, I have updated the example with the new winresource usage
https://github.com/marc2332/freya/pull/390/files#diff-814556d4ee71407537d0eebc7e55bb0a378c7948b755d02c0bf2ce62fb89dabf

Doesn't cargo-packager do this?

No, not for Windows. Installer icon != executable icon

Sorry for not replying sooner. I looked at the examples and they don't use winresource, but the executables do have icons.

It would be nice to also mention winresource in the instructions
the crate lets you apply a custom icon to the executable, I have updated the example with the new winresource usage
https://github.com/marc2332/freya/pull/390/files#diff-814556d4ee71407537d0eebc7e55bb0a378c7948b755d02c0bf2ce62fb89dabf

Doesn't cargo-packager do this?

No, not for Windows. Installer icon != executable icon

Sorry for not replying sooner. I looked at the cargo-packager examples and they don't use winresource, but the executables do have icons (at least the tauri example, which is the most extensive one). I'm on Windows as well.

Sorry for not replying sooner
it's fine, I wasn't expecting an answer right away

I looked at the cargo-packager examples and they don't use winresource, but the executables do have icons (at least the tauri example, which is the most extensive one). I'm on Windows as well.

I didn't test the Tauri one, I only tried the Dioxus one. If you install it, the app will not have an icon.

You can see the discord discussion around this here. I wasn't the one who came up with using winresource, they told me themself

But...

But...

The Tauri example doesn't apply here as it depends on tauri-build and Tauri's CLI.

But...

The Tauri example doesn't apply here as it depends on tauri-build and Tauri's CLI. It is Tauri who is changing the icon, not cargo-packager.

That makes sense. I don't mind winresource, I just don't like the fact that it's only for Windows, while Freya and cargo-packager are supposed to be cross-platform. Do you know of a cross-platform solution?

Also what discord server is that?
Open the link, it is the official CrabNebula Discord Server, authors of cargo-packager

But...

The Tauri example doesn't apply here as it depends on tauri-build and Tauri's CLI. It is Tauri who is changing the icon, not cargo-packager.

That makes sense. I don't mind winresource, I just don't like the fact that it's only for Windows, while Freya and cargo-packager are supposed to be cross-platform. Do you know of a cross-platform solution?

The fact that the executable doesn't have an icon, only happens in Windows. Linux and MacOS is already handled by cargo-packager, you can read it in the conversation I had

Also what discord server is that?

Open the link, it is the official CrabNebula Discord Server, authors of cargo-packager

It doesn't invite me automatically. Had to look for it on google.

But...

The Tauri example doesn't apply here as it depends on tauri-build and Tauri's CLI. It is Tauri who is changing the icon, not cargo-packager.

That makes sense. I don't mind winresource, I just don't like the fact that it's only for Windows, while Freya and cargo-packager are supposed to be cross-platform. Do you know of a cross-platform solution?

The fact that the executable doesn't have an icon, only happens in Windows. Linux and MacOS is already handled by cargo-packager, you can read it in the conversation I had

Ok I'll add it. Sorry for being maybe a little too stubborn

Also what discord server is that?

Open the link, it is the official CrabNebula Discord Server, authors of cargo-packager

It doesn't invite me automatically. Had to look for it on google.

But...

The Tauri example doesn't apply here as it depends on tauri-build and Tauri's CLI. It is Tauri who is changing the icon, not cargo-packager.

That makes sense. I don't mind winresource, I just don't like the fact that it's only for Windows, while Freya and cargo-packager are supposed to be cross-platform. Do you know of a cross-platform solution?

The fact that the executable doesn't have an icon, only happens in Windows. Linux and MacOS is already handled by cargo-packager, you can read it in the conversation I had

Ok I'll add it. Sorry for being maybe a little too stubborn

No worries.

Hey, just letting you know that there's nothing else to add. I'm only saying this because you responded to the commits I made and I doubt you've been reviewing it for 11 hours :)

Hey, just letting you know that there's nothing else to add. I'm only saying this because you responded to the commits I made and I doubt you've been reviewing it for 11 hours :)

Don't worry, I add myself as reviewer, so I don't forget about it. I was working until just a few hours ago, so I'll check this asap

Don't worry, I add myself as reviewer, so I don't forget about it.

I know I was just confused since you replied with no notes and this is a very small change that barely needs a review. I thought you missed the fact that I made the commits and only saw the message... I didn't realize you could be at work :L

Nice! Ty!


Made the description for lastIndexOf more clear

It is stated in the cases above, what happens when the string is empty or both the string and substring are empty.
So it is not possible to have a case, where the length of the string -1 is less than zero, since the string must have at least 1 character, to enter this case.
The two subcases are removed and the only possible case is stated instead, making it more clear for the reader, what will happen.

@thygesteffensen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@thygesteffensen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@thygesteffensen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@thygesteffensen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@thygesteffensen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@thygesteffensen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@thygesteffensen, looks good, thank you! I'll #sign-off so the PR review team can validate.

@thygesteffensen, looks good, thank you! I'll #sign-off so the PR review team can validate.


Meteor: deploy fail due to npm prebuild

I faced similar problem like #861
On my dev machine (macOS) it works well. but on the production environment(AWS linux), it is not working..
I am using meteor and this library ( both of them are latest version )
And I am using elastic beenstalk to delploy then
I got error like below at eb-activity.log
><EMAIL_ADDRESS>preinstall /tmp/deployment/application
  > cd programs/server && npm install

  ><EMAIL_ADDRESS>install /tmp/deployment/application/programs/server/node_modules/fibers
  > node build.js || nodejs build.js

  `linux-x64-48` exists; testing
  Binary is fine; exiting

  > meteor-dev-bundle@ install /tmp/deployment/application/programs/server
  > node npm-rebuild.js

  ><EMAIL_ADDRESS>install /tmp/deployment/application/programs/server/npm/node_modules/bcrypt
  > node-pre-gyp install --fallback-to-build

  [bcrypt] Success: "/tmp/deployment/application/programs/server/npm/node_modules/bcrypt/lib/binding/bcrypt_lib.node" is installed via remote

  ><EMAIL_ADDRESS>install /tmp/deployment/application/programs/server/npm/node_modules/sharp
  > (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)

  info sharp Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.6.1/libvips-8.6.1-linux-x64.tar.gz
  fs.js:932
    return binding.mkdir(pathModule._makeLong(path),
                   ^

  Error: EEXIST: file already exists, mkdir '/tmp/deployment/application/programs/server/npm/node_modules/sharp/vendor'
      at Error (native)
      at Object.fs.mkdirSync (fs.js:932:18)
      at WriteStream.<anonymous> (/tmp/deployment/application/programs/server/npm/node_modules/sharp/install/libvips.js:61:10)
      at emitNone (events.js:86:13)
      at WriteStream.emit (events.js:185:7)
      at fs.js:2059:14
      at FSReqWrap.oncomplete (fs.js:123:15)
  make: Entering directory `/tmp/deployment/application/programs/server/npm/node_modules/sharp/build'
    TOUCH Release/obj.target/libvips-cpp.stamp
    CXX(target) Release/obj.target/sharp/src/common.o
    CXX(target) Release/obj.target/sharp/src/metadata.o
    CXX(target) Release/obj.target/sharp/src/stats.o
    CXX(target) Release/obj.target/sharp/src/operations.o
    CXX(target) Release/obj.target/sharp/src/pipeline.o
    CXX(target) Release/obj.target/sharp/src/sharp.o
    CXX(target) Release/obj.target/sharp/src/utilities.o
    SOLINK_MODULE(target) Release/obj.target/sharp.node
  g++: error: ../vendor/lib/libvips-cpp.so: No such file or directory
  g++: error: ../vendor/lib/libvips.so: No such file or directory
  g++: error: ../vendor/lib/libglib-2.0.so: No such file or directory
  g++: error: ../vendor/lib/libgobject-2.0.so: No such file or directory
  g++: error: ../vendor/lib/libcairo.so: No such file or directory
  g++: error: ../vendor/lib/libcroco-0.6.so: No such file or directory
  g++: error: ../vendor/lib/libexif.so: No such file or directory
  g++: error: ../vendor/lib/libffi.so: No such file or directory
  g++: error: ../vendor/lib/libfontconfig.so: No such file or directory
  g++: error: ../vendor/lib/libfreetype.so: No such file or directory
  g++: error: ../vendor/lib/libgdk_pixbuf-2.0.so: No such file or directory
  g++: error: ../vendor/lib/libgif.so: No such file or directory
  g++: error: ../vendor/lib/libgio-2.0.so: No such file or directory
  g++: error: ../vendor/lib/libgmodule-2.0.so: No such file or directory
  g++: error: ../vendor/lib/libgsf-1.so: No such file or directory
  g++: error: ../vendor/lib/libgthread-2.0.so: No such file or directory
  g++: error: ../vendor/lib/libharfbuzz.so: No such file or directory
  g++: error: ../vendor/lib/libjpeg.so: No such file or directory
  g++: error: ../vendor/lib/liblcms2.so: No such file or directory
  g++: error: ../vendor/lib/liborc-0.4.so: No such file or directory
  g++: error: ../vendor/lib/libpango-1.0.so: No such file or directory
  g++: error: ../vendor/lib/libpangocairo-1.0.so: No such file or directory
  g++: error: ../vendor/lib/libpangoft2-1.0.so: No such file or directory
  g++: error: ../vendor/lib/libpixman-1.so: No such file or directory
  g++: error: ../vendor/lib/libpng.so: No such file or directory
  g++: error: ../vendor/lib/librsvg-2.so: No such file or directory
  g++: error: ../vendor/lib/libtiff.so: No such file or directory
  g++: error: ../vendor/lib/libwebp.so: No such file or directory
  g++: error: ../vendor/lib/libxml2.so: No such file or directory
  g++: error: ../vendor/lib/libz.so: No such file or directory
  make: *** [Release/obj.target/sharp.node] Error 1
  make: Leaving directory `/tmp/deployment/application/programs/server/npm/node_modules/sharp/build'
  gyp ERR! build error
  gyp ERR! stack Error: `make` failed with exit code: 2
  gyp ERR! stack     at ChildProcess.onExit (/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
  gyp ERR! stack     at emitTwo (events.js:106:13)
  gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
  gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:219:12)
  gyp ERR! System Linux 4.9.85-38.58.amzn1.x86_64
  gyp ERR! command "/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/node" "/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
  gyp ERR! cwd /tmp/deployment/application/programs/server/npm/node_modules/sharp
  gyp ERR! node -v v6.12.2
  gyp ERR! node-gyp -v v3.4.0
  gyp ERR! not ok

  npm ERR! Linux 4.9.85-38.58.amzn1.x86_64
  npm ERR! argv "/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/node" "/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/npm" "rebuild" "--update-binary"
  npm ERR! node v6.12.2
  npm ERR! npm  v3.10.10
  npm ERR! code ELIFECYCLE
  npm ERR<EMAIL_ADDRESS>install: `(node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)`
  npm ERR! Exit status 1
  npm ERR!
  npm ERR! Failed at the<EMAIL_ADDRESS>install script '(node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)'.
  npm ERR! Make sure you have the latest version of node.js and npm installed.
  npm ERR! If you do, this is most likely a problem with the sharp package,
  npm ERR! not with npm itself.
  npm ERR! Tell the author that this fails on your system:
  npm ERR!     (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)
  npm ERR! You can get information on how to open an issue for this project with:
  npm ERR!     npm bugs sharp
  npm ERR! Or if that isn't available, you can get their info via:
  npm ERR!     npm owner ls sharp
  npm ERR! There is likely additional logging output above.

  npm ERR! Please include the following file with any support request:
  npm ERR!     /tmp/deployment/application/programs/server/npm/npm-debug.log

  npm ERR! Linux 4.9.85-38.58.amzn1.x86_64
  npm ERR! argv "/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/node" "/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/npm" "install"
  npm ERR! node v6.12.2
  npm ERR! npm  v3.10.10
  npm ERR! code ELIFECYCLE
  npm ERR! meteor-dev-bundle@ install: `node npm-rebuild.js`
  npm ERR! Exit status 1
  npm ERR!
  npm ERR! Failed at the meteor-dev-bundle@ install script 'node npm-rebuild.js'.
  npm ERR! Make sure you have the latest version of node.js and npm installed.
  npm ERR! If you do, this is most likely a problem with the meteor-dev-bundle package,
  npm ERR! not with npm itself.
  npm ERR! Tell the author that this fails on your system:
  npm ERR!     node npm-rebuild.js
  npm ERR! You can get information on how to open an issue for this project with:
  npm ERR!     npm bugs meteor-dev-bundle
  npm ERR! Or if that isn't available, you can get their info via:
  npm ERR!     npm owner ls meteor-dev-bundle
  npm ERR! There is likely additional logging output above.

  npm ERR! Please include the following file with any support request:
  npm ERR!     /tmp/deployment/application/programs/server/npm-debug.log

  npm WARN<EMAIL_ADDRESS>No repository field.
  npm WARN<EMAIL_ADDRESS>No license field.
  npm ERR! Linux 4.9.85-38.58.amzn1.x86_64
  npm ERR! argv "/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/node" "/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/npm" "--production" "install"
  npm ERR! node v6.12.2
  npm ERR! npm  v3.10.10
  npm ERR! code ELIFECYCLE
  npm ERR<EMAIL_ADDRESS>preinstall: `cd programs/server && npm install`
  npm ERR! Exit status 1
  npm ERR!
  npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script 'cd programs/server && npm install'.
  npm ERR! Make sure you have the latest version of node.js and npm installed.
  npm ERR! If you do, this is most likely a problem with the mup-myfirstfoundueapp package,
  npm ERR! not with npm itself.
  npm ERR! Tell the author that this fails on your system:
  npm ERR!     cd programs/server && npm install
  npm ERR! You can get information on how to open an issue for this project with:
  npm ERR!     npm bugs mup-myfirstfoundueapp
  npm ERR! Or if that isn't available, you can get their info via:
  npm ERR!     npm owner ls mup-myfirstfoundueapp
  npm ERR! There is likely additional logging output above.
  npm WARN Local package.json exists, but node_modules missing, did you mean to install?

  npm ERR! Please include the following file with any support request:
  npm ERR!     /tmp/deployment/application/npm-debug.log
  Running npm install:  /opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/npm
  Setting npm config jobs to 1
  npm config jobs set to 1
  Running npm with --production flag
  Failed to run npm install. Snapshot logs for more details.
  Traceback (most recent call last):
    File "/opt/elasticbeanstalk/containerfiles/ebnode.py", line 695, in <module>
      main()
    File "/opt/elasticbeanstalk/containerfiles/ebnode.py", line 677, in main
      node_version_manager.run_npm_install(options.app_path)
    File "/opt/elasticbeanstalk/containerfiles/ebnode.py", line 136, in run_npm_install
      self.npm_install(bin_path, self.config_manager.get_container_config('app_staging_dir'))
    File "/opt/elasticbeanstalk/containerfiles/ebnode.py", line 180, in npm_install
      raise e
  subprocess.CalledProcessError: Command '['/opt/elasticbeanstalk/node-install/node-v6.12.2-linux-x64/bin/npm', '--production', 'install']' returned non-zero exit status 1 (ElasticBeanstalk::ExternalInvocationError)
caused by: + /opt/elasticbeanstalk/containerfiles/ebnode.py --action npm-install

I also tried the npm clean ... on node_modules/sharps it still doesn't work

same for me 😢

Hello, if you're copying a node_modules directory created on OS X to use on Linux, you'll need to remove the node_modules/sharp/vendor directory first.
sharp has logic to warn about this kind of platform mismatch but I've just noticed the error is being silently caught - commit 75556bb fixes this.

v0.20.6 now available with improved error messaging for this scenario.


CI step hangs in GitHub Action

Hello, I'm trying to move a GitHub Actions CI workflow to use a pre-existing devcontainer configuration for a Ruby on Rails application. The configuration works locally in VS Code, but I'm having trouble getting it to run as an action. I have a feeling I'm missing something simple.
Following the "simplest example" code from the Getting Started docs:
name: CI
on:
  push:
    branches:
      - my-feature-branch
  pull_request:

jobs:
  tests:
    name: Run test suite
    runs-on: ubuntu-latest

    steps:
      - name: Check out code
        uses: actions/checkout@v3

      - name: Create environment files
        run: |
          cp .env.sample .env

      - name: Run CI
        uses<EMAIL_ADDRESS>        with:
          runCmd: echo "Hello World!"

The workflow successfully builds the devcontainer, and I see it start up:
 [2023-08-03T22:20:18.662Z] Start: Run: docker-compose --project-name my-app_devcontainer -f /home/runner/work/my-app/my-app/.devcontainer/docker-compose.yml -f /tmp/devcontainercli-runner/docker-compose/docker-compose.devcontainer.build-1691101213357.yml -f /tmp/devcontainercli-runner/docker-compose/docker-compose.devcontainer.containerFeatures-1691101218661.yml up -d

But it hangs at that point, and never runs what I've set in runCmd.
Any guidance is appreciated, thanks!

I figured out what was going on—a service I'd defined in the dev container's docker-compose causes CI to hang. I removed it with a workaround and can now build using the Action.


cannot login with mobile devices

hi, using default username/password says incorrect login on mobile devices (ipad / android) works on iphone
INFO[0034] Response Info                                 host="aquaponicsnepal.com:4200" ip=<IP_ADDRESS> method=POST request_id=ziFszEuojQibFgtol63kHd0pFLpmBDjA roundtrip=70129 roundtrip_human=70.129847ms status=302 uri=/api/authorize user_agent="Mozilla/5.0 (iPad; CPU OS 9_3_5 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13G36 Safari/601.1"
INFO[0034] Response Info                                 host="aquaponicsnepal.com:4200" ip=<IP_ADDRESS> method=GET request_id=F8WVGfyaOlWS0hUQKwNw6ydmjYPYBv9L roundtrip=86 roundtrip_human="86.606µs" status=200 uri="/?access_token=35f3698f-f0ad-4e6e-a003-5b69e6ed563c&state=random-string&expires_in=0" user_agent="Mozilla/5.0 (iPad; CPU OS 9_3_5 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13G36 Safari/601.1"

@prasmalla Have you checked your redirect_uri in your conf.json for aquaponicsnepal.com:4200?
For example, if you had multiple host, then you need to add all of them:
   "redirect_uri": [
        "http://localhost:8080",
        "http://localhost:9090",
        "http://<IP_ADDRESS>:8080",
        "http://<IP_ADDRESS>:8080"

Please update to the latest commits from branch master for the multiple redirect_uri supports

Does this fix your problem @prasmalla ?

@adhatama i have a single host for redirect_uri
@lynxluna phones work ok. guess it is just an ipad issue

I'll close this issue then.


Docker Compose: Nginx Configuration Issue

Describe the bug
Using custom nginx configuration file does not override default configuration if done according to comments in docker compose file
To Reproduce
Steps to reproduce the behavior:
In your docker compose file if you would like to override the default nginx conf file, your nginx configuration should look something like this...
  nginx:
    build: .
    image: heartexlabs/label-studio:latest
    ports:
      - "80:8085"
      - "8081:8086"
    depends_on:
      - app
    environment:
      - LABEL_STUDIO_HOST=${LABEL_STUDIO_HOST:-}
#   Optional: Specify SSL termination certificate & key
#   Just drop your cert.pem and cert.key into folder 'deploy/nginx/certs'
#      - NGINX_SSL_CERT=/certs/cert.pem
#      - NGINX_SSL_CERT_KEY=/certs/cert.key
    volumes:
      - ./mydata:/label-studio/data:rw
      - ./deploy/nginx/certs:/certs:ro
#   Optional: Override nginx default conf
      - ./deploy/nginx/default.conf:/label-studio/deploy/nginx/default.conf

Expected behavior
The comment implies that this should override nginx configuration but it doesn't.
Additional context
After some debugging I found that changing the destination configuration location to /etc/nginx/nginx.conf works.
The suggestion here is to update the line to
      # - ./deploy/nginx/default.conf:/etc/nginx/nginx.conf
Happy to create a PR if you guys would like.

Hi,
You're right, the file should be mounted into /etc/nginx/nginx.conf
https://github.com/heartexlabs/label-studio/blob/7ef51890b66b3d83a64fadfe84a3c1bb42d403af/Dockerfile#L49

Fixed: https://github.com/heartexlabs/label-studio/commit/339e294ef1f7b3f66bf712d63ae0364798f4dd61


Applications filtering

Hi,
First, thanks a lot for this awesome work!
I was taking a look  to the docs and code and i can't find a way to show only the apps that i want in the Popup Component.
IE: Maybe i have google maps installed  but i don't want to show Google Maps as an option.
Is that possible?
Regards

Hi,

IE: Maybe i have google maps installed but i don't want to show Google Maps as an option. Is that possible?

Yes it's possible, we can add an option allowing to blacklist apps on demand.
Atm the popup shows all the applications installed on the phone. You'll find below the list of concerned apps:

Apple Maps
Google Maps
Citymapper
Uber
Lyft
The Transit App
Waze
Yandex.Navi
Moovit

@tschoffelen: What do you think about that feature?
Regards,

@johanleroch I can help with a PR if you find this feature useful.

Blacklist would be nice, but wouldn't it be better to make it a whitelist? I think that's more in tune with how that feature would be used in most situations.

@tschoffelen  agree, whitelist make more sense than a blacklist.

@tschoffelen: Sure, whitelist will make more sense.
@gbahamondezc: You're welcome if you want to make a PR

Ok,
If really makes sense for you guys,  i will do between today and next Monday.
Thanks !

Was implemented in #30  , thanks!


Expected Memory reduction when using PEFT for flant5-XL

Hi all, I'm trying to train google/flan-t5 xlarge on A100 40GB machines with pytorch lightning and deepspeed stage 2. Using AdamW as the optimizer. I'm using Lora config (r=8, alpha=32, dropout=0.1) and I can see the following:
trainable params: 4718592 || all params:<PHONE_NUMBER> || trainable%: 0.16530502867367827
However, my memory consumption on A100 40 GB is still around 34 GB with batch size 1. I'm not able to even fit batch_size=2. I expected a much more reduction in memory footprint with that percentage of trainable parameters.
In terms of speed, I'm seeing around 5x increase in speed. Again expected much more significant increase in speed. Anything I'm missing to reduce the memory requirements to the level where this can be trained on standard colab machines as mentioned here:
https://huggingface.co/blog/peft
Any hints would be greatly appreciated!

Same question here. I'm training a modification GPT2-M on a google Colab GPU, using the transformers.Trainer class. With a standard fine-tuning (125,379,072 params), training takes ~20G of GPU RAM.
Now, with a peft Lora wrapper:
        task_type=TaskType.CAUSAL_LM,
        inference_mode=False,
        r=4,
        lora_alpha=32,
        lora_dropout=0.1,
    )

It reports reducing the number of trainable params by a factor thousand:
trainable params: 147456 || all params: 125379072 || trainable%: 0.1176081443639972

However, when it comes to training, the GPU RAM usage is still exactly the same ~20G.
I manually verified that for all non-lora parameters require_grad is set to False, so this behavior puzzles me.

Still unaddressed.

I've seen the same issue on my end as well. I noticed a lot of the documentation & tutorials use int8 quantization in addition to LORA. Not sure what speedup to expect with and without int8. But without int8 I see a slowdown and no memory decrease as well.

Hello, it might be the case that the sequence lengths you use are longer, leading to bottlenecks in activations occupying high GPU memory. In that case, enable activation checkpointing and use DeepSpeed ZeRO-3 for sharding parameters/gradients/optimizer states across GPUs and if required DeepSpeed's CPU offloading.
Not much we can do without reproducible script, the example scripts in example folder show the GPu memory occupied with DeepSpeed + CPU offloading for the raft datasets here: https://github.com/huggingface/peft/blob/main/examples/conditional_generation/peft_lora_seq2seq_accelerate_ds_zero3_offload.py

Below are my rule of thumb:

Want to fit whole large LLM onto single GPU and reduce the model memory, use INT8 quantization and the preprocessing prepare_for_int8_training() also activates gradient checkpointing. So, model size as well as activations occupying GPU memory is reduced. With PEFT you have small number of trainable params now, so small optimizer states and less greadient computation limited to these.

Have multi GPUs and don't want to use INT8 quantization. Use PEFT + DeepSpeed + Gradient Checkpointing.

To quote the DeepSpeedChat repo: https://github.com/microsoft/DeepSpeedExamples/blob/master/applications/DeepSpeed-Chat/training/step1_supervised_finetuning/README.md
One important consideration for users is determining the maximum model size they can train using their current system. Here, we present a method for estimating this limit. Assuming that you do not use the offload feature and enable (i) zero stage 3 (if using multiple GPUs), (ii) gradient checkpoint, and (iii) LoRA, the approximate maximum model size (in billions of parameters) that you can train can be estimated as "Total GPU memory in GB divided by 3." For example, if you have a single A6000-48G GPU, you can probably train models up to 16 billion parameters. It is important to note that this is a rough estimation, and you should verify it by yourselves.

this is still an issue!


Wind data URL broken

Broken URL in README.MD: http://nomads.ncep.noaa.gov/cgi-bin/filter_gfs.pl?file=gfs.t00z.pgrb2.1p00.f000&lev_10_m_above_ground=on&var_UGRD=on&var_VGRD=on&dir=%2Fgfs.${YYYYMMDD}00
Fixed URL: https://nomads.ncep.noaa.gov/cgi-bin/filter_gfs_1p00.pl?file=gfs.t00z.pgrb2.1p00.f000&lev_10_m_above_ground=on&var_UGRD=on&var_VGRD=on&dir=%2Fgfs.${YYYYMMDD}%2F00

URL has changed slightly again and needs 'atmos' at the end, as of July 2021 the format is
https://nomads.ncep.noaa.gov/cgi-bin/filter_gfs_1p00.pl?file=gfs.t00z.pgrb2.1p00.f000&lev_10_m_above_ground=on&var_UGRD=on&var_VGRD=on&dir=%2Fgfs.${YYYYMMDD}%2F00/atmos


Project().parsed_pipfile parse wrong pipfile

Issue description
From v2020.5.28, in case PIPENV_PIPFILE env var supplied, and pipenv install package from git, and the package's setup.py use pipenv Project().parsed_pipfile for install_requires, it take the install_requires from wrong pipfile.
To be more clear, assuming a git repository named "Library" contains some library code, as well as Pipfile which specify the install requirements for this library. Let's say an application named "app" wants to use "Library" and have the following in its Pipfile:
[packages]
library = {editable = true,git =<EMAIL_ADDRESS>
Let Library's setup.py be:
from pipenv.project import Project
from pipenv.utils import convert_deps_to_pip
from setuptools import setup, find_packages

setup(
    name='library',
    version='0.1',
    packages=find_packages(),
    install_requires=convert_deps_to_pip(Project().parsed_pipfile['packages'], r=False)
)

When pipenv clone the repository "Library" and run its setup.py, it will import pipenv. Since PIPENV_PIPFILE exists in os.environ (set to app/Pipfile) the required packages will be taken from it and not from Library's pipfile.
Expected result
Library's pipfile will be parsed for install_requires
Actual result
app's pipfile will be parsed for install_requires
Steps to replicate
For the above example run PIPENV_PIPFILE=<app/pipfile> pipenv sync
Why it's happening
In pipenv v2018.11.26 the relevant code is:
if PIPENV_PIPFILE:
    if not os.path.isfile(PIPENV_PIPFILE):
        raise RuntimeError("Given PIPENV_PIPFILE is not found!")
    else:
        PIPENV_PIPFILE = _normalized(PIPENV_PIPFILE)

In pipenv v2020.5.28 it change to the following:
if PIPENV_PIPFILE:
    if not os.path.isfile(PIPENV_PIPFILE):
        raise RuntimeError("Given PIPENV_PIPFILE is not found!")
    else:
        PIPENV_PIPFILE = _normalized(PIPENV_PIPFILE)
        # Overwrite environment variable so that subprocesses can get the correct path.
        # See https://github.com/pypa/pipenv/issues/3584
        os.environ['PIPENV_PIPFILE'] = PIPENV_PIPFILE

Optional fix
Add pipfile_location kwarg to pipenv.project.Project.__init__ method. Libraries with pipfile probably will want force specific pipfile to be in use. Preventing the above will be as following:
from pipenv.project import Project
from pipenv.utils import convert_deps_to_pip
from setuptools import setup, find_packages
from Pathlib import Path

pipfile_location = Path(__file__).parent.joinpath('Pipfile')
required_packages = Project(pipfile_location=pipfile_location).parsed_pipfile['packages']

setup(
    name='library',
    version='0.1',
    packages=find_packages(),
    install_requires=convert_deps_to_pip(required_packages, r=False)
)

From your description, I can't tell the current behavior is WRONG. It seems more correct though. All you want is a method to convert Pipfile dependencies into a list of PEP 440 requirement strings.
If that is the case, the internal API of pipenv may not be the best way to do it. Instead, you can have a tool like pipfile_requirements. Moreover, depending on a heavy library in your setup.py is not a good idea. It makes it impossible to install via pip install git+<git url> unless you specify it in setup_requires or PEP 517's build-system requires section.

pipfile_requirements can fix the problem, thanks.

I do expect parsed_pipfile to parse the right pipfile, and it behave correctly till version v2020.5.28. From then, since it set PIPENV_PIPFILE it start take wrong pipfile from PIPENV_PIPFILE's content instead of the search for the pipfie in root repository. So, such change should come along with a way for prevent this unwanted behavior, like the way I suggest or any other way which allow users to tell pipenv to use only the root repository search for dictate the pipfile.

The env var PIPENV_PIPENV is to tell which Pipfile to use. You can't ignore that var with it existing.


Use another RS485-TTL module Maybe we could connect without DE/RE

I have found a RS485-TTL module that use the AutoDirection. And it product with MAX13487. So I think we can use it to connect without RE/DE. And It can free two GPIO point.
https://item.taobao.com/item.htm?spm=a230r.<IP_ADDRESS>b2340a7xfdnD0

It would only free one because on the master side the RE/DE are connected together.

But yes. that would be cool

THX. And I will have a try. I also found a board named DT-06 witch make with ESP8266. And it have only TX RX STATE GND VCC. So It is very small, and it can make the module smaller that while it connect to MAX13487.
https://item.taobao.com/item.htm?spm=a230r.<IP_ADDRESS>9927f77gxvdQ

Ok. But my code is for ESP32. On ESP8266 you have to do some modifications. Please have a look on closed issues to see more details.


Passage UniqueID

When implementing the database, each embedding belongs to one passage. The hash() of each passage is being used to generate an ID and insert it into the database. This is helpful so the code can skip the computing of an embedding if it already exists in the database. The problem is that the value returned by the hash() function is not entirely the same when the code is executed in a different context (for example, if the notebook is restarted, the has value returned is different, even though in theory it shouldn't, and the same passage is inserted again in the database).
Could we come up with another way of creating Passage IDs that are always unique? It would be a plus if the ID is informative (for example, an ID can be the concatenation of the name of the original file, the issue number, the index of the passage inside that file, and the first 5 characters of the passage, etc...)

On second thought, uniqueness seems to be important here, so I think the UUID module might be more appropriate.

To make the plan more specific:

[ ] add a Passage.uuid() method (using Python's uuid module), that uses text and metadata
[ ] Use the Passage.uuid() as unique ID for database

The Passage.__hash__() therefore does not need to change, but will no longer be used for the database IDs.


Thumbnail SVG format

Hey. Can I use svg format assets for thumbnail? or is it limited only for PNG? and why Icon's icon very limited. Was hoping to have all of material designs' icons.

You can use all the icons from react-nativevestor-icons. It is not just limited to Ionicons. Please go through the docs for Icon configuration.
Thumbnail inherits all the properties of RN Image, so if Image has SVG support, the Thumbnail will support it too.


patched wms to read caps from ncwms2 with default namespace

… and timepositions.
ncWMS2 uses a xml default namespace which failed the GetCapabilitiesReader. The solution was to remove the default namespace:
http://stackoverflow.com/questions/34009992/python-elementtree-default-namespace#35165997
This patch also strips the timepositions to remove newlines.
This patch includes a doctest.

Shouldn't this be an ncWMS bug?  WMS 1.1.1 does not define a namespace.

it is fixed on the ncWMS side and available with the next release.


HDFS-16460. [SPS]: Handle failure retries for moving tasks

JIRA: HDFS-16460.
Handle failure retries for moving tasks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 38s

trunk passed

+1 :green_heart:
compile
1m 50s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  4s

trunk passed

+1 :green_heart:
mvnsite
1m 54s

trunk passed

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 40s

trunk passed

+1 :green_heart:
shadedclient
27m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 59s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 59s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
0m 59s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 55s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 55s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

the patch passed

-1 :x:
mvnsite
0m 58s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
0m 55s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
12m 23s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
1m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

99m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux fbb3ac115d28 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a146cddf124e620db2db4ea0930e8ddab6a7bddd

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/1/testReport/

Max. process+thread count
589 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 32s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 33s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 23s

trunk passed

+1 :green_heart:
shadedclient
25m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 52s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 201 unchanged - 0 fixed = 202 total (was 201)

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 26s

the patch passed

+1 :green_heart:
shadedclient
25m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
352m 26s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

460m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 10374cbf177b 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c10107bd1963bf5721793537e20ad518f2545a93

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/2/testReport/

Max. process+thread count
2082 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @jojochuang @tasanuma @Hexiaoqiao @ferhui , PTAL. Thanks.

Hi @umamaheswararao @tasanuma @Hexiaoqiao , could you please take a look? Thank you very much.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 37s

trunk passed

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
25m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 25s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 52s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 201 unchanged - 0 fixed = 202 total (was 201)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 33s

the patch passed

+1 :green_heart:
shadedclient
25m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
351m 45s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

461m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 7c8047b92267 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 982589e9ba3de81e2af162f7af209016a75ad3a3

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/3/testReport/

Max. process+thread count
2029 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @umamaheswararao @ayushtkn @tasanuma , could you please take a look at this? Thanks a lot.

@tomscut Thanks for your contribution. It looks good. Please look at the checkstyle.

@tomscut Thanks for your contribution. It looks good. Please look at the checkstyle.

Thanks @ferhui for your review. I fixed this.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 10s

trunk passed

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
26m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 25s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
25m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
356m 49s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

484m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 36fcaa049d1c 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 65573245fcce49a42b41a62adb1d8f917034bc35

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/4/testReport/

Max. process+thread count
2065 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4001/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @ferhui .


Prevent hiding filtered nodes in tree

Dear developers, i have a task to mark filtered nodes of tree with custom css class and do not hide them. As you can see, marked orange with text-decoration: line-throught nodes was filtered, but i still need to display it:

For now, i could do this only comment next lines in sources:
    template: [
      '
',
        '<li ng-repeat="child in root | ivhTreeviewAsArray"',
            //'ng-hide="trvw.hasFilter() && !trvw.isVisible(child)"', <-- this
            'ng-class="{\'ivh-treeview-node-collapsed\': !trvw.isExpanded(child) && !trvw.isLeaf(child)}"',
            'ivh-treeview-node="child"',
            'ivh-treeview-depth="0">',
        '
',
      '
'
    ].join('\n')

and this:
    template: [
      '
',
        '<li ng-repeat="child in getChildren()"',
            //'ng-hide="trvw.hasFilter() && !trvw.isVisible(child)"', <-- this
            'ng-class="{\'ivh-treeview-node-collapsed\': !trvw.isExpanded(child) && !trvw.isLeaf(child)}"',
            'ivh-treeview-node="child"',
            'ivh-treeview-depth="childDepth">',
        '
',
      '
'
    ].join('\n')

Something like this?
http://jsbin.com/kuwoyam/1/edit?html,css,output
That's just a hack (we only use ng-hide for filtering) but I could get behind adding a custom class for filtered out nodes rather than just using ng-hide if that's what you're looking for.

Actually - on second though it might be better for us to stick with ng-hide so folks can take advantage of ngAnimate... I'm open to suggestions :).

Yeap, hack with css li.ivh-treeview-node.ng-hide looks not so bad. Right now i'm looking for a way of prevent hiding and possible to apply styles for filtered nodes, so i'm ready for all kinds of you implementation desicion :) Sry for my bad english

Cool - I'm thinking we'll just end up supporting .ivh-treeview-node.ng-hide so we can stand on the back of ngAnimate for filtering. I'd say you should feel free to override that class now your purposes here as in the demo above. I'll update the docs to include it.


Add support for using @AllowedOrigins("*") to do per class/method CORS configuration and use it so that http://petstore.swagger.io/?url=http://localhost:8080/api/v1/swagger.json loads ok.

Codecov Report

Merging #104 into master will increase coverage by 0.34%.
The diff coverage is 73.33%.

@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
+ Coverage     46.11%   46.45%   +0.34%
  Complexity       86       86
============================================
  Files            62       62
  Lines           527      536       +9
  Branches         44       46       +2
============================================
+ Hits            243      249       +6
- Misses          263      265       +2
- Partials         21       22       +1

Impacted Files
Coverage Δ
Complexity Δ

...redhat/ipaas/api/v1/rest/SwaggerConfiguration.java
0% <ø> (ø)
0 <ø> (ø)
:x:

...ain/java/com/redhat/ipaas/runtime/CorsFeature.java
88.23% <84.61%> (-11.77%)
0 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4eb0b...a26b959. Read the comment docs.

Merging on green. Thanks @chirino!

[merge]


private tx for asset hub demo

viewer experience
Minimal command line screencast for client cli interaction only
js/apps view asset hub. see events
mock graphical wallet view for sidechain

sidechain block number (1s blocktime?)
L2 balance for Alice and Bob
events

Story
Alice has ROC on Asset hub
Alice shields 9 ROC
Alice sends 6 ROC to Bob on L2
Bob unshields 3 ROC
tech setup
zombienet setup (on host):

target A: asset hub rococo
Integritee: on Rococo

in integritee-dev docker:

2 sidechain validateers

Needs #1440

demo done, but not yet with asset hub runtime support

will close as the demo is done and remaining issues are submitted


[Windows] implement mapping of pid to service name

Checks the pid against the table of SCM controlled processes. If it's SCM controlled, returns the service information.
Because we must enumerate the entire SCM (there doesn't seem to be an api for that), the SCMManager object maintains a cache of objects, and refreshes only when it sees a PID it hasn't seen before.
On a machine with high process churn, this could still result in a lot of accesses.  However, if process agent queries only when doing the process check (i.e. every 30s), then it should only iterate the list once per 30s.
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Looks good for the most part. Just curious about the performance characteristics of building a new process table every check run.

Fair question and I don't know the exact answer... which is why it's built the way it is to minimize number of times we rebuild that table.  I think we can build in some stats on how long it takes to build the table.  There's already the ability to query how many times the table is rebuilt, so we can report that from the process agent.


Fixing gdb issue with gcc11 on Windows

It complained "A syntax error in expression, near `= -1'."
Apparently gdb was evaluating the expressions in the command file as if they were in Fortran. Since Fortran 77 does not have "==" this produced a syntax error. Setting the language to C manually appears to resolve this.
It's also not entirely clear why we were looking for exitcode to be equal to -1. Some tests showed that if the exitcode were 2 this would be a problem, so we look at the more reasonable value of 0 instead.
Closes #151

Great! Thank you @nbelakovski !


What route for refresh token?

What route for refresh token and parameters?

Look at the readme. Its localhost/oauth/access_token


[FS] History amendment for <IP_ADDRESS>

Cherry picked #3790 and removed old unused code.

@codingupastorm what was the reason for this? Was it something we missed?

<IP_ADDRESS> is already released :)

Ah nevermind I saw PR in slack 👍


building the example app fails

Describe the Bug
Getting build errors compiling the example app.
Steps To Reproduce
Follow these steps:
https://github.com/doublesymmetry/react-native-track-player/blob/main/example/README.md
Then run npx react-native start and npx react-native run-ios
Receive error:
The following build commands failed:
CompileC /Users/mheavers/Library/Developer/Xcode/DerivedData/example-fepvtamaklazdacyqzthmylvbyyx/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-Codegen.build/Objects-normal/x86_64/FBReactNativeSpec-generated.o /Users/mheavers/Documents/Mozilla/FP/Concepts/podcast/prototypes/react-native-track-player/example/ios/build/generated/ios/FBReactNativeSpec/FBReactNativeSpec-generated.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'React-Codegen' from project 'Pods')

Code To Reproduce
Please provide a simple code example that allows others to replicate the bug.
Replicable on Example App?
Can you replicate this bug in the React Native Track Player Example App?
Yes
Environment Info:
Paste the results of npx react-native info
System:
    OS: macOS 13.2.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 640.46 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.19.2 - /usr/local/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.12.1 - /Users/mheavers/.rubies/ruby-3.1.2/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 14.3/14E222b - /usr/bin/xcodebuild
  Languages:
    Java: 20.0.1 - /Users/mheavers/OpenJDK/jdk-20.0.1.jdk/Contents/Home/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: 0.71.4 => 0.71.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Paste the exact react-native-track-player version you are using
4.0.0-rc03
Real device? Or simulator?
What OS are you running?
Mac OSX 13.2.1 (22D68) - Ventura
How I can Help
What can you do to help resolve this?
LMK
Have you investigated the underlying JS or Swift/Android code causing this bug?
Can you create a Pull Request with a fix?
If I can fix it...

I see a few relevant console messages that could be relevant(?)
On yarn:
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>
On Pod install:
[!] The `exampleTests [Debug]` target overrides the `ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES` build setting defined in `Pods/Target Support Files/Pods-example-exampleTests/Pods-example-exampleTests.debug.xcconfig'. This can lead to problems with the CocoaPods installation
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

[!] The `exampleTests [Release]` target overrides the `ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES` build setting defined in `Pods/Target Support Files/Pods-example-exampleTests/Pods-example-exampleTests.release.xcconfig'. This can lead to problems with the CocoaPods installation
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

Tried to build from within xcode, and I get potentially a little more info:


target bat file not opening when app argument defined as cmd (windows 10)

This works
opn('H:\command.bat');
but this just opens a command prompt without executing the the target bat file.
opn('H:\command.bat', {app: 'cmd'});
Tested on windows 10

As a workaround to the problem the following code allowed the use of app and arguments.
opn('',{app:['cmd.exe','/c start H:\command.bat "argument"']});


Reformat code in studio

Motivation
reformat the code
JIRA: https://issues.jboss.org/browse/AGDROID-763
Progress

[x] Done Task

(Just repeating what we talked in IRC) @matzew Before merging all this cleanup, we should also enable the linter so that future PRs won't mess with the formatting.

@matzew https://github.com/diffplug/spotless looks like it can do what we want (including Google code formatting out of the box AND has kotlin support).  If you don't have the bandwidth I can throw it into my pile.

Closing in favor of https://github.com/aerogear/aerogear-android-sdk/pull/128


Failed to pass Object data through named routes when migrating from vue-router 3.1.5

Version
4.0.0-beta.12
Reproduction link
https://codesandbox.io/s/affectionate-sunset-dng3r?fontsize=14&hidenavigation=1&theme=dark
Steps to reproduce
this.$router.push({
  name: `Target-Page`,
  params: {
    data: {
      fieldA: 'a',
      ...
      filedZ: false,
    }
})

What is expected?
this.$route.params?.data is supposed to be an Object data
What is actually happening?
this.$route.params?.data becomes a String data
data: "[object Object]"

Our projects are heavily using route.params to pass dynamic data from page to page.
We also tried "Passing Props to Route Components", which still cannot meet our demand.
We have to use JSON.stringify/JSON.parse/Number()/Boolean() everywhere to pass or retrieve dynamic data if this behaviour is correct for vue-router 4.x.
Looking forward to see a proper explanation.
Thanks!

Passing data in params has never been supported. It will even break in some scenarios in vue router 3. Params must be present on the url.
Alternatives are passing data in a store, query params, or using the history state.

I am sorry that I have to tell the truth, which is vue-router 3.x do support passing object/boolean/number/ data in params.
here is the reproduction link
https://codesandbox.io/s/long-lake-zce24?fontsize=14&hidenavigation=1&theme=dark
I have no idea what makes you feel like "Passing data in params has never been supported", but it really exists.
It is grateful if anyone can tell why passing Object data in named routes, which is supported in 3.x, now fails in vue-router 4.x beta.
Thank you!

@jackjtr you get the encoded object being a string representing its type because the encodeParam is applied to your data object. Currently you can't mount components with raw data object being passed through router props. The simplest workaround is to stringify your object, pass as router param and parse back in target component. I do agree that looks dirty, but still.
@posva fortunately, passing data in params has been supported for ages (until vue 3 and vue-router 4 are there)
https://jsfiddle.net/5fgmsLcd/

@jackjtr In terms of router navigation to the component that's supposed to handle your data from previous page, It's trully better to pass common typed object like id as prop and then use it to retrieve the certain object from the collection in your store (whether it's been already populated with the data you need), or even better to use that id to request a full object model from your api.

@Splinterjke I think what @posva means by "not supported" is that router was never written in a way this works in all scenarios. Yes, you could pass an objects when calling $router.push and it worked but as soon as user used browser navigation (back, forward) or copy/pasting URL's, such solution was ultimately broken...
I personally answered few questions on SO where users was perplexed by exactly this. So IMHO it is a good thing this is completely shut down in the new router...

@Liwoj totally agreed, a passing some complex data through a router is not the best practice and it should be avoided since there is a lot of more proper ways to implement a state management. There is a good one called pinia by the way.

@Splinterjke @Liwoj Thanks for commenting. Actually we are using $router.push this way on Hybrid App, which won't allow user jump to any specific page but only the entrance. Most of the pages are supposed to be controlled through configurations on the server side. We tried using JSON.stringify and JSON.parse with Composition API and it works fine now.

Here's hoping they revert to v3 behavior for a small convenience (to some of us) in the future so we can get rid of JSON.stringify/JSON.parse in our projects.

+1 for hybrid apps. We are rewriting an Ionic app from Angular JS to Vue 3 and this behaviour is quite a bummer

I don't see why the RouteLocation can't be made to have an arbitrary data field that gets passed along wherever it goes. Not sure how that could break things.
And clearly this is a heavily needed feature.

Alternatives are passing data in a store, query params, or using the history state.

At the very least, this should be somewhere in the docs, with examples.

Stumbled upon this when migrating from Vue 2 (where it used to work without any issues) to Vue 3, my two cents: It was a little difficult to debug because I couldn't quite figure out why would an object silently turn into a string… But I found this ticket which made it all clear. I only have a couple of uses, so I guess I can find a way to do it differently, but as people migrate to Vue 3 there will be more people looking for a way to make it work. To me it always seemed like a reasonable solution for passing the data when navigating around.

I discovered the following workaround to restore vue-router 2 behavior:
import { createRouter, createWebHistory } from 'vue-router'
+import { stringifyQuery } from 'vue-router'
export const router = createRouter({
  history: createWebHistory(),
+ stringifyQuery: (query) => stringifyQuery(query),
  // ...
})

This works thanks to the implemented behavior of skipping query object normalization when stringifyQuery option is provided: https://github.com/vuejs/router/issues/328#issuecomment-649492012 https://github.com/vuejs/router/commit/ea65066e8511d8320ad8de37b32ea9a8028fa9d5
@posva what do you think about adding a skipQueryNormalization option to make this configuration explicit, and an entry in the migration guide? I would be happy to contribute. I suppose this could be used to force skip or force not skip, i.e. documentation would state "the default is true if stringifyQuery is provided and otherwise false"