OCPBUGS-3690: profilerecorder: gracefully skip containers that did not record anything

Backports https://github.com/kubernetes-sigs/security-profiles-operator/pull/1378 which fixes https://issues.redhat.com/browse/OCPBUGS-3690
It's unusual to send a backport before an upstream patch is merged, but I'm doing that because:

the holiday season starts soon and reviews might take longer
the upstream CI tests that run the upstream e2e tests on Flatcar are not working at the moment which is blocking merges upstram
I want to get the PR through the OCP CI to see if there's any failures
I want to give QE a head start testing the PR

We can
/hold
the PR until the original upstream PR is reviewed and merged.

@xiaojiey to test, you can deploy with make deploy-openshift-dev as there are no packaging changes. Then the steps to reproduce in your bug should no longer be reproducable.

flaky tests are flaky, sometimes
/test e2e-flaky

/test e2e-flaky

OK, turns out that the flaky tests are failing in the upstream PR as well.
@xiaojiey when you haeve a chance, testing the PR might be welcome to test the general approach, but it looks like some CI debugging is needed.

With payload 4.13.0-0.nightly-2022-12-12-210406 and code in the PR, tried several times, I didn't reproduce the bug.
Steps:

install SPO
Enable log Enrisher
Create a new namespace mytest. To record by using the enricher, create a ProfileRecording which is using recorder
Create the severice account with privileged permission:
Add label for ns and create deployment to be recorded:
$ oc label ns mytest security.openshift.io/scc.podSecurityLabelSync=false pod-security.kubernetes.io/enforce=privileged --overwrite=true
$ oc apply -f -<<EOF
apiVersion: apps/v1
kind: Deployment
metadata:
name: hello-openshift
namespace: mytest
spec:
replicas: 3
selector:
matchLabels:
app: hello-openshift
template:
metadata:
labels:
app: hello-openshift
spec:
serviceAccountName: spo-record-sa
initContainers:

name: wait
image: quay.io/openshifttest/centos:centos7
command: ["/bin/sh", "-c", "env"]
containers:
name: hello-openshift
image: quay.io/openshifttest/hello-openshift:multiarch
ports:

containerPort: 8080
readinessProbe:
tcpSocket:
port: 8080
initialDelaySeconds: 5
periodSeconds: 5

name: hello-openshift2
image: quay.io/openshifttest/hello-openshift:multiarch-fedora
ports:

containerPort: 8081
readinessProbe:
tcpSocket:
port: 8081
initialDelaySeconds: 5
periodSeconds: 5
EOF
deployment.apps/hello-openshift created
$ oc get selinuxprofiles.security-profiles-operator.x-k8s.io
NAME                                    USAGE                                                  STATE
test-recording-hello-openshift-2hhdj    test-recording-hello-openshift-2hhdj_mytest.process    Partial
test-recording-hello-openshift-kv29z    test-recording-hello-openshift-kv29z_mytest.process    Partial
test-recording-hello-openshift-vg9r2    test-recording-hello-openshift-vg9r2_mytest.process    Partial
test-recording-hello-openshift2-2hhdj   test-recording-hello-openshift2-2hhdj_mytest.process   Partial
test-recording-hello-openshift2-kv29z   test-recording-hello-openshift2-kv29z_mytest.process   Partial
test-recording-hello-openshift2-vg9r2   test-recording-hello-openshift2-vg9r2_mytest.process   Partial

/qe-approved

Adding no-FF labels as QE tested the fix and there is no impact on docs or PX.

/hold cancel
In order to speed up downstream, I'm going to cancel the hold and merge.
In case upstream requests changes to the code, I'm going to revert this PR and send another one with the upstreamed code.


Adding gitignore for all Jetbrains IDEs

I think that this should not be tracked within a project's .gitignore but instead the global ignore file.
Check out this other list  github maintains as a repo.

Not merging this in lieu of #5


Fix typo

Pull request template
Fix a typo in the README.
Type of changes

[ ] CI
[ ] Bugfix
[ ] Feature
[ ] Generic maintenance tasks
[x] Documentation content changes
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no URL changes)
[ ] Improving performance of the project (not introducing new features)
[ ] Other (please describe):

Resolve Issue Number: N/A
What is the current behavior?
The comment sounded weird.

What is the new behavior?
It's grammatically correct, I guess?

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

Not stale

Not stale.

Thanks for contributing @lishaduck.
Sorry for late. I will merge this pr.


Obey HTTP_PROXY and HTTPS_PROXY env variable

the app should check if the env variables are set and should connect through the proxy if set.

This app does not control the connection/requests to slack, hence cannot implement this feature. You can submit a PR on the module here
Closing this for now, you can reopen if you have further questions or clarification on this.


feat: Add support for gitlab issues

I thought that it would be interesting for my project, which uses a self hosted gitlab instance. It requires glab for now, as it would require some further changes to get_issues to support curl and I didn't want to change to much for now. Also I've not looked into mentions for now.
I'm quite new to coding in neovim and lua, so any feedback is very much welcome and I'll try to incorporate it :^)

Thank you for your contribution! I didn't know glad was a thing, will test this now


[fix #129] Fix register/de-register bug when process is restarted out-of-band.

Fixes a bug when a process is restarted out-of-band wherby the
original pid was never unwatched and thus would trigger
false-positives by god on noticing process exits.
I am not 100% sure that this doesn't cause problems elsewhere. Not exactly sure how to test and don't know enough about the overall architecture to know what I don't know about how all this works across different process mechanisms.
In any case I'm going to use this on my prod box for a bit and see how it goes.
Would love to have additional feedback.

I've been running into this issue for a while (and #127 as well) but came up with a slightly different fix which you can see here:
https://github.com/chetan/god/compare/dangling_process_exit
In addition, I changed my config to disable the clean_pid_file behavior and changed the process_exit condition to transition to :init instead of :start, so that it has a chance to pickup the new pid instead of just blindly trying to start and throw errors.


Feature: Adjust environment variables and deploy on Vercel

Overview

This PR adjusts the environment variables for deployment. Accordingly, this branch has been deployed to Vercel as a "preview" deployment.
Changes

Only renamed the env variables
*I did NOT remove the NEXT_PUBLIC_  prefix from any existing env variables because I figured out that they all have to be exposed to the client side.

Review points

Please only check if there is no error that this PR generated.

Screen Captures

References

Notes

I will secretly share the testing URL with the reviewers.
After this PR is merged into development as well as the main, I will also deploy them.

Assignee Checklist:

[x] The naming convention of the PR title is correct (See the comment at the top of this template)
[x] The base branch is correct (See: Types of Branches)
[x] The branch name follows the Branch Naming Conventions
[x] The correct assignees and reviewers have been designated for this PR
[x] The coding style follows the Coding Style Guide
[x] All the related issues are associated with this PR
[x] All criteria in the associated issues are met (please tick the checkboxes)
[x] My changes do not generate new warnings or errors (especially in the console)

Reviewer Checklist:

[ ] Double-check the "Assignee Checklist"
[ ] The code follows the generic best practices and our Coding Style Guide
[ ] The code is well-commented and easy to understand
[ ] The UI changes accurately reflect the provided design

@kanta1207
Thank you for your review 😄


Since the update there's no way to ignore an unrecognized SSL certificate.

Your description here
I'm working with a debug server that desn't have a valid SSL certificate. The previous version worked fine if a rule was created in chrome. With this version I just  a ERR_CERT_COMMON_NAME_INVALID error and there is no (apparent) way to instruct the app to ignore the certificate and accept the response
Expected outcome
What should happen?
should get the response, since there's a rule created in chrome
Actual outcome
What happened?
ERR_CERT_COMMON_NAME_INVALID
Versions
App: <IP_ADDRESS>-stable
Chrome: 49.0.2623.110
Platform: Windows (7)
Steps to reproduce

find a web server that doesn't have a valid ssl certificate
open the web site with chrome, after the regular security prompts create a rule to ignore this error for this site and access the site regularly
try to make the same call with the app
You will get an error of type ERR_CERT_COMMON_NAME_INVALID

Duplicate of #432 (sort of but it's all leading to the same issue - the cert is not installed in the system)


Expose an endpoint to use as a healthcheck for the build agent

(AWS focused) use case: if running a fleet of elastic agents in an autoscaling group with an elastic load balancer for healthchecks, an HTTP endpoint on an instance can be used to determine if the agent is still available.
For example, if an agent crashes, the endpoint would stop responding and the instance would be terminated.  A new instance would be spun up by the ASG.
This would enable easy horizontal scaling on smaller instances.
Perhaps check an environment variable such as BUILDKITE_EXPOSE_HTTP_ENDPOINT and if set to true, run http.ListenAndServe.

From Slack…

The ELB healthcheck dictates a single endpoint to check, so limits to a single build agent on an instance with this feature.
Hence the preference towards many smaller instances.
Limits liability in case an availability zone goes down.

I think it'd make sense to include a port argument if we were to add this… just to support multiple agents on the one machine.

There's the existing API for polling registered agents: https://buildkite.com/docs/api/agents .
If that was to be used, each instance would have to be running a watchdog process that polls the GET agents endpoint, matches the hostname with its instance hostname and check the status.  If not a healthy state, report back to AWS the instance is unhealthy.
I'd greatly prefer an HTTP endpoint exposed and let the ELB do the work.

I don't think we'll put this functionality directly into the agent (I try to keep the agent as dumb as possible). In saying that, I still think the idea in general is good! I just quickly wrote a tool that should help us!
https://github.com/buildkite/elb-healthcheck-pid
Just spin this tool up along side the agent and give it the agent's PID, and it'll give you an endpoint that you can monitor in ELB.
What do you think of this approach? (btw, I wrote this in a few hours and some local testing, so I haven't done any thorough testing yet, but it seems to work!)

I'm not sold on doing a health check outside the process: the signal 0 used by the elb-healthcheck-pid project only tells us if the PID exists and we can send a signal to it.  It tells us nothing about its state.
How can we determine if the agent process is unresponsive or crashed?  Embedding an http server is one way, or writing to a log as a heartbeat, etc...  Not sold we can get enough information outside the process.

So here are some things that come to mind, and I may be completely wrong on some of them :) - but may be worth talking about! I'll talk about each one:

agent process is unresponsive

I suppose an important question here is: what is "unresponsive"? It's not just accepting any work now? Or no longer communicating with Buildkite?
If the thread that's doing the actual work somehow gets stuck, but the thread that is running the HTTP server is still running fine, this could give funky results. So we'd need to handle that some how.

agent crashed

Because of the way Go handles errors, it makes actually crashing the program very difficult (unless you call panic) which we don't do anywhere. If the agent crashes, wouldn't it be easier for the OS to just restart it? Instead of taking it out of the group? upstart, monit, inspeqtor have already solved this problem.
Touch wood :evergreen_tree: we've never had a report that an agent has panic'd and crashed. One of our customers has an auto-scaling EC2 group setup with our agents. They pipe their build queues into CloudWatch, and it automatically scales up/down how many agents they have running at once. It's working great for them, and they've never had a problem with agents getting stuck on their end.
Buildkite already has a mechanism to detect agents that have crashed. We already take them out of the pool of agents when we don't hear from them in a while - so the only thing we need to solve now is taking it out of your server rotation.
Other approaches
Just like you're not sold on the pid monitor, I'm not sold that banging a HTTP server in the agent is the best solution :) Just like we don't do our down daemonizing (because that's a solved problem from other tools). If enough people wanted it - then we can revisit. But I think we together we may be able to find a solution that should work for your use case! :dancers:
So, here are some other ideas:

When Buildkite detects an agent as missing, we send a webhook to you with details about which one was lost, and you remove that server from the group using the AWS API. Our agents check in ever 3-5 seconds, so if we haven't heard from the agent in a while, we assume it's gone. We can let you know when this happens.
I think this would be a good approach, because once you start accepting those hooks, you can start pumping your build queue information into Cloudwatch to spin up/down instances.

Using one of the monitoring tools I mentioned, detect if the agent crashes/stops, and then touch /var/www/broken.txt and you have some nginx rules that detect if the broken.txt is present, and starts returning a 500.

if (-f $document_root/broken.txt) {
  return 500;
}

Again, using one of the tools I mentioned above, when you detect a fatal crash, and it can't be restarted, call sudo shutdown now - which should take it out of rotation, right?

Other tools
Can we learn anything from how other tools do this? How does AWS recommend you remove servers from a scaling group? I tried to find some docs on it, but it seems they just let you handle that stuff yourself.

An unresponsive agent would be one not accepting any new work or is hung running a job for a long time.  Long time being undefined for now, but there's probably a rough guideline to use, such as a step not finishing in 30 minutes.
It sounds like the big question is how to notify the infrastructure running the build agents to terminate the instance with an agent in a bad state.  The four options you outlined are ways to handle that.  My thoughts:

A webhook receiver would mean each customer would need to make their own infrastructure to accept the call and sort out the logic to find which instance to terminate.  Adds a fair amount of complexity and each customer would have to make their own stack.  Maybe provide a solution that receives the webhook and allows a shell command to be run on reception?  That way AWS users can use that to implement the shutdown command mentioned in option three.

A watchdog process along with an nginx process adds complexity to each instance.  It smells a bit and only handles crashes of the process.

A watchdog process that can shut down the instance sounds simpler.  This means the autoscaling group can be made without using an ELB, thus no need for an ELB healthcheck.  Of the four options this one appeals the most.  Still only handles the agent crashing though.

Cycling all instances regardless of agent status seems a good way to waste money and bandwidth. :)

I do hear you about the stability of the golang process - explicit error handling makes crashes less likely, but there could be other factors that nix the process.  Kernel bugs, instance running out of resources such as memory and starts killing processes, etc...  And yes, there could be a state where the http server goroutines work fine but the "worker" goroutines can be hung up.
I've requested someone weigh in on the canonical way of removing servers from an ASG.

AWS AutoScaling really manages host swaps for you. I can think of two distinct ways off the top of my head that would give you the desired effect of swapping a host out of the group:
(1) The AutoScaling service exposes an API to manage instance health, SetInstanceHealth (http://docs.aws.amazon.com/AutoScaling/latest/APIReference/API_SetInstanceHealth.html), so you can manually set it to unhealthy. This will cause the AutoScaling group to replace the unhealthy node. Cycling instances in and out of the logical group of instances is handled by AutoScaling. The major part of it is getting agents "registered" back with the "master" service on instance boot. That's just a matter of configuring the registration with the boot.
(2) Maintain a fixed AutoScaling group size, and just either shut the instance down from within the OS, or call the EC2 terminateInstances API. This would force the ASG to normalize by launching a replacement.
Option #1 is far more flexible, as it allows you to scale the fleet in and out, without risk of behavioral changes regarding desired capacity vs. current capacity, etc... if AWS decided to modify the functionality under the covers. It also gets things into a less wasteful mode of operation, and unleashes more cost-effective workflows.
Of course, the effectiveness of this assumes that the health and state of the agent can be accurately determined/interrogated beyond "is the process in a running state and not hung on a task?"

Howdy guys.  Any more thoughts on this?

Hey @matthewkmayer - sorry - we've been flat out prepping for the new agent release. We've been deep in writing documentation lately - so we haven't had a chance to start thinking about new features. How's the agent been tracking without this feature for you? Is it ok, or have you hit some snags?

We've not had a chance to pick this up again ourselves, but we still desire an external health check.

I've had a think about this some more, and the solution we want to support for now is to go with the watchdog process, like the one I created before: https://github.com/buildkite/elb-healthcheck-pid
There are too many variables to determine if an agent is "hung", and because of the agent's concurrent nature, we would have to do some drastic rewrites of it's internals, that we have no plans to do at this stage. If a goroutine does get stuck or blocks indefinitely due to a bug, the healthcheck HTTP endpoint will continue to function correctly, and the server will remain in rotation.
If a user does notice something wrong, then can hit the "Stop" button on the agent. We can trigger a webhook if someone does do this so you can hook it up to ELB to take that server out of rotation.
We've not had reports of hung or crashed agents before, touch :evergreen_tree:.
If jobs get hung, users can use the Automatic Timeout feature to have jobs automatically killed after a certain period of time. If a job does hang, then the job should just get cancelled, no need to remove the server from the fleet.
If the agent crashes, upstart will take care of that. If it fails to start, you can user other tooling to notify ELB and take that server out of rotation. No need to remake that stuff in the agent. You'd probably not want to take the server out of the fleet anyway, so you can debug what's going wrong.
It's also common and recommended to run multiple agents on the same machine, which would add another layer of complexity around this.
Sorry If I've wasted your time on this @matthewkmayer! If there's more demand for this sort of feature from others, we can take another look at it down the track. We've got some customers running agents across entire AWS fleets, and to our knowledge there's been no problems related to the agent.
If there's any information that we can expose from the agent or any webhooks that we can trigger that would make the integration on your side easier, we'd be happy to look into that!

Sorry to dig up an old thread.
Would it be possible to expose a command like buildkite-agent status?
I would expect it to return a successful status if it has an active connection to the buildkite API.
That would be quite helpful in implementing such a health check endpoint.
In my case, I plan to simply run the busybox httpd daemon on the same machine (same docker container in my case), which exposes a cgi script as health endpoint that would then call the aforementioned command.

FYI, https://github.com/buildkite/agent/pull/1066 implements this. :)


check21 - If no account cloudtrail trail is found, check org trail

This check started failing when we moved to an org trail...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks!


Doc update: Nuke Vectorfield now matches OCIO applying CSP LUT

http://opencolorio.org/FAQ.html#what-are-the-differences-between-nuke-s-vectorfield-and-ociofiletransform
..is now outdated - was true of Nuke 6.2, but the Vectorfield in 6.3v8 appears to match the OCIOFileTransform almost exactly.
Should update the documentation to reflect this

I assume so, but this is for all the listed file formats?


feat: github actions

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Tooling update

What is the current behavior? (You can also link to an open issue here)

CircleCI is used for ci, which on the free tier results in a lot of queued jobs

What is the new behavior (if this is a feature change)?

This is now all done on github actions.
From the first few runs, this looks to bring the average runtime (when nothing was blocked on circleci) down to 7 minutes from 11 minutes.
Some parts of the flow have not been tested very well, and should be closely monitored during the first release to ensure it goes smoothly

Other information:

Some time after this has been merged, the old circleci config can be removed. When this is done, circleci will want to be disabled completely for the repo, otherwise it will report an error/failure for every push.
If it is needed urgently, the contents of the cirlceci file can be uncommented (and the noop section removed), and the .github/node.yaml can have the file extension changed to disable
Status

[ ] Code documentation for the relevant parts in the code have been added/updated by the PR author
[ ] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Codecov Report

Merging #428 (3f48978) into release29 (74f939e) will increase coverage by 31.32%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release29      #428       +/-   ##
===============================================
+ Coverage      68.67%   100.00%   +31.32%
===============================================
  Files            213         1      -212
  Lines          14258        21    -14237
  Branches        3221         5     -3216
===============================================
- Hits            9792        21     -9771
+ Misses          4291         0     -4291
+ Partials         175         0      -175

Impacted Files
Coverage Δ

meteor/server/api/playout/pieces.ts

...ckages/server-core-integration/src/lib/timeSync.ts

meteor/lib/collections/lib.ts

meteor/lib/collections/Users.ts

...teor/server/api/blueprints/context/adlibActions.ts

...eor/server/migration/deprecatedDatabases/0_25_0.ts

meteor/server/api/peripheralDevice.ts

meteor/server/migration/1_10_0.ts

meteor/lib/collections/ShowStyleVariants.ts

meteor/lib/collections/ExpectedPlayoutItems.ts

... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f939e...3f48978. Read the comment docs.

Codecov Report

Merging #428 (3f48978) into release29 (74f939e) will increase coverage by 31.32%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release29      #428       +/-   ##
===============================================
+ Coverage      68.67%   100.00%   +31.32%
===============================================
  Files            213         1      -212
  Lines          14258        21    -14237
  Branches        3221         5     -3216
===============================================
- Hits            9792        21     -9771
+ Misses          4291         0     -4291
+ Partials         175         0      -175

Impacted Files
Coverage Δ

meteor/server/api/playout/pieces.ts

...ckages/server-core-integration/src/lib/timeSync.ts

meteor/lib/collections/lib.ts

meteor/lib/collections/Users.ts

...teor/server/api/blueprints/context/adlibActions.ts

...eor/server/migration/deprecatedDatabases/0_25_0.ts

meteor/server/api/peripheralDevice.ts

meteor/server/migration/1_10_0.ts

meteor/lib/collections/ShowStyleVariants.ts

meteor/lib/collections/ExpectedPlayoutItems.ts

... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f939e...3f48978. Read the comment docs.


Pool: Longevity handling.

Currently it's O(n) to remove stale transactions - we could optimize this bucketing transactions into eras (like every 64 blocks) and then just considering transactions in a particular era (that would add another mapping to the queue (era -> transaction) that would have to be kept in sync though)

Existing tests were aleady checking valid_till, but as Instant - the only difference now is that we use block numbers instead of time, so the tests were just changed.


Implement deleteObject(persistenceId: String, revision: Long) properly

As can be seen from https://github.com/apache/incubator-pekko-persistence-jdbc/blob/db5733e60fffb99d3d822d3d60199ec2f0890278/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L117-L118 the current implementation of deleteObject(persistenceId: String, revision: Long) just defers to deleteObject(persistenceId: String) (which means it ignores the revision).
The implementation should instead be improved so it only deletes correct revision.

#156 merged


non-attachables in masks3d

Three of the modules in masks3d are not attachable.   Two of them were written to take anchor, spin and orient args but ignored those args.  I've cleaned that up and added no_children() to the relevant masks, but maybe they should be attachable?   The affected masks can be found by searching for no_children.

Looks like this was fixed.


Upgrade version requirement of coremltools to 3.1

coremltools 3.1 was just released; we should bump the requirements to 3.1 from 3.0b3.

@srikris -- Why is this removed from the 6.0 milestone?  It doesn't make sense to force us and users to depend on a beta version of coremltools with a new release is out that isn't in beta.


Does FlaUI can read the cursor position and text from custom controle like devExpress Editor (XtraRichEdit/5.2.16) ?

HI,
At present, i am using UIAComWrapper in my project. It's working fine but stuck at few important task on handling the cursor position inside the custom control like DevExpress or TX text control rich formating editor.
All this custom control does not have any control pattern like,  TextPattern, TextPattern2, ValuePattern.  How can we read text and cursor position without any text pattern support?
Attached inspect screen of control

Would you please guid me is this FlaUI can handle the cursor position inside the text and read text from custom text control..
Regards,
Piyush

If the control does not provide any UIA-Access, it gets a bit harder. First, check if you can enable UI-Automation in DevExpress itself. For WPF, there is a property ClearAutomationEventsHelper.IsEnabled = false; that enables additional automation helpers (at the cost of a bit of performance). If that does not provide more information there are only two possibilities: Either screenshot the control and use OCR to get the text or copy the text to clipboard (via Keyboard) to get the text.

DevExpress version that we are using does not have UIA access , or any text pattern support.  We are accessing text via clipbaod but it too slow.
Makie it faster I am planing to explore , TSF, https://learn.microsoft.com/en-us/windows/win32/tsf/text-services-framework
It's may help to get text from cursor position.  Any thought on text service framework(TSF) ?


Update accumulo to 1.8.1 in mini-accumulo-cluster

Currently the mini-accumulo-cluster module is using an old version of accumulo, 1.6.5, when the gaffer docs mention that it was extensively tested on 1.8.1.

Migration Steps
This only applies to you if you are using the mini-accumulo-store.
You shouldn't need to do any migration, but it is worth noting that the version of accumulo used for the mini accumulo store has been updated to 1.8.1, inline with the the accumulo version for the rest of Gaffer.

Merged into develop.


CIP-0001 | Rework to reflect reality

This is the first step in a broader work aiming at pushing the CIP in the forefront of every Cardano changes. Before addressing current shortcomings of the process, it is necessary to capture what the process actually is at present.
This rework will serve as a base for a retrospective discussion amongst the editors and, shall be proposed to the
community for approval and review.

see rendered Markdown

I can't give this a full read & review before the upcoming retrospective meeting but at first glance it looks excellent & I'll catch up with it in the next day.  Recently I realised how badly we needed this, especially with more community postings (for example) suggesting an inappropriately loose definition of "CIP" has been going around.  It will be great to refer people to something more rigorous & updated :sunglasses:

This is way better!

People (including me, some time ago) wonder about cips.cardano.org - how it's different from GitHub, how it's generated.

Perhaps this repository needs a CONTRIBUTING: obviously for contributing CIPs themselves, it should link to CIP-001, but there are clearly a few other things to say, like how the website works and so on.

Yes, Michael did it on purpose to force the re-introduction of a "rejected" status. Smart move.

Honestly I just forgot you were going to remove it 😆

Had a little chat about the "rejected" status wrt https://github.com/cardano-foundation/CIPs/pull/336. I think that "rejected" is not quite right, since it's not the case that the CIP process has rejected this proposal. What's more accurate is to say that it is no longer supported by its author. So something like "withdrawn" is maybe more appropriate.
However, if you want to have a single "dead" status my vote still goes to "inactive", perhaps with the suggestion that an inactive proposal should have a short note explaining why it is inactive? "Inactive: no activity", "Inactive: withdrawn by proposer", "Inactive: superseded by X"?

Looking back at how we historically handled things: I don't like inactive, nor do I like rejected (for the reason you mention). There has been only a couple of cases where we had a desire from an author to merge an "anti-CIP"; or said differently, to merge a purposely bad idea to keep a track history of discussions that happened. CIPs that are rejected are typically closed without making it to the repository. Once again, I am not saying that this is the process we want in the long-run, but it is the process we follow de facto.
Since the action of proposing a purposely wrong CIP reflects an actual author's will, I think the status should also. Something that expresses "contemplated but rejected". Maybe: discarded or dropped ?

I think there could be other workflows. Consider e.g. a pretty good CIP that gets merged, has lots of discussion, but then eventually it turns out that for some obscure incentives reason it can't be implemented in current Cardano. We probably don't want to delete it, but it would be nice to mark it in some way that makes it clear that it's not a live proposal any more.

I would suggest "Invalid" (or "Declined") if not for the implication that people should be prevented from doing things differently than we've documented in CIPs.
"Disavowed" may be closer but sounds overly dramatic, like from a spy movie... as does "Sanctioned" which also has the same problem as "Invalid".
"Challenged" could incorporate all the possibilities above why a CIP "didn't make it"... but doesn't answer the next question in the mind of the reader: Why was it challenged?
So, since none of these words will ever really tell the whole story, no matter how specific one or several choices would be, I also think the only option remaining is to add a qualifying phrase to Inactive as suggested in https://github.com/cardano-foundation/CIPs/pull/331#issuecomment-1259323553.  It shouldn't be that hard to establish (starting with the 2 or 3 cases we've seen so far) a canonical set of choices to add after Inactive:.

As far as I know, I wasn't given a change to comment about the reason for my last commit... which was to keep this fresh after the omnibus update to the top level README.md of https://github.com/cardano-foundation/CIPs/pull/338.

Opted for the following statuses rework:

Status
Description

Draft
An implicit status given to newly proposed CIPs that haven't yet been validated or reviewed.

Proposed
Assigned to CIP that has been reviewed, accepted and now working towards acceptance. 'Proposed' generally means that implementation is ongoing or that adoption from various actors is missing before moving to 'Active'.

Active
The proposal has completed all steps needed for its activation. Said differently, it means observable metrics showing its adoption in the ecosystem.

Inactive
The CIP is no longer, or has never been, active. When marked 'Inactive', the status should also indicate a reason (e.g. obsolete, superseded, abandoned...). For example: Inactive: superseded by CIP-XXXX

I was also going to say that not yet Active proposals submitted as PR's would have to be triaged to include a Path to Active if they were submitted as Proposed... but @KtorZ I guess you are planning an new state that does not imply review but means more than the meaningless Draft 🤓

I've included most feedback (I hope) in this latest version. Note that I have left the discussion / rework of the statuses for the next iteration -- the one that'll define the new process. In this one, I have left the previous statuses as they were defined (and simply removed 'On Hold' which we literally never used).
Tried to clarified the wording on the statuses thanks to @michaelpj's feedback. I hope we can get this one on review next week and merge it A.S.A.P. so we can have a proper discussion on what the CIP process should become next.

@rphair I think that a PR template that
(a) reminds of CIP-0001
(b) points to CIP-TEMPLATE.md
(c) encourages people to also provide a rendered version of their CIP (using Github's existing capabilities)
should address your concerns right? I did remove the previously PR template on the basis that indeed, we do not want people to generally put the CIP's content in their PR body and thus, having the CIP template defined as a PR template felt off. Or are you suggesting that we should encourage people to do exactly as such? (reading your last comment, I am not sure anymore).
I can also add a link to the CIP-TEMPLATE.md somewhere on the root README, to make it more apparent.

thanks @KtorZ, the content & proposed usage of the template are fine... I'm only suggesting that this PR template itself should be something that people can read and find easily, regardless of how it's used or not used in the PR submission process.
i.e. showing it somehow in this directory in which the contents of the .github directory are suppressed: https://github.com/cardano-foundation/CIPs/tree/cip-0001-rework/CIP-0001
I do agree, and have never disputed, that stuffing the template into a PR form would encourage the CIP going into the OP which has always been messy. 😎

p.s., hopefully explaining myself better this time 😖 ... I'm happy with & approving this draft either way, yet also thinking from the point of view of those who only want to learn (and possibly write) about the CIP process without actually writing a CIP.  It will help these visitors to CIP-0001 to see the structural template in the directory listing, and not have to look for & possibly miss it in a document reference that currently looks like a footnote. 🤔

Merging this one now, to make room for the actual rework and CIP-9999.


Tamagui's Image ignoring dimensions

Current Behavior
Using Image from tamagui results in:

the element not being displayed on web
showing the image in its original dimensions on mobile

This happens even when dimensions are passed
Expected Behavior
I'm expecting the image to render at the proper size, on both web and mobile
Tamagui Version
Latest (1.71.0)
Platform (Web, iOS, Android)
At least web and iOS
Reproduction
import { Image } from "@tamagui/image
<Image
  source={{ uri: 'https://tamagui.dev/social.png ' }}
  height={200}
  width={200}
  />

This renders but dimensions are completely ignored. Codesandbox to reproduce

Can you add width/height to the source={{ uri: '', width: 200, height: 200 }}
The outer width/height applies only to style, whereas the source one applies to the image.

@natew

The outer width/height applies only to style,

Actually, the issue is that it currently does not apply at all, not even to style. I believe this is the regression

Can you add width/height to the source={{ uri: '', width: 200, height: 200 }}

This is a good workaround for web in the meantime. But it won't work on mobile where the source can be a number handled by Metro.

Workaround
As a workaround, I'm back to using react-native's Image:
import { useStyle } from "@tamagui/core";
const style = useStyle(propsIn, { resolveValues: "auto" })
<Image style={style} source={source} />;

fix in next release

lmk if that works

Works perfectly! Thanks for the import normalization as well, I had something custom that's not necessary anymore 🙂


Fix background scrolling for Android and improve on iOS

Apply the reveal iOS background scrolling fix to Android as well to prevent background scrolling, and improve the recovery of position on mobile reveal close.  Fixes issue turned up by QA.

don't know how but it works


fix issue in SliceMap/Maps for package gconv when nil value in map of slice item

Codecov Report
Patch coverage: 54.54% and project coverage change: -0.01% :warning:

Comparison is base (243fe73) 79.17% compared to head (792e488) 79.16%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2857      +/-   ##
==========================================
- Coverage   79.17%   79.16%   -0.01%
==========================================
  Files         634      634
  Lines       52423    52428       +5
==========================================
+ Hits        41506    41507       +1
- Misses       8855     8858       +3
- Partials     2062     2063       +1

Flag
Coverage Δ

go-1.18-386
79.22% <54.54%> (-0.03%)
:arrow_down:

go-1.18-amd64
79.27% <54.54%> (+0.05%)
:arrow_up:

go-1.19-386
79.15% <54.54%> (+0.01%)
:arrow_up:

go-1.19-amd64
79.15% <54.54%> (+0.07%)
:arrow_up:

go-1.20-386
79.23% <54.54%> (+0.03%)
:arrow_up:

go-1.20-amd64
79.23% <54.54%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

util/gconv/gconv_map.go
96.00% <54.54%> (-1.15%)
:arrow_down:

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CB3S BK7231N AVATTO Tuya WiFi Door Sensor, Smart Door Open/Closed Detectors model DS06

this device has tuyamcu but it can be converted to openbeken even by removing mcu
out of curiosity i tried reading flash in 3 methods, bkwriter 1.60 in two modes and hid_download_tool without crc check, but binaries seems similiar.

CB3S_door_sensor.zip
full review will be posted on Elektroda later
MOSFET is used to turn of CB3S when not needed (energy saving feature)

but binaries seems similiar.

rolling hashes is because of the boot counter writing to flash changes the checksum of a full dump a little bit.

Hi, my Tuya Wi-Fi door window sensor look very similar to this one: The LPC 2129 is 90 degrees

Could you please let me know, (for a newby) how to extract the binaries?
Best Regards
P.S. I would like to flash a firmware, 'free' from tuya server - best it would connect to (any) WiFi router of my own in order to provide its door state. Possible??

An update has been pushed that should include a profile for this device.  Please update your repo and give it a try.  Please see the instructions page ( https://github.com/tuya-cloudcutter/tuya-cloudcutter/blob/main/INSTRUCTIONS.md ) for any command or input changes.
If the new profile does not work, please re-open this ticket with details (including logs) of the failure.
Any feedback is appreciated.


Add KytheFS + configure kythe_langserver...

...to serve //kythe/go/...
The README.langserver file details how to use the language server to
serve crossreferences to compliant editors (I tried vim-lsp).
Using KytheFS in addition enables virtual sources to be navigated and
crossreferenced.
Review note: I didn't have Go readability, so please suggest improvements.
Also there are no unit tests, I can add some later, or even now if you are keen.
CC @creachadair @shahms

Also, thanks for this!

Addressed all comments, PTAL.

This has a lot of lint errors which are now impacting my ability to push unrelated changes:
>>> Lint for README.langserver:

   Error  (S&RX) copyright header
    File missing copyright header

    >>>        1 # Running Kythe Langserver
                ^
               2
               3 Note: Below only tested for serving Go code.
               4
>>> Lint for kythe/go/serving/tools/kythefs/kythefs.go:

   Advice  (GOLINT) GOLINT
    Exported type KytheFs should have comment or be unexported

              64 		"[--server SERVER_ADDRESS]")
              65 }
              66
    >>>       67 type KytheFs struct {
                      ^
              68 	pathfs.FileSystem
              69 	Context context.Context
              70 	Api     api.Interface

   Advice  (GOLINT) GOLINT
    Struct field Api should be API

              67 type KytheFs struct {
              68 	pathfs.FileSystem
              69 	Context context.Context
    >>>       70 	Api     api.Interface
                  ^
              71
              72 	WarnedEmptyCorpus       bool
              73 	WarnedOverlappingPrefix bool

   Advice  (GOLINT) GOLINT
    Should omit 2nd value from range; this loop is equivalent to `for k :=
    range ...`

             195 	}
             196
             197 	var results []FilepathResolution
    >>>      198 	for k, _ := range nextDirs {
                         ^
             199 		res := FilepathResolution{NextDirComponent: k}
             200 		results = append(results, res)
             201 	}

   Advice  (GOLINT) GOLINT
    Exported method KytheFs.FetchSourceForURI should have comment or be
    unexported

             253 	return true, nil
             254 }
             255
    >>>      256 func (me *KytheFs) FetchSourceForURI(uri *kytheuri.URI) ([]byte, error) {
                 ^
             257 	ticket := uri.String()
             258 	dec, err := me.Api.Decorations(me.Context, &xpb.DecorationsRequest{
             259 		Location:   &xpb.Location{Ticket: ticket},

   Advice  (GOLINT) GOLINT
    Exported method KytheFs.FetchSource should have comment or be unexported

             265 	return dec.SourceText, nil
             266 }
             267
    >>>      268 func (me *KytheFs) FetchSource(path string) ([]byte, error) {
                 ^
             269 	resolutions, err := me.ResolveFilepath(path)
             270 	if err != nil {
             271 		return nil, err

   Advice  (GOLINT) GOLINT
    Exported method KytheFs.GetAttr should have comment or be unexported

             292 // go-fuse stub implementation
             293 //
             294
    >>>      295 func (me *KytheFs) GetAttr(path string, context *fuse.Context) (*fuse.Attr, fuse.Status) {
                 ^
             296 	resolutions, err := me.ResolveFilepath(path)
             297 	if err != nil {
             298 		log.Printf("resolution error for %q: %v", path, err)

   Advice  (GOLINT) GOLINT
    Exported method KytheFs.OpenDir should have comment or be unexported

             332 	return nil, fuse.ENOENT
             333 }
             334
    >>>      335 func (me *KytheFs) OpenDir(path string, context *fuse.Context) (c []fuse.DirEntry, code fuse.Status) {
                 ^
             336 	resolutions, err := me.ResolveFilepath(path)
             337 	if err != nil {
             338 		log.Printf("resolution error for %q: %v", path, err)

   Advice  (GOLINT) GOLINT
    Exported method KytheFs.Open should have comment or be unexported

             399 	return result, fuse.OK
             400 }
             401
    >>>      402 func (me *KytheFs) Open(path string, flags uint32, context *fuse.Context) (file nodefs.File, code fuse.Status) {
                 ^
             403 	// Read-only filesystem.
             404 	if flags&fuse.O_ANYWRITE != 0 {
             405 		return nil, fuse.EPERM

   Advice  (GOLINT) GOLINT
    Var kytheApi should be kytheAPI

             427 		log.Fatal("You must provide --mountpoint")
             428 	}
             429
    >>>      430 	kytheApi, err := api.ParseSpec(*serverAddr)
                  ^
             431 	if err != nil {
             432 		log.Fatal("Failed to parse server address!", *serverAddr)
             433 	}

@shahms Thanks for notifying, will prepare a PR.

JFYI, https://www.kythe.io/contributing/#linting-and-testing talks about how to hook up the lint checks as a pre-commit hook.


MAC ADDRESS is case sensitive in RaspDacDisplay and logs CLI ERRORS

Lot of cli errors logged if characters of MacAddress is in CAPS in RaspDacDisplay.py
[16-11-14 16:57:19.9610] Slim::Plugin::CLI::Plugin::cli_socket_accept (236) Warning: Closing connection: too many connections open! (30)
[16-11-14 16:57:20.2530] Slim::Plugin::CLI::Plugin::cli_socket_accept (236) Warning: Closing connection: too many connections open! (30)
[16-11-14 16:57:20.5439] Slim::Plugin::CLI::Plugin::cli_socket_accept (236) Warning: Closing connection: too many connections open! (30)
[16-11-14 16:57:20.8288] Slim::Plugin::CLI::Plugin::cli_socket_accept (236) Warning: Closing connection: too many connections open! (30)
[16-11-14 16:57:21.1096] Slim::Plugin::CLI::Plugin::cli_socket_accept (236) Warning: Closing connection: too many connections open! (30)
[16-11-14 16:57:21.3999] Slim::Plugin::CLI::Plugin::cli_socket_accept (236) Warning: Closing connection: too many connections open! (30)
[16-11-14 16:57:21.6859] Slim::Plugin::CLI::Plugin::cli_socket_accept (236) Warning: Closing connection: too many connections open! (30)
[16-11-14 16:57:21.9661] Slim::Plugin::CLI::Plugin::cli_socket_accept (236) Warning: Closing connection: too many connections open! (30)

Thanks for reporting this.  I will see if I can reproduce the issue.

I've changed the comparison between the MAC address returned from LMS and the provided LMS_PLAYER value so that it is case insensitive.


Papilio 51 error handling implementation

Added winston logger library for all logging activities
Centralized all error handling acitvities
Refactored controllers, services and repos to reflect new error-handling framework
Added a types folder for all statusCodes available
Updated package.json with nodemon

Need to:

Document error structure and codes
Add tests
Add validation (useful to prevent update user errors in sequilize i.e. phone number too long)

Small typos, otherwise good job! I think tests should come with new features and we should not wait to implement the features first and put the tests in a secondary position because we will get behind schedule very fast on the testing side if it is not done together with the features


Extend preview notice to .NET 8 doc versions

Display the preview warning that was added to What's new on all docs when .NET 8 is selected.

Associated WorkItem - 132842

Fixed by #29844


No indication that some controls are toggles

Metadata icon,
Switch Workspace
Bookmark
Need visual indication that clicking again turns it off

related to #782


Support BlueSCSI compatibility mode for names of drive image files

BlueSCSI codes drive properties in the name of the image files. While the command line approach of SCSI2Pi/PiSCSI is more flexible it would be useful to have a compatibility mode with the same parsing rules as those used by BlueSCSI, see https://github.com/BlueSCSI/BlueSCSI-v2/wiki/Usage. In this mode you can directly use existing BlueSCSI image files for SCSI2Pi without having to provide a full set of SCSI2Pi command line options.
A new device-specific s2p option "-B" shall switch to the compatiblity mode when parsing the data for the respective device. With this option s2p takes the drive parameters from the filename.
Instead of
>s2p -i 0:2 -b 1024 -n vendor:product:revision test.hds

you can also use an image file with a filename in BlueSCSI format:
>s2p -B HD02_1024_vendor:product:revision.hds

Note that there is a separator "_" between the sector size and the product data. If this separator is missing the string after the block size is ignored, because BlueSCSI permits any string between the block size and the extension. Without the "_" marker s2p cannot know whether to parse this string as product data or not.
The existing s2p command line options shall override the settings taken from the filename:
>s2p -B -i 2 HD10_1024.hds

This command assigns the drive a SCSI ID of 2, because "-i" overrides the SCSI ID 1 coded in the filename.
>s2p -B -h 2 HD10_1024.hds

Same as above, but for a SASI instead of a SCSI drive.
While BlueSCSI does not make use of the LUN number in a filename, SCSI2Piuses it.
>s2p -B HD10.hds -B CD131.hds -B RE11.hds

This results in a SCSI hard drive with SCSI ID 1, LUN 0, a CD-ROM drive with SCSI ID 1, LUN 31 and a removable media drive with SCSI ID1, Lun1.

@erichelgeson I would appreciate your feedback on this ticket. The proposed parsing rules would also make use of the LUN field, which appears to be unused in BlueSCSI. They also use the unused (in BlueSCSI) text between the sector size and the extension as the INQUIRY product data.
Would you expect potential compatibility issues with future BlueSCSI versions?

The issue_23 branch now contains unit-tested support for this compatibility mode.

Merged into develop branch

My 2c adding vendor/product/version is not needed. The "presets" we have defined would be a better option as there are usually other things that need to be set to be compatible with different host systems .

@erichelgeson Thank you for your feedback. As far as the SCSI2Pi compatibility mode is concerned only the filenames matter for this mode. This is not about further compatibility. Any other BlueSCSI configuration mechanism would be out of scope for SCSI2PI, which has its own configuration mechanism for defining custom mode pages etc.
The option of having the product data in the filename would just be something I think is convenient, because SCSI ID/LUN, sector size and product name are the most frequent configuration properties as far as I can tell.


how do i implement a function like CyclicBarrier

i have called several requests,i don't care about the callback order,but want to do something after all requests have callbacked just like CyclicBarrier.i created CyclicBarrier and called CyclicBarrier.await() after each callback,but it didn't work,some request(maybe onSuccess callback) even don't execute.
CyclicBarrier barrier = new CyclicBarrier(5, new Runnable() {                                 @Override                                 public void run() {                                     Log.i("CloudSyncTaskService", "CyclicBarrier: done！");                                 }                             });                             requestBaseArgsSet(wcuSn,barrier);//AsyncHttpClient request                             requestAdvArgsSet(wcuSn,barrier);                             requestCollectData(wcuSn,barrier);                             requestDeviceEvent(wcuSn,barrier);                             requestDeviceAlert(wcuSn,barrier);

Best coding practices should be discussed on stackoverflow.com
Issues in this project are meant to track bugs and feature requests, not general programming questions.


⚠ Orpheus has degraded performance

In 5b2b4cf, Orpheus ($OPS) experienced degraded performance:

HTTP code: 504
Response time: 21856 ms

Resolved: Orpheus performance has improved in 0effbd4.


How to customize the colour of one specified elements?

It is possible to select primary colour and accent colour to customize the colour of MDL elements, but how can I customize the colour of some specified elements(such as: use css selectors or attributes) other than the primary and accent colours.

@futursolo Use .mdl-color--indigo-100 for background and mdl-color-text--grey-800" for text color.
Color names and depths you can find at MD docs

Our classes for these are quasi-deprecated. Adhereing to MD restricts you to the primary and accent color (using 3 hues from each.) In the next major these specific classes are going to be removed by default. I am going to look into ways to help with getting pallet color hues in, but using direct classes isn't a good method. Including these is a bunch of bloat when most of the classes are never used.

Limit your selection of colors by choosing three hues from the primary palette and one accent color from the secondary palette. ---- Via MD color

The preferred solution at the moment (and unto the future) is to use a Sass build pipe and use the color variables directly in your classes to set colors.


Release date keeps getting updated even if you're updating the content of the release notes

Gitea version (or commit ref): 1.12.2
Git version: 2.14.5
Operating system: MacOS
Database (use [x]):

[ ] PostgreSQL
[X] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[X] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
When I make a release, the created unix time gets set to the time I make the release, no the commit, which is right.
Yet if I now update my release by editing its content, its date changes.
This is a problem if I update an old release, such as tell users not to use, it becomes the release at the top of the release page!
Related to this change: https://github.com/go-gitea/gitea/pull/11218
Basically you should only change the release created_unix if it is making an actual tag (going from Draft to pre-release or release), do not touch it if updating a release or pre-release.
...
Screenshots
On try.gitea.io, making two releases v1, then v2, then edit v1. It now is at the top.

I'll probably end up working on this anyway. Will make a fix.


initial={true} on tab page doesn't work.

When I set initial={true} on Tab 3, the view initially is set to Tab 3, but the TabBar icon still shows Tab 1 is selected.
This is simple to reproduce in the current example. I have it in my repo here

Please try 'selected' not initial. Initial is only for root initial route.

Hmmm. That makes it worse. Now both Tab1 and Tab3 are highlighted in the tab bar, and the view is of Tab1.

Then that is bug (selected), i will look at it, thanks.

And you are right, probably i should do select it with 'initial', to avoid complexity.

@chetstone could you look into this issue and fix it?

I spent some time last night and tried a couple of things but the code was
very hard to follow. If you're thinking of refactoring, maybe this should
wait. Refactoring may be a good idea: my feeling (could be wrong) is that
processing the children of  could be different. Somehow I think it
should not matter if the Router is a TabBar router or not --- any Router
(or nested router) should be treated the same, e.g. it could have 'initial'
defined.
What is different about a tab bar router is that it has to deal with an
extra component (TabBar), and the actions are switch instead of push/pop.
Otherwise the same.
On Tue, Dec 15, 2015 at 2:00 AM, Pavlo Aksonov<EMAIL_ADDRESS>wrote:

@chetstone https://github.com/chetstone could you look into this issue
and fix it?
—
Reply to this email directly or view it on GitHub
https://github.com/aksonov/react-native-router-flux/issues/62#issuecomment-164691595
.

@aksonov @chetstone Thought I might look at this. Do either of you have any changes pending?

@smallsaucepan No, you could work on it.

@smallsaucepan Any update for this?

I finally had some time to look at this again. @aksonov, the good news is that it looks like the structure of your code has improved a lot with the refactor. The bad news is I haven't gotten any smarter, and I still can't figure it out.
It looks like the error is caused by Tabbar:getChildrenState() being called with a null selectedRoute parameter on initial render. I've figured out a couple of ways to fix that --- the easiest for experimentation is just to add the prop initial="tab4" to tabbar router like this:
<Router footer={TabBar} showNavigationBar={false} initial="tab4" >

Then I get the error:
Cannot find router for route=tab4 current router=root

and I'm stuck trying to figure that out.

Should be fixed with latest version, please check.

Seems to be fixed in 2.3.6. Thank you!


Account password easily retrievable

It is possible to retrieve every set password by going into the 'Waltz Management' page, press the 'decrypt' and 'show' buttons.
The only requirement is being logged in in clef(/waltz?). If the user has multiple sites saved in waltz chances of being logged in is very high. Leaving the computer unattended and unlocked for even a short amount of time has the risk of having every password stolen.
The current situation requires the user to either lock the computer or log out of clef completely.
My suggestion would be to either:

Require a password to decrypt the password (doesn't seem to fit the philosophy of clef)
Don't display the password at all and only allow the user to change it.

PS: Leaving the computer unlocked is a user error and it's completely the users fault. But I don't think waltz should increase the damage such error would cause by exposing every password.

Hi! Thanks for taking the time to open an issue! When a user logs in with Clef, all the passwords are decrypted and when they log out they are re-encrypted. In the interim—when a user is on the computer with Clef active—users can view, edit, and delete the saved credentials. This is the expected behavior, let me know if you have any other questions!

The thing is: If they don't log out, ALL their saved password are visible in plaintext. One error can compromise ALL your passwords. It is worse than any browser built-in password management system. Chrome for example requires a password before showing any saved passwords as plain text.
There are no other password management system I know of that will expose ALL your password if you simply leave your computer for a small break without logging out.
Please rethink whether this behavior is secure enough.

FWIW, I use 1Password as well, and that also allows passwords in plaintext for a defined amount of time, without requiring a password. Similar to Clef, the timeout is configurable.


python312Packages.python-hosts: 1.0.6 -> 1.0.7

Changelog: https://github.com/jonhadfield/python-hosts/blob/1.0.7/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 333893 run on x86_64-linux 1

6 packages built:

python311Packages.python-hosts
python311Packages.python-hosts.dist
python312Packages.python-hosts
python312Packages.python-hosts.dist
tunnelgraf
tunnelgraf.dist


implementing sharing functionality

Implementing the first steps to share items.
Even this is a Draft for now I would like to hear opinions if that is the way forward.

CC @phil-davis @amrita-shrestha @S-Panta @nirajacharya2


Angular: Prerendering does not work when app is published on server, does not display HTML tags on ViewSource page. On Local host It is working fine

I have create the application with [ASP.NET Core X Angular] (14) - Server side rendering for SEO. All is working fine when publishing on local host but when I published on Server it is not working, It doesn't display HTML tags on view source.
Hope anyone find anything which can be helpful to me.
Thanks
Milan.

Thanks for contacting us. We're closing this issue as this doesn't align with our long-term plans in this area. You can read more details about our vision for this area at https://github.com/aspnet/AspNetCore/issues/12890.


Nav Tree Structure

I don't consider this feature fully-baked, but there are enough elements of it that I want to get it merged into place for you guys.
The top-level drizzle object available in template contexts now has a tree property, which has, at present, two sub-objects (pages and collections). These objects are structured in a more useful way to generate navigation. They are structured like (I'm going to write this in YAML for speed savings):
pages:
  items:
    - id: pages.index
      key: index
      path: ./dist/index.html
    - id: pages.another-page
      key: another-page
      path: .dist/another-page.html
  children:
    items: ...
    children: ...
      items: ...
      children: ...

You'll note the path properties aren't completely useful yet—they're calculated based on the dest options passed. We'll want to circle back when we get the BASE_URL stuff sorted.
I added some tests and some placeholders for more tests. Trying to get this out there so I can get out of the way sooner than later! The structure might not be quite right, but the foundation is there so you can tweak it as you like.

:+1:


Relay Plugin: Make ID encoding optional

Right now there's a handful of cases where the ID of relay nodes / cursors are base64 encoded. While at times this makes sense, there are cases where the ID type is already entirely opaque, and does not require encoding. It would be good to have a option to disable the automatic encoding of these values

2.0 has the ability to customize the id encoding (PR above).  Leaving this open to track auto-decoding global ids when used as in arguments. I've got a few ideas around that I want to try soon


guake: add missing dependency on setuptools

Motivation for this change
guake crashed at launch due to missing dependency:
  File "/nix/store/3pwkg13xs7brvhfm3xwnkj2ygfi5lfsg-guake-3.6.3/lib/python3.7/site-packages/guake/paths.py", line 26, in <module>
    from pkg_resources import Requirement
ModuleNotFoundError: No module named 'pkg_resources'

The missing module is provided by setuptools.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @msteen

Thanks.


⚠ Avatar API Endpoint has degraded performance

In 310c75c, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1349 ms

Resolved: Avatar API Endpoint performance has improved in 63b7d19 after 9 minutes.


Code 1: The operation was cancelled.

I am trying to run my Node.js application with this client library, but it fails instantly with this error message:
{
  "code": 1,
  "details": "The operation was cancelled.",
  "metadata": {
    "internalRepr": {},
    "options": {}
  }
}

It's not very helpful. And is there a place I can find a reference of the error codes? I couldn't find anything in the API reference
I have exported the GOOGLE_APPLICATION_CREDENTIALS env variable and double-checked that it's a valid service account with access to the Google Cloud Memorystore for Redis API.
I'm running the sample code below:
/**
 * List instances in a given location.
 * @param {string} project.
 * @param {string} location, e.g., us-east-1.
 */
async function main(projectId, location) {
    const { CloudRedisClient } = require('@google-cloud/redis')
    const client = new CloudRedisClient()
    const formattedParent = client.locationPath(projectId, location)
    const request = {
        parent: formattedParent,
    }
    try {
        const resp = (await client.listInstances(request))[0]
        console.info(resp)
    } catch (error) {
        console.error(error)
    }
}

main('<my-project-name>', '<my-procect-region>')

Do I need to set up a VPC connector if I'm using this SDK with a service account?

@draperunner I wouldn't expect you need to connect through a VPC, are you running on your local network? and is there a proxy you connect through perhaps?

Yes, I'm trying to run this on my computer on my local home network. I'm not using a proxy or anything like that. And my home office does not have any complex enterprise firewall setup either. A colleague suggested I would need to set up a proxy, but I hoped the service account credentials would be enough for local development.
After I found this: https://cloud.google.com/appengine/docs/standard/nodejs/using-memorystore I kinda gave up on this SDK and installed redis locally and the suggested node_redis SDK.

@draperunner I can't repro this with the code provied. I used my project and location us-west2.
With no redis instances it returns an empty array.
With a single redis instance:
Object {labels: Object, redisConfigs: Object, name: "projects/PROJECTNAME/locations/us-west2/instance…", displayName: "", locationId: "us-west2-b", …}

I'll see if I can debug some more tomorrow. I am using us-central1 and Node.js v10.13.0.

Found it!
TL;DR: The error comes from an old version of the transitive dependency @grpc/grpc-js. rm package-lock.json && npm install fixed it...
I created a new directory and ran the sample code I posted in the original post (with project and region replaced of course). Only dependency: @google-cloud/redis. To my surprise it worked fine.
I then tried the exact same code, but now with the file lying in the real project. Now I got the same error as described above. Therefore the error had to be with some dependency. From the stack trace I could see that @grpc/grpc-js was reporting the error. The result of npm list @grpc/grpc-js in the faulty project was:
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
while in the clean project:
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
Using npm list google-gax I found that @google-cloud/logging was also depending on it:
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>deduped
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
Deleting the package-lock.json and installing again with npm install updated the transitive dependencies and it works now. 🙄😄


Do not use command: in Vault Deployment

Is this a request for help?:
No

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature/Enhancement

Version of Helm and Kubernetes:
Helm v2.12, Kubernetes v1.11
Which chart:
Vault Helm chart at charts/tree/master/incubator/vault
What happened:
In the chart we run Vault as root as specified here: https://github.com/helm/charts/blob/master/incubator/vault/templates/deployment.yaml#L43
Output of deploying the chart:
# ps -ef
PID   USER     TIME  COMMAND
    1 root      0:07 vault server -config /opt/config/config.json
   26 root      0:00 bash
  176 root      0:00 ps -ef

What you expected to happen:
There is already a docker-entrypoint.sh as per the official Dockerfile. This script does some additional checks and also runs the program as vault user inside the container, which might be useful. Hence, instead of using command: in the chart, we should enable the usage of using the official entrypoint in the imae.
How to reproduce it (as minimally and precisely as possible):
Deploy the chart and run a ps -ef to verify. Also, run the command docker run vault locally, and verify that you see Vault run as the vault user:
/ # ps -ef
PID   USER     TIME  COMMAND
    1 root      0:00 {docker-entrypoi} /usr/bin/dumb-init /bin/sh /usr/local/bin/docker-entrypoint.sh server -dev
    6 vault     0:05 vault server -config=/vault/config -dev-root-token-id= -dev-listen-address=<IP_ADDRESS>:8200 -dev
   42 root      0:00 sh
   96 root      0:00 ps -ef

Anything else we need to know:
Nothing else, I think.

@jbialy @mikeraimondi @dimitrigraf @varshavaradarajan @wfernandes
Can you please help in assigning on removing the lifecycle/stale policy here?

/reopen

@krish7919 Can you attempt to implement the change, test and submit a PR? I agree that we should be using the default entrypoint defined in the vault docker image as opposed to overwriting it, if possible. However, I haven't tested this!

/reopen

Going to bump this again!

This is still a good issue to look into!


Progress.Circle is not working on Android - -Error while updating property 'stroke' in shadow node of type: ARTShape

This happens when we used Progress.Circle and Progress.CircleSnail
"Error while updating property 'stroke' in shadow node of type: ARTShape
Value for stroke cannot be cast from String to ReadableArray"
Progress.Bar might be working fine since it doesn't cause this error but we don't need the bar version for our app.

me too

me too

I switched back to version 3.5.0. Even 3.6.0 is not working..

Install this lib and check
https://github.com/react-native-community/art

Install this lib and check
https://github.com/react-native-community/art

I tried that before opening this issue. It didn't work.

Install this lib and check
https://github.com/react-native-community/art

This is working for me, but I hope we don't have to install an extra package.

Not working for me too, same issue running on android.

I fixed this problem, and it working , following is the method
see https://github.com/react-native-community/art readme,
we should migrating from the core react-native module
import {ART} from 'react-native'; const {Surface, Shape} = ART;
to
import {Surface, Shape} from '@react-native-community/art';
so , I override react-native-progress code ,modify import ART from  '@react-native-community/art',
like this :
`// import { ART } from 'react-native';
import * as ART from '@react-native-community/art'`,
remember modify all file in react-native-progress;
good luck.

@sszcome did anyone create a pull request yet?

@dogaoz I can have a look at creating a PR tonight

I created a PR at https://github.com/oblador/react-native-progress/pull/181

It is finally merged.
Imagine how tired we are lmao

has anyone succeeded to resolve this issue ?

I have @react-native-community/art version 1.1.2 and I have exactly the same issue. Any news on this ?

I have @react-native-community/art version 1.1.2 and I have exactly the same issue. Any news on this ?

Yeah I also encounter this.
I'm investigating and for now I've pinpointed this part of code:
return (
      <ARTShape
        d={path}
        strokeCap={strokeCap}
        strokeWidth={strokeWidth}
        {...restProps}
      />

The {...restProps} containing stroke property which causing the error

For some reason my project is trying to use Facebook's old ARTShapeShadowNode which has
@ReactProp(name = "stroke")
  public void setStroke(@Nullable ReadableArray strokeColors) {
    mStrokeColor = PropHelper.toFloatArray(strokeColors);
    markUpdated();
  }

don't know how to tell my project to not use this.

Managed to "fix" the problem right now with installing version 1.0.2 of art library as someone suggested here: https://github.com/oblador/react-native-progress/issues/179
I hope to find a proper fix.

Hi @Rotemy,
I installed the 1.0.2 of Art library but I still have the issue, what version of Progress are you using?
Thanks,
Théo

Hi @Rotemy,
I installed the 1.0.2 of Art library but I still have the issue, what version of Progress are you using?
Thanks,
Théo

I have 4.0.3, but I got to say that nothing is working for me, especially in iOS.
Very annoying.

me too... going crazy with this right now, I'm gonna use Activity Indicator for the time being.

eu também ... enlouquecendo com isso agora, vou usar o Indicador de Atividade por enquanto.

Veja isso https://github.com/expo/expo/issues/6523#issuecomment-571001942

me too

Downgrade it work for me: yarn add<EMAIL_ADDRESS>

yarn add @react-native-community/art and rebuilding the app worked for me. I believe because this package doesn't have any native code, autolinking for @react-native-communit/art doesn't work. For RN < 0.60, react-native link @react-native-communit/art is also required.
The fix should be that this library set up the native dependency properly, or at least add linking instructions to the readme.

Any new update on this, try latest version "@react-native-community/art": "^1.1.2" and "react-native-progress": "^4.0.3" but it's still not work.

Any new update on this, try latest version "@react-native-community/art": "^1.1.2" and "react-native-progress": "^4.0.3" but it's still not work.

Sorry, I miss do the linking on Android for react-native-art, for those who getting this issue just follow these steps to link on android: https://github.com/react-native-community/art

I have been upgraded "react-native-progress": "4.0.3",and "@react-native-community/art": "1.2.0", this issue was resolved

Same problem guys, I have tried all the solutions updating to latest versions and also downgrading to previous versions but not able to fix this.
Is this issue solved using react-native link?
I am currently using expo so that's the only thing i have not tried yet.

@sandeepsinghs thanks for the solution
It works for me

If you are on expo version 36 this wont work

problms with PieChart. help me please

this is a bug for react native. My ReactNative version is 0.61.4, the default implementation of ArtShape's property stroke is an array, but the community one is a string!!!!

If you are on expo version 36 this wont work

yes its not working , how can I resolve ?

@mukulramchandani
You might need to eject out of expo or use an other alternative like this one
https://github.com/bartgryszko/react-native-circular-progress

@mukulramchandani
You might need to eject out of expo or use an other alternative like this one
https://github.com/bartgryszko/react-native-circular-progress

Okay. Actually I'm looking to downgrade the expo 35 (current 36) and have ART is not  supported in expo 36. Looking for a way to downgrade it. Thanks for reply btw . :)

any update?
I use
react-native: 0.62.1
"@react-native-community/art": "^1.2.0",
"react-native-progress": "^4.1.0",

"react-native-progress": "3.6.0",

Until my fix gets merged you can use yarn add https://github.com/brewskey/react-native-progress

Until my fix gets merged you can use yarn add https://github.com/brewskey/react-native-progress

Tried and got error trying to load two version of same view art/surface..

Until my fix gets merged you can use yarn add https://github.com/brewskey/react-native-progress

Tried and got error trying to load two version of same view art/surface..

What was the actual error? It sounds like an issue with linking. You may need to delete the node_modules folder and delete any Android studio generated files.

Until my fix gets merged you can use yarn add https://github.com/brewskey/react-native-progress

Tried and got error trying to load two version of same view art/surface..

What was the actual error? It sounds like an issue with linking. You may need to delete the node_modules folder and delete any Android studio generated files.

Did a clean build - tired of fooling with it. Using https://github.com/RobertFOConnor/react-native-progress-wheel instead.
Good luck!

Seems like package.json is somehow used when compiling the app:
The react-native-progress already has a dependancy for<EMAIL_ADDRESS>(which in my case was already resolved to version 1.2.0). If I then added "@react-native-community/art": "1.2.0" to my package.json, I didn't get this crash again. The diff from yarn.lock looked like this:
...
-"<EMAIL_ADDRESS>+"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>   version "1.2.0"
   resolved<EMAIL_ADDRESS>   integrity sha512-a+ZcRGl/BzLa89yi33Mbn5SHavsEXqKUMdbfLf3U8MDLElndPqUetoJyGkv63+BcPO49UMWiQRP1YUz6/zfJ+A==
...

AKA nothing has changed!
Just for the hell of it, I removed a lot of stuff from dependancies in package.json and I immediately started getting interesting issues during compile time (react-native run-android). I don't have the knowledge of how package.json is included in the compile process, but I hope  it will help the developers here to resolve this issue for others out of the box.

Additonal,you should change the source code of @react-native-community/art/lib/Shape.js. And use the code "stroke={extractBrush(props.stroke)}" at line #64 which has solved my problem.

Additonal,you should change the source code of @react-native-community/art/lib/Shape.js. And use the code "stroke={extractBrush(props.stroke)}" at line #64 which has solved my problem.

Love you.  Hope the author of @react-native-community/art will fix the issue.

Additonal,you should change the source code of @react-native-community/art/lib/Shape.js. And use the code "stroke={extractBrush(props.stroke)}" at line #64 which has solved my problem.

But I found the prop stroke of NativeShape need is [R, G, B, A]. Not the function extractBrush give [SOLID_COLOR, R, G, B, A]. So I keep Shape.js the same, but modify @react-native-community/art/lib/helpers.js function extractColor.
export function extractColor(color?: ColorType) {
    if (color == null) {
        return null;
    }
    const c = new Color(color);
    return [c.red / 255, c.green / 255, c.blue / 255, c.alpha];
    //return toHex(new Color(color));
}

RN 0.63.2
react-native-progress 4.1.2
@react-native-community/art 1.2.0
Android
^ That's working for me although I did need to manually install react-native-community/art

The above wording can temporarily solve the problem, if you do not use the stroke attribute。And if you want solve the problem completely,you have to introduce "react-native-community/art" component, the most important thing you shouldn't forget is adding code "new ARTPackage()" to MainApplication which can cause 'updating property stroke problem'.

I fixed it by linking, although I have latest React version:
react-native link @react-native-community/art

Additonal,you should change the source code of @react-native-community/art/lib/Shape.js. And use the code "stroke={extractBrush(props.stroke)}" at line #64 which has solved my problem.

After rubbing my back on hot tar road from the last 2 days this gives me a feeling of ice. Thank you so much.

Additonal,you should change the source code of @react-native-community/art/lib/Shape.js. And use the code "stroke={extractBrush(props.stroke)}" at line #64 which has solved my problem.

After rubbing my back on hot tar road from the last 2 days this gives me a feeling of ice. Thank you so much.

Yeah.. I've had a fix out for a long time now but they won't merge for some reason.
If you run:
yarn add https://github.com/Brewskey/art

It should apply the patch that @dwyanelin mentioned.

I'm on Expo SDK 40 and spent a couple hours trying the following with various errors or issues:

yarn add @react-native-community/art; yarn add react-native-progress
yarn add https://github.com/Brewskey/art; yarn add https://github.com/Brewskey/react-native-progress
yarn add<EMAIL_ADDRESS>yarn add https://github.com/RobertFOConnor/react-native-progress-wheel

I finally ended up liking react-native-semi-circle-progress with yarn add https://github.com/pajicf/react-native-semi-circle-progress even though it's not even published in npmjs and hasn't been updated in a while but it's simple and works great with nice animation. https://github.com/bartgryszko/react-native-circular-progress also looks promising.

Any update on this? Cant make it work thanks to the same error of ReadableNativeArray cannot be cast to java.lang.String

Any update on this? Cant make it work thanks to the same error of ReadableNativeArray cannot be cast to java.lang.String

@Sp3ctreZero I solved this problem by adding java files to
<EMAIL_ADDRESS>and more...
I found the java files in the repo... But it was not present in the installed node module folder in my project...
So, I copied it and my problem was solved

Need to update react-native-svg, if you have version 6. of react-native-svg will now work, with 12. works fine.

I'm using "react": "18.0.0", "react-native": "0.69.5" and had to downgrade from version 13 to npm i<EMAIL_ADDRESS>and that fixed this problem.


Line numbers for invalid files are incorrect

What happened?
Running devspace print with an invalid file gives incorrect line numbers.
> devspace print
fatal error loading config: yaml: unmarshal errors:
  line 2: cannot unmarshal an array into map[string]*latest.CommandConfig (line 2: - command: |)
  line 199: cannot unmarshal an array into map[string]*latest.DependencyConfig (line 199: - name: deps)
  line 209: cannot unmarshal an array into map[string]*latest.DeploymentConfig (line 209: - helm:)
  line 233: field disabled not found in type latest.DevPod (line 233: disabled: true)
  line 235: cannot unmarshal an array into latest.DevPod (line 235: - url: http://fake:4001)
  line 237: cannot unmarshal an array into latest.DevPod (line 237: - forward:)
  line 251: cannot unmarshal an array into latest.DevPod (line 251: - containerName: rails)
  line 370: field build not found in type latest.Image (line 370: build:)

What did you expect to happen instead?
The line numbers to match with the file on disk
How can we reproduce the bug? (as minimally and precisely as possible)
My devspace.yaml:
version: v2beta1
name: fake
command:
 - name: foo
   command: env

Local Environment:

DevSpace Version: 6.0.0
Operating System: mac
ARCH of the OS: ARM64

/kind bug

@ethankhall thanks for the issue! Unfortunately we cannot preserve the ordering of the keys when the DevSpace yaml is converted, but we'll print the parsed config including line numbers alongside the error in future which should make it a lot easier to see the problematic fields!


how to set GPU

I can't run the train process with GPU ? who to set the training process on GPU?

sorry, I just to ask which file to set GPU?


Add ci-checks

Change-type: patch
Signed-off-by: Giovanni Garufi<EMAIL_ADDRESS>

Looks like the scripts added here are all missing the copyright header that all the scripts in https://github.com/balena-io/scripts/tree/master/shared have?


Decrease NPM package size

Is your feature request related to a problem? Please describe.
The NPM package size is extremely large and impacts frontend performance.
Describe the solution you'd like
A smaller NPM package
Additional context
https://bundlephobia.com/package/<EMAIL_ADDRESS>

You're looking at the size of the wallets package, which includes all wallets and their dependencies. Dapps only add a few of these practice, and the package supports tree shaking.
Have you tried using this in an application and seeing how large it actually is?

Related: https://github.com/solana-labs/wallet-adapter/issues/69


Add an slide near the end, about the reasons for some signals/features

There is space for that in final remarks

Repeat: TRANSFERS are initiated by M, finished by S, and CAN'T BE CANCELED!!!


Fix:  ast-offset fix

fix #1

hi @g-plane , the last pr commit history is pretty messy, so I reopen here, this pull request use no any and only one cast https://github.com/swc-project/swc-playground/pull/9/files#diff-39cc19ac7b95ec6821d23f87ff94218f89b639e42d335fa5d17e09cb2cf404fcR74 which is necessary

Identifiers must follow camel case convention.
Don't use any.
Those imported and not used as values must be marked as "type-only import".

sorry about that , recently i write rust a lot, hhhh.


ruby prerequisite ?

Just trying to use bosh-init on a new vm, following bosh-init install step.
Seem to require ruby?
Command 'deploy' failed:
Installing CPI:
Rendering and uploading Jobs:
Rendering job templates for installation:
Rendering templates for job 'cpi/c2e7587fc42a085d406e63ac23fb0de84391809a':
Rendering template src: application.yml.erb, dst: config/application.yml:
Rendering template src: /root/work/.bosh_init/installations/cad807cd-9518-4866-5c74-a7f8406c5659/tmp/bosh-init-release727818083/extracted_jobs/cpi/templates/application.yml.erb, dst: /root/work/.bosh_init/installations/cad807cd-9518-4866-5c74-a7f8406c5659/tmp/rendered-jobs136182778/config/application.yml:
Running ruby to render templates:
Starting command ruby /root/work/.bosh_init/installations/cad807cd-9518-4866-5c74-a7f8406c5659/tmp/erb-renderer703006993/erb-render.rb /root/work/.bosh_init/installations/cad807cd-9518-4866-5c74-a7f8406c5659/tmp/erb-renderer703006993/erb-context.json /root/work/.bosh_init/installations/cad807cd-9518-4866-5c74-a7f8406c5659/tmp/bosh-init-release727818083/extracted_jobs/cpi/templates/application.yml.erb /root/work/.bosh_init/installations/cad807cd-9518-4866-5c74-a7f8406c5659/tmp/rendered-jobs136182778/config/application.yml:
exec: "ruby": executable file not found in $PATH

Yup, currently needs any ruby executable to build some ERB templates. Which OS are you using? Typically some ruby is available.

ubuntu 14, just installed ruby it from apt repo, works like a charm. Just suggesting adding it to the prerequisites of bosh-init.

Updated docs: http://bosh.io/docs/install-bosh-init.html. Thanks!


Bug: form_upload second parameter VALUE is not used in source code

This is the code in form_helper
function form_upload($data = '', string $value = '', $extra = ''): string
{
	$defaults                = [
		'type' => 'file',
		'name' => '',
	];
	is_array($data) || $data = ['name' => $data];
	$data['type']            = 'file';

	return '<input ' . parse_form_attributes($data, $defaults) . stringify_attributes($extra) . " />\n";
}

Surely we see that the $value is not used inside this function. from the source code

And because of this set_value for files does not work.
I am trying to upload a file and when i have form errors from validation rules
the upload file gets removed.
 So much work i have to do with form_upload and set_value dude.

No one ? 🗡
Please someone review this. This is very important to me.
I am eager to show you the code how i resolve this very weird but i got up some very big problems with it.
Someone please comment here about this issue Thanks.

I don't think this is possible. This is blocked on a browser level. Maybe there is some hacky way to accomplish this, but this would be a security issue.
The valid question is why do we have $value variable there, but I guess it is because of the direct import from CI3.

i have a way to save the file if was valid file anyways. and store it but i don't know how to implement this in the firm helper.


Add compose support of attachable in networks

- What I did
This fix tries to address the issue raised in #29975 where it was not possible to specify attachable flag for networks in compose format.
- How I did it
This fix adds the support of attachable for compose v3.1 format.
- How to verify it
Additiona unit tests have been updated and added.
- Description for the changelog
Add support of attachable flag for networks in compose 3.1 format.
- A picture of a cute animal (not mandatory but encouraged)

This fix fixes #29975.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

ping @dnephin @shin- PTAL

What happens when you run  docker stack rm foo,  if there is a non-stack container attached to the stack network?

cc @shin- for Compose file format changes that may impact docker-compose.

What happens when you run docker stack rm foo, if there is a non-stack container attached to the stack network?

@dnephin ^^?

I have no idea. Whatever happens when you do a network rm in that scenario. I guess it either fails or the container is forcefully removed by the engine?

I tried it out:
$ docker network rm testfoo
Error response from daemon: rpc error: code = 9 desc = network gwsru0tunvf489g8nv3tan64j is in use by task 2w4j8yeiosez4mw90ana91l3y


Change logs are not valid markdown

Issue
Right now we have the following change log file which lists the changes with a new line as separator:
change1
change2

Which, is an invalid markdown list.
Proposed Solution
Maybe we could or should use a item list instead, as below.
- change1
- change2

Right, we should change that as you propose 👍


Test current version before releasing

I'm not sure if all use cases were properly tested. It would be cool if someone volunteers for testing them before #281 , as the tool is downloaded and used by quite some folks.

[x] 2D labels
[x] 3D labels
[x] 2D + time
[x] 3D + time
[x] points
[x] surface
[x] points + time ?  (bf09d794596de073a993f5e8c942782bb1a42ff3)
[x] surface + time ?  (9cf67049d4222163e2f9c08f4c46778eddb52729)

For the last tests, example data might be necessary (see also #301 )
Thanks!

I had made some progress on this issue but one Issue is that the napari-skimage-regionprops function show_table is incompatible with surface layers currently. I have made a suggestion to fix it as a PR but until this gets merged and released we will need to either keep the newest cluster plotter release on hold or find a workaround for showing the table..

@zoccoler Have you tested the new features manually yet? I don't think the plugin will work for the surface layer as expected because as soon as you perform dimension reduction or clustering on the surface layer the show_table function will erase the surface layer data.... I don't know if you would prefer just to do a workaround which I could get started on or if we should wait until the suggested PR is merged in napari-skimage-regionprops?

Hi @Cryaaa ,
I tried to fix that PR today, but I did not try that branch with the napari-clusters-plotter.
If you have some time, could you test if it would work?


chore: remove lib mtop

Codecov Report

Merging #174 (cc0b2e6) into master (c9b3bf5) will decrease coverage by 0.20%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   78.47%   78.26%   -0.21%
==========================================
  Files          29       29
  Lines        1059     1063       +4
  Branches      192      204      +12
==========================================
+ Hits          831      832       +1
  Misses        228      228
- Partials        0        3       +3

Impacted Files
Coverage Δ

packages/generate-project/src/formatProject.ts
73.68% <25.00%> (-2.71%)
:arrow_down:

packages/generate-project/src/checkEmpty.ts
25.00% <0.00%> (ø)

packages/iceworks-cli/src/command/config/index.ts
93.33% <0.00%> (ø)

...iceworks-cli/src/command/init/addSingleMaterial.ts
38.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b3bf5...cc0b2e6. Read the comment docs.


cannot load your MiniCPM-V-2.0 model file

Due to the issue of transformers, with a dot in model name may encounter this error:
ModuleNotFoundError: No module named 'transformers_modules.MiniCPM-V-2'
Add '/' to the end of local model path should solve it:
model_path=/my/local/path/MiniCPM-V-2.0/

Thank you.It works.


Nürnberg Pass - replace Link

Is your feature request related to a problem? Please describe.
Daniel aksed me to foward you this e-mail from the city of Nuremberg as an issue to replace the link mentioned here.

Additional context
Add any other context or screenshots about the feature request here.

I will going to ask for time schedule/urgency of the replacement...

@dkehne i think the links is already in use?
https://beantragen.nuernberg.sozialpass.app -> forward to the correct link

the link is already the correct one


Province Names and Geography

Due to the recent province changes, some of them might need a new name, because the cities they are named after are probably in another province now. Also the name position needs to be adjusted. See Issue #526.

will make it as part of the general State/region redesign #532

This issue will also include the (continuous huge  work of ) correcting province borders to correlate with real world provinces. Will start with a couple of bigger countries, and then create a new issue post 1.08.

some issues has reappeared

rural provinces gets emptied on pops.
blank space" in Siberia.

some provinces are now awfully big, getting the warscore takes in some cases very long, especially Italy and Finland, maybe split them further up?

Yes that is the long term plan to add additional provinces (lots of them).


Cloudflare

How to use cloudflare with azure container apps.

How to use cloudflare with azure container apps.

Did you ever get this working? I've tried origin certs (ACA rejects it) and custom domains with valid certs but no joy (SSL handshake error).

Check this blog post:
https://medium.com/@gjoshevski/azure-container-apps-aca-and-cloudflare-e63e16ae1c64


make fit method of rv_continuous pickleable

Allows fit methods decorated with _call_super_mom to be pickleable.

Reference issue

Closes #14346
What does this implement/fix?

Makes rv_continuous.fit methods decorated with _call_super_mom pickleable
Additional information

The more thorough way to do this is to use functools.wraps()

@rkern thank you for pointing this out, I updated the PR

Can you add some regression tests to demonstrate the fix?

@rkern added, let me know if this looks right - this is my first experience with the scipy codebase

No idea why the test fails - the code change itself passed all tests, so it must be my change to the check_pickling function. But the build fails for check_rvs_broadcast which is completely unrelated to what I changed. I think I need help here.

There are quite a few "fails fitting" skips, maybe they will help: https://github.com/scipy/scipy/blob/master/scipy/stats/tests/test_continuous_basic.py#L45

I would not try to run the fit methods. I think just pickling and unpickling should be sufficient to demonstrate the bug that you fixed (run the tests without the fix to verify that the new tests fail). The fitting procedures are based on nonlinear optimization and might not work for all possible random inputs.

I think this PR is be ready - the issue with method pickling is fixed and tested for. @rkern thank you for your help and advice on this issue

All green, merging. Thanks @georgebv @rkern


Clarify AppConfiguration properties for Spring Cloud Azure

Sync codes from https://github.com/Azure/azure-sdk-for-java/pull/33567

API change check
API changes are not detected in this pull request.


[BUG] JSON files is not being reloaded after changes.

Setup multiple .json files under plugins/CustomCommands/Commands
Editing exists JSON files => Plugin should auto-reload, but it does not reload at all.
So I need to run css_plugins restart CustomCommands from each editing on files, whenever files are shared with 10-15 CS2 servers.

Yes this will be the case.

@HerrMagiic Sounds good. ;) I hope the plugin will be updated ^

@HerrMagiic Sounds good. ;) I hope the plugin will be updated ^

I miss spelled my sentence. Yes you will need to reload the plugin on every server. Maybe I will implement something like this in the feature but I have zero time and no motivation to add this feature right now

with the new update you can create your own plugin reload command.
Here an example:
{
        "Title": "reload",
        "Description": "reload",
        "Command": "csreload",
        "Message": "reloading...",
        "ServerCommands": [
            "css_plugins reload CustomCommands"
        ],
        "PrintTo": 0
    }

You should also add Permissions to the command so only allowed player can use it.
https://github.com/HerrMagiic/CSS-CreateCustomCommands/blob/dev/Examples/Permissions.md


fix(dependencies): 💫 update crates

Description
Update dependencies.
Type of change

[X] Dependency update

How Has This Been Tested?

[X] cargo test run with all tests passing

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

Current dependencies on/for this PR:

main

PR #1   👈

This comment was auto-generated by Graphite.

@rodneylab started a stack merge that includes this pull request via Graphite.

@rodneylab merged this pull request with Graphite.