Sunshine Improvement/Suggestion?

With Sunshine you are able to add custom commands, so instead of running the script in the background all the time is it possible to add it as a command to Sunshine so when you connect it starts the script and is only active during that session?
Thank you!

This task can be accomplished with relative ease, provided one has a basic understanding of computer paths. However, we recognize that not all users may have this knowledge, and as a result, some could find it challenging and potentially struggle with completing the task. To avoid an influx of support questions on Discord regarding setup, we've opted not to include this feature in the base script.
If you are comfortable with using commands on a computer, you can review the code on this branch:
https://github.com/Nonary/ResolutionAutomation/tree/precommand_version
In a nutshell, this version modifies the original script so that it breaks after the stream ends and then launches a new PowerShell process in the background. Since Sunshine initiates pre-commands in the system32 folder, please make sure to input the full path of the script in the Activate.ps1 file, relatives paths would not work.

Once https://github.com/LizardByte/Sunshine/pull/1123 is merged into Sunshine I will plan on adding this feature to this script.
While elevation is not required, it fixes some other issues that would make this script easier to integrate with.

@Misl3d I have a pre-release version of this available for download and testing if you're interested.
https://github.com/Nonary/ResolutionAutomation/releases/tag/precommand_beta

Nice! I'll get it and mess around with it asap. Thank you!

Hey so I got to play around with the new script a little bit. And just things I noticed:
It worked in changing the resolution when connecting with moonlight but once I disconnected it wouldn't change back.
Running the function script in console I saw it was grabbing my second monitor settings.
My display settings were set where my primary monitor was identified as display 2. I fixed it by flipping the cables around.
This let the script grab the correct monitor resolution. So maybe a config or something to specify which monitor the resolution should grab from.
Even though it was grabbing the correct settings the resolution, it wouldn't change back. I ran out of time so I wasn't able mess around with it more but I thought I should just mention the display identifier issue as it will probably come up in the future.
I read the AI conversation and it's is crazy how well it works.
Thank you :)

After a reboot the script began to pick up my secondary settings again, after trying to find a way to get powershell to output display settings of a specific monitor (without external programs), I failed to do so. So as a band aid, that I actually got working:
I created a display_settings.cfg file in the install folder, with the contents being my default monitor settings:
Width: 1920
Height: 1080
Freq: 144

Then I just replaced the OnStreamEnd Function with
function OnStreamEnd() {
    $content = Get-Content -Path "$path\display_settings.cfg"

    $width = [int]($content | Select-String -Pattern "Width: (\d+)").Matches.Groups[1].Value
    $height = [int]($content | Select-String -Pattern "Height: (\d+)").Matches.Groups[1].Value
    $freq = [int]($content | Select-String -Pattern "Freq: (\d+)").Matches.Groups[1].Value

	Set-ScreenResolution -Width $width -Height $height -Freq $freq
    break;

}

Obviously, this adds another manual setup step but it's a one and done, especially since most people's monitor settings will remain static. So maybe we are overthinking things and setting the client resolution should be dynamic, but reverting can be static?
So maybe It would be OK to have 2 scripts?
DO: Read Sunshine logs and change resolution to client resolution
UNDO: Read cfg revert to host resolution

Hey so I got to play around with the new script a little bit. And just things I noticed:
It worked in changing the resolution when connecting with moonlight but once I disconnected it wouldn't change back.
Running the function script in console I saw it was grabbing my second monitor settings. My display settings were set where my primary monitor was identified as display 2. I fixed it by flipping the cables around.
This let the script grab the correct monitor resolution. So maybe a config or something to specify which monitor the resolution should grab from.
Even though it was grabbing the correct settings the resolution, it wouldn't change back. I ran out of time so I wasn't able mess around with it more but I thought I should just mention the display identifier issue as it will probably come up in the future.
I read the AI conversation and it's is crazy how well it works.
Thank you :)

I have fixed the issues with it not reverting back in the latest release (the file date is newer than the published tag date)

I tried the latest file and it worked in reverting resolution except for refresh rate, and it looks like its a limit of windows powershell.
I have 2 monitors, the primary being 144hz and second being 60hz, running Get-CimInstance -ClassName Win32_videocontroller CurrentRefreshRate outputs 60, I think windows is listing the refresh rate available to all screens.
So when reverting back to host resolution it will only revert to 60hz and not the 144hz I had it set to.

Ye

I tried the latest file and it worked in reverting resolution except for refresh rate, and it looks like its a limit of windows powershell.
I have 2 monitors, the primary being 144hz and second being 60hz, running Get-CimInstance -ClassName Win32_videocontroller CurrentRefreshRate outputs 60, I think windows is listing the refresh rate available to all screens.
So when reverting back to host resolution it will only revert to 60hz and not the 144hz I had it set to.

Yeah this is a problem I've been trying to figure out how to get around. The vast majority of users will have their primary monitor as position 1 instead of 2. And I can't seem to figure out how to use the Windows API to get information such as which is the users primary display; at least not without having the script run as admin which is what I am trying to avoid.

I have no idea what I am doing inpowershell but here's what I got, I found this : Reddit Post w/ pastebin in comments
From the pastebin script I took out the refresh rate grabber and put in ResolutionMatcher.ps1 by replacing the $hostresolution line with
Add-Type -AssemblyName System.Windows.Forms
$primaryScreen = [System.Windows.Forms.Screen]::PrimaryScreen
$devMode = [Display+DEVMODE]::new()

[Display]::EnumDisplaySettings($primaryScreen.DeviceName,-1,[ref]$devMode)

$hostResolutions = New-Object -TypeName PSObject
$hostResolutions | Add-Member -MemberType NoteProperty -Name CurrentHorizontalResolution -Value $devMode.dmPelsWidth
$hostResolutions | Add-Member -MemberType NoteProperty -Name CurrentVerticalResolution -Value $devMode.dmPelsHeight
$hostResolutions | Add-Member -MemberType NoteProperty -Name CurrentRefreshRate -Value $devMode.dmDisplayFrequency

It's messier since idk what I am doing but It worked, it changed my resolution and refresh rate correctly :)
No admin too!

It worked until it didn't, Idk what changed but it stopped working and began outputting 0 for settings..

I have no idea what I am doing inpowershell but here's what I got, I found this : Reddit Post w/ pastebin in comments
From the pastebin script I took out the refresh rate grabber and put in ResolutionMatcher.ps1 by replacing the $hostresolution line with
Add-Type -AssemblyName System.Windows.Forms
$primaryScreen = [System.Windows.Forms.Screen]::PrimaryScreen
$devMode = [Display+DEVMODE]::new()

[Display]::EnumDisplaySettings($primaryScreen.DeviceName,-1,[ref]$devMode)

$hostResolutions = New-Object -TypeName PSObject
$hostResolutions | Add-Member -MemberType NoteProperty -Name CurrentHorizontalResolution -Value $devMode.dmPelsWidth
$hostResolutions | Add-Member -MemberType NoteProperty -Name CurrentVerticalResolution -Value $devMode.dmPelsHeight
$hostResolutions | Add-Member -MemberType NoteProperty -Name CurrentRefreshRate -Value $devMode.dmDisplayFrequency

It's messier since idk what I am doing but It worked, it changed my resolution and refresh rate correctly :) No admin too!

Windows Forms is an option, but the issue with using DisplayName is that it can actually change once resolution is applied. It's a really frustrating bug in the Windows API. So I can use that but will have to figure out a method that works in the bounds of the bugged Windows API.

@Misl3d I believe I have fixed this issue in the latest release update.

RIP there was a bug with it. It's fixed now.
Also I have refactored the script to no longer rely on the $path being set, so now going forward just simply replacing the script files is enough to update them, no need to run the install each time.

Nice! I updated and it worked as except both resolution and refresh rate reverted to the correct original values :)

Closing out this issue as it is now implemented as a new release now.
https://github.com/Nonary/ResolutionAutomation/releases/tag/precommand


Add CodePen

Added CodePen.io - their team is 100% remote.  In CodePen Radio episode 77 they delve into how it benefits them: https://blog.codepen.io/2016/02/16/077-remote/

👏 Nice one @specious!


add cli support for loading .env file

Adding .env file support helps to manage a list of TRANSFORMATIONS_** environment variables:

without the need to add them to your environment before
or explicit usage of cli-parameters

Sidenote:
The Cognite python-extractor-utils project (which is a dependency of the transformation-cli) has an open PR#131 about this too, but even if this is added it will not support transformations-cli.
I'll add a PR using python-dotenv next.

opened PR #45


CTFd not sending mails?

Although there is a mail setup configured in the CTFd config, it is not sendign mails (for example for password resets).
We need this,
at least for password resets,
and if we want to limit registrations to certain mail addresses (see #12), we need to enable email address verification.

Current debugging status:
Gunicorn logs this:
[2017-09-18 15:10:57 +0000] [11] [CRITICAL] WORKER TIMEOUT (pid:21)
[2017-09-18 15:10:57 +0000] [21] [INFO] Worker exiting (pid: 21)
[2017-09-18 15:10:57 +0000] [37] [INFO] Booting worker with pid: 37

Probably fixed, at least the timeout is gone.


fix(no-extranaeous-dependencies): check if node.parent.importKind is 'type'

Thanks for your work on this plugin! :heart:
This PR extends no-extranaeous-dependencies' check for Flow type imports to also work with TypeScript. This should help with https://github.com/benmosher/eslint-plugin-import/issues/903#issuecomment-549942374.

Coverage decreased (-0.3%) to 97.502% when pulling df1f80fb007e8ec2909bf3502341b3810b35eac3 on taye:fix-allow-extranaeous-type-import into 54eb51b873697e006287d2a19c7b906ab480a04d on benmosher:master.

Coverage decreased (-0.3%) to 97.502% when pulling df1f80fb007e8ec2909bf3502341b3810b35eac3 on taye:fix-allow-extranaeous-type-import into 54eb51b873697e006287d2a19c7b906ab480a04d on benmosher:master.

Coverage decreased (-0.3%) to 97.502% when pulling df1f80fb007e8ec2909bf3502341b3810b35eac3 on taye:fix-allow-extranaeous-type-import into 54eb51b873697e006287d2a19c7b906ab480a04d on benmosher:master.

Coverage decreased (-0.3%) to 97.502% when pulling df1f80fb007e8ec2909bf3502341b3810b35eac3 on taye:fix-allow-extranaeous-type-import into 54eb51b873697e006287d2a19c7b906ab480a04d on benmosher:master.

Coverage decreased (-0.3%) to 97.502% when pulling df1f80fb007e8ec2909bf3502341b3810b35eac3 on taye:fix-allow-extranaeous-type-import into 54eb51b873697e006287d2a19c7b906ab480a04d on benmosher:master.

This seems to be a duplicate of #1820.

Thanks!


Expect toEqual error message lacking info

Describe the bug
Jest expect has quite good error messages, switching some tests with nested keys resulted in error messages from vitest where you don't know what the underlying error is.
Reproduction
test('JSON', () => {
  const input = {
    foo: 'hello',
    bar: 'world',
    nested: {
      key: 'with a difference',
    },
  };

  expect(input).toEqual({
    foo: 'hello',
    bar: 'world',
    nested: {
      key: 'difference',
    },
  });
});

vitest
https://stackblitz.com/edit/node-k4gpvn?file=test%2Fbasic.test.ts&view=editor
jest
https://stackblitz.com/edit/jest-example-5mfqv2?file=sum.test.js&view=editor&terminal=test

vs

System Info
npx envinfo --system --npmPackages '{vitest,vite,@vitejs/*}' --binaries --browsers                                                                                9s 16:01:22

  System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1
    Memory: 98.70 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.2.0 - /opt/homebrew/bin/node
    Yarn: 1.22.15 - /opt/homebrew/bin/yarn
    npm: 8.1.4 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 96.0.4664.110
    Edge: 96.0.1054.62
    Firefox: 95.0.2
    Safari: 15.2
  npmPackages:
    vite: ^2.7.4 => 2.7.4
    vitest: ^0.0.103 => 0.0.103

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This should be fixed in the next version

@antfu @async maybe we should check the length of serialized Objects and if they are longer than a threshold pretty print with proper identation? So for big objects, we get an output like jest and for small one or two props objects, we keep it compact?

This should be fixed in the next version

@antfu @async maybe we should check the length of serialized Objects and if they are longer than a threshold pretty print with proper identation? So for big objects, we get an output like jest and for small one or two props objects, we keep it compact?

I personally would prefer jest's output with only one object and +/- signs instead of one lines like this
Even if the object has only one property
I think compat output is only needed for primitives

Should be fixed


⚠ Visual-Crew_Builder has degraded performance

In 655cda5, Visual-Crew_Builder (https://visual-crew-builder.ai) experienced degraded performance:

HTTP code: 200
Response time: 1424 ms

Resolved: Visual-Crew_Builder performance has improved in c611008 after 7 minutes.


MM-17425/MM-17683 Disable Send button when sending post

In addition to disabling the send button while sending a post, this also fixes it so that the post textbox is cleared after using a slash command and removes an unused warning modal.
I wasn't able to add unit tests for this.state.sendingMessage because the control flow after pressing the send button is incredibly complicated.
Note: MM-17425 is scheduled for 1.22, but since there are a large number of changes to this component on master, I'll be submitting a separate PR for it in 1.22 instead of trying to cherry-pick it.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17425
https://mattermost.atlassian.net/browse/MM-17683
Checklist

Includes text changes and localization file updates

Device Information
This PR was tested on: iOS Simulator (iPhone X, iOS 12.1), Android Emulator (Nexus 5X, Android 9)

@hmhealey build fails

QA can test this one after it's merged rather than on the PR. Removing QA Review label.


cannot run app

On Windows 10, when I run "npm start", there's error message as below.
Did I miss something ?
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "start"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: tsc && concurrently "tsc -w" "lite-server"
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'tsc && concurrently "tsc -w" "lite-server" '.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc && concurrently "tsc -w" "lite-server"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-quickstart
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\USER\Desktop\workspace\angular60\npm-debug.log

Did you run "npm install"?

i am having the similar error above. Yes i did run npm install

Open 2 instances of cmd at your angular quickstart directory
Window #1
npm run build:watch
then..
Window #2
npm run serve
This worked for me. I was facing the same issue. Found the solution on stackoverflow

Its not working


Check that events exist before adding/removing handlers.

For example, when enableMouseEvents is set, a call is made to this.addEventListener(window, 'contextmenu', ...). This does not exist under the eventNames.touch or eventNames.keyboard, which in turn causes subject.addEventListener to be called with undefined as the event name.
Under a Cordova application, this causes the app to hang as it immediately tries to call .toLowerCase() on an undefined value. I'd assume this could cause issues elsewhere too!
This commit adds a simple check that the event exists before trying to add/remove handlers.

Hi guys,
Any update on this ? I also stuck with the same issue.

The Travis build on master is currently failing, so I'm not sure what's expected from a PR perspective in terms of fixing this. Advice/suggestions welcome - this appears to be an important yet simple fix, so it'd be nice to have it integrated...

LGTM


Fix Eslint rules

Had to disable eslint check, due to some problems with eslint-config-oclif mentioned here: https://github.com/oclif/eslint-config-oclif/issues/93 hopefully it will be fixed, or i will create my own eslint rules, but would be great to use one from oclif

closing, not using Oclif anymore, instead went for in version 3.0.0 : https://github.com/sindresorhus/meow


Added figureS4--cytokine correlaion heatmaps

Closes #170

This should swap to the log-transformed Pearson correlation. Doesn't Pearson assume data is normally-distributed? Is that a safe assumption with cytokine data?

This is a common misconception (I even got it on a grant review). Pearson correlation is a measure of linear correlation, it does not assume normality.

Whoops--small bug. I setup correlations so that we wouldn't correlate a cytokine with itself. Just need to modify tick labels slightly.

Great! Thanks.


Mat error on Mac

Got an exception in viewer_display.py  line 290
            if self.__mat_images and diff_aspect > self.__mat_images_tol:
                if not pics[1]:
                    im = self.__matter.mat_image((im,))

WARNING:viewer_display.ViewerDisplay:Can't create tex from file: "/Users/herbe/Pictures/Wallpapers/Berlin.jpg" or "None"
WARNING:viewer_display.ViewerDisplay:Cause: array() takes 1 positional argument but 2 were given
Going deeper I see that:
Exception in mat_image.py line 506.
def run(self, image, start_clusters=None):
        image = image.copy()
        image.thumbnail(self.size)
        im = np.array(image, dtype=np.float)[:,:,:3]

'np.float is a deprecated alias for the builtin float. To silence this warning, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.\nDeprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations'
numpy version 1.21 is installed on Mac. On my raspberry lumpy version is 1.16.2.

@helgeerbe, thanks for finding that. We should change it to np.array(image, dtype=float) as suggested. Also on line 519.
There only seems to be one other place I've used np.float in pi3d (TextBlock) so patched that in develop branch for the moment.
PS I really hate the vagueness of C leaving the choice up to the operating system or compiler or whatever. In Rust you specify f32, f64, i32 etc. that way you always get what you expect!

pushed change here https://github.com/helgeerbe/picframe/commit/cb4d8c1cd36b6d674ace91e77544f095ac79a42f

Thanks @paddywwoof, but this doesn't solve the root cause.
 im = np.array(image, dtype=float)[:,:,:3]still throwing an exception.
Image.py line 546 raises AttributeError.
    def __getattr__(self, name):
        if name == "category":
            warnings.warn(
                "Image categories are deprecated and will be removed in Pillow 10 "
                "(2023-01-02). Use is_animated instead.",
                DeprecationWarning,
                stacklevel=2,
            )
            return self._category
        raise AttributeError(name)

That looks like an error from pillow what do you get if you open a python terminal and
from PIL import Image
im = Image.open('/Users/herbe/Pictures/Wallpapers/Berlin.jpg')

my version of pillow is 8.3.1

Now it works. I can't tell what happened. I uninstalled PIL and installed the latest version again. Running from command line everything works. In visual studio code I had to select Python 3.9.6 which is located in /opt/homebrew/bin. Using python3.82 which is located at /usr/bin/phython3 can't find PIL.
So it seems to be maybe a problem with my  environment. Using libs and interpreter from /opt/homebrew/... works now.

Guess we can close this issue.

Sure. Well done for sorting it out. Python is still a bit of a minefield with different versions (quite apart from 2 v 3) existing in different places and different modules being installed in /home/user/.local as well as in the root of the system.


Hits shown for empty search

I'm using react-instantsearch on react native. When I first open the search screen, the connected searchBox is empty, but my hits ListView is populated with results.

Hi @smkhalsa to solve this you can do:
import {Hits} from 'react-instantsearch/dom';
import {connectSearchBox} from 'react-instantsearch/connectors';

const Results = connectSearchBox(
  ({currentRefinement}) =>
  currentRefinement
  ? <Hits />
  : null
);

What it does is looking at the current query before trying to display Hits.
It's not perfect because it will still trigger a search, @mthuret any idea?

The [Conditional Display trick] (https://community.algolia.com/instantsearch.js/react/guide/Conditional_display.html#displaying-content-when-the-query-is-empty) can also be used. But it will not solve the extra search issue.

In the context of an app, you can decide not to display the whole instantsearch until you reach a specific route / state of the app. Would you like to display the search bar even though you are not searching? This first request is based on our experience of search, it initiates the conversation with the user and displays the items based on your metrics (custom ranking). This is usually recommended to do that @smkhalsa

@smkhalsa If you still need help on this, please reopen the issue.

There really should be an option to NOT have default hits on an empty search.
Using the autocomplete search box with searchAsYouType and debounce will always create a flicker of results since the initial hits is always filled. Tried force blanking out the results but the default hits always gets returned.
Or is this a separate issue that I should file?

There's a section on our Conditional Display page that talks about handling empty queries. There are two workarounds for now. We are aware that those are not optimal though.


Path Error on execution

Getting the following error when I try and run the cmd to start. Also how do you run this in the background, how to make it work with pm2?
error: uncaughtException: "path" is not defined: null date=Wed Mar 07 2018 16:05:06 G                    MT-0600 (CST), pid=7529, uid=1000, gid=1000, cwd=/usr/lib/node_modules/cncjs/dist/cnc/app, execPath=/usr/bin/nod                    e, version=v8.9.4, argv=[/usr/bin/node, /usr/bin/cnc, -m, /tablet:/home/pi/cncjs-shopfloor-tablet/src], rss=1291                    91936, heapTotal=102518784, heapUsed=86225476, external=357078, loadavg=[2.05908203125, 1.70556640625, 1.3447265                    625], uptime=1154, trace=[column=19, file=/usr/lib/node_modules/cncjs/dist/cnc/app/index.js, function=new Serial                    Connection, line=2018, method=null, native=false, column=27, file=/usr/lib/node_modules/cncjs/dist/cnc/app/index                    .js, function=new GrblController, line=17181, method=null, native=false, column=34, file=/usr/lib/node_modules/c                    ncjs/dist/cnc/app/index.js, function=null, line=16817, method=null, native=false, column=13, file=events.js, fun                    ction=emitTwo, line=126, method=null, native=false, column=7, file=events.js, function=Socket.emit, line=214, me                    thod=emit, native=false, column=12, file=/usr/lib/node_modules/cncjs/node_modules/socket.io/lib/socket.js, funct                    ion=null, line=503, method=null, native=false, column=7, file=internal/process/next_tick.js, function=_combinedT                    ickCallback, line=131, method=null, native=false, column=9, file=internal/process/next_tick.js, function=process                    ._tickCallback, line=180, method=_tickCallback, native=false], stack=[TypeError: "path" is not defined: null,                         at new SerialConnection (/usr/lib/node_modules/cncjs/dist/cnc/app/index.js:2018:19),     at new GrblController                     (/usr/lib/node_modules/cncjs/dist/cnc/app/index.js:17181:27),     at Socket. (/usr/lib/node_modules/                    cncjs/dist/cnc/app/index.js:16817:34),     at emitTwo (events.js:126:13),     at Socket.emit (events.js:214:7),                         at /usr/lib/node_modules/cncjs/node_modules/socket.io/lib/socket.js:503:12,     at _combinedTickCallback (in                    ternal/process/next_tick.js:131:7),     at process._tickCallback (internal/process/next_tick.js:180:9)]

I'm also getting this error. To start it with pm2 you need to run this:
pm2 start $(which cncjs) -- --port 8000 -m /tablet:/home/pi/cncjs-shopfloor-tablet/src

@MitchBradley I'm running latest versions of CNCjs on Node 8.x LTS on Raspberry PI 3/debian stretch. Cncjs is running in pm2 but this error also happens when started directly using the command in your readme. Any ideas on what is going on here? or alternative instructions to get it working?
Cheers!

I get that error too, but have not seen any bad results from it.
I tried several times to debug it but always got lost in a twisty maze of little passages.  It seems that there is a timer-activated callback in the Socket library that is trying to instantiate a GrblController object automagically, without supplying a path to the serial device.  Perhaps this is happening prior to the time that the GrblController is opened properly with a valid path.  But why that would be happening, I cannot figure out.  Control flow in cncjs is byzantine, and the ultra-dynamic nature of modern Javascript and Node.js makes it very difficult to trace what is happening.

@MitchBradley thanks for quick reply! Yeah I suppose you are right. I was having a problem where it wasn't prompting me to choose the Arduino port before the tablet interface loaded, and then I was stuck. I thought it was related to this, but it's not. :-)
You can probably close this issue then. Thanks!


Support enums defined in C++ code.

This allows listing an enum in an extern "C" block as well as in the shared block.  In this case, we do not emit the C++ declaration of the enum but instead emit static assertions that it has the values that we expect.
Do you know a good way to test the assertions?  The ui tests don't seem to compile the generated C++ files, so I'm not sure how to do it.
I'm also considering refactoring the discriminant generation code somewhere now that it's mostly duplicated in three different places.
Closes #177.

The reason I didn't compute the discriminant during parsing in my original patch was to keep it as close to the source as possible. If you want to change that, we can.

I think the goal of the representation under crate::syntax::Api would be to be useful to the later compiler stages (check.rs, expand.rs + write.rs), not necessarily to be close to the source. That means normalizing all insignificant differences. For example:

Whether the person typed fn f(&self) or fn f(self: &Ident) doesn't matter outside the parser, so those come out of the parser looking exactly the same.

Similarly, whether they typed extern "C" { fn f(); fn g(); } or extern "C" { fn f(); } extern "C" { fn g(); } isn't significant, so those come out of the parser the same.

I would want the same for enum E { A, B } vs enum E { A = 0, B } vs enum E { A, B = 1 } vs enum E { A = 0, B = 1 }. These are only different in ways that only matter to the parser.

That makes sense.  I'll follow up with that tomorrow.


Use parse5's tree adapter directly instead of the current indirection

My understanding of what we currently do, in the htmltodom.js file, is:

We use the htmlparser2 tree adapter built into parse5 to get a particular representation of the nodes. This is done because historically we used to use htmlparser2, so this was an easy transition path.
We then use this function named setChild to convert the htmlparser2 representation into actual jsdom classes

This is roundabout and unnecessary. The setChild function is full of strange hacks around templates, doctypes, and namespaced attributes that would probably be unnecessary if we just implemented a proper jsdom tree adapter for parse5.
We already have half of a tree adapter, in documentAdapter.js, which we use for serialization. We should finish it out and try to use it.
/cc @Sebmaster in case he remembers any different details.

Doing our own mostly works, except for scripts. We'll create an empty script tag, append that, then get the scriptText from parse5 and HTML does not re-execute on changed nodeText of scripts. So we'd have to hack around that and trigger another execution in that case.

Right, I see, and at that point it's tempting to skip to doing things the "right" way with the streaming document.write()-aware version... but that's hard, of course.


Automatic injection of frosch in python interpreter

Either write a script, that hooks itself into the python interpreter so frosch is always executed or find another way to its
auto hooking by simply pip installing frosch

https://github.com/Qix-/better-exceptions/blob/master/better_exceptions_hook.pth this would word, but should used with a ENV var like they did. Not sure if I want automatic hooks at all.


Migrate samples for IotCentral and IotHub

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Fixed missing yosys share directory

Motivate of the pull request

[ ] To address an existing issue. If so, please provide a link to the issue: #421 #429
[ ] Breaking new feature. If so, please describe details in the description part.

Describe the technical details
What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

[ ] VPR
[ ] Tileable routing architecture generator
[ ] OpenFPGA libraries
[ ] FPGA-Verilog
[ ] FPGA-Bitstream
[ ] FPGA-SDC
[ ] FPGA-SPICE
[ ] Flow scripts
[ ] Architecture library
[ ] Cell library
[ ] Documentation
[ ] Regression tests
[ ] Continous Integration (CI) scripts

Impact of the pull request

[ ] Require a change on Quality of Results (QoR)
[ ] Break back-compatibility. If so, please list who may be influenced.

@coolbreeze413 It is very late on my side as well as for @ganeshgore
When CI is green, can you or @tpagarani  click the merge button ?


acorn events --help should indicate that --details works only with -o json/yaml option.

acorn version v0.7.0-alpha1-73-g17e3dd1e+17e3dd1e
There is no difference in output when using "-d"option unless used with "-o" option.
 acorn events -d
SOURCE        NAME                               TYPE                  ACTOR          OBSERVED    DESCRIPTION
app/mytest1   03759ed272ff12eb5f65a4c9ae9a50b2   AppCreate             system:admin   4m55s ago   App acorn/mytest1 created
app/mytest1   9d64a0d430288ec38cf8d590bce81df9   AppImagePullSuccess   acorn-system   4m55s ago   Pulled 143b970d0f86dbd59b1b1754a2d630b9966eacb56fe0e857f40e295e7b33cc40

 % acorn events
SOURCE        NAME                               TYPE                  ACTOR          OBSERVED   DESCRIPTION
app/mytest1   03759ed272ff12eb5f65a4c9ae9a50b2   AppCreate             system:admin   5m6s ago   App acorn/mytest1 created
app/mytest1   9d64a0d430288ec38cf8d590bce81df9   AppImagePullSuccess   acorn-system   5m6s ago   Pulled 143b970d0f86dbd59b1b1754a2d630b9966eacb56fe0e857f40e295e7b33cc40
sangeethahariharan@Sangeethas-MacBook-Pro example %

acorn events --help should indicate that “--details” works only with “-o json/yaml” option.

Tested with acorn version -v0.7.0-59-gfa7ba122+fa7ba122
Following text is provided in acorn events --help
 # Getting Details
  # The 'details' field provides additional information about an event.
  # By default, this field is elided from this command's output, but can be enabled via the '--details' flag.
  # This flag must be used in conjunction with a non-table output format, like '-o=yaml'.
  acorn events --details -o yaml


Make Count Trips at Stops indicate the routes the trips are associated with

"Would be great to see the count trips at stops giving us statistics of what routes serves each stop and how many trips each route has. Say for instance you have 20 trips at one particular stop, but its only one route that gives you an oppurtunity to reach a certain destination. This route may only have 3 trips within the selected time window. That may give the population in this area a poor access to that destination even though they have a lot trips nearby."
Requested by a user on GeoNet

This is resolved with https://github.com/Esri/public-transit-tools/pull/148. The new Count Trips at Stops by Route and Direction tool breaks out the counts at each stop by route_id and direction_id.  Download the newest version of the toolbox here: https://arcg.is/0yr9fr


A lot of type instability in the Term Bechmark for Julia

Quickly looked at this.... Memoization makes it difficult to pin down, but there's a lot of runtime dispatch happening because of functions potentially returning Any

Partially fixed in #25

I don't think there is anything concrete to address now. We can always look at type instability if we want to have another round of performance optimization, but right now performance has already been optimized quite a bit.
Feel free to reopen this if you have any concrete example in mind where type instability occurs in a way that affects performance.


Multivalued emails, mobiles, verified mobiles and verified emails holding claims are not marked as multivalued claims

Describe the issue:

Check-IS-7.1.0-m4:

Login to console
Go to user attributes & stores -> SCIM -> custom schema
You can see newly introduced 4 default scim claim mapping to hold multivalued emails, mobiles, verified mobiles and verified emails

Check each local claim mapped to them.
As per the doc https://is.docs.wso2.com/en/6.1.0/references/extend/provisioning/add-scim2-custom-user-schema-support/#how-to-add-claims-to-support-multivalued-simple-attributes, custom SCIM schema pick whether the attribute is multivalued based on additional property multivalued : true stored in the local claim

But that information is not available in those claims

How to reproduce:

Mentioned in the description
Expected behavior:

The mentioned attributes should be marked as simple multi valued attributes
as per https://is.docs.wso2.com/en/6.1.0/references/extend/provisioning/add-scim2-custom-user-schema-support/#how-to-add-claims-to-support-multivalued-simple-attributes
Also address this doc issue https://github.com/wso2/product-is/issues/20121

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: 7.1.0-m4

Multivalued emails, mobiles, verified mobiles and verified emails holding claims were marked as multivalued claims through following PR for the IS.

https://github.com/wso2/carbon-identity-framework/pull/6103

Doc issue is tracked separately through

https://github.com/wso2/product-is/issues/20121

Since these attributes are newly introduced, user profile currently doesn't handle these claims. When merging UI PRs, we will ensure they are treated as multi-valued attributes.


Add documentation about TypeScript support

This PR adds some notes about TypeScript to the Getting Started page. It includes information gathered primarily from @smockle in a PR from another project (thank you @smockle!)
https://primer-components-git-mkt-types-docs.primer.now.sh/components/getting-started#typescript
Closes #782

Closing this as it's included in #786


Snapping turtle style clutch grabbing ranged attack

Currently the snapping turtle style clutch feat allows its user to grab enemies if they miss a ranged attack against him, which i assume is not intended.

lol I'll look into it

fixed in 2.9.3!


deprecate baseImage, tag, and sha fields in custom resources

fixes #2911

lgtm, we will need to make sure to announce this in the release notes as well.


No-std support

I'd like to use this library on some STM32 chips.

Hi @thunderstorm010, that would be nice to have in the message generation, to generate messages that can be used in embedded applications.

I've created a very, very small subset of this library at https://github.com/thunderstorm010/ping-protocol-core.git. It only includes decoding and serializing functions. Open for everything.

Hey @thunderstorm010, to make it broadly available as no-std, we need to think about how to replace the tokio ecosystem features.
I did a quick attempt by splitting out decoder.rs and message.rs into an inner core project (https://github.com/RaulTromber/ping-rs/tree/split_no_std_method).
Then in /ping-protocol-core:
cross build --target thumbv7em-none-eabihf --example stm32 --features stm32
With this approach, the examples still run on the main crate, but we need to put more effort into checking everything. It would be nice to forward the message generation from builder to this inner crate.


[SPARK-16353][BUILD][DOC] Missing javadoc options for java unidoc

Link to Jira issue: https://issues.apache.org/jira/browse/SPARK-16353
What changes were proposed in this pull request?
The javadoc options for the java unidoc generation are ignored when generating the java unidoc. For example, the generated index.html has the wrong HTML page title. This can be seen at http://spark.apache.org/docs/latest/api/java/index.html.
I changed the relevant setting scope from doc to (JavaUnidoc, unidoc).
How was this patch tested?
I ran docs/jekyll build and verified that the java unidoc index.html has the correct HTML page title.

Can one of the admins verify this patch?

Jenkins add to whitelist

Jenkins test this please

LGTM

Test build #61687 has started for PR 14031 at commit 939e8b5.

Test build #61687 has finished for PR 14031 at commit 939e8b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61687/
Test PASSed.

Merged build finished. Test PASSed.

Test build #61728 has started for PR 14031 at commit fcc45c7.

Test build #61728 has finished for PR 14031 at commit fcc45c7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61728/
Test PASSed.

Merged to master/2.0/1.6

Thank you.


[WEB] Textfield  can't type on Safari Desktop Mac OS on new Stable 2.10.0

Steps to Reproduce

Open link on Desktop Safari: https://flutter-2bc9f.web.app/#/
Try to type on the textfield

Expected results:

Working textfield after upgrading to new Stable 2.10.0

Actual results:

Non working textfields

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: const <Widget>[
            TextField(
              decoration: InputDecoration(
                border: OutlineInputBorder(),
                labelText: 'Enter your name',
              ),
            ),
          ],
        ),
      ),
    );
  }
}

[✓] Flutter (Channel stable, 2.10.0, on macOS 12.2 21D49 darwin-arm, locale en-US)
    • Flutter version 2.10.0
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5f105a6ca7 (2 days ago), 2022-02-01 14:15:42 -0800
    • Engine revision 776efd2034
    • Dart version 2.16.0
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/bilonik/Library/Android/sdk
    • Platform android-32, build-tools 32.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.64.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 97.0.4692.99

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Serious issue . Must be addressed

Hi @Bilonik @RageshAntony, this was initially reported in https://github.com/flutter/flutter/issues/96411 and has since been fixed.
The fix is available on master and there's a cherry-pick request for it to be hotfixed into the current stable. It will be evaluated and handled appropriately.
We're sorry for any inconvenience this has caused you, but in the meantime, you can switch to the master channel.
Closing as this has already been fixed.
Thank you


** Cannot get connection id for node<EMAIL_ADDRESS>

I am running vernMQ container on server-1
docker run -it --name=vernmq1 -p 1883:1883 -p 8883:8883 -p 8080:8080 -p 44053:44053 -p 4369:4369 -p 8888:8888 -p 9100-9109:9100-9109 -e "DOCKER_VERNEMQ_ALLOW_ANONYMOUS=on" -e "DOCKER_VERNEMQ_ACCEPT_EULA=yes" vernemq/vernemq
Server-1 has IP: <IP_ADDRESS>
I am creating a second docker container on server-2. And I want this one to join the container of server-1 and for a cluster.
docker run -it -p 1883:1883 -p 8883:8883 -p 8080:8080 -p 44053:44053 -p 4369:4369 -p 8888:8888 -p 9100-9109:9100-9109 -e "DOCKER_VERNEMQ_ALLOW_ANONYMOUS=on" -e "DOCKER_VERNEMQ_ACCEPT_EULA=yes" -e "DOCKER_VERNEMQ_DISCOVERY_NODE=<IP_ADDRESS>" -e "DOCKER_VERNEMQ_DISCOVERY_NODE=<IP_ADDRESS>"  --name vernmq2 vernemq/vernemq
I have mapped all exposed ports.
The second container is not being able to join the first container on server-1
The interactive output of container-2
10:39:03.373 [info] loaded 0 subscriptions into vmq_reg_trie
10:39:03.380 [info] cluster event handler 'vmq_cluster' registered
10:39:04.161 [info] Sent join request to<EMAIL_ADDRESS>10:39:11.166 [info] Unable to connect to<EMAIL_ADDRESS>
The interactive output of container-1
10:38:06.791 [info] Opening LevelDB database at "./data/msgstore/12"
10:38:06.829 [info] Try to start vmq_generic_msg_store: ok
10:38:06.953 [info] loaded 0 subscriptions into vmq_reg_trie
10:38:06.962 [info] cluster event handler 'vmq_cluster' registered
10:39:04.180 [error]
** Cannot get connection id for node<EMAIL_ADDRESS>

Could anyone please help me with this.
Thank you.

I tried creating a cluster with multiple containers on a single server. It worked beautifully. Also, I tested it with mqtt.fx (mqtt client) no problem there. The problem appears when I am running two containers on two different servers. Also, the servers are ubuntu-server 2020 virtualized on proxmox in my local network. I have checked the firewall and it is not active.
As much I understood from the log is that the requesting container should pass a connection ID along with the request. If that is the case then is there an environment variable that I can set up with the ID?

@tuhin37 I don't think I have seen that specific error mentioning the connection id. You don't need to handle any connection id anyway. It'll be a variant of issues around network connectivity between those servers/pods.
Noteably, you'll need to be able to reach the vmq listener directly on the configured IP (on the 44053 port, in case you use the default). This will not work exposing that port on a different IP, the original listener still only runs on the internal port.
So you need to ensure somehow that you have a Docker network connectivity on that level.

Please support the VerneMQ project: https://github.com/sponsors/vernemq

It worked when I used --network host in the docker run.
Also, now I am running 3 container cluster and I am using a nginx  layer4 load balancer.
events {}

stream {
    upstream mqtt_cluster {
        server <IP_ADDRESS>:1883;
        server <IP_ADDRESS>:1883;
        server <IP_ADDRESS>:1883;
    }

    server {
        listen 1883;
        proxy_pass mqtt_cluster;
    }
}

The nginx LB is also running as a docker container on the same bridge.
My mqtt client can only connect when all three containers are running. If I stop any one container, the mqtt client can not connect to the broker (Through LB)
Docker run commands
`docker run -e "DOCKER_VERNEMQ_ALLOW_ANONYMOUS=on" -e DOCKER_VERNEMQ_ACCEPT_EULA=yes --name mq1 -d vernemq/vernemq
docker run -e "DOCKER_VERNEMQ_ALLOW_ANONYMOUS=on" -e DOCKER_VERNEMQ_ACCEPT_EULA=yes -e "DOCKER_VERNEMQ_DISCOVERY_NODE=<IP_ADDRESS>" --name mq2 -d vernemq/vernemq
docker run -e "DOCKER_VERNEMQ_ALLOW_ANONYMOUS=on" -e DOCKER_VERNEMQ_ACCEPT_EULA=yes -e "DOCKER_VERNEMQ_DISCOVERY_NODE=<IP_ADDRESS>" --name mq3 -d vernemq/vernemq
`

allow_register_during_netsplit = on
allow_publish_during_netsplit = on
allow_subscribe_during_netsplit = on
allow_unsubscribe_during_netsplit = on

Thank you for support the VerneMQ project: https://github.com/sponsors/vernemq

I am using the docker version, so should I pass these along as environment variables? If not environment variable then how?
Also, I want the clients to connect using a self-signed TLS certificate and username and password. How to set it up?
Thank you


Allow fee/gas to be specified per transaction instead of using the default from config

Crate
ibc-relayer, ibc-relayer-clie
Summary
Hermes should allow a fee to be specified when submitting a transaction.
Problem Definition
The problem right now is that we use the same fee (via config) for all transactions. In reality different commands might 'cost' different because of gas used.
Proposal
Added a fee (and denom) to the cli commands for txs. Also provide support for that in the future REST API endpoints.
Acceptance Criteria
All the txs commands have a way to specify the fee

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Hermes dynamically computes the fees now, via /tx_simulate endpoint. Closing as outdated.


Move spark-cassandra to backend module

Fixes https://github.com/quasar-analytics/quasar/issues/2716

@drostron it would probably be best if we can land this today so that @djspiewak can then merge it into the dynamic loading PR #2756. Otherwise we'd have to deal with the conflicts going the other way.

@alissapajer Conflicts in either direction going to be minor, though they are semantically more validly conflicts generated by #2756.  I agree that this should land before my PR, just in the interest of good git hygiene.

@alissapajer @djspiewak Sure, I was most of the way through yesterday and will switch to finishing the review momentarily.


Refactor authentication to use JWT verification

 Issue by evansiroky
Wednesday Jul 18, 2018 at 04:42 GMT
Originally opened as https://github.com/catalogueglobal/datatools-server/issues/105

It appears that the current authentication system merely verifies a token is valid and does not check that it was signed in the way we expect it to be signed.  We should be verifying that the JWT signature is expected by verifying it against our own secret.  See example in analysis-backend.

 Comment by landonreed
Tuesday Jul 24, 2018 at 19:09 GMT

I tried pasting the example code block into the Auth0Connection#checkUser method, but I'm running into a java.security.SignatureException: signature verification failed exception.  However, it does seem to work with the suggestion here: JWTVerifier verifier = new JWTVerifier(new Base64().decode(secret));
Thoughts?

 Comment by evansiroky
Tuesday Jul 24, 2018 at 20:02 GMT

Yeah, the code in analysis assumes the use a base64 encoded key.


Request for new hook useContractBlueprint to support dynamic contract instantiation

Feature Request
Suggestion
Add a new hook useContractBlueprint(codeHash: string, metadata: Record<string, unknown>, chainId?: ChainId) that allows creating new instances of a contract instead of just interacting with a unique deployment.
Motivation
Currently, when working with useInk, there is support for interacting with a specific deployment of a contract using the useContract hook. However, there is no built-in mechanism to create new instances of the contract based on a blueprint or template. This limitation makes it cumbersome for users who want to instantiate multiple instances of the same contract with different parameters.
Use Cases

Dynamic Contract Instantiation: Users could define a blueprint or template of a contract by providing the codeHash and metadata. They can then utilize the useContractBlueprint hook to create new instances of the contract with varying parameters.
The proposed feature would enhance the flexibility and ease of use of useInk, reducing the need for manual contract instantiation and enabling users to leverage the full potential of the library.

I'm almost done with this one. I have a working branch here. This should get released this week @0xLucca

Hi @DoubleOTheven! Awesome, i will start trying it. Thanks!


fix: change main file to server.js

Was this causing problems?  I would have thought "start": "node server.js" is enough.

no, it's not causing problems. We changed all the index.js server files to server.js - so this was just for consistency, even though it really doesn't matter. https://github.com/freeCodeCamp/demo-projects/pull/17#discussion_r493164805


[Doc-enhancement] State maintenance in Tab application

Once user access tab application, based on user action there may be internal navigation and displaying results. But if user navigates away from tab and open tab app again (or click on back button) will show the tab home page. Previous state will not be maintained. This behavior is By design. Adding note in FAQs section will help.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 61f5ca59-ab3e-b7ef-d3bc-55a88a362abf
Version Independent ID: 6d43a761-19e0-541e-ba06-170099411ac1
Content: Create a personal tab - Teams
Content Source: msteams-platform/tabs/how-to/create-personal-tab.md
Service: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

We will look into it and redirect to doc team.

Hi @surbhigupta12 - Could you please help here to add this as note ?
Note:
Once user access tab application, based on user action there may be internal navigation and displaying results. But if user navigates away from tab and open tab app again (or click on back button) will show the tab home page. Previous state will not be maintained. This behavior is By design.


submariner bug

https://github.com/stolostron/console/pull/1712
Signed-off-by: John Swanke<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/22622

/lgtm


Validate presence of framework-name property in config.json when is_framework=true

cc @jsancio @BenWhitehead

I think this an okay idea, though it may cause an issue for cassandra which configures framework name based on the cluster name.
For example the user can specify cluster.name = prod which will result in a framework name in mesos of cassandra.prod

Based on how the DCOS UI maps registered frameworks to Marathon processes, there's no way around this (otherwise your service has 0 chance of appearing "healthy" in the UI).  Since that's the case, it should be required to avoid massive confusion.

The alternative for the UI is to change how that mapping is done.  That's outside the scope of this repo though.  cc @mlunoe && @rcorral.

FYI, We also need framework-name to be there given how uninstall works.

Good point.

Just for the record, if there's a DCOS_PACKAGE_FRAMEWORK_NAME we assume that the marathon app is a framework.

@rcorral -- understood.  That's something that doesn't live in this repo though (it's added as a label to the Marathon app), so the purpose of this required config parameter is to have a uniform way to communicate the value to the client (dcos-cli).

I'm spinning up a cluster with 3 instances of the cassandra framework running so that we can test some of these things out before I roll it back.

I think what you are talking about @ConnorDoyle is covered by this task, right?
https://mesosphere.atlassian.net/browse/DCOS-1561

In the case of cassandra I think think things are handled rather well.
Install
I created a cluster and installed 3 different instances of the cassandra service.

Default cassandra.dcos
Configured cassandra.cluster-name to be test1
Configured cassandra.cluster-name to be test2

As can be seen in the screenshot below all three instances started by marathon cleanly:

Health Checks
It can also be seen that the health check correlation is happening correctly, and was verified using the following script:
for s in dcos test1 test2; do http --print=HhBb --pretty=colors http://benw-19-elasticloa-a0ax8we91ngl-695045825.us-west-2.elb.amazonaws.com/service/cassandra.$s/health/cluster/report;done

Which output:
GET /service/cassandra.dcos/health/cluster/report HTTP/1.1
User-Agent: HTTPie/0.9.0
Accept: */*
Connection: keep-alive
Accept-Encoding: gzip, deflate
Host: benw-19-elasticloa-a0ax8we91ngl-695045825.us-west-2.elb.amazonaws.com

HTTP/1.1 200 OK
Content-Type: application/json
Date: Wed, 03 Jun 2015 00:20:12 GMT
Server: openresty/<IP_ADDRESS>
Content-Length: 592
Connection: keep-alive

{"healthy":true,"results":[{"name":"nodeCount","ok":true,"expected":3,"actual":3},{"name":"seedCount","ok":true,"expected":2,"actual":2},{"name":"allHealthy","ok":true,"expected":[true,true,true],"actual":[true,true,true]},{"name":"operatingModeNormal","ok":true,"expected":["NORMAL","NORMAL","NORMAL"],"actual":["NORMAL","NORMAL","NORMAL"]},{"name":"lastHealthCheckNewerThan","ok":true,"expected":[1433290512948,1433290512948,1433290512948],"actual":[1433290763791,1433290765815,1433290765998]},{"name":"nodesHaveServerTask","ok":true,"expected":[true,true,true],"actual":[true,true,true]}]}

GET /service/cassandra.test1/health/cluster/report HTTP/1.1
User-Agent: HTTPie/0.9.0
Accept: */*
Connection: keep-alive
Accept-Encoding: gzip, deflate
Host: benw-19-elasticloa-a0ax8we91ngl-695045825.us-west-2.elb.amazonaws.com

HTTP/1.1 200 OK
Content-Type: application/json
Date: Wed, 03 Jun 2015 00:20:13 GMT
Server: openresty/<IP_ADDRESS>
Content-Length: 570
Connection: keep-alive

{"healthy":false,"results":[{"name":"nodeCount","ok":true,"expected":3,"actual":3},{"name":"seedCount","ok":true,"expected":2,"actual":2},{"name":"allHealthy","ok":false,"expected":[true,true,true],"actual":[true,true]},{"name":"operatingModeNormal","ok":false,"expected":["NORMAL","NORMAL","NORMAL"],"actual":["NORMAL","NORMAL"]},{"name":"lastHealthCheckNewerThan","ok":false,"expected":[1433290513143,1433290513143,1433290513143],"actual":[1433290781614,1433290789801]},{"name":"nodesHaveServerTask","ok":false,"expected":[true,true,true],"actual":[true,false,true]}]}

GET /service/cassandra.test2/health/cluster/report HTTP/1.1
Host: benw-19-elasticloa-a0ax8we91ngl-695045825.us-west-2.elb.amazonaws.com
Accept: */*
Connection: keep-alive
User-Agent: HTTPie/0.9.0
Accept-Encoding: gzip, deflate

HTTP/1.1 200 OK
Content-Type: application/json
Date: Wed, 03 Jun 2015 00:20:13 GMT
Server: openresty/<IP_ADDRESS>
Content-Length: 592
Connection: keep-alive

{"healthy":true,"results":[{"name":"nodeCount","ok":true,"expected":3,"actual":3},{"name":"seedCount","ok":true,"expected":2,"actual":2},{"name":"allHealthy","ok":true,"expected":[true,true,true],"actual":[true,true,true]},{"name":"operatingModeNormal","ok":true,"expected":["NORMAL","NORMAL","NORMAL"],"actual":["NORMAL","NORMAL","NORMAL"]},{"name":"lastHealthCheckNewerThan","ok":true,"expected":[1433290513357,1433290513357,1433290513357],"actual":[1433290787673,1433290792903,1433290797275]},{"name":"nodesHaveServerTask","ok":true,"expected":[true,true,true],"actual":[true,true,true]}]}

Uninstall
When attempting to uninstall cassandra with:
dcos package uninstall cassandra

I am met with the following output:
Multiple instances of app [cassandra] are installed. Please specify the app id of the instance to uninstall or uninstall all. The app ids of the installed package instances are: [/cassandra/dcos, /cassandra/test1, /cassandra/test2].

Then when I run:
dcos package uninstall --app-id=/cassandra/test2 cassandra

The framework scheduler process in marathon is correctly stopped (the framework isn't shut down yet because we haven't had a new release of the cli with the functionality).
Summary
I definitely agree that we will need some sort of control in place to make sure that the cli can function well, but I don't know if the requirement to have a framework-name property is the correct way to go.  In the case of cassandra marathon app id, framework name, executor ID and task ID are all correlated with the cassandra cluster that has been configured so things work out well.  Perhaps there are other frameworks that are less disciplined in how these things are approached and this is something we should look into building tooling/documentation to direct service implementers toward.


Fix ThreadedHTTPTransport import path

As the title says.

Thanks!

(Doh can't merge from phone. Will grab later)


Do not use pixel unit, only rem

The Material theme is good. But everything is huge: the buttons are huge, the titles are huge, the selectors are huge... This theme is not well suited to Line Of Business type of applications. Too bad.
One of the ways to adapt it is to reduce the overall font size. So, by putting "font-size: 13px" to "html" or "body", the whole theme should normally scale and shrink since the default font-size is 16px.
It does not work. Most designers no longer put pixel sizes in CSS : they do everything relative to the base font-size, they work with "rem". Bootstrap does rem, and it's terribly efficient when you want to adapt it to more "admin" applications.
This transition would therefore consist in transforming all sizes defined in pixel sizes to rem. This would make it easier to create themes as well.

This is gonna be a huge change.

I don't think this is so easy as stated

This issue is now organized in our feature requests project
Note: the issue is closed but that doesn't mean that this won't be implemented. Check the project to see how it is scheduled. If enough users vote for a different scheduling it can be changed. Also, if you want to PR this feature you may do so any time.
You can still discuss this feature here!

Good !
I have read parts of the sources and it seems to me that only key values could be converted to REM to allow better adaptation to more LOB use cases. It should open the way to "real" theme creation. If I decide to make a specific branch to make a LOB theme, I would try to do so for the purpose of PR.
Thank you !

Another idea is to add a density parameter like they did in Material.Blazor: https://material-blazor.com/docs/articles/Density.html

I'm working on this since I also need it. But what do we do with borders of f.e. 1px?
Do we also convert them to rem:

Hi ! For borders, keep it in pixel. If you want to change the scale of the UI, you don't want one pixel line become sub pixel width, because the rendering may become weird, unstable and blurry.
Most devices with ultra high def, have a conversion from pixel to something relative to a standard "pitch" (the pitch is the number of pixel per pouce). On a really high def screen, 1 px = 2 or 3 physical pixels. If you zoom in your browser, 1 pixel line become a lot more than 1 pixel width. So, pixels are already "relative" or "visually compensated" unit.

I guess we have two concern :

Make all REM is the first step, like a "fast and easy" customization : it is like zooming the browser view to adapt to the real usage of the application.
The second goal here is to modulate margins, paddings, spaces independently from the "real" font size, to make components more LOB compatible, to design rich forms, lists and interface panels with lot of components.

As mentionned before, a "global density parameter" could solve the problem.
Beyond that, to create a real theme, the process might need 4 basic steps :

Set a base font size to uniformly scale all components. This can be device size relative (smaller on mobile, bigger on desktop).
Change the font size of components and basic tags to relativelly reduce margins and paddings.
Optionnaly change the "density" parameter if previous step do not work.
And then, make all the job for classical CSS theme : font-family, colors, backgrounds, animations, etc.

If there is a lot of variable to control the margins and padding, it may ease the theming work. So, I think the REM conversion is cool and really efficient basic feature, but we need something to have a relative control over margins and paddings.

I have 3 themes that are references for a theming feature.
Limitless is the basic, classical LOB apps theme :
https://demo.interface.club/limitless/demo/Template/layout_1/LTR/default/full/form_layout_horizontal.html
Metronic is a great theme too, with more fuzzy borders :
https://preview.keenthemes.com/metronic/demo1/crud/forms/widgets/bootstrap-datetimepicker.html
Page is a styled, modern admin theme :
https://pages.revox.io/dashboard/latest/html/condensed/form_layouts.html
If MudBlazor supports such level of theming, it become usable for a very large kind of projects. Open-source themes may be an important ecosystem components.

I have 3 themes that are references for a theming feature.
Limitless is the basic, classical LOB apps theme :
https://demo.interface.club/limitless/demo/Template/layout_1/LTR/default/full/form_layout_horizontal.html
Metronic is a great theme too, with more fuzzy borders :
https://preview.keenthemes.com/metronic/demo1/crud/forms/widgets/bootstrap-datetimepicker.html
Page is a styled, modern admin theme :
https://pages.revox.io/dashboard/latest/html/condensed/form_layouts.html
If MudBlazor supports such level of theming, it become usable for a very large kind of projects. Open-source themes may be an important ecosystem components.

You can pretty much do all 3 of them today with our current theming.

This will also aid accessibility allowing the user to zoom the screen if there eyesight is poor.  But it is a big change with a lot of manual testing required.

It would be good if someone could do a video showing a small amount of controls that have been rem'ed and how they react to changing font size.

I've only been using MudBlazor for a couple days now and haven't contributed much yet but let me ask only two questions that might help prioritizing this.

Is it an option for a modern UI framework to use pixels in the future?
When is this going to be easier to get done?
From my point of view, this framework would be better served with rem. Not only for LOBs but for accessibility and theming support. Yes, we can hack our way out overriding styles all over the place but this goes against the framework's philosophy (well, at least what I understood so far).
It's obvious this change is massive and will have impacts on existing sites but later is just not a better time to get it done.

Maybe the discussion should focus on how we bring that change and mitigate the impacts for existing sites.

It would be good if someone could do a video showing a small amount of controls that have been rem'ed and how they react to changing font size.

Not a video but here are a couple MubButton in a try
You can get an idea of the result by going in your browser settings and changing the font size there.
Here's a screenshot of running these at 16px (default for most browsers) and 32px.

You can see
The one using the built-in style [top row] is reacting, somehow...
the one styled with px [middle row] are not reacting at all
And the one styled in rem are growing
I've also included a couple more samples with border-radius and one showing the more disruptive em approach.

Just for info, we have a PR to this topic #2109

Experimental PR to convert ToggleGroup to relative units: https://github.com/MudBlazor/MudBlazor/pull/8676


brcm-bt-firmware fails due to mnt-conf not existing anymore

In https://github.com/resin-os/resin-artik710/blob/master/layers/meta-resin-artik710/recipes-bsp/brcm-bluetooth/files/brcm-bt-firmware.conf - I tried replacing this for mnt-boot and it seemed to work, but I'm not sure if it's the right replacement.

@floion can you please confirm this is fixed now? Is there anything else left to do?

Fixed by https://github.com/resin-os/resin-artik710/pull/53


msbot clone services fails at Creating Azure Bot Service - ERROR: At least one resource deployment operation failed. Please list deployment operations for details.

Sample information

Sample type: \samples\
Sample language: typescript
Sample name: 14.nlp-with-dispatch

Describe the bug
I'm trying to deploy the bot to Azure by running this command from the project directory:
msbot clone services --name "chuck-dispatch" --luisAuthoringKey "<MY AUTHORING KEY>" --folder "deploymentScripts/msbotClone" --location "westus" --appId <MY APP ID> --appSecret <MY APP SECRET PASSWORD>
I had create a "Web App Bot" before and I have used it's app id and passwords as  MY APP ID and MY APP PASSWORD
To Reproduce
Steps to reproduce the behavior:

Go to '/botbuilder-samples/samples/javascript_nodejs/14.nlp-with-dispatch'
npm i -g msbot chatdown ludown qnamaker luis-apis botdispatch luisgen
msbot clone services --name "chuck-dispatch" --luisAuthoringKey "<MY AUTHORING KEY>" --folder "deploymentScripts/msbotClone" --location "westus" --appId <MY APP ID> --appSecret <MY APP SECRET PASSWORD>
See error

Expected behavior
It is expected to create required services - Azure App Site Plan, Azure AppInsights Service,  Azure Blob Storage Service, Azure Bot Service Registration, Azure LUIS Cognitive Service, Azure LUIS Cognitive Service, Azure LUIS Cognitive Service (Dispatch), Azure QnA Maker Service, Azure Search Service, Azure WebApp Service (Bot), Azure WebApp Service (QnA) successfully and create Bot configuration file.
Screenshots

Additional context
Checking az botservice version
Fetching subscription account
The following services will be created by this operation:
 Service                                 Location            SKU                 Resource Group
 Azure App Site Plan                     westus              S1                  chuck-dispatch
 Azure AppInsights Service               West US 2           F0                  chuck-dispatch
 Azure Blob Storage Service              westus              Standard_LRS        chuck-dispatch
 Azure Bot Service Registration          Global                                  chuck-dispatch
 Azure LUIS Cognitive Service            westus              S0                  chuck-dispatch
 Azure LUIS Cognitive Service            westus              S0                  chuck-dispatch
 Azure LUIS Cognitive Service            westus              S0                  chuck-dispatch
 (Dispatch)
 Azure QnA Maker Service                 westus              S0                  chuck-dispatch
 Azure Search Service                    westus              Standard            chuck-dispatch
 Azure WebApp Service (Bot)              westus                                  chuck-dispatch
 Azure WebApp Service (QnA)              westus                                  chuck-dispatch
Resources will be created in subscription: TCS TechBU Digital (0f9853a8-119d-4d8e-8b55-6dd78734012a)
Would you like to perform this operation? [y/n]Creating Azure group [chuck-dispatch]
y
Using the provided ApplicationId and Secret rather than auto-provisioning
Creating Azure Bot Service [chuck-dispatch]
az bot create -g chuck-dispatch --name chuck-dispatch --kind webapp --location westus --insights-location "West US 2" --subscription 0f9853a8-119d-4d8e-8b55-6dd78734012a --version v4 --lang Node --appid 58091305-d6cf-40eb-8df2-f32ae35b338a -p "S%k##{H*zK(PuGk!" exit code: 1
ERROR: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.

Usage: msbot clone services [options]

allows you to clone all of the services a bot uses into a new azure resource group

Options:
  -n, --name <name>                            name of new bot
  -f, --folder <folder>                        path to folder containing exported resources
  -l, --location <location>                    location to create the bot service in (westus, ...)
  --luisAuthoringKey <luisAuthoringKey>        authoring key from the appropriate luisAuthoringRegion for luis resources
  --luisAuthoringRegion <luisAuthoringRegion>  (OPTIONAL) [westus|westeurope|australiaeast] authoring region to put LUIS models into (default is based on location)
  --luisPublishRegion <luisRegion>             (OPTIONAL) region to publish LUIS models to (default fallback is based location || luisAuthoringRegion)
  --subscriptionId <subscriptionId>            (OPTIONAL) Azure subscriptionId to clone bot to, if not passed then current az account will be used
  --insightsRegion <insightsRegion>            (OPTIONAL) region to create appInsights account in (default is based on location)
  --groupName <groupName>                      (OPTIONAL) groupName for cloned bot, if not passed then new bot name will be used for the new group
  --sdkLanguage <sdkLanguage>                  (OPTIONAL) language for bot [Csharp|Node] (Default:CSharp)
  --sdkVersion <sdkVersion>                    (OPTIONAL) SDK version for bot [v3|v4] (Default:v4)
  --prefix                                     Append [msbot] prefix to all messages
  --appId <appId>                              (OPTIONAL) Application ID for an existing application, if not passed then a new Application will be created
  --appSecret <appSecret>                      (OPTIONAL) Application Secret for an existing application, if not passed then a new Application will be created
  --proj-file <projfile>                       (OPTIONAL) auto publish the local project file to created bot service
  --code-dir <path>                            (OPTIONAL) auto publish the folder path to created bot service
  -q, --quiet                                  minimize output
  --verbose                                    show commands
  -f, --force                                  do not prompt for confirmation
  -h, --help                                   output usage information

NOTE: You did not complete the operation.
To delete the group and resources run:
az group delete -g chuck-dispatch --no-wait --subscription <MY SUBSCRIPTION>

az -v output:

azure-cli (2.0.52)

acr (2.1.10)
acs (2.3.12)
advisor (2.0.0)
ams (0.3.1)
appservice (0.2.8)
backup (1.2.1)
batch (3.4.1)
batchai (0.4.5)
billing (0.2.0)
botservice (0.1.2)
cdn (0.2.0)
cloud (2.1.0)
cognitiveservices (0.2.4)
command-modules-nspkg (2.0.2)
configure (2.0.19)
consumption (0.4.0)
container (0.3.9)
core (2.0.52)
cosmosdb (0.2.5)
dla (0.2.3)
dls (0.1.6)
dms (0.1.1)
eventgrid (0.2.0)
eventhubs (0.3.1)
extension (0.2.3)
feedback (2.1.4)
find (0.2.12)
hdinsight (0.1.0)
interactive (0.4.0)
iot (0.3.4)
iotcentral (0.1.4)
keyvault (2.2.8)
lab (0.1.4)
maps (0.3.2)
monitor (0.2.7)
network (2.2.10)
nspkg (3.0.3)
policyinsights (0.1.0)
profile (2.1.2)
rdbms (0.3.5)
redis (0.3.2)
relay (0.1.2)
reservations (0.4.1)
resource (2.1.6)
role (2.1.11)
search (0.1.1)
servicebus (0.3.2)
servicefabric (0.1.9)
signalr (1.0.0)
sql (2.1.6)
storage (2.2.6)
telemetry (1.0.0)
vm (2.2.9)

Extensions:
botservice (0.4.3)

Python location '/opt/az/bin/python3'
Extensions directory '/home/srichakradhar/.azure/cliextensions'

Python (Linux) 3.6.5 (default, Nov 29 2018, 21:51:02)
[GCC 7.3.0]

$ node -v
v10.14.2
$ npm -v
6.5.0

[bug]

I figured out I was using the app id of an app for which Bot Service already exists - by listing the operations..
az group deployment operation list \
>   --resource-group chuck-dispatch \
>   --name chuck-dispatch

It says MsaAppId is already in use..
"statusMessage": {
        "error": {
          "code": "InvalidBotData",
          "message": "Bot is not valid. Errors: MsaAppId: MsaAppId is already in use.. "
        }
      }

So, I changed it and it works.

It was an issue with confusing appID


Fix node engine version

What
Latest v14 is 14.17.1 but buildpack only has 14.17.0
Omitting fix/patch version number
How to review

run a build/cf push to check buildpack compiles

Who can review
anyone

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

ta


FlowRouter.all() && Database based Routing

It'd be really awesome (mostly for debug purposes) to be able to get a list of all registered routes.
I'm building a database based routing system with FlowRouter at the moment.
As with any CMS system all page routes are saved to the DB, but now that I'm trying to fetch the routes I get an error saying '/' is not defined.
Some code:
lib/routes.jsx
Routes.find().fetch().map((dbRoute) => {
    FlowRouter.route(dbRoute.path, {
        name: dbRoute.name,
        action(params) {
            renderWithLayout(dbRoute);
        }
    });
});

function renderWithLayout(dbRoute) {
    ReactLayout.render(window[dbRoute.template], {
        content: window[dbRoute.component],
    });
}

/lib/bootstrap.jsx
Meteor.startup(() => {
    if (Routes.find().count() === 0) {
        Routes.insert({
            path: '/',
            name: 'Start',
            template: 'MainLayout',
            component: 'Home'
        }, function(error, result) {
            console.log(error);
        });

        Routes.insert({
            path: '/login',
            name: 'Login',
            template: 'MainLayout',
            component: 'Login'
        }, function(error, result) {
            console.log(error);
        });
    }
});

lib/collections/routes.jsx
Schemas = {};

Schemas.Routes = new SimpleSchema({
    path: {
        type: String,
        optional: false,
    },

    name: {
        type: String,
        optional: false,
    },

    component: {
        type: String,
        optional: false
    },

    template: {
        type: String,
        optional: true
    }
});

Routes = new Meteor.Collection('Routes');
Routes.attachSchema(Schemas.Routes);

Any ideas?

The things is FlowRouter tries to run routes just after the DOM loaded. But in your case, you don't have data at that time and no routes will be rendered.
So, you can use this: https://github.com/kadirahq/flow-router#flowrouterwait-and-flowrouterinitialize

Awesome! Ill try that!
So Ill set flowrouter to wait, load My DB set and then initialize?
What about the serverside rendering? Are there any differences there?
Because I don't want that blank page when the site initializes before the router loads the default page. Is that possible?
Jonas
—
Have a nice day!
On Sat, Sep 12, 2015 at 10:18 AM, Arunoda Susiripala
<EMAIL_ADDRESS>wrote:

The things is FlowRouter tries to run routes just after the DOM loaded. But in your case, you don't have data at that time and no routes will be rendered.
So, you can use this: https://github.com/kadirahq/flow-router#flowrouterwait-and-flowrouterinitialize
Reply to this email directly or view it on GitHub:
https://github.com/kadirahq/flow-router/issues/317#issuecomment-139739861


remote ssh makes site unresponsive on EC2 (t3.small)

VSCode Version: 1.41.0
OS Version: MacOS Catalina 10.15.1

Steps to Reproduce:

Install vscode remote ssh plugin
connect to EC2 instance via SSH

Does this issue occur when all extensions are disabled?: No

Can you give any more details, like which resources are being consumed and which processes are consuming them? What extensions do you have installed remotely? Can you try disabling those extensions?


Feature/with sharing changes

Warning
Information
Issues
Fixes #1479
Fixes #1819

@njjc ready for your review and merge.  it's just all the with sharing changes we talked about, plus one minor bug fix.

@dospromptman Nic is out this week, so could you please review and merge this pull request.  It passes build and is ready.  Let me know if you have any questions. thanks!

It looks like there was much discussion that happened before about which classes to remove 'with sharing' from.  I can only confirm that 'with sharing' was removed from several classes.
I have tested and confirmed that the NPSP Settings page will not choke when finding classes named ADDR% that do not have a no-arg constructor.
Merging!


Add note and example about quotes in JSON string fields

Double-quotes are not intuitive to insert in jsonb string fields
What kind of change does this PR introduce?
Docs update
What is the current behavior?
No hint to insert quotes in strings
What is the new behavior?
Note and example about it

Thanks for opening. Could you please try linked example that includes a double quote?
You should not have to do any extra escaping to insert json
https://github.com/supabase/pg_graphql/blob/aac44ceac59dbbace1660f31edbb832a6606586f/test/expected/json_is_stringified.out#L7-L24

The extra escaping is required to insert double quote " in a json string field, not to insert a simple string without double-quote actually

With your example, it would be :
mutation {
       insertIntoBlogPostCollection(objects: [{
         id: 1
         data: "{\"key\": \"Here a double quote \\\" inside a string\"}"
         parentId: 1
       }]) {
         records {
           id
           data
         }
       }
     }

got it, my mistake!
I just double checked the behavior of the json serialization/deserialization against JS

And it all seems to be well behaved.
Given that the current behavior matches the standard, I'd prefer not to add this callout to the API docs in case it confuses readers to think that the implementation is non-standard (that was my interpretation when first reading it)
Closing for now but I appreciate you taking the time to open a docs PR for something that was a stumbling block! Please feel free to suggest other changes as/if you run into rough edges

I wanted to add this in the docs as we were 2 teams of devs struggling with it for a couple of hours (maybe not the best you may say ^^`)
What's really confusing here is the behavior (or display) in my browser console (Chromium 116) :
> JSON.stringify({value: "hey \"there\" yo"})
'{"value":"hey \\"there\\" yo"}'

> JSON.parse('{"value":"hey \\"there\\" yo"}')
{value: 'hey "there" yo'}

> JSON.parse('{"value":"hey \\\"there\\\" yo"}')
{value: 'hey "there" yo'}

We will try more extensively about serialization / serialization using standard APIs.
If you feel it's not worth adding any mention in the docs, we learned about it by now anyway and you are the creator and maintainer of the extension :) Let me know if you need explanations to be changed in the docs from my side for them to be more clear for others.
And btw thanks a lot for checking this out really fast ! And for your amazing work. Can't wait for nested mutations support.


Debugging original source (.ts) when testing

In the default Angular setup, when you debug the tests you get one big boot-test.ts file in the browser. The file has the tests in the original TypeScript but the components' code in the transpiled JavaScript. What's the magic setting so it shows the TypeScript for everything? (not just the *.spec.ts)

Good question. It's not something I've looked into.
From a quick search, it looks like maybe Karma has to be configured with something like https://www.npmjs.com/package/karma-sourcemap-loader to get the original sources in its debug view.
If you're able to figure out how to set that up simply, would you please consider submitting a pull request?
I'll close this as it's not a feature we have yet - until your pull request :)


Remove T4 custom tool

use same generator as most other projects in aspnet repos
were not using named arguments to resource methods anyhow

FYI mostly

@natemcmaster @pranavkm @ryanbrandenburg a quick confirmation: We don't plan to remove the resx target (and use regular generator) i.e. I'm not migrating toward something that's about to go.

Actually, we do plan to remove the resx target. I can't promise a timeline on it, but removing our custom resx targets is part of the plan to converge with Arcade. See The MicroBuild team won't let us use MicroBuild.Plugins.Signing in TeamCity agents, so this basically copies the API

Oops, copy paste fail. See https://github.com/aspnet/BuildTools/issues/728

@natemcmaster is aspnet/BuildTools#728 likely to make it in 2.2?

No.

Attempting to trigger VSTS validations.


Develop

Portuguese Translate (pt)
translation.zip

@nurio-felix  thanks for your work! however to merge, could you start over again,and add a folder named "pt" in the translation directory. It looks like you had some merge conflicts in this PR.


Update copyright to 2021

What does this PR do?
Update copyright to 2021.
Motivation
We’re in 2021 now !
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details that should be tested during the QA.

-Present

This format can be used across Datadog repos.

-Present
This format can be used across Datadog repos.

That's what we did https://github.com/DataDog/integrations-core/pull/5384

Following the suggestion, I’ve replaced the -2021 by -present in the copyright.


Multiple groups Regex

Cannot search for... example:
(Phys)+ (Elem)+
Single groupings work, but not multiple. The skill tree crashes when typing the second parenthesis. My best guess is that the code isn't written to handle a second (or more) grouping.
Will fix myself once I get GitHub working...

This is already fixed in #111.
Tho not released yet.

Yep, was fixed.

Gotcha. Looked like it just had to be switched to Matches vs Match for
groupings. But idk.
On Sat, May 23, 2015 at 12:31 PM, Emmitt Johnson<EMAIL_ADDRESS>wrote:

Yep, was fixed.
—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104922845
.

Well the regex is handled by C#. There isn't any special logic that we
built in.
On May 23, 2015 1:21 PM, "cezelkowitz"<EMAIL_ADDRESS>wrote:
Gotcha. Looked like it just had to be switched to Matches vs Match for
groupings. But idk.
On Sat, May 23, 2015 at 12:31 PM, Emmitt Johnson<EMAIL_ADDRESS>wrote:

Yep, was fixed.

—
Reply to this email directly or view it on GitHub
<https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104922845

.

—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104941451.

Yeah.  I'm more of a Java guy but that was my first take on it from
when it failed to apply the regex groupings. My presumption was that a
String.split was required on either spaces to handle any groupings or on
open/close braces (, [, {, to apply specific groupings, use Matches instead
of Match, and then iterate over the collection returned.
Anyway, thanks for the fix. Can't wait to see it out there so I can search
for Elemental damage + Phys damage + Life at same time and more easily
search for quickest routes. Maybe in a later version you can impement
Dykstra's to a set of wanted nodes and find the shortest route while
favoring specific nodes such as Ele/Phys/Life :D... That might be overkill
:)
On Sat, May 23, 2015 at 4:25 PM, Emmitt Johnson<EMAIL_ADDRESS>wrote:

Well the regex is handled by C#. There isn't any special logic that we
built in.
On May 23, 2015 1:21 PM, "cezelkowitz"<EMAIL_ADDRESS>wrote:
Gotcha. Looked like it just had to be switched to Matches vs Match for
groupings. But idk.
On Sat, May 23, 2015 at 12:31 PM, Emmitt Johnson<EMAIL_ADDRESS>
wrote:

Yep, was fixed.

—
Reply to this email directly or view it on GitHub
<
https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104922845

.

—
Reply to this email directly or view it on GitHub
<https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104941451

.

—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104941822
.

It is already implemented and in the tools sections called skill
highlighted nodes. It uses steiners tree problem though which solves for
the smallest tree. You can read more about it if you look through the
closed issues
On May 24, 2015 3:17 AM, "cezelkowitz"<EMAIL_ADDRESS>wrote:

Yeah.  I'm more of a Java guy but that was my first take on it from
when it failed to apply the regex groupings. My presumption was that a
String.split was required on either spaces to handle any groupings or on
open/close braces (, [, {, to apply specific groupings, use Matches instead
of Match, and then iterate over the collection returned.
Anyway, thanks for the fix. Can't wait to see it out there so I can search
for Elemental damage + Phys damage + Life at same time and more easily
search for quickest routes. Maybe in a later version you can impement
Dykstra's to a set of wanted nodes and find the shortest route while
favoring specific nodes such as Ele/Phys/Life :D... That might be overkill
:)
On Sat, May 23, 2015 at 4:25 PM, Emmitt Johnson<EMAIL_ADDRESS>wrote:

Well the regex is handled by C#. There isn't any special logic that we
built in.
On May 23, 2015 1:21 PM, "cezelkowitz"<EMAIL_ADDRESS>wrote:
Gotcha. Looked like it just had to be switched to Matches vs Match for
groupings. But idk.
On Sat, May 23, 2015 at 12:31 PM, Emmitt Johnson <
<EMAIL_ADDRESS>
wrote:

Yep, was fixed.

—
Reply to this email directly or view it on GitHub
<

https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104922845

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104941451

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104941822>
.

—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/125#issuecomment-104998549
.

You can search for multiple things at once using RegEx right now, just have to write correct expression ;)
You look at RegEx groups wrong way. Groups are not for matching multiple things, but to provide more complex expressions.
The thing that RegEx engine can return matched groups is just a feature for programmer to save his time.
You can look at RegEx groups as parenthesized subexpressions in Java or C/C#, like this:
if ((A) && (B)) { /*...*/ }
...
if ((A) || (B)) { /*...*/ }

See? "if" statement cannot behave based on "groups" A and B, it has to behave based on expression as whole. Because only whole expression puts both "groups" into relation.
It's same with RegEx. Application cannot match based on groups, as those don't have meaning when separated from the whole, so it has to match against whole expression.
So, if you want to search for Elemental damage + Physical damage + Life. You can write it like this:
Elem.+ Damage|Phys.+ Damage|maximum Life

or this:
(Elem.+|Phys.+) Damage|maximum Life

The expression you wrote, has it's own meaning too. Schematically you wrote this:
(A) (B)

which means match group A followed by space, which is followed by group B.
Hope this will make RegEx groups more clearer for you :)


Nginx not working

Github first sends an HTTP GET to see if it POST the update, but the service responds with a 405

Hi Brecht,
I didn't find any reference to a GET request in the github webhook documentation, and also didn't see this on my system.
I guess there is something else going on. Did you select apache in CultURIze? This is not clearly mentioned in the documentation currently but the docker uses apache internally and is not compatible with nginx configuration. You can use nginx as the reverse proxy that redirect to the docker but not for the docker internally.


ci: SDK Publish Support

Add publish to SDK interface

e.g. mage sdk:python:publish sdk/python/v0.1.0

Converted Go publishing from GHA to sdk:go:publish and updated CI

/cc @gerhard @helderco @dolanor  @sipsma

Starting to look at this now.

This looks good to me. Once we have the Python SDK tests fixed - @helderco is creating a PR now - this is ready to be merged from my POV.
To check that the changes introduce in this PR work as expected, can we publish a new Go SDK release @aluzzardi @sipsma @shykes?

https://github.com/dagger/dagger/pull/3732


Unclear how to update a Context only with Components

This is about:

[ ] A typo
[ ] Innaccurate/misleading documentation (e.g. technically incorrect advice)
[x] Undocumented code
[ ] Outdated documentation
[x] Other

Problem
AFAICT there isn't any documentation showing how you can use a context (create a context and consume it appropriately to update your component) that doesn't use function components.

e.g. In the Contexts documentation on yew.rs it doesn't show how to update a Context and have it reflected.
Details about the solution you'd like (Optional)
Just add to the existing documentation for https://yew.rs/docs/concepts/contexts - by including another section called updating context - it could simply show how you can update the context and have it reflected in your component.
Additional context (Optional)

https://github.com/yewstack/yew/blob/master/examples/contexts/src/struct_component_subscriber.rs <- shows a good example of how to do this, although it's unclear why you need to store a ContextHandle<_>
Questionaire (Optional)

[x] I'd like to write this documentation
[ ] I'd like to write this documentation but I'm not sure what's needed
[ ] I don't have time to add this right now, but maybe later

There are two parts for contexts to work: A "provider" somewhere up in the virtual dom tree, and the "consumers" below it.
When a provider wants to make some type of context, let's say a Theme, a value theme: Theme accessible to some of its children, he should render
<ContextProvider<Theme> context={theme}>
    {children_with_consumers}
</ContextProvider<Theme>>

To update the provided value, the provider needs to re-render and pass the updated value as the new context property of <ContextProvider<Theme> context={theme}>. This will then trigger all subscribers down below. I think at this point the current page is inaccurate saying

The children are re-rendered when the context changes.

instead of

The subscribed children are notified when the context changes.

Note that children_with_consumers does most often not change, so not all children are re-rendered. But this is allowed and when new children_with_consumers are rendered, this will re-render all of those (shallowly, with the usual vdom diffing).
The struct consumer calls ctx.link().context::<Theme>(cb) and has to provide a callback cb that will be called when the context changes (the trigger). This callback is called with the updated context value and is expected to return a Message that is sent to the struct component. This call returns the current, immediate context value (as the provider already exists and has a definite provided value) and a ContextHandle. This second struct models the interest in receiving updates through the callback. Dropping it (e.g. as part of the component being destroyed), will unsubscribe from receiving updates when the context updates.
Again, the example slightly misuses this API in the guise of simplification. The context is gotten directly in fn view, which always uses the most up-to-date context either way, which does more work and doesn't receive updates - passing Callback::noop(). This will fail to re-render the component when the the theme changes.
In function components, use_context is similar, except its use will always re-render instead of sending a message, and the updated context will be picked up during that render, so no callback here. An example is missing and should also show off using the Theme context.

So taking a look at [the next documentation](https://yew.rs/docs/next/concepts/contexts#step-2-consuming-context) it looks like this was mostly addressed. When is next expected to be released? Since that change has been made I think it's fine to close this issue.

Closing this as Yew 0.21 has been released with the fix


Remove region tags from retail samples

Remove region tags from:

RetailEvents samples
RetailProducts samples
RetailSearch samples

I just want to make sure that you are all aware that thesa samples without region tag won't be able to be included in documentation? @chenlei1216 can you please confirm?

Discussed offline, that we're not gonna use the interactive tutorial samples in cloud doc, so SGTM to remove the tags.


Native Video support

We'll soon have experimental video support in the web viewer (https://github.com/rerun-io/rerun/issues/7271).
The next step is to get that working on native too.
Progress
Experimental support using rav1d can be found in:

https://github.com/rerun-io/rerun/pull/7557

TODO

[ ] https://github.com/rerun-io/rerun/pull/7563 (required by rav1d)
[ ] Error handling and cleanup of https://github.com/rerun-io/rerun/pull/7557
[ ] Check memory use
[ ] Move chroma-upsampling on GPU
[ ] Give https://github.com/rerun-io/rav1d-rs a good name and publish it (or upstream the bindings)
[ ] Update the video support matrix docs

(Note that I made the same mistake as in re_mp4 and uploaded a bunch of binary files to rav1d-rs, which need cleaning up via history rewriting and either be turned into LFS files or removed)

@jprochazk I summarized my understanding of rav1d-rs in https://github.com/rerun-io/rerun/issues/7575 - feel free to edit/comment


GH-36913: [C++] Skip empty buffer concatenation to fix UBSan error

Rationale for this change
This is a trivial fix for a UBSan error in calls to ConcatenateBuffers with an empty buffer that has a null data pointer.
What changes are included in this PR?
Conditional call to std::memcpy based on whether the buffer's length is 0.
Are these changes tested?
Test added in buffer_test.cc.
Are there any user-facing changes?
No

Closes: #36913

Hi @sfc-gh-ebrossard and thank you for your contribution.

Please let me know if you'd like a test; I can add one to buffer_test.cc. I'm not sure if there are automated UBSan runs for Arrow unit tests.

Yes and yes. You'll find a "AMD64 Ubuntu 22.04 C++ ASAN UBSAN" CI job below.

The Windows 2019 build failure is unrelated and appears on other PRs.


fix the Feature Gates status

I checked https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L25, update all features status which contains word v1.12.

Thanks for the quick fix.
This change reminds us that there are quite a few new features introduced (alpha) but not documented. Would be good to file some issues for tracking.
/lgtm
/approve


Google OAuth 2.0 with IdentityResource fails

The identity_resource option assumes there will be a uid field that is not nil.
Google's is nil in my tests.
Since the resource is defined by ash_authentication more than my app I don't know quite what to do here.

Changing this line to include "id" as an option seems to work:
https://github.com/team-alembic/ash_authentication/blob/486a3989d5164097867b5e517a65797de25db7a6/lib/ash_authentication/user_identity/upsert_identity_change.ex#L34

New error after the above fix:
%Ash.Error.Invalid.NoPrimaryAction{resource: Knowb.Accounts.User, type: :read, changeset: nil, query: nil, error_context: [], vars: [], path: [], stacktrace: #Stacktrace<>, class: :invalid}

The NoPrimaryAction had all the info I needed at least. A default action on the User resource got me through.
I have no idea if the uid/sub/id fix would be the right thing. But it seems like it would work.

https://github.com/team-alembic/ash_authentication/pull/481

Closed by #481


chore: exclude benchmark files

Hello,
When looking for "bbcode language:javascript" in github search box, I did not find this awesome library at first glance, as it wasn't in the list. Turns out that the exclusion for linguist wasn't working well.
before:

after the pr, tested in my forked repo:

Hope it helps.;)

Thank you for your contribution!