Child benefit tax calculator is missing pre-tax pension contribution field

[ I haven't yet added/updated any tests for this until someone else confirms if the field should be there :) ]
Not sure why I didn't notice this with #129, so perhaps I have misunderstood something! But there doesn't appear to be any field on https://www.gov.uk/child-benefit-tax-calculator/main for entering pension contributions made before tax. As it says on https://www.gov.uk/guidance/adjusted-net-income, "Take off any tax reliefs that apply like: payments made gross to pension schemes - those that have been made without tax relief".
But both the pension fields in the calculator are for post-tax pension contributions, either from your pay packet ("Pension contributions deducted from your pay (don't include contributions deducted before tax)"), or private contribution ("Pension contributions not paid from your salary (the amount you actually paid, not the grossed-up amount)").

ping, can I get an acknowledgement of this?

Hi @dracos - really sorry for not acknowledging this earlier. We're trying to find a subject matter expert to check this change is ok. Will get back to you as soon as we know more.

@dracos hi 👋  so we've asked the content team who know the department (DWP I think) to ask them to double check, but they may not get back for a while. Hope that's ok with you.

@dracos Hi, I've just heard back from the subject matter expert for this content, who says the tool is working as it should and doesn't need updating. Their reply in full:
"We think the calculator doesn’t need any changes (there’s no issue with it). On the question of what to enter for pension contributions made before tax:
• If they are paying directly in to a pension scheme that operates under the Relief at Source (RAS) scheme then they would enter the amount they actually pay in to the box that says ‘Pension contributions not paid from your salary (the amount you actually paid, not the grossed-up amount). The calculator grosses up the amount for Adjusted Net Income (ANI) purposes.
• If they are paying directly in to a pension scheme out of their net pay because the employer doesn’t operate the ‘net pay arrangement’ but the pension scheme operates under the RAS scheme then they would enter the amount they actually pay in the ‘Pension contributions deducted from your pay’ box (don't include contributions deducted before tax)’.The calculator then grosses up the amount for ANI purposes.
• If they are paying in to a Retirement annuity contract - there’s a box for that.
There isn’t a box for pensions paid under the net pay agreement (e.g. civil servants), and there doesn’t need to be.
The calculator was really tested when it was introduced for all these type of scenarios."
I hope that's ok. Let us know if there are any further issues with this.

Closing this PR given the above response.
Thanks @JamesButlerGDS for chasing this. Thanks again @dracos and for raising and for your patience.

So just to be totally clear, you are saying that you should enter pensions contributions made from your salary before tax should be entered into a box that is labelled "Pension contributions not paid from your salary".
Am I really the only one who can see an issue with this?
If you are saying that pre-tax pension contributions from your salary should be entered into that box, then I suggest you change the wording to not saying the exact opposite!

Surely "pension contributions not paid from your salary" is for private pensions, because that would be a pension contribution that isn't coming from your salary.
Also, if your pension contribution is taken out before tax, then it doesn't need to be grossed up. So why should I have to work out my net contribution (rather than gross) to enter into a form in order for it to be grossed up again? Why can't I just have a box where I can enter the gross amount directly?

Look, here is a hypothetical person who earns £20,000 in employment. They, for reasons unknown apart from this comment, pay £1000 pension contribution before tax, another £1000 different pension contribution post tax (to a pension that operates relief at source), and then out of their take-home packet contribute £1000 to a third pension.
So on the child benefit form, what do they enter in the two pension boxes?
"Pension contributions deducted from your pay (don't include contributions deducted before tax)" - that's easy, that must be £1,000.
"Pension contributions not paid from your salary (the amount you actually paid, not the grossed-up amount)" - reading that, surely that is also £1,000.
Now I have nowhere to put the third £1,000.
Your response is saying that for some reason they have to calculate that their pre-tax salary contribution £1000 gross is £800 net, so they then have to enter £1,800 into the second box?
Please consider reopening this issue, or please explain to me my misunderstanding about the above scenario, thank you :)

Ah, I think I have understood my misunderstanding. When it says
'payments made gross to pension schemes - those that have been made without tax relief" on https://www.gov.uk/guidance/adjusted-net-income it means, for those payments that have been made without tax relief, include the payments made gross.
It doesn't mean include "payments made gross to pension schemes" which should not be included at all!
Okay, sorry, I think that page could be clearer then
My apologies for going on a bit there, before the penny finally clicked.

No, sorry, I'm back again. How could someone's pension taken before tax not count towards their adjusted net income? The page starts with
What adjusted net income is
Adjusted net income is total taxable income before any Personal Allowances and less certain tax reliefs, for example:
trading losses
donations made to charities through Gift Aid
pension contributions paid gross (before tax relief)
pension contributions where your pension provider has already given you tax relief at the basic rate

So surely you have to account for the pre-tax pension contribution to calculate the net income? Could you please explain this?

Thank you :) I guess my question can be summed up as: "If I make a payment into a pension before tax direct from my salary, such as the first bullet point on https://www.gov.uk/tax-on-your-private-pension/pension-tax-relief –  "employer takes workplace pension contributions out of your pay before deducting Income Tax" – then how do I enter this figure into the child benefit calculator in order that my correct adjusted net income is calculated". Adjusted net income, by the Income Tax Act definition, is net income minus extra deductions for relief at source pensions and charitable giving. You have to therefore start with your net income, but the child benefit calculator does not provide the means to produce the correct net income for someone with a pre-tax pension contribution because there is nowhere to enter this figure (to be subtracted from the gross salary figure). Again, apologies if I have misunderstood this, but I think I have read everything correctly.

Hi @dracos.
I've had the following from the dept, as a suggested content fix - basically rearranging and relabelling some of the fields in part 4 of the calculator.
To what extent would these changes address your concerns with the content?
I've requested that they provide an explanation of why the calculator itself works as it should (they are very confident that it is), and where any misunderstanding may be arising, but am still awaiting this.
Thanks,
James
child-benefit-calc.docx

Hi James, thanks for continuing to follow this up! Yes, the attachment looks clearer by separating out the income and deductions fields, bringing the two pension boxes together and making it more obvious that you should ignore pension contributions deducted before tax. So what is missing is the bit you are still awaiting (could perhaps be on another page linked or something I guess), for curious people like me, explaining why you don't include contributions deducted before tax anywhere.
Ooh, alternatively, does the "salary before tax" box actually mean "salary before tax but after the pre-tax pension contribution is taken" in which case I think that could still be clearer, as I don't think it's what most people reading that would put. I thought of that explanation after reading http://adviser.royallondon.com/technical-central/pensions/contributions-and-tax-relief/tapering-of-annual-allowance-for-high-incomes/ which does state "Unfortunately, HMRC's definitions of adjusted and threshold income tend to cause a bit of confusion because they start with something called 'net income'. A common sense meaning of this would be 'income after tax', but it's not. Net income in this context is all taxable income less various deductions. The most important (or at least the most common) of these deductions are member contributions paid to an occupational pension scheme, both money purchase and defined benefit, under the net pay arrangement. This is where the sponsoring employer of the pension scheme deducts employee contributions before deducting tax under PAYE." – they even then go on to say that normal people would take "salary before tax" to mean their top-line salary, not salary-after-pre-tax-pension-contributions-but-before-income-tax. So if that's a/the cause of the confusion, improving that field would help.
Hope that's perhaps helpful, and regardless, I look forward to the explanation, thank you :)

Hi again @dracos - I've heard back from the dept. Their response is that it might be helpful to link to an explanation of 'net income' such as https://www.gov.uk/guidance/adjusted-net-income
I'm not sure where they'd want this, though, as the page doesn't actually refer to net income at all - any suggestions from your end?
They also say that you're right in thinking that that the "salary before tax" box actually means "salary before tax but after the pre-tax pension contribution is taken". They think the link above will suffice to explain that, and say that as they haven't had any other complaints relating to this content, that (along with the reorganising in the .doc) is as far as they'd want to go in terms of changes.
I hope that's ok? As I say, any further pointers on clarity, esp for where best to put that link, would be appreciated!

Hi, I strongly suggest you do some user testing. I have just asked some of my work colleagues and 100% of them said they would enter their gross total salary in that box, without any deductions. I don't think anyone reading that page would take "salary before tax" to mean "salary before tax but after pre-tax pension contribution is taken", why would they?! There isn't an option for that on my payslip, which lists total, and then all deductions (pension, unpaid leave, National Insurance, childcare, student loan, etc). Raises yet more questions, e.g. do I deduct "National Insurance", does that count as a "tax" or not?
I don't think a link to that page will be anywhere near enough to explain this (firstly, because I doubt people will follow it, secondly because the page doesn't make it any clearer!); it needs to state, on the page, that it is not "salary before tax", which is, your total gross salary before any deductions, but something you have to work out based upon multiple figures in your payslip. Alternatively, you could do as I suggested at the start of this PR and ask for the pre-tax pension contribution figure, state that it is gross salary that should be entered, and do the calculation for them.
They haven't had any other complaints because presumably people are just putting in their total gross salary, getting the wrong result, and assuming it's the right answer…!

Hi again. I'm fighting your corner on this, and have requested that they provide text to clarify the label. This is going to be a much easier and faster fix than recoding the calculator, a move the dept insists isn't necessary. Please understand - that's not my view, it's theirs. I'm not in a position to tell the SME how the calculator works or should work. So the best thing for us to aim to do is to adjust the label so people can adjust their inputs accordingly.

Yes, and thanks very much for continuing to follow this up :) In the absence of being able to change the calculator (I did provide the PR to fix it though, so about the same as reordering it ;-) ), updating the label in some regard is certainly the next best thing :+1:

@dracos Hi again. Just to let you know, I've rearranged the form and relabelled some of the fields to try and improve clarity.
Preview available here: https://calculators-pr-patch-1.herokuapp.com/child-benefit-tax-calculator/main
It's with the dept now to check that it all makes sense and operates as expected.
Cheers,
James

Thanks, looks good, even if (as I know you're aware) makes it a bit more complex for the user :) Thanks for following this through.
(Just a note from your PR, I'm not a former employee :) ).

@dracos @JamesButlerGDS sorry that was my impression and I'm not sure where I got that from now...


Added recursive pathPrefix in contract options

closes #215
Added changes to allow user to supply path prefix in options and have it added to path recursively.

Damn - that was quick 🎉 Great to see this was q quick win

Codecov Report

Merging #258 (b42be24) into main (3fde3f6) will increase coverage by 0.09%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   58.95%   59.04%   +0.09%
==========================================
  Files          20       20
  Lines         441      442       +1
  Branches      111      112       +1
==========================================
+ Hits          260      261       +1
  Misses        170      170
  Partials       11       11

Impacted Files
Coverage Δ

libs/ts-rest/core/src/lib/dsl.ts
89.47% <100.00%> (+0.58%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Wow that was quick! Super impressed how you navigated around this one so quickly!


PLFM-7030: Worker for indexing forum discussions

Depends on https://github.com/Sage-Bionetworks/Synapse-Stack-Builder/pull/442


Add "configuring calico/node" guide

calico-cni, calicoctl, and k8s-policy have a configuration guide.
Calico-node could use one as well.

Probably some overlap with #280


Ctrl+C does not cancel command in ZSH terminal

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Flatpak VSCode
OS Version: Fedora Linux 40

Steps to Reproduce:

    "terminal.integrated.profiles.linux": {
        "zsh": {
            "path": "/usr/bin/flatpak-spawn",
            "args": ["--host", "--env=TERM=xterm-256color", "zsh"],
            "overrideName": true,
        }
    },
    "terminal.integrated.defaultProfile.linux": "zsh",

Ctrl+Z is not working either

My only solution was to switch to the traditional repository, so I did that. The flatpak had this issue for me.

/duplicate #184713

The issue #184713 is clearly for MacOS, but this problem occurs on Linux.

also on linux https://github.com/microsoft/vscode/issues/184713#issuecomment-2233997952


Create a skeleton for the METS reader

What is this PR trying to achieve?
Part of #1810. This sets up a Scala skeleton for a new METS reader application, and gets it running and tested in Travis. Adding useful functionality can come in a separate PR.
Who is this change for?
🎿 🇸🇻

The only failure is what looks like a broken cache in the sierra_adapter common lib, which I propose to essentially ignore as expiring all the caches will slow our builds down for the rest of the day.


buffer / stream issue - upgrading to current imagemin version

In older version of imagemin I was able to pass the module a stream / buffer like this
new ImageMinify().src(StreamOrBuffer).use(ImageMinify.jpegtran({progressive: true}))
In the current version of imagemin there is no src function and calling the module will result in a promise.
I could not find how to achieve the same result in newer version of imagemin
Could it be done or that the support was removed?

You can supply a buffer using imagemin.buffer. Streams has never been supported.

@kevva thanks!


Add path option to SABnzbd component

Description:
Adds an optional path setting to the SABnzbd component. This allows support for SABnzbd installs that use a different url_base (typically a reverse proxied configuration; see https://sabnzbd.org/wiki/configuration/2.3/special).
This change passes the path along to pysabnzbd as its web_root, which in turn uses the path to build up it's api URLs.
Rebased on top of dev now after #23846
Related issue (if applicable): #23846 which was approved/reviewed by @MartinHjelmare
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10124
Example entry for configuration.yaml (if applicable):
sabnzbd:
  path: /sabnzbd

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Looks like the CI builds and checks ran for an hour and exceeded the maximum time...re-run it perhaps?

Hi @cj-thornton,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Thanks!


Move exercises into folder. Closes #46

Whoops! Should I have done this first?

@jwood803 No you shouldn't have, this is fine. I'll rebase this.

@jwood803 There is some newline issue with the largest series product file. I'll look into it later.

@jwood803 I fixed the newline issue. It is now ready to be merged I think.

@jwood803 Could you take a look at this? Or perhaps I can also be added as a contributor? :angel:

@jwood803 Great!


WebView2: Update documentation for 1.0.1210.30

Docs Build status updates of commit 43c2b0b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

1-0-1210-30/icorewebview2.md
:warning:Warning
View (webview2-1.0.1210.30)
Details

1-0-1210-30/icorewebview2environmentoptions.md
:warning:Warning
View (webview2-1.0.1210.30)
Details

1-0-1210-30/icorewebview2windowfeatures.md
:warning:Warning
View (webview2-1.0.1210.30)
Details

1-0-1210-30/icorewebview2framepermissionrequestedeventhandler.md
:bulb:Suggestion
View (webview2-1.0.1210.30)
Details

1-0-1210-30/icorewebview2permissionrequestedeventhandler.md
:bulb:Suggestion
View (webview2-1.0.1210.30)
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

1-0-1185-39/icorewebview2.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_10.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_11.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_12.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_2.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_3.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_4.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_5.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_6.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_7.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_8.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_9.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2acceleratorkeypressedeventargs.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2acceleratorkeypressedeventhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2addscripttoexecuteondocumentcreatedcompletedhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2basicauthenticationrequestedeventargs.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2basicauthenticationrequestedeventhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2basicauthenticationresponse.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2browserprocessexitedeventargs.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

This comment lists only the first 25 files in the pull request.

1-0-1210-30/icorewebview2.md

Line 1128, Column 66: [Warning: file-not-found - See documentation] Invalid file link: '[https://developer.mozilla.org/docs/Web/HTML/Element/iframe'.
Line 1128, Column 134: [Warning: file-not-found - See documentation] Invalid file link: '[https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy](https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Security-Policy)'.
Line 1202, Column 59: [Warning: file-not-found - See documentation] Invalid file link: '[https://chromedevtools.github.io/devtools-protocol/tot](https://chromedevtools.github.io/devtools-protocol/tot)'.
Line 1388, Column 183: [Warning: file-not-found - See documentation] Invalid file link: '[https://chromedevtools.github.io/devtools-protocol/tot](https://chromedevtools.github.io/devtools-protocol/tot)'.

1-0-1210-30/icorewebview2environmentoptions.md

Line 64, Column 173: [Warning: file-not-found - See documentation] Invalid file link: '[https://www.chromium.org/developers/how-tos/run-chromium-with-flags](https://www.chromium.org/developers/how-tos/run-chromium-with-flags)'.
Line 90, Column 233: [Warning: file-not-found - See documentation] Invalid file link: '[https://www.iso.org/iso-639-language-codes.html](https://www.iso.org/iso-639-language-codes.html)'.
Line 90, Column 308: [Warning: file-not-found - See documentation] Invalid file link: '[https://www.iso.org/standard/72482.html](https://www.iso.org/standard/72482.html)'.

1-0-1210-30/icorewebview2windowfeatures.md

Line 32, Column 79: [Warning: file-not-found - See documentation] Invalid file link: '[https://developer.mozilla.org/docs/Web/API/Window/open'.

1-0-1210-30/icorewebview2framepermissionrequestedeventhandler.md

Line 2, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Receives `PermissionRequested` events.' is duplicated in '1-0-1210-30/icorewebview2framepermissionrequestedeventhandler.md(2,14)', '1-0-1210-30/icorewebview2permissionrequestedeventhandler.md(2,14)'.

1-0-1210-30/icorewebview2permissionrequestedeventhandler.md

Line 2, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Receives `PermissionRequested` events.' is duplicated in '1-0-1210-30/icorewebview2framepermissionrequestedeventhandler.md(2,14)', '1-0-1210-30/icorewebview2permissionrequestedeventhandler.md(2,14)'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f423109:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

1-0-1185-39/icorewebview2.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_10.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_11.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_12.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_2.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_3.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_4.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_5.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_6.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_7.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_8.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2_9.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2acceleratorkeypressedeventargs.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2acceleratorkeypressedeventhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2addscripttoexecuteondocumentcreatedcompletedhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2basicauthenticationrequestedeventargs.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2basicauthenticationrequestedeventhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2basicauthenticationresponse.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2browserprocessexitedeventargs.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2browserprocessexitedeventhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2bytesreceivedchangedeventhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2calldevtoolsprotocolmethodcompletedhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2capturepreviewcompletedhandler.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

1-0-1185-39/icorewebview2clientcertificate.md
:white_check_mark:Succeeded
View (webview2-1.0.1185.39)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Raise exception when no free accounts pool

Hello, I would like to thank you for your project.
I encountered an unexpected issue where the methods hang in an infinite loop when there are no accounts available until a free account becomes available. This is a significant problem for me, and I need to handle such situations.
Could you please consider adding a setting that would change this behavior?
The API creation could look like this:
api = API(DB_PATH, raiseWhenNoAccount=True)
And the function responsible for getting an account would be like this:
async def get_for_queue_or_raise(self, queue: str) -> Account:
    account = await self.get_for_queue(queue)
    if not account:
        nat = await self.next_available_at(queue)
        raise NoAvalibleAccountException(f'No account available for queue "{queue}". Next available at {nat}')
    return account

Will be added in v0.12.
Usage:
from twscrape import API, NoAccountError

api = API(raise_when_no_account=True)
try:
    api.search("foo", limit=10)
except NoAccountError:
    pass

Or with environment variable:
TWS_RAISE_WHEN_NO_ACCOUNT=1 twscrape tweet_details<PHONE_NUMBER>163110904


requests 2.5.1 dependency

I've been testing this with requests==2.4.3 succesfully, is there a reason you specifically need 2.5.1?
If this is ok, would like to request to make the dep requests >= 2.4.3, <=2.5.1 ?

No reason at all. 2.5.1 was latest at the time. Let's lower req to 2.4.3 then

:+1: great thanks @swevm , maybe even requests >= 2.4.3 that way 2.4.3 or 2.5.1 can be used.


fix(img_link)

updated img link with iiif-dev

I changed this as iiif one is not working on our editor. when i check with img link obtained from bdrc, i noticed the different and hence the change.

ah I see what's happening... It should work now if you log out and log in again from BDRC if you use iiif. Please report that kind of issues instead of implementing workarounds

Sure @eroux, I will roll back the changes. I will keep that in mind.


fsck: only decrypt when needed

Summary
gopass fsck pessimistically decrypts all passwords, which is inconvenient if decrypting each password requires intervention (e.g. Yubikey GPG touch-to-decrypt).
Steps To Reproduce

Use a Yubikey GPG key in "touch-to-decrypt" mode.
Have a repo with N passwords, 1 of which has a fsck issue: bad.example.com
Execute gopass fsck

Expected behavior
I am prompted once, to decrypt bad.example.com
Actual behaviour
I am prompted 500 times, to decrypt each password.
Per https://github.com/gopasspw/gopass/blob/330d23da287b5de0590db069e49657b1e9280ee0/pkg/store/sub/fsck.go#L48-L49 , gopass fsck will pessimistically decrypt each password because it figures if it can't decrypt, it cannot fix the issue, so it may as well exit-early. This is reasonable logic, but doesn't account for if decrypting is expensive. Perhaps a flag "--no-eager-decrypt" (or some such) could only prompt for a decrypt if it knows it needs to do this.
Environment

OS: NixOS 19.09
OS version: 4.19.114 #1-NixOS SMP
gopass Version: 1.8.6
Installation method: NixOS package manager

An alternative solution would be to have gopass fsck (no flags) not perform decryption, but instead check that the GPG keyring contains the decryption key.
Though this is convenient for me, I oppose it, because gopass fsck that actually performs the decryption is a useful check, and is useful and appropriate for most users (who don't have touch-to-decrypt).

Workaround: Delete https://github.com/gopasspw/gopass/blob/330d23da287b5de0590db069e49657b1e9280ee0/pkg/store/sub/fsck.go#L50-L53 and re-build.


Update Podman Desktop E2E and playwright E2E workflow

We need to migrate this workflow from my fork to an upstream fork. Now it is working well after Adrian supported an WSL installation.

Fixed by #47


Use property bindings instead of signals in the sync_widgets example

Cool, I don't know about this possibility.
👍

I didn't know about it either. Thanks!


How can I download pre-trained model if I can't register on baidu?

I want to download the pre-trained model, but I don't have a Chinese mobile phone number so I can't create an account of baidu. Can you upload it to google drive ?

Hi, you can find the models from the direct link of github, like:


support for opening the repo in gitpod

What kind of changes does this PR include?

Something else!

Description

Closes #1750
What does this PR change? Please refer to the issue.
Did you change something visual? NO

Participating in HACKTOBERFEST

Ha! I have done this myself on the branch I'm currently using regularly!  ;)
We're going to have to check with the team on this though, since many do use Gitpod at least some of the time, whether this is the action they want. We've purposely ignored that file so that people don't commit back their own custom gitpod.yml setups.

Hi @naveennamani! We finally had a chance to discuss this, and I think your Gitpod defaults look good, so let's get this merged!  🥳  (I also just opened a branch on the repo without a gitpod.yml for the first time in a while, and was reminded how helpful this was going to be!)  Thanks so much for this contribution, and welcome to Team Docs!  🚀

Thank you @sarah11918 for your prompt response and support. Looking for opportunities for more contributions.
Have a good day :)


How can i create x12 messages from clr objects?

First of all thanks for creating this project! It looks awesome!
I played around with the code, and it seems that the API is all tailored around parsing existing formatted messages into clr objects.
I'm wondering how to go about creating a well formatted  x12/hl7 message from clr types.
Is that possible?

That hasn't been a focus at this point, to be honest. Right now, it's around parsing and processing data - the primary use case is reading data from systems for analytics purposes, versus generating valid HL7 or X12 output. The formatting will come around eventually, as will the ability to create the components, segments, etc. but that isn't where most of the work is being done at present.
@ahives can give more details around that aspect.

So, the eventual goal is to be able to do this. But as @phatboyg said our current focus really is on getting the parsing engine solid, then we will build out from that. We have a few open issues around Layouts, which are basically POCOs. Once this work is done we will beef up the formatting and translator functionality. Some of that is already done, but, it needs to be extended to support POCOs (i.e. Layouts, segments, etc.). Once done though, you will have the ability to create your own POCOs (Layouts, segments, components, etc.) using the Translate API and then format it to text, which would give you a string HL7/X12 message. This will definitely be there when we rev the package to stable as it is a core use case.

Thanks @phatboyg and @ahives for your prompt reply.
I guess I'll be waiting around until I can start to use it for this purpose.
Thanks again!


Create nth_Ugly_Number.cpp

Created nth_Ugly_Number using C++
Assigned Issue Number?
#221
Language Opted?
C++
Number of files added or updated?
1
Name of these files?
Algorithms => DP => nth_Ugly_Number => nth_Ugly_Number.cpp
Checklist

[x] I was assigned for this otherwise my PR will be rejected.
[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've filled up this entire template correctly.

:star2: this repository and support.

Please review my PR @krishrahul98


Documentation for Flow Exporter feature

This PR will be merged after PR#825 and PR#836.

The doc should include a link to @zyiou's doc about ElasticStack, once we merge #836

Actually, we are planning to merge both into one doc depending on whichever PR goes first.

Thanks for the review. Addressed the comments.

/test-all

/test-conformance

/test-e2e
/test-networkpolicy
/test-windows-conformance

/test-all

/test-all

/test-windows-networkpolicy

/test-all

since this PR only changes text files. i don't think we require testing all jobs. you may use skip-all to skip the tests

/test-all

since this PR only changes text files. i don't think we require testing all jobs. you may use skip-all to skip the tests

Yes, I thought of that, but just wanted to run those again in case if there are intermittent failures in any e2e test.

There was a failure in jenkins-e2e test because of a timeout in realizing test podIP. Following tests fail too while waiting for podIP.
basic_test.go:643: Creating Pod 'test-pod-znzmlwt7' on 'antrea-e2e-for-pull-request-1061-md-0-57f5f9ddb7-4lns7'
    basic_test.go:656: Error when waiting for IP for Pod 'test-pod-znzmlwt7': timed out waiting for the condition
    fixtures.go:244: Deleting Pod 'test-pod-znzmlwt7'

Does not seem to be related to any new features.
/skip-all

/skip-all

@srikartati line not wrapped?

Yes fixed it.

/skip-all


Associate Security group to AWS Load Balancer

NLB now supports Security groups and can enable security groups on NLB by using AWS Load Balancer controller version 2.6.0 or later.
But unable to associate security group to nlb created through this module by adding below annotation.
   {
      name  = "controller.service.annotations.service\\.beta\\.kubernetes\\.io/aws-load-balancer-security-groups"
      value = "<sg-name>"
      type  = "string"
    }

It's not throwing any error, but this section is completely ignored and we could see in the console that there is no security group associated to the newly created NLB.

Is there any chance to get a solution for this?

Hi, @vijayreddiar it could be potential problem with AWS.
Have you checked is this annotation exsits in ingress-controller service ?

@vijayreddiar BTW, this module does't deploy AWS LoadBalancer controller, becuase this annotation which you provided only for this type of controller.
Module deploys this controller: https://kubernetes.github.io/ingress-nginx/

You check the docs which is for AWS Load Balancer ingress controller. This docs is not suitable for this ingress controller.
You have to find annotation for k8s service with type loadbalancer. It's even not related to ingress, just k8s service with type LoadBalancer

Thanks, this issue stands resolved.
We had deployed aws-load-balancer-controller helm chart of version 1.5.3 which is now upgraded to 1.6.1 that uses aws-load-balancer-controller  v2.6.1


Add privateKeyPassword option for private key decryption

Introduces the privateKeyPassword option, enabling users to define the password for decrypting encrypted private keys.
The option is ignored if privateKey is not set, or if it is an instance of crypto.KeyObject

closes #45

One more thought for you: do you think it would make sense to allow a string or a function that returns string for privateKeyPassphrase? That would allow a function to retrieve that data from a secure vault or environment variable of some sort.
Thank you for the more complete tests.

@shunkica , I was just looking back at some PRs to see if we could get them landed. Let me know what you think about my last comment.

@shunkica , I was just looking back at some PRs to see if we could get them landed. Let me know what you think about my last comment.

Sorry this is not something I have bandwidth for right now. If you have time to implement it go ahead.


Safe For Concurrent Runs?

Looking to use this for replacing tgenv/tfenv in atlantis but wondering if anyone has done this yet and if its safe for concurrency (multiple versions, multiple concurrent runs)? This was an issue early on with those other projects which was fixed in an eventual refactor. Thanks for making this project!

Closing due to inactivity


Update documentation of statuses

Hi, I have received status: 5 from kaldi gstreamer, which is not mentioned in the documentation. I think it has something to do with the encoding, but can you please provide a comprehensive list of statuses that can be returned along with their meaning?

If it helps, I can see from the code that status code 5 (STATUS_NOT_ALLOWED) is returned whenever an error is reported on the websocket between the worker and the master.
You probably want to look at the worker logs to get more information.


“require is not defined” : how to be able to use "import" and / or use "require"?

Following this example: https://github.com/RedisGraph/redisgraph.js/blob/master/examples/redisGraphExample.ts I tried to include redisgraph in my Electron-Typescript-React-Webpack app with const RedisGraph = require("redisgraph.js").Graph; in the react page but got require is not defined.
This is my tsconfig.json :
{
  "compilerOptions": {
    "target": "esnext",
    "module": "commonjs",
    "lib": ["dom", "es2015", "esnext"],
    "outDir": "dist",
    "jsx": "react",
    "baseUrl": "./src",
    "paths": {
      "@sections/*": ["app/sections/*"],
      "@app/*": ["app/*"]
    },
    "strict": true,
    "sourceMap": true,
    "skipLibCheck": true,
    "noImplicitAny": false,
    "noImplicitThis": false,
    "moduleResolution": "node",
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "resolveJsonModule": true,
    "allowJs": true
  },
  "include": ["src/**/*"],
  "exclude": [
    "src/index.js",
    "dist",
  ]
}

I've put in type.d.ts  :
declare module RedisGraph {
  require("redisgraph.js").Graph
}

But this is not sufficient and/or ok.
How to make require available in the react page, or how to use import for this module ?

import { Graph } from 'redisgraph.js' should do the trick

Hi @leibale !
Thanks for helping.
If I put
import { Graph } from 'redisgraph.js';
let graph = new Graph("notes");

I get the error message require is not defined

please take a look at https://www.electronjs.org/docs/tutorial/quick-start#nodejs-api

I get the error require is not defined in runtime.
https://www.electronjs.org/docs/tutorial/quick-start#nodejs-api : this is what I've done:
I installed redisgraph.js with yarn add github:RedisGraph/redisgraph.js.git
and then required the module
const RedisGraph = require("redisgraph.js").Graph;

But I get at the runtime: require is not defined

I tried to do with resisgraph.js what I've done with sqlite3 in webpack.config.js :
const sqlite3 = require('sqlite3');
const RedisGraph = require("redisgraph.js").Graph;

    externals: [
      {
        'utf-8-validate': 'commonjs utf-8-validate',
        bufferutil: 'commonjs bufferutil',
      },
      {
        'sqlite3': sqlite3,
      },
      {
        'RedisGraph': RedisGraph,
      }
    ],

But when I start the app I get this error:
yarn start
yarn run v1.22.5
$ yarn run build && electron ./dist/main/main.js
$ npx webpack --config ./webpack.config.js
[webpack-cli] Invalid configuration object. Webpack has been initialized using a configuration object that does not match the
API schema.
 - configuration[1].externals should be one of these:
   [RegExp | string | object { byLayer?, <key>: [non-empty string, ...] | boolean | string | object { … } } | function, ...] | RegExp |
string | object { byLayer?, <key>: [non-empty string, ...] | boolean | string | object { … } } | function
   -> Specify dependencies that shouldn't be resolved by webpack, but should become dependencies of the resulting bundle.
The kind of the dependency depends on `output.libraryTarget`.
   Details:
    * configuration[1].externals[2]['RedisGraph'] should be one of these:
      [non-empty string, ...] | boolean | string | object { … }
      -> The dependency used for the external.
      Details:
       * configuration[1].externals[2]['RedisGraph'] should be an array:
         [non-empty string, ...]
       * configuration[1].externals[2]['RedisGraph'] should be a boolean.
         -> `true`: The dependency name is used as target of the external.
       * configuration[1].externals[2]['RedisGraph'] should be a string.
         -> The target of the external.
       * configuration[1].externals[2]['RedisGraph'] should be an object:
         object { … }

But if I require in the main process :
const RedisGraph = require("redisgraph.js").Graph;
let graph = new RedisGraph("notes");

I get this new error:

Thank you @leibale for your kind help
I close the issue, since now the problems I'm facing seem to be related to the connection to Redis


Scroll-top added in projects section

Fixed issue #1179
Added scroll-top in projects section
Screenshot:

@Vishal-raj-1 @urvashi-code1255 @harshgupta20 @ridsuteri @991rajat Please view my PR

Great. Keep Contributing.


[DRAFT] Fix Storage engine sonar

coverage: 44.531% (-0.03%) from 44.563% when pulling 6f6a46f818ce32cafc2da478f7289080ddd8e50a on storage_engine_sonar into 30018f2d53034637db13c402275302b1162a22f2 on master.


W boson and top tagging paper

Came across this one that can be added as well:
http://cdsweb.cern.ch/record/2259646

We should add pub notes to this listing. By their nature they aren't intended to have a paper as a followup, but they are of far higher quality than the majority of the papers listed here.

@matthewfeickert, these notes might not have an INSPIRE link but I think we have little choice but to break that convention in this case. Any survey of modern machine learning techniques in high energy physics should certainly include references to what experiments are actually using. Unfortunately there are very few cases where the collaborations publish externally reviewed papers.


GO:0016226 & GO:0006790

Should GO:0016226 iron-sulfur cluster assembly be related to GO:0006790 sulfur compound metabolic process ?
Cheers

@deustp01 : any thoughts on whether incorporation of sulfur into a metallo-sulfur cluster qualifies as sulfur metabolism?  I'm leaning towards 'no.'  Thanks.

the sulfur is derived from cysteine (this seems to be conserved across different organisms)

Piling on here, the abstract of PMID:15952888 says, "Formation of intracellular [Fe-S] clusters does not occur spontaneously but requires a complex biosynthetic machinery. Three different types of [Fe-S] cluster biosynthetic systems have been discovered, and all of them are mechanistically unified by the requirement for a cysteine desulfurase and the participation of an [Fe-S] cluster scaffolding protein." And cysteine desulfurase activity is an aspect of cysteine metabolism and ChEBI:17561 L-cysteine is-a CHEBI:33261 - organosulfur compound

Thanks, both of you!  I am now more educated on this process and will make a link between the two terms.

+is_a: GO:0006790 ! sulfur compound metabolic process


Override-based inference succeeds when multiple setters have different types

abstract class A {
  set x(num x);
  set y(int x);
}

abstract class I {
  set x(int x);
  set y(num x);
}

class B extends A implements I {
  var x;
  var y;
}

Override-based inference should inferring a type for both B.x and B.y. This is because both fields are constrained by two setters with different types. However, my new implementation fails to flags B.x as an error.

This could potentially be solved by adding another bit to KernelFieldBuilder which could be named something like hadTypesInferredFromSetter.

/cc @stefantsov


Fix the alignment of the content on the Mobile Screen size version of the "Donate" page

(From Debbie Berlin):

I am researching a solution.
It seems to relate to github issue:
"nav bar logo not mobile friendly #47"
nav bar logo not mobile friendly · Issue #47 · civictechdc/civictechdc-website


Nothing seems to run from steam

First issue is most launchers (Itch and Rockstar seem to be the exception) won't even download without using the option "Seperate app ids"
The next is nothing will run from steam afterwards. I can't even change the proton version it's using. The tickbox in compatibility isn't selectable. Same issues in both desktop and game modes.

After a few retries I was able to get Battle Net to work. No clue at all what was going wrong.

@mightyflub weird ill take a look and see what going on thanks for letting me know

The tickbox in compatibility isn't selectable.

Definitly the problem - this tickbox must definitely be checked. I think, this is a weird bug in Steam. I had the same issue, but it fixed itself by restarting Steam once again.

@pnhofmann that's a steam bug that has been for a while. You can't run non steam games or laun hers without selecting a force compatability tool, if you did it "Grey's out" the check box till you restart steam


Improve ode

Codecov Report
Attention: Patch coverage is 98.43137% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 99.33%. Comparing base (39608cb) to head (4ad6cbe).
Report is 348 commits behind head on main.

Files
Patch %
Lines

russell_ode/src/euler_backward.rs
94.00%
3 Missing :warning:

russell_ode/src/radau5.rs
93.33%
3 Missing :warning:

russell_ode/src/euler_forward.rs
96.15%
1 Missing :warning:

russell_ode/src/explicit_runge_kutta.rs
98.95%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   98.44%   99.33%   +0.88%
==========================================
  Files         102      131      +29
  Lines       20905    26860    +5955
==========================================
+ Hits        20580    26681    +6101
+ Misses        325      179     -146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


wait for breakpoints to be installed before resuming

thanks to @sigurdm for the fix!
@devoncarew

lgtm


[WIP] Continued GAT Refactoring

So far I have:

Removed Expr types from GAT defintions
Began separating code geration and theory creation
Made code generation only dependent on a theory object

To remove dependency of any of the raw macro head/body objects for the code generation, I added the theory name to the theory struct. I'm not sure if this is the best way, I was also thinking it might make sense to not have it store a name and the code generation struct would just also take in a name possibly. Having anonymous theories I think will be valuable down the line when we want to start doing pushouts and things with GAT of GATs

I agree, eventually we'll want to be able to manipulate theories anonymously, but I think this is fine for now if it simplifies the refactor.

@epatters, there has been a ton of work since this was originally written, do we still want this refactoring code?

Unfortunately this got stale because Micah had higher-priority work to do. I'll close for now, but I may refer to this when I finally get to the GAT refactoring myself.


POV-Ray heuristic: #declare

Add heuristic for .inc files: the #declare keyword seems to be unique to POV-Ray.
Fixes #3150.

There should be a test!

@arfon Rebased, made Travis happy.

👍


We remove ini files from our iterated list that are not part of the d…

…s to be run.
Things To Remember:

Be sure to merge into the right branch. The choices are:

master if your PR runs on the current version of Tableau.
dev-2021.2

You should update at least one of the following:

The changelog of the project you modified.
The root README.md if the PR is a release of the SDK, Connector Packager, or TDVT.
=====

Hi, @tabsdavis! Thanks for opening this PR!

In the file tdvt/tdvt/config_gen/datasource_list.py:

Line 380:32: E231 missing whitespace after ','
Line 366:29: F405 'get_ini_path_local_first' may be undefined, or defined from star imports: ..resources

For reference: Error Code Reference, PEP8, Python code style


Add JAVA_HOME to the PATH

...to temporarily fix travis-ci/travis-cookbooks#875

We were trying to test these changes in staging but ran into some issues getting a test job to actually run in staging. We'll come back to this next week.

Tested and seems to work on staging: https://staging.travis-ci.org/kdaniels/obstinate-otter/jobs/615393#L429


Fix ERC-20 example

This fixes the URL of the repository in the instructions.
This also adds gasLimit and gasPrice parameters to the deployment script
in order to avoid Error: cannot estimate gas; transaction may fail or may require manual gas limit
gasLimit = 30M was chosen based on the documentation:
https://docs.bitfinity.network/evm/opcodes#gas-limit
gasPrice = 10 is the minimum accepted gas price.

@alexriet, @itsyaasir: would you mind taking a look?

Thanks Ulan, merged.


Error running on WSL2

Hi!
I can't run using the IntelliJ on Windows with all environments set to WSL2, it doesn't happen if I use a simple test with JUnit.
Error running 'FakeTempGisModelTest': Cannot run program "\wsl$\Ubuntu\home\pac.asdf\installs\java\adoptopenjdk-8.0.345+1\bin\java" (in directory "\wsl$\Ubuntu\home\pac\git\avangrid-e3\avangrid-model"): CreateProcess error=193, %1 is not a valid Win32 application

I have got the same issue

wow,,, I have got the same issue too

Still doesn't work with WSL :(

A workaround could be that running the junit 5 instead of running them as kotest
See https://github.com/kotest/kotest-intellij-plugin/issues/170#issuecomment-1200103433


installation issue with installed with pip

Hi all,
I've tried to install bioscrape via pip, in a new virtual environment, but I got this error:

It looks like, it tries to install bioscrape without installing numpy first. Maybe the order of dependencies needs some tweaking in the setup.py
Steps to recreate the problem:
mkdir  test_bioscrape
cd test_bioscrape
python -m venv ./venv
source venv/bin/activate
pip install bioscrape

Thanks! I will take a look.

Thanks! I will take a look.

@zoltuz I believe I fixed this issue, could you please check?

@zoltuz I believe I fixed this issue, could you please check?

yep, the installation works now:

yep, the installation works now:


fix(libscap): set openat dirfd parameter to 0

Signed-off-by: Luca Guerra<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
I was hitting this assertion when building in debug mode:
falcosecurity/libs/userspace/libsinsp/event.cpp:1429: std::string sinsp_evt::get_base_dir(uint32_t, sinsp_threadinfo*): Assertion `dir_param_info->type == PT_FD' failed.

I traced it to an issue when parsing the openat entry event. This patch fixes it.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

fix(libscap): correctly parse dirfd on openat entry

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: LucaGuerra
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @LucaGuerra. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Great catch man! :heart_eyes:
/ok-to-test

LGTM label has been added.  Git tree hash: 78c02c75f2a50aa34d867131d206da6b20c6975b

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Clean up grammar, make skip behavior clearer, fix certain inconsistencies with HyperWaveCHIP-64, etc.

Also modifies 5XY1 to be > and NOT >=, as this breaks HyperWaveCHIP-64 compatibility. instead, 9XY1 has the =< behavior.
Also specified Division by 0 behavior to match HyperWaveCHIP-64's spec, and changed the "HPS Flags" to their actual name, the RPL flags.

On the current spec, the XO-Chip skip at only F000, while Fn00 is for Hyperchip,
this is only way to detect difference between XO-Chip and Hyperchip, without crash.
Had clarified the CHIP-8E's 5xy1 instruction through Emma02
Turns out it's indeed VX > VY. I'll apply the changes later on.
For elaborations of the other behaviors, it's should be not in this markdown, at least not yet.
It's supposedly summarize added opcodes in concise. I might do the proper revise someday.


(SURE-5510) Unable to upgrade an imported AKS cluster from Rancher GUI

https://jira.suse.com/browse/SURE-5510

I will triage this card

This issue is missing basic data with information on customer AKS cluster configuration. As I mentioned in https://jira.suse.com/browse/SURE-5510
I have tried to check out this problem on our site with Rancher v2.6.8 Azure AKS supported versions currently are
KubernetesVersion    Upgrades

1.25.5               None available
1.25.4               1.25.5
1.24.9               1.25.4, 1.25.5
1.24.6               1.24.9, 1.25.4, 1.25.5
1.23.15              1.24.6, 1.24.9
1.23.12              1.23.15, 1.24.6, 1.24.9
I did test upgrade from 1.23.12 to 1.23.15. Cluster was upgrade successfully.
What is missing for this bug is:
cluster.management.cattle.io YAML manifest from customer cluster
aksclusterconfigs.aks.cattle.io YAML manifest from customer cluster
Resource JSON from Azure Portal to customer cluster
Please provide us these information, otherwise we will be not able reproduce this problem on our site.

it is waiting for customer response

it is waiting for customer response

See SURE-5510 😉

Finally we have got at least part of configuration, so I am starting investigation

Currently on Rancher v2.6.8 I am getting following error during upgrading:
time="2023-03-05T16:57:14Z" level=error msg="error syncing 'cattle-global-data/c-xb46v': handler aks-controller: failed to update cluster: containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code=\"LinkedAuthorizationFailed\" Message=\"The client 'bb491dd0-5d05-40c3-970d-ba80d0cf072b' with object id 'bb491dd0-5d05-40c3-970d-ba80d0cf072b' has permission to perform action 'Microsoft.ContainerService/managedClusters/write' on scope '/subscriptions/f5e1bf9e-ec79-4fc5-8354-53e2fcc0d99f/resourceGroups/mjura-aks/providers/Microsoft.ContainerService/managedClusters/mjura-test2'; however, it does not have permission to perform action 'Microsoft.OperationalInsights/workspaces/sharedkeys/read' on the linked scope(s) '/subscriptions/f5e1bf9e-ec79-4fc5-8354-53e2fcc0d99f/resourcegroups/defaultresourcegroup-eus/providers/microsoft.operationalinsights/workspaces/defaultworkspace-f5e1bf9e-ec79-4fc5-8354-53e2fcc0d99f-eus' or the linked scope(s) are invalid.\", requeuing"


Handle tombstone in combined iterator and add tests

Codecov Report

Merging #1135 (2b25226) into master (99994b3) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
+ Coverage   47.28%   47.36%   +0.07%
==========================================
  Files         185      185
  Lines       14464    14474      +10
==========================================
+ Hits         6840     6856      +16
+ Misses       6725     6717       -8
- Partials      899      901       +2

Impacted Files
Coverage Δ

graveler/combined_iterator.go
76.11% <100.00%> (+19.97%)
:arrow_up:

catalog/mvcc/cataloger_commit.go
74.28% <0.00%> (-5.72%)
:arrow_down:

catalog/mvcc/cataloger_create_repository.go
59.25% <0.00%> (-3.71%)
:arrow_down:

graveler/committed/range_iterator.go

graveler/committed/unmarshal_iterator.go
68.00% <0.00%> (ø)

graveler/graveler.go
36.41% <0.00%> (+0.28%)
:arrow_up:

catalog/mvcc/cataloger_create_entry.go
100.00% <0.00%> (+5.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99994b3...2b25226. Read the comment docs.


Support not which is built-in predicate

Support not.
?- not(1 =:= 1).
false.

?- not(1 =:= 2).
true.

https://github.com/ArkArk/d-prolog/issues/40


⚠ Fetchers has degraded performance

In d7f64e8, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 245 ms

Resolved: Fetchers performance has improved in 60c9772.


move keyword completion functionalilty to core framework

Originally submitted to Google Code by bryan.oakley on 5 May 2009

I would like a method on a FileSuite object that can return a list of all
the possible keywords, taking into consideration libraries and whatnot. In
effect, I want a single call that can return all the information needed to
implement the keyword completion feature used in RIDE.
I assume this code already exists in RIDE, but I think it would be better
to move it into the core framework. This would make it easier to write
additional tools that manipulate robot test suites. For example, one could
easily build a tool that checks that all keywords used in a test file are
valid.
For example, to display a list of keywords valid for a file I would like to
be able to do something like this:
suite = TestSuite("foo.tsv")
print "all valid keywords for foo.tsv:"
for keyword in suite.valid_keywords:
    print keyword.name, keyword.args, keyword.description

I don't think this makes sense. Python packaging system has improved and keyword completing logic could be made available separately. We should rather try removing extra functionality from the core framework.


Use this project with OpenGL

Hi guys, first of all I want to thank you for this great project. Can I use OpenGL for this project?
if possible, how?
My English is not very good so I hope to hear from you. Thanks

Hi @quocviet8198
The visualizer uses only Android's canvas API.
https://developer.android.com/reference/android/graphics/Canvas
If you want it to be based on OpenGL, you will need to reimplement everything with OpenGL I believe.
https://developer.android.com/guide/topics/graphics/opengl
Which I think is more difficult than what I had done for this project. But it should be more powerful and performant.


zdbfs crashes when the underlying disk goes out of space

last logs from the qsfs container:
[     137.151184][-] data write: Quota exceeded
[-] cache flush: blockid mismatch
[-] fatal: segmentation fault
[+] blocks cache size: 4096 KB
[+] fuse: ready, waiting events: /mnt
[-] zdb: zdbfs-data: set: error: Cannot write data right now
0x4058c7: (zdbfs_system_sighandler+0x37)
0x43e8af: (sigprocmask+0x21)

This happen on a zos node, testing locally with a limit disk size doesn't crash zdbfs.

Which version do you use ? It should reoport Input/Output Error in this case and not crash.
Which files were you writing at that time ? Can you reproduce ?
Locally I try by mounting a small tmpfs and put zdb on, which will quickly reach No space left on device :)

zdbfs version is 0.1.10. I couldn't reproduce locally (created a limited disk, and it failed with an io error but didn't crash).
But it seems to happen consistently on zos nodes. This is what I was trying when it crashed: https://github.com/threefoldtech/quantum-storage/issues/19

zdbfs gdb's stack trace:
Program received signal SIGSEGV, Segmentation fault.
sdscatlen (s=0x7f329eea0f39 "*3\r\n$3\r\nSET\r\n$8\r\n\341\017", t=0x0, len=len@entry=131072) at sds.c:383
383     sds.c: No such file or directory.
(gdb) bt
#0  sdscatlen (s=0x7f329eea0f39 "*3\r\n$3\r\nSET\r\n$8\r\n\341\017", t=0x0, len=len@entry=131072) at sds.c:383
#1  0x00000000004290e9 in redisFormatSdsCommandArgv (target=target@entry=0x7fffb30f1fd0, argc=3, argv=0x7fffb30f2040, argvlen=0x7fffb30f2060) at hiredis.c:605
#2  0x0000000000429f0c in redisAppendCommandArgv (c=c@entry=0x7f329f240960, argc=<optimized out>, argv=<optimized out>, argvlen=<optimized out>) at hiredis.c:1118
#3  0x000000000042a059 in redisCommandArgv (c=0x7f329f240960, argc=<optimized out>, argv=<optimized out>, argvlen=<optimized out>) at hiredis.c:1170
#4  0x000000000040653a in zdb_set (remote=0x7f329f219570, id=id@entry=4065, buffer=<optimized out>, length=<optimized out>) at zdb.c:384
#5  0x0000000000401688 in zdbfs_cache_block_release (fs=0x7fffb30f2390, cache=0x7f329f219b60) at cache.c:555
#6  0x0000000000402222 in zdbfs_cache_block_release (cache=<optimized out>, fs=<optimized out>) at cache.c:635
#7  0x0000000000406f2f in zdbfs_fuse_release (req=0x7f329f240190, ino=<optimized out>, fi=<optimized out>) at zdbfs.c:1022
#8  0x000000000041d286 in do_release (req=<optimized out>, nodeid=<optimized out>, inarg=<optimized out>) at ../lib/fuse_lowlevel.c:1455
#9  0x000000000041f443 in fuse_session_process_buf_int (se=se@entry=0x7f329f219c20, buf=buf@entry=0x7fffb30f22d0, ch=ch@entry=0x0) at ../lib/fuse_lowlevel.c:2666
#10 0x000000000041fad7 in fuse_session_process_buf (se=se@entry=0x7f329f219c20, buf=buf@entry=0x7fffb30f22d0) at ../lib/fuse_lowlevel.c:2538
#11 0x00000000004096e6 in zdbfs_fuse_session_loop (se=se@entry=0x7f329f219c20, fs=fs@entry=0x7fffb30f2390, timeout=timeout@entry=1000) at zdbfs.c:1248
#12 0x00000000004011c3 in main (argc=<optimized out>, argv=<optimized out>) at zdbfs.c:1337


Test against rfc7749

In particular, see the set of changes from https://tools.ietf.org/html/rfc7749#appendix-B .

Having a reasonable test set in the first place would be brilliant (it would also be able to serve as a compatibility aid with future implementations of the same format).  I'll take this issue as a reminder to start building a test set.
Note that many of the changes in Appendix B actually have been in XML2RFCv2 for ages (kramdown-rfc2629 never has been a strict RFC2629 implementation).
Most of the new attributes that don't have explicit support in markdown can be accessed by an IAL.
(See also https://github.com/cabo/kramdown-rfc2629/wiki/Syntax for more details.)

While building a test set, we may as well also start adding support for v3: https://tools.ietf.org/html/draft-iab-xml2rfc-02
I have the beginnings of such a document here: https://github.com/hildjj/draft-iab-html-rfc/blob/master/example/test.3.xml; keep in mind that this is the input document, which needs to be "prepared" before it is fed to an output formatter, using the rules in https://tools.ietf.org/html/draft-iab-rfcv3-preptool-00.  The corresponding prepared XML is in https://github.com/hildjj/draft-iab-html-rfc/blob/master/example/test.x.xml


Forward port "Set axis background to transparent in inlinebackend"

See ipython/ipython/8336
Revert "Set axis background to transparent in inlinebackend"

This reverts commit 902c754fcbd0581ea33912e583cd3ccb8bdb9a5b.

Making axis transparent seem to confuse and annoy lot of people,

See #7964 (do not fix it, this will be a 4.0 or 5.0 thing),
the real fix would be to use matplotlib themes.

We already merged the PR against 3.x, so merging this.


[Test] Don't run EmptyCollectionSingletonRealization on older runtimes that aren't fixed.

rdar://problem/59590614

@swift-ci please smoke test and merge


Simple GLTF model problem

Hello,
I have been working with VRML and GlTf seems promising.
I am writing a converter from VRML to GlTF,but I think that there is something which I am doing wrong because I cannot even convert a simple VRML to GLTF (Please see the attached files,I including a simple vrml, and the coresponding the gltf/bin.
No validation error, but I always get index out of bounds for OGL DrawElement (Using Babylon.js sandbox viewer), and I am wondering what am I doing wrong.
Thanks in advance.
test.zip

Hello you should post it to the gltf repo:)
P


Improve download speeds for Cosmos Emulator

For some reason the Cosmos Emulator is taking a long time to download on Java hosts (>10 minutes) and very little time to download on Python and JS hosts (<1 minute)... These figures are anecdotal and collected from arbitrary samplings of the step run times.
We've seen several instances where Emulator tests have timed out in Java and have had to increase the timeout.

Done, download and start is now combined into one though. But we use the same logic from across Python, JS and Java.


metis

Adds a port for metis (http://glaros.dtc.umn.edu/gkhome/metis/metis/overview).
This is a dependency for parmetis (#430)

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

Looks solid, thanks!


[macOS Big Sur] Focus does not come back to the app after authorization at a browser.

Probably due to a specification change in Big Sur, the focus does not return to the app after the authentication flow during debugging, and the locally installed app launches.
If the app of the release version is not installed, the following modal shows.

I think this issue will resolve by using ASWebAuthenticationSession.
I will try to implement it and pull a request.


profileparameters POST request with no request body returns Internal Server Error

I'm submitting a ...

[X] bug report
[ ] new feature / enhancement request
[ ] improvement request (usability, performance, tech debt, etc.)
[ ] other

Traffic Control components affected ...

[ ] CDN in a Box
[ ] Documentation
[ ] Grove
[ ] Traffic Control Client
[ ] Traffic Monitor
[X] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] unknown

Current behavior:

Making a POST request to /profileparameters with no body in the request returns:
HTTP/1.1 500 Internal Server Error
{
    "alerts": [
        {
            "text": "Internal Server Error",
            "level": "error"
        }
    ]
}

Expected / new behavior:

Most endpoints return:
HTTP/1.1 400 Bad Request
{
    "alerts": [
        {
            "text": "EOF",
            "level": "error"
        }
    ]
}

Minimal reproduction of the problem with instructions:

Anything else:

Is that a regression, or did Perl panic too?

Perl returned:
HTTP/1.1 400 Bad Request
{
    "alerts": [
        {
            "level": "error",
            "text": "parameters must be in JSON format."
        }
    ]
}

This is also caused syntactically invalid bodies e.g. [, {, and any valid JSON that isn't an object or array e.g. "string", null


feat: add support for extra pod Spec

What issues does your PR fix?
Ability to add misc. spec resources on pods
What does your PR do?
Add a extraPodSpec variable to allocate Spec of pods not anticipated by the chart.
Checklist
For all Pull Requests

[x] Commits are signed off
[x] Commits have semantic messages
[x] Documentation updated
[x] Passes ct linting

For releasing ONLY

[ ] Chart.yaml version bumped
[ ] CHANGELOG.md updated

Bumping for bot.

I am not sure this is a good idea, it will result in people breaking stuff and anyone who has such complex requirements can probably just fork the chart for their own purposes.
@Hosade Am I missing anything that might make this necessary?

Hi, necessary, I don't know. Forking (and maintaining the fork) for something that simple is kind of a pain. This would not break any existing setup and does not seem to be more error prone than other k8s concepts that we can find in the chart (pdb, affinity...)

For example, hostAliases( unsupported by this chart )...
This is possible by using patches of kustomization.
If chart supports extraSpec,  ignoring this by default will not affect for all users. Furthermore, for users that need unsupported spec, this approch(=not implement) is simply unkind.
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
helmCharts:
  - name: airflow
    releaseName: airflow
    repo: https://airflow-helm.github.io/charts
    version: 8.8.0
patches:
  - path: ./patch.yaml
    target:
      kind: StatefulSet
      name: airflow-worker

apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: airflow-worker
spec:
  template:
    spec:
      hostAliases:
      - ip: "<IP_ADDRESS>"
        hostnames:
        - "example.com"


Output exodus file from reading in Vtk-ASCII file, point data now shown in exodus file

Hi,
I am using the following script to output a exodus file from Reading in an VTK-ASCII file.
import meshio
import glob

input_folder = 'input_vtk'
output_folder = 'output_vtk'
filename = 'hex8_100m-zpos_t8980000.vtk'
input_Path_list = glob.glob(input_folder + '/' + '*.vtk')

for input_Path in input_Path_list:
    filename = input_Path.split('/')
    print(filename)
    output_Path = output_folder + '/' + 'test.exo'
    mesh = meshio.read(input_Path)
    print(output_Path)
    meshio.write_points_cells(
        output_Path,
        mesh.points,
        mesh.cells,
        point_data=mesh.point_data,
        )

However the output file exodus file I got have the two point data but there is no data , is there a similar example that I could follow ?  And also I would like to append all the time series vtk data to the same exodus file, is there a way to append to the same exodus file ?
Thanks ,

For converting files, simply use meshio-convert on the command line.

Thank you. Is it possible to convert multiple time series vtk files into one  exodus file ?

Exodus: Not yet. With XDMF you can: https://github.com/nschloe/meshio#time-series.


Microsoft Teams and Verizon CDN?

Has this been updated to reflect changes in networking related to Microsoft Teams Live events and the Verizon CDN?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077406d8-bff1-496e-3ea2-b38558fd9355
Version Independent ID: 57db3dec-2250-2dee-fd1a-ec6656911798
Content: Office 365 URLs and IP address ranges
Content Source: Enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@jdemaree Sorry for the delay. I have forwarded your question to the team that manages these endpoints for consideration in the next update. Thanks for your question.


Invalid product price cached when switching channels in the dev mode

Summary
After a fresh pull from main and clicking some buttons I ended up in a state where the selected channel is USD, but the price displayed is in PLN:

The issue does not happen in the production build with just 2 channels, but I haven't tested it for more than 2 channels.
It can be resolved by bypassing the apollo query cache (fetchPolicy: "no-cache").
Steps to reproduce

Run the dev server
Go to product details, e.g. the Saleor Beanie.
Switch channel from USD to PLN several time

A link to a reproduction repository
No response
What OS are you using?
No response
Your next.config.js file

`next.config.js`
# Paste content of your `next.config.js` file here. Check there is no private info in there.

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
# Paste logs here

@stnatic thanks for reporting, should be fixed now


problem definition

DO NOT MERGE
As mentioned in #1 & #3, there's a break in this package, this PR hopefully helps making tracking down the issue easier, this PR makes some sensible guesses, and lifts the test suite up for easier checking.

@b5 thanks for this, I do think that the lack of using Reset is a big part of the problem. We fixed a bug in yamux this way recently. cc @stebalien

I believe package.json needs an update hash for go-stream-muxer. Have you tested with gx test?

ran gx test, no errors reported, but the package refs have definitely changed. If I had the time I'd dig through the gx docs, but quick instructions on how  to switch github.com/jbenet/go-stream-muxer -> github.com/libp2p/go-stream-muxer, I can ship quicker. I'm guessing gx publish only happens after merge.

gx update github.com/libp2p/go-stream-muxer should be sufficient.

If I'm not mistaken, this might actually be mergeable? If not I can close it out. Thanks!

@whyrusleeping is on vacation at the moment and is the only one who can perform merges on this repo.

So glad to hear Jeremy's getting some well earned time off. No rush at all!

I'm back! Let's go go go!


TN-124 TN-249 Store UI table sort order/filter values

https://jira.movember.com/browse/TN-249

added new TablePreference object

stores preferences regarding filtering & storing for given User (user_id) and UI Table (table_name)

sort field and order stored individually

order must be 'asc' or 'desc'

filter values stored in dict/json form (e.g. {"<field_to_filter>": "<value_to_filter_on>"})

combination of user_id and table_name must be unique
includes as_json() and from_json() methods

TablePreference.from_json() only updates fields present in incoming json data, but it DOES update with blank/None vals (if users want to blank out their sort field, etc)

added table_preferences table db migration
added TablePreference API endpoints

[GET] and [PUT]/[POST] endpoints both located at /api/user/<user_id>/table_preferences/<table_name>
[PUT]/[POST] will create if user/table entry doesn't exist, otherwise just update

added unit tests for API endpoints (and subsequently also for model functions)
fixed issues with test_site_persistence and test_scheduled_job

unrelated to the actual change here, but the existence of the new tests caused the erroneous code in test_site_persistence to fail non-silently, and fixing that caused the erroneous code in test_scheduled_job to fail non-silently.

Hooray, test issues (with the other, pre-existing tests) finally fixed :)
@pbugni This should be ready to merge


⚠ Bofrost.fr has degraded performance

In 1105d85, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1185 ms

Resolved: Bofrost.fr performance has improved in 8bb3484 after 9 minutes.


How to pass data to webgl?

Hey, so I've been pretty frustrated trying to get this basic thing to work.
I'm using typescript and I want to pass data to WebGL via 'bufferData'.
        let a: vec3[];
        let b: Array<vec3>;
        let c = b.flat();
        gl.bufferData(gl.ARRAY_BUFFER, a, gl.STATIC_DRAW);
        gl.bufferData(gl.ARRAY_BUFFER, b, gl.STATIC_DRAW);
        gl.bufferData(gl.ARRAY_BUFFER, c, gl.STATIC_DRAW);

None of these work because of this type error:
No overload matches this call.
  Overload 1 of 2, '(target: number, size: number, usage: number): void', gave the following error.
    Argument of type 'vec3[]' is not assignable to parameter of type 'number'.
  Overload 2 of 2, '(target: number, data: BufferSource, usage: number): void', gave the following error.
    Argument of type 'vec3[]' is not assignable to parameter of type 'BufferSource'.
      Type 'vec3[]' is missing the following properties from type 'ArrayBuffer': byteLength, [Symbol.toStringTag]

c because of:
No overload matches this call.
  Overload 1 of 2, '(target: number, size: number, usage: number): void', gave the following error.
    Argument of type '(number | Float32Array)[]' is not assignable to parameter of type 'number'.
  Overload 2 of 2, '(target: number, data: BufferSource, usage: number): void', gave the following error.
    Argument of type '(number | Float32Array)[]' is not assignable to parameter of type 'BufferSource'.
      Type '(number | Float32Array)[]' is missing the following properties from type 'ArrayBuffer': byteLength, [Symbol.toStringTag]ts(2769)

Am I doing something fundamentally wrong? I've tried a bunch of different type definitions for arrays but nothing seems to work.
Thanks in advance.

You can't submit an javascript array to WebGL. JS arrays hold javascript variables, but WebGL expects the raw values in memory, which don't match JS variables. If you want to give an array of Vec3's to javascript you need to first copy it to an ArrayBuffer or a typed array, then put the ArrayBuffer/typed array into the WebGL buffer.

As a quick helper, you can use Float32Array.from(c) in your case:
const myVecs: vec3[] = [vec3.fromValues(1, 2, 3), vec3.fromValues(4, 5, 6)];
gl.bufferData(gl.ARRAY_BUFFER, Float32Array.from(myVecs.flat()), gl.STATIC_DRAW);


Find an elegant way to disable interrupt support

We want to be able to disable interrupt support in v1.5.x to save on RAM.
We have to find an elegant way of doing it without having to put ifdefs up to the assembly files.

Won't be fixed, the overhead is marginal


"a 8-frame overlap"

3.We follow the same way to extract clips from video as the C3D paper saying:'To extract C3D feature, a video is split into 16 frame long clips with a 8-frame overlap between two consecutive clips.These clips are passed to the C3D network to extract fc6 activations. These clip fc6 activations are averaged to form a 4096-dim video descriptor which is then followed by an L2-normalization' <

I think is not true cause you simply take a random index for the first frame from a certain sequence. After the firsts 16 frames are taken and a new sequence is considered. There is no mention of 50% overlapping in this code.

The overlapp is used for classification on video level, while the provided predict function is clip level


Update alerts api to display that notifications are muted for certain receivers.

The is a new feature about mute_time_intervals and if approved to active_time_intervals. The notifications are not sent when they are muted but there is no way using the API what notification will be delivered or not.
Example imagine that we have an alert and we have two receivers but for devs receivers the notification is muted:
Current state:
GET /api/v2/alerts
[
  {
    "annotations": {
      "description": "randomina.lan:9100 of job node has been down for more than 10 minutes.",
      "summary": "Endpoint randomina.lan:9100 down"
    },
    "endsAt": "2022-02-14T01:07:46.140Z",
    "fingerprint": "0593f1c55738ce93",
    "receivers": [
      {
        "name": "devs"
      },
      {
        "name": "monitoring"
      }
    ],
    "startsAt": "2022-02-12T09:01:16.140Z",
    "status": {
      "inhibitedBy": [],
      "silencedBy": [],
      "state": "active"
    },
    "updatedAt": "2022-02-13T20:03:46.134-05:00",
    "generatorURL": "http://azul:9090/graph?g0.expr=up+%3D%3D+0&g0.tab=1",
    "labels": {
      "alertname": "InstanceDown",
      "instance": "randomina.lan:9100",
      "job": "node",
      "severity": "medium"
    }
  }
]

So the alert is active and is not inhibited or silenced but it wont be delivered to devs reciever so I propose the next
GET /api/v2/alerts
[
  {
    "annotations": {
      "description": "<HOST2>:9100 of job node has been down for more than 10 minutes.",
      "summary": "Endpoint <HOST2>:9100 down"
    },
    "endsAt": "<DATETIME>",
    "fingerprint": "0593f1c55738ce93",
    "receivers": [
      {
        "name": "devs"
      },
      {
        "name": "monitoring"
      }
    ],
    "startsAt": "<DATETIME>",
    "status": {
      "inhibitedBy": [],
      "notificationMutedFor": ["dev"],  <------------------------ This is new
      "silencedBy": [],
      "state": "<DATETIME>"
    },
    "updatedAt": "<DATETIME>",
    "generatorURL": "http://<HOST>:9090/graph?g0.expr=up+%3D%3D+0&g0.tab=1",
    "labels": {
      "alertname": "InstanceDown",
      "instance": "<HOST2>:9100",
      "job": "node",
      "severity": "medium"
    }
  }
]

In this case we tell that even when the alert is active the notification itself is muted for the dev reciever.
Please provide feedback if this make sense I can send a PR.

I wonder if it doesn't make more sense to attach the information to the receivers?
  {
    "annotations": {
      "description": "<HOST2>:9100 of job node has been down for more than 10 minutes.",
      "summary": "Endpoint <HOST2>:9100 down"
    },
    "endsAt": "<DATETIME>",
    "fingerprint": "0593f1c55738ce93",
    "receivers": [
      {
        "name": "devs",
        "status": "muted"
      },
      {
        "name": "monitoring",
        "status": "active"
      }
    ],
    ...


[WIP] Reduce Docker image size and split into one image per service

When finished, this will resolve #213.
I still need to:

[ ] Create a Dockerfile for the client libraries
[ ] Stop hardcoding hostnames and ports in Docker images

[ ] Java backend server
[x] Node frontend
[ ] Client libraries

[x] Create a docker-compose.yml for the server
[ ] Make docker-compose.yml able to build the images from scratch
[ ] Update readmes
[ ] Upload prebuilt images to Docker Hub.

The backend is 1.35 GB and the frontend is 1.16 GB on my computer. Official mongo is 360 MB.
Simplest usage for now, if you have Docker Compose installed:
cd /repo/root/folder
docker build -t backend -f Dockerfile-backend .
docker build -t frontend -f Dockerfile-frontend .
docker-compose up
# Logs should be visible and the site should be reachable at http://localhost.

Going to skip making Docker images for the client libraries in this PR.

Ready for a look. I'll build and push images to Docker Hub once this has been merged into master.

@mpvartak All your comments should be addressed by these new commits.

Looks great otherwise!

@mpvartak Ready for another look.

Looks good. There's a conflict in start_server.sh though that needs to be fixed.

@justinanderson this looks fantastic, exactly what I had in mind. I'll be working on getting this running early next week.


chore: [CHAOS-7136]: Updates linux api chaos fault permissions

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: Updates linux api chaos fault permissions
Jira/GitHub Issue numbers (if any): CHAOS-7136
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[x] Successful preview build.
[x] Code owner review.
[x] No merge conflicts.
[x] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67569c94b003dac6256949dc--harness-developer.netlify.app


Update LocalAccountCreated.md

"DeviceName" seems to be situated after a break line and hence if someone copy pastes the query it doesn't work. Proposed change places "DeviceName" at the end of the commentary line.

Thanks for noticing! Will merge.


Remove cargo-make from GitHub CI

cargo-make is not compatible with older versions of Rust, so fair when testing against those versions. This updates the CI pipeline to directly call the cargo commands, instead of the proxy through cargo-make.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.97%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
32

Relevant Lines:
33

💛  - Coveralls


Add Settings screen

gpsd daemon socket connection (ip, port)
gpsd usb port (/dev/ttyUSB0)?
ADS-B server connection (ip, port)
adsb_deku All packets log? (This might be a Log screen)

Instead of attaching to a host and port ADS-B server, if not provided we could go to the screen and request that you enter the host port information. For now this can just list settings and stuff tho

Instead of attaching to a host and port ADS-B server, if not provided we could go to the screen and request that you enter the host port information. For now this can just list settings and stuff tho

I'm just gonna add some key bindings instead of a settings screen for more