Ensure AWS_PROFILE is passed to the credential_process

Describe the feature
It would be helpful if the environment variable AWS_PROFILE was always passed to the process called as credential_process even if the profile was chosen via the command line switch --profile (in case of aws-cli).
Use Case
I have to use an local fork of the aws-adfs credential_process helper to authenticate against the company's ADFS.
The fork maintains the config per profile in a separate config file ~/.aws/adfs-config. The config for each profile is slightly different. So I can't configure a single credential_process for all my profiles but have to pass a --profile xyz switch to the helper as well. This makes configuring the tool unnecessary complex.
Proposed Solution
The tool already picks up the profile from the AWS_PROFILE environment variable. That one is passed through if set for the aws-cli process only. It would be simpler if the current profile name was always passed to the subprocess.
It looks like all one would have to do is to add something like
  env=os.environ | { 'AWS_PROFILE': self._profile_name }

to the popen call in ProcessProvider._retrieve_credentials_using.
While that sounds trivial I didn't test that assumption and might be missing something obvious. Before I invest the time I wanted to ask if such a change would be accepted.
Other Information
No response
Acknowledgements

[X] I may be able to implement this feature request
[X] This feature might incur a breaking change

Edge cases where this could break existing processes:

Somebody combines an AWS_PROFILE environment variable with a different value for --profile.
According to the subprocess.Popen documentation does Linux support binary environments via os.environb (TIL!). Supporting that would make the outlined solution more complicated so I would skip that.

SDK version used
aws-cli/2.13.27 Python/3.10.12 Linux/6.2.0-35-generic source/x86_64.neon.22 prompt/off
Environment details (OS name and version, etc.)
Linux

Hi @mss thanks for reaching out. I don't think that this change could be considered. Anything involving credentials/configuration must be heavily scrutinized in order to maintain backwards compatibility. Here is the current AWS CLI documentation on configuration and credentials precedence for reference. Supporting unofficial authentication use cases through third-party applications is unlikely to get prioritized.
Have you explored alternative approaches? I found a couple AWS links on AD FS that may be helpful:

https://repost.aws/knowledge-center/adfs-grant-ad-access-api-cli
https://aws.amazon.com/blogs/architecture/field-notes-integrating-active-directory-federation-service-with-aws-single-sign-on/

@tim-finnigan thanks for the quick response. I understand that reasoning though I think the potential impact here is minimal.
I checked the links you posted and am not sure if there isn't maybe a misunderstanding of the impact involved here:

The aws-adfs I linked is used in combination with option 7 from the first page you linked ("Custom Process").
The script linked in the blog post linked from the second article is a hack of which the aws-adfs script is a more evolved variant (and the internal corporate script is even more sophisticated). I actually think that second article should point to the aws-adfs script instead of that blog post.
The third article doesn't seem to be relevant since it describes how to set up the ADFS-AWS-SSO integration which is already done by corporate IT.

What I am proposing is that an environment variable AWS_PROFILE (with the value from the --profile command line switch) is always passed to the Custom Process invoked. There are edge cases where this might break existing workflows but those are very odd ones.
The patch would look something like this:
diff --git a/botocore/credentials.py b/botocore/credentials.py
index 6c2d72013..012d8eeae 100644
--- a/botocore/credentials.py
+++ b/botocore/credentials.py
@@ -994,7 +994,8 @@ class ProcessProvider(CredentialProvider):
         # command and all arguments as a list.
         process_list = compat_shell_split(credential_process)
         p = self._popen(
-            process_list, stdout=subprocess.PIPE, stderr=subprocess.PIPE
+            process_list, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+            env=os.environ | { 'AWS_PROFILE': self._profile_name },
         )
         stdout, stderr = p.communicate()
         if p.returncode != 0:

Hmmm... if I changed that to to { 'AWS_PROFILE': self._profile_name } | os.environ I think even the mentioned edge case would not apply.
Do you think there is any chance of getting this added? This is mainly an onboarding issue for us since people have to ensure that they set up their environment correctly and not miss the one place where they have to replace their username in each profile ~/.aws/config.
If you don't see a reasonable chance I will close this feature request and look for another way to solve the issue. It should be solvable in the internal fork of the aws-adfs tool, I just thought this would be helpful for other people as well.

Thanks for following up and expanding on this. I still think this is unlikely to be considered, mainly because of the potential to break existing workflows. Maybe this feature request warrants more discussion and input from the team/community, but I do think you're better off trying to address this in the internal fork of the aws-adfs tool.

No worries, that's why I asked first before creating a PR. In the end it is just a minor inconvenience which can be scripted away.

Re-closing, I used the wrong resolution.


negationConditon Potential Spelling Error

In the example on the "Custom rules for Web Application Firewall v2 on Azure Application Gateway" page, the Negation Condition is spelt as negationConditon rather than negationCondition. I am unsure if this spelling is intended, but it may cause users who copy and paste to incorrectly implement rules if it is unintentional.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f69ca730-5af2-a52f-8017-c9a38a45b60e
Version Independent ID: f5f6bdec-fb46-6b69-48c1-599e34f7acf0
Content: Azure Web Application Firewall (WAF) v2 custom rules on Application Gateway
Content Source: articles/web-application-firewall/ag/custom-waf-rules-overview.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@niall-san, Appreciate your feedback. The doc has been edited accordingly and it would take some time for the changes to get reflect over the doc.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


How to use the react version？

When I tried to install the react module, unable to find the corresponding module
npm i PXvideo
× Install fail! Error: GET http://registry.npm.taobao.org/PXvideo response 404 status

Unfortunately at this point in time, we have not published this package to npm. You will have to manually get the file from the repo and use it.
The README has instructions on how to use the PXvideo player with react.
If you want to use one from npm, I would suggest using something https://www.npmjs.com/package/react-html5video

You can install with:
npm install --save git+https://github.com/paypal/accessible-html5-video-player.git
However, how to get it to work in react is anybodys guess,
import { PXVideo } from "accessible-html5-video-player" or
import PXVideo from "accessible-html5-video-player"
give error:
Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.


⚠ Site ANTS has degraded performance

In 0b999ea, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 4584 ms

Resolved: Site ANTS performance has improved in d39cc1c.


python311Packages.opower: 0.0.29 -> 0.0.31

Diff: https://github.com/tronikos/opower/compare/refs/tags/v0.0.29...v0.0.31
Changelog: https://github.com/tronikos/opower/releases/tag/v0.0.31
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250514 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.opower
python310Packages.opower
python310Packages.opower.dist
python311Packages.opower
python311Packages.opower.dist


Overarching Categories + Themes should be added to news form

The Overarching Categories + themes should be added as fields to the news contribution form. Currently I only see them in the LL, but this is something that should be applied to the whole website.

all CT have been updated with the latest "Topics and Regions" group, which include the 4 fields,
geographical focus
Related concepts
Overarching
Themes and use the nice autocomplete/select ex: https://landportal.info/node/add/news


Angular bootstrap-ui carousel broken in 3.3.3 [Chrome only]

I must use 3.2.0, because in Chrome  40.0.2214.94 (64-bit) [MAC OS Yosemite] in some case transform3d didn't work, i can give you link for site where this issue can be reproduced to test in private messaging

We cannot help you with Angular-related problems. Can you reproduce the problem without Angular?
Are you using Autoprefixer?
Can you reproduce the problem with Less-based Bootstrap?

Closing due to lack of response.


autocmd-containers doesn't work

I got the following error messages when I have autocmd-containers setting in my domains.conf
ERROR: /var/run/docker.sock socket is missing.
2018-07-18 06:32:01,287 INFO exited: mydomain.com_autocmd-containers (exit status 1; not expected)
2018-07-18 06:32:01,288 INFO gave up: mydomain.com_autocmd-containers entered FATAL state, too many start retries too quickly

As for the autorestart functionality, you need to mount the docker socket on your letsencrypt-dns container. It was not really understandable from the README.md, I updated it accordingly.

The problem has gone after I mounted the docker socket. Thanks!


ovs support seems to have dissapeared in 0.44.0

mgmt:
  bridge: mgmt
  ipv4-subnet: <IP_ADDRESS>/24
  network: mgmt1
name: lab1
topology:
  links:
  - endpoints:
    - n1:e1-1
    - ovsbr0:ovsp0
  nodes:
    n1:
      image: alpine:latest
      kind: linux
      mgmt-ipv4: <IP_ADDRESS>
    ovsbr0:
      kind: ovs-bridge

root@lab1:/opt# clab deploy -t test.yaml
INFO[0000] Containerlab v0.44.0 started
INFO[0000] Parsing & checking topology file: test.yaml
INFO[0000] Creating docker network: Name="mgmt1", IPv4Subnet="<IP_ADDRESS>/24", IPv6Subnet="", MTU="1500"
Error: interface ovsbr0 found. expected type "bridge", actual is "openvswitch"

Pinging @steiler

Yes, first issue was a check for the netlink type, which was restricted to bridge but is openvswitch in this case.
But turns out, we need to use the openvswitch libraries to bind the interface to the switch. Setting the master interface via netlink will result in an error.


[Enhancement Proposal]: Addition of an option to join the discord community of ksctl

Enhancement Title
Addition of an option to join the discord community of ksctl
Summary of the Enhancement
Just like below we have a section for (Contributors welcome of github), (Follow us of twitter), similarly there should be an option to join the discord community of ksctl just beside these 2 sections.

Motivation and Goals

It will help fellow visitors to join the ksctl community.
It will also help to fill the blank part which is not looking good.

Detailed Design

Already explained in description part

Alternatives
No response
Scope of changes

[ ] Cli
[X] UI
[ ] Docs

Agreement

[X] I agree to engage in constructive discussion and follow the Contribution Guidelines.

I have assigned you


Fix lodash uniqBy import

Basic information

nrich-frontend module version:

Module:
form-configuration-core

Description
Summary
Fixed import for lodashs' uniqBy function
Types of changes

Refactoring

Checklist

[x] I have read the project's CONTRIBUTING document
[x] I have checked my code with the project's static analysis tooling
[x] I have formatted my code with the project's IDEA code-style configuration
[x] I have checked my code for misspellings
[x] I have organized my changes in easy-to-follow commits
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] All new and existing tests pass.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.05%. Comparing base (6ce2e3b) to head (7d435fd).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   99.01%   99.05%   +0.03%
==========================================
  Files          25       25
  Lines         203      211       +8
  Branches       32       32
==========================================
+ Hits          201      209       +8
  Misses          2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Problem getting vector (array) of strings

Similar to this one:
https://github.com/nlohmann/json/issues/44
#include <nlohmann/json.hpp>
#include <iostream>

using nlohmann::json;

int main() {
  auto j = R"(
    {
         "names": ["Tim", "Tom"],
         "num": [1, 2]
    }
    )"_json;

  std::vector<std::string> names;
  names = j["names"];

  for (auto i : names) {
    std::cout << i << " ";
  }

  // prints: Tim Tom
}

main.cpp:14:20: error: ambiguous overload for ‘operator=’ (operand types are ‘std::vector<std::__cxx11::basic_string >’ and ‘nlohmann::basic_json<>::value_type {aka nlohmann::basic_json<>}’)
names = j["names"];

Hi @nlohmann , separating the definition and declaration doesnt work again. Any solution for this? In some cases this separation is needed.

Implicit type conversion from JSON objects is not recommended anymore. You might use explicitly-typed get<T>() method:
names = j["names"].get<std::vector<std::string>>();

This is a known issue, and there is no real way to fix it while preserving support for implicit conversions. The proposal of @nickaein works, however. You can further simplify the code with get_to (https://nlohmann.github.io/json/classnlohmann_1_1basic__json_a65753c68f06639eda0d355f919564e01.html#a65753c68f06639eda0d355f919564e01):
j["names"].get_to(names);

@chakpongchung Do you need further assistance?


Duplicate Contact headers in responses on B2BUA

When I specify in createB2BUA ...:
responseHeaders : { contact : '<validcontact>' }

... this happens in the provisional, and final responses to UAS:
100 -> No contact
180 -> 1 contact
180 -> 2 contacts
180 -> 3 contacts
183 -> 4 contacts
200 -> 5 contacts

This happens on both lowercasecontact, and camelcase Contact.

fixed in 4.4.31

This seems to not be fixed. On e.g. the second provisional response the command sent to drachtio-server is:
makeTags - Adding well-known header 'contact' with value '<validcontact>,<validcontact>'
which turn into two duplicates.
(Note, I am running the patched server version from https://github.com/davehorton/drachtio-server/issues/114 if that matters)

hmm, can you show me the drachtio server log at debug

Sent you unfiltered on mail.

You can see how I use it here: https://github.com/havfo/drachtio-msteams-gw/blob/9ea98298e46dc5b97821efb153518dd7d9f6eaeb/lib/handlers/Session.js#L140

You probably do not want to include a Contact on a provisional response, unless it is a reliable provisional response.  To support this, opts.responseHeaders can be function that returns an object.  The function will be called like so:
`responseHeaders: (uacRes, headers) => {...

where you are passed the provisional response object, as well as any headers that have already been copied from the B leg to the A leg (via opts.proxyResponseHeaders).  This would let you examine uasRes.status and only put a Contact header on your response if it was a 200 OK.
This is not related to the bug but may be useful to you

Ah, great, I must have missed that on my many rounds through the API documentation :smile:


Compiler can't infer that flat-mapped NonEmpty<[String]> results in [String]

struct Emoji {
    let aliases: NonEmpty<[String]>
    let tags: [String]
}

let emoji = /* an Emoji */
let searchTerms: [String] = [emoji.aliases, emoji.tags].flatMap { $0 } // error

The error is Cannot convert value of type '[Any]' to specified type '[String]'.
I'm using Xcode 11.4.1 and Swift 5.

your [emoji.aliases, emoji.tags] is of type [Any] and you've specified the searchTerms to be [String]

@ibrahimkteish I don't understand your implication, can you clarify? Regardless of the type of [emoji.aliases, emoji.tags], it remains that the code above works if aliases is typed as [String] and not when it is typed as NonEmpty<[String]>. As far as I understand the library, NonEmpty is supposed to present as an instance of whatever collection it wraps in every way except for enforcing non-emptiness, so this seems like a bug.

The problem here is that Swift does not yet have disjoint types (like Either).
emoji.aliases is a NonEmpty, and emoji.tags is a [String], so [emoji.aliases, emoji.tags] is a[[Any]] (ideally, it might be a [(NonEmpty|[String])], but again, Swift can't do that yet. It'd also be nice if it were a [Collection], but knowing that the sub-collections all have String Elements is also not possible yet in Swift).
Because that array literal is a [[Any]], it doesn't have a flatMap method; it doesn't see that its contents are all collections which can be flattened.

Here's a version of your code that works:

import NonEmpty

struct Emoji {
    let aliases: NonEmpty<[String]>
    let tags: [String]
}

let emoji = Emoji(aliases: NonEmpty("smile", "grin"), tags: ["smiley", "face"])
let searchTerms: [String] = [Array(emoji.aliases), emoji.tags].flatMap { $0 }

Thanks for the explanation @BenLeggiero ! Turning the NonEmpty<[String]> into a [String] like that doesn’t look too bad. I don't know if you'd prefer to keep this issue open to track adopting the (eventual) Swift features you mention, but if you'd like to close that's fine by me.

Glad I could help, @wearhere!
I'm tagging @stephencelis and @mbrandonw since they control this repo

Glad y'all figured this out, thanks for the help @BenLeggiero and @ibrahimkteish!
Another way of doing this would be to wrap the collections in AnyCollection in order to get Swift to think it's a homogenous collection:
[AnyCollection(emoji.aliases), AnyCollection(emoji.tags)]
  .flatMap { $0 }

It's a bit longer, but has the potential benefit that it won't allocate an array for emoji.aliases, it will just wrap the collection.


[Snyk] Upgrade @opentelemetry/exporter-jaeger from 1.4.0 to 1.7.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @opentelemetry/exporter-jaeger from 1.4.0 to 1.7.0.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.
The recommended version was released 22 days ago, on 2022-09-16.

Release notes

Package name: @opentelemetry/exporter-jaeger

1.7.0 - 2022-09-16🐛 (Bug Fix)

fix(sdk-trace-base): make span start times resistant to hrtime clock drift
#3129

📚 (Refine Doc)

docs(metrics): add missing metrics packages to SDK reference documentation #3239 @ dyladan

🏠 (Internal)

deps: update markdownlint-cli to 0.32.2 #3253 @ pichlermarc

1.6.0 - 2022-08-24🚀 (Enhancement)

perf(opentelemetry-core): improve hexToBase64 performance #3178
feat(sdk-trace-base): move Sampler declaration into sdk-trace-base #3088 @ legendecas
fix(grpc-instrumentation): added grpc attributes in instrumentation #3127 @ andrewzenkov
feat: support latest @ opentelemetry/api #3177 @ dyladan

🐛 (Bug Fix)

fix(context-async-hooks): Ensure listeners added using once can be removed using removeListener
#3133

1.5.0 - 2022-07-261.5.0
🚀 (Enhancement)

feat(sdk-trace-base): Improve extensibility of BasicTracerProvider #3023 @ Rauno56

1.4.0 - 2022-07-06🚀 (Enhancement)

fix(resources): fix browser compatibility for host and os detectors #3004 @ legendecas
fix(sdk-trace-base): fix crash on environments without global document #3000 @ legendecas

🏠 (Internal)

test: add node 18 and remove EoL node versions #3048 @ dyladan

    from @opentelemetry/exporter-jaeger GitHub release notes

Commit messages

Package name: @opentelemetry/exporter-jaeger

ad88c3d chore: proposal 1.7.0/0.33.0 (#3259)
4422d8c deps: remove unused protobufjs and update used ones to 7.1.1 (#3251)
ec56837 chore: fix markdownlint issues (#3252)
9c102b7 deps: update markdownlint-cli to 0.32.2 (#3253)
fade3c9 ci(instrumentation-http): improve metrics test stability (#3242)
bd0a77f docs(sdk-metrics): fix typos and add missing parameter docs (#3244)
032f68f chore(deps): update node.js to v18 (#3204)
0f178d1 Merge api repository into main (#3245)
c1ef97d chore: upgrade linkinator to 4.0.3 (#3241)
f9f7fed feat(opentelemetry-api-metrics): Adding generics to `create{metricType}` (#3170)
b73c29d feat(sdk-metrics): align MetricReader with specification and other language implementations (#3225)
be24d69 chore(sdk-metrics): remove accidental export of the SDK Meter class (#3243)
5818129 feat: anchored clock (#3134)
32cb123 Add metrics packages to generated docs (#3239)
cdbf67d Logs/events API (#3117)
5005b0b docs(node-sdk): update outdated metric documentation. (#3226)
597ea98 Add HTTP Server and Client duration Metrics in HTTP Node.js Instrumentation (#3149)
a8047ba docs: add experimental disclaimers to all experimental packages. (#3233)
c926e3d fix: rollback linkinator (#3231)
d3adc22 chore(api-metrics): clean up exports (#3198)
4e123b5 feat(node-sdk): added resourceDetectors option to NodeSDK #3210 (#3212)
a669f9c chore(deps): update prometheus example dependencies to 0.32 (#3216)
dd22372 feat(sdk-metrics-base): per metric-reader aggregation (#3153)
bd9159a chore: cleanup eslint (#3209)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Coverage remained the same at 85.161% when pulling a1bbce7bc3f9f3d8cbec15123869493c0dfe20d8 on snyk-upgrade-945657e3548fc042cc0e2cbedac41510 into eaf3308f545eb9d47737c0f7f2b3a480960572c3 on main.


Requesting multiple tokens with different scopes

Hi,
In our application we need to produce different tokens for same client id but different scopes (PKCE flow).
I tried to create 2 different instances of OAuthService when both sharing same configuration but each have different scopes. The token that returned is same token. Is that achievable somehow?
Thanks

This is not easily achieved with this library. It's set up as a singleton service with a singleton configuration, having either 0 or 1 sets of id/access tokens. Doing multiple instances and multiple access tokens for separate scenario's is in my opinion not a real strong suit (though maybe it can be get to work), so I'd recommend looking elsewhere for that use case.

@eddyuk Hi there. Did you find any solution to your problem. I am also having similar issue. I use PKCE flow but inside my app I have a create signature functionality and during that process second user (not the one that authorized himself before) has to authorize himself. I tired to use fetchTokenUsingPasswordFlow method with different credentails but after successful login my original user becomes the one that just authorized just for the signature...
@jeroenheijmans maybe some tip how to get it done?

Sorry, I can only reiterate my previous comment: don't use this library for that scenario. It's in my opinion currently not suited for this situation, even with workarounds and customization.
PS. See also #1280, I'm quite a bit less involved with the library nowadays (just as a heads up).

The solution I have in mind, is eventually to retrieve a token from backend service with different client (for my scenario it is suitable). With the library I only login the working user.


prefix-exact-match (^) syntax does not work in 0.21.0

[ ] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce

Download and install fzf 0.21.0.
Open a new Bash shell.
Try to search through your history for a previously ran command with the prefix-exact-match search syntax (with CTRL-R or history | fzf), e.g. ^vim.
Observe that results that should appear do not, e.g. commands like vim some_file.txt will not appear in the results.

I've ran git bisect and it tells me that the "[bash] Multiline C-r without histexpand (#1837)" commit is the first commit where this issue arises.

Thanks for the report. I missed that in the review process.

Fixed in 14f90502a49b868b6c9fed4a86d413427052fb81


Secret store for passwords, tokens, api keys and more

We need a secure way to store passwords, tokens, api keys and everything that should be kept secret.
For example when the user wants to access vault via a pipeline. Usually a token is required to get access to vault and this token should be stored in the secret store.
After a secret has been stored, it must be possible to automatically inject this password during runtime in the pipeline as a job argument. This is not a problem at all, we just have to decide how the user can setup the relationship between a secret and a pipeline. That means, which secret should be available in which pipeline.
First option: In the details page create a new view to configure the pipeline. Add a subview to manage secrets.
Second and preferred option: Create a new view below settings. This view is for managing secrets. When a view is created or modified it can be linked to multiple pipelines. This has the advantage that one secret can be shared with multiple pipelines.
What do you think?

ping @Skarlso

Picking this up.

Fixed by #56


[WIP] Fixes #28404 -- Show empty_value for empty strings

Fixes https://code.djangoproject.com/ticket/28404

Hi @markkohdev.
I'm going to close this due to the failures, the lack of activity and more generally in favour of #9391.
I don't think the exact changes you made here were right — it was meant to be a regression test on Django Project #14982 — but adding a test for this issue in admin_changelist/tests.py is a good idea.
If you still want to work on this let me know and we can look at re-opening.
Thanks for the input!


Repo sync for protected CLA branch

The pull request is created from main638061411505236057sync_temp to main to fix git push error for protected CLA branch

Learn Build status updates of commit 2de0312:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Multi-platform build targeting both amd64 and arm64

What are you trying to do?
Trying to set up a build to output multi-platform images for both linux/arm32v5 and linux/amd64 for the same main entrypoint.
I can configure one or the other by changing the default base image between gcr.io/distroless/static and gcr.io/distroless/static:latest-arm64, but that requires changing the base image configuration between the build steps.
What did you expect?
Lacking a distroless/static image that supports all platforms, the ability to configure different base images for different platforms in the same build.

Yeah, this is a known annoyance. Some discussion and prototyping in https://github.com/google/ko/issues/475
Tekton also does this, to combine distroless and a Windows base image as a pre-step, but it's definitely annoying.
I think we could figure out how to make it work in ko directly.

Actually: Does this work for you?
ko publish ./cmd/app --platform=linux/amd64,linux/arm

If distroless/static supports armv5 I'd expect this to work.

@imjasonh Thank you, that seems to work!
So if I read this PR correctly I'm supposed to provide the ARM instruction set as part of the platform, https://github.com/google/ko/pull/239 - but that leads to a base image that is not included in the distroless/static metadata?
So to solve this I can configure the build to target linux/arm and manually set GOARM=5?

You can specify linux/arm/v5 to differentiate between variants if the base image specifies multiple (linux/arm/v5, v7, whatever). That PR means that the base image's detected/supported variant would be used to further specify better go compilation support if it can find it (using GOARM).
Since distroless only currently provides a generic linux/arm, this is moot. If you want to use another base image, eg alpine, you could.
If you want to support linux/arm via distroless/static and other variants via eg alpine, you could combine a base image together, like Tekton does as described in the issue above, but that's cumbersome. ko could do better.


Flag name for disabling hooks inconsistent across commands

helm delete --no-hooks
helm install --no-hooks
helm rollback --no-hooks
helm upgrade --disable-hooks

To keep backward compatibility, we're going to have to make --disable-hooks an alias of --no-hooks for helm upgrade.


Any update on an example for implementaton

Any update on an example for implementaton

Any update on an example for implementaton

Hi, Dear @SaabirMohamed
I'm working on example.
You can checkout the project documentation site from: https://dahkenangnon.github.io/flutter_feathersjs.dart/
NB: An example app will be available next week.
🚀 🐦

Any update on an example for implementaton

Hi, Dear @SaabirMohamed
I'm working on example.
You can checkout the project documentation site from: https://dahkenangnon.github.io/flutter_feathersjs.dart/
NB: An example app will be available next week.
🚀 🐦

If you have any question, feel free to participate to the discussion here: https://github.com/Dahkenangnon/flutter_feathersjs.dart/discussions/3#discussion-1232961

If you have any question, feel free to participate to the discussion here: https://github.com/Dahkenangnon/flutter_feathersjs.dart/discussions/3#discussion-1232961

this is great thanks! I will check it out
On Sat, Jan 2, 2021 at 12:28 PM Justin Dah-kenangnon <
<EMAIL_ADDRESS>wrote:

Any update on an example for implementaton
Hi, Dear @SaabirMohamed https://github.com/SaabirMohamed
I'm working on example.
You can checkout the project documentation site from:
https://dahkenangnon.github.io/flutter_feathersjs.dart/
NB: An example app will be available next week.
🚀 🐦
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Dahkenangnon/flutter_feathersjs.dart/issues/1#issuecomment-753456985,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCJF6SBQOIYEA354TFWE7DSX3YNDANCNFSM4VQRKO7A
.

this is great thanks! I will check it out
On Sat, Jan 2, 2021 at 12:28 PM Justin Dah-kenangnon <
<EMAIL_ADDRESS>wrote:

Any update on an example for implementaton
Hi, Dear @SaabirMohamed https://github.com/SaabirMohamed
I'm working on example.
You can checkout the project documentation site from:
https://dahkenangnon.github.io/flutter_feathersjs.dart/
NB: An example app will be available next week.
🚀 🐦
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Dahkenangnon/flutter_feathersjs.dart/issues/1#issuecomment-753456985,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCJF6SBQOIYEA354TFWE7DSX3YNDANCNFSM4VQRKO7A
.

Nice, this issue will be close. Feel free to open an other or create discussion.

Nice, this issue will be close. Feel free to open an other or create discussion.


Use stunnel3 wrapper in stunnel example.

The stunnel example does not work for stunnel versions >= 4, but there is a perl-script wrapper provided that allows for usage of older commandline options. I've created this pull request to reflect this in the docs.
BR,
Thomas

@tkettenbach-dwd Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Would It make more sense to switch to the options used by stunnel 4?

I've updated the PR to use stunnel >= 4 command line usage. The config file presented should be equal to the older command line parameter usage.

Let's merge and update snippet formatting a bit.


impl std::error::Error for Error

We talked about this over chat a while back, and this patch is not the right fit for where we're taking this crate. Closing.


Limit Supervisor container to 100mb memory

Over time the supervisor container uses more and more RAM (up to ~3.5GB) until it is either restarted or updated to a new version. Then eventually it starts eating RAM again. This change limits the container to a hard cap of 100mb. I have been running this change on my own system (actually with a stricter limit of 50mb) since September 15 and have not noticed any ill effects or unexpected container restarts.
Also, it's just best security practice to limit how much memory a container can consume :)

Hi @TravelinMax,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Had to force-push that commit with a properly configured gpg key ☝

We should fix memory leaks. I know there is a lot discusion about workarounds vs. bugfix.
Howevery, my test instances are all around 52mb. I will have my eyes on that but I don't think the current version have a memory leak.

It will be a while without seeing the memory leak before I’ll be convinced it’s truly gone 😀
Regardless, it is good practice to put resource limits on containers, in case of a memory leak, or an attacker gaining access to the container and intentionally causing high memory use as an attempt to DOS the system.
BUT, 1. That seems like an unlikely attack on a typical Home Assistant user, and 2. No other Home Assistant containers currently have resource limits, so this might be an odd break from the norm.
Anyway, all that to say, if you take this change, great! If you don’t, great! :)


Custom scheme does not work on Windows 11

Hi,
I'm using Photino v3.1.18.
When I tried using Custom scheme handler, even if I navigate the browser directly to the scheme or refer it in href, the custom scheme does not work.

Direct navigation to custom scheme:

[STAThread]
         public static void Main(string[] args)
         {
             var appUrl = "app://my-web.io";
             var services = new ServiceCollection();
             services.AddSingleton(new PhotinoWindow());

             var serviceProvider = services.BuildServiceProvider();
             var window = serviceProvider.GetService<PhotinoWindow>()!;

             // The appUrl is set to the local development server when in debug mode.
             // This helps with hot reloading and debugging.

             // Window title declared here for visibility
             var windowTitle = "Photino.Angular Demo App";

             // Creating a new PhotinoWindow instance with the fluent API
             window.SetWebSecurityEnabled(false);

             window
                 .SetTitle(windowTitle)
                 .SetUseOsDefaultSize(false)
                 .SetSize(new System.Drawing.Size(2048, 1024))
                 // Resize to a percentage of the main monitor work area
                 //.Resize(50, 50, "%")
                 .SetUseOsDefaultSize(false)
                 .SetSize(new System.Drawing.Size(800, 600))
                 // Center window in the middle of the screen
                 .Center()
                 // Users can resize windows by default.
                 // Let's make this one fixed instead.
                 .SetResizable(true)
                 .SetDevToolsEnabled(true)
                 .RegisterCustomSchemeHandler("app", (object sender, string scheme, string url, out string contentType) =>
                 {
                     contentType = "text/javascript";
                     return new MemoryStream(Encoding.UTF8.GetBytes(@"
                             (() =>{
                                 window.setTimeout(() => {
                                     alert(`🎉 Dynamically inserted JavaScript.`);
                                 }, 1000);
                             })();
                         "));
                 })
                 // Most event handlers can be registered after the
                 // PhotinoWindow was instantiated by calling a registration
                 // method like the following RegisterWebMessageReceivedHandler.
                 // This could be added in the PhotinoWindowOptions if preferred.
                 .RegisterWebMessageReceivedHandler((object sender, string message) =>
                 {
                     var window = (PhotinoWindow)sender;

                     // The message argument is coming in from sendMessage.
                     // "window.external.sendMessage(message: string)"
                     string response = $"Received message: \"{message}\"";

                     // Send a message back the to JavaScript event handler.
                     // "window.external.receiveMessage(callback: Function)"
                     window.SendWebMessage(response);
                 }); // Can be used with relative path strings or "new URI()" instance to load a website.

             window.Load(new Uri(appUrl, UriKind.Absolute));

             window.WaitForClose(); // Starts the application event loop
         }

This is the result I got:

Refer custom scheme in script tag:

[STAThread]
    public static void Main(string[] args)
    {
        var services = new ServiceCollection();
        services.AddSingleton(new PhotinoWindow());

        var serviceProvider = services.BuildServiceProvider();
        var window = serviceProvider.GetService<PhotinoWindow>()!;

        // The appUrl is set to the local development server when in debug mode.
        // This helps with hot reloading and debugging.

        // Window title declared here for visibility
        var windowTitle = "Photino.Angular Demo App";

        // Creating a new PhotinoWindow instance with the fluent API
        window.SetWebSecurityEnabled(false);

        window
            .SetTitle(windowTitle)
            .SetUseOsDefaultSize(false)
            .SetSize(new System.Drawing.Size(2048, 1024))
            // Resize to a percentage of the main monitor work area
            //.Resize(50, 50, "%")
            .SetUseOsDefaultSize(false)
            .SetSize(new System.Drawing.Size(800, 600))
            // Center window in the middle of the screen
            .Center()
            // Users can resize windows by default.
            // Let's make this one fixed instead.
            .SetResizable(true)
            .SetDevToolsEnabled(true)
            .RegisterCustomSchemeHandler("app", (object sender, string scheme, string url, out string contentType) =>
            {
                contentType = "text/javascript";
                return new MemoryStream(Encoding.UTF8.GetBytes(@"
                        (() =>{
                            window.setTimeout(() => {
                                alert(`🎉 Dynamically inserted JavaScript.`);
                            }, 1000);
                        })();
                    "));
            })
            // Most event handlers can be registered after the
            // PhotinoWindow was instantiated by calling a registration
            // method like the following RegisterWebMessageReceivedHandler.
            // This could be added in the PhotinoWindowOptions if preferred.
            .RegisterWebMessageReceivedHandler((object sender, string message) =>
            {
                var window = (PhotinoWindow)sender;

                // The message argument is coming in from sendMessage.
                // "window.external.sendMessage(message: string)"
                string response = $"Received message: \"{message}\"";

                // Send a message back the to JavaScript event handler.
                // "window.external.receiveMessage(callback: Function)"
                window.SendWebMessage(response);
            }); // Can be used with relative path strings or "new URI()" instance to load a website.

        window.Load(new Uri("path\\to\\index.html", UriKind.Absolute));

        window.WaitForClose(); // Starts the application event loop
    }

index.html:

Hello world

This is the result I got:

Nothing happened.
Any solutions please ?

@redplane We're trying to understand what your goal is. The first scenario should not work. You cannot navigate directly to a non-http resource. The second scenario should also not work. You cannot use href= in a script tag. Instead use src=. In our sample, it doesn't navigate to the JavaScript file, it navigates to index.html, where the script tag returns the JavaScript content to the http resource (index.html).

@redplane We're trying to understand what your goal is. The first scenario should not work. You cannot navigate directly to a non-http resource. The second scenario should also not work. You cannot use href= in a script tag. Instead use src=. In our sample, it doesn't navigate to the JavaScript file, it navigates to index.html, where the script tag returns the JavaScript content to the http resource (index.html).

Like the Android or iOS web view, I want to register a custom scheme that I can handle the content by myself.
For example, I want a custom scheme: app:// or anything except http, https, so when webview requests content for that scheme, based on condition, I can return content of a physical file or I will download it from somewhere.


After openssl is upgraded facing GNUC safe_math.h not found issue

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4880
Facing the below issue after openssl is upgraded
Edk2\CryptoPkg\Library\OpensslLib\openssl\include\internal/safe_math.h(19): warning C4668: 'GNUC' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif'
Reviewed-by: Gerd Hoffmann<EMAIL_ADDRESS>
Checklist

[x] documentation is added or updated
[x] tests are added or updated

This could be accepted with CLA: trivial. Could you please amend the commit message to contain CLA: trivial on a separate line?

I too would be okay with trivial for this.

The style failure looks relevant unfortunately.

@HemaAnmisha  Could you please amend the commit message to contain CLA: trivial on a separate line?

@HemaAnmisha All contributions to OpenSSL need to either be covered by a CLA, or to be considered trivial for copyright concerns. That's why you are seeing "CLA missing" and hold: cla required.
This change could be accepted as "CLA: trivial", which would avoid the CLA requirement. For "CLA: trivial" we need you to amend the commit message (replacing the existing commit) to have the text CLA: trivial on a separate line in the commit message body, separated from the rest of the commit message by an empty line. For an example, see my comment here.

@HemaAnmisha Could you please amend the commit message to contain CLA: trivial on a separate line?

done

can this pr be merged, now?

can this pr be merged, now?

The required approvals have been obtained. We just wait for 24 hours from the second approval to confirm no other objections are raised before merging.

24 hours has passed since 'approval: done' was set, but as this PR has been  updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.


Hi, Everyone - How to get Base64 Log ID

Hi, Everyone
I want to know that....How to know or get that Base64 Log ID..?

I answered this here:
https://groups.google.com/d/msg/certificate-transparency/VfppgRLCMY4/cJ53UyDIAgAJ

Okay thanks brother, but other company have base64 id?
You can see in this link:  https://www.certificate-transparency.org/known-logs


Create TMSTACLSRetexture.netkan

#rebuild to see if error persists

Huh?  Sorry, this process is a little perplexing to me.

Tested manually with netkan.exe and it spits out a .ckan without issue. It actually looks like an issue with TACLS?

The following inconsistencies were found:
TACLS requires TACLS-Config but nothing provides it

Probably related to how TACLS-Config is provided?
Someone smarter than me will forward this to the people that need to know about it, but you're in the clear @tambo1. =)

But does it install correctly, that's the part Jenkins is stuck on. Does this overwrite any files or is it all done with MM?

Everything is done via MM.  No overwrites.
I'm wondering if the problem is that TACLS has TACLS-Config as a dependency, but I only state that TACLS as a dependency?

Nah CKAN (should) handle that without problems, this seems to be an error somewhere on our part.
I just ran everything locally and it installed fine so I'm notifying @RichardLake who might be able to spread some knowledge around.

Seems Jenkins is fetching an old (7 days, so about 4 years in CKAN development cycle time) so I'm merging this since it works locally and presents no errors on newest CKAN.

Many thanks for your time and consideration, gents.


Submit a Listing page - The screenshots are not being saved properly in IE11

Test 1
Open the Submit Listing page in IE11.
Add a screenshot to the Preview Image
Hit Save and the image is moved to the Full Screenshot
Test 2
Open the Submit Listing page in IE11.
Add a screenshot to the Both Images
Hit Save and the screenshot disappears
Test 3
Open the Submit Listing page in IE11.
Add a screenshot to the Full Image
Hit Save and the screenshot disappears

@mparizernc & @jal-vsi - Is this still an issue?

@tonyalletag This appears to be working now.


Defer transforming values in CucumberExpressions

It should be OK for Parameter transform functions to throw errors. It should also be possible to match a CucumberEpxression (or RegularExpression) without invoking the transform function.
This probably means that the Argument.getTransformedValue() needs to do the transformation on demand rather than having it passed into the constructor.
See cucumber/cucumber-js#765 for more context

Fixed by 0d36406fc1617138d18ff319a8b04fe12bd7df91


Win10 Windows Defender Registry Modification Error

Operating System Version: Ubuntu 20.04
Deploying via (VirtualBox/VMWare/AWS/Azure/ESXi): Virtualbox
Vagrant Version (if applicable): 2.2.14

Description:
While building the win10 machine with Vagrant/Virtualbox, the join-domain.ps1 script fails due to denied access while attempting to modify the Windows Defender registry. I'm trying to find a solution to this now but the user vagrant does not have the appropriate permissions to make the registry key modification. The following code snippet causes the issue.
REG ADD "HKLM\SOFTWARE\Microsoft\Windows Defender\Features" /v TamperProtection /t REG_DWORD /d 0 /f
Error Message:
[12:58] Now join the domain...
[12:58] Adding Win10 to the domain. Sometimes this step times out. If that happens, just run 'vagrant reload win10 --provision'
WARNING: The changes will take effect after you restart the computer win10.
[12:58] Disabling Windows Updates and Windows Module Services

The operation completed successfully.

The operation completed successfully.

The operation completed successfully.

The operation completed successfully.

The operation completed successfully.

The operation completed successfully.

The operation completed successfully.

The operation completed successfully.

The operation completed successfully.

Stderr from the command:

powershell.exe : ERROR: Access is denied.
    + CategoryInfo          : NotSpecified: (ERROR: Access is denied.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

Encountered this several times on the win10 VM as well. I just shut down the VM using vagrant halt win10 and then run vagrant reload win10 --provision until the provisioning has been completed.

Thank you for the input but running vagrant reload win10 --provision doesn't actually re-run the join-domain.ps1 script if the WIN10 machine is already joined to the domain. This simply prevents the segment  REG ADD "HKLM\SOFTWARE\Microsoft\Windows Defender\Features" /v TamperProtection /t REG_DWORD /d 0 /f from running and triggering the permissions error.

This should be fixed in caa57f7fe2d656cbb582ac654a71e155888ada81


iPhone Detail View Display Issues

The new detail view added for iPhones in version v<IP_ADDRESS>.b remains partially broken. The view does not display or render correctly in certain cases, causing layout inconsistencies. While the category filter and vertical stack optimizations are functional, the detail view needs additional troubleshooting to ensure it works smoothly across all iPhone devices.

Fixed Detail View Display Issue on iPhone:
•	Removed .background Modifier:
•	The .background modifier in the compact size class (iPhone) was causing the detail view to appear under the navigation bar. This has been removed, resolving the UI glitch on iPhone.


Handle equations split across lines and with superfluous whitespace

Fix for #205

Coverage increased (+0.006%) to 93.552% when pulling ab44aaa03d844d4a5f5a31ca0efb0060f49aa42e on ConnectedSystems:fix-eqn-issue-205 into 9f61767d4ccd0cd86bd6fb5df0c3902088555c9f on JamesPHoughton:master.

Coverage increased (+0.006%) to 93.552% when pulling ab44aaa03d844d4a5f5a31ca0efb0060f49aa42e on ConnectedSystems:fix-eqn-issue-205 into 9f61767d4ccd0cd86bd6fb5df0c3902088555c9f on JamesPHoughton:master.

I can provide regression tests and a sample stmx file if someone points me to the best place for them (new test file or as part of an existing test suite?)

I can provide regression tests and a sample stmx file if someone points me to the best place for them (new test file or as part of an existing test suite?)

Welcome to the community, @ConnectedSystems, and thanks for the PR! Looks good to me. =)

I can provide regression tests and a sample stmx file if someone points me to the best place for them

That would be great. We have tests in two places:

A repo of integration tests is here: https://github.com/SDXorg/test-models/ - it's a shared test suite that is also used for at least one other translator tool. These tests pass if the translated model produces the same numerical output as the original Vensim/Stella files. You can use some of the existing tests as an example of the syntax. As #205 is a bug that affects execution, it would be good to have a test here. Once a test is created there, it also needs to be referenced in https://github.com/JamesPHoughton/pysd/blob/master/tests/integration_test_vensim_pathway.py.
Unit tests of specific PySD behaviors are here: https://github.com/JamesPHoughton/pysd/tree/master/tests. You'll see a file unit_test_vensim2py.py, but apparently, we don't have a unit_test_xmile2py.py yet. If you wanted to start one for the xmile translation, that could also be an appropriate place to test that your code produced a specific output, if you had one in mind, and not just that it simulates properly.

Welcome to the community, @ConnectedSystems, and thanks for the PR! Looks good to me. =)

I can provide regression tests and a sample stmx file if someone points me to the best place for them

That would be great. We have tests in two places:

A repo of integration tests is here: https://github.com/SDXorg/test-models/ - it's a shared test suite that is also used for at least one other translator tool. These tests pass if the translated model produces the same numerical output as the original Vensim/Stella files. You can use some of the existing tests as an example of the syntax. As #205 is a bug that affects execution, it would be good to have a test here. Once a test is created there, it also needs to be referenced in https://github.com/JamesPHoughton/pysd/blob/master/tests/integration_test_vensim_pathway.py.
Unit tests of specific PySD behaviors are here: https://github.com/JamesPHoughton/pysd/tree/master/tests. You'll see a file unit_test_vensim2py.py, but apparently, we don't have a unit_test_xmile2py.py yet. If you wanted to start one for the xmile translation, that could also be an appropriate place to test that your code produced a specific output, if you had one in mind, and not just that it simulates properly.


Update azure-firewall.md .. deprecated .. read aloud .. broken links …

….. dashes .. many
grammar
behind thresholds
below thresholds
no more required
no longer required
update link ... known issues
https://learn.microsoft.com/en-us/azure/firewall/overview#known-issues https://learn.microsoft.com/en-us/azure/firewall/firewall-known-issues#azure-firewall-standard
update link ... fw metrics
https://learn.microsoft.com/en-us/azure/firewall/logs-and-metrics#metrics https://learn.microsoft.com/en-us/azure/firewall/metrics
read aloud .. mispronounces .. adding dashes
SpoketoSpoke, SpoketoInternet, and SpoketoHybrid
Spoke-to-Spoke, Spoke-to-Internet, and Spoke-to-Hybrid
contextual
this page
firewall performance
correct .. bookmark link
https://learn.microsoft.com/en-us/azure/firewall/fqdn-tags#current-fqdn-tag https://learn.microsoft.com/en-us/azure/firewall/fqdn-tags#current-fqdn-tags
https://learn.microsoft.com/en-us/powershell/module/az.network/set-azfirewall?view=azps-12.2.0#4--deallocate-and-allocate-the-firewall https://learn.microsoft.com/en-us/powershell/module/az.network/set-azfirewall?view=azps-12.2.0#example-4-deallocate-and-allocate-the-firewall
https://learn.microsoft.com/en-us/azure/advisor/advisor-reference-reliability-recommendations#create-azure-service-health-alerts-to-be-notified-when-azure-problems-affect-you https://learn.microsoft.com/en-us/azure/advisor/advisor-reference-reliability-recommendations#create-an-azure-service-health-alert
broken link
https://learn.microsoft.com/en-us/azure/firewall/logs-and-metrics#metrics https://learn.microsoft.com/en-us/azure/firewall/metrics#firewall-metrics
https://learn.microsoft.com/en-us/azure/firewall/logs-and-metrics#metrics https://learn.microsoft.com/en-us/azure/firewall/metrics#firewall-metrics
https://learn.microsoft.com/en-us/azure/advisor/advisor-operational-excellence-recommendations#ensure-you-have-access-to-azure-cloud-experts-when-you-need-it

doesn't exist

https://learn.microsoft.com/en-us/security/benchmark/azure/baselines/advisor-security-baseline?toc=/azure/advisor/toc.json#pa-7-follow-just-enough-administration-least-privilege-principle

doesn't exist

Policy definitions .. several deprecated
[Deprecated]: Azure firewall policy should enable TLS inspection within application rules https://portal.azure.com/#blade/Microsoft_Azure_Policy/PolicyDetailBlade/definitionId/%2Fproviders%2FMicrosoft.Authorization%2FpolicyDefinitions%2Fa58ac66d-92cb-409c-94b8-8e48d7a96596
[Deprecated]: Azure Firewall Premium should configure a valid intermediate certificate to enable TLS inspection https://portal.azure.com/#blade/Microsoft_Azure_Policy/PolicyDetailBlade/definitionId/%2Fproviders%2FMicrosoft.Authorization%2FpolicyDefinitions%2F711c24bb-7f18-4578-b192-81a6161e1f17
[Deprecated]: Bypass list of Intrusion Detection and Prevention System (IDPS) should be empty in Firewall Policy Premium https://portal.azure.com/#blade/Microsoft_Azure_Policy/PolicyDetailBlade/definitionId/%2Fproviders%2FMicrosoft.Authorization%2FpolicyDefinitions%2Ff516dc7a-4543-4d40-aad6-98f76a706b50
[Deprecated]: Firewall Policy Premium should enable all IDPS signature rules to monitor all inbound and outbound traffic flows https://portal.azure.com/#blade/Microsoft_Azure_Policy/PolicyDetailBlade/definitionId/%2Fproviders%2FMicrosoft.Authorization%2FpolicyDefinitions%2F610b6183-5f00-4d68-86d2-4ab4cb3a67a5
[Deprecated]: Firewall Policy Premium should enable the Intrusion Detection and Prevention System (IDPS) https://portal.azure.com/#blade/Microsoft_Azure_Policy/PolicyDetailBlade/definitionId/%2Fproviders%2FMicrosoft.Authorization%2FpolicyDefinitions%2F6484db87-a62d-4327-9f07-80a2cbdf333a
[Deprecated]: Subscription should configure the Azure Firewall Premium to provide additional layer of protection https://portal.azure.com/#blade/Microsoft_Azure_Policy/PolicyDetailBlade/definitionId/%2Fproviders%2FMicrosoft.Authorization%2FpolicyDefinitions%2Ff2c2d0a6-e183-4fc8-bd8f-363c65d3bbbf
Before selecting the "Create pull request" button:

Enter a meaningful title above^, using a prefix if necessary and keywords "New" or "Update" indicating the nature of changes.

Describe the summary, scope, and intent of this PR:
[REPLACE-THIS-TEXT]

Insert links(s) to any related work item(s) or supporting detail:
[DELETE-OR-REPLACE-THIS-TEXT]

AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.
These are common guidelines for contributions across the repos managed by the Cloud Architecture Content Team (CACT). Some repositories may have additional specific requirements that are not listed here.
Guidance for all contributors

Topic
Guidance

Draft PR
If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.

ms.date metadata
Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.

Placement and linking
If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).

PR build
After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.

Publishing
Following a successful merge, most repos publish to the live site at least once per (business) day, usually around 10am Pacific.

Additional resources
Learn.Microsoft.Com contributor guide

Additional guidance for private repos and internal contributors

Topic
Guidance

PR size
If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/Contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.

PR title prefix
Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:[Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)[LinkFix] - recurring/adhoc PRs to correct link URLs[Pipeline] - new/updated contributor success pipeline content[WIP] - a work-in-progress draft requiring several days/weeks

PR preview
Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.

PR sign-off (public repo)
If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.

PR sign-off (private repo)
After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.Your PR may be selected for initial review by the CACT. Following CACT review, you may receive questions or requests for additional changes. You should have initial feedback from CACT review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers in your PR and someone will get back to you. After CACT review is complete, a CACT #sign-off will be added.Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).

Additional resources
Learn.Microsoft.Com internal contributor guideAuthoring templates: architecture-center-pr, well-architected-prTo contact the CACT use e-mail, or @mention our GitHub team in your PR comments using: @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers

@microsoft-github-policy-service agree company="Microsoft"

Thank you for your contribution @annadeAz . There are some policies to add, I will do that in a future update.
Regards.

#sign-off

#sign-off


Merge 0.8 into 1.x

[ ] Sort the gazillion merge conflicts

Closing in favour of #1601 since we should be using an intermediary brach when merging between versions as fixing the conflicts would require commits directly on the 0.8 branch, which should remain intact.


harbbor preheat can not connect dragonfly2

dragonfly2 has deployed,but harbbor preheat can not connect dragonfly2
harbor log
2024-11-14T03:39:58Z [ERROR] [/pkg/p2p/preheat/provider/client/http_client.go:75]: Get http://<IP_ADDRESS>:18080/_ping with cred=&{OAUTH map[]}, params=map[], options=map[]: no credential data provided
2024-11-14T03:39:58Z [ERROR] [/lib/http/error.go:57]: {"errors":[{"code":"UNKNOWN","message":"unknown: no credential data provided"}]}

bu config manager insecureSkipVerify
      preheat:
        # -- registryTimeout is the timeout for requesting registry to get token and manifest.
        registryTimeout: 1m
        tls:
          # -- insecureSkipVerify controls whether a client verifies the
          # server's certificate chain and hostname.
          insecureSkipVerify: true
        # # caCert is the CA certificate for preheat tls handshake, it can be path or PEM format string.
        # caCert: ''

@MouseSun846 Please provide the version of the harbor.

Without authentication, it can be connected, but the image preheating is stuck at 0%

@MouseSun846 Please refer to the version compatible table: https://goharbor.io/docs/edge/administration/p2p-preheat/

ok, Thanks you.


Add 3 new terms

Description
Added 3 new web 3.0 terms with short descriptions that follow the guidelines.
Fixes #35
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I ran the sort command to make sure all terms are sorted
[x] My changes generate no new warnings
[x] Existing unit test passes locally with my changes

Thanks for your contribution @choubari


many_cubes: Add a cube pattern suitable for benchmarking culling changes

Objective

Add a cube pattern to many_cubes suitable for benchmarking culling changes

Solution

Use a 'golden spiral' mapped to a sphere with the strategy of optimising for average nearest neighbour distance, as per: http://extremelearning.com.au/how-to-evenly-distribute-points-on-a-sphere-more-effectively-than-the-canonical-fibonacci-lattice/

While investigating:

#3796
I wanted a 3D benchmark to test with. The recent changes to many_cubes seemed promising. However, the pattern of placing cubes on the surface of a large cube produce view-dependent number of visible meshes. This was intended to demonstrate frustum culling is working properly. I needed something more consistent so I found an algorithm for reasonably evenly distributing the cubes on the surface of a sphere. This does indeed maintain the number of visible meshes at fairly consistent numbers, making it more suitable for benchmarking changes to the culling and visibility systems.

Should we consider moving this and bevymark to their own folder? They're not exactly useful as learning material IMO.

I think it could be useful to have a place for tests/benchmarks that exercise various aspects of the engine and enable developers to test/check things without having to (re)write the same things over and over. At least I find I’m very commonly using examples, possibly slightly modified, for testing various things during development. I also think we should make a gltf viewer out of load_gltf and a flying camera implementation like that in the shadow biases example. But that’s all off topic for the PR. :)

Agreed; we should consider that in a separate PR I think.

Could more people test this example to ensure it doesn't cause dizziness or discomfort?

Should we consider moving this and bevymark to their own folder? They're not exactly useful as learning material IMO.

bevy_mark, many_sprites, many_cubes, text_debug and font_atlas_debug come to mind. But yes, another PR 🙂

@superdump could you also update the few ..Default::default() that slipped through in the last PR on that example to the new ..default()?

@superdump could you also update the few ..Default::default() that slipped through in the last PR on that example to the new ..default()?

Done.

bors try

bors try

Oh, I thought the test progress would be shown at the bottom and it had failed again. I see the status is elsewhere.

bors r+

We had a couple sets of eyes on this for nausea, and this is a very niche example. We can tweak it later if we get complaints.


Allow setting of requests/limits on VMExport pod

What this PR does / why we need it:
Currently the VMExport pod won't start inside a namespace with a quota. It will also not work inside a namespace with a specific limit range ratio. This commit allows one to specify the requests and limits of the VMExport pod, and it adds some defaults so it will work inside a namespace with a quota.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # RHBZ 2236422
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[X] PR: The PR description is expressive enough and will help future contributors
[X] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[X] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

BugFix: VMExport now works in a namespace with quotas defined.

/test pull-kubevirt-e2e-k8s-1.27-sig-compute-migrations

/lgtm

/test pull-kubevirt-e2e-k8s-1.26-sig-compute

/cherrypick release-1.0

/cherrypick release-0.59


[Select] Typeahead doesn't work on a closed Select

When a Select is closed but focused, pressing a character key should open it and move focus to the first option matching the pressed key. Currently, pressing character keys on a closed Select has no effect.
Search keywords:

@michaldudak, this issue (https://github.com/mui/material-ui/issues/42539) seems related. But instead it describes cycling through options in a closed state when a character key is pressed, similar to the behavior in the native Select (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select).
Modified code:
<label for="pet-select">Choose a pet:</label>
<select name="pets" id="pet-select">
  <option value="">--Please choose an option--</option>
  <option value="dog 1">Dog 1</option>
  <option value="dog 2">Dog 2</option>
  <option value="hamster">Hamster</option>
  <option value="parrot">Parrot</option>
  <option value="spider">Spider</option>
  <option value="goldfish">Goldfish</option>
</select>

Can you take a look at https://github.com/mui/material-ui/issues/42539?

Thanks for letting me know!
@colmtuite, FYI, we can consider it when designing the overhauled Select.


Ansible Deployment for Windows

Install splunk-otel-collector using Ansible for Windows following MSI installer approach.
Downloading and installing Splunk-otel collector and FluentD for Windows.
Setting up appropriate Registry Values for Windows.
Updated README.md.

I have committed suggested changes in the latest commit

Fetch latest version of splunk-otel-collector.
Push custom config file from source to dest for fluentd & splunk-otel-collector.
Updated ENV VARS.
Updated Readme file.

Please Review and suggest any additional changes, if required.

Please add windows to the CI https://github.com/signalfx/splunk-otel-collector/blob/main/.github/workflows/ansible.yml#L55 and rebase on the latest main

Hello @dmitryax
Updated the PR with suggested changes.
Can you please review it.
Also, guide me if any other changes are needed on this PR.

Hello @dmitryax
Updated the PR with suggested changes.
Can you please review it.

Hello @dmitryax
Updated the PR with suggested changes.
Can you please review it.

@jcheng-splunk PTAL. Requested changes still blocks the merge


Set component as tooltip content

I'm creating a large tooltip with your plugin at the moment. It would be useful when I'm abled to use a component as the tooltip-content. That would allow me to make my code more clearer.

Yeah, that would come very handy for me as well. It'd be a nice feature to add.
Thanks for this great plugin :)

👍

Totally agreed with that.

As I currently see this, you will be able to use a new <Tooltip> component with a target slot and a content slot that can contain any components.
For example:
<Tooltip
  position="top-center"
  :class="{ foo: bar }"
>
  <button slot="target">Hover me!</button>
  <template slot="content">
    <MyComponent />

I'm a tooltip!

  </template>
</Tooltip>

Thank you very much for your reply!
I just tested your suggestion but it don't seem to work.
Here is a snippet of code I used:
          <vtooltip position="right" :class="{ foo: bar }">

                A

            <template slot="content">

hi!

            </template>
          </vtooltip>

</template>


Add dates indent fix

The ERB indentation for app/views/observations/form/_projects.html.erb confused me.  I think this achieves the same goal, but is less confusing to me.  Not 100% sure it achieves all the same things.

coverage: 94.48%. remained the same
when pulling f6fcb26b5d8afeb034f9dfd86ebaf7b0173e9ec0 on njw-add-dates-indent-fix
into 8d85b7681fa037610d32df1f3530a85d477a1cb3 on jdc-project-add-dates.


Fix app registration

[ ] All speced functionally is implemented and is working
[ ] Unit tests for all functions and modules
[ ] Integration tests for all use cases
[ ] Comment documentation for all modules, functions and types
[x] Ready for code review

hi - is this your main working branch? should I pull & play - what supposed to be working in it?

@avive Yes please


AO-15467: Enable gzip compression for gRPC by default

Enable gzip compression for the gRPC connection.
See https://swicloud.atlassian.net/browse/AO-15467

Codecov Report

Merging #140 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   82.08%   82.04%   -0.04%
==========================================
  Files          37       37
  Lines        4588     4590       +2
==========================================
  Hits         3766     3766
- Misses        698      699       +1
- Partials      124      125       +1

Impacted Files
Coverage Δ

v1/ao/internal/reporter/reporter_grpc.go
70.28% <0.00%> (-0.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45205c9...17e29a4. Read the comment docs.

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   82.09%   82.09%
=======================================
  Files          37       37
  Lines        4590     4590
=======================================
  Hits         3768     3768
  Misses        698      698
  Partials      124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e29a4...692ba7e. Read the comment docs.


Fixes issue #1210

I fixed issue #1210 .
Before:

After:

for incorrect email .

for correct email.

Please add labels of gssoc and level .

@khushi-joshi-05  please review my PR.


dovecot: fix CVE-2017-15132

Motivation for this change
fixes CVE-2017-15132
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg test dovecot

Failure on x86_64-linux (full log)
Partial log (click to expand)
cannot build derivation ‘/nix/store/cxh98bpkhkya58b7bwdlg721n9m4ar87-system-units.drv’: 4 dependencies couldn't be built
building path(s) ‘/nix/store/d56zhd0ymrz4346c9mp7m18rnji57yn1-users-groups.json’
cannot build derivation ‘/nix/store/vn7nxaqs454gv0rz3dvcy8wvr074szgp-etc.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/bx2qmjkm0cdd72zp7ylmjfy2pspkihdv-nixos-system-machine-18.03.git.90496ed.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/5fki1fdbb7jqjhyjrj52wjzbs5hvn5ik-closure-info.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/abg01yhf4ys5gdnj4qcmf2n7qrfjymgl-run-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/xikx9l5lykayamyrvvwswr3ddacsiycp-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/3rxipaj69cs7kqhy26lyp57r4iymszy0-nixos-test-driver-dovecot.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/w5wqihycywkbigrd9rw3kbmsba8qqd1x-vm-test-run-dovecot.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/w5wqihycywkbigrd9rw3kbmsba8qqd1x-vm-test-run-dovecot.drv’ failed

Failure on aarch64-linux (full log)
Partial log (click to expand)
building '/nix/store/vfnw01y3g677kfvs9m53vvhrr1839zl2-unit-postfix.service.drv'...
cannot build derivation '/nix/store/4idg3l29lyp3y9zibixjqiw45gzch5iy-system-units.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/249im139hjry15cq5vs0841vdsrh1lq5-etc.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/z3kss4wns99v5v9qsx5cvzzmzgr9yxd9-nixos-system-machine-18.03.git.90496ed.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/yy2rszx5i7lyc8gkpgnhvm0s5vgn72jj-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1ygrnfa1c42b66sxk40a7rjccizlg2nw-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3k32wqnggikil6s2lfpsish6ralzrgg2-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9fd4q5kzrzfvsxmnjllr988w6vsq8d9x-nixos-test-driver-dovecot.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8hsqqlnq7yc0h38lldgnqgrg57gq86g6-vm-test-run-dovecot.drv': 1 dependencies couldn't be built
error: build of '/nix/store/8hsqqlnq7yc0h38lldgnqgrg57gq86g6-vm-test-run-dovecot.drv' failed

@GrahamcOfBorg test dovecot

Success on x86_64-linux (full log)
Partial log (click to expand)
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 15.84s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-dovecot.drv-0/vde1.ctl': Directory not empty
/nix/store/161326b8hgpsqv4crgz5ya4nqp15ymg3-vm-test-run-dovecot

Failure on aarch64-linux (full log)
Partial log (click to expand)
cannot build derivation '/nix/store/mxji31xfx63iak66h09l8nn29yjlnay4-system-units.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ld14c9swgnd7zlsw07i15dskn2kkjwrs-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/i1k7bz9r2vmnhsk62rpydr759rjl3li2-etc.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/ffw64ivlasmjbxawzx4gsh0w3c51659h-nixos-system-machine-18.03.git.e27e026.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/80qa8nslrlnjppq67k7xjgsz80hsn7l7-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vkkinhgsm58nmjqb87dc9jdjyjv3n52p-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/i2bj9l32lympy6v8wly2gkkycra9gx0m-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wwcn0hi9wkn8xgzb5x505pw3xjkbh46q-nixos-test-driver-dovecot.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7cawlmqrwjaaz138msl0b7f3a9fgk1a9-vm-test-run-dovecot.drv': 1 dependencies couldn't be built
error: build of '/nix/store/7cawlmqrwjaaz138msl0b7f3a9fgk1a9-vm-test-run-dovecot.drv' failed


Trigger prod bundle release-0.21.3

Description of changes:
Trigger prod bundle release-0.21.3
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


The inference speed of Switch Transformer

Thanks for a nice implementation of Switch Transformer here https://nn.labml.ai/transformers/switch/.
In the original paper, the speed is slower than T5-BASE but they used much einsum in code. I see you choose index operation to handle different experts. I have a question about how this implementation speed compares to the original Transformer (not using switch layer).

The original paper uses a distributed implementation where each expert was running on its own device (GPU). Our implementation has all the experts on a single device. It's slower than a transformer without a switch layer, but has more parameters. It's faster than the original transformer with the same number of parameters.

Thanks~ BTW, in the original paper although they use separate devices for different experts, Switch Transformer is also slower than original Transformer.


Floodplain population <1000 decimal place

Where the population in the floodplain is under 1,000 (like BK 2), remove the decimal place

@chriswhong I've pushed a fix for this in PR #464. I've also renamed the old Carto table and added a new one with numbers instead of strings. Everything seems to be working. But please double-check this. Once #464 is merged, we can close this.


proper_case fixes

Pull in @puneetloya's fix to the proper_case check (thanks!) from #2550.
Also remove proper_case from Mapping: it's a listener thing, and was a no-op in Mapping.
Testing
Tested by hand:

no Ambassador module
Ambassador module with proper_case: true
Ambassador module with proper_case: false
Ambassador module that doesn't mention proper_case at all

Known broken link, merging.

thanks a ton :)


Update installation instructions

Closes #698 and #718. According to the notes I gathered during recent installation/CI runs, this PR

recommends the libmamba solver when installing via conda
corrects the dependency arguments (or adds them) when using pip
recommends adding the main repo as remote upstream and fetches the tags from there

How to review

Read the diff and note that the CI checks all pass.
Build the documentation and look at the installation page.

PR checklist

[x] Continuous integration checks all ✅
Except for macos-latest-py3.7 per iiasa/ixmp#484.
[x] ~Add or expand tests;~ coverage checks both :white_check_mark:
[x] Add, expand, or update documentation.
~Update release notes.~ Not applicable.

Thanks @glatterf42! 🚀


fix(firestore-bigquery-export): Improved import script

Solution
This PR looks to improve on the previous script by introducing a multi-threaded approach to processing multiple blocks of data simultaneously. This will ensure that performance is improved while avoiding timeouts as data is chunked for individual processes.
Features

[x] Multi-threaded approach for importing data into separate workers.
[x] Automatic calculation of threads, based on the machine capabilities.
[x] Refactored project into a flat structure for separating code modules.
[x] Utilises getPartitions for quickly splitting collectionGroup data
[x] Custom solution for separating collection data into partitions.
[x] Removed previous dependency on file system providing reduced complexity and bugs.

Caveats / future updates
Until a future api exists for collection, a custom function will be needed. Future work would allow collections and subCollections to use the same logic with getPartitions.
The same number of parameters are needed. BatchSize and queryCollectionGroup could be removed in the future with updates to collection partitions.

@googlebot I consent.

Codecov Report

Merging #656 (16036e2) into next (612cbbf) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 16036e2 differs from pull request most recent head 6a1e552. Consider uploading reports for the commit 6a1e552 to get more accurate results

@@           Coverage Diff           @@
##             next     #656   +/-   ##
=======================================
  Coverage   50.65%   50.65%
=======================================
  Files          30       30
  Lines        1313     1313
  Branches      193      193
=======================================
  Hits          665      665
  Misses        647      647
  Partials        1        1


Big picture not showing in nextbit OS

Expected Behaviour
Show the picture if expanded when style is set to "PICTURE".
Actual Behaviour
Expanding the notification but it is showing full white rather than showing a picture.
Reproduce Scenario (including but not limited to)
This is only happening for nextbit OS mobile device is nextbit robin running the android 7.1.1
Steps to Reproduce
Sending the below payload to the nextbit robin device
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 7.1.1
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
nextbit
Cordova CLI version and cordova platform version
cordova --version: 5.0.0
cordova platform version android : 5.1.1

Plugin version
cordova plugin version | grep phonegap-plugin-push : 1.5.3

Sample Push Data Payload
{
  "title":"sample",
  "body":"sample",
  "style":"picture",
   "picture:":"https://www.elivio.com/assets/elivio/img/banners/10.png"
}

Attaching the image that looks like in the robin device

For the same payload it is working fine in other devices like moto g3 , honor running android 7 etc.
Extra information is , in the robin devices for other apps are working with picture style

@pavankumarkatakam not sure if I'll be able to fix it as I don't have access to nextbit device. Can you try to reproduce while running adb logcat | grep Push?

Hi @macdonst, Surely I will share you the details of logcat today. More information on the issue is it is not working in devices

Obi SF1 running 5.0.2
Nexus 6p running 7.1.2

@pavankumarkatakam any update on this? I can't reproduce it.

Hi, I can confirm that the payload is correct since it is working in other devices and the image is showing. More info about is the same payload is not able to show image sometimes and showing sometimes i have attached the images please check

Is there any effect depending on image format, battery, and the internet for showing push notification.

@pavankumarkatakam I can only speculate without logs. The Nextbit may just have a bug with regards to picture messages or there could be some program running on the Nextbit preventing the download of the image, etc.

Facing this issue in another device of my own brother it is Oneplus 3 running 7.1.1 . Today I sent 10 push notification to this device but only one-time image is not showing.

@pavankumarkatakam I feel for you but I can't do much without some logs to tell me what is going on. I do have a OnePlus device here that I can't reproduce the problem on.

Ok then I will send logs related to Oneplus3 when the image is not showing.

Issue is reproducing in moto c + as well as in one plus 3, android 7 , when the devices are in sleep mode , for more than 30 minutes.

Thanks @sk16 , Im actually unable to reproduce it but now i got it if the mobile is in sleep mode then img not noting but after than it is showing.

push4.txt
Here is android logs . Please check . I have send two push notification . In first Push notification , image did'nt work properly . But it came in second push notification .
Steps to Reproduce

Put device into sleep for more than 30 minutes
Send push notification.

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 7.0.0 . Reproducible only in android 7 .
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Moto c+ , one plus 3
Sample payload :
{
"default": "Enter default message here",
"GCM": "{"data":{"notId": 5,"priority": 1,"message":"The internet is built on cat pictures","title":"On Android if you want your on('notification') event handler to be called when your app is in the background it is relatively simple.","image": "www/styles/images/app_icon_180.png","delay_while_idle": "false","link": "profile","type": "0","summaryText": "The internet is built on cat pictures","style": "picture","picture": "https://learnyst.s3.amazonaws.com/assets/schools/1247/resources/pushMessage/images/login_screen_bg_mjl2q9.png\"}}"
}

@pavankumarkatakam  can u tell me issue is reproducing with images with http or https ? I am not able to reproduce the issue with http images.

Still, im not able to reproduce but all the images im using is https because if using s3 to host my all images.

@sk16 there's not much I can do if the HttpUrlConnection times out.

Can we retry (exp backoff) if it times out

Closing, can't reproduce.


Plural result count using wrong string

The result count for plural results appears to be using the incorrect string. Observe on:
https://en-gb.wordpress.org/openverse/search/image?q=dogs

The string seems to be translated correctly in the translation project.

@0kyn this is a really interesting discovery—thank you so much! I'll see what we can do about it.

Resolved, closing.


feat: support the ability to sense client disconnection

What type of PR is this?

feat
Check the PR title.

[ ] This PR title match the format: <type>(optional scope): <description>
[ ] The description of this PR title is user-oriented and clear enough for others to understand.
[ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: feat: support the ability to sense client disconnection
zh(optional):
支持感知客户端连接断开的能力

仅用于 netpoll
需要与 WithOnconnect 配合使用
开启后会有较大的开销

(Optional) Which issue(s) this PR fixes:

#855
(Optional) The PR that updates user documentation:

Is this PR still in process/valid?

This PR should be able to close, hertz cannot solve this problem


setState() called after dispose()

thanos_snap_effect: ^0.0.8
flutter: 3.24.3
Problem Description
When using the DeleteAnimatedContainer widget with the thanos_snap_effect package, I encounter the following error after the afterAnimation callback removes the item from the list:
flutter: SHOUT: 2024-12-12 10:02:25.144586 Unhandled exception setState() called after dispose(): _ShaderBuilderState#218b4(lifecycle state: defunct, not mounted)
This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback.
The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree.
This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose().
flutter: #0      State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9)
#1      State.setState (package:flutter/src/widgets/framework.dart:1202:6)
#2      _ShaderBuilderState._initShader (package:thanos_snap_effect/src/shader_builder.dart:62:5)
<asynchronous suspension>

Here is my code sample:
class DeleteAnimatedContainer extends StatefulWidget {
  const DeleteAnimatedContainer({
    super.key,
    required this.needAnimate,
    required this.afterAnimation,
    this.wipeDuration = const Duration(milliseconds: 1500),
    this.scaleDuration = const Duration(milliseconds: 750),
    required this.child,
  });

  final Duration wipeDuration;
  final Duration scaleDuration;
  final bool needAnimate;
  final VoidCallback afterAnimation;
  final Widget child;

  @override
  State<DeleteAnimatedContainer> createState() => _DeleteAnimatedContainerState();
}

class _DeleteAnimatedContainerState extends State<DeleteAnimatedContainer> with TickerProviderStateMixin {
  late final AnimationController _controller;
  late final AnimationController _scaleController;
  late final Animation<double> _scaleAnimation;

  @override
  void dispose() {
    _controller.dispose();
    _scaleController.dispose();
    super.dispose();
  }

  @override
  void initState() {
    super.initState();
    _controller = AnimationController(
      duration: widget.wipeDuration,
      vsync: this,
    );

    _scaleController = AnimationController(
      duration: widget.scaleDuration,
      vsync: this,
    );

    _scaleAnimation = Tween<double>(begin: 1.0, end: 0.0).animate(
      CurvedAnimation(
        parent: _scaleController,
        curve: Curves.easeInOut,
      ),
    );
  }

  @override
  void didUpdateWidget(covariant DeleteAnimatedContainer oldWidget) {
    super.didUpdateWidget(oldWidget);
    if (widget.needAnimate == oldWidget.needAnimate) return;

    if (widget.needAnimate && mounted) {
      _startAnimation();
    }
  }

  @override
  Widget build(BuildContext context) {
    return AnimatedBuilder(
      animation: _controller,
      builder: (_, __) {
        return SizeTransition(
          sizeFactor: _scaleAnimation,
          axis: Axis.vertical,
          child: Snappable(
            animation: _controller.view,
            child: widget.child,
          ),
        );
      },
    );
  }

  void _startAnimation() {
    _controller.forward().then((_) => widget.afterAnimation());
    _scaleController.forward();
  }
}

I think the problem is in lib/src/shader_builder.dart in  _initShader() func, maybe add mounted check before setState() ?

It looks strange since the _initShader is usually called during the Snappable widget initialization. @Marabushka Could you please provide a code sample of using the DeleteAnimatedContainer widget?

@ArkhipenkaPiotr
InfinityScrollListener(
        onStartReached: onStartReached,
        onEndReached: onEndReached,
        child: ScrollablePositionedList.builder(
          itemScrollController: itemScrollController,
          itemPositionsListener: itemPositionsListener,
          reverse: true,
          itemCount: count,
          padding: EdgeInsets.only(bottom: 12.0, top: topMargin + 12.0),
          itemBuilder: (context, index) {
            if (index == messageList.length) {
              return const MessageInProgressListTile();
            }
            final message = messageList[index];
            final operations = message.operations(
              messageDeletionAbilityTimeout: messageDeletionAbilityTimeout,
              streamOwner: stream is StreamWithMultipleUsers ? stream.owner : null,
            );

            final messageTile = MessageListTile(
              stream: stream,
              message: message,
              onReplyTap: onReplyTap,
              onOpenGallery: onOpenGallery,
              lastReadId: lastReadId,
              jumpFromId: jumpFromId,
              jumpToId: jumpToId,
              previousMessage: index < messageList.length - 1 ? messageList[index + 1] : null,
              nextMessage: index > 0 ? messageList[index - 1] : null,
              onForwardedTap: message is Message && message.originalMessage?.owner is! UserGuest
                  ? () => onForwardedTap(message.forwardStreamId, message.forwardSenderId)
                  : null,
              onOpenUserProfile: onOpenUserProfile,
              onRetry: message is MessageDraft && message.status.isUndelivered ? () => onRetrySend(message) : null,
              onCancel: message is MessageDraft ? () => onCancelSend(message) : null,
              onDelete: operations.contains(MessageOperation.delete) ? onDelete : null,
              onCopy: onCopy,
              onEdit: onEdit,
              onReply: onReply,
              onForward: onForward,
              onEntityLinkTap: onEntityLinkTap,
              onMentionTap: onMentionTap,
              onUrlTap: onUrlTap,
              onPopupShow: (overlay) {
                FocusScope.of(context).requestFocus(FocusNode());
                onPopupShow(overlay);
              },
              onPopupClose: onPopupClose,
              onMeet: onMeet,
              onMeetDownloaded: onMeetDownloaded,
              onJumpToIdCompleted: onJumpToIdCompleted,
              padding: _getSeparatorValue(index),
              messageEditingAbilityTimeout: messageEditingAbilityTimeout,
            );

            return message is Message
                ? DeleteAnimatedContainer(
                    key: ValueKey(message.id),
                    needAnimate: message.id == needDeleteMessage,
                    afterAnimation: () => onDeleteComplete != null ? onDeleteComplete(message.id) : null,
                    child: messageTile,
                  )
                : messageTile;
          },
        ),
      ),
    );
  }

There are a lot of context variables, please provide a full file to reproduce it @Marabushka

@ArkhipenkaPiotr
Due to our privacy policy, I am unable to share the exact implementation. However, I managed to resolve the issue by limiting the rebuilding of the DeleteAnimatedContainer widget in my application.
That being said, I still believe it would be beneficial to add a mounted check in the _initShader() function. Since _initShader()  involves asynchronous operations, there is a possibility that the widget might be disposed of before the operation completes. Adding this check would make the implementation more robust and prevent similar issues in the future.

@Marabushka The fix has been pushed to master, thank you for the suggestion.