[Issue]: Unable to Set Cache Directory in Read-Only File System Environments

Describe the issue
I am using the Autogen library in an AWS Lambda environment and I am encountering an issue related to the cache directory.
In AWS Lambda, the file system is read-only except for the /tmp directory. However, when I use the UserProxyAgent, GroupChat, or GroupChatManager classes in the Autogen library, it seems that they are trying to create a cache directory at .cache/41, which is not writable in AWS Lambda. This results in an OSError: [Errno 30] Cache directory ".cache/41" does not exist and could not be created.
I tried to set the cache directory to /tmp using the Completion.set_cache(cache_path_root="/tmp") method, but it seems that the UserProxyAgent, GroupChat, or GroupChatManager classes are creating their own instances of the Completion class, which use the default cache directory .cache.
Unfortunately, the Autogen library does not seem to provide a way to change the cache directory for these classes directly. I would like to ask if there is a way to set the cache directory for these classes to /tmp or if there is a workaround for this issue.
I would appreciate any assistance you could provide.
Steps to reproduce
No response
Screenshots and logs
No response
Additional Information
No response

@sonichi

try: OpenAIWrapper.cache_path_root="/tmp"
Completion is deprecated for openai>=1

This should be part of the llm_config, which we should use a typed class rather than a dict that user must guess it's schema.

thanks @sonichi that resolved it

@alexpwrd & @sonichi could you help me with my code below, please :
`from flask import Flask, request
import os
import autogen
from autogen import AssistantAgent, UserProxyAgent, GroupChat, GroupChatManager, Cache, OpenAIWrapper
app = Flask(name)
api_key = os.getenv('AZURE_OPENAI_API_KEY')
azure_endpoint = os.getenv('AZURE_OPENAI_API_ENDPOINT')
api_version = os.getenv('AZURE_OPENAI_API_VERSION')
config_list = [
{
"model": "gpt-4",
"api_key": api_key,
"api_type": "azure_openai",
"azure_endpoint": azure_endpoint,
"api_version": api_version
}
]
llm_config = {
"config_list": config_list
}
class ResumableGroupChatManager(GroupChatManager):
def init(self, groupchat, history, **kwargs):
print("Initializing ResumableGroupChatManager with history:", history)
# self.groupchat = groupchat
if history:
groupchat.messages = history
super().init(groupchat=groupchat, **kwargs)
if history:
self.restore_from_history(history)
def restore_from_history(self, history) -> None:
    print("Restoring history...")
    self.groupchat.messages = history
    for message in history:
        print("Replaying message:", message)
        for agent in self.groupchat.agents:
            if agent != self:
                print(f"Sending to {agent}: {message}")
                self.send(message['content'], agent, request_reply=False)

@app.route('/query', methods=['POST'])
async def post_query():
message = request.json.get("message")
history = request.json.get("history", [])  # Default to an empty list if not provided
print("Received message:", message)
print("Received history:", history)
with Cache.disk(cache_path_root="./temp/autogen_cache") as cache:
    assistant = autogen.AssistantAgent(
        name="assistant",
        llm_config=llm_config,
        system_message="You're a helpful assistant.\nIf you need more info, ask the user for anything missing."
    )
    user_proxy = autogen.UserProxyAgent(
        name="user_proxy",
        human_input_mode="NEVER",
        code_execution_config=False,
        is_termination_msg=lambda message: True  # Always True
    )
    weather_assistant = autogen.AssistantAgent(
        name="weather_assistant",
        llm_config=llm_config,
        max_consecutive_auto_reply=3,
        system_message="You're a helpful assistant to get the weather.\nYou ONLY say the weather in Paris is Hot, then return it."
    )
    chitchat_assistant = autogen.AssistantAgent(
        name="chitchat_assistant",
        llm_config=llm_config,
        max_consecutive_auto_reply=3,
        system_message="You're a helpful assistant for chitchat. \n You answer user's questions about their day."
    )

    groupchat = autogen.GroupChat(
        agents=[assistant, user_proxy, weather_assistant, chitchat_assistant],
        messages=[]
    )
    manager = ResumableGroupChatManager(
        name="Manager",
        groupchat=groupchat,
        history=history,
        llm_config=llm_config,
    )

    new_message = await user_proxy.a_initiate_chat(manager, message=message, clear_history=False, cache=cache)
    print('new_message: ', new_message)

    last_message_content = new_message.chat_history[-1]['content']

    print('last_message_content :', last_message_content)
    print("Final messages in groupchat:", groupchat.messages)

    return {
        "response": groupchat.messages[-1] if groupchat.messages else "No response generated",
        "history": groupchat.messages,
        # "history": new_message.chat_history,
    }

if name == "main":
app.run(debug=True)
`

this is still broken for Lambda deployments.  currently investigating.
Thought i had a workaround by monkey patching Cache.disk to no avail...
it's something to do with this hardcoded LEGACY_CACHE_DIR in the OpenAIWrapper.  If anyone knows offhand what else to look for let me know as i'm still relatively new to Python

I'm having the same issue even with the provided solutions. Has anyone been able to fix it?


feat: add an install script like in GECKO3

Main improvements in this PR:
Added an install script:
To install Human-GEM:
cd to root of Human-GEM
HumanGEMInstaller.install
to uninstall:
HumanGEMInstaller.uninstall
What the installation does is to setup the MATLAB path (and remove Human-GEM from it at uninstall). This is very useful when you have multiple versions of Human-GEM on your disk.
I hereby confirm that I have:

[X] Tested my code on my own computer for running the model
[X] Selected develop as a target branch

Finally, an actual solution to #136! Thanks @johan-gson

Hi Mihail, this code doesn't work for me, you are not adding the subfolders in code and so forth (at least not on my computer). Could you either fix that (you could use my previous strategy for the code subtree) or revert this? I simply don't have time to dig further into this now, but I think it is important that it works.

Or, was there something here I didn't get? Are you saying that we don't need to add all the subfolders? I don't think MATLAB will find the code otherwise, right?

And, I realize I technically committed the code :). Still, I don't know if you want to work more or go back :)

And, I realize I technically committed the code :). Still, I don't know if you want to work more or go back :)

It's fine, I'd like to continue fixing the obvious genpath that I forgot to add. For some reason I'm having VPN issues so Matlab won't start.

Looks good, it seems to work now!

Looks good, it seems to work now!

Also when changing directory and trying to uninstall? I tried to mention before that this check fails unless this script is moved to the code directory, which is in the path, whereas the main Human-GEM directory is not.

So, I added the Human-GEM folder to the path - I think it should be in there. In my opinion, the install script should be there, otherwise people will not find it. I tested, it works.

the install script should be there

I can see arguments on both sides to having the install script in the top level folder or in /code. Perhaps we should ask for other opinions @JonathanRob @haowang-bioinfo ?

would be neat to place it in /code, while a dedicated section explaining install/uninstall with this script should be added to the top level README

I'm ok with the script being in either location. Normally such things would of course be in /code, but an install script is a special case where I can see the benefit of keeping it in a more obvious location.

For me it doesn't matter that much as long as it works. If someone wants to move it, please go ahead!

Looks good, good job Mihail. I'm merging this now!


Issue accessing shader files in UE 4.21

Moving my project from 4.20 to 4.21 while using this plugin i now face an issue for accessing my shader files:

Same :'(

Solved it. You need to add root 'shader' folder back as default path for storing shaders. Explained it all there:
https://forums.unrealengine.com/development-discussion/rendering/1562454-virtual-shader-source-path-link-custom-shaders-4-21


Tooltip of DNS name server is always "ns5.linode.com"

No matter which dns name server my cursor on, the tooltip always shows "ns5.linode.com".
Screenshot (cursor on "ns3.linode.com"):
https://imgur.com/KDFQh8k

Thanks @iredmail I have raised a similar issue few months back #2536


HBASE-25103 Remove ZNodePaths.metaReplicaZNodes

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
1m 41s
master passed

+1 :green_heart:
shadedjars
6m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 30s
the patch passed

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

+1 :green_heart:
shadedjars
6m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  4s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 43s
hbase-zookeeper in the patch passed.

-1 :x:
unit
7m  3s
hbase-server in the patch failed.

37m 50s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e4b34cef5289 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b57bef5b7d

Default Java
1.8.0_232

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/testReport/

Max. process+thread count
942 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 29s
master passed

+1 :green_heart:
checkstyle
2m  5s
master passed

+1 :green_heart:
spotbugs
4m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 14s
the patch passed

+1 :green_heart:
checkstyle
2m  0s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 27s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
4m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

46m 49s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux fcc2a6de1eb6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b57bef5b7d

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  9s
the patch passed

+1 :green_heart:
compile
2m 21s
the patch passed

+1 :green_heart:
javac
2m 21s
the patch passed

+1 :green_heart:
shadedjars
8m 11s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 29s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 19s
hbase-zookeeper in the patch failed.

-0 :warning:
javadoc
0m 48s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 34s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 50s
hbase-zookeeper in the patch passed.

-1 :x:
unit
11m 53s
hbase-server in the patch failed.

56m 52s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 297edba31bb4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b57bef5b7d

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/testReport/

Max. process+thread count
603 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 26s
master passed

+1 :green_heart:
checkstyle
2m  1s
master passed

+1 :green_heart:
spotbugs
4m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
checkstyle
1m 57s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 31s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
4m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

46m 43s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 959bd0c55604 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b57bef5b7d

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HBASE-25103? Does this issue have compatibility problem?

HBASE-25103? Does this issue have compatibility problem?

Oh, changed the title. No compatibility issue, just code change, no actual data and logic change. ZNodePaths is IA.Private.
The follow on issue for changing the way we handle meta replicas will have compatibility issue.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 38s
master passed

+1 :green_heart:
compile
2m  5s
master passed

+1 :green_heart:
shadedjars
8m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 36s
the patch passed

+1 :green_heart:
compile
1m 58s
the patch passed

+1 :green_heart:
javac
1m 58s
the patch passed

+1 :green_heart:
shadedjars
8m 17s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 11s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 48s
hbase-zookeeper in the patch passed.

-1 :x:
unit
156m 47s
hbase-server in the patch failed.

195m  6s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0b018fc02ff8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b57bef5b7d

Default Java
1.8.0_232

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/testReport/

Max. process+thread count
3722 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 19s
the patch passed

+1 :green_heart:
compile
3m 10s
the patch passed

+1 :green_heart:
javac
3m 10s
the patch passed

+1 :green_heart:
shadedjars
9m 47s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-zookeeper in the patch failed.

-0 :warning:
javadoc
1m  1s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
1m  2s
hbase-zookeeper in the patch passed.

-1 :x:
unit
249m 13s
hbase-server in the patch failed.

300m  9s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5a40f565f830 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b57bef5b7d

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/testReport/

Max. process+thread count
2600 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 54s
master passed

+1 :green_heart:
checkstyle
2m  9s
master passed

+1 :green_heart:
spotbugs
4m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  1s
the patch passed

+1 :green_heart:
checkstyle
2m 16s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
15m 18s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
6m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 41s
The patch does not generate ASF License warnings.

53m 51s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 593e075f5ef8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 86557edf2c

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
1m 51s
master passed

+1 :green_heart:
shadedjars
6m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
compile
1m 50s
the patch passed

+1 :green_heart:
javac
1m 50s
the patch passed

+1 :green_heart:
shadedjars
6m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 44s
hbase-zookeeper in the patch passed.

+1 :green_heart:
unit
147m 18s
hbase-server in the patch passed.

180m 39s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4c1bdd37cf78 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 86557edf2c

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/testReport/

Max. process+thread count
3796 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 47s
the patch passed

+1 :green_heart:
compile
2m 49s
the patch passed

+1 :green_heart:
javac
2m 49s
the patch passed

+1 :green_heart:
shadedjars
9m 21s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 35s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 23s
hbase-zookeeper in the patch failed.

-0 :warning:
javadoc
1m  2s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m  3s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 56s
hbase-zookeeper in the patch passed.

-1 :x:
unit
248m 23s
hbase-server in the patch failed.

296m 19s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2464

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2292b30f681f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 86557edf2c

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/testReport/

Max. process+thread count
2821 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2464/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


[CPS-6036]fix: mount xtables file to ipvsdr deployment

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @hanxueluo

Release note:

NONE

/lgtm

/cherrypick release-0.5

/cherrypick release-0.7

/cherrypick release-0.6

/cherrypick release-0.5-2020


Support custom errors

Custom errors cannot be configured to be included in the Markdown report.
When I run solidity-docgen over a contract with lots of custom errors (such as the BalanceSheet), the custom errors are not included in the output.

Thanks for pointing this out! I'd like to fix this, hope I get the time. :pray:

@paulrberg This is solved in the upcoming rewrite (#350). I'll try it out with the contract that you shared!
Can you share an example of what you'd like the output to look like for errors?

This is solved in the upcoming rewrite (#350)

Glad to hear.

Can you share an example of what you'd like the output to look like for errors?

Well custom errors are annotated with NatSpec comments, just like any other function. So treating them as functions would be a good solution to start with. The only difference would be that the errors would be placed under another upper header "Custom Errors", and not under "Functions".
To take BalanceSheet__BorrowMaxBonds as an example, this is the Markdown output that I would like to see when using our Handlebars template:
## Custom Errors

### BalanceSheet__BorrowMaxBonds

```solidity
error BalanceSheet__BorrowMaxBonds(
    IHToken bond,
    uint256 newBondListLength,
    uint256 maxBonds
);

Emitted when the account exceeds the maximum numbers of bonds permitted.


feat(RadioGroup): configurable label size

🔗 Linked issue
#779

❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Allowing the label, required, and help text size on a Radio component to be configured. This also includes a fix where the RadioGroup component was allowed to be configured in the app.config.ts file using the select key. Documentation updated to include callout about using the new uiRadio prop to configure the Radio options when using the RadioGroup component.
Resolves #779
📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

I thought that too, but removing it caused other alignment issues
With the text-sm

Without the text-sm

I can spend more time figuring out why that is the happening if you want

Well never mind I figured it out. Needing to add an inline-flex items-center and that fixes the alignment. Going to do some more tests with that change in place and then I'll push the commit

Let me know when you're done 😊

All done. Ready to merge in!

Thanks 😊


bgfx as rendering api

Have you heard of bgfx lib ?
It provides opengl, opengl es, webgl, directx (9, 11, 12) and metal support.
I thinck it would be awesome to use this lib in sparky engine
Check out examples here

Looks like it will be a great resource to refer to, however Sparky is going to rock its own renderers, for obvious reasons. Thanks for bringing this to my attention though, should definitely help. :)


New page for installation

Update the doxygen page and create a new and separate installation page.

Commit e65dc4c5f6868a11dc52fa36f808bf902b8c25f5 creates a new page for installation. However, we still need ref to binary installer which is incomplete. Also need instruction for Python bindings post build for Mac OS

Hi, I'd like to move the sections about configuring XCode and VS2013 projects to the Installation page as well, as they seems more logical there.  Currently they are located under Getting Started tab.  Getting Started should be more like a tutorial as in "Getting Started with SBOL".  Any opinions?

I think the installation page could include the setup of IDE’s, as long as there is a good jumping off point at the top.  Namely, the top should say something like click here to download pre-built libraries for Windows, Mac, etc., click here to get instructions for getting and building from source, click here once you have the libraries to setup a Visual Studio, XCode, Eclipse project.
We need to make sure there is an easy route for a new user to obtain the library, setup a development environment, and write their first SBOL program.
Chris

On Nov 2, 2016, at 11:20 PM, bbartley<EMAIL_ADDRESS>wrote:
Hi, I'd like to move the sections about configuring XCode and VS2013 projects to the Installation page as well, as they seems more logical there. Currently they are located under Getting Started tab. Getting Started should be more like a tutorial as in "Getting Started with SBOL". Any opinions?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SynBioDex/libSBOL/issues/52#issuecomment-258028963, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD9xdrj7NSW2ciqmC_2Af3PLFfAF0pks5q6Rq0gaJpZM4KhU6r.


Enable FP16 BatchMatMul

This adds a missed FP16-related change.

Can one of the admins verify this patch?


[Error] There is error in speed of video

Video streams slowly than origin speed

I think this error must be occurred when we use opencv

This issue must be discussed on Development meeting @kdh0324

https://www.pyimagesearch.com/2017/02/06/faster-video-file-fps-with-cv2-videocapture-and-opencv/


Fix for multiple processes creating a folder

it happens that with many processes accessing the same folder, some of them find that there is no folder and then simultaneously try to create one and this fails.

Most elegant option would be to add exists_ok=True to mkdir, but it doesn't work on Python 3.4.
Second would be to catch FileExistsError, but that is only for Python 3, not 2
Catching the error on Python 2.7 is ugly so I'd rather just do a catch-all except...

I don't like it either, but I think we really should handle the error properly in a compatible way. It's not too hard:
except OSError as e:
    if e.errno != errno.EEXIST:
        raise

ok, something similar is also done later in the same file anyway.

Thanks

@takluyver could you make a new pypi release version of pickleshare with this fix ?
My software (BluePyOpt) is using ipyparallel, and this issue is causing problems for our users from time to time.
Thanks !

Thanks for the reminder, pickleshare 0.7.3 is up on PyPI.


Some openAPS treatments appearing as future dated in Nightscout reports for Australia timezone

The issue is not affecting all openAPS generated entries - just ones that are created from the afternoon period onwards.

I looked into this a while back - at the time I came to the conclusion that it was because OpenAPS uploads treatments in local time (i.e. +10 in Sydney). Might be a change required to https://github.com/openaps/oref0/blob/dev/bin/nightscout.sh to upload using a timestamp converted to UTC?

Did you see it on all entries - I just have it happening with treatments from early afternoon and evening?

Only with treatments after 2 pm. During daylight savings it's treatments after 1 pm. Which is consistent with the time difference of +10/+11. Is that what you see?
At the time I we were switching over from Loop to OpenAPS. Loop treatments displayed fine, which suggested that it was the OpenAPS upload procedure that was at fault - not NS itself.

Yes that sounds the same as what I see - it's been like it since I setup in Dec. We haven't tried loop to compare it with.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Paul Dickens<EMAIL_ADDRESS>Sent: Sunday, August 13, 2017 10:49:03 AM
To: openaps/oref0
Cc: Mel Clegg; Author
Subject: Re: [openaps/oref0] Some openAPS treatments appearing as future dated in Nightscout reports for Australia timezone (#600)
Only with treatments after 2 pm. During daylight savings it's treatments after 1 pm. Which is consistent with the time difference of +10/+11. Is that what you see?
At the time I we were switching over from Loop to OpenAPS. Loop treatments displayed fine, which suggested that it was the OpenAPS upload procedure that was at fault - not NS itself.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/openaps/oref0/issues/600#issuecomment-322014746, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHs1YDDLeQufIoeZlTGGFQ7Dly3oYmc0ks5sXkf_gaJpZM4O1ise.

@thebookins :the fix must not be in the nightscout.sh, but the created_at in mm-format-ns-treatments.sh must be converted to UTC time. See
https://github.com/openaps/oref0/pull/426#issuecomment-287545072

Thanks @PieterGit , I knew we'd been over this before. I see that your PR wasn't pulled; do you think that created_at still needs to be converted to UTC?

Yes, we need the JSON command to convert created_at to UTC, e.g.
new Date(created_at_timestamp).toISOString()

@thebookins I just created a pull request https://github.com/openaps/oref0/pull/612
that fixes the issue...
BUT BE CAREFULL: I'm seeing duplicate carbs because the mongodb will have both the created_at  in UTC format and the created_at in local format (+0200 for  me, +1100 for you). I think some/all of the carbs are not seen as duplicates.
@scottleibrand do you know a proper way to add the necessary unduplication code, so that carbs/treatments that are in TIMESTAMP+TZ format are ignored by oref0.

We might want to avoid cross-tz deduplication, and instead just force oref0 to ignore treatments with a non-UTC timezone at the same time we switch it to upload in UTC.  We'd still need a compatibility warning not to run older rigs alongside newer ones, though, which probably means this would be best targeted for 0.6.0.

I agree that completely switch to ignore treatments with a non-UTC timezone should be targeted at 0.6.x. But I think we can make an easier upgrade path by:

converting / unifying the created_at for medtronic pump in the Javascript for 0.5.3 and making sure duplicates are not counted twice, .e.g new Date(Date.parse(x.created_at)).toISOString()"
creating a PR for Nightscout to always convert created_at to UTC when uploading

That way a 0.5.3 rig and 0.6.x rig can still work together fine.
For 0.6.x I think we must also must convert mm-format-ns-treatments.sh to NodeJS and add unit tests for it.
Help is needed/wanted.
I think that we must make a working solution for all the +xx:00 timezones for 0.5.3.

Note that this issue is not only related to Australia, but to all +xx:00 timezones. Furthermore, fixing this will also benefit day light saving time issues and possible travelling across timezones if you change your pumps time and your rig timezone.

@PieterGit converting all date strings to ISO should solve the duplication issue, but I think this change will still cause some disruption since MongoDB will have treatments using the old local timezone and the query we are using does a simple string compare. I guess we could write a python script that crawls over the database and converts all created_at fields, but users would need to remember to do this before updating.

The suggestion I make is for 0.5.3 to always convert the created_at to UTC in Javascript, so we don't need a python script (Which off course could be integrated with oref0-setup.sh). For 0.6.0 we can only accept UTC records, so this problem of duplicate carbs would disappear because the timezoned created_at will be ignored. I'm looking for a smooth upgrade path that also support the use of a 0.5.3 and 0.6.x rig in future (for short period of time when users will upgrade their rig).

IMO these changes are all too complicated for 0.5.3, but would be reasonable for 0.6.0.  If we want to do something for the 0.5.3 patch release, I think it should be limited to (for example) extending the query duration from 6 hours to ~ 18 hours so that the timezone-blind string comparison doesn't miss anything.  Even that would require some testing, though, so if we want to make that change we should do so soon.

This is something you could potentially use momenjs for potentially

Might be easier to just make ns do a conversion on created_at if not in utc

👍 for a longer look back as a short term patch

One of you Aussies or Kiwis want to test out the different lookback durations and see what works well for you, and then prep a PR to change it so the rest of us can test?

@scottleibrand I'm happy to do that.

@scottleibrand : after a good night of sleep I must admit that converting to UTC / unduplicating the created_at timestamps in 0.5.3 is too risky and must be postponed to 0.6.x. I don't see how I can retarget https://github.com/openaps/oref0/pull/612 to 0.6.0-dev. Can you do that for me? Or can you change the oref0 github settings so that authors can retarget their own PR's themselves?
I also tried how we should ignore non-UTC created_at timestamps but I couldn't see a clean implementation of that in https://github.com/openaps/oref0/blob/0.6.0-dev/lib/meal/history.js. Help is wanted on that.
@stavlor : I agree momentjs is cool and it's used in oref0 on other places, but I don't think it has any advantages to plain Javascript like: new Date(Date.parse(x.created_at)).toISOString() in this particular case.

@PieterGit just curious, any reason for wrapping Date.parse in a Date constructor? When I was playing around with this new Date(x.created_at).toISOString() resulted in the same timestamp. Bit more readable too.

I think you're right, see https://www.ecma-international.org/ecma-262/5.1/#sec-<IP_ADDRESS>
I couldn't find good documentation on the Date constructor.

In my experience it's good to be lenient in what data is ingested and strict what data is output; look like a good related improvement would be to add code to the Nightscout API that ensured all dates are normalized to UTC upon input, before inserting to MongoDB.

Temporary fix in https://github.com/openaps/oref0/pull/614 to get temp targets and carb histories working again for everyone at UTC +x.

@sulkaharo @thebookins : i created a patch for Nightscout which converts the created_at for inserted or updated/changed records to UTC format. This way Nightscout will always save the created_at timestamp in UTC format.
This follows https://en.wikipedia.org/wiki/Robustness_principle  / Postel's law "Be conservative in what you send, be liberal in what you accept".
The branch is based on @sulkaharo branch https://github.com/nightscout/cgm-remote-monitor/pull/2736 and can be found here: https://github.com/PieterGit/cgm-remote-monitor/tree/treatments_utc
Please test this Nightscout branch and check to see if all COB's and created_at timestamps are fine. I tested in on a 0.5.3 rig, and can't find any problems with this Nightscout solution.

Feature request: can the GVI and PGS also be displayed in the Daily Stats and/or the Weekly success?
It's now only displayed on the Distribution tab.
Is the Percentage Time in Range (PTIR) the same as the % of Readings for range Normal?

@sulkaharo @PieterGit @scottleibrand I just noticed that autotune uses a local timezone string compare to filter treatments.json:
Query: http://second15.herokuapp.com/find\[created_at\]\[$gte\]=2017-08-27T20:00+1000&find\[created_at\]\[$lte\]=2017-08-29T00:00+1000

If I'm not mistaken, this will need to be changed to UTC with https://github.com/nightscout/cgm-remote-monitor/pull/2763. This also means that currently autotune won't be getting all of the carb info if some of it was entered through NS (with UTC timestamp).
Would much of this messiness be resolved by storing created_at as a Date object in MongoDB (https://docs.mongodb.com/manual/reference/method/Date/)? Then, I imagine the query would do a true date comparison, rather than a string comparison. Are there any performance issues with this approach?

I believe I fixed the autotune timezone issue in 0.6.0-dev.  Are there any remaining issues here we want to actively work on fixing?  Or are we happy with the fixes in place for now?


Add an example .php_cs

Many projects nowadays use php-cs-fixer, and the new version is losing the ability to run --config=symfony23, leaving us with the task to manually craft a .php_cs file on our own, it would be helpful to have an example here on symfony-demo.

@ABM-Dan thanks for proposing this. I didn't know they were going to remove that option. That's a big reason to include an example of the .php_cs file in this demo app.
I'll wait a few days to see if someone from the community wants to contribute this feature. Otherwise, I'll implement it myself. Thanks!


All template wrap tag and length more 4096

If error message length over 4096 and i change template:
{{ $appName }} ({{ $level_name }})
Env: {{ $appEnv }}

[{{ $datetime->format('Y-m-d H:i:s') }}] {{ $appEnv }}.{{ $level_name }} {{ $formatted }}

Message break and I get two messages:
Project (ERROR)
Env: local

[2023-03-01 17:41:32] local.ERROR many text

and:
many text

When send messages to telegram as a response we get 400 error:
{
  "ok": false,
  "error_code": 400,
  "description": "Bad Request: can't parse entities: Can't find end tag corresponding to start tag pre"
}

If not use wrap tag everything is fine.
Addition
I want 1 error = 1 message even if the size is over 4096.

Maybe you can cut $formatted message in the template if you need?

Maybe you can cut $formatted message in the template if you need?

Yes
Is it planned to do something like this?

I decided to make a package https://github.com/i3bepb/laravel-crop-str-blade-directive with a directive for Blade that cuts the variable to the right size. With it, you can do this:
{{ $appName }} ({{ $level_name }})
Env: {{ $appEnv }}

[{{ $datetime->format('Y-m-d H:i:s') }}] {{ $appEnv }}.{{ $level_name }} @crop($formatted, 3846) }}

For others parts message I reserve 250 (4096 - 250 = 3846)


Update execution tolerances instructions

Description
This change fixes #167 and updates the execution tolerances instruction at the end of the tutorial.
Checklist

[ x ] Required by CI: Code is auto formatted using clang-format
[ x ] While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@jackcenter did you mean to send this PR to foxy instead of main?


[dv/clkmgr] Add test for frequency measurement timeouts

These will require "forcefully" stopping the clocks being measured, since stopping them normally disables the measurements.

Fixed by https://github.com/lowRISC/opentitan/pull/10000


Comments from Nilufer

[x] Tissue specificity
[ ] Disease specificity
[ ] Other associated diseases
[ ] Other associated diseases data-sets

high level associated diseases included in ODDI data


IO#rewind breaks read operations with custom encodings

IO::Decoder maintains an internal buffer of decoded bytes yet to be consumed (@out_slice), but this buffer is not reset whenever IO#rewind is called on its owner. This means the contents of the buffer could leak on subsequent reads:
io = IO::Memory.new "ＡＢＣＤ".encode("UTF-32LE")
io.set_encoding "UTF-32LE"
io.read_char   # => 'Ａ'
io.rewind
io.read_char   # => 'Ｂ'
io.gets_to_end # => "ＣＤＡＢＣＤ"

io = IO::Memory.new "ＡＢＣＤ".encode("UTF-32LE")
io.set_encoding "UTF-32LE"
io.read_char   # => 'Ａ'
io.seek(8)
io.gets_to_end # => "ＢＣＤＣＤ"

A side effect is that IO#pos reports the byte position of the external buffered reads:
io = IO::Memory.new "ＡＢＣＤ".encode("UTF-32LE")
io.set_encoding "UTF-32LE"
io.read_char
io.pos # => 16
io.rewind
io.read_char
io.pos # => 0

io = IO::Memory.new(("ＡＢＣＤ" * 1000).encode("UTF-32LE"))
io.set_encoding "UTF-32LE"
io.read_char
io.pos # => 4096

At this rate I believe custom encodings should be done through a new IO wrapper class that implements IO::Buffered with mandatory read buffering, rather than having an encoder-decoder pair in every IO.

I personally prefer how this is done in Ruby, where every IO has an encoding that you can set.

I don't think this can be done similar to IO::Buffered. IO::Buffered is an implementation specialization that depends on the type of the IO backend. When it benefits from buffering, the author of an IO implementation can include IO::Buffered to get buffered behaviour.
Encodings on the other hand are typically already transparently applied and depend mostly on usage configuration, rather than being an inherent property of a specific IO backend.

I like this approach ❤ I've always wondered about the peculiar encoding API which seems odd to be present in just every IO instance. This is a good use case for composition. I might be missing some practical usability aspects from my image. But in terms of general software designm this looks like a good idea.

The details about buffered reads / writes might be error-prone; nothing is written to b in the snippet above if the #sync= call is dropped.

I suppose sync = true could be the default for IO::Encoded?

The new API has no special handling for the default UTF-8 behavior; an IO::Encoded.new(..., "UTF-8") will blindly use Iconv for what would be a near identity transformation.

But we can optimize that, right? It just needs to be implemented.

A bit more about why I like the Ruby way, despite it not being "good software design": https://dev.to/asterite/why-i-love-ruby-part-5-3caa

The #pos issue might be solvable if we make it so that IO::Decoder#read(io) uses only io.read_byte to fill @buffer. We then repeatedly call LibC.iconv with increasing in-buffer sizes. For example, to decode Bytes[0x03, 0x02, 0xF6, 0x01, 0x00] from UTF-32LE, we need the following iconv calls:

Bytes[0x03] -> EINVAL (calls read_byte)
Bytes[0x03, 0x02] -> EINVAL (calls read_byte)
Bytes[0x03, 0x02, 0xF6] -> EINVAL (calls read_byte)
Bytes[0x03, 0x02, 0xF6, 0x01] -> EILSEQ (calls read_byte)
If invalid: :skip is not set, raise ArgumentError here
Bytes[0x02] -> EINVAL
Bytes[0x02, 0xF6] -> EINVAL
Bytes[0x02, 0xF6, 0x01] -> EINVAL
Bytes[0x02, 0xF6, 0x01, 0x00] -> okay (calls read_byte)

This may have a rather significant performance impact, but perhaps it is unavoidable because one would have done the same anyway if the whole decoder is rewritten in pure Crystal.
It also might be tempting to use the current large-buffer implementation on IO::Buffered, but now #unbuffered_pos must be kept in sync with the original byte counts associated with the decoded UTF-8 byte sequences in IO::Decoder#@out_slice as they are read. I don't think that will be easy.


Add missing in backport

Fix backport #3192

I recreated the list of issues here:
https://sonarcloud.io/project/issues?resolved=false&pullRequest=3240&id=mapfish_mapfish-print

Closed because I am doing the dev, so I can't be the reviewing it. Then I reopen.


side bar problem when resize screen

thanks for you,
when using the arabic version
http://mmdsharifi.github.io/AdminLTE-RTL/pages/forms/general.html
and resize windows as mobile device
any click on the page opened side bar which disable writting on the form
pls fix

Please check your all css called on page exist in place. Because I'm seeing http://mmdsharifi.github.io/AdminLTE-RTL/dist/css/skins/_all-skins.min.css is missing and called on the page. Use browser developer tools for more information.

thanks
all css refferences are ok ?
same problem

hi
did you find the problem ?
if you download and test in you device you face same problem
if you click any where in page while you in mobile view ( resize browser window) the side bar is open !!!!!

You may need to fix sidebar's css in rtl.less file to be like this

I only test in Chrome.

thank you
im not use less or any compiler
i just use the css files
please tel me what to do in rtl.css or any other css files

From my css above will be complied like this.

@media (max-width: 767px) {   .main-sidebar,   .left-side {     right: -230px;     -webkit-transform: translate(230px, 0);     -ms-transform: translate(230px, 0);     -o-transform: translate(230px, 0);     transform: translate(230px, 0);   }   .sidebar-open .main-sidebar,   .sidebar-open .left-side {     -webkit-transform: translate(-230px, 0);     -ms-transform: translate(-230px, 0);     -o-transform: translate(-230px, 0);     transform: translate(-230px, 0);   } }
You may insert in any css file but after main AdminLTE.css file (or in the end of main css file)  to override default css.

thanks
it working


Syntax highlighting issues

following completely breaks syntax highlighting for us:
border: 0.25rem solid rgba(${props => props.white ? colours.white : colours.black}, 0.2);
atom, using language-babel plugin

Would you mind submitting an issue over at https://github.com/gandm/language-babel? Thank you!

Please note that this package is no longer supported

@mxstbr is language-babel still the recommended tool?

It still is, not sure why @gandm put that notice in the README! Works for me 😉


2.0.0 doesn't have binaries for download

Hello everyone!
I see a new release with the Electron version updated, but the binaries on the site are still in the old version.

@engelgabriel , this should not be closed yet, since the Windows Binaries are not signed as per #273

We have never signed windows binaries, this is still a work in progress.


Add  args to logs and calls help text.

Fix for 1 and 3 #430 Cannot get logs for a function invocation.

Awesome, thank you!


Add support for screen readers

Currently, the <asciinema-player> is not seen as an interactive item when using a screen reader. I've only tested with VoiceOver on the Mac, but adding tabindex="0" fixes this.
The output isn't perfect — PHPUnit 4.8.31 is read as "PHP Unit 4th August 1931" — but otherwise it makes the content of a finished cast available to screen readers (and possibly other assistive technologies) more than it does now.

Does it then read the text in the terminal element? What happens when you click play and the text keep changing constantly?


Added doc describing image handling.

Fixes #251

This change is

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

docs/images.md, line 6 at r1 (raw file):

## Options:
- ImagePullSecrets - not supported currently

ImagePullSecrets - please enclose all names in doc in backticks, so also PullImage, ImagePullPolicy, kubeapi.PullImageRequest, and so on.

Comments from Reviewable

Reviewed 1 of 2 files at r1.
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

docs/images.md, line 6 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
ImagePullSecrets - please enclose all names in doc in backticks, so also PullImage, ImagePullPolicy, kubeapi.PullImageRequest, and so on.

Done.

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 12 unresolved discussions.

docs/images.md, line 3 at r1 (raw file):

# Image Handling

Virtlet supports qcow2 format images for VM boot images.

Maybe "Virtlet supports VM boot images in QCOW2 format" ?

docs/images.md, line 7 at r1 (raw file):

## Options:
- ImagePullSecrets - not supported currently
- Protocol to use to download the image. By default `https` is used. To set other change `VIRTLET_DOWNLOAD_PROTOCOL` env var in `deploy/virtlet-ds.yaml`.

download the images ...
In order to use http, set VIRTLET_DOWNLOAD_PROTOCOL env var value to http in deploy/virtlet-ds.yaml.
deploy/virtlet-ds-dev.yaml defaults to using http currently.

docs/images.md, line 9 at r1 (raw file):

- Protocol to use to download the image. By default `https` is used. To set other change `VIRTLET_DOWNLOAD_PROTOCOL` env var in `deploy/virtlet-ds.yaml`.

## Example of definition:

Sample definition or "An example of container definition"

docs/images.md, line 14 at r1 (raw file):

  containers:
    - name: test-vm
      image: download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img

This will not work with CRI proxy, need virtlet/ prefix

docs/images.md, line 17 at r1 (raw file):

Note, that to pass apiserver pod's definition validation, you need to specify url without scheme://.

Note: you need to specify url without the scheme:// part
(it's not just validation, it's also how Virtlet handles the images, right?)

docs/images.md, line 21 at r1 (raw file):

## Image handling Workflow:
1. Kubelet sends PullImage gRPC request to virtlet

it's better to use consistent casing, perhaps Virtlet is better than virtlet

docs/images.md, line 22 at r1 (raw file):

## Image handling Workflow:
1. Kubelet sends PullImage gRPC request to virtlet
(Note, that as ImagePullPolicy value in not included within kubeapi.PullImageRequest to CRI runtime, it's up to kubelet basing on ImagePullPolicy whether to send PullImage gRPC request. So PullImage will be sent in two cases: ImagePullPolicy=PullAlways OR PullIfNotPreset).

Note that PullImage request can be skipped by kubelet unless the pod has imagePullPolicy: PullAlways or imagePullPolicy: PullIfNotPreset and the image is not pulled yet.

docs/images.md, line 23 at r1 (raw file):

1. Kubelet sends PullImage gRPC request to virtlet
(Note, that as ImagePullPolicy value in not included within kubeapi.PullImageRequest to CRI runtime, it's up to kubelet basing on ImagePullPolicy whether to send PullImage gRPC request. So PullImage will be sent in two cases: ImagePullPolicy=PullAlways OR PullIfNotPreset).
1. Virtlet uses image url fragment after last slash as image name to look up though the list of existent images on the host.

Virtlet uses image url fragment after last slash as internal image name that it looks up in the list of existing images on the host

docs/images.md, line 24 at r1 (raw file):

(Note, that as ImagePullPolicy value in not included within kubeapi.PullImageRequest to CRI runtime, it's up to kubelet basing on ImagePullPolicy whether to send PullImage gRPC request. So PullImage will be sent in two cases: ImagePullPolicy=PullAlways OR PullIfNotPreset).
1. Virtlet uses image url fragment after last slash as image name to look up though the list of existent images on the host.
1. In case if there's no image with such name in the list, the image will be downloaded using specified url prepended with `scheme://`. And after that Virtlet creates libvirt volume in "**default**" libvirt pool under  `/var/lib/libvirt/images` and uploads image content to it.

remove "And"
... default libvirt pool
... copies the image content to it

docs/images.md, line 25 at r1 (raw file):

1. Virtlet uses image url fragment after last slash as image name to look up though the list of existent images on the host.
1. In case if there's no image with such name in the list, the image will be downloaded using specified url prepended with `scheme://`. And after that Virtlet creates libvirt volume in "**default**" libvirt pool under  `/var/lib/libvirt/images` and uploads image content to it.
1. In case if there's an entry with such name in list, just send succesfull response to kubelet.

PullImage call just return success.

docs/images.md, line 27 at r1 (raw file):

1. In case if there's an entry with such name in list, just send succesfull response to kubelet.

**Note**, that to safe disk space and be able to reuse already existent guest OS volumes Virtlet creates separate volume which uses original one as backing store.

In order to save disk space and to be able to reuse existing guest OS Volumes creates separate volume which uses the original one as backing store.

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 11 unresolved discussions, some commit checks failed.

docs/images.md, line 3 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Maybe "Virtlet supports VM boot images in QCOW2 format" ?

Or at last "... supports qcow2 images format ...". BTW. "boot" in this line seems to be unnecessary addition. More common name is "VM images".

docs/images.md, line 14 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
This will not work with CRI proxy, need virtlet/ prefix

It's not virtlet requirement, but preferred virtlet deploy mode requirement, which uses criproxy. So this deserves for wider explanation with link to point in criproxy.md - now this info is described in a bit scattered in this doc, in -connect explanation, and later in image name explanation - maybe this also should be described in separate point to which this doc could link?
WDYT?

docs/images.md, line 17 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Note: you need to specify url without the scheme:// part
(it's not just validation, it's also how Virtlet handles the images, right?)

Yes, we don't test for any prefix like scheme - we are adding one basing on configuration (which defaults to https://).

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 11 unresolved discussions.

docs/images.md, line 3 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Or at last "... supports qcow2 images format ...". BTW. "boot" in this line seems to be unnecessary addition. More common name is "VM images".

Done.

docs/images.md, line 7 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
download the images ...
In order to use http, set VIRTLET_DOWNLOAD_PROTOCOL env var value to http in deploy/virtlet-ds.yaml.
deploy/virtlet-ds-dev.yaml defaults to using http currently.

Done.

docs/images.md, line 9 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Sample definition or "An example of container definition"

Done.

docs/images.md, line 14 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
It's not virtlet requirement, but preferred virtlet deploy mode requirement, which uses criproxy. So this deserves for wider explanation with link to point in criproxy.md - now this info is described in a bit scattered in this doc, in -connect explanation, and later in image name explanation - maybe this also should be described in separate point to which this doc could link?
WDYT?

Added note re virtlet/ prefix in case of criproxy.

docs/images.md, line 17 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Yes, we don't test for any prefix like scheme - we are adding one basing on configuration (which defaults to https://).

Yes, we don't, but kubelet does, and expects to have container image name there, so that's why Michal done it without setting schema:// for url. If you set it you'll receive from kubelet:
Failed to apply default image tag "http://download.cirros-cloud.net/0.3.5/cirros-0.3.5-x86_64-disk.img": couldn't parse image reference "http://download.cirros-cloud.net/0.3.5/cirros-0.3.5-x86_64-disk.img": invalid reference format

But anyway I removed this mention to not overcomplicate the description.

docs/images.md, line 21 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
it's better to use consistent casing, perhaps Virtlet is better than virtlet

Done.

docs/images.md, line 22 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Note that PullImage request can be skipped by kubelet unless the pod has imagePullPolicy: PullAlways or imagePullPolicy: PullIfNotPreset and the image is not pulled yet.

Done.

docs/images.md, line 23 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Virtlet uses image url fragment after last slash as internal image name that it looks up in the list of existing images on the host

Done.

docs/images.md, line 24 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
remove "And"
... default libvirt pool
... copies the image content to it

Done.

docs/images.md, line 25 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
PullImage call just return success.

Done.

docs/images.md, line 27 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
In order to save disk space and to be able to reuse existing guest OS Volumes creates separate volume which uses the original one as backing store.

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 11 unresolved discussions.

docs/images.md, line 3 at r1 (raw file):
Previously, vefimova (Victoria Efimova) wrote…
Done.

IMO this should be: "Virtlet supports QCOW2 images format." or "... QCOW2 format for VM images".

docs/images.md, line 25 at r1 (raw file):
Previously, vefimova (Victoria Efimova) wrote…
Done.

Double "." at the end.

docs/images.md, line 27 at r1 (raw file):
Previously, vefimova (Victoria Efimova) wrote…
Done.

please replace "," with ":" in bolded part, and remove "that" at the beginning.

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 11 unresolved discussions.

docs/images.md, line 3 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
IMO this should be: "Virtlet supports QCOW2 images format." or "... QCOW2 format for VM images".

Done.

docs/images.md, line 25 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Double "." at the end.

Done.

docs/images.md, line 27 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
please replace "," with ":" in bolded part, and remove "that" at the beginning.

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 11 unresolved discussions.

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 11 unresolved discussions.

Comments from Reviewable

Reviewed 1 of 2 files at r1, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Missing version of .NET Framework: 528033

I've just installed the latest updates on Windows Server 2016 running in a VM in Azure Resouce Manager. Following this guide, I get version 528033, which is not listed here. The Version entry in the same subkey says 4.8.03745.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2115da38-e95e-46fc-1e2d-da88ef92c6cf
Version Independent ID: a3790e8a-0654-851b-c991-ab7382025406
Content: How to: Determine which .NET Framework versions are installed
Content Source: docs/framework/migration-guide/how-to-determine-which-versions-are-installed.md
Product: dotnet-framework
Technology: dotnet-appcompat
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

528033 is a pre-release value, @prochan2. The article documents only release values.
Since this behavior is by design, I'll close this issue.


Samples/bluetooth: Failed to connect with eddystone sample app on arduino_101.

Eddystone sample app is designed to advertise eddystone pkts and waiting for connection for 30sec after boot. If any connect request comes within 30 sec, then connection is successful. In zephyr version v1.9-branch, connection is getting successful, but with latest version connection failed on arduino_101.
Error logs:
console: ***** BOOTING ZEPHYR OS v1.10.0-rc1 (delayed boot 1000ms) *****
[bt] [WRN] hci_vs_init: Vendor HCI extensions not available
[bt] [WRN] set_static_addr: Read Static Addresses command not available
[bt] [WRN] set_static_addr: Using temporary static random address
[bt] [INF] show_dev_info: Identity: e7:8c:6c:22:d0:23 (random)
[bt] [INF] show_dev_info: HCI: version 5.0 (0x09) revision 0x0000, manufacturer 0xffff
[bt] [INF] show_dev_info: LMP: version 5.0 (0x09) subver 0xffff
Bluetooth initialized
Configuration mode: waiting connections...
[bt] [ERR] hci_acl: Unable to find conn for handle
[bt] [WRN] report_completed_packet: Unable to look up conn with id 0xff
Switching to Beacon mode.
Advertising failed to start (err -69)
Tested zephyr version:
Latest version: a916b796d5954226b613ad2a317b3d7af1ec7ea4
How to reproduce.

Take one zephyr ble target(arduino_101) and ble dongle connected with Linux machine. And placed both BLE devices near to each other.
On zephyr target: Install eddystone sample app($ZEPHYR_BASE/samples/bluetooth/eddystone).
Check on console and waiting for "Configuration mode: waiting connections...".
Run bluetoothctl tool on linux machine(where BLE dongle is connected).
Run below commands to connect BLE dongle to arduino_101.
$ bluetoothctl
$ agent on
$ default-agent
$ remove * 		# remove all scanned devices from cache.
$ scan on		# scan for eddystone advertisment pkt. waiting for eddystone advertise pkt.
$ scan off
$ connect $MAC_ADDR_A101	# $MAC_ADDR_A101 is a BLE mac addr of a101.
Make sure above steps must be done before 30sec. As after that eddystone sample app will start sending non-connectable beacons.

Expected result:

Zephyr target and ble dongle must be connected.

Actual result:

Zephyr target and ble dongle is not connecting and getting error of "Unable to find conn for handle".

Could you also flash your controller with the latest Zephyr version? From the logs its evident that you have some older one.

Thanks @jhedberg, with latest BLE FW, test is passing. So closing the issue thread.


Camera-wall is completely broken

Camera wall does not auto-disable, and shows the back of modules instead of the front sometimes. It also doesn’t allow !x zoom to work, and doesn’t auto-fill with modules.

I tried to test everything besides the auto-disable not working and everything worked fine for me. I ran a bomb with 18 modules, viewed them, enabled the camera wall using !enablecamerawall and then tried zooming one of them. Anything I should be doing differently? Are there any specific modules you noticed that have the issue? Are you on the latest build?

I’ll attach some pictures soon

This, and no modules auto-view

Some modules, like The Jukebox, just don't view at all

this may be worth re-opening, since the bug is interactive mode specific and still exists

I made a new one clarifying the issue


Added page content

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bluetooth: host: Add support for multiple advertising set

Add support for multiple advertising set. Move the advertising state
flags to be per advertising set and loop over advertising sets instead
of looking up legacy advertiser set or handle 0.
Since it is not certain that the advertising set terminated event can
arrive directly after the connection complete event there is currently
a limitation that there can only be one local identity used by
connectable advertisers at a time. This guarantees that we know
the local identity being used in the connection complete event.
Only attempt to restart the background scanner in connection complete
event when the new connection is a master role connection or the
initiator was successfully canceled.
Enable enhanced connection complete when extended advertising has been
enabled. This event is mandatory if extended advertising is supported.

I have a duplicate of the fix in: https://github.com/zephyrproject-rtos/zephyr/pull/24315, it should be merged first.


Client side library with browserify / wepback with superagent

I've been working on a branch to transform swagger-js-codegen from request to superagent because superagent is able to run on both client and server sides.
This would make it possible to bundle the output code with browserify/wepback and provide a client library as well.
Is it something what you find interesting?
Should i continue the work?
Progress: https://github.com/hekike/swagger-js-codegen/commits/feature/superagent

@hekike I think it would be interesting to have only a single template for both browser and nodejs javascript.

@hekike Any progress on this?  Does your fork pass all of the tests?

For me, there are two primary reasons for wanting to pre-generate a library: static builds for deployment and enabling the IDE to pickup on available commands.  Browserify tends to bloat the size of the package and it confuses IDEs.
A better strategy would be to switch to the upcoming Fetch API or Popsicle and use native promises.  All three have libraries/polyfill for Node and the major browsers.
As a convenience for browser users, we could add a third template that inlines the Fetch/Popsicle and promise polyfills.

@wcandillon no, unfortunately I also started to do a heavy refactor and added some features what we needed asap at our company.
The good news is that we are using the generated code for months, in production as well. The bad news is that I still need time to fix all of the tests.

+1 for bluebird and superagent.
I am using bluebird in my fork as well.
bluebird is very powerful, for example it allows to catch multiple predicate errors. Which is super handy.
It also has a compliant API. It have also deprecated "deferred's"  in favor of spec compliant syntax. and some other cool stuff

@hekike @dciccale I started a PR for this: #104 .


Fix - Refactor For Better Readability, Structuration and Tests

This pr is exactly what the title says, where made major changes in the code throughout the project and there were a lot of dead code that were unused and duplicate code were weren't needed.
This pr also prepare the environment for the US007 merge, were tests are made.

Apparently missing changes in the US007 are breaking the build, will merge the US007 and commit to see if it works.


Create expiration for tokens

Tokens need to expire. add check in method to test for created attr

 dev expiration for tokens

Won't implement.


Moving CG detection to separate 'Audit' job

After the creation of VM matrix for the 'Test' job, to be consistent with the other repos (eg: azure-sdk-for-js) and as per Mike's suggestions, move the task for Component Governance to a separate 'Audit' job
@Azure/azure-sdk-eng

This has been done


Downloading graalvm-ce within the Gradle task is unbelievable slow

Downloading https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-20.3.0/graalvm-ce-java11-linux-amd64-20.3.0.tar.gz within the Gradle task sometimes takes hours. It would be nice to have an option to specify a local installation path.
Please see this screenshot for the ultra-slow download speed while other accesses to GitHub work fine:

Note that the Gradle Graal plugin caches it: https://github.com/palantir/gradle-graal
(Which might be harder with buildpacks)

See paketo-buildpacks/java#86

@bclozel Setting pullPolicy = org.springframework.boot.buildpack.platform.build.PullPolicy.IF_NOT_PRESENT for the Gradle task bootBuildImage doesn't change anything.

@juergenzimmermann just FYI
https://paketo.io/docs/buildpacks/configuration/#bindings
https://paketo.io/docs/buildpacks/language-family-buildpacks/java/#connecting-to-a-private-maven-repository
https://github.com/spring-projects/spring-boot/issues/24556
https://github.com/paketo-buildpacks/bellsoft-liberica/issues/7
We have similar situation as yours,  I have set up a proxy to speed up the download, but springboot maven build:image just downloads some files every run that slows down our CI/CD pipeline so much that I have to pass a Binding to replace the urls  with local ones.

Please raise this issue on Paketo buildpack side, maybe as a comment on https://github.com/paketo-buildpacks/java/issues/86.

Please raise this issue on Paketo buildpack side, maybe as a comment on https://github.com/paketo-buildpacks/java/issues/86.


Delegate transformKey() logic to old input provider implementation?

WIP

Coverage decreased (-10.9%) to 83.871% when pulling 9ac1d61d972fd72c9e3910a1a2785f5b3e04798d on JesseLeite:bugfix-double-key-transform into 89b19934a2d3e95b6261ad7e6f6c6055973b56d9 on adamwathan:master.

Coverage increased (+0.7%) to 95.526% when pulling 401549c5fda572a1da9afbaa4740827d3d5fc077 on JesseLeite:bugfix-double-key-transform into 89b19934a2d3e95b6261ad7e6f6c6055973b56d9 on adamwathan:master.

Nevermind, bad idea.


Add a validator for env. Fixes #460

I had to disable old Python versions in Travis to get the test run to pass. These old versions can no longer be installed.

Test failures on Python 3.7 and 3.8 seem unrelated. I'll remove those from travis again and leave that for a different PR.

@amoffat Ping?

Great PR and tests :+1:
The interesting thing is that you stumbled across a deeper problem.  There is a mechanism in place to catch fork-child exceptions and write the traceback out to the parent process (via a pipe).  The fact that we weren't seeing any output related to the env variable not being a dictionary means that that mechanism wasn't working correctly.  Digging deeper, it turns out that the pipe fd was being aggressively closed by the child process, as part of cleaning up inherited file descriptors.  342f246dec4f4341cc65513286d3ecdcec152e5b fixes that.  Now you get this nice exception:
======================================================================
ERROR: test_invalid_env (__main__.FunctionalTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test.py", line 657, in test_invalid_env
    self.assertRaises(exc, ls, _env="XXX")
  File "/usr/lib/python3.5/unittest/case.py", line 733, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/usr/lib/python3.5/unittest/case.py", line 178, in handle
    callable_obj(*args, **kwargs)
  File "/home/amoffat/workspace/sh/sh.py", line 1457, in __call__
    return RunningCommand(cmd, call_args, stdin, stdout, stderr)
  File "/home/amoffat/workspace/sh/sh.py", line 767, in __init__
    self.call_args, pipe, process_assign_lock)
  File "/home/amoffat/workspace/sh/sh.py", line 2045, in __init__
    raise ForkException(fork_exc)
sh.ForkException:

Original exception:
===================

    Traceback (most recent call last):
      File "/home/amoffat/workspace/sh/sh.py", line 2004, in __init__
        os.execve(cmd[0], cmd, ca["env"])
    AttributeError: 'str' object has no attribute 'keys'

I imagine this was a pain to debug going by only the 255 exit code.

Just to clarify, your validator commit will ensure that the above traceback snippet won't be seen (I had to disable your validator to get that output), and we'll get your friendly error text, but future 255 exit code errors will have the child exception visible at least.

Thanks for the explanation and extra fix!
It was indeed a pain to debug. I was chasing a timeout error in a painfully long test suite running inside a docker container. I was playing around with different timeout values for a certain part of the test, passed via _env, and only after several days it occurred to me that I was passing _env={'TIMEOUT': 300} and not _env={'TIMEOUT': '300'}. The test wasn't failing. sh was :-)

I am tempted to add some kind of environment sanitizer function that goes through all the key-values and stringifies them.  Can you think of any downsides?

Since the fix is very easy for the user (just add str() around your key or value), and the exception message should explain the error clearly, I think it may be better to just leave it as-is.
I can't think of any catastrophe's off the top of my head, but in some people use __str__ for all kinds of weird tricks. Mistakenly passing a key or value that just happens to support str() could lead to hard-to-debug situations.
Bash does support 'integers' in env values (export FOO=100 is the same as export FOO="100") but since bash variables are actually untyped (see http://tldp.org/LDP/abs/html/untyped.html) you should should think of 100 as an unquoted string.


Add bang bang by michael jackson

Song Name
bang bang
Artist Name
michael jackson
Source
Youtube
Youtube Link
pxdg2aOtpOvcqi7M
Direct File Link
No response
Song ID
2
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 13519

here

reject
invalid YouTube link


DSE download error

I encountered an error when trying to download the Design Space Exploration - Scripts for generating and analysing multiple co-simulations (0.2.0) from the download manager.
The error says:
Invalid Checksum
Bad MD5 expected: 'a7c916f74981e526bcbc9dc22d9898aa' got: 'dabf7b8cc338587bf8ad11ba6317e415'
Is it maybe because of my internet connection?
PS: attaching files does not work neither from the app's Help > Report Issue

The checksum in the current version of the DSE download is incorrect.
The fix should come online later today when the new bundle comes out.


Split build processes to save execution time in gh-actions

Sorry, I deleted the fork to make some tests and the PR #3652 was closed, so I open it again.
The action to test is divided in two in order to avoid compilation time in GitHub Actions. For example in run #8442 it took 2m 30s to run, of which 1m 56s was to build the html and then failed the test.

With this new action, if the test fails, the build is not executed:

Note: It can be seen that only 35 seconds are consumed in the test and if it fails, no ghactions time is spent in build

continue to discussion https://github.com/ros2/ros2_documentation/pull/3652, IMO

having test and build in different job element, that makes sense. it more explains what the job for. (i think this is NOT related to execution time.) for the future enhancement and maintenance, such as adding more steps for either test or build and so on.

If others can https://github.com/ros2/ros2_documentation/pull/3596 into https://github.com/ros2/ros2_documentation directly, there will be four jobs.
Do you think the result below is good for them?

originally @iuhilnehc-ynos pointed out here, https://github.com/ros2/ros2_documentation/pull/3652#issuecomment-1556408535
Test / test (pull_request)
Test / build (pull_request)
Test / test (push)
Test / build (push)

i think this is not good. i think we should avoid this, since this is duplicated job execution.
@iuhilnehc-ynos if i am not mistaken, either this PR or suggested fix, both have the same problem, right? i am not sure we need to or we can fix this duplication.

If others can https://github.com/ros2/ros2_documentation/pull/3596 into https://github.com/ros2/ros2_documentation

probably this is not recommended procedure so that we can avoid... but maintainers do?

Of course, this is possible, but the activation rules must be well established. In my opinion, I think that the triggers could be the pushes to the main branches (rolling, crystal, humble, etc.). Although it is not clear to me why in #3596 it is executed twice.

That said, I'm going to wait to merge this as I'd like to hear @iuhilnehc-ynos opinion again.

The make test is a step meaning to me, not a job.
As far as I know, the Fast-DDS just use one job to build the doc(Fast-DDS-docs).
The doc8(default: on) and sphinx are executed in one job. (https://github.com/eProsima/Fast-DDS/blob/master/.github/workflows/documentation-tests.yaml#L100-L106)

@iuhilnehc-ynos if i am not mistaken, either this PR or suggested fix, both have the same problem, right? i am not sure we need to or we can fix this duplication.

Yes, it's another topic.
As @clalancette and @fujitatomoya approved, I think this PR makes sense to most people.

The make test is a step meaning to me, not a job.

yeah, i know it is element under job.
i mean,

having test and build in different job element, that makes sense

this still makes sense to me. besides it shows the dependency clearly.

Yes, it's another topic.

yeah, this seems to be the problem here. probably we can address with different PR.

As far as I know, the Fast-DDS just use one job to build the doc(Fast-DDS-docs).

not really sure why you brought this up? probably just an one of the example, right?

probably we can address with different PR.

OK.

not really sure why you brought this up? probably just an one of the example, right?

Yep.

@Mergifyio backport iron humble foxy


Prefer direct matches over nested title-tags

With this change we prefer top level title tags over deeply nested ones.
This fixes https://github.com/defunkt/jquery-pjax/issues/616

as the opposite of this change is asserted via unit tests I will close this