Correct documentation

Surprisingly, online documentation does not include last merged functions and examples.
I have corrected some errors. Maybe there are others left.

Error on requirements filename for documentation

ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'doc/doc-requirements.txt'

Warning for deprecated parameter

RemovedInSphinx30Warning: autodoc_default_flags is now deprecated. Please use autodoc_default_options instead.
See https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_default_options

Minor warning: unresolved references in partial_fit of RP and RPF

Thanks @qbarthelemy !


Culling for rigid and articulated objects

Motivation and Context
Add culling for articulated and rigid objects.  Also moves away from using btMotionState for syncing positions as this gives us finer control over when the scene graph is dirtied and will be needed for rendering in a background thread.
Also compiles with broadwell vectorized instructions -- broadwell is quite old so unlikely that people don't have support for those but the newer wider AVX instructions don't improve perf.
How Has This Been Tested
Andrew's interactive benchmark looks identical and I have spent a lot of time in the view watching objects and everything looks correct.

It's stable with Eric's change are added so we'll just turn it once those are in


How to get the Metadata from the atomium.model?

How to get the Metadata from the atomium.model?
When you save the model as a pdb file, the metadata will be lost.

Which metadata are we talking about here?
Ideally, when we parse back the superposed PDB, we will only get the updated coordinates instead of the full model, but I am not sure these addresses your question :/

When you save a model as a pdb file, you will only have the atom records.

Ok, then the more reason to retrieve the coordinates from the reimported (superposed?) and update those on the initial model.


[Idea] Clipart-on-stroke

Hey there again! I have had this idea for a potential feature for your tool, which I think might be quite useful for many users. I think having the ability to repeat a clipart throughout a stroke could be very handy, in special for artists and general illustration.
How I suggest it could work: When drawing a stroke, clipart instances would be generated along it. This is kind of like a particle system for the line but much simpler. These cliparts would be internally attached to the stroke so they would get deleted if the stroke is deleted, or moved all at once if the stroke is moved. There could be a setting which allows you to adjust randomness from 0 to 1 so the cliparts either generate in a straight line and follow the stroke closely, or get generated in a noisier manner and deviate from the stroke track to have a more random look. There could be a spacing option which would determine how spaced each instance gets drawn from the previous one. Here is an example.

I have used an isometric brick for the example, but this could be useful to lay cliparts in a perfectly straight line such as if you wanted to insert windows on a house doodle, line up houses on a block illustration, or add random leaves to a tree drawing without having to do it manually. This would also be useful for people who would like to make their own custom stroke styles as they can make a clipart for the pattern/shape they want to use for the stroke.
PS/1: I'll make a LUT to darken grays and make them black to work around the black keying limitation with OBS. I can share the resulting LUT if you'd be interested in delivering it alongside the tool, and maybe write documentation on how it works. If you'd be interested in something like that let me know if I should post it here or elsewhere.
PS/2: Would you like to see proposals for potential UI redesigns? I'm not an expert designer, but if you would like to see an alternative look I could put something up.

under thinking
about PS/1 : it will be welcomed
about PS/2 : UI redesign may be very time comsuming, but I'm always open to proposals

@NOVAinc Interesting... This is the same feature that's available on GIMP, Photoshop and their like right?
Hey @pubpub-zz , I wanted to know, do you have plans to include a resizing tool, where we can select things with the lasso tool and resize them? It would be especially useful for people like me who have huge handwriting.

Yes, this is a very basic implementation for a stencil brush of sorts. I understand ppink is an annotation tool only and there must be limits drawn so people don't expect this to become more of a full drawing editor with the ability to crop, resize, rotate stuff, add layers etc. I have a specific use case for a feature like this and I thought of use cases for others too, but I would understand it getting rejected as well.

Yes, this is a very basic implementation for a stencil brush of sorts. I understand ppink is an annotation tool only and there must be limits drawn so people don't expect this to become more of a full drawing editor with the ability to crop, resize, rotate stuff, add layers etc. I have a specific use case for a feature like this and I thought of use cases for others too (such as applying custom stroke styles like using rounded dots instead of squares, spacing things evenly on a straight line, etc), but I would understand it getting rejected as well.

The point is that design relies on strokes. Feasability is not yet acquired

Hey @pubpub-zz , I wanted to know, do you have plans to include a resizing tool, where we can select things with the lasso tool and resize them? It would be especially useful for people like me who have huge handwriting.

the Strokes Library have a scaling option. Not sure yet on how to implement the feature, but you may raise it as an issue

Hi @NOVAinc @YouFoundJK
I've finally found a starting point to implement this function.
ppInk64_Pattern07b.zip
to engage the function, select Clipart button, and in the dialog box,check the new  checkbox.
the button will be tagged with a S to identify that you are now in the tool to draw pattern along a stroke.
the cursor will change to a target : you will have to select the size as a box (or just click to use the clipartsize),
then click and release in order to adjust the distance between 2 images.
then the cursor will go to arrow, and now you can draw a(or many) stroke : images will be drawn along.
Currently copy,move are working,  but resize and rotate not yet.
Tool selection may very slightly change in order to be able to get this function through clipart1/2/3 and in order to store size and distance and accelerate drawing.
Give me your first feedbacks

Woah! I'm sorry it took some time to get to this. I'm testing it now and it's amazing!

Happy you are enjoying.

This is definitely enough to start doing very interesting stuff with it at least with my use case. I'm very much looking forward to being able to use it with line, circle, etc. It's impressive work. I'm wondering if you're planning to make the first two steps automatable by using the rest server?

I will implement the REST API with capability to provide the size and distance in order to automate. I've just finished to implement also the parameter storage in Clip1/2/3 :
ppInk64_Pattern12a.zip

I'll try to get the ppink video done soon. Let me know if you would prefer me to upload it privately and share a link with you so you can share it as a tutorial (viewable with link only) or if you'd prefer a public video people could find by searching for annotation tools instead. My YT channel is for Age of Empires, so I'd have to use a different account but I can sort that out I think.

Do your best :  I'm not sure I could not be linked with your AoE channel in some way: I remember seeing people being admiring your way to document your videos. Personnally I considerer that your videos can be both for guiding and advertising (and then the more visible it will be visible, the best it will be 😊)

If I made the video for my channel I could link it to age for sure, but it would be something pretty niche along the lines of "how I use ppink to annotate AoE matches" instead of something more broad like "this is the best annotation tool out there - ppink guide" or something like that. My channel isn't very popular so I don't think it'd affect outreach too much (~100 subs at the moment)

@NOVAinc @YouFoundJK
normally, the new object type is now complete : scale, rotate, and REST API are implemented.
ppInk64_Pattern14a.zip
waiting for your feed back before release

Hey pubpub! I seem unable to make it work, currently. I noticed the checkbox isn't there anymore, however I found the option in the drop down menu inside the frame options. I can set the size and the spacing, but drawing doesn't display the cliparts currently.
https://user-images.githubusercontent.com/19545604/129649044-64ae3201-2549-4dc5-8867-ea6afe0f8bdc.mp4

Oups. Wrong cleanup
ppInk64_pattern17a.zip

I will create a new issue then. Thanks for the answer, looking forward to the 5º version!
I've just issued 1.8RC1 and the option is available in

https://github.com/pubpub-zz/ppInk/releases/tag/v1.8RC1


Added languages to code highlighting

Added http, json and bash to to list of supported code languages.  Unknown languages now return as-is with no highlighting.

Very happy about the BASH add. Can YAML be included if it is not already? Commerce cloud infrastructure is heavily dependent on YAML configurations.

Closed pending push of 3.0.10.


Inconsistancy on const Naming Cases

Affected pages

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/add-two-numbers-with-javascript

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/subtract-one-number-from-another-with-javascript

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/multiply-two-numbers-with-javascript

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/divide-one-number-by-another-with-javascript

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/create-decimal-numbers-with-javascript

Previous Lesson:
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword
Your code
/*
  Change the 0 so that sum will equal 20.
*/

const SUM = 10 + 10;

Expected behavior
Correctionr:
Extract: On lesson 10 from the JavaScript curriculum all caps constants are referred as the "common practice" and there after several times this "common practice" is not followed. Does it deserves to change lesson 10 text to limit this convention to a certain kind of constants of should other lessons be updated to follow this "common practice".
As explained on previous lesson all const should be named ALLCAPS
"...variables declared with const to conform to common practices, meaning constants should be in all caps."
"const sum" according to previous lesson should be rewritten to "const SUM"
Screenshots
System

Device: Desktop
OS: Manjaro Linux 21.2.3 "Qonos"
Browser: Firefox
Version: 97.0 (64 bits)

@nhcarrigan Yeah that's correct. But in the lesson Declare a Read-Only Variable with the const Keyword

It was mentioned:

A common practice when naming constants is to use all uppercase letters, with words separated by an underscore.

So we need to correct that statement.

@nhcarrigan I read that, capital-named constants are only used for “hard-coded” values and constants that are calculated at run-time are named normally.
Source: javascript.info
Which is the correct way😕?

Is this accurate? I use camelCase for almost everything, personally.

In general, many programming languages (C-like) follow this:
const I_AM_GLOBAL_AND_PRIMITIVE = 10;

let iAmGlobalButChange = 10;

// This is often also SCREAMING_SNAKE
const iAmGlobalButIndefinite = I_AM_GLOBAL_AND_PRIMITIVE + iAmGlobalButChange;

const iAmJustAConstantPointer = ["i", "could", "change", "but", "my", "pointer", "never", "does"];

enum IAmAnEnum {
  VALUE
};

function iAmAFunction() {
  for (const iAmLocalAndIndefinite in [1, 2, 3]) {
    iAmGlobalButChange++;
  }
}

class IAmAClass {}

At the end of the day, it does not matter, because none of this is a feature of the language, and I know some who actively have the opposite convention.
My suggestion: Nothing to be done here.

My suggestion: Nothing to be done here.

How would you feel about removing the note? Seems unnecessary.

If you mean that is it not inconsistent to have an exercise in lesson Declare a Read-Only Variable with the const Keyword "Change the code so that all variables are declared using let or const. Use let when you want the variable to change, and const when you want the variable to remain constant. Also, rename variables declared with const to conform to common practices, meaning constants should be in all caps." with the fact that in the next lessons this "common practice" seems to be "less common".
Then maybe change the text on that lesson to explain somehow where to use capitalized constants, and where to follow the most "common practise" of camel case practise. I question, where is the pedagogics of learning the way something should be, when thereafter you learn how not to do it?

If we do anything, I would change this line:

Also, rename variables declared with const to conform to common practices, meaning constants should be in all caps.

To

Also, rename variables declared with const to conform to common practices.

And maybe remove this:

A common practice when naming constants is to use all uppercase letters, with words separated by an underscore.

How would you feel about removing the note?

The note is spot-on, in my opinion.

Note: It is common for developers to use uppercase variable identifiers for immutable values and lowercase or camelCase for mutable values (objects and arrays). You will learn more about objects, arrays, and immutable and mutable values in later challenges. Also in later challenges, you will see examples of uppercase, lowercase, or camelCase variable identifiers.

Especially our declaration of:

Also in later challenges, you will see examples of uppercase, lowercase, or camelCase variable identifiers.

Marvelous!

Alright, let's give that a shot. I think it's a clear enough explanation that we can open this up for first timers.

This looks like something that can be fixed by "first time" code contributors to this repository.
Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.
Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first.
Happy contributing.

Is this issue open to work? Shall I take this up?

@Jagruti1610 Yes, you can make a Pull Request.

can I work on this ?


Not working with ReactNative 0.71.3

Hi, im trying to get this to work with react-native 0.71.3.
But It looks like they've changed com.facebook.react-native to com.facebook.react-android.
And some other smaller changes.
Are there any plans to support this in the near future? I really need this for our app :)

Interesting - this is something that will obviously be interesting to us over at react-native-firebase (where we use this plugin, naturally) I just haven't had time to update our e2e test app to 0.71+  so I didn't even realize this would be a problem.
Makes sense though, they did need to change their coordinates, that was fun with all the build breaks as they published on the old coordinates once to maven central.
What have you tried so far? What errors do you see currently?

Hi, it seems like my issue was caused by some weird gradle caching that broke the com.facebook.react:react-native:+ import.
After clearing the gradle cache this issue has resolved itself.
Thanks for your help anyways :)

Ha - one less thing potentially on my plate, I love it! Caches ... so useful ... cache coherency ... so hard. Cheers


QC: Add sample data generation scripts to data_raw/

QC Details
To increase transparency and reproducibility, add scripts that generate the sample data frame CSVs
Additional Comments

Probably good to log that it looks like it's this: https://github.com/Gilead-BioStats/gsm/blob/44d95c16450d42a12af9f487b8a788a743064a84/inst/examples/3_0_longitudinal_sim.R
(or at least based on that).


Documentation - ModelImporterAnimationType

Hello,
Thank you for providing this great package! I just wanted to let you know that it might be helpful to mention in the documentation / read.me that the attached script "FixRocketboxMaxImport.cs" overwrites the ModelImporterAnimationType (L62). This leads to the fact that you cannot manually select "Humanoid" in the ImportSettings of an avatar.fbx in Unity. A brief note on this would certainly have saved me some time and prevented some confusion.
Many thanks and best regards
David

Will do!
Also you can change the importer file to re-configure as humanoid if needed.
Mar
Dr. Mar Gonzalez Franco
<EMAIL_ADDRESS>http://research.microsoft.com/people/margon
Microsoft Research, One Microsoft Way, Redmond, WA 98052, USA
Get Outlookhttps://aka.ms/qtex0l for iOS

From: dave2ma<EMAIL_ADDRESS>Sent: Monday, January 18, 2021 8:26:05 AM
To: microsoft/Microsoft-Rocketbox<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [microsoft/Microsoft-Rocketbox] Documentation - ModelImporterAnimationType (#10)
Hello,
Thank you for providing this great package! I just wanted to let you know that it might be helpful to mention in the documentation / read.me that the attached script "FixRocketboxMaxImport.cs" overwrites the ModelImporterAnimationType (L62). This leads to the fact that you cannot manually select "Humanoid" in the ImportSettings of an avatar.fbx in Unity. A brief note on this would certainly have saved me some time and prevented some confusion.
Many thanks and best regards
David
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FMicrosoft-Rocketbox%2Fissues%2F10&data=04|01|margon%40microsoft.com|29dd91b315c54dfdcec208d8bbcdc1a6|72f988bf86f141af91ab2d7cd011db47|1|0|637465839681434925|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xDCqriVx5HZ9Bc4pw7zlk2LrA9%2F2P%2B0%2B%2FbnoYfBQLj4%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKB4CJQTGKSJQBZGTCV3UZDS2ROJ3ANCNFSM4WHRIJNA&data=04|01|margon%40microsoft.com|29dd91b315c54dfdcec208d8bbcdc1a6|72f988bf86f141af91ab2d7cd011db47|1|0|637465839681444886|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=wdmu9iLzZOaTT0DQUUHcgJw2M%2BXEQe74eR5bQwjfVHQ%3D&reserved=0.

Will do!
Also you can change the importer file to re-configure as humanoid if needed.
Mar
Dr. Mar Gonzalez Franco
<EMAIL_ADDRESS>http://research.microsoft.com/people/margon
Microsoft Research, One Microsoft Way, Redmond, WA 98052, USA
Get Outlookhttps://aka.ms/qtex0l for iOS

From: dave2ma<EMAIL_ADDRESS>Sent: Monday, January 18, 2021 8:26:05 AM
To: microsoft/Microsoft-Rocketbox<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [microsoft/Microsoft-Rocketbox] Documentation - ModelImporterAnimationType (#10)
Hello,
Thank you for providing this great package! I just wanted to let you know that it might be helpful to mention in the documentation / read.me that the attached script "FixRocketboxMaxImport.cs" overwrites the ModelImporterAnimationType (L62). This leads to the fact that you cannot manually select "Humanoid" in the ImportSettings of an avatar.fbx in Unity. A brief note on this would certainly have saved me some time and prevented some confusion.
Many thanks and best regards
David
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FMicrosoft-Rocketbox%2Fissues%2F10&data=04|01|margon%40microsoft.com|29dd91b315c54dfdcec208d8bbcdc1a6|72f988bf86f141af91ab2d7cd011db47|1|0|637465839681434925|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xDCqriVx5HZ9Bc4pw7zlk2LrA9%2F2P%2B0%2B%2FbnoYfBQLj4%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKB4CJQTGKSJQBZGTCV3UZDS2ROJ3ANCNFSM4WHRIJNA&data=04|01|margon%40microsoft.com|29dd91b315c54dfdcec208d8bbcdc1a6|72f988bf86f141af91ab2d7cd011db47|1|0|637465839681444886|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=wdmu9iLzZOaTT0DQUUHcgJw2M%2BXEQe74eR5bQwjfVHQ%3D&reserved=0.


VideoCall

Good afternoon, how do I activate the camera and microphone permissions within a webview to view a video call?

Hello sarellano20, Try to see if the UnityEngine.Android.Permission structure works for granting permissions. I have not verified this myself, so please let me know if it does not work.

The pop-up to activate the camera and microphone still does not work, even after activating permissions :(

TLabWebView has not yet implemented the ability to capture pop-ups such as Toast. It is possible that popups are just not displayed and are actually functioning in a way that is not visible.
We plan to add popup capture to the plugin in the future.

If possible, could you provide a screenshot of the screen where the problem is occurring?

It was found that WebView was rejecting microphone permissions. A corrected version is now available in the repository.

Man u really amazing!


Remove spending counter from Vote Cast transactions

Removes the spending counter from the vote cast transactions, by introducing breaking changes to how witness signatures are built, and by not deducting value from the ledger, by keeping the current safeguards.

This is WIP, I'm working on fixing the wallet to make the right witness type, and finishing with the fragment logic to ensure that the spending counter is totally ignored on the node.


Perhaps add docker build to example_app docs

When running
docker run -p 5000:5000 example --name example
You'll receive an error message saying that
... pull access denied for example
Probably because "example" is not a public image.
You should perhaps add that you have to build the image specifying the name, e.g.:
docker build . -t example

Okay, so just found Toy_app repo, so this repo may be inactive


Reduce resoloution of GeoJSON object [feature request]

Hi,
I have a GeoJSON polygon that's made of 67,077 points. It's far too long to be used with the API of the website I'm trying to communicate with. It would be really useful if there was a function to reduce the resolution of the polygon.

Hi @Tasty213,
i'm not one of the package managers and didn't work with this package yet, but am working on a very simliar thing right now.
There are several simplification algorithms already implemented in different packages, e.g. https://pypi.org/project/rdp/ for
douglas-peucker which you might be able to use with the provided mapping functionality (maybe..)
What i didn't come across yet, but would also be beneficial for large polygons, is a representation similar to the google encoded polyline. It can be easily used with normal LineStrings and simple Polygons, but not on any GeoJSON as a whole :/
Well hope the simplification might help in your case
cheers

Thanks for the tip @TheGreatRefrigerator, I agree that https://github.com/fhirschmann/rdp already handles the use case you're describing, @Tasty213. Can you give that a try and report back?


Repo needs index.js so that it can be invoked with require

To reproduce, run var fuzzy = require('clj-fuzzy') in requirebin.com - throws error.

Hello @paragmajum, I just tried your example in requirebin.com and it does work.
var fuzzy = require('clj-fuzzy');

console.log(fuzzy.phonetics.metaphone('Michael'));
>>> MXL

Ah ok! I had used var clj_fuzzy as the variable which was breaking the code (instead of var fuzzy). I guess we can close this.

No problem @paragmajum.


1.2 Update the README.md in pg repo

Update the README.md in the repo with the accordingly needed information

https://github.com/DSCI-310/dsci-310-group-10-GCC-pkg/pull/4 Done with this PR


Dev/roschuma/boost

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ywj11407 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @ywj11407, I think this PR was made in error.
If you believe there are changes on that branch that need to be in master, please create your own branch with just those changes and make a new PR.


Tabs don't wrap well in 3.3

Don't wrap well ever.

There is hope... https://github.com/silverstripe/silverstripe-framework/pull/5208

Fixed with #5208


remove missing LF in cert-manager templates

When parsing templates (e.g. with helm template) it is important to have the right file-ends - otherwise LineFeeds are missing and yaml files parsed with get broken.
This PR prevents problems like:
 1	---
     2	# Source: cert-manager/templates/certificate-crd.yaml
     3	apiVersion: apiextensions.k8s.io/v1beta1
     4	kind: CustomResourceDefinition
     5	metadata:
     6	  name: certificates.certmanager.k8s.io
     7	  annotations:
     8	    "helm.sh/hook": crd-install
     9	  labels:
    10	    app: cert-manager
    11	    chart: cert-manager-v0.5.2
    12	    release: cert-manager
    13	    heritage: Tiller
    14	spec:
    15	  group: certmanager.k8s.io
    16	  version: v1alpha1
    17	  scope: Namespaced
    18	  names:
    19	    kind: Certificate
    20	    plural: certificates
    21	    shortNames:
    22	      - cert
    23	      - certs
    24	      ---
    25	# Source: cert-manager/templates/clusterissuer-crd.yaml
    26	apiVersion: apiextensions.k8s.io/v1beta1
    27	kind: CustomResourceDefinition
    28	metadata:
    29	  name: clusterissuers.certmanager.k8s.io
    30	  annotations:
    31	    "helm.sh/hook": crd-install
    32	  labels:
    33	    app: cert-manager
    34	    chart: cert-manager-v0.5.2
    35	    release: cert-manager
    36	    heritage: Tiller
    37	spec:
    38	  group: certmanager.k8s.io
    39	  version: v1alpha1
    40	  names:
    41	    kind: ClusterIssuer
    42	    plural: clusterissuers
    43	  scope: Cluster---
    44	# Source: cert-manager/templates/deployment.yaml
    45	apiVersion: apps/v1beta1
    46	kind: Deployment
    47	metadata:
    48	  name: cert-manager
    49	  namespace: "default"
    50	  labels:
    51	    app: cert-manager
    52	    chart: cert-manager-v0.5.2
    53	    release: cert-manager
    54	    heritage: Tiller
    55	spec:
    56	  replicas: 1
    57	  selector:
    58	    matchLabels:
    59	      app: cert-manager
    60	      release: cert-manager
    61	  template:
    62	    metadata:
    63	      labels:
    64	        app: cert-manager
    65	        release: cert-manager
    66	      annotations:
    67	    spec:
    68	      serviceAccountName: cert-manager
    69	      containers:
    70	        - name: cert-manager
    71	          image: "quay.io/jetstack/cert-manager-controller:v0.5.2"
    72	          imagePullPolicy: IfNotPresent
    73	          args:
    74	          - --cluster-resource-namespace=$(POD_NAMESPACE)
    75	          - --leader-election-namespace=$(POD_NAMESPACE)
    76	          env:
    77	          - name: POD_NAMESPACE
    78	            valueFrom:
    79	              fieldRef:
    80	                fieldPath: metadata.namespace
    81	          resources:
    82	            {}
    83
    84	---
    85	# Source: cert-manager/templates/issuer-crd.yaml
    86	apiVersion: apiextensions.k8s.io/v1beta1
    87	kind: CustomResourceDefinition
    88	metadata:
    89	  name: issuers.certmanager.k8s.io
    90	  annotations:
    91	    "helm.sh/hook": crd-install
    92	  labels:
    93	    app: cert-manager
    94	    chart: cert-manager-v0.5.2
    95	    release: cert-manager
    96	    heritage: Tiller
    97	spec:
    98	  group: certmanager.k8s.io
    99	  version: v1alpha1
   100	  names:
   101	    kind: Issuer
   102	    plural: issuers
   103	  scope: Namespaced---
   104	# Source: cert-manager/templates/rbac.yaml
   105	apiVersion: rbac.authorization.k8s.io/v1beta1
   106	kind: ClusterRole
   107	metadata:
   108	  name: cert-manager
   109	  labels:
   110	    app: cert-manager
   111	    chart: cert-manager-v0.5.2
   112	    release: cert-manager
   113	    heritage: Tiller
   114	rules:
   115	  - apiGroups: ["certmanager.k8s.io"]
   116	    resources: ["certificates", "issuers", "clusterissuers"]
   117	    verbs: ["*"]
   118	  - apiGroups: [""]
   119	    resources: ["configmaps", "secrets", "events", "services", "pods"]
   120	    verbs: ["*"]
   121	  - apiGroups: ["extensions"]
   122	    resources: ["ingresses"]
   123	    verbs: ["*"]
   124	---
   125	apiVersion: rbac.authorization.k8s.io/v1beta1
   126	kind: ClusterRoleBinding
   127	metadata:
   128	  name: cert-manager
   129	  labels:
   130	    app: cert-manager
   131	    chart: cert-manager-v0.5.2
   132	    release: cert-manager
   133	    heritage: Tiller
   134	roleRef:
   135	  apiGroup: rbac.authorization.k8s.io
   136	  kind: ClusterRole
   137	  name: cert-manager
   138	subjects:
   139	  - name: cert-manager
   140	    namespace: "default"
   141	    kind: ServiceAccount---
   142	# Source: cert-manager/templates/serviceaccount.yaml
   143	apiVersion: v1
   144	kind: ServiceAccount
   145	metadata:
   146	  name: cert-manager
   147	  namespace: "default"
   148	  labels:
   149	    app: cert-manager
   150	    chart: cert-manager-v0.5.2
   151	    release: cert-manager
   152	    heritage: Tiller$ cat build/cert-manager/templates/* | ssh root@${MASTER} kubectl --namespace ${NAMESPACE} apply -f - --dry-run
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
error: error parsing STDIN: error converting YAML to JSON: yaml: line 25: could not find expected ':'

Especially look at the lines 24, 43, 102, 141
 Client: &version.Version{SemVer:"v2.12.3", GitCommit:"eecf22f77df5f65c823aacd2dbd30ae6c65f186e", GitTreeState:"clean"}

push

@munnerz @kragniz
can this be merged? What about the merge conflicts - when I opened the PR there were none. Now the button to see or resolve the conflicts is disabled for me.

anybody out there?

Sorry for the delay on this - we don't accept contributions into this repository directly for the cert-manager chart, in favour of managing our own chart in the jetstack/cert-manager repo.
This version is now also deprecated, in favour of our Jetstack-hosted chart repository. You can see more information in #12970 😄
Thanks for your contribution!
/close

It'd be awesome if you could submit this change upstream too! I didn't realise this was an issue 🙈


Resolve Deprecated warnings in the Error traits

Resolve the Deprecated warnings in the following traits:

pbd::dpi::error::Error
pbd::dsg::error::Error
pbd::dtc::error::Error
pbd::dua::error::Error

The impacted methods are the following:

description(&self) -> &str
Deprecated since 1.42.0: use the Display impl or to_string()
cause(&self) -> Option<&dyn Error>
Deprecated since 1.33.0: replaced by Error::source, which can support downcasting

The Rust lang std::io::Error also has these warnings.


xorg.xf86videoati: 7.9.0 -> 18.0.1

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 18.0.1 with grep in /nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1
directory tree listing: https://gist.github.com/094fbc79ea86324a9b95f4784be3e1cd

Success on aarch64-linux (full log)
Attempted: xorg.xf86videoati
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ldxhq4l2j4hvim5v474g6vs1xhs1lq23-xf86-video-ati-18.0.1
shrinking /nix/store/ldxhq4l2j4hvim5v474g6vs1xhs1lq23-xf86-video-ati-18.0.1/lib/xorg/modules/drivers/radeon_drv.so
shrinking /nix/store/ldxhq4l2j4hvim5v474g6vs1xhs1lq23-xf86-video-ati-18.0.1/lib/xorg/modules/drivers/ati_drv.so
gzipping man pages under /nix/store/ldxhq4l2j4hvim5v474g6vs1xhs1lq23-xf86-video-ati-18.0.1/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ldxhq4l2j4hvim5v474g6vs1xhs1lq23-xf86-video-ati-18.0.1/lib
patching script interpreter paths in /nix/store/ldxhq4l2j4hvim5v474g6vs1xhs1lq23-xf86-video-ati-18.0.1
checking for references to /build in /nix/store/ldxhq4l2j4hvim5v474g6vs1xhs1lq23-xf86-video-ati-18.0.1...
/nix/store/ldxhq4l2j4hvim5v474g6vs1xhs1lq23-xf86-video-ati-18.0.1

Success on x86_64-linux (full log)
Attempted: xorg.xf86videoati
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1
shrinking /nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1/lib/xorg/modules/drivers/ati_drv.so
shrinking /nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1/lib/xorg/modules/drivers/radeon_drv.so
gzipping man pages under /nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1/lib
patching script interpreter paths in /nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1
checking for references to /build in /nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1...
/nix/store/00hw6alrivxhdl0x9alclhidmnq358mb-xf86-video-ati-18.0.1


Upgrading to npm7 and latest version of puppeteer

@googlebot I signed it!

@googlebot I signed it!
On Wed, Jul 21, 2021 at 2:25 PM google-cla[bot] @.***>
wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle%2Fmodel-viewer%2Fpull%2F2601
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/model-viewer/pull/2601#issuecomment-884510176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA536XLEYSQ5U6V75JV43LTTY43K3ANCNFSM5AYVRYSA
.

@googlebot I signed it!

@googlebot I signed it!


a new project with 0.37 doesn't run with ng serve

OSX 10.11.3

angular-cli: 0.0.37
node: 4.4.3
os: darwin x64

create a new project with ng new p
cd into the project and run ng serve
project doesn't start and dumps a log to console

Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
Cannot read property 'sourceDir' of undefined
TypeError: Cannot read property 'sourceDir' of undefined
at new Angular2App (/Users/eleitch/tmp/p/node_modules/angular-cli/lib/broccoli/angular2-app.js:30:40)
at module.exports (/Users/eleitch/tmp/p/angular-cli-build.js:6:10)
at Class.module.exports.Task.extend.setupBroccoliBuilder (/Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/lib/models/builder.js:55:19)
at Class.module.exports.Task.extend.init (/Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/lib/models/builder.js:89:10)
at new Class (/Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/node_modules/core-object/core-object.js:18:12)
at Class.module.exports.Task.extend.run (/Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/lib/tasks/serve.js:15:19)
at /Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/lib/commands/serve.js:64:24
at lib$rsvp$$internal$$tryCatch (/Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1036:16)
at lib$rsvp$$internal$$invokeCallback (/Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1048:17)
at /Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:331:11
at lib$rsvp$asap$$flush (/Users/eleitch/tmp/p/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1198:9)
at nextTickCallbackWith0Args (node.js:420:9)
at process._tickCallback (node.js:349:13)

Select one of the following:
I am filing a bug.

In this case you need the following information:

OS. Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Versions. Please run ng --version. If there's nothing outputted, please
run in a Terminal:
 node --version
 npm --version
 npm info angular-cli

And paste the result here.

Repro steps. Tell us exactly what you did and how you came to the failure.
If you can give us steps from the moment you created an empty application,
even better! Please try to be as descriptive as you can; this will avoid
unnecessary back and forth. Was this an app that wasn't created using the
CLI? What change did you do on your code? etc.

The log given by the failure. Normally this include a stack trace and some
more information.

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

I am filing a feature request.
Unfortunately, for now, although we accept proposals, it will be probably be
deferred. It's not that we don't want to hear you, it's that we're focusing
on the beta release and as such we want to keep things a bit tidier than it
will be once this is out in the open.
We're not closed to good ideas, we simply have a limited amount of bandwidth.
There's only 24 hours per day.

I want customer support / I don't know how to do X.
This is unfortunately not the right place. Please join the discussion on
gitter, Stack Overflow or twitter and don't be afraid to post your
questions there. A FAQ will be created with those and it will help answer
questions other people might have as well.

I want to help!
Please read our contributing guidelines;
https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md
If you really want to be part of the crew and start cracking,
try to contact us on gitter. We're never really far and we might have
something just for you!

I solved the problem. The generated angular-cli.json file is missing a few new properties.
The defaults property was missing. I also had to add the sourceDir child property. After adding these it worked again.
{
  "routes": [],
  "defaults": {
      "sourceDir": "src/client"
  }
}

The page will start up but not output anything to dist/vendor. Still working on this.

Finally got it working again. All the node_module includes must be specified in angular-cli-build.js
vendorNpmFiles: ["es6-shim/es6-shim.js",
                    "systemjs/dist/system-polyfills.js",
                    "angular2/bundles/angular2-polyfills.js",
                    "systemjs/dist/system.src.js",
                    "rxjs/bundles/Rx.js",
                    "angular2/bundles/angular2.dev.js",
                    "angular2/bundles/http.dev.js",
                    "angular2/bundles/router.dev.js"]
  });

Yes. We now never copy your vendor files automatically. You have to specify them.
Also we don't use bundles locally anymore, but that depends on your systemJS configuration and might not be a problem.
Here's our current vendor list:
    vendorNpmFiles: [
      'systemjs/dist/system-polyfills.js',
      'systemjs/dist/system.src.js',
      'zone.js/dist/*.js',
      'es6-shim/es6-shim.js',
      'reflect-metadata/*.js',
      'rxjs/**/*.js',
<EMAIL_ADDRESS>    ]

the @angular/**/*.js doesn't work.

I'm also wondering why you won't include those for us? After running ng new we then have to go in make sure our angular-build-cli.js includes all those things manually? That seems like a step backwards.

I have a PR to fix this issue
https://github.com/angular/angular-cli/pull/679

I had to nuke my old generated code and place it in a newly configured project. It moved from 0.0.3x to 1.0.0-beta within a few days. Lots of changes happened all at once.

@metric152 I ran npm update angular-cli and it updated it from 0.0.37 to 0.0.39. I can't get it to update to beta :/

@sharpmachine You shouldn't build new projects with anything older than the beta.
As for upgrading to the latest beta, try npm install -g angular-cli@beta or just npm install -g angular-cli@latest.

@hansl I tried to run "npm install -g angular-cli@latest" but then I run "ng -v" and still getting an older version 0.0.39.
How can I force to download latest beta version?

Try upgrade instead of install
On Monday, June 13, 2016, Federico-Comesana<EMAIL_ADDRESS>wrote:

@hansl https://github.com/hansl I tried to run "npm install -g
angular-cli@latest" but then I run "ng -v" and still getting an older
version 0.0.39.
How can I force to download latest beta version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/616#issuecomment-225695570,
or mute the thread
https://github.com/notifications/unsubscribe/AANCOrRYOyqPJq-Vmy5VmWHLUT68dGdkks5qLbsAgaJpZM4IWkMQ
.

@Federico-Comesana we recently added https://github.com/angular/angular-cli#updating-angular-cli, it should help you upgrade.

@filipesilva I've followed your link and still have an old angular-cli version (now is 0.0.33).
Do am I missing something?
I had run:

npm uninstall -g angular-cli
npm cache clean
npm install -g angular-cli@latest

I'm running "ng -v" in my home folder.
My environment:

Ubuntu 14.04.4 LTS
angular-cli: 0.0.33
node: 5.11.1
npm: 3.8.6

@Federico-Comesana that's really weird. Try forcing the version manually npm install -g<EMAIL_ADDRESS>

just need to update everytime i need to uninstall and install again i need to migrate my project to latest one its not good

update instructions don't work for me either.  currently latest is 22, and , even after following the 'update' instructions, i'm stuck at beta 15


Add method to infer primary key of model

resolves #

Problem

Solution

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
[ ] This PR includes type annotations for new and modified functions

Current dependencies on/for this PR:

#9650  👈
main

This stack of pull requests is managed by Graphite.


Updated Volunteers section with Grids

Kind of change this PR introduce :
This pr contain changes related to the #4 Redesign the volunteer section.
In this pr the volunteer section is redesigned.
Issue it resolves :
Prevoius UI contain tabular representation of volunteer section which is not so good according to modern Ui's.
In this pr volunteer section is redesigned to modern flex based design with good looking tiles.
Screenshots & GitHub Page Link :

Changed To :-

Issue it resolves :- #4
Github Page Link :- https://davyj123.github.io/Blood-Buddy/

Done.

that's my little mistake

ok mam

mam actually working proper at my local repo

Updated succesfully

Not showing any scroll bar

Done

@2024-SANDHYA  done with all changes

Mam it is already perfect

All things are done from myside now.

I have decreased font size by 6px because it is making website irresponsive in mobile widths.

Mam when will this pr will get merged

@davyj123  Pull the latest changes from the repo. Seek help from mentors @davyj123

I pulled the latest changes. Now what i have to do.

Mam please guide me

Also @davyj123 Pull and merge the latest changes from the repo, I can see you have not done anything

Done with previous design of register button

Please Check it.

Fix these @davyj123 :
1. ![image](https://user-images.githubusercontent.com/75671152/147679698-340cfa07-5e8d-44eb-81bc-e5f0ccbbc242.png)

2. Where's the spacing in b/w 'em:
   ![image](https://user-images.githubusercontent.com/75671152/147679773-425b2c01-85ce-461a-9ca8-996600310b21.png)

3. Fix the footer:
   ![image](https://user-images.githubusercontent.com/75671152/147679895-6b1791f7-35fb-481c-8523-82828fe8ab8e.png)

@davyj123  You have not worked on the second issue.

Done second one.

Mam You have assigned me #114. Please tell me if i will make a github page link for that then this will expires or this will remain in working condition?

Mam You have assigned me #114. Please tell me if i will make a github page link for that then this will expires or this will remain in working condition?

Both will work ofc. @davyj123

Pull the latest changes from the repo first @davyj123

Alredy pulled

Now please tell me this will get merged or any issues yet.

Pull that again please, follow what I am saying @davyj123 Because recent changes are added to the code.

I pulled again using fetch stream  then pulled to update my local repo and then repushed my changes to my branch.

Now please help me in this pull request


Initial idea for a rake task

Fixes #21
Basic idea for now, any suggestions on default options and the like?

Can one of the admins verify this patch?

Is this still wanted?  (Sorry for the long delay!)

good question, i think most projects fix it up themselves somehow.
see for instance puppet-module-skeleton

Having a rake task removes a few more lines of boilerplate in each Rakefile - I'd still say it's useful.

merge away then…!

I'm still up for a merge! :+1:

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Create Proactive alert for WC master high memory

As a customer i do want to be notified when master nodes on the WC are running under high memory consumption for a longer period of time. The usage of master nodes are increasing especially with security pack where if any additional scans are running, the master nodes can be impacted and go OOM.
We would like to create the alerts for the high memory consumption to alert and talk with customers about resizing the nodes. This alert would page AEs to start the communication between Customers and Cloud team for the resizing/investigation.
The go-to instance type would be then the r6.x where the CPUs are the same but they are memory oriented.

why don't we instead make use of the already existing too many requests alert?
It serves exactly the same purpose but using a meaningful metric (API being overloaded) rather than this system load based one.
We also already have a list of affected clusters https://github.com/giantswarm/giantswarm/issues/23874

Initially let's try with the 'notify' page to alert us in the slack-channel for validation of the usefulness of the alert

PR https://github.com/giantswarm/prometheus-rules/pull/636
Still missing the ops recipe

Ops recipe merged, there is room for improvement in future

alert is no active


[COMMENTS] Recommended subjects and textbooks for self-study (for physicists)

Please leave a comment if you have any other textbook/resource recommendations!

Test

Test

Test

Test

Test

Test


C# API Not Handling Coupons In Subscriptions

I wanted to highlight a problem we are continuing to have referencing subscriptions with coupons using your C# API.
When I run an API call on one of our existing (test) subscriptions using:
var subscription = Recurly.Subscriptions.Get(newSubscriptionDetails.subscription.uuid);
where uuid references a valid subscription, the XML payload that is returned shows an error/exception in the coupon fields as in Pic1 (see highlights in blue).

However, if I look at this account in the web console panel the subscription shows very clearly that a valid coupon is attached (see Pic2)

Where this is causing me problems is when I try to serialize the subscription object into a Json I get an error related to the Coupon field ..
Is this a known issue with a workaround or possible a bug in the C# API ?
Follow-Up: I spoke with Charlie Gerrior and he indicated that the problem was an incomplete C# implementation of the latest subscription/coupon XML payload

@cbarton @bhelx Any chance either of you could take a look at this?

@cgerrior Could you add any details you know about it?

@djovanovi I'm able to reproduce the issue you are seeing above, but I think it's just an issue with how the debugger works. It seems when I pull up a subscription in the debugger it calls every method on the object and i think it's trying to improperly call Coupons.
You should be able to get redemptions by using the API as expected (using GetRedemptions):
  var subscription = Recurly.Subscriptions.Get("352e52069aa207245b96a84331881f46");
  var redemptions = subscription.GetRedemptions();

Please re-open if you think this answer didn't solve your problem. I'd be happy to help you get to the bottom of it.

Thanks Benjamin,
I will test soon and get back if I still see the issue outside of the
debugger.
Appreciate your help !
-DJ
On Mon, Mar 28, 2016 at 6:31 PM, Benjamin Eckel<EMAIL_ADDRESS>wrote:

@djovanovi https://github.com/djovanovi I'm able to reproduce the issue
you are seeing above, but I think it's just an issue with how the debugger
works. It seems when I pull up a subscription in the debugger it calls
every method on the object and i think it's trying to improperly call
Coupons.
You should be able to get redemptions by using the API as expected (using
GetRedemptions):
var subscription = Recurly.Subscriptions.Get("352e52069aa207245b96a84331881f46");
var redemptions = subscription.GetRedemptions();
[image: screen shot 2016-03-28 at 4 27 22 pm]
https://cloud.githubusercontent.com/assets/185919/14093388/59a5eb9a-f502-11e5-9948-6e595615082e.png
Please re-open if you think this answer didn't solve your problem. I'd be
happy to help you get to the bottom of it.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/recurly/recurly-client-net/issues/138#issuecomment-202624825


Flashing M for "million" in resistance mode

As noted on Louis Rossmann's stream, the "M" before the "ohm" character flashes on and off in the cases of high resistance.
I do not know if this is when using the command line version or the win32 version.
It is currently unknown if a similar problem exists for other unit prefixes as I do not own the hardware to test and debug.

It's in the Windows GUI version (GDI).
I was going to get Louis to drop me a data dump from his meter, as I'm wondering if I've missed something.   It's annoying to me too and so I would like to get it fixed up.  Having the meter data from Louis would be the most useful thing to me right now, as I too do not have a BK390A meter, so the whole thing has been done just from the spec sheet.

Very interesting. I would be interested to see the data dump too if you are willing to share. Thanks for your work on this project.
If I have time this weekend, I may write some code to enumerate the available serial ports and try sending and receiving a command/response pair to auto-defect the port the BK390A is on.

That'd be good if you can add that; saves another parameter having to be explicitly set.
At least this meter does have a fixed set of comms parameters (rate/bits/stop),  I just left it generic for any future adaptations to other meters that people might try.
I'm not sure if there was any data-send options to the meter (just listen only), but you should see the same frame-start sequences within a second or two, so that could be your way of testing.

Thanks for the info. Just downloaded the serial protocol manual, and hopefully I can look at it later this week.

Reviewed the code and the documentation. Code looks pretty sane regarding the "prefix". Would be curious to know if it occurs in any of the other modes (current, etc.)

Can confirm it happens in other modes.  For example, at around https://youtu.be/3YGCFeZZS6A?t=20m38s (watch about 20 seconds), it happens with V and mV.

Another observation is that the multimeter data is updating only about once a second, but the units glitch happens within a single digit update. Ex: V changes to mV then changes back to V every time the digits get updated. I think it therefore must be somehow clearing the prefix while the code is waiting for more serial data.
With that said, I can't figure out where this could possibly occur in the code....

I was wondering if you are able to get in touch with Louis and if he is willing to run the software in debug mode to help us diagnose this problem. Maybe we can even add some extra debug prints to help with this.

I've asked him several times.  It's just a waiting game.  Most of my debugging in the past is purely from what's seen on the videos, that's about all the debugging data you get, which leads to false fixes occasionally.    What'd be best is to have access to one of these meters.

He's only got the one. What's more realistically going to happen is someone who owns the meter might finally stumble on to this and participate.

Let's hope so! Or I thought about writing a serial port emulator that sends data in that format... but probably not worth the time. Let's just hope for a user willing to do a -d !

One more thing -- I also noticed that it doesn't seem to keep a a space either. That is, the prefix appears to be emptystring, even though you set it to a space or a character every time. That is why the width keeps changing.
Is it possible in the end, an older version is being used? Just want to rule that out.  Thanks!

I fixed that on my local version here, keeps a fixed width.

I guess that makes me wonder how old of a version he is using. Is it possible the flashing prefix is fixed in the current version as well?

There appears to be a lot of missing default cases in various switch statements in the code which could be part of the problem. Ideally these would be logged.
I also noticed in the datasheet it says "The serial data is sent to SDO pin twice every A/D conversion cycle.", it's unclear to me exactly what this means (and my serial-data-fu is lacking), but I wonder if it comes quickly and the second send might be corrupted. Perhaps the previous software Louis used was working around this.
And how did you develop this without the multimeter and without an emulator?

Developed from the spec, nothing more.  Blind development as it were.
As for the SDO (serial-data-output) thing, it just means that the data is sent twice per A/D conversion and that the buffer simply ( should? ) remain constant, but it would seen there's an ambiguity/nuance being missed which is why at this point getting actual live debugging data would be more useful than more speculation.
As for the missing defaults on the case statements, other than perhaps logging the situation "bit wasn't handled by existing case statement", it's not likely to assist with the situation.
We just need a debugging run of data, else it's just more blind wandering through the forest. . . . unless someone wants to fork out $ to buy one of the meters ( sorry folks, I've already dumped enough $ in to free projects for now ).

I'm aware of that live debugging data is ideal, I was just trying to suggest alternatives given that it doesn't seem to be forthcoming.
As to the missing defaults, it actually seems to me a corrupted RANGE of something like 0x0F causing falling through seems to be the most likely explanation.
I've also just noticed that dps is not cleared every loop unlike the other variables, if it was I suspect you'd see that reset too.

You get to the point where you choose;  if the data is corrupted, do you act on it, or ignore it.
The latter is being opted currently, particularly given that we're uncertain as to the nature of the data.
I'll ask Louis a few more times for data, but beyond that someone really just needs to get their own meter, or find someone who has it ( who originally influenced Louis to buy this one? ).
It's hard enough getting him to get the time to update important things, let alone smaller (but annoying) things like this.  At this stage, I'd say someone has to buy/borrow one (not from Louis) and when it's proven to work properly that's when we can finally push it to Louis and say "Here, it's working 100%".

Yes, I realise that's not totally conclusive and I understand the reticence to play around without the data.
I did just find something else though that you may not have been aware of, I previously only saw the document on the B&K site, but I found the full manual for some boards, and it appears that one or both of these are the same:
http://www.cyrustek.com.tw/spec/ES51962.pdf
http://www.cyrustek.com.tw/spec/ES51978.pdf
It looks like there is at least one other multimeter that uses this, the Peaktech 3315. Perhaps there's more. It might be possible to find some reference code or other multimeters for these.

Software looks real familiar... price is steep still ( considering the purpose,  I've got no problem spending $ on a good meter that I'd use though ).
https://www.ebay.com/itm/PeakTech-3315-Digital-USB-Multimeter-Messgerat-Meter-Messer-Digitalmultimeter-/221583963478

This suggests that a lot of multimeters can be hacked to do this:
http://www.flashingleds.net/rs232/rs232.html

It's unclear if the 51962 and 51978 are exactly the same, and which exactly the B&K uses if not, but I did find some other models for both and there are other Cyrustech 519 chips besides these.
Given this and the above you might be able to find something really cheap for this, you might already own something if you're willing to do the hack above.

Actually it looks like the B&K doc is taken from the Cyrustech 51962 manual given the superfluous section at the top of the B&K doc. Peaktech has the same superfluous section.
Given this apparently Uni-T UT70B is compatible too.

Interesting different to note though is that the BK390A suggests NO parity for regular serial and ODD parity for serial over usb.
The site codemachine linked to shows a screenshot with EVEN parity.
I wonder why these all differ? Could that be affecting the communication somehow?

Very cool find though that we could probably work with different hardware to get this working :)

I can't find anything about even parity (which site?), but the ES519xx chips do seem to have differing protocols.
A parity issue seems like it'd drop all data though.

The screenshot: http://www.flashingleds.net/rs232/dmm-serial-packet.jpg
on the site you linked to: http://www.flashingleds.net/rs232/rs232.html
suggests an even parity bit

I think within a second we can see what's going on with the flickering looking at this data.
Run 1 with 1.4k resistor
  Meter displays:
     RS232 AUTO
     1.473 k(omega symbol)

C:\Users\mark\Downloads\bk390_app>win-bk390a.exe -d -z 120 -p 3 -s 2400:7o1 -m -fc #10ff10 -bc #000000 -wx 480 -wy 60 -fw 600
Port COM3 Opened
        Baudrate = 2400
        ByteSize = 7
        StopBits = 0
        Parity   = 1
        Setting time-outs successful
        CommMask successful
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 31 31 34 37 33 33 30 30 32 0d 0a :END
DATA START: 0a :END

Run 2 with 1k resistor
  Meter displays:
     RS232 AUTO
     98.8 (omega symbol)

C:\Users\mark\Downloads\bk390_app>win-bk390a.exe -d -z 120 -p 3 -s 2400:7o1 -m -fc #10ff10 -bc #000000 -wx 480 -wy 60 -fw 600
Port COM3 Opened
        Baudrate = 2400
        ByteSize = 7
        StopBits = 0
        Parity   = 1
        Setting time-outs successful
        CommMask successful
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 30 30 39 38 38 33 30 30 32 0d 0a :END
DATA START: 0a :END

Run 3 with shorted leads
  Meter displays:
     RS232 AUTO
     0.6 (omega symbol)

C:\Users\mark\Downloads\bk390_app>win-bk390a.exe -d -z 120 -p 3 -s 2400:7o1 -m -fc #10ff10 -bc #000000 -wx 480 -wy 60 -fw 600
Port COM3 Opened
        Baudrate = 2400
        ByteSize = 7
        StopBits = 0
        Parity   = 1
        Setting time-outs successful
        CommMask successful
DATA START: 30 30 30 30 36 33 30 30 32 0d 0a :END
DATA START: 30 30 30 30 36 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 30 30 30 30 36 33 30 30 32 0d 0a :END
DATA START: 30 30 30 30 36 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 30 30 30 30 36 33 30 30 32 0d 0a :END
DATA START: 30 30 30 30 36 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 30 30 30 30 35 33 30 30 32 0d 0a :END
DATA START: 30 30 30 30 35 33 30 30 32 0d 0a :END
DATA START: 0a :END
DATA START: 30 30 30 30 35 33 30 30 32 0d 0a :END
DATA START: 30 30 30 30 35 33 30 30 32 0d 0a :END
DATA START: 0a :END

In this case I think a simple length check will do the job. I already had one for my auto port detection code, so I just added the check for every serial 'packet' received too. I think my code changes should be just about ready for review, testing, and merge :)

I've ended up storing a copy of the last good frame, and if the next frame is a dud, it replays the previous one.
Code seems to be working now with the tester.
The frame length was being tested already, but there was actually a 1-off error in that, so it amuses me that the code ever worked in the first place.

Right, so the reason the symptom affected the range only is it's the first character in the frame and it's getting hit with 0x0A which will drop into the silent default case - the rest of the frame will remain the same from the previous iteration, not being overwritten.

Just a small robustness issue you may or may not want to deal with, which likely wouldn't occur in practice - it looks like there is no functioning overlength check because the loop will end after the max size without having read the LF and nowhere in the code does it check the end_of_frame_received variable, it only writes to it.
In practice this would treat the first part as a valid frame and then treat the extra as an invalid underlength frame, but you might want to drop the whole overlength frame.

Just sorting out the scaling / display quirks right now, thankfully this person is really quick on the ball for the testing cycle.
After that you'll have to resubmit your PR likely to suit the new changes; then we can finally move forward with the automated stuff.

I fixed the off-by-one in my latest commit in my fork so that the length checks work.
Glad you found a tester. Who is it?
Let me know if I have to resubmit the PR in the end. I've made a lot of good changes (at least in my opinion) hopefully I don't have to rebase to your fork and do them over again.

Chap called Mark Stanley.
I've notified the important-person about the new binary, guess we'll see on the next live stream or so if the update has been made.

Hello everyone, I was just about to tear down my setup when I got Paul's email inviting me over here.  I would be glad to help.

Fantastic, Nullkraft. Could you please test my fork to see if it works with and without specifying the port with -p on the commandline?  Thanks!

OK, give me a minute to reboot into windows.

OK, I see that you've already incorporated Paul's changes.  I tested for the flashing 'm'.  Anyway, I ran it without any command line parameters and it of course took 2 seconds to find the port but it did find it.  Next I ran it with -d and finally I ran it with -p 3 -d and everything seems to be working as advertised.
I noticed a faster startup when specifying the port number.  You might want to add an artificial delay so the end user doesn't think something is wrong with auto detection.  Just saying. ;)

Maybe make it write up "Checking port... ", ah but all the comms detection happens before the GDI starts, though you could swap that around.
Just noticed there's a small issue when you've moved the i++ line around, it'll sort of break the debug code afterwards.  I'll let you settle out your changes and then I'll clean that back up.

Alright, off to a family event.  I'll check back in later this evening (East coast USA).

(Or of course we could talk in the merge request thread if we want to keep the discussion in inflex's repo)

@Ownasaurus can you check out lines 511~538 for me in the latest update after the PR; wasn't quite sure what you were trying to do in there, I reshuffled some items but if you could explicitly-brace sections or clarify, that'd be great.
Stylistically I prefer variable modifications outside of the if() tests, esp things like if (foo-->x)   or if (--foo > x) type things, just saves some ambiguities ( even though it should be clear to coders, it's more about avoiding future side effects/accidents ).
With code blocks,  the style being used is the opening brace on the same line;
if (foo) {
   ...
}

rather than
if (foo)
{
   ...
}

again, a style thing, the rest of the code is (should be ;) ) styled that way afaik.
Other than that, since I don't have a meter here, not much more that I can pick out.

@inflex After carefully reviewing the code, it looks like you got it right. I'd just clean up the comments and it should work as I intended.
What might need tweaking is the number of attempts and the sleep time though. Is sleeping for 1 second sufficient? Is two attempts necessary? (I added that bit in case the meter sent a bad packet followed by the correct data)

nope i'm delusional. fixing again now.

Looks like he's updated and it appears to be working -
https://www.youtube.com/watch?v=TsfaQQc2RAg

Yes it's being done on my fork :)

@pvtinflex one more thing though -- do you have a timestamp showing the units prefix not flashing? i couldnt find it quickly in the hour long video.

About 3:18 it starts.

I don't see any measurements that would require a prefix though. I see all voltages being measured that are < 10. But if @Nullkraft says it's working, I believe him anyhow.

Usually what would happen is that because of the auto-ranging, it would most times go through the mV range to get to the required one, and that would load up the prefix.  There's also more a few minutes later and it seems to be steady/fine there too.  Typically the blinking 'm' kicks in very quickly.

Oh gotcha. Awesome work!

Me: "greetings. Hoping the new version of the bk-390a software is working out for you (if you're using it)"
Louis: "I never updated"

Note line 13 says COM99...
C:\Users\mark\Downloads\bk390_app>pl-bk390a.exe -d
Port detected: COM3
Port COM3 Opened
Baudrate = 2400
ByteSize = 7
StopBits = 0
Parity   = 1
Setting time-outs successful
CommMask successful
Waiting for 2s to get a data sample
DATA START: 30 30 37 36 37 3b 34 30 38 0d 0a :END
LENGTH CHECK: SUCCESS
DATA FORMAT CHECK: SUCCESS
COM99 automatically detected.
DATA START: 30 30 37 36 37 3b 34 30 38 0d 0a :END [11 bytes]
DATA START: 30 30 37 36 37 3b 34 30 38 0d 0a :END [11 bytes]
DATA START: 30 30 37 36 37 3b 34 30 38 0d 0a :END [11 bytes]
DATA START: 30 30 37 36 37 3b 34 30 38 0d 0a :END [11 bytes]
DATA START: 30 30 37 36 37 3b 34 30 38 0d 0a :END [11 bytes]
DATA START: :END [0 bytes]
Invalid number of bytes, expected 11, received 0, loading previous frame
DATA START: 30 30 37 36 37 3b 34 30 38 0d 0a :END [11 bytes]
DATA START: 30 30 37 36 37 3b 34 30 38 0d 0a :END [11 bytes]
DATA START: :END [0 bytes]
Invalid number of bytes, expected 11, received 0, loading previous frame

Right this is @inflex's current version right? That should be one of the things that is fixed in my latest version.
So we still get some funny packets. But that's OK for now since we handle them gracefully. I think my version also has a few of these 0 byte packets.

I tried the command line:  win-bk390a.exe -z 120 -p 3 -m -fc #ff1010 -bc #000000 -fw 600
and everything seems to be working fine.  I changed -z a few times and had good control.  I got a rather large red font in the display.
I will mention one thing, when I set -z to a relatively small value (less than 25) the display began to cutoff portions of the information, namely the description(?) such as the word 'Frequency'.

@Nullkraft can you do a test with the latest binary I have uploaded here, to see if it produces the "version/build" code in the bottom left corner,  I'm anticipating it to show up something like "B75          Volts" or similar on the bottom

I'm seeing [B54] (with the brackets) in the bottom left corner.
By the way, the port detection seems to be working a LOT faster.  Did you do something?

That looks great. And if you ran it with -m you'd probably see it like "[B54] Resistance" or whichever mode its in.
To my knowledge neither of us modified the port detection code any further.

That's got it, -m did just as you said.   And you're right, if I hammer the port too quickly I will get the com port error just like before.  Still, it seems to be operating extremely well and is a real pleasure to use at this point.

@Nullkraft screenshot? (Demanding, I know :) )

Our do it yourself with my new PR code :D <3

Do you need the screenshot for something?  I can jump back to windows if you do.

Prob a screenshot of the GUI with you using -m

Here's two with volts and frequency, or would you like to see something else?
Or for some reason I can't drop files in here.  Try:
https://drive.google.com/open?id=1S_7spABVIJSQ1zgiJgRwDWcgYcmnr1rp
app-z120-m_freq.png and app-z120-m_volts.png

Right, that's definitely not what I was hoping for with the [build-version] mod.    I'll think of a better place to put it.

There's no 'Help-->About' window?

@pvtinflex how about appending it to the window title? Or did you want to be able to see when someone was streaming with it?

Wanted it in-stream.  That's fine, I'll just reposition it perhaps to the bottom-right or such. I need to get other things done today before I play with such trivial things though, must prioritise!

OK then.  If you want to work on it this weekend it will have to be Saturday.  I've got another family fun event planned for Sunday.

The good news is I can now compile and test no problem. I got your versioning system to work in Windows build environments. So I can build with #define USE_SERIAL 0 and test GUI whenever since Win is my default OS.
(Can we move conversation to another thread now that the flashing units issue is resolved? :) )


Refactor wrapped neo unit tests to use Test Runner

Summary or solution description
A clear and concise description of what you made in this change.
Tests
Reran the test in test_wrapped_neo.py
Platform:

OS: Windows 10 x64
Python version: Python 3.8

Task linked: CU-864ebctu6 Refactor wrapped neo unit tests to use Test Runner

Coverage: 91.086% (-0.3%) from 91.421% when pulling da38f18254d68c94cf1a4d4c497aff622ccc1bcf on CU-864ebctu6 into 3337c20f683ba22fc47e87e9184c2caa573542a4 on development.


docs: make code block style consistent

Fix code block style inconsistent

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   31.23%   31.23%
=======================================
  Files           6        6
  Lines         429      429
  Branches       73       73
=======================================
  Hits          134      134
  Misses        284      284
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff5f92...d3f5787. Read the comment docs.


Reconfigure/Optimize Metadata Scheme

Right now our metadata persistence scheme can make programs incredibly slow. This happens most when we are writing to a file, as each increase in file length creates a need to update the metadata (in case of a crash). The current way we're doing it more or less is the same as it was in Repy SafePOSIX.
I'm opening up this issue to start discussion on how to overhaul this. Some questions:

Can we speedup the actual persistence method from our current one?
Possibly by splitting up metadata and only updating per file?
Do we have to update metadata on every write? Is there another scheme where we can handle crashes w/o doing this?
Do we have to handle crash inconsistencies at all?

Requesting feedback with any additional questions or answers.

Question 4 is really the most important one.  I'll assume for a moment we want to have this happen.
If so, then likely the best thing to do would be to use a log structured filesystem (LFS) approach to writing metadata.  This means we would append changes to the metadata to a log where we only write to blocks at the end.  (You can read a lot of papers on this if you aren't familiar.)
This should have very fast write access, but will be slower at startup.  However, we are likely doing startup asynchronously, so that cost should not really matter.
As for Question 4, we should discuss in a meeting, but my thinking is that yes we would need this for a system people would use in production.

Thanks for the suggestion Justin. I think that may work well.
We'll talk about this tonight so that we hopefully have a plan that I can implement over the next few days.
I started to put this document together to layout ideas.
Metadata RFC

I have an implementation working for this that reduces the overhead on a 1GB dd from > 1000x to 5x.
I'm currently close to switching that version from json to bincode which will hopefully reduce that further.

Switching to cbor has decreased that overhead from 5x to 1.2x. Almost there!
Going to profile a little to see if I can squeeze more out of this.

I got it working with mmap but it actually increased the overhead. It looks like its because I have to call truncate over and over to make sure the log isnt filled with junk.
I'm currently trying to keep count of the number of bytes written at the beginning of the log so that we don't have to call truncate at all. The FlameGraph suggests if we can do that the performance gains will be pretty substantial.

Got it working!
Here's a flamegraph for serializing with cbor and logging to a mapfile.
The test I've been using is
dd if=testfile.txt of=testfile2.txt bs=1024 where testfile is 1GB and testfile2 is a new file.
Stats:
Native: 3.5 secs
Lind w/ CBOR serialization and logging (no mapfile): 4.2 seconds
Lind w/ CBOR serialization and logging (mapfile): 3 seconds
We're now outpacing native by 15%! Awesome.
I'm going to clean this up for a merge and get data on varying blocksize. I also anticipate more gains here (and with the pipetests) when @TristanB22 finishes the conversion to dashmaps.

Closed with recent PR.


Simple per-tenant logic class instantiation

I'm trying this
public class MyTenantInfo : TenantInfo
{
    readonly ITenantRules _tenantRules;

    public MyTenantInfo()
    {
        if (Id == TenantIds.A) _tenantRules = new ATenantRules();
        if (Id == TenantIds.B) _tenantRules = new BTenantRules();
    }

but at this point in the pipeline Id == null.
What's the correct way of achieving this (loading a class specific to the tenant into the TenantInfo)? - or am I going about this completely wrong!
Thanks

hello,
in the tenant info constructor Id will always be null so what youa re trying to do here won't work. The library was designed to work best with the Options pattern which is not limited to ASP.NET Core but can be used in any .NET application.
The idea is that you write you app logic to take advantage of options, then in Finbuckle you can use Per-tenant options to customize the how the options are presented to your application via dependency injection based on the tenant.
There's a sample in the repo as well which will show how it works. Give it a shot and let me know if you run into any issues.


Cannot use function invocation with require-meta-docs-url

The rule require-meta-docs-url cannot be used with a function invocation as done here - mysticatea/eslint-plugin-node:lib/rules/exports-style.js@bbf4b60#L302:
`meta.docs.url` property must be a string. (eslint-plugin/require-meta-docs-url)

Would it be possible to fix this issue?

I don't think it's possible to fix this because there is no way to tell what your getDocsUrl function does. That said, if you're already using a helper function to get the docs URL, it might be better to just disable the rule.

Alright, thanks!


chore: bump kcl lib to 0.10.0-rc.1

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

chore: bump kcl lib to 0.10.0-rc.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 32.916%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
5814

Relevant Lines:
17663

💛  - Coveralls


Error

Xcode Version 12.0 (12A7209)

@L1cardo Compiles without errors for me on Xcode 12.0.1, could you please give it a try?

I am closing this one, since there's been an Xcode update since this issue was opened, @L1cardo please open another one if you are still having problems

I am closing this one, since there's been an Xcode update since this issue was opened, @L1cardo please open another one if you are still having problems


Awesome! I've got questions!

This looks really neat. Here's a few questions I have though:

do you have timing information for identical rebuilds?

first run: (everything needs to be built) cabal vs. ghc-nix. I guess you could force ghc-nix to rebuild everything by giving the hs-builder an argument and embed that into the derivation, e.g. a splace or some # comment, to prevent pre-existing cache-hits.

second run: (evertying is already built) cabal vs. ghc-nix
we essentially generate a nix expression for each haskell file, this seems pretty similar to snack, except that we don't try to do it all in nix. Does the explosion of nix-expressions cause issues?
any reason this would not work with Setup.hs?
Finally, ghc-nix calles out to nix a lot, unless I missread the source, so this won't work inside a nix-build unless we have recursive nix?

Thanks! Amazing work!

Do you have timing information for identical rebuilds?

How's this?

Build
Time

fused-effects-<IP_ADDRESS> (after nix-collect-garbage)
23s

fused-effects-<IP_ADDRESS> (after cabal clean, no ghc-nix)
10.96s

fused-effects-<IP_ADDRESS> (ghc-nix with 100% cache hits)
15s

I'm going to do some quick work on profiling to get better timings for how long it takes to call nix-instantiate, nix-build and nix make-content-addressable. I wouldn't say any of these timings are too interesting right now, I basically vomited out the simplest thing that could possibly work!

we essentially generate a nix expression for each haskell file, this seems pretty similar to snack, except that we don't try to do it all in nix.

Yes, it's similar, but the point of this to drive the build in ghc-nix and use nix make-content-addressable to get early cut off. Snack cannot do this, so that's what is new here.

Does the explosion of nix-expressions cause issues?

I dunno :smile: I don't have a good answer for that.

any reason this would not work with Setup.hs?

It does, doesn't it? cabal build is the same thing, isn't it? I would imagine ./Setup -w ghc-nix should work, assuming ./Setup gives you a -w option.

Finally, ghc-nix calles out to nix a lot, unless I missread the source, so this won't work inside a nix-build unless we have recursive nix?

Yes, this is exactly the idea. The end goal is to have this as something you can drop in to haskellPackages (or haskell.nix) to do all Haskell builds. At that point, you need recursive Nix.
Let me know if that helps, and if you have any other questions!

Am I reading those timing information right? ghc-nix currently takes 100% (uncached) and 50% (cached) more time thanghc --make?
I'd eventually like to try this out with haskell.nix once we have recursive nix proper in nix. Especially if we can somehow get better performance.

Looks like it, yep. But I'm not too bothered by the numbers yet. I'm sure it will get faster than this! For one, I'm not even certain if my whole 'fork a GHC for each file is necessary'. Maybe we can act more like GHC --make with just one process

I'm absolutely looking forward to it!

Looks like it, yep. But I'm not too bothered by the numbers yet. I'm sure it will get faster than this! For one, I'm not even certain if my whole 'fork a GHC for each file is necessary'. Maybe we can act more like GHC --make with just one process

Would this require some modifications to GHC itself to have it call nix-build internally?

That's certainly one option, but unlikely to happen. I think I was more thinking about having ghc-nix be smarter, but ultimately I can't really remember what I had in mind.

I've done some work improving performance. Here's the updated times:

Build
Time

fused-effects-<IP_ADDRESS> (after nix-collect-garbage)
10.066s

fused-effects-<IP_ADDRESS> (after cabal clean, no ghc-nix)
10.230s

fused-effects-<IP_ADDRESS> (ghc-nix with 100% cache hits)
2.244s

I'm using:
nix develop github:matthewbauer/fused-effects/add-flake -c hyperfine -L compiler ghc-nix -w 1 -p "./nix-clean.sh && cabal clean && cabal configure -w {compiler} -j" "cabal build -w {compiler}"

to time 1 and
nix develop github:matthewbauer/fused-effects/add-flake -c hyperfine -L compiler ghc,ghc-nix -w 1 -p "cabal clean && cabal configure -w {compiler} -j" "cabal build -w {compiler}"

to time 2 & 3.
out of this branch: https://github.com/matthewbauer/fused-effects/tree/add-flake
I'm not sure why ghc-nix is slightly faster than cabal without cache... Might be that in nix max-jobs = 10 for me and in ghc jobs = $ncpus. I'm not sure how ncpus is calculated.


roi_head question

Hi, thank you very much for your great work.
I have a question that the htc_cbv2_swin_base_patch4_window7_mstrain_400-1400_adamw_20e.py is inherited from htc_without_semantic_swin_fpn.py that illiterately does not use semantic.  If I command out the roi_head to remove the semantic_roi_extractor and semantic_head, does it affect the final accuracy.
My datasets have mask annotations info but I didn't convert them to .pngs, are they necessary?

Hi,
Without mask annotation, the performance for object detection may drop a bit.
You might need to convert mask annotation into .json format to follow the COCO style.

My annotation is the coco style. When I start to train, it still required png files, maybe the bug #4 is not fixed well.

If you wanna train without semantic gt, you may try this:
train_pipeline = [
    dict(type='LoadImageFromFile'),
    dict(type='LoadAnnotations', with_bbox=True, with_mask=True),
    dict(type='RandomFlip', flip_ratio=0.5),
    dict(
        type='Resize',
        img_scale=[(1600, 400), (1600, 1400)],
        multiscale_mode='range',
        keep_ratio=True),
    dict(type='Normalize', **img_norm_cfg),
    dict(type='Pad', size_divisor=32),
    dict(type='DefaultFormatBundle'),
    dict(type='Collect', keys=['img', 'gt_bboxes', 'gt_labels', 'gt_masks']),
]

I want train without semantic gt, but  do not drop mAP, can you help me  thks? @tingtingliangvs @chuxiaojie


Document limitation on setting timeout for individual RPC calls

You can set a timeout for your calls to an EVM node, but it can't be longer than the default timeout for the node.
Need to add info on setting the default timeout for the node.

Is it possible to have the code block change color with the theme? Its only white for me

Is it possible to have the code block change color with the theme? Its only white for me

I added a fix for that in this PR: https://github.com/etherlinkcom/docs/pull/102#issuecomment-2228518783

This is based on my incorrect assumptions -- closing.


changes to support SCIP 4.0

update SCIPtrySolFree to new interface

cc @fserra

should fix #29

Maybe mention the SCIP version requirements in the README?

Sure, this is WIP


HELLP!!!!  BETA VERSION  HAS EXPIRED 2023-10-10 Get a new copy before

!!!!!  BETA VERSION  WILL EXPIRE 2023-10-10 Get a new copy before!!!!!!!!!!!!!!!!!!!!!!

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!  EXPIRED 2023-10-10 - Get a recent build from Github!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

we now using the software sicelore-2.1. but it seems that it has expired at 2023-10-10. So how can i solve it? where do i download the latest version ? thx!! can i continue using this version?

I met the same problem


timeouts are needed for possible hangs

There are some tasks that will hit parts of Ceph that will wait for ever:
TASK [ceph-mon : collect admin and bootstrap keys] *****************************
task path: /home/jenkins-build/build/workspace/ceph-ansible-prs-ansible2.2-centos7_cluster/roles/ceph-mon/tasks/start_monitor.yml:64

This is stuck because it hits an issue where the bootstrapping process will try forever until it can get the keys.
A fix is now in the newest Jewel but ceph-ansible needs to support everything that doesn't have this changeset: https://github.com/ceph/ceph/pull/11749
See issue #760
There are numerous reasons to why it might wait/loop forever, so the right fix here is to properly timeout on tasks that request these keys with ceph-create-keys

As far as I remember this was a safety measure in some old releases. I'm not sure if we still need this as ceph-create-keys should get fired when the monitor process starts.  I remember having issues on centos 7.0 and 7.1 not triggering ceph-create-keys.
It's also a safe guard in case the mon process doesn't start properly. However we have this task right after "wait for client.admin key exists" that would fail after 300 seconds.
I just tried to remove the "collect admin and bootstrap keys" task and it seems to be working perfectly on 3 mons. I suspect we can remove this task.

Hi there, I know this issue is quite old, but I'm having exactly this problem again on ceph-ansible stable-3.1 deploying the monitor on an ubuntu 16.04.
root@mon1:~# ceph-create-keys --cluster ceph -i mon1 -t 30
INFO:ceph-create-keys:Talking to monitor...
Cluster connection interrupted or timed out
Cluster connection interrupted or timed out
INFO:ceph-create-keys:Cannot get or create admin key, permission denied

@andrelohmann please look at your monitor logs to see what's going on.


Upgrade to Nuxt 2.14

Upgrade dependencies
Remove mode: "universal" from config
Add target: "static" to config
Remove static and crawler modules from config

@samlfair Tested and looks good you'll just have to remove this folder and the files it contains since we don't use them anymore:
https://github.com/samlfair/nuxtjs-blog/tree/nuxt214/modules
Also edit the production build command in the readme:
https://github.com/samlfair/nuxtjs-blog/tree/nuxt214
Also, because the latest nuxt doesn't use the vue runtime compiler you'll have to add the html serializer used here:
https://github.com/prismicio/sm-documentation/blob/master/app/prismic/html-serializer.js
Then add this code to plugins/prismicLinks.js
export default async ({ redirect }) => {
    window.addEventListener(
        'click',
        (event) => {
            // If the clicked element doesn't have the right selector, bail
            if (!event.target.matches('a[data-nuxt-link]')) return

            // Don't follow the link
            event.preventDefault()

            // Push link destination to router
            redirect(event.target.pathname)
        },
        false
    )
}

and add the plugin to your nuxt.config.js with ssr set to false:
{
    // ...other configuration
    plugins: [
        // ...other plugins
        { src: '~/plugins/prismicLinks', ssr: false }
    ]
}

@phillysnow All done

[x] Remove modules folder
[x] Edit build command in readme
[x] Replace html serializer
[x]  Add plugins/prismicLinks.js
[x] Add prismicLinks to Nuxt config plugins

@samlfair Good job, tested and merged.


Add raiseRecoverable hook

This allows consumers to override raiseRecoverable() errors if they want.
To start, I only added this in places where value validation failed.
Fixes #370

This looks good. Merged as 4593dc8


Define getClusterDetails() (ACK) method at one place

Is your feature request related to a problem? Please describe.
The getClusterDetails() method is implemented in two different packages with very similar functionality:

https://github.com/banzaicloud/pipeline/blob/master/pkg/cluster/acsk/action/action_utils.go#L255
https://github.com/banzaicloud/pipeline/blob/master/cluster/acsk.go#L422

Describe the solution you'd like to see
There should be only one implementation which is called uniformly everywhere from the codebase. It is not clear which to keep though, need to investigate.

My guess is it's duplicated because the original method was unexported.

ACSK needs a complete rewrite


'Future<bool?>' is not a subtype of type 'FutureOr' in type cast

Describe the bug
When I try to click phone field I get this error after writing anything  -> [ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: type 'Future<bool?>' is not a subtype of type 'FutureOr' in type cast
E/flutter ( 7313): #2      _InputWidgetState.onChanged package:intl_phone_number_input/…/widgets/input_widget.dart:312 E/flutter ( 7313): #3      new TextFormField.<anonymous closure>.onChangedHandler package:flutter/…/material/text_form_field.dart:246 E/flutter ( 7313): #4      EditableTextState._formatAndSetValue package:flutter/…/widgets/editable_text.dart:2276 E/flutter ( 7313): #5      EditableTextState.updateEditingValue package:flutter/…/widgets/editable_text.dart:1731 E/flutter ( 7313): #6      TextInput._handleTextInputInvocation package:flutter/…/services/text_input.dart:1279 E/flutter ( 7313): #7      MethodChannel._handleAsMethodCall package:flutter/…/services/platform_channel.dart:435 E/flutter ( 7313): #8      MethodChannel.setMethodCallHandler.<anonymous closure> package:flutter/…/services/platform_channel.dart:382 E/flutter ( 7313): #9      _DefaultBinaryMessenger.handlePlatformMessage package:flutter/…/services/binding.dart:284 E/flutter ( 7313): #10     _invoke3.<anonymous closure> (dart:ui/hooks.dart:221:15)
Package version
0.7.0
** Targeted platforms (please complete the following information):**

Android

Same error v0.7.0

Hi, I just pushed a fix. Could you help me check if it resolves this issue? Thanks.
  intl_phone_number_input:
    git:
      url:https://github.com/natintosh/intl_phone_number_input
      ref: b1dd083e58987e61a74242313fe587ffc20be7cc

I'm seeing the same error. And with your fix, I don't see the error in the console anymore, but I still get a PlatformException on NOT_A_NUMBER that stops my debugger.

This fix seems to work