[CP staging] Followup/23961 edit request

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/23961
$ https://github.com/Expensify/App/issues/25386
$ https://github.com/Expensify/App/issues/25388
$ https://github.com/Expensify/App/issues/25390
PROPOSAL: #23961
Tests

Go to the request details
Edit the request (click the first item with the amount)
Click the currency button - verify that you're able to change the currency

[x] Verify that no errors appear in the JS console

Offline tests

n/a
QA Steps

Go to the request details
Edit the request (click the first item with the amount)
Click the currency button - verify that you're able to change the currency

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/28020445/c02d8f29-3b09-43ae-a23e-21154b6714b0

Mobile Web - Chrome

https://github.com/Expensify/App/assets/28020445/31648566-45c6-46ee-8f97-a6236441b00c

Mobile Web - Safari

https://github.com/Expensify/App/assets/28020445/01b9abd6-2829-4f42-97ab-128e77bf6c2c

Desktop

https://github.com/Expensify/App/assets/28020445/36d27e2c-b782-4d7b-a3a4-48da37f43107

iOS

https://github.com/Expensify/App/assets/28020445/06cf9e07-5c47-42b5-ac6b-feca53033f4c

Android

https://github.com/Expensify/App/assets/28020445/eb007631-7887-4a65-b49f-271d7a92d84f

@mountiny @pecanoro all comments adressed

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Could you please merge with main? After merging locally I am getting this NaN in the message.
https://github.com/Expensify/App/assets/36083550/5c0ee9a5-80ac-498f-a5f4-dcc4c5e6e05b
Also there might be some other issues now as we are using the transactions data

@mountiny the problem still persists after merging with main - we're still using originalMessage in getModifiedExpenseMessage (it's still on main). I don't know if this function should be removed or some merge conflicts were resolved inappropriately, but I think it should be handled in another PR. WDYT?

@mountiny EDIT: I've found a bug - the function for converting amount was changed here, but as the new one doesn't accept currency it returns a NaN. I can add this fix to this PR

@mountiny
https://github.com/Expensify/App/assets/28020445/ccc04c7c-24ad-478d-8bc9-ff0a3c1fcd63
after this fix everything is being updated correctly

@mountiny the problem still persists after merging with main - we're still using originalMessage in getModifiedExpenseMessage (it's still on main). I don't know if this function should be removed or some merge conflicts were resolved inappropriately, but I think it should be handled in another PR. WDYT?

We should be using the originalMessage from the MODIFIEDEXPENSE action, we are only using the transaction data in case of the IOU actions

Michal confirmed the ios and android work well so I am going to ship this

iOS and Andoird work well 👍

iOS

https://github.com/Expensify/App/assets/39538890/2fb29885-9c3e-4153-aeae-f4721cd6fe00

Android

https://github.com/Expensify/App/assets/39538890/a1344b3b-5010-4bf5-acea-07427cd033f6

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.55-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


javascript error when applying both sortList and headers options

When you apply both the sortList and headers options, you get an error right after the page loads.
When you add the sortList option, if I remember correctly, the form sorts itself once the page is loaded. When you add the headers option, you decide which of the colums are sortable.
When you add them both, and set it up so that the list is sorted on some of the unsortable columns specified in headers, you get an Cannot read property 'addClass' of undefined  error. This error stems from a rather weird implementation in the setHeadersCss method.
Hope you can fix this somehow :)

Did you ever find a resolution to this issue? I'm having the same error report. I am setting both headers and sortList

This may not be a bug per-se. In my case I had headers defined for columns 0 and 1. I was sorting on columns 0 and 1 also. Then when I deployed to test (instead of dev) the table that was being sorted had an additional column added (because of some other setting) which did not have a header defined. This led to tablesorter not having a sorter and failing.


Infer error cannot find pom.xml

Hello! I am trying to run infer on a maven project but I am getting an error where it cannot find a pom.xml file, when it exists and is shown in the gist. Any ideas? The error is (full output shown in the gist):
Uncaught error: (Sys_error
   "/data/\
  \n   jannovar-cli\
  \n  /pom.xml: No such file or directory")

[x] v0.14.0
[x] Debian 9
[x] infer --keep-going -- mvn clean test-compile compile -Dmaven.test.skip.exec
[x] https://gist.github.com/dtomassi/47df88ed33fb06cada04443a90bb85fa

Same same error occurs with v0.17.0.
Here is the gist for v0.17.0: https://gist.github.com/dtomassi/33a98ec4028d91915f95e11307a04bb3

@dtomassi I realized I should probably have given you the link to the results instead of just saying how many results.   Use these or not as you desire - they were generated by a github app that wraps Infer and other analyzers and runs them on each pull request.

@TomMD I appreciate it! :)


Document SBOM use cases

TODO: What are the use cases?
Document needs to fleshed out and structured.
SBOM Use Cases for Security
Kathy Goeschel will take point
Bunny Hernandez
Cameron Banowsky
David Wheeler willing to take a pass at adding in his thoughts.
Ran Dall

We need to better define the scope and definitions for these use cases

This list of SBOM use cases relative to the data needed under CDX was invaluable to me in assessing completeness of SBOMs during SDLC...
https://cyclonedx.org/use-cases/

This from NTIA is a good SBOM use cases reference which I've found useful: https://www.ntia.gov/files/ntia/publications/ntia_sbom_use_cases_roles_benefits-nov2019.pdf

I wrote a blog post which identified 4 use cases for SBOMs all related to managing risk:

SBOMs should form part of your vulnerability management process by using them to scan for vulnerabilities when acquiring software from the supply chain and also understanding your vulnerability posture when releasing software to your users. As vulnerabilities are being discovered continuously, vulnerability scanning of released software should be proactively performed so that your users can be informed of any new vulnerabilities as they are discovered.
SBOMs can also be used as part of an integrity checking process for components received from the supply chain as the metadata associated with each component typically includes checksums which are used primarily to protect against accidental corruption. These checksums can be used to validate that the components ‘as received’ are ‘as produced’ by the supplier. Cryptographically strong checksum algorithms may be used to detect deliberate corruption or to confirm the desired version of a component, if multiple versions are available.
The continued use of obsolete or no longer supported software is a key risk to any solution, as this increases the potential that vulnerabilities could be exploited. By monitoring the supported versions of components against an SBOM, identification of software which may need additional measures in order to limit the likelihood of compromise can be performed.
And finally using SBOMs to ensure that the components are being used in accordance with their licence is still a very important use case to consider as part of the overall risk management associated with the supply chain.


java.io.FileNotFoundException: Cidaas.xml

Hey I am getting an error Property file is missing. when I try to make a call. I tracked the issue and it boils down to  java.io.FileNotFoundException: Cidaas.xml This occurs with the new 2.0.9 and 2.1.0 SNAPSHOT versions. The old 2.0.2 version does not have this issue when the file is named "Cidaas.xml".
I have tracked down the error to here:
https://github.com/Cidaas/cidaas-sdk-android/blob/e0695728b94a74bdfa562134701cc429931f0782/cidaas/src/main/java/de/cidaas/sdk/android/helper/general/FileHelper.java#L56
In the documentation it says the file name should be "cidaas.xml", but the FileHelper tries to read a "Cidaas.xml". I have tried with both "cidaas.xml" AND "Cidaas.xml" but it still crashes.

Hello,
can you try this with the latest master-SNAPSHOT version?
dependencies {
	        implementation 'com.github.Cidaas:cidaas-sdk-android:master-SNAPSHOT'
	}

Hello,
can you try this with the latest master-SNAPSHOT version?
dependencies {
	        implementation 'com.github.Cidaas:cidaas-sdk-android:master-SNAPSHOT'
	}

Hey it seems to be working with master-SNAPSHOT. I tried both com.github.Cidaas:cidaas-v2-sdk-android:master-SNAPSHOT and com.github.Cidaas:cidaas-sdk-android:master-SNAPSHOT and they both work.
I should be using the v2 one right? 🤔

No, please use the one without the -v2.
In the current refactoring process, we have removed the version number from the name.

We have released the version 3.0.0: 'com.github.Cidaas:cidaas-android-sdk:3.0.0' including this fix.
https://jitpack.io/#Cidaas/cidaas-android-sdk/3.0.0
I am going to close this issue as the problem is fixed now. If it reoccurs, or any other problems occur, feel free to reopen this or create a new issue.


v0.3 video previews hanging up the UI

Hello,
I've upgraded from v0.2 to v0.3
Preview videos now take like 1 minute to show when switching games, during this time the UI is hung up / sloppy.
I've tried with:

32 GB SD Card
128 GB SD Card
FAT 32 roms parition
exFat roms partition

And both on an upgraded installation and also a clean installation formating the SD card, result is always slow
I re-installed v0.2 and is lightning fast.
I guess this only happens when the library is big.
Can I provide some kind of log or can I look somewhere to give you more info on the issue? if so, let me know. I have both versions in 2 different SD cards, same roms library etc.
Thanks!

Thanks for the report, I typically just test batocera default content, and those don't contain more than 1-2 videos per folder.
This update contained about 2500 changes on the batocera side of things so I'll have to check what's going on.

@lucke I've just tried with a folder full of previews and I don't see any lag. One important question, did you update to v0.3 with the boot.tar.xz or installed it as a new sdcard from the img file?

Hi, I had the same problem but after doing a clean install of the new image it hasn't happened again (for now).

@acmeplus I tried both:

First by using the boot.tar.xz to update from v0.2 to v0.3. When I faced the issue I thought "let's do a clean install"
I did a clean install, formated SHARE to Fat32, copied my usual content and faced the issue.
Then i formated to exFAT, copied my usual content and faced the issue.

If this is not happening to others, there might be something wrong with my conent, although it's working fine with v0.2
I'll try next time to just add roms and scrape them instead of importing pre-scraped content structure which probably contains some custom paths to the videos etc (my guess is that the issue is with custom paths to videos). Thanks!!

Its reproducible either in update or clean install

I test， update to v0.3 with the boot.tar.xz or installed it as a new sdcard from the img file，both  video previews hanging up the UI

I've been able to reproduce some of the behavior with a video backgrounds enabled for the systems view. It's not clear at this point if this is an issue with the latest batocera ES or the specific implementation for this board.
As a workaround, disable video backgrounds, or revert back to v0.2

I get this hang issue , I think its reproducible withthe stock 0.3 install, selecting and unselecting the preinstalled space-twins gba game

no response here since ages.
donated 3$ only to write a message,
didnt even get an answer.


switch to 'shadow-dom' and test

Since Polymer 1.x use Shady DOM and Polymer 2.0 will be full Shadow DOM, lets change the global settings and do some tests on the Pattern Library Components to see how they behave.
/* this script must run before Polymer is imported */
window.Polymer = {
  dom: 'shadow',
};

Reference https://www.polymer-project.org/1.0/docs/devguide/settings

the main issue regards CSS management...


[BUG] snowpack 3.3.x introduces cyclic dependencies between imports

Bug Report Quick Checklist

[x] I am on the latest version of Snowpack & all plugins.
[x] I use package manager npm (also checked yarn)
[x] I run Snowpack on OS Windows (also checked Linux)
[x] I run Snowpack on Node.js v12+

Describe the bug
When using the dev server from Snowpack 3.3.4 I see an "Uncaught SyntaxError: Detected cycle while resolving name 'LoginOverlayElement' in<EMAIL_ADDRESS>error instead of my app, after adding the two imports below. With Snowpack 3.2.2 and earlier (tested down to 3.0.13) everything works just fine.
import '@vaadin/vaadin-login/vaadin-login-overlay';
import { LoginI18n } from '@vaadin/vaadin-login';

To Reproduce

npx create-snowpack-app snowpack-app --template @snowpack/app-template-lit-element-typescript
cd snowpack-app
npm i<EMAIL_ADDRESS>--save-exact
add 2 additional imports into src/index.tsimport '@vaadin/vaadin-login/vaadin-login-overlay';
import { LoginI18n } from '@vaadin/vaadin-login';

start the dev server with npm start
see the error in the browser

stop the dev server and downgrade snowpack to 3.2.2 with npm i<EMAIL_ADDRESS>--save-exact
start the dev server again with npm start
see no error

Expected behavior
I expect that snowpack does not introduce cyclic imports when the original source code does not have them.
Anything else?
I've also created 2 online sandboxes to illustrate the issue:

working, with snowpack 3.2.2: https://codesandbox.io/s/snowpack-322-gmgbn?file=/src/my-element.ts:63-164
failing, with snowpack 3.3.4: https://codesandbox.io/s/snowpack-334-1kxo9?file=/src/my-element.ts:63-164

When looking at the source code that snowpack produces and comparing it to the original, I see that snowpack incorrectly swallows a part of the path of an imported file and that results in creating an import from the file itself.
I.e. export * from './src/vaadin-login-overlay.js'; in the source becomes export { LoginOverlayElement } from<EMAIL_ADDRESS>in the snowpack output, and that clearly misses the src segment of the URL.

I get the exact same issue but importing, in my case, from Font Awesome package, @fortawesome/free-solid-svg-icons, or any of the free-<variant>-svg-icons packages.

I forgot to mention above, but in my case, the issue first appeared in 3.1.x, but no present in 3.0.0.


Staging > Master (Maintenance Monday)

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


docs: Added a 'how it all works' page

- What I did
docs: Added a 'how it all works' page. It's the first iteration, we will improve on this over time.
Note: one of the links ("how notifications work") will not work until https://github.com/atsign-foundation/at_protocol/pull/98 is merged to trunk
- How to verify it
Please review for typos etc

This repo probably needs a docs directory
And a lot of the existing docs (that aren't Dart implementation specific) can go in there.


Moving auto from Buildbot to Travis+Appveyor

Buildbot will remain for nightlies at the moment, but we can get the rest off of it.

[X] add GNU triples to https://github.com/rust-lang/cargo/blob/master/appveyor.yml  -- https://github.com/rust-lang/cargo/pull/3187
[ ] Fill out Travis matrix to include all of 64 & 32-bit Mac & Linux https://github.com/rust-lang/cargo/pull/3190/files
[ ] Port cross matrix from https://github.com/rust-lang/rust-buildbot/blob/master/master/master.cfg#L223 to Travis matrix also https://github.com/rust-lang/cargo/pull/3190/files
[ ] Make sure Travis & Appveyor are working correctly
[ ] Switch Homu to using Travis+Appveyor insead of Buildbot
[ ] Verify that's all working
[ ] Remove auto stuff from Buildbot configs

Travis is landed and publishing builds now, so closing.


make up `token-manager' pallet

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Motivation
Relaychain needs a mapping link the AssetId between relay chain and each parachain.
Request
features of token-managerpallet

set SystemTokenTable
insert the mapping link between chains to  SystemTokenTable

Solution
No response
Are you willing to help with this request?
Yes!

author = "blockchain labs" 인 pallet 은
prefix infra-* 통일하는것이 좋을거같습니다. 개인적으로는 infra-system-token-pallet

closed as it is merged


[DEV] Add julia gd solver for logreg l2

I added gradient descent for logreg_l2 problem, see files:

benchmarks/logreg_l2/solvers/julia_gd.jl
benchmarks/logreg_l2/solvers/julia_gd.py

And I did check that the loss and the gradient were correctly computed by running
test_julia/test_logreg_l2_grad.jl
PS: I will need to reuse functions in benchmarks/logreg_l2/solvers/logistic.jl for all the other stochastic methods (SGD, SAG, SAGA, etc), yet I was unable to import this file julia_gd.jl using canonical
include("./benchmarks/logreg_l2/solvers/logistic.jl")

Anyone knows how to do ?

I incorporated the required changes (comments on the sigmoid and its link to the loss derivative, deletion of useless files). I think the julia_gd.py file is also needed.

I've seen several changes of the structure of the repo. Should I git merge master into this DEV branch ?

no you should open a PR on this repo instead
https://github.com/benchopt/benchmark_logreg_l2

Hello @ngazagna
Sorry for the complex changes, we decided to move all benchmark in separated repo to avoid maintenance burden.
As @agramfort  said, you should open a new PR on benchopt/benchmark_logreg_l2 instead.
For the error, this should be fixed on master so if you open this new PR (which simply corresponds to cloning the repo and copying your solver in solvers), this should be fixed.
Thanks a lot

Thanks for the answer. Perfect, I'll do that !


Token Group Interface

The following is a spec for a "Token Group Interface" - which serves to outline
an interface for grouping tokens together.
This interface is designed to be generic over whatever type of asset
(represented by tokens) you might be implementing the interface for.
Two common examples are demonstrated in this PR/spec:

Token Collections: Collections of tokens where one token identifies the
collection (or group), and all other tokens are simply "members" of the
collection.
Token Editions: Token "editions" where one token serves as the original,
and all others are "reprints"

Note: These are implementations of the interface specific only to this
example, and interfaces that follow the guise of "collections" or "editions"
can be implemented in a variety of ways.

Reviewing this Spec

Commit 1: Token Group Interface
Commit 2: Token Group Example
Commit 3: Token Group Example Tests

Token Group Interface
The interface itself is structured similar to the
Token Metadata Interface
or the
Transfer Hook Interface,
however this particular interface introduced the idea of a generic interface.
This basically means that specified values can be injected into things like
instructions and state, all while still preserving a compliant implementation.
Key points:

The instructions require a generic argument describing the asset to which
the group is tied to. This generic argument is keyed to the group, even
when working with a member.
Some instruction data structs can be extended with an optional meta field
that can take metadata about the group or member.
Some instructions can be expanded with extra required accounts.
The interface supports a slightly more robust version of managing extra
required accounts (ExtraAccountMetaList) via TLV data and a validation
account - adapted from Transfer Hook.
The data for a Group or a Member is stored in TLV data, so it can live
within its own account, or be stored alongside other TLV data in an account
such as a Token2022 mint!

Token Group Example
This example demonstrates how an on-chain program might serve as both a
token collection and edition standard.
Key points:

When working with a Collection, the example provides a Collection as the
generic argument for the interface.

It leverages the optional additional group and member metadata for
collections and collection members.
Creation of both collections and collection members is straightforward and,
in this example, done in individual separate accounts.

When working with an Edition, the example provides an Edition as the
generic argument for the interface.

It leverages the optional additional group and member metadata for
collections and collection members.
It also leverages extra required accounts to perform some additional
operations when working with a "reprint" (member).
Creation of a "reprint" (member) demonstrates how this example program can
leverage extra account metas and some other arbitrary program which
implements the SPL Token Metadata interface.

The example program itself shows how an on-chain program might implement this
interface multiple times over, demonstrating through a modularized processor
and separated state.

A Note on Extra Account Metas
In this example, I'm not actually storing the extra required account
configurations in a validation account.
Should this specification gain traction as something we want to pursue, I
propose we actually pop the extra account configuration instructions, state,
and helpers out of the transfer hook interface and into a more generalized
library for other interfaces to use.
In this example - in the tests - I'm just providing the extra accounts
manually.

Closing in favor of #5512 !


Feature/contagion areas

Please read and mark the following check list before creating a pull request (check one with "x"):

[ ] I read and followed the CONTRIBUTING.md guide.
[ ] I read and followed the New Feature Checklist guide.

Short description of what this resolves:

fix conflicts


Can't input letters into gradient boxes in 1.18.2 on Fabric

For example, if I try to write 5500FF, which is a valid hex code, it will only let me type 5500. I have only tried this with 1.18.2 and Fabric so far, but it may be happening for other versions and modloaders.

The 1.18.2 version doesn't use hex colors, but integer colors instead.
This was changed in the 1.19 version, but I don't plan on backporting anything to outdated versions of Minecraft.


Note WSL doesn't support USB cameras

It appears WSL does not provide access to USB camera devices.
Using a USB camera for input is a common use case.  All mediapipe platforms other than WSL support it.  It is non-obvious that WSL doesn't.  The issue has come up in  #149 and #261, but these are now closed and low visibility.
Recommendation: Add a cautionary note to https://github.com/google/mediapipe/blob/master/mediapipe/docs/install.md#installing-on-windows-subsystem-for-linux-wsl , like "Note: WSL has historically not provided access to USB cameras.  Mediapipe can use a video file as input."

Thanks for the suggestion! We will put the cautionary note into install.md soon.

The note for WSL is added. See https://github.com/google/mediapipe/commit/ae6be10afe59a6a99d8a68007784706ac98720dd#diff-956151db6fecd29fe7cba43281162199R358


Largest and 2nd Largest value of a Matrix

Hi @SoumyadeepMukherjee I can try this, pls assign it to me :)

Please assign me this issue


Could not determine artifacts for org.wysaid:gpuimage-plus:2.6.3: Skipped due to earlier error

Could not resolve all dependencies for configuration ':app:debugRuntimeClasspath'.
Could not determine artifacts for org.wysaid:gpuimage-plus:2.6.3: Skipped due to earlier error

Get, I'll fix it this week.  The jcenter is deprecated, we may need to add a maven repository hosted by github.

Any updates related to this ?

Updated:
repositories {
    maven {
        url 'http://maven.wysaid.org/'
    }
}

//Choose only one of them
dependencies {
    //All arch: armeabi-v7a, arm64-v8a, x86, x86_64 with video module (ffmpeg bundled)
    compile 'org.wysaid:gpuimage-plus:3.0.0'

    //All arch: armeabi-v7a, arm64-v8a, x86, x86_64 without video module (no ffmpeg)
    compile 'org.wysaid:gpuimage-plus:3.0.0-min'
}


udpates to configmap

What this PR does / why we need it: changes to allow additional JanusGraph parameters to be set
Special notes for your reviewer: follows pattern to to allow bring-your-own-configmap

/assign @viglesiasce

/ok-to-test


Which version should I use for a new project?

According to the README.md I should use version 0.8.0.
If I look into the master branch the latest stable release is 1.0.1.
Additional features stated inside the readme (i.e. concurrent task handling) seems to be implemented only in version 1.0.2. There is a pending pull request that aims to merge 1.0.2 version inside the master branch.
Which version of this library should I use in a production app?
Can I use latest commits in develop branch or I need to wait for your pull request to be approved and merged?
Thank for your support.

Hi Simone,
We've recently decided to make some larger changes to the library to make it less prone to breaking as we make changes (while still maintaining a similar level of customizability). Because of that, this library is currently a "Work In Progress". While we make these changes, I'd suggest using another task queue library that will hopefully give you a similar feature set as turnstile until turnstile is more stable.
Below is a list of some other task queue options. If you'd still like to use turnstile after reviewing the list, I'd recommend using the develop branch as a submodule - but as a warning we are likely going to make changes to the API of turnstile.
Other task queue options

    If you don't think you'll benefit from the customizability of this library, there are many other options that are each excellent in their own way (this list is not exhaustive).

        android-priority-jobqueue

                Pros: Most of the features above. Additionally has prioritization of jobs, job delay, load balancing, and grouping

                Cons: Doesn't run in a Service (dies with your application). It's difficult to extend or customize.

        tape

                Pros: Most of the features above. Very easy to implement for simple tasks.

                Cons: No progress broadcasting or awareness of network. It's difficult to extend or customize.

        robospice

                Pros: Good for long running network requests.

                Cons: It's difficult to extend or customize. It also has a limited feature set.

Thanks @kvenn for your help.
I'm evaluating to use yourdevelop branch or switch to android-priority-jobqueue.
I really like the way you are working on turnstile library and your effort in achieving a great level of customizability.
I need to extend your library to support pause and resume at task level.
I'll follow this project to be updated on next progress.
Great job!

Marking as closed 📕


Mailbox unit testing

What ❔
Increased coverage in Mailbox unit tests.
Why ❔
Previously proving mechanism was mocked in the tests, now actual merkle tree is constructed, so is the merkle tree proof.
Checklist
test:

[x] prove message inclusion success/failure
[x] prove log inclusion success/failure
[x] get base cost of transaction
[x] finalize withdrawal success/failure
[x] transaction request (check if all cases are included)

Merged: https://github.com/matter-labs/era-contracts/pull/559


merge package from arlac77/npm-package-template

package.json

chore(package): add publishConfig from template

.travis.yml

chore(travis): remove node versions 10.2.1
chore(travis): add node versions 10.3

:tada: This PR is included in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


listEntities always returns an Int32 type for a value of "1.23456789012346e+24"

Package Name: @azure/data-tables
Package Version: 12.1.1
Operating system: Windows
[x] nodejs

version: 14.16.0

[x] typescript

version: 4.4.2

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
When calling listEntities(), one of the entities in my table contains a value of "1.23456789012346e+24". This is clearly beyond the limits of an Int32 value, yet Int32 is the type that's returned by the SDK. This happens even if the value is explicitly inserted as a Double.
To Reproduce
Steps to reproduce the behavior:

Write the following program:

let client = new TableClient("https://myacct.table.core.windows.net", "mytable", someCred);
const inputEntity = {
    partitionKey: "0",
    rowKey: "0",
    Value: { value: "1.23456789012346e+24", type: "Double" }
};
await client.insertEntity(inputEntity);

let response = client.listEntities();
let next = await response.next();
let entity = next.value;

Expected behavior
I would expect inputEntity to have the same value as entity.
Instead, entity has a value of:
 {
    partitionKey: "0",
    rowKey: "0",
    Value: { value: "1.23456789012346e+24", type: "Int32" }
};

Screenshots
N/A
Additional context
N/A

@craxal  thanks for reporting this issue. I was able to get a local repro. The problem is that the service is not sending enough metadata to tell this is a double and our check is missing checking if the number is a safe integer or not.
I'm preparing a PR for this fix and will send it out soon


Compiling error on MacOS

Hi team,
The following error on MacOS:
The following warnings were emitted during compilation:
warning: curl/lib/connect.c: In function 'singleipconnect':
warning: curl/lib/connect.c:1279:10: warning: implicit declaration of function '__builtin_available'; did you mean '__builtin_scalbl'? [-Wimplicit-function-declaration]
warning:  1279 |       if(__builtin_available(macOS 10.11, iOS 9.0, tvOS 9.0, watchOS 2.0, *)) {
warning:       |          ^~~~~~~~~~~~~~~~~~~
warning:       |          __builtin_scalbl
warning: curl/lib/connect.c:1279:30: error: 'macOS' undeclared (first use in this function)
warning:  1279 |       if(__builtin_available(macOS 10.11, iOS 9.0, tvOS 9.0, watchOS 2.0, *)) {
warning:       |                              ^~~~~
warning: curl/lib/connect.c:1279:30: note: each undeclared identifier is reported only once for each function it appears in
warning: curl/lib/connect.c:1279:35: error: expected ')' before numeric constant
warning:  1279 |       if(__builtin_available(macOS 10.11, iOS 9.0, tvOS 9.0, watchOS 2.0, *)) {
warning:       |                             ~     ^~~~~~
warning:       |                                   )
error: failed to run custom build command for curl-sys v0.4.52+curl-7.81.0
Caused by:
process didn't exit successfully: /Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-9b4192310196e29f/build-script-build (exit status: 1)
--- stdout
cargo:rerun-if-changed=curl
cargo:rustc-link-lib=clang_rt.osx
cargo:rustc-link-search=/opt/homebrew/Cellar/llvm/13.0.1/lib/clang/13.0.1/lib/darwin
cargo:root=/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out
cargo:include=/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/include
cargo:static=1
cargo:rustc-cfg=libcurl_vendored
cargo:rustc-cfg=link_libz
/Library/Developer/CommandLineTools
unable to determine Xcode version, assuming >= 9
TARGET = Some("aarch64-apple-darwin")
OPT_LEVEL = Some("3")
HOST = Some("aarch64-apple-darwin")
CC_aarch64-apple-darwin = None
CC_aarch64_apple_darwin = None
HOST_CC = None
CC = None
CFLAGS_aarch64-apple-darwin = None
CFLAGS_aarch64_apple_darwin = None
HOST_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("false")
CARGO_CFG_TARGET_FEATURE = Some("aes,crc,dit,dotprod,dpb,dpb2,fcma,fhm,flagm,fp,fp16,frintts,jsconv,lor,lse,neon,pan,pauth,pmuv3,ras,rcpc,rcpc2,rdm,sb,sha2,sha3,ssbs,v8.1a,v8.2a,v8.3a,v8.4a,vh")
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/conncache.o" "-c" "curl/lib/conncache.c"
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/asyn-thread.o" "-c" "curl/lib/asyn-thread.c"
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/content_encoding.o" "-c" "curl/lib/content_encoding.c"
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/bufref.o" "-c" "curl/lib/bufref.c"
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/altsvc.o" "-c" "curl/lib/altsvc.c"
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/base64.o" "-c" "curl/lib/base64.c"
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/connect.o" "-c" "curl/lib/connect.c"
cargo:warning=curl/lib/connect.c: In function 'singleipconnect':
cargo:warning=curl/lib/connect.c:1279:10: warning: implicit declaration of function '__builtin_available'; did you mean '__builtin_scalbl'? [-Wimplicit-function-declaration]
cargo:warning= 1279 |       if(__builtin_available(macOS 10.11, iOS 9.0, tvOS 9.0, watchOS 2.0, *)) {
cargo:warning=      |          ^~~~~~~~~~~~~~~~~~~
cargo:warning=      |          __builtin_scalbl
cargo:warning=curl/lib/connect.c:1279:30: error: 'macOS' undeclared (first use in this function)
cargo:warning= 1279 |       if(builtin_available(macOS 10.11, iOS 9.0, tvOS 9.0, watchOS 2.0, )) {
cargo:warning=      |                              ^~~~~
cargo:warning=curl/lib/connect.c:1279:30: note: each undeclared identifier is reported only once for each function it appears in
cargo:warning=curl/lib/connect.c:1279:35: error: expected ')' before numeric constant
cargo:warning= 1279 |       if(__builtin_available(macOS 10.11, iOS 9.0, tvOS 9.0, watchOS 2.0, )) {
cargo:warning=      |                             ~     ^~~~~~
cargo:warning=      |                                   )
exit status: 1
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/cookie.o" "-c" "curl/lib/cookie.c"
exit status: 0
exit status: 0
exit status: 0
exit status: 0
exit status: 0
exit status: 0
exit status: 0
--- stderr
fatal: not a git repository (or any of the parent directories): .git
error occurred: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "curl/lib" "-I" "curl/include" "-I" "/Users/jianshuzhao/Github/mudskipper/target/release/build/libz-sys-4a0742c61ab93e89/out/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS="unknown"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/Users/jianshuzhao/Github/mudskipper/target/release/build/curl-sys-fd2b0ac6e5689972/out/build/curl/lib/connect.o" "-c" "curl/lib/connect.c" with args "cc" did not execute successfully (status code exit status: 1).
warning: build failed, waiting for other jobs to finish...
error: build failed
Any idea
Thanks,
Jianshu

Hi @jianshu93,
Thanks for the bug report.  I think this is related to pulling in of curl, which is an optional dependency of rust-htslib, and building that on some OS X systems.  The current source builds cleanly on our OS X systems — can you tell us what version of OS X you are on, and what version of OS X developer tools you have installed on the machine where you are trying to build this?
Regardless, I've pushed a modified Cargo.toml that removes curl from the set of included features.  Can you try to pull from the repo and build again and let us know if this works for you?
Thanks,
Rob

Hi @jianshu93 — I'll also note you should now be able to install mudskipper directly through cargo, as well as using bioconda.
--Rob

Hi @jianshu93
Did you get a chance to try the latest code on github, or try to install from cargo or bioconda?


Left curly bracket in markdown seems to be unescapable

I am trying to put a left curly bracket { in my markdown docs but it doesn't seem to be possible. A few variations that I've tried all give the 500 error "abc is not defined".
{ abc }

\{ abc }

\{ ref \}

{ abc }

{ abc }

This doesn't error but explicitly outputs the characters "{" instead of showing a curly bracket:
\{ abc }

I tried reproducing the error on the online parser here but it seemed to work fine. Any idea how I would go about troubleshooting this?

Ye there's some issues with braces right now because code blocks are like so {@html ...}. Can I see the code snippet you're trying to insert?

@mihar-22 just following up here. Any suggestions?


Add TIC-80 topic

Thank you for contributing! Please confirm the following:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

TIC-80 is a fantasy console that has a few tagged repos 🕹

Thanks @leereilly!


Preserve user timezone

In https://github.com/gitgitgadget/gitgitgadget/pull/22 and https://github.com/gitgitgadget/gitgitgadget/pull/23, GitGitGadget was changed to use the current time when sending patches, to match git send-email. However, this always sends in UTC.
Would it be possible to change the timezone offset of the outgoing patch emails to match those of the corresponding commits?

I meant to comment here, but my interest in implementing this waned. I dug in and found, as you mentioned, that the flow is rather tightly coupled. I do have an architectural question, though. It seems that GGG has a local Git clone, that it issues Git commands to. Given that, I’m surprised so much of the info is queried from GitHub when it seems it could be fetched there. What’s the logical division of work between the clone and GitHub? (It’s likely I misunderstood something.)
Alternatively, what would you think of an optional Tz Europe/Berlin header that can be supplied when people care? When using a fixed timezone offset, either read from a commit or similar header, it cannot necessarily be used for future dates due to DST.
Closing this is fine with me, though, as it really hinges on me implementing this. If either approach seems feasible, I’ll file it away until the +0000 bothers me again.

It seems that GGG has a local Git clone, that it issues Git commands to. Given that, I’m surprised so much of the info is queried from GitHub when it seems it could be fetched there. What’s the logical division of work between the clone and GitHub? (It’s likely I misunderstood something.)

The plan was always to avoid having a local clone as much as possible. And in some cases, the local clone simply does not have the information we're seeking, such as: what is the GitHub handle of the author? What is the PR branch's name? Which branch does the PR target?

what would you think of an optional Tz Europe/Berlin header that can be supplied when people care?

Sure, that would work.
Having said all that, I find that I have a hard time focusing on the timezone of the patches sent to the mailing list, as long as there are other issues open that seem much more pressing to me. For example, https://github.com/gitgitgadget/gitgitgadget/issues/869 and https://github.com/gitgitgadget/gitgitgadget/issues/1266 strike me much more important than the timezone in the Date header of the sent mails (especially keeping in mind that it is GitGitGadget, not you, who sends these, and as a bot, GitGitGadget is not really affiliated with any specific timezone).

especially keeping in mind that it is GitGitGadget, not you, who sends these, and as a bot, GitGitGadget is not really affiliated with any specific timezone

Right, but then once it’s committed to git.git, the affiliation with GGG disappears, as there is no back-link to the email thread—only the author’s name and date and Junio’s.
I agree this isn’t the most pressing improvement to make to GGG, but I tend to think of data integrity and metadata more than most, so it was what I thought of.

I tend to think of data integrity and metadata more than most

I would think that you'd be most interested in the problem that your original commits in your fork of Git have no connection on record to the commits in git/git. I find this one of the most vexing things about the mailing list-centric workflow: It is really hard to keep track of all the commits/branches/mails that should be connected automatically, but are not.

Well sure, but that's fundamental to the workflow and Git itself. The timezone offsets are a case where this tool is slightly lossy compared to the mail workflow, while staying compatible with the same workflow.
Incidentally, I recently read these interesting papers, that [1] determine the mailing list thread corresponding to a commit and [2] trace the flow of commits through contributers' and maintainers' repos to the blessed repo. They're hard problems, since the Git object format and protocol tracks neither. For anything contributed via GitGitGadget, [2] is easier to trace, because GitHub keeps a log of rebases and GGG shows the status. Additionally, GGG makes it easier to get to the contributor's branch in their fork, because it sends with a mailing list message ID that can be rewritten into a github.com PR URL; this is somewhat a reverse of [1].

Yujuan Jiang, Bram Adams, Foutse Khomh, and Daniel M. Germán. 2014. Tracing Back the History of Commits in Low-tech Reviewing Environments: A case study of the Linux kernel
Daniel M. Germán, Bram Adams, Ahmed E. Hassan. 2015. A Dataset of the Activity of the git Super-repository of Linux in 2012

I recently read these interesting papers, that [1] determine the mailing list thread corresponding to a commit and [2] trace the flow of commits through contributers' and maintainers' repos to the blessed repo. They're hard problems, since the Git object format and protocol tracks neither.

GitGitGadget provides two notes refs that are designed to help with this mapping. I do have a set of shell script functions to use those refs:
# requires GitGitGadget's `commit-to-mail` notes ref
lookup_commit_to_mail () { # <commit>
        # fetch the ref if missing or older than a day
        if ! git rev-parse --verify -q refs/notes/commit-to-mail >/dev/null ||
                test $(($(date +%s)-$(git show -s --format=%ct refs/notes/commit-to-mail))) -gt 86400
        then
                echo "Fetching \`commit-to-mail\` note..." >&2
                git fetch https://github.com/gitgitgadget/git refs/notes/commit-to-mail:refs/notes/commit-to-mail ||
                die "Could not fetch 'refs/notes/commit-to-mail'"
        fi

        mid="$(git notes --ref=commit-to-mail show "$1")"
        echo "$mid"
        return 0
}

commit_to_mail () { # <commit>
        mid=lookup_commit_to_mail $1

        test -n "$mid" || {
                echo "Cannot find Message-ID for $1" >&2
                return 1
        }

        open_url "https://lore.kernel.org/git/$mid"
}

You can do a similar thing to do the lookup in the opposite direction, something like this:
mail_to_commit () { # <Message-ID>
        # fetch the ref if missing or older than a day
        if ! git rev-parse --verify -q refs/notes/mail-to-commit >/dev/null ||
                test $(($(date +%s)-$(git show -s --format=%ct refs/notes/mail-to-commit))) -gt 86400
        then
                echo "Fetching \`mail-to-commit\` note..."


Im getting a Key Error Please Help

----------------EPOCH 1
0% 0/49 [00:00<?, ?it/s['', {'Batch': nan, 'EMA': nan}]]Traceback (most recent call last):
File "run_train.py", line 296, in
trainer.run()
File "run_train.py", line 277, in run
phase_info, engine_opt, save_path, prev_log_dir=prev_save_path
File "run_train.py", line 256, in run_once
main_runner.run(opt["nr_epochs"])
File "/content/drive/My Drive/Projects/hover_net-pytorch/run_utils/engine.py", line 182, in run
step_output = self.run_step(data_batch, step_run_info)
File "/content/drive/My Drive/Projects/hover_net-pytorch/models/hovernet/run_desc.py", line 48, in train_step
true_tp = batch_data["tp_map"]
KeyError: 'tp_map'

@Thejas05  This error is because you are training with model defined for nuclei type classification while your generated data is not.
https://github.com/vqdang/hover_net/blob/b527c004d51c7515f5f08f59c2e0597f7171dd02/config.py#L30
https://github.com/vqdang/hover_net/blob/b527c004d51c7515f5f08f59c2e0597f7171dd02/models/hovernet/opt.py#L34
https://github.com/vqdang/hover_net/blob/b527c004d51c7515f5f08f59c2e0597f7171dd02/models/hovernet/opt.py#L68
nr_type=None means not  nuclei type classification  mode.

@Thejas05  This error is because you are training with model defined for nuclei type classification while your generated data is not.
https://github.com/vqdang/hover_net/blob/b527c004d51c7515f5f08f59c2e0597f7171dd02/config.py#L30
https://github.com/vqdang/hover_net/blob/b527c004d51c7515f5f08f59c2e0597f7171dd02/models/hovernet/opt.py#L34
https://github.com/vqdang/hover_net/blob/b527c004d51c7515f5f08f59c2e0597f7171dd02/models/hovernet/opt.py#L68
nr_type=None means not  nuclei type classification  mode.

Thankyou so much for the reply! i corrected it and its working thank you

Thankyou so much for the reply! i corrected it and its working thank you


Docker registration flow broken

After following the instructions in readme file, the containers starts fine, but in the Step 3 - Add site info step the flow broken, and got a consol error message in the plausible/community-edition:v2.1.4 container:
2024-12-04 07:32:31 ** (exit) an exception was raised:
2024-12-04 07:32:31     ** (ArgumentError) The email address `plausible@localhost` is invalid.
2024-12-04 07:32:31
2024-12-04 07:32:31         (mail 0.3.1) lib/mail/renderers/rfc_2822.ex:134: Mail.Renderers.RFC2822.validate_address/1
2024-12-04 07:32:31         (mail 0.3.1) lib/mail/renderers/rfc_2822.ex:141: Mail.Renderers.RFC2822.render_address/1
2024-12-04 07:32:31         (mail 0.3.1) lib/mail/renderers/rfc_2822.ex:97: Mail.Renderers.RFC2822.render_header/2
2024-12-04 07:32:31         (elixir 1.17.1) lib/enum.ex:1703: Enum."-map/2-lists^map/1-1-"/2
2024-12-04 07:32:31         (elixir 1.17.1) lib/enum.ex:1703: Enum."-map/2-lists^map/1-1-"/2
2024-12-04 07:32:31         (mail 0.3.1) lib/mail/renderers/rfc_2822.ex:174: Mail.Renderers.RFC2822.render_headers/2
2024-12-04 07:32:31         (mail 0.3.1) lib/mail/renderers/rfc_2822.ex:56: Mail.Renderers.RFC2822.render_part/2
2024-12-04 07:32:31         (bamboo_mua 0.2.2) lib/bamboo_mua.ex:57: Bamboo.Mua.deliver/2

Steps to reproduce:
Follow the steps 1 - 5 in the readme file
probably needs to make som (or all) steps from the email configuration docs, to solve this.
So its not a big deal, but the ones wants to try it out quickly its not a good fist plausible experience.

👋 @vectorkovacspeter

Step 3 - Add site info

Do you mean the second step? Step 3 is about exposing HTTP ports.

And regarding the error, I guess you used BASE_URL=http://localhost:8000 or something like that?

We generate the mailer's email from BASE_URL if MAILER_EMAIL is not provided. There isn't much we can do if BASE_URL=http://localhost:8000 and raising an exception as we do seems ot be good enough as you were able to see it and realize that something is wrong with your configuration.

Ah, and https://github.com/plausible/community-edition/wiki/Configuration#enable_email_verification is set to false by default. So the registration emails are not sent out by default.

Would you be able to share your configuration files and the steps you took to setup Plausible CE to better understand your issues?


Implement mkdir

Address #77 by creating local-only directories.
Initial PR to discuss the approach.
I'm relying on the existing mechanism for files (add to parent's writing_files, set write_status) and it mostly works (manually, proper tests still to be added), but is it the right approach? Or do we want to keep track of "local" directories separately?
Also, for files we transition to the remote state on finish_writing (and remove them from writing_children): is there anything equivalent for directories? Or should we add a check e.g. in update_or_insert?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Added integration tests for mkdir. The mock/s3 test session only offered a PutObject function, I've extended them with a few more functions and created a TestClient trait. Any thoughts on the approach?


Using Nylas Python v3 SDK, create a code sample to read calendar events

Using Nylas Python v3 SDK, create a code sample to read calendar events

Hey there @relaxedtomato,
I would like to take up this issue! Please assign it to me if that's alright.
Thanks

Thanks @aakzsh!

Hi @relaxedtomato, could you please check pr #80 that I've created, thanks!

@aakzsh - going to have @atejada take a look soon!


add init agent data

👍

Current coverage is 44.19% (diff: 0.00%)

Merging #281 into master will increase coverage by 0.89%

@@             master       #281   diff @@
==========================================
  Files            12         12
  Lines          9815       9888    +73
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           4250       4370   +120
+ Misses         4431       4376    -55
- Partials       1134       1142     +8

Powered by Codecov. Last update 77409cb...6f1a6f9


nfs mount issues

Hi
I'm trying to mount a NFS share in a POD, but I encounter the exact same issue as mentioned here
https://github.com/coreos/bugs/issues/2038
My cluster is created with kube-aws 0.9.10 and CoreOS with ami-c70005be
Deployment for test purposes
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: hello
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: hello
        tier: webapp
    spec:
      volumes:
      - name: netapp
        nfs:
          server: my-nfs-server-host
          path: /vol1
      containers:
      - name: hello-backend
        image: docker pull busybox
        volumeMounts:
        - mountPath: /vol1
          name: netapp

Error message
Mounting command: mount
Mounting arguments: netapp.gdo.aws:/vol1 /var/lib/kubelet/pods/d7452ed4-6f44-11e8-a1d5-02878f774928/volumes/kubernetes.io~nfs/netapp nfs []
Output: mount.nfs: rpc.statd is not running but is required for remote locking.
mount.nfs: Either use '-o nolock' to keep locks local, or start statd.
mount.nfs: an incorrect mount option was specified

Pull request that fixes this issue.
https://github.com/kubernetes-incubator/kube-aws/pull/1365