Html version not working

looks like parseItems() call is missing somewhere

I am also working on it and I couldn't make it ; here codepen , pls help ;
https://codepen.io/ayd-in/pen/PomBxzN

I am also working on it and I couldn't make it ; here codepen , pls help ;
https://codepen.io/ayd-in/pen/PomBxzN

looks like parseItems() call is missing somewhere

HTML version is not working for me too. Is this still an issue?
Any working example of Initialize Zuck via HTML, please? I would greatly appreciate response.


Export additional API jars

Discovered the AppEngineSdkClasspathContainer#getKind() was returning an IClasspathEntry kind rather than an IClasspathContainer kind.  Type proposals work!
Added the other libraries shown in #385 except I can't find libservice.jar.
We may want to consider exposing a the library path via a variable so we don't have the full path to the SDK?
Fixes #385
PTAL @nbashirbello

LGTM

lgtm


[REVIEW] Fix unsafe string path concatenation

This PR:

Fixes all remaining unsafe uses of raw string concatenation for paths

This is now ready for review, cc @ayushdg @VibhuJawa @Christian8491

Will factor out the blazingsql create table calls into a helper function to avoid duplication in a followup shortly


fix: remove extra slash in requests to Metal API via equinix-sdk-go

The E2E tests look fine. Some of the unrelated failures were 429 related. https://github.com/equinix/terraform-provider-equinix/pull/758 should address that.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.42%. Comparing base (4b6af14) to head (0c9eebf).
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #752       +/-   ##
===========================================
+ Coverage   34.38%   52.42%   +18.03%
===========================================
  Files         154      154
  Lines       21080    21062       -18
===========================================
+ Hits         7249    11041     +3792
+ Misses      13670     9588     -4082
- Partials      161      433      +272

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Critical PowerShell script to setup SPN for ADO ALM fails and poorly commented.

The New-CrmServicePrincipal powershell scrip is critical to setup Pipelines for Power platform ADO.
It consistently fails for me so I examined the script and typed in manually. Not sure if doesn't work because I've done it wrong or Enterprise privileges need to be improved.
Error message text attached but extract is
Message: Invalid value specified for property 'displayName' of resource 'Application'.
The script runs with no parameters so it devises the display name.
The script is obviously written by a power shell expert and is no doubt slick and performant but I don't know why it needs to be.
Most mortals will only ever run it once so it could be written as easier to understand wall paper.
There are various comments and links which will have helped the expert developer but I'm lost.
I especially don't understand why when it's finished running I cannot type a variable name and see the contents as I used to.
Its now cost me a day to understand what's wrong, hopefully I'll have got the SPM manual approach sorted soon but if someone can fix this script it will make lives easier for those trying to setup Power platform ALM on ADO.
Cheers, Richard UK.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fba2155b-98b3-64e0-29f5-79cf2b1a90f1
Version Independent ID: d2b30089-7cf3-563a-eb38-d112793beb9b
Content: Microsoft Power Platform Build Tools for Azure DevOps - Power Platform
Content Source: power-platform/alm/devops-build-tools.md
Service: power-platform
Sub-service: alm
GitHub Login: @mikkelsen2000
Microsoft Alias: pemikkel
alm-powershell-spn-failure-messages.txt
New-CrmServicePrincipal.txt

Good news.
I managed to get my ADO Service Principal setup right.
I had manually configured my App registration okay, my problem in the ADO service connection was specifying msonline 365 as the server and not the Dynamics 365 environment URL.
I did recheck my app registration to check if a redirect was needed, it's not in the script, but I don't think it is.
The App registration is so easy to setup manually that the 7 page powershell is quite a bit of overkill and in a problem situation very confusing.
As it is I think that one App registration can be used across all of our environments with different SPN's just referring to the different URL's.
In that case the monster script will probably only ever be needed once.
It certainly consumed a lot of my time! Thanks, anyway.
Cheers, Richard UK


fix(call): Silence button call

What this PR does 📖

Makes the button update the call tracker in state
Adds "Coming Soon" to the button tooltip (the button isnt functional yet)

Which issue(s) this PR fixes 🔨

Resolve #1386

Special notes for reviewers 🗒
I have not seen a way yet in blink to silence a call. You could maybe loop over all participants and set their volume to 0 but i feel like that is not the proper way. Maybe @dariusc93 can give his insight there more

@sdwoodbury might be able to give some insight into this

idk why we want this feature anyway. if we must have it then i can add it to blink.


ViroView Render Issue - White Noise Like Fog

It displays a white noise  that looks like a fog.

Hi @jaylumba sorry for the delay in responding. We saw the screenshot you sent over via support and are looking into it. A couple additional question to help us root cause the issue:

Does this white fog always appear? or only when you take a screenshot?
Can you provide a code snippet so we can repro on our end?
Are you on ViroCore 1.5.0?

Adding information from support email:

Repro-ed on Galaxy S8+ and Note 8
Screenshot:

Hi @dam00n,
1. Yes the white fog always appear even when not taking screenshot.
2. Code Snippet: Where llViroviewContainer is a LinearLayout.
`public void initViroView(){
viroView = new ViroViewARCore(this, new ViroViewARCore.StartupListener() {
@Override
public void onSuccess() {
// Create the 3D AR scene, and display the point cloud
scene = new ARScene();
viroView.setScene(scene);
            // Add some lights to the scene; this will give the Android's some nice illumination.
            Node rootNode = scene.getRootNode();
            List<Vector> lightPositions = new ArrayList<Vector>();
            lightPositions.add(new Vector(-10, 10, 1));
            lightPositions.add(new Vector(10, 10, 1));

            float intensity = 300;
            List<Integer> lightColors = new ArrayList();
            lightColors.add(Color.WHITE);
            lightColors.add(Color.WHITE);

            for (int i = 0; i < lightPositions.size(); i++) {
                OmniLight light = new OmniLight();
                light.setColor(lightColors.get(i));
                light.setPosition(lightPositions.get(i));
                light.setAttenuationStartDistance(20);
                light.setAttenuationEndDistance(30);
                light.setIntensity(intensity);
                rootNode.addLight(light);
            }
        }

        @Override
        public void onFailure(ViroViewARCore.StartupError error, String errorMessage) {
            Timber.e("Error initializing AR [" + errorMessage + "]");
        }
    });
    llViroviewContainer.addView(viroView);

}`
3. Are you on ViroCore 1.5.0?
I'll get back to you on this. Will double check the version of ViroCore I'm using.


Opening mat-menu for the first time in MS Edge causes scrollbars to show

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Mat-menu scrollbars shouldn't show on first-time render on MS Edge if styling is not specified.
What is the current behavior?
Scrollbars in mat-menus are shown on first time rendering on Edge. Subsequent opening of mat-menus do not render scrollbars. Disabling and enabling overflow styling does not re-render scrollbars.
What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?
This would appear to be incorrect behaviour for the mat-menu component
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Microsoft Edge 38.14393.2068.0
Microsoft EdgeHTML 14.14393
"@angular/material": "^6.2.0"
"@angular/core": "^6.0.3"
Is there anything else we should know?

I wasn't able to reproduce the issue by adding extra content to the menu. Can you post an example that shows the issue? You can fork one of the examples from the docs.

Hi, I was able to reproduce it. Kindly check the below link:
https://stackblitz.com/edit/angular-nq6s32?file=app/menu-overview-example.css
Basically by simply specifying
[mat-menu-item] {   width: 230px; }
I was able to reproduce the issue with reference to the above browser version.


Clearer label for the rank plot y-axis

Currently, the rank plot y-axis just says Magnitude: [ranking column name].
[ranking column name] can be either a differential name—examples:

Magnitude: C(sample_type_body_site, Treatment(sea water))(T: fish GI)
Magnitude: Intercept
Magnitude: effect
Magnitude: Oxygen

...or a feature loading axis name—

Magnitude: Axis 1
Magnitude: Axis 2
Magnitude: Axis 3

A way to make this legend slightly more understandable would be changing "Magnitude" to either Differential or Feature Loading, based on the input ranking type:

Differential: C(sample_type_body_site, Treatment(sea water))(T: fish GI)
Differential: Intercept
Differential: effect
Differential: Oxygen
Feature Loading: Axis 1
Feature Loading: Axis 2
Feature Loading: Axis 3

Programmatically, this should be simple enough to implement (on the python side of things, just chuck the y-axis label prefix somewhere into the rank plot JSON; on the JS side of things, detect it in the rank plot JSON and store it as a property of the loaded RRVDisplay instance).
@cameronmartino @mortonjt does this seem mathematically kosher / helpful?

@fedarko that seems reasonable to me


sending multiple transactions as ACID transactions

Hello again :)
I was just wondering, is there a way to do ACID transaction with your library?
For example, if I was to send tether tokens to addresses A and B from address C, could I do an ACID transaction to ensure that the tokens get sent to both address A and B otherwise the transaction would roll back if the one didn't succeed?
You guys should start billing me for all your time in answering all my questions ;)
thanks heaps

Transferring tokens is an instruction. You can pack them (transfer token to A and B) into the same transaction. If one of them fails, the whole transaction will fail as well.


Minified alternative?

We can't afford to store this much data, pls minify

I agree, the Dockerfile is bloat


Danger fails on CI when running on PR from a fork in GH Actions / Buddy Build

We just set up danger in our repository and it fails when running on PRs from forks.
What did you do?
bundle install
bundle exec danger --fail-on-errors=true

What did you expect to happen?
It would run danger and find the branch & commit in my fork.
What happened instead?
It failed to find the commits and/or the branch:
fatal: Couldn't find remote ref refs/heads/event-ordering
fatal: Couldn't find remote ref refs/heads/event-ordering
fatal: Couldn't find remote ref refs/heads/event-ordering
fatal: Couldn't find remote ref refs/heads/event-ordering
bundler: failed to load command: danger (/usr/local/bin/danger)
RuntimeError: Commit c2b6bb0b doesn't exist. Are you running `danger local/pr` against the correct repository? Also this usually happens when you rebase/reset and force-pushed.
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/lib/danger/scm_source/git_repo.rb:111:in `raise_if_we_cannot_find_the_commit'
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/lib/danger/scm_source/git_repo.rb:93:in `ensure_commitish_exists_on_branch!'
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/lib/danger/request_sources/github/github.rb:112:in `setup_danger_branches'
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/lib/danger/danger_core/environment_manager.rb:57:in `ensure_danger_branches_are_setup'
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/lib/danger/danger_core/dangerfile.rb:259:in `setup_for_running'
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/lib/danger/danger_core/dangerfile.rb:270:in `run'
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/lib/danger/danger_core/executor.rb:29:in `run'
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/lib/danger/commands/runner.rb:72:in `run'
/Library/Ruby/Gems/2.3.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
/Library/Ruby/Gems/2.3.0/gems/danger-5.14.0/bin/danger:5:in `<top (required)>'
/usr/local/bin/danger:22:in `load'
/usr/local/bin/danger:22:in `<top (required)>'

Your Environment

Which CI are you running on?
Buddybuild
Are you running the latest version of Danger?
Yup
What is your Dangerfile?

warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"

swiftlint.lint_files fail_on_error: true

Did that commit exist in the repo?

@orta yeah the commit exists but it seems like it's trying to look at the wrong remote (origin) instead of my fork.

Ah cool, might be worth looking that the buddy build part of the codebase and compare it to the env vars that bb shows and see If they need changing

@orta thanks for the quick response – this part right here looks like it's defaulting to the origins, if I'm reading it correctly. Would it be possible to use the slug to construct a URL instead somehow?

I'm unsure, I've never used buddy build: maybe there's an API? maybe there's another remote on the repo? Maybe there's another env var?

Hey! Gonna resurrect this issue because I forgot about it for a while. @orta do you know what the repo_url is actually used for? It seems to me that we should be able to know where to fetch the changes from even without the repo_url since we have the repo_slug (i.e. {username}/{repo}). Is there any way we can construct a repo_url by using the slug somehow?

I'm having this same issue with github actions - danger can't find the commit from the forked repo because it appears to be looking in the origin.

Yes, happening for us too on public Open Source repo. Can we somehow work around that?
bundler: failed to load command: danger (/usr/local/lib/ruby/gems/2.6.0/bin/danger)
105
RuntimeError: Commit f28e72a0 doesn't exist. Are you running `danger local/pr` against the correct repository? Also this usually happens when you rebase/reset and force-pushed.

@orta Let me know if you have any idea what to do here - but it could be easy for someone who knows where is Danger looking for wrong remote?

it looks like danger is not finding the head commit, so the pull from the remote repo seems to be failing somewhere?
I can't really remember where all that code is anymore though, so I'm afraid you'll have to do some digging to find the commands it runs and try see why danger can't find the commits.

@orta I already did today, and I think I'm not sure if setup_danger_branches in github.rb:112 is getting the right stuff, if so, then ensure_commitish_exists_on_branch (git_repo:99) uses origin as remote and it might not be the correct one - and I wasn't able to dig into that and get the info from that.
I just checked other repos and it looks like all frameworks / repos / projects not only on Github have the same issue with Forks and some of them just removed Danger for open source with many fork PRs... which is sad 😢
/usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/lib/danger/scm_source/git_repo.rb:117:in `raise_if_we_cannot_find_the_commit'
107
  /usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/lib/danger/scm_source/git_repo.rb:99:in `ensure_commitish_exists_on_branch!'
108
  /usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/lib/danger/request_sources/github/github.rb:112:in `setup_danger_branches'
109
  /usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/lib/danger/danger_core/environment_manager.rb:58:in `ensure_danger_branches_are_setup'
110
  /usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/lib/danger/danger_core/dangerfile.rb:259:in `setup_for_running'
111
  /usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/lib/danger/danger_core/dangerfile.rb:270:in `run'
112
  /usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/lib/danger/danger_core/executor.rb:29:in `run'
113
  /usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/lib/danger/commands/runner.rb:73:in `run'
114
  /usr/local/lib/ruby/gems/2.6.0/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
115
  /usr/local/lib/ruby/gems/2.6.0/gems/danger-6.3.1/bin/danger:5:in `<top (required)>'
116
  /usr/local/lib/ruby/gems/2.6.0/bin/danger:23:in `load'
117
  /usr/local/lib/ruby/gems/2.6.0/bin/danger:23:in `<top (required)>'

I gave up after about two hours...

I'd be very surprised if all projects using forks are seeing this, this issue has been open for a year and danger is used extensively in open source projects. I'm not sure why it's working in these cases though.
The code here looks correct though, both head and base references are requested - and if those commands fail then it should also raise I believe
https://github.com/danger/danger/blob/c51e39c61c814f545c4c88c0179920684b620e56/lib/danger/request_sources/github/github.rb#L99-L114

And isn't that exactly the problem?
github.rb:112:in `setup_danger_branches'

which means
scm.ensure_commitish_exists_on_branch! head_branch, head_commit

raises an issue...
It seems like git_fetch_branch_to_depthis fetching from wrong place then.
Can you point me to any open source repo with Danger and PR from fork that works, please? I'll do my best to find out what's happening...

This repo has had a few PRs from forks, here's a PR which still has a danger comment: https://github.com/danger/danger/pull/1207

Thanks @orta , that might help!
I can see that Circle CI job has setup: https://github.com/danger/danger/blob/69809e8fbb2f61f2755607d2219608ac645eb4d6/.circleci/config.yml#L24
      - run: '[ ! -z $DANGER_GITHUB_API_TOKEN ] && bundle exec danger || echo "Skipping Danger for External Contributor"'
      - run: bundle exec danger init --mousey --impatient

Looking at the Circle CI run on given job, I can see that it skipped the first one due to external contributor, and then tried the second run:
What exactly the mousey and impatient does? Could it be that?

Travis should be the one running the dangerfile for PRs (need to test many, but don't want it spamming and confusing for others)
Though I don't see the status, here's the run: https://travis-ci.org/github/danger/danger/jobs/666482321#L2452
mousey and impatient are options to init which makes it not output so much and not wait for user input during the process, that's mainly a lint that the init command works and not useful here alas

I've got a PR with it running: https://github.com/danger/danger/pull/1210 - though it's not from a fork

Looks like what GitHub Actions does is:

Clone danger/danger
Create a merge commit with the changes in the PR into it /usr/bin/git log -1

 commit ac8589d580c00e773bf8e8dcb8bf9ba62bf1147c

 Author: Orta<EMAIL_ADDRESS>
 Date:   Mon Apr 6 17:40:52 2020 -0400

  Merge 90137a1b12581aab3efa299c1a37776c7998e91b into c577853adbdc50b36b5ed06cf1a195f8554e1c21

Then it uses that as head, so the actual commit from your fork isn't there at all. Which is why danger never finds it.
This is likely because other CIs clone your repo fork, where as these other one's clone the main repo and merge the changes in
There are two valid options from my perspective:

Check to see if it's a fork PR and if it is also make sure that the fork is fully fetched as well as the main repo
Allow GitHub Actions, and others to use HEAD instead of the real PR head (which isn't available)

I don't mind either route

Sounds like the first would take more time as it would be cloning/fetching two repos where the second one would be just using different commit as HEAD, right?
Honestly I don't care, but it's great to see this moving, thank you so much!

Nah, only Danger Ruby would get this - the others all use the GH/GL/BB API and don't need local FS access to git for their info.
Your guess is right - it'd have to fetch from two remotes instead of one right now. The latter has a chance for inaccuracy though, it might be a safe assumption that HEAD represents the current tip of the PR, but it might also not. That's why danger is a bit pedantic here and really making sure it knows the full history.

Let's do what you think is better, or maybe more bulletproof :)

Here to chime in, we're also seeing this behavior in our repo which uses Github Actions.
See https://github.com/GetStream/stream-chat-swift/pull/154 for example

Cool, then I'd recommend someone make a PR which checks the PR data to make sure both remotes are fetched: https://github.com/danger/danger/blob/7da261774d02359b723aec83abc3ba72fe7e8149/lib/danger/request_sources/github/github.rb#L99

Github Actions also does not pass secrets to any fork builds, which might be a cause.

Using:
      - uses: actions/checkout@v2

Will only checkout the single commit to be tested-you need something with more depth, so you can either use actions/checkout@v1 or specify the fetch-depth as in:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0

This solved my issues with Github Actions 😄

@orta Does Danger use the same secrets in CI check on PRs from forks. I was seeing this error

Could not set up API to Code Review site for Danger

For your GitHub repo, you need to expose: DANGER_GITHUB_API_TOKEN
You may also need: DANGER_GITHUB_HOST, DANGER_GITHUB_API_BASE_URL, DANGER_OCTOKIT_VERIFY_SSL

Seems like the repo secrets were not being shared.

Yep thread is about how GitHub does not share secrets to forks on PRs. It's out of Danger's control I'm afraid, you'd need to make it public like:
        run: |
          TOKEN='7469b4e94ce21b43e3ab7a'
          TOKEN+='79960c12a1e067f2ec'
          DANGER_GITHUB_API_TOKEN=$TOKEN yarn danger

Is there a Danger App I can install into my org which will run on PRs as clearly Danger in the CI process just is not compatible with Github's Action design

I'm not taking responsibility for something that important in my spare time. GitHub CI effectively made building it not worth it for me: https://www.youtube.com/watch?v=G_3JiEwby5Q
But I believe Yahoo! Japan implemented a version you can run yourself: https://github.com/yahoojapan/hosted-danger

idk if this will fix everyone's problems, but changing github workflow trigger from pull_request to pull_request_target resolved the issue for me. see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

@SgtPooki can you post the full action workflow you are using as I'm struggling to recreate it

@SgtPooki can you post the full action workflow you are using as I'm struggling to recreate it

it's in ipfs/awesome-ipfs repo. Also, there was some feedback on the PR or issue I created in that repo from galargh that you may find valuable regarding what setting pull_request_target actually does.

A few updates here:

Moving to pull_request_target basically never triggers the workflow in my experience, so that doesn't solve the 'access to the fork" problem, best I can tell.
The details in https://github.com/danger/danger/issues/1103#issuecomment-610055193 seem accurate, we need to make sure we look for the commit in the right place, and it seems like we're not... but not SOMETIMES, because other times it works (??)

I've found a few work-arounds (see https://github.com/chef/chef/pull/13976), basically I tee the output to a file, and if the failure shows Danger intentionally failed the PR, I exit 1, otherwise I exit 0. THis means that for forked-PRs, when it works, the output is only in the test log, which is still something, and for branched-PRs, the output will get put into a nice comment, which is good enough. It would be even better if danger itself could have different exit codes for that.

You could use --fail-on-errors=true to force an error code on the branched PR, though warnings would still slip by living only in logs
In Danger JS I explored using job summaries as another route for this, as well as https://github.com/danger/danger-js/pull/1126 but that meant I would be storing a bunch of people's github tokens which isn't something I want to do really

You could use --fail-on-errors=true to force an error code on the branched PR, though warnings would still slip by living only in logs

What? It works on branched repos, just not on forked repos. And it already fails on error, that's not the problem, the problem is it also fails for all PRs from forked repos because it can't find the commit making it seem like the author has bugs even when they don't. Hence the grepping the output above to decide what really happened.

I FINALLY found a work around:
      - uses: actions/checkout@v4
        with:
          # This will checkout the fork, if it's a fork
          # or the main repo if it's a branch
          ref: ${{github.event.pull_request.head.ref}}
          repository: ${{github.event.pull_request.head.repo.full_name}}

so I tried to work around this today, and while I didn't get a solution, I think what i found may be enlightening.
I added a step to checkout the fork remote:
      - run: |
          set -x
          echo $GITHUB_BASE_REF
          echo $GITHUB_HEAD_REF
          echo $EVENT
          echo $PR_REPO
          echo $BASE_REPO
          # should be PR_REPO_URL, but that doesn't exist
          # for some reason...
          git remote add pr https://github.com/$PR_REPO
          git fetch pr
          git remote -v
          git checkout $PR_HEAD
          git show
        if: github.event.pull_request.head.repo.full_name != github.repository
        env:
          EVENT: ${{ github.event_name }}
          PR_REPO: ${{ github.event.pull_request.head.repo.full_name }}
          PR_REPO_URL: ${{ github.event.pull_request.head.repo.clone_url }}
          BASE_REPO: ${{ github.repository }}
          PR_HEAD: ${{ github.event.pull_request.head.ref }}

When I did that, however, Danger, I think, ended up comparing the branch to itself, and saw no delta, and thus was very happy.
So then I tried to pass in --base:
      - run: |
          danger --verbose --fail-on-errors=true --base=$BASE
        env:
          BASE: ${{ github.event.pull_request.base.ref }}
          DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

But then it complains it can't find main anywhere in the repo (Commit main doesn't exist). That can't be right!
I then tried dropping the checkout, but that didn't work either.  I even tried modifying my git-fix step to be:
          git checkout -b main origin/main
          git checkout $PR_HEAD

to make sure the right main and the right head would be there. This gets the right things in the right places:
+ git remote -v
origin	https://github.com/chef/chef (fetch)
origin	https://github.com/chef/chef (push)
pr	https://github.com/jaymzh/chef (fetch)
pr	https://github.com/jaymzh/chef (push)
+ git checkout -b main origin/main
Previous HEAD position was 63aab93aff Merge cb81921547c7a0b0bdac3ebdf66f7726e5210015 into 3e18296d7e4f1a175f43f41d08173c708634cd8c
Switched to a new branch 'main'
branch 'main' set up to track 'origin/main'.
+ git checkout dangerfix
Switched to a new branch 'dangerfix'
branch 'dangerfix' set up to track 'pr/dangerfix'.

But, this, once again, caused danger to simply see nothing.
I tried at this point modifying danger call to be this, though I think this is what it does by default:
      - run: |
          danger --verbose --fail-on-errors=true --base=$BASE --head=$PR_HEAD
        env:
          BASE: ${{ github.event.pull_request.base.ref }}
          PR_HEAD: ${{ github.event.pull_request.head.ref }}
          DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

But it sees nothing.
So then I decided to add message(git.diff) to see what diff it thinks it's seeing.
Low and behold, it's my diff. It crashes on unless source.valid_encoding? (https://github.com/chef/chef/actions/runs/7148990967/job/19470679407?pr=14134), but in the stacktrace I can see the diff.
So at this point, given I've made sure that both the base ref and the head ref are both there, I think it seems reasonable to believe there's something that Danger isn't quite catching here.

I'm wondering if anyone has tried out the set up described in https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ (in particular ReceivePR.yml + CommentPR.yml) along with danger?

That seems like it would work if Danger were modified to be able to dump it's run results into some standard format, but not act on it, and then read it in and act on it. But AFAIK, it does not have such options.

Danger in JS is already split in a way to be able to do this (because it allows for different runtimes) - it'd require a pretty massive re-work of this ruby codebase to do that probably

Thank you both for your insights. I did a bit of testing locally last night and would appreciate your feedback, if I'm on the right track. I particular, I'm wondering if these commands would need some further adjustments when running as part of GH actions.
Step 0: Preparation: environment variables
For testing purposes, I defined the following environment variables. Here I'm also not 100% clear how this would need to be adjusted for GH actions.
export DANGER_GITHUB_API_TOKEN=xxx
export DANGER_FAKE_CI="YEP" DANGER_TEST_REPO='openstreetmap/openstreetmap-website' DANGER_TEST_PR='5269'

Step 1: ReceivePR.yml - generate JSON DSL format for step 2
$ yarn --silent danger pr https://github.com/openstreetmap/openstreetmap-website/pull/5269 --json > dsl_5269.json

For this step, I also looked into "danger ci", but it seems this is doing too much for our use case, and can't emit the DSL in json format?
Step 2: ReceivePR.yml - process Dangerfile, generate danger results as json output
$ cat dsl_5269.json | yarn --silent danger runner
danger-results://tmp/danger-results-c6ad4a36.json

This script outputs the "danger-results" location. My assumption would be that I have to check in this file as an artifact, and then process it in step 3 below.
I guess Steps 1 and 2 could be combined to as a single command as well?
$ yarn --silent danger pr https://github.com/openstreetmap/openstreetmap-website/pull/5269 --json | yarn --silent danger runner

Danger results output might look shown in this example:

{
  "fails": [
    {
      "message": "Gem/Bundle changes were not documented in the Description. If this is a major update, add #gemlock_major_upgrade to the PR Description."
    }
  ],
  "warnings": [],
  "messages": [],
  "markdowns": [],
  "scheduled": []
}

Step 3: Inside CommentPR.yml, update the pull request with findings from step 2.
yarn --silent danger process ./update_pr.rb

The respective ruby script processes the JSON danger result from step 2.  I've noticed that danger process had some issues with the json file generated in step 2, probably due to some additional whitespace. That why I had to do some reformatting using  JSON.parse(input).to_json. I'm not sure if this is the recommended approach, though.
#!/usr/bin/ruby
str = STDIN.tty? ? "Cannot read from STDIN" : $stdin.read
exit(1) unless str

require "json"

input = File.read("/tmp/danger-results-c6ad4a36.json")
results = JSON.parse(input).to_json

STDOUT.write(results)

Thanks!


Named capture groups

A major thing that ulex is missing is named capture groups, i.e. (Plus '0'..'9') as digits syntax. Sedlex misses it, too; asking the user to manually calculate the indexes is absurd.

:+1:

:+1:

I've just came across this problem.  And I agree, having to reprocess the whole matched lexeme with OCaml-re to fetch the individual groups is a bit ridiculous...

Same here. This is a major blocker to move to sedlex. Will not consider it until this has been implement.. :-(

Essentially, if you want it, implement it. At this point sedlex is not really maintained.

At this point sedlex is not really maintained.

That's a sad thing to hear. Is there any successor library?

Not really.

This is very sad to hear indeed! (And let me second, for whomever may show up, the need for named capture groups.)


Does autoware.iv support lane change?

Hi,
I am playing with autoware.iv and trying out the new features.
Is lane change supported in this version? If yes, where is it implemented?
Thanks

I found out:
https://github.com/tier4/Pilot.Auto/tree/master/planning/scenario_planning/lane_driving/behavior_planning/lane_change_planner
just works fine when the lanelet map is properly annotated (https://github.com/fzi-forschungszentrum-informatik/Lanelet2/blob/master/lanelet2_core/doc/LinestringTagging.md#as-lane-boundary)
:)


get website icon enhancement

Describe the feature or enhancement
Hi,
Been using this program for a while.
This is the first problem I've had.
Some areas do not open properly duckduckgo.com get website icon
like https://icons.duckduckgo.com/ip3/bing.com.ico
can add more api to select or just use website <link rel="shortcut icon"> href path ?
thx.

What other APIs are there? Loading the icon through making a request to each website would be really inefficient.


Drop IE11 from Browser Matrix

There is confusion in the project team about wether IE11 is to be supported. Unknowingly of the latest development I added it to the Browser Matrix with #47.
Let's collect here

If we should drop it from the matrix
What the IE11 issues are
If we act on them

Connected:

https://github.com/sinnerschrader/sinnerschrader-website/issues/25

in the last two month, we've only 4,6% of ie11 users - if this information helps.
ie11 issues:

external svg icon sprite (doesn't work in ie11)
-- possible fix: inline svg. we've only a few icons, so this should be ok

offer:
we add ie11 as b-browser

Drop IE 11

B-Grade Support

Vote via +1 on the comments above


initial code

Merge activity

Dec 6, 5:24 PM EST: A user started a stack merge that includes this pull request via Graphite.

#2  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


test result

（1）two pc connect  different wifi ，test no pass
（1）two pc connect  same  wifi ，the ip are in same subnetwork ，test ok

Duplicate, answer here: https://github.com/miroslavpejic85/p2p/issues/47#issuecomment-1794290028


AccessToken refresh clears value

What happened?
I am creating access tokens when bootstrapping repositories. These get then stored in the GitHub repository and/or a Vault instance.
This was working fine until the refactoring of the access token read method was done as since then a refresh clears the token value, which makes sense because the Pulumi API doesn't return the token but https://github.com/pulumi/pulumi-pulumiservice/blob/main/provider/pkg/provider/access_token.go#L128 and ultimately https://github.com/pulumi/pulumi-pulumiservice/blob/main/provider/pkg/provider/access_token.go#L30 assumes a token to be present.
This behaviour breaks my automation because on the next run, all stored tokens are cleared in GitHub/Vault and, in the end, all pipelines using these tokens are failing.
The same seems to happen with the description field.
Example

Create a AccessToken resource, and print the value (it seems like description is also cleared).
Call pulumi up and check the token.
Call pulumi refresh.
Call pulumi up again and the token is cleared.

Output of pulumi about
CLI
Version      3.125.0
Go Version   go1.22.5
Go Compiler  gc

Plugins
KIND      NAME           VERSION
resource  aws            6.45.0
resource  gcp            7.32.0
resource  github         6.2.3
language  nodejs         unknown
resource  pulumiservice  0.22.2
resource  random         4.16.3
resource  time           0.0.17
resource  vault          6.2.0

Host
OS       darwin
Version  15.0
Arch     arm64

This project is written in nodejs: executable='/Users/daniel/.nvm/versions/node/v20.15.1/bin/node' version='v20.15.1'

<truncated>

Found no pending operations associated with prod

Backend
Name           pulumi.com
URL            https://app.pulumi.com/muhlba91
User           muhlba91
Organizations  muhlba91
Token type     personal

Dependencies:
NAME                      VERSION
@pulumi/aws               6.45.0
@pulumi/gcp               7.32.0
@pulumi/github            6.2.3
@pulumi/pulumi            3.125.0
@pulumi/pulumiservice     0.22.2
@pulumi/random            4.16.3
@pulumi/vault             6.2.0
@pulumiverse/time         0.0.17
@types/nunjucks           3.2.6
nunjucks                  3.2.4
yaml                      2.4.5
eslint                    9.7.0
eslint-config-prettier    9.1.0
eslint-plugin-functional  6.6.3
eslint-plugin-import      2.29.1
npm-run-all2              6.2.2
prettier                  3.3.3
ts-node                   10.9.2
typedoc                   0.26.4
typescript                5.5.3
typescript-eslint         7.16.1

Pulumi locates its logs in /var/folders/v5/n7c212tn57v8mx8xtkm00wqc0000gn/T/ by default

Additional context
FYI: I implemented the previous support for refreshing the token as per https://github.com/pulumi/pulumi-pulumiservice/pull/177.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Good afternoon
Thank you for documenting the issue - I looked into it and realized that I indeed missed logic that accounts for value and description. I will make a fix and release it as soon as possible.
Sorry about that!

Release for 0.22.3 is out, please update to this new version - that should fix the issue.

awesome, thank you for the fix! 👍


Some CIPM references are not fetching

In relation to https://github.com/metanorma/bipm-si-brochure/issues/145
Following identifiers are not fetching:
CIPM Resolution 43
CIPM Resolution 51
CIPM Resolution 59
CIPM Resolution 62

Like I've stated in this thread: https://github.com/relaton/relaton-bipm/issues/17
Numbers correspond to the Meeting, not the Resolution.
The correspondence with original document is as follows:
CIPM Resolution 43 -> (PV, 22, 92)
CIPM Resolution 51 -> (PV, 30, 27)
CIPM Resolution 59 -> (PV, 38, 110-111)
CIPM Resolution 62 -> (PV, 1879, 41)
For CIPM Resolution 59 there is data available in the web: https://www.bipm.org/en/committees/ci/cipm/59-1970,
so the fetching should occur in this case. I can't say the same for the others, however.

Numbers correspond to the Meeting, not the Resolution.

What do you mean? Do you want to cite using the Meeting number, or the Resolution number?

The correct format is specified here: https://github.com/metanorma/metanorma-bipm/issues/164

From Janet Miles of the BIPM:
For the Resolutions/Recommendations/Decisions I think the following simple rule works without any ambiguity:
English:
[BODY] [Type] {number} (YEAR)

(where the number can be omitted if necessary, and the Type will be Resolution/Recommendation/Declaration as appropriate).
French (in French an additional dash is required as follows):
[BODY] - [Type] {number} (YEAR)

(and of course the Type has to be specified in French : Résolution,  Recommandation, Déclaration…)
Examples:
CGPM Resolution 6 (1987)
CIPM Resolution (1948)
CCDS Recommendation 2 (1970)

We are no longer using these:

The correspondence with original document is as follows:
CIPM Resolution 43 -> (PV, 22, 92)
CIPM Resolution 51 -> (PV, 30, 27)
CIPM Resolution 59 -> (PV, 38, 110-111)
CIPM Resolution 62 -> (PV, 1879, 41)


Navigator error upon attempt to open Scripts in the UI

Description
I click in Scripts folder and version 23.2.2 throws Navigator error:

Click ok and am able to open scripts  from File > Open File
2nd issue:
my server connections used to auto-connect upon opening of the UI, but this also stopped, but may have happened in previous version of DBeaver?
Thanks in advance for your help!
Steve
DBeaver Version
Community Edition version 23.2.2
Operating System
Windows 10
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Could you please provide the log files? You can find instructions here: https://dbeaver.com/docs/wiki/Log-files/. Thank you.

Hello,
adding all the log files from this location:
C:\Users\haufs\AppData\Roaming\DBeaverData\workspace6.metadata
dbeaver-debug-1697114603809.log
dbeaver-debug.log
dbeaver-debug-1697059763623.log
dbeaver-debug-1697067901846.log

Thanks for the bug report

you're very welcome!

Thank you very much for resolving all issues in this ticket!!!
Very much appreciated!
please close ticket

I failed to say Community Edition:
23.2.4 resolved the issue

The package on Arch stays on 23.2.2 version...


Update CLI documentation for profiles to show that edit accepts STDIN.

When the fix for issue #573 "Nice to have: write out config files and read it back in" was merged, the CLI usage documentation was not updated.  This commit clarifies that 'lxc profile edit' now accepts stdin.  I've not yet done the equivalent fix for 'lxc config edit' because I've not tested that functionality myself yet and the structure of the usage block in that file might benefit from a larger refactoring for legibility.
Signed-off-by: Matt Saunders<EMAIL_ADDRESS>

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.
Commands are simple Github comments of the format: "jenkins: COMMAND"

As this is a translatable string, you need to commit the result of "make i18n" too.

I guess the same should also be added to "lxc config edit" and "lxc image edit".

Ah, I didn’t know that “lxc image edit” accepts stdin.  As for config, I mentioned in the PR that it needed to be done, but as I’m not currently set up for go dev (I just treated this as a plain text file change really) I wasn’t able to test how line wrapping etc would look - and that’s why I didn’t realise about make i18n either.  Late in my timezone now but will have a look at both when I can - was just trying to scratch my own itches with the PR because I was jumping through lots of hoops trying to turn a yam file into a series of “lxc profile set” commands…
cheers
Matt

On 28 Oct 2015, at 18:24, Stéphane Graber<EMAIL_ADDRESS>wrote:
I guess the same should also be added to "lxc config edit" and "lxc image edit".
—
Reply to this email directly or view it on GitHub https://github.com/lxc/lxd/pull/1251#issuecomment-151941672.

Hi,
All 3 commands appear to be using the exact same duplicated code so the syntax for all 3 of them should be identical.
When you have the time, it'd be great if you could update the help for all 3 then run "make i18n" to update the translation template and that should be ready for merging.
I also opened a new issue for merging the duplicated code into one, #1253

Hello,
Are you still planning on working on this pull request?
If not, I can take it over from you and have it landed later this week.

Sure, go ahead, I won’t have time for a long while I expect.
cheers
Matt

On 3 Nov 2015, at 06:31, Stéphane Graber<EMAIL_ADDRESS>wrote:
Hello,
Are you still planning on working on this pull request?
If not, I can take it over from you and have it landed later this week.
—
Reply to this email directly or view it on GitHub https://github.com/lxc/lxd/pull/1251#issuecomment-153258170.


Possible performance issue (measured by blackfire)

Hi. Happy Christmas.
We are on production and decided to refactor our code to modules. So we created a command to make the refactoring easy and automatic as I have stated in #1146. I mentioned there that after putting the new code on production we experienced a big impact on performance, even behind opcache and cdn. So we had to rollback to previous code.
This week I got time to get back on this again since we are in need to do refactoring before adding more features. Today I was able to create a small benchmark from 4 different versions of our code and it's described below.
4 different versions:

original: Our code on production

laravel-modules: Refactoed code to this package's structure (only app folder, didn't touch database, routes, resources, ...) (31 modules)

laravel-modules-noproviders: Previous version with all but not functional providers (31 modules)

simple modules: We twisted our command a bit to just create an empty folder for each module and simply moved the same files from app folder to those folders with no extra providers, configs, ... files (almost the same files were moved as previous ones)

php artisan optimize and php artisan view:cache is used before serving on local computer and I have used blackfire for profiling

Version
Page1
Page2

original
32.7ms (1x mb)
113ms (1x mb)

laravel-modules
542ms  (1.25x mb)
619ms (1.18x mb)

laravel-modules-noproviders
56.6ms (1.08x mb)
135ms (1.06x mb)

simple modules
34.5ms (1.02x mb)
110ms (1.01x mb)

Of course I ran each one multiple times but the average response results were just about the same.
By the way the package is awesome and I'm not sure if my profiling was sane and I am looking for a solution. thanks

@bluemmb Did you get to the bottom of this?

@bluemmb Did you get to the bottom of this?

@xtfer As we concluded for our source code, having many providers (we had 31) which load their own routes and etc causes the bad performance. Since time was tight we decided to use another approach.
But we should wait and see what the main contributors are going to say.

@xtfer As we concluded for our source code, having many providers (we had 31) which load their own routes and etc causes the bad performance. Since time was tight we decided to use another approach.
But we should wait and see what the main contributors are going to say.


useHtml5routing

Add AngularJS configuration so that, whenever it is allowed by browsers, the # (hashtag) in URL is avoided, without losing capability of client-side routing.

yeah that is a nice addition to remove the HashTag. :+1:


Merge master into integrate-crowdin

Wondering how you bypass the lint warning about using console statements, since there is a console.error in createPages.js but no warning from that.

Pretty sure the lint rule just checks against console.log not console.error.


Images are pixelated when zoomed out

top: pineapple-pictures
botton: gwenview

https://github.com/BLumia/pineapple-pictures/blob/4c07a89ca3a8a9bec39c3ff3bc984849ef218bf5/app/graphicsview.cpp#L392-L399
Currently pineapple-pictures uses QGraphicsPixmapItem::setTransformationMode with SmoothTransformation  to smooth image when zoomed out, not sure how Gwenview did, will investigate it later™.
By the way, did you mind share the original image so I can use that to test on my machine?
Thanks!

Can't give that image right now, any image should work. I feel like there's some other transformation going on, since it looks fine in flameshot recent uploads window, which uses QLabel with scaled QPixmap

https://github.com/KDE/gwenview/blob/d82258c4318188993a428f51e4a205083a121602/lib/documentview/rasterimageitem.cpp#L120
I don't have an image that very suited for testing this issue right now. It seems like Gwenview uses the same method (not 100% sure, just did a quick look), may look into it later. It could be an interesting issue if Gwenview really does that and the behavior is not the same :p

Just randomly drew an ellipse and seems I'm able to reproduce this issue.

Original image used to test this bug
Anyway, I'll investigate it later™.

I'm probably using the QGraphicsView/QGraphicScene in a wrong way. Currently, when zooming in and out, the program will apply the scale to the graphics view instead of the image (QGraphicsPixmapItem) item. The SmoothTransformation mode applied to the item seems will only work when the scale transform is applied to the item.
Maybe I need to refactor some part of the code to resolve this issue, still not sure about this. Any confirmed this issue and this should be resolved in later updates.

Hi and could you try if https://github.com/BLumia/pineapple-pictures/commit/36c54addce2f7ba34f43631276ca4ad901b5dc36 resolved this issue?

Looks good now, thanks
Preview thing is also not using SmoothTransform btw

Preview thing is also not using SmoothTransform btw

The preview and the main area share the same graphics scene so only one of them could look smooth in the current implementation. It's just a navigation preview so I guess it's okay ;P
I'll close this issue then, let me know if you found any other issue :)

Update: 36c54ad introduced a bug that has been fixed in 7a0ed5b. If you are using 36c54ad please consider update :)


Initial porting work to .NET Core

This lays the groundwork for our 3.0 release which will feature a port from ASP.NET to ASP.NET Core. With these changes Augurk will start up on non-Windows platforms, but we do not yet make use of any new features, such as dependency injection. Also, some features might not work yet.

Seems fair.

Op 4 dec. 2018 om 22:00 heeft Jonathan Mezach<EMAIL_ADDRESS>het volgende geschreven:
@jmezach commented on this pull request.
In src/Augurk/Extensions/RavenDbServiceCollectionExtensions.cs:

+using System;
+using System.IO;
+using System.Reflection;

+namespace Microsoft.Extensions.DependencyInjection
+{

public static class RavenDbServiceCollectionExtensions
{

   public static void AddRavenDb(this IServiceCollection services)

   {

       var serverOptions = new ServerOptions

       {

           DataDirectory = Path.Combine(Environment.CurrentDirectory, "data")

       };

       var databaseOptions = new DatabaseOptions("FeatureStore")

Good point. I'm happy to change it to something else. Any suggestions? Perhaps just AugurkStore?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Okay, I'll squash merge this into the release branch and rebase my other branches on top of that. Next up, the dependency injection stuff ;).


Fix documentation links

These links were broken because they were relative to the current docs directory vs absolute from the base of the project folder.

Thanks!


Issue in running mxnet on windows

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System: Windows 10
Compiler: 64 bit
Package used (Python/R/Scala/Julia): Python
MXNet version:
Or if installed from source:
MXNet commit hash (git rev-parse HEAD): latest verion
If you are using python package, please provide
Python version and distribution: python 2.7.13
Error Message:
Please paste the full error message, including stack trace.
C:\Python27\python.exe C:/Users/Avrahim/PycharmProjects/CDL/cdl.py
Traceback (most recent call last):
File "C:/Users/Avrahim/PycharmProjects/CDL/cdl.py", line 2, in
import mxnet as mx
File "C:\Python27\lib\site-packages\mxnet_init_.py", line 7, in
from .base import MXNetError
File "C:\Python27\lib\site-packages\mxnet\base.py", line 45, in
_LIB = _load_lib()
File "C:\Python27\lib\site-packages\mxnet\base.py", line 36, in _load_lib
lib_path = libinfo.find_lib_path()
File "C:\Python27\lib\site-packages\mxnet\libinfo.py", line 37, in find_lib_path
'List of candidates:\n' + str('\n'.join(dll_path)))
RuntimeError: Cannot find the files.
List of candidates:
C:\Python27\lib\site-packages\mxnet\libmxnet.dll
C:\Python27\lib\site-packages\mxnet../../lib/libmxnet.dll
C:\Python27\lib\site-packages\mxnet../../build/Release/libmxnet.dll
C:\Python27\lib\site-packages\mxnet../../build\libmxnet.dll
C:\Python27\lib\site-packages\mxnet../../build\Release\libmxnet.dll
C:\Python27\lib\site-packages\mxnet../../windows/x64\Release\libmxnet.dll
Process finished with exit code 1

Have you successfully compiled the package?

Yeah, of course, but i did not get mxnet.dll, instead i get libmxnet.dll (about 1.5 gb) with successful building.

I think one solution is to put the compiled dll to the listed candidate directories. Also, you may try install the package via python setup.py develop --user.

sxjscience,
I need the detailed instructions of how to install mxnet on Windows need to rewritten. Because the building of mxnet did not give mxnet.dll as it is mentioned, but it gives libmxnet.dll (about 1.5 gb).
http://mxnet.io/get_started/windows_setup.html#install-the-mxnet-package-for-python

@MohammadAvrahem  a pr for that is welcome~

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


[nob] Adds Østnorsk (Bokmål) phones and updated TSV data

[x] Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

Closes #328

The data were transcribed really inconsistently in terms of what symbols were used for which phonemes, as noted in the .phones file. The "less common transcriptions" listed in the file nevertheless occur quite often (otherwise I wouldn't have bothered including them in the list). Given the small amount of data overall, I probably wouldn't recommend Bokmål for the shared task unless the data gets cleaned up.

The data were transcribed really inconsistently in terms of what symbols were used for which phonemes, as noted in the .phones file. The "less common transcriptions" listed in the file nevertheless occur quite often (otherwise I wouldn't have bothered including them in the list). Given the small amount of data overall, I probably wouldn't recommend Bokmål for the shared task unless the data gets cleaned up.

Okay, then, I think we should look at Phoible (for instance) and then
recommend a bot-based standardization to Aryaman.
On Sat, Jan 23, 2021 at 2:42 PM ajmalanoski<EMAIL_ADDRESS>wrote:

@ajmalanoski commented on this pull request.
In data/phones/nob_phonemic.phones
https://github.com/kylebgorman/wikipron/pull/330#discussion_r563191083:

+l

+ʃ  # Less common transcription of /ʂ/.
+ʈ  # Underlyingly /rt/.
+ɳ  # Underlyingly /rn/.
+ʂ
+ɽ
+ç
+j
+k
+ɡ
+ŋ
+h
+# Syllabic consonants
+n̩
+### VOWELS ###
+i  # Less common transcription of /ɪ/.
I looked through the TSV file a bit to compare /ɪ/ and /i/, and I didn't
really notice any patterns. Both seem to occur in the same contexts, as far
as I can tell
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/330#discussion_r563191083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OO425RCOKMRB6BNTM3S3MRBJANCNFSM4WP256JA
.

Okay, then, I think we should look at Phoible (for instance) and then
recommend a bot-based standardization to Aryaman.
On Sat, Jan 23, 2021 at 2:42 PM ajmalanoski<EMAIL_ADDRESS>wrote:

@ajmalanoski commented on this pull request.
In data/phones/nob_phonemic.phones
https://github.com/kylebgorman/wikipron/pull/330#discussion_r563191083:

+l

+ʃ  # Less common transcription of /ʂ/.
+ʈ  # Underlyingly /rt/.
+ɳ  # Underlyingly /rn/.
+ʂ
+ɽ
+ç
+j
+k
+ɡ
+ŋ
+h
+# Syllabic consonants
+n̩
+### VOWELS ###
+i  # Less common transcription of /ɪ/.
I looked through the TSV file a bit to compare /ɪ/ and /i/, and I didn't
really notice any patterns. Both seem to occur in the same contexts, as far
as I can tell
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/330#discussion_r563191083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OO425RCOKMRB6BNTM3S3MRBJANCNFSM4WP256JA
.

Checked---there's only one Phoible inventory (there are two actually, but
they're sourced from the same 1972 grammar), but both have tense/lax+length
distinctions, so I'd probably choose to standardize on that, all else held
equal.
On Sat, Jan 23, 2021 at 2:43 PM Kyle Gorman<EMAIL_ADDRESS>wrote:

Okay, then, I think we should look at Phoible (for instance) and then
recommend a bot-based standardization to Aryaman.
On Sat, Jan 23, 2021 at 2:42 PM ajmalanoski<EMAIL_ADDRESS>wrote:

@ajmalanoski commented on this pull request.
In data/phones/nob_phonemic.phones
https://github.com/kylebgorman/wikipron/pull/330#discussion_r563191083:

+l

+ʃ  # Less common transcription of /ʂ/.
+ʈ  # Underlyingly /rt/.
+ɳ  # Underlyingly /rn/.
+ʂ
+ɽ
+ç
+j
+k
+ɡ
+ŋ
+h
+# Syllabic consonants
+n̩
+### VOWELS ###
+i  # Less common transcription of /ɪ/.
I looked through the TSV file a bit to compare /ɪ/ and /i/, and I didn't
really notice any patterns. Both seem to occur in the same contexts, as far
as I can tell
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/330#discussion_r563191083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OO425RCOKMRB6BNTM3S3MRBJANCNFSM4WP256JA
.

Checked---there's only one Phoible inventory (there are two actually, but
they're sourced from the same 1972 grammar), but both have tense/lax+length
distinctions, so I'd probably choose to standardize on that, all else held
equal.
On Sat, Jan 23, 2021 at 2:43 PM Kyle Gorman<EMAIL_ADDRESS>wrote:

Okay, then, I think we should look at Phoible (for instance) and then
recommend a bot-based standardization to Aryaman.
On Sat, Jan 23, 2021 at 2:42 PM ajmalanoski<EMAIL_ADDRESS>wrote:

@ajmalanoski commented on this pull request.
In data/phones/nob_phonemic.phones
https://github.com/kylebgorman/wikipron/pull/330#discussion_r563191083:

+l

+ʃ  # Less common transcription of /ʂ/.
+ʈ  # Underlyingly /rt/.
+ɳ  # Underlyingly /rn/.
+ʂ
+ɽ
+ç
+j
+k
+ɡ
+ŋ
+h
+# Syllabic consonants
+n̩
+### VOWELS ###
+i  # Less common transcription of /ɪ/.
I looked through the TSV file a bit to compare /ɪ/ and /i/, and I didn't
really notice any patterns. Both seem to occur in the same contexts, as far
as I can tell
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/330#discussion_r563191083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OO425RCOKMRB6BNTM3S3MRBJANCNFSM4WP256JA
.

Makes sense to me.

Makes sense to me.


[Docs]: missing import in example code

Description
Here https://lucia-auth.com/tutorials/username-and-password/astro#:~:text=generateIdFromEntropySize
there is no import { generateIdFromEntropySize } from "lucia";

Should we use generateId() instead?

Should we use generateId() instead?

Didnt get it. You can just import generateIdFromEntropySize and use it as the docs suggest.

Oh, haha. I misunderstood your issue. My issue was there is no generateIdFromEntropySize to import from lucia, so I was having to use generateId instead. I later realized I wasn't on the latest version of lucia.

@andyrue yeah, I just meant the docs missing the necessary import. So it's typo for me.


Added test protocol specification.

This change is

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Added the Nonce Increment test.

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

spec.md, line 4081 [r3] (raw file):
#basic-data-encoding doesn't specify what actual tests (if there are any) are supposed to be.

spec.md, line 4083 [r3] (raw file):
is test BinaryDecode NodeInfo still available?
And is there a list of tests that are actually implemented? I mean, it implies that tests are limited by the existence of deconstructed values of data structures, but..

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

spec.md, line 4081 [r3] (raw file):
Clarified this section a bit.

spec.md, line 4083 [r3] (raw file):
Is this now clearer?

Comments from Reviewable

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Tracing is now very broken in Azure Functions

Description
I'm not entirely sure what's changed, but I suspect this may have been a host change, but I'll list out what I'm saying based on multiple customer issues we've had.
There is now an empty Activity present in the execution path. This means that whenever a user adds tracing, this new Activity is the parent, however, it's not something that you can listen to since it does not have a source name.
This leads to the new ActivitySource named Microsoft.Azure.Functions.Worker, this does take over the Blank Activity when you listen to the source, however, it uses the TraceContext from the FunctionContext as it's parent, which doesn't use the inbound traceparent from the HttpRequest headers as it's parent. This means that your span has a parent which you're unable to access.

That is what a trace looks like right now with the OOTB setup.
        services.AddOpenTelemetry()
            .ConfigureResource(resource => resource.AddService("practical-otel-azure-functions"))
            .UseFunctionsWorkerDefaults()
            .WithTracing(tracingBuilder =>
            {
                tracingBuilder
                    .SetSampler<AlwaysOnSampler>()
                    .AddSource("Microsoft.Azure.Functions.Worker")
                    .AddHttpClientInstrumentation()
                    .AddAspNetCoreInstrumentation()
                    .AddOtlpExporter();
            });

Aspire is rendering it in a semi-ok way, that's compensating for the fact that the data itself on those spans isn't right (missing parents, and missing root spans).
I think the big change is that, previously, there was not TraceContext on the function context, and therefore there was no active Activity. Since the upgrade, this has changed and now, there is an Activity which has a remote parent that there is no way to get access to (there's supposed to be a way to access it in Flex Consumption).
To be clear, this is a breaking change. Adding an Activity that is not trackable, and overriding the inbound traceparent causes functions to be untraceable due to the context propagation issues.
The AspNetCore span completely baffles me, since it's got a different parent to the FunctionsWorker span, and also somehow is outside of the hierarchy.
I'd love to know what caused this, and whether there is a plan to fix functions tracing for users who aren't upgrading to Flex Consumption.
Steps to reproduce
Create a new HTTP Trigger function
Add OpenTelemetry
Send the data to somewhere you can see the raw data.
Run it locally
Hit the endpoint
Look at the telemetry and you'll see that it doesn't follow a linear hierarchy, and there is no span that doesn't have a parent (aka a root span)

Thanks @martinjt for reaching out, I will provide an update by tomorrow.

Apart from this, when you have a HTTP triggered function and send a request to it, a new unparented span (a.k.a. new trace) is also being emitted from the AspNetCore instrumentation, so you have this blank Invoke span and this new trace.
ScopeSpans #1
ScopeSpans SchemaURL:
InstrumentationScope Microsoft.Azure.Functions.Worker <IP_ADDRESS>
Span #0
Trace ID       : 63b5dd200c01e184afdf5bafe61c90eb
Parent ID      : 055abe33f3e3a70e
ID             : ff98f9123b333119
Name           : Invoke
Kind           : Server
Start time     : 2024-09-26 16:56:46.7240646 +0000 UTC
End time       : 2024-09-26 16:56:46.9083439 +0000 UTC
Status code    : Unset
Status message :
ScopeSpans #2
ScopeSpans SchemaURL:
InstrumentationScope Microsoft.AspNetCore
Span #0
Trace ID       : 1e5d60beeafd93c433bb594460c600ff
Parent ID      :
ID             : 58a419ff1ceb4d7a
Name           : POST api/MyApi
Kind           : Server
Start time     : 2024-09-26 16:56:46.7395207 +0000 UTC
End time       : 2024-09-26 16:56:46.9209312 +0000 UTC
Status code    : Unset
Status message :

@martinjt , you are right. We created this internal activity to provide context since the current activity was null. We intentionally did not use an ActivitySource so it cannot be tracked. I'll look into it and update this thread tomorrow.

This has caused a breaking change @RohitRanjanMS, I can understand following rhe pattern than ASP.NET Core uses here (the legacy activity without source), however, there is no check for an existing activity here, which if there is, it makes no sense to create a new one.
Further, the host now creates an activity (even in none flex consumption), which means we have no ability to know if this was an entrypoint, and therefore can't override to make a root span.
I get that Aspire isn't flagging that there are missing spans in the trace, that's a separate issue since it should make developers aware there is an issue in their tracing.
The reason this is important is that the lineage of spans is important for searching and also display. Where you're at right now with it, there is no way to render a trace view with the right lineage where there is a function app involved.
In my opinion, there needs to be 2 high priority fixes.

Check for an existing activity and don't create the invisible one if that's the case.
Change the host such that it doesn't create spans by default.

Those 2 will fix all the issues this change has caused.

Hi @martinjt , there are two parallel pipelines: ASP.NET Core and Functions. While the ASP.NET Core pipeline is awaiting, the Functions pipeline runs the worker code. The correct approach is to integrate both pipelines, allowing the worker code to run within the ASP.NET Core pipeline and ensuring that telemetry is assigned the correct parent. This issue is also impacted for the same reason. Although I don’t have a specific date for the fix, it’s something we’ve been discussing recently.
I plan to add a null check for Activity.Current and, if it's not null, I won’t create the internal activity. This will be useful once the ASP.NET Core pipeline is fixed, allowing consumers to utilize the server span emitted by AspNetCoreInstrumentation.
However, the Functions runtime/host process will emit a server/consumer span, as it has the necessary context, especially in batch execution scenarios with messaging. The internal activity represents the remote activity on the host process, ensuring that all logs and spans are correctly parented by this remote activity.
This runtime version is available in the Flex consumption plan and will also be part of the Aspire release. We're actively working to improve OpenTelemetry support, with more features rolling out over the next few months.
Additionally, I don't recommend listening to Microsoft.Azure.Functions.Worker source, as it was designed to support the classic AppInsights SDK, which doesn’t add value in an OpenTelemetry context.

The null check, or correct parentage on the null activity will solve the issue with ASP.NET Core instrumentation appearing out of band (I tried this).
The issue right now is that even if you're not asking the runtime/host to use OpenTelemetry (and therefore generate all the data from the host), the host adds it's own span and therefore breaks the parentage with the calling service. This is most present when there is no traceparent coming from the calling http service, since this generates a root span in the host process that you don't get access to.
There is the further issue that you can't filter the Activity's generated by the host process, so it's incredibly noisy, with little signal data, but that's separate and related only to flex consumption (It's the reason that the collector approach in lambda is done that way).
I can understand that the host runtime has important context, and that context might only live there, but right now, it's generating spans and breaking the trace hierarchy even when you're not requesting that it does so. There are a lot of people who've required tracing to be present before this, and have used the inbound propagation from the traceparent in the headers, but now, that's broken due to the intermediary process generating a span that they can't see, and therefore can't do propagation properly.
This was a breaking change in the host runtime, that has broken existing functionality. One of them can be worked around, the other is in the host and therefore cannot.

I've created a minimal reproduction of the issue now.
https://github.com/[martinjt/root-span-issue-functions](https://github.com/martinjt/root-span-issue-functions)
Deploy that to a basic azure function, then add an environment variable for OTEL_EXPORTER_OTLP_ENDPOINT then point that at anything which doesn't process the telemetry to normalise it (I used an ngrok endpoint forwarding to Aspire locally).
When you hit the endpoint for the function, you'll generate a trace with 1 span, and that span will have a parent. That shouldn't happen, as now we have a missing root span. Since this is not in flex consumption, I have no ability to get access to that span.
This is how broken it is, since this used to work.

@RohitRanjanMS can we get this reopened to fix the remaining issue?

@martinjt we are tracking the 'fake' activity design here: #2810

@jviau This is slightly different.
The point (relating it to that other issue) is that context.TraceContext is set all when I haven't passed one in the traceparent in my http call.
Ultimately, in my example scenario above, the .SetId() would setting null anyway, which should be fine.
That's what has broke all our customers, since now there is a trace parent set that they can't get access to.


Allow running of just one stanza when using command line

When using the command line, please allow me to choose a single stanza to run.  i.e. I want to be able to do this:
python eventgen.py default/eventgen.conf --stanza sp-iisupload.csv
so that I can test a specific stanza in isolation without affecting the other stanzas in the file.

Complete in the dev branch as of this weekend.


Remove unneeded ServerMockerInstructionsList

This is a follow up to #8 and includes it.  When reviewing, make sure to click "commits" tab and only look at the 2nd commit .
The ServerMockerInstructionsList is essentially a vec wrapper, and does not add any value other than adds to API size. Instead, it is much easier to just pass the Vec<Instruction> to the mock server.
Also, minor improvement to test_dns_mock to keep it smaller.
In general, I think it might make sense to start using b"..." byte strings - easier than encoding each hex separately.

Wow thanks!
@nyurik so you can close the PR https://github.com/thomasarmel/socket-server-mocker/pull/8 ?

thx!  I was thinking you may want to review #8 first, merge it, and then this pr could have been rebaed on top of it to actually see the difference with it.  This way it might have been simpler to review, but either way works :)
About lints - I agree, need docs, and also need to enable CI to fail if clippy fails - i will propose CI changes soonish to ensure that.


implement decorator pattern

in this branch we:

Create a class Nameable.
Implement a method called correct_name that will raise a NotImplementedError.
Turn your Person class to Nameable

Make sure that your Person class inherits from Nameable
Make sure that this class has a method correct_name implemented. It should simply return the name attribute.
Prepare base Decorator

Make sure that it inherits from Nameable.
In the constructor assign a nameable object from params to an instance variable.
Implement the correct_name method that returns the result of the correct_name method of the @nameable.
Prepare CapitalizeDecorator and TrimmerDecorator

For the CapitalizeDecorator:
Create a class that inherits from the base Decorator class.
Implement a method correct_name that capitalizes the output of @nameable.correct_name.
For the TrimmerDecorator:
Create a class that inherits from the base Decorator class.
Implement a method correct_name that makes sure that the output of @nameable.correct_name has a maximum of 10
characters. If it's longer it should trim the word.

Hi @AhmedMohsen600 😊,
While you made a great effort in this project, I cannot proceed to review your code.
Invalid Code Review Request 🛑 💀
You have submitted a project, that supposes the Pull Request is made from the “feature branch” into the dev branch, not the main branch.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Integrate post-training bias analysis in pipeline model evaluation step

implemented in both 00_quickstart/ and 10_pipeline/


feat: Support custom templates for commits + PRs

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature.
:arrow_heading_down: What is the current behavior?
All commit messages, and pull request title and body templates are hardcoded.
:new: What is the new behavior (if this is a feature change)?
This commit introduces mustache templates for commit messages, and pull
request titles and bodies.
The design consists of templates with predefined properties. A custom
template can be provided.
Stubble has been chosen as the template renderer.
It is possible to define additional context for the templates, this also
includes delegates. These can be provided as the value of a "_delegates"
key in the context.
:boom: Does this PR introduce a breaking change?
No.
:bug: Recommendations for testing
Creation of pull requests and commits.
:memo: Links to relevant issues/docs
N/A
:thinking: Checklist before submitting

[X] All projects build
[X] Relevant documentation was updated

will this feature be merged?

I am very interested in the ability to set custom templates for commit messages and PR titles. We have a requirement to put a JIRA ticket number in both of these places.

I'm also interested in this; seems like a relatively small change too!

Rebased to incorporate new changes on master and fix conflicts.

Rebased to incorporate new changes on master and fix conflicts.

Heya, what needs done to get this functionality added? This still remains a dealbreaker of using this tool for us.

We are very interested in having custom commit messages, as we are using conventional commits to automatically set our version.
We are able to invest time into this feature. How to go on with this PR? What's missing? How we can help?

Any news? Still ready to help, if necessary.

For those which are looking for the corresponding issue (closed because of inactivity): https://github.com/NuKeeperDotNet/NuKeeper/issues/897


[Feature][plugins] refine plugin module

[Feature][plugins] refine plugin module

move all source/sink to seatunnel-connectors
move all transform to seatunnel-transforms

In case of existing issue, reference it using one of the following:
closes: #774
related: #774
Here is some example about how to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] Change does not need document change, or I will submit document change to https://github.com/InterestingLab/seatunnel-docs later

@garyelephant @CalvinKirs @dailidong PTAL

Thanks, very nice work, codes are too much, I will check this at this weekend carefully.

@wolfboys Hi, please resolve conflicts between your pr and dev branch

@garyelephant PTAL again


cli: ansible-repo-grapher now a full cli

This change adds command line structure. There is now a single "binary" which has two sub commands.

folder: Takes one argument pointing to the folder to graph (was called REPO_ROOT)
playbook: Takes one argument pointing to the playbook to graph

$ ansible-repo-grapher --help
Usage: ansible-repo-grapher [OPTIONS] COMMAND [ARGS]...

  Diagram Ansible playbook and role dependencies

Options:
  --help  Show this message and exit.

Commands:
  folder    Graphs a folder
  playbook  Graphs a playbook

Fixed the typo ⬆


[Storage] az storage container policy create Fix where it deletes public access info

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Storage


Demo doesn't load - returns error

`SyntaxError
Invalid left-hand side expression in prefix operation
xo
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:199475
e.value
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:216433
e.value
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:239498
t
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:216129
at evaluate (https://l7p179qr6m.csb.app/node_modules/
deck.gl/geo-layers/dist/esm/h3-layers/h3-cluster-layer.js:22:18
xo
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:199479
e.value
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:216433
e.value
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:239498
t
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:216129
at evaluate (https://l7p179qr6m.csb.app/node_modules/
deck.gl/geo-layers/dist/esm/index.js:37:57
xo
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:199479
e.value
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:216433
e.value
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:239498
t
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:216129
evaluate
https://l7p179qr6m.csb.app/node_modules/deck.gl/dist/esm/index.js:428:23
xo
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:199479
e.value
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:216433
e.value
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:239498
t
https://codesandbox.io/static/js/sandbox.9bb533ef6.js:1:216129
evaluate
/src/index.js:6
3 | import React, { Component } from "react";
4 | import { render } from "react-dom";
5 | import MapGL from "react-map-gl";

6 | import DeckGL, { GeoJsonLayer } from "deck.gl";
7 | import Geocoder from "react-map-gl-geocoder";
8 |
9 | // Please be a decent human and don't abuse my Mapbox API token.
View compiled
▶ 10 stack frames were collapsed.
`

Trying to mess around with the demo because I'm looking to add a search function to my map, but the demo doesn't load.

Hey @andrewshrout, thanks for raising the issue. Seems to be a problem with Code Sandbox. It seems like none of the sandboxes using deck.gl are working at the moment. I removed deck.gl from the demo which fixed the problem. https://codesandbox.io/s/l7p179qr6m


Runbook: extracting test DB backup

When there are DB errors, such as sqitch on the test instance it is very helpful to take a copy of the test DB and debug locally. This ticket is to document the steps and commands to run to get this copy.
AC:

[ ] Instructions on generating and extracting a full copy (with data) of the test db from OpenShift
[ ] Instructions on generating and extracting a copy with no data of the test db from OpenShift

Hey team! Please add your planning poker estimate with Zenhub @AntBush @rafasdc


add openeuler ospkg

What type of PR is this?

/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Ci Job https://github.com/hangscer8/kubean/actions/runs/4673957332

/lgtm

/lgtm


Add support for node:* imports with the nodejs_compat compatibility flag

What this PR solves / how to test:
This PR does two things:

Renames the --node-compat CLI/config option internally to legacyNodeCompat. Nothing changes externally. You still invoke it with --node-compat or node_compat. We maybe want to think about moving this to experimental as we stabilize thedev() API, but that discussion can happen elsewhere.
Marks any imports prefixed with node: as external when bundling with the nodejs_compat compatibility flag.

Associated docs issues/PR:

https://github.com/cloudflare/workerd/pull/208
https://github.com/cloudflare/miniflare/issues/473

Author has included the following, where applicable:

[ ] Tests (need a test to check the publish --dry-run and pages functions build output)
[x] Changeset

Reviewer has performed the following, where applicable:

[ ] Checked for inclusion of relevant tests
[x] Checked for inclusion of a relevant changeset
[ ] Checked for creation of associated docs updates
[ ] Manually pulled down the changes and spot-tested

Fixes # [insert issue number].

We need to add support for this compatibility flag in Miniflare (https://github.com/cloudflare/miniflare/issues/473) but once the workerd PR is merged and released, this'll be available with --experimental-local. Difficult (read impossible) to test this properly without either of these in place.

There are checks for exclusivitity throughout?

https://github.com/cloudflare/wrangler2/pull/2539/files#diff-91077b2ba8090bca91e063f04c1e862495858f9d4033fa7a8d4e34d9fcdb34e3R346
https://github.com/cloudflare/wrangler2/pull/2539/files#diff-c90ff1ca6d929baaafb7d67d6d6ccd573593762adf4e7a9b6917343ceeceb68bR309
https://github.com/cloudflare/wrangler2/pull/2539/files#diff-4aff2d0b1b481b9ead6cbf181ebf7298c13ecccd9644f5e8d4402663f7ff1d5aR134
https://github.com/cloudflare/wrangler2/pull/2539/files#diff-ee7e6a6ed4db87e45fe346d2922bd6b7eb68485222e23852bed880f5f6468e4fR32
https://github.com/cloudflare/wrangler2/pull/2539/files#diff-09e3e18998ee74fff220a99061a72ddc6d412dd8fd0110d75a8d20780657d15eR796

There are checks for exclusivitity throughout?

https://github.com/cloudflare/wrangler2/pull/2539/files#diff-91077b2ba8090bca91e063f04c1e862495858f9d4033fa7a8d4e34d9fcdb34e3R346
https://github.com/cloudflare/wrangler2/pull/2539/files#diff-c90ff1ca6d929baaafb7d67d6d6ccd573593762adf4e7a9b6917343ceeceb68bR309
https://github.com/cloudflare/wrangler2/pull/2539/files#diff-4aff2d0b1b481b9ead6cbf181ebf7298c13ecccd9644f5e8d4402663f7ff1d5aR134
https://github.com/cloudflare/wrangler2/pull/2539/files#diff-ee7e6a6ed4db87e45fe346d2922bd6b7eb68485222e23852bed880f5f6468e4fR32
https://github.com/cloudflare/wrangler2/pull/2539/files#diff-09e3e18998ee74fff220a99061a72ddc6d412dd8fd0110d75a8d20780657d15eR796

Correct, I would like to see tests that as a proof/coverage of that check functionality.

What is the status of this PR?
Will it enable the use of async_hooks in worker scripts?
Currently I get this error when trying to use it:
The package "async_hooks" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
Is this PR related / will enable this workerd PR: https://github.com/cloudflare/workerd/pull/208 ?

@danbars , still a work-in-progress! Please bear with us.

Hi @GregBrimble, sorry for nagging, I simply have a module that is pending on this PR - using async_hooks from node.
I'll be happy to know what is the expected timeline for this.
If this is a few weeks I guess I'll wait. Otherwise I'll probably develop an alternative solution that does not have this dependency.

@JacobMGEvans: rebased and added a couple of tests for that now:

https://github.com/cloudflare/workers-sdk/pull/2539/files#diff-8f31996226fa2e6948e321edadd5c6e1c8eca2ea47ec7662d0b9b41dd8c5dd17R1579
https://github.com/cloudflare/workers-sdk/pull/2539/files#diff-14ab3d4c8d99fc0fd46940e551843a07935a06e9153869e48b1c4554efcecb97R6782

Should this work with Pages? See https://discord.com/channels/595317990191398933/1024343493251973190/1084637493787373630


Inform User to Apply Layout after Settings Adjustment

Background
Related task https://github.com/epam/ketcher/issues/5152 the new setting Reaction component margin size were implemented.
Solution
When the user adjusts the "Reaction component margin size" settings and clicks the "Apply" button, an informational message should be displayed, informing the user that these changes require applying the layout to take full effect.
The message: "To fully apply these changes, you need to apply the layout."
The informational window  should include an "OK" button for the user to acknowledge the message and close the notification.

Verified.

Ketcher Version 2.28.0-rc.1 Build at 2024-12-03; 17:04:52
Indigo Version 1.27.0-rc.1.0-g8d656a341-wasm32-wasm-clang-19.0.0
Chrome Version 131.0.6778.109 (Official Build) (64-bit)
Win10


Add the extra sql migration scripts to the zip and stack dists

everything in ./scripts needs to be included in the dists so they are available to the admin that is deploying them.  Also stuff in stroom-ansible will need to change to make use of them being on the remote host, i.e. dump_to_stack_db_migration.

Fixed in > beta.170


✨ Add Auth0 functionality to Appropriate Pages

User Need
As a
I want
so that
Value
Functional Requirements:

Non-Functional Requirements:

Acceptance Criteria:

Notes:

Aged out


falco ConfigMap diff in live vs desired state - using ArgoCD

Describe the bug
We are using the latest (4.5.1) falco helm chart to deploy falco to our clusters using ArgoCD
After a while (minute or so) we see a diff in the live falco configMap vs. desired configMap (rendered from the falco helm chart)
Mostly this is due to incorrect indentation but also due to different yaml scalars

How to reproduce it
Deploy falco using helm and then compare the falco configMap against the rendered falco configMap. Or deploy using ArgoCD

Expected behaviour
We expect the live and desired state to match after we deploy falco using helm and ArgoCD

Screenshots

Environment

Falco version:

falco --version
Tue Jun 25 14:00:56 2024: Using deprecated config key 'rules_file' (singular form). Please use new 'rules_files' config key (plural form).
Tue Jun 25 14:00:56 2024: Falco version: 0.38.1 (x86_64)
Tue Jun 25 14:00:56 2024: Falco initialized with configuration files:
Tue Jun 25 14:00:56 2024:    /etc/falco/falco.yaml
Tue Jun 25 14:00:56 2024: System info: Linux version 5.10.218-208.862.amzn2.x86_64 (mockbuild@ip-10-0-42-214) (gcc10-gcc (GCC) 10.5.0 20230707 (Red Hat 10.5.0-1), GNU ld version 2.35.2-9.amzn2.0.1) #1 SMP Tue Jun 4 16:52:10 UTC 2024
{"default_driver_version":"7.2.0+driver","driver_api_version":"8.0.0","driver_schema_version":"2.0.0","engine_version":"40","engine_version_semver":"0.40.0","falco_version":"0.38.1","libs_version":"0.17.2","plugin_api_version":"3.6.0"}

System info:

falco --support | jq .system_info
Tue Jun 25 13:58:31 2024: Using deprecated config key 'rules_file' (singular form). Please use new 'rules_files' config key (plural form).
Tue Jun 25 13:58:31 2024: Falco version: 0.38.1 (x86_64)
Tue Jun 25 13:58:31 2024: Falco initialized with configuration files:
Tue Jun 25 13:58:31 2024:    /etc/falco/falco.yaml
Tue Jun 25 13:58:31 2024: System info: Linux version 5.10.218-208.862.amzn2.x86_64 (mockbuild@ip-10-0-42-214) (gcc10-gcc (GCC) 10.5.0 20230707 (Red Hat 10.5.0-1), GNU ld version 2.35.2-9.amzn2.0.1) #1 SMP Tue Jun 4 16:52:10 UTC 2024
Tue Jun 25 13:58:31 2024: Loading rules from file /etc/falco/falco_rules.yaml
Tue Jun 25 13:58:31 2024: Loading rules from file /etc/falco/rules.d/datadog-agent-exclude.yaml
Tue Jun 25 13:58:32 2024: Loading rules from file /etc/falco/rules.d/k8s-api-namespace-exclude.yaml
Tue Jun 25 13:58:32 2024: Loading rules from file /etc/falco/rules.d/kong-spawn-processes-exclude.yaml
{
  "machine": "x86_64",
  "nodename": "falco-2b9cd",
  "release": "5.10.218-208.862.amzn2.x86_64",
  "sysname": "Linux",
  "version": "#1 SMP Tue Jun 4 16:52:10 UTC 2024"
}

Cloud provider or hardware configuration:
OS: EKS - linux

Kernel: 5.10.218-208.862.amzn2.x86_64

Installation method:
Kubernetes using Helm and ArgoCD

Additional context

Hi @flickers, when the driver.kind is set to auto, falcoctl will automatically select the optimal driver for Falco. This selection will be updated in the Falco configmap. If you do not want this behavior then set the driver.kind to the desired driver: https://github.com/falcosecurity/charts/blob/7527d0f635bd3a20ece3362fcd8d7b9e418d939a/charts/falco/values.yaml#L184

/assign @alacuku

Hey @flickers, falcoctl does not update anymore the falco configmap. For more info see: https://github.com/falcosecurity/charts/pull/735.
Let me know if this is still an issue for you.

Can confirm that this is not an issue now.

Hey @flickers, falcoctl does not update anymore the falco configmap. For more info see: #735.
Let me know if this is still an issue for you.

yeah, no longer an issue now. Thanks

/close

@alacuku: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


docs: updating TLA+ spec

Description
To enter the "change-proposer" phase, a non-faulty node requires a quorum of "CHANGE-PROPOSER" votes. This ensures that non-faulty nodes do not transition into the "change-proposer" state too soon.
Additionally, a block is considered committed if it has a quorum of "BLOCK-ANNOUNCE" messages. This assumption ensures safety in an "asynchronous network", where a non-faulty node may receive a "BLOCK-ANNOUNCE" message too late.
Related issue(s)

Spec for fixing #585

Concerning "quorum", is there a requisite minimum number of nodes that need to be verified? If this is the case, what is the estimated probability?

is there a requisite minimum number of nodes that need to be verified?

Here, 'quorum' refers to a supermajority, which is more than two-thirds (2/3+) of the votes.
In committee, each vote is weighted according to the stake. Therefore, more than two-thirds of the committee's stake should vote for the proposed block.


Not Supported - Issue while installing pykaldi from source

Hi,
I am trying to install pykaldi. I have followed all the installation steps mentioned in the below link
https://github.com/pykaldi/pykaldi#installation
I have successfully installed all the dependencies using the scripts under tools directory
However when i am running "python setup.py install", i am getting the following error. I also set KALDI_DIR environment variable to the path where kaldi is installed
Also, i have run all the installation steps at the same time
"Kaldi installation at /data/manogna/pykaldi/tools/kaldi is not supported.
Please update Kaldi to match https://github.com/pykaldi/kaldi/tree/pykaldi"
Any help regarding this would be appreciated
Regards,
Manogna Nadella

Below is the error. There seems to be a problem with an option for git
(pykaldi_env) [jioapp@AZDEJIOADSAP02 pykaldi]$ python setup.py install
Unknown option: -C
usage: git [--version] [--help] [-c name=value]
[--exec-path[=]] [--html-path] [--man-path] [--info-path]
[-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
[--git-dir=] [--work-tree=] [--namespace=]
 []
Kaldi installation at /data/manogna/pykaldi/tools/kaldi is not supported.
Please update Kaldi to match https://github.com/pykaldi/kaldi/tree/pykaldi.
If i try to correct it and change 'C' to 'c', the error is as below
(pykaldi_env) [jioapp@AZDEJIOADSAP02 pykaldi]$ python setup.py install
fatal: Not a valid commit name 5dc5d41bb603ba935c6244c7b32788ea90b9cee3
Kaldi installation at /data/manogna/pykaldi/tools/kaldi is not supported.
Please update Kaldi to match https://github.com/pykaldi/kaldi/tree/pykaldi.

Note that we changed a lot recently to allow PyKaldi to build with newer OS versions, newer gcc version + Python 3.8 and Python 3.9. Please try again and let us know with a new issue if you still have problems. Thank you.

@Manogna-Nadella I was facing a similar problem... then I went to kaldi/tools/extras and ran ./install_mkl.sh


Extending computed class name identifiers throws:

Input:
var a = {
  foo: class {}
}

class bar extends a['foo']{

}

CC throws:
JSC_DYNAMIC_EXTENDS_TYPE: The class in an extends clause must be a qualified name. at line 6 character 18
class bar extends a['foo']{
                  ^

Is this by design? The JS code is valid.

I think CC should not treat bracket property accessor with string value as "dynamic". In my example class bar extends a.foo works but class bar extends a['foo'] doesn't while both are the same.
TypeScript compiler can follow the code:

Can you elaborate a bit on what your use case is? i.e. why you don't want
to write 'a.foo' instead?

Webpack outputs code like this:
class APIClientError extends __WEBPACK_IMPORTED_MODULE_3_helpers__["e" /* CustomError */] {

And I am using CC to minify Webpack output.

Duplicate of https://github.com/google/closure-compiler/issues/2106 ?

Not a duplicate - it's different. Fixing this would be a pretty simple change to the transpilation. Should be non-controversial as well.

Just ran into this as well trying to replace the ever-bloating Babel with CC. Sadly I'm getting otherwise great results, but this error pretty much prevents us from adopting CC.

Webpack outputs code like this:

class APIClientError extends __WEBPACK_IMPORTED_MODULE_3_helpers__["e" /* CustomError */] {
@mohsen1 webpack would only replace that if you are extending a namespace / import / etc. that you have imported. Can you please share the original source?

I don't exactly remember the original code anymore but this is close enough:
// Errors.ts
export class CustomError {
// ....
}

// SomeFile.ts
import { CustomError } from './Errors.ts';

class APIClientError extends CustomError {
// ...
}

Thanks, @mohsen1 https://github.com/webpack/webpack/blob/master/lib/dependencies/HarmonyImportSpecifierDependency.js#L87-L99 if you wanted to hack.

As workaround:
// SomeFile.ts
import { CustomError } from './Errors.ts';

const CustomErrorTemp = CustomError;

class APIClientError extends CustomErrorTemp {
// ...
}

The problem is from cases like this:
class APIClientError extends CustomError<API> {
// ...
}

we cant do:
const CustomErrorTemp = CustomError<API>;

You should be able to do that with type:
type CustomErrorTemp = CustomError<API>;

class APIClientError extends CustomErrorTemp {
// ...
}

Hmm error:
error TS2693: 'CustomErrorTemp' only refers to a type, but is being used as a value here.

oh right... sorry for misleading comment

I ran into this issue and decided to take a stab at fixing it (despite never having touched the Closure Compiler codebase before...). As far as I can tell, the most elegant solution is to allow CC to consider terms like a.b['c'] as a qualified name, similar (but not equivalent!) to a.b.c.
I don't want to submit a PR for this as my fix isn't perfect -- it fails some tests -- but perhaps somebody more familiar with the codebase can build upon it and complete it: https://github.com/Treeki/closure-compiler/tree/allow-constant-getelem-in-qualified-names

I deal with this limitation by manually extracting the base into a variable. I wonder if applying such a transform mechanically could be a correct resolution for this issue.
I.e. for the code in the first comment, the rewriting could be:
var a = {
  foo: class {}
}

var barBase0 = a['foo'];
class bar extends barBase0 {
  // ...
}

Will this be typed as expected?

I'm also experiencing this issue with webpack + closure compiler. Is there any ETA on a fix?

See #2997

Closed by #2997


refactor: perms-v2

Please add test cases for these new fields: undefined dm_permisdion vs false, undefined member permissions vs specified ones vs null ones

added boss


Improve project's CSS

[x] Add stylelint into pre-commit hook (webview/.lintstagedrc.js)
[ ] Enable stylelint camelCase selector rules (https://github.com/iterative/vscode-dvc/pull/3736#discussion_r1174131527)
[ ] Move stylelint packages into webview/node_modules instead of the root /node_modules (https://github.com/iterative/vscode-dvc/pull/3736#discussion_r1176801423)
[ ] Remove table/styles disabled comments (https://github.com/iterative/vscode-dvc/pull/3736#discussion_r1174127415)

Followup to #3736

Follow up on this: https://github.com/iterative/vscode-dvc/pull/3736#discussion_r1176801423

Yes, that's the second item on our task list, "Move stylelint packages into webview/node_modules instead of the root /node_modules". Though I see I've pasted the wrong comment link, I'll update it.

Add stylelint into pre-commit hook (webview/.lintstagedrc.js)

Good idea!

I actually meant this:

I tried to install stylelint packages inside of webview via the stylelint.stylelintPath config option, but stylelint kept getting installed inside the root for some reason, even after moving packages inside of webview/package.json, deleting node_modules, and starting out of a fresh install. I even tried to revert yarn.lock to a previous commit and fresh install the packages but stylelint still appeared inside of /node_modules instead of /webview/node_modules. Kept the packages installed in the root for now but can revisit this later

I actually meant this:

I tried to install stylelint packages inside of webview via the stylelint.stylelintPath config option, but stylelint kept getting installed inside the root for some reason, even after moving packages inside of webview/package.json, deleting node_modules, and starting out of a fresh install. I even tried to revert yarn.lock to a previous commit and fresh install the packages but stylelint still appeared inside of /node_modules instead of /webview/node_modules. Kept the packages installed in the root for now but can revisit this later

...Yes, that is the exact comment I'm referring too 🤔 The packages should be installed inside of /webview instead of the root since they're only used in the webview but I was having issues moving them... Is there something I'm misunderstanding?

I got as far as

Yes, that's the second item on our task list

Whoops! I think it was the second item at the time when I wrote the comment... Or I just made a type 😄


Enhancement Support date_trunc(date) and use it in auto partition

Proposed changes
Issue Number: close #xxx
before:
mysql> select date_trunc('2020-12-12', 'year');
+---------------------------------------------------------+
| date_trunc(cast('2020-12-12' as DATETIMEV2(0)), 'year') |
+---------------------------------------------------------+
| 2020-01-01 00:00:00                                     |
+---------------------------------------------------------+
1 row in set (0.16 sec)

after:
mysql> select date_trunc('2020-12-12', 'year');
+---------------------+
| 2020-01-01 00:00:00 |
+---------------------+
| 2020-01-01 00:00:00 |
+---------------------+
1 row in set (0.16 sec)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall