1107 update discovery search filter

Based on the feedbacks from PR #1058 , I made the following changes:

Removethe "update" button
Dynamically show the filtering results
Update faceting items only when search text is changed

Can one of the admins verify this patch?

Does this PR require/include #1058 ?

All style attributes in this changeset need to be moved to appropriate stylesheets.

@ironfroggy Not really. It has a different version of filtering panel from PR #1058 . We are not sure which one we prefer to. We want to test on both cases, I guess. I think we will discuss more about it on Thursday's meeting.

@xuezhaokun Waiting for responses on the comments already left.

@ironfroggy Sorry, I was too busy with my classes these days. I just noticed some bug on the PR. This PR works fine on my localhost, but when I tested it on HTTPS, there is something wrong with my view class. I am just trying to fix it by today's meeting.

@xuezhaokun - suspect the failing tests report from Jenkins is due to not being up to date with the develop branch. You may want to rebase or merge develop into your branch on your next iteration to allow the Jenkins tests to pass.

@mjstealey I am going to try to merge develop into my branch now.

@mjstealey It still fails...

It still fails...

Have you looked at the errors being generated by Jenkins?
Most notably:
Error Message
No module named simplejson

Stacktrace
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/home/docker/hydroshare/hs_core/tests/api/rest/test_create_resource.py", line 19, in test_post_resource_get_sysmeta
    response = self.client.post(url, params)
  File "/usr/local/lib/python2.7/site-packages/rest_framework/test.py", line 170, in post
    path, data=data, format=format, content_type=content_type, **extra)
  File "/usr/local/lib/python2.7/site-packages/rest_framework/test.py", line 92, in post
    return self.generic('POST', path, data, content_type, **extra)
  File "/usr/local/lib/python2.7/site-packages/django/test/client.py", line 379, in generic
    return self.request(**r)
  File "/usr/local/lib/python2.7/site-packages/rest_framework/test.py", line 159, in request
    return super(APIClient, self).request(**kwargs)
  File "/usr/local/lib/python2.7/site-packages/rest_framework/test.py", line 111, in request
    request = super(APIRequestFactory, self).request(**kwargs)
  File "/usr/local/lib/python2.7/site-packages/django/test/client.py", line 448, in request
    response = self.handler(environ)
  File "/usr/local/lib/python2.7/site-packages/django/test/client.py", line 109, in __call__
    self.load_middleware()
  File "/usr/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 52, in load_middleware
    mw_instance = mw_class()
  File "/usr/local/lib/python2.7/site-packages/django/middleware/locale.py", line 24, in __init__
    for url_pattern in get_resolver(None).url_patterns:
  File "/usr/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 401, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/usr/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 395, in urlconf_module
    self._urlconf_module = import_module(self.urlconf_name)
  File "/usr/local/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/docker/hydroshare/hydroshare/urls.py", line 13, in <module>
    from hs_core.views.discovery_json_view import DiscoveryJsonView
  File "/home/docker/hydroshare/hs_core/views/discovery_json_view.py", line 1, in <module>
    import simplejson as json
ImportError: No module named simplejson

Looks like you might need to make sure that simplejson is installed. You can use the main Dockerfile to accomplish this.
Example:
FROM mjstealey/hs_docker_base:1.6.9
MAINTAINER Michael J. Stealey<EMAIL_ADDRESS>
### Begin - HydroShare Development Image Additions ###
RUN pip install simplejson
### End - HydroShare Development Image Additions ###

USER root
WORKDIR /home/docker/hydroshare

CMD ["/bin/bash"]

Then rebuild and run the tests again.
You can run tests locally and verify that everything works. (they take some time to run).
$ docker exec hydroshare ./run-tests

@mjstealey It passes the tests after installing simplejson. Can you install simplejson module to docker? Or should I just commit my Dockerfile with RUN pip install simplejson?
Ran 304 tests in 728.462s

OK
nosetests corsheaders theme theme.blog_mods haystack hs_core hs_access_control hs_labels hs_metrics irods_browser_app hs_geo_raster_resource ref_ts hs_app_timeseries hs_app_netCDF hs_model_program hs_modelinstance hs_tools_resource hs_swat_modelinstance hs_geographic_feature_resource hs_script_resource hs_sitemap hs_collection_resource debug_toolbar filebrowser_safe django_comments --verbosity=1
Creating test database for alias 'default'...
Destroying test database for alias 'default'...
Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
hs_access_control/__init__.py                           1      0   100%
hs_access_control/models.py                           619     78    87%
hs_app_netCDF/__init__.py                               0      0   100%
hs_app_netCDF/admin.py                                  4      0   100%
hs_app_netCDF/forms.py                                121     72    40%
hs_app_netCDF/models.py                               139     82    41%
hs_app_netCDF/nc_functions/__init__.py                  0      0   100%
hs_app_netCDF/nc_functions/nc_dump.py                  88     75    15%
hs_app_netCDF/nc_functions/nc_meta.py                 209    186    11%
hs_app_netCDF/nc_functions/nc_utils.py                180    157    13%
hs_app_netCDF/page_processors.py                       78     67    14%
hs_app_netCDF/receivers.py                            236    218     8%
hs_app_netCDF/serialization.py                        330    166    50%
hs_app_timeseries/__init__.py                           0      0   100%
hs_app_timeseries/admin.py                              4      0   100%
hs_app_timeseries/forms.py                            109     27    75%
hs_app_timeseries/models.py                           207     24    88%
hs_app_timeseries/page_processors.py                   37     29    22%
hs_app_timeseries/receivers.py                        294     63    79%
hs_collection_resource/__init__.py                      0      0   100%
hs_collection_resource/admin.py                         4      0   100%
hs_collection_resource/models.py                       28      3    89%
hs_collection_resource/page_processors.py              34     26    24%
hs_collection_resource/receivers.py                     7      3    57%
hs_collection_resource/urls.py                          3      0   100%
hs_collection_resource/views.py                        49      3    94%
hs_core/__init__.py                                     0      0   100%
hs_core/admin.py                                        9      0   100%
hs_core/autocomplete_light_registry.py                 21     14    33%
hs_core/discovery_form.py                              46     40    13%
hs_core/forms.py                                      715    471    34%
hs_core/hydroshare/__init__.py                          5      0   100%
hs_core/hydroshare/date_util.py                        53     34    36%
hs_core/hydroshare/discovery.py                         8      4    50%
hs_core/hydroshare/hs_bagit.py                        141     25    82%
hs_core/hydroshare/resource.py                        328    160    51%
hs_core/hydroshare/social.py                           77      9    88%
hs_core/hydroshare/users.py                           231    115    50%
hs_core/hydroshare/utils.py                           318     67    79%
hs_core/languages_iso.py                                1      0   100%
hs_core/management/__init__.py                          1      0   100%
hs_core/management/commands/__init__.py                 1      0   100%
hs_core/metadata_terms_urls.py                          4      0   100%
hs_core/models.py                                    1170    254    78%
hs_core/page_processors.py                            207    193     7%
hs_core/receivers.py                                   78     71     9%
hs_core/resourcemap_urls.py                             4      0   100%
hs_core/serialization.py                              912    680    25%
hs_core/signals.py                                      9      0   100%
hs_core/tasks.py                                       93     54    42%
hs_core/templatetags/__init__.py                        1      0   100%
hs_core/templatetags/hydroshare_tags.py                85     44    48%
hs_core/testing.py                                     11      0   100%
hs_core/urls.py                                         3      0   100%
hs_core/views/__init__.py                             471    386    18%
hs_core/views/autocomplete.py                          46     40    13%
hs_core/views/discovery_json_view.py                   31     23    26%
hs_core/views/discovery_view.py                        38     28    26%
hs_core/views/pagination.py                             3      0   100%
hs_core/views/resource_rest_api.py                    214     39    82%
hs_core/views/serializers.py                           85     14    84%
hs_core/views/user_rest_api.py                         12      0   100%
hs_core/views/utils.py                                163    101    38%
hs_geo_raster_resource/__init__.py                      0      0   100%
hs_geo_raster_resource/admin.py                         4      0   100%
hs_geo_raster_resource/forms.py                       153     93    39%
hs_geo_raster_resource/models.py                      149     17    89%
hs_geo_raster_resource/page_processors.py              57     47    18%
hs_geo_raster_resource/raster_meta_extract.py         121     28    77%
hs_geo_raster_resource/receivers.py                   197     36    82%
hs_geo_raster_resource/serialization.py               341    210    38%
hs_geographic_feature_resource/__init__.py              0      0   100%
hs_geographic_feature_resource/admin.py                 4      0   100%
hs_geographic_feature_resource/forms.py                66     26    61%
hs_geographic_feature_resource/models.py              116     25    78%
hs_geographic_feature_resource/page_processors.py      72     64    11%
hs_geographic_feature_resource/parse_lib.py            76     10    87%
hs_geographic_feature_resource/receivers.py           362     74    80%
hs_labels/__init__.py                                   0      0   100%
hs_labels/models.py                                   121      3    98%
hs_labels/urls.py                                       3      0   100%
hs_labels/views/__init__.py                            52     47    10%
hs_metrics/__init__.py                                  0      0   100%
hs_metrics/models.py                                    0      0   100%
hs_metrics/urls.py                                      3      0   100%
hs_metrics/views.py                                    65     49    25%
hs_model_program/__init__.py                            0      0   100%
hs_model_program/admin.py                               4      0   100%
hs_model_program/forms.py                              49     21    57%
hs_model_program/models.py                             83     35    58%
hs_model_program/page_processors.py                    24     17    29%
hs_model_program/receivers.py                          33     24    27%
hs_model_program/urls.py                                4      0   100%
hs_model_program/views.py                              20     14    30%
hs_modelinstance/__init__.py                            0      0   100%
hs_modelinstance/admin.py                               4      0   100%
hs_modelinstance/forms.py                              56     25    55%
hs_modelinstance/models.py                             84      3    96%
hs_modelinstance/page_processors.py                    29     20    31%
hs_modelinstance/receivers.py                          23     14    39%
hs_script_resource/__init__.py                          0      0   100%
hs_script_resource/admin.py                             4      0   100%
hs_script_resource/forms.py                            29     10    66%
hs_script_resource/models.py                           71     27    62%
hs_script_resource/page_processors.py                  28     21    25%
hs_script_resource/receivers.py                        41      9    78%
hs_sitemap/__init__.py                                  0      0   100%
hs_sitemap/views.py                                     6      2    67%
hs_swat_modelinstance/__init__.py                       0      0   100%
hs_swat_modelinstance/admin.py                          5      0   100%
hs_swat_modelinstance/forms.py                        175     70    60%
hs_swat_modelinstance/models.py                       229    116    49%
hs_swat_modelinstance/page_processors.py               44     35    20%
hs_swat_modelinstance/receivers.py                     33     24    27%
hs_tools_resource/__init__.py                           0      0   100%
hs_tools_resource/admin.py                              4      0   100%
hs_tools_resource/forms.py                             88     26    70%
hs_tools_resource/models.py                            97     20    79%
hs_tools_resource/page_processors.py                   55     48    13%
hs_tools_resource/receivers.py                         24      1    96%
hs_tools_resource/utils.py                             14      0   100%
hydroshare/__init__.py                                  2      0   100%
hydroshare/celery.py                                   11      1    91%
hydroshare/local_settings.py                           69      0   100%
hydroshare/settings.py                                 64      2    97%
hydroshare/urls.py                                     23      0   100%
irods_browser_app/__init__.py                           0      0   100%
irods_browser_app/models.py                             0      0   100%
irods_browser_app/urls.py                               3      0   100%
irods_browser_app/views.py                            132    116    12%
manage.py                                               6      0   100%
ref_ts/__init__.py                                      0      0   100%
ref_ts/admin.py                                         4      0   100%
ref_ts/forms.py                                        15      0   100%
ref_ts/models.py                                       94     41    56%
ref_ts/page_processors.py                              21     16    24%
ref_ts/receivers.py                                     8      3    63%
ref_ts/ts_utils.py                                    441    407     8%
ref_ts/urls.py                                          3      0   100%
ref_ts/views.py                                       205    175    15%
theme/__init__.py                                       0      0   100%
theme/admin.py                                         12      0   100%
theme/blog_mods/__init__.py                             0      0   100%
theme/blog_mods/admin.py                                7      3    57%
theme/blog_mods/models.py                               0      0   100%
theme/forms.py                                        183    115    37%
theme/models.py                                        96     12    88%
theme/templatetags/__init__.py                          0      0   100%
theme/views.py                                        167    129    23%
-----------------------------------------------------------------------
TOTAL                                               13264   6476    51%

should I just commit my Dockerfile with RUN pip install simplejson

Yes, please commit the updated Dockerfile so that the install of simplejson will be applied to all once your branch is merged with develop.
When it comes time to put together the next release, I accumulate all Dockerfile additions and migrate them to the hs_docker_base branch as part of the new base build.

@xuezhaokun Is this ready for another round of review?

@pkdash  Yes. Sure.

@ironfroggy Seems it is ready for another round of review.

@xuezhaokun I left a few questions. Can we discuss them ASAP to move forward with this?

@ironfroggy Yes. Can we discuss it tomorrow morning at around 10:30am? Should I contact you via hipchat?

Sure, I will be on Hipchat tomorrow at 10:30AM.

@alvacouch @ironfroggy fixed

+1


CI Report task visibility

The report that is run from the CI fires of the task without much feedback to the user, the user would wait for a email that never arrives not knowing anything about what happened.
This will give the user some visibility on where in the process the task is and if they should wait for the email or escalate/retry.
The plan is to show the last 10 tasks below the report form on the CI, the user can then see what is going on.

This is ready for another look @rudigiesler


Content of folder metadata, section II, 4.1

Does it mean descriptive metadata specific to intellectual components of the IP should not be placed in this folder (e.g., if the IP contains a digital music album, metadata about each track)? Does this mean it's just that metadata specific to a given representation should go to the corresponding metadata folder in each representation folder. This sentence is slightly confusing, maybe something like this instead "descriptive metadata, and preservation metadata relevant to the whole package"?
Section: II, 4.1
Text: The Information Package root folder MUST include a folder named metadata, which SHOULD include metadata relevant to the whole package.

We need better text explaining the differences between package and representation level and the corresponding use of mets. This may need improvements to CSIPSTR5.

Something more needed in CSIPSTR5, @carlwilson ?
It currently looks like this:
CSIPSTR5: The Information Package root folder SHOULD include a folder named metadata, which SHOULD include metadata relevant to the whole package.


First pass at the External Wallet

Should we try to combine ExternalWallet and Wallet into one object and just have overloads for the constructor?


Install Travis and other services

Install Travis, Scrutinizer, Coveralls, CodeInsight, etc. so that when we create a pull request, there are some obvious indicators of that particular branch/changeset's quality and worthiness of being merged.

[x] Travis
[ ] Coveralls
[ ] StyleCI?
[ ] CodeInsight?
[x] Scrutinizer
[x] Sension Insight?

I think we don't need other. We have code coverage on Scrutinizer


Biometrics driver code error.

I think biometrics driver project have some code errors.
Please see my change and fix it.
Thanks.

Many Thanks 	@JinZhuXing
I got my Device started correctly (without the yellow exclamation mark) after some debugging at startup before the process stop.
I'd like to add a small contribution:
Before the end of the method: CBiometricDevice::CreateUsbIoTargets add a condition:
The variable m_pIUsbInterruptPipe must me not null because is used later in the code.

Also the next code is harcoded for usb devices that have only one interface (My device has two):
hr = pIUsbTargetDevice->RetrieveUsbInterface(0, &pIUsbInterface);
Here is a snnipet where I implemented a for loop to iterate through the number of interfaces and initialize all three variables, bingo!


readme: fix nix-env command.

The nix-env based install command specified in the README file is
failing.

$ nix-env -i https://github.com/utdemir/nixdu/archive/master.tar.gz -A exe
error: attribute 'https://github' in selection path 'https://github.com/utdemir/nixdu/archive/master.tar.gz' not found

PS: first!

Thanks!


attach a modal to each card

Hello all,
I discovered bootstrap and bootstrap native and I would like to attach a modal to each card of my card deck. On each card, I have an icon allowing to show more details. When clicking on it, I would like to display a modal with some data specific to each card.
In the onload function, I was planning to read all my data and generate my modals but I'm stuck.
What is the best way to achieve this and especially update the modal with the right data.
Thanks a lot for your help.

Read my docs on the demo page and try harder.

Not helping so much! I tried your demo page but the only way I found to associate card to modal is by using event. target to know which button has been pushed. Is it the right way?

Even the original library doesn't have this functionality, it's up to you to make it your way.


refactor: use globwalk builder pattern

I took the chance to remove some back and forth between OsStr, &str and PathBuf and return an iterator from the new get_glob_walker method.

:shipit: this is awesome @beeb Thank you!


[Testing] Fix types in operations for dense pauli strings

Fix #4835.
Fix operations like __pow__, __mul__,  __rmul__,  __abs__, tensor_product, etc, on abstract class BaseDensePauliString so that the operations return compatible types when applied on the two concrete subclasses DensePauliString and MutableDensePauliString.
Also add a few type annotations, and modify a few tests.
One noticeable implied change: multiplying a MutableDensePauliString object with a DensePauliString object (and vise versa) is not allowed anymore.

Friendly ping @alexandrebouayad: Do you have time to finish this up? I can take it on if not.

Friendly ping @alexandrebouayad: Do you have time to finish this up? I can take it on if not.

@vtomole thanks for the reminder, it had slipped my mind. I'll do it in the coming days.

I have made the changes as suggested, plus a few other minor ones. I'll add the remaining tests, and I'll ensure that local checks pass by the end of this week hopefully.

@alexandrebouayad Can you please fix the remaining failing tests? Thanks!

@alexandrebouayad Gentle reminder, do you still have time to work on this?

Hey @alexandrebouayad , I'm pretty sure this PR has been superseded by https://github.com/quantumlib/Cirq/pull/5624. We would love your review on that PR.

@vtomole Actually, I did skip over some of the tricky parts of fixing mypy types in my PR https://github.com/quantumlib/Cirq/pull/5624; for example:
Adding return types annotations to operations like __neg__, __add__ etc. breaks mypy because the cirq.Gate class returns LinearCombinationOfGates by default for these methods, but in BaseDensePauliString, we want to return type(self)(...), which is a (subclass of) BaseDensePauliString and not a LinearCombinationOfGates. This breaks Liskov Substitution Principle because BaseDensePauliString  is not a subclass of LinearCombinationOfGates.
Fixing this would require us to modify the default return types on cirq.Gate, which will be a big breaking change. We can potentially open a new issue to track this and maybe @alexandrebouayad's PR can tackle the new issue if he's already thought on this (I see the solution he has applied in his PR is to completely remove the return types from cirq.Gate's methods -- I'm not sure if this is the best we can do though; it's probably better to not have return types on a specific implementation  like BaseDensePauliString instead of removing return types from cirq.Gate)


Safari hangs (beach ball) when opening calendar widget [v0.18.7]

When opening the date picker with the 0.18.7 version of material-ui, Safari 11.0.1/11.0.2 hangs (unresponsive, eventually with a beach ball) on at least Mac OSX Sierra 10.12.6.
Note that the date picker works fine with recent versions of Chrome/Firefox on Mac/Windows 10.
So this looks clearly like a Safari issue (no client should be able to hang the browser!) but there may be something that material-ui can do to work-around the issue to avoid triggering it.
Unfortunately we've found problems upgrading to newer versions of material-ui; we're still working through this. At this stage I can't say if it's been resolved in a newer version of material-ui (suspect it has as it's a pretty glaring issue!).

[x] I have searched the issues of this repository and believe that this is not a duplicate. There are a few tickets related to Safari but nothing specifically with a) the date picker and b) Safari.

Expected Behavior
Open date picker, should be able to select a date.
Current Behavior
Open date picker, Safari hangs.
I can't yet expose our current website but will (in the next day) try to construct a reproducible test at codesandbox.io. For now I'll log this in case anyone has any pertinent information.
Your Environment

Tech
Version

Material-UI
0.18.7

React
15.6.1

browser
Safari 11.0.1/11.0.2

Mac OSX
Sierra 10.12.6

So does in Firefox At version of v1.0.0-beta.47
#11327

We do no longer plan any work on v0.x. I'm closing the issue. Thanks for the report.


Delete old backup

Please add option to delete old backup file
user can specify time in .config file
I want to delete 30 days old backup files

Please add option to delete old backup file user can specify time in .config file I want to delete 30 days old backup files

Hi, thanks for your feedback.
I have added this function. Please before you run the script with this new functionality backup your backup directories for security reasons.


GPR review: Move cmdline and subprocess from public gpr to test/core/util

****************************************************************

libgrpc.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                      ++++++++++++++

 -------------- SHRINKING                                                                    --------------
  -0.1%    -416 [None]                                                                       -1.41Ki  -0.0%
      -0.1%    -416 [Unmapped]                                                                   -1.41Ki  -0.0%
      [DEL]      -1 grpc_polling_api_trace                                                             0  [ = ]
  -7.7%    -288 src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc    -288  -7.7%
      [DEL]    -196 dns_ares_maybe_start_resolving_locked                                           -196  [DEL]
     -13.2%     -72 dns_factory_create_resolver                                                      -72 -13.2%
      [DEL]     -48 dns_ares_on_next_resolution_timer_locked                                         -48  [DEL]
      -1.9%     -32 dns_ares_on_resolved_locked                                                      -32  -1.9%
     -15.8%     -23 [Unmapped]                                                                       -23 -15.8%
 -10.9%    -256 src/core/ext/filters/client_channel/resolver/dns/native/dns_resolver.cc         -256 -10.9%
      [DEL]    -188 maybe_start_resolving_locked                                                    -188  [DEL]
     -24.5%    -120 dns_factory_create_resolver                                                     -120 -24.5%
      [DEL]     -45 dns_on_next_resolution_timer_locked                                              -45  [DEL]
     -16.0%     -33 dns_start_resolving_locked                                                       -33 -16.0%
  -0.6%     -64 src/core/lib/iomgr/ev_epollex_linux.cc                                           -64  -0.6%
      -7.0%     -60 pollset_set_add_pollset                                                          -60  -7.0%
      -1.2%      -4 [Unmapped]                                                                        -4  -1.2%

  -0.1%   -1024 TOTAL                                                                        -2.01Ki  -0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +24  +0.0%

  [ = ]       0 TOTAL      +24  +0.0%

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences


[VL] Hide symbols defined by gflags for libvelox.so

What changes were proposed in this pull request?
This is a follow-up pr for this comment.
If not hidden, the below error can be reported when running gluten CPP test.
something wrong with flag 'velox_memory_num_shared_leaf_pools' in file '/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/flag_definitions/flags.cpp'.  One possibility: file '/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/flag_definitions/flags.cpp' is being linked both statically and dynamically into this executable.
CMake Error at /usr/local/lib64/python3.9/site-packages/cmake/data/share/cmake-3.28/Modules/GoogleTestAddTests.cmake:112 (message):
Error running test executable.

  Path: '/__w/incubator-gluten/incubator-gluten/cpp/build/velox/tests/velox_shuffle_writer_test'

velox_memory_num_shared_leaf_pools is declared in Velox under google namespace. See DEFINE_int32 used by this velox code. Even though local: *; is defined for version script, we have to explicitly make all symbols under *google::* namespace hidden. The possible reason is that the specified global *facebook::velox::* symbols cover those *google::* symbols.
How was this patch tested?
CI.

@zml1206, could you take a look? This is a follow-up for a comment in your merged pr.

Just found some other issue. Let's hold on.

This pr once intended to use one same symbols.map set for version-script in both static build and dynamic build. But it seems we cannot achieve this. For static build (with vcpkg), the below symbol patterns need to be put inside extern "C++" block. But for dynamic build, they should be moved out from this block. Otherwise, symbol conflict issue will be reported when running gluten cpp tests. One possible root cause is the use of different linking tool or linking options.
local:
    extern "C++" {
      *fL*::*;
      *google::*;
    };

As currently dynamic build has no symbol conflict so far, let's simply exclude the use of symbols.map in this build path.


Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails

Steps to Reproduce

Load Multi-Tailed Arrow from KET
multi-tailed-arrow-4-tails-minimal-distance.zip

Try to move the middle tails which are intersected with the top and bottom tails because of the distance = 0.01

Actual behavior

Tail is moved to the nearest available place, "TypeError Cannot read properties of undefined (reading 'center')" appears in the console:

Expected behavior
No issues in console, MTA should be automatically expanded to a minimal size on the UI
TBD - Confirm with PO
Environment Details

Tested on Nightly env
Ketcher [Version 2.26.0-rc.1] Build at 2024-10-16; 06:55:14
Indigo Version 1.26.0-dev.1.0-g2edd615c1-wasm32-wasm-clang-19.0.0
Desktop, Windows 11 Enterprise
Chrome Version 129.0.6668.101 (Official Build) (64-bit)

Additional context

Issue is introduced during testing of changes for minimal sizes - https://github.com/epam/ketcher/issues/5761 and related to https://github.com/epam/ketcher/issues/5104

Need merge into 2.26

Tested. Bug fixed.
https://github.com/user-attachments/assets/79e6304a-0f8e-4d95-9ccc-040794d866ba
Desktop:

OS: Windows 11
Browser Chrome
Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.6]
Indigo version
[Version 1.25.0-rc.4]


Mh temporal gobblin 1915

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #11 (91910a5) into master (a289613) will decrease coverage by 1.19%.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
- Coverage     47.31%   46.12%   -1.19%
+ Complexity    10956     2182    -8774
============================================
  Files          2152      416    -1736
  Lines         85114    17987   -67127
  Branches       9452     2191    -7261
============================================
- Hits          40271     8297   -31974
+ Misses        41190     8809   -32381
+ Partials       3653      881    -2772

see 1739 files with indirect coverage changes


Add Solo Machine Contents

Add Solo Machine contents with the examples under Resources.
Signed-off-by: Anthea<EMAIL_ADDRESS>

/staging


Array Docs - example for find uses assignment operator, not comparison operator

The docs for Array.find use the wrong operator in the example.
Current:
users.find(function(user) {
  return user.name = 'Harry';
});

Should be:
users.find(function(user) {
  return user.name == 'Harry';
});

Good catch! Thanks will fix.

We're using sugarjs extensively and loving it, please let me know if there's something I can do to help with this project.

Happy to hear it! Will let you know!

Updated! Thanks!


fixed issue #1564,#1716,#1718,#1771 - [closed]

In GitLab by @liyanq528 on Dec 11, 2018, 03:01
Merges 20181006 -> dev

In GitLab by @wknet123 on Nov 13, 2019, 11:33
The test coverage for backend is 21.8%  %  , check  console log

In GitLab by @wknet123 on Nov 13, 2019, 11:33
The test coverage for backend is 21.8%  %  , check  console log

In GitLab by @wknet123 on Nov 13, 2019, 11:33
The test coverage for backend is 20.7%  %  , check  console log

In GitLab by @wknet123 on Nov 13, 2019, 11:33
closed


Poor rendering

https://github.com/user-attachments/assets/77909fd5-e27b-428c-adb9-fb68e7e9e2d3
https://github.com/user-attachments/assets/7cdbd6f8-fc70-4194-8843-56123fe32ac8
How do I zoom in to get in the scene and make it better quality

Hi，is it under the multiview setups? can you show me a GT video?

series of these images captured in a studio

Hi，is it under the multiview setups? can you show me a GT video?

it is in multiview

I don't think it's normal.
I think you can check the initialized point clouds first. And check this to check the initialization of the deformation field, which could correspond to the size of the bounding box.

input "points3D_multipleview
and output point_cloud


Add ToObservableCollection to LocalView so that it can be used for data binding

Issue #7397
In EF Core, DbSet.Local is a pure view over the state manager. This is much more efficient for normal local queries, etc., but doesn't work for data binding because it does not preserve order or maintain indexes. This change adds DbSet.Local.ToObservableCollection() which creates a less efficient but maintains order and indexes.

I wondering if we should consider implementing IListSource and BindingList<T>. Probably none of this is urgent.

@divega Do you mean implementing on some other class in addition to what we already have?

Since this is a minor breaking change I would love to get it into preview2. @divega Did you review this? Could someone else look at it? @smitpatel @bricelam @AndriySvyryd @anpete

@ajcvickers I meant IListSource on .Local and binding list in a different class. I can create a new issue to review how what we have works with different flavors of data binding.

Sure, we should review what we have.


Very slow compilation of SDXL model

Hi,
Very slow compilation of SDXL model (on first run). It takes 7 minutes (RTX 4060 16GB), while it compiles SD1.5 model faster than a minute. Is this normal or is something wrong?

I met the same problem: It's very slow to load both SD and SDXL (slower) on its first run.


_5etools: init at 1.175.2

Description of changes
A suite of browser-based tools for players and DMs of D&D 5e. https://5e.tools
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1804

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1865


Adding a scenario for revoking signatures

Signing means different things to different people. To some, it only means this artifact was produced by an entity. But to others it conveys that the signer has attested some qualities to the artifact, typically that the artifact is secure. Since the security of an artifact is mutable with the discovery of new vulnerabilities, we should also have a way to modify our trust in that artifact over time.
As a simple example, if a major CVE is discovered in an image, it should be possible for the signer to revoke that previous trust and force notary users to upgrade to a secure version of that image.
Signed-off-by: Brandon Mitchell<EMAIL_ADDRESS>

I think what your suggesting is this:
An author of content identifies they have identified what they perceive as an issue with that content. net-monitor:v1@sha256aaa After the fact, as they woudln't knowingly publish something bad.
They publish net-monitor:v1.1@sha256bbb, which they may also update tag :v1 to point to the new digest.
While Wabbit Networks decided :v1@sha256aaa is invalid, ACME Rockets found they can't run :1.1 as it has some incompatibility in their environment, and won't run.
To ACME Rockets, digest aaa works, and digest bbb doesn't, so they don't actually want aaa to be considered invalid.
But, what I do think could solve your problem is a forwarding update.
First, let's assume wabbit networks publishes the update to :v1 - net-monitor:v1@sha256bbb
If ACME is pulling on tag, they'll see the update, and can determine if they want to move forward, as they hopefully have a gated-mirror in their environment to cache the artifacts they depend upon in their environment.
But, for those that may deploy on digests: net-monitor@sha256:aaa what if a registry could identify a forwarding:
Let's say you could add a linked artifact (signed of course), that says net-monitor@sha256:aaa has been updated to net-monitor@sha256:bbb. Kind of like a parts replacement in the manufacturing industry.
What I'm mostly getting at is:

revocation should be when a signing key was truly stollen and used for evil purposes. Anything ever signed with that key should be considered invalid.
we should support a forwarding concept, where the content is still valid (not hacked), just has something that may not be desirable, and thus, there's a new version, that doesn't have that problem, but likely has a new problem we'll discover next month.

@SteveLasker Capturing some of the comments from our weekly meeting here:

To ACME Rockets, digest aaa works, and digest bbb doesn't, so they don't actually want aaa to be considered invalid.

When companies pull ingest external artifacts into their own registry, they would check the upstream signature at the time of ingesting, and then resign the artifact with their company signature. From that point forward, internal verification would happen against the company signature rather than the upstream, allowing the company to have their own policy of when they consider revoking the signature on an artifact, separate from the upstream policy.

But, for those that may deploy on digests: net-monitor@sha256:aaa what if a registry could identify a forwarding:
Let's say you could add a linked artifact (signed of course), that says net-monitor@sha256:aaa has been updated to net-monitor@sha256:bbb. Kind of like a parts replacement in the manufacturing industry.

I think that would expand the scope of notary more than we want. I'd like to keep this one simple, just at revoking a single signature without impacting everything else the signer has also signed.

What I'm mostly getting at is:
* revocation should be when a signing key was truly stollen and used for evil purposes. Anything ever signed with that key should be considered invalid.

This is a bit of a nuclear option. I think there's a value in being able to take back an accidental signature on an artifact when you sign the wrong thing without invoking a full key revocation and resigning of every other asset you previously signed.

* we should support a forwarding concept, where the content is still valid (not hacked), just has something that may not be desirable, and thus, there's a new version, that doesn't have that problem, but likely has a new problem we'll discover next month.

Allowing upstream to impose their opinion on what downstream users should use in place of another digest can be very problematic, especially if those users expect an immutable response to pulling by digest. The best option to me is telling the user the digest they are pulling is not trusted by the signer, even if it used to be, and leaving the decision on what to do (run the image anyway, rollback, upgrade) up to the downstream user.

what if a registry could identify a forwarding:
I think that would expand the scope of notary more than we want. I'd like to keep this one simple,

I'm all for KISS. Just trying to figure out the problem/requirement, then focus a design that matches. While we should absolutely support deleting anything in a registry, including signatures, I wonder if we really need a revocation. If a clients can "sync" with another registry, and they pulled the wabbit networks signature, which was then deleted, they should be able to track the deletes, and cascade the deletes to the mirrored replica. Although, I fully recognize we don't have a tombstoning solution in registries today.

This is a bit of a nuclear option.

If we're tying revocation of the key for the deletion of a signature, I agree. Just not sure how to think about revoking a signature, vs. delete.
I like to model solutions to problems around other solutions to similar problems, even if in a completely different industry. Building occasionally connected software, I modeled around store and forward water and food supply systems. You always have a buffer, when (not if) something fails.
For this revocation scenario, which may not really be a revocation, rather a hint that there's a newer version, I'm just thinking there's something about the replacement parts concept. You can use this part # if you really want it, and have it. But, here's the newer part # that you may really want.

Allowing upstream to impose their opinion on what downstream users should use in place of another digest can be very problematic, especially if those users expect an immutable response to pulling by digest. The best option to me is telling the user the digest they are pulling is not trusted by the signer, even if it used to be, and leaving the decision on what to do (run the image anyway, rollback, upgrade) up to the downstream user.

So, just riffing on this a bit. If you revoke the signature, isn't that an even stronger opinion? It's basically saying, I built this thing, at a point and time. And now I want to revoke that (oops). Rather than revoke, what if there was a forwarding, with a possible severity? You can either say (critical forward, informational forward, or some other grammar). It then expresses the intent with more granularity. The issue is I don't know how to imply "trust". We must assume that all software has some amount of vulnerabilities. Some known, some unknown until a later period of time. Since the only non-vulnerable software is an empty container, the level of vulnerabilities must be left to the owner to determine how it impacts them.
Of the long list of vulnerabilities, how many of them really fall in that critical category? It's critical we support the critical vulnerability issues, but how do we support the majority of issues that are more opinionated for the consumer?

So, just riffing on this a bit. If you revoke the signature, isn't that an even stronger opinion? It's basically saying, I built this thing, at a point and time. And now I want to revoke that (oops). Rather than revoke, what if there was a forwarding, with a possible severity? You can either say (critical forward, informational forward, or some other grammar). It then expresses the intent with more granularity.

Revoking a signature just says that the signer no longer trusts a specific image. We're leaving it up to the end user where they go from there. Adding a forwarding to another image breaks the trust that when I pull by digest that the object pulled will never change. It also feels like an additional attack vector to me, an attacker finds a way to create a forwarding policy to a vulnerable image that goes unnoticed since the original digest is unchanged and all the image references look the same.

The issue is I don't know how to imply "trust". We must assume that all software has some amount of vulnerabilities. Some known, some unknown until a later period of time. Since the only non-vulnerable software is an empty container, the level of vulnerabilities must be left to the owner to determine how it impacts them.
Of the long list of vulnerabilities, how many of them really fall in that critical category? It's critical we support the critical vulnerability issues, but how do we support the majority of issues that are more opinionated for the consumer?

Trust is always going to be between the signer and the verifier. Notary v2 doesn't need to define "trust" but it should provide the signer a way to provide something that can be trusted. Once we provide the tools, it's up to the signer to decide what situation would warrant revoking a signature, if ever.
To add a recent situation, I heard that Solar Winds still hasn't revoked their signing keys for malicious code they signed and shipped. Because if they do so, all of the other good code that they've shipped and that's currently running would also end up being revoked. So they have to get all of the old releases resigned, and get clients to update things on their side, to be able to revoke those keys without causing a disruption.
Why not just delete the signature on the registry? First, that implies the registry can be trusted, and if we started with that assumption, Notary wouldn't be needed. With the ability to clone repos, I could see deletes not getting cloned. Why not? What's to say the signature you don't see upstream wasn't locally created in the clone to add a local signature, if ACME clones Wabbit's images locally, the ACME signature won't be seen upstream. What if there's a DoS attack or poor network connectivity to upstream that causes updates to fail? But my biggest concern is what if there's a poorly secured local mirror? With Notary, if we can trust the signature, we have a cryptographic assurance the content can be trusted even if the registry is hacked, we don't even need HTTPS. But that only works if attackers can't easily replay stale data, and it would be useful if Notary could prevent that, similar to what we want with tag signing, but applied to not just tags but also digests.

Here's the reference to the post on the SolarWinds revocation issue: https://www.solarwinds.com/sa-overview/new-digital-certificate. Looks like it might have been revoked as of March 8th, I don't see any updates in that post though.

Adding a forwarding to another image breaks the trust that when I pull by digest that the object pulled will never change.

The forwarding info is just info. It says, this artifact has been replaced. Whether the original is considered vulernable is a different dimension a scanning solution would determine. There's nothing stating it can't be used, just like finding the original part. If the original part is still considered safe and is found, it can be used. If you're looking for thew newer version of "the part", here's a pointer to it.

It also feels like an additional attack vector to me, an attacker finds a way to create a forwarding policy to a vulnerable image that goes unnoticed since the original digest is unchanged and all the image references look the same.

The forwarding info would need to be signed, to be just as trusted as all other content.
BTW, these are just ideas for how we might cope with some of the "versioning" scenarios as I'm suggesting the majority of content isn't versioned in a serial stream.

We revisited this in the 6/11 meeting, and it looks like it should be ready to merge, especially in light of the implementation discussions around revoking signatures. @justincormack or @SteveLasker would you be willing to merge?

I've rebased and squashed so this should be ready to merge again. @gokarnm, @shizhMSFT, and @NiazFK, PTAL.

@gokarnm I've updated with feedback from our discussion on Friday. PTAL.
The only change I didn't make was to revoke trust in an entire artifact rather than only the signature on the artifact. Thinking more about it, I could see that as being a potential DoS attack, where a malicious actor gets access to register new signatures using an arbitrary (likely untrusted) key, and then revokes that trust. If that revoked the entire artifact's trust, it would deny clients the ability to use a signed artifact verified by a key they do trust.

@gokarnm, @NiazFK, @sudo-bmitch, @mnm678, can you provide your review if this is ready for merge?

@gokarnm, @NiazFK, @sudo-bmitch, @mnm678, can you provide your review if this is ready for merge?

LGTM :)


Unable to manually add a new artifact via editor

When creating a NEW artifact manually after selecting the set all other sets disappear from the drop down and you cant close the drop down. Clickout out of the drop down results in no selection being made.

fixed in https://github.com/frzyc/genshin-optimizer/releases/tag/8.20.1


kubeadm reference pages Synopsis header not rendered correctly in v1.18 of reference docs

This is a Bug Report

Problem:
When viewing kubeadm pages in the v1.18 reference docs, the "Synopsis" heading is not generated and instead, the following is shown:

Synopsis

I think the synopsis text is rendering, just the header is not
Proposed Solution:
Fix page rendering
Page to Update:
https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-init/
https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-join/
https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-upgrade/
...
etc (all of the kubeadm reference pages)

Kubernetes Version
1.18.  Earlier versions of the reference (1.17 and earlier) do not seem to have this problem.

/sig cluster-lifecycle docs
/priority important-soon
cc @tengqm @sftim

/kind bug

Hi @brianpursley .
Yes, this is a result of the recent Markdown parser switch.

Relevant to issue #20335
I'd have put this one as priority important-longterm; the bug is only cosmetic.

Agreed, it is not a major issue. I was just reading the kubeadm docs and noticed it. Feel free to close if this is tracked elsewhere.

/remove-priority important-soon
/priority important-longterm

BTW #20335 is an umbrella issue

I believe the mentioned pages are all fixed. Please feel free to reopen if there are still such issues.
/close


Added my name to the file

Hey I would like to merge.


api/v1/label/name/values does not return return values from remote read

Proposal
Use case. Why is this important?
If samples have been written to a remote and not via prometheus, then the labels are not returned in the api. This causes an issue for autocompletion in the prometheus UI and other tools such as Grafana.
Bug Report
What did you do?

Inserted samples directly into a Postgres + TimescaleDB remote database (to get around the data too old issue).
Used prometheus UI to search the data
Data can be queried, if the sample name is keyed in full

What did you expect to see?

Autocomplete to include the same name in the list

What did you see instead? Under which circumstances?

Sample name wasn't included

Environment

System information:

Linux 4.14.133-88.112.amzn1.x86_64 x86_64
Running prom/prometheus docker image

Prometheus version:

prometheus, version 2.13.0 (branch: HEAD, revision: 6ea4252299f542669aca11860abc2192bdc7bede)
build user:       root@f30bdad2c3fd
build date:       20191004-11:25:34
go version:       go1.13.1

Alertmanager version:
N/A

Prometheus configuration file:
N/A

Alertmanager configuration file:
N/A

Logs:
N/A

auto complete
The autocompletion feature relies on the labelValues interface. By default, this interface of remote storage is empty, and it can be implemented.
Our team maintains its own code branch, and in this branch we implement the autocompletion feature by implementing the labelValues interface.

When we implement the labelValues interface, we need to complete the query based on the specific syntax in the specific TSDB selected by remote storage.

@brian-brazil @roidelapluie
labelvalues endpoint

I think this is a duplicate of #3351

Hello from the bug scrub.
We close this as a duplicate #3351.


Are there any major downsides to creating a redux store for testing?

Let's say I've got a counter application, I could just create the "fake" store in one file. And import it to my tests.
FakeStore.js
CounterTests.js

// in CounterTests

import Store from './FakeStore'

let expected = {
count: 2
}
Store.dispatch(counterAdd())
expect(expected).to.eql(CounterSelector(Store.getState()))

To me it seems that with this approach and a localhost server running you can test every part of your redux logic and the only untested part would be the components and containers.

Please ask usage questions on StackOverflow. The counter and todomvc examples in the examples folder show how to test different parts of Redux apps. I'm not sure what's being asked specifically here.


Correct data type for (numeric) values

Values from (numeric) placeholders should probably be converted to an int or float, they are currently a string when they are passed into the controllers.

It looks like I have a nasty solution, but I blame php for this :) Have a look at 5ee145c5e4ef8a658173b97f82d7ffbbc607139d
I would appreciate a code review.

I have some suggestions here, we can talk about this tomorrow.

Sure, my suggestion isn't so big


Highlighted HTML from pygmentize-bundled is not output

Code that reproduces the problem:
var MarkdownIt = require('markdown-it');
var pygmentize = require('pygmentize-bundled');

var md = new MarkdownIt({
  html: true,
  linkify: true,
  highlight: function(str, lang) {
    pygmentize({ lang: lang, format: 'html' }, str, function(err, result) {
      return !err ? result.toString() : '';
    });
  }
});

console.log(md.render('```python\n' +
'print("Hello world!")\n' +
'```'));

Expected output: HTML with pygmentize spans and classes inside a code block.
Actual output: Plain text inside a code block.
Pygmentize itself returns escaped HTML. Am I missing something here?

https://github.com/markdown-it/markdown-it#syntax-highlighting
Hightlighter MUST be sync. For async processing you need to chain manually parse + highlight + render.

D'oh! That would make sense. Thanks.


opm alpha bundle generate  does not target manifests directories

https://github.com/redhat-openshift-ecosystem/community-operators-prod/blob/ef73c7f08d0ab33ca0a10013de15a8cbf7e238a2/ci/prow/openshift-deploy-core.sh#L195
Shouldn't this line target the manifests subdirectory of the operator bundle?  The example formats given in most of the operator-registry documentation and the opm alpha bundle generate help files would seem to indicate this.
  -d, --directory string     The directory where bundle manifests for a specific version are located.
@mvalarh This may be the issue with my PR.

Would this issue have caused the grafana-operator to have disappeared from the community-operators ? Building an OKD4.8 cluster using " - image: registry.access.redhat.com/redhat/community-operator-index:v4.9" and the grafana operator no longer appears.


Provide CMMN modeling

Beside bpmn and dmn the Camunda Modelers allows cmmn modeling

Wasn't this planned for Q2 2016 (I believe i saw in blog post) ?

We are not sure when it will be released, but yes, it is in our roadmap.

:cake:

Done: https://blog.camunda.org/post/2016/05/camunda-modeler-cmmn-modeling/


improve README

update to latest MAAS release (3.3)
add instructions to install Ansible on Jammy
add note about DB data preserved in the nodes after a teardown

jenkins: !test


Item Carousel Widget is broken for MVWs

Summary
Elements within the Item Embed carousel widget are not functioning at all or not behaving in the expected ways.
Impact
DPUL builder currently working on a forthcoming exhibit is unable to use the widget that was to be on the homepage of their exhibit. several DPUL exhibits use this same format, implementing item carousel on homepages (i.e. the first page a visitor sees).
Priority recommendation

[ ] asap
[x] within the next 3 weeks
[ ] PO will priotize

Expected behaviour

Add Item within widget from dropdown
Item comes up with thumbnail to left and pages at bottom to change/chose from for carousel.
Item may be removed by clicking "remove" to the right of the bar containing the selected item within the widget
Item is crisp and may be viewed clearly by users in item carousel in front end

Actual behaviour

Add Item within widget from dropdown
Item comes up but not always with thumbnail to left and not always with pages at bottom to change/chose from for carousel (I believe the MVW in this instance is making making the widget die a slow death).
Item may not be removed by clicking "remove" to the right of the bar containing selected item within the widget and in many instances DPUL becomes unresponsive
Item is blurry and illegible in item carousel in front end

Steps to reproduce behaviour

Go to https://dpul.princeton.edu/happy_gall-entines_day
Enter edit mode
Select "Item Carousel" Widget
Start Adding items from the drop down - The red volume (the MVW) will freeze the system immediately. If you exclude it from the options, the item behaves as expected until you try to remove the item from the carousel list and when you view the fuzzy result in the front end after you save).

Screenshots

Sudden Priority Justification
The carousel is a primary showpiece of a number of our collections. Exhibit creators can't make new exhibits the way they'd like to without it. In this particular case they'd like the exhibit live by valentine's day.

Just checking in on this on, @tpendragon .

It's prioritized for the maintenance cycle this week.

Example of a collection that has a working one (from before bug): https://dpul.princeton.edu/gnib

hi, @hackartisan ! Same thing happening again, I think. Im reopening this ticket, but Im happy to make a new one. Natalie and Fernando are having the same problem on the home page of:
https://dpul.princeton.edu/lae-dig-microfilm

hard deadline: this has to be ready for a conference fernando is attending in June of this year.

full_image_url_ssm is configured for the autocomplete json response, but is not included in the field list for the query sent to solr:
"fl"=>"id full_title_tesim thumbnail_ssim content_metadata_iiif_manifest_field_ssi",

We found that non-MVWs have a value for iiif_tilesource once they're saved by trevor, but MVWs do not. This makes https://github.com/projectblacklight/spotlight/blob/main/app/views/spotlight/sir_trevor/blocks/_solr_documents_carousel_block.html.erb#L13 work for non-mvws, and a larger image is displayed. Note that neither is getting the full_image_url value.
That all happens in https://github.com/projectblacklight/spotlight/blob/main/app/javascript/spotlight/admin/iiif.js
But it seems too hard to make that work for MVWs. We're already doing it on the ruby side, so let's use what we already have.
Plan:

write a test on the autocomplete endpoint to ensure it returns a full_image_url. Maybe add something around https://github.com/pulibrary/dpul/blob/403a9311d1ec21d1544588fcc5ad1e4ed5c8fa4e/spec/features/catalog_spec.rb#L66
Make autocomplete return full_image_url_ssm by setting the field list in the initializer. Add a fl to the setting as seen in https://github.com/projectblacklight/spotlight/blob/a29b6bd3dc1e97fcc8f49a0273c90516af4d3f49/lib/generators/spotlight/templates/config/initializers/spotlight_initializer.rb#L32
Index the full image url at a slightly larger size. see https://github.com/pulibrary/dpul/blob/403a9311d1ec21d1544588fcc5ad1e4ed5c8fa4e/app/services/iiif_manifest.rb#L43-L47


Apply fmt and clippy

Codecov Report

Merging #108 into master will decrease coverage by 0.18%.
The diff coverage is 86.48%.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   96.14%   95.95%   -0.19%
==========================================
  Files          12       12
  Lines        1479     1484       +5
==========================================
+ Hits         1422     1424       +2
- Misses         57       60       +3

Impacted Files
Coverage Δ

src/lib.rs
92.3% <ø> (ø)
:arrow_up:

tests/decode.rs
100% <ø> (ø)
:arrow_up:

tests/tests.rs
98.83% <ø> (ø)
:arrow_up:

src/tests.rs
100% <ø> (ø)
:arrow_up:

src/chunked_encoder.rs
98.78% <100%> (ø)
:arrow_up:

src/write/encoder.rs
88.88% <100%> (+0.1%)
:arrow_up:

src/write/encoder_tests.rs
94.66% <75%> (-1.01%)
:arrow_down:

src/encode.rs
98.03% <80%> (ø)
:arrow_up:

src/decode.rs
94.4% <88.88%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e90f80...f788483. Read the comment docs.


Loading part of the model using one GPU

I plan to measure the latency and other performance metrics of a model using high-level Tensor Parallelism. However, when using TensorRT-LLM, I have to run the model using all GPUs.
Is there a way to either:
Convert the HF checkpoint to TensorRT-LLM format for just one slice of the model,
or
Run the model by loading one slice on one GPU?

No, it will crash if you build engine for more than 1 GPU but only use 1 GPU

No, it will crash if you build engine for more than 1 GPU but only use 1 GPU

You can use --workers to specify the number of worker processes to build the engine.
such as tp_size = 4, workers = 1

I mean to perform real inference serving using a part of the model on a single GPU, not to build the engine.
For example, if I build Llama-70B with tp = 8, can I eventually run it with mpirun = 1 instead of 8?
I don't need the output; I just want to know the end-to-end latency of this part of the model on this GPU. This is how I intend to test the performance of a slice of the model.

I mean to perform real inference serving using a part of the model on a single GPU, not to build the engine.
For example, if I build Llama-70B with tp = 8, can I eventually run it with mpirun = 1 instead of 8?
I don't need the output; I just want to know the end-to-end latency of this part of the model on this GPU. This is how I intend to test the performance of a slice of the model.

TRT-LLM does not support this feature currently.


Insecure Content Warning

Using react-player on a https site with Wistia I get the following error:

Mixed Content: The page at 'https://www.speedwright.com/' was loaded over HTTPS, but requested an insecure resource 'http://fast.wistia.com/embed/iframe_shim?domain=com'. This request has been blocked; the content must be served over HTTPS.

My code:
<ReactPlayer
className={styles.reactPlayer}
url="https://speedwright.wistia.com/medias/17luu6ucce"
// playing
width="100%"
height="100%"
/>

Please close, the issue was in a react prerenderer.

@cookpete How to solve problem? I used Next.js and got same problem.


Update Custom-ROS2-Interfaces.rst

fix over-indented

@Mergifyio backport iron jazzy rolling

This was fixed in Rolling by #4586.


Modernize PowerModule and fix reboot.

Reboot doesn't work, I previously built a version where it did work prior to it updating for iOS 13. That is now broken, and I wish to bring it to the public version. It's a pain to use my own repo for it, please consider merging this.

Also changes respring to sbreload.


TTV Fitting With Jaxoplanet?

Thanks for the updated documentation regarding jaxoplanet lately! I will preface by saying I am a relative beginner to jax+jaxoplanet but have experience with pymc5+exoplanet. I was just checking if jaxoplanet supported any transit timing fitting analogous to exoplanet's TTVOrbit? I cannot find anything similar so was not sure if this is because the functionality has not been added yet/there are other ways to solve this using jaxoplanet or if pymc does a "better job" for this problem.
The alternative solution is obviously using TransitModel while fitting for each transit time, but I have typically avoided this in the past due to the high independent random variates this creates (i.e. tt1, tt2, ttN rather than one tt with dim=N). Is there an intended vectorization approach such as using jax.vmap over all transit times?
Many thanks,
Tyler

Hi @TylerFair and thanks for raising this point! The functionality has not been added yet. I would have a look to implementing that asap!


Update openssl-probe to 0.1.1

This helps find ssl certificates on termux (android). Contribute to https://github.com/rust-lang-nursery/rustup.rs/issues/1058

Is there a way to get this build for aarch64-linux-android? I would like to give it a test.


Changes to be committed:

new file:   lib/domains/com/pristineschool.txt
Website: https://pristineschool.com
To add Pristine Private School of Dubai to swot

@LexiCodesOfficial First stage of verification passed, official domain for Pristine Private School is pristineschool.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@LexiCodesOfficial Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


Project spec as YAML/JSON

Purpose
I'd like to confirm / create services from a json something along the lines of
{
  "environments": [
    {
      "name": "production",
      "plugins": [
        {
          "type": "postgres"
        },
        {
          "type": "redis"
        }
      ]
    }
  ]
}

I was thinking the same thing!
But take a look at Digital Ocean app spec as it is about the same type of setup.
And in DO you can copy or download the file/spec to use it.
Maybe change the title of this issue to "Project spec as YAML/JSON"?

I was thinking the same thing! But take a look at Digital Ocean app spec as it is about the same type of setup. And in DO you can copy or download the file/spec to use it, super easy to spin up an existing stack to a new project. Maybe change the title of this issue to "Project spec as YAML/JSON"?
This would also open up the platform for a range of uses and short comings that the templates dont address today.

That's a great idea, updated the title!
Yeah something similar to the digital ocean spec would be great

This would also open up the platform for a range of uses and short comings that the templates dont address today.

Can you list these shortcomings?

Sure can.
The template system today is only made for sharing a stack with other people, that also means that they have to clone the repos on init to use it, not just use it as is. It also only deals with the init of a project, no update/deleting/adding items in the stack.
I think the template is good for it's specific use case, but it is too narrow to do more with the platform.
With a project spec you can have the template on top of that, using the spec as a staring point and then change varies settings/items in one move. As of now you cant copy an existing stack, i have to make the same stack manually every time.
Let's say i have made a product i'm selling and i have 4 items in the stack of that product: web, cli, db and cache. I cant make this with the template as it clones the repo and i cant change it over time. And since there is no api at this time i cant really change the stack later down the line, i have to do it via the control panel.
A project spec solves a lot of things and makes the use cases for the platform larger in my opinion, maybe things i cant even see at this point.
It is a good reason that Digital Ocean implemented this on the app platform, usability and complexity in on go. You can go as narrow or wide as you like with it.

This is indeed something we are looking at adding to Railway. But it spans much more than just the CLI. I'm going to close this issue here and recommend that you follow along with the feature request on Canny for updates
https://railway.canny.io/feature-requests/p/infrastructure-as-code


TPCH Query 18 has wrong o_orderdate result

       |SELECT
       |    c_name,
       |    c_custkey,
       |    o_orderkey,
       |    o_orderdate,
       |    o_totalprice,
       |    sum(l_quantity)
       |FROM
       |    customer_ext,
       |    order_ext,
       |    lineitem_ext
       |WHERE
       |    o_orderkey IN (
       |        SELECT
       |            l_orderkey
       |        FROM
       |            lineitem_ext
       |        GROUP BY
       |            l_orderkey
       |        HAVING
       |            sum(l_quantity) > 300)
       |    AND c_custkey = o_custkey
       |    AND o_orderkey = l_orderkey
       |GROUP BY
       |    c_name,
       |    c_custkey,
       |    o_orderkey,
       |    o_orderdate,
       |    o_totalprice
       |ORDER BY
       |    o_totalprice DESC,
       |    o_orderdate

日期数据可能在shuffle传输过程中存在问题

fixed


Don't ignore UI scale for text

Objective
Fixes #7476. UI scale was being incorrectly ignored when a primary window exists.
Solution
Always take into account UI scale, regardless of whether a primary window exists.
Tested locally on @forbjok 's minimal repro project https://github.com/forbjok/bevy_ui_repro with this patch, and the issue is fixed on my machine.

bors r+


Add checkpoint and certificate serialization

The stable checkpoint can be now deterministically serialized and deserialized.
The certificate can be added to and removed from the checkpoint.

Out of a curiosity, why did you start the PR from your fork instead of using a branch of the mir repo directly?

I always do it that way because I find it cleaner, not polluting the main public repo with extra branches. And we don't loose anything in terms of collaboration, since others can still push to the PR branch, even if it is in my repo.


ERROR: readstream not defined

I'm attempting to process a CSV file in a streaming manner as described here:
http://juliastats.github.io/DataFrames.jl/datastreams.html
Here's the output:
--- snip ---
julia> using DataFrames
julia> ds = readstream("foo.csv")
ERROR: readstream not defined
--- snip ---
I'm running Mac OSX 10.9.4 and Julia 0.3.0

Closing (not in the docs any longer).


eTicket

Type of issue
Missing information
Description
Configurations do not contain a definition for ,'GetConnectionStrings'
[Enter feedback here]
Page URL
https://learn.microsoft.com/en-us/dotnet/csharp/misc/cs0117?f1url=%3FappId%3Droslyn%26k%3Dk(CS0117)
Content source URL
https://github.com/dotnet/docs/blob/main/docs/csharp/misc/cs0117.md
Document Version Independent Id
fefbef5d-bc47-9458-1ba5-86388d2c251a
Article author
@BillWagner
Metadata

ID: b1c7d191-7c09-0bd8-32b2-527748c41882
Service: dotnet-csharp
Sub-service: errors-warnings

Related Issues

Hi @Randy-boop-debug
Is there more information you were looking for here? I can't see anything to add in this article from your description.


DEID Prep GET config list returns more than just  list of DEID config files

For a newly deployed DEID Prep service, I attempt to get a list of configurations via:
https://test-enrichment-enrich-deid-prep.wh-health-patterns.dev.watson-health.ibm.com/config
The list I get back is:
run-java.sh
default
quarkus
app
quarkus-run.jar
lib
I am expecting to see just "default" in the list.  The other items in the list are not stored configurations.

This bug still exists in the deid-prep service.  Verified on an enrich deployment on 5/3/2022.


Descoped tests and documentation for v1.8.0

[ ] Fully cover all paths for is_cancellation method.
[x] Update docs for /transactions/<safe_address>/propose endpoint

https://github.com/gnosis/safe-client-gateway/wiki/transactions_proposal


Proposal: Implement an 'ItemHovered' event

Proposal: Implement an ItemHovered event
Summary
An event that is invoked whenever a ListView's item is hovered.
Rationale

Now it's only possible to set the style of hovered items, it would be great if there was a public event that gets called whenever an item is hovered. This would allow programmers to add more on-hover-features (item preview, select-on-hover, ...)

PointerEntered and PointerExited can already be used.

I know, but when I opened this issue I was having troubles with these events, because of their activation-area.
Now I found a way around the problem.


Allow usage of node v0.4 in package.json

When you ported node-syslog to node v0.5.7, you set node >= v.0.5.7 as a requirement in package.json https://github.com/schamane/node-syslog/commit/d3c2014a52795a77b4969dd374df753b47aaa8e1#L3R9
After you made it working again under 0.4, you forgot to mark that in package.json https://github.com/schamane/node-syslog/commit/bcf98461022001f31361927875ba3528dd6a6461

The 1.1.0 version was mentioned to be working only with 0.6 :D But i think its safe enough to allow it compile against 0.4.
Thanks for your pull request. I will merge it.

thx for the fast merge, can you please republish this package?

Yes, i was already thinking about this. We need to bump version i think. Or i force update without version change. What do you think?
I will republish npm in a few hours.

imho you should create a new version

Created and published. Thanks again for support.


CLI Upgrade command missing

The CLI upgrade command is missing from the docs.

Write a topic for upgrade
Update the overview list and screen shot in the https://v1-rc3.docs.dapr.io/reference/cli/cli-overview/ topic
Update the getting started page https://v1-rc3.docs.dapr.io/getting-started/install-dapr-cli/

Can use content for the above from here https://v1-rc3.docs.dapr.io/reference/cli/cli-overview/

Resolved. Closed


Overlay content type selector for quick sub (rather than full page)

not priority. will mockup later if needed.


Move structure generator into chime repo #269

moved generator plug-in from chime-starter to this repo
compiled the plug-in into a gem and import it on run in run-jekyll.sh
also importing the _config.yml file at the sample site's root

Closes #269

@wpietri could you double-check and merge?

Looks good. Normally in Ruby I'd break out some of the generate_site code into smaller methods or meaningful objects, but since this is a small side thing, I'm ok with leaving it like this unless it grows.


if the image is a QR code or contains a QR code, the result is larger than the original image.

When I use Sharp to compress PNG images, I find that if the image is a QR code or contains a QR code, after I use sharp(file.buffer).png({ quality: 80 }).toBuffer() for compression, the result is larger than the original image. This is not the outcome I expected. What should I do to address this?

For QR codes, avoid lossy compression as it can increase file size. Use lossless compression instead with Sharp:
sharp(file.buffer).png({ compressionLevel: 9, adaptiveFiltering: true, palette: true }).toBuffer()
This applies maximum lossless compression, adaptive filtering, and palette conversion, which is more suitable for QR codes. Always test the compressed images to ensure they remain scannable.

If you know your output PNG will contain only 2 possible pixel values then you can limit the palette to a relevant size:
const output = await sharp(input).png({ colours: 2 }).toBuffer();

This reduces the file size of the sample image provided from 11441 bytes to 5209 bytes.
https://sharp.pixelplumbing.com/api-output#png

I hope this information helped. Please feel free to re-open with more details if further assistance is required.

@lovell
Thank you very much for your help. I think I should first identify whether the image contains a QR code, and then use the configuration you provided to compress it.


Using both Fixed and Random passwords.

Hello.
I am assuming it's possible to use both fixed and random passwords? For example:
[root]
real_password = 123456
fake_passwords = password1, password2, password3

[setup]
real_password = 123456
random_chance = 15

[test]
real_password = 123456
random_chance = 10

In this scenario I would expect root to only be able to login using the passwords password1, password2 and password3, whereas the other two accounts can login with any random password.
I have tried the above but it appears as though the root user can login with random passwords. I've also tried adding "random_chance = 0" to the root user but this doesn't appear to make any difference.
Example:
20160801_001522_791927 - [SSH  ] Incoming Connection from <IP_ADDRESS>:40508 - Netherlands
20160801_001522_868358 - [SSH  ] Login Successful: root:support
20160801_001522_868358 - [SSH  ] Login was spoofed
20160801_001522_928846 - [SSH  ] Lost Connection with <IP_ADDRESS>

This is using the latest version cloned from git.
Thanks.

Hi,
Sorry for the slow reply. Yeah, this should work as you describe.
In the logs folder, there should be a file called spoof.log. Is 'support' listed as a valid password for root?
HonSSH keeps a log of previously spoofed passwords so the attacker does not get suspicious when the password does not work on the second login.
If it is not there, then I will need to test it out myself!

This was exactly what it was. Thanks for all the great work.


why I take wrong data and wrong timestamp

as you see I take different time
also when I use .KXBTUSDT I take wrong data

can you help me

Hi.
Are you still experiencing this issue?

Since this issue has already been addressed and there have been no updates for a long time, we will now close it.
If you need any further assistance, feel free to ask!


composer update (allow-plugins)

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
should fix tests

related https://github.com/yiisoft/yii2-docker/issues/146

Looks like we are downgrading the version of phpunit, is this expected?

Strange, it's like this since 5 years: https://github.com/yiisoft/yii2/commit/758f01934f180b4a4a47d36e1be103b1f979d76b#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R84

I wonder how this update was made?! CC: @samdark
https://github.com/yiisoft/yii2/commit/1271bc419ffaa2ac0e4db7d2eabea349ac5e4ace#diff-f37acfaa6b11f575a9a6f41a75fa73a61d0f8ebc2c9b8cddc215d8aca10e44f5R1341
@bizley
Can we merge this PR on a branch? I do not have sufficient permissions to do so, AFAIK.
Then we could run tests for all versions, I can just specify a YII_TEST_VERSION (commit hash)

@bizley Thank you, build is running: https://github.com/yiisoft/yii2-docker/actions/runs/1923486648
8.1 worked locally...


fix(denols): add package_json

Added the path to package.json.
Please check it.

Are you validating these? Most of this looks like options for vscode, not for sending to deno's language server.

I'm sorry. I haven't verified it.
We have not tested other language servers, so we will do so and create the PR again.

It's fine, just test the already open PRs and let me know if the settings are relevant, and I will merge if that is the case.

Yes, sir.
It may take some time, but I'll verify and get back to you.
Thank you.

I don't know the details of the Rust code, but according to the deno server code, the vscode_deno setting seems to be correct.
Here is the result.
Also, we have not checked all the settings, but we have confirmed that some of them work correctly.

It is assumed that YES is the correct setting value and NO is the setting value for VSCode only.

YES "deno.cache",
YES "deno.codeLens.implementations",
YES "deno.codeLens.references",
YES "deno.codeLens.referencesAllFunctions",
YES "deno.codeLens.test",
NO "deno.codeLens.testArgs",
YES "deno.config",
YES "deno.enable",
YES "deno.importMap",
YES "deno.internalDebug",
YES "deno.lint",
NO "deno.path",
YES "deno.suggest.autoImports",
YES "deno.suggest.completeFunctionCalls",
YES "deno.suggest.imports.autoDiscover",
YES "deno.suggest.imports.hosts",
YES "deno.suggest.names",
YES "deno.suggest.paths",
YES "deno.unstable"

Thank you for merging!


Update plugin info & icon

Edit existing Plugin in Marketplace
Update info, icon and add effect - need for MutationObserver
Plugin Github repo URL: https://github.com/yoyurec/logseq-solarized-extended-theme

@xyhp915 can you plz rebuild https://raw.githubusercontent.com/logseq/marketplace/master/plugins.json ? tnx 🙏


Unknown component ID: elasticsearch

I have just recently included Elastic Search widget in Yii2.
but i am getting the below error in Elastic Search.
Unknown component ID: elasticsearch
let me know any suggestion for the same.

@kartik-v I have just recently included Elastic Search widget in Yii2.
but i am getting the below error in Elastic Search.
Unknown component ID: elasticsearch
let me know any suggestion for the same.

@samdark
I have just recently included Elastic Search widget in Yii2.
but i am getting the below error in Elastic Search.
Unknown component ID: elasticsearch
let me know any suggestion for the same.

please stop spamming. read the docs: https://github.com/yiisoft/yii2-elasticsearch#configuration and add the component to your config.
Next time please use the forum to ask questions.


feat: implement surface of wrangler [vars] as env vars

This PR is created to add the feature to surface wrangler [vars] in $env in dev mode only, as requested in this https://github.com/sveltejs/kit/issues/12191
It adds the public and private [vars] of wrangler.toml to $env/static/public and $env/static/private respectively.
Also generates the ambient types accordingly.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Its surprising how I didn't think about it as I was writing the code with the assumption that all of the adapters will have same structures without even looking at the code.
But the only solution I can think of is adding an if statement as inside this file only we are writing the env vars.
if (svelte_config.kit.adapter?.name == '@sveltejs/adapter-cloudflare') {
    //@ts-ignore
    platform_env = split_env_vars(emulator?.platform?.(false)?.env, kit.env);
}

but again it is cloudflare-adapter specific implementation,

The way it would need to be done is to have an adapter method that provides environment variables in a SvelteKit-defined format
Alternatively, I wonder if Cloudflare/wrangler/whatever could be made to understand .env files? That might be nicer so that we retain one single place to define environment variables

cc: @dario-piotrowicz

Alternatively, I wonder if Cloudflare/wrangler/whatever could be made to understand .env files? That might be nicer so that we retain one single place to define environment variables

Hi there 🙂👋
Wrangler uses .env files only for its own configuration and not as environment variables to be made available in the workers runtime.
This has been so for a while and is something that in a way or another keeps popping up 😓:

https://github.com/cloudflare/workers-sdk/issues/190
https://github.com/cloudflare/workers-sdk/issues/3106
https://discord.com/channels/595317990191398933/920749372256419930/1235245234418487296

Unfortunately as you can see from https://github.com/cloudflare/workers-sdk/issues/3106#issuecomment-1589574995 the team is currently not too keen on supporting .env files and we do have a .dev.var file convention instead (this comment explains well the reasoning behind it: https://github.com/cloudflare/workers-sdk/issues/1305#issue-1276453110)
But there are internal diverging opinions on the matter...
I am trying to get to some sort of agreement on this, to either decide wether .env files should actually be read (given the community's demand for it) or provide a more definitive/offical/line-in-the-sand/public documentation on our decision not to support them.
So I am unsure/doubtful if .env files are ever going to be supported... but even if they were I don't see that happening any time soon unfortunately 😓

Thanks for the details @dario-piotrowicz! So if I understood, it's that .env is meant for the build process and .dev.vars for code inside the runtime.
There was also some nervousness about merging env vars provided from two different locations and I have a little bit of the same nervousness here. Like how would we know which one to prefer and if that hold hold true across platforms? I'm not sure I really want to go down this path
The other way to go would be to file a feature request with Vite and see if they can add an option for loading environment variables from a custom location (.dev.vars) instead of .env

@benmccann yes, .env is used to configure wrangler itself, whilst .dev.vars is where you can configure variables for the runtime (so that they are available in your actual workers code) (alongside the wrangler.toml file, you can also define your variables there).
By the way, I checked the PR's changes and my understanding is that this is just using the adapter.emulate() which just uses wrangler's getPlatformProxy under the hood, right? If that's the case getPlatformProxy provides all the variables from both the toml file and the .dev.vars one. (PS: I am just not sure if we provide a way for you to distinguish between these and bindings...)
What do you think? Would just relying on the getPlatformProxy result not work here?

What's "the toml file"? Is that .env?
We can't depend on platform in SvelteKit itself: https://github.com/sveltejs/kit/pull/12232#pullrequestreview-2069479165. We'd need a new adapter method

Yes, a new adapter method could.
Then the issue becomes do we merge with .env and which one takes precedence? I guess wrangler's opinion here is that .env should be discarded. We could potentially do that. Though we may need to introduce different merging modes for different adapters in the future. We'd also need to make sure the docs say "use .env unless your adapter says otherwise" instead of simply "use .env" which adds complications for all users because then they need to check what their adapter's behavior is and can't easily know what will happen from a quick glance at the docs.
If wrangler used .env for the runtime and had a separate .build.vars for environment variables during building it would allow it to keep those separate and would avoid these issues by aligning with Vite's behavior

I'm going to go ahead and close this for now to keep the PR queue clean since it can't be merged in its current state. Please feel free to reopen it in the future with a new approach as discussed above


Unsupported phi use of const or let variable

New example ( v8 5.4.500.45 / Node.js 7.4.0):
'use strict';

let i;

for (i = 0; i < 1e7; i++) {}

let j;

for (j = 0; j < 1e7; j++) {}

[marking 000001F62D3DF079 <JS Function (SharedFunctionInfo 000002B36CA679C1)> for optimized recompilation, reason: small function, ICs with typeinfo: 2/4 (50%), generic ICs: 0/4 (0%)]
[compiling method 000001F62D3DF079 <JS Function (SharedFunctionInfo 000002B36CA679C1)> using Crankshaft OSR]
[aborted optimizing 000001F62D3DF079 <JS Function (SharedFunctionInfo 000002B36CA679C1)> because: Unsupported phi use of const or let variable]
[disabled optimization for 000002B36CA679C1 <SharedFunctionInfo>, reason: Unsupported phi use of const or let variable]

It seems the deopt concerns some internal function for loops.

A v8 issue with more info.

It seems this is a bug posted and forgotten by myself)
https://bugs.chromium.org/p/v8/issues/detail?id=5666


PowerShell's convertfrom-json fails if there is non-English in gh api's output

Description
When using convertfrom-json to convert the output of the gh api command in PowerShell on non-English Windows, non-English errors occur, not on Ubuntu 22.04.
gh version 2.42.0 (2024-01-11)
Reproduction Steps
The commit messages in this repository contain Japanese characters, and when the output of the gh api command is converted using convertfrom-json in PowerShell 7.4 in a Japanese environment, an error occurs in the Japanese commit message.
Error: Windows 11 22H2(ja-jp) + PowerShell 7.4.0 + gh version 2.42.0 (2024-01-11)
❯ $json = gh api -H "Accept: application/vnd.github.v3+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/kkamegawa/felica2money/commits | convertfrom-json
ConvertFrom-Json: Conversion from JSON failed with error: After parsing a value an unexpected character was encountered: t. Path '[4].commit.message', line 1, position 14380.

Success: Windows 11 22H2(ja-jp) + PowerShell 7.4.0
$header = @{
  Accept = "application/vnd.github+json"
  'X-GitHub-Api-Version' = "2022-11-28"
}
$uri ='https://api.github.com/repos/kkamegawa/felica2money/commits'
$json = Invoke-RestMethod -Uri $Uri -Method Get -ContentType "application/json" -Headers $header

Success: Ubuntu 22.04(en-us) + PowerShell 7.4.0 + gh version 2.42.0 (2024-01-11)
PS /home/kkamegawa> $json = gh api -H "Accept: application/vnd.github.v3+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/kkamegawa/felica2money/commits | convertfrom-json
PS /home/kkamegawa>

@kkamegawa Thanks for reaching out! It looks like this bug report is related to the GitHub CLI, not the GitHub Enterprise Importer extension. I'm going to transfer it to cli/cli.

Actually, I can't transfer, so I'm gong to close this issue. Can you reopen it on https://github.com/cli/cli?


Why is the cert-manager-operator for Red Hat not AllNamespaces

During tech preview, I was able to install cert-manager-operator in AllNamespaces mode. When was this support removed and why?
The CNCF cert-manager-operator is only installable in AllNamespaces mode, so why does the Red Hat one deviate from this?

Additionally, cert-manager is a cluster wide service, and there is a limitation that there cannot be 2 active cert-manager-controllers on a cluster simultaneously since cert-manager never implemented this functionality properly https://github.com/cert-manager/cert-manager/issues/2525.
So with Red Hat cert-manager not restricting the install mode to only AllNamespaces, isn't there a risk that different users on a cluster accidentally install Red Hat cert-manager multiple times, leading to multiple active cert-manager-controllers?

I actually have run into this today. When you install in multiple namespaces, the Deployment.app for the operator conflicts, and is constantly updating.

While it seems most currently-developed Operators are moving to AllNamespaces mode, it is quite disruptive to change anything like this mid-channel version.  Documenting why this namespace method was used could be useful, but otherwise I'm happy to see this close.

The controller deployed by RH Cert Manager operator has cluster-wide permissions and visibility, as does the upstream CNCF/Jetstack Cert-Manager on which this is based.
Not installing the Cert-Manager in AllNamespaces mode does not change this.  Allowing installation in anything but AllNamespaces mode is misleading.  This is the essence of the bug

On further review of this, I believe that the desire on behalf of Red Hat was to install the operator in a namespace other than openshift-operators even though it is cluster scoped (essentially AllNamespace Mode).  Taking the default, the operator is installed in the cert-manager-operator namespace with its deployed resources running in the cert-manager namespace.   So this operator's payload does indeed have cluster scoped visibility and control (look at its clusterrolebindings).
The issue is in the OperatorHub dialog misrepresentation that installing Cert-Manager in a named namespace implies that it only watches and controls its CRs in that installed namespace.  Regardless of where its installed, it is essentially running in AllNamespace mode.
The OperatorHub DIalog is just WRONG with respect to this operator/payload.
In addition because it is not installed in openshift-operators (currently the right place for all operators installed in AllNamespace mode) views of the installed operators in other namespaces in the OperatorHub do not show the RH Cert-Manager operator even though it has control in those namespaces.  My guess is that only operator installed in in the openshift-operators namespace are seen as as installed operator in every other namespace. Again this is misleading.

It does not look like this issue was resolved, and in a recent discussion with the Red Hat Cert Manager team I was under the impression a fix was in progress.
/reopen
/remove-lifecycle rotten

@griffindvs as this is affecting a productized component, I would suggest opening an issue at https://issues.redhat.com for tracking purposes. Issues in GitHub are generally not tracked as strongly.
Suggest starting at https://issues.redhat.com/projects/CM/summary