Fix /data response to match /transactions

The current implementation of the /data response produces a JSON array of two elements:
["hash","047e9423a1e6f9ee53596abf787884d007c82e1ec898a599f2048961ce5872e2"]

but I think the intention was to produce an object similar to the /transactions endpoint:
{"hash":"4ee922ad6b244df6ec5b84a54cb9024d92607cba3cbc2c7b283e0b2fa053cf5e"}

@sdavidp label is missing

We can go back to shapeless if that is preferred but I was running into compiler inference issues at some point with trying to derive the EntityEncoder from the implicit scope. Invoking Shapeless HNil seemed like overkill since the expected response was JSON so my aim was to simplify from using the HNil to format a response. I had not noticed that my first approach produced an array instead of an object though so perhaps Shapeless is the easiest route to get the proper response.

the correct approach to avoiding the shapeless import would be to return
Ok(Json.obj("hash" -> hashed.hash.value.asJson))

We can go back to shapeless if that is preferred but I was running into compiler inference issues at some point with trying to derive the EntityEncoder from the implicit scope. Invoking Shapeless HNil seemed like overkill since the expected response was JSON so my aim was to simplify from using the HNil and format the expected response directly. I had not noticed that my approach produced an array instead of an object though so perhaps Shapeless is the easiest route to get the proper response.

I suspect the reason an array was produced instead of an object is that we were constructing json from a tuple. If we wanted to generalize producing a json object for our newtype objects we could write this:
def toJsonObject[A: Encoder](name: String, a: A): Json = Json.obj(name -> a.asJson)

This is the error that I encounter through the IDE and when running sbt compile via CLI when the return type is Ok(("hash" ->> hashed.hash.value) :: HNil)
[error] /home/scas/git/tessellation/modules/currency-l1/src/main/scala/org/tessellation/currency/l1/http/DataApplicationRoutes.scala:87:60: Cannot convert from String with shapeless.labelled.KeyTag[String("hash"),String] :: shapeless.HNil to an Entity, because no EntityEncoder[F, String with shapeless.labelled.KeyTag[String("hash"),String] :: shapeless.HNil] instance could be found.
[error]                 dataUpdatesQueue.offer(hashed.signed) >> Ok(("hash" ->> hashed.hash.value) :: HNil)
[error]                                                            ^

I am unsure what about my environment could cause the failure though as this doesn't seem to be a problem for you all.

This is the error that I encounter through the IDE and when running sbt compile via CLI when the return type is Ok(("hash" ->> hashed.hash.value) :: HNil)
[error] /home/scas/git/tessellation/modules/currency-l1/src/main/scala/org/tessellation/currency/l1/http/DataApplicationRoutes.scala:87:60: Cannot convert from String with shapeless.labelled.KeyTag[String("hash"),String] :: shapeless.HNil to an Entity, because no EntityEncoder[F, String with shapeless.labelled.KeyTag[String("hash"),String] :: shapeless.HNil] instance could be found.
[error]                 dataUpdatesQueue.offer(hashed.signed) >> Ok(("hash" ->> hashed.hash.value) :: HNil)
[error]                                                            ^

I am unsure what about my environment could cause the failure though as this doesn't seem to be a problem for you all.

I think you resolve that with an import (which IntellliJ doesn't realize is needed):
import io.circe.shapes._

This is the error that I encounter through the IDE and when running sbt compile via CLI when the return type is Ok(("hash" ->> hashed.hash.value) :: HNil)
[error] /home/scas/git/tessellation/modules/currency-l1/src/main/scala/org/tessellation/currency/l1/http/DataApplicationRoutes.scala:87:60: Cannot convert from String with shapeless.labelled.KeyTag[String("hash"),String] :: shapeless.HNil to an Entity, because no EntityEncoder[F, String with shapeless.labelled.KeyTag[String("hash"),String] :: shapeless.HNil] instance could be found.
[error]                 dataUpdatesQueue.offer(hashed.signed) >> Ok(("hash" ->> hashed.hash.value) :: HNil)
[error]                                                            ^

I am unsure what about my environment could cause the failure though as this doesn't seem to be a problem for you all.

I think you resolve that with an import (which IntellliJ doesn't realize is needed):
import io.circe.shapes._

That worked, I missed the import when testing again and I suspect that I accidentally removed it when using the IntelliJ formatting tool. Thank you for the clarification.

It looks like one of the reasons this bug was possible was that we don't have any tests on the POST /data endpoint.
Would you add a simple test that verifies the response schema on a successful request?

@AlexBrandes  Added.


[PHP-FPM] Fix cli debug auto start

Description
This PR provides fix for autostart debug for cli commands and by a trigger for fpm
#267

@davidalger Please check and merge fix for cli debug

@davidalger Please check and merge fix for cli debug

Changes look good to me. Merging without testing since it only affects the xdebug3 images, so they can be rebuilt by CI. Would be good if you could pull and validate once they build.

Changes look good to me. Merging without testing since it only affects the xdebug3 images, so they can be rebuilt by CI. Would be good if you could pull and validate once they build.

@davidalger just checked - works fine

@davidalger just checked - works fine


[2513] Added a list of known subjects to docs

Context
Subjects
Changes proposed in this pull request
Added a list of subjects to v1 docs
Guidance to review
:shipit:
Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 Update API v1 documentation to have a list of subject codes

The list of subjects is missing SEND (U3)

@mcghief Added


fleetengine.googleapis.com don't exists in GCP APIs and Services

Greetings.
https://github.com/googlemaps/last-mile-fleet-solution-samples/blob/d3c6adb7f40667eb02b2342c2da3b354d218d43b/getting-started.md?plain=1#L24
Produce "Failed to load." in APIs and Services in Cloud Console.

Same can't able to find those api.
Have you found the solution.


Unexpected 504 for room

Anyone seen this before?
Error: #<HipChat::UnknownResponseCode: Unexpected 504 for room `Playlist Builder'>"]
/Volumes/Storage/martincleaver/.chefdk/gem/ruby/2.1.0/gems/hipchat-1.5.2/lib/hipchat/room.rb:142:in `send': Unexpected 504 for room `Playlist Builder' (HipChat::UnknownResponseCode)

504 doesn't even appear in https://www.hipchat.com/docs/apiv2/response_codes or https://www.hipchat.com/docs/api/response_codes
I suppose I'll just have to catch such exceptions. Weird.

That exception typically happens if something in the backed takes longer than expected to respond back, your safest bet is to add a catch and retry. Is it happening  a lot?

Yeah, I'm getting all sorts of exceptions actually. Eg no such room after creating a room - yet then I see in actuality the room does get created. I was just considering wrapping he HipChat class to make exceptions non-fatal - or throttling somehow. Any advice? Thanks, M.


Switch to versioned Quark files.

Also reflect the change from discovery to datawire_discovery.

@brikelly: I'd like you to verify that the Market example still works fine for you with this change before I merge it, please.

@kflynn - market demo verified as OK with these changes. Merge away!


Collisions not working when browser tab changes

When I change the browser tab, no collisions are detected, any ideas how to fix it?
gif:

It probably has to do with the fact that browser slow down setInterval and requestAnimationFrame and others for inactive tabs.
I recommend to pause the game when the tab is inactive.
document.addEventListener(`visibilitychange`, function () {
    if (document.hidden) {
        pause();
    }
});

In case someone else have the same problem:
if I doa simple if/else the result is the same, I had to add a delay of 100ms before resuming the game again to avoid this problem.
thanks @GrosSacASac


deleted useless code

@aaaaadamchen thank you for your contribution, please sign CLA.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot I signed it!

----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/f/w/bazel-out/k8-opt/bin/tensorflow/python/eager/function_test.runfiles/org_tensorflow/tensorflow/python/eager/function_test.py", line 976, in testRunMetadata
    run_metadata = context.export_run_metadata()
  File "/b/f/w/bazel-out/k8-opt/bin/tensorflow/python/eager/function_test.runfiles/org_tensorflow/tensorflow/python/eager/context.py", line 1970, in export_run_metadata
    return context().export_run_metadata()
  File "/b/f/w/bazel-out/k8-opt/bin/tensorflow/python/eager/function_test.runfiles/org_tensorflow/tensorflow/python/eager/context.py", line 1473, in export_run_metadata
    with c_api_util.tf_buffer() as buffer_:
NameError: name 'c_api_util' is not defined

Closing as spam PR.


Reporters should not be mandatory

Again,
Currently, metric registry is only created if reporter are provided. However, we may want to collect metrics without reporters. For example, the metrics could be used through some ring middleware. Or they could be queried during tests.

Providing an empty list works too.


chore: update dockerfile to python 3.11

What I did
Updates the Dockerfile python version to 3.11 because features.
Any reason not to do this?  Will this roll the docker hub versions automagically?
Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

Will this roll the docker hub versions automagically?

Dockerhub currently updates latest tag to whatever main is, and then makes a tagged that mirrors any github release made (e.g. v0.7.11) and slaps stable on whatever is the last release
I have been considering to migrate to GHCR because of the recent changes with Dockerhub, would also be nice to have it all in one place as well

WIll note that I do not believe that the docker images build until they hit main, so just verify it locally and we can merge

WIll note that I do not believe that the docker images build until they hit main, so just verify it locally and we can merge

I did verify that it builds and runs locally.


Need restart GDB test if received SIGTRAP

Need restart GDB test if received SIGTRAP
Thread 2.1 received signal SIGTRAP, Trace/breakpoint trap.
[Switching to Thread 1.1073741888 (inactive)]
0x0000000000000000 in ?? ()
(gdb)

Originally posted by @PokhodenkoSA in https://github.com/IntelPython/numba-dppy/issues/568#issuecomment-926486699

Faced it several times on oneAPI 2021.3.


[5.2] Pagination from source and CDN looks different

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Pagination looks different in CDN version vs compiled version

All the links in list are rounded using 1st code snippet from https://getbootstrap.com/docs/5.2/components/pagination/

Reduced test cases
Useless in this case bc codepen uses CDN version
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Firefox
What version of Bootstrap are you using?
5.2

@mdo https://github.com/twbs/bootstrap/commit/a153f360eea855f29947ac14be14e29380ddebeb yep, i found


No reconnect method in WsProvider.

Hello,
How to implement reconnect function with built-in Ws Provider?
As a workaround I created custom Ws Provider that extends Provider, and implement it by myself.

You can pretty much catch the exception and call the connect method again. But I guess what you want is to auto-reconnect, is that correct?

auto reconnect would be a nice feature.
But my main problem with no 'onError' and 'onDone' callbacks. After losing internet connection Websocket connection will be lost as well as all subscriptions and queries. And there's no TimeOutException in websocket by default.
For example:
Class provider.dart [line 184 - 186]
    }).listen((message) {
      queries.remove(message.id)!.complete(message);
    });

And [line 203 - 207]
    }).listen((message) {
      final StreamController? controller =
          get SubscriptionController(message.subscription);
      controller?.add(message);
    });

'jsonStream' only listening for responses and completely ignores any errors.

I see. @Lohann was responsible for this part but not sure if he has free time to look into it. I'm going to check with him and if he is not able to take a look add to my queue here.

Good catch @overetch, will fix this week when I have some free time.

@Lohann were you able to look into this?


Support Both JDT and CDT

to use both java and c/c++ project in one Eclipse instance

[ ] need new project : dexter-eclipse-cdt

it was solved.


subscriber canno manage cloud account

There is no way for the subscriber to manage the cloud accounts.
We need in the Account menu a "manage cloud account" link to the cloud account management pages:
list of the cloud account of "that" organization and the possibility of adding more etc.

Check also SP role and admin, all need to be able to manage cloud accounts:
SP as the subscriber
the admin need to see the list but cannot see the password or data inside the records so only list the records and be able to delete them but no edit

The "Account" in the menu will be deleted. To access the cloudaccount management you have to click in "Name: "  in order to access to the profile. Then you will find a CloudAccount tab to manage cloud accounts.


casts should be ints if needed

From #223 , we wanted a way to test whether args->ru was NULL. But casts can't currently can't be treated as ints.
Either these should work:
# bpftrace -e 'tracepoint:syscalls:sys_enter_wait4 /args->ru/ { printf("hi\n"); }'
Invalid type for predicate: cast

# bpftrace -e 'tracepoint:syscalls:sys_enter_wait4 { printf("hi %d\n", args->ru); }'
printf: %d specifier expects a value of type integer (cast supplied)

Or, these should work:
# bpftrace -e 'tracepoint:syscalls:sys_enter_wait4 /(int)args->ru/ { printf("hi\n"); }'
Unknown struct/union: 'int'

# bpftrace -e 'tracepoint:syscalls:sys_enter_wait4 { printf("hi %d\n", (int)args->ru); }'
Unknown struct/union: 'int'

yesterday I got confused by jumping to wrong semaphore declaration in linux/rwsem-spinlock.h. The generic rw_semaphore is in linux/rwsem.h and there count is atomic_long_t which is a structure. The following bpftrace program thus works:
#include <linux/path.h>
#include <linux/dcache.h>
#include <linux/sched.h>
#include <linux/mm_types.h>

kprobe:fuse_readpage,kprobe:fuse_readpages {
        printf("%s (%d) %s\n", probe, ((task_struct *)curtask)->mm->mmap_sem.count.counter, stack);
}

sorry for the noise.

I think there's three parts to this: map keys, printf, and predicates. I'll look at fixing some or all.


Parse batch-index latency metrics

What does this PR do?
Parse batch-index which is not namespace specific instead of below and not send any latency metrics at all.
 Invalid data. Namespace and/or metric name not found in line: `batch-index:06:10:32-GMT,ops/sec,>1ms,>8ms,>64ms`

Motivation

AGENT-1673

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

redoing


Update Components github action is failing

Describe the bug
There is an authorization problem where the user weaveworks-gitops-test-weave-gitops-bot doesn't have permission to push to a branch.
Link to the log https://github.com/weaveworks/weave-gitops/runs/3475859815?check_suite_focus=true#step:5:532

Environment

wego: [e.g. v0.1.0]
kubernetes:  [e.g. 1.20.4]

[ ] KinD - version]
[ ] k3s - version
[ ] cloud [e.g., EKS, AKS]  version
[ ] other - name version

Browser + version: [e.g. chrome 74, safari 12, firefox 87]

Affects versions
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Config and Logs
If applicable, add logs to help explain your problem. please compress the output before attaching

[ ] wego config
[ ] wego cli call output (and parameters)
[ ] wego-controller logs
[ ] Events from wego-* namespaces
[ ] kubectl cluster-info dump
[ ] Prometheus alerts

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Closing this issue as the workflow is working properly. Probably it doesn't work if it gets triggered manually but with the cron job works perfectly.


Missing On Off information

Hello,
thank you for this helpfull library. What I was missing is an explicit on/off function. So I've done some extention:
in EspalexaDevice.cpp
bool EspalexaDevice::getOnOff()
{
return _on_off;
}
void EspalexaDevice::setOnOff(bool onoff)
{
_on_off = onoff;
}
in EspalexaDevice.h
...
class EspalexaDevice {
private:
...
bool _on_off = false;
...
in Espalexa.h
if (body.indexOf("false")>0) //OFF command
{
devices[devId]->setOnOff(0);
...
if (body.indexOf("true") >0) //ON command
{
devices[devId]->setOnOff(1);
...
works for me.
Greetings Jörg

Missing something, no?
C:\Users\Warren\Documents\Arduino\libraries\Espalexa\src/Espalexa.h: In member function 'bool Espalexa::handleAlexaApiCall(String, String)':
C:\Users\Warren\Documents\Arduino\libraries\Espalexa\src/Espalexa.h:479:19: error: 'class EspalexaDevice' has no member named 'setOnOff'
devices[devId]->setOnOff(0);
^
C:\Users\Warren\Documents\Arduino\libraries\Espalexa\src/Espalexa.h:489:19: error: 'class EspalexaDevice' has no member named 'setOnOff'
devices[devId]->setOnOff(1);
^
exit status 1

There is no need for setOnOff, the library has the function already.
In my house i have many lights with i can switching (toggle with a tactile switch) instead of alexa command:
device[i]->setValue(device[i]->getValue() > 0 ? 0 : 255);		// toggle value
device[i]->doCallback();	// relay on

or
// toggle value, switch on with last brightness, if needed
device[i]->setValue(device[i]->getValue() > 0 ? 0 : device[i]->getLastValue());
// set relay or LED strip dim value
device[i]->doCallback();

or
device[i]->setValue(1);     // relay on
device[i]->doCallback();    // set relay

So "device[i]->setValue(n)"


any chance to get 12.5.6 support?

Describe the feature you'd like
if possible, can we get a 12.5.6 support for A7 iPad Air first gen?
12.5.5 is the maximum right now
would be awesome and I hope its not that much of work to implement

Your kidding me... I had my phone with 12.5.5 saw it supported 11-14 and upgraded to 12.5.6  and now this....


Adding a new tool called CakeFuzzer

I added our interactive application security testing tool called CakeFuzzer. CakeFuzzer employs both static and dynamic testing techniques to find all possible endpoints of the application and conduct security tests.

[x] I have not changed the README.md directly.

Hi,
is this, strictly speaking, a static analysis tool?
The README.md mentions Interactive Application Security Testing (IAST) as a sort of hybrid static/dynamic approach.

Hello,
Yes, CakeFuzzer is an IAST tool that employs SAST techniques, and source code analysis and combines it with a dynamic approach to minimize false positives. I also mentioned in the PR. Please ask any further questions since it is truly a unique tool and generated really good real-world results.

All good. I took a closer look, and it makes sense to add it. If you're fine with accepting the suggestion I made, I'm happy to merge it. 😃

Yes, I am fine and understand the reason :) thank you

Awesome. Thanks a lot for the contribution. 😃


Feature - [IAM] Delete Policy

Added an additional test for delete_user as well, as that was missing

Coverage decreased (-0.001%) to 93.494% when pulling 856a06a7785d3afa7e6b932c9a628bd1f4986299 on bblommers:feature/iam_delete_policy into 16a0e93259bec370f65eb1232e842ad4999fc23d on spulec:master.

Fixed @mikegrima


Adding a picture as a background image

Hello, I have been working on this weeks hw, and I was thinking it would be cool to put a picture for my background image. I have been trying to use a jpg image and set the background to the size of the image, but still nothing. Any ideas? Thanks!

Do you have a picture of your code?  Next week's content looks like we'll be going over putting in things like images so the course content might be helpful if you were unable to troubleshoot by googling the problem

here is my code as it stands, but I would like have four different background images on a loop, but lets just start with loading one.

It looks like you're using Chrome.  I had the same problem. It's annoying, but the easiest way to get around it is to just preview your code in Internet Explorer, Edge or Firefox if you have it. After you commit it, it works just fine in Chrome. It just blocks taking images directly from the desktop for 'security issues'. I think you can preview it in Chrome, but you have to do it manually with a line of text enabling it access. I didn't bother because my code opened right up in another browser.
If if keeps loading forever and your error says:
"Access to image at 'where ever your file is located' from origin 'null' has been blocked by CORS policy: The response is invalid. "
Chrome is your problem.


Update the blackbox-testing docker-compose file

Update the blackbox-testing docker-compose file to reflect the changes made by https://github.com/edgexfoundry/developer-scripts/pull/184

@jinlinGuan is working on #295 , so it will be consistent soon

@cloudxxx8 Do you have an estimated time when #295 will be completed?  The master branch's security versions of the blackbox tests are currently broken and should be fixed as quickly as possible.  If #295 is expected to be completed within the next week, I'd say we could wait.  Otherwise, my ask is for @jim-wang-intel, @bnevis-i, or @tingyuz to port the work done in https://github.com/edgexfoundry/developer-scripts/pull/184 to the blackbox testing repository early this week to get the blackbox tests up and functioning again.

#295 has to be completed by next week
add @jinlinGuan and @cherrycl for awareness

#295 is still in flight as of the date/time of this entry.  @jim-wang-intel, @tingyuz, @bnevis-i -- please do the necessary work to get this change into blackbox-testing's copy of the docker-compose file so we can ensure security-related tests run properly between now and when #295 is merged.

https://github.com/edgexfoundry/blackbox-testing/pull/349 was submitted on Friday and is still awaiting review and merge.

#349 made progress but didn't fix the build.  Now seeing following:


Can I put and use the folder "locale" l18n in my project?

Question.
I need customize the translation of Userena, but I don't like override the package.
Can I to configure the folder "locale" l18n to my project?. I would like put a copy inside my app.

1º. Copy "locale" to the personal app
2º. django-admin makemessages --locale es
3º. django-admin compilemessages


Add support for Alternative Credentials

That would be great! :) We work in a mixed environment and we are not always logged under our domain admin account, or even on a domain joined PC (or vice versa).


The wasmtime::Store type should be thread-safe

As proposed in #708 the Store type in the wasmtime API should be thread-safe, meaning it should implement both Send and Sync. Currently, however, it has a few items that are not thread safe and/or need audits:

The global_exports field is an Rc-protected data structure used by wasmtime internals. I don't know myself what it would take to remove this, but @sunfishcode looks like he does in https://github.com/bytecodealliance/wasmtime/pull/390
The signature_cache field requires interior mutability and currently uses a RefCell. While this could be switched to a Mutex I think it would be best to avoid this altogether. I don't personally know why this field exists, @yurydelendik do you know why it's here?
The context field has a contained compiler field which has a number of issues. Namely Rc and RefCell are not thread safe (but can be swapped for Arc/Mutex if necessary), but the underlying Compiler type has a number of trait objects, raw pointers, etc, which would need auditing. I think the solution here is going to be making Compiler itself threadsafe by redesigning it's internals.

signature_cache shall be a common storage across all imports/exports/module that are interact between each other to maintain common database of SignatureId -> Signature. The Compiler type contains signatures field to do the reverse operation, which is needed for codegen.

@alexcrichton why is this impossible?

@DemiMarie-parity the way things are set up right now you instantiate Instance structures into a Store. The Store keeps a handle on each Instance, so effectively a Store stores each Instance. This is done to keep each Instance alive since we don't have a GC right now to otherwise understand when there are no references to an Instance.
Instances themselves are fundamentally not Sync because operations like global get/set aren't atomic. They're ideally Send, however, but with the Rc that we're using for memory management that forces them to not be Send.
The current state of affairs is that basically Store stores enough instance-local information that it can't be shared across threads because instances can't be shared across threads. There may still be internal refactorings or possible designs to fix this, but overall our threading story isn't great right now unfortunately.

@alexcrichton what if we used Arc instead?  I imagine that reference count operations are not in hot paths.

Unfortunatey it's not quite as easy as that. In Rust there's no way to statically have a reference counted type that's Send but not Sync, which is morally what we'd want here. The only static solution for that is to entirely remove the reference counting, but that doesn't jive well with the memory management that we have in wasmtime today.
Failing that we'd have to invent our own solution in wasmtime which is much more invasive than just using an Arc instead of an Rc, and I'm not really sure if that's even possible much less workable.

What would need to change to allow JIT-compiled code to be used by multiple threads simultaneously?

The first idea that comes to mind is to separate the JIT-compiled code (which is immutable) from the data (which is mutable).  So to execute some code, one would first need to compile it, which would return an immutable CompiledBlob object.  One would then need to create an Instance from the CompiledBlob.  Since a CompiledBlob is immutable, making it Send + Sync is trivial.

Ah yes so sharing Store is its own issue but sharing compiled code is definitely something that we want to enable. Making Module both Send and Sync should be easier than making Store either Send or Sync, and that's largely just a matter of internal refactorings.

FWIW wasm-c-api planed to shared a module between two stores via wasm_module_share/wasm_module_obtain , see https://github.com/WebAssembly/wasm-c-api/blob/master/example/threads.c#L34


Small documentation fixes

Some fixes I have found while reading the docs.
Unfortunately I was not able to run the make spelling.
Make with virtualenv caused some access denied errors.
Matthias

It says the changes lead to a failing check: what can I do to resolve that?
Or is it just a test artifact? It seems, that some builds before or after had problems with the same testcase.
Thanks for your advice, Matthias

@mcavigelli issue is already solved in 3.2 branch. We need to forwardport the changes to develop, after which you can simply merge develop on your branch (or rebase your branch on top of new develop).
It may take some days, though, as we're about to ship 3.2.1 and we will sync develop after this.
But that's not an issue when reviewing your PR

LGTM, summoning @evildmp for the final ok

All looks good to me. Just restarting tests, not sure why they should fail.

Merged in #5077, thanks @mcavigelli


Backport some dependabot bumps (#1350, #1355, #1357, #1359)

Description
Backports four dependabot version bumps to release/v1.14.x:

#1350
#1355
#1357
#1359

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Closing this for now. Probably won't do this unless we need a v1.14.1.


Bluetooth: Mesh: Restructure doc

Adds a deeper hierarchy to the Bluetooth Mesh documentation by moving
the modules in separate pages with a brief description of the concepts
in each module.
Adds the full list of specification defined Health model faults.
Signed-off-by: Trond Einar Snekvik<EMAIL_ADDRESS>

I wrapped the health server externs in @cond INTERNAL_HIDDEN to get rid of the duplicate declaration issue reported by the build system, it doesn't like having types and variables with the same name, it seems like. I plan on making another PR filling in a lot of missing doxygen entries next week, I'll do this for the other models as well at that point


Use memsup.get_system_memory_data for available memory measurement

:memsup.get_system_memory_data Seems like a good non OS dependent way to gather memory data.
iex(1)> :memsup.get_memory_data()
{0, 0, {#PID<0.81.0>, 0}}

13:23:14.764 [warn]  OS_MON (:memsup) called by #PID<0.81.0>, not started
iex(3)> :memsup.start_link
{:ok, #PID<0.86.0>}

iex(5)> :memsup.get_system_memory_data()
[system_total_memory:<PHONE_NUMBER>0, free_swap:<PHONE_NUMBER>,
 total_swap:<PHONE_NUMBER>, cached_memory:<PHONE_NUMBER>, buffered_memory: 406970368,
 free_memory:<PHONE_NUMBER>, total_memory:<PHONE_NUMBER>0]
iex(10)><PHONE_NUMBER>0 / (1024 * 1024 * 1024)
15.614891052246094

I thought it was weird that it said 15.6 GB, but that's also what my own system info center claims. :man_shrugging:

@devonestes have you seen this, wdyt could we substitute the OS specific things with it? :) That way Erlang does some of the heavy loading and we have less OS dependent code

I hadn't seen this before! I'd be ok with moving to using this instead for sure. There's one difference between what we have already and this, though. What we have already shows the total system memory, but this function gives us "The total amount of memory available to the Erlang emulator, allocated and free. May or may not be equal to the amount of memory configured in the system."
That's most likely a really small difference, if any, and I don't think it would be too confusing to folks if for some reason they see something they're not expecting. Frankly, for the purposes of showing the available system resources for a given set of benchmarks, this is probably a more accurate number!

Huh, I've never used that call, interesting.  It seems to work on Windows 10 fine too!

@PragTob So I just tried this out on my machine, and I didn't get the results I was expecting.
iex(1)> :memsup.start_link()
{:ok, #PID<0.82.0>}
iex(2)> :memsup.get_system_memory_data()
[total_memory:<PHONE_NUMBER>, free_memory:<PHONE_NUMBER>,
 system_total_memory:<PHONE_NUMBER>]
iex(3)><PHONE_NUMBER> / (1024 * 1024 * 1024)
5.405590057373047

However, I have 8gb of RAM installed. I'm not sure why those 2.5gb of RAM aren't marked here, but I think this would be kind of confusing. Frankly, I wasn't expecting this kind of difference. If it were a couple MB off, then that would be something, but it's missing nearly 1/3 of my installed memory here...

However, I have 8gb of RAM installed. I'm not sure why those 2.5gb of RAM aren't marked here, but I think this would be kind of confusing. Frankly, I wasn't expecting this kind of difference. If it were a couple MB off, then that would be something, but it's missing nearly 1/3 of my installed memory here...

I think that is expected, it is the total memory available to Erlang, not the total memory of the system from what I'm seeing in the source.  As long as it is documented as such whenever that number is displayed then that should probably be fine?

Personally, I think when people see this output in their results they're going to say to themselves "Hey, I don't have 5.4 GB of RAM - I have 8!". I think we'd pretty quickly see bug reports, since I doubt most folks would read all that would be required to understand why that result is displaying as it is.
I'm totally cool with implementing it if others think this is a good call, but to me it seems like the potential for a confusing UX is high by displaying numbers that are so far off from what users expect.

Maybe list it as "usable_memory" or so?

Yeah, I see the concerns but I think it's more what we want to look at for benchmarking purposes - and that is how much memory the Erlang VM has for use. Because that's also what (I guess) determines when the swapping starts (guess: rest is already occupied) or what the garbage collector does.
It'd be interesting to find out why it reports it differently on your system/mac.
I'm plus one on usable_memory or available_memory or something of that sort. I guess we might get issues about it, but I'd also explain what it is in the README. We can always revert back to the current solution with relative ease should it get tooo annoying I feel like :)

I'll start tackling this :)

I'll start tackling this :)So after way too much time spend, it might not be usable.
 However, there is always an annoying [os_mon] memory supervisor port (memsup): Erlang has closed message being printed, during test runs and real run time. I can't figure out how to get rid off those message and I believe it's probably almost impossible as it is a direct fprintf call - but while I write this, I might redirect all the stderror, but that might break on Windows again... oh, fun times.

And that I can't really et to work as it's not just a system command... sigh. Ideas welcome.

Well, it might not be a good idea, but we could capture :stderr for the duration of that function to suppress that output. ExUnit.CaptureIO.capture_io/2 takes a device to capture, so you can give it :stderr: https://hexdocs.pm/ex_unit/ExUnit.CaptureIO.html#capture_io/1-examples

Tried that - or well I might have made a mistake. I'm not sure, I thought it might not work because it's c-code calling that in fprintf so I think the elixir/erlang ways of circumventing it might not work because it comes from a nother place. I also tried disabling error logging alltogether (:error_logger.tty(false)) to no avail :(

Changes are on this branch: https://github.com/PragTob/benchee/tree/memsup-get-stystem-memory
Or well, this commit: 6979450c97cfe02d49749ce35dd1cd2fb8badaf6
I feel like I should be missing something easy to stop it from printing. Maybe also an OTP thing about how I start it or kill it... :( It looked so beautiful as a solution, making the code much smaller and probably more reliable.

Our current solution works well enough. We could revisit this at some point and either live with the shutting down messages or just leave it running but I fear interference with our benchmarks and that's something I can't/don't want to have :)


VOL-3116: Enable LDAP Filtering by LDAP_USERNAME_ATTRIBUTE and use resulting object as FQDN for authentication

Enable LDAP Filtering by LDAP_USERNAME_ATTRIBUTE and use resulting object as FQDN for authentication.
Description
Include a summary of the change here.
Related issue: VOL-3116
Type of change
Feature (non-breaking change (hopefully) which adds functionality)
Checklist:

[x] I have performed a self-review of my own code
[x] I have added tests that prove my fix is effective or that my feature works

Looks good - there are quite a few linting issues though.
To fix ESlint, update NPM to version 7+ and npm i. May need to do the same in the GitHub action too.

But the general idea, flow will be compatible with MOT implementation of this lambda? I don't think there are any breaking changes, so wanted to make sure you did not see any pitfalls or problems with this solution.

Looks good - there are quite a few linting issues though.
To fix ESlint, update NPM to version 7+ and npm i. May need to do the same in the GitHub action too.

But the general idea, flow will be compatible with MOT implementation of this lambda? I don't think there are any breaking changes, so wanted to make sure you did not see any pitfalls or problems with this solution.

Yeah, looks good.


training  error

Thank you for sharing. I want to train spmnet on ISTD, but I got the error after some epochs:
C:\anaconda\envs\taka1\lib\site-packages\numpy\lib\polynomial.py:628: RuntimeWarning: invalid value encountered in true_divide
lhs /= scale
Intel MKL ERROR: Parameter 4 was incorrect on entry to DGELSD.
Traceback (most recent call last):
File "train.py", line 31, in
for i, data_i in enumerate(dataloader, start=iter_counter.epoch_iter):
File "C:\anaconda\envs\taka1\lib\site-packages\torch\utils\data\dataloader.py", line 521, in next
data = self._next_data()
File "C:\anaconda\envs\taka1\lib\site-packages\torch\utils\data\dataloader.py", line 561, in _next_data
data = self._dataset_fetcher.fetch(index)  # may raise StopIteration
File "C:\anaconda\envs\taka1\lib\site-packages\torch\utils\data_utils\fetch.py", line 49, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "C:\anaconda\envs\taka1\lib\site-packages\torch\utils\data_utils\fetch.py", line 49, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "C:\SynShadow\src\data\paired_dataset.py", line 82, in getitem
return self.postprocess(input_dict)
File "C:\SynShadow\src\data\base_dataset.py", line 49, in postprocess
d['input'], d['target'], d['mask'].squeeze())
File "C:\SynShadow\src\util\illum_affine_model.py", line 98, in fit_brightening_params
1
File "<array_function internals>", line 6, in polyfit
File "C:\anaconda\envs\taka1\lib\site-packages\numpy\lib\polynomial.py", line 629, in polyfit
c, resids, rank, s = lstsq(lhs, rhs, rcond)
File "<array_function internals>", line 6, in lstsq
File "C:\anaconda\envs\taka1\lib\site-packages\numpy\linalg\linalg.py", line 2306, in lstsq
x, resids, rank, s = gufunc(a, b, rcond, signature=signature, extobj=extobj)
File "C:\anaconda\envs\taka1\lib\site-packages\numpy\linalg\linalg.py", line 100, in _raise_linalgerror_lstsq
raise LinAlgError("SVD did not converge in Linear Least Squares")
numpy.linalg.LinAlgError: SVD did not converge in Linear Least Squares
Thanks.
I revise code in illum_affine_model.py line 100 except ValueError: -> except :
Then, I didn't get error.

On the other hand, when I trained spmnet on ISTD,w_l2 and b_l2 loss decreased fastly, but L1 loss didn't decrease. The results from this checkpoints are bad.
I trained spmnet on SynShadow(USR/shadowfree). W_l2 and b_l2 loss decreased slowly, and L1 loss also decreased. The results are good.
In addition,do you have some validation set to evaluate benchmark during training?

code modification
It seems OK but be careful you might ignore some errors that should be fixed.

bad results on ISTD
I haven't tested SP+M on the original ISTD dataset, since there is a non-negligible level of brightness inconsistencies between paired shadow/non-shadow images.
Have you tried ISTD+, where the problem is fixed?

Do you have some validation set to evaluate the benchmark during training?
I did not have it, but you can make it by splitting the data to keep some shadow-free and matte images only for validation.
Note that the performance on the 'synthetic' validation set may not highly correlate with the performance on the 'real' validation set due to the distribution change.


Add custom css for new newsletter signup

Prep for newsletter signup module: part of https://github.com/mapzen/website/issues/1468

Heyy so I gave approval, but I was wondering it would be better if we can stack these changes on staging, so we don't have to worry about syncing to master when we actually put this out. now some changes are going to staging and some are going to master, and I am bit worried it would be hard to sync two branches later.

Good note.  This will merge cleanly into either.  There are actually some other updates from master that should get into staging, so how about if we merge this into master, then rebase staging?

cool cool, I will remind myself to rebase our staging often while we are in this diverged depolyment phase.


Please, add @gpk.bme.hu

Please, add @gpk.bme.hu
We are the Faculty of Mechanical Engineering at the hungarian Budapest University of Technology and Economics (BME).
Homepage HU: https://gpk.bme.hu
Homepage EN: https://gpk.bme.hu/en

Our study programmes:

BSc
MSc
PhD

Educational units

@rbalazs-bme Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


Add delete_range method

Note that it also changes delete_prefix signature to be consistent with other methods there (prefix -> key_prefix, prev_kv keyword, descriptions in the docstring), and delete_range uses similar signature as well.

Should be all fixed up.

@mk-fg  could you please rebase the branch over upstream master?

Done.

Cherry-picked in https://github.com/martyanov/aetcd/commit/d7de6049bf5b7dc73e71cb988de0d180a93348f0.


Doesn't stage CHANGELOG.md if version_source configuration option is tag_only

Changelog and additional files should not be staged by publish() with update_changelog_file() and
update_additional_files() if the version_source configuration option is tag_only due to no
commit is added by bump_version().
Fixes #381

Commit message typo fixed.

Commit messages improved.

Commit messages improved again :(

Just got round to taking a look at this @sim6 - thanks for putting a PR together! :rocket:
However I'm not sure this is the way to fix the issue - I checked the docs and maybe the wording is ambiguous, but it does state:

If set to tag_only, then version_variable is ignored and no changes are made or committed to local config files. The current version from the latest tag matching vX.Y.Z. This won’t change the source defined in version_variable.

I wouldn't consider a changelog a config file... I might be irritated if I had a colleague that used a changelog as a config file, too :grin: what I'm getting at is - I think it's currently expected behaviour that PSR will manage the changelog file regardless of version_source, so this would be a breaking change. I would prefer this done with an explicit config setting like enable_changelog or something along those lines (with default true to get the same behaviour as now).
I'm going to close this - not because the effort isn't appreciated, just because I want to avoid those issues above. I think this code is a start towards implementing the new option though so if you want to raise a new PR later, please do. Thanks again!


HttpContext Method use Http Enum

Is your feature request related to a problem? Please describe.
Currently today Method in HttpRequest is exposed as a string. I'd like to propose also using the HttpMethod Enum. Any use of Action Filter or middleware has to do a string comparison of the method, and I believe exposing the enum would improve the experience of writing these.
Describe the solution you'd like
Add HttpMethod to the value
Describe alternatives you've considered
Current day, leaving it as a string
Additional context
The string makes it easier to handle situations where a method isn't passed in, so there are few potential issues, if there is no value passed in, HttpMethod would need to be set to None, and exposing both the enum and the string would add some additional overhead.
If this is approved I can tackle exposing this Enum.

BTW there's no limit to valid values of HTTP methods - you can have one called "JACOB" if you want, and it's perfectly valid. So, if there were an enum, you'd still have to have an "Unknown" value and fall back to a string.
See https://tools.ietf.org/html/rfc2616#section-5.1.1

Totally understandable, the enum would only cover the case of HTTP verbs, I see some precedence here, in the case that the string isn't any of the enums, I think unknown is fine. The property would explicitly be HttpMethod and if I sent in "JACOB" That's fine, it's an unknown http method, but not an unknown method. That difference makes sense to me, but I'm also not an expert.

As @Eilon says, we don't want to use an enum becuase the field is freeform. I believe we do some string interning kind of logic here though so that you can be confident that if the request provides GET, the value of this property will be the exact string instance in HttpMethods.Get. So you can optimally check for equality (with the same performance that checking an enum would have) using ReferenceEquals. In fact, there are utility methods in HttpMethods that you should use for this purpose:
if (HttpMethods.IsGet(request.Method)
{
	// ...
}

This gives you the performance expectations of an enum with the flexibility of a string.
Closing as we don't plan to expose an enum here given the options we currently provide.


shmop_close function has been DEPRECATED as of PHP 8.0.0

https://github.com/ip2location/ip2proxy-php/blob/f8a99a93b1ff91e1b091f1ddc4115c1801b43e70/src/Database.php#L584C8-L584C8
Add
if (PHP_MAJOR_VERSION < 8) { 	shmop_close($shmId); }

#17 https://github.com/ip2location/ip2proxy-php/commit/5696b0658888af22047fa9d34d65fff518e853cd


TODO: Support individual settlement force settlements

When a smartcoin has chosen the individual fund settlement option as its configured smartcoin recovery method, then when a debt position is undercollateralized it will be placed into an individual settlement fund as opposed to triggering a global settlement of the smartcoin.
These funds can be bid on through force settlements.
We should create a page to support this functionaltiy.

Now implemented.


FieldMask.toObject gives array of strings instead of expected comma separated string

What version of protobuf and what language are you using?
Version: v3.7.2
Language: Javascript
What operating system (Linux, Windows, ...) and version?
Linux Ubuntu 16.04
What runtime / compiler are you using (e.g., python version or gcc version)
protoc gcc version
What did you do?
Steps to reproduce the behavior:

Make proto file like the following:

message Company {
    uint64 id = 1;
    string name = 2;
    string address = 3;
    string city = 4;
    string zipcode = 5;
}
message UpdateCompanyRequest {
    Company company = 1;
    google.protobuf.FieldMask mask = 2;
}

Compile it to generate js & ts files using:
protoc --plugin="protoc-gen-ts=./node_modules/.bin/protoc-gen-ts" \  --js_out="import_style=commonjs,binary:./src/_models/proto" \ --ts_out="./src/_models/proto" \ proto/company.proto proto/identifiers.proto proto/site.proto \ -I./proto
Use new compiled proto into ts code like this:

            const company = new Company()
            company.setId(1)
            company.setName("name")
            company.setCity("city")
            company.setAddress("address")
            company.setZipcode("zipcode")
            const mask = new FieldMask()
            mask.addPaths("name")
            mask.addPaths("address")
            const update: UpdateCompanyRequest = new UpdateCompanyRequest()
            update.setMask(mask)
            update.setCompany(company)

            console.log(update.toObject())

What did you expect to see
{
    "company:{
        "id":1,
        "name":"name",
        "address":"address",
        "city":"city",
        "zipcode":"zipcode"
    },
    "mask":"name,address"
}

What did you see instead?
{
    "company:{
        "id":1,
        "name":"name",
        "address":"address",
        "city":"city",
        "zipcode":"zipcode"
    },
    "mask":{
        "pathsList": [
            "name",
            "address"
        ]
    }
}

This is not supported because toObject is not intended to output proto3 JSON.


update chart version from v1.3.2 to v1.3.4

What type of PR is this?
/kind documentation
What this PR does / why we need it:
update chart version for release v1.3.2
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@rambohe-ch  PTAL

/lgtm


Use a bytes buffer internally in the logs prefixer

What does this PR do?
The logs prefixer prepends a prefix to passed bytes per-destination. Our profiles flag the apply function as allocation center. Considering that each destination maintains an instantiated prefixer we can elide some of that allocation pressure through the use of a buffer.
Note also we avoid converting the passed prefix from a string to bytes, storing it as a string internally.
Motivation
Reduce allocation load in the Agent.
Possible Drawbacks / Trade-offs
If a particularly large content is passed to apply we will size the bytes.Buffer up to accommodate it. This space is not reclaimed. Previously we would incur the same allocation pattern but temporarily as the heap allocation would subsequently be freed.
Describe how to test/QA your changes
I expect most of the result to come in the regression detector results and in profiles. I'll link those below when ready.
Related
REF #19125
REF SMP-664

Alright, throughput is not up enough to pass threshold but the comparison profile suggests:

improved allocations per second
a drop in total allocated memory for tcp_syslog_to_blackhole experiment
the total byte count of live heap objects is reduced and
the heap objects that remain are comparatively larger.

I think a similar approach could be taken to the delimiter code indicated here or if the prefixer and delimiter are only used in one call site they might be fused profitably.


[SPARK-29082][core] Skip delegation token generation if no credentials are available.

This situation can happen when an external system (e.g. Oozie) generates
delegation tokens for a Spark application. The Spark driver will then run
against secured services, have proper credentials (the tokens), but no
kerberos credentials. So trying to do things that requires a kerberos
credential fails.
Instead, if no kerberos credentials are detected, just skip the whole
delegation token code.
Tested with an application that simulates Oozie; fails before the fix,
passes with the fix. Also with other DT-related tests to make sure other
functionality keeps working.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15605/
Test PASSed.

Test build #110629 has started for PR 25805 at commit e6efb06.

Test build #110629 has finished for PR 25805 at commit e6efb06.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110629/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15835/
Test PASSed.

Test build #110671 has started for PR 25805 at commit 29b069d.

Test build #110671 has finished for PR 25805 at commit 29b069d.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110671/
Test FAILed.

Retest this please.

Test build #110723 has started for PR 25805 at commit 29b069d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15876/
Test PASSed.

Test build #110723 has finished for PR 25805 at commit 29b069d.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110723/
Test FAILed.

Doc failure seems unrelated.

retest this please

Test build #110744 has started for PR 25805 at commit 29b069d.

Merged build finished. Test PASSed.

Test build #110744 has finished for PR 25805 at commit 29b069d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110744/
Test FAILed.

[error] running /home/jenkins/workspace/SparkPullRequestBuilder@2/build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos test:package streaming-kinesis-asl-assembly/assembly ; process was terminated by signal 9

retest this please

Test build #110775 has started for PR 25805 at commit 29b069d.

Test build #110775 has finished for PR 25805 at commit 29b069d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110775/
Test FAILed.

Maybe it's related since No UGI and Proxy user tests are failing.

Hmm, that's a new test IIRC, I'll take a look at what's going on.

The Hive tests passed locally for me. Maybe just needed a merge with master...

retest this please

Test build #110814 has started for PR 25805 at commit c46d76d.

Test build #110798 has started for PR 25805 at commit c46d76d.

Test build #110815 has started for PR 25805 at commit c150238.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15932/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15947/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15946/
Test PASSed.

Test build #110814 has finished for PR 25805 at commit c46d76d.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110814/
Test FAILed.

Test build #110815 has finished for PR 25805 at commit c150238.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110815/
Test FAILed.

retest this please

Test build #110820 has started for PR 25805 at commit c150238.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15952/
Test PASSed.

Test build #110820 has finished for PR 25805 at commit c150238.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110820/
Test FAILed.

retest this please

(Looks like maven metadata is corrupt everywhere after Jenkins was restarted...)

Test build #110823 has started for PR 25805 at commit c150238.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15955/
Test PASSed.

Test build #110798 has finished for PR 25805 at commit c46d76d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110798/
Test PASSed.

Ack. Updated the wrong branch...

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15966/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15968/
Test PASSed.

Test build #110823 has finished for PR 25805 at commit c150238.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110823/
Test PASSed.

Ok, no more comments, I'll merge to master.

Hi, All.
This seems to break our Jenkins one profile consistently. Could you guys take a look please?

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-3.2-jdk-11/

- zero-partition RDD *** FAILED ***
  java.io.IOException: Can't get Master Kerberos principal for use as renewer
  at org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:134)
  at org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:102)
  at org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodes(TokenCache.java:81)
  at org.apache.hadoop.mapred.FileInputFormat.listStatus(FileInputFormat.java:216)
  at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:325)
  at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:205)
  at org.apache.spark.rdd.RDD.$anonfun$partitions$2(RDD.scala:256)
  at scala.Option.getOrElse(Option.scala:189)
  at org.apache.spark.rdd.RDD.partitions(RDD.scala:254)
  at org.apache.spark.rdd.MapPartitionsRDD.getPartitions(MapPartitionsRDD.scala:49)

Sorry guys. Until now, I cannot find a solution for this. I'll revert this one to unblock our JDK11 monitoring. Please make another PR and test with [test-hadoop3.2][test-java11].

FYI, all the failures are recovered and the Jenkins is continuing to the next step. If this doesn't hide the other failure during the outage, I guess the Jenkins will pass.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-3.2-jdk-11/443/

FileSuite:
- text files
- text files (compressed)
- text files do not allow null rows
- SequenceFiles
- SequenceFile (compressed)
- SequenceFile with writable key
- SequenceFile with writable value
- SequenceFile with writable key and value
- implicit conversions in reading SequenceFiles
- object files of ints
- object files of complex types
- object files of classes from a JAR
- write SequenceFile using new Hadoop API
- read SequenceFile using new Hadoop API
- binary file input as byte array
- portabledatastream caching tests
- portabledatastream persist disk storage
- portabledatastream flatmap tests
- SPARK-22357 test binaryFiles minPartitions
- minimum split size per node and per rack should be less than or equal to maxSplitSize
- fixed record length binary file as byte array
- negative binary record length should raise an exception
- file caching
- prevent user from overwriting the empty directory (old Hadoop API)
- prevent user from overwriting the non-empty directory (old Hadoop API)
- allow user to disable the output directory existence checking (old Hadoop API)
- prevent user from overwriting the empty directory (new Hadoop API)
- prevent user from overwriting the non-empty directory (new Hadoop API)
- allow user to disable the output directory existence checking (new Hadoop API
- save Hadoop Dataset through old Hadoop API
- save Hadoop Dataset through new Hadoop API
- Get input files via old Hadoop API
- Get input files via new Hadoop API
- spark.files.ignoreCorruptFiles should work both HadoopRDD and NewHadoopRDD
- spark.hadoopRDD.ignoreEmptySplits work correctly (old Hadoop API)
- spark.hadoopRDD.ignoreEmptySplits work correctly (new Hadoop API)
- spark.files.ignoreMissingFiles should work both HadoopRDD and NewHadoopRDD

Yeah, I found this caused tests to fail locally too, so it's at least not specific to Jenkins (or Java 11)

In addition to this, one another big issue is that one Python UT failure blocks spark-master-test-sbt-hadoop-2.7 for a long time until now.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.7/

Having a look but jdk11 has to be set up locally where I have some difficulty...

We've found the issue with the help of @squito so going to file a PR soon with the required change...

Great! Thank you, @gaborgsomogyi and @squito !


Suggest adding the PhExecuteRunAsCommand3 function to the output API list in the SystemInformer.def file

Description of the feature, modification, idea or suggestion
I used the SystemInformer project as a DLL to call functions inside, which is very useful. Thank you for this great project!
Suggest adding the PhExecuteRunAsCommand3 function to the output API list in the SystemInformer.def file!
In order to conveniently call this function to specify the user to run the program.
Proposed implementation details (optional)
No response

We only use the definition file for library exports and when they're required for plugin support. This function probably won't be exported because it's not used by plugins but feel free to compile your own builds with changes to the exports 👍


Issue with InstantIR_Loader: Shape Mismatch in conv_in.weight

When attempting to use the InstantIR_Loader, an error occurs due to a shape mismatch in conv_in.weight. The loader is expecting the shape tensor(..., device='meta', size=(320, 4, 3, 3)), but it receives torch.Size([320, 9, 3, 3]).
The error message suggests that if the intention is to overwrite the randomly initialized weights, it is necessary to pass both low_cpu_mem_usage=False and ignore_mismatched_sizes=True.
Error Message:Cannot load because conv_in.weight expected shape tensor(..., device='meta', size=(320, 4, 3, 3)), but got torch.Size([320, 9, 3, 3]). If you want to instead overwrite randomly initialized weights, please make sure to pass both low_cpu_mem_usage=False and ignore_mismatched_sizes=True. For more information, see also: huggingface/diffusers#1619 (comment).

I need to see which code process the error occurred in. This is just the result of the error, and I can't help you with anything. You can try using a different SDXL model


Android TV navigation impossible

With Android TV and the D-Pad, the navigation is imposible. The only thing you can do is opening the hamburger menu and perform a search. No list selections possible.

Hey, can you try the latests 1.5.2 build from http://bit.ly/2cnXaUx and see if that solved this problem?
I've enabled some dpad navigation but I don't have a device/TV to fully test this

Menu selection works now fine, but I can't select a movie with the D-pad...

Same for me (FireTV - Movie selection only possible with external mouse), would really welcome this feature.
Except this Problem everything is working great!

It's working for me now too! Awesome! Only two complains: the app does not show up in the Leanback launcher and you can't use voice search. But otherwise it's great!

@krmax44 please try 1.5.3-rc1 from here. This should add Leanback and voice search.
Since I don't have a Android TV I could only test voice search which worked fine on my phone.

It shows up in the launcher now, awesome! Voice search does work on my phone, but not really on my TV. It's fine, I'll just use my phone to type it in. Thanks for putting all the stuff in the app, I appreciate it a lot!


Pickup latest ubpf and fix breaking changes

Description
Pickup the latest version of uBPF and update the function signature to address the breaking changes.
Testing
CI/CD
Documentation
No.
Installation
No.

@Alan-Jowett do you want to close PR #3551 then?


Add tests for Json type

Closes #40.
The test is almost completely copied from @metamask/types, with just one small adjustment. The following test would result in a compile-time type error:
// The Json type is too accepting of types. This type isn't valid Json because
// it can contain `undefined`, but the Json type allows it.
type TypeWithOptionalProperty = {
  a?: number;
};
const typeWithOptionalProperty: TypeWithOptionalProperty = { a: undefined };
expectAssignable<Json>(typeWithOptionalProperty);

TS2375: Type '{ a: undefined; }' is not assignable to type 'TypeWithOptionalProperty' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.

I added undefined to a's type, which makes it not assignable to Json, which seems to be the behaviour we want.

@Gudahtt Pinging you on this PR since you added these types originally!


Fix missing data-x-out-of-boundaries attribute

Current behavior
No support for https://popper.js.org/popper-documentation.html#modifiers..hide.
Expected behavior
Full support for modifiers.hide, specifically that the data-x-out-of-boundaries attribute is passed along.
Changes
Passes along the data-x-out-of-boundaries attribute in a similar manner to data-placement.
Why
We needed this in our app. More importantly, we saw no reason a wrapper around Popper shouldn’t support this.
How this has been tested
Confirmed build still works. Confirmed expected example behavior when running dev after modifying the Popper config like so:
const modifiers = {
  customStyle: {
    // ...unchanged
  },
  preventOverflow: {
    boundariesElement: 'viewport',
  },
  hide: {
    enabled: true,
  },
}

Hi, @souporserious. Have you had a chance to consider this? We still need it within our app, and would love to not have to rely on my fork.

You may create a custom modifier to add this missing piece of logic. It's fairly easy

Or directly use the data object to obtain this info

Sorry, I've been super busy lately and just getting around to this. Looks good! Thanks!

Thanks, Travis!


Update README.md

Related issue
Adding my name

What changes does this PR do?
Added my name into Readme file.

Screenshots (If any)
Questions

Kindly apply the changes listed in the review

i think it is better , it actually solves an error ..no need to revert it

@vedanshi555 recheck the requirements in the Readme or the past PRs, none of them listed that we should linter spaces or lines.  Kindly check past PRs for reference

@vedanshi555 Well then I owe you an apology, I'm sorry, you're right. I didn't know this so I played by the rules.
Thanks for the heads up 😄

@vedanshi555 Well then I owe you an apology, I'm sorry, you're right. I didn't know this so I played by the rules. Thanks for the heads up 😄

that's okay!


Swift memory leaks

I've subclassed JSQMediaItem to create a custom photo item and it causes it to be memory retained.
I create my item when I create JSQMessage:
JSQMessage(senderId: String(self.sender.id), displayName: "\(self.sender.firstName) \(self.sender.lastName)", media: PhotoChatItem(message: self))
Chat controller is released but PhotoChatItem is never released. I've just a simple empty subclass:
class PhotoChatItem:JSQMediaItem{

    init(message:MyMessage) {
        super.init(maskAsOutgoing: false)
    }

    required init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }
}

What can cause the memory issue?
Edit: I'm using Instruments to see allocation count and PhotoChatItem allocations number only grows.

Thanks @bitomule ! :smile:
This doesn't seem specific to the library. StackOverflow is a more appropriate place to ask this question. :blush:
I'm going to close this issue, but the community should feel free to continue the discussion here.
Other ways to get help:

Ask on StackOverflow with the jsqmessagesviewcontroller tag
See the FAQ
Search previous questions


LetsEncrypt notice turning off v0.2, what version do we need?

Earlier this week we received the following email from LetsEncrypt:
Hello,

Action is required to prevent your Let's Encrypt certificate renewals from
breaking.

You have been using the jetstack-cert-manager/v0.2 client to access the Let's
Encrypt API in the past 60 days, from the IP address  <IP_ADDRESS> .

This version of jetstack-cert-manager is very aggressive about retrying its
requests, and has been sending our API many requests per second that it will
never complete successfully. We plan to block all API requests from this
version shortly.

We've worked with Jetstack to release an update. Please update to the latest
version of cert-manager, which will reduce the amount of traffic you are
sending to Let's Encrypt. Without an update, your certificate renewals will
break and existing certificates will start to expire.

[...]

Thank you,
Let's Encrypt Staff

Looking at the logs, 0.3.2 still makes a lot of requests to letsencrypt from what I can see. We're looking to make the upgrade for cert-manager to a version where this is no longer an issue, since this is a side-project we don't have a huge amount of time to commit to upgrading the whole way and debugging any issues.
Is there a safe version we can move towards which will not be turned off by LetsEncrypt? I'm assuming you folks know and have had some level of communication with them, if not then I can contact them directly instead.

I got the same email

Does anyone have any guidance on this issue? I'm assuming LetsEncrypt would have communicated with the cert-manager maintainers in some way, it would be great to have some information if anyone has some 😄 Needless to say this is a bit worrying for us given that it's a production impact and we don't quite know when it'll happen.

I've just come across this information on the Let's Encrypt Community Support forum. Here are the relevant excerpts.

jsha - Let's Encrypt engineer
Thanks for the feedback, rvandegrift! We generally try to provide more advance notice. In this case we had to act fast because all the extant v0.2 clients hit their bug at once, causing a massive increase in traffic for us.
Also, I’d encourage you to keep your cert-manager up-to-date per our Integration Guide 4.
Thanks for the quick fix, and apologies for the short notice!

kingjulianza
Is it only v0.2 being blocked? [...]

ezekiel - Let's Encrypt staff
At this time, only versions like v0.2.* are affecting us in such a way that it prompts a block.

[...]

ezekiel - Let's Encrypt staff
I’ve just verified that this change has made it into the Production environment.

So TLDR; this only affects v0.2.x and it is already in production for Let's Encrypt as of a 1 day ago.
We will attempt to update to the latest over the comming weeks to elivate the issue anyway.


Day view: how to customize the grid row height?

Version
1.9.1
Is there a possibility to set height of the hour grid row in the Day view? I could not find it in the options.
Another option would be to stretch it according to the schedule(s) height, if I use custom height for schedules.
Thanks,
Yakov

Hi ! Thanks a lot for this great work !
I have a very similar question to this one, so that's why I write here : I can't see any similar option to set the row's height on a month view calendar... is it possible to do it ?

Thanks!
https://reinaldoamaral.net/galeria/index.php/home/brasil-central
https://reinaldoamaral.net/galeria/index.php/home/brasil-central

Em 04/04/2563 BE, à(s) 01:34, Lekterx<EMAIL_ADDRESS>escreveu:
Hi ! Thanks a lot for this great work !
I have a very similar question to this one, so that's why I write here : I can't see any similar option to set the row's height on a month view calendar... is it possible to do it ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/nhn/tui.calendar/issues/263#issuecomment-608972139, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFS5ENPGNFYHH47QS55RPTRK22GNANCNFSM4GR4TLAA.

The problem exists with new version of TuiCalendar as @YashkaSurin provided config values does not seem to work. How could I fix it with current config keys, values?


"Mapping" a union of disjoint types

I have a union of disjoint types, and I have a type that is parameterized on those disjoint types. I want the second type to accept only specific members of the union, ie. it should prevent mixing-and-matching between the different subtypes.
Is there a way to do this without having to list each of the different subtypes individually in a new union?
Example:
type Wobble = {|
  type: 0,
  wobbliness: number,
|};

type Dohicky = {|
  type: 1,
  use: string,
|};

type Doodle = {|
  type: 2,
  bitmap: string,
|};

type Thing =
  | Wobble
  | Dohicky
  | Doodle;

type InflightRequest<T: $Subtype<Thing>> = {|
  requestType: $PropertyType<T, 'type'>,
  resolve: (thing: T) => void,
|};

// I want this array to only accept matching requestType/resolve
const arrayOfRequests: Array<InflightRequest<$Subtype<Thing>>> = [];
arrayOfRequests.push({
  requestType: 0,
  resolve: (thing: Dohicky) => {}, // should error
});

// This works, but I'd prefer not to have to write everything out
type InflightThingRequest =
  | InflightRequest<Wobble>
  | InflightRequest<Dohicky>
  | InflightRequest<Doodle>;
const arrayOfThingRequests: Array<InflightThingRequest> = [];
arrayOfThingRequests.push({
  requestType: 0,
  resolve: (thing: Dohicky) => {}, // does error
});

Try Flow link

You can’t “map” over the union directly, but you can map over a helper
type in a readable and reusable way:
type Wobble = {| type: 0, wobbliness: number |};
type Dohicky = {| type: 1, use: string |};
type Doodle = {| type: 2, bitmap: string |};

// Utility type; never instantiated.
type Things = {
  Wobble: Wobble,
  Dohicky: Dohicky,
  Doodle: Doodle,
};
type Thing = $Values<Things>;

type InflightRequestT<T: Thing> = {|
  requestType: $PropertyType<T, 'type'>,
  resolve: (thing: T) => void,
|};
type InflightRequests = $ObjMap<Things, <T>(T) => InflightRequestT<T>>;
type InflightRequest = $Values<InflightRequests>;

(See: $ObjMap docs.)
Flow type-at-pos says:
type InflightRequest =
  | InflightRequestT<Wobble>
  | InflightRequestT<Doodle>
  | InflightRequestT<Dohicky>;

which was what was wanted.
This appears to correctly admit correct programs and correctly raise an
error on incorrect programs, but in the case of an incorrect program the
errors can be unhelpful compared to the version in which you have
explicitly written out the InflightRequest type. For instance, writing
const requests: InflightRequest[] = [
  { requestType: 1, resolve: (thing: Dohicky) => {} },
];

correctly typechecks, and
const requests: InflightRequest[] = [
  { requestType: 2, resolve: (thing: Dohicky) => {} },
];

correctly fails to typecheck, while
const requests: InflightRequest[] = [
  { requestType: 0, resolve: (thing: Dohicky) => {} },
  { requestType: 1, resolve: (thing: Dohicky) => {} },
];

also correctly fails to typecheck, but raises errors for
both elements of the array rather than just the problematic one.
A benefit of this approach is that you can reuse the Things type for
other $ObjMaps (say, a CompletedRequest type).

(Aside: prefer type X<T: Thing>, not type X<T: $Subtype<Thing>>. The
constraint is already a subtyping constraint. The two may be equivalent
here, but $Subtype in general is unsafe (and poorly documented), and
should be avoided.)

 Thank you for your service. I figured it'd have to do with $ObjMap, but never considered the idea of a utility type. Will definitely be adding to the mental tool chest.
I am running into some issues trying to actually call the "resolve" function. This code errors using both the manual way I used in the OP, and the $ObjMap method:
function resolveThing(thing: Thing) {
  for (let request of requests) {
    if (thing.type === request.requestType) {
       request.resolve(thing);
    }
  }
}

With the manual definition, it's possible to placate the typechecker with unnecessary runtime checks, but for some reason this doesn't work with the $ObjMap method:
function resolveThing(thing: Thing) {
  for (let request of manuallyTypedRequests) {
    if (thing.type === 0 && request.requestType === 0) {
       request.resolve(thing);
    } else if (thing.type === 1 && request.requestType === 1) {
       request.resolve(thing);
    } else if (thing.type === 2 && request.requestType === 2) {
       request.resolve(thing);
    }
  }
}

Try Flow link
Thanks again for your help!

 Thank you for your service. I figured it'd have
to do with $ObjMap, but never considered the idea of a utility type.
Will definitely be adding to the mental tool chest.

Happy to help. It’s a good trick to have in hand.

I am running into some issues trying to actually call the "resolve"
function. This code errors

Yeah, this is a really annoying behavior of Flow. The simplest repro
that I’ve been able to find is
// @flow
type A = {| +type: "A" |};
type B = {| +type: "B", +value: number |};
type O = A | B;
function f(o: O): O {
  return {...o};  // fails!
}
function g(o: O): O {
  return o.type === "A" ? {...o} : {...o};  // works...
}

but for some reason this doesn't work with the $ObjMap method:

Ugh. That’s strange, and definitely a bug. I don’t have enough
visibility into Flow’s internals to be able to diagnose it, sorry.

Managed to get the disjoint-ness passed down using the $ObjMap
method by just adding an $Exact to the function type return:

Good catch. This is #5853, then. Glad that you found a solution.


chore: bdd-spring-1575972524 to 0.0.1

chore: Promote bdd-spring-1575972524 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


0.00_ parse error

0.00_ parse error:
SyntaxError: Illegal character: 0.00_ (at parseFormatSection.js:436:13)
at parseFormatSection (parseFormatSection.js:436:13)
at parsePattern (parsePattern.js:48:12)
at prepareFormatterData (index.js:45:19)

That seems to be correct behavior. 0.00_ is not a legal format pattern and should throw an error.
If you want the formatter to handle invalid patterns for you, you need to enable that via an option:
format("0.00_", 12.34, { throws: false }); // → "######"

Also, consider - if you think this pattern comes from a trusted source, that you may have an error in you application that it is trimming the pattern strings where it should not: 0.00_  is a valid pattern.


Download expiry for getfilelink() URL

Uploaded a file. Used getfilelink(fileId)  to generate link
Link worked fine yesterday
Today I get "Your download expired. Try previous step again."
How do I fix this? How to extend expiry time?
The only options are:
forcedownload | int Download with Content-Type = application/octet-stream
contenttype | string Set Content-Type
maxspeed | int limit the download speed
skipfilename | int include the name of the file in the generated link

Every time you need to download a file you have to call getfilelink and use the link immediately. All our clients work that way. This is bacause files are being stored on different storage servers and they could be moved.


Local search

Reference

https://github.com/gvsucis/art-at-gvsu-android/blob/f2ca68cddda7dc2a8aa285929face4a0c9d61712/app/src/main/java/edu/gvsu/art/gallery/ui/SearchIndexSearchBar.kt#L25-L39

https://github.com/jocmp/capyreader/discussions/296

I would also like to have a search. For me searching all titles would do. I read many feeds, and being able to search the titles for keywords would be of help. I still use
https://f-droid.org/packages/ru.yanus171.feedexfork/
in parallel as this is the only one I know of with a search feature.
Thank you for giving us your good app!

@rudolfmu thanks for trying out the app. I'm still planning on article search either after I complete #199 or #196. That makes sense to search titles. I also want search to look at article summaries when they're available.

My main point is searching titles. I read about something two days ago and need to reread it. I have hundreds a day, so visual search is cumbersome.
If I need a more global search I can also use my favorite web search.
So if it is easier to just implement a title search, that would do. If it makes little difference, a complete search would also be fine.

Local search is available as of 2024.08.1036-dev. The feature will search exact text matches in the article's title or summary within the current drawer section. If you search in "All," your search will match against all articles. Changing to "Unread" will only search unread articles, and changing to a tag or feed will only search within that selection.

Thank you very much!


Add Grid Search Experiments

This PR contains the grid search experiments with the post processing parameters for the distances.

I'll go ahead and close this, as this has been implemented in micro-sam now.


flask run throws ImportError: No module named azure.storage.blob

% flask run
Usage: flask run [OPTIONS]
Error: While importing "app", an ImportError was raised:
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/cli.py", line 240, in locate_app
import(module_name)
File "/Users/cindybishop/Documents/GitHub/chomskyvschomsky/chomskyPipeline/app.py", line 4, in
from azure.storage.blob import BlobServiceClient, BlobClient, ContainerClient, version
ImportError: No module named azure.storage.blob
this doesn't happen if I run python3 app.py

I had to do this from within a venv and it is running now


Please update dependencies !

Please make node-sass-middleware cool again :+1:

Updated, for reference it doesn't matter unless the major version changes. See #74 for further explanation.


Port ML changes

PR in Main : (#12674)
Co-authored-by: Alan Ren<EMAIL_ADDRESS>
This PR fixes #
https://github.com/microsoft/azuredatastudio/issues/12744

Pull Request Test Coverage Report for Build 290043883

20 of 20 (100.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 38.872%

Files with Coverage Reduction
New Missed Lines
%

extensions/machine-learning/src/views/widgets/dashboardWidget.ts
1
94.03%

Totals

Change from base Build 285049508:
-0.005%

Covered Lines:
19231

Relevant Lines:
45145

💛  - Coveralls


Disable magnum in develcloud8

The magnum barclamp currently fails to deploy
in develcloud8 because some packages are missing
from Devel:Cloud:8 (python-kubernetes and
python-marathon).
This commit temporarily disables magnum in develcloud8
in order to get Jenkins jobs to pass over the point
where they try to deploy magnum and fail.
This is required to unblock the mkcloud8 gating job.

Please don't merge this yet, it will have no effect on scenario based jobs (e.g. the mkcloud8 gating job). Need to address this too.

@rsalevsky @aplanas please re-review and confirm that this is still ok. I ran an mkcloud-job-2-nodes-x86_64 job with these modifications and the magnum barclamp was skipped just as intended.

@aplanas sure I will, as soon as this one gets merged


Update energy-secondary.yaml

Add secondary energy|electricity|electricity storage type
COmplement to #196

@loeffko agreed

I propose to delete this PR as , as mentioned by @loeffko , 'storages', except for Hydro, do not produce electricity. Hydro is already icnluded in the variables names via {Electricity Input}, and we don't want a variable such as Secondary Energy|Electricity|Lithium-Ion


The docker-outside-docker feature fails to load

I can't get the docker-outside-docker feature to work anymore.  This was working for me recently.  I have read about workarounds related to how the apt repo is configured, but nothing I have tried works for me.
Repro steps

Open an empty folder in vscode.
Invoke the vscode command Remote-Containers: Add Development Container Configuration Files and then respond to the prompts as follows:

Container definition
C# (.NET)
.NET version
6.0-bullseye (default)
Node.js version
none
Additional feature:
Docker (moby) support (Docker-in-Docker)
Docker/Moby engine version
20.10

Invoke the vscode command Remote-Containers: Rebuild and Reopen in Container

Expected result
I expect the devcontainer to successfully build and open.
Actual result
The devcontainer fails to build and gives an error.  Here is the error.
The repository 'https://dl.yarnpkg.com/debian stable InRelease' is not signed.

Here is the full devcontainer log.

remoteContainers-2023-01-24T21-54-52.896Z.log

Here's a small portion of the end of the log.
------
 > [dev_containers_target_stage 2/2] RUN cd /tmp/build-features/docker-in-docker_1 && set -a && . ./devcontainer-features.env && set +a && chmod +x ./install.sh && ./install.sh:
#0 1.121 DOCKER_MOBY_ARCHIVE_VERSION_CODENAMES=buster bullseye bionic focal jammy
[2023-01-24T21:55:00.293Z]
#0 1.121 Distro codename  'bullseye'  matched filter  'buster bullseye bionic focal jammy'
#0 1.128 find: '/var/lib/apt/lists/*': No such file or directory
#0 1.128 Running apt-get update...
#0 1.161 Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB]
#0 1.169 Get:2 http://deb.debian.org/debian-security bullseye-security InRelease [48.4 kB]
[2023-01-24T21:55:00.293Z] #0 1.169 Get:3 http://deb.debian.org/debian bullseye-updates InRelease [44.1 kB]
#0 1.203 Get:4 https://dl.yarnpkg.com/debian stable InRelease [17.1 kB]
#0 1.271 Get:5 http://deb.debian.org/debian bullseye/main amd64 Packages [8183 kB]
#0 1.368 Get:6 http://deb.debian.org/debian-security bullseye-security/main amd64 Packages [216 kB]
[2023-01-24T21:55:00.293Z]
#0 1.466 Get:7 http://deb.debian.org/debian bullseye-updates/main amd64 Packages [14.6 kB]
#0 1.514 Err:4 https://dl.yarnpkg.com/debian stable InRelease
#0 1.514   The following signatures were invalid: EXPKEYSIG 23E7166788B63E1E Yarn Packaging<EMAIL_ADDRESS>[2023-01-24T21:55:00.293Z]
#0 2.280 Reading package lists...
#0 2.725 W: GPG error: https://dl.yarnpkg.com/debian stable InRelease: The following signatures were invalid: EXPKEYSIG 23E7166788B63E1E Yarn Packaging<EMAIL_ADDRESS>#0 2.725 E: The repository 'https://dl.yarnpkg.com/debian stable InRelease' is not signed.
[2023-01-24T21:55:00.293Z] ------
[2023-01-24T21:55:00.293Z] ERROR: failed to solve: executor failed running [/bin/sh -c cd /tmp/build-features/docker-in-docker_1 && set -a && . ./devcontainer-features.env && set +a && chmod +x ./install.sh && ./install.sh]: exit code: 100
[2023-01-24T21:55:00.297Z] Stop (8493 ms): Run: docker buildx build --load --build-arg BUILDKIT_INLINE_CACHE=1 -f /tmp/vsch-azureuser/container-features/0.251.0-1674597291376/Dockerfile-with-features -t vsc-devcontainer-docker-outside-docker-error-bed6397d70acb3b5890795ea56a2cef4 --target dev_containers_target_stage --build-arg VARIANT=6.0-bullseye --build-arg NODE_VERSION=none --build-context dev_containers_feature_content_source=/tmp/vsch-azureuser/container-features/0.251.0-1674597291376 --build-arg _DEV_CONTAINERS_BASE_IMAGE=dev_container_auto_added_stage_label --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp /home/azureuser/repos/devcontainer-docker-outside-docker-error/.devcontainer
[2023-01-24T21:55:03.319Z] Error: Command failed: docker buildx build --load --build-arg BUILDKIT_INLINE_CACHE=1 -f /tmp/vsch-azureuser/container-features/0.251.0-1674597291376/Dockerfile-with-features -t vsc-devcontainer-docker-outside-docker-error-bed6397d70acb3b5890795ea56a2cef4 --target dev_containers_target_stage --build-arg VARIANT=6.0-bullseye --build-arg NODE_VERSION=none --build-context dev_containers_feature_content_source=/tmp/vsch-azureuser/container-features/0.251.0-1674597291376 --build-arg _DEV_CONTAINERS_BASE_IMAGE=dev_container_auto_added_stage_label --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp /home/azureuser/repos/devcontainer-docker-outside-docker-error/.devcontainer
[2023-01-24T21:55:03.320Z]     at OF (/home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js:258:1490)
[2023-01-24T21:55:03.320Z]     at processTicksAndRejections (node:internal/process/task_queues:96:5)
[2023-01-24T21:55:03.320Z]     at async Wf (/home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js:257:2801)
[2023-01-24T21:55:03.320Z]     at async pb (/home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js:257:1779)
[2023-01-24T21:55:03.320Z]     at async DF (/home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js:263:2006)
[2023-01-24T21:55:03.320Z]     at async to (/home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js:263:3110)
[2023-01-24T21:55:03.320Z]     at async Ak (/home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js:383:8108)
[2023-01-24T21:55:03.321Z]     at async Ok (/home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js:383:7864)
[2023-01-24T21:55:03.327Z] Stop (9153 ms): Run in Host: /home/azureuser/.vscode-server/bin/97dec172d3256f8ca4bfb2143f3f76b503ca0534/node /home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js up --workspace-folder /home/azureuser/repos/devcontainer-docker-outside-docker-error --workspace-mount-consistency cached --id-label devcontainer.local_folder=/home/azureuser/repos/devcontainer-docker-outside-docker-error --log-level debug --log-format json --config /home/azureuser/repos/devcontainer-docker-outside-docker-error/.devcontainer/devcontainer.json --default-user-env-probe loginInteractiveShell --remove-existing-container --mount type=volume,source=vscode,target=/vscode,external=true --skip-post-create --update-remote-user-uid-default on --mount-workspace-git-root true
[2023-01-24T21:55:03.327Z] Exit code 1
[2023-01-24T21:55:03.331Z] Command failed: /home/azureuser/.vscode-server/bin/97dec172d3256f8ca4bfb2143f3f76b503ca0534/node /home/azureuser/.vscode-remote-containers/dist/dev-containers-cli-0.251.0/dist/spec-node/devContainersSpecCLI.js up --workspace-folder /home/azureuser/repos/devcontainer-docker-outside-docker-error --workspace-mount-consistency cached --id-label devcontainer.local_folder=/home/azureuser/repos/devcontainer-docker-outside-docker-error --log-level debug --log-format json --config /home/azureuser/repos/devcontainer-docker-outside-docker-error/.devcontainer/devcontainer.json --default-user-env-probe loginInteractiveShell --remove-existing-container --mount type=volume,source=vscode,target=/vscode,external=true --skip-post-create --update-remote-user-uid-default on --mount-workspace-git-root true
[2023-01-24T21:55:03.331Z] Exit code 1

Looks like this is related to Yarn's GPG key expiring. Closing as a duplicate of https://github.com/devcontainers/images/issues/370 which is tracking rebuilding and releasing new images with an updated Yarn key.

Thank you!


read_dimensions conversion can read value from name incorrectly

The aX category naming convention used to draw a value from the category name (e.g. cat_namea1) is being evaluated for each category in a variable one at a time, which means the results can be inconsistent if some category names satisfy the convention and others don't.
The convention needs to be evaluated for an entire variable and then applied or avoided for all categories in that variable accordingly.

Resolved by #841.


[plot] Split profile into manager and toolbar

It would be much better to have a stateless toolbar, with all the logic inside another class for flexibility.
That's something which can be done to avoid duplication code between flint and silx.

Closed by  #3011