rrd support

I've read that graphite can be used to provide information from existing rrd files by simply linking them to the appropriate directory. Am I right in assuming that this is a feature of graphite-web only? I cannot get this to work with graphite-api and from logical assumptions, it would probably require an "rrd finder", correct?

I am going to give this a try soon.

Ok, does that mean I can not serve rrd files with graphite-api
or am I doing something wrong?


Close #2625 by updating method to enable Dependabot security updates

Why:
As mentioned in #2625, the documentation for enabling automated Dependabot security updates appears to be out-of-date.

What's being changed:
I'm changing steps two, three and four of the "Managing Dependabot security updates for your repositories" section of the "Configuring Dependabot security updates" page to match what I think is the new user interface for enabling Dependabot security updates.
In this pull request, I removed what I think is an out-of-date screenshot and replaced it with a screen capture that I think matches the current user interface.

Original:

Appearance with changes from this pull request:

Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

@hamirmahal Thanks so much for opening a PR! I'll get this triaged for review ✨

@hamirmahal Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene You're welcome! Happy to help.

@janiceilene You're welcome! Happy to help.

@hamirmahal - Many thanks for raising this PR. That's a good catch and a great fix. 👍
I'm going to make a slight modification just to make it clear that the procedure refers to enabling/disabling Dependabot security updates on a single repository, and also to match the instructions we give in the related "Managing security and analysis settings for your repository" topic.
Thanks again for helping to keep GitHub documentation up to date. Your assistance is very much appreciated!

@hamirmahal - Many thanks for raising this PR. That's a good catch and a great fix. 👍
I'm going to make a slight modification just to make it clear that the procedure refers to enabling/disabling Dependabot security updates on a single repository, and also to match the instructions we give in the related "Managing security and analysis settings for your repository" topic.
Thanks again for helping to keep GitHub documentation up to date. Your assistance is very much appreciated!

See my changes to this PR in this commit: https://github.com/github/docs/pull/2662/commits/5a0a1b153bc601368837350051cfb9d645f61a00
Staged deployment of the updated page is here: https://docs-2662--fixdependabot-updat.herokuapp.com/en/free-pro-team@latest/github/managing-security-vulnerabilities/configuring-dependabot-security-updates#managing-dependabot-security-updates-for-your-repositories

See my changes to this PR in this commit: https://github.com/github/docs/pull/2662/commits/5a0a1b153bc601368837350051cfb9d645f61a00
Staged deployment of the updated page is here: https://docs-2662--fixdependabot-updat.herokuapp.com/en/free-pro-team@latest/github/managing-security-vulnerabilities/configuring-dependabot-security-updates#managing-dependabot-security-updates-for-your-repositories

@hubwriter You're welcome! Happy to help.
I think there's a typo at the very end of line 56 in content/github/managing-security-vulnerabilities/configuring-dependabot-security-updates.md.
I think fixing the typo is my only suggested change. I gave a couple of alternatives.
Thanks for the direct preview link! That saves me a bit of time so I don't have to find the page again, since I didn't bookmark the preview link.

@hubwriter You're welcome! Happy to help.
I think there's a typo at the very end of line 56 in content/github/managing-security-vulnerabilities/configuring-dependabot-security-updates.md.
I think fixing the typo is my only suggested change. I gave a couple of alternatives.
Thanks for the direct preview link! That saves me a bit of time so I don't have to find the page again, since I didn't bookmark the preview link.

@hubwriter You're welcome! Thanks for merging.

@hubwriter You're welcome! Thanks for merging.


New package: Reddit v0.1.0

Registering package: Reddit
Repository: https://github.com/kennethberry/Reddit.jl
Created by: @kennethberry
Version: v0.1.0
Commit: 44ff5d6a0044bfe4e372f787445c2c0cb2d063f0
Git reference: master

Needs a [compat] section in Project.toml with at least an entry for julia itself, e.g.:
[compat]
julia = "1"

would mean that the package is compatible with Julia versions [1.0.0, 2.0.0).

I've added a [compat] section to the Project.toml.  Do I just need to comment with @JuliaRegistrator register in my latest commit?

Yes, that will update this PR with the new commit.

I have commented on a commit with @JuliaRegistrator register but it doesn't seem to be triggering the Registrator.  I initially triggered this PR via the web interface.  Is there something else besides commenting on a commit that needs to be done to trigger the Registrator to update the PR?


Update README.md

fix: https://github.com/react-native-community/react-native-cameraroll/issues/44

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


enable checkpointing for gpt model def'n

Initial benchmarking shows that gradient checkpointing doesn't bring noticeable differences when flash-attention is enabled. This makes sense as flash-attention does activation recomputation.

How do you mean? Generally checkpoints will trade slower speed for much less memory usage, no?

I am interested in checkpointing support to reduce VRAM requirements. But I don't quite understand how this PR works. Is there something using checkpointing kwarg already?

This change was not enough for me to use with HF trainer:

AttributeError: 'GPTLMHeadModel' object has no attribute 'gradient_checkpointing_enable'

This change was not enough for me to use with HF trainer:

AttributeError: 'GPTLMHeadModel' object has no attribute 'gradient_checkpointing_enable'

This is because trainer calls model.gradient_checkpointing_enable, but gradient_checkpointing_enable is function of Tri's model definition.
To answer your question above as to why I don't expect setting checkpointing = True further saves memory when flash-attention is turned on: This is because Tri is checkpointing the attention portion, but FlashAttention already avoids storing activations in the attention block and performs backwards recomputation (this is documented in the original paper).


Running locally tests fails due to missing libnftables headers

While running ./automation/run-tests.sh, the following error appears:
github.com/networkplumbing/go-nft/nft/schema
github.com/networkplumbing/go-nft/nft/config
github.com/networkplumbing/go-nft/nft/exec
github.com/networkplumbing/go-nft/nft
github.com/networkplumbing/go-nft/nft/lib
# github.com/networkplumbing/go-nft/nft/lib
nft/lib/lib.go:25:11: fatal error: nftables/libnftables.h: No such file or directory
 // #include <nftables/libnftables.h>
           ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
github.com/networkplumbing/go-nft/tests/testlib
github.com/networkplumbing/go-nft/tests/example

FYI @qinqon

what is FYI?

what is FYI?

https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&cad=rja&uact=8&ved=2ahUKEwitqML4mZf9AhUCHOwKHVGtCt8QFnoECBIQAQ&url=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FFYI&usg=AOvVaw33_4bQBtmYMSZ0uILBnkjW


fix uvbeam.interp issue.

closes #16
closes #17

Thanks for the review @philbull. This should be ready for another look whenever you have a chance.


Update fast_dict.pxd

Fix for issue #7

Changed to sklearn 0.20 proposed implementation instead of adding the line import numpy as np. It simply removes the DTYPE variables. We need to check how that impacts the rest of the code since this new piece is tested against 0.20 and not 0.18.


Consider improving menu structure for the API docs

The current API ref menu structure is not ideal. Apiary forces us to use artificial categories like "Run collection", which is super confusing. It's hard to find endpoints in the menu.
In an ideal world, we'd have a simple structure with categories corresponding to areas of product, and then list of endpoints under each category. BTW this is how Stripe has it https://stripe.com/docs/api/
See this conversation: https://apifier.slack.com/archives/CQ96RHG2U/p1580899496004200

I'd first consider migrating our API docs to Swagger as:

It will be much easier to maintain (allows to split it to multiple files and have object schemas in separate files)
We will be able to use if pragmatically in tests as it's either YAML or JSON instead of a markdown

And then consider using some open source docs generator as we will be able to modify the theme:

https://github.com/sourcey/spectacle
https://github.com/slatedocs/slate
(both inspired by Stripe)

Good point. Using some of these tools could let us integrate them better into our docs structure...

Moved to Product Board: https://apify.productboard.com/feature-board/423133-all-development-features/features/11215370/detail


Support other languages than english

I would like to have the option to define a language for the Poll.
So that the text that is shown to the user can be some other language than english.
i.e.
'Vote by adding reactions to the poll. You have 1 vote, but can change it. '
--> German:
'Stimme ab, indem du eine Reaktion hinzufügst. Du hast 1 Stimme, kannst dieser aber nachträglich ändern.'
Is it possible to implement something like that?

This is currently not planned and it would require a lot of work to implement.
I will accept a pull request that implements multi language support in a sensible way (and I will help developing it), but I don't plan on doing it myself from scratch in the near future.

I was also just wondering if you could support multiple languages.
Could you please use an external tool such as Crowdin to support multiple languages? This way, the translation work can be done by other users.


ci: Move pre-commit to each sub-repo

Thanks for submitting a PR! Please check the boxes below:

[X] I have run pre-commit to check linting
[X] I have filled in the "Changes" section below?
[X] I have filled in the "How did you test this code" section below?

Changes
Use pure Githooks in root folder of the mono repo to run the hooks in api and frontend repos correspondingly.
How did you test this code?
Manually:
Run:
git config core.hooksPath hooks
Then make changes and commit to see both pre-commit tools running in api and frontend folders.

Does this changes the docs in terms of how to set up pre-commit in the project?
@dabeeeenster Sorry, I forgot to add the docs folder. Now I added the checks for the docs folder to the pre-commit script, running what I saw there in its package.json, is it ok?

npm run prettier:fix

I see the following:
Starting pre-commit in 'api' folder:
isort (python).......................................(no files to check)Skipped
black................................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
prettier.................................................................Passed
Starting pre-commit in 'frontend' folder:
.husky/pre-commit: line 2: .husky/_/husky.sh: No such file or directory
→ No staged files match any configured task.

Overall, this feels a bit hacky. It feels like there must be a better solution here, but I think I would prefer (over this), simply having to install the relevant pre-commit in each directory. This feels like it would become stale fast.
Perhaps a global makefile could run each of the relevant pre-commit packages? Relevant PR?

I think we should close this in favour of https://github.com/Flagsmith/flagsmith/pull/2397 thoughts?

@dabeeeenster @matthewelwell, @kyle-ssg I think that there are a couple of differences:

Here I added a Typescript check, I guess that could also easily added in pre-commit.
Using this approach we don't need to copy or move the checks tooling configuration files to the root folder, which I think is cleaner. Some of those config files include .eslintrsjs,  eslintignore, .prettierrc, tsconfig.json.
I guess, but I am not sure, that soon or later we will need or want another check to run in the context of the frontend folder, like E2E tests, or other checks.
Even If we want to use the pre-commit instead of Husky, I would suggest using this approach so we can run the tools in the context of each app folder so we don't need to have the configuration files at the root level.

Closed in favour of a simpler life


[Operator] various fixes for Kubeflow Operator

This PR addresses a list of issues related to the Kubeflow Operator

First reported under #393, the operator will redeploy Kubeflow when the cluster's master gets restarted. This has been reproduced and the root cause of the issue is garbage collection related. Kubeflow Operator set the ownerReferences for the resources it created and depended on the garbage collection to delete those resources when the kfdef instance was deleted. Since the garbage collection problem won't be fixed through Kubernetes project for a while, we take the similar approach the other projects have been doing to use the annotations instead.

As part of the Kubeflow deployment, many new CRDs are created. These are not known to the current controller of the operator. One example is the Application kind resources, they were not actually watched by the controller and so when they were deleted, operator did not get notified. To fix such issue, this PR adds a new controller to watch on these GVKs once the first kfdef instance creates successfully.

Reduce the number of reconcile requests when create and delete the kfdef instance. Two events happen during kfdef CR is applied. First, it is a CREATE event. And when the Reconile() function kicks in, the finalizer is added to the CR, an UPDATE event happens. This results in one more Reconcile() call after the Kubeflow is successfully deployed. Two events happen also when the kfdef CR is deleted. First is an UPDATE event. This happens because the kfdef resource has a finalizer so the delete action leads to adding the deletion timestamp to the CR and so the kfdef CR is updated. Then when the finalizer is finally removed, a DELETE event happens. This results in one more Reconcile() call after the kfdef CR is actually deleted. This PR instead adds the finalizer in the watch handler func when the kfdef instance is created. Only the UPDATE event will queue a request. When the kfdef CR is deleted and the deletion timestamp is added, this is the UPDATE event for the reconcile func to handle. When it finally is deleted when the finalizer is removed, no request is needed to queue for the reconcile func.

For resources created during Kubeflow deployment, verify their annotations containing the kfdef instance's name and namespace then queue the request for reconciling.

Now that the operator is no longer depending on the garbage collection to delete the resources, this PR adds KfDelete() function to handle the deletion. It is done as part of the kfdef instance's finalizer.

Change GenerateYamlWithOwnerReferences function to GenerateYamlWithOperatorAnnotation function so that the Kubeflow resources will be added the annotations indicating they are deployed through the Kubeflow operator. A couple of special cases are excluded from appending the annotations. First, for Namespace kind resource, it tries to verify if the namespace exists. If a namespace already exists, the annotations will not be added. This will avoid the accidental deletion of a namespace that is not created by the operator. This strategy works when the operator and the Kubeflow coexist in the same cluster. If in the future the remote deployment through operator is supported, this needs revisit. Second, for Profiles kind resource, it will not add the annotations. Part of the reasons this PR does so is currently the profiles CRD is the owner of user profiles (ie. namespace). When the profiles crd is deleted, the user namespaces and data will be cascade deleted. Therefore this PR assumes that users will incline to keeping user namespaces and data when the Kubeflow is uninstalled, it then will not remove the profiles crd when the kfdef instance is deleted.

Pass byOperator indicator to utils.DeleteResource function to indicate that if the function is called by the operator, it will only delete the resources with the annotations appended during Kubeflow deployment.

Avoid processing the applications with same name in kfdef multiple times. This is also applied to CLI install. The fact is that with the kustomize v3, kfdef configuration is allowed to have the same application name (eg. kubeflow-apps) pointing to different manifest path. This is however useful for use cases where a v3 full stack needs to break into sub-components. The tool appends all the manifests into one single kustomization.yaml file under kustomize/kubeflow-apps directory. And we are taking the advantage of this. But at runtime, when the apply() function loops through the kfdef configuration, it iterates by application name and results in applying the resources multiple times. This PR skips the apply if the application is already applied.

@adrian555 i'm testing the new operator. Creating and watching the new resources works great. However, when i try to delete the kfdef, it panic due to a nil channel. To recreate this, run:

Deploy kfdef on Kubernetes 1.16
Delete a custom resource such as kubectl delete VirtualService ml-pipeline-ui -n kubeflow
After it redeployed, delete kfdef kubectl delete kfdef --all -n kubeflow
you will see the errors below

time="2020-09-23T00:44:51Z" level=info msg="Go Version: go1.14.3"
time="2020-09-23T00:44:51Z" level=info msg="Go OS/Arch: linux/amd64"
time="2020-09-23T00:44:51Z" level=info msg="Version of operator-sdk: v0.13.0"
time="2020-09-23T00:44:51Z" level=info msg="Kubeflow version: 1.1.0"
time="2020-09-23T00:44:55Z" level=info msg="Registering Components."
time="2020-09-23T00:44:55Z" level=info msg="Adding controller for kfdef."
time="2020-09-23T00:44:58Z" level=error msg="Cannot create watch for resources Deployment extensions/v1beta1: no matches for kind \"Deployment\" in version \"extensions/v1beta1\"."
time="2020-09-23T00:44:58Z" level=info msg="Controller added to watch on Kubeflow resources with known GVK."
time="2020-09-23T00:45:04Z" level=error msg="Could not create ServiceMonitor object. Error: no ServiceMonitor registered with the API."
time="2020-09-23T00:45:04Z" level=error msg="Install prometheus-operator in your cluster to create ServiceMonitor objects. Error: no ServiceMonitor registered with the API."
time="2020-09-23T00:45:04Z" level=info msg="Starting the Cmd."
time="2020-09-23T00:45:04Z" level=info msg="Got create event for ibmstack.kubeflow."
time="2020-09-23T00:45:04Z" level=info msg="Watch a change for KfDef CR: ibmstack.kubeflow."
time="2020-09-23T00:45:04Z" level=info msg="Reconciling KfDef resources. Request.Namespace: kubeflow, Request.Name: ibmstack."
time="2020-09-23T00:45:04Z" level=info msg="Deleting kfdef."
E0923 00:45:04.959894       1 runtime.go:73] Observed a panic: "close of nil channel" (close of nil channel)
goroutine 1501 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic(0x1c35e20, 0x22c7170)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/runtime/runtime.go:69 +0x7b
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/runtime/runtime.go:51 +0x82
panic(0x1c35e20, 0x22c7170)
	/usr/local/Cellar/go/1.14.3/libexec/src/runtime/panic.go:969 +0x166
github.com/kubeflow/kfctl/v3/pkg/controller/kfdef.(*ReconcileKfDef).Reconcile(0xc000c80580, 0xc0010bd948, 0x8, 0xc0010bd940, 0x8, 0x0, 0x303a37030, 0xc0004d4000, 0xc00002a518)
	/Users/tommyli/go/src/github.com/kubeflow/kfctl/pkg/controller/kfdef/kfdef_controller.go:258 +0xcb5
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc00042e460, 0x1ccf160, 0xc00024c2e0, 0x0)
	/Users/tommyli/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.0/pkg/internal/controller/controller.go:216 +0x161
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc00042e460, 0xc000a66100)
	/Users/tommyli/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.0/pkg/internal/controller/controller.go:192 +0xae
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker(0xc00042e460)
	/Users/tommyli/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.0/pkg/internal/controller/controller.go:171 +0x2b
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc0031ac0f0)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/wait/wait.go:152 +0x5f
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc0031ac0f0, 0x3b9aca00, 0x0, 0xc000779d01, 0xc00026dc20)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/wait/wait.go:153 +0xf8
k8s.io/apimachinery/pkg/util/wait.Until(0xc0031ac0f0, 0x3b9aca00, 0xc00026dc20)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/wait/wait.go:88 +0x4d
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
	/Users/tommyli/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.0/pkg/internal/controller/controller.go:157 +0x2fd
panic: close of nil channel [recovered]
	panic: close of nil channel

goroutine 1501 [running]:
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/runtime/runtime.go:58 +0x105
panic(0x1c35e20, 0x22c7170)
	/usr/local/Cellar/go/1.14.3/libexec/src/runtime/panic.go:969 +0x166
github.com/kubeflow/kfctl/v3/pkg/controller/kfdef.(*ReconcileKfDef).Reconcile(0xc000c80580, 0xc0010bd948, 0x8, 0xc0010bd940, 0x8, 0x0, 0x303a37030, 0xc0004d4000, 0xc00002a518)
	/Users/tommyli/go/src/github.com/kubeflow/kfctl/pkg/controller/kfdef/kfdef_controller.go:258 +0xcb5
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc00042e460, 0x1ccf160, 0xc00024c2e0, 0x0)
	/Users/tommyli/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.0/pkg/internal/controller/controller.go:216 +0x161
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc00042e460, 0xc000a66100)
	/Users/tommyli/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.0/pkg/internal/controller/controller.go:192 +0xae
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker(0xc00042e460)
	/Users/tommyli/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.0/pkg/internal/controller/controller.go:171 +0x2b
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc0031ac0f0)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/wait/wait.go:152 +0x5f
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc0031ac0f0, 0x3b9aca00, 0x0, 0xc000779d01, 0xc00026dc20)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/wait/wait.go:153 +0xf8
k8s.io/apimachinery/pkg/util/wait.Until(0xc0031ac0f0, 0x3b9aca00, 0xc00026dc20)
	/Users/tommyli/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190612205821-1799e75a0719/pkg/util/wait/wait.go:88 +0x4d
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
	/Users/tommyli/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.0/pkg/internal/controller/controller.go:157 +0x2fd

@Tomcli this doesn't seem to happen to me. I just ran this again but did not see the error. Were you deploying multiple times with the same operator? Maybe more details on the operations you have done will help understand the root cause. Thanks.

@Tomcli this doesn't seem to happen to me. I just ran this again but did not see the error. Were you deploying multiple times with the same operator? Maybe more details on the operations you have done will help understand the root cause. Thanks.

The extra thing i did here is I also deleted a crd to check the watcher.

/lgtm
@adrian555 we should open an issue or leave a note for the users to know that kfctl delete takes longer time to delete than k8s garbage collector.

/lgtm
/approve


Won't recognize keybindings if one fails to register

Version (which release did you use?)
Develop branch 7fbe44c
Describe the bug
If a keybinding fails to register, Nog will continue running but won't recognize any keybindings.
(added a dbg! to line 121)
[src\keybindings.rs:121] &kb = Keybinding(ALT+CONTROL+J, Swap, 3074, None)
thread '<unnamed>' panicked at 'Failed to register keybinding: Null', src\system\win\api.rs:183:10
stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/8256379832b5ecb7f71e8c5e2018446482223c12\/library\std\src\panicking.rs:493
   1: core::panicking::panic_fmt
             at /rustc/8256379832b5ecb7f71e8c5e2018446482223c12\/library\core\src\panicking.rs:92
   2: core::option::expect_none_failed
             at /rustc/8256379832b5ecb7f71e8c5e2018446482223c12\/library\core\src\option.rs:1268
   3: core::result::Result<i32, nog::system::win::WinError>::expect<i32,nog::system::win::WinError>
             at C:\Users\melus\.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\result.rs:933
   4: nog::system::win::api::register_keybinding
             at .\src\system\win\api.rs:177
   5: nog::keybindings::{{impl}}::start::{{closure}}
             at .\src\keybindings.rs:123

In this case, I already had CTRL-ALT-J registered to JetBrains Toolbox. Removing that keybinding fixed the issue.
To Reproduce
Register a keybinding with another application. Then try to run Nog with the same keybinding in config.nog.
Expected behavior
Nog continues to run OK without the bad keybinding. Or Nog exits and tells the user there was an error.
Actual behavior
Nog is still running but will not recognize any keybindings.

This sounds just like what @mdkozlowski is encountering in #190. It's even the same key binding. I am curious what happens if nog is launched first.
I think ideally if this happens nog should continue running but throw a popup indicating what keybinding(s?) weren't able to be registered.

FYI -- if I run nog first, nog's keybinding takes precedence and everything works OK.

@meluskyc
I added some code to trigger a popup showing what keybinding failed to register. It looks like this:

You should be able to use all other keybindings that aren't conflicting with other applications when this occurs. Check out the latest development release and let me know if that works for you.

Fixed now. Thanks!


SAK-40466: SiteStats doesn't track read events from Announcements

https://jira.sakaiproject.org/browse/SAK-40466
The "annc.read" event is missing from the event definition file in SiteStats, even though there is localization support for the event in the message bundles.

Good find, it looks like Neal noted this a few years ago but nobody noticed https://jira.sakaiproject.org/browse/SAK-23566


Build: SlimerJS dependency not installing on Ubuntu 14.04

See https://github.com/graingert/slimerjs/issues/36 .
Logged this issue here for reference because ol3 wasn't building for me on Ubuntu 14.04.

It looks like you're not with the latest changes. See https://github.com/openlayers/ol3/issues/5005.

Fixed with #5006


Consistent notation and terminology across files

I think files should use consistent notation and terminology across files to denote goods, firms and factors.
In aggregates.py,  j refers to both industries and goods in different equations. But i is also used to denote both goods and commodities.
In firms.py, h denotes factors of production j denotes goods and i denotes both commodities and intermediate inputs.
The Hashimoto book uses i to index goods, j to index firms and h to index factors.
Is this the format we want to follow? I think it seems reasonable.
What notation do we want for industries? Currently we use j to refer to both firms and industries?
I can work on cleaning and standardizing the notation if that would be helpful.
@jdebacker

@duncanhobbs  Making this notation consistent would be very helpful.
j can be used for industry, which I think is the same as firm here - there being only one firm per industry.
Following the notation in Hashimoto is a good idea.

Hi,
We just need to decide the notation for factors, firms and commodities.
Generally, firms/industries refer to the same set,
commodities/goods/intermediate inputs also refer to the same set.
But, following Hashimoto makes a lot of sense.
Thanks,
Dinar
On Fri, Jul 26, 2019 at 3:29 PM Jason DeBacker<EMAIL_ADDRESS>wrote:

@duncanhobbs https://github.com/duncanhobbs Making this notation
consistent would be very helpful.
j can be used for industry, which I think is the same as firm here -
there being only one firm per industry.
Following the notation in Hashimoto is a good idea.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PSLmodels/CGE/issues/39?email_source=notifications&email_token=AJGNBOT4NQMHTEKCPXTJYUDQBNGALA5CNFSM4IHGHBK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25QE3Y#issuecomment-515572335,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJGNBORJ3RJVDNLG662XIZDQBNGALANCNFSM4IHGHBKQ
.


How can I add our CA cert to connect to keycloak over tls on default port 8443?

Hi,
Our Keycloak server is using tls (ssl). I guess we must add our CA's public cert for the connection to it to be considered valid by the client handling the session to keycloak inside the streamlit keycloak module.
Is there a way to do that with the keycloak module?
Thanks!
Best,
/Mats

I realised the authentication is taking place on the client side, so as long as the client has the root cert set as valid, it is all good.
The base domain for keycloak and the streamlit web pages must be the same so the "origin" is the same for security reasons.
I am closing this out.


block_order table + integration

This PR introduces a block_order table, to add an explicit block order to the system.
It piggybacks on Bigchain.write_block in order to write to the block_order table whenever a block is written into the bigchain table.
The primary key used is the simple numeric block height, and the block id and previous block id are included in the payload. This has the properties:

Multiple writes with the same block height will fail
The chain can be validated because each item points to the previous item.

Todo:

Entries should be signed and identified
Queries for RethinkDB

Codecov Report

Merging #1372 into master will decrease coverage by 5.98%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   98.21%   92.23%   -5.99%
==========================================
  Files          54       54
  Lines        2468     2473       +5
==========================================
- Hits         2424     2281     -143
- Misses         44      192     +148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5217b...4ba9ee5. Read the comment docs.

Putting this on hold - there's a better solution: Counters table where nodes contend to CAS a single record containing block height, BEFORE writing their block.

Blocks point to previous blocks
Mechanism is easy to replace
Single node is always block order leader and that can be changed easily by changing the ID of the block height counter record


Dracula for rime

rime is an input method.
I create Dracula theme for it
https://github.com/shlroland/rime

Hey, very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉


macOS support for running individual generators

The workarounds in setup.py to install ruamel.yaml and marko don't work when starting from a clean build, e.g.:
make clean
git clean -dfx
make preinstallation
make install_test
make pyspec
make -j gen_fork_choice

This results in error:
generator fork_choice started
Processing /consensus-specs
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [30 lines of output]
      /consensus-specs/tests/generators/fork_choice/venv/bin/python3.11: No module named pip
      Traceback (most recent call last):
        File "<string>", line 45, in <module>
      ModuleNotFoundError: No module named 'ruamel'

Adding --no-use-pep517 disables some environment isolation for pip, and makes this work once more on macOS. --no-use-pep517 requires prior installation of setuptools and wheel.
% sw_vers
ProductName:      macOS
ProductVersion:   14.2.1
BuildVersion:     23C71

Still same issue.
% sw_vers
ProductName:		macOS
ProductVersion:		14.4.1
BuildVersion:		23E224

Still same issue.
% sw_vers
ProductName:		macOS
ProductVersion:		14.6.1
BuildVersion:		23G93

% python3 --version
Python 3.12.4

This seems to have been adressed as of #3927
Thanks @jtraglia 🚀


update links verify job

Status
Ready
Related Issues
fixes: link to the issue
Description
The links verify job stopped running because of old golang usage. Bringing it back to life...
Screenshots
Paste here any images that will help the reviewer

Still relevant.

Still relevant


why not provide some static method ,so people could  not noly use it for input element

some times wo want something be formatted on other element ,like 'div ','span',or 'table'

Yes we had a discussion about this before launching, and decided not to do it.
We want to create a lib only focusing on the user input behaviour, so that's not in the plan.
Thanks for proposing tho, will close this.


Q: go interoperability

hey,
Very cool project! Is it fully interoperable with golang packages?
cheers,
Wojtek

I don't aim it for now. This is a totally new programming language and not assumed to be used with Go. GoCaml has an interoperability with C for using many C libraries. So it may be possible to use Go's functions through C.
GoCaml is implemented in Go, but it's not an interpreter, but a compiler from source to LLVM IR. So it's not easy to introduce Go interoperability. It's like introducing Go interoperability to C compiler.


Gitignore for Zshell

New

[x] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Details
The docs about the entries:

zsh.sf.net/Files – search for "zwc"
zsh.sf.net/use of compinit – search for "zcompdump". The file can have a hostname appended and also the user may customize it (a bit, presumably) hence the wildcards in the template
zplugin – search for "._zplugin". The files will appear when developing a Zsh plugin with use of Zplugin, hence their presence in the template.
zshelldoc – search for data. When developing a Zsh-plugin and documenting the code with Zshelldoc, this directory will pop-up in git status without any need for commit,
per-directory-history – search for ".directory_history". The plugin can be configured to store the history in the local directory instead of $HOME,
zsh-autoswitch-virtualenv – search for ".venv".
zunit – the tests can produce results in the _output directory.

Thanks!


Notify user that something has happened when pressing on Copy to Clipboard

Notify user that something has happened if they press on Copy to Clipboard

Just pushed an implementation of this, please check if you are happy with the information provided.

great, closing!


Certificate issue with Harbor and docker daemon

The standard way to create certificates for static IP and FQDN for Harbor works fine, but it does not work with standard docker daemon.

Creating certificate for static IP works fine for Harbor if you're browsing it.  However, standard docker daemon cannot connect to it.

Error response from daemon: Get https://<IP_ADDRESS>/v1/users/: x509: certificate signed by unknown authority

Creating a certificate for FQDN works fine for Harbor, but standard docker daemon cannot connect to it unless you also include subjectAltName.  This is not common.  Most instructions including those on docker's website or the Harbor instruction website say to create certificate for FQDN OR static IP.

I have a feeling the problem is the script updating the nginx conf file.

This is going to be a problem if users are using a load balancer.

@sflxn if you want to use docker to access Harbor using IP, then the IP has to be in IPSAN of the cert of Harbor.
if you are using FQDN to access Harbor, putting the FQDN in CN of the cert should work.

For 1, this is the expected behaviour. If your certificate is signed by unknown authority, you should either put the certificate of CA under directory /etc/docker/certs.d/IP_or_FQDN/ or add --insecure-registry to docker daemon.
For 2, if you use Harbor under version 0.4.5(included), no matter IP or FQDN is used to create certificate, you should include IP as the subjectAltName. In next release, subjectAltName is not needed anymore if use FQDN.

@sflxn, there are several issues involved.
When you setup Harbor with HTTPS and tries to use docker to access it, you may see 2 kinds of errors.

If you use a self-signed cert, docker may complain the cert is signed by unknown authority, this can be fixed by putting the CA cert into /etc/xxxx directory as described in previous comment.

docker may complain mismatch of IP or FQDN between the one you used and what is set in the cert.  Now, regarding setting the cert, for FQDN it should be in the CN of the cert for IP, it should be in the IPSAN of the cert.  However, now if you install via .ova, our installation script will always try to setup Harbor using IP, so when you use FQDN to access Harbor, even when the Harbor is using a cert with FQDN in the CN you may still see error, this issue is tracked by #995 and will be fixed within next couple of days.

Hope this helps, any further issues please add commet.

Yes, I am aware that we must add the CA cert in /etc/docker/certs.d/IPorFQDN.  This only works if the server certificate has both FQDN and subjectAltName.  If the certificate was created with static IP instead of FQDN, it does not work.  If we're creating a certificate, we should not have to use --insecure-registry.  That defeats the exercise of generating a certificate.

@sflxn I believe static IP works, as long as the CA cert is put into  /etc/docker/certs.d/IP.
As for this particular error in OP:
Error response from daemon: Get https://<IP_ADDRESS>/v1/users/: x509: certificate signed by unknown authority

I believe it's due to the CA cert is not placed correctly.

@reasonerjt Have you tested static IP in /etc/docker/certs.d/IP?  I spent over a day trying it.  If I can't get it to work, I suspect customers will also have trouble.  If you guys get around to verifying it works, please let me know and provide the instructions.  Is this part of your tests?

@reasonerjt I figured out why static ip is not working.  You guys have another bug.  When creating the certificates, common name must be set to the static ip address.  Your instructions do not say to do this.  Like nearly ALL certificate generation instructions, your's say to either put in FQDN or your name.  I believe there is an error in your startup script.
One other thing, nearly every VMware dev outside of the Harbor team is having problems with the instructions your docs provide.  You guys really need to test your docs.  All of the issues I found were bugs.  Since Harbor is going out with VIC Engine as one product, we must make sure that customers do not have any issues if following the instructions.  If internal VMware engineers are having difficulty, it's guaranteed our customers will have it worst.

@sflxn  sorry for the extra effort.
However, like I saind

When creating the certificates, common name must be set to the static ip address.

This is incorrect.
I just verified by creating a certificate, server.crt. If I type this command:
openssl x509 -in ./server.crt -noout -text

I can see this in the output:
 Subject: C=AU, ST=Some-State, O=Internet Widgits Pty Ltd, CN=**not-staticIP**

So you see the static IP is not in the common name, what matters is the following chunk:
X509v3 extensions:
            X509v3 Subject Alternative Name:
                IP Address:<IP_ADDRESS>

And I can successfully docker login to <IP_ADDRESS> via docker login, using https.  And there's instructions in our doc to put IP in the x509v3 SAN:

If you're using IP, say <IP_ADDRESS> to connect your registry host, you may instead run the command below:

echo subjectAltName = IP:<IP_ADDRESS> > extfile.cnf
openssl ca -in yourdomain.com.csr -out yourdomain.com.crt -cert ca.crt -keyfile ca.key -extfile extfile.cnf -outdir .

The process to use openssl to generate cert for registry is tricky, but we have tested to follow the instructions in the doc to create cert and verify things work.  And by the way, I'm peronally a little reluctant to show this doc to customer as IMO the steps to generate a self-signed cert falls out of the scope of this project, customer may generate a cert not following the steps in our doc.
I agree the doc needs improvement, we're going through the doc to make sure things work, and the widgets of .ova has some limitations, which make the importing process a bit confusing.  If you see any problems please don't hesitate to communicate with us or open issues here, we'll follow up and fix it.

closing the issue as we've verified the https doc, and for .ova deployment Harbor will generate a self-signed cert by default.
@sflxn please reopen it if you think there's further issues need to be fixed.


zkcast run failed while inspecting: Transaction(GasMaxFeeGreaterThanPriorityFee)

Component
Cast
Have you ensured that all of these are up to date?

[ ] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.2.0 (2a5ab4c 2023-09-15T02:28:45.574479000Z)
What command(s) is the bug in?
zkcast run
Operating System
None
Describe the bug

../foundry-zksync/target/debug/zkcast run --rpc-url=https://testnet.era.zksync.dev -v 0x57e5d44e487922d2167ea67e7dc4d0bbf86ca90d7f1dfbdc03ccb801bac22674
Executing previous transactions from the block.
Error:
Failed to execute transaction: 0xbbf0ced523ca006d655177765fc6cea309d5985c42dbe40d43894a7ec12235ca

Context:
- backend: failed while inspecting: Transaction(GasMaxFeeGreaterThanPriorityFee)

forge 0.2.0 (2a5ab4c 2023-09-15T02:28:45.574479000Z)
cast 0.2.0 (2a5ab4c 2023-09-15T02:28:45.574479000Z)

I tried running this again but I got tx not found: 0x57e5d44e487922d2167ea67e7dc4d0bbf86ca90d7f1dfbdc03ccb801bac22674.
I tried looking for the tx hashes you mentioned in the issue but in both cases no tx has been found.
Do you have more information or another test case for us to verify? Thank you

Hey @AaronNan24 if you have more information please feel free to reopen the issue, but for now I'll be closing it as stale. Thanks!


use cached discovery data when request discovery error at login

Coverage decreased (-1.0%) to 89.474% when pulling bab5d95bbae5677a561bce6c77feaed6a6994c20 on embbnux:enhance/discoveryLogin into ed5a31004e623cfda189eced0de5fb025cb9263d on ringcentral:master.


Add opaque option to olx.source.OSMOptions

Fixes #4767

Looks good. Please merge.

Thanks for the review


unable to set HTTP status in AoG intent handler

hi,
I am trying to sent HTTP header 401 from AoG intent handler. Basically I have implemened OAuth account linking and in particular situation want to revoke the access and force the action to go to authorization endpoint again. I have registered middleware in order to get the access to Express framework response object:
this.app.middleware((conv: any, framework: any) => {
  return new Promise(resolve => {
    if (framework.express) {
      conv.expressResObject = framework.express.response
    }
    resolve()
  })
})

and then trying to call within AoG action handler this code:
    return new Promise((resolve, reject) => {
        const _conv  =  this.conv as any
        const expressRes = _conv.expressResObject
        expressRes.status(401).json({ error: 'user_not_found' })
        resolve()
    })

I am getting:
2019-02-11T20:21:55.292Z [server.ts] error: Unahndled promise rejection detected!
2019-02-11T20:21:55.293Z [server.ts] error: Unhandled Rejection at: Promise
2019-02-11T20:21:55.293Z [server.ts] error: Error: Can't set headers after they are sent.
at standard.then.catch (...\node_modules\actions-on-google\dist\framework\express.js:38:38)
Any idea how to sent custom HTTP status from action handler?

Hi, now the library supports a clear way to set the HTTP 401 Status code. See #187 for more details.

Now with 2.6.0 in 7fb220d, we added support for returning a HTTP 401 status code by throwing a customized error:
const { dialogflow, UnauthorizedError } = require('actions-on-google')

const app = dialogflow()

// If using Actions SDK:
// const app = actionssdk()

app.intent('intent', conv => {
  // ...

  // given a function to check if a user auth is still valid
  const valid = checkUserAuthValid(conv)
  if (!valid) {
    throw new UnauthorizedError()
  }

  // ...
})

This should allow you to respond with this and invalidate the token.
Let us know if you have any issues.


4OD - https://www.channel4.com/

Hello,
If you add this to the host file:
cdn.http.anno.channel4.com
The adverts at the start and in the middle of videos just get skipped :)
You can test with this:
https://www.channel4.com/programmes/ramsays-kitchen-nightmares/on-demand/38532-001
I have just setup Pi-Hole, I thought I would try block the videos loading on 4OD and was amazed how easy it is!
Thanks,
David

Hi @thebeanieman  – thanks for this input.
We're mostly an aggregator of hosts files from active and reputable curators of hosts files, and we package these amalgamated hosts files in various ways.
Please submit this request to one of our curated sources.
Closing.


Does not work with webpack 4 in dev mode

In production it works, resources are imported. In development do not import any resources.

Sorry


DateType should be able to parse from other types

Zod's DateType is fairly limited, it expects an existing Date object. This is most often not how they are sent over the internet, and therefore I believe that it should be able to parse inputs such as ISO timestamps, etc., which can usually be fed into the Date constructor.
Regarding UNIX epoch timestamps, I also believe that the user should have the choice of setting whether it is milliseconds or seconds, as the JS standard differs from the standards of other apps, which can have seconds as units.
I'd be fine implementing this myself, just would like to hear opinions on this.

This (and other similar stringy issues) have come up before, so I'll try to add some context and help provide some ideas of how we handle this:
Fundamentally, Zod looks to compliment the TypeScript type system and give you runtime checking capabilities. As such, the date schema (like all of the other schemas) is analogous to TypeScript's Date type which represents the JavaScript Date object. None of the schemas have any hidden or implicit conversions/coercions going on, and I would personally be -1 on making date the first to have that behavior.
We've, so far, avoided making Zod (the core library) opinionated about the system in which in runs (browser, node, deno, others?) and the problem domain it is solving for (form validation, CSV conversion, database model parsing, HTTP requests, etc.) and as such, it's common to feel like Zod isn't giving you the tools you need to approach the IO boundary that you're trying to work through. For now, as the ecosystem is still growing to cover each of those cases, you'll find that you will end up writing a few helper schemas to cover your specific use cases. I think that's likely to become less and less the case as the ecosystem grows and people start to build the abstraction layer atop Zod that represents all of these disparate platforms and problem domains.

Thanks for bearing with me on that. On to the ideas!
Given that, you can look to how TypeScript handles this situation: with unions. If a value could truly be either a string or a Date, you can represent that as a z.union([z.string(), z.date()]), which corresponds to the type string | Date in TypeScript.
Now, I think what you're getting at is that we often deal with number or string values that represent dates, but we want to be able to pass them through our schemas and reliably get a Date. In that case you have a few options:

refine(isISODate).transform(Date) - Use a refinement function and then explicitly convert to a Date. (See https://github.com/colinhacks/zod/issues/482#issuecomment-906848102 for detailed example of this)
preprocess(customCoercionCode) - If you know which keys ought to be dates, you can use preprocess to convert them before the schema parses it so that you can use z.date directly.

My historical preference has been to prefer refine -> transform, but that is mostly due to preprocess coming out after my team's patterns have mostly been established.

Going to close as a duplicate of a number of other similar issues, but feel free to ping me in this thread or reopen if you have additional questions, ideas, or thoughts on this.

Thanks for the explanation!


pure-js

I've seen links to a "pure-js" implementation but those links have expired. The correct link seems to be this:
https://github.com/uber/deck.gl/tree/master/examples/get-started/pure-js
But I need to get deck.gl going with raw html and javascript. No "npm" stuff, no react, no angular, no frameworks... just plain old html + javascript directly.
The problem with all the current deck.gl examples is that they use react and npm and other stuff that conflict with other frameworks and tools that might be already in use by a project. It would be better to have a bunch of examples that work with vanilla js and html and css so that we can later tweak it to fit within other tools and frameworks.
As it is right now... I have no idea what I'm doing here. I have no idea what js scripts to import into my project, how to wire this into my already existing mapbox maps etc.
Are there such examples running around somewhere? The "pure-js" seems like a decent start but it doesn't run without "npm". And I can't change my entire project setup/structure to use npm just because of deck.gl
Any ideas? Specifically this stuff here looks like it will be a problem:
import {Deck, MapController} from<EMAIL_ADDRESS>import {GeoJsonLayer} from<EMAIL_ADDRESS>import Map from './mapbox';
in the app.js

@localdevjs Sounds like you want to start scripting with deck.gl

Indeed! That looks pretty good, thanks for the link!


Layouts/subnav

GitHub Issue
https://github.com/HausDAO/daohaus-monorepo/issues/408
Changes

see issue

Did not build the 'more' dropdown or the mobile routes dropdown. I did build both the triggers and the switcher for mobile.
Going to wait until after the dropdown component is finalized.
Updated pictures:

Packages Added
NA
Checks
Before making your PR, please check the following:

[x] Critical lint errors are resolved
[x] App runs locally
[x] App builds locally (run the build command for any impacted package and check for any errors before the PR)

We need an issue for updating the two navs here once the dropdown component is finalized.


Cleanup and unit tests for util package

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
7537bc3373b53b997f5d43dead36bea28dbe22f0
link
/test operator-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


LibWeb: Make MessageEvents from {Window,MessagePort}.postMessage trusted

The MessagePort one in particular is required by Cloudflare Turnstile, as the method it takes to run JS in a worker is to eval the contents of MessageEvent.data. However, it will only do this if MessageEvent.isTrusted is true, MessageEvent.origin is the empty string and MessageEvent.source is null.
The Window version is a quick fix whilst in the vicinity, as its MessageEvent should also be trusted.

Should we preemptively skip the test that uses workers, since it's likely gonna timeout on macOS? 😐

yolo


Include ARM build of crictl in releases

Currently, only 386 and amd64 are available, it would be great if releases page also included arm/arm64 builds for linux.
UPDATE:
I just realized that older builds included arm version, only the most recent cri-tools v1.0.0-beta.0 release did not include arm build. Was this intentional?

No, let me build one and upload


Support for anonymous types in Typescript

It would be interesting to be able to support the generation of anonymous types by configuration when there are name conflicts in json-schema. Have something like this:
type Foo = {
  bar: { id: string, name: string };
  baz: number;
}

and not something like
type FluffyBar = {
  id: string;
  name: string;
}

type Foo = {
  bar:  FluffyBar;
  baz: number;
}

What would you imagine the heuristic would be to decide whether to make a class type anonymous or not?  Name conflicts are hard to use for this in quicktype's current architecture.  I could imagine:

A class type that's only used in one place.
Not more than N properties.
None of the properties are anonymous.


Add support for web3 1.0.

A note that<EMAIL_ADDRESS>breaks compatibility with wss connections and you may want to downgrade to beta.33 until it's fixed.

Apparently<EMAIL_ADDRESS>fixes the wss issues :).

@Arachnid Thoughts on a bounty here? Someone made a Gitcoin Request for it 🙂 cc @stevenjPearce

For anyone that arrives here from google and is receiving the following error with ethereum-ens 0.7.4 and<EMAIL_ADDRESS>Unhandled rejection TypeError: this.provider.sendAsync is not a function

The solution provided by @makoto solved it for me

I'm getting an undefined object when instantiating ensjs with<EMAIL_ADDRESS>


Confused

I came here to find practical info about using the OpenFileDialog class, but 98% of the information here is irrelevant (and confusing).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed9db6b2-ee5e-dffb-94ea-3c56ed18e34e
Version Independent ID: 9a19956f-7670-1e75-feb7-8a8b2e71c31e
Content: How to: Open files with the OpenFileDialog component
Content Source: docs/framework/winforms/controls/how-to-open-files-using-the-openfiledialog-component.md
Product: dotnet-framework
Technology: dotnet-winforms
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Hello. Sorry for the delay in responding.
It's hard to understand what is missing without fully understanding your scenario. Can you elaborate on "practical info?"
Does the https://docs.microsoft.com/en-us/dotnet/framework/winforms/controls/openfiledialog-component-overview-windows-forms article help?


Add GitHub Actions workflow

As a first attempt at addressing #39 , this PR adds a somewhat minimal GitHub Actions workflow that:

Runs a basic flake8 lint (warns mostly, only fails on critical issues)
Runs pytest which right now just contains of a test placeholder (to keep the PR small)
Runs the example workflows previously defined in .gitlab-ci.yml

It also adds a badge for the status of the tests, in README.md.
Worth noting:

The workflow uses Python 3.6.15, as 3.6 is specified as the lowest requirement in environment.yml, and since this is a bit of an old version, it requires the slightly older ubuntu-20.04 image. This could perhaps be updated later.
Right now the workflow is run on any push. One could limit this to only run on e.g. PRs towards master or similar.

I'm a little surprised why the CI doesn't show it's status here in the PR, but maybe that is because it is running on my forked repo (here) and not activated in this repo yet...


Drop usage of rmw_dds_common::qos_profile_get_best_available_X

At the same time explore transmitting QoS info only if there is a deviation from the system default. See https://github.com/ros2/rmw_zenoh/pull/210#discussion_r1652776472 for context.

We've now dropped our usage of rmw_dds_common completely, so I'm going to go ahead and close this out.


Add hashing to passwords

As of now, the passwords are directly saved into the db. However, this is insecure
Use the hash() in python to hash the passwords and then save it to the db

Hey can I work on this?

can you explain in which files i'll have to make changes? I can do the rest

Created PR https://github.com/annu12340/CS50-Final-Project/pull/5

Added argon2 secure hashing (Modern approach over Bcrypt)
Authenticates hash while login
Generates hash and store while registering

The issue is solved


Nixos-unstable: Nerd fonts characters are blank in pkgs.nerd-fonts.jetbrains-mono

Describe the bug
pkgs.nerd-fonts.jetbrains-mono is broken the characters added by nerd fonts to the jetbrains mono font do not appear.
Steps To Reproduce
Steps to reproduce the behavior:

add pkgs.nerd-fonts.jetbrains-mono to your environment.
Change font to jetbrains mono nerd font in your terminal or text editor of choice.
Attempt to view a nerd fonts exclusive character

Expected behavior
The nerd fonts characters should be a part of pkgs.nerd-fonts.jetbrains-mono
Screenshots
What my prompt looks like when using nixos unstable

What my prompt looks like when using nixos 24-11

Additional context

Metadata

system: "x86_64-linux"
host os: Linux 6.12.5, NixOS, 25.05 (Warbler), 25.05.20241217.d3c42f1
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.24.11
nixpkgs: /nix/store/6zgbbqlr7nnfxpzkyj7fsl4fpg89jbw0-source

Notify maintainers
@doronbehar
@rc-zb

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Just to add, Gnome Console cannot display any Nerd Font:

VSCode is able to however ("terminal.integrated.fontFamily": "'JetBrainsMonoNL Nerd Font', 'Courier New', monospace",)

Originally two programs that I tried and wouldn't display nerd fonts on the unstable branch were konsole and vscodium. Now konsole has decided that it will load the nerd fonts but vscodium still won't, but it will if I switch back to stable. This whole thing is just so bizarre.

I can confirm that running fc-cache -rf fixes the issue. My broken jetbrains fonts in alacritty, waybar, & anyrun were fixed by running that cmd. Thanks!

https://wiki.nixos.org/wiki/Fonts

add pkgs.nerd-fonts.jetbrains-mono to your environment.

Simply adding font packages to environment.systemPackages isn't enough for them to show up in applications and they should be put in the font.packages option instead in the NixOS configuration.

I'm closing as this is clearly a support request and not an issue with Nixpkgs. Thanks for everyone that offered their help.


Early stopping

Tested early stopping to optimize epoch number, but the reduced amount of training data (as some is needed as validation data to trigger early stopping) often resulted in worse seq2seq accuracy results.


FCFS Implementation in Java

I would like to implement FCFS Scheduling Algorithm in Java! @lovishprabhakar

/assign

Pull request #434 @lovishprabhakar


#187 cached decorator to class :refactor

Codecov Report

Merging #251 into master will increase coverage by 2.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage      97%   99.15%   +2.14%
==========================================
  Files          13       13
  Lines         802      826      +24
  Branches       84       86       +2
==========================================
+ Hits          778      819      +41
+ Misses         23        7      -16
+ Partials        1        0       -1

Impacted Files
Coverage Δ

aiocache/decorators.py
100% <100%> (+18.47%)
:arrow_up:

aiocache/__init__.py
81.81% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f199741...0b6115b. Read the comment docs.


Scrolling child nodes

Hi, first of all thanks for creating this fork
In my case i have modal with input with autocomplete dropdown menu.
Dropdown can have it's own scroll.
How to configure body-scroll-lock-upgrade for this case?

Hi, first of all thanks for creating this fork
In my case i have modal with input with autocomplete dropdown menu.
Dropdown can have it's own scroll.
How to configure body-scroll-lock-upgrade for this case?

hello, For your question, I have written an example, you can refer to https://github.com/rick-liruixin/body-scroll-lock-upgrade/blob/develop/examples/vanilla-js/index.html    @krutoo

Hi, first of all thanks for creating this fork
In my case i have modal with input with autocomplete dropdown menu.
Dropdown can have it's own scroll.
How to configure body-scroll-lock-upgrade for this case?

It seems your problem has been solved, I closed this comment. @krutoo
https://github.com/willmcpo/body-scroll-lock/issues/257

@rick-liruixin But in your example there is no dropdown elements in modal dialog


Build directory compiled prior to assets.json creates disconnect

i'm attempting to use this plugin in my React/Fluxible project, however because the assets.json file is created after the bundle has already been compiled, the included assets.json file is not found during the build. If i redo the build process a second time without making changes it works. Not sure if this is an issue with the plugin or my configuration. If assets.json is required before the build process, but can't be built until the hash has been created, how's the flow supposed to go?
var config = {
  resolve: {
    extensions: ['', '.js']
  },
  entry: './app/client.js',
  output: {
    path: './build/js',
    publicPath: '/public/js/',
    filename: '[name]-[hash].js'
  },
  module: {
    loaders: [
      { test: /\.js$/, exclude: /node_modules/, loaders: ['babel'] },
      { test: /\.json$/, loader: 'json-loader'},
      { test: /\.css$/, loader: ExtractTextPlugin.extract('style', 'css!autoprefixer!rework')},
      { test: /\.(jpg)$/, loader: 'file-loader' },
      { test: /\.(png|woff|woff2|eot|ttf|svg)$/, loader: 'url-loader?limit=100000' }
    ]
  },
  plugins: [
    new ExtractTextPlugin('app-[hash].css'),
    new AssetsPlugin({
      path: path.join(__dirname, 'app', 'configs'),
      filename: 'assets.json'
    })
  ],
  rework: {
    use: [
      at2x(),
      inherit(),
      reworkNPM(),
      media(),
      parent,
      vars({})
    ]
  },
  stats: {
    colors: true
  },
  devtool: 'source-map',
  watch: true,
  keepalive: true
};

The assets json file has to be generated after the webpack build is done as it needs the stats generated by webpack. How are you trying to use this assets file?
Usually you would run the webpack build and then run something else that will use the assets json. Maybe a gulp task.

Make sure you're not using require(); to load the json file. If you do this then it will get cached. You should use fs.readFile or fs.readFileSync.


[listing] Handling Next JS Cache issues when buying listings

Description
Thinking of completely disabling NextJS page cache
If a user buys a listing, goes back to project overview, the page is rendered from cache
=> the old listing is still there, not updated
How to enforce that NextJS is always fetching new data on the server?
Docs
https://nextjs.org/docs/basic-features/data-fetching/incremental-static-regeneration
Ideas
getServerSideProps should work, it won't cache anything in cdn/static files, but it might still have a browser-cache header.
Downside is it would run up a bill during traffic spikes
and could be significantly less performant if we have to call the slow subgraph APIs every single time anyone visits the page. Static cached pages are mega fast in comparison
For getStaticProps there is a new method to invalidate programmatically using res.revalidate(path)
which we use in the api/pledge/ handler, for example: https://github.com/KlimaDAO/klimadao/blob/9d32d9678e53dea2566fd45ca3b61b4283fc6803/site/pages/api/pledge/index.ts#L34
but this assumes you have access to a response object, which you don't, because buying a listing is just a client-side smart contract interaction.
options:

easiest: re-fetch props on every page request with getServerSideProps()
less easy, and a tiny bit risky: set up a /revalidate endpoint and expose it to the client and call it from the client before navigating to the page https://nextjs.org/docs/basic-features/data-fetching/incremental-static-regeneration#using-on-demand-revalidation
hard: ask pixel to call it from the backend after a purchase? not sure if that still leaves a race condition

Answer from ChatGPT 😄
You can disable caching of a Next.js page by setting the no-cache header when the page is being served. This can be done in the getInitialProps method of the page component:
MyPage.getInitialProps = async (ctx) => {
  ctx.res.setHeader('Cache-Control', 'no-cache, no-store, must-revalidate')
  ctx.res.setHeader('Pragma', 'no-cache')
  ctx.res.setHeader('Expires', '0')
}

This will set the Cache-Control, Pragma, and Expires headers for the page, which will tell the browser not to cache the page.
Alternatively, you can use the next-no-cache package, which is a small middleware that you can use to disable caching for specific pages or routes. To use it, you can add the following code to your server-side code:
const noCache = require('next-no-cache')

server.use(noCache())

This will disable caching for all pages in your Next.js app.
It's worth noting that the no-cache header is a request directive, which means that it only applies to the current request and not to any subsequent requests. This means that if a user navigates away from the page and then comes back, the page will be served from the cache unless the cache has been invalidated in the meantime. If you want to completely disable caching for a page, you will need to set the no-store header as well. This will tell the browser not to store a copy of the page in its cache, and to re-fetch the page from the server on every visit.

This can be closed in favor of https://github.com/KlimaDAO/bezos-frontend/pull/434


VIP models

Hi
I supported the project through patronite because you are really doing a good job. I have this question what are the differences between the VIP models ?
What is the difference between them and the models that are in the free version

Hello and thank you for the support!
The VIP main models are from different stages of the training session and the inst models use a different set of training pairs that focus on the instrumental stem quality more.

You can definitely train your own model outbuilding the dataset takes a lot of work. If you're having trouble removing vocals from some tracks, I highly recommend you use ensemble mode to process your song through multiple models.

The main problem after removing vocals is the muffling of instruments or volume drops in certain parts of the song. It's as if too many frequencies have been removed along with the vocals. The sound is kind of muffled in these parts of the song.


Fixes to Kitties Part1, for smooth passing all tutorial steps

Just passed Part1 of the Tutrorial, found some little discrepancies on my way, proposing fixes for those.

I am happy to approve the change (with minor update above). But it is blocking due to the change request from @NukeManDan

Thank you very much for this @agryaznov :partying_face:


Implement standard unicode tests for Normalization Form C

We now have the implementation in place for normalization form C, we now to incorporate the standard Unicode tests for that normalization form.

Closing this in favor of #4, which is being made more generic.


recursion

Allow recursion in compiled nimbleFunction by fixing up what happens during sizeProcessing in such a case.

@perrydv What are the guidelines for when a recursive NF will fail to compile, and when it will compile?  I know we don't generally support it, but the example below compiles and runs fine.
Can you clarify in what circumstances a recursive function will compile & run?

library(nimble)

nfDef <- nimbleFunction(
    setup = function() {},
    run = function(a = double()) {
        print('in run, a = ', a)
        m(a)
    },
    methods = list(
        m = function(b = double()) {
            if(b > 0) {
                print('in m, b = ', b)
                m(b-1)
            }
        }
    )
)

Rnf <- nfDef()
Cnf <- compileNimble(Rnf, showCompilerOutput = TRUE)

Rnf$run(3)
Cnf$run(3)


rabbitmq 'failed to merge schema: bad cookie'

I was getting this error in rabbitmq pods greater than 0.
Failed to merge schema: Bad cookie in table definition rabbit_user_permission rabbitmq

I ended up finding this solution
Step1: Downscale the statefulset it will not delete the PVC.
kubectl scale statefulsets stackstorm-ha-rabbitmq --replicas=1

Step2: Access the RabbitMQ Pod.
kubectl exec -it stackstorm-ha-rabbitmq-0 -- /bin/bash

Step3: Reset the cluster
rabbitmqctl stop_app
rabbitmqctl force_boot

Step4: Rescale the statefulset
  kubectl scale statefulsets stackstorm-ha-rabbitmq --namespace teps-rabbitmq --replicas=3

Is there something we can change in this chart to help prevent/resolve this issue? Should this just be added to documentation somewhere? Or something changed in the values passed to the rabbitmq subchart?


Inertia-link not working in pagination

The fix is to import
import {Link} from '@inertiajs/inertia-vue3'; in the Pagination.vue and use link instead of the inertia-link

+1

+1

+1

+1

Duplicate of #36


Cancel button freezes parts of lecture edit page

Go to the lecture edit page, scroll down and click on "Comments". Change something in this area such that the buttons "Save and exit" and "Cancel" appear. If one clicks "Cancel" the page does not reload (as it should) and some parts of the page freeze.

I'll fix that after the Bootstrap 5 PR has been merged.


Problems with the lettering (maybe the font)

I compiled more than 600 crates, waited more than five hours, and then I got this.
Tell me what's going on, why are there no letters?
Note: I compiled this because the linux binary needs libc2.9 and I have libc2.8

I'm on Deepin GNU/Linux 20.5 (Debian base).
I want to try this, how do I fix the problem?

Duplicate of #450


Issue on first load with Dom / V-dom becoming out of sync

Current behavior

When returning to the VSF website, the token for Magento expires. Throwing an error "The consumer can not access itself"
Something strange happens after this initial error, almost as if the virtual dom and dom have become out of sync.
if the customer logs into the website after a day, they can not check out or log out without refreshing the page.
Expected behavior

Customer should be able to checkout / log out
Steps to reproduce the issue

Using version 1.12 of both vsf and the api.  Have 2 customer accounts on the vsf site.
Log in.  Close the site, return the next day. Log out and log in as the 2nd customer.
Go to the my account section and you will notice the 1st customer details are showing.
This also appears to prevent the customer from checking out.
Version of Vue Storefront

[ ] Vue Storefront

Can you handle fixing this bug by yourself?

[ ] NO

Which Release Cycle state this refers to? Info for developer. (doesn't apply to Next)
Pick one option.

[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Chrome

OS: Mac, Android, iPhone

Code Version: 1.12

Additional information
Please see screen shot of the point the error is initially thrown, the token appears to regenerate, however the customer data is incorrect

hey @teuma86 can you also check this on branch hotfix/v1.12.3? I've added some fixes for token invalidation to newest hotfix (not released yet)

hey @teuma86 can you also check this on branch hotfix/v1.12.3? I've added some fixes for token invalidation to newest hotfix (not released yet)

Good Morning
This appears to work fine on the branch hotfix/v.1.12.3.  Do you have a specific commit for this fix as this branch is not ready for release yet and we have just updated our clients site from 1.11 to 1.12?
Thank you
Jamie

Hey :),
those two:
https://github.com/DivanteLtd/vue-storefront/pull/4533/files
https://github.com/DivanteLtd/vue-storefront/pull/4882/files

closed by #4882

Star, Seemed to resolve my issue


Inscrutable decisions to split field accesses across lines or not

I have code that looks like this:
            let stacking_relative_border_box =
                fragment.stacking_relative_border_box(&self.base.stacking_relative_position,
                                                      &self.base
                                                           .early_absolute_position_info
                                                           .relative_containing_block_size,
                                                      self.base
                                                          .early_absolute_position_info
                                                          .relative_containing_block_mode,
                                                      CoordinateSystem::Parent);

The result looks like this:
           let stacking_relative_border_box = fragment.stacking_relative_border_box(
                &self.base.stacking_relative_position,
                &self
                    .base
                    .early_absolute_position_info
                    .relative_containing_block_size,
                self.base
                    .early_absolute_position_info
                    .relative_containing_block_mode,
                CoordinateSystem::Parent,
            );

Notice how the second argument has &self by itself, while the third argument has self.base sharing a line.

This is to prevent orphaning the self:
&self
    .base // . is under the f

self
    .base // . floats by itself

// worse case:
x
    .base

Obviously this is the edge case and we lose a little on consistency, but I think it is worth it to prevent the x case.


Add package Microsoft.Extensions.Logging.Debug

...to fix build in VS 2017

but this is credit to @derrick

I think you got the wrong Derrick.  I'm afraid I can't take credit for this.

This is the right @Derrick-
@aubergemediale can you get the branch up to date?

I think this can be closed, dupe of committed https://github.com/stratisproject/StratisBitcoinFullNode/pull/110

@Derrick- I didn't understand which PR do you want to close?

This PR is dupe of #110 which is already committed, so this one can be closed.

I don't think 110 is committed

Ahh yep, I thought it was committed so I rebased. My commit is gone from the PR.
But the change snuck in as part of my next commit:
https://github.com/stratisproject/StratisBitcoinFullNode/commit/65130cae397abd6f173b558be072b100bb06962d#diff-0330c405dd0d342eccd5457ff1bde5fa
So, needs closing

it's up-to-date now!

it's fixed anyway, only version could be upgraded to 1.1.1

So this is now fixed?

yes, I tested it, it was a build and it works now, somebody else fiixed it, too by adding:

My original pull request had:

But apparently v1.0.0 is also fine!


Nonexistent Custom Fields cause confusing error messages

Maybe this is something we fix via documentation - or commenting-out the Custom Fields parts of the example settings, I don't know.
But I've had a few customers now who have had 'problems' with jamf2snipe because they didn't read the documentation (and, let's be honest, nobody ever does), and just took the example settings file, tweaked it, and ran with it. We have the built-in expectation that all users will know how to use Snipe-IT, but I've tended to find that that expectation just isn't valid most of the time.
So we can either comment-out the Custom Fields bits (which feels wrong, tbh?) or make it so that you get a nicer, more glaring error when you try and set a nonexistent custom field. I don't know exactly how you'd do that though; I don't think Snipe-IT is going to give you a particularly useful error message. Though I'm not sure off the top of my head. One thing we certainly could do is hit the Custom Fields API (we'd have to parse _snipeit_ram_2 into just 2 for that), and confirm that the field exists, crashing out (with a convenient error message) if not?
Or maybe we just comment the dang things out. Not sure. _snipeit_mac_address_1 is pretty dang likely to be there (so long as no one has deleted it) so we could leave that one uncommented.

I think I might be able to address this by changing one of the methods - It's kinda the 'universal request' method for all Snipe-IT calls - and making it so that it looks for JSON that returns {"status": "error"} and then tries to throw with the message - I'll play around with it now that I have a good test environment.


[Bug]: Can't create new connection

What happened?
Can't create a new connection. Already tried a different version of the tool and a uninstall. It worked before..

What version of the tool are you using?
v2.1.10
What version of Visual Studio Code are you running?
1.85.1 / Mac OS M1
Any relevant session id from VSCode?
No response
Relevant log output
Error running command dvdt.explorer.connections.addConnection: command 'dvdt.explorer.connections.addConnection' not found. This is likely caused by the extension that contributes dvdt.explorer.connections.addConnection.

I faced same issue.
Error running command dvdt.explorer.connections.addConnection: command 'dvdt.explorer.connections.addConnection' not found. This is likely caused by the extension that contributes dvdt.explorer.connections.addConnection.
version : 2.1.10

Same here on OSX running on a M1.
Tool version 2.1.10
VS Code version 1.85.1
Node version 18.18, but also tried Node version 14.21 with same result.

Found an issue with a related Azure package. Have logged a bug with that team: https://github.com/Azure/azure-sdk-for-js/issues/28112

This is now resolved in v2.2.0. Please update the tool. Thanks for raising the issue.


throwing exceptions in functions tagged EXTERN_C

The functions SidesParBin, DealerParBin, and ConvertToSidesTextFormat in Par.cpp throw an exception in some cases, which is not permitted in a function marked extern "C".

Thanks, will fix


Initializing saver after variables are initialized and queue runners are started causes inconsistent behaviour.

GitHub issues are for bugs / installation problems / feature requests.
For general support from the community, see StackOverflow.
To make bugs and feature requests more easy to find and organize, we close issues that are deemed
out of scope for GitHub Issues and point people to StackOverflow.
For bugs or installation issues, please provide the following information.
The more information you provide, the more easily we will be able to offer
help and advice.
Environment info
Operating System:  Mac OsX (El Capitain)
Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
If installed from binary pip package, provide:

Which pip package you installed.
The output from python -c "import tensorflow; print(tensorflow.version)".
0.8.0

If installed from sources, provide the commit hash:
Steps to reproduce

Run the CNN example provided by tensorflow using a filename queue
Initialize variable and queue runners
Initialize a saver

What have you tried?

Tried running the exact same code with a saver that saves no values and no saver.  Simply initializing the saver at the wrong time is sufficient to cause weird behaviour.

Logs or other output that would be helpful
(If logs are large, please upload as attachment).
App will crash intermittently somewhere completely unrelated in code (usually native).
I know this is user error, but it would have been really helpful if an exception had been raised.  I wasted a lot of time trying to hunt down a mystery error when it turned out it was the saver all along.  This can be confusing to beginners such as myself.

The solution is to start the queue runners after you have finished building the graph (which includes the saver). Does that work for you?

Like I said, I understand this is user error.  I just don't see why this shouldn't be disallowed.  As a beginner it's really confusing to see unrelated crashes and there isn't an easy way to debug native code.
It's an easy mistake to make and the only feedback is random crashing.

We've gone back and forth on disallowing it—for example, we could call tf.Graph.finalize() in the tf.train.start_queue_runners() method, but that would break a lot of code that mostly works. However, it seems reasonable to log an ominous warning, to discourage this kind of code. At least it should help debugging. I'll prepare a change.


Regression: wgpu panic on window minimize

Bevy version
Regression occurs in 81d57e129b507047ab165b1cee1975cd54ba100f as a result of #3412
This bug is not present in 0.6.1, or any commits prior to the above PR merge.
Operating system & version
Win 11
What you did
Minimize an example window.
What you expected to happen
Nothing
What actually happened
thread 'main' panicked at 'wgpu error: Validation Error

Caused by:
    In Device::create_texture
      note: label = `sampled_color_attachment_texture`
    Dimension X is zero
wgpu-0.12.0\src\backend\direct.rs:2273:5

Additional information

@HackerFoo you are most likely to know where this is coming from. 🙂

I'm looking into it. I was able to reproduce the bug on MacOS using:
diff --git a/crates/bevy_window/src/window.rs b/crates/bevy_window/src/window.rs
index 47c03d085..ae34badc6 100644
--- a/crates/bevy_window/src/window.rs
+++ b/crates/bevy_window/src/window.rs
@@ -418,8 +418,14 @@ impl Window {
     #[allow(missing_docs)]
     #[inline]
     pub fn update_actual_size_from_backend(&mut self, physical_width: u32, physical_height: u32) {
-        self.physical_width = physical_width;
-        self.physical_height = physical_height;
+        println!("update {physical_width}, {physical_height}");
+        if physical_width < 400 || physical_height < 400 {
+            self.physical_width = 0;
+            self.physical_height = 0;
+        } else {
+            self.physical_width = physical_width;
+            self.physical_height = physical_height;
+        }
     }

     #[allow(missing_docs)]

and then shrinking the 3d_scene example window until it crashes.

i hit the same panic just by resizing the window when fit_canvas_to_parent is set to true.
Caused by:
    In Device::create_texture
      note: label = `sampled_color_attachment_texture`
    Dimension Y value 2050 exceeds the limit of 2048

', wgpu-0.13.1/src/backend/direct.rs:2391:5


How deploy a job using the HTTP api?

I trying to deploy a job using the http api, but y get this error :
Status Code: 422
Content-Type: application/json
Date: Thu, 03 Dec 2015 15:34:18 GMT
Helios-Server-Version: 0.8.603
Helios-Version-Status: MISSING
Transfer-Encoding: chunked

and the response body show this:
{"errors":[]}

Any idea???

What is the request (including all headers) that you are sending?

i send this:
http://<IP_ADDRESS>:5801/hosts/helios-01/jobs/Tytan:v1:55f1ae3ae433c528939968412610596c19ac5176

@alejandrojnm sorry for the slow response. Does your helios master log anything related to your command?

Now you can do deploy, jobs. I would like you to try the aplicaccion. https://github.com/alejandrojnm/Helios-Manager


Remove address field

Codecov Report

Merging #20 into working-v1.2 will decrease coverage by 0.63%.
The diff coverage is 90.00%.

@@                Coverage Diff                 @@
##             working-v1.2      #20      +/-   ##
==================================================
- Coverage           72.31%   71.68%   -0.64%
+ Complexity            400      387      -13
==================================================
  Files                  70       69       -1
  Lines                1228     1190      -38
  Branches              124      117       -7
==================================================
- Hits                  888      853      -35
+ Misses                308      306       -2
+ Partials               32       31       -1

Impacted Files
Coverage Δ
Complexity Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)
8.00 <0.00> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
80.00% <ø> (-3.34%)
1.00 <0.00> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
96.77% <ø> (-0.45%)
12.00 <0.00> (-2.00)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <ø> (ø)
1.00 <0.00> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...c/main/java/seedu/address/model/person/Person.java
97.22% <66.66%> (-0.34%)
19.00 <0.00> (-2.00)

...java/seedu/address/logic/commands/EditCommand.java
96.72% <100.00%> (-0.30%)
12.00 <0.00> (ø)

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)
5.00 <0.00> (ø)

.../seedu/address/logic/parser/EditCommandParser.java
91.66% <100.00%> (-0.65%)
10.00 <0.00> (-1.00)

.../java/seedu/address/storage/JsonAdaptedPerson.java
100.00% <100.00%> (ø)
9.00 <0.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd2f16...2cd1298. Read the comment docs.

Can you rebase and then should be good to go.


Add release edition without JavaFX on the classpath

The Java FAF client brings JavaFX along and doesn't need to include these huge libraries twice.

I already tested this and added a manual version to the v3.2.0 release. So I know it works.


[popup] Ability to easily change profile language

Description:
I have to change my language quite a lot from Dutch to English to German and back. It is almost impossible to use the Salesforce setup in Dutch or German so this MUST be English :-)
But I need to look at the user interface a lot in Dutch and German because my users use their native language and it is easier to support them that way. Now I have to go into my profile, change the language and go back to the page I was working on several times a day.
Possible solution:
Is it possible to create a switch in the inspector that allows me to change the interface language with a simple click of a button.

Hi @Roland-Circle8,
I'll take a look to see if it's easy to implement !

Thanks! I have the beta version running, so if it is possible I will be happy to help you with testing.

I also need this feature, sometimes working on projects with multiple languages, I often had to switch to validate both perspectives.

Language switcher is coming guys !


New Patients not seen while running an app from scratch

Clarify the steps to take for loading patient list while starting from scratch or deleting local database.

2020-12-03 17:33:02.004 9502-9604/com.google.fhirengine.example D/OkHttp: --> GET http://hapi.fhir.org/baseR4?_getpages=51e4f072-c00d-417d-a239-2cdf673a15c0&_getpagesoffset=20&_count=20&_pretty=true&_bundletype=searchset
2020-12-03 17:33:02.004 9502-9604/com.google.fhirengine.example D/OkHttp: --> END GET
2020-12-03 17:33:02.007 9502-9604/com.google.fhirengine.example D/OkHttp: <-- HTTP FAILED: java.net.UnknownServiceException: CLEARTEXT communication to hapi.fhir.org not permitted by network security policy
2020-12-03 17:33:02.011 9502-9532/com.google.fhirengine.example I/WM-WorkerWrapper: Worker result FAILURE for Work [ id=f6277313-2f2d-4b86-80a8-6629ea461472, tags={ com.google.fhirengine.example.data.FhirPeriodicSyncWorker } ]

There seems to be a difference in ListActivity behaviour between API version 21 vs version 28.
Currently I'm not able to see Patient list on Ver 21, but works on Ver 28,
Trying to figure out more.


[feature] Handle data in ping/pong frames

Add ability to send ping/pong frames with application data attached (as per RFC6455, section 5.5.2 and 5.5.3).
Also, when such frames are received, application data (if any) is displayed in the console.
Example:
$ bin/wscat -c ws://<IP_ADDRESS>:80 --slash -P
Connected (press CTRL+C to quit)
> /ping
< Received pong (data: "")
> /ping foo
< Received pong (data: "foo")

Thank you.


Support for JSON schema

Is your feature request related to a problem? Please describe.
I need to call a 3rd party library by passing a large pandas dataframe. I also need to validate the dataframe before passing that across. The 3rd party library provides JSON schema for the dataframe. My current validation gets slow as the dataframe gets bigger. Switching to pandera is an option but I need to convert JSON schema to pandera specific yaml schema. This is a bit clumsy, error prone and not future proof.
Describe the solution you'd like
Pandera to support JSON schema. Instead of all users convert existing JSON into specific format, it would be very practical for pandera library to do this. So, something like this:
schema = pandera.from_json(json_schema_filename)
Describe alternatives you've considered
Alternative is to convert from JSON to pandera specific format manually, which is clumsy, prone to error and not future proof.
Additional context
None

thanks for the feature request @padlam001, this is a duplicate of #421, closing this one.
contributions welcome!


Add cargo deny to CI

Add github workflow to run cargo deny tool on the workspace
cargo deny: https://github.com/EmbarkStudios/cargo-deny
Action: https://github.com/EmbarkStudios/cargo-deny-action

closed in #1219


Increase timeout [Task - Archive docker image] #279

#284 needs to be merged before this, then rebase. VERY important patch


help

error:
PS C:\Users\alright\Desktop\that is him> python -m openui
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in run_code
File "C:\Users\alright\anaconda3\Lib\site-packages\openui_main.py", line 3, in
from . import server
File "C:\Users\alright\anaconda3\Lib\site-packages\openui\server.py", line 30, in
from .session import DBSessionStore, SessionData
File "C:\Users\alright\anaconda3\Lib\site-packages\openui\session.py", line 5, in
from .db.models import Session, ensure_migrated, Usage
ModuleNotFoundError: No module named 'openui.db'
how could you fix it?

Hmm, this is odd.  You might be able to add openui.db to this list and rebuild but not sure you want to bark up that tree.  The other thing to do would be to run the following and see if this works:
pip uninstall openui
cd ./backend
pip install -e .
python -m openui

Let me know if you're still getting the error, seems like it's something funky with your python environment.


[Doc]  redelivery backoff policy for ack timeout

This PR adds docs for   [PIP-130] Apply redelivery backoff policy for ack timeout  #13707
Preview looks good:

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x]  doc

@nodece can you review this PR from the technical perspective?

@liudezhi2098 Looks good to me.


refactor: create larger screen by default

Minor cleanup to pass through the angle on move and to make the default size larger

Good idea!


Draft: Cleaning up some comments, and fixing the close file bug.

Whilst I was tidying up, I found #94. Let's fix it!
Also fixes #87 and #90

Let's do #72 too!

Fixes #86 too

A failure to update the directory entry will mean that it looks like the file has X bytes when it in fact has Y bytes in it. There data is still there but if X < Y, then you won't be able to access it, or it X > Y then you will read garbage on the end of your file (and possibly get a read error if you fall off the end of the cluster chain). The clusters will have been allocated at the point you did the write, so at least nothing else will be able to write over your data. Deleting and re-creating the file will fix the issue so no major harm done.
I believe the same issue occurs with MS-DOS.
We could in future add a guard to the File object so that if you drop it without closing it you get a panic. That might be better than silently truncating the file.

I was adding a note about Drop support not being implemented on File. Then I noticed that it would basically be impossible because each File would need to borrow both the VolumeManager and the Volume.
So, five hours later, File, Directory and the new Volume are just integers uniquely identifying an object stored inside the Volume Manager. So if you want to implement Drop on File you now only have to keep a reference to &RefCell<VolumeManager> in your DroppableFile structure. Also you no longer need to keep passing that &Volume value, which is nicer.

I'll leave the fat16/32 impls review

Hopefully that bit didn't change much.

To allay (my, and other's) concerns I'm writing some more test cases and trying to get the tarpaulin coverage number up.

OK, I should stop fiddling and just merge it now. Last call!

Closes #75

thank you @thejpster for spending time to work on the crate!
Amazing work!

Thank you for the thoughtful comments! Much appreciated.

@ryan-summers  if you're happy would you mind pressing approve? It's set to auto merge.

@thejpster if you add me with maintainer or write access, that should solve things :) or just force merge if you'd prefer

Bumped all members up to write permission. It was set to Read for some reason.


Fix error parsing in compilation buffers

I'll give it another try, but help is also very appreciated =)
#26 #110 #197

I'm really motivated to fix this once and for all and already took a closer look at the parse functions of compile.el. But I actually have issues to find a situation where the parsing fails. It also seems the tests I've added years ago don't fail anymore.
Can somebody give me a hint before I forget what I looked up the last days =)

I've been testing error parsing a lot recently and added more elisp tests and still couldn't find anything that doesn't work. I decided to close this issue. Users hopefully open new issues when they encounter problems. We also fixed some stuff from the old issues that are linked here, like adding the command to the beginning of the compilation buffer.


Display Scaling on Windows in Qt6 Builds is Broken

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
When using display scaling on Windows (for high-dpi monitors), Chatterino itself will be scaled (even though on Windows, it compensates for high-dpi). I'm pretty sure this is because Qt::AA_DisableHighDpiScaling was removed (it still exists, but doesn't have any effect). The new documentation on high-dpi doesn't mention any application-attribute that can be set. As far as I know, display-scaling on macOS and Linux is done "correctly". Something to keep in mind is that on Windows, a lot of native events are consumed that use native (non-scaled) coordinates.
A not-so-great-but-working workaround is this:
diff --git a/src/main.cpp b/src/main.cpp
index 303d8ea2..874643e4 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -24,6 +24,9 @@ using namespace chatterino;

 int main(int argc, char **argv)
 {
+#ifdef Q_OS_WINDOWS
+    qputenv("QT_ENABLE_HIGHDPI_SCALING", "0");
+#endif
     QApplication a(argc, argv);

     QCoreApplication::setApplicationName("chatterino");

Not that QT_ENABLE_HIGHDPI_SCALING is described as "This variable is intended for testing purposes only, and we do not recommend setting it on a permanent basis.".
Screenshots

OS and Chatterino Version
Chatterino Nightly 2.4.2 (commit 20bdfaef) built on 2023-04-16 with Qt 6.5.0, Windows SDK, MSVC 193431943, Crashpad Running on Windows 10 Version 22H2, kernel: 10.0.19045

I experimented with some changes on fix/dpi. This attempts to use the same code for high-dpi as on Linux or macOS. There are obvious shortcomings:

Dragging the window from a monitor with DPR=1 to a monitor with DPR>1 increases the window size.
When starting, the window is too large.
Emotes (seemingly (?)) draw the 1x version (I don't know how this is handled on Linux and macOS).

👍


Delay option while autotyping

Is it possible to get a configurable delay (maybe in ms) in an autotype sequence ?

Sound's like a good idea. You mean something like: user :delay :tab pass? And having the length of the delay as a config option?

Yes ! It's mostly useful on multiple pages login. Being able to do user :enter :delay password :enter would be great

:+1: Definately useful!