Add readOnly to NEP-3

Camelcase for json property names

Can we discuss it again, why do we need readOnly? What is its use?

https://github.com/neo-project/neo/issues/927
Is for ensure that is not possible to execute a write operation in these methods, in order to prevent the write access

Why to prevent the write access?

As @igormcoelho said:

offchain services execute operations by themselves (unless forced to send to chain); and two, a readonly storage context is provided

Before this change, the developer promise to not modify the state if the method is safe, after this change is not a promise, is a must.
Also, the Abi will be compleated by the compiler acording to the Attributes, and developers doesn't need to create/modify the Abi.

Can we remove readOnly from ABI, and extend the syscall System.Contract.Call, add a new parameter readOnly to it?

But then, how the wallet know when they need to execute the context as readOnly?

Why a wallet need to execute the context as readOnly?

Imagine that you want to create a website like etherscan.io, and allow to execute readOnly methods (without relay), you need to know what methods are readOnly and what methods don't.
https://etherscan.io/address/0x01eacc3ae59ee7fbbc191d63e8e1ccfdac11628c#readContract

I think readOnly and relay are irrelevant.

How do you do this website without know which methods are readOnly and which methods not?

I don't know. Why people need to know it? If I make this website, I will provide a uniform list of methods without distinguishing between read-only or not.

🤔  🤔  🤔
Lol, you are right @erikzhang , this change makes no sense 😅 . I don't think people would even send TX to the blockchain that does not alter the storage. And even if they did, there is no difference, because making a method read-only won't remove the dependency of the storage.
Maybe we need a "no storage" flag instead of a readOnly. A method that has no access to the storage (stateless) can be used in optimizations since these are certain to be "thread safe".

Maybe we need a "no storage" flag instead of a readOnly. A method that has no access to the storage (stateless) can be used in optimizations since these are certain to be "thread safe".

This is precisely for this, allow to create methods that ensure that no changes will be made on the blockchain, has the same behavior of view in ETH

@shargon  but read-only still depends on the state, even if it is read-only, we can have different results if the content of the storage is changed. This is not true for real stateless methods

maybe we need three states instead of two
storage=stateLess, writable, readOnly
But is very important this information in the abi.

Why do we need the readonly? I think we only need stateful and stateless methods. And I believe all methods should be either of them, always. If nothing is said, it is stateful. What do you think @shargon ? I can't see the gains of only having "read only". Can you point it to me?

I think we only need stateful and stateless methods. And I believe all methods should be either of them, always.

I think even the same method can have different state dependencies on each execution.
if (needToWrite)
{
    //Write something to storage
}
else
{
    //return constant
}

So we should specify an option each time we call a method, which can include an agreement on whether the called method has permission to access the state.

For me is the same case as view in ethereum, but they don't do any check at runtime, is only for the abi
https://solidity.readthedocs.io/en/latest/contracts.html#view-functions
"This means library view functions do not have run-time checks that prevent state modifications"

Any news? this should be closed or updated?

Another reason that makes this interesting is that it allows libraries that interact with the blockchain, such as neon-js, to detect which calls require actual transactions and which can be done using a simple RPC call to any node, while providing a unified API.
Example:
contract.getName() // -> RPC call
contract.setName("hey") // -> transaction

https://github.com/neo-project/neo/blob/24da2bd8df2612643b3a4840cca2bea77b305daf/neo/SmartContract/Manifest/ContractManifest.cs#L59
The readonly is in manifest, and it is named as safemethods. So it is easy to be checked.
This proposal is to move it from manifest to abi. It is a different thing.

I see, you are right in that my comment is invalid then.

I vote to move this to the ABI, we can use an attribute at smart contract level. As @corollari mentioned, this is helpful to know when we can use RPC directly and it may also be useful for optimizations. Also, the ABI is an adequate place for it because it is where we store information about the methods in our contract.


Update streamlink-twitch-gui to 1.3.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 7847a03e72bb9c7c1d57eecc1278b8018a3dd3c7. Your contribution is still credited to you.


Two-factor auth failure does not get logged to the auth log

Rainloop build <IP_ADDRESS>1, default config block but with auth logging turned on. Let me know if you need any additional info.

Fixed in <IP_ADDRESS>3


bug: restore samples to the Bazel builds.

I accidentally removed the samples from the Bazel builds, this change
restores them.

This change is

Codecov Report

Merging #614 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   94.32%   94.28%   -0.04%
==========================================
  Files          79       79
  Lines        3013     3010       -3
==========================================
- Hits         2842     2838       -4
- Misses        171      172       +1

Impacted Files
Coverage Δ

google/cloud/spanner/internal/spanner_stub.cc
66.66% <0%> (-1.2%)
:arrow_down:

google/cloud/spanner/keys.h
98.63% <0%> (-0.04%)
:arrow_down:

google/cloud/spanner/transaction.h
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c53269...80be58c. Read the comment docs.

@scotthart sorry, clearing the "draft" bit  discarded your review.

PTAL


Augmented assign with multiple variables fails

Augmented assign fails after you declare several variables at once:
red_sum = core.IntegerVariable()
green_sum = core.IntegerVariable()
blue_sum = core.IntegerVariable()
for i in range(len(self.buffers)):
    red_sum += self.neighbors[i].buffer.red + 1
    green_sum += self.neighbors[i].buffer.green + 1
    blue_sum += self.neighbors[i].buffer.blue + 1

Howewer, if you declare and augment them one by one, the following code works:
red_sum = core.IntegerVariable()
for i in range(len(self.buffers)):
    red_sum += self.neighbors[i].buffer.red + 1
green_sum = core.IntegerVariable()
for i in range(len(self.buffers)):
    green_sum += self.neighbors[i].buffer.green + 1
blue_sum = core.IntegerVariable()
for i in range(len(self.buffers)):
    blue_sum += self.neighbors[i].buffer.blue + 1

A brief investigation shown all 3 vars having same hashes after a series of augmented assigns. Probably overridden magic method returns wrong self reference.

This issue seems to be fixed, also tests are rewritten in order to cover this case in future.


14 integrate docker services and unitest in GitHub actions

closes #14

@basarbyz The rest looks good!


Set the defaultProp's value of URLs in TryoutController component

Without passing null you can also set the defaultProp's value of URLs in TryoutController component and leave it empty here.
TryOutController.defaultProps = {
  URLs: null,
};

Originally posted by @chanaka3d in https://github.com/wso2/apim-apps/pull/100#discussion_r754840547

We are closing the issue due to a long period of inactivity.


Empty altitude response

Did something change with the altitude code? My scan.log file is full of
[2017-02-17 09:44:06][ WARNING][spawns] Empty altitude response for (##.###,##.###), falling back to random.
.## added for privacy :)

I just added logging instead of silently falling back to random. Did you set a Google API key in config that has the elevation API enabled?

Ah that's what happened, my google key wasn't correct apparently. I double checked and put in the code again.. I must have missed a digit or two the first time, but now Im not getting any of the messages. Thanks for the place to look :)


Extract max-states pass.

Fixes #227.

To make sure this actually works, we should add an option to the fud execution to use the IR-based max states as well: https://github.com/cucapra/filament/blob/main/fud/filament.py#L181

Can we instead merge this into #256 and replace the max-states in the old flow with this? That PR doesn't have any of the old flow at all.


Encountered a small issue while training the “train_DistCorr.py”  file.

The operation is as follows：
1、train_txt_path = r'E:\project\DIC_Detection\self\hub\CCS\CCS-main\dataset_img2.txt'
Path Example,
G:\stereoCalibration\dataset\composite\480X480_CCS\test\img\10-0.jpg G:\stereoCalibration\dataset\composite\480X480_CCS\test\heatmap\10-0.npy
2、when running “train_DistCorr.py”

"loss_util.py" happen

How can I solve the problem?
Is the dimension a problem with loading data ”train_txt_path “ files, or is it somewhere else? Where is the detection data generated （corners_before[:,0]） for corner loading? What are the dimensions referring to?
Looking forward to your recovery.

It may be caused by different numpy versions. This part is to load corner data generated by our code. You can investigate the generated corner data.


Fork of spectral

To @cfrancia,
While this repo has been inactive for quite a long time, spectral remains very useful so I decided to create a fork named speculoos. The idea is to be able to integrate feature that people are asking for and continue improving your work.
I hope you are ok with this. ,
I doubt you will read this since you have not been around for a while. But if you do I will be happy to here from you.
To spectral contributors
@woshilapin, @kirushik, @sazzer, @misos1, @Riduidel, @rrichardson, @viktorchvatal, @edibopp , @kirushik.
Here is what I have done so far :

making all the doc tests actually pass  (except for Path and PathBuf assertions)
implemented a does_not_contain assertion on str/String

Don't hesitate to reopen your issues/PR on speculoos if you still think those are worth it.
I will need some time to get familiar with the whole code base but I will be happy to share ideas on how to improve spectral.
I do not plan to keep repo ownership for myself so if anyone is interested to co-maintain speculoos don't hesitate to reach me.

Feel free to copy over my issue. Just fail_with_message feels like it should be public so you can override a message like you could do for example with assert!.


No more intellisense for react and react-native

Issue Type: Bug
I am not sure if it started after the automatic VS Code update, but from yesterday I have lost intellisense for React and React Native.
When I start typing, for example "<ScrollView" I see the popup suggesting to import from "react-native-web", and "react-native-gesture-handler".
Until yesterday I always had the option to import from those, plus "react-native".
Another example is when I type "useState", I don't get the usual intellisense for react.
This is slowing me down a great deal, like I think many others...
(I tried with the "Auto Import" extension on and off)
VS Code version: Code 1.65.0 (b5205cc8eb4fbaa726835538cd82372cc0222d43, 2022-03-02T11:12:08.962Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 3696)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.68GB (4.35GB free)

Process Argv
--crash-reporter-id b4e5dcc1-76a6-4eef-8368-13ea4e35c599

Screen Reader
no

VM
0%

Extensions (33)

Extension
Author (truncated)
Version

sort-imports
ama
6.3.1

laravel-extra-intellisense
ami
0.6.2

vscode-intelephense-client
bme
1.8.2

vscode-expo
byC
0.7.4

path-intellisense
chr
2.8.0

laravel-goto-view
cod
1.3.7

vscode-eslint
dba
2.2.2

es7-react-js-snippets
dsz
4.4.3

EditorConfig
Edi
0.16.4

vscode-great-icons
emm
2.1.82

react-native-react-redux
EQu
2.0.6

prettier-vscode
esb
9.3.0

auto-rename-tag
for
0.1.10

laravel-create-view
gli
0.0.6

laravel-blade-wrapper
IHu
1.0.1

dotenv
mik
1.0.1

csharp
ms-
1.24.1

vscode-react-native
msj
1.9.2

laravel-goto-components
nao
1.2.0

react-proptypes-intellisense
OfH
1.0.3

laravel-blade
one
1.31.0

laravel-extension-pack
one
1.1.0

laravel5-snippets
one
1.15.0

laravel-artisan
rya
0.0.28

code-settings-sync
Sha
3.4.3

vscode-blade-formatter
shu
0.13.3

laravel-goto-controller
ste
0.0.15

vscode-icons
vsc
11.10.0

vscode-import-cost
wix
2.15.0

php-debug
xde
1.25.0

vscode-surround
yat
1.2.2

propertylist
zho
0.0.2

material-theme
zhu
3.13.20

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30433507
vsclayoutctrt:30448491
vsrem710:30416614
dsvsc009:30440023
pythonvsnew555cf:30442237
vsbas813:30436447
vscscmwlcmt:30438805
vscgsvid2:30447481
helix:30440343
vscaat:30438848

Please share a minimal example project that demonstrates the issue

Hi @mjbvz I compared my package.json file with other projects and I saw some differences.
I tried to install @types/react-native into this one and then the intellisense started working again.
So now I am wondering......
Why would it not work without this package?
Why did it work before, without it?

Can you please share the project that causes this (or at least the package.json)

I can't share this repo but definitely i can share the package.json file:
  "dependencies": {
    "@react-native-async-storage/async-storage": "~1.15.0",
    "@react-native-community/datetimepicker": "^4.0.0",
    "@react-navigation/bottom-tabs": "^6.2.0",
    "@react-navigation/drawer": "^6.3.1",
    "@react-navigation/material-top-tabs": "^6.1.1",
    "@react-navigation/native": "^6.0.8",
    "@react-navigation/native-stack": "^6.5.0",
    "@types/react-native": "^0.67.2",
    "apisauce": "^2.1.5",
    "date-fns": "^2.28.0",
    "expo": "~44.0.0",
    "expo-app-loading": "~1.3.0",
    "expo-constants": "~13.0.1",
    "expo-location": "~14.0.1",
    "expo-secure-store": "~11.1.0",
    "expo-status-bar": "~1.2.0",
    "expo-system-ui": "~1.1.0",
    "expo-updates": "~0.11.6",
    "formik": "^2.2.9",
    "http-status-codes": "^2.2.0",
    "linq": "^4.0.0",
    "lottie-react-native": "5.0.1",
    "react": "17.0.1",
    "react-dom": "17.0.1",
    "react-native": "^0.64.3",
    "react-native-gesture-handler": "~2.1.0",
    "react-native-maps": "0.29.4",
    "react-native-open-maps": "^0.4.0",
    "react-native-pager-view": "5.4.9",
    "react-native-reanimated": "~2.3.1",
    "react-native-root-toast": "^3.3.0",
    "react-native-safe-area-context": "3.3.2",
    "react-native-screens": "~3.10.1",
    "react-native-tab-view": "^3.1.1",
    "react-native-web": "0.17.1",
    "yup": "^0.32.11"
  },
  "devDependencies": {
    "@babel/core": "^7.12.9",
    "babel-preset-expo": "~8.1.0"
  },

So if i remove this ("@types/react-native": "^0.67.2",) the intellisense is gone now. If I add it, it comes back, on both computers where I code.

@stesvis are these JavaScript or TypeScript files? Do you have a tsconfig.json or jsconfig.json file in your project directory?

@stesvis are these JavaScript or TypeScript files? Do you have a tsconfig.json or jsconfig.json file in your project directory?

It's a react native app on Expo. I don't have neither a jsconfig or a tsconfig. It ships with an app.json file only.

I recently set up a new computer, I first used "npx create-react-app my-app" to create a new react project. All import suggestions showing correctly for a few weeks. After a few weeks, I setup a project with "npx create-react-app my-app --template typescript" and now all of my standard react projects no longer receive the correct import suggestions, but the react with typescript projects do receive them correctly. So, it seems like the issue is adding typescript via create-react-app?

Como pode resolver esse problema sem um jsconfig.json?

Any idea of whats going on with this ??
it stopped working for me today, the regular "TS" on another vs code without react native does work

Please share a minimal example project that demonstrates the issue

I created a brand new Expo app with react native, I have no intellisense for react native unless I install @types/react-native https://github.com/stesvis/ReactNativeDemo

same for me

It's pretty easy to get it up & working again using this. https://www.youtube.com/watch?v=59vqVqIGEe8&feature=youtu.be


could not find react-redux context value;

Could not find react-redux context value" inside react-redux. :cry:

@kahirokunn that's really not enough info for us to offer any help.
Do you actually have a Redux store setup and and a <Provider> around your app, per the instructions?
https://rtk-query-docs.netlify.app/introduction/getting-started/#wrap-your-application-with-the-provider

In my environment, I don't get this error when using useDispatch inside a Provider. However, if I change useDispatch to use hooks obtained from RTK Query such as useGetPokemonByNameQuery in the sample, the error occurs.

I thought that maybe a different react-redux was installed, which resulted in a different context, but that was not the case.
$ ls node_modules/@rtk-incubator/rtk-query/
LICENSE  README.md  dist  package.json  src

I found the cause.
Using the debugger, I found that rtk-query imports react-redux/es.
My babel was configured to import react-redux/lib.
Therefore, it was referring to a different Context.
This was a simple mistake.
The following fix fixes it.
I apologize for the inconvenience.
"plugins": [
  ["transform-imports", {
    "react-redux": {
-      "transform": "react-redux/lib",
-      "transform": "react-redux/es",
      "preventFullImport": true,
      "skipDefaultConversion": true
    }
  }]
]

yup, something like that is usually the case :)


Fixes #1004, get rid of old chart stuff

Also skips tests that can't be run right now.

We can totally add comments.


feature(app): Add a debugging summary function, exposed via http

When someone says they have a performance problem, the first thing I want to know is whether Scope is reporting 26,000 processes on a node, or similar.  It's awkward to do that via the raw reports, so I wrote this summarising function you can call via URL /admin/summary
Example output:
pod:183, service:81, deployment:87, daemon_set:8, stateful_set:2, cron_job:5, namespace:14, persistent_volume:3, persistent_volume_claim:4, storage_class:1
ip-172-20-2-197;<host>:endpoint:992, process:369, container:101, container_image:41, host:1, overlay:1
ip-172-20-1-59;<host>:endpoint:266, process:250, container:43, container_image:15, host:1, overlay:1
ip-172-20-3-247;<host>:endpoint:891, process:383, container:107, container_image:43, host:1, overlay:1

Update the Github issue template to paste the output of /admin/summary whenever filing a new bug

I think I will leave this until experience tells us we need the info very often.


Put "no consumergroups" in the docs more times

We get a lot of questions on this still.
@wvanbergen

:+1:


Small ie usability changes

Made sure monitor gizmos are on Interaction Status by default, instead of the more unintuitive activity depth.
Removed the 'pause simulation' toggle because it was not useful in any way.

@ajohnston33

These are superficial changes that will be safe to release.


[Bug] Small Documentation Error

Describe the bug
On page 40 of the documentation pdf (6.17 Sets) the code given to generate all sets of order n from a list is given as "var t = [ 1, 2, 3 ].tuples(2)" which is identical code as given in 6.16 Tuples to give all tuples from a given list. Likely all that would need to be changed is updating the example code.

Fixed in 0.5.4


juncheng edits

Thanks for the commit bro! Can I trouble you to git pull my branch first (I made a decent amount of updates to some of the notes recently), and just include the encapsulation and subtyping updates in the PR first? So it is easier for me to review. Thanks!


%z in datetime style formatting options doesn't return offset

Describe the bug
%z in datetime style formatting options doesn't return offset
For example:

--latest-stamps option for profile download return 2021-10-03T09:49:02.000000+0300 timestamp
For latest post from same profile --post-metadata-txt="{date:%Y-%m-%dT%H:%M:%S.%f%z}" returns 2021-10-03T06:49:02.000000
For same post --post-metadata-txt="{date_local:%Y-%m-%dT%H:%M:%S.%f%z}" returns 2021-10-03T09:49:02.000000

And in both cases %z is empty
To Reproduce
instaloader --post-metadata-txt="{date_local:%Y-%m-%dT%H:%M:%S.%f%z}" -- -<post_id>
Expected behavior
For second case --post-metadata-txt %z should return +0300
Error messages and tracebacks
None
Instaloader version
4.8.1
Additional context
None.

Indeed, thanks for reporting! date_utc and date_local currently are naive datetime objects which do not carry timezone information, hence %z is empty.

Fixed in Version 4.8.3.

I have postponed the change that date_local returns a timezone-aware datetime object to version 4.9, and date_utc remains a timezone-unaware datetime object, as a compromise, especially to maintain compatibility between minor releases of version 4.8, and still provide a timezone-aware datetime object as of 4.9 as date_local, without breaking backwards compatibility in date_utc comparisons. Accordingly, I have also removed this change from 4.8 and moved it to 4.9.


[BUG] Issue with personal_finance example

I have a problem with calling the functions, apparently, it's not using the call_functions method but I don't know where to put it.
This is what I get:

#62 created a pull request

Please try again since we merged #63 and #64


release v1.0.1

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

v1.0.1
GitHub release

Your semantic-release bot :package::rocket:


Choose which port to run.

When ran, the app just seems to pick a random port to start, and it'd be nice for be to be able to pick a specific port to listen.
It would be useful for something like Heroku, where you need to pass the port as an env var.
I couldn't find any info in the docs nor after skimming trough the code quickly.
Can someone hand a light about this?

uhm, everything in discord.js should be using 80 (http) and 443 (https), since all our stuff runs over rest and websockets.

Well, a simple lsof shows that it is bound to a port other than 80 or 443, ex:
lsof -Pan -p 13773 -i
COMMAND   PID USER   FD   TYPE   DEVICE SIZE/OFF NODE NAME
node    13773 igor   11u  IPv4 15259991      0t0  TCP <IP_ADDRESS>:51502-><IP_ADDRESS>:443 (ESTABLISHED)
And after every run, it binds to a new port.
So, any idea how can I specify this port?

http://lmgtfy.com/?q=how+tcp+works

That wasn't really useful...
Anyway, even if it uses 80 or 443 by default, is there a way to change it somewhere?

it uses 80 and 443 because that is how http works. you cannot change it.

To change the port, you'd have to ask Hammer & Chisel to change the port Discord's servers run on.


How to use the internal TypeScript types?

There are lots of internal types that say "export type" but there's not any way to actually access them from a TypeScript import.
Example:
I'm trying to use the internal ColorTypes type (input to the new Color() constructor). These are the ways I've tried so far that don't work:

default import:import Color from 'colorjs.io';
type ColorTypes = Color.ColorTypes; // does not exist

destructured import:import {ColorTypes} from 'colorjs.io'; // does not exist

Workaround
With some type system trickery it is possible to extract this type, but it's quite annoying and requires the use of a huge OverloadParameters helper from this comment:
import Color from 'colorjs.io';

/** Overloaded function type helpers */
type OverloadProps<TOverload> = Pick<TOverload, keyof TOverload>;

type OverloadUnionRecursive<TOverload, TPartialOverload = unknown> = TOverload extends (
    ...args: infer TArgs
) => infer TReturn
    ? TPartialOverload extends TOverload
        ? never
        :
              | OverloadUnionRecursive<
                    TPartialOverload & TOverload,
                    TPartialOverload & ((...args: TArgs) => TReturn) & OverloadProps<TOverload>
                >
              | ((...args: TArgs) => TReturn)
    : never;

type OverloadUnion<TOverload extends (...args: any[]) => any> = Exclude<
    OverloadUnionRecursive<(() => never) & TOverload>,
    TOverload extends () => never ? never : () => never
>;

type OverloadParameters<T extends (...args: any[]) => any> = Parameters<OverloadUnion<T>>;

/** Extracted ColorTypes */
type ColorTypes = Extract<OverloadParameters<(typeof Color)['get']>, [any]>[0];

Other import attempts that fail:

import {ColorTypes} from 'colorjs.io/dist/color';
import {ColorTypes} from 'colorjs.io/src/color';

When I was writing the types I guess I didn't think about re-exporting them at the top level. I could make a PR for that when I get a chance, probably today or tomorrow.

Ah, I found one that works:
import {ColorTypes} from 'colorjs.io/types/src/color';

At least there's a sane way to access them. Still, this seems like an accidental feature; I'd expect to be able to access the types directly from a colorjs.io import.

Yeah, I agree. I've been accessing them this same way (e.g. import type { PlainColorObject } from 'colorjs.io/types/src/color';), but it makes sense to export them at the top level. @MysteryBlokHed I'm happy to review your PR once it's submitted.


feat: support service registeration and discovery with Netflix Eureka

What type of PR is this?
feat: support service registeration and discovery with Netflix Eureka.  This is part of the community's onging effort to integrate hertz with mainstream service discovery solutions. https://github.com/cloudwego/hertz/issues/197

What this PR does / why we need it (English/Chinese):
support service registeration and discovery with Netflix Eureka

Which issue(s) this PR fixes:

None

LGTM


Documention: Restore documenation

This commit should restore the balena-sound docs to working order They have presently fallen into a state of code-rot due to no index.html file at the root of the /docs directory
The landing page is rather bare-bones at the moment, but it can be enhanced later once it is at least present.
Connects-to: #658
Change-type: patch
Signed-off-by: Maximilien McDermott<EMAIL_ADDRESS>

Resolved with #655, thanks for your contribution @MaximUltimatum


Get changes on Messages.

function to get changes from messages and mark them in the static file.

This is difficult to do automatically. You can pass an older message ID in -from-id and the program will resync any changes.


chore: release 1.0.0-rc.6

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 68.245%

Files with Coverage Reduction
New Missed Lines
%

common/src/tap/checks/deny_list_check.rs
1
98.21%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.02%

Covered Lines:
4208

Relevant Lines:
6166

💛  - Coveralls


maximumSelectionLength not enforced with closeOnSelect: false

While I'd normally be more thorough with your reporting format, this one is pretty self-explanatory.
$('.select2').select2({
    	closeOnSelect: false,
    	maximumSelectionLength: 4
});

When closeOnSelect is false, the users have free reign to select as many options as they want. closeOnSelect: true solves the issue, but it's totally unintuitive.

This is a duplicate of https://github.com/select2/select2/issues/3514.


Create Per Diem and Create Payment changes

Currently, these screens are confused and confusing. On the per diems screen, we have meal days and lodging days, but not the corresponding rate fields. On both screens, there are payment fields, but no event to tie them to,

One approach is to remove the payment fields, and make these screens strictly for creating monetary adjustments disconnected from specific events.
Another approach is to add an Event ID field,  and look up the events and/or per diem data for the event, which must be tied to both the event id and the cadre id.
The first approach seems a little limited; seems like you might want to tie an adjustment to the event that the adjustment needed to be made for.
The second approach seems like it leads towards confusion; there is little apparent difference between the automatically generated invoices and ones you could create manually.
With the second approach, you'd definitely want to make the Reason field required.

Stored Procs:
For second approach:
Cadre.PerDiemInsert
Event.GetEventPerDiem


can I mask in price format ?

Hello my frind , nice code !  congratulation .
can I mask in price format ? like this
I type this -
7000020

and do it -
70.000,20

Hi @murilolivorato , we do not support money format since its a reversive typing.
I have tested:
http://www.giphy.com/gifs/l1KVatI3cl4vZlbNK
This is a good feature, I will add this to our backlog, okay?

@murilolivorato I will make a release this week with money mask support.

https://moip.github.io/awesome-examples/
Money support added on 0.5.0
https://github.com/moip/awesome-mask/releases/tag/0.5.0

Hi @iCaio, this feature is not working. I can't type any value, the field only show "money" as value.

Here is my package.json:
"dependencies": {
"awesome-mask": "^0.5.0",
"jquery": "^3.2.1",
"vue": "^2.2.1",
"vue-gmaps": "^0.2.1",
"vue-multiselect": "^2.0.0-beta.15",
"vue-router": "^2.3.0",
"vue-style-loader": "^2.0.4",
"vuejs-datepicker": "^0.6.5",
"vuelidate": "^0.4.2",
"vuex": "^2.2.1"
},

https://github.com/moip/awesome-examples
Can you please try this project? Can you reproduce the problem with a gist? @marcusvbp

I am fixing it @marcusvbp

Can you please test the version 0.5.1?

@iCaio I will! thanks.

It worked, but I have noticied the variable bind has a different value from the field. Look at the screenshot:

Hi @marcusvbp , can you try version 0.5.2?

I have tried but no success:

@iCaio it worked in my project, after server restart.
Thanks!


Fix links when the module is disabled

In 1.7.6.x when you disable ps_mbo, the following menu items are still using the ps_mbo's links:

Module Catalog
Module Selections
Themes Catalog

In 1.7.7.x the behavior is a bit different as it's not using ps_mbo's ones but Themes Catalog disapears, Module Catalog link is wrong and so Module Selections is not accessible.
This PR should fixes https://github.com/PrestaShop/PrestaShop/issues/21588
How to test
Disable ps_mbo & check that Module Catalog, Module Selections & Themes Catalog are still present and that their links are core's ones, not ps_mbo's.

Thanks @atomiix , links are now OK ! QA :heavy_check_mark:


Adds the oauth signup url as an option

Adds support for the oauth_signup_url via the bldr.env.sample file.
I wasn't sure how to handle the other auth providers (azure-ad, okta, chef-automate) as users are managed at a different level then a straight forward signup, hence there are no examples in the bldr.env.sample.
Thinking how I would set this link if I were using one of the missing providers (azure-ad, okta, chef-automate) I would likely suggest a link to some type of on-boarding documentation.
Signed-off-by: skylerto<EMAIL_ADDRESS>

Ah nice, this is literally the work I started yesterday :) I'm :+1: to merging this, but to clarify - this doesn't yet resolve #131 because the plumbing in builder isn't there. I'll put my PR for builder up in a moment when i'm not on thumbs.

Fair enough, I removed the resolution! And sorry if I was stepping on toes! :(

I'd hold off on merging this till we have a complete solution

Not at all @skylerto! Love that you hopped on it!!!

@skylerto Pls see my comment above


The "Reset" button on the filter tab does not actually reset the filter rate

Describe the bug
Pushing the Reset button on the filter tab resets the numerical values, but does not reset the following:
Max Rate, Min Rate, Mode, and Highest-Only
This would be a very minor bug on its own, save for the fact that right-clicking does not work on MacOS within Etterna right now, making it impossible to lower a rate value once increased without restarting the game.
To Reproduce
Steps to reproduce the behavior:
Increase the Max Rate or Min Rate on the filter tab.
Press the Reset button.
Expected behavior
All filter values should be reset, or at a minimum, the skillset range values and the rate range values.
Desktop (please complete the following information):

OS: MacOS Mojave
Version 70.2

I think this is the lua code that handles that button click:
https://github.com/etternagame/etterna/blob/develop/Themes/Til Death/BGAnimations/ScreenSelectMusic decorations/filters.lua#L458-L472
ResetSSFilters calls into this: https://github.com/etternagame/etterna/blob/57c8961b5f12dacad4015f4b026865d7c7f38d1e/src/Etterna/Singletons/FilterManager.cpp#L51-L59
I'm not very familiar with the filter code so I'm not sure what the exact or best fix is but these links should give some direction to anyone looking to fix this (There seems to be a FILTERMAN:SetMaxFilterRate and SetMinFilterRate, maybe we need to use those to reset them)

f12ce12f2875615d21c3651302f0412cf83cf7ac


mqtt client disconnected every 120s

Describe the bug
Hi and thank you for your work.
I use ecowitt2mqtt to publish ecowitt gw1100 gateway to mosquitto mqtt server, and all data are used in home assistant.
Every 120s, status becomes offline and all home assistant values are set to undefined.
At same time, no error in ecowitt2mqtt logs but a timeout message is present in mosquitto logs :
Client 7eNrAgfZ1UqcEud4S0w31x has exceeded timeout, disconnecting.
I try some config in mosquitto and ecowitt2mqtt without success. Your help to solve my issue would be appreciated.
Thank you
Screenshots

Additional context
Ecowitt version : GW1100A_V2.0.4
Mosquitto version : docker eclipse-mosquitto 2.0.15
ecowitt2mqtt version : docker bachya/ecowitt2mqtt 2022.12.0
ecowitt gw1100 config:

protocol: ecowitt
upload interval: 15s

mosquitto config :

per_listener_settings false
listener 1883
allow_anonymous true
persistence true
persistence_location /mosquitto/data
autosave_interval 600
include_dir /mosquitto/configinc

ecowitt2mqtt config:

hass_discovery: true
mqtt_broker: mosquitto
mqtt_retain: true
output_unit_system: metric
output_unit_speed: km/h

How frequently are you publishing data to ecowitt2mqtt?

Ecowitt gateway push data to ecowitt2mqtt every 15s

Ah, I see you included that in your original post—thank you for the confirmation.
I cannot reproduce this on my MQTT broker (EMQX), so I assume it has something to do with Mosquitto. Unfortunately, I can't provide direct support on Mosquitto itself. You might consider seeing if any of Mosquitto's configuration options can help; in particular, I would look at:

max_keepalive
keepalive_interval

I don't know if this helps, but I was experiencing something similar when I changed my router...and my new router mashed two devices on the same IP address, and they were having an IP address conflict. The result was what you were experiencing. I rebooted my router and it properly re-assigned the IP address again as they came back alive and the issues was gone.
Not sure if this your problem, but check for IP address conflicts...its  simple fix that it is the problem.

Thank you so much for help. Unfortunately, this is not a IP address conflict because this is 2 kubernetes pod (ecowitt2mqtt and mosquitto) on same cluster.
I will try some configurations and if i don't solve this, i will open an issue in mosquitto project.


Fix what information is shown about user in API.

KeepEmailPrivate shall only affect if email is returned, currently authed information is shown.

Codecov Report

Merging #9115 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #9115      +/-   ##
=========================================
- Coverage   41.11%   41.1%   -0.02%
=========================================
  Files         547     547
  Lines       71614   71612       -2
=========================================
- Hits        29447   29439       -8
- Misses      38442   38449       +7
+ Partials     3725    3724       -1

Impacted Files
Coverage Δ

modules/convert/convert.go
79.03% <100%> (-0.17%)
:arrow_down:

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

modules/process/manager.go
74.32% <0%> (-4.06%)
:arrow_down:

routers/repo/view.go
38.59% <0%> (-0.88%)
:arrow_down:

modules/avatar/avatar.go
54% <0%> (+6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0aaffe...775676d. Read the comment docs.


refactor: move module query-methods into collection-decorator

Description
As we discussed on #868, it makes sense to move this module into CollectionDecorator since it depends upon decorator_class and context.

@brunohkbx can you please rebase your branch on master ? Thank you !

@brunohkbx can you please rebase your branch on master ? Thank you !

@n-rodriguez sure thing! I totally forgot this PR, sorry.

I think I'll have time to review this soon.
Meanwhile, @brunohkbx, could you please resolve the conflicts?


[TTNN Dialect] Convert ttnn.to_memory_config from DPS to non-DPS op

ttnn.to_memory_config was implemented as a DPS op in TTNN dialect. However, actual ttnn implementation doesn't support this type of signature
Fixed stale docs
Opened #435 to follow up

Hey @svuckovicTT as a sanity test, can you run
export SYSTEM_DESC_PATH=path/to/system/desc
llvm-lit -v test/ttmlir/Silicon
ttrt run build/test/ttmlir/Silicon

and make sure the outputs are correct?

Hey @svuckovicTT as a sanity test, can you run
export SYSTEM_DESC_PATH=path/to/system/desc
llvm-lit -v test/ttmlir/Silicon
ttrt run build/test/ttmlir/Silicon

and make sure the outputs are correct?

Hey @jnie, I tried running
ttrt query --save-artifacts
export SYSTEM_DESC_PATH=system_desc_folder=/localdev/svuckovic/_workspace/repos/tt-mlir/ttrt-artifacts
llvm-lit -v test/ttmlir/Silicon

but I'm getting
llvm-lit: /opt/ttmlir-toolchain/venv/lib/python3.10/site-packages/lit/TestingConfig.py:152: fatal: unable to parse config file '/localdev/svuckovic/_workspace/repos/tt-mlir/test/lit.cfg.py', traceback: Traceback (most recent call last):
  File "/opt/ttmlir-toolchain/venv/lib/python3.10/site-packages/lit/TestingConfig.py", line 140, in load_from_path
    exec(compile(data, path, "exec"), cfg_globals, None)
  File "/localdev/svuckovic/_workspace/repos/tt-mlir/test/lit.cfg.py", line 25, in <module>
    config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
AttributeError: 'NoneType' object has no attribute 'use_lit_shell'

on the last command... Have you seen this before?
On another note, can we add this check in CI? Is there an issue to track this?


[FLINK-4011] Keep UserCodeClassLoader in archived ExecutionGraphs

Currently, completed jobs cannot be accessed in the web frontend, because the classloader passed to SerializedValue is always null.
There are different approaches to resolve this issue:

Use the system classloader to deserialize the EC. This means that as soon as the EC contains user code, we can not deserialize it. The web frontent will show fewer information
In ExecutionGraph.prepareForArchiving(), we deserialize the EC into a special field, then we set the user code classloader free for GCing. This would be a hacky approach because we would have two ECs (serialized, regular instance) in the EG.
Keep the usercodeclassloader in the EC. This means the classes of the job can not be unloaded from the JobManager JVM until the job has been removed from the JM history.

I'm open for discussing more approaches or alternative solutions.

You already outlined one of the drawbacks (holding on to the classes).
There are probably other parts in the execution graph that currently hold onto user defined classes as well.
A good (but more involved) longer term solution would be to create a "archived execution graph" that can be serialized and that does not contain any user classes, but only "stringified" versions of configs, accumulators, metrics, etc.

Given the current status, this is a good pragmatic fif.
+1

Thank you for the review. I'll merge it


Additional custom step functions

Hi, a big thanks for this gem.
I just watched your talk from RubyConf 2021 and came to your github profile looking to see if you had shared any of the custom step functions you talked about.
Boy was I lucky that this gem has just been created a month ago.
I understand that this gem is very new, but I was just wondering if you were intending to add async and authorize step functions in future. I saw that you had implemented them previously in a gist
I also note the README does also provide an example of how you might use validation before running async jobs, is this your preferred approach now, rather than using a custom step function?
Anyway, if adding these is not part of your future plans and you have no objection to them being included, I wondered if I might try adding them in a PR?
Cheers, Dylan

Hi @dylan-hoefsloot! Thanks for the kind words.
I want to add the async step to this gem, but the implementation I used at my day job was heavily dependent upon Rails and ActiveJob specifics, and I didn't want this gem to be Rails-specific. Also, in our implementation most of the code was in the app, in a base ApplicationTransaction and a specific TransactionJob, very little belonged to the async step adapter. In fact, its almost identical to the use step, replacing the txn.call(*args) with TransactionJob.perform_later(txn.class.name, *args).
I'm still noodling on how to best accomplish this within the gem, but if you want more specifics I'd be happy to whip up an example in a Gist or something.

Hi @paul, thanks for the reply.
That makes perfect sense, I've also realised the authorize step is pretty easy to accomplish without a custom step function.
check :authorized?

def authorized?(resource:, user:)
  Pundit.policy(user, resource).manage?
end


adds/fixes nested HAVING statements

This PR fixes nested HAVING statements
I ran the npm run dev command but it updated more files than I expected it too. Is this expected?

Is there a way I can run the build process on just the files I've changed? There seems to be quite a bit of stuff getting reverted in this PR.

Hi @cleathers, I made a mistake merging #896. I'm not sure what else is being overridden, but just write the change as you intend and I'll merge it after master has been corrected.

Sounds good @rhys-vdw. Thanks for your work on the library, it's a pretty awesome tool :)

Hi, I started going through old pull requests and get them merged if possible or close otherwise if they are not going to be finished.
@cleathers  Nice feature, thanks for this pull request. To be able to merge this, there were some strange indentation which needs to be fixed and documentation of the feature should be added / updated to index.html.

Closing abandoned pull request and moved to issues for now https://github.com/tgriesser/knex/issues/1282


support custom config file path with cli

Operating System: MacOS
Node Version: 8.11.3
NPM Version: 6.2.0
webpack Version: 4.16.5
webpack-serve Version: 2.0.2

Feature Proposal
Support custom serve config file path
Feature Use Case
right now webpack-serve use the default search pattern to find the config file via cosmiconfig, so I have to put the config file in the root of my project or it won't find it, or I have to put in the webpack.config.js's serve section, yes we can require the custom serve config file to assign, but can we make it more nature to achieve that, thanks
the existing problem is that we use --config as the webpack config path

I think share the dirname with webpack.config.js is a bit confusing as we have to explain another search strategy, I'd prefer a new flag to do it, like --entry
I think we can just remove the support of config alias for webpack config, that means:
webpack-serve ./serve.config.js should respect serve config only, if you want to specific the webpack config, you have to explicitly provide it webpack-serve --config ./webpack.config.js, in this way we are actually mapping the cli options strictly.
BTW, I also find that we don't support open-path from config file, that would be a problem if I want open a custom url instead of the provided host:port in the config, should I create another issue for that?

BTW, I also find that we don't support open-path from config file, that would be a problem if I want open a custom url instead of the provided host:port in the config, should I create another issue for that?
Right now I have to use the event hook to open manually.

@michael-ciniawsky What about my proposal? consume the bare config path from cli as webpack-serve's config, if you want to specific the config for webpack, use --config explicitly, if you think it's legitimate, I'd love to send a PR to do that

What about my proposal?
Added to the notes already :). Hmm... better to hold off with a PR for now, since I can't guarantee you anything atm 😛

DEPRECATED. Please use webpack-dev-server (he is in support and update mode again). Feel free to create a issue if some features are not implemented in webpack-dev-server.
Why deprecated webpack-serve ?

The author stopped developing the package.
Two development servers are misleading for developers.
Hard to maintain two packages with same purpose.
Some dependencies are not available to fixes/implement new features/etc (https://www.npmjs.com/package/webpack-hot-client and https://github.com/shellscape/koa-static) and there's nothing we can do here.
webpack-dev-server is stable.

Thanks for using webpack! We apologize for the inconvenience. In the future, we will avoid such situations.


python310Packages.webcolors: 1.11.1 -> 1.12

Description of changes
https://webcolors.readthedocs.io/en/1.12/changelog.html#version-1-12-released-2022-05-25

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 174814 run on x86_64-linux 1

2 packages failed to build:

python310Packages.bravado-core
python39Packages.bravado-core

26 packages built:

actdiag (python39Packages.actdiag)
asciidoc-full-with-plugins
blockdiag (python39Packages.blockdiag)
home-assistant-component-tests.flux_led
nwdiag (python39Packages.nwdiag)
powerdns-admin
python310Packages.actdiag
python310Packages.blockdiag
python310Packages.flux-led
python310Packages.nwdiag
python310Packages.seqdiag
python310Packages.sphinxcontrib-actdiag
python310Packages.sphinxcontrib-blockdiag
python310Packages.sphinxcontrib-nwdiag
python310Packages.sphinxcontrib-seqdiag
python310Packages.tikzplotlib
python310Packages.webcolors
python39Packages.flux-led
seqdiag (python39Packages.seqdiag)
python39Packages.sphinxcontrib-actdiag
python39Packages.sphinxcontrib-blockdiag
python39Packages.sphinxcontrib-nwdiag
python39Packages.sphinxcontrib-seqdiag
python39Packages.tikzplotlib
python39Packages.webcolors
weechatScripts.weechat-matrix

bravado-core failure will be fixed with #174952


filtering large result sets only finds subjects

If the user attempts to view an item with a large number of observations, only the first 100 are returned from the server.  The remainder can however be "filtered" by entering a search term in a special text field.  This will return the reduced result set to the browser. We noted that this filtering seems to only find terms that are "subjects".  One might assume that it would instead be doing a full text search on the observations.
We would like to (1) investigate what the intended action was, and (2) see if full text search is feasible with the current design if it was not initially included in (1).
One can investigate this by e.g. browsing on the vaccine Zostavax, which has 1664 observations, or any other subject with a large number of observations.

Another test case:
Go to http://hipc-dashboard.org/#vaccine/vo-0000046/vaccine. We can see "Only 100 of 5454 observations are listed...". If we filter by "mononuclear" (a word in subject), it reports "The number after filtering is 3517."; if we filter by "frequency" (a word in the context text), it reports "The number after filtering is 39."; if we filter by "adults" (a word in evidence), it reports "The number after filtering is 0." - not working!

This is a bug. The filtering is supposed to use the full text of the observation summary, regardless of whether it is subject, evidence, or the context sentences.

Browsed for Zostavax, then filtered for evidence terms like "young adults" (parantheses not needed) and "180".  The filter quickly returned observations with the entered terms.  Seems to be working fine.


Support object literal shorthand in ProcessEs6Modules.

Fixes #1636.

This change is

Hm, I thought I'd already merged this. Anyway I can probably get it in today.

@MatrixFrog The that was merged was about ProcessCommonJSModules. This is in ProcessEs6Modules.

committed internally, will be MOE pushed soon.


⚠ Rumah123 has degraded performance

In e53c880, Rumah123 (https://www.rumah123.com) experienced degraded performance:

HTTP code: 200
Response time: 14105 ms

Resolved: Rumah123 performance has improved in f1284b7 after 1 hour, 4 minutes.


Use Android Gradle Plugin 1.5.0

Closing, since this was already bumped here: https://github.com/android10/Android-CleanArchitecture/commit/13bf519eb434c49a848374ee49dfee8c80ad0ce5
Thanks for the collaboration.


gh-2422 FederatedStore ChangeGraphId & ChangeGraphAccess update cache…

… + Test
Related Issue

Resolve #2422

Codecov Report

Merging #2424 (8467703) into develop (8a2d802) will decrease coverage by 2.86%.
The diff coverage is 2.94%.

@@              Coverage Diff              @@
##             develop    #2424      +/-   ##
=============================================
- Coverage      66.14%   63.28%   -2.87%
+ Complexity      2169     2156      -13
=============================================
  Files            908      532     -376
  Lines          30952    16859   -14093
  Branches        3801     2072    -1729
=============================================
- Hits           20474    10669    -9805
+ Misses          8861     5220    -3641
+ Partials        1617      970     -647

Impacted Files
Coverage Δ
Complexity Δ

...affer/store/operation/handler/GetWalksHandler.java
5.55% <0.00%> (-0.95%)
0.00 <0.00> (ø)

...va/uk/gov/gchq/gaffer/operation/impl/GetWalks.java
65.42% <10.00%> (-5.72%)
30.00 <1.00> (+1.00)
:arrow_down:

...onutil/iterable/LimitedInMemorySortedIterable.java
47.22% <0.00%> (-2.78%)
15.00% <0.00%> (-1.00%)

...ore/operation/handler/utilities/SortFullGroup.java

.../spark/operation/scalardd/ImportRDDOfElements.java

...r/scalardd/SplitStoreFromRDDOfElementsHandler.java

...er/spark/serialisation/TypeReferenceSparkImpl.java

...handler/utilities/AggregateGafferRowsFunction.java

...peration/utils/scala/ElementConverterFunction.java

...er/spark/data/generator/RowToElementGenerator.java

... and 476 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efd840...8467703. Read the comment docs.

@GCHQDev404 Is this a breaking change? (Sorry, I have to ask this about every PR as you are doing gaffer 2 work)

closed due to gh-2435


Add KML options related note the upgrade notes

This is related to https://github.com/openlayers/ol3/pull/3568.

LGTM thanks for adding


jsonReader improvements

[x] Include geojson properties in the geojs feature data
[ ] Create one feature of each type whenever possible
[ ] Add on load events
[ ] Update map.fileReader to allow custom style functions

Edit: Moving the rest to a new issue.

@jbeezley are we waiting on something for this branch?

I was going to finish the other items on the list, but I didn't get to it last week.  This actually fixes a bug in the reader, so it is probably worth merging now.  I can add the rest in an issue.

great! thanks. LGTM :+1:


Validate that a valid version is specified when create a Config

Motivation:
We should validate that the version is valid that was used to create the Config object and if not fail.
Modifications:

Add validation for the version
Add some tests

Result:
Version is validated during config creation

The build failure is odd as I didn't change anything related to these files... @ghedo any idea ?

@normanmaurer most of the failures are because of the new Rust release, see https://github.com/cloudflare/quiche/pull/921, though the formatting lint failure is because of the changes in this PR https://github.com/cloudflare/quiche/pull/920/checks?check_run_id=2520952393 (need to run cargo +nightly fmt with latest Rust+rustfmt nightly to fix).

Will fix tomorrow

Am 06.05.2021 um 20:58 schrieb Alessandro Ghedini @.***>:

@normanmaurer most of the failures are because of the new Rust release, see #921, though the formatting lint failure is because of the changes in this PR https://github.com/cloudflare/quiche/pull/920/checks?check_run_id=2520952393 (need to run cargo +nightly fmt with latest Rust+rustfmt nightly to fix).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


XDEV hardlinks should be done at jail startup time

It's not ideal that if we fix a bug here that users need to recreate their jails. Just do this stuff at jail startup time.

Need #447 first


Registration returns low resolution results after update from version 1.0.0rc12 to 1.1.0

Hello,
I am encountering an issue after upgrading from version 1.0.0rc12 to 1.1.0. Previously, my registration process worked as expected with the following code:
registrar = registration.Valis(slide_src_dir, results_dir)
rigid_registrar, non_rigid_registrar, error_df = registrar.register()
registrar.register_micro(max_non_rigid_registration_dim_px=2000)
registrar.warp_and_save_slides(registered_slide_dst_dir, crop="overlap")

Since the update, using the same code, I now receive low-resolution results instead of the expected high resolution. When I separately attempt to open the respective slide file (.mrxs) using the following code:
reader_cls = slide_io.get_slide_reader(slide_src_f, series=series)
reader = reader_cls(slide_src_f, series=series, use_openslide=True)
reader.create_metadata
meta = reader.metadata.slide_dimensions

The meta.slide_dimensions only shows a single low-resolution value ([[616, 1436]]) instead of the significantly larger original slide dimensions. However, when I open the same file using OpenSlide directly, I can retrieve all of the existing dimensions as expected:
slide = openslide.OpenSlide(slide_src_f)
slide.level_dimensions

This returns: ((78753, 183759), ..., (615, 1435), (307, 717))
Could you please help me understand why the dimensions are read incorrectly after the update/where I am making a mistake? Any guidance or suggestions would be greatly appreciated.
Thank you!

Hi @iMauricee,
Thanks for bringing this to my attention. I'm not entirely sure what is happening here, but could you try to the following to see if vips is finding openslide?
    import pyvips # python wrapper for vips
    from valis import slide_io

    # Check if vips is using openslide
    vips_img = pyvips.Image.new_from_file(mrxs_f, autocrop=True) # `autocrop` crops to region around the tissue(s), instead of the entire slide, which is often mostly empty. Setting `autocrop=False` will read the entire slide
    print(vips_img) # Should print shape and type of highest resolution level

    # Check if valis is extracting the correct metadata
    valis_vips_slide_reader = slide_io.VipsSlideReader(mrxs_f)
    print(valis_vips_slide_reader.metadata.slide_dimensions)

When I run the above on a local mrxs file (circa 2016) with vips 8.15 and openslide 4.0, the print commands produce the following:
>>> print(vips_img)
<pyvips.Image 103072x202595 uchar, 4 bands, srgb>

>>>  print(valis_vips_slide_reader.metadata.slide_dimensions)
array([[103072, 202595],
       [ 51536, 101298],
       [ 25768,  50649],
       [ 12884,  25325],
       [  6442,  12662],
       [  3221,   6331],
       [  1610,   3165],
       [   805,   1583],
       [   403,    792],
       [   202,    396]])

Please try the above and let me know what you get.
Best,
-Chandler

Hey @cdgatenbee,
Thank you for your prompt response!
I ran the code with openslide 4.0 and vips 8.16 as well as 8.15 on my .mrxs file and both times received the following output:
Vips: <pyvips.Image 616x1436 uchar, 3 bands, srgb>
VipsSlideReader: [[ 616 1436]]
[[ 616 1436]]

Additionally, I tested loading an ome.tiff generated from a previous computation using the old version, as well as a standard .tiff. Both of these provided the expected results, consistent with your example.
Thanks you for your support.
Kind regards,
Moritz


Unable to load any skillmap activity in prod

When I try to start a skillmap activity, I see a double header and the editor fails to load.
Repro steps:

Go to https://arcade.makecode.com.
I was not signed in. You may want to ensure you're signed out to get the same repro.
Click "Beginner Skillmap". This will open https://arcade.makecode.com/--skillmap#beginner in a new tab.
In the skillmap, select an activity to start. I chose "Greeting Card".
Click the "Start" button to start the activity.
Notice that the editor fails to load, and the double header:

Additional notes:
Oddly enough, when I add the url parameter ?dbg=1, the activity loads successfully. Removing the parameter causes it to fail to load again.

Looks like it's inconsistent. It will load about half the time for me.


SpeechRecogntion types are missing in v4.4

lib Update Request
SpeechRecogntion was available in typescript v4.3 and not anymore in v4.4. Please, reintroduce it so that we can move from v4.3 to v4.4
Configuration Check
My compilation target is ES2016 and my lib is ['esnext', 'dom'].
Missing / Incorrect Definition
SpeechRecognition
Sample Code
const BrowserSpeechRecognition: SpeechRecognition =
  window.SpeechRecognition ||
  // @ts-expect-error fallback objects
  window.webkitSpeechRecognition ||
  // @ts-expect-error fallback objects
  window.mozSpeechRecognition ||
  // @ts-expect-error fallback objects
  window.msSpeechRecognition ||
  // @ts-expect-error fallback objects
  window.oSpeechRecognition

Property 'SpeechRecognition' doesn't exist on type 'Window & typeof globalThis'. ts(2339)
Documentation Link
SpeechRecognition

https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1029#issuecomment-908454034

For further reader, just install @types/web version 0.0.1 to solve the issue. Don't forget to remove 'dom' from the 'lib' array in your tsconfig as described in the Install process.

npm i @types/dom-speech-recognition -D provides typings for SpeechRecogntion


Extending Base.show to pretty print logger instances

#24

Thanks @pebeto for your patience with the review.


Revert "Remove Razor tooling projects"

This reverts commit 3cfa6c05263fba3c923022affb0a7cc8e3845ff5 (aspnet/AspNetCore#4411) which broke the build.
FYI @rynowak @NTaylorMullen

@natemcmaster ignore IISIntegration_* build failures in this. Those configurations do not consume changes from Hosting yet.


Add AM Solutions gentx

Hey, no I left chain id from previous getnx, gonna redo now
пт, 16 июн. 2023 г., 12:44 Tomasz Nowak @.***>:

@.**** commented on this pull request.
In mainnet-dryrun-2/gentx/am-solutions-gentx.json
https://github.com/archway-network/mainnet-dryrun/pull/62#discussion_r1232030341
:

@@ -0,0 +1,70 @@
+{

Validaton fails with
panic: signature verification failed; please verify account number (0) and chain-id (mainnet-dry-run-2): unauthorized
Was genesis.json replaced with unpacked
https://github.com/archway-network/mainnet-dryrun/blob/main/mainnet-dryrun-2/init_genesis.json.gz
before doing gentx?
Was proper --chain-id mainnet-dry-run-2 used doing gentx?
—
Reply to this email directly, view it on GitHub
https://github.com/archway-network/mainnet-dryrun/pull/62#pullrequestreview-1483112883,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU6WLXSYQCH24NCFGXWAXGDXLQTG5ANCNFSM6AAAAAAZI7Q2LQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


More test coverage, populate associations only if config setting is true

I was having a test fail, so I needed to add notNull constraint to image.user association. Also having include: [{all: true}] can lead to performance issues if there are many associations, so it now just does a simple check of the config settings. Ideally it should mimic the behaviour of sails' ActionUtil.populateEach', but this is a start.

Sequelize doesn't recognise 'include: [{all: false}]', so I withdrew my previous pull request.

Nice job, i'm really appreciate it


Channel close with timeout

Adds functionality to close a payment channel with the timeout branch of the EscrowTimeoutScriptPubKey. This pull request creates two Alegbraic Data Types for ChannelClosed. There are two ways we can close a Channel now, thus we have types to represent that. They are called ChanneClosedWithEscrow and ChannelClosedWithTimeout

Coverage increased (+0.2%) to 90.489% when pulling 8b559e9876e392c68be1ebcd687154ba0d82b057 on Christewart:channel_close_with_timeout into 78d6f04491a2f03e82bcd24287a286291129ab89 on bitcoin-s:master.

Coverage increased (+0.3%) to 90.531% when pulling 5e20fecd939e8b93199af0b83f0b1ae26aa2afb1 on Christewart:channel_close_with_timeout into 78d6f04491a2f03e82bcd24287a286291129ab89 on bitcoin-s:master.

Coverage increased (+0.4%) to 90.644% when pulling c6a16883d508d0dd85151bec0c85d5b8e5a5c781 on Christewart:channel_close_with_timeout into 78d6f04491a2f03e82bcd24287a286291129ab89 on bitcoin-s:master.


Support Terraform 0.12

It appears the provider doesn't work with Terraform 0.12.

Currently the pre-built binaries don't have 0.12 support. However, if you build from master, you should be able to use it with TF 0.12.
I'm working this week on getting an automated process for building and publishing the binaries. My aim is to cut a new release this week to

So I've published a new pre-release version v2.0.0-alpha1. You can get binaries from there that will support 0.12


AmazonS3Util.DoesS3BucketExist always return true

Hi:
I use AmazonS3Util.DoesS3BucketExist to check if the bucket is already created. I test with arbitery bucket names which are not exists and it always return true.
Looking in detail, I found when I use arbitery bucket name, the S3 service will return 403 forbidden, and in DoesS3BucketExist exception handling code path, it will retreat this status code as bucket "exist" .

And the HEAD request inside DoesS3BucketExist DO return successful response if the bucket name is exist, So I think it is not because anything related my pre-condition.

Actually I figure out myself:
The Bucket's name is global unique, the arbitery values I put in the DoesS3BucketExist are actually exist somewhere I cannot see. So that's why it returns 403 forbidden.
I think the meaning of DoesS3BucketExist is for you to check whether your bucket name is globally existed,  so it have the right behavior.
Currently it seems there're no APIs to support if I really want to check if the bucket is exist and visible to me, maybe you can implement one by change the exception handling a little.


Datarange by month

Is it possible to make datarange by month in DateTimePicker?

Sorry, it's not possible.


CPU info (architecture, processor) not collected on Mac

Implemented in https://github.com/simvue-io/client/pull/82


Create python-package-conda.yml

I've had problems with my ex and her boyfriend 🙃. I think she corrupted my original project and replaced my original version with some other stuff.
Are there any AI applications that can induce visual and auditory hallucinations or use radio wave platforms to help in the hacking of other devices?
Also, is there a program that can manipulate the predictive text keys to use as a form of communication?


quick fixes UI support

Sorry for the delay - will take a look tomorrow.

Some small changes. Can you:

merge this PR with master, and re-push it to here?
coordinate with @lukechurch re: the server change and landing this PR?

@devoncarew merged with master now
About the server, it seems that the quick fixes are already in the server. There is one issue though, that the hasFix bool of the dart-services is not really reliable. So sometimes a wrench fix is added, while there is no fix, or the other way around.

fix #260

@kasperpeulen

There is one issue though, that the hasFix bool of the dart-services is not really reliable.

For various scalability how to use a heuristic to compute this. The heuristic is conservative, so I'm not at all surprised that it is sometimes false when it should be true.
The opposite is more surprising. Please can you give me an example?

merging...

I see this with an unused import: https://dartpad.dartlang.org/459e0887f387ad463528

What I'm looking for is cases where the wrench appears but there isn't a quick fix available.

@devoncarew I found some bugs with the quick fixes, but all those bug doesn't appear if I run the master of dart-services locally. So I guess this will be solved very soon, as l heard lukechurch plans to update dart-services tonight.

OK, thanks for the update. This isn't deployed - and we don't plan to rev a new public version until ~next Wednesday, so I think we're good as is.


Make it possible to disable the linter

Sometimes the linter doesn't report coherent errors and you may disable it (or you just don't care about the style of your code)

+1


Replace full-width prompt header with a variable-width-with-max prompt header

The previous full-width prompt header looks really weird on wide screens, even a full-width laptop screen is enough to make it awkward. This PR replaces it with a variable-width prompt header with some heuristics for shortening the = bars and the title text as necessary.
Covered by existing tests, added some more thorough tests in PromptLoggerUtilTests.scala to exercise the edge cases in the new shortening heuristics

CC @lefou I think we discussed something like this before

I don't need the dashes at all. Also I accidentally thought some time ago that you changed to progress logger to have the seconds before the task name and I really liked it. Then I realized, I was looking at some evaluator command running anonymous tasks with with extra ticker output. Nevertheless, If we move the timing between the progress and the task name, we could end up with a condensed consistent output:
Before:
[15624/16847] ================================== __.compile ========================================== 14s
[15133] main.client.compile 3s
[15397] scalanativelib.worker-api.compile 1s
[15404] scalajslib.worker-api.compile 1s
[15612] kotlinlib.worker.test.resolvedIvyDeps
[15613] javascriptlib.test.resolvedIvyDeps
[15614] main.api.test.resolvedIvyDeps
[15615] contrib.versionfile.test.resolvedIvyDeps
[15616] contrib.sonatypecentral.test.resolvedIvyDeps
[15617] contrib.scoverage.worker2.test.resolvedIvyDeps
[15618] contrib.scoverage.api.test.resolvedIvyDeps
[15619] contrib.playlib.worker[3.0].test.resolvedIvyDeps
[15620] contrib.playlib.worker[2.9].test.resolvedIvyDeps
[15621] contrib.playlib.worker[2.8].test.resolvedIvyDeps
[15608] main.eval.test.resolvedIvyDeps
[15611] main.codesig.test.resolvedIvyDeps
[15173] contrib.testng.compile 2s

After (mocked):
[15624/16847]  14s  ==> __.compile
[15133]  3s  main.client.compile
[15397]  1s  scalanativelib.worker-api.compile
[15404]  1s  scalajslib.worker-api.compile
[15612]      kotlinlib.worker.test.resolvedIvyDeps
[15613]      javascriptlib.test.resolvedIvyDeps
[15614]      main.api.test.resolvedIvyDeps
[15615]      contrib.versionfile.test.resolvedIvyDeps
[15616]      contrib.sonatypecentral.test.resolvedIvyDeps
[15617]      contrib.scoverage.worker2.test.resolvedIvyDeps
[15618]      contrib.scoverage.api.test.resolvedIvyDeps
[15619]      contrib.playlib.worker[3.0].test.resolvedIvyDeps
[15620]      contrib.playlib.worker[2.9].test.resolvedIvyDeps
[15621]      contrib.playlib.worker[2.8].test.resolvedIvyDeps
[15608]      main.eval.test.resolvedIvyDeps
[15611]      main.codesig.test.resolvedIvyDeps
[15173]  2s  contrib.testng.compile

For me I need some kind of dashes, otherwise i find the lack of separation makes it visually hard to distinguish log lines from prompt lines.
The timing on the left thing is possible, but one issue is the timing string is variable width, from zero to four digits wide (to give an arbitrary upper limit). So either we would need to reserve a pretty wide gutter, or we would have un-aligned task selectors, or we would have task selectors moving left and right as the longest lived tasks complete. Might be possible to find a compromise but may need more thought

but one issue is the timing string is variable width, from zero to four digits wide

We could use a mm:ss format for the timing.


pnpm cache race condition when using different node versions between workflows

Description:
Same cache us being reused, regardless of node versions. This brings prolonged time for once of the operations, and cache race conditions.
As can be seen from the images attached below, same cache key is used for both, but once is using node14, while the other is using node16.
Action version:
actions/checkout@v3
Platform:

[x] Ubuntu
[ ] macOS
[ ] Windows

Runner type:

[x] Hosted
[ ] Self-hosted

Tools version:

Repro steps:
This is my Tests yaml
name: Tests

on:
  push:
    branches:
      - master
  pull_request:

jobs:
  exec:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0

      - uses: pnpm/action-setup@v2
        with:
          version: 7

      - name: Install Node.js
        uses: actions/setup-node@v3
        with:
          node-version: 14
          cache: "pnpm"

This is my Version yaml
name: Version

on:
  push:
    branches:
      - master

concurrency: ${{ github.workflow }}-${{ github.ref }}

jobs:
  version:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0

      - uses: pnpm/action-setup@v2
        with:
          version: 7

      - name: Install Node.js
        uses: actions/setup-node@v3
        with:
          node-version: 16
          cache: "pnpm"

Expected behaviour:
Node version is taken into account on the cache generation key.
Actual behaviour:
Same cache is being used, which leads to longer pnpm install steps, and cache race conditions.

Possibly related https://github.com/actions/setup-node/issues/286

Hello @allbetter-max , thank you for your input we started to investigate this issue

@dsame thank you, highly appreciated.
If you are able to provide an ETA or a workaround that would be great.

Hello @maximveksler, can you please give us your estimations of "prolonged time" and a sample of race condiitons.
From that we have now the time used for sharing the common cache is less then downloading 2 caches and having a common pnpm cache instead of per-project node_modules is exactly that pnpm is intended for.
If you have some issues specific use cases the https://github.com/actions/cache action should be used for fine turning.

@dsame please see reproduction and analay of the bug,
This repo contains
2 workflows

"Tests" which uses node version 14
"Version" which uses node version 16

1 app
Called apps/demo, which has 1 dependecy "hummus-recipe": "^2.0.1" which turn dependes on a pacakge called muhammara.
pnpm why muhammara
Legend: production dependency, optional only, dev only

<EMAIL_ADDRESS>/home/m/code/pr/CoreLess/apps/demo

dependencies:
hummus-recipe 2.0.1
└── muhammara 1.10.0

This dependecy is relevant for demoing the bug for reasons explained in the following section.
Bug Reproduction
In total 3 commits were performed into this repo:
6f80832
https://github.com/maximveksler/actions-setup-node-641/commit/6f808321ad870a65ab34d9f2fb4d49ef605669b9 is just the initial setup, and is irrelevant in this context.
9891f00
https://github.com/maximveksler/actions-setup-node-641/commit/9891f00496539ae6a796a3c2343dff66a748c831 which triggers the action's cache generation.
In this commit the 2 workflows have ran,
Tests which uses node version 14, it takes 15 sec to run.
This is bacuse muhammara 1.1.0 has precompiled build for node14 (as can be seen from the build logs
In addition it generated cahce key
Cache saved with the key: node-cache-Linux-pnpm-e586cd84c730ed875535ade63acd6a4c8d3b7de38c5670fe0c6c6b9e8636[1](https://github.com/maximveksler/actions-setup-node-641/actions/runs/3703277928/jobs/6274530259#step:9:1)b6d

Version which uses node version 16, it takes 2m 55s to run.
This is because muhammara 1.1.0 does not have a precompiled build for node16 (as can be seen from the build logs
.../node_modules/muhammara install: node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v93 ABI, glibc) (falling back to source compile with node-gyp)

So the job spends the 2:55 minutes no compliing the package.
In addition it tries to cache the generated pnpm cahce, but correctly fails (because such cahce key already exists, as it was generated by Tests)
Failed to save: Unable to reserve cache with key node-cache-Linux-pnpm-e586cd84c730ed875535ade63acd6a4c8d3b7de38c5670fe0c6c6b9e86361b6d, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/master, Key: node-cache-Linux-pnpm-e586cd84c730ed875535ade63acd6a4c8d3b7de38c5670fe0c6c6b9e86361b6d, Version: 578cf7a2de7d6b93a288818f024d6aa54ad870bb629c8ef7a6b5a4f1fb065d59

3b1dff9
https://github.com/maximveksler/actions-setup-node-641/commit/3b1dff9bd4f112aeba46f69de652cfb75835bd8d which attempts to use the cache key `` for both workflows.
In this commit the 2 workflows have ran again,
Tests which uses node version 14, it takes 13 sec to run.
It restore the cache key from the previous run, and pnpm uses it as expected:
Cache restored from key: node-cache-Linux-pnpm-e586cd84c730ed875535ade63acd6a4c8d3b7de38c5670fe0c6c6b9e86361b6d

Run pnpm install --aggregate-output --reporter append-only --frozen-lockfile
Scope: all 2 workspace projects
Lockfile is up to date, resolution step is skipped
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +142
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /home/runner/setup-pnpm/node_modules/.bin/store/v3
  Virtual store is at:             node_modules/.pnpm
Progress: resolved 142, reused 142, downloaded 0, added 142, done

Version which uses node version 16, it takes 3m 58s to run.
Here the cache is also restored, much like the in Tests workflow
Cache restored from key: node-cache-Linux-pnpm-e586cd84c730ed875535ade63acd6a4c8d3b7de38c5670fe0c6c6b9e86361b6d

However pnpm does not finds the complied muhammara and goes to recompile it again from scratch.
Root Cause
The bug is that it finds a cache to restore, however it's not the relevant cache because not all relevant variables are taken into account upon the cache token generation.
Therefor the pnpm install phase can't use the cached compile from the previous run, and needs to do the compilation again.
I belive that a simple solution would be to add to the hashed cahce token the version of the node version and the glibc version being used on the system. This would help prevent false positive of cache hits.

To prove that Version can be cached,
Please:

Delete the "Tests" workflow
Invalidate the cache
Run the "Version" once for cahce generation
Run the "Version" workflow a second time for cahce usage.

I won't be doing that in the repo, to not confuse the reader.

Hello @maximveksler , thanks a lot for your explanation, now i understand the race condition but it does not seem to me it directly  relates to the node version but rather it relates to the running workflows in parallel having the same lock file.
The node version plays the role only if the same lock file resolves to the binary packages that is not built, i agree.
To add the node version key seems to be a feature request, that need to be discussed so the ETA is up to a month or even it may be rejected.
Meanwhile i advise you to utilize the actions/cache that allows to set the custom cache.

Thank you.

Meanwhile i advise you to utilize the actions/cache that allows to set the custom cache.

Sure, I'll cache externally.  Are you able to suggest the best approach for caching a pnpm store as a workaround?

@maximveksler
This  step is proven to work. It is not perfect because of hard-coded cached folder path, but it can be temporary solution until the feature request is not implemented.
      - name: cache dependencies
        uses: actions/cache@v3
        with:
          path: '/home/runner/.local/share/pnpm'
          key: 'pnpm-deps'

What’s<PHONE_NUMBER>116
في ثلاثاء، 20 ديسمبر، 2022 في 4:14 ص، كتب Sergey Dolin <
@.***>:

@maximveksler https://github.com/maximveksler
This step is proven to work. It is not perfect because of hard-coded
cached folder path, but it can be temporary solution until the feature
request is not implemented.
  - name: cache dependencies
    uses<EMAIL_ADDRESS>    with:
      path: '/home/runner/.local/share/pnpm'
      key: 'pnpm-deps'

—
Reply to this email directly, view it on GitHub
https://github.com/actions/setup-node/issues/641#issuecomment-1358703610,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AULQUYMS7SYM54LCAA3FLTTWOEB73ANCNFSM6AAAAAAS5RTH7E
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This step is proven to work. It is not perfect because of hard-coded cached folder path, but it can be temporary solution until the feature request is not implemented.
      - name: cache dependencies
        uses: actions/cache@v3
        with:
          path: '/home/runner/.local/share/pnpm'
          key: 'pnpm-deps'

The following setup worked for me, as pnpm is being installed using pnpm/action-setup
      - uses: pnpm/action-setup@v2
        with:
          version: 7

      - name: Install Node.js
        uses: actions/setup-node@v3
        with:
          node-version: 16

      - name: pnpm cache
        uses: actions/cache@v3
        with:
          path: "/home/runner/setup-pnpm/node_modules/.bin/store/v3"
          key: "pnpm-deps-node16"

      - run: pnpm install --aggregate-output --reporter append-only --frozen-lockfile

Even better
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0

      - name: Install Node.js
        id: setup-node
        uses: actions/setup-node@v3
        with:
          node-version: 16

      - name: Setup pnpm
        uses: pnpm/action-setup@v2
        with:
          version: 7

      - id: pnpm-cache-path
        run: |
          echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT

      - name: pnpm cache
        uses: actions/cache@v3
        with:
          path: ${{ steps.pnpm-cache-path.outputs.STORE_PATH }}
          key: ${{ runner.os }}-${{ steps.setup-node.outputs.node-version }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
          restore-keys: |
            ${{ runner.os }}-${{ steps.setup-node.outputs.node-version }}-pnpm-store-

      - run: pnpm install --aggregate-output --reporter append-only --frozen-lockfile


build: Split out make part doing the copying of libraries from host

This file will get a bit more code later which handles the removing of
copied libraries, so split it out to avoid cluttering the already
messy stage1.mk.

LGTM


Feature #9527 - LDAP extended query on groups in RFC2307 containers.

[x] Redmine Issue: https://redmine.pfsense.org/issues/9527
[x] Ready for review

Adds the ability to abstract out a query on LDAP RFC2307 group containers, when the 'RFC 2307 Groups' checkbox is selected. It will walk though the Authentication containers as defined in system_authservers.php as per original code.

what testing needs to be done so we can get this in?

running fine on 6 of my pfsenses. whats keeping us from merging it ?

@loeken @jim-p mind me asking what values you guys used I'm trying this patch and haven't found any instructions on how to get it to work with RFC 2307 LDAP config.
Search Scope: Base DN: DC=example, DC=com
Authentication Containers: ou=users,dc=example,dc=com
User naming attribute: uid
Group naming attribute: cn
Group member attribute: memberUid
Group Object Class: posixGroup
Extended Query: &(objectClass=posixGroup)(cn=mygroup)(memberUid=*)
But apparently I am doing something wrong here.

The notable differences I have from a working config and yours shown are:
Search Scope: Entire Subtree
Base DN: DC=example, DC=com
Authentication containers: DC=example, DC=com
RFC 2307 Groups is ticked
I have users in the RootDN, not in a separate OU.
Where is your group OU ?
Authentication containers:
Semi-Colon separated. This will be prepended to the search base dn above
or the full container path can be specified containing a dc= component.
*Authentication Containers: dc=example,dc=com, ou=users,dc=example,dc=com,
ou=groups,dc=example,dc=com *            <-   maybe (untested) ?
The rest of the attributes look as per my working OpenLDAP setup.
This was part of the original issue I had, getting attributes from
different OU search paths.
On Thu, May 14, 2020 at 3:18 AM Eric Anderson<EMAIL_ADDRESS>wrote:

@loeken https://github.com/loeken @jim-p https://github.com/jim-p
mind me asking what values you guys used I'm trying this patch and haven't
found any instructions on how to get it to work with RFC 2307 LDAP config.
Search Scope: Base DN: DC=example, DC=com
Authentication Containers: ou=users,dc=example,dc=com
User naming attribute: uid
Group naming attribute: cn
Group member attribute: memberUid
Group Object Class: posixGroup
Extended Query: &(objectClass=posixGroup)(cn=mygroup)(memberUid=*)
But apparently I am doing something wrong here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pfsense/pfsense/pull/4067#issuecomment-628345074, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALUGWVS5B6DWBCX5QQH6FP3RRNIHBANCNFSM4HNMJZEQ
.

Of course was meant to be semi-colon separated, apologies:
*Authentication Containers: dc=example,dc=com; ou=users,dc=example,dc=com;
ou=groups,dc=example,dc=com  *
On Thu, May 14, 2020 at 10:27 AM Steve Powers<EMAIL_ADDRESS>wrote:

The notable differences I have from a working config and yours shown are:
Search Scope: Entire Subtree
Base DN: DC=example, DC=com
Authentication containers: DC=example, DC=com
RFC 2307 Groups is ticked
I have users in the RootDN, not in a separate OU.
Where is your group OU ?
Authentication containers:
Semi-Colon separated. This will be prepended to the search base dn above
or the full container path can be specified containing a dc= component.
*Authentication Containers: dc=example,dc=com, ou=users,dc=example,dc=com,
ou=groups,dc=example,dc=com *            <-   maybe (untested) ?
The rest of the attributes look as per my working OpenLDAP setup.
This was part of the original issue I had, getting attributes from
different OU search paths.
On Thu, May 14, 2020 at 3:18 AM Eric Anderson<EMAIL_ADDRESS>wrote:

@loeken https://github.com/loeken @jim-p https://github.com/jim-p
mind me asking what values you guys used I'm trying this patch and haven't
found any instructions on how to get it to work with RFC 2307 LDAP config.
Search Scope: Base DN: DC=example, DC=com
Authentication Containers: ou=users,dc=example,dc=com
User naming attribute: uid
Group naming attribute: cn
Group member attribute: memberUid
Group Object Class: posixGroup
Extended Query: &(objectClass=posixGroup)(cn=mygroup)(memberUid=*)
But apparently I am doing something wrong here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pfsense/pfsense/pull/4067#issuecomment-628345074,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALUGWVS5B6DWBCX5QQH6FP3RRNIHBANCNFSM4HNMJZEQ
.

+1


Remove measurements tab from product template

I don't think this is a good idea. There is no reason why we should depend on product variants just to remove it from view.
Sent from my iPhone

On 12-Aug-2015, at 11:43, priyankarani<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/fulfilio/product-variant-measurements/pull/1
Commit Summary
Remove measurements tab from product template
File Changes
M product.xml (5)
M tryton.cfg (1)
A view/template_form.xml (4)
Patch Links:
https://github.com/fulfilio/product-variant-measurements/pull/1.patch
https://github.com/fulfilio/product-variant-measurements/pull/1.diff
—
Reply to this email directly or view it on GitHub.


linux bridge, port vlan: raise not implemented error

When the port vlan feature is used, raise NmstateNotImplementedError.
Signed-off-by: Miguel Duarte Barroso<EMAIL_ADDRESS>

Coverage increased (+10.05%) to 79.929% when pulling 007c1c36f667832d14a938eee3171e354c047ea8 on maiqueb:port_vlan_not_implemented into afde385d6b06921a0073f04995542974a42e5bab on nmstate:master.


Please add function nullChainSyncWithBlocksPtcl

When initializing the OuroborosInitiatorApplication struct for the tx-submission webapi, I need a null function to provide to respond to ChainSyncWithBlocksPtcl. I am currently using this:
nullChainSyncWithBlocksPtcl :: Channel IO BSL.ByteString -> IO Void
nullChainSyncWithBlocksPtcl =
  const . forever $ threadDelay (1000 * 1000 * 1000)

#1318 will solve this.

#1318 will solve this.

So, that is not correct. #1318 will change the way you start applications/miniprotocols, but you'll still need something like nullChainSyncWithBlocksPtcl.

it's already there, it's called Ouroboros.Network.NodeToClient.chainSyncClientNull.

@erikd we can rename it to nullChainSyncClient if you think it sounds better.

That's assigned in #1333.


Build(deps-dev): Bump jest and @types/jest (#5287)

Pull request opened by the merge tool on behalf of #5287

Merged in 3c7eee6397df11c7e4e41fb038c6abd2f480b94c


Drastic drop in depth/color publishing rate

Hi,
After the kinect2_bridge is launched and point cloud is being displayed in rviz, the publishing rates for depth and color are about 29Hz. However after 2 minutes or so, it drastically drops to less than 5Hz and eventually less than 1Hz. Does anyone have any idea why this happens?
Thanks

Can you explain more about your setup?  Are you transmitting anything over WLAN?  Are both driver and rviz on the same computer? Do you see anything weird in 'dmesg'? Any errors or messages on the console where you launched the bridge?  Which ros version? Kernel version? Ubuntu version? all that info can help locate the problem.

Nothing over WLAN, just using the USB 3.0 to laptop. Yes just launching the bridge and rviz from terminal. I have not seen any errors or messages that look suspicious. Running ROS Indigo on Ubuntu 14.04.05, kernel 4.4.0-66-generic. Laptop specs: Intel i7, 8GB RAM, Nvidia GeForce GT 640M.
This seem to only occur when I am visualising a point or depth cloud, if I simply rostopic echo the kinect2 topics, it doesnt seem to drop. Also when the rate drops, my CPU usage spikes up to max.

Hi, upon checking the system log I find the messages being constantly output when the rate drops
xhci_hcd 0000:00:14.0: WARN Event TRB for slot 4 ep 8 with no TDs queued?
I believe my laptop's Intel USB 3.0 eXtensible Host Controller should allow Kinectv2 to run?

Hi.

When you have the problem, can you look at a cpu usage measuring tool, such as top or htop, and report which processes are using the most  CPU ?
The USB errors could also be related to too-high CPU load, as the driver does not manage to process all the data and some queues get filled up.
I have tried on a similarly spec'ed laptop (only with an intel graphics card) and don't suffer the problem you mention.


[CARBONDATA-2755][Complex DataType Enhancements] Compaction Complex Types (STRUCT AND ARRAY)

Cherry-Picked from PR  https://github.com/apache/carbondata/pull/2516
(1) Enabling Compaction with Complex DataTypes.
(2) Major Minor compaction will run over complex dataTypes.

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[x] Testing done
UT Added

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1643/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9903/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1854/

retest this please

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1888/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9936/

This PR supports compaction only for STRUCT and ARRAY. Please raise another jira and PR to support MAP type as well.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1685/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9945/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1897/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1693/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1696/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1906/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9956/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1699/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9959/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1909/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1731/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1942/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9991/


Add support for Ruby 2.6

Connecting work this ticket: https://github.com/sorbet/sorbet/pull/1512/files

Not really sure what needs to be done for this, and this was opened ages ago; i think we have some more specific tickets that track individual issues.


⚠ DDoS-Relay US-W-sfo3-02 has degraded performance

In 3faf63d, DDoS-Relay US-W-sfo3-02 (http://<IP_ADDRESS>:42069/;csv) experienced degraded performance:

HTTP code: 200
Response time: 148 ms

Resolved: DDoS-Relay US-W-sfo3-02 performance has improved in 1e95c13 after 12 minutes.


[PSA] New ComfyUI came out that broke stuff, will make an update to patch that shortly [November 26th]

Alrighty, update pushed. There is no visible error with the update, but there was a rename for something that might potentially break something if not updated. I also made the change backwards compatible.


Ensure object server IDs do not change

My actions before raising this issue

[X] Read/searched the docs
[X] Searched past issues

Following the discussion here: https://github.com/openvinotoolkit/cvat/issues/893#issuecomment-962644749
All object annotations in CVAT are apparently assigned a unique ID when saved to the server.
It was mentioned in the conversation linked above that it is possible that these server IDs get updated. The reasoning is that it is sometimes more efficient to delete an object and recreate it (thus assigning a new ID) rather than simply updating the existing object.
While this ID reassignment does not seem to raise any issues with operations within CVAT, it results in complications for outside workflows that want to connect with CVAT and maintain knowledge of the specific objects that were uploaded.
Expected Behaviour

The expected behavior would be that once a label/object is uploaded to the CVAT server and is assigned a server ID, that server ID will never be changed unless the user manually deletes the label/object.
Current Behaviour

At the moment, it is possible that the server ID of a label can be modified due to operations other than deletion.
Possible Solution

I am not familiar enough with the codebase to understand all of the operations that can result in the server ID of an existing label/object being modified. However, a solution to this problem should result in a guarantee that once a server ID is assigned, it will never be changed.
@nmanovic suggested that the bulk_update operation in Django could allow for efficient updating of objects without needing to delete them.
Steps to Reproduce (for bugs)
I have not been able to reliably reproduce this change in server ID myself, but the possibility of it occurring raises potential issues in the workflows described below.
Context
I am working on an open-source dataset curation and model analysis tool for computer vision called FiftyOne. This tool allows ML researchers and engineers to construct, visualize, explore, and most importantly, store all metadata related to an image or video dataset. Since CVAT is an awesome tool for annotation, I have been working on an integration between FiftyOne and CVAT which allows users to automatically upload data and labels from a FiftyOne dataset to CVAT for annotation/refinement, and then load the updated labels back into the FiftyOne dataset.
The issue of inconsistent server IDs comes into play when specific objects are being reannotated. Each object has a unique ID in FiftyOne that can be tied to the server ID it is assigned in CVAT. This allows us to track exactly which objects are added/modified/deleted and handle each of those three possibilities separately. The problem is that if the server ID is changed even though the object is not deleted, then when loading labels back into FiftyOne, it would seem that the object was deleted even though it was just modified, resulting in undesired behaviors.
This problem is not unique to my use case but would arise in any situation in which someone wants to upload existing objects to CVAT and know exactly which objects were added/modified/deleted.

Operating System and version (e.g. Linux, Windows, MacOS): Ubuntu 18.04
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
Logs from `cvat` container

Next steps
You may join our Gitter channel for community support.

@ehofesmann , thanks for the detailed explanation and context. Let's look into the issue one more bug. Let me treat the issue as a bug for now.


Can't connect to Aqara App

Hi!
How can I reverse change to be able to pair Camera back to Aqara App?
Camera works fine with HomeKit but I need to pair another Aqara Devices to the camera.
If I reset it to factory, it will connect to wifi just fine, but not to the Aqara App. What can I do? Can you please provide hostname file to reverse these changes? Or is there any other way to pair Aqara devices to camera?

Telnet into the camera and replace the mod files the saved originals.
eg:
cp /etc/tar_app.sh /etc/tar_app.sh_mod
cp /etc/tar_app.sh_save /etc/tar_app.sh
cp /etc/normal.xml /etc/normal.xml_mod
cp /etc/normal.xml_save /etc/normal.xml

Telnet into the camera and replace the mod files the saved originals. eg: cp /etc/tar_app.sh /etc/tar_app.sh_mod cp /etc/tar_app.sh_save /etc/tar_app.sh chmod 775 /etc/tar_app.sh
cp /etc/normal.xml /etc/normal.xml_mod cp /etc/normal.xml_save /etc/normal.xml
Once done just: reboot

This need to change in telnet or were?


Is it possible to test *.ts files with<EMAIL_ADDRESS>

This is just question, because I am not able to find any info about that.

Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions. Thank you :)

https://github.com/kulshekhar/ts-jest

@cpojer thanks for info.
I cannot use ts-jest because my node version is locked on 4.2.2 and ts-jest require at least<EMAIL_ADDRESS>

You can probably use an older version of ts-jest to go with your older version of jest.

@jwbay so obvious... Do not know why I did not figure it out before :) works for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>and extra piece of magic in config file :)