ActionMessageView width overflow

The ActionMessageView used to display favorite and bookmark notification doesn't take smaller devices (like iPod touch and iPhone SE) window width into consideration.
Here's how it looks on an iPod touch:

When compared with a larger device, like the iPhone 8 we can see that the previous behavior is not expected, since it's missing margins and the rounded corners.

Extra info:
App version: 7.63.8
Device model: iPhone SE or iPod Touch
iOS version: Tested on iOS 14, but it probably happens on others as well
Steps to reproduce the bug

Tap the 3 dots at the bottom right corner
Choose Favorite this page

Expected behavior
"Toast" message view appears with rounded corners and respecting margins
Actual behavior
"Toast" message view appears overflowing the device's width frame without any margin.
The same issue happens when removing the favorite or bookmarking a webpage.

Thanks for this, I'm testing it now.


When refreshing window of workspace workbench.colorCustomizations setting is gone

Issue Type: Bug

Have a workspace consisting of two projects
Have workbench.colorCustomizations present in your workspace settings config file
Reload VSCode window

Expected: Workspace settings retain its color configurations.
 The settings file for the workspace has this setting workbench.colorCustomizations  removed on every start of VSCode.

Same here

Can you try to reproduce this by disabling all extensions?

I investigated a little more.
In my case it was the Peacock-Extension.
See this issue.
It is already closed - I had to update my user settings.


[api-docs] chore: move non type specific interaction info to own section

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/f91d76275df736465012e78d3ed2cf5100f9022e

Irrelevant


Chapter 10 : PPR issues

In chapter 10, enabling PPR should look like this according the tutorial :

In my document, however, I have this :

Does it make a difference? Which one is the most recent one? Is it the reason why I have an error in my layout saying that "experimental_ppr is not a valid Next.js entry export value" ?

ull need to use next canary which is not offical release yet
Partial Prerendering Preview in Next.js Canary
Why This Error Occurred
In your next.config.js you enabled experimental.ppr but you are not using the latest Next.js canary. To ensure you are experimenting with the latest version, we currently require the use of a canary release. just comment for now and it should work
import type { NextConfig } from "next";
const nextConfig: NextConfig = {
/* config options here */
// experimental: {
//     ppr: "incremental",
// },
};
export default nextConfig;
\next.config.ts

Hi Mircea, Thanks for your answer!
I ended up commenting and skipping this part indeed. I also asked my superior about it, he said we probably will not use it at work anyway.
Your answer is the clearest I read on this issue. I am glad i asked!
Have a great day.

u will run in many issues as this tutorial is not very complete and also has erros.... lmk if u have more q.... as i had to do the hard work lol

I ran into this issue as well. Chapter 10 should be updated to say this.


Docker image maintenance

The ohm-website-web-1 Docker image needed a little coaxing to stop spewing not found errors.
I'm doing this partly from memory, but one gem and a number of image compression libraries were missing.
I had to
gem install mini_portile2 -v 2.8.4
apt-get update
apt-get install advancecomp
apt-get install pngcrush
apt-get install optipng
apt-get install pngquant
apt-get install jhead
apt-get install jpegoptim
apt-get install gifsicle

We should suppress documentation installation for ruby gems; this can be done with a .gemrc file containing
gem: --no-rdoc --no-ri

I still get warnings on startup
# rails console
/usr/lib/ruby/2.7.0/net/protocol.rb:66: warning: already initialized constant Net::ProtocRetryError
/var/lib/gems/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:68: warning: previous definition of ProtocRetryError was here
/usr/lib/ruby/2.7.0/net/protocol.rb:206: warning: already initialized constant Net::BufferedIO::BUFSIZE
/var/lib/gems/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:214: warning: previous definition of BUFSIZE was here
/usr/lib/ruby/2.7.0/net/protocol.rb:503: warning: already initialized constant Net::NetPrivate::Socket
/var/lib/gems/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:541: warning: previous definition of Socket was here
warning: parser/current is loading parser/ruby27, which recognizes 2.7.8-compliant syntax, but you are running 2.7.0.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
WARN: advpng none at /usr/bin/advpng (== none) is of unknown version
svgo worker: `svgo` not found; please provide proper binary or disable this worker (--no-svgo argument or `:svgo => false` through options)
Loading development environment (Rails <IP_ADDRESS>)
irb(main):001:0>

but it's an improvement.

Hmm, so maybe we'd need to update the Dockerfile to run those additional updates?
The one time we did an upstream PR to improve our Docker local dev experience, they did accept the change, so we could do something similar here -- figure out what needs to change to improve and then submit upstream.
hmm, we'd probably want to check against the latest upstream Dockerfile, https://github.com/openstreetmap/openstreetmap-website/blob/master/Dockerfile, to see if they've already resolved any of these issues

Closing this out with a few remarks.
I did open an upstream pull request on this issue but upstream was ahead of us and had created config/image_optim/development.yml which suppresses most of the messages this issue was about. With our upstream update this now works fine in dev.
Pushing to staging yesterday, however, revealed that the binaries were not available in that environment when they needed to be. That and other updates were incorporated into ohm-deploy's Dockerfile in the Chartpress flow.


Convert this to a GitHub template repo

I'd like to look into using this as a template for non-DIBBS related apps, making use of GitHub's template repository feature.
This is because it has a good system worked out for creating the OIDC provider, the GitHub Actions role, and the DynamoDB and S3 resources for state file management of the role and provider.
So I would deploy from this repo using deploy from template, then remove the application-related code and put in my application's resources.
I also think deploy from template would be a good workflow for agencies to make use of this application. It gives you a trace back to this repo in the copy (it says, like, "deployed from template "), while not being a fork, forks being more appropriate when people want to contribute back from the copy.

We're discussing this change. Thanks for the suggestion. I'll update you when we've decided how to proceed.


/hexcasting patterns giveAll is very borken

Whoops. Smells like the same problem as in #309.
This fix might also be the fix for #333, actually...

Whoops caused by the world having been generated before the #309 fix


New tag version ?

Would love to try the new quality config parameter (https://github.com/spatie/image-optimizer/pull/109) and if I'm not wrong it is not available in any tagged version.
Have you consider making it a parameter in https://github.com/spatie/image/blob/master/src/Image.php#L148 (and then spatie/laravel-medialibrary) as well ?

The PR is from long ago, I'm pretty sure we have tagged this package after that.
Didn't need that parameter myself so made no further integrations with medialib.

sorry to bother @freekmurze, but I think last tagged version is 1.2.1 : https://packagist.org/packages/spatie/image-optimizer
and I don't see the new config parameter here:
https://github.com/spatie/image-optimizer/blob/1.2.1/src/OptimizerChainFactory.php#L14
compared to master:
https://github.com/spatie/image-optimizer/blob/master/src/OptimizerChainFactory.php#L14

You're right! I'll create a new tag for this. Thanks for bringing this to my attention.

👍


If we made an Observable using RawQuery, will we not get updates/changes to the table?

RawQuery has two properties for that!

observesTables() specifies set of tables that should be observed to re-execute this raw query.
affectsTables() specifies set of tables that will be affected by execution of this raw query and will trigger update of queries which observe these tables.


Ensure that the updates published are on or before a specific date

Hi,
The documentation contains the following option:
"To ensure that the updates published are on or before a specific date, choose the date and selectAdd and Next."
This is a feature I desperately want to use, however I can't find it under update management center in the Azure portal.
For me it is critical to be able to test a bunch of updates in a pre-prod situation prior to freezing that list of updates before sending it to production systems. I don't want new (untested) updates to pop up in the meantime, so freezing the list of KBs at a specific date is essential.
Since this feature is mentioned in the documentation, but not in the portal I was wondering whether this functionality will be added or not, or even if I'm looking at the wrong place.
Thanks,
Robert

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a6eb66ae-0aed-108e-48c9-99ca04f64252
Version Independent ID: 54d58322-abfe-70c2-f54d-8a896baaa857
Content: Deploy updates and track results in update management center (preview).
Content Source: articles/update-center/deploy-updates.md
Service: update-management-center
GitHub Login: @SnehaSudhirG
Microsoft Alias: sudhirsneha

@robertvanvugt
Thanks for your feedback! We will investigate and update as appropriate.

@robertvanvugt
Thanks for your feedback! We have assigned the issue to author and will provide further updates.

@robertvanvugt - The information in the documentation is now explained clearly with a screenshot. Thank you for your feedback and apologies for the delay.

The updates are added as another task. Closing this issue.

#please-close


Sep-2023 PBI Desktop Release info is still not updated in this page

[Enter feedback here]
While the Oct-2023 PBI Desktop release has been announced on 11-Oct-2023, the Previous Monthly Updates to PBI Desktop & Service page is still having info only till Aug-2023 PBI Desktop release -- thereby no active link currently available to download the Sep-2023 PBI Desktop.
Please have this page updated with Sep-2023 & Oct-2023 PBI Desktop release details asap, so that we can refer this to download the Sep-2023 PBI Desktop installations.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 93f23670-d83a-dffc-c17a-8cef53d0de7b
Version Independent ID: 1b63f449-9fbd-3544-bee5-17c70fe55229
Content: Previous monthly updates to Power BI Desktop and the Power BI service - Power BI
Content Source: powerbi-docs/fundamentals/desktop-latest-update-archive.md
Service: powerbi
Sub-service: pbi-fundamentals
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @Sh5678. This issue has been assigned to the doc author for review.

Thanks for noticing, we've updated that page.


Move initial settings responsibility from Http2ConnectionHandler to H…

…ttp2ConnectionDecoder
Motivation:
Http2ConnectionEncoder currently accepts an initial Http2Settings object as part of the constructor. This is used during sending the preface, but it is not set internally until after the remote peer has acked the settings. This means our internal state could be out of sync with the settings we have sent until the peer has acked the settings. This may lead to the peer violating settings even when they should not. The local settings are currently managed by DefaultHttp2ConnectionDecoder, and Http2ConnectionDecoder already provides a method to get the current Http2Settings which collects the settings from all the different classes which maintain the actual state.
Modifications:

Http2ConnectionHandler no longer accepts a Http2Settings parameter in the constructor, and instead gets the settings from the Http2ConnectionDecoder
Http2HeadersDecoder#maxHeaderSize() exists to provide some bound when headers/continuation frames are being aggregated. However this is roughly the same as SETTINGS_MAX_HEADER_LIST_SIZE (besides the 32 byte octet for each header field) and can be used instead of attempting to keep the two independent values in sync.
Encoding headers now enforces SETTINGS_MAX_HEADER_LIST_SIZE at the octect level. Previously the header encoder compared the number of header key/value pairs against SETTINGS_MAX_HEADER_LIST_SIZE instead of the number of octets (plus 32 bytes overhead).
DefaultHttp2ConnectionDecoder#onData calls shouldIgnoreHeadersOrDataFrame but may swallow exceptions from this method. This means a STREAM_RST frame may not be sent when it should for an unknown stream and thus violate the RFC. The exception is no longer swallowed.

Result:
Initial settings sent are the same as our internal state, and no more duplication of state to limit header sizes.

@normanmaurer @buchgr @carl-mastrangelo @ejona86 @nmittler - PTAL.
Currently I am not making any effort to preserve "unlimited" settings [1]. For example SETTINGS_MAX_CONCURRENT_STREAMS and SETTINGS_MAX_HEADER_LIST_SIZE are assumed to be unlimited if they are never included in a settings frame. The h2spec treats the SETTINGS_MAX_HEADER_LIST_SIZE unlimited case special and doesn't run the Stream Concurrency test ... but is happy to try with Integer.MAX_VALUE. If we feel there is value in not including values for these fields until they are explicitly set it can be done, but I'm not sure if there is value in this.
[1] https://tools.ietf.org/html/rfc7540#section-6.5.2

@Scottmitch please fix compile error

@normanmaurer - fixed

@nmittler - Sure I can refactor if it makes it easier to digest, but I have a few questions.

Can you clarify what you had in mind when you say Refactoring without changing functionality? In my mind the "refactoring" you are talking about is moving the settings initialization from Http2ConnectionHandler to  DefaultHttp2ConnectionDecoder? I'm not sure how this change can be done without changing functionality.

The int -> long change for MAX_HEADER_LIST_SIZE also seems inline with this PR's purpose to fix how we handle max header list size, and type signatures of interfaces related to this PR needed to change to facilitate this so I prefer to keep this change together.

2b) when to apply settings - I'm also not sure how to best decouple this, or what value that would provide. When the settings are applied is the core of this PR, and seems related to what you are called refactoring in item 1. Does this change and the associated description in https://github.com/netty/netty/pull/5845#discussion_r80163725 just not make sense in general?

@Scottmitch ok fair enough ... let me take another pass.

@nmittler - I started down the approach described above in https://github.com/netty/netty/pull/5845#discussion_r81672322 however I still need to finish ... I will ping when ready.

@nmittler - PTAL

4.1 (540c26b)
Thanks for review @nmittler !

@Scottmitch @nmittler Sorry to pull up an old post, but I'm in an environment where often times things like netty upgrade faster than all the libraries which use them in a JVM.  This pull request seems to be causing java.lang.NoSuchMethodError: io.netty.handler.codec.http2.DefaultHttp2HeadersDecoder.(IIZI)V Because that particular constructor disappeared.  I'm using gRPC 1.0.1 and it looks like the un-released gRPC 1.1.0 has already fixed this, but does it make sense to put this constructor back into Netty as well?

@jhspaybar we consider the HTTP/2 codec in Netty as experimental so that we can rapidly iterate on its development. If you're using an older version of grpc, you may just want to use the version of Netty that it depended on to be safe.
We'll eventually solidify the API in HTTP/2, but until then you'll probably want to keep grpc up-to-date if you want to use a newer version of Netty.


Maximum Limits of the video Triming...

Hey, You are really awesome..i m using using your library in my project . but i am  stuck at one point.. my requirement is user must trim video maximum 40 seconds ..less than 40 secondswhat ever he want...i have upper bound but dont have lower bound... means maximum limit i have is 40 seconds ..i dont have any lower limits.can you give me solution ?
Thnx in Advance. @pikachu987

Thank you for using the library.
In 0.1.2 version, trimMaximumDuration Property was added.
🖐


Log booster_config with float parameters

@shnela @Raalsky is this relevant? I don't know the context, so it's hard to judge.

Is this still relevant @shnela @Raalsky ?


Using +page.server.ts generated types in components when accessing $page.data

Describe the problem
Accessing the parent page's load() through $page.data is great, but importing PageData from './$types.d.ts' is not possible, which I currently can only resolve through $page.data as { propertyUsedForComponent: propertyValue }. This obviously does not scale well.
Describe the proposed solution
Allow importing PageData types in components.
Alternatives considered
Passing all data in through export const propertyUsed: KnownType, which takes away the convenience of using the page store.
Importance
would make my life easier
Additional Information
No response

Could you clarify what the feature request is? You are talking about parent page's load, which you get through await parent(), not $page.data. Furthermore, it is possible to import PageData, you do import type { PageData } from './$types'

The import doesn't seem to work from a component, at least neither VS Code nor IntelliJ pick up the file - is there something else required to configure to make it work?

Where is you component located? The ./$types import only works if you are inside the folder where the +page.(server.)js where that load function is coming from lives. Else you have to do something like import type { PageData } from '.svelte-kit/types/...(path to your page)/$types. If this is too confusing to type, you could reexport the type from the folder where that page is like export type { PageData } from './$types' and do import type { PageData } from '..(path to that file)'

Yeah it's a shared component under "lib".
As of now, the intellij svelte plugin (my preferred ide) doesn't support the context="module" script parts, nor the imports from ".svelte-kit/types", so both suboptimal but usable in VS Code.
Is it common to keep (single-use) components under "routes" next to their pages? I'm not sure yet whether I find it more structured if they're all under the same directory..

I'd say yes - if you only use them on that page, put it inside the same route as that page. You have +page.svelte now, so you can easily distinguish that from regular components, and do not have to fear accidentally creating another route like with the old design.
Under the hood the ./$types thing works because in the generated tsconfig we tell TypeScript that there's a "type root" which means "if you look for the type of an import, do not only look into the files that are next to it on the file system, also look at this other location".

Under the hood the ./$types thing works because in the generated tsconfig we tell TypeScript that there's a "type root" which means "if you look for the type of an import, do not only look into the files that are next to it on the file system, also look at this other location".

This only works in .ts files with the IntelliJ plugin; in .svelte files I have to specify the full relative path from the project root for the type to be usable.
But since that's not related to the issue, I'm good with closing this. Thanks for the superb responsiveness!

Yeah it's a shared component under "lib". I might go with the re-export
method for now.
Is it common to keep (single-use) components under "routes" next to their
pages? I'm not sure yet whether I find it more structured if they're all
under the same directory..
On Fri, Sep 2, 2022, 12:48 Simon H @.***> wrote:

Where is you component located? The ./$types import only works if you are
inside the folder where the +page.(server.)js where that load function is
coming from lives. Else you have to do something like import type {
PageData } from '.svelte-kit/types/...(path to your page)/$types. If this
is too confusing to type, you could reexport the type from the folder where
that page is like export type { PageData } from './$types' and do import
type { PageData } from '..(path to that file)'
—
Reply to this email directly, view it on GitHub
https://github.com/sveltejs/kit/issues/6528#issuecomment-1235351167, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJP3MYELTREHRVYGJIURV2DV4HLOJANCNFSM6AAAAAAQDEYOKU
.
You are receiving this because you authored the thread.Message ID:
@.***>


A valid generated fødselsnummer is not valid according to Nin.IsValid()

Creating a Nin with a valid fødselsnummer sometimes fail.
My most recent example, I tried to create a Nin with (the generated) fødselsnummer<PHONE_NUMBER>5 and it failed. Having checked, this is a valid fødselsnummer (the birth year could be 1854 for instance).

Thanks for testing and noticing!
When checking the century, I accidentaly tested the year with > 54 instead of >= 54.
Should be fixed now.

@njanor Are there any more failing cases you know about?

I've pushed a new nuget package with the 1854 bug fixed. Please open a new issue if you have any more examples of failing numbers.

Hi,
Sorry that I was unable to test it before you made a new NuGet-package.
However, I have updated it, and all validation errors which used to occur in my test are now gone.
Thank you :)


SetRowName didn't throw out of range when set row didn't exist

int main() {
  std::istringstream stream("a,b,c");
  rapidcsv::Document doc(stream, rapidcsv::LabelParams(0, 0));
  doc.SetRowName(0, "d");
  std::ostringstream oss;
  doc.Save(oss);
  std::cout << oss.str() << std::endl;
}

result:
a,b,c
d
if SetRowName didn't throw error, expected result shoud be:
a,b,c
d,,
Project has no example/test code tells how to dump data to a csv file, I misused API SetRowName like list code and fixed the error after reading the impl of SetRowName and noticed that there is an API called InsertRow >.< , SetCell throws exception when cell didn't exist, then why SetRowName didn't throw exception when row didn't exist?

Hi @lushengguo - this is actually the expected behavior for rapidcsv. It allows building/creating new documents by setting row/column labels outside current range - see #57 for more details. Other Set-functions in rapidcsv behave similarly. I will proceed to close this issue.


Using derived type with 2.9.0-next.3 yields 'CS1061' 'JsonElement does not contain a definition for Value'

Describe the bug
I upgraded from next-2 to next-3 and now I am receiving a build error
ModelMapper.g.cs(705,78): error CS1061: 'JsonElement' does not contain a definition for 'Value' and no accessible extension method 'Value' accepting a first argument of type 'JsonElement' could be found (are you missing a using directive or an assembly reference?)

It looks like the generated code is calling .Value twice:
// Generated code
        {
            var target = new global::SellerAmend()
            {
                Kind = source.Kind,
                SellerPartnerId = source.SellerPartnerId,
                SellerLoanId = source.SellerLoanId,
                DateCreated = source.DateCreated
            };
            if (source.ListingAmendment != null)
            {
                                                                   // .Value.Value should just be .Value
                target.ListingAmendmentValue = source.ListingAmendment.Value.Value.ToString();
            }

            return target;
        }

Haven't recreated it but I'm guessing because Amendment is a Nullable<JsonElement>, mapperly sees an object with a Value field and attempts to map?

@TimothyMakkison I think its because of the Value suffix and some special case with Mapperly?

@TimothyMakkison I think its because of the Value suffix and some special case with Mapperly for nullables?
If you rename AmendmentValue to AmendmentVal it compiles.

Yeah I've updated my comment with more speculation. I'm guessing it only affects nullable value types because its an actual type.
Does this not happen with V2?

@TimothyMakkison maybe it was just doing a throw new NotImplementedException on v2

It's strange this issue didn't crop up when field mapping was introduced. Iirc one of my nit pick optimizations changed how nullable types were checked, perhaps that broke it.

I don't think #555 caused it I've been using the following
[Fact]
public void VaueTest()
{
    var source = TestSourceBuilder.MapperWithBodyAndTypes(
        "partial B Map(A src);",
        "public record A(int? P);",
        "public record B { public int PValue { get; set; } }"
    );
    TestHelper
        .GenerateMapper(source)
        .Should()
        .HaveSingleMethodBody(
            """
            var target = new global::B();
            if (src.P != null)
            {
                target.PValue = src.P.Value.Value;
            }

            return target;
            """
        );
}

@TimothyMakkison The test you provided, which should reproduce the bug described by OP, fails on v2.8.0. So this probably exists since a longer time and isn't a regression of v2.9.0-next.3

The test passes when the bug occurs. Does this mean the bug doesn't happen with 2.8?

@TimothyMakkison sorry my bad, I adjusted the test to verify that the bug does not exist. If I use exact your version, it fails on v2.8.0 as well as on v2.9.0-next.3.
The problem is that the target property has a auto-flattened name of ending with Value. When resolving the name, autoflattening resolves it to P.Value (the value property of Nullable<T>). Then when building the mapping, the builder encounters a nullable value type and adds another .Value to access the value inside the null if condition. It relates to https://github.com/riok/mapperly/issues/572 as if Nullable<T> properties are treated as T, the problem shouldn't occur.

Name of this issue makes no sense anymore, should we close as duplicate?

I adjusted the title. I think this is a slightly different issue than https://github.com/riok/mapperly/issues/572. Here the name of the target property Value which matches the Value property of Nullable<T>, which is special cased, is a problem. While in #572 the problem is that the member resolution does take Nullable<T> into account, while the user certainly expects T. However, the solution could probably be the same.

Rel. https://github.com/riok/mapperly/issues/98


cnn shuffle not working.

Describe the bug
Image dataset shuffle does nothing.
To Reproduce

fit a cnn with imagedataset
predict it and shuffle it
The dataset is still the same

Expected behavior
Shuffled dataset, when shuffle
Screenshots (optional)
No response
Additional Context (optional)
No response

Do you mean the data from get_output and get_input? If so, this will be fixed with #771

:tada: This issue has been resolved in version 0.26.0 :tada:
The release is available on:

v0.26.0
GitHub release

Your semantic-release bot :package::rocket:


Back Button?

I think a back button would definitely be good to have as an option like the next button, just like shepherd has here: Shepherd.
This would only occur where tourtip-step != 0

:+1:


[BugFix]add input number check for array_concat

Signed-off-by: jerryjiang<EMAIL_ADDRESS>What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/StarRocksTest/issues/1767
Problem Summary(Required) ：
array_concat should have at least two inputs, so we check it in fe
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jerryjiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

[FE PR Coverage Check]
:heart_eyes: pass : 5 / 5 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
5
5
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 5 / 5 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
5
5
100.00%
[]

run starrocks_admit_test


net: buf: Take advantage of __must_check annotation

Update appropriate net_buf APIs with __must_check and update any misuse that was found in the tree.

There is still one place of "misuse" of net_buf_ref() in subsys/canbus/isotp/isotp.c which I hope @alexanderwachter  could help out with (since I can't completely understand this code): https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/canbus/isotp/isotp.c#L695-L715

Hmm, seems like doxygen doesn't like using this for function pointers:
29 Warning, treated as error:
30 /home/runner/work/zephyr/zephyr/doc/_build/src/reference/networking/net_buf.rst:139:Type must be either just a name or a typedef-like declaration.
31 If just a name:
32  Error in declarator or parameters
33  Invalid C declaration: Expected identifier in nested name, got keyword: struct [error at 6]
34    struct net_buf *__must_check(* net_buf_allocator_cb )(k_timeout_t timeout, void *user_data)
35    ------^
36 If typedef-like declaration:
37  Error in declarator or parameters
38  Invalid C declaration: Expected identifier in nested name. [error at 29]
39    struct net_buf *__must_check(* net_buf_allocator_cb )(k_timeout_t timeout, void *user_data)
40    -----------------------------^

Anyone have an idea if something can be done about that, or I should just forget about trying to use __must_check on function pointers?

@jhedberg You can add __must_check here https://github.com/zephyrproject-rtos/zephyr/blob/main/doc/zephyr.doxyfile.in#L2012

@jhedberg You can add __must_check here https://github.com/zephyrproject-rtos/zephyr/blob/main/doc/zephyr.doxyfile.in#L2012

@gmarull thanks a lot! I've added a corresponding patch to the PR now.

@jhedberg Looks like unrelated build failures? Maybe just rebase it?

@jhedberg Looks like unrelated build failures? Maybe just rebase it?

@joerchan no, that's exactly the remaining issue I mentioned in my comment https://github.com/zephyrproject-rtos/zephyr/pull/36370#issuecomment-863239058
@alexanderwachter had some proposal on Slack for how to fix this, which I didn't yet have a chance to look at.

@alexanderwachter had some proposal on Slack for how to fix this, which I didn't yet have a chance to look at.

Any updates on this?

No, sorry. Is someone else able to do a quick fix?

No, sorry. Is someone else able to do a quick fix?

Not sure, maybe @henrikbrixandersen ?

Please don't remove ISO-TP! We are using it and I have contributed to it in the past, but I was not aware of this issue.
@alexanderwachter do you remember the Slack discussions and can you post the details here?

Please don't remove ISO-TP! We are using it and I have contributed to it in the past, but I was not aware of this issue.

I doubt removing it would have happened - my primary intention was to get the attention of people interested in it (like yourself), which seems to have been successful 😉

@alexanderwachter do you remember the Slack discussions and can you post the details here?

I'll open an issue for this, describing my findings

I'll open an issue for this, describing my findings

Issue opened: #40070

Fix for isotp.c provided in #40162. This PR should be rebased as soon as the fix is merged.


Improve error handling around port in use, find new port

from Ed's original PR:
This pull request improves how we handle port in use errors.
Changes:

Check if the default port is in use. If free, start the app.
If port is in use, ask user if they want to change to a new port.

Reasoning for not changing to a new port by default:
Unless the user spots the issue, going to the browser doesn't help. Either way we need them to look at the terminal. This makes the issue more explicit - and may help them go about changing the default port for the prototype.

There's an issue with this PR - when you say "no" to the alternative port, the app tries to quit. However Nodemon is still running, you're not back at the terminal prompt.

I've raised an issue on the Nodemon repo asking how to cleanly exit. In the short term, I've added a message in the console output advising to quit using ctrl+c.
The better solution would be to check the port before doing grunt tasks. And only run grunt if the port is free. However the function as written works asynchronously, which means grunt starts up anyway. I'm not confident in would need to change to make it sync.
In the short term, I still think this PR as written benefits us and provides a clearer error for a common mistake that new users make.

Closing in favour of #130


Update overview-security-center.md

Changed the wordings from Send us your feedback to Watch this video to find out how you can trust us to read your feedback, as the video talks about what Microsoft accepts and uses the feedback and it is not a link to leave feedback.

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/5647

@JohanFreelancer9

@MSFTTracyP Please merge this Pr. Thanks.

@MSFTTracyP Gentle reminder

Need to close this PR because the original file was renamed or moved (merge conflicts).


Add support for client provided headers and cookies

Adds support for arbitrary headers and cookies provided to the client
Updated tests to validate the change.

Hello, this feature can be implemented in a shorter and more versatile way by adding a callback called OnRequest:
// called before every request
OnRequest func(*http.Request)

This allows to edit anything in the request and furthermore it allows selective editing by using any field of the existing request. This is already implemented inside gortsplib.
Therefore: if you remove Headers and Cookie and instead add OnRequest, this can be merged.

I have a lot of other changes like supporting compression and faster than presentation time downloading/decoding. If you're open to my code changes then I'll offer them but I'm not particularly interested in redoing the work to your spec. No offense just don't have much spare time

@sam-ulrich1 in all open source projects, improvements are welcome but they must provide a common benefits and adhere to standards. Every additional line of code is an additional maintenance burden. Additions to public APIs are particularly critical since once accepted they become part of the documentation and cannot be reverted unless a new breaking version is released.
This is hard for everyone, and that's the reason why there are small and big companies that are paying other open source projects for skipping this process and merging specific integrations, sometimes with their name on it, but personally i don't think this is the right approach, since the code becomes unmanageable.

Totally understand. Just don't have the time to do a rework for the sake of a merge

replaced by #163


Networking breaks when using cilium with strict kube-proxy replacement

Bug description
This issue is related to a thread I've started on istio's slack channel.
It affects inter-service telemetry, but it might impact other features as well, because traffic is not treated as http where it should be.
My setup is a kubernetes 1.18 cluster with cilium 1.8 configured with kubeProxyReplacement=strict. This means that the kube-proxy component from kubernetes is replaced and cilium handles its duties.
I'm not an expert in how cilium works, but this mode should improve service to service communication (and more networking) leveraging eBPF functionality.
I have noticed (using tcpdump) that when this mode is enabled, if from one pod I make requests to another service (eg. curl http://servicename.namespace), the connections are "magically" made directly to destination pod (pod-ip:target-port), rather then going through the ClusterIP of the destination service. I don't know the internals of how istio-proxy is configured or how metadata filter works, but this behaviour seem to make istio-proxy into thinking that requests go directly to the pod-ip:container-port, thus no route from istio config is matched, going through some default tcp path.
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[X] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Istio metadata headers to be added to requests even when using cilium's kube-proxy solution
Steps to reproduce the bug
To test this bug, I've installed kube-proxy and changed cilium's config to kubeProxyReplacement=partial and inter-service telemetry started to work, no changes to istio setup at all. Moreover, when inspecting traffic between pods using tcpdump, I was able to see some packages being sent to the ClusterIP of the destination service (this didn't happen previously).
Version (include the output of istioctl version --remote and kubectl version --short and helm version if you used Helm)
client version: 1.7.2
control plane version: 1.7.2
data plane version: 1.7.2 (1225 proxies)

How was Istio installed?
istioctl and istio-operator
Environment where bug was observed (cloud vendor, OS, etc)
aws, kops cluster
I am not able to share a config dump of my proxies, but this issue can be reproduced on any test cluster with cilium configured as described.

This essentially bypasses Istio load balancing. We do not support routing "direct to pod ip" traffic like they are doing

@howardjohn Thanks for the quick reply! It makes sense to be this way. Unfortunately I've lost a lot of time debugging this issue 😔 Maybe this info will be useful to other istio users that face similar issues or have similar setups.
I would suggest adding this information somewhere in istio's "getting started" or "setup" docs 😄

@StefanCenusa I think that makes sense. We should add the "direct to pod ip" to https://istio.io/latest/docs/ops/deployment/requirements/ and the cilium specific part  (not sure where). I wasn't aware that is what the cilium no kube-proxy mode did, so good to know

Regarding Cilium, I wasn't aware either. But now I found this in their docs:

Host-reachable services act transparent to Cilium’s lower layer datapath in that upon connect system call (TCP, connected UDP) or sendmsg as well as recvmsg (UDP) the destination IP is checked for an existing service IP and one of the service backends is selected as a target, meaning, while the application is assuming its connection to the service address, the corresponding kernel’s socket is actually connected to the backend address and therefore no additional lower layer NAT is required.

Thanks again! Should I close this issue or leave it open for the docs improvement part?

Sorry added the wrong label - lets keep this open.

We have just been made aware of this. We can definitely add to our docs to disable host-services to skip the load-balancing decision. Before doing, that I would like to understand a bit better why translating ClusterIP to pod IP prior to Istio seeing it is causing a problem.

@tgraf Istio routing is based on:

HTTP traffic - we look only at host header, by binding to <IP_ADDRESS>:<PORT> and doing routing in Envoy Routes.
Non HTTP traffic - we create listeners for <SERVICE_VIP>:<PORT>.
Auto detected traffic (no protocol specified) is also using <SERVICE_VIP>:<PORT> listeners.

So for HTTP (explicitly declared only) will work (both theoretically and I confirmed this) as the routing doesn't take the IP into account, but everything else is not going to hit the appropriate configuration.

@tgraf does disabling host services significantly reduce functionality provided by cilium?

@tgraf does disabling host services translation significantly reduce functionality provided by cilium?

No, it does not. The functionality when implemented on the network level is the same, just with a much higher overhead as each network packet has to be altered.
We will point it out in the Cilium documentation that host services are currently not compatible with Istio due to the way Istio is doing redirect.
On that note, what if Cilium did the redirect of all traffic? Similar to host services can currently bypass Istio, it can also be used in favor of Istio to redirect traffic to the sidecar.

Non HTTP traffic - we create listeners for <SERVICE_VIP>:.

This then means that headless services are not compatible either if the DNS directly returns pod IPs?

This then means that headless services are not compatible either if the DNS directly returns pod IPs?

Good point - for headless services specifically we create listeners for each pod IP. The assumption we are depending on here, and why we do this only for headless services, is that users will not have massive headless services as this will lead to scalability bottlenecks.

How would Cilium redirect all traffic to Istio ? We do need some metadata - like original DST:port - that we get using a system call. We have discussed different ways to get this metadata - like a 'proxy protocol' prefix, or tunneled in H2 CONNECT - but it'll take some time.

How would Cilium redirect all traffic to Istio ? We do need some metadata - like original DST:port - that we get using a system call. We have discussed different ways to get this metadata - like a 'proxy protocol' prefix, or tunneled in H2 CONNECT - but it'll take some time.

We have already built this using TPROXY so you will see the original network headers. This is also how Cilium redirects packets to Envoy when Istio is not in play. In the past, we have also shared metadata with Envoy and have built an eBPF metadata reader in Envoy to share arbitrary data between the Cilium datapath and Envoy.

@tgraf is this available in OSS and does it require CAP_NET_ADMIN to read eBPF metadata?

@tgraf is this available in OSS

Yes, all of this is available as of Cilium today.

and does it require CAP_NET_ADMIN to read eBPF metadata?

Yes, when using TPROXY with IP_TRANSPARENT it will require CAP_NET_ADMIN. We also used to have code to redirect to a known listener port on Envoy which does not require CAP_NET_ADMIN.

Not stale
On Thu, Jan 7, 2021, 9:05 PM Istio Policy Bot<EMAIL_ADDRESS>wrote:

🧭 This issue or pull request has been automatically marked as stale
because it has not had activity from an Istio team member since 2020-10-09.
It will be closed on 2021-01-22 unless an Istio team member takes action.
Please see this wiki page
https://github.com/istio/istio/wiki/Issue-and-Pull-Request-Lifecycle-Manager
for more information. Thank you for your contributions.
Created by the issue and PR lifecycle manager.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/27619#issuecomment-756548323, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXL5DLU7NO5QW2QJEULSY2HAZANCNFSM4R5WUUDA
.

Not stale
On Thu, Jan 7, 2021, 9:05 PM Istio Policy Bot<EMAIL_ADDRESS>wrote:

🧭 This issue or pull request has been automatically marked as stale
because it has not had activity from an Istio team member since 2020-10-09.
It will be closed on 2021-01-22 unless an Istio team member takes action.
Please see this wiki page
https://github.com/istio/istio/wiki/Issue-and-Pull-Request-Lifecycle-Manager
for more information. Thank you for your contributions.
Created by the issue and PR lifecycle manager.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/27619#issuecomment-756548323, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXL5DLU7NO5QW2QJEULSY2HAZANCNFSM4R5WUUDA
.

Maybe we can add a check to istioctl precheck to ensure compatible cilium settings are used (bpf-lb-sock-hostns-only)

Maybe we can add a check to istioctl precheck to ensure compatible cilium settings are used (bpf-lb-sock-hostns-only)

:+1: We could make the setting accessible through Cilium's Config API.

Some news on this?

@alfsch the only thing Istio can ever do about this is warn that its enabled. The option fundamentally breaks Istio. No news on a warning being added

@howardjohn Is there an easy way to detect when Cilium runs with Istio?

Statically we can try to read Ciliums config and parse the configmap for this value, but I don't know how reliable that is (or stable). I do wonder if we could add a runtime check. We have a validation container that tests our iptables actually work though, i wonder if we could extend this... something like send a request to kubernetes.default and assert we get the ClusterIP instead of some other IP when we capture. WDYT?
One issue with that is we want to remove the validation container, but I think there will always be a place we can run it, it just may move

I'm more interested in detecting a presence of Istio from Cilium PoV. I'd like to add a warning if the KPR / Socket LB are enabled when running with Istio.

Ah got it. At install time you probably have Cilium before Istio, so I would imagine you want it at runtime.
Some possible detection mechanisms:

istio-system namespace exists
Pod has istio-proxy container
pod has a container running as UID 1337 with name "envoy"?
Pod has 2 containers and some specific iptables rules
Pod has 2 containers and listens on some specific ports

I am not sure what type of data you have where you would run this, but I'd imagine we could find an approach that works
One note, this would break all sidecar service meshes, so you might want a more generic approach

For all who have troubles with cilium in strict mode without kube-proxy.
From my point of view, the root cause for the issues was our cilium version < 12.x and linux kernel < 5.7 due to the usage of ubuntu 20.04 as kubernetes node image.
There were the same issues as described in http(s) communication across namespaces using services with port mappings to different destination ports. Using the same ports mitigated the problem for some pods, but not for all.
e.g. Java based service worked well, but python services with async lib had troubles.....
After updating to cilium 1.12.6 we still faced the issues, but after looking into the logs of the cilium pods, I found in the startup section warnings about possible problems with istio using a kernel lower than 5.7.
We updated the cluster nodes to a current ubuntu 22.04 with kernel 5.15.x and voilà, all our issues were gone. We even don't need the port mapping change to use the same destination ports.
The for us working command line to render the cilium chart is:
   helm template cilium cilium/cilium --version 1.12.6 --namespace` kube-system --set cni.exclusive=false --set operator.replicas=1 \
     --set hubble.tls.auto.method=cronJob --set hubble.relay.enabled=true --set hubble.ui.enabled=true \
     --set socketLB.hostNamespaceOnly=true --set nodePort.enabled=true --set hostPort.enabled=true \
     --set externalIPs.enabled=true --set bpf.masquerade=false \
     --set kubeProxyReplacement=strict --set k8sServiceHost=CHANGEME --set k8sServicePort=CHANGEME

kubernetes node:
System Info:
  Kernel Version:             5.15.0-60-generic
  OS Image:                   Ubuntu 22.04.1 LTS
  Operating System:           linux
  Architecture:               amd64
  Container Runtime Version:  containerd://1.6.16
  Kubelet Version:            v1.22.16

I found this, because I saw a warning during startup. @brb  Is the feature you want already implemented?

Still seeing this issue on AWS EKS 1.23:
Linux 5.4.238-148.347.amzn2.x86_64 #1 SMP Thu Apr 6 19:42:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Minimal install:
helm install cilium cilium/cilium \
    --version 1.13.2 \
    --namespace kube-system \
    --set kubeProxyReplacement=strict \
    --set socketLB.hostNamespaceOnly=true

On left hand side is the application pod and right hand is the istio-proxy sidecar of said application pod. tcpdump on istio-proxy shows requests going to endpoints of corends, intead of kube-dns.
Prior to replacing kube-proxy we were seeing correct calls:
20:20:22.043611 IP test-cf8977485-gfh4n.33835 > kube-dns.kube-system.svc.cluster.local.53: 10927+ PTR? <IP_ADDRESS>.in-addr.arpa. (43)
20:20:22.046156 IP kube-dns.kube-system.svc.cluster.local.53 > test-cf8977485-gfh4n.33835: 10927 NXDomain 0/1/0 (125)

After replacing kube-proxy:
05:35:36.927550 IP test-cf8977485-xx76b.46530 > 10-0-0-15.kube-dns.kube-system.svc.cluster.local.domain: 24413+ A? address.internal.default.svc.cluster.local. (60)
05:35:36.927600 IP test-cf8977485-xx76b.46530 > 10-0-0-15.kube-dns.kube-system.svc.cluster.local.domain: 46683+ AAAA? address.internal.default.svc.cluster.local. (60)
05:35:36.928428 IP test-cf8977485-xx76b.48588 > ip-10-0-0-202.us-west-2.compute.internal.domain: 9899+ A? address.internal.svc.cluster.local. (52)

Any thoughts on what else to try? After installing cilium, nodes were terminated to ensure all configurations applied correctly.

Kernel v5.7 is patched from https://github.com/torvalds/linux/commit/f318903c0bf42448b4c884732df2bbb0ef7a2284
Cilium need this patch when --set socketLB.hostNamespaceOnly=true.

Thanks @christian-posta @gyutaeb confirmed with EKS 1.24 (Kernel v5.10) this issue is resolved.

Closing


Attribute CLKIN_PERIOD (on DCM_CLKGEN_1) doesn't match PERIOD constraint?

WARNING:NgdBuild:1212 - User specified non-default attribute value (20.000000)
   was detected for the CLKIN_PERIOD attribute on DCM "DCM_CLKGEN_1".  This does
   not match the PERIOD constraint value (10 ns.).  The uncertainty calculation
   will use the non-default attribute value.  This could result in incorrect
   uncertainty calculated for DCM output clocks.

fixed by: https://github.com/timvideos/HDMI2USB-misoc-firmware/commit/3256934c24ea08d7aa6d0711a21b43f24b7a9a2f

This seems to again exist in our current firmware.


Obey the Rule of Silence

Fixes #962

Coverage decreased (-0.0%) to 98.64% when pulling 9bbcf6daa1f818476bdd2878cd3e924b52bd482c on feross:master into ca77989defdee0320f92fb029ca61fa062ed0f35 on jscs-dev:master.

Nice job @feross! :+1:

I'm not sure we could land this till 2.0, as there maybe programs that are (albeit incorrectly) checking for the "no errors" message rather than the success error code.

Yep, I agree. This is definitely a major version bump.
Though, you could publish this as 2.0.0 immediately, if you're so inclined. Bumping the major version isn't that big of a deal :) Browserify is already on 8.x.x. Not to mention the version Chrome is on! :p

Agree with @mikesherov

+1


[ruyi-reimu] Board image revyos-milkv-meles need update

Description

In upstream repo https://github.com/milkv-meles/meles-images, the latest version is v2024-0417

Filename changed


Add ability to set the "background" option when creating an index

Add ability to set the "background" option when creating an index. This is pretty much required to avoid issues when deploying to Prod and not expecting any down time.
I'm no Go/Terraform expert so just let me know if there's anything extra you want me to add.

Seems good to me.
Note that background indexes are deprecated since mongo 4.2 though: https://www.mongodb.com/docs/v5.3/reference/method/db.collection.createIndex/#options.
I'll merge it because it can be useful for older versions but that is important to note.


Add test-proxy contributing.md

@mario-guerra when you have a couple minutes please take a look.
Resolves #5392

@scbedd I took a quick pass through the doc and it looks good. I'd like to delve into it a bit deeper and follow along with the instructions to see if I can successfully make a change and build the project before we commit this doc. I will do that early next week.


Creating from resource

Problem 3: https://github.com/laravel/nova-issues/issues/930
Same in belongsTo, when prepopulate installed, works when deleted.
Update, please

Hi sorry @dddeeemmmooonnn I completely missed this, please can you elaborate on what you mean, if it is still an issue for you.
Thanks.

Hi, just rewrite from new nova sources. I have already rewrote myself, and also MorphTo

@dddeeemmmooonnn  would you mind testing version 1.2.0 and let me know if that fixes things for you? Thanks!


There is no way to use TypeTester for data created in Python

Because we can't specify just column names to the constructor

Of course you can, you just just have to invoke TypeTester.run() directly. It's a tiny bit cumbersome, but it works.


"Vânători-Neamț", "Lunca", "Mânăstirea Neamț" and "Nemțișor" are listed in the drop-down menu

Description:
"Vânători-Neamț", "Lunca", "Mânăstirea Neamț" and "Nemțișor" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Vânători-Neamț" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Vânători-Neamț, NEAMȚ (Vânători-Neamț)" and "Comuna Vânători-Neamț, NEAMȚ".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Lunca" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Lunca, NEAMȚ (Vânători-Neamț)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Mânăstirea Neamț" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Mânăstirea Neamț, NEAMȚ (Vânători-Neamț)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Nemțișor" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Nemțișor, NEAMȚ (Vânători-Neamț)".


Build fewer wheels using abi3

@arvidn can you eyeball the benchmarks to make sure there is nothing obviously worse? I'd also like to try doing a full sync with this binary before we merge it.

the change looks good as far as I can tell, but for some reason the benchmarks are a lot worse than main.
Windows: 316s -> 357s
Ubuntu: 166s -> 185s
Mac: 271s -> 287s
Windows shouldn't be affected by this change, right? so maybe this is just noise (it seems like a lot of noise though).

I removed the openssl part of the patch to see how it affects the benchmarks.


Array Interface failure scenario

Description
This PR has changes for an integration test scenario that covers failures against a specific network interface. Specifically, we want to be able to fail only the network interface that provides access to the array. In such a scenario, we'll expect to see the podmon taint, but not the kubernetes unreachable taints.
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

#13

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?
Ran the new test scenario:

INFO[0428] k8sPoll: Node: worker-2-9kg9ykp6smfhc.domain Ready:true Taints:
INFO[0428] k8sPoll: worker-2-9kg9ykp6smfhc.domain [ PROTECTED   ] pmtv1/podmontest-0 Running
INFO[0430] k8sPoll: Node: master-1-9kg9ykp6smfhc.domain Ready:true Taints: node-role.kubernetes.io/master
INFO[0430] k8sPoll: Node: worker-1-9kg9ykp6smfhc.domain Ready:true Taints:
INFO[0430] k8sPoll: ^^^^^^^^^^^ is a failed node. Expecting taints: vxflexos.podmon.storage.dell.com
INFO[0430] k8sPoll: Node: worker-2-9kg9ykp6smfhc.domain Ready:true Taints:
| ""         | "1-1"       | "1-1" | "1-1" | "vxflexos" | "vxflexos"   | "one-third" | "zero"  | "reboot:ens192"        | "vxflexos.podmon.storage.dell.com" | 120      | 240        | 300     | 300           |
2 scenarios (2 passed)
18 steps (18 passed)
7m7.870230098s
INFO[0432] Integration test finished
--- PASS: TestPowerflexArrayInterfaceDown (427.89s)
PASS
status 0
ok      podmon/internal/monitor 432.364s

And the quick integration test for vxflexos:

INFO[0967] k8sPoll: Node: worker-1-9kg9ykp6smfhc.domain Ready:true Taints:
INFO[0967] k8sPoll: ^^^^^^^^^^^ is a failed node. Expecting taints: node.kubernetes.io/unreachable,vxflexos.podmon.storage.dell.com
INFO[0967] k8sPoll: Node: worker-2-9kg9ykp6smfhc.domain Ready:true Taints:
INFO[0969] k8sPoll: Node: master-1-9kg9ykp6smfhc.domain Ready:true Taints: node-role.kubernetes.io/master
INFO[0969] k8sPoll: Node: worker-1-9kg9ykp6smfhc.domain Ready:true Taints:
INFO[0969] k8sPoll: ^^^^^^^^^^^ is a failed node. Expecting taints: node.kubernetes.io/unreachable,vxflexos.podmon.storage.dell.com
INFO[0969] k8sPoll: Node: worker-2-9kg9ykp6smfhc.domain Ready:true Taints:
| ""         | "2-2"       | "2-2" | "2-2" | "vxflexos" | "vxflexos"   | "one-third" | "zero"  | "reboot" | 120      | 240        | 300     | 600           |
4 scenarios (4 passed)
36 steps (36 passed)
16m5.762454378s
INFO[0970] Integration test finished
--- PASS: TestPowerFlexShortIntegration (965.78s)
PASS
status 0
ok      podmon/internal/monitor 970.173s

@ameer-jabbar: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at<EMAIL_ADDRESS>


Question: Hiding a version that's not ready for release

Hi, so I currently have an API endpoints that is currently on version 1
I'm planning to make new features so it will be on version 2. But I'm wondering what's the most recommended way to hide a version that's not ready for release and in development?
(For example this version 2 is probably be ready after couple of pull requests to main branch)
So in the mean time I want to hide it first to not accidentally be used by clients.
I was thinking that maybe I can just comment out ApiVersionAttribute(2) but I don't think it's a clean way to do it
I'm using Web API OData (.NET Framework)

There are several approaches to address this issue. The first question is really about whether you want to hide the API or just restrict who can use it? Pre-releases are a supported concept; for example:
[Authorize("EarlyAdopters")]
[ApiVersion(2.0, "preview.1")]
[RoutePrefix("awesome")]
public class AwesomeController : ApiController
{
    [Route]
    public IHttpActionResult Get() => StatusCode(HttpStatusCode.OK);
}

GET /awesome?api-version=2.0-preview.1 indicates that it is a preview and is only accessible to EarlyAdopters. If any one else tries to access the API, they will receive 403.
If you don't want anyone to access the API beyond the development team, then the best way to deal with that is likely a different version control system branching. Rather than have pull requests go to main, they should go to branch release/2.0 or something like that. Once everything is tested, validated, and ready to go to main, then - and only then - a lead/manager/etc merges release/2.0 to main. This keeps things cleanly separated without a bunch of code churn and trickery.

Since there were no additional follow up questions, I presume the answer and possible solutions were satisfactory. If it wasn't or you have additional questions, feel free to ask or re-open the issue.


[BUG]: Default OpenShift 4.17 (and previous versions) deployment - all nodes have the same hostnqn for nvme-tcp

Bug Description
NVMe-TCP connectivity to PowerStore requires that the hosts all have unique NQNs.
By default, when deploying openshift - RHCOS has the same hostnqn for all nodes.
the hostnqn is found here:  the /etc/nvme/hostnqn
This challenge is not documented in the Dell CSM / CSI documentation.
Please include this requrement: "All hosts require unique NQNs" in the Dell CSM documentation and Please provide the machineconfig FIX below that was provided by Red Hat.
Here is the Red Hat provided machineconfig to ensure that OpenShift worker nodes generate a unique NQN when being deployed;  This customization should be applied before deploying the Dell CSM/CSM drivers.
https://dell-iac.slack.com/archives/C025E763URH/p1716562942754739?thread_ts=1716216313.143199&cid=C025E763URH
i.	Machineconfig
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
labels:
machineconfiguration.openshift.io/role: worker
name: 99-worker-custom-nvme-hostnqn
spec:
config:
ignition:
version: 3.2.0
systemd:
units:
- contents: |
[Unit]
Description=Custom CoreOS Generate NVMe Hostnqn
        [Service]
        Type=oneshot
        ExecStart=/usr/bin/sh -c '/usr/sbin/nvme gen-hostnqn > /etc/nvme/hostnqn'
        RemainAfterExit=yes

        [Install]
        WantedBy=multi-user.target
      enabled: true
      name: custom-coreos-generate-nvme-hostnqn.service

Logs
n/a
Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
Any OpenShift deployement
Expected Behavior
OpenShift nodes need unique NQNs for NVMeTCP connectivity to any Dell Storage
CSM Driver(s)
Yes
Installation Type
n/a
Container Storage Modules Enabled
No response
Container Orchestrator
OpenShift 4.17.7
Operating System
Linux

`apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
labels:
machineconfiguration.openshift.io/role: worker
name: 99-worker-custom-nvme-hostnqn
spec:
config:
ignition:
version: 3.2.0
systemd:
units:
- contents: |
[Unit]
Description=Custom CoreOS Generate NVMe Hostnqn
        [Service]
        Type=oneshot
        ExecStart=/usr/bin/sh -c '/usr/sbin/nvme gen-hostnqn > /etc/nvme/hostnqn'
        RemainAfterExit=yes

        [Install]
        WantedBy=multi-user.target
      enabled: true
      name: custom-coreos-generate-nvme-hostnqn.service

`


Memory consumption is way too high.

Describe the bug
The memory consumption can go higher than 2GB with this simple app.
To Reproduce
Run the provided project.
Expected behavior
Not a so high memory usage.

OS: Windows
Version 0.10.2

AvaloniaMemoryBug.zip

See the other issue you posted. Looks like virtualization is broken due to StackPanel around ListBox which will force Avalonia to keep all items in memory

Hi, I'll take a look. Thanks for the quick answer.

@Nemirtingas I don't think WrapPanel supports virtualization.

Whats the best way to display a list of nodes that I could collapse then ?

The best would be to use TreeDataGrid control, but you probably would need to restyle expander rows.
Without TreeDataGrid you have a choice between ItemsPresenter (used inside of ItemsControl) and ItemsRepeater.
First one should be enough if you use VirtualizationMode=Simple with stack panel (instead of wrap panel).
With second you can set virtualized WrapLayout, but it might be buggy.

I used a ListBox with a DataTemplate, seems fine now. As collapsible container, I used an Expander.
The only remaining issue is that the ListBox doesn't resize when openning the Expander and if I open 1 Expander and then scroll in the ListBox, it will open the next Expander available.

I open 1 Expander and then scroll in the ListBox, it will open the next Expander available

Because containers are reused. You can use bindings to the view model to remember correct state of the expanders.


Patch 1.5.1

Link
Type
1.5.x
Comment

#2438
Bug
✅

#2436
Doc
✅

#2435
Bug
✅

@PTNobel let's wait for a follow up MR to https://github.com/cvxpy/cvxpy/pull/2435 that adds the DGP support back in.


Add Js linter & commit hooks

We should add a Js linter (locally when building, and in the CI), and also a commit hook (I have a half finished one for checking the commit messages).
Details TBD.

yes also a precommit-hook will be helpful that runs linter and prettier config before each commit

@joaquimrocha whats the status for the commit hook

We don't have any specific hooks but we do have the linter, so let's close this and maybe look into the hook later.


Audiobus integration question

Hi,
I'm currently trying to implement Audiobus support in my Audiokit based prototype. I'm struggling a bit with some aspects of the AudioUnit part of the implementation and could use your help. Here's the thing,  as mentioned in #335 I build an effect rack, which consists in multiple AKNode elements wired to each other.
Now I'm following Audiobus documentation on how to have your app integrate as an effect, and wish to use the ABAudioFilter classe like in the "Filter port" section documented here: https://developer.audiob.us/doc/_integration-_guide.html#Create-Controller
The documentation says that the ABAudioFilter will take an audio unit as input, and if it's input is activated will feed the input sound into it, and send the output of it to the AudioBus port output.
Now my question is: I see that all AudioKit AKNode are basically audio units. But I don't quite understand how they are wired together when I use say a AKCostelloReverb as input for a AKDelay. Therefore I have a hard time figuring out in my case, which audio unit to provide to the ABAudioFilter, and if that's even possible. As I understand it right now, it means that my whole effect chain should work as a single audio unit. Is that even possible with AudioKit? In General?  Maybe something I've missed with AudioKit.engine?
I'm aware this question might be out of borders. If it is let me know. However, I'd love to get your help on this matter, as it would also help outlining the path to AudioBus integration with AudioKit.
Thanks!

When you tell AKDelay that its input it is AKCostelloReverb, this happens behind the scenes:
public func addConnectionPoint(node: AKNode) {
connectionPoints.append(AVAudioConnectionPoint(node: node.avAudioNode, bus: 0))
AudioKit.engine.connect(avAudioNode,
toConnectionPoints: connectionPoints,
fromBus: 0,
format: AudioKit.format)
}
which forms an audio chain from one node's output to another's input.
AKOperations create a single audio unit from many operations however, so you could make a single audio unit that uses the operation version of delay and costello reverb.
This is an important process you're going through and I'm hoping that you'll provide good information back to us as you pave the path forward and I'll try to be of as much help to you as I can.

Thanks for your quick answer @aure
The AKOperation seems interesting, however this opens a bunch of other questions:

How can I concretely chain multiple operation based effects as a single node? Do you have any example? The documentation does not seem to provide one, and I couldn't figure out myself.
I tried to read the code of AKOperation but don't quite understand how it really works under the hood. Thus a question arises: is it possible to re-implement the existing AKNode effects using AKOperation?
As previously mentioned, their documentation states that the AudioUnit must have input activated, is it the case on with AKOperation (Nota: I'm not sure to know what that actually means :D)
Also, I'm quite new to iOS development, what is the role of the AVFoundation elements, especially in the usage you've mentioned in AKNode with the AVAudioConnection point usage

If I understand this properly, it means that an implementation in my case would be to create an ABAudioFilter with my AKOperation as AudioUnit right?
I will for sure try to contribute back my learnings if I can get this to work :-)

Most of the operation playgrounds string together several operations.  Here's one example:
http://audiokit.io/playgrounds/Linear and Exponential Segment Operations/
Yes, you can access parameters at any time as demonstrated on this playground:
http://audiokit.io/playgrounds/AutoPan Operation/
I was just thinking if you were limiting to a single audio unit, operations would allow you to jam one audio unit with a lot of cool things.

Thanks for the example @aure
After a lot of die and retry, I come to the conclusion that in my specific case of an effect rack AudioKit is probably not the best tool for the job (yet?).
Thanks again for the support :-)


embassy-rp Ability to change UART baudrate during runtime

As far as I have worked with Embassy, is of my understanding that  Peripherals and UART interfaces are built under the concept of the UART interface consuming the interface pins from the the Peripherals singleton.
In rust if a member of a struct is consumed there is no way back. Which means as soon as the UART is created you can't create another instance with a different baudrate. This is not the case of more more high level frameworks, (sorry for the example I'm going to give here I which I understand is a totally different tool) the arduino Processing environment on which to change the speed is only a matter of creating again a new UART instance with a new speed configuration.
There is a case in which there are serial devices that work with different buadrates during runtime (for intance configure the device at 9600 8-N-1 and then go 115200 for regular operation after configuration). On the embassy_rp::uart::Uart methods there isn't any kind of aid to change the baudrate neither any other configuration of the UART during runtime. I'm missing something on how I'm thinking on how to solve the problem or this is a feature that is missing on the UART functionality ?

You can create the uart driver with &mut on the peripheral and pins singleton, which means that when the driver is dropped the borrow on the singletons is released, and you can use them again.
There's no "set baudrate" method currently, but we could have it. nRF already has it.. PR's welcome!.

You can create the uart driver with &mut on the peripheral and pins singleton, which means that when the driver is dropped the borrow on the singletons is released, and you can use them again.
There's no "set baudrate" method currently, but we could have it. nRF already has it.. PR's welcome!.

Alright I have just created the set_baudrate:
/// sets baudrate on runtime
pub fn set_baudrate(&mut self, baudrate: u32) {

	let r = T::regs();

        let clk_base = crate::clocks::clk_peri_freq();

        let baud_rate_div = (8 * clk_base) / baudrate;
        let mut baud_ibrd = baud_rate_div >> 7;
        let mut baud_fbrd = ((baud_rate_div & 0x7f) + 1) / 2;

        if baud_ibrd == 0 {
            baud_ibrd = 1;
            baud_fbrd = 0;
        } else if baud_ibrd >= 65535 {
            baud_ibrd = 65535;
            baud_fbrd = 0;
        }

        unsafe {

	    // Load PL011's baud divisor registers
            r.uartibrd().write_value(pac::uart::regs::Uartibrd(baud_ibrd));
            r.uartfbrd().write_value(pac::uart::regs::Uartfbrd(baud_fbrd));
	}

    }

Which is the procedure for the PR ? I need to create a new branch with some specific naming ? What else needs to be submitted to fulfill all the requirements ?

Standard github procedure (fork repo, push change to a branch in your fork with whatever name you want, open a PR)

Please don't duplicate the baudrate calculation code. Either extract it to a separate function, or make new call set_baudrate. I think the latter is nicer if it works.

Please let me know I I understood correctly it would be first some private abstraction for the baudrate calculation like this withthin UART's implementation:
    fn baudrate_calculations(baudrate: u32) -> (u32, u32) {

        let clk_base = crate::clocks::clk_peri_freq();

        let baud_rate_div = (8 * clk_base) / baudrate;
        let mut baud_ibrd = baud_rate_div >> 7;
        let mut baud_fbrd = ((baud_rate_div & 0x7f) + 1) / 2;

        if baud_ibrd == 0 {
            baud_ibrd = 1;
            baud_fbrd = 0;
        } else if baud_ibrd >= 65535 {
            baud_ibrd = 65535;
            baud_fbrd = 0;
        }

	(baud_ibrd, baud_fbrd)
    }

and then on either places where is the dependency then do the following calls right ? first on init
    fn init(
        tx: Option<PeripheralRef<'_, AnyPin>>,
        rx: Option<PeripheralRef<'_, AnyPin>>,
        rts: Option<PeripheralRef<'_, AnyPin>>,
        cts: Option<PeripheralRef<'_, AnyPin>>,
        config: Config,
    ) {
        let r = T::regs();
        unsafe {
            if let Some(pin) = &tx {
                pin.io().ctrl().write(|w| w.set_funcsel(2));
                pin.pad_ctrl().write(|w| w.set_ie(true));
            }
            if let Some(pin) = &rx {
                pin.io().ctrl().write(|w| w.set_funcsel(2));
                pin.pad_ctrl().write(|w| w.set_ie(true));
            }
            if let Some(pin) = &cts {
                pin.io().ctrl().write(|w| w.set_funcsel(2));
                pin.pad_ctrl().write(|w| w.set_ie(true));
            }
            if let Some(pin) = &rts {
                pin.io().ctrl().write(|w| w.set_funcsel(2));
                pin.pad_ctrl().write(|w| w.set_ie(true));
            }

	    let (baud_ibrd, baud_fbrd) = Uart::<T,M>::baudrate_calculations(config.baudrate);

            // Load PL011's baud divisor registers
            r.uartibrd().write_value(pac::uart::regs::Uartibrd(baud_ibrd));
            r.uartfbrd().write_value(pac::uart::regs::Uartfbrd(baud_fbrd));

......

and the over the new method that I'm suggesting:
    pub fn set_baudrate(&mut self, baudrate: u32) {

	let r = T::regs();

	let (baud_ibrd, baud_fbrd) = Self::baudrate_calculations(baudrate);

        unsafe {

	    // Load PL011's baud divisor registers
            r.uartibrd().write_value(pac::uart::regs::Uartibrd(baud_ibrd));
            r.uartfbrd().write_value(pac::uart::regs::Uartfbrd(baud_fbrd));
	}

    }

Is this correct ?

That works, but I think it should be possible to do something like this, so you don't duplicate the register writes either
fn init(...) {
    ...
    Self::set_baudrate_inner(baudrate);
    ...
}

/// sets baudrate on runtime
pub fn set_baudrate(&mut self, baudrate: u32) {
	    Self::set_baudrate_inner(baudrate);
}

fn set_baudrate_inner(baudrate: u32) {
	let r = T::regs();

        let clk_base = crate::clocks::clk_peri_freq();

        let baud_rate_div = (8 * clk_base) / baudrate;
        let mut baud_ibrd = baud_rate_div >> 7;
        let mut baud_fbrd = ((baud_rate_div & 0x7f) + 1) / 2;

        if baud_ibrd == 0 {
            baud_ibrd = 1;
            baud_fbrd = 0;
        } else if baud_ibrd >= 65535 {
            baud_ibrd = 65535;
            baud_fbrd = 0;
        }

        unsafe {

	    // Load PL011's baud divisor registers
            r.uartibrd().write_value(pac::uart::regs::Uartibrd(baud_ibrd));
            r.uartfbrd().write_value(pac::uart::regs::Uartfbrd(baud_fbrd));
	}
}

fixed in #1243


[fuzzing] removing storage_save_blocks fuzzer due to low exec/s

There is no point in wasting resources to run this fuzzer (that I wrote :D) as it is too slow. We need to find a way to either speed it up, or break down in several fuzzers.

@bors-libra r+

:pushpin: Commit b7e275c has been approved by rexhoffman

:hourglass: Testing commit b7e275cbe9544347a332a27401138a4cfe73514f with merge 39092a567a3950484416941f98a75ff1d7e2f8c3...

:broken_heart: Test failed - checks-actions_land_blocking_test

@bors-libra retry

:hourglass: Testing commit b7e275cbe9544347a332a27401138a4cfe73514f with merge 8e7bf6c897656d3b77628adc31984413b383e81c...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: rexhoffman
Pushing 8e7bf6c897656d3b77628adc31984413b383e81c to master...


SAMD21 support?

How about supporting SAMD21/Arduino Zero?! Or does anyone know of a bootloader for this controller that is able to flash/update via sdcard?!

I would be happy to pull if you get it to compile for SAMD21 :)

:-)
I'm busy with other things, but will have a look into this as soon I have enough time for it.
I have no bootloader experience yet, nor I have looked into your source code. But my guess is, that one just have to change the method how data is written into the microcontroller?!

I have started to work on this!


[FEATURE] Added LlamaParse parser

Issue
Provides the LlamaParse parser integration
Change
LlamaParse is a component of LlamaCloud that allows you to parse PDFs into structured data. https://docs.cloud.llamaindex.ai/
LlamaParse, parses complex documents with embedded objects like tables and figures.
General checklist

[X] There are no breaking changes
[X] I have added unit and integration tests for my change
[X] I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
[X] I have manually run all the unit and integration tests in the core and main modules, and they are all green

[ ] I have added/updated the documentation
[ ] I have added an example in the examples repo (only for "big" features)

Checklist for adding new model integration

[X] I have added my new module in the BOM

LlamaParse can now handle spreadsheets!
https://x.com/llama_index/status/1796237002364613040

@langchain4j  no progress here? :-)

Sorry, did not have enough time yet, will try to review this or next week

Seems like something I will likely be including in Quarkus LangChain4j, so expect an introduction of an SPI 😉

So @geoand, one more + for merging this ASAP :P

@langchain4j no news bad news? 😃

@dloiacono this does not compile. GsonConverterFactory cannot be found

@dloiacono this does not compile. GsonConverterFactory cannot be found

I fixed it

@dloiacono this does not compile. GsonConverterFactory cannot be found

I fixed it


[Bug]: unable to create a cluster with 3 control plane replicas

What happened
Unable to add 3 control plane with all templates provided in templates or example directory
Only configuration with 1 ctrl plane  are working
Step to reproduce
Choose any templates, or default https://github.com/outscale/cluster-api-provider-outscale/blob/main/templates/cluster-template.yaml
Choose any images ubuntu-2204-2204-kubernetes-v1xxxx
Add 3 replicas in control-plane section
Expected to happen
a cluster with 3 ctrl plane
Add anything
Second control plane failed to to join the cluster
...
[  388.990481] cloud-init[1077]: [2024-10-29 14:39:23] {"level":"warn","ts":"2024-10-29T14:39:23.610631Z","logger":"etcd-client","caller":"v3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"etcd-endpoints://0xc0001f8e00/<IP_ADDRESS>:2379","attempt":0,"error":"rpc error: code = FailedPrecondition desc = etcdserver: can only promote a learner member which is in sync with leader"}
[  388.990591] cloud-init[1077]: [2024-10-29 14:39:25] [etcd] Waiting for the new etcd member to join the cluster. This can take up to 40s
[  388.990708] cloud-init[1077]: [2024-10-29 14:39:25] The 'update-status' phase is deprecated and will be removed in a future release. Currently it performs no operation
[  388.990820] cloud-init[1077]: [2024-10-29 14:39:25] [mark-control-plane] Marking the node ip-10-0-4-95 as control-plane by adding the labels: [node-role.kubernetes.io/control-plane node.kubernetes.io/exclude-from-external-load-balancers]
[  388.990986] cloud-init[1077]: [2024-10-29 14:39:25] [mark-control-plane] Marking the node ip-10-0-4-95 as control-plane by adding the taints [node-role.kubernetes.io/control-plane:NoSchedule]
[  388.991056] cloud-init[1077]: [2024-10-29 14:39:58] [kubelet-check] Initial timeout of 40s passed.
[  388.991170] cloud-init[1077]: [2024-10-29 14:41:25] error execution phase control-plane-join/mark-control-plane: error applying control-plane label and taints: nodes "ip-10-0-4-95" not found
[  388.991285] cloud-init[1077]: [2024-10-29 14:41:25] To see the stack trace of this error execute with --v=5 or higher
[  388.991403] cloud-init[1077]: [2024-10-29 14:41:25] 2024-10-29 14:41:25,857 - cc_scripts_user.py[WARNING]: Failed to run module scripts_user (scripts in /var/lib/cloud/instance/scripts)
[  388.991514] cloud-init[1077]: [2024-10-29 14:41:25] 2024-10-29 14:41:25,857 - util.py[WARNING]: Running module scripts_user (<module 'cloudinit.config.cc_scripts_user' from '/usr/lib/python3/dist-packages/cloudinit/config/cc_scripts_user.py'>) failed

cluster-api output
# logs capi-controller-manager
I1029 14:36:39.251111       1 machine_controller_noderef.go:61] "Waiting for infrastructure provider to report spec.providerID" controller="machine" controllerGroup="cluster.x-k8s.io" controllerKind="Machine" Machine="default/osc-c1-dev-control-plane-6dxf4" namespace="default" name="osc-c1-dev-control-plane-6dxf4" reconcileID="484c2cb6-c494-4601-9107
-1c965c79ee2a" KubeadmControlPlane="default/osc-c1-dev-control-plane" Cluster="default/osc-c1-dev" OscMachine="default/osc-c1-dev-control-plane-6dxf4"
I1029 14:44:32.319060       1 machine_controller_phases.go:306] "Waiting for infrastructure provider to create machine infrastructure and report status.ready" controller="machine" controllerGroup="cluster.x-k8s.io" controllerKind="Machine" Machine="default/osc-c1-dev-control-plane-6dxf4" namespace="default" name="osc-c1-dev-control-plane-6dxf4" recon
cileID="cd3f6a37-ecb7-4354-bdcb-a64c5d0b8cb4" KubeadmControlPlane="default/osc-c1-dev-control-plane" Cluster="default/osc-c1-dev" OscMachine="default/osc-c1-dev-control-plane-6
dxf4"
I1029 14:44:32.319170       1 machine_controller_noderef.go:61] "Waiting for infrastructure provider to report spec.providerID" controller="machine" controllerGroup="cluster.x-k8s.io" controllerKind="Machine" Machine="default/osc-c1-dev-control-plane-6dxf4" namespace="default" name="osc-c1-dev-control-plane-6dxf4" reconcileID="cd3f6a37-ecb7-4354-bdcb
-a64c5d0b8cb4" KubeadmControlPlane="default/osc-c1-dev-control-plane" Cluster="default/osc-c1-dev" OscMachine="default/osc-c1-dev-control-plane-6dxf4"

Environment
- Kubernetes version: (use `kubectl version`):
- OS (e.g. from `/etc/os-release`):
- Kernel (e.g. `uname -a`): ubuntu
- cluster-api-provider-outscale version: v0.3.1
- cluster-api version: v1.8.4
- Install tools:
- Kubernetes Distribution:
- Kubernetes Distribution version:

I work with @pli01 and I came to same conclusion.
I think it is linked to this issue:
https://github.com/outscale/cluster-api-provider-outscale/issues/380
With my tests, when I add a public IP to the first node and/or the second node, at some point, it starts to work.
I didn't maange to find the failing curl :/
@outscale-hmi, I'd love to pair program with you to debug this :)

Hello,
The bug seems fixed in the main branch. Is-it possible to make an official release ?


Select Component is positioned behind in modal

Bug report
Current Behavior
When trying to select in a modal, the options are painted below the modal

Your environment
React with vite

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-select
^2.0.0

React
n/a
^18.2.0

Browser
chrome
n/a

Assistive tech

Node
n/a
20.3.0

npm/yarn
npm
9.6.7

Operating System
windows
10

Do you have a reproducible example?

None at the moment but there is a feature request for combobox https://github.com/radix-ui/primitives/issues/1342

I think this can be closed?


fix: minor README.md tweaks

Some small tweaks after reproducing the setup for Neovim + a typo fix

Awesome, merged!

Thanks :)


Protect example inside main

Dear authors,
Thanks a lot for COMET and outsourcing your code.
🐛 Bug
Running word_level QE estimation trigger the following error:
Traceback (most recent call last):
File "", line 1, in
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 116, in spawn_main
exitcode = _main(fd, parent_sentinel)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 125, in _main
prepare(preparation_data)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 236, in prepare
_fixup_main_from_path(data['init_main_from_path'])
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 287, in _fixup_main_from_path
main_content = runpy.run_path(main_path,
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/runpy.py", line 263, in run_path
return _run_module_code(code, init_globals, run_name,
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/runpy.py", line 96, in _run_module_code
_run_code(code, mod_globals, init_globals,
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/Users/Ebenge/Desktop/quality_estimation/examples/word_level/wmt_2018/de_en/microtransquest.py", line 52, in
sources_tags, targets_tags = model.predict(test_sentences[:1], split_on_space=True)
File "/Users/Ebenge/Desktop/quality_estimation/transquest/algo/word_level/microtransquest/run_model.py", line 991, in predict
eval_dataset = self.load_and_cache_examples(None, to_predict=predict_examples)
File "/Users/Ebenge/Desktop/quality_estimation/transquest/algo/word_level/microtransquest/run_model.py", line 1203, in load_and_cache_examples
features = convert_examples_to_features(
File "/Users/Ebenge/Desktop/quality_estimation/transquest/algo/word_level/microtransquest/utils.py", line 345, in convert_examples_to_features
with Pool(process_count) as p:
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/context.py", line 119, in Pool
return Pool(processes, initializer, initargs, maxtasksperchild,
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/pool.py", line 212, in init
self._repopulate_pool()
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/pool.py", line 303, in _repopulate_pool
return self._repopulate_pool_static(self._ctx, self.Process,
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/pool.py", line 326, in _repopulate_pool_static
w.start()
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/process.py", line 121, in start
self._popen = self._Popen(self)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/context.py", line 283, in _Popen
Traceback (most recent call last):
File "", line 1, in
return Popen(process_obj)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/popen_spawn_posix.py", line 32, in init
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 116, in spawn_main
super().init(process_obj)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/popen_fork.py", line 19, in init
self._launch(process_obj)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/popen_spawn_posix.py", line 42, in _launch
prep_data = spawn.get_preparation_data(process_obj._name)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 154, in get_preparation_data
exitcode = _main(fd, parent_sentinel)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 125, in _main
_check_not_importing_main()
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 134, in _check_not_importing_main
prepare(preparation_data)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/multiprocessing/spawn.py", line 236, in prepare
raise RuntimeError('''
RuntimeError:
An attempt has been made to start a new process before the
current process has finished its bootstrapping phase.
    This probably means that you are not using fork to start your
    child processes and you have forgotten to use the proper idiom
    in the main module:

        if __name__ == '__main__':
            freeze_support()
            ...

    The "freeze_support()" line can be omitted if the program
    is not going to be frozen to produce an executable.
_fixup_main_from_path(data['init_main_from_path'])

To Reproduce
python microtransquest.py (the one in examples/word_level/wmt_2018/de_en)
Expected behaviour
No error
Fix
Wrap everything inside a main 👍
Environment
OS: OS
certifi==2021.10.8
charset-normalizer==2.0.7
click==8.0.3
configparser==5.1.0
cycler==0.11.0
docker-pycreds==0.4.0
filelock==3.4.0
flatbuffers==2.0
fonttools==4.28.2
gitdb==4.0.9
GitPython==3.1.24
huggingface-hub==0.1.2
idna==3.3
joblib==1.1.0
kiwisolver==1.3.2
matplotlib==3.5.0
numpy==1.21.4
onnxruntime==1.9.0
packaging==21.3
pandas==1.3.4
pathtools==0.1.2
Pillow==8.4.0
promise==2.3
protobuf==3.19.1
psutil==5.8.0
pyparsing==3.0.6
python-dateutil==2.8.2
pytz==2021.3
PyYAML==6.0
regex==2021.11.10
requests==2.26.0
sacremoses==0.0.46
scikit-learn==1.0.1
scipy==1.7.2
sentencepiece==0.1.96
sentry-sdk==1.5.0
seqeval==1.2.2
setuptools-scm==6.3.2
shortuuid==1.0.8
six==1.16.0
smmap==5.0.0
subprocess32==3.5.4
tensorboardX==2.4.1
termcolor==1.1.0
threadpoolctl==3.0.0
tokenizers==0.10.3
tomli==1.2.2
torch==1.10.0
tqdm==4.62.3
transformers==4.12.5
typing-extensions==4.0.0
urllib3==1.26.7
wandb==0.12.7
yaspin==2.1.0
Additional context
Fix solve the pb.

Wrong repo. Sorry


docs | tasks | configure-pod-container | Quality of Service

Add quality of service
add example/pods/* included in file

/assign @oussemos

/lgtm

/approve


Read SMS

Does xamarin essentials has sms read method to read the mobile sms.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9f58f89-6349-2778-fc01-c565f7834f62
Version Independent ID: e81b037b-2beb-d0ff-d47f-27130f6e2d5c
Content: Sms Class (Xamarin.Essentials)
Content Source: docs/en/Xamarin.Essentials/Sms.xml
Product: xamarin
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

No, this is not a feature available across all the supported platforms.