Better Stats has visual errors.

It is set up for people to use with a small GUI, which makes everything else just way too small. Please try to set it up for normal GUI as it looks great.

Sorry it took so long to reply, that fixed it thanks a lot!
On Mon, Jan 28, 2019 at 02:02 tiffit<EMAIL_ADDRESS>wrote:

Try out update 0.3.1 and see if the issue is fixed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tiffit/Wynnforge/issues/6#issuecomment-458018370, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMr9Asl2_oAW1fEZ4HIMwoDe5MjLSKXjks5vHqCJgaJpZM4aP7lg
.


Encoding and functools ModuleError

Feature
While running program,
from functools import lru_cache as lc

@lc
def fib(s):
    if s <= 1:
        return s

    return fib(s-2) + fib(s-1)

for i in range(5_000_000):
    print(f"Fib for {i}: {fib(i)}")

I received,
encodings initialization failed. Only utf-8 encoding will be supported.
ModuleNotFoundError: No module named 'encodings'

The above exception was the direct cause of the following exception:

RuntimeError: Could not import encodings. Is your RUSTPYTHONPATH set? If you don't have access to a consistent external environment (e.g. if you're embedding rustpython in another application), try enabling the freeze-stdlib feature
Traceback (most recent call last):
  File "C:\Users\Rahul\tests\fib.py", line 1, in <module>
    from functools import lru_cache as lc
ModuleNotFoundError: No module named 'functools'

which is rather weird, I understand if functools are not implemented for current implementation of RustPython, but why this encoding errors?
Whats more surprising is that it works on playground,

Did I missed something while compiling?
I compiled just by cargo b --release -j10
Python Documentation
Here is current implementation of functools

It appears to be I compiled RustPython without stdlib, while trying to compile RustPython on Windows with the freeze-stdlib feature. I noticed that the error occurred due to a difference in how Windows and Linux handle symbolic links.
Upon inspecting the source code, I found that the directory being referred to in the code was a symbolic link, which is interpreted differently on Windows than on Linux. As a result, the compilation failed with the following error message:

While digging deep, I was able to find bug and resolve it where I just hardcoded the /Lib directory path in \pylib\src\lib.rs as follows:

Just replaced /Lib with ../Lib.

did you set environment variable RUSTPYTHONPATH but still getting the problem?

did you set environment variable RUSTPYTHONPATH but still getting the problem?

I able to compile RustPython with stdlib and it resolved the issue. But the problem is it doesn't compile on Windows without the change I mentioned in PR #4695.


docs: add instruction to replace perseus_integration

I didn't want to edit your in-depth explanation from the foldable pane, and without that, it would be kind of duplication, so instead, I opted to add a comment to the main.rs example. That way, if someone just copies the code, he'll have information right there, without the need to dig through the page.
I saw other integrations, so I added them, but maybe you don't want them exposed - let me know if you want some tweaking on this.

Requested change applied.

@Arrekin just so you're aware, I've had to undo your code in fixing #212 by aliasing all instances of perseus-integration to perseus-warp, which should hopefully render this a non-issue in future!


Fix incorrect page title of the Sticky demo (#5686)

this closes #5686

@Salamesalehpour Thanks for your contribution 🚀


EVC-105 test reply

EVC-105 Test DO NOT MERGE
Creating a branch env to test the reply-to feature.

Tests passed, closing PR


MicroBitLog uses innerHTML wich leads to XSS attacks

The user is able to inject HTML/Javascript into the data page.
input.onButtonPressed(Button.AB, function() {
    flashlog.clear()
})
flashlog.setTimeStamp(FlashLogTimeStampFormat.Milliseconds)
basic.forever(function () {
    led.toggle(0, 0)
    const ax = input.acceleration(Dimension.X)
	flashlog.beginRow()
    flashlog.logData(`a.x`, `<a href="https://bing.com">${ax}</a>`)
    flashlog.endRow()
})

Recommendation is to use DOM operation to set the value of cells instead of innerHTML.

This issue can be fixed by using innerText or other DOM API rather than innerHTML, but there's a related injection issue due to the use of a comment to package the data.
There's nothing preventing user text terminating the comment, outputting arbitrary HTML/JS (and potentially resuming the comment).
E.g. (in C++ syntax):
uBit.log.logData("xss2", "--><svg onload='alert(2)'><!--");

I think this will have to be addressed on the C++ side.
https://html.spec.whatwg.org/multipage/syntax.html#comments

Thanks @microbit-matt-hillsdon
yep - thanks for the reminder! I always meant to prevent the user from adding --> into the datastream...
If you can patch up my dodgy HTML @microbit-matt-hillsdon  I'll just filter the --> symbol out at ingress?

Why are you using a text format? You could write the data payload a hex buffer and parse it in javascript directly. In such case, you fully control the characters being injected in the HTML source.

I think we should do this if we can. @finneyj what's the background to the comment approach? Is it necessary that we have only a HTML "header" and no trailer?

What happens when the user insert <, >, or - ? Can you guarantee there is no way to escape the comment sandbox?

Writing the encoded data as a hex buffer prevents any class of javascript injection that you are exposing yourself with writing user data in a HTML comment.

Fully agree about HEX encoding being the preferred approach @pelikhan, and with the new version of DAPLink that's precisely the plan. That version can do this encoding for us dynamically on demand, but current (live and deployed) versions of DAPLink don't support this feature.
We could write as a HEX buffer at source at the cost of losing 50% of available data storage (dropping effective data storage from ~120KB to ~60KB). If we can make this approach secure by controlling the data content, it would be preferable,. Otherwise, we either need to force users needing to update DAPLink to be able to the logging features, or drop storage efficiency by 50%.
I can't see why we can't guarantee that all --> symbols are removed. All writes go through a single, line buffered function that writes a single (\n terminated) row to the table. If we scan that line before writing for the -->  symbol, we can strip it, we can close the hole.  Can you see a reason why that wouldn't work @pelikhan?

@microbit-matt-hillsdon The HTML trailer proved irrelevant in testing. All browsers I tested moved the  tags within the DOM to be at end of file. Putting these tags within the 2KB header block just burned storage.

I can't see why we can't guarantee that all --> symbols are removed.

Is there a way to craft those characters in some kind of weird unicode encoding, or generate a malicious input with >,< character that forces the browser so treat the comment as closed? I'm not sure.
What i mean by encoding buffer is generate javascript code with a hex buffer in it, then decode
var data = "abcdadsfasdfjkasldfjasdkfljasdlfkasjfdlkjasdfkj"
// javascript to decode array goes here

I can't see why we can't guarantee that all --> symbols are removed.

Is there a way to craft unicode literals or malicious entries that will treat the browser as a bogus comment and close it sooner than the -->? I don't know. The HTML parser recovers from errors, and it's hard to test for all those cases.

hmm, true - unicode literals could provide a route in that's difficult to catch. We'd have to restrict input further. If we were confident it's just literals, then we could restrict ampersand & too.  If we're more cautious then just alphanumerics.
Alternatively, hexify at source, accept the 50% overhead and send a message that "upgrade your interface firmware to get more storage". Turn a problem into an opportunity for improvement. :)

Moved to v0.2.40 so we can close off the v0.2.39 milestone. I expect that this will be in the minor patchest for *40.

The current implementation (As seen at https://github.com/lancaster-university/codal-microbit-v2/blob/master/source/MicroBitLog.cpp#L678 ) handles the commenting-out attack, and I'd rather keep this for now.
The only way to go with this right now without extensive testing would be a kind of 'paranoid mode' where only alphanumeric ASCII characters are allowed, which would have problems with anyone trying to encode unicode into the strings.
Consequently, I'm going to bump this to 0.2.41, and give us time to correct it properly.

Is there a way to craft unicode literals or malicious entries that will treat the browser as a bogus comment and close it sooner than the -->? I don't know. The HTML parser recovers from errors, and it's hard to test for all those cases.

The key outstanding issue for me is answering this question, but I'd also like to work through the downsides (if any) of limiting ourselves to alphanumerics. I'm not sure what MakeCode supports here either - @pelikhan what kind of strings does MakeCode support?

Can you escape on the html page side and use the dom to populate the table?

The main way to inject via closing an HTML comment has been mitigated, but without any evidence of this being explotable with the existing code then we should leave this as it is.

Until we get a case of someone actually doing this, the existing patches seem to be sufficient, and as trying to guess attack vectors would be a bit like playing 'bug whack-a-mole', I'm going to leave this and we should create new, specific issues for any vectors found in the future.


URL Directory, and Multi-File Support for File Distribution

Proposal

Move some functions to utility files to permit re-usability and to help simplify the argument parser file
Update the logic for master sending locustfiles to the workers so that it can support URLs, directories, and multi-files
Re-use parse_locustfile_paths for workers receiving file paths from master

Opening as a draft, if this looks good I'll create some tests for it

What do you think @DennisKrone ?

Looks ok to me. Just a few things: parse_locustfile_paths_from_master isnt very descriptive of what it does (actually downloading files for instance). And needs type hints. Its a bit sad that it is a breaking protocol change.

Are you losing the ability to detect changes in the file contents?


How to make a standalone dynamic library (instead of an executable)?

Description
Following the documentation at https://github.com/stan-dev/math#installation I have been able to successfully compile the test program.
The issue is that in my use case I would like to call some stan::math functions from another language relying on a dynamic library with C ABI.
To make things more concrete suppose that the test_fun.cpp file looks like this:
#include <stan/math.hpp>

extern "C"
double test_fun(double x)
{
  return stan::math::normal_log(x, 2, 3);
}

Basically I would need something like: make -f path/to/stan-math/make/standalone-dyn-lib test_fun that compiles a dynamic library instead of an executable.
As I am not familiar with makefiles, I have been relying on inspecting the output of make --debug=v -f path/to/stan-math/make/standalone test_fun to figure out the clang++ (I am on OSX right now) command, and appending the -fPIC -shared flags.
This seems to work but I am getting a segmentation fault when the software using this dynamic library terminates, so I am not too confident about whether this approach is appropriate.
Would what I am asking for be easily achievable by modifying the standalone makefile?
Is the flag combination responsible for the segmentation fault I am getting?
For completeness the whole clang++ command is:
$ clang++ -std=c++1y -Wno-unknown-warning-option -Wno-tautological-compare -Wno-sign-compare -D_REENTRANT       -I /Users/sp/prj/math/lib/tbb_2019_U8/include -O3  -I /Users/sp/prj/math/ -I /Users/sp/prj/math/lib/eigen_3.3.3 -I /Users/sp/prj/math/lib/boost_1.72.0 -I /Users/sp/prj/math/lib/sundials_4.1.0/include    -DBOOST_DISABLE_ASSERTS            -Wl,-L,"/Users/sp/prj/math/lib/tbb" -Wl,-rpath,"/Users/sp/prj/math/lib/tbb"  test_fun.cpp          /Users/sp/prj/math/lib/sundials_4.1.0/lib/libsundials_nvecserial.a /Users/sp/prj/math/lib/sundials_4.1.0/lib/libsundials_cvodes.a /Users/sp/prj/math/lib/sundials_4.1.0/lib/libsundials_idas.a /Users/sp/prj/math/lib/sundials_4.1.0/lib/libsundials_kinsol.a  /Users/sp/prj/math/lib/tbb/libtbb.dylib /Users/sp/prj/math/lib/tbb/libtbbmalloc.dylib /Users/sp/prj/math/lib/tbb/libtbbmalloc_proxy.dylib -fPIC -shared -o test_fun.dylib

Thank you in advance for any help!
Current Version:
HEAD as of this issue submission time.

Hello @stepelu, what you need can be done with a few additional lines in the original standalone makefile. Here is the modified file https://gist.github.com/IvanYashchuk/d2e878cd5a7402ecaaf2b7e6b5f59bcd
Run it with make -f standalone-shared-lib.make test_fun.so and it will produce the shared library that you can later link to other programs.
I think OSX supports both -shared that produces .so files and -dynamiclib flags that produce .dylib. If you want .dylib extension try adding to the makefile
%.dylib: %.o
	$(CXX) -dynamiclib $< -o $@


CSS framework?

Let's pick which CSS framework we should use. I like both Bootstrap and Foundation. I worked with Foundation most recently because it used Sass but Bootstrap is using Sass now. There are also some minimal frameworks that could be interesting to experiment with.

[ ] Bootstrap
[ ] Foundation
[ ] http://www.basscss.com/
[ ] https://milligram.github.io/
[ ] http://purecss.io/

+1 For bootstrap.


Minor release 2.4

[2.4]
Changed

Updated version of external images in GitHub actions
Updated API submission schema to the latest
Demo variant to take care of "Somatic mutation" no longer available among Mode of inheritance choices
clinicalSignificance.clinicalSignificanceDescription value extracted from Clinical significance or Germline classification column
clinicalSignificance.comment values extracted from Comment on clinical significance or Comment on classification column

Fixed

Bump certifi from 2022.12.7 to 2023.7.22
Description of the response returned by dry run endpoint in README file
Migrate from deprecated pkg_resources lib to importlib_resources
Updated python-multipart from 0.0.5 to 0.0.7 to address security alert by dependabot

Review:

[ ] Code approved by
[x] Tests executed by CR

This version is a:

[ ] MAJOR - when you make incompatible API changes
[x] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (846cec9) 95.12% compared to head (bccc525) 95.15%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   95.12%   95.15%   +0.02%
==========================================
  Files          10       10
  Lines         431      433       +2
==========================================
+ Hits          410      412       +2
  Misses         21       21

Flag
Coverage Δ

unittests
95.15% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Deployed on prod now!


FIX [trantest] make sure recv aio get the msg.

Codecov Report
Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (bb6f17f) 53.76% compared to head (1301e66) 53.73%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   53.76%   53.73%   -0.03%
==========================================
  Files         120      120
  Lines       36425    36424       -1
==========================================
- Hits        19584    19574      -10
- Misses      16841    16850       +9

see 16 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Define testing strategy for istio modules

Some modules depends on each other, and its not clear where the test should live in that case. We need to understand each module dependencies and define a strategy

Closing this. This will go on the test policy https://github.com/istio/istio-testing/issues/146.


Fix dialyzer warning for couch_att:from_disk_term

Overview
The couch_att:from_disk_term function is responible for conversion of
a disk format to #att{} record. However the way it is called
produces a dialyzer complaint.
Because couch_att:from_disk_term is always called as
[couch_att:from_disk_term(Db, T) || T <- Doc1#doc.atts].
The atts field of #doc{} record is defined as
[couch_att:att()] | binary()
This is problematic because att() definition doesn't include disk
format representation. This commit adds disk format to the spec.
Testing recommendations
Run dialyzer tool and make sure there are no complains about couch_att:from_disk_term

Prepare for analysis:

make build-plt

Run analysis

make dialyze apps=couch

The dialyzer might fail but it shouldn't fail in analysis of couch_att.
Checklist

[x] Code is written and works correctly;
[ ] Changes are covered by tests;
[ ] Documentation reflects the changes;

src/couch_att.erl:181: Function new/0 has no local return
src/couch_att.erl:188: Record construction #att{name::'undefined',type::'undefined',att_len::'undefined',disk_len::'undefined',md5::<<>>,revpos::0,data::'undefined',encoding::'identity'} violates the declared type of field name::binary() and type::binary() and att_len::non_neg_integer() and disk_len::non_neg_integer() and data::'follows' | 'stub' | binary() | fun(() -> binary()) | {_,_} | {'follows',pid(),reference()}
src/couch_att.erl:192: Function new/1 has no local return
src/couch_att.erl:408: Function from_json/2 has no local return
src/couch_att.erl:422: Function stub_from_json/2 will never be called
src/couch_att.erl:435: Function follow_from_json/2 will never be called
src/couch_att.erl:445: Function inline_from_json/2 will never be called
src/couch_att.erl:464: Function encoded_lengths_from_json/1 will never be called
src/couch_att.erl:477: Function digest_from_json/1 will never be called

Looks good no from_disk_term errors


Regig options, remove zap in favour or klog

This PR re-gigs the options and help output of policy-approver to be more in line with other cert-manager projects.
We also swap out zap with klog for the same reason.
/assign @charlieegan3

/retest

/lgtm


Add a question to "javascript-quiz.ts" file, about what will be the returned value, if property of typeof is been called on variable that was declared but was not assigned any value in Javascript.

Checklist:

[x ] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

Please, let me know if there is anything you want me to add or remove or correct. Thank you.

Thank you for the suggestion @jdwilkin4. I've confirmed the changes now. Let me know if everything is ok. Thank you

Thank you @jdwilkin4 I will add the second branch.


fdw: Add foreign data wrappers to read snapshots on s3, gcs or azure

Problem Statement
Keeping all data forever in CrateDB can get expensive.
Deleting the data isn't an option, because it might still be needed, but it is not queried often.
Having an option to use cheaper storage option at the expense of query performance would be nice.
Possible Solutions
Backups already exist in the form of snapshots. These snapshots could be exposed via a foreign table wrapper/foreign table to be able to query them ad-hoc.
Advantages:

No need for additional data exports
Infrastructure is already setup if there are backups
Snapshots contain segments file, we might be able to use the Lucene structures to do filters more efficiently than with alternative file formats.
Full control over optimization possiblities, as we control the format.

Downsides:

Snapshot format compatibility with major version updates(?)
Others?

Considered Alternatives

https://github.com/crate/crate/issues/15721

Technical constraints

Should be implemented outside the server module and the hardcoded map in ForeignDataWrappers should be replaced via a service loader. This relates to https://github.com/crate/crate/issues/15720 - except that it can be completely undocumented/private, similar to other service loaders like for Functions

Initial Scope (estimate is only for this)

Simple but slow version; No caching of downloaded data; Always reads from remote as neeeded; No attempts at operation push-down or partial result retrieval.

Follow up (for later dedicated issues, not included in the first implementation)

[ ] Download only required data to minimize traffic; And maybe add cache for the remote data to avoid repeated downloads
[ ] Index utilization; Retrieve metadata/index files, then only fetch required documents.

Hello! Сan I take this issue?


kodiPackages.pvr-iptvsimple: 7.4.2 -> 7.5.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/kodi-pvr-iptvsimple/versions.
meta.description for kodiPackages.pvr-iptvsimple is: "Kodi's IPTV Simple client addon"
meta.homepage for kodiPackages.pvr-iptvsimple is: "https://github.com/kodi-pvr/pvr.iptvsimple"
meta.changelog for kodiPackages.pvr-iptvsimple is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 7.5.0 with grep in /nix/store/i3hbr363rxipbnrn779fizgcirryckqf-kodi-pvr-iptvsimple-7.5.0

directory tree listing: https://gist.github.com/a064b99e1282c49fc57cbcb05d98d077

du listing: https://gist.github.com/5f1e3de3aba02e19bf634348e5034af9

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
kodiPackages.pvr-iptvsimple

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i3hbr363rxipbnrn779fizgcirryckqf-kodi-pvr-iptvsimple-7.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kodiPackages.pvr-iptvsimple https://github.com/r-ryantm/nixpkgs/archive/0d8dd5a485f9fc9412ca1789f892e56511cab387.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i3hbr363rxipbnrn779fizgcirryckqf-kodi-pvr-iptvsimple-7.5.0
ls -la /nix/store/i3hbr363rxipbnrn779fizgcirryckqf-kodi-pvr-iptvsimple-7.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

kodiPackages.pvr-iptvsimple

Maintainer pings
cc @aanderse @cpages @edwtjo @minijackson @peterhoeg @sephalon for testing.

see #117430 instead


Adding multiple project partners causes problems

Hi,
we are running RDMO at DKRZ under the following configuration:

CentOS 7
Postgresql 13.5
Python 3.6.8
RDMO 1.6.2
Django 3.2.9
Webserver Nginx (1.20.1-9) with gunicorn (19.9)

We have a problem after having updated to the most recent version of RDMO:
When creating a clean new project and adding new project partners and clicking "save and proceed", adding a new partner afterwards leads to unexpected behaviour (see attached), i.e. the new partner is not added to the list of tabs, but the name of a random other partner ("the bird" in this case) is repeated and the detail description of the partner is also duplicated.
We have not checked if this also happens with other types of entries, e.g. project coordination, datasets, etc.
We cannot trace this back to an error, since the error log of our RDMO instance shows no entry for this behaviour.
Thanks!
RDMO_PartnerError_DKRZ_211125.pdf

Hi @karstenpeters , thanks for finding this bug. It seems it can happen with all collection questionsets. It is a bit tricky to reproduce. I only happens when you reload with existing partners, but it should fail with datasets and funders as well. The fix will be included in the new version next week.

Thanks a lot indeed!

On 25. Nov 2021, at 17:05, Jochen Klar @.***> wrote:
Hi @karstenpeters https://github.com/karstenpeters , thanks for finding this bug. It seems it can happen with all collection questionsets. It is a bit tricky to reproduce. I only happens when you reload with existing partners, but it should fail with datasets and funders as well. The fix will be included in the new version next week.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/rdmorganiser/rdmo/issues/413#issuecomment-979327767, or unsubscribe https://github.com/notifications/unsubscribe-auth/APUAZPSP5TOMXSWEDVVE3GLUNZNC7ANCNFSM5IYV237Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

—
Dr. Karsten Peters-von Gehlen
Data Management Service Communicator
Department Datenmanagement
Deutsches Klimarechenzentrum GmbH (DKRZ)
Bundesstraße 45 a ● D-20146 Hamburg ● Germany
Phone:	+49 40 460094-138
FAX:	+49 40 460094-270
Email:	@.*** @.***>
ORCID: 	0000-0003-0158-2957 https://orcid.org/0000-0003-0158-2957
URL:	https://www.dkrz.de/about-en/staff/dr-karsten-peters https://www.dkrz.de/about-en/staff/dr-karsten-peters
Geschäftsführer: Prof. Dr. Thomas Ludwig
Sitz der Gesellschaft: Hamburg
Amtsgericht Hamburg HRB 39784


Issue 45866: kimageformats:kimgio_jxl_fuzzer: Integer-overflow in jxl::palette_internal::GetPaletteValue

This issue was found by oss-fuzz, which is testing Qt plug-in for JXL format. libjxl 0.6.1 is used.
Test file:
oss-fuzz_45866.zip
Please verify whether the issue is serious or not and/or whether it was resolved meanwhile.
/src/libjxl/lib/jxl/modular/transform/palette.h:87:14: runtime error: signed integer overflow: 128 * 16777216 cannot be represented in type 'int'
	 #0 0x5d222a in jxl::palette_internal::GetPaletteValue(int const*, int, unsigned long, int, int, int) libjxl/lib/jxl/modular/transform/palette.h:87:14
	 #1 0x5d47ca in operator() libjxl/lib/jxl/modular/transform/palette.h:264:21
	 #2 0x5d47ca in jxl::ThreadPool::RunCallState<jxl::Status (unsigned long), jxl::InvPalette(jxl::Image&, unsigned int, unsigned int, unsigned int, jxl::Predictor, jxl::weighted::Header const&, jxl::ThreadPool*)::$_5>::CallDataFunc(void*, unsigned int, unsigned long) libjxl/lib/jxl/base/data_parallel.h:88:14
	 #3 0x4fd308 in jxl::ThreadPool::SequentialRunnerStatic(void*, void*, int (*)(void*, unsigned long), void (*)(void*, unsigned int, unsigned long), unsigned int, unsigned int) libjxl/lib/jxl/base/data_parallel.cc:18:5
	 #4 0x5d44ae in Run<jxl::Status (unsigned long), (lambda at /src/libjxl/lib/jxl/modular/transform/palette.h:255:11)> libjxl/lib/jxl/base/data_parallel.h:51:12
	 #5 0x5d44ae in bool jxl::ThreadPool::Run<jxl::InvPalette(jxl::Image&, unsigned int, unsigned int, unsigned int, jxl::Predictor, jxl::weighted::Header const&, jxl::ThreadPool*)::$_5>(unsigned int, unsigned int, jxl::ThreadPool::SkipInit, jxl::InvPalette(jxl::Image&, unsigned int, unsigned int, unsigned int, jxl::Predictor, jxl::weighted::Header const&, jxl::ThreadPool*)::$_5 const&, char const*) libjxl/lib/jxl/base/data_parallel.h:60:12
	 #6 0x5cfec5 in RunOnPool<jxl::ThreadPool::SkipInit, (lambda at /src/libjxl/lib/jxl/modular/transform/palette.h:255:11)> libjxl/lib/jxl/base/data_parallel.h:0:9
	 #7 0x5cfec5 in jxl::InvPalette(jxl::Image&, unsigned int, unsigned int, unsigned int, jxl::Predictor, jxl::weighted::Header const&, jxl::ThreadPool*) libjxl/lib/jxl/modular/transform/palette.h:253:7
	 #8 0x5cf6e9 in jxl::Transform::Inverse(jxl::Image&, jxl::weighted::Header const&, jxl::ThreadPool*) libjxl/lib/jxl/modular/transform/transform.cc:32:14
	 #9 0x5cc473 in jxl::Image::undo_transforms(jxl::weighted::Header const&, int, jxl::ThreadPool*) libjxl/lib/jxl/modular/modular_image.cc:20:23
	 #10 0x71cd93 in jxl::ModularFrameDecoder::FinalizeDecoding(jxl::PassesDecoderState*, jxl::ThreadPool*, jxl::ImageBundle*) libjxl/lib/jxl/dec_modular.cc:605:6
	 #11 0x6ea6b2 in jxl::FrameDecoder::Flush() libjxl/lib/jxl/dec_frame.cc:830:3
	 #12 0x6e187b in jxl::FrameDecoder::FinalizeFrame() libjxl/lib/jxl/dec_frame.cc:927:3
	 #13 0x515eee in jxl::(anonymous namespace)::JxlDecoderProcessInternal(JxlDecoderStruct*, unsigned char const*, unsigned long) libjxl/lib/jxl/decode.cc:1340:28
	 #14 0x5119ef in JxlDecoderProcessInput libjxl/lib/jxl/decode.cc:1755:14

I think https://github.com/libjxl/libjxl/pull/1155 should resolve this.


Sync the code documentation from the README to the source files

This should help readers understand the code.
Also drop outdated documentation and polish the existing prose.
Fixes #300

Thanks a lot!


Request OSS status with Lightbend pending Akka license changes

The Akka license is changing: https://www.lightbend.com/blog/why-we-are-changing-the-license-for-akka to a paid model for "production" use with exceptions for open source projects.
Wellcome Collection uses Akka libraries in many places, we should apply for exemption for production use.

Ping @alexwlchan

Closed by https://github.com/wellcomecollection/platform/issues/5754


Check value type to avoid errors

It would be nice, if you could add Fixes #13046 at the end of the commit message, so the issue is automatically closed when(/if) the PR gets merged.
You might also want to take a look at our commit message conventions. It's not a biggy (i.e. we can take care of it when merging), but it saves us time.

Hey, it just occurred me:
We need a test, to guard this fix against future regressions :)


It extends docblock when hitting enter on the closing tag.

When there's no extra space on the closing tag, hitting enter adds an extra * on the next line (outside the comment block).
Ex:
/**
 * Some text.
*/<enter here>
*

Changing the 'extend' regex to this, will prevent extension on lines that don't start with * or contain */, which I believe is the desired behaviour: /^\s*(?=\*)(?:(?!.*\*\/)\*)/

I can reproduce this and your regex seems right, I will change this. But why not just this?
/^\s*\*(?!.*\*\/)/

That should work too. Thanks.


Process log is too long for id [N] truncating executions

I'm getting a lot of the following errors in my rancher/server log:
2015-10-19 16:19:18,379 ERROR [:] [] [] [] [ecutorService-9] [i.c.p.e.m.i.j.JooqProcessRecordDao  ] Process log is too long for id [49214] truncating executions

This is followed by a really long JSON blob.

Full logs, database dumps, etc. available on request.

I wonder if this is related to your issue in https://github.com/rancher/rancher/issues/2339#issuecomment-150337370

Not seeing it in the logs for my new Rancher Server instance...

I bet it's related so I'll label as a performance issue to investigate when we start looking how to improve it.

Please re-open if you are still seeing this.


Support request by Brett DeFoy: enable contributor access to LintDiff (azure-openapi-validator)

As reported in the email thread with subject Merge access for azure-openapi-validator
Brett's team is submitting PRs to LintDiff to add rules for ARM API specs. It lost access due to reorg. Wes gave some permissions already, but more might be needed.
Per weshaggard's remark:

As for the staging to production pipeline I’ve added konrad-jamrozik and scbedd from my team that will likely be helping to partner with you guys on this validation tool

This thread is ongoing - permissions have been granted and possibly a PR review will be in order. See the email thread for details.

This is still ongoing.
Wes mentioned:

As for further assistance I think the one aspect still to be determined is how and when to publish this package.

There is a PR out with my question on it:

https://github.com/Azure/azure-openapi-validator/pull/481#issuecomment-1485979044

There is also this discussion:

Akhila: Also, Brett came across a document which said we need to mark the rules as warning's and keep it that way until the initial 6 months in the prod pipeline, wanted to know how accurate that is?
Konrad: Can you share a link to the doc mentioning the marking rules as warning?

This thread is still ongoing; see email thread for updates.

I am closing this work item with a follow-up focusing on the exact task:

https://github.com/Azure/azure-sdk-tools/issues/6071


socket.io client experiences "SyntaxError: Unexpected token \ in JSON at position 1"

socketio server in rust main.rs
extern crate iron;
extern crate socket_io;

use iron::prelude::Iron;

fn main() {
    let server = socket_io::server::Server::new();

    server.on_connection(|so| {

        println!("connected to {}", so.id());
        so.send(("Hello, world!").as_bytes().to_vec())
    });

    println!("listening");
    Iron::new(server).http("localhost:3000").unwrap();}

nodejs socket.io-client code:
const socket = require('socket.io-client')('http://localhost:3000');

console.log('starting...');

socket.on('connect', function(){
    console.log('on_connect!');
});
socket.on('event', function(data){
    console.log('on_event!');
    console.log({
        event:data,
    });
});
socket.on('disconnect', function(){
    console.log('on_disconnect!');
});

nodejs socket.io-client error message:
[nodemon] starting `node server server.js`
starting...
undefined:1
{\"sid\":\"d1da1ad3a3499b3cba51f78c2da82acc8c9c49b8894c931eb7f826a5440c8217\",\"upgrades\":[],\"pingTimeout\":60000,\"pingInterva
 ^

SyntaxError: Unexpected token \ in JSON at position 1
    at Object.parse (native)
    at parsejson (/home/forge/code/rust-broadcast-node-test/node_modules/parsejson/index.js:24:17)
    at Socket.onPacket (/home/forge/code/rust-broadcast-node-test/node_modules/engine.io-client/lib/socket.js:426:26)
    at XHR.<anonymous> (/home/forge/code/rust-broadcast-node-test/node_modules/engine.io-client/lib/socket.js:258:10)
    at XHR.Emitter.emit (/home/forge/code/rust-broadcast-node-test/node_modules/component-emitter/index.js:134:20)
    at XHR.Transport.onPacket (/home/forge/code/rust-broadcast-node-test/node_modules/engine.io-client/lib/transport.js:143:8)
    at callback (/home/forge/code/rust-broadcast-node-test/node_modules/engine.io-client/lib/transports/polling.js:145:10)
    at Object.exports.decodePayload (/home/forge/code/rust-broadcast-node-test/node_modules/engine.io-parser/lib/index.js:298:19)
    at XHR.Polling.onData (/home/forge/code/rust-broadcast-node-test/node_modules/engine.io-client/lib/transports/polling.js:149:10)
    at Request.<anonymous> (/home/forge/code/rust-broadcast-node-test/node_modules/engine.io-client/lib/transports/polling-xhr.js:124:10)
[nodemon] app crashed - waiting for file changes before starting...

cargo -V
cargo 0.12.0-nightly (3fcbb10 2016-07-03)

It looks to me that this rust library is adding extra slashes to the JSON it sends to the client, but I don't know enough about the internals of engine.io. Is this a bug or am I doing something wrong?

For reference, I'm not having this issue when using https://github.com/googollee/go-socket.io instead of https://github.com/vibhavp/socket.io-rs

Could you try the same on a browser with JSONP as the transport? IIRC, this bug is due to nodejs using XHR, which I was having trouble implementing.

I'll try again like that, but it may be a few days before I report back.


Error when compiling on i389 LXC container

I am trying to run substrate-node-template in ubuntu LXC container and I keep getting the error
container details:
Distribution: "ubuntu",
Release : "bionic" (18.04 LTS)
Architecture: "i386"
Error:
Compiling fdlimit v0.2.0
error[E0308]: mismatched types
--> /root/.cargo/registry/src/github.com-1285ae84e5963aae/fdlimit-0.2.0/src/lib.rs:108:8
|
108 |         Some(rlim.rlim_cur)
|              ^^^^^^^^^^^^^
|              |
|              expected u64, found u32
|              help: you can convert an u32 to u64: rlim.rlim_cur.into()`
error: aborting due to previous error
it seems the package is not compatible with i389 containers, I replaced my container with amd64 architecture and that works.

@ Devs: rlim_cur can be either u32 or u64, depending on the OS/CPU (https://github.com/rust-lang/libc/commit/7ff62a4e5089be6a82275ceae26aacecaed6b27b).
The function raise_fd_limit does return Option<u64> though.
https://github.com/paritytech/fdlimit/blob/9bea0da1a3c4955bd2e280dea364d41fd8f21d04/src/lib.rs#L88-L110

Seems like this was already fixed in 0.2.1  https://github.com/paritytech/fdlimit/blob/1cec4ad03246f5c216f88605a00ad4866fe86028/src/lib.rs#L108
One thing that could be done is to upgrade the README to recommend using 0.2.1, currently it recommends using the bugged 0.2.0:

add in Cargo.toml:
[dependencies]
fdlimit = "0.2.0"


[Feature Request] Option to display trailing whitespaces in row/column data

I would like to be able to see trailing whitespaces in data fields in my SQL tables.
For example, assume the value test  in the following query:
insert into `player` ( `name` ) values ( "test " )
This way I currently can't see the whitespace in "test", leading me to face some bugs in my application. It would be easier for me if DBeaver displayed the whitespace somehow.
It could be enabled in the settings menu, preferably.

Thank you for the suggestion. We already have such option. You can enable it in Preferences>Editors>Text Editors


Ndhotkey fixes

Replaces #1147
Who'd have thought this would be so simple. Just needed to import the latest NDHotKey classes.
Try following the steps at #1134 to test. Looks like this also fixes #2418 as well:

Force-pushes just fixed some submodule checkout stuff that wasn't working properly in the GH actions. Nothing changed in the code.
(Note to self: a submodule's parent folder should be checked-in to git, so that the reference/link is there)

This is even more exciting to me than the possibility of getting a native M1 build. ♪♪ ヽ(ˇ∀ˇ )ゞ

Seems to fix displaying the higher-numbered function keys as well.

10 years in the making, such a simple fix :)
Thanks Rob for merging


Added missing Docker capability flag to enable Singularity

IIRC, @bbockelm was surprised by this requirement

I have verified it is required on a fully upgraded EL7 system

Is Singularity working in privileged or unprivileged mode in this case?

Privileged. I have not explored unprivileged within Docker.


ENABLE_LOGROTATION = False with multiple carbon daemons

I think the code that supports "logrotate" log rotation is not working under multiple carbon daemons.
log.py:
  def write(self, data):
    if not self.enableRotation:
      if not os.path.exists(self.path):
        self.reopen()
    DailyLogFile.write(self, data)

If you are running multiple daemons, as soon as one daemon notices the log file has rotated it will create a new one. Then for the other daemons os.path.exists(self.path) will be true (seeing the other daemon's newly created file), so they will not reopen their log file and will continue writing to the old file.
As a result you end up with a situation like this:
$ sudo lsof console.log*
COMMAND     PID   USER   FD   TYPE DEVICE SIZE/OFF    NODE NAME
carbon-ca 40009 carbon    6u   REG  253,0<PHONE_NUMBER>133 console.log.2016_4_26
carbon-ca 50485 carbon    6u   REG  253,0   798915  574424 console.log.2016_4_23
carbon-re 50563   root    6u   REG  253,0    10090 2728960 console.log

#550

The default settings from carbon.conf.example show how to set ENABLE_LOGROTATE, but don't clearly indicate that since the example is in the [cache] section, it doesn't apply to relay processes unless added to the [relay] section.

PR is merged, closing


sitemap function applying toString() to lastmod field

It seems as though the sitemap function is applying a toString() to the lastmod field, which messes up js date formatting. This may be something you're unable to change, but just so you're aware passing js dates doesn't work as expected.
`export const sitemap = async () => {
const brands = await getAllBrands();
/**TODO: one day make this accurate */
const lastModified = new Date();
lastModified.setMonth(lastModified.getMonth() - 1)

// toString() is messing this up
console.log(lastModified)

return brands.map(brand => ({
    loc: `/products/${brand.name}`,
    lastmod: lastModified //toString() seems to be applied here, converting the output from ISO format to
    //"Thu Jul 27 2023 19:25:17 GMT-0400 (Eastern Daylight Time)",
    images: [{ loc: `https://storage.googleapis.com/example-logos/${brand.logoUri}` }]
}));

}`
Resulting in this:
<lastmod>Thu Jul 27 2023 19:25:17 GMT-0400 (Eastern Daylight Time)</lastmod>
But needs to be this:
<lastmod>2023-08-27T23:25:17.083Z</lastmod>

perhaps add into the docs that you have to use .toISOString()


Error:  Cannot read property 'range' of null at Array.forEach ()

Hi guys,
I just added ESLint to my project and it crashed after that. Do you know what is wrong with this? It seems to be something related to eslint-plugin-react.
My eslint file:
module.exports = {     "extends": "airbnb",     "parser": "babel-eslint",     "globals": {         "fetch": true,         "localStorage": true,         "window": true,         "document": true     },     "rules": {         "linebreak-style": ["error", "windows"],         "global-require": 0,         "import/no-dynamic-require": 0,         "eol-last": 0,         "react/jsx-one-expression-per-line": 0,         "import/prefer-default-export": 0,         "camelcase": "warn",         "react/destructuring-assignment": "warn",         "react/prop-types": "warn",         "import/no-cycle": "warn",         "import/no-duplicates": "warn",         "no-unused-vars": "warn",         "max-len": "warn"     } };
The error:

./src/components/Perfil/progress/Progress.jsx
Module build failed: TypeError: Cannot read property 'range' of null at Array.forEach ()

And the first error line shown in the console:

Uncaught Error: Module build failed: TypeError: Cannot read property 'range' of null
at Object.fixer [as fix] (C:\Users\X\Desktop\Y\Z\client\node_modules\eslint-plugin-react\lib\rules\jsx-wrap-multilines.js:145:51)

I can post the full console error if necessary.
Thank you :)

Issue solved running prettier. I wasn't aware of the chance that the app could crash with eslint and thought it was something related to the lib version. Thanks anyway :)

It's definitely a bug; it shouldn't crash. "using prettier" isn't a solution.
Could you provide the code that it's erroring on?

Hey ljharb,
It was the way my colleague was declaring the functional component. He did const ComponentX = props =>
....More JSX...
 without brackets. Changing to const ComponentX = props =>(
....More JSX...
); solved the issue.

hmm, the parens shouldn't make a difference. Let's leave this open until we can reproduce.

@luismendes535 I'd also ask for ESLint version and eslint-plugin-react version. We do have similar test cases that are passing right now.

Alex, here I have the devDependecies and also the eslintConfig object because I notice that I'm extending the react-app config here in the package.json and in the eslintrc.js file I extend the airbnb config: "extends": "airbnb" . Is anything wrong with this?
  "eslintConfig": {     "extends": "react-app"   }, "devDependencies": {     "eslint": "^4.19.1",     "eslint-config-airbnb": "^17.1.0",     "eslint-plugin-import": "^2.14.0",     "eslint-plugin-jsx-a11y": "^6.1.1",     "eslint-plugin-react": "^7.11.1"   },
I might be setting up something wrong, I will take a deeper look later this weekend.

Having both eslintConfig and eslintrc seems very wrong; I’m not sure which eslint prefers but I’d recommend deleting one.

Thanks Ijharb,
The eslintConfig inside the package.json comes with 'create-react-app' and it seems to not cause any trouble, either deleting or keeping it.
I tried to reproduce the error that I had before deleting the brackets and this time around everything works properly.
I'm not sure about the solution but following the follow steps worked for me:

npm info "eslint-config-airbnb@latest" peerDependencies
npm install --save-dev eslint-config-airbnb<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Add emitWarning: true inside eslint-loader options.

Ah - when ejecting CRA app you end up with invalid dependencies; that’s indeed the solution.
You should delete the eslintConfig in your package.json, it’s left over from before you ejected.


new release

i plan on making a new release of this module once #148 gets into shape (fixing #145 and #150 hopefully) since we need this so that the module doesn't conflict with latest apt (> 7).
objections?

oops, dupe of #157 sorry.


Change representation of heading and direction

Currently, headings and directions are represented by strings of N, E, W, S. It would be better to instead use numerical values (0..360). This is more general, and would allow later extensions that do not strictly follow the grid of squares (such as flying agents that can go diagonally). Also, the rendering of graphics and other operations become more straightforward.

Fixed.


chore(content): add external link for demos to show content in new window

Deploy preview for pf-next ready!
Built with commit 6420be662ff0be570ee725de852ce3a0fae114d4
https://deploy-preview-225--pf-next.netlify.com


Memory Leak when using useDrag and useDrop hooks

Describe the bug
Potential memory leak.
After drag and drop elements are removed from the DOM, the elements remain in memory as detached HTML elements and memory is not released.
Reproduction
Below is essentially the drag and drop list reordering example from the documentation with the addition of a button to toggle its inclusion in the DOM.
Sandbox
Steps to reproduce the behavior:

Load the sandbox
Open dev tools (chrome) - head to the Memory tab
Select the app's JavaScript VM instance
Take a snapshot
Click the "Show"/"Hide" button to toggle the inclusion of the sortable list.  In this example, I've done this cycle 3 times.
Take another snapshot
View the objects created between snapshots 1 and 2
Notice an internal array with 21 detached HTMLDivElement entries (7 list entries * 3 renderings)

Expected behavior
My expectation is that once removed from the DOM, these elements would be released from memory.  Instead, they remain and potentially cause other objects to be retained causing potential memory issues.
Screenshots

Desktop:

OS: Windows
Browser: chrome
Version: 87

Additional Info
I may be misinterpreting the tooling here, if that's the case my apologies.  I also have not seen any documentation about manually cleaning up these kinds of references - if that exists somewhere I must have missed it.

I'm fairly certain now that the issue is not within the HTML5 backend.  After looking through the react-dnd package's test code, I saw that there was a test asserting that drag and drop connections were unsubscribed if null was passed instead of an actual object.
To that end, as a workaround, you can change the normal
drag(drop(ref));

to
useLayoutEffect(() => {
  drag(drop(ref));
  return () => {
    drag(null);
    drop(null);
  };
}, [drag, drop, ref]);

and it seems to avoid the retaining of detached dom elements.  As seen in this updated sandbox (I'm not actually sure if it's better to go with useLayoutEffect or useEffect here but you get the idea hopefully)
But I would think that a better solution would be fore the actual react-dnd hooks of useDrag and useDrop to do this instead.
useDrop for instance contains the following code in its implementation:
useIsomorphicLayoutEffect(() => {
  connector.dragSourceOptions = specRef.current.options || null
  connector.reconnect()
}, [connector])
useIsomorphicLayoutEffect(() => {
  connector.dragPreviewOptions = specRef.current.previewOptions || null
  connector.reconnect()
}, [connector])

and I wonder if it would be better if it was instead changed to something like
useIsomorphicLayoutEffect(() => {
  connector.dragSourceOptions = specRef.current.options || null
  connector.reconnect()
  return connector.disconnect
}, [connector])
useIsomorphicLayoutEffect(() => {
  connector.dragPreviewOptions = specRef.current.previewOptions || null
  connector.reconnect()
  return connector.disconnect
}, [connector])

with a similar change being made for useDrag.  The connector's disconnect method would be something like
public disconnect() {
  this.disconnectDragSource()
  this.disconnectDragPreview()
}

and
public disconnect() {
  this.disconnectDropTarget()
}

for the common SourceConnectors and TargetConnectors modules respectively.
I'm not sure if this makes sense / is an appropriate suggestion, as it's entirely possible that I'm misinterpreting one or more things here.

Hey! 👋
When calling React-DOM's unmountComponentAtNode, our SPA wasn't removing the listeners attached by React DND + the HTML5 backend.
I went down the same investigation pattern that @jaydavid followed... and only then I discovered this open issue.
I can confirm what @jaydavid is describing: React DND hook callbacks weren't being invoked for us — and manually passing null to the hook results (drop/drag) does fix the issue.
I'm not familiar with React DND, but I guess this is more of a bug than the expected behavior, right?
Let me know if I can add more context to help investigate the source of the problem.

I found an interesting handler registration issue tonight that may have been affecting you if you were using the hooks-based API. The latest version of react-dnd (13.0.1) should fixes the issue I found. I'll have to dig into your sandbox later to see if it fixes this issue as well.


nix: add lwt

We don't need lwt when building notty, but it is required when building the tests. The tests are useful to check how things look.

@rgrinberg It seems GitHub actions from outside this organization are disallowed:
https://github.com/ocaml-dune/notty/actions/runs/6485547263


Newly added secondary contact field doesn't have focus when using keyboard navigation [2]

Describe the Bug:
Probability (how likely the bug is to happen, scored from 1-5): 1
(For example, probability of 5 is something like "it happens to all users every time they log in."
Probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")
Effect (how bad the bug is when it does happen, scored from 1-5): 1
(For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected."
Effect of 1 is "It makes some styling look a little bit weird.")
Steps to reproduce the behaviour:

in localhost
use keyboard navigation to navigate to the add secondary contact button and hit enter to click it
there's no focus on the secondary contact dropdown so you have to tab through half the page to get back to it

Screenshots:
https://www.loom.com/share/1f4c44010814487d80982d00c7621dd1
Additional information:

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]
Additional context

@nanyangpro @suhafa we would need to determine if this is a behaviour we would like, and if it's something that is recommended in terms of accessibility and user interaction:

moving the focus automatically to a different control
is the behaviour different when using the keyboard or the mouse?


refactor(config): uniformize environment variables

Current dependencies on/for this PR:

main

PR #81

PR #82

PR #83

PR #84

PR #85

PR #86   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: 🔄 Waiting for checks to pass
This pull request is currently waiting for CI and mergeability checks to pass before being merged.
This comment was auto-generated by Graphite.

Job Reference: WMaDhgzSyZLMN10U1aZP


Breaks ChatGPT

Breaks the Mac app MacGPT as well as the safari website. Disabling Hush, relaunching safari fixes the problem.

ChatGPT works for me

Cannot reproduce


Surfaceview preview stretching

[ ] I have verified there are no duplicate active or recent bugs, questions, or requests
[ ] I have verified that I am using the latest version of Material Camera.
[ ] I have given my issue a non-generic title.

Include the following:

Material Camera version: 0.3.0

Device OS version: 6.0

Device Manufacturer: Lenovo

Device Name: Vibe X3

Material Camera version: 0.3.0

Device OS version: 5.1

Device Manufacturer: Redmi

Device Name: Prime2

Reproduction Steps

Integrated libarary 0.3.0
Open Camera Preview
Camera preview looks stretched

Expected Result

Camera preview should support (best preview) for all the devices.

Actual Result

Camera previews are not supporting looks stretch, after captured photo its looking good.

Stretched camera preview also on Samsung Galaxy Note 5 using library version 0.3.0

Managed to solve this by adding:

When the aspect ratio is set to 4/3 the SurfaceView is still stretched to fit the screen which causes the image to stretch

The SurfaceView fits the screen size. So it's stretched

https://github.com/afollestad/material-camera/issues/90


Do a sweep on docs organisation

I'm depressed so I'm not going to do with, bring on the alpha

:-( let's call for help if necessary don't overdo yrself


fix: don't complete attribute value for v-else

Before:
https://user-images.githubusercontent.com/17216317/115713186-4dcc4d00-a3a8-11eb-9751-928f8bb3b068.mp4
After:
https://user-images.githubusercontent.com/17216317/115713221-5886e200-a3a8-11eb-87cf-a809ddaa3c60.mp4

Also maked some related changes. Works good, thank you!


Two small improvments on the plugin

Hi there,
Just two small improvements:

if the "script" property has spaces only (someone might have pressed some spaces by mistake), the CustomProperties class still should recognized it as empty (.equals(""))
the default values of the properties were being loaded AFTER loading the user-provided ones. For instance I want to get rid of the subject filter "jenkins >" and I cannot do that, because when I add the property with the empty value, this default takes over. Thus, I submit this PR to change the order in which these data is loaded: first we load the defaults, THEN we load the user-provided values.

Looks good to me, thanks for the contribution!

Hi @alexei-znamensky-movile,
I've just seen a defect come up in Jenkins, which I think is related to your fix (part 2: cannot override subjectContains).
https://issues.jenkins-ci.org/browse/JENKINS-32842
Could you please provide a unit test for your improvements - to confirm the expected behaviour?
Thanks,
Nick


[pure-k8s] restserver unit test

Currently we have only yarn-based restserver ut, Need add k8s-based ut

done.


[Bug]: AppiumOptions.ToDictionary() returns an empty dictionary

Description
trying to get options as a dictionary doesn't return any Appium values
Environment

Appium.NET 5.0.0-rc.4
Appium 2.2.4

Details
Please provide more details, if necessary.
Code To Reproduce Issue [ Good To Have ]
all I did was set some capabilities using AddAdditionalAppiumOption and then called ToDictionary

@s-glatshtein, thank you for reporting the issue. A fix will be available on the next release.


RFC: Manual control of allocation

Context
Some projects like cockroachdb are written in languages that have a GC and express they like those languages and they are a good choice.  However there are few hot paths that they have to be concerned about GC.  This is where abstractions break down and the code becomes less semantic as they try and manipulate the GC for tuning.
Solution
Crystal can provide an escape hatch from the GC for more control when needed.  Crystal can provide an interface where objects will be mallocated and deallocted independently of the GC.
Solution 1: Annotation
Pros: Easy to implement both allocations in a class and switch on the annotations.
Cons: This is at a class level and would be require more work for someone to use in the example above.
@[Allocation("manual")]
class Foo
end

Foo.new # => not managed by GC
Bar.new # => managed by GC

Solution 2: Macro
Crystal would provide a macro for allocating an object that was not managed by the GC.
Pro: This could be object specific.
Con: There would still need to be an interface to implement.
manual Foo.new # => not managed by GC
Foo.new        # => managed by GC

Solution 3: Alternative initializer
Crystal could provide and alternative initializer that would create an un-managed object.
Pros: can be more easily implemented at an Object level.
Cons: Introduces new interface to objects
Foo.gen # => not managed by GC
Foo.new # => managed by GC

The proposal needs to consider

how the deallocation will happen
what is expected during the creation of objects within the manual allocation

The implementation will need to register that object as root in the GC to prevent collection of referenced objects. Or, the proposal should consider the scenario of nested objects.

I did not cover deallocation in the RFC but I think you would have to free it by calling free or another method on it.
I would expect something similar to GC_MALLOC_UNCOLLECTABLE in boehm to be called.  I think it has expected behavior for the rest of Crystal.  The one thing I dont know is if something like GC_MALLOC_UNCOLLECTABLE would reduce the GC pressure as expected for projects like cockroachdb.  I would imagine it would be better then nothing.
Ideally the feature would allocate completely outside GC for complete manual control but I think that would be too unpredictable for managed language.  I think this feature would just help people that want to move in that direction.

If the manual allocation is specified at allocation time and not per class, this feature can later be utilized by the compiler itself to perform escape analysis of objects and transform what would be a GC allocation into a manual allocation, also adding the "free" call at the appropriate location.
Something like x = Foo.allocate(false); x.initialize(...); could do the job, with a later GC.free_manual(x)? Not sure.

allocate already does GC.malloc. If any, escape analysis can be implemented without anything of this (just embedded in the compiler/codegen).

If the allocation would be defined on a per class level, then one option that hasn't been mentioned is to overload the allocate method for that class. This can be done by including a module that redefine it, so it would be perfectly reusable without having to resort to annotations or the like. Allocate is not (or at least not yet) a complicated method - the only issue with it for this use case is that it is not called directly by the user so it is inconvenient to parameterize.
That would leave the actual functionality of allocating outside the control of the GC, and deallocating to be implemented elsewhere as a separate question. Perhaps it is better to start with the raw low-level functionality of how to provide that in a sane way (that cover brians points) rather than starting with the user interface.

BTW, a somewhat related area would be to give some control over alignment. In that case allocation strategy would probably need to be at instance level (ie, a particular instance of Slice(UInt8) should perhaps benefit from an alignment, but that doesn't mean all of them should). That might also be relevant to consider, depending on what path is chosen.

I think this is essentially a duplicate of #13481 (actually this one is older, but the other one has progressed further)
There are already some experimental features available: Reference.pre_initialize and Reference.unsafe_construct as well as ReferenceStorage(T).


Upgrade Bootstrap v4 to alpha4 release

Gulp workflow  needs to be updated to keep the $font-size-root as Pixel, ( set selectorBlackList: [/^html$/] in postcss-pxtorem)

https://github.com/luyadev/luya-boilerplate-bootstrap4/issues/3


feat: use vtpool when cloning poolable objects

This PR adds support for using the vtpool when cloning poolable objects.

Thanks for the PR! I don't love the new generated code using new() -- I have hopes that someday the Go compiler will optimize literal struct initialization to prevent zeroing of memory that will be overriden, but today is not the day, I guess.


Display Error: UpperTriangular

In the  original Julia console upper triangular matrices are displayed as matrices, where the lower triangular entries are displayed as single dots.  In Juno the lower triangular entries are displayed as random values.
x = [1.2 2 3; 0 4 6; 0 0 2]
A = x'x
chol(A)
3×3 UpperTriangular{Float64,Array{Float64,2}}:
 1.2   2.0  3.0
 2.4   4.0  6.0
 3.6  30.0  2.0

(the displayed values 2.4, 2.6, 30.0 are random and will likely be different when replicating this code).
This is purely a display issue with the Juno UI. If I select the output in Juno and copy it into this message I get the correct display here in this message:
3×3 UpperTriangular{Float64,Array{Float64,2}}:
 1.2  2.0  3.0
  ⋅   4.0  6.0
  ⋅    ⋅   2.0

This display issue appears both in the Juno console and for inline results in Julia source files.

This is fixed on master, we now fall back on the show method if there's no render method.


Empty region names and missing Java doc for a code sample IdeaChecker

Description
Empty region names and missing Java doc for an IdeaChecker - see code below.
To Reproduce

Install latest build from main into IDEA 2022.2.3
Open / create a Java project (with JDK 11)
Check Settings: Summaries is turned on, Fuzzing-symbolic is default 5-95%
Generate tests for the following class:

class Node {
    public boolean isFirst;
    public Node next;
}
public class IdeaChecker {

    public void markHeadAndTail(Node head, Node tail) {
        head.isFirst = true;
        tail.isFirst = false;

        if (head.isFirst) {
            //ok
        } else {
            throw new IllegalStateException("Head must be first!");
        }
    }

}

Expected behavior
Java docs, regions, test names and descriptions are supposed to be generated.
Actual behavior
There are no Java docs, region names are empty and descriptions are missing for all generated methods.
Visual proofs (screenshots, logs, images)
Environment
Windows 10 Pro
IntelliJ IDEA Ultimate 2022.2.3
Additional context
Not reproducing on plugin built from tamarinvs19/UnitTestBot_Family_PR - with last merged main on Nov 03.
Need to investigate - when this bug appeared in main.
Will continue tomorrow.

Not reproducing - on latest main, on release build any more.


Sentry 429 error causes BadResponseException

Thanks to a pile up of deprecation notices from Symfony 2.7, I've stumbled upon an issue where Sentry returns 429 TOO MANY REQUESTS, which causes Guzzle to throw a BadResponseException.
I'm not sure what the best way of handling this is, but I don't think it makes sense for Sentry to be able to cause it's own uncaught exceptions.

Oops, posted in wrong repo - closing this and have reposted here: https://github.com/hautelook/sentry-client/issues/5


adding opencl compatibility and benchmarking

:x: Build NanoPyx 274 failed (commit https://github.com/HenriquesLab/NanoPyx/commit/000e3e6b63 by @paxcalpt)

:x: Build NanoPyx 271 failed (commit https://github.com/HenriquesLab/NanoPyx/commit/000e3e6b63 by @paxcalpt)

:x: Build NanoPyx 272 failed (commit https://github.com/HenriquesLab/NanoPyx/commit/a7b73acb9d by @paxcalpt)

:x: Build NanoPyx 275 failed (commit https://github.com/HenriquesLab/NanoPyx/commit/a7b73acb9d by @paxcalpt)

Ricardo will fix any issues after


Weather Dashboard

Describe the project
A clear and concise description of the project you are going to add to this repository.
Features of the Project
This is very useful project. This project is used for any Weather Website.
FEATURES

Search Weather in Your City
See Temperature
See Humidity
See Wind Speed
See UV Index
See 5 Days Weather
Clear Search History etc.

Issue Type:

[ ] Bug Report
[ ] Feature Request
[ ] Documentation
[x] New Project

Additional context
Add any other context or screenshots about the project here.
Screenshots

If applicable, add screenshots to help explain your problem.

Hey Can I work on this issue?

@TusharKesarwani please assign me this issue...

The project is already present in the repo


UpdateAsync not working in EF Core 2.1

I read your response in 2 other threads not supporting stable releases, still I am cornered here, because I need EF Core 2.1, official version not coming out for at least several months.  I really like idea not to query data just so I can call update.
So this statement:
await this.Context.Set<MyTable>().Where(t => t.Id == id).UpdateAsync(t => new DbMyTable() { Status = Statuses.NotProcessed });

throws:

Object reference not set to an instance of an object.

Callstack:
   at Z.EntityFramework.Plus.InternalExtensions.CreateCommand(IQueryable source, RelationalQueryContext& queryContext)
   at Z.EntityFramework.Plus.BatchUpdate.CreateCommand(IQueryable query, IEntityType entity, List`1 values)
   at Z.EntityFramework.Plus.BatchUpdate.Execute[T](IQueryable`1 query, Expression`1 updateFactory)
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
--- End of stack trace from previous location where exception was thrown ---

I hope you will take the time to have a look, since this is really basic staff. That said, I understand you quote:

Thank you for reporting, however, we do not support preview version since some internal code keeps getting modified which make it hard on our side to keep our library up to date.
Once the stable version is released, feel free to ask for a fix if none has been provided yet.

Like I said, stable release is coming out in a few months and if fix is not provided I wouldn't have any choice but to comment code until fix is provided which I really don't want to do it.

One additional note. Delete raise same exception.

Hello @MaklaCof ,
Thank you for reporting, we will take your opinion into consideration.
One problem we have to support preview is some internal code is modified from one to another one which makes the support very hard. It's already enough hard to support multiple stables at the same time.
We don't want to support multiple preview version and supporting only the latest preview version may introduce bugs to people that upgrade our library but not their previous version. We are just not sure yet how to handle it correctly beside supporting only stable version.
Best Regards,
Jonathan

Hello @MaklaCof ,
Could you try the v1.7.18?
We finally choose to add some support to preview1 and preview2
Best Regards,
Jonathan

Hi, I am unable. I had also problems with ImageSharp and I had to downgrade back to 2.0. I will close this thread and reopen, if problem is not solved.


Experimental dsl for displaying recyclable lists [WIP]

This PR adds experimental dsl for build lists of data with much more convenient syntax then using regular recyclerView.

I guess we can always revisit this in following PRs, so I propose merging this as is and gather feedback.

Alright! Removing WIP then.


Security Fix for Prototype Pollution in v1

Fix prototype pollution when path components are not strings

Hi @koskimas, can this be merged?

@koskimas was quite clear on prototype pollution fixes in his comment here: https://github.com/Vincit/objection.js/issues/2261#issuecomment-1100117833
Is there a scenario where the above code could actually become an attack vector?

The referenced function has since been changed to use isSafeKey(), which checks for __proto__. This PR thus doesn't need merging anymore.

Actually, the fix was already in place before the PR was submitted, and thus the PR was never needed nor did it change anything: https://github.com/Vincit/objection.js/commit/867dc46537a8536578556e4b25b2add411f2a5e5
@koskimas was quite clear on his opinion on prototype pollution also, which he outlined here:
https://github.com/Vincit/objection.js/issues/2261#issuecomment-1100117833


psycopg2 issue connecting due to: psycopg2.OperationalError: server didn't return client encoding

example using fortune server in<EMAIL_ADDRESS>go run main.go server.go -listen <IP_ADDRESS>:15432
2023/04/04 20:06:10 Listening on <IP_ADDRESS>:15432
2023/04/04 20:06:13 Accepted connection from <IP_ADDRESS>:50252
2023/04/04 20:06:13 Closed connection from <IP_ADDRESS>:50252
python3
import psycopg2
conn = psycopg2.connect("postgresql://<IP_ADDRESS>:15432")
I tried to force client_encoding with no success like this:
postgresql://<IP_ADDRESS>:15432?client_encoding=utf8
The real error:
conn = psycopg2.connect("postgresql://<IP_ADDRESS>:15432")
File "/home/user/.local/lib/python3.10/site-packages/psycopg2/init.py", line 122, in connect
conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
psycopg2.OperationalError: server didn't return client encoding
Are there any quick solutions to this scenario?

You might want to use the pgproto3 in the pgx repository. That is where active development is taking place now.
That said, I think the solution would be for (p *PgFortuneBackend) handleStartup() to send a ParameterStatus message for client encoding.

ok thanks for the response, ill check both out.. I'll post back later seeing if my minimal go skills can get something going here, otherwise I'll try to move to the newer.. This was originally to get postlite to work (go project serving a data directory of multiple sqlites as postgres wire protocol).


response: configurable granularity

Adds OAISERVER_GRANULARITY configuration option.  (closes #30)

:shipit:

Ups that was a bit too fast!


Timeout-related issue (?) with firebase deploy

I have OHIF deployed via Firebase here: https://idc-tester-1.web.app/, following the deploy steps by @pieper in https://github.com/ImagingDataCommons/idc-sandbox/blob/main/deploy.sh.
It first worked, then it stopped working with the error below (hard reload did not help).

But if I log in under incognito, and authenticate, it works there, but after some time stops working again.
What other details would I need to provide to help debug this?

@fedorov how about this one?

@fedorov I'm looking at the issues again after our release to triage, and would like to know the status of this one


Make cftime dateoffsets public

Consider the following cftime vector. It's fairly common to see users asking how to subtract "1 month" from this kind of vector:
xr.set_options(display_style="text")
time = xr.DataArray(
    xr.cftime_range("1000-01-01", "1000-05-01", freq="MS", calendar="360_day"), dims="time", name="time"
)
time

<xarray.DataArray 'time' (time: 5)>
array([cftime.Datetime360Day(1000, 1, 1, 0, 0, 0, 0, has_year_zero=False),
       cftime.Datetime360Day(1000, 2, 1, 0, 0, 0, 0, has_year_zero=False),
       cftime.Datetime360Day(1000, 3, 1, 0, 0, 0, 0, has_year_zero=False),
       cftime.Datetime360Day(1000, 4, 1, 0, 0, 0, 0, has_year_zero=False),
       cftime.Datetime360Day(1000, 5, 1, 0, 0, 0, 0, has_year_zero=False)],
      dtype=object)
Coordinates:
  * time     (time) object 1000-01-01 00:00:00 ... 1000-05-01 00:00:00

Subtracting pd.Timedelta("1 month") does not work because a month does not represent an absolute unit of time. Instead the solution appears to be:
time - xr.coding.cftime_offsets.MonthBegin(1)

<xarray.DataArray 'time' (time: 5)>
array([cftime.Datetime360Day(999, 12, 1, 0, 0, 0, 0, has_year_zero=False),
       cftime.Datetime360Day(1000, 1, 1, 0, 0, 0, 0, has_year_zero=False),
       cftime.Datetime360Day(1000, 2, 1, 0, 0, 0, 0, has_year_zero=False),
       cftime.Datetime360Day(1000, 3, 1, 0, 0, 0, 0, has_year_zero=False),
       cftime.Datetime360Day(1000, 4, 1, 0, 0, 0, 0, has_year_zero=False)],
      dtype=object)
Coordinates:
  * time     (time) object 1000-01-01 00:00:00 ... 1000-05-01 00:00:00

I think pandas exposes this functionality as pd.DateOffset(months=1). Can we add a similar xr.DateOffset?

I agree this would be useful functionality.  Were you thinking that we would design xr.DateOffset such that it would work for both np.datetime64 values and cftime objects?

Were you thinking that we would design xr.DateOffset such that it would work for both np.datetime64 values and cftime objects?

I think so. It would be very convenient and is similar to the proposed xr.date_range (#5233)


Invoking spinner before a "promise" not working

I'm still learning javascript and trying to get spin.js to work in a project.
Spinner works for me after a " window" command loads in app.js. But I don't understand how to make it work before a "fetch" promise in another .js module. Per your instructions I code the lines before the "fetch":
var spinner = new Spinner().spin();
target.appendChild(spinner.el);
but it tells me Spinner is undefined. I tried adding "import { Spinner } from './spin.js'" like I have in my app.js, but that didn't work either.
Thanks, spin.js is obviously a work of art.

Another question: I would like to see the spinner after this command:
form.addEventListener('keyup', function (e) {
e.preventDefault();
const value = input.value;
Thanks

I think I can resolve the issues above if I can get this command to work:
import { Spinner } from './spin.js';
that, for example, precedes these two lines in a specific module:
var target = document.getElementById('value');
new Spinner({ color: '#F38E00', lines: 12 }).spin(target);

Sorry for all the muddle above. Please ignore my many previous posts. I think I somehow got the Spinner working pretty well in my project. But I'm still wanting to learn and understand the product and javascript better.
In the project I am working on that involves waiting for data to be sent from an api,  I have a "promise"  involving the lines:
const response = await fetch(url);
const data = await response.json();
return data;

In this case, the Spinner displays just fine until the api data is returned and then it disappears. However, when awaiting input from a local user in order to proceed to a new page, the Spinner sometimes appears, depending on other display items on the screen that may hide it. When I can see it, it does not rotate; also, when I can see it, it is not in the same place on my screen as in those instances involving an api. How can I display Spinner rotating and on the screen where I can always see it, as the way it works when an api is involved? Is the Spinner not intended for use except with api's, or is there some way I can eliminate it's erratic behavior. Thanks for your patience.

Found a bug in my code, and now Spinner is working. I've noticed that as long as I have these lines in place:
import {Spinner} from 'spin.js';
var target = document.getElementById('foo');
new Spinner({color:'#fff', lines: 12}).spin(target);
I never have to employ stop(target). I guess your spin.js knows when to stop. Is that how it is supposed to work?
If so, very nice.


bom update

Description
Investigating the issue with https://github.com/dockstore/dockstore-cli/pull/253
Splitting the difference on the bom update
Review Instructions
Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments.
For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services
will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure
ticket that results in visible changes to the end-user will definitely require review.
Many tickets will likely be between these two extremes, so some judgement may be required.
Issue
A link to a github issue or SEAB- ticket (using that as a prefix)
Two follow-up issues:

Nightly cron doesn't seem to work to detect some changes in the webservice (but it works with others). Possibly compilation issues are detected, but not changes in jars?
Re-enable disabled tests (a bunch of checker workflow tests, one hosted workflow test)

Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running ./mvnw clean install
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

Going down weird rabbit holes.
Some errors appear to be changes in how the webservice responds to requests (think the nightly jobs would have caught that)
Others seem to be an issue with the webservice getting the wrong results from the DB?

Locally confirmed, the same tests needed to be disabled to get the builds working with 1.15.0-alpha.5


R2DBC API: Provide Row.get(Object identifier)

When reading and mapping data into objects, it's common to have types which differ between the model and its persistent representation. We should have a method to read values and let the driver determine the data type.
Note: Ideally, we have Row.get(String identifier) and Row.get(int index) methods to tighten up the API contract and resolve ambiguities over the identifier.

I think we should break out the discussion about identifier types into a separate issue as it's larger than this.

This issue was moved to r2dbc/r2dbc-spi#4


Multi window support

When detecting window resize events, it doesn't check which window is resized. When multiple windows are used, events from other windows will affect egui. The fix is to check like this: https://github.com/Yamakaky/gyromouse/blob/gui/src/backend/sdl/overlay.rs#L221-L225.
https://github.com/ArjunNair/egui_sdl2_gl/blob/main/src/lib.rs#L54-L57

Good point! I'll integrate that fix asap.

Sgtm!


Update README.md

Add a link for a new model

Codecov Report

Merging #59 (42cba5f) into master (665b439) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   51.04%   51.04%
=======================================
  Files           2        2
  Lines         384      384
=======================================
  Hits          196      196
  Misses        188      188

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665b439...42cba5f. Read the comment docs.


thumbnailhome under #SILKLife section.

New

Old

I updated this image because SILK Home consists of community, collaboration, and where all can live together. This image is representing SILK Home initiatives.


[feature request] Add packets over TTN/Helium

TTN and Helium (to some degree) already provide coverage in many regions of the world.
It could be useful to be use these LoRa-based networks to transmit Reticulum packets.
If routing Reticulum packets over other LoRa based networks is already possible a manual page/example would be useful.

If routing Reticulum packets over other LoRa based networks is already possible a manual page/example would be useful.

This is already possible using Reticulum. Here's a guide for setting up encrypted LoRa messaging over Reticulum: https://unsigned.io/private-messaging-over-lora/.
Please feel free to open a discussion if you have any other questions about setup.

As @4c3e mentions, the preferred (and currently only) way to use Reticulum over LoRa is using the methods already supplied and documented in various places. There is also information about setting up LoRa interfaces here:

Manual - RNode LoRa Interface
Installing RNode Firmware on T-Beam and LoRa32 Devices
How To Make Your Own RNodes

LoRaWAN networks (as opposed to raw LoRa, using an RNode for example) is generally not well suited for realtime bi-directional communication, since uplink and downlink packets can be spread out very far in time.
There are limited use cases where it might be useful to be able to "piggyback" on established LoRaWAN networks, for example for sending oppertunistic single-packet LXMF messages. This could make it possible to send very short (SMS-style) LXMF messages even when far away from any Reticulum LoRa nodes. This could be explored in the future.


chore: use strict TS option for dtslint

Description:
As mentioned in #4968, the TypeScript compiler options could be more strict. Changing this is going to involve code changes. However, there's no reason we cannot enable strict for the dtslint tests right now. Doing so will allow us to use $ExpectError in more situations in our dtslint tests - the 'strictNullChecks': false in the current configuration will prevent some types of errors from being reported.
Related issue (if exists): #4968

@benlesh It would be nice to get this merged, too.


Fix lab-dns-internal to pass shellcheck linter

No need to run full CI on this one! I will take the responsibility if this breaks the code

:tada: This PR is included in version 1.9.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix/upgrade flow

problem: flow is out of date
problem: travis ci is not running flow

Codecov Report

Merging #386 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   17.54%   17.72%   +0.18%
==========================================
  Files         187      186       -1
  Lines        2913     2883      -30
  Branches      501      495       -6
==========================================
  Hits          511      511
+ Misses       2017     1993      -24
+ Partials      385      379       -6

Impacted Files
Coverage Δ

src/components/ledger/ImportAccount/hdpath.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0b2f5...8a74f80. Read the comment docs.


Add methods to ServiceInvocationContext for propagating context into callback invocations.

Currently, when writing an asynchronous service that does multiple RPCs, the RPC callbacks will likely be called with no ServiceInvocationContext.current() set. This is because the initial invocation removes the context right away to allow processing another event from the event loop, here
https://github.com/line/armeria/blob/master/src/main/java/com/linecorp/armeria/server/HttpServerHandler.java#L264
We need a mechanism for propagating the invocation context to when the RPC callbacks fire (and may trigger additional RPCs, callbacks, etc), otherwise context-dependent features (think zipkin) will not work.
This PR adds methods for propagating context into callback methods, including an executor that will do it automatically for any subitted tasks. In general, service code will want to to use this executor in calls like CompletableFuture.whenCompleteAsync. They probably already are using ServiceInvocationContext.eventLoop to make sure callbacks are called on the same thread, and this would replace that so they're on the same thread with the correct context.

Instead, you could get the current ServiceInvocationContext before creating a callback and access the context from the callback:
public class MyThriftServiceImpl implements MyThriftService.Iface {
    public void foo() {
        ServiceInvocationContext ctx = ServiceInvocationContext.current();
        ListenableFuture<Object> f = someAsyncClientLibrary.bar();
        f.addListener(() -> {
            ... do something with ctx ...
        }, ctx.eventLoop());
    }
}

And call ServiceInvocationContext.setCurrent in service code? That sounds wrong.
Again I'm mostly concerned with armeria breaking because of the lack of context for stuff like tracing, and having the client code having to call setCurrent or whatever sounds like a dangerous way to make that work.

And call ServiceInvocationContext.setCurrent in service code? That sounds wrong.

No. Just passing the context object as a field of a callback?

How would armeria client's use of current ServiceInvocationContext to stay on the thread work?  And in the future opening a zipkin span in the context. Both of these happen in armeria and rely on setCurrent having been called. I think propagating inside an armeria executor makes the most sense for them to continue to work.

Specifically this code currently won't work in callbacks
https://github.com/line/armeria/blob/1ffb8d0ed91e56763609eba2ab721f1b2c03f6c5/src/main/java/com/linecorp/armeria/client/HttpRemoteInvoker.java#L150

Addressed comments

@anuraaga Thanks! Merged.


version of java

I have the latest version of java. But jpype requests java SE 6 as default version when running startJVM. It alerts me to install java SE 6 from a website in a dialogue-box. Can I use the installed java instead of downloading a new one?
$ java --version
openjdk 13 2019-09-17
OpenJDK Runtime Environment (build 13+33)
OpenJDK 64-Bit Server VM (build 13+33, mixed mode, sharing)
PS: my system is macOS 10.13.6

It sounds like some sore of interaction between the stubs on your os and jpype.  Jpype is definitely not making a request for Java 6.  It wouldn’t even run with Java 6 because the jars in JPype are build for Java 7 or later.  Most likely calling for Java is hitting a stub which says the default Java in the path is “install java SE 6”.
I recommend that you set your JAVA_HOME environment variable to the appropriate location and it should run fine.

It sounds like some sore of interaction between the stubs on your os and jpype. Jpype is definitely not making a request for Java 6. It wouldn’t even run with Java 6 because the jars in JPype are build for Java 7 or later. Most likely calling for Java is hitting a stub which says the default Java in the path is “install java SE 6”. I recommend that you set your JAVA_HOME environment variable to the appropriate location and it should run fine.

Thank you very much. I found the stub
    def _pre_vm7_path(self):
        """
        Returns the previous constant JVM library path:
        '/System/Library/Frameworks/JavaVM.framework/JavaVM'
        """
        return '/System/Library/Frameworks/JavaVM.framework/JavaVM'

/System/Library/Frameworks/JavaVM.framework/JavaVM is a link, link to a JavaVM (/System/Library/Frameworks/JavaVM.framework/Versions/A/JavaVM) but the executable file does not work probably. I will re-link it to my java, instead  of correcting the source code.


Mac: Add an existing Stellar account with public key/address only

What I did
I went to the Wallet page in the Mac Keybase app and clicked Add an account. A dropdown list of options appeared and I selected Link an existing Stellar account.

What happened
A window appeared requesting that I share the secret key.

What I expected to happen
A window to appear to allow me to enter either a public key/address only, or a secret key, so that I could add a second existing account I have as part of my identities without storing the secret key in Keybase.
Why did I expect this
Bitcoin and Zcash addresses can be added to Keybase with just the public key/address.

Actually it has occurred to me that it is possible to add a Stellar account using the account IDs secret key and retaining private access to the account if the sig for the account is changed. I guess this is a way to do this.

I think Keybase's goal is identity verification, if you only paste a pubkey then there's no way to verify it's actually you unless you want to waste stellar.

Both Bitcoin and Zcash addresses can be added without any assertion signature (and if they did require bidirectional assertions, that's also possible with Stellar private keys).

Both Bitcoin and Zcash addresses can be added without any assertion signature (and if they did require bidirectional assertions, that's also possible with Stellar private keys).


Failed to compile baresip using VS2015

int pipe(int fds[2]);
ssize_t pipe_read(int s, void *buf, size_t len);
ssize_t pipe_write(int s, const void *buf, size_t len);

In re-win32 there are following declaration in mqueque.h
int pipe(int fds[2]);
ssize_t pipe_read(int s, void *buf, size_t len);
ssize_t pipe_write(int s, const void *buf, size_t len);
but there is no any definition of them.
these symbols are used in file mqueque

there are definition in the file mqueue/win32/pipe.c  :)


replace api endpoint URL in README

Issue being fixed or implemented
replaced wrong endpoint urls in README
What was done
see above
What has been tested
tested endpoints
What needs to be tested
n/a
Code Coverage
n/a

Thanks for this @fanatid, @Cofresi !
I've rebased this onto latest master, squashing in the process to remove commits which only addressed previous merge conflicts. I also shortened the commit message to be shorter than 50 characters.
Let's try and keep the first line of commit messages to 50 chars or less per our guidelines and because many git tools are designed with this soft-limit in order to ensure great commit messages.

If someone merges this before I get to it tomorrow, please use "Squash and Merge" option. Thanks!


Callbacks from parent ViewComponent are not called

Hi, we have base view component class, from which all our view components inherit. It defines a before_reflex callback:
class BaseComponent < ViewComponentReflex::Component
  before_reflex do
    puts 'Base before_reflex'
  end
end

Then in an actual TableComponent which inherits from the BaseComponent, we have another before_reflex callback and  we have defined a next_page reflex method:
class TableComponent < BaseComponent
  before_reflex do
    puts 'Child before_reflex'
  end

  def initialize()
    @page = 0
  end

  def next_page()
    @page += 1
  end
end

And the problem is, that when the next_page reflex is called on a button click, only the child before_reflex is called and the console contains only this output:
Child before_reflex

However I would expect, that both callbacks would be called.
Is the way it works now (only child callback executed) desired, or is this some kind of a bug?
PS: If I remove the child's before_reflex callback, the parent's callback is still not called, so it is not a problem of owerwriting.
Thanks

What version are you running?
I'll take a look, see what I can see

We are using the latest 3.3.0 version.
Thanks :)

@stefan-schindler Give 3.3.1 a try

Thank you very much for such quick fix, it works now!🙂


Deployment on hosting

Use render or AWS
Create a docker config for app
Create a test brunch for test deployments.
Hook up the production branch to make auto deployment possible

Hosted on render.
Database is hosted on render as well
Credentials are stored in the readme of the project
Integration brunch is live https://abstract-reddit-preview.onrender.com/
Dockerfile is created
Postman env is created (integration)
Migrated to the PostgreSQL
Docker compose is created to make local development easier (Run DB container and connect automatically)
Added localhost run configuration in the .run folder
Added .env file to store env config
application.properties is changed to use env variables


#GH-59 Fixed test cases that were having time dependency

Summary
Some test cases were having time dependency which is fixed.
Checklist

[x] Added or updated test cases
[x] make test Ran test cases and ensured they are passing
[x] make check-style Ran style check and ensured both webapp and server components comply the style guides

LGTM!


add unfold,fold,bicubic,qr,eye

fold and bicubic need improving.

Thanks for your contribution~ Bravo~
Could you please add some tests like python/jittor/test/test_linalg.py, and some changes seem to be automatically generated by editor(such as add space and enter), could you please remove that?