Apply nanoseconds precision for timeout duration.

Apply nanoseconds precision for timeout duration.
Also improve javadocs

Codecov Report

Merging #453 (0a339fe) into master (7be5b59) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #453   +/-   ##
=========================================
  Coverage     84.73%   84.73%
  Complexity     3293     3293
=========================================
  Files           222      222
  Lines          7912     7912
  Branches        948      948
=========================================
  Hits           6704     6704
  Misses          959      959
  Partials        249      249

Impacted Files
Coverage Δ

.../org/apache/commons/io/input/QueueInputStream.java
96.29% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

The timeout is configurable through the public API with a Duration value which encapsulates both time amount and time unit.
This PR changes so that internal usage and conversion of Duration is more precise up to nanoseconds.


Reland "Remove single-view assumption from ScrollPhysics (#117503)"

This reverts commit c956121ac098b91061bfc0a93c930121ff3279ba.
There's a g3fix for this in cl/499261505.

I think bill mentioned flutter gallery in https://github.com/flutter/flutter/pull/117647#issuecomment-1366006497 . would the comment also be relevant?

I'll fix up gallery.


Use which instead of type to detect if command exists

type will not confirm the file in $PATH is executable or not.

Is there a use case where something passes type but isn't executable?

@ljharb this may be a very special case but "type" does ignore to confirm the executable permission, but "which" does confirm that. If the behavior here currently we expected won't be affected, it'll be worth to move on the one won't have this potential problem.

to be honest, I'd rather use type and [ -x $path ] if that's something worth checking - but it's not once truly come up, and I don't want to be recklessly fixing hypothetical problems that don't yet exist.

Got you point, actually, I just tested type under sh, ksh, zsh and bash and the results are interesting: ksh and zsh will make sure if the command is executable or not, but sh and bash wouldn't, if ksh and zsh will make sure that, is it still not good enough to make sure in bash and sh by ourselves?

It's still not good enough; so since we need the -x check regardless, let's not bother with using which.


Suggest using NAT44 and NAT66 or DHCPv6 with relay mode

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I want to use IPV6.
I've tried using mirrored network mode, but it caused that all my network connections on windows including zerotier and tailscale have been mirrored. I can't choose whether or not which network connection can mirrored.
When I turn on different WSLs. The IP is same in NAT mode and mirrored mode. If ip is different, it will be better to connect to different WSLs.

Describe the solution you'd like
A clear and concise description of what you want to happen.
IPV4 mode: NAT44
IPV6 mode: dhcpv6 relay ( I have ipv6 with 64 prefixlen and my router offer dhcpv6 server )
### Tasks

Logs are required for review from WSL team
If this a feature request, please reply with '/feature'. If this is a question, reply with '/question'. Otherwise please attach logs by following the instructions below, your issue will not be reviewed unless they are added. These logs will help us understand what is going on in your machine.
How to collect WSL logs

/feature


Agent Webhook Settings [Incorrect grammar]

If you want to define a global webhook that will called each time the user talks with your agent then you can do it here.

is worded poorly.
should be:
If you would like to define a global webhook that will be called each time the user talks with your agent, then you may do it here.

Closed by https://github.com/samtecspg/articulate/commit/809ba39c98a66bdbae7c81763ca06d79c1782c18


Clarification on Documentation: iceoryx-enabled pre-built and zero-copy mode

I am quite excited to see eCAL 5.10 is including iceoryx as a possible inter-process communication middleware, which theoretically could achieve zero-copy (through shared memory)!
I have two questions after reading the documentation:

ECAL_LAYER_ICEORYX is by default turned off (link). Then if I am installing the eCAL library using PPA on Linux, am I using a version with iceoryx or not? If not, is there any pre-built version that has iceoryx turned on?

The documentation here explained zero-copy mode, as well as its limitation of blocking. Is this refering to the eCAL's own SHM implementation? Or it refers to the iceoryx version?

For point 2, I would assume, if iceoryx is enabled, there shouldn't be this blocking limiation, am I right? I read a bit of the iceoryx internals from here.
Thanks for maintaining eCAL :)

To add on to the thread, I observed two interesting API:
https://github.com/eclipse-ecal/ecal/blob/b4875ce42932db0ba31c9ce45b2f358f192dad3c/ecal/core/include/ecal/ecal_publisher.h#L244
https://github.com/eclipse-ecal/ecal/blob/b4875ce42932db0ba31c9ce45b2f358f192dad3c/ecal/core/include/ecal/ecal_publisher.h#L215
If I understand correctly, these two APIs only apply to builtin shared memory version. How would these two API take effect, if ECAL_LAYER_ICEORYX is turned on?
I am mainly interested in the one-publisher-many-subscribers use case, with large payload (high resolution images).

Hi HuiminC,

If you are installing from a PPA, you are installing an eCAL version without Iceoryx. eCAL provides its own shared memory layer that is easier to use than iceoryx, e.g. you don't need to know your maximum message size beforehand and don't need an orchestrator.
For using iceoryx you need to compile your own eCAL. The documentation will get you started on how to do that: https://eclipse-ecal.github.io/ecal/development/build_ecal.html
You can also check out this github action, which builds eCAL with iceoryx: https://github.com/eclipse-ecal/ecal/blob/master/.github/workflows/build-ubuntu-iceoryx.yml
If you are on Ubuntu 20.04 you can also check if the build artifacts produced by that action fit your needs.

The eCAL Zero Copy mode refers to the eCAL Share Memory Layer. If you are using a pre-built version of eCAL, you can use that feature, as the Shared Memory Layer is the default one. If you are using iceoryx, those parameters don't have any effect.
At the moment, the eCAL ZeroCopy mode has 2 limitations:

Reading / working on the data blocks the publisher, as the shared memory segment is locked.  You can easily work around this limitation by using the multi-buffering feature.
In a many-subscriber environment, currently only 1 subscriber can work on the data at the same time. This may disqualify the feature for your use-case, I guess. We are working on a shared read-write-lock. Hopefully, eCAL 5.11 will get rid of this limitation.

Have you already tried eCAL without ZeroCopy and can provide some performance measurements? I would be interested in those!
Best Regards
Florian

Hi Florian,
Thanks for the prompt reply!

Yes I am on Ubuntu 20.04, that means I could first try out the action's artifactory https://github.com/eclipse-ecal/ecal/actions/workflows/build-ubuntu-iceoryx.yml . I will also try building from source if it is necessary. Noted on your comment on ease of use. Do you have a minimal working example on how the iceoryx version would work? I am interested in the performance, and I do see the benchmark section that iceoryx-enabled version would have some more performance boost. Would like to know if the extra complexity is worthwhile.
Great to know the planned improvement on eCAL 5.11 . Does this mean, eCAL is aiming to get the same performance (latency) level as iceoryx currently is this?

For performance measurement, yes I would definitely do one. I am currently trying out the combination of eCAL+CapnProto. Would like to compare it with the ROS1 implementation we had, to see if there is considerable improvements. Any suggestions on how you would like the performance to be measured? I would guess it would be the average send-receive latency, and perhaps CPU utilisation?
If I understand correctly, the non-zerocopy version of eCAL with SHM transport, would still be a lot better than ROS1 which is using TCP socket communication, by saving at least two copies (user-to-kernel and then kernel-to-user, reference). With proper selection of serialisation method (e.g. CapnProto) we could also save more on the serialisation copies, at least at the decoding time.
Thanks!

From my point of view, I would try to get started first (e.g. with the PPA eCAL version) for basic benchmarking.
If your setup gets more complex, at some point you might have to compile (at least eCAL runtime) yourself, to match your dependency stack.
To be honest, the iceoryx implementation in eCAL has been done, and benchmarked, but in production scenarios we always work with eCAL's native SHM implementation.
We do transfer large amounts of data, but we seldomly observe that eCAL is the performance bottleneck.
I think you will see massive improvements over ROS1 / TCP, just with regular eCAL SHM.
The rest will depend highly on your setup:

Do you have 1:1 or 1:N (and how big is N) scenarios?
How are you continuing to process your data? (e.g. how do you partion your nodes? Do they do heavy computation before sending out data again, or are you chaining very light nodes?)

I am curious to see how eCAL works out for you!

Closing this as the discussion seems to have seized.


[HOLD for Payment 2024-09-23][$100] Web - Chat - New line added when selecting "Edit comment" with arrow and enter key

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4912531
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/
Go to any chat with messages (or send some messages).
Right click on any message.
Click on "Edit comment".
Note that the cursor is at the end of the message.
Cancel the edit.
Right click on the message.
With the arrows and enter keys, select "Edit comment".
Note that a new line is added, cursor is on a new line.

Expected Result:
No new line should be added when selecting "Edit comment" with arrows and enter keys.
Actual Result:
A new line is added when selecting "Edit comment" with arrows and enter keys.
Workaround:
Unknown
Platforms:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/c8be3199-28da-46ee-a3aa-62f111456c7e

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021831491720281537308
Upwork Job ID:<PHONE_NUMBER>281537308
Last Price Increase: 2024-09-05

Issue OwnerCurrent Issue Owner: @parasharrajat

@adelekennedy  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
New line is added when we edit a message using keyboard ENTER.
What is the root cause of that problem?
In the context menu component, we have an ENTER keyboard shortcut that will open the edit composer.
https://github.com/Expensify/App/blob/aa693719e19c468983a090e0c8a7bb2cec8ee76c/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx#L245-L261
Because the context menu option is focused, pressing ENTER will also by default trigger the element onPress which will open the edit composer. But because it's already handled by the ENTER keyboard shortcut, the enter event is captured by the edit composer which adds the unexpected new line.
What changes do you think we should make in order to solve the problem?

Enable the ENTER shortcut for native only. We don't need the ENTER shortcut for the web because the item is focused when we navigate using the arrow key.

I can reproduce - however this seems like a pretty smal bug to me so I'm reducing the bounty
https://github.com/user-attachments/assets/16189b95-d7a1-4433-8ad7-ea81ca3ebf59

Proposal:
To address the issue where pressing "Enter" during the "Edit Comment" action adds an unintended new line, I propose adjusting the keyboard input handling logic in the component responsible for this functionality.
Technical Explanation:

I will modify the event handling for the "Enter" key to ensure that when it's pressed during the "Edit Comment" action, it prevents the default behavior that adds a new line.

The solution will ensure that pressing "Enter" correctly triggers the editing action without introducing any additional lines in the text input.

This change will involve refining how the keyboard input is managed in the context of the edit action, ensuring that only the intended behavior occurs when the "Enter" key is pressed.

https://github.com/user-attachments/assets/a6f067e3-5b4b-491a-a8bb-33a43cd067f0

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/chevgan

@parasharrajat what was your reasoning for choosing @Krishna2323's alternative proposal?
IMO, @bernhardoj's proposal LGTM. It effectively address in the first place the problem, since we don't need to have the ENTER shortcut when on web from what it seems.
Letting the shortcut event there trigger while we don't need it, to then prevent its effect doesn't sound that good to me.

Just noting for pricing we don't have a standard reduced priced - our SO says to set it at whatever we think is fair and then increase if we don't see traction

PR is ready
cc: @parasharrajat

Payouts due:

[ ] Contributor: $100 @bernhardoj NewDot
[ ] Contributor+: $100 @parasharrajat NewDot

Requested in ND.

$100 approved for @bernhardoj

$100 approved for @parasharrajat


Mandelbrot example segmentation fault.

Hi!
With build 0.1.5-71-gfa2f4e1 I've downloaded the mandelbrot example, compiled it, and gives me segmentation fault every time. Also, I've tried to put a single print at the start of Main.create and still gives me the segmentation fault.
λ ponyc
Building .
Building builtin
Building files
Building time
Building collections
Building options
Generating
Optimising
Writing ./mandelbrot.o
Linking ./mandelbrot
------------------------------------------------------------
λ ./mandelbrot
[1]    22729 segmentation fault (core dumped)  ./mandelbrot

I'm afraid I'm not able to duplicate this on OSX, Linux or FreeBSD using HEAD. Could you please try again with HEAD, and let me know what platform you're on? Thanks!

I was using the AUR version in archlinux.
Here in Ubuntu 14.10, I installed from the repository (version 0.1.5) and have the same result.
With the HEAD version:
> ./build/release/ponyc --version
0.1.5-74-g915d322

> ./build/release/ponyc examples/mandelbrot
Building examples/mandelbrot
Building builtin
Building files
Building time
Building collections
Building options
Generating
Optimising
Writing ./mandelbrot.o
Linking ./mandelbrot

> ./mandelbrot
[1]    19600 segmentation fault (core dumped)  ./mandelbrot

I am failing to reproduce this on Ubuntu. Can you please try compiling and running example/helloworld
Also what version of LLVM do you have installed? Can you please check by running
llvm-config --version

and let us know what it says.

I don't know why it's happening, ArchLinux 64 bits, fresh cloned:
λ llvm-config --version
3.6.0

λ make config=release
stdfd.c
socket.c
posix_except.c
[...]
fun.cc
pool.cc
heap.cc
pagemap.cc
Linking libponyrt.tests

λ ./build/release/ponyc examples/helloworld
Building examples/helloworld
Building builtin
Generating
Optimising
Writing ./helloworld.o
Linking ./helloworld

λ ./helloworld
Hello, world.

λ ./build/release/ponyc examples/mandelbrot
Building examples/mandelbrot
Building builtin
Building files
Building time
Building collections
Building options
Generating
Optimising
Writing ./mandelbrot.o
Linking ./mandelbrot

λ ./mandelbrot
[1]    4538 segmentation fault (core dumped)  ./mandelbrot

The weird thing is that I can execute complex applications:
λ ./build/release/ponyc test/pony/httpserver/
Building test/pony/httpserver/
Building builtin
Building net/http
Building collections
Building net
Building net/ssl
Building time
Generating
Optimising
Writing ./httpserver.o
Linking ./httpserver

λ ./httpserver
Listening on <IP_ADDRESS>:50000
<IP_ADDRESS> - - [22/May/2015:13:29:58 +0000] "GET / HTTP/1.1" 200 15 "" "Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0"
<IP_ADDRESS> - - [22/May/2015:13:29:59 +0000] "GET /favicon.ico HTTP/1.1" 200 26 "" "Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0"

@rockneurotiko Could you try to run mandelbrot in a debug-build and paste the gdb/lldb stack trace when it crashes? Thank you!

Yeah, sure!
λ make config=debug
stdfd.c
socket.c
posix_except.c
stat.c
[...]

λ ./build/debug/ponyc examples/mandelbrot
Building examples/mandelbrot
Building builtin
Building files
Building time
Building collections
Building options
Generating
Optimising
Writing ./mandelbrot.o
Linking ./mandelbrot

trace:

λ gdb mandelbrot
(gdb) run
Starting program: /home/rock/Git/ponyc/mandelbrot
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[New Thread 0x7ffff3ce6700 (LWP 22469)]
[New Thread 0x7ffff34e6700 (LWP 22470)]
[New Thread 0x7ffff44e7700 (LWP 22468)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff3ce6700 (LWP 22469)]
0x000000000040d845 in pony_traceunknown (p=0x0) at src/libponyrt/gc/trace.c:68
68        pony_type_t* type = *(pony_type_t**)p;
(gdb) backtrace
#0  0x000000000040d845 in pony_traceunknown (p=0x0) at src/libponyrt/gc/trace.c:68
#1  0x0000000000411293 in actor_run (actor=0x7ffff54e8200) at src/libponyrt/actor/actor.c:110
#2  0x000000000040bd70 in run (sched=0x623970) at src/libponyrt/sched/scheduler.c:407
#3  0x000000000040bdfa in run_thread (arg=0x623970) at src/libponyrt/sched/scheduler.c:432
#4  0x00007ffff79bd374 in start_thread () from /usr/lib/libpthread.so.0
#5  0x00007ffff71f227d in clone () from /usr/lib/libc.so.6

Thanks. On more favour: could you checkout 3cc402b73220aa90c7cc33bd8b9d35c0b6c2930f and retry? Does it still crash?

The same result :-S
λ git checkout 3cc402b
Note: checking out '3cc402b'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 3cc402b... non-mutable set/map operators

λ make config=debug
fatal: ref HEAD is not a symbolic ref
stdfd.c
socket.c
[...]

λ ./build/debug/ponyc examples/mandelbrot
Building examples/mandelbrot
Building builtin
Building files
Building time
Building collections
Building options
Generating
Optimising
Writing ./mandelbrot.o
Linking ./mandelbrot

λ gdb mandelbrot
(gdb) run
Starting program: /home/rock/Git/ponyc/mandelbrot
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[New Thread 0x7ffff40f8700 (LWP 10329)]
[New Thread 0x7ffff48f9700 (LWP 10328)]

Program received signal SIGSEGV, Segmentation fault.
0x000000000040d708 in pony_traceunknown (p=0x0) at src/libponyrt/gc/trace.c:68
68        pony_type_t* type = *(pony_type_t**)p;
(gdb) backtrace
#0  0x000000000040d708 in pony_traceunknown (p=0x0) at src/libponyrt/gc/trace.c:68
#1  0x0000000000410c92 in actor_run (actor=0x7ffff58fa200) at src/libponyrt/actor/actor.c:110
#2  0x000000000040bc35 in run (sched=0x623010) at src/libponyrt/sched/scheduler.c:407
#3  0x000000000040bcc4 in run_thread (arg=0x623010) at src/libponyrt/sched/scheduler.c:432
#4  0x000000000040bffc in scheduler_start (library=false) at src/libponyrt/sched/scheduler.c:516
#5  0x000000000040b311 in pony_start (library=false) at src/libponyrt/sched/start.c:145
#6  0x00000000004099a9 in main ()
(gdb)

I confirm the issue with HEAD on archlinux. Exact same backtrace.

Thanks for confirm it, I was going crazy :-S

@rockneurotiko I have tried it on Archlinux with latest GCC and mandelbrot runs. What gcc did you use to compile ponyc and what version of GLIBCXX have you installed - 3.4.21?

Pony HEAD,
gcc version 5.1.0 (GCC),
llvm 3.6.1
Program received signal SIGSEGV, Segmentation fault.
0x000000000040a21f in pony_traceunknown (p=0x0) at src/libponyrt/gc/trace.c:68
68	  pony_type_t* type = *(pony_type_t**)p;
(gdb) bt
#0  0x000000000040a21f in pony_traceunknown (p=0x0) at src/libponyrt/gc/trace.c:68
#1  0x000000000040ceb0 in actor_run (actor=0x7ffff54ea200) at src/libponyrt/actor/actor.c:110
#2  0x000000000041431a in run (sched=0x623870) at src/libponyrt/sched/scheduler.c:407
#3  0x00000000004143a4 in run_thread (arg=0x623870) at src/libponyrt/sched/scheduler.c:432
#4  0x00000000004146da in scheduler_start (library=false) at src/libponyrt/sched/scheduler.c:516
#5  0x000000000040c5c7 in pony_start (library=false) at src/libponyrt/sched/start.c:149
#6  0x0000000000409fc9 in main ()

ponyc: in HEAD (f858169d)
gcc: 5.1.0
clang: 3.6.1 (Don't know if it's using gcc or clang, so I put here both :P)
llvm: 3.6.1
I don't know how to see the version of GLIBCXX
backtrace:
(gdb) r
Starting program: /home/rock/Git/ponyc/mandelbrot
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[New Thread 0x7ffff3ce8700 (LWP 16438)]
[New Thread 0x7ffff44e9700 (LWP 16437)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff3ce8700 (LWP 16438)]
0x000000000040dd72 in pony_traceunknown (p=0x0) at src/libponyrt/gc/trace.c:68
68        pony_type_t* type = *(pony_type_t**)p;
(gdb) bt
#0  0x000000000040dd72 in pony_traceunknown (p=0x0) at src/libponyrt/gc/trace.c:68
#1  0x0000000000411837 in actor_run (actor=0x7ffff54ea200) at src/libponyrt/actor/actor.c:110
#2  0x000000000040c29f in run (sched=0x624970) at src/libponyrt/sched/scheduler.c:407
#3  0x000000000040c32e in run_thread (arg=0x624970) at src/libponyrt/sched/scheduler.c:432
#4  0x00007ffff79bd354 in start_thread () from /usr/lib/libpthread.so.0
#5  0x00007ffff71f3bfd in clone () from /usr/lib/libc.so.6

Could you paste the output of:
readelf -sV $(/sbin/ldconfig -p | grep stdc++ | cut -d" " -f 4) | sed -n 's/.*@@GLIBCXX_//p' | sort -u -V | tail -1

?
Thanks, again!

yeah!
$ readelf -sV $(/sbin/ldconfig -p | grep stdc++ | cut -d" " -f 4) | sed -n 's/.*@@GLIBCXX_//p' | sort -u -V | tail -1
3.4.21

This is now fixed. Thank you for your input guys!!

Thanks! :smile:


AvoidCUDAOOM usage

Hi Team,
I am training a faster RCNN model and tried to use the AvoidCUDAOOM  in the following way
    from mmdet.utils import AvoidOOM
    from mmdet.apis import train_detector
    from mmdet.models import build_detector
    from mmdet.datasets import build_dataset
    AvoidCUDAOOM = AvoidOOM()
    cfg, _ = load_config(data_folder)
    datasets = [build_dataset(cfg.data.train)]
    model = build_detector(cfg.model, train_cfg=cfg.get("train_cfg"), test_cfg=cfg.get("train_cfg"))
    AvoidCUDAOOM.retry_if_cuda_oom(train_detector)(model, datasets, cfg, validate=True)

The code working fine without the OOM. But when I Use the OOM, it's throwing the following error. Can you please let me know if I am doing something wrong?
Traceback (most recent call last):
  File "basicHighResolution.py", line 150, in <module>
    output = AvoidCUDAOOM.retry_if_cuda_oom(train_detector)(model, datasets, cfg, validate=True)
  File "/mmdetection/mmdet/utils/memory.py", line 160, in wrapped
    raise ValueError('There is no tensor in the inputs, cannot get dtype and device')

I am also facing the same issue. I am using it in the following way -
from mmdet.utils import AvoidCUDAOOM
AvoidCUDAOOM.retry_if_cuda_oom(train_detector)(model, datasets, cfg, validate=True)

AvoidCUDAOOM only works with functions that take tensors as input.

Seems that AvoidCUDAOOM is not in our doc, we should update it.


[shape][glyph] add restProps + additionalProps. fixes #71

Coverage decreased (-0.01%) to 27.517% when pulling 9bceae99ed4fc608676970db7dc1ea3b04bf7c16 on harry-shapes-fix into f77d8f53fb0b2e3ad793dd09c8984bc72f296e46 on master.


detect table alignment (left, center, right) with the first row of every range

for now, there will be four enums: general, general-left, center, right

added https://github.com/pffy/googledocs-addon-markdowntablethree/issues/7


Installation failed due some failed tests

Hi,
I'm installing Bailador 0.0.8 in a fresh installation of Perl 6 on Mac with Rakudobrew:
$ perl6 --version
This is Rakudo version 2017.07 built on MoarVM version 2017.07
implementing Perl 6.c.

When I try to install Bailador with:
$ zef install Bailador
I got:
===> Testing: Bailador:ver('0.0.8')
# Skipping author test. Set AUTHOR_TESTING to enable.
# Skipping author test. Set AUTHOR_TESTING to enable.
# Skipping author test. Set AUTHOR_TESTING to enable.

    # Failed test 'program terminated successfully'
    # at t/20-cli.t line 97
    # expected: '0'
    #      got: '1'

    # Failed test 'text matches 'rx:s/Result\: PASS/''
    # at t/20-cli.t line 100
    #      expected: 'rx:s/Result\: PASS/'
    #      got: ''
    # Looks like you failed 2 tests of 3

# Failed test 'test newly generated app with its test cases'
# at t/20-cli.t line 90
# Looks like you failed 1 test of 9

    # Failed test 'route GET /hello/Foo.html'
    # at t/30-examples-app.t line 68
    # expected: $[200, [:Content-Type("text/html")], "Hello Foo.html!"]
    #      got: $[404, [:Content-Type("text/html;charset=UTF-8")], "\n    \n        <title>Custom 404 page</title>\n        <meta charset=\"UTF-8\">\n    \n    \n
Hello, this is 404 for you.
\n    \n\n"]
    # Looks like you failed 1 test of 2

===> Testing [FAIL]: Bailador:ver('0.0.8')

Then I forced the installation with:
$ zef install Bailador --force-test
Bailador was installed, but I got another failed tests:
===> Testing: Bailador:ver('0.0.8')
# Skipping author test. Set AUTHOR_TESTING to enable.
# Skipping author test. Set AUTHOR_TESTING to enable.
# Skipping author test. Set AUTHOR_TESTING to enable.

    # Failed test 'program terminated successfully'
    # at t/20-cli.t line 97
    # expected: '0'
    #      got: '1'

    # Failed test 'text matches 'rx:s/Result\: PASS/''
    # at t/20-cli.t line 100
    #      expected: 'rx:s/Result\: PASS/'
    #      got: ''
    # Looks like you failed 2 tests of 3

# Failed test 'test newly generated app with its test cases'
# at t/20-cli.t line 90

    # Failed test 'text matches 'rx:s/\
Bailador App\<\/h1\>/''
    # at t/20-cli.t line 129
    #      expected: 'rx:s/\
Bailador App\<\/h1\>/'
    #      got: ''

    # Failed test 'text matches 'rx:s/Version 0\.0\.1/''
    # at t/20-cli.t line 130
    #      expected: 'rx:s/Version 0\.0\.1/'
    #      got: ''
    # Looks like you failed 2 tests of 2

# Failed test 'start app with bin/bailador watch'
# at t/20-cli.t line 109

    # Failed test 'text matches 'rx:s/\
Bailador App\<\/h1\>/''
    # at t/20-cli.t line 160
    #      expected: 'rx:s/\
Bailador App\<\/h1\>/'
    #      got: ''

    # Failed test 'text matches 'rx:s/Version 0\.0\.1/''
    # at t/20-cli.t line 161
    #      expected: 'rx:s/Version 0\.0\.1/'
    #      got: ''
    # Looks like you failed 2 tests of 2

# Failed test 'test app with watch command without bin directory'
# at t/20-cli.t line 138
# Looks like you failed 3 tests of 9

    # Failed test 'route GET /hello/Foo.html'
    # at t/30-examples-app.t line 68
    # expected: $[200, [:Content-Type("text/html")], "Hello Foo.html!"]
    #      got: $[404, [:Content-Type("text/html;charset=UTF-8")], "\n    \n        <title>Custom 404 page</title>\n        <meta charset=\"UTF-8\">\n    \n    \n
Hello, this is 404 for you.
\n    \n\n"]
    # Looks like you failed 1 test of 2

===> Testing [FAIL]: Bailador:ver('0.0.8')
Failed to get passing tests, but continuing with --force-test

It is probably because of this #194 that has been fixed after 0.0.8 was released.
Try the following to check if indeed this is the source of problem:
killall moar
zef test Bailador

I did this:

Clone the repository
Executed both commands you suggested
I got this error:

===SORRY!===
Could not find Terminal::ANSIColor at line 3 in:
[ ... ]

Installed Terminal::ANSIColor
Executed again: zef test Bailador
I got this:

$ zef test Bailador
===> Testing: Bailador:ver('0.0.8')
# Skipping author test. Set AUTHOR_TESTING to enable.
# Skipping author test. Set AUTHOR_TESTING to enable.
# Skipping author test. Set AUTHOR_TESTING to enable.

    # Failed test 'route GET /hello/Foo.html'
    # at t/30-examples-app.t line 68
    # expected: $[200, [:Content-Type("text/html")], "Hello Foo.html!"]
    #      got: $[404, [:Content-Type("text/html;charset=UTF-8")], "\n    \n        <title>Custom 404 page</title>\n        <meta charset=\"UTF-8\">\n    \n    \n
Hello, this is 404 for you.
\n    \n\n"]
    # Looks like you failed 1 test of 2
===> Testing [OK] for Bailador:ver('0.0.8')

Thanks for checking. The last one is a pass. The failure you see is a todo test that Test or maybe prove6 should report as such or should not display at all.

on my Mac
perl --version
says
This is Rakudo version 2017.04.3 built on MoarVM version 2017.04-53-g66c6dda
implementing Perl 6.c.
After cloning repo, installing necessary modules and run
zef test Bailador
I've got
t/30-examples-app.t ...........4/15

    # Failed test 'route GET /hello/Foo.html'
    # at t/30-examples-app.t line 68
    # expected: $[200, [:Content-Type("text/html")], "Hello Foo.html!"]
    #      got: $[404, [:Content-Type("text/html;charset=UTF-8")], "\n    \n        <title>Custom 404 page</title>\n        <meta charset=\"UTF-8\">\n    \n    \n
Hello, this is 404 for you.
\n    \n\n"]
    # Looks like you failed 1 test of 2
t/30-examples-app.t ........... ok
t/30-examples-echo.t .......... ok
t/30-examples-err.t ........... ok
t/30-examples-gradual.t ....... ok
t/30-examples-pastebin.t ...... ok
t/30-examples-postapp.t ....... ok
All tests successful.
Files=37, Tests=1248,  104 wallclock secs
Result: PASS
===> Testing [OK] for Bailador:ver('0.0.8')

So I was manage to install Bailador successfully.
All tests successful.
Files=37, Tests=1248,  117 wallclock secs
Result: PASS
===> Testing [OK] for Bailador:ver('0.0.8')
===> Installing: TAP::Harness:ver('0.0.2'):auth('Leon Timmermans')
 ===> Installing: Bailador:ver('0.0.8')

2 bin/ scripts [prove6 bailador] installed to:
/usr/local/Cellar/rakudo-star/2017.04/share/perl6/site/bin

Thank you. Installation process was unobvious for old Perl5 freak. =)

@sed76 you don't need to clone the repo to install Bailador. Only if you'd like to contribute to the project. Which you'd be welcome to!

this seems to be a duplicate of #224


add systemlogs test.

System logs tests addition.

Codecov Report

Merging #149 (b8543c3) into master (ee57d14) will increase coverage by 3.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   65.79%   68.98%   +3.18%
==========================================
  Files          11       11
  Lines         345      345
==========================================
+ Hits          227      238      +11
+ Misses         96       85      -11
  Partials       22       22

Impacted Files
Coverage Δ

pkg/collector/systemlogs_collector.go
73.33% <0.00%> (+73.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee57d14...b8543c3. Read the comment docs.

Good to me. Please go ahead to merge.


LinkToBlank should accept rel="sponsored"

Google suggests using rel="sponsored" for external sponsored links, but this trips the LinkToBlank cop.
Expected behavior
link_to('Title', 'external.url', target: '_blank', rel: 'sponsored')

Expect this to not register a rubocop offense.
Actual behavior
An offense is registered:
C: Rails/LinkToBlank: Specify a :rel option containing noopener.
          target: '_blank',
          ^^^^^^^^^^^^^^^^

RuboCop version
$ rubocop -V
0.80.1 (using Parser <IP_ADDRESS>, running on ruby 2.6.2 x86_64-darwin18)

The linked page doesn't mention how this impacts security, is it functionally equivalent to using `sponsored? I searched couldn't find anything definitive.

@andyw8 yeah that's a good point. It supercedes nofollower as far as I understand, but I can't find any straight answer about noopener.


Upgrade to Unicode 11.0.0

Matches https://github.com/python/cpython/pull/7439
Resolves #18

:+1:

Thank you!


Creates a blocking web server

Given this code implemented in a deno server, it creates a server request handler that blocks. Meaning if you open up CURL and make two successive requests, the second request doesn't start until the first one finishes.
Is there any way to prevent this? Or is it just not feasible to have it run within a web-server like this? I can imagine that the wasm bundle code can only handle one image in memory at a time, which is why it blocks?
import { reservedPath } from "./code/cloud_asset/cloud_api/utils/reserved_path/mod.ts";
import { ImageMagick, initialize } from "./code/utils/imagemagick/mod.ts";

const file = await Deno.readFile('./my-image.png')
await initialize()

Deno.serve((_req) => {
  console.log(`request made`)
  if (reservedPath(_req.url)) {
    return new Response("Not Found", { status: 404 });
  }
  const headers = new Headers();
  headers.set("Content-Type", "image/png");
  const i = ImageMagick.read(file, (v) => {
    return v.write(g => g)
  })
  console.log(`request served`)
  return new Response(i, { headers });
})

I've tried awaiting everything, I've tried wrapping this ImageMagick.read in a promise, running of them and not awaiting, the first still needs to finish before the second starts. The fundamental code is sync and it seems that there is no way around it. I'm assuming there's a reason for this, something WASM related?

Apparently Deno deploy supports child processes, so I could possible circumvent this using a child process, I'm gonna go that route for now, but if there's a better way let me know.

I was wrong >.<

I have no clue why this is blocking, The ImageMagick code has locks for coders that don't support multithreading but that should not be an issue here. Maybe the wasm code can only run in a single thread? Don't think I can help you much because I don't have deno experience.

Another attempt with no luck
import { Gravity, ImageMagick, Point, initializeImageMagick } from<EMAIL_ADDRESS>
const file = await Deno.readFile('./image.png')
await initializeImageMagick()

let streamController: any;

function startStream(controller: ReadableStreamDefaultController) {
  streamController = controller;
  // You can start your stream empty
}

function updateStream() {
  ImageMagick.read(file, (v) => {
    v.compositeGravity(v, Gravity.North, new Point(1000, 1000))
    return v.write(g => {
      streamController.enqueue(g)
      streamController.close()
      console.log(`request served 👍`)
    })
  })
}

function handler(_req: Request): Response {
  console.log(`request started ✅`)
  const body = new ReadableStream({
    start: startStream
  });

  updateStream()

  return new Response(body, {
    headers: {
      "content-type": "image/png",
      "x-content-type-options": "nosniff",
    },
  });
}

Deno.serve(handler);

@oscarotero do you have any thoughts on this? How is Lume currently using this in a non-blocking way?

Also to clarify non-blocking, requests appear to always be queued, and re not concurrent.
What I'm seeing:
request started ✅
request served 👍
request started ✅
request served 👍
What I want:
request started ✅
request started ✅
request served 👍
request served 👍
Note browsers will queue request to the same domains, you need to use curl to test.

more findings:
import { Gravity, ImageMagick, Point, initializeImageMagick } from<EMAIL_ADDRESS>
const file = await Deno.readFile('./image.png')
await initializeImageMagick()

console.log('a')

ImageMagick.read(file, (v) => {
  v.compositeGravity(v, Gravity.North, new Point(1000, 1000))
  v.write(g => {
    console.log(`done 1`)
  })
})

console.log('b')

ImageMagick.read(file, (v) => {
  v.compositeGravity(v, Gravity.North, new Point(1000, 1000))
  v.write(g => {
    console.log(`done 2`)
  })
})

console.log('c')

a
done 1
b
done 2
c

and this seems not to block
import { Gravity, ImageMagick, Point, initializeImageMagick } from<EMAIL_ADDRESS>
const file = await Deno.readFile('./image.png')
await initializeImageMagick()

console.log('a')

ImageMagick.read(file, async (v) => {
  await Promise.resolve()
  v.compositeGravity(v, Gravity.North, new Point(1000, 1000))
  v.write(g => {
    console.log(`done 1`)
  })
})

console.log('b')

ImageMagick.read(file, async (v) => {
  await Promise.resolve()
  v.compositeGravity(v, Gravity.North, new Point(1000, 1000))
  v.write(g => {
    console.log(`done 2`)
  })
})

console.log('c')

a
b
c
done 1
done 2

Can we conclude this is something in Deno.serve then and close the issue here?

if anyone is interested https://stackoverflow.com/questions/76791229/wasm-imagemagick-based-code-blocks-deno-server

@reggi The problem is JavaScript is single-threaded language, it means that only can run one thing at a time. Async functions and promises don't allow to run things concurrently, but they are added to the event loop. If you measure the total time spend to run the code, no matter if you use promises or not, the time will be the same. Just place this code at the end of your script and you will get similar values:
addEventListener('unload', () => {
  console.log(performance.now());
});

The only way to run code in parallel in JavaScript is with Workers.
const myWorker1 = new Worker(import.meta.resolve("./worker.ts"), { type: "module" });
const myWorker2 = new Worker(import.meta.resolve("./worker.ts"), { type: "module" });
const myWorker3 = new Worker(import.meta.resolve("./worker.ts"), { type: "module" });

This code will open tree workers that are run at the same time.

@oscarotero thanks for your comment. I implemented this worker solution in the comments here https://stackoverflow.com/questions/76791229/wasm-imagemagick-based-code-blocks-deno-server, unfortunately I was trying to use Deno Deploy for my project and it doesn't support worker. Opened up a ticket with Deno Deploy (https://github.com/denoland/deploy_feedback/issues/458) to check and see if the blocking issue here will also be an issue using Deno Deploy as it's on the edge, and instances should be spun up and handled when needed but I have batching concerns, anyway thanks for your comment. Good to know we're on the same page.


Changes to user's MFA should result in email

As a user with a registered MFA method, I would like to receive email notifications for all updates related to my MFA, so that if I receive an email referencing a change I am not aware of I can expect my account to be compromised and follow the recommended steps.
ACs

Any actions changing or resetting authentication mechanisms will trigger automated emails to the email address of the user
Email should make specific reference to the MFA method
Email should provide steps for the user to take if the change was not expected
Email template is theme-able

Notes

Examples of changing or reseting:
a. MFA method is registered
b. MFA method is removed
c. Recovery codes are reset
d. Recovery code is used
e. One recovery code left?

Comment from #25 (when you almost run out of backup codes):

@robbieaverill : I think an FYI email might be a good idea, perhaps saying "please log in and reset your backup codes if you'd like to generate a new set" or something like that (wording TBC).
We could either do this with queuedjobs or with an extension point in the login process, but either way we'd probably only want to notify the user once (?) rather than every time they login, or the job runs.

Relevant core issue here: https://github.com/silverstripe/silverstripe-framework/issues/8594

Example "e. One recovery code left?" - I thought there was a separate issue for that. I think it must be https://github.com/Firesphere/silverstripe-bootstrapmfa/issues/11 which hasn't been brought over to this repo. Either way I think we should treat it separately to this issue.

@robbieaverill

I thought there was a separate issue for that

It was covered in #25 but I closed it for this one. I'm happy for you to reopen that issue if it makes sense to handle it separately.

Moved back to Ready and removed @NightJar's assignment. Not sure what progress was made, but might be worth checking with NightJar


Retention email generator implementation

Tasks

[ ] Create content generator that will be sent to email service

References

Product doc

Blocked by

https://github.com/thematters/matters-server/issues/2786

Issue requires review and rearrangement. Close it.


Create windows installer using electron-builder

this should create an NSIS installer

done in https://github.com/arzynik/wowstat/releases/tag/3.0.2


Bump to 0.7.6

Seems to work on AWS. The cluster on Azure is still creating

Seems to work on AWS. The cluster on Azure is still creating

What is the progress here? it's blocking me for the 14.0.0 release

What is the progress here? it's blocking me for the 14.0.0 release

0.7.6 does not work on azure with this error:
level=error msg="Failed to extract targets for '....' with type 'NS'."

If its pressing, lets do a release 1.6.0 with 0.7.6 included. Otherwise I wanted to try to use managed-record-types flag for azure

0.7.6 does not work on azure with this error:
level=error msg="Failed to extract targets for '....' with type 'NS'."

If its pressing, lets do a release 1.6.0 with 0.7.6 included. Otherwise I wanted to try to use managed-record-types flag for azure

@calvix seems the log line is not as bad as it sounds. Can you approve? Do I need to add this to the requests.yaml in releases?

@calvix seems the log line is not as bad as it sounds. Can you approve? Do I need to add this to the requests.yaml in releases?

i don't you need to add to the request for was as I will be updating it anyway
it's usually used when you need to force the version due to some important bugfix or compatibility

i don't you need to add to the request for was as I will be updating it anyway
it's usually used when you need to force the version due to some important bugfix or compatibility


chore(deps) Update dns dependency and options

updates the dns lib to 0.6.0, adds the new dns_stale_ttl option.

It feels like we are adding a lot of configuration values that maybe feel overkill? Is there really a common use case for each one of these 5 new values, and can't a few of them be either grouped together, or be hard coded with sane values?

Considering the amount of issues we've had, I'd like to stick to them for now. Except for the dns_no_sync one, which has only one sane setting which is the current default.

Considering the amount of issues we've had, I'd like to stick to them for now. Except for the dns_no_sync one, which has only one sane setting which is the current default.

Sounds good, let's postpone this to the incoming revamp/cleanup of the config file then.

@Tieske LGTM, but if you want proper CI testing, you'll need to purge the cache on Travis which uses lua-resty-dns-client 0.5 from prior builds.

Merged without the title case "Update". Thanks!


Regenerate CLDF with sources and update metadata

Closes #7 and #1

By the way, there is only a total of 65 languages in languages.csv, the paper mentions 66 languages. Is this mentioned somewhere or is there a language missing?

The LJ list of Bukiyip was not disclosed due to the request from the contributor.

The LJ list of Bukiyip was not disclosed due to the request from the contributor.

Ah, thanks for clarifying!

The LJ list of Bukiyip was not disclosed due to the request from the contributor.

Maybe, adding this to "NOTES.md" would be useful.

@ianjoo do you have a preferred text that should be included in the NOTES.md and is displayed for the dataset? I'll also update the contributors as per Mattis' suggestions.


init.sh improvements and nginx-lb bugfix

02-nginx-lb.svc.deployment.yaml

fixed bad namespace

init.sh

moved namespace creation lower to ease iterative testing
improved question flow for basic-auth with a default user
improved SMTP config question flow as well as making it optional
same for slack config
updated read statements in AWS key config to ensure backspace works
removed superfluous messaging

ah my apologies. the nginx-ingress namespace does cause an error, when
running init.sh, if you aren't using RBAC
-dave
https://devopsadvice.com
http://reverbnation.com/fsaadd
http://nyfac.es
On Wed, May 24, 2017 at 1:27 PM, Camil Blanaru<EMAIL_ADDRESS>wrote:

@camilb requested changes on this pull request.
The namespace should be left as nginx-ingressfor now, otherwise will not
work with RBAC. This will not create any issue if you are not using RBAC.
The rest of changes looks very good to me. Thanks for your efforts!
In k8s/ingress/02-nginx-lb.svc.deployment.yaml
https://github.com/camilb/prometheus-kubernetes/pull/8#discussion_r118309629
:

@@ -2,7 +2,7 @@ apiVersion: v1
kind: Service
metadata:
name: default-http-backend

namespace: nginx-ingress

namespace: monitoring

@downneck https://github.com/downneck Moved the Ingress Controller to a
separate namespace. Initially tried to create a new service account for the
ingress controller but it seems that nginx ingress is looking for the
default service account even if I specify a different one in pod
definition. When RBAC is enabled, special permissions have to be granted to
ingress controller, so I created a new namespace and added permissions to
the default service account. It doesn't matter in which namespace the
Ingress controller is placed. It will work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/camilb/prometheus-kubernetes/pull/8#pullrequestreview-40089438,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIdMhc8HCCytPBKtuVKRATcBLNSOaCMks5r9GhngaJpZM4NlX_0
.

Yes, you're right. I remember now that I moved the namespace creation inside the RBAC config file. Please add a line to create the namespace if the RBAC is disabled. Thanks!

Better remove this part from rbac/02-nginx-ingress-rbac-config.yaml and create the namespace at the same time with the monitoringnamespace.
apiVersion: v1
kind: Namespace
metadata:
  name: nginx-ingress
---

ok, will do
-dave
https://devopsadvice.com
http://reverbnation.com/fsaadd
http://nyfac.es
On Wed, May 24, 2017 at 1:37 PM, Camil Blanaru<EMAIL_ADDRESS>wrote:

Better remove this part from rbac/02-nginx-ingress-rbac-config.yaml and
create the namespace at the same time with the monitoringnamespace.
apiVersion: v1
kind: Namespace
metadata:
name: nginx-ingress
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/camilb/prometheus-kubernetes/pull/8#issuecomment-303797227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIdMrJjeVPXOFE00-IZgPqLz9jdZKobks5r9Gr1gaJpZM4NlX_0
.

In the future I'm thinking to let users choose if they want to use the ingress. Could be users that already use another solutions (traefek, elb, alb). Some may just want to use the local proxy.

that sounds great. having options is better for users and, while it'll make
the setup more complicated, it should make the resulting deployment less
complex.
-dave
https://devopsadvice.com
http://reverbnation.com/fsaadd
http://nyfac.es
On Wed, May 24, 2017 at 1:57 PM, Camil Blanaru<EMAIL_ADDRESS>wrote:

In the future I'm thinking to let users choose if they want to use the
ingress. Could be users that already use another solutions (traefek, elb,
alb). Some may just want to use the local proxy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/camilb/prometheus-kubernetes/pull/8#issuecomment-303802927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIdMuwctoY_fNTN4kFLou1Wan8ASlMtks5r9G-ZgaJpZM4NlX_0
.

Yes, I'll make the changes after merging your PR.

ok...afaik, you don't have to close a PR if you want it revised. i'm not
super experienced at github's workflow, but I think the PR will
automatically update with additional commits to my fork if it's still open.
either way, i'm testing the additional changes and will open another PR
shortly. thanks!
-dave
https://devopsadvice.com
http://reverbnation.com/fsaadd
http://nyfac.es
On Wed, May 24, 2017 at 2:03 PM, Camil Blanaru<EMAIL_ADDRESS>wrote:

Yes, I'll make the changes after merging your PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/camilb/prometheus-kubernetes/pull/8#issuecomment-303804619,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIdMjNB1IPXKm-5qLIz8fO4tFqH4qUxks5r9HDvgaJpZM4NlX_0
.

forgot to mention in the commit messages:
k8s/prometheus/00-alerts.cm.yaml

updated the high disk alert to use /dev/xvda1 which is more standard in EC2

i'm not sure i follow. can you provide an example of a value that's not
getting set properly?
-dave
https://devopsadvice.com
http://reverbnation.com/fsaadd
http://nyfac.es
On Wed, May 24, 2017 at 4:44 PM, Camil Blanaru<EMAIL_ADDRESS>wrote:

@camilb requested changes on this pull request.
In init.sh
https://github.com/camilb/prometheus-kubernetes/pull/8#discussion_r118359336
:

-prompt="SMTP Password:"
-while IFS= read -p "$prompt" -r -s -n 1 char
-do

if [[ $char == $'\0' ]]
then

   break

fi
prompt='*'
smtp_password+="$char"
-done
-echo

#update configmap with SMTP relay info
sed -i -e 's/your_smtp_smarthost/'"$smtp_smarthost"'/g' k8s/prometheus/03-alertmanager.configmap.yaml

these values should to be also changed in the target files. Some values
are not matched by sed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/camilb/prometheus-kubernetes/pull/8#pullrequestreview-40144695,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIdMq7aqQjaupubxRm6FDWgp6W_yMxTks5r9Ja9gaJpZM4NlX_0
.

sure, for example, your_smtp_smarthost in init.sh is not the same in k8s/prometheus/03-alertmanager.configmap.yamlwhre is your_smtp_host.

At this stage it looks fine to me. Wold you like to add more changes in this PR?

Tested and everything works fine.Merging.

thanks!
On May 24, 2017 8:28 PM, "Camil Blanaru"<EMAIL_ADDRESS>wrote:

Merged #8 https://github.com/camilb/prometheus-kubernetes/pull/8.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/camilb/prometheus-kubernetes/pull/8#event-1096563754,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIdMscEA3Ig-g-waw_zLBXzGEJSfIKFks5r9MtIgaJpZM4NlX_0
.


TypeError: dataclass_transform() got an unexpected keyword argument 'field_specifiers'

$ python startup.py "Write a cli snake game based on pygame"
Traceback (most recent call last):
  File "~/metagpt/startup.py", line 7, in <module>
    from metagpt.roles import Architect, Engineer, ProductManager, ProjectManager
  File "~//metagpt/metagpt/roles/__init__.py", line 9, in <module>
    from metagpt.roles.role import Role
  File "~/metagpt/metagpt/roles/role.py", line 12, in <module>
    from pydantic import BaseModel, Field
  File "~/opt/anaconda3/lib/python3.9/site-packages/pydantic-1.10.7-py3.9.egg/pydantic/__init__.py", line 2, in <module>
    from . import dataclasses
  File "~/opt/anaconda3/lib/python3.9/site-packages/pydantic-1.10.7-py3.9.egg/pydantic/dataclasses.py", line 48, in <module>
    from .main import create_model, validate_model
  File "~/opt/anaconda3/lib/python3.9/site-packages/pydantic-1.10.7-py3.9.egg/pydantic/main.py", line 120, in <module>
    @dataclass_transform(kw_only_default=True, field_specifiers=(Field,))
TypeError: dataclass_transform() got an unexpected keyword argument 'field_specifiers'

Caused by pydantic?
Googled and find this: https://github.com/explosion/spaCy/issues/12034

Due to the lack of updates or replies by the user for a long time, we will close it. Please reopen it if necessary.


Fix bokeh version for compatibility

The change to version 3 of bokeh has caused errors #1 in the compatibility portion of the interface. Workaround for now is to fix the version back to the way it was before.

It has not been fixed yet.
Compatibility issues with the libraries currently used in Colab need to be resolved.

Due to Colab, I have no choice but to support bokeh3. #4 was addressed.


Mannequins/Blogpost Trained with 16K VQGAN

https://www.dropbox.com/s/x9gbxiartrqaewf/afiaka_544I_96TSL_12D_16H_64DH_sparse.zip
@robvanvolt @rom1504  sorry i dont have time to make a PR to dalle-models yet but I will asap.
If you're here from the discord - sorry I didn't leave this better packaged. The zip is 2 GiB but the main dalle.pt is just 445 megabytes. It's not a huge model or anything but you don't really need one on this dataset. If you wanna finetune from it, i've included in the optimizer states from the deep speed training session as well. I used deep speeds WarmupDecayScheduler.
Anyway I finally hit the loss floor with it which I believe to be around 2.2. If anyone thinks they can get lower than that - good luck.
Sorry there are no generations posted - I'm sure they look great; but I'm only posting because there are newer...better VQGANs out now. And I must of course switch to those.

Awesome stuff! I'll try to be testing / playing with this model on my part and possibly add it to the colab if your comfortable with that.

@afiaka87 Works great!
a female mannequin dressed in a bright blue jacket and bright red skirt

@afiaka87 Works great!
a female mannequin dressed in a bright blue jacket and bright red skirt

Feel free to link it! It can also (try) to do lots of other stuff like -

an emoji of a baby penguin wearing a blue hat, blue gloves, red shirt, and green pants
a photo of the city streets of france
a professional high quality emoji of a pikachu tiger chimera. a pikachu imitating a tiger. a pikachu made of tiger. a professional emoji.
a black and white photograph of an eagle sitting in a forest during spring
a pencil sketch of a cougar sitting in a field at twilight
a female mannequin dressed in a black pullover sweater and blue wrap skirt
a living room with two red armchairs and a painting of a galleon. the painting is mounted behind an indoor palm.
a photo of the a museum in new zealand
a black and white photograph of a capybara sitting on a mountain at dusk
a female mannequin dressed in an olive button-down shirt and gold palazzo pants
a female mannequin dressed in a beige leather jacket and orange palazzo pants
an illustration of a baby hedgehog in a cape staring at its reflection in a mirror
2 panel image of the exact same teapot. on the top, a photo of the teapot. on the bottom, the teapot with a brain. [source teapot photo 5]
a professional high quality illustration of a turtle octopus chimera. a turtle imitating an octopus. a turtle made of octopus.
a female mannequin dressed in a gray leather jacket and yellow sweatpants
a painting of an eagle sitting in a field in the morning in surrealist style
a professional high quality emoji of a chicken phoenix chimera. a chicken imitating a phoenix. a chicken made of phoenix. a professional emoji.
a purse in the form of a butterfly wing. a purse imitating a butterfly wing.
an illustration of a shrimp with headphones igniting a firework
a professional high quality illustration of a cat rabbit chimera. a cat imitating a rabbit. a cat made of rabbit.
a professional high quality illustration of a toad octopus chimera. a toad imitating an octopus. a toad made of octopus.
a male mannequin dressed in an olive and black checkered button-down shirt and black pleated trousers
an illustration of a baby tapir in a cape writing a letter
a small blue book standing to the right of a large red book
a photo of westwood park, san francisco, from the water in the afternoon
an emoji of a baby hedgehog wearing a yellow hat, red gloves, blue shirt, and green pants

Here is a line separated list of 12,800 captions from the dataset. You could literally just pipe them into it automatically in colab - it probably won't do very well on much else.
sample_12800.txt.gz
Download and grab 32 mannequin captions.
wget 'https://github.com/lucidrains/DALLE-pytorch/files/6719423/sample_12800.txt.gz'
tar xf sample_12800.txt.gz;
shuf sample_12800.txt | grep 'mannequin' | head -n 32 > 32_mannequin_captions.txt

oh yes - the image mask feature should be interesting to test with this checkpoint.

Made a colab specifically for inferencing this model: https://colab.research.google.com/drive/11V2xw1eLPfZvzW8UQyTUhqCEU71w6Pr4?usp=sharing

moving to discussions https://github.com/lucidrains/DALLE-pytorch/discussions/322


HAProxy bin and bout metrics are incorrect.

HAProxy defines bin and bout metric as
 8. bin [LFBS]: bytes in
  9. bout [LFBS]: bytes out

They are not per seconds, they are absolute values from the last time HAProxy was restarted.
In the plugin you send them as rate
        "bin": ("rate", "bytes.in_rate"),
        "bout": ("rate", "bytes.out_rate"),

And in the Datadog web interfaces, they are defined as gauge

In the end, this is translate to an invalid graphic.
In this case, I'm having in the HAPRoxy  close to 30MB/s but this is the graph printed by the metric

Hallo,
When a metric is submitted as rate it is not submitted raw, the conversion to per second is done in app. Which I mean by this is that the numbers you're seeing in DD are not the numbers emitted by haproxy. What we can do is emit new metrics frontend.bytes.in.total, frontend.bytes.out.total which are already included in the new prometheus implementation we've recently added

That would help, even the conversion you are doing to per seconds is not correctly done. As I said we are seeing 30MB/s in HAProxy using other tools but in DD we are seeing KiB. That's the main issue we are having.

Hi @doradito would you mind sharing what this other tool is and if you know how the number is calculated? In the case of DD the agent calculates the delta of that metric's value between two submissions and divides it by the submission interval to get the rate.

We use hatop and bwm-ng to monitor the traffic, also to filter by port we use iftop. I also did the calc manually, checking the stats in two different times getting the numbers, and doing the division

Hi @doradito,
I opened a pull request #7722 in order to emit backend/frontend.bytes.in/out.total metrics as raw values in the non-prometheus version of the integration. I will ping you once it’s merged, released and ready to be installed.
In order to troubleshoot the issue more precisely, we would need to request more information about your setup, the dashboard you're showing and the check behaviour in your system. Can you open a support ticket here https://docs.datadoghq.com/help/? It would also be helpful if you include a link to this issue, a debug flare (https://docs.datadoghq.com/agent/troubleshooting/send_a_flare/?tab=agentv6v7) and the output of datadog-agent check haproxy`

Hi @doradito, you can now install the new version of the haproxy check version 2.13.0 with datadog-agent integration install datadog-haproxy==2.13.0. The backend/frontend.bytes.in/out.total metrics will be emitted. I am closing this issue and I suggest we continue to investigate your issue on a support ticket. Thank you for the report!

Thanks!


NO-JIRA Fix federated-address-downstream pom

The bigger issue here seems to be that the release profile in the broker-federation parent pom is missing all the modules so that caused the version to not be updated

I will go ahead and fix the commit with that change and merge it


update crypto calls

Not finished --- the current crypto calls return wrong keys, we are waiting for update to crypto_helpers ( @xchapron-ledger ).

Superseded by https://github.com/LedgerHQ/app-cardano/pull/53


Use more ES6 syntaxes in the async example

Convert the async example files to using fat arrows and stateless components.
This is a follow up to what I started in the counter example in #1942.
I’ll be ok if we decide to stick to the old notation on this example since the fat arrows don’t add any feature in itself, except reduce the number of lines in files.
References #1800

Thank you so much!


Create hello.html

Please put them in a directory with your username as your directory name.
Cheers!


Change fishshell language color.

Hi :wave:! @arfon @pchaigno
I'd like to propose using a different color for the fishshell language. The current color is the same #88E251 green used for Shell (bash/*sh).
It's not impossible to find similarities between both *sh scripts and fishshell scripts, but they are syntactically different. Fish is also not POSIX compatible.
For this reason, I think it deserves its own color, just like PowerShell has its own color.
Maybe the color can be #EC3C2D orange/red used in the "official" logo.

👋  Hey @jbucaran, thanks for the suggestion.
Differentiating between Fish-shell and Bourne-shell scripts would be an invitation for disaster, as both shell-flavours are similar enough to risk widespread misclassification. I imagine we'd quickly get a new swarth of issues reporting Bash-repos misclassified as Fishshell.
It's safer and simpler to keep shell-scripts lumped together as they are now; also note that the current definition of the "Shell" language isn't necessarily Bourne-specific.

Fish is also not POSIX compatible.

Neither is Bash, or at least many parts of it. ;-)


remove expire mechanism

expire mechanism in brubeck is not thread-safe, and may causes some problem like #33 and #51 .


Add #107 Jython vulnerability to the Security Advisories

Since 10.2 is released, could we add #107:  "Uncontrolled Search Path Element when executing CMD." to the Security Advisories?

I'll bring it up to the team.

https://github.com/NationalSecurityAgency/ghidra/security/advisories/GHSA-pr2h-5qhx-9544


A bug in srn.py

Hi, it an excellent work. But I came into something wrong.
I find that the code in srn.py line 22 is   self.base_path = os.path.join(SHAPENET_DATASET_ROOT, "srn_{}/{}_{}".format(cfg.data.category,                                                                               cfg.data.category,                                                                               cfg.data.category,                                                                               dataset_name))
However this causes a wrong path, shouldn't it be
 self.base_path = os.path.join(SHAPENET_DATASET_ROOT, "srn_{}/{}_{}".format(cfg.data.category,                                                                               cfg.data.category,                                                                               dataset_name))
The number of parameter is three not four.

https://github.com/szymanowiczs/splatter-image/issues/10#issuecomment-1994176872

Fixed now.


missing title error: args["title"] -> args[" title"]

Need to change args['title'] to args[' title'] or change dictionary to use 'title' instead of ' title'
Error:
Exception in thread Thread-9 (handler):
Traceback (most recent call last):
  File "/usr/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.11/threading.py", line 982, in run
    self._target(*self._args, **self._kwargs)
  File "/home/epyc/ai/nucleo-ai/backend/app/ai_models/assistant_model2.py", line 156, in handler
    chain.run()
  File "/home/epyc/ai/nucleo-ai/backend/app/ai_models/ai_model_base.py", line 98, in run
    res = self.instance.run_next()
          ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/epyc/ai/nucleo-ai/backend/ai_tools/prompt_chain/chain.py", line 75, in run_next
    result = entry.run(self)
             ^^^^^^^^^^^^^^^
  File "/home/epyc/ai/nucleo-ai/backend/ai_tools/prompt_chain/entry.py", line 100, in run
    result = self.runner(instance)
             ^^^^^^^^^^^^^^^^^^^^^
  File "/home/epyc/ai/nucleo-ai/backend/app/ai_models/assistant_model2.py", line 67, in runner
    runner.run()
  File "/home/epyc/ai/nucleo-ai/backend/app/ai_models/ai_model_base.py", line 98, in run
    res = self.instance.run_next()
          ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/epyc/ai/nucleo-ai/backend/ai_tools/prompt_chain/chain.py", line 75, in run_next
    result = entry.run(self)
             ^^^^^^^^^^^^^^^
  File "/home/epyc/ai/nucleo-ai/backend/ai_tools/prompt_chain/entry.py", line 100, in run
    result = self.runner(instance)
             ^^^^^^^^^^^^^^^^^^^^^
  File "/home/epyc/ai/nucleo-ai/backend/ai_tools/prompt_chain/entry.py", line 122, in runner
    self.fn(instance, response, self.opts)
  File "/home/epyc/ai/nucleo-ai/backend/app/ai_models/function_chain_simple.py", line 71, in call_function
    result = fn.handler(inst, inst.get_opt('function_arguments'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/epyc/ai/nucleo-ai/backend/app/functions/functions.py", line 187, in run
    "result": f"Created doc: {args['title']}",
                              ~~~~^^^^^^^^^
KeyError: 'title'
^C^CException ignored in atexit callback: <bound method Client.join of <posthog.client.Client object at 0x7fe952d82d50>>
Traceback (most recent call last):
  File "/home/epyc/ai/nucleo-ai/env/lib/python3.11/site-packages/posthog/client.py", line 416, in join
    consumer.join()
  File "/usr/lib/python3.11/threading.py", line 1119, in join
    self._wait_for_tstate_lock()
  File "/usr/lib/python3.11/threading.py", line 1139, in _wait_for_tstate_lock
    if lock.acquire(block, timeout):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyboardInterrupt:

Sorry for not responding to this sooner.
This is a weird issue. It looks like it made it past the part where it saved the doc using args['title'] for the name. Do you see the doc in in the Docs tab?


[NEMO-350] Implement Off-heap SerializedMemoryStore & [NEMO-384] Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore

JIRA: NEMO-350: Implement Off-heap SerializedMemoryStore
NEMO-384: Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore
Major changes:

When a block is emitted by an executor, we write it directly to off-heap memory using DirectByteBufferOutputStream and DirectByteBufferOutputStream.

Minor changes to note:

getData() and getBuffer should be distinguished when acquiring data in SerializedPartition

Other comments:

This implementation does not ensure performance gain since the overhead of allocateDirect (malloc) surpasses the garbage collection overhead. For this reason, memory management is being implemented.

Thanks @hy00nc! I've left some comments. I also have two questions regarding the issue description.
First, I was not able to find in the code "If there is any chance of using getData() in SerializedPartition, we check the length of the SerializedData to ensure that this SerializedPartition was created from existing data". Can you point me to it?
Second, can you file a JIRA issue and add a TODO comment besides allocateDirect? That would make it clear that line of code causes overheads.
e.g.,
// TODO #999: ISSUE_TITLE

Thanks for the review @johnyangk !
For the first question, I didn't update the comment after addressing some fixes for the bug. Sorry for the confusion. Please check the updated comment :)
For the second one, maybe I can add to the existing JIRA) about the overhead. I will also add the TODO in the code, thanks!

Thanks @hy00nc! The code looks good.
I've left minor questions. I'll merge as soon as you confirm.

Thanks again! I made minor changes and it's ready to be merged :)


Change partitioning approach in ParquetStore

The elements in the ParquetStore should be partitioned so that all instances of the same edge are in the same partition, but edges for the same vertex can be in different partitions. This will allow it to deal with high degree vertices.
This change will mean that data ingested with previous versions of the ParquetStore will not be readable.

Merged into develop.
Note this is a breaking change for the Parquet store (the store is marked as experimental so breaking changes are allowed).


Estimation with singularity and bad scale

Dear Junior Maih:
Please forgive me for bothering you. I used the RISE to solve my constant MS-DSGE model. And I got a warming message:
"Matrix is close to singular or badly scaled. RCOND =  3.872922e-33.
In generic_tools.posterior_maximization_variable_quantities (line 50)
In generic/estimate (line 329)
In dsge/estimate (line 47)
In Constant_zhu (line 85)"
Based on solves of other issues with singularity and bad scale proposed in the forum, I tried to solve the issue by adding stderr_ and reseting parameters. However, the problem still cannot be solved. Could you tell me why I got the message? And how to modify it?
Here is my code:
paul.zip
Many thanks!
Paul

Hi Paul,
The singularity is not related to the measurement errors. It arises from the computation of the covariance matrix at the end of the posterior maximization process. Unfortunately the optimizer you are using doesn't reach a well-defined peak and as a result, the computed covariance matrix is not positive definite.
This problem may arise either because of a poor performance of the optimizer or because some estimated parameter lies up the boundaries of the parameter space.
Potential solutions include changing the priors so as to prevent estimation from hitting the boundaries, changing the optimizer, perhaps starting from a different initial condition.
Cheers,
J.


Whether tensorflow supports image training or retraining on c++ API

Tensorflow has supported image training or retraining on python
https://www.tensorflow.org/hub/tutorials/image_retraining
but that tutorials doesn't have any tutorials about  training or retraining on c++ API.
And here are very few discussions about this.
Whether tensorflow supports image training or retraining on c++ API?
THX

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

It has been 15 days with no activity and the awaiting response label was assigned. Is this still an issue?

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!


Stack will not be deleted when prerequisite stack is missing

What happened?
When you have two stacks where one (stack A) is a prerequsite of the other (stack B), then stack B can't be deleted after stack A has been deleted. In other words, order is not maintained during deletion and it is not fault tolerant.

Status:
  Conditions:
    Last Transition Time:  2024-11-18T16:11:42Z
    Message:               reconciliation is in progress
    Reason:                NotReadyInProgress
    Status:                False
    Type:                  Ready
    Last Transition Time:  2024-11-18T16:11:42Z
    Message:               unable to fetch prerequisite "stack-a": Stack.pulumi.com "stack-a" not found
    Reason:                PrerequisiteNotSatisfied
    Status:                True
    Type:                  Reconciling
...

Output of pulumi about
n/a
Additional context
Pulumi Operator versions tested:

1.16.0
1.14.0

This is especially a problem when using GitOps tools like Flux and ArgoCD.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Thanks for the report, your finds ring true.  You're responsible for the lifecycle of the Stack objects, and nothing prevents you from deleting a prerequisite stack.
Would a possible solution be to use Argo CD sync waves? I believe that, by using two distinct waves, the ordering will be preserved during creation and deletion.  Could you give that a try?  For example:
apiVersion: pulumi.com/v1
kind: Stack
metadata:
  name: stack-a
  annotations:
    argocd.argoproj.io/sync-wave: "1"
---
apiVersion: pulumi.com/v1
kind: Stack
metadata:
  name: stack-b
  annotations:
    argocd.argoproj.io/sync-wave: "2"
spec:
  prerequisites:
    - name: stack-a
      requirement:
        succeededWithinDuration: 1m

Hi Eron,
Thanks for your reply. I guess what you suggest for ArgoCD might work, but would make things complicated.
Actually we use Flux. Here we could solve it with dependencies, but it is even more complicated and an ugly workaround. It would make code very confusing for handling multiple dependencies.
As a user I would expect that when I configure dependencies, then the operator would respect order also when deleting objects. The pulumi operator currently only respects oder for creation. Why should I rely on another operator for deletion? Then I don't need it in the Pulumi Operator at all.
The question is, why the Pulumi Operator does even check for existence of prerequisite stacks when destroying a stack and cancels the process when prerequisites are missing. From my point of view this is not necessary.
For now we removed the prerequisite completely. Stacks with missing prerequisites are destroyed and for creation, they are retried, until the prerequisite is up.

@beffe123 makes a good point:

The question is, why the Pulumi Operator does even check for existence of prerequisite stacks when destroying a stack and cancels the process when prerequisites are missing. From my point of view this is not necessary.

When a Stack is deleted, the behavior varies based on the destroyOnFinalize field.  When enabled, a pulumi destroy operation is run during finalization. The dependent blocks because it may be that the prerequisite stack produces outputs or other effects that the dependent relies on.  How about we add a flag to the prerequisites block to control whether a given prerequisite should block deletion?
To be clear, when destroyOnFinalize is disabled, the dependent doesn't block.


Installation issue after upgrade to 1.4.0

Description
After upgrading to v1.4.0 I'm getting an issue when installing the app in iOS. The errors thrown are:
Multiple commands produce '/Users/user_name/Library/Developer/Xcode/DerivedData/projectName-cqlfmtjboujykabujkqvrublhouw/Build/Products/Debug-Dev-iphonesimulator/react-native-skia/react_native_skia.framework/Headers/GrBackendSemaphore.h'
The same happens with various header files, all prefixed with 'Gr' and sourced both from cpp/skia/include/gpu/ and cpp/skia/include/gpu/ganesh (probably related to the new experimental WebGPU in this version)

Version
1.4.0
React Native 0.73.9
Steps to reproduce
Upgrade and attempt installation in ios
Snack, code example, screenshot, or link to a repository
"react-native": "0.73.9",
"@shopify/react-native-skia": "~1.4.0",

thanks for reporting this, will fix it asap

my apologies for this. I was confused about the issue, publishing a fix for it now.

Hey @wcandillon I seem to have this is with the 1.5.0 build too:
'include/gpu/ganesh/GrDirectContext.h' file not found


Documentation for testing

Proposed Changes

Added a section in the readme for how to test new features

I used this procedure and it worked, but of course feel free to change it if you have a preferred or more clear method

Fixed some indentation in the readme
Fixed a couple minor typos

I'm not sure why pre-commit didn't like my fenced code blocks, but it likes your fenced code blocks...? Any ideas?
Yours (which don't seem to properly turn to code block, still showing the backticks, maybe since it's indented, it's not counting the ```yaml at all?):

Mine (which properly turns into a code block but without yaml formatting):


chore: added owner in modules: dns, nat, router, log-export , vpn, vpc-sc

Added owner in dns, nat, router, log-export , vpn, vpc-sc

applied


Test staking contract full stack

We now have a stable v0.8.0-alpha3 release and integration tests for the staking contract in wasmd.
To fully demo this, we need some very high level tests via cosmwasm-js showing the contract in use. It only needs to cover a happy path, but mainly showing client interaction down to the contract working.

Where/how do you want to write those tests? 0.8.0-alpha.0 is published and can be used from npm

I was thinking to add them to cosmwasm-js, but I guess that is a bit ugly. But we do have the erc20 and mask contracts in there already. I think a few demo runs on the staking contract like we do with erc20 would be a simple addition.
If you have a better approach, please let me know.

Which contract are we talking about exactly? This one https://github.com/CosmWasm/cosmwasm/tree/master/contracts/staking?
One ugly thing I see here is that we don't get a source URL. Also this repo is not well suited to host contract specifics. Having the erc20 connection here is just because we use them as a secondary currency implementation to the bank module in BCP, which will die sooner or later. Then we have some notes in to CLI package, but those are not tested.
We could create a package with unit tests for one contract here and don't publich the package.

We could create a package with unit tests for one contract here and don't publich the package.

Sounds like a good solution.
I would just "port" some of the simplest unit tests - init, bond, and unbond and check with a few queries. This is more to demo usage - we already unit tested the contract itself (in cosmwasm), as well as the sdk integrations (in wasmd)


Memory-inefficient updater may cause denial of service

The way the updater currently works, it must read the entire metadata into memory in order to check its format, or read an entire target or metadata file into memory in order to check its hashes and so on. This is clearly inefficient with regard to memory, and could cause denial of service. We should read files as efficiently as possible.

Not really a security issue: the worst that can happen is that the updater crashes, but no arbitrary software attacks should happen. Also, since then, we have default upper bound limits on metadata and targets file sizes.


fix(robot): support multiple backup stores

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#5411
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
e2e test cases running: https://ci.longhorn.io/job/private/job/longhorn-e2e-test/2282

Summary by CodeRabbit

New Features

Enhanced backup verification and data integrity checks with updated keyword definitions.
Improved volume restoration operations by linking backups to their respective source volumes.

Bug Fixes

Added retry mechanisms for retrieving and deleting backup volumes to improve reliability.

Tests

Updated test cases for disaster recovery scenarios to clarify the source volume context.
Enhanced clarity in backup volume test cases by specifying the associated volumes.
Refined recurring job tests to improve reliability with added retry parameters.

Chores

Implemented cleanup procedures in test fixtures to maintain a clean testing environment.

@Mergify backport v1.8.x


Date picker in access policy is unpredicable

Version: 1.12.0
AzCopy Version: 10.3.3
Platform: macOS
Architecture: x64
Build Number: 20200116.10
Commit: 0a86d4ecc
Support ID: 70f20b02-ca4a-d914-07c0-f17d73883239
Bug Description
The expiration date picker on access policies is wholly ineffective:

Two-digit numbers cannot be entered because it treats "12" as two separate inputs of "01" and "02"
Flipping moving the minute counter up or down one also toggles, AM/PM and day fields even if the minute wasn't on a day boundary
Various other bugs (see below)

Steps to Reproduce

Create an access policy
Try to set 12/31/2099 12:00:00 AM as the expiration date

Expected Experience

Entering "12" in the month field sets month to 12 not 02
Moving the minute counter up/down with the arrow keys does not affect any other field unless crossing the minute boundary between AM/PM within a day or between days (i.e. 11:59 PM <--> 12:00 AM)
Setting a day field doesn't change the time
Moving the hour field with arrow keys moves it by one hour, not skipping by two or more (and changing the day field)

Actual Experience
See attached video (in ZIP): storageexplorer-dateselector-repro.zip

Duplicate of #2812


Add onTraitClicked callback to the Gw2Specialization component

While many of the icon+tooltip components show a single entity, where it is possible to capture a click event over the entire component and know the ID of the underlying skill/trait/item, the Gw2Specialization component shows multiple different entities with separate icons and tooltips.
In order to allow more dynamic usage of the components without having to rely on the component's inner DOM tree, it would be great if the component could send information about click events back to its parent. One option could be adding a function onTraitClicked to the Gw2Specialization props, which would be called with the corresponding trait ID whenever its icon would be clicked.
Bonus points for allowing us to change the cursor while hovering over the clickable traits (either automatically if the callback function is supplied, or via a custom class prop that would be applied to the trait's divs).

hey @keirbhaltair, want to try your hand at this issue?
im happy for a onTraitClicked to be added, as well as allowing to pass down a traitClassName too.

I might try it when I'll have the time, but since I still know very little about React, it might feature some amount of arm flailing... ^^

Thanks for the assistance! I tried it out in my Angular project now and it seems to work perfectly. ^^


Add option for selecting execution engine

Add a query parameter to when starting builds to select the execution engine. Such as:
POST /api/project/{projectId}/build?engine=wharf-cmd

The value possible here should come from the configs. Such as:
ci:
  defaultEngine: jenkins
  engines:
    jenkins:
      name: Jenkins
      triggerUrl: https://jenkins.local/whatever
      triggerToken: changeit
    wharf-cmd:
      name: wharf-cmd
      triggerUrl: http://wharf-cmd-provisioner
      triggerToken: changeit

Needs backwards compatbility, so if defining ci.triggerUrl and ci.triggerToken (the existing config fields) then that should be equivalent to:
ci:
  # old fields:
  triggerUrl: https://jenkins.local/whatever
  triggerToken: changeit

  # are translated to the following:
  defaultEngine: unnamed
  engines:
    unnamed:
      name: Unnamed
      triggerUrl: https://jenkins.local/whatever
      triggerToken: changeit

There should also be new endpoints for accessing these endpoints, so the frontend can display a way to select between them:
GET /api/engine

Response:
{
  "default": "jenkins",
  "engines": {
    "jenkins": {
      "name": "Jenkins",
      "triggerUrl": "https://jenkins.local/whatever"
    },
    "wharf-cmd": {
      "name": "wharf-cmd",
      "triggerUrl": "http://wharf-cmd-provisioner"
    }
  }
}

The response cannot include the tokens. But the URLs are safe to share and can be used to give more context to the user.

Viper doesn't play well with environment variables of unknown keys, such as in maps or slices. Need to rethink this.

👍🏻
Suggest changing endpoint to GET /api/engine instead to match the "no plural endpoints" design that we have now.

New design:
ci:
  engine:
    name: Jenkins # Defaults to "Primary"
    triggerUrl: https://jenkins.local/whatever
    triggerToken: changeit
  engine2:
    name: wharf-cmd # Defaults to "Secondary"
    triggerUrl: http://wharf-cmd-provisioner
    triggerToken: changeit

It's a little bit clunky, but it's what we can do with Viper's restrictions right now. I find it an OK workaround instead of trying to update wharf-core to use a different config provider and whatnot


Make shutdown/restart actions configurable

hum, should we do it also for ntp sync and so on?

hum, should we do it also for ntp sync and so on?

possibly? ntp also requires elevated privileges, so perhaps this should also be migrated to an admin plugin... Not sure if we want to split into separate plugins to avoid escalating everything?


MobileAds.init from a Background thread

Description
Calling MobileAds init from background thread.
Related Issues
https://github.com/googleads/googleads-mobile-flutter/issues/1135
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Appears the AppLovin APIs have changed - they are causing a failure: https://github.com/googleads/googleads-mobile-flutter/blob/main/samples/admob/mediation_example/ios/Runner/AppDelegate.m#L46

Appears the AppLovin APIs have changed - they are causing a failure: https://github.com/googleads/googleads-mobile-flutter/blob/main/samples/admob/mediation_example/ios/Runner/AppDelegate.m#L46

There is a major change on latest AppLovin which is affecting the sample. For now I limited the version used by the sample, but we might need to rethink the sample in the future.


Paid content upload support + UX / UI improvements

Closes #2210
Test: kp
Review notes

Reads both new and old tag formats.
Writes new tag format.

[ ] :warning: The dev instance currently writes old format too for testing. Should remove after review.

In the form, separated Fiat and SDK paywalls for now. Not sure how to link the currencies when we support beyond USD later.
Need closer look on membership-gating, since this is the merge-conflict area.  Tried to redo some logic that handles both membership-gating and paywall-gating -- highest potential for error.

Known Issues

[ ] After a rental expires, can't seem to rent again.  Happens in production too.  The payload sent seems correct.
[ ] claim is not a rental error from the backend.  Not sure yet what causes this, but maybe due to LBC paywall.

WIPs

[ ] Don't invoke purchase modal if creator doesn't have account (I broke it).
[ ] Price label in queue looks bad.
[ ] Use Haffa's bank-account driver modal in the Publish Form.
[ ] Test...test...test...
[ ] Purchase/Rentals should only be for Audio/Video, or all claim types?
[ ] Input field sanity checks
[ ] "Publish Tags" section: when editing, those internal tags eat up the tag slots. Legacy issue, maybe handle separately.

[ ] shows price free on confirmation  - I guess that's coming from the LBC price setting. Show new selections?

[ ] Odysee will be taking a 25% platform fee + standard processing fees from rentals/purchases in USD. We'll need to show that here so creators understand + link to term & conditions (I can fill in details later).

Will get some feedback from marketing side on this flow also!

Confused with this one. Should be testing on kp, and the new look is this:

Whoops, must have went back to Odysee on that one, sorry. Too many tabs 😂

On a related note, @toshokanneko , would be nice to find a way to show that a rental is also available in the claim preview.

Can try a variant of this, but one (or maybe just all labels) would need to be removed.  Maybe just use the icons when cannot fit?

I definitely prefer this new approach without the text. However, if this is still the one that I wrote then we should probably find a solution that doesn't rely on the screw value....at least not without before or after.

I definitely prefer this new approach without the text. However, if this is still the one that I wrote then we should probably find a solution that doesn't rely on the screw value....at least not without before or after.

Yeah, still that version.  Agree, we'll have to re-write.  Wasted a lot time trying to it to work in various places like FilePage, etc.

found a small bug when testing legacy functionality, would be good to fix up. On page load, we make a call to customer list with: claim id filter, to see if the user has a rental/purchase.

This returns any tips on the claim too, so on the response, we have to check for type: rental or type: purchase. There also may be multiple here, so it should check them all to see if any are valid.
      "is_live": null,
      "type": "tip",
      "reference_claim_id": null,
      "valid_through": null,
      "source_claim_id": "63540d14482cea0adb329240412b7f031950da52"
    }
  ]
}

[ ] would it be a lot of effort to show that content is already purchased on claim preview? Maybe run the customer/list for all results that have the tag? Would be nice to support multiple claim ids here so we can do it in one call, will check on that.

--- Draft ---
Hold off review for now, want to chance a small part...

[ ] Search for @TOM to fill in URL and fix the breakdown formula (@tzarebczan)

--- Review ---

Ok to resume review. The remaining changes will just be incremental small additions.
Re-do the skewed price label, which now also fixes the cut-off seen in production's File Page.

I think there's no space to show both Rental and Purchase price, and the video duration seems nice to have still, so just show icons for that case.
Don't know how to do responsive stuff yet -- can show/display based on available width when know how to.


Update a list of available regions of Azure Cognitive Services

The list of available regions under the multi-service subscription chapter is out of date (e.g. the centralus region is missing).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69823924-7def-6548-4f85-4ab9b8075d46
Version Independent ID: 9593dc98-656c-a73a-cbe6-ce201e497b11
Content: Translator Text API V3.0 Reference - Azure Cognitive Services
Content Source: articles/cognitive-services/Translator/reference/v3-0-reference.md
Service: cognitive-services
Sub-service: translator-text
GitHub Login: @swmachan
Microsoft Alias: swmachan

@FSou1
Thanks for the feedback! We are currently investigating and will update you shortly.

@swmachan Hi, could you please help to check this issue? In both the document and the "Product available by region" I can not find any details for which region we provide our service.

Here's the link on regions where translator service is deployed - https://docs.microsoft.com/en-us/azure/cognitive-services/Translator/reference/v3-0-reference#base-urls

@swmachan Could you please help to check if the centralus region is missing? Thank you.

You are right. CentralUS and other regions are missing in the document. We will update it.

The document has been updated.
#please-close


append weblogic connection support

weblogic + cxf will use "weblogic.net.http.HttpURLConnection" to connect next node. so append transformer on it.
if append code in weblogic plugin . some code is dumplicated. so I append it in http-jdk plugin

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.haotianyu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

First-time contributors need a maintainer to approve running workflows.
Did any body help me for this ???

@emeroad Is this PR mergeable?


error 401

My plugin just stopped working, it displays the following error message.
[eWeLink] An error was encountered while requesting a list of devices. Response was [{"error": 401}]
plus someone with the same problem
?
thanks

I managed to resolve my authenticationToken changed, will this occur frequently?

Got same problem twice on this week :(

In my experience the token changes about once a month.
Keep in mind to always use the Bearer [use_this_token] token in the HTTP Header and not the apiKey in the query string. Always happens to me.


[HOLD for payment 2024-08-02] [$250] Dupe detect - Merchant field is empty on the confirmation page when there is info on merchant

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Submit two expenses with same content for every field (amount, description, merchant and category)
Go to transaction thread of any expense
Click Review duplicates
Select Keep this one (any)
Proceed to confirmation page

Expected Result:
All the fields will reflect the correct information on the confirmation page
Actual Result:
Merchant field is empty on the confirmation page when there is info on merchant field.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/d3732ce4-2c4c-4e5f-aaed-073657442cf1
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a0550d2189cf44a1
Upwork Job ID:<PHONE_NUMBER>359268142
Last Price Increase: 2024-07-22

Issue OwnerCurrent Issue Owner: @twisterdotcom

We think that this bug might be related to #wave-collect - Release 2

Dupe Detection is still under Beta, so I don't think this needs to be Hourly. We can make it Daily.

And since its in beta we can also remove the blocker labels

cc @JmillsExpensify @pecanoro @kubabutkiewicz @parasharrajat

@francoisl I am reassigning the issue to myself so I can review and track the fixes since this is for the duplicate detection project that I am handling.

@mountiny or @pecanoro who is due payment here? Just @parasharrajat for reviewing https://github.com/Expensify/App/pull/45890?

Payment Summary:

@parasharrajat paid $250 via NewDot Manual Request (Reviewer)

$250 approved for @parasharrajat


Improve explaination for metrics in README：

What this PR does / why we need it:
Improve explaination for metrics in README.

/lgtm


add_user_to_group

I'm not sure anyone has done this yet, but this would be feature could added for the crowd, if an organisation has multi-group and multi-users, they might want to switch between them for automation purpose. Hope someone is watching this good repo.
Cheers

I spend about an hour and write a new method in this package. Hope some one could update it. Here is the code, put it under the class 'Crowd Server'. Appreciated.
def add_user_to_group(self, username, groupname, raise_on_error=False, **kwargs):
    # Populate data with default and mandatory values.
    # A KeyError means a mandatory value was not provided,
    # so raise a ValueError indicating bad args.
    try:
        data = {
            "name": groupname
        }
    except KeyError:
        return ValueError

    print data

    response = self._post(self.rest_url + "/user/group/direct",
                          params={"username": username},
                          data=json.dumps(data)
                          )

    if response.status_code == 201:
        return True

    if raise_on_error:
        return RuntimeError(response.json(['message']))

    return False


Created a Google Home integration last year before requestSync was a thing

I just implemented the requestSync, which is really nice for when someone adds a new device on their account associated with my service. The bad thing is, I can't seem to find a way to force all my users to "re-sync" so that their agentUserId is now sent in my sync request. Is there something I'm missing? Is there a way to do this?

Yeah if you don't have a user id for someone you can't request a sync, and there's no resync for everyone option. You'd have to ask them to relink their account or manually trigger a sync, ie. "OKG, sync my devices"


Add missing namespace to resolve asset retargeting failures

See #4700 for more details

CI running here:
https://dev.azure.com/aipmr/MixedRealityToolkit-Unity-CI/_build/results?buildId=2221


improve property question flow

very abrupt now. Asks for car and home, then asks user to list all property including car and real estate in one text field.
Delete question with ID =  property?

Not sure this is relevant anymore. Closing