When I try to freeze the checkpoint model, an error occurs: you must feed a value for placeholder tensor

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow version and how it was installed (source or binary):
TensorFlow-Recommenders-Addons version and how it was installed (source or binary):
Python version:3.7
Is GPU used? (yes/no):yes

Describe the bug
When I try to freeze the checkpoint model, an error occurs: you must feed a value for placeholder tensor
A clear and concise description of what the bug is.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

I attempted to modify the placeholder using the signature of the saved_model, but ultimately, it still failed.
The reason TFRA can enable TensorFlow training is that it constructs a variable proxy. During forward pass, it looks up the table and fills the variable with values, while during backward pass, it retrieves the updated values and inserts them into the hash table. Therefore, it is evident that the size of this variable varies for each training step, making it dynamic (hence the name "de"). Consequently, it cannot be converted into a constant.

In the end, I use the saved_model for online inference.

There is another issue regarding enabling inference. When encountering a key that is not present during online inference, it will take the value from the initializer. Therefore, when exporting the model, the initializer needs to be set to 0. Additionally, during evaluation, new embeddings will not be generated

@yingzhic I'm facing a similar error, are you using more than 1 GPU? Can you share how you are saving the model?

Hello @MoFHeka, can you please help take a look at this question?

@yingzhic Please make sure rebuild model before saving by using de.enable_inference_mode().
If it doesn't work, please give me a file with minimal realizations, so that I can debug and find out what happens.

User could solve this problem by using TF2's savedmodel for inference, without the need to convert to a freeze graph.


TR docs for migrating removed and one example added to Traffic Router

Issue -
#5978
Which Traffic Control components are affected by this PR?

Documentation

PR submission checklist

[ ] This PR has tests
[x] This PR has documentation
[ ] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@ocket8888 , @rawlinp  Could you please review this Sir

Done @ocket8888

Hello @ocket8888 are there any other changes you want on this PR?

Looks like all of @ocket8888's comments have been addressed, the docs build with no new warnings and appear to render ok.


Inline Edits: Implement Hotkeys

Installlation info:
IntelliJ IDEA 2022.1 (Community Edition)
Build #IC-221.5080.210, built on April 11, 2022
Runtime version: <IP_ADDRESS>+1-b2043.25 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 14.2.1
GC: G1 Young Generation, G1 Old Generation
Memory: 752M
Cores: 10
Non-Bundled Plugins:
com.sourcegraph.jetbrains (6.0-localbuild)
Kotlin: 221-1.6.20-release-285-IJ5080.210
Description:
The hotkeys are displayed in the code lenses, but are not currently operational.
Need to set up the appropriate key listeners to invoke the lenses as actions, as if you had clicked them with the mouse.
Objectives:

Acceptance Criteria:

Design Tasks:
### Design Tasks
- [ ] Add a draft title or issue reference here

Engineering Tasks:
### Engineering Tasks
- [ ] Add a draft title or issue reference here

Related Docs:

PRD: Your-Title

@mkondratek I did a bit of research and I think we can go forward with:
Enter edit mode => ctrl + shift + enter
Retry => ctrl + shift + enter
Accept edit => ctrl + shift + +
Show Diff => ctrl + shift + '
Undo edit => ctrl + shift + backspace
As far as I know, these are safe.
Also, these should be listed and configurable here as
Edit Code: Open Edit Mode
Edit Code: Retry Edit
Edit Code: Accept Edit
Edit Code: Show Dif
Edit Code: Undo Edit

done in 6.0.0!


An option to embed SearchBox with Ripple effect

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like

Props to set ripple effect to SearchBox.
Builder to embed SearchBox with Inkwell.

Describe alternatives you've considered
Additional context
I didn't found how to add ripple effect to SearchBox:
return Column(
    children: [
        Material(
          color: Colors.transparent,
          child: DropdownSearch<String>(
            items: (filter, infiniteScrollProps) => ['hello', 'world'],
            clickProps: ClickProps(
              borderRadius: BorderRadius.circular(20.00),
            ),
            decoratorProps: DropDownDecoratorProps(
              decoration: InputDecoration(
                labelText: "Sucursal",
                helperText: 'Busque y seleccione la sucursal',
                border: OutlineInputBorder(
                  borderRadius: BorderRadius.circular(20.00),
                ),
              ),
            ),
            popupProps: const PopupPropsMultiSelection.modalBottomSheet(
              showSearchBox: true,
              searchDelay: Duration(milliseconds: 0),
              searchFieldProps: TextFieldProps(
                decoration: InputDecoration(
                  labelText: "Buscar sucursal",
                  border: OutlineInputBorder(
                    borderRadius: BorderRadius.all(Radius.circular(20.00)),
                  ),
                ),
              ),
            ),
          ),
        ),
    ],
);

Screenshots

dropdown_search: ^6.0.1

this is not possible in this package. seachBox is a textField and textFileld has no Ripple effect


Usage example for tf.linalg.det()

@yashk2810 can the examples in pbtxt files also be used as doctests? If yes, I assume they should follow the same guidelines, right?

files also be used as doctests

Yup.

assume they should follow the same guidelines, right?

Yes

@abhayKashyap03 please follow the guidelines in https://www.tensorflow.org/community/contribute/docs_ref


The PHP page is showing limited number of users and groups

Hi Folks,
Everything worked fine for me however the PHP pages DisplayUsers.php and DisplayGroups.php is not throwing all users and groups results but just a limited number.
Is there any way to change this to throw all Azure users or groups in the same page or in a pagination view?
Thank you,

This sample has been archived.


Update dev to 6.0.0a12 (r19777)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf would you mind taking a look at this? I've been scratching my head over this but can't figure out why it's failing on the svn checkout. It runs fine locally. Am I missing a feedstock update or something?

@leouieda I'm in a conference at the moment but I'll take a closer look once I get back home. It does not seem like a feedstock update issue though. Anyway we can always do
@conda-forge-admin, please rerender
to check :smile:

@msarahan do you have an idea why the svn source is failing here?

Seems like there is nothing to rerender.

Seems like there is nothing to rerender.

Yep. I did not really have faith in that one :smile:
Do you have an alternate source available? It seems that building from svn is broken.

how do you have svn installed locally?  We do test it, so it should be working, but that traceback is not very informative.  I agree with @ocefpaf that using a different source would be a better way.

We use the conda package from defaults for svn.


Proposal: Removing sudo from examples

Situation
Currently, we propose users set up Docker and sudo rules such that depending on configuration sudo is required . For Mac users on Boot2Docker we actually historically told them not to use sudo.
Removing sudo from our documentation is the most inclusive way to document.

For those Mac etc users and users without sudo requirements, no harm no foul.
For those in restrictive environment, well they will need to use sudo but they will be used to that anyway not just for issuing docker commands but for other third-party commands which I am sure are similarly restricted. If these users forget, the note is there to remind them if not the fact the command fails with a perm error.

Proposal
We now have instructions in our Unix installs about setting up docker group to avoid sudo.  So, let us sudo from the examples and any other file. Let's add a boilerplate section when appropriate reminding them that if they have to use sudo to run docker they can change that.  I propose to do this in all our docs.  If the proposal is accepted; I'll do the sweep.  run.md attached as an example.
Signed-off-by: Mary Anthony<EMAIL_ADDRESS>

@SvenDowideit @jamtur01 @fredlf @spf13

See also https://github.com/docker/docker/pull/10144 which goes the opposite direction.

@cgwalters I don't quite follow your reference or is it inference. :-D  We've actually already removed sudo from other parts of the documentation. The result is that we have inconsistent inclusion of sudo in our examples.
The reality is currently we allow users to set up Docker and sudo rules such that  depending on configuration sudo is required .  For Mac users on Boot2Docker we actually historically told them not to use sudo.
Removing sudo is the most inclusive way to document. For those Mac etc users and users without sudo requirements, no harm no foul. For those in restrictive environment, well they will need to use sudobut they will be used to that anyway not just for issuingdocker` commands but for other third-party commands which I am sure are similarly restricted.  If these users forget, the note is there to remind them if not the fact the command fails with a perm error.
@jfrazelle  let me know if I'm wildly off the reservation; always possible.

Assuming everyone is in agreement then it LGTM.

See #8056 which this is effectively the opposite of.

@phemmer thanks for pointer.  That was merged in Sept 2014. I'll get folks in a pod and talk.

The goal should be to have examples that most users can copy/paste in most situations. I honestly cannot say whether that means including sudo or not. My instinct says not, but I would like to discuss with some people to get more data.
It would be nice if we (docs writers) could discuss large-scale changes like this as a group to make sure we are serving the needs of all users.

@fredlf I've only made changes to this single file.  Unfortunately, I was unaware there was any controversy over sudo or not sudo.  I had seen an early PR sweep that Jess did removing sudo from examples; also I did not include sudo in the contributors guide; so, unfortunately, I assumed the sudo in the doc were legacy left overs from a sweep.
When I saw the inclusion/exclusion of sudo raised in a bday contributor's submission; I merged his and opened this.  My thinking was, yes, we needed a larger discussion.  I certainly think the writers should discuss it but I also think any discussion should include the the maintainers as a whole.  This is, in part, a technical issue.  My current understanding is that PRs are the good forum for raising and discussing these issues with maintainers.  Point taken, though, I'll reframe this as a proposal though...to clarify it as such.

Awesome, thanks. A proposal seems like the best way to go about this.
FWIW, my informal polling this morning of support, training and SE folk is leaning pretty hard towards the approach you have here: remove sudo from examples, but be sure to include a note about using it as needed.

Solomon brought @naelmohammad (a user at the party) stopped by the docs desk to give this feedback "You need to remove the sudo from your examples; it really caused problems for my friend and me tonight."

Yeah, I talked to a bunch of people throughout yesterday and the consensus was pretty clear, we should remove it.

Good. Glad you feel comfortable with this now Fred.  Would you like to add an LGTM?

Oh, right. LGTM

LGTM

@jamtur01 @SvenDowideit @fredlf @spf13 one more set of eyes before I commit these changes please.  Thanks for your help everyone!

LGTM


Migrate Reconcile Assistant to Typescript

GitHub Issue (if applicable): #2572
Trello Link (if applicable):
Explanation of Bugfix/Feature/Modification:
A clear and concise description of what changes you've made and why.
Moving Reconcile Assistant to leverage the added Typescript in the repository (:.

Broke apart some components
Added a Transaction Type that can be added to later on
Use the transaction date rather than the UTC time

ughhh since I rebased, it change commits and github doesn't think this is merged like I thought it would, guess next time I'll just merge this and add a commit on top in master lol.

@joshmadewell awesome thanks for the stylistic changes and helping be get this in! (:


Min ruby version have to be fix to 2.2.2

doesn't work with ruby 2.0
yum-config-manager --enable software_collections
yum-config-manager --enable ol7_latest ol7_optional_latest
yum install -y scl-utils ruby ruby-devel gcc make gcc-c++

gem install apiaryio
ERROR:  Error installing apiaryio:
	rack requires Ruby version >= 2.2.2.

works with ruby 2.5
FROM oraclelinux
RUN yum install -y oraclelinux-release-el7 \
    oracle-softwarecollection-release-el7
RUN yum install -y rh-ruby25-ruby rh-ruby25-ruby-devel gcc make gcc-c++
RUN source /opt/rh/rh-ruby25/enable && gem install apiaryio
ENTRYPOINT ["/opt/rh/rh-ruby25/root/usr/local/bin/apiary"]

Min ruby is now 2.4


Fixed width of images on homepage

The images on Homepage are not responsive

Closes #1186
Motivation and context

Design was broken.

Images overflow the container.

With a nextjs/image property.

Screenshots:

Before

After

Testing
Steps to test
Affected urls

Environment
New environment variables:

[ ] NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name
Previous version
Updated version
Details

dependency/name
v1.0.0
v2.0.0

@pshumareva You can read more about the changes applied with Next 13 at https://nextjs.org/docs/api-reference/next/legacy/image
On this link you can find snippets with migration ideas: https://nextjs.org/docs/advanced-features/codemods#next-image-experimental-experimental

The 'layout' property solves the problem but it is deprecated and causes warnings. Could we find another solution? For example the following should work: width: 100%; height: auto;

NextJS will complain about adding width: 100%; like that to the image. Maybe maxWidth: 100% will be the solution.

I'll have a look at it today.

Closing this PR since the issue is fixed with https://github.com/podkrepi-bg/frontend/pull/1233.


change default shell under vscode terminal failed

VSCode Version: 1.35.1
OS Version: macos mojava

Steps to Reproduce:
I exec chsh -s /bin/zsh under vscode terminal, but it shows chsh: no changes made (/bin/zsh already installed in the path), and echo $SHELL shows the old shell (/bin/sh)

Does this issue occur when all extensions are disabled?: Yes/No

https://apple.stackexchange.com/a/88296


Fixed Docker File to build from source.

Added the right path for cmd/prometheus & cmd/promtool

This didn't work for me because it copies the source directories into the container instead of the binaries.  If you run 'make build' or 'go build github.com/prometheus/prometheus/cmd/prometheus', then the binaries will be in the right place for the docker build.

Hi there, sorry but we can't merge this.
The proper way to build the application is to run the following command from the repository root :
make build

@brian-brazil , @sdurrheimer seems you can close this and will reopen if needed.


RemotePS Task Flat Machine List

Hi @KrishnaAdityaB, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Krishna Aditya). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

This is already reviewed offline.

Hi @KrishnaAdityaB, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Krishna Aditya). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


added: trads for select-list and select-tree tabs elements

thanks! don't forget to update upstream


delete failed using the example

hi all
step 1， install the minikube and start
step 2.   download the release binary
step 3.   using the configuration under example and run kubecfg create, it'ok
step 4   trying to delete by running kubecfg delete, it failed like below
get error like below
ERROR strconv.Atoi: parsing "": invalid syntax
~/dev/kubecfg$ kubectl version
Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.4", GitCommit:"793658f2d7ca7f064d2bdf606519f9fe1229c381", GitTreeState:"clean", BuildDate:"2017-08-17T17:03:51Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"", Minor:"", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2018-01-26T19:04:38Z", GoVersion:"go1.9.1", Compiler:"gc", Platform:"linux/amd64"}

 :~/dev/kubecfg$ ./kubecfg version
kubecfg version: v0.7.2
jsonnet version: v0.9.5
client-go version: v1.7.3-beta.0+$Format:%h$
(py36) yongweixing@ :~/dev/kubecfg$ ./kubecfg version
kubecfg version: v0.7.2
jsonnet version: v0.9.5
client-go version: v1.7.3-beta.0+$Format:%h$

 :~/dev/kubecfg$ minikube version
minikube version: v0.25.0

This is an unfortunate minikube bug kubernetes/minikube#2505.  You can see it was compiled without setting the server Major/Minor versions correctly at apiserver build time (they're both "").
My local minikube seems to have this fixed, but I don't remember if I had to do something to make that happen:
$ minikube version
minikube version: v0.25.0
$ kubectl --context minikube version
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.4", GitCommit:"bee2d1505c4fe820744d26d41ecd3fdd4a3d6546", GitTreeState:"clean", BuildDate:"2018-03-12T16:29:47Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T20:55:30Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}

I'm leaving this open as a kubecfg bug, because we should also handle this better.  Either make it non-fatal (log a warning and make a wild guess at server version/behaviour), or at least improve the error message to make it clear what's going on.

@anguslees Kubernetes is recommending to parse Gitversion, instead of Major, Minor. Shall we do that in Kubecfg? https://github.com/kubernetes/kubernetes/blob/v1.9.3/pkg/version/base.go#L37-L41


Quantize public values we are asserting against in public

In our codebase we use the Router contract to check whether a timestamp or a block is bigger, smaller, equal (etc.) compared to the current value from context. It will be common that this value will be stored in the contract's public storage (e.g. end of voting stored in shared mutable, then obtain in private when voting and asserting against that value via the router contract).
In these situations the developers typically do not care about the value being super specific and they typically want the deadline to be e.g. on a specific date. This makes it possible to encourage developers to choose a value such that it's shared with multiple contracts which possibly results in a good privacy set.
I think we should build tools in aztec-nr that will help devs choose this value. Then the dev could do the following to get the nice quantized value:
    #[aztec(public)]
    #[aztec(initializer)]
-    fn init(donation_token: AztecAddress, operator: AztecAddress, deadline: u64) {
+    fn init(donation_token: AztecAddress, operator: AztecAddress, num_days_until_deadline: u64) {
        storage.donation_token.initialize(donation_token);
        storage.operator.initialize(operator);
+       let deadline = get_quantized_timestamp_num_days_from_now(num_days_until_deadline);
        storage.deadline.initialize(deadline);
    }

Look for TODO(#8367) in the codebase to find an example where this could be used.

How do you imagine we'd quantize? Take some modulo and have discrete steps, e.g. instead of per-block we'd do 50 block jumps?
A possible footgun with that is that we'd need to pick a quantizing direction (e.g. does block 728 become 700 or 750?), so we'd need to make sure we're always quantizing all amounts, since otherwise the comparisons might be invalid (e.g. if checking for greater or equal, it's fine to compare a quantized current block of 700 to a target block of 728, but if checking for less or equal it is not - the issue being that we quantized the current block but not the target).

We could I guess use the type system to try to prevent such errors, by converting a T into a Quantized<T>.

How do you imagine we'd quantize? Take some modulo and have discrete steps, e.g. instead of per-block we'd do 50 block jumps?

@nventuro Did not think about this too deeply but yes for blocks would just round to some nice nearby value as you mention. For timestamp would have num_hours, num_days, num_weeks, num_months from now and most likely always round up to the end of the hour, day, week, month.

We could I guess use the type system to try to prevent such errors, by converting a T into a Quantized.

Good idea 👍


Disable  and  key

I find these two keys very annoying (both when I press them or when I get called by my parents...).
This contains an example how to disable it with some registry magic: https://www.wikihow.com/Disable-the-Capslock-Key-in-Windows (method 2 disables both).
The gist:
Add a new binary value under HKLM\System\CurrentControlSet\Control\Keyboard Layout ->  "Scancode Map"
Values:
INSERT alone:    00000000 00000000 02000000 000052E0 00000000
CAPS LOCK alone: 00000000 00000000 02000000 00003A00 00000000
BOTH:            00000000 00000000 03000000 000052E0 00003A00 00000000

Explanation for the keymaps are here: https://www.howtogeek.com/howto/windows-vista/disable-caps-lock-key-in-windows-vista/
I can send a PR for the most trivial case: setting both at once via a DisableInsertAndCapsLockKey (and EnableInsertAndCapsLockKey which deletes the value again). IMO this should be two different methods (DisableCapsLockKey and DisableInsertKey) and it should take already replaced stuff into account, but my powershell is not good enough to parse that string and make the adjustments on the fly.
Would you take such a "simple" PR?

Interesting topic. I must say that out of the several hundreds of PCs I have built, installed and supported over the span of last 10+ years, I could count such requirements on the fingers of one hand.
Although I can see what kind of problems do BFUs have with the Insert key, I personally find it very useful especially when copy-pasting stuff from terminals which have Ctrl key combinations reserved for other things (e.g. Ctrl+C for interrupt, so I have to use Ctrl+Insert for copying instead). As for the Caps Lock and Scroll Lock, more often then disabling them, I see remapping them to something useful, like Ctrl or Esc.
I'm not really fond of such tweaks as they go against the expected functionality, but even if I'd agree to adding them and having them disabled by default, I see potential problems with their implementation. If they would be in separate tweaks, one for each key (which they should), you'd need to introduce some logic which checks the current state of the Scancode Map registry and adds or subtracts the appropriate scancode and increments or decrements the counter at the same time. The tweaks also shouldn't interfere with any other scancodes added by the user or the script itself to ensure that repeated runs will always result in correct values. I'm not saying that it's impossible, but I'm afraid that such logic may prove to be hard to implement in a clear, concise and easy-to-read way. Feel free to give it a shot, though... or don't and simply add the desired functionality using hardcoded values in your own fork.

I'm fine with keeping this as a local script I have to run.
Thanks for making this script, this helps a lot, BTW!


Failed to compile: Module not found: Can't resolve 'aws-sdk'

Hi,
I  want to use danfo.js in an React App. I created an React app with npx create-react-app somename --template typescript and then installed danfo with npm install danfojs-node. When I now try to import danfo.js I allways get the Error
Failed to compile.

./node_modules/node-pre-gyp/lib/info.js
Module not found: Can't resolve 'aws-sdk' in 'C:\Users\XXX\node_modules\node-pre-gyp\lib'

I tried to update node-pre-gyp to @mapbox/node-pre-gyp, but this didn't helped
When installing the aws-sdk there are alot of Warining, which dont look so good:
Compiled with warnings.

<EMAIL_ADDRESS>Critical dependency: the request of a dependency is an expression

./node_modules/node-pre-gyp/lib/pre-binding.js
Critical dependency: the request of a dependency is an expression

./node_modules/node-pre-gyp/lib/util/versioning.js
Critical dependency: the request of a dependency is an expression

./node_modules/node-pre-gyp/lib/util/compile.js
Module not found: Can't resolve 'node-gyp' in 'C:\Users\Pascal\Desktop\Catenion\testapp\node_modules\node-pre-gyp\lib\util'

./node_modules/node-pre-gyp/lib/util/compile.js
Module not found: Can't resolve 'npm' in 'C:\Users\Pascal\Desktop\Catenion\testapp\node_modules\node-pre-gyp\lib\util'

./node_modules/node-pre-gyp/lib/util/nw-pre-gyp/index.html 1:0
Module parse failed: Unexpected token (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> <!doctype html>
|
|

The only change I made to the original created App is in App.tsx. The Import of DataFrame and the creation of a new DataFrame Object.
import React from 'react';
import logo from './logo.svg';
import './App.css';
import { DataFrame } from 'danfojs-node';

function App() {
  const df = new DataFrame()
  return (

          Edit src/App.tsx and save to reload.

          Learn React

  );
}

export default App;

Did I something wrong or is this a Bug? I hope my Description is good enougth to reacreate the Error.
Best Pascal

@PascalStehling You can't danfojs-node in react, as it is server side, use danfojs instead. You can follow this example https://danfo.jsdata.org/examples/using-danfojs-in-react

Ohh :D thank you for your clearification :D


exchange method error in v0.16.3

Add a test case that interacts with the app
This will result in an error as the transport returned by zemu v0.16.3 cannot be used to call exchange

A good test can be based on appInfo which is supported by all apps:
I copy an example here
  async appInfo(transport) {
    return transport.send(0xb0, 0x01, 0, 0).then(response => {
      const errorCodeData = response.slice(-2);
      const returnCode = errorCodeData[0] * 256 + errorCodeData[1];

      const result = {};

      let appName = "err";
      let appVersion = "err";
      let flagLen = 0;
      let flagsValue = 0;

      if (response[0] !== 1) {
        // Ledger responds with format ID 1. There is no spec for any format != 1
        result.error_message = "response format ID not recognized";
        result.return_code = 0x9001;
      } else {
        const appNameLen = response[1];
        appName = response.slice(2, 2 + appNameLen).toString("ascii");
        let idx = 2 + appNameLen;
        const appVersionLen = response[idx];
        idx += 1;
        appVersion = response.slice(idx, idx + appVersionLen).toString("ascii");
        idx += appVersionLen;
      }

      return {
        return_code: returnCode,
        error_message: errorCodeToString(returnCode),
        appName,
        appVersion,
      };
    }, processErrorResponse);
  }

I think they had an issue here. The export type should be something like
export default (urls: In): new () => StaticTransport => { }
Otherwise, we don't have access to the static open method in that class.


Rubocop ignores Exclude in inherited configuration file.

Be clear, concise and precise in your description of the problem.
Open an issue with a descriptive title and a summary in grammatically correct,
complete sentences.
Use the template below when reporting bugs. Please, make sure that
you're running the latest stable RuboCop and that the problem you're reporting
hasn't been reported (and potentially fixed) already.
Before filing the ticket you should replace all text above the horizontal
rule with your own words.

Expected behavior
RuboCop should respect all Exclude's in an inherited configuration file.
Actual behavior
RuboCop reports violations of a cop for a file listed in .rubocop_todo.yml under Exclude for that cop.
.rubocop.yml includes:
inherit_from: .rubocop_todo.yml

.rubocop_todo.yml includes a very long list of files to Exclude for Metrics/AbcSize
# Offense count: 350
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
Metrics/AbcSize:
  Exclude:
    - 'app/classes/api2/core/parameters.rb'
    - 'app/classes/api2/external_link_api.rb'
    - 'app/classes/api2/image_api.rb'
    - 'app/classes/api2/location_api.rb'
    - 'app/classes/api2/name_api.rb'
    - 'app/classes/api2/observation_api.rb'
    - 'app/classes/api2/parsers/time_parser.rb'
    - 'app/classes/api2/sequence_api.rb'
    - 'app/classes/api2/species_list_api.rb'
    - 'app/classes/api2/user_api.rb'
    - 'app/classes/auto_complete/by_word.rb'
    - 'app/classes/auto_complete/for_clade.rb'
    - 'app/classes/auto_complete/for_herbarium.rb'
    - 'app/classes/auto_complete/for_location.rb'
    - 'app/classes/auto_complete/for_location_containing.rb'
    - 'app/classes/auto_complete/for_name.rb'
    - 'app/classes/auto_complete/for_region.rb'
    - 'app/classes/auto_complete/for_user.rb'
    - 'app/classes/checklist.rb'
    - 'app/classes/eol_data.rb'
    - 'app/classes/ip_stats.rb'
    - 'app/classes/mappable/collapsible_collection_of_objects.rb'
    - 'app/classes/mappable/map_set.rb'
    - 'app/classes/pattern_search/base.rb'
    - 'app/classes/pattern_search/error/bad_term_error.rb'
    - 'app/classes/pattern_search/term.rb'
    - 'app/classes/pattern_search/term/dates.rb'
    - 'app/classes/prawn/field_slip_card.rb'
    - 'app/classes/project_lat_lngs.rb'
    - 'app/classes/query/herbarium_base.rb'
    - 'app/classes/query/modules/conditions.rb'
    - 'app/classes/query/modules/datetime.rb'
    - 'app/classes/query/modules/high_level_queries.rb'
    - 'app/classes/query/modules/joining.rb'
    - 'app/classes/query/modules/sequence_operators.rb'
    - 'app/classes/query/modules/sql.rb'
    - 'app/classes/query/modules/validation.rb'
    - 'app/classes/report/adolf.rb'
    - 'app/classes/report/darwin/observations.rb'
    - 'app/classes/report/fundis.rb'
    - 'app/classes/report/raw.rb'
    - 'app/classes/report/symbiota.rb'
    - 'app/classes/site_data.rb'
    - 'app/classes/suggestion.rb'
    - 'app/classes/tree.rb'
    - 'app/controllers/account/login_controller.rb'
    - 'app/controllers/account/profile/images_controller.rb'
    - 'app/controllers/account/profile_controller.rb'
    - 'app/controllers/account_controller.rb'
    - 'app/controllers/admin/blocked_ips_controller.rb'
    - 'app/controllers/admin/session_controller.rb'
    - 'app/controllers/api2_controller.rb'
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/articles_controller.rb'
    - 'app/controllers/checklists_controller.rb'
    - 'app/controllers/collection_numbers_controller.rb'
    - 'app/controllers/comments_controller.rb'
    - 'app/controllers/concerns/descriptions.rb'
    - 'app/controllers/concerns/descriptions/merges.rb'
    - 'app/controllers/concerns/descriptions/moves.rb'
    - 'app/controllers/concerns/descriptions/permissions.rb'
    - 'app/controllers/concerns/descriptions/publish.rb'
    - 'app/controllers/field_slips_controller.rb'
    - 'app/controllers/herbaria/curator_requests_controller.rb'
    - 'app/controllers/herbaria/curators_controller.rb'
    - 'app/controllers/herbaria_controller.rb'
    - 'app/controllers/herbarium_records_controller.rb'
    - 'app/controllers/images/votes/anonymity_controller.rb'
    - 'app/controllers/images/votes_controller.rb'
    - 'app/controllers/interests_controller.rb'
    - 'app/controllers/locations/descriptions_controller.rb'
    - 'app/controllers/locations_controller.rb'
    - 'app/controllers/names/classification/inherit_controller.rb'
    - 'app/controllers/names/descriptions_controller.rb'
    - 'app/controllers/names/eol_data/preview_controller.rb'
    - 'app/controllers/names/synonyms/deprecate_controller.rb'
    - 'app/controllers/names/synonyms_controller.rb'
    - 'app/controllers/names/trackers_controller.rb'
    - 'app/controllers/names_controller.rb'
    - 'app/controllers/observations/images_controller.rb'
    - 'app/controllers/observations/locations_controller.rb'
    - 'app/controllers/observations/maps_controller.rb'
    - 'app/controllers/observations/namings/votes_controller.rb'
    - 'app/controllers/observations/namings_controller.rb'
    - 'app/controllers/observations/species_lists_controller.rb'
    - 'app/controllers/observations_controller/create.rb'
    - 'app/controllers/observations_controller/destroy.rb'
    - 'app/controllers/observations_controller/edit_and_update.rb'
    - 'app/controllers/observations_controller/new.rb'
    - 'app/controllers/observations_controller/shared_form_methods.rb'
    - 'app/controllers/observations_controller/show.rb'
    - 'app/controllers/observations_controller/validators.rb'
    - 'app/controllers/projects/admin_requests_controller.rb'
    - 'app/controllers/projects/field_slips_controller.rb'
    - 'app/controllers/projects/members_controller.rb'
    - 'app/controllers/projects_controller.rb'
    - 'app/controllers/publications_controller.rb'
    - 'app/controllers/rss_logs_controller.rb'
    - 'app/controllers/species_lists/name_lists_controller.rb'
    - 'app/controllers/species_lists/projects_controller.rb'
    - 'app/controllers/species_lists/shared_private_methods.rb'
    - 'app/controllers/species_lists/shared_render_methods.rb'
    - 'app/controllers/translations_controller.rb'
    - 'app/extensions/string_extensions.rb'
    - 'app/extensions/symbol_extensions.rb'
    - 'app/helpers/api2_inline_helper.rb'
    - 'app/helpers/api_keys_helper.rb'
    - 'app/helpers/application_helper.rb'
    - 'app/helpers/carousel_helper.rb'
    - 'app/helpers/content_helper.rb'
    - 'app/helpers/descriptions_helper.rb'
    - 'app/helpers/footer_helper.rb'
    - 'app/helpers/forms_helper.rb'
    - 'app/helpers/images_helper.rb'
    - 'app/helpers/link_helper.rb'
    - 'app/helpers/map_helper.rb'
    - 'app/helpers/matrix_box_helper.rb'
    - 'app/helpers/names_helper.rb'
    - 'app/helpers/namings_helper.rb'
    - 'app/helpers/observations_helper.rb'
    - 'app/helpers/pagination_helper.rb'
    - 'app/helpers/table_helper.rb'
    - 'app/helpers/tabs/descriptions_helper.rb'
    - 'app/helpers/tabs/projects_helper.rb'
    - 'app/helpers/title_and_tabset_helper.rb'
    - 'app/helpers/user_stats_helper.rb'
    - 'app/jobs/field_slip_job.rb'
    - 'app/models/abstract_model.rb'
    - 'app/models/api_key.rb'
    - 'app/models/description.rb'
    - 'app/models/field_slip.rb'
    - 'app/models/image.rb'
    - 'app/models/interest.rb'
    - 'app/models/language_exporter.rb'
    - 'app/models/location.rb'
    - 'app/models/location_description.rb'
    - 'app/models/name.rb'
    - 'app/models/name/change.rb'
    - 'app/models/name/create.rb'
    - 'app/models/name/format.rb'
    - 'app/models/name/lifeform.rb'
    - 'app/models/name/parse.rb'
    - 'app/models/name/spelling.rb'
    - 'app/models/name/taxonomy.rb'
    - 'app/models/name_description.rb'
    - 'app/models/name_parse.rb'
    - 'app/models/name_sorter.rb'
    - 'app/models/name_tracker.rb'
    - 'app/models/naming.rb'
    - 'app/models/naming/name_resolver.rb'
    - 'app/models/observation.rb'
    - 'app/models/observation/consensus_calculator.rb'
    - 'app/models/observation/naming_consensus.rb'
    - 'app/models/project.rb'
    - 'app/models/queued_email.rb'
    - 'app/models/queued_email/location_change.rb'
    - 'app/models/queued_email/name_change.rb'
    - 'app/models/queued_email/observation_change.rb'
    - 'app/models/species_list.rb'
    - 'app/models/synonym.rb'
    - 'app/models/translation_string.rb'
    - 'app/models/user.rb'
    - 'app/models/user_stats.rb'
    - 'app/models/visual_group.rb'
    - 'app/models/vote.rb'
    - 'app/presenters/image_presenter.rb'
    - 'app/presenters/matrix_box_presenter.rb'
    - 'lib/core_extensions/action_view/log_subscriber.rb'
    - 'lib/tasks/lang.rake'
    - 'script/bulk_name_change'
    - 'script/config.rb'
    - 'script/refresh_sitemap'
    - 'script/update_ip_stats.rb'

Steps to reproduce the problem

git clone https://github.com/MushroomObserver/mushroom-observer
cd mushroom-observer
rubocop -f simple app/helpers/forms_helper.rb --only Metrics/AbcSize

Will yield this output:
== app/helpers/forms_helper.rb ==
C: 12:  3: Metrics/AbcSize: Assignment Branch Condition size for submit_button is too high. [<7, 20, 6> 22.02/17]
C: 87:  3: Metrics/AbcSize: Assignment Branch Condition size for check_box_with_label is too high. [<4, 25, 2> 25.4/17]
C:121:  3: Metrics/AbcSize: Assignment Branch Condition size for radio_with_label is too high. [<4, 27, 2> 27.37/17]
C:155:  3: Metrics/AbcSize: Assignment Branch Condition size for text_field_with_label is too high. [<9, 72, 8> 73/17]
C:332:  3: Metrics/AbcSize: Assignment Branch Condition size for text_area_with_label is too high. [<9, 30, 4> 31.58/17]
C:354:  3: Metrics/AbcSize: Assignment Branch Condition size for select_with_label is too high. [<9, 31, 4> 32.53/17]
C:395:  3: Metrics/AbcSize: Assignment Branch Condition size for date_select_with_label is too high. [<11, 41, 6> 42.87/17]
C:419:  3: Metrics/AbcSize: Assignment Branch Condition size for date_select_opts is too high. [<8, 22, 13> 26.78/17]
C:436:  3: Metrics/AbcSize: Assignment Branch Condition size for number_field_with_label is too high. [<6, 17, 1> 18.06/17]
C:482:  3: Metrics/AbcSize: Assignment Branch Condition size for hidden_field_with_label is too high. [<3, 18, 2> 18.36/17]
C:526:  3: Metrics/AbcSize: Assignment Branch Condition size for file_field_with_label is too high. [<8, 34, 1> 34.94/17]
C:644:  3: Metrics/AbcSize: Assignment Branch Condition size for check_for_help_block is too high. [<3, 23, 3> 23.39/17]

1 file inspected, 12 offenses detected

RuboCop version
% rubocop -V -f simple app/helpers/forms_helper.rb --only Metrics/AbcSize
1.65.1 (using Parser <IP_ADDRESS>, rubocop-ast 1.31.3, running on ruby 3.3.0) [x86_64-darwin23]
  - rubocop-performance 1.21.1
  - rubocop-rails 2.25.1

Other: MacOS Sonoma 14.5, % ruby --version
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin23]

Yes, I find this behaviour rather unfortunate. There's a related issue here https://github.com/rubocop/rubocop/issues/9325 and this does affect the generated todo file as well.
The solution is to make use of the inherit_mode option, the other issue contains a snippet with that.

@Earlopain: Thanks for the pointer to the fix/workaround. It's a big improvement.
There is one remaining or new issue. The fix is not working for the Metrics/ModuleLength cop.
(As a result, I disabled that cop in one file. This, in turn, caused an autoconfig error: the todo file does not include a Metrics/ModuleLength for that one file.)

Is it possible that you generated the todo while the disable comment was still present? I see that the application with this error is open source and while trying it out myself it just worked, the forms_helper got added to the todo file just fine.

@Earlopain Thanks for the response.
My mistake. RuboCop is behaving correctly on its own.
(What I was seeing was an issue in VSCode, which ignored the Metrics/ModuleLength Exclude.)


phantomjs terminated with signal SIGSEGV

when i run npm test comond:"mocha-phantomjs --web-security=no TestRunner.html", shows this 'phantomjs terminated with signal SIGSEGV' error in my osx;

i solve this promblem switch mocha-phantomjs to mocha-phantomjs-core


Question: PromiseLike instead of Promise?

I'm using the bluebird library, it seems that the type definitions specify Promise instead of PromiseLike.
Any reason for using Promise vs PromiseLike? I'd be willing to submit a PR to change it.

@mceachen Could you take a look at this?

@hardeep Promise and PromiseLike are mostly ducktype compatible, but Promise neither extends nor implements PromiseLike in the TypeScript 2.6.2 typings. You'd have to change every reference to Promise to be Promise<T> | PromiseLike<T>, and callers would have to either cast (which is unsafe) or instanceof guard those calls if they had consumers that only accepted Promises.
About a year ago I'd tried to use PromiseLike when Promise wasn't necessary in my own projects, but it caused so much signature bloat I ended up only using the Promise signature internally.
If there's a clever way to do this that I'm missing, I'm all ears!

You'd have to change every reference to Promise to be Promise | PromiseLike

Has something changed? This compiles:
function foo<T>(bar: PromiseLike<T>): void {
    bar.then(alert)
}

foo(new Promise((resolve, reject) => resolve(1)));

Of course, consumers that only accept Promise are another story.

@Aankhen the typings were changed a while back from PromiseLike to Promise.


ci: Increase timeouts for slow builds

Fix #26818

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

here:
https://dev.azure.com/cncf/envoy/_build/results?buildId=134521&view=logs&j=bbe4b42d-86e6-5e9c-8a0b-fea01d818a24&t=00ade0d6-ffae-5af0-b5e0-e33b1813c8bc&l=4769
for example. This test was run in part to get these timings - its incredibly frustrating to wait 3 hours for a test and it then timeout.
Whether coverage should take 3+ hours is another matter, that i think we should address

heres another running the first Pr on the new 1.26 branch (ie full rebuild)
https://dev.azure.com/cncf/envoy/_build/results?buildId=134604&view=logs&s=b2710bd9-3b3a-5a17-3102-13ba462a848c
both arm and cov die from timeout

here is a non-scheduled job timing out https://dev.azure.com/cncf/envoy/_build/results?buildId=134635&view=logs&j=bbe4b42d-86e6-5e9c-8a0b-fea01d818a24
i really think this should be landed asap @htuch

relatedly im very much hoping that #26839 will begin to address the underlying problem


Whether resource names in svc.ack.resourceenames need to be unique？

Please provide an in-depth description of the question you have:
https://github.com/kmesh-net/kmesh/blob/6b0643bb617d1ca7dec6f89345d802b33c611cd0/pkg/controller/envoy/ads_event.go#L243-L277
In the handleRdsResponse method, if routeConfiguration.GetVirtualHosts() ! = nil then the routeConfiguration name is added to the resourceName. This will result in multiple same names in svc.ack.ResourceNames.
                if routeConfiguration.GetVirtualHosts() != nil {
			svc.ack.ResourceNames = append(svc.ack.ResourceNames, routeConfiguration.GetName())
		}

Don't we need to guarantee resource names in svc.ack.resourceenames to be unique?
What do you think about this question?:
I think the uniqueness of it needs to be guaranteed
Environment:

Kmesh version: 0.2.0
Others:

No, the resources from the response is already unique


[docs] ban-comma-operator marked as Typescript only

Isn't the comma operator a JS language feature too?

Agreed. Accepting PRs

Fixed by #3612 and can be closed


need release to fix OAuthLib version incompatibility

A release of invenio-oauthclient is needed.
Problem description:
invenio-oauth2server>=1.0.0a5  depends on Flask-OAuthlib>=0.9.3
PR #61 also makes this change in invenio-oauthclient but its last release still asks for Flask-OAuthlib>=0.6.0,<0.7
Thus the two of them cannot be installed together.

I'll make the PR for the new release.

See #69


Issue with IOS 14

Hello! I am new to developing and I have just been playing around with the code for fun.  I have been trying your implementation, which has been working great until I updated my iphone to IOS 14.  I have suddenly been receiving the output of:
CAMetalLayer ignoring invalid setDrawableSize width=0.000000 height=0.000000
first frame, fusion reset
Lost frame
Fusion Failed
I was wondering if you have any idea why this is happening and how I could fix it?
Thank you so much! And thank you for your amazing work!

This is mainly caused by ios's stricter shader language update. You can try to locate some "nan“ or "float compare" related code in shaders and add some safer "if" logic before it to avoid "nan" or "float compare".
It would be very appreciated if you push the fixed version code after you solve the problem.

Hello! Sorry it took me so long to respond to your message! Unfortunately, my computer died and it took a while for me to have access to a replacement.  I am going to close the issue and will start working on it once I have time again.
Thank you so much for your help!


[Purchase Data Importer] Failing on Origin (EA) once again

Extension name
Purchase Data Importer
Bug Description
Even though I am logged in I get the error:
Failed to obtain licenses for Origin library
Verify that you are logged in
To Reproduce
No response
Logs
extensions.log
playnite.log
Screenshots

Same issue on my side 😩


Passwords shown in plain text

If the user will be prompted for a password by arangodump or arangorestore the entered password is shown in plain text on screen.
Tested with Arangodb 3.0.1 on Debian 8.2.

Closed via commits.


Generic error message when log path isn't specified

deploydir=/var/www/something/htdocs
logdir=/var/www/something/logs
$ forever --minUptime=1000ms --spinSleepTime=1000ms --sourceDir=$deploydir --pidFile=/var/run/tester.pid -o $logdir/tester.out.log -e $logdir/tester.err.log -o $logdir/tester.log -a -v -d app.js

fs.js:418
  binding.open(pathModule._makeLong(path),
          ^
TypeError: path must be a string
    at Object.fs.open (fs.js:418:11)
    at WriteStream.open (fs.js:1652:6)
    at new WriteStream (fs.js:1642:10)
    at Object.fs.createWriteStream (fs.js:1606:10)
    at exports.attach (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/plugins/logger.js:27:43)
    at Object.bootstrap (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:33:27)
    at exports.App (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/node_modules/broadway/lib/broadway/app.js:47:21)
    at new exports.Monitor (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:119:16)
    at Object.forever.start (/usr/local/lib/node_modules/forever/lib/forever.js:381:17)
    at /usr/local/lib/node_modules/forever/lib/forever/cli.js:535:27

After a bit of brainstorming I realized that I forgot the -l option, but it seems like Forever could be more helpful in pointing that out. I don't see it specified anywhere that -l is a required option as well, so maybe this is just a documentation issue.

Duplicate of #490.


Width Fix 2

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-2021.06@48446e6). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-2021.06   #6372   +/-   ##
=================================================
  Coverage                   ?     72%
=================================================
  Files                      ?     398
  Lines                      ?   26909
  Branches                   ?    3959
=================================================
  Hits                       ?   19472
  Misses                     ?    5794
  Partials                   ?    1643


Added Data8 connector

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mattybeard sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


add step to test fips binaries for fips compliance

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.01%) to 57.351%

Files with Coverage Reduction
New Missed Lines
%

internal/agent/event_sender.go
1
78.11%

pkg/metrics/sampler/sampler_routine.go
2
95.35%

internal/integrations/v4/testhelp/testemit/testemit.go
2
90.63%

Totals

Change from base Build<PHONE_NUMBER>5:
0.01%

Covered Lines:
15366

Relevant Lines:
26793

💛  - Coveralls


Provide Windows binaries

I use Windows. I wanted to use Acme to do RL research. Acme requires Reverb, and Reverb doesn't have Windows binaries for download. I don't know how to compile packages on my own. This means that now I can't use either Reverb or Acme.

Hey,
I'm afraid that it is as you said. Reverb, and by extension Acme, is not available on Windows. We don't have any plans to support Windows at the moment and this is very unlikely to change in the future.


More flexible exercise listing - can be run without arguments

Coverage decreased (-0.2%) to 71.52% when pulling<PHONE_NUMBER>39b2674c03a180356e660408f05376 on runtests into d0c392cd59f764c770f0aff1aa38fad6440b8396 on master.

LGTM.


python310Packages.pkutils: 2.0.0 -> 3.0.2

Description of changes
Update to latest upstream release 3.0.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 172069 run on x86_64-linux 1

4 packages built:

python310Packages.pkutils
python310Packages.pygogo
python39Packages.pkutils
python39Packages.pygogo


activate assembly support for basic function (e.g. memcpy)

don't rename symbols for newlib

bors r+

bors retry

bors retry

bors retry

bors retry

bors retry

bors retry


Check version conflicts using linkage.

Instead of refusing to install software preemptively by assuming
multiple linkage to differing versions of the same library we now make
brew linkage --test verify that we don't have two versions of the
same library linked at the same time.
This will be considerably more permissive whilst checking the actual
problem that we're worried about.
CC @DomT4 as this will allow what you were doing in https://github.com/Homebrew/brew/pull/4729.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Merging as CodeCov is temporarily broken.


[react/prop-types] eslint cannot access imported proptypes externally

I want to import proptypes from another file because I am using the same api data (as props) for multiple components.
I was reading the previous issue threads about it, and it looks like it should work (at least in 2016) by reading this post: https://github.com/yannickcr/eslint-plugin-react/issues/545
I tried to replicate the same code even though it is deprecated, but it didn't worked.
Then I tried to simplify the issue as much as possible.
So when I try to get props from defined proptype it works (warning appears when the testprop is not defined in proptypes)
When prop is defined - no warnings:
import React from 'react';
import PropTypes from 'prop-types';

const Test = props => {
  const { testProp } = props;
  return
{testProp}
;
};

Test.propTypes = {
  testProp: PropTypes.string,
};
export default Test;

When prop is not defined - warning: 'testProp' is missing in props validation
import React from 'react';
import PropTypes from 'prop-types';

const Test = props => {
  const { testProp } = props;
  return
{testProp}
;
};

Test.propTypes = {};
export default Test;

When I externalize the proptypes to other object it still works
When prop is defined - no warnings:
import React from 'react';
import PropTypes from 'prop-types';

const Test = props => {
  const { testProp } = props;
  return
{testProp}
;
};

const externalProps = {
  testProp: PropTypes.string,
};

Test.propTypes = externalProps;

export default Test;

When prop is not defined - warning: 'testProp' is missing in props validation
import React from 'react';
import PropTypes from 'prop-types';

const Test = props => {
  const { testProp } = props;
  return
{testProp}
;
};

const externalProps = {};

Test.propTypes = externalProps;

export default Test;

But when I try to import the externalProps variable from other file it stops giving warnings even if the proptype is missing.
Test.js:
import React from 'react';
import PropTypes from 'prop-types';
import externalProps from './externalProps';

const Test = props => {
  const { testProp } = props;
  return
{testProp}
;
};

Test.propTypes = externalProps;

export default Test;

externalProps.js
import PropTypes from 'prop-types';

const externalProps = {};

export default externalProps;

Is there any way to read it from the external file, or it is some kind of bug because of file importing?  I would love to hear your opinion or even better - a solution for it
Thanks!

So basically if I want proptypes externally I need to switch to typescript? I understand that it's being decoupled from prod code, but still copying and pasting the same api text doesn't look like a good practice.
Either way, thanks for the answer :)


Create vanilla_small.txt

May new small vanilla logo, if you like it

Update builtin.c too, please.


sell link with ETH 0.00001 ..... will show as ETH 0.0001

sell link with ETH 0.00001 ..... will show as ETH 0.0001 on Andriod AlphaWallet
sell link with ETH 0.00001 ..... will show as 1.0E-5 ETH on landing page

Fixed in PR #312

@JamesSmartCell if this is fixed in the PR then please close the issue.


Enforce user to specify a value

I am designing a Parameterized class that requires some of the parameters to be set on instantiation.
I would expect the below to raise an error. But it does not
import param
class CronjobSpec(param.Parameterized):
    schedule = param.String(default=None, allow_None=False)

CronjobSpec()

Workaround
If I create a custom __init__ I can get it working.
import param
class CronjobSpec(param.Parameterized):
    schedule = param.String()

    def __init__(self, schedule: str, **params):
        super().__init__(schedule, **params)

CronjobSpec()

$ python 'script.py'
Traceback (most recent call last):
  File "script.py", line 8, in <module>
    CronjobSpec()
TypeError: __init__() missing 1 required positional argument: 'schedule'

Congratulations! You've made a duplicate of the very first issue ever opened on the Param github repo: https://github.com/holoviz/param/issues/1 . :-) Another user also requested this recently, on some other forum (Stackoverflow, maybe?). It's related to https://github.com/holoviz/param/issues/97 , in that I think we should define a non-None value that is Undefined or NotImplemented, to distinguish between a valid value of None and an invalid value that should force inheritance from a superclass and eventually error if not ever set.
I'd be happy for someone to investigate what it would take to close issues 1 and 97, which I don't think is difficult but requires some work to see what sentinel value is appropriate and whether we can preserve backwards compatibility properly if we change various None defaults to this sentinel. I'll close this issue as a duplicate, but it's still a valid request!
BTW, detecting the case you showed above is tricky, because allow_None is False by default, and so specifying it explicitly like that has no effect. It then falls down to the logic that infers that if a user creates a Parameter with a default value of None, None must be allowed, which is generally true but not your intention in this case. Detecting that you had specified allow_None=False explicitly would require something like making it None by default, treating that like False, and then raising an error in the above code.  I suppose that would be a way to achieve what you are requesting (and what #1 requests) without a new sentinel value, but I'm not sure it's clearer.

As mentioned above, this is a duplicate of #1


unix: support aarch64 in uv_cpu_info

This is the result of platform_output test, before this PR the "model" value was: "unknown".
These changes were develop in an aarch64 VM in aws
uv_get_process_title: build/uv_run_tests_a
uv_cwd: /home/ubuntu/libuv
uv_resident_set_memory: 794624
uv_uptime:<PHONE_NUMBER>00
uv_getrusage:
  user: 0 sec 1003 microsec
  system: 0 sec 0 microsec
  page faults: 0
  maximum resident set size: 3264
uv_cpu_info:
  model: Neoverse-N1
  speed: 0
  times.sys: 88210
  times.user: 183090
  times.idle: 597098570
  times.irq: 0
  times.nice: 13710
  model: Neoverse-N1
  speed: 0
  times.sys: 95720
  times.user: 183360
  times.idle: 597009280
  times.irq: 0
  times.nice: 11790
uv_interface_addresses:
  name: lo
  internal: 1
  physical address: 00:00:00:00:00:00
  address: <IP_ADDRESS>
  netmask: <IP_ADDRESS>
  name: ens5
  internal: 0
  physical address: 12:0d:87:bc:d7:09
  address: <IP_ADDRESS>
  netmask: <IP_ADDRESS>
  name: lo
  internal: 1
  physical address: 00:00:00:00:00:00
  address: ::1
  netmask: ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff
  name: ens5
  internal: 0
  physical address: 12:0d:87:bc:d7:09
  address: fe80::100d:87ff:febc:d709
  netmask: ffff:ffff:ffff:ffff::
uv_os_get_passwd:
  euid: 1000
  gid: 1000
  username: ubuntu
  shell: /bin/bash
  home directory: /home/ubuntu
uv_os_getpid: 46909
uv_os_getppid: 44613
uv_os_uname:
  sysname: Linux
  release: 5.11.0-1019-aws
  version: #20~20.04.1-Ubuntu SMP Tue Sep 21 10:41:13 UTC 2021
  machine: aarch64

Any update here?

I must've missed that Santiago signed off on it. I'll go ahead and merge it, thanks.


Add new Minitest/AssertPathExists and Minitest/RefutePathExists cops

https://github.com/rubocop-hq/minitest-style-guide#assert-path-exists
Both cops are almost identical (same as AssertNil and RefuteNil, for example). Is it worth extracting (and complicating a bit) somehow into, say, module?

Rebased.

Updated links.

Is it worth extracting (and complicating a bit) somehow into, say, module?

This is an issue with Minitest RuboCop, but this PR is fine as a first step.

Thank you!


BUG: Using RootModule does not write fastLinkJS main.js file

In the following repo: https://github.com/davesmith00000/shaders
Changing the following line in build.sc to use RootModule allows you to omit shaders from Mill commands - which is great!
-object shaders extends mill.Module {
+object shaders extends mill.RootModule {

So now I can run ./mill demos.campfire.compile instead of ./mill shaders.demos.campfire.compile.
However, if you try running ./mill demos.campfire.fastLinkJS, no main.js file is written to out/demos/campfire/fastLinkJS.dest (the folder is empty). Changing back to a normal module and running ./mill shaders.demos.campfire.fastLinkJS works correctly, the main.js file can be found in out/shaders/demos/campfire/fastLinkJS.dest.
Millw 0.4.7
Mill 0.11.4

Did you also move the code from shaders/demos/campfire/src to demos/campfire/src?
I can't reproduce the issue, it seems to work fine.
Suggestion: I call my RootModule root to make it clearer that it's not an actual directory but the root of the project.

I did not, that'll be the problem, thank you.
Interesting, that didn't align with my existing understanding / intuition around Mill. I think I'll probably leave it as it to keep my build more regular / consistent, and avoid special casing root, in that case.
Thanks again. :smile:

Alternatively, you could overwrite the millSourcePath of your root module to shaders.


Fixing paths to dist files in bower

The current paths don't compile correctly because they point to the wrong place.

Right, thanks


surfig requests shwig i wrg plae

Subject: surfig requests shwig i wrg plae
Description:
https://couchers.org/messages/chats
Results:
these shuld e i surfig
Backend version: develop-7c33e18d
Frontend version:
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Page: https://couchers.org/messages/chats
User: calicia (13391)

not enough info or can't reproduce


Fix #87 - Add support for setting container mac address

This adds the ability to set a mac address for a container.
I see that you have a VerifyHostnameSetIT that is @ignored and doesn't work so I haven't tried to add something similar for macAddress.  Let me know if it's a problem.

Code looks good and I tried it out. You would probably run into the same issues as the "VerifyHostnameSetIT", so for now this is good enough. :-)


Add linting rules

Rules: https://dart-lang.github.io/linter/lints/
Discussion: https://ably-real-time.slack.com/archives/C0178QGC093/p1596456192026600

https://github.com/ably/ably-flutter/pull/20#discussion_r464403047

https://pub.dev/packages/pedantic has been deprecated.

Instead, please see package:lints which is the lint recommendation from the Dart team, or package:flutter_lints which extends that for Flutter. These are better than the Google lint set because they take into account the needs of all Dart users, not just Google engineers.
To migrate away from package:pedantic please see the instructions here.

In the latest release from Flutter, they mentioned https://pub.dev/packages/flutter_lints
We should switch to use this instead

Closing this because of the above comment, a new issue has been created: https://github.com/ably/ably-flutter/issues/168


Set up GitHub Pages

set up GitHub Pages (from the main branch), update repository description with the proper website link

Follow the steps provide it by the reviewer


[d3d11] Shared texture flags handling fixes

Fixes Night Security (steam id 2367230) crash upon reaching 2nd floor during the first mission (soon after beginning of the game, at "1F" to "2F" level transition). The crash is due to shared texture import failure which is due to the mess between handle types (wrongly determined from flags). The texture is created with (D3D11_RESOURCE_MISC_SHARED | D3D11_RESOURCE_MISC_SHARED_NTHANDLE) which looks confusing from the point of view of currently present logic but actually this is the only way one can create a texture with NT shared handle without using D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX (see below).
Only patch 2 is strictly need for the game, while patch 1 fixes handle (and the shared memory under it) possible leak and the rest are straightening the thing up by adding validations (also covered by the tests) and giving some sense to the changed flag handling.
Here is the test I made which covers all of this behaviour: https://gitlab.winehq.org/wine/wine/-/merge_requests/3247
Attached is the diff on top of the referenced MR with the test which removes fixed todo's (and adds one for NT kernel object name), as well as leaving only the related test to run.
To summarize the test essentials (for some reason not clearly covered in MS docs) for easier understanding what the patches do:

D3D11_RESOURCE_MISC_SHARED_NTHANDLE can't be used alone, it is actually modifier to D3D11_RESOURCE_MISC_SHARED or D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX;
D3D11_RESOURCE_MISC_SHARED and D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX can't be used together;
D3D11_RESOURCE_MISC_SHARED or D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX alone means KMT handle is used, D3D11_RESOURCE_MISC_SHARED_NTHANDLE modifier means NT handle is used;
IDXGIResource::OpenSharedHandle can only open KMT handle, IDXGIResource1::CreateSharedHandle can only return NT handle (using those with texture with non-matching MiscFlags results in a error);
Similarly, ID3D11Device_OpenSharedResource can only open KMT handle, ID3D11Device1::OpenSharedResource1 can only open NT handle (this part was already working correctly).

There are some returned value fixes which are not strictly related, but since I tested that anyway...
test.txt

I also sent vkd3d-proton PR: https://github.com/HansKristian-Work/vkd3d-proton/pull/1625 which should ideally be synced in some way (as currently vkd3d-proton sets MiscFlags incorrectly in the view of corrected behaviour after the present PR.

I added one more commit to make version dependency with vkd3d-proton one way: so dxvk after this PR should be fine with old vkd3d-proton (while vkd3d-proton related change still depends on this dxvk PR)>

v2:

formatting fixes.


Network agent not updated after removed host

This is only a minor glitch I noticed once, and which I don't find important enough to investigate further on our end.
Rancher Version:
1.1.0
Docker Version:
1.12.3
OS and where are the hosts located? (cloud, bare metal, etc):
RHEL 7, bare metal
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node, external DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
cattle
Steps to Reproduce:
(this is roughly from memory of what I did, haven't re-applied the steps to verify that I get same outcome again)
Add two nodes. Deploy a few services.
Add third node.
Remove third node.
N.B.
The network were most likely never setup properly between the first two nodes and the third, due to firewall rules. The third node was a mistake, it shouldn't join this particular environment.
I noticed a lot of denied traffic on UDP 500, first later. I simply removed the Network Agent container on the afflicted nodes in the environment, and then the blocked traffic disappeared.
Results:
The Network Agent still attempts to setup the IPSec network with the third node.
Expected:
No UDP traffic between the third node and the other two nodes.

Oh, come to think of it. As apparently, the network agent was attempting to setup a network, which was failing, but there were no feedback of this in the UI... so, perhaps a network status page or some such, could be informative ;)

Network components are their own stacks that you can see the upgrade status of in 1.2+.


[New Theme Request]Android Studio theme

Can someone add android studio theme please?

Hello @HasanAliKaraca, feel free to create one and send it over https://github.com/dracula/dracula-theme#are-you-going-to-support-editor-x. Thanks for using Dracula!


"Hints" in the README file

This PR adds information which may help people in setting up the project. It took me some time to figure it out. :wink:

Thanks again!


Add digging / swimming conjugations from JW

[x] spit up audio

[x] annotate audio

[ ] create ground truth with tones - https://docs.google.com/spreadsheets/d/1DkzejTCWi-nWQlKBzL5vRWDdO0KT9ScGq71pjdxhFsE/edit#gid=0 <-- sheet for content

[ ] JW QA


Fixes #963

need to update docs, will add a commit to this PR

Merged as two separate commits: f21ef852 and parent


Clearing the cache / Question 1/2

Hi folks !
This is 1/2 questions wrt to fsspec cache handling when we want to clear it.
Context:
I develop a python library to work with ocean data collected using a specific type of instruments (Argo floats): https://github.com/euroargodev/argopy
Data can be fetched from local files or from an erddap server online.
I recently tried to use fsspec to implement file/resource management and ease handling of cached data.
I ended up wrapping file, memory and http fsspec file systems into classes that managed custom methods like open_dataset or open_dataframe.
Question 1:
When my users specify to use a caching system, I simply wrap the original one with a filecache.
I wanted to offer the possibility for users to clean up the cache from data they would have fetched, but I couldn't figure how fsspec allows to do this.
I found the clear_instance_cache() but I don't really understand what it is doing. In any case, when I call on it, it doesn't trigger some deletion in the cache folder files and registry (the pickle cache file):
import fsspec
import os

# Create a dummy file, read it with fsspec, and check that the cache folder is filled:
with open("dummy_file.txt", "w") as fp:
    fp.write('Hello world!')

fs = fsspec.filesystem("filecache", target_protocol="file", target_options={'simple_links': True}, cache_storage="./tmp")

with fs.open("dummy_file.txt", "r") as fp:
    txt = fp.read()

print("File is cached:\n", os.listdir("./tmp"))

# Now, try to clear the cache:
fs.clear_instance_cache()

# and check again the cache folder:
print("Expect cache folder to be cleared:\n", os.listdir("./tmp"))

which produces:
File is cached:
 ['cache', '0515f6cf660c690fd787b4d6d305b8ec11d894cdb5cacf6fee8aeff541de3eac']
Cache should be cleared:
 ['cache', '0515f6cf660c690fd787b4d6d305b8ec11d894cdb5cacf6fee8aeff541de3eac']

I expected that the cache folder ./tmp would be empty, or removed after the clear_instance_cache() call.
Do you have any idea of what am I doing wrong here ?
Could you please help me understand the behavior of the clear_instance_cache method ?

fs.clear_instance_cache() is not the method you want. It refers to a cache of instances of the filesystem, such that if you were to call the constructor again with the same arguments, you get the same instance  back instead of a new one. This helps with sharing resources, not having to reconnect to remote services. There is also a cache of directory listings, so many similar names.
There is actually no functionality for clearing the cache. There should be! For now, you could clear the metadata with fs.cached_files[-1].clear(); fs.save_cache(), which will cause reloads of files, but not delete existing ones. Deleting the "cache" files should have the same effect. Also, deleting the files from the cache should work too, something in the metadata but not on disc should cause a reload, but I think now would cause an exception.

Thanks for these explanations !
I now understand better the clear_instance_cache()
About the alternative you suggest, I'm afraid they would simply clear the cache content, whatever the file system that created them. So in the case where a single folder is being used by more than one fs, this could remove content that should not. Is this correct ?

Yes, my example would clear all the cache from the target folder. You want a per-instance cache, but sharing the same location? That might be trickier; you can keep the current state in memory (instead of a file), but you wouldn't know what other instances/processes are doing to the cache, then.

yes, that's why I tried to implement a registry in the wrapper I created, more here: #325
would that be a good approach ?

I'm closing this issue since it's be resolved in our library using a registry


Sub-optimal batching in React

Describe the bug
After leaving windows with mouse and return inside window and  click  empty space  any component that live inside RouterProvider  it rerenders.
mouse hover on links that have preload="intend" also rerender everything inside RouterProvider without click on  link.
Your Example Website or App
https://tanstack.com/router/v1/docs/examples/react/kitchen-sink?file=src%2Fmain.tsx
Steps to Reproduce the Bug or Issue
function Root() {
const routerState = router.useState();
console.log('render');
concole log inside root in this official example
Expected behavior
expect not to rerender 2 times even without strict mode.
Screenshots or Videos
rerenders.webm
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

This is fixed.

Problem still here for me did tests on 0.0.1-beta.38.
it comes from listeners on mount in router.ts.
Have idea if maybe  if those listeners can be part of  router oprions.
Not sure why they here but without them everything works perfect in my app.
// addEventListener does not exist in React Native, but window does if (!isServer && window.addEventListener) {   // Listen to visibillitychange and focus      window.addEventListener('visibilitychange', router.onFocus, false)      window.addEventListener('focus', router.onFocus, false) }

I'm in the process of reworking the internal state management to allow for more granular component subscriptions and batching. Stay tuned :)

any news about this issue?
This one its comming from
// addEventListener does not exist in React Native, but window does
// In the future, we might need to invert control here for more adapters
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (window.addEventListener) {
// Listen to visibilitychange and focus
window.addEventListener('visibilitychange', onFocus, false)
window.addEventListener('focus', onFocus, false)
}

Any update for this?
I have same the problem with beta 61. The app is re-rendered when focus or click some place on page.

This is from the default windowFocusRefetching functionality in react-loaders. It's implemented exactly the same as Query is. You can turn it off in each loader or in the loaderClient options.


Add bseti instruction

Single-Bit Set (Immediate) instruction
Mnemonic: bseti rd, rs1, shamt
Opcode: 1100100
This instruction returns rs1 with a single bit set at the index specified in shamt. The index is read from the lower log2(XLEN) bits of shamt. For RV32, the encodings corresponding to shamt[5]=1 are reserved.
Operation:
let index = shamt & (XLEN - 1)
X(rd) = X(rs1) | (1 << index)

What should i do, if your simulator parse commands with shamt[5] = 0 and
with shamt[5] = 1 ? And result is absolutely same for both,
[image: image.png]
These tests both passed. Difference between them only in shamt[5] bit.
пн, 15 нояб. 2021 г. в 16:32, Pavel I. Kryukov @.***>:

@.**** requested changes on this pull request.
In simulator/risc_v/t/unit_test.cpp
https://github.com/MIPT-ILab/mipt-mips/pull/1503#discussion_r749326950:

@@ -358,6 +360,11 @@ TEST_RV64_RR_OP( 1, add_uw, 0x12344321b5a69788, 0xabababab82736455, 0x1234432133
TEST_RV64_RR_OP( 2, add_uw, 0x1111111233333332, 0x11111111ffffffff, 0x1111111133333333) // 32 bits overflow
TEST_RV64_RR_OP( 3, add_uw, 0x01010102222221ce, 0xffffffffffffffac, 0x0101010122222222) // 64 bits overflow

+TEST_RV64_IMM_OP ( 1, bseti, 0xA95, 0xA91, 0x2)
+TEST_RV64_IMM_OP ( 2, bseti, 0x159D26AF37BF48C0, 0x159D26AE37BF48C0, 0x20)
This is a very unobvious test. What value I expect to see if it fails
after my changes?
The tests should tell about the purpose of instruction w/o looking into
spec. Check #1504 https://github.com/MIPT-ILab/mipt-mips/pull/1504, for
instance.
In simulator/risc_v/t/unit_test.cpp
https://github.com/MIPT-ILab/mipt-mips/pull/1503#discussion_r749329103:

@@ -118,6 +118,8 @@ TEST_CASE("RISCV disassembly")
TEST_RV32_DISASM  ( 0x0ae7d7b3, "minu $a5, $a5, $a4");
TEST_RV32_DISASM  ( 0x48D747B3, "packu $a5, $a4, $a3");
TEST_RV64_DISASM  ( 0x8D707BB,  "add_uw $a5, $a4, $a3"); // 0000100 | 01101 ($a3) | 01110 ($a4) | 000 | 01111 ($a5) | 0111011

TEST_RV64_DISASM  ( 0x28179713,  "bseti $a4, $a5, 1");
TEST_RV32_DISASM  ( 0x28269793,  "bseti $a5, $a3, 2");

For RV32, the encodings corresponding to shamt[5]=1 are reserved.
Is it possible to test that encoding is not parsed as bseti by our
simulator?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#pullrequestreview-806067647,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBI5POEHO5WPVFD7EGDUMEDXVANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I don't see the image. Please never share a screenshot, they make less use as you cannot copy from it.

if your simulator parse commands with shamt[5] = 0 and with shamt[5] = 1 ?

Our simulator. Generally we can check it while constructing the instruction and say it is 'illegal opcode' if it is.
Another option is to split it in riscv-opcodes, so RV32 version will have 0 hardcoded and RV64 will not. See how rori and roriw are different.
I would implement it in this PR so we won't face it suddenly in the future. If you don't feel strong enough to do it, open an Issue, add a commented test, and reference Issue number, so this problem will be known and possibly be solved later.

I read specification again with more attention and I stop to understand
this phrase " For RV32, the encodings corresponding to shamt[5]=1 are
reserved.". How we can reserve codes with shamt[5] = 1, if in RV32 case
shamt have only 5 bits (indexes from 0 to 4)?
пн, 15 нояб. 2021 г. в 18:58, Pavel I. Kryukov @.***>:

I don't see the image. Please never share a screenshot, they make less use
as you cannot copy from it.
if your simulator parse commands with shamt[5] = 0 and with shamt[5] = 1 ?
Our simulator. Generally we can check it while constructing the
instruction and say it is 'illegal opcode' if it is.
Another option is to split it in riscv-opcodes, so RV32 version will have
0 hardcoded and RV64 will not. See how rori and roriw are different.
I would implement it in this PR so we won't face it suddenly in the
future. If you don't feel strong enough to do it, open an Issue, add a
commented test, and reference Issue number, so this problem will be known
and possibly be solved later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#issuecomment-969053949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBNKYED6FFTICU45NOLUMEU2NANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I understand my last question. But i have a new question, why RV64 version
of rori is in opcodes32 and RV32 version of rori (roriw) is in opcodes64?
пн, 15 нояб. 2021 г. в 18:58, Pavel I. Kryukov @.***>:

I don't see the image. Please never share a screenshot, they make less use
as you cannot copy from it.
if your simulator parse commands with shamt[5] = 0 and with shamt[5] = 1 ?
Our simulator. Generally we can check it while constructing the
instruction and say it is 'illegal opcode' if it is.
Another option is to split it in riscv-opcodes, so RV32 version will have
0 hardcoded and RV64 will not. See how rori and roriw are different.
I would implement it in this PR so we won't face it suddenly in the
future. If you don't feel strong enough to do it, open an Issue, add a
commented test, and reference Issue number, so this problem will be known
and possibly be solved later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#issuecomment-969053949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBNKYED6FFTICU45NOLUMEU2NANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I tried to create a new test for rori func. Test, where shamt[5] bit is 1,
and it is passed, but opcode was incorrect.
I modify upper test and add 1 to shamt[5], is it supposed to work like
this? (both tests are passed)
TEST_RV32_DISASM ( 0x61F7D793, "rori $a5, $a5, 31"); // 01100 | 0011111
(31) | 01111 ($a5) | 101 | 01111 ($a5) | 0010011
TEST_RV32_DISASM ( 0x65F7D793, "rori $a5, $a5, 31"); // 01100 | 1011111
(31) | 01111 ($a5) | 101 | 01111 ($a5) | 0010011
пн, 15 нояб. 2021 г. в 18:58, Pavel I. Kryukov @.***>:

I don't see the image. Please never share a screenshot, they make less use
as you cannot copy from it.
if your simulator parse commands with shamt[5] = 0 and with shamt[5] = 1 ?
Our simulator. Generally we can check it while constructing the
instruction and say it is 'illegal opcode' if it is.
Another option is to split it in riscv-opcodes, so RV32 version will have
0 hardcoded and RV64 will not. See how rori and roriw are different.
I would implement it in this PR so we won't face it suddenly in the
future. If you don't feel strong enough to do it, open an Issue, add a
commented test, and reference Issue number, so this problem will be known
and possibly be solved later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#issuecomment-969053949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBNKYED6FFTICU45NOLUMEU2NANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Do I understand correctly rori has the same wording regarding shamt[5]?

Yes, it is.
пн, 15 нояб. 2021 г. в 22:00, Pavel I. Kryukov @.***>:

Do I understand correctly rori has the same wording regarding shamt[5]?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#issuecomment-969219841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBNMLMYNWMVPIPKSNUDUMFKEBANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

"This instruction performs a rotate right of rs1 by the amount in the
least-significant log2(XLEN) bits of shamt. For RV32, the encodings
corresponding to shamt[5]=1 are reserved."
It is description of rori.
пн, 15 нояб. 2021 г. в 22:00, Pavel I. Kryukov @.***>:

Do I understand correctly rori has the same wording regarding shamt[5]?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#issuecomment-969219841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBNMLMYNWMVPIPKSNUDUMFKEBANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

OK. So please

open an Issue
add a commented test (both for rori and bseti)
reference here the Issue number, so this problem will be known and possibly be solved later.

Done. Issue numbers is #1507 for rori instr and #1508 for bseti instr.
Add tests for both commands and comment them
пн, 15 нояб. 2021 г. в 22:10, Pavel I. Kryukov @.***>:

OK. So please

open an Issue
add a commented test (both for rori and bseti)
reference here the Issue number, so this problem will be known and
possibly be solved later.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#issuecomment-969229095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBKZHSIXM5KI47FCGRDUMFLIRANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Please reference the issues (# + number) in code

In comments to tests?
пн, 15 нояб. 2021 г. в 22:39, Pavel I. Kryukov @.***>:

Please reference the issues (# + number) in code
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#issuecomment-969253825,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBJFGTI5UVT5NVKLZULUMFOXLANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Yep. I'll fix the submodule conflict.

Done.
пн, 15 нояб. 2021 г. в 22:43, Pavel I. Kryukov @.***>:

Yep. I'll fix the submodule conflict.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MIPT-ILab/mipt-mips/pull/1503#issuecomment-969257042,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWAJBI25A6S2RT7BBK6UT3UMFPHDANCNFSM5IANNPVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Automated Package Upgrade

:tada: This PR is included in version 2.2.461 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Limit for scheduled jobs per azure automation account

What is maximum number of scheduled jobs that can be submitted every 30 seconds per Azure Automation account ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f49a06-90b1-cbe1-3853-2c38277b79f8
Version Independent ID: 02ff6f6c-3ef6-b48f-060d-b290419e0aba
Content: Azure subscription limits and quotas - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/azure-subscription-service-limits.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@vipul0517 Thanks for your comment. We will review the issue and get back to you shortly.

@vipul0517 I have checked with product team. As of now, there is no specific limitation for scheduled jobs.


[Model Update]: Reuse Certificate v2.0.0

Update Reason

add attributes: Article Number, VIN, OE number, Issuer, issue date, Dismantler, CatenaXId Previous Life, Catena X ID, serial number.

Link to the current version of the Reuse Certificate (v1.0.0)
https://github.com/eclipse-tractusx/sldt-semantic-models/tree/main/io.catenax.reuse_certificate/1.0.0
MS1 Criteria

[x] The model that should be updated exists
[x] The referenced use case exists
[x] The potential updates are discussed with all stakeholders
[x] A decision on versioning was made in consensus with the affected parties according to the guidelines.
[x] The potential update will be either

[ ] backward compatible or
[x] a (chain of) migration strategy(-ies) from all non-deprecated previous versions to the new model will be developed

[ ] A modeling steward has been assigned

In version 1.0.0 of the certificate a shared aspect
https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.shared.recycling_strategy_certificate/1.0.0/RecyclingStrategyCertificate.ttl
was used. It should be clarified if this structure can also be realized in the new version of the certificate.

Modeling Steward: @agg3fe support by @bs-jokri


Rebase workflow rolling with Ubuntu Nobel and add jazzy

To be added later.

https://github.com/fujitatomoya/ros_k8s/actions/runs/8844657207/job/24286958820
 > [2/2] RUN apt-get update     && apt-get upgrade -y     && apt-get install -y     net-tools     iputils-ping     dnsutils     libssl-dev     ros-rolling-desktop     ros-rolling-rmw-cyclonedds-cpp     --no-install-recommends     && rm -rf /var/lib/apt/lists/*:
4.591 Some packages could not be installed. This may mean that you have
4.591 requested an impossible situation or if you are using the unstable
4.591 distribution that some required packages have not yet been created
4.591 or been moved out of Incoming.
4.591 The following information may help to resolve the situation:
4.591
4.591 The following packages have unmet dependencies:
4.660  ros-rolling-pcl-conversions : Depends: libpcl-common1.13 but it is not installable
4.660                                Depends: libpcl-io1.13 but it is not installable
4.663 E: Unable to correct problems, you have held broken packages.
------
Dockerfile.rolling:19
--------------------
  18 |     # Install packages
  19 | >>> RUN apt-get update \
  20 | >>>     && apt-get upgrade -y \
  21 | >>>     && apt-get install -y \
  22 | >>>     # Basic utilities just in case
  23 | >>>     net-tools \
  24 | >>>     iputils-ping \
  25 | >>>     dnsutils \
  26 | >>>     # ROS 2 Security
  27 | >>>     libssl-dev \
  28 | >>>     # install full packages including GUI
  29 | >>>     ros-${ROS_DISTRO}-desktop \
  30 | >>>     # install cyclonedds
  31 | >>>     ros-${ROS_DISTRO}-rmw-cyclonedds-cpp \
  32 | >>>     --no-install-recommends \
  33 | >>>     && rm -rf /var/lib/apt/lists/*
  34 |
--------------------
ERROR: failed to solve: process "/bin/bash -c apt-get update     && apt-get upgrade -y     && apt-get install -y     net-tools     iputils-ping     dnsutils     libssl-dev     ros-${ROS_DISTRO}-desktop     ros-${ROS_DISTRO}-rmw-cyclonedds-cpp     --no-install-recommends     && rm -rf /var/lib/apt/lists/*" did not complete successfully: exit code: 100
Error: Process completed with exit code 1.

I guess that temporary unstable failure, maybe base ros:rolling image.
currently all workflow goes green, https://github.com/fujitatomoya/ros_k8s/actions/runs/9027449760