[TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/31925
PROPOSAL:
N/A
Tests

Start a new chat or open an existing one.
At the top of the chat, click on the user name and their profile will slide from the right of the screen.
Click on Private notes
Create a new note and save it.
Check that it displays correctly on a list

Offline tests

Same as tests.
QA Steps

Same as tests.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/48553277/ca75efa0-42d0-4ad4-83b9-2518b36c8b5a

Android: mWeb Chrome

https://github.com/Expensify/App/assets/48553277/c6a2a311-645c-45e6-b02e-1fe57c746e4a

iOS: Native

https://github.com/Expensify/App/assets/48553277/65519601-5873-4766-a85a-8d0fa07b6325

iOS: mWeb Safari

https://github.com/Expensify/App/assets/48553277/dda8e5b4-5b2e-44ae-92d2-debcb11b0ca6

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/48553277/e2c88f61-3f2b-4d1c-ba4c-e3598ef1724d

MacOS: Desktop

https://github.com/Expensify/App/assets/48553277/42cafc33-e7f6-4f66-9374-ab1acb321363

Looks good, I left a minor comment 👍

cc @pac-guerreiro

@cubuspl42
Sorry, I'll add the missing info in the PR description 😉

@cubuspl42 Missing info added! Thank you for your patience! 🙏

@pac-guerreiro No worries! Sadly, some more actions are required:

TypeScript Checks are failing
We've got some conflicts

@pac-guerreiro Please ping me when all checks (except PR Reviewer Checklist) are passing

@cubuspl42 Issues resolved! 😄

At the top of the chat, click on the user name and their profile will slide from the right of the screen.

A linguistic / cultural hint. We shouldn't assume the gender or pronouns of the user.

Could you check this out? When I tried to edit an existing note, an endless spinner shows up. I tried switching between main and PR branch and it actually seems to work on main, making this a regression.
https://github.com/Expensify/App/assets/2590174/e43c500f-fa7a-4f8b-9772-8b07e33fe6f4

@pac-guerreiro Checks, mate!

@cubuspl42 Typechecks are now passing! Thanks @VickyStash 🙏

@cubuspl42 Sorry, it seems I only fixed part of the problem, which was when the user already had private notes.
I just applied a fix for the situation you reported when there are no private notes yet.
Let me know if there's any remaining problem here and thanks for your patience! 😄

Let us take a step back here. As GitHub is not displaying the diff side-by-side, I'll post a screenshot from the IDE:

Why is the shouldShowFullScreenLoadingIndicator condition so different?
As I understand it, TypeScript migrations should be relatively 1:1 regarding the business logic unless we have good reasons to act otherwise.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/2590174/e0e0378b-0eef-46bd-bfa5-14a7162e1177

Android: mWeb Chrome
https://github.com/Expensify/App/assets/2590174/9ff53220-c6cd-434e-894b-cc2e991ac7f6

iOS: Native
https://github.com/Expensify/App/assets/2590174/90c335ea-a0b8-4849-908d-fc89d7ba9869

iOS: mWeb Safari
https://github.com/Expensify/App/assets/2590174/1d92e7b5-73be-4a1e-b549-ef1944283716

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/2590174/1e680d3a-3c77-4cee-84b0-6867f970c1c9

MacOS: Desktop

@pac-guerreiro Could you also maybe merge main one last time? We're over 1000 commits behind

@cubuspl42 Main rebased 😄

Sure I will

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


APEXMALHAR-2072 Fixing setter property variables for better User experience

@sandeepdeshmukh @bhupeshchawda Please review and merge.

@tweise @PramodSSImmaneni If you find time, Please review this PR.

Looks like it is just renaming variables and methods?
Changes seem fine to me.

@sandeepdeshmukh @bhupeshchawda Can we merge this?


Add as_strided() or a strides argument to ndarray.init()

Numpy has np.lib.stride_tricks.as_strided(x, shape, strides). It allows to create a view into the data of an existing array with a custom shape and strides. A common use case is to view a vector of data points as a matrix of overlapping subsequences of data points (e.g., for an STFT). This cannot be accomplished by reshape operations.
cupy.core.core.ndarray has a strides property, but does not provide a way to create an array with a specific data pointer and custom strides. It would thus be great to either support a strides argument in the ndarray constructor, or provide an as_strided function (not sure if it needs to be buried as deep as in numpy, but for full compatibility, it probably should).

strides option is added to ndarray in #1611.

np.lib.stride_tricks.as_strided would be absolutely awesome to have in cupy. I have already implemented n-dimensional neural network style convolutions and N-dimensional pooling in numpy by leveraging as_strided.
If you guys add this, I will be able to use cupy to add gpu support to my autograd library!

as_strided is now implemented.


Misleading Data Mesh Reference

[Enter feedback here]
Under "Reference Architecture" section the Data Mesh has been referenced as an Architecture as opposed to an operational pattern. Whereas in the Overview section it's used as an operational pattern alongside Lakehouse, data fabric etc.
This would be confusing for the users so need to use these terminologies carefully for standardisation & clarity.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc42c384-f5c3-b47b-1903-9d3ae4a71247
Version Independent ID: a6a5e0de-1d1e-af9b-2eea-c06440102b76
Content: Azure data management and analytics scenario overview - Cloud Adoption Framework
Content Source: docs/scenarios/data-management/index.md
Service: cloud-adoption-framework
Sub-service: scenario
GitHub Login: @mboswell
Microsoft Alias: mboswell

#label:"data management and analytics"
#assign @simonlid

fixed #please-close


Implement Retention Period for the messages

As a Devops I would like to configure Retention period for each Component, Also I want to be able to add and change from andyx-cli

Merged with v2.1/main


feat: adds support for tracing.

This is a WIP
It adds support for tracing (hopefully multiple providers) and it is a first exercise to the code part.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, this looks cool. Any reason it needs to be part of the standard builds, though? We're trying to avoid adding more unless there's a really good reason. It seems like this could be a plugin just as easily.

Well, it could indeed be a plugin but I believe now it is more common that
http servers or frameworks include tracing by default. Making it a plugin
is also good because it can be a dedicated plugin for specific tracers
(e.g. zipkin) and use those specific capabilities. I will make it a plugin
first then. Thanks!
fre. 12. apr. 2019 kl. 04:59 skrev Matt Holt<EMAIL_ADDRESS>
Hi, this looks cool. Any reason it needs to be part of the standard
builds, though? We're trying to avoid adding more unless there's a
really good reason. It seems like this could be a plugin just as easily.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mholt/caddy/pull/2558#issuecomment-482418182, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC7sAnIxRPRlguNzNIvPaIZjXdlSVxl-ks5vf_aQgaJpZM4cnPP3
.

--
--  José Carlos Chávez Teléfono: 708-5422 Anexo 918 Móvil: 962840384 /
946177706 RPM: 6975470 Nextel: 6177706

Sounds good! Looking forward to it!


Refactor AuxCoordFactory unit tests to remove biggus references

Fixes  #2381

@marqh @pp-mo Although I have reviewed and approved these changes, and can technically merge this PR if I wanted to, I do not intend to abuse this position of power.  I would feel much better if somebody with genuine authority could also review this, and then merge it.

looks great, thank you @djkirkham


Yelp Dataset 2021 version incompatibility

In the latest version of the Yelp Open Dataset, the metropolitan areas were changed, so the cities_checkin_data dictionary doesn't get populated when running datasetgen.py. May I request for access to the same version of the dataset that was used during development? Thanks!

I'd love to do it, but from what I saw its terms of Yelp, I'm not allowed to distribute their data. I want to contact Yelp soon for more information on sharing the dataset I used. If I get any good news, I'll share it here.

@kayeval finally, I got permission to share the dataset I used, you can download it from Google Drive, and let me know if you have any problems.


Media

Media (images, video, audio ...) streams tend to be very large.  Clients usually just want a URL to the media so that an ` HTML tag can be created.  Also, by including the media in the entity means that every access  fetches the entity.
Entities that have associated media should just have URL (link) to the media.
A media upload and download route need to be defined.
Should thumbnails  and image resize/cropping be supported.

MongoDB supports large files.  Storing media in the database instead of files is recommended

The resulting application will have a simpler architecture: one system for all types of data;
Document metadata can be expressed using the rich flexible document structure, and documents can be retrieved using all the flexibility of MongoDB’s query language;
MongoDB’s high availability (replica sets) and scalability (sharding) infrastructure can be leveraged for binary data as well as the structured data;
One consistent security model for authenticating and authorizing access to the metadata and files;
GridFS doesn’t have the limitations of some file systems, like number of documents per directory, or file naming rules.

The media model
{
    title: { tag: 'en', text: 'My holiday photo'},
    mimetype: 'image/jpeg',
    content: ...
}

A media link is a URL that returns the content as a HTTP stream and is not a normal link to the media entity.  It has the form "/api/download/id" as opposed to "/api/media/id" which is the media entity.

Changing media link to /api/media/id/content.  This makes it much easier to get the entity link, just remove the trailing /content.
The media entity is the data maintained by mongo.

The media entity is just the mongoDB fs.files object.


feat(tutorial): complete step 5 - Hursley

http://carbon-tutorial-asfordmatt.mybluemix.net
Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

:+1::skin-tone-2:   Looks good - I have recorded your completion of this step!


MAINT: update logo and favicon

Tuned down the resolution of the original logo file, let me know if it was too much.

Looks great! When the Fornax website is more developed, we can think about making the logo a link to it. But for now, I think we are good to go!

I'll iterate a bit more on the favicon as it looks really bad for me (too busy for the size of it). I'll either use a better resolution one, or reuse the old logo as it's less busy

The favicon looks good to me!


User blueprints

In the documentation, it says that custom pages (blueprints for custom fields) can be built by putting blueprints in the /user/blueprints/pages folder. https://learn.getgrav.org/forms/blueprints/example-page-blueprint
After having done this, how do you get that page type to show up when creating a new page? Is there a missing step here?

Also create a corresponding twig template file, then it will show up.

Okay, so even though you can create a user blueprint, you cannot create a user template aside from in the theme? I was hoping there was a way to maintain a third-party theme and create custom page forms.
The obvious use-case: being able to update the theme at at will, without overwriting custom blueprints / pages.

You can use theme-inheritance to keep the third-party theme updated without directly impacting your customized theme.
Theme Inheritance

Even when modifying the theme: I've placed a project.yaml file in the theme's blueprints/ folder and a project.html.twig file in the theme's templates/ folder. I do see a "Project" option when I go to add a new page, but it doesn't present the custom form defined in the .yaml file.

Never mind, I see it now! Thanks!


⚠ Bofrost.nl has degraded performance

In 53edbf8, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1422 ms

Resolved: Bofrost.nl performance has improved in 8dccfa0.


Unable to install Package

Laravel CRM Version: 0.10.0 || 0.10.1
PHP Version: 7.4

Description:
I am unable to add this package to my existing project.
When I execute following command
composer require venturedrake/laravel-crm
Problem 1
- owen-it/laravel-auditing[v13.0.0, ..., 13.x-dev] require illuminate/console ^7.0|^8.0|^9.0 -> found illuminate/console[v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev, v9.0.0-beta.1, ..., 9.x-dev] but these were not loaded, likely because it conflicts with another require.
- venturedrake/laravel-crm 0.10.1 requires owen-it/laravel-auditing ^13.0 -> satisfiable by owen-it/laravel-auditing[v13.0.0, ..., 13.x-dev].
- Root composer.json requires venturedrake/laravel-crm ^0.10.1 -> satisfiable by venturedrake/laravel-crm[0.10.1].
You can also try re-running composer require with an explicit version constraint, e.g. "composer require venturedrake/laravel-crm:*" to figure out if any version is installable, or "composer require venturedrake/laravel-crm:^2.1" if you know which you need.
Steps To Reproduce:

Looks like conflict with the laravel-auditing package I set up for audit logging. What version of Laravel are you using?

I am using this project.
https://github.com/hrshadhin/school-management-system.
I think it's 6.

I'll take a look, yes it's Laravel 6. Might be an issue with PHP 7.4, I'll do some testing

I have just released some updates and with latest version managed to get the package to install via composer. Please note I haven't completed a full install on that school management system. It is a bit out of date itself, no released for 2 years. Try a full install yourself and let me know if it works ok. I am also working on a CLI installer for the CRM as it is a bit manual at the moment.

Ok.

I have gone through all the installation steps but while executing 6th migration step it gives me following error.

Migrating: 2022_09_03_182548_create_permission_tables

   Illuminate\Database\QueryException  : SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'permissions' already exists (SQL: create table `permissions` (`id` bigint unsigned not null auto_increment primary key, `name` varchar(255) not null, `guard_name` varchar(255) not null, `created_at` timestamp null, `updated_at` timestamp null) default character set utf8 collate 'utf8_unicode_ci')

  at /Applications/MAMP/htdocs/cloudschool1/vendor/laravel/framework/src/Illuminate/Database/Connection.php:669
    665|         // If an exception occurs when attempting to run a query, we'll format the error
    666|         // message to include the bindings with SQL, which will make this exception a
    667|         // lot more helpful to the developer instead of just the database's errors.
    668|         catch (Exception $e) {
  > 669|             throw new QueryException(
    670|                 $query, $this->prepareBindings($bindings), $e
    671|             );
    672|         }
    673|

  Exception trace:

  1   PDOException::("SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'permissions' already exists")
      /Applications/MAMP/htdocs/cloudschool1/vendor/laravel/framework/src/Illuminate/Database/Connection.php:463

  2   PDOStatement::execute()
      /Applications/MAMP/htdocs/cloudschool1/vendor/laravel/framework/src/Illuminate/Database/Connection.php:463

  Please use the argument -v to see more details.

So I changed table name from database/XX_create_permission_tables.php to crm_permissions
So I am getting this error
ErrorException  : Undefined index: crm_permissions

 at /Applications/MAMP/htdocs/cloudschool1/database/migrations/2022_09_03_182548_create_permission_tables.php:28
   24|         if ($teams && empty($columnNames['team_foreign_key'] ?? null)) {
   25|             throw new \Exception('Error: team_foreign_key on config/permission.php not loaded. Run [php artisan config:clear] and try again.');
   26|         }
   27|
 > 28|         Schema::create($tableNames['crm_permissions'], function (Blueprint $table) {
   29|             $table->bigIncrements('id');
   30|             $table->string('name');       // For MySQL 8.0 use string('name', 125);
   31|             $table->string('guard_name'); // For MySQL 8.0 use string('guard_name', 125);
   32|             $table->timestamps();

 Exception trace:

 1   Illuminate\Foundation\Bootstrap\HandleExceptions::handleError("Undefined index: crm_permissions", "/Applications/MAMP/htdocs/cloudschool1/database/migrations/2022_09_03_182548_create_permission_tables.php", [])
     /Applications/MAMP/htdocs/cloudschool1/database/migrations/2022_09_03_182548_create_permission_tables.php:28

 2   CreatePermissionTables::up()
     /Applications/MAMP/htdocs/cloudschool1/vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php:392

 Please use the argument -v to see more details.

Ah ok, this is an interesting use case. The school management project has permissions tables already, which will conflict with the Spatie permissions package I have implemented. There is a way around this. Let me make some updates and run a few tests.

Hi, any update sir?
I would like to use in my school management system (to give it a wing to fly)
If I can do anything from my side to remove this error I would like to work on that please help.

Can you try this:

Add this to your env file

LARAVEL_CRM_PERMISSION_TABLE_PREFIX=crm_

Replace the "permissions.php" file in the application config folder with this new version

https://github.com/venturedrake/laravel-crm/blob/master/config/permission.php

Run the migrate command.

This should allow the Spatie package tables to use alternative table names so not as to conflict with the tables currently in the schools package.

Hi,
Sorry couldn't get permission.php file from provided URL. Can you please send me again?
I am sorry for little late. :(

Strange link should be https://github.com/venturedrake/laravel-crm/blob/master/config/permission.php


Merge Strategies

There are a number of scenarios where multiple mapping sets may be present, and users may want to merge them. I can think of a variety of actual situations where this could be handy.

[ ] Obf -> Deobf (Chained mappings), obfuscated values = first.obfName, de-obfuscated values = second.deobfName, matched by first.deobfName == second.obfName
[ ] Deobf -> Deobf, obfuscated values = first.deobfName, de-obfuscated values = second.deobfName, matched by first.obfName == second.obfName

I have done a little work on this, though I may end up pushing this back for the 0.5.0 modularisation release. I'm not back until the 4th, so I can't do much until then anyhow - so my decision will be deferred til then.
If I can get it done between now and then ofc it will be in for 0.4.0.

Completed with https://github.com/CadixDev/Lorenz/commit/5c5e8bb22c4fbd1c667d38ec404a92265409bdfb.


Use in6addr any instead of loopback xctest driver

Proposed Changes
Changing xctest driver server to use in6addr_any instead of in6addr_loopback. This might fix some connection issues, i.e. java.net.ConnectException: Failed to connect to localhost/[0:0:0:0:0:0:0:1]:22087

@artem888 Connect Exceptions are mostly due to HTTP server not being reachable not sure how switching the port can affect this 🤔 Do we have some reports or issues that can validate loopback address is causing the server not reachable?


feat: A user-friendly wrapper for running OpenHands in docker container.

Add a user-friendly wrapper for running OpenHands in docker container - a native command line tool  implemented in Golang.
Multiple instances can be started to work in different workspaces.

Give a summary of what the PR does, explaining any non-trivial design decisions
The CLI performs the following:

Check docker installation. If not found, open the Docker installation page in a browser
Validate user inputs and provide defaults for required arguments
Pull the docker image and start OpenHands
Launch the OpenHands Web UI in a browser

See more details in README.md

Link of any specific issues this addresses

Hey @qiangli--appreciate the contribution here!
Unfortunately adding Golang to this project is probably out-of-scope. We don't have the capacity to maintain it.
I'd encourage you to create a repo in your own GitHub account to maintain this. And you're welcome to post about it in our Slack/Discord once it's up!
If you're working on any other large projects feel free to gut check them with the team in Slack before putting in too much effort. (the #devops channel is probably a good place)
Thanks again for being here--sorry we cant merge this one!


cmd/link: package versioning for shared libraries is incompatible with linkobj builds

During linkobj builds, __.PKGDEF files are still included in the linker object files, but they're empty stub files that only contain information already present in the .o file, so I'm looking at getting rid of them in that case.
Working on cmd/link, I notice that genhash (used for generating package versions from the __.PKGDEF files for shared library builds) makes two assumptions that are incompatible with this:

They assume __.PKGDEF files are the first file in the .a. This is currently true because loadobjfile requires it to be the case, but won't be if we get rid of the __.PKGDEF files from linkobj files (as I intend to do).

In linkobj builds, the __.PKGDEF file is largely useless for versioning because it doesn't actually record anything about the package. So the versioning is broken.

My plan here is:

Near-term: change cmd/link to not require __.PKGDEF files for non-shared builds, change genhash to error if the archive is missing a __.PKGDEF file, and change cmd/compile to stop producing useless __.PKGDEF files in linkobj files.
This means shared library, linkobj builds will now explicitly fail, whereas before they would work but be subtly incorrect due to useless package version files.

Intermediate-term: have cmd/compile compute the package version hash and include it directly in the link object, so that cmd/link doesn't need the __.PKGDEF at all.

/cc @ianlancetaylor @mwhudson

@mdempsky Do you know what the status of this is?

@ianlancetaylor The "near-term" steps I outlined are done. The "intermediate-term" steps are not done.


AB#688 Remove font load duplication in scania theme light

Restructure typography package
Remove typography duplication in theme

Cause of bug:

Error when importing theme light via script in the head
relative path issues on duplicated font-face css

Fix #108 AB#688
How to test

Run HTML demo, see error appears
branch on PR
Npm run build on theme-light & typography package
Npm pack to create local package
Install local package in HTML demo with "npm i file: ....\theme\core\typography\scania-typography-1.1.0.tgz"
Install local package in HTML demo with "npm i file: ....\theme\scania-theme-light-2.2.0.tgz"
See error is gone
Try in angular demo as well

Note: Somehow npm link doesn't work with angular 11, some webpack config cause error for the code sourceMapping, that is why we need to try by installing local package of this branch

I tried both in angular and standard HTML both works good!
But I didn't get any error when linking the package normally in angular. 🤔 I even modified some styling in the typography


Add scaffolding command for quickly generating blocks

Description of the Change

This PR adds a new scaffold:block command to the 10up starter theme which allows anyone to easily scaffold out a new block. It is based on the @wordpress/create-block package with custom block templates that are bundled in the scaffold itself.

Closes #
How to test the Change

To test this you can run npm run scaffold:block -w themes/10up-theme in the wp-content folder. This will run through a few prompts and generate the block for you.
Changelog Entry

Added - Block Scaffolding command to easily build out new blocks

Credits

Props @fabiankaegy
Checklist:

[x] I agree to follow this project's Code of Conduct.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[x] All new and existing tests pass.

@fabiankaegy If we were to add it to the toolkit, we could also create a command to publish the templates into the project to be customized, like Laravel does here: https://laravel.com/docs/10.x/artisan#stub-customization.

@ivanlopez 👀 That does sound like an interesting solution that would cover both cases!

@fabiankaegy Since the actual logic to create scaffold the block is handled by @wordpress/create-block I don't think there's much value in moving this to toolkit as it would essentially wrap @wordpress/create-block.  One thing that toolkit could do it let projects override the default template, so if nothing is provided at the project level it would use the one shipped with toolkit.

Okay, in that case, let's keep it simple for now.
We can ship this as is and iterate on it if we find we want more flexibility in the future


Pin aws-sdk-java-core for JSONObject compatibility

The latest version of aws-sdk-java-core removes JSONObject in favor of Jackson (https://github.com/aws/aws-sdk-java/commit/b26560b306d1e0fd1eea7843032d0a51d75a9aa7). This breaks builds of aws-apigateway-importer since it depends on JSONObject. Locking to version 1.10.77 until aws-apigateway-importer can be updated fixes builds.
Fixes #192

Thanks - can you confirm what code is relying on JSONObject in this repo?

Sorry about the delay responding. It looks like it was being used in these files:
src/com/amazonaws/service/apigateway/importer/RamlApiFileImporter.java:17:import com.amazonaws.util.json.JSONObject;
src/com/amazonaws/service/apigateway/importer/RamlApiImporter.java:17:import com.amazonaws.util.json.JSONObject;
src/com/amazonaws/service/apigateway/importer/ApiImporterMain.java:27:import com.amazonaws.util.json.JSONException;
src/com/amazonaws/service/apigateway/importer/ApiImporterMain.java:28:import com.amazonaws.util.json.JSONObject;
src/com/amazonaws/service/apigateway/importer/ApiImporterMain.java:29:import com.amazonaws.util.json.JSONTokener;
src/com/amazonaws/service/apigateway/importer/impl/ApiGatewayRamlFileImporter.java:19:import com.amazonaws.util.json.JSONObject;
src/com/amazonaws/service/apigateway/importer/impl/sdk/ApiGatewaySdkRamlApiImporter.java:29:import com.amazonaws.util.json.JSONArray;
src/com/amazonaws/service/apigateway/importer/impl/sdk/ApiGatewaySdkRamlApiImporter.java:30:import com.amazonaws.util.json.JSONException;
src/com/amazonaws/service/apigateway/importer/impl/sdk/ApiGatewaySdkRamlApiImporter.java:31:import com.amazonaws.util.json.JSONObject;
tst/com/amazonaws/service/apigateway/importer/impl/ApiGatewayRamlFileImporterTest.java:20:import com.amazonaws.util.json.JSONException;
tst/com/amazonaws/service/apigateway/importer/impl/ApiGatewayRamlFileImporterTest.java:21:import com.amazonaws.util.json.JSONObject;
tst/com/amazonaws/service/apigateway/importer/impl/ApiGatewayRamlFileImporterTest.java:22:import com.amazonaws.util.json.JSONTokener;

If  I knew anything about modern Java development, I would happily take on converting to the new method, but sadly I wouldn't know where to begin! :smiley:
Thanks for the merge.


Konsole not supported with sixel

This library does not recognize that Konsole has sixel support.
Related Issue: https://github.com/aome510/spotify-player/issues/202
Output of echo $TERM: xterm-256color

if you mean Konsole as in KDE's terminal, then it is supported for me:
$ echo $TERM
xterm-256color

$ echo "\x1b[c"

^[[?62;1;4c

viuer 0.7.1
konsole 23.08.5
viuer's feature sixel just needs to be activated


Allow a single asset to contain multiple data

Problem
Our asset flow lacks support for non-trivial asset handling.
The following scenario is a good example of this:

UI Image elements use a render device (GPU) texture.
That render device texture is created by sending an image to the GPU/render device.
The image can be loaded from a file.

Currently, we can tackle this by providing an Image asset type, which loads a .png or equivalent.
Then, on the UI side, we keep a Asset<Image> field on a component, and the UI code must manually manage the render device texture creation.
This is cumbersome and error prone, and this is only one of the examples - we also have a similar situation with voxel grids.
Solution
A single asset (UUID) should be able to contain multiple data types.
For example, taking the image example once again, we could have two asset types: Image, and Texture.
The UI would store an Asset<Texture>, keeping a reference to only the GPU/render device texture asset.
When loading texture data for a given asset, the TextureBridge load method is called, which internally loads the Image data of the same asset, and creates a render device texture.
As no reference is kept to the Image data, it can be unloaded, keeping only the Texture part.
To sum it up, we should:

Identify asset data through their type and UUID, not only by their UUID.
Change asset meta files to not contain the data extension (i.e., instead of image.png.meta, just image.meta).

After thinking about this a bit further, I came to the conclusion that this might not be such a good idea, as multiple 'source' assets may need to be exported multiple times, with different options. For example, it should be possible to create multiple font atlas assets from a single font asset.

Following up on the previous comment, we decided to keep the existing system, and simply have assets which don't have 'data file' counterparts. For example, we could have a .mesh asset which only contains a meta file, i.e., car.mesh.meta, but no car.mesh itself. Then, on the meta file, it would contain the UUID of the .grd from which the mesh is loaded.


Parser creates 8-node element array for cartilage files

Half of this task ended up being fixed simply by implementing issue #249. The side nodes section of the cartilage files is what was creating 10+ node element arrays. I just need to properly add the new 8-node element array data into session storage now.

Completing this task took about 40 minutes. 15 or so of that was coding, the rest was testing the results using console statements.  Each row of the elements array created by a cartilage .inp file is now length 9. Index 0 is the element number itself, and then indexes 1 through 8 are the nodes required to make a cartilage element. These elements can be drawn as cubes instead of the triangles for bone .inp files.
Naming conventions for accessing cartilage element session data are:
'total elements'
'initial element number'
'element element# node 1'
'element element# node 2'
'element element# node 3'
'element element# node 4'
'element element# node 5'
'element element# node 6'
'element element# node 7'
'element element# node 8'
The element# for accessing individual nodes in an element will change based on which element you want to access. It should always be index 0 of its row in the multidimensional elements array.


Add instructions for submitting detailed logs

Resolves https://github.com/Microsoft/WSL/issues/3137

Checking back in after a couple of days. Are more changes needed? Anything else that's blocking this from being merged?

@chwarr - Other than my vacation, nope! Thanks for taking care of this.

Is it possible to collect ETL with tracelog.exe insead of logman.exe?


Service not getting registered against correct host

I am running registrator container on all of my hosts. Also I am running a sample httpd container on all the hosts for HA. When registrator registers the service, it is registering against consul node and not under the host where the service is running.
I am not sure that I am not starting the container's correctly.
To bring up the registrator:
docker run -d  -v /var/run/docker.sock:/tmp/docker.sock -h $HOSTNAME  gliderlabs/registrator:latest -ip $IP consul://consulhost
To bring up the httpd container:
docker run -i -d -P -e "SERVICE_NAME=simple" -e "SERVICE_IP=$IP" -h $IP httpd:latest
Curl to consul:
$ curl http://consulhost/v1/catalog/service/simple
[{"Node":"consulnode","Address":"CONSUL IP","ServiceID":"HOST1 NAME:gloomy_hawking:80","ServiceName":"simple","ServiceTags":null,"ServiceAddress":"HOST1 IP","ServicePort":32774},{"Node":"consulnode","Address":"CONSUL IP","ServiceID":"HOST2 NAME:suspicious_wozniak0:80","ServiceName":"simple","ServiceTags":null,"ServiceAddress":"HOST2 IP","ServicePort":32779}]
I am not sure where I am making mistake or the its bug.
Thanks

Can you be more specific about what you want to see?

Thanks for the response. I would like to see the simple service being registered against the node that it runs instead of under consulnode.
Currently all the services are listed below consulnode from the consul UI. There are 0 services being listed under that node that runs the service.
Hope this explains the problem I am going through.

Consul expects you to register services against the local running agent. If you're not connecting to that agent it's not going to register them with the right node. This is node a registrator issue.

I belieave what @progrium means is that for every node where you are running docker containers, you must have a local consul agent(not in server mode), and register against that local agent, which in turn forwards it to the master consul node. Hopefully that will help you out

Thank you progrium/JohnyDays. It helped.


Youtube crashed by YouPiP

"-[MLPIPController initWithPlaceholderPlayerItemResourcePath:]: unrecognized selector sent to instance 0x282dfe220"

Which YouTube version?

15.49.6

Fixed in 1.3.1


Update Rakefile

Only leave page building

/lgtm
/approve

I'm not very prowd of this, force merging...


Fix settings menu on mobile

Currently when switching between the setting tabs on mobile it annoyingly opens the first section:

Also note how the list view has the title of the last viewed section and highlights it in the list (which is quite confusing).
With the first commit it looks like this:

The second commit fixes a media query edge case that completely broke the settings navigation.

Testing Plan:
GIFs or Screenshots:

This is great; I posted a batch of small comments.  Thanks @Gittenburg and let me know when those are resolved :)

Merged as the series ending with 35378d4660afbd3bda0e8947f53f376b55d55f60, after adding some comments in the second commit to at least mark that we're doing something weird, and noting the no-border change in the first's commit message.  Ultimately it seems like a bad idea to have subscriptions.scss contain a bunch of shared media query logic; we should perhaps look at a refactoring to make a common component in app_components.scss for the 2-column overlay styling.
Thanks @Gittenburg!


add support for taking filters as an input

also add support for setting filters after chart has instantiated

This is something I could possibly take on.
Any thoughts @hkang1 on how to approach?

What is the desired API?
setFilters(Hermes.Filter[]).
addFilters(Hermes.Filter[]).
resetFilters()
Do merge and update like from user interactions?
Do we want to apply regardless of whether it's above the threshold interaction supplied filters? Or does that cause problems?

What is the desired API?
setFilters(Hermes.Filter[]).
addFilters(Hermes.Filter[]).
resetFilters()

Yeah those three actions sound reasonable. Maybe Hermes.Filters as an input instead so we also know which dimension to apply the filters.
One additional way to add might be to take Filters during Hermes initialization, which would be useful if the dev wanted to build a chart with filters pre applied in one go.

Do merge and update like from user interactions?

Yeah. There is an update routine that "cleans up" filters. Specifically it removes 0-sized filters and also merges overlapping filters within the same dimension. But mimicking user interactions makes sense to me.

Do we want to apply regardless of whether it's below the threshold required for user-interaction-supplied filters? Or does that cause problems, and we should require threshold?

Good question... my initial reaction is that it's probably best to mimick the user interactions, which translates to following the threshold rules.

removeFilters() could be a useful one too, but referencing the exact filter to remove could be a bit tricky. Would need the dimension key and the index of the filter. e.g. removeFilter('accuracy', 1) would remove the 2nd filter from the accuracy dimension.

resolved with PR 114


mgmt, upgrade compute

live test pass
manual change:

https://github.com/Azure/azure-sdk-for-java/pull/34551/commits/34283316f74ba980f5c068380f43117680b6ff82
https://github.com/Azure/azure-sdk-for-java/pull/34551/commits/6bee4dacbbaf19695c95bc12a1e3732e131cc4b2
https://github.com/Azure/azure-sdk-for-java/pull/34551/commits/40906d74a76d0da5f08ac828e331db1a0e6b78e6 @XiaofeiCao , as I am not sure whether instanceId be null or not would have other implications

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

We may need to skip revapi:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=2711147&view=logs&jobId=b70e5e73-bbb6-5567-0939-8415943fadb9&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=68a849d6-f425-5f38-d450-7e2c3d1df885

We may need to skip revapi: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2711147&view=logs&jobId=b70e5e73-bbb6-5567-0939-8415943fadb9&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=68a849d6-f425-5f38-d450-7e2c3d1df885

Yeah, updated changelog. Seems the one of type change is the real break (other likely not used).


Suggestion for a Complimentary GraphQL Client for ASP.NET Core Blazor

Greetings gentlemen,
I would like to suggest creating a new GraphQL client to complement this awesome GraphQL server framework. The timing of this suggestion is related to introduction of ASP.NET Core Blazor. As web developers, we are used to use something like Apollo Client to communicate with out HotChocolate Server in JavaScript world. However, the world is changing now for a full-stack pure .NET implementations for both client and server. Hence, the need for an awesome client. There may be some existing GraphQL clients, and I have not throughly looked at all of them; but the trust in your framework quality is pushing me to ask for a complimentary client with similar quality as well.
What do you guys think?

@geekox86  There is already one. And it is awesome! ;)
Check it out here, it available in 11 previews. At the moment there is a massive PR from @michaelstaib  in the works that will further improve it :)
It is a graphql client that generates c# types for your queries, mutation or subscriptions. Like actuall C# types
The tooling downloads the schema file so. The client is actually generated from this downloaded file.
You only need to have the server running when you update the schema file.
So only when you change the schema :)
It comes with tooling so that you really only have to set it up once and then the client is generated on every build.
You just have to do this:
You just have to do this:

add reference to StrawberryShake in project file
currently the newest version is 11.0.0-preview.84
install the tool in the project folder
 dotnet tool install strawberryshake.tools --version 11.0.0-preview.84
initialize the project
dotnet graphql init <<graphqlendpoint>> -p <<path fot the client>> -n <<name of the client>>
e.g.
 dotnet graphql init  http://localhost:60004/graphql -p ./Clients/MyClient -n MyClient
add a query file Queries.graphql to the folder /Clients/MyClient
register generated client and http client in di
build and enjoy.

more info you find in the blog post, the github repo or on slack
You can join here:
https://join.slack.com/t/hotchocolategraphql/shared_invite/enQtNTA4NjA0ODYwOTQ0LTViMzA2MTM4OWYwYjIxYzViYmM0YmZhYjdiNzBjOTg2ZmU1YmMwNDZiYjUyZWZlMzNiMTk1OWUxNWZhMzQwY2Q
Check it out:
https://chillicream.com/blog/2019/11/25/strawberry-shake_2

@PascalSenn this is actually fantastic news :-)
I will definitely a try and provide feedback.
I am very interested on the caching aspects of the client.
What are the caching strategies available?
I may need to sneak into the source code a bit.

@geekox86  I could be wrong but I don't think there are any implemented yet.
But this is definitely a question for @michaelstaib

it is still early. The store api is not yet in ... we are currently focusing on the pipeline api and the generators. after this is in we will focus on state management.

I am closing this issue

I am giving an online talk about this next Friday ... get registered if you are interested:
https://www.meetup.com/DotNetIasi/events/269455344/


Forked Repository just shows the readme

Hi there!
I forked your repository like you said in the instructions. But I cannot see the portfolio page correctly. I just see the README.
https://github.com/GoodbyeKittyy/GoodbyeKittyy.github.io
https://goodbyekittyy.github.io/
Can you help advise on this?

Apologies. I kept trying and I managed to get it!


Option to install Rebar3

Note this has not been tested, and with regards to Powershell I have no idea what I am doing.
Please give feedback

I've tested OTP versions <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, 23.3.1, 24.0.2 with rebar3-version: true parameter, and it works for ubuntu-latest at least.


⚠ ClamAV has degraded performance

In 4869ea5, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 286 ms

Resolved: ClamAV performance has improved in 3a10f1b after 8 minutes.


Setting the component file name to be imported from in index.ts file.

Hello and thank you for your awesome tool!!!
I just have one question though - what configuration I need to add in the rcci.config.js file in order to export as a variable for the templates the component file name?
Example:
If my component file name is my-component.tsx I need to use it in index.ts the following way: import { #NAME# } from "./#FILE_NAME#" where this should compile to import { MyComponent } from "./my-component".
Thank you in advance!

Hello @SimetrioKolev!
Thank you for the question! It is really right question, because i forgot to support this case in my default templates.
Btw, i will help you.
First, you need to open rcci.config.js and add new placeholder like that:
{
  ...
  placeholders: {
     ...
     COMPONENT_FILE_NAME: ({ filePrefix }) => filePrefix,
  }
}

After that, open your index file template and change it like this:
export { #NAME# } from './#COMPONENT_FILE_NAME#';

And then - check, it shoud work.
You can see all available fields here. I'm sure you can describe whatever you want by using them. But if you find the hard case i can update functionality to help you with.
Have a nice day! 😊

Hey, brother, thank you for your quick response!
Unfortunately for some reason it doesn't work. Look what I got compiled on
creation:
import { MyComponent } from './#FILE_NAME#';
I have set  in the config file exactly what you've suggested:
FILE_NAME: ({ filePrefix }) => filePrefix,
Any idea why it might not work? THanks in advance!
Best regards,
Petar.
On Fri, Jan 28, 2022 at 6:13 PM Kamenskih Dmitriy @.***>
wrote:

Hello @SimetrioKolev https://github.com/SimetrioKolev!
Thank you for the question! It is really right question, because i forgot
to support this case in my default templates.
Btw, i will help you.
First, you need to open rcci.config.js and add new placeholder like that:
{
...
placeholders: {
 ...

 COMPONENT_FILE_NAME: ({ filePrefix }) => filePrefix,

}
}
After that, open your index file template and change it like this:
export { #NAME# } from './#COMPONENT_FILE_NAME#';
And then - check, it shoud work.
You can see all available fields here
https://github.com/coolassassin/reactcci#placeholders. I'm sure you can
describe whatever you want by using them. But if you find the hard case i
can update functionality to help you with.
Have a nice day! 😊
—
Reply to this email directly, view it on GitHub
https://github.com/coolassassin/vs-rcci/issues/1#issuecomment-1024368023,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWK4ZV6NJLRHKZCQU3XPC5LUYK6A5ANCNFSM5NAZUCYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

First of all, check the version of reactcci package in yarn.lock or package-json.lock. It must be 1.8.0 or higher.
If version is ok, you can try to use my updated "reactcci" package version. After you request I have released new version of package with this placeholder. You can try to delete your config and templates, or make a new project, and then run "yarn rcci" (npx rcci) again to init reactcci. I have checked this. It works.
If it not help you, so, you can attach you config file, or make a project on github with this issue and i will help you.
P.S.: No replacement without errors looks like that placeholder in file and placeholder in config have different names. Try to check or copy it.

I have updated it to v1.8.4 before I tested it but you are right about the
yarn.lock file, I have forgotten to delete it before the package update.
 THank you, mate!!! Will give you feedback right after I
do it :)
On Mon, Jan 31, 2022 at 1:35 PM Kamenskih Dmitriy @.***>
wrote:

First of all, check the version of reactcci package in yarn.lock or
package-json.lock. It must be 1.8.0 or higher.
If version is ok, you can try to use my updated "reactcci" package
version. After you request I have released new version of package with this
placeholder. You can try to delete your config and templates, or make a new
project, and then run "yarn rcci" (npx rcci) again to init reactcci. I have
checked this. It works.
If it not help you, so, you can attach you config file, or make a project
on github with this issue and i will help you.
P.S.: No replacement without errors looks like that placeholder in file
and placeholder in config have different names. Try to check or copy it.
—
Reply to this email directly, view it on GitHub
https://github.com/coolassassin/vs-rcci/issues/1#issuecomment-1025646803,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWK4ZV7CM7V3AXFRWW2JRFDUYZXZFANCNFSM5NAZUCYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

So, I will close issue. If you find any problems - create a new one.

Hey, Dmitriy :)
It's working perfectly, thank you so much :)))))
I hit another issue, though. I have installed your lib in our project under
devDependencies. A colleague of mine installed the VS Code extension and
when trying to create a component the add-on pops up a modal with a
question does he want to install reactcci in the project.
Do you have any idea why this might occur when we already have it
installed? Thanks in advance!
Best regards,
Petar.
On Tue, Feb 1, 2022 at 10:17 PM Kamenskih Dmitriy @.***>
wrote:

Closed #1 https://github.com/coolassassin/vs-rcci/issues/1.
—
Reply to this email directly, view it on GitHub
https://github.com/coolassassin/vs-rcci/issues/1#event-5990983101, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AWK4ZV6V6QHX6BRTWW644KLUZA5XBANCNFSM5NAZUCYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello, @SimetrioKolev!
This extension check package by searching ./node_modules/reactcci
It is searching in the root folder.
If package installed not in the root of project, you can open this folder in VSCode to make it as a root.
But, you have the alternative way. The extension has a setting. This setting named like a "Root".
So, you can set up your own root relatively to you current root.
After both of this ways it should work fine.
Btw, I heard that new yarn has feature, where node_modules folder is hidden. So, if you use this feature and cuz of this you have this trouble, let me know. I will try to find a solution in my next releases.

Hello again, @SimetrioKolev!
I have made a new realese. 0.5.0 version.
Now it should work fine with berry version of yarn 👌

Hey there, mate =]
THanks for the update! Btw I am using yarn (v1.x.x) workspaces and I didn't
think at all about the root issue and it makes a lot of sense!
The thing is I have multiple projects in which I wish to use your add-on
and the extension is accepting a single path. I will try to pass the paths
as strings in an array, and as a last resort if this doesn't work I will
install your package in the root of the workspace instead of in every
package. Then it should work :)
Thank you for all the effort!!! Your add-on is amazing!!!
On Sat, Feb 5, 2022 at 6:35 PM Kamenskih Dmitriy @.***>
wrote:

Hello again, @SimetrioKolev https://github.com/SimetrioKolev!
I have made a new realese. 0.5.0 version.
Now it should work fine with berry version of yarn 👌
—
Reply to this email directly, view it on GitHub
https://github.com/coolassassin/vs-rcci/issues/1#issuecomment-1030655332,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWK4ZV2AWJRHB3QCDJVIWQTUZVGUFANCNFSM5NAZUCYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello @SimetrioKolev
It is great that we figured it out.
So yeah. You have two ways, then.
First is to set multiple paths for folderPath param as array.
Second is to use multi-project mode.  This mode allows you to select project in CLI mode, and use Project name in your templates.
For example, you have projects with this structure:

Project1/src/components/
Project2/frontend/src/
Project3/modules/

Then you can set folderPath like that:
['src/components/', 'frontend/src/', 'modules/']
Then set multiProject to true, and that is it. My CLI will find your projects automatically.

AMAZING!!! I will try it out =]
On Mon, Feb 7, 2022 at 8:56 AM Kamenskih Dmitriy @.***>
wrote:

Hello @SimetrioKolev https://github.com/SimetrioKolev
It is great that we figured it out.
So yeah. You have two ways, then.
First is to set multiple paths for folderPath param as array.
Second is to use multi-project mode. This mode allows you to select
project in CLI mode, and use Project name in your templates.
For example, you have projects with this structure:

Project1/src/components/
Project2/frontend/src/
Project3/modules/

Then you can set folderPath like that:
['src/components/', 'frontend/src/', 'modules/']
Then set multiProject to true, and that is it. My CLI will find your
projects automatically.
—
Reply to this email directly, view it on GitHub
https://github.com/coolassassin/vs-rcci/issues/1#issuecomment-1031132452,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWK4ZV6CZUO3BHHVQGXHSJDUZ5UJVANCNFSM5NAZUCYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Handle skipCertVerification field for pipelines fetch

Setting
skipCertVerification: true
for pipelines.https seems to have no effect.
Steps to reproduce:
install default Kab instance
create and deploy Nginx container hosting pipelines tarball
edit Kab CR to point to Nginx container route, including skipCertVerification: true
check stack controller logs to see x509: certificate signed by unknown authority
listing pipelines returns empty as original defaults have been removed (correctly) but newly config'd pipelines have not loaded.

Looking at the code....
https://github.com/kabanero-io/kabanero-operator/blob/310160e8d1b9df3410c34d54d017baf015ecbb32/pkg/controller/stack/archive.go#L56
seems to always pass false to the cache which always causes certificates to be verified.
To get this to work, we'd have to pass in more than just the URL to this method.  I think back in stack_controller.go, we'd have to add more than just the url to the pipelineUseMapValue:
https://github.com/kabanero-io/kabanero-operator/blob/310160e8d1b9df3410c34d54d017baf015ecbb32/pkg/controller/stack/stack_controller.go#L385
the pipelineUseMapValue is an extended form of the PipelineStatus.  So perhaps we can just add the whole HttpsProtocolFile to the PipelineStatus instead of just the URL part.  It would change the structure of the Stack CR status somewhat.  Or could just add it directly to the pipelineUseMapValue so that it can be read out later and passed to GetManifests().

Fyre 4.3 cluster w/ Kabanero 0.8.0-rc.2
oc get kabanero kabanero -o yaml
  stacks:
    pipelines:
    - gitRelease: {}
      https:
        skipCertVerification: true
        url: https://pipelines-index-latest-kabanero.apps.wharfrat.os.fyre.ibm.com/default-kabanero-pipelines.tar.gz
      id: default
      sha256: d4d825415e933a2ceabd9e5be94f8bf2441abc85b666d83b5ff94b2b5428dc59

oc get stack java-microprofile -o yaml
spec:
  name: java-microprofile
  versions:
  - images:
    - id: Eclipse MicroProfile®
      image: docker.io/kabanerobeta/java-microprofile
    pipelines:
    - gitRelease: {}
      https:
        skipCertVerification: true
        url: https://pipelines-index-latest-kabanero.apps.wharfrat.os.fyre.ibm.com/default-kabanero-pipelines.tar.gz
      id: default
      sha256: d4d825415e933a2ceabd9e5be94f8bf2441abc85b666d83b5ff94b2b5428dc59

While I was researching the fix for this, I stumbled on something that seems kind of minor but can really mess up how the stack controller manages the tekton artifacts.
There is this thing called the pipelineUseMapKey that is basically the key to a map that manages whether a stack version uses a particular pipeline version (meaning a pipeline zip with a particular URL and digest). That key can either contain a URL, or a struct of GitHub release information.  The value of this map then becomes the content of the pipeline zip and a bunch of other meta-data about how it is used by the various stack versions.
When we introduced GHE support, the skipCertVerification boolean ended up in the pipelineUseMapKey.  If you had two stack versions, which only differed in skipCertVerification, this would cause the stack controller to try and load and apply that pipeline twice.  However when one version got removed from the Stack CR instance, the results would be non-deterministic, because the stack controller would think it had to delete those artifacts for the version that just went away, but then keep them for the other... but they have two different map keys.
When I fix this, I'm going to remove the cert verification from the key if I can.  The cert verification information can be kept on the side and used if we need to retrieve the pipeline zip from either the web, or from a GitHub/GHE release.
The cert verification information should probably also be removed from the Stack CR status, but that's less important.


Reachability 8badf00d

Can you tell me why？

Revive! Just noticed that I am getting this too. Not often, maybe once every 200 app startups. I've just ended up removing the initialisation code from application:didFinishLaunchingWithOptions:


How does cosign verify use the privatized fulcio deployment?

How do I specify the fulcio service address for private deployment when using the cosign verify command to verify the mirror signature

https://github.com/sigstore/cosign/blob/004443228442850fb28f248fd59765afad99b6df/cmd/cosign/cli/options/fulcio.go#L36


Vscode Razor Comment no color

I use Vscode 1.79.2 and latest C# extension to dev Blazor.
But I found my razor Page, @code{ } block Comment isn't have Color

at right side bar is my all use extension now.
this project is new, I just add 2 lines

@Edemilorhea could you confirm exactly what version of the C# extension you are using? I can see you're on the pre-release, which is great, but I cannot reproduce this issue with v2.0.212

@Edemilorhea could you confirm exactly what version of the C# extension you are using? I can see you're on the pre-release, which is great, but I cannot reproduce this issue with v2.0.212

Thanks your replay, But I found the problem is my mistake, I found two reason for this problem.

My Vscode Setting set "editor.semanticHighlighting.enabled" is true, So it skip the razor comment.
is C# Extension some times cannot be parsed Razor Component code block normally.

I think it is expected that we don't use semantic highlighting in Razor, tracked in https://github.com/dotnet/razor/issues/4323
I'll close this out as not a bug, but if you run into a good example of number 2, where the extension can't parse the code block correctly, please feel free to log a new issue.


Change semantic ordering of kernel_size parameter in SSIM

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Fixes https://github.com/PyTorchLightning/metrics/issues/414
Changes the semantic ordering of kernel_size parameter of SSIM metric such that it matches the standard [N, C, H, W] image format. Note this does not change anything for the end user, essentially just a change of variable naming to match standard.
Also adds a bit more testing for the metric.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@justusschock mind have look?


conjur-oss should be available as a stable helm chart

We want to be in the charts here: https://github.com/helm/charts.
Figure out what needs to be done to submit this chart for verification.

More preferably, the stable section. 😛

considering helm stable is going the way of the dodo I think this one can be closed ;)

:) thanks @The-Loeki - I'll take you up on that!


Twisted Edwards in extended coordinates w/ a=-1

[do not merge yet]
#91

faster but not unified formulae
paper: https://iacr.org/archive/asiacrypt2008/53500329/53500329.pdf
EFD: https://hyperelliptic.org/EFD/g1p/auto-twisted-extended-1.html

@yelhousni instead of "[do not merge yet]" can you put the PR as Draft and make it ready when it's ready to merge ? :)


0.7.0 Autotune: UAM always categorized as basal even if categorize-uam-as-basal setting is false

I made hundred tests to compare results with or without categorized-uam-as-basal setting
=> Tests done with AutotuneWeb and on a virtual machine on my computer (I use AndroidAPS)
UAM data are always categorized as basal whatever categorize-uam-as-basal setting (even in my worst days with several hours of uam data)
This is confirmed by a code analysis of categorized.js file lines 289-396
    if (opts.categorize_uam_as_basal) {
        console.error("--categorize-uam-as-basal=true set: categorizing all UAM data as basal.");
        basalGlucoseData = basalGlucoseData.concat(UAMGlucoseData);
    } else if (CSFLength > 12) {
        console.error("Found at least 1h of carb absorption: assuming all meals were announced, and categorizing UAM data as basal.");
        basalGlucoseData = basalGlucoseData.concat(UAMGlucoseData);
    } else {
        ...
    }

It's just quite impossible to have test line 392  else if (CSFLength > 12) false: if we have only one meal announced with 20 or 25g of carbs, we will have at least one hour of CSF data so even if we have several hours of UAM data, all uam data will always be categorized as basal...
=> I think code between lines 396 and 424 is never executed
I also made some tests replacing line 392 by  else if (UAMLength < 12)
=> With this line if I have less than 1 hour of UAM data (assuming all meals were announced) UAM data is categorised as basal)
=> But if I have more than one hour of UAM data then UAM are categorized between ISF and basals according to lines between 396 and 424
I think with this modification Autotune works as expected (there are security warning in documentation if we use --categorize-uam-as-basal=true...)

Yes, this is on purpose. We originally had the behavior you expected, but too many people were seeing "problems with autotune failing to converge, and instead constantly trying to reduce basals until it hits safety limits, because too much data that would otherwise indicate basals are too low is being excluded as UAM", as described at in the PR where we added the code you found:
https://github.com/openaps/oref0/pull/1195

Sorry wrong manip


How to run inference using existing models?

Hey, I see a method of evaluation on the readme, but is there some example code for running inference on an example file?

The repo now includes a demo notebook showing how to load pretrained models and run inference on individual files :)
-> Demo Notebook

@burchim !! You even put it in a colab notebook! Thank you so much!

@burchim I tried to run the small model on Colab on one of my files and got this error for some reason when running this code:
audiofile = '/content/drive/MyDrive/test.wav'
audio, sr = torchaudio.load(audiofile)

# Predict sentence
prediction = model.gready_search_decoding(audio.to(device), x_len=torch.tensor([len(audio[0])], device=device))[0]
print("model prediction:", prediction, '\n')

IndexError                                Traceback (most recent call last)
<ipython-input-16-750b6f475cbd> in <module>()
      5
      6 # Predict sentence
----> 7 prediction = model.gready_search_decoding(audio.to(device), x_len=torch.tensor([len(audio[0])], device=device))
      8 print("model prediction:", prediction, '\n')

/content/EfficientConformer/models/model_ctc.py in gready_search_decoding(self, x, x_len)
    112
    113             # Decoding Loop
--> 114             for t in range(logits_len[b]):
    115
    116                 # Blank Prediction

IndexError: index 1 is out of bounds for dimension 0 with size 1

I assume this is just me doing something stupid with the code.

I also just tried converting my file to .flac, 16kHz, and placing it in a folder like the Librispeech example so that I don't make many changes to the code. I only deleted the displaying the audio bit, and I still got that error.

I think that the error comes from the fact that your audio file has multiple audio channels.
This will result in a tensor of size (channels, audio_length) instead of (1, audio_length).
prediction = model.gready_search_decoding(audio.to(device), x_len=torch.tensor(audio.size(0)*[audio.size(1)], device=device))
This should resolve the problem by transcribing each channel separately.

Ah! Silly me. If I'd only checked the difference between my file and the librispeech ones. Thank you so much again for being so helpful. I will try again.

Just an update: I tried it and it worked! Thanks again.


Document bitfield usage in the users guide

Similar to the section on using unions, we should have a section on using bitfields.

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.
If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. :smile:

@highfive: assign me

Hey @ambaxter! Thanks for your interest in working on this issue. It's now assigned to you!

@ambaxter I don't think we have anything in CONTRIBUTING.md about using mdbook yet (another PR opportunity!), but between mdbook's documentation and running mdbook watch from the ./book directory, I think you should be able to figure everything out.
As far as content goes, we should just explain how bitfields get translated from C/C++ into Rust, and how to use them. You can experiment locally and look at the bitfield related tests. High bits are getters, setters, and bitfield unit constructors.
Let me know if you have any questions :)

@ambaxter making any progress here? Anything I can help with?

I am making some progress. A few things came up that took my time. Hope to be done in the next day or two.


ROCANA-5660: Rewrite netflow project imports

Sorry, wrong repository!

Thanks for contributing?

This step is part of our golang vendoring process. I will be happy to send some real contributions your way in the coming weeks!


How to load multiple safetensors with json format

For such a task:
https://huggingface.co/black-forest-labs/FLUX.1-dev/tree/main/transformer
how should safetensors be loaded?

All the examples in this repo use hub_load_safetensors to load weights from a json description like this.
In the case of flux, we actually use the main safetensors file at the root of the repo that combines all these together.

Thanks, this works great with mmap.

By the way, is there a plan to load and save a single flux model file?
The model I downloaded from civit has this structure:
[
    "model.diffusion_model.double_blocks.0.img_attn.norm.key_norm.scale",
    "model.diffusion_model.single_blocks.9.norm.query_norm.scale",
    ...,
    "model.diffusion_model.final_layer.adaLN_modulation.1.bias",
    "model.diffusion_model.guidance_in.in_layer.bias",
    "model.diffusion_model.img_in.bias",
    ...
    "text_encoders.clip_l.logit_scale",
    "text_encoders.t5xxl.logit_scale",
    ...
    "vae.encoder.conv_out.weight",
]

And the python version also supports this:
https://github.com/huggingface/diffusers/pull/9083

This shouldn't be too hard to support as the weight structure seems mostly identical, my guess is that it would just require tweaking the example code and not require much/any change on the actual model side.
Could you provide some pointers to models that use this layout?

flux-clip.json
scheduler/                # not mapping
text_encoder/             # -> text_encoders.clip_l.transformer.{KEY}
?                         # -> text_encoders.clip_l.logit_scale
text_encoder_2/           # -> text_encoders.t5xxl.transformer.{KEY}
?                         # -> text_encoders.t5xxl.logit_scale
tokenizer/                # no weights
tokenizer_2/              # no weights
transformer/              # not mapping?
vae/                      # not mapping?
ae.safetensors            # -> vae.{KEY}
flux1-dev.safetensors     # -> model.diffusion_model.{KEY}

Sorry I meant would you have a link to an actual safetensors file that has this layout so that I can give it a try?

https://huggingface.co/Comfy-Org/flux1-dev/tree/main?show_file_info=flux1-dev-fp8.safetensors
These formats can't actually be loaded because the dtype is not supported.
I can't find an unquantized version


Pick "Bug Prevent making snapshot on remote rowset in sin…

…gle replica compaction #28716"
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


isuue regarding registering a url

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[144], line 5
      2 parent_dict = {}
      3 file_path = '/home/finley/test_dict.json'
----> 5 create_parent_dict(link, parent_dict, file_path)

Cell In[143], line 9, in create_parent_dict(link, parent_dict, file_path)
      5 links = get_csv_links(link)
      7 for link in links:
----> 9     create_erthscp_dict(link, parent_dict, i)
     12     i += 1
     14 save_dict_to_json(parent_dict, file_path)

Cell In[140], line 25, in create_erthscp_dict(url, parent_dict, i)
     21 name = 'erthscp_dict_' + str(i)
     23 parent_dict[name] = data
---> 25 client.register_url(**data)

File ~/.local/lib/python3.10/site-packages/scidx/client/register_url.py:164, in register_url(self, resource_name, resource_title, owner_org, resource_url, file_type, processing, notes, extras, mapping)
    152 headers = self._get_headers()
    154 # Build the payload
    155 payload = {
    156     "resource_name": resource_name,
    157     "resource_title": resource_title,
    158     "owner_org": owner_org,
    159     "resource_url": resource_url,
    160     "file_type": file_type,
    161     "notes": notes,
    162     "extras": extras or {},
    163     "mapping": mapping or {},
--> 164     "processing": processing.to_dict(),
    165 }
    167 response = requests.post(url, json=payload, headers=headers)
    168 if response.status_code == 201:

AttributeError: 'dict' object has no attribute 'to_dict'

I am seeing a regression to his now that processing is an optional parameter.
I suggest something like this:
# Build the payload
   payload = {
       "resource_name": resource_name,
       "resource_title": resource_title,
       "owner_org": owner_org,
       "resource_url": resource_url,
       "file_type": file_type,
       "notes": notes,
       "extras": extras or {},
       "mapping": mapping or {},
   }

   if processing:
       payload['processing'] = processing.to_dict()

The problem with any resolution to this in the client is that processing is being validated against the file_type-specific model in the API. I'm opening a ticket for this in the scidx-api repo, since that's where the handling comes out.

Hi Philip! This has been resolved in the branch, the new version looks like this:
payload = {
"resource_name": resource_name,
"resource_title": resource_title,
"owner_org": owner_org,
"resource_url": resource_url,
"notes": notes,
"extras": extras or {},
"mapping": mapping or {},
}
if file_type:
    payload["file_type"] = file_type
if processing:
    payload["processing"] = processing.to_dict()

By the end of today I will send the merge request of the actual branch I am working on.


Fixing one and removing another dead link

Hey @dreamingechoes,
just fixing one link and removing a dead link here.
Cheers!

Awesome, thank you @dreamingechoes !


Unify internal and external LN pay API

Having two APIs for internal and external payments leads bad DX and bugs in downstream projects (e.g. #6000). From my PoV there are are two improvements possible here:

Rename functions to be more clear:

subscribe_ln_pay to subscribe_ln_pay_external
subscribe_internal_pay to subscribe_ln_pay_internal

Create a new subscribe_ln_pay function that internally chooses correct implementation

CC @m1sterc001guy @joschisan

Lnv2 fixes this.


Set-MsolCompanyMultiNationalEnabled - possible Servicetype

Hi Team, it would be great to have a list of selectable servicetypes here. Trying to work with SharePoint online but due to the lack of information i'm not able to figure out the correct servicetype naming.

@RobdeJong  have you seen this suggestion?

any update on that? i would like to enable the future for Skype and getting the same error..

Hi @NatiSayada
Sorry for the delay in response.  I have opened a work item for this so that engineering can take a look and possibly address this.  At this point, I am going to go ahead and close this issue and will post any update I have here.  Thanks!
Bill


Baklava

Our baklava is better.
(Even though I've never tasted yours so technically I can't know until I eat yours)
PS: this is 100% satire, greetings from Greece

Fork our baklava and present yours ;)
Greetings from the Netherlands 😊


People messaging me to be invited to group after I've joined another group using ClassicLFG

Here's what happened:

Used ClassicLFG to advertise that I wanted to "Join a Group" for ZF
Saw it was posting my desire to join a group in LookingForGroup
Got an invite pretty fast afterwords
While inside ZF I got at least 2 messages (whispers) asking me to invite them to the group
I was busy in the instance so I couldn't/didn't check to see what I was saying in LookingForGroup or General for the instance's zone
I'm just confused...

Why would two separate people ask me to invite them to a group that I'm not advertising for?  I didn't use the create group function in ClassicLFG and I haven't yet.  I've only used the Join a Group system.
After I join a group does it think I want to find more people and keeps advertising?

I've had the same experience


Setting make tool plugin to return None when a subprocess check_outpu…

…t command fails. This will cause Statick to exit with an error condition. A new unit test was added to check for valid make scans.

Codecov Report

Merging #182 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   95.52%   95.66%   +0.13%
==========================================
  Files          45       45
  Lines        2214     2214
==========================================
+ Hits         2115     2118       +3
+ Misses         99       96       -3

Impacted Files
Coverage Δ

statick_tool/plugins/tool/make_tool_plugin.py
84.7% <100%> (+3.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d806ad...e55cba2. Read the comment docs.


Disable separator

Purpose
As a developer I want to disable the separator because I want to handle this myself.
Proposal
Probably a prop rather than css.
Acceptance criteria

[ ] As a developer I can disable the separator

Hi @johnwalley, is this issue still available? If yes, I would love to work on it

Hi @uwemneku. I've not started on this issue and would be happy for you to take it on 👍

Thanks, @johnwalley. So I understand the task better, the props to disable the separator would make the separator-border invisible right? And would this also affect the blue hover effect for the sash?

I imagine a prop, say separator={boolean} on the main component.
If it is false then we don't add the before pseudo element. Just to be clear, we simply don't add it, rather than make it invisible.


Add permissions

Hey,
i tried to add new permissions to the manifest:
...
"version": "1.0.10",
"manifest_version": 3,
"permissions": [
  "storage"
],

Any suggestions why chrome doesnt recognize?

What problem are you running into?

The specified rights in the manifest file are not granted. You can test
this with the rights: 'storage'.

Message ID: @.***
.com>

@andrei-g-git that's an unrelated issue. Set the type of sharedManifest to Partial<chrome.runtime.ManifestBase>

@oliverkoehler I'm not able to reproduce any issue with the storage permission. How are you attempting to use the storage API?


Using newer compilers in CI

Currently, our CI only uses gcc-10 and clang-9. We maybe want to go to some newer version for checks in CI.

may probably resolve #65


Load balance to multiple Splunk instances

Agreed, or at a minimum support a basic failover for cases where there are multiple HEC endpoints but no external load balancer in front of them.


Failed to start service due to '- is not ready yet.'

I'm on
OS: Ubuntu 18.04 Desktop
tag: v1.2.0
When I tried to start service by quick-start-service.sh, it hangs on database-controller is not ready yet. Please wait for a moment! like below:
2020-10-15 00:05:45,579 [INFO] - deployment.paiLibrary.paiService.service_management_start : Begin to execute service database-controller's start script.
serviceaccount/database-controller-account created
clusterrolebinding.rbac.authorization.k8s.io/database-controller-role-binding created
statefulset.apps/database-controller-sts created
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!
database-controller is not ready yet. Please wait for a moment!

 Any help with this?

It is a bug that db controller should deployed after framework controller, but sometimes,  it doesn't.
I will give a workaround today.

@hchoi405 , here are two solutions:

use branch name zhiyuhe/cp_fix_dbc_dep in your config
wait for the v1.2.1, add install v1.2.1 directly.

Ok, thank you for the solution!


[FEATURE] Memory not logged via API.

Describe the feature you'd like
When using the API to interact with Flowise, the memory appears to not be logged automatically. It simply has no conversation history to refer to. Would be great to find a solution for that or allow history to be passed through the API.

here - https://docs.flowiseai.com/memory/short-term-memory#prediction-api


How can I validate a phone number when prefix is selected but number not, but the field is not required?

Now we apply the following check to omit the prefix, but is there a smarter way to valid it?
if (val?.length >= 5) {
      return matchIsValidTel(val);
}

Hello !
Not sure what you mean.. Please provide a codesandbox


Develop Whole Image Quality Control and Rerun Plate 5

Develop Whole Image Quality Control and Rerun Plate 5
In this PR, I add whole image quality control to filter out poor quality images and rerun only Plate 5 to generate data to use for analysis and machine learning.

@MattsonCam

It LGTM @jenna-tomkinson, good job! I left some comments. Maybe I missed this, but did you include the QC data? I didn't see it in the data folder. I'll also look more into the QC data during model training.

The QC output used for developing thresholds is included in the PR. As for QC-specific data, there is no specific data as we are removing images from being processed during IC, so the SQLite and parquet files downstream are updated to only include cells from the good-quality images.

@MattsonCam Thank you lots for the review! I will be merging now!


Replace direct usage of browserHistory with getHistory/useHistory

The desktop app is going to need to override the browser history object in the future, and, to make that easier, I thought it'd be a good idea to put it behind a getter function so that we can more easily change where it comes from. In general, we're going to want to follow a similar pattern for singletons that the desktop app needs to override.
At the same time, I also realized that there's a useHistory hook from react-router that just gives us the history object, so React components shouldn't need to import utils/browser_history directly anyway. I'd like to figure out a way to do that for outside the React scope, but that's a future thing.
Related Pull Requests
https://github.com/mattermost/mattermost-webapp/pull/11383
Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-tests

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/253500

/e2e-tests

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/254770


ComboBox issues

Discovered during extended testing:-

Dim.Fill() incorrectly calculated

Both ListView and ComboBox have Height = Dim.Fill(2)

List height not resizing

Resizing window, list does not fill Height.

SetSource() not immediately updating list.

If comboBox.SetSource (items); is called a second time after initial construction, the list does not instantly change

Double click not selecting item

Double clicking the list should be the same as hitting the enter key

@fergusonr can you confirm all of these issues are fixed in #710? If so I'll close it. Thanks!

Yes, all four named issues in this are resolved. - thanks


"Couldn't find Bluesky user" when user exists

What does it mean when Bridgy replies with "Couldn't find Bluesky user foo", while the user does exist, and the option to discourage logged-out access is not enabled?
For example: @0xa1ef.bsky.social

Sorry for the trouble! Looks like this account doesn't pass our spam filters: https://fed.brid.gy/docs#troubleshooting
We should definitely make this message more clear though! That's https://github.com/snarfed/bridgy-fed/issues/758#issuecomment-2487042651. Thanks for the nudge.

It would be useful to amend the documentation in order to cover:

what happens when a Bluesky account that is the target of a bridging request is set to receiving only messages from accounts they follows, AND they are not following the robot.
what actions are expected from the owner of the target account, if any.

Additionally, a follow-up message from the robot to the initiator of the bridging request is needed, after the bridging has been successful. Its content should cite the bridged account on the respective platform, similar to the message received when requesting the bridging of an account that's already bridged.

Agreed on all counts!

It's a duplicate of #758, correct?

Correct, specifically this one part: https://github.com/snarfed/bridgy-fed/issues/758#issuecomment-2487042651

* [rimaanabtawi.bsky.social](https://bsky.app/profile/rimaanabtawi.bsky.social)
* [ahmadelnemr.bsky.social](https://bsky.app/profile/ahmadelnemr.bsky.social)

These accounts both have the "hide account in logged out view" setting enabled, as mentioned in https://fed.brid.gy/docs#troubleshooting .

what happens when a Bluesky account that is the target of a bridging request is set to receiving messages only from accounts they follows, AND they are not following the robot.

This is #1326

Additionally, a follow-up message from the robot to the initiator of the bridging request is needed, after the bridging has been successful.

This is #1024

Great. Thanks for this great work. It's very useful.
I've also read your post about institutionalizing this, and I hope it is realized one way or the other.

what happens when a Bluesky account that is the target of a bridging request is set to receiving messages only from accounts they follows, AND they are not following the robot.

This is #1326

Friends helping me understand/debug the process reported having received/seen the robot's message after following the robot's account.
But I must say I don't understand how Bluesky messaging works, and whether there's a retry window, or whether the relevant setting is just a filter on the view.
In all cases, it would be great, in addition to the DM, to mention the case in the docs.

Bluesky has slightly strange behaviour if someone tries to DM without permission (at the protocol level): The DM is apparently still received, but just hidden from the recipient until the sender is allowed to send it.
Bridgy Fed probably sends the DM without checking for permission first, so #1326 should help with this too.


Integration with casbin

You support fields permissions, but from what I can tell, it is not on a per user basis.
https://github.com/prest/prest/blob/f646e763875ac77068e9bdc493735e7f3017530f/adapters/postgres/postgres.go#L1121-L1153
I would suggest using casbin which could support access roles on a per user basis. This would permit much more intricate policies for users.
sub := "alice" // the user that wants to access a resource.
obj := "database.table.column" // the resource that is going to be accessed.
act := "read" // the operation that the user performs on the resource.

if res := e.Enforce(sub, obj, act); res {
    // permit alice to read database.table.column
} else {
    // deny the request, show an error
}

In doing this, you could remove the whole section of your config if you like, or just make casbin calls to enforce those existing policies with Casbin.
I created a draft PR with a simple change to show roughly where changes would need to be made initially. https://github.com/prest/prest/pull/470.
My longer term goal is to support AWS API Gateway authorizers, but initially just feature parity using Casbin, then user level policies.
Thoughts? Are you interested in supporting this? If so, I'll finish the PR.

The tests for TablePermission and FieldsPermission don't seem to run normally. Can you please explain how to run them?

Using Postgres roles is probably better like https://postgrest.org/en/v3.2/admin_security.html and https://stackoverflow.com/a/19602050