Upgrade from 1.7.2 to 1.10.0 - call to wireless.createNetworkWirelessSsidIdentityPsk() not working anymore

I am making this call in one of my script:
wireless.createNetworkWirelessSsidIdentityPsk(netID,
ssidNumber,
mapping['name'],
mapping['passphrase'],
policyID)
When I use package 1.7.2 it is working fine.
With an upgrade to 1.10.0 I am getting the error message :
createNetworkWirelessSsidIdentityPsk() takes 5 positional arguments but 6 were given
Downgrading to 1.7.2 solves the issue

Hi @Philippe-Ragon, one of the params on this endpoint has changed from required to optional. While not a breaking change for the API itself, I see how using positional arguments that would have resulted in this.
Just to confirm that this is the reason for the issue, please change your arguments to keyword arguments instead, and let me know if you continue to have the problem.

Hi John,
Could you please specify which arguments have to be changed from positional to keyword ?
And could you please specify the keywords ?
Philippe Ragon
+33 611 700 152
De : John M. Kuchta @.>
Envoyé : jeudi 17 juin 2021 18:13
À : meraki/dashboard-api-python @.>
Cc : Philippe RAGON @.>; Mention @.>
Objet : Re: [meraki/dashboard-api-python] Upgrade from 1.7.2 to 1.10.0 - call to wireless.createNetworkWirelessSsidIdentityPsk() not working anymore (#158)

WARNING: This is an external email. Shall you have any doubt, report any suspicious e-mail by clicking on the "Report suspicious e-mail" button in Outlook.

Hi @Philippe-Ragonhttps://urldefense.com/v3/__https:/github.com/Philippe-Ragon__;!!Lt0KOR8!A65ZQKAIVHF3UJTERj_biw3QyccLFvPd6uvNktR6z5pOBi3df-A7Vd_xJd64W_1B0zelFkCu4hpB$, one of the params on this endpoint has changed from required to optional. While not a breaking change for the API itself, I see how using positional arguments that would have resulted in this.
Just to confirm that this is the reason for the issue, please change your arguments to keyword arguments instead, and let me know if you continue to have the problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/meraki/dashboard-api-python/issues/158*issuecomment-863374056__;Iw!!Lt0KOR8!A65ZQKAIVHF3UJTERj_biw3QyccLFvPd6uvNktR6z5pOBi3df-A7Vd_xJd64W_1B0zelFgGANQTw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AQ3ZRHZS6IK6WV7S73EN7ALTTINJ3ANCNFSM46346L6A__;!!Lt0KOR8!A65ZQKAIVHF3UJTERj_biw3QyccLFvPd6uvNktR6z5pOBi3df-A7Vd_xJd64W_1B0zelFp597BxK$.

For this test, change them all to keyword args. You would have to read the docs to see the names of the args though, that's outside the scope of an issue report.

The only doc I am aware of is the one online : https://developer.cisco.com/meraki/api-v1/#!create-network-wireless-ssid-identity-psk
It is still referring to positional parameters.
Looking at the code I found keywords for 3 parameters ==> I changed the call to the endpoint into
wireless.createNetworkWirelessSsidIdentityPsk(netID,
ssidNumber,
name=mapping['name'],
passphrase=mapping['passphrase'],
groupPolicyId=policyID)
It is working with both package v1.7.2 and v1.10.0
Philippe Ragon
+33 611 700 152
De : John M. Kuchta @.>
Envoyé : jeudi 17 juin 2021 19:18
À : meraki/dashboard-api-python @.>
Cc : Philippe RAGON @.>; Mention @.>
Objet : Re: [meraki/dashboard-api-python] Upgrade from 1.7.2 to 1.10.0 - call to wireless.createNetworkWirelessSsidIdentityPsk() not working anymore (#158)

WARNING: This is an external email. Shall you have any doubt, report any suspicious e-mail by clicking on the "Report suspicious e-mail" button in Outlook.

For this test, change them all to keyword args. You would have to read the docs to see the names of the args though, that's outside the scope of an issue report.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/meraki/dashboard-api-python/issues/158*issuecomment-863419218__;Iw!!Lt0KOR8!DdBv0ZpaWrAcmW9uQ0ER-6xwsqmfVsozXuInBwJnjGHFdWGgt-RhNbdadj7EecgvO6FAomOEvRiz$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AQ3ZRH6UYK52T5SQOA2TYMDTTIU3LANCNFSM46346L6A__;!!Lt0KOR8!DdBv0ZpaWrAcmW9uQ0ER-6xwsqmfVsozXuInBwJnjGHFdWGgt-RhNbdadj7EecgvO6FAoiXgWgPW$.

Thank you for confirming!


updated cmake (3.5.1)

point release update of cmake.
changed sha sum

Thank you for the contribution. It needed some fixes, so they were made in b1fb1a446c8432a1b23207587678e3565ad6532f. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Check default plugins BaseCache build

https://github.com/argaen/aiocache/blob/master/aiocache/cache.py#L108 should be covered by tests. I have my doubts it works

It works, the set_plugins gives the correct format

It works, the set_plugins gives the correct format


Missing regeneratorRuntime in REPL

Test case: try to run an async function in the REPL
Throws:

Uncaught ReferenceError: regeneratorRuntime is not defined

Forgot to include the polyfill in the REPL. Good catch, thanks!


Move the retry module from client-base

In the future, when we move run_forever() it might be nice to be able to pass a retry strategy to it. A good reason to move the retry module from client-base to this repo.
Originally posted by @llucax in https://github.com/frequenz-floss/frequenz-sdk-python/pull/1081#discussion_r1790352715

https://github.com/frequenz-floss/frequenz-sdk-python/pull/1081#discussion_r1790420629
ExponentialBackoff is hard to do with generic functions, because it needs to know if a previous attempt succeeded, so that it can reset its backoff interval.
This is easy to do with streams, we just reset it after every incoming message. But for functions, we'd need something like a timer to reset the backoff interval, if the function hasn't failed for a certain interval, then we say it succeeded, for example.

https://github.com/frequenz-floss/frequenz-sdk-python/pull/1081#discussion_r1791367022
Yeah, maybe we can have a strategy that actually takes into account for how long the task ran, so if last time it ran for a long time it waits very little to restart and if it failed immediately it waits quite a long time to restart 🤔


[DOC] Search Processor (new feature)

What do you want to do?

[ ] Request a change to existing documentation
[x] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Search processor is a chain of processors to take in queries preprocess the query, do information retrieval, and rerank/enhance retrieved results.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
markcoh is the SDM, SDE is froh@ and Stavros is the PM
This was targeted for 2.6, but may go experimental in 2.6 and GA in 2.7
Associated issue: https://github.com/opensearch-project/search-processor/issues/80

Hi @kolchfa-aws , you are listed on the project scorecard as the Doc lead, so please confirm you will be working on this. As noted above, this may not be ready for 2.6 and may go out in 2.7. Labeling as 2.6 just in case.

@hdhalter Yes, I will be working on this. It's currently scheduled for 2.7.

Looks like this has been bumped out to 2.8. I'll update the label and milestone.


Always allow spell combat causes charge not to do an attack

Description of the bug
On my magus character, if I have the "Always allow spell combat" cheat turned on and use charge with a 2 handed weapon or 1h weapon (didn't try dualwield)  in turn based mode, I do not get an attack at the end of the charge. In RTWP it seems to work fine, or at least I do get an attack that gets +2 attack from charge. This is all on the latest version 1.5.18. Rolling back to 1.5.17 fixes the issue, so I think it has something to do with the change to the cheat in 1.5.18.
Steps To Reproduce

Turn on Always Allow Spell Combat.
Execute a charge in turn based mode.

Expected Behavior
No response
Log Files
No response
Save File
Manual_161_ToyboxSaveSubmit.zip
The only mods enabled are Respec Mod and Toybox.
Screenshots
No response
Settings
No response
Toybox Version
1.5.18
Operating System
No response
What game are you using Toybox on?
Pathfinder Wrath of the Righteous
Game Version
No response
Anything else?
No response

I tried it with both an elven curved blade and a dagger. Neither got an
attack off with the charge ability in turn based. Spell combat itself works
fine.
On Thu, Jun 20, 2024, 06:47 xADDBx @.***> wrote:

Wait, so in Turn Based when you only wield one weapon, you don't get a
second attack after using a spell?
—
Reply to this email directly, view it on GitHub
https://github.com/xADDBx/ToyBox-Wrath/issues/5#issuecomment-2180476870,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ3NVBYYXVSGBNEWJ55WYJLZIK6NHAVCNFSM6AAAAABJS2KZXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGQ3TMOBXGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[chore] remove helper images and examples

remove helper images and bevel example reference application

delete the examples folder
update the docs to point to bevel-samples for examples
delete nms, doorman and linuxkit images

Moving this PR to draft, needs additional changes


Add criterion

absence of which prevents compiling.

Thanks for the patch though i don't maintain this anymore. For a modern IRC server check out https://github.com/ergochat/ergo they are good.

I actually was seeking to practice Rust, and you have well-sized todos
at Sourcehut. Unfortunately I know nothing about Go.
Btw, did you consider to delist the crate from <Crates.IO>? So that
somebody won't pull it unmaintained...
On 2023-08-04 19:38, Hubert Hirtz wrote:

Thanks for the patch though i don't maintain this anymore. For a modern
IRC server check out https://github.com/ergochat/ergo they are good.
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you authored the thread.Message ID:
@.***>

Links:
[1] https://github.com/hhirtz/ellidri/pull/7#issuecomment-1665964841
[2]
https://github.com/notifications/unsubscribe-auth/APXLOTYOBIB2GATLQNTR36LXTUXRBANCNFSM6AAAAAA3EORXI4


The Shenyu-Bootstrap already started

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When you use the ./start.sh command to start the admin successfully, and then use the ./start.sh command to start bootstrap, it will prompt: The ShenYu-Bootstarp already started! PID: xxxx

Expected Behavior
Need to successfully start ShenYu-Bootstrap

Steps To Reproduce
1.cd apache-shenyu-incubating-2.4.2-bootstrap-bin/bin
2.Modify the start.sh file
3.Change PIDS=ps -ef | grep "$DEPLOY_DIR" | grep -v grep | pgrep -f java to PIDS=ps -ef | grep "$DEPLOY_DIR" | grep -v grep
4.Successfully saved after modification
5.Reuse the ./start.sh command to start bootstarp

Environment
ShenYu version(s):2.4.2-tar

Debug logs
bootstrap started successfully

Anything else?
If you are referring to Chinese documentation, you need to pay attention to:
When the admin starts, it will prompt: java.sql.SQLException: No suitable driver found for jdbc:mysql...
You need to copy your local mysql-connector.jar to the ext-lib directory or the lib directory
hope this helps! Of course, ignore that exaggerated title. have a good day.

https://github.com/apache/incubator-shenyu/pull/2859


Feature - EKS - Option to manage security groups outside of Rancher (e.g. when wrapped with Terraform)

What kind of request is this (question/bug/enhancement/feature request):
Feature - EKS - Option to manage security groups outside of Rancher (e.g. when wrapped with Terraform)
Steps to reproduce (least amount of steps as possible):
Create appropriate SGs outside of Rancher
Result:
SUCCESS: Cluster succeeds in using externally managed SGs
FAIL: Cluster does not provision
Other details that may be helpful:
https://github.com/terraform-providers/terraform-provider-rancher2/pull/185/files#diff-8ff886122dea219642c3089e474409a0R23
https://github.com/terraform-providers/terraform-provider-rancher2/pull/185/files#diff-8ff886122dea219642c3089e474409a0R26
https://github.com/rancher/kontainer-engine/pull/200/files#diff-193f5e744cfdca5a8b1c37da968623f3R161

@dstockton Can you give more details on what this means? How are these security groups managed outside of Rancher? or where are they being created?

If your organisation wants to manage their own security groups - through any method other than hidden away in rancher- then you can set this flag and rancher will not create or alter the SGs, it will only attach the SGs passed in.

The “where are they being managed” answer is up to the user. In our organisations case, it’s via terraform code

OK, cool, so if I have my SGs created outside of Rancher through some other process, these security groups will be applied unmodified to the cluster?
Would it address: #22910

Yes - sorry, I’ve opened a duplicate issue (but the PR/code resolves it)


Cluster behaves unstable(etcd and kubelet-related issues)

Issue Report Template
Tectonic Version
1.7.5-tectonic.1
Environment
Baremetal. The etcd-cluster is deployed automatically with the Tectonic installer WEB-GUI.
Expected Behavior
The cluster should work.
Actual Behavior
Hangs up once a couple of days. Reboots or systemctl restart etcd-member help for some time.
Reproduction Steps

Installed with the Tectonic installer WEB-GUI
Deployed some users' manifests

Other Information
The alert-manager shows alerts like:  [FIRING:1] K8SApiserverDown (critical), the cluster becomes slow or stops working. The journalctl -f says:
Nov 24 13:38:28 node1.ololo.com etcd-wrapper[1627]: 2017-11-24 13:38:28.466859 W | rafthttp: health check for peer dd9ac7553c520ac2 could not connect: dial tcp: lookup node3.ololo.com on [::1]:53: read udp [::1]:46900->[::1]:53: read: connection refused
The further restarts help for some time.
I was trying to tune the etcd timeouts and snapshot intervals, doesn't help much.

@megastallman There isn't much advice I can offer without logs from the cluster but one possibility is that the controller nodes are not sufficient for running both the control plane and etcd. You might want to review the hardware requirements.
https://coreos.com/etcd/docs/latest/op-guide/hardware.html
https://support.coreos.com/hc/en-us/articles/115004021914

Thanks @kbrwn!
As for my hardware, those are 4 Dell PowerEdge R430 servers, with 64(8*8) cores each, 320GB ram, 10GBit/s and 1700GB of RAID10 HDD. They should be sufficient enough to keep that load.


Enable firestore environments?

"Second" App Instance
We could leave this up to the user to create a "Second App" and pass it in as an instance of Firestore. This doesn't require a lot of work on our end, which could mean that it doesn't really get used.
Suffix|Prefix Params
We could offer params to create a suffix or prefix depending on the environment. This could be a simple set up that wouldn't require a whole lot of set up on the dev's side
This could be a plausible solution for Staging environments so that the DBs can be reviewed
Set up Emulator
I don't have enough experience to have an opinion on this. I just know that it exists. Any thoughts on possibly automating this process for the dev?
This would really only be used as the dev environment?

Moved to its own package: https://github.com/SupposedlySam/firefuel/tree/main/packages/firefuel_env


pass the standalone request arg in the /caravel/slices/<slice_id>/ endpoint redirect

Gave some context in slack, but this will be useful for us to auto-generate standalone viz's from a slice's id. This endpoint currently re-directs to a slice's url, but ignores all arguments passed to it.
@mistercrunch

Coverage decreased (-0.1%) to 81.379% when pulling dae508e951457fa40243f9f7cb6e4d3dd7753ad4 on chris/support-standalone-arg-in-slice-id-endpoint into aaef338539eff4ff855e0f87bcb17ca71440e251 on master.

Coverage decreased (-0.1%) to 81.379% when pulling 6808aed3a6ef916e80c252feb39a1d79455cb093 on chris/support-standalone-arg-in-slice-id-endpoint into aaef338539eff4ff855e0f87bcb17ca71440e251 on master.

how can I fix the coveralls blocker? :(

@mistercrunch I tried messing with the assertRedirects but wasted a ton of time trying to get the flask_testing.TestCase to work. This is the current best standard for how you're testing redirects so I went with it for now.
Also updated the 'false' vs False logic.

Coverage increased (+0.1%) to 81.57% when pulling 77f2593920a68c1f062674d3844d07053053b7e4 on chris/support-standalone-arg-in-slice-id-endpoint into b48101ca51da8bd07608ccdbd9912efb2000cd0b on master.

Nice!


scroll bars with RDK

See #787

Hey @becky-gilbert I didn't check, but does this absolute positioning mean that the canvas element is always in the top left? Does that change the centering behavior of the stimulus at all?

@jodeleeuw I initially had the same concern about this solution. But in the plugin code, the canvas element is set up to have the same width and height as window.innerWidth and window.innerHeight, which is why scroll bars appear when the canvas has any margin/padding and is positioned anywhere except for (0,0). The dots are centered within the canvas, so they end up being centered in the window as well. I've tested this solution on browsers and window sizes and it works - the stimulus is centered and there are no scroll bars.
However, this does mean that the stimulus doesn't remain centered if the browser is resized after the page loads - if the window gets bigger then the stim will be appear more toward the upper left, and if the window gets smaller then it'll be more toward the bottom/right, and scroll bars will appear. I'm happy to try finding a responsive solution. I don't know if it's possible to responsively resize the canvas itself, but that seems problematic anyway. Another option might be to use a fixed canvas size that's smaller than the typical window, and center the canvas responsively. But I haven't looked at the plugin code closely enough to know if that might cause other problems. Maybe @vrsivananda has some thoughts/suggestions?

Hi @becky-gilbert, many apologies for the delayed response.
Yes, you're right that the canvas size is fixed when the RDK trial begins, and as such it does not re-center when the window resizes. I made it this way as it was intended to not be resized mid-trial. May I know why you might want to resize it mid-trial? There might be another way around the problem, depending on your needs. I can try to help more if I had more context.
If it was for subsequent trials (e.g. resize the window during the instructions, then run the RDK trials after the window has been resized), then this thread might help.

Thanks @vrsivananda! You're right, resizing the browser window after the trial begins isn't really a problem. The bigger issue was removing the scroll bars that appear, and I think that's been resolved now.
The other issue that I wanted to ask about is that the RDK stimulus does not seem to center in the same way as other jsPsych stimuli, but it looks like that's the same issue that's discussed in the thread that you linked to, so thanks for pointing me to that. In the discussion forum question #1122, someone is asking how to center an RDK stimulus relative to an image that's presented separately (the image and RDK stim are overlaid in the post, but that's just to illustrate their relative positioning). This person hasn't found a solution that works across different screen sizes. Please feel free to comment on that discussion thread if you have any suggestions!


Puppeteer triggers captcha always and I can  never complete it..

  puppeteer.launch({executablePath: "C:/Users/DDM/AppData/Local/Google/Chrome/Application/chrome.exe", headless: false, slowMo:10, ignoreDefaultArgs: ['--enable-automation'], args: ["--proxy-server=http://" + proxy]}).then(async browser => {
  const page = await browser.newPage()

These are my launch options, any site I try with captcha, it does not work. Tried Chromium and Chrome.

Perhaps it might be helpful if you shared the site you are encountering that is presenting you with the captcha, and of what variety captcha it is. I'm happy to help but I'm also not sure what the rules are for issues, I suspect they don't encompass these kinds of problems (captcha can't be solved).

Perhaps it might be helpful if you shared the site you are encountering that is presenting you with the captcha, and of what variety captcha it is. I'm happy to help but I'm also not sure what the rules are for issues, I suspect they don't encompass these kinds of problems (captcha can't be solved).

Any site that has captcha (recaptcha v2). captcha like this https://patrickhlauke.github.io/recaptcha/

It just says that i'm using a bot.

Take a look at my repo: puppeteer-theater. Look specifically inside the classes/puppeteer-bot-2a.js file. Just chill it is a lot of code but I want to point out the functions you are looking for.
Search for disguisePage and feel free to copy it I guess, though you are going to run into problems if you can't understand at least the gist of what's going on here to disguise the bot. This function takes a page, browserContext, and some basic properties so it can be easily extracted from this class file.
Next, for solving captchas: Search for resolveCaptcha & resolveAntiCaptchaTask. Pull these out and implement them as you need. If you haven't realized yet, to get around this you will also need a captcha solving provider. I recommend AntiCaptcha. Find the docs here: https://anti-captcha.com/apidoc/image.
You should want something like  const { gRecaptchaResponse } = await resolveCaptchaTask({       type: 'NoCaptchaTaskProxyless',       websiteURL: page.url(),       websiteKey,     });
gRecaptchaResponse here is the solution you need to set to document.querySelector('#g-recaptcha-response').value & document.querySelector('#g-recaptcha-response').innerText.

To clarify the above:
Step (1): Implement antidetection in your code so you are less likely to even see a captcha.
Step (2): Add functions to handle solving captchas if you do see them.

To clarify the above:
Step (1): Implement antidetection in your code so you are less likely to even see a captcha.
Step (2): Add functions to handle solving captchas if you do see them.

Thank you.

Take a look at my repo: puppeteer-theater. Look specifically inside the classes/puppeteer-bot-2a.js file. Just chill it is a lot of code but I want to point out the functions you are looking for.
Search for disguisePage and feel free to copy it I guess, though you are going to run into problems if you can't understand at least the gist of what's going on here to disguise the bot. This function takes a page, browserContext, and some basic properties so it can be easily extracted from this class file.
Next, for solving captchas: Search for resolveCaptcha & resolveAntiCaptchaTask. Pull these out and implement them as you need. If you haven't realized yet, to get around this you will also need a captcha solving provider. I recommend AntiCaptcha. Find the docs here: https://anti-captcha.com/apidoc/image.
You should want something like  const { gRecaptchaResponse } = await resolveCaptchaTask({ type: 'NoCaptchaTaskProxyless', websiteURL: page.url(), websiteKey, });
gRecaptchaResponse here is the solution you need to set to document.querySelector('#g-recaptcha-response').value & document.querySelector('#g-recaptcha-response').innerText.

@nicoandmee is puppeteer-theater repo still available, or a recommended alternative? :) Thanks!!!

I've seem these two soluctions, but both envolve 2captch which is paid:
https://github.com/berstend/puppeteer-extra/tree/c5828dd01333b6dbb15d74e63d9b866b2b2ff2a6/packages/puppeteer-extra-plugin-recaptcha
https://medium.com/@jsoverson/bypassing-captchas-with-headless-chrome-93f294518337

@geekbleek https://github.com/dcubasoy/puppeteer-theater/blob/master/classes/puppeteer-bot-2a.js it is a link.


Handle invalid empty command inputs

Reject empty inputs for:

Meta key
Group display name
Permission

Additionally, reject invalid group names in lp group .. delete.
Behaviour was also expanded to and documented in API NodeBuilders.

Oh whoops, the translatable won't work well with the text literal argument

The problem with the translation is resolved, I simply added a new entry for each message, this is already done for other entries as well, and I don't think there are enough differences to really worry about separating them into their own translatable arguments, so I deemed this solution the least complex.
The issue with allowing spaces in inheritance nodes needs to be discussed further.


Make it more clear there are prebuilt disk images in the readme

From the current instructions it appears as though you need a lot of skills to install Chromium OS on a RP, however it looks like prebuilt images are available in the 'releases' tab, it would be really helpful if there was a note at the top of the readme that made this more clear
Thanks very much for working on this

Accepted, thank you.


Update pom.xml

Connected to #1063

Rejecting in favour of #1065 as the solution should be conditional.


Add a conda workflow to build the environment and run the tests

Summary of changes (Bug fix, feature, docs update, ...)

Add a conda workflow to build the environment and run the tests.

Please check if the PR fulfills these requirements

[x] Closes #594

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1e37978) 33.90% compared to head (17fc077) 33.90%.
Report is 4 commits behind head on devel.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #843   +/-   ##
=======================================
  Coverage   33.90%   33.90%
=======================================
  Files         180      180
  Lines       14149    14149
=======================================
  Hits         4797     4797
  Misses       9352     9352

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OK this is working properly now.

Looks more clean and easier to understand. Just one query from a CI/CD perspective: In terms of shell, you have written micromamba-shell {0} Is there a way to include it in the below section? Or don't want it to be used as the default? defaults: run: shell: bash -el {0}

That's due to the way shell environments are handled by GitHub actions.


Need more details on opting out of HTTPS after project upgrade

Just upgraded old project to latest ASP.NET core and now it fails to start complaining about being unable to configure HTTPS endpoint (which it shouldn't have being doing in the first place - project never used HTTPS) and it is unclear how do I opt out.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c7ddfb2f-5dea-5e31-2a27-02a4dc16104c
Version Independent ID: 12ca0b9a-2638-a4ce-c45f-d4579c83dafb
Content: Enforce HTTPS in ASP.NET Core
Content Source: aspnetcore/security/enforcing-ssl.md
Product: asp.net-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Why would you want to opt out?  The document is not about optioning out of HTTPS.
What is the error message?
You can build a new project without HTTPS
dotnet new webapp --no-https -au Individual

Why would you want to opt out?

I don't even know what to say... Because I don't want HTTPS on my web site? Because I don't like when framework decides for me when it is time to start using it?
The error message went away after installing the .net core SDK 2.1 (logical, right?), but it started with "Unable to configure HTTPS endpoint" and suggested to run dotnet dev-certs <something> (which failed when I tried it, and I don't remember how).
I am yet to deploy it to the actual hosting location, so maybe it'll reproduce there.
I don't want a new web app. I was upgrading existing asp.net core 2.0 project to asp.net core 2.1. HTTPS was never mentioned anywhere neither in code nor in configuration, yet it failed to start attempting to configure it (or at least complaining about its inability to configure it) after the upgrade.
As far as I can see, new project with HTTPS differs from the one without only by having additional
        app.UseHsts();
        app.UseHttpsRedirection();

lines in Startup.cs. My project had neither of those and yet I saw the HTTPS related error...

In my hosting environment it didn't reproduce and I see in logs that Kestrel does not try to listen for https, but on my dev box it does:
Now listening on: https://localhost:5001
Now listening on: http://localhost:5000

I don't see any place where it is configured and I have no idea how it picks a certificate to use for HTTPS.
On my hosting I have an nginx in front of Kestrel, so if I ever decide to use HTTPS it will be terminated there and I never would need to have HTTPS enabled in a Kestrel.

You can build a new project without HTTPS
dotnet new webapp --no-https -au Individual
And see how that opts-out of HTTPS.

I also config https at load lalancer, so I don't want enable https in my project.
Is there any way to close https to asp .net core 2.1.1 envirnment?

@agr I find a way to close https.
Just add "applicationUrl": "http://*:PORT" in launchSettings.json file.
Like this:
{
  "profiles": {
    "Your_Proj_Name": {
      "commandName": "Project",
	  "applicationUrl": "http://*:5000"
    }
  }
}

I have also found that if the sslPort is set to anything other than zero in the following section of the launchSettings.json file, kestrel will still attempt to bind an SSL port during debug sessions:
  "iisSettings": {
    "windowsAuthentication": false,
    "anonymousAuthentication": true,
    "iisExpress": {
      "applicationUrl": "http://localhost:52901",
      "sslPort": 0
    }
  }

Yes, that's right, kestrel is using the iisExpress section of this file to pick up some of its config.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


I can't get my fan speed control to work

The LED light dim function works but I can't control the speed of my fan. Also I don't get any air quality info.
I have a 2889/10 with Shanghai wifi chip and my Homebridge is running on Windows 10 x64. I had to copy the python.exe to python3.exe to make it work.
When I start homebridge:
[7-11-2020 01:30:01] [Philips Air] [Philips 2889/10] Initializing accessory...
Exception in thread Thread-1:
Traceback (most recent call last):
File "C:\Python39\lib\threading.py", line 950, in _bootstrap_inner
self.run()
File "C:\Python39\lib\threading.py", line 888, in run
self._target(*self._args, **self._kwargs)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 273, in receive_datagram
self._send_ack(transaction)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 307, in _send_ack
self.send_datagram(ack)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 170, in send_datagram
if self._receiver_thread is None or not self._receiver_thread.isAlive():
AttributeError: 'Thread' object has no attribute 'isAlive'
[7-11-2020 01:30:29] [Philips Air] [Philips 2889/10] Initializing accessory...
Exception in thread Thread-1:
Traceback (most recent call last):
File "C:\Python39\lib\threading.py", line 950, in _bootstrap_inner
self.run()
File "C:\Python39\lib\threading.py", line 888, in run
self._target(*self._args, **self._kwargs)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 273, in receive_datagram
self._send_ack(transaction)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 307, in _send_ack
self.send_datagram(ack)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 170, in send_datagram
if self._receiver_thread is None or not self._receiver_thread.isAlive():
AttributeError: 'Thread' object has no attribute 'isAlive'
[7-11-2020 01:30:29] [SWL-HUB] DidFinishLaunching
[7-11-2020 01:30:29] [SWL-HUB] (SWL-HUB)INFO - Loading activities...
[7-11-2020 01:30:29] [Philips Air] [Philips 2889/10] Unable to load firmware info: TypeError: Cannot read property 'replace' of undefined
Exception in thread Thread-1:
Traceback (most recent call last):
File "C:\Python39\lib\threading.py", line 950, in _bootstrap_inner
self.run()
File "C:\Python39\lib\threading.py", line 888, in run
self._target(*self._args, **self._kwargs)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 273, in receive_datagram
self._send_ack(transaction)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 307, in _send_ack
self.send_datagram(ack)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 170, in send_datagram
if self._receiver_thread is None or not self._receiver_thread.isAlive():
AttributeError: 'Thread' object has no attribute 'isAlive'
Exception in thread Thread-1:
Traceback (most recent call last):
File "C:\Python39\lib\threading.py", line 950, in _bootstrap_inner
self.run()
File "C:\Python39\lib\threading.py", line 888, in run
self._target(*self._args, **self._kwargs)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 273, in receive_datagram
self._send_ack(transaction)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 307, in _send_ack
self.send_datagram(ack)
File "C:\Python39\lib\site-packages\coapthon\client\coap.py", line 170, in send_datagram
if self._receiver_thread is None or not self._receiver_thread.isAlive():
AttributeError: 'Thread' object has no attribute 'isAlive'
When I try to read status:
C:\Windows\System32>airctrl --ipaddr <IP_ADDRESS>
Exchanging secret key with the device ...
Traceback (most recent call last):
File "c:\python39\lib\urllib\request.py", line 1342, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
File "c:\python39\lib\http\client.py", line 1255, in request
self._send_request(method, url, body, headers, encode_chunked)
File "c:\python39\lib\http\client.py", line 1301, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "c:\python39\lib\http\client.py", line 1250, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "c:\python39\lib\http\client.py", line 1010, in _send_output
self.send(msg)
File "c:\python39\lib\http\client.py", line 950, in send
self.connect()
File "c:\python39\lib\http\client.py", line 921, in connect
self.sock = self._create_connection(
File "c:\python39\lib\socket.py", line 843, in create_connection
raise err
File "c:\python39\lib\socket.py", line 831, in create_connection
sock.connect(sa)
ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\python39\lib\runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "c:\python39\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "C:\Python39\Scripts\airctrl.exe_main.py", line 7, in
File "c:\python39\lib\site-packages\pyairctrl\airctrl.py", line 444, in main
c = HTTPAirCli(device["ip"])
File "c:\python39\lib\site-packages\pyairctrl\airctrl.py", line 100, in init
self._client = HTTPAirClient(host, debug)
File "c:\python39\lib\site-packages\pyairctrl\http_client.py", line 108, in init
self.load_key()
File "c:\python39\lib\site-packages\pyairctrl\http_client.py", line 156, in load_key
self._get_key()
File "c:\python39\lib\site-packages\pyairctrl\http_client.py", line 119, in _get_key
with urllib.request.urlopen(req) as response:
File "c:\python39\lib\urllib\request.py", line 214, in urlopen
return opener.open(url, data, timeout)
File "c:\python39\lib\urllib\request.py", line 517, in open
response = self._open(req, data)
File "c:\python39\lib\urllib\request.py", line 534, in _open
result = self._call_chain(self.handle_open, protocol, protocol +
File "c:\python39\lib\urllib\request.py", line 494, in _call_chain
result = func(*args)
File "c:\python39\lib\urllib\request.py", line 1371, in http_open
return self.do_open(http.client.HTTPConnection, req)
File "c:\python39\lib\urllib\request.py", line 1345, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [WinError 10061] No connection could be made because the target machine actively refused it>
When I try to set protocol CoAP:
C:\Windows\System32>airctrl --ipaddr <IP_ADDRESS> --protocol coap
Unexpected error:'Thread' object has no attribute 'isAlive'
Exception in thread Thread-1:
Traceback (most recent call last):
File "c:\python39\lib\threading.py", line 950, in _bootstrap_inner
self.run()
File "c:\python39\lib\threading.py", line 888, in run
self._target(*self._args, **self._kwargs)
File "c:\python39\lib\site-packages\coapthon\client\coap.py", line 273, in receive_datagram
self._send_ack(transaction)
File "c:\python39\lib\site-packages\coapthon\client\coap.py", line 307, in _send_ack
self.send_datagram(ack)
File "c:\python39\lib\site-packages\coapthon\client\coap.py", line 170, in send_datagram
if self._receiver_thread is None or not self._receiver_thread.isAlive():
AttributeError: 'Thread' object has no attribute 'isAlive'

I think I've found the issue: akunzai commented on 8 Oct
seems threading.Thread 's method isAlive() was renamed to is_alive() since Python 3.9.0
see micheles/decorator#75

It's working!


Possible fix for readable being spent in functions

@mfellner thanks for tracking down the problem and the inspiration, I think we have a solution here.


fix(utils): fix cli name typo devlab -> lab

See title.

This is actually a bit of a question right now, see #46

Might be a question for future releases, but the current message is wrong.   If a user executes it as instructed, they will get an error.
The current CLI should be merged now and if the CLI name changes in the future, then update this name as well.
FWIW, I ran into this error once as well as Kyle.


安装报错

ERROR: Could not find a version that satisfies the requirement onnxruntime==1.15.0 (from versions: 1.17.0, 1.17.1, 1.17.3, 1.18.0, 1.18.1, 1.19.0)
ERROR: No matching distribution found for onnxruntime==1.15.0

The project is mainly tested on python3.10, other versions of python may encounter situations where dependencies cannot be found.
Consider optimizing this in the future. :)


Deletion displays as completed in UI, but does not complete in ACK

rancher/rancher:master 02/14
It's the similar issue with https://github.com/rancher/kontainer-engine/pull/112
We need to fix it in Aliyun Hosted k8s

@gitlawr Please validate it

Verified in master 02/20


[2.5] Update default ui-dashboard-index setting

Ensure dashboard served up is latest 2.5, rather than fixed 2.5.8

@gaktive or @richard-cox , is there an issue that this can be linked to? I'm only seeing the PR. QA was looking for the original issue for testing purposes.

@MKlimuszka This was first raised by QA. Gary has now created https://github.com/rancher/dashboard/issues/4860.


Update the WHC SWIO Flasher app for the SDK version 0.99 f7

Hello!
Your WHC SWIO Flasher app version 1.0 fails to build with the SDK version 0.99.0-rc f7. Please update the app in your repository and create a new pull request to the catalog repository with the updated manifest file.

IMPORTANT: Don’t forget to update the app version and commit version in the manifest file.

View logs
Flipper Team

Fixed in 00c66bb914a640ca789b05874680d56d4a1fc388


Write atomwise PDB file for both forward and reverse geometry proposals

This adds writing of atomwise multi-model PDB files for both forward and reverse proposals.

Oh, sorry, I must have missed this. Do you want to merge this? Or is there still some work to be done here?

I think it's useful for debugging and illustration purposes, provided the changes I made don't interfere with the actual algorithm.  Perhaps we can add a writeProposalPDB flag to the geometry engine and have this off by default?  If that make sense, I'll add that and then you can merge this if everything looks good.

I agree that it's useful. Your plan sounds good--just checking to see if anything else needed to be done.

OK, I've made this PDB sequential atom placement writing optional. Should be good to review and merge.

Merging this.


Allow to configure alternate mirrors

It would be nice if we could point the crate to alternate mirrors rather than having https://bitcoincore.org/ hard-coded.
Main motivation is that we in LDK recently started seeing CI failures that seem to come from Github CI being unable to connect to  https://bitcoincore.org/:
error: failed to run custom build command for `bitcoind v0.28.1`

Caused by:
  process didn't exit successfully: `/home/runner/work/rust-lightning/rust-lightning/target/debug/build/bitcoind-db625c734508c201/build-script-build` (exit status: 101)
  --- stdout
  filename:bitcoin-23.0-x86_64-linux-gnu.tar.gz version:23.0 hash:2cca490c1f2842884a3c5b0606f179f9f937177da4eadd628e3f7fd7e25d26d0
  url:https://bitcoincore.org/bin/bitcoin-core-23.0/bitcoin-23.0-x86_64-linux-gnu.tar.gz

  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Transport(Transport { kind: Io, message: None, url: Some(Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("bitcoincore.org")), port: None, path: "/bin/bitcoin-core-23.0/bitcoin-23.0-x86_64-linux-gnu.tar.gz", query: None, fragment: None }), source: Some(Custom { kind: TimedOut, error: "timed out reading response" }) })', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoind-0.28.1/build.rs:106:43

If these issues continue to appear we'd be interested in exploring hosting our own mirror to make the bitcoind/electrsd based tests more robust.

Make sense to allow to override the download endpoint from an env var.
PR welcome, or I'll do it sometime whoever arrives first :)


NodeJS: LazyConnect options on create client

Describe the feature
Currently when a Redis instance is created, a connection to Redis server is established at the same time.
This means that the application cannot start if Redis is not available. However, if the application loses the connection, an automatic reconnection is attempted. It should with lazy connect, create Glide Client even if Redis isn't available.
The lazy connect feature allows you to connect only when you make your first request (and retry after in cases of failures).
Use Case
In the context of horizontal scaling, Redis may not respond. This does not mean that the application has to be killed. Connecting at startup makes the application dependent on Redis.
We could create a mechanism on the application side, but I think that's the driver's responsibility.
Proposed Solution
I think the solution provided by IORedis https://github.com/redis/ioredis is the best way. RedisClient.createClient should not throw when LazyConnect is enabled.
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Client version used
0.4.0
Environment details (OS name and version, etc.)
Ubuntu 22.04.2 LTS - Node v20.11.1

Hi @Ealenn,
Sounds like an interesting feature, and as always, you are more than welcome to try to implement and contribute this feature.
Since it is a fairly easy to implement on the user side (Create the client when you want to send your first command and/or add error handling when trying to connect), and we have a massive amount of big feature that we want to implement before, for example client side caching or routing in runtime to the node we know will give us the fastest response (mix of measuring regions and availability zones for the distance, and measuring load on each node for latency) I believe it will take us time to provide the feature suggested here.
But as always, we appreciate any suggestion for improvement, and this feature will get on our roadmap, and we will be even more happy if the community will grow and we'll more contributor will join the effort, so if you'd like to work on it, we will really welcome you, and i can help you get started with the project :)
Anyhow, as said, it is getting on our roadmap, and we really appreciate your suggestion and improvement idea :)


ResetOnReporting for counters in Prometheus does nothing

This may be a duplicate, but currently I am struggling with issue described in heading.
There are some custom Counters (example below) which should be reset after reporting to Prometheus (format in plain text, endpoint is /metrics-text). However even after multiple calls these Counters do not reset.
Package version is latest stable, 3.1.0
Can anyone give any advise here?
Metric definition:
public static CounterOptions MyMetric => new CounterOptions
{
    Name = $"My metric name",
    MeasurementUnit = Unit.Calls,
    ResetOnReporting = true
};

Config:
public static IServiceCollection AddMetrics(this IServiceCollection services, IConfiguration configuration)
{
    var metrics = AppMetrics.CreateDefaultBuilder()
        .OutputMetrics.AsJson()
        .OutputMetrics.AsPrometheusPlainText()
        .Build();

    services.AddMetrics(metrics);
    services.AddMetricsReportingHostedService();

    services.AddMetricsTrackingMiddleware(t =>
    {
        t.ApdexTrackingEnabled = false;
        t.OAuth2TrackingEnabled = true;
    });

    services.AddMetricsEndpoints(options =>
    {
        options.MetricsTextEndpointOutputFormatter = new MetricsPrometheusTextOutputFormatter();
    });

    services.AddSingleton<HealthCheck, DatabaseHealthCheck>();

    AppMetricsHealth.CreateDefaultBuilder()
        .OutputHealth.AsPlainText()
        .HealthChecks.RegisterFromAssembly(services)
        .Report.ToMetrics(metrics)
        .BuildAndAddTo(services);

    services.AddHealthEndpoints(options =>
    {
        options.HealthEndpointOutputFormatter = new HealthStatusTextOutputFormatter();
    });
    services.AddHealthReportingHostedService();

    return services;
}

public static IApplicationBuilder ConfigureMetrics(this IApplicationBuilder app)
{
    return app.UseMetricsAllMiddleware()
        .UseMetricsEndpoint()
        .UseMetricsTextEndpoint()
        .UseHealthEndpoint();
}

Faced the same thing. I assume it works this way because there is no reporting as such. There is a metric output formatted for Prometheus.
It would be too good if metrics were reset when Prometheus scrapes metrics endpoint.


Update ggml.c/h to the version used in llama.cpp

Seems like Kerfuffle already did this in #119 ?

Apologies for the work double-up, but #119 seems to include everything from this PR


GroundItems notification sound getting louder

Every ground item causes the notification sound to get louder and louder.
This loop should only trigger the sound effect once instead of once per iteration.
https://github.com/cabbagegod/cabbagescape/blob/ae4329ecf42e0c8a1f365f0c63b49f2c46589f0d/src/main/java/com/cabbagegod/cabbagescape/client/grounditems/GroundItemsManager.java#L73-L93
Sound location:
https://github.com/cabbagegod/cabbagescape/blob/ae4329ecf42e0c8a1f365f0c63b49f2c46589f0d/src/main/java/com/cabbagegod/cabbagescape/client/grounditems/GroundItemsManager.java#L104

Resolved in commit 5ac0aed14154c10bc7cf2648766d42da090b2405


Discriminator classification loss flat even when it is training

Something up with the new reporting method?

It was an issue with reporting. Fixed


XD-3118 Adding CONTAINER_PROCESSES property to run multiple xd-contai…

…ners on one host

updated the logs to use separate file for each container, also to overwrite existing file for the startup log plus changed variable names to be less confusing


Feature request: read namespace from environment variable for brig

If Brigade is deployed into a namespace other than default, from that point on, every brig command will have to be executed using the flag --namespace <brigade-namespace>.
Now most commands will fail in an obvious way because of the wrong namespace (such as brig dashboard, which doesn't find a Kashti pod and errors out) - but others will fail in a more subtle way - for example, creating a new project with brig without passing the namespace will create the project secret in the default namespace, which means any build for that project will not fire, because there is no secret for the project in your <brigade-namespace> namespace - and no logs will point you to why nothing is happening.
The easiest fix would be to set a default <brigade-namespace> for brig (that would then be used by other tools as well - for example brigadeterm, which needs the same flag if the namespace is different) - the obvious option would be to have an environment variable - BRIGADE_NAMESPACE, that if set, will change the globalNamespace variable across brig, so eliminating the need to pass the flag with each command.
In the case of multiple deployments of Brigade in the same cluster, in multiple namespaces, the flag will always take precedence (and the environment variable for the command can be passed before the command, or for the terminal session), thus not affecting this scenario.
Thoughts?

100% agree with the env proposal, seems to be the most elegant solution.
Apart from that, you also raise another interesting issue: I think that we would need a separate fix for brig project create so that it checks for the existence of Brigade controller before it creates the Secrets. WDYT?


[Clippy] Code maintenance

🤖 This is an automatic PR 🤖
Clippy suggests the following changes

Codecov Report
Base: 86.61% // Head: 86.57% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (bdfa14a) compared to base (a8c1563).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   86.61%   86.57%   -0.05%
==========================================
  Files          17       17
  Lines         986      983       -3
==========================================
- Hits          854      851       -3
  Misses        132      132

Impacted Files
Coverage Δ

src/deepzoom.rs
98.14% <ø> (-0.03%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


M3-6067: Linode Create - API/CLI Copy Changes

Description 📝

Updates new API/CLI modal with new copy on the Linode Create Flow
To verify copy check the internal ticket

Preview 📷

How to test 🧪

Check copy and links in the modal on the Linode Create Flow
To verify copy check the internal ticket

Merging the PR after discussing with @bnussman


[Bug] Support multiple same-level node types and improve items/array support

Description
Some schemas can implement more than one node type at the same level, such as oneOf and properties, or any other combination. This change introduces changes to how createNodes processes schemas. Previously, there was an ordered precedent applied whereby we exited after the first match. With these changes, now all node types will be collected in an array and returned together, in the order they were processed.

Note: also includes improvements to how items/arrays are rendered

Motivation and Context
Addresses issue observed in the following endpoint, whereby only the oneOf schema/node was processed and the properties were ignored: https://pan.dev/access/api/prisma-access-config/post-sse-config-v-1-address-groups/
How Has This Been Tested?
Tested with the Prisma Access Config address-group spec referenced above. Can be found here: https://raw.githubusercontent.com/PaloAltoNetworks/pan.dev/master/openapi-specs/access/prisma-access-config/AddressGroups.yaml
Additional testing is required to ensure no regression bugs are introduced.

Example of how arrays are now rendered in the UI:

Example of schema with allOf (that also includes an anyOf) and properties combined:

Note the array of "object"


301 dispute resolution

PULL REQUEST CHECK LIST

If you have new .env variable, check if you add it in the .env.example file
Check if you have some prettier issues
Complete the README file with correct data if needed
if any changes have been made in contract, please update the abis

On the proposal creation modal, add a info block to explain what is dispute and how it works


Update Gradle to 8.9 and AGP to 8.5.2

What does this PR do?
Since we are now using Kotlin 1.9, we can also update Gradle and AGP to the newer versions (which were bringing Kotlin 1.9 to the classpath).
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.99%. Comparing base (6d2cf93) to head (c07bc24).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2192      +/-   ##
===========================================
- Coverage    70.02%   69.99%   -0.02%
===========================================
  Files          726      726
  Lines        27004    26968      -36
  Branches      4526     4522       -4
===========================================
- Hits         18907    18876      -31
+ Misses        6827     6826       -1
+ Partials      1270     1266       -4

Files
Coverage Δ

...compat/widget/DatadogActionBarContainerAccessor.kt
100.00% <100.00%> (ø)

...ternal/recorder/mapper/ActionBarContainerMapper.kt
90.48% <ø> (ø)

...main/java/com/datadog/exec/CommonTaskExecutor.java
47.83% <100.00%> (ø)

... and 26 files with indirect coverage changes


Add reindexing to actions of the ILM

Is your feature request related to a problem? Please describe.
We would like to create a copy of a current long lasting index every night. The ILM supports a bunch of operations but not the reindexing option.
Describe the solution you'd like
Add reindex to ILM operations
Describe alternatives you've considered
Scripting it ourselfs as a timed job, but this would be cleaner.
Additional context

Track in https://github.com/opensearch-project/index-management/projects/1#card-71473393

Could I be assigned to this issue? Thanks!


Fix/fog pass

Puts fog in the right stack and removes physical_sky from the pass shaders menu,
This closes #38

@sjannuz could you merge this when you get a chance?

Sorry for the delay.


Upgrading NSwag to the latest version (v14.0.3) broke C# client generation for arrays/lists with nullable primitive types

Hello all!
Issue description:
I've just upgraded my NSwag libraries & client to the latest version v14.0.3 (from v13.19.0):

NSwag.AspNetCore 14.0.3,
NSwag.CodeGeneration.CSharp 14.0.3,
NSwag.Generation.WebApi 14.0.3,
NJsonSchema 11.0.0,
Newtonsoft.Json 13.0.3.

My C# dto class:
  public class TestClass
  {
      public IEnumerable<decimal?> Values { get; set; } = Enumerable.Empty<decimal?>();
  }

Before the upgrade, generated code looked like:
  [System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))")]
  public partial class GeneratedTestClass
  {
      [Newtonsoft.Json.JsonProperty("values", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
      public System.Collections.Generic.ICollection<decimal?> Values { get; set; }
  }

which is fine. As we can see in the output file our list is of type ICollection<decimal?>, exactly as expected.
But, after the upgrate to the versions listed at the top of this issue, generated code looks like that:
    [System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))")]
    public partial class GeneratedTestClass
    {
        [Newtonsoft.Json.JsonProperty("values", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
        public System.Collections.Generic.ICollection<decimal> Values { get; set; }
    }

As you can see, there is a discrepancy between what we have as our base class and the output from the generated class. We want to have nullable decimals in output list but NSwag generated ICollection<decimal> instead of ICollection<decimal?>. I haven't change anything but the libraries' versions. nswag.json and all the configuration stuff remained untouched.
Am I correct that this is misbehaving? Looks like a bug to me. I'm expecting that generated class will keep the underlying nullable primitive types?
I would highly appreciate every answer!

Looks good to me:

it works in the latest version


help needed: use pdf preview and regions selection in spring boot project with thymeleaf

I'm trying to liberate the PDF-preview page and region selection from this project. Since I want to embed it in a project that does not use spark and very limited ajax/jquery.
therefore I would like to know if someone can help me with this, or has done this in the past.

Hi @iWhacko,
The region selection is a Javascript component, so it should be possible to extract it from this or the official Tabula web app with a bit of effort.
PDF preview is implemented with PDFBox rendering.


Fix for event_system_properties description

This PR provides additional details for the event_system_properties description

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

kusto


Should  CloudEvent.Data property  be lowercase?

Describe the proposal
Use [JsonPropertyName ("data")]
https://github.com/dapr/dotnet-sdk/blob/56017dd94ad860911beba4b6d15081d9f4d6aae8/src/Dapr.Client/CloudEvent.cs#L60

@saber-wang - Has this caused any problems for you? If it did, it feels like something that would've come up before. Making a change to the serialization/naming conventions though would probably be considered a breaking change, so we need to be careful with what we do here.

@halspang Recently processed the serializer inside the project, and the case is not processed during serialization,so...
At present, other attributes are all lowercase, and the 'CloudEvent' protocol is also lowercase, so this problem exists.

Had the same issue, found out that I incorrectly configured daprClient with default JsonSerializerOptions() while it should be JsonSerializerOptions(JsonSerializerDefaults.Web).
JsonSerializerDefaults.Web sets naming policy to CamelCase and case insensitive naming policy.


New exercise Elyses Enchantments

Note there are some issues with solution
https://github.com/abaplint/abaplint/issues/2452
Preferred solutions left as commented code
https://github.com/exercism/abap/blob/01e4a550a534c584d97bed802287be56aeab6dff/exercises/practice/elyses-enchantments/.meta/zcl_elyses_enchantments.clas.abap#L63-L73

@pokrakam try updating to your preferred solution, downport logic has been extended in abaplint

Thanks, unfortunately both variants still don't work.
Using option 1:
./downport/zcl_elyses_enchantments.clas.abap[73, 5] - "<temp1>" not found, FSTarget (check_syntax) [E]
Option 2 results in a test failure:
  actual: String { value: '7 ' },
  expected: String { value: '7' }

I think there may be an issue with string handling?
Shall I push my exercism-test?

Created https://github.com/larshp/exercism-test/pull/3

@pokrakam example from https://github.com/larshp/exercism-test/pull/3 now fixed

I'll merge this in a bit, when https://github.com/exercism/abap-test-runner/commit/6ddc4d55cd33dabaf721bbb3d8934781740f416b has updated the docker image

I could revert to plan b, which is good enough to merge.
There's still a downport bug preventing plan a.
Original:
  METHOD set_item.

    result = stack.
    result[ position ] = replacement.

Downport:
  METHOD set_item.
    FIELD-SYMBOLS <temp2> LIKE LINE OF result.

    result = stack.

    READ TABLE result INDEX position ASSIGNING <temp1>.
    IF sy-subrc <> 0.
      RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
    ENDIF.
    <temp2> = replacement.

Which results in transpiler (rightfully) complaining about temp1 and temp2
./downport/zcl_elyses_enchantments.clas.abap[72, 5] - "<temp1>" not found, FSTarget (check_syntax) [E]

hmm, whats the exact code to reproduce the issue?

nevermind, its hardcoded to temp1,

@pokrakam try again

Works, thanks! PR ready.

yay, merging


Create Go Docker images based on CBL-Mariner

Upstream doesn't have these images. We could create/maintain them if it is useful.
.NET example: https://github.com/dotnet/dotnet-docker/blob/main/src/runtime/5.0/cbl-mariner1.0/amd64/Dockerfile

Completed. (Cleaning up old issue.) Our image publishes this way:

Unpack our signed, checksum-verified build of Go into the container and publish that as our image.


Mica (and other) does not work

Windows 11 build 22523. Interface language: Russian (I don't know how in other languages)

It's ok if you don't use ExtendFrameIntoClientArea. It doesn't look good on all apps and it's not my fault, but I added a config file and you can use it to set config for each app.


chore: go-demo-6 to 1.0.338

chore: Promote go-demo-6 to version 1.0.338

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Geomasked processing

Support for limiting the processing area to an EWKT polygon.
Removed sub-tile flipping prior to NetCDF storage.

While the build passes now, there are some build-time warnings left.
Deprecated usage of OGRGeometryFactory::createFromWkt().
implicitly-declared ‘constexpr Vector<int>::Vector(const Vector<int>&)’ is deprecated
implicitly-declared ‘constexpr Vector<float>::Vector(const Vector<float>&)’ is deprecated


Dropdown Menu Underlapping Grouping Header

Broken by #726. Maybe just need to set a new z-index context to the content view.

Closed by #732


fix: Fixed Bug29566 spec with list widget

Description
Root Cause Analysis (RCA):
The test case in BugTests/Bug29566_Spec.ts has become flaky due to its dependency on a third-party API call (https://api.jsonbin.io/v3/b/). As experienced automation engineers, we understand that relying on third-party services can introduce instability and lead to frequent test failures. In this particular case, the dependency was tightly coupled with the test logic, and updating the data was not a viable solution.
Solution:
Upon assessing the situation, I determined that refactoring the existing test would take significantly longer than rewriting it from scratch. Therefore, I chose the rewriting approach to prioritize time efficiency. The test flow has been updated while maintaining the same assertions for data validation. Additionally, I have incorporated an extra assertion to verify the data after a page reload to further enhance the robustness of the test.
Fixes #36259
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

/ci-test-limit-count run_count=20


Minor documentation update

Added more clarify around common plugin usage scenarios, I think it helps to understand plugin purpose more quickly since the name of the plugin itself may be confusing - "Secure storage" might imply that it's appropriate for storing lots of data securely, when really it is intended for storing secret strings.

Updated some links to point to the latest/official docs.

Thanks :)

This was very fast :) thank you!

I also added you to the contributors in the package.json reference fyi.


Unable to access controller directory

I am unable to open the controller directory. It says "No such file or directory". I tried running it using your VM too. I have installed the git clone file outside the vm and tried to install it inside the vm as well, but I could not get it to work.

I bro i tried to contact you linkedin and github and medium you are not responding please give a reply right to understand our problem we are undergraduates we need to submit the projects please make note helping other make a real man  sorry for saying please respond yar

Did he reply you or

No
On Sat, 6 Apr 2024 at 1:36 PM, cynthia-nohuje @.***>
wrote:

Did he reply you or
—
Reply to this email directly, view it on GitHub
https://github.com/chiragbiradar/DDoS-Attack-Detection-and-Mitigation/issues/17#issuecomment-2041011182,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGUDFOC7245D2MVQNATNSLDY36UGXAVCNFSM6AAAAABEPRZCGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGAYTCMJYGI
.
You are receiving this because you authored the thread.Message ID:
<chiragbiradar/DDoS-Attack-Detection-and-Mitigation/issues/17/2041011182@
github.com>

Where you able to solve the problem
On Sat, Apr 6, 2024, 10:23 Kishansaisaguturusa @.***>
wrote:

No
On Sat, 6 Apr 2024 at 1:36 PM, cynthia-nohuje @.***>
wrote:

Did he reply you or
—
Reply to this email directly, view it on GitHub
<
https://github.com/chiragbiradar/DDoS-Attack-Detection-and-Mitigation/issues/17#issuecomment-2041011182>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/BGUDFOC7245D2MVQNATNSLDY36UGXAVCNFSM6AAAAABEPRZCGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGAYTCMJYGI>

.
You are receiving this because you authored the thread.Message ID:
<chiragbiradar/DDoS-Attack-Detection-and-Mitigation/issues/17/2041011182@
github.com>

—
Reply to this email directly, view it on GitHub
https://github.com/chiragbiradar/DDoS-Attack-Detection-and-Mitigation/issues/17#issuecomment-2041015073,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3774JUCTS6VT53XTD7P4ODY36WH7AVCNFSM6AAAAABEPRZCGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGAYTKMBXGM
.
You are receiving this because you commented.Message ID:
<chiragbiradar/DDoS-Attack-Detection-and-Mitigation/issues/17/2041015073@
github.com>


Added few ebooks

What does this PR do?

Added Essential Algorithms
Added Production Go
Added JavaScript Wikibook
Added Laravel Tips and Tricks
Updated The Modern Javascript Tutorial to use HTTPS
Added Essential SQL
Added TypeScript Handbook

For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

sometimes it's better to link to the web version which links to a pdf. sometimes this is especially true of wikibooks because sometimes they take a lot of time to generate.
Your comments on other PRs have been very helpful.

Updated the link to the wikibook also so the user directly lands into the HTML webpage, where he can navigate to the PDF version and printable version.

you can the 'changes made' label to make sure I notice that a PR has changes to check


[Spike] EKS - Research on Kubernetes Network Policies

Is your feature request related to a problem? Please describe.
We don't have any information about EKS network policies but we want to have knowledge about this prior to implementation of EKS Network Policies feature.
Describe the solution you'd like
We want to have some design doc that shows how to use Network Policies in EKS and configure them as close as it possible to the solution that is available on AKS on Azure and on prem deployments.
Describe alternatives you've considered
None.
Additional context
We want only to consider Network Plugins and Policies that are supported by the cloud providers.

I've put estimates to '2', if you disagree, please change it.

No longer valid


Custom NodeComponent - overriding inputs/outputs

I've upgraded from 0.2.2 to 0.3.0. In 0.2.2, I was able to define a custom NodeComponent as follows:
@Component({
  selector: 'app-question-response-node',
  templateUrl: './question-response-node.component.html',
  styleUrls: ['../node.component.scss'],
  providers: [NodeService],
})
export class QuestionResponseNodeComponent extends NodeComponent {
  override inputs: MessageInput[];
  override outputs: ResponseOutput[];

  constructor(service: NodeService, cdr: ChangeDetectorRef) {
    super(service, cdr);
  }
}

Both MessageInput and ResponseOutput extend from rete's Input and Output respectively. They provide additional properties that are accessed in the QuestionResponseNodeComponent template. For example, in question-response-node.component.html:

  <rete-socket rete-socket [io]="input" [socket]="input.socket"></rete-socket>

{{ message }}

However, inputs and outputs on NodeComponent are now getters instead of class properties.
How can I go about overriding the inputs and outputs for a custom NodeComponent?

I've upgraded from 0.2.2 to 0.3.0
the only significant difference between these  versions is enableIvy: false. Probably this is a reason. Anyway, you can copy https://github.com/retejs/angular-render-plugin/blob/c3e874885a45fd6f1e5fd6e4b34df27b7b0c30f0/src/node/node.component.ts instead of extending.

Also, I would recommend switching to the v2 if you want more possibilities in the customization of the editor

Thanks for the prompt response and for suggesting to use NodeComponent directly. My issue with the Maximum call stack size exceeded was a silly mistake with how I was overriding the getters:
override get inputs(): MessageInput[] {
  return this.inputs;
}

changing this to use the same in NodeComponent with a typecast resolved this issue:
override get inputs(): MessageInput[] {
  return Array.from(this.node.inputs.values()) as MessageInput[];
}

I'm experiencing a different issue now with the connections not being displayed in the editor (they're rendered in the DOM, but not displaying in the editor), but this issue can be closed.


chore: release 1.1.35

:robot: I have created a release *beep* *boop*
1.1.35 (2024-05-13)
Bug Fixes

update docs (f893e60)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v1.1.35 :sunflower:


[Error While Compiling] Missing go.sum for X, Y, Z after installing the library

I installed the library as documented
go get github.com/eko/gocache/v3
then I installed the in-memory store
go get github.com/patrickmn/go-cache
And I have a code without any syntax error like this
package main

import (
	"context"
	"fmt"
	"github.com/eko/gocache/v3/cache"
	"github.com/eko/gocache/v3/store"
	gocache "github.com/patrickmn/go-cache"
	"time"
)

func main() {
	cacheManager, _ := createCache()
	err := cacheManager.Set(context.Background(), "my-key", []byte("my-value"))
	if err != nil {
		panic(err)
	}

	value, err := cacheManager.Get(context.Background(), "my-key")
	if err != nil {
		panic(err)
	}
	fmt.Printf("%s", value)

}

func createCache() (*cache.Cache[[]byte], error) {
	gocacheClient := gocache.New(5*time.Minute, 10*time.Minute)
	gocacheStore := store.NewGoCache(gocacheClient)
	cacheManager := cache.New[[]byte](gocacheStore)

	return cacheManager, nil
}

When trying to compile I get error as below (yes I tried also go mod tidy and did not help)
../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/store/pegasus.go:10:2: missing go.sum entry for module providing package github.com/XiaoMi/pegasus-go-client/admin (imported by github.com/eko/gocache/v3/store); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/store/pegasus.go:11:2: missing go.sum entry for module providing package github.com/XiaoMi/pegasus-go-client/pegasus (imported by github.com/eko/gocache/v3/store); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/store/memcache.go:12:2: missing go.sum entry for module providing package github.com/bradfitz/gomemcache/memcache (imported by github.com/eko/gocache/v3/store); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/store/redis.go:8:2: missing go.sum entry for module providing package github.com/go-redis/redis/v8 (imported by github.com/eko/gocache/v3/store); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/gin-gonic/gin@v1.6.3/binding/protobuf.go:11:2: missing go.sum entry for module providing package github.com/golang/protobuf/proto (imported by github.com/gin-gonic/gin/binding); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/metrics/prometheus.go:5:2: missing go.sum entry for module providing package github.com/prometheus/client_golang/prometheus (imported by github.com/eko/gocache/v3/metrics); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/metrics/prometheus.go:6:2: missing go.sum entry for module providing package github.com/prometheus/client_golang/prometheus/promauto (imported by github.com/eko/gocache/v3/metrics); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/store/pegasus.go:12:2: missing go.sum entry for module providing package github.com/spf13/cast (imported by github.com/eko/gocache/v3/store); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/store/options_test_matchers.go:7:2: missing go.sum entry for module providing package golang.org/x/exp/slices (imported by github.com/eko/gocache/v3/store); to add:
        go get<EMAIL_ADDRESS>../../../go/pkg/mod/github.com/eko/gocache/v3@v3.1.1/store/memcache.go:10:2: missing go.sum entry for module providing package golang.org/x/sync/errgroup (imported by github.com/eko/gocache/v3/store); to add:
        go get<EMAIL_ADDRESS>make: *** [build] Error 1

Hello, the pegasus store is now in a separated Go module so this should be fixed in case you only use the Gocache library (by importing github.com/eko/gocache/v4/lib).
I close this issue for now but feel free to reopen if you still have any issue with this new v4.0.0 release.


add delay to milking

Done. Need to be verified in terms of numbers and balance. Currently 30 seconds


Add React 17 support

This library (though officially not maintained) works fine in React 17
The reasoning for this is because NPM v7 installs peerDependencies by default. The only way to get around the conflict when using this library and React 17 is to append --legacy-peer-deps

@tannerlinsley would you be able to publish this? Or is that risky (Last publish to npm was pre-covid Nov 2019!)


Disabled / read-only state

Hi,
is there any way to achieve a read-only or disabled state? I would assume that read-only state would just work as normal, but not update the value when the new option is chosen. And I'm not sure whether disabled state should fit into this library, as this could be just a collapsed input with no actions and no dropdown icon and maybe an additional styling

Hello!
PR

Cool! I'm currently using AbsorbPointer and hiding closedSuffixIcon to achieve this effect

Hey @karniv00l
Enabled/disabled feature now available in the latest release 3.1.0.
Thanks to @KabaDH for the contribution. Really appreciate you guys are taking interest in my package!


Submenu in a menu bar does not work.

Hi, I'd like to use submenus in a menu bar but so far I can't make it work.
I use below code to check the issue. Could you please take a look at it?
#include <nana/gui.hpp>
#include <nana/gui/widgets/menubar.hpp>

int main()
{
	using namespace nana;

	form fm(API::make_center(500, 300));
	fm.caption(L"submenu test");

	menubar mb(fm);
	mb.push_back(L"&File");
	mb.push_back(L"&View");

	auto& menu_view = mb.at(1);
	menu_view.append(L"Test 0");
	menu_view.append(L"Test 1");
	menu_view.create_sub_menu(1)->append(L"aa");

	// from http://nanapro.org/en-us/help/widgets/menu.htm
	menu mobj;
	mobj.append(STR("Item 0"));
	mobj.append(STR("Item 1"));
		mobj.create_sub_menu(1)->append(STR("A sub menu item"));
	mobj.renderer(mobj.renderer());
	mobj.item_pixels(30);

	fm.events().click(menu_popuper(mobj));

	fm.show();
	exec();
}

Thank you for reporting this issue, it also causes a crash error. When the submenu is popped up, move the cursor to the "Item 0", the submenu is being closed, at the same time, the program crashs.
A fix has been checked into the hotfix branch.

Thank you for the fix. I confirmed that a submenu in a menubar works now.
Other subtle issues I noticed are as follows.

Left clicking a submenu item in a menu does not immediately open its submenu.
Behavior of opening a submenu by cursor keys is weird now.

Pressing left key opens a submenu but pressing right key does not open a submenu.

Right clicking a menu works but should it work?

Hi, a fix for the menu bahavioral issues has checked into the hotfix branch. Look forward to your feedback.

Thank you for the fix.
I confirmed that three subtle issues (in my prev post) are fixed now.


PTX-1208  move torpedo to use sdk

this PR moves all API osd calls to use the sdk instead

Let's have your private job running on this with all stable tests.

initial test https://jenkins.portworx.co/job/Torpedo/job/tp-dev-test/206 passing without DecommissionNode

This is a lot of refactoring. We should run this for one of our torpedo jenkins jobs for a couple of days to make sure that these changes don't regress.


Add a new tutorial and package

Added a new tutorial on using Hooks with forms, and a new React dialog component called modali that's built from the ground up using Hooks.

Cool!


Tanking tests

PR for adding support for tanking tests. Some things remain.

Stuff that needs checking and some thought:

What if test is fixed horizon, but tanking tests are sequential?
What if there is no preferred direction? Should be just nans, but need to verify


Predeploy RoleBinding before unmanaged pods

RoleBindings should be deployed before unmanaged pods. This matters when RoleBindings define Pod Security Policies. This might prevent unmanaged pods from starting unless RoleBinding has been set up and the deployment fails.
For normal deployments only scenario it already works. Even if there is a race condition, it works as the pods retry.
Should there be a separate resource type? Other similar resource types seemed to have also the corresponding class defined.

Rebased. I used Docker for Mac for testing from #356, which almost worked as it didn't see to like context name "docker-for-desktop" rather than "docker-for-mac". Didn't realise that it also changed the constant name.


Add BenchmarkCI support

This (hopefully) adds support for running the benchmarks defined in benchmark/benchmarks.jl at every commit, using BenchmarkCI.jl.
It is set up to compare against the latest master branch.

I'm really excited to see this. I wonder if you also noticed that the benchmark results appear 3 times. Is that just 3 different machines running them or is there some duplication going on?

Codecov Report

Merging #361 into master will increase coverage by 1.47%.
The diff coverage is 85.65%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   84.03%   85.51%   +1.47%
==========================================
  Files          36       36
  Lines        3063     3148      +85
==========================================
+ Hits         2574     2692     +118
+ Misses        489      456      -33

Impacted Files
Coverage Δ

src/qn/qnindex.jl
64.83% <0.00%> (-1.47%)
:arrow_down:

src/qn/qnitensor.jl
55.31% <38.70%> (-31.17%)
:arrow_down:

src/index.jl
76.00% <60.00%> (-1.56%)
:arrow_down:

src/broadcast.jl
64.10% <66.66%> (+47.97%)
:arrow_up:

src/indexset.jl
74.27% <66.66%> (+0.74%)
:arrow_up:

src/itensor.jl
75.17% <72.00%> (-2.69%)
:arrow_down:

src/mps/mps.jl
95.72% <88.63%> (-2.51%)
:arrow_down:

src/decomp.jl
95.26% <94.44%> (+0.49%)
:arrow_up:

src/mps/abstractmps.jl
96.31% <96.00%> (+2.70%)
:arrow_up:

src/mps/mpo.jl
97.82% <98.52%> (-0.27%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0514445...33111ee. Read the comment docs.

Looks like it worked!
I only see two results, the "Target result" (this PR) and the "Baseline result" (the master branch). The comparison is shown in the "Results" category, but the table is empty since there were no significant speedups or regressions.

Ah ok yes I somehow counted 3 as I was scrolling up and down but now I see there's just the two and what they are. I was confused also as to why they were the same but I see it's just because things are only getting started and from now on we'll be seeing differences.
This is really great to have and to be an automated thing.

At some point we should remove Travis from the CI settings, since Github Actions is running a good bit quicker most of the time. I guess it's still there mainly for Documenter?

I think this will be really useful going forward, I'll merge this.
Yeah, right now Travis is building the documentation, but I agree we should get rid of it. There's a guide to build the documentation with Github actions, so we can just use that for everything.


Bump ads-extension-telemetry to 1.3.4

Adding small fix to ensure error isn't thrown on startup if invalid values are passed to the telemetry reporter. Not something we've ever hit (AFAIK) but good to have just in case.
I won't plan on doing releases of all of the extensions touched by this PR since it's a pretty low-impact issue. I will be updating most of the ones touched in this PR though (which includes a subset of the ones here) : https://github.com/microsoft/azuredatastudio/pull/21754

admin-tool-ext-win
datavirtualization
import (@aasimkhan30 )

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 42.007%

Files with Coverage Reduction
New Missed Lines
%

extensions/machine-learning/src/common/processService.ts
3
77.78%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
28635

Relevant Lines:
63296

💛  - Coveralls


fix(rules): handle anonymous class

Fix #422

@mgechev , travis complains because of linting error :

ERROR: test/noAttributeParameterDecoratorRule.spec.ts[17, 12]: Missing semicolon

@wKoza that's for the catch. Should be fine now.


Passing an object value to req.flash()

I’m interested in expanding connect-flash to allow passing objects to it. Ideally, I’m looking to do this:
// controller.js

// some other logic happens, then…

// this generates error messages indexed by field name:
var errors = req.validationErrors(true)

if (errors) {
  req.flash('errors', 'Your submission is invalid. See errors below.')
  req.flash(req.validationErrors(true))
  return res.redirect('back')
}

This way, it would be trivial to check for messages.fieldName from my templates like so:
//- template.jade

//- other fields and markup

label(for='fieldName') Field Name:
input(name='fieldName' id='fieldName' class=(messages.fieldName ? 'error' : ''))
if messages.fieldName
  label(for='fieldName').error #{messages.fieldName.msg}

Specifically, I’d like to expand on req.flash() to accept a non-Array object as the second argument or the only argument. Behavior could be as follows:

req.flash('type', object) — Only the object would be registered at req.session.flash.type (i.e. not an array with the passed object as its first item). If an object had already been registered for that type, it would be expanded with the current object’s properties (read: not entirely replaced). If a non-object had already been registered for that type (i.e. req.flash('type', 'A message') followed by req.flash('type', object)), then we would respect the existing array and simply push to it, resulting in req.session.flash.type being equal to [ 'A message', object ].
req.flash(object) — Each key/value pair at the root of the provided object is handled as if it was req.flash(key, value), following existing conventions as well as the new conventions I described above.

I don’t think this would break existing functionality (please correct me if I’m wrong) and it would make more granular error reporting to the user easier to implement.
Is this a contribution you would be interested in, or would you rather it live as a separate project?

This should be implemented as a separate project.  The goal of connect-flash is to mimic the functionality in Express 2.x, and nothing else.

Got it. Thanks!

Hey @agarzola, did you make any progress with this?

@loweoj I think I handled this need some other way last year. That said, if this is something you want to take on yourself, I'd be happy to contribute either with code or testing/reviewing/both.

How I handled mine, the object passed to req.flash can be accessed as the zeroth index
req.flash('old', {me: 'Josh'})  var old = req.flash('old')[0]  res.send(old.me)