Enable C&U worker roles by default

Turn on the three C&U metrics worker roles by default.

Wanted to open this up for discussion, cc @Fryguy

:+1: from me (it was my idea LOL)  cc @chessbyte @bdunne @jrafanie @kbrock would like your opinions
Now that our appliance is at 16GB, I don't see why we wouldn't do this.  It is clunky as it is to enable it, where most users would expect it by default, and it can always be disabled later.  Most users turn it on anyway, so having it off by default doesn't make sense.
My only concern with this specific PR is that the user still need to turn on the region level cluster config thing.  Can we also turn that on by default?

My only concern with this specific PR is that the user still need to turn on the region level cluster config thing. Can we also turn that on by default?

That's a bigger issue, this is currently enabled via tagging so we can't just "turn it on by default" without a data migration to invert the tags (we'd have to apply a disable tag to anything which doesn't currently have an enabled tag)

I see...I still think merging this is progress towards better UX than currently

The only "easy" way to make the region level setting a non-issue would be to add CloudManager::Vm to https://github.com/ManageIQ/manageiq/blob/master/app/models/metric/ci_mixin/targets.rb#L2-L16 since it already is kind of awkward to enable cluster/datastore for cloud

Yeah, we can discuss the approach to changing that #21511.  I'm not sure about adding Cloud VM there because someone may have already intentionally disabled it and we'd be bypassing that.

I agree this is expected.
My concern is the resources necessary to run C&U.
It sure hits the provider with a lot of queries and pushes our own CPU pretty hard.

🤷🏻♂ If we get a lot of complaints about it, we can always turn it back off. :shipit:

ok. that is 3 👍🏽  -- @jrafanie you ok?

Also want @chessbyte's input

Let's merge this and see what the user experience is.  I definitely don't want to backport this to Najdorf, as I want to give this new setting time with the community.

🤷🏻♂ If we get a lot of complaints about it, we can always turn it back off. :shipit:

Agreed.  I always say, if @Fryguy disagrees, you'll get his opinion after you merge it. 🤣   I think this translates well to user or tester expectations as well.  We'll never know if it's better or worse until we do it.

Agreed. I always say, if @Fryguy disagrees, you'll get his opinion after you merge it.

Damn straight 🤣


The desktop zoom is not maintained between changes of preview modes (mobile/desktop)

The problem seems to be that switching back an forth between mobile/desktop preview modifies the zoom level.

@saleiva: I can't reproduce this issue now. Can you check again, please?

going to

Magic!

:dancer:


Tests fail in off-line environment

When I run the tests in a system without an access to the Internet, most of the tests fail:
$ prove -l
t/00.use.t ........ ok
t/chain.t ......... 3/?
#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::Object::Domain''
#   at t/chain.t line 18.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::Object::Domain'

#   Failed test 'undef isa 'Net::RDAP::Object::Entity''
#   at t/chain.t line 22.
#     undef isn't defined
Can't call method "parent" on an undefined value at t/chain.t line 24.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 4.
t/chain.t ......... Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/4 subtests
t/document_url.t .. 3/?
#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::Object::Domain''
#   at t/document_url.t line 17.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::Object::Domain'
Can't locate object method "nameservers" via package "Net::RDAP::Error" at t/document_url.t line 29.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 4.
t/document_url.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/4 subtests
t/jcard.t ......... ok
t/objects.t ....... 1/?
#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::Object::Domain''
#   at t/objects.t line 33.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::Object::Domain'

#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::Object::Domain''
#   at t/objects.t line 33.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::Object::Domain'

#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::Object::IPNetwork''
#   at t/objects.t line 33.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::Object::IPNetwork'

#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::Object::IPNetwork''
#   at t/objects.t line 33.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::Object::IPNetwork'

#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::Object::Autnum''
#   at t/objects.t line 33.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::Object::Autnum'

#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::Object::Autnum''
#   at t/objects.t line 33.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::Object::Autnum'
Can't locate object method "zoneSigned" via package "Net::RDAP::Error" at t/objects.t line 97.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 101 just after 24.
t/objects.t ....... Dubious, test returned 101 (wstat 25856, 0x6500)
Failed 6/24 subtests
t/redaction.t ..... ok
t/search.t ........ 1/?
#   Failed test 'An object of class 'Net::RDAP::Error' isa 'Net::RDAP::SearchResult''
#   at t/search.t line 21.
#     The object of class 'Net::RDAP::Error' isn't a 'Net::RDAP::SearchResult'
Can't locate object method "nameservers" via package "Net::RDAP::Error" at t/search.t line 23.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 3.
t/search.t ........ Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/3 subtests

Test Summary Report
-------------------
t/chain.t       (Wstat: 65280 (exited 255) Tests: 4 Failed: 2)
  Failed tests:  3-4
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/document_url.t (Wstat: 65280 (exited 255) Tests: 4 Failed: 1)
  Failed test:  3
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/objects.t     (Wstat: 25856 (exited 101) Tests: 24 Failed: 6)
  Failed tests:  3, 6, 9, 12, 15, 18
  Non-zero exit status: 101
  Parse errors: No plan found in TAP output
t/search.t      (Wstat: 65280 (exited 255) Tests: 3 Failed: 1)
  Failed test:  3
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output

It would be great to skip the tests if a TCP connection to the RDAP servers cannot be established. Or you can use LWP::Online for detecting such environment. Or skip/run the tests only if an option is passed to Makefile.PL. Or move the test to ./xt directory.
In general, tests should not depend on on-line resources. It's bad for reproducibility and it abuses servers exampled in the tests. Also many software distributors build and test software in off-line environment intentionally and they will have to patch them.

Or the best, but the most laborious, solution is to reimplement the RDAP server for the sake of the tests. One can use e.g. HTTP::Daemon.

Thanks for reporting this, I've added LWP::Online to the tests that require an internet connection. I agree that implementing a server would be the best option; something for a future version!
I will tag a 0.33 release and upload to CPAN shortly.


Integration with Thales enterprise key management

Adding new KMS (Thales), support added from UI, ceph-csi, rook and noobaa.
Signed-off-by: sanjalkatiyar<EMAIL_ADDRESS>

@GowthamShanmugam @umangachapagain PTAL.


Passing plain identifier inside HPX_DEFINE_PLAIN_ACTION_1

HPX_DEFINE_PLAIN_ACTION_1and HPX_DEFINE_PLAIN_DIRECT_ACTION_1 pass plain "name" as an identifier for action name, which may cause class redefinition.
It might be reasonable to pass BOOST_PP_CAT(func, _action) like it's done for HPX_PLAIN_ACTION or just to remove these macros.

Introduced by https://github.com/STEllAR-GROUP/hpx/commit/eb93bb0de108a07da6c656090d91a2428ea8e556

Tis was fixed by 2bdf6a58fa4c10d404663f47aafd2f523808a52f

That commit looks like a functional change. Does it require documentation changes to follow? What about announcing the breakage on the mailing list? Where are the basic unit tests to catch this kind of bug?
This kind of change should have gone through a pull request.

@K-ballo I don't think it's functional, because it doesn't break usage of macro and any existing code. Documentation defines it exactly as it is now. Sorry for committing directly to master.

Whether the change breaks out-of-tree builds depends only on what's documented. The current documentation for HPX_DEFINE_PLAIN_ACTION depicts it as a variadic macro. It looks suspiciously underdocumented. Do we want it to diverge from HPX_PLAIN_ACTION and HPX_REGISTER_ACTION? Do we want it to diverge from HPX_DEFINE_COMPONENT_ACTION?

k

@K-ballo you're probably right, we should leave it as an variadic macro and try to implement the one argument version analogously to the existing macros. Let's move this to a PR as well.

A proper fix has been added to the branch fixing_1550.

Fixed by merging #1553


401 Unauthorized error in e2e tests

/kind bug
What steps did you take and what happened:
 when make API call

  client = k8s_client.ApiClient()
  crd_api = k8s_client.CustomObjectsApi(client)
  return crd_api.get_namespaced_custom_object(
    GROUP, VERSION, namespace, PLURAL, name)

Every 15 mins, the attached token has to be refreshed otherwise 401 Unauthorized.
E.g, check prow build logs (Not Argo Workflow) and you can see every 15mins, 401 Unauthorized error surfaces, http://prow.kubeflow-testing.com/view/s3/aws-kubeflow-jenkins/pr-logs/pull/kubeflow_kfserving/1315/kubeflow-kfserving-presubmit/1357497548171907072
The way that we handle it is add retry logic to refresh the API call.
https://github.com/kubeflow/testing/blob/master/py/kubeflow/testing/argo_client.py#L87-L105

**What did you expect to happen:**

**Anything else you would like to add:**
[Miscellaneous information that will assist in solving the issue.]

**Environment:**

- Istio Version:
- Knative Version:
- KFServing Version:
- Kubeflow version:
- Kfdef:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
- Minikube version:
- Kubernetes version: (use `kubectl version`):
- OS (e.g. from `/etc/os-release`):

https://github.com/kubernetes-client/python-base/issues/125

fixed by recreating the KFServing client every time.


Invalid Code

Hi,
just updated to the latest version but now I can't enter the settings menu.
The floating icon for the settings asks me a code, I enter the default one (1234) but it always says "code is invalid, please try again"
I've already uninstalled and did a fresh install but the issue remains.
Thanks

Try with the updated release, I just published it.

Thanks, it's fixed on version v0.9.4-beta.2.


Update appveyor.yml

Hi guibranco,
just trying to fix issue #8, please check it out

:x: Build locaweb-servidores-sdk-dotnet 1.0.25 failed (commit https://github.com/guibranco/locaweb-servidores-sdk-dotnet/commit/7b8ccf7d37 by @viktoriussuwandi)

Hi @guibranco,
How about this PR ?
Should it close without merge, or anything need to add/improve ?

@viktoriussuwandi I am updating the files, just wait. I tracked all Prs that you submitted, just wait, no need to push a comment on every single one.

:white_check_mark: Build locaweb-servidores-sdk-dotnet 1.0.31 completed (commit https://github.com/guibranco/locaweb-servidores-sdk-dotnet/commit/dd41a393f6 by @guibranco)

Thanks @guibranco !


[BuildSystem] Cache the ShellCommand signature.

Computing shell command signatures can be expensive; this speeds up null
builds in cases where the build description is being held in memory.

@swift-ci please smoke test


Allow other contract types to have upload of contracts

It would be nice for there to be a check box in Admin>Scout>Contract Types where I determine if that contract type can have contracts uploaded.  For other contract types (other than costars right now), there are contracts where I get the PDF but there is no website for me to link to.  I wish these would show up in Conductor>COSTARS Upload>Contract PDFs

I'm confused. Do you have a file that need to upload or a link to a PDF hosted elsewhere?

I'm saying that some contract types have their contracts on websites (county, state, a-bids)....others don't and you have to download a pdf copy of the contract (costars).  It would be nice if there was a switch where I could signal, this type of contract has pdf's that I need to upload for contract types that don't have websites.  I would then have these contracts appear in my same 'costars upload' list.

This came up again today.  If I say a contract in scout is 'US Communities', I would like to upload a document of the contract pricing (in conductor>costars upload>upload contract pdfs, probably) because you can only get to the contract URL if you are logged in as a user.

If we don't have a switch, We could always do "any contract in scout **without a URL **appears in conductor>costars upload>upload contract pdfs.  This would allow me to upload a document for any of these contracts.

I will try to get to this, but it's a new feature as opposed to a bugfix which is why I haven't prioritized it.

This is getting to be a bigger issue as we have more and more different contract types that we are adopting and not all of them have a URL.  Most of them I have a PDF of the contract that I would like to upload and attach.
If somewhere under Admin>Scout>Contract Types there was a column for upload vs URL it would be helpful.  That way for example I could select GSA as an upload type of contract and they would show up under Conductor>Costars Upload list.

Hi Riley -- I can take a look at this soon. However, because this will require a database change, I want to wait until after we do the user migration to the new username/password system.


Error -32602, unknown field blockhash, returned by eth_getLogs

Describe the bug
Got the response
{"jsonrpc":"2.0","error":{"code":-32602,"message":"Invalid params","data":"unknown field `blockhash`, expected one of `fromBlock`, `toBlock`, `address`, `topics`, `blockHash` at line 1 column 12"},"id":1}

by request payload {"jsonrpc":"2.0","method":"eth_getLogs","id":1,"params":[{"blockhash":"0x58dc57ab582b282c143424bd01e8d923cddfdcda9455bad02a29522f6274a948"}]}
While the request payload is valid for erigon=2.55.1-12889fd0
Steps to reproduce
curl <reth-client> \
    -X POST \
    -H "Content-Type: application/json" \
    --data '{"jsonrpc":"2.0","method":"eth_getLogs","id":1,"params":[{"blockhash":"0x58dc57ab582b282c143424bd01e8d923cddfdcda9455bad02a29522f6274a948"}]}'

Node logs
NA

Platform(s)
Ubuntu 22.04, x86_64
What version/commit are you on?
c4c07b86
What database version are you on?
Current database version: 1
Local database is uninitialized
What type of node are you running?
archive
What prune config do you use, if any?
None
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

you have a typo here "blockhash", this should be blockHash.
this only works on go clients because they json library supports case insensitive entries by default, though the spec is blockHash


(FACT-1595) split the blocklist and ttls tests into multiple files

The existing blocklist and ttls tests where all in the same 2 files. I copied the existing tests into separate files, and updated comment and step descriptions to match each of the tests. Then applied code style updates, formatting by RubyMine, TestRail numbers, and risk tags.

Looks like you need to rebase this to pick up the changes made in your other PR that got merged.

Yes, it appears that I do need to rebase

CLA signed by all contributors.


5 add config file support

I added config file support using toml and marshmallow.
A default config file can be created using transient init and transient init -name config-file-name.
The default config explains the format. QEMU args remain an arbitrary list of strings.
I added some very basic behave tests, but I still want to add actual unit tests.
I look forward to your feedback and ways we can improve this pull request. Thanks Adam!

That sounds reasonable to me
On Thu, Jun 18, 2020, 3:29 PM Mark V Senofsky<EMAIL_ADDRESS>wrote:

@senofsky commented on this pull request.
In transient/cli.py
https://github.com/ALSchwalm/transient/pull/74#discussion_r442484678:

+@click.help_option("-h", "--help")
+@click.option("-name", help="Creates a config file with the given name")
+@cli_entry.command("init")
+def init_impl(**kwargs: Any) -> None:

"""Creates a default Transient config file """
args = argparse.Namespace(**kwargs)

if args.name:

   config_file = args.name

else:

   config_file = "transient-config.toml"

with open(config_file, "w") as file:

   file.write(_config.default_config_file)

sys.exit(0)

That's a well-reasoned argument and I am inclined to agree with you
regarding a configuration file driven by need rather than a boilerplate
config - especially given the simple interface.
To resolve this, I will:

remove the init command
move the exhaustive config file string to
test/config-files/exhaustive-config

Let me know if you disagree and/or have any additional comments.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ALSchwalm/transient/pull/74#discussion_r442484678,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIDYP5FIE4VO25A5YFYMXTRXJ2LLANCNFSM4OABRUYA
.

I definitely learned a few things while creating this PR so thanks for the opportunity!
Let me know if there is anything else I can clean up.

lgtm :+1:


On my android the app crashes after upgrading to 1.8.7

Hi @wksantiago! Can you provide a little more details?
Is it crashing immediately on the splash screen or at some action?

After restoring using my 12 word phrases
It indicates the Logo screen starting...
Then closes
-------- Original Message --------
On Feb 14, 2024, 2:40 AM, Richard Holzeis wrote:

Hi @.***(https://github.com/wksantiago)! Can you provide a little more details?
Is it crashing immediately on the splash screen or at some action?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Cleared storage and cache and close app and restored again
and now it's spinning at the logo screen “Welcome to 10101”

Can you try starting the app without restoring? If it starts, we should be able to see something in your logs.
Also are you trying to restore a wallet with an open channel? Or did you only had on-chain funds?

Yes the app start OK is when initiating restore from backup phrase.
And yes trying to restore a wallet with an open channel, that it canceled by itself before I uninstalled it. Then all this happened.
On Thursday, February 15th, 2024 at 4:49 PM, Richard Holzeis @.***> wrote:

Can you try starting the app without restoring? If it starts, we should be able to see something in your logs.
Also are you trying to restore a wallet with an open channel? Or did you only had on-chain funds?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Yes the app start OK is when initiating restore from backup phrase. And yes trying to restore a wallet with an open channel, that it canceled by itself before I uninstalled it. Then all this happened.
…
On Thursday, February 15th, 2024 at 4:49 PM, Richard Holzeis @.> wrote: Can you try starting the app without restoring? If it starts, we should be able to see something in your logs. Also are you trying to restore a wallet with an open channel? Or did you only had on-chain funds? — Reply to this email directly, [view it on GitHub](#2031 (comment)), or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>

do you happen to know your node id ?

I never applied a node ID or changed it. Whatever the app default ID
William
On Friday, February 16th, 2024 at 8:57 AM, Philipp Hoenisch @.***> wrote:

Yes the app start OK is when initiating restore from backup phrase. And yes trying to restore a wallet with an open channel, that it canceled by itself before I uninstalled it. Then all this happened.
…
On Thursday, February 15th, 2024 at 4:49 PM, Richard Holzeis @.> wrote: Can you try starting the app without restoring? If it starts, we should be able to see something in your logs. Also are you trying to restore a wallet with an open channel? Or did you only had on-chain funds? — Reply to this email directly, [view it on GitHub](#2031 (comment)), or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>

do you happen to know your node id ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Unfortunately there is no default ID, it's derived from your seed phrase. Can you open your app one more time, let it crash and record the exact time the crash happened please?
With this we should hopefully see which node tried connecting on our side and can learn something about your case.

After deleting storage from the app I start the app and choose to restore form backup.
After restoring using the 12 word passphrase I go to a logo screen where is stays waiting.
See attach for where it gets stuck:

I believe I'm experiencing the same issue, here are my logs:
A Dart VM Service on Bonophone is available at: http://<IP_ADDRESS>:62833/od9H2P7x3TU=/
The Flutter DevTools debugger and profiler on Bonophone is available at: http://<IP_ADDRESS>:9100?uri=http://<IP_ADDRESS>:62833/od9H2P7x3TU=/
flutter: [WARN] TIME: 2024-02-19T18:28:49.647788Z r: Initializing fee rate cache with default values. defaults: [(MempoolMinimum, 1000), (Background, 2000), (Normal, 3000), (HighPriority, 4000)]
flutter: [INFO] TIME: 2024-02-19T18:28:50.439150Z r: Found channel manager data. Recovering from stored state
flutter: [INFO] TIME: 2024-02-19T18:28:50.632159Z r: Listening on <IP_ADDRESS>:56017
flutter: [INFO] TIME: 2024-02-19T18:28:50.632725Z r: Starting background processor
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.632918Z r: Getting all non-pending channels
flutter: [INFO] TIME: 2024-02-19T18:28:50.638680Z r: Lightning node started with node ID 0260f5d3f3f90551729c3df880be7214be3a0dcf7f7cc421f44cac0938554fca80@<IP_ADDRESS>:56017
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.644261Z r: Syncing 0 shadow channels
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.644619Z r: Got all transactions transactions: []
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.644688Z r: Syncing 0 shadow transactions
flutter: [INFO] TIME: 2024-02-19T18:28:50.653772Z r: Keeping RGS snapshot up to date
flutter: [TRACE] TIME: 2024-02-19T18:28:50.655044Z r: lightning_background_processor: Calling ChannelManager's timer_tick_occurred on startup
flutter: [INFO] TIME: 2024-02-19T18:28:50.655220Z r: Requesting RGS gossip update latest_sync_timestamp:<PHONE_NUMBER>,rgs_server_url: https://rapidsync.lightningdevkit.org/snapshot
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.659746Z r: Got all spendable outputs outputs: []
flutter: [TRACE] TIME: 2024-02-19T18:28:50.665180Z r: lightning_background_processor: Rebroadcasting monitor's pending claims on startup
flutter: [TRACE] TIME: 2024-02-19T18:28:50.799049Z Successfully synced payment history
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.799375Z found no subscribers, skipping event
flutter: [INFO] TIME: 2024-02-19T18:28:50.799922Z r: Started on-chain sync
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.799999Z r: Setting up connection peer: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156@<IP_ADDRESS>:9045
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.800056Z r: Connecting to orderbook API
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.800106Z r: Pruning expired orders
flutter: [ERROR] TIME: 2024-02-19T18:28:50.803077Z Failed to start backend. FfiException(RESULT_ERROR, A failed order must have a reason, null)
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.817325Z r: Response status code 200 OK
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.817496Z r: Successfully uploaded backup of dlc/03/636861696e5f6d6f6e69746f72.
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.839475Z r: Connection setup completed peer: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156@<IP_ADDRESS>:9045
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.839583Z r: Waiting to confirm established connection peer: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156@<IP_ADDRESS>:9045
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.839643Z r: Response status code 200 OK
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.839693Z r: Successfully uploaded backup of dlc/03/636861696e5f6d6f6e69746f72.
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.862586Z r: lightning::ln::peer_handler: Finished noise handshake for connection with 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.863120Z r: tungstenite::handshake::client: Client handshake done.
flutter: [INFO] TIME: 2024-02-19T18:28:50.865152Z r: Connected to orderbook realtime API
flutter: [TRACE] TIME: 2024-02-19T18:28:50.900698Z r: lightning_rapid_gossip_sync::processing: Processing RGS data...
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.901596Z r: lightning_rapid_gossip_sync::processing: Processing RGS update from<PHONE_NUMBER> with 0 nodes, 0 channel announcements and 0 channel updates.
flutter: [INFO] TIME: 2024-02-19T18:28:50.901687Z r: Updated network graph new_latest_sync_timestamp:<PHONE_NUMBER>
flutter: [TRACE] TIME: 2024-02-19T18:28:50.921928Z r: lightning::ln::channelmanager: New best block:<PHONE_NUMBER>0000000002e19243e556eccff322dd5600629f39bf75822c44788c at height 831152
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.922141Z r: lightning::chain::chainmonitor: New best block<PHONE_NUMBER>0000000002e19243e556eccff322dd5600629f39bf75822c44788c at height 831152 provided via best_block_updated
flutter: [TRACE] TIME: 2024-02-19T18:28:50.951764Z r: lightning_background_processor: Persisting ChannelManager...
flutter: [TRACE] TIME: 2024-02-19T18:28:50.996040Z r: lightning_background_processor: Done persisting ChannelManager.
flutter: [INFO] TIME: 2024-02-19T18:28:50.996465Z r: lightning::ln::peer_handler: Received peer Init message from 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156: DataLossProtect: required, InitialRoutingSync: not supported, UpfrontShutdownScript: supported, GossipQueries: not supported, VariableLengthOnion: required, StaticRemoteKey: required, PaymentSecret: required, BasicMPP: supported, Wumbo: supported, AnchorsNonzeroFeeHtlcTx: not supported, AnchorsZeroFeeHtlcTx: not supported, ShutdownAnySegwit: supported, Taproot: not supported, OnionMessages: not supported, ChannelType: supported, SCIDPrivacy: supported, ZeroConf: supported, unknown flags: none
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.997010Z r: lightning::ln::channelmanager: Generating channel_reestablish events for 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156
flutter: [INFO] TIME: 2024-02-19T18:28:50.997120Z r: Successfully logged in to 10101 websocket api!
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.998955Z r: Received all orders from orderbook orders: []
flutter: [INFO] TIME: 2024-02-19T18:28:50.999037Z r: Peer connected! inbound: false,their_node_id: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156
flutter: [DEBUG] TIME: 2024-02-19T18:28:50.999102Z r: Updating prices prices: {BtcUsd: Price { bid: Some(52099.5), ask: Some(52100) }}
flutter: [INFO] TIME: 2024-02-19T18:28:51.002142Z r: Processing message from: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156,kind: ChannelSettleConfirm
flutter: [DEBUG] TIME: 2024-02-19T18:28:51.007101Z r: Sending last dlc message last_outbound_serialized_dlc_message.message_type: SettleFinalize,peer: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156
flutter: [DEBUG] TIME: 2024-02-19T18:28:51.016871Z r: Received message that has already been processed, skipping. kind: ChannelSettleConfirm,node_id: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156
flutter: [INFO] TIME: 2024-02-19T18:28:51.830743Z r: Connection established peer: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156@<IP_ADDRESS>:9045
flutter: [INFO] TIME: 2024-02-19T18:28:55.275714Z r: Finished on-chain sync duration: 4480,latest_height: 831152
flutter: [TRACE] TIME: 2024-02-19T18:28:55.955569Z Successfully synced payment history
flutter: [TRACE] TIME: 2024-02-19T18:29:01.024385Z Successfully synced payment history
flutter: [TRACE] TIME: 2024-02-19T18:29:06.115387Z Successfully synced payment history
flutter: [TRACE] TIME: 2024-02-19T18:29:11.215178Z Successfully synced payment history
flutter: [WARN] TIME: 2024-02-19T18:29:14.387395Z r: Could not remove non-existing order order_id: 22a078f3-db74-4f12-bd04-c966fad443e3
flutter: [DEBUG] TIME: 2024-02-19T18:29:14.388622Z r: Updating prices prices: {BtcUsd: Price { bid: Some(52101), ask: Some(52100) }}
flutter: [DEBUG] TIME: 2024-02-19T18:29:16.473178Z r: Updating prices prices: {BtcUsd: Price { bid: Some(52101), ask: Some(52101.5) }}
flutter: [TRACE] TIME: 2024-02-19T18:29:16.479396Z Successfully synced payment history
flutter: [DEBUG] TIME: 2024-02-19T18:29:20.800911Z r: Pruning expired orders
flutter: [DEBUG] TIME: 2024-02-19T18:29:20.815384Z r: Response status code 200 OK
flutter: [DEBUG] TIME: 2024-02-19T18:29:20.815949Z r: Successfully uploaded backup of dlc/03/636861696e5f6d6f6e69746f72.
flutter: [DEBUG] TIME: 2024-02-19T18:29:20.817945Z r: Response status code 200 OK
flutter: [DEBUG] TIME: 2024-02-19T18:29:20.818501Z r: Successfully uploaded backup of dlc/03/636861696e5f6d6f6e69746f72.
flutter: [TRACE] TIME: 2024-02-19T18:29:20.870266Z r: lightning_background_processor: Calling PeerManager's timer_tick_occurred
flutter: [TRACE] TIME: 2024-02-19T18:29:20.871221Z r: lightning_background_processor: Rebroadcasting monitor's pending claims
flutter: [TRACE] TIME: 2024-02-19T18:29:21.675623Z Successfully synced payment history

This seems to be the cause  :
flutter: [ERROR] TIME: 2024-02-19T18:28:50.803077Z Failed to start backend. FfiException(RESULT_ERROR, A failed order must have a reason, null)


feature/ifdef-conditional, conditional compilation with webpack

Allows us to add triple slash conditionals to the generated npm javascript classes that almost mirrors the functionality of the haxe conditional compilation. You need to add the ifdef-loader to a project's webpack loader list. So here's the updated lib/_gen/openfl/display/MovieClip.js init closure that includes the conditional.
{
  MovieClip.__parent_fps = true;
  /// #if (typeof swf_parent_fps === 'undefined' || !swf_parent_fps) && (typeof swflite_parent_fps === 'undefined' || !swflite_parent_fps)
  MovieClip.__parent_fps = false;
  /// #endif
}

webpack.common.js
module: {
  rules: [
    {
      test: /\.js$/,
      use: [
        { loader: "ifdef-loader", options: {swflite_parent_fps: true} }
      ]
    },
    {
      test: /\.tsx?$/,
      use: [
      { loader: 'ts-loader' }
      ]
    }
   ]
}

A slightly modified hxgenjs ClassGenerator is required for the sole purpose of removing the trailing semicolons that the Haxe compiler adds to the end of any __js__("...") output. ifdef-loader errors out if it encounters these semicolons. So short of fixing this in the Haxe compiler, this can be dealt with using  hxgenjs.
untyped __js__("/// #endif")

haxe outputs in the js:
/// #endif;

The modifications in CustomClassGenerator  are from line 189 to 204.

The conditionals changed to use dashes instead of underscores, Haxe automatically converts our defines (using dashes) into underscores. -Dswf-parent-fps is the real preferred format, so figures it makes sense to support this on HTML5.
I'm using this convention for the conditional code here:
https://github.com/openfl/openfl/blob/develop/src/openfl/display/MovieClip.hx#L43
I think this leads to much cleaner source code (even if we still export both versions of the code to most targets). The inline should allow C++ compilers to optimize it out, and at the risk of slightly added weight to Haxelib-style HTML5 builds, I think it's probably a good way to handle this.
We can handle more defines this way, now, if we run across more we want :smile:


New theme: termite

Termite
Screenshot:

Repository

@gabrielsimoes I have now cloned your repo to https://github.com/dracula/termite and made you admin :)
@zenorocha we need to serve now the installation instructions at draculatheme.com/termite. Can I help you with this?

Here's a PR that includes termite: https://github.com/dracula/dracula.github.io/pull/67
I can merge it as soon as I have the instructions to activate the theme.


@ApiParam is ignored on ValueObjects wrapped with @JsonCreator

Bug: Using springfox-swagger2 version 2.7.0 swagger ignores @ApiParam documentation on parameters with ValueObjects.
Given a ValueObject with one field:
@Data
public class Key {

    @JsonCreator
    public Key(@JsonProperty("key") String keyContent) {
        key = keyContent;
    }

    // if enabled, name will be shown @ApiModelProperty(value = "my description")
    private final String key;
}

And a method on a controller:
@Controller
@RequestMapping("/store")
@Api(value="property", description="Retrieve values for an environment")
public class EnvironmentKeyValueStoreController {

   @RequestMapping(method = RequestMethod.GET, path = "{propertyKey}/{environmentKey}")
   public ResponseEntity<String> getProperty(
      @ApiParam(name = "propertyKey", value = "Key of the property", required = true) @PathVariable("propertyKey") Key propertyKey,
      @ApiParam(name = "environmentKey", value = "Key of the environment", required = false) @PathVariable("environmentKey") Key environmentKey
    ) {
      return "";
  }
}

All  @ApiParam on the two parameters are ignored. The only way i can show a description in swagger-ui, is by enabling @ApiModelProperty on the field Key.key.
Actual:

Parameter
Value
Description

key

key

Expected:

Parameter
Value
Description

propertyKey

Key of the property

environmentKey

Key of the environment

Try giving the @ApiParam#type a value of "string"

Thank you for your proposal. It's not working. I've created a project where you can reproduce the issue easily:
https://github.com/dkellenb/spring-fox-issue-2096
Actual:

Expected:

@dkellenb Thanks it appear to be a bug!


social authentication setup

I am referencing and opening this issue here, since its a bug with the generator and not the main framework.
https://github.com/feathersjs/feathers/issues/471

Closing. Issue captured in #35 and original issue was not a bug.


Error 401 while generating a report using grafana API

Hi @mahendrapaipuri,
I'm trying to generate a report using grafana api, I have "Status 401: Unauthorized".

The dashboard permissions

$ curl -H "Authorization: Bearer <my_token>" -X GET -k "https://xxxxx/api/dashboards/uid/iLdsyDbWz/permissions" | jq
[
  {
    "dashboardId": 190,
    "folderId": 168,
    "created": "2024-04-25T13:55:49+02:00",
    "updated": "2024-04-25T13:55:49+02:00",
    "userId": 99,
    "userLogin": "sa-1-mahen-reporter",
    "userEmail": "sa-1-mahen-reporter",
    "userAvatarUrl": "/avatar/f8a33429582f8dcd39b77cf6d295a9ab",
    "teamId": 0,
    "teamEmail": "",
    "teamAvatarUrl": "",
    "team": "",
    "permission": 1,
    "permissionName": "View",
    "uid": "iLdsyDbWz",
    "title": "HYP - Serveurs par zone",
    "slug": "hyp-serveurs-par-zone",
    "isFolder": false,
    "url": "/d/iLdsyDbWz/hyp-serveurs-par-zone",
    "inherited": false
  }
]

The user permissions

$ curl -H "Authorization: Bearer <my_token>" -X GET -k "https://xxxxx/api/access-control/user/permissions" | jq '."dashboards:read"'

[
  "dashboards:*",
  "dashboards:*",
  "folders:*",
  "folders:*",
  "dashboards:uid:iLdsyDbWz"
]

Using grafana API

$ curl -k -o report.pdf -H "Authorization: Bearer <my_token>" "https://xxxxx/api/plugins/mahendrapaipuri-dashboardreporter-app/resources/report?dashUid=iLdsyDbWz&from=now-1M%2FM&to=now-1M%2FM&var-datasource=xxx&var-zone=xxx&layout=grid&orientation=landscape" -v

*   Trying x.x.x.x:443...
* Connected to xxxxx (x.x.x.x) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* TLSv1.0 (OUT), TLS header, Certificate Status (22):
} [5 bytes data]
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
* TLSv1.2 (IN), TLS header, Certificate Status (22):
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Server hello (2):
{ [122 bytes data]
* TLSv1.2 (IN), TLS header, Finished (20):
{ [5 bytes data]
* TLSv1.2 (IN), TLS header, Supplemental data (23):
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
{ [25 bytes data]
* TLSv1.2 (IN), TLS header, Supplemental data (23):
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Certificate (11):
{ [1002 bytes data]
* TLSv1.2 (IN), TLS header, Supplemental data (23):
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
{ [264 bytes data]
* TLSv1.2 (IN), TLS header, Supplemental data (23):
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Finished (20):
{ [36 bytes data]
* TLSv1.2 (OUT), TLS header, Finished (20):
} [5 bytes data]
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
} [1 bytes data]
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
} [5 bytes data]
* TLSv1.3 (OUT), TLS handshake, Finished (20):
} [36 bytes data]
* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: C=xx; ST=xxx; L=xxx; O=xxx; OU=xxx; CN=xxx; emailAddress=xxx
*  start date: Dec 14 15:23:04 2023 GMT
*  expire date: Jan 13 15:23:04 2024 GMT
*  issuer: C=xx; ST=xxx; L=xxx; O=xxx; OU=xxx; CN=xxx; emailAddress=xxx
*  SSL certificate verify result: self-signed certificate (18), continuing anyway.
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
} [5 bytes data]
> GET /api/plugins/mahendrapaipuri-dashboardreporter-app/resources/report?dashUid=iLdsyDbWz&from=now-1M%2FM&to=now-1M%2FM&var-datasource=xxx&var-zone=xxx&layout=grid&orientation=landscape HTTP/1.1
> Host: xxxxx
> User-Agent: curl/7.81.0
> Accept: */*
> Authorization: Bearer <my_token>
>
* TLSv1.2 (IN), TLS header, Supplemental data (23):
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
{ [57 bytes data]
* TLSv1.2 (IN), TLS header, Supplemental data (23):
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
{ [57 bytes data]
* old SSL session ID is stale, removing
* TLSv1.2 (IN), TLS header, Supplemental data (23):
{ [5 bytes data]
* Mark bundle as not supporting multiuse
< HTTP/1.1 500 Internal Server Error
< cache-control: no-store
< content-security-policy: sandbox
< content-type: text/plain; charset=utf-8
< x-content-type-options: nosniff
< x-frame-options: deny
< x-xss-protection: 1; mode=block
< date: Thu, 25 Apr 2024 13:17:45 GMT
< transfer-encoding: chunked
< set-cookie: SERVERID=grafana-01; path=/
<
{ [30 bytes data]
* TLSv1.2 (IN), TLS header, Supplemental data (23):
{ [5 bytes data]
* Connection #0 to host xxxxx left intact

The grafana log file :

logger=context userId=0 orgId=0 uname= t=2024-04-25T15:23:41.44301195+02:00 level=info msg= error="[auth.unauthorized] cannot authenticate request" remote_addr=<IP_ADDRESS> traceID=
logger=context userId=0 orgId=0 uname= t=2024-04-25T15:23:41.443934498+02:00 level=info msg="Request Completed" method=GET path=/api/dashboards/uid/iLdsyDbWz status=401 remote_addr=<IP_ADDRESS> time_ms=0 duration=990.814µs size=102 referer= handler=/api/dashboards/uid/:uid status_source=server
logger=plugin.mahendrapaipuri-dashboardreporter-app t=2024-04-25T15:23:41.44462634+02:00 level=error msg="error generating report" endpoint=callResource err="error fetching dashboard iLdsyDbWz: error obtaining dashboard from https://localhost:3000/api/dashboards/uid/iLdsyDbWz?var-datasource=xxx&var-zone=xxx. Got Status 401 Unauthorized, message: {\"extra\":null,\"message\":\"Unauthorized\",\"messageId\":\"auth.unauthorized\",\"statusCode\":401,\"traceID\":\"\"}\n " pluginID=mahendrapaipuri-dashboardreporter-app
logger=context userId=99 orgId=1 uname=sa-1-mahen-reporter t=2024-04-25T15:23:41.44510429+02:00 level=error msg="Request Completed" method=GET path=/api/plugins/mahendrapaipuri-dashboardreporter-app/resources/report status=500 remote_addr=<IP_ADDRESS> time_ms=45 duration=45.014819ms size=24 referer= handler=/api/plugins/:pluginId/resources/* status_source=downstream

Any solutions ?
Best regards

grafana open source 10.4.2
reporter 1.2.0
Ubuntu 22.04

@Alan1810 How many organizations you have in your Grafana deployment? It seems to me that you have your service account created in orgId=1 and that account is making a API request to generate a report of a dashboard in orgId=0. Could you try adding orgId=1 to the query parameters for the report API?
Cheers

Hi,
We only have one org with Id=1.
I've added orgId=1 to the query parameters for the report API but i have the same error :
logger=context userId=0 orgId=0 uname= t=2024-04-25T18:29:16.474621771+02:00 level=info msg= error="[auth.unauthorized] cannot authenticate request" remote_addr=<IP_ADDRESS> traceID=
logger=context userId=0 orgId=0 uname= t=2024-04-25T18:29:16.475739121+02:00 level=info msg="Request Completed" method=GET path=/api/dashboards/uid/iLdsyDbWz status=401 remote_addr=<IP_ADDRESS> time_ms=1 duration=1.155599ms size=102 referer= handler=/api/dashboards/uid/:uid status_source=server
logger=plugin.mahendrapaipuri-dashboardreporter-app t=2024-04-25T18:29:16.476427808+02:00 level=error msg="error generating report" endpoint=callResource err="error fetching dashboard iLdsyDbWz: error obtaining dashboard from https://localhost:3000/api/dashboards/uid/iLdsyDbWz?var-datasource=xxx&var-zone=xxx. Got Status 401 Unauthorized, message: {\"extra\":null,\"message\":\"Unauthorized\",\"messageId\":\"auth.unauthorized\",\"statusCode\":401,\"traceID\":\"\"}\n " pluginID=mahendrapaipuri-dashboardreporter-app
logger=context userId=99 orgId=1 uname=sa-1-mahen-reporter t=2024-04-25T18:29:16.47720817+02:00 level=error msg="Request Completed" method=GET path=/api/plugins/mahendrapaipuri-dashboardreporter-app/resources/report status=500 remote_addr=<IP_ADDRESS> time_ms=63 duration=63.30165ms size=24 referer= handler=/api/plugins/:pluginId/resources/* status_source=downstream

Best regards

Cheers @Alan1810 for the info.
Yes, I can reproduce the behaviour with newer Grafana. I have already tested a potential solution but I would like to investigate it more on what is the "recommended" way to do this. I will get back to you ASAP.

Fine.
Thanks

Hello @Alan1810, could you please try this patch? You can download the plugin artifacts from here. The service account token must be configured for the plugin as well as stated in docs. If you are using grafana >= 10.3.0, you can use externalServiceAccounts feature which is stated in docs as well.

Hi @mahendrapaipuri,
The patch works fine.
Thank you for you work.
Regards


test/K8sUpdates: Bump stable branch for v1.11 development

/test

/test-1.23-net-next

test-1.22-4.19

test-1.23-net-next

test-1.23-net-next

test-1.22-4.19

test-1.23-net-next

test-1.23-net-next

test-1.23-net-next

Oh, one minor nit: The PR says "v1.11 development" but this is for testing v1.12, with upgrade from v1.11.

/test

test-gke

Tests are passing except for k8s-1.21-kernel-5.4 which failed with known flake #16852. Reviews are in. Merging.


284 validate context

@marcincichon @RobertWDLowe Please can you review?
Summary of changes

Normalize output of all context-related methods to return slugs as identifiers for agencies. Previously the method Agency_Context::current_user_available_agencies() was returning an array of WP_Term objects. Also update uses of this method to expect the new return type.
Agency_Context::set_agency_context($agency) now checks that the current user is allowed to change to the specified $agency. If not, the method will return a WP_Error object.
Handle the WP_Error object and show the error message to the user if they're trying to change to a context they don't have permission for.
Agency_Context::get_agency_context($agency) will now check that the context stored for the current user is still valid – i.e. if they're still allowed access to the agency. If not, it'll set it to one that they do have access to before returning.
Move Agency_Context and Agency_Editor classes into new directory inc/utilities.

@ollietreend tested. Looks good.

The code looks good, @ollietreend


Configurator script

Description
A simple script that accepts config.toml file, a variable, and a value and can write the changes to the artemis config.toml.  Here is an example of how it could work:
$ sh configurator.sh [/path/to/config.toml] [variable name] [variable value]

I'm working on this.

resolved by #666


Multiple queues, different Q_CLUSTER settings

First off, thanks for giving new life to django-q!
In the old repo there are several issues discussing maintaining multiple queues. We've had success with a qclusters command that looks like this:
class Command(BaseCommand):
    help = "Start multiple django-q clusters"

    def handle(self, *args, **options):
        for config in settings.Q_CLUSTER_CONFIG_LIST:
            q = Cluster(get_broker(config["name"]))
            q.start()

However, we really want our two queues to have different number of workers and different settings for retry/timeout, but this isn't possible because every Cluster uses the settings found in settings.Q_CLUSTER. It'd be really great if we could pass in a Q_CLUSTER-like dictionary to the Cluster constructor to adjust these values.
Thoughts? Would this be difficult to add?

I like this idea!
The main issue here is that currently all Q2 settings (except for the broker) are fetched directly from the settings through a separate class that gets called pretty much anywhere, without having to rely on the cluster itself. This means that if we were to simply add the options to the Cluster constructor, we would likely miss a few cases.
For example here:
https://github.com/GDay/django-q2/blob/c1d4858f622c7b05c825cc1f9d39cef6243ae3dc/django_q/signing.py#L13-L21
Having said that, adding WORKERS and TIMEOUT to the constructor should be fairly straightforward as those are only used within the cluster. RETRY is also used in the brokers, so that's likely a bit more work.
I don't think the monitoring tools will like that change though. https://django-q2.readthedocs.io/en/master/monitor.html

I have done similar things in my local branch. I don't think the monitoring tools will like the change too, but I don't use it for monitoring LOL.


Improve error handling for failed user credentials staging

fixes #837
looking into ways to reduce error handling duplication

What this PR does is no longer throwing an exception and doing a log.error when the staging of the user credentials fails.
Instead, we immediately end the task and show an error message to the user. Before, the task would actually execute and then cause the IDE to explode due to missing credentials.

Instead of an IDE error, here is what the user will now see when reproducing this issue:

I think we have some flows for deployment that trigger login right?  What if instead of a console message we had a dialog box explaining that they don't have any valid credentials for that project with the option to 'add a user'?
BTW what does the run configuration editor look like after logout?  Is the old project name still there?  Could be cool to have some validation in there too.

I'll look into your first point about creating a dialog.
Regarding the second point - yes the old project is still there: the dropdown is prepopulated with the previously entered project name. The validation on the deployment dialog just checks to see if the project is populated. I can look into expanding validation here.

ok. I'll file a bug for the second point. It doesn't have to be fixed here.

@patflynn I poc'd the dialog concept. I need to refactor the code, but here is what it would look like. Let me know if you have any suggested improvements:
If the user reproduces the issue (account is not associated with the cloud project), then at deploy time they will see this dialog:

Clicking 'add account' will open up the browser giving them the option to add a new account. If successfully adding an account tied to the cloud project, the deploy will succeed. If clicking 'cancel' or not adding the right account, the task will fail and they will they will see the console error:

I've added the dialog feature and did a bunch of refactoring so its ready for review.

:ship:


Foundation dependency

Taken apart Cocoa dependecies like
import class Foundation.NSString;
import var Foundation.NSUTF8StringEncoding;
import class Foundation.NSJSONSerialization;
import struct Foundation.NSJSONReadingOptions;
import struct Foundation.NSJSONWritingOptions;
import class Foundation.NSData;

there is no other dependencies from Cocoa, so is it possible to leverage these ones in order to be pure Swift lang?

I am open to using the above imports instead of importing all of Foundation.
Can you please create a pull request with the change?

@tristanhimmelman so the idea actually was to make this Swift project to work in a non Cocoa environment, take a look at the discussion here: http://talk.remobjects.com/t/swift-libraries-with-silver/7853/11
I'm not sure if all these dependencies could be completely removed in order to have no Cocoa's Foundation or Darwin dependency, so a cross-platform compiler could generate multi platform binaries from this.


[AWS] [EKS] unexpected route, incorrect gateway with Calico version v3.20.0

Hi,
When using Calico v3.20.0, I see this message appearing randomly in my calico pods
{"log":"2021-08-22 12:20:06.485 [INFO][58] felix/route_table.go 876: Remove old route dest=<IP_ADDRESS>/26 ifaceName=\"eth0\" ifaceRegex=\"\" ipVersion=0x4 routeProblems=[]string{\"unexpected route\", \"incorrect gateway\"}\n","stream":"stdout","time":"2021-08-22T12:20:06.485950174Z"}
When this error appear, I cant resolve hostnames from pods in my cluster (cant resolve a service inside my cluster, cant resolve google.com, etc). My application load balancer target groups cant access pods exposed via nodePort on my nodes (request time out).
After a few minutes (5-10) everything goes back to normal and after 10mn the problem reappear.
I didnt find any solution except downgrading from v3.20.0 to v3.19.1 thanks to Yuri Gelfand on the Calico slack.
Im using EKS 1.21, installed with Terraform.
I use the Calico CNI instead of the AWS VPC CNI.
I installed Calico using this manifest https://docs.projectcalico.org/manifests/calico-vxlan.yaml
calico_node_logs.zip

Checked for likely candidates:

The routing table code hasn't changed at all between v3.19.1 and v3.20.0.
However, there is a change in the vxlan_mgr; we added blackhole route calculation
No change in the L3 route resolver or vxlan resolver.

This doesn't seem to only affect AWS/EKS. I ran into the same issue with a bare metal on-prem install (kubernetes 1.22 + calico 3.20). As with the others, downgrading to 3.19.1 (which also meant downgrading to kubernetes 1.21) resolved the issue.
Seems like #4869 is more general

Running 3.19.1 doesn't solve the issue for me. Looks like it was an AMI upgrade that did it.

As @jubbynox pointed out, kubectl patch ippool.crd.projectcalico.org default-ipv4-ippool --type merge -p '{"spec":{"vxlanMode":"Always"}}' is a good workaround. It's too bad this cannot be specified in tigera Installation.

i can confirm that downgrading the version helped solve this issue. please update when you solve the bug.

@LiranBinshtok Are you using AWS CNI?

@LiranBinshtok Are you using AWS CNI?

no.

Running 3.19.1 doesn't solve the issue for me. I'm on AWS EKS 1.20 w/o the AWS CNI plugin. Looks like same-subnet non-VXLAN routing doesn't work. I have to use VXLAN for all routes.
As @jubbynox pointed out, kubectl patch ippool.crd.projectcalico.org default-ipv4-ippool --type merge -p '{"spec":{"vxlanMode":"Always"}}'.
Or, if using Tigera operator Helm chart, values.yaml:
installation:
  calicoNetwork:
    ipPools:
      encapsulation: VXLAN

if using calico.yaml manifest not tigera operator installed,
calico_backend: "vxlan"
value: "Never"
value: "CrossSubnet"
value: "CrossSubnet"
change CrossSubnet into Always


(AGAIN) Bare metal installation using quick script is not working

Deployment Method

[X] Installer
[ ] Docker Development
[ ] Docker Production
[ ] Bare metal Development
[ ] Bare metal Production
[ ] Digital Ocean image
[ ] Other (please provide a link Steps to Reproduce

Describe the problem*
I've done a clean reinstall of Ubuntu in WSL on Windows 10 and tried reinstalling Inventree using the quick script, and I am again experiencing issues.
It looks like this time the script does not create the config.yaml file in /etc/inventree and the data file in /opt/inventree.
The result is that connecting to localhost gives 502 error
Steps to Reproduce
Fresh install of inventree using quick script
Relevant log output
### Installer for InvenTree - source: inventree/stable
### Detected distribution: Ubuntu 22.04
### Installing required packages for download
### Installing libssl1.1
deb http://security.ubuntu.com/ubuntu focal-security main
Hit:1 http://archive.ubuntu.com/ubuntu jammy InRelease
Hit:2 http://archive.ubuntu.com/ubuntu jammy-updates InRelease
Hit:3 http://archive.ubuntu.com/ubuntu jammy-backports InRelease
Hit:4 http://security.ubuntu.com/ubuntu jammy-security InRelease
Get:5 https://dl.packager.io/srv/deb/inventree/InvenTree/stable/ubuntu 20.04 InRelease [1863 B]
Get:6 http://security.ubuntu.com/ubuntu focal-security InRelease [128 kB]
Get:7 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages [2983 kB]
Get:8 http://security.ubuntu.com/ubuntu focal-security/main Translation-en [446 kB]
Get:9 http://security.ubuntu.com/ubuntu focal-security/main amd64 c-n-f Metadata [13.2 kB]
Fetched 3572 kB in 3s (1201 kB/s)
Reading package lists... Done
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
libssl1.1 is already the newest version (1.1.1f-1ubuntu2.22).
The following packages were automatically installed and are no longer required:
  fontconfig gettext javascript-common jq libdatrie1 libevent-2.1-7 libevent-extra-2.1-7 libexpat1-dev libffi7 libgraphite2-3 libharfbuzz0b libjq1 libjs-jquery libjs-sphinxdoc libjs-underscore
  libnginx-mod-http-geoip2 libnginx-mod-http-image-filter libnginx-mod-http-xslt-filter libnginx-mod-mail libnginx-mod-stream libnginx-mod-stream-geoip2 libonig5 libpango-1.0-0 libpangoft2-1.0-0 libpq5
  libpython3-dev libpython3.10-dev libthai-data libthai0 libxslt1.1 nginx nginx-common nginx-core python3-brotli python3-cffi python3-dev python3-pip python3-ply python3-pycparser python3-wheel
  python3.10-dev zlib1g-dev
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 2 not upgraded.
### Getting and adding key
### Adding package source
### Updating package lists
Hit:1 http://archive.ubuntu.com/ubuntu jammy InRelease
Get:2 https://dl.packager.io/srv/deb/inventree/InvenTree/stable/ubuntu 20.04 InRelease [1863 B]
Hit:3 http://security.ubuntu.com/ubuntu jammy-security InRelease
Hit:4 http://archive.ubuntu.com/ubuntu jammy-updates InRelease
Hit:5 http://archive.ubuntu.com/ubuntu jammy-backports InRelease
Fetched 1863 B in 1s (2027 B/s)
Reading package lists... Done
### Setting installer args
### Installing InvenTree
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  inventree
0 upgraded, 1 newly installed, 0 to remove and 2 not upgraded.
Need to get 0 B/64.5 MB of archives.
After this operation, 153 MB of additional disk space will be used.
Selecting previously unselected package inventree.
(Reading database ... 32177 files and directories currently installed.)
Preparing to unpack .../inventree_0.15.3-1716835122.d4d9aa9d.focal_amd64.deb ...
Unpacking inventree (0.15.3-1716835122.d4d9aa9d.focal) ...
Setting up inventree (0.15.3-1716835122.d4d9aa9d.focal) ...
# Setting base environment variables
# No config file found: /etc/inventree/config.yaml, using envs or defaults
# Collected environment variables:
#    INVENTREE_MEDIA_ROOT=/opt/inventree/data/media
#    INVENTREE_STATIC_ROOT=/opt/inventree/data/static
#    INVENTREE_BACKUP_DIR=/opt/inventree/data/backup
#    INVENTREE_PLUGINS_ENABLED=true
#    INVENTREE_PLUGIN_FILE=/etc/inventree/plugins.txt
#    INVENTREE_SECRET_KEY_FILE=/etc/inventree/secret_key.txt
#    INVENTREE_DB_ENGINE=sqlite3
#    INVENTREE_DB_NAME=/opt/inventree/data/database.sqlite3
#    INVENTREE_DB_USER=sampleuser
#    INVENTREE_DB_HOST=samplehost
#    INVENTREE_DB_PORT=123456
# Getting the IP address of the server via web service
IP address is xxxxxx
# No python environment found - using python3.9
# Setting up python environment
bash: line 1: python3.9: command not found
bash: line 1: env/bin/pip: No such file or directory
# Stopping nginx
# Setting up nginx to /etc/nginx/sites-enabled/inventree.conf
# Starting nginx
# (Re)creating init scripts
Nothing to do.
Nothing to do.
# Enabling InvenTree on boot
# Creating admin user data
# Stopping InvenTree
# Updating InvenTree
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: wheel in /usr/lib/python3/dist-packages (0.37.1)
bash: line 1: invoke: command not found
# Set permissions for data dir and media: /opt/inventree/data
chown: cannot access '/opt/inventree/data': No such file or directory
# Setting up InvenTree config values
# Writing the settings to the config file /etc/inventree/config.yaml
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
sed: can't read /etc/inventree/config.yaml: No such file or directory
chown: cannot access '/opt/inventree/data': No such file or directory
chown: cannot access '/etc/inventree/config.yaml': No such file or directory
# Setting up InvenTree site URL
# Starting InvenTree
####################################################################################
This InvenTree install uses nginx, the settings for the webserver can be found in
/etc/nginx/sites-enabled/inventree.conf
Try opening InvenTree with either
http://localhost/ or xxxxx

Admin user data:
   Email<EMAIL_ADDRESS>   Username: admin
   Password: xxxxx
####################################################################################
### Install done!

Currently, only python3.9 is tested for. Using other versions is possible but you might run into issues. You can manually bypass this by setting SETUP_PYTHON to the python run command you want to use eg. python3.10

Duplicate of https://github.com/inventree/InvenTree/issues/7437

See https://github.com/inventree/InvenTree/issues/7377


mouseClickable shouldn't fire click when detectTransformGestures on parent handles gesture

Drag your mouse over the following text. Observe that mouse click fires on the child despite the fact a pan gesture was detected by the parent.  Issue appears to be on the desktop side in mouseClickable . We normally/should solve this by watching for consumed events while waiting for the "up". See waitForUpOrCancellation as an example.
import androidx.compose.foundation.ExperimentalFoundationApi
import androidx.compose.foundation.gestures.detectTransformGestures
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.mouseClickable
import androidx.compose.material.Text
import androidx.compose.ui.Modifier
import androidx.compose.ui.geometry.Offset
import androidx.compose.ui.input.pointer.pointerInput
import androidx.compose.ui.window.Window
import androidx.compose.ui.window.application

@OptIn(ExperimentalFoundationApi::class)
fun main() = application() {
    Window(onCloseRequest = ::exitApplication) {
        Box(Modifier.fillMaxSize().pointerInput(Unit) { detectTransformGestures { centroid, pan, zoom, rotation -> println("parent detected gesture $centroid $pan $zoom $rotation") }}) {
            Box(Modifier.fillMaxSize().mouseClickable { println("child click detected") }) {
                Text("Just some content")
            }
        }
    }
}

cc @igordmn @olonho

Fixed in https://github.com/JetBrains/androidx/pull/178.
By the way, mouseClickable is a temporary workaround. It still doesn't support auto-hover, auto-action on Enter key, mouse slop detection.
Also it doesn't support detection of simultaneously pressed buttons (right click when the left button is pressed, for example).
We tried to introduce info about pressed buttons in the past into common clickable. We plan to return to this feature someday, and deprecate mouseClickable

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Remove pypi DL counts. Add library count for adafruit and community

resolves: #385
Here is an example of how the library and blinka sections of the report would look with this change:
### Libraries
* Adafruit Libraries: 346 Community Libraries: 158
* 9 pull requests merged
  * 8 authors - FoamyGuy, TheIllusionist77, dcooperdalrymple, mikeysklar, michalpokusa, BlitzCityDIY, itsFDavid, shubham0x13
  * 4 reviewers - dhalbert, FoamyGuy, ladyada, BlitzCityDIY
  * Merged pull requests:
    * https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint/pull/55 (Days open: 30)
    * https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X/pull/20 (Days open: 14)
    * https://github.com/adafruit/Adafruit_CircuitPython_EPD/pull/83 (Days open: 3)
    * https://github.com/adafruit/Adafruit_CircuitPython_Display_Text/pull/210 (Days open: 3)
    * https://github.com/adafruit/Adafruit_CircuitPython_TemplateEngine/pull/5 (Days open: 3)
    * https://github.com/adafruit/Adafruit_CircuitPython_WM8960/pull/4 (Days open: 1)
    * https://github.com/adafruit/Adafruit_CircuitPython_VCNL4200/pull/4 (Days open: 1)
    * https://github.com/adafruit/Adafruit_CircuitPython_VCNL4200/pull/2 (Days open: 1)
    * https://github.com/adafruit/Adafruit_CircuitPython_Bundle/pull/483 (Days open: 1)
  * 43 open pull requests (Oldest: 809, Newest: 1)
* 7 closed issues by 7 people, 5 opened by 5 people
* Removed Hacktoberfest label from 113 issues.
  * 888 open issues
  * 96 good first issues
* https://circuitpython.org/contributing

#### Library updates in the last seven days:
* **New Libraries**
  * [adafruit/Adafruit_CircuitPython_VCNL4200](https://github.com/adafruit/Adafruit_CircuitPython_VCNL4200)
* **Updated Libraries**
  * [adafruit/Adafruit_CircuitPython_TemplateEngine](https://github.com/adafruit/Adafruit_CircuitPython_TemplateEngine)

### Blinka
* 0 pull requests merged
  * 0 authors -
  * 0 reviewers -
* 5 open pull requests
  * https://github.com/adafruit/Adafruit_Blinka_bleio/pull/40 (Open 1123 days)
  * https://github.com/adafruit/Adafruit_Python_PlatformDetect/pull/335 (Open 311 days) (draft)
  * https://github.com/adafruit/Adafruit_Blinka/pull/884 (Open 82 days) (draft)
  * https://github.com/adafruit/Adafruit_Blinka_Displayio/pull/140 (Open 79 days)
  * https://github.com/adafruit/Adafruit_Blinka/pull/888 (Open 65 days)
* 0 closed issues by 0 people, 1 opened by 1 people
* Removed Hacktoberfest label from 0 issues.
* 112 open issues
  * https://github.com/adafruit/Adafruit_Blinka/issues
* Piwheels Downloads in the last month: 16960
Number of supported boards: 146

The PyPi stats have been removed and the counts for each library bundle is added as the first line in the Library report section

@ladyada


HTML::DocumentFragment - invalid encoding on windows&jruby

See https://github.com/jruby/jruby/issues/2089

@ahorek, don't you forget to add encoding comment at the top of your script?

Can't reproduce. Closing.


[PoC] Apply spell check to tutorials

Summary
Apply spell check to tutorials by sphinxcontrib-spelling.
https://sphinxcontrib-spelling.readthedocs.io/en/latest/
If CI fails in this PR, you can add words to docs/spelling_wordlist.txt.
Details and comments

It captures two spell misses.

/home/runner/work/qiskit-nature/qiskit-nature/docs/tutorials/05_Sampling_potential_energy_surfaces.ipynb:23: Spell check: Oppenhemier: This interactive notebook demonstrates how to utilize the Potential Energy Surface (PES) samplers algorithm of Qiskit Nature to generate the dissociation profile of a molecule. We use the Born-Oppenhemier Potential Energy Surface (BOPES)and demonstrate how to exploit bootstrapping and extrapolation to reduce the total number of function evaluations in computing the PES using the Variational Quantum Eigensolver (VQE)..
Writing /home/runner/work/qiskit-nature/qiskit-nature/docs/_build/tutorials/05_Sampling_potential_energy_surfaces.spelling

/home/runner/work/qiskit-nature/qiskit-nature/docs/tutorials/07_leveraging_qiskit_runtime.ipynb:332: Spell check: releasess: . In this first release, the optimizer must be provided as a dictionary, in future releasess you’ll be able to pass the same optimizer object as in the traditional VQE..

@manoelmarques I don't get the reason why make html fails even if make spell succeeds. Do you have any idea?
Warning, treated as error:
/home/runner/work/qiskit-nature/qiskit-nature/docs/jupyter_execute/stubs/qiskit_nature.circuit.library.CHC.assign_parameters.ipynb:1:Each notebook should have at least one section title
make[1]: *** [Makefile:31: html] Error 2
make[1]: Leaving directory '/home/runner/work/qiskit-nature/qiskit-nature/docs'
make: *** [Makefile:69: html] Error 2
Error: Process completed with exit code 2.

https://github.com/Qiskit/qiskit-nature/pull/202/checks?check_run_id=2640948004#step:12:1945

@t-imamichi The output left by spell in the _build/stubs folders was interfering with the html build. Also the command for spelling was creating a jupyter_execute folder outside the _build folder. I fixed the makefile.

Thanks, @manoelmarques. How about cherry-picking https://github.com/Qiskit/qiskit-optimization/pull/142 to this PR? If OK, I'll do it.

@t-imamichi you mean, copying the relevant changes to this PR right ? Yes, it is a good idea. I was going to do it once this PR was merged but you can add it here as well.

Thank you. If we can do it, it's better to ask you do it because this PR is already reviewed by you.


Address CI issues

Add scala built/test/package - #89
Add yarn package - #84
Converge CI Files = #62

Closes #89
Closes #84
Closes #62

I have created and assigned #111 to myself for adding dependabot to the CI. @tuxji For this repo we would need it to check npm/yarn packages and github-actions correct? Based on the file https://github.com/apache/daffodil/blob/main/.github/dependabot.yml I assume Scala isn't supported currently.

@tuxji For this repo we would need it to check npm packages and github-actions correct? Based on the file https://github.com/apache/daffodil/blob/main/.github/dependabot.yml I assume Scala isn't supported currently.

Yes, correct. We have to use Scala Stewart to keep sbt dependencies up to date.  See https://www.scala-lang.org/blog/2019/07/10/announcing-scala-steward.html.

+1 looks good to me. Once squashed this should be good to merge.


Support new data type: TimestampWithTimeZone

This is also a long time ask, similar to presto type: TIMESTAMP WITH TIME ZONE
Instant in time that includes the date and time of day with a time zone. Values of this type are rendered using the time zone from the value.

Example: TIMESTAMP '2001-08-22 03:04:05.321 America/Los_Angeles'

Just as a reminder, this type in Postgres does not actually include timezone. Instead, at disk level, this type is just a normal timestamp. As explained by the doc:

For timestamp with time zone, the internally stored value is always in UTC (Universal Coordinated Time, traditionally known as Greenwich Mean Time, GMT). An input value that has an explicit time zone specified is converted to UTC using the appropriate offset for that time zone. If no time zone is stated in the input string, then it is assumed to be in the time zone indicated by the system's TimeZone parameter, and is converted to UTC using the offset for the timezone zone.

When a timestamp with time zone value is output, it is always converted from UTC to the current timezone zone, and displayed as local time in that zone. To see the time in another time zone, either change timezone or use the AT TIME ZONE construct (see Section 9.9.4).

Conversions between timestamp without time zone and timestamp with time zone normally assume that the timestamp without time zone value should be taken or given as timezone local time. A different time zone can be specified for the conversion using AT TIME ZONE.

So basically the timezone feature is mostly a frontend property. When timezone is included in the type, values are converted to UTC. When timezone is not included, the received timezone is considered to be based on the server timezone.

Example: TIMESTAMP '2001-08-22 03:04:05.321 America/Los_Angeles'
I'm a little unsure if this format may not lead to confusion.
The problem I see when using these values is, that Dayllight saving time (DST) / summer and winter time is not reflected in this.
Since summer and winter time is not aligned all over the world,
see https://en.wikipedia.org/wiki/Daylight_saving_time_by_country
some calculations on base of these values may get complicate/prone to errors.
One approach to solve this may be adding UTC+X to timestamp instead
Example:
TIMESTAMP '2001-07-23 03:04:05.321 UTC+2' -> Germany/Berlin/summertime
TIMESTAMP '2001-12-24 03:04:05.321 UTC+1' -> Germany/Berlin/wintertime

Format should be ISO-8601 (which is the one used in JSR-310).

btw the "official" letter "T" as a delimiter between Date and Time in this example, makes it also easier to read/use
2007-04-05T12:30−02:00
https://en.wikipedia.org/wiki/ISO_8601#Combined_date_and_time_representations

+1 on this feature

@mghildiy It should be similar to how the TIMESTAMP data type is handled (you may search the usage of DataType.TIMESTAMP). We need to design the internal storage format (presto uses long format and we may use the same way to store it), and how it interacts with other TIMESTAMP WITH TIME ZONE and TIMESTAMP

@Jackie-Jiang , thanks for the lead.

Which part of codebase takes care of internal storage format?

Each DataType has a getStoredType().
BOOLEAN is stored as INT, TIMESTAMP is stored as LONG, JSON is stored as STRING. Take a look at its usage

Hi, I may take some time here due to an unplanned change in events.

I am restarting work on it.

I have a query here.
This data type needs to be a composite one as its combination of instant value and time zone.
Hnece, Internal storage format would be a combination of long(for instant value in UTC) and string/int(for timezone). Am I correct?

This data type needs to be a composite one as its combination of instant value and time zone.
Heece, internal storage format would be a combination of long(for instant value in UTC) and string/int(for timezone). Am I correct?

I don't think that should be the case. I think what Postgres does is pretty smart here. Basically at storage level, timestamp (without time zone) and timestamp with time zone are equivalent. They just store millis since epoch (which is 1/1/1970 00:00 UTC). The only difference is how that is interpreted when written/reading. When timestamp without time zone is used, all writes/reads are interpreted to be UTC (or the timezone used by the server, I guess). When timestamp with time zone is used, then it follows a more complex logic that depends on the timezone of the client/connection.
I strongly recommend to read postgres documentation page describing datetime datatypes, this stackoverflow answer and specially this post from yugabyte

Exactly that is the case and that is what we would like to have.

Exactly that is the case and that is what we would like to have.

I have a query here then. So when query arrives at database engine, does it also contain client's timezone information?

I don't think so, and therefore I'm not sure if this issue is well defined. I think what we need is to add TIMESTAMP WITH TIMEZONE as a runtime type, but it should be stored as a TIMESTAMP (and therefore a long), converted at UTC.
What we need to add then is the ability to write literals as '2001-08-22 03:04:05.321 America/Los_Angeles', which would be of type TIMESTAMP WITH TIMEZONE. Then we need functions to transform from one timezone to another. Probably some of the timestamp functions we have right now support timezone and we will need to think about what to do with them.

Thanks  @gortiz.
Any more inputs by anyone else?

I've found this document describing TIMESTAMP and TIMESTAMP WITH TIMEZONE in Velox and I think it we can get use of this. Especially the concept and physical representation is similar to what we want to achieve here

I've found this document describing TIMESTAMP and TIMESTAMP WITH TIMEZONE in Velox and I think it we can get use of this. Especially the concept and physical representation is similar to what we want to achieve here

Thanks @gortiz for the link. Looking into it.

After going through that document, my approach would be:

Represent timestamp with time zone similar to timestamp ie a long value, with a part of bits used to store timezone.
User's tiemzone input(a string) is mapped to an integer representing one of the tiemzones and viceversa.
A mapper/converter class takes care of mapping mentioned above.

Another comprehensive [blog|https://kaiwern.com/posts/2021/07/20/what-you-need-to-know-about-postgresql-timezone/] on how time zone is handled in Postgres. +1 to storing timestamp in UTC at the storage level. A couple of other configs required are timezone of the server and client. The timezone of the server can be a config. Timezone of the client can be set through a query option ?
With these, it should be possible to provide all the functionality similar to PG.

I have a query. User input would be something like '2021-01-01 01:01:01.001 America/Chicago', and not with offsets. Am I right?

This is the PR I have created. It's a WIP currently.

We've got designs of different flavors:

TIMESTAMP NO TIME ZONE: #14398
TIMESTAMP WITH TIME ZONE: #14526

Here is the PostgreSQL documentation for reference. The internal storage format should be long value (millis since epoch), and we need to align on the input value parsing and output result format for these data types:

What input format is allowed
If input doesn't have time zone info, which time zone to use to parse the value
What output format to use

cc @xiangfu0 @gortiz


[SPARK-43541][SQL][3.3] Propagate all Project tags in resolving of expressions and missing columns

What changes were proposed in this pull request?
In the PR, I propose to propagate all tags in a Project while resolving of expressions and missing columns in ColumnResolutionHelper.resolveExprsAndAddMissingAttrs().
This is a backport of https://github.com/apache/spark/pull/41204.
Why are the changes needed?
To fix the bug reproduced by the query below:
spark-sql (default)> WITH
                   >   t1 AS (select key from values ('a') t(key)),
                   >   t2 AS (select key from values ('a') t(key))
                   > SELECT t1.key
                   > FROM t1 FULL OUTER JOIN t2 USING (key)
                   > WHERE t1.key NOT LIKE 'bb.%';
[UNRESOLVED_COLUMN.WITH_SUGGESTION] A column or function parameter with name `t1`.`key` cannot be resolved. Did you mean one of the following? [`key`].; line 4 pos 7;

Does this PR introduce any user-facing change?
No. It fixes a bug, and outputs the expected result: a.
How was this patch tested?
By new test added to using-join.sql:
$ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z using-join.sql"

and the related test suites:
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly org.apache.spark.sql.hive.HiveContextCompatibilitySuite"

Authored-by: Max Gekk<EMAIL_ADDRESS>Signed-off-by: Max Gekk<EMAIL_ADDRESS>(cherry picked from commit 09d5742a8679839d0846f50e708df98663a6d64c)

Merged to branch-3.3.


Resource location issue

SURFMirflickr25K256 feature cannot load the resource file as it is not found.
Branch: multi-module

It expects a resources folder to be present at './resources'. The current build process does apparently not copy these resources properly. We will have to add that...

Instead of copying some resource folder, the ideal way is to put them in src/main/resources where they're automatically copied to the jar. This simplifies the build process.

@silvanheller they are located in cineast-core/src/main/resources/ - however, adjusting the CODEBOOK_FOLDER to codebooks/ does not fix the issue.
TL;DR: As @lucaro pointed out, the codebook files shall be copied to an accessible location during build

We did in the past explicitly not copy these kinds of resources into the jar since they are very large which would bloat the jar and slow down the loading of everything and since they are (to a certain degree) user configurable. The code books for example can be generated via cineast, so if someone wants to generate one for their specific use case, they can do so. Same is true for the DNNs.

@sauterl is this still reproducible?


Fixed '/say /foobar' not showing ':' after name

Tested with Obsi -

Obsi : foobar
Obsi : I did '/say foobar' there
Obsi : /foobar
Obsi : And '/say /foobar'

Nice and simple. Approved. :100:


cannot open URLs

Hello I think this is great. :)
One feedback. It is not possible to open the URL for the package which is displayed in the right pane.
In kitty, xfce terminal and konsole:

hover over URL =

line appears under URL indicating it is being recognized by terminal emulator
cursor changes from regular arrow to pointing hand (except in konsole this doesn't happen)

click URL = no action
right click URL = no action
click & drag = unable to select URL to copy/paste to browser
shift + (drag) click = can select text this way. but if the URL is too long and gets wrapped, would have to pick out the text from box drawing and left column

In terminator,  it is as above execpt if you double right click the context menu pops up and it is possible to select "Open link", which works
In alacrity, the URL doesn't get picked up at all. No underline, no cursor change. Can use shift + (drag) click as above.
I verified in kitty, alacritty and terminator that I was able to interact with URLs are expected in another TUI application (gitui) so I believe the issue isn't in my system.

Most terminals detect URL's and it should work with CTRL + Click (in xfce4-terminal, terminator this works)
In kitty it works with Shift + Click.
There are a couple of issues about that topic at the github repository of tview(which is used in pacseek for the tui stuff).
Like https://github.com/rivo/tview/issues/108
Now there is also this commit https://github.com/gdamore/tcell/commit/e7b14a71dc78721c0f007fd6197262c52c1d4df9 in tcell (which in turn is used by tview) to address hyperlinks. However, at the moment tview imports an earlier version of tcell where it is not present.
I might give it a try and fork tview and update the modules to see if I can make use of the new Url thing from tcell.
That being said, I'm not sure if want to go down that rabbit hole though. There might be good reasons that tview did not yet adopt to the latest tcell version...
Regarding alacritty there is also this: https://github.com/alacritty/alacritty/issues/922
So, I'm not even sure if that would fix it there.

Idk if this would be just too hacky. But if the URL would be made to span the whole terminal window instead of half, it would be a lot easier to copy properly. Because being on 2 lines is what turns the selected URL into something like  https://github.com/moson-        │║║│                              ││               mo/pacseek
I think that part could be a lot improved by a keyboard shortcut that would toggle horizontal instead of vertical split. Which would sometimes be useful in other situations like when there is really long package names.
Wouldn't really solve the URL issue but work around more easily.

This might help:
https://github.com/moson-mo/pacseek/wiki/Usage#resizing-components

I've solved it differently. With 1.3.2, when you click on a URL it will execute xdg-open which should open your default browser and navigate to the page.
(make sure you have xdg-utils installed...)
This should also fix the problem with the line-wrapping where the URL is split into multiple lines...

it works! :D


Update formatting in the sample XML

Removed extra white spaces to fix alignment of the XML in the code sample.

@Tanya-Solyanik : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


[A11Y] [iOS] Unable to linear navigate to the items in Preview banner.

ENVIRONMENT:
Form factor : iPAD
Model : MC705LL/A
Version : 9.3.5(13G36)
Browser : Safari
PRE-REQUISITE:
Turn 'VoiceOver' ON. ( Settings->General->Accessibility->VoiceOver->ON )
STEPS TO REPRODUCE:

Navigate to the URL: https://ampstart.com/
Navigate to "Templates" link and double tap on it.
Navigate to 'VIEW TEMPLATE' in any of the sections and double tap on it.
Try to linear navigate through all the items in the Preview banner.

ACTUAL RESULTS:
Focus does not move onto the Preview banner through linear navigation. Focus is on the background text content. Only exploratory touch works.
EXPECTED RESULTS:
User should be able to navigate through all the items in the preview banner through linear navigation.
ATTACHMENT:
Please see the video in the link below for reference.
https://drive.google.com/corp/drive/folders/0BwgKOOZP99EuUzVWT25TVzl2S00

Duplicate of #407
Please see comment on that issue as well if interested


feat: Implement Add for patch

A fix to manage generic types and add the imlementation of Add for two patches.

This might not work for all cases

Thank you so much.  I just fix it, sorry I did not find out this PR.


Improve pre-commit hooks configuration

Codecov Report

Merging #1071 (7515e4f) into main (218e468) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   88.51%   88.51%
=======================================
  Files          39       39
  Lines        1332     1332
  Branches      127      127
=======================================
  Hits         1179     1179
  Misses        140      140
  Partials       13       13

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

 PUI: Family Court filter - displaying 'b' when it should not be


customized evaluation

Hi! Is it possible to input our own audio and get the enhanced audio through the model?

Hi!
We have uploaded the code for custom enhancement.
You can find details in './custom_enhance.py'.
The code is only for inference, and if you want to evaluate, you can refer to './eval_measure.py'.
Thanks for your interest.

Hi! I have adapted manner into a custom audio processing demo.
demo.py.txt
attached is the source code.
Because I dont really understand how manner works I have fed it only 1 or 2 seconds at a time of audio
also because my script wont allow for a greater delay
manner, as other networks and methods of noise gating, only has a short term memory(seemingly) for variations in
amplitude(as in a noise gate approach) and cannot(as used here) significantly attenuate noise outside of windows of activity


Synced charts padding variation (causes hover issues)

Explanation
The labels are exactly the same on both charts. The only difference is the value of X. Not many custom options are set other than the markers and some tooltip/label formatting. The charts are also exactly the same width/height.

What is the behavior you expect?
The padding to be synced so that the hover position matches precisely.

What is happening instead?
Padding seems to be also dependant on x value

What error message are you getting?
None

I just found out this issue is also present in the docs sync example: https://apexcharts.com/vue-chart-demos/line-charts/syncing-charts/

I've added rulers to try visualize the problem more, apperantly the extra padding is only on the left side of the chart. The right side is still in sync. https://imgur.com/a/JWntKF4

Re-opening this until a fix is released.

Added a console.warn which asks the user to provide yaxis.labels.minWidth when charts are grouped. Setting the width automatically required a lot of calculations for all charts, so decided to add a console.warn

Docs require update stating this requirement.

Hey,
Having the same issue and warning pop up despite setting minWidth and declaring global values. none of these seem to work.


Add tests issue #28

I added some rudamentary tests so that new features or changes to existing ones can be test-covered

Made the changes


⚠ Bofrost.de has degraded performance

In da67f8c, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1521 ms

Resolved: Bofrost.de performance has improved in 08e6ded after 6 minutes.


Attach original traceback in direct runner failure.

This will make it much easier to debug pipelines.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @aaltay

Changes Unknown when pulling 37b93a3b9847f5ed886be8117a3bcdde6ca09666 on robertwb:runner-exceptions into ** on apache:master**.

Changes Unknown when pulling 37b93a3b9847f5ed886be8117a3bcdde6ca09666 on robertwb:runner-exceptions into ** on apache:master**.


[UI] Configurations UI Enhancements | Apps | Designs | Filters

Signed-off-by: Gaurav Chadha<EMAIL_ADDRESS>Description
Configurations UI Enhancements | Apps | Designs | Filters
This PR fixes #

[x] Adds source type icon in grid view cards dynamically.
[x] Adds an icon with a tooltip in the source type column to indicate to the user what action can be performed on icon click—[UX].
[x] Fixes responsive issue with 3 buttons on designs grid view cards.
[x] Makes Undeploy and Deploy icon scale to the same ratio.
[x] Applied standard and hovered state for undeploy red button according to the decided color

Notes for Reviewers
https://user-images.githubusercontent.com/65453826/184954013-08a47443-ea08-4c4a-90fd-71b28475d441.mp4
Signed commits

[x] Yes, I signed my commits.

This is looking good. Worth noting that this also brings the grid-based view on par with the table view in terms of functionality.

@Chadha93 great work :clap:
just wanted to ask is that multiple files downloading intentional at 0:14 of the video ?

@Chadha93 great work clap just wanted to ask is that multiple files downloading intentional at 0:14 of the video ?

@legendarykamal I checked again it's downloading only once. I have pushed more fixes here, feel free to test and report any bugs.

@asubedy @legendarykamal Will you test this pr and try to find and report any bugs if facing?  Do perform all the CRUD operations.
Let's make sure we don't have any bugs left in configurations.

yes Ok I will be testing it out on my local pc today :+1:


DatabasesInParallel

Description of the issue
We have (8) TLOG backup jobs running across hundreds of databases in parallel.
If one of the backups is still running when the job executes in 20 minutes none of the databases are backed up.
SQL Server version and edition
SQL 2016 13.0.7016.1
Version of the script
2022-01-02 13:58:13
What command are you executing?
DatabaseBackup LOG DatabasesInParallel
What output are you getting?
Nothing. The other (7) jobs just close because the one very large database is still doing a large LOG backup.

Hey Keith,
A few questions here:
What's the specific parameters of your 8 log backup jobs?
What's the schedule of these / how frequently are you running log backups?
How large is the database in question?
Other than seeing if something is abnormal with the above, I'd say to make 1 specific log backup job for that very large database, and make the other separate 8 jobs exclude that database with something such as the following:
@Databases = 'USER_DATABASES, -VeryLargeDatabaseNameHere',

Ben,
Here are your answers you requested:
1.)  Specific parameters =   " sqlcmd -E -S $(ESCAPE_SQUOTE(SRVR)) -d master -Q "EXECUTE [dbo].[DatabaseBackup] @Databases = 'USER_DATABASES', @Directory = N'\acespbak1\SQLBackups\SQLTLogBackups', @BackupType = 'LOG', @Verify = 'N', @CleanupTime = 168, @CheckSum = 'Y', @maxtransfersize= 65537, @DatabasesInParallel = 'Y', @LogToTable = 'Y'" -b"
2.) LOG backups run every 20 minutes.
3.) Data file = 614400.00 mb
   Log file = 409728.68 mb
4.) One off solutions like mentioned below got us into this mess. Evidently someone excluded the largest database from it's own backup job back in February.
Everything is caught up after this weekend but thought you should be aware that in the current design none of the LOG backups run again until all of them are done.
Thanks,
Keith

From: Ben @.>
Sent: Wednesday, September 28, 2022 10:49 AM
To: olahallengren/sql-server-maintenance-solution @.>
Cc: KeithCorser @.>; Author @.>
Subject: Re: [olahallengren/sql-server-maintenance-solution] DatabasesInParallel (Issue #687)
Hey Keith,
A few questions here:
What's the specific parameters of your 8 log backup jobs?
What's the schedule of these / how frequently are you running log backups?
How large is the database in question?
Other than seeing if something is abnormal with the above, I'd say to make 1 specific log backup job for that very large database, and make the other separate 8 jobs exclude that database with something such as the following:
@databaseshttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdatabases&data=05|01||7baa211fcaf24ebbe19f08daa16902bc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637999769637177947|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=f%2FMygZjwpr9dwODDrE7V%2F9BpgaEchDwq7q3LPVe8d74%3D&reserved=0 = 'USER_DATABASES, -VeryLargeDatabaseNameHere',
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Folahallengren%2Fsql-server-maintenance-solution%2Fissues%2F687%23issuecomment-1261109745&data=05|01||7baa211fcaf24ebbe19f08daa16902bc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637999769637177947|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=6cNhpQ7qvZTSA6cR%2ByeuMnysfxgxcbRUp8uRyL1cQe8%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMHAOIDUBTHRHNZU24A6SHTWARSIBANCNFSM6AAAAAAQUB7PGE&data=05|01||7baa211fcaf24ebbe19f08daa16902bc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637999769637177947|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tvMW8xBJAzqz3Ma5IshLQrNEd%2BwryfkwRRAWIzmHLYk%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Yeah in this case, there's definitely that known issue with the @DatabasesInParallel parameter but given the inactivity of updates to this repo, I'd recommend in the meantime having that secondary job for that large databases.
Definitely good to have monitoring in place, however aggressive/frequent that works, but something that checks for log backups for databases in full recovery model and alerts if there's no log backup in X time, so that if someone had made an accidental exclusion or disabled the job, you'd be notified about it within X time. Especially if there's a lot of transactions for that database, leaving it without log backups can blow up its log and nobody wants that.
One other thing I'd recommend is increasing the frequency of the log backups in addition to moving that large database to its own job. There's a really good BO article I've linked below on this topic, but it's actually less overhead to do them more frequently if your system can handle it with the amount of databases.
https://www.brentozar.com/archive/2014/02/back-transaction-logs-every-minute-yes-really/

Ben.
We put our own modification in to the sp to correct the behavior. Just wanted to let others know the issue was there. 🙂
For monitoring of backups I dug up some policies I had created in the past to make sure backups are being done going forward.
Thanks,
Keith

From: Ben @.>
Sent: Wednesday, September 28, 2022 11:44 AM
To: olahallengren/sql-server-maintenance-solution @.>
Cc: KeithCorser @.>; Author @.>
Subject: Re: [olahallengren/sql-server-maintenance-solution] DatabasesInParallel (Issue #687)
Yeah in this case, there's definitely that known issue with the @DatabasesInParallel parameter but given the inactivity of updates to this repo, I'd recommend in the meantime having that secondary job for that large databases.
Definitely good to have monitoring in place, however aggressive/frequent that works, but something that checks for log backups for databases in full recovery model and alerts if there's no log backup in X time, so that if someone had made an accidental exclusion or disabled the job, you'd be notified about it within X time. Especially if there's a lot of transactions for that database, leaving it without log backups can blow up its log and nobody wants that.
One other thing I'd recommend is increasing the frequency of the log backups in addition to moving that large database to its own job. There's a really good BO article I've linked below on this topic, but it's actually less overhead to do them more frequently if your system can handle it with the amount of databases.
https://www.brentozar.com/archive/2014/02/back-transaction-logs-every-minute-yes-really/
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Folahallengren%2Fsql-server-maintenance-solution%2Fissues%2F687%23issuecomment-1261175543&data=05|01||2a15777d48da4481823a08daa170c129|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637999802899135207|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=lw7049ihuUgfLiHeYWreXF%2BAGrICO0ClpGT6PU%2Bswaw%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMHAOIAAMAUEJENY7W6BWOLWARYX5ANCNFSM6AAAAAAQUB7PGE&data=05|01||2a15777d48da4481823a08daa170c129|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637999802899135207|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=w1ls438ji%2BlL%2B2baLFruOlZcuu3KqiI1Ltv7vGdW4tc%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Glad to hear it! 😄
Hoping this post brings some attention to OLA to give us some of that much needed update love.

This is the current design. I agree that for transaction log backups it is not optimal.
I will look into how it can be improved.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-23-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 859

Questions ?
Please refer to the Backport tool documentation


Enabling branch protection for Werkzeug

Some people push broken stuff to master (stylechecker!) and then Armin publishes releases with broken tests. GitHub has ways to prevent that. I would like to enable:

protected branches -- no force-pushes
require status checks -- no direct pushes, only pull requests

cc @mitsuhiko @RonnyPfannschmidt

See also #851

This is now done. Also I enabled @homu for merging.


/data info bugs

🐛 Bug Report
I encountered a few bugs while going through the list of commands in /data. I'm not sure if they've already been reported but I didn't find anything from the search function in the github channel in the support server.
OSB/BSO /data personal farmed crops shows global farmed crops and is empty.
OSB/BSO /data personal activity types and personal activity durations time out when the command is running.
OSB/BSO personal TOB wipes and global TOB wipes time out when the command is running.
I've included a screenshot of the bots timing out if that helps.
They're small things but I wanted to bring them up since I noticed them.

All these issues should be fixed in the next update.