Include Android and iOS clients in gui section

There are some capable clients for mobile platforms:

Pocket Git for Android
Git2Go for iOS
Working Copy for iOS (made by me)

Could these be included in the gui section?
I would be happy to provide a pull request.

I think there's no problem in adding a iOS and Android section to https://git-scm.com/downloads/guis, no @peff ?

I think that would be fine, as long as their platforms are marked appropriately (and since #951, we'd probably need matching filter buttons, too).

Hey guys, looking at implementing this. Trying to find good clients for both iOS and Android and have got these ones for Android: https://www.slant.co/topics/5207/~github-clients-for-android and these ones for iOS: https://www.slant.co/topics/1429/~github-clients-for-ios. Haven't used any of them, but googling 'best iOS/Android git client led me to them. Do they seem like good ones to add? Thanks guys!

I think I'd rather have people who are users or developers of particular clients add them (or least have tried them out). This isn't exactly a curated list, but I'd like there to at least be a minimum bar of knowing that the tool is supported and works.
So if we even start with 1 or 2 entries, then that may entice people to add their favorite clients (and gives the framework for how to add more).

Fair enough. Well, I've got an iPhone, I can try and find 1 or 2 that seem decent, and well supported and add those ones. Does that sound okay?

I made this issue originally and sort of regretted it. It felt wrong to add my own app to such a list even if someone else had to approve the pull request. A little like making your own wikipedia bio.
If you have any questions or need some kind of materials or specific work done for this, I can help, but I would prefer to not help decide which apps go on the list.

@Gangezilla Yes, that sounds great.

@palmin Actually, developers requesting their apps be added is how most of the gui list has been built. I don't mind devs promoting their own apps. I just want to see that somebody thinks it's useful enough to promote. Finding a mention on a random list may or may not be a good filter; I've seen a lot of vaporware and abandoned projects, and that's what I'm really trying to protect against.

OK. But Working Copy and Git2Go have both been supported for a number of years and my app is sometimes featured in the US and Canadian App Store.

I would say the 3 clients from the original comment could be a nice start. As someone who developed a client, I would assume he tried a few similar apps before/during developing its own :)

started looking at this here: https://github.com/pedrorijo91/git-scm.com/tree/feature/mobileGUI
@palmin If you want to have a look at the new GUI mobile clients, you can see at https://github.com/pedrorijo91/git-scm.com/blob/feature/mobileGUI/resources/guis.yml#L185-L208

Note: I still need to scrap the images

@pedrorijo91 Looks good, but I would really like the Working Copy link to be https://
Should I provide some images?
If so, should the dimensions be 588x332 pixels just like it seems to be in the GUI section?

I know there's a PR where the images are approached (or maybe the PR is about other images? not sure, and did not check yet). I wanted to see it to know if we have any restrictions/recommendations (I should probably document somewhere else after I find out)
about the https:
I simply clicked on the link you provided and copied, but of course I will change to https :) (maybe you should have a redirect to https on your side also)

@palmin I started by choosing these images: https://github.com/git/git-scm.com/compare/master...pedrorijo91:feature/mobileGUI
let me know if you have any other recommendation

If you could use the attached image for Working Copy, I would be super happy.
The one you picked is getting a little old.

sure ;) will update the image when I get back to this (probably tonight or this weekend)


feat(jest-config): openHandlesTimeout config option

Summary
Jest CLI currently prints a warning that tests have probably left handles open if it does not exit cleanly after 1000 millseconds.
This makes that timeout customisable, with the ability to disable it completely.
Useful when invoking jest-cli programmatically and doing work after the test run, or in other cases where handles may be known to be slower to close.
Test plan

New e2e test covering CLI option
Tested locally patched at FB (openHandlesTimeout specified via config file)

I'm not sure whether this should be a project option or just global, but given it seems to pair with detectOpenHandles I've added it alongside wherever that appears - do let me know if that's wrong.

https://github.com/facebook/jest/releases/tag/v29.5.0


Can "print website" in browser trigger the myst build command?

Which area is this feature request for?
LaTeX Export
Describe the feature you'd like to request
Pressing command+p in a web browser opens the print preview.
It would be great if there was an option that this print preview as generate by myst build 01-hello.md.
Would something like that be possible?
That would be a great option to have a preview of the PDF!
I know that there are custom CSS rules for printing (https://www.tutorialspoint.com/css/css_printing.htm),
but I don't know if something like this is also possible with JavaScript.
This is just a thought experiment, I don't need that feature, and this is deftly a low priority issue.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response

With a tiny bit of configuration, MyST sites already do something somewhat close to this. If you define static exports in your page frontmatter and build those prior to building your site, those static exports will be directly available from your myst site.
For example, in my file paper.md I have the frontmatter:
---
...
exports:
  - format: pdf
    template: lapreprint
  - format: tex
    output: my_paper_content.zip
---

...

Running myst build --all builds the files _builds/export/paper.pdf and my_paper_content.zip. Then, when I run myst start, those files are bundled into the content of the site and available for download on the page (along with the original source markdown):

Now, this isn't hooked directly into the browser print functionality, and it does not directly invoke myst build in javascript. The author must explicitly build the PDFs ahead of time, but if they do, the files are available for download/print.
Potentially we could build PDFs for all pages when building the site (and maybe allow authors to opt out, rather than opt in)? And potentially hook these up to browser print...


RuboCop fails when running specs due to parallel assignment

Fixing this issue:
Warning: unrecognized cop Blocks found in<EMAIL_ADDRESS>Inspecting 9 files
......C..
Offenses:
lib/faraday/request/digestauth.rb:34:9: C: Do not use parallel assignment.
@user, @password = user, password
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
9 files inspected, 1 offense detected
RuboCop failed!

Coverage decreased (-3.2%) to 90.476% when pulling 4c9d9b562d9fc2eb52a93f9a0a7243fc6db0f466 on nkamali:no_parallel_assignment into 0ab59fe20fd32b68c032ead7e1ac39e201757ef3 on bhaberer:master.


2 years passed, it's time to update the next version

I hope the next version will be referenced by issue
QuasarRAT A version should be updated，
Because the last update is 2 years now.
There is a great hope for QuasarRAT，
I hope  @MaxXor  gives a timetable for the next update ！


updated hover effects and cursor  pointer.

Description:
[Please include a brief description of the changes or features added]
i was added  hover effects to the navigation links .

Changed the cursor to a pointer when hovering over the navigation links.
Changed the background color of the links when hovered over.

Screenshots / Videos (if applicable)
Before:

After adding hover-effects:

Email_id<EMAIL_ADDRESS>


add accelearator

control+enter to trigger start/restart
closes #437

bug: pressing control-enter twice starts the underlying app twice in parallel. I'll fix and resubmit


ApnsClientTest#testSendManyNotifications() is really slow

Sending a thousand notifications takes way longer and burns way more CPU time than seems reasonable. I haven't investigated at all, but would like to (a) make sure that this isn't a sign of a larger performance issue and (b) make the test faster.

I'm going to close this and collapse it into #218, since they appear to stem from the same issue.

I lied. I think these are different issues again. Some almost-certainly-relevant debugging notes live in #218, though.

Looks like this was fixed by 7a6cd1460bc0b5cedad416766c67d25634f2d130.

Looks like this was fixed by 7a6cd14.

Actually, that's not true; I think I just happened to run 7a6cd14 on a different machine. It appears that GCM ciphers are just outrageously slow for much of Java 8, and a recent-ish update de-terrible-ized them. With 1.8.0_66-b17, testSendManyNotifications finishes in ~700ms. Elsewhere (will check on the specific version when I get back to that machine), it takes ~9,500ms.


PARQUET-911: [C++] Support nested structs in parquet_arrow

Support for simple StructArray reads.
Not supported in conjunction with lists yet.

cc @wesm @advancedxy

@itaiin is this ready for review? And do you want to support repeated struct support(list of struct  and struct of list) in this pr?
If ready, I will allocate some time to do a proper review as this is a quite big change.

I think it's ready for review. It would be nice to have complete nested types support, but I'm ok with proceeding in stages as long as the test cases don't have a lot of hard-coded assumptions about the completeness of the code

It is almost ready to review - after posting the PR I've played with it with some more complex parquet files I had and unfortunately found a bug. I'll fix it and extend the tests before your review.
About the hard-coded test cases - I dont think they are more specialized than before. I can think of  column-reader-test where there is one, but a) there was already an assumption there, and b) I think its non-essential and can be extended/eliminated, I just didn't want it to block the PR.

Fixed and added more testing. Should be ok to review.

It's late in my time zone. I will do the review tomorrow morning

ping @itaiin any updates?

@advancedxy thanks a lot for the review! sorry for not being responsive, its just that i am currently away and wont  be back in a few days. i will get right on it as soon as i can.

@xhochy I've pushed a commit with all of the fixes according to the conversation so far.
If @advancedxy thinks they're cool then I think its ready.

@itaiin some minor comments plus the included_column_indices ordering..

Sorry I haven't gotten down to review this yet. I think we are going to merge this right after parquet-cpp 1.1.0 and then we can make sure this gets into 1.2.0 and Arrow 0.5.0 (which should be released within a month of 1.1.0 / 0.4.0, respectively)

@wesm no worries. Also I think the reviews so far were very helpful.

Any updates on this pr?

I'm reviewing finally, can you rebase? thanks

@wesm thanks for reviewing.
I've found yesterday a small bug with partial struct reads, I'll commit a change + test along with the rebase.

@itaiin can you fix the Appveyor failure (it looks like just a compiler warning, may require a static_cast or two)? Then I think we can merge this and move on to the next iteration of nested data support.

@wesm cool. will fix right after the weekend

@xhochy can you have a last look? I think we should probably merge this and then start a design document about implementing nested data "properly" (implementing a state machine capable of decoding any nested / repeated tree of types into Arrow memory), which adequate testing (perhaps automatically generated, using Arrow's JSON file format that we now use for integration testing) so that we're able to exhaust all of the possibilities -- null structs, empty / null lists, lists with null or empty structs, and so forth.

@wesm That sounds fine to me. Feel free to merge.

@itaiin thank you!

@xhochy  @advancedxy & @wesm thanks for the reviews.
And thanks for merging the PR, I'm glad I could be helpful!
Next phase I guess is full read support.

@itaiin you are welcome. Our internal compute engine (will open source in this year if possible) also needs nested struct support from parquet-cpp.


Fixed a bug when keyboard shorcuts were triggered when form fields were focused

Keyboardjs doesn't support this out of the box, so we introduce a patch
to prevent callbacks running when input is focused.
Fixes https://github.com/divio/django-cms/issues/5698

Changes Unknown when pulling<PHONE_NUMBER>34f76df9935bb737bcee09a219a5b2 on vxsx:bugfix/keyboard-shortcuts-inside-forms into ** on divio:release/3.4.x**.


Run tests on macos arm-based runners

At least 2 users have reported crashes running on apple arm chips using the x86_64 conda-forge stack.  This branch is just an attempt to reproduce it and see if it is easily fixed.

It looks like adding this small test to the C.I. runner worked.  Merging.


Daemon fails to sync and then crashes on startup

NavCoin Core 4.6.0
2 GB Memory / 50 GB Disk / SFO2 - Ubuntu 18.04.1 x64 - Digital Ocean Droplet.
Tried to sync 4.6.0 starting from the genesis block. The daemon reached block 594406 and then crashed with the debug.log abruptly ending at that block height with no indication of the problem.
When restarting the daemon it crashes with this message dumped to the cli;
navcoind: chain.cpp:96: CBlockIndex* CBlockIndex::GetAncestor(int): Assertion `pindexWalk->pprev' failed.

When running the daemon with the debug flag, this is the log output;
2019-05-09 20:57:10 NavCoin version v<IP_ADDRESS>-bb51359-dirty
2019-05-09 20:57:10 InitParameterInteraction: parameter interaction: -whitelistforcerelay=1 -> setting -whitelistrelay=1
2019-05-09 20:57:10 RSA keys pair generated.
2019-05-09 20:57:10 Default data directory /home/bootstrap/.navcoin4
2019-05-09 20:57:10 Using data directory /home/bootstrap/.navcoin4
2019-05-09 20:57:10 Using config file /home/bootstrap/.navcoin4/navcoin.conf
2019-05-09 20:57:10 Using at most 125 connections (1024 file descriptors available)
2019-05-09 20:57:10 Using 2 threads for script verification
2019-05-09 20:57:10 Allowing HTTP connections from: <IP_ADDRESS>/8 ::1/128
2019-05-09 20:57:10 Binding RPC on address ::1 port 44444
2019-05-09 20:57:10 Binding RPC on address <IP_ADDRESS> port 44444
2019-05-09 20:57:10 Initialized HTTP server
2019-05-09 20:57:10 HTTP: creating work queue of depth 16
2019-05-09 20:57:10 Starting RPC
2019-05-09 20:57:10 Starting HTTP RPC server
2019-05-09 20:57:10 No rpcpassword set - using random cookie authentication
2019-05-09 20:57:10 Generated RPC authentication cookie /home/bootstrap/.navcoin4/.cookie
2019-05-09 20:57:10 Registering HTTP handler for / (exactmatch 1)
2019-05-09 20:57:10 Starting HTTP server
2019-05-09 20:57:10 HTTP: starting 4 worker threads
2019-05-09 20:57:10 Using BerkeleyDB version Berkeley DB 4.8.30: (April  9, 2010)
2019-05-09 20:57:10 Using wallet wallet.dat
2019-05-09 20:57:10 init message: Verifying wallet...
2019-05-09 20:57:10 CDBEnv::Open: LogDir=/home/bootstrap/.navcoin4/database ErrorFile=/home/bootstrap/.navcoin4/db.log
2019-05-09 20:57:10 scheduler thread start
2019-05-09 20:57:10 Entering http event loop
2019-05-09 20:57:10 init message: Synchronizing clock...
2019-05-09 20:57:10 [NTP] Starting clock sync...
2019-05-09 20:57:10 [NTP] Opening socket to NTP server nl.pool.ntp.org.
2019-05-09 20:57:12 [NTP] Received timestamp:<PHONE_NUMBER>[NTP] Opening socket to NTP server time.google.com.
2019-05-09 20:57:12 [NTP] Received timestamp:<PHONE_NUMBER>[NTP] Opening socket to NTP server bg.pool.ntp.org.
2019-05-09 20:57:12 [NTP] Received timestamp:<PHONE_NUMBER>[NTP] Opening socket to NTP server time3.google.com.
2019-05-09 20:57:12 [NTP] Received timestamp:<PHONE_NUMBER>[NTP] Opening socket to NTP server no.pool.ntp.org.
2019-05-09 20:57:17 [NTP] Could not read socket from NTP server no.pool.ntp.org (Read timeout)
2019-05-09 20:57:17 [NTP] Opening socket to NTP server ca.pool.ntp.org.
2019-05-09 20:57:22 [NTP] Could not read socket from NTP server ca.pool.ntp.org (Read timeout)
2019-05-09 20:57:22 [NTP] Opening socket to NTP server dk.pool.ntp.org.
2019-05-09 20:57:27 [NTP] Could not read socket from NTP server dk.pool.ntp.org (Read timeout)
2019-05-09 20:57:27 [NTP] Opening socket to NTP server hora.roa.es.
2019-05-09 20:57:28 [NTP] Received timestamp:<PHONE_NUMBER>[NTP] Measured: nl.pool.ntp.org[+1sec.] bg.pool.ntp.org[0sec.] time.google.com[0sec.] hora.roa.es[+1sec.] time3.google.com[0sec.]
2019-05-09 20:57:28 [NTP] Calculated offset from median: 0
2019-05-09 20:57:28 Bound to [::]:44440
2019-05-09 20:57:28 Bound to <IP_ADDRESS>:44440
2019-05-09 20:57:28 Block index database configuration:
2019-05-09 20:57:28 * Using 1000 max open files
2019-05-09 20:57:28 * Compression is enabled
2019-05-09 20:57:28 Cache configuration:
2019-05-09 20:57:28 * Using 2.0MiB for block index database
2019-05-09 20:57:28 * Using 8.0MiB for chain state database
2019-05-09 20:57:28 * Using 440.0MiB for in-memory UTXO set (plus up to 47.7MiB of unused mempool space)
2019-05-09 20:57:28 init message: Loading block index...
2019-05-09 20:57:28 Opening LevelDB in /home/bootstrap/.navcoin4/blocks/index
2019-05-09 20:57:28 Opened LevelDB successfully
2019-05-09 20:57:28 Using obfuscation key for /home/bootstrap/.navcoin4/blocks/index:<PHONE_NUMBER>000000
2019-05-09 20:57:28 Opening LevelDB in /home/bootstrap/.navcoin4/chainstate
2019-05-09 20:57:28 Opened LevelDB successfully
2019-05-09 20:57:28 Using obfuscation key for /home/bootstrap/.navcoin4/chainstate: 6c17c86d80a49c4b

then the same crash message is dumped to the cli.

I've upgraded the server to 4GB RAM with 2vCPUs and am trying to resync from the genesis block again. Will report back on whether increasing the resources resolved the issue or not.

Did re-index fix the issue?

I think this was related to not having enough RAM, closing as it works with 2GB ram as long as you have SWAP file, but takes much longer to boot the daemon.


Spam in Console | BUG

Logs:
http://pastebin.com/A9csRcPn
Version: 1.9.4
Version Magic: 6.2

This was fixed a while back, sorry for not responding!


Implement cron service

Cron service schedules tasks periodically

Cron service configs live in projects/<project_id>:cron.cfg
One entry in cron.cfg specifies

When to run the task. Bare minimum: frequency like in GAE cron.yaml
Quest to run and/or HTTP request to send

Example of cron.cfg
tasks  {
  # this is too long:
  # schedule {
  #    value: 5
  #    unit: MIN
  # }

  schedule: "every 5 min"
  quests {
     # definition
  }
}

tasks {
  # other task
}

This was implemented by @vadimsht in luci-go.


SID

i HAVE MADE SOME CHANGES

Thank you for your contribution.
I'm looking to do a Marie Kondo on the PR's and clean them up.
Is this still relevant? If not, let's close it.

Let's close it


cross-platform npm test script

The previous npm test script executed a .sh file
that isn't natively supported by Windows.
Since the actual code inside the .sh is pretty small,
it can be completely embedded inside a npm script instead,
making it cross-platform and more straight-forward.
This is a suggestion, if there are specific reasons why this should be in a .sh file as it was, disregard this PR.

@reyronald thanks for the PR. No reason specifically that I am aware of except that the original author was developing on *nix.


Adding active=true in alert list not passed to backend

Alertmanager version:
current master https://github.com/prometheus/alertmanager/commit/f32ad1dd8b0367100f8f0abcd121ce743711a549

When trying to filter the alert groups main view to only display silenced and/or inhibited alerts, I added &active=false to the URL:
http://localhost:9093/#/alerts?silenced=false&inhibited=true&active=false
What got sent to the backend was:
http://localhost:9093/api/v2/alerts/groups?silenced=false&inhibited=true
the param active is default true, so I am unable through the webui to see anything else.

I'd like to take this on if that's alright. I think I've already got most of it implemented.

Definitely! Let me know if I can help. It should only require changes to the elm code.

I've gotten the filter working. Should there be a checkbox for active since it's a default filter like inhibited and silenced? Or do you think it is safe to assume that most people will be fine with the default behavior and anyone who isn't should probably know how change URL query params?

Let's start with the default behavior + supporting the URL param, and we can think about adding the checkbox. Maybe we can think of a better way to support selecting the desired state through the UI, for a different PR.


reproducibility multilanguage

Those ones don't build on the machine.

Oh, the Matlab license and so.


Configure Azure Pipelines

This configuration builds the application and produces builds for both Debug and Release configurations.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mohdhafeezajh sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Proposal: DoMeFavor

Description:

A person creates a post to solve his problem. This person creates a quest on the smart contract plus a bounty.
Others join to do the work. Then they post proof of completed work or answer.
The quest creator chooses the best result to approve for funding.

Bounty track:

Other

there is an issue with non-payment tho. The quest creator can choose to not pay at all and rug everyone. You need an arbitration process with disputes that works like an optimistic oracle https://uma.xyz/#how-it-works

Thank you, I will think more carefully about it.


Add raw batch put/get/delete/scan

Add raw batch put/get/delete/scan and test cases, which can significantly reduce gRPC cpu utilization for bulk put and reduce number of roundtrips for reads
Require merge request #244 of kvproto to be merged and updates to Cargo.lock

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Since more AdminCmdType types in kvproto were added without corresponding code being merged in TiKV, I temporarily fixed build and test which is actually not related to this merge request

please make dev before commit

Could you update Cargo.toml and edit kvproto to your branch?

Sure, thanks.

@AndreMouche can you please tell me what version of nightly rust can be used? I tried couple versions but keep having issues with clippy_lints.
This is what I get with the latest nightly: rustc 1.26.0-nightly (75af15ee6 2018-03-20)
Compiling librocksdb_sys v0.1.0 (https://github.com/pingcap/rust-rocksdb.git#b127863a)
Compiling clippy_lints v0.0.179
error[E0463]: can't find crate for rustc_const_eval
--> /usr/local/rust/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.179/src/lib.rs:40:1
|
40 | extern crate rustc_const_eval;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
error: aborting due to previous error
For more information about this error, try rustc --explain E0463.
error: Could not compile clippy_lints.
warning: build failed, waiting for other jobs to finish...
error: build failed
Makefile:63: recipe for target 'test' failed
However running cargo test works

Tried nightly 2018-01-09 which was just one day before clippy_lints v0.0.179. And it works now.

It's strange that build was finished like a quarter ago, but tests are still pending.

Hello @AndreMouche , I have changed Cargo.toml and make work with make dev now. But it somehow failed a not related test of a new feature committed recently. Can you kindly explain what can I do now?

Thank you very much, I think you can create an issue for us and we will fix it as soon as possible @sunxiaoguang

Rebase to last night's master passed CI, but it conflict with later commit and the later commit made test failed again. Issue is create at here: #2863

Thanks @sunxiaoguang
Can you help us add the Go client API too?

Go API will come soon after more testing to make sure it actually works as expected

@zhangjinpeng1987 Please check the new commit with commented lines updated. Thanks.
CI failed again, but with different case 'test_node_merge_rollback'.

I'm thinking about why your every commit contains full change? It's hard to review :(.

Sorry, I'm just kind of don't like too many small commits.  Next time I will keep all the intermediate commits and squash them at last.

Rest LGTM
PTAL @disksing @zhangjinpeng1987

PTAL @breeswish

/run-integration-tests

LGTM


The twin loading color in the light mode doesn't show the text because of the white color.

Screencast from 03-07-23 17:08:40.webm
should be like
Screencast from 03-07-23 17:12:24.webm

2.1.0-rc2


Installing the backend dependencies fails (@nestjs)

Describe the bug
Following the macOS setup guide (without Docker) fails when installing the backend dependencies.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@nestjs/common
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nestjs/testing
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   1 more (@nestjs/typeorm)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@nestjs/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@nestjs/common
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nestjs/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/zlee/.npm/_logs/2023-04-19T16_49_39_040Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/zlee/.npm/_logs/2023-04-19T16_49_39_040Z-debug-0.log

I was able to bypass this with npm install --legacy-peer-deps but this should be resolved.
To Reproduce
Steps to reproduce the behavior:

Follow the setup guide as written in the documentation page
Run npm ci (or npm install) in the UpGrade/backend/packages/Upgrade directory
Installing the dependencies will fail

Expected behavior
The backend dependencies should successfully be installed.

@zackcl is this still happening?


get-fonts-css command throws exception

you can go to here to reproduce: https://codepen.io/dhika345/pen/bGZOjXG
why should this throw an Exception here? this is a mistake btw
https://github.com/silexlabs/grapesjs-fonts/blob/d7b32b3c39cfde3be1faff2cf46b16ccd2da5e78/src/commands.js#L7-L9

Hello
I was hoping someone would contribute this part
I don't use it in silex so i will not
Can you make a contrib?


Allow config to specify work days

Our office has Fridays off in the summer. Let's make sure we can set the configuration to only send notification on days 1-4

Bonus points for skipping MCT holidays too.

It'd be :cool: if it took company holidays into account. Happy Memorial Day.

hrm... it should be able to do that through bamboo somehow. I'll create a separate issue


Stressng sequential change

Changing run type to sequential instead of parallel, tests have proven results are much more stable using this mode.
Also reduced the runtime after confirming memory allocation and run variance looks fine for a 2min run for each test type.

Note: tested and passed on PerfCI cluster

Yeah I do think parallel is interesting, maybe something to add later, but the run to run variance swings in the memory tests are so wild that we need to figure out what is useful from a regression standpoint..


Error dialog when reindenting JSON file

Testing #19091.

Create a JSON file:

{
}

Invoke 'Reindent lines'
Error dialog: ' Cannot read property 'length' of undefined'

Same for other extensions like 'c', bat',...

swapping bug and verification-needed labels because the latter should be used for small feature requests that don't deserve a test plan item whereas all bug need verification by default


Bug with Utility Widget

It crashes when you have a Utility widget open in the layout.

This behavior is actually bug from engine side (I submitted bug report) . I tested it working correctly in ue5. But from utility widgets scanning point of view, those assets are like level assets and must not be removed and scanned. So with this changes I removed editor utility assets from scanning.


[FEATURE] Remove the "user note" feature

Is your feature request related to a problem? Please describe.
As part of the migration away from database support, this command needs to be removed as its the last part of the codebase that still connects to the db.
Additional context
This command has yet to be used, but can be added in the future. For now, it wont be needed though

Closing this as resolved in the latest refactor #219


[Bug]: change chroma client depend Pydantic  version

What happened?
If it already support Pydantic 2.0 (https://github.com/chroma-core/chroma/issues/893),  can you change Chroma_Client depend version
https://github.com/chroma-core/chroma/blob/65f3bb9ae256344d269d847a2d5c41b8ae11075f/clients/python/pyproject.toml#L19C24-L19C24
I believe this change is very simple, you just need to delete "<2.0"
Versions
chroma 0.4.18
Relevant log output
No response

Hi @vmjcv thanks for pointing this out. We’ll make the change or are happy to accept it if you do!

@HammadB
I am not very familiar with the overall project, so could you please change it
Thanks

@vmjcv, I've created a PR for this. Should be in next release.


Add Vega and Polaris Series Drivers

Please add drivers for Vega and Polaris Series. They are supporting AMD Software: Adrenalin Edition driver but do not appear in this repository.
https://www.amd.com/en/support/downloads/drivers.html/graphics/radeon-600-500-400/radeon-rx-500-series/radeon-rx-580.html
https://drivers.amd.com/drivers/whql-amd-software-adrenalin-edition-24.9.1-win10-win11-vega-polaris.exe
There is a combined version in release notes.
https://www.amd.com/en/resources/support-articles/release-notes/RN-RAD-WIN-24-10-1.html
https://drivers.amd.com/drivers/whql-amd-software-adrenalin-edition-24.10.1-win10-win11-oct-rdna-combined.exe

The next release will include the combined version, if available.

Thank you very much, my maintenance tools can't access the AMD website smoothly, this repository is useful for me.


Built-in support for Mailgun

Is your feature request related to a problem? Please describe.
At Tacto we are looking for a drop-in replacement of django-anymail but in FastAPI, that supports Mailgun, our third-party service. We're migration from Django to FastAPI for our API.
Describe the solution you'd like
Ideally, we want to be able to swap backends, like SMTP or Mailgun, but we might as well switch to a different provider in the future. So we want this to be easy.
What I like is that this project supports backends. However, I wonder what are your thoughts on supporting third-party backends, the same way django-anymail does. We oould provide an implementation of a Mailgun backend, heavily based on https://github.com/anymail/django-anymail/blob/main/anymail/backends/mailgun.py.
Describe alternatives you've considered
Alternatively, if you want to keep this project provider-agnostic, we could implement the Mailgun backend as a separate plugin. We would need a way to support external plugins.
Additional context
Add any other context or screenshots about the feature request here.

At the next release I will add a feature to add custom backend plugins with Fastapi-Mailman. Thanks for checking this out.


Added test to check for well-formed input element

In challenge Add Placeholder Text to a Text Field
added test:
"assert($(\"input[type=text]\").length > 0 && code.match(/URL\\s*\"\\s*>/g), 'message: The finished input element should have valid syntax.');"
which validates that the input element has a proper closing bracket

npm tests pass
total:     710
passing:   710
There seems to be many different ways of solving this problem, so I'm open to feedback. I'm not sure if this is a 'best practice' solution...
closes #7185

While not required it is valid HTML 5 to end a void tag like input with a /> like <input type="text" placeholder="cat photo URL" />, so this regex should be made to allow that pattern. Otherwise it looks good :smile:

@ltegman made the changes, it should work now

@NolanChan Sorry, one more thing I should have caught earlier -- it should be /URL\\s*[\"\\']\\s*\\/?>/gi to account for either single or double quotes. After that this will definitely be ready!

@NolanChan updated the pull request.

@BerkeleyFalse wow that's an interesting bot haha

:+1: Thanks!


[bug] Minio storage provider error: Handler crashed with error runtime error: invalid memory address or nil pointer dereference

It works for HTTPS (Minio served as HTTPS endpoint), but doesn't work for HTTP.
This issue may relate to: https://github.com/casdoor/oss/blob/515bf5ee9791dbab7a8c008c63aee59bb59d0605/s3/s3_test.go#L71
Need to set secure: false to support HTTP, but at the same time HTTPS won't work. So it should be set in if condition. Can change code here:
https://github.com/casdoor/casdoor/blob/ee5c3f3f39af3935d79498dab877e1a1d7fcf7c8/storage/minio_s3.go#L23-L36

Invalid issue


added enableHttpsWarnings configuration property

While local development it would be nice, that you can disable https warnings.
That's why I added a configuration property called "enableHttpsWarnings" which defaults to false

@dennismende Thanks, but now that I check into it, I'd prefer to follow what was done in https://github.com/simplabs/ember-simple-auth/issues/318

Are there any information about the status of such an implementation. All these warning are really annoying.

@dennismende I'll probably release a new version which includes the changes in b9537a2064d6f1607df180781a8ef8f780e45ce6 that removes the warning.

@dennismende v0.5.0 is out https://github.com/jpadilla/ember-cli-simple-auth-token/releases/tag/v0.5.0

Thanks


SNAP_CHANNEL = 'latest/edge' breaks deployment

Summary
SNAP_CHANNEL being pinned to 'latest/edge' has broken my deployment. My deployment depends on a specific Kubernetes version, particularly a K8s config with a token variable. The latest K8s has replaced that with private keys.
What Should Happen Instead?
A developer should be able to reliably deploy Microk8s without having to worry if the snap packages, and therefore Kubernetes version, changing unexpectedly.
Reproduction Steps

Deploy Microk8s charm before November 13 2023
Deploy Microk8s charm after November 13 2023

Environment
Ubuntu 22.04
MicroK8s charm track: latest/stable
Juju version: 3.3.0-genericlinux-amd64
Juju controller version: 3.1.6
Cloud: MaaS 3.3.4
Additional info, logs

Can you suggest a fix?
The MicroK8s charm should contain a variable to specify the version of the snap package to be installed, ie SNAP_CHANNEL. That way a developer can pin that in their deployment code.
Are you interested in contributing with a fix?
I can code something but probably can't test it well, because I don't have the setup or experience in developing Juju charms.

Hi @theNewFlesh, thank you for raising this!
It is not recommended (actually, it is actively discouraged) to deploy the charm for production use from the latest/edge channel. This is only reserved for bleeding edge features and may break at any time.
Instead, you should be installing the charm from the respective channel $version/stable. In this case, this would be
juju deploy microk8s --channel 1.28/stable

See also https://charmhub.io/microk8s?channel=1.28/stable for a list of available tracks. Thank you!

I am deploying latest/stable revision 62.

I will try deploying to 1.27/stable, and let you know if that works. Probably an oversight in the deployment code.

there is no 1.27 anymore... the snap exists... as do many previous versions, but its 1.28 or nothing it seems now from juju side since the version is also hard coded via constant we cannot change it unless we were to fork and DIY... the option to override "if you really want to" would be nice.

What is legacy/stable? Is that bound to a particular version? Or is it just current version minus 1?

legacy/stable is the previous charm version, for MicroK8s versions 1.27 or older. The Kubernetes version for that is configured through the channel option, similar to what you need. That way, you should not get any unexpected version changes.

That's helpful. Thank you.


feat: add cli engine

Types

[x] 🎉 New Features

Background or solution
add opensumi cli engine
Changelog
add opensumi cli engine

/publish

/publish


Tab interfaceName triggers schema error

Link to reproduction
No response
Describe the Bug
Setting an interfaceName on a tab and reusing that tab declaration triggers a schema error as follows:
/Users/seth/dev/backend/node_modules/graphql/type/schema.js:219
        throw new Error(
              ^
Error: Schema must contain uniquely named types but contains multiple types named "SyndicationsInterface".

I can confirm there are no naming collisions (unless I'm misunderstanding the usage here).
To Reproduce
Create a tab as follows:
{
    type: 'tabs',
    tabs: [
        {
            label: 'Syndications',
            name: 'syndications',
            interfaceName: 'SyndicationsInterface',
            fields: [ ...

Add this tab to 2 collections and attempt to start the development server.
Payload Version
2.5.0
Adapters and Plugins
db-mongodb bundler-webpack

Wondering if anyone has ideas for a workaround in the meantime? We use this interface in like 20 collections and I think not having it will lead to some serious GraphQL havoc.

BTW this seems to only be broken for tabs, if I convert my tab field to a group it works (though ruins admin UX 😉 )

@ssyberg we are looking at this now, hoping to have a solution to you ASAP


add volume-checker sample

the cloud run volume checker makes it easier for volumes users to check that their cloud run deployment has connectivity to the volume source, and that the volume contents are present in the running container once mounted.

Can you add a test Cloud Build file like: https://github.com/GoogleCloudPlatform/cloud-run-samples/blob/main/gcloud-report/tests.cloudbuild.yaml

added a cloud build yaml file that builds and pushes the image

/gcbrun


Add multi-namespace tests + periodic test designation

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Pull Request title is properly formatted: FAI-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting main: [0.3.x] FAI-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

/retest

/test trustyai-explainability-e2e

/test all

/test trustyai-explainability-e2e

/test trustyai-explainability-e2e

/test trustyai-explainability-e2e

/test all

/test trustyai-explainability-e2e


About the GPU memory footprint

Thx for your great work.
In the paper, you said " fully-vectorized implementation requires huge GPU memory – at least 45 GB for 320×320 input resolution with the base model of Swin-Transformer".
I'd like to know the 45 GB memory usage is whether for single GPU or for multiple GPUs in total?
Thx anyway.

Hello, It is for single GPU.

Thx for your quick reply.
Is there any way to reduce single GPU memory usage for fully-vectorized impl? Since our server is 16GB per GPU and 8 GPUs per node, can RankED be trained in DDP-style on our single node?

You can try with smaller input size (160x160 instead of 320x320) or smaller model ( swin-small/tiny instead of swin-base) , but this leads to performance drop.

I see, thx.


bad_alloc was found while trying to load Chem moduel in with Python import

x-posting from https://github.com/rdkit/rdkit/issues/7735
This is observed with 2024.3.3 package but doesn't appear in 2024.3.2 and older packages.
Full details available in https://github.com/rdkit/rdkit/issues/7735

I can't repo this on my ubuntu machine with python 3.12:
➜  chris ~ ipython
Python 3.12.3 (main, Jul 31 2024, 17:43:48) [GCC 13.2.0]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.17.2 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import accelerate
   ...: from rdkit import Chem

In [2]:

Might be related to your specific machine or setup.

@kuelumbus What's the ubuntu version?

24.03
(/usr/lib/aarch64-linux-gnu/libstdc++.so.6.0.30)
From https://github.com/rdkit/rdkit/issues/7735,  it seems like you are on aarch64 linux?

Closing this https://github.com/rdkit/rdkit/issues/7735#issuecomment-2307395225


Optional weekday for rfc2822

Given the following project:
# Cargo.toml
[package]
name = "time-test"
version = "0.1.0"
edition = "2021"

[dependencies]
time = { version = "0.3.34", features = ["parsing"] }

// src/main.rs
use time::{format_description::well_known::Rfc2822, OffsetDateTime};

fn main() {
    // ok
    OffsetDateTime::parse("Sat, 12 Jun 1993 13:25:19 GMT", &Rfc2822).unwrap();

    // thread 'main' panicked at src/main.rs:6:65:
    // called `Result::unwrap()` on an `Err` value: ParseFromDescription(InvalidComponent("weekday"))
    OffsetDateTime::parse("12 Jun 1993 13:25:19 GMT", &Rfc2822).unwrap();
}

According to the rfc:
https://datatracker.ietf.org/doc/html/rfc2822#section-3.3
Or the rfc 5322 which made rfc2822 obsolete
https://datatracker.ietf.org/doc/html/rfc5322#section-3.3
The abnf syntax is:
   date-time       =   [ day-of-week "," ] date time [CFWS]

I suppose your implementation make weekday require where it should be optional.

Definitely a bug. I'll get to this in the near future.

Fixed on main.


CTD-preNet-W32's model

I find that only BUCTD-preNet-W48's model Weights are available in the repository. Can you provide BUCTD-preNet-W32's model on COCO? I want to compare with your prenet-w32 model on the COCO dataset, but didn't have the time to train it again with your methods.

Hi, thank you for your attention. And sorry for this, we only trained the model BUCTD-preNet-W48 on COCO which is available online.


New Visualization: Testing per capita

As you know, it is really hard to truly compare confirmed infections region by region (e.g. state by state) as testing is so inconsistent. As a result, it would be really cool to see confirmed tests per capita and be able to compare that against confirmed cases.

#332 - Better description here, now in my queue.

Closed original ticket #332 by @danieldesignnomad  (thanks!) and working on this one.

A plot like this one would be nice. Made with data from http://covidtracking.com

@telesphorus and @mmorper -- we're doing this for v2.0 -- stay tuned.  We finished the database migration today.  We went from schema-on-read to having an ontology for the countries because the schema on read was brittle.  Subtle changes in the data sources would break big parts of the site.


font setting of theme is ignored

Godot version
v3.4.4.stable.official [419e713a2]
System information
macOS 12.3.1 (21E258)
Issue description
Creating a theme, which is set as the default theme inside the project settings, lets me change the font color of a button, but the setting for the font type is just ignored, even though the different font is visible in the preview.
Steps to reproduce

Create theme, set button font
Set theme as default in project settings
Add a button to the scene

Minimal reproduction project
bug_font.zip

Related to https://github.com/godotengine/godot/issues/48477 and https://github.com/godotengine/godot/issues/33902 (possible duplicate?).

This might've been fixed in 3.5

Yes, it was fixed in #55497


changing shape of polygon animation

Describe the Feature you want to end

i want to add this amazing changing shape polygon animation
Expected behavior

Screenshots (optional)

https://github.com/pranjay-poddar/Dev-Geeks/assets/120590200/12638388-e77d-4bb9-8696-975641142e6d
Additional context (optional )

@MohitGupta121 @TusharKesarwani please assign this issue to me

@MohitGupta121 @TusharKesarwani please review it i have raised the pr


Could not found page of MVC patten

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

Please check it: Setting up a Node development environment

The problem is in the part of 'Express development environment overview', the third paragraph of 'What is the Express development environment?'. Clicking the MVC patten page and it shows could not found. May you guys fix it.
Thanks.

Ah yes. I deleted that article last week because it is getting very out of date, and very few people are looking at it. I moved the useful content to https://developer.mozilla.org/en-US/docs/Glossary/MVC, so I've linked to that instead.


Grafana enterprise 7.0.0

Microsoft Reviewers: Open in CodeFlow

Took forever to progress but Microsoft has confirmed it as non malicious:


Why force VSCode users to use SQLite?

VSCode is available on Windows, and SQL server runs on Dockers and Linux? Why does the documentation not explain how to connect to a local (or remote) SQL Server instance using VSCode? I don't want to use SQLite, and the documentation here is trying to force me to use something else (which isn't even a MS product). The Visual Studio Documentation is useless for trying to implement to VSCode, meaning I have to figure it out myself.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03221075-5dfa-d1b6-0552-3fe88abe1d03
Version Independent ID: b8c7d824-35ca-68fb-e3be-839ae886657c
Content: Work with a database and ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/sql.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@LarnuUK  thanks for the comment. We document ASP.NET Core, not SQL. It's just a matter of changing the connection string.

If you're on Windows, why not LocalDB?

I'm not on Windows, hence my comment about Docker and Linux. I know how to use SQL, but I'm brand new to ASP.Core, and, unfortunately, the document gives me no details on how to connect to SQL Server. That isn't a SQL issue, that's a problem with the Document. I know very well how to use SQL Server; I specifically don't want to learn a different RDBMS and why this document confuses me.


Expose a -Class <string[]> parameter for Export-ModuleMember

Summary of the new feature / enhancement
I would like to have the ability to export class definitions in a module as a means to automatically expose access to it.  Something like:
class MyClass{
   $MyMember1
   $MyMember2
}

export-modulemember -Class MyClass

The goal is to avoid having to pepper my scripts with explicit "using " directives in my scripts/code
Proposed technical implementation details (optional)
No response

Duplicate of #12533

Thanks for the report! We're tracking this in the issue above, consider giving it a thumbs up!


Reformat the source code

I'd like to get feedback about reformatting entirely the source code which I think would be beneficial for these reasons:

Quite often when a PR is submitted to Param it includes a few format changes (either because this is done automatically by a code editor or because the developer couldn't resists "fixing" the format of the code surrounding their changes). This is not ideal for the sake of git history and doesn't help code reviews.
I've opened two issues about improving the docstrings (https://github.com/holoviz/param/issues/588) and adding type hints to the source code (https://github.com/holoviz/param/issues/589). These changes if they happen (specially the second one) would touch a lot of code lines, I'd prefer this to be done on a clean basis, after reformatting (and to avoid what is mentioned in 1.).
Param has linting enabled except that it's pretty loose! Linting is of a good help when writing code (at least to me), reformatting the source code would allow to remove most (if not all!) of the ignored exceptions listed below. I'd also like to see the tests being reformatted and linting applied to them.

[flake8]
# TODO tests should not be excluded (one day...)
include = setup.py param numbergen
exclude = .git,__pycache__,.tox,.eggs,*.egg,doc,dist,build,_build,tests,.ipynb_checkpoints,run_test.py
ignore = E114,
         E116,
         E126,
         E128,
         E129,
         E2,
         E3,
         E4,
         E5,
         E731,
         E701,
         E702,
         E703,
         E704,
         E722,
         E741,
         E742,
         E743,
         W503,
         W504,

And here are a few points against reformatting the source code, with my opinion:

The maintainers of Param may be used to how the source code looks and feels and don't want to see it changed not to disturb them or slow them down. Well this is a tradeoff, potential contributors to Param could also be disturbed and slowed down by how the source code currently looks and feels.
Parameters of a Parameterized class are usually declared following a common style (not described anywhere to my knowledge) that gets messed up when an automatic code formatter is executed. While I think this could be a problem for a large source code like Panel (although that's debatable) this would here affect only numbergen. I think the number of people who read numbergen's code is pretty low, even more so now that it is documented.
Reformatting the source code will touch a lot of code lines and thus have an impact on git history/blame. Yet I believe it is healthier if it happens in one go, instead of slowly at each new PR.

Are we talking reformatting using Black? Then I'm all for it. Would make my life a lot easier.

I have no strong opinion about using black or another tool. I think that if this is ultimately done, the code formatter could be added as a pre-commit step to avoid drifting.
I also prefer a longer line length than the one recommended by PEP8.

I'm happy for the Param source code to be reformatted in some consistent style, and happy for that to be done using Black with line length 100. Black should work fine for Param's own source code, but for libraries using Param extensively (as you note for numbergen), we'd have to figure out how to trick Black into having a reasonable formatting for parameter declarations (perhaps by postprocessing?). Luckily that's a separate issue.
Regarding your anticipated objections,

Current Param maintainers primarily work on other projects, only very rarely needing to change Param itself. So we don't have strong internal models of Param's formatting, and find it just as annoyingly inconsistent as you do.
Numbergen changes almost never, so we could either not mess with the numbergen files (it's a separate module, after all) or else do a one-time automatic formatting of the numbergen module but manually leaving the parameter declarations formatted as they are now.
Agreed; a single reformatting PR is better than reformatting changes in every PR.

Nice to hear this positive feedback! I know code formatting can be a sensitive topic among developers so I was just being careful ;)
As for formatting numbergen I could apply black once and then fix the Parameter formatting manually. Then, if black ends up as part of Param's CI (run by pre-commit for instance) numbergen would be excluded from the files collected by black, since as you say its code almost never changes.
I've sampled some Parameter definitions from numbergen below:
    lbound = param.Number(default=0.0,doc="inclusive lower bound")

   time_dependent = param.Boolean(default=False,  doc="""
       Whether the given time_fn should be used to constrain the
       results generated.""")

    random_generator = param.Parameter(
        default=random.Random((500,500)), doc=
        """
        Random state used by the object. This may may be an instance
        of random.Random from the Python standard library or an
        instance of numpy.random.RandomState.
        This random state may be exclusively owned by the object or
        may be shared by all instance of the same class. It is always
        possible to give an object its own unique random state by
        setting this parameter with a new random state instance.
        """)

    mean = param.Number(default=0.0, doc="""Mean value""")

    choices = param.List(default=[0,1],
        doc="List of items from which to select.")

Their formatting, in particular the doc attribute, isn't consistent. What's the recommended format?
On black, I'm not sure there's a way to trick it, from what I know it's not so configurable. We could have a preprocessor that adds fmt: skip to each Parameter declaration to have it ignored by black. Or as you say a postprocessor that reformats Parameter declaration as we want. If it does exist, maybe such tool could live in Param itself.

I don't think Black itself is configurable to do it; it's designed not to be, which is generally not a bad thing but in this case highly inconvenient. We don't currently have a postprocessor, but my preferred format if it's achievable would be, for these examples:
    lbound = param.Number(default=0.0, doc="""
        Inclusive lower bound""")

    time_dependent = param.Boolean(default=False, doc="""
       Whether the given time_fn should be used to constrain the
       results generated.""")

    random_generator = param.Parameter(default=random.Random((500,500)), doc="""
        Random state used by the object. This may may be an instance
        of random.Random from the Python standard library or an
        instance of numpy.random.RandomState.
        This random state may be exclusively owned by the object or
        may be shared by all instance of the same class. It is always
        possible to give an object its own unique random state by
        setting this parameter with a new random state instance.""")

    mean = param.Number(default=0.0, doc="""
        Mean value""")

    choices = param.List(default=[0,1], doc="""
        List of items from which to select.""")

Here I didn't try reformatting anything for a particular line length, which would follow whatever is enforced on the rest of the file.

Just saw that Github can now ignore commits, which could be relevant if a big reformat is done.
https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view


Bulk Byte to Short Map Converter

Added a way to Convert maps from Byte to Short in a Bulk format

Sorted sorry about that I thought I removed all the prints


Finish telemetry PR

see https://github.com/superfluid-finance/superfluid-sentinel/pull/186#pullrequestreview-1629946257

provide endpoint
create report in prometheus format
add default config & docs

Changes implemented.
A reverse proxy was added to the pre-existing prometheus push gateway, providing us with a nice URL.
The identifier was solved with a random uuid. Since prometheus uses a system of multiple labels per metric, we can leave that persistent - multiple instances per instances are well covered due to the addition of chain_id as label.
Instead of converting the health report, a custom report is generated for telemetry.
That's because we don't need that much data, and because that structure isn't nicely mappable to prometheus format despite GPT claiming so.


replace unicode control chars as they can't be parsed by YAMLParser

The randomized field names may contain Unicode characters. YAMLParser is skipping these control characters during serialization/deserialization that we are doing in testFromXContent test case.
Randomized field name: "æÆ\u0000¢¡Èýñ«Ò"
Parsing fromXContent: "æÆ ¢¡Èýñ«Ò"
Space replaces the control character NUL, leading to the test case failure.
issue-ref: https://github.com/opensearch-project/OpenSearch/issues/6411#issue-1593545979

3. Add an entry to CHANGELOG.md[2] in unreleased 2.x section (as we will backport this to 2.x) if not @andrross will chase you.

We can skip the changelog for this test-related change. I've added the label.

Codecov Report

Merging #6486 (ca10044) into main (8bda365) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main    #6486   +/-   ##
=========================================
  Coverage     70.77%   70.77%
- Complexity    59092    59143   +51
=========================================
  Files          4802     4802
  Lines        282968   282970    +2
  Branches      40793    40793
=========================================
+ Hits         200267   200282   +15
- Misses        66239    66253   +14
+ Partials      16462    16435   -27

Impacted Files
Coverage Δ

...n/java/org/opensearch/test/OpenSearchTestCase.java
84.76% <100.00%> (+0.05%)
:arrow_up:

...java/org/opensearch/client/indices/DataStream.java
0.00% <0.00%> (-76.09%)
:arrow_down:

.../opensearch/client/indices/CloseIndexResponse.java
17.50% <0.00%> (-60.00%)
:arrow_down:

.../java/org/opensearch/node/NodeClosedException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

.../index/shard/IndexShardNotRecoveringException.java
0.00% <0.00%> (-50.00%)
:arrow_down:

.../search/aggregations/pipeline/HoltLinearModel.java
20.33% <0.00%> (-35.60%)
:arrow_down:

...ensearch/client/indices/DetailAnalyzeResponse.java
20.54% <0.00%> (-34.25%)
:arrow_down:

...rch/client/transport/NoNodeAvailableException.java
42.85% <0.00%> (-28.58%)
:arrow_down:

.../java/org/opensearch/index/reindex/RemoteInfo.java
50.45% <0.00%> (-28.45%)
:arrow_down:

...ndex/seqno/RetentionLeaseBackgroundSyncAction.java
37.50% <0.00%> (-26.79%)
:arrow_down:

... and 481 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Fixed the gradle check @saratvemulapalli. Please review.


Recursive Entities behave different when calling ToList or FirstOrDefault.

Steps to reproduce
Open project at https://github.com/shawnwildermuth/RecusiveEFQueryBug and go to /api/employees and /api/employees/1 and see the different behaviors.
The issue
I have a self-referencing entity:
  public class Employee
  {
    public int Id { get; set; }
    public string FirstName { get; set; }
    public string LastName { get; set; }
    public string EmployeeNumber { get; set; }
    public bool Active { get; set; }
    public DateTime HireDate { get; set; }
    public DateTime ExitDate { get; set; }

    public ICollection<Address> Addresses { get; set; }

    public Department Department { get; set; }

    public Employee Manager { get; set; }
    public ICollection<Employee> Reports { get; set; }

  }

When I query it with .ToList() and include the self-references field (e.g. Reports) it works find down the hierarchy (hurrah!), but if I do the identical query with .FirstOrDefault() it stops at one level of recursion. For example:
This gets the entire hierarchy:
      var emp = _ctx.Employees
        .Include(e => e.Reports)
        .ToList();

This get's only one level of hierarchy:
      var emp = _ctx.Employees
        .Include(e => e.Reports)
        .Where(e => e.Id == id)
        .FirstOrDefault();

I can work around it for now by:
      var emp = _ctx.Employees
        .Include(e => e.Reports)
        .ToList()
        .Where(e => e.Id == id)
        .FirstOrDefault();

But obviously that is going to load a lot of employees and filter down to the specific one so it's going to be very inefficient.  Is this expected behavior?
Further technical details
EF Core version: (found in project.json or packages.config) 1.0.0
Operating system: Windows 10 Ent
Visual Studio version: (e.g. VS 2013 or n/a) VS 2015
Other details about my project setup:

@shawnwildermuth - This behavior is due to tracking nature of query. In the first query, you are querying for all the employees. Since it is self-referencing relationship and results are being tracked, all the navigations will be fixed up. Hence you see Reports populated down the hierarchy. That query should give same results even without Include.
In the second query, since you are querying for only first record, EF will fetch only 1 employee & associated Reports due to include. But since data down the hierarchy is not loaded from database to memory, the navigations will be null. You need to use ThenInclude for subsequent levels.


interface charges

Is it possible to apply interface condition in the presence of interfacial charges, which according to Gauss law is

?
I read the manual about interface equation but still cannot figure it out.
It seems that interface equation supports integration of flux term but description is not very clear and I cannot find any examples for it.
I guess I have to use PotentialEdgeFlux, which is Permittivity * ElectricField, to set up the interface model?
Any help is appreciated.

I have the same problem

Hi:
Juan has created a forum for Devsim in https://forum.devsim.org/.  So we can discuss its usage in this forum.
I have a solution for the interface charge. You can create a charge node model on one side of the interface and set the concentration decreasing exponentially with depth. Then you should keep the integration of bulk charge equal to the surface charge.
Hope this will be useful.

Hi:
Thanks for your reply, can you show me your code about this section?
thank you!
At 2021-07-15 22:07:57, "ythran" @.***> wrote:
Hi:
Juan has created a forum for Devsim in https://forum.devsim.org/. So we can discuss its usage in this forum.
I have a solution for the interface charge. You can create a charge node model on one side of the interface and set the concentration decreasing exponentially with depth. Then you should keep the integration of bulk charge equal to the surface charge.
Hope this will be useful.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

You would need to add a node model component to the equation on one side of the interface for the potential equation.  This is similar to adding a doping to the semiconductor.  If you want to add a surface density you would need to scale it by SurfaceArea/NodeVolume.  This is since the equation command will integrate the charge with respect to NodeVolume.
If you would like to discuss this further, please create a topic on the forum.

@tcaduser
Thank you for the reply.
I have just implemented fixed interface charges according to your advice by creating a node solution, setting the the interface values as surface density scaled by SurfaceArea/NodeVolume and adding it to the RHS of Poisson equation.
Here is my implementation for users facing the same problem:
def set_interface_charge(device, interface, name, value):
    area_name = "SurfaceArea"
    vol_name = "NodeVolume"
    region_list = devsim.get_region_list(device=device, interface=interface)
    for region in region_list:
        values = list(devsim.get_node_model_values(device=device, region=region, name=name))
        edge_list = devsim.get_element_node_list(device=device, region=region, interface=interface)
        node_list = numpy.unique(numpy.array(edge_list, int).flatten())
        surf_area = devsim.get_node_model_values(device=device, region=region, name=area_name)
        node_vol = devsim.get_node_model_values(device=device, region=region, name=vol_name)
        for node in node_list:
            values[node] = value * surf_area[node] / node_vol[node]
        devsim.set_node_values(device=device, region=region, name=name, values=values)

devsim.node_solution(device="device", region=region1, name="InterfaceCharge")
devsim.node_solution(device="device", region=region2, name="InterfaceCharge")
set_interface_charge("device", interface_name, "InterfaceCharge", 1e10)
RHS = "-ElectronCharge*kahan4(Holes, -Electrons, NetDoping, InterfaceCharge)"

Can the interface charge density be set time-varying? For example, the charge density is about the electric fields at the interface.

Can the interface charge density be set time-varying? For example, the charge density is about the electric fields at the interface.

You would need a model for interface charge density with respect to other solution variables.  You can also add a time dependent trap continuity equation.  A dependence on electric field could potentially be done with an edge or element edge model, as described here:
https://doi.org/10.1109/TED.2021.3094776
Do you have a specific model in mind?

I have a special interface model whose equation is different from the bulk equation. In my application, what's more, the equation at the two side of interface is different.  In my mind, the quantity of interface conditions for a two order partial differential equation should 2 conditions. In your software, I only find a condition setup, I guess the another condition is integrated by the bulk equation. So my mind is right? Can you have the solution to solve my demand? Thank you!

I am sorry if I did not follow up on this issue with you before.  I hope you found a solution.


Fix erroneous context canceled errors

When per-try timeouts are enabled, the context can only be canceled
after the body has been read and closed.  Our tests missed this due to
very small response body sizes that fit in the transport's read buffer.
Made NoClosingBytesReader internally available.

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

Fixes https://github.com/Azure/azure-sdk-for-go/issues/17780


Updating Test Flow

adjusting the test-app flow to edit comments by the bot once made, with timestamps in UTC, as well as creating a deployment status with the link.

Great, starting from that link, I can put a link to an edited version back without having to login or create a project.


Main activity back press is not working.

Is the bug present in the demo Chat SDK project?
Yes

What modifications have you made to the Chat SDK?
Nothing.

Android Version:
11

Steps taken to reproduce the problem:
Sign in -> main activity launches. Press back button.

Expected result:
Back button should work.

Actual result:
It is on the same page.

Comments:
On another note, I also checked with allowBackPressFromMainActivity = true. Not working as expected.

Hi @nur-shuvo if set allowBackPressFromMainActivity = true with the default configuration, the app will just load the splash screen and immediately reload the main activity. This is the expected behaviour because we don't want users to be able to click back and go to the login screen accidentally.
That setting exists in case you want to launch the main activity from another activity and you want it to be possible to click back.
If you want it to behave differently, you would need to either make your own splash screen or override the main activity and launch a new activity when back is pressed.

Hi, @bensmiley Thanks for your quick response.


Adding query parameters in the url crashes the UI

Bruno Version: 0.6.1
OS: Mac OS 13.2 (M1 Pro)
When adding query parameters like '?' or '&' to the URL the UI turns totally white.
After Reloading it says, that the Collection is still open, but there is nothing visible.
Adding the query parameters in the bru file and executing it with Bruno works totally fine

Hey @Lordi999 !
This issue has been fixed in the latest version of the app.

Oh. Thx :D
quickly updating

Hey @Lordi999
We just released v0.9.0
We have simplified the language greatly. Checkout the docs
After downloading, and opening an api collection repo, it will automatically take care of converting the old format to new format.
Let me know if you face any issues, happy to help.


Eliminated 15-minutes hang after completing mesos/mesos-modules cmake.

This speeds up mesos and mesos-modules Windows build scripts by 15 minutes each.
Corresponding DC/OS tickets (required)

D2IQ-67207 Windows builds of Mesos and mesos-modules on DCOS OSS hang for 15 munutes after cmake exit.

@mesosphere-mergebot changelog-not-required ci change

@mesosphere-mergebot label Ship It


Added Agnes Scott

Adding another line of data

@eculler I added Agnes Scott College to the hometowns.csv file.


Commands v2

Description

Introduce a V2 implementation of CommandObject and SubcommandObject.
Provide EventEntities<T> with @Nonnull entries for reduced null checks.
Remove SubcommandPassthroughObject.

Type of change

Enhancement

How Has This Been Tested?

Tested locally.

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code appropriately, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Need to document all todo's as issues or some other manner of tracking as they are out of scope of this PR.


Support C4 instances types

Fixes: #91.
Ignore the last commit, if you just want to see the code changes.

:+1: Looks good! Merge?

The new table is available here for anyone who wants to check it right now: https://rawgit.com/stefanor/ec2instances.info/c4/www/index.html

Thanks for this! Will get it merged in shortly


Chat cards from Damage Log styling with Dorako UI enabled

Chat cards from the module "Damage Log" are normally color-coded red (for damage taken) and green (for healing), like this:

With Dorako UI enabled, the cards all look the same, making it less convenient to distinguish at a glance, like this:

I took those screenshots in a fresh world to make sure there weren't any other modules at play.
Is it possible to have an option to allow those chat cards to keep their original styling?  Or could there be some styling for them that fits the Dorako style, but still maintains some distinction between damage and healing log cards?

Fixed for next release


Many warnings in Xcode15

Thank you for providing this repository.
My team uses GoogleTagManager.
The way to install it is in Package.swift.
https://dl.google.com/firebase/ios/tagmanager/swiftpm/7.4.0/GoogleTagManager.zip and using binaries via Carthage.
We used to have no problem with that, but since switching to Xcode15, we are getting warnings at build time.
The specific warnings are as follows
Mixed ObjC ABI, /Users/me/Library/Developer/Xcode/DerivedData/MyProject-fmtasuxvuqiklbbmnyuervvwdwzl/Build/Products/Dev- iphonesimulator/GoogleTagManager.framework/GoogleTagManager[x86_64][3](GoogleTagManager-dummy.o) compiled with category class properties

We get about 30 of these warnings.
We have been able to temporarily address this with the following

Remove -ObjC from OTHER_LDFLAGS in Xcode build settings.
Since we are using CocoaPods, remove -ObjC from the xcconfig generated by Cocoapods as well.

Due to a problem with CocoaPods, it resets every time you run pod install.
I didn't have this problem until Xcode14, so if this can be addressed on the GTM side, it would be very helpful.
Best regards.

@tsunghung any update on this? The new iOS SDK will be mandatory in April 2024.

FYI: https://forums.developer.apple.com/forums/thread/740231
Could you please try the following solution instead of removing -ObjC? Thanks.
https://stackoverflow.com/questions/77200555/when-i-update-to-xcode15-i-get-lot-of-warnings-mixed-objc-abi-xxx-compiled-w

Also, GoogleTagManager 7.4.4 has been released. Please try to use the latest binary instead, thanks.
https://dl.google.com/firebase/ios/tagmanager/swiftpm/7.4.4/GoogleTagManager.zip


RequestNextFrameRendering on OpenGL Control partially drawn

Describe the bug
For an OpenGLControlBase-derived control, calling RequestNextFrameRendering causes the rendered scene to only be partially drawn (a subset of the draw calls, or only the left side of the bitmap, it seems). Causing a re-render via a window resize paints successfully.
To Reproduce
I've got a class derived from OpenGLControlBase in Avalonia 11.0.9, running on WIndows with Avalonia.Angle.Windows.Natives <IP_ADDRESS>3020321.
My program setup includes  .With(Win32PlatformOptions(RenderingMode = [Win32RenderingMode.Wgl]))
Sample code: https://github.com/marklam/AvaloniaOpenGLPointCloud
I'm rendering two point clouds (actually arranged in planes at the moment) and a wireframe cube in my OnOpenGlRender override (ignoring fb and using the GlInterface passed during OnOpenGlInit)
When mouse interaction changes the model transform, I request a new render by calling RequestNextFrameRendering()
The strange paint problem I'm seeing is that as the mouse drags, some of the re-renders are missing bits (either half of one of the point clouds, or an entire cloud, or the wireframe cube).
The really weird bit is that if I stop the drag operation on a badly drawn frame, and then resize the window, the calls to my OnOpenGLRender will show the full scene.
In my real app, not the sample app, I'm checking all the OpenGL return codes, and RenderDoc doesn't show anything strange.
Expected behavior
The image should  draw fully in response to the RequestNextFrameRendering when handlng mouse moves, as it does when the app window is resized.
Screenshots
In the attached animation, the messages in the console window "OnOpenGLRender" shows the render calls, in response to the transform changing (and RequestNextFrameRendering being called) or Avalonia's redraws from the window resizing.

Environment

OS: Windoss 11
Avalonia-Version: 11.0.9

Additional context
Tried with nvidia and intel graphics cards.

I've added an OpenTK version (no Avalonia) to the above repo, and it doesn't have the flicker.

I've also switched the Avalonia project to use OpenTK for the bindings, it still exhibits the flickering. So it definitely seems to be a diffrerence between OpenTK's GameWindow and Avalonia's OpenGLControlBase.

Please check if it happens with ANGLE-backed OpenGL ES. WGL mode is experimental and isn't really supported.

I've created an 'angle' branch  but I can't persuade Angle to draw anything for the point clouds, so it doesn't help. I've added GL Debug logging and error checks and Angle isn't complaining about anything.
I'm not sure what the problem is with the point arrays.

I made the shaders compatible with Angle, and they still draw the points OK under Wgl
I can either have no 'cube' drawn, or a solid cube because GLPolygonMode isn't resolved under Angle, even with OpenTK 5 pre-release.

So all I can get from the Angle version is a blank screen because the clouds don't render, or a solid cube which doesn't exhibit the problem (probably because there's no point clouds being drawn)
The solid cube under Angle doesn't flicker, but nor does just-the-cube under Wgl so without the point rendering it's not telling me anything.

Just in case, try calling glFinish before exiting from OnOpenGlRender

That fixes it (the Wgl flicker, which was my initial problem)!
You're the remote-debugging wizard (and I get the clown nose).

It's probably a problem on our side, will need to read more on context sharing.


Improve validation of slash command/option names

Summary
This PR improves the error message for invalid command names, and adds validation for option names.
Checklist

[x] If code changes were made, then they have been tested

[ ] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running pre-commit run --all-files

[ ] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Thanks!

seems like an unnecessary change though (since the function's only being used once)

It's now being used for option name validation as well, and #269 uses it in a few additional locations (suppose I could've mentioned that here as well)


Too bloated for being a simple site with a simple goal

This issue should serve as a tracking point for whomever is willing to improve the website ending HTML and the way it is styled.
By cold analyzing the HTML in the final domain I noticed the following things:
-> Google Analytics ( really? I mean, which kind of business use case you can have around it? )
-> Styles as Javascript: this can be HEAVILY improved by just swapping a class on the body and style at your own pleasure
-> CSS not cachable: how often will it be changed that has to be served on the HTML page? Can't it be a separate file?
Thank you in advance and I hope you get this issue as a constructive one. I may also later come up with a PR adressing the following issues.
Best regards,
Julian

I agree, Google Analytics is very bloated, but stays for the time being as it is a project requirement. I do plan on replacing it with a lighter weight and less invasive solution.
While changing styles in Javascript is a code smell, it isn't a big deal in a project of this size as only two elements are modified. Although, I would entertain the change.
The CSS/JS/HTML are 2.5KB total loaded and fetched / cached as a single resource. I don't see an issue with this. Separating the CSS would allow for it to be cached separately but would slow down how fast the site loads and renders by forcing the browser the download and parse the HTML before requesting the CSS, blocking the page from rendering until it had loaded. See Render Blcoking CSS and Ultrafast Loading of CSS for more information.
If bloat is the biggest concern, the biggest returns would be GA (42KB) SVGs (4.7KB each), the Favicon is (3.2KB).

Hi,
sorry for my late reply. I see a valid point in your reply.
I'll stay tuned for further optimizations, and I'll close this issue meanwhile.
Best regards.

As much as I want to know how many users I'm getting, I'd rather not have google farming users data.
Reopening to remove google analytics.

Resolved by 4830adf


Fix RTN15c3

Discussion #612

@ricardopereira could you address the minor feedback and release a fix?  It would be good if this fix is applied to 0.8.* if easy.

@mattheworiordan Ok but isn't this an issue only for 1.0? It's about the reattach feat.

@mattheworiordan Ok but isn't this an issue only for 1.0? It's about the reattach feat.

Yes, apologies, good point.


Multiple documents not supported in percolator query

Which version of Elastic are you using?
[ x  ] elastic.v6 (for Elasticsearch 6.x)
Percolator queries in 6.x support multiple docs, for example https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-percolate-query.html#_percolating_multiple_documents
This function does not exist
func (q *PercolatorQuery) Documents(docs []interface{}) *PercolatorQuery

@olivere Thanks a bunch!


Request Makefile be modified to allow arguments to curl

One of the computers I use sits behind a firewall that causes curl to fail when it tries to retrieve robot.jar. I request line 78 of Makefile be changed from:

curl -L -o $@ https://github.com/ontodev/robot/releases/download/v1.8.4/robot.jar

to:

curl -L -o $@ $(CURL_ARGS) https://github.com/ontodev/robot/releases/download/v1.8.4/robot.jar

With this change, I can invoke make as follows:

$ make CURL_ARGS='--ssl-no-revoke --insecure'

@swartik I'll run this down (and also respond to your other helpful recent notes) when I have a minute (might be this weekend); don't want you to think I'm ignoring you.
Very appreciative you digging into this btw; excellent feedback sir.


The webpage documents make my computer stuck

Thanks for the excellent documents.
My issue is that there are too many videos on the Trainer and LightningModule documents. Every time I open one of these two pages, my PC is stuck, running out of CPUs  to load these videos.
Would you please improve this? : ) Thanks.
cc @borda @rohitgr7 @akihironitta

I remember there was a similar issue reported before. We had larger ones before, but @kaushikb11 replaced them with smaller ones that we currently have in the docs (e.g. https://pytorch-lightning.readthedocs.io/en/latest/common/trainer.html).
I'm in favour of removing all video embeddings and having links to YouTube videos (not embedding!) instead.

I believe we have compressed them already, but feel free to reopen if the issue preserves... :rabbit:


Long Branches

Hi

How can I fix the long Branching?

git branch --unset-upstream master doesn't sound like a complete resolution to the symptoms called out by Mohammad and Jeremy. Is there any more info needed to reconcile this, or should we mark it as 'wontfix'?

Definitely not a satisfactory resolution, but I'm closing for now... If past or future visitors are able to provide more info maybe we can figure it out?


What about merging with development-guide?

Would be great to have this as part of https://github.com/18F/development-guide -- the description of that repo is "A set of guidelines and best practices for an awesome engineering team" and the description of this repo is "Place to collect research and thoughts toward, and then hold, 18F code style guidelines." -- seems like there is some overlap there.
what are peoples' thoughts?

makes sense to me

+1 on having this be a part of the dev guide.

any thoughts on this, @ertzeid ?

Overall, yes. But there's also a push for every working group to have a repo that at the very least has an .about.yml file describing what it does. I'm happy for this repo to simply be that, plus a README saying that all content made by the working group goes into the dev guide.

OK that works! I've been wanting to suggest some Ruby guidelines but wanted to wait until we'd resolved this issue.
Also, since we have some projects that cannot have an about.yml because 18F does not have access to their GH repos, we have the data-private repo as a secondary place to hold project data. I wonder if we should / could do the same for working groups. Seems like a lot of overhead to have an entire repo if someone only needs it for a single file.

I'll bring that up with the hub/team_api/etc. team. I think part of the
reason to follow the repo-with-about.yml-file pattern is because
data-private keeps the project info off of any public site?
On Tue, Dec 15, 2015 at 6:35 PM, Jessie A. Young<EMAIL_ADDRESS>wrote:

OK that works! I've been wanting to suggest some Ruby guidelines but
wanted to wait until we'd resolved this issue.
Also, since we have some projects that cannot have an about.yml because
18F does not have access to their GH repos, we have the data-private repo
as a secondary place to hold project data. I wonder if we should / could do
the same for working groups. Seems like a lot of overhead to have an entire
repo if someone only needs it for a single file.
—
Reply to this email directly or view it on GitHub
https://github.com/18F/code-style-guide/issues/1#issuecomment-164930334.

Ok. I'd like to keep this repo for:

.about.yml file
issues to be handled by the Workgroup (to keep them easy to find)

... And then note in the README that actual style guides are located in 18F/development-guide
Thoughts?

I have a vision for the future where there are super active issues /pull requests sections on development-guide where we discuss any and all things related to development.
Coding style guides could be part of that and I think it would be cool if they were. But your call!


Configure versioning for application repo

Do not assign a story-point value to this task
What needs to be done
Configure automatic versioning based on commit messages
Out of scope
Publishing assets, only configure tagging on the repo

Re-opening as the process is broken


Support rename for enum member used as type

This fourslash test fails currently:
/// <reference path="fourslash.ts"/>

////enum E { [|A|], B }
////type T = E.[|A|]

let ranges = test.ranges()
for (let range of ranges) {
    goTo.position(range.start);
    verify.renameLocations(/*findInStrings*/ false, /*findInComments*/ false);
}

There is no problem when using E.A as a value.

Closed by #15743.


How to apply @inheritDoc tag to all classes without inheriting the @deprecated tag from parents

Search terms
inherit doc inheritdoc custom plugin
Question
How can I add the inheritDoc jsdoc comment inside a custom plugin, unless the class is already marked as deprecated? Additionally, I don't want to inherit @deprecated tags from parent classes because sometimes we deprecate a specific class/interface, however it's children are not deprecated. I currently have this code inside application.converter.on(Converter.EVENT_CREATE_DECLARATION) and even though it logs that it's adding @inheritDoc to classes, when I actually build the app none of the classes it said it added to are inheriting.
if (reflection.kind === ReflectionKind.Class) {
  const commentTag = new CommentTag("@inheritDoc", []);
  if (reflection.comment) {
    const isDeprecated = reflection.comment.blockTags.find(
      (tag) => tag.tag === "@deprecated"
    );
    const parent = reflection.parent;
    if (parent && checkParentIsDeprecated(parent)) {
      // no-op
    } else if (!isDeprecated) {
      console.log("Adding comment tag for", reflection.name);
      reflection.comment.blockTags.push(commentTag);
    }
  } else {
    const parent = reflection.parent;
    if (!parent || !checkParentIsDeprecated(parent)) {
      // No comment already existed, add a new comment with `@inheritDoc` tag
      reflection = new DeclarationReflection(
        reflection.name,
        ReflectionKind.Class,
        reflection.parent
      ).comment = new Comment(undefined, [commentTag]);
    }
  }
}

This is in reference to an open source project, you can find the PR trying to implement this here

TypeDoc has a Reflection.isDeprecated method to check if a reflection or any of its parents are deprecated. (note: The .parent does not refer to parent classes. It refers to the reflection containing this class, which will be some module/namespace, if you want to check parent class you want the .extendedTypes)
Your PR title "Inherit class properties from parent classes" is confusing, as TypeDoc will do that without @inheritDoc...
reflection = new DeclarationReflection(
        reflection.name,
        ReflectionKind.Class,
        reflection.parent
      ).comment = new Comment(undefined, [commentTag]);

This is going to do very bad things. Creating a new reflection requires that the reflection be registered with the project so that it can be linked to. You also don't actually want to do this here, the reflection already exists.
A few things to consider:

Doing this check at EVENT_CREATE_DECLARATION is too early. The parent class might not have been converted yet if the child is exported from a module in such a way that it is processed first. You should instead perform this check on EVENT_RESOLVE_BEGIN with a high priority so that it happens before @inheritDoc resolution.
If the parent class is deprecated, and the child class doesn't have a comment, you need to add a comment so that TypeDoc doesn't implicitly inherit the comment from the parent class, thereby marking the child class deprecated.
TypeDoc has an isDeprecated method which checks for @deprecated on the class + its parents (.parent)
@inheritDoc is kind of an ugly method because what it does depends how it is formatted in an attempt by TypeDoc to support both TSDoc and JSDoc style comments... if you know what you want, it might be better to copy the comment (or pieces of the comment) rather than telling TypeDoc to do it.

With this in mind, I think something like the following does what you want:
// @ts-check
import td from "typedoc";

/** @param {td.Application} app */
export function load(app) {
    app.converter.on(td.Converter.EVENT_RESOLVE_BEGIN, addInheritDoc, null, 1000);
    app.converter.on(td.Converter.EVENT_RESOLVE_BEGIN, () => {
        // In case we're running in watch mode, we should clear these to avoid leaking memory.
        isDeprecated.clear();
        visited.clear();
    });

    /** @type {Set<td.Reflection>} */
    const visited = new Set();

    /** @type {Set<td.Reflection | undefined>} */
    const isDeprecated = new Set();

    /** @param {td.DeclarationReflection} refl */
    function getParentClass(refl) {
        for (const type of refl.extendedTypes || []) {
            const ref = type.visit({
                reference(ref) {
                    return ref.reflection;
                },
            });
            if (ref) return ref;
        }
        return undefined;
    }

    /** @param {td.DeclarationReflection} refl */
    function needsVisit(refl) {
        if (visited.has(refl)) return false;
        for (const type of refl.extendedTypes || []) {
            if (
                type.visit({
                    reference(ref) {
                        return ref.reflection?.kindOf(td.ReflectionKind.Class) && !visited.has(ref.reflection);
                    },
                })
            ) {
                return false;
            }
        }
        return true;
    }

    /** @param {td.Context} context */
    function addInheritDoc(context) {
        const allClasses = /** @type {td.DeclarationReflection[]} */ (
            context.project.getReflectionsByKind(td.ReflectionKind.Class)
        );
        let queue = allClasses.filter(needsVisit);

        // There's probably some smarter way to do this iteration so that we
        // visit parent classes before child classes... but this works.
        while (queue.length) {
            for (const refl of queue) {
                visited.add(refl);
                if (refl.isDeprecated()) isDeprecated.add(refl);

                const parentClass = getParentClass(refl);
                if (!parentClass) continue;

                if (isDeprecated.has(parentClass)) {
                    // Ensure this class has a visible comment so TypeDoc doesn't automatically
                    // inherit the comment. TypeDoc considers a comment to be "visible" if it
                    // has any text or block tags.
                    if (!refl.comment?.hasVisibleComponent()) {
                        refl.comment ||= new td.Comment();
                        refl.comment.summary = [{ kind: "text", text: " " }];
                    }
                    continue;
                }

                // Use @inheritDoc to copy the comment from the parent class:
                refl.comment ||= new td.Comment();
                refl.comment.blockTags.push(new td.CommentTag("@inheritDoc", []));

                // Or copy whatever you're interested in from the parent class's comment
                // You may want to do this instead of adding an @inheritDoc tag so that
                // you can copy only part of the comment if desired.
                // refl.comment.summary = parentClass.comment.summary
                // refl.comment = parentClass?.comment?.clone();
            }

            queue = allClasses.filter(needsVisit);
        }
    }
}

Thanks for your in depth reply @Gerrit0! One quick question though, you say classes by default inherit their parent methods. However that doesn't seem to be the case for our project's typedoc build. For example we have this class which extends VectorStore, however it doesn't show any of the methods which are present on VectorStore but that are not implemented on the class I linked. Any idea why this might be?

Given that the hierarchy at the top of the page links to a page which is just Toolkit: any... I suspect that's your issue. However Toolkit is defined when TypeDoc is run doesn't have types.


Could not import aseprite file: output location does not exist

Hello! I'm trying to use this plugin, and when I manually import my .aseprite files through the SpriteSheet, it works fine by transforming them into resource files. But when the editor is trying to automatically import these .aseprite files, it shows following errors:
ERROR - Could not import aseprite file: output location does not exist
editor/editor_file_system.cpp:1801 - Error importing 'res://characters/player/placeholder_toucan.aseprite'.
ERROR - Could not import aseprite file: output location does not exist
editor/editor_file_system.cpp:1801 - Error importing 'res://characters/player/placeholder_toucan_flight.aseprite'.
ERROR - Could not import aseprite file: output location does not exist
editor/editor_file_system.cpp:1801 - Error importing 'res://characters/player/placeholder_toucan_nonflight.aseprite'.

This is a screenshot from the files imported. As you can see, I was able to transform the .aseprite files into .res files, but the error message still shows. How can I fix that? Or maybe, how can I disable the automatic import of .aseprite files? Thank you

Hello @raulboo. Thanks for notifying me about this issue. I'll have to investigate further to try to identify the root cause.
In the mean time, I'm releasing a new version with the option to disable the importer.


memory leak when add new catalog

**What kind of request is this (question/bug/enhancement/feature request):**bug
Steps to reproduce (least amount of steps as possible):
add this repohttps://github.com/Okabe-Kurisu/helm-stable-charts to catalog
Result:
rancher usr all the memory, and cpu using 300%
Other details that may be helpful:
After adding this catalog, rancher uses an additional 3G of memory
even i delete this catalog, memory still gone.
when the repo have no icon files, everything is right.
after i put icon in every chart, boom
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):rancher/server 2.2.7
Installation option (single install/HA):single install
rancher running in a 8c16g redhat kvm

Someone on qa team should check this.

The same to me.


Misc improvements

Hi,
Here are several changes
Misc improvements
Please be indulgent 😄, I'm a Vimscript newbie!

filename change (fzy.vim)
some refactoring / moving around of the functions (the reason why is in the notes section below)
no bind keys by default
add some API functions: quite a big name for just 2 functions 😂, namely fzy#get_status_string() and fzy#get_view_string(). This is for playing nice with plugins like lightline.
add some limited ability to filter only buffer names (using the config below): it is limited because despite my efforts, I could not switch transparently between filtering buffers and filtering files. You first have to toggle a switch using <c-t> and then re-call the plugin using <c-p>. Please note that the plugins opens for buffers first. You have to toggle and re-call the plugin to filter for files. Clearly not ideal.

Config
My init.vim config for this plugin is:
nnoremap <silent> <C-p> :FuzzyOpen<cr>
let g:fuzzy_bindkeys = 1 " activate default bindkeys
let g:fuzzy_contentsearch_engine = 'ag'

Usage
<C-P> opens the plugin in buffers view
<C-T> to toggle to buffers+files view (this also kills, as <esc> does, but this is unfortunate)
<C-P> opens the plugin in buffers+files view
<C-T> to toggle back to buffers view

Notes

Some other contributors did some work, but honestly, I did not take the time to present their work here. Their commits are included in this PR, of course.

I moved around the functions because they made more sense to me. Here is my vim window with the code now (thanks to folding). I hope it is self-explanatory

Here is a terminal recording

Thanks in advance for your comments and ideas.
Best regards

The filename change from neovim-fuzzy to fzy is probably bad practice for a PR. This should also have been broken down into more than one PR.


Adding .eslintrc for possible move to newer linting

ESLint is becoming more and more the go to linting tool and believe it would help to enforce the style guide of code conventions when implemented into CI

You've sent 6 commits instead of one :) When sending a PR on github you need to create a feature branch per PR. I would be better if you closed this PR and created another one, cleaned up.