WIP - Python3 migration

This pull request contains what I think is necessary in order to make this plugin Python 3 compatible, while still retaining compatibility with Python 2 so installs on older Kodi versions don't break. The changes are largely based on suggestions by the 2to3 script, but the are a couple of things I've ignored as I don't think they're necessary. There are also some changes that are of the recommended sort and not strictly necessary for Python 3 compatibility (replacement of printf style formatting come to mind).
As I currently don't have a Widevine capable device that is also running Kodi 19 my changes are not tested in a Python 3 environment, but rather a Python 2 one (where it works fine as far as I can tell). As such I wouldn't merge this PR until at least some basic verification has been carried out on Kodi 19. For that reason I'm also marking it a work in progress.

If this need testing I would be happy to help. Have Cmore through ComHem.

@rikardfries Feel free to give it a go and report back. I'm still on Kodi 18, i.e. Python 2, so there's a reasonable chance that I missed something.

@rikardfries Feel free to give it a go and report back. I'm still on Kodi 18, i.e. Python 2, so there's a reasonable chance that I missed something.

Can you give me the zip for the addon with python 3 code.
I have to raise the levels of the addon and the python version,
otherwise the Matrix alpha1 will disable it...
Then I can try it. :)

You can get the code from my fork. The branch is called python3.

You can get the code from my fork. The branch is called python3.

When I try to put in the Comhem number I get :
2020-09-29 21:30:15.180 T:7456    ERROR : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'AttributeError'>
Error Contents: 'str' object has no attribute 'decode'
Traceback (most recent call last):
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py", line 5, in
addon.run()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 17, in run
plugin.run()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 130, in run
self._dispatch(self.path)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 141, in _dispatch
view_func(**kwargs)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 340, in play
helper.play(plugin.args['video_id'][0])
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 211, in play
login_token = self.get_token()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 116, in get_token
self.set_login_credentials()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 106, in set_login_credentials
return self.set_tv_provider_credentials()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 137, in set_tv_provider_credentials
username = self.get_user_input(username_type)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 72, in get_user_input
query = keyboard.getText().decode('utf-8')
AttributeError: 'str' object has no attribute 'decode'
-->End of Python script error report<--
2020-09-29 21:30:15.510 T:7456     INFO : Python interpreter stopped
2020-09-29 21:30:15.527 T:4544    ERROR : Playlist Player: skipping unplayable item: 0, path [plugin://plugin.video.cmore/play?video_id=3355874]
2020-09-29 21:30:27.315 T:12972 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-09-29 21:30:42.378 T:12972 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-09-29 21:30:57.443 T:12972 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-09-29 21:31:02.311 T:11668    INFO : initializing python engine.
2020-09-29 21:31:02.904 T:11668 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-09-29 21:31:02.904 T:11668 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-09-29 21:31:10.375 T:11668   ERROR : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'requests.exceptions.ConnectionError'>
Error Contents: HTTPSConnectionPool(host='account-june.b17g.services', port=443): Max retries exceeded with url: /api/?client=cmore-kodi (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x000002F5C8E30A90>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed'))
Traceback (most recent call last):
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\connection.py", line 156, in _new_conn
conn = connection.create_connection(
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\util\connection.py", line 61, in create_connection
for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
File "C:\Program Files\Kodi\system\python\Lib\socket.py", line 918, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 11001] getaddrinfo failed
                                               During handling of the above exception, another exception occurred:

                                               Traceback (most recent call last):
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\connectionpool.py", line 665, in urlopen
                                                   httplib_response = self._make_request(
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\connectionpool.py", line 376, in _make_request
                                                   self._validate_conn(conn)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\connectionpool.py", line 994, in _validate_conn
                                                   conn.connect()
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\connection.py", line 300, in connect
                                                   conn = self._new_conn()
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\connection.py", line 168, in _new_conn
                                                   raise NewConnectionError(
                                               urllib3.exceptions.NewConnectionError: <urllib3.connection.VerifiedHTTPSConnection object at 0x000002F5C8E30A90>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed

                                               During handling of the above exception, another exception occurred:

                                               Traceback (most recent call last):
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.requests\lib\requests\adapters.py", line 439, in send
                                                   resp = conn.urlopen(
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\connectionpool.py", line 719, in urlopen
                                                   retries = retries.increment(
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.urllib3\lib\urllib3\util\retry.py", line 436, in increment
                                                   raise MaxRetryError(_pool, url, error or ResponseError(cause))
                                               urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='account-june.b17g.services', port=443): Max retries exceeded with url: /api/?client=cmore-kodi (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x000002F5C8E30A90>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed'))

                                               During handling of the above exception, another exception occurred:

                                               Traceback (most recent call last):
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py", line 5, in <module>
                                                   addon.run()
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 17, in run
                                                   plugin.run()
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 130, in run
                                                   self._dispatch(self.path)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 141, in _dispatch
                                                   view_func(**kwargs)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 340, in play
                                                   helper.play(plugin.args['video_id'][0])
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 211, in play
                                                   login_token = self.get_token()
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 120, in get_token
                                                   login_data = self.c.login(username, password, operator)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\cmore.py", line 161, in login
                                                   credentials = self.make_request(url, method, params=params, payload=json.dumps(payload), headers=headers)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\cmore.py", line 77, in make_request
                                                   req = self.http_session.post(url, params=params, data=payload, headers=headers)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.requests\lib\requests\sessions.py", line 581, in post
                                                   return self.request('POST', url, data=data, json=json, **kwargs)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.requests\lib\requests\sessions.py", line 533, in request
                                                   resp = self.send(prep, **send_kwargs)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.requests\lib\requests\sessions.py", line 646, in send
                                                   r = adapter.send(request, **kwargs)
                                                 File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.requests\lib\requests\adapters.py", line 516, in send
                                                   raise ConnectionError(e, request=request)
                                               requests.exceptions.ConnectionError: HTTPSConnectionPool(host='account-june.b17g.services', port=443): Max retries exceeded with url: /api/?client=cmore-kodi (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x000002F5C8E30A90>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed'))
                                               -->End of Python script error report<--

2020-09-29 21:31:10.698 T:11668    INFO : Python interpreter stopped

Hi, sorry for the slow response, but I just had a look at this and I think I identified the issue. I just pushed an update, so if you feel like it, please give another shot.

Thank you!
i change addon.xml to have python 3.0.0.
Then install the addon.
When I try to put in the Comhem number I get :
2020-10-17 16:25:15.264 T:9976     INFO : CPythonInvoker(26, C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py): script successfully run
2020-10-17 16:25:15.501 T:9976     INFO : Python interpreter stopped
2020-10-17 16:25:24.072 T:7932  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:25:26.077 T:1552     INFO : Loading skin file: DialogAddonSettings.xml, load type: KEEP_IN_MEMORY
2020-10-17 16:25:39.086 T:7932  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:25:54.109 T:7932  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:25:54.283 T:2060     INFO : initializing python engine.
2020-10-17 16:25:54.474 T:2060  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:25:54.474 T:2060  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:25:54.783 T:2060     INFO : CPythonInvoker(27, C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py): script successfully run
2020-10-17 16:25:55.039 T:2060     INFO : Python interpreter stopped
2020-10-17 16:26:01.542 T:14224    INFO : initializing python engine.
2020-10-17 16:26:01.755 T:14224 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:26:01.755 T:14224 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:26:02.048 T:14224    INFO : CPythonInvoker(28, C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py): script successfully run
2020-10-17 16:26:02.309 T:14224    INFO : Python interpreter stopped
2020-10-17 16:26:03.317 T:14132   ERROR : CImageLoader::DoWork - Direct texture file loading failed for resource://resource.images.studios.white/Unspecified.png
2020-10-17 16:26:09.231 T:7932  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:26:12.099 T:17292    INFO : initializing python engine.
2020-10-17 16:26:12.310 T:17292 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:26:12.310 T:17292 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:26:12.597 T:1552     INFO : Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY
2020-10-17 16:26:15.664 T:1552     INFO : Loading skin file: DialogKeyboard.xml, load type: KEEP_IN_MEMORY
2020-10-17 16:26:22.618 T:17292   ERROR : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'KeyError'>
Error Contents: 'q'
Traceback (most recent call last):
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py", line 5, in
addon.run()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 17, in run
plugin.run()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 130, in run
self._dispatch(self.path)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 141, in _dispatch
view_func(**kwargs)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 340, in play
helper.play(plugin.args['video_id'][0])
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 212, in play
login_token = self.get_token()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 117, in get_token
self.set_login_credentials()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 107, in set_login_credentials
return self.set_tv_provider_credentials()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 138, in set_tv_provider_credentials
username = self.get_user_input(username_type)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 74, in get_user_input
self.log('User input string: {q}'.format(query))
KeyError: 'q'
-->End of Python script error report<--
2020-10-17 16:26:22.898 T:17292    INFO : Python interpreter stopped
2020-10-17 16:26:22.929 T:1552    ERROR : Playlist Player: skipping unplayable item: 0, path [plugin://plugin.video.cmore/play?video_id=13290214]
2020-10-17 16:26:23.346 T:1552     INFO : Loading skin file: DialogTextViewer.xml, load type: KEEP_IN_MEMORY
2020-10-17 16:26:24.258 T:7932  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:26:32.916 T:14452    INFO : initializing python engine.
2020-10-17 16:26:33.134 T:14452 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:26:33.134 T:14452 WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-17 16:26:33.248 T:14452    INFO : CPythonInvoker(30, C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py): script successfully run
2020-10-17 16:26:33.506 T:14452    INFO : Python interpreter stopped

That issue should be fixed now and you shouldn't need to modify addon.xml either.

That issue should be fixed now and you shouldn't need to modify addon.xml either.

Python version 3.5.0 does not work. 3.0.0 works.
I do not know if that is the correct value though.
When I have inserted the kundnummer I get this.
Thanks for helping me!
2020-10-21 19:43:11.676 T:14164   ERROR : Control 55 in window 10025 has been asked to focus, but it can't
2020-10-21 19:43:11.691 T:9528     INFO : initializing python engine.
2020-10-21 19:43:11.889 T:9528  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:43:11.889 T:9528  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:43:11.901 T:9528     INFO : CPythonInvoker(25, C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py): script successfully run
2020-10-21 19:43:12.186 T:9528     INFO : Python interpreter stopped
2020-10-21 19:43:17.906 T:4656     INFO : initializing python engine.
2020-10-21 19:43:18.126 T:4656  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:43:18.127 T:4656  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:43:18.795 T:4656     INFO : CPythonInvoker(26, C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py): script successfully run
2020-10-21 19:43:19.070 T:4656     INFO : Python interpreter stopped
2020-10-21 19:43:20.076 T:4852  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:43:20.871 T:6864     INFO : initializing python engine.
2020-10-21 19:43:21.046 T:6864  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:43:21.046 T:6864  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:43:21.351 T:14164    INFO : Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY
2020-10-21 19:43:24.102 T:14164    INFO : Loading skin file: DialogKeyboard.xml, load type: KEEP_IN_MEMORY
2020-10-21 19:43:35.101 T:4852  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:43:50.122 T:4852  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:44:05.147 T:4852  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.
2020-10-21 19:44:12.055 T:6864    ERROR : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'TypeError'>
Error Contents: argument 1 must be str, not bytes
Traceback (most recent call last):
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py", line 5, in
addon.run()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 17, in run
plugin.run()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 130, in run
self._dispatch(self.path)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 141, in _dispatch
view_func(**kwargs)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 340, in play
helper.play(plugin.args['video_id'][0])
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 212, in play
login_token = self.get_token()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 117, in get_token
self.set_login_credentials()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 107, in set_login_credentials
return self.set_tv_provider_credentials()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 138, in set_tv_provider_credentials
username = self.get_user_input(username_type)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 74, in get_user_input
self.log('User input string: {q}'.format(q=query))
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 53, in log
xbmc.log(msg=msg.encode('utf-8'), level=xbmc.LOGDEBUG)
TypeError: argument 1 must be str, not bytes
-->End of Python script error report<--
2020-10-21 19:44:12.363 T:6864     INFO : Python interpreter stopped
2020-10-21 19:44:12.368 T:14164    INFO : Loading skin file: DialogTextViewer.xml, load type: KEEP_IN_MEMORY
2020-10-21 19:44:20.100 T:14164   ERROR : Playlist Player: skipping unplayable item: 0, path [plugin://plugin.video.cmore/play?video_id=3351495]
2020-10-21 19:44:20.285 T:4852  WARNING : xbmc.translatePath is deprecated and might be removed in future kodi versions. Please use xbmcvfs.translatePath instead.

I'm sorry for the delay @rikardfries, I'm afraid I haven't had any time to devote to this lately. The good news is that I'm working on setting up a Kodi 19 development system so I can test and verify my work locally. Hopefully it shouldn't be too long, but I don't want to make any promises.
Cheers

I'm sorry for the delay @rikardfries, I'm afraid I haven't had any time to devote to this lately. The good news is that I'm working on setting up a Kodi 19 development system so I can test and verify my work locally. Hopefully it shouldn't be too long, but I don't want to make any promises.
Cheers

No worries, I am thankful that you try to support me/us.
Just go as best as you can but do not get lost trying to catch time.
It never works :)

I'm sorry for the delay @rikardfries, I'm afraid I haven't had any time to devote to this lately. The good news is that I'm working on setting up a Kodi 19 development system so I can test and verify my work locally. Hopefully it shouldn't be too long, but I don't want to make any promises.
Cheers

When you have that fixed maybe you can take a look on viaplay addon that also needs to be fixed?

Hi @rikardfries. I finally found some time to dedicate to this and with my latest changes the plugin seems to be working in a Python 3 environment. At least it works on my Kodi 19 test device (RPi2 running LibreELEC nightly builds). I force pushed this update, so you might find you'll need to hard reset your local python3 branch by doing git reset --hard origin/python3.
I really hope this works for you, but please keep me updated either way.

Hi @rikardfries. I finally found some time to dedicate to this and with my latest changes the plugin seems to be working in a Python 3 environment. At least it works on my Kodi 19 test device (RPi2 running LibreELEC nightly builds). I force pushed this update, so you might find you'll need to hard reset your local python3 branch by doing git reset --hard origin/python3.
I really hope this works for you, but please keep me updated either way.

I'm sorry for the delay @rikardfries, I'm afraid I haven't had any time to devote to this lately. The good news is that I'm working on setting up a Kodi 19 development system so I can test and verify my work locally. Hopefully it shouldn't be too long, but I don't want to make any promises.
Cheers

When you have that fixed maybe you can take a look on viaplay addon that also needs to be fixed?

I'm sorry to say that at present and for the foreseeable future that's unlikely as I have very limited time and no Viaplay subscription.

I'm sorry for the delay @rikardfries, I'm afraid I haven't had any time to devote to this lately. The good news is that I'm working on setting up a Kodi 19 development system so I can test and verify my work locally. Hopefully it shouldn't be too long, but I don't want to make any promises.
Cheers

When you have that fixed maybe you can take a look on viaplay addon that also needs to be fixed?

I'm sorry to say that at present and for the foreseeable future that's unlikely as I have very limited time and no Viaplay subscription.

Hi @rikardfries. I finally found some time to dedicate to this and with my latest changes the plugin seems to be working in a Python 3 environment. At least it works on my Kodi 19 test device (RPi2 running LibreELEC nightly builds). I force pushed this update, so you might find you'll need to hard reset your local python3 branch by doing git reset --hard origin/python3.
I really hope this works for you, but please keep me updated either way.

I am sorry to say that it is not working.
I have attached my kodi log with trace on.
2021_0109_kodi.zip
Looks like I have some connection problem.
When I have put in my Comhem data it crashes.
There is no hurry here on my side.
When you have time, take a look at it.

Hi @rikardfries. I finally found some time to dedicate to this and with my latest changes the plugin seems to be working in a Python 3 environment. At least it works on my Kodi 19 test device (RPi2 running LibreELEC nightly builds). I force pushed this update, so you might find you'll need to hard reset your local python3 branch by doing git reset --hard origin/python3.
I really hope this works for you, but please keep me updated either way.

I am sorry to say that it is not working.
I have attached my kodi log with trace on.
2021_0109_kodi.zip
Looks like I have some connection problem.
When I have put in my Comhem data it crashes.
There is no hurry here on my side.
When you have time, take a look at it.

Hmm. The plugin can't resolve the operator login URL for some reason. I'm not sure whether this has anything to do with my updates, or whether CMore has changed to operator login procedure (which I personally don't use and therefore hadn't tested). While I don't get the exact same error as you, when using some dummy credentials I get one that is similar enough to try and debug from. I'll see what I can come up with.
Also, I suspect that the log contains your login credentials, so please have a look and blank them out if that's the case (I'm pretty sure they're there).

Hmm. The plugin can't resolve the operator login URL for some reason. I'm not sure whether this has anything to do with my updates, or whether CMore has changed to operator login procedure (which I personally don't use and therefore hadn't tested). While I don't get the exact same error as you, when using some dummy credentials I get one that is similar enough to try and debug from. I'll see what I can come up with.
Also, I suspect that the log contains your login credentials, so please have a look and blank them out if that's the case (I'm pretty sure they're there).

Hmm. The plugin can't resolve the operator login URL for some reason. I'm not sure whether this has anything to do with my updates, or whether CMore has changed to operator login procedure (which I personally don't use and therefore hadn't tested). While I don't get the exact same error as you, when using some dummy credentials I get one that is similar enough to try and debug from. I'll see what I can come up with.
Also, I suspect that the log contains your login credentials, so please have a look and blank them out if that's the case (I'm pretty sure they're there).

I have removed it for now.
Will put it back in a while.

Hmm. The plugin can't resolve the operator login URL for some reason. I'm not sure whether this has anything to do with my updates, or whether CMore has changed to operator login procedure (which I personally don't use and therefore hadn't tested). While I don't get the exact same error as you, when using some dummy credentials I get one that is similar enough to try and debug from. I'll see what I can come up with.
Also, I suspect that the log contains your login credentials, so please have a look and blank them out if that's the case (I'm pretty sure they're there).

I have removed it for now.
Will put it back in a while.

I'm wondering whether CMore has simply disabled direct operator login, forcing you to connect your operator credentials to a regular CMore account. It's not possible to login with operator credentials in the Android app anymore, it will just direct you to this page, where you associate your operator credentials with a CMore account. CMore revamped their login procedure back in 2019. Back then one of the actual developers at TV4/CMore chimed in regarding the changes (in issue 33) and said that
As for operator login, the typical flow would be that the user activates their account once to be able to login using regular C More credentials.

It seems the old style, or "direct", operator login continued to work for some time, but since the URL used for that purpose no longer seems to exist, I'm inclined to believe that at some point they simply disabled that type of login. Since it's not possible to login using operator credentials in the app anymore I'm also not able to observe a working case as I would normally do, so I don't really know how to proceed, other than to recommend the procedure mentioned earlier.

I'm wondering whether CMore has simply disabled direct operator login, forcing you to connect your operator credentials to a regular CMore account. It's not possible to login with operator credentials in the Android app anymore, it will just direct you to this page, where you associate your operator credentials with a CMore account. CMore revamped their login procedure back in 2019. Back then one of the actual developers at TV4/CMore chimed in regarding the changes (in issue 33) and said that
As for operator login, the typical flow would be that the user activates their account once to be able to login using regular C More credentials.

It seems the old style, or "direct", operator login continued to work for some time, but since the URL used for that purpose no longer seems to exist, I'm inclined to believe that at some point they simply disabled that type of login. Since it's not possible to login using operator credentials in the app anymore I'm also not able to observe a working case as I would normally do, so I don't really know how to proceed, other than to recommend the procedure mentioned earlier.

I'm wondering whether CMore has simply disabled direct operator login, forcing you to connect your operator credentials to a regular CMore account. It's not possible to login with operator credentials in the Android app anymore, it will just direct you to this page, where you associate your operator credentials with a CMore account. CMore revamped their login procedure back in 2019. Back then one of the actual developers at TV4/CMore chimed in regarding the changes (in issue 33) and said that
As for operator login, the typical flow would be that the user activates their account once to be able to login using regular C More credentials.

It seems the old style, or "direct", operator login continued to work for some time, but since the URL used for that purpose no longer seems to exist, I'm inclined to believe that at some point they simply disabled that type of login. Since it's not possible to login using operator credentials in the app anymore I'm also not able to observe a working case as I would normally do, so I don't really know how to proceed, other than to recommend the procedure mentioned earlier.

IT WORKS!
You are right. When I logon with my ’ordinary’ userid and password it works.
I know that it did not work earlier. Maybe the quarrel with comhem made them go back to the old logon way. Anyway, i am happy it seems to work fine. Kudos to you that fixed it !!! Maybe it could go to the kodi repo..

I'm wondering whether CMore has simply disabled direct operator login, forcing you to connect your operator credentials to a regular CMore account. It's not possible to login with operator credentials in the Android app anymore, it will just direct you to this page, where you associate your operator credentials with a CMore account. CMore revamped their login procedure back in 2019. Back then one of the actual developers at TV4/CMore chimed in regarding the changes (in issue 33) and said that
As for operator login, the typical flow would be that the user activates their account once to be able to login using regular C More credentials.

It seems the old style, or "direct", operator login continued to work for some time, but since the URL used for that purpose no longer seems to exist, I'm inclined to believe that at some point they simply disabled that type of login. Since it's not possible to login using operator credentials in the app anymore I'm also not able to observe a working case as I would normally do, so I don't really know how to proceed, other than to recommend the procedure mentioned earlier.

IT WORKS!
You are right. When I logon with my ’ordinary’ userid and password it works.
I know that it did not work earlier. Maybe the quarrel with comhem made them go back to the old logon way. Anyway, i am happy it seems to work fine. Kudos to you that fixed it !!! Maybe it could go to the kodi repo..

When you have that fixed maybe you can take a look on viaplay addon that also needs to be fixed?

I'm sorry to say that at present and for the foreseeable future that's unlikely as I have very limited time and no Viaplay subscription.

Ok but you can get it for free for 2 weeks and just cancel it before that period ends :)

When you have that fixed maybe you can take a look on viaplay addon that also needs to be fixed?

I'm sorry to say that at present and for the foreseeable future that's unlikely as I have very limited time and no Viaplay subscription.

Ok but you can get it for free for 2 weeks and just cancel it before that period ends :)

Have been testing this now and seems to work fine.

Glad to hear it!

But i have another problem but that's not related to your changes.
The plugin only shows max 100 items so it doesn't show all episodes of some series for example.
I tried to change 'page_size': '100' to 'page_size': '500' in cmore.py file but that didn't help.

But i have another problem but that's not related to your changes.
The plugin only shows max 100 items so it doesn't show all episodes of some series for example.
I tried to change 'page_size': '100' to 'page_size': '500' in cmore.py file but that didn't help.

There's room for improvement in places for sure. My ambition is to tackle some of these things that I've come across myself, but I can't really give a timeline.

Thanks for the good work @kjerstadius it works pretty good!

Seems to be a problem with opening live channels with plugin now.

Seems to be a problem with opening live channels with plugin now.

I have confirmed that there's indeed a problem with the live channels part of the plugin. Unfortunately, I have very limited time to investigate and solve this issue for the time being. I will look into it when I can.

Kodi 19.4
Error when trying to stream anything, no matter if its a movie, series, program or sports channel....
2022-06-18 14:10:01.982 T:4366    ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--                                                     - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!                                                    Error Type: <class 'TypeError'>                                                    Error Contents: byte indices must be integers or slices, not str                                                    Traceback (most recent call last):                                                      File "/home/my_username/.kodi/addons/plugin.video.cmore/default.py", line 5, in <module>                                                        addon.run()                                                      File "/home/my_username/.kodi/addons/plugin.video.cmore/resources/lib/addon.py", line 17, in run                                                        plugin.run()                                                      File "/home/my_username/.kodi/addons/script.module.routing/lib/routing.py", line 130, in run                                                        self._dispatch(self.path)                                                      File "/home/my_username/.kodi/addons/script.module.routing/lib/routing.py", line 141, in _dispatch                                                        view_func(**kwargs)                                                      File "/home/my_username/.kodi/addons/plugin.video.cmore/resources/lib/addon.py", line 340, in play                                                        helper.play(plugin.args['video_id'][0])                                                      File "/home/my_username/.kodi/addons/plugin.video.cmore/resources/lib/kodihelper.py", line 214, in play                                                        stream = self.c.get_stream(video_id, login_token=login_token)                                                      File "/home/my_username/.kodi/addons/plugin.video.cmore/resources/lib/cmore.py", line 168, in get_stream                                                        url = '{playback_api}{media_uri}'.format(playback_api=init_data['envPlaybackApi'], media_uri=asset['mediaUri'])                                                    TypeError: byte indices must be integers or slices, not str                                                    -->End of Python script error report<--

The same for me. Will check the log when I have time.

Here is what I get when trying t o start something..
2022-06-19 22:35:11.859 T:8260    ERROR : Skipped 1 duplicate messages..
2022-06-19 22:35:11.859 T:8260    ERROR : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'TypeError'>
Error Contents: byte indices must be integers or slices, not str
Traceback (most recent call last):
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\default.py", line 5, in
addon.run()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 17, in run
plugin.run()
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 130, in run
self._dispatch(self.path)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 141, in _dispatch
view_func(**kwargs)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\addon.py", line 340, in play
helper.play(plugin.args['video_id'][0])
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\kodihelper.py", line 214, in play
stream = self.c.get_stream(video_id, login_token=login_token)
File "C:\Users\rikar\AppData\Roaming\Kodi\addons\plugin.video.cmore\resources\lib\cmore.py", line 168, in get_stream
url = '{playback_api}{media_uri}'.format(playback_api=init_data['envPlaybackApi'], media_uri=asset['mediaUri'])
TypeError: byte indices must be integers or slices, not str
-->End of Python script error report<--
2022-06-19 22:35:11.873 T:10416    INFO : CActiveAESink::OpenSink - initialize sink
2022-06-19 22:35:12.361 T:8260     INFO : Python interpreter stopped
2022-06-19 22:35:12.372 T:2228    ERROR : Playlist Player: skipping unplayable item: 0, path [plugin://plugin.video.cmore/play?video_id=13737275]
2022-06-19 22:35:12.572 T:2228     INFO : Loading skin file: DialogTextViewer.xml, load type: KEEP_IN_MEMORY

It seems the playback API has changed. I'm trying to wrap my head around the new API, but I can't give any sort of ETA of when I might be able to get things working again.

I am just happy that you are helping us. If you need help with testing please just ping me!

Good news! I have made quite some progress with the new API and have a somewhat hacky, but mostly working version. However, it's not based on this plugin, but rather the Telia Play plugin. The reason for this is that, likely due to Telia's acquisition of C More, the new C More API is mostly the same as the API used for Telia Play, albeit with C More specific URIs, some additional quirks and a different login process.
Anyway, enough technical details... If you want to give the new plugin a try, the easiest way is to do the following:

Install the Telia Play plugin from the official Kodi addon repository
Clone the feat/cmore branch of my fork of the Telia Play plugin
Copy the files in resources/lib from my fork to .kodi/addons/plugin.video.teliaplay-se/resources/lib, thereby replacing the original files
Enter login info
Profit

As I said, this is a bit of hack and there are bugs. On the other hand, most things seem to work. I have tested starting movies, series episodes, sports events, TV4 programs as well as live TV and that all works. Searching also works. Here are a couple of known issues:

Some menus pages don't open correctly and lead to an error. Not sure why yet.
Due to the way the original plugin is written, the country is hardcoded to se (Sweden) in multiple places. This likely means that it doesn't work for non-Swedish users, though I am able to say for sure. Still, there's no harm in trying.

Please give it a try and let me know how it works out.

It sounded a bit to good to be true but in fact it works at least as good as the old plugin.
Have watched a full show and tested all live channels. TV2 seems to be missing.. ?
Two questions:

Do you want me to report errors in here or at another spot ?
Will you create a new plugin or just overwrite the old one with this and/or will you try cooperate with the creator of the Telia Play addon ?

and of course Thank you once again for excellent work.!!!!!!
/Rikard ¤ kind regards

Funny that you should said that. Me too. :)
I will try your update tonight or tomorrow, depending on time....
Think you are right on number two, SEEMORE ?


Correct spelling in README

Picked from #90; the other commits edit the policies.

Be honest was right is right what's wrong is wrong !!!!💯
tipsAreWelcome
*infilecoin f1j4oqo6bf5ru6fnpf2qqmyj3ecejtz7jjelgntva


Automate release notes

This PR streamlines the release flow by pulling the release notes from GitHub directly into the generated docs at build time. These notes obviate the release notes that were maintained manually in docs/versions/21.0.md. The release process docs (dev-docs/release-new-version.md) were updated appropriately.
Advantages

Simplicity: Release is as simple as using the github release process and the site will incorporate the notes automatically
Consistency between github release notes and the versions page

Disadvantages

No mechanism to differentiate github release notes and site release notes
Small possibility of build failures due to API failure (including API rate limits)
Pages are regenerated for all versions on every build. (In practice, this is «1 sec)

Most of these disadvantages can be overcome by creating and committing version page as before, and then making the page for only the most recent major.minor.
Comparing
https://hgvs-nomenclature.org/stable/versions/21.0/ and
https://hgvs-nomenclature--176.org.readthedocs.build/176/versions/21.0/
shows that these pages are nearly identical with the exception of the admonition.

Nice changes, @ifokkema .
I removed your inline 21.0.0 release notes and created a new 21.0.0. release in github. The output is essentially identical, but it means that users will also now see a 21.0.0 release in github and that the release notes work the same as the others. Thanks for catching that omission!
Since this is essentially a refinement on code that you already reviewed, I'm going to merge as-is.

I removed your inline 21.0.0 release notes and created a new 21.0.0. release in github.

Makes sense! I didn't realize it would nicely sort the way it does; I thought a new release would just get in the way. This is much better, indeed! Thanks!


Retrieving all Relationships

Hi, i want to get all the relationships by giving the node Id (it's not the internal id)
client.Cypher.Match("(n:PolyLine)-[r*]->()").Where("n.Id = 0").Return<DON'TKNOW>("r").Results;
i've tried doing this but i don't what is the return type

Hey, What are you after? The contents of the r or the type of it?

the contents

i've tried doing this to see the content and it works but it returns an "array" of n elements,
in the first element i have the first relationship, in the second element i have the first relationship and the second relationship, in the third element i have  the first ,second and third relationship and so on...
only in the Nth element i get all the relationships together
public class Metadata {
        [JsonProperty("id")]
        public long Id { get; set; }

        [JsonProperty("type")]
        public string Type { get; set; }
    }

public class Relation{

        public Relation() {

        }

        [JsonProperty("metadata")]
        public Metadata Metadata { get; set; }

        [JsonProperty("property")]
        public string Property { get; set; }

        [JsonProperty("start")]
        public string Start { get; set; }

        [JsonProperty("self")]
        public string Self { get; set; }

        [JsonProperty("end")]
        public string End { get; set; }

        [JsonProperty("type")]
        public string Type { get; set; }
}

Hi Sorry - I'm not really sure what you're doing - can you put a self contained program up, or - have you tried your cypher in the browser? If so - did you look at the table view and see what the results were?
Generally - you want to get the cypher working first, ensure it gives out the results you want, and then head into C#


Node-version restrictions added in package.json breaks my build

We are using Gitlab runners with node 19.7.0 to build our project. Have not had any issues previously, but I see you added in node-version restrictions now that means node 19.7.0 is no longer supported, and this breaks our build.
As a temporary fix I have downgraded the version of is-drm-supported we use to 1.2.1, but it would be nice to be able to use the latest versions.

Thanks for notifying us. I'll patch this, the change was intended to affect developers of the package, not consumers.


Error when user has one pending open order

to repro:
user has one open order on a market, then goes to portfolio page to cancel it. Once the cancel transaction is confirmed and the pending order is removed the UI explodes.
Issue is that filtered data doesn't get updated when the market collection has been updated. In the screenshot below the markets and marketObj have been updated by container.

marketObj is empty object

@phoebemirman let's chat on a solution to this issue. It might be an issue with all. I put in a PR with a quick fix, we might need to think about it more.


Environment variable substituion: Kit environment and buildDirectory

Brief Issue Summary
"cmake.buildDirectory" : "${env.VARNAME}" does not work if VARNAME is set in active kit's "environmentVariables". Empty string is used instead. Ditto for "cmake.installPrefix".
Although, the following works fine:

"cmake.buildDirectory" : "${buildKit}"
"cmake.configureSettings: { "SOME_SETTING" : "${env.VARNAME}" }
"cmake.buildDirectory" : "${env.VARNAME}" - if VARNAME is set in environment before running vscode, instead of the kit.

Expected:
Values of variables set in active kit's "environmentVariables" to be used in ${env.XXX} substitution for "cmake.buildDirectory" and "cmake.installPrefix".
Apparent Behavior:
1: .vscode/cmake-kits.json:
[
   {
      "name": "TEST_KIT",
      "environmentVariables": {"TEST_VAR": "TEST"}
   }
]

2: .vscode/settings.json:
   "cmake.configureSettings": {
      "TEST_SETTING": "${env.TEST_VAR}"
   },
   "cmake.buildDirectory": "${workspaceFolder}/__build/${env.TEST_VAR}-${buildKit}-${buildType}",

CMake: Select Kit => TEST_KIT

CMake: Delete Cache and Reconfigure

Output: CMake/Build
see below

CMake Tools Log
[proc] Executing command: /usr/local/bin/cmake --no-warn-unused-cli -DTEST_SETTING:STRING=TEST ... -B/home/user/project/__build/-TEST_KIT-Debug ...

Platform and Versions

Operating System: VSCode UI: Windows 10 1903, VSCode Server: Ubuntu 16 64bit
CMake Version: 3.17.2
VSCode Version: 1.45.1
CMake Tools Extension Version: 1.3.1
Compiler/Toolchain: GCC 5.4.0

Other Notes/Information
Is it expected bahaviour, am I doing something wrong, or is it a bug?
BTW, thanks for the great extension!

CMake Tools 1.7.0 was released today and it contains a fix for this issue. Upgrade the extension in VSCode and let us know if you encounter any other problems.

Still not working for me with CMake tools 1.7.0.
settings.json:
"cmake.buildDirectory": "${workspaceFolder}/__build/${env.VARNAME}-postfix",
cmake-kits.json:
"name": "TestKit",
...
"environmentVariables": {
         "VARNAME" : "var-value",

After selecting the kit and cleaning CMake cache I still have ${workspaceFolder}/__build/-postfix as build directory, i.e. VARNAME is not taken from cmake-kits.json.

You are right, I either didn't test this properly when I merged the PR targeting to fix this into the repository or it regressed with some of our latest unrelated PRs. I have a fix that we will review.

CMake Tools 1.7.1 was released today and it contains a fix for this issue. Upgrade the extension in VSCode and let us know if you encounter any other problems.

Now it's perfect. Many thanks!

I want to use this "feature" inside cmake.cmakePath in settings.json (in workspace). But it does not work. Neither with version 1.7.1 nor with the current version 1.9.1 od cmake-tools extension. The environment variable is always empty. VScode is version 1.62.2


Setup

pull in updates from template
clean up portfolio/projects list, add more tags, add images
add team member pages
add home page content, portfolio page, and about page
add other images

I haven't set up PR deploy previews because we don't have a Center Netlify account yet. So if you want to preview this PR, you'll have to build it locally:
https://github.com/greenelab/lab-website-template/wiki/Advanced-Editing#build-site-locally

Can someone help me resolve this merge conflict. It doesn't make any sense.


fix(SlateAsInputEditor): set data-key for headings - I135

Signed-off-by: Artyom<EMAIL_ADDRESS>Issue #135
Fixes issue described in  issue #135.
This bug caused the following issue in @accordproject/template-studio-v2 issue #113. Passed data-key from Heading Node was not set in heading html tags, as a result causing bugs when scrolling.
Related Issues

issue #135
@accordproject/template-studio-v2 issue #113

Updated the description, hope now it is okay. and about attributes, if we pass it using spread operator props object will contain attributes' keys as its own keys with the corresponding value and since in functional component Heading we refer to these values through { type, children ... }, to get data-key value we have to do it like { type, children, data-key } , which is not possible in JavaScript, that's why i changed it so props object contains the whole attribute object and not just its keys.

Can you run npm audit in this branch and see if there are vulnerabilities? If so, run npm audit fix.

there are 21 vulnerabilities, but npm audit fix does not fix them. I get
fixed 0 of 21 vulnerabilities in 1811520 scanned packages
21 vulnerabilities required manual review and could not be updated

@archhhh Hmm, I mean this PR isn't the source of them so this can be a separate issue, but if you try npm update then npm audit fix does that do anything?

this is what I get now
npm WARN rollback Rolling back<EMAIL_ADDRESS>failed (this is probably harmless): EINVAL: invalid argument, scandir '/mnt/d/projects/accord/markdown-editor/node_modules/fsevents/node_modules'
npm WARN rollback Rolling back<EMAIL_ADDRESS>failed (this is probably harmless): EINVAL: invalid argument, scandir '/mnt/d/projects/accord/markdown-editor/node_modules/fsevents/node_modules'
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of typescript@* but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/react-scripts/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
up to date in 17.752s
fixed 0 of 21 vulnerabilities in 1811520 scanned packages
21 vulnerabilities required manual review and could not be updated

Alright I can open an issue around this later. Still will wait for @DianaLease's or @dselman's review

I think we need to revert this, I am receiving this error in an inconsistent manner:
A node with a duplicate key of "5" was found! Duplicate keys are not allowed, you should use `node.regenerateKey` before inserting if you are reusing an existing node.

And when I revert to cicero-ui v0.1.3, which is before this PR and subsequent release was integrated, I can navigate to headers without errors (which was originally the issue in https://github.com/accordproject/template-studio-v2/issues/113)

Maybe not, actually. This may be an issue of how we populate headers in the navigation component, https://github.com/accordproject/template-studio-v2/blob/master/src/sagas/contractSaga.js#L61


Rename does not work on recursive functions

let rec func () =     func()
Steps:
Invoke rename (Ctrl+R twice)
Observed:
Only the initially selected name changes.
Expected:
All occurrences of the name change.
Visual Studio Enterprise 2017
Version 15.7.5

I cannot reproduce this in 15.8.
.NET SDK project:

.NET Framework project:

Can you reproduce this if you are on 15.8?

I'll try again when I install 15.8.x (the one that will fix to the MSBuild internal error).
In the meanwhile I tried this again on 15.7.6 and I noticed that if I let some time pass after writing the code, (~10 seconds on a small project like that), the refactoring does work. I was hitting the issue on a larger codebase where I guess this refresh time was taking longer and I assumed it just never worked.
Now that I try it out I can see this affects non-recursive calls as well.

Write a new function
Write a call to it somewhere
Observe that intellisense updates properly, mouse over the call site shows proper tooltip
Rename - doesn't actually rename
Undo, wait...
Rename - works

So it might be just an issue that the rename is available when the "backend" isn't actually ready to do the work.

So there may be a timing issue at play, but in practice I cannot get this to happen over long spans of time in a larger codebase either. Is this after opening the whole codebase fresh?


Resolve issue #577: modulate_with_cenocc changed to cenocc_model

Fixes issue #577. At the time of this request it is still under debate whether this change is appropriate. However, I believe this is the most natural way to resolve a bug in the way Zheng07Sats handles central modulation.
Please note I have not run the test modules as my local setup does not support it. I can possible run later, but it would be helpful if someone else could check.

Thanks @mclaughlin6464 - I'll give this a careful review right after the holiday.

It would appear that the leauthaud11 model has similar functionality to zheng07. It seems we should update that one as well; I'm happy to implemented the same features we have for zheng07 over the weekend.

I don't understand the Assembly bias functionality enough to fix this error. I think you'll have to take a look at this @aphearin . No rush.

No problem @mclaughlin6464 - nice work getting it down to just one remaining failure. The HeavisideAssembias class is pretty dense; I didn't see a long-term future in building upon this simple two-population family of toy models, so I didn't bother to make it super extensible. I'll fix the remaining failure next week.


field_behavior.proto (namely .pb.h) fails to build on Windows

Here OPTIONAL is used: https://github.com/googleapis/api-common-protos/blob/be41e82ef4af6406b4cf331af00a837f813c0c3b/google/api/field_behavior.proto#L41
But minwindef.h unconditionally defines OPTIONAL to nothing and so generated code fails to build.
The include comes via grpc/include/grpc/impl/codegen/port_platform.h which is included into generated code.

This is widely used by many APIs as part of the core field_behavior proto. Thanks for the feedback.

@miraleung has this issue been addressed yet?


The reference link to handlebars page no longer works.

I tried visiting the handlebars page to get a guide for using conditions in the HTML, but the page link has been changed.
The link needs to be updated.

I would like to work for this issue. can you assign it to me?. Thanks.


Text selection (with left click + drag down) does not scroll window up within notebook cells

Does this issue occur when all extensions are disabled?: Yes

Version : 1.66.2 (user setup)
Validation : dfd34e8260c270da74b5c2d86d61aee4b6d56977
Date : 2022-04-11T07:46:01.075Z
Electron : 17.2.0
Chromium: 98.0.4758.109
Node.js : 16.13.0
V8 : <IP_ADDRESS>-electron.0
Système d’exploitation : Windows_NT x64 10.0.19044
Steps to Reproduce:

Open a notebook, past long text within a cell
Insure that the cell end is occulted by window bottom
Left Click somewhere within the cell, drag down past the window bottom

I guess the window should scroll up as it does in any editor, here it does not. Sorry if duplicated, but strangely I could not find this exact issue reported.

Similar issue https://github.com/microsoft/vscode/issues/167967.
The embed editor didn't know the cursor is already out of viewport thus it will not scroll. Even if it knows, it won't scroll as the editor is rendered fully. We would need to handle this in notebook list view.


nfs:juicefs sync Failed to upload data to the nfs

What happened:
./juicefs sync ./mc nfs://root@<IP_ADDRESS>:/minio2/share/mc
2024/04/08 13:49:03.454960 juicefs[2158329] : create nfs <IP_ADDRESS>:/minio2/share/mc: unable to mount <IP_ADDRESS>:/minio2/share/mc: MNT3ERR_NOENT [main.go:31]
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?
Environment:

JuiceFS version (use juicefs --version) or Hadoop Java SDK version:
Cloud provider or hardware configuration running JuiceFS:
OS (e.g cat /etc/os-release):
Kernel (e.g. uname -a):
Object storage (cloud provider and region, or self maintained):
Metadata engine info (version, cloud provider managed or self maintained):
Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
Others:

For now the NFS bucket (<IP_ADDRESS>:/minio2/share/mc in this case) must be exported.

@SandyXSD We can try to mount with the parent dir, and use lower part as prefix


chore: mark native image checks as required

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕
If you write sample code, please follow the samples format.

The ci / windows job is failing with the following error: MetricsTracerTest.testInvalidRequest:370 � NullPointer


Create test suite for ACL module

Create test cases that cover all the commands in the ACL module.

Branch addressing this issue has been merged.


[stable/redis-ha]  Fixed unused env section.

Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes

Fixed the problem that empty env section remains when env of value.yaml is false.

Procedure

## Master branch
pwd
/Users/y_kimura/src/github.com/helm/charts/stable/redis-ha
 helm template ./ -f values.yaml --name redis  > orig.yaml
## Fixed branch
helm template ./ -f values.yaml --name redis  > fix.yaml

## diff
diff fix.yaml orig.yaml
503a504
>         env:

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @dandydeveloper
/ok-to-test

/assign @dandydeveloper

@yutachaos https://github.com/DandyDeveloper/charts
Can you also PR this here? This chart is being deprecated. Want to make sure they are in sync as best I can.

@yutachaos https://github.com/DandyDeveloper/charts
Can you also PR this here? This chart is being deprecated. Want to make sure they are in sync as best I can.

@DandyDeveloper
Thanks.
I sent a pull request this repository.
https://github.com/DandyDeveloper/charts/pull/10

/lgtm


Update free-courses-hi.md- Added a free course for DSA in C

What does this PR do?
Add resource(s)- Added a free course for learning DSA in C in Hindi
For resources
It is a free playlist on youtube by CodewithHarry
Why is this valuable (or not)? Yes itis very valuable
How do we know it's really free? It is availabe on Youtube
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ DONE] Read our contributing guidelines.
[ DONE ] Search for duplicates.
[ DONE ] Include author(s) and platform where appropriate.
[  DONE] Put lists in alphabetical order, correct spacing.
[  DONE] Add needed indications (PDF, access notes, under construction).
[ DONE ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


I don't know how to add Curses to Python.

I don't know how to add Curses to Python.
weve tried to use pip, but all versions of Python weve tried have said that there is either an issue with syntax, or that a command that tells the system to upload curses isn't recognized. Weve tried Python 3.6.1, 2.7.10. 2.7.13, and 3.5.0 and it hasn't worked primarily for syntax reasons when I copied and pasted. The version of curses Were trying to "connect" with whatever Version of Python always matches, for example, We used  curses‑2.2‑cp36‑cp36m‑win_amd64.whl  when using Python 3.6.1, on 64 bit version.
Weve only got the warning that that command isn't recognized when using Python 2. 7.10 "probably because it may be outdated"

I assume you are on Windows? When you run "pip install curses‑2.2‑cp36‑cp36m‑win_amd64.whl", do you have the "curses‑2.2‑cp36‑cp36m‑win_amd64.whl" file in the current directory?

Which directory??
what's a directory??
sorry.

Let's say that you downloaded the whl file to path "C:\Users\Maximums\Downloads\curses‑2.2‑cp36‑cp36m‑win_amd64.whl". Are you running the command "pip install curses‑2.2‑cp36‑cp36m‑win_amd64.whl" from within the directory "C:\Users\Maximums\Downloads" ?

no I'm not
is the command not being recognized because in using a directory without the file?

On file explorer right click the address bar, copy addresss, type into
command prompt without quotes or plus "cd" + directory, run the pip install
command.
On Wed, May 31, 2017 at 2:50 PM, MaximusTheGladiator <
<EMAIL_ADDRESS>wrote:

no I'm not
is the command not being recognized because in using a directory without
the file?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/general-ai-challenge/Round1/issues/17#issuecomment-305297298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATB9-YOge8d-SRaQ-fsC4rFUqcje9fIXks5r_cRrgaJpZM4Np31Q
.

--
Artur Dorovskikh

thanks !!!!

i have the same issue here pliz help me i have install unicurses 1.2 as well as python 3.6.pliz help me out i am stuck

You should install the recommended library (not unicurses, but curses). For Windows, you can download them here: https://www.lfd.uci.edu/~gohlke/pythonlibs/#curses (pick the version appropriate for your python and 32/64 bits).

Thanks @MaximusTheGladiator  for asking this question.
and thanks @martinpoliak-goodai for replying such a great answer....
it is working for me...


Bug with ReadMapCB

ReadMapCB: expect { or n, parsing 24 ...aders":{"f... at {"id":3160,"headers":{ .......
type Email struct {
Id uint64
Encoding gomail.Encoding
Charset  string

Headers     map[string]utility.StringArray
Body        EmailBody
Alternative []EmailBody
Attachment  map[string]EmailBody

UserData map[string]interface{} `json:"user_data"`

}
It always stuck at reading Id, and if I put "id" at the end of JSON i got EOF

can you provide a sample json input?

Email: UserData: ReadMapCB: expect { or n, parsing 26 ..._data":{"s... at {"id":3163,"user_data":{"split":0,"type":5}}

Duplicate for https://github.com/json-iterator/go/issues/159

@1stborn , your issue is not the same with  mine.
The json string you provide
var text = []byte(`{"id":3163, somedata: null}`)

is not valid.
key in json is always string type, so the valid one should be
var text = []byte(`{"id":3163, "somedata": null}`)

just a typo, i change key here, if i remove extra.RegisterFuzzyDecoders() all work fine

@1stborn is it working now?


Not all partitions accounted for in client when selecting SigningRegion

What happened?

There is some logic in the provider that handles signing region based on partition:
https://github.com/crossplane/provider-aws/blob/master/pkg/clients/aws.go#L213
It is, however, missing certain partitions - namely aws-iso and aws-iso-b. These partitions require special handling the same way that aws-us-gov does.
This issue is vaguely related to https://github.com/crossplane/provider-aws/pull/1020 which is what enables the ProviderConfig partition logic to even be considered.
How can we reproduce it?

What environment did it happen in?
Crossplane version: 1.6.1,
Provider 0.23.0 (with small patch taken from https://github.com/crossplane/provider-aws/pull/1020)

Think we have an issue for this https://github.com/crossplane/provider-aws/issues/596


@Header.schema() in @ApiResponse does not generate the type

Hello,
We're using Swagger annotations and Maven plugin to generate our spec. I'm attempting to add some @ApiResponse annotations to our operations, but the @Header annotation is not including the schema.type. For instance:
  @Operation(summary = "List of services for the given account",
             responses = {
                 @ApiResponse(responseCode = "200", description = "List of services for the given account"),
                 @ApiResponse(description = "User did not provide a valid auth token", responseCode = "401",
                              content = @Content(mediaType = MediaType.APPLICATION_JSON,
                                                 schema = @Schema(implementation = ErrorMessage.class)),
                              headers = { @Header(name = "testing-headers",
                                                  description = "Flow/trace ID for traceability in the logs",
                                                  schema = @Schema(type = "string")) })
             })

This generates the following spec:
    get:
      operationId: getServices
      parameters:
      - in: path
        name: accountId
        required: true
        schema:
          type:
          - string
      responses:
        "200":
          description: List of services for the given account
        "401":
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ErrorMessage'
          description: User did not provide a valid auth token
          headers:
            testing-headers:
              description: Flow/trace ID for traceability in the logs
              schema: {} # <- no `type: string` nested here
              style: simple # <- not sure where this is coming from
      summary: List of services for the given account

Even if I add something like format to the @Schema:
    headers = { @Header(name = "testing-headers",
                        description = "Flow/trace ID for traceability in the logs",
                        schema = @Schema(type = "string", format = "hexadecimal")) })

            testing-headers:
              description: Flow/trace ID for traceability in the logs
              schema:
                format: hexadecimal
                # still no type
              style: simple

(Note that the motivation for adding the schema/type to the header is that linting tools complain about content/schema being required)

Hi @emcintyre-hpe could you share more details about your problem (e.g sample project), I tried to reproduce this bug, used exactly same annotations that you provided and  schema type appears.
parameters:       - name: accountId         in: path         required: true         schema:           type: string       responses:         "200":           description: List of services for the given account         "401":           description: User did not provide a valid auth token           headers:             testing-headers:               description: Flow/trace ID for traceability in the logs               style: simple               schema:                 type: string           content:             application/json:               schema:                 $ref: '#/components/schemas/ErrorMessage'


java.lang.VerifyError

This is my query:
val mydata = sqlContext.read
.format("com.databricks.spark.redshift")
.option("url", "jdbc:redshift://url")
.option("tempdir", "s3n://bucket/")
.option("query", "select * from table LIMIT 10")
.load()
.show()
Using the hadoop config for authenticaiton.
I get the following error:
16/05/26 16:38:48 ERROR Utils$: The S3 bucket bucket does not exist
16/05/26 16:38:48 INFO RedshiftRelation: UNLOAD ('QUERY') TO 's3://bucket/6dddc8c3-abb3-445b-9e9a-d75331ded4c9/' WITH CREDENTIALS 'aws_access_key_id=CRED;aws_secret_access_key=SECRET ESCAPE
[error] (run-main-0) java.lang.VerifyError: class com.fasterxml.jackson.module.scala.ser.ScalaIteratorSerializer overrides final method withResolved.(Lcom/fasterxml/jackson/databind/BeanProperty;Lcom/fasterxml/jackson/databind/jsontype/TypeSerializer;Lcom/fasterxml/jackson/databind/JsonSerializer;)Lcom/fasterxml/jackson/databind/ser/std/AsArraySerializerBase;
java.lang.VerifyError: class com.fasterxml.jackson.module.scala.ser.ScalaIteratorSerializer overrides final method withResolved.(Lcom/fasterxml/jackson/databind/BeanProperty;Lcom/fasterxml/jackson/databind/jsontype/TypeSerializer;Lcom/fasterxml/jackson/databind/JsonSerializer;)Lcom/fasterxml/jackson/databind/ser/std/AsArraySerializerBase;
I look through all the open issues, not sure which one this is related to.

This is probably a Jackson dependency conflict. I'd check whether your AWS SDK is using a version of Jackson which conflicts with Spark's own version.

Thanks, I'm checking on this now I'll get back to you if it isn't resolved.

That fixed it. Thank you! I see your helper in the docs about this issue now too.


"Istio is being downgraded" message during the upgrade to 1.9

Bug description
I try to install Istio 1.9.3 (same for 1.9.4) from 1.8.5 and I get ugly message:
Istio is being downgraded from 1.8.5 -> 1.9.3.This will install the Istio 1.9.3 default profile with ["Istio core" "Istiod" "Ingress gateways"] components into the cluster. Proceed? (y/N)
That's misleading, I'm trying to upgrade to higher version, not downgrade.
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Message should specify that it's upgrade procedure not downgrade.
Steps to reproduce the bug
istioctl install --set profile=default --set revision=v194
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
client version: 1.9.3
control plane version: 1.8.5
data plane version: 1.8.5

How was Istio installed?
istioctl
Environment where the bug was observed (cloud vendor, OS, etc)
Fedora34
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

@tylern91
Thanks for fixing that. If I understand it correctly it was just about a message, so it should be safe to go ahead and do the upgrade from 1.8 -> 1.9.4 (and ignore downgrade message)?

Thanks for fixing that. If I understand it correctly it was just about a message, so it should be safe to go ahead and do the upgrade from 1.8 -> 1.9.4 (and ignore downgrade message)?

@jdomag Yes, it's just a message so safe to upgrade.
Closed by https://github.com/istio/istio/pull/32876


Problems with the pci_regs.h and slab.h on L4t 23.2 (Nvidia Jetson TX1)

Hi,
When I compile the RIFFA driver on the target (JTX1) I have this make command error :

make: Warning: File `circ_queue.c' has modification time 9.9e+07 s in the future
Compiling driver for kernel: 3.10.67-g458d45c with the following values
NAME: 'riffa'
MAJNUM: '100'
VENDOR_ID0: '10EE'
VENDOR_ID1: '1172'
sed -i 's/#define MAJOR_NUM [^\n]/#define MAJOR_NUM 100/g' riffa_driver.h
sed -i 's/#define DEVICE_NAME [^\n]/#define DEVICE_NAME "riffa"/g' riffa_driver.h
sed -i 's/#define VENDOR_ID0 [^\n]/#define VENDOR_ID0 0x10EE/g' riffa_driver.h
sed -i 's/#define VENDOR_ID1 [^\n]/#define VENDOR_ID1 0x1172/g' riffa_driver.h
sed -i 's/#define DEBUG [^\n]/#define DBUG 1/g' riffa_driver.h
sed -i 's/#define DBUG [^\n]/#define DEBUG 1/g' riffa_driver.h
make -C /lib/modules/uname -r/build SUBDIRS=pwd modules
make[1]: Entering directory /usr/src/linux-headers-3.10.67-g458d45c' make[1]: Warning: File /usr/src/linux-headers-3.10.67-g458d45c/arch/arm64/Makefile' has modification time 1.1e+08 s in the future
make[2]: Warning: File scripts/Makefile.lib' has modification time 1.1e+08 s in the future   CC [M]  /home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.o /home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.c: In function ‘fpga_probe’: /home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.c:1200:76: error: ‘PCI_EXP_DEVCTL2_IDO_REQ_EN’ undeclared (first use in this function)   error = pcie_capability_write_dword(dev,PCI_EXP_DEVCTL2,(devctl2_result | PCI_EXP_DEVCTL2_IDO_REQ_EN | PCI_EXP_DEVCTL2_IDO_CMP_EN));                                                                             ^ /home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.c:1200:76: note: each undeclared identifier is reported only once for each function it appears in /home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.c:1200:105: error: ‘PCI_EXP_DEVCTL2_IDO_CMP_EN’ undeclared (first use in this function)   error = pcie_capability_write_dword(dev,PCI_EXP_DEVCTL2,(devctl2_result | PCI_EXP_DEVCTL2_IDO_REQ_EN | PCI_EXP_DEVCTL2_IDO_CMP_EN));                                                                                ^ /home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.c: In function ‘fpga_remove’: /home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.c:1445:61: error: ‘PCI_EXP_DEVCTL2_IDO_REQ_EN’ undeclared (first use in this function)   pcie_capability_write_dword(dev,PCI_EXP_DEVCTL2,result & ~(PCI_EXP_DEVCTL2_IDO_REQ_EN | PCI_EXP_DEVCTL2_IDO_CMP_EN));                                                              ^ /home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.c:1445:90: error: ‘PCI_EXP_DEVCTL2_IDO_CMP_EN’ undeclared (first use in this function)   pcie_capability_write_dword(dev,PCI_EXP_DEVCTL2,result & ~(PCI_EXP_DEVCTL2_IDO_REQ_EN | PCI_EXP_DEVCTL2_IDO_CMP_EN));                                                                                ^ make[2]: *** [/home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux/riffa_driver.o] Error 1 make[1]: *** [_module_/home/ubuntu/RIFFA_tmp/riffa_2.2.1/source/driver/linux] Error 2 make[1]: Leaving directory /usr/src/linux-headers-3.10.67-g458d45c'
make: *** [riffa.ko] Error 2

One solution to solve the #include <slab.h> problem should be to put the include in  circ_queue.h.
About the pci_regs.h #define, during the driver compilation the pci #define in #if LINUX_VERSION_CODE <= (KERNEL_VERSION(3,6,11)) statement are not defined although the L4T 23.2 kernel has the 3.10.67 version.
S. P
P.S: I'm using the 2.2.1 zip version available on the website  and my GCC version is the 4.8 for arm64 architecture (compilation on the target).

Would you be up for trying the fix I just committed in the RIFFA 2.2.2 branch
I think it it will cleanly fix the two issues you're seeing above for all L4T distributions.

Yes that works although I just tried with a quick program and the last L4T version (24.1 not 23.2).
As I had the same errors with the previous driver version on L4T 24.1, I think they didn't change anything about pci_reg.h.

Yep. I checked the 24.1 source before I made the modifications just hoping that this problem would fix itself.
Just to confirm, the driver now compiles out of the box without errors?

On Jul 1, 2016, at 10:00 AM, MrLent<EMAIL_ADDRESS>wrote:
Yes that works although I just tried with a quick program and the last L4T version (24.1 not 23.2).
As I had the same errors with the previous driver version on L4T 24.1, I think they didn't change anything about pci_reg.h.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/drichmond/riffa/issues/7#issuecomment-229997549, or mute the thread https://github.com/notifications/unsubscribe/AGFUdCtGhfNIzQSvGZ5IScRJhH6nUCevks5qRUfKgaJpZM4Ifdgh.

Yes, any modification to do.

Closing issue, will fix in RIFFA 2.2.2


Error While Trying to Load the Project - "Unknown solution item type"

I download from the most recent release. When I tried to open QuantConnect.Lean.sln, I ran into the error: "Error while trying to load the project '/users/.../mypath/Lean-<IP_ADDRESS>/VisualStudioPlugin/QuantConnect.VisualStudioPlugin.csproj': Unknown solution item type: {82b43b9b-a64c-4715-b499-d71e9ca2bd60}".
I am running Visual Studio community edition on MacOS Mojave 10.14.1
Not sure if there is something I am missing?

Not sure @tlkahn - we will test with VS Community and get back to you.

Hi Karen, I get a similar error but i can't find the XML with the line to change.
I've searched in the three files but no luck.
Can you please give me a hint?
Thanks in advance

I am getting the exact same error messages when trying to load VS and Lean
Any solution?
I am using MacOS High Sierra

Have you installed Python Tools? It is optional with Visual Studio I think
On Thu, Apr 11, 2019, 12:43 PM Ruchir Godura<EMAIL_ADDRESS>wrote:

I am getting the exact same error messages when trying to load VS and Lean
Any solution?
I am using MacOS High Sierra
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/QuantConnect/Lean/issues/2724#issuecomment-482277874,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACI6maK6xnTpvXwfyeUEx5CrcUxjx4nwks5vf5BogaJpZM4Y9zsz
.

Do you mean ptvsd?
Yes, I did install that with pip
However, I did see on the Visual Studio support page that python is not supported for Visual Studio on Mac. But the tutorial suggests that it should work.
https://docs.microsoft.com/en-us/visualstudio/python/overview-of-python-tools-for-visual-studio?view=vs-2019#questions-and-answers

@jaredbroad @yegodz  same errors here. is there a way to solve it?

@jaredbroad @yegodz I happened upon this early this morning as well and have been trying to track down where explicit sdk imports are happening in the solution but unfortunately haven't found any yet.
I peeked inside of the
.../VisualStudioPlugin/QuantConnect.VisualStudio17Plugin.csproj
file, and didn't see any so I greped for any using
Lean git:(master) ✗ grep -rnw ./ -e  'Sdk='
If anyone stumbles on how we're falling into this scenario I would love to understand how.

I have the exact same error as @supermodo and it seems that there is no fix yet?
The visual studio page linked in @yegodz's comment mentioned that Visual Studio Code is compatible with Python on Mac. Will it be possible to run Lean with Visual Studio Code, which I prefer over Visual Studio Community?
Finally, what is the impact of these errors? I tried Run --> Starting debugging and
cd Lean/Launcher/bin/Debug, mono QuantConnect.Lean.Launcher.exe
as shown in the Lean readme. It compiled with no error and outputs some statistics when run Launcher.exe. Does this mean I can still run my Python algorithm and back testing (haven't created any yet)?

@jaredbroad Since this seems to still be occurring for folks, is there any chance we could get this Issue re-opened just so people cruising by looking for help don't get confused?


Add Generic instances for Scientific.

Generic makes it much easier to derive things like an Aeson representation, or a Binary representation. Generics are now in GHC base, so provided we are using recent GHC we get them effectively for free.

Just spotted issue #24, which this would help with!

Hi Nicholas, right now the Scientific type is abstract. This is a good thing because it allows me to change the representation (which I'm planning to do in #26) without me having to worry about breaking user code.
Deriving a Generic instance makes Scientific non-abstract because you can now deconstruct and construct a Scientific using from and to. I would like to keep Scientific abstract unless somebody can convince me otherwise.
Also note that aeson already has ToJSON and FromJSON instances for Scientific.
With regards to #24 I think the best thing would be to add a manual Binary instance to scientific or binary.


boot.tmpOnTmpfs fails to mount

Describe the bug
I recently updated to the latest nixos-unstable channel and attempted to rebuild my system, and came across this message:
setting up tmpfiles
warning: the following units failed: tmp.mount

● tmp.mount - /tmp
     Loaded: loaded (/nix/store/d5ylr9h5n2wyzalsg7v5vgqd3dnzh6gy-unit-tmp.mount/tmp.mount; linked; vendor preset: enabled)
     Active: failed (Result: exit-code) since Tue 2021-01-12 23:03:11 JST; 17ms ago
      Where: /tmp
       What: tmpfs
         IP: 0B in, 0B out
        CPU: 777us

Jan 12 23:03:11 nixos systemd[1]: Mounting /tmp...
Jan 12 23:03:11 nixos mount[9780]: mount: /tmp: special device tmpfs does not exist.
Jan 12 23:03:11 nixos systemd[1]: tmp.mount: Mount process exited, code=exited, status=32/n/a
Jan 12 23:03:11 nixos systemd[1]: tmp.mount: Failed with result 'exit-code'.
Jan 12 23:03:11 nixos systemd[1]: Failed to mount /tmp.

To Reproduce
Steps to reproduce the behavior:

Set boot.tmpOnTmpfs to true
Run nixos-rebuild test

Expected behavior
The rebuild shouldn't fail, as was the case before I updated.
Additional context
I use XFS for my root partition, if that's relevant.
Notify maintainers

I had no idea what to put here.
Metadata
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.6, NixOS, 21.03pre262347.257cbbcd3ab (Okapi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.10`
 - channels(root): `"nixos-21.03pre262347.257cbbcd3ab"`
 - channels(plumeus): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixos modules affected by the problem
module:
boot.tmpOnTmpfs

See PRs #108860 and #108881

See PRs #108860 and #108881

TL;DR Until a proper fix, add this to your configuration.nix:
systemd.additionalUpstreamSystemUnits = "tmp.mount";

TL;DR Until a proper fix, add this to your configuration.nix:
systemd.additionalUpstreamSystemUnits = "tmp.mount";

Thanks very much for the info. I forgot to check PRs and probably wouldn't have figured out which one to look out for otherwise.
Just a minor correction regarding the systemd option, but seems like it should be:
systemd.additionalUpstreamSystemUnits = [ "tmp.mount" ];

I guess I'll close this issue and follow the PRs, thanks.

Thanks very much for the info. I forgot to check PRs and probably wouldn't have figured out which one to look out for otherwise.
Just a minor correction regarding the systemd option, but seems like it should be:
systemd.additionalUpstreamSystemUnits = [ "tmp.mount" ];

I guess I'll close this issue and follow the PRs, thanks.

This issue still exist and can potentially break one's system

This issue still exist and can potentially break one's system

might want to pin this as well because of its severity

might want to pin this as well because of its severity

Should have been fixed by #108860 AIUI.

Should have been fixed by #108860 AIUI.


Does not integrate with meteor build system

Description
While doing the getting started integration with Meteor,I got the following  error:

Error trace
=> Errors prevented startup:

   While minifying app stylesheet:
   app/styled-system/chunks/imports__ui__App.css: While loading postcss config:
   Loading PostCSS Plugin failed: Unexpected token '||='

   (@/Users/grubba/Desktop/work/meteor/tests/panda/postcss.config.cjs)

I was expecting to be displayed a H1 with red bg:
import React from "react";
import { css } from "/styled-system/css";
export const App = () => (

Welcome to Meteor!

);

Link to Reproduction
https://github.com/Grubba27/panda
Steps to reproduce

Make sure to have Meteor CLI installed
Create a new app with meteor create app --typescript
Follow getting started from docs
run your meteor app
See error

or, you can:

Git Clone this repo
Having Meteor installed in your machine
Run meteor npm start
See error in console while building

JS Framework
MeteorJS
Panda CSS Version
0.4.0
Browser
Chromium Engine Version 114.0.5735.133 (Arc 0.108.1)
Operating System

[X] macOS
[ ] Windows
[ ] Linux

Additional Information
I would ask where I could start to look to help solve this issue. But I'm unsure where to start. This issue can be related to how the meteor build system work as well.

hey, it seems to be a module resolution with Meteor
I could fix it locally by adding this to the panda.config.ts:
outExtension: "js"

so that the files in the styled-system folder will have .js extension instead of .mjs

I think I did something wrong 😢
my config as it follows:
{
  outExtension: "js",
  preflight: true,
  include: ['./imports/ui/**/*.{ts,tsx,js,jsx}', './client/**/*.{ts,tsx,js,jsx}', ],
  exclude: [],
  outdir: 'styled-system'
}

but now I'm getting the error like this:

Trace

While minifying app stylesheet:
   app/styled-system/chunks/imports__ui__App.css: While loading postcss config:
   Unexpected token '||='

   While minifying app stylesheet:
   app/styled-system/chunks/imports__ui__App.css: While loading postcss config: While
   loading postcss config: Unexpected token '||='

@astahmer, it works, but the styles do not apply. Any clue what might be happening?
https://github.com/henriquealbert/meteor-with-panda-css

@henriquealbert I don't see an import to the styles built with the CLI in your repo :
import "/styled-system/styles.css";

@Grubba27 what node version you're using? I got this same error today and fixed by upgrading above v15.
The Logical OR assignment ||= is available from node 15 onwards: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_OR_assignment

Hey! Meteor, by default in the newest version, uses a node v14(we are working to be compatible with newer versions). This might be the reason why it does not work with it today.